[0.8] IE11 displays and then hides Custom Elements

Chrome displays the text correctly: 'Hello World, I am a Custom Element!',
but IE11 displays 'This is local DOM' very briefly and then removes it and displays nothing. Is this a bug?

    <link rel="import" href="polymer/polymer.html" />

    <x-custom></x-custom>
    <dom-module id="x-custom">
        <template>

This is local DOM

        </template>
    </dom-module>

When defining an element in the main document on a browser that doesn't support HTMLImports natively, you need to wait for the HTMLImportsLoaded event to call Polymer. For example,


Add contextual dropdown menu to Application List items

Mockup: https://mesosphere.invisionapp.com/share/Q255TQOTK#/screens/119875789
When the user clicks on the contextual menu toggle (e.g the three dots: "...") a dropdown offering the possible commands is shown:

Scale
Restart
Suspend
Reset Delay (optional; only if the app is delayed)

Please note the Destroy command is deliberately left out.
When one of the actions is clicked, the associated modal with confirmation/prompt is shown just like in the Application Detail view.
@leemunroe could you please attach the three dots icon to this issue?

Hey @leemunroe !
Happy new year. :)
Could I find the three-dots-icon somewhere or could you add it?
Thank you.

Got the icon. @orlandohohmeier gave me a hint.


Move external endian library into HPX

This fixes #1480: Move external/boost/endian into hpx/util

LGTM


Suggestions to improve aviation recipe

In https://confluentinc.github.io/ksqldb-recipes/real-time-analytics/aviation/, the formatting of many queries seems to be off?
I think we also don't need CUSTOMER_BOOKINGS but can merge it with CUSTOMER_FLIGHTS and do both joins at once.

I missed that the joins are FK-joins, not PK-joins. Addressing it is blocked on https://github.com/confluentinc/ksql/issues/8486

@mjsax the formatting does look off on this one. @rmoff can you take a look? As part of it, is there a reason the lines start with the commas?


freecad: 0.18.2 -> 0.18.3

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/freecad/versions.
meta.description for freecad is: '"General purpose Open Source 3D CAD/MCAD/CAx/CAE/PLM modeler"'.
meta.homepage for freecad is: '"https://www.freecadweb.org/"
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 0.18.3 with grep in /nix/store/am1bnwbacahrdfc5j6lzvkrciy5b3hhz-freecad-0.18.3
directory tree listing: https://gist.github.com/fc70c80c5b87ca6a4b6f40ab9ff29014
du listing: https://gist.github.com/23603d6faf68e8ea35d7532fbb51cc5f

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
freecad

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/am1bnwbacahrdfc5j6lzvkrciy5b3hhz-freecad-0.18.3 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A freecad https://github.com/r-ryantm/nixpkgs/archive/9b9434f507631d919f1e1cbfc4a33e74f64ffd09.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/am1bnwbacahrdfc5j6lzvkrciy5b3hhz-freecad-0.18.3
ls -la /nix/store/am1bnwbacahrdfc5j6lzvkrciy5b3hhz-freecad-0.18.3/bin

cc @viric for testing.

Builds fine for me on non-nixos linux x86_64... I can't get the non-cli version to launch properly, only giving me
FreeCAD 0.18, Libs: 0.18RUnknown
© Juergen Riegel, Werner Mayer, Yorik van Havre 2001-2019
  #####                 ####  ###   ####
  #                    #      # #   #   #
  #     ##  #### ####  #     #   #  #   #
  ####  # # #  # #  #  #     #####  #   #
  #     #   #### ####  #    #     # #   #
  #     #   #    #     #    #     # #   #  ##  ##  ##
  #     #   #### ####   ### #     # ####   ##  ##  ##

Fontconfig warning: "/etc/fonts/fonts.conf", line 160: blank doesn't take any effect anymore. please remove it from your fonts.conf
Aborted

But then again, I get exactly the same thing for 0.18.2.

@risicle can you run it through a debugger and generate a stack trace ?

Oh, I think you should disregard me - come to think of it this just looks like the normal issues around opengl for non-nixos users...


Fixes #6518 - No way to select all images from folder in Media Library

Fixes #6518 - New button to select all images in media library folder.
Supersedes PR #6519 to target 1.10.x

Hi @MobesE46, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

GTG once someone has confirmed it works and doesn't break existing features.

Here's the new button:

After clicking button:

What I see from the code is that Select will actually close the window and select items, while Select All will just highlight the items. Is that intentional? It would mean to actually select all items you need to click Select All, then Select. So maybe this button should actually be in the toolbar, so that there is no confusion with the Select action of the picker.

Ok, I moved the button to the Toolbar

Confirmed as working, but I'll push some changes/improvements.


CH10 code to set TensorFlow level is broken now that there are 2 digits second level of current TensorFlow

First, great book and great examples. Your examples of training in a Vertex AI pipeline are gold. However, there is a problem with this code to set the image names in https://github.com/GoogleCloudPlatform/data-science-on-gcp/blob/edition2/10_mlops/train_on_vertexai.py
    tf_version = '2-' + tf.__version__[2:3]
    train_image = "us-docker.pkg.dev/vertex-ai/training/tf-gpu.{}:latest".format(tf_version)
    deploy_image = "us-docker.pkg.dev/vertex-ai/prediction/tf2-cpu.{}:latest".format(tf_version)

Now that current TensorFlow has two digits in the second level (e.g. "2.12.0"), this code gets the current TF version and chops off the second digit of the second level, so "2.12.0" becomes "2.1", so you get an ancient TF level in the container.

Thanks!  This should fix it:
tf_version = '2-' + tf_version_string.split('.')[1]

Could you try, and file a pull-request?

Thanks very much for getting back so quickly. Unfortunately, this change won't work in cases where the TensorFlow level of the system where you are running the pipeline script is higher than what's available in pre-built images (https://cloud.google.com/vertex-ai/docs/training/pre-built-containers for training and https://cloud.google.com/vertex-ai/docs/predictions/pre-built-containers for prediction).
I am running the pipeline script from Cloud Shell which has TensorFlow 2.12.0, which means that when I update my pipeline script to use your recommended fix, as follows:
tf_version_string = tf.__version__
print("tf.__version__ is: ",tf.__version__)
tf_version = '2-' + tf_version_string.split('.')[1]
train_image = "us-docker.pkg.dev/vertex-ai/training/tf-gpu.{}:latest".format(tf_version)
deploy_image = "us-docker.pkg.dev/vertex-ai/prediction/tf2-cpu.{}:latest".format(tf_version)
print("train_image is: ",train_image)
print("deploy_image: ",deploy_image)

I get the following output:
tf.__version__ is:  2.12.0
train_image is:  us-docker.pkg.dev/vertex-ai/training/tf-gpu.2-12:latest
deploy_image:  us-docker.pkg.dev/vertex-ai/prediction/tf2-cpu.2-12:latest

And because pre-built images aren't currently available beyond TF 2.11, my pipeline script fails with the following message:
details = "The image 'us-docker.pkg.dev/vertex-ai/training/tf-gpu.2-12:latest' is not supported. Please use an image offered by Vertex AI for python package training."

So, while the fix you recommended should work in general, it won't work for my particular use case (where the TF level where I am running the pipeline script is a bit ahead of the TF level where I will run the model). Thanks again for recommending the fix, and thanks especially for your excellent book.


refactor: move ethereum and op builder into separate crates

The motivation for this is to reduce the number of in code cfg optimism and have standalone components for different networks instead.
extracts the OP code from the basic-payload-builder and add
ethereum-payload-builder
optimimism-payload-builder
so we need less cfg optimism.
this needs a few cleanup task afterwards but should be fine for now.
Note that crates still have an optimism feature to make it easier to handle mutually exclusive payload builder crates, because clippy doesn't respect the exclude members setting from Cargo.toml
This is still a bit horrible, but at least separates the implementations.
~~blocked by #5869 ~~

LGTM as an initial split. Feel free to ticket out any further cleanups you have in mind to @refcell and I!

sweet will do, this is prep for moving off op features, (soonish), feature by feature


chore: Move language switcher types due to dts-generator

There seems to be an issue with the dts generator package finding typings in a deep folder structure. I tried to get it working and then found a few issues in their github repo that could be related
https://github.com/SitePen/dts-generator/issues/60
So for now moving it out of the sub folder so it gets picked up by the typings generation script.

Thanks!


Hosting all variants on my site as tarballs

Feel free to link to my site in the README or wherever you want.
https://equwal.com/alt-hacks.html
I'm hosting some opinionated variants there. Of course, I can't host all variants there, but if anyone asks I'll generate a variant and add it.

Actually, I can host all variants; I'm not sure why I thought I couldn't.
Soon I hope to have them all up.

Actually, I can host all variants; I'm not sure why I thought I couldn't.
Soon I hope to have them all up.

Okay, my cheap hack has mapped the solution space!
https://equwal.com/alt-hacks.html
Just some final minor edits (like flattening the directory tree in the tarballs) and I'll make a pull.

Okay, my cheap hack has mapped the solution space!
https://equwal.com/alt-hacks.html
Just some final minor edits (like flattening the directory tree in the tarballs) and I'll make a pull.


GDT 290 - Queue and Dedupe EventBridge Events for Incremental MIT Harvests

Purpose and background context
Formerly, for an MIT incremental harvest, as SQS messages were consumed and Records processed, EventBridge events were published immediately that would trigger another StepFunction to copy and/or delete zip files in the S3 CDN bucket.
This did not correctly handle an edge case where a deleted event could remove a file before a later, more recent created event may expect that file to be in S3 for processing.
Example

Zip file ABC123.zip uploaded to "upload" S3 bucket

This creates the first SQS message for ABC123.zip --> created

Zip file ABC123.zip deleted from "upload" S3 bucket

This creates a second SQS message for ABC123.zip --> deleted

Zip file ABC123.zip re-uploaded to "upload" S3 bucket

This creates a third SQS message for ABC123.zip --> created

At this point, 3 SQS messages exist all referencing changes to the same zip file ABC123.zip that is now located in S3:CDN:Restricted.  There is nothing inherently wrong with this: this just means the file was modified multiple times before an incremental harvest cleared the queue.
However, when the incremental MIT Harvest does finally run, the following would happen:

first SQS message of created is processed

harvester sends EB event that record is "Restricted"
ABC123.zip remains in S3:CDN:Restricted bucket

second SQS message of deleted is processed

harvester sends EB event that record is "Deleted"
related StepFunction deletes ABC123.zip from S3:CDN:Restricted bucket (and Public if it exists there)

third SQS message of created is processed

harvester throws error because file does not exist in S3 anymore; this is the error

In this scenario, ideally the harvester would process all the actions to the record, but only send a SINGLE EventBridge event at the end of ABC123 == Restricted, thereby keeping the file in S3, as this was the last and most up-to-date event for that zip file.
This is accomplished in the code change by queuing all EB events that would get sent, then de-duping them by Record identifier, and only sending an event that reflects the most recent change.
How can a reviewer manually see the effects of these changes?
Without an integration test, it's fairly manual.
1- Ensure the SQS queue is empty for incremental harvest.  In Dev1 -- communicating with others -- this can safely be purged.
2- Download this test fixture zip file.  Then perform the following in the Dev1 upload bucket:

upload the zip file
delete the zip file
upload the zip file (again)

3- Confirm the SQS queue has three messages in the queue:

4- Set env vars and run an incremental MIT harvest:
WORKSPACE=dev
SENTRY_DSN=None
S3_RESTRICTED_CDN_ROOT=s3://cdn-origin-dev-222053980223/cdn/geo/restricted/
S3_PUBLIC_CDN_ROOT=s3://cdn-origin-dev-222053980223/cdn/geo/public/
GEOHARVESTER_SQS_TOPIC_NAME=geo-harvester-input-dev.fifo

pipenv run harvester --verbose \
harvest -t incremental \
-o output/mit_incremental.jsonl \
mit

5- Confirm the following

in the logged output sending EventBridge event shows only once
confirm the zip file stil exists in S3:CDN:Restricted bucket

Includes new or updated dependencies?
NO
Changes expectations for external applications?
YES
What are the relevant tickets?

https://mitlibraries.atlassian.net/browse/GDT-290

Developer

[ ] All new ENV is documented in README
[ ] All new ENV has been added to staging and production environments
[ ] All related Jira tickets are linked in commit message(s)
[ ] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

[ ] The commit message is clear and follows our guidelines (not just this PR message)
[ ] There are appropriate tests covering any new functionality
[ ] The provided documentation is sufficient for understanding any new functionality introduced
[ ] Any manual tests have been performed and verified
[ ] New dependencies are appropriate or there were no changes

Thank you for the detailed explanation of the updates and review method! Approved. 🎉


fix(twitter): X support for Twitter

🔧 What does this fix? 🔧
Adds support for x.com
🗒 Checklist 🗒

[x] I have read and followed Catppuccin's contributing guidelines.
[x] I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

superseded by https://github.com/catppuccin/userstyles/pull/895


Odd mappings of log levels happening on Android

Hi there! We're working on integrating this flutter plugin into our codebase and noticing an oddity around Android's log levels once logs land in the datadog backend.
In short, all of our info logs are being mapped to debug. I first confirmed that we are definitely logging them as info to the public log function of the dart API, and then isolated the problematic mapping to these lines in the Android side of the plugin. It looks like debug is being mapped to verbose, info is being mapped to debug, and notice is being mapped to info.
Additionally, on the dart side within datadog_logger, passing Level.INFO would interestingly get mapped to notice based on its value, so we were downgrading our Level.INFO priorities to Level.CONFIG to fall into the info bucket, but now we realize this won't work because info is being mapped to debug on the Android side.
We confirmed that everything works as expected on iOS, assuming we do the downgrading to Level.CONFIG mentioned above. Here's where iOS correctly maps the value sent by dart to the native SDK methods.
So we are hoping to bring clarity to two things:

Hopefully clean up the mapping on the dart side within the _levelAsStatus function to correctly map Level.INFO to info
Fix the mapping on the Android side of the plugin

This should bring both platforms to parity, though this may be a breaking change if anybody has done the same type of downgrading we were planning on doing in their implementations.
We'd be happy to open a PR up for this, but wanted to ensure this was indeed a bug prior to doing so.

Hey @btrautmann there's no explicit decision for the mappings short of "I thought this was the most accurate." Based on the reactions to your issue, it sounds like this is a problem for others. I'd really appreciate a PR to correct the mappings to what it should be.

@btrautmann thank you again for your work here and your unit testing. It's really helpful to me.
Your changes have been released as part of 2.0.0-beta.1


StacklessClosedChannelException happend after redis instance switching.

Redis version
5.0.14
Redisson version
3.32.0
Redisson configuration
Everything is set to default, except for using single server configuration and setting the DNS monitoring interval to 2000.

What is the Expected behavior?
There is a Redis instance switching operation in our application, and an unexpected error occurred. Here is what happened：

Start the application and subscribe to topic A.
Update the DNS record: change the original Redis host from IP_C to IP_D.
Wait for Redisson to detect the DNS change and establish new connections.
Subscribe to topic B.
In my opinion, Redisson should correctly subscribe to both topic A and topic B in the new Redis instance, or at least successfully subscribe to topic B. Is that right? If not, please correct me.

What is the Actual behavior?

Start the application and subscribe to topic A.
Update the DNS record: change the original Redis host from IP_C to IP_D.
Wait for Redisson to detect the DNS change and establish new connections,  as indicated in the logs..

Subscribe to topic B.
An error occurred: io.netty.channel.StacklessClosedChannelException

Additional information
Actually, we use version 3.28. We tested versions 3.29, 3.30, 3.31, and 3.32, but they all failed.
It seems like Redisson is holding onto a bad connection without releasing it.

It looks like the bug was introduced in the version 3.27.0. I've rolled back to 3.26.1 and it's working fine again, but all newer versions are still broken (including 3.39.0).

Hi @mrniko,
I created a quick test to reproduce with 3.40.0
It gets a topic and then in a loop, adds a listener, does publish, and then removes the listener.
I change the IP of redis by deleting and re-creating the redis services.
After recreating the service, Redisson notices the DNS change and reconnects, pub/sub continues to work but then
the test fails
org.redisson.client.RedisTimeoutException: Remove listeners operation timeout: (7500ms) for Topic1 topic
at org.redisson.pubsub.PublishSubscribeService.lambda$removeAllListenersAsync$56(PublishSubscribeService.java:1010)
at io.netty.util.HashedWheelTimer$HashedWheelTimeout.run(HashedWheelTimer.java:713)
at io.netty.util.concurrent.ImmediateExecutor.execute(ImmediateExecutor.java:34)
at io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:701)
at io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:788)
at io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:501)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:857)
SEVERE: Test failed
org.redisson.client.RedisTimeoutException: Unable to acquire subscription lock after 7500ms. Try to increase 'subscriptionTimeout', 'subscriptionsPerConnection', 'subscriptionConnectionPoolSize' parameters.
at org.redisson.pubsub.PublishSubscribeService.lambda$subscribe$18(PublishSubscribeService.java:414)
at io.netty.util.HashedWheelTimer$HashedWheelTimeout.run(HashedWheelTimer.java:713)
at io.netty.util.concurrent.ImmediateExecutor.execute(ImmediateExecutor.java:34)
at io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:701)
at io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:788)
at io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:501)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:857)
I collected traces:
trace.log

@avcad
Unable to reproduce it with the code below. You can find SimpleDnsServer here
    @Test
    public void testAddListenerFailover() throws Exception {
        GenericContainer<?> redis = createRedis();
        redis.start();

        SimpleDnsServer s = new SimpleDnsServer();

        Config config = new Config();
        config.setProtocol(protocol);
        config.setAddressResolverGroupFactory(new SequentialDnsAddressResolverFactory() {
            @Override
            public AddressResolverGroup<InetSocketAddress> create(Class<? extends DatagramChannel> channelType, Class<? extends SocketChannel> socketChannelType, DnsServerAddressStreamProvider nameServerProvider) {
                return super.create(channelType, socketChannelType, hostname ->
                                            DnsServerAddresses.singleton(SocketUtils.socketAddress("<IP_ADDRESS>", 55)).stream());
            }
        });
        config.useSingleServer()
                .setAddress("redis://simplehost:" + redis.getFirstMappedPort());
        RedissonClient redisson = Redisson.create(config);

        RTopic topic = redisson.getTopic("topic");

        Logger logger = LoggerFactory.getLogger("out");

        for (int i = 0; i < 100; i++) {

            if (i == 3) {
                s.updateIP("<IP_ADDRESS>");
            }

            for (int j = 0; j < 60; j++) {
                topic.publish("test" + j);
                Thread.sleep(100);
            }
            topic.removeAllListeners();

            logger.info("step1 " + i);
        }

        redisson.shutdown();
        redis.stop();
    }

Hi @avcad
I managed to reproduce the issue. Thanks for the test code.


Add magic viewport to all templates and documentation.

This improves performance on Chrome in mobile devices, by enabling
GPU rasterization.
@surma or @Garbee PTAL!

How did we forget about that o_O
LGTM :)

IKR? Sheesh. Thanks for the review! :)


Account details seemingly not updated properly if github account name and/or email changed while access token is invalid

I revoked CodeTriage's access to github years ago after getting fed up of being nagged for not working on things every week. Eventually I got fed up of being nagged about CodeTriage not having access so I re-authorised. Then when it started nagging me about not doing enough coding again I remembered why I'd revoked it so I deleted my account
However, I'm still getting emails about my access token having been revoked. I notice though that they use my old Github username (changed about 3 years ago), and my old github email address.
I assume then, that somehow CodeTriage has created a new account or something when I reauthorised due to the changed username, instead of updating the existing details, such that while the new account has been deleted, the old one has not been.
Expected Behavior

When I delete my account I should not still receive daily emails about either my access token being invalid, or about not working on any issues
When re-authorising after changing account details in Github, account details in CodeTriage should be updated

Current Behavior

Seems like if an account's access token is revoked, if github account details have changed they are not correctly updated when access is re-granted
Neverending emails. Oh good gods so many emails. MAKE THEM STOP!!! 😭

Possible Solution

Steps to Reproduce (for bugs)

Revoke CodeTriage's access from Github
Change Github username and/or primary email address (maybe need to remove the email address that CodeTriage uses?)
Re-authorise CodeTriage
Continue to receive emails to old name at old email address about access token having been revoked

Context

I just want to stop being nagged daily (without simply forwarding everything from CodeTriage to /dev/null in case I use it again in future), for the love of all that's good in this world!
Your Environment

Version used: N/A
Browser Name and version: N/A
Operating System and version (desktop or mobile): N/A
Link to your project: N/A

I just want to stop being nagged daily

If you don't click on the links, then emails auto-throttle to once a month: https://github.com/codetriage/CodeTriage/blob/1684bf854b4326ff7b0e5e69a640240b32cde110/app/models/email_rate_limit.rb#L35
Ahh, you're talking about the token warning. That's a special case.
Unfortunately I can't delete what I can't find. I don't have either your old username or email in this thread.
Using your info from your public github profile I definitely don't see your current info:
~ $ rails c
[Scout] [02/07/23 21:42:05 +0000 run.5735 (7)] INFO : Scout Agent [5.3.1] Initialized
[Scout] [02/07/23 21:42:05 +0000 run.5735 (7)] INFO : Not Loading Instruments
[Scout] [02/07/23 21:42:05 +0000 run.5735 (7)] INFO : Scout Agent [5.3.1] Installed
[Scout] [02/07/23 21:42:05 +0000 run.5735 (7)] INFO : Monitoring isn't enabled for the [production] environment.
[Scout] [02/07/23 21:42:05 +0000 run.5735 (7)] INFO : Agent attempting to load in interactive mode.
[Scout] [02/07/23 21:42:05 +0000 run.5735 (7)] INFO : Deferring agent start. Standing by for first request
W, [2023-02-07T21:42:05.613188 #7]  WARN -- Skylight: Activating Skylight for Background Jobs because SKYLIGHT_ENABLE_SIDEKIQ is set
I, [2023-02-07T21:42:05.840826 #7]  INFO -- : [SKYLIGHT] [5.3.4] Skylight agent enabled
I, [2023-02-07T21:42:05.843590 #7]  INFO -- : [RailsAutoscale] Preparing request middleware
I, [2023-02-07T21:42:05.921365 #7]  INFO -- : Raven 2.13.0 ready to catch errors
I, [2023-02-07T21:42:07.015878 #7]  INFO -- : [RailsAutoscale] Reporter not started: no metrics need to be collected on this dyno
D, [2023-02-07T21:42:07.115923 #7] DEBUG -- :   ActiveRecord::SchemaMigration Pluck (1.3ms)  SELECT "schema_migrations"."version" FROM "schema_migrations" ORDER BY "schema_migrations"."version" ASC
I, [2023-02-07T21:42:07.116231 #7]  INFO -- : Using schema cache file /app/db/schema_cache.yml
Loading production environment (Rails 7.0.4)
irb(main):001:0> User.where(github: "Tabby").first
D, [2023-02-07T21:42:18.624272 #7] DEBUG -- :   User Load (2.1ms)  SELECT "users".* FROM "users" WHERE "users"."github" = $1 ORDER BY "users"."id" ASC LIMIT $2  [["github", "Tabby"], ["LIMIT", 1]]
=> nil
irb(main):002:0> User.where(github: "tabby").first
D, [2023-02-07T21:42:22.637492 #7] DEBUG -- :   User Load (1.6ms)  SELECT "users".* FROM "users" WHERE "users"."github" = $1 ORDER BY "users"."id" ASC LIMIT $2  [["github", "tabby"], ["LIMIT", 1]]
=> nil
irb(main):003:0> User.where(email: "t<redacted>y@b<redacted>n.online").first
D, [2023-02-07T21:42:40.034092 #7] DEBUG -- :   User Load (2.0ms)  SELECT "users".* FROM "users" WHERE "users"."email" = $1 ORDER BY "users"."id" ASC LIMIT $2  [["email"<EMAIL_ADDRESS>["LIMIT", 1]]
=> nil

That's also probably why you can't log in. Did you change your name and/or email on GitHub? If so you can see how we find you here: https://github.com/codetriage/CodeTriage/blob/1684bf854b4326ff7b0e5e69a640240b32cde110/app/services/git_hub_authenticator.rb#L27-L29

I notice though that they use my old Github username (changed about 3 years ago)

Gotcha.
Update one of those on your github profile to the username or email (they should be in the codetriage emails). Once you do that you can log back in to CodeTriage and delete your account. Account deletions are hard deletes of all associated user data.

Yeah, I did change my username on Github. I think I changed my email at the same time actually, on reflection. Which is an awkward thing to do, I'll grant you, but it's rare to find a service where you can't unsubscribe from emails without logging in first.
I figured it was likely that one of those was used to find a profile assuming it wouldn't change, and that the fix would ideally be to use the Github account ID (retrievable from the API using a username) rather than using the username itself


Makes random number generator class picklable

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#1863
What are the significant changes in functionality due to this change request?
Crow RNG engines are now picklable. This was accomplished by adding a wrapper class for the crow RandomClass RNG class.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Pretest failed:

You can use script raven/developer_tools/delete_trailing_whitespace.sh yourFile to delete the white space.

Thanks for the feedback @dylanjm and @wangcj05. The requested changes have been made.


Overhaul current tests and run integration tests on main on or demand

As part of #13, we also have to separate the different types of tests that we have and integrate them on the CI/CD only for already merged PRs or on-demand (to avoid hitting the server too much and have more accurate reports). Some of the current tests are considered integration tests and should be moved even if they don't hit any thirdparty service.
This should be performed before the first release to prevent any release of the tool that is not working for whatever reason.
Important: maybe running the integration tests is perfectly fine on PR level if the APIs are not hitted by using a build flag and only tigger them on demand (maybe on the release pipeline).

Current tests are overhaul on the full rewrite (considering mock-server request as integration-tests is out of the scope at the moment, cause we are using stubs). Also, the previously named integration tests will be renamed to contract-tests and the ticket to manage them is #123. Closing in favor of it.


Matthew/f2b-7 implement faqs

[F2B-7]  API functionality for FAQ, Appropiate Changes in MongoDB
Steps to Test

Can request endpoints in Postman after logging in to get correct authorization and see functionality as well as the changes in MongoDB

Screenshots

great job!!


async_await_js_transform_test needs update to match changes in CL<PHONE_NUMBER>

CL<PHONE_NUMBER> changed some invocations from getting 4 arguments to 3 arguments in the transformation of code that implements async/await.
This breaks tests/compiler/dart2js/async_await_js_transform_test.dart, cf.
https://chromegw.corp.google.com/i/client.dart/builders/dart2js-linux-jsshell-3-4-be/builds/2531/steps/dart2js unit tests/logs/stdio vs.
https://chromegw.corp.google.com/i/client.dart/builders/dart2js-linux-jsshell-3-4-be/builds/2532/steps/dart2js unit tests/logs/stdio
because that test still expects 4 arguments.

https://codereview.chromium.org/2335583003/


Add support for running list of tests in manifest

Adding "test_list": ["test1", "test2"] to the keys in the manifest
declares a list of STF test targets.
Running p4app test myapp.p4app will run all of the tests in the list, and
report a summary at the end, in the form:
TEST SUMMARY
test1: PASS
test2: FAIL

@bstpierre can you edit the README, documenting how this new manifest option should be used?


UG Screenshot Cleanup Pass

Mostly fixed by #286, missing the GUI annotations in the beginning.

Closed by #293


{AKS} Update history to add a table of releases and adopted API versions

This checklist is used to make sure that common guidelines for a pull request are followed.
{AKS} Update history to add a table of releases and adopted API versions.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

AKS


feat: auto-detect service context

When running on GCP environments, automatically detect service context
so that error reporting can correctly pick up errors.
Fixes: https://github.com/googleapis/nodejs-logging-bunyan/issues/135

@DominicKramer PTAL.


Incorrect position check in IsUTf8?

It looks like a lot of the UTF8 checker code on GitHub is all copied with what appears to be the same issue: if the utf8 multi-byte sequence is at the end of the buffer, it's incorrectly marked as invalid. AFAICT, all of the checks for position >= length -2 (or whatever) should be position > length-2.

Thanks!, i've opted to remove it since it was unused


[Windows] Add a sub window to Flutter Window, content can't display.

Steps to reproduce

in runner/flutter_window.cpp OnCreate method,add a button window to the flutter native window. code sample below:
subHwnd = CreateWindow(
TEXT("Button"),
TEXT("anniu"),
WS_CHILD | WS_VISIBLE | BS_PUSHBUTTON | BS_DEFPUSHBUTTON,
10, 10,
120, 80,
//this->GetHandle(),
flutter_controller_->view()->GetNativeWindow(),
(HMENU)1001,
::GetModuleHandle(0),
NULL);

SetWindowPos(subHwnd, HWND_TOPMOST,10,10,120,80, SWP_SHOWWINDOW);
2.run app, the button can't display， but when click the button's frame area（10,10,120,80）, the button appear.  Click on a control in flutter that you can interact with, and the button disappears again.
https://github.com/flutter/flutter/assets/19525360/588f59ef-ede8-4f73-af03-bc0b712dabf1
Expected results
sub window can display
Actual results
sub window can't display
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

My company‘s’ business requires a webview embedded in the main window. I tried to add a webview to the window of the platform, exchange data through channel, and control the display through hidden/show. This was successful on macos, but webview content was not displayed on windows.
I wrote a simple demo verification, added a button, and moved flutterview to the right a little, the button was displayed on the window, but the part covered by flutterview could not be displayed, what is the reason? Is there a way to change it?

Rendering composition on Windows in inherently complex; see https://learn.microsoft.com/en-us/dotnet/desktop/wpf/advanced/technology-regions-overview. If you are doing your own application-level composition, it's up to you to do so in a way that works within the constraints of the operating system.
Closing as this is an application-level issue, rather than a Flutter-level issue. This would be a question for a more general resource like Stack Overflow.


gfill is NoneType

I got the error:
File "./readme2tex/render.py", line 180, in render
    gfill.set('fill-opacity', '0.9')
AttributeError: 'NoneType' object has no attribute 'set'

For whatever reason my environment's rendertex() was returning svgs with "http" instead of "https". A quick fix was to change the gfill and use variables in render.py to find the correct string.
gfill = xml.find('{http://www.w3.org/2000/svg}g')
gfill.set('fill-opacity', '0.9')
if not block:
    uses = gfill.findall('{http://www.w3.org/2000/svg}use')

If someone knows why my environment did that please let me know. It might also be nice to add some kind of check in the code to prevent the end user from having to alter this.

I had the same issue and don't know why.
But this quick fix worked great.


Lineage still exists for a deleted Data Factory

[Enter feedback here]
I completely deleted a Data Factory, refreshed everything, re-scanned all the registered Data Sources and I still see a Deleted Factory, complete with all of its lineage shows up in assets.
Does a manual deletion in Purview need to take place if a Data Factory is deleted? Are there instructions to do this?
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 26ad94bd-e2ad-01b9-93cd-05ed3c2408ff
Version Independent ID: 840bb7b0-2944-e538-25c0-26c48a7b3992
Content: Push Data Factory lineage data to Azure Purview - Azure Data Factory
Content Source: articles/data-factory/turorial-push-lineage-to-purview.md
Service: data-factory
GitHub Login: @lrtoyou1223
Microsoft Alias: lle

@v-jheichman Thanks for the question. We're investigating this and will get back to you shortly.

@v-jheichman  Since this issue is not related directly to the doc, I would recommend you to create a thread on the forums - Microsoft Q&A or Stack Overflow
Once you post your issue on forums, it will have visibility across the community which is a better suited audience for such types of issues.


don't substract player count by allowed privateClients number

don't substract player count by allowed privateClients number
A private client is a kind of slot only available to someone having the password,
allowed to ensure this one can join even if the server is full.

this is a real kind of players so there is no reason to substract the number
of private client to player count.
It makes no sense to substract all the time, even when no one private client
is connected…

Fix Unvanquished/Unvanquished#1028
do not disclose private slot number except for those taken
returns to client sv_maxclients as sv_maxclients - sv_privateClients
except if client count + bot count is greater (which means some private
slots are taken) so returns client count + bot count in this case instead.
i.e. hide private slot number when possible, but never returns a sv_maxclient
count that is smaller than the advertised client number.

Note that I haven't compiled neither tested the code, but it looks very obvious isn't it?

I just tested the code and it displays as expected.

@Kangz can I have your thought now that I also modified the way the server returns maxclients (including private slots connected)?

I think the goal should be to accurately display the number of empty slots (accessible without a password), since that's what most people care about.

the current code will show the server as full if there is 1 private client connected and the server has 1 empty slot left, which is not good

Which is expected because private slot is to allow people with password to override the limit, not to give anyone the ability to override the limit as soon as there is one private guy on server.
These two scenarii are wrong:

bouncer: do you have an invitation card?
stuffed guy: no but this guy who is already in have one for himself
bouncer: ok, come in

Or

bouncer: do you have an invitation card?
stuffed guy: no, but the owner is already in
bouncer: ok, come in

It's wrong…
@DolceTriade please read these two comments there:
https://github.com/Unvanquished/Unvanquished/issues/1028#issuecomment-335846473

Keep in mind that the private clients are subtracted from the max clients, so you're not allowing anyone to override the limit.
Maximum occupancy is 32, but we will unconditionally reserve two seats for VIPs. Regardless of whether there are any VIPs present, we will always allow 30 regular people.

Well, so it means the VIP always comes with an extra seat for someone-else if the server is not yet full. Why not but we need a way to know how many VIP are currently connected, at this place of this code.

Well, so it means the VIP always comes with an extra seat (for himself if the server is full, or for someone else if the server is not yet full). My current implementation being "the VIP comes with an extra seat for himself if the server is full”. Why not but we need a way to know how many VIP are currently connected, at this place of this code.
Note that the behavior of these two policy if there is 1 private slot but two VIP wants to join:

“the VIP always comes with an extra seat for himself if the server is full, or for someone else if the server is not yet full” policy:

30 players join, 1 VIP can join.

29 players and 1 VIP join, 1 player or 1 VIP can join. If 1 player join, the other VIP can't.

“the VIP comes with an extra seat for himself if the server is full” policy:

30 players join, 1 VIP can join.

29 players and 1 VIP join, only 1 other VIP can join.

NOTE: the real slot number is always disclosed by “B” and “P” rules in statusResponse packet, the maxclients value in infoResponse is just a number to help the UI to flag a server as full. It's always up to the server to say if the server is really full when the player is trying to connect to even if it's flagged as full in UI.
The VIP knows he can try to connect even if the UI is flagging the server as full. A server owner can allocate a large number of VIP seats (to be sure a VIP will not hit the wall) but if VIP seats are given to non-VIP people anytime a VIP enters the room, it makes allocating large number of VIP seats a dangerous idea. It means a VIP is not someone who has a free pass for himself, but someone who is giving a free pass to the first random guy coming.

The way I look at it, this question (which is orthogonal to the issue of how the number of free slots is displayed) is the matter of whether someone with VIP credentials will sit in the VIP seat, or a normal seat, in the case that both are available (I think the analogy to seats really holds since the player sits at fixed location in an array, with the current implementation). Apparently the default is to sit in the VIP seat, though I haven't checked that. It might make more sense to do as @illwieckz suggests and have VIPs use normal seats if they are available, to reserve VIP seats in the case that there exist more VIPs than VIP seats.

I still don't know if VIP people takes a VIP sit or not when they connect on a non-full server, and we can't know because that code is completely broken (see #41): currently all slots (private or not) are available to anyone.
The purpose of this PR is to makes the number displayed right, which it does. We can do other PR and create other issues lately, and perhaps when the private mechanism will be repaired it will give us better ideas for private seat policy and someone will also rewrite it.
The fact is:

The client count is always wrong as soon as at least one private slot is configured
Private mechanism is broken after all and act like if it was not existing at all, so we are just losing our time talking about things we can't implement yet.

So I just need to know if I can merge that code to ensures the client count is always correct even when someone activates the not-working private client mechanism, and if I can merge that code that ensures the maxclient is never smaller than the total number of players on the server.
i.e using that PR ensures client/maxclient is never displaying something weird, even if private mechanism is broken. Btw even if private mechanism is broken it at least already works to inadvise a player to join a server, making it looking full in server browser, which is expected.

In what way is it completely broken? #41 is just about what happens when the password is the empty string.

Or perhaps I'm doing it wrong, but it totally ignores my wrong passwords…

In the code snippet @illwieckz posted in #41, there is a special case for connections from a local address. Can you still connect without the right password when the client is not on the same local network as the server?

Apologies for the earlier confusion: it's true that the password really is ignored in (almost) all cases.
By the way, I thought of a counterexample to the assumption that filling public slots first should always be preferable to filling private slots first. Suppose you have a 4v4 clan match, so you reserve 8 password slots for the combatants. Then you want them to occupy the private slots, while leaving as many public slots for spectators as possible.
Perhaps the really sensible thing to do would be to abandon the concept of private slots, and simply count the number of players who know the password, regardless of their client number. Could be an annoying amount of work though.

idk if private clients are even worth keeping.

obsoleted by #54


Release 0.1.0

close remaining issues
create 0.1.0-rc1 branch
set version to 0.1.0-rc1
update changelog
build and publish prerelease
merge to master
update brew recipe
QA over the weekend
fix issues
create 0.1.0 branch
set version to 0.1.0
set PRERELEASE to false
update changelog
build and publish release
merge to master
update brew recipe

isn't it done @stephan83 ?

I think you told me you wanted to resolve a bug with the websocket before? Something about loosing the connection when the machine goes to sleep?

I've not been able to reproduce it so I think we're good
Adrien Montfort
VP Engineering
Stratumn SAS, 1 bis Cité Paradis, 75010 Paris, France
+33 6 85 28 38 46 • <+33%206%2020%2047%2060%2029><EMAIL_ADDRESS>•
stratumn.com
We are hiring https://stratumn.com/careers • Read about us
http://blog.stratumn.com • Twitter https://twitter.com/stratumnhq
On Tue, Sep 12, 2017 at 8:34 PM, stephan<EMAIL_ADDRESS>wrote:

I think you told me you wanted to resolve a bug with the websocket before?
Something about loosing the connection when the machine goes to sleep?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/stratumn/sdk/issues/151#issuecomment-328942807, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABPldciz2HMnSTGiPEi4jUM0OoMi3pxTks5shs6ngaJpZM4OcUJB
.


Remove some of the less popular and reviewed micro modules dependencies

Wanted to see if there was an appetite for this before I went ahead and did too much work on it but I think it would be a good idea to remove some of the micro package or single function dependencies which aren't heavily reviewed.

I've opened a pull request as an example of a module which could easily be removed.

No, we want no giant utils files in Express. We have been trying to get rid of code from Express core for a long time now, and this would be the opposite of the direction we are going in.

I wouldn't be as worried about some of the jshttp which are clearly maintained by the express maintainers more about the other smaller dependencies.

If you are worried, you should be committing your node_modules directory somehow to preserve it for your application deployments. We are not concerned with these dependencies, as we picked them at the time they were added by careful evaluation, even knowing the author, typically. This has been a dependency for years and there is no intention of removing any dependencies from our tree at this time.

The fact that a package can be unpublished from npm has always been know to myself for all the time I have ever used npm. I would expect anyone using npm, or at least those authoring to npm, know how the system works.
If the potential of an unpublish concerns you, perhaps you should put this energy into helping npm change this policy or creating an alternative to npm, rather than moving project back into a non-code-sharing, copy-and-paste world.
@express/express-tc for additional opinions here.

The fact that a package can be unpublished from npm has always been know to myself for all the time I have ever used npm. I would expect anyone using npm, or at least those authoring to npm, know how the system works.
If the potential of an unpublish concerns you, perhaps you should put this energy into helping npm change this policy or creating an alternative to npm, rather than moving project back into a non-code-sharing, copy-and-paste world.
@expressjs/express-tc for additional opinions here.

Also, @ShaneQful so far this has only been a discussion of the issue in a generic sense. Perhaps it could be useful if you are trying to convince us to elaborate more on your statements.

I think it would be a good idea to remove some of the micro package or single function dependencies which aren't heavily reviewed.

So this statement brings a lot of questions to my mind:

Do you have a list of specific modules in my here and can you state the specific concerns for each one? Perhaps the issue is with something in particular but we are gettin g lost in the discussion being too generic here.
Can you define what makes a module less popular or reviewed? I have personally read the code for all current dependencies, and as the policy is to pin specific versions, and they typically do not have sub dependencies, the code won't change without us version bumping it, at which time we review it once again.
I don't understand what makes a dependency with a single function bad. Can you explain? Eventually this very package will only consist of a single function. What that make express a terrible module no one should depend on any more?

I agree 100% with @dougwilson, starting to copy and paste small code snippets into our code base is certainly not the best way to solve the issue at hand...

Azer unpublishing left-pad was an extreme case. If you want to protect yourself from that, bundle your modules as @dougwilson said.
We should strive to be modular. We shouldn't inline anything.
That being said, I think we should consider what modules we use. If we maintain the dependency, that's okay. If we don't, we should either have some control of it or be assured that it's maintained by someone we trust. For example, I'd prefer if our dependencies preferred lodash utilities vs random micro libraries.

Has anyone considered registering the npm organization for expressjs?  This would also enable us to publish our own safe forks under the @expressjs scope on npm.  I don't think this is necessary, but is is one step we could do to utilize safe and controlled versions of deps not maintained by expressjs core team members.
There is one other step we could take that is a bit more extreme, but might actually be better than the other proposed solutions I have seen from the community.  That solution would be publishing fully packaged versions of express where all deps were bundled into one file using browserify --node.  This would provide multiple benefits:

Secured and tested dependencies.  At publish time the deps were vetted, we could be sure that no third party had the ability to modify the code after publish
Faster startup times.  Because the built version of express would be a single file, the node runtime would actually start faster
Users could be assured that the code they are running was the EXACT code vetted by the express core team, not relying on NPM policy to get in the way

We could even do something like publish a version called express-bundled that would be a dependency that users can install, and let users who want to "risk"[1] installing all of express' sub dependencies individually do so as usual.
[1]. I really don't think it is a risk.

Do you have a list of specific modules in my here and can you state the specific concerns for each one? Perhaps the issue is with something in particular but we are getting lost in the discussion being too generic here.

utils-merge and to a much lesser extent because it is controlled by a contributor array-flatten. I'd have to do a little more looking to see if there are others.

Can you define what makes a module less popular or reviewed? I have personally read the code for all current dependencies, and as the policy is to pin specific versions, and they typically do not have sub dependencies, the code won't change without us version bumping it, at which time we review it once again.

While I was looking at the modules which my projects depend on, initially I was using stars on Github. This obviously isn't an ideal way to decide if a project is reviewed but I imagine there is some correlation. I think another way to define this is the number of contributors or if it's under the control of a group of developers like jshttp, lodash, pillarjs or components.

I don't understand what makes a dependency with a single function bad. Can you explain? Eventually this very package will only consist of a single function. What that make express a terrible module no one should depend on any more?

I don't have an issue with single function packages but single function packages which are controlled by a single developer for instance I would be much more comfortable if utils-merge was replaced with lodash's _.merge.

@ShaneQful you never listed what the specific concerns were for having a pinned dependency on the utils-merge module is. Can you list the specific concerns you have with this module, please?

if utils-merge was replaced with lodash's _.merge.

Does lodash supply micro packages as well? I think it would be pretty ridiculous to add all of lodash to express just to get a tiny function.

Does lodash supply micro packages as well?

It does. However, that depends on a few other lodash functions in turn, might not be that bad but it makes a clean installation 184 Kb instead of utils-merge 20 Kb...

Being by a single developer does not mean anything by itself. Part of when this packages are picked, we look really hard at these things, like I said before.
Have you eve looked at who the author is? https://github.com/jaredhanson?tab=repositories I would think the same user that has Passport.js repo is pretty safe, even if it's just a simple module. He just wanted to share a function between projects, and we didn't want to copy and paste it around here, either.
I just don't understand what your concern with depending on this module is, so please, elaborate on what your specific concerns are, so we can work to address those concerns, instead of assuming the solution you are presenting is the only possible way to address them.

I don't really know what is a good metric for comparing npm modules, here are a few merge functions:

Name
Github Stars
Monthly downloads

lodash.merge
15 550 ¹
1 650 998

utils-merge
28
4 998 889

xtend
187
12 329 749

object-assign
385
13 067 859

¹ The entire lodash is one repo

@dougwilson That's fair enough, I can certainly see where your coming from and if you guys trust the dependencies that really does a lot to assuage my initial concerns with them. Clearly a lot more forethought has gone into them than I originally thought. Thanks for talking it through and giving me more context.
Playing devils advocate, I think the only other argument that could be made regarding switching the dependencies to something like lodash is for consistency e.g. lodash has a couple of your single function dependencies as part of it e.g. it has both a merge and a flatten function.

@ShaneQful Technically "consistency" would argue for using object-assign, since it is the most installed, assuming they have the exact same behavior.
I am for moving to more popular packages because that reduces the number of modules my projects depend on and also the build size for my browser code, but that is only a small consideration compared to having reliable and backward compatible code.

I personally think that the biggest reason for switching to object-assign would be that it's a pollyfill for Object.assign that is now a days builtin into Node. That way we can simply drop the dependency when we drop Node 0.x support...

@LinusU I agree, and not that we are using them yet, but it has support for newer es201* features which would be nice if we decide to start using them.

I also agree that it makes sense to move to Object.assign in places where objects are being merged, as it is essentially a standardized way to perform merges. I would say unless there is a very good case to make that switch within the 4.x line, we should add that as a desire to have in the 5.0 release instead.
As for the general discussion, I don't think there is much more to say on the topic. In general, a lot of these kinds of "micro libraries" are eventually being incorporated into JavaScript itself (like Object.assign) and it's just a matter of time before just using the native operations from JavaScript instead.
In addition, we talked about the desire to keep out copy-and-pasted code (why would we want to have a file full of tests for a merge function, btw, or PRs every so often trying to optimized this?). From the talking, we also mentioned that we do thoroughly vet the dependencies that Express.js takes on, typically almost all are covered by the Express TC, just because it works out better in the long run this way.
We also touched on the dependency policy Express.js has had, though before closing this issue, I will outline it here for those reading:

A dependency that is added is thoroughly-read from top-to-bottom for the code it contains, looking for if it feel well-written.
We look at the test suite of that module, and weigh the complexity of the code to the thoroughness of the test suite, and how often it is run (is it setup in Travis for every commit?).
We only depend on exact versions of dependencies that are not under the Express TC (formally it was those that are not under the main developers, even personal ones).
We take into consideration to the dependencies of our dependencies, applying this same logic. A large version range on a dependency of a dependency may disqualify it from being our dependency, due to general risk of stuff randomly breaking.
The entire "npm unpublish" situation we have been aware of as long as npm has existed with this capability, though I personally have never agreed that that should be a feature of a central code registry. This is not something that can easily be overcome, so unless there is knowledge of some immanent danger/disaster, we will deal with anything along those lines as they happen, not prior.

I hope all that makes sense. If there is a desire to discuss general dependency policies, I welcome someone opening an issue at https://github.com/expressjs/discussions/issues to have a longer discussion.
I'm going to close this issue for now, as I think the discussion is generally over and has been around for 2 days. The topic has started to trail into changing different things, rather than just not depending on various modules just because.

As an additional follow-up here, npm has changed the unpublish policy and none of our dependencies can be unpublished without npm, Inc. agreeing that it should be done, as in unpublishing is no longer under the author's complete control.


Linux on RiscV

Please show simple example linux on risc-v

Hi @0xtrzy,
You can use the Linux-on-LiteX-VexRiscv project which supports the OrangeCrab.


Got an error following the quick start

Hi,
using this controller i got the error below.
    [RestController]
    public class TestController
    {
        [Route("hello")]
        public string Hello()
        {
            return "Hello World";
        }
    }

<Error>
<Message>An error has occurred.</Message>
<ExceptionMessage>
Exception has been thrown by the target of an invocation.
</ExceptionMessage>
<ExceptionType>System.Reflection.TargetInvocationException</ExceptionType>
<StackTrace>
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor) at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments) at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters) at Cormo.Impl.Weld.CormoProxyGenerator.ComponentInterceptor.Intercept(IInvocation invocation) at Castle.DynamicProxy.AbstractInvocation.Proceed() at Cormo.Weld.Proxies.TestControllerProxy.ExecuteAsync(HttpControllerContext controllerContext, CancellationToken cancellationToken) at System.Web.Http.Dispatcher.HttpControllerDispatcher.<SendAsync>d__1.MoveNext()
</StackTrace>
<InnerException>
<Message>An error has occurred.</Message>
<ExceptionMessage>
Processing of the HTTP request resulted in an exception. Please see the HTTP response returned by the 'Response' property of this exception for details.
</ExceptionMessage>
<ExceptionType>System.Web.Http.HttpResponseException</ExceptionType>
<StackTrace>
at System.Web.Http.Controllers.ApiControllerActionSelector.ActionSelectorCacheItem.SelectAction(HttpControllerContext controllerContext) at System.Web.Http.Controllers.ApiControllerActionSelector.SelectAction(HttpControllerContext controllerContext) at System.Web.Http.ApiController.ExecuteAsync(HttpControllerContext controllerContext, CancellationToken cancellationToken) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at Cormo.Impl.Weld.CormoProxyGenerator.ForwardingInterceptor.Intercept(IInvocation invocation) at Castle.DynamicProxy.AbstractInvocation.Proceed() at Cormo.Weld.Proxies.IHttpControllerProxy.ExecuteAsync(HttpControllerContext controllerContext, CancellationToken cancellationToken)
</StackTrace>
</InnerException>
</Error>

Turns out I need HttpGet on it.


⚠ Jenkins Plugins Artifactory has degraded performance

In 66b927e, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 2433 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 7e98ed9 after 1 hour, 58 minutes.


Crowdin Language Translations

Research how to best work with Crowdin for language translations.

Language files saved in Crowdin directory language structure. Oscommerce doesnt have Crowdin supported language codes.
iso_639_1 vs crowdin_code
https://support.crowdin.com/api/language-codes/
For example Spanish and Hungarian directory structure in Crowdin is found:
*es-ES
hu*

The code for the standard English languages matches: en
We could standardize on "en-US" however "en" is an acceptable crowdin code.
Additional languages can use their specific code.

I have planned english as source base but another directories should be renamed when zip import assign to reflected core language.
I see that we can get language codes when used API from request but download/upload zip export/import wont work without associated language codes.

Right, but once the admin page is ready it can create an export package based on the language code, or accept an import package that matches the language code. This has no relation with the language directory used in core.


Return an error message when cluster create fails without one

Don't set pod/service cidr if user hasn't provided anything new.
This PR will fix the misleading error message "Failed to get cluster ID" when the cluster create fails.

LGTM.


Add ghc flags

Specifically unused imports, but also explore other necessary flags.
Also look at Nix's buildStrictly and other overrideCabal options.

May I suggest turning buildStrictly back on rather than specifying individual flags?
And maybe use per file pragmas for source files that should be exempt from certain warnings.
e.g. {-# OPTIONS_GHC -fno-warn-orphans #-}

Yea if you try, see why our ci/cd is failing too.
On 1 December 2020 9:44:33 am AEDT, nzhang-zh<EMAIL_ADDRESS>wrote:

May I suggest turning buildStrictly back on rather than specifying
individual flags?
And maybe use per file pragmas for source files that should be exempt
from certain warnings.
e.g. {-# OPTIONS_GHC -fno-warn-orphans #-}
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/MatrixAI/Haskell-Demo/issues/28#issuecomment-736100598

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


PixelHead not saving modifications

If you try to rotate an image in PixelHead (the thing that opens if you double click an image) and save it, it asks you if you sure want to overwrite, you say yes and nothing happens. Checked it in the native file explorer and by reopening PixelHead. No changes whatsoever.

Sorry, not true. What confused me was #88 appearing again in 3.2 sdk.


#CX-17126 : update menu overlay to not toggle on clearing the input

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:
Before (If applicable):

After:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Consider a situation where an md-input is the trigger element for the md-menu-overlay. Here, I am trying to stop the menu overlay from getting toggled, when the "clear" on the input is clicked.
md-input would require "stopPropagationOnClear" and md-menu-overlay would require "noToggleOnClearInput"

Changes not required


Describe initial message sent after Gpio.set_int

Thanks to @fhunleth for explaining this in the #nerves Slack channel.
Related to https://github.com/fhunleth/elixir_ale/issues/24 which may change this behavior.

Thanks!


Detection of (and testing with) other compilers

ICC, for example. I don't have ready access to it so it makes testing for it a bit challenging.
I could use something like Hedley but I'd like to keep toml++ self-contained. Cherry-picking from hedley is on option too, of course (with appropriate attribution obviously).

Support for MSVC would be great! Unfortunately, I have a lot of CMake experience and none with Meson or Hedley.

@jwillikers It already has full support for MSVC (in VS 2019, at least), since that's my daily-driver. The solution in the vs/ subfolder has a whole smattering of test projects specficially for MSVC. I haven't tested older versions of it, but then C++17 support in VS2017 was sketchy at best so I figured it would probably be a waste of time (in that most people that really wanted to use C++17 and 20 features would likely have made the switch).
I guess this issue really should be made more specific, something akin to "Tests on ICC and Apple-flavoured Clang"...

I suppose I should mention prominently in the README the platforms I already test on/for, too.

@marzer Aww yes... the vs folder should have been a clue 😅 I'm definitely talking about VS 2019. Thanks!

Did some testing with ICC recently and was able to detect the meaningful parts easily enough. I'll consider this 'done' for the time being, and re-open it if someone comes at me with a more obscure compiler.


python3Packages.faadelays: 0.0.6 -> 0.0.7

Motivation for this change
Update to latest upstream release 0.0.7
Change log: https://github.com/ntilley905/faadelays/releases/tag/v0.0.7
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 120106 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.faadelays
python39Packages.faadelays

Result of nixpkgs-review pr 120106 at 21485c0d run on aarch64-linux 1

3 packages built successfully:

home-assistant
python38Packages.faadelays
python39Packages.faadelays


feat(medusa-plugin-auth): added oauth2 as login strategy

I am thinking of something, since the purpose of the OAuth2 strategy would be to allow the users to use it for multiple purposes/plateform I would suggest that instead of directly creating a class that extends the PassportStrategy, we should probably create a function that return a class that extends passport strategy with a custom named strategy. That way we can have multiple instanced of it. In that case, we also need to allow an array of configuration for this strategy in tthe plugin config. wdyt?
it would look like this:
export function getOAuth2AdminStrategy(name: string) {
  return class OAuth2AdminStrategy extends PassportStrategy(OAuth2Strategy, `${OAUTH2_ADMIN_STRATEGY_NAME}_${name}`) {
    // ...
  }
}

// packages/medusa-plugin-auth/src/auth-strategies/oauth2/index.ts
export default {
  load: (container: MedusaContainer, configModule: ConfigModule, options: AuthOptions): void => {
    if (options.oauth2?.admin) {
      const strategyOptions = Array.isArray(options.oauth2.admin) ? options.oauth2.admin : [options.oauth2.admin];
      for (const strategyOption of strategyOptions) {
        const OAuth2AdminStrategy = getOAuth2AdminStrategy(strategyOption.name);
        new OAuth2AdminStrategy(container, configModule, strategyOption, options.strict);
      }
    }
  }
}

and so one. Let me know if thats no clear :)

Sure! I totally agree. To be honest, I wanted to do it that way, but I changed my mind, telling myself that wasn't the point of the ticket. But as you point out, I agree.
I suggest we finish this ticket first, then adapt the project with a dynamic list of providers. You know, so that we don't get mixed up...

In that case ill do a final review and merge but not released to not have a breaking changes api in btween

Yep yep. I'll stat thinking about how to refactor the code for that and check for the steam integration too

I will merge this one today, in the followup pr would you be up to add a doc page for oauth2 similar to the other providers :)

Sure @adrien2p! But let's add documentation after the change of the structure. How do you think this?

I wrote the doc in the #121

I think that in terms of changes, most of it is part of my comment above with the code snippet. For the configuration, I think it can just be an array of OAuth2 config + a name for the OAuth strategy config key. Also, for the end point, I believe the url needs to be changed to include the strategy name inside so that there is no conflict. Does it make sense?

For the configuration, an arraylike makes sense. Now, to allow customization, we can define each item either in the form of a function, maybe promise-like for people thinking about multi-tenancy, so that they resolve to the configuration or the configuration.
And as you said, each array item's subconfig can simply be

a name of the (auth) provider
an OAuth2 Config related to the provider
an ID of the login type (default to the name of the provider)

For the URL, we can check just after plugin init if everything is ok and throw an error if there are conflicts. We don't need to change URLs for that. But we can build default URLs using the id of config.
How do you see this one @adrien2p ?

That sounds like a solid plan. I like it 💪


Issue #14625 - Fix pCO2 parsers to generate correct streams during playback ingestions

It would be nice if we had some sort of test to prevent this from cropping up in other/new parsers. Not sure if there's a practical way to do it though (if the parser creater isn't thinking about it when they write the parser, they probably won't think about it when they write the test, so it'd have to be some special generic test).


ci: update release action

coverage: 96.381% (-0.09%) from 96.468%
when pulling ef2228ee485e0a79e45a1dbf5c7ed814220d8eba on Tomas2D:ci-update-repease-action
into 9be6424d79cdc1b431533068b987272c49f4a067 on IBM:main.


Problem run the playbook websit.yml

Hi,
I go the following error when running  ansible-playbook  -i inventory/vagrant website.yml.
The step to install docker-py and pull the container imagess seem successful. It failed at launching the container. Can anyone help? Thanks.
My coreos version is VERSION=647.2.0
TASK: [pull container] ********************************************************
ok: [core-02]
ok: [core-01]
TASK: [launch nginx container] ************************************************
failed: [core-01] => {"failed": true, "parsed": false}
invalid output was: /home/core/pypy/bin/pypy: /lib64/libssl.so.1.0.0: no version information available (required by /home/core/pypy/bin/pypy)
/home/core/pypy/bin/pypy: /lib64/libcrypto.so.1.0.0: no version information available (required by /home/core/pypy/bin/pypy)
Traceback (most recent call last):
File "app_main.py", line 75, in run_toplevel
File "/home/core/.ansible/tmp/ansible-tmp-1435675179.7-61095459323454/docker", line 1813, in
main()
File "/home/core/.ansible/tmp/ansible-tmp-1435675179.7-61095459323454/docker", line 709, in main
except docker.client.APIError, e:
AttributeError: 'module' object has no attribute 'APIError'
failed: [core-02] => {"failed": true, "parsed": false}
invalid output was: /home/core/pypy/bin/pypy: /lib64/libssl.so.1.0.0: no version information available (required by /home/core/pypy/bin/pypy)
/home/core/pypy/bin/pypy: /lib64/libcrypto.so.1.0.0: no version information available (required by /home/core/pypy/bin/pypy)
Traceback (most recent call last):
File "app_main.py", line 75, in run_toplevel
File "/home/core/.ansible/tmp/ansible-tmp-1435675179.7-172731872346784/docker", line 1813, in
main()
File "/home/core/.ansible/tmp/ansible-tmp-1435675179.7-172731872346784/docker", line 709, in main
except docker.client.APIError, e:
AttributeError: 'module' object has no attribute 'APIError'
FATAL: all hosts have already failed -- aborting

I see a similar error and it's kinda blocking. Any help is much appreciated.

Same error here.
coreos: 899.x
ansible: <IP_ADDRESS>


Missing license

Add a license (such as default MIT) always a grey area with repos without any license

Added one now. Thanks.


Issue with multiple Services

Two people configured, the second is missing the Body Type sensor.

Maybe related to #169

The answer is here
https://github.com/dckiller51/bodymiscale/blob/main/CHANGELOG.md#v307
remove sensor body type from sensor but still available as attribute in component

Thanks. So the old sensor is not being updated then?

Yes, since the v3.0.7 https://github.com/dckiller51/bodymiscale/blob/main/CHANGELOG.md

Just updated and mostly fixed.


Make error bars gray if not selected

Sorry - I did this a while ago but I just realized I must not have created a pull request for it

@GarreBrenn - almost!  The paint gray on refresh but not live, like the ellipses.

@GarreBrenn and @marottajb - great work!  We need one additional feature - when a point is excluded and hidden, then reset needs to ignore it and recenter on visible ellipses - I think you just need to toggle the visible attribute at the same time?


New E2E-Tests for data view

Purpose
 Adds two new E2E-Tests for data view: Testing functionality of table view and time series view. Validates that new graphs are displayed correctly and that filtering is working.
Remarks

PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no

Unfortunately, both tests are flaky: Changing the filter settings throws the error: ResizeObserver loop completed with undelivered notifications. Errors occur when adding a filter (line 55 in table.spec.ts and line 77 in timeSeriesSave.spec.ts)

Added 5 new Tests for different widgets in data view: Now testing the functionality of table, time series, 2D-correlation, distribution, heatmap, map and indicator.
To avoid the error message "ResizeObserver loop completed with undelivered notifications" when adding a filter, the test for the filter is excluded from the UI tests.

Done!


Unable to save or create books/shelves after update [v0.29.3] to [v0.30.7]

I have updated my docker from 29.3 to 30.7, now I get the 'Whoops, looks like something went wrong.' error on saving a page.
For example this error is logged to the nginx log:
2020/12/27 14:18:57 [error] 379#379: *13 FastCGI sent in stderr: "PHP message: PHP Warning:  Unknown: POST Content-Length of 1080 bytes exceeds the limit of 100 bytes in Unknown on line 0" while reading response header from upstream, client: <IP_ADDRESS>, server: _, request: "POST /books/magento-guides/page/encountered-issues HTTP/1.1", upstream: "fastcgi://<IP_ADDRESS>:9000", host: "bookstack.w4e.com", referrer: "http://bookstack.w4e.com/books/magento-guides/page/encountered-issues/edit"

It's always the content-length warning. I have never encountered this before. Is there a fix or way to downgrade so I can save again?

Hi @ikdekker,
Are you using the linuxserver.io docker image?
If so, It's worth restarting your containers and see if that fixes this as they did have a temporary issue where the PHP content limit was set too low, which appears to be the issue you have now. They added a fix but it would only take action after a restart of a fixed container image.

I am not sure what fixed it in the end, i believe using a new shared /config and restarting helped.

I am not sure what fixed it in the end, i believe using a new shared /config and restarting helped.


SheetName can not be changed

Do you know why?
Export to Excel

The 3rd parameter is the sheet name:
ExcellentExport.excel(anchor, table, name);


Designing about page

About page includes all the details of the spacex organization. Along with the details of upcoming missions.

@manankohlii  Can you please assign me this issue under LGMSOC

Hello @jyothi-k-g this feature is not needed yet. We can have it in the future. Closing this.


Expand the serverless section of the service matrix

Providers: Auth0 Webtask and PubNub Blocks

These seem like reasonable additions, so we'll definitely consider them. Would you mind removing the links for now (since we're not linking anyone at the moment) and resolving conflicts?

Also, we'd like to have a sense if these are the top providers; do you have any info or sense of this? We can also discuss on Slack. Thanks for the contribution!

Also, we'd like to have a sense if these are the top providers

I'm by no means an expert in the field but my feeling is that apart from the big three (AWS, Microsoft & Google) it might be too early to state if any alternatives such as these are "top providers". However both PubNub and Auth0 are established players in their "traditional" fields and have only recently moved into the serverless space.

We can also discuss on Slack

As we seem to be in pretty different timezones it might be easier to keep the dialog here? Might also be easier for others to track down the discussion and chime in if it's kept together with the PR?

Thanks @chids!


Don't recreate the resource group for AKS

Description
When creating an AKS management cluster, we would az group create over the top of an existing RG, which deletes its tags. This changes so we check first and skip that if the RG exists.
History Notes

This checklist is used to make sure that common guidelines for an Azure CLI pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.
[ ] I adhere to the Command Guidelines.
[ ] I adhere to the Error Handling Guidelines.

cc: @willie-yao


docs(gotcha): Add an entry about hydration warnings

Closes: #1077

[x] Docs
[ ] Tests

What is this documentation actually telling us? To always browse in incognito mode (and have our users do so)? That's obviously not a solution, so I don't understand what this is suggesting. Never mind that extensions can be enabled in incognito mode. To not uninstall extensions that cause this problem? That's impractical for developers and impossible to require of end-users.
I'd like to suggest better guidance here (I ran across this myself), but I don't feel like I understand the intent behind this note.

@msakrejda You are making a totally fair point here. I'll look into expanding the documentation here to provide a better explanation and guidance 👍🏼

@machour it would be better to explain what React does when that happens, because I think most people think React will fail completely, when the reality is that React will do a new render as if you didn't SSR-ed your app, instead of just attaching event listener like the normal hydration process.

@machour it would be better to explain what React does when that happens, because I think most people think React will fail completely, when the reality is that React will do a new render as if you didn’t SSR-ed your app, instead of just attaching event listener like the normal hydration process.

@sergiodxa a couple questions here 🙏🏼

is what you're saying true for both React 17 et React 18 ?
is the warning logged in production, or is it only for dev mode ?
when react fails at hydrating, and does the new render, will Remix call loaders / actions again, or does it already have the data in the SSR response ?


Cloud SaaS team page revamp

First big update to Cloud SaaS team handbook page after the reorg contacting clarified areas of ownership and team working agreements.

I think we should merge and iterate from there, because this is a big improvement from what's live today!

+1, LGTM


Fix debugging through an autosignal hanging VS2013/15

If you try and set a breakpoint in a function with a couple of autosignals on the callstack, it hangs visual studio.  Admitedly, this is a problem with Visual Studio, but in practice it means that debugging code that uses autosignals on windows is extremely cumbersome.

We should probably look into this more.  It's likely a problem with the complexity of the variables involved--simplification of the call tree might be all it takes to fix this bug.

@wal-rus do you think you could create a branch that has some code which creates the hang?  Then I have something to tinker with.

Looks like this is actually fixed by correcting an unrelated issue in Platform having to do with WH_KEYBOARD_LL.  Closing.


Upgrade libthrift to 0.9.3

Upgrades libthrift to 0.9.3.
An application in our stack that started experience "gc-madness" last night, the thrift transport started acting out. Seems like we were bitten by the bug fixed by https://github.com/apache/thrift/commit/bb98e97fd3c82117c87d23e3fb6b8bbd800784f2.
There are probably other fixes in there as well that could be useful :)
I don't know if its related to the upgrade, but I had to add a small sleep to ITScribeSpanCollectorFailOnSetup to make it run in a less flaky fashion on my machine.

I don't see any reason to not merge this change. Thanks!


RDKB-58139: LEVL fingerprints are not reflected on CUJO portal

Impacted Platforms: All RDKB platforms.
Reason for change: Invalid data type is being passed to rbus publish function.
Test Procedure:

Load the above mentioned build.
Subscribe to this event like below, rbuscli -i
rbuscli> sub Device.WiFi.AccessPoint.2.X_RDK_deviceConnected
Connect a client to any of the private vap.
And check for the received event data is not null and contains mac address of the connected client.
If the data is null, then issue is reproduced.

Risks: Medium
Priority: P1
Change-Id: Id4de9aade2044cd02ae8ded8e95c836293fd6d8f<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Sanjay Venkatesan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


no need skip conntrack for the lsp which peer is l3dgw_port

By default, OVN skips the conntrack process for router type lsp  within a ls . It looks  unnecessary for the lsp which peer is l3dgw_port.
If removing this restriction allows for the implementation of a stateful gateway firewall.

Fixed by #226


Can't install opencv

how can I install opencv?
mscv2015, cmake 3.12.0:

[1/2] cmd /c "cd .. && "C:/Program Files/CMake/bin/cmake.exe" "C:/Users/steve/Projects/vcpkg-master/buildtrees/libpng/src/v1.6.34-8b0008e7a8" "-DPNG_STATIC=OFF" "-DPNG_SHARED=ON" "-DPNG_TESTS=OFF" "-DSKIP_INSTALL_PROGRAMS=ON" "-DSKIP_INSTALL_EXECUTABLES=ON" "-DSKIP_INSTALL_FILES=ON" "-DSKIP_INSTALL_SYMLINK=ON" "-DCMAKE_MAKE_PROGRAM=C:/Users/steve/Projects/vcpkg-master/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Users/steve/Projects/vcpkg-master/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x86-windows" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Users/steve/Projects/vcpkg-master/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/Users/steve/Projects/vcpkg-master/packages/libpng_x86-windows""
FAILED: ../CMakeCache.txt
cmd /c "cd .. && "C:/Program Files/CMake/bin/cmake.exe" "C:/Users/steve/Projects/vcpkg-master/buildtrees/libpng/src/v1.6.34-8b0008e7a8" "-DPNG_STATIC=OFF" "-DPNG_SHARED=ON" "-DPNG_TESTS=OFF" "-DSKIP_INSTALL_PROGRAMS=ON" "-DSKIP_INSTALL_EXECUTABLES=ON" "-DSKIP_INSTALL_FILES=ON" "-DSKIP_INSTALL_SYMLINK=ON" "-DCMAKE_MAKE_PROGRAM=C:/Users/steve/Projects/vcpkg-master/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Users/steve/Projects/vcpkg-master/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x86-windows" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Users/steve/Projects/vcpkg-master/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/Users/steve/Projects/vcpkg-master/packages/libpng_x86-windows""
-- The ASM compiler identification is MSVC
-- Found assembler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64_x86/cl.exe
-- The C compiler identification is MSVC 19.0.24215.1
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64_x86/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64_x86/cl.exe -- broken
CMake Error at C:/Program Files/CMake/share/cmake-3.12/Modules/CMakeTestCCompiler.cmake:52 (message):
The C compiler
"C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64_x86/cl.exe"

is not able to compile a simple test program.
It fails with the following output:
Change Dir: C:/Users/steve/Projects/vcpkg-master/buildtrees/libpng/x86-windows-rel/CMakeFiles/CMakeTmp

Run Build Command:"C:/Users/steve/Projects/vcpkg-master/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "cmTC_2b052"
[1/2] Building C object CMakeFiles\cmTC_2b052.dir\testCCompiler.c.obj
[2/2] Linking C executable cmTC_2b052.exe
FAILED: cmTC_2b052.exe
cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_exe --intdir=CMakeFiles\cmTC_2b052.dir --manifests  -- C:\PROGRA~2\MICROS~1.0\VC\bin\AMD64_~2\link.exe /nologo CMakeFiles\cmTC_2b052.dir\testCCompiler.c.obj  /out:cmTC_2b052.exe /implib:cmTC_2b052.lib /pdb:cmTC_2b052.pdb /version:0.0  /machine:X86  /debug /INCREMENTAL /subsystem:console  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
RC Pass 1: command "rc /foCMakeFiles\cmTC_2b052.dir/manifest.res CMakeFiles\cmTC_2b052.dir/manifest.rc" failed (exit code 0) with the following output:
Не удается найти указанный файл
ninja: build stopped: subcommand failed.

CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
CMakeLists.txt:34 (project)
-- Configuring incomplete, errors occurred!
See also "C:/Users/steve/Projects/vcpkg-master/buildtrees/libpng/x86-windows-rel/CMakeFiles/CMakeOutput.log".
See also "C:/Users/steve/Projects/vcpkg-master/buildtrees/libpng/x86-windows-rel/CMakeFiles/CMakeError.log".
[2/2] cmd /c "cd ../../x86-windows-dbg && "C:/Program Files/CMake/bin/cmake.exe" "C:/Users/steve/Projects/vcpkg-master/buildtrees/libpng/src/v1.6.34-8b0008e7a8" "-DPNG_STATIC=OFF" "-DPNG_SHARED=ON" "-DPNG_TESTS=OFF" "-DSKIP_INSTALL_PROGRAMS=ON" "-DSKIP_INSTALL_EXECUTABLES=ON" "-DSKIP_INSTALL_FILES=ON" "-DSKIP_INSTALL_SYMLINK=ON" "-DCMAKE_MAKE_PROGRAM=C:/Users/steve/Projects/vcpkg-master/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Users/steve/Projects/vcpkg-master/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x86-windows" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Users/steve/Projects/vcpkg-master/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-DSKIP_INSTALL_HEADERS=ON" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/Users/steve/Projects/vcpkg-master/packages/libpng_x86-windows/debug""
FAILED: ../../x86-windows-dbg/CMakeCache.txt
cmd /c "cd ../../x86-windows-dbg && "C:/Program Files/CMake/bin/cmake.exe" "C:/Users/steve/Projects/vcpkg-master/buildtrees/libpng/src/v1.6.34-8b0008e7a8" "-DPNG_STATIC=OFF" "-DPNG_SHARED=ON" "-DPNG_TESTS=OFF" "-DSKIP_INSTALL_PROGRAMS=ON" "-DSKIP_INSTALL_EXECUTABLES=ON" "-DSKIP_INSTALL_FILES=ON" "-DSKIP_INSTALL_SYMLINK=ON" "-DCMAKE_MAKE_PROGRAM=C:/Users/steve/Projects/vcpkg-master/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Users/steve/Projects/vcpkg-master/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x86-windows" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Users/steve/Projects/vcpkg-master/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-DSKIP_INSTALL_HEADERS=ON" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/Users/steve/Projects/vcpkg-master/packages/libpng_x86-windows/debug""
-- The ASM compiler identification is MSVC
-- Found assembler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64_x86/cl.exe
-- The C compiler identification is MSVC 19.0.24215.1
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64_x86/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64_x86/cl.exe -- broken
CMake Error at C:/Program Files/CMake/share/cmake-3.12/Modules/CMakeTestCCompiler.cmake:52 (message):
The C compiler
"C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64_x86/cl.exe"

is not able to compile a simple test program.
It fails with the following output:
Change Dir: C:/Users/steve/Projects/vcpkg-master/buildtrees/libpng/x86-windows-dbg/CMakeFiles/CMakeTmp

Run Build Command:"C:/Users/steve/Projects/vcpkg-master/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "cmTC_42454"
[1/2] Building C object CMakeFiles\cmTC_42454.dir\testCCompiler.c.obj
[2/2] Linking C executable cmTC_42454.exe
FAILED: cmTC_42454.exe
cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_exe --intdir=CMakeFiles\cmTC_42454.dir --manifests  -- C:\PROGRA~2\MICROS~1.0\VC\bin\AMD64_~2\link.exe /nologo CMakeFiles\cmTC_42454.dir\testCCompiler.c.obj  /out:cmTC_42454.exe /implib:cmTC_42454.lib /pdb:cmTC_42454.pdb /version:0.0  /machine:X86  /debug /INCREMENTAL /subsystem:console  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
RC Pass 1: command "rc /foCMakeFiles\cmTC_42454.dir/manifest.res CMakeFiles\cmTC_42454.dir/manifest.rc" failed (exit code 0) with the following output:
Не удается найти указанный файл
ninja: build stopped: subcommand failed.

CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
CMakeLists.txt:34 (project)
-- Configuring incomplete, errors occurred!
See also "C:/Users/steve/Projects/vcpkg-master/buildtrees/libpng/x86-windows-dbg/CMakeFiles/CMakeOutput.log".
See also "C:/Users/steve/Projects/vcpkg-master/buildtrees/libpng/x86-windows-dbg/CMakeFiles/CMakeError.log".
ninja: build stopped: subcommand failed.

and this:

CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:56 (message):
Command failed: ninja;-v
Working Directory: C:/Users/steve/Projects/vcpkg-master/buildtrees/libpng/x86-windows-rel/vcpkg-parallel-configure
See logs for more information:
C:\Users\steve\Projects\vcpkg-master\buildtrees\libpng\config-x86-windows-out.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_configure_cmake.cmake:237 (vcpkg_execute_required_process)
ports/libpng/portfile.cmake:26 (vcpkg_configure_cmake)
scripts/ports.cmake:72 (include)
Error: Building package libpng:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: libpng:x86-windows
Vcpkg version: 0.0.113-nohash

Ok, here is how you fix it:

modify msvc 2015 installation and set this flag

Looks the issue fixed.


NULL is converted to True

Hi!
The "NULL" type is not being converted correctly:
import json

from boto3.dynamodb.types import TypeDeserializer
from orjson_ddb import orjson_ddb

record = b'{"NULL":true}'
assert orjson_ddb.loads(record) == TypeDeserializer().deserialize(json.loads(record))
# True != None

I also encountered the same problem, @MattFanto do you think it's possible to get a fix for that? Happy to help with this

Ah sorry I missed the notification for the issue, yeah shouldn't be difficult to fix in theory it would just need a special case here for "NULL" type https://github.com/MattFanto/orjson-ddb/blob/8ce73e7da6c1781da525a97652b3d5f1415a87a5/src/deserialize/yyjson.rs#L254
I'm not sure when I will be able to work on it but if you want open a PR @mpuhacz it would super appreciated

Solved in 0.2.1


fix: add some documentation for modeline

Solve some TODO documents for modeline, according to https://github.com/hlissner/doom-emacs/issues/1166

LGTM. Thanks again for your help!


Insertion sort improvements

Checklist

[X] I've looked at the contribution guidelines.
[X] This pull request is complete and ready for review.

Description

added a convenience method to use when T is comparable, thus not needing a comparison closure.
added also primitive documentation for the methods.

Looks good, thanks @JulioBBL!


Restructure code

Put views and admin views in sub-packages for easier maintenance and understanding the moving parts.

@uda what views do you mean? DB views?

No, the route views, each endpoint is a View, currently it uses functions, I prefer classes, but either way each group should be in a module for easier readability and maintenance.

I propose to work on the code restructure in 2 stages:

Split app initialization, views and functions (helpers) that are inside flask_app.py into 3 separate files
Organize the views and functions into subject modules and common module

This will give us a better look at what we provide through the app