Compiling fails with fatal error: jni.h: No such file or directory

I'm using Bazel 7.4.1 on Linux and I've followed the examples provided in Bazel documentation and rules_android/rules_android_ndk to do the setup. So I've installed the latest Android Studio (Ladybug | 2024.2.1 Patch 2) and I've downloaded the followings:

SDK Platforms: Android 14.0 ("UpsideDownCake"), API Level 34
SDK Tools: Android SDK Build-Tools 35.0.0
SDK Tools: NDK (Side by side) 28.0.12674087

Both $ANDROID_HOME and $ANDROID_NDK_HOME are set accordingly as well as the required .bazelrc flags and MODULE.bazel. If I try to build an Android application without a cc_library dep, it works properly, but I can't seem to make Bazel compile an Android application with a cc_library dep.
Unfortunately I'm not able to make this work and I'm kinda lost here.
I'm attaching my workspace in the issue to troubleshoot the issue.
Thank you in advance.
ndk-test.zip

After some tinkering I made it work.
TL;DR
Define the NDK platforms as shown in the basic example drop --fat_apk_cpu flag and build like so:
bazel build --android_platforms=:arm64-v8a,:x86 --andoird_crosstool_top=@androidndk//:toolchain

Long story version
The example documentation says that to select the NDK toolchain you need to pass
--fat_apk_cpu=arm64-v8a,x86 --android_crosstool_top=@androidndk//:toolchain

Doing so using Bazel 7.4.1 with rules_android, rules_android_ndk and bzlmod will fail with the error I've mentioned. So what I did is to take a look at how the CI actually builds this repo. Based on that what you need to do is to drop --fat_apk_cpu and use --android_platforms instead.
To use the latter you need to define the platforms somewhere and pass them to the flag. Therefore suppose you've defined them in the root of your workspace as shown above the correct invocation of Bazel build would be
bazel build --android_platforms=:arm64-v8a,:x86 --andoird_crosstool_top=@androidndk//:toolchain

At this point the apk is built.
Final note
I don't know if all of this is already common knowledge, but at least to me starting anew the documentations, both here and Bazel's, really dropped me off. Would maintainers here accept a contribution to fix the situation at least here?

This should be the minimal set of flags to build the example app (i.e. this is what CI does): https://github.com/bazelbuild/rules_android_ndk/blob/main/.bazelci/presubmit.yml#L8-L12
I think even some of those aren't strictly necessary anymore; it should be sufficient to pass --android_platforms=//:arm64-v8a,//:x86. I don't think --android_crosstool_top should be necessary.
Yeah the documentation is pretty out of date :(. We do plan on fixing and improving documentation for rules_android and rules_android_ndk in the near future. In the mean time, if you want to update the documentation to what you think should be more accurate, then we'd be open to reviewing contributions.


Workaround nondeterministic linting

See issue https://github.com/golangci/golangci-lint/issues/840
A low cost fix here is to run fmt as part of the gen, which will then
be checked by gencheck.
Also tidy up the tidy-go target usage a bit.

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests_istio
febd430cf9f7c9bcb5cd6b08dae50ceec8d8b012
link
/test e2e-simpleTests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
728e4e938ddf84fefd7a5366eb8ad0b53dc6d146
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
728e4e938ddf84fefd7a5366eb8ad0b53dc6d146
link
/test pilot-multicluster-e2e_istio

unit-tests_istio
728e4e938ddf84fefd7a5366eb8ad0b53dc6d146
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-distroless_istio
728e4e938ddf84fefd7a5366eb8ad0b53dc6d146
link
/test e2e-simpleTests-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Adding port to Kemal#run

Simply adding the possibility to choose the port to listen on.
Permitting Kemal.run(8080) for example
and of course keep compatibility with Kemal.run

Do we really need it? Then we need to pass a host binding, too.
Currently you already can do:
Kemal.config.port = 8080
Kemal.run

If we do want to pass config as parameters, then I'd recommend:
Kemal.run({port: 8080, bind: "<IP_ADDRESS>"})

etc.
In conclusion, I'm not seeing any good reason to have this feature, but it's @sdogruyol's decision :)
Thanks for your PR! :)

I like how express does this. So 👍  from me :) LGTM

Done :) Thanks


PacketStream errors in log about parsing PS_ID

Hi 👋 Any idea what is these messages about with docker logs -f picash ?
goroutine 1 [running]:
main.init.0()
 /home/developer/git/go-workspace/src/gitlab.com/packetstream/ecosystem/exit-node/main.go:59 +0x2a3
Usage: grep [OPTION]... PATTERNS [FILE]...
 PATTERNS [FILE]...
Try 'grep --help' for more information.
, 0 exiting
kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... or kill -l [sigspec]
panic: strconv.Atoi: parsing "42cy": invalid syntax

This error happens after starting (./run.sh) when packetstream has been actived in settings.conf:
# Packet Stream
USE_PACKET_STREAM=y
PS_ID=42cy

For now, I had to turn this off and spin up a different docker image:
docker run -d --restart always --name packetstream -e CID=42cy packetstream/psclient:latest
$ docker logs -f packetstream
aarch64
{"ok":false,"message":"PacketStream is initializing..."}
{"ok":true,"message":"PacketStream background process is running."}
{"ok":true,"message":"PacketStream background process is running."}
{"ok":true,"message":"PacketStream background process is running."}

Sorry about that, Packetstream has an additional step to calculate your CID the launcher script has been updated to use it.
Thanks for catching that!


How to specify ‘locations (config/modules.php )’ to create a module?

I want to generate modules in the Examples directory.
what should I do?
config/modules.php
    'locations' => [
        'app' => [
            'driver'    => 'local',
            'path'      => app_path('Modules'),
            'namespace' => 'App\\Modules\\',
            ......
            ],
        ],

        'examples' => [
            'driver'    => 'local',
            'path'      => app_path('Examples'),
            'namespace' => 'App\\Examples\\',
            ......
        ],
    ],

Folder structure
app/
bootstrap/
vendor/
Modules/
Examples/

composer.json
 "autoload": {
        "psr-4": {
            "App\\": "app/",
            "Modules\\": "Modules/",
            "Examples\\": "Examples/"
        },
        "classmap": [
            "database/seeds",
            "database/factories"
        ]
    },

You change the module path config: https://github.com/nWidart/laravel-modules/blob/master/config/config.php#L73

You change the module path config: https://github.com/nWidart/laravel-modules/blob/master/config/config.php#L73

thank you for your reply.
I modified the config.php file according to your reply and it will work,
but when I access the module that exists in the Modules directory, laravel will prompt me with a 404 error, I guess the routing file is not loaded .
What should I do?
This is my modification to config.php
[
   'namespace' => 'Examples',
   'paths' => [
      'modules' => base_path('Examples'),
      'assets' => public_path('examples'),
    ]
]

That looks good, did you run a composer dump-autoload ?

That looks good, did you run a composer dump-autoload ?

Yes, I ran it, but it didn’t work

Maybe clear your cache(s) etc. I'm able to have this work locally so I can only see caching issues as other people have had this already before.


[Trivial] Review the nomenclature term used in the fabric sync setup process

Type
Other
Explanation
There are a lot of consufion on the various terms used in CCTRL. Especially the term "Reverse" caused confusion because it has different meanings depending on whether it's from the perspective of the sender or the executor of the CommissionNode command.
We have temperately agreed to use "SendCommissionNode" on the side sending the CommissionNode command and "CommissionNode" on the side executing the command.
But we would like to review these nomenclature term used in the fabric sync setup process to make sure there is no further confusion.
Platform
other
Platform Version(s)
No response
Testing
Manually tested with SDK
(Optional) If manually tested please explain why this is only manually tested
No response
Anything else?
No response

Confirmed with Chris today that he agrees with the nomenclature terms we ended up using


View state is broken with when onboarding new machine

create fresh dev box
enable sync there
view state of main machine gets changed

Mac (Code - Insiders) #1 - Settings Sync Activity.zip

/duplicate
https://github.com/microsoft/vscode/issues/225476


Trigger service restarts on openstack code change

If we change the package or the git repo we want to restart the
services. Currently this also depends on 'upgrade' being set to True.

retest

:+1:

I just tested this, and everything worked except neutron-ns-metadata-proxy Need to sort out how to properly get that process kicked over.

It looks like neutron-ns-metdata-proxy is missing from the handler in neutron-common role.

The neutron-l3-agent service is what will in turn start up neutron-ns-metadata-proxy. It starts inside the namespace.

:+1:


Update Handover report in line with application form improvements

The JO Handover report was overlooked in the other tickets and the 'Judicial experience' column needs to be updated in line with the application form changes. The current format of data is acceptable, e.g.:
Fee paid or salaried judge - Fee Paid Judge of the First-tier Tribunal = 195 days to date
Deputy Judge of the Upper Tribunal = 86.5 days to date days
The request is to ensure that the spreadsheet is still populated correctly following the changes to the application form on Apply.

Please add your planning poker estimate with Zenhub @HalcyonJAC


Update statefulset concepts doc to use apps/v1beta2 APIs

This PR updates YAML file of StatefulSet concepts doc to use apps/v1beta2 APIs, and adds a section about selector immutability and defaulting removal for .spec.selector and .spec.template.labels.

This change is

@steveperry-53 If everything looks good to you, do you mind to provide Docs LGTM and Tech Review LGTM for this PR? Thanks!

@kow3ns Incorporated your suggestion.

/lgtm


Accessing Files in File Share Locally

Hi,
I have a premium Azure function created and I have selected an existing Azure Storage account. In the same storage account I have a File Share which contains files that are required to be processed in my function's business logic, instead of streaming the file via rest APIs, is there any way that I can refer to those files in my code locally (eg: "./{fileShareName}/{fileName}) since there are in the same storage account? If it is not possible can you please suggest a better way to perform this action.
Thanks,
Sachin C

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a4d93f2d-6c04-7fc6-3f86-5ea7f9cca5c4
Version Independent ID: 77469c95-fd85-0f8a-0a2d-f4d284657845
Content: Storage considerations for Azure Functions
Content Source: articles/azure-functions/storage-considerations.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@dracosachin Thank you for your feedback! We will review and update as appropriate.

@dracosachin , Its not possible to mount the file share and access it as a path. You can either use Rest API which you mentioned or use the Fileshare client library : https://docs.microsoft.com/en-us/dotnet/api/overview/azure/storage.files.shares-readme

@dracosachin Hope the above helps and clears things up. We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


multiline scripts in Microsoft.Compute/virtualMachines/runCommands@2022-11-01 handles newline wrong

Bicep version
VS Code Bicep v0.16.2
Describe the bug
When executing a multiline script using Microsoft.Compute/virtualMachines/runCommands@2022-11-01 bicep uses the the file line endings instead of the host line endings when executing the scripts causing unexpected behavior.
For example, if the script file has CRLF as line endings and it is executed on Linux it will add a ^M to each line (see To reproduce).
The runCommands script parsing should convert line endings to the host OS preferences (CRLF on Windows and LF on Linux) instead of using the text file preferences.
To Reproduce

Create a bicep script that has a multiline command like the one below.
Store it with CRLF as line endings.
Run the script against a Ubuntu 20.04 Linux VM on Azure from a Windows computer (haven't tried from other OS).

resource runCommands 'Microsoft.Compute/virtualMachines/runCommands@2022-11-01' = {
  name: 'rc-update-and-install-dependencies'
  parent: virtualMachine
  location: Location
  properties: {
    asyncExecution: false
    source: {
      script: '''ln -snf /usr/share/zoneinfo/Europe/Stockholm /etc/localtime
echo Europe/Stockholm > /etc/timezone
'''
    }
    timeoutInSeconds: 5400
  }
}

The result will be that the /etc/localtime and the /etc/timezone files will be /etc/localtime^M and /etc/timezone^M

This behavior is intentional - my recommendation would be to either put the script in a different file (with the correct line endings) and load it with loadTextContent, or to save your Bicep file with LF line endings.

Can you please explain why this is intentional, because I have a hard time seeing why.
There is a problem with both of your solutions. Since this is IAC that is committed to a Git repo there is no guarantee that either the script file or the bicep file have LF after a retrieval from Git, nor what people does (intentionally or unintentionally when they modifies the scripts). That depends on the client configuration what it is converted to after a retrieval of the files from Git repo.

Can you please explain why this is intentional, because I have a hard time seeing why.

Bicep has to decide to either output a string containing LF, or CRLF line endings. You have provided a multi-line string containing CRLF line endings, without any instruction that they should be converted to LF, so Bicep is simply representing what it has been given.
Trying to guess at the intended line endings is going to result in more surprising behavior for many use cases. If you do it based on the current user's OS, then you're going to end up with different results if you deploy on a Windows build agent vs a Linux build agent. The behavior has to be consistent across environments.

There is a problem with both of your solutions. Since this is IAC that is committed to a Git repo there is no guarantee that either the script file or the bicep file have LF after a retrieval from Git, nor what people does (intentionally or unintentionally when they modifies the scripts). That depends on the client configuration what it is converted to after a retrieval of the files from Git repo.

Git does guarantee consistent line endings across platforms as long as it has been configured correctly - see https://stackoverflow.com/a/2825829 for a discussion on this. IMO it's very important generally to ensure you're not using autocrlf==true for shell scripts if you want cross-platform collaboration to work properly.

Closing due to no response, and I don't think there is anything for us to change on the bicep side.

Closing due to no response, and I don't think there is anything for us to change on the bicep side.

You're quick to close issues, isn't that long it was waiting for response ;)
Anyway. It seems that the bicep team reluctant to fix this anyway, even though I really can't see any issue to successfully detect the need for conversion when passing the script to the VM. Bicep knows the VM type, so it would be pretty easy to do a line ending conversion before sending it further.
But as stated, there are workaround having it as a separate script file and load it into the context, so it isn't critical, just a bit more cumbersome having things for the same thing in multiple files.

Sorry, I was on a bit of a tear on Friday, so I may have closed this too quicly :)
It's important to be consistent in how we handle line endings. It likely would be very confusing if we adjusted line-endings in the middle of a file depending on the resource. I'd argue the workaround is not in fact a workaround, but is actually the safer way to handle this.

We have 3 related items, I tried to get some good repro on root cause for the timeout, however had some mixed results.

this current issue we are in.
https://github.com/Azure/bicep/discussions/10413
https://github.com/Azure/bicep-types-az/issues/1525

I can spend a bit more time and report back once I get consistent results.

I can offer a compromise - this would be a good candidate for a linter rule!
linux VM + \r\n line endings -> warn
windows VM + \n line endings -> warn

Added testing logs and summary on the other issue (since not related to this request)

https://github.com/Azure/bicep-types-az/issues/1525#issuecomment-1522838749


Reduce RocksDB space amplification

Reduce RocksDB space amplification with level_compaction_dynamic_level_bytes option set to true. In this case, the size target of levels is changed dynamically based on the size of the last level.
Signed-off-by: Ameziane H<EMAIL_ADDRESS>

After more than one month execution, we notice a difference in space usage of about 4 GiB, i.e the node with level_compaction_dynamic_level_bytes set to true consumed 4 GiB less than the node with the default configuration. This difference is not very significant regarding the overall usage

Persist block time (block propagation time) and system metrics are quite similar :
Persist block time

CPU utilization

Memory footprint (Resident Memory)

Network IO


fix Fix jdbc timeout with multiple FE

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 39.02 seconds
stream load tsv:          456 seconds loaded<PHONE_NUMBER>9 Bytes, about 156 MB/s
stream load json:         18 seconds loaded<PHONE_NUMBER> Bytes, about 124 MB/s
stream load orc:          57 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          28 seconds loaded 861443392 Bytes, about 29 MB/s
insert into select:          63.6 seconds inserted 10000000 Rows, about 157K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230624182314_clickbench_pr_166869.html


Add gitignore+attributes and allow function use without plotting

For my use I run dubins_curve multiple times, and plotting a new figure and elapsed time each iteration is not useful or can cause problems. I've added an extra input to allow the function to be run with plotting to figures or the command window. Existing use of the function won't change as it will still plot etc. without the extra input.

Thanks for your great idea!
I will merge it once I get access to my PC within few days.


[WIP] Refactor Uber Command

Massive UberCommand file split into 3 files, plus a start on refactoring.

Looks good. Just resolve the merge conflicts and it's good to go.


Zipped

dvipdfmx no longer supports compressed graphics (https://tug.org/pipermail/dvipdfmx/2021-March/000252.html), so this PR changes the graphics inclusion rule in xetex.def and dvipdfmx.def from eps to a new rule zipped that doesn't include the file and raises an error instead.

Looks good to me

Would it be best to put in a parallel PR for the graphics bundle just dropping the entire thing?

You mean dropping all the tests for .gz in graphics.sty?  I don't think so, because zipped graphics still work in dvips

You mean dropping all the tests for .gz in graphics.sty? I don't think so, because zipped graphics still work in dvips

I meant in the documentation part: as it only works with one backend, I don't feel we should advertise it.

Ah, the documentation, yes.  I was talking to David earlier about how to best (un)document this part.  I'll tackle that later

That would be simpler, yes, but @u-fischer and I thought it would be less clear, especially because it's something that worked (a long time ago) and now it doesn't. Though admittedly you can count on one fingers of hand the number of people using that :)
So I don't know... Simpler should suffice too

I would drop it, the list of supported extensions is explicitly specific to each back end, and if dvips is the only one supporting eps.gz then that's the way it is. I think an unknown extension error is fine rather than a custom error message.


Why is db password being written to file?

The database password for the docker examples are being written to a file in $ARTIFACTORY_HOME/.dbpassword in this setDbPassword but this file doesnt seem to actually be used anywhere.
It seems like this can be safely dropped. A better way to handle the password in the docker-compose files is also to use standard .env file with a ARTIFACTORY_DB_PASSWORD and the end user can either set the password in the .env file or remove the file in a production environment and pass it in as real environment variable to the docker-compose file.
Then the compose files can be changed to something like this:
version: '2'
services:
  postgresql:
    image: docker.bintray.io/postgres:9.5.2
    container_name: postgresql
    ports:
     - 5432:5432
    environment:
     - POSTGRES_DB=artifactory
     # The following must match the DB_USER and DB_PASSWORD values passed to Artifactory
     - POSTGRES_USER=artifactory
     - POSTGRES_PASSWORD=${ARTIFACTORY_DB_PASSWORD}
    volumes:
     - /data/postgresql:/var/lib/postgresql/data
    restart: always
    ulimits:
      nproc: 65535
      nofile:
        soft: 32000
        hard: 40000
  artifactory:
    image: docker.bintray.io/jfrog/artifactory-pro:5.9.0
    container_name: artifactory
    ports:
     - 8081:8081
    depends_on:
     - postgresql
    links:
     - postgresql
    volumes:
     - /data/artifactory:/var/opt/jfrog/artifactory
    environment:
     - DB_TYPE=postgresql
     # The following must match the POSTGRES_USER and POSTGRES_PASSWORD values passed to PostgreSQL
     - DB_USER=artifactory
     - DB_PASSWORD=${ARTIFACTORY_DB_PASSWORD}
     # Add extra Java options by uncommenting the following line
     #- EXTRA_JAVA_OPTIONS=-Xmx4g
    restart: always
    ulimits:
      nproc: 65535
      nofile:
        soft: 32000
        hard: 40000

@ju2wheels - sorry for the delay. I will try and look at this in the coming day.

@ju2wheels it seems you are correct.
Artifactory has introduced some major changes in version 5.7.0 which created that gap.
This, in addition to other changes, originated from the change of 5.7.0 have to be addressed.

@ju2wheels The fix was merged. This issue can be closed now.


Update transaction_listener.go

Fixes #1112
Let me know if it needs more, I followed instructions from the issue @cpacia.

Coverage remained the same at 34.361% when pulling 036087828b0e8f6ce69a843436f6aaba57a60b31 on aslafy-z:patch-1 into 47c97d2513afc1e7d419dcf7518a3e4632df50d6 on OpenBazaar:master.

LGTM Thanks!


Derivation for seqish types should short-circuit before recursing on W[T]

SeqishW in Implicits.scala with signature
implicit def SeqishW[T: W, V[_] <: Iterable[_]]: W[V[T]] = W[V[T]]

can cause a needlessly long increase in compilation time. It first triggers a search for W[T], even if it might not apply.
A fix was published by @patrick-premont and can be seen in his fork of upickle. We use a similar fix to save ~600s compilation time in our code base. There are other workarounds (you can generate your own Writers or extend AttributeTagged with some of your own implicits to avoid forking), but it'd be nice to be able to use the standard  automatic typeclass derivation packed with upickle.
Background:
We're using slick with a large database and generate case classes for each row. We cross-compile these js and jvm and then use upickle to serialize these case classes.
We also have a typed ID, like so: case class ID[SomeDataBaseRow](id: Int). The serialization of an Id is simple and doesn't need to recurse on SomeDataBaseRow, because you only need a Writer[Int]. When upickle tries to recurse, it essentially ends up deriving Writers for every table type in the database.

Fixed by #138


Enlist polar volume (pvol) data currently stored by one of the partners

For a limited set of countries and time periods, partners of the globam project already store pvol data at the moment. It is important to have an idea of what we would have available for the envisioned period 2016-2018 (3 years of data).
On this gsheet, the third sheet available pvol data provides an overview of the existing radars. Please, provide as a comment to the specific cell  the number of days you have pvol data available. We prepared columns on a year basis (2016 other partners,....) for each radar (we'll compile the information based on these comments).
@jshamoun I do think uva in particular has some data stored, so some columns are already setup for you with write access ;-)

@leijnse can you provide some information (comments in gsheet or here in comment) about the number of days with availability for each of the Dutch radars? A general estimate is good enough.

This is being tackled in the spreadsheet. Closing issue.


Can't start iptables cookbook on host without ipv6 support

Cookbook version
4.5.0
Chef-client version
12.17.44
Platform Details
RHEL 7.6.1810
Scenario:
Hi.
I've faced with next problem: If I use cookbook on host without ipv6 it fail to start on run ip6tables step.
Reason: The installed iptables-services package installed file /etc/sysconfig/ip6tables with default sample configuration. After install it try to start ip6tables service but can't do that because no support for ipv6 on host. 'default' recipe cant't replace it to empty file (actually it just create empty file only if it missing).
Steps to Reproduce:
Just use it on host without ipv6.
Expected Result:
It can make check for ipv6 support or just replace /etc/sysconfig/ip6tables file.
Actual Result:
It fail to start on start ip6tables step.

Same problem

this is like over a year but still haven't been addressed....

Version 7 lets you specify the service you want to start through the resources
https://github.com/chef-cookbooks/iptables/blob/master/documentation/iptables_service.md


Facility access control

Related Issue or Background Info

Rounds out https://app.zenhub.com/workspaces/simplereport-5ff8be8854ae8b000e378210/issues/cdcgov/prime-simplereport/581
Added facility-based security restrictions to a bunch of methods
Added a ton of new annotations in AuthorizationConfiguration and corresponding UserAuthorizationVerifier methods
Converted a lot of String IDs in the graphql layer, to UUIDs
gave the addPatient, updatePatient, and addTestResult mutations actual non-empty return types
Added a facility filter on retrieving patients, and on retrieving a specific patient's test results
Refactored @TomNUSDS 's facility permission function into a @PreAuthorize annotation
Added addFacilityAuthorities and removeFacilityAuthorities methods in TestUserIdentities, and added updateSelfPrivileges in BaseApiTest
A whole boatload of tests for facility access

only a couple api tests remaining

@TomNUSDS @nullflux @benwarfield-usds @nickscialli-usds @jeskew-gov @timothybest-usds @timbest-usds this PR is ready for review. don't be intimidated by the size of it -- the vast majority of it is changing parameter types and return types, and a boat load of tests. but those aren't the most important parts.
The most important parts are:

The new annotations in AuthorizationConfiguration and corresponding UserAuthorizationVerifier methods
The new facility-based security restrictions on lots of service-level methods (specifically the annotations on those methods), listed in layman's terms below.
A new facility filter on retrieving patients, and on retrieving a specific patient's test results

Facility-based restrictions on methods (note -- this is separate from role-based restrictions on these methods, which still apply):

addPatient: caller must have access to the patient's facility; no restrictions if patient's facility is null

getPatient: same as addPatient

getArchivedPatient: same as addPatient

setPatientIsDeleted: same as addPatient

updatePatient: caller must have access to both the patient's original facility, and the new facility the patient is being assigned to; no additional restrictions if either of these facilities are null (e.g., if a patient is originally at Facility X and is updated to have a null facility, the caller only needs to have access to Facility X)

getPatients (no facility specified): will return only patients that are in facilities the caller can access, or whose facility is null

getPatients (facility specified): caller must have access to the specified facility; will return only patients that are in that facility or whose facility is null

getPatientsCount: same as getPatients

addPatientToQueue: caller must have access to the specified facility; the specified patient's facility must be null or the same as the specified facility

addTestResult: caller must have access to the facility of the specified patient (or no additional restrictions if the patient's facility is null) and the facility of the patient's unfinished test

updateTimeOfTestQuestions: same as addTestResult

removePatientFromQueue: same as addTestResult

getTestResult: caller must have access to the facility of the specified test

editQueueItem: same as getTestResult

correctTestMarkAsError: same as getTestResult

getTestResults: caller must have access to the facility of the specified patient (or no additional restrictions if the patient's facility is null); will return only tests that were performed in facilities that are accessible to the caller

getQueue: caller must have access to the specified facility

getTestEventsResults: same as getQueue

sendToPatientLink: caller must have access to the facility of the test associated with the patient link

refreshPatientLink: same as sendToPatientLink

A few questions:

A new facility filter on retrieving patients, and on retrieving a specific patient's test results

In the future, we may want to allow users to search for a patient at all facilities, even if they don't have access to that facility. If we do end up wanting to do that, will this implementation make it hard to add or easy to add?

addPatient(facility): caller must have access to the patient's facility; no restrictions if patient's facility is null

I'm assuming this is in the add patient UI. Will this limit the facility drop down menu in the UI to only the facilities the user has access to?
None of these should block the PR going out.

a) it'll require some tweaking, but not much! just rewiring a couple functions
b) that's partially a @nickscialli-usds question. i'm assuming the answer is yes because i imagine that drop down comes from the user's own accessible facilities?

@jeremyzitomer-usds at this point any list of facilities comes from organization.testingFacility, which,  if I understand correctly, is only returning facilities a user has access to.
Do we have any facility list exposed by the backend that isn't going to be restricted by the user's facility access? If the answer is no, then there will be no way for a user to see any facility they don't have access to in the UI.

Do we have any facility list exposed by the backend that isn't going to be restricted by the user's facility access? If the answer is no, then there will be no way for a user to see any facility they don't have access to in the UI.

The answer is, in fact, no.

Still working my way through, but one general question: do we have any sense of the before and after number of DB queries? It looks like it could be a bunch more, but I suspect that hibernate may optimize away some of those problems.

@benwarfield-usds not sure about "before" numbers, but here's the approximate additional number of queries that would be called for various API calls:
-submitTest/updateTest/updateToT: 7
-editPatient/removePatientFromQueue: 7
-patientSearch/getPatient/deletePatient: 4
-editQueueItem: 4
-getTestResult/getTestResults(for patient or facility): 3
-correctTestMarkAsError: 3
-refresh/sendPatientLink: 3
-addPatient: 3
-getQueue/addPatientToQueue: 3
the quickest way to reduce some of the higher numbers would be to factor out the redundant isValidUser() calls. other ones, i have a harder time figuring out how to avoid. that said, if hibernate does in fact optimize redundant queries, then then isValidUser() calls would make a smaller dent, so the bigger numbers above would in fact be a couple queries smaller.

@nickscialli-usds do these random github action failures look like the ones you got? only seeing them after merging from main

On the database-load question, I think it's probably the wrong thing to worry about too much—though thanks for trying to rein it in where you could!—but I do worry about nickel-and-diming ourselves into less-than-great API responsiveness, and I especially worry because we still don't have any kind of proactive performance testing.


Fix PHP Fatal error:  Class 'Codeception\Module\Module' not found

Resolves #22

Thanks @polevaultweb ;)


mkdir 和 pathlib 对其

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (dd730dc) compared to base (a2cb71e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #163   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           33        33
  Lines         4077      4071    -6
=========================================
- Hits          4077      4071    -6

Impacted Files
Coverage Δ

megfile/fs.py
100.00% <100.00%> (ø)

megfile/fs_path.py
100.00% <100.00%> (ø)

megfile/pathlike.py
100.00% <100.00%> (ø)

megfile/s3.py
100.00% <100.00%> (ø)

megfile/s3_path.py
100.00% <100.00%> (ø)

megfile/smart_path.py
100.00% <100.00%> (ø)

megfile/lib/glob.py
100.00% <0.00%> (ø)

megfile/lib/fnmatch.py
100.00% <0.00%> (ø)

megfile/lib/s3_buffered_writer.py
100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Feature requests, mishmash

In output, separators _ or ,, or max significand (non-exponent) digits.
Unit defaults. > to ft, or systems of units (Imperial, Metric, MKS, CGS, FPS, MTS), standard or config-defined.
Or ability to use reversed syntax. $ m in 5ft $ m from 5 ft
Config defined constants? Units?
CLI args / repl overriding of config values.
Seems close to stoichiometry, or other chemistry & physics, usefulness. But likely a whole other project.

I'm throwing spaghetti against the wall to see what sticks. Quote-reactions welcome and appreciated.
Your project seems pretty well structured, I may work on parts of the above as a way to get familiar with rust in a well structured environment.

Thanks for all the suggestions! Just adding some random thoughts:

In output, separators _ or ,, or max significand (non-exponent) digits.

I'm not 100% sure what you mean by max significand digits. Limiting digits to significant figures is already supported, e.g.
> 100pi to 5 sf
approx. 314.15

Separators in the output would be really useful I think, although they probably shouldn't be enabled by default. In any case, we'll need to come up with some kind of syntax to specify whether to add decimal separators.
One thing I'm thinking about is that we probably want different conventions depending on the number's base. So for base 10, we'd probably want to output e.g. 1,000,000, but in binary or hexadecimal it probably makes more sense to group digits in sets of 2 or 4, e.g. 0b1010_1111. So maybe there needs to be a way to customize the grouping of digits. I also find it interesting how different countries group digits.
Unfortunately implementing these features will require delving into bigrat.rs, which is probably the messiest part of the codebase haha

Unit defaults. > to ft, or systems of units (Imperial, Metric, MKS, CGS, FPS, MTS), standard or config-defined.

Yup, this'd be awesome. In general it'd be good if fend could be smarter about certain automatic unit conversions, like volts / ohms should probably just be converted to amperes. I guess we could have a "default" unit for common combinations of SI units for each measurement system, so that fend knows that e.g. metric kg m s^-2 becomes newtons, etc. And similarly imperial kg m s^-2 could be converted to pound-force (lbf).

Or ability to use reversed syntax. $ m in 5ft $ m from 5 ft

m from 5 ft as a reversed alternative of 5 ft in m would probably work!

Config defined constants? Units?
CLI args / repl overriding of config values.

I think these two features would probably be the easiest to implement. Maybe it's even possible to implement config-defined constants and units using Context::variables.

Seems close to stoichiometry, or other chemistry & physics, usefulness. But likely a whole other project.

Adding conversions for chemical units and things like that would be really useful I think, even just being able to find the molar mass of different substances and being able to use that in conversions would be great.


Add functionality to the facilities segment of Store Pickup and Shipping Rules page.

What is the motivation for adding/enhancing this feature?

Currently we only have ui for the facilities segment of Store pickup and Shipping Rules page. Add the functionality to it and make it working.
What are the acceptance criteria?

[ ] ...

Can you complete this feature request by yourself?

[ ] YES
[ ] NO

Additional information

Here a discussion is needed over the functionality of facility segment in store pickup page, So for now only the implementation of the facility segment in Shiping page is done in following PR: https://github.com/hotwax/threshold-management/pull/265

Changes verified and working fine in release v3.0.0. Hence, closing it.


add and compute field adaptor_properties_hash (again)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Indent line too dark in mini.indentscope

The indent line is way too dark after last update:

Could you please indicate how to make this line lighter? It became invisible after last update :-(

to change the indent color (or any other hl group), you can add something like this to your opts for the plugin:
  {
    "sho-87/kanagawa-paper.nvim",
    lazy = false,
    opts = {
      colors = {
        theme = {
          ui = {
            indent = "#ff0000",
          },
        },
      },
    },
  },

see here for more info: https://github.com/sho-87/kanagawa-paper.nvim/issues/3#issuecomment-2183665367


Cognito not avalibile in the build process

I would like to use this with cognito. but the build process does not allow cognito to be configured. can we get cognito added or what are the steps that other people done to complete the build process. and then follow the cognito steps in the wiki.

I have also tried the manual deployment with cognitions steps and I am presented with internal server errors (500 error)

I have managed to get this resolved and working now with AWS Cognito. I am going to write up some additional doco and create a pull request for anyone who is interested


Error inserting video viewer 360 / VR

Good morning I'm trying to implement on my web the VR viewer to play 360 / VR videos but I do not recognize the video. I do not know if I'm missing a file but I really do not know what's wrong. I configured the index.js
To redirect access to my mp4 video but either the error message appears or I get an error I do not focus the index.html file
A greeting and thanks for the help

-----  visor360.html  ---------

<script src="js/index.js"></script>

-----   index.js    ----
function onLoad() {
// Load VR View.
vrView = new VRView.Player("#vrview", {
width: '100%',
height: 480,
video: "12.mp4",
is_stereo: true,
//is_debug: true,
//default_heading: 90,
//is_yaw_only: true,
//is_vr_off: true,
});
vrView.on('ready', onVRViewReady);

What is the error message that you get?

Closing as this thread has been inactive and unanswered.


Notebook gets loaded and dont work

I have followed all the steps and I have got C# kernel in my notebook, but my notebook is getting loaded and not working. No error message is also getting displayed

@deepu2010 can you please send me your notebook that you are trying to load?

@gyurisc these are the script commands generated....
[W 06:54:49.284 NotebookApp] Error loading kernelspec 'csharp'
Traceback (most recent call last):
File "N:\Anaconda\lib\site-packages\jupyter_client\kernelspec.py", line 258, in get_all_specs
spec = self.get_kernel_spec_by_name(kname, resource_dir)
File "N:\Anaconda\lib\site-packages\jupyter_client\kernelspec.py", line 201, in get_kernel_spec_by_name
return self.kernel_spec_class.from_resource_dir(resource_dir)
File "N:\Anaconda\lib\site-packages\jupyter_client\kernelspec.py", line 47, in from_resource_dir
kernel_dict = json.load(f)
File "N:\Anaconda\lib\json_init.py", line 299, in load
parse_constant=parse_constant, object_pairs_hook=object_pairs_hook, **kw)
File "N:\Anaconda\lib\json_init.py", line 354, in loads
return _default_decoder.decode(s)
File "N:\Anaconda\lib\json\decoder.py", line 339, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "N:\Anaconda\lib\json\decoder.py", line 355, in raw_decode
obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Invalid \escape: line 2 column 17 (char 18)
[I 06:54:50.405 NotebookApp] Kernel started: 7c30099c-6ee1-442b-8171-ee77caf7cbb7
[W 06:54:50.650 NotebookApp] 404 GET /nbextensions/widgets/notebook/js/extension.js?v=20181212065415 (::1) 106.94ms referer=http://localhost:8888/notebooks/Untitled.ipynb?kernel_name=icsharpkernel
[W 06:55:50.539 NotebookApp] Timeout waiting for kernel_info reply from 7c30099c-6ee1-442b-8171-ee77caf7cbb7
[I 06:56:49.776 NotebookApp] Saving file at /Untitled.ipynb

@gyurisc I'm getting to know that, my kernel is connected but my notebook keeps on loading........so I cant work further. Thanks

What happens if you just start a brand new notebook with one a single line of code:
Console.WriteLine("Hello!");
Does that work?

Hi,
When I start a new kernel, I get the kernel connected but my page is still
loading.......I mean I could see a waiting symbol on my page header.
If I type any commands on the notebook, the cell keeps on loading with a
'*' symbol. I'm not able to proceed further
On Thu, Dec 13, 2018 at 8:13 AM gyurisc<EMAIL_ADDRESS>wrote:

What happens if you just start a brand new notebook with one a single line
of code:
Console.WriteLine("Hello!");
Does that work?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gyurisc/icsharp.kernel/issues/5#issuecomment-447026227,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjVVucb3_hynLf4N1iPgSIvegBQ_yFfIks5u4nyZgaJpZM4ZOskB
.

@deepu2010 I tried this and seeing it too. I will try to figure out what is going on and will get back to you.

It seems that the whole Roslyn thing is not working. I am seeing this error that is logged against the Roslyn library.
https://github.com/dotnet/roslyn/issues/28506
Trying to figure this out...

I think I managed to fix this. Please, do a git pull and clean your build and the recompile to the whole project and hit F5 with Visual Studio. If you need a pre-built package then let me know!
Thanks for reporting this issue. Really, appreciate it...

Hi Gyurisc,
Can you provide me step by step procedure for applying this new patch? I
find some difficulties in execution.
On Sat, Dec 15, 2018 at 7:25 PM gyurisc<EMAIL_ADDRESS>wrote:

added a new release just in case
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gyurisc/icsharp.kernel/issues/5#issuecomment-447614901,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjVVuYEHADG-BzkV7eG06sTzy-mm1G8Lks5u5b05gaJpZM4ZOskB
.

Hi Gyurisc,
The rebuild was successful, however after launching my notebook, I'm facing 'Kernel Error'. Am I missing something here? Please look into this issue, thank you.

Error messages:
Traceback (most recent call last):
File "N:\Anaconda\lib\site-packages\tornado\web.py", line 1543, in _execute
result = yield result
File "N:\Anaconda\lib\site-packages\tornado\gen.py", line 1099, in run
value = future.result()
File "N:\Anaconda\lib\site-packages\tornado\gen.py", line 1107, in run
yielded = self.gen.throw(*exc_info)
File "N:\Anaconda\lib\site-packages\notebook\services\sessions\handlers.py", line 73, in post
type=mtype))
File "N:\Anaconda\lib\site-packages\tornado\gen.py", line 1099, in run
value = future.result()
File "N:\Anaconda\lib\site-packages\tornado\gen.py", line 1107, in run
yielded = self.gen.throw(*exc_info)
File "N:\Anaconda\lib\site-packages\notebook\services\sessions\sessionmanager.py", line 79, in create_session
kernel_id = yield self.start_kernel_for_session(session_id, path, name, type, kernel_name)
File "N:\Anaconda\lib\site-packages\tornado\gen.py", line 1099, in run
value = future.result()
File "N:\Anaconda\lib\site-packages\tornado\gen.py", line 1107, in run
yielded = self.gen.throw(*exc_info)
File "N:\Anaconda\lib\site-packages\notebook\services\sessions\sessionmanager.py", line 92, in start_kernel_for_session
self.kernel_manager.start_kernel(path=kernel_path, kernel_name=kernel_name)
File "N:\Anaconda\lib\site-packages\tornado\gen.py", line 1099, in run
value = future.result()
File "N:\Anaconda\lib\site-packages\tornado\gen.py", line 315, in wrapper
yielded = next(result)
File "N:\Anaconda\lib\site-packages\notebook\services\kernels\kernelmanager.py", line 160, in start_kernel
super(MappingKernelManager, self).start_kernel(**kwargs)
File "N:\Anaconda\lib\site-packages\jupyter_client\multikernelmanager.py", line 110, in start_kernel
km.start_kernel(**kwargs)
File "N:\Anaconda\lib\site-packages\jupyter_client\manager.py", line 259, in start_kernel
**kw)
File "N:\Anaconda\lib\site-packages\jupyter_client\manager.py", line 204, in _launch_kernel
return launch_kernel(kernel_cmd, **kw)
File "N:\Anaconda\lib\site-packages\jupyter_client\launcher.py", line 128, in launch_kernel
proc = Popen(cmd, **kwargs)
File "N:\Anaconda\lib\subprocess.py", line 709, in init
restore_signals, start_new_session)
File "N:\Anaconda\lib\subprocess.py", line 997, in _execute_child
startupinfo)
FileNotFoundError: [WinError 2] The system cannot find the file specified

@deepu2010 There is a log file (shell.log) in the same directory where your notebook is. Can you please send me that log file?

@deepu2010 and I wish you a Merry Christmas! :)


Add detach key sequence support

Allow detaching from attached container using 'ctrl-p ctrl-q' key sequence. This is the same as the default docker detach key sequence. This only applies when the -i and -t options are set. Resolves issue #1014.
Signed-off by James Jenkins<EMAIL_ADDRESS>
What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Special notes for your reviewer:
Does this PR introduce a user-facing change?

It makes sense to me to have a detach sequence. I find myself worried this is a breaking behavior change. it's not likely, but it's possible there are uses somewhere that specify these keys and don't currently detach. Maybe it should be a crictl run/attach argument that defaults to ""? WDYT @saschagrunert

Maybe it should be a crictl run/attach argument that defaults to ""?

This would make it more complicated from an end user perspective, right?

/lgtm
thanks!


dependenciesWhitelist.txt add package cac, webpack-chain

Hi, I'm creating a package type definition: DefinitelyTyped/DefinitelyTyped#34424
And the unit test told me if the package depend on a external package, I should add it to dependenciesWhitelist.txt
Although DefinitelyTyped already has webpack-chain, the type of
webpack-chain official repository is newer.
https://github.com/neutrinojs/webpack-chain/tree/master/types

@bolasblack Can you remove webpack-chain from DT?
$ npm run not-needed webpack-chain version-that-now-has-types https://github.com/neutrinojs/webpack-chain

@sandersn I created a new PR https://github.com/DefinitelyTyped/DefinitelyTyped/pull/34570


add howtorun.md to perf-tests/clusterloader2

What type of PR is this?

/kind documentation

What this PR does / why we need it:
add instructions and required enviroments/args for perf-tests
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

the title of the document should indicate it's about perf test with multiple apiserver. "howtorun" tells too little information.

Suggest separate the manual to a few sections: General Setup (here we can have quick start), Testing Scenarios (here you can explain additional environment variables and arguments), And an summary for all env variables at the end. Thanks.

@pdgetrf This doc is under clusterloader2 folder and only for clusterloader. In community, perf-tests including bunch of tools, clusterloader is only one of the tools. use "howtorun" as title is to match with "README" under same folder.

@pdgetrf This doc is under clusterloader2 folder and only for clusterloader. In community, perf-tests including bunch of tools, clusterloader is only one of the tools. use "howtorun" as title is to match with "README" under same folder.

none of these seems relevant to me as to why this file is named "howtorun". I don't even understand why we have a folder called "cluserloader2". where's the 2 come from? what does 2 mean? same applies to "howtorun". A filename should be self-explanatory. If our user come into this folder and saw this name, will he have any idea what is to be run by seeing his filename?

@pdgetrf This doc is under clusterloader2 folder and only for clusterloader. In community, perf-tests including bunch of tools, clusterloader is only one of the tools. use "howtorun" as title is to match with "README" under same folder.

none of these seems relevant to me as to why this file is named "howtorun". I don't even understand why we have a folder called "cluserloader2". where's the 2 come from? what does 2 mean? same applies to "howtorun". A filename should be self-explanatory. If our user come into this folder and saw this name, will he have any idea what is to be run by seeing his filename?

Perf-tests/clusterloader2 is the name from community perf-tests repo, it is one of the community perf-test tools: https://github.com/kubernetes/perf-tests/tree/master/clusterloader2

@pdgetrf This doc is under clusterloader2 folder and only for clusterloader. In community, perf-tests including bunch of tools, clusterloader is only one of the tools. use "howtorun" as title is to match with "README" under same folder.

none of these seems relevant to me as to why this file is named "howtorun". I don't even understand why we have a folder called "cluserloader2". where's the 2 come from? what does 2 mean? same applies to "howtorun". A filename should be self-explanatory. If our user come into this folder and saw this name, will he have any idea what is to be run by seeing his filename?

Perf-tests/clusterloader2 is the name from community perf-tests repo, it is one of the community perf-test tools: https://github.com/kubernetes/perf-tests/tree/master/clusterloader2

take a look inside clusterload2 folder

there are two scripts run-e2e.sh and clean-up-old-snapshots.sh and these names all at least give info on what is being run. having a doc called howtorun.md is like having a script called run.sh or dostuff.sh. It doesn't tell enough info by the look. Those who have never used it before will not know what it does.

Close this Pr per scenarios has been changed


tests: drivers: i2s: i2s_api: move to new ztest API

Move drivers i2s_api tests to use new ztest API
Signed-off-by: Hu Zhenyu<EMAIL_ADDRESS>

Change to another coding style of the test

Hi @hunterhu3000 , I think you should rebase it instead of pull.

@stephanosio sorry for late, the PR is modified according to your suggestions.
@enjiamai The PR is rebased to latest
Thanks to review


Store logs in database

Log all failure tasks into database

[x] Create table for logs
[x] Insert logs to db via function in app

@mateusz2173
I need a list of actions to be monitored. Example: When the bot joins/leave the channel etc..

I put this in index.ts in error handling section, it should works.

@mateusz2173 I need a list of actions to be monitored. Example: When the bot joins/leave the channel etc..

For now let it be:

Bot first join on the server (that is list of servers where bot has ever been)
Any errors thrown in index.ts


 It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated<EMAIL_ADDRESS>some dependency vulnerabilities fixed, support for node < 10 dropped, and newer ECMAScript syntax/features added
npm WARN deprecated<EMAIL_ADDRESS>Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated<EMAIL_ADDRESS>fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated<EMAIL_ADDRESS>fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated<EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>react-with-gesture is no longer maintained. Please use react-use-gesture https://use-gesture.netlify.com/
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>react-three-fiber has been deprecated, please use @react-three/fiber from now on
npm WARN deprecated<EMAIL_ADDRESS>drei is now @react-three/drei
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
npm ERR! code 1
npm ERR! path /Users/michaellee/WebProjects/TweakIt-Desktop/node_modules/node-pty
npm ERR! command failed
npm ERR! command sh -c node scripts/install.js
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using<EMAIL_ADDRESS>npm ERR! gyp info using<EMAIL_ADDRESS>| darwin | x64
npm ERR! gyp info find Python using Python version 3.9.9 found at<EMAIL_ADDRESS>npm ERR! gyp info spawn<EMAIL_ADDRESS>npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args   '/usr/local/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args   'binding.gyp',
npm ERR! gyp info spawn args   '-f',
npm ERR! gyp info spawn args   'make',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/Users/michaellee/WebProjects/TweakIt-Desktop/node_modules/node-pty/build/config.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/usr/local/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/Users/michaellee/Library/Caches/node-gyp/17.2.0/include/node/common.gypi',
npm ERR! gyp info spawn args   '-Dlibrary=shared_library',
npm ERR! gyp info spawn args   '-Dvisibility=default',
npm ERR! gyp info spawn args   '-Dnode_root_dir=/Users/michaellee/Library/Caches/node-gyp/17.2.0',
npm ERR! gyp info spawn args   '-Dnode_gyp_dir=/usr/local/lib/node_modules/npm/node_modules/node-gyp',
npm ERR! gyp info spawn args   '-Dnode_lib_file=/Users/michaellee/Library/Caches/node-gyp/17.2.0/<(target_arch)/node.lib',
npm ERR! gyp info spawn args   '-Dmodule_root_dir=/Users/michaellee/WebProjects/TweakIt-Desktop/node_modules/node-pty',
npm ERR! gyp info spawn args   '-Dnode_engine=v8',
npm ERR! gyp info spawn args   '--depth=.',
npm ERR! gyp info spawn args   '--no-parallel',
npm ERR! gyp info spawn args   '--generator-output',
npm ERR! gyp info spawn args   'build',
npm ERR! gyp info spawn args   '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! gyp info spawn make
npm ERR! gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
npm ERR! xcrun: error: active developer path ("/Applications/Xcode.app/Contents/Developer") does not exist
npm ERR! Use `sudo xcode-select --switch path/to/Xcode.app` to specify the Xcode that you wish to use for command line developer tools, or use `xcode-select --install` to install the standalone command line developer tools.
npm ERR! See `man xcode-select` for more details.
npm ERR! gyp ERR! build error
npm ERR! gyp ERR! stack Error: `make` failed with exit code: 1
npm ERR! gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:390:28)
npm ERR! gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
npm ERR! gyp ERR! System Darwin 21.2.0
npm ERR! gyp ERR! command "/usr/local/Cellar/node/17.2.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm ERR! gyp ERR! cwd /Users/michaellee/WebProjects/TweakIt-Desktop/node_modules/node-pty
npm ERR! gyp ERR! node -v v17.2.0
npm ERR! gyp ERR! node-gyp -v v8.4.0
npm ERR! gyp ERR! not ok

npm ERR!      /Users/michaellee/.npm/_logs/2022-01-04T02_44_09_574Z-debug.log

TweakIt-Desktop on  main is 📦 v1.0.0 via ⬢ v17.2.0 took 6m 33s
➜ npm run dev:electron

><EMAIL_ADDRESS>dev:electron
> cross-env NODE_ENV=development webpack --config webpack/electron.webpack.js --mode development && npm run start:electron

sh: cross-env: command not found

Or use npm install --legacy-peer-deps to install, printed same error logs.
And I'm sure the Xcode command line does install.

@michaellee123  you can try the newest update,I did this project 1 years ago,so some dependencies is deprecated.I try to fix some recently.but there are still some remaining issues on react-spring react-with-gesture react-three-fiber ws-scrcpy.Luckly the animation list & previewer part is available.

@MartinRGB Thanks for the reply, my local code is all updated, but it's print same logs. I'm an Android Developer, so I don't know much about web development. I wanna try this app, can you package a release version?

@MartinRGB Happy new year!


Support testing direct messages (via @mention) in Mastodon

(this PR is smaller than it looks like -- my local branches got a bit messy)

Is it possible to git rebase the branch on develop?

I'll probably mess it up, but I'll try tomorrow.

Actually I do Squash and Merge, that should make the commit history less messy.


$t-variable in templates not working

Hey guys,
Can you add support for g11n in templates? I would love to see this feature :)
Jeffrey

hey @fancenl. the thing is with g11n helpers is that they are added to view rendering via config initializers, you can check here. the good news is that you should be able to add those helpers to mail rendering just the same (adding to li3_mailer\net\mail\Media).

Met vriendelijke groeten,
Jeffrey van Hees - Fance.nl http://fance.nl/ Web Development
<EMAIL_ADDRESS>- www.fance.nl - 06 289 309 74
Dit e-mailbericht is uitsluitend bestemd voor de geadresseerde. Als dit bericht niet voor u bestemd is, wordt u vriendelijk verzocht dit aan de afzender te melden. Fance.nl staat door de elektronische verzending van dit bericht niet in voor de juiste en volledige overbrenging van de inhoud, noch voor tijdige ontvangst daarvan. Voor informatie over Fance.nl raadpleegt u www.fance.nl.

Op 25 aug. 2015, om 13:38 heeft eLod<EMAIL_ADDRESS>het volgende geschreven:
hey @fancenl https://github.com/fancenl. the thing is with g11n helpers is that they are added to view rendering via config initializers, you can check here https://github.com/UnionOfRAD/framework/blob/master/app/config/bootstrap/g11n.php#L215. the good news is that you should be able to add those helpers to mail rendering just the same (adding to li3_mailer\net\mail\Media).
—
Reply to this email directly or view it on GitHub https://github.com/eLod/li3_mailer/issues/10#issuecomment-134560672.

Thanks @eLod for the quick response. Unfortunately, when I add te following code to the li3_mailer's media.php, I got the following error:
Fatal error: Uncaught exception 'InvalidArgumentException' with message 'Locale `` could not be parsed.' in /var/www/production/libraries/lithium/g11n/Locale.php:131
So, how can I take care of the fact that Lithium will use the current locale configuration?

hey @fancenl. i think you need to set the locale as well if you are rendering emails outside of the request-response cycle, e.g. you see the initializer applying the locale setter here. also i think you don't need to use the the full path for Message because of the explicit import in that initializer file, where have you added your code? i would add it in that same initializer, and use li3_mailer\net\mail\Media as MailMedia;.

@eLod I'd added the code just at the end of the file outside the class. If I do not use the full path for Message I got the error:
Fatal error: Call to undefined method li3_mailer\net\mail\Message::aliases()
So I did use lithium\g11n\Message as MailMessage; and the top of the file and changed my code to:
MailMedia::applyFilter('_handle', function($self, $params, $chain) {
	$params['handler'] += array('outputFilters' => array());
	$params['handler']['outputFilters'] += MailMessage::aliases();
	return $chain->next($self, $params, $chain);
});

and below the code above:
$setLocale = function($self, $params, $chain) {
	if (!$params['request']->locale()) {
		$params['request']->locale(Locale::preferred($params['request']));
	}
	Environment::set(true, array('locale' => $params['request']->locale()));

	return $chain->next($self, $params, $chain);
};

MailMedia::applyFilter('_handle', $setLocale);

This gives a new error:
Notice: Undefined index: request in /var/www/production/libraries/li3_mailer/net/mail/Media.php on line 424
and
Fatal error: Call to a member function locale() on a non-object in /var/www/production/libraries/li3_mailer/net/mail/Media.php on line 424
So I think that lithium cannot find the right locale because there is no request-object.

@fancenl strange, i dont think you should use MailMessage though, i would pass the class to the anonymous function via using. For the new error: yes, there is no $params['request'] just remove those lines and set whatever locale you want to.

A few months later; it is working by adding:
`use lithium\g11n\Message;
use li3_mailer\net\mail\Media;
Media::applyFilter('_handle', function($self, $params, $chain) {
$params['handler'] += array('outputFilters' => array());
$params['handler']['outputFilters'] += Message::aliases();
return $chain->next($self, $params, $chain);
});`
Thank you!


Step validation?!

Currently maybe It's just missing the documentation part, but is there an easy way to validate all the steps?
Currently we previously used https://github.com/VinceG/twitter-bootstrap-wizard but since that wizard isn't 'that' good we will change to the one you provide. But we need an easy way to validate all ours steps.
there should be a handler where we could inject a a function like _validate_steps().
Is this possible at all?
Edit:
I found out a way.
I just patched $scope.goTo = funcion(step) where it has an if like that:
$scope.goTo = function(step) {
                    var index = _.indexOf($scope.steps , step);
                    if (self._validate_step(step) || index == 0) {
                        unselectAll();
                        $scope.selectedStep = step;
                        if (!_.isUndefined($scope.currentStep)) {
                            $scope.currentStep = step.title || step.evTitle;
                        }
                        step.selected = true;
                        $scope.$emit('wizard:stepChanged', {step: step, index: index});
                    }
                };

now i've also added the _validate_step function:
                self._validate_step = function(step) {
                    var handler = WizardHandler.getValidation($scope.name || WizardHandler.defaultName);
                    var result = _.reduce(handler, function(result, fn) {
                        var ret = fn(step);
                        return result && (angular.isDefined(ret) ? ret : true);
                    }, true);
                    console.log(result);
                    return result
                }

and added two helper functions to the Handler:
       var _validation_methods = {}

       service.addValidation = function(name, fn) {
            var nameToUse = name;
            if(!fn) {
                nameToUse = service.defaultName;
                fn = name;
            }
            if (!_validation_methods.nameToUse) {
                _validation_methods[nameToUse] = [];
            }
            _validation_methods[nameToUse].push(fn);
       };

       service.getValidation = function(name) {
            var nameToUse = name;
            if(!name) {
                nameToUse = service.defaultName;
            }
            return _validation_methods[nameToUse];
       }

now you could add validation functions to the wizard as you want.
Edit2: Also it would be great that you change the license to the Apache License since I would contribute a patched version to your code to the Openstack Project and its way better to contribute APL2 Code instead of MIT Code (MIT is not permitted but the Rest of the Project ist mostly APL2)

Is the latest version availlble?


Force non-passive event for touch device

Touch event listeners had a breaking change in chrome 56. Passive events became the default in Chrome 56 and up. This PR's forces the listener to be non-passive, so that preventDefault is no longer being ignored. Without it, the page wants to navigate to the next / previous page when swiping on a touch screen.
See: https://developers.google.com/web/updates/2017/01/scrolling-intervention
Related: facebook/react/#8968

Should i add this to other touch event handlers?

@wangzuo , that will prevent some warnings in the console. So you can do that. This fix is purely to fix the navigation issue. Chrome want's to browse to the previous page when swiping to the right. So a time-change triggered the navigation.
More correct way of fixing that warnings; is to not preventDefault in the dragEnd handler.

Keep this open due to the react-dom warning https://github.com/facebook/react/issues/8968


Error precompiling MAT.jl in Julia 1.2

Hello,
I can't precompile MAT.jl in julia 1.2.0. Is there a way to load the "libz" library in Julia
(v1.2) pkg> add MAT
 Resolving package versions...
  Updating `~/.julia/environments/v1.2/Project.toml`
  [23992714] + MAT v0.5.0
  Updating `~/.julia/environments/v1.2/Manifest.toml`
  [9e28174c] + BinDeps v0.8.10
  [a74b3585] + Blosc v0.5.1
  [631607c0] + CMake v1.1.2
  [d5fb7624] + CMakeWrapper v0.2.3
  [f67ccb44] + HDF5 v0.12.3
  [23992714] + MAT v0.5.0
  [bac558e1] + OrderedCollections v1.1.0
  [d96e819e] + Parameters v0.12.0
  [30578b45] + URIParser v0.4.0

julia> using MAT
[ Info: Precompiling MAT [23992714-dd62-5051-b70f-ba57cb901cac]
ERROR: LoadError: LoadError: error compiling version: could not load library "libz"
libz.so: cannot open shared object file: No such file or directory
Stacktrace:
 [1] top-level scope at /home/mat/.julia/packages/Libz/zMAun/src/lowlevel.jl:110
 [2] include at ./boot.jl:328 [inlined]
 [3] include_relative(::Module, ::String) at ./loading.jl:1094
 [4] include at ./Base.jl:31 [inlined]
 [5] include(::String) at /home/mat/.julia/packages/Libz/zMAun/src/Libz.jl:3
 [6] top-level scope at /home/mat/.julia/packages/Libz/zMAun/src/Libz.jl:11
 [7] include at ./boot.jl:328 [inlined]
 [8] include_relative(::Module, ::String) at ./loading.jl:1094
 [9] include(::Module, ::String) at ./Base.jl:31
 [10] top-level scope at none:2
 [11] eval at ./boot.jl:330 [inlined]
 [12] eval(::Expr) at ./client.jl:432
 [13] top-level scope at ./none:3
in expression starting at /home/mat/.julia/packages/Libz/zMAun/src/lowlevel.jl:110
in expression starting at /home/mat/.julia/packages/Libz/zMAun/src/Libz.jl:11
caused by [exception 1]
could not load library "libz"
libz.so: cannot open shared object file: No such file or directory
Stacktrace:
 [1] top-level scope at /home/mat/.julia/packages/Libz/zMAun/src/lowlevel.jl:110
 [2] include at ./boot.jl:328 [inlined]
 [3] include_relative(::Module, ::String) at ./loading.jl:1094
 [4] include at ./Base.jl:31 [inlined]
 [5] include(::String) at /home/mat/.julia/packages/Libz/zMAun/src/Libz.jl:3
 [6] top-level scope at /home/mat/.julia/packages/Libz/zMAun/src/Libz.jl:11
 [7] include at ./boot.jl:328 [inlined]
 [8] include_relative(::Module, ::String) at ./loading.jl:1094
 [9] include(::Module, ::String) at ./Base.jl:31
 [10] top-level scope at none:2
 [11] eval at ./boot.jl:330 [inlined]
 [12] eval(::Expr) at ./client.jl:432
 [13] top-level scope at ./none:3
ERROR: LoadError: LoadError: Failed to precompile Libz [2ec943e9-cfe8-584d-b93d-64dcb6d567b7] to /home/mat/.julia/compiled/v1.2/Libz/0KnGZ.ji.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] compilecache(::Base.PkgId, ::String) at ./loading.jl:1253
 [3] _require(::Base.PkgId) at ./loading.jl:1013
 [4] require(::Base.PkgId) at ./loading.jl:911
 [5] require(::Module, ::Symbol) at ./loading.jl:906
 [6] include at ./boot.jl:328 [inlined]
 [7] include_relative(::Module, ::String) at ./loading.jl:1094
 [8] include at ./Base.jl:31 [inlined]
 [9] include(::String) at /home/mat/.julia/packages/MAT/UpKPb/src/MAT.jl:25
 [10] top-level scope at /home/mat/.julia/packages/MAT/UpKPb/src/MAT.jl:30
 [11] include at ./boot.jl:328 [inlined]
 [12] include_relative(::Module, ::String) at ./loading.jl:1094
 [13] include(::Module, ::String) at ./Base.jl:31
 [14] top-level scope at none:2
 [15] eval at ./boot.jl:330 [inlined]
 [16] eval(::Expr) at ./client.jl:432
 [17] top-level scope at ./none:3
in expression starting at /home/mat/.julia/packages/MAT/UpKPb/src/MAT_v5.jl:29
in expression starting at /home/mat/.julia/packages/MAT/UpKPb/src/MAT.jl:30
ERROR: Failed to precompile MAT [23992714-dd62-5051-b70f-ba57cb901cac] to /home/mat/.julia/compiled/v1.2/MAT/3FHIv.ji.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] compilecache(::Base.PkgId, ::String) at ./loading.jl:1253
 [3] _require(::Base.PkgId) at ./loading.jl:1013
 [4] require(::Base.PkgId) at ./loading.jl:911
 [5] require(::Module, ::Symbol) at ./loading.jl:906

(v1.2) pkg> st
    Status `~/.julia/environments/v1.2/Project.toml`
  [944b1d66] CodecZlib v0.6.0
  [7073ff75] IJulia v1.20.0
  [23992714] MAT v0.5.0

My guess is you need a package on your machine. On Ubuntu it might be solved by installing zlib1g-dev.

Thank you, that's solved my problem.

I have a very similar problem on windows 10 and a new setup of Julia 1.3. I'm getting the error message:
ERROR: LoadError: LoadError: error compiling version: could not load library "zlib1"
Do I have to install zlib1 seperately? This was not necessary for older versions (of Julia or Mat.jl)

If someone is courious: I fixed it by add Libz#master


Provide better support for difference in case sensitivity of the file system

Expected Behavior

On case-sensitive system, when a file is not found but a different cased file exists, we could suggest using that file instead.
On case-insensitive system, we could warn about different cased file open.
All this is to help notify the user that his build system contains potential cross-platform issues.
Current Behavior

Gradle delegate all file operation to the operating system. When developing cross-platform builds, a different case can result in explicit or, worse, silent failures. This cause builds to be invalid or lengthy debug time.
Context

See https://discuss.gradle.org/t/case-sensitivity-in-configurablefilecollection/29506
Steps to Reproduce (for bugs)

Your Environment

Build scan URL:

@wolfs @lptr This should not be close. It's a real issue with caching and up-to-date checks.


Hover to expand topology option if the list exceeds the max width

Fixes https://github.com/weaveworks/scope/issues/3096

Moved option All to the very beginning
Changed to use flexbox
Added hover to expand behavior to display more options if the list exceeds the max width

Thanks for the PR. This looks like a pretty neat and low-cost (in terms of extra code) solution. Alas I am not a UI expert. @foot what do you reckon?

This looks really slick, thanks for the PR!
Its often dangerous to move elements around a lot on hover but I'm keen to take this for a spin. Adding an expansion button is not as cool but may be a bit easier to interact with. We'll give it a UX test on Monday.

While the hover expand is quite fun and playful you can quite easily get into that frustrating scenario where the item you intend to click jumps out from under the cursor at the last second.
A little expand/collapse caret would work fine I think. Especially if it didn't move around when clicked so you click, click, click to close / open / close.

@foot I thought about the expand/collapse caret, but I didn't figure out the position to place it. The current UI doesn't have this type of element so I am not sure the UX pattern to follow. Can you suggest where should be the caret placed?
Also once the caret is used, when to show/hide the caret itself becomes a difficulty due to the nature of a dynamic list. i.e. for filter list that doesn't go out of the screen we don't need to show the caret
Any suggestions?

Hi again! Sorry for the delay.
We use this +n[0] notation around the place for expanding out more information which could work in this case.

when to show/hide the caret itself becomes a difficult

Yes! I don't think you can pull this off in pure CSS.. But, we store the window's width/height in the global store so you can grab that in the component by adding something like viewportWidth: state.getIn(['viewport', 'width']) into mapStateToProps.
Then... you'd unfortunately still have to add a ref/dom measuring stuff into topoOptions.
rough pseudo js:

getNumberOptionsHidden(viewportWidth, containerRef) {
  const { width, height } = containerRef.getBoundingClientRect();
  // maybe only use 50% of screen width?
  if (width < viewportWidth * 0.5) {
     return 0;
  }

  // calculate cumulative sum of width of DOM children and
  // takeWhile cumWidth < viewportWidth * 0.5
  ...
  return numberOfChildrenThatFitIn50Percent;
}

class TopologyOptions {

...

componentWillReceiveProps(nextProps) {
   const widthHasChanged = nextprops.viewportWidth !== this.props.viewportWidth;
   if (widthHasChanged) {
      this.setState({
        numberOptionsHidden:
          getNumberOptionsHidden(nextprops.viewportWidth, this.containerRef)
      });
   }
}

render() {
  return <div ref={r => this.containerRef = r} ...
   ...
   {take(this.props.options, this.props.options.length - this.state.numberOptionsHidden)}
   ...
   {(this.state.numberOptionsHidden > 0)
     && <ShowMoreHorizontal count={this.state.numberOptionsHidden} />}
 </div>
}

...

}

<ShowMore /> could be copied and adapted a bit info a <ShowMoreHorizontal /> like thing.
WDYT?
[0] Example of +n in the details panel:

@ycao56 did you get so see @foot 's proposal? Any chance of getting it implemented anytime soon?

@ycao56 Closing (I am cleaning up the lingering PRs). Please feel free to create another PR if you want this merged (we are still interested).

Reopening instead of

ping @foot - how does this PR look like - did you want to review it? :)


VS is not responding after clicking add new item.

Environment data

Steps to Reproduce

Create a project
Select Project > Add New Item

Expected behavior
The add new item window should pop up.
Actural behavior
VS is not responding.

Internal bug 1111181

Works now in 16.7.0 Preview 1.0 [30028.18.master]


KYLIN-4126 cube name validate code cause the wrong judge of streaming…

… type

Codecov Report

Merging #792 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #792      +/-   ##
============================================
+ Coverage     25.74%   25.74%   +<.01%
- Complexity     6048     6049       +1
============================================
  Files          1394     1394
  Lines         83019    83019
  Branches      11611    11611
============================================
+ Hits          21372    21373       +1
  Misses        59589    59589
+ Partials       2058     2057       -1

Impacted Files
Coverage Δ
Complexity Δ

.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java
63.84% <0%> (-2.31%)
0% <0%> (ø)

...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java
66.56% <0%> (+0.6%)
7% <0%> (ø)
:arrow_down:

...he/kylin/dict/lookup/cache/RocksDBLookupTable.java
78.37% <0%> (+5.4%)
7% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4bfa1...07cac14. Read the comment docs.

Pull Request Test Coverage Report for Build 4848

0 of 0   changed or added relevant lines in 0 files are covered.
11 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.005%) to 28.226%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java
2
68.46%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
9
76.29%

Totals

Change from base Build 4840:
-0.005%

Covered Lines:
23433

Relevant Lines:
83019

💛  - Coveralls

LGTM


Rendering issue with inline submenu on treeItem

VS Code Version: 1.54.3
OS Version: Windows_NT x64 10.0.19042

Steps to Reproduce:

Create a submenu with one command in the extension manifest package.json. Register this submenu as treeItem "inline" context menu. Example:

{
    "name": "mysoft-studio",
    "displayName": "mysoft Studio",
    "contributes": {
        "views": {
            "mysoft-environments-explorer": [
                {
                    "id": "mysoft.views.changes",
                    "name": "Changes"
                }
            ]
        },
        "commands": [
            {
                "command": "mysoft.changesView.pushChange",
                "title": "Publish",
                "icon": {
                    "light": "resources/light/boolean.svg",
                    "dark": "resources/dark/boolean.svg"
                }
            },
            {
                "category": "mysoft Studio",
                "command": "mysoft.changesView.publishAndLock",
                "title": "Publish And Lock",
                "icon": "$(cloud-upload)"
            }
        ],
        "menus": {
            "view/item/context": [
                {
                    "command": "mysoft.changesView.pushChange",
                    "when": "view == mysoft.views.changes && viewItem == mysoft:change",
                    "group": "inline"
                },
                {
                    "submenu": "changes.advancedContextMenu",
                    "group": "inline@2",
                    "when": "view == mysoft.views.changes && viewItem == mysoft:change"
                }
            ],
            "changes.advancedContextMenu": [
                {
                    "command": "mysoft.changesView.publishAndLock",
                    "when": "view == mysoft.views.changes && viewItem == mysoft:change",
                    "group": "1_concept-update"
                }
            ]
        },
        "submenus": [
            {
                "id": "changes.advancedContextMenu",
                "label": "Advanced options",
                "icon": "$(gear)"
            }
        ]
    }
}

Run your extension.
Try to open the submenu from treeView item.

Actual result:
Menu is rendered cropped (outside of treeView). When cursor is moved to menu item, the focus is lost (taken by another control) and the menu disappears.
Example: https://ibb.co/VYghgD1.
Expected result:
Menu is rendered correctly, submenu command title is readable and invokable.

Does this issue occur when all extensions are disabled?: No

Duplicate of https://github.com/microsoft/vscode/issues/110083


Constants in storage/local overflow int on 32-bit

Build (which includes "go test") fails on 32-bit systems with these constant-overflows-int messages:
storage/local/codable/codable_test.go:44: constant<PHONE_NUMBER>12345 overflows int
storage/local/storage_test.go:806: constant<PHONE_NUMBER> overflows int
storage/local/storage_test.go:806: constant<PHONE_NUMBER> overflows int
FAIL    _/home/user/prometheus/storage/local [build failed]
FAIL    _/home/user/prometheus/storage/local/codable [build failed]

Pull request: https://github.com/prometheus/prometheus/pull/665

Fixed. Thanks again!


Tensor dimension mismatch in PointPillar BaseBEVBackbone

Hello, I am using a custom dataset that has been converted to kitti format, and when I run train.py, I get the following error:
Traceback (most recent call last):
  File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/openpcdet_v030/tools/train.py", line 201, in <module>
    main()
  File "/openpcdet_v030/tools/train.py", line 173, in main
    merge_all_iters_to_one_epoch=args.merge_all_iters_to_one_epoch
  File "/openpcdet_v030/tools/train_utils/train_utils.py", line 93, in train_model
    dataloader_iter=dataloader_iter
  File "/openpcdet_v030/tools/train_utils/train_utils.py", line 38, in train_one_epoch
    loss, tb_dict, disp_dict = model_func(model, batch)
  File "/openpcdet_v030/pcdet/models/__init__.py", line 30, in model_func
    ret_dict, tb_dict, disp_dict = model(batch_dict)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 550, in __call__
    result = self.forward(*input, **kwargs)
  File "/openpcdet_v030/pcdet/models/detectors/pointpillar.py", line 11, in forward
    batch_dict = cur_module(batch_dict)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 550, in __call__
    result = self.forward(*input, **kwargs)
  File "/openpcdet_v030/pcdet/models/backbones_2d/base_bev_backbone.py", line 106, in forward
    x = torch.cat(ups, dim=1)
RuntimeError: Sizes of tensors must match except in dimension 2. Got 472 and 469

When I print the values of self.blocks[i](x) for each iteration of forward() in base_bev_backbone.py, I get the following dimensions:
torch.Size([4, 64, 469, 541])
torch.Size([4, 128, 235, 271])
torch.Size([4, 256, 118, 136])
Are the dimensions supposed to match? I don't see how that is possible if the layers have 64, 128, and 256 filters respectively.
Thank you

Please refer #253 to set the voxel size. This might caused by inccoret feature map size due to incorrect voxel size.

That was exactly it, I tried a few different voxel sizes and found one that produces matching tensor dimensions. Thanks!


Support for typstfmt

https://github.com/astrale-sharp/typstfmt – code formatter for typst.
I never added a package to the registry, so it may take some time until I create a PR. Feel free to take over the PR.

typstfmt is now in the registry, issue can be closed, congrats


BuiltIn and Collections: Deprecate using no values to disable values from error messages

Now that we are making Boolean argument handling consistent (#2038), we should deprecate using custom no values argument to disable adding values to error messages. It is better to use the now standard false or no. If there's a need to make it explicit false or no applies to values, normal named argument syntax can be used e.g. like values=no.

After thinking this a bit more, I decided not to do this change. These were the two main reasons:

Deprecating and removing this features creates extra work for users and also for us.
Supporting special no values where it is currently supported in addition to false and no (#2038) is trivial.


Potential bug: v_offset expected for touch_tip during transfer but cannot be set

overview
The api reference page states:

touch_tip (boolean) – If True, a touch_tip will occur following each aspirate and dispense. If set to False (default), no touch_tip will occur.

but a warning is thrown when you follow the api instructions for performing a touch_tip.
current behavior
Running a pipette.transfer command with touch_tip=True results in a warning:

"Please use the v_offset named parameter"

steps to reproduce
from opentrons import labware, instruments

tips1000 = labware.load('opentrons-tiprack-1000ul', '1')
plate1 = labware.load('96-deep-well', '2')

pipette1000 = instruments.P1000_Single(mount='left', tip_racks=[tips1000])

pipette1000.transfer(100, plate1.well('A1'),
                     plate1.well('B1'),
                     touch_tip=True)

simulate log:

Transferring 100 from well A1 in "2" to well B1 in "2"
Picking up tip well A1 in "1"
Aspirating 100.0 uL from well A1 in "2" at 1 speed
Touching tip
Logs from this command:
WARNING (pipette): Please use the v_offset named parameter
Dispensing 100.0 uL into well B1 in "2"
Touching tip
Logs from this command:
WARNING (pipette): Please use the v_offset named parameter
Dropping tip well A1 in "12"

expected behaviour
No warning or preferably a procedure listed in the api reference for specifying the v_offset during transfer or distribute.

This is also related to #2048 and #3599
 Together they represent the ideal behaviour for a distribute touch_tip:

Aspirate
Move to first destination
Dispense, move to defined height and touch tip at defined height
Move to a new destination
Dispense, move to defined height and touch tip at defined height
...


sigsci_corp_rule inList Bug

Hi,
When trying to use a corp list in a corp rule with the below configuration
resource "sigsci_corp_rule" "test" {
    site_short_names = []
    type = "request"
    corp_scope = "global"
    reason = "Allow requests from proxy IPs"
    enabled = true
    expiration = ""
    group_operator = "any"
    conditions {
        type = "single"
        field = "ip"
        operator = "inList"
        value = sigsci_corp_list.proxies.name
    }
    actions {
        type = "allow"
    }
}

I get the below provider error

"registry.terraform.io/signalsciences/sigsci" produced
│ an invalid new value for .conditions: planned set element
│ cty.ObjectVal(map[string]cty.Value{"conditions":cty.SetValEmpty(cty.Object(map[string]cty.Type{"conditions":cty.Set(cty.Object(map[string]cty.Type{"field":cty.String,
│ "group_operator":cty.String, "operator":cty.String, "type":cty.String, "value":cty.String})), "field":cty.String, "group_operator":cty.String, "operator":cty.String,
│ "type":cty.String, "value":cty.String})), "field":cty.StringVal("ip"), "group_operator":cty.StringVal(""), "operator":cty.StringVal("inList"),
│ "type":cty.StringVal("single"), "value":cty.StringVal("Proxy allowlist")}) does not correlate with any element in actual.

I have tried using other sigsci_corp_list attributes ("id" and "entries") but they lead to an internal error. There are no errors with the sigsci_corp_list resource and it is provisioned as normal in the sigsci dashboard.

Hi @KodMishka, thanks for the issue.
I created a corp list in the UI and then a corp rule with the following TF:
resource "sigsci_corp_rule" "test-rule" {
  site_short_names = []
  type             = "request"
  corp_scope       = "global"
  group_operator   = "any"
  enabled          = true
  reason           = "Test reason"
  expiration       = ""

  conditions {
    type     = "single"
    field    = "ip"
    operator = "inList"
    value    = "corp.testlistname"
  }

  actions {
    type = "allow"
  }
}

I suspect the issue may be with conditions.value:
value = sigsci_corp_list.proxies.name

as I was unable to create a corp list with that ID (validation fails when trying to use a period in the name, and it looks like IDs for corp lists default to corp.[name]).
Could you please confirm that the corp list name is correct in the value field, and try creating the rule with the latest release v1.2.2? Thanks!

@KodMishka creating a list and corp rule worked for me on hte latest provider version (1.2.4) using value = sigsci_corp_list.proxies.id rather than value = sigsci_corp_list.proxies.name.
If you try with the latest version and it still doesn't work, please reopen this issue. Also it would be helpful to see sigsci_corp_list.proxies if you can anonymize and provide it. Thank you!


[Tabs] Use flat buttons for tabs

Use flat buttons for tab buttons to more closely comply with material design specs.

All caps text
Add ripples
Unfocused tab color: #fff 70%

@onumossn That's will make the Tabs follow more closely the material specification :+1:.

@oliviertassinari How is this going to accommodate the changes being introduced in #3042?

Well, we will have a merge conflict on this PR.

Not just a merge conflict - FlatButton / EnhancedButton don't support the 'icon over text' layout.

Not just a merge conflict - FlatButton / EnhancedButton don't support the 'icon over text' layout.

I wasn't aware of this issue.

Updated it to use EnhancedButton, and tried adding the code from #3042 to see if it would have any negative impacts, and it seemed to work fine. However, there may be minor merge conflicts, but they can be easily resolved.
I don't understand the lack of support. If it is used as container component like the div that was there, the children can be positioned and behave however they like within the container, so 'icon over text' should be work fine as long as both the icon and text are children.

@onumossn - yes, sorry, you are correct. Thanks for testing.

@onumossn We have just merged https://github.com/callemall/material-ui/pull/3042. Could you rebase?

Rebased

Other than that it's great :+1: :+1: Thanks a lot :grin:

I agree, I like this PR :heart_eyes:.

Does this look ok? I updated padding to have left and right padding, and set top and bottom padding to 0. It doesn't seem the conditional top padding is necessary with enhanced buttons. Let me know if you feel that it is necessary and I will put it back in.

Thanks a lot @onumossn Me and @oliviertassinari Will take a last look. Awesome work :+1: :+1:

:+1: here. @oliviertassinari merge if it's alright.

@onumossn Thanks! Can you squash down the commit? I think that we can merge then :+1:.

Updated and rebased. Why is line-height used instead of height anyway?

Updated and rebased. Why is line-height used instead of height anyway?

I think since that <FlatButton /> just has text, the lineHeight is used to make sure it's vertically centered properly.

@oliviertassinari @alitaheri Seems like you both okayed this so I'll merge it.

Thanks much @onumossn!

Can I tap into the FlatButton, and disable the ripple somehow? This kind of screwed my navigation bar.

Yes we should improve the customization for this. I also broke my close button since buttons cannot nest buttons. I'm trying to figure out the best way to achieve this.


Carthage update fails

I'm trying to use the latest master (e.g., b8ce449d5224fd5a893a37f367524accb975bdb3) as a Carthage dependency. However when I run carthage update the build fails with Argo. The error below is the output of the shell task that actually causes Carthage to fail building.
(I should note I am using the default toolchain on Xcode 8 Beta 5)
Error Messages
/usr/bin/xcrun xcodebuild -workspace /Users/ryan/Source/VHS/Carthage/Checkouts/Argo/Argo.xcworkspace -scheme Argo-Mac -configuration Release ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build
2016-08-12 16:31:37.557 xcodebuild[40821:2756911] [MT] DVTToolchain: Failed to register toolchain: <DVTToolchain:0x7fa975c2ba80:'org.swift.3020160804a':'Swift Development Snapshot 2016-08-04 (a)'>: Error Domain=DVTFoundationErrorDomain Code=-1 "Can't register <DVTFilePath:0x7fa975d20d30:'/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2016-08-04-a.xctoolchain'>; identifier org.swift.3020160804a conflicts with <DVTFilePath:0x7fa975d208a0:'/Users/ryan/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2016-08-04-a.xctoolchain'>" UserInfo={NSLocalizedDescription=Can't register <DVTFilePath:0x7fa975d20d30:'/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2016-08-04-a.xctoolchain'>; identifier org.swift.3020160804a conflicts with <DVTFilePath:0x7fa975d208a0:'/Users/ryan/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2016-08-04-a.xctoolchain'>}
Build settings from command line:
    CARTHAGE = YES
    CODE_SIGN_IDENTITY =
    CODE_SIGNING_REQUIRED = NO
    ONLY_ACTIVE_ARCH = NO

=== CLEAN TARGET Runes-Mac OF PROJECT Runes WITH CONFIGURATION Release ===

Check dependencies
“Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.

** CLEAN FAILED **

The following build commands failed:
	Check dependencies
(1 failure)
=== BUILD TARGET Runes-Mac OF PROJECT Runes WITH CONFIGURATION Release ===

Check dependencies
“Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.

** BUILD FAILED **

The following build commands failed:
	Check dependencies
(1 failure)

Argo Version
b8ce449d5224fd5a893a37f367524accb975bdb3
Dependency Manager
Carthage
Carthage Configuration
Cartfile
github "thoughtbot/Argo" "master"
github "thoughtbot/Curry" "master"

Cartfile.private
github "typelift/SwiftCheck" "swift3_0"

Cartfile.resolved
github "thoughtbot/Curry" "0d1db3e19759527b4ed9cf941abaea404a707db0"
github "thoughtbot/Runes" "b81919bf0129e2b7f51d7f2c2e08db274f9407af"
github "typelift/SwiftCheck" "d10548f998f2623e1fc69974e577cb3b10034468"
github "thoughtbot/Argo" "b8ce449d5224fd5a893a37f367524accb975bdb3"

It's likely that Argo needs more updates for the newer betas.

I say it's likely, but I mean that it definitely needs updates for the newer betas

@gfontenot I've ported the library to beta 6 but didn't open a PR since I couldn't run the tests on the Runes dependency I ported. Here are the changes I had to make. Most of it was automatic I had to give the custom operators precedence levels and replace the <|> definition with an import Runes because otherwise the definitions conflicted. Once those changes were made I was able to drop the updated versions into my projects with no issues.

Oh, plus all of the AnyObject to Any changes I had to do manually.

Yep, I'm actually working on this now. I'll open a WIP PR since I probably won't be able to complete it today, but want to have some proof that it's being worked on.

The updates needed for this are currently in an open PR


Update for macOS Mojave

https://github.com/0xmachos/mOSL is a good replacement until this is updated.
Basically, we should remove all settings that are no longer relevant, and add ones that are newly added.

Hi @alichtman,
For the first time I enrolled in the HacktoberFest looking to start learning about Open Source, is there in anyway that I can help with this issue?

@Gonmeso Hey! So for this issue, you should check that things work properly on Mojave and Catalina. Basically make sure that the settings are changed properly (which unfortunately must be done manually since I haven't found a way to automate this).