Windows installer not working

Latest Windows installer AppSetup from here doesn't work.
It just emits this:
---------------------------

---------------------------
old version error
---------------------------
OK
---------------------------

Furthermore, repository location doesn't look legit/official.
On related note, I am creating chocolatey package so that we can just choco install freerdp.
I am downloading latest nightly release but it lacks version info, and GitHub releases do not have snapshot at release time. File properties also does not show version, and also command line parameters /help or /? or /version. Is it possible to do any of that so I can determine when to automatically update the package and what version to give it?

@majkinetor thanks for the info, this is not an installer we provide, there was some wiki vandalism.
Removed this.

I suspected so.
What about other question? :)

@majkinetor the nightlies are build every night.
Command line parameters work, but on cmd the output is not visible (you need to do something like wfreerdp.exe /version >log.txt 2>&1 to write the output to a file log.txt

wfreerdp.exe /version >log.txt 2>&1

Interesting, that doesn't work from PowerShell, only via cmd.exe. Also this popup doesn't show as described on Wiki
I find it really hard to find out if app is working at all. Initially I thought that it is not static and some dlls are missing. Only when I specify right parameters to connect to remote, it shows that it works.
Anyway, version of nightly build differs from latest released version. I get This is FreeRDP version 3.0.0 while latest release is 2.8.0, so I can't really use that mechanism. The only thing now that comes to my mind is to monitor releases page for new version, and when I detect it, to get latest nightly build and pack it as a part of that version (which means it may have few commits more).

@majkinetor we do not ship builds of the stable branch, just nightlies. (with enabled address sanitizer and other debug related stuff)

FYI, I published automatic package on Chocolatey:

https://community.chocolatey.org/packages/freerdp.portable

It packages nightly release taken with a day after official GitHub release. Package contains binary so people can download it there or install it with cinst freerdp.portable --version x.y.z.

@majkinetor first thank you for your effort, but I think you mixed up something.
nightly are always build from master branch, releases are from stable-2.0 branch and they differ quite a lot. You might want to join our matrix chat (see https://freerdp.com for details ) to discuss that a little further.

I was using the same link available on Download page. This is the only place where working binary could be found. If there is an artifact for stable-2.0 release, or some other location that gets up to date builds, I can quicly change the package.

@majkinetor there are no binaries for 2.0, but the check for releases just does not make any sense, as stable-2.0 and master are independent branches.

Yeah, OK, I will remove such dependency and publish it if there is file hash change.


Memcached redlock implementation

Codecov Report

Merging #240 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #240      +/-   ##
=========================================
+ Coverage   99.09%   99.1%   +<.01%
=========================================
  Files          13      13
  Lines         771     779       +8
  Branches       80      81       +1
=========================================
+ Hits          764     772       +8
  Misses          7       7

Impacted Files
Coverage Δ

aiocache/backends/memcached.py
100% <100%> (ø)
:arrow_up:

aiocache/base.py
100% <100%> (ø)
:arrow_up:

aiocache/backends/redis.py
100% <100%> (ø)
:arrow_up:

aiocache/_lock.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea2938c...58909e0. Read the comment docs.


Resource settings does not automatically refresh after the upgrade

Describe the bug

After upgrading resources, the resource settings does not automatically refresh, which may result in some computed attributes not being displayed.
Steps to reproduce
https://github.com/seal-io/walrus/assets/26084756/931b8830-18e3-4585-abd5-cf939b4d8cdd
Expected behavior

Environment

Walrus version: main a759852bcf5d1deeb57f8912f7bbf7e6cb26c2b6
UI version: dev-e848863

Additional context
Add any other context about the problem here.

Environment

Walrus version: main 3806cbeb980963a23e83bf42b8ac3b15c287fbba
UI version: dev-1f51d5e

Test Result:

Resource configuration update: pass
Latest run update on the overview: failed. During the upgrade process, the latest run information does not automatically update. It only updates after clicking to view the logs.

https://github.com/seal-io/walrus/assets/26084756/1c1fc3e0-b2b8-4237-97ef-90d24ccfdc65

Environment

Walrus version: main 66a2214c8ea5dfb7fd8542fecb5e87a3778fc07e
UI version: dev-4dd2e5a

Test Result: pass


Vim plugin is changing the color scheme

@felixblind mentioned:

When I use as :! command in vim, for example to run :! python % while kite is indexing the color scheme of my terminal (xterm) is scrambled up.

@felixblind do you mind sharing the contents of your ~/.vimrc file?

`if &compatible
set nocompatible "do not act like vi
endif
" Specify a directory for plugins (for Neovim: ~/.local/share/nvim/plugged)
call plug#begin('~/.vim/plugged')
Plug 'davidhalter/jedi-vim'
Plug 'ervandew/supertab'
" Plug 'Valloric/YouCompleteMe'
Plug 'tpope/vim-commentary'
Plug 'tpope/vim-surround'
Plug 'raimondi/delimitmate'
" tmux integration
" Plug 'benmills/vimux'
" Plug 'christoomey/vim-tmux-navigator'
" dispatch allows for compiling / running code in another tmux window
" Plug 'tpope/vim-dispatch'
" Plug 'jpalardy/vim-slime'
Plug 'benmills/vimux'
" Plug 'julienr/vimux-pyutils'
" Ale is a asynchronous linter
Plug 'w0rp/ale'
Plug 'wakatime/vim-wakatime'
"" Colors
" Plug 'flazz/vim-colorschemes'
Plug 'morhetz/gruvbox'
Plug 'leafgarland/typescript-vim'
Plug 'pangloss/vim-javascript'
Plug 'neovimhaskell/haskell-vim'
Plug 'jaspervdj/stylish-haskell'
" Initialize plugin system
call plug#end()
filetype plugin on "checks what file smt is
" matchit is a plugin which is shipped with vim, but not activated.
" Matchit enhances the functionality of the % command. When this plugin is
" enabled, the % command can jump between matching pairs of keywords.
runtime macros/matchit.vim
" setlocal tabstop=4
" setlocal softtabstop=4
" setlocal shiftwidth=4
" setlocal autoindent
setlocal fileformat=unix
"" vimscript the hard way
" easytags plugin: this just prevents highlighting for all file types. File
" types for which hightlighting should be enabled have to be whitelisted
" let b:easytags_auto_highlight = 0
" source ~/.vim/preferences/ycm.vim
" source ~/.vim/preferences/nerdtree.vim
source ~/.vim/preferences/ale.vim
source ~/.vim/preferences/statusline.vim
source ~/.vim/preferences/executive_settings.vim
source ~/.vim/preferences/jedi.vim
source ~/.vim/preferences/supertab.vim
"Folding
" set foldmethod=indent " Enable Folding
" set foldlevel=99
" " Enable folding with the space bar
" nnoremap  za
"" Save when losing focus
au FocusLost * :silent! wall
" restrict usage of some commands in non-default .vimrc files; commands that
" write to file or execute shell commands are not allowed and map commands are
" displayed.
set exrc
set secure
nnoremap vimrc :vsplit $MYVIMRC " quickly edit vimrc
nnoremap sv :source $MYVIMRC " quickly source vimrc
set nrformats=
set number
set relativenumber
if &term =~ '256color'
" disable Background Color Erase (BCE) so that color schemes
" render properly when inside 256-color tmux and GNU screen.
" see also http://snk.tuxfamily.org/log/vim-256color-bce.html
set t_ut=
" let base16colorspace=256  " Access colors present in 256 colorspace
" Allow color schemes to do bright colors without forcing bold.
set t_Co=256
" colorscheme desert
" colorscheme Tomorrow-Night
colorscheme gruvbox
let g:gruvbox_undercurl = 1
let g:gruvbox_termcolors = 256
let g:gruvbox_constrast_dark='soft'
let g:gruvbox_underline=1
" let g:gruvbox_color_column='red'
set background=dark
endif
set encoding=utf-8
set expandtab
set noerrorbells
syntax on
filetype indent plugin on
"Brackets
let delimitMate_expand_cr = 0
"
" turn off search highlight
nnoremap   :nohlsearch
let &t_SI = "<Esc>[6 q"
let &t_SR = "<Esc>[4 q"
let &t_EI = "<Esc>[2 q"
" set clipboard=unnamedplus
" searching
set incsearch           " search as characters are entered
set hlsearch            " highlight matches
set smartcase
set formatoptions+=j " Delete comment character when joining commented lines
set noshowmode
set showcmd
set title
set wildmenu  " visual autocomplete for command menu behaviour like in bash
set wildmode=longest,list
set autoread
set history=200
set backspace=
set nobackup
set noswapfile
" set backupdir=~/.vim_backup//
" set directory=~/Dropbox/.vim/swap//
" by default  and  do not filter the the command history
cnoremap
cnoremap
cnoremap
cnoremap
nnoremap   " F1 triggers the help
nnoremap Q  " Q starts ex mode
"nnoremap K  " brings up man page
set shortmess+=I " omits the starting message
" nnoremap Y y$
set splitbelow
set splitright
"set cursor
" let NVIM_TUI_ENABLE_CURSOR_SHAP=1
" gvim part
set guioptions-=T  "remove toolbar
set guioptions-=r  "remove right Scrollbar
set winaltkeys=menu
" Time out on key codes but not mappings.
" Basically this makes terminal Vim work sanely.
set notimeout
set ttimeout
set ttimeoutlen=10
" Make sure Vim returns to the same line when you reopen a file.
augroup line_return
au!
au BufReadPost *
\ if line("'"") > 0 && line("'"") <= line("$") |
\     execute 'normal! g`"zvzz' |
\ endif
augroup END
" allows buffers not to be saved when changing them
set hidden
" nnoremap  [b :w:bprevious
" nnoremap  ]b :w:bnext
" nnoremap  [P :w:bfirst
" nnoremap  ]P :w:blast
" Remember: if vim automatically saves when you switch a tab then there is no
" way back when editing to buffers at once.
nnoremap  [b :bprevious
nnoremap  ]b :bnext
nnoremap  [P :bfirst
nnoremap  ]P :blast
" ctags - automatic tags generation
:autocmd BufWritePost * call system("ctags -R --exclude=static --exclude=.git --languages=-sql --exclude=plugged")
nnoremap  h
nnoremap  j
nnoremap  k
nnoremap  l
set clipboard+=unnamedplus
nnoremap  [x :w:bdelete
nnoremap  [q :bdelete
" set completeopt=longest,menuone
`
I can also give you what's in the sourced files but the color specs are here.

I can't think why the Kite plugin would be scrambling your colours.  When the statusline says "Kite: indexing", Vim isn't doing anything in particular; the Kite helper process is running in its own process.
The plugin simply polls a status endpoint every 5s and updates the statusline with the result, e.g. "indexing", "ready", etc.  From Vim's point of view there isn't anything special about the indexing state.
I wonder whether it's to do with the Kite status changing from indexing to ready, at the same time as you run a program via :! which updates the status line area.  Perhaps Vim has some kind of bug updating the status line area when there's a race between a background timer and a foreground process.
I can't reproduce the problem which makes debugging tricky.  Ideally I'd start with an empty/default vimrc, and no other plugins, and add your configuration back in a little at a time until the problem started to appear.  But that might take a while and you probably don't want to do that!

The plugin has had a number of improvements in the past 18 months to prevent the screen getting garbled.  I'm going to close this now but please do open a new issue if you have any further problems.  Thanks!


Adding warning to mx/connect/stepChange

As per our conversation from last week, I'm adding a warning to the documentation for mx/connect/stepChange. It mentions that it for analytics purposes and not controlling user experience.

:shipit:


sudo processes

I'd like to run a process as super user. Is it possible for monu to ask credentials to run processes that need special permissions?

I actually have no idea how to implement this. I'm thinking if you launch Monu.app from the command line using 'sudo' it will inherit the sudoness for all spawned child processes, but even then i'm not sure that will work.
Ideally there would be some way to e.g. use Keychain to authenticate once and give permission to Monu to always spawn processes as sudo, but I have no idea how to do that or if that is possible

Me neither, I'm going to close this issue. Thanks anyway for your help.

No worries. I actually am gonna reopen just to see if anyone ever comes through with a suggestion of how they might implement this

@potomak You need to setup sudoers in order to allow to escalate rights without passing password.
So just run sudo visudo in command line and add line at the end of file
YourUserName   ALL = (root) /bin/commandToExecute
Then you can add to monu config sudo /bin/commandToExecute and command is executed as super user. For more info see http://osxdaily.com/2014/02/06/add-user-sudoers-file-mac/

@elmariofredo I think you need also to add the tag NOPASSWD.

@potomak yes you are right, totally forgot about it, so for others correct sudoers line is
YourUserName   ALL = (root) NOPASSWD: /bin/commandToExecute

Try this
https://www.npmjs.com/package/sudo-fn


Unreliable benchmark

I have my doubts that we can trust the benchmark in the root folder. It's result  varies from +421% to -319% when the same tests are running over and over again.
In the current Cherow the flow for parsing a false keyword is this
statement > assignment expr > condital > binary > unary > upate expr > lefthand expr > primary > member expr
It's a lot of branching happend too during this flow that should slow things down.
In current re-write the flow goes like this:
statement > primary > assignment with zero to none validations except for a few super fast binary checks.
The result in the benchmark should reflect this, but the results jumps up and down like a pig.
Look at attached screenshot. I can't classify this as stable.

My opionion is that if you cut down on all path to reach the goal - in this case the false keyword - it should be way faster than this. And same thing for the update prefix expression.

cc / @fkleuver

As seen in this code I pushed you can see it jumps stright to primary expr and memory expr.
But I doubt this has something to do with the benchmark itself.

Here is another example- Jumping from -70 to +70. And it's only a simple call expression.

@fkleuver Any ideas about this?

With call + rest element we got better results, before the benchmark goes crazy again

I'm re-open this because I found out the issues has to be related to this benchmark alone.
See screenshot. Parsing out ({}) - empty obj literal - should be way faster than object literal with properties and values. But in the benchmark, a empty object literal is way slower.

cc / @fkleuver

I should add to the story that the Cherow 2.0 version on master branch have few validations (something that should slow down the benchmark results) My locale 2.0 version have all validations and still should be faster than master branch.

This screenshot should prove it all. Locale 2.0 with all valiations is way faster than current master branch. It's correct. But look at the empty obj literal, and obj literal with simple identifier. The latter values jumps as a pig.

@KFlash We all know that no benchmark can ever be 100% reliable. The jumps have to do with V8 JIT.
The best thing to do here is try various iteration counts, run them a few times and see if any of them runs somewhat stable. There is no magic bullet.
If you look at the actual numbers (the microseconds per parse) they stay roughly within the same range but there are variations. You can analyze this as much as you want - there is no better way to do it unfortunately. You need to use some common sense here.
Try other iteration and rotation counts. Use averages. It's no different from the browser benchmarks which are far more unreliable.

Well. I now ran 668000 ops and empty object literal still slower. Even if I bail out early. Then tried again with empty array literal. Same thing.
Anyway. Closing this again.


Avoid using unspecified keyword args where possible

I believe that this change is necessary to make room for the compression API, and any other APIs we want to add in the future.

interop tests are failing:
Using polling engine: poll
/var/local/git/grpc/src/ruby/lib/grpc/generic/service.rb:171:in `initialize': unknown keyword: grpc.ssl_target_name_override (ArgumentError)

and ruby performance tests are timing out (possibly related).

The change looks good, will take another quick look after the issues are fixed.
Thanks for taking the time to remove the very very wrong concept of metadata keys as keyword args.

The interop tests are green, and so is everything else except for a couple of *san failures in core

LGTM.


[UI] Fix styling of Unauthenticated Modal

Current Behavior

When users are unauthenticated then see a modal that is shown for few seconds until users are redirected to login screen.
But the styling of the modal is little off where the icon and the title are mis aligned.

Desired Behavior

Improve styling of the title bar.
Screenshots/Logs

Environment

Browser: Chrome Safari Firefox
Host OS: Mac Linux Windows
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Platform: Docker Kubernetes

Contributor Guides and Handbook

🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

working on it!


content: test suite

Moves the implementation of the content store to separate package to allow usage of a test suite from a subpackage and keep clients from needing to import the implementation to use the interface. Additionally use the test suite for metadata and content fs tests. Additional tests still need to be added to make the suite more exhaustive.

Codecov Report

Merging #1228 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1228   +/-   ##
======================================
  Coverage    28.1%   28.1%
======================================
  Files          28      28
  Lines        2832    2832
======================================
  Hits          796     796
  Misses       1887    1887
  Partials      149     149

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3e572...a361977. Read the comment docs.

LGTM

@dmcgowan can you rebase this one?

LGTM


Rename/rebrand AntShares to NEO

https://bitcoinmagazine.com/articles/antshares-rebrands-introduces-neo-and-new-smart-economy1/

Thanks mate 🍺  👍


Refactored security package

Refactored security package. Currently, the CA will be initiated and not used.
Ping @Skarlso

Codecov Report

Merging #58 into master will decrease coverage by 0.19%.
The diff coverage is 68.42%.

@@            Coverage Diff            @@
##           master      #58     +/-   ##
=========================================
- Coverage   53.59%   53.39%   -0.2%
=========================================
  Files          14       14
  Lines        1196     1221     +25
=========================================
+ Hits          641      652     +11
- Misses        491      498      +7
- Partials       64       71      +7

Impacted Files
Coverage Δ

security/ca.go
71.15% <68.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a51f1...d99713c. Read the comment docs.

Good points @Skarlso 🤗


Workaround for #13084

This completely prevents Atom launched in a non-shell fashion from shelling out to grab missing environment variables. Since this is not a proper fix, but rather a band aid solution for what seems to be a deeper, underlying issue in Arch, I'm closing this PR.
Thanks for contributing!
/cc @atom/feedback

Thank you for your quick reply, but I think you have to reconsider this being an Arch related problem. As many users reported in #13084 this problem also happens in other Linux distros, including Ubuntu, and it's probably an issue within Atom itself.

Up until now, we have only been able to reliable reproduce, and verify that this affects users who have installed Atom via unofficial distributions; using AUR packages in Arch, and webupd8 PPAs in the case of Ubuntu.
Long story short, the AUR packages and the webupd8 PPA are not supported and currently apply unofficial patches to the Atom source code. Since we do not support these, we will not dedicate any resources to any directly related issues. In the case of Arch we only support installing from pristine, unpatched official source code downloaded from atom.io (or GitHub releases).


Update nodejs config for cognitive services

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-node

Automation for azure-sdk-for-python

Automation for azure-libraries-for-java

Waiting for @daschult to take a look...

Automation for azure-sdk-for-go

@daschult not much to see here but do you mind giving a review?


Update MD file on new branch 2017-22-19_19-11-19

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Disable a field of form

Hello.
In the documentation I see:
The attribute:

editorAttrs

And in the groups google, I read the option:

form.schema.name.editorAttrs.disabled = true;

But it doesnt work for me:
How can I disable a field of form ? And Can I do it of way dinamically  ?
Thanks in advance !

can we even edit any of the editorAttrs
this.form.fields.name.editor.$el.attr('data-placement', 'top');

Hi, you can specify the editorAttrs in the schema - https://github.com/powmedia/backbone-forms#main-attributes and you can manipulate the DOM however you like - Backbone Forms doesn't restrict you, but bear in mind, if a form re-renders, you may lose your changes.
Your best bet for setting the attributes is to set in the schema, if this is something that appears on multiple fields, consider specifying your own template: https://github.com/powmedia/backbone-forms#customising-templates


Identifiers validation failed for dataset Catálogo taxonómico y biogeográfico de los radiolarios (orden Polycystina) de la región central y sur del Golfo de California

Identifier validation failed for the dataset Catálogo taxonómico y biogeográfico de los radiolarios (orden Polycystina) de la región central y sur del Golfo de California:

Crawler attempt: 326
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 5919
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 5919 total records; 5919 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3740090/step

New IDs sample:

Old IDs sample:

00063a6137f51643f1901e3151f7c51a
00b1b4d0a6682133126e3a4641b28a46
02e8d5a94c1d62471d13cdb8cfc72695
038093cf0101882e17f0c532d3c736e2
03e5014947790bb7587af9cb1cbfbcd8
03f34c71d78a982dca2558d267d7eb16
04181a8fe07214d7b436bd89eecd05c7
0440ddc88497ed9bb8f6957285b7c837
044abe5cab6580a44872991c0bfa52ad
047418d22936391a487b25e232d01442

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Catálogo taxonómico y biogeográfico de los radiolarios (orden Polycystina) de la región central y sur del Golfo de California : https://doi.org/10.15468/deskcm.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Catálogo taxonómico y biogeográfico de los radiolarios (orden Polycystina) de la región central y sur del Golfo de California:

Crawler attempt: 327
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 5919
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 5919 total records; 5919 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3741031/step

New IDs sample:

Old IDs sample:

00063a6137f51643f1901e3151f7c51a
00b1b4d0a6682133126e3a4641b28a46
02e8d5a94c1d62471d13cdb8cfc72695
038093cf0101882e17f0c532d3c736e2
03e5014947790bb7587af9cb1cbfbcd8
03f34c71d78a982dca2558d267d7eb16
04181a8fe07214d7b436bd89eecd05c7
0440ddc88497ed9bb8f6957285b7c837
044abe5cab6580a44872991c0bfa52ad
047418d22936391a487b25e232d01442

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Catálogo taxonómico y biogeográfico de los radiolarios (orden Polycystina) de la región central y sur del Golfo de California : https://doi.org/10.15468/deskcm.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.


Consul container not starting

When running the OS for the first time I can see that the docker container for consul is not starting:
$ docker ps
CONTAINER ID        IMAGE                COMMAND                  CREATED              STATUS                         PORTS                    NAMES
3528081eb5dc        hypriot/rpi-swarm    "/swarm manage consul"   About a minute ago   Up About a minute              <IP_ADDRESS>:2378->2375/tcp   bin_swarmmanage_1
db3898d5fc5f        hypriot/rpi-consul   "/consul agent -serve"   About a minute ago   Restarting (1) 9 seconds ago                            bin_consul_1
7d9b0936d53e        hypriot/rpi-swarm    "/swarm join --advert"   About a minute ago   Up About a minute              2375/tcp                 bin_swarm_1

So i  did docker logs bin_consul_1 to see what was happening :
==> Error starting agent: Failed to get advertise address: Multiple private IPs found. Please configure one.
==> WARNING: BootstrapExpect Mode is specified as 1; this is the same as Bootstrap mode.
==> WARNING: Bootstrap mode enabled! Do not enable unless necessary
==> Starting Consul agent...
==> Error starting agent: Failed to get advertise address: Multiple private IPs found. Please configure one.

I'seen on the blog's comment that I am not the only one with this issue.

@rllola Could you please check which version of Consul you are running on your cluster nodes?
Executing docker run -ti --rm hypriot/rpi-consul --version should output the version info.

@Govinda-Fichtner As reported in gitter chat, changing the cluster-start to include rpi-consul:0.5.0 instead of rpi-consul resolves this error.

OK. Well the problem is that we did not neither updated the Cluster Lab sd-card image nor the deb package.
In https://github.com/hypriot/cluster-lab/blob/master/package/usr/local/bin/cluster-start.sh#L140 we already fixed it. Version 0.6.0 of Consul should work, too.
/cc @firecyberice @MathiasRenner Could that be? If yes, we need to update those soon to prevent further confusion.

Hi @Govinda-Fichtner
$ docker run -ti --rm hypriot/rpi-consul --version
Consul v0.6.3
Consul Protocol: 3 (Understands back to: 1)

@MariusRumpf +1 Changing for 0.5.0 did fix it.

@rllola Ok. As I expected.
To fix this change the following file on each node
/usr/local/bin/cluster-start.sh
similar to this
https://github.com/hypriot/cluster-lab/blob/master/package/usr/local/bin/cluster-start.sh#L140
Afterwards do a cluster-stop.sh followed by a cluster-start.sh on each node starting with the first one you switched on. Give the first enough time to completely run cluster-start.sh before you do the same on the other nodes.
This is just a workaround for you till we fixed the Cluster Lab sd card image and the debian image.

Thank you guys so much for your feedback!
The SD card image is now updated to consul 0.6.0 with an additional minor change such that it should work better now. At least for Govinda and me it's just fine now.
Do you have a chance to test if this version works for you as well?
https://github.com/hypriot/cluster-lab/releases/

+1
I have tested the new release and it works fine ! Thank you.
You should also update your blog article so it use the new release.
New command line
$ flash --hostname cl-master https://github.com/hypriot/cluster-lab/releases/download/v0.1.1/hypriot-rpi-20160121-235123.img.zip
$ flash --hostname cl-node-1 https://github.com/hypriot/cluster-lab/releases/download/v0.1.1/hypriot-rpi-20160121-235123.img.zip

So in the future people won't have this issue.

@rllola Thank you for the feedback, awesome! The download link in the blog post is up to date now.
@MariusRumpf I moved the download of the SD card image to our blog post because this repo does not build the SD card image but only the DEB package. All links are updated, following them should be just fine.


Case sensitive column names in DI SQL destinations

Description

Users have reported not being able to use case sensitive column names on SQL destinations in Data Integration pipelines. ( Slack threads example-1 and example-2 )
To fix this, the optinal config lower_case was added. If set to False, the requested Destination will allow for case sensitive column names when executing all clean_column_name functions.
This PR adds this feature to the following destinations:

Snowflake
PostgreSQL
Redshift
OracleDB
MySQL
MSSQL
BigQuery

How Has This Been Tested?

Unittests were created at mage_integrations/tests/destinations folder.
These tests cover build-table enforcing case sensitive queries.
Checklist

[X] The PR is tagged with proper labels (bug, enhancement, feature, documentation)
[X] I have performed a self-review of my own code
[X] I have added unit tests that prove my fix is effective or that my feature works
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation

cc:
@wangxiaoyou1993

As a side note: From our side we would want the lowercase-flag to apply both to column names and table names


[7.1.0] Add note about mock service sub context

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

Fixes https://github.com/wso2/docs-ei/issues/1854

Add PRs for other branches: https://github.com/wso2/docs-ei/pull/2581, https://github.com/wso2/docs-ei/pull/2583


Task - Put latex github action onto our

Description
Customize the action on when it runs
Definition of Done

manual action? look into that

Link to tutorial videos is here:
https://mcmasteru365-my.sharepoint.com/personal/smiths_mcmaster_ca/_layouts/15/onedrive.aspx?id=%2Fpersonal%2Fsmiths_mcmaster_ca%2FDocuments%2FCapstoneVideos&ct=1727880009776&or=Teams-HL&ga=1


[AIRFLOW-170] Add missing @apply_defaults

Adds missing @apply_defaults decorator, ensuring default config values flow through to the operator.

LGTM

Not sure about removing os, is it not needed? This seems like an unrelated change.

@artwr Yeah, that shouldn't have been in the original commit. Bad copy-paste from a work-in-progress file elsewhere.

LGTM as well


chore(deps): update terraform terraform-ibm-modules/cos/ibm to v7.1.2

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cos/ibm (source)
module
minor
7.0.7 -> 7.1.2

Release Notes

terraform-ibm-modules/terraform-ibm-cos (terraform-ibm-modules/cos/ibm)
v7.1.2
Compare Source
Bug Fixes

fix bug in kms_guid validation (#484) (94f2852)

v7.1.1
Compare Source
Bug Fixes

make kms_guid optional in fscloud bucket_configs input variable. its only required if creating a KMS auth policy (#483) (244828f)

v7.1.0
Compare Source
Features

added the ability to skip KMS auth policy creation in both the buckets and fscloud profile submodules by adding a new optional option skip_iam_authorization_policy in the bucket_configs input variable. The default value for this is false. (#482) (73d5e8e)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.0.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Buildin defines description

Need describe all build-in compiler defines such as haxe_ver and its usage
(e.g.: #if haxe_ver > 3.1 ... #end).
Need describe the behaviour when we use any library from Haxelib we automatically have new define with same name. For example we using -lib foo and can get true in #if foo ... #end.

I think it can be there.

@markknol: Didn't you add that?

This one? http://haxe.org/manual/lf-condition-compilation-flags.html

Yeah!
That's in a bit of an awkward section. Should be somewhere under compiler usage as suggested.

-D my_var=4 is compiler usage, #if my_var is a language feature?

Yes
Compiler defines are not strictly related to conditional compilation. While conditional compilation without defines doesn't make much sense, compiler defines have other effects as well. Conditional compilation should certainly link to the defines, but the defines section should be under compiler usage.

Also I mean buildin "autodefined" defines. For example
For Flash target:

flashX(X_X) = 1 e.g. flash9/flash10/flash11_9 - automatically created by setted -swf-version XX.X. Generating starts from version passed to -swf-version and down to flash9 and all will be equal 1;

For all targets:

haxe2 = 1 for Haxe 2.X
haxe3 = 1 for Haxe 3.X
haxe_ver = X.X0X e.g. 3.201 for Haxe v.3.2.1 and 3.1 for Haxe v.3.1.0;
true = 1 (yes!)
libname = X.X.X for each used Haxelib-library (-lib libname / -lib libname:X.X.X);
sys = 1 for static targets excluding flash;
target-name = 1 e.g. for Javascript will be js / for C++ - cpp;
hxcpp_api_level = 321 (really for all targets);

Also for all targets:

macro = 1 in compile-time when macro executing;

if a value = 1, that mostly means it is true so it might be not needed to mention that it is "1".
Would it be an idea to add a new table after the almighty table? Something like this:
auto defined flags
These values are automatically defined on each target by the Haxe compiler.

flag
description

haxe-ver
The current Haxe version value. E.g. 3.201 for Haxe v.3.2.1 and 3.1 for Haxe v.3.1.0

libname
version number or each used Haxelib-library (-lib libname / -lib libname:X.X.X)

haxe3
True if the Haxe version is 3.x

haxe2
True if the Haxe version is 2.x

sys
True if running in static target context, excluding Flash.

js
True if running in Javascript context

as3
True if running in as3 context

swf
True if running in swf context

python
True if running in python context

csharp
True if running in csharp context

cpp
True if running in cpp context

php
True if running in php context

macro
True if running in macro context

If a flag is defined, the value equals 1

Oh my stupid mistake: sys : Defined for all system platforms. (from -help)
as3 : Defined when outputing flash9 as3 source code;
"xxx | True if running in xxx context" isn't totally understandably. Maybe "target is xxx" or "compiling/outputting (to) xxx" is more clearly?

swc | True if Flash & ext of output file is .swc (-swf lib.swc)

Those are good additions.

@simn do you have a better wording to describe the target defines?

I kinda like the context description. "True if compiling to target" works too though.

And one addition.

lib name | version number or each used Haxelib-library (-lib libname / -lib libname:X.X.X)

This isn't a number. It's a string and that fact is important because we can't work with this define as with haxe-ver for example:
// used library "mylib" version = 0.4.6
#if (mylib > 0.4)
// never going to happen
#end

// always have to work with it as string:
#if (mylib == "0.4.6")
trace("YES");
#end

I think this fact should be strongly noted.

In this example

version number or each used Haxelib-library (-lib libname / -lib libname:X.X.X)

I tried to visually highlight the identity of version (X.X.X) with the value of the define.
IMO, then it should look like this:
" version string or each used Haxelib-library (-lib libname / -lib libname:version) "


Kotlin: 102. Binary Tree Level Order Traversal

File(s) Modified: 102-Binary-Tree-Level-Order-Traversal.kt
Language(s) Used: Kotlin.
Submission URL: _https://leetcode.com/submissions/detail/779272300/_

Thanks, @MaratKhakim!


Improve readability of table

Thank you! This is definitely going to get styled soon but thanks for now.

Thank you! This is definitely going to get styled soon but thanks for now.

 Sure, it was a really quick improvement.

 Sure, it was a really quick improvement.


Generate Site JSON for nodes running on UBOS instead of hard-coding

Depends on #254 and #256 and #257.

Done in #252


Support GPT2 architecture

As simple as that, please!

Sorry for taking a while to respond. I really didn't see much of a point TBH, but then I added support for the new Granite models and it turns out they're basically GPT2 anyway.
So GPT2 is supported on the dev branch now, and from v0.0.21 when I'm ready to release.


[Service Bus] Verify receiver close() handling mechanism in case of network disconnect and reconnect

Steps to reproduce:
Close during detach

Create a receiver and start streaming messages using the receive call
Disable and then enable network connection
When the receiver is being recovered, call receiver.close()

Depending on which point in time the close() is invoked, document the different expected behaviors and verify the behaviors are as expected. The concern for these corner use-cases has come up as part of https://github.com/Azure/azure-sdk-for-js/issues/1730

Please note that since we don't have tests currently to test the reconnecting feature, it is not trivial to exactly reproduce the issue being discussed here using tests or samples
One way I can think of to simulate this scenario is to replace the line
await streamingReceiver.detached(error)

at https://github.com/Azure/azure-sdk-for-js/blob/%40azure/service-bus_1.0.0-preview.2/sdk/servicebus/service-bus/src/clientEntityContext.ts#L192 with the below
const detachedPromise = streamingReceiver.detached(error);
const closePromise = streamingReceiver.close();
await Promise.all([detachedPromise, closePromise];

This closely replicates the scenario of receiver being closed by the user when detached() was called on it.
And the actual fix to the problem is to not add credits at https://github.com/Azure/azure-sdk-for-js/blob/%40azure/service-bus_1.0.0-preview.2/sdk/servicebus/service-bus/src/core/messageReceiver.ts#L792 in such scenarios

Please note that since we don't have tests currently to test the reconnecting feature, it is not trivial to exactly reproduce the issue being discussed here using tests or samples

And the actual fix to the problem is to not add credits at https://github.com/Azure/azure-sdk-for-js/blob/%40azure/service-bus_1.0.0-preview.2/sdk/servicebus/service-bus/src/core/messageReceiver.ts#L792 in such scenarios

Got it, added changes to make sure detach() doesn't reconnect when receiver is explicitly closed by user.
Added a flag to track this.
It seems like detach() (a.k.a reconnect) is not completely implemented yet, as it is only being used in streaming receiver for non-sessions.
Changes similar to this would need to be factored in as we expand the scenarios entailing network disconnect.
@ramya-rao-a @ShivangiReja @AlexGhiondea

Closed with https://github.com/Azure/azure-sdk-for-js/pull/2442


PEP8 review

Hi, I'm Elmer
I modify your code to adapt on PEP8 style. This makes your code more readable, specially on the documentation.

Hi Elmer,
I am sorry for the late response to your contribution.
Thank you for adapting PEP8 for rainymotion! Looking forward to receiving your pull requests again :+1:
Best regards,
Georgy


class RewriteRelation should contain a reference to the startState

Right now, it only has a finalState. Besides, the executionGraph is really a chain rather than a general graph.

This class contains a lot of code that was relevant to the old debugger. Since the debugger has fallen out of use, the java backend can be refactored to not use RewriteRelation at all.

There are several places in the java backend refer to RewriteRelation, even in the Executor interface. If this class belongs to the old debugger and you don't plan to bring it up to date with the new debugger, I would like to remove such dependency gradually. What do you think?

The new debugger doesn't need anything backend specific. Please feel free to remove that dependency, or any dependency in the java backend exclusive to the debugger for that matter. The only thing that can break stuff can be a change to the Rewriter interface. As long as the interface and the implementing classes (SymbolicRewriterGlue.java in the case of the java backend) do what they're supposed to, cleaning up shouldn't be an issue. Thanks.


A TypeError is raised when the sum of values is 0

Describe the problem
The pie rendering fails when the sum of values in a pie is equal to 0.
Steps to reproduce the problem
TTY::Pie.new(data: [{ name: "DOGE", value: 0 }], radius: 2).render
=> TypeError: no implicit conversion from nil to integer

As a possible spec:
  it "renders an empty pie chart when all values are 0 " do
    data = [
      { name: "BTC", value: 0 },
      { name: "BCH", value: 0 },
      { name: "LTC", value: 0 }
    ]
    pie = TTY::Pie.new(data: data, radius: 2)

    output = pie.render

    expect(output).to eq([
       "            • BTC 0%\n",
       "         ",
       "            • BCH 0%\n",
       "         ",
       "            • LTC 0%\n"
    ].join)
  end

Which results in the following failure
  1) TTY::Pie#render renders an empty pie chart when all values are 0
     Failure/Error: item = items[select_data_item(angle, angles)]

     TypeError:
       no implicit conversion from nil to integer
     # ./lib/tty/pie.rb:143:in `block (2 levels) in render'
     # ./lib/tty/pie.rb:141:in `each'
     # ./lib/tty/pie.rb:141:in `block in render'
     # ./lib/tty/pie.rb:136:in `each'
     # ./lib/tty/pie.rb:136:in `render'
     # ./spec/unit/render_spec.rb:83:in `block (2 levels) in <top (required)>'

Actual behaviour
An exception was raised
Expected behaviour
Either an empty pie or at least an empty string.
Describe your environment

OS version: RHEL 7.9
Ruby version: 3.0.1
TTY::Pie version: 0.4.0 & master

Sorry
Sorry, somehow I am having very unusal trouble to push a merge request which at least contains the mentioned spec to reproduce. Therefore I won't do this (now).
Thanks
Thank you very much for all your tty efforts. I love them all.

Thank you for reporting this issue! Nicely spotted edge case.

@stillhart This is fixed now and ready for checking when you have a minute. I'll make a release shortly.


[Feature-6930] [Python]Add workflow as code task type sub_process

#6930

Codecov Report

Merging #7022 (057f578) into dev (a8aed0f) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #7022      +/-   ##
============================================
- Coverage     32.67%   32.61%   -0.07%
+ Complexity     1607     1605       -2
============================================
  Files           431      431
  Lines         14340    14340
  Branches       1437     1437
============================================
- Hits           4686     4677       -9
- Misses         9203     9213      +10
+ Partials        451      450       -1

Impacted Files
Coverage Δ

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
47.27% <0.00%> (-7.28%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8aed0f...057f578. Read the comment docs.

@zhongjiajie I had submit a PR,looking forward to your review and merge.

Good job! 👍  I would take a look right now!

BTW, Do you mind to add me wechat @devosend ? my wechat id is `zhongjiajie955, maybe we could discuss our workflow-as-code‘s future

I change code for your advice, re-review please! @zhongjiajie

BTW, to target specific issue from PR, we recommend use keyword fix: #issue_id or close: #issue_id or closes: #issue_id in your PR describe(not title). I would not only connect issue to PR but also close issue automatically when PR is be closed.

Oh I got it and thanks @devosend to clarification 👍 , this because parent class init before taskParam class init, and we need attribute process_definition in taskParam, it would cause cycle dependence

@devosend Please mentioned me if you submit new commit to this PR

@zhongjiajie I modified the code, re-review please.


reset app by db.dropDatabase() now can't deploy!

i was trying to reset my app that was deployed with mupx and i found this question/answer on stackoverflow
@arunoda answered the question, saying to use db.dropDatabase() -- since it was arunoda giving the advice, i followed it.  now i can't deploy my app!
i'm using the local mongodb, not compose or mongolabs, and when i look at the docker processes my mongodb image is constantly Restarting
i've tried removing the images, containers, and even docker itself, but i can't get mongodb to start up.
the app is deployed on AWS and was working fine until i db.dropDatabase() last night.
any help is appreciated here.
:~$ docker ps -a
CONTAINER ID        IMAGE                      COMMAND                  CREATED             STATUS                         PORTS                        NAMES
9bf26e959ee2        mongo                      "/entrypoint.sh mongo"   11 hours ago        Restarting (100) 3 hours ago   <IP_ADDRESS>:27017->27017/tcp   mongodb

I just added a pull request to resolve that.
Anyway you can remove /var/lib/mongodb/mongod.lock
Also you can run setup after that to be sure but then if you run setup run deploy again too.


Create upversioning utility to upgrade schema and test messages version

A tool to change the version in test messages/examples.
Introduces the $id annotation into schema files, and uses it so schema files are tagged with the version.
Uses a combination of a list of files to upgrade and a list of files to ignore, so any new files must explicitly be added into either at the time of running the utility.
Usage: bin/upversion NEW_VERSION

What's the functional intent behind it (the $id field you have) -- what is
it intended to be used for?  B/c if it has anything to do with
"versioning" specific to (e.g.) 1.4.0 I'd want it more explicit. An $id
would only be useful as a unique identifier, not with semantics. E.g., if
we replaced it with the sha512 hash of the string, would it still work for
its intended purpose?
On Mon, Oct 10, 2022 at 6:28 AM Noureddine @.***> wrote:

@grafnu https://github.com/grafnu re the $id field I took it from JSON
Schema docs
https://json-schema.org/understanding-json-schema/basics.html#declaring-a-unique-identifier
as the closest thing to a "version" attribute which it lacks.
We could just add our own, either $version or $UDMI, with just the value
being just the version (e.g. 1.4.0)
—
Reply to this email directly, view it on GitHub
https://github.com/faucetsdn/udmi/pull/477#issuecomment-1273313605, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIEPDYQF3Q2DYUEKRZSULDWCQKW5ANCNFSM6AAAAAAQ6MRHWY
.
You are receiving this because you were mentioned.Message ID:
@.***>

The intention behind the addition was to have some reference of the version of UDMI (e.g. 1.4.0) when looking at the schema, because without doing anything git related, it's not possible to tell which version it relates to. This is trying to address some issues people have had.
Removing the semantic information from the value of $id, it would no longer meet this specific purpose.

Ok, in that case I'd suggest something like "$udmi_version" -- the reason
is I wouldn't want to have to parse the larger $id string to try and
extract the semantically meaningful value -- as it makes that too brittle.
So, if we know the thing we're looking for (i.e. UDMI version) then let's
just call that out explicitly!
On Tue, Oct 11, 2022 at 5:22 AM Noureddine @.***> wrote:

The intention behind the addition was to have some reference of the
version of UDMI (e.g. 1.4.0) when looking at the schema, because without
doing anything git related, it's not possible to tell which version it
relates to. This is trying to address some issues people have had.
Removing the semantic information from the value of $id, it would no
longer meet this specific purpose.
—
Reply to this email directly, view it on GitHub
https://github.com/faucetsdn/udmi/pull/477#issuecomment-1274599266, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIEPD7MQUE3DXIOU4XRTGLWCVLXHANCNFSM6AAAAAAQ6MRHWY
.
You are receiving this because you were mentioned.Message ID:
@.***>

CI Run here
I can split the tool and the upversion to 1.4.0, but thought to leave it as an example of what exactly it does


[crypto & al] Direct signing/verification for values

What this does
We used to do:
let hash = msg.hash()
private_key.sign_message(hash)
signature.verify_msg(hash, public_key)
public_key.verify_msg(hash, signature)

Now we do:
private_key.sign(&message)
signature.verify(&message, public_key)
public_key.verify(&message, signature)

Throughout the code base.
Why was it this way?
Long story short: domain separation & weaknesses in serialization engine. We bypassed serialization (which was ambiguous, as of a while ago) and had a very specific way of constructing a hash value, which was sha3(sha3(domain_separation_bytes) || serialized_object_bytes), and then you signed that HashValue. See libra_crypto::hash::CryptoHasher for the domain separation details.
What are the signed bytes now?
We automatically derive them for you, but they're sha3(domain_separation_bytes) || serialized_object_bytes.
So signing is handled for existing structs. What do I do if I want to define MyFancyStruct ?
use libra_crypto_derive::{CryptoHasher, LCSCryptoHash}

#[derive(Serialize, Deserialize, CryptoHasher, LCSCryptoHash)]
pub struct MyCryptoSignableCustomThingy {
...
}

priv_key.sign(my_crypto_signable_custom_thingy)

Is this in specs?
It's upcoming. The older signing/verification isn't there yet.
Why is this better?
It's simpler and more secure (you might pass the wrong hash in code, it's even a crypto gotcha).
Why is this worse?
Serialization is now on the critical path for signing / verification operations, which are exposed as infallible. Serialization can fail in some edge cases, so now they can panic. There's no clean way of recovering from this sort situation, but we are committed to and have a plan to push serialization failures into a never-visited corner (see e.g. #4928).
What's left?
See above re:spec.  It's my very next item.

:umbrella: The latest upstream changes (presumably 7aa345055c1baa3a28d0c25813014eeaf7946c2a) made this pull request unmergeable. Please resolve the merge conflicts.

@huitseeker Can you update the swiss-knife README.md before you land?

@bors-libra r=ankushagarwal

:pushpin: Commit bd6c45d has been approved by ankushagarwal

:hourglass: Testing commit bd6c45d21d47fbb63ba86a5563bbe42873679193 with merge 13290dfe419a751bd12ba1ce52b18267f13a74d8...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: ankushagarwal
Pushing 13290dfe419a751bd12ba1ce52b18267f13a74d8 to master...


Authorization not correctly working for stitched, local schemas

Describe the bug
When using schema stitching, and adding built schemas (i.e. not over HTTP) to the schema stitching builder, the authorization middleware/directive that is registered with the sub-schemas is not applied correctly, and causes the AUTH_NOT_AUTHENTICATED error to be thrown in all cases (with auth, without auth, with correct role/policy, without correct role/policy).
To Reproduce
Steps to reproduce the behavior:

Build 2 distinct schemas similar to the following:

var schema1 = HotChocolate.SchemaBuilder.New()
    .AddDocumentFromString(schema1Content)
    .AddAuthorizeDirectiveType()
    .BindComplexType<GraphQL.Schema1.Query>(t => t.To("Query"))
    .BindComplexType<GraphQL.Schema1.Mutation>(t => t.To("Mutation"))
    .Create();
var schema2 = HotChocolate.SchemaBuilder.New()
    .AddDocumentFromString(schema2Content)
    .AddAuthorizeDirectiveType()
    .BindComplexType<GraphQL.Schema2.Query>(t => t.To("Query"))
    .BindComplexType<GraphQL.Schema2.Mutation>(t => t.To("Mutation"))
    .Create();

Stitch the schemas together:

services.AddStitchedSchema(builder => builder
    .AddSchema("schema1", schema1)
    .AddSchema("schema2", schema2);

Make sure you are using the authorize directive in one of the schemas, e.g.

type Profile {
  email: String!
  firstName: String!
  id: Int!
  lastName: String!
}
type Query {
  profile: Profile @authorize
}

Make sure you are using services.AddAuthorization(...) and services.AddAuthentication(...) in Startup's ConfigureServices, and app.UseAuthentication(); in Configure (before the call to app.UseGraphQLHttpPost(...))

Expected behavior
Authorization to be correctly applied.
Desktop (please complete the following information):

Framework: ASP.NET Core 2.2 (netcoreapp2.2)
HotChocolate Packages, all version 10.2.0:
"HotChocolate"
"HotChocolate.Stitching"
"HotChocolate.AspNetCore"
"HotChocolate.AspNetCore.Playground"
"HotChocolate.AspNetCore.Authorization"

Additional context

Changing services.AddStitchedSchema(...) line above to services.AddGraphQL(schema1) DOES apply the authorization flow as expected, it seems to be only when combined with stitching that this issue presents itself
I've added a QueryRequestInterceptor and logged out the context.User which is correctly set from the asp.net authorization flow
I've added middleware in AddSchemaConfiguration to explicitly set context.ContextData[nameof(ClaimsPrincipal)] which appears to be the field the directive middleware uses, but it still throws the same error.

I'm really liking HotChocolate so far, however I'm struggling to get this piece in particular working. I might be "using it wrong" so please feel free to correct me. I could create a repro of this in a small repo, please let me know if this isn't clear (or clearly the wrong approach) and i can do this.
I've tried to find an existing issue around this and must say, your team has been great with getting back to everyone and supporting the community.
This partly relates to tickets like #1231 . I also saw mentioned in #1228 that theres an "interceptor" i might need to have configured, but couldn't find further information on that.

Hi @barticus,
thanks for this detailed issue. The cause for this is that the authorise directive need the claims principal in the execution context.
When stitching over HTTP you would basically pass on an auth token or create a new auth token to the remote schema in and then the claims principal would be associated with the execution context.
In the case when we use in-memory schemas this does not happen.
I will have to check how we can enable this, I honestly did not think about this scenario so far :)

Thanks @michaelstaib for the prompt response.
I thought it might be something along those lines. I could see examples for passing along the headers for HTTP stitching, but couldn't see any notes on whether there was extra work for local schemas.
As mentioned, I had a go at writing some custom middleware/request filler to pass the user along, but couldn't get it working. I could write my own authorizer directive that loads the user from the http context accessor, but just wasn't sure if I was just heading down the wrong path.
Cheers.

Hi, I'm also running into this problem. Is there a workaround or a plan to fix the issue?

Not yet. But a fix is planed ... I am marking this as a bug since we already know what it is.

As a work around, I copied the code for the authorize directive and changed it so it was using HttpContextAccessor rather than trying to get the principal from the context.
I would post that here but I think in the end I changed tactics and decided not to use stitching and just use multiple calls to "AddDocumentFromFile" as I wasn't trying to do anything complicated that needed stitching (and it is more for schemas over http, not local)

Following as I have the same issue.

@michaelstaib, believe this has been fixed on 10.5.0-preview.9 if you want to mark it as such.

This is fixed in preview 9... lets close the issue :)


[Misc]: optimize eager mode host time

in my eager mode testing, this func brings a lot host duration time, which slight damaging performance
using numpy to get some accelerattion
compare of running time of func: make_tensor_with_pad
tested on : Intel(R) Xeon(R) Platinum 8358 CPU @ 2.60GHz
before:
debug block talbs:  11    128   max_len:  128
debug make blocktable tensor time:  0.0983159989118576  ms
debug block talbs:  11    128   max_len:  128
debug make blocktable tensor time:  0.09891018271446228  ms
after:
debug block talbs:  11    128   max_len:  128
debug make blocktable tensor time:  0.0807461328804493  ms
debug block talbs:  11    128   max_len:  128
debug make blocktable tensor time:  0.08287793025374413  ms

thanks, looks good to me

Thanks for the optimization! It's quite overdue but I have merged this PR now.


Unicode

Currently, a fairly restricted set of ASCII characters can be used for atoms. This is unnecessarily restrictive. We can be more permissive about what symbols are used for atoms by dividing characters into the following buckets:

Whitespace
Special characters  . # ( ) ~ @ ‘ `
Digits, specifically ASCII 0-9
Everything else.

Special characters MAY be used in atom names in certain combinations allowed by the lexer. Digits can be used except in the first character of the atom name. Whitespace can only be used via the "fuse" trick shown in the docs. All other “runes” are fair game for atom names.
Adapt the current lexer and parser to follow these rules for atom names.

One problem remains:
> (split '水果)
(� � � � � �)
>

Fixed:
> (len (split '水果))
2
> (split '水果)
(水 果)
>


Removing selected facet doesn't work

Clicking the X next to a selected facet should remove that facet from the query. Instead, nothing happens.

The fix for this bug is now live.


Type Error "Arguments list has wrong type" in Chrome 16.0.912.63 m, Windows 7 64 bit

PDF.JS Build: 6a0dd63
Message: Function.prototype.apply: Arguments list has wrong type
Stack: TypeError: Function.prototype.apply: Arguments list has wrong type
at Function.APPLY_PREPARE (native)
at Object.RadialAxial (http://localhost:8080/pdf-reader-web/js/pdf.js:24484:38)
at Function.pattern_shading [as parseShading] (http://localhost:8080/pdf-reader-web/js/pdf.js:24425:16)
at Object.partialEvaluatorGetIRQueue [as getIRQueue] (http://localhost:8080/pdf-reader-web/js/pdf.js:11895:41)
at Object.partialEvaluatorGetIRQueue [as getIRQueue] (http://localhost:8080/pdf-reader-web/js/pdf.js:11859:22)
at Object.pageGetIRQueue [as getIRQueue] (http://localhost:8080/pdf-reader-web/js/pdf.js:224:33)
at Object.wphSetupPageRequest (http://localhost:8080/pdf-reader-web/js/pdf.js:26926:24)
at DedicatedWorkerContext.messageHandlerComObjOnMessage [as onmessage] (http://localhost:8080/pdf-reader-web/js/pdf.js:26853

Hi can you please provide a link to the broken PDF?

@arturadib thanks.
Steps to produce:

download the PDF: http://www.liferay.com/documents/31578/11925632/sample.pdf
open http://mozilla.github.com/pdf.js/web/viewer.html in the Chrome
browse the downloaded PDF

I believe this is the issue with apply and typed arguments.  This will be resolved in an upcoming release of chrome.  I tested with 17 and it seems to be working fine now.

Closing for now, please reopen if issue is not resolved with Chrome 17.


Precompiled binaries for windows

Is there any plans to 'embed' precompiled libsass library into the gem, to make installation on windows more user-friendly
Thanks

Yes, this will be in the next release (for mingw only, not mswin).

Version 2.1.0.pre2 released.  Please give it a test!

Works for me, thanks


provided short description for a link

provided short description for "About CODEOWNERS link" and grammatically checked and corrected the document.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@raisedadead What about this one?


Allow for more permissive date parsing

Allow for no time passed i.e. "2020-09-22"
Allow for partial time i.e. "2020-09-22 16:24"
Add testing coverage

More generally (separators can be anything):
US format:  year-month-day [hour][-min][-sec][-millis]
EU format:  year-day-month [hour][-min][-sec][-millis]
This should not impact performance as we are still not using datetime.strptime, https://github.com/DataStax-Toolkit/sperf/pull/22. Additional overhead should be negligible.

Ok this is interesting and a real need (cause users have a very long tail of custom log formats), but the approach is slightly hackier than the hacky approach that was there prior (my fault), so rather than silently ignoring the timestamp, parsing we need to flip it on this mode explicitly (the silent pass in the except is a red flag), and we can even suggest that flag in the error message and communicate the date format as it was sent
The main thing I want to avoid and have seen too often is this parsing the wrong time and spitting out seemingly correct results that are very wrong. sperf search filltercache is the most immediate thing that comes to mind as very time sensitive and no result is better than a wrong result as it can lead to very bad tuning signals.

Added in some better error handling on the date parsing.
So one thought I had to help prevent confusion with how the datetime parsing works is to print the start/end/before/after values are when set on each subcommand. This would need to be added on each command unfortunately, but it would help the user see if a bogus value slipped in, or if they needed to refer back to an output, they would see the passed datetime value they gave as a parameter. On some of the commands we print the first log line and last log line which I think is a little misleading given a user may have requested analysis on a sub range. This could either be done in a separate PR, or I could work on that here. My vote would probably be separate.
As an example, this is the current output:
sperf -pt core statuslogger -st "2020-08-09" -et "2020-08-10 10:30"
................................................................................................sperf core statuslogger version: 0.6.5

Summary (2,685,647 lines)
Summary (0 skipped lines)

dse versions: unknown
cassandra versions: unknown
first log time: 2020-08-09 22:46:52.937000+00:00
last log time: 2020-08-10 01:37:34.289000+00:00
Nothing found!

We would want to include separate lines for the start/end time like so (needs work on the naming, just not creative atm):
first log time: 2020-08-09 22:46:52.937000+00:00
last log time: 2020-08-10 01:37:34.289000+00:00
begin analysis time: 2020-08-09 00:00:00.000000+00:00
end analysis time: 2020-08-09 10:30:00.000000+00:00

Or we could also choose to only show the begin or end analysis times when set skipping first log time and last log time when applicable in the output. Taking that one step further, we could compare start analysis time and first log time, and begin analysis time with last log time and print first log time when greater than begin analysis time and print last log time when < end analysis time.

I think you're talking about a different gh issue, but you can solve it however you want. I'm good with this PR as it is now, and I welcome any additional work to improve things.
Thanks again!


Multiple submits with same tarfile name from same directory clash

The current code makes a filtered tarfile (with permissions corrected) in the current working directory, with
a name based on the name of the tarfile being submitted.
If two submissions are being made at the same time, with the same tarfile basename, in the same directory,
this causes a clash and the tarfile gets overwritten and removed; this means that one job can
get the other job's tarfile, and that one of the submissions can fail from the tarfile "disappearing"  because
the other jobsub_submit removed it.

@hgreenlee originally reported this issue.

Note:  This also sounds like an old ticket we got from mu2e:  ServiceNow ticket INC000001150554.


[Android] Problem updating swiper views

I have a need for a swiper with dynamic items, some may be added or removed at runtime. This works fine on iOS, but has problems on Android.
Which OS ?
Android
Version
Which versions are you using:

react-native-swiper v? 1.5.4
react-native v0.?.? 0.46.4

Expected behaviour
Having a swiper with 4 items and adding some new items (say 2 more for a total of 6) should allow for 6 items to transition between.
Actual behaviour
Depending on the initial amount of items in the swiper, if additional items are added, those additional items will not render correctly. They'll appear blank, and when swiping back to one of the pre-existing items (from the blank views) the transition animation will not occur and instead will jump straight to the item (however swiping between the pre-existing items will have the transition animation).
Steps to reproduce

Create a swiper with a certain amount of items.
Call setState increasing the amount of items in the swiper.
Swipe between the items to see the issue.

Additional notes
The issue seems to be directly related to the swiper's initial state. So if the swiper is initially created with 5 items, then it will only be able to stay at 5 or go lower. Increasing it will cause this issue.

Follow

Can you try with latest version , 1.5.12.
If bug appears again, can you fork the project and reproduce it again ?
Thanks

I am getting this issue too!

@ScrimpyCat Did you find a solution?

I probably have the same situation when I go to some another view and return. In that moment the swiper not responde correctly. For example if I swiper the current slide stuck in the middle of animation.

I have similar issue.

I load swiper with 5 items.
When I move to next item I change source to contain 2 items.
Then I go back to first Item and change something which update source again and now source contain 3 items.
Now when I look at swiper it has only two views third is blank.

If I inspect swiper component I see that it has 3 children's and all are correct.
So issue is having 2 items and then make it 3 -> 3rd is blank.
And this works on IOS but not on android I tried latest and few versions back.
This is bit urgent issue for me so if someone can help it would be great.

Idem. Can still reproduce this on iOS.


fix upsert failed on autoid enabled collection

related to #399

Hi @shanghaikid, thanks for the fix! Does this also fix the issue with $meta potentially being overwritten in buildDynamicRow?

Hi @shanghaikid, thanks for the fix! Does this also fix the issue with $meta potentially being overwritten in buildDynamicRow?

yes, it should fix this .


"How much VRAM is needed to run TORA in ComfyUI, and is any CPU offloading available?

With the GGUF model, around 12-13GB all on GPU. Offloading works somewhat, hard to say what's the actual minimum though, if I enable it then it uses few GB less.

My graphics card is an RTX 3060 with 12GB, and I have 32GB of RAM. I'm using the Tora model with BF16 precision, FP8 Transformer enabled, and CPU offload activated. The generation step is 20, and it takes around 20 minutes to generate a video. The average GPU usage is between 6-8GB, and the video output is quite good, with almost no facial distortion in the characters.
https://github.com/user-attachments/assets/dd225b45-3484-4adc-964a-00d939415e26


Force sw-toolbox version to 3.1.1

Due to this issue https://github.com/GoogleChrome/sw-toolbox/issues/143, the sw-toolbox path has changed in the latest minor release (which should be major) and the package breaks when trying to require the sw-toolbox library here https://github.com/jkleinsc/broccoli-serviceworker/blob/master/lib/service-worker.js#L6.
So imo the solution must be just changing "sw-toolbox": "^3.1.1" to  "sw-toolbox": "3.1.1". I'm just creating an issue instead a PR because I'm not sure if you agree with the change.
Thanks!

@zzarcon looks like https://github.com/GoogleChrome/sw-toolbox/issues/143 has been fixed, so this issue is now fixed!


crash in onnx_runner (modeld)

Describe the bug
Hi,
After building the docker images locally:
controlsState: Reader was evicted, reconnecting
Onnx available providers:  ['TensorrtExecutionProvider', 'CUDAExecutionProvider', 'CPUExecutionProvider']
Onnx selected provider:  ['CUDAExecutionProvider']
clocksd logcatd modeld navd proclogd ui soundd locationd calibrationd controlsd deleter logmessaged paramsd plannerd radard thermald statsd
2022-04-12 10:47:16.707337515 [W:onnxruntime:Default, onnxruntime_pybind_state.cc:552 CreateExecutionProviderInstance] Failed to create CUDAExecutionProvider. Please reference https://onnxruntime.ai/docs/reference/execution-providers/CUDA-ExecutionProvider.html#requirements to ensure all dependencies are met.
Onnx using  ['CPUExecutionProvider']
ready to run onnx model ['input_imgs', 'big_input_imgs', 'desire', 'traffic_convention', 'initial_state'] [[1, 12, 128, 256], [1, 12, 128, 256], [1, 8], [1, 2], [1, 512]]
Traceback (most recent call last):
  File "/openpilot/selfdrive/modeld/runners/onnx_runner.py", line 60, in <module>
    run_loop(ort_session)
  File "/openpilot/selfdrive/modeld/runners/onnx_runner.py", line 34, in run_loop
    inputs.append(read(ts).reshape(shp))
  File "/openpilot/selfdrive/modeld/runners/onnx_runner.py", line 17, in read
    assert(len(st) > 0)
AssertionError

OS Version
Ubuntu 18.04
openpilot version or commit
85c714e350b2445a78299fe6df8c06a36d80bcea
Additional info
No response

duplicate of #23666

@adeebshihadeh  Thanks. I am aware of that issue.
I had the same issue here that was resolved by the pull request mentioned here. My guess is that changes after https://github.com/commaai/openpilot/commit/d014d8191d950a56a961c18c84463ffd0d3d5de5 caused the bug to appear again.


examples/selectable-rows mistake

In the "examples/selectable-rows". "onRowsSelect"function uses "dataIndex" instead of "index" causing issues with checkbox selection when the table is sorted. Current solution:
      onRowsSelect: (rowsSelected, allRows) => {
        console.log(rowsSelected, allRows);
        this.setState({ rowsSelected: allRows.map(row => row.dataIndex) });
      },

Fixed solution:
      onRowsSelect: (rowsSelected, allRows) => {
        console.log(rowsSelected, allRows);
        this.setState({ rowsSelected: allRows.map(row => row.index) });
      },

Expected Behavior
Clicking a row should select that row
Current Behavior
Click a row select a different row due to "dataIndex" and "index" mismatch.
Steps to Reproduce (for bugs)
Your Environment

Tech
Version

Material-UI
4.3.2

MUI-datatables
2.8.1

React
16.9.0

Hm, not sure I understand. dataIndex was the intention, as this index does not change with sorting, meaning that the same data will be selected before and after.

I see, sorry about the issue in that case. For me, the way I was keeping track of state, my method worked but the example didn't. I ended up removing mine in the end anyway. I'll close the issue now. Thanks for the great library (especially how customizable it is).


Add support for Orka

Fixes #4899
Update PLATFORM_MAP with Orka dynamic agent for Mac platforms

Grinder on aarch64_mac: https://ci.adoptium.net/view/Test_grinder/job/Grinder/8139/

This PR is eventually needed.
However this might not be the fix for https://github.com/adoptium/aqa-tests/issues/4899. See my comment in https://github.com/adoptium/aqa-tests/issues/4899
I run a grinder with master which still works for mac aarch64 as in grinder the ACTIVE_NODE_TIMEOUT will be set as 15 min.
https://ci.adoptium.net/view/Test_grinder/job/Grinder/8154/console

In short the orka test agent is used in a different way from the current dynamic agents logic is aqa-tests.

@sophia-guo - by your comment, do you feel this PR, https://github.com/adoptium/ci-jenkins-pipelines/pull/853 is a preferred approach?  If so, I can close this one and move that one out of draft.

Ugh sorry, pulled the trigger too fast - reversal PR https://github.com/adoptium/aqa-tests/pull/4913


chore: vulnerability fix

PR summary
updated packages for vulnerability fix
Fixes: <! -- link to issue -->
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?
packages are not up to date
What is the new behavior?
updated packages
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This PR is included in version 0.4.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Split override 多加

https://www.youtube.com/watch?v=fqJcRr_1hAw&t=591.980551s#:~:text=多加小心吧
多加 = Dorcas
Not Dorcas on following:
多加小心吧 = Be more careful

Yes that'll need an override or at least a second definition "add more" (as in "add more care")

It seems 多加小心 is common enough to have an entry of its own (duō jiā xiǎoxīn).  I wonder how many other contexts there are where 多加 isn't Dorcas


Don’t publish codeclimate-test-reporter and semantic-release as deps to npm

As you can see right now on npm glob-promise has a dependency on codeclimate-test-reporter and semantic-release. These should just be devDependencies.
The cause of this is npm install --only=production codeclimate-test-reporter semantic-release in the build script. It saves the specified dependencies in package.json as dependencies.
This was surfaced when Snyk detected a potential security risk in Next.js -> glob-promise -> codeclimate-test-reporter

@ahmadnassri can you check this?

fixed in 73693310f9042dca8cea37b6cdbb930ee362adb8

👍


Enhancement - Create a downlink when receiving RxTimingSetupAnswer

When a device receives RxTimingSetupReq it must keep adding RxTimingSetupAns until it receives a downlink from the network server.

Currently the router does not initiate any downlink upon reception of the RxTimingSetupAns, which is compliant to the LoRaWAN specification, but can be an issue especially in DR0 US915 where the payload is limited to 11 bytes: having 1 byte taken by the  RxTimingSetupAns is 10% of the available payload.

Maybe queuing a downlink after RxTimingSetupAns or after a few of them would help

At first, this looked like a quick turn-around enhancement but requires more effort.


blockchain/utreexoviewpoint: Refactor Modify() function

Functionality that was included in Modify() is now refactored into 3
separate functions: Modify(), IngestProof(), and ExtractAccumulatorAddDels().
Modify now only modifies the accumulator without any other checks.
IngestProof validates and ingests the proof so that the caller can call
Modify().
ExtractAccumulatorAddDels now does the proof sanity checks and extracts
the additions and deletions from the block that was passed in.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 64 (4.69%)  changed or added relevant lines in 3 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.006%) to 54.449%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

blockchain/chain.go
0
9
0.0%

blockchain/validate.go
0
9
0.0%

blockchain/utreexoviewpoint.go
3
46
6.52%

Files with Coverage Reduction
New Missed Lines
%

blockchain/utreexoviewpoint.go
1
9.14%

peer/peer.go
2
75.53%

Totals

Change from base Build<PHONE_NUMBER>:
-0.006%

Covered Lines:
26205

Relevant Lines:
48128

💛  - Coveralls


Change SPDX json package download location from NONE to NOASSERTION

Describe the issue
Tern currently reports the package download location in SPDX reports as NONE In the recent SPDX DocFest, it was discussed that the value should actually be NOASSERTION.
To Reproduce
Steps to reproduce the behavior:

Run `tern report -i  -f spdxjson
See downloadLocation is NONE for packages

"downloadLocation": "NONE"

Expected behavior
downloadLocation should be NOASSERTION
To fix
Make changes to tern/formats/spdx/spdxjson/package_helpers.py to change PackageDownloadLocation value to NOASSERTION:
 35         'downloadLocation': mapping['PackageDownloadLocation'] if
 36         mapping['PackageDownloadLocation'] else 'NOASSERTION',

Can I work on this issue?

Thank you for assigning me the issue. Kindly review my Pull Request for the same.


Modbus Master communication with Multiple Slaves???

ModbusMaster version
[2.0.1]
Arduino IDE version
[1.8.5]
Arduino Hardware
[ESP32 Dev Module]
Platform Details
[Windows10]

Scenario:
[It's a Question. The question is "should I create multiple ModbusMaster objects to interact with multiple slaves? Or is there any other way to do it?]
Steps to Reproduce:
[Not Applicable]
Expected Result:
[Not Applicable]
Actual Result:
[Not Applicable]

Feature Request
Narrative:

As a [role]
I want [feature]
So that [benefit]

Acceptance Criteria:

Scenario 1: Title
Given [context]
  And [some more context]...
When  [event]
Then  [outcome]
  And [another outcome]...

We used for interacting with multiple slaves and it is working.

Hi dvvrao, How do you manage this?
Create multiple ModbusMaster objects with different Slave ID ?
Thanks in advance
Dave

Hi Dave,
Sorry for delayed answer.
Yes, I did what you guessed.
Below is the code snippet:
/* instantiate ModbusMaster object(s) */
static ModbusMaster node1;  // Flame proof temperature sensor.
static ModbusMaster node2;  // Arduino Nano.
static ModbusMaster node3;  // Arduino Nano.
static ModbusMaster node4;  // Arduino Nano.
static ModbusMaster node5;  // Arduino Nano.
static ModbusMaster node6;  // Arduino Nano.
// Start UART1. Used for RS485.
UART1.begin(BAUD_RATE,  /* baud speed /
SERIAL_8N1, / UART mode  /
36,         / RX pin     /
17          / TX pin.    */
);
// communicate with Modbus slave ID 1, 2 and so on upto MAX_SLAVES over Serial (port 1)
node1.begin(1, UART1);
node2.begin(2, UART1);
node3.begin(3, UART1);
node4.begin(4, UART1);
node5.begin(5, UART1);
node6.begin(6, UART1);
Files_To_GIT_ModbusMaster_App.zip
PFA the code.
Regards,
Vishnuvardhan

Do you guys know if is it ok if I change the slave my calling the function ModbusMaster.begin() again?

There is still an issue with communication to multiple slaves. It is ok, to re-use .begin() with another modbus address but if I do have a class structure, where the a pointer to the MBdriver - object is passed as a parameter in constructor call, I can change the modbus - address in the receiving object but not restore to the previous modbus address before retuning to calling environment.
e.g.
_#include "ModbusMaster.h"
#include "LAMP_MODBUS_SCOUT.h"
...
// instantiate ModbusMaster object
ModbusMaster MBdriver;
ModbusMaster MBdriver_pt = &MBdriver;
....
// Declare the Object which acts as a scout on the modbus, looking for
//         lamps declared in LAMP_SYS2MONITOR but not yet talked to
LAMP_MODBUS_SCOUT               MBscout(MBdriver_pt);
...
...
// Modbus communication runs at 9600 baud; GPIO pin0=RX, GPIO pin1=TX
Serial.begin(lamp_sys.get_MODBUS_baudrate(),RXpin,TXpin);
..
// Provide the modbus address of the next lamp to poll to the MBdriver
MBdriver.begin(CURR_modbus_addr, Serial);
...
void loop() {
.....
.....
//reading from CURR_modbus_addr
retsta = MBdriver_pt->readHoldingRegisters(0x0000,numREG2LOAD);
....
//MBscout will use MBdriver.begin(FND__modbus_addr, Serial);
ret = MBscout.get_lampRELdata (FND_modbus_addr, &lamp_HWSWrel, &lamp_sys);
// here we will CONTINUE sending data to FND_modbus_addr because MBscount can not
// restore communication to CURR_modbus_addr before returning. This side effect creates a
// mess
....
};_*
I SUGGEST adding a function: uint8_t  getSLAVEaddr()  into  "ModbusMaster.h" which returns
the private instance variable _u8MBSlave. so MBscount can save it at get_lampRELdata() entry and
restore before returning. This will eliminate unwanted side effects.

@DIYDave so there will be only one .begin() for all the slaves? or do you pass all the slave ids?

anyone still working on this? I see fake-name has already done a PR to fix this, who can approve PR into master?

@DIYDave so there will be only one .begin() for all the slaves? or do you pass all the slave ids?

Yes, only one .begin(). Works great for me.

@DIYDave Could you please share your changes on public repo?

@DIYDave Could you please share your changes on public repo?
@tomek14 You can find my solution in my comment from 14 Sept 2018 above.
Sorry, I don't know how to publish otherwise.
You are welcome to publish the solution or tell me how I have to do it myself.

The fix of @DIYDave seems very good to me.
However, it is not in the official code yet?
Thanks a lot.

Hello @DIYDave
Test your solution in above
https://github.com/4-20ma/ModbusMaster/issues/109#issuecomment-421412049
but don't work for me. change lib to add slave
and use node1.begin(1, UART1); node2.begin(2, UART1); ...
Only one of them works at the moment. To work on one of the nodes, I need to remove another node. Then the commands work.
The error I receive is the E2 error related to Timeout.

Hello @DIYDave
Test your solution in above
#109 (comment)
but don't work for me. change lib to add slave
and use node1.begin(1, UART1); node2.begin(2, UART1); ...
Only one of them works at the moment. To work on one of the nodes, I need to remove another node. Then the commands work.
The error I receive is the E2 error related to Timeout.

Hi, you don‘t have to use .begin for each slave. Just one time. After that you can adress slaves by its ID. (If you have change the library)

Can someone share the code to help me read and write data for muilti slave?

Can someone share the code to help me read and write data for muilti slave?

The solution from my post from June 2018 has been running 24/7 for three years without any problems.  Change library for the MB commands you need.  Use begin() 1x and transfer the slave ID as the first parameter when called from the sketch.

Can someone share the code to help me read and write data for muilti slave?

The solution from my post from Sept. 2018 has been running 24/7 for three years without any problems.  Change library for the MB commands you need.  Use begin() 1x and transfer the slave ID as the first parameter when called from the sketch.

Thank for your reply
But I am newbie, can you share your full example code a master read and write  multi slave ?
I'm so grateful to you

Hi Dave,
Do not remember now exactly.
I will check my code and let you know later.
Thanks,
Vishnuvardhan
On Thu, 6 Sep, 2018, 8:19 PM DIYDave, @.***> wrote:

Hi dvvrao, How do you manage this?
Create multiple ModbusMaster objects with different Slave ID ?
Thanks in advance
Dave
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/4-20ma/ModbusMaster/issues/109#issuecomment-419121935,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbXlEikv9RSc4RDXo65TkR_5FFVjSScPks5uYTXwgaJpZM4UtjYV
.

I got did , i well share library  very soon

The Solution from DIYDave works ok but he didnt say that you need to change this in the modbusmaster.h too:
Line 208, you need to include an uint8_t (the same that you added in the .cpp file).
uint8_t  readHoldingRegisters(uint8_t, uint16_t, uint16_t);
Sorry for my english, im not native.

The Solution from DIYDave works ok but he didnt say that you need to change this in the modbusmaster.h too:
Line 208, you need to include an uint8_t (the same that you added in the .cpp file). uint8_t readHoldingRegisters(uint8_t, uint16_t, uint16_t);

The Solution from DIYDave works ok but he didnt say that you need to change this in the modbusmaster.h too:
Line 208, you need to include an uint8_t (the same that you added in the .cpp file).
uint8_t readHoldingRegisters(uint8_t, uint16_t, uint16_t);

Since no one did it, I made a fork here
Basically I've done what @DIYDave did but to all read/write functions (the one that returns ModbusMasterTransaction, as it is the only function that use _u8MBSlave)
Tested it on my current project (power meters logger) using both readInputRegisters and readHoldingRegisters and it seems to work normally. Quite convenient for multiple-slave use, since you only got to create one modbus object.
For single slave use though... having to specify the address for each request might be inconvenient for some..
Oh the dilemma..

Thanks for the fork, Hantuch. Unfortunately, I'm not very familiar with Github. I'm happy when I have my own reposotories under control.  It's very easy to be honest, you just click the fork button up there and it makes a copy of the repo under your name and control. If you're sure the codes works you can make a pull request, which, if accepted by the original author (or anyone else with the access), will be merged into the original repo (although for this particular library, it seems to not have been updated since 2016, and many pull requests are left unattended)
cheers!

Can

You're welcome! It's very easy to be honest, you just click the fork button up there and it makes a copy of the repo under your name and control. If you're sure the codes works and you think it's essential you can make a pull request, which, if accepted by the original author (or anyone else with the access), will be merged into the original repo (although for this particular library, it seems to not have been updated since 2016, and many pull requests are left unattended)
cheers!

Could you post an example code?
Still trying to figure out if i got a bug in my code or smth in the bus confog is wrong...


UX for handling Direct Messages

We now have first-class support for direct messages in Vector-web.
It's very unclear on how the UX should work on mobile however.  It doesn't seem right to put DMs in their own sublist of the main rooms, so instead we need to apply an icon or something to show which are which.

See #606 for the implementation side of this.

In recents we already have direct messages and group messages mixed. How should this be different? https://zpl.io/3AHRf

Ok cool! I updated this https://zpl.io/Z1hByQi

I don't have a clear idea of how we should differentiate DMs from Rooms.  Separating them into different lists feels like a mistake on iOS - i.e. the current behaviour is probably correct there.  Suggestions for how to better differentiate welcome.

I agree. I think the way it currently works on iOS is correct. I don't know if there are any other changes to make here?

Antikewl, what is your point of view on this topic?

If we want to mirror the UI behaviour of the web app, why don't we simply add an icon to direct messages? https://zpl.io/2lxn33

signed off

antikewl,
We need a UI to convert existing rooms to/from DMs, do you think possible to add an option in the swipe menu (https://zpl.io/Z1iHWPs)? or do you suggest something else?


Create a new component MeasurementPlot

This component will be able to display a 'Measurement'.
A measurement is an object that can contain many data that contains many variables. Something like:
{
  "meta": {},
  "filename": "tree-uv.jdx",
  "info": {},
  "title": "patiny_LP1234_F12",
  "data": [
    {
      "variables": {
        "x": {
          "label": "Wavenumber",
          "units": "cm-1",
          "data": [
            190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202,
            203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215,

Using the following example:
data.json.zip
We should create a component <MeasurementPlot> that use 'react-plot' and has the following properties:

measurement : the data as given in the example zip file
dataIndex : default value 0, the index in the 'data' array
xVariableName: default 'x', the name of the variable for the horizontal axis
yVariableName: default 'y', the name of the variable to use for the vertical axis

This will create a plot using:

the 'title' property as the title of the plot
for the label of the axis something like: x.label + x.units ? '('+x.units+')' : '';

does MeasurementPlot must render all data ( many line series )?, if yes ,which data axis label must be used ?

No it should only display one data. It will another component that could allow superimposition of many data.


[Tables] Address docstring

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-data-tables


Don't confirm quitting the app on restarting to install a new version

Don't confirm quitting the app when restarting the app to install a new version

Obsolete with https://github.com/algorithmwatch/dataskop-electron/commit/6053f319b7b0711f4bac228011546ec9aad37e5d


"Mapping does not have keypath, cannot set value."

Seeing an error using 0.7.3 that worked fine with 0.6.1.
I'm calling an ajax api which returns an array, then setting an existing property with the array value.  This triggers an error:
"Uncaught Error: Mapping does not have keypath, cannot set value. Please raise an issue at https://github.com/ractivejs/ractive/issues - thanks!"
This is using the ES6 syntax:
module.exports = Ractive.extend({
  data() {
    return {
      people: []
    }
  },
  oninit() {
    xhttp({ url: '/api/people' })
      .then(people => {
        this.set('people', people);
      });
  }
});

The error originates from ractive.js:14331
setValue: function (value) {
	if (!this.keypath) {
		throw new Error("Mapping does not have keypath, cannot set value. Please raise an issue at https://github.com/ractivejs/ractive/issues - thanks!");
	}

	this.origin.set(this.keypath, value);
},

when the error occurs, this is:
Mapping {
deps: Array[0],
keypath: undefined,
local: Viewmodel
localKey: Keypath,
origin: Viewmodel,
unresolved: Array[0]
}

I'm also using https://github.com/MartinKolarik/ractive-route, which could be part of the cause, but I'd like to understand what circumstances "Mapping does not have keypath, cannot set value" would get called.   Also would like to confirm I'm not missing anything obvious like "don't set an array in oninit", etc (as a fake example).

Are you using the Ractive.extend as a component for which you are also passing in a people data key? Like:
<component people='{{people}}'/>

Not exactly, using in ractive-route like so:
var router = new Router({
  el: '#main',
  basePath: '/app' // TODO just use basepath always? Avoids SS coupling
});
router.addRoute('/people', require('./people/People'));
...

and it instantiates the component for you

Having trouble reproducing in isolation: http://jsfiddle.net/uzt480dx/. Not sure how the router instantiates the components.

Thanks, will take a look and see if I can repro there.

I haven't tested ractive-route with v0.7.x yet. Let me see if I can find source of the problem.

@martypdx

Not sure how the router instantiates the components.

Basically just calling new Component().
@bestguy
I couldn't reproduce this error. Mappings are used to map data between the main Ractive instance (initialized by ractive-route) and inline components used in the template, so the source of the problem is probably somewhere else. If you can create a jsfiddle or a small repo demonstrating this, it would be very useful.

Thanks for the help, will try and reduce this down to a shareable example, will close if not able to reproduce.

Also to clarify, this problem first appeared when I switched to using an async call (xhttp Promises) to set the people array, and only seems to be an issue with array - setting a string, etc seems fine.

@bestguy what is the value of localKey? is it people or something else?
Mapping {
deps: Array[0],
keypath: undefined,
local: Viewmodel
localKey: Keypath, // what is localKey.str?
origin: Viewmodel,
unresolved: Array[0]
}

localKey: Keypath
  firstKey: "child"
  isPattern: false
  isRoot: false
  lastKey: "child"
  str: "child"
  parent: Keypath
    firstKey: ""
    isPattern: false
    isRoot: true
    lastKey: ""
    parent: null
    str: ""

I can't reproduce this after reducing an example this down to Ractive, ractive-route, xhttp and simplifying the template, so must be some other issue or dependency.   Will close this and try to identify root cause.   Thanks for help, will reopen if need be.

Seems to be a problem when I use a custom component when rendering each person in the array - not sure what I did wrong with it, but thanks for help narrowing issue.


CT 2000 fix semver prerelease comparisons

resolves #6834
Description
In semver.py we were using packaging.version.parse to parse the prerelease portion of versions, but since that version parsing is incompatible with SemVer, it started failing once the LegacyVersion fallback was removed.
This removes the dependency on packaging and subsitutes some comparison code specifically for prepreleases, so that we can remove the pin on packaging.
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

We should definitely look at a more consistent solution to these version problems, and look into using some existing package.

Let's include this in the next v1.4.x patch release as well, since users will continue to have issues installing dbt-core with the tight pin. The change was small & precise, and fixed a narrow bug (the previous logic was genuinely incorrect).