Update timeout for .github/workflows/integration-enterprise.yaml

This is an automated pull request to update default timeouts for all jobs in .github/workflows/integration-enterprise.yaml that do not currently contain a default timeout property.
Please review these changes closely to ensure that all jobs have sufficient time to run. If a job needs more time, please add a timeout property to that job to override the organization default.
Additionally, please be attentive to unintended changes to the workflow YAML file, as the parser is not perfect.
Lastly, note that it is up to the reviewer to merge this pull request and delete the PR branch once they are satisfied with the changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Clarification on total ROI vs Response Curves

Describe issue
Hello Robyn team, I have been searching the issue page for answers and I had maybe a few hints but not a clear answer.
It seems to me that when analyzing onepagers, the Share of Spend VS Share of Effect and Response Curves and Mean Spends plots are telling different stories.
See the example below:

The total historical ROI for all channels is around 5. That would mean, if I understand correctly, that the model estimates that on average I have gotten $5 worth of effect for every $1 spent in the past.
So when looking at the response curves on the right, how could it be that the point of mean spend for the blue curve, for instance, corresponds to a response lower than the spend? Same for the purple curve, which seems to indicate that response for the channel is close to zero.
What the saturation curves seem to tell is that in order to actually get any positive return I should spend much more (almost a different order of magnitude) than what was done historically. How does that relate to the total estimated historical ROI of about 5?
Since the response of those curves is indeed the one used in the robyn_allocator output, such a model (and therefore its allocation suggestions) would not make much sense for the business.
Provide reproducible example
Unfortunately I cannot provide our customer's data; the dataset is made of about ~700 daily observations, with 3 paid media channels (with spends and impressions), an organic variable (newsletters) and several context variables (related to promotions/discounts), along with Prophet automated seasonality, trend and holiday. The target variable is total sales on their e-commerce site.
I have experimented with many different configurations of variables, data windows, adstock types etc. but the result is always roughly similar.
Also, it might not be a data-related issue but just a misunderstanding on my part on how to read these outputs.
Environment & Robyn version
Robyn 3.7.2 on R 4.2.2

Hi, this question has been raised more frequently lately, for example this one. Any chance you're using the weibull adstock?
This discrepancy is due to the fact that the robyn_response and robyn_allocator functions don't conduct adstock transformation so far, while the saturation curve itself is generated with adstock. The reason is that when you input a value, say 100$, into the two functions, this value doesn't have a timestamp and without timestamp it's not possible to do adstock transformation. It's been working fine so far, as most users were using geometric adstock that is "stocking up" less, and thus the discrepancy was moderate. In comparison, weibull adstock is more advanced and becoming more popular now, and it will "stock up" more on the raw spends. Until now, we've been explaining this phenomenon as a "conservative recommendation", which means the allocator is simulating the case where adstock is 0. We've been also stressing that the allocator shows a directional recommendation, as opposed to the absolute "truth". We still see it that way, but understand that the difference is becoming too large to be ignored and the reco is coming through as unrealistic.
This issue will be solved with the upcoming forecast function, where we'll always require a timestamp as input (or assume a timestamp by default) and thus enabling the adstocking for robyn_response and robyn_allocator.
Robyn is still in the experimental phase and we appreciate your understanding.
@igorskokan  @laresbernardo @michellegrushkometa @Amyhaoming

Thank you! Makes sense. I didn't know that these two functions don't apply adstock. Is that written anywhere in the documentation? Maybe I just missed that part - it seems an important caveat.
Will try a new training run with geometric adstock to see if the issue disappears.
Looking forward to the upcoming forecast function! Apart from this issue, it is definitely an important feature. For instance, our customer would like to see the response for future periods with certain structure of context/organic variables, and for now you could only approximate by running the allocator on past periods that where somewhat similar.

Hi @gufengzhou - have a similar, but slightly different question/concern. In the screenshots, Channel X shows 644 CPA, but the response curve for this channel is flat (in red) and so while channel X seems like a decent channel based on the CPA, it appears terrible from the response curve.
Are we saying that the CPA (eg, the 644) does take into effect the adstock transformation, while the response curve does not, and so the Effect vs Spend Share Chart on the left is a more accurate depiction of the channel performance?
This discrepancy seems to have implications on further analyses like simulating marginal intakes or marginal CPA as the CPA for channel X grows to a very high number based on the robyn_response function.

We've just updated to v3.10 that is a big update of robyn_allocator and robyn_response. Please check the new version first.

I have the same concern when channel X has highest ROI but the response curve look really bad.

I understand the concept when the response curve take adstock into consideration while allocator do not. But in term of business perspective, I can't get the link of number concept and business story. Can anyone give an explanation for it? Many thanks. I used Robyn version 3.10.4, geometric adstock

this doesn't look right @dohieu2801 , are you sure you didnt mix up the channels?

this doesn't look right @dohieu2801 , are you sure you didnt mix up the channels?

I'm sure that the column and the line match. All of channel above relate to digital media + commercial investment in ecomerce platform. I think I chose incorrect adstock rate (0.5-0.7 where 0.3 is recommended). Is it the reason why the result is so weird?
@gufengzhou thanks for your reply but can you also advice how can I choose the appropriate model because each time I run i get different result and the result between each iteration also very different. And the difference in model accuracy is not significant between models?


change background in Moments' details/headings.

Hello. The text in the Moments headings were getting lost on the twitter.com home page. Changing the background in that section should make the text viewable and not have any repercussions outside of that area.

@jamessam thanks much for your contribution :) Could you share before & after screenshots for this fix?

Before:

After:

Looks good. Merging this in now. Will do a release today / tomorrow with a fix for #74. Thanks again for your contribution :)

Excellent! Thank you!

@jamessam have just published v0.0.20 which includes your fix and it should be available soon!


refactor: remove underscore prefix from core feature APIs

Issue or need
Core feature internal APIs aren't exported. No need to prefix them then

Proposed changes
Remove the underscore prefix.

Quick reminders

🤝 I will follow Code of Conduct
✅ No existing pull request already does almost same changes
👁 Contributing docs are something I've taken a look at
📝 Commit messages convention has been followed
💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
⚙ API Report has been updated if API surface is altered.

#861  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite


CED Page Updates: Add New Workshops

Could we please update the workshops section on the CED page to include the four newly added partner workshops.
Title: Securing Deployments with Policy as Code
Description: The Pulumi team will show you how to enforce best practices by creating policies that scale from a single infrastructure stack to your entire organization
CTA: Register Now
CTA Link: https://www.pulumi.com/resources/securing-deployments-policy-as-code
Title: Getting Started with Infrastructure as Code on DigitalOcean
Description: In this hands-on workshop, you will learn how to stand up basic services using Infrastructure as Code through a series of hands-on labs.
CTA: Register Now
CTA Link: https://www.pulumi.com/resources/getting-started-with-infrastructure-as-code-on-digital-ocean
Title: Getting Started with Infrastructure as Code Azure with Java
Description: Learn the basics of Azure and Pulumi with a hands-on lab that will take you from deploying a simple static website to deploying a Spring Boot application.
CTA: Register Now
CTA Link: https://www.pulumi.com/resources/getting-started-infrascructure-as-code-azure-java
Title: Production-Ready Networking on AWS with Python
Description: In this workshop you'll learn to apply Infrastructure as Code concepts to build a hub and spoke network topology with an inspection VPC.
CTA: Register Now
CTA Link: https://www.pulumi.com/resources/production-ready-networking-aws-with-python

If @zchase or @sean1588 have time to update this before the weekend, feel free to grab this, otherwise I will see if Shoes can take it on Monday.


Internal Navigation should be replaced with TOC block

Example here: https://github.com/hlxsites/bamboohr-website/tree/main/blog/blocks/toc

Some info on the current nav block: the different links in the nav block are internal links pointing to the headings of the document translated so somthing like Heading bla...
Heading bla
.
There's an intersection observer for the headings to detect which section is currently being scrolled in/over to highlight the corresponding nav link.

To limit the effort, I am going to reuse the existing code, just change how the list of links is gathered: compute based on page H2


ko_KR.json

韩文版

Coverage remained the same at 60.126% when pulling 0686ef302036fe56839020f7a5d5e7f8ad3faf4a on khjde1207:master into def80b904fc78c5f6edc1254f7e74415e9c06e47 on b3log:master.


bogus 'last update' for no edit users

15 years ago

@danbjoseph @dalekunce this is due to creating profile pages for all missing maps users without grabbing the feature data (This will be filled by a historical backfill). One fix could be to hide entries which have 0 edits; we could maybe also have another default date for last update.


Added traceContextEnter & traceContextExit

PR description
The OperationTracer is extended by the new methods:

traceContextEnter: called before switching to a new context
traceContextExit: called after leaving the context

Fixed Issue(s)
fixes #5728

Superseded by #5756


Changed some styling in the UI

Addresses issue #223

Removed the black border in the join us buttons
Resized the footer
Changed the font color from black to white in some blue box buttons to look pleasing and better

@SahityaRoy check out the changes

@SahityaRoy please add a label to this PR. It's not counted as a pr in leaderboard


add support for ZLIB_LIBRARIES with optimized/debug entries

Related issue: #5264

Well, CMake doesn't support the right way to export of IMPORTED targets (but it is required in case of static build of OpenCV).
There is some workaround for [IPPICV] (https://github.com/Itseez/opencv/blob/c223c05b82965a496f6dd059a2df2fc12b1bb4c7/cmake/templates/OpenCVConfig.cmake.in#L67-L75) , but it was a well known/fixed case (static external library).
ZLIB may be build as external static/shared library or static internal library. There is no easy way to detect library type from file name on Windows/MSVS (.lib extension is used for static libraries and for implib of .dll). Also MSVS may require .pdb files for build.
So there is no easy way to manage this with CMake.


FIX: Improve handling of reportlet style

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.25 :warning:

Comparison is base (fcbf05e) 56.06% compared to head (7ca3295) 55.82%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   56.06%   55.82%   -0.25%
==========================================
  Files          19       19
  Lines        1830     1829       -1
  Branches      370      367       -3
==========================================
- Hits         1026     1021       -5
- Misses        728      733       +5
+ Partials       76       75       -1

Flag
Coverage Δ

unittests
55.82% <100.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

nireports/assembler/reportlet.py
92.62% <100.00%> (-0.06%)
:arrow_down:

... and 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[BUG] New nodes failing to start longhorn-manager

Describe the bug
I'm trying to add extra Longhorn nodes to an EKS cluster, but the longhorn-manager PODs are not starting up on the new nodes and they error with the following  level=fatal msg="Error starting manager: fail to set the setting priority-class with invalid value system-cluster-critical: cannot modify priority class setting before all volumes are detached"
We deploy Longhorn via Helm and the values passed into the Helm chart are as follows:
defaultSettings:
  allowVolumeCreationWithDegradedAvailability: false
  createDefaultDiskLabeledNodes: true
  defaultDataPath: /mnt/longhorn
  replicaSoftAntiAffinity: false
  upgradeChecker: true
  replicaAutoBalance: best-effort
  disableSchedulingOnCordonedNode: true
  priorityClass: system-cluster-critical
longhornUI:
  priorityClass: system-cluster-critical
longhornDriver:
  priorityClass: system-cluster-critical
longhornManager:
  priorityClass: system-cluster-critical

To Reproduce

Have an EKS cluster of 3 nodes with longhorn installed.
Add a volume and wait for it to be attached.
Add an extra node.

Expected behavior
The POD's on the new nodes to be assigned the correct priority class and the PODs to startup as they don't yet have any volumes on them.
Environment

Longhorn version: 1.3.0
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): Helm - Chart Version 1.3.0
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: EKS

Number of management node in the cluster: N/A
Number of worker node in the cluster: 3

Node config

OS type and version: Managed EKS
CPU per node: 2
Memory per node: 8Gb
Disk type(e.g. SSD/NVMe): NVMe
Network bandwidth between the nodes: 1Gb

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): AWS EKS
Number of Longhorn volumes in the cluster: 4

@adamstirk-ct
This is a known issue and is fixed in the upcoming v1.3.1. Please refer to the workaround https://github.com/longhorn/longhorn/issues/4160.
Ref: https://github.com/longhorn/longhorn/wiki/Known-Issues-of-Feature-Releases


chore: add GitHub actions

https://github.com/tier4/ota-metadata/pull/18 has been merged to the unintended branch.
So I create this PR.

@Bodong-Yang
Sorry, I don't know the reason but I merged the previous PR to unintended branch.
#18 and this PR is identical.


Fix SLSA E2E test

It's currently failing due to some assumptions about the source being git

Codecov Report
Attention: 200 lines in your changes are missing coverage. Please review.

Comparison is base (e77cc0f) 67.16% compared to head (6e2191d) 67.19%.
Report is 12 commits behind head on main.

Files
Patch %
Lines

pkg/reconciler/build/build.go
50.00%
39 Missing and 12 partials :warning:

pkg/slsa/sign.go
57.14%
24 Missing and 12 partials :warning:

pkg/slsa/attest.go
83.67%
17 Missing and 7 partials :warning:

pkg/slsa/image.go
51.06%
16 Missing and 7 partials :warning:

pkg/slsa/pkcs8_signer.go
67.30%
14 Missing and 3 partials :warning:

pkg/blob/fetch.go
60.52%
10 Missing and 5 partials :warning:

pkg/cosign/image_signer.go
50.00%
6 Missing and 4 partials :warning:

pkg/secret/signing_secret.go
83.92%
6 Missing and 3 partials :warning:

pkg/registry/fetch.go
73.07%
4 Missing and 3 partials :warning:

pkg/config/lifecycle_provider.go
50.00%
2 Missing and 1 partial :warning:

... and 2 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1498      +/-   ##
==========================================
+ Coverage   67.16%   67.19%   +0.02%
==========================================
  Files         134      140       +6
  Lines        8284     8827     +543
==========================================
+ Hits         5564     5931     +367
- Misses       2266     2389     +123
- Partials      454      507      +53

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Training loss follows a strange dynamics

Hi! Thanks for the wonderful set of tools!I have a question about the weird shape of the training loss while training scvi model for data integration . It seems to be decreasing at first, but then increasing again. See the screenshots attached (the dynamics of change is shown after first and then starting from 20 epochs to emphasize the following increase in the loss). The severity of the increase later seems to be dependent on which and how many batch covariates I supply for integration. What would you advise in this case? Should I train it for longer/shorter or pick the set of covariates that minimize this bump later? Thank you very much in advance!

[CODE HERE]

[ERROR HERE]

Versions:

VERSION

So I don't think there's much to worry about here. The reason being that the loss is equal to:
reconstruction_loss + kl_weight * kl_loss
The kl_weight by default goes from 0 to 1 linearly over 400 epochs. So it makes sense that the loss can increase, since it's almost a moving target. I would inspect the ELBO instead.

Thank you very much @adamgayoso ! I am new to neural network and VAE field so it is very good to know. The ELBO is, indeed,  consistently decreasing.  I have a few follow up  questions on using scvi model, see below - but happy to move them to  discourse section if they don't belong here: 1) what are the parameters that you would advise to inspect how well the model fits? 2) Is there a way to extract and compare training and validation ELBO? Would that be useful to inspect? 3) This is more of a broad question : Would it be appropriate to decide on the exact set of covariates to use based on how well scvi model can fit the data (if it is generally possible to tell the difference in the level of fitting between models with different covariates)? Thank you very much again and my apologies if some of these are very naive questions.
With best wishes,
Veronika

We would appreciate these on discourse. Thanks! There are no naive questions!

Closing due to inactivity, but feel free to raise questions on discourse.


How to integrate this module with ZendSkeletonApplication

We are starting to migrate to zf3 on our projects. The ZendSkeletonApplication removed i18n translations, but our projects need localization. So we tried to install zend-mvc-i18n using the zend-component-installer in ZendSkeletonApplication. It was installed successfully and the modules.config.php was with it.
But when we tried to use $this->translate('string') in the view templates as we did in zf2. The error:
A plugin by the name "translate" was not found in the plugin manager Zend\View\HelperPluginManager
was shown. We tried several zf2 configurations but cannot find the correct way to fix it. Could someone check if there is any problem on using it with zf3 view helper? Thanks a lot.

As discussed here http://stackoverflow.com/questions/38293988/zf3-zend-mvc-skeleton-internationalization-not-working
This issue can be fixed by adding view_helpers array.
But I still think it is a bug of zf3 because the zf3/zf2 documents still say the translate view helper will be automatically injected if you use the PhpRenderer. The skeleton application is using PhpRender as it did in zf2.


Possible to use on FiveM ?

Hi,
do know if its possible to use your mod on FiveM ?
Thanks you.

Hi,
FiveM isn't currently supported.
@citizenfx made this fork (Port to FiveM): https://github.com/citizenfx/CustomCameraV
But is outdated, and it doesn't provide precompiled binaries.
I also have a C++ version of this mod here (Which is more recent and performs better):  https://github.com/Rbn3D/CustomCameraVPlus
But there are no precompiled binaries yet, and you'll need some third party libraries in order to compile it :/
I'll try to provide binary releases to C++ version when I have some time.

Not sure if C++ version (which relies in SHV) will work on FimeM...

Thanks for your awnser.
I m not developper C++, only some .lua and webmaster.


Fixes some errors in #1084

Fixes a few wording problems pointed out by @anselmbradford and @sebworks.
removes Sheer from Travis build
Fixes an issue with macropolo-- we're now using our own "Environment" class, not one of the ones provided in macropolo.environments

:+1:

:+1:


added output for ICON_Lx25_dx100_ProgNaNi.nc and fixed time dimension

corrected time dimension to staged and sandbox output and added output for PorgNaNi experiment.

@apossner thanks for making these changes! it looks like only the new file made it into the commit... could you please add the other ones?

Sorry about that. They are now added in the new commit. If I understand the Git correctly, the merge request is still open. Otherwise, let me know and I submit another one.

Sorry about that. They are now added in the new commit. If I understand the Git correctly, the merge request is still open. Otherwise, let me know and I submit another one.

@apossner Thank you for updating the commit. I just approved and merged.


Render tab name fix and examples

@skv-headless, hi again
Looks like I made a mistake in #401 (method renderTabName was called directly instead of property).
In this pr I fixed this and wrote example of using that property

@anyx do you need anything else from me? Or do you have any problems?

@skv-headless I updated PR. In my app, renderTab property is working (I use ScrollableTabBar).
But if we will use ScrollableTabBar in DynamicExample, demo app just crashes.
Btw, when I run demo app, I see thousands warnings.

@skv-headless hi, what about this?

Nevermind I can fix by myself

in master

Hi @skv-headless. I'm a bit confused, I can't see this PR in master. Could you please check?


@PersistentObject alert "Modifying state during view update, this will cause undefined behavior".

@BugMonkey this is now fixed.


Integration stop to work after RaspberryMatic Update

DONT'T DELETE THIS.
This is for issues only
If you have a feature request, add it as a new discussion, or add your point of view to an existing discussion.
Please answer all questions as good as possible.
Language: as you like -> english
Make sure you have read the documentation at https://github.com/danielperna84/custom_homematic#custom_homematic.
Make sure you have read the release notes at https://github.com/danielperna84/custom_homematic/releases.
Make sure you are running the latest version of the custom_component (and Home Assistant) before reporting an issue.
ENSURE that your Backend (CCU/Homegear/...) is working as expected and connected devices are controllable.
custom_component version (if applicable):
1.x.x
known last working custom_component version (if applicable):
1.x.x
Home Assistant:

Version: 2022.12.9
Installation method (HAOS ):

CCU:

Model (Raspi3/4.):
OS (Original, RaspberryMatic, debmatic ...):
Version:

Problem-relevant configuration:
Do you use tls?
Do you use callback?
Do you use username and password?
Which interfaces do you use (hmip/bidcos/wired)?
Describe the bug
A clear and concise description of what the bug is.
Integration stop to work after RaspberryMatic Update
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots (if applicable)

CCU firewall in CCU

device config in CCU

integrations view in HA

device view in HA

enity view in HA

Relevant HA log entries (press full log) VERY IMPORTANT
Diagnostic Information (available on every device)
2023-01-03 19:39:25.797 WARNING (SyncWorker_2) [homeassistant.loader] We found a custom integration homematicip_local which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2023-01-03 19:41:44.914 WARNING (MainThread) [custom_components.homematicip_local] This release of Homematic(IP) Local requires HA version 2023.01.0.dev0 and above
2023-01-03 19:41:44.918 WARNING (MainThread) [custom_components.homematicip_local] Homematic(IP) Local setup blocked
2023-01-03 19:48:50.011 WARNING (MainThread) [custom_components.homematicip_local] This release of Homematic(IP) Local requires HA version 2023.01.0.dev0 and above
2023-01-03 19:48:50.022 WARNING (MainThread) [custom_components.homematicip_local] Homematic(IP) Local setup blocked

**Expected behavior**

**Additional context**
Add any other context about the problem here.

Congratulations:

You use this integration's beta channel
You missed to read the release notes: This release requires HA >= 2023.01 (Beta)
You missed to read the logs: This release of Homematic(IP) Local requires HA version 2023.01.0.dev0 and above
You only use Version: 2022.12.9

Rollback or update to HA beta, and please start reading provided Information

Good evening,
Thank you for quick response and your work. I am just BFU beginner.....
Leon
On Tue, 3 Jan 2023, 20:19 SukramJ, @.***> wrote:

Congratulations:

You use this integration's beta channel
You missed to read the release notes
https://github.com/danielperna84/custom_homematic/releases/tag/1.26.0
: This release requires HA >= 2023.01 (Beta)
You missed to read the logs: This release of Homematic(IP) Local
requires HA version 2023.01.0.dev0 and above
You only use Version: 2022.12.9

Rollback or update to HA beta, and please start reading provided
Information
—
Reply to this email directly, view it on GitHub
https://github.com/danielperna84/hahomematic/issues/810#issuecomment-1370137878,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXLSAWJCXG3FJ4DDZUDVT7TWQR3VNANCNFSM6AAAAAATQABGDY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Ensure verbose log messages are logged on CI

I needed this to diagnose issue with Java kernels (coulnd't find the discovered kernels being logged anywhere, I'm know we had this, and thats what led me down the path of verbose logs not working)  and found that the verbose logs weren't logged at all.

Codecov Report

Merging #11057 (6ac6aaf) into main (cdae807) will increase coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #11057    +/-   ##
=======================================
  Coverage     63%      63%
=======================================
  Files        482      480     -2
  Lines      33823    33723   -100
  Branches    5511     5501    -10
=======================================
- Hits       21365    21308    -57
+ Misses     10417    10380    -37
+ Partials    2041     2035     -6

Impacted Files
Coverage Δ

src/platform/common/cancellation.ts
59% <0%> (-4%)
:arrow_down:

src/platform/common/process/baseDaemon.node.ts
50% <0%> (-4%)
:arrow_down:

...platform/interpreter/reservedNamedProvider.node.ts
93% <0%> (-3%)
:arrow_down:

src/platform/vscode-path/map.ts
10% <0%> (-1%)
:arrow_down:

src/platform/common/utils/localize.ts
76% <0%> (-1%)
:arrow_down:

src/platform/common/configSettings.ts
84% <0%> (ø)

src/standalone/serviceRegistry.node.ts
100% <0%> (ø)

src/notebooks/debugger/kernelDebugAdapterBase.ts
77% <0%> (ø)

...ne/diagnostics/reservedFileNameDiagnostics.node.ts

src/standalone/diagnostics/serviceRegistry.node.ts

... and 11 more


Tablename/variables highlighting

In SQL editor it would be nice if when I set my cursor on table name/column name/variable/etc it would highlight every word that matches the one I got my cursor on.
Here's what I mean:

This feature was implemented in 5.3.x


Running Exporter Causes Stuttering in All Games

I've been using this amazing exporter for a month or two now, but I noticed in almost all games (and even some videos) that there's be some pretty constant stuttering. This would occur once every 30 seconds or so and would essentially look like someone pressed pause then resume once really quickly.
I troubleshooted everything under the sun. I ran DDU, did a full Windows Reinstall, disabled/uninstalled any overlays I had running. It turns out the culprit was this exporter. Disabling the exporter made the problem go away immediately.
I also run the Prometheus Windows Exporter (https://github.com/prometheus-community/windows_exporter) and it doesn't seem to cause the same issue.
Unfortunately I don't really have any other info to share with you about this, and maybe there's nothing that can be done, but I thought I'd mention it in case there is a possible solution.
My Main Specs:
AMD Ryzen 3900x
EVGA 3080 Ultra
1TB NVME
64GB DDR4 @3600
Thanks!

Thanks, I think the issue might be caused by the nvidia-smi command running under the hood.
You can try to run the following command while the game is still running (in a windowed mode, or you run the command scheduled/remotely etc):
nvidia-smi --query-gpu="timestamp,driver_version,count,name,serial,uuid,pci.bus_id,pci.domain,pci.bus,pci.device,pci.device_id,pci.sub_device_id,pcie.link.gen.current,pcie.link.gen.max,pcie.link.width.current,pcie.link.width.max,index,display_mode,display_active,persistence_mode,accounting.mode,accounting.buffer_size,driver_model.current,driver_model.pending,vbios_version,inforom.img,inforom.oem,inforom.ecc,inforom.pwr,gom.current,gom.pending,fan.speed,pstate,clocks_throttle_reasons.supported,clocks_throttle_reasons.active,clocks_throttle_reasons.gpu_idle,clocks_throttle_reasons.applications_clocks_setting,clocks_throttle_reasons.sw_power_cap,clocks_throttle_reasons.hw_slowdown,clocks_throttle_reasons.hw_thermal_slowdown,clocks_throttle_reasons.hw_power_brake_slowdown,clocks_throttle_reasons.sw_thermal_slowdown,clocks_throttle_reasons.sync_boost,memory.total,memory.used,memory.free,compute_mode,utilization.gpu,utilization.memory,encoder.stats.sessionCount,encoder.stats.averageFps,encoder.stats.averageLatency,ecc.mode.current,ecc.mode.pending,ecc.errors.corrected.volatile.device_memory,ecc.errors.corrected.volatile.dram,ecc.errors.corrected.volatile.register_file,ecc.errors.corrected.volatile.l1_cache,ecc.errors.corrected.volatile.l2_cache,ecc.errors.corrected.volatile.texture_memory,ecc.errors.corrected.volatile.cbu,ecc.errors.corrected.volatile.sram,ecc.errors.corrected.volatile.total,ecc.errors.corrected.aggregate.device_memory,ecc.errors.corrected.aggregate.dram,ecc.errors.corrected.aggregate.register_file,ecc.errors.corrected.aggregate.l1_cache,ecc.errors.corrected.aggregate.l2_cache,ecc.errors.corrected.aggregate.texture_memory,ecc.errors.corrected.aggregate.cbu,ecc.errors.corrected.aggregate.sram,ecc.errors.corrected.aggregate.total,ecc.errors.uncorrected.volatile.device_memory,ecc.errors.uncorrected.volatile.dram,ecc.errors.uncorrected.volatile.register_file,ecc.errors.uncorrected.volatile.l1_cache,ecc.errors.uncorrected.volatile.l2_cache,ecc.errors.uncorrected.volatile.texture_memory,ecc.errors.uncorrected.volatile.cbu,ecc.errors.uncorrected.volatile.sram,ecc.errors.uncorrected.volatile.total,ecc.errors.uncorrected.aggregate.device_memory,ecc.errors.uncorrected.aggregate.dram,ecc.errors.uncorrected.aggregate.register_file,ecc.errors.uncorrected.aggregate.l1_cache,ecc.errors.uncorrected.aggregate.l2_cache,ecc.errors.uncorrected.aggregate.texture_memory,ecc.errors.uncorrected.aggregate.cbu,ecc.errors.uncorrected.aggregate.sram,ecc.errors.uncorrected.aggregate.total,retired_pages.single_bit_ecc.count,retired_pages.double_bit.count,retired_pages.pending,temperature.gpu,temperature.memory,power.management,power.draw,power.limit,enforced.power.limit,power.default_limit,power.min_limit,power.max_limit,clocks.current.graphics,clocks.current.sm,clocks.current.memory,clocks.current.video,clocks.applications.graphics,clocks.applications.memory,clocks.default_applications.graphics,clocks.default_applications.memory,clocks.max.graphics,clocks.max.sm,clocks.max.memory,mig.mode.current,mig.mode.pending" --format=csv

And see if the stutter happens.
If it happens, it is not the exporter's fault but nvidia-smi's.
In that case, you could try to query fewer fields at a time and see if you find a field that is the culprit.
If you succeed with that, then you can specify the query field names explicitly, omitting the field with the issue: https://github.com/utkuozdemir/nvidia_gpu_exporter/blob/master/CONFIGURE.md#command-line-reference.
Also, you can consider trying different driver versions - it might be a driver issue.

I appreciate the feedback. I tested this while running 3DMark TimeSpy just so I could have a consistent GPU load to compare.
Without your GPU Exporter running, smooth. With it running, hitches every 5-10 seconds. Most notably, they seemed to happen at the same spots every time. I did try running the command you gave me while the benchmark was running. It's hard to pin down, but it LOOKED like there may have been a stutter every time I executed that command as well, in addition to the usual intermittent ones.
I might go through field by field and try to find a culprit, but for now I thought I'd let you know the result, thanks!

Nice. Those stutters you mention that happen every 5-10 seconds is actually consistent with the stutter when you run the nvidia-smi command manually - the way Prometheus works is, it hits the exporter's http endpoint every 15 seconds or so (or whatever scrape_interval it is configured with). Every hit to the metrics endpoint runs nvidia-smi under the hood.
This indicates that the issue is not caused by this exporter.
You can still try to find out if excluding some fields from the query will help or not, and based on that can explicitly configure the query fields for the exporter. If you find something, please share it here.

I'll close this one, don't think much can be done on exporter's side here. But if you have some findings, please feel free share.


Upgrade to new versions of SpringBoot and other libraries

The versions of SprintBoot and other libraries in this project are very much out of date.  They should be updated to the latest stable versions.

Merged and closing.


default install path of application

in the README.md, it is mention that Your application is installed into /usr/local/share/my-app.
in my experiment , the path is /usr/local/my-app.

Can the installation path be changed? For example to /opt?

i struggled on this for a bit, if you check:
https://github.com/quamotion/dotnet-packaging/blob/3f7bd3c61a00ce2c51f4f53f34d149b0ce5f8fdd/Packaging.Targets/build/Packaging.Targets.targets
you can see there's a prefix property, if you add the prefix property it will allow you to set the default directory.
/usr/lib/dir1/dir2

i struggled on this for a bit, if you check:
https://github.com/quamotion/dotnet-packaging/blob/3f7bd3c61a00ce2c51f4f53f34d149b0ce5f8fdd/Packaging.Targets/build/Packaging.Targets.targets
you can see there's a prefix property, if you add the prefix property it will allow you to set the default directory.
/usr/lib/dir1/dir2

"Sorry  sir, could you show me how to do it?" I try changed /usr/share/ into ${HOME}/
default installation path still in usr/share


add on_delete with CASCADE on Ca ForeignKey

RemovedInDjango20Warning: on_delete will be a required arg

Coverage remained the same at 93.631% when pulling f6d398cfe21772ce18730eaebdb0c249b3f2235d on hggh:feature/django20 into 4788142d1143214c0bc7e19d09574e4bb4a8419c on openwisp:master.

@hggh thank you for contributing. Shouldn't a migration be created as well?

@hggh I was wrong, sorry! :-)


Ryū ga Gotoku: Ishin! Free app for PlayStation®Vita [PCSG00275]

App summary

App name: 龍が如く 維新！ 無料アプリ for PlayStation®Vita
App serial: PCSG00275
App version: 1.00

Vita3K summary
Version: 0.1.4
Build number: 2468
Commit hash: Vita3K/Vita3K@7acd5eb
CPU backend: Dynarmic
Test environment summary

OS: Windows 10 Pro 64-bit
CPU: Intel Core i7-10700K 3.8 GHz
GPU: Nvidia GeForce RTX 3070
RAM: 32 GB

Issues
Broken graphics
Uncapped (too fast)
Screenshots

Log
vita3k.log
Recommended labels
graphics bug
Ingame -

Looks much better now

Looks better now


Installation steps

Hey! Can you list somewhere how to install it? I am not a Go user, so I don't know the ecosystem and package manager.
I know there is a binary and packages for some distros on the release, but I didn't find how to do it manually from the source.

Hi!
To build the binaries by yourself, assuming that you have Go installed, here the steps:
Clone the repo:
git clone https://github.com/lucasepe/draft.git

Move to the 'cmd' directory:
cd draft/cmd

Generate the static assets
go generate ../...

Build the binary tool
go build -o draft

Thank you very much!

Thanks, @lucasepe ! I personally hadn't yet set this up for myself, and I'm a very big newbie to Go itself.
I thought maybe I should add the installation steps from here into the main README.md - which didn't have an installation step. Can you check that out whenever you get the time? Thanks! :D
I referenced the PR above.


ChangeType does not work on J.ClassDeclaration

What's changed?
A test case was added to demonstrate an issue with using the ChangeType recipe on a J.ClassDeclaration object.
What's your motivation?
ChangeType fails to change the class name for a J.ClassDeclaration object. This may be related to

#4648
since we noticed this new regression in a local recipe today.

Anyone you would like to review specifically?
@timtebeek
Checklist

[x] I've added unit tests to cover both positive and negative cases
[x] I've read and applied the recipe conventions and best practices
[x] I've used the IntelliJ IDEA auto-formatter on affected files

New test result:
ChangeTypeTest > compilationUnitTest() FAILED
    org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
        at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
        at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
        at app//org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
        at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
        at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
        at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
        at app//org.openrewrite.java.ChangeTypeTest.compilationUnitTest(ChangeTypeTest.java:2064)

As also detailed in Slack, we're exploring if this is perhaps due to the way this is tested, as a test like this passes:
@Issue("https://github.com/openrewrite/rewrite/issues/775")
@Test
void changeTypeInTypeDeclaration() {
    rewriteRun(
      spec -> spec.recipe(new ChangeType("de.Class2", "de.Class1", false)),
      java(
        """
          package de;
          public class Class2 {}
          """,
        """
          package de;
          public class Class1 {}
          """,
        spec -> spec.afterRecipe(cu -> {
            String simpleName = cu.getClasses().get(0).getSimpleName();
            assertThat(simpleName).isEqualTo("Class1");
        })
      )
    );
}

I looked into it and this happened due to the intermediate visitor that was introduced to determine whether we should apply the java visitor or the reference visitor. Restoring the previous behavior only took a small change to that.
We do however think this is an unintentional use of the ChangeType recipe and are curious if you could provide some more context (on slack) of the sequence of changes you're making so we can look at better supporting your use case!

@Laurens-W Thanks for the fix here! We have two general use cases in which we call ChangeType on only the J.ClassDeclaration and not the entire J.CompilationUnit.

We have a series of recipes that generate a new file, replace the J.CompilationUnit of an existing file with the J.CompilationUnit from the generated file, and then make a few additional modifications. At several points during these changes, there are Java syntax errors in the LST (e.g. the file name does not match the public class name) that can cause issues with calling ChangeType or other recipes on the entire J.CompilationUnit. However, we know that the J.ClassDeclaration object itself is free of syntax errors, so we use ChangeType to update the J.ClassDeclaration and then we fix the rest of the J.CompilationUnit manually. This use case is fairly specific to our situation, but the ability to call ChangeType on just a J.ClassDeclaration does provide a lot more flexibility in these cases.

Sometimes we want to change a type only in one specific class in the J.CompilationUnit, but keep this type in any other classes that may exist in the file. This is a more general use case that others may run into as well.


Round-robin DNS isn't random because clients are bad and should feel bad.

Long Thread: https://forums.rancher.com/t/dns-caching-issues/1566/12
TL;DR: many clients, including libc, do not return an IP address randomly when given multiple answers due to RFC 3484 (but not RFC 6724) sorting.
Rancher should return a single static virtual IP for each service and use iptables in the network agent to round-robin connections to it to one of the healthy service containers actually randomly.
There still needs to be a way to get the full list of IPs from DNS, so separate service.stack.all.rancher.internal A record or _exposedport._tcp.service.stack.rancher.internal SRV records should be created to preserve that use case.

LOL on the topic!
+1 to follow this.

Best title.

+1, actually this issue is quite serious:
If you have an apache frontend that proxypass your requests to several backend containers using the service hostname, DNS round robin wont happen. You have to use a load balancer, and it's not even the perfect solution because even by having one load balancer per host, there's great chance that a unique LB gets all the traffic and then reroute it correctly...

Any progress on this?

+1 👀

Any update on this?

+1 any updates? this has been open for almost a year now

Is there a plan when the proposed solution will be implemented? Does anyone know a workaround for this problem?

@mgamperl : We switched to K8S ;)

@cabrinoob completely or a k8s env in rancher instead of a cattle environment?

any update on this recently?
It was mentioned that it's fixed by network-services: v0.2.0 and rancher/dns:v0.15.0. in https://github.com/rancher/rancher/issues/7990
But looks like the round robin still not work in rancher 1.6.10 (network-services: v0.2.6 and rancher/dns:v0.15.3 ) .
Any workaround?  or did I miss some configuration?


MM-44130: Changed email button text

Summary
Test case fixed for email button text change
Related Pull Requests
https://github.com/mattermost/mattermost-server/pull/20288/files
Release Note
NONE

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/200660

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/200806

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/200854


Windows should prevent selecting things beneath

Example of what shouldn't be:

Does the window still prevent clicking on the object beneath?

Is it just highlighting or is input going through even with the window being clicked?

It's just highlighting AFAICT, so its really low priority; but it's a bit more confusing with windows such as the Hacking UI.


[Bug]: JS object does not display error for incorrect object structure in debugger

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
JS object does not recognize incorrect structure when code is copy-pasted and hence the default functions myFun1 and myFun2 are retained. No error is displayed either on the response or error tab of Debugger and only shows one when the function myFun1 or myFun2 are run.
Steps To Reproduce

Go to app at link or copy paste a chunk of code that does not follow our JS structure of export {}...
Observe the default functions retained even after the toast message informing of expected structure

Run any default function present in debugger and observe the error.

Environment
Release
Version
Cloud

The above case works as expected for copy-pasted code, but removing default structure export default {} retains default functions myFun1 and myFun2 in the debugger instead of showing a message as seen in the screenshot below.
https://www.loom.com/share/5eb8a2db83e44a5cbf96592a47f7f579

Unable to reproduce this issue

This issue is reproducible on current release and prod hence reopening it @bharath31


Architecture

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 830e1782-9caa-3533-10a0-85a3d4483d24
Version Independent ID: d66583fa-188c-9dce-b6fd-84b34c0bf315
Content: Real time processing - Azure Architecture Center
Content Source: docs/data-guide/big-data/real-time-processing.md
Service: architecture-center
Sub-service: azure-guide
GitHub Login: @ZoinerTejada
Microsoft Alias: pnp

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 391348

@hendramarcos Could you please elaborate on the feedback you intend to provide?

@hendramarcos Any further update here?

@hendramarcos We will now proceed to close this thread, but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


[ChartJS,FrappeJS,G2Plot,Google Charts,D3]=>[Javascript Chart Libraries]

Javascript Chart Libraries

Website
Description

ChartJS
Simple yet flexible JavaScript charting for designers & developers

FrappeJS
Includes Green squares grid like in github, and other charts to use.

G2Plot
G2Plot is an interactive and responsive charting library based on the grammar of graphics.

Google Charts
Get the experience from google to create similar charts that google use.

Data Driven Documents (D3)
bind complicated and massive data to interactive graphs.

Checklist:

[x] I have performed a self-review of submitted resource and its follows the guidelines of the project.

Pull request from #904


Add option to have no part of the file name pre-filled

There doesn't seem to be a way to have just the path show up in the field. I find that most of the time, the filled in file extension is not what I want.
{
	"newFile.defaultBaseFileName": "",
	"newFile.defaultFileExtension": ""
}

I set those options but the file extension is still filled in.

@bdougherty Any feedback on dkundel's answer?

The disableSmartExtension option sounds like a good solution to me.


Added option to disable reverse DNS lookups.

This commit makes the behavior of Ambry to use a reverse name lookup configurable. By default Ambry (old and current behavior) will do a reverse name lookup with DNS for every clustermap host. When the option clustermap.resolve.hostnames is set to false Ambry will trust the hostname in the clustermap to be the correct FQDN.
While I agree that reverse DNS should be configured correctly this is not always possible. For example we use Consul to lookup node names. Consul only supports reverse name lookups for local DC's. If you do a reverse name lookup for an IP in another DC Consul won't return a name. Also when a CNAME is used for an Ambry cluster host this will also break things. For comparison Kerberos originally also had a hard requirement to use the reverse resolved name of a host for a service principal. However in the end they also relaxed this because of issues with CNAME's and such.
I'm not really sure if the option name clustermap.resolve.hostnames is the best name for this option however it was the best I could think of at the moment.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d24775f). Click here to learn what that means.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master     #795   +/-   ##
=========================================
  Coverage          ?   66.51%
  Complexity        ?     4048
=========================================
  Files             ?      351
  Lines             ?    26410
  Branches          ?     3310
=========================================
  Hits              ?    17567
  Misses            ?     7911
  Partials          ?      932

Impacted Files
Coverage Δ
Complexity Δ

...java/com.github.ambry/config/ClusterMapConfig.java
100% <100%> (ø)
1 <0> (?)

...ava/com.github.ambry.clustermap/AmbryDatanode.java
76.36% <40%> (ø)
0 <0> (?)

...ain/java/com.github.ambry.clustermap/DataNode.java
83.59% <42.85%> (ø)
46 <1> (?)

...va/com.github.ambry.clustermap/HardwareLayout.java
82.11% <66.66%> (ø)
53 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d24775f...12ee7bf. Read the comment docs.

I've added some clarification in the javadoc. Is that the place you meant? Or did you mean in an exampl config file? Let me know and i'll update it if needed!
The biggest risk I can see is that after disabling the reverse lookups Ambry can't validate the host on which it is deployed is actually called that. I've added some text in the javadoc which states you should only disable it if you need it (for example when using CNAME's). Also explicitly called out this risk in the javadocs.

Yup, the config documentation is what I meant, thanks for adding !


perspective projection

Hi, thanks for your wonderful work!
I am wondering that why the pred_cam_t[3] is
    pred_cam_t = torch.stack([pred_cam[:, 1],
                              pred_cam[:, 2],
                              2*focal_length[:, 0]/(self.cfg.MODEL.IMAGE_SIZE * pred_cam[:, 0] +1e-9)],dim=-1)

I look forward to your reply, Thanks

In this case, the original pred_cam[:,0] value corresponds to s, the scaling factor of the weak perspective projection, which approximates f/Z. So the depth of the human is Z = f/s. Then, we also divide by the factor bbox_size/2, so that we project the human to [-0.5,0.5].

Thanks again. In addition, why focal length changes with image size? Thanks

scaled_focal_length = model_cfg.EXTRA.FOCAL_LENGTH / model_cfg.MODEL.IMAGE_SIZE * img_size.max()
pred_keypoints_2d = perspective_projection(pred_keypoints_3d,
translation=pred_cam_t,
focal_length=focal_length / self.cfg.MODEL.IMAGE_SIZE)

Thanks again

In this case, the original pred_cam[:,0] value corresponds to s, the scaling factor of the weak perspective projection, which approximates f/Z. So the depth of the human is Z = f/s. Then, we also divide by the factor bbox_size/2, so that we project the human to [-0.5,0.5].

You mean normalize to [-1, 1]?


Remove leftover app.so references

This file is now app.dylib.

@tvolkert
Found using "git grep app.so"

git grep - learn something new every day :-)
LGTM - thanks for the cleanup

git grep is super useful.  😄


MNT Add behat test for previewing elemental blocks

Requires silverstripe/silverstripe-behat-extension#214
Tests non-inline-editable blocks can be previewed (functionality was fixed/added in #936)

@emteknetnz I found a way around the template conundrum! I'm surprised a TestOnly extension works to be honest, since it's in the context of the actual runtime of the site - but it works! 🎉

Some of the (unrelated to this PR) tests are failing, but they pass locally if I merge this into 4. I've rebased which should resolve the issues travis was having.

Ahh! These tests pass if I run them independently, but if I run the suite as a whole they fail. All of the tests that run after the new test are the ones which are failing.
I have discovered that this is caused by I set the CMS mode to "Preview mode" - It was still on preview mode when the remaining tests were meant to be performed because that is stored in the session. I have updated the tests to set back to edit mode.
@emteknetnz Since this is a change to the PR I probably need re-approval.

Travis is red

Travis is now green! Composer got stuck (transport error) - restarting the job fixed it.


New BookInsanityRemake font has error in quotation marks

v3/Chrome 92/macOS
BookInsanityRemake seems to have new glyphs for the double and single quotation mark characters and they are "side specific", rather than uniform regardless of opening or closing as they were previously.  Now, when typing it seems the opening mark is not correct.

This may be a macOS issue though?  I looked at this question/answer on the apple forums for help and tried turning off "smart quotes" feature, to no avail.  I also did option ] and I did get the correct glyph.  So perhaps the glyph exists in the font set, but just isn't coded right?
Ugh, i've tried figuring out how font metadata works using FontForge but not with much success...

I believe there's actually a setting in Marked.js to be state the correct glyph for us. I'll take a look.

Pushed an update to fix this.


fix(vertices_around_vertex): fix ABI

:tada: This PR is included in version 4.0.7-rc.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.0.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Extract proportions instead of raw numbers

Problems:-

database incomplete with regards to proportions
even if it was complete, would be different for the different Bayesian filters that exclude patients from studies that preselected patients based on prior knowledge of the EZ,

benefits:

allows confidence interval calculation and application of weightings
may also help mitigate publication biases

e3b3347


Allow Time.parse to return UTC times

Unless I'm misinterpreting what the meaning Time::Kind I think it'd be useful to be able to get a utc time out of Time.parse
I ran into this being missing when adding support for timestamps in github.com/will/crystal-pg . In addition to this, I also discovered that there wasn't a way to parse out msec or offsets, so I'm instead just using StringScanner which is alright.

Looks good, thanks!
The time parser still doesn't handle timezones, but once it does I think the kind will specify the kind to use if a timezone can't be found. For example, if Z is found as a timezone and you didn't specify a kind, the returned time will probably be UTC. If you specify local and a Z is found, the time will be converted to local, and so on... But for now this addition is perfect.

Makes sense, thanks!


DMCN27WW tested and worked

I've just tested this on DMCN27WW and it works.
Also, Agreed should be Y/N. Now it is: Agree? (y/Y)

thanks for testing. Extended the list of supported versions in ab99e7184756e8dd3b0383bd8cca115e17838906 and fixed Prompt options.


Chrisda to Main

Docs Build status updates of commit b612c3b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/mapping/serviceMapping.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


add yumemiriamu and other achievements

Codecov Report

Merging #139 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage    44.4%   44.37%   -0.03%
==========================================
  Files          39       39
  Lines        3896     3896
  Branches      795      795
==========================================
- Hits         1730     1729       -1
- Misses       1703     1704       +1
  Partials      463      463

Impacted Files
Coverage Δ

achievements/achievements.ts
100% <ø> (ø)
:arrow_up:

sushi-bot/index.js
60.62% <0%> (-0.79%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d28763...a4d6824. Read the comment docs.


Sheet-meister 2000 Cloth recipe

About the PR
The Sheet-meister 2000 is now able to make cloth more efficiently, and faster than by hand.
Why / Balance
Cloth has a few ways of being made, most of which are fairly tedious, or inefficient. Cloth is able to be woven by hand, using 4 cotton bolls. The new recipe, requires 2 bolls and is significantly faster, while being able to queue multiple pieces. The silk recipe was not added.
Technical details
New material, cotton. Can only be used in the sheet-meister, to be used to convert cotton to cloth for a 2 boll to 1 roll ratio.
Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:

add: Cloth is now able to be made in the Sheet-Meister 2000

shouldn't this be something a loom should do?

Could one for silk get added too? 👀


feat(cdk/testing): be more lenient in HarnessQuery

Feature Description
We find the TestElement/ComponentHarness API exposed in @angular/cdk/testing very useful, especially because it decouples much of the test code from the actual environment the test runs in.
We want to use this for non-Angular projects, where pulling in @angular/cdk is a no-go. More specifically, we want to use this to create harnesses for web components, some of which will then end up being used in Angular applications.
We've created our own implementation of these types and we're trying to make these compatible with Angular types so that the web component library can use the non-Angular version but these harnesses can then still be used in Angular ComponentHarnesses.
We've nearly gotten to the point where everything works, there's only one thing we cannot resolve: the HarnessQuery used in the LocatorFactory interface's functions references the HarnessPredicate class which has private properties.
This makes "our" version of HarnessQuery and the Angular version inherently incompatible according to typescript.
This could be a small change, e.g. limiting the type in HarnessQuery to only the required properties:
 export type HarnessQuery<T extends ComponentHarness> =
   | ComponentHarnessConstructor<T>
-  | HarnessPredicate<T>;
+  | Pick<HarnessPredicate<T>, 'getDescription' | 'getSelector' | 'harnessType'>

and in the harness-environment.ts file use a new function instead of query instanceof HarnessPredicate
function isHarnessPredicate<T extends ComponentHarness>(value: HarnessQuery<T>): value is Pick<HarnessPredicate<T>, 'getDescription' | 'getSelector' | 'harnessType'> {
  return 'harnessType' in value;
}

Use Case
As mentioned above, we want to use the component harness concept in a non-Angular context and we want those harnesses to be compatible with harnesses written using the CDK and the CDK's harness environments.
An alternative solution could be to extract part of @angular/cdk/testing into a separate package that doesn't have any dependencies to the Angular framework. That way we wouldn't have to maintain our own copy of these types/classes.

This is not a use case we want to support. The ability to use these harnesses outside of an Angular context is outside of the scope of what we can be reasonably expected to maintain. A word of caution: if you choose to work around this there is no guarantee that future changes will not break you


remove size check for tmp directory

Fixes #
related issue https://github.com/Kopano-dev/kopano-docker/issues/26#issue-1175950951

Thanks @deatheibon I have just merged it.
Fixes https://github.com/Kopano-dev/kopano-docker/issues/26


Provide directions to locations specified within an event

Background
Split out from #7639
Now that events can have multiple locations attached, we need to establish how these (and directions to them) are displayed on an event. Currently, we show information about only the first location in the yellow box, under the heading Location.
User story
As a user
I want to know where an event is scheduled to take place
So I can make the necessary arrangements to attend
Acceptance criteria
Directions to location(s) are clearly specified within an event

@cbowskill Just wanted to make sure you were aware of this issue


Monitor test function

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
UI Feature
🔖 Feature description
Recently, I've added some monitors in batch.
Some of them did not work at first, because the expected HTTP code or redirect count was wrong - no big deal. After adding these monitors, they immediately failed. Then I had to edit and fix them. Then I deleted the corresponding events/heartbeats to have a clean start.
It would be nice to be able to test a monitor before saving.
✔ Solution
A test button next to the save button.
❓ Alternatives
Getting the necessary information (redirect count etc) upfront. But when adding many monitors in batch, trial & error & fixing is probably faster 😉
📝 Additional Context
No response

@casperklein
We are consolidating duplicate issues a bit to make issue management easier.
I think, we should track this issue in #2725 as there is no functional difference and said issue is more popular + had a more in-depth discussion.
⇒ I am going to close this as a duplicate (despite this being the earlier one ^^)


fix(macOS): fix race condition in webview handler

https://github.com/tauri-apps/tauri/issues/5519#issuecomment-2495380378

Does this really help? We already check this 2 instructions above in check_webview_id_valid 🤔

Does this really help? We already check this 2 instructions above in check_webview_id_valid 🤔

work like a charm.
  14:        0x103430874 - core::panicking::panic_fmt::ha4b80a05b9fff47a
                               at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panicking.rs:74:14
  15:        0x102fa8054 - objc2::__macro_helpers::declared_ivars::get_initialized_ivar_ptr::h92376258763b2729
                               at /Users/linw1995/.cargo/registry/src/index.crates.io-6f17d22bba15001f/objc2-0.5.2/src/__macro_helpers/declared_ivars.rs:403:17
  16:        0x102f9dc44 - objc2::top_level_traits::DeclaredClass::ivars_mut::h2f3cb44ff3ce2dab
                               at /Users/linw1995/.cargo/registry/src/index.crates.io-6f17d22bba15001f/objc2-0.5.2/src/top_level_traits.rs:355:34
  17:        0x102fa0474 - wry::wkwebview::class::wry_web_view::WryWebView::remove_custom_task_key::hd2a6c5fea7c15784
                               at /Users/linw1995/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wry-0.47.1/src/wkwebview/class/wry_web_view.rs:149:5

Simply performing checks is not enough; it needs to be locked to prevent race conditions.

I think this will mitigate the problem, however it could still happen if the webview is closed just before calling remove_custom_task_key.
MacOS expects us to use the NSExecption to tell if the task is dead, but that's impossible for now. The async command will be unreliable on MacOS until Objc2 can bubble up an NSException instead of panicking so that we can remove those weird checks.


feat(components): Add layout components

stories for layout components are ready @coreyar

stories for layout components are ready @coreyar

It looks like the responsiveness of the Dashboard changed. The main thing I'd call out is the capitalization changed on the connect button.

stories for layout components are ready @coreyar

It looks like the responsiveness of the Dashboard changed. The main thing I'd call out is the capitalization changed on the connect button.

yes, we don't need capitalization in buttons, like on current production version

I also set up the layout: 'fullscreen' in preview.js in case of paddings in body for storybooks preview.


Generating strongly typed resource files not currently supported on .NET Core MSBuild

From @iSazonov on July 6, 2017 13:41
What is a right repo to ask about ResGen in dotnet build?
Currently I try to generate strongly typed resources and get error:
C:\Users\user\AppData\Local\Microsoft\dotnet\sdk\2.0.0-preview2-006502\Microsoft.Common.CurrentVersion.targets(2921,5): error : Generating strongly typed resource files not currently supported on .NET Core MSBuild [C:\Users\user\Documents\GitHub\iSazonov\PowerShell\src\Microsoft.PowerShell.CoreCLR.Eventing\Microsoft.PowerShell.CoreCLR.Eventing.csproj]
From related Issue https://github.com/dotnet/cli/issues/819:

dotnet-resgen  got replaced by the  Microsoft.Net.Sdk  implementation, so closing this.

Is strongly typed resources supported?
Copied from original issue: dotnet/cli#7084

From @wli3 on July 6, 2017 17:9
Hi iSazonov,
Could you try to add resx files like this? https://github.com/dotnet/sdk/blob/cd25d6bbfc2aac61cc790c511900427ac64fdaa8/TestAssets/TestProjects/KitchenSink/TestApp/TestApp.csproj#L24
(This is a part of SDK automatic test asset)

From @wli3 on July 6, 2017 17:35
Hi @iSazonov ,
I think I misunderstood you. Looks like your project is in Github, could you share the specific strongly typed config code link?

From @iSazonov on July 6, 2017 17:41
@wli3 I'll publish the sample tomorrow from my local branch.

From @iSazonov on July 6, 2017 17:29
@wli3 Thanks! Please clarify - I don't see strongly typed config in the csproj.

From @iSazonov on July 7, 2017 5:34
I published my test. See last <ItemGroup> in  https://github.com/iSazonov/PowerShell/blob/cproj-psversion-from-git-resx/src/Microsoft.PowerShell.CoreCLR.Eventing/Microsoft.PowerShell.CoreCLR.Eventing.csproj
Build command:
dotnet msbuild /t:"ResGen" /v:diag /noconsolelogger /fileLogger .\Microsoft.PowerShell.CoreCLR.Eventing.csproj
or
dotnet build /t:"ResGen" /v:diag /noconsolelogger /fileLogger .\Microsoft.PowerShell.CoreCLR.Eventing.csproj

I believe error place is here
Is the project compiled without FEATURE_CODEDOM?

I am moving this issue over to MSBuild. FYI @rainersigwald

Huh, we should have had an issue open for this already but I couldn't find one.

Is the project compiled without FEATURE_CODEDOM?

Yes, it is: CodeDOM wasn't available at the time of the initial port to .NET Core and we haven't lit up this feature after the initial port.
It looks like CodeDOM is available in .NET Core 2.0 (for code-writing scenarios, though not compilation), so we should be able to enable that feature flag everywhere after we move to targeting .NET Core 2.0.
Workarounds
Build with full framework MSBuild.exe (on a Windows machine).
Check in the (generated) .cs files and update them when necessary (from Windows/full framework).

@rainersigwald Thanks!
PowerShell Core is multiplatform project and we cannot use MSBuild.exe. Currently we use a simple tool developed by @vors.

It looks like CodeDOM is available in .NET Core 2.0

Yes, it is. So I believe it is easy to fix the Issue.

Hello Team, I am sorry if I am asking silly question: So what I understand is that if I am using dotnet sdk on my Mac & vscode for editing, I can't create a strongly typed controller from db ?
(I know there is visual studio version now available for Mac).
Thanks 👍

Team, .Net Core 2.0 RTM was out - could you please milestone the Issue?

Team, .Net Core 2.0 RTM was out - could you please milestone the Issue?

@livarcocc, when is this feature going to be supported. Absence of this makes it difficult to build code from Linux, i.e. requires manual overhead of generating and checking in strongly typed resource access wrapper.

From a quick look this morning, CodeDOM is not enough to bring this back: the task also depends on System.Resources.ResXResourceReader which is full-framework only.

Should we open an API proposal for ResXResourceReader in CoreFX repo? https://github.com/dotnet/corefx/issues/12565 and https://github.com/Microsoft/msbuild/issues/1352 seem related issues.

Discussed with @rainersigwald offline. I think it is worth trying to bring this back without waiting for ResXResourceReader (whose port is not scheduled currently)
My suspicion (just from browsing the code) is that ResxResourcrReader/ResXDataNode are not necessary for this scenario. StronglyTypedResourceBuilder hardly depends on them and it looks like those code paths can probably be removed.
Happily MSBuild happens to already have a copy of StronglyTypedResourceBuilder.cs because I guess historically they had a reason for avoiding a dependency on System.Design.dll. (Maybe it was only in the SDK?). I compared it with .NET Framework's current copy and it's basically the same.
I think someone could take a shot at wiring this up now.

@kasper3 any interst in taking a look?

@danmosemsft, I tried building msbuild master on Windows 10, msbuild\build.cmd -hostType Core and getting errors like:

C:\Users\kasper.nuget\packages\nerdbank.gitversioning\2.1.23\build\Nerdbank.GitVersioning.targets(63,5): error MSB4018:    at LibGit2Sharp.Core.Proxy.git_revwalk_next(RevWalkerHandle walker) [C:\Users\kasper\Source\Repos\msbuild\src\Samples\TaskUsageLogger\TaskUsageLogger.csproj]

Tried in three modes: Developer Command Prompt VS2017, normal cmd, normal PowerShell.

Uh, I have no idea what that means. Is there any more information like callstack or message? Is this a fresh new clone - if not I would delete it and clone again?

I just cloned the repo, tip of master branch. Call stack:
C:\Users\kasper\.nuget\packages\nerdbank.gitversioning\2.1.23\build\Nerdbank.GitVersioning.targets(63,5): error MSB4018: The "Nerdbank.GitVersioning.Tasks.GetBuildVersion" task failed unexpectedly. [C:\Users\kasper\Source\Repos\msbuild\src\Samples\XmlFileLogger\XmlFileLogger.csproj]
C:\Users\kasper\.nuget\packages\nerdbank.gitversioning\2.1.23\build\Nerdbank.GitVersioning.targets(63,5): error MSB4018: LibGit2Sharp.NotFoundException: object not found - no match for id (7c1f7a8cd8f2b844046892036912db28a7ec4c37) [C:\Users\kasper\Source\Repos\msbuild\src\Samples\XmlFileLogger\XmlFileLogger.csproj]
C:\Users\kasper\.nuget\packages\nerdbank.gitversioning\2.1.23\build\Nerdbank.GitVersioning.targets(63,5): error MSB4018:    at LibGit2Sharp.Core.Ensure.HandleError(Int32 result) [C:\Users\kasper\Source\Repos\msbuild\src\Samples\XmlFileLogger\XmlFileLogger.csproj]
C:\Users\kasper\.nuget\packages\nerdbank.gitversioning\2.1.23\build\Nerdbank.GitVersioning.targets(63,5): error MSB4018:    at LibGit2Sharp.Core.Proxy.git_revwalk_next(RevWalkerHandle walker) [C:\Users\kasper\Source\Repos\msbuild\src\Samples\XmlFileLogger\XmlFileLogger.csproj]
C:\Users\kasper\.nuget\packages\nerdbank.gitversioning\2.1.23\build\Nerdbank.GitVersioning.targets(63,5): error MSB4018:    at LibGit2Sharp.CommitLog.CommitEnumerator.MoveNext() [C:\Users\kasper\Source\Repos\msbuild\src\Samples\XmlFileLogger\XmlFileLogger.csproj]
C:\Users\kasper\.nuget\packages\nerdbank.gitversioning\2.1.23\build\Nerdbank.GitVersioning.targets(63,5): error MSB4018:    at System.Linq.Enumerable.TryGetFirst[TSource](IEnumerable`1 source, Boolean& found) [C:\Users\kasper\Source\Repos\msbuild\src\Samples\XmlFileLogger\XmlFileLogger.csproj]
C:\Users\kasper\.nuget\packages\nerdbank.gitversioning\2.1.23\build\Nerdbank.GitVersioning.targets(63,5): error MSB4018:    at Nerdbank.GitVersioning.VersionOracle..ctor(String projectDirectory, Repository repo, ICloudBuild cloudBuild, Nullable`1 overrideBuildNumberOffset, String projectPathRelativeToGitRepoRoot) [C:\Users\kasper\Source\Repos\msbuild\src\Samples\XmlFileLogger\XmlFileLogger.csproj]
C:\Users\kasper\.nuget\packages\nerdbank.gitversioning\2.1.23\build\Nerdbank.GitVersioning.targets(63,5): error MSB4018:    at Nerdbank.GitVersioning.VersionOracle.Create(String projectDirectory, String gitRepoDirectory, ICloudBuild cloudBuild, Nullable`1 overrideBuildNumberOffset, String projectPathRelativeToGitRepoRoot) [C:\Users\kasper\Source\Repos\msbuild\src\Samples\XmlFileLogger\XmlFileLogger.csproj]
C:\Users\kasper\.nuget\packages\nerdbank.gitversioning\2.1.23\build\Nerdbank.GitVersioning.targets(63,5): error MSB4018:    at Nerdbank.GitVersioning.Tasks.GetBuildVersion.ExecuteInner() [C:\Users\kasper\Source\Repos\msbuild\src\Samples\XmlFileLogger\XmlFileLogger.csproj]

git log -1
commit e8b480c373eadd9daa975c6e96e4dbbabcd9a4fe

Shallow clone?
https://github.com/libgit2/libgit2sharp/issues/1351

Yes, that was it.. I had git clone <url> --single-branch --depth 1, unshallowed it using https://stackoverflow.com/a/17937889 🐕
Maybe something like https://github.com/dotnet/buildtools/pull/1977/files can be used to have safe rev-parsing, with git-describe command changed to git describe --always --abbrev=0 --match "NOT A TAG", to get hash, since Libgit2 does not support shallow clones.

Since our version numbers are commit-height based, we wouldn't support shallow clones regardless of libgit2sharp support. The experience could surely be better though, sorry you ran into this @kasper3.

@kasper3 if it's helpful, I pushed my WIP to https://github.com/rainersigwald/msbuild/tree/strongly-typed-resgen.
I also ran under a debugger to see which of these codepaths was hit in the sample project https://github.com/iSazonov/PowerShell/blob/cproj-psversion-from-git-resx/src/Microsoft.PowerShell.CoreCLR.Eventing/Microsoft.PowerShell.CoreCLR.Eventing.csproj:
https://github.com/Microsoft/msbuild/blob/e8b480c373eadd9daa975c6e96e4dbbabcd9a4fe/src/Tasks/system.design/stronglytypedresourcebuilder.cs#L122-L143
Despite the "this will be rare after Whidbey M3" (that's Visual Studio 2005) comment, that's the path that was traversed. If that's all that's ever used it'd make the port much easier.

@rainersigwald, thanks for the WIP branch. Seems like StronglyTypedResourceBuilder.Create method ends up requiring ResXDataNode, which is not available on .NET Core today. Should we port some code from https://referencesource.microsoft.com/#System.Windows.Forms/winforms/Managed/System/Resources/ResXDataNode.cs into MSBuild repo (internal types), unless there is a better workaround? :)

@kasper3 That's what I was investigating under the debugger: it looks like we could just #if out that code for .net core, and not lose any functionality. It didn't appear to be hit in the simple strongly-typed-resource scenario I was trying.

After applying this patch on top of @rainersigwald's branch:
diff --git a/src/Tasks/system.design/stronglytypedresourcebuilder.cs b/src/Tasks/system.design/stronglytypedresourcebuilder.cs
index 332ff638..49976ec2 100644
--- a/src/Tasks/system.design/stronglytypedresourcebuilder.cs
+++ b/src/Tasks/system.design/stronglytypedresourcebuilder.cs
@@ -119,27 +119,11 @@ namespace Microsoft.Build.Tasks
             Dictionary<String, ResourceData> resourceTypes = new Dictionary<String, ResourceData>(StringComparer.InvariantCultureIgnoreCase);
             foreach (DictionaryEntry de in resourceList)
             {
-                ResXDataNode node = de.Value as ResXDataNode;
-                ResourceData data;
-                if (node != null)
-                {
-                    string keyname = (string)de.Key;
-                    if (keyname != node.Name)
-                        throw new ArgumentException(SR.GetString(SR.MismatchedResourceName, keyname, node.Name));
-
-                    String typeName = node.GetValueTypeName((AssemblyName[])null);
-                    Type type = Type.GetType(typeName);
-                    String valueAsString = node.GetValue((AssemblyName[])null).ToString();
-                    data = new ResourceData(type, valueAsString);
-                }
-                else
-                {
-                    // If the object is null, we don't have a good way of guessing the
-                    // type.  Use Object.  This will be rare after WinForms gets away
-                    // from their resource pull model in Whidbey M3.
-                    Type type = (de.Value == null) ? typeof(Object) : de.Value.GetType();
-                    data = new ResourceData(type, de.Value == null ? null : de.Value.ToString());
-                }
+                // If the object is null, we don't have a good way of guessing the
+                // type.  Use Object.  This will be rare after WinForms gets away
+                // from their resource pull model in Whidbey M3.
+                Type type = (de.Value == null) ? typeof(Object) : de.Value.GetType();
+                var data = new ResourceData(type, de.Value == null ? null : de.Value.ToString());
                 resourceTypes.Add((String)de.Key, data);
             }

@@ -260,39 +244,6 @@ namespace Microsoft.Build.Tasks
             return ccu;
         }

-        internal static CodeCompileUnit Create(String resxFile, String baseName, String generatedCodeNamespace, CodeDomProvider codeProvider, bool internalClass, out String[] unmatchable)
-        {
-            return Create(resxFile, baseName, generatedCodeNamespace, null, codeProvider, internalClass, out unmatchable);
-        }
-
-        [SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly")]
-        internal static CodeCompileUnit Create(String resxFile, String baseName, String generatedCodeNamespace, String resourcesNamespace, CodeDomProvider codeProvider, bool internalClass, out String[] unmatchable)
-        {
-            if (resxFile == null)
-                throw new ArgumentNullException("resxFile");
-
-            // Read the resources from a ResX file into a dictionary - name & type name
-            Dictionary<String, ResourceData> resourceList = new Dictionary<String, ResourceData>(StringComparer.InvariantCultureIgnoreCase);
-            using (ResXResourceReader rr = new ResXResourceReader(resxFile))
-            {
-                rr.UseResXDataNodes = true;
-                foreach (DictionaryEntry de in rr)
-                {
-                    ResXDataNode node = (ResXDataNode)de.Value;
-                    String typeName = node.GetValueTypeName((AssemblyName[])null);
-                    Type type = Type.GetType(typeName);
-                    String valueAsString = node.GetValue((AssemblyName[])null).ToString();
-                    ResourceData data = new ResourceData(type, valueAsString);
-                    resourceList.Add((String)de.Key, data);
-                }
-            }
-
-            // Note we still need to verify the resource names are valid language
-            // keywords, etc.  So there's no point to duplicating the code above.
-
-            return InternalCreate(resourceList, baseName, generatedCodeNamespace, resourcesNamespace, codeProvider, internalClass, out unmatchable);
-        }
-
         private static void AddGeneratedCodeAttributeforMember(CodeTypeMember typeMember)
         {
             CodeAttributeDeclaration generatedCodeAttrib = new CodeAttributeDeclaration(new CodeTypeReference(typeof(System.CodeDom.Compiler.GeneratedCodeAttribute)));

I am getting SR is inaccessible due to its protection level.

I can't see the rest is the code on my phone but my guess is that the STR class is pulling some resource strings  using SR.XXX and needs to change to follow however rest of MSBuild code does it?

Did this issue make any forward progress since the last post? I'm looking into this for a project I'm working on and wondering if we should expect a fix soon or if we should roll a workaround.

@nathansoz I don't think so. I suspect they'd welcome a PR. It seemed at the time like there was likely not much work.

I assume this now impacts the winforms/wpf-on-.net-core scenario?
Would this require msbuild to run on the winforms/wpf shared framework to get the required generation/seralization assemblies used on the full-fx msbuild version? Or does it need a clean re-implementation to make sure the resulting assemblies are compatible for both net* and netcoreapp* applications built using Core MSBuild?

Just to clarify, does this mean we are still unable to generate resx file with msbuild on .NET Core at build time?

Correct. We expect to resolve this with .NET Core 3.0. Most of the discussion on that is going on in #2221.

I think it's possible to do this part (generate C# from the resx) without the full task. #3819 is an attempt to do so.
In the end we should make sure both scenarios work, so I'd keep both open but I don't have strong feelings about it.

@rainersigwald I see you've already completed some work in #4420 but you also call out some work such as 'Check to ensure that the reader type is available when not targeting netcoreapp3.0' (which is ticked now).
Does this mean that a project targeting .Net Standard (2.0) can already auto-generate the *.Designer.cs files (in my case just the simple case of only strings)? Using preview8, it does not seem to that at the moment or is a property needed to opt into this at the moment for netstandard2.0 projects? Thanks.

@bergmeister That wasn't directly related to code generation, and StronglyTypedResourceGenerator doesn't work in preview8. #4588 should enable it in the future, though.
If your code is open source, I can add it to the set of things I'm testing before merging that PR. Just feed me a link :)

@rainersigwald Thanks for the quick answer. An example project that you could use for testing is this one: https://github.com/PowerShell/PSScriptAnalyzer/tree/master/Engine
Just remove the Strings.Designer.cs file, remove the global.json one directory above and then just type dotnet build (all NuGet packages are on NuGet.org so everything should just build out of the box).

@rainersigwald I tried to use Preview9 on my project (links in last comment) but dotnet build does not create me the strongly typed .cs file from .resx file although the csproj has the following:
  <ItemGroup>
    <Compile Update="Strings.Designer.cs">
      <DesignTime>True</DesignTime>
      <AutoGen>True</AutoGen>
      <DependentUpon>Strings.resx</DependentUpon>
    </Compile>
  </ItemGroup>

  <ItemGroup>
    <EmbeddedResource Update="Strings.resx">
      <Generator>ResXFileCodeGenerator</Generator>
      <LastGenOutput>Strings.Designer.cs</LastGenOutput>
    </EmbeddedResource>
  </ItemGroup>

Am I am missing something, is there something that needs to be enabled explicitly for a .net standard (2.0) library?

@bergmeister Yes, this is fairly confusing: your build was configured so that building inside Visual Studio would regenerate the source files, but building on the command line would not (regardless of whether it was msbuild.exe or dotnet build doing it).
When I tested your repo I applied this patch to change to build-time generation in all cases:
diff --git a/Engine/Engine.csproj b/Engine/Engine.csproj
index 560ce8d..2fca8db 100644
--- a/Engine/Engine.csproj
+++ b/Engine/Engine.csproj
@@ -46,18 +46,19 @@
     <PackageReference Include="Microsoft.CSharp" Version="4.5.0" />
   </ItemGroup>

-  <ItemGroup>
+  <!-- <ItemGroup>
     <Compile Update="Strings.Designer.cs">
       <DesignTime>True</DesignTime>
       <AutoGen>True</AutoGen>
       <DependentUpon>Strings.resx</DependentUpon>
     </Compile>
-  </ItemGroup>
+  </ItemGroup> -->

   <ItemGroup>
     <EmbeddedResource Update="Strings.resx">
       <Generator>ResXFileCodeGenerator</Generator>
-      <LastGenOutput>Strings.Designer.cs</LastGenOutput>
+      <StronglyTypedFileName>$(IntermediateOutputPath)\Strings.Designer.cs</StronglyTypedFileName>
+      <StronglyTypedLanguage>CSharp</StronglyTypedLanguage>
     </EmbeddedResource>
   </ItemGroup>

@rainersigwald Thanks for the info, however, even with the rc1 of .Net Core 3 and your local changes, it does not work for me

@bergmeister Can you please file a new issue with details? How exactly does it fail to work--build error? Runtime failure doing something in particular?

Ok, I can create an issue with a minimized repro.
It fails on build due to the Strings.Designer.cs not being created by the build (I deleted the file locally as I'd expect dotnet build to create it automatically, is my assumption here right?)

Yes, that's correct--the copy in the checked-in tree is not needed when switching over to build-time generation.

@bergmeister, I think I've reproduced the problem; it looks like something's gone wrong with the namespace/class name that we're generating. Don't worry about minimizing but please do file a bug.

@bergmeister with this I can get your project to compile:
diff --git a/Engine/Engine.csproj b/Engine/Engine.csproj
index 560ce8d..e1f143b 100644
--- a/Engine/Engine.csproj
+++ b/Engine/Engine.csproj
@@ -46,18 +46,21 @@
     <PackageReference Include="Microsoft.CSharp" Version="4.5.0" />
   </ItemGroup>

-  <ItemGroup>
+  <!-- <ItemGroup>
     <Compile Update="Strings.Designer.cs">
       <DesignTime>True</DesignTime>
       <AutoGen>True</AutoGen>
       <DependentUpon>Strings.resx</DependentUpon>
     </Compile>
-  </ItemGroup>
+  </ItemGroup> -->

   <ItemGroup>
     <EmbeddedResource Update="Strings.resx">
       <Generator>ResXFileCodeGenerator</Generator>
-      <LastGenOutput>Strings.Designer.cs</LastGenOutput>
+      <StronglyTypedFileName>$(IntermediateOutputPath)\Strings.Designer.cs</StronglyTypedFileName>
+      <StronglyTypedLanguage>CSharp</StronglyTypedLanguage>
+      <StronglyTypedNamespace>Microsoft.Windows.PowerShell.ScriptAnalyzer</StronglyTypedNamespace>
+      <StronglyTypedClassName>Strings</StronglyTypedClassName>
     </EmbeddedResource>
   </ItemGroup>

We can chase down exactly why all this is necessary in your bug.

Thanks, it works now with your 2 new lines.
The StronglyTypedNamespace line seems to be only necessary because we have the following in the csproj (from the days when we converted from project.json to the new csproj format to make it work using Visual Studio)
<RootNamespace>Microsoft.Windows.PowerShell.ScriptAnalyzer</RootNamespace>
Now that the command line works, we don't care about Visual Studio too much tbh but I will check that later today (using VS 16.2.5 somehow the setting to allow VS to use preview SDKs has gone or can I use the VS Preview for that now only?)
Is the StronglyTypedClassName property needed due to the resx file not matching the project name? I tried renaming it to Engine.resx and changed the references in the csproj but the property was still needed then.
Should I file the 'bug' to be specific about this project or rather generic that those properties seem to be needed? As a user I can be flexible, but I'd like to know what is the cleanest/simplest csproj declaration to have this working (optionally also in a way that it works with VS)

File whatever's easiest for you and we can broaden/narrow it as we investigate.


fix dead code and clean code format

default section is never hit due to Strings.Count
limitation and strings.SplitN slice, in other words,
the part is dead code, this patch will fix it.
apis.opts.mountpoint: fix dead code
apis.opts.mountpoint_test: clean code format
Signed-off-by: Alex Jia<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

LGTM, while I would like to invite @rudyfly to take another review.


Incorrect type error with kebab-cased "aria-*" props

Vue version
3.4.21
Link to minimal reproduction
https://play.vuejs.org/#eNqlk19v0zAUxb/KxS8DaUnFn6cqTGJTkUAIJthjJOQ6t6lXx7aunaxo6nfn2mlDB1sf2Jvte/zzyb0n9+KD9+XQo5iLKijSPkLA2Hsw0rbvaxFDLS5qqzvvKMJH52BFroOzcsbrdPFsKl5Kmoq83her2YhlCG8idt7IiLwDqF4UBWxwKZeFkgHBk2t6hQGkBSRyBEUxCtO7krQsjFyiSbZ+eRw1tYBZZu95SnZorhLuztGGWQFw61FFbP7BfTnQ1jqM8r9pLq6Rjjw2YJk/ih9FpyYE1yEjbVugCXjgSxPcg0eq2VE3xDm3Wjm70m15G5zledwnYC2U67w2SN981M7y5TnkSqpJY9zd53wWqcfzw7lao9o8cn4btumsFteEAWnAWky1KKnFOJYXP77iltdTsePJGFafKH7H4EyfPI6yy942bPtIl91+ymHh5tyExTaiDYePSkaTcpf1teD4XJ349D9235bv8r3a7riL+1ieyjO0aJG04u1NTneDK23xmpwPVX5gCsccQiQ2y+yLl69Op7nRAwxF5N4weCI8Mez9D/I8m1PQFpyz/7b6gPKE3Z8DUpoU++V2l29ei91v4ClrVA==
Steps to reproduce

Create a component with a prop name of "ariaLabel"
Render that component with a valid value as aria-label

What is expected?
No type errors should be thrown
What is actually happening?
The kebab-cased version of an aria-* prop will produce a type error. This is true of all aria properties, not just valid ones. For example, aria-whoops will also produce an error.
Argument of type '{ "aria-label": string; }' is not assignable to parameter of type '{ ariaLabel: string; } & VNodeProps & AllowedComponentProps & ComponentCustomProps & Record<string, unknown>'.
  Property 'ariaLabel' is missing in type '{ "aria-label": string; }' but required in type '{ ariaLabel: string; }'.

System Info
System:
    OS: macOS 13.2.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 740.64 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.15.0 - ~/.nvm/versions/node/v18.15.0/bin/node
    npm: 9.5.0 - ~/.nvm/versions/node/v18.15.0/bin/npm
    pnpm: 8.7.1 - ~/Library/pnpm/pnpm
  Browsers:
    Chrome: 123.0.6312.87
    Safari: 16.3
  npmPackages:
    vue: 3.4.21 => 3.4.21

Any additional comments?
A current workaround is to use a camelCase version of the prop name.

/cc @so1ve

Could you please transfer this issue to vuejs/language-tools?

@so1ve I don't have that permission. 😄

I'll just open a fresh ticket over there and close this one. Thanks for pointing me in the right direction! 🙂


Add gzip bomb to help protect against vulnerability scanners

https://blog.haschek.at/2017/how-to-defend-your-website-with-zip-bombs.html

I think I'm going to skip this, keep it in mind if it becomes a real problem.


fix: canvas mount & update bug

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Bump up version

Thank you for the great typst library!
I noticed that the commit to this repository contains several updates/fixes over the published as @preview/whalogen:0.1.0. (And I want to use the updated feature)
I updated this library as 0.2.0. I thought it was not 0.1.1 as it contains new features.
Could you merge this PR and tag it as 0.2.0?
After merge, I will PR to typst/packages.

Thanks for your contribution.

https://github.com/typst/packages/pull/598


Confirmed working on RAX70 with Firmware Version <IP_ADDRESS>

Thank you very much for your amazing work!
I managed to enable telnet on my RAX70 in order to change Region (it was locked to China and I live in Europe and I really needed that 4804MHz option).
I was trying on the oldest Firmware Version <IP_ADDRESS> with no luck, but trying with <IP_ADDRESS> it worked.
I got the following Syntax Errors with latest version of Python on Win11:
\telnet-enable.py:50: SyntaxWarning: invalid escape sequence '\s'
for v in (re.split('\s+', i) for i in arp_data_raw))
\telnet-enable.py:660: SyntaxWarning: invalid escape sequence '\s'
for line in re.findall('([-.0-9]+)\s+([-0-9a-f]{17})\s+(\w+)', data):
and then the message Done sending pw data XXXXXXXXXX to <IP_ADDRESS>:23
But finally everything worked as a charm and I connected to Telnet!
I have to notice here that I was trying using single quotes on 'password' and no quotes on password on my unsuccessful tries.
I was getting the same Syntax Errors and then the message:
Done sending pw data XXXXXXXXXX to <IP_ADDRESS>:23 but after rebooting I could not connect to telnet.
With fw <IP_ADDRESS> it was the first time I tried with double quotes on "password". I cannot tell if it was the quotes or the firmware version that allowed to enable telnet.
PS: running telnet-enable.py from Ubuntu 22.04 returned no Syntax Errors at all.

Thank you for sharing @Iliasbrv My issue was i got Done sending pw data xxxxxxxxxxxxxxxxxxxx, to <IP_ADDRESS>:23, but i was not able to telent to my router. This is was quite weird. Do you have any clue?

I was getting the same message with the Firmware Version <IP_ADDRESS> and the latest Netgear Firmware without being able to telnet the router. I tried Firmware Version <IP_ADDRESS> and run telnet after Done sending pw data without restarting my router.
Make sure telnet is enabled on Windows features.

Hello @zh-pan
Yes you can update your Router without any problem.
After updating to the latest FW you have 6 Region Options:
Australia & New Zeland
Europe
Hong Kong
India
Middle East (United Arab Emirates)
Singapore

@Iliasbrv Thanks again! I try it and success!

Of course. Thanks for the reminder!

Off course. Thanks for the reminder! 🙂


TODO Moving a player/object on screen

add

Can't this be considered done already?

I believe so, i think i've fixed the last bugs with player movement (apart from the new crippled player walking animation, maybe because their toe sticks out of the shoe?)