7571: do not activate terminal window upon settings modificaion

Summary of the Pull Request
Took this as an easy starter. The method IslandWindow::SetAlwaysOnTop is triggered once terminal settings are reloaded (in TerminalPage::_RefreshUIForSettingsReload flow). This method calls SetWindowPos without SWP_NOACTIVATE. As a result the window gets activated, the focus is set and the cursor starts blinking.
Added SWP_NOACTIVATE flag there and in few additional places in island windows. See a discussion below.

References

PR Checklist

[X] Closes https://github.com/microsoft/terminal/issues/7571
[X] CLA signed.
[ ] Tests added/passed
[ ] Documentation updated - irrelevant
[ ] Schema updated - irrelevant
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
Added SWP_NOACTIVATE  in all SetWindowPos calls  from IslandWindow and NoClientIslandWindow (where it was missing). Please let  me know if this is an overkill - it is not required to fix the issue, however seems a good practice, that might help if we decide to apply more settings immediately.

Validation Steps Performed

Only manual testing - please guide me to the relevant UT framework, if exists.
Trying to reproduce this with VS attached doesn't work - the window gets the focus in any case.
Tested as a standalone application, by modifying different settings (and comparing the results before and after the fix).
Checked with Spy++ that no WM_ACTIVATE / WM_SETFOCUS is thrown upon settings modification
Applied terminal resizing, toggling full screen and focus mode to check no regression was introduced.

Feel free to unmark this as a draft; it looks fairly complete to me! Are you participating in Hacktoberfest? I can mark these pull requests as eligible if so.

Feel free to unmark this as a draft; it looks fairly complete to me! Are you participating in Hacktoberfest? I can mark these pull requests as eligible if so.

Thanks! And thanks for reminding about Hacktoberfest - I signed up to it right now. Why not to plant a tree? 😄

Thanks again for the contribution!


Build fails on Ubuntu 18 - gcc8

I get the following error:
ERROR: conanfile.py (OrbitProfiler/None): Error in build() method, line 164
	cmake.build()
	ConanException: Error 2 while executing cmake --build '/home/pf/Downloads/repos/orbit/build_default_relwithdebinfo' '--' '-j12'

/home/pf/Downloads/repos/orbit/OrbitService/Utils.cpp:188:15: error: ‘transform_reduce’ is not a member of ‘std’
   return std::transform_reduce(begin(proc), end(proc), std::vector<pid_t>{},

I think CMakeLists.txt needs to explicitly set C++17 in CFLAGS somewhere

Don't understand, CMakeLists.txt sets c++17 as the minimum standard.

But OrbitService's CMakeLists.txt file doesn't

What was the last release that built on Ubuntu 18  with either gcc or clang?

Hey everybody,
I am facing the same issue while trying to build the code on Debian 10. If it could be useful, the issue persists using the default Conan profile both with compiler.libcxx=libstdc++ and compiler.libcxx=libstdc++11.

Hello everybody,
thanks for reporting this and sorry for the delay.
I hope this is fixed now.
Cheers,
Henning


fix: MD007/ul-indent

Unordered list indentation
Added code fence languages
Trim trailing/leading spaces

@BillWagner I've rebased this now that the other PRs landed

@BillWagner anything to change here?

@nschonni Thanks for the ping. I was OOF for a long weekend, and this dropped off my radar. Reviewing now.

@BillWagner not a problem


dnn + python

Are dnn functions exposed through python ?

No. And as Dlib does no provide dynamic network structure - it will not be possible to make python API for DNN
http://dlib.net/faq.html#Whycan'tIchangethenetworkarchitectureatruntime

Right.  I doubt I will add any sort of Python training API for the DNN
tooling since Python is incapable of representing the C++11 language
concepts used by the DNN API.
Although maybe I'll add a Python API for running specific trained models if
that eventually makes sense.  We will see.

yep that would be awesome to run the detection on a trained model via python

Any news?

No.  It's still impossible to expose C++ templates to python.

hi davisking. What value of padding has to be used for training the HELEN dataset for face landmark detection ?

Read Kazemi's paper.  It's all in there.


Construction Bugfixes

Added CanReach property to AfterAttack events which signals if the attack was within reach.
You cannot construct/deconstruct things out of reach.
Construction entities now preserve transform rotation.
No more exceptions about missing grids when constructing world entities.
Used the proper intermediate sprite for intermediate entities.
Issue with missing sprite layers on ghost.

Resolves https://github.com/space-wizards/space-station-14/issues/1308.
Resolves https://github.com/space-wizards/space-station-14/issues/1317.

No fix for https://github.com/space-wizards/space-station-14/issues/1296 ?

Yeh, this resolves https://github.com/space-wizards/space-station-14/issues/1296 also.


Android Pushes not appearing

Hi, pushes are not appearing when my app is in the background or not started.  They only appear if the app is already running in the foreground.

I think i used to see  this problem and it's solved. Find the file "GCMIntentservice.java" show me the code of this and including your client callback function please.


#49: Create the "cikit-webserver" role

#49

Merge was rescheduled to February 4, 2018 (https://github.com/BR0kEN-/cikit/pull/90/commits/5c7e605258b7cdc2f8eef711d1e032355b74e809) to give reviewers, @temoor-gilmutdinov and @lokeoke, more time for evaluation.


Liltoon only draws shadows for directional light, and does not draw shadows for other light sources.

spot light example
https://github.com/lilxyzw/lilToon/assets/10657819/b03df0e9-4eb4-42a6-bbb2-9aee1b560dd8
directional light example
on liltoon version 1.3.6, 1.4.1, 1.5.0
same bias, same shader settings.
what can i do?

This is according to specifications. If a shadow is drawn using anything other than the main light (directional light), the shadow will be dark and dirty.


Discord integration

Write a bot to integrate with Discord.  Start with notifications of updates.

Need to flush out where in the pipeline notifications should happen.


[5686] Fixed incorrectly awarded trainee

Context
Incorrectly awarded trainee
Changes proposed in this pull request
Fixed incorrectly awarded trainee
Guidance to review
:shipit:
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[x] Do we need to send any updates to DQT as part of the work in this PR?
[ ] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 URGENT: QTS recommendations error


Feature Request: Option to refresh website

Using this with ChatGPT the session sometimes gets stale in some way, shape or form, where the "gate" needs to be closed and opened again in order to restart the session.
I think it would be nice to see the added option of "Refresh tab" in the "More options" menu of a tab with a "gate" open in it.

Added in version 1.1.0. Just released

Now you can right click on the tab icon. You can see the refresh option.

I've been using the feature for a while now and it works perfectly! Thank you for the swift implementation!


[CINFRA-674][CINFRA-675]  Replicated operations refactoring

Summary
This pull request refactors DocumentLogEntries to use variants instead of enums and fixes several bugs that were discovered during the refactoring.

Refactored DocumentLogEntries to use variants instead of enums
Fixed several bugs that were discovered during the refactoring, including handling the IntermediateCommit operation
Introduced a new ReplicatedOperation structure to indicate the command that the replicated state machine has to execute
Fixed a potential problem caused by early compaction on the leader
Separated the decision to replicate a transaction from replicateOperations and moved that logic into a separate method: needsReplication
Added additional C++ tests as needed and refactored existing tests

Gory details

We are refactoring DocumentLogEntries to use variants instead of enum. Due to this refactoring alone, several bugs were found and fixed, as pointed out by the compiler (for example, we forgot to handle the IntermediateCommit operation in several places). The DocumentLogEntry structure remains as the main mechanism for transporting log entries into the stream, while the newly added ReplicatedOperation indicates the command that the replicated state machine has to execute. Currently, the log entry is only a wrapper on top of the operation, but I believe this separation could prove to be beneficial in the future. This change is responsible for most lines modified in this PR, and brought with itself a necessary refactoring in the unit tests (both C++ and JS). Additional C++ tests were added as needed. This point address CINFRA-674.
A potential problem caused by early compaction was fixed on the leader. When dealing with Commit and CreateShard operations, the leader has to replicate them first, wait for the entries to be committed (in the log sense), commit the operation in RocksDB (or create the shard) and only then call release on the stream. This is now achieved by introducing a release method on the leader. There are currently two versions, one for handling user transactions that carry an official TransactionID and cannot simply be split in half by compaction, and one taking just a log index, which is enough for identifying an internal transaction (such as DropShard). This could be improved in the future, such that we no longer have to handle two different cases, perhaps we could generate transaction IDs for internal operations as well. The first plan was to use a ScopeGuard here, but I found that a bit tricky due to potential exceptions being thrown in doCommit(). Nevertheless, the focus here was to get a working version, while making sure the current refactoring allows for such improvements in the future. See CINFRA-675 for reference.
We separated the decision to replicate a transaction from replicateOperations and moved that logic into a separate method: needsReplication. This makes it more visible where are the places in which we decide what to replicate or not. However, as single commit/abort operations can still be encountered on the follower, we've made sure these are safely ignored. See the comments on CINFRA-695.
Some additional bug-fixes and minor TODO's were covered in the rest of this PR.

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[x] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[x] C++ Unit tests
[x] integration tests
[ ] resilience tests

[ ] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[ ] Backport for 3.10: (Please link PR)
[ ] Backport for 3.9: (Please link PR)
[ ] Backport for 3.8: (Please link PR)

I created CINFRA-702 for ideas of future improvements.


HBASE-24143 [JDK11] Switch default garbage collector from CMS

Per comments in Jira, be explicit about what collector we
use. Existing code simply hard-codes HBASE_OPTS in
conf/hbase-env.sh. We now need to be a little more clever than this,
so moves the definition into bin/hbase. Also consolidates logic
around JVM version detection into a reusable function.
This change also changes how we set HBASE_OPTS. Before, we would
accept an operator's value, but always append our GC
prescription. After this change, we defer entirely to the operator's
choice, only applying our values when they've not specified their
intentions.

Posted patch is explicit, per @markrmiller 's comment on Jira. I only set to G1GC for JDK11+, even though it's deprecated from 9+. Not sure if that's the right approach or not. I'm not sweating it because we probably don't even run on 9 or 10 due to some portion of the class path fixes that are applied only from 11 onward.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

_ Patch Compile Tests _

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

2m  1s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1527/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1527

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 0f2676aaf6ef 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 853a72bc46

Max. process+thread count
44 (vs. ulimit of 12500)

modules
C: . U: .

 U: .

 U: .

 U: .

 U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1527/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

_ Patch Compile Tests _

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

1m 49s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1527/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1527

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 2960bace20c1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5ff4376d80

Max. process+thread count
43 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1527/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Upgrade to new version possible without dataloss?

Hi, I am running the previous version on a linux system. Unfortunately docker is still some kind of a black box to me.
Can I somehow upgrade to the new version (for resolve 18) without dataloss? Or will I have to import the old database somehow?
Some how-to-upgrade-instructions would be appreciated.
Thank you for this superb tool.

In the next release I added a container for PGAdmin, which lets you backup the entire server, as well as transfer individual databases. This should make this process significantly easier


Inactivity penalty for participating validators might be too high

Issue
During an inactivity leak it is expected that those validators that are participating optimally would see their balance unchanged whereas, those that are participating but not optimally will lose a small amount, and those that are failing to vote on the "correct" target are subject to a quadratic leak.
It turns out that due to some of the details of the calculations performed in get_attestation_deltas that an optimally participating validator would still lose some amount of capital. This is due to two minor details in the way rewards are applied

Micro-incentives for FFG source, target, and head are scaled by attesting_balance // total_balance
max_attester_reward for inclusion delay is less than base_reward due to the portion given to the proposer

These two sources of reward are less than base_reward even for an optimally participating validator during an inactivity leak. (1) is certainly scaled below the maximum for target and head because the chain is not finalizing and thus the attesting_balance < 2/3 * total_balance. (2) is always scaled slightly below the maximum regardless of the inclusion time due to a portion going to the proposer.
During an inactivity leak, all active validators receive a BASE_REWARDS_PER_EPOCH * base_reward penalty with the expectation that an optimally performing validator's rewards will be perfectly balanced out by this penalty resulting in a net 0 affect on balance. As discussed above, the max reward for an optimally performing validator is less than BASE_REWARDS_PER_EPOCH * base_reward, thus they will lose capital.
Proposed solution
We could be more nuanced about the penalty applied here to ensure a penalty balancing scaled by the proper amounts, but that seems a bit messy.
Still thinking on it.

There's reasons for other broader changes to how incentives work; namely, having a global per-epoch penalty that rewards cancel out instead of having separate inactivity penalties (it simplifies the logic, and also it moves us closer to https://github.com/ethereum/eth2.0-specs/issues/1340).
If we do that, that would be a good opportunity to also adjust to make sure we fix this.

@vbuterin Any thoughts on this and the related issue?

Can we bump this? It seems there has been a lot of confusion after the topaz network had an outage.

I'm also interested in this. We often see user confusion around losses during any gap of finality larger than 5 epochs. It doesn't make sense to users that they were online, performed 100% of their duties in a timely manner, and still realized a negative change in their validator balance.

addressed in #1830!
Thanks for the nudge on this one. Will make for a cleaner validation experience


qBittorrent Injection doesn't handle download/save path correctly

When adding torrents to qBittorrent, if the default download directory (different than the save directory for completed torrents) is set, the recheck fails, as qBittorrent checks the download directory on force recheck. This causes torrents to be detected at 0% (despite working hardlinks in the OPS/RED output directories) and will begin downloading them.
I am not savvy enough to suggest a solution, but my workaround was to set the global download directory to the OPS output directory (as all the torrents I'm trying to seed come from RED). An ideal solution would be to address the handling of download vs. save directories in qBittorrent and/or not start the torrents if the check results in a 0% result (kind of like how cross-seed handles partial matches).
P.S. also maybe add documentation to add the user: 1000:1000 to the docker compose, as this runs as root when using docker, which resulted in permissions errors for my torrent client.

That's very strange - I wouldn't have expected the recheck to check the download directory preferentially over the final destination directory.
I don't actually use qbit so I might need the help of someone with more experience here. In the meantime, is it possible to set label-specific rules so that torrents with a fertilizer label/tag have a different save path? This way you don't need to change the global directory

When adding torrents to qBittorrent, if the default download directory (different than the save directory for completed torrents) is set, the recheck fails, as qBittorrent checks the download directory on force recheck. This causes torrents to be detected at 0% (despite working hardlinks in the OPS/RED output directories) and will begin downloading them.
I am not savvy enough to suggest a solution, but my workaround was to set the global download directory to the OPS output directory (as all the torrents I'm trying to seed come from RED). An ideal solution would be to address the handling of download vs. save directories in qBittorrent and/or not start the torrents if the check results in a 0% result (kind of like how cross-seed handles partial matches).
P.S. also maybe add documentation to add the user: 1000:1000 to the docker compose, as this runs as root when using docker, which resulted in permissions errors for my torrent client.

Do you mean you are using the qBit feature to store incomplete downloads in a specific place? I have that enabled too but it works for me... it sets the right location based on the hardlink... however the torrent is added at 0% and I have to manually force recheck and then start it. I have Do not start the download automatically enabled, as well as Torrent stop condition set to Files checked. I'm on qBit 5.0.2 with Libtorrent <IP_ADDRESS>, on Ubuntu without Docker.

That's very strange - I wouldn't have expected the recheck to check the download directory preferentially over the final destination directory.

Every time I add a torrent (for upload or reseed), I have to have the save directory AND the download directory set to the same path (where the files are located), otherwise it reads 0% on force re-check.

In the meantime, is it possible to set label-specific rules so that torrents with a fertilizer label/tag have a different save path? This way you don't need to change the global directory

You can set default save paths for each category, but qBittorrent only respects that with automatic torrent management enabled (which automatically sorts torrents into paths based on category) or with the option Use Category paths in Manual Mode enabled.

Do you mean you are using the qBit feature to store incomplete downloads in a separate DIR?

Yes, I use category paths in manual mode for my save directories (i.e., /torrents/sonarr, /torrents/sonarr4k, /torrents/lidarr, etc.) so when one of the *arrs adds a torrent, it gets sorted by which app added it to the queue.

however the torrent is added at 0% and I have to manually force recheck and then start it. I have Do not start the download automatically enabled, as well as Torrent stop condition set to Files checked.

I do have Do not start the download automatically disabled, as I don't want to have to manually start every torrent sent to qBit by the *arrs. Additionally, Torrent stop condition is set to None.
My workaround has evolved to completely disabling the download path (was previously /torrents/temp) so qBittorrent places incomplete torrents in the save path. With this configuration, when fertilizer adds a torrent, it still correctly creates hardlinks, and when it adds the torrent, qBit force re-checks and it comes back as 100% and begins seeding automatically.

Pathing in qBittorrent, particularly with AutoTMM, was difficult for us when we started to expand linkings functionality in cross-seed v6.
I'm happy to help with some of the more specific "gotchas" if need be, but it's going to require a bit more logic surrounding injection specific to what would be expected and the behavior you want fert to take @moleculekayak
You can hit me up on github (anyone looking to help) directory of in our (cross-seed) discord. Just let me know.


Auth::verifyIdToken() verifies valid tokens as revoked ( v4.32 )

The Auth::verifyIdToken() method throws an Kreait\Firebase\Exception\Auth\RevokedIdToken exception with valid idTokens generated using SOCIAL NETWORK providers on the client side and the second param (checkIfRevoked) set to true (works fine with idTokens generated from custom tokens).
To Reproduce
Generate an idToken with javascript, react or native SDKs and pass it to Auth::verifyIdToken( $token, true ). I've also verified the idTokens with verifyIdToken() method from the "firebase-admin" node.js package and it works ok.
I've checked the idToken
Expected behavior
No exception should be thrown with the checkIfExpired param set to true and using valid idTokens.
Environment (please complete the following information):

OS: Ubuntu 18.04
PHP version: 7.2
Firebase SDK Version: 4.32

The information that you didn‘t get an invalid token exception, but „just“ a revoked token exception let’s me think of time inconsistencies on the server (I had issues about that in the past). There‘s a third „allow time inconsistencies“ parameter to the verifyIdToken method, could you please try verifying the ID token with that enabled?
ID tokens from social auth providers are currently not directly supported by the PHP SDK - if the verification works without revocation checks, could you please share the decoded token with me so that I can help investigate what the issue might be?

I made a ver_dump() of the idToken and firebase user object and it exp, auth_time and tokensValidAfterTime attributes are correct. Also created a node.js script and used the verifyIdToken from the official Google's node.js SDK and the same token was verified successfuly :(

I believe you, but this SDK is not as feature-rich as the official SDKs and might not work the same way as the official SDKs - in my understanding, even after a social network login, the Firebase ID token should still be just that - an ID token issued by Firebase.
The throw of a RevokedIdToken exception happens after the validation of the Token itself, that's why I assume that the token itself is valid.
If you call $check = $auth->verifyIdToken($idToken) additional parameters, you should have the token in the $check variable and can debug the token claims by reproducing the behavior from
https://github.com/kreait/firebase-php/blob/6bf91b0622a381ca384cddb67c4a3773f7508782/src/Firebase/Auth.php#L398-L407
For example:
$check = $auth->verifyIdToken($idToken);

$tokenAuthTime = $check->getClaim('auth_time');
$uid = $check->getClaim('sub');
$user = $auth->getUser($uid);
$validSince = $user->tokensValidAfterTime;

And then compare the values... it has to do something with time, this is the only place where this specific exception is thrown.
I hope this helps!

Thanks! It's exactly what I've done :)
Also would be great if it can be fixed. Not supporting Social Network Provider's tokens because a line of code it's a shame :)

If that is what you‘ve done, could you share what the actual issue is? Do the timestamps not match or do they? If you dived into the code, do you see an issue somewhere?


Make test_server yaml use develop branch on non master.

Fix bug in ci.yaml, where it always used develop
Update test that broke from temporal validation change

This should fix the test_server.yaml build always failing.


Generated unmarshalling code for [reductiontarget] inappropriately offsets into message buffer for entry methods taking a single array argument: entry [reductiontarget] void foo(double[4] a)

Original issue: https://charm.cs.illinois.edu/redmine/issues/1061

Originally reported to me by Robert Pavel via email.
In the case where the entry method argument was a single array, expecting to just be passed the pointer to the CkReductionMsg data() buffer, this pointer was instead being offset by 16 bytes, based on how things would work in the normal case where an array is passed to a marshalled entry method.

Original date: 2016-05-10 21:17:29

~~https://charm.cs.illinois.edu/gerrit/1188~~ https://github.com/UIUC-PPL/charm/commit/5c00bf0f5a0480c9c354326cf1500dbd4474c353


Unable to load AWS credentials from any provider in the chain

Hi,
This may well be a spark issue which doesn't concern flintrock, but it is something that becomes a bit more tricky in flintrock.
I'm trying to use the ID and secret key of an IAM user to authentic pulling data into a cluster from s3. I've confirmed that my ID and secret work when used like sqlCtx.read.csv('s3a://<ID>:<SECRET>@bucket/file.txt).
But I get the Unable to load AWS credentials from any provider in the chain if trying to load the ID and secret dynamically. Ways I've tried getting them to load, all resulting in same mentioned error;
• adding ~/.aws/credentials (and confirming it's found by aws cli using aws configure) to master and slaves
• running !export AWS_ACCESS_KEY_ID=..., and for secret, in Jupyter notebook that is connected to the spark cluster
Suggestions on how you solved this appreciated.
Note: I want to rely solely on the ID and secret key as working in a team and want to easily share bucket access.
Thanks

Spark doesn't look at ~/.aws/credentials and probably not the AWS_* environment variables either.
What you need is to use the fs.s3* properties described here, and if you're using Hadoop 2.7+ you should specifically use s3a as opposed to s3n or just s3.

In the end I guessed it must not be - though this in combination with
com.amazonaws.AmazonClientException: Unable to load AWS credentials from any provider in the chain
at com.amazonaws.auth.AWSCredentialsProviderChain.getCredentials(AWSCredentialsProviderChain.java:131)

seemed to imply that it should be looking in there which keep me trying for longer -  maybe it's not because it's not DefaultAWSCredentialsProviderChain? Anyway!
Do you have a suggestion how to either automatically inject those xml config files, or to "bake" them into the ami without clashing with flintrock's setup process?
I'm finding using flintrock great because it's so speedy, and I'm avoiding (almost) all extra cluster setup steps to keep it speedy by having everything else already setup on a custom ami.

The easiest thing to do is use flintrock run-command to inject the configs into the appropriate files, though the commands will be clunky (you'll probably need to use sed or something similar).
My recommended solution is to not use credentials at all and instead use IAM roles.
A potential future solution is coming in #202, where you'll be able to bring your own templates and have Flintrock use them during launch.

Ok, that's helpful thanks, and #202 looks great, hoping it gets merged!


Jwt rsa token validation fails if the same parameters are used in 2 separate tests

Relating to this issue:
https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/1433
Both tests would pass when run by themselves but one would fail when both were run at the same time.
However the validation would actually work if you tried it again after that.
They would also work if different parameters were used.
Both  tests used the same csp blob (even if it was stored in different places).
A fix is being implemented but this is to keep a record of the problem for future reference.

This has been fixed now and is in v.0.7.0.


Three undocumented props for recipe prototypes

overload_multiplier = <Integer> -- sets the input buffer multiplier; optional, default: 1
requester_paste_multiplier = <Integer> -- when assembly machine using the recipe is copied and then pasted on to a requester, the values can be multiplied up by this value; optional, default set in game options
main_product = <String> -- no idea what this does, only seen on chemical processing recipes; optional, defaults to ""

There's also icons, which allows the display icon to be composed (used very heavily in omnibarrels) and localised_name, which appears to be a more programmatic way of localizing things.

FWIW, if you run python factorio_schema.py, you get a list of everything missing, except for things that filter into some complex types (I ran into this with probabilistic recipe generation).

Regarding icons, it seems any recipe that has a single result (or a results with only one element? not tested that yet) will default to the icon of the item/fluid that the recipe produces.
Anywhere that an icon filed is present (single static icon), an icons field can be used as alternative (for layering icons, not sure what max number of layers is though), and vice versa. Not sure which one takes precedence if both icon and icons are specified, I would imagine the latter but not tested yet.
Just as the layered icons support tinting (like in omnibarrels), I suspect there might be an undocumented tint property at the same level as anywhere that accepts an icon property, to tint that icon (not tested yet).
My testing of localised_name indicates it works on just about any prototype, and it offers features similar to GUI elements in that it supports parameters, nested locale tables, etc.
As for running python, I have no clue where to start in that respect.


📝

More descriptions will be added. I'll ping you when this is ready to review.

@cweijan, the last commit is removing unnecessary indentation level. Without the whitespace changes the diff is less frightening https://github.com/cweijan/vscode-autohotkey/pull/12/files?diff=unified&w=1

That's great.


It is unclear which reverb gain to use

Hi,
This comes with my usual proviso that it could just be me being stupid, but I am unclear whether to set the gain of a given reverb, or whether to set the gain in the call to syz_configRoute or whatever it's called.
Am I missing something? Or are they interchangeable?
Thanks in advance.

syz_routingConfigRoute configures the gain of the route, e.g. you can have multiple sources pointing at the same reverb with different gains, to do things like feed half the source to each reverb.  that's documented here:
Gains are per route and apply after the gain of the source. For example, you might feed 70% of a source's output to something (gain = 0.7).
Filters are also per route and apply after any filters on sources. For example, this can be used to change the filter on a per-reverb basis for a reverb zone algorithm that feeds sources to more than one reverb at a time.

OK thank you. Makes sense.
Take care,
Chris Norman
On Sat, 24 Jul 2021 at 20:50, Austin Hicks @.***> wrote:

syz_routingConfigRoute configures the gain of the route, e.g. you can have
multiple sources pointing at the same reverb with different gains, to do
things like feed half the source to each reverb. that's documented here
https://synthizer.github.io/concepts/effects.html:
Gains are per route and apply after the gain of the source. For example,
you might feed 70% of a source's output to something (gain = 0.7).
Filters are also per route and apply after any filters on sources. For
example, this can be used to change the filter on a per-reverb basis for a
reverb zone algorithm that feeds sources to more than one reverb at a time.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/synthizer/synthizer/issues/65#issuecomment-886103635,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBUZ2LIJKBOKF244NFMZATTZMKRFANCNFSM5A5UZMOQ
.


Support landscape mode

Currently the landscape mode is disabled due to some layout bugs. Refers to #8

Appreciated on desktop environments (Samsung DeX) / tablets with keyboard / other use cases with landscape mode.

The landescape mode will be available in the next update


Seed onboard (BOOT) button support and example.

Works great for me! All this needs, like #2, is some formatting.


i need a tool, you have finish it, i have see it  but now i can not find it

the tool is like :  it can transform the html from any web or url to FT Components or python code !
i really see the tool in https://docs.fastht.ml/   but now i can not find it

if there is the tool,please tell me ,if there is not the tool ,   Do you think it's necessary to implement this tool, if it's there, it's possible to quickly convert see html to python fasthtml for publishing

I am chinese, some parts of the language are not well organised, I hope you can help me.

I found this function,

but it's missing the most important function, which is layout, as follows.

I think this is what you are looking for: https://h2f.answer.ai/

yes  it is ok !  thank you!
但是你能优化一下这个web工具吗 ,  就是完整复现任意网页的布局,尤其是一些经过css和js控制后布局,通过您这个工具生成的python代码也自动实现布局!

yes it is ok ! But can you optimise this web tool to reproduce the layout of any web page, especially the layout of some pages controlled by css and js, and automatically implemented in the python code generated by your tool!

the second optimisation point is a redundant div span, the current look down the effect of the conversion of the ft will be very redundant do not know what you have good ideas! this may be a little difficult, your web tool may not be able to determine that is important that is not important, but this is good topic,What do you think?

I think since it (https://h2f.answer.ai/) is decoupled into a tool, it should be iterative, and I hope you can push the optimisation of this tool to keep adding new features and buttons to it, and I think the foreseeable future is that this page accepts a url at the same time, so that the backend can actually visit the page to get the real attempts to reproduce the page one for one.The ft component, and in the process reducing redundant div ,br,hr,p,spans for eventual integration into fasthtml apps.

Great ideas! Consider submitting PRs implementing them to https://github.com/AnswerDotAI/fasthtml-example/tree/main/h2f!


Create sbt task for scapegoat

Currently configuring an sbt project to use scapegoat has the effect that scapegoat will run during the compile phase, as configured, every time.
Please create an sbt task that will allow scapegoat to run on demand, and decouple from running during the default compilation phase, as is the case with scalastyle. This will allow users to optionally run scapegoat periodically, and otherwise run the build without penalizing compile times.

This is particularly important since SBT's incremental compile means Scapegoat only runs on modified files, overwriting reports, unless you clean first.

It's in the works for May :)
On 4 May 2015 at 19:58, Kyle Unverferth<EMAIL_ADDRESS>wrote:

This is particularly important since SBT's incremental compile means
Scapegoat only runs on modified files, overwriting reports, unless you
clean first.
—
Reply to this email directly or view it on GitHub
https://github.com/sksamuel/sbt-scapegoat/issues/19#issuecomment-98813249
.

Any updates on this? If you haven't already got it started, I may be willing to take a swing at it.

Please do :)
On 19 May 2015 21:51, "Greg Symons"<EMAIL_ADDRESS>wrote:

Any updates on this? If you haven't already got it started, I may be
willing to take a swing at it.
—
Reply to this email directly or view it on GitHub
https://github.com/sksamuel/sbt-scapegoat/issues/19#issuecomment-103664479
.


Write script to convert full dataset to letter classification dataset and add unit test

Put the script in the training submodule, which you don't need to PR for. In this repo, use your script to generate a small test dataset for letter classification and write a unit test that measures the letter classifier's accuracy, then open a PR for that.

@scliou any progress or blockers for this?

The unit test uses the dataset in the "letter dataset" folder and compares the prediction results from the each image to the label in the corresponding .txt file.  The script in the submodule crops out the shape detected by the shape detector that is close to one the ground truth bounding boxes and gets the letter label for the box from the label of the tile.  for now, i'm cropping out the center 50% of the image to try to remove the shape boundaries from the letter dataset.  is there anywhere I should push the script? lmk if there are any modifications I can make!


font icons not working any more

one of the latest compiler updates broke the font icon support. It seems as if the glyphs for the font are not generated anymore. I do not find any resources for the font except the font files itself.

just found this as well :( going to downgrade the compiler for now ...

I did some further testing. The last working version for me is 1.0.0-beta.20200415-0654.
1.0.0-beta.20200420-2025 and 1.0.0-beta.20200421-0852 do not compile at all in my ptroject so I can't test them and in 1.0.0-beta.20200422-1126 the font icons are broken.

i think i've just fixed it in https://github.com/qooxdoo/qooxdoo-compiler/pull/678


Use certificats for API connexion

Hi, I have a restriction on application connections. I would have to connect to the application via a certificate, not a secret. Would it be possible to add a feature for this case?

Hello,
The MISP2Sentinel integration relies on the setup recommended by Microsoft to get access to the Upload Indicators API, which is via a secret, please see https://learn.microsoft.com/en-us/azure/sentinel/connect-threat-intelligence-upload-api#generate-and-record-client-secret
Access via a certificate is not immediately foreseen in the near future (except fe. if the documentation from Microsoft on the Upload Indicators API would also include it).


Rollback at a specific height causes the node to fail to start

Bug Report
Setup
CometBFT version (use cometbft version or git rev-parse --verify HEAD if installed from source):
635d0b596c7300c98caa57e7aab26a7a4579ab97
Have you tried the latest version: yes
ABCI app (name for built-in, URL for self-written if it's publicly available):
https://github.com/bnb-chain/greenfield
node command runtime flags:

./gnfd rollback --home ./ --hard

What happened?
Rollback at a specific height causes the node to fail to start. This is caused by the error code:
https://github.com/cometbft/cometbft/blob/635d0b596c7300c98caa57e7aab26a7a4579ab97/internal/state/rollback.go#L71
According to the definition of the State struct as below
https://github.com/cometbft/cometbft/blob/635d0b596c7300c98caa57e7aab26a7a4579ab97/internal/state/state.go#L63
LastHeightValidatorsChanged satisfy the following condition under any circumstances
1 <= state.LastHeightValidatorsChanged <= state.LastBlockHeight + 1 + 1
this condition can also be confirmed by looking at the code in func (store dbStore) save(state State, key []byte) error
https://github.com/cometbft/cometbft/blob/635d0b596c7300c98caa57e7aab26a7a4579ab97/internal/state/store.go#L229
state.LastHeightValidatorsChanged is with nextHeight + 1(state.LastBlockHeight + 1 + 1) corresponds.
When we rollback from block height state.LastHeightValidatorsChanged - 1 to height state.LastHeightValidatorsChanged - 2, newState.LastHeightValidatorsChanged would be wrong to modified into the state.LastHeightValidatorsChanged - 1
What did you expect to happen?
Node start properly while rollbacked from state.LastHeightValidatorsChanged-1 height to state.LastHeightValidatorsChanged-2 height
How to reproduce it
Let me give an example to describe the issue:
example

... => [block 242 (5validators)]  ==state1(5validators)==> [block 243 (5validators)]  ==state2(4validators)==> [block 244 (4validators)]   => ...

Assume that the current height of the block is 243, current state is state2 and state2.LastHeightValidatorsChanged == 244, validatorSet changed to 4 validators in the block 244 and state2

Rollback to block 242 and state1, the target rollbackHeight == 242

Since the error code, https://github.com/cometbft/cometbft/blob/635d0b596c7300c98caa57e7aab26a7a4579ab97/internal/state/rollback.go#L71
state1.LastHeightValidatorsChanged was changed to 243 incorrectly and it should be 244

After rollbacked to block 242, node could not start properly

Anything else we need to know
I've already made a pr fix for this issue:
https://github.com/cometbft/cometbft/pull/2136

This might also close this https://github.com/cometbft/cometbft/issues/1074


ex 3.34

Why p1 = &arr[0]; and p2 = &arr[0].?
These pointers can point to different elements of the array (for example p1 = &arr[1];, p2 = &arr[3];).

Why p1 = &arr[0]; and p2 = &arr[0].?

Because they point to the same array, rather than the elements of same array. But the statements make no sense. Sorry for the misleading.


After adjusting the tree view, the mouse does not drop the resize bar.

In safe mode I cannot see Tree-View (try cmd + / doesnt work)
Yes
Yes
I click on the partition between the tree-view and other content.
I try to drag (reduced tree-view)
After dragging, release the mouse button.
atom considers that the mouse pressed.
Solution - Only restart
Expected behavior: If I release mouse button drug event stop
Actual behavior: If I release mouse button drug event doesnt work
Versions:
Atom    : 1.12.9
Electron: 1.3.13
Chrome  : 52.0.2743.82
Node    : 6.5.0
apm  1.12.9
npm  3.10.5
node 4.4.5
python 2.7.12
git 2.10.0
MacOS Sierra 10.12.1

Same behaviour with console

Hi @Xurma2, Do you see this behavior when running chrome when trying to resize?  I am unable to repro on my machine.

Hi
No. Chrome does not have a relation to the problem with the atom (I think)

In safe mode I cannot see Tree-View (try cmd + / doesnt work)

This implies that one of your installed community packages is overriding the tree view.  Make sure the Tree View (in Settings -> Packages) is enabled.

@50Wliu
You're right!
I activated it
But still hotkeys does not work, and it does not appear in the safe-mode


Question.

Hi! How can I pass a custom prefix for headers to opir? Currently it reads from /usr/include which is not where libclang stores it's headers on artix linux so I'm unable to build binaries.


ko-327 Refactor test functions

From my perspective, this looks awesome. Nice job @johntrimble. I'm leaving a more in-depth review for the devs on the team.


Various Fixes for Getting the Double Agent tests running

This PR adds a number of changes for fixing double agent tests:

Large request bodies timing out
Performance of page recorder too slow to load page
Misidentifying XHR requests
Not tracking websocket messages correctly for unknown plugins
Emulators need to be able to set a specific user agent for Double Agent tests
Update docker deployment option

NOTE: the commits are a bit off in this PR because this branch got into a merge loop because of tags for alpha 1 and alpha 2 that I couldn't untangle.


execArgv not being interpreted correctly

It appears as though when tap passes process.execArgv params into nyc, they aren't being used correctly when spawning.
For example, with a fresh clone of https://github.com/isaacs/node-glob, I ran:
$ node --expose-gc node_modules/.bin/tap test/*.js --cov

On node 6.3.1, this produces the following error:
Error: spawn --expose-gc ENOENT
    at exports._errnoException (util.js:1012:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:182:32)
    at onErrorNT (internal/child_process.js:348:16)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)
    at Module.runMain (module.js:577:11)
    at run (bootstrap_node.js:352:7)
    at startup (bootstrap_node.js:144:9)
    at bootstrap_node.js:467:3

Tap sends process.execArgv to nyc via command-line args here.

@bengl what version of nyc are you bumping into this issue on?

@bcoe<EMAIL_ADDRESS>and<EMAIL_ADDRESS>


Seeing "unexpected end of file" issues for non-CDN channel

What happened?
Since a while a pixi user sees issues with "unexpected end of file" when downloading packages from robostack-staging which is a "non-CDN" channel.
2023-11-05T20:13:05.6283585Z   × error sending request for url (https://conda.anaconda.org/robostack-
2023-11-05T20:13:05.6285841Z   │ staging/linux-64/ros-humble-sros2-0.10.4-py310h7c61026_3.tar.bz2):
2023-11-05T20:13:05.6286861Z   │ connection error: unexpected end of file
2023-11-05T20:13:05.6287487Z   ├─▶ connection error: unexpected end of file
2023-11-05T20:13:05.6288023Z   ╰─▶ unexpected end of file

2023-11-05T20:13:05.5862693Z DEBUG validating{path=/home/runner/.cache/rattler/cache/pkgs/ros-humble-sros2-0.10.4-py310h7c61026_3}: rattler::package_cache: downloading https://conda.anaconda.org/robostack-staging/linux-64/ros-humble-sros2-0.10.4-py310h7c61026_3.tar.bz2 to /home/runner/.cache/rattler/cache/pkgs/ros-humble-sros2-0.10.4-py310h7c61026_3
2023-11-05T20:13:05.5872394Z DEBUG validating{path=/home/runner/.cache/rattler/cache/pkgs/ros-humble-sros2-0.10.4-py310h7c61026_3}: rattler_networking::authentication_storage::storage: Unable to retrieve credentials for conda.anaconda.org: Platform secure storage failure: no secret service provider or dbus session found, using fallback credential storage at /home/runner/.rattler/rattler_auth_store.json
2023-11-05T20:13:05.5880002Z  WARN validating{path=/home/runner/.cache/rattler/cache/pkgs/ros-humble-sros2-0.10.4-py310h7c61026_3}: rattler_networking::authentication_storage::fallback_storage: Can't find path for fallback storage on /home/runner/.rattler/rattler_auth_store.json
2023-11-05T20:13:05.5888109Z DEBUG validating{path=/home/runner/.cache/rattler/cache/pkgs/ros-humble-sros2-0.10.4-py310h7c61026_3}: rattler_networking::authentication_storage::storage: Unable to retrieve credentials for *.conda.anaconda.org: Platform secure storage failure: no secret service provider or dbus session found, using fallback credential storage at /home/runner/.rattler/rattler_auth_store.json
2023-11-05T20:13:05.5896238Z  WARN validating{path=/home/runner/.cache/rattler/cache/pkgs/ros-humble-sros2-0.10.4-py310h7c61026_3}: rattler_networking::authentication_storage::fallback_storage: Can't find path for fallback storage on /home/runner/.rattler/rattler_auth_store.json
2023-11-05T20:13:05.5901082Z DEBUG validating{path=/home/runner/.cache/rattler/cache/pkgs/ros-humble-sros2-0.10.4-py310h7c61026_3}: hyper::client::pool: reuse idle connection for ("https", conda.anaconda.org)

I wonder if this could be related to the anaconda.org infrastrucutre changes? Or rate limiting (this is a custom github runner, so has different IP from Github)?
Any hints appreciated!

Just noting that I've seen this and pinged Anaconda infra folks about it.

Thanks @jezdez – I think on our end we might try to up the retries.
Another thing to note is that the user mentioned this started to happen only in the last ~3 weeks or so, that's why I thought that it might be related to the infra changes on Anaconda's side.

Thanks @jezdez – I think on our end we might try to up the retries. Another thing to note is that the user mentioned this started to happen only in the last ~3 weeks or so, that's why I thought that it might be related to the infra changes on Anaconda's side.

Happy to Wolf! I don't have knowledge about any larger changes, but anecdotally we've seen the conda tests fail with retry issues as well recently, and I wonder if that is related.

Hi Wolf, thank you very much for reporting this. Currently we're adding a ticket to track this issue. We have not yet implemented the upgrade -- we've been running it through some final testing. Once we implement our upcoming infrastructure upgrade, and if this is issue is still extant, we'll look into prioritizing it.

The package downloads correctly for me, so maybe this was an intermittent issue.  We were having some upstream issues with Cloudflare around the time of the problems, so we can't rule that out.
(base) canderson@carls-mbp-2 missing_sha256 % wget https://conda.anaconda.org/robostack-staging/linux-64/ros-humble-sros2-0.10.4-py310h7c61026_3.tar.bz2
--2023-11-07 11:23:12--  https://conda.anaconda.org/robostack-staging/linux-64/ros-humble-sros2-0.10.4-py310h7c61026_3.tar.bz2
Resolving conda.anaconda.org (conda.anaconda.org)... <IP_ADDRESS>, <IP_ADDRESS>
Connecting to conda.anaconda.org (conda.anaconda.org)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-tar]
Saving to: ‘ros-humble-sros2-0.10.4-py310h7c61026_3.tar.bz2’

ros-humble-sros2-0.10.4-py310h7c61026_3.tar.     [ <=>                                                                                ]  58.69K  --.-KB/s    in 0.06s

2023-11-07 11:23:13 (991 KB/s) - ‘ros-humble-sros2-0.10.4-py310h7c61026_3.tar.bz2’ saved [60096]

(base) canderson@carls-mbp-2 missing_sha256 % file ros-humble-sros2-0.10.4-py310h7c61026_3.tar.bz2
ros-humble-sros2-0.10.4-py310h7c61026_3.tar.bz2: bzip2 compressed data, block size = 900k
(base) canderson@carls-mbp-2 missing_sha256 % tar -xjf ros-humble-sros2-0.10.4-py310h7c61026_3.tar.bz2
(base) canderson@carls-mbp-2 missing_sha256 % ll
total 29720
drwxr-xr-x  9 canderson  staff       288 Nov  7 11:24 info
drwxr-xr-x  3 canderson  staff        96 Nov  7 11:24 lib
-rw-r--r--  1 canderson  staff     60096 Feb  6  2023 ros-humble-sros2-0.10.4-py310h7c61026_3.tar.bz2
drwxr-xr-x  4 canderson  staff       128 Nov  7 11:24 share

@barabo I'm interpreting this as a "worksforme" and will close it. @wolfv please let us know if this is still happening.

Yeah, I think it was always "working" and it's a random package that fails. But if you didn't make the infrastructure changes yet, idk why it changed. Again, we should probably increase retry limits and backoff time.


Add dashboard url to service provisioning request

Signed-off-by: Hristo Dobtchev<EMAIL_ADDRESS>

Coverage increased (+0.3%) to 90.071% when pulling bcc9711367f6e9d155b879f32e42d7f6b7f32d51 on SAP:dashboard-uri into b52f1f134dfca20e81e74e03457a6e247cc193e4 on cloudfoundry-incubator:master.

Coverage increased (+0.3%) to 90.071% when pulling 3eaecb28fb861be36532e8ed2738d5e7859bbecf on SAP:dashboard-uri into b52f1f134dfca20e81e74e03457a6e247cc193e4 on cloudfoundry-incubator:master.

Coverage increased (+0.3%) to 90.071% when pulling 4d0fd538f880d15cfbf6249dbbd95cdac609e208 on SAP:dashboard-uri into b52f1f134dfca20e81e74e03457a6e247cc193e4 on cloudfoundry-incubator:master.


Indexing takes over 100x longer on big file

When indexing a big file that contains around 16000 generated classes, the indexing process takes around 100 more time.
Jandex 3.1.0  ~ 5 seconds
Jandex 3.1.1  ~ 490 seconds

OK, that is weird. The only change in 3.1.1 that could realistically cause this is #308. Could it be that you have a lot of recursive type parameters (T extends Something<T>) that have the same name? That would lead to a lot of hash table collisions, which could explain the issue.

In our test case reverting the internHashCode did fix the performance loss when indexing our JAR file

OK, that is weird. The only change in 3.1.1 that could realistically cause this is #308. Could it be that you have a lot of recursive type parameters (T extends Something<T>) that have the same name? That would lead to a lot of hash table collisions, which could explain the issue.

Actually #308 has caused this issue. In our case we need to revert the version delivered in WildFly 29 back to 3.1.0 due to fact, that the deployment will take 15 instead of around 1 minute.
I wonder, that no benchmark test seem to have caught this problem unfortunately...

This seems to be a reasonable approach: https://github.com/Ladicek/jandex/commits/type-variable-reference-intern-hash-collisions Could you please build Jandex from that branch and test with it? Thank you!

Note that the branch actually changes the persistent index format, so it will require releasing Jandex 3.2. Also older versions of Jandex won't be able to read an index produced by Jandex built from that branch, so take care.

This seems to be a reasonable approach: https://github.com/Ladicek/jandex/commits/type-variable-reference-intern-hash-collisions Could you please build Jandex from that branch and test with it? Thank you!

@Ladicek I will run a check tomorrow and give you feedback

@Ladicek The proposed fix seems to have more ore less the same performance as the version 3.1.0 taking slightly longer:
Version 3.1.0

Proposed fix

Yeah, it does take a little more time -- the JAR from your repo requires cca 8 seconds to index with Jandex 3.1.0 on my machine, and roughly 10 seconds with the suggested patch. I would think that's acceptable, but I can try to reduce it further.
I was more interested in actual usage. If you replace Jandex in WildFly with the version from my branch, does that keep working for you? (I don't see why it shouldn't, all the existing Jandex tests pass, but real world feedback is always best.)

Hi @Ladicek I did some measurements for comparison as follows:
Jandex 3.1.0 without index file in jar (17s)
Rolled back library version on WildFly 29.
2023-08-25 10:00:57,318 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 71) [Usr#] WFLYCLINF0002: Started http-remoting-connector cache from ejb container
2023-08-25 10:01:14,771 WARN  [org.jboss.as.server.deployment] (MSC service thread 1-4) [Usr#] WFLYSRV0059: Class Path entry mchange-commons-java-0.2.15.jar in /C:/bison/base/20230824_131254/wildfly-29.0.0.Final/standalone/deployments/BisonProcess.ear/lib/c3p0.jar  does not point to a valid jar for a Class-Path reference.

Jandex 3.1.2 without index file in jar (12min 17s)
Current state using WildFly 29 without any changes.
2023-08-21 10:29:27,960 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 71) [Usr#] WFLYCLINF0002: Started http-remoting-connector cache from ejb container
2023-08-21 10:41:44,325 WARN  [org.jboss.as.server.deployment] (MSC service thread 1-2) [Usr#] WFLYSRV0059: Class Path entry mchange-commons-java-0.2.15.jar in /C:/bison/base/20230821_093101/wildfly-29.0.0.Final/standalone/deployments/BisonProcess.ear/lib/c3p0.jar  does not point to a valid jar for a Class-Path reference.

Jandex 3.1.3-SNAPSHOT with index file in (22s)
Proposed library version on WildFly 29 accessing the big file with an index generated using Jandex 3.0.5.
2023-08-25 09:33:29,978 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 71) [Usr#] WFLYCLINF0002: Started http-remoting-connector cache from ejb container
2023-08-25 09:33:34,381 WARN  [org.jboss.as.server.deployment] (MSC service thread 1-2) [Usr#] WFLYSRV0002: Loading failed for the annotation index "/C:/bison/base/20230824_131254/wildfly-29.0.0.Final/standalone/deployments/BisonProcess.ear/lib/CH.obj.Application.generated.jar/META-INF/jandex.idx" with the following exception: java.lang.IllegalStateException: Invalid tag: 14
2023-08-25 09:33:51,020 WARN  [org.jboss.as.server.deployment] (MSC service thread 1-2) [Usr#] WFLYSRV0059: Class Path entry mchange-commons-java-0.2.15.jar in /C:/bison/base/20230824_131254/wildfly-29.0.0.Final/standalone/deployments/BisonProcess.ear/lib/c3p0.jar  does not point to a valid jar for a Class-Path reference.

Jandex 3.1.3-SNAPSHOT without index file in jar (20s)
Proposed library version on WildFly 29.
2023-08-25 09:37:44,489 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 71) [Usr#] WFLYCLINF0002: Started http-remoting-connector cache from ejb container
2023-08-25 09:38:04,063 WARN  [org.jboss.as.server.deployment] (MSC service thread 1-3) [Usr#] WFLYSRV0059: Class Path entry mchange-commons-java-0.2.15.jar in /C:/bison/base/20230824_131254/wildfly-29.0.0.Final/standalone/deployments/BisonProcess.ear/lib/c3p0.jar  does not point to a valid jar for a Class-Path reference.

OK, thanks. I was more interested in hearing about any possible issues when running the application, but I realized that there's most likely nothing in WildFly bothering about type variable references, so we should be good there.
The 3rd experiment is interesting, Jandex 3.1.3-SNAPSHOT should very much be able to read an index generated by 3.0.5. There must be a bug somewhere, likely similar to #320, which I need to investigate.
In any case, as I mentioned, this will need Jandex 3.2, because of the change of persistent index format.

OK, I fixed the case when Jandex 3.1.3-SNAPSHOT couldn't read an index generated by 3.0.5, that was some poor handling of versioning on my side. Thanks for highlighting that.

In any case, as I mentioned, this will need Jandex 3.2, because of the change of persistent index format.

@Ladicek thanks for your fast feedback. For providing an index within our big libraries can mitigate the issue and we would patch our WildFly instance if needed. I guess that as long as we keep generating the index using a Jandex version that aligns the one for WildFly we should be save. Having a fix in the future will be perfectly ok for us.

If indexing takes longer time, pregenerating the index (using the Maven plugin for example) is a good choice indeed.

@Ladicek does this mean, that you create a version 3.2.0 now?

There's one more PR that needs some more work (#361), so it will take a bit more time, but 3.2.0 is near indeed.


[Bug]: Objective constructors have bad initial keyword args

What happened?
function QuadraticSmoothnessRegularizer(;
	name::Symbol=nothing,
	times::AbstractVector{Int}=1:traj.T,
	R::AbstractVector{<:Real}=ones(traj.dims[name]),
	eval_hessian=true
)

and
function QuadraticRegularizer(;
	name::Symbol=nothing,
	times::AbstractVector{Int}=1:traj.T,
	dim::Int=nothing,
	R::AbstractVector{<:Real}=ones(traj.dims[name]),
	values::Union{Nothing,AbstractArray{<:Real}}=nothing,
	eval_hessian=true,
	timestep_symbol=:Δt
)

are an example of the bug. These interfaces are not usually called, but still the interface of these objectives should be adjusted.
Version
stable release
What does this bug affect?

[ ] quantum system construction
[X] problem setup
[ ] problem solution
[ ] problem performance
[ ] solution analysis
[ ] plotting
[ ] documentation
[ ] tests
[ ] other (please specify below)

Other information
No response

For now, the fix should be to set default args to nothing, with their types declared as Unions with nothing so that the asserts print.


Fix styling of GitHub source code links

Implement the design here: https://github.com/Qiskit/documentation/issues/518#issuecomment-1954927049.
This needs to be done in the internal repository and should get designer sign off before landing.

Closed by @arnaucasau with https://github.com/Qiskit/documentation/pull/915 and a change to the docs app to use 4 pixels rather than 8 pixels of padding for code blocks. Thanks! This looks much better. And thanks @gracelindsell for the design guidance.


Create example date range picker

This is now available in the demo repo or stackblitz

Thank for demo. Is it possible to have a demo version without jQuery? jQuery is not listed as a dependency for this module.

This is now available in the demo repo or stackblitz

Hey, @bodyfarmer JQuery is not a dependency of the module, only the demo. I made the demo in the simplest way I thought of at the time. Of course all of the JQuery calls can be replaced with direct DOM api calls.  A Pull Request with the changes you requested would be most welcome.


Bug in tf.autodiff.ForwardAccumulator for tf.signal.mdct

Click to expand!
Issue Type
Bug
Source
binary
Tensorflow Version
tf 2.9
Custom Code
Yes
OS Platform and Distribution
Linux Ubuntu 20.04
Mobile device
No response
Python version
3.9
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
Gradient in forward mode is inconsistent with that in backward mode for API `tf.signal.mdct`

Standalone code to reproduce the issue
import tensorflow as tf
signals = tf.constant([3.3425903], dtype=tf.float32)
frame_length = 49152
with tf.GradientTape(persistent=True,) as g:
      g.watch(signals)
      res = tf.reduce_sum(tf.signal.mdct(signals, frame_length, window_fn=None, pad_end=True, norm=None))
      print(res)
print("gradient in reverse mode: ", g.gradient(res, signals))

with tf.autodiff.ForwardAccumulator(signals,tf.constant([1.],shape=[1],dtype=tf.float32)) as acc:
        res = tf.reduce_sum(tf.signal.mdct(signals, frame_length, window_fn=None, pad_end=True, norm=None, ))
        print(res)
print("gradient in forward mode: ", acc.jvp(res))

Relevant log output
tf.Tensor(11.523682, shape=(), dtype=float32)
gradient in reverse mode:  tf.Tensor([1.0006392], shape=(1,), dtype=float32)
tf.Tensor(11.523682, shape=(), dtype=float32)
gradient in forward mode:  tf.Tensor(3.4477844, shape=(), dtype=float32)

@gowthamkpr I was able to replicate the issue on colab , please find the gist here. Thank you!

You're running into floating-point precision issues because the frame length is too large (representable numbers go out of range in forward accumulation of gradients).  Changing to float64 fixes the issue.


The method 'setBackgroundHandler' isn't defined for the type 'FlutterUploader'

Hi,
I'm getting this error:
The method 'setBackgroundHandler' isn't defined for the type 'FlutterUploader'
import 'package:flutter_uploader/flutter_uploader.dart';

class UploadVideo extends StatefulWidget {
  @override
  _UploadVideoState createState() => _UploadVideoState();
}

class _UploadVideoState extends State<UploadVideo> {
  @override
  void initState() {
    super.initState();
    FlutterUploader().setBackgroundHandler(backgroundHandler);
  }

  void backgroundHandler() {
    WidgetsFlutterBinding.ensureInitialized();

    FlutterUploader uploader = FlutterUploader();

    uploader.progress.listen((progress) {
      print('UPLOAD:PROGRESS: ${progress.progress}');
    });

    uploader.result.listen((result) {
      print('UPLOAD:RESULT: ${result.status}');
    });
  }

...........rest

Am I missing something? Also, do I need to make the AppDelegate changes that are in the GitHub readme? They are not in the pub.dev instructions?

I've closed this issue. Is the Github readme out of date?

@andykitt if you are using the code from Github's master branch, then you may need some adjustments. Please check the example in example/lib/main.dart.


esp::core::Configuration changed to use unordered_maps instead of Magnum::ConfigurationGroups

Motivation and Context
Currently Habitat-sim uses Magnum::ConfigurationGroups as the backing datastructure for all metadata loaded via JSON configuration files.  A ConfigurationGroup saves all data as strings, and the original type of that data is lost once it is loaded into the system.  This is particularly problematic with the user-defined attributes that habitat now supports. Upon read, the type of the user-defined value is inferred by the format of the data in the source JSON.  With the upcoming functionality to save JSON configs to disk, including user_defined values, without having the type known will cause all data to be saved to disk as strings.
This PR replaces the ConfigurationGroup as the container for esp::core::Configuration and instead uses a collection of typed std::unordered_maps.
One question to consider : do we wish to remove the ConfigurationGroup as the backing structure for esp::core::Configuration.  A different structure can be easily designed to replace esp::core::Configuration as the base class for the various configuration attributes that Habitat uses.
If nobody is using an esp::core::Configuration currently outside of the Metadata attributes/configuration subsystem, then the changes proposed by this PR can probably proceed with impunity; if, however, the ConfigurationGroup functionality backing habitat's Configuration is desired to remain, then I should instead create another class to back the attributes.

How Has This Been Tested
Locally, all c++ and python tests pass.

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Really would like to hear @mosra's input on this. Might be a better solution.

Discussing this refactor with @mosra, he suggested I investigate a tagged union storage container, so this PR introduces this.

A std::variant/std::visitor system would have been safer and more streamlined, but these require c++17, which we do not currently support.
This would be nice to have and PyBind11 has native support for std::variant. Everything seems to compile just fine under C++17 so I would in favor of upgrading as well. https://pybind11.readthedocs.io/en/stable/advanced/cast/stl.html#c-17-library-containers. There are also some minor improvements in PyBind11 you get when using C++17 thanks to fold expressions and better constexpr support.

A std::variant/std::visitor system would have been safer and more streamlined, but these require c++17, which we do not currently support.

This would be nice to have and PyBind11 has native support for std::variant. Everything seems to compile just fine under C++17 so I would in favor of upgrading as well. https://pybind11.readthedocs.io/en/stable/advanced/cast/stl.html#c-17-library-containers. There are also some minor improvements in PyBind11 you get when using C++17 thanks to fold expressions and better constexpr support.

Just FYI, when I said safer and more streamlined, I meant as compared to the former tagged-union refactor that this PR originally introduced.  The system that I replaced it with (with substantial guidance from @mosra ) does not have the same safety concerns.

Re std::variant, to clarify my view and repeat to what I said to John privately -- I think what we created here does everything we need, is safe, memory- and runtime-efficient, compiles fast and is reasonably easy to maintain / extend for new types.
On the other hand, std::variant<bool, int, double, Vector3, Quaternion, Rad, std::string, Configuration, ...> would have notorious issues with compile times, where the compile-time cost of accessing a value scales linearly with the number of types a variant can store, and it can quickly become unbearable to the point where people have to "optimize" by storing e.g. a float as a Vector3 to reduce the amount of types used. (Not to mention the "fun" one has to go through with std::visit().) Yes, I'm skeptical about C++17 features.

About python bindings, I think we're fine here, exposing all types in a Pythonic way wasn't too complicated.


Don't handle request when the response is instance of StreamedResponse

Fixes the Call to undefined method Symfony\Component\HttpFoundation\StreamedResponse::header() error on responses of type StreamedResponse. The StreamedResponse has no header() method.
Fixes #7

Hi @WesleyE,
Thanks for the pull request.
After reviewing symfony http-foundation source code, I found that calling ResponseHeaderBag set method directly could also solve the problem.
Thus, instead of excluding response class, I think using this solution is more suitable.


Usage section isn't up-to-date?

In the Usage section it says to add:
libraryDependencies ++= Seq(
  "io.swagger" %% "swagger-play2" % "2.0.1-SNAPSHOT"
)

but that leads to downloads from URLS like
https://repo1.maven.org/maven2/io/swagger/swagger-play2_2.13/2.0.1-SNAPSHOT/swagger-play2_2.13-2.0.1-SNAPSHOT.pom
that aren't found.

https://mvnrepository.com/artifact/io.swagger/swagger-play2 - 2.0.1-SNAPSHOT ain't there

That's my issue, so it basically mean that this project can't be used with play 2.7 I suppose...

Hey @frantuma is the 2.0.1-SNAPSHOT version going to be published? It would be great to use this library for our 2.7 play project.


can i insert a formula?

how can i insert a formula behind a portion?

@cooskaka, not sure I understand the question. Do you mean math formula? Could you please give more details or some screenshot how it looks like.

yes,insert math formula,like this:

No, it is not supported.


index 55 is out of bounds for axis 0 with size 55

This is the issue When I run this code:
Traceback (most recent call last):
File "ceshi.py", line 44, in
flow_color = flow_vis.flow_to_color(flow_uv, convert_to_bgr=False)
File "/home/fang/OpticalFlow_Visualization-master/flow_vis.py", line 142, in flow_to_color
return flow_compute_color(u, v, convert_to_bgr)
File "/home/fang/OpticalFlow_Visualization-master/flow_vis.py", line 99, in flow_compute_color
col0 = tmp[k0] / 255.0
IndexError: index 55 is out of bounds for axis 0 with size 55
Can somebody tell me What's wrong about it?

The Matlab original has:
fk = (a+1) /2 * (ncols-1) + 1;  % -1~1 maped to 1~ncols

This +1 at the end is for Malab 1-based coordinates - and it was preserved in the Python code:
fk = (a+1) / 2*(ncols-1) + 1

Looks like changing this to:
fk = (a+1) / 2*(ncols-1)

should help.

Pull request #3


Add uv-lock to pre-commit

This will be helpful for e.g., dependabot PRs that update pyproject.toml, but don't know how to update the uv.lock, as we can just ask pre-commit CI to fix them, with the CI still running with locked deps every time.

Nevermind, this is fraught with issues:

uv needs to install packages which are not allowed at runtime in free pre-commit.ci
uv in pre-commit ends up nuking another installed local version's cache


Feature request: Set pull intervall

Hello @Ludy87 ,
I saw that data is being pulled regularly. Would it be (or is it maybe already) possible to set this interval manually?
Thank you for your consideration.
Alex

If you put the interval over the value of 24 hours, it could happen that you miss a day. The best solution would currently be 11:59 hours.

Miss a day of what?
Do they also offer daily data for some devices?
Would it not be possible to define a scan_interval in the config?
Heating data e.g. is monthly.  So not mich point in checking daily.
Alternatively (and maybe linked to by other request), would it not be possible to check daily but only write new data point if the data is from a month that is not yet im database?

You can use scan_interval

@tribut I think if Hassio is restarted, the current data will only be fetched a day later.
You could possibly use 11 h 59 min 59 sec to push it to the limit.

I thought that the scan_interval is normally started at reboot. So the clock resets itself.
But I could well be mistaken because I set the scan_interval to 60 seconds so I can test pulling 2022 data and it so far has not updated the sensor at all.
But this is strange to me. Why would it not apply the new scan_interval until the next day?

You misunderstand that, if the interval is set to 24 hours and you start Hassio now at 1 p.m., the data will not be queried again until 1 p.m.


pull before tree/find

https://github.com/justwatchcom/gopass/issues/281#issuecomment-324937685
In a similar vein to this comment. It would be useful to attempt to do a git pull before gopass search & such.
This would make it easier to transparently operate in a team.

We were considering this before, but so far I think this might be too slow/expensive.
We may consider doing that if a search yields no results, but if we do it on every operation (even if only on search) that would incur a sever latency that some people (including me) are not willing to pay.

Agree that it's well-intentioned, but probably a bad idea overall.
Especially since it opens a lot of new corner cases - like a connection interruption (or air-gapped server) blocking showing the tree, while you just want to access the damn secret because you know it's downloaded already.
There's a few milder versions that are more promising IMHO, food for thought:

Simple new short flag that shouldn't collide with any existing so far (haven't checked TBH), like gopass search -p foo or gopass tree -p will pull before executing
Kicking off a simple (and hopefully fast) comparison with upstream in a background goroutine, with a timeout and waiting for either upstream fetch or that short timeout (maximum maybe 2s), displaying a message after the command: "Newer upstream version detected, type gopass pull && !! to update"
A combination of the above

@SevereOverfl0w Do you think the new gopass sync command could be useful for your usecase? It's not yet in any release, but we're trying to publish an release candidate soon.

I definitely think it could help.
I'm slightly on the fence with this one, because of the problems you highlighted.
This might be something for tooling to solve (e.g. The various browser integrations can offer a helpful sync button).
I'm mostly trying to minimize friction for people who may irregularly use this tool in a team such that I don't get a "The password is missing, halp"
I do like the suggestion of sync on a failed find, but accept this makes the tool more complex.
-------- Original message --------From: Dominik Schulz<EMAIL_ADDRESS>Date: 12/09/2017  12:13  (GMT+00:00) To: justwatchcom/gopass<EMAIL_ADDRESS>Cc: Dominic Monroe<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [justwatchcom/gopass] pull before tree/find (#320)
@SevereOverfl0w Do you think the new gopass sync command could be useful for your usecase? It's not yet in any release, but we're trying to publish an release candidate soon.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/justwatchcom/gopass","title":"justwatchcom/gopass","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/justwatchcom/gopass"}},"updates":{"snippets":[{"icon":"PERSON","message":"@dominikschulz in #320: @SevereOverfl0w Do you think the new gopass sync command could be useful for your usecase? It's not yet in any release, but we're trying to publish an release candidate soon."}],"action":{"name":"View Issue","url":"https://github.com/justwatchcom/gopass/issues/320#issuecomment-328821289"}}}

As a possible workaround that is less intrusive I've added a "sync" hotkey to the selection wizard. Hope that helps. Still don't want to run sync/pull on every search.


3d Items can't click properly if the page is scrollable

If I tried to implement the blueprint layout in my page, IN 3d modules, Items e.g window, doors can't click or move if the page is not focus on the center of the 3d (viewer). Is there any way that it can be work even the page is scrollable ? Thanks

I believe this is due to the offset calculation happening because of scrolling. Ensure always to keep the 3d, 2d area to have the full visible area instead of scrolling


Addresses #26184 - use configuration for pinned default

Uses the configuration setting workbench.editor.enablePreview to provide a default of pinned if not explicitly passed. See https://github.com/Microsoft/vscode/issues/26184#issuecomment-300984513
Hopefully this is decent way of implementing this :)
/cc @jrieken @bpasero

I have the feeling that this would be a lot more simple if that is implemented in the _workbench.diff-command with some true, false, and undefined values for pinned set from the API

@jrieken I've re-worked this completely to move it down to hopefully the lowest level. So as per @bpasero comments, if you pass true / false for pinned it will be honored, but undefined will enact the default behavior which is controlled first by workbench.editor.enablePreview and then the existing other checks

@eamodio this is a bad change as it can result in editors showing up as preview even though "workbench.editor.enablePreview": is set to false as soon as a client of openEditor is setting pinned: false.
I think what Joh meant is to implement this behaviour only in the _workbench.diff command but not throughout all users in the workbench?

@bpasero I guess I misunderstood your original comments. I thought the desire was to allow extensions to be able to fully control the pinned state regardless of workbench.editor.enablePreview, but if the extension passed undefined then the default would be based upon the current default rules including the check of workbench.editor.enablePreview.
If that isn't the case and workbench.editor.enablePreview should rule regardless I can just tweak that back here to make the this.tabOptions.previewEditors always win

@bpasero Updated to honor workbench.editor.enablePreview above all else

Not sure how this should work @bpasero? Now pinned is more or less removed in most placed which makes sense if we have a reasonable and configurable default but I don't know why folks have done it like that in the first place

I do not really understand the need for introducing undefined for this. I agree that we should not set pinning hard coded from anywhere unless we know that the action that triggers the opening wants to pin or not pin. One example is double clicking on an entry in a tree or making something dirty.
If we simply do not set pinning state when opening things, the default will be to open as preview unless this is disabled via user settings.
In other words, I would let extensions opt-in to pinning (with the API we have today) but not set it by default. This should give the correct experience.
Btw for webviews we should probably enforce pinning simply because the UI state in there is not preserved and it would be odd to loose the content so quickly.

When I wasn't honoring workbench.editor.enablePreview, undefined was required as there wasn't a way to say I want the "default" behavior, its either pinned or not. But now that we are again always honoring workbench.editor.enablePreview I guess pinned === false is the equivalent of use the "default".
Although honestly, I'd rather leave undefined in there because it is a clear indicator of not specifying the behavior and that the default behavior should be used. That way if down the line something there changes you know the difference between something not caring about pinned/unpinned vs explicit intent.

@bpasero do you want me to make the changes to take out undefined?

@eamodio yes, thanks

@bpasero I (hopefully) removed all the undefined's from the internal calls -- though I left it from calls from extensions. I also rebased this branch to master as well. Let me know if you want me to make any other changes.

@bpasero Any thoughts on the above?

@eamodio what is the use case for forcing an editor to be not-pinned (= previewed)? Can you give me an example?

@eamodio in your demo today at lunch, you indicated that you wanted to open diff editors from the picker as preview and not pinned. But is that really an issue still if we do not set the pinned state by default from extensions? It seems to me the original request for pinned: false only existed because we used to set pinned: true by default. If you would just not set the pinned attribute at all, any editor you open should show up as preview editor unless the user has disabled this feature.

@bpasero Yeah, just being able to control it is enough. Though the main reason I wanted to plumb it all the way through was so that the final code could know the expressed desire of the extension, because it was passed as false, not left undefined. The only actual difference this would have is if this condition is met: (options && typeof options.index === 'number') || input.isDirty(), because those cases could end up changing pinned to true, even though false was passed. While this is true of the overall "preview editors" setting -- that feels different. IMO at least ;)

@eamodio thanks. I made some changes on top of yours. My argument is still that the pinned state cannot be overridden by the user if explicitly defined. Lots of stuff in the editor world depends on a dirty file being pinned for example (you cannot have a dirty file that shows up as preview).
I went ahead and merged the PR because the original request seems addressed.


Add check for Memcached class in CreatePoolTrait

Q
A

Tests pass?
yes

License
MIT

Hm, I understand that you like to have this because you run phpunit in the project root. I've solved the same problem by adding my own phpunit.xml and configured it to skip the Memchaced tests.
Im not sure this is a good idea because you may skip more test then you should without knowing it. On the other hand it may get easier for developers to run the project.

we only suggest to use memcached so the developer should know what he needs to run this

I close this, then.


If cart rule condition does not match the cart then on applying coupon it should display message "Coupon cannot be applied".

Bug report
Title
If cart rule condition does not match the cart then on applying coupon it should display message "Coupon cannot be applied".
Issue Description
If cart rule condition does not match the cart then on applying coupon it should display message "Coupon cannot be applied".
Preconditions
1. Commit id.-567419a534dbe0dc16866124090e73f90e9e5f85

Steps to reproduce
1. step1- Create a cart rule with coupon.
2. step2- Apply this coupon on a cart which does not fulfill the conditions of rule.

Expected result
It should display a message that "Coupon cannot be applied"
Actual result

Commit Id: f0e5bfdae76e77dc49c4acce05912c90cb01eecf

Fixed


fix: min_values and max_values when selecting tags

Currently, I think the min_values should be 1, since from this behaviour, if none of any option is chosen, the bot will be offline for a while (?) and thus, interaction failed.

For max_values, it should be limit to 5, as when I tested it with 6 options chosen, the bot refused to edit the forum tags, thus, interaction failed.

Add a remove all option then

Huh, another button or another option in the SelectMenu?

Add a remove all option then

Huh, another button or another option in the SelectMenu?

Select

Add a remove all option then

Huh, another button or another option in the SelectMenu?

Select

Commited. 828875b


Fix recursive loop in BVH building

Brief Description
When all primitive centroids are equal during a recursive BVH building step, it results in a recursive loop.
This fix detects this case and returns a leaf node instead.
Pull Request Guidelines

[ ] I have added pull requests labels which describe my contribution.
[x] All existing tests passed.

[ ] I have added tests to cover my changes, of which pass.

[x] I have compared the render output of my branch to master.
[x] My code has passed the ESLint configuration for this project.
[ ] My change requires modifications to the documentation.

[ ] I have updated the documentation accordingly.

Thanks for your PR! I encountered this bug myself, but I never got to the bottom of it, so it's great you figured it out.
I have a lot on my plate right now, but I can review and merge your fix in the next couple days when I have a moment.

Looks good! Lastly, we omit the build files from PRs since they're automatically generated for each release. Could you revert the changes to the build files?

I removed the /build folder changes from the commit. Let us hope we are good to go now!

@ToJans thanks!


Website results in 404 error

Accessing the website results in 404 error. (same issue as yesterday)

Going directly to the docs works though, just the landing page seems to be gone.
This works -> https://facebook.github.io/jest/docs/en/api.html

Seems to be back up for me.

Yeah, it went back up by the time @thymikee commented. Not really sure what's going on, or if it's the "fault" of docusaurus, circle ci or github pages

It works now.

Not sure what's going on - it seems like the redirect from https://facebook.github.io/jest/ to https://facebook.github.io/jest/en (notice language at the end) is down during deploys. I suspect either crowding or docosaurus is doing something weird.
@ericnakagawa @JoelMarcey ideas?

@SimenB Can you provide a bit more context? The site seems functional now. Am I missing something there?
What exactly was done when you noticed that the site was down to make it come back up?
Just trying to figure out if there is something reproducible here.

It's during deploy. You might be able to reproduce by triggering a deploy of the website?

Right. I understand that I think. But now the site is functional (right?). What was done to make the site functional again? Or are you saying that once the deploy is finished, the site is fine. i.e., in the seconds/minutes that the site is deploying, you get the funky behavior, but after that, all is good?

Yes, correct. I wonder if it's related to crowdin, as it takes a few minutes and the thing that's gone is the default language redirect

Talking to some folks here, @ericnakagawa and @rickyvetter

Perhaps something happening when pages are being built and pages get deleted before completing. The issue reported mentioned pages "showing up" later. That sounds like something is delayed maybe something with their Github's gh-pages deployment.

almost certainly not a crowdin issue because all of the crowdin interaction happens before you git push. its either an issue with gh-pages deployment or with the browser cache.

https://github.com/facebook/jest/issues/6508 :(

@SimenB that issue you referenced is closed now. Is there still a problem?
Also, what version of Docusaurus are you running now? 1.2.1? That’s the latest.
Sent with GitHawk

Yeah, it fixes itself. But it still happens. We're in 1.0.14. Should we upgrade?

There have been a bunch of fixes since then. It may help. You can look at the Changelog see what has been added and fixed.
Of course, run locally first to make sure nothing breaks.
cc @yangshun @endiliey
Sent with GitHawk

Do we know why it fixes itself?

No, but I suspect (without evidence) that it's down during deploy, but comes up again after deploy is done. There was a merge-spree for PRs yesterday, same as the last time (this issue was opened when we merged PRs for the Jest 23 release).

Actually, we'll release 1.3.0 soon and I can help to do an upgrade for Jest.

Great, I'll hold off then 🙂

1.3.0 is released 😊

Hopefully fixed


Roll Flutter Engine from fdc667ebb34e to 0a2afce2ec0d (2 revisions)

https://github.com/flutter/engine/compare/fdc667ebb34e...0a2afce2ec0d
2024-10-14<EMAIL_ADDRESS>Remove fl_keyboard_view_delegate_subscribe_to_layout_change and just access the object directly via a method (flutter/engine#55817)
2024-10-13<EMAIL_ADDRESS>Split out FlKeyboardLayout into its own class (flutter/engine#55816)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


There is no way to disable shader visualization in the 2d mode of Godot.

Godot version:
Godot_v3.0.6-stable_x11
OS/device including version:
Linux Mint 19
Issue description:
There is no way to disable shader visualization in the 2d mode of Godot. In 3d mode, you can click on Perspective in the upper corner of the workspace and select Display Unshaded. But in the 2D there is no such possibility.

So you want to remove all the shaders and just show the sprites and also remove the light effects.
Am I correct or is there something more?
I really think wireframe will also look cool in 2D and make it easier to find objects in complex scenes.

@swarnimarun I think there can be different reasons for this. In my case, I'm just tired of the constant vision of shaders. In addition, in case of an error in the shader code, the shader starts to unpleasantly slow down.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


Reimplementation of GlobalPhone as wrapper around libphonenumber-csharp

This fixes #26 , fixes #22, fixes #23

What do you think @twcclegg ?

I think it looks good, quite the reduction of code.

Thanks for the code review @twcclegg !


fix: correct typo in style sheet #128

Alaska Airlines Pull Request
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Fix a typo in the style sheet by adding a missing semicolon to ensure proper CSS syntax.
Bug Fixes:

Correct a typo in the style sheet by adding a missing semicolon in the CSS variable declaration.

:tada: This PR is included in version 5.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Minor: Fix user details page bugs

I worked on the following:

[x] Fix the user avatar not showing any letter when the displayName is an empty string
[x] Changed the patch request payload for displayName change to remove the displayName field if case of empty input instead of sending an empty string.

Before:
https://github.com/open-metadata/OpenMetadata/assets/51777795/09b96838-30ec-4d97-bc3e-272587f1f411
After:
https://github.com/open-metadata/OpenMetadata/assets/51777795/3fe8a0e2-826c-4ff1-9df1-045b74629dd4

Type of change:

[x] Bug fix
[x] Improvement

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya I've pushed the changes. Can you please review it again?


Returning null for hsl/hwb values that have additional characters after closing paren

The Regexes for cs.get.hsl and cs.get.hwb seem to lack an ending $ anchor, making strings like hsl(100, 50%, 50%)asdf return the parsed array rather than null. It seems that cs.get.rgb has the anchor. This behavior should be consistent, and I'm inclined to believe that the rgb Regex has it right and the return value for an invalid color string should always be null, even if the beginning of the string is valid.

I would agree :) thank you!

@Qix- would you mind publishing a new patch version with this change? Thanks!

Yep - I published as a minor patch even though this might break someone relying on this bug (hint: don't rely on this bug).
Published as 1.3.0.


chore(deps): update @shikijs/vitepress-twoslash to 1.5.0

Description
https://github.com/twoslashes/twoslash/pull/33 Implemented twoslash to support adding spaces in front of cut comments, so <!-- prettier-ignore-start --> can be removed.

It looks like the code examples now look indented though, I think we want to dedent it?

@bluwy Adjusted according to @sapphi-red 's suggestion, now there is no indentation. But now there is no scene with a space before the cut comment. 😃