Can you support objective-c

Can you support objective-c

Will need to figure this out. Looks like a similar issue to #13

@lexiaoyao20 - do you mind if I use your code as part of this project?

Thanks!
On Wed, May 29, 2019 at 7:07 AM lexiaoyao20<EMAIL_ADDRESS>wrote:

@lexiaoyao20 https://github.com/lexiaoyao20 - do you mind if I use your
code as part of this project?
NO problem.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/moozzyk/SignalR-Client-Swift/issues/37?email_source=notifications&email_token=AAK7JJDWHIXOOHYKXQJQ4YDPX2E2NA5CNFSM4GHXUP22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWPOGTA#issuecomment-496952140,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAK7JJCHWHPWF3UUU5USZGDPX2E2NANCNFSM4GHXUP2Q
.

I am trying to use SignalR-Client-Swift library on an objective C project when calling "start()". I'm getting next error.
2019-08-05T14:02:42.027Z debug: Negotiate response: {"connectionId":"9zjIAJuJmXkN9xLaGrwm3w","availableTransports":[{"transport":"WebSockets","transferFormats":["Text","Binary"]},{"transport":"ServerSentEvents","transferFormats":["Text"]},{"transport":"LongPolling","transferFormats":["Text","Binary"]}]}
2019-08-05T14:02:42.031Z debug: Negotation response received
2019-08-05T14:02:42.033Z info: Starting WebSocket transport
atos[69262]: atos cannot examine process 69257 (ProjectName) for unknown reasons, even though it appears to exist; try running with `sudo`.
==69257==WARNING: Can't read from symbolizer at fd 31
atos[69263]: atos cannot examine process 69257 (ProjectName) for unknown reasons, even though it appears to exist; try running with `sudo`.
==69257==WARNING: Can't read from symbolizer at fd 31
atos[69264]: atos cannot examine process 69257 (ProjectName) for unknown reasons, even though it appears to exist; try running with `sudo`.
==69257==WARNING: Can't read from symbolizer at fd 31
atos[69265]: atos cannot examine process 69257 (ProjectName) for unknown reasons, even though it appears to exist; try running with `sudo`.
==69257==WARNING: Can't read from symbolizer at fd 31
==69257==WARNING: Failed to use and restart external symbolizer!
==================
WARNING: ThreadSanitizer: Swift access race (pid=69257)
  Modifying access of Swift variable at 0x7b280002a280 by thread T10:
    #0 $s18SwiftSignalRClient7Manager33_7B38D54E3FC021D04F957FB8C00AFD21LLCADycfcyycfU_ <null> (SwiftSignalRClient:x86_64+0xd8692)
    #1 $s18SwiftSignalRClient7Manager33_7B38D54E3FC021D04F957FB8C00AFD21LLCADycfcyycfU_TA <null> (SwiftSignalRClient:x86_64+0xe474d)
    #2 $sIeg_IeyB_TR <null> (SwiftSignalRClient:x86_64+0x72460)
    #3 __tsan::invoke_and_release_block(void*) <null> (libclang_rt.tsan_iossim_dynamic.dylib:x86_64+0x676ab)
    #4 _dispatch_client_callout <null> (libdispatch.dylib:x86_64+0x3db4)

  Previous modifying access of Swift variable at 0x7b280002a280 by thread T11:
    #0 $s18SwiftSignalRClient7Manager33_7B38D54E3FC021D04F957FB8C00AFD21LLC6nextIdSiyF <null> (SwiftSignalRClient:x86_64+0xda53b)
    #1 $s18SwiftSignalRClient9WebSocketC7request12subProtocolsAC10Foundation10URLRequestV_SaySSGtcfc <null> (SwiftSignalRClient:x86_64+0xdc2a8)
    #2 $s18SwiftSignalRClient9WebSocketC7request12subProtocolsAC10Foundation10URLRequestV_SaySSGtcfC <null> (SwiftSignalRClient:x86_64+0xdbf92)
    #3 $s18SwiftSignalRClient19WebsocketsTransportC5start3url7optionsy10Foundation3URLV_AA21HttpConnectionOptionsCtF <null> (SwiftSignalRClient:x86_64+0xe9f72)
    #4 $s18SwiftSignalRClient19WebsocketsTransportCAA0E0A2aDP5start3url7optionsy10Foundation3URLV_AA21HttpConnectionOptionsCtFTW <null> (SwiftSignalRClient:x86_64+0xeeaa8)
    #5 $s18SwiftSignalRClient14HttpConnectionC14startTransport33_1386C1C9AB3A1F54B5B7C070283F4473LL19negotiationResponseyAA011NegotiationR0C_tF <null> (SwiftSignalRClient:x86_64+0xffc7)
    #6 $s18SwiftSignalRClient14HttpConnectionC5startyyFyAA19NegotiationResponseCcfU_ <null> (SwiftSignalRClient:x86_64+0xbddf)
    #7 $s18SwiftSignalRClient14HttpConnectionC5startyyFyAA19NegotiationResponseCcfU_TA <null> (SwiftSignalRClient:x86_64+0x15e78)
    #8 $s18SwiftSignalRClient14HttpConnectionC9negotiate33_1386C1C9AB3A1F54B5B7C070283F4473LL11accessToken0F11DidCompleteySSSg_yAA19NegotiationResponseCctFyAA0dU0CSg_s5Error_pSgtcfU0_ <null> (SwiftSignalRClient:x86_64+0xd558)
    #9 $s18SwiftSignalRClient14HttpConnectionC9negotiate33_1386C1C9AB3A1F54B5B7C070283F4473LL11accessToken0F11DidCompleteySSSg_yAA19NegotiationResponseCctFyAA0dU0CSg_s5Error_pSgtcfU0_TA <null> (SwiftSignalRClient:x86_64+0x18dbc)
    #10 $s18SwiftSignalRClient17DefaultHttpClientC04sendE7Request3url6method17completionHandlery10Foundation3URLV_SSyAA0E8ResponseCSg_s5Error_pSgtctFyAH4DataVSg_So13NSURLResponseCSgAOtcfU_ <null> (SwiftSignalRClient:x86_64+0x3c47)
    #11 $s18SwiftSignalRClient17DefaultHttpClientC04sendE7Request3url6method17completionHandlery10Foundation3URLV_SSyAA0E8ResponseCSg_s5Error_pSgtctFyAH4DataVSg_So13NSURLResponseCSgAOtcfU_TA <null> (SwiftSignalRClient:x86_64+0x47e8)
    #12 $s10Foundation4DataVSgSo13NSURLResponseCSgs5Error_pSgIegggg_So6NSDataCSgAGSo7NSErrorCSgIeyByyy_TR <null> (SwiftSignalRClient:x86_64+0x3e18)
    #13 __75-[__NSURLSessionLocal taskForClass:request:uploadFile:bodyData:completion:]_block_invoke <null> (CFNetwork:x86_64+0xc177)
    #14 _dispatch_client_callout <null> (libdispatch.dylib:x86_64+0x3db4)

  Location is heap block of size 160 at 0x7b280002a260 allocated by thread T11:
    #0 malloc <null> (libclang_rt.tsan_iossim_dynamic.dylib:x86_64+0x4a4fa)
    #1 swift_slowAlloc <null> (libswiftCore.dylib:x86_64+0x2ce3c8)
    #2 globalinit_33_7B38D54E3FC021D04F957FB8C00AFD21_func5 <null> (SwiftSignalRClient:x86_64+0xdab37)
    #3 dispatch_once <null> (libclang_rt.tsan_iossim_dynamic.dylib:x86_64+0x682d4)
    #4 dispatch_once_f <null> (libclang_rt.tsan_iossim_dynamic.dylib:x86_64+0x683c0)
    #5 swift_once <null> (libswiftCore.dylib:x86_64+0x2f0578)
    #6 $s18SwiftSignalRClient9WebSocketC7request12subProtocolsAC10Foundation10URLRequestV_SaySSGtcfc <null> (SwiftSignalRClient:x86_64+0xdc267)
    #7 $s18SwiftSignalRClient9WebSocketC7request12subProtocolsAC10Foundation10URLRequestV_SaySSGtcfC <null> (SwiftSignalRClient:x86_64+0xdbf92)
    #8 $s18SwiftSignalRClient19WebsocketsTransportC5start3url7optionsy10Foundation3URLV_AA21HttpConnectionOptionsCtF <null> (SwiftSignalRClient:x86_64+0xe9f72)
    #9 $s18SwiftSignalRClient19WebsocketsTransportCAA0E0A2aDP5start3url7optionsy10Foundation3URLV_AA21HttpConnectionOptionsCtFTW <null> (SwiftSignalRClient:x86_64+0xeeaa8)
    #10 $s18SwiftSignalRClient14HttpConnectionC14startTransport33_1386C1C9AB3A1F54B5B7C070283F4473LL19negotiationResponseyAA011NegotiationR0C_tF <null> (SwiftSignalRClient:x86_64+0xffc7)
    #11 $s18SwiftSignalRClient14HttpConnectionC5startyyFyAA19NegotiationResponseCcfU_ <null> (SwiftSignalRClient:x86_64+0xbddf)
    #12 $s18SwiftSignalRClient14HttpConnectionC5startyyFyAA19NegotiationResponseCcfU_TA <null> (SwiftSignalRClient:x86_64+0x15e78)
    #13 $s18SwiftSignalRClient14HttpConnectionC9negotiate33_1386C1C9AB3A1F54B5B7C070283F4473LL11accessToken0F11DidCompleteySSSg_yAA19NegotiationResponseCctFyAA0dU0CSg_s5Error_pSgtcfU0_ <null> (SwiftSignalRClient:x86_64+0xd558)
    #14 $s18SwiftSignalRClient14HttpConnectionC9negotiate33_1386C1C9AB3A1F54B5B7C070283F4473LL11accessToken0F11DidCompleteySSSg_yAA19NegotiationResponseCctFyAA0dU0CSg_s5Error_pSgtcfU0_TA <null> (SwiftSignalRClient:x86_64+0x18dbc)
    #15 $s18SwiftSignalRClient17DefaultHttpClientC04sendE7Request3url6method17completionHandlery10Foundation3URLV_SSyAA0E8ResponseCSg_s5Error_pSgtctFyAH4DataVSg_So13NSURLResponseCSgAOtcfU_ <null> (SwiftSignalRClient:x86_64+0x3c47)
    #16 $s18SwiftSignalRClient17DefaultHttpClientC04sendE7Request3url6method17completionHandlery10Foundation3URLV_SSyAA0E8ResponseCSg_s5Error_pSgtctFyAH4DataVSg_So13NSURLResponseCSgAOtcfU_TA <null> (SwiftSignalRClient:x86_64+0x47e8)
    #17 $s10Foundation4DataVSgSo13NSURLResponseCSgs5Error_pSgIegggg_So6NSDataCSgAGSo7NSErrorCSgIeyByyy_TR <null> (SwiftSignalRClient:x86_64+0x3e18)
    #18 __75-[__NSURLSessionLocal taskForClass:request:uploadFile:bodyData:completion:]_block_invoke <null> (CFNetwork:x86_64+0xc177)
    #19 _dispatch_client_callout <null> (libdispatch.dylib:x86_64+0x3db4)

  Thread T10 (tid=8726874, running) is a GCD worker thread

  Thread T11 (tid=8726875, running) is a GCD worker thread

SUMMARY: ThreadSanitizer: Swift access race (/Users/jordi/Library/Developer/CoreSimulator/Devices/B4868C29-CDA6-4EDE-BF04-03708A1A4B93/data/Containers/Bundle/Application/82AD19DA-C3E3-424F-80FF-8507A25D3134/ProjectName.app/Frameworks/SwiftSignalRClient.framework/SwiftSignalRClient:x86_64+0xd8692) in $s18SwiftSignalRClient7Manager33_7B38D54E3FC021D04F957FB8C00AFD21LLCADycfcyycfU_
==================
atos[69266]: atos cannot examine process 69257 (ProjectName) for unknown reasons, even though it appears to exist; try running with `sudo`.

@lexiaoyao20 or @moozzyk did you find a similar issue? Any tip would be appreciated!

Seems like a data race in the WebSocket library. The stack trace points to this code:
https://github.com/moozzyk/SignalR-Client-Swift/blob/9e235dcea5e48128c78654db67c4fbd68b59307d/Sources/SignalRClient/WebSocket.swift#L1651-L1656
but I don't immediately see anything there. I think the problem is that I don't know what code the other thread is running:
$s18SwiftSignalRClient7Manager33_7B38D54E3FC021D04F957FB8C00AFD21LLCADycfcyycfU_  (SwiftSignalRClient:x86_64+0xd8692)

I tried with a new obj-c project and only with this pod so no "external" code should be involved. I wonder (it works on swift) if there is some kind of compilation or transitional code that makes swift works in an objective c project that causes this "Swift access race".

If anyone interested, there is a pull request for the WebSocket.swift file on its original repo, that solves this issue. Pull request: https://github.com/tidwall/SwiftWebSocket/pull/141

@jaragones - this is a great find. My experience is that the SwiftWebSocket project is not actively maintained and PRs linger for a long time before they are merged (if ever). Fortunately, I forked the code so can take the fix without waiting for it to be merged in the SwiftWebSocket repo.

Cool! Thanks for the library by the way! :)

I applied the fix from the PR so if you try master you should no longer see the TSAN issue.

args, typeConverter 是啥

@jaragones - the version on CocoaPods now has the TSAN fix.

Cool, I was importing the library manually on my project! Thanks to let me know.

Is there any remaining work to support Objective-C? I am asking as the issue is still open, but from the conversation above it seems that @lexiaoyao20 @moozzyk  and @jaragones have a working solution.

I have not tried but I am not sure how well Objective-C works with Codable. The real interop should allow the same flexibility as the Swift version and a sane way of installing it into the project. What @lexiaoyao20 provided is great because it unblocks the scenario but require at least some work to turn it into a reusable framework solution. I started looking into it some time ago but given that I do this in my free time I barely made any progress.

You need to extend it on bridge with codable if response is not simple. But
apart from that on my case works like a charm. 😊
On Sat, 12 Oct 2019 at 23:00, Pawel Kadluczka<EMAIL_ADDRESS>wrote:

I have not tried but I am not sure how well Objective-C works with Codable.
The real interop should allow the same flexibility as the Swift version and
a sane way of installing it into the project. What @lexiaoyao20
https://github.com/lexiaoyao20 provided is great because it unblocks
the scenario but require at least some work to turn it into a reusable
framework solution. I started looking into it some time ago but given that
I do this in my free time I barely made any progress.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/moozzyk/SignalR-Client-Swift/issues/37?email_source=notifications&email_token=AAQVYS5PIWG5HIE4XXQ27ETQOI3IBA5CNFSM4GHXUP22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBCIHSA#issuecomment-541361096,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQVYSY6NASVO7CBNHKOQCTQOI3IBANCNFSM4GHXUP2Q
.

--
Sent from Gmail Mobile

I am not sure if this is simple to do in a generic way but good to hear
that it’s at least possible.
On Sun, Oct 13, 2019 at 11:50 AM Jordi Aragones-Vilella <
<EMAIL_ADDRESS>wrote:

You need to extend it on bridge with codable if response is not simple. But
apart from that on my case works like a charm. 😊
On Sat, 12 Oct 2019 at 23:00, Pawel Kadluczka<EMAIL_ADDRESS>wrote:

I have not tried but I am not sure how well Objective-C works with
Codable.
The real interop should allow the same flexibility as the Swift version
and
a sane way of installing it into the project. What @lexiaoyao20
https://github.com/lexiaoyao20 provided is great because it unblocks
the scenario but require at least some work to turn it into a reusable
framework solution. I started looking into it some time ago but given
that
I do this in my free time I barely made any progress.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/moozzyk/SignalR-Client-Swift/issues/37?email_source=notifications&email_token=AAQVYS5PIWG5HIE4XXQ27ETQOI3IBA5CNFSM4GHXUP22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBCIHSA#issuecomment-541361096
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAQVYSY6NASVO7CBNHKOQCTQOI3IBANCNFSM4GHXUP2Q
.

--
Sent from Gmail Mobile
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/moozzyk/SignalR-Client-Swift/issues/37?email_source=notifications&email_token=AAK7JJC5FGYTV753TXUGIJ3QONUWPA5CNFSM4GHXUP22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBC5B7Q#issuecomment-541446398,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAK7JJFS5BTG6GDH5ROOCK3QONUWPANCNFSM4GHXUP2Q
.

Has anyone tried https://github.com/DyKnow/SignalR-ObjC

I believe the client you pointed to is for the old (i.e. non-Asp.Net Core)
version of SignalR.
On Mon, Oct 14, 2019 at 9:11 AM Navneet Gupta<EMAIL_ADDRESS>wrote:

Has anyone tried https://github.com/DyKnow/SignalR-ObjC
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/moozzyk/SignalR-Client-Swift/issues/37?email_source=notifications&email_token=AAK7JJGSKIFKFYAJS7YBS4DQOSK3DA5CNFSM4GHXUP22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBFMNII#issuecomment-541771425,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAK7JJBLHKUZZWSEVMRA52LQOSK3DANCNFSM4GHXUP2Q
.

you can add an adapter to support objective-c, like this.
//
//  SignalRClient.h
//  Followme
//
//  Created by Subo on 2018/12/25.
//  Copyright © 2018年 com.followme. All rights reserved.
//

import Foundation
import SwiftSignalRClient

@objc public protocol SignalRClientDelegate : class {
    func clientDidConnectSuccess(client: SignalRClient)
    func clientDidConnectFailed(client: SignalRClient, error: Error)
    func clientDidClosed(client: SignalRClient, error: Error?)
}

/// 因为SwiftSignalRClient没有做OC的支持，所以这里多包装了一层来支持OC
@objcMembers public class SignalRClient : NSObject {
    var url: String
    var headers: [String: String]?

    private var connection: HubConnection?
    public weak var delegate: SignalRClientDelegate?

    public init(url: String, headers: [String: String]?) {
        self.url = url
        self.headers = headers
        super.init()
    }

    public func start() {
        self.connection = HubConnectionBuilder(url: URL(string: self.url)!)
            .withLogging(minLogLevel: .debug)
            .withHttpConnectionOptions(configureHttpOptions: { (httpConnectionOptions) in
                if let header = self.headers {
                    for (key, value) in header {
                        httpConnectionOptions.headers[key] = value
                    }
                }
            })
            .build()
        self.connection?.delegate = self
        self.connection?.start()
    }

    public func stop() {
        self.connection?.stop()
    }

    public func on(method: String, callback: @escaping (_ jsonString: String?) -> Void) {
        self.connection?.on(method: method, callback: {args, typeConverter in
            if let json = args.first as? String {
                callback(json)
                return
            }
            callback(nil)
        })
    }

    public func send(method: String, arguments:[AnyObject], sendDidComplete: @escaping (_ error: Error?) -> Void) {
        self.connection?.send(method: method, arguments: arguments, sendDidComplete: sendDidComplete)
    }

    public func invoke(method: String, arguments: [AnyObject], invocationDidComplete: @escaping (_ error: Error?) -> Void) {
        self.connection?.invoke(method: method, arguments: arguments, invocationDidComplete: invocationDidComplete)
    }
}

extension SignalRClient: HubConnectionDelegate {
    public func connectionDidOpen(hubConnection: HubConnection!) {
        self.delegate?.clientDidConnectSuccess(client: self)
    }

    public func connectionDidFailToOpen(error: Error) {
        self.delegate?.clientDidConnectFailed(client: self, error: error)
    }

    public func connectionDidClose(error: Error?) {
        self.delegate?.clientDidClosed(client: self, error: error)
    }
}

You can use it like this.
#import "YourTarget-Swift.h"

    NSString *url = @"https://xxxxxxxxxxx";
    NSDictionary *headers = @{@"token" : @"xxxxxxx"};
    self.client = [[SignalRClient alloc] initWithUrl:url headers:headers];
    self.client.delegate = self;

    __weak __typeof(self)weakSelf = self;
    [self.client onMethod:@"YourMethod" callback:^(NSString * _Nullable jsonString) {
        NSLog(@"arguments: %@", jsonString);
    }];

    [self.client start];

public func send(method: String, arguments:[AnyObject], sendDidComplete: @escaping (_ error: Error?) -> Void) {
self.connection?.send(method: method, arguments: arguments as! [Encodable], sendDidComplete: sendDidComplete)
}
public func invoke(method: String, arguments: [AnyObject], invocationDidComplete: @escaping (_ error: Error?) -> Void) {
    self.connection?.invoke(method: method, arguments: arguments as! [Encodable], invocationDidComplete: invocationDidComplete)
}

我按照你写的额,在oc里调用,但是不知道这个Encodable不知道对应OC里的什么修饰符号,最后报错
Could not cast value of type '__NSCFConstantString' (0x10a8e4ae0) to 'Swift.Encodable'

@aysw7331447 Encodable 无法转成OC的代码。
你只能用 SwiftSignalRClient 低版本的代码，我目前是用的 0.4.2 版本
pod 'SwiftSignalRClient', '0.4.2'

Can you support objective-c

Demo for adding an adapter to support objective-c via SwiftSignalRClient
https://github.com/zangyang/SignalR-ObjC-Bridge-Swift

@moozzyk any update on this?


Expand the Gender Options with a free text field

this discussion is currently at:
https://github.com/OpenSlides/openslides-backend/issues/847

done in os4


chore: linting

updated dev dependencies
updated linting rules
fixes for :point_up: rules

I wanna reuse the ruleset I created a while ago for all my projects https://github.com/floydspace/linters
which is basically a fork from https://github.com/Tinkoff/linters with some additions.
Let me raise the PR. Thank you for spending time on this though.

@floydspace Should I close this one? There are some fixes in here that I think should be merged.

Let me continue in your branch. if you don't mind


Allow embedding endpoint badges into the frontend

Motivation
The endpoint badge #2838 allows implementing the api-to-badge conversion logic in different locations without need to modify or add shields.io services. This leads to a possible diversification and emergence of new badges, which should be faster than badges added directly to shields.io source.
Context
In order to provide an endpoint badge, one "only" needs to create an API as specified in https://shields.io/#/endpoint.
However, to make this badge usable by other people, one as developer would like to provide the same template functionality as shields.io does, such as https://img.shields.io/appveyor/ci/:user/:repo.svg when you click on a badge at https://shields.io
Example: http://transifex.quelltext.eu/
Problem
Each new endpoint wants to provide configurable badges.
Currently, the endpoint badge only allows using your endpoint.
Configuration needs to be done manually by users or as crappy as on https://transifex.quelltext.eu
Possible Solution
A possible solution to this would be

[ ] A way of including endpoint badges into the shields.io frontend.
[ ] A documentation of how to achieve this

[ ] located in https://shields.io/#/endpoint or /docs?

Relevance
As stated earlier, I believe that in the future, more badges will exist using the endpoint API than the shields.io implementation. As such, it would be good, if shields.io is still the place to go to find these badges, sparing the badge users the hassle of different template engines.
Related:

https://github.com/badges/shields/issues/2838#issuecomment-458657152

Hi! That's a nice suggestion. I think we'd handle this like any other badge proposal. Since the upstream API uses the Shields.io format, the implementation is easier and could reuse existing code.

Would you like us to add one for Transifex? There's been interest: #497. I'm happy to do a PR if you'd like.
We could add on the endpoint page some documentation describing the process of getting a badge included, and maybe point to an example PR.
It could also be cool to have an embeddable front-end component that allows a service provider to provide a badge popup-like interface in their website, which allows users to set customization options and get a badge URL.

(1) Would you like us to add one for Transifex? There's been interest: #497. I'm happy to do a PR if you'd like.

We can add one for Transifex, yes. If you like, you can do it. I can do it, too. I think, it would be located in the endpoint directory, shouldn't it? Or not? Should it be a different service directory? Probably yes, because the sorting of the services is based on the topic and not on the implementation - although the API is probably the same if the topic ("Docker", "Transifex") is the same.
(2) Yes!
(3) I think this would be a new issue and not the scope of this one.

There's a bunch of helper code that needs to be moved / extracted, so I'm happy to take this one.

Should it be a different service directory? Probably yes, because the sorting of the services is based on the topic and not on the implementation - although the API is probably the same if the topic ("Docker", "Transifex") is the same.

Yup, exactly, it would belong in services/transifex.

Okay, you are welcome to do so. I can review if you like. Would you solve this issue and #497 at the same time?
What I would like to see is:

[ ] using multiple URLs for services in case of some going down (using just the first one is sufficient)
[ ] a reference to the endpoint's repository can be included so that we can track if something goes wrong and other people can do a set-up if needed.
[ ] customization of the endpoint's url, not the shields url using ?url=... in the frontend
[ ] adding all this information as JSON, no coding required.

I'm proposing we add a Transifex badge which would appear in our normal badge listing.
I feel like this is asking for something a bit different, which we could also do, which is provide a page where a user can paste in an endpoint badge URL and then customize it.

[ ] using multiple URLs for services in case of some going down (using just the first one is sufficient)

AFAIK we don't have any services that do this now.

I feel like this is asking for something a bit different, which we could also do, which is provide a page where a user can paste in an endpoint badge URL and then customize it.

I understand why it is not possible to do it 100% as I proposed: endpoints may have a different format from the one shields.io uses. Thus, it probably needs some programming to map the one format to the other.
i.e. shields: /transifex/:organization/:project whereas the service may use endpoint.json?org=:organization&p):project. It would not make sense to break from consistency for that. So, yep :+1:, I agree.

I know this isn't exactly what you asked for, though I think it's a nice touch to provide a customization UI you can use for live testing: http://shields-staging-pr-2908.herokuapp.com/#/endpoint
I'm working on the Transifex badge now.

I finished the refactor to make it easy to pipe through badge data that's using the endpoint format. There are some formatting changes I'd like to make to bring things in line with the other Shields badges. Would you like to make some changes to your badges to implement some formatting changes? Or, would you prefer that any re-formatting is done in Shields?


Update README.md

I wrote a step by step guide for Rust + Godot 3.2 (with pictures) which might help some people.
Feel free to close this PR if you don't feel it's a good fit.

To me this seems fine.
cc @nical @toasteater ?

It seems mostly fine to me as well, but I'm not very sure about naming a specific commit at the start of the tutorial:

# This was the current commit at the time of writing.
# This might not be necessary, but useful in case you
# run into errors.
git checkout c760b0b84fa689b9c248066ccf10e343948a48bb

I understand the usefulness of having a reference: it's a good way to tell whether the guide is out of date. The problem is, however, that it's presented as an instruction. The line is explained with comments, but knowing the kind of users (no offense intended) that will need this kind of tutorials in the first place, I doubt if they'll actually read them. Even if they did, the wording will probably lead them to the wrong conclusion: fast-forward a few months, "useful in case you run into errors" will be interpreted as "if the latest version broke compatibility with this outdated tutorial, run this ancient commit instead!"
The worst scenario comes when they encounter a problem with the commit named here, months later when a lot has changed. These users are hard enough to help as is, the last thing we want is them running some ancient obscure commit (and not telling anyone).
I'd suggest removing this line from the instructions, and putting the commit hash in the footnotes. The information will still be there for those interested, and the experience more streamlined for the less attentive readers.

That's a valid point. I have moved it to the bottom of the page and it reads more as information than an instruction.

After the change it seems fine to me as well.

I think this is good to merge. Thanks!


Fixup: Small Typo

Assosciation > Association
Missed that there a few further instances of this, and can't easily amend this PR on my Android so feel free to close it and create a better one.
Also not sure why the diff indicates I replaced L167, didn't touch.

Thank you for your contribution. Fixed in e80cc5d.


I'd argue that a .gitignore would still be good to have 😅

@anbraten Which one do you prefer, this one or #39?

This issue seems to let all CI runs in the other PRs fail - so should be merged to move on cleanly.

@anbraten The removed gitignore parts were there on purpose, following the templates of https://github.com/github/gitignore. Ofc up to you whether you want to have them but just that you are aware :)


libspng: init at 0.7.0-rc3

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 136274 run on x86_64-darwin 1

Update from @DavHau: https://github.com/DavHau/nixpkgs/commit/f0b7bbb20e4655592c9ff52f86063f52ceb9134c

Cherry-picked and formatted the changes from @DavHau

Thank you!


Implement a mechanism to use a resource URL for the API server

Issue Type

Feature request

Expected Behavior

Being able to specify the base URL for the api server depending on the environment. For instance, the base URL for the API server would be http://localhost:8000 if run locally, or http://api.<IP_ADDRESS>.nip.io if run on Minikube.
Current Behavior

The URLs are hardcoded.
Possible Solution

Link: https://stackoverflow.com/questions/39566875/what-is-the-preferred-way-to-set-phase-specific-environments-in-polymer-apps

Hi, I'm GitMate.io!
It seems you've just enabled the issue triaging. I'm just scraping all issues from your repository and will give you some more information about this in a few minutes or so.
Because of the rate limit we can't scrape all information (including all comments and authors) right now - our system is already set up to scrape this in the next days over which the predictions will become more precise every day.
If you want me to use a different account for triaging your issues, simply create one and log in with it.
Sit tight!

@rgreinho I'll take this one.

Oh cool! I am curious to see how you'll solve that one!


feat(RHOAIENG-15495): Add component metadata manifest

Refer to RHOAIENG-15495
Add template component_metadata to be populated with release values when performing community releases.

to be populated with release values when performing community releases

Do you plan to make this automatic?

to be populated with release values when performing community releases

Do you plan to make this automatic?

@danielezonca I could include some automation in a future PR. Perhaps getting the values from the release branch name? I think it's better than tag-based, since in that case the changes would happen after the tag is pushed.


fix adding a mark in addMark method when a node doesn't allow marks

Imagine I have a node:
{
    inline: true,
    marks: "",
    group: "inline",
    parseDOM: [{tag: "span"}],
    toDOM: function toDOM(node) {
      return ["span", {}, 'someText']
    }
}

When I try to apply a mark on that node, I expect the schema to restrict that, but yet its possible.
Playground: https://github.com/eshvedai/website/commit/2bccc0e214202484c5a03c7bdaeb6859cc13fa04
This PR is my attempt to fix this issue. Let me know if its not the best place, I'll update the PR.

I think you misunderstood what marks does. You can't restrict mark types per child node, you can only set the set of allowed marks in the parent node. I.e. your schema example disallows marks on the content of that node, not on the node itself. The parent.type.allowsMarkType part of the line you changed checks for this.

Got it, misunderstood indeed. Thanks for the explanation.


Application shortcut guide

Description of the new feature / enhancement
When one wants to pick a new shortcut, there's the issue of which shortcuts are already used (by which apps).
It would be tremendously useful to have a PowerToy showing the list of shortcuts that are current handled by running applications (as opposed to handled by Windows itself, which the Shortcut Guide is supposed to reflect), and set in application shortcuts:

Scenario when this would be used?
Whenever someone is looking for an unused shortcut / key combination.
Supporting information
No response

Good idea, I don't know if this is possible.  that is one hook, an app itself could force a hook, and there are multiple ways to get hooks for stuff like this.

This also would bubble into https://github.com/microsoft/PowerToys/issues/129.  i'm going to dup this against that


Add informational output to federate subcommands

This is intended to be in keeping with the output provided when creating and deleting resources with kubectl.

/lgtm


Rename queueLength to messageCount for Azure Service Bus scaler

Signed-off-by: Tom Kerkhove<EMAIL_ADDRESS>
Rename queueLength to messageCount for Azure Service Bus scaler since this is confusing when using topics.
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)
[ ] Tests have been added
[ ] A PR is opened to update the documentation on https://github.com/kedacore/keda-docs
[x] Changelog has been updated

I'll open a doc PR when this is agreed and merged. (depends on this PR as well)
Fixes #1109

Didn't run them locally and don't know how to write Go, but this will work for sure!

actually looks like a test case (TestAzServiceBusGetMetricSpecForScaling) is failing. I think the order of the test data in parseServiceBusMetadataDataset has changed, but azServiceBusMetricIdentifiers, which is used in that test depends on that order.


Update token_handler.py

Type
enhancement, bug_fix

Description

Introduced error handling in _get_system_user_tokens to gracefully handle failures, returning -1 in case of exceptions.
Fixed the missing newline at the end of the file in the count_tokens method.

Changes walkthrough
Relevant filesError handling

token_handler.pyEnhance Token Handling with Error Management

pr_agent/algo/token_handler.py
Added error handling in _get_system_user_tokens to return -1 on exception.  Ensured newline at the end of count_tokens method.

+10/-7

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

/help


Apps not automatically updating on Google Play, Profile

GIVEN I have enabled 'silent' System Updates in Owner Profile
AND I have installed a new profile with Google Play and Google Play Services (Sandboxed)
WHEN see 'Apps are up-to-date' as a silent notification
AND I check the Google Play Store updates
THEN I see that App updates can be installed/and are not up to date
Expected:
The app update and google play need to sync
As in you can just have the google play store automatically update
Is the notification just for the GrapheneOS apps?
Is there a way to automatically update the apps via Google Apps Sandboxed?
Provide secure delivery method for attachments
@thestinger If this is completely not possible, perhaps add a wiki on how to automatically ensure the 'google play' apps are kept up to date

Wrong location


Follow up with Alicia to set up Ansible playbooks

[x] CDH Web
[x] Geniza

Successfully deployed cdhweb and geniza to staging using Ansible Tower; confirmed that the playbooks also still work when from a local dev enviroment.
These are the two most urgent playbooks to get running in Tower; dropping geotaste from the initial list since we haven't had any requests about that one.


libc::abort prevents wasm build

Building for wasm currently fails because libc::abort is not available on this target.
$ rustup target add wasm32-unknown-unknown
$ cargo build --target wasm32-unknown-unknown
error[E0425]: cannot find function `abort` in module `libc`=======>    ] 17/18: crossbeam-channel
   --> src/internal/channel.rs:268:28
    |
268 |             unsafe { libc::abort() }
    |                            ^^^^^ not found in `libc`
help: possible candidates are found in other modules, you can import them into scope
    |
3   | use std::intrinsics::abort;
    |
3   | use std::process::abort;
    |

error[E0425]: cannot find function `abort` in module `libc`
  --> src/internal/utils.rs:61:24
   |
61 |         unsafe { libc::abort() }
   |                        ^^^^^ not found in `libc`
help: possible candidates are found in other modules, you can import them into scope
   |
3  | use std::intrinsics::abort;
   |
3  | use std::process::abort;
   |

error: aborting due to 2 previous errors

We're pretty close to at least compiling! Do you think it would be possible to use an alternative to libc::abort in these cases?

I've just replaced libc::abort with std::process::abort and released version 0.2.2.
Can you try with the new version?

It compiles! :tada:
Real testing will be for another time.
Thanks a lot!


[PTX-21149] Fix ValidateCreateVolume

What this PR does / why we need it:
This PR ensures the DevicePath is not empty for attached volumes in ValidateCreateVolume and TriggerVolumeCreatePXRestart.
Which issue(s) this PR fixes (optional)
Closes #PTX-21149
Special notes for your reviewer:
Please review the Jenkins build for the test cases "SetupTeardown" and "AppScaleUpAndDown" with "elasticsearch" app
https://jenkins.pwx.dev.purestorage.com/job/Users/job/Leela/job/tp-byoc/369
Aetos Dashboard: https://aetos.pwx.purestorage.com/resultSet/testSetID/431783

@kphalgun-px add backup job test also


IA: Poll based on canonical url [WIP]

parking this until I can talk to Facebook support

@mparent61 @benghaziboy this is ready for review.

Coverage increased (+0.9%) to 85.657% when pulling ea9a557123c857097020989e13f0b17de2eee737 on ia-canonical-url into 82b61f5ac41af9eae6e044e679724d057f87b9d4 on master.

👍

Coverage decreased (-0.2%) to 85.657% when pulling a987365f4aff5bbfee62bb6136f6c50907840cdf on ia-canonical-url into d9fd155b4dc72efb495af1c4d50437aa08e9ba6c on master.


Bitfields

Shamelessly stole (with consent) @coleifer's bitfield implementation. TBD we should decide if we want to support the slice operations Charles made that look like: https://github.com/coleifer/walrus/blob/617d2efafd3f2021054c228c2e1a1bfcf15f575b/walrus/tests/containers.py#L924
Fixes #926 and provide an alternate implementation to #1054.

@coleifer ping, just an FYI. Feel free to comment/participate.

@andymccurdy - very nicely done, thanks! I don't see any shame in stealing from the best.
I don't completely agree with overflow being inside incrby, I'm a strict Redis geek after all, but I can live with that :)
As for slicing, I liked @coleifer's suggestion. My pains are the inability (Python's) to support field signage and/or overflowage with it, but perhaps that can be resolved via careful documentation.

righteous! Bear in mind, too, that I stole my initial idea from @itamarhaber's patch, so we're all standing on eachother's shoulders here.

I stole mine from Andy's pipeline - a shining proof of Escherian Relativity.

@itamarhaber I added an overflow() method just for you :) Also you can now set a default_overflow when instantiating a bitfield. This default gets re-applied after the bitfield operation is executed, so if the same instance is used again, the default behavior is still there.
I haven't added slicing yet because of the signage problem. We can always add it later and I don't consider it critical to merging this.

Brilliant + I learned about the extend list method :)


Add more utils

As a result of safer interface few bugs are fixed and the ground is prepared for type-safe console output in druntime without calling any C I/O routines.

Possible regression: https://issues.dlang.org/show_bug.cgi?id=14783
Does this PR add overlap checking functionality or refactor existing one? If the latter, the refactoring introduced a regression.

Possible regression: https://issues.dlang.org/show_bug.cgi?id=14783

It's an enhancement, not a regression.

Does this PR add overlap checking functionality or refactor existing one? If the latter, the refactoring introduced a regression.

This pull fixes overlap checking. Previously cases like x[] *= x[] we accepted in release builds and rejected in debug ones.

cases like x[] *= x[] we accepted in release builds and rejected in debug ones.

I tested multiple D versions and in none of them did this code raise an error in non-release mode.

cases like x[] *= x[] we accepted in release builds and rejected in debug ones.

I tested multiple D versions and in none of them did this code raise an error in non-release mode.

As you see in a6aa6ee66dcbe3f77b4e0c816e02d8f32040dede, there were some checks, but only in debug build of a runtime. Also "cases like" doesn't mean this particular case, maybe for this exact type and this exact operator the check weren't even present in precondition block.

Regression or not applies to the final effect, not the nature of the change. If the checks were in a debug-only build of Druntime, they were effectively not there at all as we don't ship a debug runtime and almost no one builds one for themselves. If a well-intended and generally correct change broke valid code, it's still a regression. See issue discussion for whether this code is valid or not?

See issue discussion for whether this code is valid or not?

This code is not valid. Overlapping operations are not supported.

OK.

BTW, please try to not take it personally if a possible regression is found in your code. There are over a thousand regressions in Bugzilla. I go through bug reports, extract test cases and use semi-automatic tools to check if the test cases worked in previous versions of D or not. In many cases, when I'm not familiar with the relevant code I rely on the PR authors and reviewers to check if the issue is indeed a regression (hence the GH notifications).


Video List Feature

Hi,
Thanks for this good plugin. I was wondering whether is possible to add support to youtube video list.
For example, given the following URL:
https://www.youtube.com/embed/VIDEO_ID?playlist=aaaaaa,bbbbb,cccccc
After the main video was finished, continue with the list of videos in the playlist.
Best regards.

npm i<EMAIL_ADDRESS>docs here


Error: transaction from signature must match

I have try to send money, I get that: Error: transaction from signature must match. I only get that issue when sending money to cgeek.

@c-geek there is a typo in your error if this is written this way ! ^^ mach :)
When is this error present ? I can't reproduce it. Could it be because of your double UIDs cgeek ?

Moul probably hand wrote the sentence. In the code the error is:

Signature from a transaction must match

Anyway, this error occurs when signature is invalid. The range of causes that may lead to this is very large...

Yep, match.
This problem did not appear again.

To be continued...


Upgrading trollop to optimist to remove deprecation warnings

This may break ruby <= 1.8 but I am unable to test this since I don't know how to set up a 1.8 env.
Fixes #267

From my point of view this looks fine, but I would like to get feedback from another reviewer. Thanks for the contribution @chadlyon !

According to optimist website, ruby 1.8 is still OK. I assume we can remove the backwards-incompatible flag.

I tried to test in a 1.8 env and I got other incompatibilities:
Gem::InstallError: rake requires Ruby version >= 2.0.0. An error occurred while installing rake (12.3.1), and Bundler cannot continue. Make sure thatgem install rake -v '12.3.1'` succeeds before bundling.
In Gemfile:
rake
...and then commenting out rake:
Gem::InstallError: ffi requires Ruby version >= 1.9.
An error occurred while installing ffi (1.9.25), and Bundler cannot continue.
Make sure that gem install ffi -v '1.9.25' succeeds before bundling.
In Gemfile:
aruba was resolved to 0.6.2, which depends on
childprocess was resolved to 0.9.0, which depends on
ffi
`
...then I gave up. It seems that the test suite is incompatible with 1.8.

Do we care about ruby 1.8 from Puppet 3? This seems good to merge.

Ruby 1.8 and Puppe 3 are EOL. We don't support it anymore.

When do you guys plan on cutting a release so that I can see these warning finally go away?


Update registration.py (nit pick)

Summary of the Pull Request
You can decline this PR if you want to simply push this change in any of your own commits.
PR Checklist

[nit] Applies to work item: #nit
[X] CLA signed. If not, go over here and sign the CLI.
[_] Tests added/passed

Info on Pull Request
Nit pick
Validation Steps Performed
Looked like this when I deployed with a missing single quote after bbbbbb...

INFO:deploy:retrieving the application registration cos<***>_pool
INFO:deploy:Found existing application objectId 'aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa' - appid 'bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb

You may decline this PR if you want to simply push this change in any of your own commits.


Removed optional tag in front of Numba

Solved issue #1146.
Took into account suggestions from @Yash-10  and @DhruvSondhi

Hey @AlphaVictorDelta, a small piece of advice from my side... Please don't close the PR ... If you push more commits from your local dev environment to GIT, it will automatically update the state of the changes... Squashing & Rebase also needs to be done on the same PR...


fix(tekton): fix sorting for pipeline run durations

Fixes: https://github.com/janus-idp/backstage-plugins/issues/946
Description

Added new logic to use orderById for sorting using duration.

Screens
https://github.com/janus-idp/backstage-plugins/assets/6041994/187ab6a2-2143-469a-bff6-f1335369b015

/cc @jerolimov ^^

Thanks @rohitkrai03 for the PR
Verified the changes
LGTM


Placeholder overflow is hidden now

If the placeholder is very long, the overflow should be hidden and replaced with three dots instead.
Otherwise, a long placeholder will be displayed in two lines.

I signed it!


Setup publishing

This does the work necessary to setup our own internal publishing.
Publishing to our internal Artifactory is done via Azure Dev Ops.

We. expect the repos GitHub things to fail right now. Just our own publish should work. We would have to do more configuration for the sqldelight things to work.
* What went wrong:
[30](https://github.com/autodesk-forks/sqldelight/runs/5219441438?check_suite_focus=true#step:8:30)
A problem occurred configuring project ':sqldelight-gradle-plugin'.
[31](https://github.com/autodesk-forks/sqldelight/runs/5219441438?check_suite_focus=true#step:8:31)
> releaseRepositoryUrl of uploadArchives is required to be set

what's the grammarkit dependency all about? does the plangrid-publish branch need to be specified somewhere?
looks good in general, but I'd love a little bit more info and links (azure job?) if possible. also, I assume this will be squashed and merged so it can be easier to maintain the plangrid-publish branch when merging in with sqldelight upstream?

The azure pipelines are configured to run on prs, so you can follow the links from there.
The grammar kit stuff is updated to match what is on master of sqldelight because it seems that the older version that existed when 1.5.3 was published is not available for some reason.
And yes, I do intend to squash and merge.


Error

Hi my online FTP file manager is showing me:

Your editor is failing to parse the file correctly, or incorrectly considers whatever it understands as an error. Open an issue with them, this doesn't cause any error with SjareXen itself, thank you.

ok

Logs are working:


g8core.client() doesn't raise timeout exception

g8core.client() doesn't raise timeout exception. I waited arround15 mins and there is no response.
Steps:
Try to connect to a fake ip.

still the case .. it hangs for a long time
Version
1.1.0-alpha @Revision: 867d58e68dd938f90f2190c2a48cbf300489f1a0

@john-kheir can you point me to your test regarding this please.


Siad for Windows have some sort af slow memory leak

Hello
Sia demon for windows x64 platform (I am testing on Windows 7 64 bit Pro) have some sort of memory leaks.
Or may be it some sort of aggressive DB caching, but i did not find it in docs. Then please point me where i can read and config it.
But fact is simple: after starting siad on windows it consume only about 200-250 Мб of RAM (with 6 modules: gateway + consensus + transaction pool + wallet + host + renter). But over a time this amount slowly increasing. More client is running without restarts - more memory it use (especially physical memory - working set).
Soon after fresh start ~ 200-250 MB
After 3 days of online work ~ 500 MB
After 1 week ~ 800 MB
After 1 month ~ 1300-1400 MB
Current record (~40 days online 24/7) ~ 1500-1600 MB

And more ...
Win8.1x64 sia-ui 1.3.0 and RAM: 8 GB Memory.
I decided to save 77GB of data ... saved ... waited 24 hours. But siad.exe has a size of 3.9GB. That is, I again have a 4GB computer :).
Is it possible to reduce the appetite of siad.exe or somehow compress it directly in memory?
Is it real to use siad.exe on RAM machines: 2-4 GB of memory?

This is likely due to a bug in the current renter code, which we are in the process of overhauling. @KaiRo-at posted a profile here which suggests that managedDownloadChunkData is responsible.

Interesting. I do not use renting at all - this data is from 100% hosting machine. But renter module was enabled all along, so it still can affect RAM usage. Via maintaining of hostdb for example and regular scans of other hosts.
I will try to restart siad with renter module disabled and check few days later: will abnormal RAM consumption cease or not?
Right now it over 650 MB of RAM after just 2 days online since previous restart.
P.S.
I have noticed what siad also has HUGE virtual size(virtual memory).
This memory not actually allocated("virtual size" is huge but "private bytes" in reasonable range) but i never saw such high values for this parameter - right now it >45 500 Mb (yes, 42.5 GB).
It is a possible reason why sia does not work on win32 platform properly. It simply can not address such crazy memory volumes with 32 bit addressing.

Yeah, the virtual memory is caused by our database (bolt) which mmap's the entire database file. So it will report tons of virtual memory usage, but in reality it will release physical memory to the OS if there's contention.

Update.
Looks like renter module do not cause this issue. And memory leak in renter module is a separate independed issue.
Because I have been running siad with renter module disabled (-M gctwh command line option) for few last days and still see similar behavior. Physical RAM usage have grown from <100 Mb after start and full sync to ~ 1150 Mb range. Or x10 times more in about 4 days.
I take snapshot of memory details after 4 days online: https://drive.google.com/open?id=0Bxy0NGbyM6mdSWRfQ0VwV1lFZEU (screenshot from process explorer)
Most of physical RAM usage grow come from RAM marked as shareable section of working set, but only tiny fraction of it actually shared with other programs (and this amount remain  at about same level ~3-5 MB), while total amount constantly grows.
So may be it some sort of system (windows) dlls being connected and loaded by siad to RAM without releasing it after use? Or file handlers or other sort of system resources.
P.S.
I also noticed that siad creates many thread inside main process. 55 threads right now. Are such quantity actually needed and such number is expected?

I believe this memory leak has gotten worse.  I have to restart my WinServer2016 every two days due to siad consuming 98% of memory and Sia-UI becoming completely broken.  In the UI the hosting section says that the wallet is locked and the wallet screen says it's unlocked and unsynchronized.  At this point you can not even kill the siad process and are required to reboot the server.
I am using Sia-Ui 1.3.1.

@rbj325 can you try just running siad without Sia-UI?

@lukechampine Sure, it's running standalone now.  I will report back in a day or two if the memory usage shoots up again.
Also for reference this server has 24GB of RAM, 30+GB of VRAM and is hosting ~40TB of space on the network.
Let me know if there are any other diagnostic steps I can take to help pinpoint the issue.

The most precise would be a memory profile. If you run siad with --profile=m, it will dump a memory profile to the profiles directory at regular intervals. Then we could inspect two profiles a few hours apart (for example) and try to determine which allocations were leaking.

@lukechampine Running siad standalone does not result in the memory leak after 4 days.  Can I invoke that command line parameter via Sia-UI somehow?

If siad alone isn't leaking memory, it's probably something in the UI, although I suppose it's possible that the UI is making requests to siad in a way that causes siad to leak memory.
If you run siad with --profile=m and then start Sia-UI, Sia-UI will connect to the running siad instead of starting a new process. So you can try that and see if siad leaks.
While you're running that test, might as well try to determine if Sia-UI itself is leaking memory. You should be able to bring up the developer tools by pressing Ctrl+Shift+P in Sia-UI. I believe the dev tools can help diagnose memory leaks; see https://developers.google.com/web/tools/chrome-devtools/memory-problems/#visualize_memory_leaks_with_timeline_recordings

@lukechampine After running Sia-UI for two days, since running siad standalone, I have not been able to reproduce the memory leak.  I don't think anything has changed but I will report back with those results if it pops up again.

Two days later and the leak is back.  I believe it has something to do with hosting using Sia-UI and then having intermittent connection issues.  In the console window there were 100+(and growing) errors pointing to the following locations:
https://github.com/NebulousLabs/Sia-UI/blob/6629b14235e4e3391e335892f8904fba4b1a1085/plugins/Hosting/js/sagas/saga.js#L255
https://github.com/NebulousLabs/Sia-UI/blob/6629b14235e4e3391e335892f8904fba4b1a1085/plugins/Hosting/js/sagas/saga.js#L266
https://github.com/NebulousLabs/Sia-UI/blob/6629b14235e4e3391e335892f8904fba4b1a1085/plugins/Hosting/js/sagas/saga.js#L241
The error message is, "error fetching host status: Error: ESOCKETTIMEDOUT".  I'm not sure if this is a cause or an effect but I will try to reproduce with siad memory profiling enabled.  It seems like the UI is making rapid succession requests to siad until it runs out of memory and then is throttled by that.
Also I'm not sure if this is better suited as a Sia-UI issue or not.

Interesting. A socket timeout would happen if siad is deadlocked or overwhelmed with requests. A deadlock seems unlikely, but you can check by making a manual request to siad with siac host. So my guess is that the UI is sending requests faster than siad can process them.
If that is the case, we should figure out a way to 1) measure the frequency of API requests, and 2) identify the code that's responsible for sending requests too fast. For 1), hopefully the Dev Tools provide some means of seeing which requests are being made. Alternatively, you could probably point Sia-UI at an HTTP proxy that records the requests.

I used the dev tools to take a Heap allocation timeline, not sure if it's helpful at all.  At the time of recording, the UI had reported 650+ exceptions and threw at least 6 while I was recording.  Let me know if you need more time recorded, etc.
Recording the network traffic resulted in no requests being captured so I'll look into the HTTP proxy.
Heap-timeline-20180227T045517.zip

I think the 1.3.2 release fixed the memory leak.  I still see the socket timeout exception but not as often and I can't reproduce the leak after updating.

I'm going to close this, feel free to reopen if it comes back or you can reproduce it again.


:feet: Cancel the option to edit the URL under the OVA details page

Reference: #826
The option to edit the URL field within the OVA provider -> Details page is canceled.
A note was added to the URL field's popup help text.
Screenshot

@RichardHoch can you take a look ?

Change "should be" to "must be" or "needs to be". "Should" can be taken as advice, so we avoid it in technical writing unless is just advice.


Added Icon

Hope you like the icon I made for it!

I see you got a different icon for it. Are you considering using mine as an alternate one, or should I close this PR?

Oh sorry just noticed this PR, I feel like just keeping things as they are right now, thank you anyways.


fix:  runtime-core.esm-bundler.js:2939 Uncaught (in promise) TypeErro…

runtime-core.esm-bundler.js:2939 Uncaught (in promise) TypeError: track(...) is not a function
#8357

It's not a correct fix, see #8360


Cards Missing References

[x] Benzo metabolism
[x] ECG  Right Sided Leads
[ ] Emergency Drug Card - Adult
[ ] Emergency Drug Card - Peds
[ ] End of Shift Feedback
[ ] Pain Management
[x] Pediatric Weight Based Resus
[x] Shoulder Exam
[ ] Ultrasound Measurements

Nonconforming References:
[ ] c3-c7 Fractures
[ ] DVT Ultrasound


createdperceptron_classifier.py

i created just 2 files. 1 perceptron_classifier.py and 2. test_perceptron_classifier.py . number 2 is to test  the  perceptron_classifier.py  using the pytest function/

implementation done already before i made PR


DSD-473: Chakra Accordion

Fixes JIRA ticket DSD-473
This PR does the following:

Uses Chakra components to compose the DS Accordion component.
The only update that is weird is the closing animation for the fixed height scrollable variant. It's difficult to make the panel scrollable since that isn't a feature Chakra provides for its own Accordion component. So trying to build that feature into this was tricky.
Note: It's complicated and we won't get consistent styling if children are passed. So the only way to render a DS Accordion component is to construct the contentData array with objects for each accordion item (label/panel properties).
Note: While this is pointing to PR #640 , this should be merged as Phase 2 of the Chakra integration project. This means that eventually this PR will point to the development branch once PR #640 is merged into development.

How has this been tested?
Locally and storybook.
Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] All new and existing tests passed.

Front End Review:

[ ] View the example in Storybook

Tugboat has finished building the preview for this pull request!
Link:

https://pr681-uvhdjwd3hsxizzt2zhms9jdvlirzyyzj.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6143c692b8fde5f405af97c7

Tugboat has finished building the preview for this pull request!
Link:

https://pr681-uvhdjwd3hsxizzt2zhms9jdvlirzyyzj.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6143c692b8fde5f405af97c7

Tugboat has finished building the preview for this pull request!
Link:

https://pr681-uvhdjwd3hsxizzt2zhms9jdvlirzyyzj.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6143c692b8fde5f405af97c7

Tugboat has finished building the preview for this pull request!
Link:

https://pr681-uvhdjwd3hsxizzt2zhms9jdvlirzyyzj.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6143c692b8fde5f405af97c7

Updated and removed the scrollable feature which is not being used.

Tugboat has finished building the preview for this pull request!
Link:

https://pr681-uvhdjwd3hsxizzt2zhms9jdvlirzyyzj.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6143c692b8fde5f405af97c7


Why is Melown making so many requests on a low altitude map?

Hello,
I am coming back to Melown and comparing it to other 3D viewers and something that I noted is that melown makes about 1000 requests by default for the "Hello World" example:
https://jsfiddle.net/a5rh6vnh/2/
Looking at the Network panel, it looks like Melown loads ALL the tile pyramid from Z0 to initial zoom. So it requesting all the antarctica tiles (imagery and terrain) for some reasons that I can't understand
I noticed that Cesium and iTowns have the same behaviour, so there must be a technical reason behind this I guess ....
Can you give me an explanation as to why it doesn't just load the necessary levels?
Thanks,
Fabien

Hello Fabien,
you are right. In the default load mode vts-browser loads  all the tile pyramid from Z0 to initial zoom. Reason why industry uses this approach is that this way you always have something loaded no mater where you move, jump, fly, ... from initial position, so something is always visible and you don't loose context. Drawback of this solution is that you load more tiles that is needed for displaying specific position in the map.
Good news is that vts-browser also supports different load mode.  All you need to do is set following browser option:
mapLoadMode: "fit"
This mode loads only tiles which are needed. In places where tiles are not yet loaded is displayed grid. You ca try it in following example:
https://jsfiddle.net/ufzpe6jm/

Thanks a lot for your answer, that's exactly the setting I needed, the map loads really fast that way and zooming out/panning still loads the necessary tiles on demand, amazing :)


moved from redhat-developer/odo to openshift/odo

replaces redhat-developer/odo reference with openshift/odo
fix and add tests. Integrations tests and e2e scenario is run with the new images

/refresh

/lgtm

/refresh


VerifyError caused by invokeinterface with long/double parameters

The following example code throws a VerifyError that I don't think is my fault:
public class Main {
    public interface Foo {
        double bar(DoubleBinaryOperator op);
    }

    public static void main(String[] args) throws Exception {
        var c = ClassMaker.begin().implement(Foo.class);
        var m = c.addMethod(double.class, "bar", DoubleBinaryOperator.class);
        m.return_(m.param(0).invoke("applyAsDouble", 2.0, 4.5));
        System.out.println(((Foo) c.finish().getConstructor().newInstance()).bar(Double::sum));
    }
}

The error message is
Exception in thread "main" java.lang.VerifyError: Inconsistent args count operand in invokeinterface
Exception Details:
  Location:
    org/cojen/maker/ClassMaker-3.bar(Ljava/util/function/DoubleBinaryOperator;)D @7: invokeinterface
  Reason:
    Error exists in the bytecode
  Bytecode:
    0000000: 2b14 0010 1400 12b9 000c 0400 af

The bytecode in question is
 0: aload_1
 1: ldc2_w        #16         // double 2.0d
 4: ldc2_w        #18         // double 4.5d
 7: invokeinterface #12,  4   // InterfaceMethod java/util/function/DoubleBinaryOperator.applyAsDouble:(DD)D
12: dreturn

And indeed we see that the invokeinterface claims to use 4 stack elements, but requires 5.
I think the cause may be at https://github.com/cojen/Maker/blob/e8d62f313be55637354b3e0ad69ae807c4d67fb6/src/main/java/org/cojen/maker/TheMethodMaker.java#L754
It looks as though this array doesn't contain the receiver type, so it probably shouldn't be skipping the first parameter?

Thanks for the report and initial investigation. I'll take a look at this further.

Let me know if this fix works for you: https://github.com/cojen/Maker/commit/53be6ff83e942046cf6511e652f71831d0343a83

Yes, that works perfectly, thank you!
This is a beautiful library btw. I've tried a bunch of code generation libraries over the years and all the others felt like more trouble than they were worth, but this one gets it right -- thank you for writing it :)


Crash

Describe the problem
TMPE Labs crashed
Steps to reproduce
Installed Mod MOM

deinstall MOM -> it works fine
install MOM -> chance Labs into Stabel   up Now, no Errors seen

output_log.txt
TMPE.log
Savegame?

Screenshots?

Notes or questions?

It seems you are not reading mod descriptions...
Why do you have two versions of the mod subscribed??
If you want to change version you have to close game first then use Steam client to unsubscribe one and then subscribe to the other. If you do that while game is running you are calling for troubles.
Log contains a lot errors unrelated to TM:PE but worth fixing.
Use Mod Compatibility Checker to find issues with mod you subscribe and follow mod description to solve problems

First I `ve  installed the Labs Version and all will be fine. After I installed MOM i have trouble .
Then I Reabo the Lab and get the Stable Version, no mistakes appears .
I can't detect duplicate mods in the log file, possibly by swapping labs for stable?
Subscribed is now only then Stable Version
also the recommented Files for TM:PE where installed.
It may be possible that i not exit to Desktop only to Main Menue , i try to make it better.

The problem is if you changing versions when game is running you will end up with all versions loaded to memory. Unsubscribed mod is not unloaded from memory so we recommend closing game before switching versions


Enhancements/Code Refactoring

Hi, This is Sujal. I came across your organization through one of the answers in StackOverflow that were written by a developer working @puppet. I researched about the company and to my utter surprise I got to know, the company has a lot of reops open sourced. Not only that, but further to my surprise the major techstacks were Ruby and Golang, the stacks that I spend at least 18 hours of my day with. 😅
Got through the code, and have made a few changes, will be adding a few more, please review, it, and we can discuss them further on the thread regarding the implementations.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello! Thank you for this PR.
It's very welcome!
You've actually come across a utility that is used internally by my team.
We will review it shortly!

Hello! Thank you for this PR.
It's very welcome!
You've actually come across a utility that is used internally by my team.
We will review it shortly!

Sure, it has a few changes suggested that requires removal of certain codes, while addition of few new.


update dependencies

it's been a while, do it.
$ npm outdated
Package        Current  Wanted  Latest  Location
app-root-path    2.2.1   2.2.1   3.0.0  uctech-greeter
botkit           0.5.8   0.5.8   4.6.2  uctech-greeter
dotenv           4.0.0   4.0.0   8.2.0  uctech-greeter
eslint          4.19.1  4.19.1   6.8.0  uctech-greeter

botkit to 4.6.2 is a significant change but botkit to 0.7.4 still silences a lot of npm audit warnings (not all of them) and also supplies a helpful warning message at startup that we'll have to address before updating to 4.x.x. So, as an incremental step in the right direction: https://github.com/ucsf-ckm/uctech-greeter/pull/21
I also enabled dependabot for this repo.

superseded  by #21


Publish to https://open-vsx.org/

Is your feature request related to a problem? Please describe.
Contextive is published to the VSCode Marketplace, but that is not available to users of Code - OSS or VsCodium which by default looks for extensions in https://open-vsx.org/
Describe the solution you'd like
Contextive to be available at https://open-vsx.org/

:tada: This issue has been resolved in version 1.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Can't create DataFrame from SQLite3 cursor

When I pass cursor as data to DataFrame constructor an error occurs.
cursor = sqlite.execute(sql)
pd.DataFrame(cursor)

/usr/lib/python3/dist-packages/pandas/core/frame.py in __init__(self, data, index, columns, dtype, copy)
    255                                          copy=copy)
    256         elif isinstance(data, collections.Iterator):
--> 257             raise TypeError("data argument can't be an iterator")
    258         else:
    259             try:

TypeError: data argument can't be an iterator

But normal generators is accepted
def gen():
    yield (1,2,3)
    yield (4,5,6)
    yield (7,8,9)

pd.DataFrame(gen())
Out[171]:
   0  1  2
0  1  2  3
1  4  5  6
2  7  8  9

It feels like inconsistence.

what is type(cursor).__mro__

type(cursor).__mro__
(sqlite3.Cursor, object)

It's not a big issue: passing cursor to list constructor results normal list wich is accepted by DataFrame.
I just can't understand why iterable is not acepted.
Type checking is a bad practice in Python, isn't it?
Why just not to check ability to iterate?
hasattr([], "__iter__")

type checking in python is fine. In pandas is actually quite a bit more complicated, because we need to determine, if, for example a list of-lists or list-of scalars are passed, then this is problematic
so an Iterable must have __iter__ AND __len__. A cursor doesn't have this property, while for example range(5) does. (I know that in theory rowcount works for his, but I don't think this is a guaranteed property). So a Cursor should act much like a GeneratorType (and not an Iterator).

I just create a generator with not defined length. And DataFrame accepts it as I expect.
I think we should turn off type check. Anyway user may construct infinity generator and pass type checking.
In [20]: def g():
   ....:     for i in range(5):
   ....:         yield [i, i ** 2, i ** 3]
   ....:

In [21]: DataFrame(g())
Out[21]:
   0   1   2
0  0   0   0
1  1   1   1
2  2   4   8
3  3   9  27
4  4  16  64

a generator is fine. you have an iterator. you can certainly make any changes you would like. but they would need to pass the test suite as is.

Hmmm. I'll see how to overcome it.

@jreback Out of curiosity, why is a generator fine, but not an iterator? It looks like DataFrame's constructor checks to see if the data argument is a GeneratorType and then wraps it (data = list(data)), but if it's an iterator it raises an exception.

see my comment above
and iterator is not sufficient as its not required to have a len
this is an old issue - so don't really remember
have a look at the test code for Frame construction

Generator is also not required to have a len. The solution for generators in the DataFrame constructor is to consume it into a list() and from there treat it as though a list was passed as the data arg. The same should work for iters. If you're worried about infinite iterators, then you should be equally worried about infinite generators, unless I'm misunderstanding something. I'll take a look at the tests.

Duplicate of https://github.com/pandas-dev/pandas/issues/2193
I also think it'll be possible to turn the iterable into a list, just like with a generator.


Code needs to be cleaned up more

Honestly our code is pretty good at this point, but it could always be better. We need to:

[x] Clean up constants.py
[ ] Add comments to the tests (oh boy)
[ ] Do another go at changing var names and function names to be clearer and convey more info
[ ] Flesh out scripts/ a little more, maybe add a nicer UI for them or something
[ ] Expand the readme, maybe add a little more documentation/guidance where to start for new members

Duplicate of #38

Duplicate of #38

so real

Flesh out scripts/ a little more, maybe add a nicer UI for them or something

This can probably be done along with/after #106.


imgpkg panic when a retry happens

What steps did you take:
When imgpkg is copying images to the registry and loses access to the server the retry will panic.
An example can be found in: https://kubernetes.slack.com/archives/CH8KCCKA5/p1622737728282300
What happened:
imgpkg panics because go-containerregistry closes the channel
What did you expect:
On the second retry, it should provide work if the network connection was reestablished.
Environment:

imgpkg version (use imgpkg --version): 0.8.0
Docker registry used (e.g. Docker HUB): any
OS (e.g. from /etc/os-release): any

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help to work on this issue.

@DennisDenuto it might be good to fix up go-containerregistry to follow following channel pattern - whoever creates channel is responsible for closing it. currently caller creates channel, but MutliWrite closes it making it impossible to reuse the channel against multiple calls (in our use case when we wrap MultiWrite in a retry logic)

@cppforlife That's a good idea. I'll create an issue in go-containerregistry. Might even volunteer to submit a PR on my dev day.

Merged: https://github.com/google/go-containerregistry/pull/1041
The retry logic (and the channel multiplexing logic) can be removed the next ggcr bump.
Blocked until ggcr (v0.5.1) releases a newer version with merged PR

initial fix is in https://github.com/vmware-tanzu/carvel-imgpkg/releases/tag/v0.9.0

we are waiting for version 0.6.0 of ggcr or higher to be able to fully solve this issue

v0.6.0 has been cut! Just a heads up, the folks from ggcr were super responsive!


Add git support for uploadpack.allowReachableSHA1InWant

Adds support to chef-client git HWRP to utilize the new feature were possible.
Notes
This PR, requires PR 4471, https://github.com/chef/chef/pull/4771 to be merged first.
Background
Introduced in git 2.5 // uploadpack.allowReachableSHA1InWant
https://github.com/git/git/blob/v2.5.0/Documentation/config.txt#L2570

I'm seeing some functional test breakage and will investigate.  Thanks!

The failures resemble this:
NoMethodError:
       deploy_revision[deploy-revision-unit-test] (dynamically defined) had an error: NoMethodError: undefined method `uploadpack_allow_reachable_sha1_in_want' for Chef::Resource::DeployRevision

Running this functional test locally successes:
bundle exec rspec ./spec/functional/resource/deploy_revision_spec.rb
Can anyone provide guidance on this failure?
Thanks!

Any update on this?
Thanks!

the deploy and git resources are tightly coupled and the API for the deploy resource is a superset of the git (or scm) resources.
its all mildly horrible and very old code.
you probably need to update Chef::Resource::Deploy with this property as well.

We've had enough changes around the pre-req PRs that I'll be resubmitting this.  Thanks everyone!


PHP 5.2 compatible ternary operator

PHP 5.3 added ex1 ?: ex2 as shorthand for ex1 ? ex1 : ex2.  Use the long form for backwards compatibility.

Jim - Nice catch. Thanks for the patch! :)


Showcase does not register information sent over

Description of problem
Information sent successfully but showcase does not register information.
Expected behavior
After sharing information. The showcase should acknowledge the information sent over and allow the user to move forward.
Steps to reproduce

Open the prod showcase : https://digital.gov.bc.ca/digital-trust/showcase/uc/store
attempt the student showcase
use credentials and get a student discount

Screenshots and/or log output
Environment

[X] Occurs on Android
[ ] Occurs on iOS

Build #: 1087
Android Device Model:
iOS Device Model: iPhone SE
Workaround
Severity

[ ] High
[X] Medium
[ ] Low

@knguyenBC I can reproduce this in v1.0.9 and v1.0.10 if I have a credential issued from a different showcase instance. For example, if I have Student Card from test (displays as brown color) and I have one form prod (displays as green color) and I respond to a production proof, the wallet will use the first credential issued, in my case brown, and the issue above surfaces.
The showcase URL above is for prod. Please delete any other credentials from different Showcase environments. You should only have the (green) credential with branding.

Odd. I thought the wallet automatically selects the latest issued credential. Not the oldest issued credential. Might be a different bug then. Either way, tested the prod showcase with 1.0.10. works fine.


background blur in kitti 0003 data

Hi, mars team, I train a nerf model using 0003 scene for 30~90 frames. I didn't use depth, carnerf weight and semantic mask in the training. The maximum iterations are 50000.
I found the scene that ego car is moving is usual blur as the figure 1.

And I also found the dynamic object close to ego car usunaly has a ghost shadow as the following figure.

The training logs are following:

Could you explain these cases?  I met the same problem in my private data.
Thank you in advance.

Hi! @szhang963
While the ego car is moving, maybe using depth will help with the performance. It seems that there are many shadowed areas in this scene, which will also affect the training performance.
Perhaps a longer sequence could help with decoupling the object from the background.

Thanks for your reply. A longer sequence means a larger memory, could you share a solution for saving the memory? Thank you very much.

Hi! @szhang963
Maybe you can refer to #85.

Hi, @xBeho1der
I follow the process of generating the depth map using monocular depth estimation model. However, the result is poorer than the depth map you provided, like these (my, your, and image):

Could you provide some causes to resolve this? Thank you in advance.

Hi! @szhang963
Try modifying the resize part?

Hi @xBeho1der. Yes, I have fixed it. However, the rendered RGB images are still blurred using the depth loss when the ego car is moving (e.g. 006, 190-249).

Could you provide a training result for the scene?


Adding rspec

fixes #13
1 - rspec added
 basic `rspec` coverage added with model, request , lib and routing specs

2 - issue fixed in app/views/application_mailer/new_gem_admin_notification.html.erb ti support new columns
  Mailer template was using old columns.

3 - ILIKE changed to lower, because its supported by both Sqlite and Postgres
  having `ILIKE` is not working for tests as sqlite doesnt support the syntax. now both the user inout and column value will change to lowercase to match.

@sameera207 awesome, thanks! I've left a comment in the Gemfile.
Would be great if you can address it, and the rebase your work against the master branch to resolve the conflicts (I've just made a few changes before seeing your pull request) and squash your commits into a single one.
See http://makandracards.com/makandra/36003-recommended-git-workflow-for-feature-branches if you never did that. If you can't do it no problem, let me know and I would take care of that.
Thanks again!

@Florent2 , no worries, I'll address the comments and I'll have a look at the link and send u a new PR. :)

Hey @Florent2 , I addressed your comments, but still seems like there are some merge conflicts. I might be doing something wrong. could u pls have a look :)

@sameera207 I've merged your branch into master and fixed the conflict. Thanks for your contribution!


Updates adal4j dependency

Updates adal4j dependency now that it has been released.

/azp run java - storage - tests


Single resolution registration

I have a registration problem in which I need to do a simple rigid transform of images primarily composed of thousands of small particles. Where there is some underlying low-frequency structure, simpleElastix works well, however fail with just particles.
I am assuming this is because I am using the default MultiResolutionRegistration which is initially ignoring the high frequency information. I expect I would have better luck by starting with a single resolution registration at the highest resolution possible. However, I can't find anything in the documentation about this or any alternatives to MultiResolutionRegistration.

Unless you have a high degree of overlap in the particles, or you can make them 'fuzzy' enough to overlap using the multi-resolution approach, this type of image may not register well with an image-based approach such as SimpleElastix.
For point-based rigid registration, the classic approach is iterative closest points, which is implemented in ITK. If the particles can be easily segmented in the image (e.g., if you can simply threshold the image to identify the particle locations), you might be better off using such a method. Here is an example. I'm not sure if this is implemented in SimpleITK or not, though.

@rdg-clearbridge Note that if you set the number of resolutions to 1 ElastiX will register your images in full resolution, which in your case may work. And maybe changing the metric to cross-correlation (AdvancedNormalizedCorrelationMetric) may help if the pattern is very similar from an image to another.
I encountered one case were ElastiX was less appropriate that a basic cross-correlation, which you can test very quickly using scikit-image register_translation.
Another solution would be to extract some particles coordinates from your images (convert image to binary, analyse particles and get central coordinates for each) and register the points sets with ElastiX. But it may be tricky to automate depending on your images.


PostgrestErrors not reported correctly

Bug report
Describe the bug
I noticed that I never see the actual error that Postgrest returns, but instead get a generic statusCode: 400 error. I had to set breakpoints and print the response to see what was actually wrong.
After some digging through the code, I noticed that the problem is that the validateResponse delegate method from APIClientDelegate is never called on PostgrestAPIClientDelegate. This is because the supabase-swift package adds its own delegate, resulting in a MultiAPIClientDelegate being set.
So far so good, but since supbase-swift does not implement validateResponse the default implementation from the Get package gets called, which throws this generic error and the custom implementation from PostgrestAPIClientDelegate never gets called.
The easy way to fix this, is to give PostgrestAPIClientDelegate precedence to whatever delegate is passed to PostgrestClient.init, but I could imagine this having other unforeseen consequences.
The change would simply be to change the line 32 in PostgrestClient.swift from this:
$0.delegate = MultiAPIClientDelegate([customDelegate, PostgrestAPIClientDelegate()])
to this:
$0.delegate = MultiAPIClientDelegate([PostgrestAPIClientDelegate(), customDelegate])
Alternatively, the SupabaseClient could implement the validateResponse method and just not do any validation.
What do you think? I'm happy to submit a PR, but don't feel either approach is perfect.

Hey @leoMehlig thanks for opening this.
I'm currently working on the removal of the Get library as a dependency on https://github.com/supabase-community/postgrest-swift/pull/43, this issue will be fixed.


Add options for advancing in a non-linear way

I would love to be able to create a choose your own adventure style comic/game with panels. I imagine there could be two different types of controls. A dialog chooser - A or B - and a spatial navigation - up, down, left, or right on the D-pad.
Dialog: this could work like being able to say that the A button advances to the next sequence but that the B button goes to a different, specified sequence.
Spatial: another possibility might be using the four directions of the D-pad where the default direction advances to the next sequence like normal but you could define up, down, and left to go to different, named sequences.

I think that the easiest way to create an implementation with the current codebase would be to extend the advanceControl to take in more than one option with a scene number for each option. The choice explanation can be handled in content.

@tgb20 Yeah, that sounds like a good way to do it. The rest of the code assumes a linear progression, so I'll have to unwind some of those bits first. I probably have time to look at this in the next couple of weeks.

I made some changes to enable this on the nonlinear-story branch.
There are some simple examples in this example project that show how it works. But basically, you can define multiple options in a sequence's advanceControls table. Those controls can target any sequence in your comic.
As mentioned above, it's mostly up to you to define how the controls are presented and explained. But I did include a few different examples for how you could do that, including a directional D-pad one, which could be pretty fun.
If y'all have some time to check this out I'd appreciate any feedback. Otherwise I'll work on the documentation and then merge into main in the next week or so.

Thanks @cadin! I'm working through your tutorial now. I'll let you know how it goes.

I merged this change into main.
There's a dedicated page in the docs that explains how this should work:
Creating Comics with Branching Storylines
Let me know if you run into problems. I'm closing this, but you can reopen or just comment here if you have feedback.
Thanks!


Arbitrum: bump contracts to v1.0.0rc4 and remove incompatible deployments

Fixes #
Short description
Title
Definition of Done

[x] Steps to manually test the change have been documented
[x] Acceptance criteria are met
[ ] Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

@weilbith in TS, there's 2 ways to import a JSON:

importing at compile time (import _ from 'file.json';) embeds it in bundled outputs, avoiding the requirement for the files to be available at the correct paths at runtime; downside is that we need to be explicit about which files to import, and they always need to be available at compile time (so we have to drop the non-available networks here)
using something like fs.readFile* to read and parse the JSON at runtime; can support dynamic files, but make static embedding harder (e.g. bundled builds).

But either way, I already support both solutions here: I try to keep static imports for known networks (in this branch, only arbitrum-rinkeby), to allow the embedding, but fallback to fs.readFile and throw only if deployment files for the current network aren't found in the expected paths. This should allow even dropping the files for custom/private networks after build and they'll be picked, as an additional feature over passing them explicitly when instantiating the SDK or relying only on --user-deposit-contract-address discovery (slower on first launch).

The default case doesn't work for build:bundle case, and may create problems on webpack and other web-bundle solutions (if they don't make the JSONs in deployment folder properly available e.g. on a webserver), that's the reason we keep it for the known networks. Let's keep it like that and assess if any problems arise. It's not that much code, and checked at compile-time.


Title on mouse over

Add new oprion: showTitle: true
New option to get the name of social on Mouse Over.

Add new oprion: showTitle: true
New option to get the name of social on Mouse Over.


Persistence Error Injection Client

What changed?
Add an error injection client for persistence layer

Why?
Injection random persistence error during bench test to expose potential error handling bugs.

How did you test it?
Tested locally using canary with 0.001 error rate

Potential risks
No risk. Error injection client won't be created if error rate is 0 on service start up.

Coverage decreased (-0.6%) to 59.41% when pulling 6d72f773efe86d23cd93b1f5b8793de179a95bc4 on yycptt:persistence-error-injection into 995c4dc0d48962ee1c57e5795300286568ecd679 on uber:master.


Update scission.d.ts

Fix this return result.

Technically scission does not support Geom2 so that first line could actually be deleted...

@FishOrBear technically, this is correct, however scission of geom2 is not performed, only the original geom2 objects are returned. Is that ok?
of course, if you submit the code for geom2 scission then we would be really happy.

@z3dev ok, I have updated the code


dotnet new ... hangs up for a minute after completing local work

I've notices this with dotnet new console and dotnet new sln: after all local files appear to have been created, dotnet.exe hangs about for a while before exiting -- a minute or more. Here's a screenshot of Process Explorer process details from the last time I ran dotnet new sln:

Of concern is the amount of network traffic for creating a single, small, .sln file -- dotnet received over a mb of data... for what?
For reference, I have set $env:DOTNET_CLI_TELEMETRY_OPTOUT=1 before this last run, so one would hope that there's nothing telemetry-related in there (and even if there were, it wouldn't explain a mb of download during .sln creation).
When I created a new console project, the same kind of hang-up occurred, with the dotnet process sitting there for a while after claiming to have completed package restore. So, what gives? These operations used to be lightening fast, though admittedly the last time I did a dotnet new ... was a while a go (read: months)
Operating system: windows 10 (version 2004) x64
dotnet version: 3.1.302

I'm experiencing the exact same issue since a few days.

Maybe related to https://github.com/dotnet/templating/pull/2341 ?

This repo is no longer actively monitored. Closing up old issues that have not had activity in while. If this is still an issue, please open a new issue in an appropriate repo listed in microsoft/dotnet#1275

This repo is no longer actively monitored. Closing up old issues that have not had activity in while. If this is still an issue, please open a new issue in an appropriate repo listed in microsoft/dotnet#1275


SonarCloud quality gate should pass.

Is this already assigned to someone? otherwise I could take a look on it

I've done a few things already in the teams branch. However many still need to be fixed, especially in the UI.

then i'll take a look at the ui

Code coverage for Java code and lots of code smells have been fixed in #380.


GPT 3.5 for CompleteText

Hey Guys,
maybe I"m overseeing something but how can I make a simple prompt like in the Thai translation example but with GPT3.5 or 4? The function is only supporting davinci models as far as I can see. The ChatComplete functions I'm having a hard time figuring how to make a simple prompt.
thx!!

@ฮันเชา2407 you have example code for this issue?

@hanchao2407 You Have Error


Reorder calendar fields to match rfc5545

Reorder calendar fields to match rfc5545, which changes the expected output serialization order.

Codecov Report

Merging #35 (07615da) into main (d151f65) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   95.90%   95.90%
=======================================
  Files           8        8
  Lines         708      708
=======================================
  Hits          679      679
  Misses         29       29

Impacted Files
Coverage Δ

ical/calendar.py
100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Last image stuck in detection loop

When testing darknet_ros with recorded rosbags, we encounter the following problem:

Running darknet rosnode is fine, the net will be initialized and then the message "Waiting for image" will be printed.
As soon as I run the rosbag, darknet receives the image and does the inference and publishes the messages as it should
When I stop the rosbag, than darknet will always run the net on the last received image in loop.
There will be no message like "Waiting for image" since the while-block will be not left, unless the rosnode is closed - which is not.

This beaviour is very bad. We use several cameras but it can happen that at some time no camera is recording, so darknet would do inference on the last image. Thus, it will alway publish the same bounding boxes until new images arrive.
Did anyone else encounter this problem? How can you fix the node, so that if no new image arrives, darknet just prints "Waiting for image" and only waits?
Thx.

I am also encountering this problem. I am about to look into it, but it seems as if darknet is constantly grabbing the last received image.

Is there any progress towards solving this problem.  I have found various posts which all point towards darknet running at full speed even when the image has not been updated.  I found that the bounding boxes message is received repeatedly with the same frame_id, in the image header, and identical bounding boxes.  This is wasting a lot of GPU. Could darknet store the frame id and not run the NN until a new frame is received ?

I have made a fix which seems to solve the problem, but I still have not worked out how to publish it through Github.

can you share your repository?
I am facing same issue

can you share your repository?
I am facing same issue

I have made a fix which seems to solve the problem, but I still have not worked out how to publish it through Github.
Can you share your repo?
I am facing the same issue
@elpidiovaldez please..

I have made a fix which seems to solve the problem, but I still have not worked out how to publish it through Github.
Can you share your repo?
I am facing the same issue
@elpidiovaldez please..


[azure-storage-blob] wrong sas permission string caused authentication failure

Package Name: azure-stroage-blob
Package Version:  12.4.0b1
Operating System: Win 10
Python Version: 3.7.7

Describe the bug
A clear and concise description of what the bug is.
When specify permission with string, it passes the permission string to _str as shown here:
https://github.com/Azure/azure-sdk-for-python/blob/1216acf1caa13575d3b8cfa0b401e42eefa9f17f/sdk/storage/azure-storage-blob/azure/storage/blob/_models.py#L930
but what we expect is that it should be format with the following method:
https://github.com/Azure/azure-sdk-for-python/blob/1216acf1caa13575d3b8cfa0b401e42eefa9f17f/sdk/storage/azure-storage-blob/azure/storage/blob/_models.py#L899-L904
If the permission string sequence changes, it will cause signed signature change and authentication failure.
Removing  this line could fix it.
https://github.com/Azure/azure-sdk-for-python/blob/1216acf1caa13575d3b8cfa0b401e42eefa9f17f/sdk/storage/azure-storage-blob/azure/storage/blob/_models.py#L930
Same for other sas permissions.
To Reproduce
Steps to reproduce the behavior:

generate sas token with specifying container sas permission with string like 'dlrw'
upload blob with generated sas

but if you are using rwdl, it will work.
Expected behavior
A clear and concise description of what you expected to happen.
Authentication failed.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

This will be addressed in the pr, thanks for catching this!

Hi @Juliehzl, the PR related to this issue has been merged. I will proceed to close this issue. Let us know if anything else comes up!


Improve design on gamification module in header BO

Linked to this ticket: http://forge.prestashop.com/browse/FF-169
Linked to this PR: https://github.com/PrestaShop/PrestaShop/pull/8914

@sLorenzini
On legacy page, I don't see the trophy icon. And when I click on the notification, the window is opened but not under

On symfony page, I don't see the trophy icon either

It's ok, my bad :)

Hi, just to mentioned that the module just upgraded in my shop and the icon is not visible either, will this be updated? Thanks!

Hi @AAraKKe, sorry about that!
This PR should fix the problem #20

For the record, this bug happens only on versions lower than <IP_ADDRESS>.


Brackets shouldn't launch with the debugging enabled for the same port twice and incorrect infobar shown on second launch.

1.Launch Brackets 1.14.1  from the terminal/Cmd line with the port number.
2. Again launch Brackets 1.14.1  from the terminal/Cmd line with the same port number.
Expected: Brackets shouldn't launch with the remote debugging enabled for the same port number for which the Brackets was launched first.
Actual behavior: Brackets launches with the debugging enabled for the same port number and incorrect info bar displayed.
Brackets  1.14.1-17752
Platforms: Win /Mac  /Ubuntu

@yprasad1 @narayani28 @jha-g

Scenario 2:
Same behavior is encountered if a port is blocked and trying to launch Brackets with remote debugging enabled with the blocked port.
Steps:

Block port 1234 by executing the below command:
(sudo pfctl -sr 2>/dev/null; echo "block drop quick on lo0 proto tcp from any to any port = 1234") | sudo pfctl -e -f - 2>/dev/null

Launch Brackets with remote debugging enabled on port 1234.

Expected behavior : Brackets shouldn't notify that remote debugging is enabled for the blocked port.
Actual behavior: Brackets launches with incorrect info bar displayed.
Note: http://localhost:1234 does not load the content in the browser


⚠ Bofrost.lu has degraded performance

In afa2ca9, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1706 ms

Resolved: Bofrost.lu performance has improved in 60f6698 after 6 minutes.


update the autonag script

Coverage remained the same at 45.287% when pulling 9a4adfc0300dc6c12c22c8118fbfd56790bf3eb7 on sylvestre:master into 09710893d4b2ebf96a6b9462d48e82b7e64e5b44 on mozilla:master.


Support ssh auth with private key file to enable to deploy pai to AWS…

… EC2 (#1295)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: liudongqing sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Coverage increased (+0.4%) to 51.851% when pulling 6c22e4103064b1707b0d6d1e9b25a97332078d04 on liudongqing:feature/sshkeyfile into 4a521c9ffee4ac62d375c280f06f9b092af6bf24 on Microsoft:master.

@hao1939

Hi @liudongqing ,
Noticed your PR is out-of-data with the base branch, could you rebase on the master branch?

We'd better add the logic for user to choose.
They can choose password or key_filename to set. And they must set one of them. For another one, it's optional.
And in current code base, the password is the necessary field. And the key_filename is optional. I think we can make it more flexible

Hi @liudongqing ,
Your PR can't pass CI build, it's because that CI scripts make some config change hardcoded.
Could you make it to work with your PR?
Here's code change needed:
https://github.com/Microsoft/pai/blob/a59f05fe32934dd1164c26caafc0676f0763b692/Jenkinsfile#L82
https://github.com/Microsoft/pai/blob/a59f05fe32934dd1164c26caafc0676f0763b692/Jenkinsfile#L172
https://github.com/Microsoft/pai/blob/a59f05fe32934dd1164c26caafc0676f0763b692/Jenkinsfile#L276

@hao1939 rebased. And removed the added line from cluster-configuration.yaml to pass CI. As ssh-keyfile-path is an optional configuration, I think it is OK for its absence in quick-start-example.yaml

Hi @liudongqing ,
Yeah, agree with you, ssh-keyfile-path could be optional.
Now, the   ./paictl.py config generate is broken, could you fix it?
+ ./paictl.py config generate -i /var/lib/jenkins/bed1/singlebox/quick-start/quick-start.yaml -o /var/lib/jenkins/bed1/singlebox/cluster-configuration
Traceback (most recent call last):
  File "./paictl.py", line 639, in <module>
    main(sys.argv[1:])
  File "./paictl.py", line 634, in main
    args.handler(args)
  File "./paictl.py", line 603, in generate_configuration
    args.force)
  File "/mnt/jenkins/workspace/pai_PR-1308-U3ZJB3VWLXGSM2FZ6D3H7KOYIUH6QB3RAS3JQPEYATIFBYYP26NA/pai-management/paiLibrary/paiCluster/cluster_util.py", line 80, in generate_configuration
    "key-filename": quick_start_config["ssh-keyfile-path"],
KeyError: 'ssh-keyfile-path'
script returned exit code 1

Hi @liudongqing , The PR has already passed the CI.

We are planning to freeze master code change in several days to do large code structure change. To minimize impact on this PR, we decided to merge this PR and resolve possible conflict internally.