Start of work for floating point precision for the x-axis, Issue 194

The purpose of this pull request is to open a place for conversation about work I've started to resolve Issue #194 .  This is a work in progress.  My goal is to have the work pulled into mainline when it is ready.  On my fork I've started a Wiki page to give an idea of my current understanding of the problem and roadmap for my work.
https://github.com/StephanieB5/ios-charts-xTime/wiki/ios-charts-xTime:-support-of-floating-point-and-date-x-axis-values
@RyGuyM, @liuxuan30 have been great to offer support and mentioned interest in a conversation.  I feel code is greatly improved by review and feedback so please let me know what you think.
Thanks!

Let's get the fork up to date with the current version. I took a quick stab at Scatter Charts on my local branch yesterday and made good progress on a scaled value rendering but where things start to break down are the labels and grids.

I've got the fork up to date.  Would you like to work together to get this feature rolled out?  I'm always open to ideas. :)

@danielgindi since it's a big move, shall we use another branch for it?

Of course- this kind of stuff should be thoroughly tested before going into master... Feel free to create a branch

Btw, just a hint - it's possible that all you need is actually an extension for the XAxis, not a whole chart-view. Otherwise you would have to create time versions of almost all charts.
Just try to generify it.

Thanks @liuxuan30 and @danielgindi!  A branch would be great.  It's in a branch on my side too. :)  A generalized XAxis should hopefully take care of labelling issues.  However, I believe the changes will spread beyond that though. For example functions like BarLineChartViewBase::lowestVisibleXIndex will need to be changed.
That being said, in the end I'm hoping that the changes end up being small enough that classes like BarLineChartViewBase can be safely changed.  I've just isolated things into separate classes for now.

I'm doing some work on the lowestVisibleXIndex right now which doesn't work in a value scheme. In the index scheme order is based on index so we can always assume index[0] will appear before index[1] but in the value scheme index[0] might have a value of 10 and index[1] might be -5 so we need to filter or renderings based on position instead.
I agree with @danielgindi that an extension for XAxis for time values could useful. I haven't looked at times yet though, just numerical based scaling.

If you use time as represented in seconds from a reference date, such as NSTimeInterval, then hopefully getting date representation from values should just be a matter of formatting the labels. The XAxis has space for a ValueFormatter, it just needs to be generalized to support customs formatting.
I suspect the data points will need to be ordered by xNumericVal before rendering.  For example in line chart rendering you to know which point is next to which according to their place on the x-axis.
@RyGuyM it appears that we're working in the exact same area of the code.

I have created a branch floatXAxis from master. You can merge it there. Keep the code style :)

Thanks!
Sorry about the scattered commits.  On my end, I like to do fine grain commits to retrace steps in case bugs appear.  I'll squash those together to make it easier to see the changes overall.  I appreciate the feedback. :)
Once things are squashed I'll open a new pull request (into floatXAxis this time).

Closing this pull request in preparation for pull request into floatXAxis branch.


Add fv test chaincode deploy logging

Previously if chaincode deploy failed during fvt tests no message was logged making it impossible to troubleshoot. Now the chaincode deploy commands and results and logged.
Signed-off-by: David Enyeart<EMAIL_ADDRESS>

@mbwhite @jt-nti This logging helped me to resolve the fabric-test interop tests, but I think I've introduced an unresolved promise because it now times out the test after successfully logging the response. I'm a node.js newbie, what is the proper way to add the logging?

@denyeart it looks like you're trying to use a callback when exec has been promisified - something like this might work instead...
https://github.com/hyperledger/fabric-chaincode-node/blob/9b800780c5d47a0f4e5f5b7254cb947ae838314b/tools/toolchain/test/devmode.js#L27

@jt-nti Thanks, I think I've got it now!


onEnter called twice 3.0.0

I've got 2 <Route /> (a, b) with async onEnter hooks, they are called twice when i click on <Link /> (in stack trace first run is caused by handleClick, second by handleHashChange)
3.0.0
Expected Behavior
onEnter called once

Dupe of #3220.


Make easy use a different selector

I like the library, but I don't like how to select the container of the image.
In the documentation you write a markup like:

but in the real worlds we use class and ids!

This throw an error:
Uncaught DOMException: Failed to execute 'querySelectorAll' on 'Document': '[.profile]' is not a valid selector.

IMO, a better solution is pass to querySelectorAll the container selector.

Hey @kikobeats !
Thanks for your comment.
I decided to use attributes because to me it's more classy and elegant.
But you're right ! We do uses classes and ids !
It's just the v1, a kind of proof of concept, but the next versions will be improved, I will make the selector better.
Thanks for your issue !

@LukyVj I understand your point, but you have to think that a lot of people want to use this library for current websites under production. How do you make easy compatible with whatever website? That's the point!

I agree.
But in theory, if you follow the documentation, everyone could use it on their own websites.
Thanks for your precious contributions tho !

So, this will be shipped in the next version (1.2 ) of colorify.
Targeting will use IDs and classes to work.
Now, it will work with the following markup and JS

colorify({
    container: 'colorify-container' // id only
});

sounds amazing! :-)


Clarify Network and Relation dependency.

Right now State has separate entries for Networks and Relations, but, perhaps, Networks should be 'nested' under Relations: IE for each Relation you have, you also get a Network.
TODO:

verify this matches the juju model

This will become live when #90 merges


issue-288 : new param for createOrUpdateApplicationLtpsAsync

Fixes #288

@ManasaBM1 , as discussed last week , please close this PR if the changes are not required for version 2.1.


refactor json path and schema tests

fixes #359
extracted all TestXXX_Getters that included Path and Schema tests into TestXXX_Path, TestXXX_Schema, and Test_Getters individual, respective tests.
additionally, refactored each set of Schema tests into the following format:

create new instance of value based on first referenced type
perform Schema check for first type
perform Schema check for second type

I considered splitting the tests into subtests and creating a new variable inside each one, but that ended up being too much repeat code. Although it may have been slightly more readable to a new user, this version is cleaner and more maintainable.

Coverage: 95.672%. Remained the same when pulling 558c94549cc0463e55a7c81ea2e0bf9a84f3dc87 on antara-gandhi:master into e6ecc94d891c26835a09f97db494c9a872fcde3b on gavv:master.

@gavv PR is ready for review! Lmk if there are any changes to be made. Thanks!

Nice!
Could you please remove now unnecessarily cslls to chain.clear in the end of some tests?
Also, could you rename TestXxx_Getters tests that now check only Raw method to TestXxx_Raw?
Thanks

Should be done now @gavv! I wasn't sure for TestString_Getters though - I think we still need the value.chain.clear() in it but correct me if I am wrong. Also, since the test is also checking num.chain.assert(t, success), I kept the test name as TestString_Getters instead of TestString_Raw, but again lmk if I should change that.

LGTM!


Failed to activate extension after onUri event

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.80.2
OS Version: Windows_NT x64 10.0.22621

Steps to Reproduce:

Uninstall all extensions except Azure Account, Azure Machine Learning and Azure Machine Learning Remote
Activate the Azure ML extension with the URI vscode://ms-toolsai.vscode-ai/computeInstance/remote?computeId=/subscriptions/<SUBSCRIPTION>/resourceGroups/<RESOURCE-GROUP>/providers/Microsoft.MachineLearningServices/workspaces/<WORKSPACE>/computes/<COMPUTE-INSTANCE>&windowId=_blank
VS Code opens but the extension is not activated since the Azure Account extension dependency failed to activate. See the logs:

2023-08-01 15:23:12.570 [info] Extension host with pid 49200 started

2023-08-01 15:23:12.583 [info] ExtensionService#_doActivateExtension ms-vscode.azure-account, startup: false, activationEvent: 'onUri:ms-toolsai.vscode-ai', root cause: ms-toolsai.vscode-ai

2023-08-01 15:23:12.622 [error] Activating extension ms-vscode.azure-account failed due to an error:

2023-08-01 15:23:12.622 [error] Error: Cannot find module 'vscode'

Require stack:

- c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js

- c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\main.js

- c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js

- c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\bootstrap-amd.js

- c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\bootstrap-fork.js

-

    at Module._resolveFilename (node:internal/modules/cjs/loader:1010:15)

    at s._resolveFilename (node:electron/js2c/utility_init:2:2740)

    at Module._load (node:internal/modules/cjs/loader:858:27)

    at f._load (node:electron/js2c/asar_bundle:2:13330)

    at l._load (c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:127:28070)

    at p._load (c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:127:25404)

    at Module.require (node:internal/modules/cjs/loader:1082:19)

    at g (c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:4:647)

    at 89496 (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:2800570)

    at __webpack_require__ (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:3437775)

    at 53717 (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:480939)

    at __webpack_require__ (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:3437775)

    at 32233 (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:484889)

    at __webpack_require__ (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:3437775)

    at 71179 (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:410782)

    at __webpack_require__ (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:3437775)

    at 94485 (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:431062)

    at __webpack_require__ (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:3437775)

    at 35695 (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:2525460)

    at __webpack_require__ (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:3437775)

    at 42863 (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:2503212)

    at __webpack_require__ (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:3437775)

    at c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:3438950

    at Object.<anonymous> (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\dist\extension.bundle.js:2:3438995)

    at u._compile (c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:4:1271)

    at Module._extensions..js (node:internal/modules/cjs/loader:1243:10)

    at Module.load (node:internal/modules/cjs/loader:1058:32)

    at Module._load (node:internal/modules/cjs/loader:893:12)

    at f._load (node:electron/js2c/asar_bundle:2:13330)

    at l._load (c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:127:28070)

    at p._load (c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:127:25404)

    at Module.require (node:internal/modules/cjs/loader:1082:19)

    at g (c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:4:647)

    at Object.<anonymous> (c:\Users\E13CBH\.vscode\extensions\ms-vscode.azure-account-0.11.5\main.js:19:19)

    at u._compile (c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:4:1271)

    at Module._extensions..js (node:internal/modules/cjs/loader:1243:10)

    at Module.load (node:internal/modules/cjs/loader:1058:32)

    at Module._load (node:internal/modules/cjs/loader:893:12)

    at f._load (node:electron/js2c/asar_bundle:2:13330)

    at l._load (c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:127:28070)

    at p._load (c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:127:25404)

    at Module.require (node:internal/modules/cjs/loader:1082:19)

    at require (node:internal/modules/cjs/helpers:102:18)

    at Function.i [as __$__nodeRequire] (c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:5:98)

    at i.rb (c:\Users\E13CBH\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:127:26583)

    at async Promise.all (index 0)

2023-08-01 15:23:12.630 [info] ExtensionService#_doActivateExtension vscode.github-authentication, startup: false, activationEvent: 'onAuthenticationRequest:github'

2023-08-01 15:23:12.655 [info] ExtensionService#_doActivateExtension vscode.git-base, startup: true, activationEvent: '*', root cause: vscode.git

2023-08-01 15:23:12.667 [info] ExtensionService#_doActivateExtension vscode.microsoft-authentication, startup: false, activationEvent: 'onAuthenticationRequest:microsoft'

2023-08-01 15:23:12.683 [info] ExtensionService#_doActivateExtension vscode.git, startup: true, activationEvent: '*'

2023-08-01 15:23:12.715 [info] ExtensionService#_doActivateExtension vscode.github, startup: true, activationEvent: '*'

2023-08-01 15:23:12.805 [info] Eager extensions activated

2023-08-01 15:23:12.805 [info] ExtensionService#_doActivateExtension vscode.debug-auto-launch, startup: false, activationEvent: 'onStartupFinished'

2023-08-01 15:23:12.813 [info] ExtensionService#_doActivateExtension vscode.merge-conflict, startup: false, activationEvent: 'onStartupFinished'

2023-08-01 15:23:12.822 [info] ExtensionService#_doActivateExtension ms-vscode-remote.remote-wsl-recommender, startup: false, activationEvent: 'onStartupFinished'

2023-08-01 15:23:12.835 [info] ExtensionService#_doActivateExtension ms-vscode-remote.remote-containers, startup: false, activationEvent: 'onStartupFinished'

2023-08-01 15:24:22.125 [info] ExtensionService#_doActivateExtension vscode.emmet, startup: false, activationEvent: 'onLanguage'

cc'ing @bamurtaugh for visibility

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!

There isn't much we can do about it. When a dependency fails to activate we cannot activate the actual dependency. From the log this looks like a webpack error. It says that the vscode module cannot be loaded which is likely true because that module is special and only exists at runtime. For webpack it should be defined as external so that the code loading this doesn't get changed


Use number as key

When I use number to get value, it go to the wrong way.
e.g.
var cache = store.namespace('test')
cache(1, true)
console.log(cache(1))
In the store function, it just charge the string type, but sometimes the key will be number.
Should I pull request to solve this issue?

The value is stored just fine. Try console.log(cache.get(1));
The cache(key) shortcut is treating the single, non-string parameter as an object and passing it off to the setAll(values) function instead of get(key).
Using non-string keys is not something store is designed to fully support. I'd be happy to review and consider a pull request that changes that, especially if it doesn't require a lot of changes.

Thanks for the PR. Works for me. :)


XGBoost Custom Objective function uknown

I am using XGBoost 0.9 in Python 3.7  and trying to implement a custom objective function calling xgboost.train. I have defined my function However I am getting the following error message xgboost.core.XGBoostError: [19:31:46] /workspace/src/objective/objective.cc:23: Unknown objective function <function custom_loss at 0x7f2ca3028200>
The signature of my objective function is the same as defined in here
I have also noticed the same behavior when just trying to pass a custom eval_metric
The following is a complete code snippet
 params = {'max_depth':6, 'eta':0.3, 'objective':custom_loss, 'eval_metric':['rmse'],'colsample_bytree':0.75, 'colsample_bylevel':0.75, 'colsample_bynode':0.75, 'reg_alpha':0.3, 'reg_lambda':1}
xgb_model = xgb.train(params, dtrain,num_boost_round=1000,early_stopping_rounds=10, feval=f_error, evals=[(dtrain,'train'),(dtest,'test')], verbose_eval=True)

First rmsle is not in 0.9 release.

I have installed xgboost using pip. Are you asking me to build it from the source ? I have tried running this example with my current installation and I am getting the following error:
Traceback (most recent call last):
  File "temp_example.py", line 151, in <module>
    rmsle_evals = native_rmsle(dtrain, dtest)
  File "temp_example.py", line 97, in native_rmsle
    evals_result=results)
  File "/home/anaconda3/envs/mdir/lib/python3.7/site-packages/xgboost/training.py", line 216, in train
    xgb_model=xgb_model, callbacks=callbacks)
  File "/home/anaconda3/envs/mdir/lib/python3.7/site-packages/xgboost/training.py", line 74, in _train_internal
    bst.update(dtrain, i, obj)
  File "/home/anaconda3/envs/mdir/lib/python3.7/site-packages/xgboost/core.py", line 1109, in update
    dtrain.handle))
  File "/home/anaconda3/envs/mdir/lib/python3.7/site-packages/xgboost/core.py", line 176, in _check_call
    raise XGBoostError(py_str(_LIB.XGBGetLastError()))
xgboost.core.XGBoostError: [09:33:50] /workspace/src/metric/metric.cc:23: Unknown metric function rmsle
Stack trace:
  [bt] (0) /home/anaconda3/envs/mdir/xgboost/libxgboost.so(xgboost::Metric::Create(std::string const&)+0x62d) [0x7fc268a5aebd]
  [bt] (1) /home/anaconda3/envs/mdir/xgboost/libxgboost.so(xgboost::LearnerImpl::Configure(std::vector<std::pair<std::string, std::string>, std::allocator<std::pair<std::string, std::string> > > const&)+0x1299) [0x7fc268a3e009]
  [bt] (2) /home/anaconda3/envs/mdir/xgboost/libxgboost.so(XGBoosterUpdateOneIter+0x76) [0x7fc2689a3ae6]
  [bt] (3) /home/anaconda3/envs/mdir/lib/python3.7/lib-dynload/../../libffi.so.6(ffi_call_unix64+0x4c) [0x7fc28de5bec0]
  [bt] (4) /home/anaconda3/envs/mdir/lib/python3.7/lib-dynload/../../libffi.so.6(ffi_call+0x22d) [0x7fc28de5b87d]
  [bt] (5) /home/anaconda3/envs/mdir/lib/python3.7/lib-dynload/_ctypes.cpython-37m-x86_64-linux-gnu.so(_ctypes_callproc+0x2ce) [0x7fc28e070ede]
  [bt] (6) /home/anaconda3/envs/mdir/lib/python3.7/lib-dynload/_ctypes.cpython-37m-x86_64-linux-gnu.so(+0x12914) [0x7fc28e071914]
  [bt] (7) python(_PyObject_FastCallKeywords+0x49b) [0x562fae2288fb]
  [bt] (8) python(_PyEval_EvalFrameDefault+0x52f8) [0x562fae28c6e8]

@Skeftical You can install the nightly build by running
pip install https://xgboost-ci.net/job/xgboost/job/master/lastSuccessfulBuild/artifact/python-package/dist/xgboost-1.0.0_SNAPSHOT-py2.py3-none-any.whl

I am not sure why this issue is closed I am still getting the same error even after I have installed the nightly build.

The native RMSLE is not in release version yet.  You have to compile XGBoost from latest commit to use it.

Yes, this not the error I am encountering. I am not trying to use RMSLE specifically. I am trying to define my own custom objective function. However when I do that XGBoost throws an error saying that this is an unknown function.
Take a look at my code :
 params = {'max_depth':6, 'eta':0.3, 'objective':custom_loss, 'eval_metric':['rmse'],'colsample_bytree':0.75, 'colsample_bylevel':0.75, 'colsample_bynode':0.75, 'reg_alpha':0.3, 'reg_lambda':1}
xgb_model = xgb.train(params, dtrain,num_boost_round=1000,early_stopping_rounds=10, feval=f_error, evals=[(dtrain,'train'),(dtest,'test')], verbose_eval=True)

I am defining a custom objective. Here, custom_loss is a defined Python function. However XGBoost cannot properly locate it maybe. An throws the error xgboost.core.XGBoostError: [19:31:46] /workspace/src/objective/objective.cc:23: Unknown objective function <function custom_loss at 0x7f2ca3028200>

Please see the example code here https://github.com/dmlc/xgboost/blob/master/demo/guide-python/custom_rmsle.py
Notice which parameter is used to hold your function.

Okay I got it now. Beware that when passing a custom function the parameter is obj instead of objective, which is really strange. Also, when passing a custom feval make sure that your label does not have spaces. For instance in the example @trivialfis gave the last line of the custom function is :
return 'PyRMSLE', float(np.sqrt(np.sum(elements) / len(y)))
If the label was 'Py RMSLE' XGBoost throws an error saying there are not enough values to unpack.


upgrade binwrap to drop deprecated natives dependency

binwrap 0.2.0 doesn't have a transitive dependency on natives, which is a dicey package (See this note: https://github.com/addaleax/natives#caveat)
Specifically opening this PR because of test failures here https://github.com/NoRedInk/elm-css-files/pull/1

See #1884, the package on npm has already been released with this version bump. The changes have not yet been merged into this repository though.
There is also a discourse post somewhere with more information.

Here is the mentioned topic on discourse https://discourse.elm-lang.org/t/why-are-updates-to-the-official-npm-package-coming-out-of-an-obscure-branch-on-not-the-official-repo


Deleting never works (PR closed)

See e.g. https://ci.woodpecker-ci.org/repos/3780/pipeline/12163/3
Error:
Surge.sh preview plugin
not Found

well it do look like it works now https://ci.woodpecker-ci.org/repos/3780/pipeline/13573/3 ... kind a
the initial issue should be fixed with https://github.com/woodpecker-ci/woodpecker/pull/3442

so I'll close this one ;)
and open a new one for the next one


Papers might be meaningful to be included

Hi OpenDILab,
I want to share our published papers that might be meaningful to be included:

StARformer: Transformer with State-Action-Reward Representations for Visual Reinforcement Learning at ECCV'22 https://arxiv.org/abs/2110.06206

StARformer: Transformer with State-Action-Reward Representations for Robot Learning at T-PAMI https://ieeexplore.ieee.org/document/9878209

Thanks and regards,
Jinghuan

Thank you for sharing published papers with us. They indeed seem meaningful and relevant to be included.
We appreciate your contribution and will consider adding these papers to future updates. (Index is very cute!)


Nisekoi !? (ニセコイ　ヨメイリ！？) [PCSG00397]

App summary

App name: ニセコイ　ヨメイリ！？
App serial: PCSG00397
App version: 1.00

Vita3K summary

Version: v0.1.6
Build number: 2829
Commit hash: https://github.com/vita3k/vita3k/commit/2d62a97a9d3cadbd67836da415421c7a4197c057
CPU backend: Dynarmic

Test environment summary

Tested by: Croden1999
OS: Windows 10
CPU: Intel Core i7-7700HQ
GPU: NVIDIA GeForce GTX 1050
RAM: 8 GB

Issues
No issue, running this game works great.

Screenshots

Log
vita3k.log
Recommended labels

Playable

sorry, I did not notice a duplicate issue just now.


Laravel's response objects.

Using Laravel's Requests for validation ect throws an exception. Somewhere this is being created into a json response but Dingo doesn't like it.
Argument 1 passed to Dingo\Api\Routing\Router::prepareResponse() must be an instance of Illuminate\Http\Response, instance of Illuminate\Http\JsonResponse given, called in /var/www/fundbay.co.uk/packages/application/vendor/dingo/api/src/Routing/Router.php on line 541

Yes, its because $this->validate automatically return instance of Illuminate\Http\JsonResponse if request was AJAX .. workaround for right now maybe we should using manual validator
$validator = Validator::make($payload, $rules);

        if ($validator->fails()) {
            throw new Dingo\Api\Exception\StoreResourceFailedException('Could not create new user.', $validator->errors());
        }

waiting for other for better idea :)

Actually, I like the fact I'm not having to put it in my controller, one of the main reasons I've upgraded. I'd prefer if this sort of stuff works or has a very similar method.

Yes, i'd like to write code like this too :+1:

Yeah, same problem I had today. I fix it this way.
try {
	$this->validate($request, [
        'id' => 'required', 'password' => 'required',
    ]);
}
catch(IlluminateException\HttpResponseException $e) {
    return $this->response->array(['message'=>$e->getResponse()->getContent(),'status_code'=>$e->getResponse()->getStatusCode()]);

}

And don't forget this :
use Symfony\Component\HttpKernel\Exception;
use Illuminate\Http\Exception as IlluminateException;

Some note aside : If you use code above as internal request, it will throw an error. Some modification are still needed.

@vugtis wow, nice, at least we can use $this->request .. hehhee ..
Thanks

Duplicate of #462. I'll take a look at this today folks, see what I can come up with.


Fix PEP issues in hamlpy_watcher and add tests

Coverage increased (+12.5%) to 92.035% when pulling ad0feee3af2d27c388419b9119e886f0acb3c82c on watcher_testing into 13dbeebfe9edf30a75a5d119d9a0f59a2cc43941 on master.

Coverage increased (+12.5%) to 92.035% when pulling ad0feee3af2d27c388419b9119e886f0acb3c82c on watcher_testing into 13dbeebfe9edf30a75a5d119d9a0f59a2cc43941 on master.


Normalize scheme for URL on Android

Android requires lowercase for URL scheme. This commit https://github.com/facebook/react-native/commit/d00bdb9bb8b9b11bce900689c7e28cebd2eb0807 fixed it but on React Native side.
Because it is Android specific, it should be fixed on Android side.
Android has method to normalize url scheme: https://developer.android.com/reference/android/net/Uri.html#normalizeScheme()
Test Plan:
> import android.net.Uri;
>
> Uri.parse("Http://google.com").normalizeScheme();

Result: http://google.com
> import android.net.Uri;
>
> Uri.parse("HtTps://google.com").normalizeScheme();

Result: https://google.com

Release Notes:
[ANDROID] [BUGFIX] [Component] - Normalize Android URI scheme

@facebook-github-bot shipit

@radeno thank you for the PR. Could you please sign CLA so we can land your PR.

@dulmandakh done

@facebook-github-bot shipit


New Machine requirement: TRSS replacement

I need to request a new machine:

New machine operating system (e.g. linux/windows/macos/solaris/aix): Linux
New machine architecture (e.g. x64/aarch32/arm32/ppc64/ppc64le/sparc): Probably x64
Provider (leave blank if it does not matter):
Desired usage: Replacement for the TRSS server
Any unusual specification/setup required: New system will be running under docker, so will need docker to be available.
How many of them are required: 1

Please explain what this machine is needed for: Replacement for the existing TRSS server which is running on AWS and should therefore be decommissioned as most others there have been as it is not a sponsored provider.

We have an existing playbook for setting up a TRSS server, but the current recommended way to set up TRSS is using docker compose, Some references:

AQAvit call on the setup with docker-compose
Doc: https://github.com/adoptium/aqa-test-tools/tree/master/TestResultSummaryService#docker-compose
Support added in https://github.com/adoptium/aqa-test-tools/pull/795

Created at <IP_ADDRESS> - infrastructure team's keys added

@llxia @smlambert Should the second link with the docker-compose docs work straight out of the box with the current aqa-test-tools repo? The package.json has references to docker compose instead of docker-compose and if I fix it gets a bit further then hits this problem:
Removing intermediate container 125d62fd987c
 ---> dc4be6de7db7
Step 4/13 : COPY package.json package-lock.json .
When using COPY with more than one source file, the destination must be a directory and end with a /
ERROR: Service 'client' failed to build : Build failed

Also from taking a look at the video, is it storing the database in the directory where you run npm docker run as opposed to in the docker container itself (I need to know for setting up the file systems appropriately)?

docker compose should be used.
docker-compose, aka v1, has now been deprecated and development has moved to v2. Please see
https://stackoverflow.com/questions/66514436/difference-between-docker-compose-and-docker-compose
https://docs.docker.com/compose/#compose-v2-and-the-new-docker-compose-command
https://docs.docker.com/compose/migrate/#what-are-the-differences-between-compose-v1-and-compose-v2

The new machine has 100g in /var/lib/docker, however because of https://github.com/adoptium/aqa-test-tools/blob/6ffa683e929c20b6eb31eb2ecaf473d2e977544e/docker-compose.yml#L9C30-L9C30, mongo will store everything in the top level aqa-test-tools because thats where the docker-compose file is. Right now on the new machine I have the service running from /home/jenkins/aqa-test-tools which means mongo is storing everything in a docker-host mounted volume in /home/jenkins/aqa-test-tools, ie not in /var/lib/docker where all the space is

What ive done so far:

TRSS is running on http://<IP_ADDRESS>/
It is running as a non root user
port 80 is open on the machine via the azure console
The mongo data from the current machine has been imported into the new machine

What needs to be done:

The back end is not 'pointing' at our adoptium jenkins. I copied the credentials file from the current machine into a trssConf.json file on the new machine. The logs indicate that the credentials file is being used, yet the new TRSS instance does not look like it is getting any new test data from the adoptium jenkins server
Certificate files need to be copied from the current machine
The nginx conf files on the new machine are the bare minimum. I suggest the conf files from the current machine are copied over after the certificates get copied over

I think a solution is to add a disk and mount it to a separate directory, like /data/, and launch docker compose from there

In that case I recommend that we redo the disk with /var/lib/docker on it and created a smaller file system for that and a larger one that covers the data - I'd probably prefer that being mounted on /home or /home/jenkins or another path underneath those - seems simpler not to have a complete new separate directory off / for this, and it's always good to have /home separate to avoid it filling up the root file system.

Ill add the disk to /home/jenkins/trss/ and launch the service from there.
Regarding the import of the mongo data, I used exportMongo.sh. However since now mongo runs in a docker container the restore command (mentioned in that script) needs to be run in the container, and the archive needs to be copied into the running container.
https://adoptium.slack.com/archives/C5219G28G/p1692865247390769?thread_ts=1692109686.752019&cid=C5219G28G, at the moment the performance of the machine when it comes to loading data is extremely slow. Ill continue to monitor the performance after ive added the new disk

Update
The machine's ip has changed to <IP_ADDRESS>. The TRSS service is running on port 80 on the machine. The data disk is 128g with 30g for /var/lib/docker, 60g for /home/jenkins/trss (which is where mongo will be storing its data) and 4g swap.
More can be added if needs be, at the moment mongo (and the other trss services) are taking up 4.9G (thats including the import of the data from the current trss machine)

MongoDB was chewing up two full cores of CPU continuously which the original server was not doing. It appears ok today though - has a configuration change occurred to resolve that problem @Haroon-Khel ?

I checked too.  By this I mean mongod uses 0.7% when idle, and goes up to 200% when accessing the service. Funnily enough I did the same thing for the current trss service and I found it behaved the same way, ie on the current trss machine mongod eats up upto 400% of the CPU but only when accessed, stays at 0.3%ish when idle
PID     USER         PR  NI    VIRT        RES         SHR   S    %CPU  %MEM  TIME+         COMMAND
9630 mongodb   20   0     10.439g  8.002g   6932  S   355.1     53.0     139390:51   mongod

So its not specific to the new trss instance

Interesting - I'm no longer seeing it getting stuck at high CPU load although it does sit at 200% when loading the initial TRSS homepage - I wonder if we could optimise some of the queries there.
@smlambert Can you see if this new TRSS instance is working adequately for the JDK21 triage? Would be good to give it a bit of a workout before switching it to be the primary one.

Something is not quite right with it, as I am struggling to add new pipelines to monitor, trying to add https://ci.adoptium.net/job/build-scripts/job/release-openjdk20-pipeline/ and the service seems to 'go away' (would be good to see the logs to see what is going on).  I can give details when I am back from 3 day PTO and can share a screen.  Let's keep the old one up and running.

Haroon has indicated that he's been able to replicate the problem that Shelley mentioned in the previous comment. Given that we are having issues here with the new instance and are unable to switch over the production server we should perhaps consider creating a direct replica of the existing server for now and see if that behaves as expected and look at fixing underlying issues with the new deployment asynchronously to avoid delaying the switchover.

Yes I have seen the data just disappear on occasion. Annoyingly there is no log file in the normal mongo log file location
root@5a6e8cab57d6:/# ls -la /var/log/mongodb/
total 12
drwxr-xr-x 1 mongodb mongodb 4096 Sep  2  2022 .
drwxr-xr-x 1 root    root    4096 Sep  2  2022 ..

Given that we are having issues here with the new instance and are unable to switch over the production server we should perhaps consider creating a direct replica of the existing server for now and see if that behaves as expected and look at fixing underlying issues with the new deployment asynchronously to avoid delaying the switchover.

I could increase the new trss server's cpu and ram to make it similar to the current server and then observe any differences. That would be quicker than creating a whole replica

I could increase the new trss server's cpu and ram to make it similar to the current server and then observe any differences. That would be quicker than creating a whole replica

I'm sceptical as to whether that will make any difference but if you can quickly test it then feel free.

I've resized the machine to 8cpu and 16g ram. On htop im seeing CPU usage upto 500% when the trss service is accessed, 0.7% when idle. So similar to the current trss machine. Data loads up alot faster than before.
@smlambert Could you try adding another pipeline again

Yes I have seen the data just disappear on occasion. Annoyingly there is no log file in the normal mongo log file location
root@5a6e8cab57d6:/# ls -la /var/log/mongodb/
total 12
drwxr-xr-x 1 mongodb mongodb 4096 Sep  2  2022 .
drwxr-xr-x 1 root    root    4096 Sep  2  2022 ..

Can we see if we can enable the logging? https://betterstack.com/community/questions/how-to-log-all-or-slow-mongodb-queries/ shows how to enable query logging which might give us an idea of where the slowness is occurring. There's also stuff in there to specifically track slow-to-execute queries in there which might be useful. https://www.mongodb.com/docs/manual/reference/log-messages/#logging-slow-operations is the official docs related to logging slow queries.

Looks like logging is already enabled in /etc/mongod.conf
# where to write logging data.
systemLog:
  destination: file
  logAppend: true
  path: /var/log/mongodb/mongod.log

Running db.adminCommand( { getLog: "global" } ) in the mongo shows me a somewhat readable log

@smlambert The changes in https://github.com/adoptium/aqa-test-tools/pull/821/files have been applied to the new trss machine. Could you try again to add a new pipeline

I am now able to add new pipelines without issue, thanks @Haroon-Khel !

Let's see how it goes this week - from the comments being made it seems to be working well now (other than a problem when I configured the nginx frontend to rate limit more than it needed) We can then look at switching this to be the primary server next week. @Haroon-Khel Have you looked at copying the SSL certificate from the old machine across as a test to make sure we can enable it with that (It will show as an invalid certificate when you connect, but worth making sure the setup of nginx is correct)

It looks like the light rate limiting may have stopped the mongodb becoming overwhelmed with requests as it's not jumping up to 500% CPU in the way it was previously.

Can confirm. At most it is hitting 100% cpu. If it stays like this we could certainly drop the cpus down

I was at least expecting http://<IP_ADDRESS>/ to have a faulty certs proceed with caution barrier but instead it just gave me nginx errors

Hmmm http would never give a faulty cert option (unless it redirected!) - you'd need to go to the HTTPS port for it to present the certificate. Do you know what the errors were? Copying the files across shouldn't have caused anything related to the HTTP connections to break.
If it's not an obvious reason I suggest we take a look at this and the switch of CPUs tomorrow morning as I doubt too many people will be using the server until the afternoon.

DNS entry has been updated so should propogate everywhere soon https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3904

LetsEncrypt certbot is now set up and will auto-renew via a systemd timer

Old machine in AWS has now been decommissioned so will not be incurring future charges - closing.


[roi] Arc ROI can't be used to select a full circle

In fact there is name uses of the arc ROI, then it looks like it is very difficult an user interaction which feet evey usage.

We could provide a kind of DonutROI
We could provide tools on the manager to close ArcROI instead of only using anchors (the way chosen by Inkscape)
We could provide another modernization more based on circle concept
We could provide more anchors

Here is a proposal:

custom the weight
custom angle of start/end points without changing the circle center/radius
relocate this point without changing the curvature (kind of rotation/scale)
custom the curvature without moving end points and weight (swhich could be removed for a third free circular point (tree point to identify a base circle))
translate the shape

The Arc ROI can be closed now


closes #89 lasta@devel

Please add "Closes #" to the title of the pull request. Then the
issue is closed automatically once it is merged to main.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[x] Updated relevant unit tests or have written new unit tests - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Update to all relevant roxygen headers and examples
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md
[x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue so that it closes after successful merging.
[x] Address all merge conflicts and resolve appropriately
[x] Pat yourself on the back for a job well done!  Much love to your accomplishment!

The following line requests to update the man pages by the "Man Pages" workflow.
/roxygenize

@bundfussr i'm more inclined to go with issue an error in this case, as the package is so early anyway without many users likely - agree?

@bundfussr i'm happy with these updates so feel free to take a look but will have to wait for the CI workflows / gh actions to be back working again

thanks @bundfussr - i was so focused on the deprecation step that i missed such obvious things in the templates/vignettes! will get on these updates tomorrow and hopefully the workflows will be back working then too

@bundfussr i spotted a couple of extra updates needed for DEATH parameter too, which i'll make for admiralroche as well - see the last 2 commits. just need to check workflows now and then will request a re-review once they run ok

@bundfussr is the R 4.0 CI fail a known issue? looks to be something to do with staged.dependencies as its not picking up admiral and admiraldev dependencies

@rossfarrugia , yes, that's a known issue. Dinakar is investigating it.

@bundfussr i just spotted that the update i made for DEATH parameters to set AVAL is needed for all the places where we use derive_param_extreme_event() - what do you think about me doing this just once at the end for all params with Y or N value as a catch all instead? ideally the function itself would give AVAL as well as AVALC in a future release.

@rossfarrugia , fine with me.
I think the function should support both deriving AVAL and not deriving AVAL. We should consider this in the clean-up issue.

@bundfussr should be ok to re-review now.


Terminal links: url parameters value ignored

VSCode Version: 1.10 insider
OS Version: windows 10

Steps to Reproduce:

open the terminal from VSCode and have it print an url with an url parameter, like https://github.com/foo?param=ignored

Click on the link: the page https://github.com/foo?param will be opened instead of the full url with parameters https://github.com/foo?param=ignored.

Duplicate https://github.com/Microsoft/vscode/issues/21186


✨ new transformer loggers and some redesign

Added new transformer loggers:

ColorMessageTransformerLogger
FixedMessageWidthTransformerLogger

Some design changes:

Got rid of the build function.  Replaced with compose for chaining transformers in the right order.
The composite transformer loggers are reimplemented using @pipe rather than chaining TransformerLogger's

Codecov Report

Merging #9 into master will decrease coverage by 27.67%.
The diff coverage is 52.17%.

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
- Coverage   94.33%   66.66%   -27.68%
===========================================
  Files           6        5        -1
  Lines          53       84       +31
===========================================
+ Hits           50       56        +6
- Misses          3       28       +25

Impacted Files
Coverage Δ

src/LoggingFacilities.jl
100.00% <ø> (ø)

src/sink.jl
66.66% <ø> (ø)

src/types.jl
100.00% <ø> (ø)

src/common.jl
46.15% <41.66%> (-53.85%)
:arrow_down:

src/transform.jl
83.33% <90.00%> (-12.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a3f54...4da735c. Read the comment docs.


.net core 3, no dbcontext was found for PersistendGrantDbContext and ConfigurationDbContext

Please only use the issue tracker for bug reports and/or feature requests. For general security questions, or free or commercial support options do not use the issue tracker and instead see here for more details.
For bug reports,  include the relevant log files related to your issue. See here how to enable logging. Delete this line once you have.
Finally, please keep the issue concise and to the point. If you paste in more code than the text for the issue you are reporting then we will most likely not read it.
Issue / Steps to reproduce the problem
New .net core 3 project from scratch.
Adding identity server with following code:

services.AddIdentityServer(x =>
{
x.IssuerUri = "null";
x.Authentication.CookieLifetime = TimeSpan.FromHours(2);
})
.AddDeveloperSigningCredential()
.AddAspNetIdentity()
.AddConfigurationStore(options =>
{
options.ConfigureDbContext = builder => builder.UseSqlServer(connectionString,
sqlServerOptionsAction: sqlOptions =>
{
sqlOptions.MigrationsAssembly(migrationAssembly);
sqlOptions.EnableRetryOnFailure(maxRetryCount: 15, maxRetryDelay: TimeSpan.FromSeconds(30), errorNumbersToAdd: null);
});
})
.AddOperationalStore(options =>
{
options.ConfigureDbContext = builder => builder.UseSqlServer(connectionString,
sqlServerOptionsAction: sqlOptions =>
{
sqlOptions.MigrationsAssembly(migrationAssembly);
sqlOptions.EnableRetryOnFailure(maxRetryCount: 15, maxRetryDelay: TimeSpan.FromSeconds(30), errorNumbersToAdd: null);
});
})

executing: dotnet ef migrations add InitialIdentityServerPersistedGrantDbMigration -c PersistedGrantDbContext -o Data/Migrations/IdentityServer/PersistedGrantDb
result: No DbContext named 'PersistedGrantDbContext' was found.
executing: dotnet ef migrations add InitialIdentityServerConfigurationDbMigration -c ConfigurationDbContext -o Data/Migrations/IdentityServer/ConfigurationDb
result: No DbContext named 'ConfigurationDbContext' was found.

Issue was that I forgot to add ConfigurationDbContext and PersistedGrantDbContext to my DesignTimeDbContextFactory... After creating them, migrations worked as expected


core: don't display unsuported image types

If an image type was supported by osbuild-composer but not cockpit-composer it would still be displayed. Now, an image type must be listed in the list of imageTypeLabels for it to be displayed in the list of available image types.

The firefox error seems real. I can't find User account actions user anywhere in the code. Shouldn't it be present on a dropdown somewhere?

This has been broken for months now.


[BUG] Fail to Add disk with LHv2 Provisioner

Describe the bug
Fail to add SCSI and NVME disk using LHv2 Provisioner
To Reproduce
Steps to reproduce the behavior:

Enable LHv2 Engine in Settings

Harvester

Longhorn

:x: Add /dev/sdb disk with LHv2 Provisioner

:x: Add NVME disk with LHv2 Provisioner

Expected behavior
Disk should be able to add using LHv2 Prosisioner
Support bundle
supportbundle_9aca9f59-bed0-4893-a649-fa43153cba67_2024-10-23T10-14-14Z.zip
Environment

Harvester ISO version: v1.4.0-rc3
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): Baremetal with HPE ProLiantDL360Gen9

Additional context

Longhorn Nodes

Retest on v1.4.0-rc4, successfully add NVME this time but still fail on SCSI disk with block size error.
Note that delete disk also fails.
Environment

harvester-v1.4.0-rc4

Profile: Single node AMD64 Bare-metal
ui-source: Auto

Test Steps

 :green_circle: Enable LHv2 data engine

Harvester

Longhorn

 :green_circle: Add NVME disk

Format

Add

Disk State

 :red_circle: Add SCSI disk

:heavy_check_mark: Format and Add from UI

:heavy_check_mark: Add

:x: Disk State

Host

instance-manager

blockdevice

[longhorn-instance-manager] ... ERROR: Disk size<PHONE_NUMBER>168 is not a multiple of block size 4096

 :red_circle: Delete SCSI disk

:heavy_check_mark: Delete from UI

:x: instance-manager

blockdevice

[longhorn-instance-manager] ... msg="Failed to get lvstore with UUID or disk name ...
[longhorn-instance-manager] ... level=error msg="Failed to delete disk" ...

Logs
supportbundle_FailToAddScsiWithLhv2_2024-10-23T14-33-01Z.zip

When adding SCSI disks, Longhorn will use the aio bdev driver, which AIUI from a discussion with @damiasan assumes a block size of 4096 bytes, and thus requires the device to be an exact multiple of 4096 bytes. I don't know if this is documented anywhere, but AFAIK this is not something we can fix or change in harvester.
The disk deletion behaviour is correct under the circumstances. The disk was never completely added to longhorn, which is why we get the "failed to delete disk" errors in the instance manager log.
The device will remain in the list of block devices, as it is still attached to the system. When you add a disk using the harvester GUI, it changes the block device state from Unprovisioned to Provisioned, and the new disk appears in the Longhorn GUI. If you later delete the disk using the harvester GUI, it changes the block device state from Provisioned back to Unprovisioned, and the disk disappears from the Longhorn GUI. But it will always remain in that list of block devices, unless you physically remove or detach the disk.

4096 is by design, please check https://github.com/longhorn/go-spdk-helper/blob/main/pkg/spdk/client/advanced.go#L17

OK, I have reproduced the controller scan error here in a VM:
[2024-10-30 04:12:17.322755] nvme.c: 821:nvme_probe_internal: *ERROR*: NVMe ctrlr scan failed
[2024-10-30 04:12:17.322777] bdev_nvme.c:6263:bdev_nvme_create: *ERROR*: No controller was found with provided trid (traddr: 0000:00:02.0)

This appears to be a red herring. It only occurs in my testing on v1.4.0-rc3 (node-disk-manager v0.7.5) if there is already a filesystem on the nvme device when the device is provisioned. It does not occur if the disk is completely blank (no filesystem). It also does not occur on harvester v1.4.0-rc4 or newer (node-disk-manager v0.7.6+), because that version of NDM includes the call to wipefs when provisioning the disk (https://github.com/harvester/node-disk-manager/pull/157)
Here's what should work:

Completely blank NVMe device (with no filesystem created at all), should still be recognised by node-disk-manager and shown in the list of devices to add, provided the NVMe device has a WWN. It should be possible to provision this disk for LHv2 without running mkfs.ext4 on it first.
An NVMe device with an existing filesystem should also work, because it'll be wiped anyway by NDM as part of the provisioning process.

4096 is by design, please check https://github.com/longhorn/go-spdk-helper/blob/main/pkg/spdk/client/advanced.go#L17

Just to add to my earlier comment on this topic, 4096 only applies to the aio bdev driver, so, virtual SCSI disks, SSDs, any disk with a WWN that node-disk-manager recognises but that's not actually an NVMe. For NVMe devices, Longhorn defaults to the nvme bdev driver which picks up the block size of the underlying device, so will work fine whatever the size is.

If you have an NVMe device attached by the kernel, running SPDK  script setup.sh should detach the device from the kernel driver so that SPDK could attach to it ... But I don't know if this is true also if an existing filesystem is present on the device ...

Retest on v1.4-daf68d56-head without mkfs.ext4 -E nodiscard /target/disk this time and works as expected, close ticket.
Environment

harvester-v1.4-daf68d56-head

Profile: Single node AMD64 Bare-metal
ui-source: Auto

Test Steps

 :green_circle: Enable LHv2 data engine

Harvester

Longhorn

 :green_circle: Should be able to add a NVME disk

 :green_circle: Should fail to add a non-4096 bytes multiples SCSI disk

 :green_circle: Create VM with extra volume using LHv2 disk

VM

Volume

 :green_circle: Reboot and data still valid.

 :red_circle: Create VM with extra volume using LHv2 disk

Trace by #6868


[docs] Features added to landing page and readme (closes #763)

\cc @DevExpress/testcafe

/r-

lgtm

@testcafe-build-bot \retest

@testcafe-build-bot \retest


Server Error ReferenceError: global is not defined

Using middleware.js from Next.js I am getting this error when importing my session object from the session.ts/js file.

Hi @khentonx
It seems you're using the default MemoryStore, This error would happen if you're calling the session in the client side instead of server side.
The Readme file has details on where you can use the session and how:

Note: in App router, session can only read data in Server Components while it can read+write data in Route Handler and Server Actions. It follows the same usage rules as the cookies() dynamic function

If this is still an issue, please share the code from which you're calling the session file so I can investigate.
Thanks


CRM API - Unable to use + in filter query

I can verify the number is correct in "https://ENVIRONMENTNAMEHERE.api.crm.dynamics.com/api/data/v9.2/DBHERE?$select=SPECIFICCOLUMN" but cannot filter it due to the +. How would you do this? Need a parsing example and all info online says to cast which isn't supported for some reason?
https://ENVIRONMENTNAMEHERE.api.crm.dynamics.com/api/data/v9.2/DBHERE?$select=SPECIFICCOLUMN&$filter=contains(cast(SPECIFICCOLUMN,Edm.String),'+PHONENUMBERHERE')
Error: {"error":{"code":"0x8006088a","message":"The "cast" function isn't supported."}}
https://ENVIRONMENTNAMEHERE.api.crm.dynamics.com/api/data/v9.2/DBHERE?$select=SPECIFICCOLUMN&$filter=contains(SPECIFICCOLUMN,'+PHONENUMBERHERE')
Empty result
https://ENVIRONMENTNAMEHERE.api.crm.dynamics.com/api/data/v9.2/DBHERE?$select=SPECIFICCOLUMN&$filter=contains(SPECIFICCOLUMN,+PHONENUMBERHERE)
Error: {"error":{"code":"0x0","message":"No function signature for the function with name 'contains' matches the specified arguments. The function signatures considered are: contains(Edm.String Nullable=true, Edm.String Nullable=true)."}}
The document is very good, but it doesn't say how to parse special characters.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 65612608-d80d-d51e-6a74-d2120b6fa7f4
Version Independent ID: 0b0f4bad-88a6-3afd-25e4-bc50dc1cf257
Content: Web API Query Data Sample (Microsoft Dataverse) - Power Apps
Content Source: powerapps-docs/developer/data-platform/webapi/web-api-query-data-sample.md
Service: powerapps
Sub-service: dataverse-developer
GitHub Login: @divkamath
Microsoft Alias: dikamath

Thanks for your comment, @wrharper. This issue has been assigned to the doc author for review.

@wrharper
Thanks for your feedback.
This topic is describing a sample.
The topic that describes feature capabilities is this one: Query data using the Web API. For example, it shows the standard query functions that the Dataverse Web API supports, and you can see that cast isn't one of them. We only support contains, startswith, and endswith.
I've tested this using POSTMAN (see setup instruction here)
GET: {{webapiurl}}contacts?$select=telephone1&$filter=contains(telephone1,'+')

It returns this:
{
<EMAIL_ADDRESS>"https://myorg.api.crm.dynamics.com/api/data/v9.2/$metadata#contacts(telephone1)",
    "value": [
        {
<EMAIL_ADDRESS>"W/\"78107430\"",
            "telephone1": "+1 (555)-1234",
            "contactid": "3a254b05-d61f-ed11-b83e-000d3a572421"
        }
    ]
}

Is this what you are trying to do?
Can you provide a sample using common table (like contact, account) showing what you are sending, what you get back and what you expect?

I was unable to replicate this with custom DB's. I worked around this by just not putting the + since it is a contains anyway and it works that way.

Should be valid:

Should be valid:
https://ENVIRONMENT.api.crm.dynamics.com/api/data/v9.2/DBNAME?$select=COLUMNNAME1,COLUMNNAME2,COLUMNNAME3,COLUMNNAME4,COLUMNNAME5&$filter=COLUMNNAME1 eq 'AADOBJECTID' and COLUMNNAME2 eq '+PHONENUMBER' or COLUMNNAME1 eq 'AADOBJECTID' and COLUMNNAME3 eq '+PHONENUMBER'
but instead, the response is empty:
{"@odata.context":"https://ENVIRONMENT.api.crm.dynamics.com/api/data/v9.2/$metadata#DBNAME(COLUMNNAME1,COLUMNNAME2,COLUMNNAME3,COLUMNNAME4,COLUMNNAME5)","value":[]}

@wrharper-AASP
This repository contains the documentation and the issues we respond to are about the content. We can't offer technical support.
If you believe the content is inaccurate or incomplete, we can take action on specific feedback. Can you isolate what specific part of the syntax for constructing a query isn't documented clearly enough?

How can I speak with the devs of dataverse? This doesn't appear to be possible at all actually. It is an issue with how Edm.String is programmed on the Dataverse end.

You can contact technical support to raise issues.
But before you do that, I recommend reviewing the documentation about constructing queries here Query data using the Web API

I made a ticket here: https://admin.powerplatform.microsoft.com/support
None of that is the answer. I'll just mention this link to them so they can see the issue.

@wrharper-AASP
OK. I'll close this documentation issue since there is nothing actionable.
For support, I recommend providing a more specific repro using common tables as mentioned above.


QUESTIONS: Modem router, VPN, Firefox, Public WiFi etc

Hi,
I am a new user of SimpleDNSCrypt.
I am reading lot of stuff about it, trying to learn/understand how it works.
Naturally, lot of questions emerge, I tried to found answers, but it is not easy for me. So please, I have several questions:

In simple terms for laymen-users: What is the difference between DNSCrypt and VPN?

Do I need DNSCrypt if I have VPN?

I am a Firefox-user. Firefox recently implemented DoH + CloudFlare. If I activate it, do I need DNSCrypt for Firefox?

Having both "on" (DNSCrypt and Firefox DoH+CloudFlare), does it impact browser or computer performance (RAM, CPU, Internet speed etc)?

Using DNSCrypt, should I change DNS <IP_ADDRESS> at my router-modem? Should I change any other settings in my router-modem in order to use DNSCrypt?

If I use DNSCrypt, it will work in a public Wi-Fi?

Thanks a lot in advance!

A VPN will encrypt and authenticate all your traffic. Encrypted DNS (DNSCrypt, DNS-over-SSH, DNS-over-HTTP/2, whatever) only encrypts and authenticates DNS.
Depends on what you mean by DNSCrypt. You don't need encrypted DNS if you use a VPN. However dnscrypt-proxy (even through interfaces such as Simple DNSCrypt) let you block ads, trackers, inspect queries being made, remove duplicate queries, and more, to further enhance privacy.
If your system has been configured to use a secure DNS, you don't. Having secure DNS in Firefox is nice, but only protects Firefox. Firefox is not the only software installed on your system, and everything else also constantly sends DNS queries.
It can only degrade performance. dnscrypt-proxy has a cache, so that recent queries are served from memory. You won't take advantage of a central cache if you have two distinct things doing the same thing.
Unless dnscrypt-proxy is running on your modem, you shouldn't. Just keep the default DNS configured on your modem.
Yes, and that's the main use case.

Hi @jedisct1 ... as usual, excellent answers from your side! Thank you!
Sorry my ignorance, I still have some questions:

I read similar answers in other articles, but I still can't understand the difference between "traffic encryption" (VPN) and "DNS encryption" (DNSCrypt). Please, can you explain in other way? I understand VPN encrypts my IP, the number of queries, the IPs I visit etc (and DNSCrypts doesn't encrypt that). So, is this the difference between VPN x DNScrypt?

I can't use DNSCrypt in my modem (no open firmware). SimpleDNSCrypt is in my computer with CloudFlare. So based on you answer, my modem should be <IP_ADDRESS> / <IP_ADDRESS>... right?

Thanks!

Traffic encryption includes many protocols, and DNS is just one of them. With a VPN, your ISP doesn't see the IP addresses you are connecting to. With only DNS encryption, it does. But with a VPN, the VPN provider sees all the protocols. You have to ultimately trust them. With DNS encryption, the DNS provider only sees DNS. You also need to trust it, but less :)

You can use <IP_ADDRESS>/<IP_ADDRESS> on your router. If it breaks related equipments such as TV or telephony, switch back to your ISP DNS.

OK @jedisct1 , please let's keep talking a little more about point 1:
With a Public Wi-Fi, let's say the owner of the modem wants to steal user credit-cards or private stuff, and he hacks his own device:
What happens if I am using DNSCrypt in my computer? How DNSCrypt avoids "middle-man attacks"?
Why did you say that one of the main DNSCrypt uses is with public Wi-Fi?
What happens if I am using a VPN?
What happens if I am not using nothing? Does the owner of this public Wi-Fi can steal every information passing trough his modem?
Thanks!

I can only recommend https://www.wilderssecurity.com/ to learn about privacy technologies.

Hi @jedisct1 ,
Thank you, once again, for all your answers here in my post, in my other first post also here at GitHub, and in my other post at CloudFlare forum. You have been great!
I always knew GitHub is not a forum, not the place for my kind of questions.
And you have been more than patient with me. Thanks also for that!
Before asking, I tried to read, to learn, to understand about DNSCrypt, VPN etc.
The problem @jedisct1 is that I don't have knowledge to differentiate garbage from trusted sources.  In a Forum, everyone becomes an IT expert. Another problem at Forums is that when a serious guy appears to help, he uses terms so technical that is difficult to understand, at least for average users like me.
My final conclusion is a suggestion for you:
Please, consider the possibility to add a kind of FAQ at DNSCrypt webpage, answering questions for laymen-users, in simple terms. I know the DNSCrypt' Wiki and the webpage in general is full of great technical explanations. Nothing to critic there. I am just suggesting to add more simpler explanations for average users.
Thank you!


Clear login data

Description
Based on @tijno's changes https://github.com/bitclout/identity/pull/39 per issue https://github.com/bitclout/identity/issues/34
Adds "Clear login data" option to login for users to be able to wipe their accounts from localstorage. The bulk of the diff here is from Prettier formatting the styles.scss file 😅
Screenshots

Before
After

n/a

See it live (back button + confirmation flow)

@akutch amazing! thank you so much.

Any updates here?

@maebeam can you take a review of this? Wanted a second set of eyes and forgot to tag you earlier. sorry @akutch

If you could just fix that one merge conflict I'd love to get this added


Added png images for keploy Java dependencies.

Update documentation for mocking feature of java sdk

In this issue only adding png for Java dependencies part was left to add.

Closes: #353[keploy/keploy/issues/353]
Describe the changes you've made
A new section (supported dependencies) displaying png images for keploy Java dependencies has been added.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA.
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas and used java doc.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.

Screenshots (if any)
Light-mode

Dark-mode

Please see this mam @nehagup

@Arpcoder can you please post updated screenshot?

@nehagup  mam I have already edited my pull request comment with new screenshots. These are screenshots after using svg images.

@nehagup mam, I have added updated screenshots in my PR comment. Here is the updated screenshots -

@nehagup mam I have updated them by keeping aspect ratio constant.

@nehagup mam can you please review it for the last time. I have attached the screenshots in my previous comment.

@Arpcoder the naming of each dependency is still missing. I'm closing this since the documentation for mocking features has been done which was the initial goal of this issue. If you want to add logos of supported dependencies you can follow the same theme as displayed on landing page and open a new PR.


[Platform]: OtTable update drug

[Platform]: Drug page update to use OtTable(Tansctack)
Description
Drug page update to use OtTable(Tansctack) component.
Issue: (link)
Deploy preview: https://deploy-preview-415--ot-platform.netlify.app/drug/CHEMBL2010601
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Test A
Test B

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have made corresponding changes to the documentation

Indication widget on https://deploy-preview-415--ot-platform.netlify.app/drug/CHEMBL1431
Search:

Search for 'phenotype' - Does not give results
Search for 'covid' vs search for 'COVID' - case sensitive
Search for 'Phase I' - does not differentiate between Phase I, Phase II, Phase III and Phase IV
Search for 'pancreas disease' - does not search in the drawer results
Search for 'NCT01042379' - no results, unable to search by Clinical Trails

Sort

Default descending sorting by Max Phase IV to I is correct. But clicking on the sort changes the behaviour. Ideally it should be descending, then ascending and then off. Then descending, then ascending and then off

Font of 'Rows per page' is different and would need to be corrected before merging onto production.
Mechanisms of Action widget on https://deploy-preview-415--ot-platform.netlify.app/drug/CHEMBL185

Search for 'thymidaa' - yields results which does not match anything
Search for 'cancer or benign tumor' - does not give any results

The changes look good!


 Test failed.  See above for more details.

this happens after i run npm install
I did some exploring it seems that the tests (at least for me) start failing at commit 8286faf664bafa36c16d17964142e4fee61fd581
is this a problem on my end or are the test broken ?, i really like this project and would like to contribute if possible, thanks.
How to reproduce
Clone this repo: https://github.com/MSE99/TypL
and run npm install
Additional information
os: Pop!_OS 20.04 (An ubuntu based linux distro)
node version: 14.16.1
npm version:  6.14.1
typL version: I'm running the tests on the master branch on the latest commit.

I think it's entirely plausible that the tests are in a failing state, especially as it relates to that work around complex array types.
Would love help! Haven't looked at this project in a while so I need to get re-acquainted with it to give more detailed diagnosis. Will try to get to it ASAP.

Sorry for the late reply i was busy with school, i have an interesting idea but I'm not sure it would work, a large bulk of typL code is centered around collecting type information and validating it, i think it would be possible to delegate the the validation process to an external library.
For example we could collect and organize types as JSON schemas, and then use a validator like Ajv to preform type validation a big issue with this approach is JSON format doesn't fully support all javascript types, but JSON and the JSON schema standards are quite flexible so it's possible to get around these issues.
@getify Do you think that doing something like this is possible ?.


[Bug]: Compatibility with laravel 11

What happened?
The pkg is not compatible with laravel 11
How to reproduce the bug
Install the pkg in laravel 11
Package Version
1.0.8
PHP Version
8.2
Laravel Version
11.1.1
Which operating systems does with happen with?
No response
Notes
No response

Forgot to answer here :1st_place_medal:
The plugin is now compatible with Laravel 11 with version 1.0.9 and eventually later versions
https://github.com/edwink75/filament-user-activity/releases/tag/1.0.9

See above


Feature Request: data deletion protection in Prisma Cloud / Prisma CLI

Feature Request
I accidentally reset the data in a shared development environment by running yarn prisma delete (I thought I was pointing to my local environment). While it was not the end of the world, it would be a huge hassle if that were to happen in production.
Desired Solution
A way to set some kind of "data deletion protection" in the Prisma admin console for a Prisma service. When that deletion protection is turned on, the prisma CLI would give an error message when running yarn prisma reset or yarn prisma delete. Perhaps even yarn prisma import could be protected (occasionally we like to export from one environment and import into another).
In addition to this, there is a yes/no prompt when running a dangerous command that says something like
? Are you sure that you want to reset the data of default in stage default? y/N

Automatically printing out the PRISMA_ENDPOINT environment variable here would be helpful in letting the user know the potential consequences of their actions.
Alternatives and Workarounds
The best alternatives I can see right now must be implemented with policy and tooling. A rule of always running echo $PRISMA_ENDPOINT before running deletion migrations is an easy start. Other policy changes could be things like running a database backup, or running the yarn prisma export command before a dangerous operation is executed. Policies like this can be enforced with tools like bash/npm scripts that are used in place of directly invoking the prisma CLI.

Any word on this?


Prompt only if --option's argument isn't provided

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the Typer documentation, with the integrated search.
[X] I already searched in Google "How to X in Typer" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to Typer but to Click.

Commit to Help

After submitting this, I commit to one of:

Read open issues with questions until I find 2 issues where I can help someone and add a comment to help there.
I already hit the "watch" button in this repository to receive notifications and I commit to help at least 2 people that ask questions in the future.
Implement a Pull Request for a confirmed bug.

[X] I commit to help with one of those options 👆

Example Code
import typer

cli = typer.Typer()

@cli.command()
def req(
    username: str = 'admin',
    password: str = typer.Option(
        'default',
        prompt=typer.prompt('Password'), # True,
        # prompt_required=True,
    )
) -> None:
    print(f'Username: {username} | Password: {password}')

cli()

Description

Assume that the above code runs directly with command req

I would prefer if it were possible to provide password via prompt and not on commandline

Additionlly, using getpass & getuser seems more favourable.

When I provide a command like:
$ req --username myuser --password

It prompts, but afterword it runs into error:
Password:
Error: Option '--password,' requires an argument

Wanted Solution
Prompt for (here) password only when --password is passed w/o any argument.
Wanted Code
# NAY

Alternatives
NA
Operating System
Linux
Operating System Details
Arch Linux
Kernel: 5.18
Typer Version
0.6.1
Python Version
3.10.5
Additional Context
No response

My bad I do not understand this behavior:
~/test via 🐍 v3.10.5 (test)
➜ python -m test_typer --password "def"
0.6.1
Password: abc
Username: admin | Password: def

~/test via 🐍 v3.10.5 (test)
➜ python -m test_typer
0.6.1
Password: def
def [default]: 123 # why?!
Username: admin | Password: 123

I think something like this could give you what you want to achieve, if I've understood correctly. Instead of specifying the --password option and leaving it blank, you just don't use that option at all.
import typer

def main(
    user: str,
    password: str = typer.Option("", help="Enter your password."),
):
    if password:
        print(f"{user} and {password}")
    else:
        new_password = typer.prompt("Enter your password", confirmation_prompt=True, hide_input=True)
        print(f"user is: {user} and password is: {new_password}")

if __name__ == "__main__":
    typer.run(main)

As far as I can tell, if you add an option, then use the option when you are running the program on the command line, you have to specify some value for that option - i.e. there is no way to leave it blank. So I don't think the way you're trying to solve this is possible.

Yup, I've done something like this.

... if you add an option, then use the option when you are running the program on the command line, you have to specify some value for that option ...

Right, but it feels counter intuitive when used with prompt

prompt actually takes in a boolean so i believe that what you actually want it:
import typer

cli = typer.Typer()

@cli.command()
def req(
    username: str = "admin",
    password: str = typer.Option("default", prompt=True),
) -> None:
    print(f"Username: {username} | Password: {password}")

cli()

Output:
$ python /tmp/asd/potato/potato/main.py
Password [default]: hello
Username: admin | Password: hello

Thanks @heiskane!


Missing references.

Could you add references to the datasets and code that you took from my repositories? The license requires that your code is relicensed under the same license.

thanks, we are just starting to put things together. we will add references
for sure!
Le dim. 16 août 2020 à 12:34, Benedek Rozemberczki<EMAIL_ADDRESS>a écrit :

Could you add references to the datasets and code that you took from my
repositories? The license requires that your code is relicensed under the
same license.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ftheberge/GraphMiningNotebooks/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AKFEKTHRFSDBCOL4FEQ3KZDSBAC7ZANCNFSM4QA5CY7A
.


Reference to MvcMovie.db in Razor Pages example

In the Visual Studio Code tab of add a database connection string, the property ConnectionStrings.MovieContext points to a MvcMovie.db.
In the context of a Razor Pages app tutorial, it might be more suitable to call the database RazorPagesMovie.db or similar.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6719f08e-3bd7-dc1a-71df-f2ef9fbca9d8
Version Independent ID: 7096fdb3-612e-9e00-bd0b-8ea4886a09ce
Content: Add a model to a Razor Pages app in ASP.NET Core
Content Source: aspnetcore/tutorials/razor-pages/model.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

That's not the convention. Check out the other connection string.


missing uint256 on objectBalance

In case of "Operations.SUB", objectBalance type is not defined

Good catch, this actually compiles currently! https://twitter.com/gakonst/status/1041658852037541888
More context: https://www.youtube.com/watch?v=gk-Yu7BLa6I
Merging nonetheless


Bug report: creating aad app from manifest with keycredentials fails

Description
% m365 aad app add --manifest @manifest.json fails on App creation
Steps to reproduce
Scenario:
Create a local manifest .json ( dumped from a working AAD Enterprise app ), that includes KeyCredentials.
The Key credentials JSON block includes an 'endDate' :
"keyCredentials": [
"customKeyIdentifier": "..................",
"endDate": "2032-10-01T22:20:25Z",
...
)
m365 aad app add --manifest @manifest.json
Error: Expected property 'endDate' is not present on resource of type 'KeyCredential'
Expected results
The Enterprise App is created
Actual results
App fails to be created
Diagnostics
No response
CLI for Microsoft 365 version
v6.1.0
nodejs version
18.9.0
Operating system (environment)
macOS
Shell
zsh
cli doctor
No response
Additional Info
No response

Interestingly, I would have thought the Error implied the Enterprise App did not get created.
However, in fact, it was ( created ).

If I recall it correctly, setting up a secret can be done only after the app was created. Unfortunately, the underlying API doesn't support transactions so if some operation further down the chain fails, you end up with an incomplete app :(

Thanks @waldekmastykarz - Will try simplifying the manifest, and adding keys afterward, as a workaround. Cheers!

Thanks for trying alternatives, @hcsmith. On our end, we consider it a bug, and will fix it shortly.


SCRUM-42 completly functionaning API created for company registration

Fix redundant code for getters and setters and constructers


[pcl:arm64-uwp] build failure

Operating system
Windows 11 x64
Compiler
MSVC
Steps to reproduce the behavior
`.\vcpkg install pcl:arm64-uwp`

Failure logs
install-arm64-uwp-static-md-dbg-out.log
PS C:\Users\adcon\Dev\vcpkg> ./vcpkg install pcl:arm64-uwp
Computing installation plan...
boost-random is only supported on '!uwp', which does not match arm64-uwp. This usually means that there are known build failures, or runtime problems, when building other platforms. To ignore this and attempt to build boost-random anyway, rerun vcpkg with --allow-unsupported.
PS C:\Users\adcon\Dev\vcpkg> ./vcpkg install pcl:arm64-uwp --allow-unsupported
Computing installation plan...
warning: boost-filesystem is only supported on '!uwp', which does not match arm64-uwp. This usually means that there are known build failures, or runtime problems, when building other platforms. Proceeding anyway due to --allow-unsupported.
warning: boost-iostreams is only supported on '!uwp', which does not match arm64-uwp. This usually means that there are known build failures, or runtime problems, when building other platforms. Proceeding anyway due to --allow-unsupported.
warning: boost-random is only supported on '!uwp', which does not match arm64-uwp. This usually means that there are known build failures, or runtime problems, when building other platforms. Proceeding anyway due to --allow-unsupported.
The following packages will be built and installed:

boost-filesystem[core]:arm64-uwp -> 1.82.0#1
boost-foreach[core]:arm64-uwp -> 1.82.0#1
boost-format[core]:arm64-uwp -> 1.82.0#1
boost-graph[core]:arm64-uwp -> 1.82.0#1
boost-interprocess[core]:arm64-uwp -> 1.82.0#1
boost-iostreams[bzip2,core,lzma,zlib,zstd]:arm64-uwp -> 1.82.0#1
boost-math[core]:arm64-uwp -> 1.82.0#1
boost-multi-array[core]:arm64-uwp -> 1.82.0#1
boost-parameter[core]:arm64-uwp -> 1.82.0#1
boost-phoenix[core]:arm64-uwp -> 1.82.0#1
boost-pool[core]:arm64-uwp -> 1.82.0#1
boost-property-map[core]:arm64-uwp -> 1.82.0#1
boost-property-tree[core]:arm64-uwp -> 1.82.0#1
boost-proto[core]:arm64-uwp -> 1.82.0#1
boost-ptr-container[core]:arm64-uwp -> 1.82.0#1
boost-random[core]:arm64-uwp -> 1.82.0#1
boost-serialization[core]:arm64-uwp -> 1.82.0#1
boost-signals2[core]:arm64-uwp -> 1.82.0#1
boost-sort[core]:arm64-uwp -> 1.82.0#1
boost-spirit[core]:arm64-uwp -> 1.82.0#1
boost-thread[core]:arm64-uwp -> 1.82.0#1
boost-tti[core]:arm64-uwp -> 1.82.0#1
boost-uuid[core]:arm64-uwp -> 1.82.0#1
boost-variant[core]:arm64-uwp -> 1.82.0#1
boost-xpressive[core]:arm64-uwp -> 1.82.0#1
bzip2[core,tool]:arm64-uwp -> 1.0.8#4
eigen3[core]:arm64-uwp -> 3.4.0#2
flann[core]:arm64-uwp -> 2019-04-07#6
liblzma[core]:arm64-uwp -> 5.4.1#1
libpng[core]:arm64-uwp -> 1.6.39#1
lz4[core]:arm64-uwp -> 1.9.4#1
pcl[core]:arm64-uwp -> 1.13.0#3
qhull[core]:arm64-uwp -> 8.0.2#4
zlib[core]:arm64-uwp -> 1.2.13
zstd[core]:arm64-uwp -> 1.5.5
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet arm64-uwp...
Restored 0 package(s) from C:\Users\adcon\AppData\Local\vcpkg\archives in 668 us. Use --debug to see more details.
Installing 1/35 boost-filesystem:arm64-uwp...
Building boost-filesystem[core]:arm64-uwp...
warning: -- Using community triplet arm64-uwp. This triplet configuration is not guaranteed to succeed.
-- [COMMUNITY] Loading triplet configuration from: C:\Users\adcon\Dev\vcpkg\triplets\community\arm64-uwp.cmake
-- Using cached boostorg-filesystem-boost-1.82.0.tar.gz.
-- Cleaning sources at C:/Users/adcon/Dev/vcpkg/buildtrees/boost-filesystem/src/ost-1.82.0-5fe71fa1f4.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Users/adcon/Dev/vcpkg/downloads/boostorg-filesystem-boost-1.82.0.tar.gz
-- Using source at C:/Users/adcon/Dev/vcpkg/buildtrees/boost-filesystem/src/ost-1.82.0-5fe71fa1f4.clean
-- Found external ninja('1.11.0').
-- Getting CMake variables for arm64-uwp
-- Configuring arm64-uwp
-- Building arm64-uwp-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:134 (message):
Command failed: C:/Users/adcon/Dev/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/cmake.exe --build . --config Debug --target install -- -v -j21
Working Directory: C:/Users/adcon/Dev/vcpkg/buildtrees/boost-filesystem/arm64-uwp-dbg
See logs for more information:
C:\Users\adcon\Dev\vcpkg\buildtrees\boost-filesystem\install-arm64-uwp-dbg-out.log

Call Stack (most recent call first):
installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_build.cmake:74 (vcpkg_execute_build_process)
installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_install.cmake:16 (vcpkg_cmake_build)
installed/x64-windows/share/boost-build/boost-modular-build.cmake:140 (vcpkg_cmake_install)
ports/boost-filesystem/portfile.cmake:12 (boost_modular_build)
scripts/ports.cmake:147 (include)
error: building boost-filesystem:arm64-uwp failed with: BUILD_FAILED
Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+boost-filesystem
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?title=[boost-filesystem]+Build+error&body=Copy+issue+body+from+C%3A%2FUsers%2Fadcon%2FDev%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md
Additional context
We are trying to leverage the Point Cloud Library on the Microsoft Hololens 2, which is an arm64 based processor.  We have a custom DLL project that references PCL, and we want to make that available to our Unity MRTK application C# code. It seems like the proper way in for this is UWP.  Every other option looks really hacky, or doesn't work from what we've seen so far.

I guess pcl really doesn't support uwp, but this might be better asked upstream.

From what I can see it fails already in building boost dependency:
..\src\operations.cpp(1340): error C3861: 'get_proc_address': identifier not found
..\src\operations.cpp(2184): error C3861: 'CreateFileW': identifier not found
..\src\operations.cpp(4349): error C2039: 'GetWindowsDirectoryW': is not a member of '`global namespace''
..\src\operations.cpp(4349): error C3861: 'GetWindowsDirectoryW': identifier not found
..\src\operations.cpp(4359): error C2039: 'GetWindowsDirectoryW': is not a member of '`global namespace''
..\src\operations.cpp(4359): error C3861: 'GetWindowsDirectoryW': identifier not found

So this seems like boost doesn't support arm64-uwp ?

UWP doesn't support the desktop APIs for file access. This blocks many packages which aren't adapted to the alternatives. This include pcl's dependency boost-filesystem.

Seems that it has been working, with: https://github.com/microsoft/vcpkg/pull/12762?

Is there any way to reduce dependencies or can I triage historical versions
to see if one will succeed?
It seems like the best arm64 uwp support existed back when the consumer
focused Windows Phone was around. HoloLens 2 has been more business
focused, and may not have encouraged as much arm64 + uwp adoption.
On Wed, May 31, 2023 at 1:35 AM Lars Glud @.***> wrote:

Seems that it has been working, with: #12762
https://github.com/microsoft/vcpkg/pull/12762?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vcpkg/issues/31655#issuecomment-1569523826,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOLLQNLNGKYHBFWBKEXXLDXI3KA7ANCNFSM6AAAAAAYQ4XRRE
.
You are receiving this because you authored the thread.Message ID:
@.***>

--

Andrew Conklin
https://linkedin.com/in/adconk
202-288-5595 <(202)%20288-5595>

Thanks for posting this issue. I think this issue could be closed, you could refer to the suggestion from https://github.com/PointCloudLibrary/pcl/issues/5732#issuecomment-1576268447.


Module '"@skeletonlabs/skeleton' has no exported member 'storePopup"

Link to the Page
https://www.skeleton.dev/utilities/popups
Describe the Issue
Hi,
I'm following the docs for popup utility here: https://www.skeleton.dev/utilities/popups
However, I'm getting a "Module '"@skeletonlabs/skeleton' has no exported member 'storePopup" error for both the popup and popupStore.

Are you able to create a Pull Request with the fix?
None

@carlskii We put out a quick hotpatch to resolve this. Make sure you're using the x.x.5 version here:
https://github.com/skeletonlabs/skeleton/releases/tag/0.132.5

Hi, yes I'm already using v0.132.5  - same problem.

Could you share a repository or a minimum reproduction?

Sorry first push didn't have the popup code - just re-pushed

Hmm, I'm not sure what's up. The export is there and I'm seeing it when testing in a new project:

I see the export present when I browse<EMAIL_ADDRESS>
Can you run npm list in your project directory within your terminal and provide the output here please. I know your package.json lists the .5 version, just want to confirm.

You're missing floating-ui in your package.json.

Ahh, this is why early morning debugging is bad :) Thanks Sarenor!

OK - So fixed that it was installed, just not in the package.json.
Getting this now.
proxy.js?v=5c081724:15 [HMR][Svelte] Unrecoverable HMR error in <Root>: next update will trigger a full reload
logError @ proxy.js?v=5c081724:15
Proxy<Root> @ proxy.js?v=5c081724:380
initialize @ client.js?v=5c081724:432
_hydrate @ client.js?v=5c081724:1757
await in _hydrate (async)
start @ start.js:22
(anonymous) @ (index):4558
Promise.then (async)
(anonymous) @ (index):4557
+page.svelte? [sm]:35 Uncaught (in promise) ReferenceError: popup is not defined
    at mount (+page.svelte? [sm]:35:48)
    at targetCmp.$$.fragment.m (svelte-hooks.js?v=5c081724:291:24)
    at mount_component (index.mjs:1949:26)
    at Object.mount [as m] (root.svelte? [sm]:42:82)
    at Object.mount [as m] (+layout.svelte? [sm]:9:53)
    at Object.mount [as m] (AppShell.svelte:53:81)
    at mount_component (index.mjs:1949:26)
    at mount (+layout.svelte? [sm]:46:8)
    at targetCmp.$$.fragment.m (svelte-hooks.js?v=5c081724:291:24)
    at mount_component (index.mjs:1949:26)

Try:
import { popup } from '@skeletonlabs/skeleton';

instead of
import type { popup } from '@skeletonlabs/skeleton';

OK so that fixed that problem, no I'm seeing:
proxy.js?v=5c081724:15 [HMR][Svelte] Unrecoverable HMR error in <Root>: next update will trigger a full reload
logError @ proxy.js?v=5c081724:15
Proxy<Root> @ proxy.js?v=5c081724:380
initialize @ client.js?v=5c081724:432
_hydrate @ client.js?v=5c081724:1757
await in _hydrate (async)
start @ start.js:22
(anonymous) @ (index):4558
Promise.then (async)
(anonymous) @ (index):4557
floating-ui.dom.browser.mjs:6 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'ownerDocument')
    at getWindow (floating-ui.dom.browser.mjs:6:39)
    at isNode (floating-ui.dom.browser.mjs:59:27)
    at getNodeName (floating-ui.dom.browser.mjs:36:10)
    at getParentNode (floating-ui.dom.browser.mjs:297:7)
    at getNearestOverflowAncestor (floating-ui.dom.browser.mjs:313:22)
    at getOverflowAncestors (floating-ui.dom.browser.mjs:330:30)
    at autoUpdate (floating-ui.dom.browser.mjs:593:202)
    at popup (popup.js:188:5)
    at mount (+page.svelte? [sm]:33:48)
    at targetCmp.$$.fragment.m (svelte-hooks.js?v=5c081724:291:24)

Is there any chance you can post a working example.

@carlskii we're actively working on some improvements to our documentation.
Maybe give the new popup section a glance?
https://dev.skeleton.dev/utilities/popups
Every documentation section includes a "page source" option, so here's what that looks like:
https://github.com/skeletonlabs/skeleton/blob/master/src/routes/(inner)/utilities/popups/%2Bpage.svelte
Our doc site is built on top of Skeleton, so it's a functional Skeleton app. Just note we reference imports locally rather than through the @skeletonlabs/skeleton page, so be sure to adjust accordingly.

Thanks. I just did this. In the https://github.com/skeletonlabs/skeleton/blob/master/src/routes/(inner)/utilities/popups/%2Bpage.svelte where does DocsShell and import { DocsFeature, type DocsShellSettings } come from ?

@carlskii Those are custom feature for our documentation page structure. You can disregard those. Just focus on the items that make use of popups

Uncaught (in promise) TypeError: Cannot destructure property 'computePosition' of 'get_store_value(...)' as it is undefined.
"@floating-ui/dom": "^1.4.5",
"@skeletonlabs/skeleton": "^2.4.0",
"@skeletonlabs/tw-plugin": "^0.2.3",

popup.js file
export const storePopup = writable(undefined);
export function popup(triggerNode, args) {
const { computePosition, autoUpdate, offset, shift, flip, arrow, size, autoPlacement, hide, inline } = get(storePopup);
....

While I appreciate the comment, this issue is incredibly old and the solution you found is also very well documented: https://www.skeleton.dev/utilities/popups#installation
Are you facing any other issues @marke-dev ?


Brakeman dynamic render path error when finding records inside components

Steps to reproduce
Hi! I’m seeing an issue specifically when working with view_components and brakeman. Basically, the way we’re using view_components is to create reusable components (like buttons for example) so that we can plug and play these onto a page easily.
However, we’re encountering an issue if we want to send in a record to the component. I believe this has to do with how view_component is monkey patching the render method. Essentially, any time we try to send in something to do with params or with a record that’s found with params, we’re seeing a dynamic render path error. I’ve pasted an example below, where we have a button to component that accepts a path as a param.
class Owlery::ButtonToComponent < ApplicationComponent
  def initialize(name = nil, options = nil, html_options = {})
    @name = name
    @options = options
    @html_options = html_options
  end

<%= render Owlery::ButtonToComponent.new(a_store_path(@store), nil, {is_color: 'dark', is_outlined: true, method: :delete}) do %>
 A button
<% end %>

{
 "warning_type": "Dynamic Render Path",
 "warning_code": 15,
 "check_name": "Render",
 "message": "Render path contains parameter value",
 "file": "<our_file>",
 "line": 14,
 "link": "https://brakemanscanner.org/docs/warning_types/dynamic_render_path/",
 "code": "render(action => Owlery::ButtonToComponent.new(a_store_path(Store.find(params[:id]), nil, :is_color => \"primary\", :method => :delete), {})",

Normally, render can tell if you’re grabbing a record and doesn’t throw an error. But because we’re rendering a component with fairly complex logic that ALSO sends in a record found via params, brakeman can’t parse what’s happening, and thus throws this dynamic render path error.
This can easily be fixed if we add an exception to our brakeman list any time this happens. The brakeman error that this produces is a weak confidence error, so it’s less worrying. But the issue I have with that is that it’s not a sustainable solution. As our usage of components grows we’re going to need to send them records that were found via params. Having a growing list of brakeman exceptions defeats the purpose of fixing brakeman issues - especially if the habit becomes ‘oh that’s known, just create an exception and move on’.
Expected behavior
You should be able to send in a record found in the controller via params to the view component without brakeman throwing a dynamic render path warning.
Actual behavior
Brakeman throws a warning when you send in a record you found into your view component
System configuration
Rails version:  <IP_ADDRESS>
Ruby version: 2.6.5
Gem version: 2.24.0

@ChantalForget thank you for taking the time to file this issue! I appreciate your detailed explanation of the problem.
From what I can tell, it feels like brakeman needs to be updated to support the rendering of objects in render calls,  which is now part of the official Rails API: https://guides.rubyonrails.org/layouts_and_rendering.html#rendering-objects. Perhaps it might be worth filing an issue on brakeman?
If there are changes we can make to the monkey patch in view_component to appease brakeman's warnings, I'd definitely be open to making them.

@ChantalForget thank you for taking the time to file this issue! I appreciate your detailed explanation of the problem.
From what I can tell, it feels like brakeman needs to be updated to support the rendering of objects in render calls,  which is now part of the official Rails API: https://guides.rubyonrails.org/layouts_and_rendering.html#rendering-objects. Perhaps it might be worth filing an issue on brakeman?
If there are changes we can make to the monkey patch in view_component to appease brakeman's warnings, I'd definitely be open to making them.

See related issue: https://github.com/presidentbeef/brakeman/issues/1529

See related issue: https://github.com/presidentbeef/brakeman/issues/1529

@anthonyshchang thanks for the report. Might you file this issue with the brakeman folks to see what they think? My hunch is that the issue is on their end ❤


require('css').parse does not work in Typescript

let css = require('css');
let obj = css.parse('body { font-size: 12px; }');

 TypeError: css.parse is not a function

However, the following works just fine:
const parse = require('css/lib/parse');
const obj = parse('body { font-size: 12px; }');

Honestly this seems more like a Typescript issue, but I think it could be simpler to solve at the package level.

You need to use import not require


An easy way to translate slick-sr-only dots ?

Dear Jason,
Thanks for your amazing accessible library!
I would like to use it on multi languages website but I need to translate wording inside dots Go to slide 9
Do you have any suggestions or API able to do this?
Thanks a lot :)

Hey Florian! Glad you're enjoying it!
At the moment, accessible-slick doesn't allow for custom slide dot markup to be provided the way you can for the previous/next arrows (using the prevArrow and nextArrow options), but you can freely modify whatever text you want by directly modifying the strings in the DOM after the library has loaded!
Here is a snippet that uses the init event to wait for the accessible-slick library to finish initializing, then loops through each slide dot element in the DOM and updates its inner text string with some translated text. Apologies for the auto-translated text, I'm sure it's not perfect :P
$('.carousel').on('init', function(e, slick) {
  slick.$dots[0].querySelectorAll('button .slick-sr-only').forEach(function(buttonText) {
    buttonText.innerText = buttonText.innerText.replace('Go to slide', 'Allez à la diapositive');
  });
});

You can test this snippet for yourself in this live example: https://codepen.io/A360/pen/e9fdac8bc02e1980b69165222e37f95c?editors=0010
Hope that helps!

Dear Jason, this is absolutely perfect!
Would be happy to contribute to your project if needed!
Thanks for your help.
Florian

Great!
Thanks for that! My hope is that there isn't much to do since this repo is just a thin layer on top of the original Slick package, but there are one or two minor bugs that I'm aware of. I'll look into capturing and tagging those issues as "bug" and "help wanted" soon. Feel free to get involved in those threads when you see them!