read full partition in KEEP_LATEST_FILE_VERSIONS Strategy when clean files

i use cow table，and 'clean-policy' = 'KEEP_LATEST_FILE_VERSIONS'
with table's parition increased, the flink task became instability

yes. it might get costly w/ the scale or if you plan to retain lot of file versions. I can file a jira to enhance this. but might need some intelligent design around this.

yes. it might get costly w/ the scale or if you plan to retain lot of file versions. I can file a jira to enhance this. but might need some intelligent design around this.

ok thanks! because this was in our production environment and is really affect our flink task. so we solved it through a simple treatment. and we are looking forward this intelligent design in next release. then we will upgrade.
here is our simple treatment

the same case for compact too
2022-08-31 12:35:33,278 INFO  org.apache.hudi.table.action.compact.HoodieCompactor         [] - Compacting s3:// with commit<PHONE_NUMBER>3532928
2022-08-31 12:35:34,018 INFO  org.apache.hudi.table.action.compact.HoodieCompactor         [] - Compaction looking for files to compact in [19700101, 20220511, 20220512, 20220513, 20220514, 20220515, 20220516, 20220517, 20220518, 20220519, 20220520, 20220521, 20220522, 20220523, 20220524, 20220525, 20220526, 20220527, 20220528, 20220529, 20220530, 20220531, 20220601, 20220602, 20220603, 20220604, 20220605, 20220606, 20220607, 20220608, 20220609, 20220610, 20220611, 20220612, 20220613, 20220614, 20220615, 20220616, 20220617, 20220618, 20220619, 20220620, 20220621, 20220622, 20220623, 20220624, 20220625, 20220626, 20220627, 20220628, 20220629, 20220630, 20220701, 20220702, 20220703, 20220704, 20220705, 20220706, 20220707, 20220708, 20220709, 20220710, 20220711, 20220712, 20220713, 20220714, 20220715, 20220716, 20220817, 20220818, 20220819, 20220820, 20220821, 20220822, 20220823, 20220824, 20220825, 20220826, 20220827, 20220828, 20220829, 20220830, 20220831] partitions

I have made some perf fixes to the full cleaning when metadata is enabled.
https://issues.apache.org/jira/browse/HUDI-4749
Also, I have proposed a hybrid cleaning policy to enhance cleaning by LATEST_FILE_VERSIONS : https://issues.apache.org/jira/browse/HUDI-4750

oh, just now looking at your solution. it might have some corner cases. For eg, if you choose cleaner policy to be LATEST_FILE_VERSION, and set commits retained to 10 (this config is supposed to work only for LATEST_COMMITS policy).
after 15 commits, we will consider only the last 10 commits to do clean up, what incase some file group never got updated from C5 to C15. So, those file groups should also be considered right when we are looking to schedule cleaning based on  FILE_VERSIONS.
Open to jam more on this and find a good enhancement.

In my opinion, read full partition in KEEP_LATEST_FILE_VERSIONS strategy when clean files is required anyway, since the commit instant will be cleaned up, you never know how many slices are in the fileGroup. All we can do is speed up listing partitions or files with metadata as far I am concerned
However, for KEEP_LATEST_COMMITS strategy, you only need to read the partitions that exist in the latest replate commits , rhat's what hudi is doing now.

Closing it as we have a fix under review.


Possible bug with negative lookahead?

Describe the bug
This bug report for electron-reloader could be a bug with chokidar, but I'm not sure. https://github.com/sindresorhus/electron-reloader/issues/22
Versions (please complete the following information):
I'm not sure which version electron-reloader is using
To Reproduce:
electron-reloader claims that it uses chokidar for its ignore handling,
require("electron-reloader")(module, { ignored: [/^(?!(web)).*/] });
which results in the behavior described in this issue:
I'm seeing weird behavior, for example changes to my .exports directory do not trigger hot-reloads but everything else does. I thought this was odd so I added a directory .test and changes to it don't trigger hot-reloads, while changes to a new directory test do.
Expected behavior
Additional context
Sorry for not diving deeper into this, if electron-reloader doesn't respond to the issue I linked above and I have some time I'll dive into their source code, see how they're using chokidar, and edit this issue to include concise chokidar reproduction.

Editing, I've consolidated the issue.


Attempting to message someone in a multiparty DM has inconsistent behavior

Describe the bug, optionally with screenshots
DMing individual retrieves multiparty DM individual is also in when the multiparty DM is more recent.
To Reproduce
Steps to reproduce the behavior:

Have multiparty DM with someone in it that you haven't messaged since the multiparty DM was created
Attempt to message individual using 'New Message' flow. Enter @p, hit enter.
Multiparty DM loads instead of individual DM
Using left nav list of DMs, scroll to individual DM with @p entered, message individual
Repeat step 2.
Individual DM loads

Expected behavior
I would expect the individual DM to be loaded.
Additional context:

may be related to this issue.

@patosullivan has a repro--he has never DM'd with @sigilante but is in a multi-DM with him; entering Neal's @p into a new DM routes Pat to the multi-DM.

sneaky!


Migrate build to Spring Develocity Conventions extension

This PR migrates the build to use Spring's Develocity Conventions Maven extension.
https://github.com/spring-io/develocity-conventions
With this, explicit configuration of the Develocity Maven extension is no longer required, as all configuration is encapsulated within the Spring extension.
Additionally, build cache authentication now uses the Develocity access key, so separate build cache credentials are no longer required. The DEVELOCITY_ACCESS_KEY environment variable is enough for both build scan publishing and remote build cache access.

Thanks. That's merged.


can't control epick gripper

hello，i have followed the steps try to control rpick by ROS, after i run command 'rosrun robotiq_vacuum_grippers_control RobotiqVacuumGrippersRtuNode.py /dev/ttyUSB0', the light turns to green rather than blue that showed in the vedeo, then ,i run "rosrun robotiq_vacuum_grippers_control RobotiqVacuumGrippersSimpleController.py", whatever command i use ,the epick didn't work. but i can use ur screen to control it. could anyone help me?

add that when i echo this message 'RobotiqVacuumGrippersRobotInput', every number of arguments is '0', and never changed whatever command i send, the message 'RobotiqVacuumGrippersRobotOnput' has changed after i sent command. the outside light is blue, the USB's light is green, i think it is right, sorry.

i find the difference from the video, i connect my epick with ur robot by I/O Coupling connector directly, and i can use the ur screen to control it. but i want to use ros to control it, so i use the micro-USB port connect the epick with my computer. i didn't change the I/O port like your video shows. can i control it by Micro-USB directly?


README.md: Adding dependencies (+dev) check badge

Detects if the dependencies are up to date and displays if there are security vulnerabilities in it.
Information about the badge are here and about the repo are located here.
To identify any the security issues they are using: nodesecurity.io
Slogan of it is:

Watching your Node.js Dependencies.

Thank your for your PR we are now using 'GitHub security alert digest' the track vulnerabilities in dependencies .


Support lines and stroke attributes

I added support for the attributes stroke-linecap, stroke-linejoin, stroke-miterlimit and stroke-dasharray. I also included a new example image. Let me know what you think.

Thanks!
Code looks good. But there’s just that issue with attribute inheritance.

@fjolnir thank you very much for your feedback! I've added another SVG as test case to fix the attribute inheritance problem and to my surprise everything worked straight away.
My understanding is that this together with this already ensures that every path inherits the group attributes as default values.
So I think everything works as expected - or did I still miss your point?
I was tempted to add screenshot tests to be able to easily ensure correctness of future changes, but figured that's would blow the scope of this PR.

Yeah, you're right. Thanks for checking!


QoS 1 and 2 seem to malfunction (testing with malaria)

Environment

OS:
Linux Obuntu 14.04 LTS
On Amazon ECS - 4 cores, 16gb.

Erlang/OTP:
[{release,"Erlang/OTP","19","8.3",
[{kernel,"5.2","/usr/lib/erlang/lib/kernel-5.2"},
{stdlib,"3.3","/usr/lib/erlang/lib/stdlib-3.3"},
{sasl,"3.0.3","/usr/lib/erlang/lib/sasl-3.0.3"}],
permanent}]

EMQ:
Latest Master 2.2
compiled from  https://github.com/emqtt/emq-relx.git

Description
Testing Qos 1 and Qos 2 with Malaria
yields that only QoS 0 is stable and all messages arrive to subscribers.
With Qos 1 and Qos 2 not all messages are received...
and the Malaria subscriber simply waits for many messages
while the subscriber says it's finished.
It seems like the messages are simply not routed to all the clients
and the dashboard does not report any of these anomalies.
Does EMQ have tests that make sure all units functioning correctly?
Reproduce:
malaria subscribe -n 1000 -N 20 --host emq.net -q 1
malaria publish -t -n 1000 -P 20 --host emq.net -q 1
:fails.
malaria subscribe -n 1000 -N 20 --host emq.net -q 2
malaria publish -t -n 1000 -P 20 --host emq.net -q 2
- fails.
malaria subscribe -n 1000 -N 20 --host emq.net -q 0
malaria publish -t -n 1000 -P 20 --host emq.net -q 0
- Success.

@syberkitten Thanks for your report. @huangdan will benchmark EMQ with Malaria tool and try to reproduce the issue.

Adding to the report, first try with 10 workers, 20 seems too much, at least on my local machine.
so, 10 should not be clogging the bandwidth, but it still fails:
The following example creates sends 1000 messages for every worker (10k messages)
malaria subscribe -n 1000 -N 10 --host emq.net -q 1
malaria publish -t -n 1000 -P 10 --host emq.net -q 1
ps: Also nodjes Mosca broker fails these tests, the only broker that did pass
was verneMQ. both Qos1/2

@syberkitten Tune the two parameters in etc/emq.conf:
mqtt.mqueue.max_length = 0
mqtt.session.max_awaiting_rel = 0

By default, the EMQ broker will queue 1000 Qos1/2 messages for each session to avoid memory overload.
The full benchmark report for EMQ 2.0: http://emq-xmeter-benchmark-en.readthedocs.io/en/latest/

Yes, this fixes the problem perfectly.
Thank you 👍


List of "printer-state-reason"s in api-filter.html incomplete/outdated

Version: 2.2-feature
CUPS.org User: stefanbruens
Table 2 contains a excerpt of RFC2911 printer-state-reasons.
This list has several issues:

RFC2911 is not mentioned as source for this list
Several reasons from RFC2911 are missing
The list contains reasons deprecated in PWG5100.9
It is not coordinated with ipp-spec.html, which explicitly references RFC2911

Both api-filter.html and ipp-spec.html should reference a common document referencing the IANA list [1], RFC2911, PWG5100.9 [2] and PWG5100.13 [3].
This documentation should also mention which reasons are supported under which circumstances (e.g. is "STATE: +cleaner-life-over" (PWG5100.13) accepted?)
[1] http://www.iana.org/assignments/ipp-registrations/ipp-registrations.xhtml#ipp-registrations-4
[2] http://ftp.pwg.org/pub/pwg/candidates/cs-ippstate10-20090731-5100.9.pdf
[3] http://ftp.pwg.org/pub/pwg/candidates/cs-ippjobprinterext3v10-20120727-5100.13.pdf

Been a while, but in response to Stefan's last comment the 5100.9 wording is a known issue and subject to a future errata update by the PWG IPP workgroup. The proposed new wording will recommend that Printers SHOULD report both the generic and the specific keywords to propose interoperability.

[master 8d7608e] Add reference to IANA registry for printer-state-reasons values.


fix: project name error

I noticed that the project name was incorrectly written as XTMP instead of XMTP in the documentation. PR corrects the typo to ensure accuracy and consistency throughout the project materials. Please review to ensure the quality and accuracy of the documentation.

I already have a merged pull request with the same error in another repository. https://github.com/xmtp/libxmtp/pull/1140


Add kafka connection info to worker containers

Requires https://github.com/ManageIQ/manageiq-pods/pull/390
cc @agrare

Jansa backport details:
$ git log -1
commit ef6661d5b722e444433792d3bcd24504e7aa0b1d
Author: Brandon Dunne<EMAIL_ADDRESS>Date:   Mon Mar 30 13:56:16 2020 -0400

    Merge pull request #20000 from carbonin/add_kafka_for_container_workers

    Add kafka connection info to worker containers

    (cherry picked from commit 7cb53851b26fa9fcad10338060ee31f7bc2acb7c)


📑 Feature Request: Addition of a Dockerfile

IMPORTANT TO CHECK BEFORE ISSUE

[X] You check that same issue is not present in the repository
[X] You have read contribution guidelines and rules

Please describe your feature request related to a problem?
We don't have to install anything extra on our local machine instead all the things will be installed into a container and we can install and run everything in one command.
Describe your solution to problem
@rahulsainlll Addition of the docker file will help in smoother running of the project locally.
Describe alternatives you have considered
No response
Additional context
No response
Add Relevant Screenshot (if available)
No response

This issue has already been assigned to someone so closing this!


editor.tabSize seems not work

Issue Type: Bug

open workspace settings
set tabSize:2
open a javascript file (tabsize is 4), press alt+shift+f to format

expect: the tabSize become 2.
result: the tabSize is still 4.
This bug appeared after I updated to 1.23.0
VS Code version: Code 1.23.0 (7c7da59c2333a1306c41e6e7b68d7f0caa7b3d45, 2018-05-03T15:23:19.356Z)
OS version: Linux x64 4.13.0-38-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 3119)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: unavailable_softwarevideo_encode: enabledvpx_decode: unavailable_softwarewebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
7.64GB (0.92GB free)

Process Argv
/usr/share/code/code .

Screen Reader
no

VM
0%

Extensions: none

@mjbvz does ts formatter take tabSize into account?

Yes we do use the tabsize for formatting. The problem is that VS Code tells us that the tab size for the current editor is still four. I believe this is the same problem / question as #48440
Try setting:
"editor.detectIndentation": false,
"editor.tabSize": 2

To force a tabsize of 2

Try setting:
"editor.detectIndentation": false,
"editor.tabSize": 2

It works for me. Thanks.


Concise not working if two sets

Hey,
the concise display of the openinghours do not work, if the company has a break. It will display all of the weekdays. I managed to find the potential source:
openinghours/templatetags/openinghours_tags.py
lines 141 - 150
    for day in days:
        if 'hours' not in current_set.keys():
            current_set = {'day_names': [day['name']],
                           'hours': day['hours']}
        elif day['hours'] != current_set['hours']: # note 1
            concise_days.append(current_set)
            current_set = {'day_names': [day['name']],
                           'hours': day['hours']}
        else:
            current_set['day_names'].append(day['name'])

Note 1: Here, if you have two sets, it will change current_set. Thus, day['hours'] != current_set['hours'] will always be true for those cases. It should check, if there is a day['hours'] in concise_days and do actions according to it existence.
Do you guys have a solution for this? I am struggling with it.

Thanks for the report, @oesah! We will look into this


Bump engines to node 10

Coverage remained the same at 97.778% when pulling 376b80dd5e836faea4c37229e858f5378ee14272 on node-10 into 14ca95fd925d54682f797eb97604d43b5bcc1b9b on master.

Coverage remained the same at 97.778% when pulling 376b80dd5e836faea4c37229e858f5378ee14272 on node-10 into 14ca95fd925d54682f797eb97604d43b5bcc1b9b on master.

Coverage remained the same at 97.778% when pulling 376b80dd5e836faea4c37229e858f5378ee14272 on node-10 into 14ca95fd925d54682f797eb97604d43b5bcc1b9b on master.


Published version

Hi everyone, i would like you guys to make sure that the new version is published.. i tried to insert this
plugins {
  id "io.swagger.core.v3.swagger-gradle-plugin" version "2.1.3-SNAPSHOT"
}

but i get an error. So i've tried to go directly to the gradle URL that consults and this version is not published yet.

snapshots are not published, you would use latest 2.1.2 https://plugins.gradle.org/plugin/io.swagger.core.v3.swagger-gradle-plugin


Fix: Use a Python Version Compatible with Sublime Text 4

Addresses issue #158.

Memo: Without checking.


RNfetchBlob cannot upload video

🐛 Bug Report
RNfetchBlob upload video to API failed
To Reproduce
-> npm install --save rn-fetch-blob
-> react-native link
Expected Behavior
Can upload video to API
Code Example
        ImagePicker.openPicker({
            mediaType: "video",
        }).then((video) => {
            this.setState({
                VideoSource: {uri: video['path']},
                data: video.data,
            });
        }).catch((err) => {

        })
    }

uploadToServer = () => {
        RNFetchBlob.fetch('POST', 'xxx.xxx.xxx', {
            Authorization: "Bearer access-token",
            otherHeader: "foo",
            'Content-Type': 'multipart/form-data',
        },
        [
            {name: 'video', filename: 'image.png', type: 'image/png', data: this.state.data},
        ]).then((resp) => {
            let Obj = JSON.parse(resp.data);
            let predict = Obj.success;

            Alert.alert(resObj);
        }).catch((err) => {
            console.log(err);
        })
    }

Environment
React Native Environment Info:
System:
OS: Windows 10
CPU: (4) x64 Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz
Memory: 3.24 GB / 7.87 GB
Binaries:
Yarn: 1.13.0 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
IDEs:
Android Studio: Version  <IP_ADDRESS> AI-181.55<IP_ADDRESS>56338

Hello there 👋! Thanks for posting that issue, however, it seems this should be posted directly on the library issues as the code concerned is not part of this repo.
https://github.com/joltup/rn-fetch-blob/issues
I'll close this issue, but if you find something directly related to react-native, feel free to comment and it'll be opened again.


fix: results are not updated after a re-render

Fix the result image disappears after a re-render. It will happen if the response doesn't include a unique id for each entry.

Feel free to message me in Slack about this. Am I correct in understanding that we're getting results back from the engine where each result is expected to have an _id but sometimes doesn't?

Feel free to message me in Slack about this. Am I correct in understanding that we're getting results back from the engine where each result is expected to have an _id but sometimes doesn't?
I ask because this sounds like a bug in the engine which would be worth fixing.

@wwalser your intuition is right. We could fix that by including fields:'' in the body request so the response will come with _id. But I will wait for the confirmation from Dave if we should do it in the frontend.


Localhost set up Polymer 1.0

I am trying to set up polymer 1.0 on my Apple Mac.
I have been able to install Git, Node JS, Atom and Bower fine but I am not getting anything on any local host.
I have followed instructions on Polymer Project website but when running the polymer serve command in terminal in project directory I get nothing at localhost:8080/components/icon-toggle/demo/
I have attached the response I get from the polymer serve command in terminal. I have also tried to navigate to the link shown in the image but get a page not found error.
Quite new to this so any help is largely appreciated.

What kind of project do you have? See docs for element project and application project.

I would like to set up an elements project I believe. I need to use polymer 1.0
The polymer programming I have done so far has been using HTML files and importing bower components at the start of each document then calling an instance of that component.

Probably port 8080 is already in use, so polymer serve is using 8081.
Try hitting localhost:8081

Returns "not found"

update: If I navigate to
http://localhost:8081/polymer-first-elements/demo/index.html
I get a white screen with some bower element errors (see attachment)
I'm fairly sure I have installed bower correctly (see attachment)
Again all help appareciated thank you

Looks like port 8081 since you're having errors
If you're following google codelabs then you have a wrong path
localhost:8081/components/icon-toggle/demo/
as per this doc says
https://www.polymer-project.org/1.0/docs/start/reusableelements.html#local-dependencies

That produces the right page. Looks like Polymer serve is working now thank you all!
What is the best way of setting up a local host to create my own custom elements? Previously I have run a run.bat file with some Go programming code to set up a local host with an index.html file
Can I set something up that will work in a similar way?
Thanks again

If I get it right, you can follow the same structure, in components folder, to build your own component. Then you can publish or wrap it for your own use.
https://www.webcomponents.org/publish

It sounds like you got the help you were looking for so I'm going to close this issue.


[POAE7-961] fix null pointer issue when offheap enabled.

What changes were proposed in this pull request?
fix null pointer exception when update long array, with offheap enabled.
How was this patch tested?
N/A
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@winningsix Please take a look and help merge.


chore: increase overflow width to fill container

Current dependencies on/for this PR:

next

PR #235

PR #236

PR #237

PR #238

PR #239

PR #240

PR #241   (this PR)

This comment was auto-generated by Graphite.


Units, legend

I think it would be helpful if the generated graph had units and a legend for the lines.
Just started using this fine tool, and I don't really understand what, say, the lines represent.
So consider this a small feature request.

The lines represent the value of each vector, they have no units.

Alright so no units. But the lines have to mean something, like loss, strength, etc?

The vector values are used to calculate the strength and magnitude of the embedding.


Scalar if

Adds support for regular if-statements (with boolean condition).
@field_operator(backend=fieldview_backend)
def both_branches_return(inp: Field[[IDim, JDim], float64], condition1: bool, condition2: bool):
    if condition1:
        tmp1 = inp
        if condition2:
            return tmp1 + 1.0
        result = tmp1 + 2.0
    else:
        result = inp + 3.0
    return result

Including extended SSA pass supporting Ifs.
Superseeds #972

@egparedes This PR is ready for review (after #1250 is merged). The files single_static_assign.py and test_single_static_assign.py only appear here until we merge #1250.


Secret templater fails when the secret key is using "-" in its name

What happened:
bad character U+002D '-'
What you expected to happen:
How to reproduce it:
Environment:

piped version:
control-plane version:
Others:

This is caused by the spec for go template.


a new job request sometimes returns error 500

See the attached log. I think this fortunately fixes itself after some retries.
systemd[1]: Started OSBuild Composer Remote Worker (composer.osbuild.org:8700).
osbuild-worker[461968]: 2020/11/24 04:19:50 Composer configuration:
osbuild-worker[461968]: [koji]
osbuild-worker[461968]:   [koji."brewhub.stage.engineering.redhat.com"]
osbuild-worker[461968]:     [koji."brewhub.stage.engineering.redhat.com".kerberos]
osbuild-worker[461968]:       principal =<EMAIL_ADDRESS>osbuild-worker[461968]:       keytab = "/etc/osbuild-worker/client.keytab"
osbuild-worker[461968]: Waiting for a new job...
osbuild-worker[461968]: Running 'osbuild-koji' job add0de98-e9f0-4eff-9c47-f7133b2b76bd
kernel: XFS (loop1): Mounting V5 Filesystem
kernel: XFS (loop1): Ending clean mount
kernel: XFS (loop1): Unmounting Filesystem
systemd[1]: Starting SSSD Kerberos Cache Manager...
systemd[1]: Started SSSD Kerberos Cache Manager.
sssd[kcm][483401]: Starting up
osbuild-worker[461968]: 2020/11/24 04:28:36 Job add0de98-e9f0-4eff-9c47-f7133b2b76bd finished
osbuild-worker[461968]: Waiting for a new job...
osbuild-worker[461968]: 2020/11/24 04:28:42 error requesting job: 500 — Internal Server Error
systemd[1]: osbuild-remote-worker@composer.osbuild.org:8700.service: Main process exited, code=exited, status=1/FAILURE
systemd[1]: osbuild-remote-worker@composer.osbuild.org:8700.service: Failed with result 'exit-code'.
systemd[1]: osbuild-remote-worker@composer.osbuild.org:8700.service: Service RestartSec=10s expired, scheduling restart.
systemd[1]: osbuild-remote-worker@composer.osbuild.org:8700.service: Scheduled restart job, restart counter is at 15.
systemd[1]: Stopped OSBuild Composer Remote Worker (composer.osbuild.org:8700).
systemd[1]: Started OSBuild Composer Remote Worker (composer.osbuild.org:8700).
osbuild-worker[483408]: 2020/11/24 04:28:52 Composer configuration:
osbuild-worker[483408]: [koji]
osbuild-worker[483408]:   [koji."brewhub.stage.engineering.redhat.com"]
osbuild-worker[483408]:     [koji."brewhub.stage.engineering.redhat.com".kerberos]
osbuild-worker[483408]:       principal =<EMAIL_ADDRESS>osbuild-worker[483408]:       keytab = "/etc/osbuild-worker/client.keytab"
osbuild-worker[483408]: Waiting for a new job...
osbuild-worker[483408]: 2020/11/24 04:32:41 error requesting job: 500 — Internal Server Error
systemd[1]: osbuild-remote-worker@composer.osbuild.org:8700.service: Main process exited, code=exited, status=1/FAILURE
systemd[1]: osbuild-remote-worker@composer.osbuild.org:8700.service: Failed with result 'exit-code'.
systemd[1]: osbuild-remote-worker@composer.osbuild.org:8700.service: Service RestartSec=10s expired, scheduling restart.
systemd[1]: osbuild-remote-worker@composer.osbuild.org:8700.service: Scheduled restart job, restart counter is at 16.
systemd[1]: Stopped OSBuild Composer Remote Worker (composer.osbuild.org:8700).
systemd[1]: Started OSBuild Composer Remote Worker (composer.osbuild.org:8700).
osbuild-worker[483420]: 2020/11/24 04:32:51 Composer configuration:
osbuild-worker[483420]: [koji]
osbuild-worker[483420]:   [koji."brewhub.stage.engineering.redhat.com"]
osbuild-worker[483420]:     [koji."brewhub.stage.engineering.redhat.com".kerberos]
osbuild-worker[483420]:       principal =<EMAIL_ADDRESS>osbuild-worker[483420]:       keytab = "/etc/osbuild-worker/client.keytab"
osbuild-worker[483420]: Waiting for a new job...
osbuild-worker[483420]: Running 'osbuild-koji' job ed0b7709-908b-4024-ab86-cb23348ab824

I managed to retrieve the error:
/api/worker/v1/jobs  channel was closed unexpectedly

https://github.com/osbuild/osbuild-composer/blob/01c21b5a47dc6d96e7a81b204902d904790e5e91/internal/jobqueue/fsjobqueue/fsjobqueue.go#L174
This is the cause, we're deleting channels that still have listeners. :-/

https://github.com/osbuild/osbuild-composer/blob/01c21b5a47dc6d96e7a81b204902d904790e5e91/internal/jobqueue/fsjobqueue/fsjobqueue.go#L174
This is the cause, we're deleting channels that still have listeners. :-/


geebong, carps (logical-conflict)

This pull request was generated by the 'mq' tool

/trunk merge


approve - improved logic to prevent approve transaction when not needed

we force approve 0 on all tokens.
however, some tokens support approve amount if current approve is not 0.
what to do?

check user current approve: IF current approve amount > amount we need, do not trigger approve and only trigger:

transaction

run a check with "approve {amount}", if web3 doesnt return any error/issue,

trigger approve {amount}
transaction

else, if approve {amount} returns error, it means that we need to trigger:

approve 0
approve amount
transaction

Moving to #727

Moving to #727


Problem: Click callback uses outdated data

Hi,
i ran into a strange issue using the marker click callback.
Pushed a sample here: https://github.com/p-lr/MapCompose/compare/master...cwsiteplan:MapCompose:bug/marker-click-callback
I'm adding a click callback to the mapState initially and inside the callback i do access data that does change over time.
But somehow the callback accesses only the initially passed object.
Interestingly, moving the code outside the child composable it starts to work fine 🤔
Probably not related to your implementation at all, but would be glad if you have an idea why.

You probably need to update the callback when your state changes. Try with:
@Composable
fun MyMapComposable(modifier: Modifier = Modifier, myData: MyData, mapState: MapState) {
    LaunchedEffect(myData) {
        mapState.onMarkerClick { id, x, y ->
            Log.d("Bug", "my marker state: ${myData.someList.size}")
        }
    }

    MapUI(modifier, state = mapState)
}

yep, that works too - but i'm not quite sure why i would need to do that .

That's because LaunchedEffect can take keys as parameters, and whenever one keys changes of value, the composable block is recomposed. By using LaunchedEffect(Unit){..}, you are actually capturing the initial value of your state.

thanks, i thought i'm aware of the concept of LaunchedEffect but assumed that the created callback (lambda) would still access the current state - seems it also captures a snapshot of the current state -interesting.

Another approach is to call a method from the view-model from the lambda, passing id, x and y values. Since the view-model has all necessary data, you can do necessary operations and state changes from there, without having to worry about updating the lambda.


Github project page title still says "JavaFX 2.0"

The title on this page still says

A library for writing JavaFX 2.0 applications in the Groovy language

I'd send a pull request for this fix, but it requires someone with repo admin privilege to edit via the Github Web UI.

I believe I am supposed to have appropriate privileges but I do not see an edit button – but then the GitHub UI changes so often I may just be missing it.

I just checked on a repo I have admin access on and the edit link appears on the main page just to the right of title. Maybe you don't have access. Should we tag someone or assign this issue to someone. We definitely want GroovyFX to look like an active/current project. It should definitely have an 8 there.

@msgilligan I have a request in to @aalmiray to find out who has "big boss" privilege as clearly I don't. I had assumed everyone in the team that could commit to the repository could also amend things, but apparently commit and admin are different roles and privileges.

@msgilligan I have been inculcated into the mysteries of core and appended to the membership of core. You will note that s/2.0/8/ has been achieved.

Awesome! You should also change the link to be GroovyFX.org -- someone's paying for the domain, let's use it!

Good point. Done.


Throw errors when .with is given missing keys

Fixes #18
Couldn't bundle install with rcov on ruby >2, so I updated it to simplecov.

one small error message fixup and this is good to go

Fixed :ok_hand:

released as 1.6.0: https://rubygems.org/gems/values


Motion Pair Dataset Creation Using TMR Motion Embedding

Hello,
Thank you for making the code and resources available for this amazing work. I am particularly interested in the data generation process described in the paper, specifically regarding the creation of motion pair datasets using TMR embeddings.
Could you provide detailed steps or code snippets for using TMR embeddings to retrieve motion pairs?

Hello and thanks for the nice words :)
Unfortunately, I have this code in a separate repo. However, I will try to release it and clean it during Christmas.
If you are interested into it asap, drop me an email at<EMAIL_ADDRESS>and I will provide guidance and a dirty code version for which you can get the motion pairs.


add other utils method

add utils description and comparison. fix #31
and remove xml method related, because xml method are not commonly used.

:+1:


test datasets size

Hi,
Thank you for the code and your prompt responses to the issues.
Could you please provide the number of images used for testing from the CASIA V1 dataset? I am currently experiencing difficulties reproducing the results reported in the manuscript, as I am obtaining notably high F1 scores for the CASIA V1 test dataset. Are these F1 scores the pixel-level ones or the general ones mentioned in Table 3 of the paper? Additionally, I’ve noticed that the AUC code has not yet been updated in the repository. Could you please advise on this so that I can align my results with those presented in the manuscript?
Moreover, when changing the norm type, I encounter an error: "Unexpected key(s) in state_dict: 'predict_head.norm.running_mean', 'predict_head.norm.running_var', 'predict_head.norm.num_batches_tracked'." Could you provide guidance on how to resolve this issue?

Hi, thanks for your attention to our work, and sorry for the delay. Here are our responses:

Could you please provide the number of images used for testing from the CASIA V1 dataset?

For testing the pixel-F1 score, we only applied 920 manipulated images since pixel-F1 for the authentic images means less (see this comment.

I am currently experiencing difficulties reproducing the results reported in the manuscript, as I am obtaining notably high F1 scores for the CASIA V1 test dataset. Are these F1 scores the pixel-level ones or the general ones mentioned in Table 3 of the paper?

Since this work only focuses on localization, only pixel-level metrics are reported. The reason why your results seem very high is that we thoroughly searched optimal settings months after we released the paper and adjusted this part of the settings in our code. Thus, you may experience some performance improvement with the code. We will revise the paper to clarify this gap in the future.

I’ve noticed that the AUC code has not yet been updated in the repository. Could you please advise on this so that I can align my results with those presented in the manuscript?

You may check this issue #8, but I recommend trying out our latest benchmark, IMDL-BenCo, to calculate the metrics for a more robust solution. The documentations are also provided.

Moreover, when changing the norm type, I encounter an error: "Unexpected key(s) in state_dict: 'predict_head.norm.running_mean', 'predict_head.norm.running_var', 'predict_head.norm.num_batches_tracked'." Could you provide guidance on how to resolve this issue?

When you change the type of norm layer, the model structure is also changed. So, you cannot directly load a checkpoint that was trained with a different normalization layer. You must re-train the model with the norm layer you like and load it to the corresponding model.
If you have further questions, please feel free to reach out.

Hi!
Please check if your issue is solved or not. Welcome for further discussion as well.

The case was closed since there was no response for a long time. No response. If you have further issues, please feel free to reopen this issue.


Create Bank brand rather than issuer for the wallet login screen

we need bank brand rather than issuer for the wallet login screen

In the login-consent app: both the login form and the consent forms have headers "Trustbloc Issuer" when the wallet logs in.

So you are calling login-consent of edge-sandbox ?


Rename column name heath_check_targets

Describe the bug
Column heath_check_targets appears to be misspelled on the table aws_ec2_classic_load_balancer.
https://github.com/turbot/steampipe-plugin-aws/blob/main/aws/table_aws_ec2_classic_load_balancer.go#L152-L157
https://github.com/turbot/steampipe-plugin-aws/blob/main/docs/tables/aws_ec2_classic_load_balancer.md?plain=1#L66

D'oh, completely missed the missing letter. We'll add in the missing letter, thanks!


Dockerize application

Building
Ensure you have docker installed.
To build, navigate to the project root then run docker compose build with admin/sudo privileges.
To execute, run docker compose up with admin/sudo privileges.
If docker compose is not recognized as a command, try docker-compose, although if this is the case you should update docker.
Testing
Open a browser and go to localhost:5000.
Try registering a new account. Don't forget the password, there is currently no way for users to reset them.
Next, try logging in with that account. The page should display "logged in as (email)" at the top if this is successful.
Finally, try logging out, and ensure that the message disappears or displays undefined.
To test the back-end, simply press the button at the bottom of the page. It should display a random number 1-10.
NOTE: the python server takes a while to start up (about a minute, but not longer), so if it is not working try waiting a bit.

Tested on 4/8/24, works as intended.


Drop repo's 'crystal-language' topic

The Crystal community has somewhat decided to use crystal as the language's topic.
To avoid fragmentation in the community, please drop the crystal-language topic, that only has ~28 repositories at the moment. We're sticking to crystal, instead.
Any contributor can change it from the repo's homepage.
See crystal-lang/crystal#4241 for more context.
Thank you very much :)

We're now down to just 9 repos wrongly-tagged - if you can take just a moment to fix this, we're almost there :)
Thank you @ctiapps, and apologies for the noise!

Sorry, mail was filtered out. Will fix later today
Andrius Kairiukstis
t: +34 65 22 99 183 <+34%2065%2022%2099%20183>
https://andrius.mobi/contact/
On 26 April 2017 at 19:14:59, Matías García Isaía<EMAIL_ADDRESS>wrote:

We're now down to just 9 repos wrongly-tagged - if you can take just a
moment to fix this, we're almost there :)
Thank you @ctiapps https://github.com/ctiapps, and apologies for the
noise!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ctiapps/asterisk/issues/2#issuecomment-297480095, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABomC5IUOMyhPz2zSr3k2lnyvSI9NmGks5rz3uTgaJpZM4MzmUF
.

Fixed!


inject source via config map / secrets feature

Today openshift build v1 API allows for injection of config map content under the source tree of the build container for use during the image build
Do we want to expose a similar policy in build v2?
tekton tasks already allow for mounting of config maps / secret volumes in tasks/taskruns

Today openshift build v1 API allows for injection of config map content under the source tree

Could you help me with a scenario, please?

Today openshift build v1 API allows for injection of config map content under the source tree

Could you help me with a scenario, please?

In this case I think our docs do a sufficient job of capturing this one.  See https://docs.openshift.com/container-platform/4.3/builds/creating-build-inputs.html#builds-input-secrets-configmaps_creating-build-inputs

Interesting use-case, @gabemontero. Putting myself as a final user, it would come handy to share common resources between different builds, therefore, it would act as another point of extensibility, which currently we only offer on BuildStrategy.
Good idea, I think we should pursue it!

/kind feature
This would be useful in two contexts - dovetailing on the discussion in #419:

Using ConfigMap and Secrets as content in the image to be built (sources)
Using ConfigMap and Secrets as supplemental information used in the build, but is not present in the final image (volumes)

@adambkaplan I feel like we can either close this in favor of https://github.com/shipwright-io/community/pull/23 and any items opened as a result of that, or we should cite this issue as something address by that SHIP,
The former feels better but I'm enough on the fence to not hit the close button unilaterally
Thoughts?


Release/code structure changes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: cuztomizer:x: coreyjmorrisonYou have signed the CLA already but the status is still pending? Let us recheck it.


Doesnt work

I just got this plugin and it fails to start no matter what. i dont know why tho. Does this conflict with any other plugin or is it something to do with the threads update?
My plugin list is:

AutoPlayGifs
BDFDB
BetterFormattingRedux
BetterRoleColors
CallTimeCounter
CharCounter
CollapsibleUI (This one but it just wont load)
CompleteTimestamps
CrashRecovery
Double Click To Edit
EmojiUtilities
GameActivityToggle
GifSaver
GuildProfile
ImageToClipboard
ImageUtilities
InvisibleTyping
Link-Profile-Picture
LinkBanner
NoSpotifyPause
NotificationSounds
OldUpload
OpenSpotify Links in Spotify
PluginRepo
ReadAllNotificationsButton
Send BD Emotes
ShowConnections
ShowHiddenChannels
SpellCheck
SplitLargeMessages
SpotifyControls
StaffTag
StatusEverywhere
streamerModeOnGoLive
ThemeRepo
ThemeSettings
TypingIndicator
UserVoiceShow
UserVolumeBooster
XenoLib
ZeresPluginLibrary

sorry for the long list but maybe one of them is conflicting and known to conflict and it would be great to know so yah...

I don't think any of those plugins should conflict. Try downloading the latest version (v2.0.1) directly from Github and see if that one works. Also, what theme are you using?

AH yes wonderful the GitHUb one works :D i just garbbed it inside discord via plugin repo before and that one seems out of date/not working :) also theme i use: BlurpleRecolor

Great!
Yeah, the one in BD's repo is v1.1.0, which had some pretty glaring issues. I'm not really sure how to get the new version uploaded there atm, but I'll try to figure it out :)
Also, I asked about the theme because CollapsibleUI's animations mess with the styling of some elements, which could break certain themes. I'm hoping to add a settings option in the near future to toggle the animations so that it won't be an issue anymore.
Anyways, I'm glad the new version works for you! :)

@programmer2514  your polugin in plugin repo and BDiscord is outdated on version v1.1.0

@BlueStarBRS I know, but unfortunately,  there's nothing I can do about it. The update has already been submitted, but it needs to be approved by a site admin before it can be pushed to the BD repo. In the meantime, if you download the latest version from Github, it will automatically update to the latest version from now on.


Drag, dock and position editor panels on other screens

Godot version:
3.0, 3.1
OS/device including version:
all
Issue description:
I would like to drag and dock the editors panels freely to customize my workspace. This would allow me to also dock the panels "magnetically" together to form a cluster or sort and position on my screen however I like. This would also allow me to have the 2D/3D/script/assets area on one screen and my panels on another screen. The position and size of the panels should be saved and revertible to "default" at any time as well as to "last custom workspace" for instance.
Maybe even being able to separate "script", "2D" and "3D" as individual panels which then are draggable and position able even on separate screens. A feature that has come up as request on reddit a number of times before. (here is one example: https://www.reddit.com/r/godot/comments/aqr5ja/voice_your_frustration_what_do_you_think_is_the/egiov4f)

duplicate of #8250 or #9059 or #12742 or #2326

Yea, this is a duplicate issue. Please search through existing issues when opening new ones.
Duplicate of: #8250, #9059, #12742, #2326


Cannot read property 'propHooks' of undefined

I have an issue when loading the plugin, I've got the following error :
Cannot read property 'propHooks' of undefined
    // Add special hooks so that window scroll properties can be animated
    $.Tween.propHooks.scrollLeft =    <--------------- It complain about this line
    $.Tween.propHooks.scrollTop = {
        get: function(t) {
            return $(t.elem)[t.prop]();
        },
        set: function(t) {
            var curr = this.get(t);
            // If interrupt is true and user scrolled, stop animating
            if (t.options.interrupt && t._last && t._last !== curr) {
                return $(t.elem).stop();
            }
            var next = Math.round(t.now);
            // Don't waste CPU
            // Browsers don't render floating point scroll
            if (curr !== next) {
                $(t.elem)[t.prop](next);
                t._last = this.get(t);
            }
        }
    };

Hi, the plugin requires at least jQuery 1.8. Are you using an older version?
I should specify that in the README (it's in the JSONs but still)

Thanks you very much for the prompt reply (and the awesome plugin), now I have to update jQuery and I make sure I don't break everything :smile:

I happens with JQuery 3.1.1

Same with me. I'm using jQuery 3.2.1

LOL I've figured it out.
Use the full jQuery version not the slim version!
The slim version doesn't have the $.animate function.

Thanks @kevinwarren, I made the same mistake.

Years go by and people (me) keep making this mistake :D

Thanks @kevinwarren, I made the same mistake.

LOL I've figured it out.
Use the full jQuery version not the slim version!
The slim version doesn't have the $.animate function.

how to do that?


Introducing the Stellar Community Staking Competition scam

Another very good scam people get destroyed it cost me £9000.00 in XLM.
r/Stellar - Introducing the Stellar Community Staking Competition scam
Pay close attention to the email you received people and never click on them the scammers are very good :(
<EMAIL_ADDRESS>email received from this one

I never click on this email but it took me by surprise and I thought is legit


[CLOSED] Setup new pipeline for UI

 Issue by neel1996
Wednesday Feb 16, 2022 at 05:55 GMT
Originally opened as https://github.com/neel1996/mimock/issues/35

The pipeline should be triggered only when changes are added to mimock-ui path

Should run prettier format check +Eslint
Should run tests
Publish test coverage report as artifact
Publish react app bundle as artifact

 Comment by Nageswari-droid
Friday Feb 18, 2022 at 16:49 GMT

Successful run - https://github.com/neel1996/mimock/actions/runs/1865511474


use the specific spark version

Codecov Report
Base: 74.09% // Head: 50.62% // Decreases project coverage by -23.46% :warning:

Coverage data is based on head (070252c) compared to base (f78db4c).
Patch coverage: 80.15% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #62       +/-   ##
=============================================
- Coverage     74.09%   50.62%   -23.47%
+ Complexity      153      121       -32
=============================================
  Files            24       26        +2
  Lines          1594     1448      -146
  Branches        256      239       -17
=============================================
- Hits           1181      733      -448
- Misses          266      639      +373
+ Partials        147       76       -71

Impacted Files
Coverage Δ

...ala/com/vesoft/nebula/connector/NebulaConfig.scala
56.89% <ø> (ø)

...scala/com/vesoft/nebula/connector/NebulaEnum.scala
78.57% <ø> (ø)

...la/com/vesoft/nebula/connector/NebulaOptions.scala
0.00% <ø> (ø)

...cala/com/vesoft/nebula/connector/NebulaUtils.scala
59.70% <ø> (ø)

...a/com/vesoft/nebula/connector/PartitionUtils.scala
100.00% <ø> (ø)

...n/scala/com/vesoft/nebula/connector/Template.scala
0.00% <ø> (ø)

.../vesoft/nebula/connector/exception/Exception.scala
0.00% <ø> (ø)

...cala/com/vesoft/nebula/connector/ssl/SSLEnum.scala
100.00% <ø> (ø)

...om/vesoft/nebula/connector/ssl/SSLSignParams.scala
0.00% <ø> (ø)

...esoft/nebula/connector/writer/NebulaExecutor.scala
0.00% <ø> (ø)

... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add lang support in feed block

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fixes #223
Test URLs:

Original: https://www.sunstar.com

Before: https://main--sunstar--hlxsites.hlx.live/jp/_drafts/satyam/test

After: https://i-223--sunstar--hlxsites.hlx.live/jp/_drafts/satyam/test

[ ] New Blocks introduced in this PR
If yes, please provide details below

Block Name
Documentation

For e.g. cards
doc-link

[ ] New variations introduced in this PR

Variation Name
Documentation

For e.g. cards (grid)
doc-link

For the LCP degrade I have logged https://github.com/hlxsites/sunstar/issues/242
Anyway, its unrelated to this PR changes and the PSI failure is for a test page I created for this ticket (not a real site page).

LGTM


Use invariant culture in sorting

Now uses culture-specific sorting that may lead to different sort results.
(we have teams in different countries and experience this as a problem)

This should be fixed in 1.2


List files for magnet link.

In the previous release (0.13), there used to be a dialog showing the files before start downloading.
This was the feature why I prefer picotorrent to utorrent...
In new release, after the magnet link is added, the "Add torrent(s)" shows nothing so I can't select which files to download beforehand.

I guess you can add a checkbox in the magnet link dialog:

[x] Pre-load metadata.

So the users can choose to wait or not. It'd be better to remember this option.

I prefer preloading since I do not  want to download everything in the magnet torrent

This has been added in #672 and was also discussed in #608 😄 It will be released with v0.16.


ChildrenWatch should notify the function when the node is deleted

The documentation doesn't go into any depth on the semantics of high-level data and children watches, so it's hard to know what the actual API is and what to report as a bug.
If you set a DataWatch on a node, the watch survives node deletion. When a node is deleted, None is passed to the handler.  The handler stays around and if the node is recreated, the handler is called with the new data.  I guess DataWatches also serve as
high-level existence watches. This is rather useful. Is it intentional? :)
In the case of ChildrenWatches, if a node is deleted, Kazoo logs an error, but doesn't call a handler.  Is this intentional?

@zk.ChildrenWatch("/producer")
def watch_children(children):
print("Children are now: %s" % children)
I am using this function is a program where nodes are created like this ("/producer/node_1") and ("/producer/node_2") etc. But when I try to delete a node which is a child of /producer no event is triggered. There is no response from the watch function. I tried declaring the watch decorator before and after node creation but still no response. Anyhow there is just 1 response from the watch function which is by default during the creation of nodes. Any help please. By the way I am trying to create high availability on several slaves and keeping watch using the zookeeper. So if a slave fails I need to get it back with the help of zookeeper and at the same time do nothing when I am deleting slaves while I scale in. Any help is appreciated. By the way I am running all these components in docker container


updated dataIO

Major updates:

I fixed the issue with psi and chi local and galactic. I had a sign error in the vector from  the second interaction to the first interaction. Everything is now in good agreement after fixing this. Specifically, I've checked psi and chi local and galactic using the grb from mini-DC2. Additionally, I've verified that all values are in good agreement with the MEGAlib calculations.

I've added the first test script for dataIO. It compares psi and chi to the MEGAlib calculations. This comparison requires a local MEGAlib installation, so it will only be ran by certain users. The code should now account for this and not throw errors for users without MEGAlib -- I've wrapped the corresponding imports in a try statement. I will add more tests soon.

I've added another method to easily plot slices of psi and chi, in order to view a slice of the Compton cone.

When binning the data you can now choose between local and Galactic coordinates, for psi and chi. The default is Galactic.

I've updated the MEGAlib comparison test, as recommended by @israelmcmc. The test now reads in the MEGAlib calculations from a file instead of using MEGAlib to calculate them on the fly. The file is kept in cosipy/test_data. Additionally, I have added all parameters to the test; the last version was only testing psi and chi.
For now I am keeping the old TRA reader class in dataIO. This should not cause any issues, but please let me know if any problem arises. I think it's important to keep this for the time being, as it will make future testing much more easier.


Hide dep guts under internal/

This is an experiment to see if we like having dep's guts moved into internal.
I was trying to implement #500 under internal and was running into circular dependency hell. If we don't go with something like this, my plan is to implement #500 outside of internal, all in one directory to stop wasting time with circular reference problems. 😀
I realize this touches pretty much ... everything so here's the tldr:

Move dep/ to internal/dep/.
Move testdata/ to internal/dep/testdata.
Move log functions into own internal package so test, internal pkgs and cmd/dep can all reference.
Otherwise circular references were present.
Using the name util in honor of @kris-nova and to ensure proper bike-shedding.
Move test/ into internal/test/ so that internal tests can use it.

The following packages were left exported:

gps because it's crazy useful and doesn't have circular reference problems that would make me want to move it.
hack because anyone who references that is silly anyway.
cmd/dep because a) I'd like to see everything interesting in that moved into internal anyway, there's a lot of logic in there and b) again it isn't having circular reference problems.

This is the final folder structure (though the commits are broken down if we want to not do all of this):

dep/

cmd/
gps/
hack/
internal/

cfg/

manifest.go
lock.go

dep/

context.go
project.go
... (rest of the stuff from the root)

test/
util/

fs.go
log.go

... non-go stuff from the root is still here

LGTM with the exception of internal/util which is a dumping ground of unrelated functionality.

@dcheney-atlassian Yeah that's why I left the comment invoking @kris-nova because she just started a conversation about this topic. I didn't want to spend too much time time coming up with pkg names and knew that calling it util would bring people out to share their opinions. 😀

If/when this converges with my logger changes or some version of them (https://github.com/golang/dep/pull/525), then that will be a few less util members to worry about.

Thanks for the love @carolynvs,
Twitter shenanigans aside, what are we gaining from the move? Unsure what the inspiration for this awesome change is/was?
Also re:

I was trying to implement #500 under internal and was running into circular dependency hell

Which packages were conflicting? There are a few easy ways to pull them apart if necessary.. but usually when you get cycles it's because 1) you have too many packages or 2) an interface is defined somewhere weird or something. Just curious is all :)

@kris-nova  This was just a thought experiment (heavily aided by an IDE, so it wasn't a huge time investment). 😁
There has been encouragement to avoid exporting new types/functions, and when I was chatting with @sdboyer yesterday, I asked What would dep look like if we made everything internal? Instead of trying hard to not export things, and end up with a single flat directory, what if we moved most of dep into internal/ so that we could organize our code without worrying about exports. I volunteered to try it out and if it wasn't a steaming pile of 💩, open a PR so people could discuss it.
For #500 in particular, when I tried to implement it under internal/, I was running into trouble because I needed things like the manifest, lock and context, which are defined under dep, which also reference internal/. I also wanted to group some of my files into a directory (gasp I know what was I thinking?), but quickly ran into trouble because of where the log functions are defined. Instead of trying to move the things I needed in this PR, I wanted to step back and think as a group about how we'd like to organize the code in dep.
I was hoping we could look at this and answer a couple questions:

This is what (nearly) everything in interna/ looks like. Do we like it?
If we try to not export anything, does that mean that everything ends up in a single flat directory, most likely in cmd/dep since that's at the top of the import graph?
Do we want to hide only new functions/types or do we want existing stuff to be unexported too?

@jmank88 Sweet! I didn't realize your in-proc changes would improve our logging situation too! 👍

Some quick thoughts on this...
I do like the idea of moving almost everything into internal, at least initially, because it's easier to expose that stuff later when we're confident than it is to play footsie with general community best practices about releasing Go software in a project that's poised to influence those practices. That's not an ouroboros I want.
It seems like there's three basically sensible things we could do here:

Expose...nothing. At least for now.
Expose gps, dep.Manifest, dep.Lock,  and possibly also dep.Ctx.
Hide away e.g. the test package, maybe also the glide/other tool-related packages, but leave the rest exposed.

3 is mostly a 🦆.
1 seems too draconian, but 2 seems a bit too open, and still problematic because we're absolutely still modifying those types. ...and actually, 2 seems remarkably similar to what we're already doing right now 😦.
All that's to say, I'm open to argument here, and would ❤ it if someone made a clear, strong one 😄

also, just

gps because it's crazy useful

😂 😂 😂 ❤

You probably want to move github.com/golang/dep/gps to
github.com/golang/dep/internal/gps unless you want people to start
depending on it; the version of gps forked into dep shows up in godoc and
will rank higher as soon as it gets one more importer.
https://godoc.org/?q=gps
On Tue, May 9, 2017 at 11:21 AM, sam boyer<EMAIL_ADDRESS>wrote:

Some quick thoughts on this...
I do like the idea of moving almost everything into internal, at least
initially, because it's easier to expose that stuff later when we're
confident than it is to play footsie with general community best practices
about releasing Go software in a project that's poised to influence those
practices. That's not an ouroboros I want.
It seems like there's three basically sensible things we could do here:

Expose...nothing. At least for now.
Expose gps, dep.Manifest, dep.Lock, and possibly also dep.Ctx.
Hide away e.g. the test package, maybe also the glide/other
tool-related packages, but leave the rest exposed.

3 is mostly a 🦆 https://blog.codinghorror.com/new-programming-jargon/.
1 seems too draconian, but 2 seems a bit too open, and still problematic
because we're absolutely still modifying those types. ...and actually, 2
seems remarkably similar to what we're already doing right now 😦.
All that's to say, I'm open to argument here, and would ❤ it if someone
made a clear, strong one 😄
also, just
gps because it's crazy useful
😂 😂 😂 ❤
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/dep/pull/527#issuecomment-300034749, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAcA_3zthikgsDncWqCcqYXFwbetIJ4ks5r37-ngaJpZM4NTYpV
.

While I realize option 1 feels draconian, anyone who would be tempted to rely on this code right now is going to be burned. I just checked godoc and it doesn't appear that anyone is referencing dep yet. One could take that to mean that it's not worth bothering, or as the perfect time to move code before people do start referencing it.
I don't have skin in the game, we could go either way exposing/hiding everything and I'd be fine. What is chaffing me right now is that concerns about exposing new code is making it harder for me to work on features. I am spending too much time thinking about where code should be. 😊 Maybe I'm the only one feeling that way, I am new-ish to Go. But I would love for us to decide and commit to one or other.

Who is the decision maker for this issue?
On Wed, 10 May 2017, 07:49 Carolyn Van Slyck<EMAIL_ADDRESS>wrote:

While I realize option 1 feels draconian, anyone who would be tempted to
rely on this code right now is going to be burned. I just checked godoc and
it doesn't appear that anyone is referencing dep yet. One could take that
to mean that it's not worth bothering, or as the perfect time to move code
before people do start referencing it.
I don't have skin in the game, we could go either way exposing/hiding
everything and I'd be fine. What is chaffing me right now is that concerns
about exposing new code is making it harder for me to work on features. I
am spending too much time thinking about where code should be. 😊 Maybe
I'm the only one feeling that way, I am new-ish to Go. But I would love for
us to decide and commit to one or other.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/golang/dep/pull/527#issuecomment-300312060, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAcA3C9eGS4F64KIGWbQeC6byj4VHFsks5r4N9xgaJpZM4NTYpV
.

@davecheney this is a significant and general enough issue that i'm going to explicitly pull in other committee folks, so the decisionmaker in this case will be that group (though i may still be the one who clicks 'merge').
that's just decisionmaking, though. i'm hoping someone will step up with a coherent proposal for what of the codebase to make internal vs. not, as well as at least some general outline of how we should approach the question of publicizing packages in the future.
i, at least, do not plan to make any such proposal (so, please ignore my earlier comment), though i'll certainly participate in discussing those that are made.

Is #519 sufficient as a proposal? If not, what would you like to see?
On Wed, May 10, 2017 at 11:00 AM, sam boyer<EMAIL_ADDRESS>wrote:

@davecheney https://github.com/davecheney this is a significant and
general enough issue that i'm going to explicitly pull in other committee
folks, so the decisionmaker in this case will be that group (though i may
still be the one who clicks 'merge').
that's just decisionmaking, though. i'm hoping someone will step up with a
coherent proposal for what of the codebase to make internal vs. not, as
well as at least some general outline of how we should approach the
question of publicizing packages in the future.
i, at least, do not plan to make any such proposal (so, please ignore my
earlier comment), though i'll certainly participate in discussing those
that are made.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/dep/pull/527#issuecomment-300343944, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAcA2rw2CFLcWtL_YTydQnlfJRSgDE_ks5r4QwlgaJpZM4NTYpV
.

(I'll assume #521 is also included alongside #519)
Additional questions to answer would be:

What do we do with the github.com/golang/dep package?

If it remains exposed, what guideline do we follow about identifiers that are OK to export?

At what time in the future would it be appropriate to consider re-exposing some of these packages (e.g. gps or github.com/golang/dep)

I'm in favor of moving everything into internal/ (including gps) until we have concrete plans about what we want to make available.

On Wed, May 10, 2017 at 11:10 AM, sam boyer<EMAIL_ADDRESS>wrote:

(I'll assume #521 https://github.com/golang/dep/issues/521 is also
included alongside #519 https://github.com/golang/dep/issues/519)

Nope, scope creep is what is lead to this issue bogging down. #519
addresses just github.com/golang/dep/gps

Additional questions to answer would be:

What do we do with the github.com/golang/dep package?

Out of scope for the moment.

If it remains exposed, what guideline do we follow about
identifiers that are OK to export?

See above.

At what time in the future would it be appropriate to consider
re-exposing some of these packages (e.g. gps or github.com/golang/dep)

Same

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/dep/pull/527#issuecomment-300345324, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AY8dppEIipzJg2b1XQWgftC49ZYAxLo4ks5r4Q6QgaJpZM4NTYpV
.

Nope, scope creep is what is lead to this issue bogging down. #519
addresses just github.com/golang/dep/gps

If this discussion were on #519, it'd be scope creep. But the scope of this issue has, from the outset, been inclusive of moving (potentially) all packages under internal/.
I opted to turn toward policy as we're organically bumping into this elsewhere, and it's clear that the lack of even a loose policy on this is hindering development.

I'm sorry if my previous response came across as combative. My goal is to
solve #519 with the solution I proposed. There are other packages that the
same motivation applies to but I consider them out of scope because placing
them in scope seems to block any action behind calls for a holistic policy.
On Wed, 10 May 2017, 12:25 sam boyer<EMAIL_ADDRESS>wrote:

Nope, scope creep is what is lead to this issue bogging down. #519
https://github.com/golang/dep/issues/519
addresses just github.com/golang/dep/gps
If this discussion were on #519 https://github.com/golang/dep/issues/519,
it'd be scope creep. But the scope of this issue has, from the outset, been
inclusive of moving (potentially) all packages under internal/.
I opted to turn toward policy as we're organically bumping into this
elsewhere, and it's clear that the lack of even a loose policy on this is
hindering development.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/dep/pull/527#issuecomment-300355676, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAcA2KbPD-YHZut20ODO1YV7G7C2fy2ks5r4SAcgaJpZM4NTYpV
.

no problem. seems pretty clear that any outcome here is going to end up putting gps under internal for the moment, so i'd be happy to merge a PR that did so; perhaps it'll help narrow the discussion here in pursuit of a policy.

I'd still like to see us come to an understanding of what contributors should be aiming for with respect to what's exposed. Maybe that can be considered in #609. 😄


resourcesToBackend calls twice, and the second time re-write correct language

🐛 Bug Report
I follow this guide: https://locize.com/blog/next-app-dir-i18n/ to exist project and have problem, that my languages can't be changed.
I've tried it with new project, is okay.
Did 4 fully steps by instruction.
https://github.com/user-attachments/assets/14a63b72-ec51-4884-878d-c96970dfb3ee
Your Environment

runtime version: node v20.10.0
i18next version: 23.12.2
os: Mac

@adrai any ideas?

Please provide a minimal reproducible example repository.

nextjs
├── node_modules
├── src
│   ├── app
│   │   └── [lng]
│   ├── api
│   └── i18n
│       ├── locales
│       │   ├── de
│       │   │   ├── footer.json
│       │   │   ├── second-page.json
│       │   │   └── translation.json
│       │   └── en
│       │       ├── footer.json
│       │       ├── second-page.json
│       │       └── translation.json
│       ├── index.js
│       └── settings.js
│   ├── components
│   ├── middleware.js
|
Code from this article. This project structure, just change some imports.

sorry, not able to reproduce it...
please fork this repository and change it to reproduce the issue: https://github.com/i18next/next-app-dir-i18next-example

btw: the issue is not related to next-i18next at all... will move over to the other repo


Hashrate showing 0.00

Hashrate for Network is at 0.00 on all console commands. Seems something is wrong since moving multi-algo.

Any help with this?

ah yes i see. we need to implement the hashrate per algorithm. thanks for bringing that up.

Thx for response let me know when we can download new version or beta of new candidate happy to test

I'm assuming this was taken care of?  if not, feel free to re-open.


CST and literals

Hi @ikatyang,
I was wondering if the CST that tree-sitter-yaml produces could additionally contain literals like :.
Having a following yaml
openapi: 3.1.0

I'd expect CST to contain the : literal as a SyntaxNode with a location information. Currently literals are consumed by the grammar. For example tree-sitter-json does provide literals as SyntaxNodes within CST.
Thank you

@ikatyang not sure I see a difference in CST. What has actually changed ? Thanks!

They are now anonymous nodes, and you can verify it by enabling "Query" in the playground:

Hm interesting. This is what I see:

I've used Incognito Chrome window to eliminate any cache problems.

I do confirm that I'm seeing anonymous nodes when building<EMAIL_ADDRESS>locally. Great job!


Speech to Text 3.2 API support

Can we have documentation / instructions on how to use the 3.2 or 3.2-preview Speech to Text API from Python. Simular to https://github.com/Azure-Samples/cognitive-services-speech-sdk/tree/master/samples/batch/python

Hi there,
Thanks for reaching out to us. I'll see if I can contact the correct people and get an answer to you.

We are working on getting the docs and samples updated. Typically we will have a preview branch available first and then merge it into main after it is no longer preview. I will update this issue when the preview branch is available.

Thanks,
The thing is that the 3.2-preview is the basis for the (new/current)pricing for Speech to text ‘Pay as you’ https://azure.microsoft.com/en-us/pricing/details/cognitive-services/speech-services/ go’.
So I would like to make use of it through this Python Route.
Thanks again
Van: Christopher Schraer @.***
Verzonden: woensdag 31 januari 2024 19:07
Aan: Azure-Samples/cognitive-services-speech-sdk @.>
CC: Piebe @.>; Author @.***>
Onderwerp: Re: [Azure-Samples/cognitive-services-speech-sdk] Speech to Text 3.2 API support (Issue #2246)
We are working on getting the docs and samples updated. Typically we will have a preview branch available first and then merge it into main after it is no longer preview. I will update this issue when the preview branch is available.
—
Reply to this email directly, view it on GitHub https://github.com/Azure-Samples/cognitive-services-speech-sdk/issues/2246#issuecomment-1919638713 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUPSJ46JGJSNGOA2OPQJD3YRKB35AVCNFSM6AAAAABCRAUJRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJZGYZTQNZRGM .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/ADUPSJ2BD7BM4IODUGZY5XLYRKB35A5CNFSM6AAAAABCRAUJRKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTSNNOLS.gif Message ID: @.*** @.***> >
--
Dit e-mailbericht is met AVG-antivirussoftware gecontroleerd op virussen.
www.avg.com

The preview is now on this branch here: https://github.com/Azure-Samples/cognitive-services-speech-sdk/tree/chlandsi/v3.2-preview/samples/batch/python
I'll close this issue, but if you have any questions or concerns, feel free to reopen it.


Update HelloController.java

@somu1679 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Hi @somu1679 .  We'd like to keep our general greeting.  If you are interested in contributing please watch for the tag good first issue in this repository.


The nuget feed is broke/missing/never?

https://www.nuget.org/packages?q=ForcedHttps returns nothing.
Does Install-Package Owin.ForcedHttps actually work?

http://www.nuget.org/packages/Owin.ForceHttps
Drop the d ;)

There's no D https://www.nuget.org/packages?q=ForceHttps
Sent from my Windows Phone

From: Matt<EMAIL_ADDRESS>Sent: 2/10/2015 9:09 PM
To<EMAIL_ADDRESS>Subject: [Owin.ForceHttps] The nuget feed is broke/missing/never? (#1)
https://www.nuget.org/packages?q=ForcedHttps returns nothing.
Does Install-Package Owin.ForcedHttps actually work?
—
Reply to this email directly or view it on GitHubhttps://github.com/Readify/Owin.ForceHttps/issues/1.

Fixed readme too
Sent from my Windows Phone

From: Rob<EMAIL_ADDRESS>Sent: 2/10/2015 9:13 PM
To<EMAIL_ADDRESS>Subject: Re: [Owin.ForceHttps] The nuget feed is broke/missing/never? (#1)
http://www.nuget.org/packages/Owin.ForceHttps
Drop the d ;)
—
Reply to this email directly or view it on GitHubhttps://github.com/Readify/Owin.ForceHttps/issues/1#issuecomment-144992438.

thanks guys


Login and Sign up with Line

Hi Guys! Please help or advice. I'm trying to add a new provider Line, configured Line in a gigya console under Providers Configurations section(App ID, Secret Access Key).  Using method with params gigya.accounts.socialLogin({provider: "line", keepLogged: true}).
On click I see https://take.ms/WtURX, but when I'm typing a correct email and password always see the text The email address or password you entered doesn't exist or is invalid. Please also ensure that you have enabled "Allow login" on your smartphone as shown below: Settings > Accounts > Allow login
Settings > Accounts > Allow login is active https://take.ms/eFtnq
https://take.ms/d40Ia Email and password are correct because I able to login with these credentials in Line mobile, desktop apps.
Tried the same flow on package versions 3.0.1, 2.0.33. Please help.

hi andrey, this repo is for the backend nodejs sdk - i suggest contacting Gigya support for this issue.


Yarn audit shows vulnerability for lodash

💬 Questions and Help
Yarn audit shows a high vulnerability for lodash, which was fixed in Version 4.17.21.
Is there a plan to update this dependency in the near future?

https://github.com/gregberge/loadable-components/blob/main/packages/server/package.json#L33

"lodash": "^4.17.15"

such vulnerabilities are very complicated beasts, especially when they are not any vulnerabilities at all...
But I would like to advise you to fix the problem via your very own lock file first. Just find the problematic version and delete it - the newer one will be installed automatically.
Removing and Adding loadable will do the same.


Features, small refactors, documentation

Changes made:

Middleware to check if a user is banned and prevent further actions
Modification of the schema for posts and users to add more fields
Function to ban users (only for supervisors)
Make the posts endpoint "universal" (so, v1/posts/ will return all posts, v1/posts?author=jaysermendez will return only posts by me, v1/posts?category=music will return posts only from music, v1/posts?search=music will search for posts with the keyword music or related). All the fields can be combined in the URL.
Indexation of author and category in post schema
API Documentation for posts endpoint, "ban" endpoint
Add master user the first time the server run
Remove user object from user schema since it is redundant (data can change and we don't want this fixed data)
Prevent moderators to moderate a post more than once
Middleware to check if a post is moderated. If so, prevent any moderator to moderate it again
Merge all moderation tools into a single endpoint for more consistency
Refactor of single post endpoint to follow project guidelines and linter
Add "isVoted" field for posts endpoint so you can know if you have voted any of the posts returned
API documentation for single post endpoint
Change group name for moderation tools in the API docs
Validation of fields for "ban" endpoint
Validation for moderate endpoint

Great Work Buddy! :slightly_smiling_face:
You smell like Microsoft

Will see if I smell like it next week :D

fragrant

Traced


Benchmark section removed from README

@themisir Why are you considering removing the benchmark?

@themisir Why are you considering removing the benchmark?

It does not reflect current state of the ecosystem. The benchmarks were old and a lot changed since then. Also some points might be "unfair" to compare on benchmark basis. So I don't want people to make decision based on misleading data.
Also some benchmark steps were not tested correctly back then or for some other reasons when I do benchmark myself the results are different, for some reason Lazy boxes performed worst than regular boxes.

It's a fair point that we should keep the benchmark up to date.
I think it's normal for benchmarks that they compare a certain thing though. So it's developer's responsibility to think whether a certain benchmark relates to their use case.
I'm not sure how it's right now, but I actually adjusted and ran the benchmark myself for my article. The results were somewhat different, but the conclusion was the same - Hive is fast.
Perhaps the benchmark should be updated or described differently, but I think it's responsible to include some benchmark, if we're claiming that Hive is "blazing fast" in documentation.
PS: I'm just a random guy from internet, so sorry for "sticking my nose" here, but I always liked Hive and considered speed to be one of it's most important benefits :)

Yeah I've updated and added new comparison points to the benchmark. You can see final result here. But what's interesting is apperately lazy reads was way slower than what's shown on current README. I think that's because Hive have to read data from file when doing lazy reads, which is the whole point (otherwise hive have to read the whole data into memory, which indeed takes memory, which might be an issue if data source is bigger). But that also means using more conventional solutions like SQLite makes more sense for data heavy workloads instead of using Hive because of efficiency.

PS: I'm just a random guy from internet, so sorry for "sticking my nose" here, but I always liked Hive and considered speed to be one of it's most important benefits :)

Don't worry, I'm actually not sure about removing that too, so that's why didn't wanted to merge this PR yet.


Fix Python argument parsing for Call nodes

This previous was throwing exceptions in some cases where Attribute nodes were
used instead of Name nodes.

:+1:


Fix wrapper and horizontal group classes in docs

The default wrapper_class has become mb-3 as per BS5 docs and form-group is deprecated in favour of grid utilities (row for horizontal component groups)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.146%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
591

Relevant Lines:
604

💛  - Coveralls


Improve releasing during v0.12.1

More follow-ups once release is done:

[x] Fix ordering of instructions to ensure that the changelog PR is always included in engine+cli tag: https://discord.com/channels/707636530424053791/1262430315683647578/1263590457188028527
[x] I have to run dagger develop before the instructions on updating dev/ with go mod edit/tidy fully work. Was an issue this time because I had recently run git clean, which resulted in errors
[x] We really need to fix the permissions issue with the bump engine PR (or at the very minimum add the instructions for manually creating it)

I attempted a fix for this here, details in commit message: https://github.com/dagger/dagger/pull/7983/commits/49670c60801087745951be532ad01a7184a4158a

[ ] Figure out why engine tests are not automatically running in this PR (???)

I am not immediately sure why the engine tests are not getting run automatically in this PR? Just running locally in the meantime, will revisit after release is done.

I am still quite confused why the engine tests are not running here. All I see in Actions is this workflow with no jobs stuck in Queued: https://github.com/dagger/dagger/actions/runs/10000394190
My yaml updates don't look obviously wrong at first glance. I will just let this be for now and revisit tomorrow in case it's just a GHA issue I suppose? Wouldn't be the first time.


TypeError: instance.INTERNAL.registerComponent is not a function

[REQUIRED] Step 2: Describe your environment

Operating System version: _____
Firebase SDK version: _____
Firebase Product: admin
Node.js version: _____
NPM version: 6.13.3

Have tried with firebase-admin 8.8.0, 8.7.0, and 8.6.1 (the last 3 versions)
Running firebase-functions 3.3.0
[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
I'm getting this error when I try to deploy Cloud Functions. firebase deploy --only functions:FUNCTIONNAME
Any idea what the problem is? Anyone else have this issue?
Error: Error occurred while parsing your function triggers.

TypeError: instance.INTERNAL.registerComponent is not a function
    at registerDatabase (/PATH/cloud-functions/functions/node_modules/firebase-admin/node_modules/@firebase/database/dist/index.node.cjs.js:15165:39)
    at Object.<anonymous> (/PATH/cloud-functions/functions/node_modules/firebase-admin/node_modules/@firebase/database/dist/index.node.cjs.js:15196:5)
    at Module._compile (internal/modules/cjs/loader.js:721:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:732:10)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
    at Function.Module._load (internal/modules/cjs/loader.js:552:3)
    at Module.require (internal/modules/cjs/loader.js:657:17)
    at require (internal/modules/cjs/helpers.js:22:18)
    at FirebaseNamespace.get [as database] (/PATH/cloud-functions/functions/node_modules/firebase-admin/lib/firebase-namespace.js:282:38)

Duplicate of #717, #714

I followed the linked threads but no concrete solutions were provided.
@firebase/app doesnt fix the problem

it's work fo me. Thank alot

More clearly
npm install @firebase/app --save
was the solution

If it helps anyone see my comment here: https://github.com/firebase/firebase-admin-node/issues/714#issuecomment-567877071
@firebase/app should not be explicitly required on server side when firebase-admin is included but you have to be careful  @firebase/app isn't somewhere in your node_modules folder hierarchy.

It's possible that @firebase/app is expected to be in your node_modules, like if you're using @firebase/testing:
PS C:\code\> npm ls @firebase/app
<EMAIL_ADDRESS>C:\code
`--<EMAIL_ADDRESS>  `--<EMAIL_ADDRESS>    `--<EMAIL_ADDRESS>
In my case, the fix was updating @firebase/testing from version 0.13 to 0.16.

In my case, I already had @firebase/app as part of firebase. I also have node 12 installed with Win 10
npm ls @firebase/app
functions@ C:\Users\me\source\repos\admin\functions
`--<EMAIL_ADDRESS>  `--<EMAIL_ADDRESS>

I fixed the issue by updating the firebase dependencies to the latest.
npm i --save firebase@latest firebase-admin@latest firebase-functions@latest
From my package.json:
"firebase": "^8.2.4",
  "firebase-admin": "^9.4.2",
  "firebase-functions": "^3.13.1",

Note: Always update firebase-tool to the latest:
   npm i -g firebase-tools@lates

In my case, I already had @firebase/app as part of firebase. I also have node 12 installed with Win 10
npm ls @firebase/app
functions@ C:\Users\me\source\repos\admin\functions
`--<EMAIL_ADDRESS>  `--<EMAIL_ADDRESS>

I fixed the issue by updating the firebase dependencies to the latest.
npm i --save firebase@latest firebase-admin@latest firebase-functions@latest
From my package.json:
"firebase": "^8.2.4",
  "firebase-admin": "^9.4.2",
  "firebase-functions": "^3.13.1",

Note: Always update firebase-tool to the latest:
   npm i -g firebase-tools@lates


Updating to Kubernetes 1.24.2

@hickeyma can you rebase this from main. Seems another change was merged causing a conflict.

@mattfarina Rebased

@hickeyma merge when ready


ollama: 0.0.17 -> 0.1.3

Description of changes

Updated the package and added llama-cpp as a required dependency. Also added support for Metal, CUDA, ROCm hw acceleration.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

We need to allow to be built with gpu support before merge

Note 0.1.1 is already available.

Thanks, I've updated to 0.1.1 and also added CUDA/ROCm support (based on https://github.com/ggerganov/llama.cpp/blob/master/flake.nix) by integrating llama-cpp as a package. I don't have hardware to test CUDA and ROCm locally, maybe someone could try that out?

Rebased & updated ollama to 0.1.3.

@benneti Thanks for testing. I'll look into that issue reg. ROCm. I've also added OpenCL support, could you test that as well?

I've patched the passing of the deprecated --gqa flag, which seems to be only needed for GGML format models. Could you test that again?

As I am unable (I run out of space while compiling rocblas and am too lazy to change my tmpfs setup for this) even with the fixes necessary (see code comment), I only tried the standard version and opencl support.
Both work and seem to be much more performant than the previous version, thanks for the effort again.
For others that quickly want to check whether it works, only GGUF models are supported in this version and they are not clearly labeled, for me a model that worked was ollama run zephyr (see https://github.com/jmorganca/ollama/issues/738#issuecomment-1758207870).

ROCm support should be fine now from a packaging standpoint, was able to build & run it successfully on my laptop just to see it fail with a seemingly ROCm/GPU specific error.
Anyone able to give the CUDA version a shot?

Anyone able to give the CUDA version a shot?

It works!
$ nix run 'nixpkgs#nixpkgs-review' -- pr 257760 --extra-nixpkgs-config '{ cudaSupport = true; }'
2 packages built:
llama-cpp ollama

I can confirm this works and is GPU-accelerated: :rocket:
$ nixpkgs-review/pr-257760-5/results/ollama/bin/ollama serve
(snip)
llama.go:255: 23601 MiB VRAM available, loading up to 176 GPU layers
(snip)
llm_load_tensors: using CUDA for GPU acceleration

$ nixpkgs-review/pr-257760-5/results/ollama/bin/ollama run mistral-openorca 'write napoleon key life event dates as a JSON list'
 [
  {
    "event": "Birth",
    "date": "15 August 1769"
  },
  {
    "event": "Education",
    "date": "1780-1784"
  },
  {
    "event": "Military career",
    "date": "1785-1799"
  },
    {
    "event": "Consul of France in Egypt",
    "date": "1798-1801"
  },
  {
    "event": "Emperor of the French",
    "date": "1804-1814; 1815"
  },
  {
    "event": "Battle of Austerlitz",
    "date": "2 December 1805"
  },
  {
    "event": "Battle of Jena-Auerstedt",
    "date": "14 October 1806"
  },
  {
    "event": "Exile to Elba",
    "date": "11 April 1814"
  },
  {
    "event": "Return from Elba and defeat at Waterloo",
    "date": "20 March 1815; 18 June 1815"
  },
  {
    "event": "Death",
    "date": "5 May 1821"
  }
]

Awesome, thanks for testing!

from ofborg: substituteStream(): ERROR: variable $llamaCppServer is unset

Thanks for the heads-up. Fixed & updated to latest 0.1.5.

from ofborg on x86_64-darwin: /tmp/nix-build-llama-cpp-2023-10-11.drv-0/source/ggml-metal.m:5:9: fatal error: 'Foundation/Foundation.h' file not found

Thanks, I've added the required dependency for x86_64-darwin.

I think that's reasonable, updated.

Thanks, much appreciated. I've updated accordingly.

did the latest commits change anything apart the versions?
With the version from 12h ago everything was working fine on my end but with the current version (while I can still run models) I do not get responses, only "Error: unexpected end of response" and then the prompt quits for me (no GPU backend for this test) and I do not see anything helpful in the logs.

https://github.com/NixOS/nixpkgs/compare/efc2f884d9635bee71f7ee50dbf5b956c587f1e3..0398d616a88b2b9f4f9f4718c58caf55494115d6

hmm seems like only the versions changed, but maybe one of the new ones (llama-cpp) would work again, but I don't have the time right now to debug this further (also the problem might have developed on my end if some-one else might try whether it functions might be great).

I can reproduce @benneti issues (No GPU), I also am not sure, where they are from.
v0.1.0 works fine for me. The current build built with nixpkgs review has the same error:
Error: unexpected end of response

Result of nixpkgs-review pr 257760 run on x86_64-linux 1

2 packages built:

llama-cpp
ollama

Thanks for testing, I had updated llama-cpp which introduced a regression how the completion endpoint works. I've now updated both llama-cpp and ollama to their latest versions and patched the issue within ollama.

can confirm, it works as intended again!
Thank you.

I can also confirm that it now works as intended,
thanks for keeping at it!

The issue was fixed upstream, so I updated & removed the patch.

I read through the change logs and it seems there are only additions and no major changes, and i don't consider this a breaking change for the 23.11 release. but the aarch64 darwin ofborg builder isn't doing too good, i think it could use some friends

I read through the change logs and it seems there are only additions and no major changes, and i don't consider this a breaking change for the 23.11 release. but the aarch64 darwin ofborg builder isn't doing too good, i think it could use some friends

Version 0.0.17 is broken with the current models. This update puts it  back in a working state.
Is there anyone who can confirm this PR builds with aarch64-darwin?

I can confirm that, actively using it on aarch64-darwin w/ Metal support.

I installed ollama from unstable and I am getting:
{"timestamp":1699272675,"level":"WARNING","function":"server_params_parse","line":1994,"message":"Not compiled with GPU offload support, --n-
gpu-layers option will be ignored. See main README.md for information on enabling GPU BLAS support","n_gpu_layers":-1}

Related upstream issues:

https://github.com/jmorganca/ollama/issues/920
https://github.com/jmorganca/ollama/issues/832
https://github.com/jmorganca/ollama/issues/758

I am not sure, what's the issue. I have 11.8 toolkit running. Building ollama directly also doesn't seem to pickup the includes. I think this (https://github.com/jmorganca/ollama/pull/958) should finally fix it?

The override looks like this:
ollamagpu = pkgs.unstable.ollama.override { llama-cpp = (pkgs.unstable.llama-cpp.override {cudaSupport = true;}); };

But it seems like compiling llma-cpp fails with issues mentioned here: https://github.com/ggerganov/llama.cpp/issues/2481

Should we provide ollameWithNvivia and ollamaWithRocm in all packages like torch does?

Just wanted to thank @geekodour for his fix https://github.com/NixOS/nixpkgs/pull/257760#issuecomment-1794967371 . Worked for me as well.

Does this still work for you guys? I'm getting the following error:

error: llama-cpp: exactly one  of openclSupport, openblasSupport and rocmSupport should be enabled

And removing the disable cublas option then complains about running an unsupported compiler version.

Does this still work for you guys? I'm getting the following error:

error: llama-cpp: exactly one  of openclSupport, openblasSupport and rocmSupport should be enabled

And removing the disable cublas option then complains about running an unsupported compiler version.

It stopped working for me so I removed the check altogether. Not sure what's the proper fix.

Does this still work for you guys? I'm getting the following error:

error: llama-cpp: exactly one  of openclSupport, openblasSupport and rocmSupport should be enabled

And removing the disable cublas option then complains about running an unsupported compiler version.

It stopped working for me so I removed the check altogether. Not sure what's the proper fix.

So you're just using the CPU right? I removed the override and it installs just fine but holy hell is it slow lol. Must be some new configuration for llama-cpp I'm going to lookup if I have time later.

I don't have a proper fix but ran into the following errors:

complained about it using gcc 12 rather than version 11
passing -DALLOW_UNSUPPORTED_COMPILER=ON to gcc had no impact on nvcc
complained about git not being found, so I added that in an overlay
proceeds to run the git command except it's not in any git folder so it has no effect
here's what I'm left with and it works for some reason w/ gpu usage (checked w/ nvtop)

    (self: super: {
      llama-cpp = super.llama-cpp.overrideAttrs (oldAttrs: {
        nativeBuildInputs = oldAttrs.nativeBuildInputs ++ [ super.git ];
      });
    })
    (self: super: {
      llama-cpp = super.llama-cpp.override (args: {
        openclSupport = true;
        openblasSupport = false;
      });
    })

Globally, cuda support is not turned on. Just thought I'd leave this here in case someone else stumbles on this issue. I'm also not using unstable.

to try to address this, I made https://github.com/NixOS/nixpkgs/pull/277709
let me know if of course, I missed something.

https://github.com/ggerganov/llama.cpp/commit/68eccbdc5b56f2a2450f9a8463f9934388cafabf

Thank you! SomeoneSerge nicely commented on what had to change, I think all is incorporated now. Let me know if you notice something I missed.