TypeError: Cannot read properties of null (reading 'clone')

Found this in the smoke test logs, I think this is opening a task.json file in the editor:
[2023-07-24T05:44:56.773Z] Playwright (Electron): window.on('console') [%c  ERR color: #f33 Cannot read properties of null (reading 'clone'): TypeError: Cannot read properties of null (reading 'clone')
    at u (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:613:106785)
    at g.updateTokensUntilLine (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:613:102140)
    at a.forceTokenization (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:613:114993)
    at c.forceTokenization (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:613:109581)
    at h (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:629:30550)
    at y (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:629:46932)
    at r.m (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:640:277)
    at r.typeWithInterceptors (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:641:241)
    at vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:643:1626
    at g.H (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:643:960)
    at g.type (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:643:1516)
    at vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:724:3009
    at m.O (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:724:4005)
    at m.N (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:724:2804)
    at m.type (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:724:2997)
    at Sn.Lb (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:726:8027)
    at Sn.trigger (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:726:7228)
    at T.runCommand (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:663:36483)
    at handler (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:663:2010)
    at k.handler (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:618:11336)
    at d.invokeFunction (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:622:326)
    at y.k (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:1509:12357)
    at y.executeCommand (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:1509:11945)
    at Object.type (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:726:17361)
    at P.type (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:663:37331)
    at r.value (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:702:52067)
    at u.w (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:69:1902)
    at u.fire (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:69:2119)
    at r.value (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:596:26833)
    at u.w (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:69:1902)
    at u.x (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:69:1972)
    at u.fire (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:69:2188)
    at HTMLTextAreaElement.k (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:69:7712)
    at P.typeInEditor (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:627:27855)
    at eval (eval at evaluate (:197:30), <anonymous>:1:38)
    at UtilityScript.evaluate (<anonymous>:199:17)
    at UtilityScript.<anonymous> (<anonymous>:1:44)]

[2023-07-24T05:44:56.774Z] Playwright (Electron): window.on('console') [%c  ERR color: #f33 Cannot set state before setting previous state: Error: Cannot set state before setting previous state
    at r.setEndState (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:613:104422)
    at g.updateTokensUntilLine (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:613:102250)
    at a.forceTokenization (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:613:114993)
    at c.forceTokenization (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:613:109581)
    at h (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:629:30550)
    at y (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:629:46932)
    at r.m (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:640:277)
    at r.typeWithInterceptors (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:641:241)
    at vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:643:1626
    at g.H (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:643:960)
    at g.type (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:643:1516)
    at vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:724:3009
    at m.O (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:724:4005)
    at m.N (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:724:2804)
    at m.type (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:724:2997)
    at Sn.Lb (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:726:8027)
    at Sn.trigger (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:726:7228)
    at T.runCommand (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:663:36483)
    at handler (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:663:2010)
    at k.handler (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:618:11336)
    at d.invokeFunction (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:622:326)
    at y.k (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:1509:12357)
    at y.executeCommand (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:1509:11945)
    at Object.type (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:726:17361)
    at P.type (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:663:37331)
    at r.value (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:702:52067)
    at u.w (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:69:1902)
    at u.fire (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:69:2119)
    at r.value (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:596:26833)
    at u.w (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:69:1902)
    at u.x (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:69:1972)
    at u.fire (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:69:2188)
    at HTMLTextAreaElement.k (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:69:7712)
    at P.typeInEditor (vscode-file://vscode-app/mnt/vss/_work/1/VSCode-linux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:627:27855)
    at eval (eval at evaluate (:197:30), <anonymous>:1:38)
    at UtilityScript.evaluate (<anonymous>:199:17)
    at UtilityScript.<anonymous> (<anonymous>:1:44)]

Will look into this later today, I think this is important.
Please let me know if someone managed to reproduce this locally (so far, I didn't).

No sorry, just found it looking through a failing smoke test log.

I assume there is no verification possible?

I guess so


Roll engine

This roll dramatically improved our metrics but did not return them to the state they were in before b59286.


Pip install DS packages if Python ext fails

For #8325

Codecov Report

Merging #8326 (c9dea22) into main (40e744f) will decrease coverage by 0%.
The diff coverage is 30%.

:exclamation: Current head c9dea22 differs from pull request most recent head 2217c6d. Consider uploading reports for the commit 2217c6d to get more accurate results

@@          Coverage Diff           @@
##            main   #8326    +/-   ##
======================================
- Coverage     72%     71%    -1%
======================================
  Files        373     374     +1
  Lines      23323   23424   +101
  Branches    3570    3584    +14
======================================
+ Hits       16844   16853     +9
- Misses      5029    5116    +87
- Partials    1450    1455     +5

Impacted Files
Coverage Δ

...cience/data-viewing/dataViewerDependencyService.ts
87% <ø> (ø)

...interpreter/jupyterInterpreterDependencyService.ts
75% <ø> (ø)

...science/jupyter/kernels/kernelDependencyService.ts
82% <ø> (ø)

src/client/telemetry/index.ts
63% <ø> (ø)

src/client/common/installer/backupPipInstaller.ts
28% <28%> (ø)

src/client/common/installer/productInstaller.ts
57% <34%> (-5%)
:arrow_down:

src/client/common/utils/localize.ts
95% <100%> (+<1%)
:arrow_up:

...ent/datascience/jupyter/pythonVariableRequester.ts
68% <0%> (-6%)
:arrow_down:

...tascience/jupyter/kernels/kernelCommandListener.ts
66% <0%> (-4%)
:arrow_down:

src/client/datascience/jupyter/kernelVariables.ts
56% <0%> (-3%)
:arrow_down:

... and 5 more


Support excluding directories

Hello,
I'd like to run htmllint on my project. However, running htmllint **/*.html gives a lot of false positives since it lints also the HTML files of the project dependencies stored in ./node_modules. The only workaround I can think of is to list all the directories (e.g. foo/**/*.html, bar/**/*.html) and the top-level HTML files (i.e. *.html). But with this approach, there is a big chance that I'll forget to add a newly created directories in the future and I won't notice that they are not linted.
It would be nice if there was a way to list directories/globs that should be excluded (like what you can do with .gitignore).

OK, I don't need this any more (I'm going to use something like find ... | xargs ...). But maybe some one else does...

@radek-holy  What's the glob pattern you used? I have
./node_modules/.bin/htmllint {*.html,./!(node_modules)/**/*.html}

and it kind of works

You can just do htmllint $(find /directories /you /want /to /search -name '*.html)

Any plans on including the possibility to use .gitignore? eslint and stylelint have the option


Is there a reason why libxgboost.a is output to the source directory?

It's done on this line: https://github.com/dmlc/xgboost/blob/master/CMakeLists.txt#L252
That's confusing to me.  I noticed this while trying to pull both XGBoost and another project dependent on it into a superproject using FetchContent for XGBoost and ExternalProject_Add for the other project (which does not use CMake).  I have given ExternalProject_Add the build command:
BUILD_COMMAND ${CMAKE_COMMAND} -E env "CXXFLAGS=-I${xgboost_SOURCE_DIR}/include" "LDFLAGS=-L${xgboost_BINARY_DIR}/dmlc-core\ -L${xgboost_SOURCE_DIR}/lib" $(MAKE)

to call make directly on the other project and give it environment variables so that it can find libxgboost.a and libdmlc.a.  It works, I'm just wondering if you currently think outputting the static library to the source directory is correct.
Thanks!

Just a convention in XGBoost that we put the shared libraries in that directory for easy packaging with other language bindings.
You can always run cmake install to put the library else where.


New Spotify design breaks most hotkeys

No other hotkeys but only the Next works.
I assume it's due to the recent frontend changes made to the web player.
This is how my control panel looks like atm.

Indeed, thanks for the quick report. Will have a look tomorrow.

@yongminparks You seem to be the lucky winner of some A/B testing lottery. Spotify does not serve the new UI on my account. I cannot solve this issue unless you dump the HTML structure of your entire play bar in all relevant states. If you are able to and have the time, please use Chrome devtools (F12) to copy/paste (see image) into any pastebin (eg. https://0bin.net/) and give the links here.
You'll need to do 3 copy/pastes to cover everything:

not liked, not repeating, not shuffled, paused (your screenshot)
liked, repeating 1, shuffled, playing
any state you like but with repeating all enabled

Thanks for your help!

Same issues for me as well:
https://0bin.net/paste/Xj-HwDDv#Ms6KuCx7CjRjANJpi2MxhqZI3Lv0unA8hwsnDz5ufoT
https://0bin.net/paste/+sODMw+6#V3J-8LKCHPgYjBOuJ2AS2QcwkOLZZJufj1kfknP0D5W
https://0bin.net/paste/ouexpaXJ#SuacBBeClrd4AE1ODWsjL2QPJc84I6cadAOiGjdzfLs
Hope that helps!

@shie1d3d Perfect, thanks a lot, that should do it. It's very late here so I'll do that tomorrow.

All right, I sent 0.6.2 for review by Google. Since I cannot test the changes myself, please report back if this issue is actually fixed when you get the update (probably some time tomorrow).

It's fixed on my end.
Big thanks for the quick fix. I appreciate it a lot.

Thanks for confirming!


webpack: add "@templates" alias via config

Now that it's possible to add aliases via the ASSETS_WEBPACK_ALIASES config (see https://github.com/inveniosoftware/invenio-assets/pull/123), the @templates alias used for search templates will need to be added via the default InvenioRDM config, like so:
ASSETS_WEBPACK_ALIASES = {
    '@templates': "templates",
    ...
}

We probably don't need the templates alias now that we can use React-Overridable.


Adfly no longer uses the same domain for all their links, how do we go about that?

Can you also tell how to add links and how th whole thing works in detail?

adf.ly is dead well kind of, i will start working on linkvertise or/and other adfly alternatives from 20th December. So i cant guarantee if this bot would still work.
Still the answer to just how this bot works would be, my server has all image files that is related to the bot, basically you create an account on my server and the adfly referral number to your account, then my server will generate web pages for when your bots work, your bots(the Virtual Machines) visits those web pages and gets views, push ads, for your adfly account. Lets forget adfly now, i'll make something for adfly alternative now

adf.ly is dead well kind of, i will start working on linkvertise or/and other adfly alternatives from 20th December. So i cant guarantee if this bot would still work. Still the answer to just how this bot works would be, my server has all image files that is related to the bot, basically you create an account on my server and the adfly referral number to your account, then my server will generate web pages for when your bots work, your bots(the Virtual Machines) visits those web pages and gets views, push ads, for your adfly account. Lets forget adfly now, i'll make something for adfly alternative now

@qwakup2314


Replace aborted with exitted or goodbye when exiting instructlab

Is your feature request related to a problem? Please describe.
I'm always frustrated worried when I exit instruct lab and get an "Aborted!" message because it seems like something has gone wrong!
Describe the solution you'd like
I'd like the message to be more neutral like "exitted" or friendly like "goodbye"
Additional context
Suggested at RedHat Summit

I think this is addressed by #1131 + #1136. These fixes are not yet in a release.

Fixes are part of https://github.com/instructlab/instructlab/releases/tag/v0.15.0 now, can we close this? Thanks!

Thank you!


added mldotnet titleSuffix to docfx file

Summary
Added ML.NET brand to each page title using settings in docfx.json file - titleSuffix

#sign-off
There might be duplicate brands (- ML.NET) in titles, but we can fix those. In the long run, branding consistency and placement is of primary importance.
@natke @luisquintanilla


Fix for issue no. #310

Related Issues

PR for issue no. #310
Closes #
Short Description and Why It's Useful

There were some console.log and console.error statements which are not useful because the toast messages in the console.error serves the same purpose!
Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

[x] I read and followed contribution rules

Okay @ymaheshwari1 , let me fix I will raise another PR!


Allow disabling tessellation and simplify tcs

I just copied most of the shader together so it works. Gonna clean up all the shader handling soon.

Awesome! I tried to do this too but failed miserably...

Should we merge this soon?

I'm sure @LukasKalbertodt doesn't mind


[c++] support building with Ninja on Linux

Contributes to #5061.
Adds support for building with Ninja instead of make on Linux.
This is necessary (or at least, very very helpful) for integrating scikit-build-core as the backend for building the Python package (as I'm working on in #5759).
What is Ninja?
Ninja is an open-source alternative to make, originally developed to support building Google Chrome on Linux ("Google man open sources Chrome build system").
It's often much faster than make, in exchange for being simpler (i.e. supporting a stricter, harder-to-customize API).
Because of its build speeds, Ninja is the strongly-preferred default build tool for macOS and Linux in scikit-build-core. See https://github.com/scikit-build/scikit-build-core.
How do these changes relate to supporting it?
Try the following on a Linux system, using latest master (https://github.com/microsoft/LightGBM/commit/36fe73aecbd15a09635ddea98744ff4babd735f0).
rm -rf ./build
mkdir ./build
cd ./build
cmake \
    -G 'Ninja' \
    -D__INTEGRATE_OPENCL=ON \
    ..

ninja -j2 _lightgbm

You'll see the following error.

ninja: error: 'Boost/source/stage/lib/libboost_filesystem.a', needed by '/home/jlamb/repos/LightGBM/lib_lightgbm.so', missing and no known rule to make it

This is because of the use of ExternalProject_Add(... BUILD_COMMAND ...) in the CMake script used to build the integrated-OpenCL wheels. Unlike with make, the Ninja CMake generator requires that you explicitly list the outputs of such commands, so the generated .ninja files will contain the appropriate references to them. See the following for documentation on that:

https://cmake.org/cmake/help/latest/module/ExternalProject.html
https://stackoverflow.com/a/65803911/3986677

This PR modifies that script by adding an explicit list of the expected output files.
Should we add new CI jobs?
I don't think that's necessary. Once #5759 is merged, the Python-package tests on Linux and macOS will be testing compilation with Ninja.
Notes for Reviewers
Thanks for your time and consideration. I know the progress towards fixing #5061 has been slow and has involved a lot of building/packaging changes. I really appreciate your thoughtful reviews.

cc-ing main authors of the integrated OpenCL wheels, in case you're interested: @jgiannuzzi @tpboudreau
and thanks to @csegarragonz for the very helpful Stack Overflow answer 😊

@guolinke @shiyu1994 could I get a review on this this week, if possible? Sorry for the @, but I think this is an important step towards #5061 via its support of #5759 ... and therefore an important step towards the v4.0 release (#5153).

Thank you!


add version function into mrob python bindings

It would be great to have a function which returns the version of mrob python bindings:
For example:
import mrob mrob.__version__
should return something like:
0.0.3
All popular python libraries do so. For example:
import numpy
numpy.__version__
'1.15.4'

@anastasiia-kornilova
I've checked the usual ways how to add this attribute to the package:
https://stackoverflow.com/questions/41146784/set-python-wheel-version-tag-dynamically
https://stackoverflow.com/questions/17791481/creating-a-version-attribute-for-python-packages-without-getting-into-troubl
Besides the __version__ there are a few other attributes:
https://www.python.org/dev/peps/pep-0008/#module-level-dunder-names
It makes sense to add them all.
It should be done in setup.py

@nosmokingsurfer , I'm not sure that those stackoverflow straightforward solutions are the most beatiful ones. But they are right about setup.py.
Actually, as you may notice, we already use setuptools-git-versioning to automatically version pip-package (https://pypi.org/project/setuptools-git-versioning/).
You can find this in toml project file -- https://github.com/MobileRoboticsSkoltech/mrob/blob/f08e88c98bb7703f34504616fabf7fdb1755238a/pyproject.toml#L24
And then it is used in setup.py --  https://github.com/MobileRoboticsSkoltech/mrob/blob/f08e88c98bb7703f34504616fabf7fdb1755238a/setup.py#L55
In manual of this tool (https://pypi.org/project/setuptools-git-versioning/) in section "Callback/variable as current version" you could find how to use this tool to assign value to __version__ variable of the python package. I would try this solution first.

@nosmokingsurfer , CI -- is your friend, it contains all steps in a reproducible way in comparison to any other guide/manual :)
Follow build-wheel step -- https://github.com/MobileRoboticsSkoltech/mrob/blob/f08e88c98bb7703f34504616fabf7fdb1755238a/.circleci/config.yml#L63 -- install proper docker container, install packages inside it, attach your sources instead of checkout and run  scripts/build-wheels.sh.

@nosmokingsurfer , I've realized that the step you propose will change nothing, it just adds tag to the pip-package and doesn't change the attribute __version__ . This tag we already have with version_config=True. What we need is to assign to __version__ current pip-package distribution version in __init__.py:
from pkg_resources import get_distribution
__version__ = get_distribution('mrob').version

Btw, instead of building things locally I would propose to use artifacts build on CI -- there is a special section where you can download built pip-wheel and install locally. Just commit changes on some branch and visit CI page in one minute.

@anastasiia-kornilova
Adding your lines in __init__.py worked straight. I used CI artefacts to test the wheels, as you recommended. Here is the current output:

Is it ok or should it only report the digital part of the version? I don't think that the information about what git state was used to build the wheel is required, it already contained in the name of the whl file

@nosmokingsurfer , I would say that it is the standard way in common practice (that is why it is the default behavior for setuptools package) -- we need to separate "release" version and some "dirty/experimental" version. The way you propose -- after the installation env doesn't remember what wheel was used for installation (as well as a user), and this could produce some ambiguities. So, I propose to remain it as it is now.
Also, you were proposing to add other attributes, I suppose they could be added in the same way as with the version -- wheel already encapsulates information about maintainer/licence/etc.

@anastasiia-kornilova
You mean, if the wheel will correspond to some release tag, then the version value will automatically become a "pretty" release version like "0.0.7"? If so, then ok.
About other attributes, yes, sure. I will add them as soon as I understand how it worked exactly in the case of the version attribute =)  I've never done package wrapping before, just need to read the documentation more and play around with tools for packaging.

About versioning -- yes, it should be so because setuptools-git-versioning state that they follow PEP-440. In their README:
Use git repo data (latest tag, current commit hash, etc) for building a version number according PEP-440.
I hope it works, you could check CI artifacts from commits that were tagged and output version of it using pkg_resources directly.
Sure, any questions about pip-package are welcome, many thanks to your contributions!

Or even check "release" version from our releases -- https://github.com/MobileRoboticsSkoltech/mrob/releases

I've looked at the numpy and pandas packages as a reference. It makes sense to add the following dunder names to add to the package:

[ ] version
[ ] git_version

Metadata for mrob improved:
Before:

Now:

branch added into the version value + possible to set full SHA value if required (setuptools-git-versioning);
summary added;
author and author e-mail added;
download URL added;
supported platforms added = 'any';

MROB package now has attribute version that can be called from the console line:

Git full SHA can be also enabled if required, but having branch name in version is more informative during development.

Closed in #88


Prototype to create a separate sync module

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #428
Description
Separate the sync code into a new module. This is done via creating clear separation of concerns in the FhirEngine API.
suspend fun syncDownload(download: suspend (suspend (ResourceType) -> String?) -> List<Resource>)
suspend fun syncUpload(upload: (suspend (List<Resource>) -> Unit)?)

Alternative(s) considered
This is an improvement on the existing approach.
Type
Choose one: Feature
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct
[x] I have read How to Contribute
[x] I have read the Developer's guide
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
[x] I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

closing this as this is being reworked in #482


Add support for Dry-Run reconciliation

Description
Pre-requisite for https://github.com/kyma-project/cli/issues/1135.
AC:

Add option to trigger a dry-run reconciliation
the dry-run reconciliation will not modify the resources on the cluster but provides an option to retrieve the potentially applied changes  (e.g. as string or object oriented etc.)

Reasons
Enable users to see up-front the changes of a reconciliation run.
Attachments

Implemented by @khlifi411


chore: bdd-spring-1574354224 to 0.0.1

chore: Promote bdd-spring-1574354224 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Query Results: x rows in y seconds, y never stops counting up after results have been returned

Expected behavior
It should tell you how long the query took
Actual behavior
it never stops counting up.  Here is an example of a query the returned in less than 1 second, but the wheel is still spinning and the counter is still counting:

Steps To Reproduce
CTRL Enter on a SQL file
Log output/Screenshots
No response
Operating System
Windows
dbt version
1.3
dbt Adapter
snowflake
dbt Power User version
0.8.3
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

It also looks like the "Dispatched SQL" tab is now missing.  Commenting on the same bug because I'm it is likely related to whatever update was released.

I can't reproduce the issue. Also latest version did not change anything related to query execution.
Could you check Help > Toggle developer tools and see if there is anything interesting being logged in the console?

does this tell you anything?

Must be something related to the query template. Maybe check if you have modified the queryTemplate, that shouldn't be required for snowflake.

I have not modified anything.  :(

Can you post the executed query from the snowflake query log, maybe that will give some indication what went wrong?

Further troubleshooting steps that did not work:

uninstalled all other plugins related to dbt.
removed all folders from the workspace except for one.

Here is an example.  First screenshot in vs code.  Then screenshot from snowflake query history.

Just to be sure can you verify following setting?

yep, mine is the same as yours

Fixed in 0.8.4.
Let me know if it works for you

yes, it seems to be fixed.  Back to normal!


LED Setup

Hi everyone, after almost 1 year with our phonibox I wanted to make some upgrades and came across one "issue" - maybe its just so trivial that it wasn't discussed yet.
Most of the jukebox pics I see on GitHub use LED (in buttons in lights etc.) - but there is no explanation about those LED and the wiring (or did I just not come across it?).
So the issue is - I used 4 LED (2 yellow, 2 red) and wanted to add 2 more - they are all using the "status" script and are turned on as soon as box is fired up ... but now I came across several statements that even 2 normal LED (between 10-20 mA) could exceed the max amount of current healthy for the pi (max 30-50 mA?) - so even with a higher resistor you will reach that goal easily.
How did you solve that problem? I tried to "understand" transistor or MOSFET solutions but the days of my higher electrical/physical understandings are gone I guess....
So I just need 6 LEDs lighting up if the Box is on ;)
Let me know if it is something dumb to ask... I googled all day (with a 3 year old in my ear all day :D - so not fully aware of what I read ;)

I agree there isn't really much documentation about LEDs, I think we should add some info.
Maybe #171 can provide some.

Yes - that’s the old script I used - but no information about the max. amount of LED etc - and most people trying to build the jukebox are electric noobs (like I was and still am - some physics in university but still noob...). Even with google it’s hard to find a step by step for using a transistor or a MOSFET for LEDs...

There is an article in the wiki about this topic. I just updated it but recognized that

the documentation is not aligned with the gpio_control docs and
the shutdown LED doesn't work (separate issue - I'll have to open another issue for that)

Wiki page was updated, so closing it for now.


Mention gradient  in the Getting started section

Currently the user-friendly function gradient and it's friends are only mentioned in the API section.
I think it would be great for new users to have it in the Readme and in the Getting started section.
This more in line with other AD packages
gradient(Reverse, rosenbrock, [1.0, 2.0])

and seems much simpler than
autodiff(Reverse, rosenbrock, Active, Active(1.0), Active(2.0))

In case  gradient has a lower performance than autodiff, the Getting started section would be a good place to explain this too.

Sure, contributions welcome!


Fix Footer position in playground pages

On bit website pages, When the page scrolls, The footer is placed on the navbar.

This issue was solved by fixing the navbar position on pull request #986, so I close it.


MSID: 88321 Version: 2 DOI: 2<IP_ADDRESS>6335

[PLACE MANUSCRIPT AND EDITOR DETAILS HERE WHEN AVAILABLE] See step 3
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=88321)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/88321/v2)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>6335)
[ ] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/88321/v2/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/88321)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/88321

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/88321

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/88321/v2/88321-v2.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/88321)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

elocations missing from references


How to get  count subscription  in private channel ?

please??

@rawezhcode I don't fully understand what you are trying to achieve. By a rule, private channels are not presence channels, you can not see number of its subscribers

@kerimamansaryyev  I asked that question to see if I could see the number of participants.
Because in one presence channel what I saw is that only 100 users can be subscribed?

@rawezhcode Private channels do not support that feature. If you want to do that for private channels - you need probably to implement manually on the server-side by adding subscribers number into payload. So it's not an issue or a responsibility of this package. So, is the issue resolved?


Pin periodfind 0.0.5

This PR pins the latest version of periodfind.

Agreed about the test. I can work on a fix by commenting/modifying the hardcoded references to melman that currently fail. Not sure if we're close to a new penquins release - if so, it would be a simpler fix.


Media and TSS API

As a developer, I want full access to the Media and TSS API.

https://2600hz.atlassian.net/wiki/display/APIs/Media+and+TTS


disable proprietary extended tar attributes from package tarballs

They're just problematic, and pretty much unnecessary (though, absolutely ought to be on by default in node-tar).

Related: isaacs/node-tar#2

Fixed.


[Automated] Update eventing-istio-eventing-kafka-broker nightly (#206)

Update eventing-kafka-broker nightly
Signed-off-by: Knative Automation<EMAIL_ADDRESS>

OCF Webhook is merging this PR


API misuse checker is not accurate: only intra-procedural analysis done

Hi, thanks for the nice tool.
In your Amandroid paper, you said that API misuse checker will be done as a plugin after generating inter-procedural data dependency graph (DDG). The older versions of Amandroid did do this.
However, I found that after version 3.0, API misuse checker only does very simple analysis. Basically, just retrieve each class, obtain each method, and do intra-procedural dataflow analysis (via ExplicitValueFinder) if the method contains a targeted API call. Let alone no DDG is generated, the call graph is also not produced during its analysis.
I verified this by reading source code. For example, https://github.com/arguslab/Argus-SAF/blob/df2557a9654260d5dd933a15f52143bbd6da1f6d/amandroid/src/main/scala/org/argus/amandroid/plugin/apiMisuse/CryptographicMisuse.scala
So how to enable the accurate detection of API misuse? Or do you plan to re-add it in the recent versions of Amandroid? Thanks.
Btw, a related question is https://github.com/arguslab/Argus-SAF/issues/12.

Let me also attach a sample log of the current API misuse checker. Only dedexing bytecode, no call graph and no DDG.
$ time java -jar argus-saf_2.12-3.1.1-assembly.jar a -f -c CRYPTO_MISUSE com.qiyi.video.apk
Total apks: 1
Analyzing #1:file:/home/dao/software/amanDroid/com.qiyi.video.apk
Dedexing... Total: 5874
[==================================================] 100.00% 14s556ms ETA: 0ms
Dedexing... Total: 7932
[==================================================] 100.00% 18s673ms ETA: 0ms
Dedexing... Total: 8146
[==================================================] 100.00% 18s712ms ETA: 0ms
Dedexing... Total: 8912
[==================================================] 100.00% 16s380ms ETA: 0ms
Dedexing... Total: 7473
[==================================================] 100.00% 6s477ms ETA: 0ms
CryptographicMisuse:
  Lorg/qiyi/basecore/algorithm/AESAlgorithm;.encrypt:(Ljava/lang/String;)Ljava/lang/String; L1d2f02 : Use non-random IV!
  Lcom/coloros/mcssdk/c/c;.b:(Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String; L30b506 : Use ECB mode! Lcom/qiyi/qyreact/modules/CryptoModule;.AES128Decrypt:(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lcom/facebook/react/bridge/Promise;)V L52c52c : Use non-random IV!
  Lcom/iqiyi/hcim/utils/encode/EncryptAES128Utils;.decrypt:(Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String; L41ce54 : Use ECB mode!
  Lcom/iqiyi/paopao/a/aux;.eV:(Landroid/content/Context;)Ljava/io/InputStream; L474ab6 : Use ECB mode!
  Lcom/coloros/mcssdk/c/c;.a:(Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String; L30b460 : Use ECB mode!
  Lorg/qiyi/video/o/aux;.decrypt:(Ljava/lang/String;Ljava/lang/String;[B)[B L3287fa : Use non-random IV!
  Lcom/iqiyi/passportsdk/interflow/c/aux;.o:(Ljava/lang/String;J)Ljava/lang/String; L5b474e : Use non-random IV!
  Lorg/qiyi/context/b/con;.init:(Landroid/content/Context;)V L28b5a4 : Use ECB mode!
  Lcom/hmt/analytics/a/nul;.encode:(Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String; L2c0082 : Use non-random IV!
  Lorg/qiyi/basecore/algorithm/AESAlgorithm;.decrypt:(Ljava/lang/String;)Ljava/lang/String; L1d2e76 : Use non-random IV!
  Lcom/hmt/analytics/a/nul;.decode:(Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String; L2bffda : Use non-random IV!
  Lcom/iqiyi/passportsdk/interflow/c/aux;.n:(Ljava/lang/String;J)Ljava/lang/String; L5b46b6 : Use non-random IV! Lcom/qiyi/qyreact/modules/CryptoModule;.AES128Encrypt:(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lcom/facebook/react/bridge/Promise;)V L52c5d0 : Use non-random IV!
  Lorg/qiyi/video/o/aux;.encrypt:(Ljava/lang/String;Ljava/lang/String;[B)[B L328856 : Use non-random IV!
  Lcom/iqiyi/hcim/utils/encode/EncryptAES128Utils;.encrypt:(Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String; L41ceca : Use ECB mode!
real	1m46.750s
user	2m8.072s
sys	0m4.904s


POI Specific OSM Question.

Currently, the OSM Upload Media Type specifies the tags and labels that are to be presented to the user in OpenMapKit. Ideally, we could also specify a OpenMapKit POI question type that would allow the application to hide or show POIs and the ability to add / delete them.
Right now, the user can always mess with POIs, regardless of whether we should be tagging buildings or not. This isn't the end of the world, and it might even be useful to maybe add a POI that is supposed to be a building, that can then later be made into a way in JOSM.
Still, it is somewhat awkward to be creating POIs on building ODK questions, because the tags specified to be filled in are not appropriate for nodes.
Example of seeing both buildings and POIs at once, with the add UI:

This sort of logic would require a modification to pyxform, JavaRosa, ODK Collect, OpenMapKit, and Ona.
Master Issue: #31

I don't think we want this, because if we have a building that doesn't exist, we might want to put a POI in there in place.


Travis: Fix docs and remove unnecessary script

It seems we don't need the after_success script for codecov. to work.

Current coverage is 91.16% (diff: 100%)

Merging #74 into master will not change coverage

@@             master        #74   diff @@
==========================================
  Files             2          2
  Lines           283        283
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            258        258
  Misses           25         25
  Partials          0          0

Powered by Codecov. Last update 0fea31a...c2e4a65


GPU vs CPU Performance

Hello,
first of all i wanna say thank you for this great Framework and those tuned Hyper parameters.
Now to my question:
I tested the performance with my own gym/baselines examples and there were only 5-10 seconds difference.
I also tested your implementation and the difference vs CPU and GPU is really small (about 5 sec.).
Is this an normal behavior or must be the difference much higher (maybe i installed the nvidia-docker wrong with the wrong nvidia-runtime settings) ?
I hope maybe you can help me out
Thanks!!!
Regards Mom0

Duplicate of https://github.com/hill-a/stable-baselines/issues/308
Also related: https://github.com/hill-a/stable-baselines/issues/367
So for short, for small networks, there won't be any difference between of communication delay and also passing data from cpu to gpu back and forth. For bigger architecture and especially CNN, you should see a boost when using GPU.

Ok thank you for your fast response.
I didn´t know that, i will try so test bigger networks.


[Observ] Add Dial of HTTP.GET pannel

Include basic informations of http

https:   probe_http_ssl{instance}
version:  probe_http_version
tlsversion:  probe_tls_version_info{version}
cert expiry: probe_ssl_earliest_cert_expiry

Supported at this commit https://github.com/kubegems/dashboard/commit/3540ff43f92b80428c36965328e7801a0487318a


⚠ ClamAV has degraded performance

In 2f17416, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 198 ms

Resolved: ClamAV performance has improved in fc2a520.


Add print-color-adjust declaration

👋
I'm working on a feature that requires the background colors of divs to show up during printing and I can add -webkit-print-color-adjust declarations but the non-webkit version doesn't compile:

I asume using print-color-adjust alone isn't sufficient?

So I just tested this in FF/Safari/Chrome on OSX and print-color-adjust: exact without the vendor prefix works on all of them so that might be sufficient. I have not tested this on windows/linux however.

Sounds good. Autoprefixing works by emotion at client runtime (and if SSR by us), this will be done by us in the future as well (when we remove emotion).
No need to parse -webkit- and other prefixed properties from our parser. Closing this!


gotrue docker image stuck on v2.74.2

Describe the bug
Using this cli to start supabase locally the gotrue docker container is running from image v2.72.2 which was released back in June.
As far as i can see it should be using v2.99.0 (main and latest release): https://github.com/supabase/cli/blob/v1.106.1/internal/utils/misc.go
And the hosted version is on 2.104.2 so the local one is lagging behind quite a bit.
To Reproduce
Steps to reproduce the behavior:

supabase start
docker ps | grep true

Expected behavior
Ideally the latest version used in the cloud environment (as I'm seeing some differences and am testing to rule out an issue is because of different versions of the software).
Desktop (please complete the following information):

OS: Ubuntu 20.04
Browser (if applicable)": N/A
Version of CLI: 1.106.1 (latest at time of writing)
Version of supabase-js (if applicable): N/A
Version of Node.js (if applicable): N/A (installed cli with brew not npm)

Additional context

Could you try deleting supabase/.temp/gotrue-version file? It should reset the local gotrue version to the default v2.99.0.
If you want to match local gotrue version to that of your remote project, you can also use relink your project with supabase link --project-ref <ref>. That will save your remote project's gotrue version to supabase/.temp/gotrue-version.

ah! nice one @sweatybridge . that's got it :+1:
good to know about the (re)link-ing too. i will give that try soon also.


error(linting): Unused import throws tslint error

#644 - project.config.ts

import {InjectableDependency} from './seed.config.interfaces';

Correction, looks like I just fail at merge conflicts today.


NoMethodError: undefined method `rspec_is_quitting'

knapsack_pro seems to fail with rspec 3.10, the minimum version that supports this method is 3.11, Can this be explicitly be called out in the documentation?

Thanks for reporting this.
I have a fix for that in #237 so that we could support older RSpec versions.
Is this issue blocking you? Can you update the RSpec version in your project?

I realized we already fixed that issue in the knapsack_pro 6.0.1 version.

https://github.com/KnapsackPro/knapsack_pro-ruby/pull/231

Changelog: https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md#601
Please update the knapsack_pro gem to the latest version.


[Draft] Replace sqlite with pouchDB

@spiritanand there are tons of unresolved issues going stale with pouch + nextjs  - so pls do not wait for resolution.  https://github.com/pouchdb/pouchdb/issues?q=is%3Aissue+nextjs


Update config.js

fixing address links and children of links - hopefully all new pages will work now.

Merged, thanks!


Notebook

It renders very badly on older gtk version now (the tabs specifically). The Notebook widget fixes this issue.

And this one has actually broken enable/disable, while the menubutton still doesn't work.

I've reverted the changes for now, but if you can get everything working so that the original code remains untouched for newer GTK 3.16+ environments, you can resubmit it. I do warn though that I will be making a number of changes to the UI that might also break your work.


Update doc version in README

You should also probably change the default version on read the docs; currently http://docs.tweepy.org/ gets you to 3.2.0.

Whoops. I always forget to bump that one. Thanks.


Add script to check performance

I was looking for ways to improve the performance of the slicer, and decided to do a bit of benchmarking. This adds a script to test the performance of updating an image with Plotly+Dash.
It contains a dcc.Interval that tries to update a figure as fast as it can. The time it costs to do this will slow the interval down, so we can measure fps. Of course this FPS value depends on a lot of factors, but it's valuable to see the differences between methods.
Some observations:

Even if the (client-side) callback yields no_update, the FPS does not go beyond 20. Not sure whether this is some rate limit or some overhead in Dash.
When the callback returns an empty figure, the FPS is the same as doing noting, so that's good.
Heatmap is slow! (about 6-7 FPS for me).
The gl heatmap is only a wee bit faster (8 FPS). This makes no sense to me ...
The PNG approach (which we now use) is actually pretty fast! (13-14 FPS). It actually looks a lot faster than what I experience with the slicer, so we might gain performance by having a good look at the slicer internals.
The PNG approach that does not swap the y-axis grinds to a mere 6 FPS. I'd love to get this fixed ...

In summary, I had hoped the glheatmap would allow us to get more smooth interaction. Alas. On the plus side, we seem to have some internal overhead that we can hopefully fix to make things more smooth!

A question about serialization: did you compute the JSON serialization time of the figure? If it's a significant fraction of the time it might explain why the difference between heatmap and heatmapgl is not huge.

I tried the same benchmark on larger (256x512x512) and random uint8 (worst case for png compresseion) data  and

png: 8-9 fps
heatmap 1 fps
heatmapgl: 3-4 fps
png not reversed: 1 fps :-(

Note that the performace of the noop and empty modes are improved when setting the update_title of the app to None:
app = dash.Dash(__name__, update_title=None)

also see https://dash.plotly.com/external-resources. I think this also slightly improves the png mode.

I added update_title=None. I'm surprised at how much this improves the performance ...


BUG: Validation for Book Exchange Hub input fields & Enhanchment in Password Requirments

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Issues:

"More" navigation in navbar UI is bit squeezed.

Validation for input fields inBook Exchange HUB.

UI is not attractive would like to change the color in Unleash the Magic of BookSwapping div cards

Rate US UI is not looking looking Good would like to enhace it.

The UI of Password Requirment is not looking good in create account page.
Solutions:
1)Improve the UI of More in [navbar]
2)Book Exchange Hub validation for all input fields
3) Unleash the Magic of Book Swapping of [change UI for cards]
4)Rate US ui issue
5) Create Account [improve UI for password requirement]
Hi, I have raised the following issues i'm intersted to work on those, please assign these issues to me under gssoc 24 label and under appropriate level badge.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@PankajR007
Assigned!
Make sure to attach before & after screenshots in your PR. Also, star the repo before working on it. While creating your PR, ensure you pull all existing changes beforehand to avoid conflicts.
Happy open-source contributing!

@anuragverma108  Sure, Thank you for assigning this issue to me, will start working on it.

@anuragverma108 is @PankajR007 is still working on it?
If not then can you please assign this issue to me...

I have completed it will raise the PR Today.


Update 1.17

update to 1.17
use cmake as build system
specify more recent MACOS SDK 10.13 as minimum (using on compilation 10.14)

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_c2huzi833p/clone/recipe/meta.yaml:42: missing_description: The recipe is missing a description
Warnings were found


Missing Extension

Type: Bug
all of my installed extensions are disappeared when i close current VS code or open a new window. Please help me fix it. Thank you so much!
VS Code version: Code 1.74.2 (e8a3071ea4344d9d48ef8a4df2c097372b0c5161, 2022-12-20T10:29:14.590Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: Yes

You mean do not see any extensions in the Extensions view? May I know if extensions are running? Can you please extensions folder F1 > Extensions: Open Extensions Folder and let us know what do you see there?

there are still my installed extensions.
pic 1: i install extension and then i but the refresh button, there is no
extension in the Extensions (pic 2).It happens with every extension.
[image: image.png]
[image: 3350717f-97d7-435e-be25-4effbe790a23.png]
Vào Th 5, 22 thg 12, 2022 vào lúc 21:46 Sandeep Somavarapu <
@.***> đã viết:

You mean do not see any extensions in the Extensions view? May I know if
extensions are running? Can you please extensions folder F1 > Extensions:
Open Extensions Folder and let us know what do you see there?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/169808#issuecomment-1362924978,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWCXC3G4KMUE2RWG3ONXYHTWORSSVANCNFSM6AAAAAATGP5DWQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

@theluctran Unfortunately I do not see any pics in the above comment. Can you please share them again?

I've been having the same problem for days now. All my sync'd extensions automatically disappeared, and anytime I install a new extension, it doesn't get saved / sync'd. I don't know what to do, because every time I close and re-open VSCode, it removes any extensions that I have installed.

I'm getting the same issue after I updated to 1.74.2. I checked the extension folder and all extensions are still there, the problem is that the extensions.json is somehow reset.

After recovering extensions.json from sync, extensions seem to work, but all of them are gone (and extensions.json is reset again) if I refresh the extension window.
Resetting vscode version back to 1.74.1 seems to solve the problem.

and anytime I install a new extension, it doesn't get saved / sync'd.

@pcgeek86 What do you mean by not getting saved? Does the extension gets uninstalled automatically? Can you please try to reproduce it again and provide us following logs?

F1 > Set Log Level... > Trace
Reproduce the issue
Provide us with shared log F1 > Open View...  Shared

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Awaiting Subject.OnNext

I'm using RX + Azure WebJobs to build a simple queue-based MessageBus. I have dozens of "events" that can be fired based on incoming and outgoing data, and multiple handlers, implementing IObserver, can subscribe to the same event.
It all works great, but I'm having some concurrency issues that are hard to track down. I suspect it's because most of my implementing methods are async, but my RX call is not. When I call subject.OnNext(item), I want a clean way for all of my subscribers to be able to call Async methods all the way up the chain. Ideally, I'd be able to call await subject.OnNextAsync(item) and have everything structured the way I have it now.
Is there a better way to handle this? If not built in, something I can build with an extension method, or something like that?
Thanks!

I think this is one for StackOverflow.com if you post a reproduce-able sample there, you will no doubt get some quick and helpful responses.

I don't believe StackOverflow is the answer here. What I'm proposing is that there needs to be a new function that can handle the fact that it is possible to call async code within OnNext. The following needs to be added to SubjectBase
public abstract async Task OnNext(T value);
And the following needs to be added to Subject and AsyncSubject:
public override async Task OnNext(T value);
That would allow for OnNext calls to be awaitable.

I can't speak for the team, but given how this impacts the IObserver<T> contract - and the potential flow-on effects, I'd like for this to be done as a proposal so we can consider things in a holistic way.
@advancedrei do you have an example of the code you've written to work around this issue?

Calling asynchronous functions in a sequence is what the "sequential composition" operator of the magical "Continuation Monad" is for; a.k.a, Rx's SelectMany operator. Is it possible that using subjects is simply the wrong way to solve your problem?
from e in event
from x in CallAsync(x)
from y in CallNextAsync(y)
from z in CallLastAsync(z)
select new { x, y, z }

Note that when building the code currently in GitHub, though not v2.2.5, adding using System.Reactive.Threading.Tasks allows you to include .ToObservable(scheduler) on each *Async method that you're composing if you want to control concurrency; otherwise, the TPL will most likely introduce concurrency between each from clause. I'm not sure whether the v2.3 beta includes it or not.

@shiftkey From the interface perspective, you're right - I think maybe a new subject type, like "AwaitableSubject", and a new interface ("lAwaitableObserver" or something like that) may be in order.
@RxDave I think you might be thinking that the purpose of this is to "control" concurrency. My purpose is simply to be able to use Async methods (which are mostly the norm in .NET moving forward) inside RX events, without hacks.
OK, so here's the architecture. I'll try to explain it well and keep it succinct. We have built what we internally call a "Simple Service Bus" (or SBB for short), based on Azure Queue Storage, the WebJobs SDK, and RX. (This was built about a year before the ASP.NET Webhooks SDK and Logic Apps, so I'm well aware of those solutions. I have no interest in migrating for now).
As events are generated by our own apps & APIs, as well as from 3rd party inbound webhooks, we have our SBB publish an event onto the queue. The way it is designed, I can do so without the publisher (and thereby the endpoints) taking a dependency on any 3rd party libraries except Azure Storage.
So then in the Core of our system, we have a Dispatcher assembly that lives inside the WebJob and does the dirty work. MessageDispatcher is lObservable, so it observes each message coming off the Queue from the WebJobs SDK, and manages a set of MessageHandlers, which are IObservers. Those MessageHandlers are instanced-up by our IoC container, and the MessageDispatcher constructor grabs those MessageHandlers and subscribes them by the System.Types they handle.
We have a WebJobs QueueTrigger function that calls Dispatcher.Dispatch(message). That function looks like this:
        public void Dispatch(MessageEnvelope messageEnvelope)
        {
            _subject.OnNext(messageEnvelope);
        }

INSIDE the individual OnNext implementations, however, I have to call code that is often Async. My hacks often have to use Sync workarounds to function, like this actual code, which uses NotificationHubs to send push notiﬁcations to my phone:
        internal bool SendChargeFailedNotification(ChargeFailed chargeFailed, TextWriter log, int retryCount = 0)
        {
            try
            {
                var toast = GetNewToast();
                var stripe = chargeFailed.GetCharge();
                toast.Visual.BodyTextLine1.Text = "Charge Failed! (" + (stripe.Amount / 100).ToString("C2") + ")";
                toast.Visual.BodyTextLine2 = new ToastText { Text = stripe.Description };
                ///TOTALLY AWKWARD SYNC HACK BELOW
                var result = HubClient.SendWindowsNativeNotificationAsync(toast.GetContent(), "admin").Result;
                log.WriteLine($"AdminPushNotification Outcome: {result.State}");
                return WasNotificationSuccessful(result);
            }
            catch (Exception ex)
            {
                LogError(log, ex, new Dictionary<string, string>
                {
                    ["StripeEvent"] = chargeFailed.StripeData,
                })
                .Wait();
                throw ex;
            }
        }

I would like to be able to create these internal helper functions as Async methods, so they can be called inside an awaited AwaitableSubject.OnNextAsync(), and have the .NET Framework work its magic. That way, subscribers still fire in order, but the internals can still call awaitable code properly.
I hope that helps. Please let me know if you have any questions.

The overloads of SelectMany that I'm using in my example accept projections that return Task<T>. Have you seen them?
I'm merely suggesting that piecing together the computation by injecting subjects may not be the best design. If instead you simply stick to the functional world of operator composition, SelectMany overloads that accept 'Task' projections do the job nicely.

@RxDave While I admit that I am a relative n00b in the RX space, it is difficult for me to see how the example you are using is relevant to me, given the explanation I gave of our architecture. By the example given, you are assuming the operations are known at compile time, therefore I can "just code in the calls manually". Which "OnNext" gets called for which Type is dynamic and can change at runtime, based on how the MessageHandlers are registered, and the incoming CLR types they are supporting.
While I can see the possibility of using a LINQ query on the registered IMessageHandlers for a given type, looping through the collection, and calling my own awaitable OnNext... at that point, why would I even need Observables, because the Azure Storage Queue + WebJobs are doing the work of "reacting" for us?
I trust the person that designed the code that we're using, and respectfully ask that you consider that neither one of us are in the best position to discuss which approach is the "best" one. If you had the time, I'd love to show you the complete code, and get your opinion on what might be better. But I assume you have better things to do, and if I were to rewrite it, I see a distinct possibility if just using Azure Logic Apps and removing our dependence on RX altogether.
Regardless of opinions on whether our specific architecture is "best", the design of RX as currently implemented does not allow you to call Async code properly inside a Subscriber's OnNext. As Async is the only possible option for certain things (like ModernHttpClient), the currently-shipping architecture is no longer relevant in the modern development world, and IMHO needs to be updated.
Thanks!

@advancedrei I can see how you arrive to this conclusion

the currently-shipping architecture is no longer relevant

but how you arrived at that conclusion is IMO incorrect.
So let me see if I can help lead you down a path, that may help you see why this is not what you actually need.
As @RxDave suggested, you should be using SelectMany (or another compositional method) to allow your execution of the Async methods.
i.e. what you are putting in your subscribe method belongs in your query chain instead.

just using Azure Logic Apps and removing our dependence on RX altogether.

This sounds like it probably is a good plan.
Trying to keep on topic, your code you provide as an example (appreciated), shows some other interesting features:

You throw in your OnNext handler SendChargeFailedNotification
SendChargeFailedNotification returns a bool

These things are key to telling me that they belong in the query chain

possibility of failure,
asynchronous requirement
and has a return value

Let us consider each of these.
 The guidance is that your should not throw in your OnNext handlers. They are just there to be notified that an event happened.
If your OnNext handler is doing so much work that it has a requirement to be asynchronous then you can consider the work it is doing to be an asynchronous sequence with a single event. This then allows it be part of the query chain (composition of asynchronous events). Alternatively the source event can be be passed off to another processor e.g. put in a queue for someone else to process in a blocking,  long running or asynchronous manner.
If your OnNext handler needs to return a value, then it is clearly not the end of the chain or the sink.
In this case it is a candidate for functional composition.
Specifically the function here translates a ChargeFailed value to a bool.
These three things seem like a compelling reason to look at asynchronous functional composition, with is what Rx excels at.
From the information I have, I would suggest that instead of calling the method provided above in the OnNext Handler, it should be modified to something like the code below and moved into the query.
internal IObservable<bool> SendChargeFailedNotification(ChargeFailed chargeFailed, TextWriter log, int retryCount = 0)
{
	return Observable.Create<bool>(observer =>
	{
		try
		{
			var toast = GetNewToast();
			var stripe = chargeFailed.GetCharge();
			toast.Visual.BodyTextLine1.Text = "Charge Failed! (" + (stripe.Amount / 100).ToString("C2") + ")";
			toast.Visual.BodyTextLine2 = new ToastText { Text = stripe.Description };
		catch (Exception ex)
		{
			return LogError(log, ex, new Dictionary<string, string>
			{
				["StripeEvent"] = chargeFailed.StripeData,
			}).ToObservable()
			.Subscribe(_=>observer.OnError(ex));

		}

		return HubClient.SendWindowsNativeNotificationAsync(toast.GetContent(), "admin")
			.ToObservable()
			.Catch(ex =>
			{
				return LogError(log, ex, new Dictionary<string, string>
				{
					["StripeEvent"] = chargeFailed.StripeData,
				}).ToObservable()
				.IgnoreElements()
				.Select(_=>false)	//Convert what I assume is a Task -> Unit -> Bool
				.Concat(Observable.Throw<bool>(ex))
			})
			.Subscribe(result =>
				{
					log.WriteLine($"AdminPushNotification Outcome: {result.State}");
					var value = WasNotificationSuccessful(result);
					observer.OnNext(value);
				},
				ex => observer.OnError(ex));
	});
}

It obviously still has plenty of room for improvement.
The logging code, if it really is asynchronous and is pervasive in the code base with Rx, then this is a clear candidate for some helper method.
Logging and Rx has been thrashed out plenty, so I wont go into it here.
There is a retryCount value passed in to the method, that is not used.
Again, Retry is something that Rx can do for you and also something that would then belong in the query chain.
I hope this helps you with your work, and also helps lead you to why people are against the introduction of an async OnNext handler method.

I very much appreciate the super-thoughtful method with which you approached this (no BS or sarcasm here). I will read this over several  times tomorrow AM, reflect on it a bit, and get back with you at some point later in the day. Seriously, thanks.

OK, so I've read over this. I really appreciate the time you've taken to explain your viewpoint, and write code that you think will help.
I think the key element you are missing  is "what" I'm trying to observe. I'm observing messages coming off a queue. I don't need to observe any of the other stuff. I have no issue if the control flow takes a while, because the event I'm observing already happened, and the WebJobs SDK already has a way to handle transient issues.
I throw exceptions inside these individual helper functions because that is how the WebJobs system needs to function in order to drop the message into a "poison" queue to get handled as an error. The application functions very predictably at that point, it shuts down and restarts. I am fine with that, because the whole point of our architecture is to process incoming events from different sources out of band from our web APIs.
To be frank, here's the part I don't understand... if I was using the most common RX use case I've seen: observing click events in an app, and using multiple subscriptions to those events to process various actions, one of them could be an instrumentation subscription that reported back to Application Insights. In that case, I would still have the exact same problem, because AI APIs are asynchronous, and this RX one is not.
And while I really appreciate that you tried to help give me "what I actually need", as you put it, your code is twice as long, convoluted, and unnecessary. I don't see how making my code twice as long and convoluted is any better of a solution than just letting me able to call await AwaitableSubject.OnNext(item), and use the exact same code I'm using today (because that code is clean, it's awesome, and it works well. It's just not what you're used to).
I'm really trying to be constructive here, but I think maybe you guys are so used to using RX a certain way that you aren't seeing the forest for the trees.
Thanks for your time.

I would have to agree with @shiftkey here. It isn't a simple matter of adding another Subject type, I think you would need to re-implement all of the operators to support this new set of methods. Moreover, I'm not sure I entirely understand what kind of semantics you would expect from it, since it would likely break down at the first sign of a scheduler.

_subject.observeOn(Scheduler.Default).Subscribe(x => Console.WriteLine(x));

//What is being awaited here? The task to be scheduled or the OnNext block to be run?
await _subject.OnNextAsync(event);

I'll throw out another suggestion which is to try moving your logic down stream. Right now it would seem that you have an Observer from which you are trying to handle all the logic within the OnNext callback. I would suggest that instead of simply attaching an Observer during your handler hook up phase, that you inject a pipeline.
As a slightly nonsensical example would be:

class MessageHandlerImpl : MessageHandler<T> {

  public IDisposable OnHookUp(IObservable<T> source) {
    return source.SelectMany(async x => await SendChargeFailedNotificationAsync(x, this.textWriter))
                 .Subscribe(result => HandleResultOfWorkSync(x));
  }

}

// In your MessageDispatcher hookup logic
handlerInstance.OnHookUp(_subject);

//Then this works again

_subject.OnNext(messageEnvelope);

@paulpdaniels I really appreciate your additions to the discussion. The short answer from the question in your first example is that you're awaiting the code inside the OnNext block. I think that question for the scheduler could be solved with some kind of hinting, and the question for the end-developer could be solved with clear documentation.
I have to admit, initially I didn't like the second example. But the more I think about it, redesigning how the messages are dispatched might help. Would you happen to be available for a few hours to consult on the project?
Thanks!

A parallel universe of Rx with async signatures can definitely be envisioned; in fact, we've built a partial implementation of this for a service here internally, where query operators may have to call out to async functions, hence requiring the observer contract (etc.) to be async as well. The drawback is the big oil spill it creates over the entire operator surface (the same holds for Ix-Async), so more design work is needed. When I find some cycles here, I'll try to distill the essence of our implementation and share it here.

FINALLY!!! I'm not crazy after all! 😀
@bartdesmet Do you envision that as something that could be an add-on package to the non-async version? Or do you see it as something being a part of the core implementation/NuGet package?

Is there any progress in this topic?

@bigdnf, meanwhile, @bartdesmet has published AsyncRx.NET. To my knowlege there is not any nuget package released for it and any active (at least public) development on it.

It would be nice if someone from MS give some info about roadmap for that feature. I can't imagine Rx without full async/await support.

shame, shame, shame ;)

Why would you await OnNext? Do you expect some reliable delivery mechanism? Rx is about an unidirectional fire-and-forget by default.

I explained it extensively in this thread and have no interest in rehashing it. In the nearly 3 years since this was last discussed, we've moved even closer to an async-first world. I'm surprised (but somehow not) that the use case for Async even needs to be explained.

For me it is simple - current codebase have async/await in many places and I cannot use them right now. Of course I can use " GetFooAsync(...).GetAwaiter().GetResult();" when I'm using some async code but I would prefer not to do this.

@robertmclaws would you consider as a solution an overload of the Subscribe method that accepts asynchronous onNext actions?
public static IDisposable Subscribe<T>(this IObservable<T> source,
    Func<T, Task> onNext, Action<Exception> onError, Action onCompleted)
{
    return source.Select(async x =>
    {
        await onNext(x);
        return Unit.Default;
    })
    .Merge()
    .Subscribe(_ => { }, onError, onCompleted);
}

This implementation notifies all subscribers concurrently, and each subscriber is also notified concurrently about new values. So if for example the source sequence emits 10 values in quick succession, and there are 10 observers with long-running asynchronous onNext subscriptions, it is possible that all 100 tasks will be up and running concurrently. Is this behavior desirable?


Raise exception on write() if stream is not writeable

Fixes #13.
I had to change how isWritable does the check, as is_writable($meta['uri']) is unreliable for TEMP and MEMORY streams.

Updated!

Added tests for all modes that make sense; did the same for isReadable.

Thanks @mtymek

@mtymek merged, thanks!
master: zendframework/zend-diactoros@d7d77518cc86ac509747a11a5953cd3668d68a5a
develop: zendframework/zend-diactoros@4718cf47d688f8c1a9091bacc433c52451abcb49


Extension Settings are not working

This plugin is really nice, but I found that the extension settings are not working.
I am using this plugin for my hexo, and I modified the user-settings as follow:

Then after I pasted an image by using "Ctrl+Alt+V",the plugin behaved like this:

But actually, it was expected to behave like this:

While the image was inserted to the path correctly.

I think the plugin ignored my custom settings and turned to use the default setting. However, I found there no similar issue, that's totally strange.
Is this a bug or just wrong environmental settings, could you please answer my quesion? Thank U so much.
Windows 10,
VSCode: 1.42.0
VSCode-paste-image: 1.0.4

Having a similar issue, the following seems to use the default setting ${projectRoot} rather than the expected


103 video support on notes

This issue is done. Video support is now available on mobile. When you upload a video to the text editor it opens an inline video player with the TipTap player. You can save it like this too and when it loads back the video remains within the editor. We need to look into what this means on mobile.

Marking for ready for review. However, there was no way that I found in which we could edit the size of the video player in the textbox. This may grow to be problematic and likewise a less desirable feature than we were hoping.


Update to latest & android compile fixes

Changes

By default don't use  noexcept, it is varied across all different compilers and STLs so = default is good enough
Android GCC 4.9 doesn't support templated variables, use structs instead

Note: There was some git branch juggling that happened to avoid a massive amount of incompatible merge conflicts. The previous state has been kept in the runtimecore-old-2018... branch

@crezefire I don't see the lua file that we need to build this library?

Disregard my lua comment.  I forgot that this was header only :)


intel_adsp/ace: power: fix address space annotation for powerdown

power_down() expects a cached pointer. Fix the sparse annotation to match the implementation (sys_cache_cached_ptr_get() returns a cached pointer so this is correct).
Fixes: f54232e9124d ("intel_adsp/ace: power: Do not re-implement cache func")

V2:

fix style warning (add whitespace right of "*")
drop the fixes-by  based on feedback from @marc-hb

@marc-hb wrote:

You're fixing the prototype of power_down() that this commit did not touch; the prototype has always been wrong from
the start? Maybe mentioning the prototype of power_down_cavs() would be useful.
If the prototype of power_down() had always been wrong, then why is sparse finding this only now?

power_down is an assembly routine, so this is a bit of a special case (C compiler cannot verify that implementatoin and declaration match in the same way as for normal routines implemented in C). The extern declaration for the function was indeed wrong, and I'm fixing that with this commit.
Dropped the fixes tag -- it's debatable whether it's correct or not. Old code uses a local copy of uncache_to_cache() which is not sparse-aware, but oh well.

It's very good to have a reference to this commit that exposed the issue but ...

Dropped the fixes tag -- it's debatable whether it's correct or not.

Too bad you're not mentioning the "messenger" commit any more at all in the commit message (the PR description is out of date right now)

C compiler cannot verify that implementatoin and declaration match in the same way as for normal routines implemented in C

Not sure how that matters: even in pure C, power_down() could have had consistently wrong sparse annotation. Nevermind.

Old code uses a local copy of uncache_to_cache() which is not sparse-aware, but oh well.

I'm disappointed by the "oh well" because this is exactly what I was trying to get at: is there a (much?) bigger problem with uncache_to_cache()?
Don't get me wrong: I'm NOT asking for this PR to fix such a bigger problem if any. But it should really be clear whether there is such a problem or not.
I never had a good understanding of how sparse works but "uncache_to_cache() is not sparse-aware" sounds very surprising and TBH: pretty bad. No?

This power code uses a local version of uncache_to_cache()

Or rather: "used" past tense because removed by commit f54232e9124dd1318190fdf7c4897d4d33deca66
So it was really the case of "two (small) sparse wrongs make a right", which is always confusing type of situation. Thanks for your patience.
Even more confusing because the local version of uncache_to_cache() was also removed by commit f54232e9124dd1318190fdf7c4897d4d33deca66 - "messenger" commit which was correct and should not be "killed" but definitely be referenced in this commit message.

This looks good from my perspective. The implementation of power_down() is voodoo anyway[1], of the form "leave it to the hardware people because no one without register specs can possibly maintain it". Given that, API hygiene kind of takes a back seat: if it's cached it's cached, and we should just make sure sparse can see that it's cached.
[1] It wants that to be a cached pointer so that it can fetch and lock it with a DPFL instruction, presumably because it needs to survive an impending shutdown of the SRAM banks?

that is my understanding as well.


Fetcher slow mode is inconsistent

I see what the problem is now.  The slow mode button changes the amount that is added to the current fetcher target each cycle.  But in fast mode, the target changes way faster than the fetcher actually moves.  It will still go just as fast to get to the way-high target even after you change the rate at which the target changes from there.  The process will reset when you let go of the joystick and the target is made equal to the encoder again.
One solution is to change the PID's speed with the setPower command, rather than change the joystick rate.  Or we could do more tuning and path planning to make the joystick target not get so far from the actual position.

Derp.  The simplest solution is to make the slow mode button justPressed or justReleased call fetcher.stopExtension(), then continue moving from there at the new speed.

Can be addressed as part of #20

I forget if they tested this, but yes it should work now.


[RFC] ProviderInterface::getAuthenticatedRequest() method

This would give users of Providers a method that returns an already-authenticated HTTP client, using the token retrieved in the OAuth 2.0 flow. They may then use this client object to make authenticated requests of whatever provider API they are using, without the OAuth 2.0 Provider classes becoming API wrappers.
From @shadowhand in the comments on https://github.com/thephpleague/oauth2-client/issues/265#issuecomment-94943566:

One of the things that always bothered me about this library (and am moving towards solving with #232) is that it doesn't do very much to make using the provider APIs easier, it only gets us to the point of having an authenticated token.
I'll be very clear here and say that the goal is not to create API wrappers with providers. However, I think a very valuable part of this package is that it makes it easier to use provider APIs and so any changes we are proposing here should keep that in mind.
To this end, what are valuable things this package can do to make API usage easier?

Ensure that providers contain a method to fetch an API base URL. This is not very useful by itself, but it makes writing multiple API calls much DRYer.
Ensure that providers contain a method to add authentication to a request. This is what #232 did (see also thephpleague/oauth1-client#18) and it immediately improved the code I was working on that made API calls.
Provide ways to integrate more cleanly with dependent packages. The client already uses Guzzle, so it should expose methods that work with those classes. For instance, having a method like this would save a lot of repeated code:

/**
 * Create an authenticated client to access an API URL.
 *
 * @param  string $method
 * @param  string $path
 * @param  AccessToken $token
 * @return Psr\Http\Message\RequestInterface
 */
public function getAuthenticatedRequest($method, $path, AccessToken $token);

This would allow us to write code like:
$request = $client->getAuthenticatedRequest('GET', 'me?fields=id,name,email', $token);
$response = $client->send($request);
$me = json_decode($response->getBody());

Personally I would find this to be a very useful and complete example of how to build upon what the package provides and represents best practice.

One possible tweak? :)
$authClient = $client->getAuthenticatedRequest($token);

$request = $authClient->request('GET', '/me', ['fields' => 'id,name,email']);
$response = $authClient->send($request);

Then you'd also have the same function signature for POST, DELETE, etc. :)

@SammyK the signature of my example is also consistent for every method. What makes yours more consistent?

I think @SammyK is advocating for just returning the HTTP client object rather than actually making the request, which is what it appears getAuthenticatedRequest() is designed to do.
I'm in favor of returning the HTTP client with all authentication details set on it and letting the user make any subsequent request they like.

So, maybe the method should be getAuthenticatedClient()?

@ramsey that would be a misinterpretation... the PSR-7 RequestInterface is only a container, it would never actually generate a response until it is passed into a client with send($request).

I think I understand what the suggestion is, but I would prefer that the object coming out of getAuthenticatedRequest be a standard PSR-7 Request object with a pre-filled header or query parameter, depending on the provider's requirements.

Okay. I think I see where you are going, as well. Where does the getResponse() method come from? I don't see that on the RequestInterface.

Oh that's just bad editing on my part. The getResponse shouldn't be there
at all.

Oops! I've edited the example and removed it. :-)

I've made a couple of more changes to the variable names on the example that I think make it clearer (I hope). Let me know if my assumptions were correct.

@ramsey was trying to get to this today but stalled out doing some other cleanup work. Will start on it soon!

PR created in my local fork, blocked until #274 is merged.

@ramsey this can be closed, not sure why my PR didn't automatically close it out.

No worries. I think it has to be merged into master before it fully closes issues on GitHub.


returning error when Eloquent model is null

I'm using dev-master of fractal.
Suppose I have 2 transformer: PhotoTransformer and CityTransformer.
In my CityTransformer I have a default include of photo and includePhoto(City $city) method.
sometimes tough, photo model got from includePhoto method returns null. and I get an exeption. for example:
public function includePhoto(City $city)
    {
        return $this->item(null, new PhotoTransformer());
    }

What happens here, I get an error
   "message": "Type error: Argument 1 passed to app\\Api\\Transformer\\PhotoTransformer::transform() must be an instance of App\\Photo, null given.
What I want is to return json object for city like: photo{ } or completely remove photo object from response.But that's not happening.
How can I make that happen?
I know I can check for null manually and return $this->null() but this is a common pattern for my api so that would become cumbersome.
Tnx

Up

plus one on this, create allot of boilerplate

Came here looking for this exact issue as it's something I'm trying to resolve. Sad to see this unanswered from April...
Is Fractal still in active development at all?

if this is still an issue, please reopen the issue. However since it is now a few years old, we will close it for now.


v2 - member portal - wrong name displayed for company acknowledgment with broken icon

When a user acknowledges under a ccla, a row is created in the 'contributor acknowledgments' section of the member portal. For a user without a public github name, the "Name" shows another person.

"Neal Poczar" is not the name of the user who verified with the CCLA. It may be an alias of the person who created the Salesforce company record last year. It is not known how this value was filled.
The correct user has correct info in database and should be using that information.

when adding a user_name field to the user's record, it fixed the issue. We need to account for users from github especially not having user_names and user something else or leave it blank. the icon is still broken

created LFX-3112  for the broken icon.

verified on prod


graph routing error

found bug-- only left channel was getting connected under default Delay construction

nice, @jvntf !


Hi, I want to kindly remind you that the readme link is broken

This is the one in the readme:
https://swiftuix.github.io/SwiftUIX/documentation/SwiftUIX/
This is the correct one:
https://swiftuix.github.io/SwiftUIX/documentation/swiftuix/

Alright I will create a pr to fix this tiny mistake.


Only process tables with nice names

This script fails in many place when tables have names that require quoting, for example:
my_schema."my-stupid-table-name"
Rather than try to quote everywhere, this pull request simply skips those tables.
This was discussed in an earlier issue https://github.com/awslabs/amazon-redshift-utils/issues/54 but it seems nobody is keeping up with comprehensively quoting names. Skipping seems like the simplest solution.

It's not ideal, but I think this is a reasonable constraint for now. Thanks for the PR


bug: Type error from parser run services

Parser run services are experiencing an error when receiving events:
2022-07-13T01:57:27.126156ZTraceback (most recent call last): File "/usr/local/lib/python3.7/site-packages/gunicorn/arbiter.py", line 583, in spawn_worker worker.init_process() File "/usr/local/lib/python3.7/site-packages/gunicorn/workers/gthread.py", line 104, in init_process super(ThreadWorker, self).init_process() File "/usr/local/lib/python3.7/site-packages/gunicorn/workers/base.py", line 129, in init_process self.load_wsgi() File "/usr/local/lib/python3.7/site-packages/gunicorn/workers/base.py", line 138, in load_wsgi self.wsgi = self.app.wsgi() File "/usr/local/lib/python3.7/site-packages/gunicorn/app/base.py", line 67, in wsgi self.callable = self.load() File "/usr/local/lib/python3.7/site-packages/gunicorn/app/wsgiapp.py", line 52, in load return self.load_wsgiapp() File "/usr/local/lib/python3.7/site-packages/gunicorn/app/wsgiapp.py", line 41, in load_wsgiapp return util.import_app(self.app_uri) File "/usr/local/lib/python3.7/site-packages/gunicorn/util.py", line 350, in import_app __import__(module) File "/app/main.py", line 19, in <module> import shared File "/usr/local/lib/python3.7/site-packages/shared.py", line 17, in <module> from google.cloud import bigquery File "/usr/local/lib/python3.7/site-packages/google/cloud/bigquery/__init__.py", line 35, in <module> from google.cloud.bigquery.client import Client File "/usr/local/lib/python3.7/site-packages/google/cloud/bigquery/client.py", line 58, in <module> from google.cloud.bigquery import _pandas_helpers File "/usr/local/lib/python3.7/site-packages/google/cloud/bigquery/_pandas_helpers.py", line 40, in <module> from google.cloud.bigquery import schema File "/usr/local/lib/python3.7/site-packages/google/cloud/bigquery/schema.py", line 19, in <module> from google.cloud.bigquery_v2 import types File "/usr/local/lib/python3.7/site-packages/google/cloud/bigquery_v2/__init__.py", line 23, in <module> from google.cloud.bigquery_v2 import types File "/usr/local/lib/python3.7/site-packages/google/cloud/bigquery_v2/types.py", line 23, in <module> from google.cloud.bigquery_v2.proto import encryption_config_pb2 File "/usr/local/lib/python3.7/site-packages/google/cloud/bigquery_v2/proto/encryption_config_pb2.py", line 64, in <module> file=DESCRIPTOR, File "/usr/local/lib/python3.7/site-packages/google/protobuf/descriptor.py", line 560, in __new__ _message.Message._CheckCalledFromGeneratedFile() TypeError: Descriptors cannot not be created directly.
Full log:
runlogs.txt

Looks like it's a problem with the underlying protocol buffers:  https://github.com/protocolbuffers/protobuf/issues/10051
Looking at the logs, it looks like it's a problem with the bigquery import.

Maybe try bumping the version on all the libraries and see if that helps?  The one we're using is quite old.  bq-workers/github-parser/requirements.txt