[Search Emoji] Add support for Unicode 15.1

Description
Adding support for Unicode 15.1 to the Search Emoji extension. Mostly duplicated from #6417.
(I really like using the "nodding" emoji 😅🙂↕)
Screencast
before:

after:

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Looks like CI is failing with this error:
Error:    9:4  error  Invalid contributor "kidonng". Error: Not found (RequestID: 3474e2f2-1270-4263-b521-6ec7440bdf0a)
Error:   12:4  error  Invalid contributor "sinasab". Error: Not found (RequestID: 81e2e5d9-bdfb-4522-9db2-57e0160bba5b)

Happy to address this, but not sure how; would appreciate any insight 😁

Oh, should the contributors field be set to my raycast handle? I had it set to my Github, happy to correct it if that's the case; my raycast handle is sina_sabet.
My first contribution to this large repo, so appreciate the patience 🙏

@pernielsentikaer thanks for the guidance! I just updated my raycast handle to match my github, so a re-run of the CI should reflect that.
Not sure what to do for kidonng's handle though, please let me know if you have any ideas. Would love to get this merged so I can more easily paste the new emojis 😃 🙂↕

Awesome, thank you 😄


Add section on how Data Explorer authorizes against Event Hub

In the "Connect to the event hub" section above, nothing is said about how the Data Explorer cluster gets authorization to read from the event hub. Testing a simple setup, I have found that ingestion seems to work without having assigned a managed identity to Data Explorer (to be able to assign to it the "Azure Event Hubs Data Receiver" role) and without having created "Listen" authorization rules on the event hubs. Unless there is some internal magic going on, I can only assume that the "RootManageSharedAccessKey" from the event hub name space is used, but I would very much like to know with certainty how this actually works. Could you please add a little about this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d5808ed2-5d09-4c56-dc0b-4e3650f8fc16
Version Independent ID: ba034a8d-d5bb-6ea4-e61b-74ea3a5eb2be
Content: Ingest data from Event Hub into Azure Data Explorer
Content Source: data-explorer/ingest-data-event-hub.md
Service: data-explorer
GitHub Login: @orspod
Microsoft Alias: orspodek

@m2000ank thanks for your feedback.
@kerend are you able to assist?

Yes it is using "RootManageSharedAccessKey"

@basaba - thanks for your assistance. @m2000ank - does that answer your question?

Yes it does, thank you @orspod and @basaba. However, since this is a very implicit dependency, I would appreciate it being mentioned in the documentation as well. What happens if that key is rotated, for instance? Is intervention necessary on the Data Explorer side, or will it sort itself out in some way?

Hi @m2000ank ,
In case of key rotation, the best practice is to update the data connection (using ARM template for example) with the exact same properties (actually you don't update any property but to process trigger re-fetching of the new keys).
In addition, we plan to support managed identity based data connection for better security of our customers' data sources (we wouldn't hold EH keys in that scenario). The customer would grand the managed identity Read permission.
Unfortunately, there is no ETA yet.

@m2000ank hope this answers your question

@m2000ank  Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly reopen the issue and continue the discussion.

Hi @m2000ank, In case of key rotation, you should rotate in 2 steps, with interval of few hours in between. Our service will pickup the first rotation and will auto update the connection and fetch the new keys. During this time the connection works with the secondary key.
After the second rotation, same process is done and we end up with 2 fresh keys.
I will add this explanation to the docs.

Hi, everyone. Sorry for the late reply, and thanks for the details on key rotation. Looking forward to be able to use managed identity for this.


Documentation for Tabs does not set type on tab roots -> tabs don't show up

From @marcusforsberg on March 27, 2017 16:5
Ionic version:
[ ] 1.x
[x] 2.x
I'm submitting a ...
[x] bug report
[ ] feature request
[ ] support request
Current behavior:
The documentation for the Tabs component (https://ionicframework.com/docs/v2/api/components/tabs/Tabs/#usage) does not set a type for the "tab roots". For me, when copying the example code as a base for my project (which was based on the blank template), this resulted in the tabs not showing up at all until I added any as the type.
Expected behavior:
Adding any as the type for the tab roots makes the tabs show up again. any is also included in the tabs starter template. If this is correct, it should probably be added to the example in the docs.
Steps to reproduce:
Just follow the usage example for tabs step-by-step: https://ionicframework.com/docs/v2/api/components/tabs/Tabs/#usage
Related code:
Specifically, it's this part of the docs, in TabsPage
 tab1Root = Page1;
 tab2Root = Page2;
 tab3Root = Page3;

This should include the type, any (?).
Other information:
I can go ahead and submit a PR but wanted to follow the contribution guidelines to the point and open an issue first :) Also wanted to double check that any is indeed the type to use here.
Copied from original issue: driftyco/ionic#10933

Hmm, the type, like all typescript types are optional, so they're definitely not needed.
Just tested this out with the latest stable release.
export class TabsPage {
  // this tells the tabs component which Pages
  // should be each tab's root Page
  tab1Root = HomePage;
  tab2Root = AboutPage;
  tab3Root = ContactPage;

  constructor() {

  }
}

And the tabs loaded correctly.


[nmstate-0.3] connection: retry on profile activation if libnm error happened

When activating a profile if NetworkManager fails during the activation,
Nmstate should retry it once.
Then mark_as_managed is not needed anymore and is being removed.
Signed-off-by: Fernando Fernandez Mancera<EMAIL_ADDRESS>

@ffmancera To minimize the changes, could you only include the retry code and still keep the set_managed workaround?


update version

Can you please add a description and also update the title to reflect what this PR is doing?


Vue 2.0

@kcalliauw  do you have any plans on update this bootstrap project to use the version 2.0 of vue and the other components?

@gpassarelli
I have been trying to upgrade to vue 2....  but I am pretty stuck on the bootstrap.js file... specifically on the render part .. I am getting a blank screen. @kcalliauw made a sick little app here but a bit difficult to modify.
`const App = Vue.extend(require('./compiled/app.vue'))
new App(router).$mount('#app')
// blank screen
//new Vue(Vue.util.extend({router}, App)).$mount('#app');
// still need to fix this....
//router.start(App, '#app')
//window.router = router
`
Other than that I believe I have the routes working. In tandem I am working on the webpack version, trying to get that to @kcalliauw style working example

can you push the v0.12 version ? I can't find it


Remove deprecated properties in next major release

The UK units are deprecated in favor of UK2, and offset on Forecast is also deprecated. Remove these and other deprecated properties in v3.0.

 Remove deprecated properties


Version 0.4.1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.805%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
248

Relevant Lines:
251

💛  - Coveralls


501 Not Implemented

While running videojs it returns 501 Not Implemented.

It shows, Video successfully uploaded but no video found.
<!doctype html>

Audio/Video Example - Record Plugin for Video.js
    <!-- Include Video.js stylesheet (https://videojs.com/) -->
    <link href="https://cdnjs.cloudflare.com/ajax/libs/video.js/7.0.0/video-js.min.css" rel="stylesheet">

    <!-- Style of VideoJS -->
    <link href="https://cdnjs.cloudflare.com/ajax/libs/videojs-record/4.5.0/css/videojs.record.min.css" rel="stylesheet">

    <style>
    /* change player background color */
    #myVideo {
        background-color: #9ab87a;
    }
    </style>
</head>
<body>
    <!-- Create the preview video element -->
    <video id="myVideo" class="video-js vjs-default-skin"></video>

    <!-- Load video.js -->
    <script src="https://cdnjs.cloudflare.com/ajax/libs/video.js/7.0.0/video.min.js"></script>

    <!-- Load RecordRTC core and adapter -->
    <script src="RecordRTC.js"></script>
    <script src="adapter.js"></script>

    <!-- Load VideoJS Record Extension -->
    <script src="https://cdnjs.cloudflare.com/ajax/libs/videojs-record/4.5.0/videojs.record.min.js"></script>
    <script>
    var videoMaxLengthInSeconds = 120;

    // Inialize the video player
    var player = videojs("myVideo", {
        controls: true,
        width: 720,
        height: 480,
        fluid: false,
        plugins: {
            record: {
                audio: true,
                video: true,
                maxLength: videoMaxLengthInSeconds,
                debug: true,
                videoMimeType: "video/webm;codecs=H264"
            }
        }
    }, function(){
        // print version information at startup
        videojs.log(
            'Using video.js', videojs.VERSION,
            'with videojs-record', videojs.getPluginVersion('record'),
            'and recordrtc', RecordRTC.version
        );
    });

    // error handling for getUserMedia
    player.on('deviceError', function() {
        console.log('device error:', player.deviceErrorCode);
    });

    // Handle error events of the video player
    player.on('error', function(error) {
        console.log('error:', error);
    });

    // user clicked the record button and started recording !
    player.on('startRecord', function() {
        console.log('started recording! Do whatever you need to');
    });

    // user completed recording and stream is available
    // Upload the Blob to your server or download it locally !
    //player.on('finishRecord', function() {

        // the blob object contains the recorded data that
        // can be downloaded by the user, stored on server etc.
      //  var videoBlob = player.recordedData.video;

        //console.log('finished recording: ', videoBlob);
    //});

	// user completed recording and stream is available
	player.on('finishRecord', function()
	{
		//player.record().saveAs({'video': player.recordedData.name});
		//console.log('finished recording: ', player.recordedData);
		// the blob object contains the recorded data that
		// can be downloaded by the user, stored on server etc.
		console.log('finished recording: ', player.recordedData.video);

		// Create an instance of FormData and append the video parameter that
		// will be interpreted in the server as a file
		var formData = new FormData();
		formData.append('video', player.recordedData.video);
		console.log(formData);

		//var videoBlob = player.recordedData.video;

		// Execute the ajax request, in this case we have a very simple PHP script
		// that accepts and save the uploaded "video" file
		xhr('https://<IP_ADDRESS>/static/upload-video.php', formData, function (fName) {
			console.log("Video succesfully uploaded !");
		});

		// Helper function to send
		function xhr(url, data, callback)
		{
			var request = new XMLHttpRequest();
			request.onreadystatechange = function ()
			{
				if (request.readyState == 4)
					if (request.status == 200)
					{
						console.log("success");
						callback(location.href + request.responseText);
					}
					else
						console.log(request.responseText);
			};
			request.open('GET',url);
			request.send(data);
		}
	});
	</script>
</body>

upload-video.html

// In this case the current directory of the PHP script
$uploadDirectory = './'. $fileName;

// Move the file to your server
if (!move_uploaded_file($_FILES["video"]["tmp_name"], $uploadDirectory)) {
    echo("Couldn't upload video !");
}

}else{
echo "No file uploaded";
}
?>

running videojs it returns 501 Not Implemented.

Where does it say this? can you make a screenshot? I have a feeling this is a PHP issue I can't help you with.

no feedback, closing.


option to specify search pattern explicitly

I don't see an obvious way to search for a pattern that looks like an option. E.g., say I wanted to search for the string "----------------------":
$ag '----------------------' -Q ag: unknown option -- --------------------
Ack has this implemented as the '--match' option.

See #941
Specific my comment

Thanks, I forgot about double dash. Seeing as this has been raised as an issue multiple times now, should there perhaps be a note or example in the man page? It is mentioned in the man pages of 'rm' and 'find' on my system:

To remove a file whose name starts with a '-', for example '-foo', use one of these commands:
          rm -- -foo

And from man find:

A double dash -- can also  be  used to signal that any remaining arguments are not options

I think that a note in the manpage would be helpful.

I've seen this come up a lot on here too. Submitted PR #985 to add an example to the manual.

Thanks for the PR, @okdana. I'm closing this now that -- is documented.


[DOC]: ./gradlew: not found error when running docker image on Windows

What are you missing in the docs
When we try to build docker image for conductor server on Windows, it throws -

[conductor:server builder 4/4] RUN ./gradlew build -x test --stacktrace:
#24 0.398 /bin/sh: 1: ./gradlew: not found
So I found a solution to do that and I have added steps for the same below.

Proposed text
./gradlew: not found when running on Windows

Switch the line endings to "LF" from "CLRF" in gradlew file.
In IntelliJ - From the main menu, select File | File Properties | Line Separators, and then select LF - Unix and MacOS(\n).
In Eclipse - Go to Window | Preferences | General | Workspace | New Text file line delimiter -> Other -> Unix
From the docker directory,docker build --no-cache -t conductor:server -f server/Dockerfile ../

I have added a solution for it. Please let me know if I can assign it to myself and get it merged.

I found another similar issue that when we are trying to build docker compose on windows. I was facing an error ./gradlew: not found.
I fixed it by changing the line seperator in gradlew so docker build was able to built it successfully but when I tried to run the server it was again throwing some exceptions. Reason for this issue is that when we clone code in windows machine it by default uses CRLF as line separator and due to this all scripts have CRLF line separators as EOL and they broke.


#306: Modify BkBasic for persistent conections according to HTTP 1.1

#306 Modify BkBasic checking headers and modifying resposes for http conections according to HTTP 1.1

@lautarobock Thanks, I will find someone to review this PR soon

@pinaf please review,thanks

@lautarobock sorry for the delay

@lautarobock 12 comments above

@lautarobock nice PR!

@pinaf there is a new commit with fixes

@lautarobock looks good

@lautarobock thanks

@rultor merge

@rultor merge

@pinaf Thanks for your request. @yegor256 Please confirm this.

@lautarobock the implementation is OK, but the way you test it is rather bad. Mocking, in general, is a bad practice, see http://www.yegor256.com/2014/09/23/built-in-fake-objects.html Instead of mocking a Socket, let's create a proper HTTP connection and send some data into it in a few sessions and see how the server will behave. More like an integration test..

@yegor256 ok, but the test with mocks was there before. I will change the test, but I think more for a  //TODO or //FIXME for only 30 minutes

@yegor256 Is there a way to make JdkRequest use the same connection? because in JdkRequest:129 the connection is always closed.

@yegor256 test are now with a HTTP connection, but only test the headers, with JdkRequest can't re-use the same connection

@lautarobock I'm not sure we're actually testing anything with this unit test. I think JdkRequest is not suitable for this type of testing. You need to create a connection through HttpURLConnection and manage it yourself, directly, without any help from jcabi-http. Otherwise, as you see, you're not testing the Keep-Alive functionality

@yegor256 how can restart build? I think is not the problem of this PR

@yegor256 ok, I will try with HttpURLConnection

@yegor256 @pinaf there is a new commit using HttpURLConnection

sorry, forget the -Pqulice, i will try again

@yegor256 @pinaf qlice solved

sorry, I sill sick ...

@yegor256 @pinaf done (I hope)

@yegor256 @pinaf done

@yego256 Is this what you were looking for?

@pinaf @lautarobock I don't really like this boolean flag "persistent" in the class. It would be much better to create another class, something like BkPersistent. I'm not sure how, but current implementation is too complex...

@pinaf @yegor256 really I don't like too. But another class implies too mucho redundant code, both options require a post-refactor.

@lautarobock yes, we should somehow get rid of code duplication. let's think...

@yegor256 IMHO I think the actual solution in the minimal enough, the best is to create a new bug with this refactor.

@lautarobock current solution makes the code hard to read. I would recommend you to keep the unit test in the branch and remove the implementation. Then, add a puzzle to the test. Someone later will implement it.

@yegor256 done, remove implementation and let test @Ignore waiting for new implementation

@lautarobock there are checkstyle violations. please fix them and get the travis build to go green.

@pinaf new commit with this fixes, sorry

@lautarobock I don't see the puzzle @yegor256 asked for

@pinaf yes, but, what this mind in this case?

@lautarobock sorry, I don't understand

@lautarobock hello?

@lautarobock if you are not going to merge, could you please close this PR? Thanks!

@lautarobock ping

@pinaf done

@elenavolokhova please, let us know what do you think about this ticket, according to our QA rules

@pinaf

lautarobock commented 29 days ago
sorry, forget the -Pqulice, i will try again

lautarobock commented 29 days ago
sorry, I sill sick ...

According to our quality rules:

Messages in a ticket always start with a name of a user they are addressed to.

As far as you are the performer of this ticket you are responsible for its quality. Please make sure that everyone follows this rule in your tickets in the future. Ask them to fix issues before closing the ticket.
Please confirm that everything is clear and you have no questions regarding this approach.

@elenavolokhova sorry. I'll pay more attention.

@pinaf Thank you!

@davvd Quality is acceptable here.

@davvd Quality is acceptable here.

@elenavolokhova thanks for the QA review, we'll work better next time

@pinaf I added 10 mins to @elenavolokhova (for QA review) in transaction 61660897... 29 mins was added to your account, many thanks for your contribution (payment AP-3CV882267J514640X)! The task took 1006 hours and 59 mins.... extra minutes for review comments (c=14)... +29 added to your rating, at the moment it is: +5729


Draft: SIOP Encryption

Quick draft to encrypt responses from SIOP holders, if the verifier requests it.

Obsoleted by https://github.com/a-sit-plus/kmm-vc-library/pull/78


License

Hi @qulle the project looks very useful and nicely programmed. Currently the project does not have a license, which makes it hard to reuse it in other projects.
Adding a license might attract more people to reuse your code.

Hi @JakobMiksch Thanks for creating the issue. I have now added a license to the project.


Enable Application Insights logging for your API - Frontend Request

Hello,
As WAF is calling our APIM, we are getting WAF IPs recorded in APIM request logs.
We want to get x-forwarded-for which contains IP of actual client into App Insights.
We enabled Frontend Request option in API settings within APIM, but not sure where i can see this info, as i don't see this anywhere in AppInsights.
Also in documentation & Video, it contains how to enable Frontend request but nowhere mentioned about how & where to look this data in logs.
Can you please update this info?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c26c1996-853e-9a55-5802-8c4095d545b9
Version Independent ID: 437f5553-6914-c0ef-9370-bb11d3a0fa4b
Content: How to integrate Azure API Management with Azure Application Insights
Content Source: articles/api-management/api-management-howto-app-insights.md
Service: api-management
GitHub Login: @mikebudzynski
Microsoft Alias: apimpm

@manishjoisar Thank you for your feedback. We will have this reviewed and actioned accordingly.

You need to explicitly set logging of the x-forwarded-for header in the header section here: https://docs.microsoft.com/en-us/azure/api-management/media/api-management-howto-app-insights/apim-app-insights-api-1.png
If you're having troubles seeing data in Application Insights, please open a support request.
#please-close

Thanks for your feedback.  If you look at my comments, i have enable frontend which comes under settings tab of API -> Diagnostics Logs. so that means i have enabled Logging explicitly. But i don't see it anywhere in App Insights request data. So not sure where to see this


Adding Contest Reminders

Is your feature request related to a problem? Please describe.
To implement personalized contest reminders via DM
Describe the solution you'd like
Adding a new command to opt-in/out of contest reminders

Assigned @Jordian0

@jinx-vi-0 Please check this task, i've requested PR.


How to customize log information？

Question
Hello, I'd like to ask. If I want to customize the log information (API call success and failure information, IP, parsing location information, saving specific information, etc.), how should I configure it?

hi， you can see logging plugin，and logging-rockeqMQ plugin.
If it does not meet your needs, you can custom develop  shenyu plugin.

If you have good suggestions or find problems or unmet needs, you can communicate with the community, and the community is willing to improve

If there are still questions, please reopen issue


Use std::unique_ptr instead of new

Summary

Use smart pointer instead of handling raw pointer

Purpose

prevent memory leak

Contents

bb708fa55bac999ac05aa6458268e0576ed25f5c Use std::unique_ptr instead of new

Testing Methods Performed

Run progress_demo.py 3~5 times with N=10,000, valgrind --tool=massif when launching CC
Run CC small, medium test

@mdonaka I changed code, and check that small, medium test are passed at local.
Please review again.


SingleMachine: Does not work on Fedora due to default firewall rules

On Fedora the Single Machine tests do not work due to the default firewall rules.
The DHCP requests directed to the CNCI are blocked by the default firewall rules.
The single machine scripts should be modified to allow the local DHCP request into the CNCI VM.
A workaround for now is to temporarily stop firewalld
sudo systemctl stop firewalld
#And run the script
sudo systemctl start firewalld

@mcastelino Regarding this topic. Is there a plan for handling the firewall from Ciao? Not only for fedora but other distros?

@erick0z it's really hard to know what to do.  There's a tonne of different firewall tools in linux, and at the iptables level they implement "firewall" quite differently in terms of how they use the default tables and add interrelated chains to handle packet flows.  And other system tools tweek things too, eg: docker adds miscellaneous rules into the mix and dynamically manages them.

I'm able to operate on Fedora with the following firewall additions, but note:  I'm not running the distro complex firewall.  I have a modestly complex, relatively restrictive, hand built /etc/sysconfig/iptables ruleset.
Prior to "setup.sh":
{code}
#!/bin/bash
iptables -I INPUT   1 -p tcp -m tcp --dport 8888 -j ACCEPT
iptables -I INPUT   1 -p 47 -j ACCEPT
iptables -I OUTPUT  1 -p 47 -j ACCEPT
iptables -I INPUT   1 -p tcp --dport 22 -m conntrack --ctstate NEW,ESTABLISHED -j ACCEPT
iptables -I OUTPUT  1 -p tcp --sport 22 -m conntrack --ctstate ESTABLISHED -j ACCEPT
iptables -I FORWARD 1 -p tcp --dport 22 -m conntrack --ctstate NEW,ESTABLISHED -j ACCEPT
iptables -I FORWARD 1 -p tcp --sport 22 -m conntrack --ctstate ESTABLISHED -j ACCEPT
iptables -I FORWARD 1 -p udp -m udp --dport 67:68 -j ACCEPT
iptables -I FORWARD 1 -p udp -m udp --dport 123 -j ACCEPT
iptables -I FORWARD 1 -p udp -m udp --dport 53 -j ACCEPT
iptables -I FORWARD 1 -p udp -m udp --dport 5355 -j ACCEPT
#iptables -I FORWARD 1 -p 2 -j ACCEPT
iptables -I FORWARD 1 -p icmp -j ACCEPT
{code}
and after "cleanup.sh":
{code}
#!/bin/bash
iptables -D INPUT   -p tcp -m tcp --dport 8888 -j ACCEPT
iptables -D INPUT   -p 47 -j ACCEPT
iptables -D OUTPUT  -p 47 -j ACCEPT
iptables -D INPUT   -p tcp --dport 22 -m conntrack --ctstate NEW,ESTABLISHED -j ACCEPT
iptables -D OUTPUT  -p tcp --sport 22 -m conntrack --ctstate ESTABLISHED -j ACCEPT
iptables -D FORWARD -p tcp --dport 22 -m conntrack --ctstate NEW,ESTABLISHED -j ACCEPT
iptables -D FORWARD -p tcp --sport 22 -m conntrack --ctstate ESTABLISHED -j ACCEPT
iptables -D FORWARD -p udp -m udp --dport 67:68 -j ACCEPT
iptables -D FORWARD -p udp -m udp --dport 123 -j ACCEPT
iptables -D FORWARD -p udp -m udp --dport 53 -j ACCEPT
iptables -D FORWARD -p udp -m udp --dport 5355 -j ACCEPT
#iptables -D FORWARD -p 2 -j ACCEPT
iptables -D FORWARD -p icmp -j ACCEPT
{code}
I'm not sure what's doing IGMP (protocol 2) inside the cluster.  I don't see anything not functioning without the addition of an ACCEPT rule for it.  But I do see packets logged on the virtual bridge when they hit my end reject rule in the nat table FORWARD chain if I don't accept them.

This issue is resolved by using ciao-down.


DTLS

Since you have QUIC going, then its makes it sweeter to have DTLS ?
https://en.wikipedia.org/wiki/Datagram_Transport_Layer_Security
note near the bottom how its really designed for RTC and QUIC.
one implementation semi working.
https://github.com/pixelbender/go-dtls

ah i did not know that. Oh thats great news. Will make things much easier.


fix unzip command in readme

Looks like the file is now called closure-compiler-v20170423.jar
instead of compiler.jar. This appears to already have been corrected in
the Makefile here.

Thanks!


How to set video frame captuer?

Is there a way to create a video track where frames are passed in via a captureFrame method?

@SeanMooneySavari You can use VideoCapture.setVideoSink and you will the onVideoFrame event.
Once you receive the frame, I haven't figured out what to do with it. Have you worked this out? Or, are interested in collaborating on the solution?

Streaming a file is not supported yet, but will be possible in the near future. For upcoming progress see https://github.com/devopvoid/webrtc-java/issues/87


[$1000] App crashes on iOS simulator on open

Action Performed:
Break down in numbered steps

Pull the latest main
Run npm run ios
Check that the app crashes with an unhandled promise error

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: the latest main branch
Reproducible in staging?: Nop
Reproducible in production?: Nop
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: N/A
Notes/Photos/Videos:
Expensify/Expensify Issue URL: N/A
Issue reported by: @hayata-suenaga
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1693020712748639
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017fd401adeff84c58
Upwork Job ID:<PHONE_NUMBER>700159488
Last Price Increase: 2023-08-27
Automatic offers:

shubham1206agra | Contributor | 26347760

@hayata-suenaga Can I take up this issue because I was the original commenter on the offending PR? And I have not raised the issue due to its being handled by SWM member at that time.
https://github.com/Expensify/App/issues/24681#issuecomment-1694334022
https://github.com/Expensify/App/issues/24681#issuecomment-1694334124

Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes on iOS simulator on open
What is the root cause of that problem?
It is a regression from this PR #25745 due to which the getPlatform() method always resolves to CONST.PLATFORM.WEB as it always refers to index.js file, not index.ts file. Due to that, it tries to access window.localStorage method which does not exist on iOS.
What changes do you think we should make in order to solve the problem?
Delete the existing src/libs/getPlatform/index.js file

@allroundexperts @hayata-suenaga PR ready

don't know why melvin assigned two bug-zero members...
anyway, @slafortune I apologize situation with this issue looks a little confusing
@allroundexperts is the C+ member who took care of this issue (they did pull request review)
@shubham1206agra is the contributor who made the pull request
More context

I created the issue because this was urgent problem
I approved a proposal before C+ approved it because this issue needed to be solved urgently
I unassigned an auto-assigned C+ and assigned another C+ @allroundexperts who was online at that time and had the context for the issue

Why is this part of distance requests? @JmillsExpensify

Why is this part of distance requests? JmillsExpensify

I gonna remove this issue from Distance Request project

@slafortune I didn't receive any bonus. Is there any particular reason for that?

@shubham1206agra I did add the bonus, so it's strange if you don't see that.  Upworks has made some updates where the bonus is shown differently -

Can you check again?

Adding a new BZ member to monitor this, I'm out on sabbatical

It shows the correct balance, but the message shows only milestone completion (earlier, it shows the complete amount).

@shubham1206agra as Stevie mentioned, it looks like the correct amount has been paid out to you: I would recommend reaching out to Upworks to gain some clarification as their newly implemented bonus system seems to be confusing.
FWIW, I never use that new bonus system for payouts - I pay the bonus directly on the job.

Job removed, here's the summary for JMills

$1,500 payment approved for @allroundexperts based on BZ summary.


Does this run on Fable Js as well?

Can i try this on fable js as well?

No, not yet. To do this you would need some middleware integrations e.g ExpressJS, then you need to use Fable.SimpleJson and Fable.Node. You would need separate Middleware.fs and HttpContext.fs for JS. Then there's the problem that Fable JS to not have a task builder. It might be possible to make a simple that just uses async or wraps promise instead. So, it should be possible, but will require some work.

this could come handy?
https://github.com/AngelMunoz/expressive.

I can separate the Python specific code so that it's more obvious what needs to be changed. Any plans of adding a task builder to Fable JS @alfonsogarciacaro or is it simply to just use Fable.Promise and let task = promise?

Sorry for the late reply. I was a bit reluctant to add support for tasks because I associated it with thread support which is not available in JS. But with the native task CE now it makes sense to add support for task at one point.
Anyways, using let task = promise should be a good work-around for the moment.

this would be such a game changer to also have a nodejs easy backend for F#, as valid and well spread alternative to aspnet, performance of nodejs is not so bad after-all and so many companies use it for foll stack. 💟


[PE-D][Tester D] Error message points out wrong issue in edit command

When entering a command with wrong parameter flag, eg. 'edit eid/3 name/test name', program identifies error as id, instead of name. Perhaps it might be better to use a generic message regarding how to use the edit command?

Labels: type.FeatureFlaw severity.Low
original: joyngjr/ped#6

@kennethk-1201 i dont think this can be changed either.. let me know if u think otherwise


Any suggestion on trees comparison?

I want to do a tree grafting. What approach do you guys suggest.
My idea is doing a step by step comparison inside tree walk.

Not sure I understand your goal. You mention both comparison and grafting. Check if this answer helps you in any way.


Navigation bar

AS A website user
I WANT a way to navigate to the website
SO THAT I can view the different sections as easily as possible

Create a responsive navigation menu
When the BeWYLD logo is clicked, return to the top of the main page
When the "About Us" button is clicked, go to that section/page
When the "Book a trainer" button is clicked, go to the section to book a personal trainer.

Nav bar is not visible at small screen sizes. Is this expected behaviour? Do we want a mobile version of the nav menu using Bootstrap?


JsonIgnoreAttribute from Newtonsoft.Json doesn't work anymore

Describe the bug
I am currently trying to upgrade to the latest Verify version.
Because Verify switched from Newtonsoft.Json to Argon the JsonIgnoreAttribute from Newtonsoft.Json stopped working.
As the data I want to verify is from classes that are used in production code and a switch from Newtonsoft.Json to Argon for the whole application is not desired, I can't verify the data properly anymore.
Possible solutions to this issue would be:

modify CustomContractResolver from Verify to also check for the attribute from Newtonsoft.Json
make CustomContractResolver public so consumers of Verify can override the behavior

Would a PR with one of the suggested solutions be accepted?
Is there any other way to configure this globally?
So far I haven't found a way to override this globally for all classes, just based on the MemberInfo.

While trying to make the required changes to Argon I noticed that there is also IgnoreDataMemberAttribute which might already solve the issue for me.
Will check that at work next week.

did it work?

Sorry. Forgot to respond.
Yes it worked like a charm.
I just replaced all our usages of JsonIgnoreAttribute with IgnoreDataMemberAttribute.
I consider this solved.

good to hear


Privacy Essentials plugin in Chrome blocks login to Zendesk-backed site with custom domain

Description
When attempting to sign in to a Zendesk Guide site that uses a custom domain, the sign-in process redirects from the custom domain to a zendesk.com domain and then back to the custom domain.  DuckDuckGo Privacy Essentials is removing some part of the authentication token which results in a Forbidden / Invalid Authenticity Token error.
Steps to Reproduce

Attempt to create an account on a site that uses Zendesk with a non-zendesk domain, e.g. https://support.vertigis.com/
This configuration requires a CNAME DNS record
Set the password for your new account and sign in

Expected behavior:

Sign-in succeeds
Actual behavior:

Sign-in is not successful, the user is presented with an error stating Invalid Authenticity Token

Versions

Extension: 2022.01.24
Browser: Chrome
OS: Windows and Linux

Additional Information

Issue is repeatable.  Disabling the DuckDuckGo extension immediately resolves the issue.  Only appears on sites that use a custom domain, users can successfully sign in to Zendesk sites that use the zendesk.com domain.

This is due to 3rd party cookie blocking. Despite using the CNAMEd community.vertigis.com as the site domain, login calls to Zendesk still go directly to vertigis.zendesk.com which is seen as a 3rd-party by our code. This looks like an issue with how Zendesk have implemented their custom domain functionality, requiring 3rd party cookies for it to work correctly. On browsers with 3rd party cookie restrictions it looks like they use the Storage Access API to get around the restrictions.
I'll open an issue internally to see if we can get around this issue, or at least mitigate cases like this.


[hotfix] [docs] fix first example in table API documentation

Also, I don't see table1 being used in either java or scala examples, unless I'm missing something.

Yes, I think, either table1 or table2 are unused in these examples.

@knaufk Then shouldn't we remove the SQL example and keep only the TableAPI?
@twalthr what do you think?

This PR is subsumed by https://github.com/apache/flink/pull/19681


Move mwakaba2 to inactive list

Hi all, I have a lot of personal and work related travel and commitments coming up, so I'm setting myself inactive for a few months.

Take care @mwakaba2 - we look forward to your return!


[MB-8381] Revoke office user session when roles are modified

Jira ticket for this change
Summary
Changes to an office user's permissions don't take effect until they get a new session.
So if you revoke a role from an office user, they will still be able to use that role until they log out and log in again.
This PR addresses this security hole by revoking the office user's session whenever role changes are made. So they will have to log in again and start a new session before being able to do anything.
One question I have: is returning a 500 error to the admin user adequate when we fail to revoke a session?
Admins do have the ability to see if a user has an active session and manually revoke it, so if it failed due to a transient issue, they would be able to address it, if they knew to do it.
Setup to Run Your Code

💻 You will need to use two separate terminals to test this locally.
Terminal 1
Start the UI locally.
make client_run

Terminal 2
Start the Go server locally.
make server_run

Additional steps
Sessions work differently with local sign in, so you'll have to log in with login.gov, even when testing this locally.

Log in as an admin user (with login.gov)
Use the admin interface to create an office user with your truss email address. Make sure they have at least one of the office user roles (TOO, TIO, or Services Counselor)
Log in as that office user with login.gov.
From the admin interface, make a change to the user's roles. (doesn't matter what change, add or remove any of the roles)
Go back to your office user, make sure that if you try to do anything, you should get logged out. If you can perform any actions in your current session without getting logged out, then something is wrong.

Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Backend

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Screenshots

Messages

:book:
:link: MB-8381

  Generated by :no_entry_sign: dangerJS against 1badd77bcd6b13f5f01f629943c7611b620303cf


added  exploit  protection rules for  important applications based on…

protection.zip
…
request issue #4253
@jvsam. Request issue #4253.
taken example from Windows 10 v1903 64bit buildno 18362.207.   I already added last year and keeping these settings as default.
taken much care while adding commands, so please review and test on your systems, then verify all, and approve PR .
Thanking you sir

cc @jvsam

Hi @levinec, does this type of contribution acceptable to this documentation https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-defender-exploit-guard/enable-exploit-protection? I think this may not be the right place to add a long list of commands (and they need to be tested as well). Please let us know what you think so we will know how to proceed, thank you. See #4252

Hi @levinec and @Dansimp if time permits, can you please review this pull request and let us know if this kind of extensive content update is allowed? We appreciate your feedback, thank you.

Hi again @levinec and @Dansimp hoping you can provide feedback on this open pull request. Thank you.

Sorry, but I'm not sure what issue this is addressing. The mentioned issue is basically asking to create this PR.
What are we solving with adding this information? We're adding 400+ lines with a lot of duplicate examples.
I tend to reject this PR, because I don't understand the need for it. Please elaborate, if possible.

Thanks for the response @DaniHalfin. This contribution contains a list of rules put together by a community user. That's why I am asking if this kind of content is acceptable or not. If it isn't, then we can close this PR (unfortunately I do not have that level of access) and provide feedback.

@jvsam - Thanks for elaborating. While I under the general intent, I'm not sure that the downside here is warranted, given that there doesn't seem to be a need for that from other members of the community.
We prefer to keep content concise when possible, and in this case this contribution would increase the size of the topic by 300%. So unless there's some additional reasoning to add this information, I tend to reject it.

Appreciate your input @DaniHalfin. If that's the case, will you close this pull request? Please advise. Thank you so much.
Since the community user exerted considerable effort in putting this together, it may be worth sharing the information on the TechNet forums or the TechCommunity. I'll communicate, depending on the decision with regard to this PR.


Fix image file size when uploaded from ios

Details

upgrade the version of react-native-image-picker
add a new request handler to deal the selected image

Fixed Issues

$ https://github.com/Expensify/App/issues/9424
Tests

Launch the app
Go to a chat and upload an image from a ios device.
Check the image size on device.
Now open the chat on recipient account in a web browser.
Open and download the received image.
Check the image file size.

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

Launch the app
Go to a chat and upload an image from a ios device.
Check the image size on device.
Now open the chat on recipient account in a web browser.
Open and download the received image.
Check the image file size.

[x] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

https://youtu.be/oQQwplchSw8
Android

Hi, I thought it was made clear in the proposal 😂

react-native use RCTImageLoader#sendRequest by default to convert the image uri to binary data ( this image uri is returned by the react-native-image-picker ), and I also mentioned it in this issue
So we need to add a new handler to replace it.
Additionally, this new handler won't affect normal image loading

@mountiny @Santhosh-Sellavel,  I'm going to add a short comment. Is this ok ? 🙂
diff --git a/ios/NewExpensify/OriginImageRequestHandler.mm b/ios/NewExpensify/OriginImageRequestHandler.mm
index d6dc968f9..346b43a9e 100644
--- a/ios/NewExpensify/OriginImageRequestHandler.mm
+++ b/ios/NewExpensify/OriginImageRequestHandler.mm
@@ -4,6 +4,8 @@
 //
 //  Created by ntdiary on 2022/8/8.
 //
+//  Use this handler to upload images returned by react-native-image-picker instead of the default RCTImageLoader.mm
+//  See https://github.com/facebook/react-native/issues/33760#issuecomment-1196562161

 #import <Foundation/Foundation.h>
 #import <ReactCommon/RCTTurboModule.h>

Agree its useful

@mountiny  I can try it, and there is something I need to explain 🙂
there are also comments in its protocol file (RCTURLRequestHandler.h)
These two files are copies of RCTFileRequestHandler in react-native, the only difference is that I changed its canHandleRequest condition and handlerPriority.
They are automatically loaded by by RCTNetworking.mm and are only used  in react-native.
(RCTNetworking.mm uses RCTImageLoader to parse the image by default, like the image below)

How about this revision ?

@ntdiary
Can you update the screenshot recording to ensure, everything works as expected?
Please fill the author checklist

@mountiny Can you initiate work flows to perform checks

@Santhosh-Sellavel This issue and revision only occurs on ios platform.
I'm not so sure, should I fill in all items in the author checklist and update all platform screenshots?
or only related to this revision and ios platform?

I swear to god I pressed that button!
I think it would be nice to test this and show video of android working well at least and check the checkboxes in the list too. But we can move ahead even without it this time since it touches ios predominantly (however updating the package could theoretically cause problems to android as well)
@ntdiary @Santhosh-Sellavel Great job guys! I hope @ntdiary you will pick up more issues in the repo, it was good to work with you!

@ntdiary
You checked this

-[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

@Santhosh-Sellavel uh, sorry, I canceled it first. 😅
i'm still trying to run the App on Android,
but it is running very slow, no matter if i build it from main branch or this branch
I'm checking what's going on.

@Santhosh-Sellavel Any chance you could help out with testing on android? I guess once confirmed all works well we can approve and merge 🙌

PR Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Hi, I have tested it on android and updated the checklist, although it runs slowly.
And I found this issue, it seems that everyone has encountered this problem in DEV env.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

👋 Just making a note that this introduced a regression with the Take Photo attachment functionality as noted here. We're adding a regression test for our QA suite, but let's be careful to ensure we're test both types of image uploads in the future (from file / from taking a photo). Thanks!


sticky-sidebar seems to not be working

Please ensure:

[X] The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

I am on 21.6.8, and there seems to be 21.7.18, but I cannot update somehow (?!?)

I am not saying its a duplicate, its just the same issue

What is the gif demonstrating? I see a sticky sidebar in it

Your gif  also shows the header bar to be sticky. I assumed they worked together?
Or sticky header was a GH/RG feature, but no more?

@fregante go to pull requests, go to issues, open an issue you will see it does not work

@yakov116 I have an idea: do you happen to use https://github.com/yourduskquibbles/webannoyances?
It seems that it interferes with something

No

However, even after my workaround, the Repo Root https://github.com/yourduskquibbles/webannoyances is still broken for me

Now its doing it again. @fregante can you try on repo root?

That's the sticky header, not the sidebar. The sticky header is native to GitHub. This is a GitHub issue 😃

Actually it's not even a bug if you're using that extension. The first line literally says:

Block annoying web elements such as sticky headers,

However, even after my workaround,

ie I disabled it...

the Repo Root yourduskquibbles/webannoyances is still broken for me

...

Missed this! Indeed sticky-sidebar appears to not work on repo roots

Indeed sticky-sidebar appears to not work on repo roots

It seems to work fine on https://github.com/fregante/Awesome-WebExtensions

Am I missing something here?

It's been 25d since @fregante re-verified my claim of repo-roots being broken.
I don't remember seeing any improvement, and there seems not to have this ticket auto-closed (correctly).
Unfortunately, I am on vacation and I couldn't help you 😕

Thanks for checking @shinenelson! Indeed it's working for me now.
I do see the sidebar occasionally not working on issues, but it's probably best to open a new specific issue if we find how to reproduce that.