Use SecureRandom instead of Random

Description

Related Issue

Fixes #1132
How Has This Been Tested?

Connect to a remote server.
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

I've looked into this a bit, and I no longer think there is any direct vulnerability here. The cache poisoning exploit requires that there is malicious code controlling the websocket client. Since this is a Java library, any code controlling this client is typically already running with full Java privileges and can do whatever it wants on the user's computer.
There might be a situation though, where a user of this library sends unobscured data (without using Json or base64) obtained from a malicious source (like someone implementing a web browser using this library, which is in practice very unlikely).
Either way, this PR should be merged, just to follow the advice in the spec, but as far as I understand, the masking mechanism is primarily for web browsers.


Support Double-tap gesture on Base message

Added new gesture recogniser to BaseMessageCollectionViewCell, a bit updated delegate methods to work simultaneously with others.
Updated BaseMessageInteractionHandlerProtocol to have double-tap handler method.
BaseMessagePresenter translates new gesture event to interaction handler.
Unit-test for BaseMessagePresenter added.

Codecov Report

Merging #691 (185728a) into master (79f9e40) will increase coverage by 11.61%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #691       +/-   ##
===========================================
+ Coverage   58.23%   69.84%   +11.61%
===========================================
  Files          99       20       -79
  Lines        5138     1310     -3828
===========================================
- Hits         2992      915     -2077
+ Misses       2146      395     -1751

Impacted Files
Coverage Δ

...attoAdditions/Source/Input/ChatInputItemView.swift

...ttoAdditions/Source/Common/CALayer+ImageMask.swift

...urce/Chat Items/ChatItemDecorationAttributes.swift

...oAdditions/Source/Input/InterfaceOrientation.swift

...attoAdditions/Source/Common/CGRect+Additions.swift

...Additions/Source/Input/ChatInputBarPresenter.swift

...at Items/PhotoMessages/Views/PhotoBubbleView.swift

...ource/Common/Bundle+ChattoAdditionsResources.swift

...s/PhotoMessages/PhotoMessagePresenterBuilder.swift

...e/Chat Items/PhotoMessages/PhotoMessageModel.swift

... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f9e40...185728a. Read the comment docs.

Codecov Report

Merging #691 (185728a) into master (79f9e40) will increase coverage by 11.61%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #691       +/-   ##
===========================================
+ Coverage   58.23%   69.84%   +11.61%
===========================================
  Files          99       20       -79
  Lines        5138     1310     -3828
===========================================
- Hits         2992      915     -2077
+ Misses       2146      395     -1751

Impacted Files
Coverage Δ

...attoAdditions/Source/Input/ChatInputItemView.swift

...ttoAdditions/Source/Common/CALayer+ImageMask.swift

...urce/Chat Items/ChatItemDecorationAttributes.swift

...oAdditions/Source/Input/InterfaceOrientation.swift

...attoAdditions/Source/Common/CGRect+Additions.swift

...Additions/Source/Input/ChatInputBarPresenter.swift

...at Items/PhotoMessages/Views/PhotoBubbleView.swift

...ource/Common/Bundle+ChattoAdditionsResources.swift

...s/PhotoMessages/PhotoMessagePresenterBuilder.swift

...e/Chat Items/PhotoMessages/PhotoMessageModel.swift

... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f9e40...185728a. Read the comment docs.

Will be fixed in #692

Will be fixed in #692


Designed Links Page

Designed the Links Page.

It looks like this

I change the css to tailwind css and create a new PR.


Allow to config dns bind address in DnsNameResolver

Motivation:
The DnsResolver default start address listen to "<IP_ADDRESS>", which may have some security risks.
Modification:
Add bindAddress as a param of DnsNameResolver
Result:
The DnsNameResolver's bind address can be configured.

@Shoothzj thanks a lot!


Xcode 9.2 Beta

Hi
I install SQLite.swift with cocoapods and use it in my project with Xcode 8.2.1
Today i download Xcode beta 9.2 and opened my project
But it gives error
Module compiled with Swift 3.0.2 cannot be imported in Swift 3.2.3
I reinstall it with cocoapods without a problem.
Other pod which i used before doesn't give any error but just sqlite gives that ...
Regards

This just means you need to rerun the pods again so that they are recompiled. Close the project and run pod update. The pods will be recompiled with the current version of Swift in that project. If there are further issues search for LEGACY in your build section and verify that you are working with the correct version of Swift on the updated project.

please retry with the latest version and reopen if needed


[DESIGN] - Lighting

Design Scope
Design a wide-spectrum controllable LED lighting system.
Deliverables
Outline the implementation prototype and its components:

[X] LED Drivers
[X] LEDs (types, quantity)
[x] Topology Adaptation, Fusion 360 EDA

[ ] Multiple LED-only daughter boards, wired in series

[x] Two 6-pin (5 LED + GND) Molex Micro-Lock PLUS connectors (one +, one -)
[X] How many LEDs per series per daughterboard? 3 per series
[ ] Power Route Widths

[ ] Single power board

[x] Voltage requirements for all LEDs in series? 4 boards = 12 LEDs, max. ~38V for blue
[ ] Power Route Widths

[ ] Pull-down resistors on master control board for each PWM

[x] Lighting performance enhancement (diffusion/lenses)

Requirements
List any applicable metrics with criteria/constraints:

Covers maximum possible PAR requirement
Spectrum range from near-UV to near-IR
Intensity from off to welding arc

Purely functional prototype in and tested, just want to refine its layout (see original checklist)

Diffusion lens

Not sure if Cree LEDs are being phased out...
https://cree-led.com/applications/horticulture
http://www.seoulsemicon.com/en/application/Lighting/Industrial + Horticulture

Correction: they are not being phased out, i'm just an idiot. There are tons of CREE options on DigiKey. Might have to do a more rigorous selection process.


fix(leap): use LeapLabel

LeapLabelPrimary, LeapLabelSecondary deprecated (b75a86f)
What is this PR for?
Brings back leap labels highlight
Does this PR fix an existing issue?

Fixes #578

Did you close this by accident?

closed in favour to #582


Having trouble with set up

Hi! Thanks for building this library. The set up instructions are unclear to me.
Here's what I'm trying currently:
import React from 'react';
import { render } from 'react-dom';
import { createStore } from 'redux';
import { Provider } from 'react-redux';
import reducers from '../Reducers';
import storeCreatorFactory from 'reduxed-chrome-storage';
import Popup from './Popup';
import './index.css';

const options = {
  createStore: createStore,
};
const asyncStoreCreator = storeCreatorFactory(options);
const store = asyncStoreCreator(reducers).then((store) => {
  const state = store.getState();
  console.log('asyncStoreCreator state', state);
});

render(
  <Provider store={store}>
    <Popup />
  </Provider>,
  window.document.querySelector('#app-container')
);

I'm not getting an error that looks like it's calling out anything with the library or my reducers file, but when I load the extension it comes out blank. If I remove the code relating to this library, my extension loads just fine. What am I getting wrong here?

It seems that you haven't read the Readme attentively. With Promise-based usage all code that depends on Redux store has to be placed inside Promise callback, not outside as in your sample.
BTW, you could star this repo if it's really useful for you.


Updating Certification faq

#sign-off

#sign-off

#sign-off

#sign-off

Hi @github-2407 - This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. We can keep this PR open for review and merge, but would you make future content updates in the private repo? Thank you!

Hi @github-2407 - This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. We can keep this PR open for review and merge, but would you make future content updates in the private repo? Thank you!

Thanks Kristine, please merge this PR. I will make sure I select the private repo for merge the next time.
From: Kristine Toliver<EMAIL_ADDRESS>Sent: Friday, January 15, 2021 2:32 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Kriti Shah<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Updating Certification faq (#68998)
Hi @github-2407https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgithub-2407&data=04|01|Kriti.Shah%40microsoft.com|fdc7256e643f46c3ccd708d8b9a55732|72f988bf86f141af91ab2d7cd011db47|1|0|637463467082609407|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=D7Tq%2B03x6c4kjxG9X8nHaz7vKK%2FCy5L9vdJZt6p3ARQ%3D&reserved=0 - This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. We can keep this PR open for review and merge, but would you make future content updates in the private repo? Thank you!

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F68998%23issuecomment-761231778&data=04|01|Kriti.Shah%40microsoft.com|fdc7256e643f46c3ccd708d8b9a55732|72f988bf86f141af91ab2d7cd011db47|1|0|637463467082619400|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=VVpchNeX2O80CN2LpNft%2BrbiHxWsEpnxgXOm6TA3Bas%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANOBRNYPPUH7XG35XQ4ZWHDS2C65DANCNFSM4WENCOMQ&data=04|01|Kriti.Shah%40microsoft.com|fdc7256e643f46c3ccd708d8b9a55732|72f988bf86f141af91ab2d7cd011db47|1|0|637463467082629395|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=TqkCNLZTug%2FMaHTO7f823GRmKgP73LijFe%2FwzekUXcY%3D&reserved=0.

Thanks Kristine, please merge this PR. I will make sure I select the private repo for merge the next time.
From: Kristine Toliver<EMAIL_ADDRESS>Sent: Friday, January 15, 2021 2:32 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Kriti Shah<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Updating Certification faq (#68998)
Hi @github-2407https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgithub-2407&data=04|01|Kriti.Shah%40microsoft.com|fdc7256e643f46c3ccd708d8b9a55732|72f988bf86f141af91ab2d7cd011db47|1|0|637463467082609407|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=D7Tq%2B03x6c4kjxG9X8nHaz7vKK%2FCy5L9vdJZt6p3ARQ%3D&reserved=0 - This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. We can keep this PR open for review and merge, but would you make future content updates in the private repo? Thank you!

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F68998%23issuecomment-761231778&data=04|01|Kriti.Shah%40microsoft.com|fdc7256e643f46c3ccd708d8b9a55732|72f988bf86f141af91ab2d7cd011db47|1|0|637463467082619400|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=VVpchNeX2O80CN2LpNft%2BrbiHxWsEpnxgXOm6TA3Bas%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANOBRNYPPUH7XG35XQ4ZWHDS2C65DANCNFSM4WENCOMQ&data=04|01|Kriti.Shah%40microsoft.com|fdc7256e643f46c3ccd708d8b9a55732|72f988bf86f141af91ab2d7cd011db47|1|0|637463467082629395|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=TqkCNLZTug%2FMaHTO7f823GRmKgP73LijFe%2FwzekUXcY%3D&reserved=0.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@github-2407 Thanks.

@github-2407 Thanks.


Add Tinkerbell machine config validation webhook

Issue #, if available:
Validation webhook for Tinkerbell Machine Config#1018
Description of changes:
Machine config immutable fields
Testing (if applicable):
unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I'm a little hesitant to give an official okay, but this looks good.

/lgtm

/approve


Fix exception for missing repository in related browser

Description
Catch any errors for unfound model repositories in empty block browsers. Alternatively, one could disable the $block->getRelated($relation)->isNotEmpty() check — not sure what that does or why it's there.
Related Issues
Fixes #1404

Thanks for this @daun!
The check is most likely there from a backwards compatibility intention. When we introduced this feature, there might have been use cases where the table was created but the data was not yet stored in it, so its fallbacking to a regular module/capsule repository resolution, which obviously doesn't work if the relation name doesn't match a repository in your codebase. Was that your case?

@ifox It's a new(ish) installation that had the related table from the start. The problem is that the isNotEmpty check means it will fall back to the regular repository resolution even though the table exists and the query returns a result set (albeit empty). Which is fine except that the regular resolution mechanism expects the repository to actually exist. Catching the exception here bridges the gap between these two implementations and should solve this particular bug. Maybe there's a more elegant solution but none that I could see at a glance.


classgraph 4.8.116 (was 4.8.90)

Updates io.github.classgraph:classgraph from 4.8.90 to 4.8.116.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.github.classgraph", artifactId = "classgraph" } ]

labels: library-update, semver-patch

Superseded by #199.


Performance improvement and image quality controls

Hi.
I've changed the code for reading the dice images to prevent redundant file reads.
I have also declared a variable called quality from which you can control the resolution of your image.
more dice have also been added to dice directory.

Anybody there?


Not able to connect AC anymore after HA upgrade to 2024.05.x

After HA upgrade to 2024.05.x the device turned unavailable and I was not able to connect AC anymore, even if I try to add a new entry from Midea AC Integration.

Logger: msmart.base_device
Source: custom_components/midea_ac/coordinator.py:38
integration: Midea Smart AC (documentation, issues)
First occurred: June 7, 2024 at 9:56:31 PM (3696 occurrences)
Last logged: 12:13:38 PM
Network error <IP_ADDRESS>:6444: Connect failed.
Network timeout <IP_ADDRESS>:6444: Connect timeout.
No response from <IP_ADDRESS>:6444 in 5.000000 seconds.

Logger: msmart.device.AC.device
Source: custom_components/midea_ac/init.py:64
integration: Midea Smart AC (documentation, issues)
First occurred: June 7, 2024 at 9:56:31 PM (5 occurrences)
Last logged: 12:02:37 PM
Failed to query device capabilities.

Logger: msmart.base_device
Source: custom_components/midea_ac/init.py:64
integration: Midea Smart AC (documentation, issues)
First occurred: June 7, 2024 at 9:56:31 PM (5 occurrences)
Last logged: 12:02:37 PM
Network error <IP_ADDRESS>:6444: Connect failed.

Hm..I'm not aware of any incompatibilities with HA 2024.5.  Based on the errors it looks like the device is not on the network/not responding.
Did the IP address change? When attempting to add a new device are you using automatic discovery, or manual configuration?

Yes, the IP address changed and I was unable to find were it was defined and how to change it.
After a long research I changed the config file </homeassistant/.storage/core.config_entries> then rebooted the HA
It will be great if you add the IP address information into web interface and some documentation how to change it.

Glad you got it working.

After a long research I changed the config file </homeassistant/.storage/core.config_entries> then rebooted the HA

I would've just removed and re-added the device.

It will be great if you add the IP address information into web interface and some documentation how to change it.

I don't really anticipate changing the IP to be regularly required. I'll consider adding the configured IP in the device info or somewhere.


NET/C# → 1.0.0-beta.2 (preview) supports API version 2024-02-29 (preview) and above

Fix documentation: .NET/C# → 1.0.0-beta.2 (preview) supports API version 2024-02-29 (preview) and above.
Addresses #43415

@laujan
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@YalinLi0312  @HarshaNalluru @samvaity Documentation suggests that the .NET Document Intelligence SDK supports all REST API GA versions, which is incorrect. We only support the latest preview. Would the same apply for Python, JS, and Java? Here are the docs in question: https://learn.microsoft.com/azure/ai-services/document-intelligence/sdk-overview-v4-0?view=doc-intel-4.0.0&tabs=csharp#supported-programming-languages

@kinelski, thanks.
I didn't update the documentation for Pyton, JS and Java, since I don't know the status of those.

@YalinLi0312 @HarshaNalluru @samvaity Documentation suggests that the .NET Document Intelligence SDK supports all REST API GA versions, which is incorrect. We only support the latest preview. Would the same apply for Python, JS, and Java? Here are the docs in question: https://learn.microsoft.com/azure/ai-services/document-intelligence/sdk-overview-v4-0?view=doc-intel-4.0.0&tabs=csharp#supported-programming-languages

In Python SDK, Document Intelligence package only support the most recent two preview API versions, Form Recognizer package support the rest GA API versions.

The proposed change now appears in the live article: https://learn.microsoft.com/azure/ai-services/document-intelligence/sdk-overview-v4-0?view=doc-intel-4.0.0&tabs=csharp

@Court72,
Perfect, thank you!


Improve the instructions for setting up the OAuth client.

Improve the instructions for setting up the OAuth client.

Add screenshots
Explain that Authorized Domains may not be an option and explain they
don't need to set it in that case.
Fix #177

This change is

Thanks. PTAL.

Looks good to me. I'll let @sarahmaddox have the final word.

Thanks!
/lgtm
/approve


Checklist: normalise topics

Note: the suggestions are generated automagically. If something is actually missing, please open an issue at problem-specifications to add the missing topics.
=> fetching config from ../exercism-ruby/config.json
=> reading topics from ..\problem-specifications\TOPICS.txt

List of valid topics

abstract_classes
algorithms
arrays
behavior_driven_development
bitwise_operations
booleans
callbacks
classes
concurrency
conditionals
cryptography
dates
discriminated_unions
domain_specific_languages
enumerations
equality
events
exception_handling
files
filtering
floating_point_numbers
functional_programming
games
generics
globalization
graphs
inheritance
integers
interfaces
lists
logic
loops
maps
math
matrices
memory_management
networking
object_oriented_programming
operator_overloading
optional_values
parallelism
parsing
pattern_matching
pattern_recognition
performance
polymorphism
queues
randomness
reactive_programming
records
recursion
refactoring
regular_expressions
searching
security
sequences
sets
sorting
stacks
strings
structs
test_driven_development
text_formatting
threading
time
transforming
trees
tuples
type_conversion
variables

Exercises with non-standard topics

[ ] series
Incorrect topics:

[ ] enumerable (perhaps: enumerations)

[ ] word-count
Incorrect topics:

[ ] hash (perhaps: math, maps, dates, graphs, lists, sets, time, games, loops, arrays, classes, stacks, trees, files, logic, parsing)
[ ] enumerable (perhaps: enumerations)

[ ] resistor-color-duo
Incorrect topics:

[ ] array (perhaps: arrays, trees, loops, dates, graphs, lists, maps, sets, time, files, games, logic, math, parsing)

[ ] roman-numerals
Incorrect topics:

[ ] numbers (perhaps: integers, queues, tuples, games, dates, maps, sets, time, trees, files)

[ ] space-age
Incorrect topics:

[ ] if_else_statements

[ ] say
Incorrect topics:

[ ] numbers (perhaps: integers, queues, tuples, games, dates, maps, sets, time, trees, files)

[ ] queen-attack
Incorrect topics:

[ ] errors (perhaps: arrays, events, loops, graphs, records, trees, generics, dates, lists, maps, queues, sets, stacks, strings, structs, tuples, files, games)

[ ] allergies
Incorrect topics:

[ ] enumeration (perhaps: enumerations)

[ ] linked-list
Incorrect topics:

[ ] data_structure
[ ] pointer (perhaps: events, dates, integers, lists, time, files)

[ ] collatz-conjecture
Incorrect topics:

[ ] control_flow_loops (perhaps: loops)

[ ] zipper
Incorrect topics:

[ ] data_structures

Exercises without topics

[ ] binary
[ ] trinary
[ ] hexadecimal
[ ] octal
[ ] point-mutations

The binary, trinary, hexadecimal, and octal are deprecated, I believe, in favor of "All Your Base".  It may be fine to leave them without topics.

That's right. I have not removed them from the list.

The topics have been deprecated in problem-specifications. We will be reevaluating topics for all exercises as part of implementing the concepts and concept exercises. I'm closing the issue.


On replacing tag, allow presenve props

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)
mini.surround
Description
It would be nice, when doing a surround replace tag, by another tag, some special char could be used on the input, to put the original tag's props back in.
Ex:
given <div class="menu" ...>
press srtt
input: nav %
gets <nav class="menu" ...>

Thanks for the suggestion!
This was already discussed in #397 with resolution that it doesn't quite fits the 'mini.surround' design.
Closing as duplicate of #397.


feat(app/notifications): update notification error by adding api types

Close #4240

@pull-dog up

/azp run

@pull-dog down

/azp run

/azp run

/azp run

@pull-dog down

@pull-dog down

Closing this one, see https://github.com/portainer/portainer/issues/4240#issuecomment-796137839


Error on immediate casts of literals to incompatible literal types

Just an experiment after filing https://github.com/microsoft/TypeScript/issues/37032

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

This experiment is pretty old, so I'm going to close it to reduce the number of open PRs.


Found a critical bug, go figure out yourself and thank me later.

Ah!   would allow outsiders to read  which in turn made   incredibly unsafe! I'll work on a pull request right now

Thanks for fixing this. 👏


Support horizontal scrolling in ScrollArea

ScrollArea currently only supports scrolling vertically. We need a way to allow scrolling horizontally for wide content.
Describe the solution you'd like
"Wide content" is a broad definition, so I'll propose that we define the term to mean, roughly, that the content width needs to be wider than the ScrollArea width. This is usually because the content area contains UI elements that cannot be made thinner. A very obvious example is an Image which has a static width and height.
Draw a horizontal scroll bar at the bottom of the ScrollArea, and allow it to be scrolled with Shift + Scroll Wheel. Otherwise it should support the same interactions as the existing vertical scroll bar, including touch inputs.

Having horizontal scrolling as an opt-in part of ScrollArea is the right approach. Users should have the choice between vertical, horizontal or both.


DefaultMessageSizeEstimator should have a default unknown size of 1

A size of 1 would prevent the task queue og the  eventLoop of the client from growing indefinitely in cases where the client is producing data faster than when the server can consume them.

@prange that is actually a very good idea! Let me do a PR or you want to do it ?

@normanmaurer If you could do that it would be great.

Will do...


Social Work: Add the ability for documenting expenses information for a patient

🚀 Feature Proposal
There should be the ability to document Social Work information for a patient.
This MUST be done after #2487
Social Work tab
There should be a new tab called Social Work on the patient profile screen. Under this tab there will be two sections, one titled Family Information and the other titled Expenses. This issue deals with the Expenses section.
The Expenses section must be displayed below the Family Information section
Expenses

When the Social Work tab is active, there should be a button labelled "Add Expense", that allows a user to add a new expense for this patient.

The Social Work tab should also display a table of information showing the already entered expenses.

IMPORTANT NOTE: The images below is just for illustration purposes only. Styling must be as per the existing styles for forms, tables and buttons in other parts of the application.

When the user clicks on the Add Expense button, they should be prompted to enter the following information:

category: clothing|education|electricity|food|fuel|other|rent|transportation|water
sources: string
cost: number

This should create a expenses object entry under the patient

A expenses entry should also contain the following information that is auto generated by the system:

id: string
createdAt: string
updatedAt: string

The table of expenses should show the category, sources and cost.

The user must be able to edit or delete each entry listed in the table.

Technical Notes

The routing should work similarly to the care plan routing

Motivation
Social Determinants of Health (SDOH) are important to capture as they help give the healthcare workers a better idea of factors that could potentially affect the patient's well being

in prgress


Unable to resolve path to module 'vite-plugin-ssr/plugin' as of 0.3.57

As of version 0.3.57:
in vite.config.ts:
import { ssr } from "vite-plugin-ssr/plugin"

results in:
Unable to resolve path to module 'vite-plugin-ssr/plugin'

and anywhere I call getPage:
import { getPage } from "vite-plugin-ssr/client"

results in:
Unable to resolve path to module 'vite-plugin-ssr/client'

This doesn't happen in 0.3.56, but probably related to adding ESM support?

What's your Node.js version?

Also, I need a full stack trace.

Node version is: v16.13.2
There really isn't a stacktrace since it's eslint that fails, but here's that:
> eslint .

./renderer/_default.page.client.tsx
  6:25  error  Unable to resolve path to module 'vite-plugin-ssr/client'  import/no-unresolved

./vite.config.ts
  5:21  error  Unable to resolve path to module 'vite-plugin-ssr/plugin'  import/no-unresolved

✖ 2 problems (2 errors, 0 warnings)

I see. I'll write the fix today/tomorrow.

Fix released in v0.3.59. It should now work but I didn't test it; let me know if you still have problems with eslint.


Errors installing new bot

updated to the latest dev branch. After pip install requirements I get:
----------------------------------------
Command "/usr/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-build-hCOMwd/pycryptodomex/setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))" install --record /tmp/pip-sW5WeQ-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-build-hCOMwd/pycryptodomex/
Running the pokecli script gives me:
root@xxxx:~/PokemonGo-Bot# python pokecli.py --config ./configs/config.json
Traceback (most recent call last):
File "pokecli.py", line 38, in
from pgoapi.exceptions import NotLoggedInException
ImportError: No module named pgoapi.exceptions
Previous version worked fine (also using the install guide, which is now shorter?)

install pgoapi first

more errors:
root@vpsxxx:~/PokemonGo-Bot# python pokecli.py --config ./configs/config.json
Traceback (most recent call last):
File "pokecli.py", line 38, in
from pgoapi.exceptions import NotLoggedInException
File "/root/PokemonGo-Bot/src/pgoapi/pgoapi/init.py", line 19, in
from pgoapi.pgoapi import PGoApi
File "/root/PokemonGo-Bot/src/pgoapi/pgoapi/pgoapi.py", line 36, in
from pgoapi.auth_google import AuthGoogle
File "/root/PokemonGo-Bot/src/pgoapi/pgoapi/auth_google.py", line 31, in
from gpsoauth import perform_master_login, perform_oauth
File "/usr/local/lib/python2.7/dist-packages/gpsoauth-0.3.0-py2.7.egg/gpsoauth/init.py", line 4, in
from . import google
File "/usr/local/lib/python2.7/dist-packages/gpsoauth-0.3.0-py2.7.egg/gpsoauth/google.py", line 4, in
from Cryptodome.PublicKey import RSA
ImportError: No module named Cryptodome.PublicKey

Had the same issue regarding the NotLoggedInException, running the install.sh again fixed it for me :)

install.sh gives me more errors. I even reset my VPS with a clean ubuntu 14 again. installed all the things needed (and where the previous version worked with) and it still isn't working :(

Reinstalled my vps with ubuntu 14. Now requirements seems to install without error. When trying to run I get this error:
root@vps302521:~/PokemonGo-Bot# python pokecli.py
Traceback (most recent call last):
File "pokecli.py", line 39, in
from pokemongo_bot import logger
File "/root/PokemonGo-Bot/pokemongo_bot/init.py", line 13, in
from pgoapi import PGoApi
File "/root/PokemonGo-Bot/src/pgoapi/pgoapi/init.py", line 19, in
from pgoapi.pgoapi import PGoApi
File "/root/PokemonGo-Bot/src/pgoapi/pgoapi/pgoapi.py", line 34, in
from pgoapi.rpc_api import RpcApi
File "/root/PokemonGo-Bot/src/pgoapi/pgoapi/rpc_api.py", line 42, in
from POGOProtos.Networking.Envelopes_pb2 import RequestEnvelope
File "/root/PokemonGo-Bot/src/pgoapi/pgoapi/protos/POGOProtos/Networking/Envelopes_pb2.py", line 9, in
from google.protobuf import symbol_database as _symbol_database
ImportError: cannot import name symbol_database
root@vps302521:~/PokemonGo-Bot#

getting the same issue on ubuntu 14


Allow to switch to folder/workspace without window reload

#34774

VSCode, open a no folder vscode
Click on the big open folder button in the explorer
Notice that VSCode reloads - unlike most other scenarios where we are adding aditional folders where this just happens

This scenario is blocked by not being able to start/stop extensions without window reload. The folder to open could have specific extension settings configured.

We have two blockers for this

Changing UI state
Extensions

If we tackle the UI state issue we are good to go for 90 percent of cases. Having different extensions per workspace is less likely. We can trigger reload in only such cases.

Blockers:

understand the consequences of entering an existing workspace without reload (memory, processes, singlestons, etc.)
restore workspace associated state (e.g. the opened editors)
restore backups

With individual APIs to stop & start extension hosts, we can now restart extension host with new set of extensions ie., those which are enabled for the folder that is getting opened.


[list] Fix first selection

Description
First click raises an error.
Patch
Fix the error raised.
Fixes #750

Just a warning on Map usage is it generated by Babel


Elements generation issue

When you generate elements from figma file give an error in each generated element (.tsx component).
To Reproduce
Steps to reproduce the behavior:

Clone repository https://github.com/mikaelvesavuori/figmagic-example
Install dependencies
Add project to your figma https://www.figma.com/community/file/821094451476848226
Create .env with figma creds
npx figmagic
npx figmagic --syncElements,

Expected behavior
Expected to get and generate elements from figma without issues with props in generated components.
Screenshots

Hi @RmnMatusevich!
I just released 4.5.7 that should fix this. See https://github.com/mikaelvesavuori/figmagic/releases/tag/v4.5.7


make sure all the rescheduled containers were removed

Signed-off-by: Victor Vieux<EMAIL_ADDRESS>

ping @abronan

LGTM


Enable user to preserve stateful resources on stage destroy

Allow user to preserve:

logs
dynamodb tables
s3 buckets

Marking as wontfix right now.
It was mostly idea and stays like that.


Offline devices don't appear as offline in homekit

Hello,
I'm running Homebridge on a Mac connecting to 6 devices through a Mosquitto MQTT broker installed on the same machine. The devices are Sonoff (ESP8266) flashed with Tasmota MQTT enabled firmware.
I'm using this plugin and most everything is working well; I can control state of the devices through Homekit and get real-time state of the device reported back to Homekit when the device is toggled manually.
My expectation is that when a device goes offline through a loss of power or network, Homekit should show the device as "offline" or some such. But there is no outward indication that the device is in trouble, in fact Homekit still lets me toggle the button on/off and behaves as though all is ok.
I can see by monitoring the LWT topic that mosquito does report it as "offline" and if I open the "details" page for the device in Homekit I can see that "status active" = No.
It was suggested that the problem may be in the plugin. That doesn't seem right to me, but I'm asking anyway to be sure.
Is this normal?
Any suggestions?
[Cut from config.json below]
Thanks very much,
"accessories": [
{
"accessory": "mqtt-switch-tasmota",
"switchType": "other",
	"name": "POE Switch",

	"url": "mqtt://<IP_ADDRESS>",
	"username": "",
	"password": "",

	"topics": {
		"statusGet": "stat/poepwr01/RESULT",
		"statusSet": "cmnd/poepwr01/POWER",
		"stateGet": "tele/poepwr01/STATE"
		},
	"onValue": "ON",
	"offValue": "OFF",

	"activityTopic": "tele/poepwr01/LWT",
    "activityParameter": "Online",

	"startCmd": "cmnd/poepwr01/TelePeriod",
	"startParameter": "60",

	"manufacturer": "ITEAD",
	"model": "Sonoff Basic",
	"serialNumberMAC": "EC:FA:BC:06:1C:44"
	}]

I've the same 'problem'.
Funny thing is, in the EVE-app, is does say offline....

I can't make a test until I buy one of these devices, get back home and install the whole thing... But.
Check out;
https://github.com/cflurin/homebridge-mvc/blob/master/lib/accessory.js#L225
See how it uses
if (this.reachable) {
...
callback("no_response");

I tested this on another plugin, and it worked.
So for this plugin, I would say for this code;
MqttSwitchTasmotaAccessory.prototype.getStatus = function(callback) {
	if (this.activeStat) {
		callback(null, this.switchStatus);
	} else {
		callback(null);
	}
}

Change it to;
MqttSwitchTasmotaAccessory.prototype.getStatus = function(callback) {
	if (this.activeStat) {
		callback(null, this.switchStatus);
	} else {
		callback("no_response");
	}
}

Should probably also modify this;
MqttSwitchTasmotaAccessory.prototype.setStatus = function(status, callback, context) {
	if (context !== 'fromSetValue') {
		this.switchStatus = status;
		this.client.publish(this.topicStatusSet, status ? this.onValue : this.offValue, this.publish_options);
	}
	callback();
}

To;
MqttSwitchTasmotaAccessory.prototype.setStatus = function(status, callback, context) {
	if (this.activeStat) {
              if (context !== 'fromSetValue') {
		     this.switchStatus = status;
		    this.client.publish(this.topicStatusSet, status ? this.onValue : this.offValue, this.publish_options);
	     }
	     callback();
	}   else {
		callback("no_response");
	}
}

If anyone can test this out, I'd love to know if it solved the problem.

I have just tested this, and it seems to work great! It was the only feature I was missing from this great plugin :)

Is this going to be on the next release? I’m having the exact same problem: on the home app the accesory shows that is off but is actually on. I have to turn it on and then off to turn it off.

Good question. This feature would be a great addition 👍🏻😊

Actually, it was successfully pulled recently:
https://github.com/MacWyznawca/homebridge-mqtt-switch-tasmota/pull/10
Unfortunately, the NPM-package still not up to date on npmjs.com - had to update the file manually.

Updating index.js manually works great! Thanks!!!

@mriksman Would there also be a quick status fix for the temperature plugin?
https://github.com/MacWyznawca/homebridge-mqtt-temperature-tasmota/blob/master/index.js


BadgeApp: Fix text errors

The form doesn't always match criteria.md

I've made progress on this front, intend to finish tomorrow.


change transactions clients method signatures to match use, allow result of None to return 204

Related Issue(s):

https://github.com/stac-utils/stac-fastapi/issues/376

Description:

for all Txn clients, update the method return types to match what can actually be returned. This is now None, a STAC object type, or a starlette Response.
In addition to the existing behavior of returning a 200 + STAC object type or Response, also return a 204 No Content if the result value is None.

PR Checklist:

[X] Code is formatted and linted (run pre-commit run --all-files)
[X] Tests pass (run make test)
[X] Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
[X] Changes are added to the CHANGELOG.

Discussed this with @geospatial-jeff. On the one hand, it is generally the case that exceptions are used to inject non-200 responses. At the same time, we agreed it felt bizarre to force exceptions in non-exceptional cases. +1


Redirect logs from save-execution containers to loki

https://github.com/docker-java/docker-java/pull/1676


Nothing useful happens after esy run.

I have followed Build and Run to run Oni2, but I have problem with esy run command. When I execute esy run I can only see single rectangle blink in the middle of the screen. Neither error nor message is printed in the terminal.

Hi! Sorry for the issues caused!
Could you run esy run -f --checkhealth? That might give us some extra info.
Also running esy run -f (No fork, which sends the debug info to the screen) whilst you have the ONI2_DEBUG environment variable set to 1?
That should let us start seeing some of the debug information, to work out what is causing the issue here.

esy run -f --checkhealth is ok, everything passes.
esy run -f output:
[DEBUG] Startup: Parsing CLI options complete
[DEBUG] Starting Onivim 2.
[DEBUG] Calling App.start
[DEBUG] Init
[INFO] [Revery]: Window: Starting window creation...
[INFO] [Revery]: Window: Using vsync: true
[INFO] [Revery]: Window: Creating window Oni2 width: 800 height: 600
[INFO] [Revery]: Window: Window created - id: 2
[INFO] [Revery]: Window: Setting window context
X Error of failed request:  GLXBadDrawable
  Major opcode of failed request:  152 (GLX)
  Minor opcode of failed request:  5 (X_GLXMakeCurrent)
  Serial number of failed request:  251
  Current serial number in output stream:  251

Hm, that looks to be the same error as over here: https://github.com/revery-ui/revery/issues/568
Are you on Arch as well?

Yes, I use Arch.

Bummer! Looks like @glennsl isn't the only one hitting this with the upgrade to SDL2 https://github.com/revery-ui/revery/issues/568
Just for extra data:

What type of GPU are you using, @m-kru ? I'm wondering if this is specific to the newer NVidia drivers - or something more general.

01:00.0 VGA compatible controller: NVIDIA Corporation GP106M [GeForce GTX 1060 Mobile] (rev a1)
	Subsystem: Tongfang Hongkong Limited GP106M [GeForce GTX 1060 Mobile]
	Kernel driver in use: nvidia
	Kernel modules: nouveau, nvidia_drm, nvidia

Hitting this as well on arch + NVIDIA card:
01:00.0 VGA compatible controller: NVIDIA Corporation GM204 [GeForce GTX 980] (rev a1)
	Subsystem: NVIDIA Corporation GM204 [GeForce GTX 980]
	Kernel driver in use: nvidia
	Kernel modules: nouveau, nvidia_drm, nvidia

git-bisecting it indeed points to the SDL2 integration (f459914ea0dd0830aa6945420acb38958c5a896f), commits before that still work just fine.

Thanks @necabo and @m-kru for the details and the investigation.
I debugged this with @glennsl earlier today - looks like it was fixed for him in this commit: https://github.com/revery-ui/reason-sdl2/commit/9e93f9d565e2adce23635f839aa014f93999c0ec
I've just pulled in that change with #813 - would you mind trying on the latest master?

Ok, now I am able to launch Oni2. But to be honest, the number of bugs, that I have spotted in 5 minutes is surprisingly high :( .

Ok, now I am able to launch Oni2. But to be honest, the number of bugs, that I have spotted in 5 minutes is surprisingly high :( .

We are still in pre-alpha! Bugs are slowlgy getting ticked off, I think mainly based on the number of 👍 s the issues on here have. Because of that, its useful to check if there is an issue/raise one.

I've just pulled in that change with #813 - would you mind trying on the latest master?

Can confirm it "working for me"™ again.

Thanks for confirming that it launches now with #813 , @necabo and @m-kru !

Ok, now I am able to launch Oni2. But to be honest, the number of bugs, that I have spotted in 5 minutes is surprisingly high :( .

Yes, we have our work cut out for us! But logging them is helpful - thank you 👍  And '+1'ing issues that impact you helps us prioritize.
I'll close this particular issue now as it was resolved with #813


Upgrade Grafana to 8.0.1

This PR upgrades Grafana to 8.0.1 and also enables the alerting feature

/meow


[silgen] Hide ManagedValue::forUnmanaged and rewrite all uses to use more specific APIs

Just further work so I can force ManagedValues to specify the scope that their lifetime is part of.

@swift-ci test

@swift-ci test source compatibility

I am not going to wait for the release compatibility suite since I was just checking for assertions after SILGen. So debug is fine.


Issue while executing https://github.com/suriyadeepan/easy_seq2seq

I tried running execute.py from https://github.com/suriyadeepan/easy_seq2seq however, I'm facing trouble with this.
Not sure if I'm doing something wrong, but a suggestion or a solution would be great help.
This is the dump from my Windows CMD prompt:
C:\Users\myPC\Downloads\easy_seq2seq-master\easy_seq2seq-master>python execu te.py
Traceback (most recent call last):
  File "execute.py", line 31, in <module>
    import seq2seq_model
  File "C:\Users\myPC\Downloads\easy_seq2seq-master\easy_seq2seq-master\seq2 seq_model.py", line 28, in <module>
    from tensorflow.models.rnn.translate import data_utils
ImportError: No module named 'tensorflow.models'

This belongs on StackOverflow, not as a github issue. tensorflow.models is a separate repository from this one. The translate directory can be found here.

The code referenced is not a TF owned code.
It simply seems to be out of date.
Please contact the owner of the code, or reach out to StackOverflow as @mckinziebrandon suggested.
Closing this issue.


Stuck on revision 45-1

Title says it all really, checking for updates comes back as all upto date, however my version is stuck on 45-1.

Can you post the output of this command: cat /frzr_root/source ?
Most likely you pinned the version to 45-1.

Sorry for the delay, I have been away.

sudo frzr-deploy chimeraos/chimeraos:stable

Unfortunately I get this response

Unfortunately I get this response

You didn't type everything I said.

Apologies, redone, it looks to have installed 46-2 however I now cannot enter gamemode

What hardware are you using?

Ryzen 5800x3d, with an Rx7900xt


lack of warnings/errors for unwanted latches

Consider the following trivial (and buggy) code:
module test1 (input logic a, b, output logic y);
always_comb begin
 if (a)
   y = b;
end
endmodule

read_slang does not give any error or warning, and a muliplexer with output connected to in_0 is synthesized.
read_verilog -sv followed by: proc gives correctly the following message and exit: ERROR: Latch inferred for signal \test1.\y from always_comb process
Similar problems occur for case statement, with case values incompletely covered (no default)

Thanks, that needs addressing

Actually I am not sure it needs addressing, this will emit a combinational loop which will be caught in a subsequent check call. To me a combinational loop is not an invalid reading of the input code when always_comb prohibits inference of latches.
We could detect this in the frontend and emit a warning/error, but there's risk of false positives depending on how we do the detection. In any case I reclassify this as an enhancement.

I think the way it is currently handled in yosys-slang itself is fine (ie check catching the loop).
What would be more interesting would be a warning (or just info) in Slang itself that warns of incomplete cases.
-Wcase-gen-dup and -Wcase-gen-none show that something like that is probably possible.


[New Port Request] eventi

Library name
eventi
Library description
Library for creating custom events with callbacks in C++.
Source repository URL
https://github.com/Swassie/eventi
Project homepage (if different from the source repository)
No response
Anything else that is useful to know when adding (such as optional features the library may have that should be included)
No response

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


Add a Gitter chat badge to README.md

Mindsers/nativetable now has a Chat Room on Gitter
@Mindsers has just created a chat room. You can visit it here: https://gitter.im/nativetable/Lobby.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Coverage remained the same at 81.893% when pulling 0e60798ad833e6a8fe6632aea21cfab05d29cbd1 on gitter-badger:gitter-badge into dcd3f95da2b766b8b3b19c15cd7e197e805e0282 on Mindsers:master.

Coverage remained the same at 81.893% when pulling d907a063ca389fc3434bb200c0a127f989c272fd on gitter-badger:gitter-badge into dcd3f95da2b766b8b3b19c15cd7e197e805e0282 on Mindsers:master.


Changing overlay stroke color

Hello,
In order to easily change color of the white rect border, could we make "overlayColor" value in "ReaderOverlayView" public?
Currently using  "ov.strokeColor = .black" for example is blocked due to internal protection level

Hello, as I can see in the latest version that field is still internal for the framework.
Can you please adapt it somehow (or make public) so users can easily change overlay (border) color while customizing overlayView?


Add support for go test

It will be nice to have support of go test command in pre-push hook.

Implemented in #685. Thanks!


issue in yarn install and npm 404 package not found

Description
Encountering a 404 error when attempting to install specific Radix UI packages. These packages seem to be unavailable or not resolving correctly in the package registry.
Affected Packages
The following packages are affected:
@radix-ui/react-aspect-ratio - ^1.1.0
@radix-ui/react-avatar - ^1.1.1
@radix-ui/react-dialog - ^1.1.2
@radix-ui/react-slot - ^1.1.0
@radix-ui/react-toast - ^1.2.2
Steps to Reproduce
Run npm install or yarn add for any of the packages listed above.
Observe the 404 error in the terminal.
Expected Behavior
The packages should install successfully from the npm registry without any errors.
Actual Behavior
The following error message appears:
perl
Copy code
404 Not Found - GET https://registry.npmjs.org/@radix-ui/
Environment
Node.js version: x.x.x
npm/Yarn version: x.x.x
Operating System: Your OS
Package Manager: npm or yarn
Additional Notes
I have confirmed that my internet connection is stable.
The issue persists across multiple systems and environments.
Could this be related to a recent update or registry configuration issue?
Please advise on how to resolve this issue or if the packages are temporarily unavailable.

NPM is down for maintenance.
https://status.npmjs.org/

Not able to reproduce this unfortunately, but it sounds like it might be an issue with your local environment. If you can create an isolated repro, happy to re-open and look into it.


Cannot detect persisitance entity in maven dependency

xxx.xxxx.xxxx
domain
1.1.0-SNAPSHOT

...

com.mysema.maven
apt-maven-plugin
1.1.3

process

target/generated-sources/qDomain
com.mysema.query.apt.jpa.JPAAnnotationProcessor

true

Could you elaborate?

I think he is having the same issue as I have : if the model entities are not in the same maven artifact as the repository having the apt-maven-processor plugin, the Q-entities are not generated

Me to,  a.pom.xml has model has entities ,b.pom.xml has repository   ,but apt-maven-processor dit not create the Q[className] 's java file

Well, apt doesn't work with dependencies.. afaik
You could ask the type system for types, but not ask the processing run for annotations not on the source path.


Clean up after making formating floating point numbers @nogc.

Followup on #8005, #8006 and #8007.

Add note for the changelog.
Remove several useless buffers
Remove two items from note in docs of sformat about GC usage.

I also tried to annotate a unittest with @nogc, but that failed. The reason is, that there are several calls to range primitives (e.g. put in writeAligned or indirectly in graphemeStride, where the compiler does not manage to deduce that they are @nogc.
Please note that the changes in std.format.internal.write look like much, but aside from the first few lines it's moving everything four spaces to the right, because the static if doesn't need this anymore.

If formatting floating point numbers is @nogc shouldn't some methods be marked as @nogc ?

If formatting floating point numbers is @nogc shouldn't some methods be marked as @nogc ?

I havn't found a way to do so and I don't completely understand the reason why. The test introduced in #7393 from @rainers shows (at least as I understand it), that GC is not used, meanwhile not even for arbitrary large output. The former implementation was limited to about 500 characters.
To find out, why the compiler thinks, a certain function is not @nogc, is rather difficult. It only tells that it thinks that the function isn't. But not more. I can go deeper and try to annotate the mentioned function with @nogc. And then go deeper again. That led me to the range primitives, where I had to stop this process.
If anyone could provide a function annotated with @nogc (or could explain me, why this doesn't work) I'd appreciate that.

If a function is marked @nogc the compiler checks for 2 things: it checks that all functions that are called are marked as nogc and that there are no operations that call the garbage collector (you can check this file for more specifics on that [1]). For templated functions, however, @nogc can be inferred depending on the instantiation. There is the hammer way where you can simply mark a template as @nogc and force all instantiations to be @nogc (this is done in some places in phobos [2]).
My expectation would have been that the format function, even though it is a template, could be marked as @nogc as a result of your PRs. That was what I was referring to in my previous comment.
As for the unittest that you mentioned, my intuition is that the garbage collector is invoked (therefore the unittest cannot be marked as @nogc), however, no memory is allocated. That is why the garbage collector specific functions are used to check that no memory was actually allocated. @rainers correct me if I am wrong.
I would suggest trying to mark the functions that do not allocate as @nogc and see what happens. We can start from there.
[1] https://github.com/dlang/dmd/blob/master/src/dmd/nogc.d#L31
[2] https://github.com/dlang/phobos/blob/master/std/exception.d#L1039

If anyone could provide a function annotated with @nogc (or could explain me, why this doesn't work) I'd appreciate that.

You often can't use @nogc because something deep down might throw an exception. For example, front on a string might throw a UTFException.

With the help of dmd PR 12383 I got the following:
std/format/internal/floats.d(2971): Error: `@nogc` function `std.format.internal.floats.__unittest_L2964_C7` cannot call non-@nogc function `std.format.internal.floats.printFloat!(NoOpSink, float, dchar).printFloat`
std/format/internal/floats.d(34):          could not infer `@nogc` for `std.format.internal.floats.printFloat!(NoOpSink, float, dchar).printFloat` because:
std/format/internal/floats.d(144):          - calling `std.format.internal.write.writeAligned!(NoOpSink, string, string, string, dchar).writeAligned` which is not `@nogc`
std/format/internal/write.d(3235):            could not infer `@nogc` for `std.format.internal.write.writeAligned!(NoOpSink, string, string, string, dchar).writeAligned` because:
std/format/internal/write.d(3240):            - calling `std.format.internal.write.writeAligned!(NoOpSink, string, string, string, string, dchar).writeAligned` which is not `@nogc`
std/format/internal/write.d(3244):              could not infer `@nogc` for `std.format.internal.write.writeAligned!(NoOpSink, string, string, string, string, dchar).writeAligned` because:
std/format/internal/write.d(3264):              - calling `std.format.internal.write.getWidth!string.getWidth` which is not `@nogc`
std/format/internal/write.d(3537):                could not infer `@nogc` for `std.format.internal.write.getWidth!string.getWidth` because:
std/format/internal/write.d(3265):              - calling `std.format.internal.write.getWidth!string.getWidth` which is not `@nogc`

Here, the output stopped, but that far I had come without this new feature (although it would have saved me a lot of time). So I annotated getWidth with @nogc and got:
std/format/internal/write.d(3543): Error: `@nogc` function `std.format.internal.write.getWidth!(char[]).getWidth` cannot call non-@nogc function `std.format.internal.write.getWidth!(char[]).getWidth.all!(char[]).all`
std/algorithm/searching.d(120):          could not infer `@nogc` for `std.format.internal.write.getWidth!(char[]).getWidth.all!(char[]).all` because:
std/format/internal/write.d(3547): Error: `@nogc` function `std.format.internal.write.getWidth!(char[]).getWidth` cannot call non-@nogc function `std.uni.graphemeStride!char.graphemeStride`
std/uni/package.d(7105):          could not infer `@nogc` for `std.uni.graphemeStride!char.graphemeStride` because:
std/uni/package.d(7110):          - calling `std.uni.genericDecodeGrapheme!false.genericDecodeGrapheme!(const(char)[]).genericDecodeGrapheme` which is not `@nogc`
std/uni/package.d(6975):            could not infer `@nogc` for `std.uni.genericDecodeGrapheme!false.genericDecodeGrapheme!(const(char)[]).genericDecodeGrapheme` because:
std/uni/package.d(6999):            - calling `std.range.primitives.front!char.front` which is not `@nogc`
std/range/primitives.d(2498):              could not infer `@nogc` for `std.range.primitives.front!char.front` because:
std/range/primitives.d(2504):              - calling `std.utf.decode!(Flag.no, const(char)[]).decode` which is not `@nogc`
std/utf.d(1121):                could not infer `@nogc` for `std.utf.decode!(Flag.no, const(char)[]).decode` because:
std/utf.d(1137):                - calling `std.utf.decodeImpl!(true, Flag.no, const(char)[]).decodeImpl` which is not `@nogc`
std/utf.d(1443):                  could not infer `@nogc` for `std.utf.decodeImpl!(true, Flag.no, const(char)[]).decodeImpl` because:

I think this is enough. Looks like there is a long way to go...

I havn't found a way to do so and I don't completely understand the reason why. The test introduced in #7393 from @rainers shows (at least as I understand it), that GC is not used, meanwhile not even for arbitrary large output. The former implementation was limited to about 500 characters.

IIRC, the test was there to verify that no GC allocations happen with reasonable sizes, but it could still allocate for huge numbers, e.g. here: https://github.com/dlang/phobos/pull/7393/files#diff-0d234c6b34c08dbe8b91f67337884a45095fc2f4e6b1640bebe20cced56a3606R7066
When looking at the current code, this statement looks strange: https://github.com/dlang/phobos/blob/master/std/format/internal/write.d#L599. Is that .dup intentional?

IIRC, the test was there to verify that no GC allocations happen with reasonable sizes, but it could still allocate for huge numbers, e.g. here: https://github.com/dlang/phobos/pull/7393/files#diff-0d234c6b34c08dbe8b91f67337884a45095fc2f4e6b1640bebe20cced56a3606R7066

That's what the precursor PRs of this changed: Meanwhile no GC allocations happen, independed of sizes.

When looking at the current code, this statement looks strange: https://github.com/dlang/phobos/blob/master/std/format/internal/write.d#L599. Is that .dup intentional?

Uh, that code is (old, buggy and) on the verge of being removed. It's meanwhile only used for exotic reals (128 bit and such stuff).

@berni44 How do you suggest we proceed here? Should we pull this and investigate how to make the called functions @nogc? If throwing exceptions is the problem, there's DIP1008 [1] which allows exceptions to be thrown in @nogc code, however, I doubt that that DIP is in a usable state.
[1] https://github.com/dlang/DIPs/blob/master/DIPs/other/DIP1008.md

@berni44 How do you suggest we proceed here? Should we pull this and investigate how to make the called functions @nogc? If throwing exceptions is the problem, there's DIP1008 [1] which allows exceptions to be thrown in @nogc code, however, I doubt that that DIP is in a usable state.

I guess, as long, as we have the problem with exceptions, we will not manage to add @nogc to any function. But dealing with this is beyond the scope of this PR.
Before merging this, I think we should ponder about the changelog entry. What do we want to tell users there? I fear, they will hope for being able to annotate functions with @nogc which won't work. On the other hand, I think, that we should communicate, that another step towards @nogc has been done. What is your opinion on that?
Finally, I think this PR should be merged, before 2.079.0-beta is branched off, which I expect to happen in 2 or 3 days.

On the other hand, I think, that we should communicate, that another step towards @nogc has been done. What is your opinion on that?

I think the best way is to be sincere up-front. Something on the lines of: we made sure that working examples never allocate with the gc, however, we are still using exceptions which are gc managed. Therefore, code that uses formatting correctly will never allocate, but in the case of exceptions, the gc will be used to allocate the exception. We are working on dip1008 to solve this issue.

I think the best way is to be sincere up-front. Something on the lines of: we made sure that working examples never allocate with the gc, however, we are still using exceptions which are gc managed. Therefore, code that uses formatting correctly will never allocate, but in the case of exceptions, the gc will be used to allocate the exception. We are working on dip1008 to solve this issue.

OK. Done. Thanks.


Cannot search any longer on book title, journal title, short journal title nor conference title

Bug description
Cannot search any longer on publisher, book title, journal title nor conference title
Steps to Reproduce
Go to biblio test or production, and look for

a publisher
- Elsevier BV
a conference title
- Optical Components and Materials XX (test)
- Academy of Management Annual Meeting (production)
a journal title / short journal title
- BURNS or Burns (test)
- Journal of Neurology or J Neurol (production)
a book title
- Snoeck (test)
- China Science and Technology Press (production)

Automatic testing scenario
When I use the search box, I can search on:

[works] ID
[works] Title
[works] (E-)ISSN, (E-)ISBN
[works] Department ID (e.g. GE32)
[works] Year
Alternative Title [does not work]
Journal Title [does not work now]
Short Journal Title [does not work now]
Book Title [does not work now]
Conference title [does not work now]

These fields were removed from the all fields since commit https://github.com/ugent-library/biblio-backoffice/commit/28285f331e4b2046293c6298bf53802707e095d4:

abstract
alternative_title
issue_title
keyword
publisher
publication
publication_abbreviation
series_title

Removal of "abstract" is ok.

what about datasets? All ok there?

@nicolasfranck And department code, e.g. pp05

Does not seem to work for Conference title yet. Test is failing (locally).

@nics are we sure? Because they referred to it as "we can't do this anymore, this was really convenient".

@mietcls I just tried Academy of Management Annual Meeting, and it looks like that string also appears in another field, e.g. "publisher" or "proceedings title".

@nicolasfranck I see, now I understand why @verheyenkoen's test fails for conference title. Feel free to add an example and include it if you discover something like this.

@mietcls So should the conference test be removed again (so we can close this ticket) or are we gonna add that behaviour?

We'll add it @verheyenkoen

@mietcls this can be closed


Enable systemd options as a docker_service attribute.

Description
Modifies the template file and systemd service files to allow users to specify an array of Systemd options, such as "TasksMax=infinity" that need to go into the /etc/systemd/system/docker.service file.
Pull request #759 and associated issue #756 would be covered by this in that rather than assuming a default for MountFlags that would need to apply to all Docker service deployments in Chef, users could dictate these settings through an attribute/property of the docker_service resource or docker_service_manager resource without losing the other extremely useful features of the cookbook by having to rewrite that file with their own cookbooks.
It's not really right to assume that MountFlags will be the very last setting that developers will want to change in the systemd settings--the list of potential settings is extremely long and complex. Better to let the developer make the decision in his/her cookbook.
Issues Resolved
#759 at least. But I'm sure many other systemd settings will come up if this is not resolved.
Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Signed-off-by: Ben Smith<EMAIL_ADDRESS>

Thanks for this work. It's going to help me make kubernetes work :)

Happy to help.  Is there something else I need to do to get this merged in?

LGTM thanks!


VR Support

Works on my pc, but on VR, if you drop the tablet, it falls through the desk and floor. If you throw it away, it doesn't respawn. Finally, you cannot select  anything with motion controllers. I tested this on my friend's HTC Vive. Please try and fix these problems, because it is such a useful addition.

Ok, I'll try to make the colliders bigger for the UI elements. And I'll also look to add a rigidbody collider to the entire tablet (I thought I had previously done that, but possibly not). As I have no kit to test this, I'll be making changes entirely in the blind.


Prevents ffmpeg from eating bytes on stdin

Signed-off-by: Maxime Gervais<EMAIL_ADDRESS>

Updated in https://github.com/MediaArea/RAWcooked/pull/326.


Using intl on a few more example pages to help with internationalization

Adding a bit more localization to the pro layout as it was a bit hard for me

Codecov Report

Merging #568 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #568   +/-   ##
=======================================
  Coverage   64.96%   64.96%
=======================================
  Files          34       34
  Lines        1079     1079
  Branches      408      408
=======================================
  Hits          701      701
  Misses        375      375
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2380cf5...919e558. Read the comment docs.


Config to save a input file

Hi guy,
As title, please help me config plugin to cache input file.
Thanks.

It is impossible to cache any input files.

Yes, thank you!


Recurring Donation Custom Installment Period translation support

The RD Custom Installment Period value is hardcoded as Days, Weeks, Months, and Years in both STG_PanelRDCustomInstallment_CTRL.listSORDCustomPeriod() and RD_RecurringDonations.getNextDate().  The ui value in listSORDCustomPeriod() should come from custom labels, so the ui can be translated.  It's correct, however, to always store the internal period in english.
Note that the use of custom labels in the RD processing code for Status and Multiply By is actually misleading.  The translator should translate the Picklist Values for these fields, but the internal storage should always be english.  Thus translators must not change these custom labels, but just translate the UI picklist values.
@mpusto fyi

**lurch: add

Tracking W-009670

FYI @jjbennett

Resolved in our new recurring donations functionality.


[SPARK-13889][YARN] Fix integer overflow when calculating the max number of executor failure

What changes were proposed in this pull request?
The max number of executor failure before failing the application is default to twice the maximum number of executors if dynamic allocation is enabled. The default value for "spark.dynamicAllocation.maxExecutors" is Int.MaxValue. So this causes an integer overflow and a wrong result. The calculated value of the default max number of executor failure is 3. This PR adds a check to avoid the overflow.
How was this patch tested?
It tests if the value is greater that Int.MaxValue / 2 to avoid the overflow when it multiplies 2.

Test build #53162 has started for PR 11713 at commit 8469148.

Test build #53162 has finished for PR 11713 at commit 8469148.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53162/
Test PASSed.

BTW, @carsonwang can you also describe without this change, what would happen to those applications with dynamic allocation enabled? This will helps people to understand the impact of this bug fixing.

Test build #53260 has started for PR 11713 at commit 1b4f1b1.

Without this patch, the application with dynamic allocation enabled will fail when only 3 executors are lost.

Test build #53260 has finished for PR 11713 at commit 1b4f1b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53260/
Test PASSed.

Merged build finished. Test PASSed.

cc @rxin @JoshRosen

cc @andrewor14

LGTM.

Merged to master. It looks like this was not a problem in 1.6 because the default was not Int.MaxValue at that point.

Thanks @srowen . There is no integer overflow in 1.6 but the max number of executor failure is also 3 if dynamic allocation is enabled. It should use Int.MaxValue as the default as the doc and other code use. Do you want me to submit a fix to 1.6?

OK if it's a different change for the same issue, and therefore not a question of cherry-picking, go ahead and make the change you think needs to happen for 1.6 and open a PR


Modifiers clickable and toggleable don't fire if there's a delay between down and up mouse events

@Composable
fun Thing(
    modifier: Modifier = Modifier,
    interactionState: InteractionState = remember { InteractionState() },
    content: @Composable RowScope.() -> Unit
) {
    val selected = remember{ mutableStateOf(false)}
    Box(
        modifier = modifier
            .background(if (selected.value) Color.Green else Color.Red)
            .pointerMoveFilter(
                onEnter = {
                    println("Entered")
                    false
                },
                onExit = {
                    println("Exited")
                    false
                },
                onMove = {
                    false
                })
            .toggleable(
                value = selected.value,
                enabled = true,
                interactionState = interactionState,
                indication = null,
                onValueChange = {
                    println("Toggled!")
                    selected.value = !selected.value
                })
    ) {
        Row(
            Modifier
                .defaultMinSizeConstraints(
                    minWidth = 64.dp,
                    minHeight = 36.dp
                )
                .padding(8.dp),
            horizontalArrangement = Arrangement.Center,
            verticalAlignment = Alignment.CenterVertically,
            content = content
        )
    }
}

fun main() = Window {
    Column(modifier = Modifier.fillMaxHeight().fillMaxWidth()) {
        Thing() {
            Text("sample")
        }
    }
}

If pointerMoveFilter is removed, "long" toggling works. But the combination of the two makes long toggle (mouse down, wait a second, mouse up) not working

This is macOS + build129

@kirill-grouchnikov could you please specify what exact behaviour do you expect?

It shouldn't matter how much time passes between down and up events. This is how pretty much all native apps on my Mac work.

It looks like a bug, long toggling should work, no matter if we use pointerMoveFilter or not

MacOs + build265 works fine (adjusted reproducer to API changes). @kirill-grouchnikov is it reproducible on your system now?
@Composable

fun Thing(
    modifier: Modifier = Modifier,
    content: @Composable RowScope.() -> Unit
) {
    val selected = remember{ mutableStateOf(false)}
    Box(
        modifier = modifier
            .background(if (selected.value) Color.Green else Color.Red)
            .pointerMoveFilter(
                onEnter = {
                    false
                },
                onExit = {
                    false
                },
                onMove = {
                    false
                })
            .toggleable(
                value = selected.value,
                enabled = true,
                interactionSource = remember { MutableInteractionSource() },
                indication = null,
                onValueChange = {
                    println("Toggled!")
                    selected.value = !selected.value
                })
    ) {
        Row(
            Modifier
                .defaultMinSize(
                    minWidth = 64.dp,
                    minHeight = 36.dp
                )
                .padding(8.dp),
            horizontalArrangement = Arrangement.Center,
            verticalAlignment = Alignment.CenterVertically,
            content = content
        )
    }
}

Yes, this is working on 265 now

Closing then

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Merge the-analytical-engine/main

Conflicts:

package.json - version number, I kept the one from the-analytical-engine (3.0.3)
src/app/components/navigation/WarningBanner.tsx - just the Isaac CS downtime banner, I changed the date range to end yesterday
src/app/components/site/cs/HomepageCS.tsx - just some imports

I had to fix the tests (which luckily are pretty solid and failed for understandable reasons), and make sure that highlightjs-vba is transformed when the tests are run (because it contains some ES6 syntax).
Changes I made: https://github.com/isaacphysics/isaac-react-app/compare/cc4ea1e320aeadec16ddc1d93a6ac3656ac601d1..3d92b9db96482d5fd9b6b039891d3ec95e7d3694

I added the code font-size thing straight to this - it's a small visual tweak and I would have committed it to master if I could.


Trigger animate event

Resolves #10.
I had tests for checking event.detail, but Puppeteer does not include that property in the event. You just have to take my words for it that event.detail is the IntersectionObserverEntry.

Also, I was not sure whether to trigger another event when the element is not intersecting (in reverse function). Let me know if you would like that.

I think that CustomEvent is not the best option in this case. I would prefer adding a callback property to sal.js options like onEnter and onExit, which will allow to track what element is currently in viewport, etc. CustomEvent API is not widely supported, so to run sal.js on Safari you would need to add 2 polyfills, which is too much in my opinion.

Using callback only allows 1 handler at a time. Having event allows multiple listeners. Also, having the event originated from the elements in viewport feels more natural to me than checking for desired elements in a single callback.
Polyfill for CustomEvent is very tiny. I'd rather patch things up for less used browsers than trying to accommodate them with outdated technique.
Besides, https://caniuse.com/#feat=customevent shows a better compatibility table for Safari.

As I see in Browser compatibility table, Safari doesn't support constructor of CustomEvent and detail property, which you use to provide entry's context. Please test it on Safari (preferably on 11th version) and confirm that it works properly.
Also I think that, it's a nice idea to add both enter and exit events, followed by sal prefix. So I would propose something like sal:enter and sal:exit for event names. I don't think that event name needs to be customisable.
Please also remember, that adding CustomEvent to sal.js requires proper note in documentation, especially about required polyfill.

The MDN's browser compatibility table only shows Safari 5.1. The current version of Safari is 12.0. And with most people on Mac OSX, their Safari is very up to date.
Here is the test I used to test on Safari 12.0, and it works fine.
Regardless, since a polyfill is required any way for IE, Safari should be taken care of.
Regard documentation, I don't think asking the user to include the polyfill is nice. We can simply include the following polyfill snippet in sal.js codebase:
(function () {

  if ( typeof window.CustomEvent === "function" ) return false;

  function CustomEvent ( event, params ) {
    params = params || { bubbles: false, cancelable: false, detail: undefined };
    var evt = document.createEvent( 'CustomEvent' );
    evt.initCustomEvent( event, params.bubbles, params.cancelable, params.detail );
    return evt;
   }

  CustomEvent.prototype = window.Event.prototype;

  window.CustomEvent = CustomEvent;
})();

Ok, I see that Safari is covered. As sal.js is based on IntersectionObserver, we need to adjust browser support to this API. In other words, we may not need polyfill for CustomEvent as you said that it's valid only for IE, which we don't support at all.
What about this one?

Also I think that, it's a nice idea to add both enter and exit events, followed by sal prefix. So I would propose something like sal:enter and sal:exit for event names. I don't think that event name needs to be customisable.

I'm merging this PR. It needs a few adjustments and then I will release it. Thanks!

Sorry, I somehow missed your comment. I could add those events with prefix if you would like.
I would also like to suggest "sal:in" and "sal:out" instead, to match with aos.

Thanks for suggestion. I have added it.


Update idls

What changed?

Update idls
Update internal types and mappers to support new idls

Why?

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 018e68e3-a947-4d58-bfb2-16b8b6fdcac2
Details

16 of 31 (51.61%)  changed or added relevant lines in 3 files are covered.
103 unchanged lines in 19 files lost coverage.
Overall coverage decreased (-0.05%) to 65.375%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/types/shared.go
0
15
0.0%

Files with Coverage Reduction
New Missed Lines
%

common/persistence/sql/sqlplugin/postgres/task.go
2
73.4%

common/persistence/sql/sqlplugin/postgres/db.go
2
80.0%

common/persistence/execution_manager.go
2
82.55%

common/persistence/sql/sqlplugin/mysql/task.go
2
73.68%

service/matching/db.go
2
73.23%

common/util.go
2
91.78%

service/history/execution/mutable_state_util.go
2
78.48%

common/persistence/statsComputer.go
2
95.71%

common/persistence/sql/sqlplugin/mysql/db.go
2
79.49%

common/log/tag/tags.go
3
50.18%

Totals

Change from base Build 018e65bd-b15a-441a-b795-bc7578fc4a8f:
-0.05%

Covered Lines:
95598

Relevant Lines:
146231

💛  - Coveralls


feat: Add config to settings GraphQL query

This PR adds config fields to the settings query. To query all fields in this query:
{
  settings {
    tzStatsUrl
    rpc
    contracts {
      nft
    }
  }
}

Created another PR to merge into develop instead of master.


Raise HandshakeFailure instead of ValueError when Ack is wrong size

Fixes #776
What was wrong?
ValueError was escaping during Peer.connect
How was it fixed?
Changed ValueError exceptions to be HandshakeFailure exceptions which are caught and handled in Peer.connect.
Cute Animal Picture

I think we should find out if those peers are actually replying with an empty/incomplete auth ack, or if it is a bug in our code (e.g. we're not reading the whole reply, or maybe it's an EIP8 ack), but if we use a HandshakeFailure here, these will now be relegated to the debug log together with the expected handshake errors (e.g. different network/genesis) and we'll forget about them. Given that, I'd prefer if we keep using a separate exception here and catch it in peer.handshake(), with a TODO comment saying we need to investigate

@gsalgado take a look at latest changes.  How does that look?
I ended up putting the handling in connect because p2p.peer.handshake only has a happy-path or exception raising where-as Peer.connect has a failure path by returning None.


Disable observing app background

@Veronique I can't approve this PR because I created it but you are free to merge it.


Testing the 'PR' version of the new split workflow

This PR changes the docs/ folder so should trigger workflow, but not run the 'deploy' step

Sorry, approved the wrong PR - I am a moron


Add installation instructions to the README

Extract to a library location
https://en.wikibooks.org/wiki/OpenSCAD_User_Manual/Libraries#Library_locations


Block importer update

Please recheck dependency queries for correctness, especially related to 'cms_nav_item'.
Tests with deleted blocks and nested page structures were successful though.

this fixes #370 !


Error 403 when downloading from youtube

I couldn't troubleshoot this myself, I don't do python :P
https://gist.github.com/MrabEzreb/8ad1fa7059df4cec1735

You are using an outdated version of youtube-dl. Read our FAQ if you have troubles updating.


Add screenshot on application window capability to Goose

Hi, with the screen toolkit, I can take a screenshot on the entire whole screen. However, if I use single screen, every time before I take a screenshot, I will need to move the terminal window or other unrelevant windows aside, so that these windows won't overlap the target area I am interested in.
As I saw the screen toolkit using screencapture command(code), which has a -w flag to take a specific windows. I tested that asking Goose to run the command for me:
G❯ can you run this command for me? screencapture -w -x /tmp/window_screenshot_test
_1.jpg
I'll help you capture another screenshot of the current window.
─── shell ─────────────────────────────────────────────────────────────────────────

 screencapture -w -x /tmp/window_screenshot_test_1.jpg

The screenshot has been captured and saved to /tmp/window_screenshot_test_1.jpg.
The command completed successfully. The -w flag captured the selected window and
the -x flag prevented the camera shutter sound from playing.

and it does capture the window I selected.
Can we add such capability to Goose screen tooltik? Happy to contribute

Hi @Kvadratni I would like to. Is there a contribute guide in RUST?


feat: Implement eth_getStorageAt method

Description
Read storage point from starknet rpc. Then return the response. Response type has to be padded to achieve same output as ethereums.
RPC Outputs
https://github.com/keep-starknet-strange/rosettanet/blob/main/rpc-call-examples/eth_getStorageAt.hurl
https://github.com/keep-starknet-strange/rosettanet/blob/main/rpc-call-examples/starknet_getStorageAt.hurl
Requirements

Unit tests have to be implemented.
Do not change the existing type structure

Completion Time
The issue is assumed to be completed in 5 days. If you need more time, please also specify that.

Hi, can I work on this issue?

Assigned

@all-contributors please add @TropicalDog17 for code,tests


Opening Code Studio in Safari 12 shows a blank screen, error in logs

Steps to Reproduce

Open Code Studio with Safari 12

Expected Results

Code studio opens, can do stuff

Actual Results

Blank page is shown, error in the log:

TypeError: function is not a constructor (evaluating 'new EventTarget')
e — LogProxy.ts:115
(anonymous function) — LogInit.ts:12
i — ide:1:1308
r — ide:1:1174
t — ide:1:1037
Global Code — main.18e248e9.chunk.js:1:102

In LogProxy.ts, we create a new EventTarget: https://github.com/deephaven/web-client-ui/blob/53749323846b09a4b0e6f5778306a35c80d3d3f1/packages/log/src/LogProxy.ts#L45
EventTarget constructor was only added to Safari in version 14: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/EventTarget
We're not targetting Safari, and it can be fixed by updating Safari, the recommendation is simply to update Safari.
However, we can fix this in Safari <14 by using event-target-shim (as we already do in GridModel). It's easy to do and will increase compatibility.


Handle process death.

Save BottomNavigator state in saveInstanceState.

What is the current behavior on process death? Default init settings? Isnt it a leak? Because fragments are still inside FragmentManager, arent they?

Yes it's a leak. BottomNavigator will create new fragments and ignore the existing ones inside FragmentManager.

Moved the memory leak bug to Issue #4. This ticket is for the enhancement to preserve BottomNavigator state after process death.


reading file problem on IIS, but works great on xampp

Hello!! first off all, great package!
I'm having an specific issue when deploying in IIS and is driving me crazy, I guess it might be a problem from the package thats why I'm posting the issue. This app (w/Laravel) simply gets an excel from the user and save it on the DB.
First I had this issue: when uploading the file, the route was wrong, appending 2 routes like this: "c:\www\myapp\c:\windows\temp\file.tmp" which was weird, but I commented the "if" in LaravelExcelReader.php line 734:
// if (!$noBasePath && !realpath($file)) {
//     $file = base_path($file);
// }

Now, it finds the file (yayy!!!) butit looks empty. And the same code stills works on local (XAMPP).
This is the line that gets the excel file in my controller:
Excel::selectSheets('content')->load($request->file('sheet'), function($reader) {

the result in my local xampp where it works is:
Maatwebsite\Excel\Collections\CellCollection Object
(
    [title:protected] =>
    [items:protected] => Array
        (
            [content_name] => Aries 25012016
            [content_type] => 1
            [content_body] => Loremipsumdolorsitametconsecteturblablalblabla....
        )

)

but, in IIS I'm having this:
Maatwebsite\Excel\Collections\CellCollection Object
(
    [title:protected] =>
    [items:protected] => Array
        (
        )

)

So, I don't know where to break to fix this. I already check file permissions, my app (laravel) has access to all directories with no restrictions. I guess it might be the way the package handles the file..?. Not sure.
Thanks for your help!
Diego

Hey
I honestly don't know an aweful lot about IIS and can't reproduce it.
Did you google PHPEXCEL IIS? Maybe something like this http://stackoverflow.com/questions/5368362/phpexcel-import-fails-during-load-on-iis could be the issue?

Thanks Patric. Yes I did, checked permissions and all. It doesn't seem to be the problem. I put the code the way it was before my changes, and this is the original error laravel gives me:
PHPExcel_Reader_Exception in Excel2007.php line 82:
Could not open C:\inetpub\www_horoscopo\laravel\C:\Windows\Temp\php7D19.tmp for reading! File does not exist.

in Excel2007.php line 82
at PHPExcel_Reader_Excel2007->canRead('C:\inetpub\www_horoscopo\laravel\C:\Windows\Temp\php7D19.tmp') in FormatIdentifier.php line 249
at FormatIdentifier->canRead('Excel2007', 'C:\inetpub\www_horoscopo\laravel\C:\Windows\Temp\php7D19.tmp') in FormatIdentifier.php line 229
at FormatIdentifier->lastResort('C:\inetpub\www_horoscopo\laravel\C:\Windows\Temp\php7D19.tmp', null, 'tmp') in FormatIdentifier.php line 55
at FormatIdentifier->getFormatByFile('C:\inetpub\www_horoscopo\laravel\C:\Windows\Temp\php7D19.tmp') in LaravelExcelReader.php line 1128
at LaravelExcelReader->_setFormat() in LaravelExcelReader.php line 660
at LaravelExcelReader->_init(object(UploadedFile), null, false) in LaravelExcelReader.php line 255
at LaravelExcelReader->load(object(UploadedFile), null, false) in Excel.php line 118
at Excel->load(object(UploadedFile), object(Closure)) in ExcelController.php line 107
at ExcelController->store(object(Request))
at call_user_func_array(array(object(ExcelController), 'store'), array(object(Request))) in Controller.php line 256
at Controller->callAction('store', array(object(Request))) in ControllerDispatcher.php line 164
at ControllerDispatcher->call(object(ExcelController), object(Route), 'store') in ControllerDispatcher.php line 112
at ControllerDispatcher->Illuminate\Routing\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 139
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in Authenticate.php line 45
at Authenticate->handle(object(Request), object(Closure))
at call_user_func_array(array(object(Authenticate), 'handle'), array(object(Request), object(Closure))) in Pipeline.php line 124
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 103
at Pipeline->then(object(Closure)) in ControllerDispatcher.php line 114
at ControllerDispatcher->callWithinStack(object(ExcelController), object(Route), object(Request), 'store') in ControllerDispatcher.php line 69
at ControllerDispatcher->dispatch(object(Route), object(Request), 'App\Http\Controllers\ExcelController', 'store') in Route.php line 201
at Route->runWithCustomDispatcher(object(Request)) in Route.php line 134
at Route->run(object(Request)) in Router.php line 704
at Router->Illuminate\Routing\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 139
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 103
at Pipeline->then(object(Closure)) in Router.php line 706
at Router->runRouteWithinStack(object(Route), object(Request)) in Router.php line 671
at Router->dispatchToRoute(object(Request)) in Router.php line 631
at Router->dispatch(object(Request)) in Kernel.php line 236
at Kernel->Illuminate\Foundation\Http\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 139
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in VerifyCsrfToken.php line 50
at VerifyCsrfToken->handle(object(Request), object(Closure))
at call_user_func_array(array(object(VerifyCsrfToken), 'handle'), array(object(Request), object(Closure))) in Pipeline.php line 124
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in ShareErrorsFromSession.php line 54
at ShareErrorsFromSession->handle(object(Request), object(Closure))
at call_user_func_array(array(object(ShareErrorsFromSession), 'handle'), array(object(Request), object(Closure))) in Pipeline.php line 124
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in StartSession.php line 62
at StartSession->handle(object(Request), object(Closure))
at call_user_func_array(array(object(StartSession), 'handle'), array(object(Request), object(Closure))) in Pipeline.php line 124
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in AddQueuedCookiesToResponse.php line 37
at AddQueuedCookiesToResponse->handle(object(Request), object(Closure))
at call_user_func_array(array(object(AddQueuedCookiesToResponse), 'handle'), array(object(Request), object(Closure))) in Pipeline.php line 124
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in EncryptCookies.php line 59
at EncryptCookies->handle(object(Request), object(Closure))
at call_user_func_array(array(object(EncryptCookies), 'handle'), array(object(Request), object(Closure))) in Pipeline.php line 124
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in CheckForMaintenanceMode.php line 42
at CheckForMaintenanceMode->handle(object(Request), object(Closure))
at call_user_func_array(array(object(CheckForMaintenanceMode), 'handle'), array(object(Request), object(Closure))) in Pipeline.php line 124
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 103
at Pipeline->then(object(Closure)) in Kernel.php line 122
at Kernel->sendRequestThroughRouter(object(Request)) in Kernel.php line 87
at Kernel->handle(object(Request)) in index.php line 58

Of course, this works perfectly with xampp on windows. As you can see, the path is wrong (C:\inetpub\www_horoscopo\laravel\C:\Windows\Temp\php7D19.tmp). I don't know what else to check.

I'm having the same problem, with the same errors. Works on xampp, doesn't work on IIS.
This code get the excel file in my controller on xampp:
       $srImport = Excel::load($request->file('srImport'), function($reader) {

        })->get();

But gets me this error on IIS:
PHPExcel_Reader_Exception in Excel2007.php line 82: Could not open C:\inetpub\wwwroot\prisonjustice/C:\Windows\Temp\php742.tmp for reading! File does not exist. I checked the 'C:\Windows\Temp\' directory on the IIS server. There is a php742.tmp file.

And this code works in xampp but gets me an empty collection in IIS:
       $srImport = Excel::load($request->file('srImport'), function($reader) {

        }, false, true)->get();

I found the solution! I added this to the top of the controller
use PHPExcel_Settings;
And this in the controller:
PHPExcel_Settings::setZipClass(PHPExcel_Settings::PCLZIP);
Here is the explanation from the PHPExcel documentation:

PHP complains about ZipArchive not being found
Make sure you meet all Requirements, especially php_zip extension should be enabled.
The ZipArchive class is only required when reading or writing formats that use Zip compression (Excel2007 and OOCalc). From version 1.7.6 the PCLZip library has been bundled with PHPExcel as an alternative to the ZipArchive class.
This can be enabled by calling:
PHPExcel_Settings::setZipClass(PHPExcel_Settings::PCLZIP);
before calling the save method of the Excel2007 Writer.
You can revert to using ZipArchive by calling:
PHPExcel_Settings::setZipClass(PHPExcel_Settings::ZIPARCHIVE);
At present, this only allows you to write Excel2007 files without the need for ZipArchive (not to read Excel2007 or OOCalc)

Glad it solved your problem, athough those notes are slightly out of date.... PHPExcel_Settings::PCLZIP is now supported for Readers as well as Writers

Sadly, it didn't solve the problem to me, I'm still having the wrong address.

Hello, may be you solved time ago, but I find out another way, I hope it can be helpfull for someone:
The load() method has 4 parameters, and the fourth one fix the issue for me:
Sintax:
Excel::load(file_path, callback, encoding, noBasePath)
The "noBasePath" by default is false, and because of it occurs the

PHPExcel_Reader_Exception in Excel2007.php line 82:
Could not open C:\inetpub\www_horoscopo\laravel\C:\Windows\Temp\php7D19.tmp for reading! File does not exist.

When the fourth parameter is set to true it looks like this:

C:\Windows\Temp\php7D19.tmp

$excel = \Excel::load($request->file('ExcelFile')->getPathName(),function($reader) {

} ,null,true)->get();

I use ubuntu 16.04 and php 5.6.
so apt-get install php5.6-zip solved my problem

@jofelgarze Confirmed your solution worked for me.  Thank you.  I was having the same problem from development to production on Digital Ocean Ubuntu LAMP.

you´re welcome!! it´s nice to know it help you!!

This is mine... Please Help....
Error loading file "Animal.xlsx": Could not open temp/Animal.xlsx for reading! File does not exist.
set_include_path(get_include_path() . PATH_SEPARATOR . 'Classes/');
/** PHPExcel_IOFactory */
include 'PHPExcel/IOFactory.php';
move_uploaded_file($_FILES["file"]["tmp_name"],
"temp/" . $_FILES["file"]["name"]) ;
$inputFileName = "temp/".$_FILES["file"]["name"];  // File to read
//echo 'Loading file ',pathinfo($inputFileName,PATHINFO_BASENAME),' using IOFactory to identify the format';
try {
$objPHPExcel = PHPExcel_IOFactory::load($inputFileName);
} catch(Exception $e) {
die('Error loading file "'.pathinfo($inputFileName,PATHINFO_BASENAME).'": '.$e->getMessage());
}
STILL can't solve the ERROR:
Error loading file "Animal.xlsx": Could not open temp/Animal.xlsx for reading! File does not exist.


Underlined parameter in tooltip not relevant after using a named parameter

Here you can see that default is the parameter hint being underlined, but it's only being highlighted because it's the fifth parameter and I've already typed four. This doesn't really make sense because the moment I started explicitly naming my parameters, the position no longer matters (and trying to put something in that position without naming it would simply fail).
It's probably better to stop underlining parameters in the tooltip once a named parameter has been given.

I think this turns out to be a lot more complicated than I thought it was. The LS gives a list of those parameters in SignatureInformation, and I think VSC is just picking by index which one to highlight. I'm not sure if there's a good way to handle this unless the LS can send a new SignatureInformation after the code changes, changing that list on the fly to match what is being written.

Turns out that we do control that index:
https://github.com/Microsoft/python-language-server/blob/083666d318bd5814131aab70c92f2cf55c6a3ee4/src/LanguageServer/Impl/Sources/SignatureSource.cs#L83-L97


Add needed import statement to needs_extra_options

In the needs_extra_options example, the options shall get directives.unchanged.
It is unclear, where directives.unchanged is coming from. So lets add from docutils.parsers.rst import directives to the example.

Maybe this kind of detailed definition is even not really needed.
I see no use case, where an additional option should be something different as directive.unchanged.
I guess that also our code would have some problem with any other kind of directive type...
So needs_extra_options could be a simple list and sphinx-needs sets the needed directive type internally:
needs_extra_options = ["author", "creation_date"]

This model is rather restrictive though.  For instance, if I want to introduce a piece of metadata and make it required, then I can't do that.  Likewise if I want to introduce an attribute that is a flag.  This seems like an important hook point for validation and error checking.  The full set of built-in options conversion functions are here: http://docutils.sourceforge.net/docs/howto/rst-directives.html#option-conversion-functions however at they simple functions and there's no need to use those vs. your own.
Improving the docs makes sense, but I wouldn't be in favor of removing the capability.   Perhaps, if you want to make it easier, then we could change the default behavior to if you specify None then we default to unchanged.  That avoids requiring an import, but leaves the option for customization if needed.

needs_extra_options = {
   "author": None,
   "approved": directive.flag,
}

Thoughts?

No problem to keep it as it is, if there are cases for different options conversion functions.
However I'm not sure if sphinx-needs can already handle it.
For instance if positive_int_list shall be used, sphinx-needs may crash as it expects a string and not a list. Maybe the same for a flag (But I haven't check the code right now).
So let's just do the doc update....

Fixed in 0.3.0


🚨: Public Goods work halted

Please see https://twitter.com/CosmWasm/status/1620783214125256704 for the announcement and discussion.

Thank you all for your support!
https://twitter.com/confio_tech/status/1630965447419133954