Corrupted Scenes due to Caching in .godot

Godot version
4.1.2 stable
System information
Godot v4.1.2.stable - Windows 10.0.22621 - Vulkan (Mobile) - dedicated NVIDIA GeForce RTX 4070 (NVIDIA; <IP_ADDRESS>40) - AMD Ryzen 7 3700X 8-Core Processor (16 Threads)
Issue description
Basically, I get corrupted scenes all the time. With the scenes and all resources completely ok and working. (Build works without Problems.)
Also there is no Info why they are corrupted/cant be opened.. In 3.x at least you always could open the scene and fix dependencies etc. But thats another topic.
So the main problem is, that rebasing in git basically corrupts my project (several scenes in it) everytime.
It worked fine before the rebase.
To fix this I need to delete the .godot folder. I load the project - still getting corrupted scenes issues (probably due to some weird racing conditions, without caches in .godot) - reload it again and then everything works.
This workaround works basically all the time when something goes corrupt.
Sorry if this already exists I looked through the issues and did not found anything (which is a little bit weird, as I guess it should happen to nearly everyone who uses git with rebase.
Steps to reproduce
Have a more or less complex project.
Rebase in Git.
Minimal reproduction project
Not really. Did not try out at which complexity stage of a project this happens. Or what needs to be done with a scene to trigger this behavior.
Maybe I find the time to do it.

In 3.x at least you always could open the scene and fix dependencies etc. But thats another topic.

This is fixed by #83024

So the main problem is, that rebasing in git basically corrupts my project (several scenes in it) everytime.

Rebasing the project should not have any effect on its stability, unless you happen to break some dependencies or track the .godot folder (which is not recommended).

.godot is not tracked
The rebase does not change anything (i.e. just squashing commits).
Opened Scripts and Scenes in Godot also get an update that something changed after a rebase (even so no content changed).

Rebase will affect modified time of the files and Godot will detect that, even if their content is the same. It should not have any effect.

Godot 4.1 - I just fixed a corrupt scene by copying the scene somewhere to save it, git revert the scene, overwrite the unchanged scene. Just putting this here, might open a proper issue report later, can't put time in a reproduction project right now.

Had many RigidBody2D in the scene moving at high pace and, while the game was running, changed Project Settings > Physics > 2D > Solver Iterations from 16 to 64
Game started slowing down significantly, I killed the Godot editor with task manager
Reopened project, the scene that was previously opened was now corrupted and couldn't be opened anymore

Again, here is how I fixed it

Copy the corrupted scene somewhere
git revert the corrupted scene
open project, open the previously corrupted scene - works now
close project, replace the now working scene with the one before the git revert
open project, open the scene. Everything works + my changes are there again

Maybe a button for the user to nuke all caches really is a good idea as a first step. Even if rebuilding these caches takes some minutes, it still would be faster than googling.

+1 for that. Or, what I really want is a button to nuke '.godot/global_script_class_cache.cfg' without nuking all of my imported assets. (Note: deleting 'global_script_class_cache.cfg' by itself breaks the project. The only option seems to be to delete the entire .godot directory.)

Hey,
I got some updates and narrowed the problem down in my case after some research and sparse information on this matter.
I think the biggest Problem is, that the error messages from the engine are so opaque...
But back to my case.
The issue resolved around preloading of resources and seemingly resulting cyclic references based on Static Typing, that lead to corrupt scenes.
And also preloading the same resource (tscn) twice from different code parts)
First Case: So I got Class A that preloads Class B.
Class A also has a static var holding the instance of itself, when it gets instantiated (only happens once and to remove the need for a singleton and the need to pass some reference around.)
Class B uses that instance.
After deletion of .godot I get the error (Class B) could not be loaded correctly.
After restarting this issue is seemingly resolved as I do net get any more errors in the console. But it is not.
As using this Class B in Scene of Class C (preloading/@export) seems to over time corrupts Scene C.
Second Case: I got Class A and it gets preloaded in Class B and Class C.
Also Class C references Class B and uses the preloaded Class indirectly through Class B and directly through preloading it.
A least there I get an error - that Class A gets loaded from a different place, when starting without .godot
Also after restarting the editor the error is gone.
Only the same issues arise.
Solved when one preload is changed to load.
I only got there because I did a little Refactoring and starting Scenes by itself in the process. Leading to error messages that did not come up, when the game was loaded by starting the main scene. These error messages where still not helpful, but at least I had a starting point for some digging.
So there seem to be two problems.
Cyclic referencing due to Code interpretation of the editor when using preload?
Preloading a Scene from different Classes. (That might also only be the case, when there is also a reference between the classes.)
The thing is, that these Scenes work fine. They run and you can open them without problems. So exerything seems fine. Only if you use these Scenes for other Scenes the problem arises, as these scenes get broken and you do not know why, because the tscene file is correct and every ressource and reference is working too and it works when you run the game....
I am not quite shure how the rebasing fits in there, but nuking the caches did not really solve the problem, it just posponed it until some Scene gets corrupted beyond obvious repair (Using one of the Classes/Scenes desrcibed above i.e. Inheriting from a Scene or preloading it.
Hope that helps.

Still happening on 4.2.1.stable.arch_linux. whats i found interesting (and what led me to this issue) is that the editor panics with a corrupt file but the preload doesn't (meaning that it's anoying to edit the scene, but should stiil work on release). Reloading the cache for a specific file could be a good fallback for when the engine finds a corrupt file, making so that the error only appears if the actual file is corrupted, not the cached one.

If I'm not mistaken, this seems related to #83395. In that issue, one creates a class error by duplicating a file. Well, the error is perfectly expected. However, unlike Godot 3.x, the editor can't seem to resolve these errors without the user manually deleting .godot.

I'm having this issue with the duplicated classes-- would it resolve my class issues if I deleted the .godot in my project, or will this screw my project up more?

Im having the same issue here, has there been any kind of fix?

It should be fixed in 4.3.

@KoBeWi can you link the PR/commit by which this is fixed? I'd like to give it a couple of runs, because seem to experience this issue a lot in after-rebase scenarios.

#92303 fixes script issues.
#85159 and the follow-up fixes issues with corrupted scenes that can't be opened.


[textures] Text/shapes don't appear in RenderTexture unless rendered twice (new in 3.0)

[x] I tested it on latest raylib version from master branch
[x] I checked there is no similar issue already reported
[x] My code has no errors or misuse of raylib

Issue description
I was trying to render a large amount of text to a RenderTexture. In the original example, the first half of the text did not appear but the second half did. On the second attempt (after reloading the level) all of the text appeared.
In a minimal example, I tried to draw text and some rectangles. If I ran the code once, only the first letter of the text appeared. After running the code twice, everything appeared.
Downgrading to 2.6 resolved the issue.
Environment
original issue mentioned: Replicated under Desktop, Windows 10 and Ubuntu, OpenGL 3.3, Intel HD 5500 + one friend also saw same issue under Windows.
minimal example: Replicated under Desktop, Ubuntu, OpenGL 3.3, intel HD 5500 + on one other person's PC
Issue Screenshot
If rendered once:

If rendered twice:

Code Example
https://hastebin.com/odepogevoj.cpp

@Andrew-Maxwell the link to the code doesn't seem to load

@Andrew-Maxwell please, could you provide a short code sample illustrating the issue? I tested shaders_custom_uniform and it seems to work ok.

That's weird, I think it's an issue with Hastebin. Anyway, here's the code:
`#include <raylib.h>
#include
using namespace std;
class textureTester {
RenderTexture2D renderTex;

public:

void init(string text) {
    renderTex = LoadRenderTexture(300, 300);
    BeginTextureMode(renderTex);
    ClearBackground((Color){0, 0, 0, 0});
    DrawText(text.c_str(), 150, 150, 20, BLACK);
    DrawRectangle(0, 0, 10, 10, RED);
    DrawRectangle(0, 290, 10, 10, BLUE);
    DrawRectangle(290, 0, 10, 10, GREEN);
    DrawRectangle(290, 290, 10, 10, PURPLE);
    EndTextureMode();
}

textureTester(string text) {

    //If init is only called once, only the "h" in "hello world" displays.

    init(text);
    init(text);
}

void print() {
    DrawTexture(renderTex.texture, 300, 300, BLACK);
}

};
int main(int argc, char** argv) {
InitWindow(1600, 900, "Texture Test");
SetTargetFPS(60);

textureTester t("hello world");

while(!WindowShouldClose()) {

    BeginDrawing();
    ClearBackground(WHITE);
    t.print();
    EndDrawing();
}

}`

Hi @Andrew-Maxwell, I verified the issue... very weird!
I created a simpler example that works ok:
#include "raylib.h"

int main(void)
{
    InitWindow(800, 450, "raylib render texture issue");
    RenderTexture2D target = LoadRenderTexture(300, 300);

    // WARNING: Draw to texture does not work properly here!

    SetTargetFPS(60);               // Set our game to run at 60 frames-per-second

    while (!WindowShouldClose())    // Detect window close button or ESC key
    {
        BeginDrawing();

            // Drawing to texture works ok here
            BeginTextureMode(target);
                ClearBackground(BLANK);
                DrawText("Hello World!", 90, 150, 20, BLACK);
                DrawRectangle(0, 0, 10, 10, BLUE);
                DrawRectangle(0, 290, 10, 10, BLUE);
                DrawRectangle(290, 0, 10, 10, GREEN);
                DrawRectangle(290, 290, 10, 10, PURPLE);
            EndTextureMode();

            ClearBackground(RAYWHITE);
            DrawTexture(target.texture, 0, 0, WHITE);

        EndDrawing();
    }

    UnloadRenderTexture(target);
    CloseWindow();

    return 0;
}

I need to investigate it...

Ok, found it and corrected the issue.
This is tha kind of issue that can drive you crazy... no compile errors, everything apparently working... very weird result on drawing depite everything being correctly processed... it was hard...


Ionic build --prod issue

ionic cordova build android --prod
Error: ./src/app/app.module.ngfactory.js
Module not found: Error: Can't resolve '../../angularfire2/database' in '/Users/chris/GIT/ccoocat/src/app'
resolve '../../angularfire2/database' in '...../src/app'
using description file: ...../package.json (relative path: ./src/app)
Field 'browser' doesn't contain a valid alias configuration
after using description file: ...../package.json (relative path: ./src/app)
using description file: ...../package.json (relative path: ./angularfire2/database)
no extension
...
ng version
angular-cli: 1.0.0-beta.28.3
node: 8.3.0
os: darwin x64
@angular/common: 4.1.3
@angular/compiler: 4.1.3
@angular/compiler-cli: 4.1.3
@angular/core: 4.1.3
@angular/forms: 4.1.3
@angular/http: 4.1.3
@angular/platform-browser: 4.1.3
@angular/platform-browser-dynamic: 4.1.3
ionic version
3.12.0
node -v
v8.3.0
npm -v
5.4.2
cordova -v
7.0.1
angularfire2 4.0.0-rc.2
don't works
angularfire2 4.0.0-rc.1
angularfire2 4.0.0-rc.0
building with --dev works well

This is an issue with angular I believe. I think it is fixed now. Please let me know if this doesn't work with the latest angular/ionic.
Thanks,
Dan


adding 2d projection to mat3

While developing a small framework to work with Quads on 2D environment, and for speed purposes, I found it useful to add a project2d style method. It receives the canvas width and height, and inverts on the Y axis so the 0 coordinate is on top.

any updates on this?


Added count for unique models and components

Description
This PR fixes #
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@abdullah1308 will you like into the Lint Checks?

@abdullah1308 PR title doesn't have a link to the issue where can I see the issue?

@abdullah1308 and can you please clarify to me, how the uniqueness of a component is defined. for example, if there is a slice of components like this [A, C, B, A, D, F, E, C, P] in your solution after loop iteration it ends up on the elements [A, C, B, D, F, E, P] contained in set map and returns  len(set) so is this desired uniqueness because the uniqueness can be evaluated as [B, D, F, E, P] since A, C are twice they aren't considered unique.

@abdullah1308 and can you please clarify to me, how the uniqueness of a component is defined. for example, if there is a slice of components like this [A, C, B, A, D, F, E, C, P] in your solution after loop iteration it ends up on the elements [A, C, B, D, F, E, P] contained in set map and returns len(set) so is this desired uniqueness because the uniqueness can be evaluated as [B, D, F, E, P] since A, C are twice they aren't considered unique.

@zakisk Yes, that is how it works


question: Should Code block require language?

From Bram call, @rothfels thought perhaps not having Code block require langauge attribute

it will make the entire system MUCH MUCH MUCH more complicated if we don't put the language on the code block.

right now we have 1 language that we contribute: glass.  if we put the language NOT on the code block, then we'd have to create n languages, where n is the number of different code syntaxes we support.  we'd have to go back to glass-py glass-ts glass-js etc etc
we would have to code-gen the textmate grammar files again, since we'd need a different syntax grammar per language
what happens if a user forgets to put the language in the frontmatter? is there a default language? can users set their own defaults? if so, we run into all the same problems that we had before

I don't support this because it introduces a bunch of complexity for very, very, very little value.  what I will do instead is autocomplete the <Code block to include the language ID so you don't have to type it out yourself


Fixing two small bugs which appeared in the model plot demo

model_plot could not handle evaluation arrays with nans in them. Fixed now
also the crossvalidation made problems when no pattern_descriptor was given.

@HeikoSchuett fyi, this seems to have introduced an error in the exercise_all.ipynb demo in this section:
results_1 = pyrsa.inference.eval_fixed(models, rdms_data, method='corr')
pyrsa.vis.plot_model_comparison(results_1)

---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
<ipython-input-9-b9fb1a9153d1> in <module>
      1 results_1 = pyrsa.inference.eval_fixed(models, rdms_data, method='corr')
----> 2 pyrsa.vis.plot_model_comparison(results_1)
      3
      4 #results_1 = pyrsa.inference.eval_fixed(models, rdms_data, method='spearman')
      5 #pyrsa.vis.plot_model_comparison(results_1)

~/anaconda3/envs/rsa/lib/python3.8/site-packages/pyrsa/vis/model_plot.py in plot_model_comparison(result, sort, colors, alpha, test_pair_comparisons, multiple_pair_testing, test_above_0, test_below_noise_ceil, error_bars)
    128     while len(evaluations.shape) > 2:
    129         evaluations = np.nanmean(evaluations, axis=-1)
--> 130     noise_ceiling = noise_ceiling[:, ~np.isnan(evaluations[:, 0])]
    131     evaluations = evaluations[~np.isnan(evaluations[:, 0])]
    132     perf = np.mean(evaluations, axis=0)

IndexError: too many indices for array: array is 1-dimensional, but 2 were indexed

I'm not sure how to fix it, but I just ran into the issue.


Add next-seo

Description
Setup all the necessary tools to improve the website search engine optimation.
Tasks

[x] Read the following resources:

https://snipcart.com/blog/react-seo-nextjs-tutorial
https://snipcart.com/spa-seo
https://blog.logrocket.com/5-tricks-to-eliminate-render-blocking-resources/

[x] Install and setup https://github.com/garmeeh/next-seo

[ ] Serve fonts locally using woff and woff2 formats. https://google-webfonts-helper.herokuapp.com/fonts

[x] Define open graph tags to increase social shareability of content.

[x] Sitemap to help bots to index the website.

[x] robots.txt to tell the search engines which pages or files the crawler can or can't request from your site.

To serve fonts locally, you need to use compressed formats like woff or woff2.
This tool https://google-webfonts-helper.herokuapp.com/fonts help to get the fonts and generate the font-face


[Feature] Ability to hide a specific GPU

Description of the feature
I would like to hide a specific GPU and only show my Nvidia P4 card and not the others. Correct me if I am mistaken and this is already an option that I missed. It would also be nice to be able to set the order of which card appears first in the UI.
Additional context
No response

I'd like to hide this

and just show this one without having to arrow over

Hi, this should definitely be a feature - can you please send me the output of:
docker exec CONTAINER yarn cli raw-data --gpu

yarn cli raw-data --gpu

Output:
const gpuInfo =  {
  controllers: [
    {
      vendor: 'ASPEED Technology, Inc.',
      subVendor: '',
      model: 'ASPEED Graphics Family',
      bus: 'Onboard',
      busAddress: '02:00.0',
      vram: 128,
      vramDynamic: false,
      pciID: ''
    },
    {
      vendor: 'NVIDIA Corporation',
      model: 'GP104GL [Tesla P4]',
      bus: 'Onboard',
      busAddress: '18:00.0',
      vram: 7680,
      vramDynamic: false,
      subVendor: 'NVIDIA Corporation',
      driverVersion: '545.23.08',
      subDeviceId: '0x11D810DE',
      name: 'Tesla P4',
      pciBus: '00000000:18:00.0',
      memoryTotal: 7680,
      memoryFree: 7606,
      temperatureGpu: 32,
      powerDraw: 6.78,
      powerLimit: 75,
      clockCore: 455,
      clockMemory: 405
    }
  ],
  displays: []
}

I also would love to see this added! My Proxmox VM's virtual gpu (?) is displayed before the passed through P4000

const gpuInfo =  {
  controllers: [
    {
      vendor: '',
      subVendor: '',
      model: '',
      bus: '',
      busAddress: '00:02.0',
      vram: 4,
      vramDynamic: false,
      pciID: ''
    },
    {
      vendor: 'NVIDIA Corporation',
      model: 'GP104GL [Quadro P4000]',
      bus: 'Onboard',
      busAddress: '00:10.0',
      vram: 8192,
      vramDynamic: false,
      subVendor: 'Hewlett-Packard Company',
      driverVersion: '545.29.02',
      subDeviceId: '0x11A3103C',
      name: 'Quadro P4000',
      pciBus: '00000000:00:10.0',
      fanSpeed: 50,
      memoryTotal: 8192,
      memoryUsed: 2,
      memoryFree: 8111,
      temperatureGpu: 43,
      powerDraw: 6.91,
      powerLimit: 105,
      clockCore: 139,
      clockMemory: 405
    }
  ],
  displays: []
}

My compose file:
version: '3'
services:
  dashdot:
    image: ghcr.io/mauricenino/dashdot:nvidia-5.8.3
    ports:
      - $PORT:3001
    volumes:
      - /:/mnt/host:ro
    privileged: true
    deploy:
      resources:
        reservations:
          devices:
            - capabilities:
                - gpu
    environment:
      - DASHDOT_SHOW_HOST=$DASHDOT_SHOW_HOST                                #true/false
      - DASHDOT_ENABLE_CPU_TEMPS=$DASHDOT_ENABLE_CPU_TEMPS                  #true/false
      - DASHDOT_ALWAYS_SHOW_PERCENTAGES=$DASHDOT_ALWAYS_SHOW_PERCENTAGES    #true/false
      - DASHDOT_ACCEPT_OOKLA_EULA=$DASHDOT_ACCEPT_OOKLA_EULA                #true/false
      - DASHDOT_CUSTOM_HOST=$DASHDOT_CUSTOM_HOST                            #String
      - DASHDOT_WIDGET_LIST=$DASHDOT_WIDGET_LIST                            #refer to https://getdashdot.com/docs/config/ui-features#dashdot_widget_list

Hello, dear MauriceNino,
I have a similar need. My Dashdot is running inside a Docker container with an NVIDIA environment. Dashdot is working very well and has detected my Tesla P4 and its associated data. However, for some reason, when using the API call /load/gpu, the GPU list is: {"layout":[{"load":0,"memory":0},{"load":95,"memory":61}]}, which places an empty GPU before my Tesla P4. A small feature to switch the GPU reporting order or the filter functionality you mentioned in  issue #290 be sufficient for me.
Below is the output of running yarn cli raw-data --gpu inside the Docker container. I would be very grateful for any assistance you can provide.
const gpuInfo =  {   controllers: [     {       vendor: '',       subVendor: '',       model: '',       bus: '',       busAddress: '00:01.0',       vram: 4,       vramDynamic: false,       pciID: ''     },     {       vendor: 'NVIDIA Corporation',       model: 'GP104GL [Tesla P4]',       bus: 'Onboard',       busAddress: '01:00.0',       vram: 8192,       vramDynamic: false,       subVendor: 'NVIDIA Corporation',       driverVersion: '535.161.08',       subDeviceId: '0x120710DE',       name: 'GRID P4-8Q',       pciBus: '00000000:01:00.0',       memoryTotal: 8192,       memoryUsed: 1210,       memoryFree: 6325,       clockCore: 885,       clockMemory: 2999     }   ],   displays: [] }


refactor: simplifying and de-globalization of GetMasternodePayment and GetBlockSubsidy

Issue being fixed or feature implemented
Functions GetMasternodePayment, GetBlockSubsidy and related methods have too many flags and arguments especially after https://github.com/dashpay/dash/pull/5611
This PR simplifies interfaces and reduce usages of global variables such as ::ActiveChain().Tip()
What was done?

change flag fSuperblockPartOnly to a new function GetSuperblockSubsidyInner
get rid usage of global ::ChainstateActive() and ::ChainActive() from block_reward_reallocation_tests.cpp
removing usage of ::ChainActive::Tip() form masternode/payments
proper BIP9 bury of BRR - follow-up "Harden BRR activation (#4726)"

How Has This Been Tested?
Run unit/functional tests
Breaking Changes
N/A
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone

Nice cleanup! 👍 Will try reindexing to double-check.


0.17 rc

Can we please track 0.17 rc issues here so I can also do some testing on my end?
I'd like to test RubyDNS with 0.17 rc so I know that everything is still working on my end. I'm sure that I'm not the only one (e.g. sidekiq).
Alternatively if there is a better way to do this feel free to suggest or improve :)

@digitalextremist keeps things well organized AFAIK - https://github.com/celluloid/celluloid/milestones/0.17.0
For keeping track of production-related changes, just do a git diff on the lib dir - very few changes to review (which makes 0.17 less likely to have issues).

Okay the milestone makes sense but I guess when the time comes to test the rc where will it be announced?

@ioquatix - good point. Probably best to change this issue's title to "Announce 0.17 pre/rc" or something.

The changelog will be broadcast on Google groups as usual, when pre1 is cut and testable ( with the milestone of closed issues there too ) ... only once tested at pre1 for a while will the actual release go live. Generally it's also announced on Twitter, in IRC, I even post status updates to LinkedIn and share that with known contributors and dependents. This won't be sudden, undocumented, and quiet :)

I'm subscribed to that group but I don't get notifications.. perhaps it would be good to have something here?


Bug: merged and unlabeled PRs don't change with date filter

Describe the bug
On the explore page, if you change the date range, the Merged and Unlabeled PR fields don't change.
Steps to reproduce

Go here: https://app.opensauced.pizza/ai/dashboard/filter/recent?range=90
Change the date range
See the last two cards not changing.

https://github.com/open-sauced/app/assets/34313413/9bed7da6-ab31-432c-81c2-f91edffa66f8
Browsers
No response
Additional context (Is this in dev or production?)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

Hi @BekahHW, I took a brief look into this and noticed that the app hits an api endpoint that only returns insights from the past 2 months. So this issue might also be related to the api.
The endpoint is /prs/insights, if you take a look in this file from the api repo you'll notice that it always requests insights from the interval [30, 60].
I'll be happy to work on this once it's out of triage.

Any updates on this?

@mathbraga it's all you if you are still interested?

FYI - this will likely get squashed by work done in the v2 API changeover (reference: #2507) Let's keep this issue open and see how the new v2 handles this

@BekahHW I'm still interested but I don't have the time right now unfortunately. So it's best to just leave this unnassigned in case someone else wants to take a try. Thank you.


Fix TemplateMails createMail for shops without templates

1. Why is this change necessary?
With the recent changes in the TemplateMail component (https://github.com/shopware/shopware/commit/ed2e80e974470eb3451f1a9afd9d3dd1e34d2c14#diff-e8b4c5662b6e1a932d05d94187a75b70) a theme is added to the mail context that is built from the shop's template. But this theme addition will crash if the given shop has no own template (i.e. it is a language sub shop).
See https://github.com/shopware/shopware/commit/ed2e80e974470eb3451f1a9afd9d3dd1e34d2c14#diff-e8b4c5662b6e1a932d05d94187a75b70R167
2. What does this change do, exactly?
This PR adds checks before adding a theme to the mail context: If the passed shop has no own template, the shop's main shop template is used. If even that shop has no template, no theme is added to the context at all (which was the behavior before https://github.com/shopware/shopware/commit/ed2e80e974470eb3451f1a9afd9d3dd1e34d2c14).
3. Describe each step to reproduce the issue or behaviour.
Create a sub shop that has no own template. Call createMail of the TemplateMail component with this shop as parameter. The mail creation will fail when trying to build the shop theme.
4. Please link to the relevant issues (if any).
None.
5. Which documentation changes (if any) need to be made because of this PR?
None.
6. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-21778
Please use this issue to track the state of your pull request.

thanks for your contribution @hanneswernery :+1: :tada: :blue_heart:


Update Angular

Update to angular 10
https://update.angular.io/#9.1:10.0l3

Waiting for https://github.com/nrwl/nx/issues/3251
and https://github.com/angular/flex-layout/issues/1280


Update Prereqs for Fabric users

Signed-off-by: pama-ibm<EMAIL_ADDRESS>Per Matt Sykes request, clarify that the list of prereqs in this Getting started topic is for Fabric users and not Fabric developers. I provided a link to the Fabric developers topic.
Type of change

Documentation update

Description

[x]  Remove node.js and python info from core Fabric prereq doc section

[x] Remove GOPATH requirement to developers contributing guide.

[x] In the Windows extras section, remove the language around developing Fabric and 'make', and instead in the developer contribution guide mention that the same Windows guidance would apply.

[x] Remove node.js and python info. Guidance should be in the API docs and git repos for the chaincode and client SDKs.  Improvements can be made there. There are sections for both Chaincode and Client SDKs in the Getting Started- these could be good places to add pre-reqs for the development.

Additional details

hey @pamandrejko The writing your first application tutorial and the commercial paper. Both use Node.js. If we remove Node from the prerequisites, should we update those tutorials to include the prerequisites, perhaps by linking out to the API docs

hey @pamandrejko The writing your first application tutorial and the commercial paper both use Node.js. If we remove Node from the prerequisites, should we update those tutorials to include the prerequisites, perhaps by linking out to the API docs

Good catch. The commercial paper tutorial already included that. I added it to the writing your first application tutorial.

The prereqs for the commercial paper tutorial are here: https://hyperledger-fabric.readthedocs.io/en/latest/tutorial/commercial_paper.html#prerequisites
I actually like what you put on the writing your first application tutorial better, and it would be good to have them be consistent. I also think we can remove docker since that is in the Fabric prereqs

@mbwhite is adding the prereqs to the Node SDKs and then I will update the prereqs with links to that content.

This looks good to me. However, I am still skeptical about the requirement for Xcode for the writing your first app tutorial. If it is not required for the commercial paper tutorial. The tutorials have different levels of complexity, but the same app invoking smart contract functionality.

I am still skeptical about the requirement for Xcode for the writing your first app tutorial.

You're probably right. The only Xcode requirement we really have in fabric is for the command line tools. These are needed to support pkcs11. I'll try to verify that at some point in the very near future.

Per Nik's comment about the xcode prereq for macOS in the Writing your first app tutorial. I ran the tutorial from a Mac that did not have xcode installed. It ran successfully after I
-- installed homebrew
-- brew install node
-- npm install
So per all the requests around this one I've added instructions now for macOS, Windows  and Linux (per Matthew and Andy).

@sykesm I followed up with Matthew White on your questions:
Docker Desktop is the latest version, however I would still mention Docker Toolbox as there are some cases when you can't use Docker Desktop. For example if you have Windows 10 Home, Can't enable Hyper-V on you machine, or run other virtualization software.
Really not quite sure what binaries means either... I'm guessing the peer commands?

@Mergifyio backport release-2.1

@sykesm I followed up with Matthew White on your questions:
Docker Desktop is the latest version, however I would still mention Docker Toolbox as there are some cases when you can't use Docker Desktop. For example if you have Windows 10 Home, Can't enable Hyper-V on you machine, or run other virtualization software.
Really not quite sure what binaries means either... I'm guessing the peer commands?

Right, While Windows 10 Home is an issue, I'll mention later this month this issue goes away. When WSL2 is released in the next couple days, Docker Desktop is now compatible with W10 Home Edition. So we will need to update the doc then.


Update go-oidc to include changes to client and provider metadata

Update go-oidc to include coreos/go-oidc#38.
This PR provides the necessary changes to field names, changes to types, and adds a database migration to accommodate the changes in JSON marshaling for oidc.ClientMetadata.

Retracting due to coreos/go-oidc#42


SIGILL on OSX when using io.netty:netty-tcnative-boringssl-static:1.1.33.Fork26

Actual behavior
We got a SIGILL while using a client (Google Cloud Spanner Client) that depends on io.netty:netty-tcnative-boringssl-static:1.1.33.Fork26 . SIGILL seems to come from the native tcnative library.
Here is the error report and the stack trace of the relevant thread:
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGILL (0x4) at pc=0x000000011b9f5ec0, pid=1869, tid=0x0000000000007903
#
# JRE version: Java(TM) SE Runtime Environment (8.0_101-b13) (build 1.8.0_101-b13)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (25.101-b13 mixed mode bsd-amd64 compressed oops)
# Problematic frame:
# C  [libnetty-tcnative-osx-x86_641800715405814754196.dylib+0xeeec0]  CRYPTO_memcmp+0xb0

Stack: [0x000070000273a000,0x000070000283a000],  sp=0x00007000028387f0,  free space=1017k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
C  [libnetty-tcnative-osx-x86_641800715405814754196.dylib+0xeeec0]  CRYPTO_memcmp+0xb0
C  [libnetty-tcnative-osx-x86_641800715405814754196.dylib+0x77ee2]  X25519+0x22
C  [libnetty-tcnative-osx-x86_641800715405814754196.dylib+0x28182]  ssl_x25519_accept+0xb2
C  [libnetty-tcnative-osx-x86_641800715405814754196.dylib+0x17f40]  ssl3_connect+0xec0
C  [libnetty-tcnative-osx-x86_641800715405814754196.dylib+0x2a520]  ssl_read_impl+0x80
j  org.apache.tomcat.jni.SSL.readFromSSL(JJI)I+0
j  io.netty.handler.ssl.ReferenceCountedOpenSslEngine.readPlaintextData(Ljava/nio/ByteBuffer;)I+37
j  io.netty.handler.ssl.ReferenceCountedOpenSslEngine.unwrap([Ljava/nio/ByteBuffer;II[Ljava/nio/ByteBuffer;II)Ljavax/net/ssl/SSLEngineResult;+732
j  io.netty.handler.ssl.ReferenceCountedOpenSslEngine.unwrap([Ljava/nio/ByteBuffer;[Ljava/nio/ByteBuffer;)Ljavax/net/ssl/SSLEngineResult;+9
j  io.netty.handler.ssl.SslHandler$SslEngineType$1.unwrap(Lio/netty/handler/ssl/SslHandler;Lio/netty/buffer/ByteBuf;IILio/netty/buffer/ByteBuf;)Ljavax/net/ssl/SSLEngineResult;+59
j  io.netty.handler.ssl.SslHandler.unwrap(Lio/netty/channel/ChannelHandlerContext;Lio/netty/buffer/ByteBuf;II)Z+38
j  io.netty.handler.ssl.SslHandler.decode(Lio/netty/channel/ChannelHandlerContext;Lio/netty/buffer/ByteBuf;Ljava/util/List;)V+194
j  io.netty.handler.codec.ByteToMessageDecoder.callDecode(Lio/netty/channel/ChannelHandlerContext;Lio/netty/buffer/ByteBuf;Ljava/util/List;)V+58
j  io.netty.handler.codec.ByteToMessageDecoder.channelRead(Lio/netty/channel/ChannelHandlerContext;Ljava/lang/Object;)V+81
j  io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(Ljava/lang/Object;)V+16
j  io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(Lio/netty/channel/AbstractChannelHandlerContext;Ljava/lang/Object;)V+31
j  io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(Ljava/lang/Object;)Lio/netty/channel/ChannelHandlerContext;+5
j  io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(Lio/netty/channel/ChannelHandlerContext;Ljava/lang/Object;)V+2
j  io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(Ljava/lang/Object;)V+16
j  io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(Lio/netty/channel/AbstractChannelHandlerContext;Ljava/lang/Object;)V+31
j  io.netty.channel.DefaultChannelPipeline.fireChannelRead(Ljava/lang/Object;)Lio/netty/channel/ChannelPipeline;+5
j  io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read()V+127
j  io.netty.channel.nio.NioEventLoop.processSelectedKey(Ljava/nio/channels/SelectionKey;Lio/netty/channel/nio/AbstractNioChannel;)V+119
j  io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized([Ljava/nio/channels/SelectionKey;)V+38
j  io.netty.channel.nio.NioEventLoop.processSelectedKeys()V+15
j  io.netty.channel.nio.NioEventLoop.run()V+126
j  io.netty.util.concurrent.SingleThreadEventExecutor$5.run()V+44
j  io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run()V+4
j  java.lang.Thread.run()V+11
v  ~StubRoutines::call_stub
V  [libjvm.dylib+0x2ecf06]  JavaCalls::call_helper(JavaValue*, methodHandle*, JavaCallArguments*, Thread*)+0x6ae
V  [libjvm.dylib+0x2ed694]  JavaCalls::call_virtual(JavaValue*, KlassHandle, Symbol*, Symbol*, JavaCallArguments*, Thread*)+0x164
V  [libjvm.dylib+0x2ed840]  JavaCalls::call_virtual(JavaValue*, Handle, KlassHandle, Symbol*, Symbol*, Thread*)+0x4a
V  [libjvm.dylib+0x348029]  thread_entry(JavaThread*, Thread*)+0x7c
V  [libjvm.dylib+0x5695ab]  JavaThread::thread_main_inner()+0x9b
V  [libjvm.dylib+0x56ac98]  JavaThread::run()+0x1c2
V  [libjvm.dylib+0x48933a]  java_start(Thread*)+0xf6
C  [libsystem_pthread.dylib+0x399d]  _pthread_body+0x83
C  [libsystem_pthread.dylib+0x391a]  _pthread_body+0x0
C  [libsystem_pthread.dylib+0x1351]  thread_start+0xd
C  0x0000000000000000

To me this seems like an incorrect version of the native library is somehow being used. We looked at the maven dependencies of our project and we are only including one version of tcnative.
Netty version
4.1.8 Final
JVM version (e.g. java -version)
JRE version: Java(TM) SE Runtime Environment (8.0_101-b13) (build 1.8.0_101-b13)
Java VM: Java HotSpot(TM) 64-Bit Server VM (25.101-b13 mixed mode bsd-amd64 compressed oops)
OS version (e.g. uname -a)
OSX

hmmm... Seems like it "dies" in CRYPTO_memcmp+0xb0  which comes from boringssl. @davidben any idea ?

 CRYPTO_memcmp isn't written in assembly or anything, but maybe the compiler did something.
You all produce precompiled things right? How would I get a copy of libnetty-tcnative-osx-x86_641800715405814754196.dylib to see what instructions are at those addresses? (Sorry, I am totally unfamiliar with how Java things are distributed.)

@davidben just unpack http://repo1.maven.org/maven2/io/netty/netty-tcnative-boringssl-static/2.0.1.Final/netty-tcnative-boringssl-static-2.0.1.Final.jar . you will find these in the "META-INF/native folder

Thanks! http://repo1.maven.org/maven2/io/netty/netty-tcnative-boringssl-static/1.1.33.Fork26/netty-tcnative-boringssl-static-1.1.33.Fork26-osx-x86_64.jar but yeah, that matches the stack trace.
Looks like the compiler is actually vectorizing that loop and sticking a pmovzxbd instruction in there. Huh. If you're getting a SIGILL, I'm guessing netty-tcnative-boringssl-static-1.1.33.Fork26-osx-x86_64.jar was built targeting newer hardware than you have? That's an SSE 4.1 instruction.
@vkedia What hardware are you running this on? This page lists when SSE 4.1 was added to Macs.
https://en.wikipedia.org/wiki/List_of_Macintosh_models_grouped_by_CPU_type#Penryn
@normanmaurer Do you know how that file was built? The compiler seems to have been told that SSE 4.1 is fair game. Dunno if that was intentional.

Ah, looks like clang (on a Mac at least) will just assume SSE 4.1 is available by default.

Reporter states OSX which seems not up-to-date with current macOS Sierra, and macOS Sierra requires SSE 4.1.

Thanks for looking into this. I will find out what hardware was this.

Do you know if there is a way to check on the machine, if SSE 4.1 is available?

@jprante @davidben ^^

By typing the command

sysctl machdep.cpu.features

Macs will return the CPU flags and will print if SSE4.1 is supported.  Thanks!


Unable to update mocha to 8.3.1: fsevents@patch - Cannot apply hunk #1

Prerequisites

[x] Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
[x] Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
[x] 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
[x] Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend that you not install Mocha globally.

Description
I'm trying to update mocha from version 8.2.1 to 8.3.1. Mocha is installed as dev dependency.
Steps to Reproduce
Set version 8.3.1 in package.json and run yarn or use upgrade-interactive or use yarn add mocha --dev.
Expected behavior:
Mocha 8.3.1 should be installed.
Actual behavior: [What actually happens]
Error occurred:
➤ YN0066: │ fsevents@patch:fsevents@npm%3A2.3.2#builtin<compat/fsevents>::version=2.3.2&hash=127e8e: Cannot apply hunk #1 (set enableInlineHunks for details)

Versions

The output of mocha --version and node node_modules/.bin/mocha --version: 8.2.1
The output of node --version:  12.18.3
Your operating system

name and version: Windows 10
architecture (32 or 64-bit): 64-bit

Your shell (e.g., bash, zsh, PowerShell, cmd): Powershell
Your browser and version (if running browser tests): -
Any third-party Mocha-related modules (and their versions): yarn 2.3.3.
Any code transpiler (e.g., TypeScript, CoffeeScript, Babel) being used (and its version): -

I searched for this error and found many issues from 2020, but all of them were resolved somehow. So not sure why it occurred for me especially on Windows.

@juergba you might be right about optional. It looks like the chain is: mocha requires chokidar and chokidar requires fsevents, but optionally.
I have no idea why yarn 2 tries to install optional dependency and flag --ignore-optional does not work as per this issue.
I'll raise another issue for yarn team.
Thanks.

Update: it was a yarn issue. It looks like issue was fixed in yarn 2.4.1. We updated yarn to 2.4.0 - issue was in place, but after ipdating yarn to 2.4.1 everything is fine.
Hope this will help someone.


Add ioDirectory override to the yaml file

I'm using an external rust repo which uses workspaces for its project layout. Running flutter_rust_bridge_codegen generate works well except for a portion of frb_generated.dart:
  static const kDefaultExternalLibraryLoaderConfig = ExternalLibraryLoaderConfig(
    stem: 'libsometool',
    ioDirectory: '../../sometool/src/workspace_a/target/release/',
    webPrefix: 'pkg/',
  );

the generated ioDirectory is assumed to be the target/release folder underneath the frb project, but because its a workspace project, the output is at the project root: sometool/target/release.
It'd be nice to have a way of specifying the ioDirectory wthout manually rewriting it every time it is generated.

To customize it, the simplest way is to use https://cjycode.com/flutter_rust_bridge/guides/how-to/load-library and set the ExternalLibraryLoaderConfig.ioDirectory when loading it.
However, feel free to PR to enhance the auto detection to find the correct release dir!

I'll look into seeing if I can extend the auto detection.
With respect to workspace dirs, the documentation here suggests that target will never be in any other location:

The workspace has one target directory at the top level that the compiled artifacts will be placed into; the adder package doesn’t have its own target directory. Even if we were to run cargo build from inside the adder directory, the compiled artifacts would still end up in add/target rather than add/adder/target. Cargo structures the target directory in a workspace like this because the crates in a workspace are meant to depend on each other. If each crate had its own target directory, each crate would have to recompile each of the other crates in the workspace to place the artifacts in its own target directory. By sharing one target directory, the crates can avoid unnecessary rebuilding.

Looks great - then we only need to extract "what is the workspace dir" from cargo metadata and done.


Migrate to GitHub Actions

Move from Circle CI to GitHub Actions for consistency.

Closed in favor of #206


Error when saving messages into datasore(models).

I followed the documentation and when i added models to save messages .
def msg_consumer(message):
  # Save to model
room = message.content['room']
   ChatMessage.objects.create(
      room=room,
      message=message.content['message'],
)
  # Broadcast to listening sockets
  Group("chat-%s" % room).send({
     "text": message.content['message'],
  })
@channel_session
def ws_message(message):
 # Stick the message onto the processing queue
 Channel("chat-messages").send({
 "room": channel_session['room'],
   "message": message['text'],
 })
then i am getting this error ,
error-  "room": channel_session['room'],
TypeError: 'function' object has no attribute 'getitem'
but when i change the code to this , its working now.
def msg_consumer(message):
  # Save to model
 room = message.content['room']
  ChatMessage.objects.create(
   room=room,
  message=message.content['message'],
 )
 # Broadcast to listening sockets
  Group("chat-%s" % room).send({
  "text": message.content['message'],
})
@channel_session
def ws_message(message):
 # Stick the message onto the processing queue
 Channel("chat-messages").send({
"room": message.channel_session['room'],
   "message": message['text'],
 })

Is this a typo in docs or am  i missing something?

Stick some back-ticks around that code -- it's not valid Python the way it is.

(https://cloud.githubusercontent.com/assets/6693374/17600078/95b72e72-601f-11e6-9bd0-3c0a7aab3984.png)

(https://cloud.githubusercontent.com/assets/6693374/17600124/c1885c4c-601f-11e6-994f-2712747b6491.png)

You need to refer to it as message.channel_session, not channel_session like you are, which is the decorator object.


Feedback

[Enter feedback here]

Document details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 516a8fed-04ea-628c-d644-eb81dedecfe6
Version Independent ID: 060c37e4-36e1-48b3-2435-cf858b14d860
Content: Data collections - Introduction to C# interactive tutorial
Content Source: docs/csharp/tour-of-csharp/tutorials/list-collection.yml
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Hi @jaenDeyPlaidne
Do you have further comments here? I'm going to close this, but if you have further comments, you can open a new issue, or add comments here and reopen the issue.

#22784


Add API and CLI for deleting named NetworkFileSystem objects

This was a feature gap exacerbated by the recent move away from "single-object apps".
Fixes CLI-283
Changelog

It is now possible to delete named NetworkFileSystem objects via the CLI (modal nfs delete ...) or API (modal.NetworkFileSystem.delete(...))

@prbot approve


fixes assertion disabling for LuceneTestCase childs

LuceneTestCase.TEST_ASSERTS_ENABLED defaults to true
which raises an exception if global assertions are disabled

ack


[mirror] Add new extractor

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[x] New extractor
[ ] New feature

Description of your pull request and other information
Add support to mirror.co.uk requested on issue #13340

Updated

Updated

@dstftw i made the requested changes


Add EvaluationTimeoutSample projects and readme file

We are adding tutorials for Custom Managed Debugger Visualizers here and customers wanted to be able to download the projects for which we show code snippets. Hence, we are putting them here so that they have easy access to them.

Is there a reason you're not using <PackageReference> but uses the old nuget.config files?

@madskristensen there is no reason, I assume it must have been default behavior from VS since they are .NET Framework projects.

It would be nice to have these sample follow as many modern and best practices as possible. That includes using PackageReference. I recommend you change it, but it's not a strict rule and we can publish without it. Let me know what you want to do

The WPF project cannot be SDK styled unless we upgrade the version of VS used to build the projects to be at least VS 2019.
https://github.com/microsoft/VSSDK-Extensibility-Samples/blob/2a2f9282360028d9ab761c6c37ee2ac4320ebd57/appveyor.yml#L2
Related: https://github.com/dotnet/installer/issues/213

@madskristensen I think it is ready for check-in :)

Thanks


Change how we comment the license.

LGTM. Does START_EXCLUDE not work at all or is it that it shows ...?
For ... issue, I believe we can use [START_EXCLUDE silent].


Binary reader writer

Cleaned up APIs
Added Try* versions of endinanness-aware reading and writing APIs

cc: @joshfree, @ahsonkhan, @shiftylogic

tagging the new @dotnet/corefxlab-contrib alias (mostly as a test)


[3957] Add dynamic funding guidance link

Ensure that the link to funding guidance is for the correct year relevant to the trainee
Context
Prior to this PR the funding guidance link only went to the 2021/22 funding guidance. Now this link will go to the relevant years funding guidance based on the trainees ITT start date.

 [S] Link to correct academic year's funding guidance depending on the funding year


static_framework.mk: No such file or directory

Hello
I just cloned the repo and tried to 'make dist' it but it failed with the following message
"Makefile:1380: ../make/static_framework.mk: No such file or directory
make[1]: *** No rule to make target `../make/static_framework.mk'.  Stop.
make: *** [jre_emul_jar_dist] Error 2"
(I checked the make folder and couldn't find the static_framework.mk file.)
Thanks for your help

Fixed in latest source.


iOS app crash on FBLPromise observeOnQueue:fulfill:reject:

Description
We observe over 4700 crashes of this type in our Firebase Crashlytics.
iOS environment:
71% iOS 17
23% iOS 16
5% iOS 15
Stack trace examples and keys are below.
Example 1:

Crashed: com.google.perf.FPREventsQueue
0  libsystem_kernel.dylib         0xa974 __pthread_kill + 8
1  libsystem_pthread.dylib        0x60ec pthread_kill + 268
2  libsystem_c.dylib              0x75b80 abort + 180
3  libsystem_malloc.dylib         0x2bc68 malloc_vreport + 896
4  libsystem_malloc.dylib         0x2bf10 malloc_zone_error + 104
5  libsystem_malloc.dylib         0x21a44 nanov2_guard_corruption_detected + 44
6  libsystem_malloc.dylib         0x7f84 nanov2_find_block_and_allocate + 402
7  libobjc.A.dylib                0x2ab7c class_createInstance + 72
8  CoreFoundation                 0x2129c __CFAllocateObject + 20
9  CoreFoundation                 0x21180 __NSArrayM_new + 60
10 CSOB                           0x45e5520 -[FBLPromise observeOnQueue:fulfill:reject:] +<PHONE_NUMBER>
11 CSOB                           0x45e5a24 -[FBLPromise chainOnQueue:chainedFulfill:chainedReject:] +<PHONE_NUMBER>
12 CSOB                           0x45e78f0 -[FBLPromise(CatchAdditions) onQueue:catch:] +<PHONE_NUMBER>
13 CSOB                           0x45e7850 -[FBLPromise(CatchAdditions) catch:] +<PHONE_NUMBER>
14 CSOB                           0x460ed9c -[FIRInstallationsSingleOperationPromiseCache getExistingPendingOrCreateNewPromise] +<PHONE_NUMBER>
15 CSOB                           0x460aa00 -[FIRInstallationsIDController getInstallationItem] +<PHONE_NUMBER>
16 CSOB                           0x46069b0 -[FIRInstallations installationIDWithCompletion:] +<PHONE_NUMBER>
17 CSOB                           0x4740b84 -[FPRClient processAndLogEvent:] +<PHONE_NUMBER>
18 CSOB                           0x47407ec __29-[FPRClient logNetworkTrace:]_block_invoke +<PHONE_NUMBER>
19 libdispatch.dylib              0x213c _dispatch_call_block_and_release + 32
20 libdispatch.dylib              0x3dd4 _dispatch_client_callout + 20
21 libdispatch.dylib              0xb4d0 _dispatch_lane_serial_drain + 956
22 libdispatch.dylib              0xbf30 _dispatch_lane_invoke + 380
23 libdispatch.dylib              0x16cb4 _dispatch_root_queue_drain_deferred_wlh + 288
24 libdispatch.dylib              0x16528 _dispatch_workloop_worker_thread + 404
25 libsystem_pthread.dylib        0x1f20 _pthread_wqthread + 288
26 libsystem_pthread.dylib        0x1fc0 start_wqthread + 8

crash_info_entry_0 | abort() called
crash_info_entry_1 | CSOB(37744,0x16b78b000) malloc: Heap corruption detected, free list is damaged at 0x301a240f0 *** Incorrect guard value:<PHONE_NUMBER>

Example 2:

Crashed: com.google.iid-token-operations (QOS: UTILITY)
0  libsystem_kernel.dylib         0xa974 __pthread_kill + 8
1  libsystem_pthread.dylib        0x60ec pthread_kill + 268
2  libsystem_c.dylib              0x75b80 abort + 180
3  libsystem_malloc.dylib         0x2bc68 malloc_vreport + 896
4  libsystem_malloc.dylib         0x2bf10 malloc_zone_error + 104
5  libsystem_malloc.dylib         0x21a44 nanov2_guard_corruption_detected + 44
6  libsystem_malloc.dylib         0x7f84 nanov2_find_block_and_allocate + 402
7  libobjc.A.dylib                0x2ab7c class_createInstance + 72
8  CoreFoundation                 0x2129c __CFAllocateObject + 20
9  CoreFoundation                 0x21180 __NSArrayM_new + 60
10 CSOB                           0x45e5520 -[FBLPromise observeOnQueue:fulfill:reject:] +<PHONE_NUMBER>
11 CSOB                           0x45e5a24 -[FBLPromise chainOnQueue:chainedFulfill:chainedReject:] +<PHONE_NUMBER>
12 CSOB                           0x45e91b4 -[FBLPromise(ThenAdditions) then:] +<PHONE_NUMBER>
13 CSOB                           0x460f210 -[FIRInstallationsStore installationForAppID:appName:] +<PHONE_NUMBER>
14 CSOB                           0x460ac10 -[FIRInstallationsIDController getStoredInstallation] +<PHONE_NUMBER>
15 CSOB                           0x460aa9c -[FIRInstallationsIDController createGetInstallationItemPromise] +<PHONE_NUMBER>
16 CSOB                           0x460a8f4 __131-[FIRInstallationsIDController initWithGoogleAppID:appName:installationsStore:APIService:IIDStore:IIDTokenStore:backoffController:]_block_invoke +<PHONE_NUMBER>
17 CSOB                           0x460eccc -[FIRInstallationsSingleOperationPromiseCache getExistingPendingOrCreateNewPromise] +<PHONE_NUMBER>
18 CSOB                           0x460aa00 -[FIRInstallationsIDController getInstallationItem] +<PHONE_NUMBER>
19 CSOB                           0x460b984 -[FIRInstallationsIDController installationWithValidAuthTokenForcingRefresh:] +<PHONE_NUMBER>
20 CSOB                           0x460a938 __131-[FIRInstallationsIDController initWithGoogleAppID:appName:installationsStore:APIService:IIDStore:IIDTokenStore:backoffController:]_block_invoke.11 +<PHONE_NUMBER>
21 CSOB                           0x460eccc -[FIRInstallationsSingleOperationPromiseCache getExistingPendingOrCreateNewPromise] +<PHONE_NUMBER>
22 CSOB                           0x460b8c0 -[FIRInstallationsIDController getAuthTokenForcingRefresh:] +<PHONE_NUMBER>
23 CSOB                           0x4606bd8 -[FIRInstallations authTokenForcingRefresh:completion:] +<PHONE_NUMBER>
24 CSOB                           0x47344a4 -[FIRMessagingTokenOperation start] +<PHONE_NUMBER>
25 Foundation                     0x7119c NSOPERATIONQUEUE_IS_STARTING_AN_OPERATION + 16
26 Foundation                     0x70f08 __NSOQSchedule_f + 172
27 libdispatch.dylib              0x213c _dispatch_call_block_and_release + 32
28 libdispatch.dylib              0x3dd4 _dispatch_client_callout + 20
29 libdispatch.dylib              0x72d8 _dispatch_continuation_pop + 600
30 libdispatch.dylib              0x68f4 _dispatch_async_redirect_invoke + 584
31 libdispatch.dylib              0x15894 _dispatch_root_queue_drain + 392
32 libdispatch.dylib              0x1609c _dispatch_worker_thread2 + 156
33 libsystem_pthread.dylib        0x1ee4 _pthread_wqthread + 228
34 libsystem_pthread.dylib        0x1fc0 start_wqthread + 8

crash_info_entry_0 | abort() called
crash_info_entry_1 | CSOB(437,0x16b887000) malloc: Heap corruption detected, free list is damaged at 0x303a2dd40 *** Incorrect guard value:<PHONE_NUMBER>
state | SBCSOB:app_start:splashscreen

Reproducing the issue
Happens during a launching an app.
Firebase SDK Version
10.23.0
Xcode Version
15.3
Installation Method
Zip
Firebase Product(s)
Analytics, Crashlytics, Performance
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

Since this issue, along with #12987 and #12988, are relating to heap corruptions, there may be something in the app corrupting the heap.
Does running with Instruments help to isolate the cause?

We are also facing a similar issue that is only happening on Release and Testflight. We were not able to catch it when debugging.
Versions we tried: 10.26.0 10.24.0 10.23.0
Reason: +[NSData %s]: unrecognized selector sent to class 0x1ecba4cd0

Crash:
Triggered by Thread:  5

Last Exception Backtrace:
0   CoreFoundation                	0x197abab28 __exceptionPreprocess + 164 (NSException.m:249)
1   libobjc.A.dylib               	0x18f936f78 objc_exception_throw + 60 (objc-exception.mm:356)
2   CoreFoundation                	0x197b4bd94 +[NSObject(NSObject) doesNotRecognizeSelector:] + 344 (NSObject.m:151)
3   CoreFoundation                	0x197a00300 ___forwarding___ + 1572 (NSForwarding.m:3612)
4   CoreFoundation                	0x197b41760 _CF_forwarding_prep_0 + 96 (:-1)
5   AppCore                 	        0x10302de34 Data.zipped() + 112
6   AppCore                 	      0x10302d730 Data.zipped() + 40
7   AppCore                 	      0x10302d3b8 HeartbeatsPayload.headerValue() + 288
8   AppCore                 	      0x103030ffc @objc _ObjC_HeartbeatsPayload.headerValue() + 52
9   AppCore                 	      0x10301fc74 FIRHeaderValueFromHeartbeatsPayload + 44
10  AppCore                 	      0x10305eec4 __96-[FIRInstallationsAPIService requestWithURL:HTTPMethod:bodyDict:refreshToken:additionalHeaders:]_block_invoke + 380
11  AppCore                 	0x102fe4efc __38+[FBLPromise(DoAdditions) onQueue:do:]_block_invoke + 40
12  libdispatch.dylib             	0x19f8c913c _dispatch_call_block_and_release + 32 (init.c:1530)
13  libdispatch.dylib             	0x19f8cadd4 _dispatch_client_callout + 20 (object.m:576)
14  libdispatch.dylib             	0x19f8dcaf4 _dispatch_root_queue_drain + 1000 (queue.c:7136)
15  libdispatch.dylib             	0x19f8dd09c _dispatch_worker_thread2 + 156 (queue.c:7204)
16  libsystem_pthread.dylib       	0x1f39b8ee4 _pthread_wqthread + 228 (pthread.c:2678)
17  libsystem_pthread.dylib       	0x1f39b8fc0 start_wqthread + 8 (:-1)

Please confirm you've followed all of the zip instructions in the README including: Add the -ObjC flag to Other Linker Settings.

Hello Paul,
thank you for the response. This issue happens to a small percentage of unlucky users, it's difficult to simulate same situation and find a cause. Seems line it happens during a launch time or when an app is going foreground. I don't know much more at the moment. Please let me know if you need something more to solve this issue. I can share more crash reports for example.
I can confirm that we have -ObjC flag in linker settings.

Can you confirm that you're building the Promises library from the latest Firebase distribution and not an older one?

Have the same issue with firebase sdk version 10.24

Our project is using 10.23.0. I'll manage to update to the latest version.

I updated our project to use version 10.29.0. Closing this issue now and we will observe following Crashlytics logs if it helps or not. Thank you for your time and help @paulb777


Edit of aggregated_by docs

This is a proposed fix in respect of https://github.com/SciTools/iris/issues/1758
The behaviour of aggregated_by has been tested, and it doesn't affect the results whether the identical values are consecutive or otherwise. So, I propose to remove the "Todo..." line.

Thanks for testing this! :+1:

... and after an unexpectedly-long trip down the version control rabbit-hole, here is the updated documentation.

Thanks @davidnmurray. :+1: I hate to have to ask, but would you mind squashing your commits?

would you mind squashing your commits?

@SciTools/iris-devs - for simple cases such as this, perhaps we should consider enabling the squash and merge option?

Squashing is done.

Super - thanks @davidnmurray :+1:


Updated Routing description and Unwrapping non-optional travelmodes

@singhgag Can you look at these description improvements?
Also included are changes to unwrapping non- optional travel modes.

All changes have been incorporated into another PR.
Closing.


ARROW-12801: [CI][Packaging][Java] Include all modules in script that generate Arrow jars

cc @anthonylouisbsb

The artifacts that were generated by the triggered build are these one https://github.com/ursacomputing/crossbow/releases/tag/actions-443-github-java-jars, right?
The gandiva, dataset and orc components are with the shared libraries for both systems(Linux and MacOS). It looks fine!

The artifacts that were generated by the triggered build are these one https://github.com/ursacomputing/crossbow/releases/tag/actions-443-github-java-jars, right?

Right!

The gandiva, dataset and orc components are with the shared libraries for both systems(Linux and MacOS). It looks fine!

Thanks for verifying!

@kszucs We have missing files to release: https://issues.apache.org/jira/browse/ARROW-12801?focusedCommentId=17352249&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17352249
Do you want to work on including the missing files in this pull request? Or do you want you or @anthonylouisbsb to work on it in a follow-up pull request?

@github-actions crossbow submit java-jars

@github-actions crossbow submit java-jars

@github-actions crossbow submit java-jars

@github-actions crossbow submit java-jars

@github-actions crossbow submit java-jars

@kszucs Thanks for fixing this. Is there anything left to be done in this patch?

We could and probably should list the expected artifacts for the crossbow task so we see if anything is missing during the release process.

@github-actions crossbow submit java-jars

Created a follow-up task: ARROW-13051


Authentication

Hi,
Do you know if it is possible to add authentication on your web site. I'd like to add authentication when VS get the feed, and the VSIX Packages
Alex

It is not, and VS doesn't support that either.


[Concurrency] Limit futures test to x86_64 for now.

We have not yet implemented ptrauth support for the async calling
convention, so this test is crashing on arm64e. Limit it to x86_64
until that comes online.
Fixes rdar://71592154.

@swift-ci please smoke test and merge

@DougGregor - does it make sense to make this // XFAIL: ARCH=arm64e instead?  e.g. this should work on say Linux armv7 right?

@DougGregor - does it make sense to make this // XFAIL: ARCH=arm64e instead? e.g. this should work on say Linux armv7 right?

Yeah, good point. I ended up pulling this (with your change) into https://github.com/apple/swift/pull/34842

@swift-ci please smoke test

Subsumed by #34842


Update review-template.md

Why:
Closes [issue link]

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[ ] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

Adam Harden liked your email

On Sun, 6 Nov 2022 at 9:06 AM venomOZ431 @.***> wrote:
Adam Harden liked your email
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>
-- 90079955

@kandeldeepak46 Thanks for opening this PR! However, we are not going to accept these changes.
Please take a look at our help wanted section to find open issues you can work on.
Thank you for your interest in improving GitHub Docs! :sparkling_heart:

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg


[Button] Expose disableTouchRipple

This PR directly references:
https://github.com/callemall/material-ui/pull/6232

The enhanced button wrapper exposes the option to
disable touch ripples.  This is the case with the FlatButton
component and should be exposed on RaisedButton for consistency.
In addition to exposing the prop, the documentation will be updated
automatically with the newly defined prop from the RaisedButton Component.

Please wait to merge this until the previous PR is merged and this PR is rebased.

@oshalygin Thanks, I have merged this PR and close the other one as RaisedButton & FlatButton are deeply linked. An atomic PR update sounds better.


Some tests?

Feature Request
Well I think it could be nice to have a way to test if our listeners are working, some way to send fake data...

There has been some effort on the testing branch but due to lack of time it was kinda abandoned. Not sure when I can find enough time for it, actually.
Always feel free to contribute via PRs though. :)

If you're still interested in this, for chat, fdgt now exists.

I just used https://github.com/twitchdev/twitch-cli for testing with EventSub events and works nice after some problems how to call the cli for this libary.

With fdgt and Twitch CLI existing, I don't see value in implementing this anymore; thus, I'm closing this issue.


fix: inlay hints maybe a bit delayed if sync init

r.i.p bram.

I don't know why you closed this PR.  I intend to continue to develop and maintain the LSP plugin.

Hope this PR can be merged soon. Without this, my rust-analyzer doesn't until I execute :LspInlayHint enable manually.


Add wavenumber frequency set from e3sm_diags

Add the wavenumber frequency plot to zppy:

[x] Include in e3sm_diags.bash
[x] update data to Chrysalis
[x] update configuration file

I have tested the configuration as follows. Results can be found here:https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.zhang40/E3SMv3_trop_dep/v3.LR.historical_0051/e3sm_diags
[default]
#input = /lcrc/group/e3sm2/ac.golaz/E3SMv3/v3.LR.piControl
input = /lcrc/group/e3sm2/ac.wlin/E3SMv3/v3.LR.historical_0051
output = /lcrc/group/e3sm2/ac.zhang40/E3SMv3/v3.LR.historical_trop_dep
case = v3.LR.historical_0051
www = /lcrc/group/e3sm/public_html/diagnostic_output/ac.zhang40/E3SMv3_trop_dep
partition = compute
#environment_commands = "source /lcrc/soft/climate/e3sm-unified/load_latest_e3sm_unified_chrysalis.sh"
environment_commands = "source /lcrc/soft/climate/e3sm-unified/test_e3sm_unified_1.9.3rc4_chrysalis.sh"
campaign = "water_cycle"

[climo]
active = True
#years = "0001:0100:50", "0001:0100:100"
years = "1985:2014:30"
walltime = "1:00:00"

  [[ atm_monthly_180x360_aave ]]
  input_subdir = "archive/atm/hist"
  mapping_file = /home/ac.zender/data/maps/map_ne30pg2_to_cmip6_180x360_aave.20200201.nc
  frequency = "monthly"

  [[ atm_monthly_diurnal_8xdaily_180x360_aave ]]
  input_subdir = "archive/atm/hist"
  input_files = "eam.h3"
  mapping_file = /home/ac.zender/data/maps/map_ne30pg2_to_cmip6_180x360_aave.20200201.nc
  vars = "PRECT"
  frequency = "diurnal_8xdaily"

[ts]
active = True
years = "1985:2014:30"
walltime = "00:50:00"

  [[ atm_monthly_180x360_aave ]]
  input_subdir = "archive/atm/hist"
  input_files = "eam.h0"
  frequency = "monthly"
  mapping_file = /home/ac.zender/data/maps/map_ne30pg2_to_cmip6_180x360_aave.20200201.nc
  vars = "FSNTOA,FLUT,FSNT,FLNT,FSNS,FLNS,SHFLX,QFLX,TAUX,TAUY,PRECC,PRECL,PRECSC,PRECSL,TS,TREFHT,CLDTOT,CLDHGH,CLDMED,CLDLOW,U,ICEFRAC,LANDFRAC,OCNFRAC,PS"

  [[ atm_daily_180x360_aave ]]
  input_subdir = "archive/atm/hist"
  input_files = "eam.h1"
  frequency = "daily"
  mapping_file = /home/ac.zender/data/maps/map_ne30pg2_to_cmip6_180x360_aave.20200201.nc
  vars = "FLUT,PRECT,U850"
[e3sm_diags]
active = True
walltime = "4:00:00"
#years = "0001:0100:50", "0001:0100:100"
years = "1985:2014:30",
ts_num_years = 30
ref_start_yr = 1979
ref_final_yr = 2016
multiprocessing = True
num_workers = 8

  [[ atm_monthly_180x360_aave ]]
  environment_commands = "source /home/ac.zhang40/y/etc/profile.d/conda.sh; conda activate edv290"
  short_name = 'v3.LR.historical_0051'
  grid = '180x360_aave'
  reference_data_path = '/lcrc/soft/climate/e3sm_diags_data/obs_for_e3sm_diags/climatology'
  obs_ts = '/lcrc/soft/climate/e3sm_diags_data/obs_for_e3sm_diags/time-series'
  dc_obs_climo = '/lcrc/group/e3sm/public_html/e3sm_diags_test_data/unit_test_complete_run/obs/climatology'
  climo_diurnal_subsection = "atm_monthly_diurnal_8xdaily_180x360_aave"
  climo_diurnal_frequency = "diurnal_8xdaily"
  ts_daily_subsection = "atm_daily_180x360_aave"
#  sets="lat_lon","zonal_mean_xy","zonal_mean_2d","polar","cosp_histogram","meridional_mean_2d","annual_cycle_zonal_mean","qbo","diurnal_cycle","zonal_mean_2d_stratosphere","aerosol_budget","tropical_subseasonal",
  sets="tropical_subseasonal",
  output_format_subplot = "pdf",

@forsyth2 The PR is ready to review. For next zppy release, we can include this feature as well as the global time series plot that you are working on.
@golaz and @wlin7. This is a FYI. Note that in the configuration, it includes:   [[ atm_daily_180x360_aave ]] subsection in [ts] taks; and the [e3sm_diags] task is updated accordingly. Right now I'm using my development version of e3sm diags for testing, hopefully, we can have new deployment of e3sm_unified soon to cover the new feature.

@chengzhuzhang Is this ready to merge? Let me know if I should hold off on making a new zppy RC, so we can include this

@chengzhuzhang Is this ready to merge? Let me know if I should hold off on making a new zppy RC, so we can include this

@forsyth2 This is ready to merge. I think I will have another fix for ilamb task in soon.

Sounds good, thanks!


Enhancement Request - Content selection

Would it be possible to control the content menu's (source)

Based on which Expansions you select on the main scenario page:

So if you don't add any expansions the only the base will be White (the rest being red, or grey or whatever), on first select.
If Say RM (and Base) was the only expansions selected then the content for only these two boxes will show as white (and be listed in the right hand window) and the others would be red/grey/whatever.
Since I have all of the expansions personally, I found myself picking tiles by scrolling down the list and getting hit by inspiration (ohh the new library, I could do this and this!). So I end up with tiles of all expansions and limit my scenario's potential player base, when I may have been able to use another tile from another set.
Having an option to hide tiles for a specific expansion by default (but having the option to browse them with a few clicks) will stop me from accidentally picking tokens, monsters and tiles from other expansions, then having to retro fit them later to refine the number of expansions required.

The issue is that this isn't how the selection works.  If both 'base' and 'RN' where white then there would be nothing available because nothing is in base and RN.  For D2E there are cases where there are components in multiple sets, but this isn't what is wanted anyway.  Perhaps first there could be an alternate way of selecting traits that is an exclusion such as:
[X][   RN   ]
And selecting the X will exclude RN?

I first thought this would be simple, but redoing the selection system will take some time, so I'll bump this till later.

Sounds fair.
Just a quick not related question.
Are comments meant to not allow break lines:

Please submit as another issue, will look into it.  Either it is a bug or a feature request, I agree it would be better if it did.


Issue with Toggle In Call Status Bar

When a incoming call toggle status bar then spotlight frame get disturbed.
Spotlight shift to diffrent poistion.

It would be helpful if you could also submit the code for the specific problem. Also, since it has been a while since the issue was submitted, I close this issue once. If there is a problem, please reopen it.


last.fm integration

thank you for creating this app! i love the feature where you can download the songs and stream offline, i dont think its in the jellyfin app yet :p
i know there is a jellyfin plugin that integrates with last.fm, but that is server-side only. is it possible to do it on the client side? because i believe when you stream songs that are downloaded offline, the status isn't sent to the server, correct me if i am wrong 😅

nevermind, i just discovered the playback reporting option, and looks like it is enabled by default :p
still, would it be out of scope to create a client side integration?

Not necessarily, but I would strongly prefer to have Jellyfin as the sole back-end for the application. Is there a reason why the server-side plugin is insufficient?

in some rare cases if playback reporting fail(server is down while streaming locally, or a network issue), client will be able to handle the tracking

@leinelissen FYI

Hey @magandrez, please create a new issue for this. Can you double-check that the listening events are coming in correctly in your admin dashboard? They should be available at https://[JELLYFIN-SERVER-URL]/web/#/dashboard/activity?useractivity=true


Adding advisor recommendations and log analytics integrations

PR Checklist

[ ] Explain your changes, so people looking at the PR know what and why, the code changes are the how.
Updating the SQL UI to have Advisor Recommendations and link to our new Log Analytics Workbooks/Troubleshooting workbooks.

If adding or updating templates:

[ ] post a screenshot of templates and/or gallery changes

[ X ] ensure your template has a corresponding gallery entry in the gallery folder

[ ] If you are adding a new template, add your team and template/gallery file(s) to the CODEOWNERS file. CODEOWNERS entries should be teams, not individuals

[ X ] ensure all steps have meaningful names

[ X ] ensure all parameters and grid columns have display names set so they can be localized

[ X ] ensure that parameters id values are unique or they will fail PR validation (parameter ids are used for localization)

[ X ] ensure that steps names are unique or they will fail PR validation (step names are used for localization)

[ X ] grep /subscription/ and ensure that your parameters don't have any hardcoded resourceIds or they will fail PR validation

[ X ] remove fallbackResourceIds and fromTemplateId fields from your template workbook or they will fail PR validation

I just had some thoughts and I figured it is easier to put it here over marking in the workbook.

What are your thoughts on Adding Service Availability to the main Overview tab. The Availability tab only contains one chart and I think the availability metric itself is a good starting point when looking at Overview/Health of the customer's account.
For multi-region account, having Replication Latency might be a nice to have. It would be super cool if there can be a map with the customers regions and then a way to click and see the latency over time.
429 % would be nice :), we'll see about squeezing that work in
there are a lot of blank panels (with edit button) at the bottom of the workbook, what are those for our of curiosity?
I would move this section on the main overview to the top or the bottom, I think it separates the metrics which may make the customer miss the section at the bottom about Metrics by Collection


C# Prevent type name collisions

By using namespace aliasing
Fixes #1868

Codecov Report

Merging #1903 into master will increase coverage by 0.3%.
The diff coverage is 98.32%.

@@             Coverage Diff             @@
##             master    #1903     +/-   ##
===========================================
+ Coverage     85.37%   85.68%   +0.3%
- Complexity     4747     4761     +14
===========================================
  Files           436      438      +2
  Lines         18692    19141    +449
  Branches       2002     2009      +7
===========================================
+ Hits          15959    16401    +442
- Misses         2037     2041      +4
- Partials        696      699      +3

Impacted Files
Coverage Δ
Complexity Δ

...en/transformer/csharp/CSharpCommonTransformer.java
95% <ø> (ø)
13 <0> (ø)
:arrow_down:

...ansformer/csharp/CSharpGapicClientTransformer.java
95.72% <100%> (ø)
41 <1> (ø)
:arrow_down:

...former/csharp/CSharpGapicSmokeTestTransformer.java
78.82% <100%> (+0.25%)
9 <1> (+1)
:arrow_up:

...i/codegen/transformer/PathTemplateTransformer.java
98.96% <100%> (ø)
35 <0> (ø)
:arrow_down:

...ansformer/csharp/CSharpModelTypeNameConverter.java
93.79% <100%> (ø)
33 <1> (ø)
:arrow_down:

...oogle/api/codegen/util/csharp/CSharpAliasMode.java
100% <100%> (ø)
1 <1> (?)

...sformer/csharp/CSharpGapicUnitTestTransformer.java
89.68% <100%> (+0.08%)
18 <3> (+1)
:arrow_up:

...sformer/csharp/CSharpGapicSnippetsTransformer.java
97.55% <100%> (+0.13%)
39 <3> (+2)
:arrow_up:

...oogle/api/codegen/util/csharp/CSharpTypeTable.java
87.36% <86.95%> (+0.57%)
24 <7> (+8)
:arrow_up:

...codegen/transformer/csharp/CSharpSurfaceNamer.java
91.63% <90%> (+0.08%)
85 <2> (+1)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1442d39...ffe9b96. Read the comment docs.

Issues found generating all clients:

WithCallSettingsOverlay doesn't qualify CallSettings
The Bigtable code generator will need to be altered (easy enough to do; just adding regular using directives is enough)
In Datastore, an optional ByteString value generates Transaction = transaction ?? ByteString.Empty, // Optional; ByteString needs to be qualified. (Ditto in Spanner.)
Logging: IResourceName isn't qualified in the LogSink.DestinationAsResourceName property (in either declaration or comment)

(Currently running unit tests, but that's all that's needed to get it all compiling. Pretty impressively small list of further changes required!)

All issues now fixed.


Add docs on generating ProblemDetails payload

Documentation for https://github.com/dotnet/aspnetcore/issues/4953.

@captainsafia  merge when you're ready.


Tanimoto distance distribution for a dataframe input

I found this function in one of the notebooks, I made few changes and tested it. The function takes in a data frame and computes fingerprints --> Tanimoto distances and plots distance distribution. I think the function will be useful for EDA analysis.

I propose that we merge this into 1.2.0. Otherwise I have no comments.

I agree with Stewart. Ravi, could you close this PR and create a new one to merge it into 1.2.0 branch?

I can change the target branch from here. Merge complete.

I inadvertently merged some of master into 1.2.0 with that merge. I think that's ok though.


Avoid conversion between lossy audio codecs when target codec is available

[x] I've verified and I assure that I'm running youtube-dl 2018.06.14

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[x] Question

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
youtube-dl -v -F "https://www.youtube.com/watch?v=epXN2H1SenI"
[debug] System config: []
[debug] User config: ['--no-playlist', '--output', '~/REMOVABLE_MEDIA/usb_ntfs/tmp_HDD/%(title)s.%(ext)s', '--ignore-errors']
[debug] Custom config: []
[debug] Command-line args: ['-v', '-F', 'https://www.youtube.com/watch?v=epXN2H1SenI']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.06.14
[debug] Python version 3.6.5 (CPython) - Linux-4.16.13-2-zen-x86_64-with-arch-Arch-Linux
[debug] exe versions: ffmpeg 4.0, ffprobe 4.0, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] epXN2H1SenI: Downloading webpage
[youtube] epXN2H1SenI: Downloading video info webpage
[info] Available formats for epXN2H1SenI:
format code  extension  resolution note
140          m4a        audio only DASH audio  131k , m4a_dash container, mp4a.40.2@128k, 41.57MiB
160          mp4        256x144    144p  120k , avc1.4d400c, 12fps, video only, 35.38MiB
133          mp4        426x240    240p  254k , avc1.4d4015, 24fps, video only, 79.16MiB
134          mp4        640x360    360p  261k , avc1.4d401e, 24fps, video only, 73.49MiB
135          mp4        854x480    480p  560k , avc1.4d401e, 24fps, video only, 155.34MiB
136          mp4        1280x720   720p 1105k , avc1.4d401f, 24fps, video only, 338.97MiB
17           3gp        176x144    small , mp4v.20.3, mp4a.40.2@ 24k, 24.21MiB
36           3gp        320x180    small , mp4v.20.3, mp4a.40.2, 73.05MiB
43           webm       640x360    medium , vp8.0, vorbis@128k, 115.51MiB
18           mp4        640x360    medium , avc1.42001E, mp4a.40.2@ 96k, 116.44MiB
22           mp4        1280x720   hd720 , avc1.64001F, mp4a.40.2@192k (best)

youtube-dl -v -x --audio-format vorbis "https://www.youtube.com/watch?v=epXN2H1SenI"
[debug] System config: []
[debug] User config: ['--no-playlist', '--output', '~/REMOVABLE_MEDIA/usb_ntfs/tmp_HDD/%(title)s.%(ext)s', '--ignore-errors']
[debug] Custom config: []
[debug] Command-line args: ['-v', '-x', '--audio-format', 'vorbis', 'https://www.youtube.com/watch?v=epXN2H1SenI']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.06.14
[debug] Python version 3.6.5 (CPython) - Linux-4.16.13-2-zen-x86_64-with-arch-Arch-Linux
[debug] exe versions: ffmpeg 4.0, ffprobe 4.0, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] epXN2H1SenI: Downloading webpage
[youtube] epXN2H1SenI: Downloading video info webpage
[debug] Invoking downloader on 'https://r1---sn-gpoxu-n8vl.googlevideo.com/videoplayback?key=yt6&dur=2714.853&source=youtube&lmt=1412221181141796&nh=%2CIgpwcjAyLnN2bzA1KgkxMjcuMC4wLjE&c=WEB&id=o-ANneR67N2tdv2h6CsuQPLe4zZVFouF8YvcsRgm0Mb7Dy&requiressl=yes&ip=<IP_ADDRESS>&signature=8F6A3F8FFF07C9BB9D48A094EC83D5B0F8225443.91BF4F38B0BE8E3089B99A180527A839B905D273&gir=yes&fvip=17&sparams=clen%2Cdur%2Cei%2Cgir%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Ckeepalive%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cnh%2Cpl%2Crequiressl%2Csource%2Cexpire&mv=m&mt=1529130174&ms=au%2Crdu&itag=140&ei=eK0kW53UIsnQ7gTy8Yj4Cg&ipbits=0&mn=sn-gpoxu-n8vl%2Csn-n8v7zns7&mm=31%2C29&initcwndbps=1390000&keepalive=yes&expire=1529151960&clen=43584581&pl=22&mime=audio%2Fmp4&ratebypass=yes'
[download] Destination: /home/username/REMOVABLE_MEDIA/usb_ntfs/tmp_HDD/Dhammapada Verse 50 - Oversee Yourself.m4a
[download] 100% of 41.57MiB in 00:11
[ffmpeg] Correcting container in "/home/username/REMOVABLE_MEDIA/usb_ntfs/tmp_HDD/Dhammapada Verse 50 - Oversee Yourself.m4a"
[debug] ffmpeg command line: ffmpeg -y -i 'file:/home/username/REMOVABLE_MEDIA/usb_ntfs/tmp_HDD/Dhammapada Verse 50 - Oversee Yourself.m4a' -c copy -f mp4 'file:/home/username/REMOVABLE_MEDIA/usb_ntfs/tmp_HDD/Dhammapada Verse 50 - Oversee Yourself.temp.m4a'
[debug] ffmpeg command line: ffprobe -show_streams 'file:/home/username/REMOVABLE_MEDIA/usb_ntfs/tmp_HDD/Dhammapada Verse 50 - Oversee Yourself.m4a'
[ffmpeg] Destination: /home/username/REMOVABLE_MEDIA/usb_ntfs/tmp_HDD/Dhammapada Verse 50 - Oversee Yourself.ogg
[debug] ffmpeg command line: ffmpeg -y -i 'file:/home/username/REMOVABLE_MEDIA/usb_ntfs/tmp_HDD/Dhammapada Verse 50 - Oversee Yourself.m4a' -vn -acodec libvorbis -q:a 5 'file:/home/username/REMOVABLE_MEDIA/usb_ntfs/tmp_HDD/Dhammapada Verse 50 - Oversee Yourself.ogg'
Deleting original file /home/username/REMOVABLE_MEDIA/usb_ntfs/tmp_HDD/Dhammapada Verse 50 - Oversee Yourself.m4a (pass -k to keep)

Description of your issue, suggested solution and other information
The goal is to get an Ogg/Vorbis audio file. In the example above one of the formats (43) already contains Vorbis audio, so I expect youtube-dl -x --audio-format vorbis to use that format and extract Vorbis audio track out of it. Instead youtube-dl downloads m4a/AAC audio and converts it to Ogg/Vorbis with ffmpeg. Conversions between lossy audio formats could lead to a loss of quality and are much longer than audio track extraction from video file.
Expected behavior:

youtube-dl downloads format 43 because it contains requested Vorbis format
youtube-dl invokes ffmpeg -i track.webm -c:a copy -vn track.ogg and removes track.webm.

Please tell me if I missed some setting to achieve this.

43 is video+audio format. Downloading video for an audio extraction request is an overkill. Instead youtube-dl downloads audio-only format. If there is a vorbis audio-only format it will be download with no conversion. In this case there is no vorbis audio-only format thus a conversion happens.

Cause it will download video part that is useless in such scenario.
You don't need to do this manually: specify -f to prefer best format with acodec=vorbis.

OK, youtube-dl -x -f"best[acodec=vorbis]" works, thanks a lot.
Conversion was taking forever on a SoC server.


Align stuff, capitalize.

Thank you. I don't know if I like this one. Let me think more about it.

OK. Previews are not working properly. I create a Design issue with ideas i have in mind so people can tell me what they think before i do PR's.


Implement CHA - Charisma

User Story
As a game designer, I'd like a player's charisma score/modifier to affect the prices they receive when in the shop.
Acceptance Criteria

High charisma modifiers (+1 and above) lower the price of items in the shop
Low charisma modifiers (-1 and below) raise the price of items in the shop

Notes
Blocked by #47

Why is this feature needed? Please describe the problem your requested feature wants to solve
Currently the charisma score does not affect any gameplay elements, but it should affect some.
Describe the solution you'd like
Based on the charisma ability modifier (which itself is affected is by ability score), the prices a player should see at the shop should change. In particular, the following equation is proposed:
base_price * (1.0 - ability_bonus / 10)
Use Case
Health potions cost 15 Gold. Player A has 12 CHA (modifier of +1). Player B has 8 CHA (modifier of -1).
A: 15 * (1 - 1 / 10) = 15 * 0.9 = 13.5
B: 15 * (1 - (-1) / 10) = 15 * 1.1 = 16.5

Would this also effect sale price back to the shop?

Would this also effect sale price back to the shop?

In the current implementation, the sell price is buy_price / 2, so it would affect the sell price. However, that would then be counterintuitive. I think the sell price should probably be changed, but I'm not sure how it should be changed. Keen to hear your thoughts.


How to reconnect?

Sorry for this simple question, but I do not understand how to reconnect after a failure.
I tried a few combinations of dyad_end / dyad_update but it always fails.
(see example here here )
The only way that seems to work is to create a new stream and reset the callback functions.
Is this the correct method?
`

The only way that seems to work is to create a new stream and reset the callback functions.
Is this the correct method?

This is the correct method -- when a stream closes it is automatically destroyed (DYAD_EVENT_DESTROY) and its resources are freed, the stream is no longer valid and should not be used once this occurs.


[QA] Neon colors turn gray upon approach in 'Inner State' scene (58, -68) in DCLWW

Explorer Alpha build versions:

v0.13.0

Issue Description:
In the 'Inner State' scene at coordinates (58, -68) within DCLWW, neon colors that initially appear vibrant and bright turn gray when the player approaches.
STR:

Launch the explorer
Navigate to coordinates (58, -68) in the 'Inner State' scene within DCLWW.
Observe the neon colors from a distance.
Approach the neon colors and observe the change to gray.

Expected behavior:
https://github.com/user-attachments/assets/fcf191f5-a52c-4f3f-bc66-c6c4efb5f9fe
Current behavior:
https://github.com/user-attachments/assets/d864e71a-4ee8-47e1-9b93-a8010da9011e
Additional Notes:
Windows 11. 12th Gen Intel(R) Core(TM) i7-12650H 2.30 GHz. nvidia geforce RTX

I think this is due to LOD's and it being an SDK6 scene but lets verify.

After debugging the scene, I can confirm:

It's a SDK7 scene.
It's using LODs and they are currently switching between them correctly: When we go far away from the scene, its LOD0 version loads (with more simple meshes, without animations, without collider, etc.), and when we go near the scene, it loads the original version (with more complex meshes, animations, colliders, etc.).
If we compare the LOD0 version with the oringial one, we see the creator decided to use different materials. This is why, for example for the lights that are above the columns, we see them with different bright.


combine packetUnpackerBase and packetUnpacker

The split was only needed for unpacking gQUIC packets.

Codecov Report

Merging #1574 into master will increase coverage by 0.03%.
The diff coverage is 86.67%.

@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
+ Coverage   87.66%   87.69%   +0.03%
==========================================
  Files          95       95
  Lines        6127     6127
==========================================
+ Hits         5371     5373       +2
+ Misses        537      535       -2
  Partials      219      219

Impacted Files
Coverage Δ

packet_unpacker.go
86.67% <86.67%> (ø)
:arrow_up:

session.go
73.87% <0%> (+0.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18b5c0...f4e89ac. Read the comment docs.


Compiler error messages should not be cropped

Compiler error messages are cropped in the UI:

Have I overlooked a way to see the full error messages somewhere? That would be helpful when debugging, as the important bits are often at the (cut-off) ends of the messages.
Maybe they could just be logged to the console?
Even better would be having inline error messages, like in the linter plugin ;)

Have you found a way to work around this?  I'm having a hard time determinging what the compiler is complaining about.

This will be probably done by implementing #79 or some logging panel. Currently the main goal is updating to latest Atom and fully support upcoming Photon.

I had to do this pain in the arse to see full errors for another problem #110
In atom go to the menu -> View -> Developer -> toggle developer tools
Its just like chrome or chromium developer tools: you can click on the magnifying glass and click on a UI element, and see the source for the full information

This is a real pain. Is this being worked on?

Yes, we're going to introduce error console similar to one in Build IDE.

This is rea big pain.. I get the error "build didn't produce binary Error: Command faild:.." I could see the full error .. this is minimum is ide that it shows what the error is ..

Has this been implemented yet? This is the least lovable Particle Dev feature right now..

Unfortunately not yet. But it is on top of your Dev priorities!


Sequencer Problem since last update

Recently I  updated the RNN package and the, up to this point, working script wouldn't run anymore.
To ensure the problem is not (completely) on my side I tested the script in the README
require 'rnn'

batchSize = 8
rho = 5
hiddenSize = 10
nIndex = 10000

mlp = nn.Sequential()
   :add(nn.Recurrent(
      hiddenSize, nn.LookupTable(nIndex, hiddenSize),
      nn.Linear(hiddenSize, hiddenSize), nn.Sigmoid(),
      rho
   )
   :add(nn.Linear(hiddenSize, nIndex))
   :add(nn.LogSoftMax())

rnn = nn.Sequencer(mlp)

criterion = nn.SequencerCriterion(nn.ClassNLLCriterion())

-- dummy dataset (task is to predict next item, given previous)
sequence = torch.randperm(nIndex)

offsets = {}
for i=1,batchSize do
   table.insert(offsets, math.ceil(math.random()*batchSize))
end
offsets = torch.LongTensor(offsets)

lr = 0.1
i = 1
while true do
   -- prepare inputs and targets
   local inputs, targets = {},{}
   for step=1,rho do
      -- a batch of inputs
      table.insert(inputs, sequence:index(1, offsets))
      -- incement indices
      offsets:add(1)
      for j=1,batchSize do
         if offsets[j] > nIndex then
            offsets[j] = 1
         end
      end
      -- a batch of targets
      table.insert(targets, sequence:index(1, offsets))
   end

   local outputs = rnn:forward(inputs)
   local err = criterion:forward(outputs, targets)
   print(i, err/rho)
   i = i + 1
   local gradOutputs = criterion:backward(outputs, targets)
   rnn:backward(inputs, gradOutputs)
   rnn:updateParameters(lr)
   rnn:zeroGradParameters()
end

After adding the missing ')' in line 12 after rho (is this a bug?) the script should run.
Instead it gave my the same error message as my privat script, which was just recently corrected from Mr. Léonard himself (the problem with the sequencer):
.../sebastian/Torch/install/share/lua/5.1/rnn/Recurrent.lua:148: expecting at least one updateOutput
stack traceback:
        [C]: in function 'assert'
        .../sebastian/Torch/install/share/lua/5.1/rnn/Recurrent.lua:148: in function 'updateGradInputThroughTime'
        ...an/Torch/install/share/lua/5.1/rnn/AbstractRecurrent.lua:107: in function 'backwardUpdateThroughTime'
        ...an/Torch/install/share/lua/5.1/rnn/AbstractRecurrent.lua:120: in function 'updateParameters'
        ...e/sebastian/Torch/install/share/lua/5.1/nn/Container.lua:34: in function 'func'
        ...e/sebastian/Torch/install/share/lua/5.1/nn/Container.lua:25: in function 'applyToModules'
        ...e/sebastian/Torch/install/share/lua/5.1/nn/Container.lua:34: in function 'updateParameters'
        ...an/Torch/install/share/lua/5.1/rnn/AbstractRecurrent.lua:117: in function 'updateParameters'
        ...e/sebastian/Torch/install/share/lua/5.1/nn/Container.lua:34: in function 'func'
        ...e/sebastian/Torch/install/share/lua/5.1/nn/Container.lua:25: in function 'applyToModules'
        ...e/sebastian/Torch/install/share/lua/5.1/nn/Container.lua:34: in function 'updateParameters'
        torchrnntest.lua:55: in main chunk
        [C]: in function 'dofile'
        ...tian/Torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:131: in main chunk
        [C]: at 0x00405ea0

Every luarock was updated to the latest version.
I looked in the code and I think it happened in commit 1fc81a47cb55adf74b896338f148fa9bea113ea0
with changing:
-         if step > 1 then
-            self.gradCells[step-1] = gradCell
-         end
+         self.gradCells[step-1] = gradCell

I tried manipulating it but I think there is also a change in the sequencer part.
Can anybody reproduce the error?
I'm pretty (totally) new to Git and I'm just getting started with torch and rnn so please forgive me if this is no bug or if I am doing anything wrong.
Thank you Mr. Léonard for providing this awesome repo!

I couldn't locate the issue.
After resinstalling torch and all its dependecies the third time it did the charm.
Now it works again.
Sorry for opening this ticket. This was no (code) bug.

@angelifrangite thanks for resolving this issue. Open as many as you like :)


Database

Sql or append only log db?

@ahdinosaur One of the features I want to work towards is Time Travel Transactions. As such I think an append only log would suit better - thoughts?

kappa architecture!
agree, it sounds like your data model is financial streams anyways.

also known as "Event sourcing (ES) and Command Query Responsibility Segregation (CQRS)"


FR: Remember the selected column between runs

For my use case for example I do not use or need the PackageName column but on each restart it's enabled again.

@Tolriq I made an another improvements, if there is only one for package, tag, date then columns are automatically collapsed. So you may not need to collapse Packager column manually 😄


Code coverage

Calculate and document code coverage.
Write more tests if needed

resolved test issue in branch. Still should look into increasing coverage


Doesn't understand all possible log paths

The ZNC log module supports placeholders like %Y, %m, and %d in addition to the documented $USER, $NETWORK, and $WINDOW substitutions. However, znc-backlog does not. This makes znc-backlog unusable with ZNC installations that log to directories using these placeholders.
Example: My log module writes to %Y/%m/%d/$NETWORK_$WINDOW.log (year/month/day/ folders, to avoid dumping hundreds of files into any one directory). However, specifying that pattern in this module returns "Could not list directory %Y/%m/%d: No such file or directory" on requesting backlog.

+1. Also being affected.
Backlog module also assumes the target is directory. Which isnt always the case.
22:57:37 <znc_user> logpath $WINDOW_%Y-%m_($USER_on_$NETWORK).log
22:57:37 <*backlog> LogPath set to: $WINDOW_%Y-%m_($USER_on_$NETWORK).log

23:01:17 <znc_user> #znc 100
23:01:17 <*backlog> Could not list directory #znc_%Y-%m_(znc_on_freenode).log: No such file or directory


Update opentelemetry-exporter-jaeger, ... to 1.31.0

About this PR
📦 Updates

io.opentelemetry:opentelemetry-exporter-jaeger
io.opentelemetry:opentelemetry-exporter-otlp
io.opentelemetry:opentelemetry-sdk

from 1.27.0 to 1.31.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.opentelemetry" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.opentelemetry" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #356.