max() arg is an empty sequence

Talon: v0.2.0-305-g968a (305)
Knausj: 3e57e0165257cf07b0e21880d44a91e79cb3ef16
pokey/talon: 0.2.0
pokey/parse-tree: 0.14.0
pokey/cursorless: 0.25.271
2022-02-02 20:55:56 DEBUG User modules loaded at 1.6050s
2022-02-02 20:55:57    IO dired-mode
2022-02-02 20:55:58  INFO (SpeechSystem) Activating speech engine: W2lEngine(fast Conformer b108 (2021-09-15))
2022-02-02 20:55:58    IO Error finding color enablement; falling back to full enablement
2022-02-02 20:55:58    IO Traceback (most recent call last):
2022-02-02 20:55:58    IO   File "/home/nixos/.talon/user/cursorless-talon/src/marks/vscode_settings.py", line 59, in vscode_get_setting_with_fallback
    return actions.user.vscode_get_setting(key, default_value), False
2022-02-02 20:55:58    IO   File "talon/scripting/actions.py", line 78, in __call__
2022-02-02 20:55:58    IO   File "talon/scripting/types.py", line 383, in call
2022-02-02 20:55:58    IO   File "/home/nixos/.talon/user/cursorless-talon/src/marks/vscode_settings.py", line 33, in vscode_get_setting
    path: Path = actions.user.vscode_settings_path()
2022-02-02 20:55:58    IO   File "talon/scripting/actions.py", line 78, in __call__
2022-02-02 20:55:58    IO   File "talon/scripting/types.py", line 383, in call
2022-02-02 20:55:58    IO   File "/home/nixos/.talon/user/cursorless-talon/src/marks/vscode_settings.py", line 89, in vscode_settings_path
    return pick_path(
2022-02-02 20:55:58    IO   File "/home/nixos/.talon/user/cursorless-talon/src/marks/vscode_settings.py", line 68, in pick_path
    return max(existing_paths, key=lambda path: path.stat().st_mtime)
2022-02-02 20:55:58    IO ValueError: max() arg is an empty sequence
2022-02-02 20:55:58    IO Error finding shape enablement; falling back to full enablement
2022-02-02 20:55:58    IO Traceback (most recent call last):
2022-02-02 20:55:58    IO   File "/home/nixos/.talon/user/cursorless-talon/src/marks/vscode_settings.py", line 59, in vscode_get_setting_with_fallback
    return actions.user.vscode_get_setting(key, default_value), False
2022-02-02 20:55:58    IO   File "talon/scripting/actions.py", line 78, in __call__
2022-02-02 20:55:58    IO   File "talon/scripting/types.py", line 383, in call
2022-02-02 20:55:58    IO   File "/home/nixos/.talon/user/cursorless-talon/src/marks/vscode_settings.py", line 33, in vscode_get_setting
    path: Path = actions.user.vscode_settings_path()
2022-02-02 20:55:58    IO   File "talon/scripting/actions.py", line 78, in __call__
2022-02-02 20:55:58    IO   File "talon/scripting/types.py", line 383, in call
2022-02-02 20:55:58    IO   File "/home/nixos/.talon/user/cursorless-talon/src/marks/vscode_settings.py", line 89, in vscode_settings_path
    return pick_path(
2022-02-02 20:55:58    IO   File "/home/nixos/.talon/user/cursorless-talon/src/marks/vscode_settings.py", line 68, in pick_path
    return max(existing_paths, key=lambda path: path.stat().st_mtime)
2022-02-02 20:55:58    IO ValueError: max() arg is an empty sequence
2022-02-02 20:55:58 ERROR cb error topic="ready" cb=<function on_ready at 0x7fae65c94ca0>
   15:                         lib/python3.9/threading.py:930* # loader thread
   14:                         lib/python3.9/threading.py:973*
   13:                         lib/python3.9/threading.py:910*
   12:                            app/resources/loader.py:805|
   11:                            app/resources/loader.py:755|
   10:                        talon/scripting/dispatch.py:105|
    9:                        talon/scripting/dispatch.py:144|
    8:                        talon/scripting/dispatch.py:135|
    7: ------------------------------------------------------# loader thread
    6:                            talon/scripting/rctx.py:233| # 'ready' user.cursorless-talon.src.marks.mark:on_ready()
    5:            user/cursorless-talon/src/marks/mark.py:223| vscode_settings_path: Path = actions.u..
    4:                         talon/scripting/actions.py:78 |
    3:                           talon/scripting/types.py:383|
    2: user/cursorless-talon/src/marks/vscode_settings.py:89 | return pick_path(
    1: user/cursorless-talon/src/marks/vscode_settings.py:68 | return max(existing_paths, key=lambda path: path.stat().st_mtime)
ValueError: max() arg is an empty sequence

I got another error after that one, but I think maybe users installing extensions the expected vscode way might not run into the error below where I don't have command-server.
For context to understand how I run into it I'm installing vscode with nixos where I list out the extensions and only had talon, parse-tree, and cursorless.
2022-02-03 16:22:14  INFO Startup warnings displayed at 3.5035s
2022-02-03 16:22:40 WARNING list 'user.punctuation' skipped unknown tokens: [',', '`']
2022-02-03 16:22:40 WARNING list 'user.symbol_key' skipped unknown tokens: [',', '`']
2022-02-03 16:23:28 ERROR    19:                                talon/scripting/talon_script.py:590|
   18:                                talon/scripting/talon_script.py:297|
   17:                                talon/scripting/talon_script.py:557|
   16:                                     talon/scripting/actions.py:78 |
   15:                                       talon/scripting/types.py:383|
   14:                   user/cursorless-talon/src/actions/actions.py:65 | return actions.user.cursorless_command..
   13:                                     talon/scripting/actions.py:78 |
   12:                                       talon/scripting/types.py:383|
   11:                   user/cursorless-talon/src/actions/actions.py:54 | return actions.user.cursorless_single_..
   10:                                     talon/scripting/actions.py:78 |
    9:                                       talon/scripting/types.py:383|
    8:                           user/cursorless-talon/src/command.py:32 | actions.user.cursorless_multiple_targe..
    7:                                     talon/scripting/actions.py:78 |
    6:                                       talon/scripting/types.py:383|
    5:                           user/cursorless-talon/src/command.py:93 | actions.user.vscode_with_plugin_and_wa..
    4:                                     talon/scripting/actions.py:78 |
    3:                                       talon/scripting/types.py:383|
    2: user/knausj_talon/apps/vscode/command_client/command_client.py:331| run_vscode_command(
    1: user/knausj_talon/apps/vscode/command_client/command_client.py:154| raise Exception("Must use command-server extension for advanced commands")
Exception: Must use command-server extension for advanced commands

My latest issue is:
2022-02-03 16:51:55 WARNING actions: skipped because they have no matching declaration: (user.code_type_dictionary)

That appears to be in knausj_talon under the javascript tag, so I'll add that to settings.talon.

I'm still getting:
2022-02-03 17:10:05 WARNING actions: skipped because they have no matching declaration: (user.code_type_dictionary)

Even though I've enabled that tag and restarted talon:
$ cat ~/.talon/user/settings.talon
settings():
    speech.record_all = 1
tag(): user.i3wm
tag(): user.javascript

Things seem to work now despite that warning, but I'm just slow at understanding how to use things :)

Should I close this or leave it open until the fix you referred to is merged?

I got another error after that one, but I think maybe users installing extensions the expected vscode way might not run into the error below where I don't have command-server.
For context to understand how I run into it I'm installing vscode with nixos where I list out the extensions and only had talon, parse-tree, and cursorless.

I'm a bit surprised you have the talon extension but not command-server.  The talon extension bundles the command-server extension

I'm still getting:
2022-02-03 17:10:05 WARNING actions: skipped because they have no matching declaration: (user.code_type_dictionary)

Yes, as you discovered, that warning isn't actually a problem.  It's actually a knausj thing, so you might file that there

Even though I've enabled that tag and restarted talon:
$ cat ~/.talon/user/settings.talon
settings():
    speech.record_all = 1
tag(): user.i3wm
tag(): user.javascript

You should remove that user.javascript tag.  Talon will automatically detect when you're in a javascript file and activate the user.javascript tag for you

Should I close this or leave it open until the fix you referred to is merged?

Yeah I think we can close this one; Cursorless already does its best to handle this case using the current infrastructure, and it won't be a problem with the next version, which should be shipping soon

I am still getting this warning. In my Linux distribution (Arch) the settings paths are ~/.config/Code - OSS/User/settings.json for the stable and ~/.config/Code - Insiders/User/settings.json for the beta version. I guess this is not covered yet: https://github.com/cursorless-dev/cursorless/blob/main/cursorless-talon/src/marks/vscode_settings.py#L87-L94 . Despite the warning everything is working fine.

Yeah maybe let's reopen, since this one is still an issue, even though it's not severe

I think probably the thing to do for now is to show a better error / warning, with an explanation and a link to this issue

Just to say that i had this error with latest talon beta and latest cursorless on a Ubuntu 22.04 and it was indeed due to the missing vscode setting file:
2023-05-10 12:23:01    IO Error finding color enablement; falling back to full enablement
2023-05-10 12:23:01    IO Traceback (most recent call last):
2023-05-10 12:23:01    IO   File "/home/user/.talon/user/cursorless-talon/src/apps/vscode_settings.py", line 60, in vscode_get_setting_with_fallback
    return actions.user.vscode_get_setting(key, default_value), False
2023-05-10 12:23:01    IO   File "talon/scripting/actions.py", line 88, in __call__
2023-05-10 12:23:01    IO   File "/home/user/.talon/user/cursorless-talon/src/apps/vscode_settings.py", line 34, in vscode_get_setting
    path: Path = actions.user.vscode_settings_path()
2023-05-10 12:23:01    IO   File "talon/scripting/actions.py", line 88, in __call__
2023-05-10 12:23:01    IO   File "/home/user/.talon/user/cursorless-talon/src/apps/vscode_settings.py", line 91, in vscode_settings_path
    return pick_path(
2023-05-10 12:23:01    IO   File "/home/user/.talon/user/cursorless-talon/src/apps/vscode_settings.py", line 69, in pick_path
    return max(existing_paths, key=lambda path: path.stat().st_mtime)
2023-05-10 12:23:01    IO ValueError: max() arg is an empty sequence
2023-05-10 12:23:01    IO Error finding shape enablement; falling back to full enablement
2023-05-10 12:23:01    IO Traceback (most recent call last):
2023-05-10 12:23:01    IO   File "/home/user/.talon/user/cursorless-talon/src/apps/vscode_settings.py", line 60, in vscode_get_setting_with_fallback
    return actions.user.vscode_get_setting(key, default_value), False
2023-05-10 12:23:01    IO   File "talon/scripting/actions.py", line 88, in __call__
2023-05-10 12:23:01    IO   File "/home/user/.talon/user/cursorless-talon/src/apps/vscode_settings.py", line 34, in vscode_get_setting
    path: Path = actions.user.vscode_settings_path()
2023-05-10 12:23:01    IO   File "talon/scripting/actions.py", line 88, in __call__
2023-05-10 12:23:01    IO   File "/home/user/.talon/user/cursorless-talon/src/apps/vscode_settings.py", line 91, in vscode_settings_path
    return pick_path(
2023-05-10 12:23:01    IO   File "/home/user/.talon/user/cursorless-talon/src/apps/vscode_settings.py", line 69, in pick_path
    return max(existing_paths, key=lambda path: path.stat().st_mtime)
2023-05-10 12:23:01    IO ValueError: max() arg is an empty sequence
2023-05-10 12:23:01 ERROR cb error topic="ready" cb=on_ready
   11:                        lib/python3.9/threading.py:937* # loader thread
   10:                        lib/python3.9/threading.py:980*
    9:                        lib/python3.9/threading.py:917*
    8:                           app/resources/loader.py:889|
    7:                           app/resources/loader.py:835|
    6: -----------------------------------------------------# [stack splice]
    5:                       talon/scripting/dispatch.py:134| # 'ready' user.cursorless-talon.src.marks.mark:on_ready()
    4:           user/cursorless-talon/src/marks/mark.py:242| vscode_settings_path: Path = actions.u..
    3:                        talon/scripting/actions.py:88 |
    2: user/cursorless-talon/src/apps/vscode_settings.py:91 | return pick_path(
    1: user/cursorless-talon/src/apps/vscode_settings.py:69 | return max(existing_paths, key=lambda path: path.stat().st_mtime)
ValueError: max() arg is an empty sequence
2023-05-10 12:23:02 DEBUG Dispatched launch events at 6.8212s, done at 11.5318s
2023-05-10 12:23:02 ERROR [!] 1 error(s) during startup (shown earlier in log)

The fix:
$ echo "{}" > ~/.config/Code/User/settings.json

I would be a bit careful with that fix, though, because the message can appear for one of two reasons:

You don't have any custom VSCode settings. Your fix is fine in that case
You are using a VSCode version that is using some weird settings location. I think we've fixed that problem in all cases, but there were some pretty weird corner cases, so I'd be hesitant to blanket apply your fix in case we missed something. Also in this case your fix will only work until you actually change your enabled hats

@auscompgeek @AndreasArvidsson does that sound right?

Sounds right. In any case, opening the VSCode user settings JSON using the VSCode command and saving it would be the guaranteed correct way to create the settings file.

Yeah good call. Can just say "show settings json" with VSCode focused and then save it. Not sure if it automatically inserts a {}, but can just say "inside braces" and then save if not

In case anyone else is using VS Code Insiders on a Mac, you will get this error as well, as src/apps/vscode_settings.py does not check for the Insiders settings which are at Code - Insiders/User/settings.json instead of Code/User/settings.json
Not sure if anything should be done about it officially, as Insiders is beta for a reason, but good to know that it's an easy manual fix.

Oh yeah that's a bug we should file and fix separately. should be super easy

Hi! I just helped a friend who's getting into coding set up Cursorless and fae ran into this same bug -- Talon wouldn't start up because cursorless-talon couldn't find settings.json.
Changing a setting in VS Code created the file and fixed the problem, but I had to dig into cursorless-talon's source code a little to figure out what it was looking for, and guess that changing a setting would fix it.
It would be nice if you could add a quick note to the installation page making sure that users have changed a setting -- even just flipping the color scheme back and forth -- so other folks don't get caught on this.

@AndreasArvidsson I wonder if we could actually ensure the file is there automatically. Eg on Cursorless start-up the first time, just set and unset some dummy cursorless setting to make sure the file appears?

Or we could just gracefully handle that it doesn't exist?

The thing is we don't actually know that it doesn't exist, because there are several places it could be, including places we don't know about, as has happened before
That's not to say we shouldn't also gracefully handle it not existing, but ensuring it exists should help too

Sure. We can just toggle the Cursorless debug setting or something.

I guess we should check that toggling leaves an empty (or just {}) file there. I would guess it does tho


Update Statistics.ipynb

You've left the std to default, which seems to equals t 1, which generates a standard normal distribution

Hey, Thanks for pointing this out.
Rather than changing the question to call it Standard Normal Distribution, can you propose a solution where t = 1 is mentioned and we can call in the answer that for t=1 it is standard else not. That way readers will have a better answer to the same question.


Crash KinematicBody2

First :)
THX FOR YOUR WORK
I got an strange bug i try to play with KinematicBody2D
Describe the bug
collision := p.MoveAndCollide(velocity)
make an beautifull
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
-- END OF BACKTRACE --

To Reproduce
        animatedSprite := gdnative.NewAnimatedSpriteWithOwner(p.GetNode(gdnative.NewNodePath("AnimatedSprite")).GetOwnerObject())
	animatedSprite.Stop()
	var velocity = p.getInputs()
	v1 := velocity.Normalized()
	velocity = v1.OperatorMultiplyScalar(float32(p.speed.AsReal()))
	if velocity.Length() <= 0 {
		log.Debug("no move")
	} else {
		velocity = velocity.OperatorMultiplyScalar(float32(delta))
		str := velocity.AsString()
		log.Debug(str.AsGoString())
		collision := p.MoveAndCollide(velocity, true, true, true)

		if collision != nil {
		    log.Debug("I collided with " + collision.GetCollider().ToString())
		}
	}

Expected behavior
Player move
Screenshots
My Project Tree

My npc Tree

Desktop (please complete the following information):

OS: [MAC OS]
Architecture [amd64]
.
Any Idéa ?

Thanks for the interest in my project! I'll have to give this a try tonight as I can't see any obvious issues.

https://github.com/ekozan/godotIA <- I uploaded my project if you need it
if you need more info just ask
I hope it's not an error of mine

it's a bug in the library; the codegen didn't include a short-circuit if the move_and_collide returns nil. it should be a simple fix

@ekozan godot-go 0.0.13 should have the fix. thanks for bringing up the problem! i'll close out the ticket for now, but please leave a comment or reopen the issue if the crash persists.
i left a PR here: https://github.com/ekozan/godotIA/pull/1 that has the fix

@pcting  it works thx  👍


Fix race condition that resets environment setting to default

Description
Merging #6083 on the iso4 branch resulted in a merge conflict and it requires a lot of work to fix the conflict. Since the tests are not failing on this issue for iso4 and iso4 is nearly EOL, I decided not to fix this on iso4.

Processing this pull request

Merged into branches iso4 in b21414dd25e3a1a5c30d20ca07897d82963ba300


Various CSS and HTML tweaks

Remove various horizontal dividers on repo pages that didn't provide visual benefit
Remove issue-related pill buttons on projects page
Increase contrast of color-secondary on arc-green
Improve notifications icon, make circle bigger
Remove some inline styles

Can you post a before/after comparison?

Will do some improvement to issue/pr title as well.

@yardenshoham done

Mobile view improved as well:

Some tweaks to state label:

Made some changes to the "branch_dropdown", only two places need the "button right margin":

And remove more dead code from release list page:

The issue page title seems no margin/padding at the moment:

The issue page title seems no margin/padding at the moment:

Yes, I remember removing spacing, but apparently didn't notice this.

Margin issue is a mystery. It is there on PR, but absent on issue. I assume it should be this divider pushing down the content:

Ah, it is related to presence of ui stackable grid which sets (ugh) negative margins and shifts the content. Will try to remove it.

Margin issue fixed in https://github.com/go-gitea/gitea/pull/24459/commits/61976e73e0fcf65c1f764039518e2bc604b03cee. It cleans up the subtemplate inclusions as well so that view_title and view_content are only imported once.
I also removed one seemingly useless wrapper div:
<div class="ui bottom attached tab pull active" data-tab="request-{{.ID}}">

The .ID was not set so data-tab would end up rendered as request-. I do not see any impact on the tab behaviour in a PR, so I think it was a useless element.

Open questions:

Can someone share a method how to trigger a flash on the PR page?
Whether the tab pull active removal really has no negative effect. 95% sure it has none.

Ready again. If someone can help test what is mentioned in https://github.com/go-gitea/gitea/pull/24459#issuecomment-1533527436, it should be good to go. PR got quite big now, but overall it will be a nice cleanup as well.

Flash figured out and working fine after margin tweak:

It seems related:

Very likely a regression because of the lack of negative margin on the container.

The ".review-item" doesn't get matched, because "ui bottom attached tab pull active" was removed.

Ah, yes the tab pull active wrapper was removed as mentioned above, so we need to adapt the existing CSS.

Where was this screenshot from with the box being misaligned horizontally? I do not see this box misalignment on main branch, but I do see the icon misalignment:

Where was this screenshot from with the box being misaligned horizontally? I do not see this box misalignment on main branch, but I do see the icon misalignment:

Small width.

Working on it.

BTW avatar is misaligned in those screenshots as well and I see the issue is on 1.19 as well.

https://github.com/go-gitea/gitea/pull/24526 should fix all issues discussed.


Deprecate source deploy & deploy destructive manifest

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@583652d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #356   +/-   ##
==========================================
  Coverage           ?   81.04%
==========================================
  Files              ?       28
  Lines              ?      955
  Branches           ?      166
==========================================
  Hits               ?      774
  Misses             ?      181
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 583652d...f5e4276. Read the comment docs.


Add Swift sample

This looks great, thanks for doing this.
@JustinBeckwith can I get your eyes on this real quick?


An implementation of Nord in PrismJS

Issue type: feature
Related issues: #47

More specifically, this comment: https://github.com/arcticicestudio/nord/issues/47#issuecomment-355847065
Description
I implemented a PrismJS css file for the Nord theme. It is currently in my GitHub repo here. I am not sure if the original author would like this to be under this official GitHub repo instead. If so, please contact me and we can transfer the repository.
Meanwhile, if anyone comes looking for Nord theme in PrismJS, you can head over to this repo: https://github.com/GalenWong/nord-prism-js
Thank you for this amazing theme!

Hi @GalenWong :wave:, thanks for your contribution :+1:
There are plans to definitely create an official port project for PrismJS since it'll be used by Nord itself later on.
I've added it to the backlog and @-mention you as soon as I start working on it so you can track the progress or contribute ideas for this port project.
Please note that it may take some time because there are many other issues over many other port projects with requests and proposals waiting in the queue. I'm currently also very busy working on the data transition of all port projects to the new and shiny website and documentations to finally have a „single source of truth“ for Nord and all related data. Please also take into account that I work as a software developer in the "real world" and I hope you understand that the time to work on my projects may vary depending on my free time. :octocat:


Add files via upload

Description 📜
Added Documentation about Rarely Used but Useful HTML Tags
Fixes #2909

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Frontend Dev HTML/CSS/JS

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@ipsitagoel Changes made, grammar corrected. Please review.


Do not merge: Apply upstream aarch64 consecutive register fix (11.x)

Closes #164
Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin please rerender

Thank you for pointing this out. I'm going to let this run, to see if holding back the compiler helps osx for educational purposes.

Seems like OSX didn't get fixed from this.

This is an ABI breakage. See the last comment in https://bugs.llvm.org/show_bug.cgi?id=46996

Isn't that only the case when the LLVM 12-specific version of the patch is applied to LLVM 12? It looks like the version applied to the LLVM 11 branch was OK: https://bugs.llvm.org/show_bug.cgi?id=46996#c9

Why do you think it's not an ABI breakage for LLVM 11? The patch for LLVM 11 changes the signature for a public method which changes the name mangling and therefore is an ABI breakage

Why do you think it's not an ABI breakage for LLVM 11? The patch for LLVM 11 changes the signature for a public method which changes the name mangling and therefore is an ABI breakage

Thanks for the clarification, I was wrong about this. I'd misunderstood some of the discussion on the LLVM bug which lead me to believe that the ABI was the same for LLVM 11 but differed for LLVM 12.


🚀 Added image opening functionality

Modified the extension code to open images with a clickable link. Now, when you save an image, you can click on the "Open Image" link in the information message to open the image using the default system image viewer.

@khattakdev can you review this?

there was a merge conflict due to a recent update via https://github.com/khattakdev/capture/issues/15, I have resolved this.

@hammadsaedi please resolve the conflicts - so I can review this.

@khattakdev resolved :)

@hammadsaedi some more conflicts :)

@khattakdev done: third time :(
pls, merge it first 🗿


chore(main): release 1.8.3

:robot: I have created a release beep boop
1.8.3 (2023-10-20)
Bug Fixes

🚀 修复 MacOS 软件包安装后无线显示 Logo 的问题 (77dd81b)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/viarotel-org/escrcpy/releases/tag/v1.8.3 :sunflower:


changing authentication to api key for tone analyzer and NLU

@markstur, I added a new screenshot. The instructions are still the same. Thank you.


FAIL: Example_badinit_nocompiler

Build in travis is failing
https://travis-ci.org/apache/incubator-openwhisk-runtime-go/builds/373762183#L1197
--- FAIL: Example_badinit_nocompiler (1.11s)
got:
400 {"error":"no action defined yet"}
200 {"ok":true}
400 {"error":"cannot start action: command exited"}
400 {"error":"cannot start action: command exited"}
200 {"ok":true}
400 {"error":"command exited"}
want:
400 {"error":"no action defined yet"}
200 {"ok":true}
400 {"error":"cannot start action: command exited"}
400 {"error":"cannot start action: command exited"}
400 {"error":"cannot start action: command exited"}
400 {"error":"no action defined yet"}
=== RUN   Example_bininit_nocompiler

Same test passed when it was from the PR
https://travis-ci.org/apache/incubator-openwhisk-runtime-go/builds/373761010#L1208

@sciabarracom could you take a look why this test is failing.

@sciabarra you have an update on this?

Can I get a debug build? Will contact you on slack, you start the build I’m debug and give me ssh to connect to the temporary container.

It looks like the test is passing in travis now.
Closing...


Fix/47584

Details

Adding this condition reportActions.length === 1 will handle case when we are changing view from many transactions to one transaction and ReportActionsView will be able to scroll up. Currently here https://github.com/Expensify/App/blob/78e484f41e5fb5fa3f8827d2b4aea0ba55b581e4/src/components/InvertedFlatList/BaseInvertedFlatList/index.tsx#L21-L23
we are not setting autoscrollToTopThreshold because shouldEnableAutoScrollToTopThreshold is always false.
Fixed Issues

$ #47584
Tests

Submit 2 Expenses to same person/workspace
Delete one of them so it will change view to One-transaction
Verify that whole details are visible

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Submit 2 Expenses to same person/workspace
Delete one of them so it will change view to One-transaction
Verify that whole details are visible

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native
https://github.com/user-attachments/assets/5399e3ba-6ff9-465b-a27d-8ab539025aef

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/373c861a-44a8-4ae2-bb83-d59f0f58960d

MacOS: Desktop
https://github.com/user-attachments/assets/72fc2867-cf08-48e2-a01d-f1e574b0487e

This didn't fix the reported issue (delete request from another device)
https://github.com/user-attachments/assets/a493ec85-bbcc-439e-bd45-5098b3a3de4b

@s77rt for me this fix is working also for this scenario. tried to reproduce that few times
https://github.com/user-attachments/assets/c7e539cc-fcd7-45cf-9d42-8aa5caf334ef

done @s77rt

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/96f34ea8-0ec8-4d09-9939-43217a6d87e2

Android: mWeb Chrome

https://github.com/user-attachments/assets/c4c07594-d5cf-437d-a5d7-57a6a414ac6d

iOS: Native

https://github.com/user-attachments/assets/6cac47ff-cc0c-484f-99ca-2e370b377d0a

iOS: mWeb Safari

https://github.com/user-attachments/assets/8cd47081-1c52-40b5-8a15-7b2d9f946529

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/5647a63e-b822-4a7e-a3b6-5027a3d3939a

MacOS: Desktop

https://github.com/user-attachments/assets/e8f9ba3d-eb2c-405e-b779-cc0175a9987e

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Add Python inspections and a script for tool evaluation

Description:

Added wps-light support (see #17)
Added support for flake8-broken-line, flake8-string-format, flake8-commas (they are WPS dependencies) (see #18)
Added support for cohesion (see #18)
Added new inspector: Radon (see #19)
Added maintainability index (see #19)
Updated versions of dependencies (see #21)
Added xlsx_tool_run.py – script to run the tool on multiple code samples stored in xlsx file (see #24)

@vyahhi I fixed this TeamCity build

This branch has conflicts that must be resolved

@vyahhi I fixed them. TeamCity build is successful

Is test/resources/evaluation/xlsx_files/__init__.py file (and similar __init__.py in the xlsx files paths) really needed?

No, sorry, PyCharm created them automatically.

@andrvb I fixed all comments

@vyahhi We deleted the evaluation part, fixed pmd and flake8 bugs.
But yesterday we found several new bugs (see new issues), we will fix all of them tomorrow.


What's the difference between Search cache and Primary cache?

Hi @Pacific73
I noticed that there are four Cache level:
const (
	CacheLevelOff         CacheLevel = 0
	CacheLevelOnlyPrimary CacheLevel = 1
	CacheLevelOnlySearch  CacheLevel = 2
	CacheLevelAll         CacheLevel = 3
)

What's the difference between Search cache and Primary cache, or All cache?  Thanks a lot.

Primary cache gets objects cached when you use db.Where("id IN (?)", []int{1,2,3}). It's based on primary key, a.k.a, id.
Search cache gets objects cached using complete SQL as key.


firmware.volt: fix regression in previous. typo

fixes Updates tab behavior after checking for updates.
ref. https://github.com/opnsense/core/issues/5635#issuecomment-1396823926
sorry for the inattention (

Merged, thanks!


TS: Output string not String for fallback scalar type.

At the moment, apollo-codegen outputs the type String as a fallback for custom scalar types (the JS String type, very different from TS string).
After this patch, it correctly outputs string.
If you take a quick look at the patch, I'm fairly certain this was simply unintended behaviour (and lucky that it worked at all), caused by an implicit toString on a value of the wrong type.

Done, thanks for the review!

Can the code from this PR be also added on 0.11.x? I'm not sure why 0.10.x and 0.11.x have overlapping releases but I can't get 0.10.13 to work in my TypeScript project (the generated schema.ts file have errors) while 0.11.13 is just fine.
Sorry I forgot to mention that I tested the code on this PR on 0.11.13.
@tekacs what version are you using?

That is really unexpected. The 0.11.x releases are made from the new-swift-target branch, and are only needed when running apollo-ios from master. There should be no need to run these for TypeScript/Flow, and recent 0.10.x releases in fact should be more up to date for these targets.
Can you post the error you get on 0.10.13 so we can look into it?

Actually it doesn't really output any errors in the console at all. It's just that the resulting schema.ts file has errors when apollo-codegen tries to generate it from instrospection with multiline comments. It makes the multiline comments part of the code (that is obviously should not) when they should just remain as comments.

Can you post an example of the generated code from 0.10.x vs. 0.11.x so we can look into this?


Add option to disable scrolling for custom layout

A new functionality that allows to users to disable scrolling for the custom layout.

Summary by CodeRabbit

New Features

Added an allowScrolling option to customize scrolling behavior in the swiper widget.

Improvements

Enhanced gesture handling in custom layout to respect the allowScrolling setting, allowing for more flexible user interactions.

Merge this


term_variables/2 missing, numbervars/2 problematic

Currently, there is no an implementation of term_variables/2 as a library, but it should be a built-in predicate. And then, there is this unusual code for numbervars/2. Usually no copy is involved in this.
Here is an efficient implementation using term_variables/2:
numbervars(Term, N0,N) :-
   % type check for instantiated integer(N0)
   % type check for integer(N)
   term_variables(Term, Vars),
   numberlist(Vars, N0,N).

numberlist([], N,N).
numberlist(['$VAR'(N0)|Vars], N0,N) :-
   N1 is N0+1,
   numberlist(Vars, N1,N).

So the complexity of efficient term traversal is delegated to term_variables/2. Thus less code.

Please note that term_variables/2 is ISO. So it should be present by default.
On the other hand, numbervars/3 should remain in a separate module. And numbervars/2 is pretty uncommon. Just stick with numbervars/3.

numbervars/2 is still here and numbervars/3 is not. It should be the other way around.

Using library(error), numbervars/3 reads:
numbervars(Term, N0,N) :-
   must_be(integer, N0),
   can_be(integer, N),
   term_variables(Term, Vars),
   numberlist(Vars, N0,N).

In general for built-ins this convention would also help on the Rust-level: that is: must_be/2 produces both instantiation errors and type (or even domain) errors.
Whereas can_be/2 only produces type (and domain) errors, but produces nether an instantiation error. can_be/2 is thus responsible for checking (kind of) output arguments.

Ugh, sorry. I was careless with my first reading of your response.
This raises an issue I left unresolved and forgot about months ago. When calling a predicate from a module, how should namespace resolution work? Presently, call/N searches only the "user" namespace for user-defined predicates. This means that the new definition of numbervars/3 won't be able to find internal_numbervars, since its definition is internal to the module.

In this case there should not be any ambiguity. That is, internal_numbervars/3 when used within catch/3 would be prefixed with the module providing numbervars/3. So I do not see any problem here.
Sooner or later you will have to use meta_predicate declarations. They indicate which argument needs an explicit prefixing - should the argument not be prefixed already. Think of catch/3 which would be
:- meta_predicate catch(0, ?, 0).

The 0 means: Further 0 arguments are needed to call this.
Think of
:- meta_predicate maplist(1, ?).

Here, the first argument needs an extra argument to become a goal.  This argument will be added via
call(G_1, Arg).
Another useful convention is to name all variables that are actually goals or incomplete goals  with _0 for needing zero args, _1 for needing one extra arg etc. Thus its the very same number as in the declaration

And: term_variables(Term, Variables) needs a can_be(list, Variables)!

@mthom: did you see my last comment?


Plugins should not print or colorize stuff

All the configuration information must be centralized and provided by the main app code. Same for the print messages that must be implemented in a single place in order to centralize the logging and reporting.

Fixed!


(WIP)[RN-781]: ios/android quick links

I found an issue specifically on Android. The event quickActionShortcut is permanently called every time you enter (or back) to Home. So, if you click on a shortcut function (receive, send, buy, or swap), then you go back to Home, it will return to the view "Select a currency". Also, if you go back, and change the tab, it's fine. But if you return to Home, it will redirect again to "Select a currency".

thank you, I'm working on a fix


Docs improve README.md

So what does this improve?

and why do we need to add this?

just for swag t shirts from hackstars
I think you can understand bro.
Please don't mind...😀😀🤗🤗
On Thu, Oct 1, 2020, 9:04 PM metalcupcake5<EMAIL_ADDRESS>wrote:

and why do we need to add this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SkyCryptWebsite/SkyCrypt/pull/85#issuecomment-702218584,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQS3SX2HIDMNO52FHQVIE4LSISOSBANCNFSM4SAFBWTA
.

I'm just a beginner coder. So I actually don't know what to do...
On Thu, Oct 1, 2020, 10:41 PM Kartik Savaliya<EMAIL_ADDRESS>wrote:

just for swag t shirts from hackstars
I think you can understand bro.
Please don't mind...😀😀🤗🤗
On Thu, Oct 1, 2020, 9:04 PM metalcupcake5<EMAIL_ADDRESS>wrote:

and why do we need to add this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SkyCryptWebsite/SkyCrypt/pull/85#issuecomment-702218584,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQS3SX2HIDMNO52FHQVIE4LSISOSBANCNFSM4SAFBWTA
.

https://hacktoberfest.digitalocean.com/details#quality


fix: added test case for empty li elements in the 'Create a bulleted unordered list' challenge.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #18007

This is my very first PR.  Apologies in advance if PR wasn't done correctly. This is for issue https://github.com/freeCodeCamp/freeCodeCamp/issues/18007

@alan-nguy
Good Work for a first PR, I would suggest you create an issue first for this as this seems like something which would be better discussed first.
Straight Pull Requests are only desirable when we are fixing issues not really needing any discussion however we are changing a test in a challenge here so it could use some discussion first.
you can then link the PR with this issue.
Awesome work for your first PR 👍

@co16353sidak
Thank you for for the pointer. A new PR has been submitted.
This PR is for issue https://github.com/freeCodeCamp/freeCodeCamp/issues/18007

@alan-nguy I tested your solution it seems to work well.  One thing this challenge is missing (not your fault) is an actual valid working solution.  When one is present it is used behind-the-scenes to validate all the written test case still pass with a working solution. Replace the section which looks like:
## Solution
<section id='solution'>

````js
// solution required

```
with
```
## Solution

<h2>CatPhotoApp</h2>
<main>
  <p>Click here to view more <a href="#">cat photos</a>.</p>

  <a href="#"><img src="https://bit.ly/fcc-relaxing-cat" alt="A cute orange cat lying on its back."></a>

  <ul>
    <li>milk</li>
    <li>mice</li>
    <li>catnip</li>
  </ul>
</main>```
</section>
```

Hi @alan-nguy,
So we have a unique situation here that I am hoping you will not be to upset about.  Even though you created your PR before any other PR was created for issue #18007, another user was given the go ahead to create a PR.  Most of the time, when users say they will create a PR, they never do.  However, in this case, the user did create a valid additional test.  It is not the same as yours, but it works all the same.
Seeing that the other user was given "consent" to work on this, I have approved the other PR instead for the additional test.  However, the other PR did not provide a working solution (as I requested you add), so if you can just remove the additional test off this PR and update the PR title with applicable wording, this PR can still be merged independently of the other one.
Also, neither yours nor the other PR added the additional test to the Basic HTML and HTML5: Create an Ordered List challenge, so the other user agreed to let you be the one to add a similar test for that challenge and include it on this PR.  Go ahead an add a working solution for that challenge to this PR and that will truly close out issue #18007.
Sorry for any confusion or frustration this may have caused you, but this is kind of a unique situation that does not come up very often.  If you have any questions about anything I have stated here, please let me know.

ATTENTION REVIEWERS:  Please do not merge this PR before #35234 has been merged.

@RandellDawson Thank you for the update. Nothing to be upset about. PR coming in shortly in the next hour. Cheers!

@ezioda004 thnx for the review! New PR added.

@ezioda004 I pull this PR down again with the most recent changes and test it locally.  I think this PR is ready to merge.

@Manish-Giri I think all of your observations are valid.  I think a new issue with these items should be created and then we can discuss all options of how best to deal with them before even creating a PR.
In several of my latest PRs, I have been stripping white space from the code (where it does not affect the code's purpose).  My regular expressions become much simpler in many cases, because I don't have to add all possible \s* just to account for how someone white attempt to write the code.  Also, I really believe we could get away from the heavy use of regular expression in the asserts if we rethink how we can check for valid solutions.  I have a few ideas that we can discuss.  One is using a minifier for CSS and HTML sections which would be used to before the test so in the case where we are looking for very specific CSS in the code, we at least don't have to deal with trying to account for all the possible white space that could be present and still be valid code.

@ezioda004 I guess we are just waiting for review to validate the changes you requested have been met in your opinion, before merging this PR.

@ezioda004 Any change for a final review?

Thank you @alan-nguy for your contribution. Looking forward to more contributions from you! 🎉


BlackHole Curve and Ambience Pitch

What Happened?
The BlackHole curve attribute doesn't work. I tried changing the default size to 0.1 and multiplying the size by 50000 and also changing the default size to 5000 and setting the value to 0 at times 0-5, yet it only stays the default size.
Then, when super sizing a BlackHole to size 5000, when falling in the pitch is higher than the normal blackhole and normal-sized singularities. would be fun if you could change the volume and pitch of the BlackHole sounds
What was supposed to happen?
BlackHole curve attribute will multiply the blackhole size by the provided value
BlackHole would have the same deep hum when falling into it when its supersizedit's
Platform
Steam
Mods
New Horizons Dev Build
PacificEngine's Common Resources
Cheats Mod
Unity Explorer
Run In Background
Collider Visualizer

Logs
Not listed

Todo

[ ] Apply scale curve to singularities
[ ] Fix pitch shift when changing size
[ ] Add pitch option


Flag for preserving driver pods that failed to start

Brainstorming some flag names for that:
--preserve-pods
--keep-driver-pod
--preserve-driver-pod
Would we want this flag to keep the pod around even if it launched and finished its job successfully? Maybe some folks will want to look at logs afterwards for debugging, though kubectl logs might preserve those anyway so no need to keep successful pods just for logs.
See discussion at https://github.com/apache-spark-on-k8s/spark/pull/11#discussion_r95709753

Maybe the right thing to do is to not cleanup pods at all. The biggest issue is that we cannot reuse the app name unless we delete the succeeded/failed driver pod, but that can be solved simply by using an auto-generated suffix as the driver pod name. The successful and failed pods should get eventually cleaned up by the pod garbage collector, and keeping them around ensures we always have access to the logs. I think currently we trigger pod garbage collection at 12500 successful/failed pods.

The auto-generated suffix should have the submission timestamp, so that we can tell drivers apart. kubectl get pods -a shows the entire list of pods which are in failed/succeeded state. So, the action items if we go with this will be:

At the end of the spark job, exit driver container.
Clean up secret and service.

@ash211 can we close this? We do not delete completed pods as of now, and that seems like the right thing to do as well.

@foxish we do delete executor pods, but leave driver pods as completed.  This makes difficult for me to read logs from the deleted executor pods when debugging (to get the name since it doesn't show even with kubectl get pods).  Seems like we should either delete both driver/executor pods or leave them both as completed.
Or can logs be read from deleted pods and we just need to make getting executor pod names easier?

@ash211 logs cannot be accessed from pods after they are deleted. They can be accessed from completed pods (ending in state succeeded/failed).
In my opinion, since we need access to stdout, the driver pods should always be preserved (in succeeded/failed state), till it is eventually cleaned up by the GC. If the executor logs are important for debugging, we should introduce a flag to not delete them in specific at the end of the SparkJob. Does that make sense?

Filed changing the way we stop executor pods as https://github.com/apache-spark-on-k8s/spark/issues/125
This issue for leaving the driver pod around was filed quite a bit ago and I don't think is relevant anymore now that we are able to get logs with kubectl logs <pod-name> which was only introduced in https://github.com/apache-spark-on-k8s/spark/pull/13
Closing


add telemetry | collect usage information

What problem does this PR solve?
Add telemetry function.
When the telemetry collection feature is enabled, usage information will be shared, including(but not limited to):

A randomly generated telemetry ID.
OS and hardware information, such as OS name, OS version, CPU, memory, and disk.
A part of TiSpark configuration.

What is changed and how does it works?
The telemetry default is on.
And it can be closed in configuration, such as spark.tispark.telemetry.enable = flase .
Telemetry will work at injecting Spark rule in com.pingcap.tispark.telemetry.TelemetryRule. And each Spark application only sends a telemetry message once even if sending fails.
The collection entry will be sent by Restful API to the telemetry server.
Here is a simply telemetry-report example.
// build Telemetry
val telemetry = new Telemetry

// make TeleMsg
val teleMsg = new TeleMsg(sparkSession)

// report msg to server by HTTP post
telemetry.report(teleMsg)

TeleMsg entry would be transformed to JSON, such as
{
  "track_id" : "trkid_7178a3d8-da26-41ca-a7a3-00e165877bda",
  "time" :<PHONE_NUMBER>,
  "hardware" : {
    "os" : "Ubuntu",
    "disks" : [ {
      "name" : "/dev/nvme0n1",
      "size" :<PHONE_NUMBER>92
    } ],
    "version" : "20.04.4 LTS (Focal Fossa) build 5.13.0-41-generic",
    "cpu" : {
      "model" : "11th Gen Intel(R) Core(TM) i7-1160G7 @ 1.20GHz",
      "logicalCores" : 8,
      "physicalCores" : 4
    },
    "memory" : "Available: 1.7 GiB/15.4 GiB"
  },
  "instance" : {
    "tispark_version" : "2.5.0-SNAPSHOT",
    "tidb_version" : "v5.4.0",
    "spark_version" : "3.0.2"
  },
  "configuration" : {
    "spark.tispark.plan.use_index_scan_first" : false,
    "spark.tispark.index.scan_concurrency" : 5,
    "spark.tispark.type.unsupported_mysql_types" : "",
    "spark.tispark.plan.allow_index_read" : true,
    "spark.tispark.request.command.priority" : "LOW",
    "spark.tispark.request.isolation.level" : "SI",
    "spark.tispark.show_rowid" : false,
    "spark.tispark.plan.allow_agg_pushdown" : false,
    "spark.tispark.isolation_read_engines" : "tikv",
    "spark.sql.auth.enable" : false,
    "spark.tispark.coprocessor.chunk_batch_size" : 1024,
    "spark.tispark.index.scan_batch_size" : 20000,
    "spark.tispark.coprocess.codec_format" : "chblock",
    "spark.tispark.coprocess.streaming" : false
  }
}

Suggested review order：

TiExtensions.scala
TelemetryRule.scala
Telemetry.scala
TeleMsg.scala
all that remains

Tests

Unit test

Side effects

Possible performance regression
Increased code complexity

Related changes

Need to update the documentation
Need to update the tidb-ansible repository
Need to be included in the release note

/run-all-tests

Plz list the exact information which would be collected in the description.

ReadMe has been changed , fix the conflict. you can add the doc in wiki

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/hold

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/merge

/unhold

/merge


[web] flutter_service_worker.js routine downloadOffline is broken

To reproduce:

Start a new project with web support
Replace the script in index.html with this code

    if ('serviceWorker' in navigator) {       window.addEventListener('flutter-first-frame', function () {         navigator.serviceWorker.register('flutter_service_worker.js')         .then((reg) => {              navigator.serviceWorker.controller.postMessage('downloadOffline');         });       });     }

Build the web project
Access build/web/index.html through a web server, and refresh the page to get the service worker to run downloadOffline.
Look at the network log in the browser.  Instead of loading real resource files, the service worker attempts to download files named "0" through "14".

I have uploaded the result of steps 1-3 to my web site at https://www.bradchristie.com/sample_web_project/
The bug is one line in downloadOffline,
  for (var resourceKey in Object.keys(RESOURCES)) {
should be
  for (var resourceKey of Object.keys(RESOURCES)) {

@bradchristie
Please provide flutter doctor -v.

@bradchristie
Please provide flutter doctor -v.

For development I'm using beta 1.24 because of #72627, I also checked the current beta 1.25 and the issue is there as well.
`  ╔════════════════════════════════════════════════════════════════════════════╗
║ A new version of Flutter is available!                                     ║
║                                                                            ║
║ To update to the latest version, run "flutter upgrade".                    ║
╚════════════════════════════════════════════════════════════════════════════╝
[√] Flutter (Channel beta, 1.24.0-10.2.pre, on Microsoft Windows [Version 10.0.19042.685], locale en-US)
• Flutter version 1.24.0-10.2.pre at P:\flutter
• Framework revision 022b333a08 (7 weeks ago), 2020-11-18 11:35:09 -0800
• Engine revision 07c1eed46b
• Dart version 2.12.0 (build 2.12.0-29.10.beta)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at p:\programs\AndroidSDK
• Platform android-30, build-tools 30.0.2
• ANDROID_HOME = p:\programs\AndroidSDK
• ANDROID_SDK_ROOT = p:\programs\AndroidSDK
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Android Studio (version 4.1.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] IntelliJ IDEA Community Edition (version 2020.3)
• IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2018.3
• Flutter plugin version 52.1.5
• Dart plugin version 203.6912
[√] Connected device (5 available)
• SM T580 (mobile)                   • 520010335ba39425 • android-arm    • Android 8.1.0 (API 27)
• Android SDK built for x86 (mobile) • emulator-5554    • android-x86    • Android 8.0.0 (API 26) (emulator)
• Web Server (web)                   • web-server       • web-javascript • Flutter Tools
• Chrome (web)                       • chrome           • web-javascript • Google Chrome 87.0.4280.88
• Edge (web)                         • edge             • web-javascript • Microsoft Edge 87.0.664.66
• No issues found!`

For development I'm using beta 1.24 because of #72627, I also checked the current beta 1.25 and the issue is there as well.
`  ╔════════════════════════════════════════════════════════════════════════════╗
║ A new version of Flutter is available!                                     ║
║                                                                            ║
║ To update to the latest version, run "flutter upgrade".                    ║
╚════════════════════════════════════════════════════════════════════════════╝
[√] Flutter (Channel beta, 1.24.0-10.2.pre, on Microsoft Windows [Version 10.0.19042.685], locale en-US)
• Flutter version 1.24.0-10.2.pre at P:\flutter
• Framework revision 022b333a08 (7 weeks ago), 2020-11-18 11:35:09 -0800
• Engine revision 07c1eed46b
• Dart version 2.12.0 (build 2.12.0-29.10.beta)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at p:\programs\AndroidSDK
• Platform android-30, build-tools 30.0.2
• ANDROID_HOME = p:\programs\AndroidSDK
• ANDROID_SDK_ROOT = p:\programs\AndroidSDK
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Android Studio (version 4.1.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] IntelliJ IDEA Community Edition (version 2020.3)
• IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2018.3
• Flutter plugin version 52.1.5
• Dart plugin version 203.6912
[√] Connected device (5 available)
• SM T580 (mobile)                   • 520010335ba39425 • android-arm    • Android 8.1.0 (API 27)
• Android SDK built for x86 (mobile) • emulator-5554    • android-x86    • Android 8.0.0 (API 26) (emulator)
• Web Server (web)                   • web-server       • web-javascript • Flutter Tools
• Chrome (web)                       • chrome           • web-javascript • Google Chrome 87.0.4280.88
• Edge (web)                         • edge             • web-javascript • Microsoft Edge 87.0.664.66
• No issues found!`

flutter doctor -v
[✓] Flutter (Channel beta, 1.25.0-8.1.pre, on Mac OS X 10.15.4 19E2269
    darwin-x64, locale en-IN)
    • Flutter version 1.25.0-8.1.pre at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 8f89f6505b (3 weeks ago), 2020-12-15 15:07:52 -0800
    • Engine revision 92ae191c17
    • Dart version 2.12.0 (build 2.12.0-133.2.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (2 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11
      (API 30) (emulator)
    • Chrome (web)                • chrome        • web-javascript • Google
      Chrome 87.0.4280.88

• No issues found!

flutter doctor -v
[✓] Flutter (Channel beta, 1.25.0-8.1.pre, on Mac OS X 10.15.4 19E2269
    darwin-x64, locale en-IN)
    • Flutter version 1.25.0-8.1.pre at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 8f89f6505b (3 weeks ago), 2020-12-15 15:07:52 -0800
    • Engine revision 92ae191c17
    • Dart version 2.12.0 (build 2.12.0-133.2.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (2 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11
      (API 30) (emulator)
    • Chrome (web)                • chrome        • web-javascript • Google
      Chrome 87.0.4280.88

• No issues found!

@ferhatb PR landed. Close this?

@ferhatb PR landed. Close this?


JsonBlobService tweaks:

JsonBlobService.list accepts includeValue argument.
Revert recent commit to parse value in formatForJSON (7780cffb6cc40d04d5c61b4f13e6abc68b53f16c) - it wasn't compatible with the rest admin panel. Instead, parse json values in the client service.

See corresponding hoist-react PR: https://github.com/xh/hoist-react/pull/2071

See new hoist-react PR: https://github.com/xh/hoist-react/pull/2073


Add batch_process tool

Overview
A development helper to make processing a CSV a bit more convenient for developers.
Demo
$ ./tools/batch_process 16
[+] Running 1/0
 ⠿ Container open-apparel-registry-database-1  Running                                                                                0.0s
parse: 2 successes
[+] Running 1/0
 ⠿ Container open-apparel-registry-database-1  Running                                                                                0.0s
geocode: 2 successes
[+] Running 1/0
 ⠿ Container open-apparel-registry-database-1  Running                                                                                0.0s
INFO:api.matching:Rebuilding gazetteer
INFO:dedupe.api:reading training from file
INFO:dedupe.training:Final predicate set:
INFO:dedupe.training:(SimplePredicate: (commonTwoTokens, address), SimplePredicate: (sameSevenCharStartPredicate, name))
INFO:dedupe.training:(SimplePredicate: (sameSevenCharStartPredicate, address), SimplePredicate: (wholeFieldPredicate, country))
INFO:dedupe.training:(SimplePredicate: (commonIntegerPredicate, address), SimplePredicate: (sameFiveCharStartPredicate, name))
INFO:rlr.crossvalidation:using cross validation to find optimum alpha...
INFO:rlr.crossvalidation:optimum alpha: 0.100000, score 0.4985716877424044
INFO:dedupe.training:Final predicate set:
INFO:dedupe.training:(SimplePredicate: (commonSixGram, name), SimplePredicate: (sameSevenCharStartPredicate, address))
INFO:dedupe.training:(SimplePredicate: (commonIntegerPredicate, address), SimplePredicate: (sameFiveCharStartPredicate, name))
INFO:dedupe.training:(SimplePredicate: (commonThreeTokens, name), SimplePredicate: (fingerprint, name))
INFO:api.matching:Indexing started
INFO:api.matching:Indexing finished (0:00:00.095603)
INFO:api.matching:Cleanup training
INFO:dedupe.api:0 records
match: 2 successes

Testing Instructions

Upload a list and note the list id
Run ./tools/batch_process {id} and verify that it completes without error.

Checklist

[ ] fixup! commits have been squashed
[ ] CI passes after rebase
[ ] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Thanks for the review. I added the script to the "Tools" section of the README in a rebase.


Update openapi

Numerous changes that need to be tested as prerelease - 5.4 introduced many fixes we need

@craicoverflow there is huge difference in content between 5.4.0 and 5.2.0 but overall changes are small/code semantics changed. I have tried and tested kafka version and it seems to be working fine.


File name

:P

I always forget about that :)
On Thu, Mar 2, 2017 at 3:34 PM, designatednerd<EMAIL_ADDRESS>wrote:
@designatednerd approved this pull request.
Derp! Thanks Jimmy :)
And yeah when you change the name of the file, it changes the name of the file itself and then changes the references to it in the .xcodeproj file as well, so you've gotta commit both or it won't build.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [https://github.com/designatednerd/GoCubs/pull/1#pullrequestreview-24847740] , or mute the thread [https://github.com/notifications/unsubscribe-auth/ALS0IcxKfG63DviB04QPNQlB-CJaCrTLks5rhzQtgaJpZM4MRgYj] .


Detection of DLC in library

I don't know if it's a bug on my side, or a feature missing, but as far as I can tell, no DLC is detected in my library.
As a consequence, the filter to hide owned items only works for games, and leaves all DLC displayed.
In case it's a limitation of the Steam API, perhaps a workaround would be to let us import a list of our owned contents (using a copy/paste from userdata comes to my mind).
This way, we could easily filter to query only missing DLC from games we own (right now, I get the whole list of DLC, including the ones I already have, so this is not really efficient).

Install the extension, it does exactly this.


Elastic subnets CLI docs

Docs PR Template
Why this should be merged
Elastic Subnets for CLI documentation
How this works
documentation changes only
How these changes were tested
no tests
Workflow checks

[x] ran vale /docs/file/path on all changed .md files to ensure all grammar rules pass
[x] ran markdownlint /docs/file/path on all changed .md files to ensure all linting rules pass
[x] completed the above two checks and all additional rules outlined in style-checker-notes.md to
ensure all checks pass
[x] if a doc was removed/deleted, the path to that doc must be redirected to a valid URL via the
_redirects file
[x] all files that were moved from their current directory to a new path have had their paths
redirected via the _redirects file
[x] _redirects were manually verified with the cloudflare preview link
[x] sidebars.json reflects all changes made to file path

The checklist in the PR template will help with fixing the lint/vale issues that are preventing the build from passing

the doc being added is more about transforming a Subnet into an Elastic Subnet, rather than creating one. The information being merged should Ideally be added to docs.avax.network/subnets/create-a-mainnet-subnet instead of creating a new page.
Please integrate the changes into the existing page.

Elastic subnets are a big feature, however, this document does not include any background/explanatory information on the topic. This doc a series of How-to's written with the expectation that the reader already:

knows what an Elastic subnet is
has already deployed a permissioned subnet

The title misleads the user to believe that they could create an elastic subnet from scratch. This information would be better if available to users who already satisfy the above criteria.
If kept as is, this document needs to be appropriately renamed, and moved to a better section than "How to use the Avalanche-CLI".
I understand this tab is in need of a major re-organization, and that this process is more tedious than it should be. I am actively working to plan and build a better structure for our docs. I will ping you a link to the future plan for reference.


Normalize WSClient JSON output (RIPD-1095)

Normalize WSClient JSON output:
JSON returned from the WSClient is normalized to resemble JSON-RPC
output, to make unit tests agnostic to the transport used.

Current coverage is 69.60%

Merging #1615 into develop will not affect coverage as of 76c611f

@@            develop   #1615   diff @@
=======================================
  Files           908     908
  Stmts         67393   67406    +13
  Branches          0       0
  Methods           0       0
=======================================
+ Hit           46909   46916     +7
  Partial           0       0
- Missed        20484   20490     +6

Review entire Coverage Diff as of 76c611f

Powered by Codecov. Updated on successful CI builds.

:+1: Looks reasonable to me...

:+1: Code looks good and I compared with what's in JSONRPCClient.cpp

Merged as c37261858ac193536230179923f0bc03c7285e71


Allbridge button

Add allbridge link button to dashboard of pools with usdc, backstop, and menu

Did we want it on the backstop page?
I thought it was just dash, hamburger, asset?


python.pkgs: hypothesis, pylibmc, ldap, pylint: minor build fixes

Motivation for this change
Quite a bit of breakage in python packages at the moment. This fixes some of the smaller things but I don't expect a nox-review to be successful for this due to all the other breakage.
Among things getting changed here is conversion of a couple of packages to fetchPypi - have pypi dropped an old url scheme lately? Getting a lot of 404s all of a sudden from non-fetchPypi packages.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Getting a lot of 404s all of a sudden from non-fetchPypi packages.

That's not good. Can you tell whether these are packages that have been updated recently, more specifically, in https://github.com/NixOS/nixpkgs/commit/6b999f3c42607342231b6fe119fcf0f934f40fd8?

Yup, all of them. The fact that they're working with fetchPypi made me just think "well, that's clearly why we're switching..."


support: Remove contact email and shorten plan status strings for remote activity.

Notes:

Removes the contact email from the remote activity table. This can be accessed via the support view link.
Shortens the plan status text strings, which are currently primarily used here.

Screenshots and screen captures:

Updated plan status string on support view

Updated remote activity page

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Let's not drop the email right now. I'm finding it quite useful.

Sounds good. I've dropped that commit from these changes. Therefore, this is only changing the plan status strings to be slightly shorter. Will update the title of the GitHub PR for this change as well.

"New plan scheduled" would be shorter, and should be clear enough?

Made that tweak and merged, thanks @laurynmm and @alya!


Independent spinbox arrow step precision

Rebase of #33743
Bugsquad Edit: Implements godotengine/godot-proposals#226.

@KoBeWi should be ok now

I understand why this is needed, but I would probably do the following changes:

Rename "arrow_step" to "custom_arrow_step"
Would use it when != 0.0 , not with max/min

I think with these two changes, the workings should be more intuitive.

I think it should be ok now @reduz

Thanks!

Thank you for this! Love seeing someone taking good care of this feature :)


How to create a new distributed database in OrientDB using Scala API?

OrientDB Version: 3.0
Java Version:
openjdk version "1.8.0_161"
OpenJDK Runtime Environment (build 1.8.0_161-b14)
OpenJDK 64-Bit Server VM (build 25.161-b14, mixed mode)
I installed a distributed version of OrientDB on two instances and executed ./bin/dserver.sh on both of them.
------------+
|Name               |Status|Databases             |Conns|StartedOn|Binary           |HTTP             |UsedMemory              |
+-------------------+------+----------------------+-----+---------+-----------------+-----------------+------------------------+
|123_slave(*)|ONLINE|demodb=ONLINE (MASTER)|4    |13:47:29 |<IP_ADDRESS>:2424|<IP_ADDRESS>:2480|506.22MB/3.83GB (12.90%)|
|123(@)      |ONLINE|demodb=ONLINE (MASTER)|0    |13:47:15 |<IP_ADDRESS>:2424|<IP_ADDRESS>:2480|424.32MB/3.83GB (10.81%)|
+-------------------+------+----------------------+-----+---------+-----------------+-----------------+------------------------+

Now I want to create a database using Scala API.  This is the way that I found in the documentation of OrientDB:
val uri: String = "plocal:target/database/GRAPH_1"
val graph: OrientGraph = new OrientGraph(uri)

In my case I have two instances. So, how should I specify the uri string?

Hello,
I'm not a scala expert but when you're running in distributed mode you will likely connect remotely. so that should be: 'remote:<IP_ADDRESS>/database/GRAPH_1'

Ok that's about as much as I could help you with my orient knowledge. I'll ping @luigidellaquila

Ok, below I provide the code that does not actually create a database, but it expects that the database is already created. My question is how can I create the database from code:
val uri: String = "remote:<IP_ADDRESS>/database/ACCESO_GRAPH_TEST"
val username: String = "root"
val password: String = "123"
val factory: OrientGraphFactory = new OrientGraphFactory(uri, username, password)
val graph: OrientGraph = factory.getTx()

Hi @LianaNapalkova
Please, try to remove the database/ from the URL, it's not needed and probably it's creating the problem.
So just
val uri: String = "remote:XXX.XX.XX.XX/GRAPH_TEST"

If it still fails, could you please the full logs of the client and the node you are connecting to?
Thanks
Luigi

Hi @LianaNapalkova
Did my suggestion help? Do you still need help on this issue?
Thanks
Luigi

I will check it during this week and report the result.

Hi @luigidellaquila,
I am testing now this code with OrientDb for docker. The uri is defined as follows:
val uri: String = "remote:<IP_ADDRESS>/GRAPH_TEST"
But I still cannot create the database GRAPH_TEST. I am getting the java.lang.NullPointerException error, because graph is null.
This is how I create oriented container.
  orientdb:
      image: orientdb:2.2.33
      container_name: orientdb
      command: server.sh
      ports:
        - "2424:2424"
        - "2480:2480"
      environment:
        - "ORIENTDB_ROOT_PASSWORD=123"
      restart: "no"


added FAQ functionality

Description
Added FAQ section (no content)
FAQ questions can be added as individual files to /_faqs/ with this structure:
---
question: What colour is the sky?
category: General
---

The sky is blue.

Issues Resolved
Resolves #31
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@dblock / @lornajane Thoughts on this structure?


Problem with set_heart() in class R_Impact

When the value of set_heart(int value) is upper to 1 that's cause a bug when the polygons is calling like show_polygons()
Pretty sure the problem is from build_polygon()

too much work too fix it, we remove the possibility to set the level of the heart size.


Hotfix/Issue 584

This change is

Codecov Report

Merging #597 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #597   +/-   ##
=========================================
  Coverage     58.14%   58.14%
  Complexity    18682    18682
=========================================
  Files          1932     1932
  Lines         99432    99432
  Branches      10101    10101
=========================================
  Hits          57817    57817
  Misses        38539    38539
  Partials       3076     3076

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e548a62...003fe5a. Read the comment docs.

Reviewed 35 of 36 files at r1, 32 of 32 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


Add credentials to HTTP resolver

Changes
This adds the ability to pass credentials to the HTTP resolver when fetching the URL.
This let the user for example fetch a task from another SCM private repositories on another SCM providers than the one configured with the git resolver.
Fixes #7296
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[X] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[X] Has Tests included if any functionality added or changed
[X] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[X] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[X] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
The http resolver supports passing username and password for fetching URLs with basic credentials

/kind feature

Thanks!
/lgtm


in address tab, jump at random icon stopped transmitting requests to geocoder

I turned on Chrome network monitor and no request was sent to geocoder when I pressed jump-at-random icon. This happened after I entered a few addresses in Victoria and Metchosin and pressed jump and view in GM icons a few times.
A workaround is to click the X icon then hit * again. Seems that icon state is getting lost somehow.

I've already found and fixed this one locally since the last delivery.

In delivery now.

Verified in test.