Clean up listings and ratings indexes; fixes #381

As per @hoffmabc's request.

@JustinDrake this is probably better to just put a check on the slug when saving that it cant be named index rather than refactoring the structure of the directory.

Why accumulate technical debt in the protocol at this early stage (pre-release)? Separation of concerns in the listings and ratings folder is clearly superior than the current approach.

Coverage remained the same at 28.225% when pulling e35101dd6bfc52baac96e82cab53cb9dd9bb72f6 on JustinDrake:indexes into 29162e472331bef83220284eaa26cbc4bce380b3 on OpenBazaar:master.

I don't know what you mean. Those folders are already separated. This now sticks listing data in two separate folders... the root and the listing folder.

I mean that the listings folder does precisely one thing, namely store listings.

I support the proposal but have not reviewed the PR (it was assigned to Chris so I never checked it out).
@cpacia What do you think? I don't mind reviewing the PR if you'd rather not but do you have a yay or nay on the concept? Or more discussion?

I don't mind revisiting later, but it doesn't seem like an imperative change at this time. We would need a rebase to revisit as well.


error nuking and resetting aggregate branch with path based tag

$ git fetch --tags
Reset staging to builds/master/2017-06-01-13-46-46? (y/n) y
$ git diff builds/master/2017-06-01-13-46-46...staging --name-only db/migrate
fatal: ambiguous argument 'builds/master/2017-06-01-13-46-46...staging': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
/Users/ryansonnek/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/gitx-3.0.1/lib/gitx/executor.rb:23:in `block in execute': git diff builds/master/2017-06-01-13-46-46...staging --name-only db/migrate failed (Gitx::Executor::ExecutionError)
	from /Users/ryansonnek/.rbenv/versions/2.4.1/lib/ruby/2.4.0/open3.rb:205:in `popen_run'
	from /Users/ryansonnek/.rbenv/versions/2.4.1/lib/ruby/2.4.0/open3.rb:190:in `popen2e'
	from /Users/ryansonnek/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/gitx-3.0.1/lib/gitx/executor.rb:14:in `execute'
	from /Users/ryansonnek/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/gitx-3.0.1/lib/gitx/cli/base_command.rb:26:in `run_cmd'
	from /Users/ryansonnek/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/gitx-3.0.1/lib/gitx/cli/base_command.rb:32:in `run_git_cmd'
	from /Users/ryansonnek/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/gitx-3.0.1/lib/gitx/cli/nuke_command.rb:37:in `migrations_need_to_be_reverted?'
	from /Users/ryansonnek/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/gitx-3.0.1/lib/gitx/cli/nuke_command.rb:18:in `nuke'
	from /Users/ryansonnek/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/thor-0.19.4/lib/thor/command.rb:27:in `run'
	from /Users/ryansonnek/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in `invoke_command'
	from /Users/ryansonnek/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/thor-0.19.4/lib/thor.rb:369:in `dispatch'
	from /Users/ryansonnek/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/thor-0.19.4/lib/thor/base.rb:444:in `start'
	from /Users/ryansonnek/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/gitx-3.0.1/bin/git-nuke:6:in `<top (required)>'
	from /Users/ryansonnek/.rbenv/versions/2.4.1/bin/git-nuke:22:in `load'
	from /Users/ryansonnek/.rbenv/versions/2.4.1/bin/git-nuke:22:in `<main>'

not able to reproduce.


Issue with sticky header

Hey,
I have an issue using the plugin sticky-headers: when scrolling down, the map goes over the header, see below

Can you check if the changes on PR #13 fix the issue for you?

@dmandrade yes it is ! Thanks


Consider adding flow?

My thinking is that it is more of a tool than an architecture.
It can also just exist without affecting those who don't want to use it. i.e. it won't break anything if you write code without the annotations.
It's nice to have it set up from the get go.

I may add this to the "-opinionated" extension.  This starter is finally stabilising I feel, so it's a good time to do a bigger extension.

Decided to add it in the end.  Flow is so beautifully unobtrusive.  It can exist without breaking anything even if you don't want to continue its use throughout your project.


ci: improve security (github actions)

Make sure github actions does not have admin rights over this repo (or any celestiaorg repos for that matter).

Thank you to @liamsi for making GA read-only.


name 'Collection' is not defined

Hello
following your notebook in this repo I couldn't define create_head function because of the error:
NameError: name 'Collection' is not defined
Do you know where Collection is defined? Is it part of fastai ?

Hi,
yes, Collection definitely was part of fastai. I cannot look into this right now, because of lack of time, but please remind me if this problem persists.


Fixed geolite2 import

Determining country from IP address is an optional feature.
geolite2 was being imported directly ignoring the usecase
that it might not be installed.
geolite2 import has been moved to the get_contry_code method
inside try-except block.

@PetrDlouhy @Alir3z4 what do you think about this PR?

Codecov Report

Merging #166 (1bd2b4c) into master (6e0748c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   82.40%   82.40%
=======================================
  Files           8        8
  Lines         125      125
=======================================
  Hits          103      103
  Misses         22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b6a633...1bd2b4c. Read the comment docs.

@pandafy Did you revert the commit? The final diff seems to be blank.

@PetrDlouhy yes I did. 😅
One of the CI build was failing and it seemed like an unrelated issue. I wanted to verify if it broke due to my changes. I have removed the revert commit now.
Can you help me understand why this build is failing https://github.com/django-getpaid/django-plans/runs/5733296866?check_suite_focus=true ?

I am not sure. It might be that VIES system has again problems with connection.

I had opened an issue for this, I also banged my head on this. Thank you @pandafy for fixing it!
https://github.com/django-getpaid/django-plans/issues/157

I hope this can be merged too since it's breaking projects using this app unless they install this optional dependency.

@Alir3z4 @PetrDlouhy ping!


Infinite auto on simulation?

Is it possible for it to run simulation without stopping?
mine always stops after 1 game of simulation.

Thanks for raising this issue, it's caused by a recent update of the game. A new version will be released soon with the fixes to this specific problem.

The update has been released on v1.4.4, please let me know if the issue persists.

Serious bug on simulation. It starts selecting the sector and difficulty and it looks at this

and then it thinks that the simulation is cleared already and goes back home.
2024-01-01 18:55:40,951 - INFO - succesfully detected app window 2024-01-01 18:55:42,032 - INFO - Simulation room started... 2024-01-01 18:56:04,336 - INFO - Could not start simulation 2024-01-01 18:56:44,044 - INFO - Simulation room started... 2024-01-01 18:56:56,704 - INFO - starting simulation run difficulty 4 sector c... 2024-01-01 18:57:06,342 - INFO - Sector cleared, ignoring clear is set to false, exiting... 2024-01-01 18:57:06,345 - INFO - Simulation room ended. 2024-01-01 18:57:06,348 - INFO - Exiting to home... 2024-01-01 18:57:24,010 - INFO - Exited to home succesfully 2024-01-01 18:57:44,347 - INFO - Simulation room started... 2024-01-01 18:57:57,002 - INFO - starting simulation run difficulty 4 sector c... 2024-01-01 18:58:06,621 - INFO - Sector cleared, ignoring clear is set to false, exiting... 2024-01-01 18:58:06,625 - INFO - Simulation room ended. 2024-01-01 18:58:06,629 - INFO - Exiting to home... 2024-01-01 18:58:24,306 - INFO - Exited to home succesfully

Hmm from what I see on the image it seems like you've already cleared sector 4C and you are trying to redo 4C? Is that the intended behavior? If yes then you should check the option in the settings to "打过也重打" and it'll ignore whether that sector has been completed or not.

ahh I didn't know about that one. I'm going to test it right now.

hello, it works fine now but how do I prevent it from stopping after simulation end / clear? like it being on repeat?

Unfortunately the app was not originally designed to have repeat. If you want to repeat for certain achievements (not sure if it's still possible now), you could simply assign a mouse macro to repeat it.

I see, how unfortunate. Thank you for the app and the update anyways!


cloud.google.com/go/pubsub has outdated dependencies?

In relation to #483, It looks like cloud.google.com/go/pubsub pulls in outdated dependencies which don't actually build.
In this case, all that needs to be done is manually updating github.com/golang/protobuf/proto and google.golang.org/grpc, but there's no indication in any documentation I've come across that this needs to be done - I had to puzzle it out from the source code consts that are thrown out when the build errors occur after importing the pubsub package.
Given that many that will be using this package won't necessarily be using any of it's dependancy packages directly, it would make sense to have this noted down somewhere?

How did you update your dependencies?
After changing your google.golang.org/cloud/{PKG} imports to cloud.google.com/go/{PKG}, you should have been able to run:
go get -u ./...

from within your go project.
As noted on #483 , this change was made last August, and was announced on the google-api-go-announce google group as well as in the gophers slack (https://gophers.slack.com/archives/google-cloud/p1470694566000044).
But I'm sorry that this message did not reach you :(.
@jba thoughts about putting a line on the README.md, eg:
(previously "google.golang.org/cloud")?

I was using gb vendor to pull the dependencies. Perhaps it's an issue with vendor? I've never seen it run into this kind of issue before, however.
I don't necessarily mind the change of naming convention in the pubsub package, it's more that there has to be a better way of fixing this then having someone go through the source code of a bunch of recursive-required packages they're not even using just to get google's official pubsub package to build. Seems a bit janky.
As for Gophers... that's fine at the time, but running google searches on the errors typically doesn't go into the depths of the Slack channel ;)

Hm. The import paths within all the google cloud code (including the pubsub package) were updated months ago. The only explanation for this behavior is that you had old versions of your proto and grpc packages locally.
This problem has not been reported by anyone else in the months since this change has taken place. I must conclude that this was a fluke, possibly with gb. Perhaps gb was fetching dependencies in the wrong order? It's hard to say.


include waived status, justification, and expiration date on csv export

Signed-off-by: Victoria Jeffrey<EMAIL_ADDRESS>:nut_and_bolt: Description: What code changed, and why?
include waived status, justification, and exp date on csv
:chains: Related Resources
https://github.com/chef/automate/issues/3853
:+1: Definition of Done
waiver info in the csv report
:athletic_shoe: How to Build and Test the Change
rebuild compliance
load_compliance_reports
download csv report, see waiver data
:white_check_mark: Checklist

[x] I have read the CONTRIBUTING document.
[x] Tests added/updated?
[n/a] Docs added/updated?
[x] All commits have been signed-off for the Developer Certification of Origin.

the JSON is added by default?

im gonna go double check, but im pretty sure it's already added - bc we return the full report and this information is already on the full report to be able to display in ui

❓ Do we care for compatibility here? Something written against the JSON export probably would just ignore extra fields, tools consuming CSV might choke on the new columns...

tools consuming CSV might choke on the new columns

do you mean if someone has built something themselves around the expected format of our csv export?

@vjeffrey yup, that possibility.

hmmm. i don't know that we've ever promised compatibility on the csv reports -- i'm not sure how we could support that? do you have an idea in mind @srenatus ?

Oh I was just wondering. Let's call it out in the release notes so people aren't caught by surprise, maybe?
If we wanted to do that, we'd have versioned endpoints as one possibility. Not a small fix, though, I guess. Or have the client pass in a list of desired columns, defaulting to the set we had before.

i would love to one day change our apis so that more of them accept "desired fields returned" kinda thing, i opened an issue about that a while ago: https://github.com/chef/automate/issues/2147. but ya - bigger change. one day! 🤞


[Request] See remaining credits

Would it be possible to add in the ability to see the remaining credits on an account?
This would allow users to keep track of their remaining balance without having to re-log into the service every time they want to check.
Thanks!

That's a great idea. I'll keep this issue open and will work on that feature in the future.
Mind it's a side project (of a side project), so I can't promise it'll be done by me soon. I'm open to pull requests if someone would like to implement it :)


Pretrain on custom dataset without labels

I am looking to pretrain a model on images for which labels are not available/defined. For that, I'm trying to replicate the DataLoader for other datasets in the catalog (like cifar10), but it seems the methods are implemented to return labels along with the images. Could you please guide on how/what to tweak in order to make the training pipeline work without labels?

Hey,
At the moment, the easiest way would be to just return -1 for all labels. Those are ignored when training the linear classifier, so I think you will be good. I'm not sure, but an error might arise in the evaluation part of the code. If it does, I would simply create dummy labels for your data.
We are working on making an interface for custom datasets that will handle that.

Support for custom datasets has been added in #103


Add the Nadam optimizer

Nadam is Adam with Nesterov's correction. It is recommended by the Deep Learning Tuning Playbook.
This PR adapts @AntoinePlumerault's excellent work in https://github.com/deepmind/optax/pull/529 to

Pass the tests, by tree mapping, safe incrementing, and reducing learning_rate in alias_test.
Not include an extra b2 scale factor on the second moment estimate.
This multiplier only appears in the 2016 OpenReview paper, and I believe it might be a typographic error because I see no explanation. Other versions also exclude it.
Document the mathematical form we implement.
The versions linked above differ by their "bias correction" factors go. This implementation matches Torch and Keras (for constant b1).

In this PR, we:

Add the Nadam transform and optimizer alias.
Make minor tidy-ups: remove some inconsistent whitespace, place scale_by_lion alphabetically.

Merges #570 so that tests pass.
Ticks one off #507

hey @Rupt , any reason why this PR got closed? perhaps by mistake?

Hi @fabianp, I was just cleaning up after I got the impression that this project was inactive on the public (outside-google) site.
I am more than happy to re-open this if there is interest.

Excellent! A bunch of us are working hard on reviving the project and creating a vibrant community around it (not just for Googlers!) 🤗 . We're working on solving a big backlog of issues, and this one is very high on our priority list
if you reopen the issue I think we can get it merged real quickly 🚀

That's great news! Thank you for saying. I'll try to have a got at that this evening.

Excellent. Just to be clear, I just need to you to reopne this PR (I can't do that myself). Then I can take care of the last polishing before merging

reopening

OK I think I understand now better why I can't reopen the PR. The branch Rupt:nadam seems to be deleted. Hope you can get back the code easily @Rupt (but of course no rush)!

Redone in #719. Indeed, I made the mistake of deleting this branch, but I am glad that you've raised it again. :)


Support for BRPOP and BLPOP

Hi,
I saw the notes/redis.md file and I'm wondering if the unsupported commands are somethin that you are working on it or not. Just to know if the (near?) future these commads like BRPOP e BLPOP will be supported.
Thanks
M

any update?

It's very likely the decision to leave it out was deliberate on the part of the original maintainers - it was documented that the command is not supported.
If twemproxy has 200 clients and a small number of redis servers, and one of them issues a BRPOP or BLPOP, then 199 other clients will see an unexpected pause of an unknown length (for commands forwarded to the same server), possibly even seconds, causing an unexpected delay and adversely impacting the overall host/application performance, in a reason that those 199 clients have no visibility into.

Currently, I believe twemproxy only supports a single server connection, even if the configuration allows more than one connection to a backend server.
This would manifest as random pauses and would make twemproxy appear to be extremely unreliable
Application authors would need to know what twemproxy's timeouts were, in order to make sure that a lower timeout was passed to BLPOP, etc.

As a workaround, it's already possible to call BLPOP/BRPOP in lua scripting (eval) if you're sure that your use case has timeouts properly configured or won't have adverse performance impact from blocking commands interfering with non-blocking commands.

In theory, separate server connections could be allocated for use exclusively with blocking commands, but that goes against the current design, and is difficult to implement correctly in C


Files are still created although it was showing error

It is still creating files under the migrations folder

Although it was showing error, it was creating the file in the background. I am not sure about that now. :(


Feat - Added ToggleMute optional targeting

I think I got it now :p Thanks for the patience.
Added in the ability to target a specific input with ToggleMute.
Target is optional; if none is supplied, mutes 'Mic/Aux' instead.
Shouldn't break existing scripts or implementations.
Added summary doc comment for --help.

Codecov Report
Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 0.0%. Comparing base (986fdf5) to head (7ba4211).

Additional details and impacted files

Files
Coverage Δ

src/main.rs
0.0% <0.0%> (ø)

Released in 0.1.2 :tada:


Change directory of admin API unit tests

Purpose

The purpose of this PR is to fix #51
Goals

Move the unit tests of admin apis to the admin/ directory
Approach

Moved the test controllers to a new directory
Kept the common program unit tests outside the directory
Previous structure:
├── controller
│   ├── MenteeControllerTest.java
│   ├── MentorControllerTest.java
│   └── ProgramControllerTest.java
└── service
    ├── MenteeServiceTest.java
    ├── MentorServiceTest.java
    └── ProgramServiceTest.java
New structure:
├── controller
│   ├── admin
│   │   ├── MenteeControllerTest.java
│   │   ├── MentorControllerTest.java
│   │   └── ProgramControllerTest.java
│   └── ProgramControllerTest.java
└── service
    ├── MenteeServiceTest.java
    ├── MentorServiceTest.java
    └── ProgramServiceTest.java
Checklist

[x] This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
[x] I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

Related PRs

N/A
Test environment

Ubuntu 19.04
OpenJDK 1.8
Learning

N/A

Resolved conflicts. Please review and merge


Update firebase-admin release links

I noticed the links for the firebase-admin releases were wrong in the doc.
This PR updates it.

Thanks for your contribution


Cannot load such file — octopress/docs/hooks

When I run the octopress command octopress docs, I got the following error:

~/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/octopress-3.0.0/lib/octopress/docs.rb:223:in `require': cannot load such file -- octopress/docs/hooks (LoadError)

from ~/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/octopress-3.0.0/lib/octopress/docs.rb:223:in `load_docs'

from ~/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/octopress-3.0.0/lib/octopress/commands/docs.rb:25:in `serve_docs'

from ~/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/octopress-3.0.0/lib/octopress/commands/docs.rb:16:in `block (2 levels) in init_with_program'

from ~/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `call'

from ~/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `block in execute'

from ~/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `each'

from ~/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `execute'

from ~/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/mercenary-0.3.5/lib/mercenary/program.rb:42:in `go'

from ~/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/mercenary-0.3.5/lib/mercenary.rb:19:in `program'

from ~/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/octopress-3.0.0/bin/octopress:10:in `<top (required)>'

from ~/.rbenv/versions/1.9.3-p0/bin/octopress:23:in `load'

from ~/.rbenv/versions/1.9.3-p0/bin/octopress:23:in `<main>'

It looks like something is missing for my ruby. But I don't know what it exactly requires? What is the 'octopress/docs/hooks'?
Thank you in advance.

I'm not sure why it wouldn't be able to access that file, it's this line which it is complaining about. @parkr do you know of any reason why this would be happening?

@imathis  Thanks for reply. The similar error also occurs when I tried to use octopress new post to create a new blog page.

/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/octopress-3.0.0/lib/octopress/commands/new.rb:52:in `block (3 levels) in init_with_program': cannot load such file -- octopress/post (LoadError)

I'm thinking the problem may be caused by the ruby environment setting, but not sure how to fix it.

Do you have gem "octopress" in your Gemfile? If not, add that and try bundle exec octopress docs.

@imathis it works after modified the gemfile. Thank you.

Was just going to report this separately but I found this issue. I am having the same problem (also Octopress 3.0), but my gemfile does contain  gem "octopress" in it (here).
octopress new draft, octopress doc, etc. don't work unless I call them with bundle exec. I am not very experienced with Ruby (sorry, I know you're probably sick of noob problems), so my little bit of debugging involved printing $: in octopress.rb:
C:/Ruby193/lib/ruby/gems/1.9.1/gems/toml-0.1.2/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/colorator-0.1/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/jekyll-2.5.3/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/octopress-3.0.11/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/colorator-0.1/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/yajl-ruby-1.2.1/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/pygments.rb-0.6.3/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/hitimes-1.2.2-x86-mingw32/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/timers-4.0.1/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/celluloid-0.16.0/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rb-inotify-0.9.5/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/listen-2.7.8/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/jekyll-watch-1.2.1/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/fast-stemmer-1.0.2/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/classifier-reborn-2.0.3/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/jekyll-2.5.3/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/titlecase-0.1.1/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/octopress-escape-code-2.0.6/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/octopress-3.0.11/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/mercenary-0.3.5/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/safe_yaml-1.0.4/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/liquid-2.6.2/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/kramdown-1.8.0/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/blankslate-<IP_ADDRESS>/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/parslet-1.5.0/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/toml-0.1.2/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/jekyll-paginate-1.1.0/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/jekyll-gist-1.2.1/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/jekyll-coffeescript-1.0.1/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/coffee-script-2.4.1/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/execjs-2.5.2/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/coffee-script-source-<IP_ADDRESS>/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/jekyll-sass-converter-1.3.0/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sass-3.4.16/lib
C:/Ruby193/lib/ruby/site_ruby/1.9.1
C:/Ruby193/lib/ruby/site_ruby/1.9.1/i386-msvcrt
C:/Ruby193/lib/ruby/site_ruby
C:/Ruby193/lib/ruby/vendor_ruby/1.9.1
C:/Ruby193/lib/ruby/vendor_ruby/1.9.1/i386-msvcrt
C:/Ruby193/lib/ruby/vendor_ruby
C:/Ruby193/lib/ruby/1.9.1
C:/Ruby193/lib/ruby/1.9.1/i386-mingw32

and again where autoloading of draft.rb fails in new.rb:
C:/Ruby193/lib/ruby/gems/1.9.1/gems/fssm-0.2.10/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/colorator-0.1/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/coffee-script-2.4.1/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/execjs-2.5.2/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/coffee-script-source-<IP_ADDRESS>/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/classifier-reborn-2.0.3/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/fast-stemmer-1.0.2/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/chunky_png-1.3.4/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/celluloid-0.16.0/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/timers-4.0.1/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/hitimes-1.2.2-x86-mingw32/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/blankslate-<IP_ADDRESS>/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/RedCloth-4.2.9-x86-mingw32/lib
C:/Ruby193/lib/ruby/gems/1.9.1/gems/RedCloth-4.2.9-x86-mingw32/lib/case_sensitive_require
C:/Ruby193/lib/ruby/gems/1.9.1/gems/RedCloth-4.2.9-x86-mingw32/ext
C:/Ruby193/lib/ruby/gems/1.9.1/gems/bundler-1.6.3/lib
C:/Ruby193/lib/ruby/site_ruby/1.9.1
C:/Ruby193/lib/ruby/site_ruby/1.9.1/i386-msvcrt
C:/Ruby193/lib/ruby/site_ruby
C:/Ruby193/lib/ruby/vendor_ruby/1.9.1
C:/Ruby193/lib/ruby/vendor_ruby/1.9.1/i386-msvcrt
C:/Ruby193/lib/ruby/vendor_ruby
C:/Ruby193/lib/ruby/1.9.1
C:/Ruby193/lib/ruby/1.9.1/i386-mingw32

As you can see, the octopress/jekyll gems are no longer in the path at lazy-load time.
I also printed the trace of the failure:
C:/Ruby193/lib/ruby/gems/1.9.1/gems/octopress-3.0.11/lib/octopress/commands/new.rb:72:in `block (3 levels) in init_with_program': cannot load such file -- octopress/draft (LoadError)
        from C:/Ruby193/lib/ruby/gems/1.9.1/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `call'
        from C:/Ruby193/lib/ruby/gems/1.9.1/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `block in execute'
        from C:/Ruby193/lib/ruby/gems/1.9.1/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `each'
        from C:/Ruby193/lib/ruby/gems/1.9.1/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `execute'
        from C:/Ruby193/lib/ruby/gems/1.9.1/gems/mercenary-0.3.5/lib/mercenary/program.rb:42:in `go'
        from C:/Ruby193/lib/ruby/gems/1.9.1/gems/mercenary-0.3.5/lib/mercenary.rb:19:in `program'
        from C:/Ruby193/lib/ruby/gems/1.9.1/gems/octopress-3.0.11/bin/octopress:8:in `<top (required)>'
        from C:/Ruby193/bin/octopress:23:in `load'
        from C:/Ruby193/bin/octopress:23:in `<main>'

I also tried switching out the autoload statements in octopress.rb with explicit require statements and this fixed the immediate problem (though the same error was then thrown when Jekyll classes could not be found).


Problem patching polymorphic linked relationships

Using Active Record's polymorphic association example, let's say your app has the following model relationships:
class Picture < ActiveRecord::Base
  belongs_to :imageable, polymorphic: true
end

class Employee < ActiveRecord::Base
  has_many :pictures, as: :imageable
end

class Product < ActiveRecord::Base
  has_many :pictures, as: :imageable
end

A GET request to /employees/1 might return:
{
  "links": {
    "employees.pictures": "http://api.example.com/pictures/{employees.pictures}"
  },
  "employees": [{
    "id": "1",
    "name": "Johnny Appleseed",
    "links": {
        "pictures": [ "3", "4" ]
    }
  }]
}

A GET request to one of the pictures (/pictures/3) might return:
{
  "links": {
    "pictures.imageable": "http://api.example.com/imageable/{pictures.imageable}"
  },
  "pictures": [{
      "id": "3",
      "name": "Johnny Appleseed.jpg",
      "links": {
        "imageable": "1"
      }
  }]
}

The problem here is that the "imageable" link's ID is ambiguous – we don't know if it's linking to an employee or product resource.
Now, if we're just going to retrieve the "imageable" relationship, we don't really need to know whether it's an employee or product. If we really did care, our link could be more specific:
{
  "links": {
    "pictures.imageable": "http://api.example.com/employees/{pictures.imageable}"
  }
}

The real problem arises when trying to update the picture's "imageable" link.
A PATCH request to change the picture's "imageable" link is impossible with just the ID:
PATCH /pictures/3

[
  { "op": "replace", "path": "/pictures/0/links/imageable", "value": "28" }
]

We don't know what type the "28" ID belongs to, that is, is it an employee or a product? Right now, document IDs are not globally unique, but scoped to the document's type.
How can we describe polymorphic link relationships? It doesn't look like relying solely on IDs is sufficient – we're missing any notion of the resource's type. Using GUIDs is one option (at leat a poor man's GUID of :id-:type), but this would require larger changes for implementers' backend.

This issue is no longer relevant with the current version of the spec.


How can ibrik be used with mocha?

We have a suite of Mocha tests and I'm looking for a coverage tool to determine how thorough our tests are.  Any idea how Mocha can integrate with ibrik?  Thanks.

@justin-lau @duereg  sorry for reviving this - i am trying to figure out how to get this istanbul fork to work since this still hasn't been merge upstream. When I try the command you listed @justin-lau I still get "No coverage information output was collected, exit without coverage information"
Can either of you perhaps help me out with this ? :) thanks.

@gilligan You figured this out, correct?

@duereg yep thanks ;-)

Just wanted to drop a note mentioning that coffee-coverage has support for Istanbul instrumentation now, and it was designed from the ground up with mocha in mind.

Got the answer of ibrik:
$ ibrik cover _mocha -- test/*.coffee

Demo:
https://travis-ci.org/59naga/jasminetea/builds/65687751


Support multi-part/mixed content type in Azure.Core

See https://github.com/Azure/azure-sdk-for-python/pull/7083

Done 1.0.0b4


How do I create a user using laravel passport?

I clone the larapi repo and installed the dependencies successfully then I made following request using curl:
curl -X POST -H 'Content-Type: application/json' -d '{"user": {"email"<EMAIL_ADDRESS>"name": "A user", "password": "12345678"}}'  http://apis.mydomain.dev/users
server returns following response:
{
   "status":"error",
   "code":0,
   "message":"Unauthenticated.",
   "exception":"Illuminate\\Auth\\AuthenticationException: Unauthenticated. ......."
   "line":66,
   "file":"project/vendor/laravel/framework/src/Illuminate/Auth/Middleware/Authenticate.php"
}

@ak-incaendo you missed this step
php artisan users:add Esben<EMAIL_ADDRESS>1234

How about user registration from the client

You need to create public routes in your User component.
/Users
   /Controllers
   / ...etc
   /Services
   /routes.php
   /routes_public.php <--- does not require authentication

In routes_public.php
<?php

$router->post('/register', 'UserController@register');

And then you just create a registration method and so forth. Then from your client (example with jquery or similar):
$.post('/register', {
  email<EMAIL_ADDRESS>  password: '1234'
});


Header + Icon; unwanted new line for a particular icon ("content")

Bug Report
Steps
A simple usage of Header + Icon, taken from the examples. But modified the icon name to content.
    <Header as="h2">
      <Icon name="content" />
      <Header.Content>
        Account Settings
        <Header.Subheader>Manage your preferences</Header.Subheader>
      </Header.Content>
    </Header>

Expected Result
Correct alignment like in:

Actual Result
A new line is inserted, so the icon is no more aligned.

Version
0.88.2
Testcase
https://codesandbox.io/s/semantic-ui-react-r1469

Hello I would like to work in this, is it still available?

@cristian-spiescu this is an issue with the CSS and I can confirm it is also present in the parent Semantic UI project where all of our styles come from. Since this is a CSS issue from the upstream parent project, I am closing this report as we have no control over those styles.
@solmalisani if you want to work on a solution to that issue with the CSS, you could submit a PR to the parent project. 🙌

I opened an issue in Fomantic UI: https://github.com/fomantic/Fomantic-UI/issues/1620

Just use an alias icon name bars or sidebar
    <Header as="h2">
      <Icon name="bars" />
      <Header.Content>
        Account Settings
        <Header.Subheader>Manage your preferences</Header.Subheader>
      </Header.Content>
    </Header>

Thanks! So it seems to be particular only to the icon named content, which is kind of special and used in a lot of places in the CSS.


Provide option to override SEMP VendorID

This helps if someone wants to migrate e.g. from SAE to EVCC without the need to re-register the charger in the SMA backend

Habs nochmal angehübscht


Disable swipe conditionally

I would like to disable left swipe or right swipe according to a condition.
This way, you can't move forward until a condition is satisfied.
Is that possible?
Thanks.

Hi @carlosrc ,
Have you tried using allowsHitting?

I don't find that configuration... I try Pager(...).allowsHitting(...), but looks like Pager doesn't have this property.

Hi @carlosrc ,
Sorry, I meant allowsHitTesting:

@fermoya it works, but is there a way to disable only left or right swipe?
This would be useful, for example, in an app where you have to fill a form before going to the next screen, but you can always go back.

Hi @carlosrc ,
I get you, you want to disable the swiping but not the interaction with the page. I'll add a modifier for this, I'll keep you posted

Thanks!

Hi @carlosrc , I just released version 1.5.0-beta.1. Give it a try, I'll release 1.5.0 within the next days if everything looks fine

Released version 1.5.0. Use disableDragging or allowsDragging(shouldDrag)

Perfect! Great work @fermoya , and thanks for your quick response :)


Build hadoop only when needed

Check image.yaml, when src/hadoop-run/hadoop is in the copy-list, build hadoop-ai, else skip hadoop-ai. Fixes #720 .
Move 'tag()' into the 'build()', now the base_image could be tagged. Fixes #747 .

@ydye , @haowu, please take a look.

Will figure it out in another PR, close it now.


[app_store_build_number/latest_testflight_build_number ] Export version in SharedValues

This adds the version as second export parameter to the mentioned actions. This
is useful when the live version is queried.
Fixes: #15735
Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
See linked issue.
Description
See commit message.
Testing Steps
Run the two actions.

@googlebot unfortunately does not agree - or the CLA label would have switched to green and yes. Different email address than commits maybe?

Uh, does that also change the return value of the actions and thus be a breaking change for existing users?

@janpio, no, the return value of the actions is still the build number. I only changed the return value of an internal (at least I hope it's internal) method to also include the version string.

Ah right, missed that line.
We're using ostruct in other places as well, so this should be fine.


Remove Hackpad

Hackpad references should be removed since it is defunct.

I believe @isaacchansky just did this.


fix for Safari 7 polyfill detection

I get the following error on Ipad safari 7
TypeError: 'undefined' is not a valid argument for 'in' (evaluating ''Promise' in this')
An example detector is :
"Promise" in this
However 'this' is undefined on iPad
Changing the detector call to be
.call(window, main)
ensures that 'this' is window

@cameronbraid You accidentally opened this pull request in your own fork, to merge your fix into your own master branch (instead of merging it from your fork into my project). Therefore I wasn't notified by GitHub about this PR.
Anyways, I worked on a new release and also hit this issue. It is now fixed in version 1.0.0.


added INRIA pedestrian dataset

@bmagyar Could you please help me to review this patch?

Looks good to me! :+1:
I didn't spot any dependencies on other (possibly unmerged) work at all, all clean!

Thanks!

:+1:


Add support for the v0.4.0 Gateway API

There is a new version of Gateway API https://github.com/kubernetes-sigs/gateway-api/releases/tag/v0.4.0
The Gateway API APIGroup has moved from networking.x-k8s.io to gateway.networking.k8s.io which is not supported by the current version of cert-manager. There might be other changes that are not supported as well.
See a Challenge object:
Status:
  Presented:   false
  Processing:  true
  Reason:      the server could not find the requested resource (post httproutes.networking.x-k8s.io)
  State:       pending
Events:
  Type     Reason        Age                  From          Message
  ----     ------        ----                 ----          -------
  Normal   Started       18m                  cert-manager  Challenge scheduled for processing
  Warning  PresentError  8m23s (x8 over 18m)  cert-manager  Error presenting challenge: the server could not find the requested resource (post httproutes.networking.x-k8s.io

Describe the solution you'd like

Please add support for v0.4.0
/kind feature

Hello!
Which implementation of the Gateway API are you using? I have started work on this but will need to update the e2e tests before it can be merged.
/assign
/priority important-soon

Hi, we have it on production with the latest stable Istio. And also Contour in the latest beta  https://github.com/projectcontour/contour/releases/tag/v1.20.0-beta.1 supports the Gateway API 0.4.0 as well.

Support has been merged now, so will be in the next alpha release, or you can try it now by building your own images as with make images


Automated cherry pick of #6197

Cherry pick of #6197 on release-5.27.
/cc  @sudheerDev

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 0ef2bfd43c43c30c2b3c4cb066778db3660cd3ce


Networking Issues: Zeppelin cannot fetch dependencies

Hi, and thank you for this repo it is incredibly useful!
However, I'm having problems running your notebook. I'm not really sure what exactly the problem is (so sorry from the ramblings below) as I've tried a number of different things and getting different issues even after reverting all changes back to your exact code.
Initially, upon executing the notebook, everything apart from the consumer seemed to work. I could see messages being written to the Kafka topic in Grafana. However, the consumer complained that it didn't have the Kafka dependency available.
I found that the Kafka JAR hadn't been downloaded, as indicated in the image below of Zeppelin's interpreter page:

I couldn't even wget the JAR from inside the Zeppelin container (I believe the request timedout).  However, now (after reverting my changes) it seems I can wget in the container, but Zeppelin is still unable to fetch them itself.
Putting aside the network issue, I've tried to manually add the dependency using:
%sh
mkdir /zeppelin/dep
cd /zeppelin/dep && wget https://repo1.maven.org/maven2/org/apache/spark/spark-streaming-kafka-0-8_2.11/2.0.2/spark-streaming-kafka-0-8_2.11-2.0.2.jar

%producer.dep
z.reset()
z.load("/zeppelin/dep/spark-streaming-kafka-0-8_2.11-2.0.2.jar")

%consumer.dep
z.reset()
z.load("/zeppelin/dep/spark-streaming-kafka-0-8_2.11-2.0.2.jar")

but now the producer times out when connecting to Kafka:
KafkaTimeoutErrorTraceback (most recent call last)
<ipython-input-6-49d1d1bf1849> in <module>()
     20         topic=KAFKA_TOPIC,
     21         key=str(row_dict["_c0"]).encode("utf-8"),
---> 22         value=json.dumps(row_dict).encode("utf-8"))
     23
     24     try:

/opt/conda/lib/python2.7/site-packages/kafka/producer/kafka.pyc in send(self, topic, value, key, headers, partition, timestamp_ms)
    562         key_bytes = value_bytes = None
    563         try:
--> 564             self._wait_on_metadata(topic, self.config['max_block_ms'] / 1000.0)
    565
    566             key_bytes = self._serialize(

/opt/conda/lib/python2.7/site-packages/kafka/producer/kafka.pyc in _wait_on_metadata(self, topic, max_wait)
    689             if not metadata_event.is_set():
    690                 raise Errors.KafkaTimeoutError(
--> 691                     "Failed to update metadata after %.1f secs." % (max_wait,))
    692             elif topic in self._metadata.unauthorized_topics:
    693                 raise Errors.TopicAuthorizationFailedError(topic)

KafkaTimeoutError: KafkaTimeoutError: Failed to update metadata after 60.0 secs.

This is all on a fresh set of containers (docker-compose down && docker-compose up -d).
Any help would be greatly appreciated!

I think the Kafka servers may have gotten in a twist due to excessively bringing them up/down.  Deleting the kafka/kafka_zookeeper Docker volumes seems to have fixed the KafkaTimeoutError raised by the producer but now I'm getting an error again with the consumer:
ERROR:root:Exception while sending command.
Traceback (most recent call last):
  File "/zeppelin/interpreter/spark/pyspark/py4j-0.10.4-src.zip/py4j/java_gateway.py", line 883, in send_command
    response = connection.send_command(command)
  File "/zeppelin/interpreter/spark/pyspark/py4j-0.10.4-src.zip/py4j/java_gateway.py", line 1040, in send_command
    "Error while receiving", e, proto.ERROR_ON_RECEIVE)
Py4JNetworkError: Error while receiving

Py4JErrorTraceback (most recent call last)
<ipython-input-8-63c862b08c08> in <module>()
     17                             ssc,
     18                             [REDDIT_TOPIC],
---> 19                             {"metadata.broker.list": KAFKA_BROKERS})
     20
     21 stream = stream.map(lambda x: json.loads(x[1]))

/zeppelin/interpreter/spark/pyspark/pyspark.zip/pyspark/streaming/kafka.py in createDirectStream(ssc, topics, kafkaParams, fromOffsets, keyDecoder, valueDecoder, messageHandler)
    128             func = funcWithoutMessageHandler
    129             jstream = helper.createDirectStreamWithoutMessageHandler(
--> 130                 ssc._jssc, kafkaParams, set(topics), jfromOffsets)
    131         else:
    132             ser = AutoBatchedSerializer(PickleSerializer())

/zeppelin/interpreter/spark/pyspark/py4j-0.10.4-src.zip/py4j/java_gateway.py in __call__(self, *args)
   1131         answer = self.gateway_client.send_command(command)
   1132         return_value = get_return_value(
-> 1133             answer, self.gateway_client, self.target_id, self.name)
   1134
   1135         for temp_arg in temp_args:

/zeppelin/interpreter/spark/pyspark/pyspark.zip/pyspark/sql/utils.py in deco(*a, **kw)
     61     def deco(*a, **kw):
     62         try:
---> 63             return f(*a, **kw)
     64         except py4j.protocol.Py4JJavaError as e:
     65             s = e.java_exception.toString()

/zeppelin/interpreter/spark/pyspark/py4j-0.10.4-src.zip/py4j/protocol.py in get_return_value(answer, gateway_client, target_id, name)
    325             raise Py4JError(
    326                 "An error occurred while calling {0}{1}{2}".
--> 327                 format(target_id, ".", name))
    328     else:
    329         type = answer[1]

Py4JError: An error occurred while calling o66.createDirectStreamWithoutMessageHandler

Note this is using my code above to add the JAR to the consumer.dep interpreter.
I've seen some other people with what looks like the same problem (see https://stackoverflow.com/questions/58975545/azure-databricks-kafkautils-createdirectstream-causes-py4jnetworkerroranswer) and they've suggested upgrading the JAR. I've tried editing the Zeppelin interpreters to use the newer "spark-streaming-kafka-0-8_2.11-2.4.5.jar" but this results in the same set of issues.

I am facing with the same issues. Have you resolved it @gregbrowndev yet?

Using the assembly solved the issue:
%sh
cd /zeppelin/dep && wget https://repo1.maven.org/maven2/org/apache/spark/spark-streaming-kafka-0-8-assembly_2.11/2.0.2/spark-streaming-kafka-0-8-assembly_2.11-2.0.2.jar

%consumer.dep
z.reset()
z.load("/zeppelin/dep/spark-streaming-kafka-0-8-assembly_2.11-2.0.2.jar")

@dotdothu sorry for the late reply! Glad you managed to fix it.
I added the Jar manually, just like you did, but never quite got it completely working. I still had issues with the consumer: "Py4JError: An error occurred while calling o66.createDirectStreamWithoutMessageHandler"

@gregbrowndev I added your library files to spark dep. below is my entire operation
%sh
mkdir /zeppelin/dep
cd /zeppelin/dep && wget https://repo1.maven.org/maven2/org/apache/spark/spark-streaming-kafka-0-8-assembly_2.11/2.0.2/spark-streaming-kafka-0-8-assembly_2.11-2.0.2.jar
cd /zeppelin/dep && wget https://repo1.maven.org/maven2/org/apache/spark/spark-streaming-kafka-0-8_2.11/2.0.2/spark-streaming-kafka-0-8_2.11-2.0.2.jar
cp /zeppelin/dep/spark-streaming-kafka-0-8_2.11-2.0.2.jar /zeppelin/interpreter/spark/dep
cp /zeppelin/dep/spark-streaming-kafka-0-8-assembly_2.11-2.0.2.jar /zeppelin/interpreter/spark/dep
and
%producer.dep
z.reset()
z.load("/zeppelin/dep/spark-streaming-kafka-0-8_2.11-2.0.2.jar")
%consumer.dep
z.reset()
z.load("/zeppelin/dep/spark-streaming-kafka-0-8-assembly_2.11-2.0.2.jar")

@gregbrowndev I added your library files to spark dep. below is my entire operation
%sh
mkdir /zeppelin/dep
cd /zeppelin/dep && wget https://repo1.maven.org/maven2/org/apache/spark/spark-streaming-kafka-0-8-assembly_2.11/2.0.2/spark-streaming-kafka-0-8-assembly_2.11-2.0.2.jar
cd /zeppelin/dep && wget https://repo1.maven.org/maven2/org/apache/spark/spark-streaming-kafka-0-8_2.11/2.0.2/spark-streaming-kafka-0-8_2.11-2.0.2.jar
cp /zeppelin/dep/spark-streaming-kafka-0-8_2.11-2.0.2.jar /zeppelin/interpreter/spark/dep
cp /zeppelin/dep/spark-streaming-kafka-0-8-assembly_2.11-2.0.2.jar /zeppelin/interpreter/spark/dep
and
%producer.dep
z.reset()
z.load("/zeppelin/dep/spark-streaming-kafka-0-8_2.11-2.0.2.jar")
%consumer.dep
z.reset()
z.load("/zeppelin/dep/spark-streaming-kafka-0-8-assembly_2.11-2.0.2.jar")


Npm dependencies from package.json do not work in Pull requests

npm deps work in file view

but don't it PR view

btw thanks for awesome work

Thanks for filling this issue. Unfortunately it's a know issue 😞 I was writing the release notes on an airplane, so I missed to mention it there. I will try to explain why it isn't working in the PR view.
Let's start with the structure of the package.json file. Every dependency is declared within a subtree like dependecies or devDependecies. There are other subtrees like scripts, repository and many others. To differentiate between them, the extension does a JSON parse on the blob so I can use the json representation of this blob to get the dependencies name.
This approach requires a valid json representation which is never the case in a PR. During develop this feature I spend a couple of weeks and various chat with others to find a better solutions how to identify dependencies in git patch.
Do you have any idea? If so please let me know.

I'm not super familiar with the internals of octolinker but could we leverage the github api to get the full blob of the file for parsing?

That would be a great way to do it, @koddsson! You'd probably want to have readLines call getPath, to find the filename, then use a github API to fetch the full contents.

I made some good progress on this today. I'm using the raw url to fetch the underlying full blob. There is just one issue left. Unchanged lines get not linked on the right hand side just on the left.

@Strajk it's out 😃


[FEATURE] make bot parse the whole command where applicable

Right now every command only check the beginning of each command for the right command (-thanks).
In the cases where the users intention to use the command is clear (ie thanks) the bot should invoke the command.
So far the thanks command is the biggest and only viable change
Requested by Adimant.

If command modules had a standardized member (perhaps named aliases) containing a collection of aliases, the commandHandler could refer to those aliases when deciding if a command should be invoked or not. That would keep us on track for a scalable implementation to command invocation.


Reduce bandwidth on RPCs by having arguments be single letter

Hi!
Just a proposal as I was reading through https://github.com/jonathaneeckhout/jdungeon/blob/main/documentation/networkingsync.md  which has some interesting info on Godot RPCs;
Godot sends the full argument name over the network when performing an RPC call.
While this makes the code a bit less readable, changing arguments to 1 letter should reduce the size of RPCs sent over network and improve bandwidth; You can always rename the arguments once received to something more readable or add a comment to make sure the code is easily maintainable.

You may also note that argument names for these functions are a single letter. This is intentional due to Godot needing to send argument names when performing RPCs.

Thank you for sharing this. That's awful lol, I will go open a godot proposal for this
As for the rest of this issue, netfox with forest-brawl as tutorial must be as readable as possible, given the complexity of rollback. I think this optimization shoud be project-specific instead of being automatically applied to all RPC calls.
That said, this optimization does have merit, so in the docs, or in some comment, there should be a suggestion to use single-letter RPC parameters :+1:

As explained in https://github.com/godotengine/godot-proposals/issues/10885 the statement is wrong.
Godot does not send the arguments names, nor the function name.
The RPC sends:

The Node Network ID OR the node path (only if the node path has not been already exchanged)
The function ID (reason why RPCs must match between server and client)
The argument count
The argument values

Thanks for the note @warsang and thanks @Faless for clearing this up! Browsing around the code a bit seems to confirm this. Also created https://github.com/jonathaneeckhout/jdungeon/issues/262 so they can update their docs if wanted.


to() docs page doesn't indicate what it returns

The to() documentation doesn't indicate what it returns.  It seems to return whatever went into it, to allow you to pipe the output of the to() somewhere else, or to do some additional processing on it.  If that's the design decision I'm fine with it, but I would suggest that this page should explicitly state that.  (Apparently it also drops null timestamps - if we can confirm that, then that fact should be documented as well).
Relevant URLs

https://docs.influxdata.com/flux/v0.x/stdlib/influxdata/influxdb/to/
Provide other relevant URLs (project issues, community threads, etc.)

Thanks @wz2b. to() returns the input stream unmodified, so you can perform further processing. I'll add this to the documentation.
Information about null timestamps is already noted in the documentation: https://docs.influxdata.com/flux/v0.x/stdlib/influxdata/influxdb/to/#output-data-requirements


Right Click Option Not Showing in 1.9.1

In issue (https://github.com/cweijan/vscode-mysql/issues/4#event-3271741329) it was noted that the right click option was added, but this is not visible in 1.9.1.
Originally posted by @cweijan in https://github.com/cweijan/vscode-mysql/issues/4#issuecomment-618436835

change active db is appear on sql editor context menu.


Added enableSonatypeOpenSourceSnapshotsRep property

Vert.x Snapshots are published to the Sonatype's new infra for OSS projects.
This allow to run tests with, for example '-PenableSonatypeOpenSourceSnapshotsRep -PvertxVersion=4.1.0-SNAPSHOT'

Thanks, I will try this soon

THanks @tsegismont !
I've rebased this on a new branch that I will push on hibernate/hibernate-reactive or merge if ready
(I still haven't checked all the the changes).

@DavideD great! Which is the new branch?

This is the branch: https://github.com/hibernate/hibernate-reactive/tree/wip/mssql


Plot transfer to NFS is really slow

Hi Everyone,
from a network perspective and interfaces perspective on all my servers, nothings has been changed.
I have moved only from Official-Chia plotter to MadMax, what I see is that copying/moving the plots are really slow.

as you can see, the biggest spike yesterday is when it was still on the official plotter. (1gpbs)
the others are now around the 50-200Mbps, which makes it really slow.
Any idea what could be the issue here?

which commit are you at? I increased the block size for copy recently, in hopes to increase NTFS performance, see 67da6828801dcc56c57e36af78bf8da867aaed0a

On windows, I was using NFS, and I found that if I re-niced chia_plot to 'below normal', my tx speed increased form 300mbps to 700mbps.

which commit are you at? I increased the block size for copy recently, in hopes to increase NTFS performance, see 67da682

commit a2e06b01ae71b2a5811fa853d57abfd14c78a003 (HEAD -> master, origin/master, origin/HEAD)
Author: Max<EMAIL_ADDRESS>Date:   Mon Jun 21 15:43:34 2021 +0200

ah you mean NFS, I've been using that too without any issues...

ah you mean NFS, I've been using that too without any issues...

Haha yes!
2 NFS servers are pointed from 10 virtuals on different hardware. Somehow/something was impacted but Im not sure what exactly. Half of the servers are now on the official and half with yours. I will check later on today what the outcome is and try to tweak a bit more. Hopefully it was just an error somewhere...


Fix test email faker

I want to merge this change because... it fixes test email faker to fix failing e2e tests.

Screenshots
It replaces the following email whitespaces:

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

Task linked: CU-7pr5x2 E2E tests fails due to usage of wrong email addresses.


hide textblock sort option when there is only 1 textblock available

You should also update the CHANGELOG.md


Heap-buffer-overflow in wvtest with ASAN

Hi, developers of WavPack:
Recently, I test the binary wvtest instrumented with ASAN. Unfortunately, it incurred a crash with the following error information.

Hi, and thanks for reporting this!
The problem was that the seektest expects a valid WavPack file, not the output of a fuzzer. It's purpose is to test the seeking function of libwavpack with varying, but valid, files. In this case the WavPack file was longer than its header indicated, which we were not checking for when reading the file. I have pushed a fix for this, but there could certainly be other bugs in the tester, not to mention memory leaks.
Since wvtest is not a user-facing program, or even available in any distribution, I do not consider this a security issue. And I also believe that even if a bug was found in the libwavpack seeking code, it would not be a great security risk either because of the difficulty of triggering it outside of the lab.

As you have analyzed, this is a small bug rather than a security vulnerability. Thank you very much for fixing it.


Feat/adding oci chart releaser

PR Type
enhancement, configuration changes

Description

Introduced a new GitHub Actions workflow to automate the release of Helm charts using OCI registry.
Configured the workflow to include steps for checking out the repository, installing Helm, and managing chart dependencies.
Utilized helm-oci-chart-releaser action to push charts to the GitHub Container Registry.
Updated the Helm chart version in Chart.yaml to 0.1.0-RC3.

Changes walkthrough 📝
Relevant filesEnhancement

release.ymlAdd GitHub Actions workflow for Helm chart release

.github/workflows/release.yml
Added a new GitHub Actions workflow for releasing Helm charts.  Configured steps to checkout code, install Helm, and manage dependencies.  Integrated helm-oci-chart-releaser for pushing charts to OCI registry.

+35/-0

Configuration changes

Chart.yamlUpdate Helm chart version

Chart.yaml

Updated chart version from 0.1.0-RC1 to 0.1.0-RC3.

+1/-1

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

/help


Functions on parameters using existential parameters

@rachitnigam and I discussed this in a meeting, but the addition of existential parameters by #121 enables creating components used only for operating on parameters.
For example, we can now do the following to implement pow2:
comp Pow2[N]<'G: 1>() -> () with {
    exists K;
} where K > 0, N >= 0 {
    if N == 0 {
        exists K = 1;
    } else {
        P := new Pow2[N-1]<'G>();
        exists K = P.K;
    }
}

This is a pretty cool observation as it allows us to do arbitrarily complex computation on parameters without making the compiler any more complicated, but still has some caveats:

The assumptions necessary for type checking are currently not added using this, so such an implementation cannot be used somewhere that needs to be validated at that point in compilation (I.E. ReduceAdd or equivalent).
These functions are components, so we cannot use them simply as functions on parameters, and can only define them in component bodies (though the existential parameters can likely be accessed outside of that scope, @rachitnigam correct me if I am wrong here).

This also allows us to use the constraints on K to generate assumptions in our parent component, which is also a nice observation (although assume already exists, so this may be less important). This is not really an issue, but just recording some of the possibilities with existential parameters, and maybe we could add some syntactic sugaring to this to make some cool features in the future.

The code in the example is not quite right. If we want to compute K = 2^N, then we have to do:
comp Pow2[N]<'G: 1>() -> () with {
    exists K where K > 0;
} N >= 0 {
    if N == 0 {
        exists K = 1;
    } else {
        P := new Pow2[N-1]<'G>();
        exists K = 2 * P.K;
    }
}

Apart from that, yeah, this is a cool capability. Essentially, forall parameters act as inputs to components and existentials are "outputs". The notable thing about this component is that it doesn't actually do anything at runtime; it's more like a "type-level" function whose only goal is to produce a new type based on a given type.
The reason this encoding is interesting (and tractable) is because while the computations on parameters can be arbitrary, the type system doesn't know about it. That is, even though, mathematically, we have the constraint that K == 2^N, the only fact exposed to the type system is that K > 0 so users of this parameter can only rely on this knowledge.

A relevant reading here is liquid types which also allow for reasoning of predicates over types in a decidable manner. Maybe one way to decide which functions (like pow2 and log2) make into the core language is keeping the language fragment decidable.

Is there anything actionable with this issue?

Fstar has a similar idea with the Lemma return type that they use to describe libraries of helpful axioms: https://github.com/FStarLang/FStar/blob/master/ulib/FStar.Math.Lemmas.fst#L66


I do even want to start

https://github.com/xbony2/Nuclear-Control/blob/master/src/main/java/shedar/mods/ic2/nuclearcontrol/tileentities/TileEntityThermo.java#L219
.... Exp api is more then enough... Please change that to IReactor instead of a Exp Releated only Class which i can not support...

That change was made because using IReactor would crash the game. From what I can tell, a 5x5x5 reactor does not cast to IReactor. See #114 for crash and reason for revert

why are you checking the chamber which has no logic at all.... Also this causes incompatiblity with classic......

The chamber exposes the functions needed for the panel. Does Classic have a 5x5x5 reactor? If so, does it all cast from IReactor?

ok. All the reflection part was on my side a bad idea. I agree with that. But still everything is accessable through the API:
https://github.com/xbony2/Nuclear-Control/blob/e82a22933dcfa5b3531156017e4e1b23d205bbed/src/main/java/shedar/mods/ic2/nuclearcontrol/items/ItemCard55Reactor.java
Line 54: can be returned through IReactor: produceEnergy()
Line 55-56: Cast it as a IFluidHandler and get the fluidTank info. first tank you get is the input tank second is the output.
Only thing where you require Exp is simply the EmitHeat...
But for that you could use a Proxy which prevents Exps Data to coilide with classic...

the 5x5x5 is just a normal reactor with a casing no code change... Its still the basic reactor... And yeah IC2 Classic supports IReactor without any problems as the 5x5x5 reactor from Ic2Exp... Just that it is a normal reactor with a casing... Its still uses the IReactor API...

i'll try to patch in something, I have an idea of how to do them both


Potential downsampling artifact to investigate

Details: https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/11251

Still valid and help wanted 🤗


Update README.md

Hey, ended up adding this because there were a few other places that needed the features/docs updated. Thanks for the effort though!


please remove the suport of mysql,mssql,sqlite in the higher version

60 | ERROR | Extension 'sqlite' is removed since PHP 5.4
72 | ERROR | Extension 'sqlite' is removed since PHP 5.4
89 | ERROR | Extension 'sqlite' is removed since PHP 5.4
66 | ERROR | The function is_countable() is not present in PHP version 7.2 or earlier
398 | WARNING | INI directive 'safe_mode' is deprecated since PHP 5.3 and removed since PHP 5.4
400 | WARNING | INI directive 'mbstring.func_overload' is deprecated since PHP 7.2
odeigniter/framework/system/libraries/Encrypt.php
FOUND 14 ERRORS AFFECTING 8 LINES
208 | ERROR | The constant "MCRYPT_MODE_ECB" is deprecated since PHP 7.1 and removed since PHP 7.2
298 | ERROR | Function mcrypt_get_iv_size() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
298 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
299 | ERROR | Function mcrypt_create_iv() is deprecated since PHP 7.1 and removed since PHP 7.2; Use random_bytes() or OpenSSL instead
299 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
299 | ERROR | The constant "MCRYPT_DEV_URANDOM" is deprecated since PHP 7.1 and removed since PHP 7.2
300 | ERROR | Function mcrypt_encrypt() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
300 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
315 | ERROR | Function mcrypt_get_iv_size() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
315 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
325 | ERROR | Function mcrypt_decrypt() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
325 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
433 | ERROR | The constant "MCRYPT_RIJNDAEL_256" is deprecated since PHP 7.1 and removed since PHP 7.2
450 | ERROR | The constant "MCRYPT_MODE_CBC" is deprecated since PHP 7.1 and removed since PHP 7.2
codeigniter/framework/system/libraries/Encryption.php
FOUND 50 ERRORS AND 1 WARNING AFFECTING 26 LINES
164 | WARNING | INI directive 'mbstring.func_overload' is deprecated since PHP 7.2
234 | ERROR   | Function mcrypt_list_algorithms() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
234 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
260 | ERROR   | Function mcrypt_enc_get_algorithms_name() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
260 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
261 | ERROR   | Function mcrypt_enc_get_modes_name() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
261 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
264 | ERROR   | Function mcrypt_module_close() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
264 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
267 | ERROR   | Function mcrypt_module_open() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
267 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
352 | ERROR   | Function mcrypt_create_iv() is deprecated since PHP 7.1 and removed since PHP 7.2; Use random_bytes() or OpenSSL instead
352 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
352 | ERROR   | The constant "MCRYPT_DEV_URANDOM" is deprecated since PHP 7.1 and removed since PHP 7.2
414 | ERROR   | Function mcrypt_enc_get_iv_size() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
414 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
418 | ERROR   | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
418 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
422 | ERROR   | Function mcrypt_module_close() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
422 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
430 | ERROR   | Function mcrypt_enc_get_modes_name() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
430 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
432 | ERROR   | Function mcrypt_enc_get_block_size() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
432 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
448 | ERROR   | Function mcrypt_enc_get_modes_name() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
448 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
449 | ERROR   | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
449 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
450 | ERROR   | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
450 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
452 | ERROR   | Function mcrypt_generic_deinit() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
452 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
455 | ERROR   | Function mcrypt_module_close() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
455 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
573 | ERROR   | Function mcrypt_enc_get_iv_size() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
573 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
575 | ERROR   | Function mcrypt_enc_get_modes_name() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
575 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
591 | ERROR   | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
591 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
595 | ERROR   | Function mcrypt_module_close() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
595 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
601 | ERROR   | Function mdecrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
603 | ERROR   | Function mcrypt_enc_get_modes_name() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
603 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
608 | ERROR   | Function mcrypt_generic_deinit() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
608 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
611 | ERROR   | Function mcrypt_module_close() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
611 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
742 | ERROR   | Function mcrypt_module_open() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
742 | ERROR   | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
oasgames/vendor/codeigniter/framework/system/libraries/Image_lib.php
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
1774 | WARNING | Function dl() is deprecated since PHP 5.3
codeigniter/framework/system/libraries/Session/Session.php
FOUND 4 ERRORS AND 4 WARNINGS AFFECTING 8 LINES
343 | WARNING | INI directive 'session.hash_function' is removed since PHP 7.1
348 | ERROR   | INI directive 'session.hash_function' is removed since PHP 7.1
355 | ERROR   | INI directive 'session.hash_function' is removed since PHP 7.1
360 | ERROR   | INI directive 'session.hash_function' is removed since PHP 7.1
364 | WARNING | INI directive 'session.hash_bits_per_character' is removed since PHP 7.1
369 | WARNING | INI directive 'session.sid_bits_per_character' is not present in PHP version 7.0 or earlier
370 | WARNING | INI directive 'session.sid_length' is not present in PHP version 7.0 or earlier
375 | ERROR   | INI directive 'session.sid_length' is not present in PHP version 7.0 or earlier

Please don't spam OSS projects with silly results from automated scanners.


[monorepo] task: Jenkins integration

Added Jenkinsfile and scripts for all projects
remove travis files
build configuration file.
Jenkinsfile for seed job

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@c92bea3). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev      #23   +/-   ##
======================================
  Coverage       ?   92.95%
  Complexity     ?     2340
======================================
  Files          ?      265
  Lines          ?     6894
  Branches       ?      418
======================================
  Hits           ?     6408
  Misses         ?      382
  Partials       ?      104

Flag
Coverage Δ

nem-core
95.53% <0.00%> (?)

nem-deploy
52.87% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c92bea3...089606d. Read the comment docs.


hw_inc is 40
mul is 3994
XXX sdiff:<PHONE_NUMBER>, nsdiff: 668700679
ratio is 0.999995
hw_inc is 40
mul is 4609
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331300341
ratio is 0.999994
hw_inc is 40
mul is 3883
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331299158
ratio is 0.999995
hw_inc is 40
mul is 4559
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331300145
ratio is 0.999994
hw_inc is 40
mul is 3994
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331299317
ratio is 0.999994
hw_inc is 40
mul is 4510
XXX sdiff:<PHONE_NUMBER>, nsdiff: 668700067
ratio is 0.999994
hw_inc is 40
mul is 4072
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331299552
ratio is 0.999994
hw_inc is 40
mul is 4415
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331299958
ratio is 0.999994
hw_inc is 40
mul is 4112
XXX sdiff:<PHONE_NUMBER>, nsdiff: 668700440
ratio is 0.999994
hw_inc is 40
mul is 4369
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331300057

A few minutes later, here's how the values are looking:
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331300217
ratio is 0.999994
hw_inc is 40
mul is 3994
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331299290
ratio is 0.999995
hw_inc is 40
mul is 4609
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331300270
ratio is 0.999994
hw_inc is 40
mul is 3956
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331299247
ratio is 0.999995
hw_inc is 40
mul is 4660
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331300082
ratio is 0.999994
hw_inc is 40
mul is 4032
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331299439
ratio is 0.999994
hw_inc is 40
mul is 4462
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331300022
ratio is 0.999994
hw_inc is 40
mul is 4072
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331299510
ratio is 0.999994
hw_inc is 40
mul is 4415
XXX sdiff:<PHONE_NUMBER>, nsdiff: -331300013
ratio is 0.999994
hw_inc is 40
mul is 4032

@ainguraXmarquiegui ,  do you run 'west update' before build?

@hakehuang I do run west update before build, yes.
Every module updates OK, except hal_nxp, so I go and manually checkout https://github.com/NXPmicro/hal_nxp/commit/2d7a8a4de179e9010b3be013a2f64f0103768c06 for the nxp_hal
Here you can see a log of how I do it:
west_update.txt
Here you can see all the revisions of every repo in the project:
repo_revisions.txt
You can verify every version, or you can run this command on your side and I can do the verification for you, if you send me the output of the command. The command needs to be run from the top directory containing all the modules:
find -name .git -exec /bin/sh -c 'HOME_DIR="$(pwd)" ; cd {} ; cd .. ; pwd ; git rev-parse HEAD ; cd "${HOME_DIR}"' \;

@ainguraXmarquiegui
/c/github/upstream/gptp/zephyr
5204bead0bd9b28949b287ce8b6450665fe13024

/c/github/upstream/gptp/modules/hal/nxp
0d6fdc1219f1b0c38a768ade1f7079a7eb8e9f90

@hakehuang , it seems we are running the same code base.
Are you still working on any new fixes? Should we find out why we are seeing this difference?

Are you still working on any new fixes? Should we find out why we are seeing this difference?

sorry, I push the code to bitbucket, forget to update, just pushed
https://github.com/hakehuang/zephyr/commits/eth_thread
hal_nxp: 2d7a8a4de179e9010b3be013a2f64f0103768c06
zephyr: 5b313b6192a5085c07f4fec9b756bb1739fe0158

OK, thanks. west update now works OK, but the code has not changed, so there's no use in testing again.
How should we move forward?

what is your testing PC brand? from my side the clock shows converged, but it is not work at all at your side. would this possible to download my binary?
zephyr.zip

My PC is a Lenovo desktop PC with an Intel I210 NIC.
Before I flash your binary: What board is it compiled for?

Before I flash your binary: What board is it compiled for?

it is RT1060, do you have it?

@hakehuang , I'm sad to report that flashing your binary shows lower numbers in the nsdiff log print, but it's always in the hundreds of microseconds ballpark. Much higher than the results you are showing.
See the captured log of one of the test runs I have done:
minicom.log
Also the PPS is not sync-ed at all, it's still drifting away without control:

what's your brand of testing laptop? let me try to find one like yours. it is way of strange.

There is definitely something strange going on. I have just repeated the test, just to be sure. I have new findings to share. It turns our that if I run gPTP on my PTP master PC, I get the results I have reported above repeatedly.
However, if I run the PTP master PC on linuxPTP and your binary, the nsdiff numbers I am getting are much closer to the ones you reported. Sadly, the PPS signal is still not in sync, and in 15 minutes of runtime it has already accumulated more than 200 microseconds of drift and is still moving in the same direction.
This is the setup I am using:

Your binary flashed onto a mimxrt1050evk as the gptp slave
Direct ethernet connection to gptp master
gptp master hardware specs:

ThinkCentre Edge71 1577N8G - Intel Pentium G630 / 4GB RAM
PCIe NIC: Intel I210

gptp master SW specs:

OS: Ubuntu 20.04.3 LTS
linuxptp

https://sourceforge.net/p/linuxptp/code/ci/27bc9d52fa12b78abe0b3b73e162693938fbf498
Config file: https://github.com/zephyrproject-rtos/zephyr/files/7040484/007-gPTP-PCMasterZephyrSlaveMinChange.cfg.txt

Let me remind you that using two PCs running these Intel I210 NICs and the same software stack I have been able to perform long term duration tests that showed sub 50 nanosecond synchronization accuracy, so I think it's pretty likely that my master setup is good enough.
I don't think the PC part is that important, but I do agree that sharing a common setup could help us avoid unwanted variables. If you can do changes to your setup, I think any desktop computer with similar or better specs than the one I'm using, equipped with an intel i210 NIC would be a good platform.
Even better that the PC would be if you could do your tests on a mimxrt1050evk board instead of the 1060. Especially taking into account that the freertos stack you shared is supposed to be made for the 1050.
Anyway, the key takeaways I draw from this test are:

I am able to reach comparable results to yours by flashing your binaries onto my imxrt1050evk using my linuxptp master PC
There's something different about my builds and your builds
Even if the nsdiff variable appears to show good results, the PPS clock is still not synchronized to the master clock

So what we need to work on is:

What can we do to make my builds behave like yours?
What can we do to fix the PPS sync problem?

What can we do to make my builds behave like yours?
I just run west build with zephyr compiler
What can we do to fix the PPS sync problem?
there are some alogirthm change required in gptp to better fit our ethernet driver, I only add a very simple filter there, but actually there need to have a PID filter, do you contact our europe AE team for supporting? those algorithm still no opensourced.

What can we do to fix the PPS sync problem?
there are some alogirthm change required in gptp to better fit our ethernet driver, I only add a very simple filter there, but actually there need to have a PID filter, do you contact our europe AE team for supporting? those algorithm still no opensourced.

I did contact NXP's europe AE team. After an initial conversation, they promised they would get back to us, but they never did.
I am confused by your statement saying that there are parts that are not opensourced, since you shared the full TSN stack source code for freeRTOS a few posts back. I'm trying to look into it for ideas, but I have not made any progress so far.
Can you explain what the PID filter is in detail, and how it will help fix the PPS sync problem?

What can we do to make my builds behave like yours?
I just run west build with zephyr compiler

Your answer is not detailed enough to find the root cause of the difference. I need you to share at lease these key components on your build machine:

Zephyr SDK: 0.13.1
cmake version 3.20.2
Git hashes of every repository in the zephyr project directory:
zephyr_repos.txt

Your answer is not detailed enough to find the root cause of the difference. I need you to share at least these key components on your build machine:

Zephyr SDK: 0.13.1

zephyr: 0.13.1
cmake version: 3.21.1
git hases:
zephyr_version.txt

I am confused by your statement saying that there are parts that are not opensourced, since you shared the full TSN stack source code for freeRTOS a few posts back. I'm trying to look into it for ideas, but I have not made any progress so far.

the code I shared with TSN team has some obj files.

Can you explain what the PID filter is in detail, and how it will help fix the PPS sync problem?

if you look at the linuxptp source code this module do the similiar thing (filter.c)[https://github.com/openil/linuxptp/blob/master/filter.c]

Hello again everyone. @hakehuang and friends at NXP: Has this been abandoned? Do you guys intend to keep working on this issue?

@ainguraXmarquiegui @kevin137 the code branch is Ok for demo quality, but for better performance, we still has some more works to do, but I guess we can close this issue for now, and use another ticket to track the timer precision improvement. agree?

@hakehuang you have definitely made some very valuable contributions in this issue, and I agree that some of it should be merged as soon as possible. It's especially important to merge the ethernet driver fixes. However, I wouldn't merge other parts of the current code base.
I have prepared a new branch that has everything I think we should be pulling to mainline:
https://github.com/ainguraXmarquiegui/zephyr/tree/eth_thread_hwsync_rebase
Here's what I would do:

Start a new pull request to contribute the ethernet driver improvements and other small fixes
Keep this issue open until we really solve gptp problems on the imxrt platform

@hakehuang , please review the branch I referenced a few lines ago. I would like to hear feedback about that branch, and also about my proposed actions.

@ainguraXmarquiegui , ok, can you create PR for review? and I am ok to keep this issue open.

@hakehuang , here's the pull request:
https://github.com/zephyrproject-rtos/zephyr/pull/42216

Hello everyone. I just wanted to say that we do not consider this issue to be resolved. We are seeing quite respectable performance in FreeRTOS on the same hardware, and would very much still like to see something similar in Zephyr.

@dleach02 @hakehuang would you mind taking another look? I was going to close this as fixed by https://github.com/zephyrproject-rtos/zephyr/pull/35328, but since the reporter says it is still open, I am going to leave it open.

yes, leave it open. The pr you reference only partially helped things.

Hello everyone I have been looking into the gptp stack and drivers for the last two to three weeks. After having made a few changes into the eth_mcux driver I am able make gptp work with a IMXRT1050-EVKB as well as with a MIMXRT1170-EVK boards. I would appreciate some advice on making a PR since one of the changes involved in making this work out is board dependent (there is a constant that needs to be added/substracted when reading timestamps).

It's great to see other people trying to get gPTP to work.
I'm sorry to report that I have moved on from this part of the project, and I don't currently have access to the material I need to work on these issues.
Just an example of a pull request that may be similar to this from a github management point of view, you could have a look here: https://github.com/zephyrproject-rtos/zephyr/pull/42216
You might be able to get help on Discord too.

@lomn, you can submit a PR and we will review and give feedback.

Hi @lomn
Have you implemented a servo control loop? Looking at how drivers on other platforms work, good, stable seems to be impossible without it.

@dleach02 Ok thank you I will !
@kevin137 Not for now. I just fixed a bug and took some delay into account for propagation between the phy and the mac. It seems like a control loop isn't quite necessary as I was able to test the boards with two different certified hardware and everything worked fine. A nice addition in order to improve on stability would be to average the last 3 or 4 pdelay and pratio.

@kevin137, I've removed the stale and reopened the issue.

We've given up. We will let the bot close the issue.

@dleach02  I will follow up this fix and retest the gptp performance as well as stabilities. will feeedback once ready


Some minor fixes

where is paper adventure kyori component

where is paper adventure kyori component

nose, bungee-api momento


better README?

any contribution would be appreciated

refactor examples kinda what we need right now i guess

realm parameter in options needed for constructor ... take 2 hours to find it why the constructor throw me an error. Please update  README

@adnanebrahimi i have no issue like that. there is no realm in my test cases. Are you using js?

Yes I'm using js file in  Angular but i install it with npm..

#76


Use texture theme path instead of texture path for buttons

About the PR
Companion PR to engine change to make sure arrow buttons don't become error buttons if the below engine change hits
Requires https://github.com/space-wizards/RobustToolbox/pull/4048

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

fix: Fix images on paper, mech UI, and targetting dummy

Superseded by space-wizards/RobustToolbox/pull/4059


Renaming Document Id property in .NET Core 3.0 requires Newtonsoft.Json

Describe the bug
Several Microsoft samples for Cosmos DB and .NET Core use Newtonsoft.Json.JsonPropertyAttribute to rename the Id property on a model to id. In .NET Core and ASP.NET Core, Newtonsoft.Json has been replaced by System.Text.Json. If I use System.Text.Json.Serialization.JsonPropertyNameAttribute instead, CosmosClient.CreateItemAsync() fails with the following error message:
The input content is invalid because the required properties - 'id; ' - are missing

To Reproduce
See my fork of cosmos-dotnet-core-todo-app in which I have followed the steps below:

Create, clone or open a Cosmos + .NET Core app
Upgrade the app to .NET Core 3.0 (if not already targeted)
Remove references to Newtonsoft.Json
Replace [Newtonsoft.Json.JsonProperty("id")] attributes with [System.Text.Json.Serialization.JsonPropertyName("id")] attributes.
Run the app and create a Document

Expected behavior
I expect that the Id property will be renamed to id by the native System.Text.Json attribute and that Cosmos DB will accept the document and create it.
Actual behavior
CosmosException: Response status code does not indicate success: 400
The input content is invalid because the required properties - 'id; ' - are missing

Environment summary
SDK Version: Microsoft.Azure.Cosmos 3.3.3
OS Version Windows 10 1909 (OS Build 18363.418)
Additional info
Workarounds are 1. use Newtonsoft.Json and 2. rename the property on the model class to "id".

See also #202

This is a goal in the VNext SDK. The current v3 has hard dependencies on Newtonsoft. We also ran into a few blockers trying to do the conversion that the System.Text.Json library should address in the next release.

I'm closing this as a duplicate of #202


No warning for unused variables

When compiling under high warning levels, I get this warning for unused variables. I commented them out, which is AFAIK the usual thing to do.

Thanks, merged.


Save branch as scene on a control node also adds hidden nodes to the scene

Godot version
4.0.alpha4.official
System information
Windows 10
Issue description
When using the Save Branch as Scene on a more complicated control node such as GraphEdit, the "hidden" nodes are also saved to the scene.

Steps to reproduce
Add any Control node which contains "hidden" nodes, such as a TabContainer or GraphEdit, and then right click and choose Save Branch as Scene on it or it's parent.
Minimal reproduction project
No response

Duplicate of #54960


All History Model Fields From Source Model NOT Required

Problem Statement
For performance optimisation purposes I want to use the "update_fields" kwarg on the save() method for all Django models when updating a record. In high volume websites making lots of changes to database records, it provides the ability to use updates that do not require fetching the entire current record before persisting a single field that has changed to the database and also means the payload of data between Django and the DB server will be significantly reduced. Using "update_fields" works great for the source models but results in the understandable error below for the history tracking record:

IntegrityError: null value in column "xxx" violates not-null constraint

Describe the solution you'd like
It would be great if there was a configuration attribute that could be specified as part of the simple history instantiation that would allow the transform_field() method to set blank=True, null=True on all copied fields.
Describe alternatives you've considered
There is no other solution that would work realisticly as far as I can see apart from monkey patching the transform_field method but is not an ideal solution.
Additional context
It is all about perfomance optimisation.
NOTE: I am happy to do the enhancement and raise a PR for it if you see it as beneficial

I am also being bit by this issue and would be willing to help develop and/or test the PR.

This is the monkey patch working for me with no issues so far:
from copy import copy as _copy
from simple_history import models

TRANSFORM_FIELD = _copy(getattr(models, "transform_field"))

def transform_field(field):
    """
    Patch transform_field to set field.{blank,null} = True
    """
    TRANSFORM_FIELD(field)
    field.blank = True
    field.null = True

setattr(models, "transform_field", transform_field)


Move list of User-Agent headers from apify-system to apify-shared

A list of User-Agent headers is necessary for the rotateUserAgents Crawler option.
Since we're migrating Crawler to Actor (e.g. crawler-cheerio),
it makes sense to keep relevant constants in one place only.
I downloaded a fresh list off the page in comment and will prepare a PR in apify-system
that would use this list from apify-shared.

Closing this. Crawler cannot load constants from npm package. Adding the User-Agent list to apify-js.


Lottie test

Add an exercise through the form and see it in the exercise list. (after refresh)

changed input and form section from id to values
added a snackbar to show "successfully added" message - not working 100%.
need to add some validation for the inputs...

Looks good :)


Performance improvement of SparsePauliOp.tensor

Summary
Performance improvement of SparsePauliOp.tensor by skipping a redundant phase check.
import random
from timeit import timeit

from qiskit.quantum_info import SparsePauliOp

def bench(k, n):
    random.seed(123)
    op = SparsePauliOp.from_list([(''.join(random.choices('IXYZ', k=k)), 1) for _ in range(n)])
    op2 = SparsePauliOp.from_list([(''.join(random.choices('IXYZ', k=k)), 1) for _ in range(n)])

    print(f'{k}, {n}: {timeit(lambda: op.tensor(op2), number=1)} sec')

bench(10, 5000)

main
10, 5000: 3.415048268998362 sec

this PR
10, 5000: 1.9170281529986823 sec

Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 85.279%

Totals

Change from base Build<PHONE_NUMBER>:
0.001%

Covered Lines:
67251

Relevant Lines:
78860

💛  - Coveralls


LIB: update submodule, use .vs files.

checks fail and need Artur to approve the iob-lib PR

checks fail and need Artur to approve the iob-lib PR

Fixed the checks failing. Waiting for Artur feedback.