Megalodon.db

I ran the tests they were all successful, Now I'm trying how to get this .sample.megalodon.db file, I have my output in the bam file only.
data/MCF7_ATCC.sample.haplotag.bam data/MCF7_ATCC.sample.megalodon.db
data/MCF7_ECACC.sample.haplotag.bam data/MCF7_ECACC.sample.megalodon.db

Hey there, not quite clear on what you mean but I think you might be asking how to run this on your own data where you just have .bam files and not .db files, is that correct?
If so, and if the .bam files have the MM/ML tags for modified bases, you can feed them to methylartist via the -b/--bam option.

Hello, Yes I have .bam files, I sort my bam file index it, and merge it into a single .bam file. But When I run with the segmeth command there is an error showing --ref --motifs required for -bams? Is it asking for my references Genome, and what about motifs?

Ok, good, yes --ref should point to a reference genome that has been indexed via samtools faidx, and --motifs is CG if you're looking at CpG methylation A if you're looking at m6a, etc.

There isn't a requirement for a particular naming scheme (unless I've missed something?) so you should be able to use coordinates like NC00001.11:12345-22345, let me know if that makes sense as I'm not sure I understand.

Command given:
methylartist scoredist -n 300000 -b output.sorted.bam --ref /home/singhrajender/Documents/manorma/nanopore_data/NanoRef/hg38.fa.fai --motif CG -m m
Error:
2024-05-21 17:08:58,030 starting methylartist with command: /home/singhrajender/.local/bin/methylartist scoredist -n 300000 -b output.sorted.bam --ref /home/singhrajender/Documents/manorma/nanopore_data/NanoRef/hg38.fa.fai --motif CG -m m
[E::fai_build_core] Format error, unexpected "c" at line 1
Traceback (most recent call last):
File "/home/singhrajender/.local/bin/methylartist", line 5592, in
main()
File "/home/singhrajender/.local/bin/methylartist", line 5272, in main
args.func(args)
File "/home/singhrajender/.local/bin/methylartist", line 1786, in scoredist
sample[os.path.basename(bam)] = sample_bam(bam, args.motif, args.ref, int(args.n))
File "/home/singhrajender/.local/bin/methylartist", line 761, in sample_bam
ref = pysam.Fastafile(ref)
File "pysam/libcfaidx.pyx", line 123, in pysam.libcfaidx.FastaFile.cinit
File "pysam/libcfaidx.pyx", line 183, in pysam.libcfaidx.FastaFile._open
OSError: error when opening file /home/singhrajender/Documents/manorma/nanopore_data/NanoRef/hg38.fa.fai
We are facing the above error with reference file. We have done reference genome indexing using "samtools faidx" tool.
Below are the attached reference index file data:
chr1	248956422	6	50	51
chr10	133797422	253935564	50	51
chr11	135086622	390408942	50	51
chr11_KI270721v1_random	100316	528197322	50	51
chr12	133275309	528299652	50	51
chr13	114364328	664240475	50	51
chr14	107043718	780892097	50	51
chr14_GL000009v2_random	201709	890076715	50	51
Below is the .bam file data:
NC_000001.11	10000	10423	b112a3cb-817b-4c50-abb8-84de3900b738	0	+
NC_000001.11	10000	10468	3ef37e5d-5b44-4249-b161-93e102200aad	0	+
NC_000001.11	10000	10468	ae3cb4a1-d80d-4103-8588-0c8c7a042735	0	+
NC_000001.11	10000	23012	e4ae9864-f99a-4fcd-b391-fc61bab567e8	0	+
NC_000001.11	10000	10467	36d1e1b8-1167-4775-9d70-7068dd0b2fa8	0	+
NC_000001.11	10000	10468	36d1e1b8-1167-4775-9d70-7068dd0b2fa8	0	+
NC_000001.11	10000	10368	12807309-45c8-4668-9ff1-b60724a61f28	0	+
NC_000001.11	10000	10468	b5d4ccfa-30a5-4fc2-b5dd-45ebfcf030f7	0	+
NC_000001.11	10000	10374	986037a0-a0fe-45ea-9181-d69d3db5034b	0	+
NC_000001.11	10000	10468	686213fa-7bcb-48ab-b84c-44bfceb59e57	0	+
<< ValueError: invalid contig chr1 >>
How to solve the above error?

ah the reference .fasta file should be the same one as was used to create the .bam files

Is there any way to solve this issue? I tried reheader command from samtools but it didn't work? Can you suggest something?

One issue I didn't pick up on before is that --ref should point to the .fa file not the .fa.fai file.
The easiest way to address this is to point --ref to the same reference genome as was used to create the .bam you are using.

hi again,
I have a problem regading graph generated by segplot. every time I tried the graph is blank and there are so many o(zero) in .csv file and nan in .tsv file after trying next command I get a error :
Traceback (most recent call last):
File "/home/.local/bin/methylartist", line 5592, in
main()
File "/home/.local/bin/methylartist", line 5272, in main
args.func(args)
File "/home/.local/bin/methylartist", line 2711, in segplot
sns_plot = sns.FacetGrid(plot_data, row='samplegroup', hue='sample', aspect=15, height=.5, palette=args.palette)
File "/home/.local/lib/python3.10/site-packages/seaborn/axisgrid.py", line 462, in init
axes = fig.subplots(nrow, ncol, **kwargs)
File "/home/.local/lib/python3.10/site-packages/matplotlib/figure.py", line 930, in subplots
gs = self.add_gridspec(nrows, ncols, figure=self, **gridspec_kw)
File "/home/.local/lib/python3.10/site-packages/matplotlib/figure.py", line 1542, in add_gridspec
gs = GridSpec(nrows=nrows, ncols=ncols, figure=self, **kwargs)
File "/home/.local/lib/python3.10/site-packages/matplotlib/gridspec.py", line 378, in init
super().init(nrows, ncols,
File "/home/.local/lib/python3.10/site-packages/matplotlib/gridspec.py", line 48, in init
raise ValueError(
ValueError: Number of rows must be a positive integer, not 0
Please suggest what should I do?


about how to train the diffusion model?

I think this is a good job. I'm a little confused about training the diffusion model. Is your training method using direct prediction x_0 to calculate the loss with the real camera or calculating epsilon and epsilon_pred to calculate the loss? I used the second one, but it was all garbage when predicting. Is there any skill?

We tried and got reasonable results on both. I think our performance and training stability was better when doing X_0 prediction. I would suggest trying that first.
When doing epsilon prediction, are you using our ddpm inference code? You may need to make sure that the flag for epsilon vs X0 prediction is set properly.

@jasonyzhang Hi! sorry for commenting here if it's not appropriate. I'd like to politely ask when are you planning to release the training code :)

Hi! Is there any update to the release of the training code?

The dev branch now has a V1 of the training code.


Don't raise error when template is empty

sassc raises an error when an empty template is passed (see https://github.com/sass/libsass/blob/b2a3d98ed384d2d19aa79157d08fa21c3e8043e0/src/sass_context.cpp#L390). rubysass accepts that however, that means the sass and sassc gems behave differently when passed the same input:
Sass::Engine.new('', style: :compressed).render # => ""
SassC::Engine.new('', style: :compressed).render # raises SassC::SyntaxError
# but with one space:
SassC::Engine.new(' ', style: :compressed).render # => ""

This change just short-circuits the whole Engine#render-method if the template is empty. This is the easiest solution I could see, but maybe I'm missing something.
A side note: While putting this together I noticed that the :quiet-option seems badly named, as it is more like a dry run if I understand it correctly. The quiet option in rubysass actually surpresses warnings, whule the sassc version just does not return the resulting css. This subtle difference might trip someone up. If the current behavior of the quiet option is indeed intentional, then this PR needs to be updated to make the behavior the same for the empty template case.

Thanks for merging, @rosenfeld has a point about mutating the input. I think both solutions work, however return<EMAIL_ADDRESS>if @template.empty? is probably more explicit than return @template.dup if @template.empty?.
It would probably make sense to add tests that the returned empty string is not the same as the input string, as well as that it preserves the encoding.

@fschwahn I merged as some folks were running into this problem.  If you want to further improve the code or tests, that's more than welcome - feel free to submit another PR!


Dyndns plugin unknown directive

1. Which version of Caddy are you using (caddy -version)?

0.11.5
2. What are you trying to do?

Deploy Caddy using official creator with 'dyndns' and 'tls.dns.cloudflare' plugins.
3. What is your Caddyfile?
paste entire Caddyfile here - DO NOT REDACT ANYTHING (except credentials)

subdomain1.example.com {
	on startup "\"C:\Caddy\php\php-cgi.exe\" -b <IP_ADDRESS>:9000" &

	ext .html .htm .php
	root C:\Caddy\www\subdomain1.example.com\html

	fastcgi / <IP_ADDRESS>:9000 php

	gzip

	tls {
		dns cloudflare
	}

	log C:\Caddy\logs\subdomain1.example.com.log {
		rotate_size 1
		rotate_age  7
		rotate_keep 2
	}

	errors C:\Caddy\logs\subdomain1.example.com_errors.log {
		rotate_size 1
		rotate_age  7
		rotate_keep 2
	}

	header / {
		Strict-Transport-Security "max-age=31536000;"
		X-XSS-Proection "1; mode=block"
		X-Content-Type-Options "nosniff"
	}
}

http://localhost http://<IP_ADDRESS> {
	ext .html .htm .php
	root C:\Caddy\www\subdomain1.example.com\html

	fastcgi / <IP_ADDRESS>:9000 php

	gzip

	dyndns {
		provider cloudflare
		ipaddress http://whatismyip.akamai.com/
		auth ********edited********<EMAIL_ADDRESS>		domains subdomain2.example.com
		period 30m
	}
}

4.

Using native Windows 10 64bit command line tool opened with system administrator privileges. The command was executed from within Caddy directory:
caddy.exe -agree -email<EMAIL_ADDRESS>-log C:\Caddy\logs\Caddy.log
5. Please paste any relevant HTTP request(s) here.

6. What did you expect to see?

Activating privacy features... done.

Serving HTTPS on port 443
https://subdomain1.example.com

Serving HTTP on port 80
http://localhost
http://<IP_ADDRESS>
http://subdomain1.example.com

7. What did you see instead (give full error messages and/or log)?

2019/03/15 17:00:26 Caddyfile:42 - Error during parsing: Unknown directive 'dyndns'
8. Why is this a bug, and how do you think this should be fixed?

'dyndns' plugin is not being detected or is not being added during the process of building Caddy.
9. What are you doing to work around the problem in the meantime?

I read that it's possible to compile Caddy manually which I'm willing to try.
10. Please link to any related issues, pull requests, and/or discussion.

Issue discussed on Caddy forum
Issue discussed on GitHub
Bonus: What do you use Caddy for? Why did you choose Caddy?

Homelab and private websites.

Hi, unfortunately since you did not fill out the issue template, we don't have enough information to assist you. :( If you will update your post to answer the questions in the bug report template, we can help and reopen the issue. Thanks!

I updated the information. Please, let me know if something is still missing. Thanks.

@Zachar2 Thanks. Upon investigating, it seems that the plugin author has not submitted a pull request to add this directive to Caddy: https://github.com/linkonoid/caddy-dyndns/issues/1
Hence, Caddy doesn't recognize it unless you do it manually.
This is something that will have to be resolved by the plugin authors -- thanks for the question!


Very high consumption of the CPU when reading data from the database with async api

Describe the bug
The problem occurs when calling http methods in ASP Net Core application. In the process request, we connect to the sql server and read data. Problem occurs when using the asynchronous API to read data. It can be obtained when we host an application on IIS and IIS Express.
To Reproduce
Steps to reproduce the behavior:

API: Microsoft.AspNetCore.App 2.2.0, Microsoft.EntityFrameworkCore 2.2.4, System.Data.SqlClient 4.6.1
Create Controller which inherits from ControllerBase
Run this code
[HttpGet] public async Task<ActionResult<string>> Get(){
var query = $"select TOP 1 * from ftBinDocuments ";
using (var cc = new SqlConnection(DbContextCommandExtensions.st))  {
using (SqlCommand command = cc.CreateCommand()){
 command.CommandText = query;
  cc.Open();
using (var rd= await command.ExecuteReaderAsync()){
while (await rd.ReadAsync()){
}
}}
return "ok";
}
We connect to MS Sql Server and read a lot of data.  The row size  is over 5-6 MB.
There is a lot of CPU usage during the execution of rd.ReadAsync ().

The problem disappears if we switch to synchronous api.
Expected behavior
Low CPU usage.
Screenshots

Tagging @sebastienros @ajcvickers

@landryn record a CPU profile and show the results in here.

@davidfowl - ok, I did it.
Report20190524-0834.zip
I am also enclosing the application's source code.
WebApplication5.zip


Better support invocation-side erroneously passing non-iterable objects to request-streaming methods

We don't yet have for request in request_iterator: wrapped in a try:/except: but we certainly should. If the invocation-side application makes a mistake and passes an object that is not an iterable of request values, something (probably logging) should make them aware of that.

The fix for this landed in pull request 8686 and will be included in whatever release comes after 1.0.4 (likely 1.0.5 or 1.1.0).


[only test]Opt time format 2

Proposed changes
Issue Number: close #xxx

run buildall

run buildall

run performance

run buildall

run performance


The extension should notify the user to install Python and the Python extension when attempting to export a notebook if they are not installed

Currently, the extension requires Python and the Python extension to export a Jupyter notebook. But, if you lack either, the drop-down menu asking for a Python environment is blank and VSCode gives you no information about what to do.
I would like the extension to notify the user to install Python and the Python extension when trying to export a notebook if they are not installed.

Thank you for filing this issue, given the fact that we haven't had sufficient upvotes on this issue I'm closing this as not planned.


very simple and hacky path item parameter override test

Hi. This is a follow up on #140 and #144.
The fix in #144 is good enough for me and solves my use case. (Thanks again @p1c2u)
However I thought I play around a bit and test overriding parameters. Here are two very simple (and hacky) test cases to demonstrate that.
The issue of overriding Path Item Parameters with Operation Parameters is a bit more complex though. First it is possible to create an invalid Spec object by overriding a parameter with same name but different in attribute. The second part is parameter validation, which should only validate with the overridden parameter definition from the Operation object.
I believe it is a rather rare use case to override parameters, but I thought I'll put it up here. It does not hinder me using this fantastic library and I know that this pull-request is not really mergeable (I only put it together in one place to better demonstrate the two sides of this issue).

@gweis thanks for the PR.

The issue of overriding Path Item Parameters with Operation Parameters is a bit more complex though. First it is possible to create an invalid Spec object by overriding a parameter with same name but different in attribute. The second part is parameter validation, which should only validate with the overridden parameter definition from the Operation object.

It's absolutely okay to have many many parameters with the same name and different location. See https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#fixed-fields-7
It says:

A unique parameter is defined by a combination of a name and location.

A unique parameter is defined by a combination of a name and location.

@p1c2u thanks for pointing that out. (It's sometimes a bit hard to keep following all the little details)
This certainly simplifies that issue.
There is only one part left then, the part about validating overridden parameters. (I have updated the test cases, it's less tacky now :)
If you have any pointers on where in the code base to fix that, I can have a look and create a PR.

I think I was able to put a fix together as well.


LQR based altitude control

This is a draft.
Main Changes
This is an attempt to implement an LQR-based altitude control algorithm, which runs on Raspberry Pi.
Tests
Tests will be included in future

@gunturiCM This is getting too lengthy and it will be difficult to review. Let us set a realistic goal that will allow us to merge it into dev soon. When you're ready please invite @boyle26 too.

Closing because a working altitude hold control is implemented in #107.


Hello!  how to update wine from 7 to the latest version?

Describe the bug
I can't install a Windows application on my desktop.  Wine from an outdated version of the store, winezgui crashes immediately after turning it on, which does not allow you to perform any actions in the program.  Installing the repository from the console gives an error.
What did you expect to happen?
I expected that, as in the example on Ubuntu, everything would work without any problems
Output of rpm-ostree status
No response
Hardware
No response
Extra information or context
No response

Use Lutris or WineZGUI, wine-core is only present for Lutris dependency reasons.

The point is that you need to add an application, not a game. The games work out of the box and that's cool. I've tried different distributions, but they are not very stable. Yours is the most stable and easy to install. Am I correct in understanding that you are not planning to add full support for Wine? And I will try the bottles as you advise me.

bottles works fine for applications, you should never have to use system wine.


Issue when trying to perform sky subtraction

There seems to be an issue when performing the sky subtraction process. The function extract_spectrum_region works perfectly with an already defined region file and gives proper fitting results. However, if I try to directly specify a background region with the function extract_spectrum and x-y coordinates, the fitting results I obtain are completely different.

The x and y pixels had not been properly transposed for the extract_spectrum function as they had been for all other functions. This has been remedied :D

Reopening because this problem has occurred again.


Show properties/methods 'inherited' from Behaviors on element's doc page

It would be nice if an element's documentation page also included a section for Properties/methods "Inherited from Behaviors". An example is the iron-pages doc page: basically none of the properties you came there to reference are actually shown. You have to click through to the Behaviors' pages to see what is actually available.
I think showing these inherited items would save time for both experienced Polymer devs just doing a quick reference and those getting started with Polymer who may not realize there are other properties and methods on an element that it gets from its behaviors.

+1. This really important. Needed to achieve parity with the old docs (which had show/hide for inherited members).

+1. All of an element's properties/methods/attributes need to be visible on the documentation page for that element. I would even argue that they should not be initially hidden. Ideally, when I first pull up the documentation I should be able to see all inherited properties and methods with a short description next to them, and if I need to find out more about that property or method I can expand the details.

+1 on this, @arthurevans is this something you would like me to do? If so I can jump in

I know @garlicnation has done some work on this, but I don't know the current status of the ticket.

ok I have done some more looking into exactly what would be involved here to roll this out.

update hydrolysis to include inherited methods / events in the JSON that it generates
update iron-doc-property to correctly display "inherited" methods / events

After that we should be good to go.
Let me know your thoughts @arthurevans

@samccone The hydrolysis work is done. We're working on the necessary updates to iron-doc-viewer and iron-component-page to display the additional information properly.

awesome @garlicnation let me know if I can be of any help here :)

+1.
I don't want to drilldown through all the 'inherited' behaviors to find out the properties of the element, because.. well... I'm lazy.


New version: Microsoft.OneDrive.Internal.Fast version 23.011.0115.0001

Result: Installation Failed

Manifest
Add/Remove Programs

Name
Microsoft OneDrive Internal Fast

Version
23.011.0115.0001

Publisher
Microsoft Corporation

ProductCode

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 5334
Microsoft Reviewers: Open in CodeFlow

This PR appears to remove files from another version. Is that intentional?


Can't expand to check the data of a Variable when debugging pytorch code

for the pytorch Variable object listed in the debug panel, expand to see its data part shows no tensor which suppose to have in a pytorch Variable, and among the items in data, there is another nested data part which have endless nested data part in it.

VSCode Version: Code 1.19.3 (7c4205b5c6e52a53b81c69d2b2dc8a627abaa0ba, 2018-01-25T10:32:23.601Z)
OS Version: Linux x64 4.13.1-gentoo
Extensions:

Extension
Author (truncated)
Version

python
ms-
2018.2.1

vscode-ai
ms-
0.1.7

cpptools
ms-
0.16.0

rust
rus
0.4.0

Steps to Reproduce:

Reproduces without extensions: Yes/No

Please could you try debugging using the experimental debugger.
Try changing the type from python to pythonExperimental in launch.json.

tried as your advice, but changing to pythonExperimental do not help.
the tensor is still absent in the data, while the data part is still expanding endless nesting.

Please could you provide a sample code to replicate this issue (please include the steps as well)
Please provide the version of program used
Are you using anaconda etc

any pytorch code, as long as it includes tensor, could replicate this issue. for example:

import torch
from torch.autograd import Variable

x = torch.randn(2,2)
y = torch.Tensor([1])
z = Variable(torch.ones(2, 3))

print(x, y, z)

in the code above, I can't track the tensor data in x, y, z when debugging with vscode.

by the version of program used do you mean the vscode or the python extension? for vscode, I tried 1.19.3, 1 and 1.21.1, for the python extension, I tried 2018.2.1 and the recently updated 2018.3.1, all come the same issue.

yes, it is anaconda.
but weeks ago, vscode worked well with my os environment, showing the tensor information correctly when debugging. It could hardly be my environment problem since pycharm could debug very well, while vscode fails.

The issue is not well fixed yet ...
For a Tensor type in PyTorch, its data part is a multidimensional array in fact. But it is still unable to expand the data correctly, but only be caught into infinitely expansion of itself, as shown in the following screenshot:

How can I make the Tensor data expand into any index correctly, as the numpy ndarrays do?
VSCode Version: 1.33.1
Python Extension Version: 2019.3.6558

I would also like a solution for this issue on Windows 10 / VSCode 1.41.1

It is not yet solved 2 years later...

Infinite expansion is not an issue with the debugger - it just faithfully reports what attributes the object has; and in this case, the data attribute seems to be recursively referencing itself.

I would also greatly appreciate a fix on this issue. In the meantime, are there any workarounds available? Extensions or anything?

@stash-196 one simple workaround is to copy the tensor from debugger and paste it into the terminal at the bottom or anywhere else, not an elegant solution but it shows the full tensor data.

@adamxyang Yes.
Also, I'd like to add that some matrices have 100~1000 rows/columns and I'd like to check them out too. So it would be nice to have an Rstudio-like interface where I can track a variable in full screen.

Another option I just found was, the tensor can be viewed as a pandas dataframe using the "View Value in Data Viewer" (right click). The Jupyter extension needs to be installed. It's not great as it opens the tensor in a new tab etc.
Would love to see a fix for this!

And more often then not, the data viewer doesn't load but shows an error instead.

I think i'm hitting something similar in #19598

I found one workaround solution is using cpu().numpy(), or if you have a single value tensor, you could use item().


Start beacon chain w/ quick start state

start beacon chain w quick start state or dumped ssz/yaml state

@wemeetagain I think this is now good to go. I fixed those deposit proofs and stuffs so it now all works
We can do other stuff from this point on


Add support for the partitioning requirements using Mesos group concept

implement support for providing an instance index if it is required

for indexed deployments deploy N number of apps with instance index of 0 to N-1, where N is the count deployment property

for indexed deployments use a sub group mathcing the app name under the group that the deployer SPI provides

Resolves #17

@trisberg Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@trisberg Thank you for signing the Contributor License Agreement!

LGTM, merging. Also verified running the SCDF mesos with the deployer changes applied on DC/OS and stream partitioning looks good.


Name modal instead of auto generation

dev update, instead of auto generating a name, prompt the user to create one. solves #1744

updated


Sort triangles by distance for correct layering of rendering

This will probably work really well: https://stackoverflow.com/a/3893967/5191756

Fixed.


Sort studios list and add "Rodeo FX" to it

Hi! I'm a Pipeline Developer at Rodeo FX and we have been using Qt.py a lot as we transition towards supporting Maya 2018 in our pipeline. It's a super handy module!
I couldn't decide where to add our name so I thought it'd be nice to sort the list alphabetically first.

Thanks @darkvertex, looks solid!
@mottosso I actually checked so no companies got lost in the sort... Because waiting for my commute...

Neat, thanks a bunch!


Fix self transfer duplicate history

Added checks when saving history, making sure history is never recorded twice in the same address's history

Thanks @baedrik for reporting this issue and helping me find an elegant solution for it 🎉


development: strict types could be returned from handlers

to make code more safe

Do you have an example of what the end result looks like? Maybe in the examples folder?

of course I do :)
configure_issue_tracker.go
this is a file generated from examples/task-tracker. there are  some more changes but they all are related to the changes in this file.
The main idea is to force the handler to return one of the replays predefined for this particular method.

and yes, I can create a strict (and build api) examples based on the existing ones. just tell me which one suits best

Either the todo list api or the issue tracker example would be great

done

BTW, I need help adding tests for these options.

so essentially the change is it returns the more precise responder types instead of the interface?
And the builder changes because of that, including the not implemented error?

exactly

for tests we typically take a spec, generate code and verify that the files have the expected content through regex matchers etc.

I suppose this is not ready for merge yet is that correct?

from my point of view it is ready to be merged
it is in use in prod in some place at the moment
the parts are missing:

tests to satisfy the coverage checker
tests to actual test the functionality

unfortunately it looks like I'll not complete the tests

Unfortunately we need tests to accept this contribution, so that it doesn't inadvertently breaks. The last year we spent increasing our test coverage and stability.

Unfortunately we need tests to accept this contribution, so that it doesn't inadvertently breaks. The last year we spent increasing our test coverage and stability.

do you have your test system documented somewhere?
I might be able to assign somebody less busy/lazy to this task

I don't think we have it documented somewhere but it's pretty straight forward. You make a spec or take one of the pre-existing ones, and then call render. We have tons of tests that all look like this:
https://github.com/go-swagger/go-swagger/blob/master/generator/discriminators_test.go#L38-L65
Or more in line with this changeset:
https://github.com/go-swagger/go-swagger/blob/master/generator/server_test.go#L347-L379

@onokonem I've had a look at this work and was surprised about the way you are duplicating a lot of templates.
Is this change so hard on response, etc templates so as to require an entire copy of this source?
Couldn't the same be achieved with proper {{ if .Stricts }} ... {{ else }} ... {{ end }} with a single template?

Couldn't the same be achieved with proper {{ if .Stricts }} ... {{ else }} ... {{ end }} with a single template?

@fredbi , of course it could
But these templates are overcomplicated already.

But these templates are overcomplicated already.

So you think that duplicating the source would make the overall solution simpler to maintain and safer to use? I don't think anyone is going to apply their changes everywhere and maintain both sets of templates.
Another way to "fork out" templates is to add "contrib" templates, which live their own lives next to the main templates set.

Another way to "fork out" templates is to add "contrib" templates, which live their own lives next to the main templates set

I've tried that first, but found I need one more parameter passed to templates.
So I've added them
For my own task I've added the templates we are using to the project.
And yes, I'm ready to discuss how this has to be refactored to be added to the upstream, as it is a little pain to maintain the fork.

great, will do on weekend

replaced by https://github.com/go-swagger/go-swagger/pull/2312


chore(master): release 1.2.28

:robot: I have created a release beep boop
1.2.28 (2023-08-13)
Miscellaneous

deps: update dependency phpunit/phpunit to v10.3.1 (97cab54)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/laravel-symfony-serializer/releases/tag/v1.2.28 :sunflower:


Node Agent Integration

gRPC Worklod Service Server Integration
Add a wrapper for containerd-client lib (and ctr cli for creation) to create a container and run a workload.
The wrapper uses gRPC to communicate to the containerd socket. It reconnects to the socket before each request. This is done to avoid potential issues with resource management, isolation, and security and simplicity. It is also more fault-tolerant.
This will however mean more resource usage, overhead, latency, potential socket exhaustion, etc.. This is a tradeoff we are willing to make for now, since these issues are not likely to be a problem in the near future.
The ctr cli was used to create the container because the containerd-client we did not manage to create a container with the containerd-client lib. It runs the command ctr run -d <image> <container-id>.
The containerd-client lib was also used to kill the container. We did however have an issue concerning an ambiguous type efinition. Indeed, the Workload Signal enum is ambiguous. It is not clear what signal STOP represents. For now we made the assumption that stop is SIGINT (2). Both Stop (SIGINT) and Kill (SIGKILL) signals are sent to the workload, then the workload is cleaned up.
Note: It seems Kuruyia has managed to prepare a rootfs and run a container, you can find it here.
But to be honest, going with runc or a container runtime made in rust might be an easier way to achieve our goals.
gRPC Lifecycle Service Client and Status Update Service Client Integration
When the program starts, it connects to the scheduler and registers itself to it. If it fails, it will retry every 5 seconds. If it fails 3 times (can be modified in args or env see node-agent/src/args.rs), it will exit. It also starts the gRPC server.
If any of the two processes fail (gRPC of lifecycle), the server will shut down and try to leave the cluster if needed.
Note: We would be glad to know how you think we managed the application's lifecycle. It was a first for us, and it feels clunky.
Cargo Workspaces
We added a Cargo.toml file at the root of the project to manage the dependencies of the different crates. Building, formatting and linting will now be easier.
However, we had an issue when building the node-agent. When you build the binary from the root of the project, requests to the containerd socket fails, saying it didn't find it. We did not manage to fix this issue. We did however manage to make it work only if build from the node-agent directory. We are not sure why this is happening.
Misc
Add ide directory to gitignore.
What's next
Use the network team's CNI implementation.
@sameo
@noetarbouriech

@Martin-Moreira-de-jesus Let me know when I should review this PR, it is still in draft.

Sure, we've been struggling with containerd so far. We're getting there...

To be rebased.

.

@sameo done !

I just realized cargo fmt formatted the controller's code, is that an issue ?


Experiment with dropping default serde dep

Related #214
Motivation
This was an experiment to see how difficult it would be to drop serde usage by default (including serde_json and serde_yaml). The idea was to see how lightweight insta could be in both clean compile times and the number of dependencies if someone was just using the debug, display, and string snapshot formats
(Spoilers) :boom: Breaking Changes :boom:

This does involve removing the Deserialie and Serialize trait from several publicly exposed types
The type for info got changed to a String although I think it could just be moved behind the serialization feature flag
The assert_yaml_snapshot!() and assert_json_snapshot!() formats got moved behind the yaml and json feature flags respectively

Implementation
The serde implementation was replaced by a handwritten baby version that somewhat follows the same principle. The idea is still to translate the underlying data format to a common structure (in this case crate::parse::Value) and to have logic to serialize and deserialize data for structs with that common format
To make the implementation simple the common format is kept very basic to make it easy to map to the data returned by the parsers (This can be seen in src/parse/mod.rs). Also the mapping of the common data format to different structs had to be handwritten instead of just being able to use #[derive(Deserialize, Serialize)] (This can be seen in src/snapshot.rs)
Results
Big dislaimer: The main benefit is to people who can get by with just the debug, display, and string snapshot formats
This drastically drops the number of default dependencies
$ cargo tree --edges no-dev
insta v1.17.1 (/home/wintermute/Programming/Repos/insta)
├── console v0.15.1
│   ├── libc v0.2.126
│   ├── once_cell v1.11.0
│   └── terminal_size v0.1.17
│       └── libc v0.2.126
├── json v0.12.4
├── linked-hash-map v0.5.6
├── once_cell v1.11.0
├── similar v2.1.0
│   ├── bstr v0.2.17
│   │   ├── lazy_static v1.4.0
│   │   ├── memchr v2.5.0
│   │   └── regex-automata v0.1.10
│   └── unicode-segmentation v1.9.0
└── yaml-rust v0.4.5
    └── linked-hash-map v0.5.6

Along with having a large impact on clean build times (Note before filters out crates that built in less than 0.3 seconds while after filters out less than 0.2s)
Before

After

I also took a brief survey over 20 highly downloaded crates that use insta to see how many use formats outside of debug, default, and string. From
cargo-emit	    cynic	   hostlist-parser   opentelemetry-application-insights  symbolic-debuginfo
cargo-watch	    cynic-codegen  html_parser	     paperclip				 symbolic-symcache
cargo-workspaces    delog	   lustre_collector  similar				 syn
codespan-reporting  full_moon	   minijinja	     stylua				 test-case

only cynic, full_moon, and html_parser used a format outside of debug, default, and string. yaml for cynic and full_moon and json for html_parser
Pending Work
I didn't want to take the time to polish everything since I'm not sure this will even be merged considering it involves breaking changes

Going through and updating docs
Probably switching info back to Serialize probably

I like this a lot. There are even quite quite significant benefits for people who are using the serde formats with this. However what I'm not a fan of is that the snapshot format no longer carries info directly and expression is missing entirely:
Before:
---
source: tests/test_settings.rs
description: The snapshot are four integers
expression: "vec![1, 2, 3, 4]"
info:
  env:
    ENVIRONMENT: production
  cmdline:
    - my-tool
    - run
---

After:
---
source: tests/test_settings.rs
description: The snapshot is four integers
info: "env: [\"ENVIRONMENT\", \"production\"], cmdline: [\"my-tool\", \"run\"]"
---

I generally think that the info change to a string would be something I would not be okay with. Since apparently yaml is a dependency now anyways it should be easy enough to parse this. The info object can also be represented by the internal Value type rather than the serde_yaml Value type instead.
More importantly in general content::Content and parse::Value are more or less duplicates. I think it would be a better call to make them the same type and only add the serde specific trait implementations for the former as needed. There is no need to carry two value types in the crate for what is effectively the same purpose. The many different types on the content type could be phased out, they are not that useful and i believe they are already invisible to observers.
I also generally believe that serde_json and serde_yaml could be entirely pointless as dependencies. For as long as Content/Value implements optionally serde::Serialize it would be possible to make a minimal adapter that just serializes out via yaml/json.
In the interest of cutting out more dependencies the json dependency as it exists at the moment is completely unneeded. The only use of parsing seems to be the cargo manifest which can be parsed with the yaml crate as well.
Good work overall. I think this can turn into something quite valuable!

I totally agree with all the feedback. A brief summary:

Drop parse::Value in favor of content::Content
Switch info to store a Value/Content and potentially expose two apis to set it (one by giving the raw value and the other taking some Serialize type)
Potentially drop serde_json and serde_yaml entirely by substituting Content rendering to json/yaml

The one thing I still have questions on is

In the interest of cutting out more dependencies the json dependency as it exists at the moment is completely unneeded. The only use of parsing seems to be the cargo manifest which can be parsed with the yaml crate as well

I'm assuming that you're mixing up YAML and TOML when it comes to parsing the manifests unless there's something else I'm missing
Also worth noting that json is currently being used to create the pending inline snapshot files which seems to be a line delimited JSON format. I wonder if we could store them as a YAML array instead. It should be possible to make cargo-insta handle both formats to handle backwards compatibility

Good work overall. I think this can turn into something quite valuable! Oh in terms of if this could be merged: absolutely. Mostly because I believe this could even be smooth by going in two version steps:

In the first release: a new _hidden_serde feature is added which is on by default which gates Serialize and Deserialize on public traits along with the serde based assertion macros and gives a deprecation warning unless the necessary yaml and json features are also enabled.
Next release that is off by default.

Awesome! That's great to hear
I'll work towards addressing all the feedback above, and thanks for fixing expression being missing. That change was unintentional :sweat_smile:

I'm assuming that you're mixing up YAML and TOML when it comes to parsing the manifests unless there's something else I'm missing

YAML is a superset of JSON so for the purpose of reading cargo manifest files you can use the yaml-rust crate:
use std::process::Command;

fn main() {
    let out = Command::new("cargo")
        .arg("read-manifest")
        .output()
        .unwrap();
    let manifest = yaml_rust::YamlLoader::load_from_str(
        std::str::from_utf8(&out.stdout).unwrap()).unwrap();
    dbg!(manifest);
}

About this in particular:

Also worth noting that json is currently being used to create the pending inline snapshot files which seems to be a line delimited JSON format. I wonder if we could store them as a YAML array instead. It should be possible to make cargo-insta handle both formats to handle backwards compatibility

For now I would probably keep the logic here but since insta (not cargo insta) only needs to emit these files I wouldn't be entirely opposed to a minimal JSON emitter which can be used for snapshots and this. #256 already showed that relying on generic serialization libraries is not great for insta as formats change all the time with updates, so actually having an embedded JSON emitter in insta is something I would probably prefer having anyways. But in the interest of keeping the PR mergeable I think that should be a followup task. So I would keep the json dependency exclusively for the inline snapshots pending file for now, and I will then follow up with something that kills that too.

Pushed changes that:

Replace usages of parse::Value with content::Content
Make info take Serialize and add in a raw_info that takes a content::Content e.g.

use insta::internals::Content;

let raw_info = Content::Map(vec![
    (
        Content::from("env"),
        Content::Seq(vec![
            Content::from("ENVIRONMENT"),
            Content::from("production"),
        ]),
    ),
    (
        Content::from("cmdline"),
        Content::Seq(vec![Content::from("my-tool"), Content::from("run")]),
    ),
]);
with_settings!({description => "The snapshot is four integers", raw_info => &raw_info}, {
    assert_debug_snapshot!(vec![1, 2, 3, 4])
});

Lower the MSRV to 1.51.0 when using default features

I think this is a good stopping point for this PR to avoid scope creep and trying out a bunch of changes that may need hashing out. With that said the pending work left is (which I'm certainly happy to work on, but feel free to pick some if you want)

[ ] Switch cargo manifest parsing and pending inline snapshots to use YAML dropping the need for json

This will involve changes in cargo-insta to support both formats for backwards compat.

[ ] Evaluate replacing serde_yaml with Content::as_yaml (manually verify with several projects to make sure there aren't any differences)
[ ] Smooth the breaking changes with:

In the first release: a new _hidden_serde feature is added which is on by default which gates Serialize and Deserialize on public traits along with the serde based assertion macros and gives a deprecation warning unless the necessary yaml and json features are also enabled.

[ ] Deprecate the backtrace feature now that it's no longer used? (seems like we might as well)
[ ] Update docs to reflect all the changes

This looks very good. I think I will be merging this to master and then look from there how to close on the remaining items.


perf: Optimize performance of Results and Samples tables on Explore

SUMMARY
This PR fixes an issue described in a comment https://github.com/apache/incubator-superset/issues/11968#issuecomment-747945240
I wrapped table components in React.memo and removed unnecessary rerenders of copy to clipboard button.
However, the biggest change is adding virtualization (react-window) for react-table, which improves the performance drastically for tables with many rows.
However, due to how react-window works (which is wrapping row components in 2 divs) I had to stop using <table> and other table-related html tags in favour of divs, since the divs from react-window were breaking the table. Also, I needed to add a react-table plugin useBlockLayout, which requires the table cells to have fixed widths. The result is that we no longer benefit from cell widths being calculated by the browser, which is a huge bummer. I tried a few hacks to keep <table> tags (like wrapping divs generated by react-table in <td>), but all of them generated layout issues.
I'd appreciate any suggestions on how I could improve this PR, especially when it comes to solving the issues with table layout!
CC: @rusackas, @nytai, @ktmud, @villebro
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
The changes are related only to the table.
Before - super slow performance:
https://user-images.githubusercontent.com/15073128/103567566-5580e800-4ec4-11eb-8cfd-7ab4f82587e2.mov
After:
https://user-images.githubusercontent.com/15073128/103567676-84975980-4ec4-11eb-8e51-c8541073be05.mov
TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Closes https://github.com/apache/incubator-superset/issues/11968#issuecomment-747945240

Codecov Report

Merging #12257 (b60eeaf) into master (f3ab1f4) will decrease coverage by 2.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12257      +/-   ##
==========================================
- Coverage   66.20%   63.58%   -2.62%
==========================================
  Files         996      485     -511
  Lines       49174    29791   -19383
  Branches     4993        0    -4993
==========================================
- Hits        32554    18943   -13611
+ Misses      16476    10848    -5628
+ Partials      144        0     -144

Flag
Coverage Δ

cypress
?

javascript
?

python
63.58% <ø> (-0.64%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-12.78%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/utils/celery.py
96.42% <0.00%> (-3.58%)
:arrow_down:

superset/db_engine_specs/postgres.py
82.45% <0.00%> (-3.51%)
:arrow_down:

superset/examples/world_bank.py
97.10% <0.00%> (-2.90%)
:arrow_down:

superset/examples/birth_names.py
96.51% <0.00%> (-2.33%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

... and 519 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc0de1...b60eeaf. Read the comment docs.

Codecov Report

Merging #12257 (b60eeaf) into master (f3ab1f4) will decrease coverage by 2.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12257      +/-   ##
==========================================
- Coverage   66.20%   63.58%   -2.62%
==========================================
  Files         996      485     -511
  Lines       49174    29791   -19383
  Branches     4993        0    -4993
==========================================
- Hits        32554    18943   -13611
+ Misses      16476    10848    -5628
+ Partials      144        0     -144

Flag
Coverage Δ

cypress
?

javascript
?

python
63.58% <ø> (-0.64%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-12.78%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/utils/celery.py
96.42% <0.00%> (-3.58%)
:arrow_down:

superset/db_engine_specs/postgres.py
82.45% <0.00%> (-3.51%)
:arrow_down:

superset/examples/world_bank.py
97.10% <0.00%> (-2.90%)
:arrow_down:

superset/examples/birth_names.py
96.51% <0.00%> (-2.33%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

... and 519 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc0de1...b60eeaf. Read the comment docs.

Not sure if it's related to this PR, but I'm getting triple scrollbars (and cut-off cell values, 😱) in the preview pane for the recently added "cleaned_sales_data" dataset.

（Confirmed. It is from this PR.)

😱😱 Thanks for finding this, will fix!

Not sure if it's related to this PR, but I'm getting triple scrollbars (and cut-off cell values, 😱) in the preview pane for the recently added "cleaned_sales_data" dataset.

（Confirmed. It is from this PR.)

😱😱 Thanks for finding this, will fix!

It getting virtualized table to work is too much a hassle, I'd recommend try adding pagination instead. The DataTable used by table viz is quite performant when used with pagination, so I'd assume it's the same with this implementation, too.

It getting virtualized table to work is too much a hassle, I'd recommend try adding pagination instead. The DataTable used by table viz is quite performant when used with pagination, so I'd assume it's the same with this implementation, too.

@ktmud I'm kinda sad to let virtualization go, but using pagination does seem to be the most reasonable solution now. I set a page size 50 and I think it works fine. Can you check it out again?
@nikolagigic FYI, I removed your function getDataTablePageSize, as we'll no longer need it since we use pagination by default.

@ktmud I'm kinda sad to let virtualization go, but using pagination does seem to be the most reasonable solution now. I set a page size 50 and I think it works fine. Can you check it out again?
@nikolagigic FYI, I removed your function getDataTablePageSize, as we'll no longer need it since we use pagination by default.

While testing this I had very ugly behavior where Data title is moved to the middle of the table while adjusting size of bottom part.
https://user-images.githubusercontent.com/25153919/103952657-101d1e80-5141-11eb-862e-cfea51dfd7c8.mov

Click on Data title move bottom table to the original position - not sure if it works as expected.
@kgabryje Could you test it as well on your machine?

While testing this I had very ugly behavior where Data title is moved to the middle of the table while adjusting size of bottom part.
https://user-images.githubusercontent.com/25153919/103952657-101d1e80-5141-11eb-862e-cfea51dfd7c8.mov

Click on Data title move bottom table to the original position - not sure if it works as expected.
@kgabryje Could you test it as well on your machine?

@kgabryje Can you quickly address @adam-stasiak comment so that we can merge this PR? 🙏

@kgabryje Can you quickly address @adam-stasiak comment so that we can merge this PR? 🙏

@adam-stasiak I think that this bug was caused by changes made on January 6th in file src/explore/components/ExploreChartPanel.jsx. It's unrelated to this PR - we should open a separate issue to fix that bug.
CC @ktmud

@adam-stasiak I think that this bug was caused by changes made on January 6th in file src/explore/components/ExploreChartPanel.jsx. It's unrelated to this PR - we should open a separate issue to fix that bug.
CC @ktmud

The performance problem seems fixed. However, while testing, I found a couple of more bugs (some of them probably not related to this PR):

Change datasource does not update the samples
Previously the query state is persistent when editing an existing chart (e.g. if you change something and, hit Run, and refresh the page, your changes to the form data are persisted in the URL). This is now broken.
We probably shouldn't show "0 rows" in an error state while it is still loading:

Many styling issues which I don't even categorize as "cosmetic":

a) search input is cut off
b) sort icons break into another line
This happens when there are too many columns (tested with the wh_health_data dataset)
Scrolling (both horizontally and vertically) moves the pagination bar

which makes it almost unusable.

Not sure how feasible it is, maybe it's worth looking into rendering this table with DataTable from the table viz plugin. It handles many rendering issues like this. I had a plan to generalize that implementation, but didn't have time to finish. If someone can pick it up from where it was left, that would be also great.

The performance problem seems fixed. However, while testing, I found a couple of more bugs (some of them probably not related to this PR):

Change datasource does not update the samples
Previously the query state is persistent when editing an existing chart (e.g. if you change something and, hit Run, and refresh the page, your changes to the form data are persisted in the URL). This is now broken.
We probably shouldn't show "0 rows" in an error state while it is still loading:

Many styling issues which I don't even categorize as "cosmetic":

a) search input is cut off
b) sort icons break into another line
This happens when there are too many columns (tested with the wh_health_data dataset)
Scrolling (both horizontally and vertically) moves the pagination bar

which makes it almost unusable.

Not sure how feasible it is, maybe it's worth looking into rendering this table with DataTable from the table viz plugin. It handles many rendering issues like this. I had a plan to generalize that implementation, but didn't have time to finish. If someone can pick it up from where it was left, that would be also great.

Merging since this is still better than status quo.

Merging since this is still better than status quo.

Merging since this is still better than status quo.

Thanks for merging this PR and pointing additional issues out. (@ktmud you are the best!)! We really should have caught those by ourselves. 😿  will address all those in separate PR 🙏

Merging since this is still better than status quo.

Thanks for merging this PR and pointing additional issues out. (@ktmud you are the best!)! We really should have caught those by ourselves. 😿  will address all those in separate PR 🙏

Thank you for pointing out those bugs @ktmud !

Thank you for pointing out those bugs @ktmud !


Download progress indicator should be human formatted

Feature Request
Is your feature request related to a problem? Please describe:
The progress bars are useful, but on large files it is hard to see the size without formatting. i.e.
download https://tiup-mirrors.pingcap.com/pd-nightly-linux-amd64.tar.gz:
33213324 / 33213324 [-----------------------------------------------------------------------------------------------------------------------------------------------] 100.00% 7776611 p/s

I believe the p/s should also be k/s.
Describe the feature you'd like:
It would be nice if it looked like this instead:
download https://tiup-mirrors.pingcap.com/pd-nightly-linux-amd64.tar.gz:
31.67 M / 31.67 M [-----------------------------------------------------------------------------------------------------------------------------------------------] 100.00% 13.6 M/s

Describe alternatives you've considered:
I use gnome terminal, so I can see the sizes in human format by right clicking on them. But that is a bit of an inconvenience.. and not available to all users.
Teachability, Documentation, Adoption, Migration Strategy:
N/A, cosmetic change.

Closed via #152


How is the VRAM usage?

When I looked at RunwayML's Stable Diffusion (the official implementation, right?), it takes 10GB of VRAM to run a simple SD1.5. Comfy can do this with only 1GB of VRAM by only loading the necessary models into VRAM and leaving the others in RAM.
Can diffusers manage memory in a similar way to reduce VRAM requirements? I am not very familiar with diffusers and am just curious.

Hey! Wow that looks like a lot indeed! Personally I've built upon Hugging Face's diffusers API, and I think they have put in place several parameters to lower VRAM consumption, such as pipe.enable_cpu_offload(), that sort of thing. I can for example use SDXL on a 8Gb GPU thanks to that kind of flags!

By the way you can also offload some of the work through your RAM by using Deepspeed, but I found that library kind of difficult to install, I've not investigated it much yet

I can for example use SDXL on a 8Gb GPU thanks to that kind of flags!

That's promising~!

It is! I was planning to create a Diffusers notebook sometime this week to keep track of all my experimentations on this subject, I'll share the repo with you if you're interested!

sure, please share it with me!
P.S. I am going to Europe for a family trip and will be back to coding in about a month.

Okay have fun!!
I'll keep you posted when I've started the notebook, it gives me some time to do it before you're back ^^'


Can supply a default return value to get()

This does not introduce any breaking changes.
Closes #52

Why only add the functionality to get(), what about search()?

Also, why not just catch KeyError and set the default value?

what about search()?
I'm on the fence but with search(). When searching you're potentially getting back an iterator and it feels weird to populate that with a default value. I haven't come across a use case where I've wanted a default value with search(), but I'm happy to add it if you think it would be useful?

why not just catch KeyError and set the default value?
You could definitely do that, but I think that this is a common enough case and catching an exception an "ugly" enough solution that it's worthwhile. .get() exists on a dictionary for this reason, even though you can catch the KeyError from using dict[].


The directory profiler/bin doesn't exist in the folder /opt/rocm

I have installed ROCM  by instruction from https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html#ubuntu
After installation both utilits works properly
/opt/rocm/bin/rocminfo
/opt/rocm/opencl/bin/clinfo
in the documentation one of the step is add a PATH parameter
echo 'export PATH=$PATH:/opt/rocm/bin:/opt/rocm/profiler/bin:/opt/rocm/opencl/bin' | sudo tee -a /etc/profile.d/rocm.sh
but directory /opt/rocm/profiler/bin doesn't exist. Is it ok ?
(base) yuriy@yuriy-System-Product-Name:~$ cd /opt/rocm
(base) yuriy@yuriy-System-Product-Name:/opt/rocm$ ls -l
total 36
drwxr-xr-x 3 root root 4096 ნოე 12 21:45 amdgcn
drwxr-xr-x 2 root root 4096 ნოე 12 21:45 bin
drwxr-xr-x 4 root root 4096 ნოე 12 21:45 hsa
drwxr-xr-x 3 root root 4096 ნოე 12 21:45 include
drwxr-xr-x 3 root root 4096 ნოე 12 22:04 lib
drwxr-xr-x 4 root root 4096 ნოე 12 21:45 oam
drwxr-xr-x 5 root root 4096 ნოე 12 21:45 opencl
drwxr-xr-x 6 root root 4096 ნოე 12 21:45 rocm_smi
drwxr-xr-x 9 root root 4096 ნოე 12 21:45 share
(base) yuriy@yuriy-System-Product-Name:/opt/rocm$

Thank you for reaching out. The issue is now resolved, and the directory is corrected at:
https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html#ubuntu
AMD ROCm Documentation

Thank you for reaching out. The issue is now resolved, and the directory is corrected at:
https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html#ubuntu
AMD ROCm Documentation

But directory /opt/rocm  also doesn't contain the director rocprofiler/bin. See a list of directories below.
Why?    Which commands or processes should create this directory?
(base) yuriy@yuriy-System-Product-Name:/opt/rocm$ ls -l
total 36
drwxr-xr-x 3 root root 4096 ნოე 12 21:45 amdgcn
drwxr-xr-x 2 root root 4096 ნოე 12 21:45 bin
drwxr-xr-x 4 root root 4096 ნოე 12 21:45 hsa
drwxr-xr-x 3 root root 4096 ნოე 12 21:45 include
drwxr-xr-x 3 root root 4096 ნოე 12 22:04 lib
drwxr-xr-x 4 root root 4096 ნოე 12 21:45 oam
drwxr-xr-x 5 root root 4096 ნოე 12 21:45 opencl
drwxr-xr-x 6 root root 4096 ნოე 12 21:45 rocm_smi
drwxr-xr-x 9 root root 4096 ნოე 12 21:45 share
(base) yuriy@yuriy-System-Product-Name:/opt/rocm$

Thanks @YuriyTigiev
Actually rocprofiler should also be under /opt/rocm.
Can you please share steps you followed to install ROCm.
Thank you.

Thanks @YuriyTigiev
Actually rocprofiler should also be under /opt/rocm.
Can you please share steps you followed to install ROCm.
Thank you.

Step by step for Ubuntu
https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html#ubuntu

Thanks.
Looks like your installation did not go well. There might be problem with uninstallation of old rocm (or) issue with installation of new rocm.
Below installation steps should create rocprofiler also.

sudo apt update
sudo apt dist-upgrade
sudo apt install libnuma-dev
wget -q -O - https://repo.radeon.com/rocm/rocm.gpg.key | sudo apt-key add -
echo 'deb [arch=amd64] https://repo.radeon.com/rocm/apt/debian/ xenial main' | sudo tee /etc/apt/sources.list.d/rocm.list
sudo apt update
sudo apt install rocm-dkms && sudo reboot

In my case, all folders are visible.
master@master:/opt/rocm$ ls
amdgcn  bin  hip  hsa  hsa-amd-aqlprofile  include  lib  llvm  oam  opencl  rocm_smi  rocprofiler  roctracer  share

I did but without changes.
Please see my steps and results.
(base) yuriy@yuriy-System-Product-Name:~$ sudo apt update
[sudo] password for yuriy:
Hit:1 http://dl.google.com/linux/chrome/deb stable InRelease
Hit:2 http://us.archive.ubuntu.com/ubuntu focal InRelease
Get:3 http://repo.radeon.com/rocm/apt/debian xenial InRelease [1.817 B]
Hit:4 http://archive.canonical.com/ubuntu focal InRelease
Hit:5 http://us.archive.ubuntu.com/ubuntu focal-updates InRelease
Hit:6 http://us.archive.ubuntu.com/ubuntu focal-backports InRelease
Hit:7 http://us.archive.ubuntu.com/ubuntu focal-security InRelease
Fetched 1.817 B in 1s (1.813 B/s)
Reading package lists... Done
Building dependency tree
Reading state information... Done
All packages are up to date.
(base) yuriy@yuriy-System-Product-Name:~$ sudo apt dist-upgrade
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
(base) yuriy@yuriy-System-Product-Name:~$ sudo apt install libnuma-dev
Reading package lists... Done
Building dependency tree
Reading state information... Done
libnuma-dev is already the newest version (2.0.12-1).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
(base) yuriy@yuriy-System-Product-Name:~$ wget -q -O - https://repo.radeon.com/rocm/rocm.gpg.key | sudo apt-key add -
OK
(base) yuriy@yuriy-System-Product-Name:~$ echo 'deb [arch=amd64] https://repo.radeon.com/rocm/apt/debian/ xenial main' | sudo tee /etc/apt/sources.list.d/rocm.list
deb [arch=amd64] https://repo.radeon.com/rocm/apt/debian/ xenial main
(base) yuriy@yuriy-System-Product-Name:~$ sudo apt update
Hit:1 http://dl.google.com/linux/chrome/deb stable InRelease
Hit:2 http://archive.canonical.com/ubuntu focal InRelease
Hit:3 http://us.archive.ubuntu.com/ubuntu focal InRelease
Hit:4 http://us.archive.ubuntu.com/ubuntu focal-updates InRelease
Hit:5 http://us.archive.ubuntu.com/ubuntu focal-backports InRelease
Get:6 https://repo.radeon.com/rocm/apt/debian xenial InRelease [1.817 B]
Hit:7 http://us.archive.ubuntu.com/ubuntu focal-security InRelease
Fetched 1.817 B in 1s (1.564 B/s)
Reading package lists... Done
Building dependency tree
Reading state information... Done
All packages are up to date.
(base) yuriy@yuriy-System-Product-Name:~$ sudo apt install rocm-dkms
Reading package lists... Done
Building dependency tree
Reading state information... Done
rocm-dkms is already the newest version (<IP_ADDRESS>901-19).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

After restart

(base) yuriy@yuriy-System-Product-Name:/opt/rocm$ ls -l
total 88
drwxr-xr-x  3 root root 4096 ნოე 12 21:45 amdgcn
drwxr-xr-x  2 root root 4096 ნოე 12 21:45 bin
drwxr-xr-x  4 root root 4096 ნოე 12 23:11 hipblas
drwxr-xr-x  4 root root 4096 ნოე 12 23:11 hipcub
drwxr-xr-x  4 root root 4096 ნოე 12 23:11 hiprand
drwxr-xr-x  4 root root 4096 ნოე 12 23:11 hipsparse
drwxr-xr-x  4 root root 4096 ნოე 12 21:45 hsa
drwxr-xr-x 11 root root 4096 ნოე 12 23:11 include
drwxr-xr-x  4 root root 4096 ნოე 12 23:11 lib
drwxr-xr-x  6 root root 4096 ნოე 12 23:11 miopen
drwxr-xr-x  4 root root 4096 ნოე 12 21:45 oam
drwxr-xr-x  5 root root 4096 ნოე 12 21:45 opencl
drwxr-xr-x  4 root root 4096 ნოე 12 23:11 rocalution
drwxr-xr-x  4 root root 4096 ნოე 12 23:11 rocblas
drwxr-xr-x  4 root root 4096 ნოე 12 23:11 rocfft
drwxr-xr-x  6 root root 4096 ნოე 12 21:45 rocm_smi
drwxr-xr-x  4 root root 4096 ნოე 12 23:11 rocprim
drwxr-xr-x  4 root root 4096 ნოე 12 23:11 rocrand
drwxr-xr-x  4 root root 4096 ნოე 12 23:11 rocsolver
drwxr-xr-x  4 root root 4096 ნოე 12 23:11 rocsparse
drwxr-xr-x  4 root root 4096 ნოე 12 23:11 rocthrust
drwxr-xr-x 10 root root 4096 ნოე 12 23:11 share

Looks like your old ROCm installatio before installing this new ROCm did not go well.
Now you tried installing on top of existing ROCm, can not do any upgrade and so sticks the same.
(base) yuriy@yuriy-System-Product-Name:~$ sudo apt install rocm-dkms
Reading package lists... Done
Building dependency tree
Reading state information... Done
rocm-dkms is already the newest version (<IP_ADDRESS>901-19).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Have 2 ways.
way 1. Uninstall every package along with rocm-dkms using sudo apt autoremove rocm-dkms followed by all other packages, as shown below.

Remove all libs first before installing complete rocm.
sudo apt autoremove rocm-libs
Remove rocm
sudo apt autoremove rocm-dkms
Remove any other available packages
Check and remove one by one like..
sudo dpkg -l | grep
sudo apt remove

Make sure to remove all pkgs and also /opt/rocm is clean.
Now install rocm again freshly like suod apt install rocm-dkms --> should install all packages
way 2: You can install all missing/reuired packages one by one
sudo apt install rocprofiler-dev roctracer-dev hip-samples hip-doc hip-base hip-rocclr llvm-amdgpu hsa-amd-aqlprofile

Looks like your old ROCm installation did not go well before installing this new ROCm.
Now you tried installing on top of existing ROCm, can not do any upgrade and so it shows the same.
(base) yuriy@yuriy-System-Product-Name:~$ sudo apt install rocm-dkms Reading package lists... Done Building dependency tree Reading state information... Done rocm-dkms is already the newest version (<IP_ADDRESS>901-19). 0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Have 2 ways.
way 1. Uninstall every package along with rocm-dkms using sudo apt autoremove rocm-dkms followed by all other packages, as shown below.
1. Remove all libs first before installing complete rocm.
   sudo apt autoremove rocm-libs

2. Remove rocm
   sudo apt autoremove rocm-dkms

3. Remove any other available packages
   Check and remove one by one like..
   sudo dpkg -l | grep
   sudo apt remove

Make sure to remove all pkgs and also /opt/rocm is clean.
Now install rocm again freshly like suod apt install rocm-dkms --> should install all packages
way 2: You can install all missing/reuired packages one by one
sudo apt install rocprofiler-dev roctracer-dev hip-samples hip-doc hip-base hip-rocclr llvm-amdgpu hsa-amd-aqlprofile

I have reinstalled Ubuntu and ROCM and now the folder exists

Thanks @YuriyTigiev Good to know.
You can log any new issues in future.
Thank you.

Thanks.
Looks like your installation did not go well. There might be problem with uninstallation of old rocm (or) issue with installation of new rocm.
Below installation steps should create rocprofiler also.
1. sudo apt update

2. sudo apt dist-upgrade

3. sudo apt install libnuma-dev

4. wget -q -O - https://repo.radeon.com/rocm/rocm.gpg.key | sudo apt-key add -

5. echo 'deb [arch=amd64] https://repo.radeon.com/rocm/apt/debian/ xenial main' | sudo tee /etc/apt/sources.list.d/rocm.list

6. sudo apt update

7. sudo apt install rocm-dkms && sudo reboot

In my case, all folders are visible.
master@master:/opt/rocm$ ls
amdgcn bin hip hsa hsa-amd-aqlprofile include lib llvm oam opencl rocm_smi rocprofiler roctracer share

Is this the provided list enough for install rocm library ?

Thanks.
Looks like your installation did not go well. There might be problem with uninstallation of old rocm (or) issue with installation of new rocm.
Below installation steps should create rocprofiler also.
1. sudo apt update

2. sudo apt dist-upgrade

3. sudo apt install libnuma-dev

4. wget -q -O - https://repo.radeon.com/rocm/rocm.gpg.key | sudo apt-key add -

5. echo 'deb [arch=amd64] https://repo.radeon.com/rocm/apt/debian/ xenial main' | sudo tee /etc/apt/sources.list.d/rocm.list

6. sudo apt update

7. sudo apt install rocm-dkms && sudo reboot

In my case, all folders are visible.
master@master:/opt/rocm$ ls
amdgcn bin hip hsa hsa-amd-aqlprofile include lib llvm oam opencl rocm_smi rocprofiler roctracer share

Is this the provided list of command enough for install rocm library? The current list slightly different then list of command in the documentation.

The last command (sudo apt install rocm-dkms) enables basic rocm with all compilers and runtimes.
If you wish to have some rocm libraries also on top of this, do as sudo apt install rocm-libs rccl

You didn't use staps 5,6 from the documentation. Are they mandatory?
sudo usermod -a -G video $LOGNAME
sudo usermod -a -G render $LOGNAME

echo 'ADD_EXTRA_GROUPS=1' | sudo tee -a /etc/adduser.conf
echo 'EXTRA_GROUPS=video' | sudo tee -a /etc/adduser.conf
echo 'EXTRA_GROUPS=render' | sudo tee -a /etc/adduser.conf

These are needed only one time after OS is ready.


Use qualified names as IDs for LIonCore/the M3

Note: I might change some things here and there, and then force-push.


[Question] How to fix the exception : ZenjectException: Unable to resolve type 'A' while building object with type 'B'.  Object graph: B

I'm trying to load a prefab during runtime in one particular moment at my state machine. But I get this exception in runtime. All the scenes are validate with the Ctrl Left+Maj Left+V shortcut.
The context of the problem
My state machine is bind into the project context :
using Zenject;

namespace AVF.StateMachine
{
	/**
	 *	@class AVFStateMachineInstaller
	 *	Class used to represent the installer of the state machine
	 */
	public class AVFStateMachineInstaller : MonoInstaller<AVFStateMachineInstaller>
	{
		/**
		 *	Install the bindings between the objects
		 */
		public override void InstallBindings()
		{
			// Global factory
			Container.Bind<AVFStateFactory>().AsSingle();

			// States factories
			Container.BindFactory<AVFInitState, AVFInitState.Factory>().WhenInjectedInto<AVFStateFactory>();
			Container.BindFactory<AVFLoginState, AVFLoginState.Factory>().WhenInjectedInto<AVFStateFactory>();
			Container.BindFactory<AVFSelectJobState, AVFSelectJobState.Factory>().WhenInjectedInto<AVFStateFactory>();
		}
	}
}

The state are create with a function CreateState in the AVFFactory class. No problem of creating states and navigate between them when I want. Except when I try to load a prefab who contains a game object context. So, I understand that all the managing of the state machine exist into the project context only.
I put, in the installer of the scene context, the bind of the factories of my prefabs :
using UnityEngine;
using Zenject;
using AVF.StateMachine;

public class AVFSceneHubInstaller : MonoInstaller<AVFSceneHubInstaller>
{
	[SerializeField]
	GameObject mPrefabWeldingPedestal;
	[SerializeField]
	GameObject mPrefabSandboxPedestal;

	public override void InstallBindings()
	{
		Container.BindFactory<AVFSandboxPedestal, AVFSandboxPedestal.Factory>().FromSubContainerResolve().ByNewPrefab(mPrefabSandboxPedestal).WhenInjectedInto<AVFSelectJobState>();
		Container.BindFactory<AVFWeldingPedestal, AVFWeldingPedestal.Factory>().FromSubContainerResolve().ByNewPrefab(mPrefabWeldingPedestal).WhenInjectedInto<AVFSelectJobState>();
	}
}

My prefab contains a game object context with a installer :
using UnityEngine;
using Zenject;

public class AVFSandboxPedestalInstaller : MonoInstaller
{
	[SerializeField]
	private GameObject mPrefab;
	[SerializeField]
	private GameObject mAttachObject;

	public override void InstallBindings()
	{
		Container.BindInterfacesAndSelfTo<AVFSandboxPedestal>()
			.FromComponentInNewPrefab(mPrefab)
			.UnderTransform(mAttachObject.transform)
			.AsSingle();
	}
}

And a component for using the object with the factory :
using UnityEngine;
using VRTK;
using Zenject;

public class AVFSandboxPedestal : VRTK_InteractableObject
{
	public void Start()
	{
		Debug.LogWarning("HELLO SANDBOX");
	}

	public override void OnInteractableObjectUsed(InteractableObjectEventArgs e)
	{
		base.OnInteractableObjectUsed(e);

		Debug.LogWarning(gameObject.name + "USED");
	}

	public class Factory : Factory<AVFSandboxPedestal>
	{
	}
}

My state who need the instance of the factory is like that and it's when I want to create this object I reach the exception because it can't resolve the type AVFSandboxPedestal.Factory :
using UnityEngine;
using Zenject;
using Mimbus.StateMachine;
using AVF.Context;

namespace AVF.StateMachine
{
	/**
	 *	@class AVFSelectJobState
	 *	Class used to represent the select job state of the application
	 */
	public class AVFSelectJobState : MbStateEntity
	{
		// Class fields
		private readonly	AVFStateManager				mStateManager;				/**< The state manager */
		private readonly	AVFContext					mContext;					/**< Context of the application */
		private readonly	AVFHeadState				mHeadState;					/**< Common state of all states and scenes */
		private readonly	AVFSandboxPedestal.Factory	mSandboxPedestalFactory;	/**<  */

		/**
		 *	Constructor
		 *	@param[in] pStateManager The state manager of the application
		 *	@param[in] pContext The context of the application
		 */
		public AVFSelectJobState(AVFStateManager pStateManager, AVFContext pContext, AVFHeadState pHeadState,
			AVFSandboxPedestal.Factory pSandboxPedestalFactory)
		{
			this.mStateManager = pStateManager;
			this.mContext = pContext;
			this.mHeadState = pHeadState;
			this.mSandboxPedestalFactory = pSandboxPedestalFactory;
		}

		/**
		 *	Initialize this object
		 */
		public override void Initialize()
		{
			Debug.Log("Select job state start");
			this.mSandboxPedestalFactory.Create();
		}
// Other lines of code .....

What I already try
I think the problem is : I have my state machine and the state into the project context and my prefab in his own context. So, apparently, it can't work. (No?)
So I try to add a Zenject Binding component on my prefab, I add the AVFSandboxPedestal in it and add the project context in it too.
But it doesn't work.
I try to add the installers too, to bind to the scene context, but nothing work. I'm out of solutions for that problem and reading the documentation over and over again don't help me right now. So I turn myself to you and ask for help.
NB : I don't want the actual prefab persist in all scenes just in the actual scene. But the state machine have to persist in all scenes.
NB : If you need more precisions. Just ask. ;)
Thanks ! :)

I was facing a similar issue, and this helped me: https://github.com/modesttree/Zenject/blob/master/Documentation/SubContainers.md#creating-game-object-contexts-dynamically-with-parameters

When you use BindFactory, the factory will create the object with whatever container you used with BindFactory.  So in this case, it will try and create AVFSelectJobState using the DiContainer for ProjectContext, which is why it can't find the scene context bindings.
It sounds like you added a ZenjectBinding component and set the Context property to ProjectContext?  That won't do anything because ZenjectBinding is only processed during the project context install which is over by the time you instantiate the prefab.
It's hard to make suggestions here without knowing more about what you're trying to do with the state machine.  I would ask though, why are you trying to instantiate a prefab that has dependencies on objects inside a game object context from within code inside project context?   That seems kind strange but again I don't really know much about what you're trying to do


Adding Views in MainViewController

I added some view (UILable and Buttons) in the View Controller which is set as the MainViewController but it is not being shown in the screen.
Thanks for you help!

Can u post your code?


Popup Registration Window for Unregistered Users Submitting Blog Comments

Detailed description
When an unregistered user attempts to submit a comment on a blog post, a popup window should appear, prompting them to register or log in before they can proceed. This feature aims to improve user engagement and streamline the comment submission process for authenticated users.
Context
This change is important to me because it enhances user interaction and improves the quality of comments on the blog. I would use this feature to ensure that all comments are from authenticated users, thereby maintaining a higher standard of community interaction. This can benefit other users by creating a more secure and trustworthy commenting system, and reducing the likelihood of spam comments.
Possible implementation
Since there is already a login modal available in the repository, we can leverage it to implement this feature. The steps are as follows:
React Component Logic:
Add a check in the comment submission handler to verify if the user is logged in.
If the user is not logged in, trigger the existing login modal using React state.
Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I want to solve it


PublishTestResult + NUnit3 report: publishing of test attachments with relative path not working

Should it be possible to publish the test attachments with a relative path in Azure DevOps for NUnit3 reports?
The task is configured like this:
- task: PublishTestResult@2
   inputs:
     testResultsFormat: 'NUnit'
     testResultsFiles: 'tmp/report.xml'
     publishRunAttachments: true

The report looks like this:
<?xml version="1.0" encoding="UTF-8" ?>
<test-run>
    <test-suite type="Assembly" name="...">
        <-- ... -->
        <test-case name="..." result="Failed" duration="24.161">
            <failure>
                <message>
                    ...
                </message>
                <stack-trace>
                    ...
                </stack-trace>
            </failure>
            <attachments>
                <attachment>
                    <filePath>tmp/screenshots/errors/1.png</filePath>
                </attachment>
            </attachments>
        </test-case>
    </test-suite>
</test-run>

It seems that the file can not be found, even tough it is in the given location relative to $(System.DefaultWorkingDirectory):
##[warning]Skipping attachment as it is not available on disk: tmp/screenshots/errors/1.png

Is the search folder (default: $(System.DefaultWorkingDirectory)) not taken into consideration for attachments?
Should attachment path be absolute?
I also tried it on linux and windows build agents.
I can not find information about this in the docs:
https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/test/publish-test-results?view=azure-devops&tabs=yaml#nunit-3

You need to provide the absolute path in order to publish attachments via this method


Branch 136515806

Merged by hand:

tensorflow.bzl: make sure windows rule is preserved
remove extra rules (incl resnet and text_classification_save_restore)

From these PRs that have not been merged back:

136476925 conflicts with #4684
136410307 conflicts with #5009

@gunan could you check this?

Jenkins, test this please.

Sorry triggered the build again by accident. This PR passed on Jenkins http://ci.tensorflow.org/job/tensorflow-pull-requests-multijob/2232/. Merging it.


was this package deprecated?

How come it still isn't well documented?
how do I even run the example?
I'm used to npm, writing "npm run myRunCommand"
here it seems I should write npm run test
but it writes "no test specified" and some mre lines of errors

To run the example:

Build the example:
gulp build-example
It creates the repository public, which includes all html and js needed to run the example.
Open the file /path/to/validation-repo/public/index.html in your browser. You do not need to run any server.

Let me know if you encounter any other issues.
As for the documentation, I postponed its polishing, because I came up with some improvements which I wanted to implement first. I expected to have these improvements done long time ago, but I was obviously wrong. I am planning to work on this library again in June (I do not have any time left before that). I hope to finish all the improvements, but I will at least make sure to add sufficient documentation.


Beam Sync: stats

What is wrong?
Not much visibility into beam sync import timing, download timing, trie data size, node count, etc.
How can it be fixed
Add lots of timing and counting statistics to all the beam sync things.
One approach: when replying to a CollectMissingAccount, for example, reply with the number of nodes that were retrieved. Sum up the total in the patched VM (pausing_vm_decorator) and make it available to print out at the end of the import/preview. Note that summing up the previewed & imported amounts will be very difficult to do in an automated way.

Closed by #855 which includes several new stats outputs in the debug logs.


Addresses #75 - Remove unessecary units conversion in TethysComms

Depends on ignitionrobotics/ign-gazebo#1269.
This PR attempts to remove unnecessary unit conversions in tethys from angular velocity -> force -> angular velocity.
Signed-off-by: Arjo Chakravarty<EMAIL_ADDRESS>

Thats expected behavior. The hydrodynamic model is not stable in reverse and is not an issue since the vehicle does not operate in reverse.

We need to wait for upstream to be merged and the tests to pass before merging this one

Upstream is merged and released, retriggered CI :crossed_fingers:


Unable to redefine properties of the window object

🐛 Bug Report
Unable to redefine properties of the window object, using Object.defineProperty(window, 'property', ..).
Note: an issue was created with jsdom directly, however it seems to work fine when using jsdom outside jest, cf. jsdom/jsdom#2348
To Reproduce
The following outputs null:
Object.defineProperty(window, 'frameElement', {
   value: '123'
});
console.log('window.frameElement =', window.frameElement);

Expected behavior
The window property should take the new defined value.
Link to repl or repo (highly encouraged)
With jest: https://repl.it/repls/QuickwittedChubbyPredictions
With a browser: https://jsbin.com/dinipuhehe/edit?html,js,output
Run npx envinfo --preset jest
npx: installed 1 in 1.827s
Path must be a string. Received undefined
D:\git\pcxone\node_modules\envinfo\dist\cli.js

  System:
    OS: Windows 10
    CPU: x64 Intel(R) Core(TM) i7-2600K CPU @ 3.40GHz
  Binaries:
    Node: 8.9.1
    Yarn: 1.6.0
    npm: 5.5.1
  npmPackages:
    jest:
      wanted: 23.5.0
      installed: 23.5.0

Have you tried passing writable: true? See https://github.com/facebook/jest/issues/890#issuecomment-209698782 for more details

Same problem here. Any solution for this?

Same problem here. Any solution for this?

The linked reproduction in the OP passes for me using Jest 24.8
(well, almost. The tests expects 123 to be a number, but it's a string)


Celcat Web API documentation

Hi,
Are you able to provide the Celcat Web API documentation that was used to implement this wrapper?
I can't find any documentation on Celcats website

Hi @sterichards,
There are a few places you can get the documentation from,
The Celcat Web API has a built-in instance of swagger which you can find at https://celcatserver:5000/swagger/ui/index.html - you are meant to be able to test your API endpoints with swagger but Celcat haven't gotten this working.
They also have documentation on the wiki at https://www.celcat.wiki/en/guides/developers_guides/webapi/webapi
This wrapper is a work in progress and hasn't reached anywhere near a v1!
Neil

Very kind, thank you!

Not a problem, I've only implemented what I need from the API so far. This only involves gets so far. Happy to receive PRs if you want to add anything to this.


Rebuild for eary version containers

@morimoto-cybozu
I updated TAG for all MySQL version
I am sorry to trouble for you.


feat: integrate offer button

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[x] Redesign

Context

[x] Closes #4542

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </bsx/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[ ] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

I need your help @roiLeo @Jarsen136. Does the offer button work on your side on this PR? I just followed the submit() function on AvailableActions. If not, What do I miss anyway?

wfm, block hash 0xa537886e39455a2d6e0cde1f96177433b5d4c65d996422f9abf0dc1431c6c9ad
it's been a few weeks that Snek [Rococo] endpoint is "stuck" but you can see that the call has been made on chain

I need your help @roiLeo @Jarsen136. Does the offer button work on your side on this PR? I just followed the submit() function on AvailableActions. If not, What do I miss anyway?

WFM too

Snek [Rococo] endpoint is "stuck"

After Brick I sense @vikiival updated only snek@05 for BSX, not for Rococo?

Looks like something is wrong with offers. I pinged BSX team

I've made offer on this one https://deploy-preview-4554--koda-nuxt.netlify.app/bsx/gallery/2608295324-7
But it seems on old one doesn't show up.

https://basilisk.subscan.io/extrinsic/2460385-2

Oh, seems it's on Basilisk team side something ...

Offers should be already available

Offers should be already available

Tx is good but it's not visible for me on snek Rococo

Tx is good but it's not visible for me on snek Rococo

Because the one that @yangwao made was on BSX

✅ Block hash: 0xe77afe69d0712c73bfc45df5a9ac5300ba46d22bb05bf548bfd281ab24e76546 on Rococo
Still blocked by kodadot/snek#130

Merged
https://github.com/kodadot/snek/pull/136

Merged
kodadot/snek#136

https://squiki.kodadot.workers.dev/status/snekk
new endpoint again??? (https://squid.subsquid.io/snekk/graphql)

new endpoint again???

Following good practises
https://docs.subsquid.io/deploy-squid/promote-to-production/

Yeah!! offers are back


Redesign "Currently playing" to something more lightweight

Also try to add "running text" (left to right (and maybe back?)) when the displayed string cannot fit fully

To be honest with myself, this should contain a UI overhaul on more parts


highlight and match no longer working for non-multiple tagging

I haven't been able to pinpoint the exact reason yet but after updating from 0.10 to 0.11.2 the highlight and match functions are both broken for me on my existing code.
From what I can see, the searchInput.on('keyup') event handler is now only in the multiple directive.  Might explain it, as most of the tagging handling is done there.

I'm also having this problem in my code, but for some reason it works in this plunkr: http://plnkr.co/edit/VGCKrSBaAL8KlSXihQgV?p=preview ... trying to figure out why has been pretty fruitless so far.

Closing due to not enough actionable information - feel free to open a new issue with reproduction in Plunker based off of the latest release if it is still an issue.


Wrong install instructions

Documentation uses wrong instructions:
npm install @kaung/svelte-otp
should be:
npm install @k4ung/svelte-otp
(same holds for yarn part)

Thanks for pointing out. It should be fixed now.


hit the target game

PR Description 📜
Completed the game
Fixes #2484

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @whiteknight16 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@gurjeetsinghvirdee kindly merge this, thankyou

Done @gurjeetsinghvirdee

Thank you  @whiteknight16 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


casting parametric parameters into int in addition to floats

Informations

Qiskit version: 0.20.0
Python version: 3.8.5
Operating system: OSX

What is the current behavior?
When trying to bind an integer for a circuit.Parameter() into a qiskit.pulse.library.Waveform(), the parameter needs to be casted into a float, then into an integer before it can be bound.
references:
https://qiskit.org/documentation/tutorials/pulse/6_pulse_scheduler.html
Steps to reproduce the problem
def gs_pulse(duration):
duration = int(float(duration)) # hacky solution needed ATM... TODO?
return qiskit.pulse.library.GaussianSquare(duration,0.5,64,64)
def random_2q_gate(x):
sched = qiskit.pulse.Schedule()
sched = sched.insert(0,Play(gs_pulse(x), DriveChannel(1)))
return sched
my_random_2q_gate = ParameterizedSchedule(random_2q_gate, parameters=['x'])
What is the expected behavior?
binding a parameter should maintain the datatype through to the parameterExpression
Suggested solutions
Talk to @lcapelluto , @taalexander , or #4940

@lcapelluto Is the problem here that if you bind a ParameterExpression to an int value, it currently can only be cast to a float? It seems like it'd be fairly simple to add an additional casting operator to ParameterExpression to support ints.

Actually, I may roll it into #4940

@ehchen Take a look at #4940


Cannot use output from a previous step in key

I'm successfully fetching the digest of the latest image (before downloading the actual image) with docker manifest inspect ghcr.io/zephyrproject-rtos/ci:latest -v | jq -r '.[0].Descriptor.digest' and I'm (naively?) trying to use it in the key.
I first tried set-output as documented here: https://github.com/marketplace/actions/cache#creating-a-cache-key
      - name: get digest of latest ghcr.io/zephyrproject-rtos/ci
        id: latest-zephyr-img
        run: |
          docker manifest inspect ghcr.io/zephyrproject-rtos/ci:latest -v | jq -r '.[0].Descriptor.digest' | tee latest-img
          echo "::set-output name=date::$(cat latest-img)"

      - name: Cache Docker images
        uses<EMAIL_ADDRESS>        with: # can't get digest :-(
          key: zephyr-build-img-${{ steps.latest-zephyr-img.digest }}

But the value looks empty.
Then Github informed me that set-output is deprecated. So I followed the new documentation and switched to GITHUB_OUTPUT: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

      - name: get digest of latest ghcr.io/zephyrproject-rtos/ci
        id: latest-zephyr-img
        run: |
          docker manifest inspect ghcr.io/zephyrproject-rtos/ci:latest -v | jq -r '.[0].Descriptor.digest' | tee latest-img
          printf 'digest=%s\n' "$(cat latest-img)" >> "${GITHUB_OUTPUT}"

Still empty: https://github.com/thesofproject/sof/actions/runs/3851840976/jobs/6563431229
Is this problem specific to docker-cache?

No, Actions don't have the power to control their own inputs so far as I am aware, which can be shown by attempting to use the variable from a trivial run step. My wild guess is that the colon in the value of the variable is creating issues, so maybe you need an extra set of quotes?

Thanks, I'll try "harder" tomorrow.

In case this helps anyone else facing a similar issue, the problem was that steps.latest-zephyr-img.digest is not defined. You meant steps.latest-zephyr-img.outputs.digest.


IContainerRuntime*.get*DataStoreRuntime: Supply optional AbortSignal for cases where we wait

Thinking about using AbortSignal for loader( #1191), and possibly adding to request.
Changing wait to AbortSignal would allow us to delegate the wait policy (timeout, etc). I'm thinking undefined AbortSignal would be equivalent to no wait.

I do not think it's replacement, it's addition. I.e. if we have to wait (or allow waiting), then we have to allow cancelation.
So changing title to reflect that.


Improvement: SqlContractDefinitionStore implement filtering and sorting

Feature Request
The SqlContractDefinitionStore in its current implementation allows for querying with a QuerySpec but only takes the offset and limit properties.
Now, also the filterExpression, sortField and sortOrder should be added to the query.
Which Areas Would Be Affected?

DataManagementAPI

Why Is the Feature Desired?
to establish feature parity with all other data backends and implementations
Solution Proposal
If possible wait for Issue #916 and have the query hit the cache using Predicates, similar to the InMemoryContractDefinitionStore
If that's not desirable/feasible:
implement the filtering directly in SQL: adopt the Clause interface that was originally developed for CosmosDB's SQL API, but can be re-used and ported to SQL.
Type of Issue
Improvement
Checklist

[x] assigned appropriate label?
[x] Do NOT select a milestone or an assignee!

This should be done for every postgresql store implementation

FYI: https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/discussions/1424

Closing as it's a duplicate of #1432


Multiple cores

When using Node.js, it's common to use the cluster module to fork a process per CPU core. I don't think anyone disagrees with the performance benefits of doing that.
But since SuperchargedReact.Net only uses one V8 instance, it's comparable to using Node.js without the cluster module (unless I'm missing something?).
Are there any plans/discussions regarding this?

Hi @andersekdahl,
Sorry for the late replies I've been away in Paris at the ReactEurope conference.
Great point, not one I'd considered but now you've raised it I'll have to give it some thought. By default IIS should use all available cores I believe but I'm no parallel programming master.
Our first target with this code base was getting it running and running well. I think we've done that. Next I want to make it easier to get up and running with it (we are missing lots of docs) so we cna have more people using it and so more eyes on it. Then I hope to revisit the performance and see what we can do to make it even faster.
Right now its "good enough" from the testing we've been doing but of course I'm open to getting more out of it if we can. More CPU's might be one of the ways we can do that.
Regarding the single instance of V8, we keep that instance as a static variable and every request asks this instance for a need JS engine to run it. This is the fastest way to spin up a new engine context from an existing instance of V8 according to ClearScripts own forum although I can't put my hand to the link for that right now but I will.
Cheers
Pete

Lots of my comments on performance here include the links I mention:
https://github.com/reactjs/React.NET/issues/78

Hi!
Thanks for the answers!
Sure, IIS will use all cores but since you have a single, static V8 instance all cores will be talking to the same engine (and waiting for the same engine). And a single V8 instance is single threaded even if you have multiple V8 contexts. I think it would make sense to use multiple instances (although I might be wrong, I know a lot about Node and V8 and less about how ClearScript wraps it).

Trouble is I'm not sure how to even go about doing this or even testing it? Any ideas?

You could test that it's true by creating a React component with a loop that takes at least a couple of seconds to complete.
If you open that page at the same time in different browsers/tabs and one of them completes long after the other, you knowbthat you have a bottleneck.


Work around https://issues.jboss.org/browse/ISPN-1521

Please don't handle this pull yet, this needs further discussion.


FOODON uses a PATO class as an object property

http://www.ontobee.org/ontology/FOODON?iri=http://purl.obolibrary.org/obo/PATO_0005016
this is punning on the class, technically valid OWL but this is not what you want

Not sure how that happened.  That's supposed to be RO "surrounded by" - "http://purl.obolibrary.org/obo/RO_0002219" .  Will fix now.

Thanks for spotting.  Fixed.


MemorySessionStore#m_persistentSubscriptions: Map Layout changed

If one clientid subscribes a lot of topics the old implementation
struggles with the for loops

Hi @AndreasMager
the contribution is almost ok, but don't like so much the usage of implementation classes (HashMap for example) when I can use the abstract interface (Map)
For example
HashMap<String, Subscription> clientSubscriptions = m_persistentSubscriptions.get(clientID);

should be rephrased as
hMap<String, Subscription> clientSubscriptions = m_persistentSubscriptions.get(clientID);


Revert "Fixing Strings"

Reverts opensearch-project/job-scheduler#321

@gaiksaya Seems that this revert needs to be reverted again. They have kept this change in for OpenSearch 2.x