Fix arrow up on message deletion

Details

Pass true for shouldSetModalVisibility so that it can trigger composer focus after message deletion pop up.
Fixed Issues

$ https://github.com/Expensify/App/issues/30135
PROPOSAL: https://github.com/Expensify/App/issues/30135#issuecomment-1773957511
Tests

Open a chat room
Add a message (first message)
Add another message (second message)
Press arrow up, verify that the second message is in edit mode
While in edit mode, clear the content and press enter, verify that a Delete comment popup appears
Click Delete, verify that the second message is deleted and composer is focused
Press arrow up, verify that the first message is in edit mode.

[x] Verify that no errors appear in the JS console

Offline tests

Open a chat room
Add a message (first message)
Add another message (second message)
Press arrow up, verify that the second message is in edit mode
While in edit mode, clear the content and press enter, verify that a Delete comment popup appears
Click Delete, verify that the second message is strike-through and composer is focused
Press arrow up, verify that the first message is in edit mode.

QA Steps

Open a chat room
Add a message (first message)
Add another message (second message)
Press arrow up, verify that the second message is in edit mode
While in edit mode, clear the content and press enter, verify that a Delete comment popup appears
Click Delete, verify that the second message is deleted and composer is focused
Press arrow up, verify that the first message is in edit mode.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/371291/f93d2b8e-e85d-42bc-907c-997a7e018819

Android: mWeb Chrome

https://github.com/Expensify/App/assets/371291/76bf72b2-d5a7-4a6f-a0db-fe45439cfb62

iOS: Native

https://github.com/Expensify/App/assets/371291/0d7ef18c-cc8e-48fa-b233-c6bde099ca2e

iOS: mWeb Safari

https://github.com/Expensify/App/assets/371291/65948046-7ec4-4e67-847a-e100ac80480a

MacOS: Chrome

https://github.com/Expensify/App/assets/371291/536e0f4e-b005-4f6d-b639-25d497dfcdba

MacOS: Desktop

https://github.com/Expensify/App/assets/371291/ed094e69-96ff-4d57-83c2-f095ed06830d

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/108292595/363e8008-3a76-42be-aef2-1c3e090cdd43

Android: mWeb Chrome
https://github.com/Expensify/App/assets/108292595/b83c121f-8e7d-4cd6-81cf-594e165c18d4

iOS: Native
https://github.com/Expensify/App/assets/108292595/30fef26b-e8ef-445a-b094-a05d8fa10e00

iOS: mWeb Safari
https://github.com/Expensify/App/assets/108292595/1b66bd8d-3c2d-4189-99df-b4a4ae45d0a7

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/108292595/dba8e203-1f81-42c1-b0f0-0306fca53ace

MacOS: Desktop
https://github.com/Expensify/App/assets/108292595/0b96618d-235b-4ef4-8006-d8a2309e609d

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.96-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


fix: remove duties when deleting remote key via keymanager

Motivation
Duties should be removed if key was deleted from in-memory store.
This prevents errors such as in case doppelganger protection is enabled
error: Error signing attestation slot=7063462, index=25, head=0x45243768b4c135c1cc6d426b06ce9aaf5f93e606f828d4f1a90a30ffeb462fc3, validatorIndex=453228 - Doppelganger state for key 0xa5920d02398e0e9ade09a9e10b741dd47ffcccd1d468147978560dab20181562d84dc120126fe38aafd4a19456c6e51b is not safe
Error: Doppelganger state for key 0xa5920d02398e0e9ade09a9e10b741dd47ffcccd1d468147978560dab20181562d84dc120126fe38aafd4a19456c6e51b is not safe
    at ValidatorStore.assertDoppelgangerSafe (file:///usr/app/packages/validator/src/services/validatorStore.ts:737:13)
    at ValidatorStore.signAttestation (file:///usr/app/packages/validator/src/services/validatorStore.ts:446:10)
    at file:///usr/app/packages/validator/src/services/attestation.ts:195:61
    at Array.map (<anonymous>)
    at AttestationService.signAndPublishAttestations (file:///usr/app/packages/validator/src/services/attestation.ts:189:14)
    at AttestationService.runAttestationTasksGrouped (file:///usr/app/packages/validator/src/services/attestation.ts:141:16)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at AttestationService.runAttestationTasks (file:///usr/app/packages/validator/src/services/attestation.ts:103:9)
    at Clock.runAtMostEvery (file:///usr/app/packages/validator/src/util/clock.ts:96:7)

or if doppelganger protection is not enabled, it would throw an error during getSignature call
error: Error signing aggregateAndProofs slot=7063462, index=25, validatorIndex=453228 - Validator pubkey 0xa5920d02398e0e9ade09a9e10b741dd47ffcccd1d468147978560dab20181562d84dc120126fe38aafd4a19456c6e51b not known
Error: Validator pubkey 0xa5920d02398e0e9ade09a9e10b741dd47ffcccd1d468147978560dab20181562d84dc120126fe38aafd4a19456c6e51b not known
    at ValidatorStore.getSignature (file:///usr/app/packages/validator/src/services/validatorStore.ts:679:13)
    at ValidatorStore.signAggregateAndProof (file:///usr/app/packages/validator/src/services/validatorStore.ts:500:29)
    at file:///usr/app/packages/validator/src/services/attestation.ts:275:41
    at Array.map (<anonymous>)
    at AttestationService.produceAndPublishAggregates (file:///usr/app/packages/validator/src/services/attestation.ts:269:14)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Promise.all (index 0)
    at AttestationService.runAttestationTasksGrouped (file:///usr/app/packages/validator/src/services/attestation.ts:152:5)
    at AttestationService.runAttestationTasks (file:///usr/app/packages/validator/src/services/attestation.ts:103:9)
    at Clock.runAtMostEvery (file:///usr/app/packages/validator/src/util/clock.ts:96:7)
Nov-29 14:52:36.000[]                debug: HttpClient request routeId=getProposerDuties

Description
Remove duties when deleting remote key via keymanager

:tada: This PR is included in v1.13.0 :tada:


Missing data types in Client APIs

Based on user report
For C API, we are missing

RECURSIVE_REL
SERIAL
ARROW_COLUMN
BLOB
MAP
UNION

The above types may also be missing in other APIs.
Note that for MAP and UNION, we haven't fully implemented, so no functions should be exposed for these two types. Just include them in type switch.

Rust API as far as I'm aware is missing:

[ ] RECURSIVE_REL (mostly done, I'll open a PR soon)
[ ] ARROW_COLUMN
[ ] MAP
[ ] UNION

RECURSIVE_REL also seems to be missing from the C++ API and/or docs. You can access it like a struct, and it's fairly straightforward to do so, but there's no documentation of its structure. Having a wrapper like NodeVal and RelVal do would be helpful and would provide a natural place to document it.

RECURSIVE_REL also seems to be missing from the C++ API and/or docs. You can access it like a struct, and it's fairly straightforward to do so, but there's no documentation of its structure. Having a wrapper like NodeVal and RelVal do would be helpful and would provide a natural place to document it.

Good point. Do you want to do it? Maybe wrap as PathVal.

In C and Java API we provide utility functions:
https://github.com/kuzudb/kuzu/blob/master/tools/java_api/src/main/java/com/kuzudb/KuzuValueRecursiveRelUtil.java#L6
https://github.com/kuzudb/kuzu/blob/master/src/c_api/value.cpp#L166
I think maybe we can just create another static class similar to NodeVal and RelVal for C++. No need for another wrapper.

Done in #1814


Simplify ext_arguments_map ctor

part of #548

I think we still need these. What do you think?

Could you think of any example that these types are required?

I think we still need these. What do you think?

Could you think of any example that these types are required?

These are not required per se. I am just thinking about C/C++ users who might write, say, Array<double> or Column<int32_t>.
Also, these types are included in test_type_to_extarg.py as primitives.
Another approach is to have a unique list of types that rbc supports and reject all their equivalent variations with an informative exception message such as "Array<double> is not supported, use Array<float64> instead".


Revert "Added 'typed' option to jshint"

reason: We want to warn about typed array usage since not all browsers we support have typed arrays implemented.

Thanks!


Why webpack ?

Hello
I want to know why you decided to use webpack ?
Is it just for the Chrome Extension or does it have a role in the main page as well ?

it's in the main demo as well -- somehow i had to get a node module to work on a browser (and get imported), and this was the easiest way


fixed 401: duplicate events in state hook

Description
This PR prevents adding duplicate events to the state if a recurring event spans more than 1 month.
Type of change
Please select everything applicable. Please, do not delete any lines.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This change requires an update to testing

Issue

[x] Is this related to a specific issue? If so, please specify: #401

Checklist:

[x] This PR is up to date with the main branch, and merge conflicts have been resolved
[x] I have executed npm run test and all tests have passed successfully or I have included details within my PR on the failure.
[x] I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

LGTM, should we add testing to accompany this?

Howdy @romanstetsyk did you get a chance to review my question?

@Caleb-Cohen I'm sorry, I didn't see your last message. It's a good idea, but I still need to figure out how to write tests in Cypress. It would be great if someone could add tests to this pr or create a separate issue

@Caleb-Cohen I'm sorry, I didn't see your last message. It's a good idea, but I still need to figure out how to write tests in Cypress. It would be great if someone could add tests to this pr or create a separate issue

I'll take it up!


Set a consistent API/UI endpoint

What does this PR do?
Instead of it being the first master hostname in the single-master
scenario or the first load balancer mostname in multi-master, the
sample cluster will always have the following entrypoint by default:
https://console.{{env_id}}.{{public_dns_domain}}:8443
That will simplify the documentation and be easier to look up and
understand for the newcomers trying it out.
How should this be manually tested?
The end-to-end CI will exercise this feature, no manual testing is necessary.
Is there a relevant Issue open for this?
n/a
Who would you like to review this?
cc: @Tlacenka @tzumainn  @bogdando PTAL

Oh ffs, the job succeeded but travis killed it nonetheless. /me shakes fist at travis

@bogdando it's set based on openshift_master_cluster_public_hostname by one of these tasks:
https://github.com/openshift/openshift-ansible-contrib/blob/master/roles/dns-records/tasks/main.yml#L67-L88


docs: fix client initialization in README example

I apologize for another PR on the same issue as the last one, but I really only noticed now that the client was being initialized every time on the client even if only the cached client was being returned. So now, it first checks whether it is in the browser and the browserClient is defined before creating a new client.

Okay, last correction, I swear. isBrowser should be typeof window !== 'undefined', not typeof window === 'undefined'. I don't know what was going on.

Fixed, thanks. I don't know how I missed it either :-)


8.5.1 - Upgrade script has to be run in order to upgrade completely

After replacing /concrete (8.5.0) with the one of version 8.5.1, concrete5 doesn't upgrade automatically.
Environment Information:
concrete5 Version
Core Version - 8.5.1
Version Installed - 8.5.0
Only after running the upgrade script (as it had to be done in older 5.7.x versions) the upgrade is successfully completed.
https://my-site.com/index.php/ccm/system/upgrade
Environment Information
concrete5 Version
Core Version - 8.5.1
Version Installed - 8.5.1

Can confirm, just observed the same behaviour with a site.

Confirmed. Because version_db value is not changed since 8.5.0.

Confirmed, and in some cases it's altering the name of the proxies and we're forced to manually replace them

Still true when upgrading from 8.5.1 to 8.5.2RC1. The upgrade procedure takes quite a long time and in the end the environment info says:
Core Version - 8.5.2RC1
Version Installed - 8.5.1
Only after running the upgrade script https://my-site.com/index.php/ccm/system/upgrade the environment info shows
Core Version - 8.5.2RC1
Version Installed - 8.5.2RC1


Fix issue #116 - Added css styling to align nav items properly

Added styles to .navbar-brand and .navbar-nav styles to make their alignment consistent

@Joshlansah1 Works perfectly! Awesome, Thank you for contributing. Merging!🚀


Restoring website

Email :-<EMAIL_ADDRESS>Issue #72
https://github.com/07sumit1002/CabRental/assets/140265777/9f177528-7cee-448e-994c-c15554e73aaa

Can you see the deployed website

this has still not worked


Only select the review of latest stage made by each reviewer.

Fix the issue in this comment https://github.com/pycontw/pycontw2016/pull/170#issuecomment-204727653 所以只會顯示每個人最新的 review。
ps 如果是直接覆寫 database 裡的記錄就沒這問題了……對不起我蠢@@

Current coverage is 78.59%

Merging #177 into review-stage-2-show-comments will decrease coverage by -0.19% as of 7d36d16

@@            review-stage-2-show-comments    #177   diff @@
============================================================
  Files                                 40      40
  Stmts                               1263    1266     +3
  Branches                               0       0
  Methods                                0       0
============================================================
  Hit                                  995     995
  Partial                                0       0
- Missed                               268     271     +3

Review entire Coverage Diff as of 7d36d16

Powered by Codecov. Updated on successful CI builds.


Solving #109 with redundant inclusion guards

Using redundant include guards to minimize the compilation time
C Preprocessor inclusions could explode the compilation time (even with pragma once!)
The basic idea comes from an old, dusty C++ book called Large Scale C++ Software Design, page 83-88.
Expanding the evaluate method indicated in the issue #109, everytime the ? in 0?1?2?3?4?5?6?7?8?9? is parsed, a new template instantiation begins, reading all the files again in the #includes, and increasing exponentially the compilation time.
I didn't use any redundant include guards in the standard header files. They could be used into them, too, in order to reduce even more the compilation times.
Test case:
0?1?2?3?4?5?6?7?8?9?
Even worst compile time test case:
a?b?c?d?e?f?g?h?i?j?l?m?n?o?p?q?r?s?t?u?v?w?x?y?z?

Do you have some measurements? This seems really sketchy.

Ok, I read the book on pages you sent, the chapter is talking about preprocessor, not about templates.


Add more docstring for #21

This pull request adds more docstring to public methods/data classes.
Category (place an x in each of the [ ])

[ ] slack_bolt.App and/or its core components
[ ] slack_bolt.async_app.AsyncApp and/or its core components
[ ] Adapters in slack_bolt.adapter
[ ] Document pages under /docs
[x] Others

Requirements (place an x in each [ ])
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've run ./scripts/install_all_and_run_tests.sh after making the changes.

Codecov Report

Merging #96 into main will decrease coverage by 0.06%.
The diff coverage is 85.54%.

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   89.65%   89.58%   -0.07%
==========================================
  Files         128      129       +1
  Lines        3585     3621      +36
==========================================
+ Hits         3214     3244      +30
- Misses        371      377       +6

Impacted Files
Coverage Δ

slack_bolt/auth/result.py
100.00% <ø> (ø)

slack_bolt/lazy_listener/async_runner.py
76.92% <ø> (ø)

slack_bolt/lazy_listener/runner.py
91.66% <ø> (ø)

slack_bolt/listener/async_listener.py
98.41% <ø> (ø)

...lack_bolt/listener/async_listener_error_handler.py
90.62% <ø> (ø)

slack_bolt/listener/listener_error_handler.py
90.62% <ø> (ø)

...ck_bolt/listener_matcher/async_listener_matcher.py
96.55% <ø> (ø)

slack_bolt/listener_matcher/listener_matcher.py
85.71% <ø> (ø)

...e/authorization/async_multi_teams_authorization.py
58.53% <ø> (ø)

...e/authorization/async_single_team_authorization.py
90.62% <ø> (ø)

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b4d21...ed41e65. Read the comment docs.


Make it harder to accidentally leave a video call

Right now you leave the call as soon as you move to another location. You can mitigate this by having multiple tabs, but I still got confused several times. It would be nice to have a warning to confirm whether you want to leave the call.

Closing as the new UI has been developed after this issue was opened and this issue relates only to the old UI.
(In the new UI, such warnings have been implemented.)


[chore] Improve events for Server

Notes for Reviewers
This PR fixes #

Persists k8s context instead of skipping whenever possible, earlier we were persisting the context if all checks passed, the behaviour is changed to persist the context if we are able to get server ID, server ID is mandated because it is one of the attribute used to determine unique contexts, otherwise user will quickly have stale connections.
Send the K8s deployment error field path separately as a short description instead of shoving the entire short description into one.
Disables Connections page from the navigator menu.

Signed commits

[ ] Yes, I signed my commits.

@MUzairS15 there are some failed check that need investigating...

Remove unused package. Enhanced error descriptions.

@MUzairS15 this unit test will need updated - https://github.com/meshery/meshery/actions/runs/6266860852/job/17018711297?pr=8864#step:5:259. @Philip-21 I wonder if you might be able to help move this forward.

Member

@leecalcote unit tests fix have been implmented here

@MUzairS15 why is the connection page disabled from navigation menu

It turns out that it’s just not ready for prime time (it has too many issues and too many things that don’t make sense), and that we are best off not showing it to users in its current state. // @senali-d @yash37158 @aabidsofi19 @theBeginner86

Fixed typo.


Create bhak.at

website: https://www.bhak-ff.at/
Its a bit strange that the website isn't the same as the mail doman, but If you open the website and scroll down. you can see<EMAIL_ADDRESS>" in the footer
similar schools in austria: #5939 #5671 4183

@ruru4143 lib/domains/at/bhak.at: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@ruru4143 lib/domains/at/bhak.at: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@ruru4143 I corrected the filename. Pull request merged. Thank you!


Fix Darkmode Toggle

Darkmode Toggle is not working correctly.
Few bugs:

Double-click to activate for the first-time visitor
Sometimes, it stops working and one has to reload the page to make it work again

For example, on navigation from home to /contributors

Fixed in #7


Dockerfile base image

Upgrade<EMAIL_ADDRESS>to version 3.7.17-bullseye

Added by OX Security


Translate metrics

In this PR was added localization for metrics pages.

@damiencarol I think we have some problem with execution Integration tests / test (tests/finding_test.py, postgres-redis) (pull_request)
On my laptop this test is passed


Infra - intermittent failure during vcpkg bootstrap on MacOS with operation timeout

Job: CMakeGenerate Mac
Step: cmake generate for azure-core-amqp
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3697516&view=logs&j=5b93c52f-e230-56a0-4101-bbe6cb6c4dfb&t=ae87a839-4582-575c-61ff-d44f25932f8d
2024-04-15T18:16:29.7569280Z Vcpkg integrate step - DONE.
2024-04-15T18:16:29.7643960Z -- Bootstrapping vcpkg before install
2024-04-15T18:16:48.0484480Z -- Bootstrapping vcpkg before install - failed
2024-04-15T18:16:48.0490220Z CMake Error at build/_deps/vcpkg-src/scripts/buildsystems/vcpkg.cmake:899 (message):
2024-04-15T18:16:48.0581220Z   vcpkg install failed.  See logs for more information:
2024-04-15T18:16:48.0598710Z   /Users/runner/work/1/s/sdk/core/azure-core-amqp/build/vcpkg-bootstrap.log
2024-04-15T18:16:48.0600670Z Call Stack (most recent call first):
2024-04-15T18:16:48.0608270Z   /usr/local/Cellar/cmake/3.28.1/share/cmake/Modules/CMakeDetermineSystem.cmake:170 (include)
2024-04-15T18:16:48.0610790Z   CMakeLists.txt:10 (project)
2024-04-15T18:16:48.0612920Z
2024-04-15T18:16:48.0621440Z
2024-04-15T18:16:48.0623880Z CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
2024-04-15T18:16:48.0626010Z CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
2024-04-15T18:16:48.0628580Z -- Configuring incomplete, errors occurred!
2024-04-15T18:16:48.0634240Z
2024-04-15T18:16:48.0651330Z ##[error]Bash exited with code '1'.
2024-04-15T18:16:48.0672750Z ##[section]Finishing: cmake generate for azure-core-amqp

The vcpkg-bootstrap.log says the following:
Log file: /Users/runner/work/1/s/sdk/core/azure-core-amqp/build/vcpkg-bootstrap.log
==============================================================================================================================
Downloading vcpkg-macos...
curl: (35) Recv failure: Operation timed out

@BillyONeal  what should we try to do here to improve our build reliability? Can vcpkg do something here in terms of retries?

This look like the error is happening in something outside of our build system (in scripts/buildsystems/vcpkg.cmake). Failed network connections should generally be retried after a delay.


Structure Check: Linter expects complete If/Endif to be in one member

Environment:
node version:     v16.14.0
abaplint version: 2.85.30
Issue did not exist with previous version (Linter runs every day with latests docker version).
Issue:
/tmp/abaplint-ilALfL/src/fvvi/ifre_begin_of_pr_addon.prog.abap[1, 1] - Expected ENDIF (structure) [E]
/tmp/abaplint-ilALfL/src/fvvi/ifre_end_of_pr_addon.prog.abap[1, 1]   - Unexpected ENDIF (structure) [E]
Dependency REPO code (Original SAP which can not be changed):

are there any other issues in the list of issues?
suggest trying to reproduce in a public repository, one main program and two includes should reproduce it?

These are the only issues in the list.
This issue is not a new one. It was fixed before.
It is caused by not including all includes to the source of an executable object before checking.
Will try to create a public test-set.

Issue is fixed with the current version.


docs: Updated the README.md

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[x] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description
Updated the project's readme with installation instructions and utility icons.
Related Tickets & Documents
Closes #6
Mobile & Desktop Screenshots/Recordings
Not needed.
Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[x] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[ ] 🙅 no documentation needed

Btw, I used yarn to install dependencies because I prefer using it, but I can use npm too @0-vortex what do you think?

Btw, I used yarn to install dependencies because I prefer using it, but I can use npm too @0-vortex what do you think?

npm would be better, with this .npmrc configuration set up for the project: https://github.com/open-sauced/hot/blob/beta/.npmrc
Once yarn.lock is removed, running npm shrinkwrap will consolidate it for CI purposes. Then using npm ci to get the predictable lockfiles in the clients makes first automated production release possible 🍕

Btw, I used yarn to install dependencies because I prefer using it, but I can use npm too @0-vortex what do you think?

NPM was the package manager recommended in other OpenSauced projects. I went on with the same to stay consistent. PNPM is great too.


Valid address getting invalid error message

I'm trying to send some BTC between my one Umbrel to another but when entering the address, I get the error message Please validate the Bitcoin address is correct.
I click "Withdraw", input the amount (any amount) and the address. Seconds later, the fees slider disappears and I get the error message...
The receive address is valid (other wallets can send to it). It begins with bc1 so is SegWit mainnet.
Both Umbrels are fully synced and have been for at least 24 hours.
Umbrel version 0.4.0
Pi4 on a SSD.
Any ideas what I could try?

Closing due to inactivity, but if this issue still remains, please post about it on our community forum (https://community.getumbrel.com)


DOCS-7260 Kafka 4.0 User Guide

All of the Kafka 4.0 docs are consolidated now in PR https://github.com/mulesoft/docs-connectors/pull/652


GGV cursor does not stick to object during manipulation

Ported to Github, reference 20823387
Use HoloLens 1 gestures to move an object in HandInteractionExamples scene. You can use either in-editor simulation or go to an actual HoloLens device. For in-editor simulation set Hand Simulation Mode in InputSimulationProfile to Gestures:

Expected:
when you grab and move an object, the cursor sticks to the object like in the HoloLens 1 shell
Actual:
The cursor does not stick to the object being manipulated.

I think this represented the opposite of the request in https://github.com/microsoft/MixedRealityToolkit-Unity/issues/6350. We should make this a toggle-able feature.


Method not found in class

I've run the following three commands:
php artisan clear-compiled
php artisan ide-helper:generate
php artisan optimize

and I'm still showing a number of functions with errors.
Many of them say Method not found in class. I also have some that say method signature uses 0 parameters. These functions tend to use func_get_args().
Some examples are
Header::with("campaign")->groupBy("campaign_id") //Method not found on groupBy
JavaScript::put([]); //Method signature uses 0 params
Product::where() ;//method not found
Product::find(); //method not found
$model_var->save(); //method not found, seems to only be an error when ::find is used to get the model
I've tried adjusting my use statements to use the Facade instead of the full namespace and that helped with a few of the errors. The remaining errrors seem to be from Models that don't like the Eloquent functions.
I could turn off the error notification for these but it still won't let me do the autocompletion for the method not found errors.
I had the Laravel plugin installed but I tried removing that and it had no effect. I also tried setting up my directories and making /app and /vendor source folders and /public a resource root but that had no effect either.
Am I missing something here?

Same for me.
Fresh laravel install.

Can you try with the latest version, it should add a @mixin tag, which should add most methods.

I updated to 2.1.4, deleted the _ide_helper.php file and regenerated it. I invalidated the cache and restarted PhpStorm too.
I just now found this line in the docs: "The generator tries to identify the real class, but if it cannot be found, you can define it in the config file." Is this something I have to do to fix this?

I discovered from past issues that most of these will be fixed by changing extends Model to extends \Eloquent. I tried to fix the others by using this:
'magic' => array(
	    'Eloquent' => array(
		    'groupBy'   => 'Illuminate\Database\Query\Builder::groupBy'
	    )
),

in the config file. However PhpStorm now marks it as @internal.
The other remaining issue is with functions that use func_get_args(). Is there a way to indicate for the generator what functions these are?

If you add ...$arg as a paramentr in _ide_helper.php(after regeneratin it), this problem will disappear
public static function groupBy(...$arg){
        return \Illuminate\Database\Query\Builder::groupBy();
}

@barryvdh this works for me (->groupBy() auto-complete after ::with()) out of the box, I think this can be closed :}


SQL: Fix exception with OR of impossible filters.

Fixes #7671.

Merging given that TC is broken.


DirectionalLight3D is not working correctly when light is pointing away

Godot version
4.0beta3
System information
PopOS 22.04, 5.19.0-76051900-generic kernel, Ryzen 6800h, Radeon 6700m, amdgpu, Vulkan
Issue description
Utilizing DirectionalLight3D and Environment, I'm seeing weird light behavior when the scene should be completely dark. I have a day night cycle and it's producing unexpected results and I'm not sure why:

Here is a video to demonstrate:
https://user-images.githubusercontent.com/15805689/199366194-12561a51-34ac-44a3-844e-378e3acde89a.mp4
Steps to reproduce
This is an old project, but it can be reproduced here:
https://github.com/Mikeysax/example-project-for-godot-bug-68143
Here are screenshots of the environment if that helps:

Minimal reproduction project
https://github.com/Mikeysax/example-project-for-godot-bug-68143

This looks like it could be a shadow pancaking issue, but I can't confirm as I can't reproduce locally.

Most likely, your meshes are corrupted and this is a duplicate of either upgrading from godot 3 https://github.com/godotengine/godot/issues/63550 or upgrading from an earlier version of godot 4 https://github.com/godotengine/godot/issues/64854.
You can fix it by reimporting all of your meshes in the latest version, or deleting project/.godot/imported if all of your scenes are still linked to the import files.

@clayjohn @tinmanjuggernaut , I've uploaded a new project which should be able to replicate:
https://github.com/Mikeysax/example-project-for-godot-bug-68143

It seems as though setting max distance on Directional Shadow to a higher value kinda fixes the issue:

Is this a bug though or intentional?

I see, if they are native meshes, then what I wrote does not apply.
I opened up your project. You should learn about .gitignore and exclude .godot and .import.
Yeah Godot leaks light all over the place. It's not a ray tracer, (though the light baker is). Casting a shadow from a 100x100m object onto 4x1m objects right next to it with a 100 shadow distance is a challenge. Try adjusting the scale of your shadow casters and bring them into the same order of magnitude. Increasing shadow distance to 1000 is costly, though 100 is too short. 256-400 is good for modern and previous generation cards.
You can create mesh boxes and under Geometry mark them as cast shadow cast only. Then you can use them as flags to block light the way a gaffer would shape light on a film set. https://www.youtube.com/watch?v=ShFk1Ao9sBw

I see, if they are native meshes, then what I wrote does not apply. I opened up your project. You should learn about .gitignore and exclude .godot and .import.
Yeah Godot leaks light all over the place. It's not a ray tracer, (though the light baker is). Casting a shadow from a 100x100m object onto 4x1m objects right next to it with a 100 shadow distance is a challenge. Try adjusting the scale of your shadow casters and bring them into the same order of magnitude. Increasing shadow distance to 1000 is costly, though 100 is too short. 256-400 is good for modern and previous generation cards.
You can create mesh boxes and under Geometry mark them as cast shadow cast only. Then you can use them as flags to block light the way a gaffer would shape light on a film set. https://www.youtube.com/watch?v=ShFk1Ao9sBw

I see; thank you for the tips and help!
I was aware of .gitignore although I was not used to what should be excluded from a godot project for source control.


Fix demo building for windows filesystems

Alaska Airlines Pull Request
This PR should resolve some issues that I was having running the demo project on a windows filesystem. There are also some minor improvements made to how we reference files.
I tested this on both windows and macos, and it works great on both ends now! 🎉
Fixes: #153
Summary:
This change updates a lot of our path references to use path.join so that our path references are not os specific.
Also found a bug with the copyfiles dependency requiring us to use double quotes on glob references for windows filesystems. See this link for more info.
Type of change:

[ ] New capability
[ ] Revision of an existing capability
[x] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

@mikearche  You are my hero!!  Thanks for looking into this.

Removed the merge commit, and rebased! Should be good to go now.


avm: use own VerificationKey(Data) format

AVM proving in TS is now using VerificationKey and extractVkData which were designed for Noir-style VKs. For example, the field size right now doesn't match, and therefore also the numInputs, etc.
When we fix VK exporting in the CPP side, we should create an AVM_VERIFICATION_KEY_LENGTH_IN_FIELDS constant as well.

Done


css-placeholder-shown: Add MS Edge UserVoice link

https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/12435951--placeholder-shown-css-pseudo-class

Off topic, sorry: Lol, I can't remember submitted that suggestion oO :D


Doc comments

Added basic doc comment coverage. Will continue pushing later to full coverage.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.97%. Comparing base (f3a9322) to head (f364ae2).

Files with missing lines
Patch %
Lines

src/app/migrations.rs
0.00%
2 Missing :warning:

src/bin/create-checkpoint.rs
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #301      +/-   ##
===========================================
+ Coverage    36.68%   36.97%   +0.28%
===========================================
  Files           25       23       -2
  Lines         9510     9437      -73
===========================================
  Hits          3489     3489
+ Misses        6021     5948      -73

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix a bug that toast window is shown below keyboard in iOS 11

It fixes #117

The fix will cause my app crash when clicking back button on the navigation bar as long as the keyboard appears.

@yuan-java, could you please test it again? I changed the implementation.

Can I test too @devxoul?

@RafaelPlantard sure thing!

Sounds good. I made small suggestions for you at #138.
Also, I'm not sure that we still need bringWindowToTop: it's now rendered useless and can be deleted.

To be honest, I forgot about that pull request. :-D

@devxoul I've merged it. But if we get a report of a rejection by Apple for adding subviews to the keyboard, we'll have to revert it.

@devxoul let's do a release with that change, to get feedback on it.

Still doesn't work for me. iOS 12+


Add suport for basic application/x-www-form-urlencoded POST requests

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
Other
🔖 Feature description
The current POST request feature, only allows for the body to contain { json data }.  Would be super helpful to have the option to POST key values as 'application/x-www-form-urlencoded'.
✔ Solution
Example of output I want to send via the POST request.
name=test&email=test%40test.com&attention=Technical&message=test
Rather than the json output that it currently sends via the POST request.
{"name":"test","email":"test@test.com","attention":"Technical","message":"test"}
❓ Alternatives
No response
📝 Additional Context
No response

I just checked my recently installed uptime-kuma instance (v1.11.4) and it appears to have this feature already.

The current post feature only posts via json.  { }
On Fri, Feb 25, 2022 at 12:34 PM Teo Gonzalez @.***>
wrote:

I just checked my recently installed uptime-kuma instance (v1.11.4) and it
appears to have this feature already.
[image: Screen Shot 2022-02-25 at 11 32 19]
https://user-images.githubusercontent.com/16421524/155768920-1db97b8a-ef93-482d-aacf-48af3a62ea6e.png
—
Reply to this email directly, view it on GitHub
https://github.com/louislam/uptime-kuma/issues/1332#issuecomment-1051097253,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVHW37VLIH7WSIOURFEPBJ3U47DTVANCNFSM5PFBCY6A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Yup! I was editing my comment to say that i'm sorry, I think i didn't understood the question at first.
On the bright side, I think the change isn't too difficult, and I will try to create a Merge Request this weekend to see if I can add the functionality.

You rock Teo!!!  Appreciate your time b.
On Fri, Feb 25, 2022 at 12:53 PM Teo Gonzalez @.***>
wrote:

Yup! I was editing my comment to say that i'm sorry, I think i didn't
understood the question at first.
On the bright side, I think the change isn't too difficult, and I will try
to create a Merge Request this weekend to see if I can add the
functionality.
—
Reply to this email directly, view it on GitHub
https://github.com/louislam/uptime-kuma/issues/1332#issuecomment-1051109286,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVHW37W7PWVKFYKUCHWD2HTU47F2LANCNFSM5PFBCY6A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

I was going to request the same feature, but then I found this issues and also two more which are related:

https://github.com/louislam/uptime-kuma/issues/1351
https://github.com/louislam/uptime-kuma/issues/1679

We need to do basic application/x-www-form-urlencoded POST request to be able to log into WordPress. That way we will be able to check some basic membership-only pages using a low-privileged users.
I tried to use the Header fields to change the type of the POST data:
{
    "Content-Type": "application/x-www-form-urlencoded"
}

But then it simply sent the whole POST JSON as text and did not set the individual keys.
Seems like this only needs a way of setting the POST type. So I hope this won't be hard to improve.
Thanks,
Martin


Portal breaks when using createRef

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

Portal component should accept refs created through createRef()
Current Behavior 😯

Portal blows up when doing so
Steps to Reproduce 🕹

Link: https://codesandbox.io/s/pyp3p5r0kx

Create ref in component constructor with createRef
Pass ref to Portal
That's it, Portal breaks and complains the container is not a valid element:

Context 🔦

I'm upgrading my app to React 16 and doing performance optimizations, one of which is avoiding inline functions as props, as they get renewed every time the component updates and triggers re-renders down the whole tree.
Your Environment 🌎

Tech
Version

Material-UI
v3.9.3

React
v16.8.4

Browser

TypeScript

etc.

Doing it like this works though: <Portal container={this.containerRef.current} />. Don't know how applicable this report still is.

Link: codesandbox.io/s/pyp3p5r0kx

Could you add your Portal + ref usage?

That is the behavior documented in the component API. If you pass in a ref we don't know when the instance will be available.

I always get eluded when sharing sandboxes. Should have the example code now.

I see. As I said we require an actual instance here not just the ref. Otherwise we won't know when the instance the ref points to changes.
You could put the container into state and use a callback-ref to update the state: https://codesandbox.io/s/v39w4qkox5
class Component extends React.Component {
  state = {
    container: null,
  };

  handleContainerRef = instance => this.setState({ container: instance });

  render() {
    const { container } = this.state;

    return (

        <Portal container={container}>
          {/* ... */}
        </Portal>

    );
  }
}

That solution is not really making use of the createRef() method though, which is the recommended way of dealing with refs moving forward.

With ref-objects you don't know when the instance changes the ref points to which is required for a portal. React portals need a DOM element not a ref.

which is the recommended way of dealing with refs moving forward.

I'm not aware of such a blanket recommendation. The docs still have a section for callback refs.
The example I used can also be ported to ref-objects. However, it becomes increasingly complicated to know when the DOM instance is available if you forward the ref to another component.

That's my interpretation from

Note
The examples below have been updated to use the React.createRef() API introduced in React 16.3. If you are using an earlier release of React, we recommend using callback refs instead.

In any case, the added explanation in the docs suffice, and my problem is solved. Thanks.


[tiles] Per capita calculation

update per capita calculation for tiles so that tiles fetch a series for the denom data and chooses the data point with the closest date to the main stat

create new data fetch methods for series and series/within
add helper function that gets the denom value to use for a given data point & use this in all the tiles

when choosing unit and scaling factor, use % and scaling factor of 100 when per capita is selected and there isn't any other unit being used. Make this a helper function that is used in all the tiles

screen-recording - 2023-09-01T155755.603.webm
screen-recording - 2023-09-01T155636.661.webm

thanks for the review!


Change UMD build of SignalR to use WebPack

Today we use rollup to package our CommonJS compiler output into a UMD file that can be embedded via a <script> tag. Well, rollup has a regression on Node 9+. I think it's going to be easiest to just switch to use WebPack's library output.
This is blocking #1967 because the new Jenkins images (and the VSTS images that will likely follow it) are running the latest Node. We also just want our developers (internal and external) to be able to use the latest Node.

https://github.com/aspnet/SignalR/commit/b124cb52831eb04de8de113fe4aacedc05eb9a77


Remove the IAM Policy Controller

Ref: https://issues.redhat.com/browse/ACM-10859

Please add the Jira to the commit message for traceability.

Please add the Jira to the commit message for traceability.

Curios how did you know I opened this pr

Curious how did you know I opened this pr

😬 I had sent you all those links, so I was curious to see how the PR had panned out, haha!

Looks like it was a fair bit more work than I'd expect with all the test changes!

Looks like it was a fair bit more work than I'd expect with all the test changes!

I thought it would be simple too

/cc @dhaiducek @mprahl

@yiraeChristineKim does this lead to the iam-policy-controller ClusterManagementAddOn  getting deleted?

@yiraeChristineKim so this will stop managing the ManagedClusterAddOn objects related to the iam-policy-controller and then you'll delete the ClusterManagementAddOn in multiclusterhub-operator?

@yiraeChristineKim so this will stop managing the ManagedClusterAddOn objects related to the iam-policy-controller and then you'll delete the ClusterManagementAddOn in multiclusterhub-operator?

Correct https://github.com/stolostron/multiclusterhub-operator/pull/1466 this PR will delete cma and current https://github.com/stolostron/klusterlet-addon-controller/pull/227 PR will delete mca

/cc @zhiweiyin318

/approve


Inconsistent Behavior Between Triton and PyTorch When Modifying Input Tensor In-Place for Gradient Storage

Question
Hi triton team, I am implementing a triton kernel (2.3.0 on A100) with the trick of modifying the input tensor in-place to store gradient to save memory. However, I found some unexpected behaviors:

With triton kernel backward, the version of input tensor stays at 0 no matter how many times i run the backward
With pytorch native backward, the version of input tensor increments by 1 after each backward and throws the in-place error.
With triton kernel backward + 2 views before the forward, the version of input tensor stays at 0 in the first backward, and increments by 1 at the second backward (??!), and throws the in-place error

In general, i would like to know how to safely modify input tensor in-place to save memory in backward, or it is not encouraged?
Reproduce
import torch
import triton
import triton.language as tl

# y = x**2
# dx = dy * 2x

def full(func):
    B, T, C = 2, 4, 8
    X = torch.randn(B*T, C, requires_grad=True, device='cuda')
    Y = func(X)
    # Intentionally backward three times
    Y.backward(torch.ones_like(Y), retain_graph=True)
    print("1st backward input version", X._version)
    Y.backward(torch.ones_like(Y), retain_graph=True)
    print("2nd backward input version", X._version)
    Y.backward(torch.ones_like(Y), retain_graph=True)
    print("3rd backward input version", X._version)

def full_with_view(func):
    B, T, C = 2, 4, 8
    X = torch.randn(B*T, C, requires_grad=True, device='cuda')
    # Same as full but just do two redundant view ops
    Y = func(X.view(B, T, C).view(B*T, C))
    # Intentionally backward three time
    Y.backward(torch.ones_like(Y), retain_graph=True)
    print("1st backward input version", X._version)
    Y.backward(torch.ones_like(Y), retain_graph=True)
    print("2nd backward input version", X._version)
    # It fails at the 3rd backward
    Y.backward(torch.ones_like(Y), retain_graph=True)
    print("3rd backward input version", X._version)

class SquareFunction(torch.autograd.Function):
    @staticmethod
    def forward(ctx, input):
        ctx.save_for_backward(input)
        return input ** 2

    @staticmethod
    def backward(ctx, grad_output):
        (input,) = ctx.saved_tensors
        grad_output *= 2
        input *= grad_output
        return input, None

@triton.jit
def element_mul(
    X_ptr,
    X_stride,
    grad_output_ptr,
    grad_output_stride,
    n_cols,
    BLOCK_SIZE: tl.constexpr
):
    program_id = tl.program_id(axis=0)
    X_ptr += program_id * X_stride
    grad_output_ptr += program_id * grad_output_stride
    offsets = tl.arange(0, BLOCK_SIZE)
    X_row = tl.load(X_ptr+ offsets, mask=offsets < n_cols)
    grad_output = tl.load(grad_output_ptr+offsets, mask=offsets < n_cols)
    tl.store(X_ptr + offsets, X_row * grad_output, mask=offsets < n_cols)

class TritonSquareFunction(torch.autograd.Function):
    @staticmethod
    def forward(ctx, input):
        ctx.save_for_backward(input)
        return input ** 2

    @staticmethod
    def backward(ctx, grad_output):
        (input,) = ctx.saved_tensors
        grad_output *= 2
        # triton kernel
        BLOCK_SIZE = 1024
        n_cols = input.size(1)
        n_row = input.size(0)
        element_mul[(n_row, )](
            input,
            input.stride(-2),
            grad_output,
            grad_output.stride(-2),
            n_cols,
            BLOCK_SIZE
        )
        return input, None

full(TritonSquareFunction.apply)
print("TritonSquareFunction done")

try:
    full_with_view(TritonSquareFunction.apply)
    print("TritonSquareFunction done")
except RuntimeError as e:
    print(e)

try:
    full(SquareFunction.apply)
    print("SquareFunction done")
except RuntimeError as e:
    print(e)

Output:
1st backward input version 0
2nd backward input version 0
3rd backward input version 0
TritonSquareFunction done
1st backward input version 0
2nd backward input version 1
one of the variables needed for gradient computation has been modified by an inplace operation: [torch.cuda.FloatTensor [8, 8]], which is output 0 of AsStridedBackward0, is at version 1; expected version 0 instead. Hint: enable anomaly detection to find the operation that failed to compute its gradient, with torch.autograd.set_detect_anomaly(True).
1st backward input version 1
one of the variables needed for gradient computation has been modified by an inplace operation: [torch.cuda.FloatTensor [8, 8]] is at version 1; expected version 0 instead. Hint: enable anomaly detection to find the operation that failed to compute its gradient, with torch.autograd.set_detect_anomaly(True).

Updated a new script. I found that if i do two view ops for the input with the triton kernel, it will also run into this error. I am more confused now

Answer from claude 3 Sonnet (much better than chatgpt and gemini in this case):

This behavior is related to how PyTorch handles in-place operations and how it tracks the version of tensors for autograd. In PyTorch, when a tensor is modified in-place, its version is incremented to keep track of the changes and ensure correct gradient computation.
In your case, when you use the TritonSquareFunction without the redundant views, the input tensor's version stays at 0 because the triton kernel is directly modifying the input tensor in-place without creating any new views or copies. PyTorch allows this as long as the tensor is not used in any other computation that requires its original value.
However, when you introduce the redundant views (X.view(B, T, C).view(B*T, C)), PyTorch creates new views of the input tensor, and the version of the input tensor is incremented. During the backward pass, when you try to modify the input tensor in-place using the triton kernel, PyTorch detects that the tensor version has changed, and it throws an error because it expects the tensor version to be the same as when it was saved for the backward pass.
The PyTorch native backward (SquareFunction) increments the input tensor's version after each backward pass because it creates a new tensor for the gradient and performs an in-place addition operation (input *= grad_output).
To safely modify the input tensor in-place during the backward pass, you should avoid creating any new views or copies of the input tensor before passing it to the forward function. If you need to reshape the input tensor, you should do it inside the forward function and save the reshaped tensor for the backward pass.
Additionally, you can consider using PyTorch's in-place operations carefully or use PyTorch's functional APIs that perform out-of-place operations to avoid modifying the input tensor directly.
In general, modifying input tensors in-place during the backward pass is not recommended because it can lead to unexpected behaviors and potential errors, especially when dealing with complex computations and control flows. It's safer to create new tensors for the gradients and perform out-of-place operations to avoid modifying the input tensors.

full(TritonSquareFunction.apply)

1st backward input version 0
2nd backward input version 0
3rd backward input version 0

full_with_view(TritonSquareFunction.apply)

1st backward input version 0
2nd backward input version 1
RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation: [torch.cuda.FloatTensor [8, 8]], which is output 0 of AsStridedBackward0, is at version 1; expected version 0 instead. Hint: enable anomaly detection to find the operation that failed to compute its gradient, with torch.autograd.set_detect_anomaly(True)

full(SquareFunction.apply)

1st backward input version 1
RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation: [torch.cuda.FloatTensor [8, 8]] is at version 1; expected version 0 instead. Hint: enable anomaly detection to find the operation that failed to compute its gradient, with torch.autograd.set_detect_anomaly(True).

full_with_view(SquareFunction.apply)

1st backward input version 1
RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation: [torch.cuda.FloatTensor [8, 8]], which is output 0 of AsStridedBackward0, is at version 1; expected version 0 instead. Hint: enable anomaly detection to find the operation that failed to compute its gradient, with torch.autograd.set_detect_anomaly(True).


Improve stability in cases of new broker additions to cluster

Handle topic creation when a partition has in-sync replicas that current broker configuration doesn't know
Update cluster's metadata when a partition's leader is not listed in currently known brokers

@emmett9001 Appreciate if you can review and let me know your thoughts.
This fixes a couple of issues we encountered in production with producers during a maintenance activity on Kafka cluster.

These changes both look reasonable to me

Codecov Report

Merging #936 into master will decrease coverage by 7.11%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
- Coverage   83.21%   76.09%   -7.12%
==========================================
  Files          36       36
  Lines        3806     3807       +1
  Branches      562      524      -38
==========================================
- Hits         3167     2897     -270
- Misses        492      748     +256
- Partials      147      162      +15

Impacted Files
Coverage Δ

pykafka/topic.py
71.13% <ø> (-5.16%)
:arrow_down:

pykafka/partition.py
72.72% <ø> (ø)
:arrow_up:

pykafka/cluster.py
65.32% <0%> (-6.84%)
:arrow_down:

pykafka/rdkafka/helpers.py
20% <0%> (-73.34%)
:arrow_down:

pykafka/managedbalancedconsumer.py
45.03% <0%> (-34.44%)
:arrow_down:

pykafka/broker.py
67.05% <0%> (-27.17%)
:arrow_down:

pykafka/connection.py
60.39% <0%> (-24.76%)
:arrow_down:

pykafka/handlers.py
73.52% <0%> (-18.39%)
:arrow_down:

pykafka/utils/compat.py
70.27% <0%> (-14.87%)
:arrow_down:

pykafka/simpleconsumer.py
75.66% <0%> (-10.5%)
:arrow_down:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c06730...75b21f9. Read the comment docs.


Add PerfChecker

https://github.com/JuliaConstraints/PerfChecker.jl
cc @Azzaare, @VarLad

I will merge this, and add the required PkgInfo in utils.jl myself. Thanks!


CLI: Add check command

This PR adds the check command to the CLI.  This PR depends on #127.
This command allows the user to check if some required commands are available before running TourGuide.

LGTM


Show why configuration cache test is ignored

Mention the reason in the exception thrown.

@bot-gradle test and merge.

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.


Prepatcher Optional Dependency

Looking at the documentation, it seems to be based on making the mod depend on Prepatcher. Unfortunately, this is not feasible for me. In the previous versions, I could use careful management of method calling to only use the added fields when Prepatcher is installed. I was wondering if there is anything similar I could do with this version. Specifically, I would like a way to be able to add the field and use it when prepatcher is installed, but fall back to a dictionary-based approach if it is now.

Answered on Discord.


Fixed saving of homepage

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Fixed tickets
none

Related issues/PRs
none

License
MIT

Documentation PR
none

What's in this PR?
This PR fixes a bug, which caused an error to be thrown when the homepage is saved saying that the resource locator is not valid. This only happened when there was already another page, apart from the homepage, created.
Why?
Because content manager might also want to change the homepage without an error :-)

else ACK

Maybe we could even remove the ResourceSegmentBehavior from the HomeDocument, but I am too afraid to make this change so short before the Release...

@danrot when the tests working i will merge this tomorrow


Nova unsaved URI format crashes server

Environment

Elixir & Erlang versions (elixir --version): Elixir 1.11.2 (compiled with Erlang/OTP 23)
Operating system: macOS 11.1 Big Sur
Editor or IDE name (e.g. Emacs/VSCode): Nova
Editor Plugin/LSP Client name: Nova ElixirLS

The language server crashes while attempting to parse a path from the "textDocument" URI sent by the Nova LSP client. I'm not sure if this is an issue with elixir-ls or Nova's LSP client since I couldn't find a specification for unsaved document URIs in the LSP docs. This works fine in VSCode because they use a different URI format.
Nova format:
"textDocument": {
	"uri": "unsaved://343C3EE7-D575-486D-9D33-93AFFAF773BD"
}

VSCode format:
"textDocument": {
	"uri": "untitled:Untitled-1"
}

Logs
Line that triggers the crash: https://github.com/elixir-lsp/elixir-ls/blob/master/apps/language_server/lib/language_server/source_file.ex#L66
21:47:49.496 [error] GenServer ElixirLS.LanguageServer.Server terminating
** (FunctionClauseError) no function clause matching in URI.unpercent/3
	(elixir 1.11.2) lib/uri.ex:364: URI.unpercent(nil, "", false)
	(elixir 1.11.2) lib/uri.ex:341: URI.decode/1
	(language_server 0.6.0) lib/language_server/source_file.ex:43: ElixirLS.LanguageServer.SourceFile.path_from_uri/1
	(language_server 0.6.0) lib/language_server/source_file.ex:216: ElixirLS.LanguageServer.SourceFile.formatter_opts/1
	(language_server 0.6.0) lib/language_server/server.ex:486: ElixirLS.LanguageServer.Server.handle_request/2
	(language_server 0.6.0) lib/language_server/server.ex:332: ElixirLS.LanguageServer.Server.handle_request_packet/3
	(language_server 0.6.0) lib/language_server/server.ex:126: ElixirLS.LanguageServer.Server.handle_cast/2
	(stdlib 3.14) gen_server.erl:689: :gen_server.try_dispatch/4
Last message: {:"$gen_cast", {:receive_packet, %{"id" => 7, "jsonrpc" => "2.0", "method" => "textDocument/completion", "params" => %{"context" => %{"triggerCharacter" => "s", "triggerKind" => 2}, "position" => %{"character" => 4, "line" => 8}, "textDocument" => %{"uri" => "unsaved://343C3EE7-D575-486D-9D33-93AFFAF773BD"}}}}}

Nova URI is a rather non standard as it is not mentioned in language server spec. Anyway, it looks like vscode untitled:Untitled-1 is also handled incorrectly as it returns a not existing file.
A PR fixing that would be appreciated.


.NET 6:  Reusable Razor UI in class libraries with ASP.NET Core

In this article, there is an example shown to enable static web assets, but it is using the .NET 3.1/5 generic hosting model.  Need an example showing how to enable this using the minimal .NET 6 hosting model.
When the view tab is selected to show .NET 6.0, I would suggest the example should change from the old hosting model to the new model.
The existing .NET 5 example is shown like this:
    public static IHostBuilder CreateHostBuilder(string[] args) =>
        Host.CreateDefaultBuilder(args)
            .ConfigureWebHostDefaults(webBuilder =>
            {
                webBuilder.UseStaticWebAssets();
                webBuilder.UseStartup<Startup>();
            });

We need a similar example for the .NET 6 hosting model.  I have been unable to find any such example anywhere in the docs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9fd019c7-ceb7-6ef3-26ba-6b44341b6fc5
Version Independent ID: fd116d00-0dc7-efaf-c714-34d77b345a05
Content: Reusable Razor UI in class libraries with ASP.NET Core
Content Source: aspnetcore/razor-pages/ui-class.md
Product: aspnet-core
Technology: aspnetcore-razorpages
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

We'll eventually get to this. It shouldn't be hard to covert to the new hosting model. See https://docs.microsoft.com/en-us/aspnet/core/migration/50-to-60-samples

I had a quick look at this specific issue. Although it's possible to do this:
builder.WebHost.UseStaticWebAssets();

That fails with an error about how the WebRootPath has changed. From what I can see, it isn't possible to do this with the minimal hosting model, but I could very well be wrong.

@halter73 what's the right approach here for creating a Reusable Razor UI in class library with .NET 6?

@Rick-Anderson your link to the 5.0 -> 6.0 examples does not show this feature, and this is why I raised this issue.  As @serpent5  mentioned, an exception is raised if you try the intuitive syntax shown.  I have a stack overflow question on this that has had no comments or answers.

Also running into this issue. Failure to set .UseStaticWebAssets() causes a lot of problems when your using build environment names such as "LocalDevelopment" instead of the "Development".
Which then of course breaks Razor's CSS Isolation feature as indicated here: https://github.com/dotnet/aspnetcore/issues/28174#issuecomment-734239932
In particular note this comment:

Static web assets are only enabled by default in the Development environment. If you are using a custom environment you need to call webhost.UseStaticWebAssets() to enable them explicitly.

Which now means we can't enable them in .NET 6.0, cause there doesn't seem to be a way to call .UseStaticWebAssets anymore.
Which means it completely breaks CSS Isolation feature in this scenario.
If you go to your launchSettings.json file and put in the following:
      "environmentVariables": {
        "ASPNETCORE_ENVIRONMENT": "LocalDevelopment"
      }

Then launch your project. You will notice that the following line in your _Layout.cshtml will no logner function:
<link rel="stylesheet" href="~/My.Namespace.Web.styles.css" asp-append-version="true" />

Attempting to access that URL results in a 404. And no version string is appended to the link either.
Took me hours to find out that this appears to be an unfixable issue in .NET 6.0.

Actually it appears this is actually unfixable in .NET 6. This work around only half solves the problem:
//Put these two lines before builder.Build();
builder.WebHost.UseWebRoot("wwwroot");
builder.WebHost.UseStaticWebAssets();

var app = builder.Build();

While this does fix the  link tag to now generate the proper URL to the .css file and actually contains the CSS isolated classes. The rest of the page rendering is broken. Those CSS isolated changes are supposed to also roll down to the generated .cshtml content that the CSS isolation files belong to but they no longer do.
Example:

@xantari - thanks for confirming, and for adding detailed documentation.  FYI there is a way to get this to work, but it's kind of a hacky work-around.  Answer is marked here.  It would be nice if there were a way to do this correctly in .NET 6.

cc @dotnet/aspnet-blazor-eng

@captainsafia can you recommend the approach here? (I believe you dealt with this on another issue?)

That fails with an error about how the WebRootPath has changed. From what I can see, it isn't possible to do this with the minimal hosting model, but I could very well be wrong.

This particular issue should be fixed in 6.0.6 via https://github.com/dotnet/aspnetcore/pull/41182.

Those CSS isolated changes are supposed to also roll down to the generated .cshtml content that the CSS isolation files belong to but they no longer do.

Your screenshot points that the unique attributes on the HTML elements is broken. Is there a mismatch between what is generated in the HTML and the CSS?

It really seems odd to me that we even have to do this for any environment. Why would this only be enabled in Dev and Prod environments for Razor CSS isolation to work? Can someone tell me why you would want to have it NOT work for all environments by default?

Because static web assets serves files from other locations like your nuget package cache in your machine and we don't want to be doing that unless we know we are in development. That's why if you are using a different environment you need to register it.
It is not needed in Production because at publish time the files get copied to the wwwroot folder and there is no runtime component at play.


Feat: Modified the download button

Describe the feature
the download button in explore freebook section was taking full width and was not looking good
I modified the button to shot just like a button and now it looks much good
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Hi @SadafKausar2025,
I'm excited to tackle the task of adding more style to download button webpage. With my experience in website development using HTML, CSS, and JavaScript.
Please assign this task to me under GSSoC 24, and I'll get started right away!
Looking forward to your approval and the opportunity to contribute!
Thank you 😊!!

@SadafKausar2025 @Karthikkariappa08
Assigned!
Make sure to attach before & after screenshot in your PR.
Make sure to star the repo before working on it! Happy open-source contributing!

before

after

Thank you for assigning this task .


Updated config for virtualisation

This references ticket RZJE0G01 and adds virtualisation support for the standard kernel build.

Hi @jmthackett, thank you for this contribution, we will rebuild the kernels and release new bootscripts soon


Fix external dependency on highlight constants

SublimeLinter v4.0.0 introduced a breaking change during the refactoring of the highlight module (exception below) which was changed to const. This change also affected other linters like "SublimeLinter-annotations" and so we started a campaign to fix all the dependent packages here [1].
[1] https://github.com/SublimeLinter/SublimeLinter/issues/915
reloading plugin SublimeLinter-contrib-golint.linter
Traceback (most recent call last):
  File "/sublime_plugin.py", line 109, in reload_plugin
    m = importlib.import_module(modulename)
  File "./python3.3/importlib/__init__.py", line 90, in import_module
  File "<frozen importlib._bootstrap>", line 1584, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1565, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1532, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 584, in _check_name_wrapper
  File "<frozen importlib._bootstrap>", line 1022, in load_module
  File "<frozen importlib._bootstrap>", line 1003, in load_module
  File "<frozen importlib._bootstrap>", line 560, in module_for_loader_wrapper
  File "<frozen importlib._bootstrap>", line 868, in _load_module
  File "<frozen importlib._bootstrap>", line 313, in _call_with_frames_removed
  File "/Packages/SublimeLinter-contrib-golint/linter.py", line 13, in <module>
    from SublimeLinter.lint import Linter, util, highlight, persist
ImportError: cannot import name highlight

@cixtor you need to switch here on the version if you want to maintain compatibility with SL3. E.g.:
if getattr(SublimeLinter.lint, 'VERSION', 3) > 3:

@sirreal I have updated this pull-request with the feedback from @braver ; feel free to merge.

Thanks for the contribution! I've invited you as collaborators so please feel free to move ahead with this 🙇

Thanks. Alternatively, we could move the repo into the SublimeLinter group. This allows a number of maintainers to work on it so we can keep it compatible with SL as we make changes to SublimeLinter 4. Having most plugins in the group has been a real boon to making some more impactful changes in a compatible way.
If you want you can transfer the repo to me, I'll move into the group, and make sure you still have full access to it.

Thanks all!
These changes have been merged at 78ce7de4d43cd6d615fb4559c7b8ca6ab4dd4762 and 8967d8b1115e1d1b65d3d1bdd8975fd1b73fda67.


Question: Running HA and Alexa on one slice of pi

I have Amazon echo up and running on my Pi3 as detailed at https://github.com/amzn/alexa-avs-raspberry-pi I have also installed the ha-bridge.
Ha-bridge seems to be running fine to the point that I have added my "Mi-Lights" manually and can turn them on/off via the bridge ui. I briefly changed the port from 8080 to 80 just to connect the hue app and that connected fine.
My problem is Alexa will not find the bridge on my network when I do a search. It finds my nest thermostat fine just not the bridge.
I have tried it with upnp enabled and disabled on my router, I have removed all my devices from alexa and searched again, rebooted etc
I am beggining to wonder if it is unable to find it because both alexa and ha-bridge are on the same Pi.
is there anything you could suggest I do to try and resolve this? I would try setting up bridge on a second Pi but I only have one.
Mark

If you could turn on trace upnp and then post the log output along with the IP of your echo. That would help.
Thanks

Thanks for your response. I turned on trace upnp and the ran a search for devices from the alexa app. the ip for the echo is the same as the bridge <IP_ADDRESS>
`03-31-2016 15:36:20.487	INFO	HA Bridge (v1.4.3) starting....	com.bwssystems.HABridge.HABridge
03-31-2016 15:36:20.524	INFO	reading from config file: data/habridge.config	com.bwssystems.HABridge.BridgeSettings
03-31-2016 15:36:20.697	INFO	HA Bridge (v1.4.3) initializing....	com.bwssystems.HABridge.HABridge
03-31-2016 15:36:20.735	INFO	System control service started....	com.bwssystems.HABridge.SystemControl
03-31-2016 15:36:21.052	INFO	HABridge device management service started....	com.bwssystems.HABridge.devicemanagmeent.DeviceResource
03-31-2016 15:36:21.281	INFO	== Spark has ignited ...	spark.webserver.JettySparkServer
03-31-2016 15:36:21.286	INFO	>> Listening on <IP_ADDRESS>:8080	spark.webserver.JettySparkServer
03-31-2016 15:36:22.377	INFO	Hue emulator service started....	com.bwssystems.HABridge.hue.HueMulator
03-31-2016 15:36:22.397	INFO	Hue description service started....	com.bwssystems.HABridge.upnp.UpnpSettingsResource
03-31-2016 15:36:22.403	INFO	UPNP Discovery Listener starting....	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:36:22.412	INFO	Traceupnp: eth0 ... has addr /fe80:0:0:0:9724:171:e14d:fd70%eth0	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:36:22.418	INFO	Traceupnp: wlan0 ... has addr /fd00:0:0:1:246e:7d62:6ecf:eaf9%wlan0	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:36:22.418	INFO	Traceupnp: wlan0 ... has addr /fe80:0:0:0:ba27:ebff:feb9:c344%wlan0	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:36:22.419	INFO	Traceupnp: wlan0 ... has addr /<IP_ADDRESS>	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:36:22.420	INFO	Traceupnp: Adding wlan0 to our interface set	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:36:22.420	INFO	Traceupnp: lo ... has addr /0:0:0:0:0:0:0:1%lo	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:36:22.421	INFO	Traceupnp: lo ... has addr /<IP_ADDRESS>	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:36:22.421	INFO	Traceupnp: Adding lo to our interface set	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:36:22.421	INFO	UPNP Discovery Listener running and ready....	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:36:40.559	INFO	Traceupnp: isSSDPDiscovery found message to be an M-SEARCH message.	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:36:40.560	INFO	Traceupnp: isSSDPDiscovery found message to be valid under strict rules - strict: true	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:36:40.560	INFO	Traceupnp: SSDP packet from <IP_ADDRESS>:50243, body: M-SEARCH * HTTP/1.1
Host: <IP_ADDRESS>:1900
Man: "ssdp:discover"
ST: ssdp:all
MX: 5
com.bwssystems.HABridge.upnp.UpnpListener

03-31-2016 15:36:40.561	INFO	Traceupnp: sendUpnpResponse discovery template with address: <IP_ADDRESS> and port: 8080	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:37:10.662	INFO	Traceupnp: isSSDPDiscovery found message to be an M-SEARCH message.	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:37:10.663	INFO	Traceupnp: isSSDPDiscovery found message to be valid under strict rules - strict: true	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:37:10.664	INFO	Traceupnp: SSDP packet from <IP_ADDRESS>:50243, body: M-SEARCH * HTTP/1.1
Host: <IP_ADDRESS>:1900
Man: "ssdp:discover"
ST: ssdp:all
MX: 5
com.bwssystems.HABridge.upnp.UpnpListener

03-31-2016 15:37:10.665	INFO	Traceupnp: sendUpnpResponse discovery template with address: <IP_ADDRESS> and port: 8080	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:37:40.770	INFO	Traceupnp: isSSDPDiscovery found message to be an M-SEARCH message.	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:37:40.771	INFO	Traceupnp: isSSDPDiscovery found message to be valid under strict rules - strict: true	com.bwssystems.HABridge.upnp.UpnpListener
03-31-2016 15:37:40.772	INFO	Traceupnp: SSDP packet from <IP_ADDRESS>:50243, body: M-SEARCH * HTTP/1.1
Host: <IP_ADDRESS>:1900
Man: "ssdp:discover"
ST: ssdp:all
MX: 5
com.bwssystems.HABridge.upnp.UpnpListener

03-31-2016 15:37:40.776	INFO	Traceupnp: sendUpnpResponse discovery template with address: <IP_ADDRESS> and port: 8080	com.bwssystems.HABridge.upnp.UpnpListener`

So, since it is an app on the same pi, you'll need to get routing setup for local multicast as the alexa app is not getting out on multicast.

local multicast? sounds complicated looks like I have I have some googling to do then! lol. Thank you for taking a look and your quick response!!!

I also have an Amazon Echo running on a pi using the same github project.     The ha-bridge is running on a separate pi.   my logs look similar,  UPNP starting etc but the Echo does not find the bridge.

So, the echo dev setup is not sending out a request on discover. So maybe they disabled the local discovery and only the linked home auto stuff is the only thing that works?

When I first got the echo setup and searched for devices it found my nest thermostat before I had linked any accounts so I assume the echo must have found it.

That is what I'm assuming and the local network discovery has been disabled, so no finding the Hue or bridge for that matter. Looks like you'll need a real echo.

Closing as the Alexa development does not have discovery.


Include balena fin dt overlay in resinOS

@curcuz it's as part of a patch over the kernel.

@agherzan lgtm'ed this PR.
Can you fix the conflicts and re-commit please?

Repushed. Will merge as soon as build finishes.


Autosave not triggered with list.extend() / list.append()

When a CleverDict attribute or value is changed using "=" assignment it triggers the .save() method as intended.
list.append() and list.extend() do NOT trigger the autosave function however... not sure why, and I don't have any understanding of the internals, but just wondered if there it might be desirable/possible to specify a list of methods (outside of the CleverDict class) which, if called, would also trigger a mapped CleverDict method... mainly .save and .delete but could be other things as well.
That might be overly complicated, or it might provide another rich layer of cleverness to CleverDict.  Please let me know your initial thoughts?

Raised in error - CleverDict runs methods like .extend just fine.  Confusion with derivative list.

I see that you have closed this issue, but I think it is not.
If I understand you well, you like to call the save method when the value in a CleverDict is updated with extend or append.
Well, that is not possible at all as the CleverDict object is not aware of the change of a mutable object.
The following program demonstrates that:
from cleverdict import CleverDict
class MyDict(CleverDict):
def save(self, k, v):
print(f'save[{k}] = {v}')
def init(self, *args, **kwargs):
super().init(**kwargs)
a = MyDict()
a[3]=4
l = [2,3]
a[1]= l
l.extend([4,5])  # this does not call the save method!
print(a)
I don't know what you mean when you say .extend works fine. But certainly not in this example.
Maybe you have to explain what you did accomplish with respct to .extend and save.

Parked for now - it may even be an advantage to have .append() method able to bypass setting behaviour e.g. to avoid recursion issues in README example:
class AutoStore(CleverDict):
    def __init__(self, *args, **kwargs):
        self.setattr_direct('index', [])
        super().__init__(*args, **kwargs)

    def save(self, name, value):
        """ Keep a separate 'store' for data in .index """
        self.index.append((name, value))

Parked for now - it may even be an advantage to have .append() method able to bypass setting behaviour e.g. to avoid recursion issues in README example:
class AutoStore(CleverDict):
    def __init__(self, *args, **kwargs):
        self.setattr_direct('index', [])
        super().__init__(*args, **kwargs)

    def save(self, name, value):
        """ Keep a separate 'store' for data in .index """
        self.index.append((name, value))


Add node 10 to test matrix, remove node 4.2

This is good. I'm thinking that it would probably be OK to just test on LTS versions (8 and 10) if we wanted to remove even more versions.

This is good. I'm thinking that it would probably be OK to just test on LTS versions (8 and 10) if we wanted to remove even more versions.

One of the node 7 builds failed on the PR run, but it looks like it just got weirdly stuck and timed out. Same build passed on the push run so I'm going to merge this in.


Transition existing partners to updated reportstream.cdc.gov

Now that we've got the newest version of ReportStream deployed, start scheduling partners to move over to the new site.

List current prime.cdc.gov users
Inform partners of new site and URLs via email
Do we need to host a training session? Do a walkthrough meeting?
Monitor download site for stability/etc as users transition
After 30 (?) days of all users successfully being transitioned, shut downprime.cdc.gov

@ronaldheft-usds could you set up a redirect from https://prime.cdc.gov/download to reportstream.cdc.gov?

@jlusds Yes, I can have a PR set for that today.

Thanks Ron!

From: Ron Heft @.>
Sent: Thursday, May 27, 2021 7:34 AM
To: CDCgov/prime-data-hub @.>
Cc: Liu, James (CDC/OCOO/OD) @.>; Mention @.>
Subject: Re: [CDCgov/prime-data-hub] Transition existing partners to updated reportstream.cdc.gov (#1054)
@jlusdshttps://github.com/jlusds Yes, I can have a PR set for that today.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/CDCgov/prime-data-hub/issues/1054#issuecomment-849686830, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ2FEWZHYQXXXNVMHQ5TZ7TTPZJ7DANCNFSM44TNGAFQ.