Batch polygon and circle fills and strokes

Fixes #4232.
Better solution than the reverted one from #5149.

Opened for discussion. See description above.

How about this: when creating the replay, we check if there is any opacity. If so, we do not batch. Otherwise we do. I can update the pull request easily for a proof of concept.

How about this: when creating the replay, we check if there is any opacity. If so, we do not batch. Otherwise we do. I can update the pull request easily for a proof of concept.

I think this is a nice approach. Ready for review.

While I agree this approach is a nice default that works, I would find an option to force the batching always on useful in cases where I don't care about the opacity-correctness.

I don't want to rain on the parade, but I'm dubious about the effort to batch fills and strokes in this way.  Here is a picture with batched fills and strokes:

I don't think this is what people want.
I'm also curious about how this affects what is reported in #4232, since I think that with the changes here, things are not being batched (because this.transparency is only true if the red value is 1, see https://github.com/openlayers/ol3/pull/5196#discussion_r59698640).

I can imagine we could gain performance when there is no fill or no stroke.  In those cases, we could defer stroking or filling (respectively) until the end.  We could also delay stroking or filling until a fill or stroke is encountered (no need to stroke until you are going to fill and no need to fill until you are going to stroke).  But these performance gains would be limited to pretty narrow cases.

Thanks @tschaub and @bjornharrtell for the valuable feedback. Based on that, I introduced a new overlaps option for ol.source.Vector and ol.source.VectorTile, which allows users to decide whether the fill and stroke optimisations should be applied. Does this look better to you now?

Looks good to me. I like the note on which kind of data this works on, another argument for my mission to convince people to work with non-overlapping topological data.

This sounds like a nice solution @ahocevar.  It looks like your tests may cover it, but it would be even clearer to see rendering tests for overlaps: false with and without changing stroke and fill styles (to make sure we always properly stroke/fill when the styles change).

Thanks for the review @tschaub. I have addressed your comments. Can you take another look please?

Is this good to merge now @tschaub?

Any chance to get a final review on this? Thanks in advance.

Updated pull request so it can be merged into master.
Is this good to merge, or does anyone want to give this another review?

To compare performance with and without overlaps: false, hover over the USA in the following fiddles:

with overlaps: false: http://jsfiddle.net/4cxeh29o/
without overlaps: false: http://jsfiddle.net/4cxeh29o/1/

That said, I'd still appreciate a final review on this. @tschaub maybe?

We've been running a build of this in our dev- and demo environments for about a month now with very positive result.

Rebased again, still hoping for a final review.

Rebased one more time.

LGTM @ahocevar

Thanks for the reviews @tschaub and @bartvde.

sorry for being late, but shouldn't this addition to the API be documented in the release notes?

sorry for being late, but shouldn't this addition to the API be documented in the release notes?

Changes like this can be added to the release notes by the release manager when the release is created.

the performance boost with this change is amazing !!

This says the issue #4232 is closed by this issue, I but still have terrible performance issue using IE (11 or Edge) - FF is a bit better, but not much. I use OL 3.19 version. Is there any progress on this?

@mstrop Have you configured your source with overlaps: false?

Yep, both - with and without. The difference is minimal. In addition to this, having the source defined as overlaps: false is causing display bugs for certain zooms.

@mstrop Looks like your source does not have topological data, so you cannot use the overlaps: false option anyway. I think you'll have to apply different optimisations here, because your use case is not one that this fix was made for.

@ahocevar ups, it's not a good message. Is there a chance this issue will be solved in future?

@mstrop The only two places where I see additional potential for library side performance optimization is text and regular shape (including circle) rendering.
In your case, however, I suspect that you could optimize the style functions for your vector layers on the application level.

@ahocevar thanks a lot.

@ahocevar sry, one more question - I was thinking about your comment "I suspect that you could optimize the style functions for your vector layers on the application level". What is relation between a styling function and forEachFeatureAtPixel method? I use forEachFeatureAtPixel inside pointer move event as I need to change cursor in case it hovers above a feature. So the styling function is not called as the map is not being redrawn. Or am I missing anything?

Even if you are only using forEachFeatureAtPixel for changing the cursor, without highlighting any features on the map, the style function will be called. Because for hit detection, features near the cursor will be rendered to a hidden small canvas to detect which features are rendered at the cursor location.

My mistake @mstrop. The style function is called when creating the replay, not when replaying. And during mousemoves, it is only replayed.
However, without seeing your code, it is hard to guess what could be the culprit. Does your vector source use a spatial index? Have you tried with a lower hitTolerance as option on your forEachFeatureAtPixel calls?


Adjust cited in filter size so full title displays

Please adjust this filter size so that the full title of De la Grammatologie displays, instead of being cut off as it is here:

@rlskoeser This is dependent on the width and the font-size of the filter component. I was looking into truncating the filter values if they were longer than the input, so it would look like "De la grammatolo..." Would that be acceptable?

@kevinglover could we make an exception for this filter to make sure the full title displays?
@xinyil what do you think?

Would like ideas on how we could get all the titles to fit. We could change this field to be expandable, but we would have to decide how the filters would need to be adjusted

It'd be good to make an exception for this filter. Maybe manually set the width so it displays the full title.

@xinyil It would be difficult to make the filter width dynamically change based on the size of the title. If De la Grammatologie will always be the longest title, we can set the width to the calculated size of "De la Grammatologie", but even that width may differ based on the font loaded.
Another thing we could try would be to reduce the font-size of the filter.

We don't need to make the width dynamically change. Just extend the size for this filter would be good. We could leave some Extra space for this one.

@xinyil Ok, that should be already merged in:

Looks good.


hammer_bundle causes segmentation fault

Since the recent fix for hammer_bundle in #473 running it crashes the Python process with an segmentation fault:
import dask.dataframe as dd
from datashader.layout import circular_layout
from datashader.bundling import hammer_bundle

edges_df = dd.read_parquet('./data/maccdc2012_edges.parq').compute()
nodes_df = dd.read_parquet('./data/maccdc2012_nodes.parq').compute()

positions = circular_layout(nodes_df, edges_df)
bundled = hammer_bundle(positions, edges_df)

Segmentation fault: 11

Actually not at all clear to me what caused this, reverting #473 doesn't help.

Reverting https://github.com/bokeh/datashader/pull/458 fixes it.

I haven't been able to recreate it yet. Maybe it's related to the removed edge index in #472.
Could you retry with the updated graph data?

Just re-downloaded the data, still seeing this consistently.

I can reproduce it:
0172-jbednar:~/datashader/examples> pyver dask
dask=0.11.0  # /Users/jbednar/anaconda/lib/python2.7/site-packages/dask
0172-jbednar:~/datashader/examples> git describe
0.6.1-10-g9f8a8a1
0172-jbednar:~/datashader/examples> bash
bash-3.2$ source activate ds
(ds) bash-3.2$ python bundlebug.py
Segmentation fault: 11
(ds) bash-3.2$ cat bundlebug.py
import dask.dataframe as dd
from datashader.layout import circular_layout
from datashader.bundling import hammer_bundle

edges_df = dd.read_parquet('./data/maccdc2012_edges.parq').compute()
nodes_df = dd.read_parquet('./data/maccdc2012_nodes.parq').compute()

positions = circular_layout(nodes_df, edges_df)
bundled = hammer_bundle(positions, edges_df)

I was also able to reproduce it after recreating the environment.


当n-data-table组件columns中某一列key值对应的列表数据为数组对象时，再变更这个值会抛出异常。测试从数组对象变更为null；

TuSimple/naive-ui version (版本)
2.34.3
Vue version (Vue 版本)
3.3.0-alpha.4
Browser and its version (浏览器及其版本)
Chrome(110.0.5481.100)
System and its version (系统及其版本)
MacOS
Node version (Node 版本)
Reappearance link (重现链接)
https://www.naiveui.com/zh-CN/os-theme
Reappearance steps (重现步骤)
步骤在标题中有写到
Expected results (期望的结果)
望解决
Actual results (实际的结果)
望解决
Remarks (补充说明)

This issue does not have any recent activity. If you are still experiencing similar problems, open a new error, including a minimal copy of the problem


[e2e] 🚚 move folders

What does this PR do?

Move framework folders to pkg, move teams tests folders to tests
Motivation

Code is growing, we want to clearly separate core new e2e packages, owned by the squad, from tests, owned by teams.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

I think the CODEOWNERS needs to be updated


Attachment filename and URL are not populated

When I select a file to attach in the chat UI I expect a message passed to onMessageWasSent to contain selected filename and URL. However, it's empty: {"author":"me","type":"file","data":{"file":{}}}.
The readme says it should pass a message like this:
{
  author: 'me',
  type: 'file',
  id: 1, // or text '1'
  isEdited: false,
  data: {
    file: {
      name: 'file.mp3',
      url: 'https:123.rf/file.mp3'
    }
  }
}

I tested it with Chrome and Safari on Mac.
This is how I know the message:
onMessageWasSent(message) {
      console.log("onMessageWasSent() called: " + JSON.stringify(message));
...
}

I tried to reproduce this and I have the following behaviour:

The code that prints these is:
onMessageWasSent(message) {
      console.log('mylog app with stringify', JSON.stringify(message))
      console.log('mylog app without stringify', message)
      console.log('mylog access message.data.file', message.data.file)
}

I am not 100% certain, but if I was to guess, it is because this "behaviour" is related to how JSON.stringify works with some objects. It does not serialize few objects instances. Here, our File() object is not serialized (ref), but as you can see above, the object can actually still be referred to by the property  message.data.file, so you should be able to access it like we see in the 3rd console log output.

I tried to reproduce this and I have the following behaviour:

The code that prints these is:
onMessageWasSent(message) {
      console.log('mylog app with stringify', JSON.stringify(message))
      console.log('mylog app without stringify', message)
      console.log('mylog access message.data.file', message.data.file)
}

I am not 100% certain, but if I was to guess, it is because this "behaviour" is related to how JSON.stringify works with some objects. It does not serialize few objects instances. Here, our File() object is not serialized (ref), but as you can see above, the object can actually still be referred to by the property  message.data.file, so you should be able to access it like we see in the 3rd console log output.

@3sne Thank you for the explanation!


Feature request: Rephrase

This is so cool! Is it possible to add "rephrase" option? I write something and invoke the extension on the block to rephrase it and print it in the child block?

@c3founder this is done


PageUP and PageDown don't do what you would think they would do

Can we please have those buttons activated.
Thanks

I just noticed your issue! datascroller hasn't been the most active development project lately. I'll see if I can get the guys together for one last PR.


[Feature][UI Next]Add PIGEON Task

Purpose of the pull request
Please refer to the main issue #7928.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #8462 (485fe33) into dev (df6eef8) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #8462      +/-   ##
============================================
- Coverage     45.35%   45.35%   -0.01%
+ Complexity     4028     4026       -2
============================================
  Files           686      686
  Lines         26702    26709       +7
  Branches       2867     2868       +1
============================================
+ Hits          12112    12114       +2
- Misses        13448    13450       +2
- Partials       1142     1145       +3

Impacted Files
Coverage Δ

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.70% <0.00%> (-2.82%)
:arrow_down:

.../apache/dolphinscheduler/common/utils/OSUtils.java
17.21% <0.00%> (+3.32%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df6eef8...485fe33. Read the comment docs.


Unable to use CDATA wrap on urls when using createSitemap

Hi, great module!  I ran into this issue where
      urls.unshift({
        url: `https://www.${site}.com`,
        changefreq: 'hourly',
        priority: 1.0
      });

      const siteMapByWeek = sm.createSitemap({
        urls
      });

siteMapByWeek.toXML(function handleXML(err, xml) {});

throws an error:
{ [NoURLProtocolError: Protocol is required] name: 'NoURLProtocolError', message: 'Protocol is required' }
vs doing this with buildSitemapIndex where it doesn't throw that error.
Thanks!

Hey, thanks for report & patch. Should be fixed now.


[Feature Request] Dedicated Server for netplay

Netplay should offer the ability to be hosted by a headless server daemon. By default the game should be configurable by one of the clients, possibly the first to connect. In future, options in a server ini file should allow the host to configure what game modes are allowed, or if the host wants to set up a server that only runs specific settings.
A restrictive config file could have these example options, with blank values being the default values:
[Net.Server]
DisallowMaps=ravine,carpark
DisallowSimulants=meatsim,darksim
DisallowWeapons=farsight

etc
A server that only plays complex, four players, only pistols, no simulants, default limits(forcing a map disables customization, and with no option set for simulants, doesn't enable them per default):
[Net.Server]
Map=complex
WeaponGroup=pistols

While it's not too difficult to make a headless server by just disabling audio/video, making a usable dedicated would involve adding a voting system and figuring out what to do with the dedicated server's local player.

i think maybe as a first step after figuring out how to eliminate the server's player would to just have fixed settings and skip the game setup entirely

Also keep in mind that there's currently no form of lag compensation, which gives the host a massive advantage. Lag comp should be added someday, but for now, a dedicated server might help mitigate this a little bit (although it would still advantage those with lower pings)


Most blocks in extension don't have help

Describe the bug
Most blocks in extension don't have help
Steps to reproduce the behavior

Navigate to https://arcade.makecode.com/beta#editor
Click "More..." -> "Extensions" -> choose any extension to add
Click the toolbox and right click on the block to check

Expect behavior
Blocks in extension toolbox should have help
Actual behavior
Most block in extension don't have help
(such as: "controller", "storyboard", "animation", "corgio", "darts", "palette".etc)

Additional context

OS: Windows(rs6)
arcade version: 0.14.25
Microsoft MakeCode version: 5.28.6

It's up to the extension author to write documentation for their extension. We have a new policy of requiring official extensions to have documentation going forward


Classname prop

Would it not be nice to be able to pass down classNames on components so you don't have to wrap the components with another block just to put a className on it?
For example:
<Toolbar className="Nav" color="white"></Toolbar>

instead of:
<nav className="Nav">
  <Toolbar color="white"></Toolbar>
</nav>

I would be willing to submit a PR to address this if this is a legitimate issue and not just how you explicitly designed the components.
Thanks!
Andy

Hey Andy. That tends to be a common pattern but ultimately breaks style
purity of rebass components. If a user can add any style they want to a
component it's impossible for the component author to be able to change the
component knowing they won't break anything. Wrapping components may seems
like your adding superfluous divs but it's actually making your application
much more robust.
On Sat, Jan 16, 2016 at 04:28 Andy Kay<EMAIL_ADDRESS>wrote:

Would it not be nice to be able to pass down classNames on components so
you don't have to wrap the components with another block just to put a
className on it?
For example:

instead of:

I would be willing to submit a PR to address this if this is a legitimate
issue and not just how you explicitly designed the components
Thanks!
Andy
—
Reply to this email directly or view it on GitHub
https://github.com/jxnblk/rebass/issues/30.

Thanks that makes sense. However, say I wanted to give the Toolbar component a white background how would I go about doing that without overriding the css?

You can pass color: "white" in as a prop: https://github.com/jxnblk/rebass/blob/master/src/Toolbar.jsx#L19

Sorry one last question: won't the text color still be white though?
https://github.com/jxnblk/rebass/blob/master/src/Toolbar.jsx#L18

Yep. I'd either create a PR to customize the bg-color and the text color independently or create your own toolbar component seeing as it's so simple :)

Ok thanks for your help Chris!

I generally agree with @chrislloyd on this one. Passing className as props breaks the encapsulation of styles in the component. That said, future versions of this repo should make the components more flexible, especially in regards to colors and theming.


Kubernetes 1.8 (Custom Resource) support?

Hi,
I've just tried to spin up the etcd-operator on kubernetes 1.8. I did it with the stable helm chart, but should not matter I think. I got the logs like:
time="2017-12-08T15:43:20Z" level=error msg="initialization failed: fail to create TPR: the server could not find the requested resource" pkg=controller
This is I believe due to kubernetes 1.8 totally deprecated the TPR resource in favor of CRs.
Is there any plan to support the custom resources with the etcd-operator?

etcd operator has already supported CRD.
But in helm the etcd operator version is very old.
This is helm issue? Please report it to helm. If you want to use newer versions of etcd operator please follow our README.

Closing this since it is more a helm issue.

Oops! Sorry about that.


[javadoc-only] ISPN-7820 Document store-by-reference effects in functional commands

https://issues.jboss.org/browse/ISPN-7820

Integrated into master, thanks @rvansa


feat(headless): add did-you-mean option to disable automatic query correction

https://coveord.atlassian.net/browse/KIT-2618
Now, by dispatching the disableAutomaticQueryCorrection action, the controller will no longer dispatch another search action with the logDidYouMeanClick analytics.

Like Benjamin said, this is not what the ticket is about.
Feel free to ping me on slack we can discuss live what we actually want to do for this one.


image pipeline: remove duplicit entry

IMO the line below the deleted one says the exact same thing, so I suggest deleting this one.

/remove-lifecycle rotten

/remove-lifecycle stale


Change all scripts to use here documents for usage text

This really only describes very old scripts that may eventually be deleted. Closing.


[Events section- navbar] - Adjusted improper redirection in navbar of events tab [GSSOC'23]

Description
This PR fixes the improper redirection of Home, about and contact links in the navigation bar of events tab.I also fixed the improper highlighting of active navbar tabs.
Notes for Reviewers
Please check out the changes I made. Now the Home, About, Contact navigation bar links are redirecting to the respective pages properly. Also check the screenshot attached for better understanding.

Thanks @VyjayantiN , we will review and merge it sooN!


#1125: Update apiVersion for Maven Plugin for Azure Spring Cloud

Codecov Report

Merging #1126 into develop will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #1126      +/-   ##
=============================================
- Coverage      35.51%   35.43%   -0.08%
  Complexity       540      540
=============================================
  Files            103      103
  Lines           4590     4600      +10
  Branches         708      709       +1
=============================================
  Hits            1630     1630
- Misses          2814     2824      +10
  Partials         146      146

Impacted Files
Coverage Δ
Complexity Δ

...a/com/microsoft/azure/maven/spring/ConfigMojo.java
77.77% <ø> (ø)
44.00 <0.00> (ø)

...a/com/microsoft/azure/maven/spring/DeployMojo.java
6.87% <ø> (ø)
5.00 <0.00> (ø)

...zure/maven/spring/spring/AbstractSpringClient.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...oft/azure/maven/spring/spring/SpringAppClient.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...re/maven/spring/spring/SpringDeploymentClient.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...azure/maven/spring/spring/SpringServiceClient.java
55.17% <ø> (ø)
6.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f14e61...5e2e275. Read the comment docs.


Calling next() on a shutdown client completion queue block indefinitely

What version of gRPC and what language are you using?
1.17.0
What operating system (Linux, Windows, …) and version?
Windows
What runtime / compiler are you using (e.g. python version or version of gcc)
C++ / Visual studio 2017
What did you do?
I have an asynchronous client with a bidirectional stream to a server.  The client close the connection to the server by calling:
streamer->WritesDone(tag(tagDone));
The server is notified of that and close itself (shutdown the completion queue and the application is stopped). If before I try to call stream.Finish(grpc::Status(), tag(tagFinish)); on the server side, it crashes. So I assume that I cannot call this function when the client has already notified the server of the termination of the communication.
The call to next on the completion queue of the client returns the fact that the WritesDone operation is done. I thus shutdown the client completion queue and call next() on it, expecting it to return false, but it stays stuck on wait. If instead of calling next(), I close the program, I have a warning on the console:
E1207 11:17:53.906000000 19048 backup_poller.cc:110] run_poller: {"created":"@1544177873.906000000","description":"Shutting down timer system","file":"C:\dev\conan_c\gRPC\1.17.0\AI\extern\build\78cd7b38ad8b4d21bb87826d9e499814103125be\gRPC_v1.17.0\src\core\lib\iomgr\timer_generic.cc","file_line":704}
Why ? What is wrong in my code ?
Here is my code:
`
auto streamer = m_stub->PrepareAsyncgetEvent(&context, &cq);
auto status = grpc::Status();
streamer->Finish(&status, tag(tagFinish));
streamer->StartCall(tag(tagConnection));
bool ok;
void* tagReceived;
while(cq.Next(&tagReceived, &ok)) {
    if(ok) {
        switch(detag(tagReceived)) {
            case tagConnection:
                streamer->Read(&event, tag(tagRead));
                break;
            case tagRead:
                request.set_id(event.id());
                streamer->Write(request, tag(tagWrite));
                break;
            case tagWrite:
                if(event.id() > 10) {
                    streamer->WritesDone(tag(tagDone));
                } else {
                    streamer->Read(&event, tag(tagRead));
                }
                break;
            case tagDone:
                cq.Shutdown();
                //return; //Create a warning on the console
                break;
            case tagFinish:
                cq.Shutdown();
                break;
            default:
                abort();
        }
    }
}

`

You are calling Finish() too early. Please refer to the documentation here for the correct order for calling it.
https://github.com/grpc/grpc/blob/5e50a89502a22f6c10f59259151bd0d0362c4b55/include/grpcpp/impl/codegen/async_stream.h#L79


Connectivity tests incorrectly assume that the DNS resolver is in the kube-system namespace

Is there an existing issue for this?

[x] I have searched the existing issues

Version
equal or higher than v1.16.0 and lower than v1.17.0
What happened?
All connectivity tests that require resolving DNS fail if the kube-dns pods (i.e. coredns) are not in the kube-dns namespace.
How can we reproduce the issue?

Install the DNS resolver to a namespace other than kube-system. For example, install coredns to a networking or coredns namespace.
Install Cilium. Config values don't really matter as long as Cilium works properly.
Run cilium -n <cilium namespace> connectivity test. Any test (such as --test to-entities-world) will fail as it will be unable to resolve the one.one.one.one IP address.

Cilium Version
cilium-cli: v0.16.19 compiled with go1.23.1 on linux/amd64
cilium image (default): v1.16.2
cilium image (stable): v1.16.3
cilium image (running): 1.16.3
Kernel Version
Linux client-6db7b75479-rhz7c 6.6.54-talos #1 SMP Mon Oct  7 18:53:44 UTC 2024 x86_64 Linux
Kubernetes Version
Client Version: v1.31.2
Kustomize Version: v5.4.2
Server Version: v1.31.1
Regression
This was introduced in https://github.com/cilium/cilium/commit/40da4c6bcec6281386c2c97f42415305854274ed
Sysdump
No response
Relevant log output
🐛 Executing command [curl -w %{local_ip}:%{local_port} -> %{remote_ip}:%{remote_port} = %{response_code} --silent --fail --show-error --output /dev/null --connect-timeout 2 --max-time 10 -H Host: one.one.one.one --retry 3 --retry-all-errors --retry-delay 3 http://one.one.one.one.:80]
.  ❌ command "curl -w %{local_ip}:%{local_port} -> %{remote_ip}:%{remote_port} = %{response_code} --silent --fail --show-error --output /dev/null --connect-timeout 2 --max-time 10 -H Host: one.one.one.one --retry 3 --retry-all-errors --retry-delay 3 http://one.one.one.one.:80" failed: error with exec request (pod=cilium-test-1/client-6db7b75479-rhz7c, container=client): command terminated with exit code 28
  ℹ  curl stdout:
  :0 -> :0 = 000
  ℹ  curl stderr:
  curl: (28) Resolving timed out after 2001 milliseconds
curl: (28) Resolving timed out after 2001 milliseconds
curl: (28) Resolving timed out after 2001 milliseconds
curl: (28) Resolving timed out after 2001 milliseconds

  🐛 Expecting egress drops for Action https-to-one.one.one.one.-0: Drop-exit(28)

Anything else?
The offending logic is here. The endpoint selector needs to ignore the namespace, and just match the app name label.
Cilium Users Document

[ ] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[x] I agree to follow this project's Code of Conduct

Thank you for opening the issue! I think that's a reasonable enhancement. Would you want to open a PR with the suggested change?


Strange behaviour of the component, not sure if it is an error

The times configured to the entity in the .yaml file are not shown correctly in the developer tools of HA.
Version of the schedule_state component
0.19.4
Version of HA
Core 2024.5.4
Supervisor 2024.05.1
Operating System 12.3
Frontend 20240501.1
Configuration

platform: schedule_state
name: p1_mo
default_state: "aus"
events:

start: "10:40"
end: "10:41"
state: "an"
icon: mdi:fountain

no logs, even when I enable debug logging for the component
Describe the bug
I set the configuration like above and reload the configuration. Than I check the state of the entity in the developer tools.
Before the start time has arrived it looks like this:
When the time changes to 10:40 it looks like this:

When the time changes to 10:41 it looks like this:

So the state is correct but the times are messed up.
I would have expected that the start time is always 10:40 and the end time is always 10:41 even right after the reload of the configuration. I'd like to have it as expected because I need the correct times for other purposes within HA.
Debug log
no logs, even when I enable debug logging for the component

It seems to be behaving exactly as intended. start/end attributes reflect the start and end times of the current state.
In example 1, it is showing the default (currently active) state "aus" until 10:40
In example 2, it is showing the currently active state "an" from 10:40 to 10:41
In example 3, it is again showing the default state "aus" from 10:41 to 10:40 of the next day. This one might be a bit confusing, it is looking forward to the next state transition on the next day if the state at midnight (0:00) matches the state at 0:01. See README for caveats.

Ok. Thanks for the explanation. Then I understand the philosophy behind.
I need to have the configured times for other purposes. Is it possible to add the configured times also as attributes? Should I than open a feature request?

Yes, please submit a feature request. - aneeshSent from my iPhonePlease excuse any typos or logical fallacies. On May 27, 2024, at 01:48, tj551955 @.***> wrote:
Ok. Thanks for the explanation. Then I understand the philosophy behind.
I need to have the configured times for other purposes. Is it possible to add the configured times also as attributes? Should I than open a feature request?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>


Warning: pointer is missing a nullability type specifier Flurry.h

If you are using nullability specifiers you need to adopt them on all methods and properties (either one by one or with NS_ASSUME_NONNULL macros)

Seems to be fixed in one of the releases


Fix VRTheWorld terrain geometry with ImageBitmap

This fixes https://github.com/AnalyticalGraphicsInc/cesium/issues/7697. If you go to the terrain Sandcastle in master and try the VRTheWorldTerrain, you'll see incorrect terrain geometry.
It's because VRTheWorldTerrainProvider constructs geometry from a heightmap by reading the pixels! The fix is just to make sure flipY: false in the requestTileGeometry function.
@lilleyse

Thanks for the pull request @OmarShehata!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Thanks @OmarShehata.

@mramato I've gone back to our conversations in https://github.com/AnalyticalGraphicsInc/cesium/pull/7579 and it looks like I never explicitly mentioned this new default being true. It felt consistent with the rest of the codebase since any texture upload was flipped by default, but this does mean anyone who was using fetchImage() and doing anything with the pixels or using the image object outside of Cesium will now have it flipped with this release.
We can change the default to flipY: false, and then just make sure to flip all imagery in our codebase. The only problem is that if any user is using fetchImage() and then drawing that image in Cesium, it's going to be upside down by default.  This is in our control, but not if the user is fetching the image and then passing it themselves, but I don't know how common that is.
The original problem that complicated this is that textures are all flipped by default. If imagery was flipped in the shader instead this would be simpler. I remember we tried to do that but ran into issues getting it to work correctly with the projection.


Update VS Docker Tools page

Add link explaining how to modify an existing Visual Studio installation to add the .NET Core workload

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@lisaguthrie  Nice tip,, thanks!


CreateDrop database multiple times

Hi,
I want to use SQLiteCodefirst to create my unist test database to test my EF6 domain.
Problem is that OnModelCreating is only called once per app domain, and you cant disable model caching.
Is there a way to use SQLLite code first for setting up the database for each test?

Hello
What means "each test"?
What exactly you want test?
I've also a bunch of unit tests (NUnit) which are using SQLite as a database.
I'm using it with the DropCreateDatabaseAlways Initializer. So there is a there is a database per TestFixture.
If you want to delete the database file check the "DeleteDatabase" method here:
https://github.com/msallin/SQLiteCodeFirst/blob/master/SQLite.CodeFirst/DbInitializers/SqliteDropCreateDatabaseWhenModelChanges.cs
Here is how you could force that the model is not cached:
http://stackoverflow.com/questions/13493199/onmodelcreating-forcing-new-creation
Greetings Marc

Close due to inactivity.
Please reopen if the issue still exists and provide additional information.


add isVerified field to account properties

For some use cases, we need to know whether an account is verified or not. So adding isVerified field to the account properties would be useful.

good!

Thanks for lightning fast merging!


Cross compile program get stuck at creating ClientReaderWriter

I already can build(locally) and run this sample on my Debian PC and my raspberry pi.
Weird things happens when I trying to cross compile this sample on my Debian PC with arm-linux-gnueabihf-g++, I have modified LDFLAGS to make it compile with specific arm grpc lib(which I copied from raspberry pi), build successfully and I run it on raspberry pi. Everything runs good until program get here:
std::shared_ptr<ClientReaderWriter<AssistRequest, AssistResponse>>
        stream(std::move(assistant->Assist(&context)));

It will stuck at here forever because assistant->Assist(&context) will never return.
Then I tried to copy the whole modified project with specific arm grpc lib to raspberry pi and build it on raspberry pi locally, it works well again...
Any comments and suggestions will be appreciated, thanks a lot

Did more investigation, cross  compiled executable blocked at /usr/local/include/grpcpp/impl/codegen/sync_stream.h Line:605, after calling CompletionQueue constructor.
Meanwhile local build executable works well.

Problem fixed by re-compile gRPC to static lib with cross compiler. I will close this issue.


Copy and paste shortcuts don't work in Visual Shader editor

Godot version:

3.2.3 rc3
Issue description:

When in Visual Script editor, you can't use Copy and Paste shortcuts. You need to select them from the Edit menu. All other shortcuts seem to work (including Cut and the unlisted Duplicate shortcut...)

Can I work on this issue?

Yeah, no need to ask btw.

Is title of this issue correct?

Sorry it wasn't, it's about Visual Script not Visual Shader.

I have not looked into this in detail but it sounds very much like it is related to #39039 and the issues that it mentions.
The ctrl c and ctrl V commands are jousting being 'stolen' by other editor.
The way shortcuts are handled in the editor and GUI in general needs a big rethink - something I have been pondering on for quite some time but have no solution yet.

Ok, actually the problem is pretty simple.
Graph edit has it's own keybindings set internally which cannot be changed.
https://github.com/godotengine/godot/blob/6f4384f2063dc892b751eda750e120d72119644a/scene/gui/graph_edit.cpp#L1036-L1056
Because this happens on _gui_input() and the event is marked as handled, the event does not propagate any more. As you can see, GraphEdit emit's signals showing that dupe, copy, paste and delete was requested. However, in VisualScriptEditor this signal is never connected to - only duplicate and delete are.
https://github.com/godotengine/godot/blob/6f4384f2063dc892b751eda750e120d72119644a/modules/visual_script/visual_script_editor.cpp#L4767-L4781
So to fix the issue the signals just need to be connected. It is very weird to have these baked-in shortcuts, and they cause many issue like this I think.


JSON output for removing blank lines is wrong

Rustfmt version: rustfmt 2.0.0-rc.2-nightly (e9b039ea 2020-06-03)
If Rustfmt decides to remove a blank line, the JSON output says that actually nothing needs to change. Trivial repro:
 ~ cat foo.rs
fn foo() {

    let i = 0;
}
 ~ rustfmt --emit json foo.rs | jq
[
  {
    "name": "/Users/me/foo.rs",
    "mismatches": [
      {
        "original_begin_line": 2,
        "original_end_line": 2,
        "expected_begin_line": 2,
        "expected_end_line": 2,
        "original": "",
        "expected": ""
      }
    ]
  }
]

It seems fine at removing newlines in other cases:
 ~ cat foo.rs
fn foo() {
    let i =
    0;
}
 ~ rustfmt --emit json foo.rs | jq
[
  {
    "name": "/Users/timh/foo.rs",
    "mismatches": [
      {
        "original_begin_line": 2,
        "original_end_line": 3,
        "expected_begin_line": 2,
        "expected_end_line": 2,
        "original": "    let i =\n    0;",
        "expected": "    let i = 0;"
      }
    ]
  }
]

So I think the output should be something like this:
[
  {
    "name": "/Users/me/foo.rs",
    "mismatches": [
      {
        "original_begin_line": 2,
        "original_end_line": 3,
        "expected_begin_line": 2,
        "expected_end_line": 2,
        "original": "\n",
        "expected": ""
      }
    ]
  }
]

Here's another case that causes issues. It seems like there should be newlines that get stripped.
 ~ cat foo.rs
mod a;
mod c;
mod b;
mod d;
 ~ rustfmt --emit json foo.rs | jq
[
  {
    "name": "/Users/timh/foo.rs",
    "mismatches": [
      {
        "original_begin_line": 2,
        "original_end_line": 2,
        "expected_begin_line": 2,
        "expected_end_line": 2,
        "original": "mod c;",
        "expected": ""
      },
      {
        "original_begin_line": 4,
        "original_end_line": 4,
        "expected_begin_line": 3,
        "expected_end_line": 3,
        "original": "",
        "expected": "mod c;"
      }
    ]
  }
]

I think it's trying to reformat it alphabetically, like
mod a;
mod b;
mod c;
mod d;

But what you actually get is
mod a;
mod b;
mod c;mod d;

I think both instances of "mod c;" should actually be "mod c;\n".

Thanks for the report @Timmmm, and for giving the rustfmt 2.0-rc a test drive!

I think it's trying to reformat it alphabetically, like

Yup, the default behavior is to reorder mods alphabetically, and this can controlled by the reorder_modules configuration option.

If Rustfmt decides to remove a blank line, the JSON output says that actually nothing needs to change.

Not exactly. The fact that there's mismatches in the output is indicative that something does need to be changed, it's just ambiguous what those changes are. I feel the question is really about how newline changes should be represented in the output, whether implicit/assumed given the line numbers, or explicitly.
It's clearly not explicit right now, and the scenarios you've shared here raise some good points about why IMO something should change. In addition to the removal of newline chars, it'd also be tricky to know from the json output when a newline is inserted, especially since rustfmt could be emitting different newline styles depending on the config.
The json emit mode (which is also used with --message-format json from cargo fmt) is still unstable, so we'll want to get this sorted before stabilizing the json emit mode. Within the rustfmt maintainer team we've got a lot of higher priority items on our plates right now so it'd probably be a while before we can get around to this.
If anyone's interested and willing to try updating this that would be fantastic and we'd be happy to offer assistance!
The mismatch specification logic for the json emit mode can be found here:
https://github.com/rust-lang/rustfmt/blob/cf1f0cf10f8ecafda9ceda622c4a1d2b95636cad/src/emitter/json.rs#L57-L102
It may also be helpful to cross reference the function that generates the visual output found with the --check mode.

Thanks for the hint! Turns out the fix was quite easy. :-)


Unexpected error when checking control 1.19 and "-f" option includes two or more regions

I'm having the following issue checking controls like 1.19 when -f option includes two or more regions.
I think that -f option should only admit one specific region and not a combination, am I right?
In that case, when Prowler is validating input options, if -f contains more than one region it should stop, don't you?
Execution log:
  _ __  _ __ _____      _| | ___ _ __
 | '_ \| '__/ _ \ \ /\ / / |/ _ \ '__|
 | |_) | | | (_) \ V  V /| |  __/ |
 | .__/|_|  \___/ \_/\_/ |_|\___|_|v2.4.0-07042021
 |_| the handy cloud security tool

 Date: Tue Jun  1 08:46:00 CEST 2021

 Colors code for results:
 INFO (Information), PASS (Recommended value),  WARNING (Ignored by whitelist),  FAIL (Fix required),  Not Scored

 This report is being generated using credentials below:

 AWS-CLI Profile: [default] AWS API Region: [eu-west-1] AWS Filter Region: [us-east-1,eu-west-1]
 AWS Account: [*************] UserId: [*************]
 Caller Identity ARN: [arn:aws:iam::*************:user/*************]

 0.1 Generating AWS IAM Credential Report...

 1.19 [check119] Ensure IAM instance roles are used for AWS resource access from instances (Not Scored)

Could not connect to the endpoint URL: "https://ec2.An.amazonaws.com/"
       INFO! An: No EC2 instances found

Could not connect to the endpoint URL: "https://ec2.error.amazonaws.com/"
       INFO! error: No EC2 instances found

Could not connect to the endpoint URL: "https://ec2.occurred.amazonaws.com/"
       INFO! occurred: No EC2 instances found

Provided region_name '(InvalidParameterValue)' doesn't match a supported format.
       INFO! (InvalidParameterValue): No EC2 instances found

Could not connect to the endpoint URL: "https://ec2.when.amazonaws.com/"
       INFO! when: No EC2 instances found

Could not connect to the endpoint URL: "https://ec2.calling.amazonaws.com/"
       INFO! calling: No EC2 instances found

Could not connect to the endpoint URL: "https://ec2.the.amazonaws.com/"
       INFO! the: No EC2 instances found

Could not connect to the endpoint URL: "https://ec2.DescribeRegions.amazonaws.com/"
       INFO! DescribeRegions: No EC2 instances found

Provided region_name 'operation:' doesn't match a supported format.
       INFO! operation:: No EC2 instances found

Could not connect to the endpoint URL: "https://ec2.Invalid.amazonaws.com/"
       INFO! Invalid: No EC2 instances found

Provided region_name 'region:' doesn't match a supported format.
       INFO! region:: No EC2 instances found

Provided region_name '[us-east-1,eu-west-1]' doesn't match a supported format.
       INFO! [us-east-1,eu-west-1]: No EC2 instances found

Thanks!

Hi @jfagoagas, how are you using the option? -f works like this -f 'us-east-1 eu-west-1' it is not comma separated as in other flags.

Hi @toniblyx, I think that this is the problem, I am using -f us-east-1,eu-west-1.
Maybe we can update Prowler usage guide because it shows this info about -f parameter:
-f <filterregion>   specify an AWS region to run checks against
                            (i.e.: us-west-1)

agreed! That info is correct but not comprehensive. Gonna add it now in branch 2.5

Thanks!!

done

watch out with 2.5 that I'm changing/playing with new outputs and might be not largely tested


Website Reloads Upon Trying to Start Gane

For the past couple of days, whenever I try to log on to SM64JS, after submitting my name and desired game level, the website reloads. The only work around I could find for this was to open another SM64JS tab while the previous one was still running, but that doesn't work half of the time. If you and your team could try to find a fix for this bug, that would be great. Check the attachment to see what I'm talking about.
https://user-images.githubusercontent.com/106826670/171884480-8b086c32-ded0-4241-b538-b15e47152352.mp4

Found the issue and am currently deploying the fix for it to the site, hang in there.


Is it unsupervised learning? Why is the label needed?

I can't understand why the label is needed.

I think the train data does not contain anomalies and the test data contains anomalies. So, I process my data as follow, the train data is the normal historical data while the test data contains man-made anomalies,  but the result is disappointing. What can I do?

Is it unsupervised learning?
Yes. The network in this repo is trained as a non-supervised learning method. Labels are not used when training.
Why is the label needed?
Labels are needed to evaluate model performance. If there is no label, how can we evaluate the accuracy of the model?
I think the train data does not contain anomalies and the test data contains anomalies. So, I process my data as follow, the train data is the normal historical data while the test data contains man-made anomalies, but the result is disappointing. What can I do?
What does your data look like? Is the data periodic? I think the method seems hard to detect anomalies of aperiodic data.

As the picture above, the data is periodic. I do not know which data should be labeled 1 and which data should be labeled 0 as my train data has no anomaly while the test data contains anomalies, and they are collected respectively in different situation as follow:

Wow, your data looks really cool! I never tried 16-dimensional data simply because I don't have one.
I cannot find any anomalous points in your data. Is this figure test dataset which contains anomalous points?

As the picture above, the data is periodic. I do not know which data should be labeled 1 and which data should be labeled 0 as my train data has no anomaly while the test data contains anomalies, and they are collected respectively in different situation as follow:

@chickenbestlover

Can it be real-time monitoring?


Improve documentation for getting started

The docs make no mention of the required Auto-Doc-Input tag in the readme. Important when onboarding new users.  closes #549

Hi @devSarry, the docs don’t mention the placeholder inserted because the action requires adding a h2 header to your README.md instead.
Example:
Add any of the supported headings in any location of your README.md
…

## Inputs
— A placeholder would be added here automatically —

## Outputs
— A placeholder would be added here automatically —

Let me know if this clarifies this for you.


[Finish #121953023] Hide admin role from the UI

What this PR does
Hides the admin role from the UI.
Shows users' usernames alongside the avatar instead of their roles if they are not admins.
Relevant Pivotal Tracker stories
Hide admin role from the UI

Coverage decreased (-0.07%) to 83.393% when pulling bfe1e78767aa17056598a98a0a53d7035070c7e6 on chore/remove-admin-role-from-ui into f2cb897f85ddba6f02d81fe701cb3137d69d1a51 on develop.


Adding a single kernel: Mean2DSphere

Hi Stephane @StRigaud ,
here comes my first kernel 🥳
It wasn't so complicated in fact. :-)
I wouldn't add more kernels for now, because I think the changes you mentioned make sense - especially the hash-map thingy for handing over parameters to the Execute function. Let me know if you need help with this.
Let me know what you think about my first kernel and have a great weekend!
Cheers,
Robert

Oh and one more comment: I changed the git module definition to https: instead of git: protocol because my git-client (SmartGit) throws weird error messages. I hope it doesn't disturb your git.


VM: Create bind mount of config drive and instance disk devices for exporting via 9p and virtiofsd

This works around the lack of read-only support in virtio-fs and provides an additional layer of protection for 9p shares.

@stgraber ready for review

Testsuite passed

@stgraber marking this as ready for review now as it passes the local jenkins tests for dir and zfs (it needed a couple of fixes to ordering when the virtiofsd process was started and stopped for the config drive so as to not prevent root volume unmount). It may even help reduce the frequency that the restart unmount errors occur.


fix builtin export - not duplicate a new env, if exists

if users sends: export var
the result is:
the entire list of env variables, and:
var= ""

However,in the actual version, if users sends again var, but with value, like: export var=123
The actual result is:
the entire list of env variables, and:
var= ""
var= "123"

Bash do not duplicate env var with same key.

this issue was done at #261


Update Admin App for Section, Personal, Hierarchy Flag

Title of ticket:
Description
The purpose of this task is to update the Admin module for the new flags added for sections and division - section hierarchy for the changes @abin-aot has made for #4292
Dependencies
Are there any dependencies?
DOD

[ ]  Update the CRUD operations for Divisions Module to capture new 3 flags - issection, isspecifictopersonal and parentid
[ ] Update REST API endpoints
[ ]  Update UX - react components - Search, Add, Edit
[ ]
[ ]

Thanks, @abin-aot

created a separate ticket for the above issue.
https://app.zenhub.com/workspaces/foi-flow-607f0ab6ae54b700111dc733/issues/gh/bcgov/foi-flow/4556

Fixed! Pending merge to main/test from dev
On Tue, Oct 3, 2023 at 12:29 PM Nimya John @.***> wrote:

created a separate ticket for the above issue.
https://app.zenhub.com/workspaces/foi-flow-607f0ab6ae54b700111dc733/issues/gh/bcgov/foi-flow/4556
—
Reply to this email directly, view it on GitHub
https://github.com/bcgov/foi-flow/issues/4427#issuecomment-1745592088,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APK4R5JFWVIJAKVMS5PRMF3X5RRRVAVCNFSM6AAAAAA4WYGHPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBVGU4TEMBYHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Aman-Hundal Please let me know once it is pushed to test.

@Aman-Hundal informed there is flag issue on Admin app. Once its fixed I can test it again

Flags in the admin panel have been adjusted. good to test!
On Thu, Oct 5, 2023 at 11:24 AM Nimya John @.***> wrote:

@Aman-Hundal https://github.com/Aman-Hundal informed there is flag
issue on Admin app. Once its fixed I can test it again
—
Reply to this email directly, view it on GitHub
https://github.com/bcgov/foi-flow/issues/4427#issuecomment-1749429779,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APK4R5OUJAXV4PUQDN66HKDX533PPAVCNFSM6AAAAAA4WYGHPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZGQZDSNZXHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hey @abin-aot a note for you and the team -> we will need to make sure the sections field in the programareadivisions table must be false for all divisions besides mcd/cfd (if a none value or null value exists, divisional tracking will break)

created a ticket for unable to delete a section from admin dashboard. https://app.zenhub.com/workspaces/foi-flow-607f0ab6ae54b700111dc733/issues/gh/bcgov/foi-flow/4568

Ticket for above completed and pending review / merge to main
On Fri, Oct 6, 2023 at 11:24 AM Nimya John @.***> wrote:

created a ticket for unable to delete a section from admin dashboard.
https://app.zenhub.com/workspaces/foi-flow-607f0ab6ae54b700111dc733/issues/gh/bcgov/foi-flow/4568
—
Reply to this email directly, view it on GitHub
https://github.com/bcgov/foi-flow/issues/4427#issuecomment-1751224195,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APK4R5O3C5NMH6ZKFNCHEPTX6BEG3AVCNFSM6AAAAAA4WYGHPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRGIZDIMJZGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

working as expected, so closing it


CSVNLinesSequenceRecordReader - Ensure nLinesPerSequence can be confi…

…gured via Configuration object

Refer to this link for build results (access rights to CI server needed):
/job/datavec_PR/14/


attempt to fix eaf importation failing on python 3.5

Clues:

the scripts fails on different annotations every time (not determistic)
same version of pympi across all tested versions of python


Remove java 20

This version is not really needed and adds bloat. I would make it merge into to the test branch. Love to see feedback as my first contribution to this brilliant project.
Have a Great day

Thanks,
Keep up the great work
P.S I'm a subscriber on both your yt channels


Moved version forward manually

Codecov Report

Merging #2308 into develop will decrease coverage by 2.33%.
The diff coverage is 58.91%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291111c...85ff164. Read the comment docs.


Azure AD - update the modal text for endpoint update

Needed for v2.6.11 and v2.7.0.
We need to change the text that warns users about the need to update their Azure apps to include a set of permissions. We need to change the permission required. It should be Directory.Read.All now instead of the current Group.Read.All and User.Read.All.

Looks good with above comments and closing this card.


Flutter doctor --> no conneted devices and Android studio--> new flutter project -->flutter sdk path is not given

Steps to Reproduce

flutter doctor --> cmd

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, v1.17.5, on Microsoft Windows [Version 10.0.18363.900], locale de-DE)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
[√] Android Studio (version 4.0)
[!] Connected device

! Doctor found issues in 1 category.

My problem is to solve the Point connected device.
I tryed a lot ,but nothing worked.
I hope anyone can help me:)

1.1 My next issue is. When I want to start my first flutter projekt in Android Studio, I get a error message after the steps in brackets .( File--> new--> new flutter Project--> Flutter Application--> next)
2.1 In the window "configure the new flutter aplication" I get the error message  "Flutter SDK path not given."
I tryed a lot but Nothing worked.
Hopfully anyone can help me;)
Logs

Hi @Senni765
You need to start emulator or connect physical  then flutter doctor -v, it should show connected devices or you can also execute flutter devices to see connected devices
For Android Studio, when you selected new flutter option,  in the second option click three dots to and locate your Flutter SDK on your computer
Hope this helps
Thank you

Hi @TahaTesser ,
everything worked great.
Thank you for your help:)


[tests-only][full-ci] Restructure the steps implementation for group delete to use graph API endpoint

Description
In this PR, provision API is removed for group deletion
Related Issue

Part of https://github.com/owncloud/ocis/issues/6998

How Has This Been Tested?

locally
ci

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[x] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[x] Acceptance tests added
[ ] Documentation ticket raised:

@nabim777  Can you backport this PR to stable 5.0?


chore: add missing aliases for recently renamed lemmas

From #9618, #10525 and #10614.

Thanks! :tada:
bors merge


Fix a false negative for Layout/HashAlignment

Resolves https://github.com/testdouble/standard/pull/300
This PR fixes a false negative for Layout/HashAlignment when setting EnforcedStyle: with_fixed_indentation of Layout/ArgumentAlignment and using misaligned keyword arguments.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis @koic I believe this has caused a subtle regression:
undefined method `loc' for nil:NilClass
/usr/local/var/rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/gems/rubocop-1.16.1/lib/rubocop/cop/layout/hash_alignment.rb:221:in `autocorrect_incompatible_with_other_cops?'
/usr/local/var/rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/gems/rubocop-1.16.1/lib/rubocop/cop/layout/hash_alignment.rb:206:in `on_hash'

We started getting this when Dependabot tried to bump us up to 1.16.1. The code it failed on isn't clear/consistent, but here are a couple of examples that triggered this exception that hopefully help!
{}.tap do |data|

Tags::TextField.new(form.object_name, attribute, form, {}).send(:tag_name, multiple?)

@agrobbin I think this is the same as #9861, I'll take a look.

Should be fixed by #9862.

Perfect, thanks @dvandersluis!


refactor(tabs): Use tabs from palette-mobile

This PR resolves

MOPLAT-802
MOPLAT-800

Description
This removes our internal tab implementation in favor of the recently consolidated version from palette-mobile. Now things are consistent between Eigen and Folio.
https://github.com/artsy/energy/assets/236943/5a345b51-6ce9-48b2-9629-6fb61b2f5d2b
cc @artsy/mobile-platform
PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Need help with something? Have a look at our docs, or get in touch with us.

very cool!
(when i saw the title, for a second i thought you switched spaces to tabs and got excited :D)


Package with severely malformed data: web-developer-tools

I have a package from the old Atom days, which I have tried to migrate to Pulsar.
On my own setup I can’t update to the latest version, and when I try to view it on the https://web.pulsar-edit.dev/packages/ site I get the following message:

web-developer-tools
Whoops! Seems this package has severly malformed data. Please submit an issue to https://github.com/pulsar-edit/package-backend/issue with the package's name. Thank you!

What is my next step?
PS I think there are two further issues with the message: the spelling of “severely” and the reference which (a) isn’t a link and (b) references /issue instead of /issues.

Thanks for reporting this issue.
Seems this is partially a duplicate of #88
But as that one hasn't been gotten to yet I appreciate you calling out this issue again. I've already created a PR to submit a fix for the warning given, and will take a look at the malformed data today hopefully. As that will require a manual edit to the database.
Essentially for a short period of time ( a few months ago I think) there was a bug that would incorrectly write data to the database when attempting to update a package. Which seems affected this one

So when investigating this to resolve the issue on the database, I've hit a bit of a roadblock.
The latest version the server has is web-developer-tools version 0.4.4 but the repo manngo/atom-web-tools only has up to version 0.4.0.
Would you like me to reset the latest version on the backend to 0.4.0? Otherwise I can fix the malformed data and have it point to 0.4.4 still but nobody will be able to install the package. @manngo how would you like to proceed?
Additionally you could manually publish a new 0.4.4 tag on GitHub and I can manually apply the fixes to use that as the latest on the database

With no response from the author, I've gone ahead and resolved this issue by falling back to 0.4.0 version of their package. Since there was no valid way to keep the 0.4.4 version as they had removed the tag from GitHub.
So I've deleted the now broken metadata for version 0.4.4 of their package, and fixed the metadata of their package as a whole. Since this was broken by a bug in the backend, the packages metadata has been fixed to properly include all associated data, taken from their GitHub repo.
Thanks for letting me know about this @manngo and hope this fix works for you.


Str::slug() not working with other characters aside english

Laravel Version: 8.3.4
PHP Version: 7.2.11

Description:
I am trying to use Str::slug() with another language than English(Hebrew in my case), but it is not working.
while $request->title is in Hebrew, the following will not return anything:
Str::slug($request->title);
But with English, it will.
I have also tried this form, but also not working:
Str::slug($request->title, '-', 'he');
Steps To Reproduce:
Just send a Hebrew sentence to Str::slug();
An example sentence(actually says 'this is a system test'):

זה ניסיון מערכת

Thanks for the help.

Think we need to add those characters here: https://github.com/laravel/framework/blob/5.8/src/Illuminate/Support/Str.php#L737-L763
If you could send in a PR, that'd be great. Don't speak Hebrew myself 😅

Also: 8.3.4 isn't a Laravel release. Did you mean a different version?

Also: 8.3.4 isn't a Laravel release. Did you mean a different version?

Oh, haha i have updated the version.

Think we need to add those characters here: https://github.com/laravel/framework/blob/5.8/src/Illuminate/Support/Str.php#L737-L763
If you could send in a PR, that'd be great. Don't speak Hebrew myself 😅

I will try it right now.

Added this pull request:
https://github.com/laravel/framework/pull/29838


Simplify PoseNet by parts example further?

Thank you @joeyklee and @mayaman for the new PoseNet API and example ❤
@joeyklee I think that a foreach() loop and the => syntax can be confusing for beginners just used to the basics of p5. Also, I worry the drawPosition() function (as nice as it is) might make it harder for users to be creative with the possibilities by messing around with custom drawing for different keypoints (connecting with lines, etc.) I would propose simplifying the example to something like. . .?
Let me know what you think!
let video;
let poseNet;
let poses = [];

function setup() {
  createCanvas(640, 480);
  video = createCapture(VIDEO);
  video.size(width, height);
  poseNet = ml5.poseNet(video);
  poseNet.on('pose', function(results) {
    poses = results;
  });
  video.hide();
}

function draw() {
  image(video, 0, 0, width, height);
  strokeWeight(2);

  // For one pose only (use a for loop for multiple poses!)
  if (poses.length > 0) {
    let pose = poses[0].pose;

    // Create a pink ellipse for the nose
    fill(213, 0, 143);
    let nose = pose['nose'];
    ellipse(nose.x, nose.y, 20, 20);

    // Create a yellow ellipse for the right eye
    fill(255, 215, 0);
    let rightEye = pose['rightEye'];
    ellipse(rightEye.x, rightEye.y, 20, 20);

    // Create a yellow ellipse for the right eye
    fill(255, 215, 0);
    let leftEye = pose['leftEye'];
    ellipse(leftEye.x, leftEye.y, 20, 20);
  }
}

@shiffman - oh yes! This is definitely more flexible as users can then experiment with custom geometries for each feature without defining unique functions. Let's replace the current example with the one you've proposed here :)

solved by: https://github.com/ml5js/ml5-examples/pull/99


Add Pybind + PyPi example

See: https://github.com/pybind/cmake_example
for which we probably want to also make sure we can pass in numpy arrays and OpenCV images

Project is pip-installable (see README.md), so presumably publishable to PyPi, but Ive never tried that, and Im not sure youd want to publish this template. Best leave the actual publishing until we have a real spin-off library.


fixed issue #176 - [closed]

In GitLab by @liyanq528 on Aug 28, 2017, 08:15
Merges 20170825 -> dev

In GitLab by @wknet123 on Nov 13, 2019, 09:55
closed


bug: ng-model does not work with  inside

Type: bug
Platform: all
Here is a snippet where I have an <input> inside <ion-nav-title>.  Accessing $scope.query from the controller doesn't work unless I changed the the ng-model below from "query" to "$parent.query".
<ion-view>
    <ion-nav-title>

                <input type="search" placeholder="Search" ng-model="query">

            <button class="button button-clear">
                Cancel
            </button>

    </ion-nav-title>

<ion-content>...</ion-content>

Greetings @5amfung!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Never mind it.
https://github.com/angular/angular.js/wiki/Understanding-Scopes


Refactor Socket::process into Socket::would_accept and Socket::process_accepted

Problem: Currently the process methods both check whatever the packet can be processed by the socket and do the processing. While it makes sense at the moment, the eventual adoption of a packet dispatching mechanism will make the checks optional in some configurations, thus it's beneficial to split the methods in two preemptively. As a side effect, the refactoring will allow us to get rid of the Error::Rejected error, which doesn't represent a problem with a packet or a socket, but serves as a marker of a failed packet dispatching.
Solution: Split the process methods into would_accept and process_accepted.
Changes introduced by this pull request:

TcpSocket::process, UdpSocket::process and RawSocket::process have been refactored.
Tests for new methods have been added.
Error::Rejected has been removed as not needed anymore.

Other:
This PR is a part of #19 effort.

Manually merged with stylistic changes.


docs cleanup and move

This seems to have busted the link to adding a new accelerator:

As a fun learning project I wanted to see if I could support https://github.com/adam-maj/tiny-gpu so I am curious if there is still really a cleanly minimal set of ops that need to be supported?


chore: remove duplicate go mod vendor

Title
Test already depends on vendor task, which already runs go mod vendor
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Refactoring / Technical debt

What parts of the code are impacted ?
Taskfile for Go SDK
Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

Thanks @edwardmp for your PR !
It's possible to follow this rules  ?

Thanks will change PR soon

@flemzord updated the commit message!


Letter Spinner Momentum

Hi, I was wondering if there is a way to prevent the letter spinner from doing it's little "wobble" from the momentum it has? So following the user's grab point and instantly stopping where they hold their hand.
Thanks

The wobble was dampened by increasing the angular drag of the LetterSpinner Rigidbody to 5. The LetterSpinner is an implementation example, so we probably won't touch it anymore. Another way to remove the spin might be to kill the angular velocity when the InitialAttachPoint lies on a line drawn between the point of rotation and the transform of NVRHand.

Closing, the wobble was dampened by increasing the angular drag of the LetterSpinner Rigidbody to 5. The LetterSpinner is an implementation example, so we probably won't touch it anymore. Another way to remove the spin might be to kill the angular velocity when the InitialAttachPoint lies on a line drawn between the point of rotation and the transform of NVRHand.


fix namespaces

Description of change:
Fix test namespaces to comply with psr-4 autoloading.

The Lint Wizard redacts anything he may have said before! :sparkles::sparkles::sparkles:
Lint Wizard Approved :heavy_check_mark:


Roll engine a064063e3f63..97f5ad4a9095 (11 commits)

git@github.com:flutter/engine.git/compare/a064063e3f63...97f5ad4a9095
git log a064063e3f63..97f5ad4a9095 --no-merges --oneline
2019-10-22<EMAIL_ADDRESS>Avoid accessing the Cocoa view on the GPU or IO task runners. (flutter/engine#13295)
2019-10-22<EMAIL_ADDRESS>Make flutter_tester support multithreaded testing, and run all Dart tests in both single and multithreaded configurations (flutter/engine#13273)
2019-10-22<EMAIL_ADDRESS>Made restarting the Engine remember the last entrypoint that was used. (flutter/engine#13289)
2019-10-22<EMAIL_ADDRESS>Roll src/third_party/skia f3f8ac37e468..2638f3d44b02 (12 commits) (flutter/engine#13291)
2019-10-22<EMAIL_ADDRESS>Flesh out the CanvasKit backend some more (flutter/engine#13275)
2019-10-22<EMAIL_ADDRESS>Roll Dart to 6a65ea9cad4b014f88d2f1be1b321db493725a1c. (flutter/engine#13294)
2019-10-22<EMAIL_ADDRESS>Disable flaky test ShellTest_ReportTimingsIsCalled. (flutter/engine#13292)
2019-10-22<EMAIL_ADDRESS>Do not request executable permission on Fuchsia file mappings unless it is required (flutter/engine#13290)
2019-10-22<EMAIL_ADDRESS>Roll src/third_party/dart e1c409792c..5814319bf9 (9 commits)
2019-10-22<EMAIL_ADDRESS>Revert "Made restarting the Engine remember the last entrypoint that was used. (#13264)" (flutter/engine#13287)
2019-10-22<EMAIL_ADDRESS>Made restarting the Engine remember the last entrypoint that was used. (flutter/engine#13264)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6555373565116416 , https://cirrus-ci.com/task/5147998681563136

Commit queue failed; closing this roll.


What are the build tools we might use?

Were going to use nodejs and npm to manage integration with facebook's API.  The server is gonna run on Heroku.


Improve Footer Dark 9

footer-dark-9.html
a) Change bg color as per figma design
b) Fix font size as per figma design
c) make it responsive below sm size screen
Existing Footer

Figma Footer

@Rajdip019 @rupsha014 Please assign this to me

@RavindraP04  go ahead


Unable to run as a Windows service

Hi all,
Has anyone been able to run this library as part of a Windows service? I'm trying to run it as a Windows service but I receive a "IOException occured The handle is invalid." on line 1896 of fsc.fs.
System.AppDomain.CurrentDomain.ProcessExit.Add(fun _ -> System.Console.OutputEncoding <- prev)
Is this because of the lack of console when running as a Windows service?
(my program works as a standard console application)
Thank you for your help.

I see the #if LIMITED_CONSOLE now. Would it be possible to a "include --define:LIMITED_CONSOLE" built dll into the releases? If not, can you specify the commit hash of the latest release so that we may build against those? Thanks!

It looks like LIMITED_CONSOLE is not defined anywhere (though it may be in the Visual F# Tools)
I think we would silently disable the console-related functionality rather than build an alternative version of the DLL, or control it via a command line switch.
BTW the line above is only set if the /utf8output flag is used.  Are you defining that? (though I'd expect you will hit other console-related limitations further along the way)

Confirmed. Yes, we were using the utf8output flag originally. I turned it off and now it works from the Windows service.

grep -rni "LIMITED_CONSOLE" ../FSharp.Compiler.Service-master/
./FSharp.Compiler.Service-master/src/fsharp/build.fs:5420:#if LIMITED_CONSOLE
./FSharp.Compiler.Service-master/src/fsharp/fsc.fs:1866:#if LIMITED_CONSOLE
./FSharp.Compiler.Service-master/src/fsharp/fsc.fs:1885:#if LIMITED_CONSOLE
./FSharp.Compiler.Service-master/src/fsharp/fscopts.fs:987:#if LIMITED_CONSOLE
./FSharp.Compiler.Service-master/src/fsharp/fsi/fsi.fs:669:#if LIMITED_CONSOLE
./FSharp.Compiler.Service-master/src/fsharp/fsi/fsi.fs:763:#if LIMITED_CONSOLE
./FSharp.Compiler.Service-master/src/fsharp/fsi/fsi.fs:2326:#if LIMITED_CONSOLE

OK, I'll close this now.  Most of those uses appear to be protected in the sense that a failure will just result in some console feature being disabled (e.g. console coloring).  Reopen if you see specific further problems or if you have other concerns?


Added support for complex datatypes

Currently, we try to fully support applying phase shifts when moving reflections around the unit cell (DataSet.hkl_to_asu(), DataSet.apply_symop(), etc.).  This is implemented by checking for the PhaseDtype, and updating any columns that are found.
We should also consider doing the same more broadly for structure factors stored as complex numbers. I added some support for this in DataSet.apply_symop(), but it is still missing from hkl_to_asu() and hkl_to_observed(). In an analogous way to DataSet.get_phase_keys(), this can be implemented using the recently added DataSet.get_complex_keys() helper method.
Few additional thoughts:

Is it safe to assume that any complex number stored in a DataSet represents a structure factor? Are there any other reasonable use cases for storing a complex number for which applying a phase shift would be problematic?
If there are other use cases for complex numbers, we could perhaps implement a custom dtype for complex structure factors. It would also be possible to implement compatibility with MTZ files by automatically reducing the complex number into |F|/phi columns.

P.S. I labeled this as a bug because I think we should 1) explain the behavior clearly in the documentation and 2) make it consistent to minimize surprise

#63 will fix this for hkl_to_observed()


Add 'dataZoom' event

Hello again,
Can you please update this package to support the 'dataZoom' event?
Maybe you can add the other events too, in case somebody needs them in the future..
Thanks!
EDIT: I made a fork of this repo and added the dataZoom myself. I also made a pull request: https://github.com/xieziyu/angular2-echarts/pull/9

Hi @averhaegen ,
Great, thank you! I've merged your PR.


Add Sign Up / Log In buttons next to gear menu for spectators

The high level approach taken by forum software seems like a good choice for the spectators view, of having a clear "Log in / Sign up" set of buttons in the upper-right corner (perhaps to the left of the gear menu, for us).  E.g. Discourse is a good example, though I wouldn't want to copy their approach of having one of the buttons disappear if you scroll down a bit.
https://discourse.julialang.org/t/package-not-opening-pr-for-updating/68725/4 for an example Discourse thread to look at.

Hello @timabbott I am an Outreachy applicant and I would like to work on this issue.

@zulipbot claim

@amanagr I'm pretty sure you have a PR for this; is it not linked?

I had a commit which adds Login / Signup buttons on right sidebar but removed it since #19927 changed our plan on how we want to approach this. So, this will probably be a small commit after #19927 gets merged.

#20852 will temporarily work.

Yeah, I think we'll still want simpler buttons (styled more like what we have on our portico pages would be OK) next to the gear menu, especially since the realm description piece we plan to potentially remove.

Downgrading from a release goal, since we have several other ways to do this.
I think this will still be a significant design improvement, so we should still do it.

This was fixed in https://github.com/zulip/zulip/pull/23245.


Fix Analyze step on CI

Recent changes that introduced Circle 2 (thanks @ide and @hramos for work on this) include special step for analyzing code. It takes PR number and processes the build.
Unfortunately, that breaks all non-PR builds (including ones scheduled by me as a part of release step).
This PR simply checks if such env variable is set and stops executing in case it's undefined.
Also, I have updated the order of the tests so that most important (unit tests) are no longer shadowed by temporary eslint and flow breakage. The reason for this change is that flow has been broken for ~20 days which shadowed breakage in unit tests (addressed in my other PR).
You can see build breaking before this change: https://circleci.com/gh/facebook/react-native/22391
And being green after: https://circleci.com/gh/facebook/react-native/22530

You can see this running in the wild on 0.50-stable branch.


Fix template name deprecations (no file extensions)

Removes file extensions from two places they don't belong (one that i just added today!)

Coverage remained the same at 93.059% when pulling 8b71e849b3ca5fef53ff1ad81bb3a82bd1c613f4 on nimmo-fix-deprecations-prepare-for-6.1 into 736f5b335c8969b50a5e5e11232f68637f7bef08 on master.

I'm still stoked that you figured out why the extension used to be necessary in API json results!


⚠ Bofrost.at has degraded performance

In 0dcdd75, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2567 ms

Resolved: Bofrost.at performance has improved in 83ac4f0.


Mossy: unable to export from 2D view

Tried to export SVG, PNG and JPEG from 2D view. Does not seem to work

I've got it to work with svg.  The main issue was that it was reference the old network object, not the unovis object.  That being said, for the other ones the problem is that the unovis network is a custom element that the save library cannot read. I can see a possible resolution by modifying the savesvgaspng library, but then we would have to maintain a custom library.  Looking for work arounds, but will push at least the fix for svg to mossy for now.


Incorrect element type within directive created hook

Version
3.0.11
Steps to reproduce
app.directive('test', {
    created: (el) => {
        console.log(el.type)
    },

    mounted: (el) => {
       console.log(el.type)
    }
})

 <input type="checkbox" v-test />

What is expected?
created el.type === 'checkbox'

mounted el.type === 'checkbox'

What is actually happening?
created el.type === 'text'

mounted el.type === 'checkbox'

This is expected: https://v3.vuejs.org/guide/migration/custom-directives.html#_3-x-syntax


PSA cipher driver delegation rework

Description
Rework PSA cipher as described in the documentation file docs/architecture/psa-crypto-implementation-structure.md.
Fourth and last PR on the subject, coming after #3933, #3744 and #4151. This PR also integrates the allocation of cipher
operation contexts by the application as agreed in #4157 and this PR is based on #4157.
Status
READY
Requires Backporting
NO, PSA only.
Steps to test or reproduce
CI testing is enough.

Rebased on last version of #4157.

In terms of overarching design, I'm wondering whether the IV size verification should really be a part of the core rather than the driver's responsibility (since driver's are assumed to be fed sanitized input by the core). In my mind that would make more sense.

I agree: it's better for the core to do all validation, since otherwise every driver writer would have to re-do it and get it right. Sharing responsibility for validation is especially dangerous since it tends to lead to both parties assuming something is not their responsibility.
This can be problematic if you add a driver for an algorithm that the core does not support, however. That's an open point in the design of the driver interface.

In terms of overarching design, I'm wondering whether the IV size verification should really be a part of the core rather than the driver's responsibility (since driver's are assumed to be fed sanitized input by the core). In my mind that would make more sense.

I agree: it's better for the core to do all validation, since otherwise every driver writer would have to re-do it and get it right. Sharing responsibility for validation is especially dangerous since it tends to lead to both parties assuming something is not their responsibility.
This can be problematic if you add a driver for an algorithm that the core does not support, however. That's an open point in the design of the driver interface.

I gave it a try, please have a look. The computation of the IV size is based on PSA_CIPHER_IV_LENGTH().

@stevew817 I believe I've addressed all your comments.

Following Gilles' comment I think the move of the IV size check to the core and the removal of the cipher_generate_iv driver entry point needs more thinking thus I am moving the three related commits to a separate PR to not block this one.

@stevew817 @tom-daubney-arm are you still ok to approve this PR with some part of it being moved to 4256?

Can we keep it in this PR? I don't think the final solution is that far off... Splitting this out would potentially mean indefinite delay, where the driver wrapper interface is in a weird state of requiring a cipher driver to expose a cipher_generate_iv entrypoint which would be taken away again later.
I believe Gilles' remark was merely about you adding a guarantee made to the driver as part of the set_iv entry point which is a bit off. It is wrong to say that the IV size passed to cipher_set_iv is guaranteed to be PSA_CIPHER_IV_LENGTH(key_type, alg). In the case where set_iv is called by generate_iv that will be the case, but not if a user has called set_iv directly (in which case the IV length could be any length accepted by the algorithm).
So I don't think it makes sense to split this out. Just update the doc of the driver entry point to say that iv_length is guaranteed by the core to be maximum PSA_CIPHER_IV_MAX_SIZE, and that the driver is responsible for checking whether the actual IV length is appropriate for the requested algorithm.

I don't think it is just about changing the doc. The doc is aligned with the code. If I change the doc I have to change the code as well and I am not sure how to do that properly yet.

Simple.
psa_cipher_generate_iv is meant to generate the default IV length for an algorithm (ref. its documentation). Therefore, it fetches PSA_CIPHER_IV_LENGTH(key_type, alg) of random IV into the given buffer and sets the output length iv_length to the default IV length (and throws an error if the buffer can't contain the default length).
psa_cipher_set_iv is meant to set a specific IV with a given length. If it is called as part of psa_cipher_generate_iv then the IV being set would be the default length. But if it is called directly by the user with a specific IV, that IV might vary in length as far as the underlying algorithm allows (ref. the doc for psa_cipher_set_iv). Therefore the core, as part of psa_cipher_set_iv, can guarantee the driver that the IV input length of set_iv is at most PSA_CIPHER_IV_MAX_SIZE, but the driver still has to check whether the IV length is appropriate for the underlying algorithm.
This is all in line with the top-level PSA API specification for cipher_generate_iv and cipher_set_iv.

I agree with the last paragraph but not sure about the first one. Where do you see that psa_cipher_generate_iv is meant to generate the IV with the default size ? This is what I have:
Generate an initialization vector (IV) for a symmetric encryption operation.
psa_status_t psa_cipher_generate_iv(psa_cipher_operation_t * operation, uint8_t * iv, size_t iv_size, size_t * iv_length);
Parameters
operation Active cipher operation.
iv             Buffer where the generated IV is to be written.
iv_size      Size of the iv buffer in bytes. This must be at least PSA_CIPHER_IV_LENGTH(key_type, alg)
where key_type and alg are type of key and the algorithm respectively that were used to set up
the cipher operation.
iv_length  On success, the number of bytes of the generated IV.

PSA_CIPHER_IV_LENGTH returns the “default IV size”.
I don't recall off the top of my head whether some of the non-authenticated modes declared for PSA allow a variable IV size. (Most authenticated ones do.) Even if they don't, it isn't a guarantee I would make for other modes we might plausibly add.
I haven't looked at the code in detail. I just noted that we couldn't guarantee to drivers that the IV would always be exactly PSA_CIPHER_IV_LENGTH. I think it's reasonable to guarantee that the IV will never be more than PSA_CIPHER_IV_MAX_SIZE, and that the core will validate the IV size for algorithms it knows about.

@gilles-peskine-arm Given the following part of the spec for psa_cipher_generate_iv():
"iv_size Size of the iv buffer in bytes. This must be at least PSA_CIPHER_IV_LENGTH(key_type, alg)
where key_type and alg are type of key and the algorithm respectively that were used to set up
the cipher operation."
Is it the case that the default size is the minimum size ?

The documentation for psa_cipher_generate_iv says the following:

The generated IV is always the default length for the key and algorithm: PSA_CIPHER_IV_LENGTH(key_type, alg), where key_type is the type of key and alg is the algorithm that were used to set up the operation. To generate different lengths of IV, use psa_generate_random() and psa_cipher_set_iv().

To me, that means when calling psa_cipher_generate_iv, the core should enforce the buffer can contain the default IV length, it should generate a random IV of the default length, and set it by calling psa_cipher_set_iv.
It is only psa_cipher_set_iv which can potentially take a non-default-length IV and apply it to the cipher operation. But the non-default-length will never be larger than PSA_CIPHER_IV_MAX_SIZE.

Rebased on top of development because of a merge conflict. The previous version of the PR can be found here.
Only one commit with conflicts: "psa: cipher: Include Mbed TLS cipher driver only if necessary"
Only 3 conflicts, all located in test dependencies in test_suite_psa_crypto_driver_wrappers.data due to the merge of #4246.
The three tests involved were:
PSA symmetric encrypt: AES-CTR, 16 bytes, fallback
PSA symmetric encrypt: AES-CTR, 15 bytes, fallback
PSA symmetric decrypt: AES-CTR, 16 bytes, fallback
The resolutions of the conflicts were just to keep the development version (PSA_WANT_... dependencies) and add the MBEDTLS_PSA_BUILTIN_CIPHER dependency.

The documentation for psa_cipher_generate_iv says the following:

The generated IV is always the default length for the key and algorithm: PSA_CIPHER_IV_LENGTH(key_type, alg), where key_type is the type of key and alg is the algorithm that were used to set up the operation. To generate different lengths of IV, use psa_generate_random() and psa_cipher_set_iv().

To me, that means when calling psa_cipher_generate_iv, the core should enforce the buffer can contain the default IV length, it should generate a random IV of the default length, and set it by calling psa_cipher_set_iv.
It is only psa_cipher_set_iv which can potentially take a non-default-length IV and apply it to the cipher operation. But the non-default-length will never be larger than PSA_CIPHER_IV_MAX_SIZE.

ok, that's illustrate well that it is better to read completely a spec rather than just a part of it. I've done the changes discussed in #4256.


Active Job adapter for delivering errors

Would it be possible to add support for AJ adapter for delivering errors?
It's missing now https://github.com/rollbar/rollbar-gem/tree/master/lib/rollbar/delay
I think it would be a nice addition for Rails apps

@morgoth I believe that's available as a plugin here https://github.com/rollbar/rollbar-gem/blob/master/lib/rollbar/plugins/active_job.rb
All you have to do is include it in your ActiveJob implementation like so:
app/jobs/application_job.rb
class ApplicationJob < ActiveJob::Base
  include Rollbar::ActiveJob
end

Let me know if this helps. If you have further questions, please comment and I'll reopen the issue.

@ArturMoczulski I was thinking about a way to deliver errors by AJ and not reporting errors in AJ.
So having configuration option, something like:
config.use_active_job that would use any background job backend that is configured in AJ


ArgoCD and autogenerated secrets

Quick update I just defined all my secrets manually (using sealed secrets) and now I can update the helm values file without breaking anything. Let me know if this is expected/they way to do it with ArgoCD and if so will document this as well in the PR :)
secretRefs:
  ldapSecretRef: "ldap-bind-secrets"
  jwtSecretRef: "jwt-secret"
  machineAuthApiKeySecretRef: "machine-auth-api-key"
  storagesystemJwtSecretRef: "storage-system-jwt-secret"
  storagesystemSecretRef: "storage-system"
  thumbnailsSecretRef: "thumbnails-transfer-secret"
  transferSecretSecretRef: "transfer-secret"

Originally posted by @camrossi in https://github.com/owncloud/ocis-charts/issues/137#issuecomment-1963873548

We need to check what to do for ArgoCD, but I didn't use it myself
cc @d7oc this may be some interesting edge case that could prevent us from using ArgoCD

Yep this needs to be checked.


[BUG] Regression in BlobClient.DeleteIfExistsAsync, BlobClient.ExistsAsync and BlobContainerClient.ExistsAsync

Describe the bug
If the container does not exist when using BlobClient.DeleteIfExistsAsync, BlobClient.ExistsAsync and BlobContainerClient.ExistsAsync
in v11
An exception will not be thrown because the methods will catch the exception for them (ContainerNotFound)
in v12
An exception is thrown
Expected behavior
What is the expected behavior?
It should catch the exception if the container does not exist.
Actual behavior (include Exception or Stack Trace)
What is the actual behavior?
Throws a ContainerNotFound
To Reproduce
Steps to reproduce the behavior (include a code snippet, screenshot, or any additional information that might help us reproduce the issue)
Use BlobClient.DeleteIfExistsAsync, BlobClient.ExistsAsync and BlobContainerClient.ExistsAsync on a container that does not exist.
Environment:

Name and version of the Library package used: Azure.Storage.Blobs 12.4.2
Hosting platform or OS and .NET runtime version (dotnet --info output for .NET Core projects): all
IDE and version : n/a

@amnguye, don't we return true or false if the Blob or Container exists or doesn't exist?  Also, I think the purpose of these methods is to save the customer from having to catch an exception.  I'm not sure that this is a regression.


ListObject API shows single object if we drag and drop directory structure from s3 console

Ubuntu 14.04
AWS SDK for S3 using C++
Compiler: gcc version 4.8.5
Steps to produce the bug:

Drag and drop directory structure on s3 console and upload the hierarchy.
e.g: dir1/dir2/dir3/dir4/abc.txt
upload dir1 directory at once using drag and drop on s3 console.

Compile the below code for list objects using
g++ -std=c++11 list_object.cpp -laws-cpp-sdk-core -laws-cpp-sdk-s3

Run the binary using
Ex: ./a.out "bucket name"

Output:

dir1/dir2/dir3/dir4/abc.txt
Single Path

Expected Output:

dir1/
dir1/dir2/
dir1/dir2/dir3/
dir1/dir2/dir3/dir4/
dir1/dir2/dir3/dir4/abc.txt

Note: If we make a directory hierarchy using create folder option on S3 console then we are getting expected output, Problem is if we upload the directory structure at once using drag and drop.**
sample program to list objects:
#include <aws/core/Aws.h>
#include <aws/s3/S3Client.h>
#include <aws/core/auth/AWSCredentialsProvider.h>
#include <aws/s3/model/Bucket.h>
#include <aws/s3/model/Object.h>
#include <aws/s3/model/ListObjectsV2Request.h>
/**

List objects (keys) within an Amazon S3 bucket.
/
int main(int argc, char* argv)
{
Aws::SDKOptions options;
Aws::InitAPI(options);
{
if (argc < 2)
{
std::cout << std::endl <<
"To run this example, supply the name of a bucket to list!" <<
std::endl << "Ex: list_objects  " << std::endl
<< std::endl;
exit(1);
}
 const Aws::String bucket_name = argv[1];
 std::cout << "Objects in S3 bucket: " << bucket_name << std::endl;

 Aws::Client::ClientConfiguration clientConfig;
 clientConfig.region = "ap-south-1";
 Aws::S3::S3Client s3_client(clientConfig);

 Aws::S3::Model::ListObjectsV2Request objects_request;
 objects_request.WithBucket(bucket_name);

 auto list_objects_outcome = s3_client.ListObjectsV2(objects_request);

 if (list_objects_outcome.IsSuccess())
 {
     Aws::Vector<Aws::S3::Model::Object> object_list =
         list_objects_outcome.GetResult().GetContents();

     if(object_list.size() == 0) {
         std::cout << "*Object List Size* " << object_list.size() << std::endl;
         return 1;
     }

     for (auto const &s3_object : object_list)
     {
         std::cout << "* " << s3_object.GetKey() << std::endl;
     }
 }
 else
 {
     std::cout << "ListObjects error: " <<
         list_objects_outcome.GetError().GetExceptionName() << " " <<
         list_objects_outcome.GetError().GetMessage() << std::endl;
 }

}
Aws::ShutdownAPI(options);
}

Is that a bug in the SDK?
Are you getting different results when listing the contents of the bucket via aws cli for example?

This an issue form S3 side.
With aws cli, you can still get single object.

S3 is not a directory structure even though it looks like one.
Every object in S3 has a key, and the key even though looks like directory path, it is not. The SDK does not and should not try to hide that fact and simulate a folder/directory structure.