Creating the object causes debug asserts on unsupported platforms

🐛 Bug Report
I want to create the object and then use platform to exclude the init calls.
However, merely opening up a state widget where the object is made gives a platform plugin error in debug
platform_channel.dart
      throw MissingPluginException('No implementation found for method $method on channel $name');
    }

I'm not sure if merely including the file import file  is doing this or if it is the object creation.
I only get gps when a button is pressed..
Normally I like to have a class member gps object.
But if I move the code (including the object creation) into the onpressed method, there is still an assert as above.

// This gets called when button onpressed(){}
// pretty much all of the sample code.

  void initGps() async {
    if (Platform.isAndroid || Platform.isIOS) {
      Geolocator geoLocator = Geolocator();
      if (!_initPerformed) {
        bool serviceEnabled;
        LocationPermission permission;

        // Test if location services are enabled.
        serviceEnabled = await Geolocator.isLocationServiceEnabled();
        if (!serviceEnabled) {
          // Location services are not enabled don't continue
          // accessing the position and request users of the
          // App to enable the location services.
          return Future.error('Location services are disabled.');
        }

Expected behavior
I want to be able to have the object or include files present and have one code base for desktop and mobile
(this test and failure occurs on linux)
Reproduction steps
You can try to build a file.. and if there is no mobile OS do not run anything.
Linux will assert and failure..will happen. (debug mode).
You can also clone my code https://github.com/bksubhuti/buddhist_sun
However, that code has the geolocator as a member of the gps screen.
You can move it to the gpsinit() but it won't make a difference.  it will still fail on linux
Configuration
So while the OS supported is ios or android.
It should be safe to use as a single code base without calling the gps functions
ubuntu 21.04
using latest stable dart flutter.
Version: 1.x
Platform:

[ ] :iphone: iOS
[ ] :robot: Android

I'm also getting trouble with the play store submission.  They say i'm not giving a popup to warn them, but I am and it is awaits the end of the alert popup.  However, I show the popup when they press the "get gps" button, before permission is requested.  I suspect an automation tool is pickup some functionality in a similar manner that the error is picking up  a problem.

@bksubhuti I am a bit confused. The Geolocator plugin uses a static class which cannot (and should not) be instantiated.
So when you do Geolocator geolocator = Geolocator() this must be some other class that is not part of the Geolocator plugin or you would get a compile error.

Well that is funny.. I do not see that object instantiation in the docs anymore..I'm not sure where i pulled that code from.. I'm not smart enough to figure it out.  Maybe it came from another place..
In any case.. I removed that declaration (it didn't do anything anyway)...
I succeeded on my phone for getting gps without it (as you expected)
I could reproduce the bug in linux (as you did not expect).
There were never compiler errors.. there was a runtime assert fail and it blocks the live debugger from running.  same issue without that instantiation as above.
Please see
This is not a page, but just a statefulwidget for a sliding pageview;
or compile and run the whole project.
To repeat this.. run in linux desktop .. click on gps bottom nav icon..
it should succeed and load a dummy page.
go back home..
go back to gps nav bottom nav icon..
it will throw an error (debug only).
"missing  platform plugin"
Small note to take the time to show my appreciate for:

Making this easy to use plugin
Documentation that worked for its intended platforms
Responding to this issue

@bksubhuti thank you for supplying the additional information. I will try to reproduce it, but first need to setup a linux machine. I will try to go through this today (my time is 10 am at the moment).

Fyi...I'm using Ubuntu 21.04 with added gnome desktop and xOrg boot.  Default is Wayland.
But I think standard ubuntu will give the same message.
I'm not the best coder.. but I believe the code is that has the instance never gets created (run time), but the compiler must be doing something.
My original code created the gps page, but I think this current code does not.
Just to be sure I ran this one more time.  I had to flip back and forth a few times instead of just once .  Try up to ten page switches
I believe it has to do with the creation of the static object (no longer by my code as checked in)  The code assertion still happens.  The code never does anything with geoloader run time,

Hi @bksubhuti,
I have just run your application (using the master branch) on my Linux installation (Ubuntu 21.04). I think I can reproduce the MissingPluginException error you are referring to, the problem however is that the error is not caused by the geolocator plugin but the wakelock plugin.
The error also occurs when switching between the "TMR" and "Cities" tabs (or the "TMR" and "GMT" tabs). You can see the error is caused by the wakelock plugin by analyzing the exeption below:
[ERROR:flutter/lib/ui/ui_dart_state.cc(199)] Unhandled Exception: MissingPluginException(No implementation found for method stop on channel flutter_tts)
#0      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:156:7)
<asynchronous suspension>

[ERROR:flutter/lib/ui/ui_dart_state.cc(199)] Unhandled Exception: PlatformException(channel-error, Unable to establish connection on channel., null, null)
#0      WakelockApi.toggle (package:wakelock_platform_interface/messages.dart:57:7)
<asynchronous suspension>
#1      MethodChannelWakelock.toggle (package:wakelock_platform_interface/method_channel_wakelock.dart:20:5)
<asynchronous suspension>

The error happens when the WakeLockApi.toggle method is being called. I am not familiar with this plugin and don't know how to help other then referring to their GitHub repo and suggest you create an issue there.
I will be closing this issue now because I couldn't find a relationship with the geolocator plugin. If I missed something please feel free to leave a comment and I will reopen the issue.

My sincere apologies with this...  sorry for the involved research.
Linux is easy, but setting up a flutter dev env is quite some doing.
Your Geolocator package is appreciated.
I don't see a solution to this and will look for a new plugin.
I have run into problems with the play store acceptance policy..
When it is resolved, I will hopefully try to submit some documentation for you :)


Update secure connect client docs.

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: Add secure connect client support info
Jira/GitHub Issue numbers (if any): https://harness.atlassian.net/browse/CI-14250
Preview links/images (Internal contributors only): to be added

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66e845e51e11010f5278a570--harness-developer.netlify.app


Make EEGClassifier have very nice interface

Put very good defaults so calling without anything will usually give you a good result.

I just take a short look at current examples to see what can be improved in the EEGClassifier interface. I think that the most unfriendly part is the callbacks part which takes a lot of lines and does really similar thing for CroppedDecoding and TrialDecoding but differs in details. My idea is to create two list of standard callbacks in the callbacks.py file so we can just import cropped_callbacks or trial_callbacks. This way we will remove callback definition from examples. Do you think that we should hide more from the user? @robintibor I think that other things should be easily accessible by a user (like batch_size, optimizer, lr, train_test_split).

I feel this may be a little too opaque for the user, how about we allow to supply a list of scikit-learn scoring functions like ['accuracy', 'f1_score'] either as cropped_scorings or as trial_scorings and rest of code is created internally? Then you can still decide which scorings you want but they are automatically correctly created and by default applied to both train and valid... ? How you think @sliwy

Seems legit to me and won't need a lot of modification. I'll try to implement.

@robintibor Do you know any way to infer if the callbacks should be Cropped or Trial in the EEGClassifier?

@robintibor Take a look at it: https://github.com/sliwy/braindecode/commit/82f212698dc6ff003840c01ff1465d1e9a3faad7 it does not support CroppedDecoding for now. First version for TrialDecoding, should be better tested, now just to show the conception.

Ya this seems really nice https://github.com/sliwy/braindecode/commit/82f212698dc6ff003840c01ff1465d1e9a3faad7. regarding knowing cropped or not, I think this can be a constructor_parameter cropped=True/False. I think it's not bad if this is written explicitly by user


TypeError: onVideoSelect is not a function. Then happens when i try selecting a video from the list.

Is this issue fixed, unable to move forward in the course because of this issue

I got the same problem, I had a typo in the video_list component. Check if you have any typos in the video_list component that should fix your problem.


wip: config reloading

https://github.com/bosun-monitor/bosun/issues/705

closed in favor of https://github.com/bosun-monitor/bosun/pull/1817


IP Change -> bad?

hey guys i have since yesterday a raspberry with btc core vers. 0.16 and lightning 0.4.1 online. my provider chance every day in the night my ip adresse. at the homepage: 1ml.com show me my old IP at. is this bad? is this automatically adjusted by lightning?
thank for yours horny project!
regards waffi

Hi @waffi121
I'm not 100% sure of what the consequences are if you have a new IP address and have channels open with peers that only know your old address. Probably most things would still work, assuming you still have outgoing connections with other peers.
But, the good news is, the code to automatically update your node's info is already on its way: see Pull Request #1109
For now, lnd does announce its IP address at startup, then every node in the network should update their entries for your node. But because this currently doesn't happen automatically, you could restart your lightning node every day to broadcast the new IP address.
Cheers,
guggero

Looks like a duplicate of #1057

Thank your for the infos. I will whait for the automatically update and start my raspberry from time to time new.
Have a nice day!
Cherrs
waffi

1ml.com show me my old IP at

Please don't treat these "explorers" as any source of ground truth. They shouldn't be used for anything other than looking a pretty visualizations. Their usefulness stops there.


fixes bug 1122309 - Upgrade to django 1.6

Coverage decreased (-0.01%) to 90.33% when pulling 8fea6f757234d47902777eb7e7aabc408e23e68e on peterbe:bug-1122309-upgrade-to-django-16 into 7a14c03e327e44c1997e9866c10a53aa381fcb6f on mozilla:master.


change package name to com.teragrep

currently org.teragrep is used, however we release under com.teragrep groupId so the package should be changed to com.teragrep.jpr_01

fixed in #12


The current tab is not highlighted for lightline

If no theme is selected (or another supported theme), lightline will show the current tab with a different background color.
However, if the theme is set to nightfox, the background color of all open tabs is the same.
let g:lightline = {
      \ 'colorscheme': 'nightfox',
      \ }

NVIM v0.7.2
@4513ECHO Do you have an idea how to fix this?

It looks like lightline handles both the statusline and the tabline. The field tabsel is not currently defined. This can be added.

This issue is resolved @jhscheer can you kindly confirm.

I confirm that this issue is resolved.
Thank you very much for the super fast fix!


Add CBAT logo to README.

Self explanatory.

Hi @codyroux i'll try and add a logo

@codyroux Let me know what you think of it

Hi @dbeigi, I like the PR, but I'm not sure I'd call the change a logo per se. I'll approve the PR with changes to the commit message though.
Best,
Cody


Legacy

@incuna/frontend please review :)

:+1:

@hippogriffic I don't know if it should be part of this pr, but where are we going to specify what "legacy" means? Like which browsers etc. Maybe a readme in the legacy folder?

yeah that's a good point @pandalion, I think I'm going to try and have a readme in each folder (or at least the ones that need explanation, which is most)

:+1:


<IP_ADDRESS>

I wonder what was the purpose of this pull request @sumpan ? It's sadly not clear from the description nor the changes :(

I wonder if you have seen my earlier question @sumpan ?

I'll close this one as there hasn't been any update since last August, please don't hesitate and reopen or create a new pull request!


 Build the application based in the  production Dockerfile . Push it to the local registry (localhost:5002)
. Pull it on the board from the local registry
. And run it on the board, showing the result in the VSCode terminal

LGTM


Temp directory doesn't get auto-removed and exists fails when tmplr is run from a package bin script

I'm trying to create a package that you can use like npm create foo to scaffold a project directory using tmplr.  To do this, there needs to be a bin key in the package.json that gets run when the create command is executed.  I made a really simple node script for the bin.js:
#!/usr/bin/env node
const { execSync } = require("child_process");
const { relative } = require("path");
const command = `npx tmplr use local:${relative(process.cwd(), __dirname)}`;
execSync(command, { stdio: "inherit" });

I haven't published it yet, so testing locally via something like npx ..\create-foo.  Getting the relative path from the current directory to where the .tmplr.yml file seemed to be necessary, as I think it was creating the output within the temp directory and then removing it at the end, leaving nothing behind.
Anyway, there's a prompt in the tmplr file and if I kill the command at that point, the local .use-*** temp directory is not cleaned up.  If I run a "normal" recipe with npx tmplr, the directory is cleaned up even if I kill the process.
Another thing that happens in this case is that the exists command doesn't seem to find a local directory.  So if I run the script from /projects/test/ and there's a local foo/ directory, the if: exists: below doesn't match when outputPath is foo, so the prompt isn't shown and the directory is removed:
  - if:
      exists: '{{ outputPath }}'
    prompt: '"{{ outputPath }}" already exists. Delete it before continuing?'
    choices:
      - Yes
      - No:
          skip: steps

  - remove: '{{ outputPath }}'

I belatedly realized I didn't actually need the bin.js file and could just put an npm command in the bin field.  But setting that to npx tmplr use local:. produces the same bugs as above.
It's possible I'm not setting the paths or using the commands correctly here, but there may also be some bug when the npx tmplr command is run from some other package's npm script.

ok I'd need to check these issues. the use-*** folder not getting deleted might be a bug that I'll look into.
on the other issue, can you provide an example of outputPath?

These are the steps before the if check above:
  - read: pluginName
    prompt: 'Enter the name of the plugin:'
    default:
      eval: '{{ filesystem.scopedir | Capital Case }}'

  - read: outputDir
    prompt: 'Enter the directory in which to create the plugin:'
    default:
      eval: '{{ pluginName | kebab-case }}'

  - read: outputPath
    eval: '../{{ outputDir }}'

So if you enter a name like My Test, the outputPath will be ../my-test.  The .. is necessary because the working directory seems to be set to the temp directory.
The package has been published and can be run as npm create fwidgets@latest.  Canceling that when the prompt is shown will leave the temp directory behind.
The code for the create tool is here: https://github.com/fwextensions/fwidgets/tree/main/packages/create-fwidgets

Seems strange that exists ignores directories while remove doesn't, since you may want to warn the user about removing an existing directory before actually doing it.

Seems strange that exists ignores directories while remove doesn't, since you may want to warn the user about removing an existing directory before actually doing it.

Good point. I'll look into the possibility of making exists behave like remove.

so there was a discrepancy between the behaviour of tmplr local:... and degit command, and between tmplr use local:... and use command. The behaviour is now synchronised on 0.3.2 onwards.
however, generally temporary directories are NOT removed when the process is killed. to see this issue in action, check this sandbox.
fixing this issue requires further work as the CLI needs to tap into SIGINT signal and handle things gracefully from there, which is not trivial to get correctly across all platforms. it also requires passing down an environment to all commands so that they can register their cleanup callbacks.

Thanks for digging into it.  Is there a better way of running tmplr from a node script?  Can the node API be used directly?

Thanks for digging into it. Is there a better way of running tmplr from a node script? Can the node API be used directly?

Kind of. It wouldn't solve this particular issue though, but I suspect it is a nice idea to make it easier to run some of tmplr's functionality programmatically.

from v0.3.5, at least in some situations and in some operating systems, temp directories are also cleaned up when the CLI process is killed (for example with SIGINT). note that I wasn't able to write consistent automated tests for this so I couldn't test it in the CI in different environments unfortunately, so if you spot this issue again, please feel-free to reopen this.


Decouple credentials

This PR tries to decouple some features of (RSA) credentials. This work is intended to make it possible to add other methods of:

HTTP Request signing
Decrypting account keys
Encrypting account keys

Guys, a small note on naming:

auth.Authenticator is ambigious. Does it add authentication information to an HTTP request or does it use authentication information to verify that a user is correctly authenticated?
auth.Verifier is a bit better, and explains the difference with auth.Authenticator, but that's only if you know the Verifier exists.

Consider naming it something like AddAuth and VerifyAuth to make the distinction clear. Similarly, you could do:
package auth

type Method interface {
   AddAuth(r *http.Request)
   VerifyAuth(r *http.Request)
}

Which immediately makes the different responsibilities clear. Not ultra important now, but something to consider.


Simplify the dataset index for now to just have a subject ID and an end event index.

This should wait to be solved until #82 goes in as it affects this part of the code as well.

@Oufattole , actually, do you need this indexing functionality for the windows case? Or is it not that the self.index parameter needs to have this, but rather that slicing functions need the capability of both?


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.10 to before v5.10.46",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=58c909022a5a56cd1d9e89c8c5461fd1f6a27bb5",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=208bb686e7fa7fff16e8fa78ff0db34aa9acdbd7"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "58c909022a5a56cd1d9e89c8c5461fd1f6a27bb5",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "208bb686e7fa7fff16e8fa78ff0db34aa9acdbd7",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "x86/ioremap: Map EFI-reserved memory as encrypted for SEV\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.10.46 by commit 208bb686e7fa7fff16e8fa78ff0db34aa9acdbd7, it was introduced in version v5.10 by commit 58c909022a5a56cd1d9e89c8c5461fd1f6a27bb5. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001000


Add Travis CI, update README to have working example, and start implementation of pytest

Solves #31
I've added .travis.yml file. I believe you will need to create the Travis account since the repo is under your name. Also, the example mentioned in the README should now be working.
Lastly, I am working on setting up tests. Please let me know any tests you might want to run. I have a few that I have in mind already.

Ok, sorry for all of the changes. I didn't see the comments you were mentioning. It looks like everything should be up to date now. I think we might have added back the excessive code I had replaced with the _fetch_report function. I went ahead and got rid of these.

Check the comments; if seems appropriate then update the code. I will merge it after review.

Check the comments; if seems appropriate then update the code. I will merge it after review.

@coyo8 I don't see any comments on my PR

@jackmoody11 Sorry it's my fault. it was in a pending state.

Good work @jackmoody11  👍


Please add missing tags to the git repository for 1.x releases

According to the ghapi Python package release history on PyPI, there are releases for 1.0.2, 1.0.4, and 1.0.5, but corresponding tags do not exist on the GitHub repository.  Can these be retroactively added?  Or at least added with the next 1.0.6 release?

Can it be re-opened?

My team decided to use PyGithub instead of this project.  Feel free to file another new issue to open this again, but I won't be driving this one.


IT-3606: switch security-hub account to SecurityCentralAccount

We want the security-hub CF stack to be created in the delegated admin' account rather than in the Organizations account.

you will need to setup securitycentral account as the delegated admin for security hub before securitycentral can enable and manage securityhub.

Yes, this is done.  Thank you for linking the instructions.


Can't adjust settings

When I am on the screen that shows how many blocks are needed to build the structure none of the buttons do anything.
Using ATM10 modpack version 0.43

Please turn off EMI to Ctrl+O.
EMI is not supported yet.


Flutter repository should not contain implicit null returns for functions with nullable return types

Use case
Given a function with a nullable return type, it should not fall off the end of the function with an implicit return statement. All returns should be explicit, which prevents bugs where the developer forgot to return a value.

Proposal
Add explicit return statements.

@srawlins Did you fix all instances with your PRs? Can we close this?

Er, probably. 😁


[Suggestion]: Refactor Mule Params and Param Styling

Check for existing suggestions before posting.

**Mule Type: **
ALL
Please describe your changes desired:
Params are kinda messy layout-wise all stacked and hard to understand which are required and what are optional, I suggest we refactor them with headings for bunches of related parameters and or figure out how to work nested params so that when you enable certain options others become available and remove if that option is no longer used in the order.
Additional Info (if any):
I think Tater Trader uses a version of nested parameters could be wrong but I think It does at least make tidy use of headings and dropdowns.

Related too https://github.com/Misunderstood-Wookiee/Mules-and-Warehouses-Extended/issues/6

We could nail this one at same time https://github.com/Misunderstood-Wookiee/Mules-and-Warehouses-Extended/issues/74


feat: 1446 cone and pollen count step 5

Description
Closes #1446

Changelog
New

Part-1 of Parent Tree and SMP Cypress test

Changed

my-seedlots pagination test

Removed

None

How was this tested?

[ ] 🧠 Not needed
[x] 👀 Eyeball
[x] 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?

Thanks for the PR!
Deployments, as required, will be available below:

Frontend
Backend
Oracle-API

Please create PRs in draft mode.  Mark as ready to enable:

Analysis Workflow

After merge, new images are deployed in:

Merge Workflow

Thanks for the PR!
Deployments, as required, will be available below:

Frontend
Backend
Oracle-API

Please create PRs in draft mode.  Mark as ready to enable:

Analysis Workflow

After merge, new images are deployed in:

Merge Workflow

freeing up resources, please reopen when ready


Improved repository code quality

Summary
Ref #307. This PR tries to use the same approach registering modules in the panel administrar as we are doing in gateway and the same validator in the artifact field.
Details and comments

Updated admin.py to use annotations instead of the method
Updated NestedProgram artifact field with tar extension validator

@Tansito can you check the tests?


Internal change recommendations [WIP]

Current state:

Setting change recommendations as internal ./. public works

Hint: extends PR #3907

@CatoTH I wasn't able to keep your authorship; if you want onw add a dummy commit and rebase ;)
Also: Travis is failing in the cr-repository. Can you have a look?

It should succeed now.
As for the backend: publishing works. What doesn't work yet is unpublishing a previously published change recommendation, supposedly because the client doesn't receive any update about this. This probably is not a big issue here, but may be a point for later improvement, as it will be probably the same for motions and other unpublishable objects.

Done the stylistic improvements.


blog post about PWA talks

Here’s the proper embedded video template:
<figure block="figure">
	<iframe elem="media" width="W" height="H" src="VIDEO"  allowfullscreen></iframe>
</figure>

There’s no need for allowtransparency="true", frameborder="0", scrolling="no", but elem="media" is required. I usually just go to one of the latest blog posts with a video, press “Edit on GitHub” and copy-paste code sample.

I would be also good to set the same width to all videos.


Added Clone to Cocoon and MiniCocoon

#29

@Deaths-Door I pulled your PR locally and tried to unit-test it, and I found that Cocoon is not actually cloneable, although the MiniCocoon is cloneable. It seems like the reason is that the Cocoon structure doesn't copy the password inside, instead it holds the reference. It's done for security reasons, cocoon doesn't own unnecessary copies of secret data trying to zeroize all private keys.
Add a unit test with cocoon.clone() for MiniCocoon and remove the derive(Clone) for the Cocoon.
In your application, you can manage the user password independently (encrypt, erase, clone, and such).
If you need the  Cocoon::clone() specifically, we might postpone this PR.

@Deaths-Door The Cocoon structure is pretty hollow and it does not actually represent the container structure, it just HELPS to dump and parse the container. If you needed to use Cocoon with the same password in 2 different threads, you would need to clone the password into these threads and create the Cocoon twice. Also, it's gonna challenge you to think twice whether to share or not the password with 2 different threads ;)
Overall, because of the Cocoon's limitations, the MiniCocoon was introduced.

@Deaths-Door Please, rebase to the latest main branch commit, I fixed the code coverage.


See differences between @ledgerhq/react-native-hw-transport-ble and master

https://github.com/oasisprotocol/ionic-ledger-hw-transport-ble/commit/e33220e10f6d5d6c5f0e4091d31ee36800d5d9cf doesn't do a good job showing differences between original code (@ledgerhq/react-native-hw-transport-ble) and master.
I added refactored-ledgerhq-react-native-hw-transport-ble branch that includes a subset of no-op changes extracted from e33220e10f6d5d6c5f0e4091d31ee36800d5d9cf.
This allows us to view the meaningful changes in src/index.ts:
https://github.com/oasisprotocol/ionic-ledger-hw-transport-ble/compare/refactored-ledgerhq-react-native-hw-transport-ble..master?w=1#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80

Update: we rewrote git history


Currently Unmaintained

As a note here, I am currently unable to keep this repository up to date.
@TimSusa I assume you are not interested as well, as you stopped using it internally, right?
If so, we might want to look for another maintainer.

hey @jonas-app, i can help maintain this project. we use it on a daily basis and one of its dependencies is giving us some issues.

just checking in again...do you still need a maintainer for this project? we use it on the daily and would love to keep it going for now.

@tubbo @jonas-app we are interested in this project as well. Did you find a conclusion? Wil lthis be maintained?
@tubbo did you manage to find a replacement for this project?

I no longer work at the company so I can't decide regarding this. I think the easiest for you would be to create a fork. Sorry that I have no better news for you.

In principal it should be thought about if a company which is supporting pis party in poland should be supported in any way to be honest...

So if there is no need for anybody other here, I think we can stop this project safely

In principal it should be thought about if a company which is supporting pis party in poland should be supported in any way to be honest...

I guess we should keep politics out of code, but just out of curiosity, which company are you talking about?


Static methods not callable

Logging as an issue as I'm not sure how to fix.
It seems static methods are not callable via callMethod, for example:
@JS()
@staticInterop
class Response implements Body {
  external factory Response([dynamic body, ResponseInit? init]);
}

extension PropsResponse on Response {
  static Response json(dynamic data, [ResponseInit? init]) =>
      js_util.callMethod(Response, 'json', [data, init]);

Not entirely sure how to call a static method from the JS layer, any ideas?
The error thrown is:
NoSuchMethodError: method not found: 'apply' on null

Usage is also interop.PropsResponse.json(), since you can't access a static on the extension....

IIRC you could use js.context['Response'] instead of Response directly

Can't seem to get it working. Strange one.

Okay so this seems to work:
@JS()
@staticInterop
class Response implements Body {
  external factory Response([dynamic body, ResponseInit? init]);
  external static json([dynamic body, ResponseInit? init]);
}

hi @Ehesp I've pushed a fix for this issue, https://github.com/jodinathan/js_bindings/issues/26 and https://github.com/jodinathan/js_bindings/issues/24.
The example app ran ok.
Would you mind do some testing with your apps before I publish to pub please?

I also removed some forbidden names like set and get, so there will be no more mGet and mSet.
This was needed when I was using factory properties instead of extension methods, now it seem to be fine to use those names.

Copied from chat for visibility:
Seems to be working apart from one issue 😄
If we do this for example:
fetch('', RequestInit());

We'll get an error - it seems as though header is being passed to the constructor as null, which JS says is invalid - it either needs to be undefined or an empty Headers instance. I can fix this by doing:
RequestInit(headers: interop.jsUndefined)

However, then we get another error:
null is not an accepted type. Expected one of , no-referrer, no-referrer-when-downgrade, same-origin, origin, strict-origin, origin-when-cross-origin, strict-origin-when-cross-origin, unsafe-url.

So ReferrerPolicy if not provided also gets passed as null (not undefined), and I can't pass that myself as the type is ReferrerPolicy?


Azure tenant drop-down isn't sized correctly with no accounts

Azure Data Studio Version: main

Steps to Reproduce:

Open Create Firewall rule dialog with no Azure accounts added

Actual: Azure tenant drop-down is not sized correctly

Huh I solved this issue a while ago hmm

I'm still see this, but this time with accounts added.


[Improvement][login controller] Need password when open in new tab

Describe the question
The verification is based on sessionId value stored in both cookie and sessionStorage. The new browser tab always has empty sessionStorage so we need to input password again and again.
What are the current deficiencies and the benefits of improvement

Login once and need no more password when open in new tabs.

Which version of DolphinScheduler:
-[1.3.4]
Describe alternatives you've considered
Maybe we can use localStorage instead of sessionStorage to make sessionId available across tabs. (Less secure?)
It's a so itchy feature.
Full details see https://blog.guya.net/2015/06/12/sharing-sessionstorage-between-tabs-for-secure-multi-tab-authentication/

In the latest dev branch, this issue has been fixed.
Please see #4162.

In the latest dev branch, this issue has been fixed.
Please see #4162.

fix by #4162

fix by #4162


Remove teaclave dependencies + Add documentation

Current Status
$ cd attestation/
$ cargo build

Above build works (currently, build fails with mesatee_sgx feature).
To generate docs, cargo doc --no-deps --open.

build fails with mesatee_sgx feature

The deps need to be patched: https://github.com/crypto-com/incubator-teaclave/blob/chain/cmake/tomls/Cargo.sgx_trusted_lib.toml#L19
I'm not sure whether this trickery can still work with enclave code in the same workspace.
One difficult part is that this patches all crates in the tree -- chain-core depends on parity-scale-codec's derive where there's serde/toml compile-time dependency, and it should be using the "non-patched" version...

Hi all, I just came across this fork/PR. These docs/comments are really useful (which I planed to complete them when all APIs are stable).  Is there any chance to contribute back to the Teaclave main repo?

@mssun yes, it's ok to contribute back the documentation -- @devashishdxt may later open a PR without other changes

Thanks, really appreciated!

@mssun Created this PR.


Create KubernetesExecutor Diagram

@mik-laj what do you think about moving this issue to Airflow repo?


parser/macro macros

WIP. Current status: both macros generate commands that pass elaboration... so far :) . I haven't looked at the output too closely to see if it is 100% correct.

merged


Added first unique character in string using python

Hey there!, Thanks for submitting a PR to this repo
Please complete the following checklist for your PR to be approved. Mark the items by adding an x.
Example:  - [ ] Mark me as completed
To mark: - [x] Mark me as completed

[x] My Pull Request adheres to the Contribution guidelines.
[x] I have added readme.md and solution files in the appropriate folder.
[x] The solution I have given is my own and not plagiarized in any form.
[x] My solution passes all the testcases.
[x] I have properly indented and documented my solution using comments.

If any of the above is unmarked, please make the necessary changes and then mark them so that you're PR can be approved and merged.

Added the comments for solution ..please check


typescript type, java script shows: Assigned expression type string is not assignable...

I'm using typescript side by Javascript... on Webstorm, and IntelliJ depend on the cases, and i found that it returns error, maybe it's due to one of these reasons lack of their implementation, or maybe i need to know something i do not know about JS Doc, or maybe it's lack of JsDoc for such cases....
the code i use in my TS:
type X='a'|'b'|'c';
and somewhere in my js, i say,
/**
  * @param z {X}
  */
function f(z){
    if(z =='a')
        ....
}

and when i go over the equality signs, it show a message:
"Assigned expression type string is not assignable to type IterationOption, which IterationOption is my X in above case
Anyway, the IDE does not understand that i use type, and it doesn't understand it if i put Js Doc '@type' on it's head even if i do that.
Please Refer to These Links, as I Followed Them Myself:
http://stackoverflow.com/questions/15490560/create-an-enum-with-string-values-in-typescript
https://basarat.gitbooks.io/typescript/content/docs/types/literal-types.html
YouTrack Link:
https://youtrack.jetbrains.com/issue/IDEA-166433

This is an issue with your IDE, not with JSDoc. Your IDE does not use JSDoc to evaluate your code.


Improve logs when ingesting data.

When using quickwit to ingest data, we get logs similar to the following:
Num docs    10 Parse errs     0 PublSplits   1 Input size     0MB Thrghput  0.02MB/s Time 00:00:02

The format of the log can be misleading and it can be misread as having 10 parsing errors instead of 10 documents if read quickly.

We can use tabled to print out ingest stats. We already use that dependency when printing index describe stats.


Canvas overlay position incorrect for fixed elements in Chrome

See https://jsfiddle.net/Lodjw9hn/ for code.
In Firefox it works correctly, I see this:

But here's what I see in Chrome v52.0.2743.116:

Upon some investigation I think that Firefox is actually bugged in this case as per: https://bugzilla.mozilla.org/show_bug.cgi?id=434678
The line in question that is failing is https://github.com/Andrinoid/showtime.js/blob/master/src/showtime.js#L127
The fact that this works at all for fixed elements is probably a bug with the current implementation.


Allow duplicating of operations in txbuilder

Add functionality to duplicate any operation in the txbuilder of stellar laboratory as per #543

Thanks for the PR! 🙌 Everything works nicely, I just added a few nitpicky comments.

Thank you! Those were pretty valuable.

May I bump this, @quietbits  or @piyalbasu ?

@hanseartic sorry for the delay! It should be merged today. 🤞


SelectList: adjust y padding to result in 40px total height

Currently, SelectList's total height is 43px which looks a bit funny when side by side with TextField which is 40px. I've adjusted y padding from 11px to 9.5px so that total height is 40px.

Warnings

:warning:

Please add a changelog.md entry for your changes.

  Generated by :no_entry_sign: dangerJS

Also this is worth a changelong entry :)


macros: fix references to Error in docstrings

Fixes #53

It says macros.rs has merge conflicts. I pulled it locally and don't see any, but there's nothing I can do from here. @birkenfeld will have to squash and rebase on their end. Sorry if you got spammed with my auto-merge stuff while I was trying to figure things out. This is ready to go when the conflicts are resolved.


it dont work

when i click to merge it just spends the money and then it doesnt work

i have  the same issue

same

SAME


[SVG] correct init method

Something simple like this was failing:
from fontTools import ttLib
fontFilePath = 'font-with-SVG-table.ttf'
font = ttLib.TTFont(fontFilePath)
print font['SVG ']

I took a clue from the CFF table code.

Coverage decreased (-0.003%) to 70.487% when pulling ce4af2a0a2d66c7faa05707fb4a5013909ae41f7 on miguelsousa:svg_init_fix into fb6712f3ec7a7aa2d6813a1d69d0e9c5ee3801b7 on behdad:master.

Thanks Miguel!


clean up tags for each template/sample on the spin up hub

Clean up these tags on each of the listings:

What changes are we looking to make specifically with these tags? Can we add success criteria to this ticket?

We have several instances where we interchangeably use abbreviations and expanded forms. kv and key-value are examples of one. It would be good to have consistency and also clean up cases where we have the content type listed in the tag. It would be good to come up with a fixed list of tags to be used for future PRs.


Add backlog of contributors with all contributors bot

Adding breadcrumbs to https://github.com/the-turing-way/the-turing-way/issues/3032


[Upstream Catchup] Merge Rocket.chat.Livechat:develop to develop

Weekly Catchup PR to merge Rocket.chat.Livechat:develop in develop.

@ear-dev This PR looks good. Can you please merge it? Thanks!!


implausible temperature readout from internal sensor

I life in Germany and not in some desert and currently here is winter and it is cold outside. We heat our house to ca. 20-21 degrees Celsius, but the devices after startup always shows almost 40 degrees Celsius, and after running a while the temperature increases a bit, as expected.
This is different from the Raspberry Pi Pico (2) boards I also use, this shows the correct temperature about ca. 20 degrees Celsius, increasing to ca. 22 degrees Celsius after running a bit.
We are using the conversion as explained in the RP2xxx data sheets. Only explanation I have for this is, that Waveshare uses another RP2xxx chip than Raspberry Pi with a different temperature curve for the sensor.

Created a ticket at Waveshare and asked about this, lets see what they say.

My RP2350-GEEK starts at 23°C (if left unplugged for an hour) and goes very quickly up to 29°C and then more slowly to hover around 35-40°C. The RP2350 is tightly packed with the LCD and backlight inside a plastic case and no cooling. The Pico 2 has at least some air cooling.
The Pico 2 and the Waveshare RP2350-GEEK also use different DC-DC converter chips, maybe the one used by Waveshare is less accurate. The RP2350 datasheet says that the temperature reading is extremely sensitive to the reference voltage. I'm no electrical engineer, just saying.

After the whole night at ca 20°C room temperature, if I plug them in in the morning they both show temperatures like 38-39°C and after a while it goes up to 45°C or so. That is plausible given the small case, but the initial temperature is much higher than expected.
Maybe the reference voltage for the AD is off, I did not take one apart and measured. Maybe this can be compensated in software, but I don't want to guess the formula ;-)


Hours until game - variable instead of fixed (2 hours)

Currently the games are tipped if the game starts in less than 2 hours. @nordcomputer suggested to also have this as a environment variable.

@antonengelhardt hey, sorry, I was on vacation but I will have a look next week :)


Debug verbosity for Polly and Hunter only shown on full in polly.py

Polly.py sets verbosity levels for Polly and Hunter to Debug all the time. This change reverts that
Looks like a mistaken indent removal

Yep, looks strange, was added here: https://github.com/ruslo/polly/commit/27f994716762f1d0ea5b69cc1ed1e5526f8f5794#diff-df17afae6a758d51ebefce8c1c045560L205
Thanks for the fix.


fix: Docker COPY command for multiple files

Description
The Dockerfile attempts to copy multiple JSON files with the COPY command.
However, this is not possible with . as directory. This can be fixed by using ./ as directory path.
Fixes #641
Environment
Tested on the following setup:

Armbian 21.02.2 Focal
Odroid HC2 (armv7)

@matthieubosquet I'd really like a GitHub Actions test for #580 along the lines of https://github.com/solid/community-server/blob/v0.7.0/test/deploy/validate-package.sh
Maybe we can split that test in 2 parts, and reuse the second part for Docker?

@DylanVanAssche thanks for the fix!
@RubenVerborgh I agree in principle that having CI building Docker images in multiple environment would be ideal. But while the validate-package script is interesting, I wouldn't know how to properly port it to build and clean up Docker images. I suspect it will be relatively easy once we get to publishing to Docker and just use GitHub actions... Probably just build the image in various environments and push from one which should fail if one of the environments can't build. I don't know how to achieve the same kind of behaviour via a bash script.


Having trouble trying to change the delimiter

like it was recommended in the documentation i tried to change the delimiter to a | character but it didnt work can you please help?
my code for reference
 <ReactMultiEmail
        emails={data}
        placeholder={title}
        delimiter="[|;]"
        onChange={(_emails: string[]) => {
          let newEmails: string[] | undefined = _emails;

          if (validationType) {
            if (_emails.length > 0) {
              newEmails = customValidation(_emails);
            }
          }

          value_update(attrName, newEmails ? newEmails : _emails);
        }}
        getLabel={(
          email: string,
          index: number,
          removeEmail: (index: number) => void
        ) => {
          return (
            <div className="ug_email" data-tag key={index}>
              {email}
              <span data-tag-handle onClick={() => removeEmail(index)}>
                ×
              </span>
            </div>
          );
        }}
      />

My bad it was a problem on my side only


Add BIP371 fields

Related to https://github.com/bitcoinjs/bitcoinjs-lib/pull/1742

One of the vectors from BIP-0371 had a bug, so the vectors imported here include the fix for that bug: https://github.com/bitcoin/bips/pull/1296

A quick glance looks good.
Would also like @motorina0 to look over it.

Would also like @motorina0 to look over it.

I will check next Mon/Tue.

LGTM, however it needs more unit-tests.

coverage does not meet global threshold (90%)
github workflows should be configured (see bitcoinjs-lib)

Alright. Tests added, GH workflow configured at least somewhat.
Thanks!

Also remove travis config.

in package.json the test script should also run the coverage ( && npm run coverage)

Business Logic side - all looks good 👍

Unit Test side, I'm trying to understand the  original vs new twice logic:

the original logic made two calls with a one item array, the second (twice) call altered the value for some fields
with the new logic

the old twice flag looses its meaning (second call has the same inputs, because data is not altered)

is this a regression in the tests?

the new tests make one call with a two item array (different values for each item), instead of two calls

is this intended?

The old twice logic was being (IMO) abused to do 2 things:

For valid cases, it was modifying specific keys to squeeze them through successfully
For invalid cases, it was modifying nothing to deliberately fail

Now twice is only used for invalid cases to ensure that duplicates don't sneak through, and for valid cases we explicitly put in the duplicates.
There is a slight difference between two calls with different values and 1 with 2 different values. That can be seen in lib/utils.ts. When it's one call, the dupeSet detects the duplicates, but when it's 2 calls, the array filter detects it.
Overall the new way allows for more flexibility (it's now possible by adding fixtures to fully exercise both paths).


fixing tabular parser

I've replicated the PSY3.0 objective function created by the tabular parsing of the RTS using the FuelCurve functionality.  However, I haven't developed tests. In the interest of time, I'm opening this PR now.

@claytonpbarrows I changed the target branch to the doc strings changes PR so that we can avoid name clashed and @rodrigomha can test PSB with all the changes in the same place

@claytonpbarrows we will merge this to enable a better parsing in psy4 but as discussed with @GabrielKS, there needs to be one more step of cleaning up to be done with the Plexos2Sienna effort.


Upstream QuickLogic k6n10f flow

[x] Look into libmap-based inference not setting the right attributes for TDP36K per-configuration renaming in QuickLogic’s master
[x] Sort out the licensing issue
[x] create a draft PR from Martin's branch
[x] Add the tests for the base arch cells
[x] Add small simulation tests for memory

[x] for expected code patterns, check they infer
[x] and simulation check that they work for some selected addresses

[x] Add small simulation tests for DSP

[x] for expected code patterns, check they infer
[x] and simulation check that they work for some selected values

(I will do one final rebase with squashing of fixups when we move this PR away from draft, I want the addition of the license header be there in the commit that checked in the file.)

Force pushed with rebase and squashing of fixup commits

@povik I think this broke the YoWASP build: https://github.com/YoWASP/yosys/actions/runs/7094599738/job/19310141018#step:7:380

@whitequark Let me look into it.

@whitequark As a sidenote, what would it take to have the YoWASP build in the mainline CI?

@mmicko Look above. Possibly something we could add to the Jenkins CI to run on the master at least, not necessarily on every PR.

FWIW, The WASI build without LTO (which is used with YoWASP but not in the script I gave you) should be fairly lightweight.

Sure. Will take care of it. @whitequark thanks for the script


Closing a connection fails

Hi all,
This is an issue following this DuckDB discussion, and it might also be related to Issue: https://github.com/duckdb/duckdb-node/issues/39
What happens is, after successfully closing a connection the first time, any subsequent connection cannot be closed anymore.
To reproduce, please clone this quick repo.
After the usual npm install to get all necessary node packages, use npm start to start the application and push the button.
After no longer than 30 seconds, the database lock is released and I can connect using either CLI from the Terminal, or from another API such as the duckdb package in R.
However, after the first lock being released, for any subsequent button push (therefore any subsequent database connection), the lock is not released anymore no matter how much time one waits.
This was tested on MacOS on both Intel and ARM computers, using Sonoma.
The DuckDB version is the latest, 0.10.0 (as per the package.json file in the above repo.
In hoping this can be reproduced,
Adrian

I am having the exactly issue with v0.8.1 & the latest versions. I was tested on MacOS also.

any updates? I'm facing the same problem. I try to create a database on the fly and then export the whole database file.

Confirm, can reproduce on macOS and inside docker containers of all sorts


API to fetch pod annotations and more

Closes: 109
Adding endpoint /namespaces/:namespace/pods/:name/metadata/annotations/:annotation
This allows fetching of a single annotation from a specific pod in a specific namespace. The path (.../metadata/annotation...) is intended to mirror the apimachinery API to avoid re-inventing especially assuming this might be expanded.
Given the leveraging of apimachinery, it made sense to add some additional endpoints:

/namespaces/:namespace/pods/:name/metadata/annotations - when no :annotation is added (or is blank) all annotations are returned
/namespaces/:namespace/pods/:name - pod details are returned for namspace/pod
/namespaces/:namespace/pods - pod details are returned for all pods in namespace

Unmarshalling of annotations:
Since the specific goal is to help access scheduler-simulator annotations in a usable format, we attempt to unmarshal specific annotations.  A specific scheduler-simulator/* annotation will become map[string]map[string]string.
In addition, when :annotation = "scheduler-simulator" or "scheduler-simulator/" we can conclude that all the simulator annotations for this pod should be returned and unmarshalled into map[string]map[string]map[string]string.
Other cases dump all the metadata and do not unmarshal annotations to avoid errors.
Signed-off-by: Mark Sturdevant<EMAIL_ADDRESS>
What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
/label tide/merge-method-squash

@markstur
Hello! Thank you for your PR!
Our simulator allows us to communicate with api-server on port 3131, which means that we could already get and list pods. So I think the necessary endpoint is only below. (Cc. @sanposhiho )

/namespaces/:namespace/pods/:name/metadata/annotations/:annotation
/namespaces/:namespace/pods/:name/metadata/annotations

(It is possible that /namespaces/:namespace/pods/:name/metadata will also be needed someday.)
And I would like to discuss this implementation.
If you put a string of conditions such as scheduler-simulator directly here, you may forget to modify it if the annotation name is changed. (this is also a problem on our simulator that the current simulator does not yet define such strings in a one place.)
Also, the string scheduler-simulator should be used as a prefix in the future, so it would be better to handle it in c.Param(). WDYT?

Closes: 109

@markstur Do you mean it's for https://github.com/kubernetes-sigs/kube-scheduler-simulator/issues/109?
In #109, I mean we want to have just functions (not HTTP APIs) like:
func GetFilteringResult(pod *v1.Pod, pluginName, nodeName string) string {
}

func GetScoreingResult(pod *v1.Pod, pluginName, nodeName string) string {
}

@markstur Hello! Thank you for your PR!
Our simulator allows us to communicate with api-server on port 3131, which means that we could already get and list pods. So I think the necessary endpoint is only below. (Cc. @sanposhiho )

/namespaces/:namespace/pods/:name/metadata/annotations/:annotation
/namespaces/:namespace/pods/:name/metadata/annotations

(It is possible that /namespaces/:namespace/pods/:name/metadata will also be needed someday.)
And I would like to discuss this implementation. If you put a string of conditions such as scheduler-simulator directly here, you may forget to modify it if the annotation name is changed. (this is also a problem on our simulator that the current simulator does not yet define such strings in a one place.) Also, the string scheduler-simulator should be used as a prefix in the future, so it would be better to handle it in c.Param(). WDYT?

Thanks @196Ikuchil ...

Yes I added some "pass-thru" convenience, that is probably unnecessary creep. It seemed useful for completeness, but I can remove those.

The hard-coded prefix "scheduler-simulator" problem... So there are 2 things going on here.

Since we put a / in our annotation names, using our prefix is handy to get all our annotations. But hard-coding is bad, so I'd probably change it to a query like: /namespaces/:namespace/pods/:name/metadata/annotations?prefix=scheduler-simulator. That would allow the scheduler-simulator filtering to work and retrieve all matches without a hard-coded prefix.
But I only wanted to do the unmarshal to our specific structure for our recognized annotations.  Well, I already added a default which tries and falls-back to the encoded string.  So I could just use that.

My understanding was that this issue wanted the unmarshal pretty stuff, but I can't guarantee all the annotations will conform.
So I can make those changes.

@sanposhiho So you want clients to use the simulator module, config some api-server that is active, and call those functions?  I guess in simulator/simulator.go?
Should the web API be abandoned?

Seems this is not the right solution.  I'll close the old PR.


Add CreateDefaultBuilder content to app secrets

Fixes #6523
@Rick-Anderson @scottaddie The samps here don't quite follow the convention we established earlier for folder naming. They exist explicitly as "1.1" and "2.1" samps, but we decided to continue with "1.x" and "2.x" folder names. If you'd like me to fix it on this PR, let me know, and I'll square it away.

@scottaddie Nevermind ... https://github.com/aspnet/Docs/pull/6488/files


usrSCTP no longer emits invalid fragmented packets with prio SS

This resolves #432

Good catch. Let me double check if other schedulers are also affected.

Two other schedulers are also affected. I checked in a fix in https://github.com/sctplab/usrsctp/commit/dc83f15ee6c7c54bb77580d88a96029c84dd43b3.
Thanks for reporting and providing a fix.


[Freeze][Resume After Silver SQL] Plot user revenues using Streamlit

Fixes #612.

I know this has been open for a while but I'm closing this until we tackle #612


Spec inconsistensy for type aliases

Specification, chapter 3.10:

An interface can be named in an extends or implements clause, but a type alias for an object type literal cannot.

This contradicts the actual behaviour seen in current Playground:

Interface cannot be used in the extends clause
Type alias can be used in the implements clause as well as an interface

Interface cannot be used in the extends clause

It can
interface A { x:number;}
interface B  extends A { y:number;}

Type alias can be used in the implements clause as well as an interface
Now it is true.

Spec now is in stale state.

You're right. I meant the extends clause for a class definition.
The following line is also misleading:

since interface types offer more capabilities they are generally preferred to type aliases

The type syntax supports mapped types, while interfaces do not
There's no way to emulate A | B using interfaces (or is there?)

Spec now is in stale state.

So is the spec going to be updated, or it is abandoned for the sake of faster development?

So is the spec going to be updated, or it is abandoned for the sake of faster development?

See https://github.com/Microsoft/TypeScript/pull/17215#issue-243137359

since interface types offer more capabilities they are generally preferred to type aliases

Type alias is like named references to any kind of type (primitive types, object types, union types, intersection types, mapped types), interface is like named reference to object type. You can't extend (in the sense of adding extensions to the existed class) class with an alias but with an interface can. Declaration merging is working for interfaces (class and interface, interface and interface) and enums, namespaces.
import {A} from "./a"

declare module './i' {
  interface A {
    f2():void;
  }
}

A.prototype.fn2 = function() {

};

By the way, spec doesn't contain that.

I believe this was a change we made where if a type reference resolves to an object type, then you can use it in an implements clause.
Thanks for reporting!

The spec is now an "archived" artifact and we won't be tracking defects against it anymore.


Implement new WebSocket protocol

What

Make initialize / close / startContext / stopContext API Promise-based
Update the logic to adhere to new, upcoming WebSocket API, with separate login step
Implement caching of auth JWT

Why
The WebSocket API is being changed to require the token passed in the subprotocol field, instead of passing in the app ID / device ID combination, thusly it is required now that the client has a separate login step.
The change to Promise-based API was discussed with some of the internal users and agreed upon.
Caching of the token is implemented to remove extra login calls.

@langma @Kaali I'm starting a new release branch for 1.0, which is why this is not targeting master, will start with 1.0.0-alpha, once this is merged.
Please let me know if you'd like me to separate Promise-related refactoring into a separate PR instead.


Fortify Scans

Need to work on Fortify scans for below:

fn-lake-segs-transformer
fn-mmg-based-transformer
fn-mmg-sql-transformer
fn-mmg-validator
fn-receiver-debatcher
fn-redactor
fn-structure-validator
lib-bumblebee
lib-cloud-proxy
lib-dex-commons
lib-nist-validator
svc-cloud-transport
mrr

Hi @mscaldas2012 I have uploaded the Scans report to Fortify SSC. Please review once.


Houdini: Moved to OpenPype

Brief description
Moved Houdini implementation into OpenPype.
Changes

moved houdini from avalon into openpype repository

Testing notes:

Houdini should work as before

Task linked: OP-2543 houdini

@BigRoy this wil simplify the development, however it might affect some opened PRs. Just a head up on that.


Improve PortSetPair

Instead of handling named ports separately in PortSetPair, add some global mapping from named ports to integers so that they are handled within the CanonicalHyperCubeSet.

Due to limited functionality of named ports, added relevant assertions , and assumptions in documentation.


ios Carousel cannot swipe 轮播图无法滑动

TuSimple/naive-ui version (版本)
2.30.4
Vue version (Vue 版本)
3.2.37
Browser and its version (浏览器及其版本)
any
System and its version (系统及其版本)
ios
Node version (Node 版本)
Reappearance link (重现链接)
https://www.naiveui.com/zh-CN/light/components/carousel
Reappearance steps (重现步骤)
use iphone to visit naive ui official page, cannot swipe.
Expected results (期望的结果)
can swipe to next and preview
Actual results (实际的结果)
swipe cannot work
Remarks (补充说明)

set draggable to true

set draggable to true

I mean IOS cannot swipe, you can reappearance it use iphone to visit official page, the slide effect cannot use on ios, even draggable.

n-data-table中flex-height设置为true， 在ios、ipad上纵向也无法滑动

n-data-table中flex-height设置为true， 在ios、ipad上纵向也无法滑动

get，周末看看，另外提一个 issue 吧

点错了


[Ideas] Ideas for vuerd in future

I would like to ask you what you think of some ideas I would like to implement. Some are very easy and same may take longer and may change some functionality of vuerd.

[x] (Idea) Have option to have diagram read-only so we could somehow show anybody how our GraphQL endpoints look like on live database

[x] Make working with VSCode extension much easier - add some better communication that can be easily expanded

[ ] [1 of 2] #212

[ ]  #213

[x]  #214

There is a readonly option. <erd-editor readonly></erd-editor>

Let's also consider upgrading the VSCode extension environment.

For communication, it would be better to use GitHub discussions.
I don't think real-time chatting will work well because I have to rely on a translator.

The vscode development environment has been improved.
$packages/vuerd yarn serve:vscode
# And
# Run Extension (vuerd-vscode)

What about generating table as HTML to put it in documentation like: Word, Confluence, etc? Maybe as Generate Template?

Hi, I would like if you add two more functions to the code generator, plural and singular so we can make code generation easier.
plural will pluralize English nouns.
singular does the opposite.

Import from DBML?

Add a way to add custom options for code generation, example am generation  a GraphQL API from vuerd json file, I would like to add sub: true to the columns I want to register them for subscriptions.

It might be possible to hide the columns so they don't show up in the visualization

I second @the729 request and maybe also import from SQL DDL.
Another thought that came up my mind is live editing a remote database visually.


How to find whether a job exist, tagged with a particular tag?

I could not find any method to get whether a job exist with a particular tag or not?
DO you guys support this use case?
I can only find a method to cancel a job, tagged with a particular tag, which is as follow
FirebaseJobDispatcher dispatcher = new FirebaseJobDispatcher(new GooglePlayDriver(mContext));
dispatcher.cancel(tag);

In April 2019 we announced that Firebase Job Dispatcher would be deprecated today, April 7th 2020.  For this reason we are going to close all open issues and archive the repository.  We will also stop supporting FJD for new app installations (such as those targeting sdk versions greater than Android Q).  Existing apps that rely on FJD should continue to function as usual.
While we will no longer work on FJD, we encourage you to migrate to Work Manager which is a superior tool and fully supported by the Android team.
Thank you for taking the time to try the library and provide this feedback.  We sincerely appreciate your effort and we apologize for not addressing it in time.


difference between iterations (-n) and deconvolution iterations (-k)

If I understand correctly, the -n flag applies to RL, VC, STC, and IY, whereas the -k flag applies to RL and VC only. What is the difference?

The reason the RL and VC methods use the -k flags and the others use -n is so that you can compound the techniques together in a single command line call. For example, if you wanted to apply IY and then VC (IY+VC), then the -n refers to the number of IY iterations and -k is the number of iterations performed during VC deconvolution.

Thanks!


a weird glitch

ok so someone took my subdomain which was still used by localtunnel which was still running and now its taken so who was it that took the most weird name for a sogebot admin page

Hey @Sonic4Tails . This does seem like a weird issue. Are you sure the subdomain was still in use? Also, have you tried uninstalling localtunnel and installing it again? Because this was one of the earlier issues that if say one was using a localtunnel and it crashed for whatever reason, one was not able to reuse the same subdomain for a couple of hours. This issue is now fixed so, please uninstall and install the latest version again.

I'm wondering how "fixed" it is, since it didn't crash, I just terminated the process with ^C and now my chosen subdomain seems to be unavailable.
lt --version
2.0.2
node -v
v16.15.0

I just installed it today.

This seems weird. It does work for me. What operating system are you on? Also, are you sure you did ctrl + c and not ctrl + z?

This seems weird. It does work for me. What operating system are you on? Also, are you sure you did ctrl + c and not ctrl + z?

MacOS 12 something

I think this might be fixed now. if your subdomain is still unavailable you might have to wait up to 30s for the socket to timeout and release the domain.
closing this for now but lmk if it's still happening (even after waiting 30s)


linuxKernel.kernels: update (2021-12-13)

linux: 4.14.258 -> 4.14.259
linux: 4.19.221 -> 4.19.222
linux: 4.4.295 -> 4.4.296
linux: 4.9.293 -> 4.9.294
linux: 5.10.87 -> 5.10.88
linux: 5.15.10 -> 5.15.11
linux: 5.4.167 -> 5.4.168
linux-rt_5_10: 5.10.83-rt58 -> 5.10.87-rt59
linux_latest-libre: 18484 -> 18517

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

https://github.com/NixOS/nixpkgs/pull/151792


Wrong order of the difficulty node in explorer

Should be Easy -> Medium -> Hard

How about adding an All problem list, maybe there are some one like me who want to solve the problems in order?

@taoweicn Sure, please feel free to create an issue for it


fizz: 2<IP_ADDRESS> -> 2<IP_ADDRESS>

Diff: https://github.com/facebookincubator/fizz/compare/refs/tags/v2<IP_ADDRESS>...v2<IP_ADDRESS>
Changelog: https://github.com/facebookincubator/fizz/releases/tag/v2<IP_ADDRESS>
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 223152 run on x86_64-linux 1

11 packages built:

buck
fb303
fbthrift
fizz
python310Packages.pywatchman
python310Packages.pywatchman.dist
python311Packages.pywatchman
python311Packages.pywatchman.dist
rs-git-fsmonitor
wangle
watchman


NPM packages with namespaces from ReversingLabs don't have namespace in name.

As at the time of reporting the number is 232 in NPM.
For example @zettle-bo/react is listed as react.

I will pause the reversing labs ingestion to ensure no new data is ingested until we have confirmed a fix.
Errant reports can either be corrected (moved to the correct location) in the case that the report doesn't yet exist, or withdrawn if the do.

@rhalar

fwiw it looks like https://osv.dev/vulnerability/MAL-2024-3239 is also a result of this - it would be good to know how we can get these invalid advisories cleared since they're being flagged by the scanner.
I also wonder if osv.dev should be doing some validation around the PURLs as it sounds like they're invalid so maybe the affected field or the whole advisory be rejected rather than ingested?

False positives and data problems have been resolved. Some Reversing Labs reports need to be re-added, but that is less urgent.

Hey,
to clarify for anyone affected or following this issue, I work for ReversingLabs and am 'in charge' for exposing our advisories, and as such responsible for this mess :)
I contacted Caleb and we will resolve the source of the problem very soon, to avoid any further problems with the data we expose.
I'd like to apologize for any alarms this may have triggered, it was a dumb oversight we should have caught, and I take the full blame for it.
A huge shutout and thanks to @calebbrown for doing damage control and reacting so quickly.
Our security researchers work hard and do a great job at finding malicious packages across multiple ecosystems, I hate to see their work besmirched by what is essentially a conversion error by my side; we'll make sure this doesn't happen again.
It's not the best first impression but we are very excited by this collaboration, and hope to continually contribute to the OSSF going forward.

The data fixing is now complete. I will close this issue once I have un-paused the reversing-labs source in the config.

Hi @calebbrown . It looks like some packages are missing from the "withdrawn" list, such as NPM qs (osv) or NPM angular (osv). Both of these were reverted because of this issue but they were not added to the withdrawn directory, which is causing some inconsistencies in our systems.

@lujunsan I have fixed the summaries as well. Those reports are now clearly for @ozon-shared-deps/qs and @maia-web/angular.
Is your issue that the OSV files now point to different packages, despite previously pointing at angular and qs?

Hi @calebbrown . I was under the impression that these packages that were at some point marked as malicious but later fixed should also be added to the "withdrawn" list, same as what was done for react: https://github.com/ossf/malicious-packages/blob/main/osv/withdrawn/npm/react/MAL-2024-2929.json
Is this not accurate? Like you say, the reports for those packages are correct now (and thanks for regenerating the summaries!), nothing to change there; I was just expecting to also find those fixed packages with entries in the withdrawn list, but I may have misunderstood the process.

Hi @lujunsan, the problem that was corrected was that the purl field differed to the name of the package for NPM packages with a namespace.
Since it was ambiguous which package was being reported as malicious, for packages which did not have an existing report, it was decided to fix the ambiguity and move the report into the correct path, rather than withdrawing the report.
This means the MAL-* IDs are now pointing to the correct package so it is not possible to add a withdrawn report for the same IDs.
As far as I'm aware (and I plan to confirm this with the OSV team) OSV reports are designed to be mutable so they can be extended and corrected as needed. This should mean that this type of change should be okay to make.


The update to socket2 v0.4 raised the MSRV to 1.46

CI didn't catch it because MSRV is tested only with default features.
$ cargo +1.45.2 c --features tcp
    Checking socket2 v0.4.0
    Checking tokio v1.4.0
error[E0658]: `match` is not allowed in a `const fn`
   --> /.cargo/registry/src/github.com-1ecc6299db9ec823/socket2-0.4.0/src/lib.rs:156:9
    |
156 | /         match address {
157 | |             SocketAddr::V4(_) => Domain::IPV4,
158 | |             SocketAddr::V6(_) => Domain::IPV6,
159 | |         }
    | |_________^
    |
    = note: see issue #49146 <https://github.com/rust-lang/rust/issues/49146> for more information

Oh shucks. Probably need to revert that commit for now, unless socket2 can reduce it's dependent features, but I doubt it.
cc @Thomasdezeeuw

I'm afraid socket2's MSRV can't easily be lowered. Rust 1.46 was released August 27th, if that isn't old enough then I guess it needs to be reverted.

You could just pin socket2 v0.3 for now? v0.3.X is still actively maintained in a separate branch, afaik.

You could just pin socket2 v0.3 for now? v0.3.X is still actively maintained in a separate branch, afaik.

v0.3 is still being maintained, but I prefer the ecosystem to move to v0.4.

Fair! Works for me with Rust 1.50, but not 1.49, fwiw..

@johanot are you sure? Socket2 should work with 1.46 and up.

Ok, that's embarrassing. My shell environment was polluted. Can confirm it works fine with 1.49 as well. Sorry, don't mind me :)

That's a fair point, we've mostly adopted Tokio's policy of working on rustc at least 6 months old. It could be the answer is just bump CI.

I could send a pr to bump the MSRV to 1.46. @nickelc do you need 1.45 support?

I could send a pr to bump the MSRV to 1.46. @nickelc do you need 1.45 support?

no, i only noticed the issue.

Created #2486 to increase the MSRV.

hi folks, this issue unfortunately affects the MSRV of downstream crates as well. in my case, both the oauth2 and openidconnect crates (that I maintain) had their MSRV broken by this change. would it be possible to revert this and bump hyper to 0.15 so that the MSRV follows semver?

Although I'm not opposed this, not that I'm making that call. But it's still under active discussion whether or not bumping MSRV is a breaking semver change. Especially past 1.0 that wouldn't make sense IMO.


Why was the entire image redrawn? BrushNet_basic workflow

blend inpaint PLZ

BrushNet is not working. Post your ComfyUI log, please.

The logs are gone, rolled back the version and was able to complete the repaint

That is probably due to precision change. Some setups have problems with that. I am working on it right now.

I just added dtype switch to BrushNet Loader node. Try it now, change if you have problems.

I just added dtype switch to BrushNet Loader node. Try it now, change if you have problems.

Looks like the issue persists

Can you post a log, please?

I just added dtype switch to BrushNet Loader node. Try it now, change if you have problems.我刚刚在 BrushNet Loader 节点中添加了 dtype 开关。现在就试试吧，如果有问题，请更改。

solove my problem

Can you post a log, please?

I update the plugin to latest commit, and use example/BrushNet_SDXL_basic.json，result is as follows：
(base) PS E:\ComfyUI-work\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-BrushNet> git log
commit afe771460159e835e50d53506f9b8ecfaa489cb8 (HEAD -> main, origin/main, origin/HEAD)
Author: nullquant<EMAIL_ADDRESS>Date:   Tue May 7 18:00:20 2024 +0300

    dtype switch

got prompt
[rgthree] Using rgthree's optimized recursive execution.
[rgthree] First run patching recursive_output_delete_if_changed and recursive_will_execute.
[rgthree] Note: If execution seems broken due to forward ComfyUI changes, you can disable the optimization from rgthree settings in ComfyUI.
model_type EPS
Using xformers attention in VAE
Using xformers attention in VAE
clip missing: ['clip_l.logit_scale', 'clip_l.transformer.text_projection.weight', 'clip_g.logit_scale']
#47 [CheckpointLoaderSimple]: 9.98s
#58 [LoadImage]: 0.06s
BrushNet model type: Loading SDXL
BrushNet model file: E:\ComfyUI-work\ComfyUI_windows_portable\ComfyUI\models\inpaint\brushnet\segmentation_mask_brushnet_ckpt_sdxl_v0\diffusion_pytorch_model.safetensors
BrushNet SDXL model is loaded
#45 [BrushNetLoader]: 1.38s
Requested to load SDXLClipModel
Loading 1 new model
#49 [CLIPTextEncode]: 1.23s
#50 [CLIPTextEncode]: 0.06s
Base model type: SDXL
BrushNet image, torch.Size([1, 1024, 1024, 3])
Requested to load AutoencoderKL
Loading 1 new model
BrushNet CL: image_latents shape = torch.Size([2, 4, 128, 128]) interpolated_mask shape = torch.Size([2, 1, 128, 128])
#61 [BrushNet]: 1.77s
Requested to load SDXL
Loading 1 new model
  0%|                                                                                | 0/20 [00:00<?, ?it/s]BrushNet inference: sample torch.Size([2, 4, 128, 128]) , CL torch.Size([1, 5, 128, 128])
BrushNet inference: do_classifier_free_guidance is True
BrushNet inference: sample torch.Size([2, 4, 128, 128]) , CL torch.Size([2, 5, 128, 128])
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 20/20 [00:11<00:00,  1.67it/s]
#52 [KSampler]: 12.81s
#54 [VAEDecode]: 0.69s
#12 [PreviewImage]: 0.13s
Prompt executed in 28.25 seconds

@chflame163 Ohh, now I see it! Please, change ent_at parameter in BrushNet node to 100, for example.

Yes , I modified here as you said and now it works fine. Thanks.

Due to this parameter BrushNet applied only to 1st and second iteration steps only. BTW, playing with these you can achieve some interesting results. I will update examples, sorry for inconvenience.

Due to this parameter BrushNet applied only to 1st and second iteration steps only. BTW, playing with these you can achieve some interesting results. I will update examples, sorry for inconvenience.

Interesting, looking forward to updating example：）Thank you excllent job!

@chflame163 Ohh, now I see it! Please, change ent_at parameter in BrushNet node to 100, for example.
'end_at' 100 It's good

Due to this parameter BrushNet applied only to 1st and second iteration steps only. BTW, playing with these you can achieve some interesting results. I will update examples, sorry for inconvenience.

What does end _ at mean here? I see that this number can be adjusted very high, but I have tried 100 to 1000 and there is no difference in the final image.

This parameter sets end step at which to apply BrushNet. Try set it a bit less than your steps in KSampler.

This parameter sets end step at which to apply BrushNet. Try set it a bit less than your steps in KSampler.

Got it, Thanks.


Refactor some organization settings related code.

This PR does some preparatory refactors for #21739.

First commit just changes the variable name as discussed here.
Second and third commits updates the id and name attributes of setting elements, so that we can remove extra code in further commits.
Fourth commit changes time_limit_dropdown_values to a list to make it similar to the options list for notification batching period setting.
Fifth commit is for extracting the code for showing and hiding custom input in a separate function.
Sixth commit is for sending only updated settings in the API request data for message edit subsection.
Seventh commit is to show save-discard widget only after custom input value is changed.
Eigth commit is to extract code to set the msg edit and limit setting elements into a separate function.
Last two commits are to refactor the code for realm-level default of email notification batching period setting such that we do not handle this setting as a special case.

Screenshots and screen captures:
Only user-facing changes are that the save-discard button is shown only after custom input is changed and also the flashing of save changes button mentioned in this comment is fixed.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

I think it would take at least one more refactoring and then I can move forward with the remaining work of #21739. The refactoring I am talking about is for this code where we send all the three settings in event data and the api response irrespective of whether all the three settings are actually changed or not. edit_topic_policy setting would at least be independent when we implent the third bullet point of Who can edit topics heading in #21739, so we can definitely move it out. And since we have made the edit time limit setting and allow_message_editing setting independent in frontend, we can probably refactor this code to send only the changed setting in event data and api response.

That seems plausible regarding that API detail; can you start an api design conversation about it? We'll want to get the mobile/terminal folks input on that API change.

I gave this a careful read and all the changes look correct to me; posted a few small comments on readability details. @alya can you review it as well?

Added comments as asked above and also fixed the typo.
Regarding this change, previously when changing setting from Anytime to Custom the save-discard widget was hidden initially and then shown only when I type a valid input and was hidden when I type invalid input like alphabets. But since input value is actually changed, I changed it to show the save-discard widget also when the input is invalid and keep the save button disabled. The behavior after this change is shown below -

Hm, how are we validating the custom fields? I don't think it's quite working right:

Clicking "Save changes" in this state sets the time limit to 2 minutes.

Otherwise looks good to me!

Added two commits to fix two things.

First commit is to fix the bug mentioned by Alya above.

Second commit is to actually show the save-discard widget when input is invalid (like in the first case where it starts with number but is followed with alphabets) but with save button disabled.

This is great, merged, thanks @sahil839!


CSV performance

Following up from a (incorrect) issue on IJulia, what are the main constraints on performance - starting with readtable?
How much is going to be tuning DataFrames, and how much requires improvements in optimization smarts in julia in general?
Coming from Pandas I'm finding the performance is an order higher than what I'm used to - I need to find a solution to this :)

CSV.jl and TextParse.jl are both very fast csv parsing packages. readtable has been deprecated. Feel free to open issues at those packages for specific performance issues.


Update DG: Feature Implementation: Slideshow feature

Description

TODO:

[ ] Class diagrams for Slideshow and SlideshowApp
[ ] Perhaps one more sequence diagram for AnswerCommand

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code quality improvements

How to test

Checklist

[ ] I have written testcases to cover all new methods
[ ] I have built and manually tested this code
[ ] I have updated the User Guide
[ ] I have updated the Developer Guide
[ ] I have updated my individual project portfolio
[ ] I have included a preview deployment link to the updated project documentation

Codecov Report

Merging #199 (9b7bfdf) into master (2c816e2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #199   +/-   ##
=========================================
  Coverage     72.24%   72.24%
  Complexity      542      542
=========================================
  Files            93       93
  Lines          1762     1762
  Branches        195      195
=========================================
  Hits           1273     1273
  Misses          437      437
  Partials         52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c816e2...9b7bfdf. Read the comment docs.


Add Power models to lib-dmtf package

Add Port models to lib-dmtf package

closing the issue based on the #517  pr


Fix flags to be proper bitmasks and add no-CRC flag

The NO_CRC32 flag indicates that the file header or chunk has no checksums computed for it, and is expected to be fixed at 0. Files with this flag set can be found in the system32\winevt\Logs folder on new-ish Windows Insider builds. Logs that have been exported via wevtutil.exe have the flag removed and the checksums computed as part of the export.

Awesome! Just add a test for this new file in tests/test_full_samples.rs

Thanks a lot for this :)


tenacity.RetryError: RetryError[<Future at 0x1fa21db8190 state=finished raised APIConnectionError>]

It seems that the program cannot connect to openai, but I can access GPT4 locally.

Please refer to faq8 https://deepwisdom.feishu.cn/wiki/MsGnwQBjiif9c3koSJNcYaoSnu4
Or try the cloud environment https://deepwisdom.feishu.cn/wiki/CyY9wdJc4iNqArku3Lncl4v8n2b

Thanks a lot! solved with OPENAI_API_BASE = "https://api.openai-forward.com/v1"

tenacity.RetryError: RetryError[<Future at 0x1d829ab8a10 state=finished raised AuthenticationError>] How to solve this error?


Get AddressRange & ContractRange

Currently this PR only covers AddressRange, ContractRange is mostly based upon the AddressRange. Will be adding ContractRange after the tests and correcting the implementation if needed.
This is mostly based this branch

why is the child hash logic change?

Also, how much of this code is Ashraf's?

Also, how much of this code is Ashraf's?

Most of code is based on Ashraf's work (the branch I added in description)
I have fixed it work of new ProofNode definitions, fixed few Todo's. I have to write tests also


Code questions regarding _getBeaconBlockRoot

I have two questions for the following code:

In the comment, did you mean we get the beacon block root for block N - 1 or we get the beacon block root for block N + 1?
shall we check timestamp is a multiple of 12?

   /**
     * @notice Retrieves the beacon block root for the block at the specified timestamp
     */
    function _getBeaconBlockRoot(uint256 timestamp) private view returns (bytes32) {
        // At block N, we get the beacon block root for block N - 1. So, to get the block root of the Nth block,
        // we query the root at block N + 1. If N + 1 is a missed slot, we keep querying until we find a block N + x
        // that has the block root for Nth block.
        uint256 targetTimestamp = timestamp + SECONDS_IN_SLOT;
        while (true) {
            (bool success, bytes memory result) = beaconBlockRootContract.staticcall(abi.encode(targetTimestamp));
            if (success && result.length > 0) {
                return abi.decode(result, (bytes32));
            }

            unchecked {
                targetTimestamp += SECONDS_IN_SLOT;
            }
        }
        return bytes32(0);
    }

In the _updateLookahead function's for-loop, should slotTimestamp <= prevSlotTimestamp be added into the check below
if ((slotTimestamp - nextEpochTimestamp) % 12 != 0 || slotTimestamp >= nextEpochEndTimestamp) {
  revert IPreconfTaskManager.InvalidSlotTimestamp();
}

Another question that I'm trying to figure out (still reading the code) is: what if the proposer provided a empty lookaheadSetParams list for _updateLookahead, will that be slashable?

I have two questions for the following code:

In the comment, did you mean we get the beacon block root for block N - 1 or we get the beacon block root for block N + 1?
shall we check timestamp is a multiple of 12?

   /**
     * @notice Retrieves the beacon block root for the block at the specified timestamp
     */
    function _getBeaconBlockRoot(uint256 timestamp) private view returns (bytes32) {
        // At block N, we get the beacon block root for block N - 1. So, to get the block root of the Nth block,
        // we query the root at block N + 1. If N + 1 is a missed slot, we keep querying until we find a block N + x
        // that has the block root for Nth block.
        uint256 targetTimestamp = timestamp + SECONDS_IN_SLOT;
        while (true) {
            (bool success, bytes memory result) = beaconBlockRootContract.staticcall(abi.encode(targetTimestamp));
            if (success && result.length > 0) {
                return abi.decode(result, (bytes32));
            }

            unchecked {
                targetTimestamp += SECONDS_IN_SLOT;
            }
        }
        return bytes32(0);
    }

The beacon state contract only provides beacon block roots for past blocks, so at block N we may get the roots of up to block N - 1 (this is equivalent to saying that at block N + 1, we get the roots up to block N).

So, to be specific, in the contract's context, if we intend to find the beacon proposer of block N, we can only query it within (or starting from) block N + 1.

The beacon state contract reverts if we do not pass a valid slot timestamp. Also, in general, a multiple of 12 check would not work since the genesis beacon block on Ethereum was at<PHONE_NUMBER> which is not a multiple of 12.