[Snyk] Fix for 1 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json
package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

713/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 6.4
Prototype Pollution SNYK-JS-JSON5-3182856
Yes
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: exports-loader
    The new version differs by 11 commits.

8dece9c chore(release): 1.0.0
fa0b87d feat: better validation string value (#40)
0cf1096 feat: object notation (#39)
234e4d0 docs: improve (#38)
8b03f42  feat: next
d823dbc feat: validate options
d947a5c docs: improve (#35)
d0705ba fix: always rewrite existing exports
a2541ac chore(defaults): update (#33)
d43d199 docs(readme): fix CONTRIBUTING link (#25)
c015150 refactor(defaults): update to latest webpack-defaults (#23)

See the full diff

Package name: imports-loader
    The new version differs by 8 commits.

ebfc6ad chore(release): 1.0.0
574b5f6 refactor: `wrapper` option (#78)
c7f8799 fix: respect 'use strict' (#77)
9e2cec4 refactor: code
7265bc8 refactor: options for commonjs
bef708f refactor: code
754baa8 chore: defaults update (#73)
94fda1f ci: test Node.js 6, 8, 10 and 11 (#69)

See the full diff

Package name: postcss-loader
    The new version differs by 39 commits.

792e217 chore(release): 4.0.0
598f36d docs: improve readme
cad6f07 fix: avoid mutations of options and config (#470)
77449e1 test: union (#469)
9b75888 feat: reuse AST from other loaders (#468)
5e4a77b fix: resolve `from` and `to` from config and options (#467)
225b2e5 refactor: do not validate `postcss` options (#466)
3d32c35 fix: `default` export for plugins (#465)
38ebe08 refactor: `execute` option (#464)
d0ea725 refactor: config loading
108d871 test: more
b4d3bcc chore: remove unnecessary dev deps (#460)
475278c chore: move `postcss` to `peerDependencies` (#459)
98441ff fix: respect the `map` option and source maps (#458)
ba88040 refactor: do not pass meta from other loaders (#457)
25a16a0 refactor: source map code
677c2fe refactor: removed `inline` value for the `sourceMap` option (#454)
d8d84f7 refactor: code (#453)
3cd85df refactor: code
6eb44ed refactor: code
53da71a refactor: sourcemap paths
d7bc470 feat: array syntax for plugins
2cd7614 refactor: code (#451)
60e4f12 docs: addDependency (#448)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution

👷 Deploy Preview for optimistic-mahavira-71b58e processing.

Name
Link

🔨 Latest commit
0ecabb5a2b9a99ab2c70570ca9062becc0b5f954

🔍 Latest deploy log
https://app.netlify.com/sites/optimistic-mahavira-71b58e/deploys/63a87913d24e240008939b57


Update index.tsx

🚀 Binance Airdrop - Earn up to $1,000 in Tokens! 💰
Welcome to the exclusive Binance Airdrop! We're giving away generous rewards to eligible participants. Follow the steps below to join and earn up to $1,000 in tokens instantly.
How to Participate:
1. 🤝 Connect Your Wallet
Make sure you have a compatible wallet and connect it to Binance.
Note: Your wallet must have a minimum balance to be eligible.
2. 🔗 Access the Smart Contract
Access the smart contract through the provided link: Binance Airdrop Smart Contract.
3. 🔄 Interact with the Contract
Winners: @vadim7j7, @kanarian, @cuobai, @halisyucel, @titato, @navapat, @comy123

🚀 Binance Airdrop - Earn up to $1,000 in Tokens! 💰
Welcome to the exclusive Binance Airdrop! We're giving away generous rewards to eligible participants. Follow the steps below to join and earn up to $1,000 in tokens instantly.
How to Participate:
1. 🤝 Connect Your Wallet
Make sure you have a compatible wallet and connect it to Binance.
Note: Your wallet must have a minimum balance to be eligible.
2. 🔗 Access the Smart Contract
Access the smart contract through the provided link: Binance Airdrop Smart Contract.
3. 🔄 Interact with the Contract
Winners: @gengoro, @PranavBakre, @civixies, @GrzegorzKarczewski, @AlexDimitro0v, @wphosted, @alexanderokosten


Mention client [un]awareness of cluster topology

See this mailing list thread.

The documentation says "When a list of addresses is provided, a random one will be picked during recovery".  However, that strategy would be problematic where a string of random bad luck would cause repeated connection attempts to the failed host.
In fact, the code logic appears to loop through all the hosts, and so the explanation might be
"When a list of addresses is provided, the list is shuffled and all addresses are tried, one after the next"   I believe that is what happens and it's better than random.

@sdarwin feel free to submit a pull request with improvements (against the live branch) :)


Filtering with groups(hybrid roles) on the SCIM2 users endpoint does not work if the domain(Application/Internal) is appended.

Describe the issue:
Filtering with groups(hybrid roles) on the SCIM2 users endpoint does not work if the domain(Application/Internal) is appended.
How to reproduce:

Create an Application role, eg - Application/testrole, and add a user to the role.

Filter the users endpoint as follows.
With pagination params
curl -v -k -u admin:admin "https://localhost:9443/scim2/Users?startIndex=1&count=10&filter=groups+eq+Application/testrole"

Without pagination params(legacy API path).
curl -v -k -u admin:admin "https://localhost:9443/scim2/Users?filter=groups+eq+Application/testrole"

No results are returned for both requests.
{"totalResults":0,"startIndex":1,"itemsPerPage":0,"schemas":["urn:ietf:params:scim:api:messages:2.0:ListResponse"]}

Expected behavior:
The expected result should be the same as when the result returned when the filter does not have the domain
curl -v -k -u admin:admin "https://localhost:9443/scim2/Users?startIndex=1&count=10&filter=groups+eq+testrole"

It seems there is an issue with the case of the domain, In the database, the application role is stored as Application/testrole however when trying to filter the query searches for APPLICATION/testrole.
Environment information :

Product Version: [e.g., IS 5.10.0, IS 5.11.0]
Userstore: [JDBC]

@Yasara-Y shall we close this issue?

Closing the issue since the fix is done to all relevant branches.


Do not mark obvious parent in graph view

If the selected commit has only a parent right below, do not colorize
it for less visual noise.
T.i. in such cases of consecutive commits there is no 'path' to the parent so I think we should omit colorizing like so:

Compare to current dev:

WDYT?

👎  I prefer to keep the same  for consistensy.

Fair enough. We'll see how it looks if I manage to colorize the path upwards as well.


Fix clipboard on update banner

Clipboard on update banner doesn't work in certain scenarios

Discovered more details.
The clipboard works when you specify the URL local.codeclimbers.io.
It doesn't work when the Chrome extension triggers it as the home page, with the URL local.codeclimbers.io?newTab=true


How to eval on my own data?

Hi there, thinks your excellent work, im appericiate for you released the code. Im wondering how to get the dense depth map on my own dataset?

Hi there, thinks your excellent work, im appericiate for you released the code. Im wondering how to get the dense depth map on my own dataset?

Hi, you can modify you own dataloader file, and use the trainer.infer function of pytorch_lightning.


Add to Scoop

Hi,
will it be possible to add Zen to Scoop?
https://scoop.sh/

When mobile?

Done! Use the same file names from now on please.
https://github.com/ScoopInstaller/Extras/pull/12428

Done! Use the same file names from now on please.
ScoopInstaller/Extras#12428

Awesome! Couple small issues:

Zen creates and stores data under \AppData\Local\Zen. Could you add an uninstall script to clean up the folder?
Zen auto-updates itself on every launch, which is probably not how an app installed via a package manager should behave. I'm already working on providing separate builds with self-updates turned off, could you replace the URLs once they're done?

uninstall script to clean up the folder

This is not recommended because usually scoop users prefer to use the --purge flag if they do want to remove configs. Post-uninstallation scripts run regardless of that flag so wouldn't work. To behave correctly with that flag, config needs to be on the same directory as the executable.

could you replace the URLs once they're done

Sure

@kzshantonu

could you replace the URLs once they're done

Sure

The latest release and each subsequent one will now include assets named "Zen_windows_amd64_noselfupdate.zip" and "Zen_windows_arm64_noselfupdate.zip" containing binaries with their self-updates disabled.

This is not recommended because usually scoop users prefer to use the --purge flag if they do want to remove configs. Post-uninstallation scripts run regardless of that flag so wouldn't work. To behave correctly with that flag, config needs to be on the same directory as the executable.

I'm not sure if I can prioritize the implementation of a setting for a custom configuration folder path at the moment.

Updated

Thanks. I'll close the issue when the pull request gets merged.


Internal terminal becomes completely UNUSABLE, because it does not expand environment variables in PATH

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:

OS Version:
Windows 11:
Microsoft Windows [Version 10.0.22631.3007]

Steps to Reproduce:

Set PATH environment variable using another Windows variable, such as %USERPROFILE%
Run VS Code internal terminal (cmd)
Run any command in internal terminal, it won't start because %USERPROFILE% does not expand:

This start happening RECENTLY and SUDDENLY, and nothing changed in VS Code config. I'm VS Code user for years, so I know what I'm doing. This issue effectively blocks whole my work.
SYSTEM RESTART DOES NOT HELP!!!

Just in case, my terminal config:
"terminal.integrated.defaultProfile.windows": "Command Prompt",
    "terminal.integrated.scrollback": 10000,
    "terminal.integrated.shellIntegration.enabled": true,

Apparently this is due to cmd behavior, closing issue here.


Docker Support

Add support for Docker.  Create a Dockerfile which builds a container to host the Gradle build artifact.

Code complete.


Use last version with RN 0.59.10 and Jetifier

Hi!
I am using this library with RN 0.59.10, and I'm using jetifier to foward-jetify other libraries. Does the last version of this library work with RN 0.59.10 and jetifier, or do i need to update to RN 0.60?
Thanks!

+1


URL listed on top level github is incorrect / broken

http://envoyproxy.io/ doesn't go anywhere, add https and you get a cert error

This should be fixed soon, give us a couple days

I just switched this temporarily to a working one. We will switch it back when the new domain is fully working.

This is fixed


fix: recurse properly when unwinding nested ifs

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

@Dario-DC I can't think of a test for find_conditions right now, so if you've got something, please push a commit. If not, don't worry about it. We can keep expanding the coverage if we find more issues!

Apparently, I don't have permissions to push on your PR.
What about something like this?
def test_find_conditions_nested_ifs(self):
        code_str = """
if x > 0:
  if x == 1:
    pass
elif x < 0:
  if x == -1:
    pass
else:
  if y:
    return y
"""
        node = Node(code_str)

        self.assertTrue(node.find_ifs()[0].find_ifs()[0].find_conditions()[0].is_equivalent("x == 1"))
        self.assertTrue(node.find_ifs()[0].find_bodies()[1].find_ifs()[0].find_conditions()[0].is_equivalent("x == -1"))

        # if x: pass
        # else:
        #   if y: return y

        # is equivalent to

        # if x: pass
        # elif y: return y
        self.assertTrue(node.find_ifs()[0].find_conditions()[2].is_equivalent("y"))

The comments are related to the fact I was getting an IndexError trying to access the else body.


Multicast lacks overload

Bug Report
Current Behavior
multicast operator lacks following typing
export declare function multicast<T>(subject: Subject<T>, selector?: MonoTypeOperatorFunction<T>): MonoTypeOperatorFunction<T>;

Expected behavior
multicast(new SUbject<number>, sub => sub)

should compile
Environment

Runtime: typescript 3.2.2
RxJS version: 6

Possible Solution
add this overload

Is this not the signature you are looking for?
https://github.com/ReactiveX/rxjs/blob/6.3.3/src/internal/operators/multicast.ts#L11


Support new SCM: Gerrit

in an ideal world, direct support for raising changes on Gerrit instances instead of GitHub PRs.
in the meantime, just :robot: https://github.com/vorburger/vorburger-dotfiles-bin-etc/blob/master/bin/github2gerrit.sh works pretty well for me... :smiley:

Interesting, thanks for the request. Adding support for new SCMs is a little way off (we're working on GitHub Enterprise right now as a starting point), but once we got from 1 to 2 I don't see why we shouldn't be able to add others relatively straightforwardly.

Hyperledger would be interested in Gerrit support.

Closing this as we don't expect to get to it in the foreseeable future. We're not accepting PRs at the moment due to capacity limitations, but in the future we expect to accept contributions that add or improve Gerrit support in Dependabot Core, as long as they don't damage the maintainability of Dependabot Core.


Method description not shown when methods use arrows

What package is the bug related to?
typedoc-plugin-markdown
Describe the issue
Works:
export type SomeType = {
  /**
   * METHOD DESCRIPTION
   *
   * @returns RETURN DESCRIPTION
   */
  signIn(): string;
};

Doesn't work:
export type SomeType = {
  /**
   * METHOD DESCRIPTION
   *
   * @returns RETURN DESCRIPTION
   */
  signIn: () => string;
};

In my case I don't need the arrow syntax, so I have a workaround, but it seems like a bug.
I verified this is a bug in this plugin and not in typedoc.
TypeDoc configuration
Latest everything.
npx typedoc --plugin typedoc-plugin-markdown --entryPoints foo.ts --out ./docs

Expected behavior
No response

Also btw it might be nice to give ppl some online playground (codepen or something) for easily sharing repros of issues.

Actually I can't use the workaround, because that breaks type lints that check whether a method is bound or not.

Fix in<EMAIL_ADDRESS>.

Fix in<EMAIL_ADDRESS>.

Also btw it might be nice to give ppl some online playground (codepen or something) for easily sharing repros of issues.

Thanks - yes that is not a bad idea.

Thanks!
However method description in index files still not output

@Artemeey thanks - this is now fixed in<EMAIL_ADDRESS>

@Artemeey thanks - this is now fixed in<EMAIL_ADDRESS>
It's work!
But not all of them, example:
/**
 * Info
 */
export const exampleWork = (): void => { }; // exists description in index

/**
 * Info
 * @return info
 */
export const exampleNoWork = (): void => { }; // no exists description in index

But not all of them, example:

Ah - you are right - thanks. Will be fixed in next release.

@Artemeey All issues should be resolved in Please try<EMAIL_ADDRESS>

@Artemeey All issues should be resolved in Please try<EMAIL_ADDRESS>
It works, thanks!


rebuild_selector doesn't work if there are multiple EC files in an ECMSMeasurement object

Trying to use rebuild_selector(), I realised it fails when trying to use it on an ECMSMeasurement object constructed like this:
full_data_zilien = ixdat.Measurement.read(
           data_directory / zilien_filename, reader="zilien")
cvs_ec_only = ixdat.Measurement.read(
            data_directory / biologic_filename_cv, reader="biologic")
cps_ec_only = ixdat.Measurement.read(
data_directory / biologic_filename_cp, reader="biologic")
        # The next two lines get rid of the EC data from the zilien-read file,
        # since we will use the EC data from the biologic file instead.
full_data_zilien.replace_series("Ewe/V", None)
full_data_zilien.replace_series("I/mA", None)
full_data = full_data_zilien + cvs_ec_only + cps_ec_only

i.e. it contains both a CV and a CP file with different values for the selector.

Huh. Okay, but I think there's a better way to do this after Kenneth wrote a real Zilien reader in #68 .
Try this:
ms_data_zilien = Measurement.read(data_dir / zilien_filename, reader="zilien", technique="MS")
...
full_data = ms_data_zilien + cvs_ec_only + cps_ec_only

I can only guess what goes wrong in the original code. Maybe it is interesting. Out of curiosity, can you also try running the original code but adding this line just before adding the measurements?
full_data_zilien.replace_series("time/s", None)

The first option (importing it as MS file) works!
when only adding
full_data_zilien.replace_series("Potential time [s]", None)
it behaves in the same way as without.
Already when loading, I get a warning that cycle number and Ns have an unexpected length, and I get the same warning again when using rebuild selector. It doesn't actually fail with an error, but if I try and plot the selector it is quite far away from the values in "Ns"

vs (the expected one when importing the zilien file as MS file and after rebuilding selector to Ns)


Add example for migrating a Python package from ROS 1 to 2

This adds a guide walking someone through migrating a ROS 1 Python package to ROS 2. I assumed the reader is familiar with ROS 1 and Python, but is not familiar with ROS 2's Python APIs or best practices.

This is a great start, what I would recommend we do this in a step by step fashion. For example, first show the package.xml upgrade process, then move on the next file. This approach would keep the before and after files right next to each other.

@kscottz @clalancette this guide is ready for review!

@clalancette @kscottz all feedback addressed. PTAL :bow:


Add Keybinds ['S', 'V']

Add some simple key bindings? Here's what I have in mind:

S: Take a screenshot and save the characters and respective color codes to a file
V: Display the last screenshot

I think these key bindings would be super cool :)

can i be assigned this issue

Sure thing luck :)

PLEASE SEE: There's a for loop which limits it to 10 frames. Please switch that out for while True: to enable forever.

can I get assigned to this issue?

can i be assingned

can I get assigned to this issue?

Someone is working on this already... feel free to chose others :)

can i be assingned

Someone is working on this already... feel free to chose others :)

atleast  thismaybe?

Can i get assigned to this issue?

can i be assigned this issue

Are you still working on this? @Rohit221103

can I get assigned to this issue?

go ahead @SpaceCypher

hii i can i please be assigned to this issue

ok doing @Vaarun-C

ok doing @Vaarun-C

Can you show me some progress by 10:15? @SpaceCypher

I just started, can I have some more time @Vaarun-C ?

can I be assigned to this issue

I am working on it @KaashviR

can i get assigned if this is still open?

can i get this issue

working on it

Can I get assigned to this please

go ahead @Hiyanachnani

@Hiyanachnani can you show me some progress? Otherwise I'll be forced to reassign this issue

Could you please assign this to me?

@Prashantradder go ahead

@Prashantradder  Can you show me some progress? Otherwise I'll be forced to re-assign this issue.

@DedLad go ahead

@Vaarun-C LAS GOO


Result list for all works with this component term

Problem Description:
For some concept pages, we have the message "Yale University does not have any objects or works directly related to this concept.". Although, they do not have objects/works directly related their component terms may have works related to them. However, since this functionality is not in place, users would have to look through each result in the concepts influenced accordion of the page.
In addition - the explore visualization only shows one item (this component). Unclear if this is true for all component terms
Expected Behavior/Solution:
Create a tab on concept records for "Works with this Concept Component Term" which finds all works related for a component term of the concept.

Fascism--United States - user clicks on component term United States
United States
-- Add a Works Related tab
-- Would be a search that returns any work that has any of the subject headings listed under "Concepts Influenced"

Requirements:

Create new tab "Works with this Concept Component term" is listed on concept records and functions similarly as the "Works Related" tab.
TBD: validate tab label
TBD: validate feasibility of offering this results list
TBD: what to do with Explore visualization here

Needed for promotion:
If an item on the list is not needed, it should be crossed off but not removed.

[ ] Tab/Label decision
[ ] Wireframe/Mockup - Mike
[ ] ~Committee discussions - Sarah~
[ ] Feasibility/Team discussion - Sarah
[ ] Backend requirements - TBD
[ ] Frontend requirements- TBD
[ ] Are new regression tests required for QA - Amy
[ ] Questions
List of questions for discussions. Answers should be documented within the issue.

UAT/LUX Examples:

pre-coordinated subject heading with component terms:  https://lux-front-dev.collections.yale.edu/view/concept/1fa3c3a7-50ca-4ae9-bce8-7098d041f5a8
subject heading component term page (this ticket): https://lux-front-dev.collections.yale.edu/view/concept/12927247-87b8-43a3-a12d-ff3cd7082324

Dependencies/Blocks:
Related Github Issues:
Related links:

Bugherds: https://www.bugherd.com/projects/284041/tasks/2237
https://www.bugherd.com/projects/284041/tasks/2288

Wireframe/Mockup:
Current:

Updated:

Per ticket forming - could expand the HAL link for this query to include component terms and then would get a list of Works Related (everything with that component term)
This will need a new MT ticket to update the HAL link for Works Related.

Examples from Rob
United States -
History - works tab, more or less.

@roamye @jffcamp @prowns This issue will not require a frontend ticket, only the HAL link update.

UAT 8/7:
Fine to close as it did not need a FE ticket.


Purpose of Suppressing Out in python

Hi I have been learning the shortcuts of ipython, it was so helpful.
However, I couldn't understand the purpose of Suppressing the output in IPython, If it's neither print output nor stores that output, what's the point?
I just got curious over this?

@axxdsyl


[TF 2.0 API Docs] tf.audio.decode_wav

Starting work on this for ML4ALL doc sprint
https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/audio/decode_wav

@missaugustina  Could you provide more details about the what you want to work on and context.

Hi, I'm working on the API docs per the doc sprint info, what are you confused about?

Hi, I'm working on the API docs per the doc sprint info, what are you confused about?

I plan to submit a PR for this issue

Related to Issue #28236

Just got this answered on SO...
raw_audio = tf.io.read_file(filename)
waveform = tf.audio.decode_wav(raw_audio)

https://stackoverflow.com/questions/58096095/how-does-tf-audio-decode-wav-get-its-contents


Warning on ES service status - An illegal reflective access operation has occurred

Describe the bug
I installed a RPM based OpenDistro on my Centos7 server and added it as a system service as specified in the installation documents. When I check the status of the service, I get a couple of warnings that asks me to report it to the developers.
To Reproduce
Steps to reproduce the behavior:

Run

systemctl status elasticsearch.service -l

See error

systemd[1]: Starting Elasticsearch...
systemd[1]: Started Elasticsearch.
systemd-entrypoint[9149]: WARNING: An illegal reflective access operation has occurred
systemd-entrypoint[9149]: WARNING: Illegal reflective access by com.amazon.opendistro.elasticsearch.performanceanalyzer.collectors.MasterServiceEventMetrics (file:/usr/share/elasticsearch/plugins/opendistro_performance_analyzer/opendistro_performance_analyzer-<IP_ADDRESS>.jar) to field java.util.concurrent.ThreadPoolExecutor.workers
systemd-entrypoint[9149]: WARNING: Please consider reporting this to the maintainers of com.amazon.opendistro.elasticsearch.performanceanalyzer.collectors.MasterServiceEventMetrics
systemd-entrypoint[9149]: WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
systemd-entrypoint[9149]: WARNING: All illegal access operations will be denied in a future release

Configuration:

ODFE/Kibana version - 1.8.0
Distribution - RPM
Host Machine - Centos7

According to the logs, this is an issue related to performance analyzer plugin.
I have transferred this issue to the corresponding repo issues section.
Thanks.

@sarthi2395 Thanks for reporting this issue. You can ignore this warning for now. We will work on removing this benign message.

@sarthi2395 Thanks for reporting this issue. You can ignore this warning for now. We will work on removing this benign message.


Package does not work on Android.

Hi guys, thanks for the efforts you put into making this expo module.
I've been trying to make a React app that uses the wesh protocol for the last weeks. I know nothing about golang, but I read on the discord channel that you've been working on this package to abstract the complexity of having to compile go code, and build our own native layer.
When I try to run the provided example app on the /example directory, I am having some errors. I'll put all the steps I made in order to make it "almost" work in my setup.
Setup
OS: Ubuntu 22.04 LTS
Phone: Motorola g100 with Android 12.
Steps to reproduce the error:
1 - Clone the repo and install packages.
git clone git@github.com:berty/weshnet-expo.git
cd weshnet-expo
make asdf.install_plugins
make asdf.install_tools

2 - Run the provided example
cd example
make node_modules
npm run android

After this step, I'm seeing this error:
> Task :berty-weshnet-expo:makeBuild FAILED
mkdir -p api/
buf export buf.build/berty/weshnet:c72d5759847b4dedb5411c19485e1a37 --output api/
No version is set for command buf
Consider adding one of the following versions in your config file at /home/danilo/dev/weshnet-expo/.tool-versions
buf 1.15.1
make: *** [Makefile:80: api/protocoltypes.proto] Error 126

After adding buf 1.15.1 in the .tool-versions, and running make asdf.install_plugins and make asdf.install_tools again,  and re-running npm run android now I see this issue:
> Task :berty-weshnet-expo:makeBuild FAILED
> copying current '.tool-versions' in '' folder in order to make asdf works
> this hack is needed in order for gomobile (who is building from '') bind to use the correct javac and go version
'.tool-versions' -> '/.tool-versions'
cp: cannot create regular file '/.tool-versions': Permission denied
make: *** [Makefile:118: /.tool-versions] Error 1

In my case, the solution to this error was creating a /tmp directory and adding this in line 103 on the Makefile at the root of the project.
# main Makefile
TMPDIR='./tmp'

with this little changes, now I'm able to build the code.
But as soon as I open the app on my phone, I see some errors, and the expo console says this:
Android Bundling complete 10326ms
 ERROR  init error [Error: CoreError]
 WARN  Possible Unhandled Promise Rejection (id: 0):
TypeError: Cannot read property 'serviceGetConfiguration' of undefined
TypeError: Cannot read property 'serviceGetConfiguration' of undefined
    at anonymous (http://localhost:8081/index.bundle//&platform=android&dev=true&minify=false&app=expo.modules.weshnetexpo.example&modulesOnly=false&runModule=true:1159:39)
    at tryCallOne (/root/react-native/ReactAndroid/hermes-engine/.cxx/Release/2q6r403w/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:53:16)
    at anonymous (/root/react-native/ReactAndroid/hermes-engine/.cxx/Release/2q6r403w/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:139:27)
    at apply (native)
    at anonymous (http://localhost:8081/index.bundle//&platform=android&dev=true&minify=false&app=expo.modules.weshnetexpo.example&modulesOnly=false&runModule=true:26302:26)
    at _callTimer (http://localhost:8081/index.bundle//&platform=android&dev=true&minify=false&app=expo.modules.weshnetexpo.example&modulesOnly=false&runModule=true:26221:17)
    at _callReactNativeMicrotasksPass (http://localhost:8081/index.bundle//&platform=android&dev=true&minify=false&app=expo.modules.weshnetexpo.example&modulesOnly=false&runModule=true:26251:17)
    at callReactNativeMicrotasks (http://localhost:8081/index.bundle//&platform=android&dev=true&minify=false&app=expo.modules.weshnetexpo.example&modulesOnly=false&runModule=true:26414:44)
    at __callReactNativeMicrotasks (http://localhost:8081/index.bundle//&platform=android&dev=true&minify=false&app=expo.modules.weshnetexpo.example&modulesOnly=false&runModule=true:4608:46)
    at anonymous (http://localhost:8081/index.bundle//&platform=android&dev=true&minify=false&app=expo.modules.weshnetexpo.example&modulesOnly=false&runModule=true:4420:45)
    at __guard (http://localhost:8081/index.bundle//&platform=android&dev=true&minify=false&app=expo.modules.weshnetexpo.example&modulesOnly=false&runModule=true:4592:15)
    at flushedQueue (http://localhost:8081/index.bundle//&platform=android&dev=true&minify=false&app=expo.modules.weshnetexpo.example&modulesOnly=false&runModule=true:4419:21)

Trying to debug what is going on, I replaced this line in WeshnetExpoModule.kt
    @Throws(CodedException::class)
    private fun initializeCoreService(): Service {
        // Add logic to create and return your service instance
        // If an error occurs, throw WeshnetError2.kt
        try {
            return Core.newService()
        } catch (err: Exception) {
           // throw WeshnetCoreError(err)            commented this and added the following line:
           throw err
        }
    }

Now, in the console, I'm able to see this error:
 ERROR  init error [Error: Call to function 'WeshnetExpo.init' has been rejected.
→ Caused by: go.Universe$proxyerror: unable to start service: TODO(#666): failed to init ipfs node: constructing the node (see log for full detail): opening IPFS_PATH: exec: "getent": executable file not found in $PATH]
 WARN  Possible Unhandled Promise Rejection (id: 0):
TypeError: Cannot read property 'serviceGetConfiguration' of **undefined**

... same as before.

I don't know how to fix that issue. And I don't know if this is something on your side or a third party library you use.
I remember reading on the discord channel that your priorities have changed since the weshnet-expo project was created, and the last commit was 10 month ago, but I'd be glad to help in this project because I truly believe that this is the best way to expose the wesh protocol for react devs.
Let me know if you need help on testing this issue.
Thanks in advance!

Hey, I'm not on the wesh/berty team but I've been playing around with this too. I actually have it somewhat working to the point where compiled go code can be used in an expo app. I'll push my changes up to a fork so you can see what I did (I hit a lot of the same things you did).

@danilobassi8, here you go: https://github.com/bluesliverx/weshnet-expo

@bluesliverx thanks for your comments. I tried your fork and I got this error when running npm run android:
Android Bundling failed 85ms
error: ../src/index.ts: /home/danilo/dev/weshnet-expo/src/index.ts: Export namespace should be first transformed by `@babel/plugin-transform-export-namespace-from`.
  11 |
  12 | // Export these types to be used in consuming apps
> 13 | export * as ProtocolTypes from './api/protocoltypes.pb';
     |        ^^^^^^^^^^^^^^^^^^
  14 | export * as Weshnet from './weshnet.types.gen';
  15 |
  16 | export async function init(): Promise<ProtocolServiceClient> {

If I checkout to your previous commit, I have the same error as the original repo.

This is why I haven't pushed anything up 😅
Try removing those star imports for the types, it's likely not the right way to do it anyways

I got stuck at the same point when trying to run it for Android. The execution deads in await WeshnetExpoModule.init() (in src/index.ts).
I'd like to add to this issue that when running adb logcat in a terminal I'm seeing:
08-09 00:08:46.733 12174 12266 I ReactNativeJS: Starting initialization...
08-09 00:08:46.733 12174 12266 I ReactNativeJS: Initializing WeshnetExpoModule...
08-09 00:08:46.741 12174 12290 E GoLog   : 2024-08-09T00:08:46.741Z	ERROR	core	core/builder.go:158	constructing the node: could not build arguments for function "github.com/ipfs/kubo/core/node".PeerWith.func1 (/home/baffo/.asdf/installs/golang/1.19.7/packages/pkg/mod/github.com/ipfs/kubo@v0.19.0/core/node/peering.go:29): failed to build *peering.PeeringService: could not build arguments for function "github.com/ipfs/kubo/core/node".Peering (/home/baffo/.asdf/installs/golang/1.19.7/packages/pkg/mod/github.com/ipfs/kubo@v0.19.0/core/node/peering.go:14): failed to build host.Host: could not build arguments for function "github.com/ipfs/kubo/core/node/libp2p".Host (/home/baffo/.asdf/installs/golang/1.19.7/packages/pkg/mod/github.com/ipfs/kubo@v0.19.0/core/node/libp2p/host.go:40): could not build value group []config.Option[group="libp2p"]: received non-nil error from function "github.com/ipfs/kubo/core/node/libp2p".ResourceManager.func1 (/home/baffo/.asdf/installs/golang/1.19.7/packages/pkg/mod/github.com/ipfs/kubo@v0.19.0/core/node/libp2p/rcmgr.go:31): o
08-09 00:08:46.741 12174 12290 E GoLog   : pening IPFS_PATH: exec: "getent": executable file not found in $PATH
08-09 00:08:46.745 12174 12266 E ReactNativeJS: 'Initialization error:', { [Error: CoreError] code: 'ERR_WESHNET_CORE_ERROR' }
08-09 00:08:46.761 12174 12266 E ReactNativeJS: 'WeshnetExpo.init() error:', { [Error: CoreError] code: 'ERR_WESHNET_CORE_ERROR' }

Note: the ..I ReactNativeJS.. are just some messages I added for debugging.
It seems that something is wrong in either IPFS_PATH or getent. Idk if it makes sense that you are trying to run getent on Android.

@jefft0 to try to reproduce the error on an Ubuntu VM.

Thank you for opening the issue 🙏 We confirm this is an important bug and we need to fix it.
To put things in perspective, we are currently focused on fixing the RDV server issues (which require updating a lot of components, a laborious task). So, we could approximate Sept 2024 when we will attack this Expo Module bug.
We imagine it is frustrating to have so slow times of addressing important bugs, but we have limited resources and a few very important priorities in some tangent projects. However, we will improve Berty Messenger and more than that, have the Wesh Network protocol power more decentralized dApps. Stay tunned :)

This is the same problem I'm hitting locally with pure go code I believe as well. Thanks everyone for looking into it

Hello @danilobassi8 . I am trying to reproduce your bug. I think you got farther than I did in the build process. I'm getting an error from gradle. So, what is your version of the Android SDK? If you installed Android Studio, what is its version? Thanks.

Hi @jefft0 , thanks for addressing this issue.
I'm using the latest Android Studio downloaded from the official page.
I'm using it with default settings, but I also tried other JDKs to check if it worked, but it didn't.

Hello @danilobassi8 . I have reproduced your error Cannot read property 'serviceGetConfiguration' of undefined. Now that I can reproduce the error, I will get our expo devs to look at it, and the comments from @bluesliverx .

https://github.com/ipfs/kubo/pull/10492 fixes opening IPFS_PATH: exec: "getent": executable file not found in $PATH.
This fix will be released in kubo v0.31 (https://github.com/ipfs/kubo/issues/10499).
I've opened a PR (https://github.com/berty/weshnet-expo/pull/20) to start fixing this issue, and waiting that kubo v0.31 will be released.

@danilobassi8, with the latest fixes, I'm able to build on Ubuntu 22.04 and run the example on my Android phone. Do you want to try again?

I'm seeing this in dev with a brand new project following the example code:
Android Bundling failed 1091ms node_modules/expo/AppEntry.js (649 modules)
Unable to resolve "./protocoltypes.pb" from<EMAIL_ADDRESS>

When I build, I use asdf as described in the original post. It uses the versions in this file.
https://github.com/berty/weshnet-expo/blob/main/.tool-versions
Are you using these versions?

@jefft0 that is a good call, I made sure to match those versions now with asdf. To be clear, I'm installing the weshnet-expo package into another project. I first tried it using the npm package published upstream, but that failed with the Unable to resolve "./protocoltypes.pb" message I showed above. I then cloned the latest version and tried it as a local dependency, but ran into the same issues. I had to once again make the Makefile changes [I mentioned above|https://github.com/berty/weshnet-expo/compare/main...bluesliverx:weshnet-expo:main#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52] and then was able to get much further.
I am now getting an error that it cannot read the property serviceGetConfiguration of undefined, which is generated using [the method documented in the readme|https://github.com/berty/weshnet-expo/blob/main/README.md?plain=1#L52].
On the other side, iOS is working great and I get a PeerID just fine, so it's just a problem with Android.

Thanks for the feedback. We confirm this issue and we're looking into it.

Thanks @jefft0. Here are some changes I made to get the dependent project further along (fixes the Unable to resolve "./protocoltypes.pb error): https://github.com/berty/weshnet-expo/compare/main...bluesliverx:weshnet-expo:main

Hi @bluesliverx , https://github.com/berty/weshnet-expo/pull/22 should fix your issue.
I successfully tested creating a new Expo project and then added weshnet-expo on Android and iOS.
Can you confirm me that is working to you too.
Thanks.

No more comments from poster. Issue has been fixed in our tests. Closing as resolved.


Fixes:Navbar Issues

Summary:
In the Hindi version of the page , the navbar appearance doesn't looks understandable for a Hindi user and also the [log out] hover appearance is written in English in place of Hindi
Description for the changelog:
provide Hindi translation strings for hover text
Other info:
Fixes: #862

sure @jgadsden  i'll do it further


Swipe with angular-carousel doesn't work with Angular JS 1.3.x

Swiping doesn't work with angular-carousel when you use Angular JS 1.3.x (I tested with 1.3.5). You can easily verify this by just switching the angular versions on the demo page

Seems like a change with $observe from 1.2 to 1.3 has caused the breaking change. If you manually add rn-carousel-swipe, it works as expected.
The offending code is here https://github.com/revolunet/angular-carousel/blob/master/src/directives/rn-carousel.js#L218-L224
The iAttributes.$observe('rnCarouselSwipe', function(newValue, oldValue) { never gets called in 1.3 unless you have the rn-carousel-swipe added

Thanks for this. :beer:

Thanks for the report;
Can you please issue a pull request ?

Note that this is for version 0.2.5. Due to https://github.com/revolunet/angular-carousel/issues/254, I am unable to run angular-carousel 0.3.7 on my site, so I am not sure if it applies to that version. The latest version in master doesn't seem to use $observe.


[Job Launcher] [UI] Fixes and Improvements

Description
After testing, several bugs and possible improvements to the Job Launcher user interface were discovered.
Implementation details

[x] When filling in the url field, it highlights in blue. This blue highlight extends beyond the field's border. It might be better to remove the blue highlight and use a white background instead. This issue appears when selecting a previously used option. (NOT RELEVANT ANY MORE)
[ ] Change the default task type from points to boxes. boxes are used more frequently.
[ ] The user guide url and gt url fields lack tooltips or prompts. It would be beneficial to add tooltips since it's not immediately clear how to fill them in.
[ ] The Launch button remains inactive even after filling in all the fields.
[ ] When attempting to sign in without completing the verification process, users are not presented with any error message. Instead, they are instantly redirected to the sign-in page. A client-side message must be added to inform users about the missing verification step.

@m00n620
1. Detailed
userGuideURL: This field should contain a brief description of how data should be annotated. A user guide is a valuable resource that provides instructions, guidelines, and best practices for annotators, helping them understand how to accurately and consistently annotate the data.
groundTruthURL: This field should contain a URL or link to the ground truth data. Ground truth data serves as the reference or gold standard for your annotations. It represents the correct or desired data, against which the annotations are compared for accuracy and quality assessment.
2. Short 1
userGuideURL: Annotation guidelines
groundTruthURL: Reference data for accuracy comparison.
3. Short 2
userGuideURL: Annotator's guideline for data labeling
groundTruthURL: Reference data for annotation accuracy
@Dzeranov what do you think?


Inability to save files with .jpeg extension

.jpeg and .jpg file extensions are interchangeable, yet SFML does not seem to support saving .jpeg extensions. Noteworthy in this code segment https://github.com/SFML/SFML/blob/master/src/SFML/Graphics/ImageLoader.cpp#L253 SFML doesn't check for a .jpeg extension, or in this case it would be "peg". I would like to propose a minor bugfix for simply allowing files with a .jpeg extension to be saved in the exact same manner as a .jpg

Good catch. Although the whole "extension detection" as-is is quite a bit naive. For example, test.coolpng or even some_png would still be interpreted as a PNG image since it's longer than 3 characters and ends with png. But this is obviously wrong. Going to create a patch, thanks anyway. :)

Thanks, I decided to change my implementation and repropose it

I think we should really search for '.' from the end, extract the extension and then check, @MarioLiebisch. This bug might be a good opportunity to change it. @kikiotsuka thanks for reporting!

@TankOs do you mind giving me another shot? I tried it again here https://github.com/kikiotsuka/SFML/pull/3

@TankOs do you mind giving me another shot? I redid that section of the code here https://github.com/kikiotsuka/SFML/pull/1

Next time, please read the contribution guidelines first. This helps us organize things better -- it's not necessary to have 3 open issues/PRs for the same thing. Thanks.
Let's continue the discussion in #931, otherwise it gets confusing ;)
I'll close this so we have one issue/PR per task.


24.7.3: New Suricata.yaml faulty - wrong indentation

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
With 24.7.3, a new Suricata.yaml was included. This seems to be slightly faulty:
root@OPNsense:~ # /usr/local/etc/rc.d/suricata start
Starting suricata.
Error: conf-yaml-loader: Failed to parse configuration file at line 348: did not find expected key
/usr/local/etc/rc.d/suricata: WARNING: failed to start suricata

To Reproduce
Steps to reproduce the behavior:

Update to 24.7.3
Try to start Suricata.
See error (Full error message only visible on console)

Expected behavior
Suricata starting up fine:
root@OPNsense:~ # /usr/local/etc/rc.d/suricata start
Starting suricata.
Info: conf-yaml-loader: Including configuration file installed_rules.yaml.
Info: conf-yaml-loader: Configuration node 'rule-files' redefined.
Info: conf-yaml-loader: Including configuration file custom.yaml.

Describe alternatives you considered
N/A
Solution
Indentation in /usr/local/etc/suricata/suricata.yaml  is wrong at lines 348 et seq:
      types:
        - alert:
             payload: no
             payload-buffer-size: 4kb
             payload-printable: yes
            metadata: yes
            tagged-packets: yes

must be corrected as follows (delete 1 space in front of each "payload"):
      types:
        - alert:
            payload: no
            payload-buffer-size: 4kb
            payload-printable: yes
            metadata: yes
            tagged-packets: yes

Thanks for the report. It has been hotfixed.


Fix finalize_release

As I went through the flow I found several issues. In the end I got all jobs to run succesfully (in separate runs across https://github.com/apache/beam/actions/workflows/finalize_release.yml)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @Abacn


Blocked Accounts Crash Map Server

Expected behavior
When attempting to log in with any "bad" account the server should not crash.
Actual behavior/symptoms
When attempting to log in with account (user) 1 and (pass) 1 you're provided with a "blocked account" type message.
The output file lists this:
(3280|10868) User 1 trying to login from <IP_ADDRESS>.
(3280|8744) Connection closed
(3280|1240) Client disconnected without a valid login attempt. Old client ?

then the user can log in with an unblocked account. upon loading atlas park it crashed the map server. All of the clients received "Map server disconnected".
Steps to reproduce behavior/symptoms

Log in successfully with a new or existing account
Attempt to log in with 1 / 1
Log in successfully with a new or existing account (which is not already logged in)

SEGS version
0.4.3
Operating system
Windows 10 Pro
C++ compiler and version
MinGW 5.3.0 32bit for C++

1accountcrash.txt
I forgot my output.log.

We can close this now that #334 is closed as well.


Allow contexts to be loaded from paths or resources

Directly support specifying contexts as paths to python/json files or as packaged resources to the same.

duplicates #17


Format cabal files with cabal format

Description
Apply cabal format to all the consensus .cabal files. Also add it to CI.

Close in favor of #4443


Is there a way to run bgremover on windows?

The term "backgroundremover" is not recognized, is there another way to use it?

The term "background" is not recognized, is there another way to use it?

python -m backgroundremover.cmd.cli -i "in.jpg" -a -ae 15 -o "output.png"

python -m backgroundremover.cmd.cli -i "input.jpg" -a -ae 15 -o "output.png"

Thank you!


[backport] Fix random docstring

Backport of #5628 by @takagi

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit c485185a7f63eed994fdcf89fbcea3fe8d9920bd, target branch v9) failed with status FAILURE.

Test failure is OOM and not related to this PR.


RangeSlider in Scrollview (Android)

Description of Change
We should call RequestDisallowInterceptTouchEvent when the user interacts with thumbs (move them) for preventing scrolling on Android.
I added an internal class ThumbFrame that has a custom renderer for android where we prevent scrolling if a user drags it.
Bugs Fixed

Fixes #502

API Changes
None
Behavioral Changes
None (only bugfix)
PR Checklist

[ ] Has tests (if omitted, state reason in description)
[ ] Has samples (if omitted, state reason in description)
[X] Rebased on top of main at time of PR
[X] Changes adhere to coding standard

[ ] Updated documentation

A new build for this PR has been completed. As a result a NuGet has been created which allows you to verify this fix or try out the new feature! Download here

A new build for this PR has been completed. As a result a NuGet has been created which allows you to verify this fix or try out the new feature! Download here

A new build for this PR has been completed. As a result a NuGet has been created which allows you to verify this fix or try out the new feature! Download here

A new build for this PR has been completed. As a result a NuGet has been created which allows you to verify this fix or try out the new feature! Download here


Improve styles for mobile

What:

Improve styles for mobile
Update footer links

Why:
Relates to: https://app.asana.com/0/1159164196409129/1191556884196657/f
How:

Adapt sections to mobile devices
Set padding y and x for mobile
Refactor slider to detect slide change on a touch event
Adapt images for mobile
Replace inline background gradient to tailwind background gradient

Media
https://www.loom.com/share/79d3d982677b44e289528fb6f59484dd

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


model compilation fails if model vars are named 'true' or 'false'

Another in the occasional series of naming issues.
In the BUGS biops example a variable is named 'true'. This causes problems in the generated C++.
example = 'biops'
dir = nimble:::getBUGSexampleDir(example)
m = readBUGSmodel(example, dir = dir)
conf=configureMCMC(m)
cm = compileNimble(m, showCompilerOutput = TRUE)

compiling... this may take a minute. On some systems there may be some compiler warnings that can be safely ignored.
g++  -I/usr/share/R/include -DNDEBUG  -DEIGEN_MPL2_ONLY=1 -I"/accounts/gen/vis/paciorek/R/x86_64-pc-linux-gnu-library/3.4/nimble/include" -Wno-misleading-indentation -Wno-ignored-attributes -Wno-deprecated-declarations     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c P_2_biops.cpp -o P_2_biops.o
teIn file included from P_2_biops.cpp:4:0:
P_2_biops.h:30:23: error: expected unqualified-id before ‘true’
   NimArr<1, double> * true;
                       ^
P_2_biops.h:30:21: error: expected ‘;’ at end of member declaration
   NimArr<1, double> * true;
                     ^

I'd welcome ideas on this.  I suspect that a variable whose name is any C++ keyword will lead to failures.  We could grab a list of C++ keywords and warn the user if they have used any of them as variable names and have some default renaming behavior.


build(defaults): update to v1.6.0

Updates to minimum Node version of 4.8 ( npm 5 compatibility )
Update devDependencies via npm run webpack-defaults
Semantic changes to both CI configurations

Why was this not listed as a breaking change in the release notes? Our build is now failing because of the Node version requirement 😢

The node version bump itself is within the semver minor range, I know it's annoying in your case, but we needed to bump it bc of npm@5 and we simply can't release any nitty-gritty as semver major. It's assumed that folks use the @latest within their current semver major range


fix: Editor cannot be focused

Fix monaco editor cannot be focused

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 4 committers have signed the CLA.:x: dr1rrb:x: jeromelaban:x: nickrandolph:x: carldebillyYou have signed the CLA already but the status is still pending? Let us recheck it.

Sorry wrong repo :/


How do I Disable the mod AutoLogon? There is no way to disable it in the app.

This key sets AutoLogon in the Registry HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Winlogon\AutoAdminLogon  If that is what Bloaty is using, just change the value 1 to a 0 to turn it back off.

It worked, thank you for the help!!!


Added new DTLS-SRTP protection profiles from RFC 7714

RFC 7714 was published recently with new SRTP profiles. This simple PR adds it to the existing DTLS-SRTP implementation.

I'm not sure what this commit gets you, it doesn't seem to implement anything from that RFC.

It's just adding the protection profiles from section 14.2 (which sounds like a fairly reasonable request)

I guess I just have no idea how you use DTLS-SRTP with OpenSSL.  I was expecting that those other values from that RFC should be used somewhere, but maybe that's not in the OpenSSL code?

Exactly. You use SSL_CTX_set_tlsext_use_srtp(), SSL_set_tlsext_use_srtp(), SSL_get_srtp_profiles() and SSL_get_selected_srtp_profile() to get and set the profiles that are then used within the SRTP connection (outside of OpenSSL).

So does that mean that this code outside OpenSSL can not use those profiles just because OpenSSL didn't add this profile number it doesn't do anything with?  Or is there some other way for the application to set those profiles so that OpenSSL doesn't always need to get updated?  This all looks like some "custom extension" thing.

Yes. Applications can't negotiation the profiles if OpenSSL doesn't know about them.

Fixed formatting. @mattcaswell, should I recreate the PR to contain one commit only?

Just squash the commits and push -f to keep it within this PR.

@mattcaswell, done

+1

We need a second team review now.

+1

Pushed to master. Thanks for the contribution.


ISPN-14256 CLI should work with piped input

https://issues.redhat.com/browse/ISPN-14256

Integrated into main, thanks @tristantarrant !

@tristantarrant  Looks like you wanted to add a 14.0.x branch PR?


Changed how editor is obtained and added a error message in case it fail

Could reproduce #44 and fixed.
Can you review the code please?

No-no, atom.workspace.getActiveTextEditor is a bad idea, it can lead to all kinds of issues. Problem is, editor that generated an error isn't necessarily active when event handler is called.
Changing target to currentTarget should work.

See 50e8ee086c5b2c57e92d41df51514e5ad80e2834 (also removed editor null/undefined check, since events are bound to atom-text-editor, which currentTarget is pretty much guaranteed to point to)

Oh, ok. Didn’t thought about that!
Thanks for the correction. Will merge and publish  tomorrow. Out for the day.

Closed due to better handling by @lierdakil in PR 46


Confusing error when uploading a distribution with a different auth

I'm trying to upload `Tux::CSV" by @Tux and it warns me I'm not them, but then it fails with the message:
Meta error: auth must be zef: or zef:

I guess that would be zef:Tux, right?
While we're at it, is there an easy way for @Tux to authorize me for uploading just this distribution?

That didn't prevent it from working, apparently. So it's even more confusing...

I did a fez upload after merging the changes.

I have no idea how I would authorize you to do the upload too. But I am seldom far away. Reach out on IRC

Done


Removal of react-scroll-to-bottom has caused issues in Inspector

Describe the bug
Seems to make the inspector scoll at the root level which hides the top bar of the tool.
To recreate
clone inspector
npm install
npm install @open-rpc/logs-react@latest
npm start

:tada: This issue has been resolved in version 1.1.3 :tada:
The release is available on:

GitHub release
1.1.3
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Sql test using derby doesn't start dev service and shows class loadin…

…g issue if stored procedure is called #3260
fixes https://github.com/apache/camel-quarkus/issues/3327
Needs https://github.com/quarkusio/quarkus/issues/22058 to work correctly.
I introduced an option to start sql test with derby started by docker. - to simulate external database (and not dev service).
There are 2 things which may need some changes:

To run stored procedure on external derby db, there has to be a jar which is uploaded there. I created module sql-derby for that purpose and I put it on the same hierarchy level as sql test module. I'm not sure if this is the right approach, another option is to put both sql and sql-derby in one module.
I'm facing a problem with generated port number for docker container. If I let docker to generate its own random port, I'm not able propagate it back to datasource definition. Therefore there are 2 properties, which forces usage of docker derby db:

export SQL_USE_DERBY_DOCKER=true
export SQL_USE_DERBY_PORT="#port"

On the other hand in current moment, when there is no CI automation for derby (see https://github.com/apache/camel-quarkus/issues/3083) it could stay in that way.
WDYT? @aldettinger

I think that better approach (step 1) is to created sql-derby as a module in integration-tests-support, I'll try it

It looks a big part of the difficulty comes from the setup of a derby database using a stored proc from a jar.
I wonder whether such a setup could be already present in an already built docker image ? Maybe derby testers would already have such kind of setup present in a docker image ?
In case case, this is good to see this path being dug. Well done for that @JiriOndrusek :+1:

Ufortunately even if quarkus issue is fixed, test still fails in native. See this comment for a stacktrace - https://github.com/quarkusio/quarkus/issues/22058#issuecomment-989825112
I'll keep digging into this.

@JiriOndrusek  I'm not sure if I understand this PR correctly. Why do we need this external jar for native mode ?
Is it for a Test Resource needs, or is it required for the code of the app ?

@zbendhiba  I'll try to explain. From what I remember:

We want to add a test for derby against external db.
External db is started by the test via docker image.
To be able to execute stored procedure in the derby db, jar with the implementation of that procedure has to be uploaded into  the db.

CALLLL sqlj.install_jar('/PATH_TO_JAR/camel-quarkus-integration-test-sql-derby-stored-procedure-*.jar', 'AddNumsProcedure' , 0)

CALL syscs_util.syscs_set_database_property('derby.database.classpath', 'APP.ADDNUMSPROCEDURE')

(In case of the dev service, derby runs with the same class loader and there is no need to upload this procedure. It is there because it is a dependecy of the module.)
My answer is that we need this jar for both JVM and native and it is used by the test resource to initialize derby (started via docker) to contain our stored procedure.

Maybe I'm wrong. Can you achieve this using it only  at QuarkusTestResourceLifecycleManager level? Or is the problem come from the fact of the existence of a library in the pom.xml file ?
Or can we push the jar inside the Docker image using docker compose?
My point is that something needed just for TestResource should not be included in the native build. Unless I'm wrong about how  QuarkusTestResourceLifecycleManager works

@zbendhiba your suggestion sounds good. I used this way and didn't think that it is against best practices in native. If it is possible to put a jar inside docker image, it would be solution.
Current fix uploads a jar into docker container
  container = new FixedHostPortGenericContainer("az82/docker-derby")
                    .withFixedExposedPort(SqlHelper.getDerbyDockerPort(), 1527)
                    .withCopyFileToContainer(
                            MountableFile.forClasspathResource("derby/" + jars[0].getName()),
                            "/dbs/storedProcedure.jar")
                    .waitingFor(Wait.forListeningPort());

Do I understand correctly, that having jar with stored procedure among dependencies cause quarkus in native to inspect and process it,
Maybe I can use a current solution, where the jar won't be in dependency, but will be copied (or created) in this module via maven plugin. Would it help?

@zbendhiba your suggestion sounds good. I used this way and didn't think that it is against best practices in native. If it is possible to put a jar inside docker image, it would be solution. Current fix uploads a jar into docker container
  container = new FixedHostPortGenericContainer("az82/docker-derby")
                    .withFixedExposedPort(SqlHelper.getDerbyDockerPort(), 1527)
                    .withCopyFileToContainer(
                            MountableFile.forClasspathResource("derby/" + jars[0].getName()),
                            "/dbs/storedProcedure.jar")
                    .waitingFor(Wait.forListeningPort());

Do I understand correctly, that having jar with stored procedure among dependencies cause quarkus in native to inspect and process it, Maybe I can use a current solution, where the jar won't be in dependency, but will be copied (or created) in this module via maven plugin. Would it help?

No I think it's fine. I was looking at related issues, and was thinking we have a native error because of this.
Thanks for your answer

You'll want to rebase and change the target branch to main since Quarkus has been bumped to 2.7.x.

I rebased this PR to main. I can locally run tests with external derby via docker in JVM  mode Native mode fails with
ERROR [io.qua.run.Application] (main) Failed to start application (with profile prod): ERROR 08006: Insufficient data while reading from the network - expected a minimum of 6 bytes and received only 0 bytes.  The connection has been terminated.

But native mode is not expected to be successful, see https://github.com/quarkusio/quarkus/issues/22058#issuecomment-989714178

Derby dev service doesn't work because of quarkus error - https://github.com/quarkusio/quarkus/issues/23083

@jamesnetherton The CI build fails with:
Run [[ -z $(git status --porcelain | grep -v antora.yml) ]] || { echo 'There are uncommitted changes'; git status; exit 1; }
There are uncommitted changes
HEAD detached at pull/3370/merge
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   pom.xml

But if I build the branch locally (even without -Dquickly) the is no modified file. Do you know what could be wrong?

Do you need to have the target branch as quarkus-main? main has been updated to Quarkus 2.7.x.

Thanks, this was the mistake, I rebase it on git repo but not on this PR. thanks a lot.

I slightly reworked and retested derby tests. By default derby dev service is used,
For external db testing -> it is possible to use docker image with the test (by simple export SQL_USE_DERBY_DOCKER=true or use external db , which requires several manual configurations because of stored procedure (described in README.adoc). PR can be merged.

@JiriOndrusek can you update camel-quarkus-integration-tests-support-sql-derby to 2.17.0-SNAPSHOT and we can merge this.

Done, can be merged.


fix/blocked_store_class

This PR includes:

The removal of BaseViewModel from the class. This was done to follow the rule of view models must not know about other view models.

LGTM!


Avoid converting syn types to strings before parsing

Closes #340
This is already a good number of changes to start with, but there's a few followups that might be useful here, including:

Better error handling. Right now everything either panics or returns an Option as an output type. Results would be more friendly to work with.
Unifying the IrFunc model with IrFuncOutput and IrFuncArg. The way I've implemented it, just the type from each IrFuncArg and IrFuncOutput is extracted and stored in IrFunc along with the fallible and mode information. This would also be a good opportunity to forbid more combinations in function signatures, like StreamSink along with another return type.

I tried to keep functionality as similar as possible; all the existing test cases are interpreted without any changes. There is one significant difference in that types with leading paths are always allowed now, whereas it used to only work for "special" types (e.g. anyhow::Result<_>) before. Everything before the last path segment is ignored. I left it this way for simplicity/consistency, but it's easy enough to change now if necessary.

Excellent job and LGTM!

This is already a good number of changes to start with, but there's a few followups that might be useful here, including:

Agree, especially the error handling part. Looking forward to the PR!


fix: flickering colors

Seems to be a bad idea to schedule extmarks in favor of faster data to the reader since it will cause flickering in colors as mentioned #262.
Bonus:
Noticed that pretty_print was taking ~10ms at 600+ pods, we don't really do that much work, managed to refactor it down to ~3ms.

Amazing
How did you calculate the benchmark of pretty print?

Amazing How did you calculate the benchmark of pretty print?

I'm using two ways, the easiest is just to use the timeme utility we have in utils/timeme.lua and surround a function with timeme.start()
.....
timeme.stop()
This just prints out the time in seconds and works great when you know where you need to improve.
The second way is how I usually start from, using the plugin: "stevearc/profile.nvim"
It gives me this view:
Before:

After:

Awesome! I'll start using that on my PRs :)
thank you for the detailed explanation.

I'm hoping this solves the flickering and gives us a snappier ui!


feat(swap): add warning when swapping max CELO

Description
As the title:

add a warning component
display the component when the user has pressed the max button while swapping from CELO
hide the component when the user edits the swap amount
add analytics to the max button

Unrelated:

removed a bunch of unused icons - i was going through the folder to see if the icon that i need exists already, and found a bunch of redundant things.

Test plan
Added small unit test.
https://user-images.githubusercontent.com/20150449/223147068-5510e697-ba9e-44f5-a03c-82480511114d.mp4
Related issues

Fixes RET-609

Backwards compatibility
Y

@kathaypacific seeing an issue with larger fonts.


money-tree dependency causes heroku deployments to fail

https://github.com/Sailias/cryptocoin_payable/blob/551c4bd6e0905c018f0647f9f0e704e09dbdf531/cryptocoin_payable.gemspec#L32
Please update the money-tree dependency to the more actively maintained fork: https://github.com/GemHQ/money-tree
This fork has fixed money-tree 0.9.0's libssl-dev issue that prevents apps using cryptocoin_payable from being deployed to Heroku's heroku-16 stack:
https://github.com/GemHQ/money-tree/pull/23

I can take care of this early this week. Otherwise, if you want to submit a PR, I'd be happy to merge.
I'm using the following workaround in my project to deploy to Heroku:
gem 'money-tree', github: 'GemHQ/money-tree', branch: :master

@mhluska I'm happy to try my best with a PR but my lack of experience makes me unsure!
I understand that gemspec files do not accept dependencies from source code repositories. So, is this fix as simple as adding your suggested workaround to this repository's gemfile?

@jmarbach I looked into this and it doesn't seem like there's a way forward until the GemHQ fork publishes a gem. See https://github.com/GemHQ/money-tree/issues/27


Slight variation on many_shapes.rs has worse performance?

Hi,
Firstly, great work with this library man! The seamless integration with Bevy is a winner. I know your busy with school work so no rush on this one. But if some thing obvious stands out to you here, please let me know.
I have a weird one. I've copied the many_shapes.rs example, where instead I'm just using block and they appear every 2 seconds at the top of the screen. By the time I get to 10 the whole thing is laggy, which is weird as many_shapes.rs seems to have a lot more ridged bodies + colliders in the scene? I can't figure out what the big difference is here?
Here is the full main.rs file. Simpler than many_shapes.rs really:
use bevy::window::WindowMode;
use bevy::{prelude::*, sprite::MaterialMesh2dBundle};
use bevy_xpbd_2d::{math::*, prelude::*};
use rand::Rng;

#[derive(Resource)]
struct WordSpawnTimer(Timer);

fn main() {
    App::new()
        .add_plugins(DefaultPlugins.set(WindowPlugin {
            primary_window: Some(Window {
                resizable: false,
                mode: WindowMode::BorderlessFullscreen,
                ..default()
            }),
            ..default()
        }))
        .add_plugins(PhysicsPlugins::default())
        .insert_resource(WordSpawnTimer(Timer::from_seconds(
            2.0,
            TimerMode::Repeating,
        )))
        .insert_resource(ClearColor(Color::rgb(0.05, 0.05, 0.1)))
        .insert_resource(SubstepCount(6))
        .insert_resource(Gravity(Vector::NEG_Y * 1000.0))
        .add_systems(Startup, (setup_graphics, setup_scene))
        .add_systems(Update, (spawn_blocks, keyboard_input))
        .run();
}

fn setup_graphics(mut commands: Commands) {
    // Add a camera so we can see the debug-render.
    commands.spawn(Camera2dBundle::default());
}

fn setup_scene(mut commands: Commands, window: Query<&Window>) {
    let window = window.single();

    let width = window.resolution.width();
    let height = window.resolution.height();

    // Floor
    commands.spawn((
        RigidBody::Static,
        Position(Vector::new(0.0, -height / 2.0)),
        Collider::cuboid(width, 10.0),
    ));
    // Left wall
    commands.spawn((
        RigidBody::Static,
        Position(Vector::new(-width / 2.0, 0.0)),
        Collider::cuboid(10.0, height),
    ));
    // Right wall
    commands.spawn((
        RigidBody::Static,
        Position(Vector::new(width / 2.0, 0.0)),
        Collider::cuboid(10.0, height),
    ));
}

fn random_colour() -> Color {
    let mut rng = rand::thread_rng();
    Color::rgb(rng.gen(), rng.gen(), rng.gen())
}

fn spawn_blocks(
    mut commands: Commands,
    time: Res<Time>,
    mut timer: ResMut<WordSpawnTimer>,
    window: Query<&Window>,
    mut meshes: ResMut<Assets<Mesh>>,
    mut materials: ResMut<Assets<ColorMaterial>>,
) {
    if timer.0.tick(time.delta()).just_finished() {
        // let mut rng = rand::thread_rng();
        let window = window.single();

        let width = window.resolution.width();
        let height = window.resolution.height();
        // let half_width = width / 2.0;
        let dim = width.min(height) / 10.0;

        let square = (
            Collider::cuboid(dim, dim),
            MaterialMesh2dBundle {
                mesh: meshes.add(shape::Box::new(dim, dim, dim).into()).into(),
                material: materials.add(ColorMaterial::from(random_colour())),
                ..default()
            },
        );

        // let position = Vector::new(rng.gen_range(-half_width..half_width), height / 2.0 + dim);
        let position = Vector::new(0.0, height / 2.0);

        commands.spawn((
            square,
            RigidBody::Dynamic,
            Position(position),
            Friction::new(0.001),
        ));
    }
}

fn keyboard_input(
    keys: Res<Input<KeyCode>>,
    mut app_exit_events: ResMut<Events<bevy::app::AppExit>>,
) {
    if keys.just_pressed(KeyCode::Escape) {
        app_exit_events.send(bevy::app::AppExit);
    }
}

I'll have a look over the Johan Helsing video's to see if anything stands out to me.
word

Hi, for me this has roughly the same performance as the many_shapes example. I slightly modified how the boxes are spawned, but I can nearly fill the screen with them before performance drops:
(slightly sped up)
https://github.com/Jondolf/bevy_xpbd/assets/57632562/2f709078-a4af-45e5-9fd7-c65e79a10716
Are you running it in release mode or with opt-level = 1 in your Cargo.toml for debug mode? The repo itself has opt-level = 1, so debug mode should have similar performance as release mode, but I don't think that affects projects actually using the crate.

I'll close this now and assume it works with optimizations enabled (release mode or opt-level 1, 2 or 3 in debug mode). If you're still experiencing issues, feel free to reopen.


feat(fluid-build): support tsc -b

Check project references with tsc -b
Avoid creating an empty tsBuildInfo file when there are no input, by skip checking when checking if the task is up to date.  This allows the project references check work automatically.
Webpack will always get executed if it's dependencies are out of date (recheckLeafIsUpToDate is false). No need to include dependencies information in the done file.
CopyfilesTask knows all the input/output file and can enable recheckLeafIsUpToDate so that we don't need to trigger it if the dependent task's execution didn't change any of copyfiles input.

CopyfilesTask knows all the input/output file and can enable recheckLeafIsUpToDate so that we don't need to trigger it if the dependent task's execution didn't change any of copyfiles input.

Can you point me to this change?

CopyfilesTask knows all the input/output file and can enable recheckLeafIsUpToDate so that we don't need to trigger it if the dependent task's execution didn't change any of copyfiles input.

Can you point me to this change?

it is in miscTasks.ts

CopyfilesTask knows all the input/output file and can enable recheckLeafIsUpToDate so that we don't need to trigger it if the dependent task's execution didn't change any of copyfiles input.

Can you point me to this change?

it is in miscTasks.ts

Ahh, thank you. :)


Add release configuration similar to Editor

Add a release configuration similar to what we have for the editor
Add labels to support the configuration

Fixed by #490 and #491.


Indexes wrong when using Arduino code and custom sending program

Hi, your Arduino code and Python app work perfectly, however I wanted to use the receiving code and make custom apps on phone or desktop to control the lights... I've made a simple C# program as a test that goes through indexes 1 to NUM_LEDS and sets each LED on 0xFF0000 for half a second and turns it off before going to the next LED

The color works, the on/off works.. What doesn't work quite well is which LED to light up, if I let it run too fast it'll turn on 1 through 6, then a huge gap and will end up turning on LEDs higher than NUM_LEDS (there are more on the strip I just can't power them all to be on at the same time)
If I use Serial to show which LED is turning on and off it shows them fine

But in this example, it lit up 1 to 5 fine but then said 6 but acted on 5, same for 7, then 8 jumped the LEDs it had skipped... Some buffer / speed issue?
Any ideas welcome.

Closing since there hasn't been a response from OP in over 2 years.


⚠ Bofrost.si has degraded performance

In 8f083e4, Bofrost.si (https://www.bofrost.si) experienced degraded performance:

HTTP code: 200
Response time: 3820 ms

Resolved: Bofrost.si performance has improved in 6a6f5e3 after 9 minutes.


Cannot find module 'browser-image-compression'.

I was trying to use this, but after installing I can't seem to import the module? I don't really understand how to even do what people are saying because they just say thing's like create a d.ts file and declare it there. What does that even mean?
I've had to import it like this
import imageCompression from "../../../../node_modules/browser-image-compression/dist/browser-image-compression";

You should import like this:
import imageCompression from 'browser-image-compression';
Please a look at a working React example here:
https://github.com/Donaldcwl/browser-image-compression/tree/master/example/React App


Clear button is not working when date is given as input

I am using react datepicker in one of my project. I have been facing this issue. When I enter the date as input and try to clear it, it won't work. There is a state called "InputValue" which gets set when date is given as input. On clear it has to be set as null but does not.
Steps to replicate:

Go to https://hacker0x01.github.io/react-datepicker/#example-18
Find the example "Clear datepicker input"
Input a date eg. "07/10/2017".
Click on clear button. It does not work.

Gave an input date

Clicked on clear button

Any progress on this issue?

@MarkusLund this doesn't appear to be an issue on the demo site using the repro steps, do you have any more info?

The issue can be replicated in demo. If you enter the date manually and try to clear, it won't work.

@rafeememon As @bid007 are stating, this is an issue in both my local version and the demo.

Cool, PRs to fix it are welcome

The clear button is still not working on Firefox.

so far is still not working any platform

this works its not so pretty but it works

```ts

const [startDate, setStartDate] = useState<Date | null>(value ? new Date(value) : null);

useEffect(() => {
  document.addEventListener('click', (event: Event) => {
    if (
      event.target &&
      (event.target as HTMLButtonElement).className! === 'react-datepicker__close-icon'
    ) {
      setStartDate(null);
      onChange(''); // react-form-hook
    }
  });

  return () => {
    document.removeEventListener('click', () => {});
  };
}, [onChange]);

```


NPM Install results in multiple high vulnerabilities

(Beginner to git and overall comment process here.)
Eager to work with diagrams.
Updated brew and npm. All clear.
npm install -g diagram results in multiple "high" vulnerabilities.
Can one work around or fix these?
loaded deprecated and "insecure binaries" software is a roadblock.

Happy to take directions here, or contribute by testing, etc.

I've really not been working on this in forever. I'd be down to review a PR if you can swear it still mostly works after upgrading. I'd be surprised if the lib even works, considering I haven't updated it in years.

Number one, really appreciate your work here. Thank you.
Two -- many thanks for this fast answer. Since I am a git newcomer (getting
tired of writing n00b ha), I was worried about running things with possibly
insecure libs.
All that said it appears to work. I won't risk wasting anyone's time with a
PR, but if I do "you'll be the first to know". :-)
Thanks again.
Merry Christmas to you and yours, sir!
-Ross Mohan
Arlington, VA
On Sat, Dec 25, 2021 at 12:19 PM Francois Laberge @.***>
wrote:

I've really not been working on this in forever. I'd be down to review a
PR if you can swear it still mostly works after upgrading. I'd be surprised
if the lib even works, considering I haven't updated it in years.
—
Reply to this email directly, view it on GitHub
https://github.com/seflless/diagrams/issues/38#issuecomment-1001047284,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABS6MAUYNUSS2KWPID54V5DUSX4KPANCNFSM5KX7PJBA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Ha. Yeah, anything old will scare you with a lot of warnings. Sounds good!
On Sat, Dec 25, 2021 at 1:45 PM rmohanx @.***> wrote:

Number one, really appreciate your work here. Thank you.
Two -- many thanks for this fast answer. Since I am a git newcomer (getting
tired of writing n00b ha), I was worried about running things with possibly
insecure libs.
All that said it appears to work. I won't risk wasting anyone's time with a
PR, but if I do "you'll be the first to know". :-)
Thanks again.
Merry Christmas to you and yours, sir!
-Ross Mohan
Arlington, VA
On Sat, Dec 25, 2021 at 12:19 PM Francois Laberge @.***>
wrote:

I've really not been working on this in forever. I'd be down to review a
PR if you can swear it still mostly works after upgrading. I'd be
surprised
if the lib even works, considering I haven't updated it in years.
—
Reply to this email directly, view it on GitHub
<https://github.com/seflless/diagrams/issues/38#issuecomment-1001047284
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ABS6MAUYNUSS2KWPID54V5DUSX4KPANCNFSM5KX7PJBA
.
Triage notifications on the go with GitHub Mobile for iOS
<
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
<
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/seflless/diagrams/issues/38#issuecomment-1001060514,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAONN75EEGDCI2NEECQN3USYGNTANCNFSM5KX7PJBA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

--
Francois Laberge
Applied Research at Bose
+1<PHONE_NUMBER>


add support for frequency tag

@mauruns could you please double check the frequency tag → I am not seeing it in the manual for WV files, e.g. SMW https://scdn.rohde-schwarz.com/ur/pws/dl_downloads/pdm/cl_manuals/user_manual/1175_6632_01/SMW200A_UserManual_en_37.pdf#page=350

The FREQUENCY tag is documented for the IQR device: https://scdn.rohde-schwarz.com/ur/pws/dl_downloads/dl_common_library/dl_manuals/gb_1/i/iqr_1/IQR_UserManual_en_12.pdf#page=89


Migrate from pysam to pyfaidx

since the pysam dependency cause trouble (when the conda channels as misconfigured) and since chromosome name parsing is very fragile in pysam (https://github.com/kipoi/kipoi/issues/330#issuecomment-420054392), I propose to migrate from pysam.FastaFile to pyfaidx.Fasta.

We're experiencing similar issues with pysam, and as the author of pyfaidx please let me know if there's anything I could do to help. It's worth noting that pyfaidx.FastaRecord implements a numpy array interface which could help with the efficiency (or at least clarity) of your one hot encoding, and as ML methods are something I'd like to support more directly maybe it makes sense to provide this capability in a simpler and more efficient way.

Hi! Totally agree with It. Thanks for developing and supporting pyfaidx! I made the PR more than a year ago to solve this issue: https://github.com/kundajelab/genomelake/pull/19. @jisraeli @chrisprobert any plans to merge it?
Regarding the one-hot-encoding, I think the main overhead is to iterate through the python string and populate the numpy array. Genomelake uses cython to do this for efficiently. I think the best solution would be to write a separate library just doing one-hot-encoding and then use it together with pyfaidx.


Twitch extention

Surviv Exploit doesn't work on the twitch custom game extension
https://www.twitch.tv/popout/prismatichub/extensions/c79geyxwmp1zpas3qxbddzrtytffta/panel

This feature can be added easily. Just add the extension URL to URL list in the hack. It's somewhere in some .js file 😉

Surviv Exploit doesn't work on the twitch custom game extension
https://www.twitch.tv/popout/prismatichub/extensions/c79geyxwmp1zpas3qxbddzrtytffta/panel

try this
survivio-plus-master.zip

its not that easy because the popuout is like a mobile version of surviv hopefully kalab can fix this

@Kalaborative it is possible but the popout runs a different version of the game. you can still add the script, but managing two different branches is too much wokr

Oh okay, I figured because it doesn't even look like it's trying to update anything to it


fix: Updated titles according to the latest docs

Description
Updated titles of Issue templates according to the latest docs
Closes: #417
Have you read the Contributing Guidelines on Pull Requests?

[X] Yes
[ ] No

Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)

Checklist:

[X] My code follows the style guidelines(Clean Code) of this project
[X] I have performed a self-review of my own code
[X] My changes generate no new warnings

/assign


pageserver: merge get page requests

Problem
We don't take advantage of queue depth generated by the compute
on the pageserver. We can process get page requests more efficiently
by batching them.
Summary of changes
Hold get page requests for configurable maximum debounce timeout in order
to facilitate merging. Then process the entire batch via one get_vectored timeline operation.
By default, no merging takes place.
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

The terminology is 50% debounce 50% batching.
I think batching is better, let's adjust the names.
As a person who doesn't mind wordy names, page_service_server_side_batching is how I'd call the functionality / code module.
Maybe server_side_batch_timeout for the config flag?
And BatchedFeMessageS instead of DebouncedFeMessage for the type?

You're right. I'll touch up the names.

During the hackathon, and now, I wonder(ed) whether we could refactor the batching loop into a Stream / $itertoolsadapter
Like, at the start of handle_pagerequests, split the pgb into reading and writing end (maybe fake that using Arc<Mutex<Pgb>>). The wrap the reading end into the thing that implements Stream, spitting out DebouncedFeMessage as the strema item.

I also wondered about this while going through the code, but resisted the temptation to rewrite.
Let's create an epic and add a follow-up in there.

Orthogonal to that, can we please move the batching into a helper function so the high-level control flow of handle_pagerequests remains clear-ish?

Sure, I'll give it a go.

Switched naming to batching
Looked into logging. We already log on both pagestream and ingest flows, so I've removed the redundant logging.
Reworked response filling to work around one copy
Refactored batching into a separate method.


Update Makefile to not allow unset variables

Adding SHELLFLAGS and switch to double dollar signs to prevent make from expanding bash variables
Which issue this PR addresses:
No current issues.

What this PR does / why we need it:
Currently unset variables are allowed in Makefile. I don't believe there should be a case where we need/want unset variables, I believe this a safer option.
.SHELLFLAGS := -o nounset -c sets nounset and variables are expanded by bash by escaping with double dollar signs.

Test plan for issue:
Existing tests that utilize make

Is there any documentation that needs to be updated for this PR?
No

I also ran build and push pipeline to ensure that functionality isn't impacted:
https://msazure.visualstudio.com/AzureRedHatOpenShift/_build/results?buildId=71135590&view=results


Composer: package fgrosse/phpasn1 is abandoned, you should avoid using it

https://packagist.org/packages/fgrosse/phpasn1
This library is no longer actively maintained.

public-square/phpecc has a requirement on it, and there's an issue there already. https://github.com/phpecc/phpecc/issues/285
As far as I can see,  SchnorrSignature (because that why we depend on phpecc) has no uses from that package at all, so it's not a problem at all at this point. Unless we can find a replacement package for that functionality (without forking it ourselves, not my intention), we can ignore that warning.
If we could add something to our code to suppress that warning, that would be even better, but I don't think composer has that (unless I'm looking wrong).

subscribed myself on the other issue - phpecc is relatively unmaintained too, but we need that. Again, no real big issues here.


wrap lifespan decorator in docs and add missing type

This is my solution for #1361 if you like it feel free to merge.

I guess the test in docs_src/fastapi/docs001.py needs some changes too?

Awesome, thanks for the fix! :)


HDFS-16500. Make asynchronous blocks deletion lock and unlock durtion…

https://issues.apache.org/jira/browse/HDFS-16500
I have backport the nice feature HDFS-16043 to our internal branch, it works well in our testing cluster.
I think it's better to make the fields deleteBlockLockTimeMs and deleteBlockUnlockIntervalTimeMs configurable, so that we can control the lock and unlock duration.
private final long deleteBlockLockTimeMs = 500;
private final long deleteBlockUnlockIntervalTimeMs = 100;

And we should set the default value smaller to avoid blocking other requests long time when deleting some  large directories.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

-1 :x:
mvninstall
3m 32s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
2m 19s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 13s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 54s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  9s

trunk passed

+1 :green_heart:
shadedclient
25m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 54s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 284 unchanged - 0 fixed = 285 total (was 284)

+1 :green_heart:
mvnsite
1m 21s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 16s

the patch passed

+1 :green_heart:
shadedclient
22m 42s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
230m 30s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

303m 53s

Reason
Tests

Failed junit tests
hadoop.tools.TestHdfsConfigFields

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4061/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4061

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux da3081bf758f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4419c1ccefbf54a19c000cfad9e4732d751651d9

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4061/1/testReport/

Max. process+thread count
3059 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4061/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao could you please take a look?

@smarthanwang Thanks for your work , new parameters need to be added to hdfs-default.xml.

@smarthanwang Thanks for your work , new parameters need to be added to hdfs-default.xml.
@zhuxiangyi  good suggestion, I would fix it.

Thanks @smarthanwang involve me here. It almost look good to me. Just one nit, it seems changes default value here, any consideration? Just suggest keep it if no any concerns. Thanks again.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m  9s

trunk passed

+1 :green_heart:
compile
1m 32s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 24s

trunk passed

+1 :green_heart:
shadedclient
26m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 24s

the patch passed

+1 :green_heart:
compile
1m 30s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 30s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 52s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 284 unchanged - 0 fixed = 285 total (was 284)

+1 :green_heart:
mvnsite
1m 24s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 36s

the patch passed

+1 :green_heart:
shadedclient
25m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
348m 24s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

458m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4061/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4061

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux ac02869061b7 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 19af2f3af7e0619e204de491885220182eb2fe6e

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4061/2/testReport/

Max. process+thread count
2195 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4061/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @smarthanwang involve me here. It almost look good to me. Just one nit, it seems changes default value here, any consideration? Just suggest keep it if no any concerns. Thanks again.

@Hexiaoqiao thanks for comment.
When deleting a large directory, the deletion loop would continue for a long time, if we set the lock holding limit as 500ms, the rpcQueueTime of almost all rpc requests would increase to 500ms, it's too long for production cluster. So I think it's better to set a smaller default value which is not much greater than the avgRpcQueueTime of our cluster.

Hi @Hexiaoqiao, do you have any suggestion?

@Hexiaoqiao thanks for reviews.

Committed to trunk. Thanks @smarthanwang for your contributions.
BTW, Would you like to fix checkstyle about method length is 156 lines is over 150 limit for BlockManager, IMO this is historical issue, we should file another issue to refactor it.

@Hexiaoqiao thanks you. I would fix the checkstyle later

@Hexiaoqiao I have filed issue https://issues.apache.org/jira/browse/HDFS-16553 to fix the checkstyle, please take a look.