[WalletConnect] handle eth_sign

Safe apps currently don't have any way to generate pure off-chain signatures (that don't require a transaction) that can be validated via EIP-1271. BUT the safe has a method called signMessage that can be used to mark a message hash as "signed" so that when the EIP-1271 callback is called it is a valid signature.
Steps:

the hash passed via eth_sign needs to be converted to bytes and a transaction that calls signMessage with it needs to be created (see https://github.com/gnosis/safe-contracts/blob/development/contracts/GnosisSafe.sol#L307)
A signature with 0 length needs to be returned to the dapp (see https://github.com/gnosis/safe-contracts/blob/development/contracts/GnosisSafe.sol#L330)
The dapp needs to call the old EIP-712 validation method (isValidSignature(bytes calldata _data, bytes calldata _signature))

For rinkeby we can write a new fallback handler that converts the new method to the old method

Should it also respond to eth_personalSign?
I'm trying to understand the difference but not really successful. Found this: https://gist.github.com/miguelmota/f75be1de350a0196db4a90cc96a5505f

Should it also respond to eth_personalSign?
I'm trying to understand the difference but not really successful. Found this: https://gist.github.com/miguelmota/f75be1de350a0196db4a90cc96a5505f

I would ignore personal_sign for now

I would ignore personal_sign for now

@rmeissner any help here? I am trying to sign a message with my EOA. This is what I have set up currently.
This is with a single owner on the safe on Rinkeby

Opensea has a personal_sign request with string :
I translate it to a EIP712_SAFE_MESSAGE_TYPE and sign with my wallet :

const hash = ethers.utils.hashMessage(<message to sign>)
const sig = await signer._signTypedData(
                {
                  verifyingContract: <safe address>,
                  chainId: <safe chain id>,
                },
                EIP712_SAFE_MESSAGE_TYPE,
                { message:  hash }
              );

Call to isValidSignature(hash, sig) returns the magic value 0x1626ba7e   (so that works)
The signature is sent to Opensea but is never authorized.

Any idea what opensea is using for auth check? If they do call isValidSignature are they not passing the same hash that I signed?
Thanks!

@rmeissner any help here? I am trying to sign a message with my EOA. This is what I have set up currently.
This is with a single owner on the safe on Rinkeby

Opensea has a personal_sign request with string :
I translate it to a EIP712_SAFE_MESSAGE_TYPE and sign with my wallet :

const hash = ethers.utils.hashMessage(<message to sign>)
const sig = await signer._signTypedData(
                {
                  verifyingContract: <safe address>,
                  chainId: <safe chain id>,
                },
                EIP712_SAFE_MESSAGE_TYPE,
                { message:  hash }
              );

Call to isValidSignature(hash, sig) returns the magic value 0x1626ba7e   (so that works)
The signature is sent to Opensea but is never authorized.

Any idea what opensea is using for auth check? If they do call isValidSignature are they not passing the same hash that I signed?
Thanks!

This seems to be a question for OpenSea.


Extreme mode

Add extreme mode (bans grays and same-position yellows). Changes the way the game tracks hints to allow for specific highlighting of conflicting hints (also beneficial far hard mode).

i like this. it is not, as i thought at first, weird and silly and useless.
an interesting game-within-game is to try and lose in 'extreme' mode. (this is never, in fact, easy, and is not always possible).
my main tactic in regular mode is what i imagine to be the most common one; guess 2 or 3 ground-covering words, and then basically play extreme mode, with a few exceptions if i think of a clever test. it turns out those exceptions are VERY useful, and my average play time on extreme mode is significantly higher than on regular or hard mode.

I also feel it is a bit harder to lose in extreme mode, since, you cannot waste turns as easily as with hard mode. It does quite often take more thinking effort than hard mode, and sometimes it takes several minutes to come up with a guess that's allowed.
I do enjoy playing a challenge, that consists of starting each round with a word that starts on a different letter from the alphabet. So first guess of first round needs to start with A, first guess of second round with B, etc. Since extreme mode will limit your choices a lot from the second guess onwards, depending on what you got from the first guess, each round tends to feel much more unique since your repertoire of go-to guesses almost never meets the requirements. I feel playing that challenge in extreme mode has significantly improved the variety of my guesses. 🙂

Hi! Just wanted to be clear that from my side this PR is ready to be pulled. The hints would be a separate PR later once I get to them. 😄

I rebased my commits on your master branch. But I think you need to fix something in the CI because everything fails in setup.


First issue lint fix

Hi,
I stumbled upon this repo whilst experiencing the #251 bug and saw that it is open for contributions.
So as a first issue this PR fixes two small lint issues that are reported as warnings when running yarn start command. If this is helpful I might continue contributing and fix some listed issues.
lint issues fixed in this PR
/src/App.js
  Line 153:5:  'PathWithSideMenu' is assigned a value but never used  no-unused-vars

./src/components/LocationBanner/LocationBanner.js
  Line 77:25:  Missing '()' invoking a constructor

I really don't like the implementation of menu links. It's in the backlog to reimplement them as a more generic component, instead of adding in individual paths one at a time.


[feat (issue #6389)] make tauri icon support SVGs

What kind of change does this PR introduce?

[ ] Bugfix
[ x] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x ] No

Checklist

[x ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ x] I have added a convincing reason for adding this feature, if necessary

Other information
This allows .SVG files to be passed into the CLI's icon module. This was a request in the issues tab

This is an awesome addition! @amrbashir maybe this is something we could use downstream in CTA later as well to reduce the size even more?

Cool! If this ends up getting merged, it will save us a couple of hunderd kilobytes

@fetzsav we were just having a slight sidebar for CTA (create-tauri-app) for a few ideas of how this could help get us closer to shrinking the templates down there in the future. You'd still need to generate the raster images to use in icons, this PR just helps us get closer to using SVGs to generate those raster images and then in theory in the future we could use that functionality to optimise CTA.
tl;dr no impact to this, just some enhancements we could get closer to downstream with this PR

I think this feature should target the v2 release, v1.3 is pretty much ready and the idea is to focus 100% on v2 when that release is out.

I tried to use resvg but couldn't get the resize to work. Can you review @FabianLars ?


Move Common Sharing JS to SN

Move addSharingToNewShareableForm from host apps.
Add dummy view used in specs.
Move specs to SN testing suite.

[Finished: #103441490]

:copyright:


Ripple effect background is not changing

<com.ashokvarma.bottomnavigation.BottomNavigationBar
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="bottom"
android:layout_alignParentBottom="true"
app:bnbMode="mode_shifting"
app:bnbBackgroundStyle="background_style_ripple"
android:id="@+id/bottom_nv_view"
>
</com.ashokvarma.bottomnavigation.BottomNavigationBar>
the background color is not changing when item is selected... means when  i selected item its should show ripple with diff colors , but is not showing . it showing single color as background for all items

Hi Jagadish https://github.com/Ashok-Varma/BottomNavigation/wiki/Customisations please follow wiki for customisations


Replace yajl and json gem with multi JSON?

Right now there is a bit of custom code for both yajl and json-gem, which both behave slightly differently. I'd like to start a discussion about what the future should be for that.
I'd suggest that either:

We switch to using multi_json (which supports all manner of json parsers with a unified api), or
We switch to only supporting json (like rails did) and simplify the code a bit

There is an argument that multi_json is deprecated and nowadays the right move is for everyone to use json-gem, but I can't help thinking people should be given the choice (and therefore multi json is better)

In that case, only the code that specialises on yajl has to be removed if I am correct? I would do the changes if you can confirm that it is the consensus.

Yes, I think so
On Wed, 10 Jun 2015 at 7:46 pm, Frederic Branczyk<EMAIL_ADDRESS>wrote:

In that case, only the code that specialises on yajl has to be removed if
I am correct? I would do the changes if you can confirm that it is the
consensus.
—
Reply to this email directly or view it on GitHub
https://github.com/ruby-json-schema/json-schema/issues/195#issuecomment-110874360
.

Nevermind, it seems like #206 already did the work, I looked at the wrong branch. I guess this issue can be closed?

Sorry, yes. It's schedule for v3.
On Sun, 21 Jun 2015 at 9:12 pm, Frederic Branczyk<EMAIL_ADDRESS>wrote:

Nevermind, it seems like #206
https://github.com/ruby-json-schema/json-schema/pull/206 already did
the work, I looked at the wrong branch. I guess this issue can be closed?
—
Reply to this email directly or view it on GitHub
https://github.com/ruby-json-schema/json-schema/issues/195#issuecomment-113951183
.


Do not warn in check-config script about ext3 if provided by ext4

Many distributions now use ext4 to provide ext2 and ext3 support,
so do not warn about possibly missing ext3 support if the config
option is used.
Signed-off-by: Justin Cormack<EMAIL_ADDRESS>

/cc @tianon @dmcgowan

ping @tianon @dmcgowan

Not very familiar with how this script is used but change looks reasonable


adding executable

Hello,
Thanks for such a nice tool, is it possible to add exe payload in shell code? . Also good write with demo with working of this tool.
Regards

What interests you can be found by the query "image x86 polyglot". As an example: https://www.rapid7.com/db/modules/encoder/x86/bmp_polyglot
The pixload has no such purpose, afaik. However, Pull Requests are welcome.

Also good write with demo with working of this tool.

See  #4 for more info.


Error while trying to register a new name from chrome extension

Describe the bug
I created a new wallet topped up with enough tokens (450AE ) and I get an error when registering a chain name, tried many different ones with the same issue.
To Reproduce
Steps to reproduce the behavior:
1.Downloaded the new version (last one)
2. Created a new wallet
3. Backup my seed
4. Tried to register mynewchainnameomar.chain
5. get error: "Value undefined is not type of number"
Expected behavior
It should allow me to register a name
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: MacOs Catalina 10.15.6
Browser Chrome
Version Version 86.0.4240.198 (Official Build) (x86_64)

Same problem for me.

@omar-saadoun @thescientress This issue was fixed among other AENS problems 2 days ago here https://github.com/aeternity/superhero-wallet/pull/603 and will be available with next release.


Get latest changes from master

Includes bug fix for FTP prereq downloads on Linux and copyright updates, among other fixes

Current coverage is 39.12%

Merging #136 into devel will decrease coverage by -0.07% as of c0cc5c5

@@            devel    #136   diff @@
=====================================
  Files           2       2
  Stmts         893     892     -1
  Branches        0       0
  Methods         0       0
=====================================
- Hit           350     349     -1
  Partial         0       0
  Missed        543     543

Review entire Coverage Diff as of c0cc5c5

Uncovered Suggestions

+1.92% via src/mpi/mpi_caf.c#1904...1920
+1.58% via src/mpi/mpi_caf.c#2002...2015
+1.58% via src/mpi/mpi_caf.c#1557...1570
See 7 more...

Powered by Codecov. Updated on successful CI builds.

Had to manually resolve version number bump.
Retro-active:
Looks good to me!


Street Fighter 6 format issue

Hi!
I stumbled upon this repo while researching the Street Fighter 6 save game format. I haven't heard about Lime encryption before and can't find any other resource on the format. Are you aware of any?
Street Fighter 6 seems to use this format. However, LimebrellaSharp crashes once I try to load the win64_save folder into it (see below).
Here's the Hex header of data00-1.bin: 44535353 02000000 04000000. I suppose encryption type 0x04 is not supported yet?
If you're interested (and it's possible to decrypt this), i can send you my steamID + the save game.
Thanks!
System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at LimebrellaSharpCore.Helpers.LimeDeencryptor.EncryptionFirst(Span`1& containerA, ReadOnlySpan`1 containerB)
   at LimebrellaSharpCore.Helpers.LimeDeencryptor.Limegator(Span`1 containerA, ReadOnlySpan`1 containerB, ReadOnlySpan`1 containerC)
   at LimebrellaSharpCore.Helpers.LimeDeencryptor.HashPublicKeys(Span`1& segmentHashedKey, ReadOnlySpan`1 cKey1, ReadOnlySpan`1 cSteamId, ReadOnlySpan`1 limeBank)
   at LimebrellaSharpCore.Helpers.LimeDeencryptor.Limetree(DsssLimeFile limeFile, UInt64 steamId, Boolean encrypt)
   at LimebrellaSharp.Form1.<>c__DisplayClass18_1.<UnpackAll>b__1(Int64 ctr)
   at System.Threading.Tasks.Parallel.<>c__DisplayClass20_0`1.<ForWorker64>b__1(RangeWorker& currentWorker, Int32 timeout, Boolean& replicationDelegateYieldedBeforeCompletion)
--- End of stack trace from previous location ---
   at System.Threading.Tasks.Parallel.<>c__DisplayClass20_0`1.<ForWorker64>b__1(RangeWorker& currentWorker, Int32 timeout, Boolean& replicationDelegateYieldedBeforeCompletion)
   at System.Threading.Tasks.TaskReplicator.Replica.Execute()

Hi!
Lime is a codename of a custom encryption developed by Capcom and so far I've only seen it in PC version of the recent Resident Evil 4 Remake.
Street Fighter 6 is using other custom encryption called "Citrus". Unfortuntely, my tool does not support encryption types other than Lime. Currently I have no plans to examine it and if I ever will then I would rather make a different tool with another cool name like Sweet Citrus Six.
Sorry, I couldn't be more helpfull.

That's fair, thanks for the quick reply.
Still, can you point me to any resource regarding Citrus encryption? Or even how you know identified this as Citrus?

Sure, here is how I did it.
First I downloaded REFramework by praydog from that repo and copied its content to a game folder. From what I can see, SF6 is also supported by it.
After I run the game, in the cheat menu that appeared, I navigated to DeveloperTools>ObjectExplorer>NativeSingletons>via.storage.SaveService.SaveService>Reflection Properties>SaveEncryptionType. There you can read "Citrus". If you go deeper to Additional Information>via.storage.SaveService.SaveDataEncryptionType>TDB Fields, then you can the enumerator with all possible encryption types. That's how I found their names.
Sadly, I am not aware of the existence of any resources or documentation of the Citrus encryption.
If you only want to use your SaveData on another Steam account then it may be possible without decrypting that file.

thank you for telling me :)

Monster Hunter Rise also uses this format. I took a peek but didn't learn much other than the last four bytes in the file are a murmur3_32 hash(seed = 0xFFFFFFFF) over the rest of the file.

@windwakr
Thank you for identifying the hash's name. I will rename the function and give you credit in the comment.
Regarding MH Rise, the SaveData files from 2022 that I found on the Internet were already decrypted so I didn't bother.
I installed the latest version of the game, and now its SaveData files look like they were encrypted with the Cytric method.
8 bytes before murmur3_32 hash is the length of the decrypted data.

Can you please make a tool for SF6 ? i really don't wanna go through the world tour for the second time :) it's just frustrating ..

Hi @FarshadGrayson,
If you're asking me, then I'm sorry to say I don't own the full game and I'm not currently interested in playing it.


Call to a member function newLoop() on null

Good day!
I want to use the helper even, if the view is not in the cache, it works successfully as soon as the error is cached:
Call to a member function newLoop() on null

tell me please how to solve this?

Hello!
Please provide:

a list of steps to replicate this error.
the laravel and blade-extensions versions in use
stack trace

7.1.0 should fix this


Remove margin top of search input when it is not wrapped by a label

So the search button doesn't look deformed

Will make it again


Security fixes

select2 will render HTML returned from formatResult and
formatSelection.
Users are intended to use the escapeMarkup method when writing these
methods.
An attacker could inject HTML into the admin be signing up with a
specially crafted email address.
select2 will render HTML returned from formatResult and
formatSelection.
Users are intended to use the escapeMarkup method when writing these
methods.
This prevents admins from injecting HTML which would be visible to other
admins.
If link_to_with_icon was called with an unsafe (!html_safe?) text
attribute it would render it on the page without escaping.
This is never used in an unsafe way in the spree admin itself, but
it could be dangerous in custom admin components.
Use safe_join instead of html_safe where possible
These methods were joining safe and unsafe strings and then considering the output safe.
Especially concerning are display_line_item and display_variant could likely allow an user with admin permissions to inject HTML unescaped into the admin.
Conflicts:
backend/app/helpers/spree/admin/base_helper.rb
admin/search#users should be top-level json object
Returning a top level array is vulnerable to JSON hijacking, as the
JSON can be interpreted as valid javascript.
Conflicts:
SPREE_VERSION
cmd/lib/spree_cmd/extension.rb
core/lib/spree/core/version.rb

 Cherry-pick Spree Security Patch

 Cherry-pick Spree Security Patch


ironbar: 0.14.1 -> 0.15.0

Description of changes
closes https://github.com/NixOS/nixpkgs/issues/307687
https://github.com/JakeStanger/ironbar/releases/tag/v0.15.0
overcame a few build issues using nix develop .#ironbar in a cloned version of ironbar, this resulted in me adding the following new inputs to fix the build issues:

libpulseaudio
luajit
lua51Packages.lgi

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 307726 run on x86_64-linux 1

1 package built:

ironbar

The LUA_PATH and LUA_CPATH env vars need to be set at runtime when the cairo feature is enabled (which it is by default). These need to point to the lua-lgi package. This can be done in gappsWrapperArgs.
Implementation in the repo version:
https://github.com/JakeStanger/ironbar/blob/d37547e046b50c418b6e388a249fd3e6aedfdd75/nix/default.nix#L75-L78


Test workflow for fetching project id

Working as intended. Testing is finished.
Further testing will be done in a "real" team project(dapla-stat) and in a different branch https://github.com/statisticsnorway/dapla-source-data-processor-build-scripts/pull/21


Plugin [id: 'com.diffplug.gradle.spotless', version: '3.14.0'] was not found

Plugin [id: 'com.diffplug.gradle.spotless', version: '3.14.0'] was not found in any of the following sources:

Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
Plugin Repositories (could not resolve plugin artifact 'com.diffplug.gradle.spotless:com.diffplug.gradle.spotless.gradle.plugin:3.14.0')
Searched in the following repositories:
Gradle Central Plugin Repository

Do you have the latest copy of master? The project syncs fine for me.

Do you have the latest copy of master? The project syncs fine for me.

Yes I pulled fresh copy of master yesterday and wasn't able to compile the code.
Thanks fro reply.

It's a little weird since 3.14.0 is available on Gradle Central Plugin Repository (latest is 3.16.0).
Can you run ./gradlew spotlessApply from a terminal?

I updated on following two places which fixed the error for me.
classpath 'com.android.tools.build:gradle:3.3.0-beta02'
TO
classpath 'com.android.tools.build:gradle:3.4.0-alpha02'
and :
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-bin.zip
TO
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-all.zip
which fixed the issue for me. Thanks @ataulm

:+1: glad it's resolved but I don't think I helped 😅
If you're able, please close this issue 😊


I need some advice on authorization

Hi. I am looking for advice on the logic of authorization.
I'm trying to upgrade the ruby gem to a new version of tdlib and I don't understand how to work with authorization.
Old version is - eb80924
In the old version, every time it was necessary  to send requests to telegram, a new client instance was created, a request was sent to setTdlibParameters, followed by checkDatabaseEncryptionKey, after which the rest of the operations were performed from the same client.
In the new version, setTdlibParameters is missing and after setTdlibParameters it is required to go through the confirmation code, which is absolutely unacceptable for my tasks.
What can you recommend? I'm thinking about using the singleton pattern to work with the client, but I'm not sure if this is the right option.

See https://core.telegram.org/tdlib/getting-started#user-authorization.
checkDatabaseEncryptionKey doesn't exist anymore and setTdlibParameters didn't change conceptually.


scatterND error when using model_profile on an .onnx file

I encountered an error when I use the following code to produce a MACS summary and shape onnx:
import onnx_tool
onnx_tool.model_profile('clipEncoder.onnx',saveshapesmodel='clipEncoder_shapes.onnx')
The following error occurs:
in onnx_tool/node.py:
def scatter_nd_impl(data, indices, updates, reduction='none'):  # type: ignore
# Check tensor shapes
assert indices.shape[-1] <= len(data.shape)
AssertionError
This is because since the expression is: 22<=2, due to:
indices.shape
(1, 1, 22)
indices[0,0,:]
array([1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1.,
1., 1., 1., 1., 1.], dtype=float32)
data.shape
(1, 77)
data[0,:]
array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0])
The .onnx file was produced for the ClipEncoder in stable diffusion v2:
https://github.com/Stability-AI/stablediffusion/blob/main/ldm/modules/encoders/modules.py
under the class:
class FrozenOpenCLIPEmbedder(AbstractEncoder):
...
def encode(self, text):
with torch.no_grad():
torch.onnx.export(self,text,"clipEncoder.onnx",opset_version=12)
return self(text)

def encode(self, text):
with torch.no_grad():
torch.onnx.export(self,text,"clipEncoder.onnx",opset_version=12)
return self(text)

Please provide a test input of 'text'.

With classifier-free guidance, the text is an empty condition [''], or any conditional text, e.g.
text
['cartoon style']

A simple way to recreate is just try:
python scripts/txt2img.py --prompt "a professional photograph of an astronaut riding a horse" --ckpt <path/to/768model.ckpt/> --config configs/stable-diffusion/v2-inference-v.yaml --H 768 --W 768
or
python scripts/img2img.py --prompt "A fantasy landscape, trending on artstation" --init-img <path-to-img.jpg> --strength 0.8 --ckpt <path/to/model.ckpt>

I've reproduced your issue. But, I've confirmed the inputs of scatterND are correctly calculated. And I've checked that there is no update code for  scatter_nd_impl.
So I need more time to check whether this model is correctly exported or this is an invalid case of  scatter_nd_impl.

There is a workaround solution:
def forward(self, tokens):
      z = self.encode_with_transformer(tokens.to(self.device))
      return z

Do not export tokenize module as BERT does.

For encode:
    def encode(self, text):
        token=open_clip.tokenize(text)
        with torch.no_grad():
            torch.onnx.export(self, token, "clipEncoder.onnx", opset_version=12)
        return self(token)

Thank you for the work around. Unfortunately, I still encounter an error:
File "/home/usr1/anaconda3/envs/stableDiffusion/lib/python3.8/site-packages/onnx_tool/node.py", line 1672, in shape_infer
assert raw == volume(newshape)
AssertionError
raw
78771
newshape
[77, 16, 64]
volume(newshape)
78848
Additionally, if I remove that line, I am able to produce the shape onnx file and the summary. However, the number of parameters seems off, since the onnx_tool summary gives the total:
Total            22,811,725,305  100%        1,338,963,850  100%        340,393,938  100%        _          _
But if one prints the total number of parameters:
ss=0
for p in self.model.parameters():
ss=ss+len(p.flatten())
print(ss)
354032641
there seems to be a discrepancy: 340,393,938 vs 354,032,641.
I notice the warning:
Please note that Weight Tensors Sharing is detected:
Tensor:onnx::Reshape_3239
Shared by:
Identity_4
Identity_5
Identity_6
Identity_11
...
Tensor:onnx::Mul_3248
Shared by:
Identity_3
Identity_10
Identity_17
Identity_24
Identity_31
Identity_38
...
etc.
but I am unsure if this is the root cause.

assert raw == volume(newshape)

This should be a bug of v0.6.0. v0.6.1 was released yesterday to fix this. These summary print of v0.6.1:

Total
23803402305
100%
1944165092
100%
352990169
100%

Please note that Weight Tensors Sharing is detected:

ONNX will compress parameters into one tensor if some constant tensors are shared among layers.
In the torch model, they will be two tensors.

Strange, I have upgraded the package via pip install -U onnx-tool, and the version is now v0.6.1, with the assert raw error fixed, but the summary still gives the incorrect information:
Total            22,811,725,305  100%        1,338,956,766  100%        340,393,938  100%        _          _
Could you let me know if I should change any other bits of the code to reproduce your summary result?

I used the command:
onnx_tool.model_profile('clipEncoder_noTokenizer.onnx',saveshapesmodel='clipEncoder_noTokenizer_shapes_new.onnx')
Could you let me know yours?


Failed forwards for QR payments are considered paid

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
When someone has a receiving wallet attached and we are anon or have no wallets attached, we will show a wrapped invoice in a QR code.
When the incoming payment arrives, the UI immediately considers the payment successful even though the forward can still fail.
Screenshots
https://github.com/user-attachments/assets/d37e5d22-14f8-4841-bb3e-dbe28fde7ee2
Steps To Reproduce

Set max fee to 0 so forwards fail
Pay someone with receiver wallet as anon
QR code disappears because we use inv.satsReceived > 0 to check for success but payment failed

Expected behavior
Payment fails if forward failed and we immediately fallback to SN?
Logs
No response
Device information
No response
Additional context
This is basically the same bug as #1707 but in <Invoice> instead of in useInvoice.

This is so that anon doesn't have to wait X seconds to find out it failed ... only to be able to do nothing about it.

This isn't a bug so much as it's a lack of a feature.

I knew you were going to say this :eyes:
I think as it is, this is super confusing UX and doesn't look trustworthy if we tell them their payment was successful while their wallet will tell them it failed. This is worse than just being transparent that the receiver wallet failed.
Imo, we don't need to have optimistic UX for QR codes. If someone is going to pull out their phone to scan a QR code, I don't think they mind waiting a few seconds to see if it was actually successful.
The UI is also in a messed up state because we store the sats locally but the backend knows it didn't work. So it's possible to see an item with 0 sats but still have a zap bolt colored in 1000 sats.

only to be able to do nothing about it.

I don't think they mind waiting a few seconds to see if it was actually successful.

How about waiting 30 seconds to learn that it failed?

Yeah, this is a feature request.

Okay, I see, we are basically disagreeing on if closing the QR code is better than keeping the QR code open for up to 30 seconds while it already says "sats received". My point is that closing the QR code is worse because that looks like a even more serious bug.

I'm all for making this better though.

Okay, I'll label this as a feature request then. My idea is to have an additional state for settling the invoice so they at least know what is going on. We discussed this somewhere already iirc.

My point is that closing the QR code is worse because that looks like a even more serious bug.

You're only considering the current worst case. The average case of your solution is worse imo.


The executable requests the com.apple.security.get-task-allow entitlement.

When trying to notorise the app with xcrun altool --notarize-app --primary-bundle-id "com.myApp.app" --username "---" --password "---" --file myApp.app
We get the following errors back from Apple, any ideas how we can fix this?

Without notarization users cannot install the app.

Setting this to no fixes it. Have not tested the update yet.

After disabling this setting the automatic update fails.

For anyone else who is stuck, you have to add the following build steps.
# Sign Sparkle https://sparkle-project.org/documentation/sandboxing/
CODE_SIGN_IDENTITY="Developer ID Application: [you developer id]"
codesign -f -s "$CODE_SIGN_IDENTITY" -o runtime ${build_loc}my-app.app/Contents/Frameworks/Sparkle.framework/Versions/B/XPCServices/org.sparkle-project.InstallerLauncher.xpc
codesign -f -s "$CODE_SIGN_IDENTITY" -o runtime --entitlements Entitlements/org.sparkle-project.Downloader.entitlements ${build_loc}my-app.app/Contents/Frameworks/Sparkle.framework/Versions/B/XPCServices/org.sparkle-project.Downloader.xpc
codesign -f -s "$CODE_SIGN_IDENTITY" -o runtime ${build_loc}my-app.app/Contents/Frameworks/Sparkle.framework/Versions/B/Autoupdate
codesign -f -s "$CODE_SIGN_IDENTITY" -o runtime ${build_loc}my-app.app/Contents/Frameworks/Sparkle.framework/Versions/B/Updater.app
codesign -f -s "$CODE_SIGN_IDENTITY" -o runtime ${build_loc}my-app.app/Contents/Frameworks/Sparkle.framework

@lijy91 might be good to have some docs on this.

I had the similar issue, in my case it was different sparkle files that cause the notarize issue. What i did was signing the whole Sparkle framework using --deep before exporting the app so that we don't have to resign our own app.
codesign -f -s "$CODE_SIGN_IDENTITY" -o runtime --deep Pods/Sparkle/Sparkle.framework/


Fix volume cache issue with buildah bud --layers

buildah bud would fail at the next step after a VOLUME command
due to buildah trying to cache the volume contents and restore it
later, but the intermediate container used at the VOLUME step didn't
exist anymore.
Changed functionality to delete successful intermediate containers at
the end of the whole build process.
Signed-off-by: umohnani8<EMAIL_ADDRESS>

@rh-atomic-bot r+


Added YARD docs in new mruby.h

Added documentation for mrb_funcall(), mrb_funcall_argv(), mrb_funcall_with_block(), and mrb_intern_cstr().

@strcmp I added one space indentation does it look right?

Hi. Sorry. I wasn't clear but I'm on phone and can't explain properly now. It's worse than before. Please revert that commit.

@Mav7 Line 267 is like this:
# Ruby style
class Foo
 def Foo.bar
 end
end

There is one space used to indent but it should be two spaces. That's what I was trying to say. I don't think the new commit you added is good because it adds newlines and whitespace what seems in almost random way but it is my preference to not insert random newlines within a methods body to make code "look nicer".

@strcmp I got rid of the new lines and white spaces from before. I'm sorry I thought that's what you meant at first. I think what added to the confusion is that for some weird reason when I pulled changes from this master branch into my own and tried generating docs; the formatting would apparently be off. So I had to make sure the generated YARD docs looked good. Let me know if it looks good.

looks good, also fixes the original indentation issue. :+1:

@strcmp Hey, would you like to help me document mruby's C API. I really appreciate your help on here and we could probably cover more ground together!

hey again, yeah I would be happy to help. please drop me a line at strcmp [at] hmamail.com so we can discuss what you plan to document and how i could help. cheers.

@strcmp It's hmamail.com? I just want to make sure I got that right.

@Mav7 yeah that's right but i didn't give you right username. sorry. it is email service with very little hassle to sign up but i don't always use it, so i forgot. please email me at<EMAIL_ADDRESS>- look forward to it.

@strcmp Ok just sent you an email. I can't wait to hear from you!

@Mav7 thanks :) ill check the email soon.
just a tip, i advise you to edit your comment and remove that email address.
robots can look for them, and send you nothing good(spam).

@strcmp Wow thanks for letting me know.

hi @Mav7 - sorry for the delay. I have replied by email.

@strcmp Yeah it's fine. I just replied to the email.


Fixed typo in CONTRIBUTING.md

Signed-off-by: Kunal Kushwaha<EMAIL_ADDRESS>Getting started with contributing to the project and found a typo while going through the docs.
Fixed typo in CONTRIBUTING.md in line 95, memeber -> member
NONE

/lgtm
/ok-to-test


Managed Service Orchestrator Release 23.12 Security Acceptance Criteria

Release Security 23.12
Source in Catena-X Confluence and Expert Contacts here(Source only accessible for Catena-X Consortia members in current transition phase).

[ ] Threat Modelling Analysis results
Analysis completed (operations excluded):

List of risks generated or updated, rated & actions defined
Risks accepted or mitigation actions implemented and tested
no high threats acceptable

Artifact Repository:

risk register (decentral on Catena-X confluence)

Prime Contacts:

Security Team: SEC0

[ ] Static Application Security Testing (SAST)

code must be scanned weekly with Veracode tool
medium risks require mitigation statement
high and above not accepted

Best Practise:

Confirm relevant repository as early as possible to SEC team to enable regular, automated scans. Evidence required for Gate approval.

Artifact Repository:

Veracode UI
(+ GitHub Action)

Prime Contacts:

Security Team: SEC1

[ ] Dynamic Application Security Testing (DAST)
incl API testing (if applicable)

all findings assessed
high & very high findings mitigated
evidence by re-scan

Best Practise:

Confirm relevant repository as early as possible to SEC team to enable regular, automated scans. Evidence required for Gate approval.

Artifact Repository:

INVICTI tool

Prime Contacts:

Security Team: SEC3 SEC4

[ ] Secret scanning
Scan executed centrally by SEC team and ZERO valid findings
Artifact Repository:

Veracode or alternative tool
GitHub Secret Scanning
GitGuardian

Best Practise:

Confirm relevant repository as early as possible to SEC team to enable regular, automated scans. Evidence required for Gate approval.

Prime Contact:

Security Team: SEC1

[ ] Software Composition Analysis (SCA)
Dependencies must be scanned with Veracode tool with regards to vulnerability

high and above not accepted
FOSS whitelist policy has to be passed

Best Practise:

Confirm relevant repository as early as possible to SEC team to enable regular, automated scans. Evidence required for Gate approval.

Artifact Repository:

Veracode UI
(& GitHub Action)

Prime Contacts:

Security Team: SEC1

[ ] Container Scan conducted
All containers in GitHub Packages must be scanned

High / Critical findings not accepted

Best Practise:

Confirm relevant repository as early as possible to SEC team to enable regular, automated scans. Evidence required for Gate approval.

Artifact Repository:

Trivy
via nightly GitHub Action

Prime Contacts:

Security Team: SEC2

[ ] Infrastructure as Code
IaC code must be scanned.

Error findings not accepted

Best Practise:

Confirm relevant repository as early as possible to SEC team to enable regular, automated scans. Evidence required for Gate approval.

Artifact Repository:

KICS or alternative tool
via nightly GitHub Action

Prime Contacts:

Security Team: SEC2

@dvasunin  please add the reports of the security tools here

Threat modelling Document:
https://confluence.catena-x.net/display/cxsecurity/Security+Assessment+-+Auto+Setup+API
Dynamic Application Security Testing:
Latest Invicti report : https://www.netsparkercloud.com/scans/report/025257ccf1234f26bee8b0c101f28769/
scan-report-orchestrator.int.cx.dih-cloud.com-detailedscan-21_11_2023 02_59 PM.pdf
Container Scan conducted:
Latest Trivy Scan Report: https://github.com/eclipse-tractusx/managed-service-orchestrator/actions/workflows/trivy.yml
Infrastructure as Code:
Latest KICS report: https://github.com/eclipse-tractusx/managed-service-orchestrator/actions/workflows/kics.yml

Hi @sharathshivprasad,
Is this possible for you to verify this finding?

Although Invicti did not mark it as "high", I am concerned about this finding..
How effortful would be for you to address it?
Please let me know.
Regards,
Piotr

Hi @sharathshivprasad,
Is this possible for you to verify this finding?

Although Invicti did not mark it as "high", I am a bit concerned about it. How effortful would be for you to address it? Please let me know.
Regards, Piotr

@dvasunin @adkumar1  Please have a look.

Hi @sharathshivprasad,
Is this possible for you to verify this finding?

As far as I know, and this is marked in the controller code, '/internal/*' endpoints are dedicated for internal use only and are not exposed outside of cluster. This particular endpoint is supposed to return application details like JDBC string, but it shall be safe as this data does not leave (or shall not leave) the cluster

Hi @sharathshivprasad,
Is this possible for you to verify this finding?

As far as I know, and this is marked in the controller code, '/internal/*' endpoints are dedicated for internal use only and are not exposed outside of cluster. This particular endpoint is supposed to return application details like JDBC string, but it shall be safe as this data does not leave (or shall not leave) the cluster

Hi @dvasunin,
Thank you for your input and explanation.
My main intention was to bring the finding to your awareness so that you can make sure it is not a direct threat to your application.
Other than that, please make sure to review the potential XSS findings before the next QG.

DAST Passed
Thank you,
Piotr

Hi, @sharathshivprasad Can you please share a link for SCA?
Thank you in advance

Hi, @sharathshivprasad Can you please share a link for SCA?
Thank you in advance

Hello @klaudiaZF ,
Please find the latest veracode scan report.
Link: https://analysiscenter.veracode.com/auth/index.jsp#ViewReportsResultSummary:47240:1550110:30943369
Latest Report:
DetailedReport_DFT_AutoSetup_26_Nov_2023.pdf

Hi All,
SCA Passed

@sharathshivprasad  Thank you


bugzilla.utils: avoid IndexError while trying to hide API key from ex…

…ception
If the URL had no API key parameter, we would crash while trying to
handle e.g. an Unauthorized exception.

Coverage decreased (-0.05%) to 48.64% when pulling 132f8bb137a8e42e89125032b933e721a85c0c73 on jcristau:hide-api_key-error into e033c6975a380dd3d9b49ffc4c05ad50912f7cb9 on mozilla:master.


wrong  when pip install corre_project

I git clone this project from github. entering the project path when I run pip install ./  it get wrongs shown as below
(base) wanglei@omnisky:/project/WeightedCorrelationExtension$ pip install ./ Processing /project/WeightedCorrelationExtension Building wheels for collected packages: weighted-corr   Building wheel for weighted-corr (setup.py) ... error  ERROR: Command errored out with exit status 1:    command: /home/wanglei/anaconda3/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-m3sz9uke/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-m3sz9uke/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-005d2105        cwd: /tmp/pip-req-build-m3sz9uke/   Complete output (313 lines):   running bdist_wheel   /home/wanglei/anaconda3/lib/python3.8/site-packages/torch/utils/cpp_extension.py:352: UserWarning: Attempted to use ninja as the BuildExtension backend but we could not find ninja.. Falling back to using the slow distutils backend.     warnings.warn(msg.format('we could not find ninja.'))   running build   running build_ext   building 'weighted_corr_cuda' extension   creating build   creating build/temp.linux-x86_64-3.8   gcc -pthread -B /home/wanglei/anaconda3/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/home/wanglei/anaconda3/lib/python3.8/site-packages/torch/include -I/home/wanglei/anaconda3/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -I/home/wanglei/anaconda3/lib/python3.8/site-packages/torch/include/TH -I/home/wanglei/anaconda3/lib/python3.8/site-packages/torch/include/THC -I/usr/local/cuda/include -I/home/wanglei/anaconda3/include/python3.8 -c weighted_corr.cpp -o build/temp.linux-x86_64-3.8/weighted_corr.o -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="_gcc" -DPYBIND11_STDLIB="_libstdcpp" -DPYBIND11_BUILD_ABI="_cxxabi1011" -DTORCH_EXTENSION_NAME=weighted_corr_cuda -D_GLIBCXX_USE_CXX11_ABI=0 -std=c++14   cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
The Driver Version: 440.64.00    CUDA Version: 10.2 torch version: 1.7.1
Thank you advance.

Hi,
Thanks for noticing.
Could you please downgrade your pytorch to any version between 1.3.0 and 1.6.0 and see if that works? I tried upgrading my pytorch to 1.7.1 and the installation failed as well...
Here's my environment configuration for successful installation:
CUDA 10.1
torch 1.5.1 (also OK for 1.4.0, 1.6.0)
gcc 7.3.1

Thank.When I downgrade my pytorch to 1.5.0, it works.I am sorry that I hadn't noticed the version problem.

Good to hear that. The readme file has been updated.

@runtoforever Hi, I have also fixed the compilation error when using torch 1.7.1, and it should be working normally on that version.
See this issue.


Can't build

Not sure if this is xcode 8 related.
But can't seem to get this to build.
I'm importing library into my class:
import Doppelganger_Swift
However I can't install when referencing NIArrayDiffUtility.

I think this is due to NIArrayDiffUtility needing to be defined as public.
public class NIArrayDiffUtility

This still seems to be an issue with 0.2.0


WIP: Save and load old workout data

An seems-to-be-working sketch of #101
Will try to add some gifs
Maybe a showcase on a call? 🙃
TODO:

[ ] Show modal on "startup"
[x] Use arrow counterclockwise icon
[ ] Check out load -> start without power
[x] optimize with slices

Show modal if last timestamp more than 12 hours away
change from data-laps-lapIndex-elementIndex to something like recovery-data-timestamp with {lap:lapIndex} in object

Closing this as we're going for a solution with IndexedDB ref #101


Remove LJC codesign certs from all machines

We no longer need these codesign certs. The safest option is to fully remove them from the machines to prevent us signing an Adoptium build with the wrong cert
Checklist

[ ] commit message has one of the standard prefixes
[ ] FAQ.md updated if appropriate
[ ] other documentation is changed or added (if applicable)
[ ] playbook changes run through VPC or QPC (if you have access)
[ ] for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Vagrant run is erroring on:
/opt/vagrant/embedded/gems/2.2.16/gems/vagrant-2.2.16/lib/vagrant/patches/net-ssh.rb:10:in rsa_compat_build_request': undefined method []' for nil:NilClass (NoMethodError)

The vagrant failure is on the Solaris check. I wouldnt think it would be associated with this pr. Either way, ive kicked off another job

The vagrant failure is on the Solaris check. I wouldnt think it would be associated with this pr. Either way, ive kicked off another job

@Haroon-Khel What was the other job? Was it a re-run of the Solaris check or something else?

@Haroon-Khel What was the other job? Was it a re-run of the Solaris check or something else?

A re run of the Solaris check. It still fails with the same error. As discussed in Slack, we agreed that the failure does not concern this pr. Is it safe to merge then?

I'd say this is safe to merge. @sxa pleas approve and merge


Dummy PR to Test New Checks

Testing out our newly separated workflows for reporting results on PRs (#265)

Looks like everything is working! The E2E Report action runs (seen in Actions, not on Checks on the PR) and publishes a URL to the results. This does appear as a Check in the PR, as Playwright Tests (see above, or in Checks tab).


"Create our first networt" incomplete code snippet

In this tutorial there's an incomplete code snippet at the end of the tutorial, there's a lost "block" line, which I don't know what to do, should I just delete and ignore it?
https://github.com/awslabs/djl/blob/master/jupyter/tutorial/01_create_your_first_network.ipynb
This is also weird in the website:
https://docs.djl.ai/jupyter/tutorial/01_create_your_first_network.html
Thanks!

That line is only required in the notebook to show the output. You can remove it.

That line is only required in the notebook to show the output. You can remove it.

Closing the issue. Please reopen ticket if you have encounter any issue.

Closing the issue. Please reopen ticket if you have encounter any issue.

That line is only required in the notebook to show the output. You can remove it.

The line "block" is jupyter notebook specific shortcut for: System.out.println(block);

That line is only required in the notebook to show the output. You can remove it.

The line "block" is jupyter notebook specific shortcut for: System.out.println(block);

thanks @frankfliu and @keerthanvasist

thanks @frankfliu and @keerthanvasist


User Application

I think it would be better to discuss this with your reviewer, but haven't we agreed on a common folder/directory naming style (and it's not PascalCase)?

It seems there is a typo in some places in the project: loyality instead of loyalty

should we place .idea/* in .gitignore?


Encrypted attributes

German laws determine that sensitive data must not be stored in plain text, but encrypted. The main purpose of it is that in case the database access is compromised, then the data would be unreadable.
As an example, credit card numbers, emails, first and last names, social security numbers, etc.
For this, we extended the Eloquent/Model.php class in order to address encryptable attributes. So whenever an attribute is "set" we encrypt it and whenever is "get" we decrypt it.
Would be nice to have this in the base-line of Laravel.
In case there's a better alternative on how to implement this, I'm happy to code it.
Thanks.

Think this was rejected already just a few days ago

I read the thread. Two things to point out:

The code is slightly different. But both persue the same objective.
Seems it's becoming a recurrent issue/requirement.

I don't mind having it on my own Laravel fork, but seems to be something that many web apps require around there. Just googling it gives you an idea.
I suggested the pull request because as I said, it's becoming a recurrent issue and I think that's why date mutation, guarded attributes, native type casting and fillable attributes were also added at the time.
Cheers.

:-1:


Position Command Interface Sensitivity & Control Exceptions

We have tried to use the position command interface, but found strange motion generation exceptions. We posted to #52, and learned about the libfranka bug which requires reading from initial_joint_position. After applying that fix, we still have been unable to use the position command interface, and I believe we now have a repeatable demo which shows this issue. Commanding any change in (initial) position with a magnitude of 1e-5 radians or larger results in motion generation and control exceptions. This sensitivity is preventing us from using the position interface at all, unfortunately. This change in position, 0.00001 rad, seems to be well within the acceleration limits specified in the libfranka documentation.
I have forked humble, and changed the relevant line in joint_position_example_controller.cpp to highlight this issue. If you run that example, with my modification applied, you should immediately see a Franka control exception without any arm motion.
https://github.com/jcarpinelli-bdai/franka_ros2/commit/8ed4d99e90f3cec43eaf3a11d7262406dd987516

Hi  @jcarpinelli-bdai , today I was migrating my joint position controller from ROS1 to ROS2 and I have literally the same problem as you, thanks to you and the issue #52 I learned about the libfranka bug, and I still cant find a way to make the controller work, if i solve it i will make you know.


Publish arm64 without cuda nuget package.

Please publish arm64 without cuda nuget package.

@vnetb Your library need libtesseract.so.4


Changing gem install command to use single quotes to appease Rubocop

If you're copying + pasting this into a Gemfile, Rubocop will complain about the double quotes.

Thanks for the PR! I'm going to close this, since the official style on this project is to use double quotes. I'm not exactly sure where we are getting that configuration, so it might be worth adding an explicit .rubocop.yml, but you can see in https://github.com/thoughtbot/factory_bot/pull/1163#discussion_r207628103 that hound will bark at us if we use double quotes. I think it makes sense for our documentation to match the the code style for the project.

@composerinteralia similar topic: Is there a way to run rubocop locally? I didnt see a rubocop config file? It is a little tiresome to wait for the hound comments after pushing and then trying to blindly fix the issues again ...


Openstack support lacks region support

When using beaker with a multi-region Openstack, we need to pass this through to Fog, else it errors with:
Multiple regions available choose one of these 'emea1,amers1,amers2,amers3'

In PR, https://github.com/puppetlabs/beaker/pull/681

Follow up here:
https://tickets.puppetlabs.com/browse/BKR-27


[SR-15825] Miscompilation leads to reference of unavailable type at runtime

Previous ID
SR-15825

Radar
rdar://problem/88513988

Original Reporter
@NachoSoto

Type
Bug

Attachment: Download

Environment
Xcode 13.2.1 (13C100)
swift-driver version: 1.26.21 Apple Swift version 5.5.2

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Bug

Assignee
None

Priority
Medium

md5: 0364d04118c34e43f2a2f813254337a7

Issue Description:
This code:
import StoreKit

@available(iOS 15.0, tvOS 15.0, macOS 12.0, watchOS 7.0, *)
class Mock {
    var mockTransaction: StoreKit.Transaction?
}

Compiles, but when run in a unit test host app on iOS 14.x it crashes at runtime:
dyld: lazy symbol binding failed: Symbol not found: _$s8StoreKit11TransactionVMa
  Referenced from: /Users/nachosoto/Library/Developer/CoreSimulator/Devices/47674D70-24C0-455B-BAB3-D0A5C218C75A/data/Containers/Bundle/Application/DD93C493-D46E-4CB5-BA2B-D83B4B7C77BB/StoreKitTest.app/PlugIns/StoreKitTestTests.xctest/StoreKitTestTests
  Expected in: /System/Library/Frameworks/StoreKit.framework/StoreKit

`StoreKit.Transaction` isn't available until iOS 15.0, and neither is `Mock`.
Repro steps:

Download attached project

Select `StoreKitTest` scheme

Test (on iOS 14.x)

Is this still not fixed?

Looks like this should have been fixed with https://github.com/apple/swift/pull/40741.


unable to fetch testcases

same error with me too.

same error

Hey there, the new script for fetching test cases is in the works and should be ready in 3-4 days after testing. Thanks for hanging in there while we sort this out!
PEACE!


render to existing window handle

is there any way to render to an existing window handle? i would like to use sokol in an audio plugin library (and i know of another considering the same), and the normal way to do things is rendering to a window created by the software hosting the plugin. it would be very nice to have an easy way to get sokol going on an existing window handle. if there isn't a nice abstracted way to do this, do you have any suggestions on where in the (i presume sokol-gfx) code to look for each platform so i can set it up myself?

For D3D11/DXGI you can look at this minimal window system glue setup:
https://github.com/floooh/sokol-samples/blob/master/d3d11/d3d11entry.c
Basically start after the CreateWindowExW() call.
Here's the similar code for Metal+MTKView:
https://github.com/floooh/sokol-samples/blob/master/metal/osxentry.m
I don't have a similar simple example for GL, since those use GLFW:
https://github.com/floooh/sokol-samples/blob/master/glfw/glfw_glue.c
That part is otherwise taken care of the sokol_app.h, and may be a bit more robust:

for D3D11/DXGI: https://github.com/floooh/sokol/blob/c2d01bc25c58be460787d5f027eed73d1c036e6f/sokol_app.h#L6445-L6541
for Metal/MTKView: https://github.com/floooh/sokol/blob/c2d01bc25c58be460787d5f027eed73d1c036e6f/sokol_app.h#L3860-L3989
the GL setup for Windows and Linux is a lot more gnarly, but I just hope that's not relevant for you ;)

mac and windows is higher priority than linux so if i can't get linux support soon that wouldn't be the worst thing. thank you very much for this


General frontend refactor

Overview
Since courses backend was rewritten, we figured it was time to pull in the most recent version of courses frontend. However, since the backend changed quite a bit in the portlet to soffit conversion, some reworking of the frontend code was necessary to get everything working properly.
This is a really large pull request (my bad), and I've been looking at this code for a long time, so I'm sure that I've missed stuff. I'd appreciate if you guys could really dig into this PR, if you have the time.
You can either run the project locally by changing the is_demo variable in the index.html to true or by running courses backend and frontend simultaneously. I would suggest the latter, as it would ensure all functionality (printing especially) works as expected. I've tested on chrome and firefox. If anyone can test on edge or safari, it would be greatly appreciated.
A general list of what's changed:

Anything advising related has been ripped out
Reducers/actions have been reworked to fit new endpoint structure
The react calendar has been replaced with a third party option, Full Calendar (sorry Aaron!)
The local backend has been removed and replaced with demo JSON data located in src/api
Translations was removed as it was outdated and we are planning to look into a new way of handling that
prettier was added to the project and run
Unused/unnecessary code was removed and the project was cleaned up generally

Merger

[ ] @amgoodfellow

Reviewers

[x] @richast
[x] @sterlingwalker
[ ] @nickwoodle

NOTE: The amount of additions/deletions looks HUGE, I mainly blame this on prettier. Also, you'll want to run this branch with courses backend branch CS-9 (until that is merged in). Those two work together

@sterlingwalker you have a lot of good suggestions, and they've got me looking at other areas in the code that I can update as well.
I think that I'm going to opt to only add in bug fixes in this merge request since its already huge. But I'm going to branch off of this branch and continue working on code enhancements. How's that sound?

@sterlingwalker you have a lot of good suggestions, and they've got me looking at other areas in the code that I can update as well.
I think that I'm going to opt to only add in bug fixes in this merge request since its already huge. But I'm going to branch off of this branch and continue working on code enhancements. How's that sound?

That works for me! I'll check my box.

LGTM :100:
I really like these changes, everything is much prettier now. Worked with the backend find and I didn't find any bugs.

LGTM! I am good with it!


nsp failing its own audit :)

Name    Installed  Patched  Vulnerable Dependency
semver    3.0.1    >=4.3.2<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>semver    2.3.2    >=4.3.2<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>

Filed the upstream silent-npm-registry-client issue as https://github.com/juliangruber/silent-npm-registry-client/issues/4.

Hi there, the issue at https://github.com/juliangruber/silent-npm-registry-client/issues/4 has been merged to https://github.com/juliangruber/silent-npm-registry-client/commit/16ad82381d219a90e6f2b1286771c065f21adc1a
Could you please rebuild NSP with the latest?

:+1:


Tests for curriculum helpers

The curriculum helper scripts could use some tests.  A recent breaking change to https://github.com/williamkapke/bson-objectid stops the helpers working, but https://github.com/freeCodeCamp/freeCodeCamp/pull/41677 is green.

Did that breaking change land? If so why & how?

Nope, because I saw that it was major bump and went and investigated.  I had to find this PR: https://github.com/williamkapke/bson-objectid/pull/37 before I realised that it was going to affect us, though, so I could easily have missed it.

I'm interested in taking this up and wanted to know what kind of tests can be made.

Awesome :+1:
Since we're not actively developing right now (@RandellDawson did a great job and we don't currently plan to extend it), the main thing we want is to make sure it doesn't break if we update dependencies.
It's worth considering tests like

do the scripts create-empty-steps, create-next-step and so on behave as expected (i.e. acceptance tests)
do the individual functions do what we think they do (i.e. unit tests)

I'd probably go the unit test route and test createStepFile and reorderSteps, since they do the majority of the work.

Gotcha 👍


Memory leak in phanta array

Hi!
So i've been having these memory leak for a long time and i finally managed to locate where it was by digging into the phantom.js file. When i am using phantom i have multiple instances of them running in parallel but it seems like when i call page.close()/phantomJS.exit() the instance of the phantom in the phanta array does not get cleared out. This makes the array grow bigger end bigger until my the main process exits. Im not sure how it is suppose to work or if i am doing something wrong but i managed to find out what was causing the issue.
...return ps.on('exit', function(code, signal) {
          var p;
          httpServer.close();
          if (phantom) {
            phanta = (function createPhanta() {
              var _j, _len1, _results....

If i understand it correctly the exit event is emitted when i call Phantom.exit(). However,  the phantom variable is never defined here. I don't know when/how it is suppose to be set but its always null for me and if evaluates to false, which means that it never gets removed from the phanta array.
Now because phantom, or the instances in phanta is shared between the code using this module the gc will never clear these instances until the process exits fully. I managed to create a temporary sollution where i basically add the phantom instance to the ps object :
sock = shoe(function shoe(stream) {
        var d;
        d = dnode({}, options.dnodeOpts);
        d.on('remote', function remote(phantom) {
          wrap(phantom);
          phantom.process = ps;
          ps.currentPhantom = phantom; //here
          phanta.push(phantom);
          return typeof cb === "function" ? cb(phantom) : void 0;
        });

And then removing it in ps.exit, i know this is a terrible sollution but until i can understand what i am doing wrong or this gets fixed. I Suppose its a working work around.

I've run into this same issue. Out of curiosity, @Oted are you using Phantom 2.0? I don't seem to be experiencing the issue on 1.9.8 on my OS X machine, but do in production on Linux with phantom 2.0...


JSCompiler broken on older versions of node.

Compiler uses Buffer.allocUnsafe which does exist on Node v4.X (default on Ubuntu 16.04 LTS)

Fixed.


Add GDS::SSO::PermissionDeniedError to excluded exceptions list

Related to: https://github.com/alphagov/gds-sso/pull/300

We do not need to capture these errors generated from gds-sso. They do not indicate that something went wrong with the application; rather, they indicate that a user does not have permissions to access a resource.

trello card: https://trello.com/c/qb1qpwnr/1369-additional-functionality-to-gds-sso-gem-for-intercepting-401s-and-providing-a-route-constraint

Thanks for the review @kevindew , I updated the things you suggested, I followed the pattern for the changelog message and version (I noticed it does not have unreleased section), should I update the gem's version as part of this PR?

We normally just add an unreleased section each time a new one is added.
It's no biggie though to update the gem version as part of this PR since this is a relatively slow moving gem.


operator List supports operators like "in"

https://github.com/apache/incubator-apisix/issues/841,
Many times we need to specify a certain batch of users as grayscale users
vars = {
    {"arg_name", "in", ["lua","java","c"]}
}

Yes, that is a good way, PR welcome.


brew cask list - not working.

Error: wrong number of arguments (1 for 0) while loading '/usr/local/Library/Taps/caskroom/homebrew-cask/Casks/all-the-gifs.rb'
Please report this bug:
https://github.com/caskroom/homebrew-cask/issues
:5:in `name'
:5:in `'
:in `'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/source/path_base.rb:55:in `eval'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/source/path_base.rb:55:in `rescue in load'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/source/path_base.rb:52:in `load'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask.rb:124:in `load'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/scopes.rb:55:in `block in installed'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/scopes.rb:49:in `map'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/scopes.rb:49:in `installed'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/cli/list.rb:52:in `list_installed'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/cli/list.rb:10:in `run'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/cli.rb:81:in `run_command'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/cli.rb:121:in `process'
/usr/local/bin/brew-cask.rb:42:in `'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Library/brew.rb:58:in `require?'
/usr/local/Library/brew.rb:141:in `'

sorry cask was outdated... Thanks guys.


Consider including things such as lsblk and usbutils, at least during the early stages of development of helloSystem

gpart show to the left, lsblk to the right:

lsusb | sort

Not wishing to bloat the ISOs, but including utilities such as these can ease technical feedback.
https://www.freshports.org/sysutils/lsblk/
https://www.freshports.org/sysutils/usbutils/

I am in the contact with the author of http://bsd-hardware.info/ on the subject of including a Hardware Probe tool. Would that do the job? First prototype should be ready soon.

Yes and no; I might perform (not necessarily upload) a probe infrequently.
lsblk might be run frequently and its output is, in some ways, more user-friendly than e.g.
less /root/HW_PROBE/LATEST/hw.info/logs/diskinfo

Thank you 👍
Related
FreeBSD bug 252282 – sysutils/hw-probe depends upon sysutils/usbutils for lsusb(8)
Background
I learnt of lsblk on Linux a few months ago through a 2013 article, Guide to Using DDRescue to Recover Data - Technibble.
I wasn't aware of the port to FreeBSD until a couple of weeks ago, someone's comment in Reddit. Now I see this 2019 post:

List Block Devices on FreeBSD lsblk(8) Style | 𝚟𝚎𝚛𝚖𝚊𝚍𝚎𝚗

– thanks @vermaden

lsusb, lspci are indeed what I as a switcher from Linux was intuitively looking for. They seem to be relatively small, so let's add them.
We will have to go through an extensive slim-down exercise in any case.

– thanks @vermaden

Welcome :)

Sometimes I think one should develop helloSystem by just reading @vermaden's blog and implementing (almost) all of it ;-)

Sometimes I think one should develop helloSystem by just reading @vermaden's blog and implementing (almost) all of it ;-)

It could be useful for more 'power users' but I doubt that it will be useful/usable for non-tech people.

This is what I meant with "almost" ;-)


Upgrade rxjs to ^7.4.0

re: #2073, #2042
What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Since the upgrade to angular 13, installing the package warns that one needs to install<EMAIL_ADDRESS>when one already has<EMAIL_ADDRESS>which is what angular 13+ now runs on.
What is the new behavior?
Now that we've upgraded the package to support<EMAIL_ADDRESS>Angular 13+ users shouldn't see false positive warnings when installing the package.
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

+1

please merge it asap

+1

+1

+1

Please merge

+1. Needed for using ngx-datatables with latest versions of Angular.

Need this please. Also seems the peer dep is still ng11?

Need this please. Also seems the peer dep is still ng11?

you can use --force to install it, but test it before going productive. For me it doesn't break.

Please merge

+1

+1

Hi Team,
Please merge this PR ASAP. Lot of people are waiting for this update it seems.

Hi Team,
Please merge this PR ASAP. Lot of people are waiting for this update it seems.

At this point, I honestly believe there's no "Team" behind this anymore. This project seems abandoned by maintainers.

<EMAIL_ADDRESS>(Forked)
stackblitz

Can this be merged?

Please find some time to merge 👍


[Version 4] Fix dropdown label

InputDecorator of FormBuilderDropdown misses the isEmpty-Attribute. Without this attribute, the floating label is always shown, even if there is no value set.

Thank you for your contribution @thirteenthstep.


Updating test_affine.py.

Just updated the tests for the real data. Still left it commented out for Travis CI.

awesome! merged! we will connect all pieces tomorrow night!


Path /var/lib/docker is mounted on / but it is not a shared or slave mount.

Rancher versions:
rancher/server or rancher/rancher: rancher-server 2.0.2
rancher/agent or rancher/rancher-agent: ancher/rancher-agent:v2.0.2
Docker version: (docker version,docker info preferred)
docker info on host running rancher-agent:
Containers: 8
 Running: 6
 Paused: 0
 Stopped: 2
Images: 4
Server Version: 17.03.2-ce
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 53
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
Swarm: error
 NodeID:
 Error: Swarm certificates have expired. To replace them, leave the swarm and join again.
 Is Manager: false
 Node Address: <IP_ADDRESS>
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 4ab9917febca54791c5f071a9d1f404867857fcc
runc version: 54296cf40ad8143b62dbcaa1d90e520a2136ddfe
init version: 949e6fa
Security Options:
 apparmor
Kernel Version: 4.4.0-119-generic
Operating System: Ubuntu 14.04.5 LTS
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 7.696 GiB
Name: metis-B85M-HD3
ID: 5ARK:3RW6:HO5D:GJEA:4YW3:HBSC:SYQG:OEQA:GHSJ:UROH:KRKF:DCYS
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

WARNING: No swap limit support

Operating system and kernel: (cat /etc/os-release, uname -r preferred)
NAME="Ubuntu"
VERSION="14.04.5 LTS, Trusty Tahr"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 14.04.5 LTS"
VERSION_ID="14.04"

Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Bare-metal
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single-node rancher
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Kubernetes
Issue Description
When trying to add new node to Kubernetes cluster rancher-agent fails and folowwing message is shown:
[workerPlane] Failed to bring up Worker Plane: Failed to start [kubelet] container on host [<IP_ADDRESS>]: Error response from daemon: linux mounts: Path /var/lib/docker is mounted on / but it is not a shared or slave mount.

I tried running this cleanup scrpt https://gist.github.com/superseb/2cf186726807a012af59a027cb41270d, but no luck. One little observation: adding node on Ubuntu 16.04. running exactly the same docker version was successful. Here is docker info:
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.3 LTS
Release:	16.04
Codename:	xenial
root@solovyevt-pc:~# docker info
Containers: 34
 Running: 23
 Paused: 0
 Stopped: 11
Images: 207
Server Version: 17.03.2-ce
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 4ab9917febca54791c5f071a9d1f404867857fcc
runc version: 54296cf40ad8143b62dbcaa1d90e520a2136ddfe
init version: 949e6fa
Security Options:
 apparmor
 seccomp
  Profile: default
Kernel Version: 4.13.0-45-generic
Operating System: Ubuntu 16.04.3 LTS
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 15.62 GiB
Name: solovyevt-pc
ID: 2CMP:3N5W:WZNG:DE3M:SBBR:SJSB:KWHJ:XXJS:T7MT:USGT:ARZF:EPVQ
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

WARNING: No swap limit support

Pretty sure this is due to Ubuntu 14.04, which is not a supported OS for Rancher:
Requirements
Operating System
Ubuntu 16.04 (64-bit)
Red Hat Enterprise Linux 7.5 (64-bit)
RancherOS 1.3.0 (64-bit)

I have to run some tests to see where the problem is exactly, quickest fix for now is to use a supported OS.

Roger that, running it on 16.04 solved the problem, also reproduced it on fresh 14.10.

Please use a supported OS


Feature request: accept image for graph

Thanks for the amazing tool! Would it be possible to make it accept an image or URL as input and then convert/draw it in the graph?

Hey! There is already one library which does exactly what you are asking for, however I am not able to recall it's name at the moment. I will update here once I remember it.
Also, I am not sure Rockstar should do it. Rockstar fills all the boxes (i.e. each commit for everyday), so that you get longest streak :stuck_out_tongue: But this is interesting anyways and I will look into it. Thanks for the feedback!

@avinassh This is pretty close to what @lwh wanted.

This one too.

Nice
My very own Github Vandalism webservice
And me speaking about it
:smile:

Closing this issue. I find this feature not really relevant


Add a Dataflow smoke test.

This tests all the "primitive" tests in a single Dataflow pipeline (each in its own component).

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @jrmccluskey

apache_beam.transforms.userstate_test.StatefulDoFnOnDirectRunnerTest.test_dynamic_timer_clear_then_set_timer failures look irrelevent.

Run Python PreCommit

Looks like GCP authentication isn't working properly on the Github Action

Yeah, I tried to copy what Python was doing, but not sure how to fix this.


username password error

Hi,
I get a username and password error on some phones.Could there be a problem with the account ?
because I cannot login with one account on the same phone and login with another account

@charlieAndroidDev

Error : Attempt to invoke virtual method 'boolean android.os.BaseBundle.getBoolean(java.lang.String)' on a null object reference

please contact me<EMAIL_ADDRESS>I can donate if you help, please

user id appears 0


"Add Rule" button opens "Add Route" dialog if no rules are present

Describe the problem
If there is a total of 0 rules existing, the button "Add Rule" will open the "Add Route" dialog instead of the "Add Rule" dialog. Therefore you can't create any more rules.
To Reproduce
Steps to reproduce the behavior:

Go to "Access Control" in the web interface
Delete all rules
Click on "New Rule"
See the "New Route" dialog appear instead of the "New Rule" dialog

Expected behavior
It is expected and necessary that the "New Rule" button brings up the "New Rule" dialog because otherwise one is stuck with no rules and therefore an unuseable Netbird instance.
Are you using NetBird Cloud?
Self-Hosted
NetBird version
I assume 0.25.6 because I installed today

Fix: https://github.com/netbirdio/dashboard/pull/326

This should be fixed. Please feel free to reopen it if you are still experiencing the same.


Migrate to YoWASP WebAssembly binaries

Closes #38.

When running in Node.js mode (i.e. without "--extensionDevelopmentKind=web"), starting either Yosys or Nextpnr results in the following error:
Error: Automatic publicPath is not supported in this browser
    at /home/mike/Documents/work/vscode-edacation/dist/workers/yosys.js:11089:34
    at /home/mike/Documents/work/vscode-edacation/dist/workers/yosys.js:11092:13
    at Object.<anonymous> (/home/mike/Documents/work/vscode-edacation/dist/workers/yosys.js:11159:12)
    at Module._compile (node:internal/modules/cjs/loader:1265:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1324:10)
    at Module.load (node:internal/modules/cjs/loader:1124:32)
    at Module._load (node:internal/modules/cjs/loader:965:12)
    at f._load (node:electron/js2c/asar_bundle:2:13377)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:96:12)
    at MessagePort.<anonymous> (node:internal/main/worker_thread:161:24)

Also, I'm wondering if there is any reason to keep the current workers instead of just executing the tools in the runner directly? Removing it would simplify the setup quite a bit as well as allow us to get rid of the mess that is UniversalWorker.

Also, I'm wondering if there is any reason to keep the current workers instead of just executing the tools in the runner directly? Removing it would simplify the setup quite a bit as well as allow us to get rid of the mess that is UniversalWorker.

To be honest, I just looked for the quickest way to integrate/test this. If you have a better solution then please create a PR on top of this one 😄, because I don't have too much time to delve into the project anymore.

I have updated YoWASP to the latest version with the new import statements in #46. Webpack has a config option to do eager imports by default, which I enabled for the worker bundles to avoid the otherwise required find-and-replace.
The bad news is that there is now a new error for Node.js:
ReferenceError: self is not defined
    at /home/mike/Documents/work/vscode-edacation/dist/workers/yosys.js:11037:36
    at /home/mike/Documents/work/vscode-edacation/dist/workers/yosys.js:11051:13
    at Object.<anonymous> (/home/mike/Documents/work/vscode-edacation/dist/workers/yosys.js:11077:12)
    at Module._compile (node:internal/modules/cjs/loader:1265:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1324:10)
    at Module.load (node:internal/modules/cjs/loader:1124:32)
    at Module._load (node:internal/modules/cjs/loader:965:12)
    at f._load (node:electron/js2c/asar_bundle:2:13377)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:96:12)
    at MessagePort.<anonymous> (node:internal/main/worker_thread:161:24)

I have honestly no idea where this one is coming from; I don't think it's the new config option, as the same error is raised without it. I'm giving up on this one for today.
By the way, I've tried my idea of removing the workers altogether; wouldn't recommend :)

I have honestly no idea where this one is coming from; I don't think it's the new config option, as the same error is raised without it. I'm giving up on this one for today.

I will take a look at it.

The issue is that self.location does not exist in Node.js worker threads. In general, globalThis should be used, but the output.globalObject flag didn't seem to change anything. However, even when using globalThis, Node.js does not include a location property. I brought back the replace patch plugin to implement a hot fix for this issue. It now runs, but I noticed that log output is only printed after the Node.js worker is finished. Was that already the case or is that a bug?

Aha, good find. I wonder if we can somehow polyfill that property in the code itself? Or maybe use ProvidePlugin, depending on when the error gets thrown.
Logs should be printed in real-time, so I'm not sure what's going on there. Will look into it soon.

The error occurs in a Webpack snippet, so not in something from our code. As far as I could tell, we have no real control over that piece of code (e.g. globalObject not being respected). We could obviously try, but this little hack might be the best solution.

I've taken a look, and it appears that that self.location line is indeed hardcoded (see here). However, there also appears to be an (undocumented?) baseUri option for chunks, which can be defined in the entrypoint configuration. I've implemented that in #47, which removes the need for the replace patch.
I'm unable to reproduce the web worker output issue myself; it appears to be in real time for me. It is very slow though, but that is most likely just my laptop acting up; I'll look into it a bit more, maybe the output I'm seeing is just incredibly slow terminal performance?

After some more trying I'm still unable to reproduce; the performance issue is definitely on my side, but after adding logging statements to the terminal callbacks as passed to YoWASP the output is received in real-time, and it lines up with the actual terminal output. My best guess at this point is different buffering behavior in Node.js worker threads, but again, that's a little difficult for me to debug since I'm not running into that myself.
The actual changes themselves look good to me though, so I'm OK with merge when you are.

Article that might be relevant to your (and my) interests: https://code.visualstudio.com/blogs/2023/06/05/vscode-wasm-wasi


Adapt the schema files to v3.0.1

This adapts the schema files to version 3.0.1
of the specification.
However, this is not an official release yet
and may be subject to change.
This is only meant as reference for the
API specification.

@s-heppner what is the state here? Please ping me when I can re-review this PR again.

@sebbader-sap You can use the now updated version for the API generation, however we still need to run the tests and generate the example files, before I will mark this PR as ready.

https://github.com/admin-shell-io/aas-specs/blob/b0e3e73e0584a869adc62fec30cce94d923eabe6/schemas/json/aas.json#L44
still has the old regex pattern.

This should be resolved now. Can you please check again?

@s-heppner the current state looks good for me, just two last questions:

See my comment above about the cardinality declaration. I am just not sure whether {,2} is a valid shortcut for {0,2}. Can you confirm this?
You removed the spaces from the general String-checking regex pattern, this seems fine therefore. However, I still find patterns with spaces, e.g. https://github.com/admin-shell-io/aas-specs/blob/6ab2e16187c3a3f1a60d722860e553b48ce201e3/schemas/json/aas.json#L692  Is this a problem?

@sebbader-sap
ad 1.) The zero is optional in regexes, see this comment
ad 2.) From all I can tell, this regex is fine and generally the spaces shouldn't place problems.
Please wait with the release until I was able to run the schema generation one last time, since we found one last issue: aas-core-works/aas-core-codegen#494

I regenerated the JSON Schema and confirmed that there are no other effects of aas-core-works/aas-core-codegen#494.
Therefore, this is now ready for release, as far as I'm converned


List.findIndex -1 not compatible with List.get

List.findIndex returns -1 if the item can't be found. If you then provide this index to List.get, it will return the last item! I would expect undefined.

I think it's a feature.
List.findIndex works like indexOf in Array
Using negative indices for getting values has been implemented in #116.
You should probably check if findIndex returns a negative value before passing it to List.get

I expected parity with [1,2,3][-1] => undefined

It's understandable since docs don't mention it.

It would be great to get a pull request improving the docs to mention this! For this particular bug report though I think we should close as "working as intended". Thanks for bringing this up!


templateContext not well explained / exampled

https://learn.microsoft.com/en-us/azure/devops/pipelines/process/templates?view=azure-devops#use-templatecontext-to-pass-properties-to-templates
I’d never noticed this functionality before but I’m struggling to understand the use case.  I don’t feel it’s hugely well explained as it really just shows an if switch.
I’ve done much the same type of thing as this example before with the if conditionals but it referenced a variable or parameters.
Why do I want to use templateContext over those methods of if-ing off a variable or parameter.
What advantage is it bringing to the table ?
I seen the original blog post and again don’t feel it gave a good example. Can anyone give me more examples ?
I posted this on azure devops on Reddit and the excellent Ming pointed out you can use this on top of a variable template but that still left me wondering why ?
there’s clearly something I’m missing as you’d not create this functionality without a need to fill.
thank you !
Much appreciated

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6724abea-bbdc-bf66-ed5e-3214fa6c3e66
Version Independent ID: 4f8dab21-3f0e-da32-cc0e-1d85c13c0065
Content: Templates - Azure Pipelines
Content Source: docs/pipelines/process/templates.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

@gabrielmccoll -- Gabriel, thank you for your thoughtful feedback.  Please consider these resources:

Azure DevOps Services
Azure DevOps on Stack Overflow

@juliakm -- Julia, please look into this issue.

@gabrielmccoll This comes from a Pipelines PM. I'll update the article as well.
The usefulness of the templateContext comes into light when you process each job, for example, to set up the environment for that job. Imagine you have an unbounded number of jobs that you pass as parameter value to your extended template. You could pass as parameters a list of jobs and an environment properties object (that is effectively a map between a job and its environment properties), but this is tedious and error prone. Each job must have an identifier, you must use the same identifier as a key in the environment properties object, and if you add a new job, you must remember to add it in the environment properties object, too.
If you take into consideration that one can use include templates that contain job definition, to benefit from reuse, the problem becomes even more complex: one would have to do a lot of copy-pasting of the environment properties object across different pipelines, and there would be no guarantee the job name would be unique.
By bundling the job and its environment properties object together, we make YAML more maintainable and easier to write and understand.

@gabrielmccoll This comes from a Pipelines PM. I'll update the article as well.
The usefulness of the templateContext comes into light when you process each job, for example, to set up the environment for that job. Imagine you have an unbounded number of jobs that you pass as parameter value to your extended template. You could pass as parameters a list of jobs and an environment properties object (that is effectively a map between a job and its environment properties), but this is tedious and error prone. Each job must have an identifier, you must use the same identifier as a key in the environment properties object, and if you add a new job, you must remember to add it in the environment properties object, too.
If you take into consideration that one can use include templates that contain job definition, to benefit from reuse, the problem becomes even more complex: one would have to do a lot of copy-pasting of the environment properties object across different pipelines, and there would be no guarantee the job name would be unique.
By bundling the job and its environment properties object together, we make YAML more maintainable and easier to write and understand.

I might need to read this a few times.  Is there any chance of an pair of examples that shows the comparison

Must have read it a few times by now and I still don't understand it.

I'm also struggling to understand this myself. I searched github, stackoverflow, google and I could not find an example of templateContext except for this one.
https://github.com/microsoft/security-utilities/blob/74c965348852c7f7606eec7faa75690ad48644bc/azure-pipelines.yml#L31-L39
This example makes me more confused because its much different than the example in release notes.

Might be worth opening a new issue tbh. This one’s closed but it seems like we’re all still a bit in the dark


Reuse databatch in processors.

There is no reason to copy all of the data in every processor.
cc: @jimmidyson

LGTM


remove suppliers of optionals

Thanks for sending a pull request! Here are some tips if you're new here:

Ensure you have added or run the appropriate tests for your PR.
Be sure to keep the PR description updated to reflect all changes.
Write your PR title to summarize what this PR proposes.
If possible, provide a concise example to reproduce the issue for a faster review.
Read our contributor guidelines
If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:
<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

Why push the SystemInfo into each check?  It is only used in 2 of them and the overhead to create it can't be that heavy.

thanks for merging that one commit! closing this ...


Dependabot fails to find latest versions using private Artifactory

I'm getting the following issue when using a private Artifactory nuget feed:
updater | INFO <job_113476641> Checking if My.Company.Dependency 1.5.3 needs updating
  proxy | 2021/04/22 21:31:19 [086] GET https://mycompany.jfrog.io:443/artifactory/nuget/
  proxy | 2021/04/22 21:31:19 [086] * authenticating nuget feed request (host: mycompany.jfrog.io, basic auth)
  proxy | 2021/04/22 21:31:19 [086] 200 https://mycompany.jfrog.io:443/artifactory/nuget/
  proxy | 2021/04/22 21:31:19 [088] GET https://mycompany.jfrog.io:443/artifactory/nuget/FindPackagesById()?id=%27My.Company.Dependency%27
  proxy | 2021/04/22 21:31:19 [088] * authenticating nuget feed request (host: mycompany.jfrog.io, basic auth)
  proxy | 2021/04/22 21:31:20 [088] 200 https://mycompany.jfrog.io:443/artifactory/nuget/FindPackagesById()?id=%27My.Company.Dependency%27
updater | INFO <job_113476641> Latest version is
updater | INFO <job_113476641> Requirements to unlock update_not_possible
updater | INFO <job_113476641> Requirements update strategy
updater | INFO <job_113476641> No update possible for My.Company.Dependency 1.5.3

There is a version 1.6.4 of My.Company.Dependency available, so it seems like something is going wrong with Dependabot here. Also, I checked this with a dependency that isn't made by MyCompany but does need an upgrade. It still doesn't work and the output is similar, which points to either something wrong with the configuration I have or with dependabot pulling from private artifact stores.
It's possible I have something misconfigured, but it seems to be OK to me.
Package ecosystem
nuget-feed
Package manager version
.net core
Language version
n/a
Manifest location and content prior to update
n/a
dependabot.yml content
version: 2

registries:
  nuget-jfrog:
    type: nuget-feed
    url: https://mycompany.jfrog.io/artifactory/nuget/
    username: my-username
    password: ${{secrets.DEPENDABOT_JFROG_SECRET}}
updates:
  - package-ecosystem: "nuget" # See documentation for possible values
    directory: "/" # Location of package manifests
    schedule:
      interval: "daily"
    target-branch: "3.x"
    registries:
      - nuget-jfrog

Updated dependency
n/a
What you expected to see, versus what you actually saw
Dependabot should open PRs for the dependencies that have updates available
Native package manager behavior
n/a
Images of the diff or a link to the PR, issue or logs
n/a
🕹 Bonus points: Smallest manifest that reproduces the issue
n/a

registries:
  nuget-jfrog:
    type: nuget-feed
    url: https://my-org.jfrog.io/artifactory/api/nuget/nuget
    username: ${{ secrets.ORG_JFROG_USERNAME }}
    password: ${{ secrets.ORG_JFROG_ACCESS_TOKEN }}
updates:
  - package-ecosystem: "nuget" # See documentation for possible values
    directory: "/" # Location of package manifests
    schedule:
      interval: "daily"
    target-branch: "3.x"
    open-pull-requests-limit: 10
    registries:
      - nuget-jfrog

all of a sudden, this seems to work. 🤷


feat: port data.int.lemmas

[x] depends on: #1159

This PR/issue depends on:

leanprover-community/mathlib4#1159
By Dependent Issues (🤖). Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#1159
By Dependent Issues (🤖). Happy coding!

bors r+