Indent style is not working and chunk never indents into the nested sections

Describe the bug
I'm attempting to replicate the rainbow indent style here. Except the style does not seem to work. And with chunk when selecting indented text it never indents in like you see in this gif.
❯ nvim --version
NVIM v0.10.0-dev-2039+g583c1de17-Homebrew
Build type: Release
LuaJIT 2.1.1710088188
Run "nvim -V1 -v" for more info

Screenshots
vid
Additional context
return {
  "shellRaining/hlchunk.nvim",
  enabled = true,
  opts = {
    indent = {
      enable = true,
      style = {
        "#FF0000",
        "#FF7F00",
        "#FFFF00",
        "#00FF00",
        "#00FFFF",
        "#0000FF",
        "#8B00FF",
      },
    },
    blank = {
      enable = false,
    },
    chunk = {
      enable = true,
      use_treesitter = true,
      chunk = {
        chars = {
          horizontal_line = "─",
          vertical_line = "│",
          left_top = "╭",
          left_bottom = "╰",
          right_arrow = ">",
        },
        style = "#00ffff",
      },
    },
    line_num = {
      enable = true,
    },
    exclude_filetype = {
      aerial = true,
      NvimTree = true,
      help = true,
      alpha = true,
      dashboard = true,
      Trouble = true,
      trouble = true,
      lazy = true,
      mason = true,
      notify = true,
      toggleterm = true,
      lazyterm = true,
    },
  },
  event = { "UIEnter" },
  config = function()
    require("hlchunk").setup({})
  end,
}

rainbow indent seems work properly... chunk does has some bug, I will fix it

Edit: I figured out my issue.
return {
  "shellRaining/hlchunk.nvim",
  enabled = true,
  branch = "main",
  event = { "UIEnter" },
  config = function()
    require("hlchunk").setup({
      indent = {
        enable = true,
        style = {
          "#FF0000",
          "#FF7F00",
          "#FFFF00",
          "#00FF00",
          "#00FFFF",
          "#0000FF",
          "#8B00FF",
        },
      },
      blank = {
        enable = false,
      },
      chunk = {
        enable = true,
        use_treesitter = true,
        chunk = {
          chars = {
            horizontal_line = "─",
            vertical_line = "│",
            left_top = "╭",
            left_bottom = "╰",
            right_arrow = ">",
          },
          style = {
            "#FF0000",
            "#FF7F00",
            "#FFFF00",
            "#00FF00",
            "#00FFFF",
            "#0000FF",
            "#8B00FF",
          },
        },
      },
      line_num = {
        enable = true,
      },
      exclude_filetype = {
        aerial = true,
        NvimTree = true,
        help = true,
        alpha = true,
        dashboard = true,
        Trouble = true,
        trouble = true,
        lazy = true,
        mason = true,
        notify = true,
        toggleterm = true,
        lazyterm = true,
      },
    })
  end,
}

fixed in latest commit~


Option to Render Whitespace only for selected lines

Think it would be a useful feature for a lot of people who like the convenience of the render whitespace option but dislike having it always visible

Duplicate of #1477


Move between zones with hotkey (f.i. with super-alt-arrows)

Description of the new feature / enhancement
Moving between top apps in the zones would be very useful for keyboard-centric workflows (alt-tab is garbage).
there is a handy shortcut win-alt-arrow which can be mapped to that.
sure it is great to make it customizable.
Scenario when this would be used?

User is typing something in the left panel.
He/she wants to change focus to the right one.
User presses Win-Alt-Right and easily switches to the right panel

Supporting information
No response

I now see it is a duplicate, sorry

I ended up with an AHK script for Win-Tab combination switching between left and right panels.
(as I use left-right layout)
I find it pretty useful.
; Maximize on Win+Up
#Up::WinMaximize, A
; Hotkey Win+Tab - remap the current windows behaviour
#Tab::SwitchWindow()
IsRightZone(x) {
return x > 100
}
SwitchWindow()
{
; determine target zone - opposite of the current zone
; iterate windows in z order
; first in the target zone needs to be activated
WinGet, activeId, ID, A

WinGetPos activeX, activeY, activeWidth, activeHeight, ahk_id %activeId%

toRightZone := not IsRightZone(activeX)

WinGet, windows, List

Loop, %windows%
{
    currentId := windows%A_Index%
    WinGetTitle, currentTitle, ahk_id %currentId%
    if (currentTitle = "")
        continue

    WinGetPos x, y, w, h, ahk_id %currentId%

    if (toRightZone = IsRightZone(x))
    {
        WinActivate, ahk_id %currentId%
        break
    }
}


Toggle fullscreen feature

I use XMonad.Layout.Fullscreen for fullscreen support and the AddFullscreen and RemoveFullscreen messages to manually make windows fullscreen but there is no easy way (at least I can't see one) to toggle the fullscreen state of a window say with a keybinding. So I went ahead and built my own xmonad-contrib where I added a ToggleFullscreen message and it works. I thought this feature should be in the official xmonad-contrib but I wanted to discuss this first before making a PR.
Sorry if I do something the the wrong way I am new to contributing to open source projects.

the whole point of contrib is that it's easy to PR to! So if you already have the code, there is no harm in simply doing the PR, and seeing what happens!

Ok I created the PR #395

At this point this is basically a duplicate of https://github.com/xmonad/xmonad-contrib/issues/456.  This will be added once https://github.com/xmonad/xmonad-contrib/pull/625 is merged


Deleting an important bin that contains my schoolwork!

https://jsbin.com/yururucaka/edit?html,output
I tested this code anonymously on JS bin, it is a very important piece of my schoolwork! I really can't afford to have it found my another student doing the same task or I will fail. I suppose in the future I will always test my code while logged in, in order to avoid such a dilemma.
Is there any way it can be deleted?

Sorry this took a few days, read the email but didn't have access at the time. This is done now.


GetSnapshots activity not documented

The GetSnapshots activity is not present in the Operations available in the audit and activity logs table

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a0e8bce0-95c1-07f7-d3a3-a1c22bd21f29
Version Independent ID: dddd1e30-4a88-1293-1264-3214cc4b6dc8
Content: Track user activities in Power BI - Power BI
Content Source: powerbi-docs/admin/service-admin-auditing.md
Service: powerbi
Sub-service: powerbi-admin
GitHub Login: @kfollis
Microsoft Alias: kfollis

@stbnjenkins - thank you for making us aware of that. I did find 4 snapshot activities in the audit log UI, so will track down the details and get an update made.

This information has been added to the article, so closing this issue. Thanks again for the feedback!


Refactored community resource links

@morrme you may want to provide review on this. If you find that you can't, you should have an invite to join the layer5io org here - https://github.com/layer5io.

@leecalcote for consistency, there should be an agreement on whether or not periods should be placed inside or outside of the closing  tag.

Good call, @morrme. Period moved to outside the anchor tag.


[mdcElevation] Elevation isn't working with mdc-card

Describe the bug
The mdcElevation property doesn't do anything for an mdc-card right now. It was working before I upgraded from 3.2.1 to 5.1.0
To Reproduce
Steps to reproduce the behavior:
<mdc-card [mdcElevation]="4">
    Hello, I am a card
</mdc-card>

Expected behavior
The card should have a shadow around it.
What Angular MDC version are you using? 5.1.1
What OS are you using?: Windows Server 2012
What browser(s) is this bug affecting?: Chrome

@KaranKapoorIon By default, cards are elevated which is overriding the custom mdcElevation. Try this..
<mdc-card>
  <div [mdcElevation]="5">
    Hello, I am a card
  </div>
</mdc-card>

@trimox That worked like a charm. Thanks!
 Thanks again! :+1:

@KaranKapoorIon Thank you, much appreciated!


BUG: West Longitudes show negatives

If this is my current position in SK data browser...
{
"longitude": -117.23187871379345,
"latitude": 32.500518317789535
}
KIP displays: (Latitude / Longitude in seconds) 1 Integer / 4 Decimal Places...
32* 30' 01.87" N
117* -13' -54.76" W
Not a big deal just caught my eye.

I think we need a coordinates widget. The numeric widget does not handle positions well.  We plan on having a AIS and such so we need to get to it.


How to save this pdf file to Android local storage

Hi, thanks for publishing this useful package,
How I can save this pdf to local storage in Android?
My problem is that I don't know how i can get this part:
 outputPath: '/path/to/output/file.pdf',
Do I should use Blob or Fs react  native?
of course I have to mention that I use     "react-native-document-scanner-plugin": "^0.9.0",
and I have a single uri that is generated by this plugin so I have the input path

I use react-native-blob-util, but the libraries you mentioned work too.

https://github.com/Canciller/react-native-images-to-pdf/blob/96e392f6c9181a9450c4a6acef98434e6b444c97/example/src/App.tsx#L70


Error: Building package boost-math:x86-windows failed with: BUILD_FAILED

Package: boost-math:x86-windows
Vcpkg version: 2020.02.04-nohash

@dljjqy, sorry for my late reply.
Does this still be a problem for you? I can't repro this issue with latest vcpkg and vs2017.
PS F:\vcpkg\src> ./vcpkg install boost-math:x86-windows
Computing installation plan...
The following packages will be built and installed:
boost-math[core]:x86-windows
Starting package 1/1: boost-math:x86-windows
Building package boost-math[core]:x86-windows...
-- Using cached F:/VCPKG/src/downloads/boostorg-math-boost-1.72.0.tar.gz
-- Using source at F:/VCPKG/src/buildtrees/boost-math/src/ost-1.72.0-2786b6df16
-- Building x86-windows-rel
-- Building x86-windows-rel done
-- Building x86-windows-dbg
-- Building x86-windows-dbg done
-- Packaging x86-windows-rel
-- Packaging x86-windows-rel done
-- Packaging x86-windows-dbg
-- Packaging x86-windows-dbg done
-- Packaging headers
-- Packaging headers done
-- Using cached F:/VCPKG/src/downloads/boost_LICENSE_1_0.txt
-- Installing: F:/VCPKG/src/packages/boost-math_x86-windows/share/boost-math/copyright
-- Performing post-build validation
-- Performing post-build validation done
Building package boost-math[core]:x86-windows... done
Installing package boost-math[core]:x86-windows...
Installing package boost-math[core]:x86-windows... done
Elapsed time for package boost-math:x86-windows: 2.491 min
Total elapsed time: 2.491 min

Hello, I'm with the same problem, but with the version x64

C:\xxxx\xxxx\vcpkg>vcpkg install boost-asio
Computing installation plan...
The following packages will be built and installed:
boost-asio[core]:x86-windows

boost-context[core]:x86-windows

boost-coroutine[core]:x86-windows

boost-date-time[core]:x86-windows

boost-math[core]:x86-windows

boost-thread[core]:x86-windows

boost-tokenizer[core]:x86-windows

openssl[core]:x86-windows

openssl-windows[core]:x86-windows
Additional packages (*) will be modified to complete this operation.
Starting package 1/9: boost-math:x86-windows
Building package boost-math[core]:x86-windows...
-- Using cached C:/xxxx/xxxx/vcpkg/downloads/boostorg-math-boost-1.72.0.tar.gz
-- Extracting source C:/xxxx/xxxx/vcpkg/downloads/boostorg-math-boost-1.72.0.tar.gz
CMake Error at scripts/cmake/vcpkg_extract_source_archive_ex.cmake:140 (file):
file RENAME failed to rename
C:/xxxx/xxxx/vcpkg/buildtrees/boost-math/src/TEMP/math-boost-1.72.0

to
C:/xxxx/xxxx/vcpkg/buildtrees/boost-math/src/ost-1.72.0-2786b6df16

because: No such file or directory
Call Stack (most recent call first):
scripts/cmake/vcpkg_from_github.cmake:139 (vcpkg_extract_source_archive_ex)
ports/boost-math/portfile.cmake:5 (vcpkg_from_github)
scripts/ports.cmake:90 (include)
Error: Building package boost-math:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: boost-math:x86-windows
Vcpkg version: 2020.02.04-nohash

I spot the same issue:
Starting package 1/9: boost-math:x86-windows
Building package boost-math[core]:x86-windows...
-- Using cached D:/coding/vcpkg/downloads/boostorg-math-boost-1.72.0.tar.gz
-- Extracting source D:/coding/vcpkg/downloads/boostorg-math-boost-1.72.0.tar.gz
CMake Error at scripts/cmake/vcpkg_extract_source_archive_ex.cmake:140 (file):
  file RENAME failed to rename

    D:/coding/vcpkg/buildtrees/boost-math/src/TEMP/math-boost-1.72.0

  to

    D:/coding/vcpkg/buildtrees/boost-math/src/ost-1.72.0-2786b6df16

  because: No such file or directory

Call Stack (most recent call first):
  scripts/cmake/vcpkg_from_github.cmake:139 (vcpkg_extract_source_archive_ex)
  ports/boost-math/portfile.cmake:5 (vcpkg_from_github)
  scripts/ports.cmake:90 (include)

Error: Building package boost-math:x86-windows failed with: BUILD_FAILED

If I copy the folder D:\coding\vcpkg\buildtrees\boost-math\src\TEMP\math-boost-1.72.0 one folder level up, rename it to ost-1.72.0-2786b6df16 and restart the build, the lib could be built. But that's not a solution...

I have problem with this package too. My output:
`D:\vcpkg>.\vcpkg install boost-math:x86-windows
Computing installation plan...
The following packages will be built and installed:
boost-math[core]:x86-windows
Starting package 1/1: boost-math:x86-windows
Building package boost-math[core]:x86-windows...
-- Using cached D:/vcpkg/downloads/boostorg-math-boost-1.72.0.tar.gz
-- Using source at D:/vcpkg/buildtrees/boost-math/src/ost-1.72.0-2786b6df16
-- Building x86-windows-rel
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
Command failed: D:/vcpkg/installed/x86-windows/tools/boost-build/b2.exe --stagedir=D:/vcpkg/buildtrees/boost-math/x86-windows-rel/stage --build-dir=D:/vcpkg/buildtrees/boost-math/x86-windows-rel --user-config=D:/vcpkg/buildtrees/boost-math/x86-windows-rel/user-config.jam -j12 --debug-configuration --debug-building --debug-generators --disable-icu --ignore-site-config --hash -q -sZLIB_INCLUDE=D:/vcpkg/installed/x86-windows/include -sBZIP2_INCLUDE=D:/vcpkg/installed/x86-windows/include -sLZMA_INCLUDE=D:/vcpkg/installed/x86-windows/include -sZSTD_INCLUDE=D:/vcpkg/installed/x86-windows/include threading=multi threadapi=win32 runtime-link=shared link=shared address-model=32 architecture=x86 toolset=msvc -sZLIB_BINARY=zlib -sZLIB_LIBPATH=D:/vcpkg/installed/x86-windows/lib -sBZIP2_BINARY=bz2 -sBZIP2_LIBPATH=D:/vcpkg/installed/x86-windows/lib -sLZMA_BINARY=lzma -sLZMA_LIBPATH=D:/vcpkg/installed/x86-windows/lib -sZSTD_BINARY=zstd -sZSTD_LIBPATH=D:/vcpkg/installed/x86-windows/lib variant=release debug-symbols=on
Working Directory: D:/vcpkg/buildtrees/boost-math/src/ost-1.72.0-2786b6df16/build
Error code: 1
See logs for more information:
D:\vcpkg\buildtrees\boost-math\build-x86-windows-rel-out.log
Call Stack (most recent call first):
installed/x86-windows/share/boost-build/boost-modular-build.cmake:296 (vcpkg_execute_required_process)
ports/boost-math/portfile.cmake:14 (boost_modular_build)
scripts/ports.cmake:90 (include)
Error: Building package boost-math:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: boost-math:x86-windows
Vcpkg version: 2020.02.04-nohash
Additionally, attach any relevant sections from the log files above.`
My log file:
build-x86-windows-rel-out.log

@buliasz, I can't repro this with vs2017 enterprise 15.9.19. Boost-math built successfully for me.
From your log, boost-math failed due to error C3859:
c1xx: error C3859: Failed to create virtual memory for PCH
c1xx: note: PCH: Unable to get the requested block of memory
c1xx: note: please visit https://aka.ms/pch-help for more details
c1xx: fatal error C1076: compiler limit: internal heap limit reached
See https://devblogs.microsoft.com/cppblog/precompiled-header-pch-issues-and-recommendations/ for this error.

@HLXEasy, for the issue you mentioned that duplicated to https://github.com/microsoft/vcpkg/issues/8199.

@dljjqy, please reopen this issue and attach failure log if it still be a problem for you.


Multiple sensor enhancement

I've managed to tain 10x BMP280 sensors via SPI with multiple CS lines as we want to measure pressure in multi-point system.
What I'd say the library is missing for that purpose is one little extra function like:
void bmp280_setDevice(struct bmp280_t *bmp280)
{
	p_bmp280 = bmp280;
}

So that one can have a table of sensors like:
struct bmp280_t BMP280[BMP280_COUNT];
And use them e.g.:
void BMP280_setActive(uint8_t dev_addr)
{
	if (dev_addr < BMP280_COUNT)
	{
		BMP280_active = dev_addr;
		bmp280_setDevice(&BMP280[BMP280_active]);
	}
}

bmp280_read_pressure_temperature(&BMP280_data[BMP280_active].pressure, &BMP280_data[BMP280_active].temperature);
Or, even more robust solution, if in each API function the first argument would be the pointer to the sensor struct. The internal static structure is not so universal.
But I guess most people only use one sensor in their system... ;)

@stawiski ,
Thank you for your suggestion. We have recently redesigned the APIs and are continuing to improve it in the coming weeks.
Regarding multiple sensor support, please refer to the BME280 driver https://github.com/BoschSensortec/BME280_driver. In the coming weeks we will release the same for the BMP280.


Bug : avatar

Now that avatar are kept-to-ratio, the avatar image is deformed
Either:

Don't keep the ratio, force the image to a square one
Center the image in the avatar css class

/cib


Disable retain runs while sorting out issue with script location.

Disabling retain runs whilst the script location is sorted out (this is due to a difference between the Java and Android EngSys).

/check-enforcer override


model is higher than normal

What?

What?

From the first perspective, the character model is one block higher than view.

Then you have some mod messing with stuff. This mod doesn't touch the camera at all and from the player model only the x and z, never the y.

Then you have some mod messing with stuff. This mod doesn't touch the camera at all and from the player model only the x and z, never the y.
How do i fix it in my game,i really need this mod.i tried to reinstall mod and still like this.

Figure out which mod is causing this and remove it/report the issue at that mods bug tracker/tell me here which one it is so I may look into it.

Figure out which mod is causing this and remove it/report the issue at that mods bug tracker/tell me here which one it is so I may look into it.

there's only 2 mods mod model is first-person model and yes steve model(ysm),i removed the ysm and my model position back to right place.I remind i used elytra while i quit the game,the description of ysm said ysm  compatible with first-persion model,should i make an issue on ysm mod?

Yea probably. Possible that recent changes broke the compatibility if they used the incorrect apis.

Figure out which mod is causing this and remove it/report the issue at that mods bug tracker/tell me here which one it is so I may look into it.

there's only 2 mods mod model is first-person model and yes steve model(ysm),i removed the ysm and my model position back to right place.I remind i used elytra while i quit the game,the description of ysm said ysm  compatible with first-persion model,should i make an issue on ysm mod?

There's already an issue of ysm and first-model model incompatible on Minecraft1.18
https://github.com/TartaricAcid/ysm/issues/60

This will affect 1.16.5-1.20.4.


Invalid default version

In my tests I keep getting error
picnic-api: produced an error with code [BAD_REQUEST] and message [No enum constant com.picnic.meta.ApiVersion.API_17]

Adding WithVersion("15") fixes the issue.
https://github.com/MRVDH/picnic-api also uses 15 as default version.

Resolved in V1.2.2


Azure OpenAI

Can you make it compatible with Azure Open AI?
This should be helpfull<EMAIL_ADDRESS>

Hi @stevenbaert - I just got this project working this morning with Azure OpenAI. I used the instructions from https://pypi.org/project/openai/ for Microsoft Azure endpoints along with the docs about the Langchain adapter here https://python.langchain.com/docs/guides/adapters/openai to get it to work.
When I was testing today, I had to provide the ChatCompletion.create function in llm_utils.py with a deployment_id parameter and open_api_key parameter and I configured Azure specific variables in config.py to get the adapter code in this repo to work with the Azure resources.

@stevenbaert this PR should be useful too https://github.com/assafelovic/gpt-researcher/pull/119
LiteLLM simplifies using Azure LLMs


Add Mageia logo

I added a block of code to logos.h and edited main.c to add the logo for the OS I'm writing this from: Mageia Linux.

lgtm, thanks for the contribution!
good job for updating main.c aswell ahah


SRS Review: Issues with Table of Symbols

TODO
Any point that requires more discussion should be pulled out to a different issue; I grouped these all here since they are related and small.

[x] The sentence "The choice of symbols was made to be consistent with the heat transfer literature and with existing documentation for solar water heating systems." is borrowed from the template and does not reflect your project.
[x] You say "The symbols are listed in alphabetical order," but they are not.
[x] Subscripts with words should not be italicized (i.e., R_{\text{Pinned}}).
[x] Consider an alternate way to display/name "Pinned" and "Roller"; perhaps change their names or use \text{} for them as well, since they are words and not variables (P*i*n*...).
From what I can tell, "n+1-dimensional" should be formatted as "(n+1)-dimensional" to be more clear.
[ ] The following symbols are missing: $\rho$, $x$ and $y$ (in the context of TM1), $M(x)$, and $EI$.

You're definitely correct that I didn't add all symbols to the table of symbols. x, y, E, and I are there now. I'll need to add the others too.
Aside: I currently have E and E_B. E is meant to be a hypothetical variable (without a value), while E_B is meant to be the one provided by users and have a concrete value. I haven't yet responded to @smiths feedback regarding this, but it seems relevant here :smile:
On the note of the table of symbols: do we want all symbols to be in the global table of symbols? I think it would be nice to have some symbols (such as E and I here) made and displayed locally in their respective theories because they don't leak into the instance models (I have E_B and I_B for the instance models). What do we think about having the global table of symbols only carry the symbols "local" to all instance models involving the inputs and outputs?
Pinging @smiths too.

I don't believe that Drasil allows for local symbols.  I'm fairly sure that all of the symbols go to the global table of symbols.  In the long run, we shouldn't do this.  We'll have too many symbol clashes once we get to more complex problems.  We also have the problem of mixing symbols that are only used once with symbols that are used multiple times.
In answer to your question @balacij, for symbols that are only used locally, you can define them locally and not include them in the global table of symbols.  You can do this for your manual SRS.  I'm not 100% sure you'll be able to do it for the Drasil SRS.

Sounds good, thank you @smiths! Hopefully we can figure out how to build scopes in Drasil at some point. I haven't been able to come up with a good solution yet.


add Is cA check

So, c.IsCA means HasExtension(basicConstraints) && basicConstraints.IsCA = true. For this set of "CA certs are encoded correctly" lints, I'd check everything based directly on the extensions themselves, since c.IsCA, IsSubscriberCert, etc all have some level of assumption that the certs are reasonable, and so if you're looking for weird inconsistencies about "is this actually a CA", you shouldn't assume any implementation of c.IsCA, etc, and should just directly check for the inconsistencies.
@zakird may disagree. @kumarde thoughts?

Agree.
On Tue, Aug 29, 2017 at 5:31 PM David Adrian<EMAIL_ADDRESS>wrote:

So, c.IsCA means HasExtension(basicConstraints) && basicConstraints.IsCA
= true. For this set of "CA certs are encoded correctly" lints, I'd check
everything based directly on the extensions themselves, since c.IsCA,
IsSubscriberCert, etc all have some level of assumption that the certs are
reasonable, and so if you're looking for weird inconsistencies about "is
this actually a CA", you shouldn't assume any implementation of c.IsCA,
etc, and should just directly check for the inconsistencies.
@zakird https://github.com/zakird may disagree. @kumarde
https://github.com/kumarde thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zmap/zlint/pull/139#issuecomment-325810376, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAMSUCbLb9U8VViACyETfXvTMJjVoXajks5sdIMYgaJpZM4PGZyJ
.

@dadrian to be clear, you're saying we should just marshal out the basicConstraints extension from the raw and check the value of IsCA straight from the cert, right?

@kumarde not sure if you'll need to marshal it (it might already be available parsed), but basically:

figure out what signing/constraints extension combinations you're checking for
explicitly check the values in the extensions

For each "CA is correctly encoded CA" lint

@dadrian mind taking a look and seeing if this is what you were expecting?

You might want to move basicConstraints to util or something, it looks like basically the same thing is defined in two lints?

I had to remove it from the second since it's declared in the same package

moving it to util also works.

On Tue, Aug 29, 2017 at 10:19 PM, David Adrian<EMAIL_ADDRESS>wrote:

You might want to move basicConstraints to util or something, it looks
like basically the same thing is defined in two lints?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/zmap/zlint/pull/139#issuecomment-325868060, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC4YLUijOtXkg1GeR8DBNO4neHPnlED4ks5sdNSmgaJpZM4PGZyJ
.

--
Deepak Kumar
University of Michigan Computer Science Engineering 2016
University of Michigan Minor in Mathematics 2016
Instructional Aide EECS 388 Fall 2015


listAssets candid decoded arguments error

When importing listAssets from @junobuild/core and using it in a NodeJS context, like this:
  await listAssets({
    collection: "user-profile-avatar",
    satellite: {
      identity: anonymous,
      satelliteId: "njz5m-nyaaa-aaaal-ajola-cai",
      fetch,
    },
  });

I receive the following error:
Pr [Error]: Call failed:
  Canister: <my_canister_id>
  Method: list_assets (query)
  "Status": "rejected"
  "Code": "CanisterError"
  "Message": "IC0503: Error from Canister <my_canister_id>: Canister called `ic0.trap` with message: failed to decode call arguments: Custom(Fail to decode argument 0 from table0 to text\n\nCaused by:\n    Subtyping error: text).\nConsider gracefully handling failures from this canister or altering the canister to handle exceptions. See documentation: http://internetcomputer.org/docs/current/references/execution-errors#trapped-explicitly"
    at

    ...

    index.mjs:30:18) {
  canisterId: Cr {
    _arr: Uint8Array(10) [
       0,  0,   0, 0, 1,
      96, 75, 150, 1, 1
    ],
    _isPrincipal: true
  },
  methodName: 'list_assets',
  type: 'query',
  props: {
    Status: 'rejected',
    Code: 'CanisterError',
    Message: 'IC0503: Error from Canister <my_canister_id>: Canister called `ic0.trap` with message: failed to decode call arguments: Custom(Fail to decode argument 0 from table0 to text\n' +
      '\n' +
      'Caused by:\n' +
      '    Subtyping error: text).\n' +
      'Consider gracefully handling failures from this canister or altering the canister to handle exceptions. See documentation: http://internetcomputer.org/docs/current/references/execution-errors#trapped-explicitly'
  },
  result: {
    status: 'rejected',
    error_code: 'IC0503',
    reject_code: 5,
    reject_message: 'IC0503: Error from Canister <my_canister_id>: Canister called `ic0.trap` with message: failed to decode call arguments: Custom(Fail to decode argument 0 from table0 to text\n' +
      '\n' +
      'Caused by:\n' +
      '    Subtyping error: text).\n' +
      'Consider gracefully handling failures from this canister or altering the canister to handle exceptions. See documentation: http://internetcomputer.org/docs/current/references/execution-errors#trapped-explicitly',
    signatures: [
      {
        timestamp: L { s: 1, e: 18, c: [ 17215,<PHONE_NUMBER>4931 ] },
        signature: Uint8Array(64) [
          147,  47,  88,   0,  83, 149,  78, 202, 195,   4,  96,
          164, 255, 227,  59, 112, 171,   0,  14,  44, 118, 246,
          170,  26,  26,  66, 100, 118, 115,   7,  67, 199,  87,
           87,  76,  52, 157, 239, 206,  23, 232,  10,   5, 160,
          173, 210, 206,  69, 200, 201, 114, 116,  22,  71, 103,
          247, 140, 122,   6,  35, 238, 177, 182,   9
        ],
        identity: Uint8Array(29) [
          235, 158,  15, 112, 233, 184, 191, 31,
           49, 179,  85,  43,  63, 184, 186, 80,
           52,  62, 230, 183,  45, 201,  27, 87,
          141, 100,   6,  88,   2
        ]
      }
    ]
  }
}

Not sure what's happening, your identity is correct?
With the sample I got no issue: https://github.com/junobuild/examples/blob/main/node/basic/assets.mjs
What's the version of your Satellite?
What version of the library are you using?

Maybe it's because you used the snippet which was outdated. If you update is as I just did it should work out.


Cannot edit the title of connectivity rules

User should be able to modify the title of the connectivity rules as long as their type is not "memory" or "function"

Realistically, to make this safe, we need to have connectivity rules have an ID such that when we change the name, it doesnt break prior references, since right now we are using the name for everything. Trying to ducktape in a way for BV (and FEAGI) to update connectivity names across the whole genome is slow, and likely error / bug prone

previous comment still holds. Lets discuss this for the rewrite


RFuture.cause() method should return CancellationException and not throw it.

Code to reproduce the issue:
RedissonPromise p = new RedissonPromise();
p.cancel(true);
p.cause();

Any timeline to add this to 3.10.x version and release?

I am seeing a number of exceptions like this when (I think) there is some interruption with access to Redis in 3.10.1:
ERROR o.r.client.handler.CommandDecoder - Unable to decode data. reply: :0
, channel: [id: 0x6e4b8748, L:/XXXX - R:XXXXX], command: CommandData [promise=RedissonPromise [promise=ImmediateEventExecutor$ImmediatePromise@3c300c7a(failure: java.util.concurrent.CancellationException)], command=(ZADD), params=[SessionExpired,<PHONE_NUMBER>156, PooledUnsafeDirectByteBuf(freed)], codec=org.redisson.codec.JsonJacksonCodec]
java.util.concurrent.CancellationException: null

@trasa
This issue was fixed in 3.10.2 please update to the latest version and give your feedback.


Cannot wait for system alerts 'Argument type IndexableSystemElement is not assignable to parameter type NativeElement'

What happened?
Using the system.element(by.system.label("Allow")) method that was released two weeks ago is almost useless unless your app is built to conform to this. We login and the privacy alert is shown but there's some delay and no way to account for the delay other than a hard wait.
await waitFor(system.element(by.system.label("Allow")))
        .toBeVisible()
        .withTimeout(15000);

Above is not accepted due to 'Argument type IndexableSystemElement is not assignable to parameter type NativeElement' we should be able to call waitFor on this method since there's no way to precisely expect an iOS system alert.
What was the expected behaviour?
Ideally you would be able to wait until the alert is shown using other methods.
Was it tested on latest Detox?

[X] I have tested this issue on the latest Detox release and it still reproduces.

Did your test throw out a timeout?

[ ] I have followed the instructions under Identifying which synchronization mechanism causes us to wait too much.

Help us reproduce this issue!
No response
In what environment did this happen?
Detox version:
React Native version:
Has Fabric (React Native's new rendering system) enabled: (yes/no)
Node version:
Device model:
iOS version:
macOS version:
Xcode version:
Test-runner (select one): jest / other
Detox logs
Detox logs
paste logs here!

Device logs
Device logs
paste your device.log here!

More data, please!
No response

@asafkorem  can you check this?

@noomorph @APrincipe21 This is not a bug. This usage is invalid. System APIs can't be used with waitFor.
This can be an enhancement request, so I'll keep this open with new labels + contributions are welcome :)
TBH, I need to see it with my own eyes, other dialogs that we test on our test-app doesn't have this issue..
For now, if you have to, you can do a busy-sleep or implement some try-catch mechanism as a workaround.


Bug: Removes <!DOCTYPE>

Expected Behavior
Doesn't remove <!DOCTYPE html> after format
Actual Behavior
Removes <!DOCTYPE html> after format
Steps to Reproduce the Problem

Format a document that contains <!DOCTYPE>

I was poking around and it appears that the result after the src is passed into htmlParser.parse() doesn't return a <!DOCTYPE> but instead the rootNodes first item is just {value: ""}.
This wouldn't be so much of an issue if you could disable this formatter for non-Angular HTML documents... But I'm not sure of an easy way to achieve this since, AFAIK, the Angular HTML templates aren't explicitly their own "language".
We need something like this:
...
"activationEvents": [
    "onLanguage:angular-html"
],
...

But of course that would mean VS Code understanding what angular-html is... Anyway to achieve that?

fixed by: https://github.com/stringham/angular-template-formatter/pull/14


Rynowak/shared testing

Fixes https://github.com/aspnet/Razor/issues/991 and https://github.com/aspnet/Razor/issues/1125

@ryanbrandenburg - please review.

Looks/looked good.


specific vs generic points in time

Description of the issue
A zero-dimensional temporal region is a temporal region that is without extent.
It is not clear (to me) how this is meant: does the region have to be specific (like "2003-01-01 00:00:00 UTC") or can it be generic (like "Wednesday 17:20", which happens every week)?  The first form is needed for empirical data and many model outputs, the latter for generic or stylised time series and some model outputs.  See https://github.com/OpenEnergyPlatform/ontology/issues/267#issuecomment-665679658 and following.
Ideas of solution
None so far.  I'm not clear on how the class zero-dimensional temporal region is to be linked to data.  I also don't know if there's a common practice for denoting generic time data (I don't use any).
Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[x] I already read the latest version of the workflow for this repository
[x] The goal of this ontology is clear to me

I am aware that

[x] every entry in the ontology should have a definition
[x] classes should arise from concepts rather than from words

does the region have to be specific (like "2003-01-01 00:00:00 UTC") or can it be generic (like "Wednesday 17:20", which happens every week)?

I think only the first one is a zero-dimensional region. The second one looks more like a time series (as you said). You can link a zero-dimensional temporal region to a quantity value via has quantity value. This quantity value consists of a number and unit (in this case propably a time unit). With several of these relations you can denote a zero-dimensional temporal region as precisely as necessary.

As it reads to me, the definition of the zero-dimensional temporal region does not require it to be fixed in time, only to be without extent.  My thinking is that the "generic" form would be needed/useful to construct stylised time series (but does not constitute one).
As a hypothetical example, there might by some energy system model that wants to use OEO (Yeay!) and works with stylised load profiles.  It could calculate optimal dispatch of existing capacities given exogenous demand on an hourly basis for one year – without specifying which year that is.
(For an example, see this figure https://github.com/OpenEnergyPlatform/ontology/issues/140#issuecomment-700657635.  It denotes hours of the day, but not what day.)
How would these time series' be tagged with OEO?  The point is not the precision of denoting time, but it's ambiguity.  So if temporal instants (alternate term) are "normally" denoted e.g. using ISO 8601 (2020-10-20T07) and the model in question decides to drop the year to denote an arbitrary year (-10-20T07), is that ontologically correct?  Is "October 20, 7 AM of any and every year a zero-dimensional temporal region?
If the answer is "yes", we have stylised time series' covered.  If not, we would need some class/concept/thing to do so.

You can link a zero-dimensional temporal region to a quantity value via has quantity value. This quantity value consists of a number and unit (in this case propably a time unit).

N.B.: You also need a reference point.  A quantity value (-5) and unit (seconds) only gives you five seconds before something, not an absolute position (T - 5 seconds, where T is the reference point).

With several of these relations you can denote a zero-dimensional temporal region as precisely as necessary.

Not sure what you are getting at.  In one dimension, you only need one absolute coordinate.  Additional ones are either conflicting or redundant.

Examples given by the BFO are: "right now, the moment at which a finger is detached in an industrial accident, the moment at which a child is born, the moment of someone ’ s death, and the turn of the nineteenth century".
These are very generic points in time, so I guess they don't necessarily need an exact date/time coordinate.
For the OEO use cases, it should be possible to annotate "2003-01-01 00:00:00 UTC" as well as "Wednesday 17:20". From my understanding, this works both with zero-dimensional temporal region. The user should be able to choose with quantity values / units she or he wants to attach.
But maybe @jannahastings can answer that best.

A zero-dimensional temporal region would mean just one time point. It doesn't have to be fully specified (i.e. Wednesday 17:20 is still a time point), but the interpretation is still that the instance is just one time point. An arbitrary time point (specified without the year) is fine, but it should nevertheless be strictly interpreted as a definite time point, just: one that we know less about. (Compare: an instance of apple vs. an instance of red apple -- both are single apples, but you know more about the latter from its specification.)
So, a recurring series of time points that occur every year is not an instance of a (single) zero-dimensional temporal region, but a series of instances of zero-dimensional temporal regions and would need to be classified as such.

Is "October 20, 7 AM of any and every year a zero-dimensional temporal region?

That was formulated badly.  I didn't mean recurring events.
So we're good here, no need to do anything. ;)


Imported symbols aren't shown in certain contexts

mod.nim
proc cube(x: int): int = x * x * x

main.nim
import mod
var x = |

In this case cube isn't suggested, only local symbols.
There are more cases like this, e.g.:
discard |

Also sometimes in the brackets of a procedure call it doesn't work too, but I didn't found a way to reproduce it.
There are probably more cases like these.

In this case cube isn't suggested, only local symbols.

Well cube is not exported.

Also this is a feature:
proc suggestEverything(c: PContext, n, f: PNode, outputs: var Suggestions) =
  # do not produce too many symbols:
  var isLocal = true
  var scopeN = 0
  for scope in walkScopes(c.currentScope):
    if scope == c.topLevelScope: isLocal = false

I forgot the export sign, but anyway the whole issue nonsense(sorry for that). Except one thing. I was able to track down it down:
let x = open("Test", |)
var y = open("Test2", |)
discard open("Test", |)
open("test", |)

When the cursor is at position of the first | fmRead, fmWrite etc. are suggested(maybe after typing some letters of them, but they are). When the cursor is at the second or third | it doesn't no matter how far the symbols are limited. But at the fourthst | it does suggests fmRead and fmWrite.

I recently reimplemented the cursor tracking in the compiler, so hopefully this will be solved as a side effect.

This seems to be fixed in the latest git version of Nim


Monitoring of node participation in ELB

This proposed check will make sure we have the nodes in their respective ELBs and alert us if not.

:+1:


feat: add ability to write out info as simulation progresses

This PR adds the ability to print out some logging info during the run. It adds two main ways to do this:

If you set LOG_LEVEL >= INFO then it will print out some number of updates over the time-axis loop, with current time, expected time, and current memory. This is just a standard print-to-screen kind of thing.
It also adds a slicker rich-based progress bar that is nice for interactive simulations (but maybe won't play as well with HPC-based jobs that write to a logfile).

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 66.29213% with 30 lines in your changes missing coverage. Please review.

Project coverage is 79.78%. Comparing base (027e72f) to head (290a790).

Files
Patch %
Lines

fftvis/logutils.py
25.71%
24 Missing and 2 partials :warning:

fftvis/simulate.py
92.59%
2 Missing and 2 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

:exclamation:  There is a different number of reports uploaded between BASE (027e72f) and HEAD (290a790). Click for more details.
HEAD has 3 uploads less than BASE

Flag
BASE (027e72f)
HEAD (290a790)

unittests
4
1

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #16       +/-   ##
===========================================
- Coverage   92.91%   79.78%   -13.14%
===========================================
  Files           4        5        +1
  Lines         127      183       +56
  Branches       35       43        +8
===========================================
+ Hits          118      146       +28
- Misses          5       30       +25
- Partials        4        7        +3

Flag
Coverage Δ

unittests
79.78% <66.29%> (-13.14%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


GIF rendered incorrectly

It looks like GIFs are wrongly rendered.
Here is how this gif is rendered:

While it should be:

We don't have animation support, images are converted to PNGs.
There is animation support in Kitty, but it's out of scope for now: https://sw.kovidgoyal.net/kitty/graphics-protocol/#animation

We don't have animation support, images are converted to PNGs. There is animation support in Kitty, but it's out of scope for now: https://sw.kovidgoyal.net/kitty/graphics-protocol/#animation

But even then they are incorrectly converted.
The image, while static, is messed up and doesn't resemble any frame of the original animation.

It's the frame magick outputs, we don't have control over that now :|


Add gardenlogin install hint

What would you like to be added:
Similar to https://github.com/gardener/dashboard/blob/a6d02e17f54917b73486e4d086bfa88803f62fd6/backend/lib/services/shoots.js#L396-L412 we should add a gardenlogin install hint for the Shoot kubeconfigs.
Also we should call kubectl-gardenlogin directly instead of kubectl gardenlogin, otherwise the install hint won't be shown if gardenlogin is not installed.
https://github.com/gardener/gardenctl-v2/blob/90fd13e051ad62a47882e84fdb8087721dc854e0/internal/gardenclient/shoot_client.go#L160
Why is this needed:

/closed with #214


Have a config flag to disable temporal entirely with spring-boot-auto-configure-alpha

Is your feature request related to a problem? Please describe.
Right now not all of our service environments are onboarded with temporal. So with the environments that do not have temporal but include the spring-boot-auto-configure-alpha dependency, there's no easy way to prevent the service from trying to instantiate temporal connection related beans. I have set the connection to local at the moment to have it error out and not crash the service.
Describe the solution you'd like
a enabled feature flag to conditionally create the temporal spring beans
Describe alternatives you've considered
I set the connection type to local and have it fail intentionally

Maybe we want to make Temporal beans opt-in instead (e.g. you have to provide a host:port for client bean to work). We should follow other Spring-supported dependencies/clients here which I assume only construct if some opt-in is performed.

Spring has a number of ways to disable specific auto configurations
https://docs.spring.io/spring-boot/docs/1.5.8.RELEASE/reference/html/using-boot-auto-configuration.html#using-boot-disabling-specific-auto-configuration


CLI changes for multiclusterapp Roles

This issue is based on the roles design refactor issue https://github.com/rancher/rancher/issues/18521

Roles is required in API now, so maybe CLI should make it required too
UI is only going to present cluster-owner and project-member roles. But we do want API and CLI to allow users to pass other roles. But can CLI add a short description suggesting users to provide the project-member role, or if they know that their app requires cluster role, then use the cluster-owner role?

Already discussed with @gitlawr that this is doable, but opening an issue to track this

@mrajashree to validate

Tested with v2.2.0-rc13

Roles is being handled as mandatory by passing project-member by default
The -h option explains why by displaying the following text as expected

   --role value                Set roles required to launch/manage the apps in target projects. For example, set "project-member" role when the app needs to manage resources in the projects in which it is deployed. Or set "cluster-owner" role when the app needs to manage resources in the clusters in which it is deployed. (default: "project-member")


NGINX naming

What are your changes?

Changed all occurrences to NGINX.

What type of changes does your doc introduce?

[ ] Bug fix
[x] New feature

What is the urgency level of this change?

[ ] Blocker
[ ] High
[x] Medium

I have completed these items:

[ ] I have tested all commands and code snippets.
[ ] I have built locally and tested for broken links and formatting.
[x] I have made this change for all affected versions (e.g. 1.7, 1.8, and 1.9).
[ ] My doc follows the style guide: https://github.com/dcos/dcos-docs#contributing.

Ping @emanic, @sascala, or @joel-hamill for reviewing pull request changes.
If you included a comment with your commit, it appears here:

TODO: make this change for Enterprise, after merged.


Small: alternate drawDiscrete

The drawDiscrete function in HARKsimulation should be extended with a boolean input to choose between two modes:

Current implementation, where draws from a discrete distribution are independent of each other.  Thus an input of p = [1/3,1/3,1/3] and x = [1,2,3] and N = 10000 might return an array of all 1's (with very small probability).

Alternate version that forces the simulated draws to match the discrete distribution as closely as possible, given the finite number of draws.  A version of this is in ConsumerType.makeIncShkHist(), so not much new coding is required.

I think (1) should be the default, as that's how the other drawX functions work.

Done in new commit to comments-and-cleanup.


migrate acquisition and inter library loans

Dump the tables of acquisition orders and Interlibrary loans - in the same fashion as the previous tables, visible in our production scripts
Write the script to load the dumped JSON to correct record types
Pay attention to manage the dependencies between loaded records.
test with larger amount of data

In CDS, crcILLREQUEST is the table that holds both ILL Borrowing Requests (book, article) and Acquisition Orders (acq-book, acq-standard, proposal-book). They are differentiated by the mentioned values of the field request_type. We should probably keep this field as legacy_request_type.

Should we keep the notes? In CDS there are library_notes (stringified object i.e. "{}" as an empty value) and borrower_notes.

There are few fields that were not migrated/used only_this_edition, overdue_letter_number, overdue_letter_date.

For the Acquisition Orders should we handle differently the statuses:

proposal-new
proposal-on order
proposal-put aside
proposal-received

recipient is required in ILS, and must hold the value LIBRARY or PATRON, how can we tell from the existing CDS data? If we cannot tell, which one should we use as default?

copies_ordered: number is required in Order, what should we use for default?

vendor_pid is required in Order, not stored in crcILLREQUEST.

What should we use for payment_mode: INTERNAL_PURCHASE_REQUISITION or CREDIT_CARD?


Add support for connecting to Zeus mobile wallet

@klaudius much thanks ... will still need to do some testing on it myself. see #337


[Bug]: Read Zip Issue

Guidelines

[X] I agree to follow this project's Contributing Guidelines.

Project Version
No response
Platform and OS Version
No response
Existing Issues
No response
What happened?
We would expect this zip folder of spc files to read correctly but it returns an error.
10.37.zip
Steps to reproduce
library(OpenSpecy)
file <- "10.37.zip"
check <- read_any(file)

Error in do.call(paste0("read_", tolower(ex)), list(file = file, ...)) :
'what' must be a function or character string

Also if we try to read the files as spc by themselves with read_spc
read_spc("10.8.D.spc")

Error in gsub(rawToChar(replace.nul), "\r\n", log.txt) :
'pattern' is invalid

Somehow the files can be read into OpenSpecy.org though, really a head scratcher.

Expected behavior
Read the spc files and/or zip
Attachments
No response
Screenshots or Videos
No response
Additional Information
No response

A bit more recon on this, the error line seems to be here in read_zip:
lst <- lapply(file.path(tmp, flst$Name), read_any, ...)

When it sends back to read_any we can find this line causing the issue os <- do.call(paste0("read_", tolower(ex)), list(file = file, ...))

Broke through the first error with https://github.com/wincowgerDEV/OpenSpecy-package/pull/161/commits/313395626442f0f2ed8e21085979e881d59e131d by updating how we extract the extension name.

The second error with read.spc is still there. I think it has something to do with file naming but not positive, I tested changing the file name but that didn't work. Will file issue with hyperSpec.

Working now thanks to spc fix.


Addon Error "Cannot read property 'emit' of null"

Related issue: https://github.com/mthuret/storybook-addon-specifications/issues/1
This issue is somewhat weird:
@tomitrescak got the error message
Cannot read property 'emit' of null

Which means that the addons variable here must be already available and addons.getChannel() call was successful. Which means @kadira/storybook-addons was already available.
The weird thing is that it started working once he installed @kadira/storybook-addons. Maybe it was some node module version mixups or its something else.
I checked the mthuret/storybook-addon-specifications code and the way it's using addons.getChannel() is fine. I tried setting up this addon with the react-button repo and it also worked fine.
cc: @arunoda @roonyh

We need to check with @tomitrescak he is using NPM2?

We need to do some webpack hack and try to load the same @kadira/storybook-addons in all the cases. (Using webpack's alias)
Then we may use @kadira/storybook-addons as a peer dependancy.

All addons have @kadira/storybook-addons as a peer dependency and @kadira/storybook has it as a dependency. So it should work fine, right?

@mnmtanish Ah yes. In that case, it should work properly.
May be the version of @kadira/storybook-addons in the @kadira/storybook is a older one.
Which don't have that emit method.
So, when the user installed @kadira/storybook-addons manually it will show up properly.

The emit method comes from the channel. From the error we can see that the user got null instead of the channel. This can happen when multiple versions of @kadira/storybook-addons gets loaded somehow. I think the one on react-storybook gets the addons.setChannel call and the one (somehow) loaded by the addon gets the addons.getChannel call.
Is there any node feature to make sure only one version of a module gets loaded?
Is it okay to use a global variable to check whether multiple versions are loaded?

Guys, the error was that I was using older version of storybook ... shame on me :/

Thanks @tomitrescak.
The think I guess might be correct.
I think we can close this now.

FYI, if you run into this while developing addons, I had to update .storybook/webpack.config.js:
const path = require('path');
module.exports = {
  ...<your wepback conf>...
  resolve: {
    alias: {
      '@kadira/storybook-addons': path.join(__dirname, '../node_modules/@kadira/storybook-addons'),
    },
  },
};


Fuzzy match produces wrong results

Erroneous matches produced by GetFuzzy() when the prefix length equals the length of the key string in the index.
For example, the dictionary
{"a": 1, "apple": 2}
GetFuzzy("app", 0, 1) would match "a"->1 with the score "0.0", and GetMatchedString() would return "app"
to reproduce execute the code in the attached file below
expected behavior:
the query should return and empty result set
keyvi_bug_20211217.py.zip

thanks for the report and the detailed reproduction steps. I haven't found the time yet to look into it, but I will asap.


Zstd support for compression

KIP-110 is finally accepted, so I can make a PR with something we've been using for quite a while now.
cc @dqminh, @andrew-plunk

Thanks for contributing this. Could we add some tests, similarly to how lz4 is tested?

@bai good point. I started looking into that and hit https://github.com/DataDog/zstd/issues/41.

I've updated PR with tests and a workaround for zero sized messages.

❤

This patch does not appear to actually work in practice without also incrementing the version of the producer and consumer protocol messages beyond 3 and 4 to 7 and 9, respectively. However, there are potentially breaking spec changes (even if not field/proto changes) in the intermediate versions we'd be skipping over.


Cleanup ducks folder

Summary of Changes
In order to write unit tests for the ducks folder, we wanted to resolve some inconsistencies in patterns and improve our organization of common types. This PR applies the organizational changes introduced and discussed in https://github.com/lyft/amundsenfrontendlibrary/pull/185 to the rest of the ducks directory.
Tests
Unit tests for ducks will be added in an upcoming PR. Jest thresholds for components were increased to reflect recent coverage improvements.
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes, including screenshots of any UI changes.
[x] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[x] PR passes all tests documented in the developer guide
[x] I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message"

Codecov Report

Merging #195 into master will increase coverage by 0.29%.
The diff coverage is 29.77%.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   58.29%   58.58%   +0.29%
==========================================
  Files         123      120       -3
  Lines        2983     2963      -20
  Branches      343      339       -4
==========================================
- Hits         1739     1736       -3
+ Misses       1213     1197      -16
+ Partials       31       30       -1

Impacted Files
Coverage Δ

...ication/static/js/components/ProfilePage/index.tsx
100% <ø> (ø)
:arrow_up:

..._application/static/js/components/NavBar/index.tsx
100% <ø> (ø)
:arrow_up:

...ation/static/js/ducks/tableMetadata/api/helpers.ts
0% <ø> (ø)
:arrow_up:

...tic/js/components/TableDetail/DetailList/index.tsx
0% <ø> (ø)
:arrow_up:

...tatic/js/components/common/PopularTables/index.tsx
100% <ø> (ø)
:arrow_up:

...js/components/TableDetail/WatermarkLabel/index.tsx
0% <ø> (ø)
:arrow_up:

...ts/TableDetail/DetailList/DetailListItem/index.tsx
0% <ø> (ø)
:arrow_up:

...components/TableDetail/DataPreviewButton/index.tsx
0% <ø> (ø)
:arrow_up:

...ication/static/js/components/TableDetail/index.tsx
0% <ø> (ø)
:arrow_up:

...ndsen_application/static/js/ducks/search/api/v0.ts
0% <0%> (ø)
:arrow_up:

... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 670cbdf...0c46dad. Read the comment docs.


Progressbar

Display progressbar during session
User should be able to see how many words he/she has already worked through during the current session

Not relevant anymore (since this repo now is a pure CMS)


Re-enable sidecar_api_test

Changes were required because:

mgmtCluster was changed - I guess it used to be 2 ports 3333 and 9999, but now we create it as 15020 by default, but in the tests we never set the management ports. I am not sure if this should be removed, or if we should find a way to trigger a management port being created. I dug through the code a bit but wasn't sure how to do this. @costinm or @rshriram any ideas? I don't want to disable the test without cause
BlackHoleCluster -> PassthroughCluster because ALLOW_ANY is default now

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/integration/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
7453413c8b7da031af384558ec4e3b1fa1a26643
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
7453413c8b7da031af384558ec4e3b1fa1a26643
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
7453413c8b7da031af384558ec4e3b1fa1a26643
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Integration tests are still failing though. :)

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
7453413c8b7da031af384558ec4e3b1fa1a26643
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
7453413c8b7da031af384558ec4e3b1fa1a26643
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
93da72717c154a9c6346eecb3b9563ddada3e658
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Integration tests are still failing though. :)

I think the tests are flakey, so we shouldnt enable them until that is fixed. We are getting this error:
2019-03-27T23:19:53.693736Z     info    transport: loopyWriter.run returning. connection error: desc = "transport is closing"
2019-03-27T23:19:53.693766Z     info    transport: loopyWriter.run returning. connection error: desc = "transport is closing"
2019-03-27T23:19:53.693774Z     info    ads     ADS: "[::1]:46296" sidecar~<IP_ADDRESS>~app3.testns~testns.cluster.local-1 terminated EOF
2019-03-27T23:19:53.693813Z     info    pickfirstBalancer: HandleSubConnStateChange: 0xc00048cf40, TRANSIENT_FAILURE
2019-03-27T23:19:53.693844Z     info    pickfirstBalancer: HandleSubConnStateChange: 0xc00048cf40, CONNECTING
2019-03-27T23:19:53.694125Z     info    grpc: addrConn.createTransport failed to connect to {[::]:36571 0  <nil>}. Err :connection error: desc = "transport: Error while dialing dial tcp [::]:36571: connect: connection refused". Reconnecting...
2019-03-27T23:19:53.694181Z     info    pickfirstBalancer: HandleSubConnStateChange: 0xc00048cf40, TRANSIENT_FAILURE
2019-03-27T23:19:54.694049Z     info    pickfirstBalancer: HandleSubConnStateChange: 0xc00048cf40, CONNECTING
2019-03-27T23:19:54.694361Z     info    grpc: addrConn.createTransport failed to connect to {[::]:36571 0  <nil>}. Err :connection error: desc = "transport: Error while dialing dial tcp [::]:36571: connect: connection refused". Reconnecting...

This repeats forever

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS
tests/integration/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
c513f4ce7e0242ce75fe5d6ef3afff7f03495862
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [ozevren]
tests/integration/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
c513f4ce7e0242ce75fe5d6ef3afff7f03495862
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


GUI is disabled when opened programmatically

Due to the _set_enabled behavior if you modify the launch-dev script to have the config be loaded before creating the widget (a reasonable thing to do one when scripting)
from pymmcore_plus import CMMCorePlus
from pathlib import Path

import napari
from useq import MDASequence

core = CMMCorePlus.instance()
core.loadSystemConfiguration(str(Path(__file__).parent / "tests" / "test_config.cfg"))

v = napari.Viewer()
dw, main_window = v.window.add_plugin_dock_widget("napari-micromanager")

sequence = MDASequence(
    channels=["Cy5", {"config": "FITC", "exposure": 50}],
    time_plan={"interval": 2, "loops": 5},
    z_plan={"range": 4, "step": 0.5},
    axis_order="tpcz",
    stage_positions=[(222, 1, 1), (111, 0, 0)],
)

main_window.mda.set_state(sequence)

napari.run()

then the entire GUI is still disabled.
I think the solution is to remove the top level concept of enabled/disabled and push that down to a per widget basis. They should check for the relevant loaded devices at creation and then listen the appropriate signals to (de)activate themselves as approriate.

thanks.  agreed.  let's take another close look at _set_enabled and try to do away with it entirely

My proposed fix will also involve new signals being added. Which also opens the (maybe thorny) question of where do those signals go. see https://github.com/micro-manager/mmCoreAndDevices/issues/149

Relevant signals being added to core here: https://github.com/micro-manager/mmCoreAndDevices/pull/163

Closing since this is not happening anymore. Still have an unrelated issue already mentioned in #255.
from pymmcore_plus import CMMCorePlus
from pathlib import Path

import napari
from useq import MDASequence

core = CMMCorePlus.instance()
core.loadSystemConfiguration(str(Path(__file__).parent / "tests" / "test_config.cfg"))

v = napari.Viewer()
dw, main_window = v.window.add_plugin_dock_widget("napari-micromanager")

sequence = MDASequence(
    channels=["Cy5", {"config": "FITC", "exposure": 50}],
    time_plan={"interval": 2, "loops": 5},
    z_plan={"range": 4, "step": 0.5},
    axis_order="tpcz",
    stage_positions=[(222, 1, 1), (111, 0, 0)],
)

main_window._show_dock_widget("MDA")
mda = v.window._dock_widgets.get("MDA").widget()
mda.set_state(sequence)

napari.run()


nicer css

so the new css is propagated at the next autobuild

LGTM we can ignore the regolith build error if you like


Enable testEagerParentFetchQuery

It seems it works now, probably because issue #39 about
eager fetch select.

Excellent!

Merged https://github.com/hibernate/hibernate-reactive/pull/662


experiment: fix readability of conditional

Ref: https://github.com/google/oss-fuzz-gen/pull/456/files#r1669405244

/gcbrun skip


SB-906:  Search for Nuget group repositories [ready]

Thanks for the massive amount of work you have done! :)


How to get landmarks? and Detect single face in each frame?

This project does not contain landmarks,  you can used retinaNet or mtcnn.
cenface->Detect(srcmatimg, &face_info);
detect face and save to face_info

Ok, what about detecting a single face instead of multiple faces?


Add an option to display commits from a specific date

Since there are cases when I work over the weekend, and I would like to discuss the issues with the team on our standup therefore it would be great to have a feature to pass in an option to the tool to display the commit from a date instead of the last 24 hours (like the default value).

I have implemented the feature and I did that in 3 batches.

Added es-lint to help the development, and I opened a PR from it here #4
I refactored the code, cleaned it up a bit, and made it extensible for this feature. This work depends on #4 and the changes can be seen here: https://github.com/raszi/git-scrum/compare/feat/add-eslint...raszi:git-scrum:refactor/main
I've added the feature on top of the refactored branch here: https://github.com/raszi/git-scrum/compare/refactor/main...raszi:git-scrum:feat/since-option

Please let me know if you are interested in this, then I could open the rest of the PRs after each other in the same order as I listed here.

Sounds good, thanks

I have opened the first PR here #6

I opened the last PR #7