Question:Possibility of adding a temporal component to the clustering

I wanted to know if it's possible to add a temporal component when it comes to how each node is clustered. Nodes with a close timestamp are clustered and this would take precedence over the spatial.

Hi Emmanuel, thanks for your interest and question!
If your data has n features, you could add the temporal coordinate as the (n+1) feature. For example if your data matrix X is 10x4 (10 data points with 4 features) and you have vector t of 10 time stamps, do:
import numpy as np
X = np.random.rand(10, 4) # 10 data points with 4 features
t = np.random.rand(10, 1) # 10 time stamps
s = 1                     # scaling
Xt = np.c_[X, s*t]
# now cluster Xt

Depending on the scaling parameter s, you can give more or less weight to the temporal direction.


Improve shadow threshold

Objects are prevented from casting shadows if their transparency is below X threshold.
If this threshold is too low, semitransparent objects may cast shadows when they're not supposed to or animated objects with variable transparency may cast shadows for part of their animation but not the rest of it - thus causing sharp strobing shadows.
If the threshold is too high, some objects which are supposed to cast shadows do not.
This was previously discussed in https://github.com/RS117/RLHD/issues/56 and the threshold was bumped from 0.25 to 0.3 to fix this specific case, but i continued to experiment and discuss other cases since then.
I've made a spreadsheet of affected objects here - https://docs.google.com/spreadsheets/d/16UIcbYeTgiubOE6nnOTjvZRabG80ZuxxPxFTIcLfnwY/edit#gid=0. Most things work over 0.35, but loot beams from the ground items default plugin require 0.55. For an upper bound on what the threshold can be, the only problem that i found with a high value was part of some bat wings missing when set to over 0.85.
In general, leaning high on the threshold is best IMO. The unintentional shadows and strobing shadows which can appear with too low of a threshold are a lot more distracting than maybe an occasional object not casting a shadow when it should. From many days of gameplay i've found several cases which are fixed with a higher threshold than 0.3 but nothing that broke below 0.85, so i think 0.75 is a good value to work from.

Revised upwards from 0.75 to 0.85 because it fixes Abberant Spectres without introducing any other issue that we're aware of. Added them to spreadsheet.


Sonner component has type errors!

I think a screenshot is worth a thousand words!

I'm not getting any error in this. Please check and verify on your end once. Even shadcn's sonner is successfully implemented in my project already.

Try uninstall it and install it again.

This error pops up for me as well.

It's happening to me too.

It maybe happens on some ts versions, I recommend you re-install shadcn to latest and see if that helps, it solved it for me!

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


Update accounts APIs to use latest from guide

Review this I'm noticing a few inconsistencies between what's currently in Base. What's in Base still works but would be good to be on par with things like the accounts emails. Should also review the reset password process to see if there are any updates to be done.

This appears to be good for the moment :+1:


Missing section on manual rolling upgrades

The document mentions that manual upgrades are supported as well with the feature, but it is not discussed in the article. Should we add a section on this?
Based on what I'm finding in the ARM template GitHub page for automatic upgrades, the same rolling upgrade that is triggered by the automatic upgrade can be manually scheduled through /subscriptions/<subId>/resourceGroups/<rgName>/Microsoft.Compute/virtualMachineScaleSets/<vmssName>/osRollingUpgrade if the OS image reference is latest and a new image is available, or if the OS image reference was previously set to a specific version -- by updating the image version.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 51c75ce7-2144-d81a-693c-fb51cc00f3e5
Version Independent ID: cba654ea-ee84-fca4-a76d-717bfb9d9bf5
Content: Automatic OS image upgrades with Azure virtual machine scale sets
Content Source: articles/virtual-machine-scale-sets/virtual-machine-scale-sets-automatic-upgrade.md
Service: virtual-machine-scale-sets
GitHub Login: @rajsqr
Microsoft Alias: rajraj

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.
CC @zr-msft

cc @cynthn

Please update the documentations with the command to run in PowerShell to start the manual rolling OS upgrade.

I found the command here: https://docs.microsoft.com/en-us/powershell/module/azurerm.compute/start-azurermvmssrollingosupgrade?view=azurermps-6.13.0

@zr-msft Can you please assign this issue to the right person to update the document with the information requested. Thanks. :)
CC: @cynthn

@Karishma-Tiwari-MSFT can you resassign to me for now? Thanks :)

@cynthn and @Karishma-Tiwari-MSFT - I was updating this doc yesterday for another feedback and saw this open thread. The details on manual upgrade have been added to the doc. We can close this thread now.


proof-of-concept fix for #8570

Summary
This is a fix for #8570.
Test plan

Codecov Report

Merging #8571 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8571   +/-   ##
======================================
  Coverage    63.2%   63.2%
======================================
  Files         271     271
  Lines       11284   11284
  Branches     2749    2748    -1
======================================
  Hits         7132    7132
  Misses       3538    3538
  Partials      614     614

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe14493...2f34d49. Read the comment docs.

Another question: I see that a bunch of the jest type declarations refer to NodeJS types but don't declare a "@types/node": "*" dependency.
Do you want to add that dependency to those modules or instead stub out the global NodeJS namespace with empty interfaces?

Another question: I see that a bunch of the jest type declarations refer to NodeJS types but don't declare a "@types/node": "*" dependency.
Do you want to add that dependency to those modules or instead stub out the global NodeJS namespace with empty interfaces?

That's on purpose due to #8092

As far as I know this is good to go.  Is there anything else that needs to be added?

Thanks!

Hi, I found this PR referenced here https://stackoverflow.com/questions/56181799/how-to-use-mocha-and-jest-with-typescript-without-conflicts
Is there any reason why this wasn't released? Or is it released already? I am trying to use Mocha for integration test and jest for unit tests and I'm running into this issue.
Thanks!

This was released in 24.9.0 last week


Stretchy header effect

I'm looking to create a header effect like this:

Specifically, I want it so when the user overscrolls on iOS, the image should zoom to fill the extra space. Then, on Android and iOS, when the user starts scrolling down the screen, the header should be scrolled away with a parallax effect.
I pulled the above screen video from this package here: https://github.com/gskbyte/GSKStretchyHeaderView
Another example can be found here: https://medium.freecodecamp.org/tutorial-creating-stretchy-layouts-on-ios-using-auto-layout-3fa974fa5e28
I was playing around with SliverPersistentHeaders and FlexibleSpaceBars but I was unable to get this effect quite how I wanted it.

Please consider asking support questions in one of the other channels listed at http://flutter.io/support .

I posted the question on StackOverflow: https://stackoverflow.com/questions/54580218/stretchy-header-effect
This does feel like the kind of thing that Flutter would want to officially support in some way, though, since it's a pretty common UI pattern.

Flutter is about lightweight widgets that can be composed to more powerful widgets.
What you propose would probably require lots of options to customize for individual needs and therefore probably not a good fit for the framework.

That makes sense! I wonder if there's some options or sliver widgets that Flutter could provide that would make this kind of thing easier, though. Or if I'm just missing something that already exists!

@maxlapides
See flutter_gallery/Studies/Pesto for more.

@kangwang1988 thanks for the tip! The SliverAppBar demo is handy. However, it doesn't demonstrate how I can get the stretchy background effect that I'm looking for. I'm still stuck on this one, unfortunately.

@maxlapides It would be better to ask on StackOverflow and only create an issue if it turns out to be a bug or a missing feature that prevents you from doing what you want.

@zoechi I did create an issue on StackOverflow, but so far I haven't found an answer. As far as I can tell, this is a missing feature that is preventing me from doing what I want.

I'll reopen and let the widget/framework maintainer decide.

I'm trying to achieve the same effect without success. This should be a SliverAppBar option since it is such a common UI pattern in iOS. Maybe with LayoutBuilder it is possible?

@zoechi

Flutter is about lightweight widgets that can be composed to more powerful widgets.
What you propose would probably require lots of options to customise for individual needs and therefore probably not a good fit for the framework.

I agree with your statement, but Flutter is also very much a multi platform tool.
And as a developer you kind of expect that eg. SliverAppBar and SliverPersistentHeader would work on iOS (and behave iOS-like).
It's a common pattern on iOS too.
Right now you are very limited regarding any type of expanding header on iOS.
I also hit this bug that is somewhat related (Bouncing scroll physics breaks sliver header):
https://github.com/flutter/flutter/issues/29264
To sum it up: Flutter could support sliver headers better for iOS.

there is a plugin available: https://pub.dev/packages/stretchy_header

Nice plugin but for me I need a dynamic height. And the plugin is abit to heavy with stack, my current idea is to use cliprect and scale together.

This looks like the inverted behavior of SliverFillRemaining(fillOverscroll: true, ...)
I think it could work in a similar way.

Hi all,
Just clarifying - what is needed here is the option for a stretch effect with SliverAppBar, along with a callback for when it is scrolled to a specified triggering distance?
I am assuming this will follow a similar convention to that of CupertinoSliverRefreshControl.
Also, currently SliverAppBar has options for other behaviors as well, including floating, pinning and snapping. I am also assuming these should all be available in all of the possible combinations?
Feedback always welcomed. 🙂

@Piinks that sounds exactly right!

Thanks for the feedback @maxlapides!
Would you be able to tell me what the package stretchy header, is lacking in meeting this need?

Nice plugin but for me I need a dynamic height. And the plugin is abit to heavy with stack, my current idea is to use cliprect and scale together.

@sooxiaotong, could you tell me what you mean by dynamic height?

@Piinks the header height is not dynamic. It should follow the image ratio after loaded without setting the fix height.

Thanks for clarifying!

#42250 will provide this feature.
That PR has a couple of animations and sample code to illustrate the use cases. If you would like to check it out, I would love to know what you think. :)

Hi @Piinks,
Is it possible to do a pull to refresh like this with the indicator that fades in gradually while pulling down, because seems like the callback doesn't have the stretched percentage and stretch threshold settings. And also does the expandedHeight supports dynamic height base on the image?

Hey @sooxiaotong !
I believe it is possible to do with #42250. Using a LayoutBuilder in the flexibleSpace of the SliverAppBar, the constraints.maxHeight will provide you with the current size of the app bar as it stretches. The percentage can be easily calculated based on your chosen 'expandedHeight`.  The stretch threshold is set to an overscroll offset of 100.0 by default, but you can customize that as well to whatever you like.
As to your other question - do you mean dynamic height as in, the app bar's expandedHeight will change to whatever height the image is? If that's the case, I do not think that is currently supported, and sounds like a separate feature. I would recommend filing a separate issue for that feature if that is what you are looking for. :)

@Piinks Okay thanks, looks like you have answered all my question~ I can't wait to use this pull in app now :3

Ship it 😍

@Piinks One last question, is it possible to use stretchModes with LayoutBuilder inside flexibleSpace?

The proposed StretchModes are only used as flags for the FlexibleSpaceBar class. If you look how they are used in the build method of FlexibleSpaceBar, you can see that the effects they trigger are fairly simple, using only a few lines of code. :)

@Piinks First of all, thank you very much for your work.
Excuse me, I can only use it on the master branch now, Has it been supported on the stable channel?

@Piinks
How to use it in the SliverPersistentHeader class and has supported it?

I want to do this.This is my current code.
import 'dart:ui';

import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

class AccountPage extends StatefulWidget {
  @override
  _AccountPageState createState() => _AccountPageState();
}

class _AccountPageState extends State<AccountPage>
    with TickerProviderStateMixin {
  double extraPicHeight;
  double extraBtmHeight;
  ScrollPhysics _physics;
  double prevDy;

  bool callNow;

  AnimationController animationController;
  Animation<double> animate;

  ScrollController _scrollController = new ScrollController();

  @override
  void initState() {
    super.initState();
    extraPicHeight = 0.0;
    extraBtmHeight = 0.0;
    prevDy = 0.0;
    callNow = true;
    _physics = AlwaysScrollableScrollPhysics();
    animationController = AnimationController(
      vsync: this,
      duration: Duration(milliseconds: 300),
    );
    animate = Tween(begin: 0.0, end: 0.0).animate(animationController);
  }

  void updatePicHeight(changed) {
    extraPicHeight = changed / 3;

    setState(() {
      extraPicHeight = extraPicHeight;
    });
  }

  void runAnimate() {
    setState(() {
      animate =
          Tween(begin: extraPicHeight, end: 0.0).animate(animationController)
            ..addListener(() {
              setState(() {
                extraPicHeight = animate.value;
              });
            });
      // prevDy = 0.0;
      extraPicHeight = 0.0;
    });
  }

  // 节流
  void debounce(Function fn) {
    if (callNow) {
      fn();
      callNow = false;
    }
  }

  @override
  Widget build(BuildContext context) {
    return AnnotatedRegion<SystemUiOverlayStyle>(
      value: SystemUiOverlayStyle.dark,
      child: Scaffold(
        body: Listener(
          onPointerMove: (event) {
            var position = event.position.dy;
            var detal = position - prevDy;

            if (detal > 0) {
              // print("================向下移动================");
              debounce(() {
                setState(() {
                  _physics = ClampingScrollPhysics();
                });
              });
              var result = _scrollController.offset;
              if (result <= 0) {
                updatePicHeight(detal);
              }
            } else {
              // print("================向上移动================");
            }
          },
          onPointerUp: (_) {
            runAnimate();
            animationController.forward(from: 0.0);

            if (_scrollController.offset <= 0) {
              callNow = true;
              setState(() {
                _physics = AlwaysScrollableScrollPhysics();
              });
            }
          },
          onPointerDown: (event) {
            prevDy = event.position.dy;
            callNow = true;
            setState(() {
              _physics = AlwaysScrollableScrollPhysics();
            });
          },
          child: PrimaryScrollController(
            controller: _scrollController,
            child: CupertinoScrollbar(
              controller: _scrollController,
              child: CustomScrollView(
                physics: _physics,
                slivers: <Widget>[
                  SliverPersistentHeader(
                    pinned: true,
                    delegate: SliverCustomHeaderDelegate(
                        title: '账号',
                        collapsedHeight: 40,
                        expandedHeight: 300 + extraPicHeight,
                        paddingTop: MediaQuery.of(context).padding.top,
                        coverImgUrl:
                            'https://p1.music.126.net/fqdzslent-Jx2MmhWAh0ow==/109951163009168472.jpg'),
                  ),
                  SliverFixedExtentList(
                    itemExtent: 50.0,
                    delegate: new SliverChildBuilderDelegate(
                      (BuildContext context, int index) {
                        //创建列表项
                        return new Container(
                          alignment: Alignment.center,
                          color: Colors.lightBlue[100 * (index % 9)],
                          child: new Text('list item $index'),
                        );
                      },
                      childCount: 20, //50个列表项
                    ),
                  ),
                ],
              ),
            ),
          ),
        ),
      ),
    );
  }
}

class SliverCustomHeaderDelegate extends SliverPersistentHeaderDelegate {
  final double collapsedHeight;
  final double expandedHeight;
  final double paddingTop;
  final String coverImgUrl;
  final String title;
  String statusBarMode = 'dark';

  SliverCustomHeaderDelegate({
    this.collapsedHeight,
    this.expandedHeight,
    this.paddingTop,
    this.coverImgUrl,
    this.title,
  });

  @override
  double get minExtent => this.collapsedHeight + this.paddingTop;

  @override
  double get maxExtent => this.expandedHeight;

  @override
  bool shouldRebuild(SliverPersistentHeaderDelegate oldDelegate) {
    return true;
  }

  Color makeStickyHeaderBgColor(shrinkOffset) {
    if (shrinkOffset > 5) {
      return Colors.white;
    } else {
      return Colors.transparent;
    }
  }

  Color makeStickyHeaderTextColor(shrinkOffset) {
    if (shrinkOffset > 5) {
      return Color(0xFF000001);
    } else {
      return Colors.transparent;
    }
  }

  @override
  Widget build(
      BuildContext context, double shrinkOffset, bool overlapsContent) {
    return Container(
      height: this.maxExtent,
      width: MediaQuery.of(context).size.width,
      child: Stack(
        fit: StackFit.expand,
        children: <Widget>[
          Container(child: Image.network(this.coverImgUrl, fit: BoxFit.cover)),
          ClipRect(
            child: BackdropFilter(
              filter: ImageFilter.blur(sigmaX: 10.0, sigmaY: 10.0),
              child: Container(
                // height: 200.0,
                color: Colors.white.withOpacity(0.3),
              ),
            ),
          ),
          Positioned(
            left: 0,
            right: 0,
            top: 0,
            child: Container(
              color: this.makeStickyHeaderBgColor(shrinkOffset),
              child: SafeArea(
                bottom: false,
                child: Container(
                  height: this.collapsedHeight,
                  child: Row(
                    mainAxisAlignment: MainAxisAlignment.spaceBetween,
                    children: <Widget>[
                      IconButton(
                        icon: Icon(
                          IconData(0xe660, fontFamily: 'iconfont'),
                          color: Color(0xFF000001),
                        ),
                        onPressed: () {},
                      ),
                      Text(
                        this.title,
                        style: TextStyle(
                          fontSize: 20,
                          fontWeight: FontWeight.w500,
                          color: makeStickyHeaderTextColor(
                            shrinkOffset,
                          ),
                        ),
                      ),
                      IconButton(
                        icon: Icon(
                          IconData(0xe619, fontFamily: 'iconfont'),
                          color: Color(0xFF000001),
                        ),
                        onPressed: () {},
                      ),
                    ],
                  ),
                ),
              ),
            ),
          ),
        ],
      ),
    );
  }
}

But this implementation is stupid.So how should I implement it using the flexiblespacebar and stretchmode.
I need to customize the Header Widget.I've been haunted by this problem for a long time.
Looking forward to your reply.

Hi @1111mp, this may be a good question to post on stack overflow. Also, what version of flutter were you using when working with this sample code? I believe that this feature only arrived on the stable channel last week.

@Piinks Thanks for your replay.I use the latest version of stable channel(v1.9.1+hotfix.6).
I just learned about Flutter. There are some bugs in this sample code about elastic rolling.Flutter intends to support this function in the future?

Thanks for the update!
I am not sure what you mean by elastic rolling, but the stretch effect requested in this issue has been rolled out to the stable channel as of last week.
If there is a bug you would like to report, I would recommend opening a new issue, with a description of the bug, the version of Flutter, and a minimal reproduction of the bug.
From the sample code you have provided, it is hard to tell what the problem may be. It also looks like you are incorporating several custom widgets, as well as ClampingScrollPhysics, which do not support overscrolling. Feel free to ping me on the new issue so we can investigate this further. :)

what is this animation called zoom in zoom out or stretchy zoomable header!

@LOG-TAG I wrote a post about that : https://medium.com/@diegoveloper/flutter-sliverappbar-with-stretchy-header-9ca04f316ff0


cupyx.scipy.spatial.transform implementation

Description
Following up on #6324 , I started to implement cupyx.scipy.spatial.transform from the scipy source until I got stuck.
For the implementation,

scipy.spatial.transform.tests where reimplemented into cupy/tests/cupyx_tests/scipy_tests/spatial_tests/transform_test
scipy.spatial.transform where reimplemented into cupy/cupyx/scipy/spatial/transform/

My current status:

missing features for the original scipy version:
-- from scipy.spatial import cKDTree
-- from scipy.optimize import linear_sum_assignment
--  from scipy.stats import special_ortho_group
-- from scipy._lib._util import check_random_state
-- scipy.linalg import solve_banded
retained numpy & scipy:
-- from scipy.constants import golden as phi
-- np.pi, np.import_array()
cupy.typing seems to just be an alias of numpy.typing

Since get_lapack_funcs(('gtsv',) get's called in solve_banded, which is needed for class RotationSpline, a full implementation would likely need to replace this with another module.
Unfortunately, I couldn't find notes on handling the legacy LAPACK from SciPy or on what to replace it with.
Additional Information
(In case somebody is interested in the current work in progress state)

cuSPARSE provides the gtsv routines and it seems the basic version has been exposed in CuPy. Perhaps they can be used for your purpose?


Support pseudo class + pseudo element combos

This is valid CSS:
p:target {
  background-color: gold;
}

/* Add a pseudo-element inside the target element */
p:target::before {
  font: 70% sans-serif;
  content: "►";
  color: limegreen;
  margin-right: .25em;
}

Right now, in Kobweb, you can do:
ComponentStyle("test") {
   target = ...
   before = ...
}

but it's a hack to combine them:
ComponentStyle("test") {
   psuedoClasses["target::before"] = ...
}

We probably want to rethink the API before we hit 1.0 to see if there's a better way, like:
ComponentStyle("test") {
   (target + before) = ...
}

This is now cssRule(":target::before")
Something like target + before might be neat, but it's not urgent, and definitely not a 1.0 milestone feature.


Trailing slashes added to routes whose name matches subdirectory in public directory

Reproduction
https://stackblitz.com/edit/remix-run-remix-xqcugh?file=app%2Froutes%2Fabout.tsx
System Info
System:
    OS: macOS 14.6.1
    CPU: (12) arm64 Apple M2 Max
    Memory: 487.45 MB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.7.3 - ~/.asdf/installs/nodejs/21.7.3/bin/node
    Yarn: 1.22.19 - ~/.asdf/shims/yarn
    npm: 10.8.2 - ~/.asdf/plugins/nodejs/shims/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 130.0.6723.70
    Safari: 17.6
  npmPackages:
    @remix-run/dev: ^2.12.1 => 2.13.1
    @remix-run/node: ^2.12.1 => 2.13.1
    @remix-run/react: ^2.12.1 => 2.13.1
    @remix-run/serve: ^2.12.1 => 2.13.1
    vite: ^5.4.7 => 5.4.7

Used Package Manager
npm
Expected Behavior
When visiting a route /about, I don't expect to be redirected to /about/. But I am consistently redirected to /about/ when there's a subdirectory in public with a name that matches the route name about.
Actual Behavior
We (Replicate) noticed that a handful of routes in the application were immediately redirecting to {ROUTE_NAME}/ with a trailing slash on the end.
➜  frontend git:(des-188-dig-into-frontend-slash-redirect-issue) ✗ curl http://localhost:3000/playground
<!DOCTYPE html>

<meta charset="utf-8">
<title>Redirecting</title>

Redirecting to /playground/

We could reproduce this in production and locally, after running npm run build and npm run start, the latter of which starts up Remix's server via the remix-serve library.
Because this library has basic logging built in, we noticed that curiously NO requests were being logged for /playground; only the requests for /playground/.
[remix-serve] http://localhost:3000/ (http://<IP_ADDRESS>:3000/)
GET /playground/ 200 - - 23.525 ms
GET /playground/ 200 - - 12.561 ms
GET /playground/ 200 - - 10.262 ms
GET /playground/ 200 - - 10.451 ms
GET /playground/ 200 - - 10.245 ms

I added a bunch of logs myself to the following file, and I realized that the static middleware was doing something funky; before those middlewares, I could see the logs for /playground but afterwards, it was nowhere to be found.
https://github.com/remix-run/remix/blob/b98a53eeb551459062a076f14186951b1cae7fec/packages/remix-serve/cli.ts#L126-L146
I also noticed that the static middlewares supports passing a redirect option which does the following...But Remix doesn't expose an API for configuring this yourself.

When I hardcoded redirect: false in that middleware, everything...just worked! But that wasn't a feasible fix without forking Remix. When I looked at how that middleware worked under the hood, I had an epiphany: the redirect behavior in the middleware only applied to directories. And it just so happened that we had both a playground URL in the Remix app, as well as a playground subdirectory in our app's public assets directory.
So in the end, I realized that Remix was just sort of confused here, and was treating this route (and /docs too, which had a docs directory in public) like a directory, adding the trailing slash.
This seems to me like unexpected or undocumented behavior, but I can't say that authoritatively. The simple fix was to rename the directory in my public directory. But I wonder if this is something that can be "fixed" even further?
Hope that helps!

Fair enough! We probably won't go the route of running our own server, as that's a much more heavy handed solution than renaming our subdirectories in public so that they their names don't clash with publicly accessible routes.
Would you at least be open to a PR that resolves/clarifies this issue, either by way of a change to the static middleware itself, or some documentation around remix-serve that cautions developers against this potential naming clash?

I don't think we necessarily want to try to document/call out these types of default behaviors since then we're effectively duplicating the documentation for those common express middlewares in our docs, and then. it's something we have to try to keep up to date.
I think we'd be open to maybe some extended wording on what middlewares are used by remix-serve and with links out to their docs so folks can find that type of info easier?

Understood, thanks for the prompt reply @brophdawg11 👍

Added some clarity in https://github.com/remix-run/remix/commit/80fd7e7a2c49829e56ec955c45580843b9e7e331

Fantastic. Thanks!


[Feature]: Fibonacci examples should take the number indexes as command-line arguments

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Fibonacci examples should take the number indexes as command-line arguments.
All examples except Zig should be updated.
See #18
Note, that currently Enarx incorrectly handles argv https://github.com/enarx/enarx/issues/2090.
Test this with wasmtime until that's done
Acceptance Criteria
No response
Suggestions for a technical implementation
No response

Assignment:
AssemblyScript: @rvolosatovs
C#: @platten
C++: @rjzak
C: @rjzak
Go: @rjzak
Grain: @rvolosatovs
JavaScript: @rvolosatovs
Python: @bstrie
Ruby: @rjzak
Rust: @bstrie
Swift: @rjzak
TypeScript: @rvolosatovs

@MaxGraey would you be interested in adapting the AssemblyScript example?
(for each index passed on command-line it should print the fibonacci sequence number corresponding to that index, see Zig example)

A better approach could be to take argument from stdin when no arguments are specified and FD_COUNT > 0.
With no arguments and FD_COUNT == 0 use a default of 10

Please use:
./tests/run.sh ./tests/fibonacci/golden/default --wasmcfgfile ./result/Enarx.toml ./result/main.wasm
cat ./tests/fibonacci/stdin | ./tests/run.sh ./tests/fibonacci/golden/stdin ./result/main.wasm

For testing, where result is a directory containing Enarx.toml and main.wasm


fix: explicitly add systemctl and grep to path in shell-wrapper

We can generally find them in /run/current-system/sw/bin, but WSL may try to call those before activation is fully done, so make sure it can always find what it needs.

If we're doing that, shouldn't we just add environment.systemPackages (and environment.defaultPackages) to path instead of some packages explicitly and sourcing /etc/set-environment?

I'm not sure, I'd rather have the bare minimum needed by the WSL machinery here and handle the rest in a way that's as conventional as possible.

We could also just put a busybox in there. That would be future-proof as well and less easy to brick by changing the system config

They do call systemctl, so we can't just put a busybox in there.

Right, I meant that more as "instead of gnugrep"

I'm 100% expecting WSL to assume gnugrep there tbh.


ImportError: cannot import name 'QdrantClient' from partially initialized module 'qdrant_client' (most likely due to a circular import)

how to solve this problem?, my env is python 3.8
ImportError: cannot import name 'QdrantClient' from partially initialized module 'qdrant_client' (most likely due to a circular import)

Hi, which qdrant-client version do you use?
Could you show the structure of your working dir? Do you have directories named qdrant_client?

oh, make sense. Sorry, I forget that I have named my work dir as qdrant-client.py
Thanks a lot


Processing EI's acquisition function

What's the reason behind processing the acquisition function in the way shown below?

## Acquisition function:
x_grid = np.arange(bounds[0][0], bounds[0][1], 0.001)
x_grid = x_grid.reshape(len(x_grid),1)

# (1) ACQU
acqu = acquisition_function(x_grid)

# (2) ACQU_NORMALIZED
acqu_normalized = (-acqu - min(-acqu))/(max(-acqu - min(-acqu)))
m, v = model.predict(x_grid)

model.plot_density(bounds[0], alpha=.5)

plt.plot(x_grid, m, 'k-',lw=1,alpha = 0.6)
plt.plot(x_grid, m-1.96*np.sqrt(v), 'k-', alpha = 0.2)
plt.plot(x_grid, m+1.96*np.sqrt(v), 'k-', alpha=0.2)

plt.plot(Xdata, Ydata, 'r.', markersize=10)
plt.axvline(x=suggested_sample[len(suggested_sample)-1],color='k')
factor = max(m+1.96*np.sqrt(v))-min(m-1.96*np.sqrt(v))

# (3) ACQUISITION
acquisition = 0.2*factor*acqu_normalized-abs(min(m-1.96*np.sqrt(v)))-0.25*factor

plt.plot(x_grid,acqu, 'b-',lw=2,label ='Acqu. Original')
plt.plot(x_grid,acqu_normalized, 'g-',lw=2,label ='Acqu. Normalized')
plt.plot(x_grid,acquisition, 'r-',lw=2,label ='Acquisition')

plt.legend(loc='top left')

The EI, MPI etc need to be  maximized to compute the next point. However, most optimizers are designed to minimize and that's why in GPyOpt we optimize (minimize) the negative acquisition.
The normalized one is just the acquisition we plot in the 1D case. As it is only warped into the interval [0,1] its global maximum doesn't change and is useful for visualization purposes.


Attach to running process

It seems that it is currently not possible to profile an already running process, by attaching via known process ID.
I have a multi-process long-running deamon and want to attach to one of its processes (known pid) for profiling only for some time, then detach again. This is possible with perf via -p <pid>, can this also be supported with samply?

See https://github.com/mstange/samply/issues/56, use the git version.


.sequelizerc configuration isn't supported

Custom paths defined in .sequelrc aren't supported since the lib uses hardcoded paths.

same problem here

+1

@ALiangLiang i also found that code. so how can set migrations-path in command line?

My case i wanna run makemigration command in upper folder like that
src
  - migrations
  - models
package.json

So i re declare the PWD env in package.json file like that
PWD=$PWD/src node ./node_modules/sequelize-auto-migrations/bin/makemigration

Has this problem been fixed? I am not able to generate the migrations and I believe it is because of my .sequelizerc


Revive realistic SOSE pilot simulation

This PR revives the pilot simulation initialized and forced using SOSE data that's sitting in the observations directory.
Running the pilot_simulation.jl script should produce the movies and plots below.
Obviously first problem in these figures is that the lat, lon I picked has what seems to be a very unstable temperature profile. Must be stable in real life though? Maybe our TEOS-10 equation of state isn't doing the right thing? Or maybe it's due to powerful lateral fluxes?
Was considering adding in the advanced statistics used in three_layer_constant_fluxes.jl but it'll just slow down the simulation right now when we probably want it to be fast for debugging. Let's make sure we can get the first-order statistics right first.
For fleshing out the setup we should probably pick a lat, lon that is nice and stable, preferably with small lateral fluxes.
Right now the script only runs on the CPU because Interpolations.jl is used in the forcing functions. Probably the next thing the script needs is linear interpolation on the GPU to we can actually run the script quickly.
One approach to making the interpolation GPU friendly would be to use Interpolations.jl to interpolate from the SOSE vertically stretched grid to the Oceananigans.jl grid and store the interpolated profiles in a ReducedField, then Oceananigans.Fields.interpolate can be used in the forcing functions as it's already used for Lagrangian particle advection.
cc @sandreza
Top row is surface plots, bottom row is yz slices:
https://user-images.githubusercontent.com/20099589/108284236-d6cdca80-7152-11eb-8d0d-108b5240fbe0.mp4
https://user-images.githubusercontent.com/20099589/108284241-d7fef780-7152-11eb-9c76-376bbafc44d0.mp4

This looks really awesome!

Should we write a script that analyzes a site? Eg plots the initial temperature, salinity, and velocity profiles, plots time series of the fluxes... ?

I left in some older scripts that analyzes the heat and salt budgets and surface forcings for a patch. We have monthly resolution for the budgets and daily resolution for the surface forcings. We could probably easily adapt them to analyze a specific lat/lon site before setting up the simulation.
https://github.com/CliMA/LESbrary.jl/blob/master/observations/plot_patch_fluxes.py
https://github.com/CliMA/LESbrary.jl/blob/master/observations/plot_patch_forcings.py

Note to self for when I revisit this PR: We also have a hidden Oceananigans feature that lets us use TimesDates.jl for model.clock.time which immediately makes the movies/plots feel more realistic when the title says "13:45, January 11, 2017"!

Ah, maybe a simple addition would be to plot the buoyancy profile. I see that the temperature is destabilizing and the salinity is stabilizing, but I don't see how to come to the conclusion that the initial profile is stable. The dynamics do imply that there's instability...
I'm not sure that ECCO uses TEOS10 (maybe they use EOS80?) In that case it could maybe be possible that our initial profile is unstable. Not sure.

Added some more analysis/plotting code so we can better understand these simulation. These plots are all automatically generated when you run pilot_simulation.jl.
Looking at the site analysis, I think I picked a pretty bad site (and time). Simulation time is highlighted in yellow. Seems to be a pretty unstable time for the mixed layer just before a big stratification in September 2013. Or rather, the mixed layer was probably capped from above making the model think the mixed layer got very shallow but this is a limitation of the mixed layer depth diagnostic.
Also plotted the buoyancy profile B(z) from Oceananigans and the stratification profile ∂ρ/∂z from SOSE. Might be good to be able to diagnose ∂ρ/∂z from Oceananigans since B(z) doesn't seem particularly useful (seems wrong too, I need to check that it does the right thing with TEOS10).
Looking at SOSE's ∂ρ/∂z I'm not sure what I'm looking at either since the numbers suggest it's just ρ - 1000 but the data is described as stratification ∂σ/∂z on the website (and ∂ρ/∂r in the NetCDF file). Either way seems salinity dominated.
I also compare the Oceananigans.jl mixed layer depth with SOSE's MLD diagnostic. The Oceananigans.jl MLD is computed using some code I copy pasted from @glwagner that only gives a grid point so it's a little noisy. Should make more sense when we pick a better site.

https://user-images.githubusercontent.com/20099589/108714761-f3b62500-74e7-11eb-9ff7-461bd89ae1e7.mp4

Some more useful things we could look at (kind of a TODO list):

Movie of large-scale U, V, T, S, ∂ρ/∂z, U_geo, V_geo using interpolated data before running the simulation so we know what kind of background state we're getting into. Could also do it for the full 5-year SOSE period.
Download SOSE heat and salt budget diagnostics so we can plot lateral vs. vertical fluxes at a particular site before running a simulation.

@glwagner @adelinehillier Do you guys think anything is missing before we can merge?

I say merge, this is a beautifully documented PR!

I'll wait until https://github.com/tomchor/Oceanostics.jl becomes a registered package then update and merge this PR.

In the future maybe we can write up a script that runs plot_site_analysis to look at a bunch of different sites for choosing purposes.

Yeah that would be super useful, especially if we download and also plot the lateral vs. vertical fluxes.


Increase contrast of colours to validate WCAG AA

This is a pull request for issue #2224.
Wagtail doesn't currently validate against WCAG colour contrast guidelines. In 1.7 @strindhaug   improved the contrast in PR #2985, which helps but doesn't solve the problem with the background colour within headers and on revision pages (or any page where the warning button is displayed).
@alexgleason and I had previously worked on a pip installable module to get round this problem, and some others, on certain projects, but it used some horrible hacks to get around this particular issue, and was a very brittle solution to the problem.
The proposed solution is to use the existing $color-teal-dark as $color-teal and change $color-teal-dark to #0F2828.
Explorer page with breadcrumb

Revision page

Hi @thibaudcolas, apologies for not responding more quickly to this.
The colours were run through http://webaim.org/resources/contrastchecker/ and http://leaverou.github.io/contrast-ratio/
I think there's possibly a broader question about all of the colours within the Wagtail UI but probably out of scope of this pull request.

I've added this for review at the next core team meeting. Would also be worth discussing in Iceland 🙂

Sounds good. Thanks @thibaudcolas

Discussed this last week and today – those are quite sweeping visual changes so they won't be merged as is. We want a visual design person to get involved to assess this further.
A potential alternative approach would be to have settings of sorts for a separate "high-contrast mode". I think the default install shouldn't compromise on accessibility, but realistically it would be easier to solve this within Wagtail itself with a separate code path.

Yup, seems totally reasonable. I think it'd make a lot of sense for a visual designer to consider how this could be moved forward. As you say it's a broad visual change, and something that has a big impact on the UI.
(And do let me know if it's better to close this PR, rather than having an open PR that's unlikely to be merged in.)

You're right – I forgot that there was an issue open as well. Closing this, we can take the discussion there.


dep: upgrade jemalloc

What problem does this PR solve?
Issue Number: close #xxx
Before
[Summary] Q1: 1.00s
[Summary] Q10: 0.89s
[Summary] Q11: 0.30s
[Summary] Q12: 0.50s
[Summary] Q13: 0.76s
[Summary] Q14: 0.49s
[Summary] Q15: 0.73s
[Summary] Q16: 0.34s
[Summary] Q17: 1.05s
[Summary] Q18: 1.28s
[Summary] Q19: 0.72s
[Summary] Q2: 0.38s
[Summary] Q20: 1.00s
[Summary] Q21: 1.49s
[Summary] Q22: 0.22s
[Summary] Q3: 0.69s
[Summary] Q4: 0.68s
[Summary] Q5: 0.89s
[Summary] Q6: 0.30s
[Summary] Q7: 0.56s
[Summary] Q8: 0.95s
[Summary] Q9: 1.91s

After
[Summary] Q1: 0.97s
[Summary] Q10: 0.78s
[Summary] Q11: 0.32s
[Summary] Q12: 0.50s
[Summary] Q13: 0.69s
[Summary] Q14: 0.48s
[Summary] Q15: 0.74s
[Summary] Q16: 0.36s
[Summary] Q17: 0.97s
[Summary] Q18: 1.21s
[Summary] Q19: 0.70s
[Summary] Q2: 0.34s
[Summary] Q20: 0.97s
[Summary] Q21: 1.30s
[Summary] Q22: 0.19s
[Summary] Q3: 0.62s
[Summary] Q4: 0.52s
[Summary] Q5: 0.90s
[Summary] Q6: 0.27s
[Summary] Q7: 0.55s
[Summary] Q8: 0.97s
[Summary] Q9: 1.82s

What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-all-tests

/merge

/merge cancel

/run-integration-test


EXCEPTION: Uncaught (in promise): Failed to warm up service null

Ionic version:  (check one with "x")
[ ] 1.x
[ x] 2.x
I'm submitting a ...  (check one with "x")
[ x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
When starting the application, this is the console output that I get:
[21:14:50]  console.log: Angular 2 is running in the development mode. Call enableProdMode() to enable the production
mode.
[21:14:50]  console.error: EXCEPTION: Uncaught (in promise): Failed to warm up service
[21:14:50]  console.error: ORIGINAL STACKTRACE:
[21:14:50]  console.error: Error: Uncaught (in promise): Failed to warm up service at s
(http://<IP_ADDRESS>:8100/build/polyfills.js:3:4211) at http://<IP_ADDRESS>:8100/build/polyfills.js:3:3961 at
Object.callbackFromNative (http://<IP_ADDRESS>:8100/cordova.js:295:52) at processMessage
(http://<IP_ADDRESS>:8100/cordova.js:1119:17) at processMessages (http://<IP_ADDRESS>:8100/cordova.js:1142:9) at
t.invoke (http://<IP_ADDRESS>:8100/build/polyfills.js:3:9094) at Object.onInvoke
(http://<IP_ADDRESS>:8100/build/main.js:42823:37) at t.invoke (http://<IP_ADDRESS>:8100/build/polyfills.js:3:9045)
at e.run (http://<IP_ADDRESS>:8100/build/polyfills.js:3:6481) at http://<IP_ADDRESS>:8100/build/polyfills.js:3:4583
[21:14:50]  console.error: Unhandled Promise rejection: Failed to warm up service ; Zone: angular ; Task: Promise.then ;
Value: Failed to warm up service null
[21:14:50]  console.warn: Native: deviceready did not fire within 2000ms. This can happen when plugins are in an
inconsistent state. Try removing plugins from plugins/ and reinstalling them.
[21:14:50]  console.log: deviceready has not fired after 5 seconds.
[21:14:50]  error opening ws message: {"category":"console","type":"log","data":["DEVICE READY FIRED AFTER",3938,"ms"]}
Expected behavior:
No exception at startup.
Related code:
I am not sure yet if there is any 'related code' because it just happens at startup.
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Your system information:
Cordova CLI: 6.5.0
Ionic Framework Version: 2.0.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.0.0
ios-deploy version: 1.9.0
ios-sim version: 5.0.8
OS: macOS Sierra
Node Version: v6.9.2
Xcode version: Xcode 8.2.1 Build version 8C1002

Hey, thanks for using Ionic! To be honest i've never seen this error before, would you mind posting a repo we can use to reproduce this issue?

Hi, actually after doing some more research I found out that it has something to do with Ionic Native's SafariViewController.
SafariViewController.isAvailable().then((available: boolean) => {       if(!available) return;       SafariViewController.warmUp(); });
If I remove SafariViewController.warmUp(); the Exception disappears. Under the hood this warmUp() is supposed to warm up Chrome Tabs. But this fails even on an Android device it seems.
Although I resolved the exception for now the warning remains:
[21:14:50] console.warn: Native: deviceready did not fire within 2000ms. This can happen when plugins are in an
inconsistent state. Try removing plugins from plugins/ and reinstalling them.
[21:14:50] console.log: deviceready has not fired after 5 seconds.
[21:14:50] error opening ws message: {"category":"console","type":"log","data":["DEVICE READY FIRED AFTER",3938,"ms"]}

Thanks for the info @BSWG . Based off the info you provided I am going to close and move this issue to the ionic native repo.

This issue was moved to driftyco/ionic-native#1006


[DO NOT MERGE] Table Test Page

Jira
https://pegadigitalit.atlassian.net/browse/CC-1017
Summary
Added a test page to test out a table fix that will prevent the table from locking the column widths

@colbytcook @danielamorse
Can we use the attributes object and add there an inline style to make responsivness back?
{% include<EMAIL_ADDRESS>with {
  main: {
    content: main_content,
    attributes: {
      style: 'min-width: 0;'
    }
  }
} only %}

@MarcinMr @danielamorse thanks for the review but I am going to close this PR for now, we are going to explore another option.


Add test that checks that Python code respect pep8

Do not merge until the changes have ben applied to the Python source files and the new test passes.

Refer to this link for build results (access rights to CI server needed):
/job/Cap-experimental/9/

Refer to this link for build results (access rights to CI server needed):
/job/Cap-experimental/10/

Ready for review/merge


Missing dependency SSD1306

It seems like dependency for SSD1306 lib is missing. As per issue #12 i found out missing library might be "ESP8266_SSD1306".
Could you please add this to lib_deps in platformio.ini file?
As I only have an AITHINKER board I can't test if it is working, but it does compile properly.

Faced same thing.
I tried this:
platformio lib install 2978
and this worked for me

^ @rafaelrs comment above worked for me too!

Faced same thing.
I tried this: platformio lib install 2978 and this worked for me

谢谢，我的也是通过这个命令解决的


Can we use this for 2016 hacktoberfest?

@eddiejaoude there is the 2016 verifycation on #8 PR :)

Thanks 👍


How to apply style to main view?

Is there a way to apply style on the main view or is it impossible?
I am trying to do that:
<Markdown
  style={{
    marginVertical: 30,
    marginHorizontal: 10,
  }}
  {...rest}
/>

Solved with:
    <Markdown
      style={{
        body: {
          marginVertical: 30,
          marginHorizontal: 10,
        },
      }}
    >

Brillant, thanks a lot for this library it is awesome!


Example: Predition Intervals using Quantile Regression

Description
This PR adds an example livebook inspired by the one from scikit-learn:

https://scikit-learn.org/stable/auto_examples/ensemble/plot_gradient_boosting_quantile.html

It came out of a discussion on this issue:

https://github.com/acalejos/exgboost/issues/5

Notes
The livebook started as a fairly faithful adaption, but I ended up deviating in a number of ways:

I use a normal instead of a log-normal distribution to build the noise. I started to make my own log-normal implementation (Nx doesn't have one), but I found that it was too distracting.
I dropped the MSE-trained predictor. I found that it was too distracting as well since it was only used for comparison.
I put more emphasis on the coverage and width metrics. I also changed the hyper-parameter tuning to tune for both at the same time.
I added discussion sections at the end. They're not necessary, but it made the livebook feel more self-contained to me.

The section Discussion: Pinball error felt the most ad hoc. But since the original example relied so heavily on mean_pinball_loss, I felt like I should include it.
It was also a way to bring up the early stopping issue: I couldn't tell what metric EXGBoost was using for early stopping. It should use the pinball error, but I think it may have been using rmse since I couldn't set disable_default_eval_metric: false. Though again, I'm not sure.
Remarks
This it a fairly long example. If y'all think it's too long, I can cut it down.
Happy to take any other feedback as well!

Hey, thanks for the PR! I'll take a look tonight

Just took a look and ran it in Livebook and this is an awesome example @billylanchantin! Thanks so much for the contribution. Do you have a Twitter I can shout out in a tweet about this example?

@acalejos Glad you liked it! I'm a big fan of worked examples so I'm happy I could add one.
No sorry I'm not on Twitter, but the offer is very kind :)


Add GHOST_URL

Duplicate of https://github.com/docker-library/ghost/pull/78
Please see the discussion there (and in https://github.com/docker-library/ghost/issues/77) for more details about why this is unnecessary (and doesn't do what folks expect either).


Improve home page by adding catagories section

I like to add different categories section (electronics, toys, gifts, travels home and kitchen etc) in the home page as below.

@arghadipmanna101 Can you please assign this issue to me?

ok. go ahead @DharshiBalasubramaniyam .

I want to contribute too in this section under GSSOC'24 can you assign it to me please

I want to contribute to this section, please assign it to me

Assign me the issue please i am also working usnder GSSoc24

@arghadipmanna101  please assign me this issue , i can work on it under GSSOC'24


Is this module still maintained?

https://github.com/ImVexed/muon/issues/49

https://github.com/ImVexed/muon/issues/49


Patches on event handler

mostly renaming, to help my eyes, follow the logic and some minor refactoring to separate some logic

@julien-deramond @louismaximepiton does these changes make sense to you guys? 😷

@julien-deramond @louismaximepiton does these changes make sense to you guys? mask

I haven't tested the minor refactoring but the new naming allows a better understanding.
Especially for me:

getEvent → getElementEvents that highlights when you read it the fact that you get multiple events
delegation → isDelegated is more obvious as well
I know some developers don't like the fact to have a function used only one time but IMO hydrateObj makes the code more readable here

Regarding callable I don't know well this JS file so I don't have an opinion on this. I just like that it avoids having originalHandler + handler.

@julien-deramond @louismaximepiton does these changes make sense to you guys? 😷

I haven't tested too, but the changes seems good and understandable to me.
Regarding the hydrateObj function, I was wondering if this function could be in the utils file instead of a standalone one here ?

Regarding the hydrateObj function, I was wondering if this function could be in the utils file instead of a standalone one here ?

Thank you, I 'll keep it in mind, for later usage . For now, I didn't find any other place that needs this functionality


[BUG] Malicious behavior detection in CrowdStrike Falcon

Please confirm these before moving forward

[X] I have searched for my issue and have not found a work-in-progress/duplicate/resolved issue.
[X] I have tested that this issue has not been fixed in the latest (beta or stable) release.
[X] I have checked the FAQ section for solutions
[X] This issue is about a bug (if it is not, please use the correct template)

Describe your issue
After the latest 3.0 update, CrowdStrike Falcon detects malicious activity when attempting to run WingetUI.
The tactic detected is: Defense Evasion via Reflective Code Loading
CrowdStrike Falcon describes this as:
A suspicious .NET module was loaded into the process. Adversaries may load malicious .NET assemblies into a process in order to conceal the execution of malicious payloads. Investigate the process and surrounding events.
Steps to reproduce the issue
Allow autoupdate from 2.x to 3.0 on a system with CrowdStrike Falcon installed.
WingetUI Log
N/A

Package Managers Logs
N/A

Relevant information
Issue occurred directly after the 3.0 auto update.
Screenshots and videos

Yes, definitely a false-positive

Similar issue here with CrowdStrike. Previous version worked okay, but the update to v3.0.0 did not. It installs ok, but when launching WingetUI.exe it get killed by CS.
Deatils about the detection:
Severity: High
Objective: Keep Access
Tactic & technique: Defense Evasion via Reflective Code Loading
Technique ID: T1620
IOA Name: SuspiciousDotNetAssemblyLoad
IOA Description: A suspicious .NET module was loaded into the process. Adversaries may load malicious .NET assemblies into a process in order to conceal the execution of malicious payloads. Investigate the process and surrounding events.
Command Line: "C:\Program Files\WingetUI\WingetUI.exe" --daemon
https://www.virustotal.com/gui/file/6cb0d0a2aa417c25a321b71eea761f918637806aa389566d6e4a8cd6185ca32c/detection


Kong 0.5.2-1 not available with Luarocks

https://luarocks.org/modules/mashape/kong
Shows 0.5.0-1 as the latest version.

Added.


Fix split-debuginfo support detection

What does this PR try to resolve?
cargo assumed that if -Csplit-debuginfo=packed worked, all values would be correct. This however is not the case -- as of Rust 1.65.0, rustc supports packed, but not unpacked or off on Windows. Because of this, having split-debuginfo="unpacked" on Windows has caused builds to fail, as cargo assumed that the option is fine (split-debuginfo=packed worked), but rustc then failed when being passed -Csplit-debuginfo=unpacked.
How should we test and review this PR?
Consider an empty project with the following change to Cargo.toml:
[profile.dev]
split-debuginfo="unpacked"

cargo +1.64.0 build will work, but cargo +1.65.0 build will fail with the following error message:
PS C:\REDACTED> cargo build
   Compiling tmp v0.1.0 (C:\REDACTED)
error: `-Csplit-debuginfo=unpacked` is unstable on this platform

error: could not compile `tmp` due to previous error

With this patch and 1.65.0 rustc, cargo will ignore all split-debuginfo settings, but with https://github.com/rust-lang/rust/pull/104104 rustc (approved, awaiting merge), it will properly detect supported values for split-debuginfo and only ignore those that are unsupported.

Does that require any action from my side?

No. Not really. I guess we are required to wait for your rustc patch hitting stable (presumably 1.67). Only after that this pull request can be merged.

The patch was merged, so it's indeed on track to 1.67. One question about cargo release cycle -- if we get this PR merged after 1.67 is released, will that mean that the patched cargo will be released in 1.68?

The patch was merged, so it's indeed on track to 1.67. One question about cargo release cycle -- if we get this PR merged after 1.67 is released, will that mean that the patched cargo will be released in 1.68, or later?

Cargo, and several other official components, follow Rust's train release model. The release schedule is found here. That is, if we get this merged after 1.67 is released, it should hit stable channel on 1.69.

Just to be clear, will this be blocked until after Jan 26?
It's a bit unfortunate to still incur a second rustc invocation. I wonder if some day in the future we should consider adding some kind of query command to rustc that will print a json blob with all the information we need once.

Just to be clear, will this be blocked until after Jan 26?
It's a bit unfortunate to still incur a second rustc invocation. I wonder if some day in the future we should consider adding some kind of query command to rustc that will print a json blob with all the information we need once.

I feel like it can be merged into the other with some tricks. But yeah, it is blocked until the change of rustc get stabilized.

@weihanglo this patch should now work with stable Rust, can you re-run CI?

@bors try

:hourglass: Trying commit fe95630a4a28de8f0b7fdfd644e0d0d31d8d47e3 with merge 641a4e10cb2fb19f98a2bf82727c95792b519fee...

:boom: Test timed out

@bors r+
BTW, to optimize it a bit, we could explore a way merging multiple rustc calls into one.

:pushpin: Commit fe95630a4a28de8f0b7fdfd644e0d0d31d8d47e3 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit fe95630a4a28de8f0b7fdfd644e0d0d31d8d47e3 with merge c03cc598091e4cbe3f70e13a1a5ceee55a8fe267...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing c03cc598091e4cbe3f70e13a1a5ceee55a8fe267 to master...


+EJoshuaS to SOCVR

Since he is a regular in SOCVR and seemed to attempt to provide feedback, I offered him privileges.
https://chat.stackoverflow.com/transcript/message/41522202#41522202

Coverage remained the same at 65.093% when pulling 525ae4bcd07875e64a1b027c2cb338e15afa62d6 on tripleee:socvr-ejoshuas into 2689dd48f1239284c97605722074574eb3880318 on Charcoal-SE:master.

!!/approve


Tweaks not working

Hi there! I'm using your mod on 1.19 (VanillaTweaks-forge-1.19-1.5.59). Here is the list of which are not working among the tweaks you made:

When I right-click to replant and harvest (I have my seeds with me).
Falling tree.
Sit on slabs and stairs by right-clicking with an empty hand.
The placed signs cannot be edited (I right-clicked it with an empty hand) and the shift-right-click to clear the sign isn't working as well.
Mob Spawners don't drop themselves when you use silk touch.
Shift-right-click an armor stand to swap isn't working.
Hoe doesn't act as a sickle.

Thank you!!!

Sorry for late reply been busy.

Right click to replant and harvest isn't available in VanillaTweaks.
Falling tree also not available.
Sit on slabs and stairs is a features I have removed from VanillaTweaks some while ago. ( Use Sit mod )
You need to shift right click to edit signs.
I just tested and it seems to work. Make sure you have the config for the feature is enabled on config. If you can still reproduce create a new issue with exact reproduction step, mods  and possibly video of it.
Same as point 5.
Same as point 5.

You can find the updated list of features here


[libphonenumber] Updated libphonenumber to 8.13.4 and added features

Describe the pull request

What does your PR fix?

Updated to new version of libphonenumber which helps removes some technical debt from the port (by creating features for build_test and build_shared_libs).  Adds features for available options.

Which triplets are supported/not supported? Have you updated the CI baseline?

linux, No
osx, No
uwp, No (due to icu lib)
x64-windows, Yes
x86-windows, Yes
arm64-windows, Yes
x64-windows-static Yes
x64-windows-static-md Yes

Does your PR follow the maintainer guide?

Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

All features test pass on x64-windows and x86-windows.

Ping @trishvl for response. Could you please address the review suggestions and fix the conflicts? Thanks!

Ping @trishvl for response. Could you please address the review suggestions and fix the conflicts? Thanks!

Currently have little bandwidth to resolve the suggestions. Will get back to you when possible!

Convert this PR to draft since it has some problems need to resolve. Please ping us if this PR is ready for review again.

Closing this PR since it seems that no progress is being made. Please ping us to reopen if work is still being done.


feat(firebase_messaging): add support for RemoteMessage on web

Description
On cloud messaging web, one can optionally deliver fcmOptions (containing image link, analyticsLabel and link) to the client app, which has already been implemented for the most part. However, there was a missing link so that the info could be extracted from the RemoteMessage to, e.g., register the analytics event, navigate to the url or extract and display the image within the Flutter app. This is being added here.
Related Issues
Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (melos run analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[x] No, this is not a breaking change.

Thanks for the approval. However, I'm not entirely sure if it really works. The parsing should be correct, but the parsed values where still null when sending out a test message including fcmOptions. Maybe there's another part missing (maybe in js). 🤔


Autogen Studio cannot be installed anymore?

What happened?
With pip install autogen-studio
I am right now getting :
ERROR: Could not find a version that satisfies the requirement autogen-studio (from versions: none)
ERROR: No matching distribution found for autogen-studio
What did you expect to happen?
Installation proceeds
How can we reproduce it (as minimally and precisely as possible)?
Create a new environment
install the needed packages
activate the environment
type "pip install autogen-studio"
AutoGen version
current one
Which package was this bug in
Core
Model used
No response
Python version
No response
Operating system
No response
Any additional info you think would be helpful for fixing this bug
No response

My wrong, right command is:
pip install autogenstudio
and not "pip install autogen-studio"
Please remove this "bug" :P


Noqa coming up on docs

# noqa visible here

Good catch!

@tonykploomber wanna patch it?

ACK, will handle soon


shim: Start shims inside appropriate namespaces

This PR first creates a new package nsenter so that we can spawn any code into a set of namespaces. Then, the virtcontainers code is modified to rely on this new package. At last, it starts shims from agents within the right PID namespace. In details, a shim representing a container process should enter its own PID namespace so that we can spawn other shims corresponding to exec'ed processes inside the same namespace. This is needed if we don't want some race conditions to happen, due to the exec'ed shims to never return their exit codes if the container process returned first.
Fixes #613

@sboeuf Did some digging up on the issues filed surrounding the mount namespace issue when I was implementing support for devices. See this:
https://github.com/golang/go/issues/8676
Also, that issue has code that checks if the namespace change was successful, we could do something similar in our tests:
https://storage.googleapis.com/go-attachment/8676/0/checkns.c

@sboeuf Doing things the way you are doing currently works (most of the time) and provides for a simple solution (instead of reexecing a new process), but I came across this article which does state that it is not 100% foolproof : https://www.weave.works/blog/linux-namespaces-and-go-don-t-mix
Basically golang may spawn a new thread for a blocking syscall even after LockOsThread()
We have an issue in vishwanda/netlink repo related to the above:
https://github.com/vishvananda/netns/issues/17
The issue seems to have been resolved in golang 1.10, but we may see an unsuccessful setns call in earlier versions.
Doing things in the shim code, may not be such a bad approach after all.

@jodh-intel PR updated with almost full coverage for unit tests and more than that a real test that we're entering namespaces.
As @amshinde explained, we have some limitations with Go, even if this code is supposed to be foolproof.

About limitations, both mount and user namespaces cannot be entered with the Setns() syscall from a Go program because it's multithreaded. I honestly don't get the "why" of this limitation but after all I have read and my local testing, I can confirm we cannot enter those namespaces if we don't involve some C code, or the use of an external binary such as nsenter.
About being foolproof, I think this is safe since we know that we should not pass a callback involving a go routine through this package, otherwise it won't be executed in the expected namespace. Also, the second issue about having some new threads being created in case the current one takes too long should not happen in our case and will be solved with Go 1.10.

Basically, this package does the most that a Go package can do with netns. So my proposal is that we could take it in since it will help spawning our shims into expected PID and network namespaces, and worst case, it won't do any harm in case we hit the issues explained above once every<PHONE_NUMBER>0 times.
At least this whole PR brings the structure for the shims to be switched to the expected namespaces.
I think we should try to look into a better way to solve this, but this will involve more researches.

@sameo @jodh-intel @amshinde PR is ready for another review ;)

@amshinde PR updated, PTAL

@grahamwhaley @jodh-intel  ready to be merged


[SPARK-33931][INFRA][3.0] Recover GitHub Action build_and_test job

What changes were proposed in this pull request?
This is a backport of https://github.com/apache/spark/pull/30959 .
This PR aims to recover GitHub Action build_and_test job.
Why are the changes needed?
Currently, build_and_test job fails to start because of  the following in master/branch-3.1 at least.
r-lib/actions/setup-r@v1 is not allowed to be used in apache/spark.
Actions in this workflow must be: created by GitHub, verified in the GitHub Marketplace,
within a repository owned by apache or match the following:
adoptopenjdk/*, apache/*, gradle/wrapper-validation-action.

https://github.com/apache/spark/actions/runs/449826457

Does this PR introduce any user-facing change?
No. This is a test infra.
How was this patch tested?
To check GitHub Action build_and_test job on this PR.

Test build #133576 has started for PR 30986 at commit d7dd9fc.

Test build #133576 has finished for PR 30986 at commit d7dd9fc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133576/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38165/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38165/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38165/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38165/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38165/

Thank you. Merged to branch-3.0.

Thank you. Merged to branch-3.0.


Problem with SDL2.dll

Hello Eric, sorry I disturb that.

I already installed from Nuget but it shows nothing Veldrid-SDL2-Nativer.
What do I miss that or what do I wrong?

This is the same as https://github.com/mellinoe/veldrid/issues/19. Long story short, you need to use PackageReferences instead of the old packages.config to reference the Veldrid nuget packages. There are options in the Visual Studio UI somewhere to switch.

If you want to use a different SDL2 binary, then it needs to be in the same folder as the rest of your application. No guarantees that any random version of SDL2 will work, though -- Veldrid.SDL2 is only tested with the bundled native binaries on Windows.

Yeah I know how do I make with "working directory" like this:
Environment.CurrentDirectory = Path.Combine("x64");
It is like working directory for native dlls. Does it support same to other operating system? Like Linux and macOS?

Sorry, I'm not sure I understand what you're asking. The library loader doesn't really care what the current working directory is, so changing Environment.CurrentDirectory probably won't help. If you put SDL2.dll next to your application .dll, then the loader should be able to find it. On Linux/macOS, the library can also be anywhere on the dynamic load path (LD_LIBRARY_PATH).

Oh I am sorry for my bad English.
Yes it is correct for LD_LIBRARY_PATH - I know almost.
But my question with Mono MakeBundle ( mkbundle.exe )
I don't like to happen if net assembly exe into native executable and forgets to requierement of installation with net framework. mkbundle can generates as single executable with embedded mscorlib.dll from Mono's assemblies
I understand that. It is hard for net standard 2.0 :/
mkbundle --static --deps --keeptemp ConsoleApp1.exe -L "C:\Program Files\Mono\lib\mono\4.5" -L "C:\Program Files\Mono\lib\mono\4.7.1-api" -o "TestConsole.exe" -v -L "C:\Program Files (x86)\Xamarin\Workbooks\WorkbookApps\DotNetCore"
OS is: Windows
Sources: 1 Auto-dependencies: True
Attempting to load assembly: ConsoleApp1.exe
Assembly ConsoleApp1.exe loaded successfully.
 If you're not able to solve it, I'd try asking the mono folks if there are any known issues or workarounds needed.


Highlight semver2 packages on package details view

Client version to be confirmed.
Preview:

@joelverhagen the message I used here is verbatim message I received from @anangaur (except for the version number, that's to be verified I guess)


Update experimental mixed_sp_wrr_traffic_test.go to check TransmitOctets and DroppedOctets counters

QoS: Check TransmitOctets and DroppedOctets counters are updated in addition to TransmitPkts and DroppedPkts

TransmitPkts
TransmitOctets
DroppedPkts
DroppedOctets

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.081%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2069

💛  - Coveralls

Hi @sezhang2, @nraghavendran  this pr is a breaking change for us.

The counters should be supported per the test plan. What error did you get?


[bug] Upgrade to 6.0.0-alpha.3 broke HASS scene sensor states

Build/Run method

[x] Docker
[ ] PKG
[ ] Manually built (git clone - npm install - npm run build )

zwavejs2mqtt version: Working pre-a75c112ce6bb52d85f75829b36e5f8fce99899a2, broken since.
Describe the bug
After the zwave-js upgrade in a75c112ce6bb52d85f75829b36e5f8fce99899a2, the MQTT scene topics no longer contain the actual scene state, just the time, nodeName, and nodeLocation. For example, I have some HomeSeer HS-WD100+ switches that should set the 001 scene's state to 3 when the top paddle is double tapped. Prior to a75c112 that worked, but after the upgrade the entire state value is missing from the payload.
To Reproduce
Steps to reproduce the behavior:

Run a version of zwavejs2mqtt post-a75c112ce6bb52d85f75829b36e5f8fce99899a2.
In MQTT Explorer (or some other MQTT browser), pull up the central_scene/endpoint_0/scene/001 topic for your device.
Trigger that scene (for example, with a double tap on the HS-WD100+ switches).
In MQTT Explorer, you should see that the payload in that topic is missing the state value.

Expected behavior
The state value should be set in the scene's topic.

Thanks for reporting this. We’ve reproduced it on another switch.

Thanks for reporting this. We’ve reproduced it on another switch.

The cause of this is covered here:
https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v6?id=new-quotvalue-notificationquot-event
The new event handler that was added did not account for the value being sent in a different argument, and it also did not account for the shift of CCs like Central Scene from stateful to stateless.
I have implemented an interim solution here which sends the updated value in the 'state' field to MQTT so it is received by the sensor, which should match the old functionality.
IMO The correct fix is to stop using the state_changed event entirely and shift to a stateless event.
As implemented here, an automation that triggers on "state" will only be triggered the first time a Central Scene is pressed, i.e. if you tap the top of a Zooz ZEN26 scene switch twice, the scene002 sensor's state will be updated to 3. If you press the top of the switch twice again, the state is already 3, so it is not a state change.
Instead you have to use an event trigger.
Fix is in the below PR

The cause of this is covered here:
https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v6?id=new-quotvalue-notificationquot-event
The new event handler that was added did not account for the value being sent in a different argument, and it also did not account for the shift of CCs like Central Scene from stateful to stateless.
I have implemented an interim solution here which sends the updated value in the 'state' field to MQTT so it is received by the sensor, which should match the old functionality.
IMO The correct fix is to stop using the state_changed event entirely and shift to a stateless event.
As implemented here, an automation that triggers on "state" will only be triggered the first time a Central Scene is pressed, i.e. if you tap the top of a Zooz ZEN26 scene switch twice, the scene002 sensor's state will be updated to 3. If you press the top of the switch twice again, the state is already 3, so it is not a state change.
Instead you have to use an event trigger.
Fix is in the below PR

Thanks @jcam, I didn't saw the args have changed! Now it's on master.

Thanks @jcam, I didn't saw the args have changed! Now it's on master.

Thanks everyone for digging into this so quickly! @jcam, I hit exactly that issue you’re talking about. If you use a State trigger then it does show the behavior the you mentioned. You can work around it by setting up an Event trigger watching state_changed and add some conditionals to filter it down to the correct action. That works, but it’s pretty clunky to setup correctly. I’ll definitely check out that new event-based approach instead.

Thanks everyone for digging into this so quickly! @jcam, I hit exactly that issue you’re talking about. If you use a State trigger then it does show the behavior the you mentioned. You can work around it by setting up an Event trigger watching state_changed and add some conditionals to filter it down to the correct action. That works, but it’s pretty clunky to setup correctly. I’ll definitely check out that new event-based approach instead.


Fix exclude templates

Whoops, that's a silly typo on my behalf. Thanks for catching that!

I just realised that I'd made the same mistake in the Windows version of that script too. Both versions are now fixed in ue4-docker 0.0.34.


Changed $evm.create_notification log output

Changed log output to be included in the automation.log which is very important for debugging purposes.

@mkanoor Please review.

@tinaafitz is there a BZ for this?

@simaishi No, there isn't a BZ for this. Do you want me to create one?

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1410800

Euwe backport details:
$ git log -1
commit b3b97d3da9eefb404fdffcf56aa5f8c384e2074b
Author: Madhu Kanoor<EMAIL_ADDRESS>Date:   Wed Nov 9 17:40:00 2016 -0500

    Merge pull request #12544 from tinaafitz/notification_logging_change

    Changed $evm.create_notification log output
    (cherry picked from commit 520cebc89633bc9f9d84bd1e9bf519208776b6ec)

    https://bugzilla.redhat.com/show_bug.cgi?id=1410844


Add support for Presto's REGEXP_* functions

(Resolves #377)
Add support for the following REGEXP_* functions in Presto as shown in https://prestosql.io/docs/current/functions/regexp.html:

REGEXP_EXTRACT_ALL
REGEXP_EXTRACT
REGEXP_LIKE
REGEXP_REPLACE
REGEXP_SPLIT

Please note that the lambda expression used in one of the example at the website is not currently supported in VerdictDB.

That driver version is also very outdated, the project has also forked to
prestosql/presto where the majority of the updates are being done!
On Mon, 10 Jun. 2019, 06:12 Yongjoo Park<EMAIL_ADDRESS>wrote:

@pyongjoo requested changes on this pull request.
Thanks! I just left minor comment regarding pom.xml
In pom.xml
https://github.com/mozafari/verdictdb/pull/380#discussion_r291848751:

@@ -300,6 +300,14 @@

1.7

       <dependencies>

           <dependency>

               <groupId>com.facebook.presto</groupId>

               <artifactId>presto-jdbc</artifactId>

               <version>0.212</version>

               <!-- <scope>test</scope> -->

It looks like we have been including jdbc drivers only for the test phase.
Is there any difference for Presto?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mozafari/verdictdb/pull/380?email_source=notifications&email_token=AAIEBCUTJS5TDYVZEHHSYFTPZVP4HA5CNFSM4HWIHK3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB27TTHA#pullrequestreview-247413148,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIEBCUKNDD2OJUOA5OPJVLPZVP4HANCNFSM4HWIHK3A
.

I think we had an internal discussion of 'providing JDBC drivers' vs. 'letting users use their own JDBC' and IIRC, the test-only scope has been commented out as a result. It was commented out in this commit: https://github.com/mozafari/verdictdb/commit/ac65e2c9a6a9f44a135688b1fc97ad5e47553a73
I will update the JDBC version and restore the test scope for now.

After a little big of digging, it looks likes our PrestoJDBCConnection class requires PrestoStatement and QueryStats so that is actually why we removed 'test' scope previously.

Codecov Report

Merging #380 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #380     +/-   ##
=========================================
- Coverage   66.43%   66.33%   -0.1%
=========================================
  Files         169      169
  Lines       11635    11635
  Branches     1903     1903
=========================================
- Hits         7729     7717     -12
- Misses       3397     3410     +13
+ Partials      509      508      -1

Impacted Files
Coverage Δ

...org/verdictdb/connection/PrestoJdbcConnection.java
36.67% <ø> (ø)
:arrow_up:

...ain/java/org/verdictdb/sqlsyntax/PrestoSyntax.java
13.34% <100%> (ø)
:arrow_up:

.../core/scrambling/FastConvergeScramblingMethod.java
88.16% <0%> (-3.17%)
:arrow_down:

...va/org/verdictdb/coordinator/ExecutionContext.java
62.13% <0%> (-0.54%)
:arrow_down:

...verdictdb/core/querying/ola/InMemoryAggregate.java
84.79% <0%> (ø)
:arrow_up:

...a/org/verdictdb/jdbc41/VerdictStreamResultSet.java
9.19% <0%> (+0.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 095d0d0...85f7244. Read the comment docs.

I am merging this PR after updating the group id of presto-jdbc to io.prestosql (which should be more up-to-date).

Thanks!

Thanks for this!


audit action ignores lockfile

cc @Kixiron - the audit action just started failing in https://github.com/rust-lang/docs.rs/runs/2006983845?check_suite_focus=true, but it should have been failing a long time earlier: https://github.com/rust-lang/docs.rs/pull/1295.

Looks like https://github.com/actions-rs/audit-check/issues/163

Thanks, I'll close this in favor of the upstream issue then.


Allow addition and subtraction by 0 on lin. exprs. and variables

This is just a convenience feature, but I think it would be nice.
I was summing up a bunch of different expressions, but some of them only sometimes depending on some configuration settings. These might be None. To sum them, I did something like
S = sum(e for e in [a, b, c] if e is not None)

With this pull request, I can set each of the summands to 0 instead of None as needed, and the above line is just
S = sum([a, b, c])  # or: S = a + b + c

Great, thanks @koen-vg! Could you merge the latest master to trigger the CI?

Thanks again @koen-vg for the PR.
The feature is already covered by the latest changes, which allows adding numeric values to a linear expression. Please reopen or raise another issue, if you encounter problems


Improve readability of user input box when panel is narrow.

Issue
User text in the input field becomes difficult to read when the panel is narrow.

The narrower the panel the more pronounced the issue with text readability for the user input box.
Suggested Solution
A media container query breakpoint that switches to flex-direction: column; when narrow enough so the text field and buttons will be stacked rather than side by side.
Solution Mockup:

From a UX standpoint, this is a bug but from a technical standpoint it's a feature request. Just for the future which would be the more appropriate category for me to have selected?

This is fixed now, because the toolbar is below the input box. Closing as fixed.