dbt init command to create sample dbt-config.yml file in a directory

like how rails init works (kind of)

https://github.com/analyst-collective/dbt/pull/8

closing -- this will be handled by the docs


Manufacturer Data Map is empty in advertisements

Manufacturer Data map is empty in advertisements, probably because to discover manufacturer data in advertisements, we have to also pass optionalManufacturerData in request filters, as mentioned here

I have added optionalManufacturerData to the request options as well as an enum with all the registered manufacture's identifiers. (not yet released though)
Does this solve your problem?

@jeroen1602 thanks for the update, but am still not getting Manufacturer data in advertisements, not sure if am missing something,
am trying to pass manufacturer identifier for apple devices like this :
[ 0x004c], or also tried, 0x4C from BluetoothDefaultManufacturerIdentifiers
but still getting empty Maniufacturer data in device

Seems like manufacturer data related part is not stable yet, i tried this code in browser, and sometimes i got Manufacturer data, and sometimes not

console.log("Requesting Bluetooth Device...");
navigator.bluetooth
  .requestDevice({
    acceptAllDevices: true,
    optionalManufacturerData: [0x12d, 0x4c],
  })
  .then((device) => {
    console.log("> Requested " + device.name);

    device.addEventListener("advertisement received", (event) => {
      console.log("Advertisement received.");
      console.log("  Device Name: " + event.device.name);
      console.log("  Device ID: " + event.device.id);
      console.log("  RSSI: " + event.rssi);

      event.manufacturerData.forEach((valueDataView, key) => {
        const hexString = [...new Uint8Array(valueDataView.buffer)]
          .map((b) => b.toString(16).padStart(2, "0"))
          .join(" ");
        console.log(
          `ManufacturerData Data: ` + key + "\n    (Hex) " + hexString
        );
      });
    });

    console.log('Watching advertisements from "' + device.name + '"...');
    return device.watchAdvertisements();
  })
  .catch((error) => {
    console.log("Ahh! " + error);
  });

Are you trying to communicate with iBecaons? Because I noticed while testing that they are on the block list and will thus not show up/ work.

@jeroen1602 am trying on Chrome ( MacOS )
And ble devices are my earBuds, Android phone in peripheral mode using NRFConnect or Iphone as Ble devices
Everything works fine, except the manufacturer data is empty
Though its discovering fine in native plugins with these devices

I think I have fixed the problem
The conversion from a JS map to a dart map was bugged so it didn't add adything resulting in empty manufacture data.
I have fixed this now and will release a new version shortly!


Improve node expand/collapse via keyboard

Fixes issues with expand/collapse key stroke would also scroll grid!

Install back-pointer to Hoist Column from Ag column
Never shift cell focus after doing key-based expand/collapse
More selectively do key-based expand/collapse when showing cell focus

Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[x] Caught up with develop branch as of last change.
[x] Added CHANGELOG entry, or determined not required.
[x] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[x] Updated doc comments / prop-types, or determined not required.
[x] Reviewed and tested on Mobile, or determined not required.
[x] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

Looks good to me, and fixes the issue as well as improving keyboard nav generally when in cell focus mode. Will wait for @haynesjm42 to review before merging

Thanks Tom -- will merge and forward to Haynes so he is aware.

👍


Replication conditions

Hi, is there any possibilities for make conditions for accepting new entry?
For example
if(newEntry != true) {
return false
} ellse {
addNewEntry
}
The main idea is, if new entry has incorrect signature, then don't add entry to own copy of public db

if the db is public you can do something even better: Prevent tampering by fixing the entry. this won't work if your database is a EventStore but it should work in the case of all the others. you can do your checks in the replicated event: https://github.com/orbitdb/orbit-db/blob/master/API.md#replicated

checks in the replicated event

It's ok, but, how to prevent adding entry inside replicate event?
Can i break this entry? If yes how? And after that, will db continue replication?

Moving this to the Field Manual so we can go into more detail


Powershell Method

Documentation on the powershell way would be excellent.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d90bbf62-44f9-30a6-d6ea-bbf776f6efc5
Version Independent ID: b3961eac-6c70-b345-f48c-e4c0ec67059c
Content: Azure App Service IP Restrictions
Content Source: articles/app-service/app-service-ip-restrictions.md
Service: app-service-web
Product: unspecified
GitHub Login: @btardif
Microsoft Alias: byvinyal

@mferris2421 Thank you for your feedback! We have assigned this issue to the author to investigate further and take the right course of action.

@panchagnula as FYI

hey @mferris2421  we have a new version of the API for this coming out soon, that includes new functionality.
I'll make sure to include some PS examples as well when we refresh the docs

When will this be available ?

I wrote an Add-AzureIpRestrictionRule PowerShell cmdlet:
https://about-azure.com/2018/11/26/configure-azure-app-service-ip-restrictions-using-powershell/

It looks like this issue has been addressed, so I am closing this. Thanks!


[dev] Internal inconsistency in naming for presentation sharing service

The internal naming for the presentation sharing service is all over the place:

The URL for listing presentations is /presentations/
The URL pattern for a single presentation is /view/<meeting>/
The module is website.conferences. Views are called conference_view, conference_results, etc.
Templates are called meeting.mako, meeting_body.mako, etc.

Publicly, we use the term "Presentation Sharing Service", so it would makes sense to use the presentation namespace consistently.

Thanks @caneruguz for catching this a while back.

Perhaps the only changes to be made:

Change url pattern to /view/<conference>/
Change templates to conference.mako, conference_body.mako, etc.

That way, we establish the terminology:
presentation=a submission of a poster or presentation
conference=an event that used the Presentation Sharing Service

@saradbowman ... there have been some suggestions / discussions around this, maybe? Does this remain an issue?

@lbanner The poster service was recently rebranded as "OSF for meetings". The issue of the internal naming inconsistencies still stands.

related #2744 and @chennan47's PR

This is covered in https://github.com/CenterForOpenScience/osf.io/pull/2742

The pr has been merged.

The PR only changed the URL route to /meetings/. There are still inconsistencies (e.g. usage of "conference" in the views) to be addressed. Reopening.

@sloria does is mean to change all the "conference" in the backend code to meeting?

@chennan47 Yes, that would be an improvement.


Primitive Field Type Fields.email(name)

It'd be good to have a Primitive Field Type Fields.email(name)

@CreativeWolf like text field with email pattern validation?

@CreativeWolf like text field with email pattern validation?

Yes, that'd help :)

Yes, that'd help :)

@matteocng Firstly, Thank you for addressing this. Just  a request, I understand Angular's default validation has issues with pattern recognition - https://github.com/angular/angular.js/issues/5899 - Not sure if that's been changed now and I might be completely bringing up an unwarranted issue.
Just in case, if we are to use pattern, this seems to cover the bases:
return $compile('')(scope);
References:
https://github.com/angular/angular.js/issues/5899
http://www.w3resource.com/javascript/form/email-validation.php
Looking forward to your feedback.
Thanks!

@CreativeWolf nice point! Yep. As the issue requests we need some email validation. So we can start with client side validation as @CreativeWolf proposed. But I doubt solution with ng-pattern is user friendly in this context.

Thank you @CreativeWolf for bringing up the issue, I personally find [this] (/angular/angular.js/issues/5899#issuecomment-60141093) argument compelling as far as using the default, Chromium derived regex goes. Perhaps adding a layer of server side, non-pattern based validation could be a future evolution (e.g domain, mx, smtp, third party api).

Fair point indeed. However, in an environment to have some user control, it becomes essential. Of course, as far as there is an option to use ng-pattern or Chromium derived regex or a custom pattern on the fly in a framework like AllcountJS will be highly useful.

Interesting. @matteocng have you checked that native browser email validation works both in a form and in the grid? It could be a solution.

@paveltiunov as far as i know a form is needed to get the native UI validation behaviour (native tooltip with natively generated message). @CreativeWolf I agree that letting users add their own custom logic/pattern on top of AllcountJS default validation would be a very useful feature, albeit more complex to implement well. What would you think of a regex('...', 'Message') method in the context of [#4] (4#issuecomment-154178148)?

@matteocng just checked current behavior. It actually checks but in case email has wrong format it just doesn't save. It would be nice to notify user somehow that email has wrong format. Native tooltip doesn't appear for me.
How do you think?

@paveltiunov nice find, I've reproduced that behaviour. If you ran the app below, inserted 'a' in all six email, link and quantity fields and saved, the red error label 'Required' would just appear below the required() fields. Then, if you correctly filled in just the three required() fields, the save action would complete by saving 'null' in the DB for the three optional fields. As you correctly pointed out, it would be nice to 1) block the save action if invalid data was inserted in an optional field, showing an error label below it 2) change the 'Required' error label with a different message when the issue was a validation error; this change would affect both required and optional fields.
A.app({
  appName: "Validation behaviour",
  appIcon: "heart",
  menuItems: [
    {
      name: "Gifts",
      icon: "gift",
      entityTypeId: "Gift",
    }
  ],
  entities: function(Fields) {
    return {
      Gift: {
        title: 'Gifts',
        fields: {
          item: Fields.text("Item").required(),
          quantity: Fields.integer("Quantity"),
          quantity_required: Fields.integer("Quantity Required").required(),
          email: Fields.email("Email"),
          email_required: Fields.email("Email Required").required(),
          link: Fields.email("Link"),
          link_required: Fields.email("Link Required").required()
        }
      }
    }
  }
});

@matteocng Ah. I see. Nice workaround with required(). It might work for many situations. Do you think we need another issue for validation?

@paveltiunov Yes, moved to #91.

@matteocng Ok. Nice. Will close this one then.


MAPBOX_API_KEY  CONFIG Use a public access token (pk.) with Mapbox GL, not a secret access token (sk.)

I want to use deck.gl Scatterplot and set the MAPBOX_API_KEY   with "sk.eyJ1IjoieGFuaWN1IiwiYSI6ImNsMnp2aW9qbjFqaTYzaX********",

when i update the chart got a error info:

How should I solve it？

Hi @Lubyam You need to use public token instead of secret token, which is always prefixed with pk. Please refer to the url from the error message.

Hi @Lubyam You need to use public token instead of secret token, which is always prefixed with pk. Please refer to the url from the error message.

@stephenLYZ  thank you
Turns out I had it backwards all along


Update total-connect-client to 0.18 for Honeywell Lynx Touch-Wifi support

Description:
Bump library requirement for total_connect_client from 0.17 to 0.18 in order to support the Honeywell Lynx Touch-Wifi control panel.
Checklist:

[X] The code change is tested and works locally.
[X] Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

[X] New dependencies have been added to the REQUIREMENTS variable (example).
[X] New dependencies are only imported inside functions that use them (example).
[X] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

Hi @jwood55812,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!


The algorithm is broken.

The algorithm depends on a certain order being output from find.  find usually outputs in directory order, which is different on different file systems.  There is no guaranteed order to the output.

Hi @bvinc,
can you try again ?
Thanks.


example of shared component like navbar?

This runs great! I will be attempting to integrate a shared component myself now but thought I'd see if you already have some sample code for this. Thanks for the template!

If you really aim to share components across views, you could store them as global vars (yes i'ts ugly, and its the way I did in my first projects using this template). If you're using Svelte's Store, you could "register" them there since you're already referencing your store in all your views.
But I'm honestly in doubt if the Store solution is performatic. AFAIK Store was made to handle mostly strings and one-level deep values, so while that works as a workaround, perhaps is not the best approach for many shared components.
I'm open to elegant solutions for this problem. So if you manage to work on something in your project, please share in this issue!

To be more practical, here is what I did on some of my projects:
// src/main.js

import Routes from './routes';
import Topbar from './components/topbar.html';

function main () {
  window.Routes = new Routes();
  window.Topbar = new Topbar({
    target: document.body
  });
}

document.addEventListener('DOMContentLoaded', main);

This way the topbar would work independently from the routes and you could always access it via window.Topbar on other components.
But since we probably don't want to use global vars, a better approach would be:
// src/main.js

import { Store } from 'svelte/store';
import Routes from './routes';
import Topbar from './components/topbar.html';

const store = new Store({
  activeTopbarItem: 1
});

function main () {
  window.Routes = new Routes();
  window.Topbar = new Topbar({
    target: document.body,
    store
  });
}

document.addEventListener('DOMContentLoaded', main);

This way you would manage Topbar states purely from svelte/store in other components, changing it via store.set({ activeTopbarItem: ... }).

Hello! That's pretty close to what I did - here is my main,js
import Menu from './components/Menu.html';
import { Store } from 'svelte/store.js';

import Routes from './routes';
//import 'stylific/scss/stylific';

const store = new Store({
   snippets: []
});

document.addEventListener('DOMContentLoaded', main);

function main () {
  window.Routes = new Routes();

    const nav = new Nav({
        target: document.getElementById('nav'),
        store
    })

    const menu = new Menu({
      target: document.getElementById('menu'),
      store
    })

}
window.store = store; // useful for debugging!```

do you know how I can import whole scsss projects, like a style framework? Do I do that in main.js?

thanks again for the lovely template!

Yes. I generally import my base scss file directly into main.js, pretty much like you did in yours. I also use plugin called  rollup-plugin-scss.
This plugin generates another CSS file that you can then import in your index.html
Here is a full example:
// src/main.js

import Routes from './routes';

// Importing styles like this
import './styles/base.scss';

function main () {
  window.Routes = new Routes();
}

document.addEventListener('DOMContentLoaded', main);

And in the rollup.config.js:
import svelte from 'rollup-plugin-svelte';
import resolve from 'rollup-plugin-node-resolve';
import commonjs from 'rollup-plugin-commonjs';
import buble from 'rollup-plugin-buble';
import uglify from 'rollup-plugin-uglify';
import scss from 'rollup-plugin-scss';

const production = !process.env.ROLLUP_WATCH;

export default {
  input: 'src/main.js',
  output: {
    sourcemap: true,
    format: 'iife',
    name: 'app',
    file: 'public/bundle.js',
  },
  plugins: [
    // Here is where the magic happens,
    // this plugin generate another css file
    // that you can import into your index.html
    scss({
      output: 'public/bundle.css',
    }),
    svelte({
      dev: !production,
      css: (css) => {
        css.write('public/components.css');
      }
    }),

    resolve(),
    commonjs(),

    production && buble({ exclude: 'node_modules/**' }),
    production && uglify(),
  ],
};

awesome thanks! I'll post a link when my project is live :) Your implementation of roadtrip is really clean and easy to use - frankly easier for me right now than Sapper, which assumes you want a server version which I don't. Your watch for rollup works well too - although I do have to reclick the page (no live reload).

Glad you liked it! This starter kit was the closest I could get to a boilerplate that doesn't get in the way when developing. Happy to see others make use of it.
Also, just in case you fall into these issues too: I've experienced some quirks on Rollup when editing SASS files imported by the main .scss file. That means that whenever you edit a sass file which is not directly imported in main.js, you will have to go to your base scss file and save it again to trigger Rollup build.
Not exactly sure why this happens, but the last time I checked, it seemed like a limitation from Rollup itself: Basically it only listens to files imported in your main JavaScript entrypoint. Any other files that are not .js get ignored and don't trigger the build action.

hey i have another  issue with routing - when you navigate from the nav - which looks like this

if you do this from the index - all  is great - you get the route. If you are already IN the route, then you get the wrong url , for example
http://localhost:5100/topics/topics/map_filter_reduce
I've tried with and without the './' in front of the route

I generally use absolute paths, like that:
/topics/{cat.id}

Instead of:
./topics/{cat.id}

or
topics/{cat.id}

If you're interested, I also wrote a super simple component to handle links via  roadtrip.goto(), so you don't have to trigger full page reloads everytime you click a link. You can check it here.
The usage is like that:
<Link href="/path/to/my/route" cssClass="optional-css-classes">Blabla</Link>

muito obrigado Claudio 👍 faz muito tempo que nao falo, mais sei un pouco de Portugues!

De nada, Stacey! Fico feliz em poder ajudar. 😄


Mar '23 tour pages redesign

As part of an accessibility audit conducted into the admin application, the tour pages were raised as an improvement area. The following PR implements the new styling/asset changes to the tour, to make it more visually and functionally accessible.

Is there any particular reason we got rid of the <main> tag and replaced it with a <div>.? I would have thought this would decrease accessibility.

Consistency, and also styling. The main tag could be added across all of the tour pages and restyled accordingly, but the one that it was removed on was the exception (and it also broke the page layout). The others used divs.


MOE gate fixes and enhancements

Fixes the following issues:

Fix capacity when using TP for non-MoE by aligning the capacity to TP
Fix TopKGate.wg (gate weight) when using ZeRO with fp16 or bf16
Fix top2 aux loss to be similar to top1 aux loss

Following are few configurable enhancements:

Support top2 with disable token dropping
Support disable top2 2nd expert sampling

@mosheisland -- Thank you very much for working on this PR! Overall, it looks good to me but given that we don't have the bandwidth to test the convergence, it will really help us and users if you can do two things:

Protect any changes to l_aux, capacity padding, etc. with user-configurable flags and set their default values to be False.

e.g. add a flag like pad_capacity=False as a default and then only do this if pad_capacity=True is passed by the user. This is to avoid any regression as many users are using this in the current form. If we don't know if new code is going to give better results or previous code, at least, we should have the option to have new things disabled by default.

Share any before your changes and after your changes convergence plots for any model that you have trained with new changes. That data will help the users to refer back to this PR in case setting pad_capacity=True or using new l_aux value will change any training/loss-curves for them.

Protect any changes to l_aux, capacity padding, etc. with user-configurable flags and set their default values to be False.

e.g. add a flag like pad_capacity=False as a default and then only do this if pad_capacity=True is passed by the user. This is to avoid any regression as many users are using this in the current form. If we don't know if new code is going to give better results or previous code, at least, we should have the option to have new things disabled by default.

l_aux - I will revert this change.
capacity padding - this bug is reproduced when you use drop-tokens=False and non-expert-tp>1.
The padding itself is with 0-ed rows and has no real effect on training.

Share any before your changes and after your changes convergence plots for any model that you have trained with new changes. That data will help the users to refer back to this PR in case setting pad_capacity=True or using new l_aux value will change any training/loss-curves for them.

l_aux - no need, I will revert
capacity padding - I can't share before the fix since it crashes

Reverted l_aux commit


Add wasDerivedFrom clickable link to PartEditor

If a part is imported from SBOLStack/is iGEM part, add clickable link to a wasDerivedFrom field in the part editor.

If wasDerivedFrom is set, displays a clickable link.  Also made version and wasDerivedFrom optional PartEditDialog fields to reduce clutter.

Needs further testing.

This is great.  Works well.
Chris

On Oct 18, 2016, at 3:11 AM, Michael Zhang<EMAIL_ADDRESS>wrote:
Needs further testing.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/SynBioDex/SBOLDesigner/issues/79#issuecomment-254387176, or mute the thread https://github.com/notifications/unsubscribe-auth/ADWD90j6pGok_PpHzRE4ED3vmoccScaNks5q1Cq8gaJpZM4KXLew.


Traefik performs health check against root instead of configure…

What does this PR do?
Fixes #3417
Motivation
I want to use this change on my production environment.
More

[x] Added/updated tests
[ ] Added/updated documentation

Additional Notes
This is my first golang program.

Hi @shalugin,
Thanks for your interest in Traefik!
What does this PR solve that is it currently not being addressed by the health check configuration?

@jbdoumenjou I believe it fixes the bug reported in #3417

Hello @shalugin,
After looking deeper at your changes it seems that you are expecting the health check path to be the concatenation of the server URL path and the configured health check path (L84).
As explained in the Servers documentation, Paths in the servers' URL have no effect. and that's why the resulting health check path is not prefixed with the configured server URL path. Furthermore, introducing this change will be breaking.
According to this, we will decline and close your pull request.


Add multi-excitation support to driven solver

Enable looping over different excitations in the driven solver
Extend config file to allow integer specification of "excitation" in LumpedPort, WavePort or SurfaceCurrent
Add PortExcitationHelper to manage complex excitation patterns
Tweak github tests: compile MFEM to throw exceptions not abort; make timeout shorter

ToDos:

[ ] Fix paraview conventions
[ ] Update docs with new config changes
[ ] Update changelog
[ ] Add regression tests with multiple exciataions

Code lives on top of #302 — that should be merged into main first and this branch rebased.


Data is on GPU, some of the nn.Module still on CPU

🐛 Bug
A pytorch module consisting of a Python list containing multiple nn.Conv1d objects and 3 Fully-Connected layers are raising the following error:
RuntimeError: Input type (torch.cuda.FloatTensor) and weight type (torch.FloatTensor) should be the same
When trying to do a forward pass on the first nn.Conv1d contained in the Python List.
To Reproduce
Pytorch Module
class Conv1DClassifier(nn.Module):

    def __init__(self, num_classes):
        super(Conv1DClassifier, self).__init__()
        encoder_out_channels = 256
        encoder_kernel_size = 64
        encoder_stride = 64
        n_layers = int(math.log2(encoder_out_channels))
        self.conv_layers = []
        for layer_idx in range(n_layers):
            self.conv_layers.append(
                nn.Conv1d(
                    in_channels=2 ** layer_idx,
                    out_channels=2 ** (layer_idx + 1),
                    kernel_size=encoder_kernel_size,
                    stride=encoder_stride
                )
            )
        self.fc1 = nn.Linear(encoder_out_channels, 128)
        self.fc2 = nn.Linear(128, 64)
        self.fc3 = nn.Linear(64, num_classes)

    def forward(self, x):

        for conv_layer in self.conv_layers:
            # on the first pass, the error is raised here!
            x = conv_layer(x)
        x, _ = x.max(2)  # max pooling over the sequence dim; drop sequence axis
        x = F.relu(self.fc1(x))
        x = F.relu(self.fc2(x))
        x = self.fc3(x)
        return x

The Lightning Module i used it's just the Lit Module presented on the tutorial.
Steps to reproduce the behavior:

Try to do a forward pass on the presented pytorch module with GPU.
Watch the console log to notice that the data is in GPU but the (some of) model parameters are still on CPU.

I think it has something to do with the python list that contains the many convolutions layers that should be transfered to the GPU but it doesnt. As the CPU to GPU and vice-versa data transfers are handled by Lightning i think i can get help here.

Use ModuleList. It's pytorch specific.
Try:
model = Conv1DClassifier(num_classes=2)
print(model)

You won't see the conv layers in the model.

Just for further information i unwrapped the Python List in a series of nn.Conv1d objects and it worked so the issue has to be the Python List. I'll try @rohitgr7 solution in a minute.

It works. Thanks


Led Layout: Corner space

Feature request
On behalf of internal communication.
Add corner space to led layout configuration

What problem does this feature solve?
What does the proposed API look like?

Solution 1: 1:1 HyperCon copy
Solution 2: Array of led gaps
Solution 3: Corner distance in %

How should this be implemented in your opinion?
Are you willing to work on this yourself?

What problem does this feature solve?

Leds may not align correctly with the captured frame. Especially with many leds (big screen, beamer).

What does the proposed API look like?
How should this be implemented in your opinion?

Would prefer "Solution 2: Array of led gaps" or some variation.
Multiple "gap length" and "gap position" settings.

Are you willing to work on this yourself?

Not possible in the near future

I would highly prefer option 2 as well, given that I have a gap at both top corners, but not at both bottom corners.

@Lord-Grey Is this a dead feature request?  With the current implementation, the end led's for vertical and horizontal strips appear to overlay each other no matter what I try...


Client resilience needs fix

Problem:
The solution provided for #90 is not as elegant as thought:

For Uploads, it's not sufficient to call the HTTP POST again, the whole preparation needs to be repreated. See func newFileUploadRequestViaPipe
HTTP 4xx statuscodes should get no retries

ToDo
Fix above points

Implemented resilience on HTTP 503 when HTTP method is not POST.


CAMEL-19365: disabled UndertowHttpsSpringTest

Created CAMEL-19365 to track this, so it can be investigated in the future.


FIREBASE WARNING: Exception was thrown by user callback. TypeError: div.querySelector is not a function

Am using firebase 3.9.0
==> firebase version
3.9.0
After following the steps till step7 here
https://codelabs.developers.google.com/codelabs/firebase-web/#7
Running the code in web, I get the following errors
firebase.js:328 Uncaught TypeError: div.querySelector is not a function
Uncaught TypeError: div.querySelector is not a function
    at FriendlyChat.displayMessage

and the following warning
FIREBASE WARNING: Exception was thrown by user callback. TypeError: div.querySelector is not a function
when I try to type a message into the chat text field.
Full trace
FIREBASE WARNING: Exception was thrown by user callback. TypeError: div.setAttribute is not a function
at.displayMessage (http://localhost:5000/scripts/main.js:226:9)
at . (http://localhost:5000/scripts/main.js:62:10)
at https://www.gstatic.com/firebasejs/4.0.0/firebase.js:466:375
at fc (https://www.gstatic.com/firebasejs/4.0.0/firebase.js:328:165)
at bf (https://www.gstatic.com/firebasejs/4.0.0/firebase.js:393:215)
at cf (https://www.gstatic.com/firebasejs/4.0.0/firebase.js:392:403)
at Qg.g.Gb (https://www.gstatic.com/firebasejs/4.0.0/firebase.js:483:287)
at Ag.g.wd (https://www.gstatic.com/firebasejs/4.0.0/firebase.js:447:251)
at og.wd (https://www.gstatic.com/firebasejs/4.0.0/firebase.js:437:364)
at Yf.Xf (https://www.gstatic.com/firebasejs/4.0.0/firebase.js:435:281)
firebase.js:328 Uncaught TypeError: div.setAttribute is not a function
at.displayMessage (main.js:226)
at . (main.js:62)
at firebase.js:466
at fc (firebase.js:328)
at bf (firebase.js:393)
at cf (firebase.js:392)
at Qg.g.Gb (firebase.js:483)
at Ag.g.wd (firebase.js:447)
at og.wd (firebase.js:437)
at Yf.Xf (firebase.js:435)
FIREBASE WARNING: Exception was thrown by user callback. TypeError: div.setAttribute is not a function
at.displayMessage (http://localhost:5000/scripts/main.js:226:9)
at. (http://localhost:5000/scripts/main.js:62:10)
at https://www.gstatic.com/firebasejs/4.0.0/firebase.js:466:375
at fc (https://www.gstatic.com/firebasejs/4.0.0/firebase.js:328:165)
at bf (https://www.gstatic.com/firebasejs/4.0.0/firebase.js:393:215)
at cf (https://www.gstatic.com/firebasejs/4.0.0/firebase.js:392:403)
at Qg.g.Gb (https://www.gstatic.com/firebasejs/4.0.0/firebase.js:483:287)
at Ag.g.wd (https://www.gstatic.com/firebasejs/4.0.0/firebase.js:447:251)
at og.wd (https://www.gstatic.com/firebasejs/4.0.0/firebase.js:437:364)
at Yf.Xf (https://www.gstatic.com/firebasejs/4.0.0/firebase.js:435:281)
Uncaught TypeError: div.setAttribute is not a function
at.displayMessage (main.js:226)
at. (main.js:62)
at firebase.js:466
at fc (firebase.js:328)
at bf (firebase.js:393)
at cf (firebase.js:392)
at Qg.g.Gb (firebase.js:483)
at Ag.g.wd (firebase.js:447)
at og.wd (firebase.js:437)
at Yf.Xf (firebase.js:435)

Hey friend,
If you are using functions option provided by firebase then check the functions log.There you may find the root of this problem.I am not sure that this the main problem with it but I am getting the same problem. It happened after so many requests made to the server provided for function.
If you come to the solution please let me know too.
Thanks,
Aditya Rajput

@codesdk very strange. queryseletcor should be available in most browsers. can you make sure you were using a recent browser?

Closing for inactivity


PParamsUpdate in PlutusV3 TxInfo ScriptContext

Describe the feature you'd like
Current implementation of ParameterChange governance action does not include any PParamsUpdates, because we have not converged on concrete solution on how we want to translate PParamsUpdates.
https://github.com/input-output-hk/plutus/blob/78b710d275ec88ec237aba848836883fc5e94ce4/plutus-ledger-api/src/PlutusLedgerApi/V3/Contexts.hs#L300-L302
For reference, here is a full list of ConwayPParamsUpdate:
data ConwayPParamsUpdate = ConwayPParamsUpdate
  { minFeeA :: Maybe Coin
  , minFeeB :: Maybe Coin
  , maxBBSize :: Maybe Natural
  , maxTxSize :: Maybe Natural
  , maxBHSize :: Maybe Natural
  , keyDeposit :: Maybe Coin
  , poolDeposit :: Maybe Coin
  , eMax :: Maybe EpochNo
  , nOpt :: Maybe Natural
  , a0 :: Maybe NonNegativeInterval
  , rho :: Maybe UnitInterval
  , tau :: Maybe UnitInterval
  , minPoolCost :: Maybe Coin
  , coinsPerUTxOByte :: Maybe CoinPerByte
  , costModels :: Maybe CostModels
  , prices :: Maybe Prices
  , maxTxExUnits :: Maybe OrdExUnits
  , maxBlockExUnits :: Maybe OrdExUnits
  , maxValSize :: Maybe Natural
  , collateralPercentage :: Maybe Natural
  , maxCollateralInputs :: Maybe Natural
  , poolVotingThresholds :: Maybe PoolVotingThresholds
  , dRepVotingThresholds :: Maybe DRepVotingThresholds
  , minCommitteeSize :: Maybe Natural
  , committeeTermLimit :: Maybe Natural
  , govActionExpiration :: Maybe Natural
  , govActionDeposit :: Maybe Coin
  , dRepDeposit :: Maybe Coin
  , dRepActivity :: Maybe EpochNo
  }

data PoolVotingThresholds = PoolVotingThresholds
  { motionNoConfidence :: UnitInterval
  , committeeNormal :: UnitInterval
  , committeeNoConfidence :: UnitInterval
  , hardForkInitiation :: UnitInterval
  }
data DRepVotingThresholds = DRepVotingThresholds
  { motionNoConfidence :: UnitInterval
  , committeeNormal :: UnitInterval
  , committeeNoConfidence :: UnitInterval
  , updateToConstitution :: UnitInterval
  , hardForkInitiation :: UnitInterval
  , networkGroup :: UnitInterval
  , economicGroup :: UnitInterval
  , technicalGroup :: UnitInterval
  , govGroup :: UnitInterval
  , treasuryWithdrawal :: UnitInterval
  }

I can see two potential solutions:

Use poorly typed JSON like approach, where we have a PPValue like type and we represent PParamsUpdate as a Map String PPValue, where PPValue would have to enumerate all possible types for each PParam, eg. Integer, Rational, EpochNo, [PPValue], Map String PPValue, etc.

Downside of this approach are:

dynamic typing, thus less safety in code that will be written by Plutus users
performance. Map lookups aren't exactly cheap in Plutus. Plus the translation costs

Upside is

forward compatibility

Create a matching type for ConwayPParams in plutus context, like we do for all other types. It would look very close to how it is represented here in the ticket. Then we simply translate ConwayPParamsUpdate to the Plutus context

Cons and pros are inverted from previous solution.
Upsides are:

better type safety
better performance both on translation and during Plutus execution

Downside is:

For every era that adds or removes PParams, we will have to implement a new Plutus version. This is true in general for anything that goes into transaction. If anything is added to a transaction in a new era we do need a new Plutus version to accommodate those changes. So this might not be too big of a deal.

There might be other solutions that I didn't think of.
Describe alternatives you've considered
No response

dynamic typing, thus less safety in code that will be written by Plutus users

Also PPValue will not be fun to work with.

better performance both on translation and during Plutus execution

I guess you mean the translation step in the ledger? I think it might end up being a wash on the Plutus side, since in both cases we end up transferring things inefficiently through Data...

Downside [of the second approach] is:

The other downside is more type definitions and more Plutus Tx code for dealing with them. But I think it's not too bad and we should probably just accept it.

For every era that adds or removes PParams, we will have to implement a new Plutus version. This is true in general for anything that goes into transaction. If anything is added to a transaction in a new era we do need a new Plutus version to accommodate those changes. So this might not be too big of a deal.

This was my worry too, and I guess you've allayed it. It makes the coupling between a Plutus ledger language and a ledger era more obvious... but perhaps it was pretty tight in general.
For this to cost us, we'd have to have a situation where there was a new ledger era that a) had new protocol parameters, and b) didn't make us want to change the rest of the TxInfo. I can only see b) happening because:

There were no changes to the transaction format (pparams only?)
We didn't want to expose the transaction format changes to scripts

Both of which seem unusual. So yeah, I think this is probably fine.

A design question: are we okay with scripts only seeing the new protocol parameters, or are there reasons why they might want to see the old ones? I guess if you wanted to implement a policy like "parameter X cannot be raised by more than Y% in one proposal" then you would need something like that.
Of course, that would complicate things even more since a) we'd need to pass the old parameters too; or pass a list of deltas rather than just the new values, and b) we would need to include all the current protocol parameters in the pparamsHash, since script execution could depend on any of them.
Actually, if we took the approach of having the parameter update be a list of deltas, we might not need to do the pparamsHash thing. Then the deltas could state, for each individual parameter changed, what it goes from and what it goes to, and it could be a phase 1 failure if the source value is not what was stated. Then that pins down the values enough.

A design question: are we okay with scripts only seeing the new protocol parameters, or are there reasons why they might want to see the old ones?

I don't know. I brought up this question as well. We could actually solve it easily, since ParameterChange governance action must include previous governance action id for the last action that changed PParams. So we could easily keep it around in the ledger state and pass it to plutus. It is guaranteed to be the same as the on on chain, since we do validate previous governance action id as phase1 validation.
So, in a sense we could do this for all governance action that are required to have previous govenance action id. This way plutus script could always figure out the delta.

#5481
Updated
data GovernanceAction
    = ParameterChange` GovernanceActionId
    | <...>

to
data GovernanceAction
    = ParameterChange (Haskell.Maybe GovernanceActionId) ChangedParameters
    | <...>

where
newtype ChangedParameters = ChangedParameters {getChangedParameters :: PlutusTx.BuiltinData}

I.e. we chose the dynamic typing approach, if I understood it correctly.
Hence I'm closing the issue as resolved.


Add taskCountErrorLabel

When adding more than one task, the formCountErrorLabel is shown. I've added a taskCountErrorLabel so that the wording refers to tasks rather than screens.

Thank you Conor. :)


[SPARK-9536] [SPARK-9537] [SPARK-9538] [ML] [PySpark] ml.classification support raw and probability prediction for PySpark

Make the following ml.classification class support raw and probability prediction for PySpark:
NaiveBayesModel
DecisionTreeClassifierModel
LogisticRegressionModel

Merged build triggered.

Merged build started.

Test build #39425 has started for   PR 7866 at commit 2934dab.

Test build #39425 has finished for   PR 7866 at commit 2934dab.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class NaiveBayes(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol, HasProbabilityCol,

Merged build finished. Test PASSed.

This LGTM.  Thank you!
Merging with master.


Need update when files are linking to study

Right now there is no way to know if this is happening or if you need to restart, find out if there is a problem

@josenavas, I think this was solved, right?

Correct


Fix HTTPS port bug when configured via the 'PEP_PROXY_HTTPS_PORT' environment variable

Proposed changes
If HTTPS is enabled, the HTTPS port is not working in Docker when it's configured via the environment variable PEP_PROXY_HTTPS_PORT. For that reason, the PEP Proxy sets the port to the default 443 value, and throws an error:
pep wilma ERROR: Server - Caught exception: Error: listen EACCES: permission denied <IP_ADDRESS>:443
Related to issue #112
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA

recheckcla

recheckcla

Thank you for your contribution! Merged!


Add fallback information to font-data of newer webfonts

From https://github.com/mathjax/MathJax-node/issues/78: the fontdata for all the web fonts (other than the default TeX font) is missing fallback information.
The data about where to look for characters in a given font does not include the fallback to the main fonts if the character isn't in the given font.
E.g., https://github.com/mathjax/MathJax/blob/master/unpacked/jax/output/SVG/fonts/STIX-Web/fontdata.js#L181 should read
fonts: [SANSSERIF,MAIN,MONOSPACE,LATIN,ALPHABETS,MARKS,
        ARROWS,OPERATORS,SYMBOLS,SHAPES,MISC,VARIANTS,SIZE1],

And similarly for other variants.

This looks like it should be a relatively simple fix that's just waiting for someone to get around to it, or am I missing something?
If so I'd be happy to mint a PR for this, we keep hitting this issue and I'd like to address it.

I actually had hoped to implement a more general fallback mechanism (that would automatically cause variants to fall back to appropriate other variants) so that the data files don't have to include the fallbacks explicitly.  Needless to say, this hasn't yet been done, and may not get done until version 3.

Yes, lookupChar is the right place.  The CommonHTML jax actually does implement the variant chaining that I had in mind.
Is this for mathjax-node (server side MathJax), or MathJax in the browser?

Thanks, I'll take a look.
We're using it in mathjax-node, but as far as I can tell the relevant changes are all in MathJax, no?

the relevant changes are all in MathJax, no?

Yes, but I have a simple patch that should handle the majority of situations for you, and the way it is delivered depends on which form you are using.  I'm not able to write it up today, but should be able to do so tomorrow.

OK, here is the patch.  If you are using bin/tex2svg, replace the mjAPI.config() call (line 71) with the following:
mjAPI.config({
  MathJax: {
    SVG: {
      font: argv.font,
      Augment: {
        initSVG: function (math,span) {
          if (this.config.font !== "TeX") {
            this.Augment({
              lookupChar_old: this.lookupChar,
              lookupChar: function (variant,n) {
                do {
                  var char = this.lookupChar_old(variant,n);
                  if (char.id !== "unknown") return char;
                  variant = VARIANT[variant.chain];
                } while (variant);
                return char;
              }
            });
            var VARIANT = this.FONTDATA.VARIANT;
            VARIANT["bold"].chain = "normal";
            VARIANT["italic"].chain = "normal";
            VARIANT["bold-italic"].chain = "bold";
            VARIANT["double-struck"].chain = "normal";
            VARIANT["fraktur"].chain = "normal";
            VARIANT["bold-fraktur"].chain = "bold";
            VARIANT["script"].chain = "normal";
            VARIANT["bold-script"].chain = "bold";
            VARIANT["sans-serif"].chain = "normal";
            VARIANT["bold-sans-serif"].chain = "bold";
            VARIANT["sans-serif-italic"].chain = "italic";
            VARIANT["sans-serif-bold-italic"].chain = "bold-italic";
            VARIANT["monospace"].chain = "normal";
            VARIANT["-tex-caligraphic"].chain = "normal";
            VARIANT["-tex-oldstyle"].chain = "normal";
            VARIANT["-tex-caligraphic-bold"].chain = "bold";
            VARIANT["-tex-oldstyle-bold"].chain = "bold";
          }
          this.initSVG = function (math,span) {}
        }
      }
    }
  },
  extensions: argv.extensions
});

This will cause the lookupChar() function to be modified to handle chaining of variants, and also add the data to the variants that indicates how they are to be chained.  If you are using one of the other tools in bin, or if you are using your own program to call the MathJax API, you would need to make similar changes.  This prevents you having to change MathJax itself, or the main mathjax-node libraries.
For anyone using svg output in the browser, you can add
<script type="text/x-mathjax-config">
MathJax.Hub.Config({
  SVG: {font: "STIX-Web"}
});
MathJax.Hub.Register.StartupHook("SVG Jax Ready",function () {
  var SVG = MathJax.OutputJax.SVG,
      VARIANT = SVG.FONTDATA.VARIANT;
  SVG.Augment({
    lookupChar_old: SVG.lookupChar,
    lookupChar: function (variant,n) {
      do {
        var char = this.lookupChar_old(variant,n);
        if (char.id !== "unknown") return char;
        variant = VARIANT[variant.chain];
      } while (variant);
      return char;
    }
  });
  VARIANT["bold"].chain = "normal";
  VARIANT["italic"].chain = "normal";
  VARIANT["bold-italic"].chain = "bold";
  VARIANT["double-struck"].chain = "normal";
  VARIANT["fraktur"].chain = "normal";
  VARIANT["bold-fraktur"].chain = "bold";
  VARIANT["script"].chain = "normal";
  VARIANT["bold-script"].chain = "bold";
  VARIANT["sans-serif"].chain = "normal";
  VARIANT["bold-sans-serif"].chain = "bold";
  VARIANT["sans-serif-italic"].chain = "italic";
  VARIANT["sans-serif-bold-italic"].chain = "bold-italic";
  VARIANT["monospace"].chain = "normal";
  VARIANT["-tex-caligraphic"].chain = "normal";
  VARIANT["-tex-oldstyle"].chain = "normal";
  VARIANT["-tex-caligraphic-bold"].chain = "bold";
  VARIANT["-tex-oldstyle-bold"].chain = "bold";
});
</script>

to your page just before the script that loads MathJax.js itself to get the corresponding change.

This works like a charm, thank you very much, awesome support.


JSON deserializer only sees part of object

From IRC:

<@ekleog> (as this was pushed far up the backlog, trying again) Hi! I'm discovering serde, and am hitting a weird issue: the JSON deserializer seems to go through only a part of the json object: http://xelpaste.org/AcA6xy only goes through the "policy" element of the object defined at line 118 (http://xelpaste.org/AcA6xy#L118), would you have any idea why this is happening?

Looks like there are two things wrong: your FilterVisitor::visit_map is missing v.end() and your JSON is invalid (trailing comma inside "filters").
The end() functions are confusing, easy to get wrong, and give bad error messages. I hope to get rid of them in the next release: https://github.com/serde-rs/serde/issues/656.

To explain why this went wrong in the way that it did: the v.end() call in FilterVisitor::visit_map is in charge of processing the closing curly brace after "then": "allow". Since the call wasn't there, the curly brace wasn't processed as part of Filter. Instead it was processed as part of Config, ending the deserialization before getting to the filters key.

Great, thanks! (not having opened this I can't close it, but problem solved, thanks!)


Validation issue

Laravel Version: 5.4
PHP Version: 7.1

Description:
On the documentation page: https://laravel.com/docs/5.4/validation "Implicit Extensions" section, the code as displayed does not run.
Steps To Reproduce:
Validator::make(['name' => null], ['name' => 'unique'])->passes();

Should return true, but it instead throws an error:
InvalidArgumentException with message 'Validation rule unique requires at least 1 parameters.'

@themsaid This stems on from a discussion on the #internals channel.
In Lumen 5.2, a rule such as ['id' => 'integer|positive'] would be fine being passed null. In Laravel 5.4, it no longer passes the validation.
The conclusion there was that this change was made intentionally, but my understanding of Implicit Extensions, would be that some types of rules allow nullable implicitly.
Can I get some clarification on how this is supposed to work, and which rules are implicitly allowed?

The rules run if:

Field is present
Field is null and doesn't have a nullable modifier
Rule is implicit

So the example in the docs is wrong and needs to be updated, the Validator only skips empty strings `` but null is considered.

Okay, great. If its intentional, and just a broken doc example, i'm happy for this to close.


net: Unable to reliably distinguish IPv4-mapped-IPv6 addresses from regular IPv4 addresses

What version of Go are you using (go version)?

$ go version
go version go1.13.8 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="off"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/alouis/Library/Caches/go-build"
GOENV="/Users/alouis/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/alouis/Documents/go_playground"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/gf/xt8nljp959z9gyd_qdvr68gc0000gp/T/go-build940989106=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
https://play.golang.org/p/gGY8VPwVm2J
What did you expect to see?
Some way to parse an IPv4 mapped IPv6 address (e.g. 0:0:0:0:0:ffff:ac15:0006 or ::ffff:<IP_ADDRESS>) and know that it is an IPv4 mapped IPv6 address.
The net package is bit prohibitive here, given that the ParseIP method is pretty opinionated. See here:
ip := net.ParseIP("::ffff:ac15:0006") //  -> <IP_ADDRESS> (the ip4 equivalent of ac15:0006)

len(ip) // -> 16, this is because internally, all IPs seem to be 16 byte net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xff, 0xff, 0xac, 0x15, 0x0, 0x6}

What did you see instead?
For any given IPv4-mapped-IPv6 address IP, all the IP parsing in the net package only indicate that the input is an IPv4 address.
This is also perhaps, further complicated by the internal representation of IPv4 addresses being 16 bytes, bearing the ::ffff prefix internally.
However, if the user is using the net package for IP sanitization/validation, not being able to tell the difference seems to be a shortcoming. In order to be implement this on my own, I had to copy/paste the parseIPv6 method from the net package, and do something like the following:
func isIPv4MappedIPv6Address(in string) bool {
	in = strings.Split(in, "/")[0]

	ip := parseIPv6(in)
	if ip == nil {
		// not an ipv6 address
		return false
	}

	if ip.To4() == nil {
		// couldn't map our ip6 to an ip4
		return false
	}

	return true
}

I would propose here to expose the parseIPv6 and parseIPv6 methods. Exposing the Parse helpers would help multiple use-cases I'm sure, without increasing the API footprint significantly of the net package

For more parsing fun related to IPv4-mapped-IPv6 addresses, here's another instance where things look weird: https://play.golang.org/p/lsVp472VG4E
	ip, network, _ := net.ParseCIDR("::ffff:ac15:0006/32")
	fmt.Printf("ip: %v\n", ip) // ip: <IP_ADDRESS>
	fmt.Printf("network: %v\n", network) // network: ::/32

Since ip at this point is the 16 byte form, it does have the prefix, but then again any other IPv4 address would have as we see. However, we get an IPv6 network, which will leave the onus on the user to make sense of this result.

cc @toothrot @mikioh @bradfitz @ianlancetaylor
This one seems to have fallen between the cracks and hasn't been triaged yet, tagging you folks for visibility.

I wouldn't say it fell through the cracks! Sometimes it takes us more than a couple days to triage issues when we're doing things like releasing Go 1.14.1!

Would it be more accurate to do something like the guard close in To4()? https://github.com/golang/go/blob/20a838ab94178c55bc4dc23ddc332fce8545a493/src/net/ip.go#L189-L200

Hey @toothrot! Sorry for the late reply here :)
Unfortunately, this will not work. Since under the hood, whenever you call ParseIP on anything, we always end up with a 16 byte representation. If it is an IPv4 address, the first 8 bytes of the IP type result is still 0xffff!
Here's an example: https://play.golang.org/p/GlBb81pAPIB
You can see there, that even though we have an IPv4 string, the internal representation is still 16 bytes - and then the reason we still get a non-nil result there from the To4() is because we wind up in this condition: https://github.com/golang/go/blob/20a838ab94178c55bc4dc23ddc332fce8545a493/src/net/ip.go#L193-L198
Does that makes sense? And now we wind up in a situation again where we can't distinguish after parsing whether we were given <IP_ADDRESS> or ::ffff:<IP_ADDRESS>

@andrewlouis93, I've addressed this issue in https://godoc.org/inet.af/netaddr (https://github.com/inetaf/netaddr). Perhaps that'll work for you in the meantime?

Just had a look at this, I think this will work great. Looking forward to seeing that package evolve, thanks @bradfitz!


Move randomness from pipeline name to pipeline version

Instead of adding random 5 characters to the pipeline's name:
https://github.com/kubeflow-kale/kale/blob/c8e21040af668c5c91dbea7913c4e79f544c6669/backend/kale/command_line.py#L109
add them to the pipeline's version like
https://www.kubeflow.org/docs/pipelines/tutorials/sdk-examples/#creating-a-pipeline-and-a-pipeline-version-using-the-sdk
Otherwise, kale, with each compile & run, generates a new "single-version" lineage of pipelines and clutters the pipeline overview with single pipeline

Hello @AdrianLsk,
we plan on moving towards pipeline versions at some point, indeed.
But we can't do that until Kubeflow releases ship with a bug-free KFP version (see kubeflow/manifests#984 for some bugs in the current release).
Your suggestion sounds pretty nice, thank you for that! When that time comes, we will iterate on it.
If you don't mind, let's have this issue open until we take care of it.


Add docker-compose file

Is your feature request related to a problem? Please describe.
Add docker and docker-compose file
Describe the solution you'd like
Add docker and docker-compose file
Describe alternatives you've considered
Add docker and docker-compose file
Additional context
No response

I would like to contribute on this. 😃

@bhavik2936 okk

@bhavik2936 create a pr within tomorrow

Hi @ashavijit, Thanks to ping. So that I would like to inform all open-source contributors (including you) looking this issue to contribute on.
As I am taking this issue as open source contribution rather than currently ongoing hacktoberfest. So I would like to work on this issue at my pace (for production compatibility). Hence contributors who would like to apply their knowledge to grab this opportunity and count it towards hacktoberfest contribution, Should take the opportunity first. 😄

@bhavik2936 that's okay


Tree drag and drop API proposal should support dragging into the editor

The tree drag and drop proposal allows extensions to provide data transfer items when a tree item is dragged, but the only way to drag into the editor is to attach a resource to the tree item.
Attaching a resource to a tree items means that the tree item will receive resource related display characteristics (decorations colors for example). This is not always desirable.
In the existing handleDrag API proposal, we should allow extensions to provide a resourceurls mime type that the editor then knows how to handle when the tree item is dropped there. This resourceurls type is already used internally.

Closed by https://github.com/microsoft/vscode/pull/140709

Whoops can't test yet. Well not on insiders.

/verified with vscode-oss


Dashboard Service Account Role

Is this a request for help?: No

Is this an ISSUE or FEATURE REQUEST? (choose one): ISSUE

What version of acs-engine?: v0.13.0

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
K8S v1.9.3
What happened:
dashboard service account running in cluster-admin role by default.
https://github.com/Azure/acs-engine/blob/afbf71b97cb7e14518d67708f79efa757c32bcbb/parts/k8s/addons/kubernetesmasteraddons-kubernetes-dashboard-deployment.yaml
What you expected to happen:
"As of release 1.7 Dashboard no longer has full admin privileges granted by default" https://github.com/kubernetes/dashboard/wiki/Access-control
How to reproduce it (as minimally and precisely as possible):
https://github.com/Azure/acs-engine/blob/master/docs/kubernetes/deploy.md
Anything else we need to know:
on the dashboard login screen clicking the "Skip" button correctly lets an unauthenticated user use the dashboard under the privileges of the dashboard SA. by default this would effectively be read-only view but because the SA is privileged as admin so is their access. currently no need for users to auth to their potentially lower privileges when they can just skip to admin.

This was identified during a security review we did recently. As a workaround, we are proposing disabling the addon when we run ACS-Engine against the apimodel.json and writing our own dashboard manifest using the least privileges necessary. It will have to be deployed manually or via a CI/CD pipeline.
We'll be using the ACS-Engine's example at parts/k8s/addons/kubernetesmasteraddons-kubernetes-dashboard-deployment.yaml but modifying it per our requirements.


Revert to previous verion until ready to release

Due to the way we build rpms for the monitoring container,
these changes had to be merged to prod before a stage container could be built.
Now it needs to be reverted back to the previous state, so that the staged changes
aren't accidentally pushed to prod by another monitoring container build.
This places the app-create script at commit # 0e983f9fcfe9b40996c84e6ee975b52739ee4a11.

Approved in PR #4253


Attribute 'program' does not exist.

Trying to debug a test pops the following alert on vs code. I have been using this feature before, somehow its broken now.
Attribute 'program' does not exist.('/path/to/bin/jest')
Run jest option works fine, Debug jest pops the above alert.

hey @loisgomez
i just tried to reproduce on my linux machine with:
VSCode Version: 1.44.2
Commit: ff915844119ce9485abfe8aa9076ec76b5300ddd
Date: 2020-04-16T17:50:03.709Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.5.16-1-MANJARO

was not able to reproduce your issue.
where you abel to resolve you issue? or could you provide more information on your setup? (os,vscode version)
also do you have any jest-runner settings defined?

Thanks for your time reviewing this.
Turns out I had jest missconfigured somehow.
Will close this, since its no longer valid.


DropDownMenu problem in 2022.3.0

Please fix it.

I have the same issue after update on 2022.3.0.  Waiting for fix

Issue fixed in the recentrly released 0.8.3 version.
Please update the card and get back to me with results.

Issue fixed in the recentrly released 0.8.3 version.
Please update the card and get back to me with results.

a drop-down list appeared, but I see 2 problems: 1. it goes from the bottom, the card has become wider, before the list fit on the side;  2. when the list is opened, it flies up to other cards.  Both problems are shown in the screenshots.  Thanks.

Just updated to the most recent version, but I'm still having the same issue.  Tried refreshing page, clearing cache and even changing the theme but it's still there.  Did I miss something?

a drop-down list appeared, but I see 2 problems: 1. it goes from the bottom, the card has become wider, before the list fit on the side; 2. when the list is opened, it flies up to other cards. Both problems are shown in the screenshots. Thanks.

UPD: Add. It's good work on my PC Desktop! But bad in home assistant mobile app for Android.

Checking on the Android companion app (plain Android 10/Android One) it shows just fine:

As a test try to put the card on test view and see if it works there as expected? There are some custom cards that include other cards might break the rendering of the included cards.

В качестве теста попробуйте поставить карту на тестовый просмотр и посмотреть, работает ли она там как положено? Есть некоторые пользовательские карты, которые включают в себя другие карты, которые могут нарушить рендеринг включенных карт.

Really.  The problem goes away if you put the card at the very last in the list.  Anywhere else the list jumps up like in my screenshots.  Is there nothing that can be done?  I do not observe such a problem with other cards on the same screen.

Can you please let me know in what card was the transmission card included (some stack, conditional, etc.)?

Can you please let me know in what card was the transmission card included (some stack, conditional, etc.)?

no, no special settings.  The cards just go in the list one after another.


feature: demo page for NTAG 213/215/216

https://www.nxp.com/docs/en/data-sheet/NTAG213_215_216.pdf

NTAG213 EEPROM: 180 bytes, organized in 45 pages of 4 byte per page.

26 bytes reserved for manufacturer and configuration data
34 bits used for the read-only locking mechanism
4 bytes available as capability container
144 bytes user programmable read/write memory

NTAG215 EEPROM: 540 bytes, organized in 135 pages of 4 byte per page.

26 bytes reserved for manufacturer and configuration data
28 bits used for the read-only locking mechanism
4 bytes available as capability container
504 bytes user programmable read/write memory

NTAG216 EEPROM: 924 bytes, organized in 231 pages of 4 byte per page.

26 bytes reserved for manufacturer and configuration data
37 bits used for the read-only locking mechanism
4 bytes available as capability container
888 bytes user programmable read/write memory


fix(rules): proper migration of let

Fix #8
Probably @bowenni is the best person to review this.

To be clear, this should take
source$.let(fn).map(fn2).subscribe();

and output:
source$.pipe(fn, map(fn2)).subscribe();


why cannot obtain right pb file by save.py and the create_pb.py?

I can obtain the pb file by save.py and the create_pb.py with the model.ckpt-240000 (downloading).
But, I can not get the right prediction results by try_detector.ipynb and face_detector.py with the pb file.
However, I can get the right prediction results with the model-step-240000.pb (downloading).
So, when obtain the pb file  by save.py and the create_pb.py,  any tricks or special operations need to  be paid attention to?
Thanks!

Hi. It is weird.
Here is how I do it:

Place downloaded checkpoint into models/run00/.
Run rm export/ -rf; python save.py.
Run python create_pb.py -s export/run00/SOMENUMBER/
The result is model.pb. Use it.

I get similar issue if additional checkpoint file mentioned by @azmathmoosa is not specified using tensorflow 1.12.0. , looks like it related to tensorflow version, with which tensorflow version master should to work?
INFO:tensorflow:Using config: {'_model_dir': 'models/run00', '_tf_random_seed': None, '_save_summary_steps': 100, '_save_checkpoints_steps': None, '_save_checkpoints_secs': 600, '_session_config': gpu_options {
  visible_device_list: "0"
}
, '_keep_checkpoint_max': 5, '_keep_checkpoint_every_n_hours': 10000, '_log_step_count_steps': 100, '_train_distribute': None, '_device_fn': None, '_protocol': None, '_eval_distribute': None, '_experimental_distribute': None, '_service': None, '_cluster_spec': <tensorflow.python.training.server_lib.ClusterSpec object at 0x12b0c7240>, '_task_type': 'worker', '_task_id': 0, '_global_id_in_cluster': 0, '_master': '', '_evaluation_master': '', '_is_chief': True, '_num_ps_replicas': 0, '_num_worker_replicas': 1}
Traceback (most recent call last):
  File "save.py", line 43, in <module>
    OUTPUT_FOLDER, serving_input_receiver_fn
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/estimator/estimator.py", line 663, in export_savedmodel
    mode=model_fn_lib.ModeKeys.PREDICT)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/estimator/estimator.py", line 789, in _export_saved_model_for_mode
    strip_default_attrs=strip_default_attrs)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/estimator/estimator.py", line 878, in _export_all_saved_models
    raise ValueError("Couldn't find trained model at %s." % self._model_dir)
ValueError: Couldn't find trained model at models/run00.

With fix I get output like:
python save.py

INFO:tensorflow:Using config: {'_model_dir': 'models/run00', '_tf_random_seed': None, '_save_summary_steps': 100, '_save_checkpoints_steps': None, '_save_checkpoints_secs': 600, '_session_config': gpu_options {
  visible_device_list: "0"
}
, '_keep_checkpoint_max': 5, '_keep_checkpoint_every_n_hours': 10000, '_log_step_count_steps': 100, '_train_distribute': None, '_device_fn': None, '_protocol': None, '_eval_distribute': None, '_experimental_distribute': None, '_service': None, '_cluster_spec': <tensorflow.python.training.server_lib.ClusterSpec object at 0x128c2e240>, '_task_type': 'worker', '_task_id': 0, '_global_id_in_cluster': 0, '_master': '', '_evaluation_master': '', '_is_chief': True, '_num_ps_replicas': 0, '_num_worker_replicas': 1}
INFO:tensorflow:Calling model_fn.
INFO:tensorflow:Done calling model_fn.
INFO:tensorflow:Signatures INCLUDED in export for Classify: None
INFO:tensorflow:Signatures INCLUDED in export for Regress: None
INFO:tensorflow:Signatures INCLUDED in export for Predict: ['outputs', 'serving_default']
INFO:tensorflow:Signatures INCLUDED in export for Train: None
INFO:tensorflow:Signatures INCLUDED in export for Eval: None
2019-03-14 13:39:08.654650: I tensorflow/core/platform/cpu_feature_guard.cc:141] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
INFO:tensorflow:Restoring parameters from models/run00/model.ckpt-240000
WARNING:tensorflow:From /usr/local/lib/python3.6/site-packages/tensorflow/python/estimator/estimator.py:1044: calling SavedModelBuilder.add_meta_graph_and_variables (from tensorflow.python.saved_model.builder_impl) with legacy_init_op is deprecated and will be removed in a future version.
Instructions for updating:
Pass your op to the equivalent parameter main_op instead.
INFO:tensorflow:Assets added to graph.
INFO:tensorflow:No assets to write.
INFO:tensorflow:SavedModel written to: export/run00/temp-b'1552559947'/saved_model.pb

I wonder why this custom convertion pipeline is used? i.e. why not just direct checkpoint to .pb convertion used?


Support for FVTT 11+ ?

I'm currently double-checking that all the modules I use are supported for v11 before upgrading.
https://foundryvtt.com/packages/pf2e-staves is still indicating v10:

Will this work with FVTT v11+ and PF2e v5+?
Thanks!

Currently using with FVTT v11.306 and PF2e v5.2.x and not seeing any obvious issues.

I've upgraded. Me neither.. it seems fine.
I won't close the issue so that the dev can state that it's verified v11.

Issue with magus twisted tree in conjunction with the PF2e staves module
When switches from 1 handed to two handed grip the module grinds and causes other players to DC and the game to chugg.

I am using FoundryVTT 11 Stable, Build 315, have this module installed. Adding a staff to my character's inventory does not add the appropriate group to my spellcasting tab, so I cannot track charges or use any of the module's features.


sync

Coverage decreased (-0.03%) to 70.936% when pulling d605d8e9bc9e6439ba8a09741ba3d6c0b6645cd3 on aseTo2016:master into d3ff9c2ad38108f877b74fda822c8772a46c4b01 on ServiceComb:master.

Codecov Report

Merging #114 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   66.58%   66.65%   +0.07%
==========================================
  Files          18       18
  Lines        3956     3956
==========================================
+ Hits         2634     2637       +3
+ Misses       1155     1153       -2
+ Partials      167      166       -1

Impacted Files
Coverage Δ

server/service/governservice.go
65.53% <0%> (+1.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3ff9c2...d605d8e. Read the comment docs.


Checkerboard artifacts, jagged mesh output

It looks like current network produces jaggy meshed due to using stride=2 convolutions. This problem is described here: https://distill.pub/2016/deconv-checkerboard/ . If I undersand correctly, the suggestion is to replace stride=2 convolutions with x = tf.image.resize_images(x, size=np.array(x.get_shape()[1:3])*2) and stride=1 convolution.
Here are come screenshots to illustrate the problem:
net_forward output (normalized to 0-255 range):

Zoomed:

Jagged mesh output:

Hi @AngryLoki , I also getting the same problem. did you try the solution you and is that working?

You can simply use a bulr function on the position map to smooth the 3d model.
For example
pos = prn.process(img, image_info=img_info)
pos = cv2.blur(pos, (5,5))

The model will more smoothing with a bigger kernel, but lose more details.


Temporarily skip version test that is broken (again)

https://github.com/istio/istio/pull/46291 but missed one case

/cherry-pick release-1.19
This test is also failing there.

@ericvn: new pull request created: #46392

In response to this:

/cherry-pick release-1.19
This test is also failing there.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Add .wlua to Lua filename guesses

(Original issue 481 created by None on 2010-03-12T12:22:49+00:00)
wlua is a common Lua extension for standalone Lua files that create windows rather than operating on the command line (to distinguish whether the console interpreter should be used).
Reported by guest

(Original issue was assigned to gbrandl)
(Original issue 481 last updated on 2010-03-12T12:43:06+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by gbrandl on 2010-03-12T12:43:06+00:00)
Thanks, added in [dec83e56f51a].


Add gc & index file generator

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues
-

Partially replaces #47

👍


Informer based CustomResourceEventSource

Using informer instead of a simple Watch in the custom resource event source will make the CustomResourceEventSource more reliable. Also it will serve as a cache for, replacing our current approach for caching.
Notes:

For this we will have to make few significant changes to the the framework. One of them is how we address internally custom resources, for now it's by UID. We will have to change this to namespace (optional) and name pair. Since this is how these resources are addressed in informer cache (store). Also this is a more future-proof mechanism, in case we want to implement in future transient caches we would not able to do it with UID, since a resource uid is not indexed (at least for now) in K8S. So in case of a cache miss, reading from api should be based on namespace and name (type we already know based on controller).

This will make the following issue obsolete: https://github.com/java-operator-sdk/java-operator-sdk/issues/356

This will make the following issue obsolete: #356

We might end up exposing the informer's cache for configuration at some point, though… 😄

This issue on fabric8 client may also be relevant https://github.com/fabric8io/kubernetes-client/issues/3472 so we can customize the key and index function if/when it make sense

This will make the following issue obsolete: #356

We might end up exposing the informer's cache for configuration at some point, though… smile

I guess that will be v3 :)


Color Code Converter

🚀 Feature
Color Code Converter is a web page that converts from and to different color codes such as RGB, CMYK, Hsl, & Hex.
Have you read the Contributing Guidelines ?

[x] Yes

Motivation
A nice project to get one's hands dirty with solid JS principles such as functions and variables scope. It's also a good tool to convert between different color codes on haste.
Pitch
It's an on-the-go project that converts between color code formats on haste with accurate values.
Issue created under GSSoC'22 contributions

@XZANATOL please Mention your issue belongs to GSSoC22.


Is there a solution now about NAN

Problems with NAN emerged in training.

Fixed some bugs that caused nan, please update  the coda and try again. @smile-ls-all


Username enhancement for reverse bruteforce & Kerberoasting

Hi Dan,
Firstly, wow, what an amazing tool. I can see this making my life so much easier! Thanks so much. I have a couple of suggestions for improvements/enhancements:

It would be great to have an option to provide a list of addition usernames/emails in a text file that have been enumerated separately. This could also be automated by adding tool such as LinkedInt/Prowl/InSpy (Can do multiple as they use different methods, linkedint by company name on the site, prowl by search engine results). Incorporating these to scrape & generate usernames based on LinkedIn OSINT.

I know DeathStar uses bloodhound & empire to escalate through the network, but would it be possible to include Kerberoasting in here somewhere? Part of initial access using GetUserSPNs to get the tickets, run them through John with your custom list and add successes into Deathstar to give it more to work with? Putting the kerberos tickets into a separate file thats clearly marked would be great so they can be extracted & run through a more intensive cracking process if needed.

That's a good idea. Will be a lot of work to implement so I can't give a timeframe.

I really hate relying on automated hash cracking. It's such a hassle. There's so many problems that make it not great: the machine you're attacking from rarely has a lot of resources so cracking on it is usually slow and low success. So then you can give the options for the user to specify their own cracking box which the script can remotely access, but this leads to like a billion different options that need to be configured by the user: remote IP, remote port, path to wordlist, kind of attack, path to rules (if any), etc, etc. To the point where it's like, did we even save the user any time over having them just crack them themselves? This ignores all the many many errors that can occur when running hashcat that have to be handled or else the entire functionality that you just spent a month implementing is useless. I have local cracking working in icebreaker and I've written autoresp which autocracks responder hashes and I'm pretty sure I'm not going to include autocracking in future projects unless I build an entire framework around remote cracking which I can import and I don't really want to do that right now.

But the premise that kerberoasting would be useful in DeathStar is absolutely true. I'm writing a tool msf-netpwn that's like DeathStar for metasploit and I'll probably add kerberoasting (but probably not autocracking) to it.


New metric dimension "client_name" propagated if passed by API clients via "X-Client-Name" header

Summary
problem: we cannot view metrics such as http_request_seconds_count per each type of client (e.g. trino) because there is no dimension for it
Solution: http client header set by API client which tells us which client is requesting the API. we use this header to tag the metrics and then can query the metrics via /metrics endpoint.
the http header is settable via:

passing key in property map to OpenHouseCatalog
directly to ApiClient init with ApiClient.addDefaultHeader

see proof:

In addition, I also exposed our favicon.ico because it was spamming our logs/metrics with NoHandlerFoundException because the favicon was missing and also required authorization.
see the error that was removed:
openhouse-tables-1 | {"startTimestamp":"1722276154615","endTimestamp":"1722276154617","sessionId":null,"clusterName":"LocalFSCluster","user":"undefined","serviceName":"UNRECOGNIZED","method":"GET","uri":"/favicon.ico","requestPayload":null,"statusCode":400,"responseErrorMessage":"The combination of the method [GET] and Path [uri=/favicon.ico] cannot be resolved by server. Please check and making sure you are using the right version of API.","stacktrace":"org.springframework.web.servlet.NoHandlerFoundException: No handler found for GET /favicon.ico\n\tat org.springframework.web.servlet.DispatcherServlet.noHandlerFound(DispatcherServlet.java:1287)\n\tat org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1050)\n\tat org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:965)\n\tat org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006)\n\tat
...
...

Issue] Briefly discuss the summary of the changes made in this
pull request in 2-3 lines.
Changes

[x] Client-facing API Changes
[x] Internal API Changes
[x] Bug Fixes
[x] New Features
[ ] Performance Improvements
[ ] Code Style
[x] Refactoring
[ ] Documentation
[x] Tests

For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done

[ ] Manually Tested on local docker setup. Please include commands ran, and their output.
[x] Added new tests for the changes made.
[x] Updated existing tests to reflect the changes made.
[ ] No tests added or updated. Please explain why. If unsure, please feel free to ask for help.
[ ] Some other form of testing like staging or soak time in production. Please explain.

For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information

[ ] Breaking Changes
[ ] Deprecations
[ ] Large PR broken into smaller PRs, and PR plan linked in the description.

For all the boxes checked, include additional details of the changes made in this pull request.

@autumnust pushed one more commit to address moving trino/spark options into configuration.
but I chose to push them into cluster properties yml because these are just string values and the workflow for adding a new accepted client header would just require yaml update.
let me know what you think and can approve PR


rel(network-agent): Prepare chart version to v0.2.0

Which problem is this PR solving?
Prepares the next version of the agent to be published.
Short description of the changes

Updates chart version to 0.2.0
Add changelog entry for 0.2.0 and missing entry for 0.1.0

How to verify that this has the expected result
The next version of the chart can be published.

You don't need to do these any more. Note the deprecation warning at the top of the changelog.


Linked Stratum Auth icon

A while ago, Authenticator Pro was rebranded into Stratum Auth, however, the icon stayed the same. I added a line to link Stratum Auth to the old Authenticator Pro icon, keeping the original for compatibility.
First ever pull request.. be gentle, please.
Linked
Stratum Auth (com.stratumauth.app → authenticator_pro.svg)

Works in the debug APK.

Cool, thanks!


Loosen Newtonsoft.JSON minimum version requirement from v13.0.1 to v9.0.1

The is the same action as the SARIF SDK to "loosen min version requirement to 6.0.8 for .NET FX, 9.0.1 otherwise".
The jschema project is not on .NET FX, so we are using v9.0.1
Before it was upgraded to v13.0.1, it was on v9.0.1
so the change should be minimum impact, which is a basically a revert.

We should keep the tests at 13.0.1. Please check my branch: users/marmegh/newtonsoftVersioning. @EasyRhinoMSFT, had you been able to work out the global setting on that branch? If so, we should close this PR and try to merge that one.

We should keep the tests at 13.0.1.  ---- fixed.

In reply to:<PHONE_NUMBER>

Can you add the PR link in the release history? CodeFlow is malfunctioning on me, seeing if I can add this comment here.

Once we have the global settings taken care of and the PR link addressed, this PR will be ready to merge. Please ping me at that time to approve.

In reply to:<PHONE_NUMBER>

add the PR link in the release history ---- Yes! Just fixed.

In reply to:<PHONE_NUMBER>

Once we have the global settings taken care of
and the PR link addressed  ---- done
@EasyRhinoMSFT  do you know about Mary's question above

In reply to:<PHONE_NUMBER>

I have not been able to find a single place for the fix. It's a general problem with class libraries, since there is not "startup" or "initialize" point. I am not aware of a way to wire something like that up. We got lucky in the SARIF SDK because all of the model classes inherit the same base class, where we could stick a static constructor.

In reply to:<PHONE_NUMBER>

I am looking into this some more right now

In reply to:<PHONE_NUMBER>

Nope, won't work on classes that already inherit something else

In reply to:<PHONE_NUMBER>

@EasyRhinoMSFT  thanks for fixing it in Program.cs.

In reply to:<PHONE_NUMBER>


Fix student bugs

Codecov Report
Base: 57.47% // Head: 57.74% // Increases project coverage by +0.26% :tada:

Coverage data is based on head (0ecacec) compared to base (5d72892).
Patch coverage: 77.50% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #205      +/-   ##
============================================
+ Coverage     57.47%   57.74%   +0.26%
- Complexity      766      770       +4
============================================
  Files           159      159
  Lines          3203     3235      +32
  Branches        393      397       +4
============================================
+ Hits           1841     1868      +27
- Misses         1204     1210       +6
+ Partials        158      157       -1

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...commands/consultation/EditConsultationCommand.java
0.00% <0.00%> (ø)

...s/logic/commands/tutorial/EditTutorialCommand.java
0.00% <0.00%> (ø)

...n/java/seedu/address/model/student/Attendance.java
70.00% <ø> (ø)

...ava/seedu/address/model/student/Participation.java
70.00% <ø> (ø)

...in/java/seedu/address/model/student/StudentId.java
80.00% <ø> (ø)

...ddress/logic/parser/student/StudentParserUtil.java
84.74% <66.66%> (+0.53%)
:arrow_up:

...s/logic/commands/reminder/EditReminderCommand.java
84.84% <100.00%> (-0.87%)
:arrow_down:

...ess/logic/commands/student/EditStudentCommand.java
91.89% <100.00%> (+0.22%)
:arrow_up:

...c/main/java/seedu/address/model/student/Grade.java
83.33% <100.00%> (+28.78%)
:arrow_up:

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Class "Rector\PHPUnit\Set\PHPUnitLevelSetList" not found

https://github.com/77web/sendgrid-marketing-campaign-api-php-client/actions/runs/10146065441/job/28053260103?pr=8

PHPUnitLevelSetList was renamed to PHPUnitSetList
FinalizePublicClassConstantRector was removed


add libsecret support

Instead of asking a user to type the password, libsecret can be asked for a password corresponding to a username, when present.
Several web browsers, most notably Firefox and Chrome, support storing passwords via libsecret out of the box or via Add-Ons. When these facilities are in use, the password is most probably already available.

I feel it better to have an option for libsecret rather than use it implicitly. I'm not sure how other developers think. Lets wait.

As already mentioned by @yan12125, it should not touch the current behavior and should only activate explicitly when an option is specified. Using of --password is explicit user's intention to provide password himself either on command line or interactive.


Plume vertical displacement issue after some time.

Hi,
I have been running into a weird issue with the plumes where after a couple minutes, a large portion of the plume is suddenly vertically displaced upwards. Sometimes this displacement happens multiple times in short succession, other times it happens once. And it happens on every run.
The particles are continuously generated at the source with the correct current velocity (which I am setting via the set_current_velocity service call).

Hi @ethanjpark, could you please send me the parameters you used so I can try and run this here to see if it also happens on my machine?

I managed to make this issue not happen (I hesitate to say fixed). What I suspect is that the 'current_velocity_server' instance that I created in addition to launching the gazebo world 'ocean_waves.launch' created conflicting current velocities with that produced by the gazebo current velocity controller. I took another look at the existing launch files in plume simulator and realized that the current_velocity_server was only being created if use_gazebo was false.
Long story short I think the issue was coming from my misuse of the current_velocity_server.
In case you're still interested, here is the service call that I used for setting current velocity when I still had issues:
rosservice call /current_velocity_server/set_current_velocity "{velocity: 1.0, horizontal_angle: 0.0}
Thanks for the reply, the simulator's been great!


Add data to the label

if I want to add data to the label, do I put the data (picture) directly into the input folder and then continue to add the label?

Can you clarify what you mean by adding data to the label? Does this mean you'd like the ability to update the label names?


Readme and comments

Add a readme with install guidance, update comments in CMakeLists

Also add licence, to get into the habit
Licensed under the MIT license: http://www.opensource.org/licenses/mit-license.php


Pass variable inside request header

Hello Dave,
I have some trouble while using your docker-nginx container !
I use it as reverse proxy to protect an app by LLNG authentication, and I dont find the way of give as header response the Uid associate to the cookie through.
Do you have any idea to do it ?
Thanks !

My use case hasn't been too detailed with the nginx image, more so with something like say my nginx-php-fpm image. I don't believe I am processing the headers too much.
      - NGINX_AUTHENTICATION_TYPE=LLNG
      - NGINX_AUTHENTICATION_LLNG_ATTRIBUTE1=HTTP_AUTH_USER,uid,upstream_http_uid
      - NGINX_AUTHENTICATION_LLNG_ATTRIBUTE2=HTTP_GROUPS,groups,upstream_http_groups

That's the most simple, I believe you are looking to extract it out of Nginx. That I do not know how personally - of course it is possible, but I don't know a way to dynamically use them other than passing them via fastcgi_param to another service (php-fpm)

I succeeded by adding these two line inside the llng_auth_request file located on : /etc/nginx.conf.d/authentication/
auth_request_set $authuser $upstream_http_auth_user;
proxy_set_header Auth-User $authuser;

And there are my exported headers

Note : Do you know why  I needed to add these line from myself ? I that link to the NGINX_AUTHENTICATION_LLNG_ATTRIBUTE2 (because I only set the ATTRIBUTE1 on my nginx container)
Thanks for help !

I bet the ATTRIBUTES don't even matter, as since this is so close to nginx from the handler it is aware of all headers. I may be wrong through. I'd like to know more on this personally as I have alot of uses for it.

Closing due to inactivity


The OpenSSL switch

See also:

https://github.com/kisslinux/repo/pull/266
https://github.com/kisslinux/repo/issues/263

Since Wyverkiss will always sync with KISS Linux, if/when Dylan merge the PR above, we'll follow suit.

Now that this is merged, will there be an updated rootfs?

It's here: https://github.com/wyvertux/wyverkiss/releases/tag/2021.7


Change arg_parse to always set --emit-new-didcomm-prefix and --emit-new-didcomm-mime-type to true

Signed-off-by: Stephen Curran<EMAIL_ADDRESS>Approach used was to accept the parameters, but whether set or not, set corresponding config value to True.
Left the config settings, but updated the help to say not setting the value is not possible.
Didn't change the tests, but added a comment about why the of the old setting is not particularly useful...

Fixes (finally!!) Issues #1042 and #1044.
Open to suggestions if we should be more aggressive at removing the setting where it is used.


eBook 2.1 updates

READY TO MERGE
This is a PR with the 2.1 updates to the eShopOnWeb eBook.

Ready for review @CESARDELATORRE

Maira, can you review/merge this PR when possible?
Thanks,

Interesting. WIP bot is stuck. Have you ever seen this happen @terrajobst?
@ardalis I'll start the review now but please check the warnings from the last build report as well.

Interesting. WIP bot is stuck. Have you ever seen this happen @terrajobst?

I saw this once before when one of the earlier commit messages had "WIP" in the message. I think a squash (or other interactive rebase) to edit the commit message would fix it. Also, if that's the root cause, we should file a bug with that bot.

Interesting. WIP bot is stuck. Have you ever seen this happen @terrajobst?

AFAIK the WIP bot also looks at commit messages. There is still one commit that includes "WIP" in it. Try to reword that commit.

I saw this once before when one of the earlier commit messages had "WIP" in the message. I think a squash (or other interactive rebase) to edit the commit message would fix it. Also, if that's the root cause, we should file a bug with that bot.

It's currently by-design but it's discussed here.

Read that thread - seems odd that some ancient commit that happened to be WIP will then make the entire PR forever be considered WIP. That's not a great design. Having to rewrite history on older commits like that is someone nerve-wracking, too. I can do it if it that's what's required here, though. Please confirm that's what I should do and (if you have some) point me to known good instructions for doing so. I think this is the (only) offending commit:
https://github.com/dotnet/docs/pull/4905/commits/d227706818ebc828eeb80e45970bcef8ae29dcca

@ardalis this is a good resource for squash and rebase.

I forgot that it applied to commits too. Let me know if you need help @ardalis. I could make the change for you, but then you'd have to hard reset your local copy.

Thanks, Bill. I was going to try and just amend the commit message. Do you think it would be much better for me to squash and rebase instead?

I think you can just amend the commit message, but that still requires a rebase --interactive because it's an older commit (I think).
If that doesn't work, hit it with a bigger 🔨 and rebase and squash. 😅

@mairaw I've made updates addressing your content feedback. I also tried to git amend which as Bill noted required a rebase --i which had so many commits in it that I wasn't comfortable trying to get that to work (to remove the 'WIP' text from an older commit). Can you please do whatever's necessary to fix this and I will do a reset on my local copy? If it's easier to start a new PR we could do that as well/instead. Thanks!

will do @ardalis. I'm a bit swamped at the moment but I'll get back to this as soon as possible.

yes let me unblock you

I'm running this but because the commit was so far back it's taking a long time. So it might just be better to ignore the WIP in this case.

So what does that mean for me? I thought the WIP was preventing the bot
from doing something critical to merging this PR?
 So it might just be better to ignore the WIP in this case.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dotnet/docs/pull/4905#issuecomment-398575750, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAvvL8mPQCu8cx58WyGHlB9OSXL_gKg_ks5t-YdxgaJpZM4TMuyk
.

--
Steve Smith
http://ardalis.com | http://twitter.com/ardalis

Resolve the merge conflicts that is showing here and I’ll see if I have any additional feedback.

@mairaw Done.

@ardalis I've left a few last comments but it's looking good. Take a look at my comments and questions from earlier today and just now.

All good. :shipit:

I'm fine to publish immediately. Maybe check with @CESARDELATORRE


Co-realise

PLEASE COMMENT, BUT DO NOT MERGE
because, apart from discussion, a test is still needed ...
Purpose:
User code often forms multiple stats, where data may be very large.
= several small, lazy, calculated results derived from same large, lazy data
Calculation scans the data, each time you realise one.
This can + should be done in parallel with da.compute(*dask_stats_arrays).
We need to assign back into Iris cube.data elements.
I can't find a neat Python idiom for this, so we can provide a simple utility routine.
Note: I'm proposing to put this in package iris itself, as I don't rate the alternatives :

iris._lazy_data is private
iris.utils, on inspection, I think is for "handy things you might just have written yourself"
whereas : this code uses knowledge of internals.

Could not review pull request. It may be too large, or contain no reviewable changes.

Could not review pull request. It may be too large, or contain no reviewable changes.

@pp-mo - I'm somewhat concerned about this one. What happened with it? It says "merged", but there are 0 commits. It also says "Do not merge", yet it looks like it might have been merged.
Any clues? 😄

What happened with it? It says "merged", but there are 0 commits.

Not entirely sure of details, but I suspect that #2967 included the original commit for this, so it became redundant when that was merged.


Create graph method to get all supported operations

Also create a graph method to check if an operation is supported
/**
 * @param operationClass the operation class to check
 * @return true if the provided operation is supported.
 */
public boolean isSupported(final Class<? extends Operation> operationClass) {
    return store.isSupported(operationClass);
}

/**
 * @return a collection of all the supported {@link Operation}s.
 */
public Collection<Class<? extends Operation>> getSupportedOperations() {
    return store.getSupportedOperations();
}

Merged into develop


Macro for matching multiple errors?

Is this a likely pattern that we'd want to automate, or is it discouraged?
if let Err(e) = try_to_do_the_thing() {
    match_err! { (e)
        me: MyError => println!("MyError: {}", me),
        io: io::Error => println!("IO: {}", io),
        unk => println!("unknown: {}", unk)
    }
}

I've verified that it's possible to implement this, if we want it :)

Nearly this exact macro was included as recently as a week ago.
Limitations of macro grammar made it rather awkward (maybe it could be better than I got it to be, though). I don't think it should be discouraged, but I wasn't happy publishing an API as finicky as that macro had been.

Here's the previous version. It didn't have as flexible syntax as your macro (which was a problem), but it supported by ref and mut ref downcasting using some secret extra code.
I think I'd rather see this in a separate crate for the near term and only move it into failure if this is a common use case.

Actually thinking about that, I'd prefer being able to match both Ok and error variants, something like:
match do_stuff() {
  Ok(42) => println!("Hurray!"),
  Ok(x) => println!("Suspicious answer {}", x),
  err!(e: io::Error) => println!("IO: {}", e),
  err!(my: MyError) => println!("MyError: {}", my),
  Err(e) => println!("Unknown error: {}", e),
}

Or, maybe not prefer, but have both.

@withoutboats Hey, that looks cool. I think this'd need some bit of syntax bikeshedding, but in general this'd make working with these abstract „base classes“ much more friendly.
I myself would prefer something like
Err(e: dyn io::Err)

over the @ sign (because @ is already used in pattern matching to do „capture both the whole expression and parts of it). This would be more like type ascription, which is closer to what it really is ‒ stating that e has some type. It could even downcast e to the given type, so it could be actually used in the body. I think other languages use something like that (I glimpsed something like that in scala).
But this is probably getting off-topic, right? So, when you write your ideas down, I'd be happy to look at them :-).