Pdf generator takes 4 seconds irrespective of file content  #219

Child process's exit event occurs after 4 seconds, where as data event occurs as and when it occurs.

Please review the fix and apply for #219

Fixed in v2.2.0


Allow setting of where results are placed

Results directive determines folder in tests dir to place baselines and screenshot test results.
Settings results in Gruntfile.js to baselines, will place results in the baselines dir as before this fix.

Think i'm pretty ok with this. Can you update the default results dir to 'baseline' first?

@micahgodbolt, the default results dir has been updated to 'baseline'. My only concern is this may be a bit misleading since that dir will house both the baselines and the results.

Merging this in. Created #4 to come back to the code and clean up the options.


Finding extra package.json files

In my project we run all the code through a build process that dumps the output into a build directory off the project root.  This directory is happily git ignored and all.
However, if I'm reading it right, because find is recursive (https://github.com/nlf/git-validate/blob/master/bin/validate.sh#L339), it picks up this other package.json and tries to run the validations from within that build directory.  This leads to failures due to missing dependencies, which I expect.  I don't want to run the validations against the build directory.
I'm not entirely sure what the best approach to fixing this would be.  I assume there's a reason why max-depth of 1 wouldn't be appropriate, but at the same time, I'd rather not delete my build just to lint my project.  I'm not sure this is even a "bug" with git-validate.
Do you have any guidance on this?  I'd hate to add another config file to the project's root.  I suppose I could move the build directory outside of the project, but I like everything being self-contained as well.

what if i added a config field to package.json so you could do something like
{
  'git-validate': {
    ignore: 'build'
  }
}

and any packages found in the 'build' directory (which would be a direct child of the current directory, i'd just use path.join with the root) would be ignored. sound ok?

That sounds like a great solution.

This solution would only be suboptimal. Since I git-validate is used to create modules that configure your project to use hooks, the module can't know upfront what to ignore.
IMO the best approach would be to limit the search scope to .git/../

My suggestion to look for package.json:
    local projects;
    projects=$(find . -maxdepth 1 -name package.json -print 2>/dev/null)
    if [[ $? -ne 0 ]]; then
        projects=$(find . -not -iwholename '*node_modules*' -not -iwholename '*bower_components*' -maxdepth 3 -name package.json -print 2>/dev/null)
    fi
    if [[ $? -ne 0 ]]; then
        projects=$(find . -not -ipath '*node_modules*' -not -ipath '*bower_components*' -maxdepth 3 -name package.json -print 2>/dev/null)
    fi

If you don't find a package.json at the root level continue to dig deeper.

thinking about using git ls-files instead so that anything that's not committed to the repo won't be found, this solves the problem of node_modules and of things that are .gitignored
thoughts?

noting that i'll still filter out node_modules since some people commit those

@nlf Any update on this issue?


Migrate TCK to RxJava 3

Going forward, we're looking for a composition library that remains stable and doesn't produce conflicts with upgrades. Project Reactor plans a 4.0 release and that release is likely to require adoption for the public API. We want to use a composition library that supports Reactive Streams as first-class citizen and where co-existence of newer major versions is possible. RxJava has proved the coexistence of multiple versions with versions 2 and 3 by using versioned packages.

With Project Reactor slowing down on their plans to ship Reactor 4.0 along with breaking changes there's no immediate need to address this ticket.
While investigating a potential migration path, RxJava 3 doesn't provide simple means for usingWhen or then(…) composition. Instead, there's utility code require to achieve the same level of composition as with Project Reactor.

Not moving to RxJava 3 as the base infrastructure (e.g. usingWhen operator) is not easily usable for resource management and requires additional operator logic in our test kit. Also, Reactor has moved to a much more defensive upgrade path so we can rely on Project Reactor for the next couple years.


Merge current upstream changes, 101721

See #12, and my_docs/merging_upstream.md.

Notes

As of today, this fork is 114 commits behind heroku:main.


Profile deployments validation

Validate when deploying a profile that the wearables are valid URNs

Also, in Access Checker validate that:
if(profile.hasClaimedName && !(profile.name in claimedNames)) then throw

Should we allow to support more than one avatar per profile? Changing that may imply a huge breaking change anyway

Fixed


Checkbox ticks don't work on Windows

Adwaita and OSX themes have ticks in the checked Checkboxes. They appear as squares in Windows. I think it has something to do with CSS clip-path.

Done #18


Update read from S3, Azure blob etc

The docs for reading files from cloud storage are out-of-date. As there are a number of ways to do some of these operations I'd like to cover the range and note their pros/cons.
Anything else we should aim to cover here @ritchie46, @ghuls?

How to efficiently read multiple files from S3, such as partitioned parquet, is a common question. (I've been using pl.scan_pyarrow_dataset for that...)


v1.14 Backports 2023-08-10

[ ] #27327 (@joestringer)

Once this PR is merged, you can update the PR labels via:
for pr in 27327; do contrib/backporting/set-labels.py $pr done 1.14; done

or with
make add-labels BRANCH=v1.14 ISSUES=27327

/test-backport-1.14


0.116.0 binaries re-upload reason?

Hello
it seems that 0.116.0 binaries have been re-uploaded with different versions.
Is-it possible to know the reason?
Thx
ie.:
last week 0.116.0 linux64 had the following size: 46,404,368 (sha256: 0d45e0d57a46134c7a0342e184f43aaa420b1ed6479052ef89152a56b30b45ef)
today, 0.116.0 linux64 has the following size: 46,441,778 (sha256: 92c25ae9e1089297ccf7ad7cdf22d36216de6187b28dec605b5644f8dc513cef)

Maybe I accidentally updated the v0.116.0 tag that resulted in another release?
First: https://circleci.com/gh/roboll/helmfile/5071
Second: https://circleci.com/gh/roboll/helmfile/5097


feat: Application templates

Description
Adds a template page where users can see list of templates that can be forked to an organisation of their choice.
Other features/notes includes the following

Show a notification indicating there is a new templates tab
Include a template listing page
Includes a templated detailed view page
Users can fork a template to an organisation
Currently it is hidden behind a feature flag until some templates are added.
Making use of a new api to get the list of all plugins available. https://github.com/appsmithorg/appsmith/issues/11121

Figma file: https://www.figma.com/file/dmDCEc6g2DvccF1QElkdAs/Templates?node-id=2212%3A11165
Related to #9661
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Cypress test to verify the fork template flow
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: feat/templates

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
55.71 (0)
36.99 (-0.01)
34.99 (-0.18)
56.05 (0)

:green_circle:
app/client/src/actions/pluginActions.ts
65.22 (0.22)
100 (0)
0 (0)
61.54 (3.21)

:sparkles: :new:
app/client/src/actions/templateActions.ts
68.18
100
0
88.89

:red_circle:
app/client/src/api/PluginApi.ts
82.61 (-3.1)
100 (0)
42.86 (-7.14)
81.82 (-3.18)

:sparkles: :new:
app/client/src/api/TemplatesApi.ts
71.43
100
20
69.23

:red_circle:
app/client/src/ce/constants/messages.ts
76.62 (-0.35)
100 (0)
30.64 (-1.06)
81.92 (0.17)

:green_circle:
app/client/src/components/ads/Icon.tsx
99.4 (0)
84.21 (0)
100 (0)
99.4 (0.01)

:green_circle:
app/client/src/components/ads/Text.tsx
93.22 (0.63)
74.19 (0)
100 (0)
93.1 (0.65)

:green_circle:
app/client/src/constants/routes.ts
65.43 (0.47)
23.75 (-0.3)
21.43 (-0.79)
62.09 (0.82)

:red_circle:
app/client/src/reducers/entityReducers/pluginsReducer.ts
35.71 (-5.96)
100 (0)
0 (0)
35.71 (-5.96)

:red_circle:
app/client/src/reducers/uiReducers/applicationsReducer.tsx
10.31 (-0.11)
30 (0)
8.16 (-0.17)
10.64 (-0.11)

:sparkles: :new:
app/client/src/reducers/uiReducers/templateReducer.ts
38.46
100
0
38.46

:green_circle:
app/client/src/sagas/ApplicationSagas.tsx
18.07 (0.33)
6.06 (0)
8 (0)
20.87 (0)

:red_circle:
app/client/src/sagas/PluginSagas.ts
13.59 (-0.99)
2.78 (-0.16)
9.09 (-0.91)
16.47 (-1.03)

:sparkles: :new:
app/client/src/sagas/TemplatesSagas.ts
28.95
10
16.67
34.38

:green_circle:
app/client/src/sagas/index.tsx
92.98 (0.12)
60 (0)
100 (0)
94.55 (0.11)

:red_circle:
app/client/src/selectors/applicationSelectors.tsx
67.82 (-0.85)
31.25 (-2.08)
42.86 (-3.29)
60.87 (-0.67)

:red_circle:
app/client/src/selectors/entitiesSelector.ts
46.8 (0.18)
7.8 (0)
25 (-0.52)
43.17 (-0.06)

:green_circle:
app/client/src/utils/WorkerUtil.ts
89.76 (0)
72.55 (1.96)
100 (0)
93.33 (0)

:red_circle:
app/client/src/utils/storage.ts
34.04 (-0.44)
11.11 (0)
7.14 (-0.55)
27.01 (-0.55)

Bugs:

[ ] On templates page, after selecting any filter from expanded filter list in left pane ,the show less button disappears.
[ ] The expanded filter list on templates page doesn’t persist on switching tabs.

As discussed with parthvi

[x]  On templates page, after selecting any filter from expanded filter list in left pane ,the show less button disappears.

This is expected as we don't want to hide a selected filter behind show more.

[x]  The expanded filter list on templates page doesn’t persist on switching tabs.

An older dp was used for testing. This is fixed in the latest deploy preview

/ok-to-test sha=726ae3e

/ok-to-test sha=f07ceea

/ok-to-test sha=54b0969

/ok-to-test sha=3657dc5

/ok-to-test sha=5d1cafb

/ok-to-test sha=6297560


Feat / Allow add labels on edit of a issue

What
Add edited.issue on robot to listen it automatically
Why
In order to continuously add labels even you forgot at the first time

@pamepeixinho Thank you for this :smile:. Would come in very handy. Would be nice if we could have a test case for this as well., otherwise LGTM to merge.

Added in the new version with tests. Not merging this because of no updates.


chore(master): release 1.3.0

:robot: I have created a release beep boop
1.3.0 (2023-03-15)
Features

prepare for auto-merge (ac8b073)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/docker-build-deps/releases/tag/v1.3.0 :sunflower:


Roles fixes

Codecov Report

Merging #329 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   99.73%   99.78%   +0.05%
==========================================
  Files          12       12
  Lines        1893     1900       +7
==========================================
+ Hits         1888     1896       +8
+ Misses          5        4       -1

Impacted Files
Coverage Δ

ldap2pg/role.py
100.00% <100.00%> (+0.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6a2c8f...87dd43e. Read the comment docs.


Warnings when compiling with -ffinite-math-only on Linux with Clang v19.1

TOML++ version: v3.4.0
Compiler: clang++ v19.1.1
Target arch: x64
Library configuration overrides: None
Relevant compilation flags:

You can run the following command on the generated all-in-one toml.hpp file using Clang 19.1:
$ clang++ -ffinite-math-only -fsyntax-only toml.hpp

Bug:

When compiling, you get the following warnings:
a@a:/nt$ clang++ -ffinite-math-only -fsyntax-only toml.hpp
/nt/vendor/toml++/toml.hpp:13012:30: warning: use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
 13012 |                         return inf ? (negative ? -std::numeric_limits<double>::infinity() : std::numeric_limits<double>::infinity())
       |                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/nt/vendor/toml++/toml.hpp:13012:72: warning: use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
 13012 |                         return inf ? (negative ? -std::numeric_limits<double>::infinity() : std::numeric_limits<double>::infinity())
       |                                                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.

Ideally, the parser should generate a parse error on encountering an Inf/NaN when compiling with -ffinite-math-only.

I started fixing the issue, but it looks like a lot of unit tests need to be updated to check whether finite-math-only is enabled.


docs: [IAC-2771]: Split provision and destroy workspace docs

Description

Separating Provision and Destroy workspace docs and adding interactive guides to help improve bounce rates.
JIRA

PRs must meet these requirements to be merged:

[x] Successful preview build.
[x] Code owner review.
[x] No merge conflicts.
[x] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67347fae39f9b7c84c68cc6e--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6734cad7b273cf27fe464e67--harness-developer.netlify.app


Ordering on Transaction History incorrect

On the way buying a PIVCard, if you get refunded, because of for example the service is not running correctly, the order in the History below the Wallet on the Dashboard shows the incorrect order.

The marked transactions show correct on the screenshot, but this was after I reloaded the page.
The Automatic update of the Information in the table initially sorted them the other way around.

This issue is likely already solved on the current master

Closing this as I've not received any reports of this and is likely fixed. Feel free to reopen if you encounter the issue again


fixed broken link for dos2unix

the link was for https://sourceforge.net/software/dos2unix/ which brought to a page with error.
new link is: https://sourceforge.net/projects/dos2unix/

Thank you very much for this, Alon!


bat: 0.6.1 -> 0.7.0

https://github.com/sharkdp/bat/releases/tag/v0.7.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

I did not even notice that we already had it: https://github.com/Mic92/nur-packages/tree/master/pkgs/bat

@GrahamcOfBorg build bat

Success on aarch64-linux (full log)
Attempted: bat
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lrmpvifqi3cvpsr6jkjzl3qfg6n0mjr8-bat-0.7.0
shrinking /nix/store/lrmpvifqi3cvpsr6jkjzl3qfg6n0mjr8-bat-0.7.0/bin/bat
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lrmpvifqi3cvpsr6jkjzl3qfg6n0mjr8-bat-0.7.0/bin
patching script interpreter paths in /nix/store/lrmpvifqi3cvpsr6jkjzl3qfg6n0mjr8-bat-0.7.0
checking for references to /build in /nix/store/lrmpvifqi3cvpsr6jkjzl3qfg6n0mjr8-bat-0.7.0...
/nix/store/lrmpvifqi3cvpsr6jkjzl3qfg6n0mjr8-bat-0.7.0

Success on aarch64-linux (full log)
Attempted: bat
Partial log (click to expand)
these derivations will be built:
  /nix/store/4chlmfcj90dgijnj7i8bq2yvlaf9vpb1-bat-0.7.0.drv
waiting for locks or build slots...
/nix/store/lrmpvifqi3cvpsr6jkjzl3qfg6n0mjr8-bat-0.7.0

Success on x86_64-darwin (full log)
Attempted: bat
Partial log (click to expand)
test tabs_passthrough_wrapped ... ok

test result: ok. 23 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/m15h5g9bkjizz5ic9aziapcp5gavccdp-bat-0.7.0/bin
patching script interpreter paths in /nix/store/m15h5g9bkjizz5ic9aziapcp5gavccdp-bat-0.7.0
/nix/store/m15h5g9bkjizz5ic9aziapcp5gavccdp-bat-0.7.0

Success on x86_64-linux (full log)
Attempted: bat
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7iwx9wwb8anb4466m9x858kmhm688kwc-bat-0.7.0
shrinking /nix/store/7iwx9wwb8anb4466m9x858kmhm688kwc-bat-0.7.0/bin/bat
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7iwx9wwb8anb4466m9x858kmhm688kwc-bat-0.7.0/bin
patching script interpreter paths in /nix/store/7iwx9wwb8anb4466m9x858kmhm688kwc-bat-0.7.0
checking for references to /build in /nix/store/7iwx9wwb8anb4466m9x858kmhm688kwc-bat-0.7.0...
/nix/store/7iwx9wwb8anb4466m9x858kmhm688kwc-bat-0.7.0

Success on x86_64-linux (full log)
Attempted: bat
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7iwx9wwb8anb4466m9x858kmhm688kwc-bat-0.7.0
shrinking /nix/store/7iwx9wwb8anb4466m9x858kmhm688kwc-bat-0.7.0/bin/bat
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7iwx9wwb8anb4466m9x858kmhm688kwc-bat-0.7.0/bin
patching script interpreter paths in /nix/store/7iwx9wwb8anb4466m9x858kmhm688kwc-bat-0.7.0
checking for references to /build in /nix/store/7iwx9wwb8anb4466m9x858kmhm688kwc-bat-0.7.0...
/nix/store/7iwx9wwb8anb4466m9x858kmhm688kwc-bat-0.7.0


Feature survey

Surveys has been implemented in the backend as Wagtail page and models have been created to allow admin to add surveys(questions) and can map to any of the pages. We have also developed front end pages to allow users to view surveys in the front end pages and can answer to those questions.
We are facing the issue with front end while user adding answers to those questions. Answers are not getting created for those questions and the error is related to depth column in Wagtail Core.
Please find below for your reference,
File Location: Surveys/views.py - Line no:18
Exception Type:	IntegrityError
Exception Value:     wagtailcore_page.depth may not be NULL
We are checking this in our end and could update on this once we able to fix this issue and make sure the users can add answers to the questions.

The build is failing due to issues unrelated to the Exception Type: IntegrityError Exception Value: wagtailcore_page.depth may not be NULL error. Please fix the build so we at least eliminate any errors originating from that.

We have checked this in our end and tried running the test [ python manage.py test -v1 ]
We could not see this migration error in our end and could run the test successfully. We have even tried mapping to a new database and applied migrations. We could not see this migration error. We will try to reproduce it if we could get that. Please advice.
Error:
django.db.migrations.graph.NodeNotFoundError: Migration surveys.0001_initial dependencies reference nonexistent parent node (u'wagtailcore', u'0017_auto_20150731_1102')
We have solved one of the flake8 standard issue and updated the build.

You were referring to a migration that simply doesn't exist in Wagtail. If you look at the list of available migrations at https://github.com/torchbox/wagtail/tree/master/wagtail/wagtailcore/migrations you'll notice that 0017_auto_20150731_1102.py isn't available there. I think perhaps you locally made some changes that somehow ended up as a wagtail migration which are now available on your system but aren't in the official wagtail distribution.
Instead I've referred to the last available wagtail migration: 0016_change_page_url_path_to_text_field.
I've also merged in the changes made in develop and resolved the conflicts there.

I've had a look at the pull-request. This is now the third I'm reviewing and I'm flagging the same issues around the use of {% trans ... %} and {% url ... %}, missing new lines etc. Doing these small things well matters to us and by now you know well what I'm looking for first in a review. Please attend to those first and let me know when done so I can do a review of the actual features.

I've merged #5 into develop and develop back into this pull-request.

Simon we have already checked these items and resolved in the feature questions branch. Since we updated these in feature questions branch, the code we are looking here is in surveys feature which has yet to be merged to get the latest update from questions branch. We could see that you have merged now and get the latest code.

:+1: please go ahead and merge.


Default span propagation for tracing in builders

Following on from https://github.com/jtescher/opentelemetry-rust/issues/17
It would be useful if the server and client builders provided a default implementing for propagating parent spans via the grpc-trace-bin header. Currently I have something similar to this for a service I'm working on using https://github.com/census-instrumentation/opencensus-go/blob/17d7955af9d42886455ce010dd46878208041a58/plugin/ocgrpc/trace_common.go as a reference for how it's typically done in other languages:
Server::builder()
    .interceptor_fn(|svc, req| {
        let grpc_trace = &req.headers()["grpc-trace-bin"];
        let bp = BinaryPropagator::new();
        let span_state = bp.from_bytes(grpc_trace.as_bytes().into().span_id();
        let parent = match span_state {
            0 => None,
            e @ _ => Some(Id::from_u64(e)),
        };
        let root = match req.uri().path() {
            "/package.service/method" => span!(parent: parent, Level::INFO, "package.service.method"),
            _ => span!(parent: parent, Level::INFO, "package.service.unknown"),
        };
        let _enter = root.enter();
        svc.call(req)
    })
    .add_service(service).serve(addr).await?;

The ugly match is because the span name needs a static lifetime so if there was also a static string representing the package.service.name identifier in the generated grpc code that would be useful as well.

I'm also getting BinaryPropagator from the opentelemetry so not sure about what to do with that...

@xd009642 you can also look at the the actix-web impl if that helps https://github.com/OutThereLabs/actix-web-opentelemetry/blob/master/src/middleware/trace.rs#L152

slightly, though I kinda thought it would be possible to do this with just tracing and what tonic already has? I'm currently reading up some docs to try and figure it all out in my mind before asking a bunch of stupid questions :smile:

Oh I see the grpc-trace-bin format is defined by different tracing services like opencensus etc. So I suppose I could take a Fn that takes the bytes from the trace header and decodes them to return an option of the span parent id. That would minimise the boilerplate but not solve my span name issue.
And of course whether the span name is actually standardised in any way between the different tracing things...

This was done in #175

Sorry for the necrobump, but I'm trying to wrap my head around https://github.com/hyperium/tonic/pull/175.
I get that PR adds a .trace_fn(…) to a Server::builder(), but does this actually extract the trace ID and sets the parent span if headers in the request metadata are present?
And similarly, how do I get a tonic client to (always?) inject its current trace ID as a trace ID into the metadata?
Is this something for tonic to provide? Or are there other crates that do this, and I'm just missing the link?

Hmmh, https://github.com/hyperium/tonic/discussions/1184 is probably the better place to discuss this. Sorry for the noise!


Change the charging mode

Hello, is it possible to change the charging mode to use the preferred times rather than the immediate charging mode? The Cupra application allows you to do this.
Thank you very much.

Check out the automatically created button.cupra_born_toggle_ac_charge_speed.
By pressing this button I can toggle the charge power between "Maximum" (3kW) and "reduced" (2kW) charging.


chore(storefront): redesign of frontpage

Resolves #1138

Everything looks great from designer perspective and matches the Figma sketches.


Replace broken RTL link

fixes #177

Docs Build status updates of commit 32cc40e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/Xamarin.Forms/Device.xml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 8c027cc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/Xamarin.Forms/Device.xml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Reduce quantity or scope of near-loo searches in an appropriate place

Currently, Undesirable

We ask the API server for every loo within 50km after every movement on the home page
The zoom level allows very wide areas to be looked at and this can lead to slow queries / unresponsive UI

Hard Problems

The area visible at a constant zoom level differs radically across different viewport sizes
The density of loos differs radically between suburban and rural areas
The ideal quantity or radius for a search for nearby loos differs radically across different use cases, e.g.

Looking for your nearest loo
Exploring toilet data across the entire UK
Looking for all loos within a local area

Mitigation
We can at least reduce large API hits at larger zoom levels by doing one 50km request and only requesting again when the user moves outside of these bounds or could have traveled enough for there to be a closer loo than their current 5 closest.
For lesser zoom levels, there is more of an open problem as to how to display useful data while still remaining performant.

I'm going to have to give this some more thought...

This wasn't meant to be closed.


Question about the paper

F is a nonlinear function, why they are equivalent？

Hi, @jameswu2014, thank you so much for your interests in our work.
Given that the matrix ($\Lambda$) is diagonal, for modern large language models (LLMs), the nonlinear activation function commonly used is the SwiGLU, which is element-wise matrix multiplication, therefore, $F(\mathbf{X}\mathbf{W}^T\Lambda ) = F(\mathbf{X}\mathbf{W}^T)\Lambda$  holds true in this context.
Here $\mathbf{W}$ is the up_proj weights, $F(\mathbf{V}) = \mathbf{G} \odot \mathbf{V}$, and $\mathbf{G}$ is outputs of gate_proj, i.e., $F(\mathbf{X}\mathbf{W}^T\mathbf{\Lambda}) = \mathbf{G} \odot (\mathbf{X}\mathbf{W}^T\mathbf{\Lambda}) = (\mathbf{G} \odot (\mathbf{X}\mathbf{W}^T)) \mathbf{\Lambda} = F(\mathbf{X}\mathbf{W}^T)\mathbf{\Lambda}$.

Hi, @jameswu2014, thank you so much for your interests in our work. Given that the matrix (Λ) is diagonal, for modern large language models (LLMs), the nonlinear activation function commonly used is the SwiGLU, which is element-wise matrix multiplication, therefore, F(XWTΛ)=F(XWT)Λ holds true in this context. Here W is the up_proj weights, F(V)=G⊙V, and G is outputs of gate_proj, i.e., F(XWTΛ)=G⊙(XWTΛ)=(G⊙(XWT))Λ=F(XWT)Λ.

Got it, so you mean G(outputs of gate_proj) do not need to be rotated?  the silu op is after gate_proj, so G's precision is fp16, and also  silu's output is fp16, gate_proj gemm is int4xint8->fp16? Is it right?

Hi, @jameswu2014, thank you so much for your interests in our work. Given that the matrix (Λ) is diagonal, for modern large language models (LLMs), the nonlinear activation function commonly used is the SwiGLU, which is element-wise matrix multiplication, therefore, F(XWTΛ)=F(XWT)Λ holds true in this context. Here W is the up_proj weights, F(V)=G⊙V, and G is outputs of gate_proj, i.e., F(XWTΛ)=G⊙(XWTΛ)=(G⊙(XWT))Λ=F(XWT)Λ.

Got it, Firstly, thank you for your reply. But I have several questions about it. so you mean G(outputs of gate_proj) do not need to be rotated? the silu op is after gate_proj, so G's precision is fp16, and also silu's output is fp16, gate_proj gemm is int4xint8->fp16? Is it right?

Hi @jameswu2014. For your questions,

We do not rotate block intermediate activations and thus outputs of gate_proj is not rotated.
All W4A8 GEMM kernels take in int4 weights and int8 activations, use INT8 tensor cores, and generate fp16 outputs.


Persistence

Persistence: Add an option to persist the cache to disk, so that it can be restored after a restart.

after each changes it would be great to update documentation(README.MD)


fix(cmake/modules): correct missing includes for libbpf

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Fix dependencies resolutions for libbpf when not all deps are bundled.
See https://github.com/falcosecurity/libs/pull/1583#pullrequestreview-1784265268
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Update: Stretchly.Stretchly version 1.3.0

Converting singleton to multi-file manifests
Microsoft Reviewers: Open in CodeFlow

@wingetbot run


[stable/external-dns] fix issue 15002

What this PR does / why we need it:
Which issue this PR fixes

fixes #15002

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @cpanato

Issue is fixed with this patch, thanks!

Hey @juan131,
all done. Thanks for the feedback! :)

/ok-to-test
/lgtm


Use soroban contract init command in getting started tutorial

This PR updates the getting started tutorial to use soroban contract init to create a new project, which streamlines the getting started process for new users.
This PR is dependent on the following PRs:

https://github.com/AhaLabs/soroban-astro-template/pull/4
https://github.com/stellar/soroban-cli/pull/1224

Preview is available here:http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Preview is available here:http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

While we're updating the tutorial, can we update the CLI output in the installation part? https://soroban.stellar.org/docs/getting-started/setup#usage
I think it's reflecting an older version and older options in the CLI

Preview is available here:http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/


Cannot install on Debian-based distro

I have a base Ubuntu image that has the ibm-iaccess driver installed.  However, running my build process has recently been failing.  I am using the commands provided in the documentation.
curl https://public.dhe.ibm.com/software/ibmi/products/odbc/debs/dists/1.1.0/ibmi-acs-1.1.0.list | tee /etc/apt/sources.list.d/ibmi-acs-1.1.0.list
apt-get update -y

The image successfully built on June 13 2023, but has been failing since July 1 2023.  See the attached screenshot from my successful build.  The output shows the process installing the libodbc2 and other dependencies successfully.
However, I am now getting the following error:
The following packages have unmet dependencies:
ibm-iaccess:

Depends: libodbc1 but it is not installable
Depends: odbcinst1debian2 but it is not installable
Recommends: unixodbc but it is not going to be installed

It seems like something has changed that it is now requiring old, nonexistent dependencies.

I'm using Ubuntu 23.10.  But I am open to other suggestions.  Attached is the full dockerfile and the output logs showing success and failures.
The successful one was done back in June by our GitLab CICD pipeline.  That one was also installing .NET because this part of a larger base image for our .NET apps that utilize the iaccess driver to query our AS400.
Thanks,
Jeff Scott
From: Kevin Adler @.>
Sent: Tuesday, October 3, 2023 3:08 PM
To: IBM/ibmi-oss-issues @.>
Cc: Jeff Scott @.>; Author @.>
Subject: Re: [IBM/ibmi-oss-issues] Cannot install on Debian-based distro (Issue #45)
[External Email]  This email originated from outside the organization. Review the sender's email address and mouse over links before clicking or responding. Validate any requests or attachments before proceeding. If in doubt, contact the help desk.
Which Ubuntu version are you using? Can you also paste the relevant install log for the failing build as text (not a screenshot).

Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/IBM/ibmi-oss-issues/issues/45*issuecomment-1745801940__;Iw!!AJ42WkbdAfjdAg!lheVEg1lIYV5qK0-44SM-6OMX4Qnhy1bEqDOEJpql7LcaMTAhWH1I8k3QA27LyrhBIXLPxhuVRz-UwGCsD4QPvCUs_B3TIWd$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AZSBHFUDEE32HYZWP4RM25TX5SECLAVCNFSM6AAAAAA5RUABHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBVHAYDCOJUGA__;!!AJ42WkbdAfjdAg!lheVEg1lIYV5qK0-44SM-6OMX4Qnhy1bEqDOEJpql7LcaMTAhWH1I8k3QA27LyrhBIXLPxhuVRz-UwGCsD4QPvCUs07VX44m$.
You are receiving this because you authored the thread.Message ID: @.***>
Base Image
FROM ubuntu:23.10
Run Updates and install PreReqs
RUN apt-get update -y &&
apt-get upgrade -y &&
apt-get install -y curl &&
apt-get clean
Pull Packages and Add Additional APT Repos
RUN curl https://public.dhe.ibm.com/software/ibmi/products/odbc/debs/dists/1.1.0/ibmi-acs-1.1.0.list | tee /etc/apt/sources.list.d/ibmi-acs-1.1.0.list &&
apt-get update -y
Install IBM IAccess Driver
RUN apt-get install -y ibm-iaccess

23.10 isn't even out yet, but you said it has been failing since July so presumably you were using a different image then. Were you using a different image back in June? We only support the LTS releases for Ubuntu (currently 20.04 and 22.04) BTW.

So it looks like libodbc1 and odbcinst1debian2 went away with 23.10 at least. The latest driver <IP_ADDRESS> has fixes for this so it can be installed on 24.04. It may or may not work on 23.10, but we only support LTS releases as mentioned previously.


parsing multiple env files & running the checks selectively

In dotenv you can load multiple env files, by calling .config({}) multiple times with different 'path' parameters.
eg I can do:
dotenv.config({ path: '.env'}); // this contains non-sensitive variables shared by all environments & devs
dotenv.config({ path: '.env.local'}); // this contains dev- or environment-speciffic vars

With dotenv-safe I can't seem to achieve the same behaviour.

If I run

dotenv.config({ path: '.env', example: '.env.template' });
dotenv.config({ path: '.env.local', example: '.env.template' });

I get errors about template vars missing from .env (since it only contains SOME vars - correctly)

If I try

dotenv.config({ path: '.env', example: '' });
dotenv.config({ path: '.env.local', example: '.env.template' });

It complains env.example doesnt exist

I can do:

let dotenv = require('dotenv');
let dotenvsafe = require('dotenv-safe');

dotenv.config({ path: '.env' });
dotenvsafe.config({ path: '.env.local', example: '.env.template' });

But it just feels ugly.
Any advice?
It would be cool if you could do:
dotenv.config({ path: '.env', example: null }); // import files as with plain dotenv
dotenv.config({ path: '.env.local', example: null }); // import files as with plain dotenv
dotenv.config({ example: '.env.template' }); // run the check here

This is an interesting use case, though I've never found the need to import more than 1 .env file (or worked on any project that needed it). I'm inclined towards the require('dotenv') solution, as dotenv is dotenv-safe's only dependency, so there's nothing extra to install. IMO the intent is also clearer, since it's not immediately obvious what example: null, example: undefined or example: ''should do without reading the documentation. It's also possible (although unlikely) that this could happen:
const path = getExamplePath(); // accidentally returns empty string
require('dotenv-safe').config({ example: path });

which would skip validation and silence any errors.
Since there's only one file that you need to load with plain dotenv, you could do this:
require('dotenv').config();
const dotenv = require('dotenv-safe');
dotenv.config({ path: 'foo' });
dotenv.config({ path: 'bar' });

I agree it's not as pretty as the other solution, but the intent seems clearer, there's less risk of mistakes, and you add the same amount of variables to the scope. If others run into this issue and it turns out to be a common use case, I'd be happy to rethink this.


Order:Insufficient funds

Hey everyone,
I got this error on a live server. Is it because of the max API calls?
2018-01-01 03:53:23 (ERROR):	[kraken.js] (getPortfolio) returned an irrecoverable error: General:Permission denied

I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Action taken (what you did)
Restart the program

Expected result (what you hoped would happen)
Working script

Actual result (unexpected outcome)
Error

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)

Query Funds option should be ticked on Kraken API setting.


Update project to modern packages

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


[MM-17155] Deep Linking Landing Page

Summary
This PR contains a new landing page for deep linking. It is based on the work done here: https://github.com/mattermost/mattermost-webapp/pull/2299
Ticket Link
https://mattermost.atlassian.net/browse/MM-17155
Related Pull Requests
Server changes: https://github.com/mattermost/mattermost-server/pull/13362

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 0052f1c8c0ce32bc9d2838dd1f4663f97a492eb2.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

Test server creation failed. See the logs for more information.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 893259386d5776fe390a3a98a9c92d2646705f12.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 92bc67c7298253a8c8fddafdb2cdc5b020c6fe1d.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 95ebb2f8e96cd2dcde4918b46fca6c718b2a1022.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 45edf7c419f6cfa93c7ec340acbed03f5d3fffe7.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit f30560b2911525b36a59aae538e9135bc0c75151.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

recreating the test server...

Test server destroyed

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit b63fac66d242e35a4212ab7cb3dfd63b5dab2340.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

@devinbinnie I cannot seem to get to the landing page with the /vault# route. Can you please post instructions for testing here so design and QA can also test?

Note to testers, access the landing page via "https://mattermost-webapp-pr-4455.test.mattermost.cloud/landing#"
@devinbinnie can you please write out what is testable in this PR for QA?

@esethna I've addressed your feedback, except for the custom logo bit, which I will need @andrewbrown00 's help on. I would imagine we would just resize the logo down to the same height as the provided logo such that it fits on the top bar, what do you think?

New commit detected. SpinWick will upgrade if the updated docker image is available.

@devinbinnie yes that sounds correct, with the site name to the right of it in similarly large font as in the "Where would you like to view this?" text. Also considering the case if there is no logo but there is site name

Mattermost test server updated with git commit 0ee24fb7390b12e40718382b90da75d6fbf9e958.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

@devinbinnie can you review the expected in #2B and #2C from my review above?

@devinbinnie can you review the expected in #2B and #2C from my review above?

@esethna  Misread that sorry, is there a reason we can't just sub in the site name for those strings?

Subbing in the strings doesn't read as well imo. Plus it's possible that people have white labelled the webapp but not built their own custom desktop app (meaning it's still called Mattermost)

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit e3cb42584cdd5a37377b7887b1886f9cb9c43a2f.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

@devinbinnie looks good other than the custom branding piece which I don't think was addressed. Can you ask for a re-review once everything is ready to go?

@andrewbrown00 I think the black MM logo is fine. Also note that we can't use account setting theme variables because the user may not be logged in yet - so all we have access to is server configs which don't contain theme variables

@andrewbrown00 please also test this on mobile safari to verify the mobile version. My iPhone X seems like it's missing some buffer room and the image is blurry:

@andrewbrown00 please also test this on mobile safari to verify the mobile version. My iPhone X seems like it's missing some buffer room and the image is blurry:

@esethna interesting, I'm not seeing the spacing issues on my devices:

iPhone 6 Plus
iPhone 11 Pro Max

@devinbinnie any idea why the image is coming through blurry? Do I need to provide 2x and 3x versions of the image?

New commit detected. SpinWick will upgrade if the updated docker image is available.

New commit detected. SpinWick will upgrade if the updated docker image is available.

@devinbinnie any idea why the image is coming through blurry? Do I need to provide 2x and 3x versions of the image?

I think it's probably due to the compression that webpack does on all the images. I also noticed it on the desktop image. We could try using a larger version for added clarity, is it possible to get a 3x version of the image?

Test server creation failed. See the logs for more information.

Mattermost test server updated with git commit 739b204e52ee1296bcc45058ab9338b13334ce53.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

Test server destroyed

Creating a new SpinWick test server using Mattermost Cloud.

Test server creation failed. See the logs for more information.

Test server destroyed

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit f6d925e777966176a234068a2734dc22c0f39fe9.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

@andrewbrown00 All of your feedback should be addressed.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 716e588b3543801ad7834bfb664488c241028bf8.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

@devinbinnie any idea why the image is coming through blurry? Do I need to provide 2x and 3x versions of the image?

I think it's probably due to the compression that webpack does on all the images. I also noticed it on the desktop image. We could try using a larger version for added clarity, is it possible to get a 3x version of the image?

@devinbinnie thanks for the insight, here are the 3x versions. Let me know why they are up and I'll do another review.
deep-linking-3x.zip

@andrewbrown00 @esethna I've added the 3x images and it doesn't seem to be blurry anymore for me, let me know what you see.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit ba6bc290ea372faa5f5f88caee8e85886b13e7b6.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

@andrewbrown00 @esethna I've added the 3x images and it doesn't seem to be blurry anymore for me, let me know what you see.

@devinbinnie Image is nice and crisp, thanks!

iPhone 6 Plus
iPhone 11 Pro Max

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit d68d3987d398a855a9e6eb0af8a9099e243546d1.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 693befc03c8c2df33a86911c3250bd64e9f1359d.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

/update-branch

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 6e34070ab26fa4bcad680a3488c88cbd2307bf9c.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

/update-branch

Error trying to update the PR.
Please do it manually.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 630758906b1e692d0919d9884b66616145081014.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit d98736921168b60166152a99e82068243ccbec18.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

/update-branch

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 9aafd0f4f481dd8164ad99723e72ae9e9742c676.
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

@devinbinnie
When I open the test server link in Chrome, I only see the Sign In page, same in incognito window. There's no "Where would you like to see this" option. Not sure how to get to it, I tried in Safari and Firefox and clearing cache and still don't see it.
In mobile:
Testing 1234 for site name - is this just a placeholder text?
View in App - tap on the button View in App presents system message and "Opening link in the Desktop App..." below. Wording is confusing and it follows with "Don't have the Mobile App?" see screenshot.
When tapping View in App I expected system message to be overlaid on top of the landing page, so when I tap Cancel on the system message I would remain to the landing page, but it appears that redirect has already started. Is this intended?
Thanks.

@devinbinnie
When I open the test server link in Chrome, I only see the Sign In page, same in incognito window. There's no "Where would you like to see this" option. Not sure how to get to it, I tried in Safari and Firefox and clearing cache and still don't see it.
In mobile:
Testing 1234 for site name - is this just a placeholder text?
View in App - tap on the button View in App presents system message and "Opening link in the Desktop App..." below. Wording is confusing and it follows with "Don't have the Mobile App?" see screenshot.
When tapping View in App I expected system message to be overlaid on top of the landing page, so when I tap Cancel on the system message I would remain to the landing page, but it appears that redirect has already started. Is this intended?
Thanks.

Test server destroyed

Sorry, accidentally clicked close while reviewing 😬 My magic mouse has been freaking out since upgrading to macOS Catalina...

@devinbinnie will you create a new test server, see my previous comment, sorry...

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

@devinbinnie
When I open the test server link in Chrome, I only see the Sign In page, same in incognito window. There's no "Where would you like to see this" option. Not sure how to get to it, I tried in Safari and Firefox and clearing cache and still don't see it.

You'll need to be redirected from a specific link, like an email notification. You can use this link to test:
https://mattermost-webapp-pr-4455.test.mattermost.cloud/landing#/pr4455/channels/town-square

In mobile:
Testing 1234 for site name - is this just a placeholder text?

Yes, when you define a site name and use custom branding, it will display on the landing page. Since I've refreshed the server, it should be reset back to Mattermost.

View in App - tap on the button View in App presents system message and "Opening link in the Desktop App..." below. Wording is confusing and it follows with "Don't have the Mobile App?" see screenshot.

That's a bug, I'll fix that.

When tapping View in App I expected system message to be overlaid on top of the landing page, so when I tap Cancel on the system message I would remain to the landing page, but it appears that redirect has already started. Is this intended?

No it isn't, I'll into that as well.
Thanks for the feedback :)

/update-branch

New commit detected. SpinWick will upgrade if the updated docker image is available.

Test server creation failed. See the logs for more information.

Test server destroyed

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4455.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Test server destroyed


In "UNET for dense prediction",after training and predicting,how to generate the final result?

Everything goes OK before generating the final result.When I run the candidates.py,errors maybe because of the lack of  hoi.mhd and the folder "/data/1_1_1mm_512_x_512_annotation_masks".I have done the previous steps one by one,and also change line 30 to the path of predicted png.I still don't know what hoi.mhd  and the folder "/data/1_1_1mm_512_x_512_annotation_masks" mean,and how they are generated.

I have the same question. Does anyone know how to resolve?

I also have this question, hope someone can help me to fix this issue.

Have you solved this problem? Looking forward to the solution. @eshaoliu


ProGuard tip for android libraries developers

A lot of android libraries (*.aar) don't include their proguard directives and the developers need to search for those configurations on the web and in some cases the information is outdated or incorrect.
The Android Plugin for Gradle automatically appends the ProGuard configuration files in an AAR (Android ARchive) package and appends that package to the application ProGuard configuration, looks like most of the developers don't know this. This pull request adds this information to the README.md of this project.

Great call.


Some work on Elixir 1.1 compatibility

We're moving development to Elixir master in anticipation of Elixir 1.1. I've made some changes to make timex at least compile with the current Elixir master. Unfortunately the Access protocol was used in at least the DateTime parser, so this is broken at the moment.

@MSch I've manually merged some of your changes, and gone through to verify that all the potential Access derivations won't be a problem. I've pushed a new release 0.18.1 which is fully supported on Elixir 1.1.0-dev. Thanks for the heads up!


How can I disable spell checking inside vimcmake buffer

Can someone tell me how to do it?

Do you enable spell checking by default? Then you can set an autocmd for the vimcmake filetype
autocmd FileType vimcmake setlocal nospell

Thanks!


(v2.11) Fixes enums and docBlock -> doc_block

Codecov Report

Merging #178 (0bcd9c4) into feature/types (1c2fbd3) will decrease coverage by 1.89%.
The diff coverage is 38.46%.

@@                 Coverage Diff                 @@
##             feature/types     #178      +/-   ##
===================================================
- Coverage            95.20%   93.31%   -1.89%
- Complexity             139      142       +3
===================================================
  Files                    6        6
  Lines                  438      449      +11
===================================================
+ Hits                   417      419       +2
- Misses                  21       30       +9

Impacted Files
Coverage Δ

src/LaravelRequestDocs.php
99.10% <33.33%> (-0.90%)
:arrow_down:

src/LaravelRequestDocsMiddleware.php
62.16% <40.00%> (-5.54%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kitloong
Please re-review
Please merge all and push the new tag and create the new release
No need for a meeting this Monday


Modal close button is broken in responsive mode

Hi,
First, thanks for this very nice tiny library! When going to https://robinparisi.github.io/tingle/ with a device with a width of less than 540px, the modal close button (X) is a large X over the modal content.

Thanks!

Hi  @Phyks,
It should work now, sorry for the inconvenience.

Thanks a lot!


Pylance intelligence can only take effect after qucik fix is used

Here is an example:

When I click quick fix, delete the content and re-enter it, I can get a prompt, otherwise it doesn't exist.

Is there any way I can get a prompt directly?
I tried to add the following in settings.json:
    "python.autoComplete.extraPaths": [
        "C:\\newPython\\helloFloder\\helloFloder2\\hello.py"
    ],
    "python.analysis.extraPaths": [
        "C:\\newPython\\helloFloder\\helloFloder2\\hello.py"
    ]

I also add the init.py in the folder. But they didn't work.

Hey @ydmykr, would you mind trying setting "python.analysis.indexing":true in your settings.json file? (View > Command Palette... and run "Open User Settings (JSON)").  What you're reporting seems to be the behaviour of when this setting is set to "false", and it looks like there's a bug where we're not setting it to "true" by default.

this is currently by design. currently, we do not add user types in auto import unless it is already used. code action on the other hand, adds all user types. this was a decision to make sure we do not add hundreds of user types in completion list.


Why dont you add an icon

Why dont you add the zstd icon to the nuget package?
https://raw.githubusercontent.com/facebook/zstd/dev/doc/images/zstd_logo86.png

I don't know, am I allowed to use it in my project?

I don't know it's an open source so


ftrace events: use @requires_events on top of hand-specified ftrace_conf

Introduce a metaclass for RTATestBundle that makes sure that the ftrace_conf of each subclass get at least all the events that are needed by their methods when they are decorated using @requires_events.
That avoids duplication of that information and also avoids writing it explicitly in docstrings, since sphinx will add the list of required events using the same information. That also allows setting the required events deep in the analysis functions that actually use it, and then pointing to that through the call chain using @the_analysis_method.used_events.
Also, use that for --list-trace-events that has been revamped and removed at the occasion (removed=there is no CLI option anymore since it is always done by default).
In this PR, I've "ported" synthetic tests to use that system, so they don't need any manual ftrace_conf class attribute to be setup anymore.

@valschneider Updated with all synthetic tests updates and comments addressed.
The events decorators can now be used on any callable, even if it is not a method of instances that have a trace attribute. It should also work on functions without any parameter at all.


apply bert as basic encoder to intergate with classificial architecture, but achieve worse result than original finetuning

I had tried to apply bert as a basic sentence encoder, and stacked on some traditional architecture such as match pyramid, question and passage interaction for downstream task such as nli, qa. But I got worse results compared to originial fintuing. And it took more time to converge than original finetuning...

for using BERT as a sentence encoder, maybe you want to check https://github.com/hanxiao/bert-as-service

BERT is not designed to be a "sentence encoder". If you used the hidden vector corresponding to the [CLS] token as a fixed representation that is certainly bad, because that is not a meaningful representation of the sentence.
Our recommended method of using BERT for classification is fine-tuning, as shown in run_classifier.py. If you want to use BERT for with features, we would recommend some sort of learned pooling over the word tokens, but we don't have a specific recommendation for how to do this since this was not really the focus of the paper.


DynamoDB SDK: Speed up SDK/Table initialization by removing global lock on DescribeTable

Before the DynamoDB can execute an operation on dynamodb, it must first describe the table. Once described it uses the table information for validation etc.
To optimise this, the result of the describe table operation is saved in an in-memory dictionary so to doesn't have to be requested again. It is cached at two levels, sdk wide in the SDKCache, and in a dictionary on the DynamoDBContext itself.
The cache mechanism in DynamoDBContext is very primitive, using a Dictionary<string, Table> to store the table data. Dictionaries are not threadsafe so to guard access to the cache a global lock is used. This means any api call that dynamodb makes must obtain the global lock while it accesses and possibly populates the cache.
The Describe table is a slow API (150-200ms) compared with 5-20ms for a table access (times here are from a Lambda).
In the case where an app accesses multiple dynamodb tables to service a request, this initialization time becomes significant, 3 tables might mean a 600ms delay for the first request.
Describe the Feature
Modify the GetUnconfiguredTable() method to use a ConcurrentDictionary<string, Table> to avoid obtaining a global lock. This would allow concurrent access to the table cache. If I chose to run three queries to different tables concurrently, the sdk initialization can also run in parallel, meaning my api can return in ~200ms rather than ~600.
Is your Feature Request related to a problem?
I'm frustrated at the cold start time of my lambda function, which is partially a result of the DynamoDB SDK running requests in serially rather than in parallel.
Proposed Solution
Existing:
https://github.com/aws/aws-sdk-net/blob/7bed6856e8818181087c7501d93391b04380599e/sdk/src/Services/DynamoDBv2/Custom/DataModel/Context.cs#L38
https://github.com/aws/aws-sdk-net/blob/475822dec5e87954b7a47ac65995714ae1f1b115/sdk/src/Services/DynamoDBv2/Custom/DataModel/ContextInternal.cs#L124-L138
Proposed change:

ConcurrentDictionary<string, Table> tablesMap = new ConcurrentDictionary<string, Table>();

internal Table GetUnconfiguredTable(string tableName)
{
	return tablesMap.GetOrAdd(tableName, (_) => {
		var emptyConfig = new TableConfig(tableName, conversion: null, consumer: Table.DynamoDBConsumer.DataModel,
			storeAsEpoch: null, isEmptyStringValueEnabled: false);
		return Table.LoadTable(Client, emptyConfig);
	});
}

Describe alternatives you've considered

Using different DynamoDB Context objects for different tables, but this is awkward.
During Cold start, use n different contexts to launch n dummy requests, to populate the SDKCache, allowing the DynamoDB context to fall though and behave as expected in the general case.

Additional Context
Alternatively/Additionally speed up the DescribeTable api - though i realise that is a very different ask, not to mention different aws team/division.

Environment
This is particularly impactful in Lambda where cold starts occur more frequently than a traditional app

[x] :wave: I may be able to implement this feature request
[ ] :warning: This feature might incur a breaking change

This is a :rocket: Feature Request

for reference this is the call chain to get to describe table:
Table.LoadTable() from above calls here:
https://github.com/aws/aws-sdk-net/blob/449bb72eccfe78c2bfbd8ee2edbc2a7225e8323b/sdk/src/Services/DynamoDBv2/Custom/DocumentModel/Table.cs#L409-L414
LoadTableInfo() from above calls here:
https://github.com/aws/aws-sdk-net/blob/449bb72eccfe78c2bfbd8ee2edbc2a7225e8323b/sdk/src/Services/DynamoDBv2/Custom/DocumentModel/Table.cs#L128-L134
DescribeTable from above calls here:
https://github.com/aws/aws-sdk-net/blob/449bb72eccfe78c2bfbd8ee2edbc2a7225e8323b/sdk/src/Services/DynamoDBv2/Custom/DocumentModel/Table.cs#L327-L335
this then makes a synchronous api call to dynamo using AmazonServiceClient

@williamdenton. We have a plan to improve overall performance and usability of DynamoDB this year. We can incorporate your request here into our plan. We will post the relevant progress when we get there. Thanks

Hey :wave:, just wanted to mention that I took a stab something similar to this almost a year ago: https://github.com/aws/aws-sdk-net/pull/1678, looking back this is probably not the best pull request (as I was using semaphore slims and not concurrent dictionaries which feel like the better option) but I was trying - at the time - to make small changes so that the pull request would be reviewed faster (apparently I was wrong) but if you want to take inspiration from what I did, go ahead
Also person note: If you run the DDB tests on an actual AWS account and they fail make sure to delete the AWS artifacts other wise you might wake up to a nice hefty AWS bill, speaking from experience (thanks AWS)

Disappointed. Big start up gains for lambda to be had here and no action from the aws team.


Add pipeline examples to documentation

From the current documentation, the deployment process depends on installing the function tools which doesn't seem to be too pipeline friendly. Also it looks like to deploy the function, we would need scripts and cannot rely on the pipeline function tools. Any chances you can provide guidance/clarification on deploying a .net 5 function to azure using a devops pipeline?

So using the standard .net core function deployment, we were able to deploy a function that is using this new worker. No change was required. However, you have to use the command line to create the function app otherwise it will not be using the right runtime and it looks like existing functions cannot be converted.

Closing old issue that it sounds like was resolved. Documentation should have the right coverage for deployment options, but if there's still something missing, we can reopen / create a new issue.


[bug]: InvokeAI taking years to generate on Version 2.3.0+a0

Is there an existing issue for this?

[x] I have searched the existing issues

OS
Windows
GPU
amd
VRAM
64GB
What happened?
I tried using the new version 2.3.0+a0 to install some new custom models. But I have the issue that its taking years to generate images now. I got a good GPU and a lot of VRAM and normally it takes 6-7 seconds for 50 steps to generate 1 image. With version v2.2.5 everything generates smooth and quick but with this new version it takes about over an hour just for 1 image.
So why do I need to use 2.3.0+a0 and not just stay with the v2.2.5 version?
In v2.2.5 a lot of custom models dont work. Like Deliberate for example. I tried everything to get it working but failed over and over again. In 2.3.0+a0 the custom model problem vanishes. I can use any model and even safetensor files work.
Screenshots
No response
Additional context
No response
Contact Details
No response

same but on mac for me

Same. I see that it's only loads the processor and don't use any of videochips.

Same to me, and im using win11

where did you find 2.3.0 version please? Could you share with me? They don't have it in the latest release download page. I only found it in the guide book. I am looking for textual inversion and version 2.2.x don't have it.


Bug: Virtual devices created by Loopback software leave permanent items in eqMac

Disclaimer:
Please go through existing issues to avoid creating duplicates. If you found a similar issue please post a comment there. If you are uncertain your issue is related to others then create the issue. Obvious ignorance of this rule might get you blocked from posting new issues. Please tick the box below to show that you have followed the guideline.

[x] I have checked for a similar issue and sure it hasn't been reported before.

Describe the bug
Using a 3rd-party software called “Loopback”, the user can create multiple virtual devices. However, each creation of virtual device will leave an item in eqMac, even after it is deleted.
Steps to Reproduce
Steps to reproduce the behaviour (feel free to change the placeholder as you need):

Open eqMac
Open Loopback (Note: It's a paid software with free 20-minute trial)
Click on “New Virtual Device”
Click on “Delete”
Repeat step 3 and 4 a few times
Go to eqMac, check the device list

Expected behaviour

Either the deleted virtual devices are automatically removed from eqMac,
Or the user is provided with a menu to manually remove unused devices.

Setup information:

macOS Version: 12.5.1
eqMac Version: 1.5.1
eqMac UI Version: 4.1.2
Loopback App Version: 2.2.9
Loopback ACE Driver Version: 11.8.2

Screenshots or Console.app logs

Hmm yeah that's annoying, I will fix in the next update!
Thank you for reporting this

In update v1.6.1 that you can download now through the Beta Program (enable it in eqMacs settings) I've improved the way I'm caching the devices, plus you can Reset Device cache in Output Settings to clear up the list from the old devices:

Looks good to me.
I think this change can also solve #713.


Fixed hand ray not showing up on Oculus

Overview
Fixed regression with Oculus Hand pointer not displaying properly after moving towards using the Articulated Hand Definition for detecting Teleport Gestures

/azp run

/azp run


Enabled GC of nested container sandboxes by the Mesos agent.

High-level description
What features does this change enable? What bugs does this change fix?
This flips a flag that instructs the Mesos agent to garbage collect
the sandboxes of nested containers, just like the agent currently
GC's executor sandboxes.  Nested containers always run underneath
another active executor, and have in the past been garbage collected
alongside its parent executor.  However, because the default
executor can now potentially run infinite tasks in its lifetime,
the tasks (which are nested containers) can pile up sandboxes.
Note that this flag is technically a breaking change.  A task can
potentially rely on an artifact inside a sibling task's sandbox.
If the sibling task has exited, the sibling's sandbox can now be
garbage collected.  This scenario is however, considered to be
bad practice, as shared artifacts should be placed in the parent's
sandbox or a persistent volume.  The flag can easily be disabled
if this pattern is common in a cluster.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS-39879 Enable GC for nested container sandboxes by default

Related tickets (optional)
Other tickets related to this change:

MESOS-7947 Add GC capability to nested containers
COPS-3238 Edge-LB pool task filled up disk on public agent

Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:  This change should ideally not affect the user at all, as it deals with a particular way the Mesos default executor works.  As long as the bad practice of accessing sibling sandboxes is not a problem, this change should be transparent to the user.
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:  Executing the code enabled by this flag requires the test to either (1) fill up 90% of an agent's disk, (2) wait 2 weeks, or (3) spoof either of the earlier.  These are not practical in an integration test, so the plan is to add a soak test afterwards, instead.
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
-If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:-

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

Looks like the windows failure here is a test infra issue.

Thanks @kaysoky !! Looks like that issue is occurring on DC/OS master right now, seems to be a SHA mismatch in the windows variant of adminrouter. I'll override the failure.

@mesosphere-mergebot override-status teamcity/dcos/build/dcos/windows #3459


Add to slack button not working

The button used to 'Add to slack' in the main page is not working as Jan 23, 2023.

Thanks for reporting, should be working now 🤞
https://lockbot.app/

@connorads broken again...

Thanks @andrewfrankel, taking a quick look now

It's back up now @andrewfrankel

Thanks for the quick turnaround, works again!


Only the headnode should update dashboard data.

OCD run https://ocd.appscale.com:8080/job/Daily Build/1366/

Demo done. Build pending.


Create waleshigh.txt

Wales High School addition.

@Steve136 Pull request merged. Please notice that free educational license for JetBrains tools is for high and higher schools students, i.e. those who are over 13 of age. Thank you!


Figure out a way to deal with key metadata UX-wise

From<EMAIL_ADDRESS>on June 07, 2014 02:39:48
The extension doesn't honor expired keys yet.
Original issue: http://code.google.com/p/end-to-end/issues/detail?id=40

@kbsriram this was fixed right?

cleaning up old bugs, please reopen if you would still like to see this fixed


Support action dispatch in onError hook

Close #126

Coverage increased (+0.03%) to 94.186% when pulling 7f2575a03b1cf25522184bc62ba69222fc87246b on onError-dispatch into bb449e57036badb1ef4638622c506006c0b18a19 on master.

这个应该更新到文档上吧


Could not load type 'Cassette.Trace' from assembly 'Cassette, Version=<IP_ADDRESS>44, Culture=neutral, PublicKeyToken=null'.

I have upgraded Cassette to new version 2.4.2, and then I started getting the below error
Could not load type 'Cassette.Trace' from assembly 'Cassette, Version=<IP_ADDRESS>44, Culture=neutral, PublicKeyToken=null'.
at Cassette.Web.StartUp.PreApplicationStart()
I assume Cassette.Trace is moved to some other assembly. Could you please help

The same is happening to me.

@ManojChala did you find a way to fix it?

Pardon me. Not sure when I asked this. I totally forgot about it because
that task was over.
Regards
Manoj
On Wed, Sep 14, 2022, 6:43 PM Andres Moschini @.***>
wrote:

@ManojChala https://github.com/ManojChala did you find a way to fix it?
—
Reply to this email directly, view it on GitHub
https://github.com/andrewdavey/cassette/issues/485#issuecomment-1246747288,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXTQHE4NFEZS2BPBIA7G3C3V6HFRBANCNFSM5XD5KNGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Finally, I fixed it removing these lines from web.config:
<system.diagnostics>
    <sources>
        <source name="Cassette" switchName="CassetteSwitch" switchType="System.Diagnostics.SourceSwitch" />
    </sources>
    <switches>
        <add name="CassetteSwitch" value="All" />
    </switches>
</system.diagnostics>


Set appliance state- example

Would it be possible to add a Python example how to set appliance state?

@nbogojevic It would be very helpful if you would expand your documentation to show setting states. Thank you very much!

A very rough example I found working. For example Switch on my air conditioner
apps = find_appliances(....)
app = apps[0]
app.state.running = True
app.apply()

You can find the properties for your appliance in appliance.py and you can use properties marked with the setter decorator.


Definition of Hz as 1/s doesn't work

I added it to example.cpp as a very simple testcase.
Code:
auto _Hz = 1 / _s;

g++ 4.9.2 error message:
In file included from example.cpp:26:0:
units.hpp: In instantiation of ‘constexpr typename std::enable_if<std::is_arithmetic<_Tp>::value, unitscxx::quantity<NT, N, D> >::type unitscxx::operator/(MulType, unitscxx::quantity<NT, N, D>) [with MulType = int; NT = double; N = detail::sequence<units, (units)1>; D = detail::sequence<units>; typename std::enable_if<std::is_arithmetic<_Tp>::value, unitscxx::quantity<NT, N, D> >::type = unitscxx::quantity<double, detail::sequence<units, (units)1>, detail::sequence<units> >]’:
example.cpp:43:16:   required from here
units.hpp:367:36: error: could not convert ‘unitscxx::quantity<double, detail::sequence<units>, detail::sequence<units> >((double)left).unitscxx::quantity<NumericType, Numerator, Denominator>::operator/<double, detail::sequence<units, (units)1>, detail::sequence<units> >(right)’ from ‘unitscxx::quantity<double, detail::sequence<units>, detail::sequence<units, (units)1> >’ to ‘std::enable_if<true, unitscxx::quantity<double, detail::sequence<units, (units)1>, detail::sequence<units> > >::type {aka unitscxx::quantity<double, detail::sequence<units, (units)1>, detail::sequence<units> >}’
   return unitless_quantity(left) / right;
                                    ^
units.hpp:368:2: error: body of constexpr function ‘constexpr typename std::enable_if<std::is_arithmetic<_Tp>::value, unitscxx::quantity<NT, N, D> >::type unitscxx::operator/(MulType, unitscxx::quantity<NT, N, D>) [with MulType = int; NT = double; N = detail::sequence<units, (units)1>; D = detail::sequence<units>; typename std::enable_if<std::is_arithmetic<_Tp>::value, unitscxx::quantity<NT, N, D> >::type = unitscxx::quantity<double, detail::sequence<units, (units)1>, detail::sequence<units> >]’ not a return-statement
  }
  ^

clang++ 3.5.0 error message:
In file included from example.cpp:26:
./units.hpp:367:10: error: no viable conversion from 'quantity<[...], sequence<[...], (no argument)>, sequence<[...], 1>>' to 'quantity<[...],
      sequence<[...], 1>, sequence<[...], (no argument)>>'
                return unitless_quantity(left) / right;
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
example.cpp:43:14: note: in instantiation of function template specialization 'unitscxx::operator/<int, double, detail::sequence<units, 1>,
      detail::sequence<units> >' requested here
auto _Hz = 1 / _s;
             ^
./units.hpp:228:13: note: candidate constructor not viable: no known conversion from 'unitscxx::quantity<double, detail::sequence<units>,
      detail::sequence<units, 1> >' to 'const unitscxx::quantity<double, detail::sequence<units, 1>, detail::sequence<units> > &' for 1st argument
                constexpr quantity(const quantity&) = default;
                          ^
./units.hpp:229:13: note: candidate constructor not viable: no known conversion from 'unitscxx::quantity<double, detail::sequence<units>,
      detail::sequence<units, 1> >' to 'unitscxx::quantity<double, detail::sequence<units, 1>, detail::sequence<units> > &&' for 1st argument
                constexpr quantity(quantity&&) = default;
                          ^
1 error generated.

Also, for everything else to work with g++ 4.9, I first had to make a small change to the header file (see the second revision of my gist). Anyway, I don't really understand what this error message says.

I'm looking into it.

Le 20 janv. 2016 à 13:39:02, Jonas Platte<EMAIL_ADDRESS>a écrit :
I added it to example.cpp as a very simple testcase.
Code:
auto _Hz = 1 / _s;
g++ 4.9.2 error message:
In file included from example.cpp:26:0:
units.hpp: In instantiation of ‘constexpr typename std::enable_if<std::is_arithmetic<_Tp>::value, unitscxx::quantity<NT, N, D> >::type unitscxx::operator/(MulType, unitscxx::quantity<NT, N, D>) [with MulType = int; NT = double; N = detail::sequence<units, (units)1>; D = detail::sequence; typename std::enable_if<std::is_arithmetic<_Tp>::value, unitscxx::quantity<NT, N, D> >::type = unitscxx::quantity<double, detail::sequence<units, (units)1>, detail::sequence >]’:
example.cpp:43:16:   required from here
units.hpp:367:36: error: could not convert ‘unitscxx::quantity<double, detail::sequence, detail::sequence >((double)left).unitscxx::quantity<NumericType, Numerator, Denominator>::operator/<double, detail::sequence<units, (units)1>, detail::sequence >(right)’ from ‘unitscxx::quantity<double, detail::sequence, detail::sequence<units, (units)1> >’ to ‘std::enable_if<true, unitscxx::quantity<double, detail::sequence<units, (units)1>, detail::sequence > >::type {aka unitscxx::quantity<double, detail::sequence<units, (units)1>, detail::sequence >}’
return unitless_quantity(left) / right;
^
units.hpp:368:2: error: body of constexpr function ‘constexpr typename std::enable_if<std::is_arithmetic<_Tp>::value, unitscxx::quantity<NT, N, D> >::type unitscxx::operator/(MulType, unitscxx::quantity<NT, N, D>) [with MulType = int; NT = double; N = detail::sequence<units, (units)1>; D = detail::sequence; typename std::enable_if<std::is_arithmetic<_Tp>::value, unitscxx::quantity<NT, N, D> >::type = unitscxx::quantity<double, detail::sequence<units, (units)1>, detail::sequence >]’ not a return-statement
}
^
clang++ 3.5.0 error message:
In file included from example.cpp:26:
./units.hpp:367:10: error: no viable conversion from 'quantity<[...], sequence<[...], (no argument)>, sequence<[...], 1>>' to 'quantity<[...],
sequence<[...], 1>, sequence<[...], (no argument)>>'
return unitless_quantity(left) / right;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
example.cpp:43:14: note: in instantiation of function template specialization 'unitscxx::operator/<int, double, detail::sequence<units, 1>,
detail::sequence >' requested here
auto _Hz = 1 / _s;
^
./units.hpp:228:13: note: candidate constructor not viable: no known conversion from 'unitscxx::quantity<double, detail::sequence,
detail::sequence<units, 1> >' to 'const unitscxx::quantity<double, detail::sequence<units, 1>, detail::sequence > &' for 1st argument
constexpr quantity(const quantity&) = default;
^
./units.hpp:229:13: note: candidate constructor not viable: no known conversion from 'unitscxx::quantity<double, detail::sequence,
detail::sequence<units, 1> >' to 'unitscxx::quantity<double, detail::sequence<units, 1>, detail::sequence > &&' for 1st argument
constexpr quantity(quantity&&) = default;
^
1 error generated.
Also, for everything else to work with g++ 4.9, I first had to make a small change to the header file (see the other revision of my gist). Anyway, I don't really understand what this error message says.
—
Reply to this email directly or view it on GitHub https://github.com/zneak/units-cxx14/issues/2.

Templates are notoriously ugly to debug, but I think that unitscxx is actually on the more straightforward side.
quantity represents an arithmetic value of type NumericType multiplied by units Numerator and divided by units Denominator. Numerator and Denominator are sequences of enum values (detail::sequence<type, element1, element2, ...>). So what it (gcc) is saying is:
units.hpp:367:36: error: could not convert ‘[mostly irrelevant]’ from:

unitscxx::quantity<double,
	detail::sequence<units>,            // multiplied by no units
	detail::sequence<units, (units)1> > // divided by (units)1: units::second
										// (double) / (units::second)
to:

[mostly irrelevant] {aka
unitscxx::quantity<double,
	detail::sequence<units, (units)1>, // multiplied by (units)1: units::second
	detail::sequence<units> >}         // (double) * (units::second)

This means that the return expression had type 1/_s but the overload declared its type to be 1•_s, which is wrong. It's a simple copy-paste error in the return type definition, the fix is to change quantity<NT, N, D> to quantity<NT, D, N> (since dividing flips the denominator and numerator around).

Awesome, thanks a lot for the quick replies and fixes!


Fix

I was hoping for non known bugs... but compress("P") didn't work. This at least fixes that, but I'm not sure what the largest expansion is, so this might only be a partial fix.
I would have to read the spec again, and since there are corner-cases that aren't documented, e.g. illegal UTF-8 strings, I wouldn't find out.

@PallHaraldsson  The spec does not talk about invalid UTF-8 strings.  It is just that the implementation tries to get better ratio by finding UTF-8 sequences in binary inputs such as executables and compress the invalid ones using the inefficient method for encoding binary bytes:
https://github.com/siara-cc/Unishox2/blob/a8fb6bf555d3419011223a2dff97f7baf5f94c8c/unishox2.c#L818
https://github.com/siara-cc/Unishox2/blob/a8fb6bf555d3419011223a2dff97f7baf5f94c8c/paper/paper.md?plain=1#L309

I did see somewhere in the docs explicitly stated expansion possible, and in your defense trying to find it back I very prominently see on Github, the main page (to the right), which is simply untrue: "Guaranteed compression for Unicode short strings".
Except for lower case English (plus space). I didn't think it through, but 2x might be enough for upper case too, and possibly all of ASCII. For full Unicode, which the output can be more than 3 bytes if I recall, but the input would be 2+ bytes, so I'm unsure we need to go to 3x.

I removed the 'Guarantee' everywhere else.  The guarantee is only for real life scenarios.  It is documented in the pdf for Unishox1, but I removed it since it could be misleading. https://github.com/siara-cc/Unishox2/blob/master/Unishox_Article_1.pdf?raw=true

Can you also add some tests for the string that you found that gave issues?


♻ Refactor Focus Manager Event Handling for Enhanced User Experience ✨

As you can see, the focus manager currently listens to both visibilitychange and focus events by default.
I believe it may be beneficial to consider discontinuing the listening to focus events and solely rely on visibilitychange events.
My rationale behind this proposal is that we might be supporting both events primarily for historical reasons. It is worth noting that visibilitychange was not fully supported in older browsers that are no longer relevant (e.g., IE11).
The focus event has proven to have various pitfalls, as it can be triggered in the following scenarios:

Navigating between the application and DevTools.
Closing an alert or confirm dialog.
Interacting with a file upload dialog.
Interacting with an iframe.

These scenarios have the potential to result in a suboptimal user experience.
This pull request is inspired by this reference PR.

Like it, although there're some tests that we need to update.

Like it, although there're some tests that we need to update.

Ok, sure! But could you please guide me through it? I apologize for any inconvenience caused.

Most of tests are based on focus event and fireEvent.focus. I guess you need to replace the focus event with visibilitychange event like what @tanstack/query did

Most of tests are based on focus event and fireEvent.focus. I guess you need to replace the focus event with visibilitychange event like what @tanstack/query did

Okay :)

Hi (@promer94 , @shuding ),
I apologize for the inconvenience, but I'm having trouble updating the test code correctly. I'm not familiar with the process, and I don't want to risk introducing errors or breaking anything. Could someone please lend me a hand and guide me through the correct steps? I'm sorry for any delays this may cause, and I truly appreciate your assistance.

https://github.com/TanStack/query/pull/4805/files#diff-3cd8cae55f836a38ea976d6cbf9f1b59e8fdfa4d3218b123cb1f9dccfc6824d2
I am sure what blocks you but i think this diff clearly shows what you need to do here.

Changes look good to me but this might need to be landed in v3 as it's breaking.

Changes look good to me but this might need to be landed in v3 as it's breaking.

Okay 🙌
And thanks a lot @promer94

👀

Changes look good to me but this might need to be landed in v3 as it's breaking.

Any updates on how close is the v3? Can we have like future flags or a canary channel?


Question on hybrid ref pt 2d

        ref_2d_hw = self.ref_2d_hw.clone().expand(bs, -1, -1, -1)
        hybird_ref_2d = torch.cat([ref_2d_hw, ref_2d_hw], 0)

Firstly appreciate your work,
and I wonder why you concatenate the ref pts of hw for 2 layers as shown above.
Thanks a lot.

Hi, the code is built upon BEVFormer. BEVFormer has both temporal version and spatial-only version. BEVFormer concatenates the current ref_2d and the aligned ref_2d_shift from another timestamp in its temporal version, while concatenating two same ref_2ds for the spatial-only version.
Since TPVFormer does not use temporal information, we simply follow the practice of BEVFormer.

Thanks for your answer


Several text and line endings fixes.

I'm going to apply these changes manually to the base branch.


Identify unique data properties

Right now, the app will fetch the current list of inmates and then saves them to the database. It will gladly save duplicate data and there is no understood method to track updates vs new records.
There are a few properties on the returned data that have unknown meaning/format, namely bookhandle and bookno. After a few runs of the bot, we should make an attempt to know which properties (if any, or both) might be a reliable unique identifier.
Ideally, we'd want to be able to know what is a new arrest vs an updated arrest. This could help us identify when we need to update an existing record (e.g. The record initially did not have a mugshot or certain charges, but now it does) vs when we need a new record for an existing person (e.g. An inmate was in the jail, then released, then arrested again on the same day).
If we can determine a reliable unique identifier for an InmateRecord, then we should be able to answer these questions pretty easily.
Research on the topic should be posted here. The inline JSdocs should also be updated to reflect this information once it is known.

After a day of data scrapes, I've identified a few patterns that lead me to think these are true:

Both bookhandle and bookno are a consistent identifier for the duration of the inmate stay
Both values resemble an auto-incrementing value, although I seem to have some gaps in the counts. Even with gaps, the offset is the same for both values (.e.g 2544 = 20002031 and 2549 = 20002036)

I have also noticed these (but am not sure if they are always true):

The datetimebooked and name values never change during the stay
Most other values (outside of the book IDs) can and do change
Some records have mugshots from their very first appearance in the system, others have them added later.

I think it's sane to use bookhandle and/or bookno as consistent identifiers. They could be used to calculate a hash that serves as a persistent "stay ID" value.

After more days of data gathering, it seems as though the above statement still holds true.
Closing this ticket.


Using getBoundingClientRect() Method?

I wanted to test some code that uses the getBoundingClientRect() method with jsdom, but always get zeros in the returned value after applying styles like left, top, width, etc to the DOM node. This seems related to #1435 in that these styles wont be reflected in getBoundingClientRect since there is no viewport, but I wanted to see if this was actually the case, and if so, if there is any work-around.
Is my best option (aside from decoupling my code from the viewport) using something like phantom or smokestack?

jsdom doesn't do any layouting, so stuff like that won't be possible.

Thanks @Sebmaster!