[MB-5925] DTOD SOAP Connection

Description
First part of the DTOD service object that will get distance mileage from the DTOD SOAP service.
This is able to connect successfully to the service and send a request.
Not implemented
The response is not parsed for this PR, but will be part of the next story to implement parsing the response.
Reviewer Notes
Is there anything you would like reviewers to give additional scrutiny?
Setup
Since this is a service that connect to an outside service. There are no already running UT. But there is a UT that can commented out to test the code locally.
After running make server_test uncomment out the code in the the test function TestDTODZip5Distance then run the test:
go test ./pkg/services/dtod_planner -v

Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots
n/a

Messages

:book:
:link: MB-5925

  Generated by :no_entry_sign: dangerJS against 3c446334bdc3841bdd0a5abeadaafb74161f1232


Emulate scrolling when in alternate buffer that doesn't support the mouse

This fixes scrolling in less, for instance.
This is only enabled when prevent-scroll-for-fullscreen-alternate-buffer is enabled.

Sorry, I've snuck a couple of other commits in there, which I realise is a bit cheeky. I'll create separate branches if you're not keen on merging the lot.

Hey, thanks for sending this along! I love it. :)
No, I actually appreciate having multiple commits, but I would ask you a favor: can you instead separate it into the commits that add behavior and the commits that refactor and/or format the code?
It's really difficult to tell, for example, what you changed in the second commit to fix the scroll-up/enter copy-mode vs what is just a refactoring/formatting change.
Thanks for sending this along though! I think overall it looks great.

Regarding testing, I've tested it on my Mac (10.11.4) and on Ubuntu (14.04). Can anyone out there with a POSIX OS check this over before I check it in? @corv89, would you mind helping out again? Thanks.

OK, I've refactored the changeset to introduce the whitespace changes first, so the alterations to the binding logic should be a bit clearer.

Love it. This looks great. Thanks so much again! Exciting change. It might be worth renaming the option now, since it's not really "prevent-scroll-for-fullscreen-alternate-buffer," but actually more like emulate scroll.

Also, are there any alternate screen buffers where up/down might be problematic? I tried other things that don't have a concept of scrolling, like top, but everything seemed okay. Is there anything else we should be worried about?

Yes, it could be worth renaming the option to something like emulate-scroll-for-mouse-unaware-alternate-buffers, although that's quite a mouthful!
I don't think there are likely to be any programs that have an issue with this: most programs that don't support some kind of up/down motion with the keyboard arrows will simply ignore those events. It might cause some odd behaviour in e.g. console-based games that don't support mouse events. Those might do something unexpected if they receive a lot of up and down keys, but the solution is simply to not use the mouse when using a program like that :p
FYI, this is the behaviour that Konsole uses, which is exactly why I want tmux to have the same behaviour. I originally helped figure out a patch for tmux to produce this behaviour in 2014, but it was put on hold because Nicholas was planning the new mouse binding feature that permits this kind of scripting. I only just got around to looking into it again :)

:) Haha, okay sounds great! Yeah I really love this. I've tested it on my mac and ubuntu, and it works great. I'll merge this in now! Thanks again for your help!

I've opened #16 to track changing the name of that option (and to add this to the README). I'm currently thinking @emulate-scroll-for-no-mouse-alternate-buffer. It's actually shorter than the old option name! :p
Please add any comments you have there, otherwise i'll just go ahead and change it to something like that at some point. :) Thanks again!


Where doesn't support NULL values

See #39

I'm working on this. I'll release new version as soon.
Thanks.

Hi @KrzysztofMadejski ,
I just released new version and added those methods in the library. You could examine documentation.
Thanks.


Query backend improvements

Chained conditions are now stored in a local
registry, rather than as linked objects
QueryBuilder renamed to Selector
Selector interface improvements

Fixes #86


Decouple state from tests in AbstractTestHiveClient

Decouple the testing fixture and runtime from the tests so that they
can be plugged in by concrete plugin implementations as needed.
This solves an issue where setup methods in children would be invoked
non-deterministically by TestNG, and also helps clean up and untangle
that code.

I can't finish the review.  Github won't show the diff for AbstractTestHiveClient.java.  When they fix it.  It will review

Did you move these tests out of the CI profile by mistake? (See the Travis failure)

That's strange. No, I didn't move them out.

Ugh. This is what's causing it: http://stackoverflow.com/questions/11359610/exlude-group-doesnt-work-for-constructor
I have some ideas about how to work around it.

Stupid testng creates test classes even if they are in an excluded group. This means that using any form of constructor injection (e.g., via guice integration support) is pointless. I haven't been able to come up with a reasonable workaround, so for now, I'm taking a different approach to unblock the build:
https://github.com/facebook/presto/pull/3916

Closing for now.


Update Analyzer Dependency

closes #361

This PR needs to be published to pass these checks. https://github.com/gql-dart/gql/pull/328

I think you need to run code generation on the test packages and include the generated code in your PR.
packages like ferry_test_codegen intentionally contain generated code so we see if the generated code changes.

please revert fd98ba9 again.
The code gen is omitted on purpose to make sure that the generated code checked in the repository actually matches the real generated code.

Nice! let me test this locally on my real app as smoke test.

LGTM


Allow customization of API Versions when using Helm Template

Signed-off-by: Bhargav Nookala<EMAIL_ADDRESS>
What this PR does / why we need it:
Resolves https://github.com/helm/helm/issues/3377 for helm template.
This PR adds --api-version (or -a) to add custom API versions to Capabilites.APIVersion, allowing a user to correctly render templates that depend on certain API versions.
Special notes for your reviewer:
If applicable:

[x] this PR contains unit tests
[x] this PR contains documentation

hi @bacongobbler - would you be able to take a look at this addition to helm template?

+1

This would be very useful!

Agree, would be nice if this is going to be merged!

Pending on this feature to be available.

+1

I like this @bnookala !
Could we have this feature in helm3 / "dev-v3" branch as well, please?

might also be worth to rebase against master once more now that #6577 has been merged. It includes a fix where coreutils was bumped underneath us, causing CI to fail :) thanks @bnookala!

@bacongobbler oh for sure, can totally do that - do you have a suggestion on where the docs should live? at a quick glance, thinking the "thinking about charts" section might be a good option: https://helm.sh/docs/using_helm/#thinking-about-charts

@bnookala I would actually suggest somewhere here: https://helm.sh/docs/chart_template_guide/#debugging-templates
Info on the template command was never added there and would be useful to have


enhance README with Docker Colima and syntax improvements

Dup of #65 I accidentally closed it @dtanner sorry about it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.PraveenKumar.K seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


fix query with criteria

Coverage remained the same at 96.721% when pulling e8afda0e58c941533cf626524611552d3f85d6a0 on feature/fixJournaling into d2878f72925c918bd5fa3bfe452030c736bbd6a8 on develop.


Image component displays title only if isDisplayTitlePopup is false

https://github.com/Adobe-Marketing-Cloud/aem-core-wcm-components/blob/master/content/src/content/jcr_root/apps/core/wcm/components/image/v1/image/image.html
${image.title}

This should obviously be:
${image.title}

This is not a bug. As you've mentioned in #23, you have the option to check the "Display caption as pop-up" option in the edit dialog. The info pop-up provides the following details:

When checked, the caption won't be displayed below the image, but as a pop-up displayed by some browsers when hovering over the image.


OLAF outputs the induced velocity field of the wake

Dear all,
1.I want to calculate the result as a standard spiral helix of the wake,What parameters do I need to modify to make tip vortices and root vortices behave completely? (use uniform wind)

2.Based on question 1, I think it is possible that the WAKE EXTENT AND DISCRETIZATION in the Helix_OLAF file is related to the WAKE REGULARIZATIONS AND DIFFUSION.
3.In addition, WakeLength is set to 900 by default, so the total wake is calculated by multiplying DT by 900 in the fst file?
If I want to get a wake velocity field with 10 times the rotor diameter, am I modifying WakeLength?
4.The fourth question is also related to the above. I did not find the relevant parameters of output wake velocity field. I want to achieve the velocity field in the plane from 1 times of rotor diameter to 10 times of distance from the hub, just like the Y-Z plane of the output of Fast.Farm. Or the velocity at the hub along the X axis at different rotor diameters.
Thanks all,
Best wishes,

Hi,
I would recommend that you have a look at the guidelines for OLAF
https://openfast.readthedocs.io/en/dev/source/user/aerodyn-olaf/RunningOLAF.html
These guidelines apply to the latest dev version. The dev version renamed some variables and introduced one extra parameter (nNWPanelsFree).

Can you clarify what you mean by behave completely? the Helical wake example has no rollup, no distortion of the wake, it’s a pure helix, because it’s using a large value of FreeWakeStart
Regularization and wake length are not related. The parameter may increase with downstream distance when using “age” as a regularization method.
Yes that is correct. The guidelines will help answer your question, but you do need to account for the wind speed.
the grid outputs of Olaf might do what you want. You can check the documentation for these outputs on readthedocs.
I hope some of it will help!


Cannot render tiles with React16, Leafletjs 1.3.3 and React-Leaflet 2.0

Hi,
I cannot get this to render the vector tiles under React16, Leafletjs 1.3.3 and React-Leaflet 2.0 as context is not passed to the child object (it is just undefined).
Line 117
var _context = this.context,
map = _context.map,
pane = _context.pane,
layerContainer = _context.layerContainer;

I am working on a solution but any assistance would be appreciated.

Same to me. Lemme know if u find the solution, I will try as well at mean time

@cre8te https://react-leaflet.js.org/docs/en/context.html

Latest release is published and tested. Works with<EMAIL_ADDRESS><EMAIL_ADDRESS>and<EMAIL_ADDRESS>Closing this now.


Provide NPM package

hi
Would it be possible for you to package your work also as npm package?
This would make it much easier to install the css lib into an existing Javascript/Typescript project.
Thanks. :)

Hi,
That's definitely something we'll do in the near future.

Here it is! npm i selekkt-skelet
let me know if it works correctly.

works, thank you. 👍


[FS-1537]Component/Update create errors

What does this PR do
This PR fix the error
{"level":"info","ts":1718785815.973932,"caller":"syslog/receiver.go:113","msg":"host=<IP_ADDRESS> facility=daemon severity=INFO app-name=runner-3623e994-636b-4ed5-b68b-7f748e6a2372 procid=3013 msg=\"{\\\"level\\\":\\\"error\\\",\\\"msg\\\":\\\"1 error occurred:\\\\n\\\\t* Server Component create/update error: CreateComponents: hollow client received a server error - response code: 400, message: , details: models: unable to insert into server_components: pq: duplicate key value violates unique constraint \\\\\\\"idx_server_components\\\\\\\": inventory query returned error: inventory query returned error: inventory query returned error\\\\n\\\\n\\\",\\\"time\\\":\\\"2024-06-19T08:30:15Z\\\"}\\r\\n\"","service":"github.com/tinkerbell/boots","pkg":"syslog"}

When creating components for test server.
without the code, the serial number of power supply will be "To Be Filled By O.E.M." which will duplicate with other power supply.
How can this change be tested by a PR reviewer?
Added the tests in Test_ToComponentSlice by adding a new psu there with serial number as "To Be Filled By O.E.M" and test will catch it becomes 2 to prevent the duplicate.

Thanks for the fixes !!


Insiders build - notebooks broken due to missing module

Issue Type: Bug
@corivera  please work on this, caused by your checkin
Download latest insiders, start and do New Notebook. It'll fail. Open developer tools, will see:
[Extension Host] Can't load string bundle for /Users/kevcunnane/Downloads/Insiders/Azure Data Studio.app/Contents/Resources/app/extensions/notebook/out/jupyter/jupyterController.js (at Object.loadMessageBundle (/Users/kevcunnane/Downloads/Insiders/Azure Data Studio.app/Contents/Resources/app/extensions/notebook/node_modules/vscode-nls/lib/main.js:133:21))
Zone.__load_patch.consoleMethods.forEach.console.(anonymous function) @ /Users/kevcunnane/Downloads/Insiders/Azure Data Studio.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:2280
/Users/kevcunnane/Downloads/Insiders/Azure Data Studio.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:2280 [Extension Host] Can't load string bundle for /Users/kevcunnane/Downloads/Insiders/Azure Data Studio.app/Contents/Resources/app/extensions/notebook/out/common/localizedConstants.js (at Object.loadMessageBundle (/Users/kevcunnane/Downloads/Insiders/Azure Data Studio.app/Contents/Resources/app/extensions/notebook/node_modules/vscode-nls/lib/main.js:133:21))
Zone.__load_patch.consoleMethods.forEach.console.(anonymous function) @ /Users/kevcunnane/Downloads/Insiders/Azure Data Studio.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:2280
[Extension Host] Activating extension 'Microsoft.notebook' failed: Cannot find module 'request'. (at Object.showMessage (/Users/kevcunnane/Downloads/Insiders/Azure Data Studio.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:53854:41))
Zone.__load_patch.consoleMethods.forEach.console.(anonymous function) @ /Users/kevcunnane/Downloads/Insiders/Azure Data Studio.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:2280
/Users/kevcunnane/Downloads/Insiders/Azure Data Studio.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:2280 [Extension Host] Activating extension Microsoft.notebook failed:  Cannot find module 'request' (at /Users/kevcunnane/Downloads/Insiders/Azure Data Studio.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:31357:25)
Zone.__load_patch.consoleMethods.forEach.console.(anonymous function) @ /Users/kevcunnane/Downloads/Insiders/Azure Data Studio.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:2280
/Users/kevcunnane/Downloads/Insiders/Azure Data Studio.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:2280
Azure Data Studio version: Azure Data Studio 1.5.0-insider (cc97198fe4b6f5b715addbda889e06900af8e08b, 2019-02-21T03:10:36.976Z)
OS version: Darwin x64 18.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
4, 4, 4

Memory (System)
16.00GB (0.17GB free)

Process Argv
/Users/kevcunnane/Downloads/Insiders/Azure Data Studio.app/Contents/MacOS/Electron -psn_0_1233197

Screen Reader
no

VM
0%

Extensions (5)

Extension
Author (truncated)
Version

vscode-sanddance
dan
0.0.1

newdatabase
kev
0.0.3

agent
Mic
0.36.1

server-report
Mic
0.1.4

sql-vnext
Mic
0.10.2

I remember @YurongHe had this issue before, I'm not sure what they did to solve it. I believe @kburtram was helping.


Cannot access a disposed object

I'm getting this error where it's telling me that my context is already disposed so I cant access it anymore. I've this trigger implemented in my Order.cs class, which basically updates the order status,
static Order()
{
    Triggers<Bill>.Inserted += async e =>
    {
        await PaymentStatusChangeNotifierAsync(e);
    };
}

Following is the PaymentStatusChangeNotifierAsync code,
private static async Task<int> PaymentStatusChangeNotifierAsync(IEntry<Bill, Microsoft.EntityFrameworkCore.DbContext> e)
{
    Task.Factory.StartNew(() =>
    {
        var orderedItems = e.Context.Entry(e.Entity.Order)
                                .Collection(o => o.OrderItems).Query()
                                .Where(wi => wi.OrderId == e.Entity.OrderId);

        var paidAmountSumation = e.Entity.Order.Bills.Sum(b => b.PaidAmount);

        var orderedItemAmountSumation = orderedItems.Sum(oi => oi.Quantity * (oi.UnitPrice - oi.Discount));

        if (paidAmountSumation == 0)
            e.Entity.Order.PaymentStatus = PaymentStatus.Unpaid;
        else if (paidAmountSumation == orderedItemAmountSumation)
            e.Entity.Order.PaymentStatus = PaymentStatus.Paid;
        else
            e.Entity.Order.PaymentStatus = PaymentStatus.PartialPaid;
    }).Wait();

    return await e.Context.SaveChangesAsync();
}

The await PaymentStatusChangeNotifierAsync(e); occasionally gives me the following exception.

Cannot access a disposed object. A common cause of this error is disposing a context that was resolved from dependency injection and then later trying to use the same context instance elsewhere in your application.

Is there any problems with my trigger implementation?

Hi Fiyaz!
The issue is that your trigger handler is asynchronous and at the moment this library does not support that.
Also, I'm curious why you're creating a new Task inside your  asynchronous handler?
You get the error sometimes because the context is disposed after it is used, but your handler may still be trying to run in some other thread. Since your handler makes use of the e.Context object, it may or may not be disposed by the time your handler code runs. Basically this is thread-unsafe.
Some simple fixes are:

Inside your asynchronous handler code, create a new context instance and use that one

NOTE: you're doing payment stuff here, which should definitely be in one single transaction... so don't use this option

Make your handler code synchronous

Have all your handlers synchronous and use the e.Context object which keeps it as one transaction
Outside of the handler (where you actually add Bill objects to your context, call the SaveChangesAsync so the entire transaction is run outside your calling thread.

Cheers.

I think i get the idea. Sorry I left the Task.Factory.StartNew in the code. Actually I was trying different things to get rid of that problem. But now I know that the handlers can't be asynchronous! Thanks @NickStrupat 👍


[Bug] Functions not async

As far as i can see the function_handler param can not accept an async function.
This is very limiting because i want to handle function calls by calling async methods and stuff.
Can you please fix this ?

love the tool for the rest though

any updates on this ?

Hey @Eggwise.
If you are referring to the function_handler property used in the OpenAI Functions section, these should be able to handle the async functions.
Could you give me a code example where that does not work please.
Thankyou!

Hi Ovidijus,
An error is shown when the assistant tries to call a function and the function_handler attribute is async.

const getDefaultConnectionConfig = () => ({
  openAI: {
    key: localStorage.getItem("OPENAI_API_KEY"),
    assistant: {
      assistant_id: "...",
      async function_handler(functionsDetails) {       //when this is not async it works just fine
    ...
      }
    },
  },
});

@OvidijusParsiunas

Hey @Eggwise.
Because the functionsDetails argument is an array, we expect you to return a string array or an array of string Promises (string[] | Promise<string>[]).
So in your example, you can change it to something like this:
async yourAsyncFunction(functionDetails) {
  ...
}

const getDefaultConnectionConfig = () => ({
  openAI: {
    key: localStorage.getItem("OPENAI_API_KEY"),
    assistant: {
      assistant_id: "...",
     function_handler: (functionsDetails) => {
          return functionsDetails.map((functionDetails) => yourAsyncFunction(functionDetails));
        }
    },
  },
});

Let me know if you have any questions.
Thanks!

Hey @Eggwise.
Wanted to give you another update that I have made changes to make your original code work. This is now available in deep-chat-dev and deep-chat-react-dev packages version 9.0.194. These packages behave exactly the same as the core ones except their names are different.
I will notify you when these changes have been moved to the core packages.
Thankyou!

Ovidijus thank you very much for explaining.
I see now how it works. Amazing thanks.
And cool that you changed the code to make it work.
Really appreciate your work on this great project!

You can close the issue
(or i will when i have access to eggwise again next week)
@OvidijusParsiunas

Hey @sv-developer.
I will close the issue when the functionality has made it to the core deep-chat and deep-chat-react packages. Thanks!

This doesnt work when you use function handler in chat mode instead of assistant mode though. @OvidijusParsiunas

Hey @Eggwise.
Because the functionsDetails argument is an array, we expect you to return a string array or an array of string Promises (string[] | Promise<string>[]).
So in your example, you can change it to something like this:
async yourAsyncFunction(functionDetails) {
  ...
}

const getDefaultConnectionConfig = () => ({
  openAI: {
    key: localStorage.getItem("OPENAI_API_KEY"),
    assistant: {
      assistant_id: "...",
     function_handler: (functionsDetails) => {
          return functionsDetails.map((functionDetails) => yourAsyncFunction(functionDetails));
        }
    },
  },
});

Let me know if you have any questions. Thanks!

This doesnt work when you use function handler in chat mode instead of assistant mode though. @OvidijusParsiunas

Hi @Eggwise.
Thankyou for letting me know about the issue.
I have updated the deep-chat-dev and deep-chat-react-dev packages versions 9.0.221 to allow multiple async funcs. Let me know if you experience any issues with it.
Thanks!


fix duplicate &&

This was done in PR #9 thank you!

@deadprogram I think #9 was for the arduino, not the mini drone?


Throw error when creating a MultiPoylgon with infinite edges

Expected behavior and actual behavior.
As per the doc:

Figure 7. ... on the right, a MultiPolygon that is invalid because its members touch at an infinite number of points (along a line).

Thus shapely should throw an error when creating a MultiPoylgon with infinite edges. (I caught this error when trying to save such a geometry with GeoPandas, and it would always convert the MultiPolygon into a single Polygon.)
Steps to reproduce the problem.
This test should throw an error:
from shapely.geometry import Polygon, MultiPolygon

polygon1 = Polygon(((0, 0),
                    (0, 1),
                    (1, 1),
                    (1, 0),
                    (0, 0)))

polygon2 = Polygon(((1, 0),
                    (1, 1),
                    (2, 1),
                    (2, 0),
                    (1, 0)))

multipolygon = MultiPolygon([polygon1, polygon2])

Operating system
Linux/Ubuntu
Shapely version and provenance
Shapely 1.6.4.post2
Python 3.5

@asmith26 can you give a few more details, such as the provenance of your Shapely package and GEOS library version? Support for Shapely 1.6.4 is very limited as we are working on the 1.7 version now. If you can show that this is an issue in 1.7, we're more likely to get to work on it soon.

Hi @sgillies,
As you can see this is a problem in Shapely 1.7:

Not entirely sure how to check my GEOS version, but running the following returns:
$ geos-config --version
3.5.0

Hi @sgillies,
As you can see this is a problem in Shapely 1.7:

Not entirely sure how to check my GEOS version, but running the following returns:
$ geos-config --version
3.5.0

Hope this helps, and thanks for your help!

Thank @kannes thanks for this information.
Perhaps there could be a configuration option that one could add to the start of their script to e.g. automatically check validity of all geometries created by the script (and perhaps throw an error instead of just saying "False"). (I appreciate such configurations may add unwanted complications, but I thought I would ask in case something similar already exists or if it inspires other suggestions.)

@asmith26 the GEOS library used by Shapely has a global context but that context doesn't give us anything to strictly require valid geometries. We'd need to do this entirely in Python. If you want it to be entirely transparent, so that Polygon(..) raises an exception when invalid, I think the thing to do would be to write a Python context manager that patches all the Shapely geometry constructors when __enter__() is called and then restores them when __exit__() is called. I like writing code like this, but I'm not keen to include it in Shapely. Adding features to the library requires more tests and more documentation and I'm super short on time right now.


Thanks from Prodction

Dear David, I just want to report back to you that we are using react-native-typescript-transformer successfully in production with ReactNative 0.45.1. Thank you very much for you effort in bringing this into react-native and maintaining this package. It made our stack incredibly more stable and predictable.
If you ever happen to be in Berlin, let me know for a sponsored beer.
Dino
Shoplink Team

😊 This feedback is so very nice to have, thank you! I do like to visit Berlin occasionally, will try to remember to hit you up next time.
I'm going to close this issue because it's not really an issue, but you totally made my day. :heart:


docs: I found a typo in the HTML input types page

Type: docs
Ionic Version: 1.x
Platform: all
Under the Password section, the second paragraph begins "Also note that it's being to be common practice to give users...".
It should be changed to "Also note that it's starting to be common practice to give users..." or "Also note that it's becoming common practice to give users...".

This issue was moved to driftyco/ionic-site#633


Add Free Oracle Cloud Infrastructure Certification for limited time.

Oracle has extended their free training & certification program till Feb 28, 2022.


Alt-gr + Space shortcut binding issue

Hey,
I am using a BÉPO layout keyboard on which the '_' symbol is bound to AltGr + Space
My issue is that when I try it on th SQL Editor, I get a popup that says "No Proposals"

How can I bypass this ? I have tried to unbind this shortcut but I cannot find out where to do it.
Thanks,

Most keyboards don't have AltGr as a special key, but actually send Ctrl+Alt, so most likely your AltGr+Space is intepreted by DBeaver as Ctrl+Space, which is the Content Assist shortcut:

Thanks a lot @antoniustefan  ! It was this shortcut 👍


CORE-20138: Flakey key rotation tests

Add exception message into the log.

Can you be more specific about the problem. For example if I look in the logs in the ticket I see
pod/corda-bob-crypto-worker-54897db87f-mdj5m/corda-bob-crypto-worker] 2024-04-16T10:53:13.601Z [durable processing thread crypto.key.rotation.ops-crypto.key.rotation.ops] WARN  net.corda.crypto.service.impl.bus.CryptoRekeyBusProcessor {} - A KeyRotationRequest event could not be processed:
[pod/corda-bob-crypto-worker-54897db87f-mdj5m/corda-bob-crypto-worker] net.corda.crypto.core.ShortHashException: Hex string has length of 1 but should be at least 12 characters

which appears to show you the message correctly already?

Can you be more specific about the problem. For example if I look in the logs in the ticket I see
pod/corda-bob-crypto-worker-54897db87f-mdj5m/corda-bob-crypto-worker] 2024-04-16T10:53:13.601Z [durable processing thread crypto.key.rotation.ops-crypto.key.rotation.ops] WARN  net.corda.crypto.service.impl.bus.CryptoRekeyBusProcessor {} - A KeyRotationRequest event could not be processed:
[pod/corda-bob-crypto-worker-54897db87f-mdj5m/corda-bob-crypto-worker] net.corda.crypto.core.ShortHashException: Hex string has length of 1 but should be at least 12 characters

which appears to show you the message correctly already?

Ups, looks like my fault. I was filtering the logs, and expected to see the exception on the same line.
I will close this.


viewDidAppear is not getting called

In the child controller the viewdidAppear method is not getting called for iOS 15. In earlier iOS versions it was getting called and worked properly. Using Parchment (3.1.0) pod version.

Hi @sakshigidwani93! Sorry for the late response. Do you have any tips on how to reproduce this? I'm not seeing this behaviour myself.


Acces Denied Problem with SPAppCatalog

When I try to execute SPAppCatalog Resource with FarmAccount or Setup Account I get an access denied.
 SPAppCatalog MainAppCatalog         {             SiteUrl = $Node.SharePoint.Apps.AppCatalogUrl             PsDscRunAsCredential = $SPSetupAccount             DependsOn            = @('[SPAppDomain]LocalFarmAppUrls')             #InstallAccount = $SPSetupAccount         }
Error Deails here:
VERBOSE: [MYDEV]: [[SPAppCatalog]MainAppCatalog] Leaving BeginProcessing Method of Update-SPAppCatalogConfiguration.
Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED))
+ CategoryInfo          : InvalidData: (Microsoft.Share...ogConfiguration:) [], CimException
+ FullyQualifiedErrorId : Microsoft.SharePoint.PowerShell.SPCmdletUpdateSPAppCatalogConfiguration
+ PSComputerName        : MYDEV
When I try to execue the normal powershell command:
Update-SPAppCatalogConfiguration -Site  @"http://contoso.com/sites/AppCatalog" -Force
it does work perfect for me.
Any idea what the problem could be?
Here are some environemnt informations:

PS 5.0
OS Win 12 R2
SharePoint 2013
Dsc Module Version <IP_ADDRESS>

Confirmed bug - I've seen this while building out the integration tests as well. We know this definitely used to work and we haven't changed the code either so I'm wondering if a specific cumulative update or something is causing us the issue. Can you confirm for me what update level your SharePoint 2013 farm is at?

The Server Patch level is Oct. 2015

@arashalvandi Finally got to the bottom of this one. It appears the Update-SPAppCatalogConfiguration command doesn't like running as the setup account (that created the web app in this case). The workaround is to use the farm account to run this resource (change PsDscRunAsCredential to be the same creds as the farm account). We'll add a specific error trap for this to show a more meaningful error in 1.5, and we'll be updating the documentation shortly.


Adding name theme variable $colors makes a much bigger main.css.

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/driftyco/ionic-v1)
[ ] 2.x
[x ] 3.x
I'm submitting a ...  (check one with "x")
[ x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Adding colors to the src/theme/variables.scss file greatly inflates the size of the produced main.css file.
Expected behavior:
I would not expect any file sizes to change by much based on how many colours I have named.
Steps to reproduce:
1: Run "ionic start"
2: Pick any app
3: Run "npm run build --prod"
4: Observe size of /www/build/main.css (should be in the region of 370KB)
5: Edit /src/theme/variables.scss and add a few more (~10) colours into the $colors variable (~line 27-32)
6: Run "npm run build --prod"
7: /www/build/main.css should be much bigger
Other information:
Inside the main.css file it seems to generate every component for every colour (in this example my added one "darkactive").
Ideally I'd like a css file without css not used at all in the app. (I realise in some cases figuring out if something is used is rather tricky).
Surely it can't be correct to generate components for every colour named, and if $colors is "special" and referenced in the ionic components then surely a comment to discourage/manage it's contents or set expectations for the developer that components will be generated in every named colour would be appropiate, and then possible have a secondary "$customcolors" or something would be better.
When these colours are "used" it's generally going to be something like <button  color="secondary"> and not <button class="button-clear-ios-darkactive">, so I'm not sure the "generate everything" possible approach is great for size etc but it should theoretically be possible to parse the apps code and work out what's actually required then possible include/exclude files before running sass.
.badge-ios{border-radius:10px}.badge-ios-secondary{color:#fff;background-color:#96c93d}.badge-ios-danger{color:#fff;background-color:#ef4424}.badge-ios-light{color:#fff;background-color:#1ebacf}.badge-ios-dark{color:#fff;background-color:#323c48}.badge-ios-darkactive{color:#fff;background-color:#1f2932}

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
global packages:

    @ionic/cli-utils : 1.2.0
    Ionic CLI        : 3.2.0

local packages:

    @ionic/app-scripts              : 1.3.6
    @ionic/cli-plugin-ionic-angular : 1.2.0
    Ionic Framework                 : ionic-angular 3.1.1

System:

    Node       : v6.10.1
    OS         : Windows 10
    Xcode      : not installed
    ios-deploy : not installed
    ios-sim    : not installed

It's not really a bug, so much as the current state of things. Below are a few issues discussing the need for a dynamic way to set colors, both so we can avoid the css bloat and so we can use colors that are not predefined.

https://github.com/driftyco/ionic-app-scripts/issues/506
https://github.com/driftyco/ionic/issues/9470
https://github.com/driftyco/ionic/issues/11754

Thanks for that. Apparently my github-foo isn't so good as I did try looking quite a bit in this repo and the app scripts. I'm just glad to know I'm not the only one that cares about this. I still think perhaps the starter projects/documentation should be a bit more clear about how this works. A component that can dynamically set it's "theme" based on a colour input would be great.

Hello all! Thanks for summing things up @patrickmcd ! I am going to close this issue as a duplicate of driftyco/ionic-app-scripts#506 and you can follow that issue for the status of this.


Wordpress false positive is user password begins with "$"

Hello,
I had several issues adding new users in latest WordPress and latest OWASP WordPress rules exclusion plugin.
The log is as follows:
[Sat Mar 02 11:48:20.631053 2024] [:error] [pid 27350] [client REDACTED:55579] [client REDACTED] ModSecurity: Warning. Pattern match "\\\\$+(?:[a-zA-Z_\\\\x7f-\\\\xff][a-zA-Z0-9_\\\\x7f-\\\\xff]*|\\\\s*{.+})(?:\\\\s|\\\\[.+\\\\]|{.+}|/\\\\*.*\\\\*/|//.*|#.*)*\\\\(.*\\\\)" at ARGS:pass1. [file "/usr/share/modsecurity-crs/rules/REQUEST-933-APPLICATION-ATTACK-PHP.conf"] [line "460"] [id "933180 "] [msg "PHP Injection Attack: Variable Function Call Found"] [data "Matched Data: $mm82rEJpdrmYns(Oa) found within ARGS:pass1: $mm82rEJpdrmYns(Oa)889aV"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.2"] [tag "application-multi"] [tag "language-php"] [tag "platform-multi"] [tag "attack-injection-php"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/242"] [hostname "www.REDACTED.com"] [uri "/wp-admin/user-new.php"] [unique_id "ZeMSBJ3nkXCGEAmPg4frkwAAAAM "], referer: https://www.REDACTED.com/wp-admin/user-new.php
The matched data, found in ARGS:pass1, is exactly the random password WordPress created. I believe the pattern triggers because it thinks I am passing a PHP variable (they begin with "$").

@dfumagalli The false positive you reported should already be fixed by the plugin here. I've tried reproducing the issue myself and I was successfully able to create a new WordPress user with the password you provided.
I can see that you're using CRSv3.3.2, plugins are a new feature in CRSv4 and are not supported in 3.3.2 (however the WordPress plugin should work fine if you backported it to 3.3.2).
It's likely that you've installed the plugin incorrectly or that you have a 3rd party plugin installed in WordPress that changes how WordPress creates new users (3rd party WordPress plugins are currently not supported).
Can you provide some additional information about your environment such as what version of WordPress you're running, and what plugins you have installed (if any)?

Hello,
I am using the rules I downloaded from this repository like 15 days ago.
I easily installed the plugin (I read the instructions on your main website).
All I had to do as a whole was to edit 1 rule (not relevant to here) and everything worked well in CRSv3.3.2.
Additional information: WordPress with ZERO plugins I downloaded today on Apache 2 + FPM / PHP 8.2 on Ubuntu.
Adding the user was literally the first action I did after installing WordPress.

@dfumagalli

WordPress with ZERO plugins I downloaded today

So then I assume you're on WordPress 6.4.3 (I'm on 6.4.3 and this works fine for me)?
In that case, the issue is likely a config issue. I'm not very familiar with Apache so forgive me. How are you including the plugin within ModSecurity under /etc/apache2/mods-enabled/security2.conf, are you loading it before CRS or after?

`
# Default Debian dir for modsecurity's persistent data
SecDataDir /var/cache/modsecurity
    # Include all the *.conf files in /etc/modsecurity.
    # Keeping your local configuration in that directory
    # will allow for an easy upgrade of THIS file and
    # make your life easier
    IncludeOptional /etc/modsecurity/*.conf

    # Include OWASP ModSecurity CRS rules if installed
    IncludeOptional /usr/share/modsecurity-crs/*.load

`

@dfumagalli Thank You
I don't see any includes for the plugins directory here, that's probably your issue. I don't know where you placed the plugins file, but the security2.conf file should look something like this. Replace /path/to/coreruleset/plugins/ with the path to where your plugin files are installed.
    # Default Debian dir for modsecurity's persistent data
    SecDataDir /var/cache/modsecurity

    # Include all the *.conf files in /etc/modsecurity.
    # Keeping your local configuration in that directory
    # will allow for an easy upgrade of THIS file and
    # make your life easier
    IncludeOptional /etc/modsecurity/*.conf

    Include /path/to/coreruleset/plugins/*-config.conf
    Include /path/to/coreruleset/plugins/*-before.conf

    # Include OWASP ModSecurity CRS rules if installed
    IncludeOptional /usr/share/modsecurity-crs/*.load

    Include /path/to/coreruleset/plugins/*-after.conf

Ok, thank you!


Loop through List - Server Members

Seems to be broken, does return nothing, but got 6 Members on my Discord Server.

Could you please screenshot the event & action?

https://i.gyazo.com/f8cde918bde6d3c41d07d760d78ce5c5.png - everthing beyond the loop command, does not execute


lightspeed: update ServingRuntime and switch to using command_args

This PR fixes an issue in the original implementation of roles/wisdom_llm_load_test_multiplexed. It also switches to using command_args, though this cleanup is not yet complete. I would like to run the full suite of tests and then merge this PR as is assuming that it works. More cleanup can come in a follow-up PR.
Remaining to-dos:

Clean up the way llm_load_test config is passed from testing/lightspeed/config.yaml is passed to llm_load_test container (may require cleanup in llm_load_test itself). Allow setting runtime/model version from testing/lightspeed/config.yaml
Rename roles/wisdom/wisdom* to roles/lightspeed/lightspeed*

/test lightspeed-load-test

thanks @dagrayvid looks good, I went through the changes and don't have any comment :)
feel free to rebase and merge when you want, you have merge right right?
/approve

Thanks @kpouget, yes it looks like I have merge rights

Looks like the test was running well, but hit the timeout. I shortened the duration of each multiplexed test from 15 to 10 minutes. I also opened a PR to extend the timeout: https://github.com/openshift/release/pull/41434

/test lightspeed-load-test

/test lightspeed-load-test-light

Merged as the light-speed-load-test light completed successfully (I also ran the full length test on my own cluster)
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift-psap_ci-artifacts/850/pull-ci-openshift-psap-ci-artifacts-main-lightspeed-load-test-light/1682202861468913664/artifacts/load-test-light/test/artifacts/007__wisdom__run_llm_load_test_multiplexed/_ansible.log


MediaMTX server crashed with WebRTC playback

Which version are you using?
1.9.1
Which operating system are you using?

I can't see any relationship with #2320.


build: repair the sub-build for libdispatch on Windows i686

When building on Windows i686 with a toolchain build for Windows x64, we
would try to build libdispatch for i686 as x86_64.  This obviously would
be incorrect.  Explicitly pass the target triple for the sub-builds.  We
can do this unconditionally since we always use clang-cl builds.  This
allows us to build the SDK only components for Windows i686 from a 64bit
build.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @drexin @gottesmm

@swift-ci please test

Excellent suggestion from @gottesmm: this is ripe for conversion to a toolchain file.  Doing so should really simplify the amount of logic here.  That however is a target for another day.  This currently should hopefully allow reviving the 32-bit builds of the Windows SDK.


Update Composer dependencies (2021-03-17-00-04)

Visual regression test passed!
View the visual regression test report


Deployment

Vip Cars App || Deployment
Project Description
Deploy application.
Feature Description

Deployed application using Netlify: Link
Update README.md file with app deployment link.

Happy Reviewing!

Hi @PraisesPJMT 👋🏻👋🏻
Our application is complete! There is nothing else to say other than... it's time to merge it :shipit:
Great job 🔥🔥💯
Highlights ✨✨
Descriptive PR 🚀✅
Good gitflow ✅
Professional README ✅
Cheers and Happy coding!👏👏👏


Additional Preference to be included in handover report for exercise 021

As an Admin l want the additional preference information to be  downloaded on an excel spreadsheet for all candidates that has been recommended so that l can include this information in my handover report to the JO.
Note:
Additional preference data is needed for the JO handover report. I have sent a copy of the spreadsheet to @tomlovesgithub. Can l have this bespoken report for  exercise 021 FtT&ET pls.
If you are applying for the First-tier Tribunal, please rank your choice of chambers. As business requirements may change throughout the exercise for appointment in the First-tier Tribunal you are required to rank all chambers in order of preference on your application; one being your preferred choice and seven being your least preferred. (Ranked choice)
@tomlovesgithub can you bring  @mbrookeswebdev up to speed on this issues please.

Digital platform branch is here
Admin branch is here
The report was emailed in, waiting for confirmation that it contains everything that was requested.

@mbrookeswebdev  There has been additional requirement for the tasks we also need to include Jurisdiction preferences in this report.

Report updated and emailed to users.

Requirement changed to include both recommended and handover stages


Invalid registry for transaction

Description
When trying to SendInfoToWallet we get an error: "Invalid registry for transaction". The Wallet is version 0.2.0 and PORegistry is version 0.2.2 deployed in Kubernetes.

Wallet setup:

Registry setup:

probably due to outdated proto file


[usockets] update to 0.3.4

Related issue #9274.

Update the versions
Delete deprecated functions
Update deprecated functions

/azp run


add mode() function & tests

@agaurav before I merge this, which email do you want to use as the author for this commit? I see @opavader and @agaurav seem to be both you, but with different emails. I want to make sure the commit log has the credit given to the correct GitHub username.

@jwilder can I also get a thumbs up that this is OK to merge into 1.0 to be released with the next release candidate?

@jsternberg I think i signed the CLA with this account (@agaurav), so please use this.

Looking at the CLA responses we've gotten, I see you used @agaurav as the GitHub account name, but you used<EMAIL_ADDRESS>as the email. That email appears to be linked to your other account. Do you want to use that email with the commit or a different email?
Either one is fine with me.

Yeah you can use that.

Looks great @agaurav! This is missing a changelog entry though.

cc @nathanielc

@jwilder https://github.com/influxdata/influxdb/pull/7207 for changelog.
Also, https://github.com/influxdata/docs.influxdata.com/pull/585 for updating the docs.


Add mode specific help text

Moves the help text to the scriptUtils, and create mode specific help text.
For example:
Usage:
  network.sh deployCC [Flags]

    Flags:
    -c <channel name> - Name of channel to deploy chaincode to
    -ccn <name> - Chaincode name. This flag can be used to deploy one of the asset transfer samples to a channel. Sample options: basic (default),ledger, private, sbe, secured
    -ccl <language> - Programming language of chaincode to deploy: go (default), java, javascript, typescript
    -ccv <version>  - Chaincode version. 1.0 (default), v2, version3.x, etc
    -ccs <sequence>  - Chaincode definition sequence. Must be an integer, 1 (default), 2, 3, etc
    -ccp <path>  - (Optional) File path to the chaincode. When provided, the -ccn flag will be used only for the chaincode name.
    -ccep <policy>  - (Optional) Chaincode endorsement policy using signature policy syntax. The default policy requires an endorsement from Org1 and Org2
    -cccg <collection-config>  - (Optional) File path to private data collections configuration file
    -cci <fcn name>  - (Optional) Name of chaincode initialization function. When a function is provided, the execution of init will be requested and the function will be invoked.

    -h - Print this message

 Possible Mode and flag combinations
   deployCC -ccn -ccl -ccv -ccs -ccp -cci -r -d -verbose

 Examples:
   network.sh deployCC -ccn basic -ccl javascript
   network.sh deployCC -ccn mychaincode -ccp ./user/mychaincode -ccv 1 -ccl javascript

Let me know what you think.
Signed-off-by: NIKHIL E GUPTA<EMAIL_ADDRESS>

As suggested by Arnaud, I did some edits to the help text more broadly to clean up the language and the clarity.
I also took the opportunity to remove the "restart" mode, which is not used in any of the tutorials or samples, and does not have a practical use.

As suggested by Arnaud, I did some edits to the help text more broadly to clean up the language and the clarity.
I also took the opportunity to remove the "restart" mode, which is not used in any of the tutorials or samples, and does not have a practical use.

Sounds reasonable to me but would be worth adding that to the commit log.
I think restart could be useful if it retained all the arguments but as it is, I agree it's not really useful.


Updating readme

Can this build?

Can one of the admins verify this patch?

add to whitelist.

What does mim stand for again?
Shouldn't this repo be named nms?


Is there a way to outline fonts?

Steps to reproduce
Tell us about your environment:

Puppeteer version: ^1.8.0
Platform / OS version: Mac OSX 10.14.5
URLs (if applicable):
Node.js version: 10.15.3

What steps will reproduce the problem?
Please include code that reproduces the issue.

Opening a PDF generated by that framework in Adobe Illustrator (https://github.com/RelaxedJS/ReLaXed-examples/tree/master/examples/book/)
The fonts aren't outlined

This is relevant to: https://github.com/RelaxedJS/ReLaXed/issues/139
ReLaXed is using Puppeteer to create PDFs.

If I print an HTML with Chrome and save as a pdf, it outlines the fonts so then rendering it in something lie Adobe Illustrator then it doesn't need a font. This would also allow print shops to easily print PDFs. Is there a way to outline the fonts using this library?

A member of that repository suggested this might be a Puppeteer issue.

Outlining is converting the fonts to (vector) shapes.
Embedding is different.
I see no option for this in Puppeteer: https://github.com/GoogleChrome/puppeteer/blob/v1.19.0/docs/api.md#pagepdfoptions
I guess it depends a bit on PostScript support and other things.
This is probably an issue in Puppeteer / Chromium.

What is the expected result?
I expect the fonts to be outlined the same way Chrome generates PDFs. This way, sending PDFs to print shops have less risk of unexpected outcomes.
What happens instead?
It's not outlined; I am assuming the font family is embedded as suggested by this comment: https://github.com/RelaxedJS/ReLaXed/issues/139#issuecomment-515101110

I'm struggling with the same issue with puppeteer ^2.0.0: Illustrator force vectorizes the texts of PDF generated by Puppeteer.
Opening both PDF with a text editor, I can't spot any difference in the declaration of the font/fontDescriptor, it could be in the binary embedding of the font...
As the OP, I don't reproduce this issue when opening a PDF generated directly by Chrome.

We hope the puppeteer provides an option to outline fonts or not. It's very useful.

As of now (2023/08/10), I have done tests on whether secondary development is possible.

Y : no outline <can reporduce>
N: outline <can't reporduce>

|   |
-- | -- | --
  | chrome(Directly) | puppeteer
window | N | Y
mac | system font N. Web fonts Y | Y
linux | Y(by puppeteer executablePath) | Y


bugfix:修改权限参数传错

1.修改权限参数传错
2.无权限公共api导入功能任能打开
2.修改单据评论初始化总页数

Codecov Report

Merging #260 (a6acd2c) into v2.6.x_develop (8e19cc7) will increase coverage by 0.00%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           v2.6.x_develop     #260   +/-   ##
===============================================
  Coverage           53.62%   53.62%
===============================================
  Files                 445      445
  Lines               27462    27463    +1
===============================================
+ Hits                14726    14728    +2
+ Misses              12736    12735    -1

Impacted Files
Coverage Δ

itsm/ticket/models/ticket.py
48.46% <0.00%> (-0.03%)
:arrow_down:

itsm/workflow/validators.py
41.08% <0.00%> (+0.21%)
:arrow_up:

itsm/workflow/backend.py
66.54% <0.00%> (+0.35%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e19cc7...a6acd2c. Read the comment docs.


Compilation level BUNDLE always fully parses file instead of only using regex parser

The idea of BUNDLE is that files are reordered and slightly wrapped, transpiling only when necessary to allow them all to be in the same file instead of either requiring that the browser load multiple files, or fully transpiling contents (in another optimization level). In theory, this means that the JsFileRegexParser should be sufficient to pick up dependencies between the files to correctly order them for output, but at this time JsAst.getAstRoot is called for every file passed to the command line runner.
This can be easily confirmed by trying to bundle a small set of files with a breakpoint in JsAst.parse. There are roughly two paths to this call - Compiler.orderInputs runs before the bundle work gets started (only if the --dependencyMode is set to something that requires dependencies to be directly managed), but AbstractCommandLineRunner.printBundleTo also hits this in potentially two ways, if numParallelThreads is greater than 1 (ironically asking the compiler to parallelize will cause it to do substantially more work), or if preventLibraryInjection is false.
There doesn't seem to be a way to "fix" PrebuildAst directly, but perhaps we could instead invoke CompilerInput.getDependencyInfo() on other threads, which in turn delegates to JsFileRegexParser. With that said, parseInputs, which calls orderInputs above, also does PrebuildAst work. It might be better to just encourage BUNDLE users to not set numParallelThreads.
But for the other two, the root issue is that while JsFileRegexParser does the parsing work as expected, it is then wrapped by a LazyParsedDependencyInfo instead before being returned. Then, several callers invoke getLoadFlags().get("module") to see if the file is an "es6" module (uses import/export), or a "goog" module (uses goog.provide/require/module/etc). However, while LazyParsedDependencyInfo.getLoadFlags() calls to the underlying AutoValue_SimpleDependencyInfo delegate to see the initial set of flags, it then calls ast.getFeatures(compiler), which will actually run the parser. Some validation will then occur - if the parsed features happen to suggest that the file is an es6 module but the JsFileRegexParser didn't detect this, there will be an error.
That validation is the only value I see at a glance, and to my untrained eye it would be a compiler bug for the two parsers to disagree (the user shouldn't need to explicitly enable BUNDLE to use es6 modules, but perhaps other compilation levels would need that?), and Feature.MODULES only appears to be set when the parser encounters import, import.meta, or export. At a brief glance, import.meta might not be checked for in JsFileRegexParser, which could contribute to this...?
With this in mind, it seems reasonable to introduce convinience methods that call getLoadFlags().get("module") and compare to the two known values, "goog" and "es6", returning a boolean for each one. See the linked PR for a proposed draft of this change.
Finally, this doesn't completely remove all parsing - any es6 module needs to be parsed and rewritten to correctly map its imports and exports. Perhaps the PrebuildAst could be limited to only files with module=es6 to let that happen up front.
Here's a quick perf run, new then old.

Thanks for doing this investigation! Seems like a good improvement.


语音转文字不支持Android流式的

The voice-to-text does not support Android streaming, which is not found in your official documents. We are using our own directional microphone. We want to identify it on your platform in real time based on the audio stream we recorded. I asked your customer service to say no before Support, because our current approach is to synthesize our own audio stream into wav and then go to your platform for recognition. The recognition speed is a bit slow in about 3 seconds, so I want to try streaming recognition

hi @cl-6666, maybe you can try using something like this example to populate it with your stream.
Please let me know if that works.

我试过了，这种方法不行，我们麦克风现在返回的是byte[] data，不知道您那边是否可以提供一个类似这样的api
，mRecognizer.writeAudio(data, 0, data.length);   实时的传输给你们流    然后识别结果回调给我们

I tried it, but this method doesn’t work. Our microphone now returns byte[] data. I don’t know if you can provide an api like this
，MRecognizer.writeAudio(data, 0, data.length); transmit it to you in real time, and then call back the recognition result to us

嗨@ cl-6666，也许您可以尝试使用类似此示例的内容来填充您的流。
请让我知道是否可行。

I tried it, but this method doesn’t work. Our microphone now returns byte[] data. I don’t know if you can provide an api like this
，MRecognizer.writeAudio(data, 0, data.length); transmit it to you in real time, and then call back the recognition result to us

This example uses a push audio input stream. Let me know if that is what you need.

本示例使用推送音频输入流。让我知道这是否是您所需要的。

Hello, I saw this case. This is to identify local files. I think I may not express it clearly. The effect we want is like this. Directly take the real-time audio stream returned by our own microphone and give it to you for real-time recognition. , I saw that other platforms do this and I posted the code.
if (isLast) {
if (mRecognizer != null) {
mRecognizer.stopListening();
}
} else {
mRecognizer.writeAudio(data, 0, data.length);
}
/**
* 听写监听器。
*/
private RecognizerListener mRecognizerListener = new RecognizerListener() {
    @Override
    public void onBeginOfSpeech() {
        // 此回调表示：sdk内部录音机已经准备好了，用户可以开始语音输入5e9d71b3
        if (mListener != null) {
            mListener.onRecognizerPrepared();
        }
    }

    @Override
    public void onError(SpeechError error) {
        // 错误码：10118(您没有说话)，可能是录音机权限被禁，需要提示用户打开应用的录音权限。
        // 如果使用本地功能（语记）需要提示用户开启语记的录音权限。
        if (mListener != null) {
            mListener.onRecognizerError(error.getPlainDescription(true));
        }
    }

    @Override
    public void onEndOfSpeech() {
        // 此回调表示：检测到了语音的尾端点，已经进入识别过程，不再接受语音输入
        if (mListener != null) {
            mListener.onSpeechFinished();
        }
    }

    @Override
    public void onResult(RecognizerResult results, boolean isLast) {
        Log.d(TAG, results.getResultString());
        String printResult = printResult(results);

        if (isLast) {
            if (mListener != null) {
                mListener.onGetRecognizerResult(printResult);
            }

//                FileSDCardUtil.saveFileToExternalFileDir(mContext, FileSDCardUtil.loadDataFromSDCard("/storage/emulated/0/msc/iat.wav"), "ali" + System.currentTimeMillis()+".wav");
}
        if (isLast) {
            if (mListener != null) {
                mListener.onGetRecognizerResultEnd();
            }
        }
    }

    @Override
    public void onVolumeChanged(int volume, byte[] data) {
        Log.d(TAG, "返回音频数据：" + data.length);
        if (mListener != null) {
            mListener.onVolumeChanged(volume);
        }
    }

    @Override
    public void onEvent(int eventType, int arg1, int arg2, Bundle obj) {

    }
};

Where isLast is whether the speech is finished

本示例使用推送音频输入流。让我知道这是否是您所需要的。

Hello, I saw this case. This is to identify local files. I think I may not express it clearly. The effect we want is like this. Directly take the real-time audio stream returned by our own microphone and give it to you for real-time recognition. , I saw that other platforms do this and I posted the code.
if (isLast) {
if (mRecognizer != null) {
mRecognizer.stopListening();
}
} else {
mRecognizer.writeAudio(data, 0, data.length);
}
Where isLast is whether the speech is finished

This example uses a push audio input stream. Let me know if that is what you need.

Hello, I saw this case. This is to identify local files. I think I may not express it clearly. The effect we want is like this. Directly take the real-time audio stream returned by our own microphone and give it to you for real-time recognition. , I saw that other platforms do this and I posted the code.
if (isLast) {
if (mRecognizer != null) {
mRecognizer.stopListening();
}
} else {
mRecognizer.writeAudio(data, 0, data.length);
}
Whether isLast has finished speaking, the last is to return the result in the result listener

What I believe you need to do is to use that same mechanism that sample uses; so you would create your recognizer using a PushAudioInputStream and do something like:
audioRecorder.startRecording();

byte[] buffer = new byte[audioRecorderBufferSize];

while (audioRecorder.getRecordingState() == AudioRecord.RECORDSTATE_RECORDING) {
    int bytesRead = audioRecorder.read(buffer, 0, buffer.length);
    if (bytesRead != buffer.length) {
        throw new RuntimeException();
    }
    stream.write(buffer);
}
stream.close();

我相信您需要做的是使用样本使用的相同机制。因此您可以使用PushAudioInputStream创建识别器，然后执行以下操作：
audioRecorder 。startRecording（）;

字节[]缓冲区= 新 字节[audioRecorderBufferSize]；

而（audioRecorder 。 getRecordingState（）==  AudioRecord 。 RECORDSTATE_RECORDING）{
     INT bytesRead = audioRecorder 。读（缓冲，0，缓冲器。长度）;
    如果（bytesRead ！=缓冲区。长度）{
        抛出 新 的RuntimeException（）;
    }
    流。写（缓冲区）;
}
流。关闭（）;

Hello, now I have a problem. The reco.recognized.addEventListener method is sometimes executed, sometimes not. I don’t know what caused it. The reco.recognizing.addEventListener method is executed every time, but there is no punctuation in the result. Now The realization is a single recognition, I also posted the code
`  public void streamingRecognition(String language) {
content.clear();
speechConfig.setSpeechRecognitionLanguage("zh-CN");
audioInputStream = PushAudioInputStream.create();
audioInput = AudioConfig.fromStreamInput(audioInputStream);
reco = new SpeechRecognizer(speechConfig, audioInput);
reco.recognizing.addEventListener((o, speechRecognitionResultEventArgs) -> {
final String s = speechRecognitionResultEventArgs.getResult().getText();
Log.i("TAG", "Intermediate result received: " + s);
content.add(s);
content.remove(content.size() - 1);
});
    reco.recognized.addEventListener((o, speechRecognitionResultEventArgs) -> {
        Log.i("TAG", "recognized: " + speechRecognitionResultEventArgs.getResult().getText());
    });

    reco.canceled.addEventListener((s, e) -> {
        System.out.println("CANCELED: Reason=" + e.getReason());
        if (e.getReason() == CancellationReason.Error) {
            Log.e("TAG", "CANCELED: ErrorCode=" + e.getErrorCode());
            Log.e("TAG", "CANCELED: ErrorDetails=" + e.getErrorDetails());
            Log.e("TAG", "CANCELED: Did you update the subscription info?");
        }

    });

    reco.startContinuousRecognitionAsync();

//        final Future task = reco.startContinuousRecognitionAsync();
//        setOnTaskCompletedListener(task, result -> {
//
//        });
}
public void streamingResults(byte[] bytes, boolean isLast, boolean frontPoint) {
    if (frontPoint) {
        if (identifyCallback != null) {
            identifyCallback.onNext(InternalConfig.VOICE_CODE);
        }
        return;
    }
    audioInputStream.write(bytes);

    if (isLast) {
        if (identifyCallback != null) {
            identifyCallback.onNext(content.toString());
        }
    }
}`

What I believe you need to do is to use that same mechanism that sample uses; so you would create your recognizer using a PushAudioInputStream and do something like:
audioRecorder.startRecording();

byte[] buffer = new byte[audioRecorderBufferSize];

while (audioRecorder.getRecordingState() == AudioRecord.RECORDSTATE_RECORDING) {
    int bytesRead = audioRecorder.read(buffer, 0, buffer.length);
    if (bytesRead != buffer.length) {
        throw new RuntimeException();
    }
    stream.write(buffer);
}
stream.close();

Hello, now I have a problem. The reco.recognized.addEventListener method is sometimes executed, sometimes not. At this time, my microphone has ended, and there is no print result in the log. I don’t know what caused it, reco.recognizing. The addEventListener method is executed every time, but there is no punctuation in the result. Now it is a single recognition. I also posted the code.
   public void streamingRecognition(String language) {
        content.clear();
        speechConfig.setSpeechRecognitionLanguage("zh-CN");
        audioInputStream = PushAudioInputStream.create();
        audioInput = AudioConfig.fromStreamInput(audioInputStream);
        reco = new SpeechRecognizer(speechConfig, audioInput);
        reco.recognizing.addEventListener((o, speechRecognitionResultEventArgs) -> {
            final String s = speechRecognitionResultEventArgs.getResult().getText();
            Log.i("TAG", "Intermediate result received: " + s);
            content.add(s);
            content.remove(content.size() - 1);
        });

        reco.recognized.addEventListener((o, speechRecognitionResultEventArgs) -> {
            Log.i("TAG", "recognized: " + speechRecognitionResultEventArgs.getResult().getText());
        });

        reco.canceled.addEventListener((s, e) -> {
            System.out.println("CANCELED: Reason=" + e.getReason());
            if (e.getReason() == CancellationReason.Error) {
                Log.e("TAG", "CANCELED: ErrorCode=" + e.getErrorCode());
                Log.e("TAG", "CANCELED: ErrorDetails=" + e.getErrorDetails());
                Log.e("TAG", "CANCELED: Did you update the subscription info?");
            }

        });

        reco.startContinuousRecognitionAsync();
//        final Future<Void> task = reco.startContinuousRecognitionAsync();
//        setOnTaskCompletedListener(task, result -> {
//
//        });
    }

    public void streamingResults(byte[] bytes, boolean isLast, boolean frontPoint) {
        if (frontPoint) {
            if (identifyCallback != null) {
                identifyCallback.onNext(InternalConfig.VOICE_CODE);
            }
            return;
        }
        audioInputStream.write(bytes);

        if (isLast) {
            if (identifyCallback != null) {
                identifyCallback.onNext(content.toString());
            }
        }
    }

Hi @cl-6666 I translated the issue title to English to make it more convenient, fell free to update it.

Hi @cl-6666. from the behavior you are describing I wonder if you are sending enough audio for the service to detect the end of speech. Maybe you can keep your microphone open a bit longer (or try sending a few frames filled with 0's so they are identified as silence)


EL Interpolator loading strategy needs workarounds

A proposal to satisfy working in both WildFly and OSGi: try both strategies.
Annoying, but seems necessary.

See also https://github.com/hibernate/hibernate-validator/pull/580

Superseded by https://github.com/hibernate/hibernate-validator/pull/581


NullReferenceException at 11 lines

Import: Game file 'asbresversion_f7a68606a0e1b8ae3a8a3cddc7a8b5dc.unity3d' has been found
Import: System.NullReferenceException: Object reference not set to an instance of an object.
   at uTinyRipper.Game.AssemblyManager.set_Version(Version value)
   at uTinyRipper.SerializedFile.ReadAssets(EndianReader reader)
   at uTinyRipper.SerializedFileScheme.ReadFile(IFileCollection collection, IAssemblyManager manager)
   at uTinyRipper.FileList.AddFile(FileScheme scheme, IFileCollection collection, IAssemblyManager manager)
   at uTinyRipper.BundleFileScheme.ReadFile(IFileCollection collection, IAssemblyManager manager)
   at uTinyRipper.FileList.AddFile(FileScheme scheme, IFileCollection collection, IAssemblyManager manager)
   at uTinyRipper.GameStructure.Processor.ProcessFile(String fileName, String filePath)
   at uTinyRipper.GameStructure.ProcessGameStructure(Processor processor, PlatformGameStructure structure)
   at uTinyRipper.GameStructure.Load(List`1 pathes)
   at uTinyRipper.GameStructure.Load(IEnumerable`1 pathes)
   at uTinyRipperGUI.MainWindow.LoadFiles(Object data)

The attached .unity3d file I think is the minimum to reproduce this, though it's just a few dependencies not game content. I've put the full game on Mega if needed, and will delete it after this is resolved.
202 KB - asbresversion_f7a68606a0e1b8ae3a8a3cddc7a8b5dc.unity3d
2.26 GB - https://mega.nz/#!iyhVzRwJ!vL4w8BY8B424bylsAt0YG7HMzxzIqvThmpkzOaZ5uHM

Do you use the newest version of the ripper? I've fixed this bug already in https://github.com/mafaca/UtinyRipper/issues/444

I overlooked that fast release, that does fix that specific problem! Going a little further now, I do have some new problems about it not finding all dependencies, maybe related to why I never found a "managed" folder. I think I can do what I need to do with this, thank you.


#16629 Fix issue with wrong method being called for async

Get instead of Post. Was trying to deserialize to the items array instead of the individual item (entity).

Also added code for exceptions.


Add support for Audio in contentable_type=HtmlItem and improve README

Hi,
I've added support for mp3 files in HtmlItem. The solution are already tested.
Also, while looking at the README, I found quite a few ways to improve it. Therefore, you'll see a almost total remake.
As I was working on the fix-lesson-dl branch, I've merged the main branch in hereafter, and solved the merge-conflicts.

Thank you @exetico. I am merging it.


Roadmap

After transferring the repository, we have the following items on the roadmap:

[ ] Publish package on PyPI (#1)
[ ] Set up CI with Github Actions
[ ] Change repo structure to match our default-app template

Stay tuned!

Still interested? :)

It will happen at some point, we just have higher priority items at the moment.


[Suggestion] - BlockList additions to Confluence JMX Exporter config

Suggestion
A default deny may be warranted here, however, in the interest of having more data to do a root cause analysis, I'm going to start with the suggestion of some block list additions to the default JMX exporter config.  I note we have some in JIRA under the now deprecated black list object names parameter.  ( might want to update that as well )
Confluence seems to have some fairly nasty issues in the bean imports the jmx exporter does.  Particularly as it pertains to:
com.atlassian.confluence.metrics
Example:
bean events of category01=logging
also seen in other metrics namespaces such as OneMinuteRate and many more.
com_atlassian_confluence_metrics_OneMinuteRate{category00="confluence",category01="logging",
We are exporting logging events to the prometheus exporter in the default jmx-config configmap configuration.
This results in any ingestion from that endpoint growing in infinite key cardinality, as well as an increasing delay in how long it takes to scrape the endpoint.
This isn't the only problematic metrics key we have.  the category00=hazelcast keys tend to also create tons of unique traffic that grows infinitely.  Again increasing the key cardinality on prometheus and infinitely increasing the scrape time of the exporter endpoint.
At the moment the default config for the jmx exporter is dangerous to directly integrate into prometheus.  I began trying to put together a jmx-config config map that would help me blocklist the offenders.  But to be frank, I am a bit outside my depth here, I would love some help.
As a starting point I have this in my values yaml:
jmxExporterCustomConfig:
    jmx-config:
      excludeObjectNames:
        - 'com.atlassian.confluence.metrics:category01=logging,*'
        - 'com.atlassian.confluence.metrics:category00=http,category01=rest,name=request,*'
        - 'com.atlassian.confluence.metrics:category00=bandana,*'
        - 'com.atlassian.confluence.metrics:category00=hazelcast,*'
        - 'com.atlassian.confluence.metrics.Value:category00=bandana,*'
        - 'com.atlassian.confluence.metrics.999thPercentile:category00=bandana,*'
        - 'com.atlassian.confluence.metrics.MeanRate:category00=bandana,*'
        - 'com.atlassian.confluence.metrics.OneMinuteRate:category00=bandana,*'
        - 'com.atlassian.confluence.metrics:category00=hazelcast,*'
        - 'com.atlassian.confluence.metrics.Value:category00=hazelcast,*'
        - 'com.atlassian.confluence.metrics.Count:category00=hazelcast,*'
        - 'com.atlassian.confluence.metrics.FifteenMinuteRate:category00=hazelcast,*'
        - 'com.atlassian.confluence.metrics.FiveMinuteRate:category00=hazelcast,*'
        - 'com.atlassian.confluence.metrics.OneMinuteRate:category:00=hazelcast,*'
        - 'com.atlassian.confluence.metrics.999thPercentile:category00=hazelcast,*'
        - 'com.atlassian.confluence.metrics.MeanRate:category00=hazelcast,*'
      rules:
        - pattern: '(java.lang)<type=(\w+)><>(\w+):'
          name: java_lang_$2_$3
        - pattern: 'java.lang<type=Memory><HeapMemoryUsage>(\w+)'
          name: java_lang_Memory_HeapMemoryUsage_$1
        - pattern: 'java.lang<name=G1 (\w+) Generation, type=GarbageCollector><>(\w+)'
          name: java_lang_G1_$1_Generation_$2
        - pattern: '.*'

but this seems to only deal with my logging events... I have tried a bunch of variations for clearing category00 stuff without success.  I suspect I am just wrong about the syntax and this would be obvious to a java developer.
Anyways, I open the floor to suggestions, proposals, and rebukes.  I would like to collaboratively dig through the list of metrics confluence is making available to the jmx exporter and block the dynamic growth ones.
Product
Confluence
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Regarding syntax issues
- 'com.atlassian.confluence.metrics:category01=logging,*'
this line worked.  but the attempts to handle anything in category00 have not worked.  not sure why.
Regarding Scope of block list
I have not completed figuring out all the items i will need to block list.  I would appreciate some feedback on how to approach figuring that out.  ATM I am basically working against the existing attributes used in the grafana charts and what i can see as suspect in iterative exporter scrapes.  Not even sure that's the right way to be approaching this.
Regarding severity of impact
I do want to be clear... this isn't just a performance bug.  It effectively makes the jmx exporter unusable on confluence.  in the default configuration under any load you will see the exporter trend toward infinity in terms of time it takes to scrap.  usually exceeding any reasonable timeout in prometheus until such time as it just endlessly times out.  it will additionally generate such severe cardinality growth it will OOM prometheus.

I want to bump this and add that in the current state jmx-exporter config for confluence is unusable and dangerous to any prometheus setup having to ingest it. Maybe there should be a warning that this is not intended for production use until a reasonable exclusion list is added to control growth of metric scrape.

Hello Team, I have been working on this locally and found the problem is with the string jmx-config being used in the configuration. The JMX-exporter doesn't expect any such string. A syntax like below should work flawlessly
jmxExporterCustomConfig:
     excludeObjectNames:
      - 'com.atlassian.confluence:category00=bandana,*'
      - 'com.atlassian.confluence:category00=hazelcast,*'
      - 'Confluence:name=CacheStatistics,*'
     rules:
      - pattern: '(java.lang)<type=(\w+)><>(\w+):'
        name: java_lang_$2_$3
      - pattern: 'java.lang<type=Memory><HeapMemoryUsage>(\w+)'
        name: java_lang_Memory_HeapMemoryUsage_$1
      - pattern: 'java.lang<name=G1 (\w+) Generation, type=GarbageCollector><>(\w+)'
        name: java_lang_G1_$1_Generation_$2
      - pattern: '.*'
  #  rules:
  #   - pattern: ".*"


[hotfix] Set gameId and playerId as optional.

Skip nulls when building WebSocket URL.

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   88.02%   88.02%
=======================================
  Files           2        2
  Lines         142      142
  Branches       45       45
=======================================
  Hits          125      125
  Misses         17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cca8b1...4a5d0e8. Read the comment docs.


build-siteox-solaris10u9-x64-1  has disappeared from jenkins

Was blocking JDK8 pipelines. Have disabled the solaris/x64 build job for now until this is resolved.
It appears that the underlying directory for the machine on the jenkins server file system is there, but it's no longer showing on  the jenkins UI and cannot have jobs scheduled on it

reloading the jenkins config fixed this


Faulty error message: rel_imm_variant is not a valid key

Describe the bug
This is not really a bug, but an erroneous error message that might cause confusion.
When defining a new variant, the key "rel_imm_variant" is  listed as valid key, although it actually isn't.
To reproduce
Define a new variant and use the key "rel_imm_variant", for example:
psi_pars = dict(
    rel_imm_variant = 1,
    rel_beta        = 1,
    rel_symp_prob   = 1,
    rel_severe_prob = 1,
    rel_crit_prob   = 1,
    rel_death_prob  = 1
)

psi = cv.variant(label='Psi', variant=psi_pars, days=0, n_imports=10)

Expected behavior
Either accept the provided parameters, or state that rel_imm_variant is not a valid key.
Screenshots or outputs
KeyNotFoundError: Could not parse variant keys "rel_imm_variant"; valid keys are: "rel_imm_variant, rel_beta, rel_symp_prob, rel_severe_prob, rel_crit_prob, rel_death_prob"
Platform (please complete the following information):
Covasim 3.1.1 (2021-12-06) — © 2021 by IDM
Additional Context:
This is caused by rel_imm_variant being listed in variant_pars in default.py, but does not actually seem to be a parameter defined by variants.

Thanks @Tianmaru, well spotted! We'll get this fixed in the 3.1.2 release.

Fixed in 3.1.2


moves router.js -> router.ts

Codecov Report

Merging #1239 into master will decrease coverage by 2.46%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1239      +/-   ##
=========================================
- Coverage    8.24%   5.77%   -2.47%
=========================================
  Files          60      59       -1
  Lines        2280    2216      -64
  Branches      483     479       -4
=========================================
- Hits          188     128      -60
+ Misses       2092    2088       -4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e98c2d...0917205. Read the comment docs.

Coverage remained the same at 27.615% when pulling 09172057dbbfcc777b4934c221893ee62d800b9e on theseyi:browse-revamp into 0e98c2d7c8dda2051324146a4ff4e99efb41e720 on linkedin:master.

I want to study wherehows and use it in my project, but there is no documentation on the new version.
Do you have any relevant documents or communication places?

@cgf120 we are working on updating the documentation for WhereHows at the moment. Can you please create a separate issue so we can track that against your concerns and answer any related questions you may have there? thanks for you interest


Add to HomeScreen for iOS devices

So that people dont have to type in the web url and can access it quickly...
Quite common amongst iOS web apps, is the notification to add to homescreen:
here is an example of how:
http://cubiq.org/add-to-home-screen
Here is the example of getting the right icon:
http://gigaom.com/apple/how-to-create-ios-device-home-screen-icons-for-web-sites/
not sure how to do on android...

This shouldn't be too difficult.

Testing to see if service hook pushes issue comments to irc


xoa_vm resource does not implement updates for attributes that require halting the VM

Attributes like memory and cpu require the VM to be halted before they can be applied. Since that is more complexity than updating the simpler attributes at runtime I am going to accomplish this separate from #35

In theory, it can be done live IF it's within some boundaries: can change vCPU numbers from 1 to max vCPU. Memory can be change within the dynamic range, capped by static range.
But it's complicated. I suppose it's more reasonable to do that when they are powered off.

Yea I still haven't fully grokked all the cpu and memory settings for VMs yet. I think that would be a great optimization (and I'll make sure to create a separate issue for it) but for now I will focus on making these updates possible and then edge cases can be made better in the future.

This has been addressed in #144. I implemented the online resizing of CPU and memory when possible. For updates that require the VM to be halted, terraform will stop the VM perform the full vm.set and then restart the VM.


Migrated to click

Fixed merge conflicts and linting errors from https://github.com/apache/incubator-superset/pull/4078.

Please fix the merge conflicts and build errors

Codecov Report

Merging #5410 into master will increase coverage by <.01%.
The diff coverage is 92.85%.

@@            Coverage Diff            @@
##           master   #5410      +/-   ##
=========================================
+ Coverage   59.09%   59.1%   +<.01%
=========================================
  Files         372     372
  Lines       23747   23759      +12
  Branches     2758    2758
=========================================
+ Hits        14033   14042       +9
- Misses       9699    9702       +3
  Partials       15      15

Impacted Files
Coverage Δ

superset/cli.py
46.59% <92.85%> (+1.9%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ce7b7...aa6d503. Read the comment docs.

@mistercrunch Fixed.

Can we now remove flask-script from our setup.py & requeirments.txt ?

@mistercrunch Oh, yeah good call. Sorry about that.


filteringSelect labelFunc displayedValue

In several cases there was slight confusion created by a mismatch between the labelFunc value and the displayedValue in the selection. As shown in the GenomeNameSelector.

Andrew, is this related to to the genome annotation [and/or other services] submission form?
Do you know how this should be addressed, what category it belongs to, and who should it be assigned to?

This was fixed.


Migration to change the type of a primary key

In the model I have changed the primary key type from string to long. The initial migration tries to change the column to identity which fails. I have simply changed it to a drop column and re-add the column. This also failed because of the foreign key constraints. Now my Up migration looks like:
            migrationBuilder.DropPrimaryKey("PK_Patient", "Patient");
            migrationBuilder.DropForeignKey("FK_PatientAllergy_Patient_PatientId", "PatientAllergy");
            migrationBuilder.DropForeignKey("FK_MedicationOrder_Patient_PatientId", "MedicationOrder");

            migrationBuilder.DropColumn(
                           name: "PatientId",
                           table: "Patient");
            migrationBuilder.AddColumn<long>(
                name: "PatientId",
                table: "Patient",
                nullable: false);
            migrationBuilder.AddPrimaryKey("PK_Patient", "Patient", "PatientId");

            migrationBuilder.AlterColumn<long>(
                name: "PatientId",
                table: "PatientAllergy",
                nullable: true,
                oldClrType: typeof(string),
                oldNullable: true);

            migrationBuilder.AlterColumn<long>(
                name: "MRN",
                table: "Patient",
                nullable: false,
                oldClrType: typeof(string),
                oldNullable: true);

            migrationBuilder.AlterColumn<long>(
                name: "PatientId",
                table: "MedicationOrder",
                nullable: true,
                oldClrType: typeof(string),
                oldNullable: true);

            migrationBuilder.AddForeignKey("FK_PatientAllergy_Patient_PatientId", "PatientAllergy", "PatientId", "Patient");
            migrationBuilder.AddForeignKey("FK_MedicationOrder_Patient_PatientId", "MedicationOrder", "PatientId", "Patient");

But I get the error that
System.ArgumentNullException: Value cannot be null.
Parameter name: identifier

The full exceptions details:
Applying migration '20180424212553_ImplementRepository'.
System.ArgumentNullException: Value cannot be null.
Parameter name: identifier
   at Microsoft.EntityFrameworkCore.Utilities.Check.NotEmpty(String value, String parameterName)
   at Microsoft.EntityFrameworkCore.Storage.Internal.SqlServerSqlGenerationHelper.DelimitIdentifier(String identifier)
   at System.Linq.Enumerable.SelectArrayIterator`2.MoveNext()
   at System.String.Join(String separator, IEnumerable`1 values)
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.ColumnList(String[] columns)
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.ForeignKeyConstraint(AddForeignKeyOperation operation, IModel model, MigrationCommandListBuilder builder)
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.Generate(AddForeignKeyOperation operation, IModel model, MigrationCommandListBuilder builder, Boolean terminate)
   at Microsoft.EntityFrameworkCore.Migrations.SqlServerMigrationsSqlGenerator.Generate(AddForeignKeyOperation operation, IModel model, MigrationCommandListBuilder builder)
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.<>c.<.cctor>b__63_1(MigrationsSqlGenerator g, MigrationOperation o, IModel m, MigrationCommandListBuilder b)
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.Generate(MigrationOperation operation, IModel model, MigrationCommandListBuilder builder)
   at Microsoft.EntityFrameworkCore.Migrations.SqlServerMigrationsSqlGenerator.Generate(MigrationOperation operation, IModel model, MigrationCommandListBuilder builder)
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.Generate(IReadOnlyList`1 operations, IModel model)
   at Microsoft.EntityFrameworkCore.Migrations.SqlServerMigrationsSqlGenerator.Generate(IReadOnlyList`1 operations, IModel model)
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.GenerateUpSql(Migration migration)
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.<>c__DisplayClass13_2.<GetMigrationCommandLists>b__2()
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.Migrate(String targetMigration)
   at Microsoft.EntityFrameworkCore.Design.Internal.MigrationsOperations.UpdateDatabase(String targetMigration, String contextType)
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.UpdateDatabase.<>c__DisplayClass0_1.<.ctor>b__0()
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.Execute(Action action)
Value cannot be null.
Parameter name: identifier

What should be the correct migration?
Steps to reproduce
change the model from string to long
from the PW console in Visual Studio
add-migration
update-database
Further technical details
EF Core version: "Microsoft.EntityFrameworkCore.Tools" Version="2.0.2"
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10
IDE: Visual Studio 2017 15.6.6

@KevinBurton We're having a bit of trouble figuring out what you are trying to do and what happened. Would it be possible to supply a runnable project/solution or code listing that demonstrates where EF Core did the wrong thing in the scaffolded migration?

I am trying to change the Primary key type. Before it was
    public class Patient
    {
        [Key]
        public string PatientId { get; set; }

I would like to change it to
    public class Patient
    {
        [Key]
        public long PatientId { get; set; }

When the change is made the migration that is generated from the add-migration attempts to make it into a Identity column which when I do 'update-database' I get an error that the column has to be dropped before this can happen. Then I get into the realm of hand editing the generated migration. There are other FK that reference this PK so I just end up changing the migration. I rolled back all of this so the attached project is before I make the change. PocketNurse.zip To see the problem change the type of the property in the model Model/Patient.cs to long (from string) and then do add-migration to see the migration,
the error will become apparent.
Thank you.

@KevinBurton To configure it as a normal long column, use:
[Key]
[DatabaseGenerated(DatabaseGeneratedOption.None)]
public long PatientId { get; set; }

Migrations should not then try to create an Identity column.

Thank you now I have another database column that I would like to be identity. If I change the property from string to int (in the model) From
        [Key]
        public string CabinetId { get; set; }

to
        [Key]
        public int CabinetId { get; set; }

The generated migration is
        protected override void Up(MigrationBuilder migrationBuilder)
        {
            migrationBuilder.AlterColumn<int>(
                name: "CabinetId",
                table: "CabinetSession",
                nullable: true,
                oldClrType: typeof(string),
                oldNullable: true);

            migrationBuilder.AlterColumn<int>(
                name: "CabinetId",
                table: "Cabinet",
                nullable: false,
                oldClrType: typeof(string))
                .Annotation("SqlServer:ValueGenerationStrategy", SqlServerValueGenerationStrategy.IdentityColumn);
        }

        protected override void Down(MigrationBuilder migrationBuilder)
        {
            migrationBuilder.AlterColumn<string>(
                name: "CabinetId",
                table: "CabinetSession",
                nullable: true,
                oldClrType: typeof(int),
                oldNullable: true);

            migrationBuilder.AlterColumn<string>(
                name: "CabinetId",
                table: "Cabinet",
                nullable: false,
                oldClrType: typeof(int))
                .OldAnnotation("SqlServer:ValueGenerationStrategy", SqlServerValueGenerationStrategy.IdentityColumn);
        }

but update-database gives me a stack trace and an error:

Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager[0]
      User profile is available. Using 'C:\Users\Kevin\AppData\Local\ASP.NET\DataProtection-Keys' as key repository and Windows DPAPI to encrypt keys at rest.
Microsoft.EntityFrameworkCore.Infrastructure[10403]
      Entity Framework Core 2.0.2-rtm-10011 initialized 'PocketNurseContext' using provider 'Microsoft.EntityFrameworkCore.SqlServer' with options: None
Microsoft.EntityFrameworkCore.Database.Command[20101]
      Executed DbCommand (9ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
      SELECT OBJECT_ID(N'__EFMigrationsHistory');
Microsoft.EntityFrameworkCore.Database.Command[20101]
      Executed DbCommand (0ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
      SELECT OBJECT_ID(N'__EFMigrationsHistory');
Microsoft.EntityFrameworkCore.Database.Command[20101]
      Executed DbCommand (1ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
      SELECT [MigrationId], [ProductVersion]
      FROM [__EFMigrationsHistory]
      ORDER BY [MigrationId];
Applying migration '20180501221826_ChangeCabinetKeyType'.
Microsoft.EntityFrameworkCore.Migrations[20402]
      Applying migration '20180501221826_ChangeCabinetKeyType'.
System.InvalidOperationException: To change the IDENTITY property of a column, the column needs to be dropped and recreated.
   at Microsoft.EntityFrameworkCore.Migrations.SqlServerMigrationsSqlGenerator.Generate(AlterColumnOperation operation, IModel model, MigrationCommandListBuilder builder)
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.<>c.<.cctor>b__63_4(MigrationsSqlGenerator g, MigrationOperation o, IModel m, MigrationCommandListBuilder b)
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.Generate(MigrationOperation operation, IModel model, MigrationCommandListBuilder builder)
   at Microsoft.EntityFrameworkCore.Migrations.SqlServerMigrationsSqlGenerator.Generate(MigrationOperation operation, IModel model, MigrationCommandListBuilder builder)
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.Generate(IReadOnlyList`1 operations, IModel model)
   at Microsoft.EntityFrameworkCore.Migrations.SqlServerMigrationsSqlGenerator.Generate(IReadOnlyList`1 operations, IModel model)
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.GenerateUpSql(Migration migration)
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.<>c__DisplayClass13_2.b__2()
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.Migrate(String targetMigration)
   at Microsoft.EntityFrameworkCore.Design.Internal.MigrationsOperations.UpdateDatabase(String targetMigration, String contextType)
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.UpdateDatabase.<>c__DisplayClass0_1.<.ctor>b__0()
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.Execute(Action action)
To change the IDENTITY property of a column, the column needs to be dropped and recreated.

@KevinBurton  As the message says, this change requires the table to be re-built, which is something that Migrations doesn't yet support--it is being tracked by #329. To make this kind of change you will have to manually drop and re-create the table. This can be done by writing your own Drop/Create methods in the Migration, or by using raw SQL commands against the database.


doc: fix examples in README

Problem
The one-time snippet does not work as is and complains that the speaker is not defined
 > initialization of speaker-embedding layers.
 > Text: Перевірка мікрофона
 > Text splitted to sentences.
['Перевірка мікрофона']
Traceback (most recent call last):
  File "/home/serg/.local/bin/tts", line 8, in <module>
    sys.exit(main())
  File "/home/serg/.local/lib/python3.8/site-packages/TTS/bin/synthesize.py", line 350, in main
    wav = synthesizer.tts(
  File "/home/serg/.local/lib/python3.8/site-packages/TTS/utils/synthesizer.py", line 228, in tts
    raise ValueError(
ValueError:  [!] Look like you use a multi-speaker model. You need to define either a `speaker_name` or a `speaker_wav` to use a multi-speaker model.

Also it speakers.pth should be downloaded.
Fix
Just a few documentation changes:

make instructions on what to download from Releases more precise
add --speaker_id argument with one of the speakers

@robinhad Hi, here is a suggestion on how to improve the documentation. The original snippet for a one-time run did not work for me and I had to do some changes to make it work. It could be helpful for others

Thank you @seriar! I also believe this whole section needs to be updated to highlight that you will use model without normalizer and autostress feature.


Built locally VFT does not work

Today's VS 2017 RC release
Microsoft Visual Studio Enterprise 2017 RC
Version 15.0.25920.0 D15REL

Uninstall VFT VSIX
build VisualFSharp.sln with msbuild
Install VisualFSharpFull.vsix (all other ones fail to install)
Open a F# solution

Results:

*.fs files do not colorized and no features work
*.fsx files colorized completely properly
build command does not work: nothing is happening, build process is in "in progress" state forever.

@vasily-kirichenko I've been able to build and install VisualFSharpFull.vsix correctly.  I'm using a command line install/uninstall
VSIXInstaller.exe  /a /u:"VisualFSharp"
VSIXInstaller.exe /a  debug\net40\bin\VisualFSharpFull.vsix

.fs files outside of projects are not colorized.  That's a known bug (need to search for ID)

@dsyme .fs files which belong to projects weren't colorized either. I'll try to install with vsixinstaller.exe later today. Thanks!

If I install Debug VSIX, nothing works, except .fsx files colorizing.
If I install Release VSIX, everything works, except .fsx files - it says it cannot find FSharp.Core.dll <IP_ADDRESS>

The way it works for me (as @dsyme added into DEVGUIDE.MD recently): set VisualFSharpOpenSource.vsix as startup project and hit Ctrl+F5 (F5 does not work for me, experimental instance crashes on start), then I can attach to it manually and debug.

@vasily-kirichenko Good to know.  (F5 is working for me)


Improve sm screen display

Various changes to improve the look of elements on the page when screen-width is restricted to half of a laptop/desktop monitor, including:

Font sizes are decreased slightly to make for less bloat without limiting readability.
Prevent text overflowing of copy button when full on small screens.
Slightly decrease the margins on small screens.
Fix text-wrap on toxicity AdverseEvent dropdowns.
Fix text overflow on toxicity Grade menu items when on small screens.
Improved margins on disease status Status buttons to fix weird margins displayed when rows wrap.
Increased margin-bottom of ShortcutViewer for better reading when copy button is full of content.
Changed up helper-text padding for more uniform display on all screen sizes.

Let me know if there is anything else you flagged as looking odd on smalls screens and whether or not you would like me to make those fixes in this sprint or if we want to make separate tasks.

This looks good! One thing that I noticed that I think related to the margin-bottom on ShortcutViewer. When the copy button has a lot of information in it, I can't scroll down enough to see the date picker for the Reference Date.

Looks like this problem only comes up when the browser is restricted to mobile-phone sizes. Right now, for this task, I worked on improving styling for when browser width takes up ~1/2 of the screen.

That make sense to me. This looks good then. Nice work!

... Good enough to approve? :)

This looks really good overall. One thing I noticed, and could probably wait for next sprint, is a decision on how the T, N, and M values should look. When those buttons become less wide than the text "#M0", it overflows. This may be the best way to handle this case, or perhaps we could hide the #?

My bad -- the jira task was for slim mode changes. Changed the task headline.