First element without animation?

Hello! First, I want to say thanks for this splendid plugin! And second, could I remove or dont apply "InEffects" only in the first element of a list?
For example,
h1 class="tlt"
ul class="texts"
li Some Title /li
liAnother Title /li
/ul
/h1
Can the first element remove the "inEffect"??
Thanks a lot!

Not nicely. I've accomplished something similar by defining a noneIn css animation that doesn't actually result in any animation.

Okay, dont worry. It isn't that important! Thanks!


Add init operation #95

Added init, takeRight and dropRight #95.

Tests would be lovely!

this is from the Scala open source spree, Copenhagen 2017

I'll start work on moving the buffer initialization logic inside hasNext/next as suggested by @szeiger. Might take a couple of days though as I'm off to the sun for a week :sunglasses:

Wait, I’m not sure we should have a such a lazy semantic on strict collections.

Thanks @odd!


[Feature]: Migrate from xdm to mdx-js v2

What is the new or updated feature that you are suggesting?
A few days ago MDX 2 got released!
I propose to migrate from xdm to mdx-js v2.
Why should this feature be included?
As far as I understand all features from xdm are now part of mdx-js v2.
Also, it seems like xdm could not be supported sometime in the future.
(see: wooorm/xdm/issues/94 and  kentcdodds/mdx-bundler/issues/137)
For me, it would make sense to migrate to the official mdx-js for these reasons.
Is this something you would want as well?
Or is someone already working on this? Would you be interested in a PR?

xdm now explicitly recommends using mdx 2 as well.

Happy to take a PR to address this. Going to close the issue as it's not a top priority in the meantime.

Hey, I have opened a PR for this here: https://github.com/remix-run/remix/pull/4054. As a bonus, removing xdm will remove deasync, which is a native dependency that requires compilation (which can break).


Return to train mode after validation

Validation can occur before end of epoch, which sets model mode to eval.
Training will have no effect until end of the epoch.

@nolsigan thanks! d10dd3062824195fe5cc9d196b4af4081247bb3f should fix this.


[#5059] Modify to use standard API of the module

Fixed to automatically discover all providers

Codecov Report

Merging #5518 into master will decrease coverage by 0.01%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master    #5518      +/-   ##
==========================================
- Coverage    40.8%   40.79%   -0.02%
==========================================
  Files        2820     2821       +1
  Lines       84801    84812      +11
  Branches    11298    11298
==========================================
- Hits        34602    34597       -5
- Misses      47178    47191      +13
- Partials     3021     3024       +3

Impacted Files
Coverage Δ

...npoint/bootstrap/module/UnsupportedJavaModule.java
0% <0%> (ø)
:arrow_up:

...navercorp/pinpoint/bootstrap/module/Providers.java
77.77% <77.77%> (ø)

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0%> (-11.12%)
:arrow_down:

...pc/server/LoggingServerMessageListenerFactory.java
90% <0%> (-10%)
:arrow_down:

.../profiler/sender/StandbySpanStreamDataStorage.java
72.88% <0%> (-3.39%)
:arrow_down:

...cluster/zookeeper/ZookeeperClusterDataManager.java
62.5% <0%> (-2.21%)
:arrow_down:

.../pinpoint/rpc/client/PinpointClientHandshaker.java
65% <0%> (-1.43%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
72.54% <0%> (-0.99%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
79.92% <0%> (-0.36%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f75bf...050e101. Read the comment docs.


Consume terra-dev-site 1.0

Delete site, action header, error view and no data view
Summary
Move examples.
Delete site, action header, error view and no data view
Thanks for contributing to Terra.
@cerner/terra

We can remove the i18n section on the repo readme at the time since there no internationalized components in terra-clincial

@emilyrohrbough onset picker is internationalized, but that section on the read me is dumb and gets outdated very easily. I'll remove it.

Ah, forgot about that one.


Plugin API done() is called to often - in this case before additional compiler passes

We use Webpack in an SSR React application. We have a build dependency between our client and server. The client has to be build before starting building the server. In our current code base we experienced something new... which was probably introduced during recent Webpack v2 development:

The client part is building code and completed.
The server part is building.
The client is building again.
The server is building again.

This first felt like some kind of race condition. I spend some more time debugging it and I break it down to this section in Compiler.js inside emitAssets():
var stats = compilation.getStats();
stats.startTime = startTime;
stats.endTime = new Date().getTime();
self.applyPlugins("done", stats);

Our current code based looks like this:
compiler.plugin("done", (stats) =>
{
  if (!stats.hasErrors()) {
    console.log("Done")
    resolve(compiler)
  }
})

resolve() is the promise method which leads to the execution of the server method.
So in a abstract way the execution flow looks like:

Start Client 1
Done Client 1 (in additional pass handling)
Start Server 1
Start Client 2 (from additional pass handling)
Done Server 1
Done Client 2
Start Server 2
Done Server 2

Even if rebuilding the client is required... which is another bug I investigate, it should most definitely not rebuild the server two times as well. Running these two processes in parallel is also problematic because of some possible conflicts during runtime (they use different webpack configs).
The questions would be:

Is the current behavior what you intend with calling done() two times?
Is there a way to detect whether this is really the last done()
Is there probably another API available which better fits a kind of "complete" requirement?

This is the interesting line:
https://github.com/webpack/webpack/blob/master/lib/Compiler.js#L66

It seems that, looking at the current code base, I do not have access to the needAdditionalPass flag which is being set during the process.

This issue also transports through other plugins like DevMiddleware as this middleware also listens to done hooks for updating the client etc. I can't think of a reason why it would make sense to send updates to the client when the bundle is regarded as not yet valid by Webpack.
Have a look here:
https://github.com/webpack/webpack-dev-middleware/blob/master/lib/Shared.js#L101

The current implementation with calling done() earlier = just before an additional pass is probably also wrongly documented: "All is done."

Because of filesystem accuracy it can happen that webpack compiles twices (it's unsure if files were changed). You can filter these build by comparing the build hash with the last one.

Can you explain this further? How would such code look like?
I think we have to implement this in the webpack-dev-middleware as well, as it currently seems to report being ready, when it's actually still compiling the additional pass.

What I came up with as a quick fix is to replace the usage of compiler.plugin("done", ...) calls in my application with a StatusPlugin:
https://gist.github.com/swernerx/1f1c0ff09ee393e7cd831e60c2c2b01a


[Feat] Add the ability to set modes to bonuses

Add a field to bonuses to set modes to a bonus. Currently, I'd like to support add, subtract, and multiply as modes. The override mode is a bit more complicated but that can be supported as well by using that bonus to change the base value of a field during the initial calculation.

This can't be accomplished via the bonus system. Overrides need to be handled with effects.


[fireflyiii_data_importer] Option to run automatically command line on addon startup/repeat

Which addon?
Firefly iii Data Importer
Is your feature request related to a problem? Please describe.
The Data Importer runs fine but currently requires manual action to import it, which is not useful to automate and have a low effort personal finance tracker. The source docker program allows for imports to be performed through CLI too, and the author recommend setting up a cron or something like that to trigger the command line to auto-import.
Describe the solution you'd like
The addon would feature a new config boolean askign whether the addon should attempt autoimport on startup. Then also the addon would look at a specific folder under its config and proceed to load what files it finds as per the described documentation here.
Describe alternatives you've considered
The only alternative I can think of is having a keyboard and mouse recorded to do this steps, but even that wouldn't allow for an unattended server setup.
Additional context
According to the docs, fors this to work it should be implemented that: if the config flag is marked, then the docker should run at the end of its startup the line:
# docker
docker exec -it <container> php artisan importer:auto-import /import
#self hosted
php artisan importer:auto-import /path/to/your/files

where /import is the config folder with the files to import.

Thanks for the detailed and precise request. I'll look at it as soon as possible

Thanks for the prompt feedback! Looking forward to your findings.
I see there's related .env variables available, although not sure if them alone would be enough for this to already be working "as is" or still some modifications would be needed on the dockerfile.
#
# Auto import settings. Due to security constraints, you MUST enable each feature individually.
# You must also set a secret. The secret is used for the web routes.
#
# The auto-import secret must be a string of at least 16 characters.
# Visit this page for inspiration: https://www.random.org/passwords/?num=1&len=16&format=html&rnd=new
#
# Submit it using ?secret=X
#
AUTO_IMPORT_SECRET=

#
# Is the /autoimport even endpoint enabled?
# By default it's disabled, and the secret alone will not enable it.
#
CAN_POST_AUTOIMPORT=false

#
# Is the /autoupload endpoint enabled?
# By default it's disabled, and the secret alone will not enable it.
#
CAN_POST_FILES=false

#
# Import directory white list. You need to set this before the auto importer will accept a directory to import from.
#
IMPORT_DIR_WHITELIST=

Hello, so I've enabled cron, for which you can select update frequency as hourly/daily/weekly. It runs an equivalent to php artisan importer:auto-import /path/to/your/files ; where /path/to/your/files  corresponds to the CONFIG_LOCATION/import_configs ; CONFIG_LOCATION being described in the addon options as default /config/addons_config/fireflyiii_data_importer. So, the location where files should be added is /config/addons_config/fireflyiii_data_importer/import_configs.
Hope it will work :-) I don't have a config so if you have some time let's troubleshoot that together - if you can run it and tell me if you have any error messages! Thanks!
(if what I noted makes no sense - just run the addon and everything will be in the log :-) )

Hi,
Thanks for the quick implementation. I looked at the new folder structure (within CONFIG_LOCATION) and saw that there's now 2 folders, and the naming has a trailing close parenthesis sign.
Could you check that maybe remove the extra ")" and identify the difference between these 2 folders?

Also, the configuration pane now has two 'empty' entries. i understand one would be to disable the periodic cron, but the other one?

Thanks.

Hi, thanks for the feedback. I'll correct those in the version I've pushed now.
Here is the difference between both :

Configurations can be added in the /config/addons_config/fireflyiii_data_importer/configurations folder according to :https://docs.firefly-iii.org/data-importer/help/config/
An auto import can be made by adding files in /config/addons_config/fireflyiii_data_importer/import_files according to : https://docs.firefly-iii.org/data-importer/usage/command_line/

Hi, Sorry busy during the workweek. I had this running during the week without any import file just to check if the addon failed. Seems to be stable at least so that's good news.
Then on the auto-import, the files are recognised by the tool on startup. It loads the configs fine in the dropdown options. For the autoimport it identifies the selected schedule, but i'm not sure it is working through cron at all.
I had it running since 09am aprox, with an hourly autoimport, and then updated the file to import at 18h, but at 20.47h it still hasn't been imported. Logs don't show anything either (not sure if it is programmed to output the autoimport logs or not). "Silent" config is not selected.
[09:03:18] INFO: hourly updates
Starting periodic command scheduler: cron.
[09:03:18] INFO: Automatic updates were requested. The files in /config/addons_config/fireflyiii_data_importer/import_files will be imported hourly.
[09:03:18] INFO: Please wait while the app is loading !
Now in entrypoint.sh for Firefly III Data Importer
Script:        1.5 (2021-12-05)
User:          'root'
Group:         'root'
Working dir:   '/var/www/html'
Build number:  93
Build date:    06-02-2022 09:21:56 CET
Firefly III data importer v0.8.0
PHP: cli 8.0.13 Linux
Will now run Apache web server:
[Fri Feb 11 09:03:27.621307 2022] [mpm_prefork:notice] [pid 296] AH00163: Apache/2.4.38 (Debian) configured -- resuming normal operations
[Fri Feb 11 09:03:27.622549 2022] [core:notice] [pid 296] AH00094: Command line: 'apache2 -D FOREGROUND'

More tests. I tried restarting the addon to see if at least on startup it would import the files but it didn't either.
The logs show no change either so I can't tell if it didn't run at all, or if it run but the import failed.

Thanks, my pc broke down but I'll look when it will be possible again. This means the cron doesn't run, as it's first action is anyway a log message saying it is running... My guess is that I used cron.hourly but that it is not implemented in the base distribution, I'll investigate further

Ah... So it seems cron run but it's output is not redirected to docker logs. I'll do some tests

Hi, now it's done :-)
I've redirected the messages from cron to > /proc/1/fd/1 which allows them to appear in supervisor. At least it works from portainer, I'll now update the addon and see if it works as expected

I'll check if it works and report here

typos :-) version-0.8.0-4 will work :-)

(version-0.8.0-4: well I can't fully test as I don't have a running Firefly instance ; but cron jobs executes and shows its output in logs)

I've pushed a new version, should be good : Firefly version-0.8.0-4 ; Data Importer 5.6.14-3

Great. I can see the logs in the Portainer, but not in the Addon logs though.
At least I can see that I have an issue in my import files. I'll try to fix it along this week and report back if everything works fine.
Thanks!!
[2022-02-14 20:17:03] production.DEBUG: Add error on index #0 (line no. 1): Could not parse CSV: Could not decode JSON line #2: Malformed UTF-8 characters, possibly incorrectly encoded

Ok, I updated my import .csv file and it was picked up correctly now (It had to be exported as UTF_8). It was now picked up, and the add-on logs show the full list of messages from the autoimporter action.
It would say this feature is now working as expected :-).

Just one last question, would the cron trigger on add-on start, or it needs to wait until the first recurrence occurrence (i.e., if set to hourly, the first attempt will be done after 1h since Addon start)?

Thanks for the effort! :D

Great news! The cron job works x time after start according to the set duration. But I think it still loads it at boot, just independently from the cron


Indirect set

Write an indirect set function, that will
declare "${flags}" "${1}=${2}"

Where flags are derived from declare -p. This should allow for the removal of some evals, such as
https://github.com/VisionSystemsInc/vsi_common/blob/7def0eac632ed5c4c83a4564be914624d35eee68/linux/ask_question#L93-L94

Won't work with local vars, the scope will be wrong.


fix: PR trigger in autolabeler

There's no such event as synchronized, so I updated the Github Action yml according the official docs
- synchronized
+ synchronize

Ah, I see that was done! Excellent.


Discuss dynamically linked binaries

Today the REX-Ray binary is statically linked -- it has no external dependencies. This issue proposes to build the REX-Ray by linking it to dynamic, external libraries.
This change benefits the new plug-in model (#877) as the plug-ins themselves can dynamically link to the same shared libraries, gaining the ability to communicate with the host process via strongly typed functions instead of generic interface{} values (golang/go#20481). Additionally the size of the REX-Ray binary would be tremendously reduced as it would link against external shared objects for the Go stdlib and the libStorage types.
There is a downside as well. A REX-Ray binary that loads external storage driver plug-ins is still able to be executed if those plug-in files are missing, but if REX-Ray is linked to dynamic libraries and those libraries are missing the binary will fail. Issue #879 already accounts for updates to the package, deployment, and install processes necessary to support Go plug-ins. It would be possible to include the dynamically linked, shared libraries in these changes as well.
This model is identical to how nearly every other Linux program works today, so it's a well known, supported, and understood paradigm.

Hi @vladimirvivien,
I'd appreciate it if you would kick off this discussion since we had a long chat today about this topic. I'm hoping you can help me answer any questions @cduchesne, @codenrhoden, @clintkitson, and @koensayr might have.


[cypher-dsl-parser] Missing MATCHED_PROPERTY callback

While there is the ability to provide callbacks for a lot of events, it seems there is none for knowing which property is matched against a particular node with label.
It seems the matchClause() method in the CypherDslASTFactory has already all the information available in the where argument but it is not passed to the
public Clause matchClause(InputPosition p, boolean optional, List<PatternElement> patternElements, InputPosition patternPos, List<Hint> hints, Where where) {
    var callbacks = this.options.getOnNewPatternElementCallbacks().getOrDefault(PatternElementCreatedEventType.ON_MATCH, List.of());
    return Clauses.match(optional, transformIfPossible(callbacks, patternElements), where, hints);
}

So two different things here:
MATCH (m:Movie {title: 'The Matrix'}) WHERE m.releaseYear IS NOT NULL RETURN m

The pattern element you can already capture will contain the title property.
The where clause is unrelated to this and not necessarily connected to the pattern:
The above gives you
[InternalNodeImpl{cypher=(m:Movie {title: 'The Matrix'})}]
Where{cypher=WHERE (m.releaseYear IS NOT NULL OR false)}

@michael-simons I don't see how, the following callback
UnaryOperator<PatternElement> nodesCollector = patternElement -> {
            patternElement.accept(segment -> {
                if (segment instanceof Node) {
                    Node node = (Node) segment;
                    node.getSymbolicName().map(SymbolicName::getValue).ifPresent(n -> nodes.put(n, node));
                }
            });
            return patternElement;
        };

And the following query
var query = """
                MATCH (p:Person) WHERE p.email = $node.values.email
                MATCH (c:Certification) WHERE c.name="Neo4j Certified Professional"
                RETURN $id as id, exists((p)-[:HAS_CERTIFICATION]->(c)) as neoCertified
                """;

Always yield null for properties

Those properties / expressions are parsed why before being used in a Match clause. I tried a bunch of things that I thought might sense for you, but as I guess you would like to eventually rewrite the MATCH itself, I do now allow this.
You can just collection everything in the match factory now and do as you please, or shape the match like you want it. I added an example for the latter. I hope this helps.


Install fails unless requests is already installed

This is under a python 3 venv:
$ .venv/bin/pip install pycrayon
Collecting pycrayon
  Downloading pycrayon-0.5.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-4hvqb18r/pycrayon/setup.py", line 2, in <module>
        from pycrayon.crayon import __version__
      File "/tmp/pip-build-4hvqb18r/pycrayon/pycrayon/__init__.py", line 1, in <module>
        from .crayon import CrayonClient
      File "/tmp/pip-build-4hvqb18r/pycrayon/pycrayon/crayon.py", line 1, in <module>
        import requests
    ImportError: No module named 'requests'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-4hvqb18r/pycrayon/

$ .venv/bin/pip install requests pycrayon
Collecting requests
  Downloading requests-2.13.0-py2.py3-none-any.whl (584kB)
    100% |████████████████████████████████| 593kB 2.3MB/s
Collecting pycrayon
  Using cached pycrayon-0.5.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-xyawjvaw/pycrayon/setup.py", line 2, in <module>
        from pycrayon.crayon import __version__
      File "/tmp/pip-build-xyawjvaw/pycrayon/pycrayon/__init__.py", line 1, in <module>
        from .crayon import CrayonClient
      File "/tmp/pip-build-xyawjvaw/pycrayon/pycrayon/crayon.py", line 1, in <module>
        import requests
    ImportError: No module named 'requests'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-xyawjvaw/pycrayon/

$ .venv/bin/pip install requests
Collecting requests
  Using cached requests-2.13.0-py2.py3-none-any.whl
Installing collected packages: requests
Successfully installed requests-2.13.0

$ .venv/bin/pip install pycrayon
Collecting pycrayon
  Using cached pycrayon-0.5.tar.gz
Requirement already satisfied: requests in ./.venv/lib/python3.5/site-packages (from pycrayon)
Building wheels for collected packages: pycrayon
  Running setup.py bdist_wheel for pycrayon ... done
  Stored in directory: /home/elis/.cache/pip/wheels/f2/39/f0/b7168e93688c8d36ffaae3c0ca5a9a928c5173d01baf69aeff
Successfully built pycrayon
Installing collected packages: pycrayon
Successfully installed pycrayon-0.5

Hi,
Thanks for reporting the problem.
I think it comes from the fact that we currently use distutils to package everything and that does not install missing dependencies.
We will switch to setuptools for the next release which should fix the issue.

From the time being this step should really be added to the README file.


Added button to exit customization page

Fixes #69
I hope the design of the button is satisfactory.

I've changed the button sizes and changed the label as well! 😄

@soumyankar I think 'exit' would be a better label than close :)

@soumyankar I think 'exit' would be a better label than close :)

Done!


Update !modpings off confirmation to use a discord timestamp.

Closes #2168.
The embed confirmation in !modpings off has been removed in favour of a standard message using the new discord timestamp feature to show both the date and time.
NB: Currently untested as on holiday, but everything should be good. I've added the "do not merge" tag until this is verified.

Have confirmed that the new !modpings off command message works as intended:

This PR is now ready for review :smile:


Span with custom strides?

Is there an easy way to use multidimensional span with custom strides?
Sometimes data is stored in a different order (row-major vs column-major).

Not atm. I haven't thought too much about it, but I have considered making a column-major variant. Will look more into this later.

I will soon commit an updated version of cspan.h on the dev43 branch with option to create column-major (or layout left) md spans. cspan_md_left(arr, ...) instead of cspan_md(arr, ...). In addition there will be a cspan_transpose(&ms) function to transpose the mdspan (will NOT change the underlying array, just the span itself).

Closed. Added support for column-major md span views in dev43 branch. Currently there is a API change, in cspan_md() with either 'C' or 'F' as first argument. I haven't decided if I revert to the description in prev. post for the 4.3 release.


Update UI and remove dummy text

👷 Deploy Preview for inclusiosoft processing.

Name
Link

🔨 Latest commit
8a4fff950b369539d6fc8b9b5303d2a21cf3c828

🔍 Latest deploy log
https://app.netlify.com/sites/inclusiosoft/deploys/654d389d0c3ccd0008916321


How to use the API function

Checks

[X] This template is only for question, not feature requests or bug reports.
[X] I have thoroughly reviewed the project documentation and read the related paper(s).
[X] I have searched for existing issues, including closed ones, no similar questions.
[X] I confirm that I am using English to submit this report in order to facilitate communication.

Question details
Thank you to the author, a great project.
I have read the user manual, but it does not cover how to use the API. I hope you can add instructions on how to use the API. Thank you again

this issue better suit for a "help wanted" template, will close here~


Added placeholder texts for aliases and keybinds

Also replaced some waits with task.wait

Doing some changes.

Im Done.

Ok.


Merge back master

Merge changes from master back to feature branch in order to enable Spring Boot 2 support for Failsafe Actuator.

:+1:

:+1:

:+1:


Incorrect vertical text alignment in red warning tile

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[x] Bug is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[x] Bug is not already reported in another issue

Technical details

Device name: iPhone 12 Pro
iOS version: 15.3.1
App version: 2.18.1

Describe the bug

The text in the red warning tile on the main screen is not aligned correctly in the vertical direction, both compared to the horizontal separators (especially for the exposure date) and the icons on the left. The alignment is however correct in the similar popup opened when tapping on the tile. See screenshots below.
Steps to reproduce the issue

Expected behaviour

The text should be aligned correctly w. r. t. the horizontal separators and the icons.
Possible Fix

At first glance, the problem seems to be the line break in the first row. After all, green tiles only require a single line for Keine Risikobegegnungen, and the alignment was always fine there (unfortunately, I have no screenshot to confirm this).
Additional context

Internal Tracking ID: EXPOSUREAPP-12161

@kkopper Thanks for reporting, we will create an internal ticket shortly.

Thanks for your report @kkopper. We have created an internal ticket for it and will raise this topic internally.
Internal Tracking ID: EXPOSUREAPP-12161

Corona-Warn-App Open Source Team

FYI: PR #4308 is the fix for this issue.


Inspect action.campaign for photo/text post topics

What's this PR do?
This pull request modifies the request helper to first check for whether a topic has an action set per new changes in https://github.com/DoSomething/graphql/pull/320.
If the topic does have an action set, use the nested action.campaign to set the req.campaign for the request. We'll eventually be removing the campaign reference field from the photo/text post topic content types, as it's redundant.
How should this be reviewed?
👀
Any background context you want to provide?
Once this is in place, we can remove the campaign reference field from the TextPostTopic and PhotoPostTopic GraphQL types, and delete the reference field in Contentful.
Relevant tickets
References Pivotal #176602032.
Checklist

[ ] Documentation added for new features/changed endpoints.
[ ] Tests added/updated for new features/bug fixes.
[ ] ENV variables added/updated for new features/bug fixes.
[ ] Tested on staging.
[ ] Pinged a PM if this is a larger PR that would benefit from some additional testing love.

This work would require a bit more refactoring than I anticipated -- we'd need to make similar changes to the executeInboundTopicChange request helper, as well as the hasActiveCampaign topic helper it calls:
https://github.com/DoSomething/gambit/blob/700b46e3fcbe98327384532bea8809743c4b7d7e/lib/helpers/request.js#L43-L48
Holding off on this for now,  as I thought I'd be able to knock this out today -- but we'll need to save it for a future cleanup sprint.


Daemon/Model: Add missing gst initialization

This patch adds GStreamer initialization procedure into init_model_module. Without the initialization, D-Bus interfaces for the models inproperly work.
Signed-off-by: Wook Song<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #349. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


Etherscan verify chokes for artifacts that don't have metadata (were compiled elsewhere)

I've switched over our deployment system to use buidler-deploy and so far it's AWESOME.  I love this tool.
However, I'm having trouble using the etherscan-verify command as several of my artifacts don't have any metadata, as they were deployed using the contracts option and therefore have incomplete artifacts.
It would be really helpful to be able to pass the list of deployment names we want verified.  I figure this line needs to change.  Or, perhaps it can just silently ignore deployments that don't have any metadata.
Thoughts?

I guess I could add a --silent option?
Because for some it is useful to know which contract cannot be verified
On Sun, Aug 9, 2020, 00:55 Brendan Asselstine<EMAIL_ADDRESS>wrote:

I've switched over our deployment system to use buidler-deploy and so far
it's AWESOME. I love this tool.
However, I'm having trouble using the etherscan-verify command as several
of my artifacts don't have any metadata, as they were deployed using the
contracts option and therefore have incomplete artifacts.
It would be really helpful to be able to pass the list of deployment names
we want verified. I figure this line
https://github.com/wighawag/buidler-deploy/blob/3c9a35ea27654f892e3fb0473e33226668e73938/src/etherscan.ts#L370
needs to change. Or, perhaps it can just silently ignore deployments that
don't have any metadata.
Thoughts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/wighawag/buidler-deploy/issues/25, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGBANFHBBYDZIEMLW73H7TR7XQV7ANCNFSM4PY4QCHA
.

It is useful to know which ones fail, so perhaps it could simply warn the user when no metadata is available.   Then as you suggested --silent could hide the warnings?


Outdated Information for v2019

Some of the instructions in this doc are outdated for Azure DevOps Server 2019. v2019 does not have the checkbox like the screenshot and text as described in step two. Additionally, step 3 says that new collection dbs will need to be added to the availability group, but I was informed that 2019 will automatically create the new collection dbs in the availability group if the server is configured to point to the availability group.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8228c9ee-94b7-df52-5fa8-18ec1947fd4d
Version Independent ID: e64e295c-1e26-9112-5608-97aae72bf962
Content: Use SQL Server Always-on Availability Groups - Azure DevOps Server
Content Source: docs/install/sql-server/use-always-on-groups.md
Product: devops-server
Technology: tfs-admin
GitHub Login: @aaronhallberg
Microsoft Alias: aaronha

Additionally, the /usesqlalwayson switch is not available for the registerDB command in v2019


show actual date/time on transaction list

It's really difficult to tell what dates the items in the transaction list correspond to because they are all relative dates. "2 months ago" could be March or April, depending on how it counts a month. The transaction list should show the actual date and time of the transaction so that it's easier to reconcile with my Stripe account.

fixed.

Reopening because this has gone back to showing relative dates at some point. In order to do financial accounting we need to be able to see exact dates on transactions and expenses.

@znarf @alanna
Could you provide a procedure for anyone replicate this? Thanks

@alanna @aaronpk  I just checked and it's working as expected in the transactions page.
Ie: https://opencollective.com/babel/transactions


Pre create resources (eg, s3 buckets)

Hi, I've been using moto for mocking s3 responses in tests, I was wondering if there is a way to auto create some s3 buckets so that I don't have to do so manually in the tests.
That would be a great feature for the mock server as well :)

@patrick91 : We use pytest and fixtures in our tests to pre-create resources. Here is an example: https://github.com/Netflix-Skunkworks/historical/blob/master/historical/tests/conftest.py#L122
Every test that makes use of that fixture gets all those resources created a priori.

I'm going to agree with @mikegrima 's suggestion here.
Let us know if that doesn't work for your use case and we can re-examine.


The network name can not be found

Version
Microsoft Windows [Version 10.0.19044.1415]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-microsoft-standard-WSL2
Distro Version
Ubuntu 21.04
Other Software
Windows Terminal, Version: 1.11.3471.0
Repro Steps

Open Windows Terminal with Windows.Terminal.Wsl

Expected Behavior
The terminal should open inside my Ubuntu distro
Actual Behavior
Sometimes I get "The network name can not be found" and the terminal immediately exits.
I think it is a race condition, since this does not always happen. But when it does, I can not start Windows Terminal with Windows.Terminal.Wsl at all, until wsl is started.
My work-around is to open PowerShell and write wsl -d Ubuntu. After that, I can open Windows Terminal as usual.
Diagnostic Logs
wls2.etl.zip

Same problem

I have a same problem when startingDirectory set as "\\\\wsl$\\DISTRO NAME\\home\\USERNAME".
resolve: use commandline: wsl ~ or  wsl -d DISTRO --cd ~
like this:

@fyxw was right. I change the Starting diretory to default value, which i s%USERPROFILE%, problem solved

I have a same problem when startingDirectory set as "\\\\wsl$\\DISTRO NAME\\home\\USERNAME".
resolve: use commandline: wsl ~ or  wsl -d DISTRO --cd ~
like this:

This seemingly solved the problem for me.
I was using Windows Terminal. In its Settings > Profiles > Ubuntu-20.04 > General, I had Command Line set to wsl.exe -d Ubuntu-20.04 and Starting Directory set to the absolute path through the windows filestore to /home/[user] (with backslashes). Changing Starting Directory to %USERPROFILE% stopped the error occurring, but meant the bash opened up in my windows user directory I think. Then appending   --cd ~ to the Command Line argument meant I was back to opening up the bash in my wsl2 ubuntu user directory.

It worked for me to:

change the starting directory to %USERPROFILE%
open a new Ubuntu tab in Windows Terminal
revert the change in %USERPROFILE% to \\wsl$\Ubuntu-20.04\home\myuser\

The fix persists after closing and re-opening Windows Terminal, haven't checked whether rebooting breaks it again tho.

thanks @fyxw - now it works for me.
I still feel this issue should stay open as this is a regression. It's not obvious why this is happening only that the work-around is to have either wsl.exe ~ or wsl.exe -d DISTRO --cd ~ in the Command line field in settings.
The default value for Command line is wsl.exe -d Ubuntu on my system.

Unfortunately, I just got the following error message:
[error 0x8007010b when launching `wsl.exe -d Ubuntu --cd ~']
Could not access starting directory "\\wsl$\Ubuntu\home\dotnet"

So the work-around does not work for me. :(

Unfortunately, I just got the following error message:
[error 0x8007010b when launching `wsl.exe -d Ubuntu --cd ~']
Could not access starting directory "\\wsl$\Ubuntu\home\dotnet"

So the work-around does not work for me. :(

Did you set the startingDirectory to %USERPROFILE% or other windows path, if startingDirectory is a network path, may cause it. \\wsl$\Ubuntu\xxx\ is a network path, it may not exist when wsl is closed.

Hi @fyxw. No, I had startingDirectory sat to \\wsl$\Ubuntu\xxx\. Changing that to the default %USERPROFILE% and Command line to wsl.exe ~ seems to fix my issue. Thanks!

In my case, this was caused by having \\wsl.localhost\Ubuntu\home\username set as the startingDirectory and unknowingly having Virtualisation turned off in my UEFI.
It wasn't until I changed startingDirectory back to %USERPROFILE% that WSL correctly told me that Virtualisation had been turned off.

yeah i did wsl -update and thise network error happened.
solution worked

I had to restart Windows after changing the commandline and startingDirectory settings. Worked perfectly after the restart.

Make sure Virtualization is enabled in BIOS (that's what it's called for intel CPU's) especially if you've been recently messing with your BIOS settings.


Misc formatting fixes for changelog

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[X] Documentation
[ ] Build system

Purpose

Add support for VSCode plugin markdownlint. This requires a new file with rules settings .markdownlint.json for the project.
Full list of rules implemented by this plugin: https://github.com/DavidAnson/markdownlint/blob/v0.11.0/doc/Rules.md
Also including a number of formatting fixes based on markdownlint checks,  plus some spelling in changelog.

you're the best 🙇 !!


Fix problem of starting up mysql 5.7.33 version when user is root

Fixes following problem in console of mysql container
java.lang.IllegalStateException: Container did not start correctly.
	at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:435)
	at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:325)
	at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:323)
	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:311)

[ERROR] [Entrypoint]: MYSQL_USER="root", MYSQL_USER and MYSQL_PASSWORD are for configuring a regular user and cannot be used for the root user
    Remove MYSQL_USER="root" and use one of the following to control the root user password:
    - MYSQL_ROOT_PASSWORD
    - MYSQL_ALLOW_EMPTY_PASSWORD
    - MYSQL_RANDOM_ROOT_PASSWORD

Fixes issue https://github.com/testcontainers/testcontainers-java/issues/3893

@rnorth
Hi. Please check my test

I've noticed a bad (existing) bug when testing this locally... Firstly, I noticed that your testRootAccountUsageWithEmptyPassword test takes >2mins to run.
It seems that setting the password to null causes a NullPointerException here, which is in turn swallowed here.
The terrible thing about the second piece of code is that the connection check fails continuously until timeout is reached, but upon hitting timeout it just continues.
We're going to need to fix that; I think we'll also need to prevent null passwords, to. I will dig a little more and may add a commit to your PR. Please stand by.

I've noticed a bad (existing) bug when testing this locally... Firstly, I noticed that your testRootAccountUsageWithEmptyPassword test takes >2mins to run.
It seems that setting the password to null causes a NullPointerException here, which is in turn swallowed here.
The terrible thing about the second piece of code is that the connection check fails continuously until timeout is reached, but upon hitting timeout it just continues.
We're going to need to fix that; I think we'll also need to prevent null passwords, to. I will dig a little more and may add a commit to your PR. Please stand by.

It seems that setting the password to null causes a NullPointerException

@rnorth I noticed a slow test run but I didn't dig into the reason. Thanks for finding the reason.
I pushed a "fix" and replaced the null with an empty string. This, of course, is not a solution to the NPE but I'd like to have this PR merged separately from NPE problem. which requires a separate issue and PR. What do you think?

@seveneves yes sure, I was going to suggest that. I'll follow up with a change to get null-checks where they need to be.
If you could please add my suggested change, I think we're good.


Not enabled certificate still looking cacert.pem file

Here is a part of my config file:
    'certificate' => [
        'enabled' => false,
        'disk' => 'local',
        'path' => 'szamlazzhu/cacert.pem' // Relative to disk root
    ],

Now I get InvalidClientConfigurationException.
Workaround:
If I create an empty file on this path: storage/app/szamlazzhu/cacert.pem the error is gone.

Hey netdjw,
My apologies, but the organization owner decided to exclude the package maintainers so we're not allowed to perform any hotfix / further development anymore. For now, the best I can advice to you is to clone the entire repository and make your desired changed.
However as I can remember, this issue has been fixed already.


Why some examples of PIXI.js couldn't open source ?

There are some examples of  PIXI.js  not opensource.
I know some examples are commercial , but someones are just showcases  ,  e.g.  someones in goodboy's homepage :
http://christmasexperiments.com/experiments/11/
http://www.goodboydigital.com/client/goodboy/nebulon/
http://christmasexperiments.com/2013/23/
I think they are very useful for use to learn pixi.js.
Why couldn't put them to https://github.com/pixijs/examples  or open source ?

I'm a new user of pixi.js , and   my english is very poor .

I'm  sorry very much.


Update Gaffer version to 2.0.0-alpha-0.5

Closed by https://github.com/gchq/gaffer-tools/pull/1056


[BUG] Classes not detected inside objects with computed property (using clsx callee)

Describe the bug
The plugin won't identify classes inside objects that have a computed property (object[property] or object.property), so doesn't check for any rules (classnames-order in this case).
To Reproduce
// .eslintrc.cjs
module.exports = {
  extends: [
    "plugin:tailwindcss/recommended",
  ],
  settings: {
    tailwindcss: {
      callees: ["clsx"],
    }
  },
  rules: {
    "tailwindcss/no-custom-classname": "off",
     },
  }

// Alert.jsx
import clsx from 'clsx'

let type = 'error'
const alertClass = clsx(
  {
    success: 'border-green-400 bg-green-100 text-green-700',
    warning: 'text-yellow-700 border-yellow-400 bg-yellow-100',
    error: 'bg-red-100 border-red-400 text-red-700',
  }[type],
)

Expected behavior
The plugin should detect the classes and warn of the invalid order.
Screenshots
With the computed property (no linting):

Without property (linting works fine):

Environment (please complete the following information):

OS: Linux Mint 21.2 x86_64
Softwares + version used:

VSCode 1.87.2
"eslint-plugin-tailwindcss": "3.15.1"

Current fix/ workaround:
I managed to fix this issue for the classnames-order rule, by updating the callExpressionVisitor function inside classnames-order.js:
const callExpressionVisitor = function (node) {
  const calleeStr = astUtil.calleeToString(node.callee);
  if (callees.findIndex((name) => calleeStr === name) === -1) {
    return;
  }

  node.arguments.forEach((arg) => {
    if (arg.type === 'MemberExpression' && arg.object.type === 'ObjectExpression') {
      arg.object.properties.forEach((prop) => {
        if (prop.value.type === 'Literal') {
          sortNodeArgumentValue(node, prop.value);
        }
      });
    } else {
      sortNodeArgumentValue(node, arg);
    }
  });
};

Hmm not sure if creating an object and then picking a single element from it is an efficient way of achieving what you are after. If there is ever a fix, it will encourage odd-looking clsx calls which may look confusing for collaborators. In the meantime, you can do this:
const alertClass = clsx(
  type === 'success' && 'border-green-400 bg-green-100 text-green-700',
  type === 'warning' && 'text-yellow-700 border-yellow-400 bg-yellow-100',
  type === 'error' && 'bg-red-100 border-red-400 text-red-700',
)

Or, even better, you can leverage cva:
import cva from 'class-variance-authority';

const alertVariants = cva('', {
  variants: {
    type: {
      success: 'border-green-400 bg-green-100 text-green-700',
      warning: 'text-yellow-700 border-yellow-400 bg-yellow-100',
      error: 'bg-red-100 border-red-400 text-red-700',
    }
  }
});

const alertClass = cva({ type });

Both alternatives are covered by this plugin.


Run ng test in prod mode ng test --prod

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [x] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [x] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

node: 8.9.4
npm: 6.1.0
ng: 6.0.4
Repro steps

ng test --prod
The log given by the failure

After I realized that I had to add a configuration section in angular.json under test architect node (for which was does not appear to be documented anywhere obvious), here is my config:
          "configurations": {
            "production": {
              "sourceMap": false,
              "fileReplacements": [
                {
                  "replace": "src/environments/environment.ts",
                  "with": "src/environments/environment.prod.ts"
                }
              ]
            }
          }

When I try to add "aot": true, I get the following error:
Schema validation failed with the following errors:
  Data path "" should NOT have additional properties(aot).

Which defeats the purpose of trying to run unit tests in prod mode...
Desired functionality

Runs unit tests with a production version of a build (including AOT) and works
Mention any other details that might be useful

Late at night, I dream of being on a beach with the pleasing sound of lapping waves as I run ng test --prod

Heya, we don't support using AOT in unit tests. There's an open feature request at https://github.com/angular/angular-cli/issues/6650 for it.
I can say that last week I was actually on a beach and ran ng test a couple of times, never with --prod though. It was pleasant but have to say the glare on my (glossy) laptop monitor was annoying.

It is misleading though, as the wiki states it's possible:
https://github.com/angular/angular-cli/wiki/test

That flag (--prod) does exist, but using a configuration, such as production, does not mean the same options are available as the browser build.
For instance, you can have a production configuration for tests that includes code coverage, which isn't available on the browser build.


rustc: 1.55.0 -> 1.56.0

Tested building fd, firefox, and thunderbird on x86_64-linux.
Could a Darwin user please report whether nix-build -A fd works with this PR?

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Closing in favour of #142515.


More quantum circuit library refactoring

Summary
As a part of circuit library refactoring #13046, more quantum circuits now have their "modern" variants,
either as gates or as synthesis methods.
This PR adds:

GraphState -> GraphStateGate
FourierChecking -> fourier_checking(...)
UnitaryOverlap -> unitary_overlap(...)
HiddenLinearFunction -> hidden_linear_function(...)
PhaseEstimation -> phase_estimation(...)

Details and comments
For now these are all in Python.

Thanks @Cryoris, I have addressed the suggestions from the code review, and also added some missing tests, and added the functions to the API as in the other PRs.


smallfix (typo in documentation)

Coverage remained the same at 100.0% when pulling b7ad2a3d6b45de3098f40a153f2e29fa01f094f5 on fried-sausage:master into 729239e2324055a90f1b52e9c43f2a29221cee65 on dgilland:master.

Coverage remained the same at 100.0% when pulling b7ad2a3d6b45de3098f40a153f2e29fa01f094f5 on fried-sausage:master into 729239e2324055a90f1b52e9c43f2a29221cee65 on dgilland:master.

Coverage remained the same at 100.0% when pulling b7ad2a3d6b45de3098f40a153f2e29fa01f094f5 on fried-sausage:master into 729239e2324055a90f1b52e9c43f2a29221cee65 on dgilland:master.

Thanks!


attachments=true returns multipart

Hello,
This is regarding couchdb 1.1.0. Before 1.1.0, when retrieving a document with attachments, couchdb was returning a response in application/json content-type when "parameters=true" was passed along. However, 1.1.0 returns the response in multipart content-type so response parsing fails.
http://comments.gmane.org/gmane.comp.db.couchdb.user/14091
As mentioned in this discussion, the response can be retrieved in "application/json" if accept header is supplied with "application/json". Can we pass http header for db.get method or does anyone think of other way of retrieving the attachment in base64?
Thanks.

This should be fixed in<EMAIL_ADDRESS>


Add option to show all keys

Pass in --all to the command to show all options, not just the
different ones

Tested and works! Very cool!

Would be good to update the README with the new option as well.


Error handling UX

Right now some errors make Fether display an empty screen. It would be nice to show a message to the user and for example guide them to report the issue.

related to https://github.com/paritytech/fether/issues/347

Idea:
Error happens; user is shown this screen, or some variant thereof:

An error occured

invalid RPC call
at ...
at ... (stack trace)

Please report this bug by reaching us on GitHub, Twitter, by mail at<EMAIL_ADDRESS>or by using the form below.
--
The bug report will consist solely of the following information:
Error log:
(stack trace)
(fether log, maybe)

Additional comment (what were you doing when the error occured?) :
free text field

[SUBMIT]

Some solutions should exist to set up the form endpoint easily.


Better documentation for creating a custom service

Antonio laid a good foundation for our custom service documentation in #10, but we'll want to expand on this to a more realistic service. The best example to provide would probably be a custom service that uses axum and serenity. For reference, how to do this is discussed and shown in this discord thread: https://discord.com/channels/803236282088161321/1028168259993874472

Completed in #28 :partying_face:


Added currency abstraction

Thanks, @Vaulverin. That's really what this package needs. But some tests are failing, can you fix that?

hm, i'll take a look


feat: Verbose logging with flag

Description
Adds a verbose output flag so that users can troubleshoot AVP usage easier. Goal is to be able to trace:

The final configuration Viper sees
The processing being done for each placeholder
API calls and responses from backends for both authentication and getting secrets

Assuming this looks worthwhile, I think it'd be good for bug reports to include this info to help us debug what's happening. This PR amends the issue template to say that.
Fixes: #307
Checklist
Please make sure that your PR fulfills the following requirements:

[ ] Reviewed the guidelines for contributing to this repository
[ ] The commit message follows the Conventional Commits Guidelines.
[ ] Tests for the changes have been updated
[ ] Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
[ ] Docs have been added / updated
[ ] Optional. My organization is added to USERS.md.

Type of Change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

Other information

Sample output from stderr after running AVP on a template pulling secrets from IBM Cloud SM:
2022/06/02 00:42:42 reading configuration from config file /Users/jkayani/Documents/ops/argo/vault/ibm-sm-creds.yaml, overriding any previous settings
2022/06/02 00:42:42 reading configuration from environment, overriding any previous settings
2022/06/02 00:42:42 AVP configured with the following settings:
2022/06/02 00:42:42 avp_type: ibmsecretsmanager

2022/06/02 00:42:42 avp_ibm_api_key: REDACTED

2022/06/02 00:42:42 avp_ibm_instance_url: REDACTED

2022/06/02 00:42:42 avp_kv_version: 2

2022/06/02 00:42:42 IBM Cloud Secrets Manager enabling 3 API call retries with 20 seconds between tries
2022/06/02 00:42:42 IBM Cloud Secrets Manager listing secrets of from group default starting at offset 0
2022/06/02 00:42:44 IBM Cloud Secrets Manager list secrets in group HTTP response: {
    REDACTED
}

2022/06/02 00:42:44 IBM Cloud Secrets Manager get secret: getting secret beep of type arbitrary from group default
2022/06/02 00:42:44 IBM Cloud Secrets Manager get unversioned secret REDACTED HTTP response: {
    REDACTED
}

2022/06/02 00:42:44 calling GetSecrets to get all secrets from backend because avp.kubernetes.io/path is set to ibmcloud/arbitrary/secrets/groups/default
2022/06/02 00:42:44 found placeholder beep with modifiers []
2022/06/02 00:42:44 found placeholder path:ibmcloud/imported_cert/secrets/groups/default#certs with modifiers [ jsonPath {.certificate}]
2022/06/02 00:42:44 calling GetIndividualSecret for secret certs from path ibmcloud/imported_cert/secrets/groups/default at version
2022/06/02 00:42:44 IBM Cloud Secrets Manager list secrets in group: cache hit group default
2022/06/02 00:42:44 IBM Cloud Secrets Manager get secret: getting secret certs of type imported_cert from group default
2022/06/02 00:42:45 IBM Cloud Secrets Manager get unversioned secret REDACTED HTTP response: {
    REDACTED
}

2022/06/02 00:42:45 processing modifier jsonPath with args ["jsonPath" "{.certificate}"]

Some of the output is out of order, probably b/c of the goroutines being used for this particular backend. It's still mostly traceable though especially with the original template.

Codecov Report

Merging #350 (28e6fb1) into main (81b61bb) will decrease coverage by 6.55%.
The diff coverage is 15.38%.

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
- Coverage   76.68%   70.13%   -6.56%
==========================================
  Files          22       22
  Lines         948     1058     +110
==========================================
+ Hits          727      742      +15
- Misses        137      190      +53
- Partials       84      126      +42

Impacted Files
Coverage Δ

pkg/auth/vault/approle.go
50.00% <0.00%> (-14.71%)
:arrow_down:

pkg/auth/vault/github.go
45.00% <0.00%> (-15.00%)
:arrow_down:

pkg/auth/vault/kubernetes.go
54.05% <0.00%> (-8.45%)
:arrow_down:

pkg/backends/awssecretsmanager.go
57.69% <0.00%> (-10.49%)
:arrow_down:

pkg/backends/azurekeyvault.go
50.00% <0.00%> (-23.53%)
:arrow_down:

pkg/backends/gcpsecretmanager.go
66.66% <0.00%> (-11.60%)
:arrow_down:

pkg/backends/ibmsecretsmanager.go
73.07% <0.00%> (-5.50%)
:arrow_down:

pkg/backends/localsecretmanager.go
52.63% <0.00%> (-14.04%)
:arrow_down:

pkg/backends/onepasswordconnect.go
55.00% <0.00%> (-13.75%)
:arrow_down:

pkg/backends/vault.go
66.66% <0.00%> (-10.26%)
:arrow_down:

... and 8 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jkayani does it make sense to add tests for the verbose logging?

@werne2j I don't know, what do you think? On one hand I don't like taking the hit on code coverage, but on the other, writing tests for this seems a bit silly, since it's really just supposed to be useful debug information.
I wonder if I can refactor so that the calls to the log function aren't wrapped in the conditional and instead the conditional is moved to the function definition - that'd probably reduce the code coverage hit (since the tests we have now would exercise those lines) and make the code a bit cleaner


Release 0.0.2

Hi @xct007
I am trying to use this package since https://github.com/drawrowfly/tiktok-scraper is not working anymore.
Though it looks like you haven't published 0.0.2
Any eta on that ?

Oh sorry, I forgot about this repo 😅.


DATEDIFF implementation for Oracle

Implementing DATEDIFF for Oracle

YEAR
MONTH
DAY
HOUR
MINUTE
SECOND

As the test server is giving errors, here are my tests, everything is satisfactory!
------ Test started: Assembly: Microsoft.EntityFrameworkCore.Oracle.FunctionalTests.dll ------
6140 passed, 0 failed, 51 skipped (see 'Error List / Messages'), took 475,52 seconds (xUnit.net 2.3.1 build 3858)
/cc @bricelam @smitpatel

@ralmsdeveloper - We have decided not to add DateDiff based function for other providers since that function is basically a T-SQL function and customers using other providers may find very little value in it. Certainly based on client side representation, we can arrive at some translation on server side but it would probably un-natural for customer to use such methods. That is the reason we removed translation from SQLite provider also.
Ideally, what we want to translate is date subtraction to server. Currently which has its own mapping issue. i.e. Date subtraction returns TimeSpan but SqlServer has no mapping for that type, so by some means if we arrive at computation of TimeSpan we still cannot create the object on client side properly. But that is SqlServer (and also Sqlite) limitation. Postgre perfectly maps TimeSpan to interval type on database. So if Oracle has a type which would map well with TimeSpan in C# then we would perhaps map it and translate date subtraction as is (or with function) to return TimeSpan.
If Oracle does not have a mapping type then we can look at some well-known Oracle Sql functions which customers find useful and add them to EF.Functions (same as SqlServer adds DateDiff based methods). You can file a new issue for that to start discussion on that.
Hope this explains what direction we are taking when it comes to extending EF.Functions to add provider specific functions. If you have any questions feel free to ask.
With all above in mind, we are not adding DateDiff functions for Oracle so I am closing this PR. (hence I haven't added any feedback)

@smitpatel thanks for every explanation!
But you simply can not handle Oracle by comparing with Postgre.
Another thing is TimeSpan is totally limited.
In a case of retrieving seconds, hours, minutes ... there would have to be an extension anyway!
And yes, Oracle also does the mapping, but I believe it will be difficult to try to do this kind of translation because you have TimeSpan limited to just some information.
Anyway thank you very much for the explanation, I would like to know if you have any idea to translate (Hour, Minute, Second) with TimeSpan.
Long time ago I did an extension for this, but you said it was not what you wanted!

We precisely do not want DateDiff functions on other providers if the provider SQL does not have DateDiff. The boundary definition is bit hard to be put to use for general case and it is less likely that folks not using SqlServer would want to use that. If you have any ideas, create an issue, we can discuss in detail.

@smitpatel yes I will create a problem, there are many situations to use.


Fix conflicting routes for multiple ENIs in IPAM mode

Discovered during investigation of #18868
See comment https://github.com/cilium/cilium/issues/18868#issuecomment-1077682444 of #18868 for more details on the conflicting routes for health endpoints that are left behind during restarts.
In particular we see that the health endpoint gets 2 routes associated with it. When the pod restarts it leaves one route behind, which results in a routing conflict and AWS dropping the packet when the IP is then reused for a real workload pod.
Our idea in solving this is to coalesce the 2 or more CIDR ranges into one.
Cheers,
@dezmodue
@recollir
Signed-off-by: Simone Sciarrati<EMAIL_ADDRESS>Signed-off-by: Federico Hernandez<EMAIL_ADDRESS>

@jibi I have now edited the commit msg and included the sign-off tags as well as deleted the 2 merge commits.
Please let me know if there is anything else that we should do. We have tested the change locally and in a dev cluster, but are unsure on the style and place of the change. Any feedback is appreciated. Thanks.

@gandro we pushed your suggested changes.

A simple test using the function gives
[<IP_ADDRESS>/16 <IP_ADDRESS>/8] => [<IP_ADDRESS>/8]
[<IP_ADDRESS>/16 <IP_ADDRESS>/24] => [<IP_ADDRESS>/16 <IP_ADDRESS>/24]
[<IP_ADDRESS>/16 <IP_ADDRESS>/24 <IP_ADDRESS>/8] => [<IP_ADDRESS>/8 <IP_ADDRESS>/24]

based on
  CIDR := []string{"<IP_ADDRESS>/16","<IP_ADDRESS>/8"}
  newCIDR := coalesceCIDRs(CIDR)
  fmt.Printf("%v => %v\n",CIDR,newCIDR)

  CIDR = []string{"<IP_ADDRESS>/16","<IP_ADDRESS>/24"}
  newCIDR = coalesceCIDRs(CIDR)
  fmt.Printf("%v => %v\n",CIDR,newCIDR)

  CIDR = []string{"<IP_ADDRESS>/16","<IP_ADDRESS>/24","<IP_ADDRESS>/8"}
  newCIDR = coalesceCIDRs(CIDR)
  fmt.Printf("%v => %v\n",CIDR,newCIDR)

@gandro Do you want the unit test in the same single commit? Or do you want to get the squash now as a first contribution and the unit test in a second PR?

Let's do the unit test in the same commit. There are no hard rules here, but to make it easier to read the git history in master, I think a single commit containing everything is the preferred way.

@gandro We should be good to go now.

added a unit test.
ensured gofmt on it.
added copyright to unit test.
squashed everything to one commit.
ensured sign off by me and Simone.

Thanks for guiding us through this.

@gandro There is a failing test due to a missing file. https://github.com/cilium/cilium/runs/6981297570?check_suite_focus=true#step:11:29
It seems to be an example documentation file. How do you want us to deal with this? Are we nevertheless fine with the PR or should we take some action?

@recollir Ah yes, you will have to rebase your branch on the current master. The test suite is running against tests present in master, but the code under test will be built from your branch. This can cause test failures if the branch under test is a bit older, which seems to be the case for you (lagging ~130 commits behind).
Rebasing it on the current master should fix it. Sorry about the inconvenience

@jibi We worked with @gandro on the PR which we finalised yesterday. From what I see your requested changes are all implemented now. Is your approval still needed?
@gandro What is the ongoing procedure for the PR now that you have approved it? Is anything more needed from us for the merge? When are you doing that? Curious to learn on your process.

@gandro What is the ongoing procedure for the PR now that you have approved it? Is anything more needed from us for the merge? When are you doing that? Curious to learn on your process.

Ideally we want approval from all affected code owners. So let's give @jibi some time to re-review, because I'm also not super familiar with all the affected parts here.
In parallel, we also want to make sure this passes our CI testing (thus my /test command triggering CI above). There have been a few failures. You can take a look if you want, but I will also triage this later, to see if they are real failures that need to be addressed or if they are unrelated (our CI is a bit flaky at the moment).

Fair enough @gandro . We will watch any comments/coming in. Though replies from us might be delayed starting next week due to summer. :smiley:

@recollir The failures look legitimate.
There seems to be a nil-pointer panic in allocateDatapathIPs.  cilium-agent logs from one of the Jenkins runs:
2022-06-21T14:50:07.584387758Z [signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x25e2ccd]
2022-06-21T14:50:07.584436558Z
2022-06-21T14:50:07.584621780Z goroutine 1 [running]:
2022-06-21T14:50:07.585014421Z github.com/cilium/cilium/daemon/cmd.(*Daemon).allocateDatapathIPs(0xc000339180, {0x3424da0, 0x52aedc0})
2022-06-21T14:50:07.585285431Z 	/go/src/github.com/cilium/cilium/daemon/cmd/ipam.go:263 +0x3ed
2022-06-21T14:50:07.585760387Z github.com/cilium/cilium/daemon/cmd.(*Daemon).allocateRouterIPv6(0xc000cdee80?, {0x3424da0?, 0x52aedc0?})
2022-06-21T14:50:07.585996698Z 	/go/src/github.com/cilium/cilium/daemon/cmd/ipam.go:193 +0x185
2022-06-21T14:50:07.586157544Z github.com/cilium/cilium/daemon/cmd.(*Daemon).allocateIPs(0xc000339180)
2022-06-21T14:50:07.586410844Z 	/go/src/github.com/cilium/cilium/daemon/cmd/ipam.go:407 +0xe5
2022-06-21T14:50:07.587103380Z github.com/cilium/cilium/daemon/cmd.NewDaemon({0x34215d0?, 0xc0001518c0}, 0xc0000a7b40, 0xc00033cd20, {0x3437db8, 0xc000154180})
2022-06-21T14:50:07.587356540Z 	/go/src/github.com/cilium/cilium/daemon/cmd/daemon.go:1088 +0x67c5
2022-06-21T14:50:07.587470228Z github.com/cilium/cilium/daemon/cmd.runDaemon()
2022-06-21T14:50:07.587750052Z 	/go/src/github.com/cilium/cilium/daemon/cmd/daemon_main.go:1713 +0x7da
2022-06-21T14:50:07.588316113Z github.com/cilium/cilium/daemon/cmd.glob..func1(0x4d27140?, {0x2ecccb4?, 0x1?, 0x1?})
2022-06-21T14:50:07.588558560Z 	/go/src/github.com/cilium/cilium/daemon/cmd/daemon_main.go:128 +0x3aa
2022-06-21T14:50:07.589569177Z github.com/spf13/cobra.(*Command).execute(0x4d27140, {0xc0001ac010, 0x1, 0x1})
2022-06-21T14:50:07.589574826Z 	/go/src/github.com/cilium/cilium/vendor/github.com/spf13/cobra/command.go:860 +0x663
2022-06-21T14:50:07.589576997Z github.com/spf13/cobra.(*Command).ExecuteC(0x4d27140)
2022-06-21T14:50:07.589578897Z 	/go/src/github.com/cilium/cilium/vendor/github.com/spf13/cobra/command.go:974 +0x3b4
2022-06-21T14:50:07.589580818Z github.com/spf13/cobra.(*Command).Execute(...)
2022-06-21T14:50:07.589582568Z 	/go/src/github.com/cilium/cilium/vendor/github.com/spf13/cobra/command.go:902
2022-06-21T14:50:07.589584417Z github.com/cilium/cilium/daemon/cmd.Execute()
2022-06-21T14:50:07.589586308Z 	/go/src/github.com/cilium/cilium/daemon/cmd/daemon_main.go:142 +0x45
2022-06-21T14:50:07.589588093Z main.main()
2022-06-21T14:50:07.589589842Z 	/go/src/github.com/cilium/cilium/daemon/main.go:15 +0x17

Travis CI also seems to be failing due to this panic: https://app.travis-ci.com/github/cilium/cilium/jobs/574223538
This needs to be addressed before we can merge this PR.

Added tests for ipv6

The "build-and-push-prs (cilium, ./images/cilium/Dockerfile)" job seems stuck on the "Load cilium Golang cache build from GitHub" step - it's been logging for a very long time:
Received` 838476060 of 842670364 (99.5%), 0.1 MBs/sec
Received 838476060 of 842670364 (99.5%), 0.1 MBs/sec
Received 838476060 of 842670364 (99.5%), 0.1 MBs/sec
Received 838476060 of 842670364 (99.5%), 0.1 MBs/sec
Received 838476060 of 842670364 (99.5%), 0.1 MBs/sec

Good morning @jibi @gandro, ready to be tested again.

/test

/test

Hi @gandro I looked into the error for the k8s-1.16-kernel-4.9 (test-1.16-4.9) but it is not clear to me what to do next, any guidance appreciated

Hi @gandro I looked into the error for the k8s-1.16-kernel-4.9 (test-1.16-4.9) but it is not clear to me what to do next, any guidance appreciated

Hey @dezmodue - looking at the cilium-agent logs in the artifact file, I see the following timeout:
7622:2022-06-27T10:39:20.882218066Z level=error msg="Cannot create CEP" containerID= controller="sync-to-k8s-ciliumendpoint (579)" datapathPolicyRevision=0 desiredPolicyRevision=0 endpointID=579 error="etcdserver: request timed out" identity=25824 ipv4= ipv6= k8sPodName=/ subsys=endpointsynchronizer

This looks like a ephemeral issue, I'll restart the test.

/test-1.16-4.9

Thank you for restarting the test.

Seems that the tests pass now. @gandro Should we do a final rebase on master. We did not think about that this morning when requesting the new test round. We are about 23 commits behind.

Seems that the tests pass now. @gandro Should we do a final rebase on master. We did not think about that this morning when requesting the new test round. We are about 23 commits behind.

If tests have passed, then there is no need to rebase. It's also useful to keep the current CI runs around, they will be lost if you rebase.
We usually only rebase if CI has been updated (which happened to you earlier), or if the branch is very old (e.g. older than say a week) to avoid hidden merge conflicts (e.g. where an API changed somewhere else in the code). I don't think this is the case here, so no need to rebase.
Therefore let's wait for the remaining reviews from @jibi and then this should be ready to merge :rocket:

🍾 Thanks. @gandro and @jibi

Hi @gandro @jibi, will this fix be back ported to 1.10 and 1.11? We'd be interested since we're on 1.10 right now. Thanks

Hi @gandro @jibi, will this fix be back ported to 1.10 and 1.11? We'd be interested since we're on 1.10 right now. Thanks

Thanks for reminding me. Yes, we want to backport this.

@gandro Hi there. Your comment arrived us in the middle of our summer vacation and us being AFK... Sorry for not leaving a short ping though. We are now back and will read through your comments and suggestions. We will probably have questions. I think working on this together would probably be a good thing.

@recollir Great to hear! Unfortunately I'll be out till August 22 now as well, but I'll happily take a look once I'm back. In the meantime, I'm sure other Cilium committers can also provide feedback based on my above write up.

@gandro No worries. Well deserved to be off and enjoy the summer. We have looked at your comments in the meantime, think we understand the changes needed and will start to work on those. 🌞

Question though: should we do a new PR or work in this one?

Hi @gandro the changes requested are addressed in https://github.com/cilium/cilium/pull/20848


Modifies tests to include characters in quoted strings

Regression tests for #820
I didn't see much reason to add separate tests for this change, however I can do so if preferred.

The unquoted version is more common, that should be the primary test case. Add one or more independent tests for the quoted version.

🙃 📅


Add info to readme with comparison with infer

I don't like to compare my projects with those of others, because I wouldn't be objective, so I let the community do it if it's necessary.
The only thing I can say is that file-format detects many more file formats than infer but not only serves as a detection tool but also provides a lot of information about file formats such as their kind, name, extension and so on. On the other hand, infer mights be lighter and faster if you need to detect classic file formats.


RocketChat Client saves position even if monitor is disconnected

My Setup

My OS name and version: Windows 10 64bit
My current app version: 2.4.0

[x] I have tested with the latest application version
[x] I can simulate the issue easily

Description

Current Behavior

If I open the client on the second monitor and then disconnect the monitor, the window stays there and can´t be moved to the main monitor.
Expected Behavior

If I disconnect the second monitor the client window should position itself on the main monitor.

A coworker here has this issue.  His application is open on monitor #2 at the office, but when at home he only has the single screen and can't see the app (although the icon appears in the tray).  Would be nice if this didn't occur at all (if opens on missing monitor, at least fall back to a default location on an existing one).
As a workaround, you can move it via:

Shift+Right-Click and select Move on the taskbar icon.
Press any of the 4 arrow keys on your keyboard once.  The mouse is now locked to the window and will move with it.
Move your mouse on your screen to the new position and left-click once its where you need it.

This actually works for any windows application (I've had apps in the past do the same thing).

I'm also seeing this issue a lot.  User has the program on a 2nd monitor at work, they RDP in from home, and the program is off screen.
This is on 2.6.0

I believe we have a fix for this.
Quit rocket chat (not just close the window, but quit using the taskbar icon). Edit this file: C:\Users\USERNAME\AppData\Roaming\Rocket.Chat+\window-state-main.json . It may look like:
{
"width": 1000,
"height": 600,
"x": -1219,
"y": 320,
"isMaximized": false,
"isMinimized": false,
"isHidden": false
}
Edit the " x" coordinate to 0. Restart. Fixed.

@thehutman Brilliant tip! Thank you.

I'm having this issue as well.
Using laptop and when disconnecting from the dock, it doesn't reset, it stays on the secondary screen which isn't there anymore.
Did the same thing as @kau210 but it's annoying that you have to do it.

Problem still exists in version 2.10.5

I also have this problem in 2.10.5

This is still an issue. Pls fix.

This is a serious issue, please fix.

@fuss86 We close the issues when the develop branch has the resolution merged to keep our milestone goals clear. In no way that means a "won't fix".
By the way, there is a beta release for 2.14.2: https://github.com/RocketChat/Rocket.Chat.Electron/releases/tag/2.14.2-beta.1


Is it possible to merge a kover report for multi-module multiplatform project?

Describe what you would like to clarify about Kover
Hi. Thanks for all your hard work Kover is great 👍🏻
However I am currently working on a project that consists of multiple gradle modules, which each use the kotlin multi-platform plugin.
I would like to generate some merged coverage reports,
however when I add the kover function, it seems to not be recognised...
e.g.
sourceSets {
  val commonMain by getting {
    dependencies {
        kover(project(":other:project")) // kover function not recognised
       //...
    }
  }
 //....
}

Is what I want possible at the moment?
Many thanks :)

Hi, thanks! :)
To use coverage from another project, you need to add a kover dependency to the dependencies block, which is located in the root of the script, for example
dependencies {
  kover(project(":other:project"))
}

sourceSets {
  val commonMain by getting {
    // ...
  }
 //....
}

Also keep in mind that if there is an Android target in the project, then for each build variant, its own Kover report generation tasks are created, see docs

Aha. great! thanks for quick reply. works great :)


building on windows

There's assumptions that MSVC is in use.
Installing the requirements from pip is not so straight forward either and requires downloading some WHL files separately
numpy-1.13.1+mkl-cp36-cp36m-win_amd64.whl
numpydoc-0.7.0-py2.py3-none-any.whl
scipy-0.19.1-cp36-cp36m-win_amd64.whl

Which I got from here: www.lfd.uci.edu/~gohlke/pythonlibs
There's an issue linking libraries so it has to be done manually.
I haven't tested linux and mac still work but I don't see why they wouldn't.
Feel free to reject and do manually.
Most notable change is probably in:
tick/base/src/interruption.h

As sharing static class members across DLLs is tricky, it's changed to a static method/member pair.
Prebuilt windows libraries can be found on the windows branch of my fork under the "build" directory.

Well, that's pretty clean!! Travis will tell us what he thinks about mac and linux builds. I'd love to merge that!

Travis builds fail over cpplint checks

Very minor changes are required to fit with google style
tick/base/src/interruption.h:24:  Missing space before {  [whitespace/braces] [5]
tick/base/src/interruption.h:39:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
tick/base/src/interruption.h:46:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
tick/base/src/defs.h:51:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
tick/base/src/defs.h:56:  At least two spaces is best between code and comments  [whitespace/comments] [2]
tick/base/src/defs.h:56:  Should have a space between // and comment  [whitespace/comments] [4]
tick/base/src/debug.h:29:  At least two spaces is best between code and comments  [whitespace/comments] [2]
tick/base/src/debug.h:29:  Should have a space between // and comment  [whitespace/comments] [4]
tick/base/src/debug.h:31:  At least two spaces is best between code and comments  [whitespace/comments] [2]
tick/base/src/debug.h:31:  Should have a space between // and comment  [whitespace/comments] [4]
tick/base/src/debug.h:64:  Redundant blank line at the start of a code block should be deleted.  [whitespace/blank_line] [2]
tick/base/src/debug.h:65:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]

Thanks Martin, I'll make those changes later today.

I had an ifdef "HAVE_EXECINFO" in there but it should have been "HAVE_EXECINFO_H", but it's only relevant if you're support NetBSD (libexecinfo has to be linked manually), so I removed it

This really is an important PR. If this allows indeed to compile on windows (I cannot test it, but I trust Philip), I think that this PR should also contain an update of the README.md to explain that in order to use tick on windows, only the git cloning and compilation works for now, and that some dependencies have to installed by hand (if I understand well). The README should provide some instructions so that a motivated user can follow some steps to get it compiling and working on windows.
After this is merged, we should spend some time on getting travis testing for windows (for the three python version we test upon) and, later, manage to produce binaries as we do with macOS and linux (I know that this can be painful, so let's plan that for later :))
I'll add a JIRA task and update the naming of the PR to make it consistent with our workflow.
Once again, that really pretty cool !

@stephanegaiffas
There's one big problem with building on windows, which causes linking to fail when there's any library dependencies as I mentioned earlier this results in many failed calls to "python setup.py install" and each library must be linked manually after fixing the command line call to "link.exe"
The file type which is linked during the build is ".pyd", but it should be ".lib"
I will document the setup steps for windows with MSVC, but this is a bit of a blocker for anyone but the most ardent users.

Hey @Dekken I'm not familiar enough with compilation on windows... so I'm not sure to understand the problem. However, we are trusting you on this :)
I think that you can just explain the setup steps in the README, even if it's intended for motivated users :)

Closing and recreating from different branch name


dnsutils not packaged?

Just to be sure: The dnsutils are not packaged with nixpkgs yet? I'm on latest unstable and I cannot find them (also not via the github search).

You probably want the bind package (for dig &c)

And for dnslookup?

Do you mean nslookup (interactive internet name service lookup)?

Ah, yes.

I guess it would be nice to have a dnsutils work-alike, though, for people who just want the client apps.

IMHO, discoverability of those tools is pretty good:
$ command-not-found nslookup
The program ‘nslookup’ is currently not installed. It is provided by
several packages. You can install it by typing one of the following:
  nix-env -iA nixos.bind
  nix-env -iA nixos.busybox

$ command-not-found dig
The program ‘dig’ is currently not installed. You can install it by typing:
  nix-env -iA nixos.bind
~~~

I suppose that we could create a special packet for the client side tools by means of multiple outputs, etc. I might get around to making that change in BIND, but I won't complain if someone beats me to it.

Oh. Well, I guess we should document command-not-found better, as I didn't knew about this possibility...

command-not-found fails for me :cry:

It's a feature of NixOS. Not sure how to install that on other host systems.

I'm on nixos.

@matthiasbeyer @peti command-not-found is broken atm: https://github.com/NixOS/nixos-channel-scripts/issues/4


Get rid of remnant features

In many cases, Navidrome and/or Airsonic lack these features, so why have them?

~Video~: Mostly done.
~Chat~: Mostly done.
Podcasts: Airsonic has them, so it's not a bad idea to keep.

Closing since this is probably fine now


Folder tree structure

When using upload -r, the tree structure of the subfolders does not remain intact.

@VPeeters can you post an example of what command you run and what happens? curious to see


New-SSHSession : Sequence contains more than one element

Intermittent error thrown with unknown cause.  Verified ComputerName is a [string] and not an array of strings.  Verified $Credential is a System.Management.Automation.PSCredential and not an array of System.Management.Automation.PSCredential.  Able to reproduce error (sometimes) outside of script.
Unable to troubleshoot further.  Need to understand origin of error, or bug to be fixed.

PS Z:\Test> New-SSHSession -ComputerName $Target -Credential $Credential -Verbose
VERBOSE: Using SSH Username and Password authentication for connection.
VERBOSE: Fingerprint for testSystem: 00:11:22:33:44:55:.....:99
VERBOSE: Fingerprint matched trusted fingerprint for host testSystem
New-SSHSession : Sequence contains more than one element
At line:1 char:1

New-SSHSession -ComputerName $Target -Credential $Credential -Verbose

  + CategoryInfo          : NotSpecified: (:) [New-SSHSession], InvalidOperationException
  + FullyQualifiedErrorId : System.InvalidOperationException,SSH.NewSshSession

Do you have multiple hosts with the same SSH server key? Probably a bad master image in a VM template that does not generate a new server key or an aggressive DHCP where the IP/key pair changes
Sent from my iPhone

On Mar 11, 2016, at 7:13 PM, karezza<EMAIL_ADDRESS>wrote:
Sequence contains more than one element

The test system name and fingerprint here is obfuscated, the systems should all have unique keys.  I will check to be sure.

Embarrassingly, I think I may have just figured this out after working on it for a week.  The hostname was resolving to a different hostname with a different username / password.  Hopefully, this explains the problem in its entirety.  I'll post again if the problem reoccurs.  For now, I will say a more useful error message would have helped to troubleshoot this.  Hopefully issue posting will help the next person who encounters it.

I was getting the same error with the correct server, username and password.  I tried another SSH client and got "Access Denied".  It turns out the account was locked out.  It was a valid error condition, but the error message is not very helpful and made me think I had a problem with my script.


List of files per package should be extracted from go list

Currently ciao-vendor is using a set of wildcards to work out which source files to copy from a package to the vendor folder.  But we can be more precise as go list gives us this information.

There's probably no point in fixing this as we should move to dep soon.


Issue running tape in a node/express route

Users submit code in my web app. I want to then run tape tests against their code submission and render back the results:
var test = require('tape')

app.get('/example', function(request, response) {
  var failures = []
  test.createStream({ objectMode: true }).on('data', row => {
    failures.push(row)
    console.log('pushed row onto failures')
  })
  test('my failing test', t => {
    t.ok(3 == 4)
    t.end()
  })
  console.log(JSON.stringify(failures))
  response.render(failures)
}

The problem is failures is still an empty array when logging to the console at the end. How do I get the list of failures to send back to the browser? Also, if I reload the browser a bunch of times I'll get these errors:
12:34:49 AM web.1 |  (node:11410) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 test listeners added. Use emitter.setMaxListeners() to increase limit
12:34:49 AM web.1 |  (node:11410) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 result listeners added. Use emitter.setMaxListeners() to increase limit

I believe you need to listen for the stream's "end" event before looking at failures

As for the event emitter warnings, I think you need to remove the listeners after each request, if you're adding them on each request.


Unassigned generic let declaration is treated as assigned when used within a nested function

Bug Report
🔎 Search Terms

uninitialized variable
unassigned variable
unassigned declaration

🕗 Version & Regression Information

5.0.2

⏯ Playground Link
Playground link with relevant code
💻 Code
function fail<T>(callback: (value: T) => void) {
    let lastValue: T;
    return () => callback(lastValue)
}

🙁 Actual behavior
In the provided code snippet, the function fail takes a callback function with a generic type parameter T. The variable lastValue of type T is not initialized, which means it defaults to undefined. Consequently, when the callback function is called with lastValue as its argument, it always receives undefined even though it expects a value of type T.
🙂 Expected behavior
There should either be an error at compile-time.

I'm fairly certain this is a duplicate of #9998 as well.

The lastValue variable is the local let declaration, there is no way for any other code to mutate it.

This is irrelevant, #9998 applies even if nothing else in scope can mutate a variable.  “Variable not assigned” is detected by control flow analysis, which is defeated by closures for the reasons discussed in 9998

Variables are assumed to have been initialized within closures.

Variables are assumed to have been initialized within closures.

Is it something like an implicit rule i need to keep in mind while dealing with variables within closures?

I think a good rule to follow is to always initialize your variables.

I think a good rule to follow is to always initialize your variables.

Actually i came to this problem while writing custom RxJS operator, where it's impossible to initialize the variable by design
function finalizeWithValue<T>(callback: (value: T) => void) {
  return (source: Observable<T>): Observable<T> => {
    let lastValue: T;
    return source.pipe(
      tap((value) => (lastValue = value)),
      finalize(() => callback(lastValue)),
    );
  };
}

@dilame That's actually a good example. An observable can complete without any value, in which case your tap() was never called, but your finalize will be, which in turn calls callback() with the value undefined (which is likely not compatible with the type T). By not initializing your variable you're hiding this potential bug.

@dilame That's actually a good example. An observable can complete without any value, in which case your tap() was never called, but your finalize will be, which in turn calls callback() with the value undefined (which is likely not compatible with the type T). By not initializing your variable you're hiding this potential bug. I'd define the type as T | undefined and initialize it with undefined (or accept a fallback value of type T).

Yes, thank you for understanding :)
I discovered this potential bug by accident, and was surprised that TypeScript allowed me to do it.
Shouldn't such a case be handled by TypeScript?

Shouldn't such a case be handled by TypeScript?

🤷♂ Would be nice, but the reasons for the behaviour are outlined in #9998 and other issues.
But my actual point was that you can and should initialize your variable, even in your finalizeWithValue example.

Maybe it makes sense to add one more compiler strict option like noUninitializedVars?
Looks like a perfect solution

https://eslint.org/docs/latest/rules/init-declarations

https://eslint.org/docs/latest/rules/init-declarations

Yes, thank you for the link, I know about it, but isn't it the compiler work?

AFAIK the TS team is actively trying to get away from duplicating linter functionality in the compiler, so no.

The problem seems more like the compiler's responsibility rather than the linter's.
A linter's primary focus is on syntax and formatting, which helps maintain a clean and consistent codebase but does not offer the same protection against type-related issues as a compiler.
Conversely, TypeScript is designed to provide type safety at compile-time. Allowing uninitialized variables in this case will undoubtedly lead to TypeError in runtime, which is the exact error type that TypeScript aims to prevent, as far as I understand the TypeScript philosophy. Correct me if I'm wrong.
I understand the trade-offs caused by the limitations of Control Flow Analysis mentioned in #9998. By their nature, trade-offs imply giving up something good in favor of something else that is also good, and giving up something good is undesirable. I believe we could at least partially compensate for the limitations of Control Flow Analysis by introducing a compiler flag like "noUninitializedVars", allowing developers to enforce variable initialization at the compiler level, thereby enhancing type safety for the most demanding users.

There are legit reasons for late initialization, and generally the control flow works. You just hit a corner case with CFA and closures.
If the team would add a new flag every time it's suggested here I'd quickly run out of disk space for the tsconfig alone.

Conversely, TypeScript is designed to provide type safety at compile-time. [..] error type that TypeScript aims to prevent, as far as I understand the TypeScript philosophy. Correct me if I'm wrong.

Somewhat true, but having a sound type system is an explicit non-goal, as per the TypeScript Design Goals document. The aim is to strike a balance between productivity and correctness. This issue doesn't come up often and IMO doesn't warrant yet another compiler option that needs to be documented and support (almost) indefinitely, especially when a linter rule already exists.

The only plausible rule we could have would be that all let declarations must always have an initializer, which you could check with a lint rule.


Show top 5 most expensive OCP projects

Shows top 5 most expensive projects in the OCP cluster and node detail pages. Note that there are no tags when grouping by projects, so that page is still empty.
Fixes https://github.com/project-koku/koku-ui/issues/310
Fixes https://github.com/project-koku/koku-ui/issues/300
OCP Cluster Details:

Codecov Report

Merging #382 into master will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##           master    #382      +/-   ##
=========================================
- Coverage   88.74%   88.7%   -0.05%
=========================================
  Files         146     146
  Lines        1831    1833       +2
  Branches      262     263       +1
=========================================
+ Hits         1625    1626       +1
- Misses        180     181       +1
  Partials       26      26

Impacted Files
Coverage Δ

src/api/ocpReports.ts
80% <ø> (ø)
:arrow_up:

src/components/backgroundImage/backgroundImage.tsx
100% <ø> (ø)
:arrow_up:

src/utils/getComputedOcpReportItems.ts
67.44% <66.66%> (-0.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4732c...6c726e8. Read the comment docs.


Invalid chart type?

Just spreading around this issue, even though I am not sure it's specific to vue-charts, but in Internet Explorer in all versions but Edge, I've started to get an error "Invalid Chart Type: ColumnChart".. No matter what chart I attempt, LineChart, etc. I get the same error in a red box.
It used to work in as early as iE8, which I am required to test in at my company... (yes, kill me..) so I don't know what has changed, but I also can't find any information on how to assess this error message. If anyone here knows, would appreciate the assistance.
Thanks,
Josh

Wow.. I just tried putting the following code in the head of my page, instead of relying on the vue-charts script insertion, which I noticed before was failing sometimes on the loader.js file. So I already had code to load that file in internet explorer separately, but just removed it and replaced it with the entire block below straight from google, and that fixed it.. interesting.


Fix #1843: Add Delta Lake Connector

Describe your changes :

I worked on the ..... because ...

Type of change :

[x] New feature

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have performed a self-review of my own.
[ ] I have tagged my reviewers below.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

There is a new Python client for Delta that doesn't depend on Spark.
https://pypi.org/project/deltalake/
https://databricks.com/blog/2020/12/22/natively-query-your-delta-lake-with-scala-java-and-python.html


test: GAE, GKE, GCF run on GCE

Make tests ensure that getDefaultResource prefers GAE, GKE, GCF over
GCE. Those environments would return true for GCE as well.

Coverage remained the same at 100.0% when pulling cdaa9793cd88a7e3f088078462e1c2db12d8de37 on ofrobots:gke-vs-gce-test into d0ffeebb5ada5c116e88b607c6f3f2a6bae27b84 on GoogleCloudPlatform:master.

So the source code is doing the right thing, this is just confirming? Should we find a better way to differentiate between the environments, or is it proper to say something is both GAE and GCE?

The source code is doing the right thing, but there ought to be a test for it. I think it is correct behaviour for IS_COMPUTE_ENGINE and IS_APP_ENGINE to both return true for AppEngine.

Cool, looks good!


Removing button and image.

Remove the button and the image input types for action fields.
In the context of sending an HTTP request it seems weird to have these as available input types. They can't really be set as parameters in a request body.
See here for reference: http://www.w3.org/TR/html5/single-page.html#the-input-element

Seems fine to me.  I don't know why I'd need these button-like types as a field type in Siren.  I'll let this hang out for a minute, though, unless someone would like to offer a use case.

:+1:

No objection here.

Thanks, @mdobson!


gulp serve ?

Are there any options to run gulp serve instead of watch

I was thinking it might be a good addition to this plugin to add a way for the user to select what Gulp Task to run in the panel. Maybe we can add in a dropdown to the panel or a "Gulp Helper: Switch Task" command in the pallete. It can default to watch since that's the most common scenario but this would give the flexibility to change if needed.


Buttons and anchors with the btn class have different heights

If a button and an anchor are placed next to each other, both with the button markup, they are shown with different heights.
I placed an input and and anchor next to each other inside a form and they don't look perfectly aligned.
<input type="submit" value="Submit" class="btn btn-primary" />
Cancel

Same issue here on Chrome, I have different positioning with button, anchor or input (type submit).
I don't know if it is linked but for the input, there is a margin-bottom at - 9px from the definition of input, textarea, select, .uneditable-input .

Same thing happens with a combination of button/anchor/input:
Let me show an example:

Markup
<button type="submit" class="btn btn-primary">Save</button>
Go to List

Checking the box model on Chrome it seems everything is correct same height, margins, border and paddings.
Although when i got into the box model in Internet Explorer (which btw is also displays the same behaviour) i noticed the box model gives out slightly different results:

Any ideas?

Hey if I change this :
label, input, button, select, textarea {
/* ... */
margin-bottom: 9px;
/* ... */
}

To this
label, input, button, select, textarea {
/* ... */
margin-bottom: 9px;
/* ... */
}

Looks perfect on Chrome. When for Firefox the value needs to be 3px... Not easy to solve.

Have you tried 2.0.1? Refs #1543.

Hi,
Thanks for the tip.
Tested with 2.0.1. and its fixed for me (with Chrome and IE8)

Still working on all the buttons, but most of the alignment issues have been resolved. I'm still seeing issues across elements, so we'll work on that.


Validate/test usage of service account credentials in cloud controller manager

Backlog issue for https://github.com/kubernetes/kubernetes/issues/72897

/close
I don't think we need to track this issue here, cloud providers should be testing RBAC config based as part of testing.