cmd/go: TestNoteReading test failure (note_test.go)

Using tip (bbc4351)
ok  	cmd/fix	0.013s
--- FAIL: TestNoteReading (5.30s)
	note_test.go:43: buildID in hello binary = "75011c52e1681173c8712030a5cebd243923eaf8", want "TestNoteReading-Build-ID"
FAIL
FAIL	cmd/go	11.217s
ok  	cmd/gofmt	0.025s

git bisect says:
16ebe9f72eee1ccba4e94fb2a79afa0785cb554a is the first bad commit
commit 16ebe9f72eee1ccba4e94fb2a79afa0785cb554a
Author: Russ Cox<EMAIL_ADDRESS>Date:   Thu Jun 4 14:41:02 2015 -0400

    cmd/go: use ELF note instead of binary stamp on ELF systems

Fixed by 48f2d30d4389d57b60afe69cab74a008a2f47047 already

That was quick ;)


Showcase Submission for data/1-client-side/4-json

Thank you Geoffrey Wagner for your contribution! A member of the Coding Train team will review it shortly.

Battlefield Stats Discord Bot
Geoffrey Wagner

@Cyberdine2 did you mean for this to go with the Discord Bot videos? I can move it if you like!

Yes please, discord bots I couldn't find it in list
Sent from Proton Mail mobile
-------- Original Message --------
On Mar 18, 2024, 6:44 AM, Daniel Shiffman wrote:

@.***(https://github.com/Cyberdine2) did you mean for this to go with the Discord Bot videos? I can move it if you like!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Thanks to @dipamsen for #1513 I have now moved this showcase submission.


[Android] System.InvalidOperationException: Only one operation can be active at a time

When i call CrossFilePicker.Current.PickFile() and do not select a file (pressing the hardwarebackbutton) and call CrossFilePicker.Current.PickFile() the following exception occurs:
System.InvalidOperationException: Only one operation can be active at a time
at Plugin.FilePicker.FilePickerImplementation.TakeMediaAsync (System.String type, System.String action) [0x00020] in C:\Plugin\FilePicker\FilePicker\FilePicker\Plugin.FilePicker.Android\FilePickerImplementation.cs:42
at Plugin.FilePicker.FilePickerImplementation+d__4.MoveNext () [0x0000a] in C:\Plugin\FilePicker\FilePicker\FilePicker\Plugin.FilePicker.Android\FilePickerImplementation.cs:31
Could you check this?
Thank you!

Same problem here. App thinks the filepicker is still active after pressing the backbutton.
Maybe you could look into it?
Thank you

Same problem here.Can you tell how to fix it?

Hi
This issue is fixed? I am facing same problem.
How to fix that?
Thanks.

https://stackoverflow.com/questions/42359083/xamarin-xam-plugin-filepicker-only-one-operation-can-be-active-at-a-time
The nuget version is outdated. Used the github version work at the moment.


Change classes prefix names to interface names

@yegor256
What do you think to review your decision here? In Cactoos, all classes use the complete interface name in their names. I think welcome maintain the same naming pattern. It'll improve the usage of all ecosystem.

@paulodamaso/z please, pay attention to this issue


Program crashes when there is no face in the image

I tested the mtcnn with a image with no face, the program crashed.

It seems that code in detect_faces did not handle the case that there is no bounding box detected in the image. Is that so ?

yes
do not use

I also meet this issue. Have you solve it?

Hi miaoct,
I just refactor this repo, you can check it in https://github.com/mayuanjason/MTCNN_face_detection_alignment_pytorch
• Transfer all numpy operation to torch operation, so that it can benefit from GPU acceleration.
• Automatic run on 'CPU' or 'GPU'.
• Based on the latest version of pytorch (1.3)
• Real-time face tracking
And it will not crash when there is no face in the image.

Hi miaoct,
I just refactor this repo, you can check it in https://github.com/mayuanjason/MTCNN_face_detection_alignment_pytorch
• Transfer all numpy operation to torch operation, so that it can benefit from GPU acceleration.
• Automatic run on 'CPU' or 'GPU'.
• Based on the latest version of pytorch (1.3)
• Real-time face tracking
And it will not crash when there is no face in the image.

Thank you very much

Hi miaoct,
I just refactor this repo, you can check it in https://github.com/mayuanjason/MTCNN_face_detection_alignment_pytorch
• Transfer all numpy operation to torch operation, so that it can benefit from GPU acceleration.
• Automatic run on 'CPU' or 'GPU'.
• Based on the latest version of pytorch (1.3)
• Real-time face tracking
And it will not crash when there is no face in the image.

The code is no issue. It's very well !


Cannot run sst dev in NextJS app

I am unable to use sst dev, because I always get this error:
 ✕  The dev command for this process does not look right. Check your dev script in package.json to make sure it is simply starting your process and not running `sst dev`. More info here: https://ion.sst.dev/docs/reference/cli/#dev

The package.json relevant parts:
"scripts": {
    "build": "next build",
    "dev": "sst dev",
    "lint": "next lint",
    "start": "next start",
    "test": "vitest --passWithNoTests",
  },

This is a nextjs app, sst config was created by sst init.
SST version: 3.1.36
SST is installed via npm
I am running it with WSL but it fails similarly on macOS too.
What am I doing wrong?

The command specified in package.json for running NextJS in dev mode should look like this:
"scripts": {
    "dev": "next dev",
},

And then you will be able to run it through sst with npx sst dev command.

Thank you, this fixed it!
Interestingly, sst init did this change a few versions back...


Sound (not speech) recognition on esp32-s3-eye v2.2

Hi,
I am trying to do sound recognition (specifically, a cat meowing).  My platform is the esp32-s3-eye. Is this the best library to use?  I already have the TinyML model.
Thanks,
-T

@gamename Hello, and thank you for your interest in TensorFlow Lite for Microcontrollers (TFLM).  You have several approaches you can use for your esp32-s3 platform:

Integrate with the existing TFLM repository.  After cloning the repo, you could add the appropriate esp32-s3 support in these directories:

tensorflow/lite/micro/tools/make/targets

your esp32-s3 specific makefile parameters

tensorflow/lite/micro/

your esp32-s3 specific debug_log.cc and system_setup.cc (examples such as the ceva and chre directories

Create your own build environment using CMake and the project_generation scripts in:

tensorflow/lite/micro/tools/project_generation

use the create_tflm_tree script with an Xtensa target architecture (P6?)
use the Makefile according to the instructions inside

This approach will probably require quite a bit of work to get to compile correctly.
3. Arduino.  The esp32-s3 is supported by the Arduino IDE.  You can clone the TFLM Arduino repo and then follow the instructions here.  Be sure to substitute the correct esp32-s3 flags for the Adafruit ones. This may allow you to compile the TFLM library and examples.  Note that the Arduino TFLM repo. is from March 2023, and is not up to date with the main TFLM repo.
This issue will now be closed.  Please feel free to reopen the issue should you have additional comments.

@ddavis-2015

This issue will now be closed. Please feel free to reopen the issue should you have additional comments.
THank you!

@gamename
Suggesting the TFLM Arduino repo. was not correct.  The TFLM Arduino repo. is specific to ARM Cortex processors.
However, Espressif has their own TFLM repository which they keep synched with the official Google TFLM repo.  The Espressif TFLM code supports the esp32-s3 and can be found here.

@gamename
Suggesting the TFLM Arduino repo. was not correct. The TFLM Arduino repo. is specific to ARM Cortex processors.
However, Espressif has their own TFLM repository which they keep synched with the official Google TFLM repo. The Espressif TFLM code supports the esp32-s3 and can be found here.

Thanks!


Fix instantiateImageCodec issue with Flutter 3.16.9

This pull request solves the issue with using PaintingBinding.instantiateImageCodec on Flutter version 3.16.9.
Issue: https://github.com/saytoonz/flutter_gif/issues/12

The simplest solution is to call the instantiateImageCodec function from the dart:ui library.

LGTM. Issue breaks builds on flutter please merge and release @saytoonz.


Download refts bag via rest api

@pkdash
I am not sure this is the best way to do it, but based on my testing it works. Also, the hs_restclient does not need to change anything.
hs_restclient users can download a refts bag in the same way as other res types
refts_res_id = "719034bf610b40cc97fea7033c5d7fd3"
hs.getResource(refts_res_id, destination="/tmp", unzip=True)

@pkdash your comment has been addressed

+1 @zhiyuli merge after Jenkins check is successful.

merge after Jenkins check is successful

Looks to be a flake8 warning:
./hs_core/views/resource_rest_api.py:259:101: E501 line too long (106 > 100 characters)

passed Jenkins and pep8 check


feat: Add cache for 5.0 binary URLs

https://swift.org/blog/swift-5-released/ 🎉

What about the macOS binaries?

They didn't exist at the time, for some reason Apple consistently publish them a bit later than the ubuntu builds. Updated in 35e637b


React : Challenge no. 47

The  challenge "Use Array.map() to dynamically render elements" has a problem. The solution is correct, and it shows a error "Test case not passed", for the last case. Even, pressing the "Get solution code button" didn't worked. Everything was working, according to the challenge.
Screenshot

@IshtmeetSinghRissam It works for me -

Closing as resolved. Please reopen if this still is not working correctly.


💬 RFC: Standardise Annotations for K8s resources to populate Entities

🔖 Need
Sometimes we want to present Kubernetes resources inside Backstage, and ideally we'd populate as many of the Entity fields as possible.
Things like:

lifecycle
owner
description
system
tags

For example creating kubernetes-cluster resources for the CatalogClusterLocator it'd be good to populate the fields.
🎉 Proposal
This is proposing a standard set of Kubernetes annotations and not labels because label values can't have some characters that are useful when describing resources.
apiVersion: cluster.x-k8s.io/v1beta1
kind: Cluster
metadata:
  name: test-cluster
  namespace: default
  annotations:
    backstage.io/kubernetes-lifecycle: production
    backstage.io/kubernetes-owner: team:eu-cluster-admins
    backstage.io/kubernetes-description: This is the production cluster
    backstage.io/kubernetes-system: test-system
    backstage.io/kubernetes-tags: 'eu,production,aws' # these are split on commas and trimmed

〽 Alternatives
We don't need to standardise this at all, and we don't need to populate all the fields, so we could do nothing.
This would effectively mean that each component that was providing Kubernetes resources as Backstage entities would find their own schema.
But as exposing Kubernetes resources can be useful, it feels like there's an opportunity to define some standard annotations and how they work (the tags) to simplify things for users.
❌ Risks
This is low risk, consumers of the annotations are free to support them or not.
👀 Have you spent some time to check if this RFC has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

I like this idea. We're also working on a plugin ingesting Kubernetes resources as catalog entities (kind:Resource, spec.type:kubernetes-cluster). This would allow us to have a standard notation like the Kubernetes plugin already has with:
kind: Pod
metadata:
  annotations:
    backstage.io/kubernetes-id: <value>

This is an analogy, but instead of tapping into Backstage Kubernetes plugin, we would allow the same annotation to be reused by different catalog backend plugins. This would make the annotations easily recognizable as something that belongs to Backstage catalog mapping compared to the current situation where each plugin may introduce their own distinct set of annotations, which purpose may not be apparent to Kubernetes users who are probably unaware of custom Backstage plugin-specific annotation namespaces.

I think I'm a bit confused, I'm wondering if these Entity fields shouldn't just be sourced from the Entity that owns the kubernetes resources?

We retrieve it's deployment and hpa and they all share the same owner/lifecycle as the entity that was used to fetch them.
Then surely the entity fields for lifecycle/owner etc should come from the Entity in the catalog, not annotations on the Kubernetes resources?
Am I misunderstanding?

@mclarke47 Yes, https://github.com/bigkevmcd/backstage-plugins/tree/main/plugins/catalog-backend-module-capi#annotating-capi-resources (this is pre-standardisation).
You'll also see the configuration in the provider:
catalog:
  providers:
    capi:
      hubClusterName: production-cluster # this name is looked up in the list of clusters
      # You can configure the scheduling centrally above, or via the individual providers like this
      schedule:
        frequency: { minutes: 5 }
        timeout: { minutes: 1 }
      # All these fields are optional - annotations on the Cluster resources will override them
      defaults:
        clusterOwner: group:cluster-admins
        system: testing
        lifecycle: dev
        tags:
          - imported
          - capi
          - cluster

I know the github.com/janus-idp project is doing something similar in theirocm-backend plugin, so this is really a proposal for a generic "here are some annotations for Kubernetes resources that can be reused across several plugins" suggestion.
I'd be open to contributing something to the kubernetes-common plugin extractEntityDataFromAnnotations (naming is hard) along with the annotations to make it even simpler, perhaps with a type for the description that I used in the provider implementation, I'm happy to do this once I get my code out-the-door with the standardised annotations.

Yes, we're doing something similar for our OCM plugin, but we're not as far as @bigkevmcd is with Capi. And while we can agree together on common patterns and names unofficially, I think the idea of having this convention official and recognized in the upstream docs is much better.

It might be good to get some input from @backstage/catalog-maintainers


To add Images and modify the "EXPLORE TOP DESTINATIONS" section

Describe the bug
The "Explore top destinations" section images are not displaying and also, I want to change cards design.
Expected behavior
The images should be visible, and the cards need to be formatted.
Screenshots (Mandatory)

Additional Context (Mandatory)
This is my first open-source contribution.
***Are you contributing under any open-source program? ***
Yes, I am contributing under GSSOC 2024

@parkhibhandula this issue is already present in this repo . Sorry to close this issue .


[BUG] homl.info/colab3 URL is down

The URL from the book (https://homl.info/colab3) is down

Yikes, really sorry about that, it looks like all of homl.info is down. I'm looking into it now, it should be fixed shortly.

Problem solved, it was really stupid: the auto-renewal of homl.info failed because my credit card was stolen a few months ago so I had to cancel it, and I forgot to provide my new credit card details to the web hosting company.

Problem solved, it was really stupid: the auto-renewal of homl.info failed because my credit card was stolen a few months ago so I had to cancel it, and I forgot to provide my new credit card details to the web hosting company.

Happens. I hope your accounts are safe and that not much else has happened!


[add-resource] New Theme Gravnd Zero

I would like to add my new plugin/theme to the Grav Repository. Here are the project details: https://github.com/fistmenaruto/gravnd-zero
i believe this project would be a great starting point for anyone who wishes to build their own theme from the ground up.
Thank you for reviewing my suggestion.

Added to GPM. should show up soon


test(operators): add tests against breaking unsubscription chain

For issue #875.

merged with 3c27b4c. Thanks @staltz!
1885 specs now! Woo!


CLOUDSTACK-9016: Fail to create VM instance within VPC

CLOUDSTACK-9016: Fail to create VM instance within VPC
CLOUDSTACK-9016: Deploy vm with gateway ip address in VPC
Signed-off-by: sanjeev<EMAIL_ADDRESS>This pr squashes the commits in #1020. See test in #1020.
This closes #1020.

-1 the commits in 1020 don't need squshing. this is senseless.


Can configure a fallback for unsupported language

I often like to paste content into a new, unsaved window and beautify it. Unfortunately, this causes Atom Beautify to throw an error. I suggest an improvement that allows users to configure a fallback for any unsupported language type.
https://gist.github.com/seebigs/ff0fc0c71d6d9ea8a9e2

I often like to paste content into a new, unsaved window and beautify it.

This use case sounds similar to what was described on another issue. I recommend reading over https://github.com/Glavin001/atom-beautify/issues/506#issuecomment-130362853

I suggest an improvement that allows users to configure a fallback for any unsupported language type.

The language likely is not unsupported, and actually has simply not been detected by Atom, yet. Reading https://github.com/Glavin001/atom-beautify/issues/506#issuecomment-130362853 should help resolve that issue.

Sorry, I searched issues for similar cases but didn't find #506. Thanks for pointing that out.
I still think this would be an improvement because it saves keystrokes, and honestly, it's just poor UX to throw an error message in such a scenario. Perhaps prompting the user to choose a grammar is better (and optionally check a box to always use the selected grammar when language is unsupported). Or maybe you could open Atom's Grammar Selector automatically, then proceed with beautification after a grammar has been chosen for that file.
I'm only being so picky about this because my favorite Sublime plugin has no problem with this use case:
https://packagecontrol.io/packages/HTML-CSS-JS Prettify
This plugin just beautifies the unsaved file anyway without even prompting which grammar to use, and this has become a part of my daily workflow. Your error message blocks this and makes me want to find alternatives.

First I want to address why HTML-CSS-JS Prettify plugin for Sublime works.
So this is how HTML-CSS-JS Prettify plugin for Sublime does it:

Code is read from your Sublime edit and sent to scripts/run.js. See https://github.com/victorporof/Sublime-HTMLPrettify/blob/master/HTMLPrettify.py#L86-L87
In scripts/run.js the code and filePath is extracted from the command-line arguments passed to it. See https://github.com/victorporof/Sublime-HTMLPrettify/blob/master/scripts/run.js#L18-L19
It attempts to determine the type of the code, checking isCSS, isHTMLandisJS`. See https://github.com/victorporof/Sublime-HTMLPrettify/blob/master/scripts/run.js#L63-L71
If there is an extension, then it uses that. This is not our case: we have no extension for this unsaved file.

isCSS will not work if there is no extension, see https://github.com/victorporof/Sublime-HTMLPrettify/blob/master/scripts/run.js#L132-L135
isHTML will look for < character and return true if it exists
isJS will look for < character and return false if it exists

Two problems:

CSS is not supported. Try it.
Given the above logic, I theorize that if you were to create a new, unsaved JavaScript file with the following contents it would not actually beautify as JavaScript and maybe incorrectly interpreted as HTML.

function example() {
var broken = "<";
}

Regardless, JS Beautify's website does correctly handle this case with their check: https://github.com/beautify-web/js-beautify/blob/master/index.html#L287-L294
function looks_like_html(source) {
            // <foo> - looks like html
            // <!--\nalert('foo!');\n--> - doesn't look like html
            var trimmed = source.replace(/^[ \t\n\r]+/, '');
            var comment_mark = '<' + '!-' + '-';
            return (trimmed && (trimmed.substring(0, 1) === '<' && trimmed.substring(0, 4) !== comment_mark));
        }

Try at http://jsbeautifier.org/

Atom Beautify supports a very wide variety of languages and as such having a single catch-all fallback is simply unacceptable for an advanced user. This is why I always recommend choosing your grammar, in Atom, as that is how other Atom packages will also be detect the grammar/language of your file.
These other packages can perform very primitive checks to attempt to detect the language, however they also require maintaining and bug fixes, and it is already a very easy task, for a human, to determine.
That being said, for non-advanced users, who are only beautifying a very small subset of languages with Atom Beautify, it would be nice for them to always use a fallback beautifier. Such as a user who is a website designer and only uses HTML and CSS, they may want to simply say that HTML language is their fallback and let Atom Beautify perform that beautification. In the case where it is not HTML, then it is, again, on the onus of the user to pre-select the proper grammar. The advantage being that for the most part, Atom Beautify would attempt to beautiful before causing trouble -- such as displaying an error saying the beautification failed because the beautifier could not process the language, as it was not actually HTML.
I think something like this should satisfy you and other users.
In its current state, this Pull Request is not something I would merge. I will comment in your Pull Request commits with some recommendations of improvements to make this merge-able.
Thank you for your contributions and feedback.


Are those numbers real for yolo?

The Zero 3E has the RK3566 which has a 0.8 TOPS NPU and a single core.
How many FPS you get all depends on your video resolution and what sized YOLOv8 model you use.  I work with the RK3588 which has 6 TOPS NPU and three cores and can get 30FPS out of it with 720p video.
I would estimate using a YOLOv8s model you might get inference times around 100ms per frame, so would get maximum 10 FPS at best.  You would get more using YOLOv5.


Update Homepage for Article URLs

These are the post links on the home page that need to be updated with their new respective URLs - after #143  is closed.
https://www.famous-smoke.com/cigaradvisor/cigar-news-cao-flathead-resonator-is-lines-biggest-vitola
https://www.famous-smoke.com/cigaradvisor/cigar-advisor-guide-cle-cigars
https://www.famous-smoke.com/cigaradvisor/top-rated-famous-smoke-shop-exclusive-cigars
https://www.famous-smoke.com/cigaradvisor/my-weekend-cigar-review-johnny-tobacconaut
https://www.famous-smoke.com/cigaradvisor/cigar-news-crowned-heads-releases-mil-dias-maduro
https://www.famous-smoke.com/cigaradvisor/nowsmoking-montecristo-1935-anniversary-nicaragua-cigar-review
https://www.famous-smoke.com/cigaradvisor/nowsmoking-ep-carrillo-pledge-prequel-cigar-review
https://www.famous-smoke.com/cigaradvisor/how-to-smoke-a-cigar
https://www.famous-smoke.com/cigaradvisor/nowsmoking-drew-estate-liga-undercrown-10-cigar-review
https://www.famous-smoke.com/cigaradvisor/fan-mail-advisors-more-cigar-questions
https://www.famous-smoke.com/cigaradvisor/nowsmoking-oliva-serie-v-melanio-edicion-limitada
https://www.famous-smoke.com/cigaradvisor/nowsmoking-deadwood-sweet-jane-cigar-review
https://www.famous-smoke.com/cigaradvisor/nowsmoking-montecristo-1935-anniversary-nicaragua-cigar-review
https://www.famous-smoke.com/cigaradvisor/ca-report-top-new-cigars-january-22-2024
https://www.famous-smoke.com/cigaradvisor/perdomo-30th-anniversary-sun-grown-cigar-review-video
https://www.famous-smoke.com/cigaradvisor/small-cigars-winter-smoking
https://www.famous-smoke.com/cigaradvisor/my-weekend-cigar-review-trinidad-espiritu-no-3

This has been fixed


CLI not reading/showing shared environment variables

The railway run command fail to execute because is not reading my shared enrivonment variables and the railway variables command shows all my shared environment empty. Non-shared environment variables are working fine.

What version of the CLI are you on?
I believe this was patched on the latest version, could you give it a try now and let me know?

This has since been fixed


#2 implemented all functions

Also consider running deno lint as many files are not linting.

Also consider running deno lint as many files are not linting.

Ok, I run deno fmt to fix things, I will run deno lint too


Add jitter and throttle when comparing block metadata in the background

cc @robskillington @martin-mao @cw9

Coverage decreased (-0.2%) to 79.483% when pulling efa1ac8fdd2bd8315b6e0abbb74f3a4afb7e4ee0 on xichen-compare-throttle into 37e7c3de9ec82d0727e69823b8c799bd0862cb7b on master.

Coverage decreased (-0.2%) to 79.483% when pulling efa1ac8fdd2bd8315b6e0abbb74f3a4afb7e4ee0 on xichen-compare-throttle into 37e7c3de9ec82d0727e69823b8c799bd0862cb7b on master.

Coverage decreased (-0.2%) to 79.487% when pulling 7acc1a8b455aed684c817b8c28af024dc20eddec on xichen-compare-throttle into 37e7c3de9ec82d0727e69823b8c799bd0862cb7b on master.

Coverage decreased (-0.2%) to 79.487% when pulling 7acc1a8b455aed684c817b8c28af024dc20eddec on xichen-compare-throttle into 37e7c3de9ec82d0727e69823b8c799bd0862cb7b on master.

Coverage decreased (-0.2%) to 79.494% when pulling 9ba6d9d817cfb5275406401b96eb76342d00ed81 on xichen-compare-throttle into 37e7c3de9ec82d0727e69823b8c799bd0862cb7b on master.

Coverage decreased (-0.2%) to 79.494% when pulling 9ba6d9d817cfb5275406401b96eb76342d00ed81 on xichen-compare-throttle into 37e7c3de9ec82d0727e69823b8c799bd0862cb7b on master.


Re-align lint and prettier

We have a spot now where yarn run prettier leaves things in a place that the ESLint in yarn run test doesn't like.
eslint --fix can fix it just fine -- so this just means we need to move the relevant ESLint config rule into the config file that we use in yarn run prettier.

Fixed in 71e2fe082.


chore: remove "hidden" functionality

This isn't used anywhere. The other alternative is that we do make use of this, but then we need to decide where the command is hidden. In help menus? In syntax strings? Suggestions?

I have something like this in adventure-platform-fabric to hide the /callback command from client completion: https://github.com/KyoriPowered/adventure-platform-fabric/blob/mc/1.20/src/main/java/net/kyori/adventure/platform/fabric/impl/HiddenRequirement.java#L38, applied with this mixin
Would it be useful to preserve this feature and give it that sort of functionality?

I think it would be better to reimplement that from scratch then to keep around this unused bloat until a point when someone implements it


Gridster link in Readme

The link to Gridster is pointing to a non existent page :)

The owner of the gridster domain let it expire, changed the link to the github page. Thanks.


Displaying Multibyte Characters

Hello! I am creating a TUI application that displays Japanese using illwill.
However, I am having a problem with displaying Japanese characters with illwill, and I am wondering what to do about it.

How to display Japanese and other multibyte characters in illwill?
Whether illwill support multibyte characters in the future?

I would appreciate it if you could tell me about the above two questions.
Thank you!

What platform are you using? On Windows, multibyte character support is problematic in the standard command prompt. It should work a lot better on Linux and MacOS.
Internally, illwill uses UTF-8 codepoints for everything, so things should just work. However, I haven't tested it specifically with languages that use multibyte characters heavily.
I'm suspecting that what you're experiencing in more like a console limitation.

Thanks for your reply!
I using platform Linux(Manjaro).
I will post the case together with the case in which the problem occurred.
This is a display corruption that occurs when executing the code described below on Wezterm.
I have tried running the same code on other terminal such as XfceTerminal, LXTerminal, Kitty, etc. and they all output the same results.
Screenshot

Source Code
import illwill
import os
import json
import strformat
import strutils

# ------------------------------------
# Process to prepare content
# ------------------------------------

# Draw the preview screen on the left side of the screen
proc previewArea(tb: var TerminalBuffer, content: string) =
  let width = toInt(tb.width / 3)

  tb.setForegroundColor(fgYellow)
  tb.drawRect(tb.width - width - 1, 0, tb.width-1, tb.height-1)
  tb.write(tb.width - width, 1, content)

# Draw the selection menu on the right side of the screen
proc selectArea(tb: var TerminalBuffer, y: int, pos: int, datas: seq[Results]) =
  for i, data in datas:
    if i == pos:
      tb.setForegroundColor(fgBlack, true)
      tb.setBackgroundColor(bgGreen)
      tb.write(2, y+i+1, data.title)
    else:
      tb.write(2, y+i+1, data.title)
    tb.resetAttributes()

proc exitProc() {.noconv.} =
  illwillDeinit()
  showCursor()
  quit(0)

illwillInit(fullscreen = true)
setControlCHook(exitProc)
hideCursor()

# cursor position
var pos: int

while true:
  var tb = newTerminalBuffer(terminalWidth(), terminalHeight())
  var key = getKey()

  tb.selectArea(0, pos, results)
  tb.previewArea(results[pos].content)

  case key
  of Key.J:
    pos = pos + 1
    if results.len <= pos:
      pos = 0
  of Key.K:
    pos = pos - 1
    if pos < 0:
      pos = results.len - 1
      continue
  of Key.Escape, Key.Q: exitProc()
  of Key.Enter:
    exitProc()
    echo pos
  else: discard

  tb.display()
  sleep(20)

So judging by your screenshot, I think what's happening is that the Japanese characters physically seem to take up the width of two Latin characters, but they're encoded as multiple UTF-8 code points, most likely not two codepoints, but perhaps more?
Like I said, I don't speak Japanese and know very little about the Japanese language, the symbols, and how the symbols are encoded on computers. I just found this page and there seems to be a lot of complexity regarding Japanese encodings:
https://www.sljfaq.org/afaq/encodings.html
I'm somewhat interested in getting to the bottom of this as it might affect not just Japanese but other non-Latin languages as well. But you'll need to provide a program that I can compile and execute — the above program you posted does not compile; I'm guessing it's a part of a larger program, and it doesn't output any Japanese characters, so it doesn't allow me to reproduce the issue visually on my computer.
Please don't assume anything, and provide all the following:

What character encoding are you using in your terminal (is it UTF-8? is it something else that you need to use to display Japanese characters correctly?)
A self-contained Nim program that I can compile and run that outputs some lines of text in Japanese that demonstrates the alignment problem.
If you put the same few lines of text into a textfile, and you display it in the console with echo in the same terminal, or you open the textfile in Vim (in the same terminal), do the alignment issues still happen? A textfile like that would be very useful for testing.

The encoding used in the terminal is UTF-8.
In addition, Japanese fonts must be installed to correctly display Japanese characters on the terminal.
The font used on my terminal is UDEV-Gothic, but if you are using a Linux distribution or similar, noto-fonts-cjk is the easiest to install. There is probably no difference in display between the different fonts.
This is a program that reads a file named test.txt in the current directory and displays it on the right side of the screen and a rectangle that imitates a preview window on the left side of the screen.
Please place the attached text file in the same directory and run it.

Also, the screenshot here is a shot of these files opened in Vim. I have not encountered any problems displaying Japanese.

Programs
import illwill
import os
import strutils

proc loadTxtFile(path: string): seq[string] =
  block:
    var f : File = open("test.txt" , FileMode.fmRead)
    defer :
      close(f)
      echo "closed"
    return f.readAll().split("\n")
    #echo f.readLine()

proc drawText(tb: var TerminalBuffer, texts: seq[string]) =
  for idx, text in texts:
    tb.write(0, terminalHeight()-idx, text)

proc exitProc() {.noconv.} =
  illwillDeinit()
  showCursor()
  quit(0)

illwillInit(fullscreen = true)
setControlCHook(exitProc)
hideCursor()

var pos: int

var texts = loadTxtFile("test.txt")
while true:
  var tb = newTerminalBuffer(terminalWidth(), terminalHeight())
  var key = getKey()

  tb.drawText(texts)
  tb.drawRect(terminalWidth() div 2, 0, terminalWidth(), terminalHeight())

  case key
  of Key.Escape, Key.Q: exitProc()
  of Key.Enter:
    exitProc()
    echo pos
  else: discard

  tb.display()
  sleep(20)

Text file used for loading. (Save the file as test.txt.)
いろはにほへと ちりぬるを
わかよたれそ  つねならむ
うゐのおくやま けふこえて
あさきゆめみし ゑひもせすん

色は匂へど 散りぬるを
我が世誰そ 常ならむ
有為の奥山 今日越えて
浅き夢見じ 酔ひもせず

Cheers, I'm busy with other stuff now, I'll have a look at this at some point.

Try to modify displayFull() in illwill.nim .
proc displayFull(tb: TerminalBuffer) =
  let widthTable = [
    (126,  1), (159,  0), (687,   1), (710,  0), (711,  1),
    (727,  0), (733,  1), (879,   0), (1154, 1), (1161, 0),
    (4347,  1), (4447,  2), (7467,  1), (7521, 0), (8369, 1),
    (8426,  0), (9000,  1), (9002,  2), (11021, 1), (12350, 2),
    (12351, 1), (12438, 2), (12442,  0), (19893, 2), (19967, 1),
    (55203, 2), (63743, 1), (64106,  2), (65039, 1), (65059, 0),
    (65131, 2), (65279, 1), (65376,  2), (65500, 1), (65510, 2),
    (120831, 1), (262141, 2), (1114109, 1)
  ]

  proc getWidth(c: int): int =
    if c == 0xe or c == 0xf:
      return 0
    for (num, wid) in widthTable:
      if c <= num:
        return wid
    return 1

  var buf = ""
  var skipNo = 0

  proc flushBuf() =
    if buf.len > 0:
      put buf
      buf = ""

  for y in 0..<tb.height:
    setPos(0, y)
    for x in 0..<tb.width:
      let c = tb[x,y]
      if c.bg != gCurrBg or c.fg != gCurrFg or c.style != gCurrStyle:
        flushBuf()
        setAttribs(c)
      var cc = $c.ch
      skipNo += (getWidth(cc.runeAt(0).int) - 1)
      if cc == " " and skipNo>0:
        cc = ""
        skipNo -= 1
      buf &= cc

    flushBuf()
    skipNo = 0

I tried that way, I was looked at expected behavior.
Thank you!

@forthlee
I am thinking of using this code to create a Japanese (and also Chinese, Korean, etc.) fork of illwill.
Would it be ok to include the code you provided in the fork?
Thank you.

The code is referenced from Urwid
urwid is licensed under the GNU Lesser General Public License v2.1

@forthlee I am thinking of using this code to create a Japanese (and also Chinese, Korean, etc.) fork of illwill. Would it be ok to include the code you provided in the fork? Thank you.

Feel free to raise a PR if you think Japanese/Asian languages can be supported unobtrusively.

@forthlee
thanks!
I have spring break so, I want to work on this issue.

@johnnovak
I will consider sending PR when I have reached some degree.
Please take care of me then.😉

@johnnovak
I will consider sending PR when I have reached some degree. Please take care of me then.😉

Sure thing. Good luck! 😎


Importing image just doesn’t work?

I try to import the attached image (I've tried both png and jpg versions of it, in both Chrome and Firefox, both via Ctrl+V and File → Import).
I get screen looking like this:

Trying to scale up the image in Properties reveals that the imported image is completely white.
attached.png
attached.jpg

Looks like this is a regression, I can reproduce it. The size shouldn't be 1x1 and the image shouldn't just be white. @0HyperCube are you able to take a look at this please?

I can reproduce this and so did @AnimateShadows. This is because someone changed the rust to use the snake case image_data and the vue to try and read the camel case imageData inside FrontendImageData.

Putting a serde rename on the image data fixes the issue
#[serde(rename = "imageData")]
pub image_data: Vec<u8>,

Oh, that would be a change I made when I refactored the consistent usage of snake/camel case between the Rust and JS. Hopefully I didn't make any other mistakes during that process. Thank you for finding that!


GDScript: Lambda hotswap fixes

im glad https://github.com/godotengine/godot/pull/85248 got merged and fixed my mistakes
however,
it has some problems that this PR fixes:

thread_enter and thread_exit are inadequate for initializing the threadlocal lists, as external thread created by, FMOD for example, arent tracked at all, leading to a segfault when it tries to access the threadlocal list
https://github.com/godotengine/godot/pull/85248 is, no offense, over complicated, manual refcounting is unnecessary and error prone, just keeping track of the lists should be used instead of moving orphaned list elements to the main thread list

and,, another thing fixed by this:

my original code was fundamentally broken
it nulls lambdas unrelated to the currently reloading script, making hot-reloading lambdas still broken, just safer, no crashing

keeping track of the orphaned threadlocal lists, and having a list of weak references to only the relevant updateable func ptrs in each script with a mutex for each is enough to make this fast and safe in lambda creation, and script reloading and clearing.
and easier to read and modify the code
it should function as i meant it to originally in https://github.com/godotengine/godot/pull/81628 and now waste no time checking unrelated elements when reloading
the following recent related bugs are still gone after this PR:

https://github.com/godotengine/godot/issues/84046
https://github.com/godotengine/godot/issues/84190
https://github.com/godotengine/godot/issues/85112

but i could not reproduce https://github.com/godotengine/godot/issues/85151, if someone who can reproduce it can test that its still fixed after this PR i would be so grateful

trying to find out why only the linux builds are failing..

#0  0x000000000a2119dd in GDScript::UpdatableFuncPtrOwnerListContainer::UpdatableFuncPtrOwnerListContainer (
    this=0x7fffff400d80) at modules/gdscript/gdscript.cpp:1397
1397    GDScript::UpdatableFuncPtrOwnerListContainer::UpdatableFuncPtrOwnerListContainer() {

oops it seems threadlocal var initializers arent re-entrant safe...
i rewrote it to be way simpler anyway,

#85248 is, no offense, over complicated
You should have seen its first iteration. 😆

Now seriously, I did my best to understand the intent of the original code so I could provide a fix. I had to make a few assumptions. I'm happy there's a proper patch now.

@RandomShaper good job, it was pretty bad code,,,
i should have gone with simplest option to begin with :)

Thanks!

this should probably be cherry-picked for 4.2 ,, ill make  a commit


Projectile Curving

Description
I think it would be cool to have a setting for projectiles to be able to hook left or right during their flight, with an additional setting for a delay before the hook. This could be very useful for throwable weapons such as throwing stars or boomerangs. The value for "curve" could be between 1.0 and -1.0 where 1.0 is a strong hook to the left and -1.0 is a strong hook to the right, and the value for the delay would be a simple matter of ticks before starting the curve.
Configuration
Curve:
  Curve_Strength: <amount>
  Curve_Delay: <amount>
  etc.

hahaha, I love the idea of a boomerang projectile. Similar to #28


Fails to install on windows 10.

Both npm and nodejs are running without issue.
I have installed the windows-build-tools globally prior to this.

Python is 2.7.

Looks like the issue is related to installing pty.js I recommend moving to node-pty instead. pty.js has not been updated for a year, whereas node-pty is being actively maintained.

Did you get beyond this?, I have tried the method above, but no luck on Windows 10

I haven't built the project on my main machine in ages, so very possible something changed.


Support JWT auth for HTTP endpoints

Currently, all extension endpoints except for 'auth' will go through
authentication, since it seems like the safe default.
Fixes #6345.
This is a backwards incompatible change! Unless "Trust" is configured
as a method for HTTP transports (which it will be in dev instances),
HTTP endpoints will stop working when not authenticated to.
Authentication is done by adding a header of the form:
Authorization: bearer <JWT>

We'll need to update the docs. For cloud instances, you just use the
JWT token.
I'm not sure how painful it will be to adjust other hosted prod
deployments of edgedb to be able to use JWT tokens, though?
Thoughts?
If it seems like it might be nontrivial, we can add a new transport
type so that the simple HTTP endpoints and tunnelled edgedb+http can
be separated, which would make it easy to opt-in to exactly the old
behavior.

(I have a patch to add a new transport type to split the edgedb+http from the other HTTP endpoints ready, if we want to do that)

I don't think I can review this, but my safe guess is that it blocks the rc1.

I just pushed basic password auth over simple http endpoints. Might be worth reviewing now, though there is a still pending commit to add tests. (I've tested it manually, though)

Alright, I added proper user support, so I think this is basically there.
I might also tweak it to respond 401 Unauthorized and send a [WWW-Authenticate](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/WWW-Authenticate) header if no authorization header is sent. urllib at least required a very particular incantation to get it to send a password if you don't do that.
(Of course, just injecting the basic auth header manually is actually way easier than navigating that...)


clean up active eth memory map and linker scripts

Make it work like the other memory maps, remove unused portions
Currently kernels that statically initialize globals are broken
Steps:

Remove dead portions of the l1_address_map
Define a magic base address where the metal memory map can begin
Move the metal required portions of the memory map into dev_mem_map following the naming conventions there
Unify linker scripts w/ tensix/idle eth linker scripts
Use linker script to place globals into local memory, add copy at FW and kernel init
Enable FD test TestEthInitLocalMemory

@ubcheema can you update this issue w/ the address ranges that are safe for metal to use?

On an Active ethernet core we run base firmware that performs two functions:

ethernet link training and management
Implement a custom Layer 3 routing network that enables host access to remote chips, which are only accessible over ethernet

Due to these two functions, some regions of 256 KB ethernet core L1 are already in use when the system boot up.
Runtime firmware and kernel have to be loaded to regions that will not collide with or corrupt base firmware L1 regions.
Base FW:
0x0 - 0x903F: Firmware text and data sections.
0x11000 - 0x17FFF: Layer 3 Routing network queues
Runtime FW/Kernel:
0x9040 - 0x10FFF (32 KB) : runtime loaded fw/kernel text/data
Unreserved:
0x18000 - 3FFFF (160 KB): Unreserved
Base FW regions should be treated as dead portions of l1_address_map.

For start, we could put the RingBuffer in the 32K hole, then the erisc FW and mailboxes at the start of unreserved.  32K may not be enough to double buffer large kernels, but we can re-evaluate that later (and swap the above if needed)

We should use --orphan-handling=warn (or even =error) so there can be no surprise output sections.

how is the erisc application and kernel loaded -- where is that code?  I'm trying to figure out what is responsible for placing the initialized data image in the right place -- erisc code itself doesn't seem to copy it, except in the case of idle_erisck.cc which does. there's a comment in erisc.cc // Not using firmware_kernel_common_init since it is copying to register which is confusing -- copying what to which registers?

It appears that the erisc scripts do not zero-out .sbss, and some symbols end up there. Those symbols are initialized before bss is cleared, thus things break horribly if one actually zeroes out .sbss (or moves it into bss). Tracking down which of those symbols this applies to.


fixed Davelab6's setup.py improvements

@googlebot you're mistaken. These are not the droids you're looking for.

@googlebot I'm okay with these commits


Inconsistent Login Behavior and Wallet Connection Issues

Inconsistent Login Behavior and Wallet Connection Issues
Description: After successfully logging in with Coinbase Wallet (CBW), I logged out and attempted to connect to the Converse app using other wallets. However, I encountered the following issues:
Successful Login with CBW: Initially, I logged in successfully with CBW. After logging out and trying to connect with other wallets, and then attempting to reconnect with CBW, the Converse app displayed the message: “Already Connected - this account is already connected to Converse.”
Login Status: Despite being logged out on all devices, the app indicated that the account was still connected, preventing me from signing in with other wallets.
Access via Seed Phrase/Key: The only way to successfully log in and access my messages was by using the seed phrase/key. After doing so, 1-to-1 DMs displayed with 0x/Inbox ID, and both 1-to-1 DMs and Group Chats loaded quickly.
Steps to Reproduce:
Log in to the Converse app using Coinbase Wallet (CBW).
Log out of the app.
Attempt to log in using different wallets (e.g., Rainbow, Exodus).
Attempt to log in again with CBW.
Observe the “Already Connected” message despite being logged out on all devices.
Log in using seed phrase/key and observe the behavior of 1-to-1 DMs and Group Chats.
Expected Behavior:
The app should allow reconnection with CBW or other wallets after logging out without showing the “Already Connected” message incorrectly.
Users should be able to log in with any supported wallet without encountering connection issues or app crashes.
Actual Behavior:
The app incorrectly displays the “Already Connected” message after logging out, preventing reconnection with CBW and other wallets.
Access to the app and messages is only possible through the seed phrase/key.
Connect Account
• Connect via Rainbow - unsuccessful
◦ Crashed when attempting to connect with Rainbow Wallet
• Connect via Exodus - unsuccessful
◦ Crashed when attempting to connect with Exodus Wallet
This is strange: Successfully logged in with CBW - after logging out and attempting all other wallets (and then again with CBW) after the initial approval to connect the wallet to Converse, on the Converse app it shows the message “Already Connected - this account is already connected to Converse”. I have this account logged out on all devices so am unsure why I am unable to sign in with these wallets. The only way at this point to actually get into Converse and see my message was to use the seed phrase/key. After logging in with seed phrase/key 1to1 DM’s show with 0x/Inbox ID. Both 1to1 DMs and Group Chats loaded quickly.
Slack Message

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."


Upgrade & refactor asciidoctor-maven-plugin config

Bump asciidoctor-maven-plugin to v2.2.2
Bump AsciidoctorJ to v2.5.6
Bump AsciidoctorJ PDF to v2.1.6
Refactor configuration

To remove duplication

Added Maven properties for shared versions and paths.
Use common  in plugins for all executions.

Removed unused elements

imagesdir attribute in html already uses default value.
imagesdir in pdf no longer requires to point to target (issue fixed in upstream).

Created single executions to convert only required files: index, toc, release-notes.
This has the advantatge that displays errors/warning for each file as independent
steps during maven build.

Other changes

Set source-highlighter in PDF to rouge which is current recommended.
Set outputFile to 'reference.pdf' for convenience.

Build  shows several errors for toc.adoc that now are easier to spot and fix. I can tackle those in another PR if this is fine.
mvn clean generate-resources -P generate-html -pl asciidoc -am

----
[INFO] --- asciidoctor-maven-plugin:2.2.2:process-asciidoc (generate-toc-html) @ asciidoc ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Using 'UTF-8' encoding to copy filtered properties files.
[INFO] Copying 3 resources
[INFO] asciidoctor: WARN: distributed/jdbc/jdbc-integraions.adoc: line 19: section title out of sequence: expected level 3, got level 4
[INFO] asciidoctor: WARN: distributed/jdbc/jdbc-integraions.adoc: line 48: section title out of sequence: expected level 3, got level 4
[INFO] asciidoctor: WARN: distributed/jdbc/jdbc-integraions.adoc: line 48: id assigned to section already in use: listener
[INFO] asciidoctor: WARN: advanced/listener.adoc: line 2: id assigned to section already in use: listener
[INFO] asciidoctor: INFO: possible invalid reference: tokens-inheritance-strategy-proportionally
[INFO] asciidoctor: INFO: possible invalid reference: tokens-inheritance-strategy-as-is
[INFO] asciidoctor: INFO: possible invalid reference: tokens-inheritance-strategy-additive
[INFO] asciidoctor: INFO: possible invalid reference: tokens-inheritance-strategy-proportionally
[INFO] asciidoctor: INFO: possible invalid reference: tokens-inheritance-strategy-as-is
[INFO] asciidoctor: INFO: possible invalid reference: tokens-inheritance-strategy-additive
[INFO] asciidoctor: INFO: possible invalid reference: tokens-inheritance-strategy-as-is
[INFO] Converted /home/asalgadr/github/bucket4j/asciidoc/src/main/docs/asciidoc/toc.adoc
----

Hello @abelsromero
Thank you, all looks good, excepting that for profile generate-html-plain does not work now, because index.html and release-notes.html are empty now. This profile is used each time when I do release to generate files:

https://github.com/bucket4j/bucket4j.github.io/blob/master/8.0.1/release-notes.html that looks as https://bucket4j.com/8.0.1/release-notes.html
https://github.com/bucket4j/bucket4j.github.io/blob/master/index.html that looks as https://bucket4j.com/
In other words this profile is used to generate documentation files without table of contents.

I have merged this request the to the branch try_new_asciidoctor please use it for next requests related to asciidoctor migration. If you know how to fix generate-html-plain it will be nice to provide correspondent pull-request.

I have merged this request the to the branch try_new_asciidoctor please use it for next requests related to asciidoctor migration

Excellent idea :+1:

Thank you, all looks good, excepting that for profile generate-html-plain does not work now, because index.html and release-notes.html are empty now. This profile is used each time when I do release to generate files:

Found it, doctype must be Inline in uppercase. In fact I think we can remove the use of doctype, it does not apply if we are building a single page HTML document(s).

This profile is used each time when I do release to generate files:

If I understand correctly, for a release the process would be:

Generate toc.html with generate-html
Generate index.html & release-notes.html with generate-html-plain
Manually copy and place those files under proper path: index in the root path and the other two under the version directory.

If that's the case, we can just setup a single profile "generate-html-docs" that does exactly that. Leaving index in the directory above the version one.
Also keep the PDF which I guess is a nice-to-have but is not being used to publish any content.

Yes, you correctly understand release process, I do have objections to merge html generation in one profile.

Thank you very much. Has been merged to master.


IntentIntegrator not available

IntentIntegrator class not available with latest lib version 3.6.0. Review your lib and readme.md file
Had to pull snapshot version com.github.journeyapps:zxing-android-embedded:65aaa93a27 for it to work

IntentIntegrator is still available as com.google.zxing.integration.android.IntentIntegrator, and is used in many of the examples in the project.


The undo option(Crtl+Z command) does not undo word by word but rather clears the entire entry in one go

Step-by-step undo would enhance the workflow. Consider both while typing and deleting.

Redo and undo with four steps #190


Ensure clean "make check" output

Before fixing issues or adding feature requests, let's set up make check to run cleanly.  I've made a few changes:

Change the pylint run to just use pylint -E.  Even with a custom pylintrc there's too many false positives.  I'm also not a fan of cluttering code with pylint exclusion comments.
Add a make pylint that we can occasionally run and manually sift through any issues.
Add make check as part of the travis builds.
Small code cleanup to get make check to run cleanly.

The upcoming pull requests will use this as a base branch.

James, I'll try to review the pull requests early tomorrow morning.

Looks good :shipit:


kgo: make api reference versioned

Description
This will allow us to version the api reference.
Testing instructions
Preview link:
Checklist

[x] Review label added
[x] PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

Last versino https://github.com/Kong/docs.konghq.com/pull/6531/commits/9cb85150f3e9941665f3249945b5f8caf1c00a65 from @mheap works 🥳


GoogleStackdriverTarget for NLog - Added SendJsonPayload property

@chrisdunelm Thought that NLog should also support your LogEntry.JsonPayload

Any ETA on this? Exactly what I was waiting for.

@manxjason Do you have any preference on having the Labels filled when using JsonPayload ?

@snakefoot No preference at this point - perhaps in the future but use of Stackdriver is new to us

@snakefoot From your point of view is this now ready for merging and release?

@chrisdunelm Yes it looks good to me.

Great. I'll wait for all CI to go green, then merge. I expect we'll do another beta release of this next week. Thanks very much :)

Nuget package is now available:
https://www.nuget.org/packages/Google.Cloud.Logging.NLog/2.0.0-beta02

@snakefoot this is more an Issue but as this PR is fresh and you made it, perhaps you don't mind discussing the following?

Do you have any preference on having the Labels filled when using JsonPayload ?

Hmm i'm starting to think I should have said 'Yes'. Right now we're finding that the labels are being filled, but not with the actual values, but with the type instead for some reason.
So as per the documentation
Order order = new Order
{
    OrderId = 25544,
    Status = OrderStatus.Processing
};

logger.Info("Test {@value1}", order); // object Result:  Test {"OrderId":2, "Status":"Processing"}

Results in looking like this: https://imgur.com/Olav4qc. Note the message format and the Property's value is the name of the type.
Our setup looks like:
GoogleStackdriverTarget googleTarget = new GoogleStackdriverTarget
{
    ProjectId = "234234",
    Name = "desktop app",
    CredentialFile = Path.Combine(@"C:\asdasd.json"),
    Layout = layout,
    IncludeEventProperties = true,
    ContextProperties = ....
{

And our layout:
JsonLayout layout = new JsonLayout
            {
                Attributes =
                {
                    new JsonAttribute("message", "${message}"),
                    new JsonAttribute("type", "${exception:format=Type}"),
                    new JsonAttribute("exception", "${exception:format=Message}"),
                    new JsonAttribute(
                        "innerException",
                        new JsonLayout
                        {
                            Attributes =
                            {
                                new JsonAttribute(
                                    "type",
                                    "${exception:format=:innerFormat=Type:MaxInnerExceptionLevel=1:InnerExceptionSeparator=}"),
                                new JsonAttribute(
                                    "message",
                                    "${exception:format=:innerFormat=Message:MaxInnerExceptionLevel=1:InnerExceptionSeparator=}")
                            },
                            RenderEmptyObject = false,
                            IncludeAllProperties = true,MaxRecursionLimit = 100
                        })
                },
                RenderEmptyObject = false,
                IncludeAllProperties = true, MaxRecursionLimit = 100
            };

@manxjason Not sure I understand why you are using the JsonLayout. I would instead put the values you have added with each of the JsonAttributes into the GoogleStackdriverTarget.ContextProperties
I first implemented the NLog-GoogleStackdriverTarget to have the same features as for log4net. And then I added the support for JsonPayload so it would have the same features as for Serilog.
I don't have much experience with the Google Logging Framework to know what works best for you.
Are you missing an RenderEmptyObject option on GoogleStackdriverTarget.ContextProperties ?

@manxjason Discovered your use of POCO-objects, so created #2300 to support this.


Upgrade gradle to 4.0.1

Gradle 4 release notes:
https://docs.gradle.org/current/release-notes.html

ModuleDependency.getConfiguration() has been deprecated and is scheduled to be removed in Gradle 4.0. Use ModuleDependency.getTargetConfiguration() instead.

Fixed this error in https://github.com/treasure-data/digdag/tree/fix-gradle-401

LGTM with https://github.com/treasure-data/digdag/pull/605 👍
I'll merge this PR after CI test


Access rubygems.org via https by default when using :rubygems in Gemfile

I'm partial to using source :rubygems syntax in my Gemfile to denote a source but noticed that it was using http instead of https, this brings the https changes in sync with those made in #1562 and #1522

Nice catch.

I'm sorry, but we can't make this change until Bundler 2.0 at the earliest. SemVer means we can't change 1.0 behaviors, we can only add new features on top until 2.0.
Thanks for the patch, though!
On Dec 12, 2011, at 6:59 AM, Steve<EMAIL_ADDRESS>wrote:

I'm partial to using source :rubygems syntax in my Gemfile to denote a source but noticed that it was using http instead of https, this brings the https changes in sync with those made in #1562 and #1522
You can merge this Pull Request by running:
git pull https://github.com/spagalloco/bundler https
Or you can view, comment on it, or merge it online at:
https://github.com/carlhuda/bundler/pull/1585
-- Commit Summary --

Access rubygems.org via https by default when using :rubygems in Gemfile.

-- File Changes --
M lib/bundler/dsl.rb (2)
-- Patch Links --
https://github.com/carlhuda/bundler/pull/1585.patch
https://github.com/carlhuda/bundler/pull/1585.diff

Reply to this email directly or view it on GitHub:
https://github.com/carlhuda/bundler/pull/1585

Hmmm, I thought about SemVer when pulling this but I didn't think it was relevant because it was backward compatible. Does this really count as a breaking change?

It will change all existing Gemfiles that contain :rubygems to suddenly start using HTTPS. For users on machines with bad (or old) SSL CA cert bundles, that could stop Bundler from working entirely. It's definitely at least potentially breaking.
On Dec 12, 2011, at 7:36 AM, Erik<EMAIL_ADDRESS>wrote:

Hmmm, I thought about SemVer when pulling this but I didn't think it was relevant because it was backward compatible. Does this really count as a breaking change?

Reply to this email directly or view it on GitHub:
https://github.com/carlhuda/bundler/pull/1585#issuecomment-3109372

PS: I'm happy to revert the commit if necessary. I'd just like to fully understand why it's necessary first.

Okay, I'll revert it.

Is there a 2.0 branch or milestone where we can put stuff like this so we don't forget about it?

Cool. Possibly we should start collecting these changes in a label (or even a branch) for 2.0? /cc @hone
On Dec 12, 2011, at 7:40 AM, Erik<EMAIL_ADDRESS>wrote:

Okay, I'll revert it.

Reply to this email directly or view it on GitHub:
https://github.com/carlhuda/bundler/pull/1585#issuecomment-3109427

Let's go with milestone for now and we can figure out if a branch is better later. Thanks!
On Dec 12, 2011, at 7:41 AM, Erik<EMAIL_ADDRESS>wrote:

Is there a 2.0 branch or milestone where we can put stuff like this so we don't forget about it?

Reply to this email directly or view it on GitHub:
https://github.com/carlhuda/bundler/pull/1585#issuecomment-3109442

Reverted in 7c7282f34d17db5f1c76606e479b0d1ec935d184.

Thanks for the discussion here, I can see why this creates a SemVer issue. I guess I have some Gemfiles to update :metal:

I would be against making a 2.0 at all for stuff like this. Ideally, we would be able to avoid making a breaking semver version of bundler unless we had a darn good reason for it, and I don't think this counts.

I think that's a natural stance to take. The problem is that this change would break bundler on many, many production machines that have old CA cert bundles installed. The only way to keep bundler working on those machines is to not change the default symbol to use SSL. Since that makes this a breaking change of current functionality, 2.0 seems like the minimum version possible.
On Dec 13, 2011, at 8:44 AM, Yehuda<EMAIL_ADDRESS>wrote:

I would be against making a 2.0 at all for stuff like this. Ideally, we would be able to avoid making a breaking semver version of bundler unless we had a darn good reason for it, and I don't think this counts.

Reply to this email directly or view it on GitHub:
https://github.com/carlhuda/bundler/pull/1585#issuecomment-3127428

Would the possibility exist of shipping a vendored cert?  Airbrake recently took that approach.  That obviously comes with some other implications. May be more trouble than it's worth.  Just a thought.

@spagalloco I think that would somewhat defeat the purpose of using SSL in the first place.

If you're using Bundler to get your gems, you already have to trust it to get them from rubygems.org. Including the cert would just mean Bundler could be sure that it was talking to the real rubygems.org and not a mitm attack.
That said, I prefer people to manage their own security stuff, because there rarely seems to be a one-size-fits-all approach that succeeds. If we can avoid shipping the cert, I would rather do that.
On Dec 13, 2011, at 11:14 AM, Henrik<EMAIL_ADDRESS>wrote:

@spagalloco I think that would somewhat defeat the purpose of using SSL in the first place.

Reply to this email directly or view it on GitHub:
https://github.com/carlhuda/bundler/pull/1585#issuecomment-3129753

@indirect agreed.  Airbrake obviously had an entirely different use case.  I'm probably beating a dead horse at this point, so I'll drop it. Thanks. :)


Optimization: make the most of Hint::AcceptsSingular when call make_scalar_function to Improve performance

Which issue does this PR close?

Closes https://github.com/apache/arrow-datafusion/issues/10053
Rationale for this change
Benchmark
overlay function
Gnuplot not found, using plotters backend
4args_with_3scalars/overlay/1024
                        time:   [36.540 µs 36.560 µs 36.587 µs]
                        change: [-12.476% -12.385% -12.284%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  2 (2.00%) high mild
  5 (5.00%) high severe

4args_with_3scalars/overlay/4096
                        time:   [141.54 µs 141.65 µs 141.82 µs]
                        change: [-12.584% -12.425% -12.231%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
  3 (3.00%) high mild
  8 (8.00%) high severe

4args_with_3scalars/overlay/8192
                        time:   [282.77 µs 283.42 µs 284.20 µs]
                        change: [-13.658% -13.353% -12.997%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
  3 (3.00%) high mild
  3 (3.00%) high severe

4args_without_scalar/overlay/1024
                        time:   [37.682 µs 37.717 µs 37.757 µs]
                        change: [+1.8225% +1.9984% +2.1754%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 13 outliers among 100 measurements (13.00%)
  4 (4.00%) high mild
  9 (9.00%) high severe

4args_without_scalar/overlay/4096
                        time:   [147.68 µs 147.77 µs 147.91 µs]
                        change: [+2.7595% +3.0052% +3.2531%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 20 outliers among 100 measurements (20.00%)
  4 (4.00%) high mild
  16 (16.00%) high severe

4args_without_scalar/overlay/8192
                        time:   [298.84 µs 299.63 µs 300.27 µs]
                        change: [+1.6336% +2.0972% +2.5438%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

Discussion🤔
According to the benchmark, there can be about a 12% performance improvement 🚀 when there are 3 scalar args; however, when all args are arrays, there is a 2% ~ 3% performance loss 😔. Does anyone have any ideas on how to avoid this loss?
What changes are included in this PR?
Currently, this approach has only been validated based on the overlay function. If everyone thinks it's appropriate, it can be applied to other functions as well.
Are these changes tested?

Are there any user-facing changes?

Marking as a draft to make it clear this PR isn't waiting on feedback anymore (I am trying to reduce the outstanding PR review queue)

Marking as a draft to make it clear this PR isn't waiting on feedback anymore (I am trying to reduce the outstanding PR review queue)

Is this PR not satisfactory enough for performance? Do I need to make further improvements to this PR? 🤔

Sorry @JasonLi-cn  -- marking as ready for review so we can give it another look

It seems like this PR is failing a CI check: https://github.com/apache/datafusion/actions/runs/8771259487/job/24068788239?pr=10054

It seems like this PR is failing a CI check: https://github.com/apache/datafusion/actions/runs/8771259487/job/24068788239?pr=10054

I originally intended to modify the Cargo.lock after it was approved. 😅

Sorry @JasonLi-cn -- marking as ready for review so we can give it another look

It doesn't matter. For this PR, I personally think it is valuable, but in terms of code implementation, I am not sure if there is a better solution, which needs the help of friends in the community. 🙏


rust-rocksdb: Update rocksdb and titan with arm crc32 improvment etc

What problem does this PR solve?
Problem Summary:
Update rust-rocksdb with PR https://2github.com/tikv/rust-rocksdb/pull/618
What is changed and how it works?
What's Changed: update rust-rocksdb
Related changes
No
Check List
Tests
CI
Release note

Improve crc32 performance on ARM

/merge


The magnetometer issue in F_MPU6500.cpp

The magnetometer for my unit cannot use the the set pass mode from the code. Hence I suggest we used this code
writeByte(IMUAddress, MPU6500_INT_PIN_CFG, 0x02);	//enable Magnetometer bypass
writeByte(IMUAddress, MPU6500_INT_ENABLE, 0x01);    // Enable data ready (bit 0) interrupt

**Before this the code use 0x22 to enable Magnetometer to bypass.

Can you expand on your issue? what do you mean by "The magnetometer for my unit cannot use the the set pass mode from the code."
if you have a magnetometer just plug it directly to the i2c bus, in paralell with the IMU.


[Minor BUG] Cannot import the description field when using the method 'createNewCustomEffectsWith' and  the chat handler show undefined description

Describe the bug
Cannot import the description field of the chat handler when using the method 'createNewCustomEffectsWith'.
To Reproduce
Steps to reproduce the behavior:
Just put the code because is a very easy fixing:
       const effects = <MY ARRAY OF EFFECTS>
        const activeEffectsData: any[] = [];
        for (const effect of effects) {
          // I also added this for specifically checking for custom effects.
          // It will return undefined if it doesn't exist:
          const effectFounded = game.dfreds.effectInterface.findCustomEffectByName(effect.name);
          if (!effectFounded) {
            const origin = undefined;
            const overlay = false;
            activeEffectsData.push(effect.convertToActiveEffectData({ origin, overlay }));
          }
        }
        //The data that is passed in are standard ActiveEffectData... i.e. from
        game.dfreds.effectInterface.createNewCustomEffectsWith({
          activeEffects: activeEffectsData,
        });

now on the chat handler class this line: https://github.com/DFreds/dfreds-convenient-effects/blob/3917056ee198f08ca28b456dd99f50ab01eead96/scripts/chat-handler.js#L65 has the description always undefined, this is because the ActiveEffectData doen't have a 'description' field (https://foundryvtt.com/api/data.ActiveEffectData.html)
A very simple solution for this is just to add a check ad then go to search for the convinient description.
so just replace this:
message += `<p>${effect.description}</p>`;

with this:
message += `<p>${effect.description ? effect.description : effect.flags.convenientDescription}</p>`;

or any solution you find more useful for this use case.
Expected behavior
Screenshots
Additional context

First of all, thanks for using the issue template. Secondly, thanks for the details info and fix suggestion. I appreciate it :D
Fixed in v2.4.4


Pencil Promo block #108

Fix #108
Banner blocks can be enabled or disabled by changing the data attributes in page word file:
Section Metadata
Pencil banner black | disabled
Pencil banner copper | pencil-banner-copper
Promo block gold | promo-banner-gold
Promo block copper | promo-banner-copper
Test URLs:

Before: https://develop--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/marko/v2/all-trucks
After: https://108-pencil-promo-block--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/marko/v2/all-trucks

IDK if this is regarding this issue but since the block is on this page I found it and could be solved. There is a small gap in the images of the 'all-trucks' block when hovered. This could be solved by deleting line 288 (align-items property) from 'v2-all-trucks.css' file.


Contacts not being added to campaigns anymore

My company has been using the "Add Campaign Members By Report" app successfully in our Salesforce org for some time, but I recently deactivated the Admin who installed the package, as he left the company.
The reports we are using are scheduled to run every night. The running user is an active Admin, but the process to add the contacts to campaigns doesn't seem to be working anymore - it stopped when I deactivated our old Admin's User account.
I've been trying to troubleshoot for weeks and I'm at the point where I may just uninstall and reinstall the package. Here are some things I've looked at:

Assigned the active Sys Admin the "Add Campaign Members by Report Admin" permission set
Rescheduled the reports to run with the active Sys Admin as the running user

The only thing I can see that's still under our old/deactivated Admin's user is the fact that the package was installed by him, and the reports being used were created by him, but I assume neither of those things matter. I have not changed the way the "Add Campaign Members by Report Settings" records are set up.
Any suggestions on other places I can look to troubleshoot?

As an update, I found your documentation on this site and realized that I should be subscribing to the report rather than scheduling the report to run via an apex job. The subscribe option has the Execute Custom Action = AddCampaignMembersbyReportAction, vs. scheduling the job which did not. I subscribed to it for 7AM tomorrow so fingers crossed that this works and I can close this issue!

this works now - sorry for the false alarm. The documentation on your page was helpful, I didn't have that before. you can close or delete this :)

Hi @jlucciano, glad you got it working. I appreciate your updates as you worked through the issue as that is helpful for anyone else you may encounter the same problem.
I'm also glad to hear you're enjoying this solution =)
You might also be interested in my other solution, Mass Action Scheduler, which is a much more robust and fully featured automation scheduling tool. Also free. The "contacts to campaign" automation is one of my earliest projects and precursor to Mass Action Scheduler.


10 request to add check for cscvw33061

Fix for issue #10 . Tested via test_logic and lab APIC.

Last request, change output to:

remove target version (user has to manually select this in the beginning and its displayed up top)
Add the specific VLAN block(s) that are set to internal

Example:
[Check 40/40] Internal VLAN Pool Check...                                                                          FAIL - OUTAGE WARNING!!
  VLAN Pool        VLAN Block                          Warning
  ---------        -------                             -------
  jr-dynamic-pool  from-[vlan-3100]-to-[vlan-3200]     Encap block has role "internal" and is associated to a non-AVE domain

  Recommended Action: Ensure any VLAN Encap blocks explicitly used for leaf front panel VLAN programming are set to "external (on the wire)"
  Reference Document: https://bst.cloudapps.cisco.com/bugsearch/bug/CSCvw33061

latest pytest positive result, going to merge:
[Check  4/7] Internal VLAN Pool Check...                                                                          FAIL - OUTAGE WARNING!!
  VLAN Pool        Internal VLAN Block(s)           Non-AVE Domain              Warning
  ---------        ----------------------           --------------              -------
  jr-dynamic-pool  from-[vlan-3100]-to-[vlan-3200]  uni/vmmp-VMware/dom-jr-dvs  VLANs in this Block will be removed from switch Front-Panel if not corrected

  Recommended Action: Ensure Leaf Front-Panel VLAN Blocks are explicitly set to "external (on the wire)"
  Reference Document: https://bst.cloudapps.cisco.com/bugsearch/bug/CSCvw33061


First draft of Overview

This is after the overview_and_structure branch PR.
Please have a read and comment. I put more or less everything that came to mind and we might need to reorganize the information a bit.

I will merge for now and we can start PRs for editorial change :)


Sub-sampled SRA to test the nascent transcription pipeline.

Here's the test SRA we've been using for the pipeline. Hope the size is considered small enough, please let us know if there are any issues or concerns!

Doh'! Sorry about that, was doing this in between DockerHub and Travis and missed that detail.

Looks good +1 However, the PR needs to go to a branch specifically for this pipeline, not master.
See (recently updated) docs here:

You want this repo to also use a branch with the name of your workflow, so first go to the repository GitHub web page and create this new branch using the UI there. Once created, you can open a pull request and select this as the target branch.

Once you make your branch you should be able to edit this PR and change the target branch. Let me know if you have any problems.

I just created a branch for nascent and set it as the new target for this pull request.


AWSJsonClient::MakeRequest() called with default arguments crashes in AWSClient::AttemptExhaustively()

What platform/OS are you using?
Ubuntu 18.04.2
Which version of the SDK?
1.6.0 (still broken in 1.7.127)
What compiler are you using? what version?
gcc 7.4.0
I built aws-sdk-cpp with CMAKE_BUILD_TYPE=Debug.
Catchpoint 1 (exception thrown), 0x00007ffff5b9cced in __cxa_throw () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
(gdb) bt
#0  0x00007ffff5b9cced in __cxa_throw () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#1  0x00007ffff5b98797 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#2  0x00007ffff79453d8 in std::__cxx11::basic_string<char, std::char_traits<char>, Aws::Allocator<char> >::_M_construct<char const*> (this=0x7fffffffcc60, __beg=0x0, __end=<optimized out>)
    at /usr/include/c++/7/bits/basic_string.tcc:212
#3  0x00007ffff6f05177 in Aws::Client::AWSClient::AttemptExhaustively (this=0x7fffffffd620, uri=..., method=Aws::Http::HttpMethod::HTTP_GET, signerName=0x7ffff6f99060 <Aws::Auth::SIGV4_SIGNER> "SignatureV4",
    requestName=0x0) at /home/fettinge/build/HDMA-EXT/Source/aws-sdk-cpp/aws-cpp-sdk-core/source/client/AWSClient.cpp:238
#4  0x00007ffff6f08e81 in Aws::Client::AWSJsonClient::MakeRequest (this=0x7fffffffd620, uri=..., method=Aws::Http::HttpMethod::HTTP_GET, signerName=0x7ffff6f99060 <Aws::Auth::SIGV4_SIGNER> "SignatureV4",
    requestName=0x0) at /home/fettinge/build/HDMA-EXT/Source/aws-sdk-cpp/aws-cpp-sdk-core/source/client/AWSClient.cpp:699
#5  0x00007ffff7945ba4 in MyFunc(this=0x7fffffffd620, request=...) at MyApp.cpp:333
#6  0x000055555556847b in main (argc=<optimized out>, argv=<optimized out>) at MyApp.cpp:92

We can see how the application calls AWSJsonClient::MakeRequest() below:
JsonValue MyFunc(const std::string& request)
{
    Aws::Client::JsonOutcome outcome =
==>     MakeRequest(Aws::String(request), Aws::Http::HttpMethod::HTTP_GET);
    ...

What's interesting is the 2 additional arguments to AWSJsonClient::MakeRequest() which have default values:
aws-cpp-sdk-core/include/aws/core/client/AWSClient.h
            /**
             * Returns a Json document or an error from the request. Does some marshalling json and raw streams,
             * then just calls AttemptExhaustively.
             *
             * method defaults to POST
             */
            JsonOutcome MakeRequest(const Aws::Http::URI& uri,
                Http::HttpMethod method = Http::HttpMethod::HTTP_POST,
                const char* signerName = Aws::Auth::SIGV4_SIGNER,
==>             const char* requestName = nullptr) const;

Notice that the 4th argument requestName defaults to nullptr. This becomes a problem when MakeRequest() passes requestName to AttemptExhaustively(), since it attempts to construct a string from nullptr and the std::string constructor throws std::logic_error.
aws-sdk-cpp/aws-cpp-sdk-core/source/client/AWSClient.cpp
HttpResponseOutcome AWSClient::AttemptExhaustively(const Aws::Http::URI& uri, HttpMethod method, const char* signerName, const char* requestName) const
{
    HttpResponseOutcome outcome;
    //TODO collect metrics from core.
    Aws::Monitoring::CoreMetricsCollection coreMetrics;
==> auto contexts = Aws::Monitoring::OnRequestStarted(this->GetServiceClientName(),requestName);
                                                                                ^

This is caused by 941c38345b556987e6bcbdaac1d215619a824fc9 which first appeared in 1.6.0:

This is of course not hard to work around by specifying all 4 arguments when calling AWSJsonClient::MakeRequest(), but it would be nice to have AWSJsonClient::MakeRequest() work when called with default arguments.

Hi @BinaryMan32, thanks for reaching out and you're right, this does seem like a bug we'll have to look into.

Hi @BinaryMan32 ,
We've updated the default values from nullptr to empty strings so that it doesn't break using default values.
Changes are published from version 1.7.141


Internal error when trying to sign up as user

Hi @swe-thinhnguyen1701 I attached a screenshot of the error.

can you tell me step by step when this error raise?

I pulled code from github, I was already on the database, I did npm seed, I did node server.js. I went to sign up. I clicked sign up as user. I entered my information on the page<EMAIL_ADDRESS>stefan456 username, etc. Then the internal error popped up.

ERROR fixed

Error fixed.


Workflow withItems fails if 1 of the actions fail

Discussed in https://github.com/StackStorm/st2/discussions/5970

Originally posted by glafkosch May  1, 2023
I am making dynamically generated worker requests with make_worker_requests task and passing those to another task run_linked_workers which runs for each item the action tf.run-worker-and-store-result.
The run_linked_workers task runs various worker checks for my project such as sslcheck, webcheck, dbcheck, etc. Everything works well if all return success but if even one check fails which is normal to fail in my case then the whole task fail.
As per documentation: "All action executions must complete successfully for the task to reach a succeeded state. If one or more action executions fail, then the task will result in a failed state."
ref: https://docs.stackstorm.com/orquesta/languages/orquesta.html#with-items-model
Is there any solution to solve this? Maybe is possible to introduce an additional variable to withItems if it should fail or succeed?
make_worker_requests:
action: tf.make_worker_requests
input:
target: <% ctx().target %>
target_type: <% ctx().target_type %>
services: "{{ ctx().services }}"
step: <% ctx().step %>
scan_id: <% ctx().scan_id %>
next:
- when: <% succeeded() %>
publish:
- portscan_linked_worker_requests: <% result().result %>
do: run_linked_workers
- when: <% failed() %>
publish:
- errors: <% ctx().errors + [dict(summary=>"Unable to make worker requests.", detail=>result())] %>
do:
- fail
run_linked_workers:
with:
items: <% ctx().portscan_linked_worker_requests %>
action: tf.run-worker-and-store-result
input:
worker_request: <% item() %>
next:
- when: <% succeeded() %>
publish:
- lwo: <% result() %>
- when: <% failed() %>
publish:
- errors: <% ctx().errors + [dict(summary=>"Unable to run linked workers.", detail=>result())] %>
do:
- fail

if you want the workflow to continue even if a task fails, you can instruct the workflow to do so, with specifying the task to do next if the task fails, so you can change:
do: run_linked_workers

when: <% failed() %>
publish:
errors: <% ctx().errors + [dict(summary=>"Unable to make worker requests.", detail=>result())] %>
do:
fail

to:
do: run_linked_workers

when: <% failed() %>
publish:
errors: <% ctx().errors + [dict(summary=>"Unable to make worker requests.", detail=>result())] %>
do:
fail
noop

this should instruct the workflow engine to continue execution in a failed state, so you'll have to handle the failure down the line (as the workflow will report failed)


Nuget pack command cannot find build output for multiple targets

Using the default .NET Core (.NET Framework) template on VSTS.
The build is output to the following locations (for both framework targets specified in the csproj):
\bin\release\net461\output.dll
\bin\release\netstandard1.6\output.dll

The Nuget task (version 2.0.5) looks for the output in the wrong location:
NuGet.CommandLine.CommandLineException: Unable to find 'bin\release\output\bin\release\'. Make sure the project has been built.

This is related to https://github.com/NuGet/Home/issues/5832 and not related to the build task. We made a workaround using GeneratePackageOnBuild for .NET Standard libraries.

Closing this out based on previous comment.

This fails on a .NET framework pack that references a .NET Standard core library.

@chris-strauss we are having the exact same issue still. Any progress on this? Did you find a workaround?

I assume this is still an issue. Has anyone found a work around?

@chris-strauss we are having the exact same issue still. Any progress on this? Did you find a workaround?

@Sreini I had removed the Pack task from the pipeline and had the project pack on build.


Support RenameTextSpan from TypeScript

Add support for TypeScript 3.2's RenameTextSpan. This allows us to fix cases such as: https://github.com/Microsoft/TypeScript/issues/12007
Planning to pick up support in October but we'll only ship TS 3.2 in November. You can use typescript@next to try it out early.

For verification, upgrade your test workspace to see typescript@next and see Microsoft/TypeScript#12007 for example test case

Awesome, I have wanted this


Looping circle after blockstack login

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in QA
Followed all applicable steps in the TROUBLESHOOTING guide: TODO
Checked for relevant discussions on Discord: https://discord.gg/pPERUuv
Checked that your issue isn't already filed: https://github.com/COVID-19-electronic-health-system/Corona-tracker/issues

Description
Looping login // doesn't work, but it will work if you refresh browser or open in new window. Link to video in discord: https://discordapp.com/channels/687791378075484161/689541363254951951/692857336683036813
Steps to Reproduce

Login with blockstack
Proceed
Looping black circle with black dot — cycles at top and doesn't go away or proceed to next screen.

Expected behavior:
Expect to go to homepage after log in directly.
Actual behavior:
Loop...or you have to refresh screen to go to homepage.
Reproduces how often:
Every time we log into blockstack
Versions

Additional Information
Other people have had this issue too.

Are there any error messages when running chrome dev tools (Cmd+Optinon+i on OSX)? Could be duplicate of #180

The endless spinner may happen if a Radiks server is not available at the configured or default URL, at least until #218 eventually has been addressed.

@BrianHHough do you know if this has been resolved on your end? I haven't been able to reproduce this but want to be sure before closing.

I and 3 test users haven't experienced this bug in 100% cases.

I'll close this then!


EDA (parent issue) Make plasmo and host-specific versions of the correlation apps

Plasmo and Host are itching for the correlation apps. We've agreed to release the two we have for their wgcna eigengene data with 68.
Here's the current plan:
The compute service plugins are getting refactored, so we'll need to update the compute requests.
The data service will have a plugin specifically for genomics. That makes our frontend life easier.
We need to make a third correlation plugin that uses "eigengene" (not taxa, etc) language, and allows the user to choose 1 eigengene collection and the metadata, or 1 eigengene collection and the second eigengene collection.

UX Apr 17 2024 feedback: please add term "WGCNA" to the Correlation option when clicking on New Visualization. (it already says eigengenes). Eventually we might need a generic and a study specific name?


Expose current state through WampClient

Currently, as I know, 'WampClient' use 'StateController' that holds current State of the client. As for know, user only able to subscribe on state chanings by calling client.statusChanged(). But I need just get current state. For example, I just need to check is current state is 'Connected' state.
As for know, I need to make some workaround. I need to store external field and in every event that comes from statusChanged method update this field. Also I need to control, for example, close method to update my field to be on the safe side.
But it's just an work around, why I need to do it, where there is already such field in StateController.
Could you, please, provide that functionality?

@Matthias247 Hello, I've added pull request, that expose State object. If it's normal, please, accept it. Thank you.

This is by intention. The whole State thing is an implementation detail which is not intented to be used by the library user. It even can't be used, as it is not thread safe and the users can code run in an arbitrary thread while the state changes happen in a thread owned by jawampa.
The sole way for the user to observe the state is the statusChanged event that you mention. You can subscribe to it and observe it from any thread. You can in this subscription also update a local field which stores the last known connection state in your thread and make your further assumptions based on that.


jr-quay-odf

This PR changes the following:

ODF Deployment - only deploys the MCG to support back end storage for Quay registry.
QuayRegistry: Modifies the secret/config.yaml to remove erroneous parameters in the config preventing Quay from starting:

SETUP_COMPLETE: false and another to do with TAG expiration.

All checks have failed. You got some test stuff to tidy up.

LGTM


fix flaky test for BrokerServiceLookupTest.testModularLoadManagerSplitBundle

Fixed #13102
It is invalid to set the loadBalancerNamespaceBundleMaxTopics=1 after the initialization is completed, and the condition of stats.topics = 2 > maxBundleTopics = 1000(default) can not be established, so the operation of bundle-split can not be triggered after the leader transfer.
Documentation

[x] no-need-doc

no doc is required to update.

@Shoothzj  Could you please take a look?

@wuzhanpeng  Thanks for fixing one of the most flaky tests. Good work!

This didn't fix the problem. I reopened the issue.


Loosen requests version requirement

requests 2.22.0 was released in May 2019. A lot of other packages now depend on higher versions causing conflicts when these need to be used in the same environment.

@kwevers thanks for this contribution!

@captainGeech42 Thanks for the merge! Any chance on creating a release for this?

Hi @kwevers , sorry for the delay on getting a new release out, v1.0.3 has been published to PyPi

Thanks!


Unable to open SE due to it keeps loading for a long time

Storage Explorer Version: 1.8.1_20190605.4
Platform/OS: Ubuntu 18.04
Commit: a7b2b07e
Regression From: Previous release 1.8.1
Steps to reproduce:

Try to open Storage Explorer

Expect Experience:
Succeed to open the Storage Explorer.
Actual Experience:
Keep loading for a long time.

More info:
This issue doesn't reproduce on latest master build.

Closing. This build should not have been tested? We'll email you @v-xuanzh

Reopening. This is from settings branch.

Duplicate of #1438.

@v-xianya I seem to be having trouble reproing with current builds. Does this still happen for you?

Hi @craxal Verified this issue using the build feature/main-host 20190624.2.

This issue doesn't reproduce when using snap to install Storage Explorer.
This issue still reproduces when downloading *.tar.gz file to install Storage Explorer.


WIP fix dynamic component to support embroider-optimised

I meant to add this as a draft but I can't see the "make draft" button anywhere 🤔  🤷

eh... I did it 😳 I really did it 🎉 it finally works 🎉 I've never been so happy to see a full green CI 😍


Tests: Automatically normalize line ends

Also discussed here, The parser for .test files will now automatically convert all file contents to CRLF line ends. This ensures that all languages are tested with the more difficult line ends.
This lead to the discovery (and fix) of a bug in False.
This PR contains 4 things:

The parser now converting line ends.
.test files no longer being declared as binary in .gitattributes.
The fix for False.
The changes for all changed test files. Some test files used LF line ends which were reflected in the JSON.

This PR does not convert the line ends of existing .test files to LF. This means that we now have a bunch of CRLF files in the repo. Should I convert them?
@mAAdhaTTah @joshgoebel

This means that we now have a bunch of CRLF files in the repo. Should I convert them?

I'm personally in favor of unix line endings - whichever one that is - and being consistent seems appropriate.

Advice for reviewers: Don't open the "Files" tab on Github, your tab will freeze.

Ok, no. I reverted that. I did a small test and these EOL changes will conflict will literally every PR that changes a test file.


Add flags to covecov reports to avoid coverage flakes

What does this PR do?
Codecov reports are flaky on this repo, always on platform specific (either linux-only or windows-only) files. My guess is that the circleci and appveyor reports collide and overwrite themselves.
This PR uses the flags feature to keep both CIs in two separate report spaces. This hopefully should alleviate the flaky diff issue.

Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?

I like your theory from where the problem could come from, we are having the same issue in integration-core. I am not sure if it is the same root cause tho


TypeScript error with latest @types/react

I get a typescript failure for LibraryManagedAttributes when using both the latest useful-types (1.3.0) and @types/react (16.8.19).
This issue did not happen with 16.8.18.
 ➜ yarn type-check
yarn run v1.12.3
$ sewing-kit type-check
[type-check] Checking tsconfig.json
node_modules/@shopify/useful-types/node_modules/@types/react/index.d.ts:2817:14 - error TS2300: Duplicate identifier 'LibraryManagedAttributes'.

2817         type LibraryManagedAttributes<C, P> = C extends React.MemoExoticComponent<infer T> | React.LazyExoticComponent<infer T>
                  ~~~~~~~~~~~~~~~~~~~~~~~~

  node_modules/@types/react/index.d.ts:2818:14
    2818         type LibraryManagedAttributes<C, P> = C extends React.MemoExoticComponent<infer T> | React.LazyExoticComponent<infer T>
                      ~~~~~~~~~~~~~~~~~~~~~~~~
    'LibraryManagedAttributes' was also declared here.

node_modules/@types/react/index.d.ts:2818:14 - error TS2300: Duplicate identifier 'LibraryManagedAttributes'.

2818         type LibraryManagedAttributes<C, P> = C extends React.MemoExoticComponent<infer T> | React.LazyExoticComponent<infer T>
                  ~~~~~~~~~~~~~~~~~~~~~~~~

  node_modules/@shopify/useful-types/node_modules/@types/react/index.d.ts:2817:14
    2817         type LibraryManagedAttributes<C, P> = C extends React.MemoExoticComponent<infer T> | React.LazyExoticComponent<infer T>
                      ~~~~~~~~~~~~~~~~~~~~~~~~
    'LibraryManagedAttributes' was also declared here.

Found 2 errors.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

To update:
I am now locked into "@types/react": 16.8.20 and things are working. If I change that version, the same issue shown above re-surfaces.

Seems to now be resolved. The latest of all my packages resolved the issue.


Perform constant folding

We should compute constant expressions (such as 1 + 2 and false || true at compile time.

Fixed by #123


Introduce style checking and linting for martin book

Introduce some github action or just recipe to performs style checking and linting for Markdown, to avoid broken links or undesired spaces?

agree, this is definitely needed, esp that some links might be in readme and docs and other places. Not a high priority though, but nice to have

Maybe we can get some inspiration from the ci in rust-lang/book.
name: CI
on: [push, pull_request]

jobs:
  test:
    name: Run tests
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@master
    - name: Update rustup
      run: rustup self update
    - name: Install Rust
      run: |
        rustup set profile minimal
        rustup toolchain install 1.67 -c rust-docs
        rustup default 1.67
    - name: Install mdbook
      run: |
        mkdir bin
        curl -sSL https://github.com/rust-lang/mdBook/releases/download/v0.4.21/mdbook-v0.4.21-x86_64-unknown-linux-gnu.tar.gz | tar -xz --directory=bin
        echo "$(pwd)/bin" >> ${GITHUB_PATH}
    - name: Report versions
      run: |
        rustup --version
        rustc -Vv
        mdbook --version
    - name: Run tests
      run: mdbook test
  lint:
    name: Run lints
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@master
    - name: Update rustup
      run: rustup self update
    - name: Install Rust
      run: |
        rustup set profile minimal
        rustup toolchain install nightly -c rust-docs
        rustup override set nightly
    - name: Install mdbook
      run: |
        mkdir bin
        curl -sSL https://github.com/rust-lang/mdBook/releases/download/v0.4.21/mdbook-v0.4.21-x86_64-unknown-linux-gnu.tar.gz | tar -xz --directory=bin
        echo "$(pwd)/bin" >> ${GITHUB_PATH}
    - name: Install aspell
      run: sudo apt-get install aspell
    - name: Install shellcheck
      run: sudo apt-get install shellcheck
    - name: Report versions
      run: |
        rustup --version
        rustc -Vv
        mdbook --version
        aspell --version
        shellcheck --version
    - name: Shellcheck
      run: find . -name '*.sh' | xargs shellcheck
    - name: Spellcheck
      run: bash ci/spellcheck.sh list
    - name: Lint for local file paths
      run: |
        mdbook build
        cargo run --bin lfp src
    - name: Validate references
      run: bash ci/validate.sh
    - name: Check for broken links
      run: |
        curl -sSLo linkcheck.sh \
          https://raw.githubusercontent.com/rust-lang/rust/master/src/tools/linkchecker/linkcheck.sh
        # Cannot use --all here because of the generated redirect pages aren't available.
        sh linkcheck.sh book

Thx, this might be a good pattern to follow. Just please keep in mind - we do not have that many broken links.  The problem is that other sites will link to our docs, so if we change the URL of the book pages, those links will break.

Seems we can do little to the outside links. Maybe just keep .md file names unchanged.

yep, my point exactly :)  We might even want to revert to the older links because we haven't had the numbered ones for too long?

Ok. I will split this two tasks.

[ ] Revert markdown file names back
[ ] Add markdown style check in CI

agree, makes sense, thanks!


Fix major bugs in AES Key Wrap code

crypto/modes/wrap128.c was heavily refactored to support AES Key Wrap with Padding, and four bugs were introduced into CRYPTO_128_unwrap() at that time:

crypto_128_unwrap_raw()'s return value (ret) is checked incorrectly, and the function immediately returns ret in (almost) all cases. This makes the IV checking code later in the function unreachable, but callers think the IV check succeeded since CRYPTO_128_unwrap()'s return value is non-zero.
FIX: Return 0 (error) if crypto_128_unwrap_raw() returned 0 (error).

crypto_128_unwrap_raw() writes the IV to the buffer pointed to by the iv parameter, not to the first 8 bytes of the output buffer (out) as the IV checking code expects.  This makes the IV check fail.
FIX: Compare iv to got_iv, not out.

The data written to the output buffer (out) is "cleansed" if the IV check fails, but the code passes OPENSSL_cleanse() the input buffer length (inlen) instead of the number of bytes that crypto_128_unwrap_raw() wrote to the output buffer (ret).  This means that OPENSSL_cleanse() could potentially write past the end of out.
FIX: Change inlen to ret in the OPENSSL_cleanse() call.

CRYPTO_128_unwrap() is returning the length of the input buffer (inlen) instead of the number of bytes written to the output buffer (ret).  This could cause the caller to read past the end of out.
FIX: Return ret instead of inlen at the end of the function.

Also fix minor issues in the Doxygen comments in crypto/modes/wrap128.c.

A small program demonstrating the bug this pull request fixes is available at: https://gist.github.com/rwg/d9b39167f49adf5b6e12

This was merged in commits 1062ecfc53622ff42edef5af63ace39c23dd3b49 and e6abba3ad6107d35a6e8b01a1a145902edf0062d.