webview can enable chromeClient through props.

Motivation: #6405

FYI buck build rpoblems

@lucasfeliciano Why not just set it by default?

@satya164 I came with this idea as well.
I mentioned it in #6405 but @charpeni said it was better to make the PR that way and discuss alternatives here.
One of the things of enable it as a prop is that if you are developing a product which target devices with no hardware acceleration you can disable it.
In my case I could enable as a default behaviour but I dont know about other people

@lucasfeliciano IMO it doesn't make sense to have this as a prop. Being able to embed videos is something people expect by default.
Moreover, the prop is also quite confusing, as the name of the prop is tied to the implementation detail and not the feature it enables. But again, I don't think enableVideos is the correct prop name since setting a WebChromeClient allows to handle far more things rather than just videos.
About enabling it only for devices which have hardware acceleration, don't all devices have hardware acceleration these days? Even then, since being able to embed videos requires both hardware acceleration and setting a WebChromeClient, just setting a WebChromeClient shouldn't be an issue.
cc @mkonicek

branch 'feature/chromeClient-on-android-webview' not working on 0.22

@satya164 I agree with you.
Default is the best approach for me.
IMHO, even better if there is a prop to disable it if the developer wants.

I think I made some boo boo here with the rebase.
:disappointed:

I'll fix this soon.
Tried to do this asap, didnt end how I expected.
hahaha

:)

Sorry for the delay, I was out the whole weekend.
Working upon v0.22 now.
And the discussion about "props vs default"?
@satya164 I'm into have this a default behaviour

@lucasfeliciano Let's make it default. Also can you fix the PR?

@satya164 sure.
I'm on it now

I'll close this PR and make a new one!


Perlin Lib not compatible with MUD2

Description
Currently, MUD2 does not play nicely with public libraries. The functions in the Perlin.sol file all have public modifiers.
Motivation
Inability to use Perlin noise in systems.
Minimal Repro
// SPDX-License-Identifier: MIT
pragma solidity >=0.8.0;

import { System } from<EMAIL_ADDRESS>import { Perlin } from<EMAIL_ADDRESS>
contract MySystem is System {

    function callsPerlin(int256 positionX, int256 positionY) public pure returns (uint256) {
        int128 perlinNoise = Perlin.noise2d(positionX, positionY, 0, 0);
    }
}

fixed in #934, you can update your project to the latest MUD with pnpm mud:up (assuming you started from a template)

Thanks!


Automatic PR from RestAPI-PR677

Generated from RestAPI PR: https://github.com/Azure/azure-rest-api-specs/pull/677

Doc only


feat: hooks refactoring

This is a proposal for the hooks refactoring.
It wprks without using mercurius internals.
Any feedback is appreciated!.
I've removed the reference to the mercurius/lib/errors a done some code replication that can be removed exporting the error object from mercurius.
there is still a reference to mercurius/lib/subscription-client that requires more code duplication and I decided to leave it there.
If agreed I'll add the two exports from the mercurius modules to use it properly.

awesome - I'm out most of today, but will take a look tomorrow :)

@mcollina @jonnydgreen thanks, I'll finalise the task, add docs and types and open the specific PR in mercurius project to export the Subscription class


[Bug]: Running nvim in shrs uses a lot of cpu

What went wrong?

Not sure what the reason is, will need further investigation
Once nvim is closed, it goes back to using very little resources

interesting, i also randomly get really high cpu spikes for no reason. maybe the shell is busy looping for output or something when running an interactive command?

Just to add, running htop and even cmatrix (needed to find something not super complicated that hijacks your terminal output lol) does this. Seems like it's output related, but not 100% sure.

I believe the issue is with self.wait_for_job(job_id); in job.rs. Removing the line and replacing with      sleep(Duration::from_secs(30)); Seems to remove all performance issues. I thought it had to do with the duration of the program as it waits, but other long processes dont have any effects on performance, unless they take control of the terminal.


Adding codeQL

I think this might be useful to address security issues:
References
https://codeql.github.com/docs/

Output of the workflow:


Muti pos plate selector

Codecov Report

Merging #30 (9ed2a9b) into main (5e9dbb3) will decrease coverage by 5.56%.
The diff coverage is 57.21%.

:exclamation: Current head 9ed2a9b differs from pull request most recent head d5f2dd5. Consider uploading reports for the commit d5f2dd5 to get more accurate results

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   78.51%   72.95%   -5.57%
==========================================
  Files          23       27       +4
  Lines        1983     2418     +435
==========================================
+ Hits         1557     1764     +207
- Misses        426      654     +228

Impacted Files
Coverage Δ

...nager_gui/_gui_objects/_hcs_widget/_update_yaml.py
11.37% <11.37%> (ø)

...er_gui/_gui_objects/_hcs_widget/_graphics_scene.py
31.37% <31.37%> (ø)

micromanager_gui/_gui_objects/_hcs_widget/_well.py
58.33% <58.33%> (ø)

micromanager_gui/main_window.py
69.41% <71.42%> (+0.13%)
:arrow_up:

...r_gui/_gui_objects/_hcs_widget/_main_hcs_widget.py
76.47% <76.47%> (ø)

...i/_gui_objects/_hcs_widget/_well_plate_database.py
85.10% <85.10%> (ø)

...icromanager_gui/_core_widgets/_property_browser.py
85.49% <85.49%> (ø)

micromanager_gui/_core_widgets/_property_widget.py
91.25% <86.04%> (+1.94%)
:arrow_up:

micromanager_gui/_core_widgets/__init__.py
100.00% <100.00%> (ø)

micromanager_gui/_gui_objects/_mm_widget.py
96.93% <100.00%> (ø)

... and 2 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Add Line Plot Helper

Entire Functionality of the Line Plot has been added with colors, interactive tooltip and all labels with SVG crosses.

Went over this in VC 🙂


Update data-retention.md

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://657a55e32edb9334778c88be--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://657a58552edb9336628c8b05--harness-developer.netlify.app


Example dataset/invocation of DSSAT

Hi @chporter , @GerritHoogenboom and @frostbytten ,
We are trying to do a test run of DSSAT with some representative inputs in order to make sure that our program analysis pipeline produces outputs that are faithful to the original code.
Would it be possible to get an example dataset and invocation of the dscsm047 executable to see if we can generate the expected outputs? I managed to get the following output:

RUN    TRT FLO MAT TOPWT HARWT  RAIN  TIRR   CET  PESW  TNUP  TNLF   TSON TSOC
           dap dap kg/ha kg/ha    mm    mm    mm    mm kg/ha kg/ha  kg/ha t/ha
  1 SB   1 -99 -99   -99   -99   -99   -99   -99   -99   -99   -99   -99      0
  2 SB   2 -99 -99   -99   -99   -99   -99   -99   -99   -99   -99   -99      0
  3 SB   3 -99 -99   -99   -99   -99   -99   -99   -99   -99   -99   -99      0
  4 SB   4 -99 -99   -99   -99   -99   -99   -99   -99   -99   -99   -99      0

By copying the following files (from the files sent by @chporter by email on 10/30/2018 from running the ASCE and PET options for a 1978 soybean experiment in Gainesville, FL) to the Data directory:
DSSBatch.v47
FERCH047.SDA
SBGRO047.CUL
SBGRO047.ECO
SBGRO047.SPE
SOIL.SOL
UFGA7801.SBX
dscsm047

and running the following command:
./dscsm047 B DSSBatch.v47

While the program runs to completion, the outputs seem funky, so I am fairly sure I am doing something wrong over here. We would be grateful for any help you could provide on this.
I'm tagging @skdebray , @cl4yton , and @pauldhein to keep them in the loop.
Thanks!

Hi, @adarshp
Sorry I didn't see this earlier.
I think you are missing the weather file.  It should be named UFGA7801.WTH. If you put it in the data directory, the model will find it.
Please also include the CO2047.WDA file from the StandardData directory.
This latest version of the code has disabled the ASCE-K version of potential evapotranspiration. We did that because of some unintended consequences of those routines. (just so you know).

@chporter I added the the UFGA7801.WTH and CO2047.WDA files, but am now getting the following exception:
(delphi) ~/github/dssat-csm-os/Data (develop) $ ./dscsm047 B DSSBatch.v47

Program received signal SIGFPE: Floating-point exception - erroneous arithmetic operation.

Backtrace for this error:
#0  0x110f2ea14
#1  0x110f2e136
#2  0x7fff69dc542c
#3  0x10f2a9d8c
#4  0x10f2aaa0e
#5  0x10f2ab774
#6  0x10f2a64d8
#7  0x10f2b2308
#8  0x10ee88665
#9  0x10ee869d4
#10  0x10f2c9673
Floating point exception: 8

@adarshp We finalized this outside github, so I'm closing the issue.


[Bug]<EMAIL_ADDRESS>Rimraf versions prior to v4 are no longer supported, npm WARN deprecated<EMAIL_ADDRESS>This package is no longer supported<EMAIL_ADDRESS>This package is no longer supported.

Attach (recommended) or Link to PDF file
<EMAIL_ADDRESS>Rimraf versions prior to v4 are no longer supported
├─┬<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └─┬<EMAIL_ADDRESS>│     └──<EMAIL_ADDRESS>Web browser and its version
Chrome, Edge
Operating system and its version
Windows
PDF.js version
<EMAIL_ADDRESS>Is the bug present in the latest PDF.js version?
Yes
Is a browser extension
Yes
Steps to reproduce the problem
npm install
What is the expected behavior?
I would appreciate it if this library could be updated.
What went wrong?

Link to a viewer
No response
Additional context
No response

<EMAIL_ADDRESS>Rimraf versions prior to v4 are no longer supported

We have no such direct dependency, as can be seen in https://github.com/mozilla/pdf.js/blob/master/package.json

<EMAIL_ADDRESS>
That dependency has already been updated (will be included in the upcoming release), see https://github.com/mozilla/pdf.js/blob/d37e4b08e4006b382b14b1596c5f70df7e93fbd9/package.json#L16


Enhancement:  Option to send other stuff to Vault when applying loadout

When applying a loadout to a character, it would be great to have an option for choosing what to do about any gear that's already on the character.  For example, I have made a loadout strictly containing new HoW Weapons so that I can have fun just using those.  When applying that loadout, I would love to see a prompt asking me what I want to do...
a) Send all other gear to Vault
b) Send all other gear to other character
c) Merge gear
Right now, it always merges... which is usually ok when there's space to do so, but sometimes it would be nice to have a clean loadout exactly as chosen, with nothing else mixed in.
PS - I love DIM.  Keep up the good work!

It may be better as an option when creating/modifying the loadout. One of the reasons I really love this thing is that the workflows are just a few clicks. Making the mainline flow have more steps in it should probably be avoided.

That sounds good too... just something to make room for the loadout you want to apply.

i like the idea, we'll track this in #224. i copied your suggestion there.


fix(datagrid): hidden columns included in search results

Closes #5509
Hidden columns are included in search results.
What did you change?
packages/ibm-products/src/components/Datagrid/Extensions/ColumnCustomization/ColumnCustomization.stories.jsx
Updated columns prop to include disableGlobalFilter: true for hidden columns in story.
How did you test and verify your work?
Storybook

Like we talked previously this week, there might be a better way to do this

Hey @AlexanderMelox ,
I did some research following our meeting, and the only alternative I could find was writing a custom filter function. I also found a similar discussion topic in the React Table repository, but it doesn’t have a solution yet. There might be a better approach in TanStack version 8—I can look into this further if needed for a future implementation. This workaround is the best I could find at the moment.
However if I've missed something please let me know.

Okay I went through it, I believe the only thing @matthewgallo  mentioned was using await wait(0) instead of setTimeout, but i would double check with him


nixos/usbguard: create package and module

Motivation for this change
No usbguard module or package existed for NixOS previously. USBGuard
will protect you from BadUSB attacks. (assuming configuration is done
correctly)
Things done
I build and tested the libsodium and libgcrypt variants on my nixos-unstable system. Specifying rules for devices works.
Using the qt-applet did not work for my normal user due to the Cannot mix incompatible Qt library ..., but running usbguard-applet-qt as root works fine. (found out about by accident, can someone explain why?)
As noted in description-fields of the nixos-module options, editing the rules or daemon configuration is not possible via GUI since they are inside the nixstore. (I did not see a better way to solve this. Please let me know if I missed something)

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thanks!


Error icon

When i use it, i find some icon can not display current.
When i use 'ios-lock' in my react-native project, but it can not display current.
Could you help me? I want to use this icon.

Do you have a minimal example of the code you are failing with?

Sorry, it's my false, i re-import the ion icons.tff file into my Xcode again, it works currently.
Thank you for responding me.


feat: added support for OAuth access_token

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How to enable bot running 24hrs

How do I keep the bot online for 24 hours even if I have to off my computer?
Its kinda sad the bot has to go down if I have to go offline. Any ways?

You have to have a server, a computer that is turned on all the time. You could use a raspberry pi if you have one, you don't.

Just get a Standard VPS for very cheap, thats what I am using for hosting the bot.
http://ramnode.com/vps.php

My recommendation for best pricing and getting high specs:
https://www.scaleway.com/pricing/
2GB ram, 50GB SSD, 2 cores, unlimited internet 1gbps for ~3 euro

Information about running the bot permanently is available in the installation guides which you should've followed in the first place.

Windows: https://github.com/SexualRhinoceros/MusicBot/wiki/Installation-guide-for-Windows-7-and-up
Ubuntu: https://github.com/SexualRhinoceros/MusicBot/wiki/Installation-guide-for-Ubuntu-14.04-and-other-versions
OSX: https://github.com/SexualRhinoceros/MusicBot/wiki/Installation-guide-for-OSX
Debian: https://github.com/SexualRhinoceros/MusicBot/wiki/Installation-guide-for-Raspberry-Pi-with-Raspbian-or-PC-with-Debian
Docker: https://github.com/SexualRhinoceros/MusicBot/wiki/Installation-guide-for-Docker


WIP - Polymer support - DO NOT MERGE

Hi,
I've setup this pull request to get feedback on whether it is possible to get polymer support, and whether this is the right way to do it.
Currently virtual-dom doesn't work with webcomponents or polymer when shadow dom polyfills are used. This is because when using polyfills, the Shadow dom nodes affect the native dom manipulation methods. Polymer offers a simple API to wrap all these native calls so that dom manipulation works both with and without shadow dom.
In this approach - I simply replaced all the direct dom manipulation with polymer api (if it is present), which seems to work with shadow dom.
_Note that this doesn't actually import Polymer into the codebase (that would be unthinkable). It simply checks for the presence of polymer, and if present makes itself compatible._
The tests will definitely fail for this, so I've marked this as do not merge.
Let me know what you think.

If one needs to get Polymer elements working with virtual-dom, I'd say go cowboy style and hack virtual-dom internals to do what you did. However, we shouldn't really merge this (or anything like this) into virtual-dom. Instead, browsers should implement WCs.

The problems with going cowboy style is that -

I can't check these modifications into git
Any other dependencies which depend on virtual-dom will have to be changed as well. So in my specific use case I will need to change atleast 2 other packages.
No one else benefits from these modifications.

What specifically are your objections to adding this support? Note that this doesn't actually import Polymer into the codebase (that would be unthinkable). It simply checks for the presence of polymer, and if present makes itself compatible.

What specifically are your objections to adding this support?

Yet another check during diff & patch which might slow it down. I'm just giving my humble opinion though, let's see what Matt and Jake have to say.

Okay, that's a valid objection. However the performance impact should be minimal. The presence of polymer is checked only once per module. If not present, the wrapper function is defined as simply -
var Dom = function(x) {return x;};

https://github.com/Matt-Esch/virtual-dom/pull/296/files#diff-cc5f465c9a3d786f52fe75997e7550b0R10

I like the idea, but would rather see it completely external to virtual-dom if possible. Let the client handle replacing the dom methods themselves. (maybe a virtual-dom-polymer project to make it easier)

This can be done fully externally by passing a polymer document into patch.
Just like we do for tests

@Raynos do you have a code snippet on how to do this?

A good approach would be to decouple rendering from virtual-dom to allow different plugins. Is that something people are interested in?

I was using virtual-dom with Polymer 0.5, which used to work beautifully. For the benefit of others like me who are wondering why we need this, it's because Polymer 1.0 switched to a performant alternative they call Shady DOM (which is not a Shadow DOM polyfill but an API for walking the DOM while pretending there is Shadow DOM).
I think a great way to implement this is having a generic way to allow use of custom DOM APIs, and then having a small snippet (outside virtual-dom) which sets up Polymer interop. This patch minus polymer-dom.js almost gets us there.

Note that the tests are failing because "no output is produced for 10 minutes" during the build process. I am interested to know if this passes all the tests.

Oh I think what @Raynos means is that this can be done by passing a Polymer.dom object instead of a normal DOM object as the rootNode argument to patch. That is a great idea and looks like it is the general way of allowing custom DOM APIs that I was suggesting.

@shashi thanks! I will try out passing a polymer doc to patch and report back.

Turns out, Polymer.dom(elem).children gives an array of normal DOM nodes so Polymer.dom(elem).children[0].children e.g. will not do the look up via Shady DOM.

Ok, here is a total hack to workaround this: https://gist.github.com/shashi/167eef348f268049460f
I can wrap a node in Sneaky (as in new Sneaky(node)) before passing it to patch.

Ok, here is a total hack to workaround this: https://gist.github.com/shashi/167eef348f268049460f

This works for traversal / insertion / deletion but since getters and setters are not proxied, this does not fully work...

Updated gist, now Polymer works very well for me with #299. I just need to pass in sneakyDoc as the last (renderOptions) argument to both createElement and patch, and wrap the rootNode in new Sneaky(rootNode).
One last issue remains which is that Polymer's attached lifecycle function is called twice in cases where a child is moved to a different location due to a <template>...<content></content>...</template> definition. This is a Polymer issue though.

Closing out due to lack of activity.


Updated back version to 20.8.b1

Description
Bumped black to latest release
Motivation and Context
New version of black got released in August, this PR updates to that version
How Has This Been Tested?
Tested locally (via tox) with python 3.6
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have run the make format command to format my code
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have added my name and/or github handle to AUTHORS.rst
[ ] I have added my change to CHANGES.rst
[x] All new and existing tests passed.

Thanks!


switch pyrometer to port 8080

fix after teztnets breakage. there is no pyrometer twin PR as the port is configurable purely from config.json without a docker change.

where is the value to change the port? Only templates are in this PR

where is the value to change the port? Only templates are in this PR

It should be in values.yaml, in the config: section, but there is no example of config in the values file. See pyrometer readme.


Maintainer access to the Plugins Team

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the issue has not already been raised

Issue
This is a core plugin and the Plugins Team doesn't have access to it
CC @Uzlopak

As I did not created this repo, I can not assign the repo to any team.
Th repo creator or an organization admin have to assign it to a tam.
@fastify/leads

nothing happened.

This is a library. As such, it is under the @fastify/libraries team.


use all-contributors

https://allcontributors.org/docs/en/bot/installation

@all-contributors please add @ianhi for code

@all-contributors please add @samanthahamilton for doc

@all-contributors please add @sjhaque14 for doc

@all-contributors please add @sjhaque14 for userTesting


refactorset session var for bushy join

Proposed changes
add session var: MAX_JOIN_NUMBER_BUSHY_TREE, default is 5
if table number is less than MAX_JOIN_NUMBER_BUSHY_TREE in a join cluster, nereids try bushy tree, o.w. zigzag tree
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.69 seconds
stream load tsv:          451 seconds loaded<PHONE_NUMBER>9 Bytes, about 158 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          57 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          28 seconds loaded 861443392 Bytes, about 29 MB/s
insert into select:          27.0 seconds inserted 10000000 Rows, about 370K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230712055115_clickbench_pr_176924.html

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.13 seconds
stream load tsv:          504 seconds loaded<PHONE_NUMBER>9 Bytes, about 141 MB/s
stream load json:         18 seconds loaded<PHONE_NUMBER> Bytes, about 124 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size:<PHONE_NUMBER>6 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230712135723_clickbench_pr_176925.html

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 53.29 seconds
stream load tsv:          507 seconds loaded<PHONE_NUMBER>9 Bytes, about 140 MB/s
stream load json:         18 seconds loaded<PHONE_NUMBER> Bytes, about 124 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size:<PHONE_NUMBER>9 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230712140247_clickbench_pr_176928.html


OpenAI Compatible API Incompatibility

Describe the bug
I am reporting an issue encountered while using the xinference library version 0.9.1 with the qwen1.5 model. When attempting to leverage the OpenAI-compatible API, specifically during the invocation of the ConversableAgent._reflection_with_llm() function in Autogen, , which automatically appends a summary system message at the end of a dialogue, I encounter a BadRequestError with the following message:
BadRequestError: Error code: 400 - {'detail': 'System message should be the first one.'}
This error arises due to the system message not being the first message in the message history. However, this issue does not occur when using an official OpenAI key.
To Reproduce

Deploy the xinference: 0.9.1 Docker container with the qwen1.5-chat model.
Full error stack trace: BadRequestError: Error code: 400 - {'detail': 'System message should be the first one.'}
Simplified reproduction code snippet using curl:

curl http://localhost:9997/v1/chat/completions   -H "Content-Type: application/json"   -H "Authorization: Bearer sk-anykey"   -d '{
    "model": "qwen1.5",
    "messages": [
      {
        "role": "user",
        "content": "What is triangle inequality?"
      },
      {
        "role": "assistant",
        "content":"The triangle inequality is a fundamental geometric concept that states that the sum of the lengths of any two sides of a triangle is always greater than or equal to the length of the third side. In other words, in a triangle, if you have two sides a and b, and a third side c, the following inequality must hold:\n\na + b > c\nb + c > a\nc + a > b\n\nThis inequality ensures that the three sides create a valid geometric triangle, as it prevents the formation of a \"triangle\" where the third side is shorter than the combined length of the other two. It is a simple yet essential principle in geometry, particularly in measuring distances and understanding the properties of triangles."
      },
      {
        "role": "system",
        "content": "Summarize the takeaway from the conversation. Do not add any introductory phrases."
      }
    ]
  }'

Expected behavior
xinference's openai compatible API should handle message histories consistently with the actual OpenAI API, even when system messages are not at the beginning of the message sequence.
Additional context
It would be greatly appreciated if the developers could look into improving the compatibility of xinference's openai compatible API to better align with the official OpenAI API behavior.
Thank you for your attention to this matter!

@mujin2 will fix this

take


Update supported VM list

please update the supported VM sizes list with M (v1) series. or is it not supported yet on Linux?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ccb5713-71bd-543c-7d6d-4caf2744e88e
Version Independent ID: 44b50d80-6b0c-6046-936a-b620d0ad5f5a
Content: Azure support for generation 2 VMs - Azure Linux Virtual Machines
Content Source: articles/virtual-machines/linux/generation-2.md
Service: virtual-machines-linux
GitHub Login: @ju-shim
Microsoft Alias: jushiman

@meieda
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@ju-shim
Can you please check and add your comments on this doc update request as applicable.

We are currently cleaning up old issues and closing out items that are greater than 90 days old. If an issue is still present, please open a new feedback item on the document so we can prioritize correctly.
#please-close


Support disk metric configuration

Currently sda is monitored by default https://github.com/aheart/hearth/blob/21e821768d5acceb746ca8e8e04955723fe34122/src/metrics/disk.rs#L17

Done in #32


Arm(R) Ethos(TM)-U NPU Pooling operators support

This commit adds support for the max and average pooling primitive operators for the Arm(R) Ethos(TM)-U NPU.

Thanks for the PR. @NicolaLancellotti
To get this PR moved forward, I would suggest adding tests for TypeReporter errors and lets follow up tests for other ICHECKs in P10 here : #9410.
@Mousius does that sound good ?

One thing I'd suggest we don't move to another PR is adding tests for the other activation functions, as I think that's core to the functionality introduced here. Though given this has a green tick, if it's a relatively immediate follow up then that'd actually be fine.

Thanks for the PR. @NicolaLancellotti
To get this PR moved forward, I would suggest adding tests for TypeReporter errors and lets follow up tests for other ICHECKs in P10 here : #9410.
@Mousius does that sound good ?

One thing I'd suggest we don't move to another PR is adding tests for the other activation functions, as I think that's core to the functionality introduced here. Though given this has a green tick, if it's a relatively immediate follow up then that'd actually be fine.

As I mentioned in this comment, it is a bit unclear to me in what do you mean by testing other activation functions? Would you mind giving an example?

Could we add to the description that this includes a few minor rewording changes? This is just to be explicit to anyone scanning the commit history that this change doesn't solely add pooling.

Thanks @Mousius @NicolaLancellotti @lhutton1 @mbaret  @ekalda


feat: implement filtering todos by status with nav tabs

Type
enhancement, bug_fix

Description

Implemented navigation tabs in the todo app for filtering todos by their status ('All', 'In Progress', 'Completed').
Enhanced the todo list UI to support dynamic filtering based on the selected tab.
Updated the test HTML structure to reflect the latest UI changes, including the addition of navigation tabs and restructuring of the input and 'Toggle All' button into a footer section.
Fixed the UI bug where todos were not re-rendering after a status filter was applied.

Changes walkthrough
Relevant filesEnhancement

todo.test.jsUpdate Test HTML Structure to Include Todo Status Filtering

tests/todo.test.js
Updated the HTML structure in the test setup to include navigation tabs for filtering todos by status.  Moved the input field and 'Toggle All' button into a new footer section.  Changed the 'Toggle All' button class to 'btn-success'.

+31/-19

todoListUI.jsImplement Todo Status Filtering and UI Enhancements

js/todoListUI.js
Added navigation tabs for filtering todos by status ('All', 'In Progress', 'Completed').  Implemented filtering logic in displayTodos to show todos based on the selected status.  Added an event listener for navigation tab clicks to trigger todo filtering.  Enhanced the UI to re-render todos upon clicking a nav tab and querying for filter status.

+75/-42

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

:tada: This PR is included in version 2.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Force use of warehouse class

Copy of #497. But not from a fork to make the CI work.

Closing this - we will consider redesigns for next major version.


Handle nested parens

Some urls (for example Graphite) have some nested parens in the parameters. An url with nested parens would miss the last closing paren and the linkified result would look something like this:
http://example.com/render?target=summarize(deriviative(app.numUsers),%221min%22)&title=New_Users_Per_Minute
I do realize that this fix will allow unbalanced parens. Is that a problem?

Example is acceptable, but i don't like implementation. It will ignore all intermetiate conditions between 2 scopen groups:
(foo)ignored---content(bar)

Aha! Didn't catch that. I'll work on another way of doing this. Thanks.

@iko, honestly, i'm not sure this task can be solved without side effects like reDoS.
How critical is it to detect such links properly?

How about limiting the nesting? Twitter-text for example has a hard limit of one level. I haven't had the time to look into this yet, though.
Detecting urls with nested parens is not the most critical feature at the moment, but eventually we'll probably need it to work.

Idea looks nice.

Hi guys, another example of complex/long url that the parser is unable to grok:
 http://sv-t-vnl-forge-metrics:5601/?#/dashboard/Logs-Marmotte?_a=(filters:!(),panels:!((col:1,columns:!(message,host,tags),id:Marmotte-logs,row:1,size_x:12,size_y:8,sort:!('@timestamp',asc),type:search)),query:(query_string:(analyze_wildcard:!t,query:'*')),title:'Logs%20Marmotte')&_g=(refreshInterval:(display:'10%20seconds',pause:!f,section:1,value:10000),time:(from:now-15m,mode:quick,to:now))

FYI, this URL is one generated by the "share" link of Kibana 4.

I summarized all in #23 for better tracking. May be worth to close PR if no updates expected soon.


[Provisioning Devices] Provision over WiFi - Join Soft AP

Need to implement joining a SoftAP on the controller side as part of CHIP provisioning

This should have a "provisioning" label instead of "rendezvous" label. For some reason I can't edit.

dupe with #1830. Closing.


When pushing menu button between routes I get a blank screen

Flow of actions:

Page 1 -> Page 2
Press Menu button
Data gets queried, render function gets called, but blank screen is there. It patches the dom but doesn't render.

If I hit the menu button again, it goes back to the previous page.

It seems like it could be trying to patch the DOM but for some reason isn't updating. Any ideas what might be going on?

if I pop the last document on the stack on a menu button push it seems to fix the issue.
componentDidMount() {
        console.log("on did mount");

        var myObj = this;
        var runWithData = function(){
          myObj.loadData().then((response) => {
            myObj.setState({
              data:response.data,
              props:props,
              passedProps:passedProps,
              loading: false
            })
          });
        }

        let currentDocument = this._rootNode.ownerDocument;
				this.menuButtonPressStream = TVDML.subscribe('menu-button-press');
				this.menuButtonPressStream
					.pipe(isMenuButtonPressNavigatedTo(currentDocument))
					.pipe(isNavigated => {
            if(isNavigated){
              console.log("clearin doc");
              navigationDocument.popDocument();
            }
            return false;
          });
        runWithData();
      },

I apparently am loading multiple documents to the document stack. I will investigate. I think this is probably just a user error.

Interesting case. Can you show how you handling routes? I don't think that popping documents manually is a good idea but I need more information.

Sure, I will try to get a small sample repo and link it here as an example.

That would be great 👍

If you want to jump on a screen share I can show you immediately

Sorry. I'm currently not at home

No worries, I will redact what I need and get it. I might be reading the doc / mis-understanding something as well.

Thanks a lot 👍

take a look here. I can almost replicate it.
https://github.com/spunkedy/test-tvdml
On first load there is 2 documents on the navigation document.
On the 2nd click through it doesn't load but it also adds the document to the stack and shows 3 but an empty screen.
I think I am just missing something.

Thank you for providing code example. The problem is here. You have overwritten pipeline's payload that contains not only params but also current document and some other data that is used during rendering.
The fix is simple:
return TVDML
    .createPipeline()
    .pipe(TVDML.render(({navigation: {passedProps}}) => TVDML.createComponent({
        ...
    })));

Or even
return TVDML
    .createPipeline()
    .pipe(TVDML.render(TVDML.createComponent({
        getInitialState() {
            console.log('state', this.props) // this.props contains pipeline data.

            return {
                active: null,
                loading: true,
            };
        },
        ...
    })));

I hope that will solve your problem ;)

I think I should add more information into readme about rendering.

That worked. I think I just don't fully understand the rendering side or why that fixed it.
I am seeing some flickering once rendering. Not sure why. I will see if I can capture a vid of it.

Let me try to explain in a few words.
When you handle new route it creates empty document that is supposed to "lock" place in navigationDocument for upcoming renders.
TVDML.render() create document based on markup that was passed and push it to navigationDocument. New document doesn't know anything about routes or other documents. That is what happened in your case.
But if you pass payload with document property to TVDML.render() it will update that document with new markup.
I hope that will clarify at least something :)

Added additional info to README.md in https://github.com/a-ignatov-parc/tvdml/pull/11/commits/7ce143a06db40d8a0a09020164a8be4ffd6d2796 to clarify this behaviour.


'--rm' arbitrary option to 'docker run' is ignored

I'm trying to pass an arbitrary rm option to docker run command via Marathon's API. The expected behavior would be to delete the container when the Marathon's APP is removed. However, it looks like this one specific parameter is ignored. When I delete Marathon's APP the container is stopped but it's not deleted (docker ps -a still shows the instance which is in Exited state). This is the body of a POST request to create an instance:
{
  "id": "plugin-test",
  "mem": 1024,
  "instances": 1,
  "args": [
      "bash",
      "-c",
      "sleep 3600"
  ],
  "container": {
    "type": "DOCKER",
    "docker": {
      "image": "ubuntu",
      "network": "BRIDGE",
      "privileged": true,
      "parameters": [
        { "key": "label", "value": "mylabel1" },
        { "key": "rm", "value": "true" },
        { "key": "volume-driver", "value": "rbd"},
        { "key": "volume", "value": "foo:/mnt/foo" }
      ]
    }
  }
}

The problem I have is that I want the instance to be removed entirely so that the Docker volume plugin I use can automatically cleanup the created RBD images. You can see that apart from rm option I also pass label, volume-driver and volume which are parsed correctly (I can see that the label was set and that the volume plugin was triggered as expected).
Tested with Docker 1.9.1 and Marathon 0.11.1.

Hi Mateusz,
I did some investigation and verified that the --rm=true parameter is correctly passed to the docker run invocation performed by Mesos (to test this, try starting a Marathon app with the configuration in your post above and then reading the Mesos task's stdout. You'll see the --rm=false flag in there.
However, I think I see the problem - by my reading of the Docker documentation, you should actually specify --rm=false if you want the container cleaned up on exit!
Relevant docs here: https://docs.docker.com/engine/reference/run/#clean-up-rm

Than you for the investigation!
'rm' parameter has to be passed to 'true'. I verified this earlier with the Docker command (bypassing Marathon/Mesos):
docker run -d --rm="true" --volume-driver=rbd --volume foo@1024:/mnt/foo ubuntu bash -c "sleep 3600"

Then when I type docker stop <container_id>, I've got the following output from Docker:
INFO[1826] POST /v1.21/containers/5b0466c98605/stop?t=0
INFO[1826] Container 5b0466c98605474bc8dd49d73bbc21333e884adb72d6e34e7f4779eb6168461d failed to exit within 0 seconds of SIGTERM - using the force
INFO[1826] POST /v1.21/containers/5b0466c98605474bc8dd49d73bbc21333e884adb72d6e34e7f4779eb6168461d/wait
INFO[1827] GET /v1.21/containers/5b0466c98605474bc8dd49d73bbc21333e884adb72d6e34e7f4779eb6168461d/json
INFO[1827] DELETE /v1.21/containers/5b0466c98605474bc8dd49d73bbc21333e884adb72d
6e34e7f4779eb6168461d?v=1

However, when I remove Marathon's APP, I get this:
INFO[1740] POST /v1.21/containers/mesos-2e68ce62-aac4-4966-bab1-70e1a7343221-S0.49af3498-fadb-4dad-a25a-edf93b69467b/stop?t=0
INFO[1740] Container dcdd582e63d03e26cf86a2039541950eca3724f346a0c12ac0984fb3adf32915 failed to exit within 0 seconds of SIGTERM - using the force
INFO[1741] GET /v1.21/containers/mesos-2e68ce62-aac4-4966-bab1-70e1a7343221-S0.49af3498-fadb-4dad-a25a-edf93b69467b/json

Note that there is no DELETE command passed to Docker when I simply remove Marathon's APP.

Mesos holds a stderr and stdout file in the sandbox for each task, so if your task is running you can simply read from there. Relevant docs fragment here.
Alternatively you can use the Mesos UI by identifying the task in question from its ID and clicking through to the task details, where there is a link to stderr and stdout.
The Mesos CLI can also display logs.

From the Docker docs:
--rm=false: Automatically remove the container when it exits (incompatible with -d)
(Note Docker tasks run by Marathon will be run using -d)

I ran your application with two of the parameters removed:
{   "id": "plugin-test",   "mem": 1024,   "instances": 1,   "args": [       "bash",       "-c",       "sleep 3600"   ],   "container": {     "type": "DOCKER",     "docker": {       "image": "ubuntu",       "network": "BRIDGE",       "privileged": true,       "parameters": [         { "key": "label", "value": "mylabel1" },         { "key": "rm", "value": "true" }       ]     }   } }
Then I removed it with a call to DELETE /v2/apps//plugin-test
Here's the mesos stdout
--container="mesos-20150707-153709-201330860-5050-12052-S0.4ea84576-a911-46f4-a110-973b8237cfb0" --docker="docker" --help="false" --initialize_driver_logging="true" --logbufsecs="0" --logging_level="INFO" --mapped_directory="/mnt/mesos/sandbox" --quiet="false" --sandbox_directory="/hdd/mesos/slave/slaves/20150707-153709-201330860-5050-12052-S0/frameworks/20141119-101031-201330860-5050-3757-0000/executors/plugin-test.ad6ff1da-942a-11e5-a4cb-c2b5850efd6e/runs/4ea84576-a911-46f4-a110-973b8237cfb0" --stop_timeout="0ns"
--container="mesos-20150707-153709-201330860-5050-12052-S0.4ea84576-a911-46f4-a110-973b8237cfb0" --docker="docker" --help="false" --initialize_driver_logging="true" --logbufsecs="0" --logging_level="INFO" --mapped_directory="/mnt/mesos/sandbox" --quiet="false" --sandbox_directory="/hdd/mesos/slave/slaves/20150707-153709-201330860-5050-12052-S0/frameworks/20141119-101031-201330860-5050-3757-0000/executors/plugin-test.ad6ff1da-942a-11e5-a4cb-c2b5850efd6e/runs/4ea84576-a911-46f4-a110-973b8237cfb0" --stop_timeout="0ns"
Registered docker executor on mesos.slave
Starting task plugin-test.ad6ff1da-942a-11e5-a4cb-c2b5850efd6e
Killing docker task
Shutting down

Here's the mesos stderr
I1126 10:44:33.257361 35884 logging.cpp:177] Logging to STDERR
I1126 10:44:33.259219 35884 process.cpp:973] libprocess is initialized on <IP_ADDRESS>:34677 for 40 cpus
I1126 10:44:33.260352 35884 exec.cpp:132] Version: 0.23.0
I1126 10:44:33.262181 35904 exec.cpp:182] Executor started at: executor(1)@<IP_ADDRESS>:34677 with pid 35884
I1126 10:44:33.264719 35917 exec.cpp:206] Executor registered on slave 20150707-153709-201330860-5050-12052-S0
I1126 10:44:33.266530 35917 exec.cpp:218] Executor::registered took 242402ns
I1126 10:44:33.266752 35917 exec.cpp:293] Executor asked to run task 'plugin-test.ad6ff1da-942a-11e5-a4cb-c2b5850efd6e'
I1126 10:44:33.266875 35917 exec.cpp:302] Executor::launchTask took 88001ns
I1126 10:44:33.267081 35911 docker.cpp:513] Running docker run --privileged -c 1024 -m<PHONE_NUMBER> -e MARATHON_APP_VERSION=2015-11-26T10:44:31.721Z -e HOST=mesos.slave -e MARATHON_APP_DOCKER_IMAGE=ubuntu -e MESOS_TASK_ID=plugin-test.ad6ff1da-942a-11e5-a4cb-c2b5850efd6e -e PORT=31812 -e PORTS=31812 -e PORT_10030=31812 -e MARATHON_APP_ID=/plugin-test -e PORT0=31812 -e MESOS_SANDBOX=/mnt/mesos/sandbox -v /hdd/mesos/slave/slaves/20150707-153709-201330860-5050-12052-S0/frameworks/20141119-101031-201330860-5050-3757-0000/executors/plugin-test.ad6ff1da-942a-11e5-a4cb-c2b5850efd6e/runs/4ea84576-a911-46f4-a110-973b8237cfb0:/mnt/mesos/sandbox --net bridge --label=mylabel1 --rm=true --name mesos-20150707-153709-201330860-5050-12052-S0.4ea84576-a911-46f4-a110-973b8237cfb0 ubuntu bash -c sleep 3600
I1126 10:44:33.268223 35911 docker.cpp:669] Running docker inspect mesos-20150707-153709-201330860-5050-12052-S0.4ea84576-a911-46f4-a110-973b8237cfb0
I1126 10:44:33.368973 35923 docker.cpp:771] Retrying inspect since container not yet started. cmd: 'docker inspect mesos-20150707-153709-201330860-5050-12052-S0.4ea84576-a911-46f4-a110-973b8237cfb0', interval: 500ms
I1126 10:44:33.869583 35925 docker.cpp:669] Running docker inspect mesos-20150707-153709-201330860-5050-12052-S0.4ea84576-a911-46f4-a110-973b8237cfb0
I1126 10:44:33.973841 35915 exec.cpp:515] Executor sending status update TASK_RUNNING (UUID: d578760a-8623-4659-af68-007de8d0a1f3) for task plugin-test.ad6ff1da-942a-11e5-a4cb-c2b5850efd6e of framework 20141119-101031-201330860-5050-3757-0000
I1126 10:44:33.986701 35918 exec.cpp:339] Executor received status update acknowledgement d578760a-8623-4659-af68-007de8d0a1f3 for task plugin-test.ad6ff1da-942a-11e5-a4cb-c2b5850efd6e of framework 20141119-101031-201330860-5050-3757-0000
I1126 10:53:24.167608 35909 exec.cpp:313] Executor asked to kill task 'plugin-test.ad6ff1da-942a-11e5-a4cb-c2b5850efd6e'
I1126 10:53:24.167675 35909 exec.cpp:322] Executor::killTask took 24289ns
I1126 10:53:24.167780 35893 docker.cpp:143] 'docker run --privileged -c 1024 -m<PHONE_NUMBER> -e MARATHON_APP_VERSION=2015-11-26T10:44:31.721Z -e HOST=mesos.slave -e MARATHON_APP_DOCKER_IMAGE=ubuntu -e MESOS_TASK_ID=plugin-test.ad6ff1da-942a-11e5-a4cb-c2b5850efd6e -e PORT=31812 -e PORTS=31812 -e PORT_10030=31812 -e MARATHON_APP_ID=/plugin-test -e PORT0=31812 -e MESOS_SANDBOX=/mnt/mesos/sandbox -v /hdd/mesos/slave/slaves/20150707-153709-201330860-5050-12052-S0/frameworks/20141119-101031-201330860-5050-3757-0000/executors/plugin-test.ad6ff1da-942a-11e5-a4cb-c2b5850efd6e/runs/4ea84576-a911-46f4-a110-973b8237cfb0:/mnt/mesos/sandbox --net bridge --label=mylabel1 --rm=true --name mesos-20150707-153709-201330860-5050-12052-S0.4ea84576-a911-46f4-a110-973b8237cfb0 ubuntu bash -c sleep 3600' is being discarded
I1126 10:53:24.227412 35893 docker.cpp:584] Running docker stop -t 0 mesos-20150707-153709-201330860-5050-12052-S0.4ea84576-a911-46f4-a110-973b8237cfb0
I1126 10:53:24.304169 35911 exec.cpp:515] Executor sending status update TASK_KILLED (UUID: b81816e9-e0a4-4b9f-8147-40c26dadd36c) for task plugin-test.ad6ff1da-942a-11e5-a4cb-c2b5850efd6e of framework 20141119-101031-201330860-5050-3757-0000
I1126 10:53:24.478348 35885 exec.cpp:339] Executor received status update acknowledgement b81816e9-e0a4-4b9f-8147-40c26dadd36c for task plugin-test.ad6ff1da-942a-11e5-a4cb-c2b5850efd6e of framework 20141119-101031-201330860-5050-3757-0000

As the --rm=true is passed correctly, I'm of the opinion that this isn't a shortcoming in Marathon, but is either a Mesos issue to do with the way Docker containers are stopped, or a shortcoming in Docker in that --rm is not compatible with -d.

Just to clarify - its really a bug in mesos - in the docker executor implementation: https://issues.apache.org/jira/browse/MESOS-4279


#68 - Add code coverage report and badge.

This will make code coverage report using travis.
Add badge to README.md to make code coverage visible to all.
This PR is for issue #68

A new inspection was created.

The inspection completed: No new issues


Minor grammatical tweaks to README file

As I was reading our README I came across some grammatical mistakes and typos, so I've taken the liberty to fix whatever I could find so as to make the text more gramatically coherent/correct.
Little mistakes like these are bound to happen since none of us are native speakers, so I suppose the best we can do is help each other :)
I'm open to suggestions and questions regarding any of the changes, of course.

Can one of the admins verify this patch?

@cristofolini those are great suggestions.
It LGTM

ok to test

@cristofolini good improvements, it LGTM.
If you don't mind, we would appreciate a review on our site also (http://autonomiccs.com.br/website/ - https://github.com/Autonomiccs/autonomiccs-website/blob/master/index.html), thanks ;)

@rafaelweingartner That's a fair point. I've changed all contractions on the text to their normal forms.
@GabrielBrascher Will do!


Setting custom dir downloads to user home folder

If I set a custom dir in settings.gradle
git {
    dir './gradle-libs' // or just 'gradle-libs'
}

The build fails with:
Creating directories for /Users/me/.gradle/daemon/7.4.2/./gradle-libs/kafka-internal-schemas/.git failed
or
Creating directories for /Users/me/.gradle/daemon/7.4.2/gradle-libs/kafka-internal-schemas/.git failed
Solution:
git {
    dir "${System.getProperty("user.dir")}/gradle-libs"
}

Thanks for report, it is strange that dir 'gradle-libs' ends up under .gradle directory. I need to check what's going on.
I think it is a good idea to use absolute path anyway, you can also use "$rootDir/..." for paths relative to the project's root.


Update configuration_files.md - ambiguous snipe_high_prio_threshold description

Short Description:
Doc says:
snipe_high_prio_threshold - The threshold number corresponding with the catch dictionary. Any pokemon above this threshold will be caught. Other will be ignored
where in fact

over snipe_high_prio_threshold value and if snipe is true, bot just teleport to the target pokemeon
under snipe_high_prio_threshold value whatever snipe value, it just walk to the pokemon target

Fixes (provide links to github issues if you can):
MoveToMapPokemon behavior
related to issue #3736 (discussed with @k4n30)
update to https://github.com/PokemonGoF/PokemonGo-Bot/blame/dev/docs/configuration_files.md#L241

:+1:


feat(tekton): view pipelinerun visualization on click of pipelinerun

Resolves:
https://github.com/janus-idp/backstage-plugins/issues/408
Screenshots:

in the case of multiple clusters with the first cluster having no PLR and the second having few and I select PLR from the list view on cluster 2 then I see empty PLR viz as context is missing.

in the case of multiple clusters with the first cluster having no PLR and the second having few and I select PLR from the list view on cluster 2 then I see empty PLR viz as context is missing.

Fixed it ! Added Gif in the PR description

in dev mode am not able to click on PLR to see the PLR Viz


[Bug]: Left and right arrow keys on task hub don't work as expected

Steps to reproduce the bug
1. Go to the task hub /hub?list=tasks
2. On my standard screen I see 3 columns of tasks by 4 rows of tasks.
3. Now press the right arrow key.

Actual results:
The black squares representation at the top of the screen of what tasks I'm currently viewing only moves ahead by 4 squares (which matches the tasks I see on screen). i.e. I'm now viewing tasks 5-16. See the screenshot.

Expected results:
Tasks 13-24 are displayed.

The left arrow key has the same issue, it only moves by 4 tasks at a time.

Screenshot

Expected behavior
No response
Additional Screenshots
No response
Environment
Development (docker)
Sandbox Used
No response
Version
No response
Browser Used
No response

@mjy how was this expected to work? Move one column at a time or change all cards?

Initial intent was to page columns one at a time.  I think @LordFlashmeow commented on related behaviour too in another issue IIRC.  I'm pretty impartial to 1 colum vs 1 page, so if there are a couple more votes for this let's change it.

I don't have a strong preference either, but I'll just add that, although current behavior is to shift by the size of a column, it actually does that across rows (not column); in other words if there are 4 rows (so a column has length 4) and each row has 3 items then when you press the right arrow the top row shifts off and the first item in the second row shifts off (a total of 4 items, the length of a column, gets shifted off). So the red in the screenshot will shift away when you press the right arrow:

To me that makes it kind of difficult to track how far you need to look through the current cards to see all of the ones that are going to disappear the next time you press the right arrow. The rows vs. columns: number of each vs length of each is confusing to me, was it maybe intended to shift off an entire row for each arrow press?

Aha, now I understand what you mean. I think this started happening when we changed the direction of the flex grid from column to row, so that the alphabetical order of the cards starts from left to right. I think the "easiest" ways to fix this might be to move by row instead of column, or swap all the cards.


stream.on is not a function

How can i solve this?

stream.on('end', function () {
         ^

TypeError: stream.on is not a function

https://github.com/imagemin/imagemin/issues/164


Add a code in Matlab for "Hello world"

Please make sure you reference this Issue when you submit your PR


Add zindex foundation

@bhoppers2008 @joshwooding I've put Tooltip as an example of Popover, but I'm not clear on the difference between Popout and Flyover, and if I've used the correct example. Do you know when they're both used and the reasoning for both?


Build: run make-schema ant target in headless java process

Small change / great effect! rado.incrementBeers()...

I had to, it was pissing me off that the new processes was stealing focus when building jgroups :-)

Exactly what I was thinking, too!


Type narrowing rules are unsound

Spec issue https://github.com/ballerina-platform/ballerina-spec/issues/828

related to https://github.com/ballerina-platform/ballerina-lang/issues/30142


Add cursorTo & clearLine to streams

Using process.stdout.cursorTo and process.stdout.clearLine will error in Flow because those definitions are missing.
Error: src/db/seeds/utils/helpers.js:9
  9:   process.stdout.cursorTo(0)
                      ^^^^^^^^ property `cursorTo`. Property not found in
  9:   process.stdout.cursorTo(0)
       ^^^^^^^^^^^^^^ stream$Writable

Error: src/db/seeds/utils/helpers.js:9
  9:   process.stdout.cursorTo(0)
                      ^^^^^^^^ property `cursorTo`. Property not found in
  9:   process.stdout.cursorTo(0)
       ^^^^^^^^^^^^^^ tty$WriteStream

node/lib/readline.js
node/lib/tty.js
Error: src/db/seeds/utils/helpers.js:10
 10:   process.stdout.clearLine()
                      ^^^^^^^^^ property `clearLine`. Property not found in
 10:   process.stdout.clearLine()
       ^^^^^^^^^^^^^^ stream$Writable

Error: src/db/seeds/utils/helpers.js:10
 10:   process.stdout.clearLine()
                      ^^^^^^^^^ property `clearLine`. Property not found in
 10:   process.stdout.clearLine()
       ^^^^^^^^^^^^^^ tty$WriteStream

node/lib/readline.js
node/lib/tty.js
I'm not sure if I added them in the correct place, so please check and let me know.

Hey @nmote 	,
I guess then I should've linked to these docs instead, on the tty.WriteStream class (my bad):

writeStream.cursorTo(x, y)
writeStream.clearLine(dir)

There are for sure missing definitions for these two functions, I even found code on this repo itself using them when I was researching the issue after getting Flow errors on my project and before opening this PR:
https://github.com/facebook/flow/blob/41b0eab99cdc5199421f7cccad9e0c4950f8b2f9/packages/flow-dev-tools/src/test/RunQueue.js#L202-L208
https://github.com/facebook/flow/blob/41b0eab99cdc5199421f7cccad9e0c4950f8b2f9/packages/flow-dev-tools/src/record/recordRunner.js#L124-L126
Also note that:

The tty.WriteStream class is a subclass of net.Socket that represents the writable side of a TTY. In normal circumstances, process.stdout and process.stderr will be the only tty.WriteStream instances created for a Node.js process and there should be no reason to create additional instances.
Source

I believe this is the pull request that merged the documentation for these functions on the Node repo: https://github.com/nodejs/node/pull/22893
So I think this is still missing from Flow and should be addressed, but I can't re-open this issue apparently. Let me know what you think!


Expose Rate Limit Headers

Exposes the rate limit header responses so that consumers of the API can proactively tune their usage.
@reviewbybees

I guess you far away from good gh integration, so soon you will get https://github.com/kohsuke/github-api/issues/303

@kohsuke ping


support new Python "soft keywords": match, case and _

Python 3.10 introduces pattern-matching blocks, in which the match, case and _ "soft keywords" are considered keywords only in specific parts of the syntax. See the docs for more details.
However, the list of Python keywords in lexers/python.py doesn't include these, nor does the Python lexer appear to have any other way of supporting these keywords.

@taleinat doesn't need to be told, but others might: here is how IDLE chose to support the soft keywords: https://github.com/python/cpython/pull/25851/
For coverage.py's HTML report, I used the ast module to find the start of match/case statements to help.


Take better advantage of cabal nix-style builds

If I figured out a few issues, I could switch to cabal's nix-style builds, and it would have a few advantages.  The basic idea is:

Specify the environment (e.g., available packages) where client code should run, hopefully in a cabal project file?
Let cabal v2-install write a GHC environment file on build that describes the exact set of build artifacts that implement that environment.  Pass this environment file to GHCJS when building client code.

The more formal specification of the environment (instead of "whatever packages happen to be installed right now") is its own reward.  But I also expect this to make builds much faster and more reproducible.  Currently, I have a tendency to sometimes hand-pick only some packages to rebuild, to save time in the development cycle, and cabal v2-install should make that obsolete.
Challenge: cabal v2-install really doesn't seem to like packages just sitting in a subdirectory.  It wants them to come from some repository.  I'll have to workaround this somehow.

I'm probably misunderstanding something, but superficially using cabal.project file should allow picking up a local version of a package without having it be published in any way.

That sounds approximately right, but I suspect there are some subtleties in getting it to work.  I think this works for building the server.  I still don't know how one gets from having a cabal.project file to building a GHC environment file that can be passed to GHCJS to build submitted code with GHCJS.  I really don't want to have to create a cabal fail every time I build student code (though, with the current setup, I suppose that's not so hard, since student code is built in a temporary directory anyway)

work-in-progress https://github.com/google/codeworld/pull/1523

I think there's some confusion here.  By "cabal nix-style builds" we just mean cabal v2-* rather than cabal v1-*.  There's no actual nix involved in this issue.


:bricks: Feature: Add the go-ethereum evm blocktest within tox

Feature Description
We have the occasional case where we may generate an invalid test fixture. Currently test fixtures can be checked for validity using the:
evm blocktest <path_to_fixture.json>

command from go-ethereum's evm.
To check the validity of all tests after generation, we could add an additional step during tox, that runs the above command on every generated fixture.

This will actually execute all the tests against geth, which might be overkill for our usual test.yaml workflow.
We could perhaps:

Add a new tox environment that doesn't get ran by default, like testenv:tests-develop added in #302.
Execute this test environment in a dedicated ci workflow. I'm not sure what this would look like, something executes daily on main and all branches from open PRs could be nice?

This sounds like a great option 💯


The statefulset controller cannot get the domain name for a single pod through the headless service.

Rancher versions: 2.0 master 07/18
Steps to Reproduce:

Go to the Workloads page and create a statefulset app like nginx
Click launch and check the serviceName of the generate YAML, the serviceName is empty and it should contains the correct service name
A single pod cannot get a domain name

Expected Results: Add serviceName to the deployed statefulset YAML.

Useful
Info

Versions
Rancher v2.0.6 UI: v2.0.61

Access
local admin

Route
containers.index

Version - 2.1 master 9/4
Verified fixed


New admin check command structure implementation

This is part of https://github.com/apache/accumulo/issues/4687
Changes:

Added new admin check command
admin check list prints the checks that can be run along with their descriptions and dependencies
admin check run runs all the checks or a specified list of checks (explicitly provide each check, provide a regex of the checks to run, or just run all if no further args are provided). The dependencies are run first and if a checks dependency fails, the check is skipped
Current impl of admin check run does not do any actual work besides printing that the check is running (to ensure correct run order) and returning an OK status
New IT AdminCheckIT

This IT includes a verion of the Checks where no work is actually done (right now, this is equivalent to the actual implementation). This is done so correct run order, correct checks run, etc. can be
verified without actually running the checks which may take a long time. More tests can be added later to test the actual check functionality when that is implemented.

No existing functionality was changed

Questions:

Are new classes and packages in suitable locations?
Is the way I went about implementing the dummy checks in AdminCheckIT okay? Mostly concerned if changing the real static CHECK_RUNNERS field is okay (changes it during the test but asserts that it is reset after the test completes).

Some example outputs and a sketch of the current dependency tree as support:
Dependency tree sketch:

        SYSTEM_CONFIG
              |
              V
        ROOT_METADATA
              |
              V
          ROOT_TABLE
         /          \
   METADATA_TABLE  SYSTEM_FILES
         |
         V
     USER_FILES

Sample outputs:
$ accumulo admin check list

Check Name           | Description                                                                      | Depends on
------------------------------------------------------------------------------------------------------------------------
SYSTEM_CONFIG        | Validate the system config stored in ZooKeeper                                   |
ROOT_METADATA        | Checks integrity of the root tablet metadata stored in ZooKeeper                 | SYSTEM_CONFIG
ROOT_TABLE           | Scans all the tablet metadata stored in the root table and checks integrity      | ROOT_METADATA
METADATA_TABLE       | Scans all the tablet metadata stored in the metadata table and checks integrity  | ROOT_TABLE
SYSTEM_FILES         | Checks that files in system tablet metadata exist in DFS                         | ROOT_TABLE
USER_FILES           | Checks that files in user tablet metadata exist in DFS                           | METADATA_TABLE
------------------------------------------------------------------------------------------------------------------------

$ accumulo admin check run

Running check SYSTEM_CONFIG
Check SYSTEM_CONFIG completed with status OK
Running check ROOT_METADATA
Check ROOT_METADATA completed with status OK
Running check ROOT_TABLE
Check ROOT_TABLE completed with status OK
Running check METADATA_TABLE
Check METADATA_TABLE completed with status OK
Running check SYSTEM_FILES
Check SYSTEM_FILES completed with status OK
Running check USER_FILES
Check USER_FILES completed with status OK

Check Name           | Status
--------------------------------------------------
SYSTEM_CONFIG        | OK
ROOT_METADATA        | OK
ROOT_TABLE           | OK
METADATA_TABLE       | OK
SYSTEM_FILES         | OK
USER_FILES           | OK
--------------------------------------------------

$ accumulo admin check run -p ".*table"

Running check SYSTEM_CONFIG
Check SYSTEM_CONFIG completed with status OK
Running check ROOT_METADATA
Check ROOT_METADATA completed with status OK
Running check ROOT_TABLE
Check ROOT_TABLE completed with status OK
Running check METADATA_TABLE
Check METADATA_TABLE completed with status OK

Check Name           | Status
--------------------------------------------------
SYSTEM_CONFIG        | OK
ROOT_METADATA        | OK
ROOT_TABLE           | OK
METADATA_TABLE       | OK
--------------------------------------------------

In this example, I made ROOT_TABLE fail when it was run and attempted to run all the checks
$ accumulo admin check run

Running check SYSTEM_CONFIG
Check SYSTEM_CONFIG completed with status OK
Running check ROOT_METADATA
Check ROOT_METADATA completed with status OK
Running check ROOT_TABLE
Check ROOT_TABLE completed with status FAILED

Check Name           | Status
--------------------------------------------------
SYSTEM_CONFIG        | OK
ROOT_METADATA        | OK
ROOT_TABLE           | FAILED
METADATA_TABLE       | SKIPPED_DEPENDENCY_FAILED
SYSTEM_FILES         | SKIPPED_DEPENDENCY_FAILED
USER_FILES           | SKIPPED_DEPENDENCY_FAILED
--------------------------------------------------

Closing this to be replaced by https://github.com/apache/accumulo/pull/4807.
As suggested by @ctubbsii, making these changes target main


error message: externals -> external

Following the error advice will give you follow-up error
Error: Unexpected key 'externals' found, expected one of: acorn, banner, cache, context, dest, entry, exports, external, ...
So, I guess it should say external instead

Thank you!


Build fails: ‘Dart_NewString’ was not declared in this scope'

~/work/dart-console> export DART_SDK=~/work/dart-sdk
~/work/dart-console> ./build.sh
g++ -O2 -DDART_SHARED_LIB -I/home/tom/work/dart-sdk/include -rdynamic -fPIC -shared src/dart_sandbox.cc -o lib/libdart_sandbox.so
In file included from src/dart_sandbox.cc:7:0:
src/dart_util.h: In function ‘void _Throw(Dart_Handle, const char*)’:
src/dart_util.h:38:53: error: ‘Dart_NewString’ was not declared in this scope
Dart_Handle messageHandle = Dart_NewString(message);
^
src/dart_sandbox.cc: In function ‘void NewLibrary(Dart_NativeArguments)’:
src/dart_sandbox.cc:18:89: error: too few arguments to function ‘_Dart_Handle* Dart_LoadLibrary(Dart_Handle, Dart_Handle, Dart_Handle, intptr_t, intptr_t)’
Dart_Handle lib = Dart_NewPersistentHandle(CheckDartError(Dart_LoadLibrary(url, source)));
^
src/dart_util.h:35:58: note: in definition of macro ‘CheckDartError’
#define CheckDartError(handle) _CheckDartError(_library, handle)
^
In file included from src/dart_util.h:10:0,
from src/dart_sandbox.cc:7:
/home/tom/work/dart-sdk/include/dart_api.h:2999:25: note: declared here
DART_EXPORT Dart_Handle Dart_LoadLibrary(Dart_Handle url,
^
In file included from src/dart_sandbox.cc:7:0:
src/dart_sandbox.cc: In function ‘void Declare(Dart_NativeArguments)’:
src/dart_sandbox.cc:26:58: error: too few arguments to function ‘_Dart_Handle* Dart_LoadSource(Dart_Handle, Dart_Handle, Dart_Handle, Dart_Handle, intptr_t, intptr_t)’
CheckDartError(Dart_LoadSource(libraryHandle, url, text));
^
src/dart_util.h:35:58: note: in definition of macro ‘CheckDartError’
#define CheckDartError(handle) _CheckDartError(_library, handle)
^
In file included from src/dart_util.h:10:0,
from src/dart_sandbox.cc:7:
/home/tom/work/dart-sdk/include/dart_api.h:3058:25: note: declared here
DART_EXPORT Dart_Handle Dart_LoadSource(Dart_Handle library,
^
In file included from src/dart_sandbox.cc:7:0:
src/dart_sandbox.cc: In function ‘void Import(Dart_NativeArguments)’:
src/dart_sandbox.cc:44:70: error: too few arguments to function ‘_Dart_Handle* Dart_LoadLibrary(Dart_Handle, Dart_Handle, Dart_Handle, intptr_t, intptr_t)’
importHandle = CheckDartError(Dart_LoadLibrary(importName, source));
^
src/dart_util.h:35:58: note: in definition of macro ‘CheckDartError’
#define CheckDartError(handle) _CheckDartError(_library, handle)
^
In file included from src/dart_util.h:10:0,
from src/dart_sandbox.cc:7:
/home/tom/work/dart-sdk/include/dart_api.h:2999:25: note: declared here
DART_EXPORT Dart_Handle Dart_LoadLibrary(Dart_Handle url,
^
In file included from src/dart_sandbox.cc:7:0:
src/dart_sandbox.cc: In function ‘void InitEnvMap(Dart_NativeArguments)’:
src/dart_sandbox.cc:54:70: error: ‘Dart_NewString’ was not declared in this scope
CheckDartError(Dart_Invoke(libraryHandle, Dart_NewString("_seedEnv"), 1, &map));
^
src/dart_util.h:35:58: note: in definition of macro ‘CheckDartError’
#define CheckDartError(handle) _CheckDartError(_library, handle)
^
src/dart_sandbox.cc: In function ‘_Dart_Handle* dart_sandbox_Init(Dart_Handle)’:
src/dart_util.h:65:81: error: invalid conversion from ‘void (* ()(Dart_Handle, int))(Dart_NativeArguments) {aka void ( ()(_Dart_Handle, int))(_Dart_NativeArguments*)}’ to ‘Dart_NativeEntryResolver {aka void (* ()(_Dart_Handle, int, bool*))(_Dart_NativeArguments*)}’ [-fpermissive]
Dart_Handle result_code = Dart_SetNativeResolver(parent_library, ResolveName);
^
src/dart_sandbox.cc:58:1: note: in expansion of macro ‘DART_LIBRARY’
DART_LIBRARY(sandbox)
^
src/dart_util.h:65:81: error: too few arguments to function ‘_Dart_Handle* Dart_SetNativeResolver(Dart_Handle, Dart_NativeEntryResolver, Dart_NativeEntrySymbol)’
Dart_Handle result_code = Dart_SetNativeResolver(parent_library, ResolveName);
^
src/dart_sandbox.cc:58:1: note: in expansion of macro ‘DART_LIBRARY’
DART_LIBRARY(sandbox)
^
In file included from src/dart_util.h:10:0,
from src/dart_sandbox.cc:7:
/home/tom/work/dart-sdk/include/dart_api.h:2701:1: note: declared here
Dart_SetNativeResolver(Dart_Handle library,
^
In file included from /home/tom/work/dart-sdk/include/dart_api.h:67:0,
from src/dart_util.h:10,
from src/dart_sandbox.cc:7:
src/dart_sandbox.cc: In function ‘void (* ResolveName(Dart_Handle, int))(Dart_NativeArguments)’:
src/dart_util.h:71:31: error: ‘Dart_IsString8’ was not declared in this scope
assert(Dart_IsString8(name));
^
src/dart_sandbox.cc:58:1: note: in expansion of macro ‘DART_LIBRARY’
DART_LIBRARY(sandbox)

Similar error in build.sh:
./build.sh
g++ -O2 -DDART_SHARED_LIB -I/usr/local/opt/dart/libexec/include -rdynamic -fPIC -dynamiclib -undefined suppress -flat_namespace src/dart_sandbox.cc -o lib/libdart_sandbox.dylib
In file included from src/dart_sandbox.cc:7:
src/dart_util.h:38:31: error: use of undeclared identifier 'Dart_NewString'
Dart_Handle messageHandle = Dart_NewString(message);
^
src/dart_util.h:39:55: error: use of undeclared identifier 'Dart_NewString'
Dart_Handle exceptionClass = Dart_GetClass(library, Dart_NewString("Exception"));
^
src/dart_sandbox.cc:18:61: error: use of undeclared identifier 'Dart_LoadLibrary'
Dart_Handle lib = Dart_NewPersistentHandle(CheckDartError(Dart_LoadLibrary(url, source)));
^
src/dart_sandbox.cc:26:18: error: use of undeclared identifier 'Dart_LoadSource'
CheckDartError(Dart_LoadSource(libraryHandle, url, text));
^
src/dart_sandbox.cc:44:35: error: use of undeclared identifier 'Dart_LoadLibrary'
importHandle = CheckDartError(Dart_LoadLibrary(importName, source));
^
src/dart_sandbox.cc:46:18: error: use of undeclared identifier 'Dart_LibraryImportLibrary'
CheckDartError(Dart_LibraryImportLibrary(libraryHandle, importHandle, Dart_Null()));
^
src/dart_sandbox.cc:54:45: error: use of undeclared identifier 'Dart_NewString'
CheckDartError(Dart_Invoke(libraryHandle, Dart_NewString("_seedEnv"), 1, &map));
^
src/dart_sandbox.cc:58:1: error: no matching function for call to 'Dart_SetNativeResolver'
DART_LIBRARY(sandbox)
^~~~~~~~~~~~~~~~~~~~~
src/dart_util.h:65:31: note: expanded from macro 'DART_LIBRARY'
Dart_Handle result_code = Dart_SetNativeResolver(parent_library, ResolveName);
^~~~~~~~~~~~~~~~~~~~~~
/usr/local/opt/dart/libexec/include/dart_api.h:2772:1: note: candidate function not viable: requires 3 arguments, but 2 were provided
Dart_SetNativeResolver(Dart_Handle library,
^
src/dart_sandbox.cc:58:1: error: use of undeclared identifier 'Dart_IsString8'; did you mean 'Dart_IsString'?
DART_LIBRARY(sandbox)
^
src/dart_util.h:71:12: note: expanded from macro 'DART_LIBRARY'
assert(Dart_IsString8(name));
^
/usr/local/opt/dart/libexec/include/dart_api.h:1433:18: note: 'Dart_IsString' declared here
DART_EXPORT bool Dart_IsString(Dart_Handle object);
^
9 errors generated.


Semantic versioning?

Anticipating breaking changes, I have pinned the maestral requirement to survey < 3.0 to prevent any issues. Though I probably should have checked with you first, because I noticed too late that there are already breaking changes in 2.2.0.
Are you planning to use semantic versioning? If not, this is fine as well. I will just have to be a lot more cautious in specifying my dependencies...

I'll be honest and say that not bumping to 3.0.0 was a mistake on my end since there were indeed breaking changes introduced. I plan on moving forward with properly following semantic versioning from now on. A thousand apologies for any inconvenience!

Closed a bit early, but versions should be properly set now.

Thanks for the prompt response! And yeah, I released v1.3.0 a bit too early. My hand was forced by another breaking change to the Python Dropbox SDK which came with a minor release. Though they ended up yanking that release from PyPI as well after I complained...
The lesson learned for me really is to be conservative regarding dependency versions.


Added batch_normalization in the numpy backend.

Summary
Added the op batch_normalization in the numpy backend.
Related Issues
PR Overview

Added the function in the numpy backend
Added the numpy implementation in the docs
Added tests.

[ ] This PR requires new unit tests [y/n] (make sure tests are included)
[ ] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
[x] This PR is backwards compatible [y/n]
[ ] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

@taehoonlee ping. PR ready for review.


get current branch name

currently paint.sh assumes a branch name of master. if that is not the current branch name, script fails with a somewhat confusing message about an invalid refspec.
this patch #WorksForMe

Still fails if the remote origin is not pushable; as it is in my case.
Maybe better use:
# Get remote name
a="$(git rev-parse --abbrev-ref HEAD@{u})"
remote="${a%%/*}"
remote="${remote:-origin}"
branch="${a#*/}"
branch="${branch:-master}"
git push "$remote" HEAD:"$branch"

Untested, but should do. Using something similar in https://github.com/benbe/git-prompt

looks like git branch --show-current is sufficient for the branch (though this may be recent syntax?), maybe git remote show is sufficent ffor the origin?

Worked for me.


statsd: add connection overlow handling

We have seen a production issue where the local statsd relay
stops responding without breaking the connection. Eventually this
leads to an OOM condition. This commit adds a safeguard around the
maximum amount of memory that can be buffered before we give up.
In that case we increment a stat that can at least be viewed locally.
Fixes https://github.com/lyft/envoy/issues/897

@lyft/network-team

@theatrus @yashlyft


Add carbon protobuf receiver

I've made the switch from carbon-cache to go-carbon, mainly because it gives the opportunity to use carbonapi which is wayyyy simpler to manage than graphite-web or wayyyy faster than graphite-api.
If I understand correctly, one of the reason for this speed is the use of protobuf between go-carbon and carbonapi.
I've read recently that carbon-cache added a protobuf protocol.
What do you think of adding this as a receiver? Can the receiver get even better performance?

Hi, I'm going to add protobuf receiver in the near future. But I doubt that it will be much faster than the plain protocol

@Glandos the problem with protobuf receiver is that you'll need to write custom relay that supports protobuf.

Protobuf protocol have been added in master. Sample config:
[receiver.protobuf]
listen = ":2005"
protocol = "protobuf"

@Civil yes, but in my case, I have no relay, because everything is on the same host. So yes, maybe performance increase will be invisible anyway…
@lomik thanks!

Released in 0.11.0


As an MLOps Engineer, I want to use a monolothic pipeline to fetch my model(from Git or S3 storage), build and push the containerized model image to a registry

Closed by #177


Change ShallowWrapper.text() trim spaces with same behavior as ReactWrapper.text()

ReactWrapper.text() return string with the spaces as is, ShallowWrapper.text() removing double spaces and replacing   with regular space (removing doubles as well).

[ ] check tests case is sufficient
[ ] Confirm this is the behavior is correct

In the end ReactWrapper.text() don't do anything to spaces, so the solution was to remove the replace at all.
I added a fix for npm run react:n for Windows machines

@idanilt would you mind rebasing this on latest master?