Amazon price tracker

Keeps track of the prices of a product and sends a notification (mobile) when there is 50 % or more price drop . Better if we can compare the prices of the same platform and send the URL and price to the user

Can I submit my code

You can but make sure it passes PEP8. http://pep8online.com/ and solves the above problem statement. Thank you have a great day :)

import bs4 as bs
import sys
import schedule
import time
import urllib.request
from PyQt5.QtWebEngineWidgets import QWebEnginePage
from PyQt5.QtWidgets import QApplication
from PyQt5.QtCore import QUrl
import winsound
frequency = 2500  # Set Frequency To 2500 Hertz
duration = 1000  # Set Duration To 1000 ms == 1 second
class Page(QWebEnginePage):
def __init__(self, url):
    self.app = QApplication(sys.argv)
    QWebEnginePage.__init__(self)
    self.html = ''
    self.loadFinished.connect(self._on_load_finished)
    self.load(QUrl(url))
    self.app.exec_()

def _on_load_finished(self):
    self.html = self.toHtml(self.Callable)
    print('Load finished')

def Callable(self, html_str):
    self.html = html_str
    self.app.quit()

def exact_url(url):
index = url.find("B0")
index = index + 10
current_url = ""
current_url = url[:index]
return current_url
def mainprogram():
url = "https://www.amazon.in/Airtel-4G-Hotspot-E5573Cs-609-Portable/dp/B06WV9WR4Z"
exacturl = exact_url(url) # main url to extract data
page = Page(exacturl)
soup = bs.BeautifulSoup(page.html, 'html.parser')
js_test = soup.find('span', id ='priceblock_ourprice')
if js_test is None:
js_test = soup.find('span', id ='priceblock_dealprice')
str = ""
for line in js_test.stripped_strings :
str = line
# convert to integer
str = str.replace(", ", "")
current_price = int(float(str))
your_price = 600
if current_price < your_price :
    print("Price decreased book now")
    winsound.Beep(frequency, duration)
else:
    print("Price is high please wait for the best deal")

def job():
print("Tracking....")
mainprogram()
main code
schedule.every(1).minutes.do(job)
while True:
schedule.run_pending()
time.sleep(1)

Hey Issue a PR after you run the code in PEP8 online. My Bot will handle checking and stuff make sure to create a new file and put the code along with a README file (this file must contain SC of the code in-action, code explanation, and How to use the script)


Deprecate dwave-preprocessing composites

Codecov Report

Merging #894 (748f4e5) into main (e029580) will decrease coverage by 0.75%.
The diff coverage is 74.07%.

@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
- Coverage   85.12%   84.36%   -0.76%
==========================================
  Files          78       79       +1
  Lines        6761     6652     -109
==========================================
- Hits         5755     5612     -143
- Misses       1006     1040      +34

Impacted Files
Coverage Δ

dimod/roof_duality/fix_variables.py
30.00% <12.50%> (-36.67%)
:arrow_down:

dimod/reference/composites/fixedvariable.py
68.75% <61.53%> (+1.10%)
:arrow_up:

dimod/reference/composites/roofduality.py
68.75% <61.53%> (+7.21%)
:arrow_up:

dimod/reference/composites/_preprocessing.py
63.63% <63.63%> (ø)

dimod/reference/composites/clipcomposite.py
100.00% <100.00%> (+4.54%)
:arrow_up:

dimod/reference/composites/connectedcomponent.py
100.00% <100.00%> (+2.63%)
:arrow_up:

dimod/reference/composites/scalecomposite.py
100.00% <100.00%> (+2.85%)
:arrow_up:

dimod/reference/composites/spin_transform.py
100.00% <100.00%> (+42.85%)
:arrow_up:

dimod/core/bqm.py
42.44% <0.00%> (-5.82%)
:arrow_down:

dimod/bqm/adjdictbqm.py
39.73% <0.00%> (-2.63%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e029580...748f4e5. Read the comment docs.


Is it just me or is there something broken with NativeScript

I created a NativeScript like this (please click on the link to view the image).
After I created NativeScript, I get this error

Hi @groud , I wanted to know was this a bug or something I did wrong? May I know did you add my issue to the 3.0 milestone?

Well, if you did nothing more than adding the NativeScript and end-up with and error. Yes, this is a bug.
If the problem is on master (please fill in the issue template correctly next time), yes, it should be on 3.0's milestone.

I don't know where the error line comes from, but just creating a NativeScript resource itself isn't enough and not supposed to work, so I guess the bug here is the error reporting.

When you create an issue, you have this text:

Godot version:
If thirdparty of self-compiled, specify the build date or commit hash.
OS/device including version:
If graphics related, specify also GPU model and drivers.
Issue description:
What happened, and what was expected.
Steps to reproduce:
Minimal reproduction project:
Optional but greatly speeds up debugging. You can drag and drop a zip archive to upload it.

Please next time, fill-in the template, instead of removing it and write an incomplete message :)

What else do I need in order to get the NativeScript resource working then?

This is not the place to ask for help about how to use the engine, but for raising engine bugs/ask for features.
If the raised error prevent you from using the NatvieScript, tell us. Else the only bug here is that it seems to produce an error message for nothing.

Sorry mate I was not at all sure if it really was an issue, next time I
will keep that in mind :) Is this error message preventing me from
scripting, or am I still able to use it?
I understand that this place isn't for asking how to do something, but I
have tried asking in forums but I am not getting a satisfied answer so I
wanted to ask somebody who has more experience with this sort of stuff, may
I know what else do I need to do before I can use NativeScript and use C++?
On Wed, Dec 20, 2017 at 9:50 PM, Gilles Roudiere<EMAIL_ADDRESS>wrote:

When you create an issue, you have this text:
Godot version:
If thirdparty of self-compiled, specify the build date or commit hash.
OS/device including version:
If graphics related, specify also GPU model and drivers.
Issue description:
What happened, and what was expected.
Steps to reproduce:
Minimal reproduction project:
Optional but greatly speeds up debugging. You can drag and drop a zip
archive to upload it.
Please next time, fill-in the template, instead of removing it and write
an incomplete message :)
What else do I need in order to get the NativeScript resource working then?
This is not the place to ask for help about how to use the engine, but for
raising engine bugs/ask for features.
If the raised error prevent you from using the NatvieScript, tell us. Else
the only bug here is that it seems to produce an error message for nothing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14859#issuecomment-353030824,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BsFZZV-EBwjWH2dQ1G6QbKzaC1Gvks5tCOZwgaJpZM4RIBSy
.

You can check this out, it's using C but it shows the basics.

Read at least this : https://godotengine.org/article/dlscript-here
But Godot 3.0 is not out yet, a lot of stuff still need to be documented. You can find a PR about that here: https://github.com/godotengine/godot-docs/pull/832
Understand that the Github issues are not here to support people using the engine. Just asking "How do I make NativeScript work ?" is too vague, and here is not the place to ask such question. However, if you think a tutorial is missing, you make a feature request it in the godot-docs repository (its not needed here, a PR is already written).

Is this error message preventing me from scripting, or am I still able to use it?

It's up to you to tell us that. But, yeah, it does not seem like a problematic error, you should be able to use a NativeScript anyway.

Sorry I might sound a little bit direct, but we have already a lot of work on the engine, we don't have a lot of time to help the engine users in there ^^

Why doesn't everything just come straight out of the box instead of making
users manually do additional tasks just to use C++?
On Wed, Dec 20, 2017 at 10:24 PM, Gilles Roudiere<EMAIL_ADDRESS>wrote:

Read at least this : https://godotengine.org/article/dlscript-here
But Godot 3.0 is not out yet, a lot of stuff still need to be documented.
You can find a PR about that here: godotengine/godot-docs#832
https://github.com/godotengine/godot-docs/pull/832
Understand that the Github issues are not here to support people using the
engine. Just asking "How do I make NativeScript work ?" is too vague, and
here is not the place to ask such question. However, if you think a
tutorial is missing, you make a feature request it in the godot-docs
repository (its not needed here, a PR is already written).
Is this error message preventing me from scripting, or am I still able to
use it?
It's up to you to tell us that. But, yeah, it does not seem like a
problematic error, you should be able to use a NativeScript anyway.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14859#issuecomment-353038018,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79Bgy50kGXCFt03MiGKZhMIAmfu5yaks5tCO6CgaJpZM4RIBSy
.

I mean like why doesn't things just work straight out of the box? Should
this be considered an issue?
On Wed, Dec 20, 2017 at 10:41 PM, Gilles Roudiere<EMAIL_ADDRESS>wrote:

Sorry I might sound a little bit direct, but we have already a lot of work
on the engine, we don't have a lot of time to help the engine users in
there ^^
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14859#issuecomment-353041391,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BkqkQn3nMk7uFeocw4OqU4nI02enks5tCPJngaJpZM4RIBSy
.

See the comments in the other issue you opened. Setting up a C++ compilation environment is not Godot's purpose. This environment depends on the platform it's running on and thus should be set up by the user. You cannot have out-of-the-box C++ compilation.

I am so confused, why is it with GDScript and for C#, users can directly
create scripts in Godot and attach it to a game object, whereas we can't do
this using C++ directly?
On Wed, Dec 20, 2017 at 10:59 PM, Gilles Roudiere<EMAIL_ADDRESS>wrote:

See the comments in the other issue you opened. Setting up a C++
compilation environment is not Godot's purpose. This environment depends on
the platform it's running on and thus should be set up by the user. You
cannot have out-of-the-box C++ compilation.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14859#issuecomment-353044986,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BgB3xA2XvZDvfYJeVRiW91j69LaCks5tCPaegaJpZM4RIBSy
.

Because C++ compiles to native code, while C# and GDscript compile to byte code. While native code is meant to run on a specific hardware, byte code is interpreted by virtual machine (which may run on different hardware).
Thus C++ is faster, but needs to be set-up depending on the environment. While GDscript and C# are slower, but can run over several platform provided it has the adequate virtual machine. GDscript's virtual machine is directly implemented within godot's code, while C#'s is basically Mono.

I guess we could ship GCC with Godot in a separate download (like there is godot-mono, there could be a godot-c++).

To be honest, shipping Godot with mono seems already a pain to me...

At least my suggestion is in the future builds of Godot, there should be an
addon in the Godot repository that sets everything up for the user without
having to go through complicated procedures.
On Wed, Dec 20, 2017 at 11:21 PM, Gilles Roudiere<EMAIL_ADDRESS>wrote:

Because C++ compiles to native code, while C# and GDscript compile to byte
code. While native code is meant to run on a specific hardware, byte code
is interpreted by virtual machine (which may run on different hardware).
Thus C++ is faster, but needs to be set-up depending on the environment.
While GDscript and C# are slower, but can run over several platform
provided it has the adequate virtual machine. GDscript's virtual machine is
directly implemented within godot's code, while C#'s is basically Mono.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14859#issuecomment-353049222,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79Bphtm_5SqRw9tiNQ1vriioH2wgAPks5tCPvVgaJpZM4RIBSy
.

In Unity it gives the option to install seperate things such as a third
party IDE, Android builds etc. I am sure Godot can do the same thing, Godot
already gives the user the option to use either the mono version or no mono
version, so why can't it do the same thing for C++ as well?
On Thu, Dec 21, 2017 at 10:38 AM, Joe Smith<EMAIL_ADDRESS>wrote:

At least my suggestion is in the future builds of Godot, there should be
an addon in the Godot repository that sets everything up for the user
without having to go through complicated procedures.
On Wed, Dec 20, 2017 at 11:21 PM, Gilles Roudiere <
<EMAIL_ADDRESS>wrote:

Because C++ compiles to native code, while C# and GDscript compile to
byte code. While native code is meant to run on a specific hardware, byte
code is interpreted by virtual machine (which may run on different
hardware).
Thus C++ is faster, but needs to be set-up depending on the environment.
While GDscript and C# are slower, but can run over several platform
provided it has the adequate virtual machine. GDscript's virtual machine is
directly implemented within godot's code, while C#'s is basically Mono.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14859#issuecomment-353049222,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79Bphtm_5SqRw9tiNQ1vriioH2wgAPks5tCPvVgaJpZM4RIBSy
.

@Raj2032 C++ is not a simple language, and if you use it you are supposed to know what you are doing, or at least how to download a compiler.
If you are making a multi-platform game, you need to get plenty of toolchains and cross compilers that are several gigabytes big. bundling them is pointless. Even for a single OS you have plenty of choice for C++ compilers (MSVC, LLLVM, GCC). It's not only impossible for us to bundle them but also illegal.
I suggest if you are not familiar with this stuff, or don't intend to get more familiar with developing cross platform C++, to stay away from it.

How is it illegal to bundel them together as one package?
Unreal Engine allows users to use C++ straight out of the box (please do
correct me if I am wrong)?
On Thu, Dec 21, 2017 at 11:17 AM, Juan Linietsky<EMAIL_ADDRESS>wrote:

@Raj2032 https://github.com/raj2032 C++ is not a simple language, and
if you use it you are supposed to know what you are doing, or at least how
to download a compiler.
If you are making a multi-platform game, you need to get plenty of
toolchains and cross compilers that are several gigabytes big. bundling
them is pointless. Even for a single OS you have plenty of choice for C++
compilers (MSVC, LLLVM, GCC). It's not only impossible for us to bundle
them but also illegal.
I suggest if you are not familiar with this stuff, or don't intend to get
more familiar with developing cross platform C++, to stay away from it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14859#issuecomment-353220695,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79Bow-EDoO47KoZcxMX485ez0mH1glks5tCaOwgaJpZM4RIBSy
.

Unreal Engine allows users to use C++ straight out of the box (please do
correct me if I am wrong)?

You are wrong: Unreal asks the users to install Visual Studio (or another IDE): https://docs.unrealengine.com/latest/INT/Programming/Introduction/index.html
Also, Unreal engine is several gigabytes in size, while Godot is about 40 MB. And they ask you to download the C++ apart from that (Visual Studio is another huge package).
Seriously, if you want to use C++, which is not really an easy language, you should be able to install a compiler. Which is something you do only once.

How is it illegal to bundel them together as one package?

Their licenses don't allow us to bundle with Godot.

Maybe we should add a warning on the NativeScript creation so beginners don't make one by mistake.


Implement more unit control functions

I needed a way to rotate units, and in mlog I use unit target with shoot set to 0
This PR implements this and ability to call target prediction (targetp) on any unit

Just missing an update for test_unit_actions now.

Thanks!


Adjust imports to match the now-recommended "import ops" style (section 8)

As part of canonical/operator#921, we're updating the docs to use the now-recommended "import ops" style, that is, instead of:
from ops.charm import CharmBase
from ops.main import main
class MyC(CharmBase):
    ...
if __name__ == "__main__":
    main(MyC)

We prefer people do:
import ops
class MyC(ops.CharmBase):
    ...
if __name__ == "__main__":
    ops.main(MyC)

The docs have been updated (as part of #921), so ideally the linked repo would be as well. I'll create a PR for each section of the tutorial - this is for #8 ("unit testing").
Also pin the requests version more loosely to pick up any compatible bug/security fixes.
Also bump the data_interfaces lib to the latest version.
Also remove unnecessary SystemExit raises.
This includes a drive-by version bump to isort, because the current one's dependencies break pre-commit.  See PyCQA/isort:#2079 for details.

Consolidating.


Add make (mage) targets for controller-gen and kustomize

Is your feature request related to a problem? Please describe.
Make targets that come bundle with kubebuilder/operator-framework allow the crds/manifests to be generated when changes are made to the crds, etc.  Having this as mage targets will allow the pipeline to vet that the crds matches what is described in the api/v1 layer.
Describe the solution you'd like

[ ] Include the kubebuilder make targets as mage targets to vet manifests created by the controller-gen/kustomize tool
[ ] Included mage targets in the pipeline

Describe alternatives you've considered
This used to be in the repo but was removed for some reason
Additional context
None

potential targets:

make tools:

controller-gen tool install
kustomize tool install

make manifests - generates crds from api/v1
make install - generates crds from api/v1 and puts them on a cluster (installs crds, good for integration tests?)
make generate - generate deepcopy for api types (verify in pipeline)

controller-gen object paths=./api/v1

controller-gen is there EnsureControllerGen()
kustomize is there EnsureKustomize()

make generate needs to include the go generate to include the mocks in a PR that will help with testing the GRPCClient without the server.


upgarded crate3.3.3 test env

Upgraded crate test env to 3.3.3

@daminichopra 4.x PR #300  integration is pending review, which will make this obsolete

Hi @chicco785 , As per my understanding there is no need to upgrade crate test env to 3.3.3 as 4.x integration is pending now.
I would like to suggest if you can merge this PR and then merge PR #300
Please confirm. Thanks

Hi @daminichopra,
We just merged in #300, which brings support for Crate 4 and makes 3.3.5 available for testing backward compatibility:
https://github.com/smartsdk/ngsi-timeseries-api/pull/300/files#diff-ca4c6e6bba7e25458e0f4bb913efaadb
So unless you have any objections I'd drop these changes you've made and close this PR?

Hi @c0c0n3 , you can close this PR. Thank you


fix flatMapFirst

Hey @hmhv - that looks great, thanks for the catch.
I was only wondering - flatMapFirst says:

If element is received while there is some projected observable sequence being merged it will simply be ignored.

Did you confirm maxPublishers: 1 has the same behavior where it drops streams during the processing of a previous one?

What about this?
maxPublishers
The maximum number of publishers produced by this method.

https://developer.apple.com/documentation/combine/publisher/3204712-flatmap

That piece of docs isn't clear enough to be sure, so I tested this.
There is one key difference between RxSwift and Combine in this sense - and that's backpressure.
Here's the RxSwift example:

Note that every 3 seconds - the specific element emitted from the upstream is processing and others are "dropped" (like said in the docs)
Here's the Combine example:

Note that the upstream doesn't "drop items" at all - but never actually produces them since backpressure prevents the upstream from producing more elements. In this sense it's more like a concat since the flatMap is forced to complete before the upstream can product more elements.
I'm OK with listing it as a parallel even though ... in essence it's not too similar in behavior. What do you think ?

Messing with this a bit more - I wouldn't say this is like flatMapFirst.
I just realized Observable.merge(maxConcurrent: 1) is really the parallel of flatMap(maxPublishers: .max(1)).

Thank you for your example. you are right.
flatMap(maxPublishers: .max(1)) is not ignored element

This is still a very good point though, so I've added it in 416ec0754efc796c26b2fdb416839378f453e06c


MONDO:0023232 Giant cell myocarditis  & MONDO:0018008 [Merge]

Mondo term (ID and Label)
Giant cell myocarditis MONDO:0023232
Reason for deprecation
UMLS treats the Orphanet/Idiopathic term equivalent to other sources that are the general 'GCM' concept on C0264856 (Definition on Orphanet suggests there are some forms rooted in autoimmune disorder/trigger, so it is more 'agnostic' of cause than truly saying it completely unknown )
Term to be merged with
Idiopathic Giant cell myocarditis MONDO:0018008
Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here

According to this reference PMID: 33458585, not all giant cell myocarditis (GCMc) cases are idiopathic:
"GCMc can be idiopathic or occur in various conditions, such as infection (tuberculosis, syphilis, pneumocystis jirovecii parvovirus, coxsackie), inflammation, drug sensitivity, hypersensitivity and vasculitis. At least one group of the condition is considered as an autoimmune disease in 19% of patients in some registries that co-manifest with other autoimmune diseases such as inflammatory bowel disease, cryofibrinogenemia, optic neuritis, Hashimoto thyroiditis, rheumatoid arthritis, Takayasu arteritis, temporal arteritis, myasthenia gravis (MG), alopecia totalis, vitiligo, orbital myositis, autoimmune hepatitis, Guillain-Barré syndrome, systemic lupus erythematosus, Sjögren’s and pernicious anemia."
Thus, I am not sure if 'Giant cell myocarditis' MONDO:0023232 and 'Idiopathic Giant cell myocarditis' MONDO:0018008 should be merged.


update maxAzs vpc prop

Issue #, if available: OSML-191
Notes
This PR resolves the issue of deploying the VPC stack into a non-ISO AWS region with less than 3 AZs.
Template error: Fn::Select cannot select nonexistent value at index 2

The Fn::GetAzs CFN function was returning more AZs than the VPC could create subnets in. Specifically, in us-west-1.
Providing the customer with the option to specify the number of AZs they want to use, otherwise default to 2.
I also updated the DCDataplane Domain to use the same number of AZs as the VPC rather than an arbitrary config value.
Checklist
Before you submit a pull request, please make sure you have the following:

[x] Code changes are compact and well-structured to facilitate easy review
[x] Changes are documented in the README.md and other relevant documentation pages
[x] PR title and description accurately reflect the changes and are detailed enough for historical tracking
[x] PR contains tests that cover all new code and the code has been manual tested
[x] All new dependencies are declared (if any), and no unnecessary libraries are added
[x] Performance impacts (if any) of the changes are evaluated and documented
[x] Security implications of the changes (if any) are reviewed and addressed
[x] I have read the Contributing Guidelines and agree to follow the Code of Conduct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

LGTM but blocking on it. Please follow the conventional commit message (CONTRIBUTING.md)
It would be

fix: update maxAzs vpc prop


Misleading sample code?

The documentation says that for HRNN models

[...] you only provide user-id at inference. While the system does not throw an error if you also provide an item-id, the system neglects the value and the value does not impact the results.

In example code https://github.com/aws-samples/amazon-personalize-samples/blob/master/personalize_sample_notebook.ipynb?short_path=f7aa1a1#L1168 itemId is provided (and presumably neglected by the inference engine):
get_recommendations_response = personalize_runtime.get_recommendations(
  campaignArn = campaign_arn,
  userId = str(user_id),
  itemId = str(item_id)
)

One consequence is that the results often look unreasonably bad in light of the ITEM that's printed:
USER: 734
ITEM: Roman Holiday (1953)
Recommendations: [
  "Twister (1996)",
  "Phenomenon (1996)",
  "Birdcage, The (1996)",
  "Mission: Impossible (1996)",
  "Willy Wonka and the Chocolate Factory (1971)",

It is okay to just remove the itemId like this. Would it be okay with you? If so, we will update the notebook.

Great call out @danielvarga . We have removed the item_id from the request for clarity. Closing this issue.


Adds Scoping element to auth request

Summary
Adds a scoping element to the saml auth request

adds 3 settings attributes to facilitate the data needed for building the XML
mirrors SimpleSAMLphp functionality here: https://simplesamlphp.org/docs/1.7/simplesamlphp-scoping

@tekt8tket can you please rebase off master branch and update your tests to use minitest syntax?

Hi @tekt8tket, sorry for the delay in the reply.
The ruby-saml toolkits support only set 1 IdP so the IdP scoping has not much sense.
We also try to keep the toolkit simple so we avoid to add functionality that is not required by the main customers of the toolkit.

Hi @pitbulk I understand the desire to keep it simple but then that does beg the question of where a change like this should go?
I also would like the scoping functionality so I don't want to see the work @tekt8tket has done go to waste or land up in a fork.

The unique solution I see is to create a "extended" branch and try to push there all the PRs that were rejected and try to keep it updated, but this only gonna be possible if we find collaborators.
Right now we maintaining several toolkits: php, java, python, dot-net and ruby. Also several plugins so you can underestand that the effort is huge. And I dont want to reduce time for maintaining the main ruby branch by maintaining that forked branch.


Update CHANGELOG.md

Refs: LIIK-159, LIIK-162, LIIK-130

Codecov Report

Merging #124 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   98.02%   98.02%
=======================================
  Files         102      102
  Lines        6569     6569
  Branches      262      262
=======================================
  Hits         6439     6439
  Misses        106      106
  Partials       24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a52a950...e5e05d4. Read the comment docs.


Increment version for playwrighttesting releases

Increment package version after release of Azure.Developer.MicrosoftPlaywrightTesting.TestLogger

API change check
API changes are not detected in this pull request.


Trigger a rebuild after circleci reset (issue #10)

Checklist

[X] Used a fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


compose: Prevent removal of margin on Emojis in preview markdown.

Following up to #24961, it was discovered that emojis looked worse with the new changes as the spacings became uneven with each emojis. These changes aim to remove exclude emojis from the new changes.

Screenshots and screen captures:
Before:

After:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Can you see if https://github.com/zulip/zulip/pull/24994 happens to fix this problem? I suspect that this is the wrong way to fix the issue with emoji.

Sure!

I fixed the issue noted above and merged the fixed version -- this feels much more correct as opposed to a hacky workaround. @Joelute I think you probably could have found this by spending more time looking at the browser inspector -- it'll show you which styles are applied to various elements, and in particular it'd have told you that both your proposed revised selector was still matching the emoji elements ... and if you just put a few paragraphs of stuff inside the preview area, it applied to random elements inside as well.
Anyway, thanks for helping track this down! It was pretty subtle.

Interesting, I'll probably dive myself back to the hacky approach that I had whenever I have time to and see the differences.


[BUG]WorkPro: Cannot login after scanning. 3 tokens down only 1 left that works.

Describe the bug
Scan is not being registered after user scans. No login event is provided
Info

Platform[e.g. Windows/Mac/Linux]: Linux
Runtime version[e.g. node/JAVA]: node
Wechaty version: "@juzi/wechaty": "^1.0.65"
Wechaty Puppet version:  "@juzi/wechaty-puppet": "^1.0.61",

To Reproduce
Steps to reproduce the behavior:
1.

2. Scan the QR code
3. (Optional) Sometimes we get this message on the Wecom user's phone:

4. (Optional) We enter the verification code using the new @juzi/Wechaty

5. We only receive these messages and nothing about logging in

Expected behavior
There should be a login event, that logs the user has logged in
** Screenshots**

Additional context
It started with one account, then the two other accounts needed logging and everything stopped working. Only one account works now because it hasn't been logged out.

please provide the last 6 characters of your token and the time you scan.

Hi hcfw, here's the last character of our tokens we tried to scan 6 minutes ago and it didn't work.
a8d891
They get logged in but WeChaty doesn't send a login event:

We tried it twice we're in Eastern Timezone.

also our two other tokens that weren't working for scan started scanning again but not the one mentioned above

Got it. I'll look into it. Sorry it's vacation season now the response might be delayed.

In Sep 25th, Tencent published Wecom 4.1.30. Usually it won't force you to upgrade the version of your windows wecom (which is the platform workpro is working), however we found that since 9-30, Tencent is randomly picking some of the accounts to do so.
We are working on adapting the new version now, and will upgrade our server as soon is it's ready.

Thank you, would it be possible to have a temporary token while this fix is being made? Token seems to be deactivated now

Hi hcfw, here's the last character of our tokens we tried to scan 6 minutes ago and it didn't work. a8d891 They get logged in but WeChaty doesn't send a login event:
We tried it twice we're in Eastern Timezone.

Has it been resolved? I've also encountered the same issue.

我们也遇到了

Hi hcfw, here's the last character of our tokens we tried to scan 6 minutes ago and it didn't work. a8d891 They get logged in but WeChaty doesn't send a login event:
We tried it twice we're in Eastern Timezone.

Has it been resolved? I've also encountered the same issue.

Not yet. we are still waiting for the resolution.

没有过渡性方案吗？

嗨 hcfw，这是我们 6 分钟前尝试扫描的令牌的最后一个字符，但没有成功。a8d891他们登录了，但微信没有发送登录事件：
我们尝试了两次，因为我们在东部时区。

解决了吗？我也遇到了同样的问题。

还没有。我们还在等待解决方案。

你好，目前解决了吗

还没有解决，还在等。

现在workpro已经全量更新到企微新版本了，可以尝试登录，如果不行可以联系销售帮你重启token试试。


Fix 'read without -r will mangle backslashes.' issue in scripts\version.sh

CodeFactor found an issue: read without -r will mangle backslashes.
It's currently on:
scripts\version.sh:14

fixed


[Feature Request] Implement decltype

Is your feature request related to a problem? Please describe.
Since DXC/HLSL202x support macros, it should implement decltype as well.
Describe the solution you'd like
Just implement decltype as its implemented in LLVM 3.7 from which DXC is forked.
Describe alternatives you've considered
Nothing really.
Additional context
I'm making my own BDA pointer and reference types, https://github.com/microsoft/hlsl-specs/pull/59#issuecomment-1693661117

Moved to a spec issue. The reality is that this is not trivial to add. HLSL uses types in its AST that aren't allowed to be used in lots of other contexts (like pointers and references). In order to expose decltype or auto we would need to fix up a fair amount of technical debt in DXC and we would need to explicitly specify how decltype interacts with invalid types that are exposed in the AST.

Sad but understandable.

Moved to a spec issue. The reality is that this is not trivial to add. HLSL uses types in its AST that aren't allowed to be used in lots of other contexts (like pointers and references). In order to expose decltype or auto we would need to fix up a fair amount of technical debt in DXC and we would need to explicitly specify how decltype interacts with invalid types that are exposed in the AST.

is 95% of the work the same for auto and decltype then? maybe this should merge with #24 ?

Could you at least give me typeid then?

Well even without typeid I can make it work
https://godbolt.org/z/dhPaoGe5j
but #100 would be nice to resolve, cause this stops me from doing decltype(func) etc.


Use success notification banner for flash

Context
The success flash message was missing the "Success" title
Changes proposed in this pull request
Use Govuk Notification banner for flash message.
Guidance to review
Add an organisation and see the correct banner
Link to Trello card
https://trello.com/c/V8PMOjlm
Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated or added to the Azure KeyVault

Screenshots
Before:

After

 Fix flash message

Nice that we can use a view component for this. In the prototype the message is bold. Do we want to replicate that? Looking at the documentation we can make it bold https://govuk-components.netlify.app/components/notification-banner/

Yup! Fixed now


sched/spawn: Support the stack address argument

Summary
This patch enable user pass the custom stack pointer.
Note: The upcoming patch will utilize the new argument.
Impact
new API
Testing

@davids5 please review this PR, once it pass the review and merge. I will provide the next couple patch to support the custom stack pointer completely.

This seems like the start of a reasonable change to me, but it's hard to judge it's impact without understanding how the new stackaddr argument will be used. I see no harm in merging this change, but the integration portion should have a more thorough review.


Minimal width for editor tabs

I want to be able to customize the minimum width for editor tabs, to improving the number of tabbed pages on small monitor.
Options ideas:

Favicon only (perhaps cool only, may by keyboard to navigate; Best if can be achieve with extensions).
Customize min width, overflow only when will be less than this width.
Customize min number of characters on tabs, like 3 characters on head and other characters be hidden while overflow. ... and duplicate name path hints need to be considered. Use hover to see the tooltips.
Based on the above, allow hover to expand a tab.
Refer to many extensions for tabbed browsers.

Related issue: #29953, #28431.

+1

+1

+1

+1

+1

/duplicate of https://github.com/Microsoft/vscode/issues/17775


Remove unused Perl script

Wiki suggests to use msbuild/cibuild.sh.
https://github.com/Microsoft/msbuild/wiki/Building-on-OS-X-and-Linux

CI is also using cibuild.sh.

@cdmihai, @mmitche, the Ubuntu job is failing. Is it a known issue?
Also, on OS X, although the test passed, I noticed few weird messages:
find: ftsopen: No such file or directory

and
Unsupported target detected: . Configuring as if for CoreCLR
Unsupported host detected: . Configuring as if for Mono

Is this message about Mono correct?

Deletion LGTM. Pretty sure the Ubuntu CI failure is ok, but @cdmihai has the most up-to-date understanding of those.

I'm not aware of any mono issues.

Actually msbuild xplat didn't used mono at all (as I don't have it installed locally but built on OS X). It is using dotnet CLI, but the message says otherwise. :smile:

Sorry I just figured I had mono installed in my OS X box. So we do have mono dependency even with dotnet cli downloaded during the script run.. :(

LGTM

@jasonwilliams200OK
If you want to do a .net core selfhost without using mono, try ./cibuild.sh --host CoreCLR. Calling cibuild.sh with no args defaults to using a mono hosted msbuild to build for net core. Once https://github.com/dotnet/buildtools/pull/499 is accepted, I'll update cibuild to default to .net core. We need that PR to go into build tools because it fixes an issue which fails the tests on OSX (#504).
Ubuntu is known to be failing when hosted on mono. If you build it with --host CoreCLR it actually succeeds. However, even though it succeeds to compile and copy runtime dependencies, it has some failing tests (which due to lack of time we have not yet had the chance to investigate, but we do appreciate outside contributions :) ).
Error messages:
Unsupported target detected: . Configuring as if for CoreCLR
Unsupported host detected: . Configuring as if for Mono

This is outputed by cibuild when you do not provide values for --target and --host (./cibuild -h for more details). I agree that the messages should sound less like an error and more like a friendly reminder :)
find: ftsopen: No such file or directory

I do not know why this is getting printed, or who prints it. Needs investigation.

Thanks for the detailed response.

I'll update cibuild to default to using Core CLR as host. We need that PR to go into build tools because it fixes an issue which fails the tests on OSX (#504).

Unsure if it is normal, but it makes me very excited to know that we are going to get mono-independent build process in place! I really want to try building msbuild in a Ubuntu VM / docker, where mono is unavailable. :)

I do not know why this is getting printed, or who prints it. Needs investigation.

Investigated and fixed by https://github.com/Microsoft/msbuild/pull/513 . :smile:  :tada:

@cdmihai, should this be merged then? :smiley_cat:
I will try to make a separate PR for Ubuntu. :rocket:


Update broken link

:arrow_upper_left: :facepalm:

@benface, since there was a conflict, I rebased and also updated the links in the other languages

@benface, since there was a conflict, I rebased and also updated the links in the other languages

I just saw that I shouldn't have done so I deleted the previous commit and only left the rebase

Thank you @rafaelugolini!

I just saw that I shouldn't have done so I deleted the previous commit and only left the rebase

Actually, for fixing this sort of stuff, it's perfectly fine to do it in all languages – when Crowdin updates those files eventually, surely the same fix will have been applied there too. But it's better if we don't have to wait for that.

@benface I added the fix back :)

@benface fixed :)

Thank you so much, and sorry for the back and forth!

all good :)


Fix sending small ether amount #5803

Closes  #5803, Closes #5765, Closes #5762

@oa-s does this supersede #5807 ?

yes

@hboon  can u please review this pr?

Tap Send
Tap ETH to switch to USD
Enter 0.2
Shows "~0.0001 ETH"
Tap USD to switch to ETH
Shows 0.0001 (great)
Edit to 0.00011

Expect

Show more than 0.2 USD (since 0.00011 > 0.0001)

Observed

Shows "~0.12 USD"

But if our computation is correct and just due to rounding, I think we can let this one through for now. Just wanted to make sure we aren't computing wrongly

Also I needed to change: return viewModel.fiatRawValue.value to: return viewModel.fiatRawValue.valueOptional in order to build successfully.

Sorry, hang on, looking at the code a bit

@oa-s do you think if it helps to extract from AmountTextFieldViewModel the parts that due with the pair (Crypto <-> fiat), track .notSet (as well as the current exchange rate) etc into a standalone type? Then it's easier to understand both that new type and AmountTextFieldViewModel,and we can test that specifically with actual numbers.

When we enter small amount of usd (0.002 for example), we able to see rounded value of eth, 0.00001 for example, but actual its calculated value equals 0.00001958474636363748472 and so on. But when we switch back to crypto we expected to see 0.00001 and not 0.00001958474636363748472, again when switching we do calculation of alternative value, usd in our case, and take as raw entered value 0.00001 multiplying it by some rate we will get another different from  0.002 value. Any way we keep actual values, but displaying rounded. that is how we get zeros on confirmation when sending small usd values.

also i am facing an issue when transaction type get updated, (balance updated or something else), entered amount get changed. Fixing it now with moving updating amoun text field only when it has initial value, or all funds selected or qr code get scanned.

@oa-s do you think if it helps to extract from AmountTextFieldViewModel the parts that due with the pair (Crypto <-> fiat), track .notSet (as well as the current exchange rate) etc into a standalone type? Then it's easier to understand both that new type and AmountTextFieldViewModel,and we can test that specifically with actual numbers. Preferably a dumb one, without Combine?

i will try to do that

@hboon  added useOutputFormattingDebugFlag to AmountTextFieldViewModel you can play with it.
we could show alternative amount for entered crypto/fiat value, and in case it different user will know that.

like here

I can't tell useOutputFormattingDebugFlag what does. Can you help elaborate?
I noticed the green value (annotated) in the screenshot. But it appears regardless of the value of useOutputFormattingDebugFlag

Which one represents the actual value that is going to be used to craft the transaction?

when useOutputFormattingDebugFlag is true, that means we applying formatters for output numbers.
when crypo has selected we are goin to send value from text field
when fiat has selected we send green value, (calculated)

Updated pr, with increasing formaterrs fraction digits for amount text field only, still wip. but looks better, have to check more

looks like i have a solution:

replace NSDecimalNumber for representing users entered amount with Double (because NSDecimalNumber failes check ((NSDecimalNumber(0.001) / NSDecimalNumber(0.02231)) * NSDecimalNumber(0.02231) == NSDecimalNumber(0.001)))
increase formatting fraction digits for amount only (confirmation screen, send screen) for fiat (2 replace with 6) crypto 4 replace with 8

@hboon can you please check if it works on your side?

looks like i have a solution:

replace NSDecimalNumber for representing users entered amount with Double (because NSDecimalNumber failes check ((NSDecimalNumber(0.001) / NSDecimalNumber(0.02231)) * NSDecimalNumber(0.02231) == NSDecimalNumber(0.001)))
increase formatting fraction digits for amount only (confirmation screen, send screen) for fiat (2 replace with 6) crypto 4 replace with 8

Which error does this fix? (sorry I might have forgotten). When would this computation be used? We don't usually have division unless it's for number of decimal places, right?
((NSDecimalNumber(0.001) / NSDecimalNumber(0.02231)) * NSDecimalNumber(0.02231) == NSDecimalNumber(0.001)))

issues fixed:

formating small amount (when send small fiat amount, and crypto to fiat rate is big)
precission issue (when we send fiat selected value, i was facing an issue when entered amount like 0.001 became 0.009999 on confirmation screen). for some reasons because of NSDecimalNumber computation

@oa-s hmm.. ok. Would you help to add a test case and let's get this merged.


Can't install

I tried installing the builder as per the instructions in the README but the build fails. Here is my output.
Amols-iMac:packer-builder-softlayer amol$ echo $GOPATH
/Users/amol/Documents/Development/go
Amols-iMac:packer-builder-softlayer amol$ pwd
/Users/amol/Documents/Development/go/src/github.com/leonidlm/packer-builder-softlayer
Amols-iMac:packer-builder-softlayer amol$ go build -o /usr/local/packer/packer-builder-softlayer main.go
# github.com/leonidlm/packer-builder-softlayer/builder/softlayer
builder/softlayer/builder.go:45: undefined: packer.ConfigTemplate
Amols-iMac:packer-builder-softlayer amol$ echo $?
2
Amols-iMac:packer-builder-softlayer amol$ go test ./...
# github.com/leonidlm/packer-builder-softlayer/builder/softlayer
builder/softlayer/builder.go:45: undefined: packer.ConfigTemplate
# github.com/leonidlm/packer-builder-softlayer/builder/softlayer
builder/softlayer/builder.go:45: undefined: packer.ConfigTemplate

I tried it with the Vagrantbox in case it is an environment issue but see the same error.
Amols-iMac:packer-builder-softlayer amol$ vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Checking if box 'chef/ubuntu-12.04' is up to date...
==> default: Clearing any previously set forwarded ports...
==> default: Clearing any previously set network interfaces...
==> default: Preparing network interfaces based on configuration...
    default: Adapter 1: nat
==> default: Forwarding ports...
    default: 22 => 2222 (adapter 1)
==> default: Running 'pre-boot' VM customizations...
==> default: Booting VM...
==> default: Waiting for machine to boot. This may take a few minutes...
    default: SSH address: <IP_ADDRESS>:2222
    default: SSH username: vagrant
    default: SSH auth method: private key
    default: Warning: Connection timeout. Retrying...
==> default: Machine booted and ready!
==> default: Checking for guest additions in VM...
==> default: Mounting shared folders...
    default: /opt/gopath/src/github.com/leonidlm/packer-builder-softlayer => /Users/amol/Documents/Development/go/src/github.com/leonidlm/packer-builder-softlayer
==> default: Machine already provisioned. Run `vagrant provision` or use the `--provision`
==> default: to force provisioning. Provisioners marked to run always will still run.

Amols-iMac:packer-builder-softlayer amol$ vagrant ssh
Welcome to Ubuntu 12.04.4 LTS (GNU/Linux 3.11.0-15-generic x86_64)

 * Documentation:  https://help.ubuntu.com/
New release '14.04.2 LTS' available.
Run 'do-release-upgrade' to upgrade to it.

Last login: Fri Jun 12 12:25:51 2015 from <IP_ADDRESS>
vagrant@vagrant:~$ cd /opt/gopath/src/github.com/leonidlm/packer-builder-softlayer
vagrant@vagrant:/opt/gopath/src/github.com/leonidlm/packer-builder-softlayer$ go build -o /usr/local/packer/packer-builder-softlayer main.go
# github.com/leonidlm/packer-builder-softlayer/builder/softlayer
builder/softlayer/builder.go:45: undefined: packer.ConfigTemplate
vagrant@vagrant:/opt/gopath/src/github.com/leonidlm/packer-builder-softlayer$ echo $?
2
```

Yep this looks like a change in packer itself https://github.com/mitchellh/packer/commit/1d3a4d6aa2b2c969bb52f00e27113d21a28ad793

@amolmanjure @cmluciano guys I probably won't have the time to fix this during the upcoming week, however if one of you would like to submit a patch I will make sure to review and merge it asap.

Cool, I'll try to look at it this week.

I'm going to try to fix work on this when I can, but that might take a while since I'm not too familiar with go-lang. An immediate unblocker is just to compile against version 0.6.1 of packer.

Should be fixed with aaee0561423ff696e3f516895a9ef671b6d2afd6


Add appregistry delivery label to Dockerfile.rhel7

ART relies on the presence of com.redhat.delivery.appregistry label to identify it as an OLM operator.

/lgtm

/test e2e-aws-operator

/retitle bug 1803139: Add appregistry delivery label to Dockerfile.rhel7


Digital Ocean Private Networking

I've setup my salt-cloud profile to utilize private networking but every time i create a new droplet, it never creates with with private networking enabled.
I'm using version 0.8.9 and here is an example of my profile.
tier_1_nossl:
  provider: do
  image: Ubuntu 12.04 x64
  size: 512MB
  location: New York 2
  private_networking: True
  minion:
    grains:
      profile: tier_1_nossl

Same problem here using salt 2014.7.1 (Helium)
@adamsewell I was working for my in a previous version, I'm almost sure. Have you been using it or it's the first time you tried?

I have actually moved away from DigitalOcean since this. I can't really comment on this at the moment.


Global config to filter messages out

https://github.com/microsoftly/BotTester/issues/15

Coverage increased (+1.09%) to 95.11% when pulling 45aae5a9e5021c335e5f6d617456a00cf54563c6 on suttna:global-filter into 98b2170bdc255d7aa7d9f09a19e1da1808ab5f9f on microsoftly:master.

@microsoftly
About how MessageComparator.ts compares messages, I decided to not use recursive functions because  the code ends a bit messy and difficult to understand, but if you don't like that, I can change it and use recursive functions to detect differences between 2 message objects.
This is just a WIP that we are going to use in our project because we are having lot of issues with messages of type endOfConversation and __save__, we've created a custom Prompt that uses session.save() and it sends a silent message of type __save__, without a filter, we need to add an expect for that message in almost all the dialogs that our bot has.
Also, @bilby91 please review it too 🌮

Coverage increased (+1.7%) to 95.675% when pulling 54ce28d733f350f401ad74b051940e59940b7708 on suttna:global-filter into 98b2170bdc255d7aa7d9f09a19e1da1808ab5f9f on microsoftly:master.

I've just refactored the isEqual implementation of the new MessageComparator class, talked with @bilby91 about it and the solution is not as complex as I expected.

@santiagodoldan
Theres a few points to address here:

tests in BotTester.spec.ts that demonstrate functionality need to be copied to the README.md manually. Keeping the //```javascript comment is there for easy copying later for large overhauls
consistent style: 4 space indenting, semicolons to end lines, etc ... (I may have missed some cases)
the MessageComparator and IConfig.filteredMessages seems like a lot of structure without much flexibility. Instead, I'd recommend modifying the config with something like this:

interface IConfig {
// ...
    // returns true for messages that the BotTester should not ignore. False for messages it should ignore
    messageFilter: (message: IMessage) => boolean
}

then use that later to filter incoming messages by using the function like so here
const filteredMessages = e.filter(messageFilter)

this.botToUserMessageChecker(filteredMessages);

doing this makes the filter more flexible and fit the needs of the end user, including cases we might not think of. It also makes it easier to test and maintain.
After this feature is merged, we can make a separate PR with an additional config option of shouldSendSilentSave: boolean  and any additional cases that may be generically useful (e.g. shouldIgnoreEndOfConversationEvent,  shouldIgnoreTypingEvent, etc ...)

@microsoftly
I like the messageFilter approach, but we would need to find a way to make it global (if not, each BotTester instance will need to receive the function), the nice thing of having a filteredMessages array of objects, is that it can be stored in the bot-tester.yml config file you added, here you have an example of how it looks that file in our project now:
{
  "timeout": -1,
  "defaultAddress": {
      "channelId": "console",
      "user": { "id": "user1", "name": "user1" },
      "bot": { "id": "bot", "name": "Bot" },
      "conversation": { "id": "user1Conversation" }
  },
  "filteredMessages": [
    { "type": "endOfConversation" },
    { "type": "__save__" }
  ]
}

Saying that, I'm thinking that maybe adding a new function to BotTester that defines the messageFilter globally could be a good idea, so it can be defined in the spec_helper.js only once.
BotTester
  .filter((message) => {
    return ['endOfConversation', '__save__'].includes?(message.type);
  });

For your cases, I think what I've described works fine. We once the filter is implemented, we can add in some standard options into the config e.g. a config file with:
{
  ignoreInternalSaveMessage: true,
  ignoreEndOfConversationEvent: true,
  ignoreTypingEvent: true
}

these will activate prebuilt filters

Coverage increased (+0.8%) to 94.792% when pulling d4f25b57f6b128392621d6b9847ea56cf48b0926 on suttna:global-filter into 98b2170bdc255d7aa7d9f09a19e1da1808ab5f9f on microsoftly:master.

@microsoftly I've just removed all the MessageComparator stuff, instead of all that complex logic,
now there's a simple array of strings that contains message types to be filtered out. (filteredMessageTypes: ["__save__", "endOfConversation"]).
The library keeps simple and I can think a bit more about the filter function.
I'm gonna be out for a few days, will try to think a bit more about that filter function so I can create a new PR and add that too.

I've realized that the fact that you're seeing the internal  __save__ message is a bug. I'm taking this over and will fix the bug as well

save is not the only one causing issues in our tests, what are you planning to do?

I've implemented the solution. You will just need to add your own custom message filters as needed.
I decided not to make a global filter. One possible reason is that you want to ignore the __save__ messages now, but ignoring them will break the checkSession functionality. Down the line you may want to check session, and need to update everything.
Additionally, the options are modifiers to the default functionality. The default functionality is sending the ___save__ (this is default functionality because it is at the core of checking session state) message along with all other types of event messages. For that reason, it seemed more reasonable to keep them as such.

This PR does not filter any messages by default :/ by default it's an empty array.
If I need a message in a specific test because I filtered that message type using the bot-tester.yml config file, then I can change that using the constructor, because it overrides the global configurations. The same as the defaultAddress.
Will try your changes on Monday, I'm on vacation now, I'll let you know then.

you can filter some standard messages by default (e.g. https://github.com/microsoftly/BotTester/blob/master/src/config.ts#L28) If you need more messages that can be standardly ignored, they can be added to the config later.

@santiagodoldan I think that configuration should work for our use case at the moment so we are covered.
FIY @microsoftly  their is a typo in the config ignoreInternalSveMessage => ignoreInternalSaveMessage


Add PrefixAllGlobals sniff to the ruleset.

:warning: This PR should not be merged until WPCS has been merged back into the TRTCS as the sniff has only recently been added to WPCS.
Fixes #129

Rebased & added link to WPCS wiki paragraph with info about the custom property (what it does & how to set it).

Also see: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/Customizable-sniff-properties#naming-conventions-prefix-everything-in-the-global-namespace about passing the prefixes.


fix: Remove references to non-existing plugins

Relates to jenkins-x/lighthouse#1491

/cc ankitm123

/retest

/retest


DDS Render for DSPFs does not select WINDOW attributes when using *DFT

Sorry, I did not notice this one before and get it in before you put out an update.
DSPF with a window defined as WINDOW(*DFT 5 4 ...) does not render correctly.

When the starting points are given factually, WINDOW(2 3 5 4 ...), the window renders better, for some reason larger than needed.

Looking over the render.js source, line 167 does not know how to account for the value of *DFT.

Additionally, I cannot get the WDWTITLE to appear, even though its looks like should make it show up.  This might be a flaw with my DSPF but it does create on the IBM i.
What the attached DSPF should look like.

ISSUE_XXXX.DSPF.txt

Update, I did not notice before that the demo member I attached doe render the window title but is too far up to be really readable.

I have found the issue. Working on it now.

Now works with: WINDOW(10 2 10 70 *NORSTCSR)

Working on *DFT now

Tested with WINDOW(*dft 10 70) and looks like it is working now:

Now fixed those silly dashes in the title. Release 0.1.1 incoming


[FEATURE] Conditional rendering

Description of the requested feature
It would be helpful to have the option to render based on a condition.  This would enable more flexible modifications, say, changing the layout based on user input.  This would remove the need for the current clumsy work-around: on a user action, run a script that closes the old window and opens a new one.
Proposed configuration syntax
Just replicate <script-var>; maybe call it <cond-var> or similar.  Have it run the enclosed command, but just capture the shell return code.

All widgets can already take a visible attribute, that may either be "true" or "false". Using that, you should be able to achieve everything with that, or am i missing something?
Closing this for now, but feel free to reopen if you think that something is missing here.

All widgets can already take a visible attribute, that may either be "true" or "false". Using that, you should be able to achieve everything with that, or am i missing something?
Closing this for now, but feel free to reopen if you think that something is missing here.


Fixed a few cases of exponential backtracking

I'm currently writing a library to construct NFA from JS RegExp, so plugged it into Prism's pattern test to check for exponential backtracking and fixed (almost) all offending patterns. Please note that my test was not great. It only tested for a kind of exponential backtracking and it couldn't handle assertions and lookarounds at all, so there might very well be other patterns that still have exponential backtracking.
Now for the complex part: Textile.
The modifierRegex looks like this: \([^|)]+\)|\[[^\]]+\]|\{[^}]+\} with the important parting being the \([^|)]+\). Many pattern then use the pattern like this: (?:<MOD>|[<>=()])+ to get modifiers and some other characters.
The problem is that these other characters include ( and ), so for a string of the form /(?:\(=\)){100}/ there are 2^100 ways to match it.
The problem here is that I can't just remove the () from the set of other characters because unholy creations like p((. some text are valid.
So, how do we solve this?
(I refactored textile a little anyway.)

Nice work!
Regarding Textile, would it help to constrain the modifier regexp more?
Inside the pair of parentheses, there can only be either a classname followed by an optional id or just an id, I believe.  So the content could be restricted to [\w-][\w\d-]*(?:#[\w-][\w\d-]*)?|#[\w-][\w\d-] (yes, this is not the exact grammar for identifiers in CSS but it's good enough). Would that help mitigate the backtracking issue?
Similarly, the content inside square brackets could be constrained too but I'm not sure there is the need.
Actually, maybe it's even simpler to just ban [<>=()] from the modifier? \([^|<>=()]+\)|\[[^\]]+\]|\{[^}]+\}

Ok. I solved it by using a special pattern for parentheses.
The "only classnames and attributes" approach wouldn't have worked because textile basically allows anything in between brackets.


Eng 3756 expiring application docs

Description

Document expiring app type, expires at, can create expiring apps and conditions

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.72.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Setup common locale and preload pop-data into views

Added a mergeDeep function that deeply merges objects/arrays. I thought about using a library for this, but it feels a bit unnecessary to add another library just for a single function
Added a commonLocale.json which holds common locale strings for headers, footers, other 'common' strings used in components

Common locale can be accessed in views through locale.common.

Added a res.render proxy that preloads the common-locale, and popData into the view data.

This could likely be extended to the referenceData too, and the practitioner details data too.

Removed all the unnecessary popData calls in controllers now that the data is loaded into the view as mentioned above

Note - as usual, broken up by commit. Based on top of the #113 PR.

The commit history for this PR starts at https://github.com/ministryofjustice/hmpps-sentence-plan-ui/pull/115/commits/d236133eead7eeadc56e18694cb154bd8312ac70


registration-block alert texts i18n compatible

Fixes #4280

@niladrix719 may I know where I went wrong it seems fine to me?

i think its some issue with the code climate

@tanmoysrt cloud you please review my PR!!


Refactor to prep for a new binary.

Pulls out some functionality from build_xray_quadtree.rs into generation.rs. This is in preparation for adding a new binary that generates a single X-Ray image from a bounding box of the octree.
Adds ColoringStrategyKind::new_strategy which generates a ColoringStrategy from a commandline argument.
Change xray_from_points to operate over non-square images.

@wally-the-cartographer mereg

@wally-the-cartographer merge

Merge requested by authorized user SirVer. Merge queue now has a length of 1.


mpd: 0.22.8 -> 0.22.9

Motivation for this change
Update to latest version at the time of making this PR.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 128264 at 373e9efc run on aarch64-linux 1

2 packages built successfully:

mpd
mpd-small


fix: Fix a silly-looking layout of the new-user dialog

Addresses @HipsterBrown's comment on an awkward layout.

LGTM

LGTM


Be more precise when setting a property with invalid type

When setting an Object property with a valid name but an invalid type, "Invalid property name" is returned. This modification allows returning "Invalid property type" in this case.
In order to avoid breaking existing code, has_property is left unchanged.

This is awesome! Just a nit and it's good for me.
cc @EPashkin @sdroege

It's fine to change API IMHO, these functions are all new and in no release yet

I.e., please just change the existing function :)

All right, I'll do that!

By the way, any suggestion on the "ugly part"?

It used to be:
        match ptype {
            None => Err(BoolError("Invalid property name")),
            Some(ptype) => if ptype == type_ {
                    Ok(())
                } else {
                    Err(BoolError("Invalid property type"))
                },
        }

I must admit, I was not too proud of it. Then upon @GuillaumeGomez request, I proposed this:
        if let Some(ptype) = ptype {
            if ptype == type_ {
                Ok(())
            } else {
                Err(BoolError("Invalid property type"))
            }
        } else {
            Err(BoolError("Invalid property name"))
        }

But I'm still not convinced.

Never mind... I got it known.

Looks good to me

LGFM, only commit title better changed.

Do you want me to squash the commits and keep the first commit message only?

Yes please!

Not sure if you want me to do something else on this one.
@EPashkin: shall I enhance "Be more precise when setting a property with invalid type"?

Yes, after squash all good for me. Thanks.

Well, he already squashed so let's merge. Thanks!


MMF: Test runs aren't exported into TestRail app from time to time

please submit such ticket into the private repo with details. testrail updater implementation is customized to each testrail instance and zafira is not a right place for such issues


Feature: Provide Javascript SDK as ESM package

Describe what you are looking for
It would be nice if the JavaScript SDK would be available as an ESM package too.
Can you contribute to the implementation?

[ ] I can contribute

Is your feature request specific to a certain interface?
Other bindings
Contact Details
No response
Is there an existing issue for this?

[X] I have searched the existing issues

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@sroussey seems to have covered those in #342. Is that what you have in mind, @AndiLeni?

This should be fixed now.


about reconstruction

How can I use the first VQ to reconstructe wav by languagecodec

The dimension of first 3 layers's code embedding is 128 // 3, which means that each of them cannot be used to reconstruct the audio soly. You can use all of first 3 layers' codes to reconstruct the audio.


pull request for e2e test at 12/18/2016 19:15:18

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


jaxb-xjc: Some XSDs generated in the javax namespace, other XSDs generated in the jakarta namespace

After upgrading an existing project with 17 separate XSD files to cxf-xjc-plugin v4.0.0, which in turn depends on jaxb-xjc v3.0.2, some of the generated XSD files are generated in the jakarta namespace with code that starts like this:
//
// This file was generated by the Eclipse Implementation of JAXB, v3.0.2
// See https://eclipse-ee4j.github.io/jaxb-ri
// Any modifications to this file will be lost upon recompilation of the source schema.
// Generated on: 2023.07.09 at 12:09:03 PM BST
//

package xxx.foo;

import java.util.ArrayList;
import java.util.List;
import javax.xml.datatype.XMLGregorianCalendar;
import jakarta.xml.bind.annotation.XmlAccessType;
import jakarta.xml.bind.annotation.XmlAccessorType;
import jakarta.xml.bind.annotation.XmlSchemaType;
import jakarta.xml.bind.annotation.XmlType;

While other generated XSD files are generated in the javax namespace with code that starts like this:

package xxx.bar;

import javax.xml.bind.JAXBElement;
import javax.xml.bind.annotation.XmlElementDecl;
import javax.xml.bind.annotation.XmlRegistry;
import javax.xml.namespace.QName;

For obvious reasons chaos ensues:
package javax.xml.bind.annotation does not exist

All source code from 17 XSDs is generated at the same time, in the same invocation.
While the latest version of jaxb-xjc appears to be v4.0.3 at this writing, none of the maven plugins use this version (that I can find). It is not clear if any of the maven plugins are still being maintained.

Forcing the plugin to use jaxb-xjc v4.0.3 has the identical result, the bug still exists in the latest version.
        <dependencies>
          <dependency>
            <groupId>org.glassfish.jaxb</groupId>
            <artifactId>jaxb-runtime</artifactId>
            <version>4.0.3</version>
          </dependency>
          <dependency>
            <groupId>org.glassfish.jaxb</groupId>
            <artifactId>jaxb-xjc</artifactId>
            <version>4.0.3</version>
          </dependency>
        </dependencies>

//
// This file was generated by the Eclipse Implementation of JAXB, v4.0.3
// See https://eclipse-ee4j.github.io/jaxb-ri
// Any modifications to this file will be lost upon recompilation of the source schema.
//

package xxx.foo;

import java.util.ArrayList;
import java.util.List;
import javax.xml.datatype.XMLGregorianCalendar;
import jakarta.xml.bind.annotation.XmlAccessType;
import jakarta.xml.bind.annotation.XmlAccessorType;
import jakarta.xml.bind.annotation.XmlSchemaType;
import jakarta.xml.bind.annotation.XmlType;

package xxx.bar;

import javax.xml.bind.JAXBElement;
import javax.xml.bind.annotation.XmlElementDecl;
import javax.xml.bind.annotation.XmlRegistry;
import javax.xml.namespace.QName;

the issue is likely in the plugin being used and this particular project has no control over it.

Rather than making a guess as to the problem and then arbitrarily closing it, can you reopen so that further work can happen to get to the bottom of this?
I am trying to help get this fixed, this doesn't feel helpful.

Not sharing sample project - or at least the plugin being used isn't helpful neither. Would you mind sharing it?


<EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>

React Native Environment Info:
System:
OS: Windows 10
CPU: x64 Intel(R) Core(TM) i3-4130 CPU @ 3.40GHz
Memory: 5.17 GB / 15.93 GB
Binaries:
Yarn: 1.10.1 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
IDEs:
Android Studio: Version  <IP_ADDRESS> AI-181.55<IP_ADDRESS>14246
After adding react-native-navigation, unable to recognize react-native-sound-player

I guess this is just the issue.

Open an issue on react-native-sound-recorder as it's not strictly related to react-native itself.


Use PyPi API to get url for the prebuilt macOS M1 python wheel

I was curious how python wheels were compressed/bundled. Turns out it's a zip file so I figured I'd show the viability of using the PyPi API to get the build for arm64 macOS.
I'm not in love with it as it's kind of a hack. Here are the two issues:

The wheel unzips to torch rather than libtorch so the extract function has to handle this.
The find_map string, torch-{TORCH_VERSION}-cp311-none-macosx_11_0_arm64.whl is likely to change a bit in future releases. I was tempted to use filename.contains("arm64") && filename.contains("macosx") but that is still 8 different wheels (python 3.8 to 3.11 on macOS 11 and macOS 10.9).

In theory, this closes #629.
Let me know if this seems like a reasonable path forward.

@LaurentMazare Looking for this fix to be released soon. When is your next scheduled release?

Ah yeah I haven't done a released in a while so I just pushed a new one out (0.12.0). Note that it contains some breaking changes as per the changelog.


DBZ-3290 Remove incubating note from Oracle documentation

https://issues.redhat.com/browse/DBZ-3290

LGTM; waiting with the merge until after our go/no-go call tomorrow.

Remove hard-coded version "0.9.0.Alpha1" in listings

@gunnarmorling I rebased the oracle.adoc against master and I do see that all scn and commit_scn values are quoted as strings so we likely need to see why the website build isn't reflecting that for master.

we likely need to see why the website build isn't reflecting that for master.

I'm not sure whether a push to the "documention" dir in debezium triggers a website build. @ani-sha would know.

Logged DBZ-3317 to align decimal mappings for decimal.handling.mode.  I did check and we do support all 3 modes as Jiri indicated in both SnapshotDatatypesIT and StreamingDatatypesIT tests.  I also closed DBZ-807 as it's no longer relevent.

The LONG data-type is another one of those weird ones where its currently fully supported with LogMiner; however it is not yet supported by XStream because the data is delivered using the chunk-processing callbacks.  I've updated DBZ-2948 to capture also including support for LONG.

I'm not sure whether a push to the "documention" dir in debezium triggers a website build.

@gunnarmorling @Naros So we have actually missed that. There is no trigger for website build upon any action to documentation dir.

Ah, thx, @ani-sha. Would be a nice improvement for sure.

Copyright changed in PR https://github.com/debezium/debezium.github.io/pull/651

Logged DBZ-3327 to align default values for other connectors.

@Naros Hi, it seems it is complete now. Could you please rebase to remove the convflict?

@Naros This is good to go. I've fixed one more typo oversight. Could you please just rebase on the latest master? Feel free to merget it yourself after that.


Add charts/graphs

Add charts/graphs to the report to show the analysis visually

Graphs and histograms have been added to the PDF


bug: Distribute incorrectly adds disposal volume when using maximum pipette volume

Overview

When I use the distribute command to transfer 20 ul with a p20 pipette, the software splits it up into 2 10 ul transfers.
Steps to reproduce

p20.distribute(20, water, assay_plate.wells()[353:380])
Distributing 20.0 from A1 of USA Scientific 12 Well Reservoir 22 mL on 5 to B23 of Corning 384 Well Plate 112 µL Flat on Temperature Module GEN2 on 7
Transferring 20.0 from A1 of USA Scientific 12 Well Reservoir 22 mL on 5 to B23 of Corning 384 Well Plate 112 µL Flat on Temperature Module GEN2 on 7
Picking up tip from A1 of Opentrons 96 Tip Rack 20 µL on 2
Aspirating 11.0 uL from A1 of USA Scientific 12 Well Reservoir 22 mL on 5 at 7.56 uL/sec
Dispensing 10.0 uL into B23 of Corning 384 Well Plate 112 µL Flat on Temperature Module GEN2 on 7 at 7.56 uL/sec
Blowing out at A1 of Opentrons Fixed Trash on 12
Aspirating 11.0 uL from A1 of USA Scientific 12 Well Reservoir 22 mL on 5 at 7.56 uL/sec
Dispensing 10.0 uL into B23 of Corning 384 Well Plate 112 µL Flat on Temperature Module GEN2 on 7 at 7.56 uL/sec
Blowing out at A1 of Opentrons Fixed Trash on 12
p20.transfer(20, water, assay_plate.wells()[353:380])
Transferring 20.0 from A1 of USA Scientific 12 Well Reservoir 22 mL on 5 to B23 of Corning 384 Well Plate 112 µL Flat on Temperature Module GEN2 on 7
Picking up tip from A1 of Opentrons 96 Tip Rack 20 µL on 2
Aspirating 20.0 uL from A1 of USA Scientific 12 Well Reservoir 22 mL on 5 at 7.56 uL/sec
Dispensing 20.0 uL into B23 of Corning 384 Well Plate 112 µL Flat on Temperature Module GEN2 on 7 at 7.56 uL/sec
Current behavior

In this case, dispense and transfer give different results.
Expected behavior

I would expect them to give the same result.

"Unecessary" blow-outs from the distribute command are tracked in #8315 and #3117, so I'm going to close this ticke. In general, you should not expect the same results between transfer and distribute (otherwise we wouldn't have two different methods 😄). Unless you specifically want to aspirate a large amount of liquid once and then dispense that one large blob of liquid into multiple wells, you should not use distribute.
From your example, I think you're trying to do a one-to-many transfer, where each transfer is a single aspirate from the source well followed by a single dispense into the destination well. As detailed in the complex commands documentation, the appropriate method to use here is transfer, not distribute.


Add multiple backend support

This is a proposal for multiple backend support.
The main changes are:

ONCE_REDIS_URL is deprecated, to leave place to ONCE_BACKEND_URL (although if ONCE_REDIS_URL is defined, it's still accepted, to avoid user breakages. Maybe add a warning?
A base  Backend class has been implemented, defining the API any backend must implement:

get
set
set_expiry
delete

The Redis backend class has been defined
Test updates

Every technical choice is of course open for change and criticism. If you decide to accept this PR, I'll update the documentation to reflect the changes it introduces.
Note that the Memcache backend class has not been implemented. I figured someone with knowledge of the API could do it easily once multiple backends can be supported.
This would fix #5

Coverage decreased (-4.66%) to 93.04% when pulling af476356e3075d3d28a1511a8b93f058cd46a1b4 on brouberol:multiple-backend-support into dbce7508536eb8a2d3184dd2dded42a86357882c on TrackMaven:master.

@brouberol Thanks for starting the ball rolling on this!
I think the Backend class's option could be simplify to two methods.

raise_or_lock
clear_lock

i.e.
class Backend():
    def __init__(settings):
        # Validate settings or raise an exception.
        pass
    def raise_or_lock(key, **options):
        # Either raises AlreadyQueued if locked, or locks the key and continues
        pass

    def clear_lock(key):
        # Clears the lock
        pass

Different backend may need different settings.
For example, maybe you want to use the file system as a lock? Then having a default timeout is no longer possible.
I think the best way to achieve this is to alter the ONCE conf in celery to something like this...
celery.conf.ONCE = {
    'backend': 'celery_once.RedisBackend',
    'settings': {
        'url': 'redis://localhost:6379/0'
        'timeout': 60 * 60
    }
}

The backend key would be required. You would pass in an a link to the backend class.
This would also let other to easily tweak + build custom classes.
The settings key would allow each backend to have it's own settings, which can be checked in the __init__ of the backend class.
In terms of user breakages, I'd say it would be worth just bumping up MAJOR version number (e.g. to 1.0). I think the added functionality is worth the jump up.
What do you think?

I refactored the pull request, following your remarks.
Regarding the version bump, I agree, and suggest waiting for memcache support.

Coverage decreased (-2.18%) to 95.76% when pulling 94da43fbff320393a3068aeaed836b2de227d394 on brouberol:multiple-backend-support into 2b2ceafe47da1689ea08a35b66e3cfdfe72121b3 on TrackMaven:master.

Can you tell me if the current proposal meets your requirements, so that @jezdez can move forward with the memcached support (See #5). Cheers :smile:

@brouberol Sorry for the delay in getting back on this!
Yes it does, this is great stuff! There are a few modification I want to make, mainly the file structure + a few tests. I'm gonna patch on top of this and hopefully have something stable by the end of the weekend.

Should we close this one, now that all the cool kids are on #21?

Supported delay on this, but this is now in master. Thanks for the PR!


How can I use swsim on  my sim7600 platform？

How can I use swsim on  my  development board such as sim7600 platform ？

Is it possible? I don't think so because swsim is only software based and it is basically simulating a virtual sim card so I dont think that can happen but to achieve what you're saying, maybe you should use arduino with any sim card module. there is a lot of code lying around in the internet regarding that.

It is possible but you would need to use something like SIMtrace2 (running on the cardem firmware) to forward the swSIM APDUs back and forth between the dev board and a PC running swSIM and swICC IFD driver so it's available via PC/SC.
If you want to do this without any extra hardware, then there is no way to do that right now. Sorry :/

@enginestein what do you mean exactly? I believe the OP wants a solution where they don't need to use commercial or even research SIM cards. If they did, they could just slot a real card into their dev board.
I am curious though, please elaborate :>.

@enginestein what do you mean exactly? I believe the OP wants a solution where they don't need to use commercial or even research SIM cards. If they did, they could just slot a real card into their dev board.
I am curious though, please elaborate :>.

Actually I don't know much about SIM technology, I am learning from various resources and I said what I thought. Of course I might be wrong. I've been searching open source repositories which contain some material regarding the SIM card tech and I found yours, I ran it and observed it.  I thought that swsim is only software based, so it will not support hardware or any other microcontroller board...well now I think it can.


Skip test that isn't meant to work before 3.0

Could you remove the known_failure import to keep Travis happy? Then feel free to merge. Thank you!

Beautiful, thank you very much. Merging.


Add User to Organisation Feature

Description

Created a new routes file for organisation to handle routes

Implemented the functionality

Why is this a draft??
Also, no test file
And why is your database logic not in api/v1/services/organization.py file??
Check through the file structure to see how to go about this

Why is this a draft?? Also, no test file And why is your database logic not in api/v1/services/organization.py file??
Check through the file structure to see how to go about this

I am still working on it

.


Add Ascend NPU support for nf4 quant

What does this PR do?
This PR adds Ascend NPU support for nf4 quant/dequant, and make it possible to do QLoRA fine-tuning for LLMs using transformers, peft, and trl.
You may notice that the nf4 quantization method is currently implemented in pytorch. This interim measure is due to the fact that the high-performance version implemented using AscendC is still in progress 😞 . Meanwhile, we've received feedback from many in the Ascend NPU community expressing their keen interest in using QLoRA to fine-tune Large Language Models (LLMs) at the earliest opportunity.
Related PR: https://github.com/huggingface/transformers/pull/31512
Collaborators
@SlightwindSec @Ginray @MatrixPlayer

Thanks a lot for sharing this PR and the video demo! Thanks to the demo, I was able to successfully run NF4 quant/dequant on the NPU with ease. The detailed explanation in the video really helped me understand the process and key steps. Looking forward to more updates in the future—great work!

I hope this PR can be merged soon, as it provides valuable improvements. Looking forward to seeing it merged!
cc @Titus-von-Koeller

Nice work and thanks for the demo ! Can you have a look @matthewdouglas ?

I will be able to look in more detail next week, but at first glance it looks nice. Thanks @statelesshz !

@statelesshz We really appreciate the contribution! Apart from a lint check, I think we can go ahead and merge this.
For awareness, we are currently planning to adopt usage of torch.library to register custom ops for multi-backend. When we've progressed further on that we will want to come back and migrate to an updated interface.

@statelesshz We really appreciate the contribution! Apart from a lint check, I think we can go ahead and merge this.
For awareness, we are currently planning to adopt usage of torch.library to register custom ops for multi-backend. When we've progressed further on that we will want to come back and migrate to an updated interface.

@matthewdouglas Thank you for the feedback. I have addressed the lint check warnings, and I think the PR is now ready for merging. 🤗
Could you please re-trigger the CI to ensure everything is in order?


Multiple concurrent promises and Promise.all()

When dispatching multiple concurrent actions from the same PromiseCreator and waiting for them all to resolve with  Promise.all, Promise.all resolves whenever any one of the promises from a promise creator resolves and will resolve all of the promises created by that creator with the value of whichever promise resolved first.
I assume this is something I have wired up incorrectly, so I have included a lot more information than is probably necessary.
Version:
<EMAIL_ADDRESS>  version "2.2.2"
  resolved "https://registry.yarnpkg.com/redux-saga-routines/-/redux-saga-routines-2.2.2.tgz#3fd77713919c0a03fd69673c8878a6eb085b13e1"
  dependencies:
    redux-actions "^2.2.1"

class Index extends Component {
    static async getInitialProps({store, ...props}) {
        const creators = bindPromiseCreators({
            fetchArticlesPromiseCreator,
            fetchPopularArticlesPromiseCreator
        }, store.dispatch);

        console.log('dispatching promises and waiting.');
        const promises = [
            creators.fetchArticlesPromiseCreator({cat: 'category1'}),
            creators.fetchArticlesPromiseCreator({cat: 'category2'}),
            creators.fetchArticlesPromiseCreator({cat: 'category3'}),
            creators.fetchPopularArticlesPromiseCreator(),
        ];

        await Promise.all(promises).then( data => {
            console.log('all promises resolved and i\'m inside the then method.');
            data.map(val => console.log(val.result))

            // all of the fetchArticlesPromiseCreators resolved with the value
            // of whichever fetchArticlesPromise resolved first.
        }).catch(reason => {
            console.log('a promise rejected with reason ', reason)
        });
        console.log('all promises resolved');
        // here, Promise.all() resolves as soon as both
        //  1. the popular articles promise resolves
        //  2. any of the fetchArticles promise resolves.
        return {
            articles: selectArticleList(store.getState(), 'category1'),
            sidebar: {
                category2Articles: selectArticles(store.getState(), 'category2'),
                category3Articles: selectArticles(store.getState(), 'category3'),
                popularArticles: selectArticles(store.getState(), 'popular'),
            }
        };
    }

    render() {
        console.log('rendering');
        // This still does not fire until all the sagas have run properly.
        return (
            <MyComponent/>
        );
    }
}

// ./redux/articles.js

export const fetchArticles = createRoutine('FETCH_ARTICLES');
export const fetchPopularArticles = createRoutine('FETCH_POPULAR_ARTICLES');

export const fetchArticlesPromiseCreator = promisifyRoutine(fetchArticles);
export const fetchPopularArticlesPromiseCreator = promisifyRoutine(fetchPopularArticles);

// ./sagas/index.js

import {all, takeEvery, call} from 'redux-saga/effects'
import {routinePromiseWatcherSaga} from 'redux-saga-routines';
import createCMSClient from '../lib/tni-api'
import {fetchArticlesSaga, fetchPopularArticlesSaga} from "./articles";
import {fetchArticles, fetchPopularArticles} from "../redux/articles";

let cmsClient = createCMSClient();

export default function* rootSaga () {
    yield all([
        call(routinePromiseWatcherSaga),
        takeEvery(fetchArticles.TRIGGER, fetchArticlesSaga, cmsClient),
        takeEvery(fetchPopularArticles.TRIGGER, fetchPopularArticlesSaga, cmsClient)
    ])
}

// ./sagas/articles.js

export function* fetchArticlesSaga (api, {payload}) {
    yield put(fetchArticles.request());
    const response = yield call(api.getArticles, payload);
    if (response.ok) {
        const articleList = {
            id: payload.cat,
            ...response.data
        };
        const normalized = normalize(articleList, articleListSchema);
        console.log('normalized.result is ', normalized.result);
        // this always logs the correct result, and always logs before rendering happens.
        yield put(fetchArticles.success(normalized));
    } else {
        yield put(fetchArticles.failure(response));
    }
    yield put(fetchArticles.fulfill());
}

For your specific case it is better have only one routine loadArticles. You may pass list of categories as a payload to trigger action, i.e. loadArticles.trigger({ categories: ['category1', 'category2'], loadPopular: true }).
In the saga you need parse action payload and load articles based on the payload.
Instead of using selectors at the end of your getInitialProps it is better to prepare data in the saga and pass it to loadArticles.success(), so the promise will be resolved with prepared data, and all you need to do is just return the data from as a result of getInitialProps function...


Removing executor from indexify binary

Removing executors and packaging related code from Indexify binary, as they have moved to indexify_extractor_sdk

LFG! Shipit!


Issues/2772/reports

Fixes #2772

We'll need an entry in the 3.0 release notes for this to describe the API change.

Ok done.

@sasha0 tests are failing on this - grateful if you can fix.

@sasha0 tests are failing on this - grateful if you can fix.

@solarissmoke done.


Overview page

The balance page should be replaced with an overview page that shows total balance, recent activities and links to frequently used features

Does this relate to #68? If so, how? Can both issues be merged and one closed?


Suppress show download progress

It it redundant in most cases except download process is stalled.

Result of this change:
Step 5/5 : RUN   choco feature disable --name=showDownloadProgress &&   choco install -y git wixtoolset 7zip &&   choco install -y cmake --installargs 'ADD_CMAKE_TO_PATH=System' &&   choco install -y msys2 --params /NoUpdate --version=20230718.0.0 &&   choco install ruby -y --version=<IP_ADDRESS> &&   refreshenv &&   ridk install 3 &&   gem install --no-document --force bundler builder
 ---> Running in 1ab56324fc4d
Chocolatey v2.2.2
Disabled showDownloadProgress
Chocolatey v2.2.2
Installing the following packages:
git;wixtoolset;7zip
By installing, you accept licenses for the packages.
chocolatey-compatibility.extension v1.0.0 [Approved]
chocolatey-compatibility.extension package files install completed. Performing other installation steps.
 Installed/updated chocolatey-compatibility extensions.
 The install of chocolatey-compatibility.extension was successful.
  Software installed to 'C:\ProgramData\chocolatey\extensions\chocolatey-compatibility'
chocolatey-core.extension v1.4.0 [Approved]
chocolatey-core.extension package files install completed. Performing other installation steps.
 Installed/updated chocolatey-core extensions.
 The install of chocolatey-core.extension was successful.
  Software installed to 'C:\ProgramData\chocolatey\extensions\chocolatey-core'
git.install v2.44.0 [Approved]
git.install package files install completed. Performing other installation steps.
Using Git LFS
Installing 64-bit git.install...


Update README.md

Purpose

Fix spelling mistakes and improve the language a little

Goals

Minor updates

Thanks Paul. I have updated to the same file and it is in conflict, so I manually ported the changes.


Confusion regarding documentation: inconsistency in the documentation?

These two pages mention the event to be triggered in case I want to stop the autoplay of a carousel:

http://www.owlcarousel.owlgraphic.com/docs/api-events.html
mentions the event to be stop.owl.autoplay

https://github.com/smashingboxes/OwlCarousel2/issues/234
This issue mentions that the event is autoplay.stop.owl

Are there two versions out there?
And also, is the issue #234 the one that is currently on this repository? Which branch are the changes there deployed on?

Another inconsistency is found here:
In the owlCarousel lazy load functionality, I found two pages:

http://owlgraphic.com/owlcarousel/demos/lazyLoad.html
Says that the class should be class="lazyOwl"

http://www.owlcarousel.owlgraphic.com/demos/lazyLoad.html
Says that the class should be class="owl-lazy"

Hi icyflame I believe the confusion is coming from you accessing the documentation for 2 versions of this plugin concurrently.
E.g.:
http://owlgraphic.com/owlcarousel/demos/lazyLoad.html is for OwlCarousel v1
http://www.owlcarousel.owlgraphic.com/demos/lazyLoad.html is for OwlCarousel v2
Make sure you're looking at the correct documentation for the version of OwlCarousel you're developing with.

@jazibobs
I was using v1, and trying to trigger the event, which was given in the docs of v2. Thanks for the help!


Add TailwindCSS

Description

This builds on the work started in #623, adding TailwindCSS and styling the BigValue and ErrorChart components.
Additions from the previous PR:

TailwindCSS was reinitialized and reconfigured using svelte-add
Tailwind escapes were hoisted into the theme where appropriate (e.g. text shadow, grid template items)

Checklist

[ ] For UI or styling changes, I have added a screenshot or gif showing before & after
[ ] I have added a changeset

Noteworthy Items for Review:

I used data-viz for style scoping for an svg height that is nested in a 3rd party library. I am not sure if this style is expected elsewhere; and the :global may be eligible for hoisting into app.css.

Before

After

@ItsMeBrianD I am not fussed about the awkward whitespace on the error state for now.
It looks like the sparkline here isn't rendering quite right. [Edit, nevermind it looks like this is actually regression in main.]

Fooling around with this locally.
Alerts:
Nits:

Check rendering in Safari.
I'd drop the icon (sorry). I think these will be more flexible without it, and the alignment gets a bit jumbled when you put multiple lines in the slots.
I'd cut padding to p-2, rest of the page is fairly dense
I'd drop the borders (sorry)

Sticky mode:
I can get two behaviours with the sticky prop:

sticky = {true} and the alert will follow the scroll past it's position on the page
{sticky} in reference to the bool on the example page, and I get a full-width

When it's in "sticky mode", and is scrolling with the header, I would remove the rounding on the corners.
If you are going full-width, I would have no margin on either side, currently there's a gap to the left and not on the right (see image). If that's a pain, I'd just stay in the article width.
If you're going full-width, I'd remove margin bottom while scrolling so that multiple alerts can stack.

Tabs:
These are sweet -- I'd go sans serif on the labels, and switch to the blue we use for active pages in the sidebar as the "active" colour over the green

These are great!
One thing worth considering is the syntax for true/false props - currently, the rest of the component library accepts those props as strings and converts them to boolean (idea being that it keeps the prop syntax cleaner w/ less curly braces)

Looking great to me. I'm OK to skip the "unrounding". Not sure what's going on with the MacOS 16 test, but once passing I think you're good to go.

I'm not entirely sure where to start with the MacOS / 16 test, it looks like an error getting credentials for the BigQuery tests, this has come up frequently on PRs I've worked on