Only one GPU is being used on SLURM cluster

Bug description
While trying to train a HuggingFace model on a SLURM cluster, I am facing some issues with running on multiple GPUs. I have tried both FSDP and DeepSpeed, and while Lightning can identify that there are multiple GPUs (CUDA_VISIBLE_DEVICES: [0,1,2,3]), it doesn't use them. To ensure that it is not my code causing the problem, I have ran some tests with an example script from the Lightning documentation, resulting in the same outcome.
Before this, I was able to get the script to use 2/4 GPUs, or even 3/4, but it seems to be random. I am not sure how to debug further, but I would be happy to help if you can provide any feedback.
What version are you seeing the problem on?
v2.1
How to reproduce the bug
I used the following Python script:
Using a default example from the docs:

import torch
import torch.nn as nn
import torch.nn.functional as F
from torch.utils.data import DataLoader

import lightning as L
from lightning.pytorch.strategies import FSDPStrategy
from lightning.pytorch.demos import Transformer, WikiText2

# Fast: Delays the model creation until Trainer can place it on GPU
class LanguageModel(L.LightningModule):
    def __init__(self, vocab_size):
        super().__init__()
        self.vocab_size = vocab_size
        self.model = None

    def configure_model(self):
        if self.model is not None:
            return
        self.model = Transformer(  # 1B parameters
            vocab_size=self.vocab_size,
            nlayers=32,
            nhid=4096,
            ninp=1024,
            nhead=64,
        )

    def training_step(self, batch):
        input, target = batch
        output = self.model(input, target)
        loss = F.nll_loss(output, target.view(-1))
        self.log("train_loss", loss, prog_bar=True)
        return loss

    def configure_optimizers(self):
        return torch.optim.Adam(self.parameters(), lr=0.1)

L.seed_everything(42)

# Data
dataset = WikiText2()
train_dataloader = DataLoader(dataset)

# Model
model = LanguageModel(vocab_size=dataset.vocab_size)

# Trainer
trainer = L.Trainer(accelerator="cuda", devices=4, strategy=FSDPStrategy())
trainer.fit(model, train_dataloader)
trainer.print(torch.cuda.memory_summary())

This is the bash script I am using to schedule the job:
#!/bin/bash
#SBATCH --job-name=test_parallel
#SBATCH --output=parallel_test_%j.log
#SBATCH --partition=gpu
#SBATCH --nodes=1
#SBATCH --gpus=4
#SBATCH --cpus-per-task=64
#SBATCH --mem=256G
#SBATCH --signal=SIGUSR1@90
#SBATCH --time=0-01:00:00

module load 2022 Python/3.10.4-GCCcore-11.3.0

source $HOME/linguamol/.venv/bin/activate

python collect_env_details.py

# I tried both. None change the outcome of GPU usage.
# srun --nodes=1 --gpus=4 --cpus-per-task=64 python demo_parallelism.py
srun python demo_parallelism.py

deactivate

Error messages and logs
Python script log:
[rank: 0] Seed set to 42
GPU available: True (cuda), used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
HPU available: False, using: 0 HPUs
/gpfs/home/user/project/.venv/lib/python3.10/site-packages/lightning/pytorch/trainer/connectors/logger_connector/logger_connector.py:67: Starting from v1.9.0, `tensorboardX` has been removed as a dependency of the `lightning.pytorch` package, due to potential conflicts with other packages in the ML ecosystem. For this reason, `logger=True` will use `CSVLogger` as the default logger, unless the `tensorboard` or `tensorboardX` packages are found. Please `pip install lightning[extra]` or one of them to enable TensorBoard support by default
/gpfs/home/user/project/.venv/lib/python3.10/site-packages/lightning/pytorch/loops/utilities.py:72: `max_epochs` was not set. Setting it to 1000 epochs. To train without an epoch limit, set `max_epochs=-1`.
[rank: 0] Seed set to 42
Initializing distributed: GLOBAL_RANK: 0, MEMBER: 1/1
----------------------------------------------------------------------------------------------------
distributed_backend=nccl
All distributed processes registered. Starting with 1 processes
----------------------------------------------------------------------------------------------------

You are using a CUDA device ('NVIDIA A100-SXM4-40GB') that has Tensor Cores. To properly utilize them, you should set `torch.set_float32_matmul_precision('medium' | 'high')` which will trade-off precision for performance. For more details, read https://pytorch.org/docs/stable/generated/torch.set_float32_matmul_precision.html#torch.set_float32_matmul_precision
LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0,1,2,3]

  | Name  | Type        | Params
--------------------------------------
0 | model | Transformer | 1.0 B
--------------------------------------
1.0 B     Trainable params
5.1 M     Non-trainable params
1.0 B     Total params
4,055.534 Total estimated model params size (MB)
SLURM auto-requeueing enabled. Setting signal handlers.
/gpfs/home/user/project/.venv/lib/python3.10/site-packages/lightning/pytorch/trainer/connectors/data_connector.py:441: The 'train_dataloader' does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` to `num_workers=15` in the `DataLoader` to improve performance.

Training: |          | 0/? [00:00<?, ?it/s]
Training:   0%|          | 0/14919 [00:00<?, ?it/s]
...

Output of nvidia-smi:
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 535.104.12             Driver Version: 535.104.12   CUDA Version: 12.2     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA A100-SXM4-40GB          On  | 00000000:31:00.0 Off |                  Off |
| N/A   36C    P0             224W / 400W |  20672MiB / 40960MiB |     47%      Default |
|                                         |                      |             Disabled |
+-----------------------------------------+----------------------+----------------------+
|   1  NVIDIA A100-SXM4-40GB          On  | 00000000:32:00.0 Off |                  Off |
| N/A   29C    P0              48W / 400W |      8MiB / 40960MiB |      0%      Default |
|                                         |                      |             Disabled |
+-----------------------------------------+----------------------+----------------------+
|   2  NVIDIA A100-SXM4-40GB          On  | 00000000:CA:00.0 Off |                  Off |
| N/A   29C    P0              52W / 400W |      8MiB / 40960MiB |      0%      Default |
|                                         |                      |             Disabled |
+-----------------------------------------+----------------------+----------------------+
|   3  NVIDIA A100-SXM4-40GB          On  | 00000000:E3:00.0 Off |                  Off |
| N/A   29C    P0              50W / 400W |      8MiB / 40960MiB |      0%      Default |
|                                         |                      |             Disabled |
+-----------------------------------------+----------------------+----------------------+

+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
|    0   N/A  N/A   1051848      C   .../user/project/.venv/bin/python       20658MiB   |
+---------------------------------------------------------------------------------------+

Environment

Current environment

CUDA:

GPU:

NVIDIA A100-SXM4-40GB
NVIDIA A100-SXM4-40GB
NVIDIA A100-SXM4-40GB
NVIDIA A100-SXM4-40GB

available:         True
version:           12.1

Lightning:

lightning:         2.1.0
lightning-utilities: 0.9.0
pytorch-lightning: 2.1.0
pytorch-triton:    2.1.0+6e4932cda8
torch:             2.2.0.dev20231030+cu121
torchmetrics:      1.2.0

Packages:

aiohttp:           3.8.6
aiosignal:         1.3.1
antlr4-python3-runtime: 4.9.3
appdirs:           1.4.4
async-timeout:     4.0.3
attrs:             23.1.0
certifi:           2023.7.22
charset-normalizer: 3.3.0
click:             8.1.7
deepspeed:         0.11.2+f0604078
diffusers:         0.21.4
docker-pycreds:    0.4.0
fast-tokenizer-sf: 0.1.0
filelock:          3.13.1
frozenlist:        1.4.0
fsspec:            2023.10.0
gitdb:             4.0.10
gitpython:         3.1.37
hjson:             3.1.0
huggingface-hub:   0.17.3
idna:              3.4
importlib-metadata: 6.8.0
jinja2:            3.1.2
lightning:         2.1.0
lightning-utilities: 0.9.0
linguamol:         0.0.1
markupsafe:        2.1.3
maturin:           1.3.0
mpmath:            1.3.0
multidict:         6.0.4
networkx:          3.2.1
ninja:             <IP_ADDRESS>
numpy:             1.26.1
nvidia-cublas-cu12: <IP_ADDRESS>
nvidia-cuda-cupti-cu12: 12.1.105
nvidia-cuda-nvrtc-cu12: 12.1.105
nvidia-cuda-runtime-cu12: 12.1.105
nvidia-cudnn-cu12: <IP_ADDRESS>
nvidia-cufft-cu12: <IP_ADDRESS>
nvidia-curand-cu12: <IP_ADDRESS>
nvidia-cusolver-cu12: <IP_ADDRESS>
nvidia-cusparse-cu12: <IP_ADDRESS>
nvidia-nccl-cu12:  2.18.1
nvidia-nvjitlink-cu12: 12.3.52
nvidia-nvtx-cu12:  12.1.105
omegaconf:         2.3.0
packaging:         23.2
pathtools:         0.1.2
pillow:            10.1.0
pip:               23.3.1
polars:            0.19.8
protobuf:          4.24.4
psutil:            5.9.6
py-cpuinfo:        9.0.0
pydantic:          1.10.13
pynvml:            11.5.0
pytorch-lightning: 2.1.0
pytorch-triton:    2.1.0+6e4932cda8
pyyaml:            6.0.1
rdkit:             2023.3.3
regex:             2023.10.3
requests:          2.31.0
safetensors:       0.4.0
selfies:           2.1.1
sentry-sdk:        1.32.0
setproctitle:      1.3.3
setuptools:        58.1.0
six:               1.16.0
smmap:             5.0.1
sympy:             1.12
tokenizers:        0.14.1
tomli:             2.0.1
torch:             2.2.0.dev20231030+cu121
torchmetrics:      1.2.0
tqdm:              4.66.1
transformers:      4.34.0
triton:            2.1.0
typing-extensions: 4.8.0
urllib3:           2.0.6
wandb:             0.15.12
yarl:              1.9.2
zipp:              3.17.0

System:

OS:                Linux
architecture:

64bit
ELF

processor:         x86_64
python:            3.10.4
release:           4.18.0-372.70.1.el8_6.x86_64
version:           #1 SMP Thu Aug 10 14:05:06 EDT 2023

More info
No response
cc @awaelchli

@vandrw Make sure to closely follow the instructions here:
https://lightning.ai/docs/pytorch/stable/clouds/cluster_advanced.html
There it shows the important variables you need to set, in particular:
#SBATCH --nodes=4             # This needs to match Trainer(num_nodes=...)
#SBATCH --ntasks-per-node=8   # This needs to match Trainer(devices=...)

Which you haven't done. Can you check please?

Oh, that is embarrassing.  Thanks a lot for pointing it out.
Regarding the cpus-per-task, can you help me understand how the DataLoaders are being used in this parallel scenario? I assume that only one will be instantiated, and each task will use the provided CPUs to access it and serve data to the GPU?
If so, in your experience, how many CPUs per task would be enough for training while using A100-40GB GPUs?

There will be N main processes (or "tasks" in the slurm terminology) per machine if you select ntasks-per-node=N. If you then ask the SLURM scheduler to give you cpus-per-task=64 CPUs per task, then that's a lot of CPUs per task. Are you sure you have this many? If not required, I would just remove that requirement and just take the whole machine :)
How many CPU cores you want to use for loading your data can be specified in the PyTorch dataloader DataLoader(num_workers=...) and the value needs to be tuned to your needs.

I am facing a similar issue here.
I am training on an off-perm slurm cluster, and want to use a single node with 4 GPUs.
After reading the documentation I am slightly confused. After setting --ntasks-per-node=4 equal to Trainer(devices=4, ...), I am now spawning 4 main processes that each request 4 GPUs which naturally fails.  Ideally, I would like a single task with 4 GPUs as would be the case on a local machine.

Hey @julius-thomas! In SLURM, there are different ways to request GPUs. For example, you can request using the --gpus=4 flag, --gpus-per-node=4, or --gpus-per-task=4. In my case, I set it up like this:
#SBATCH --partition=gpu
#SBATCH --nodes=1
#SBATCH --gpus-per-node=4 (this could also include the type of GPU, such as a100:4)
#SBATCH --ntasks-per-node=4

Now, that would give you 1 node with 4 GPUs. To make sure that this is used properly by the Trainer, you need to also provide the number of nodes:
trainer = L.Trainer(
        accelerator="auto",
        strategy="auto",
        devices=4,
        num_nodes=1,
    )

I hope this helps!

Sadly not. This is my batch script.
#SBATCH --nodes=1
#SBATCH --ntasks-per-node=4
#SBATCH --gres=gpu:4
#SBATCH --hint=nomultithread

and this is my trainer:
    trainer = Trainer(
        devices=4,
        strategy='ddp'
    )

The error thrown in this configuration is:
raise MisconfigurationException(
lightning_fabric.utilities.exceptions.MisconfigurationException: You requested gpu: [0, 1, 2, 3]

4 Times, once for each task.

@julius-thomas
I just realized that the default value for num_nodes is 1, so my previous statement shouldn't make a difference. It does strike me as off that it only sees [0], [1], ... on each task instead of showing [0, 1, 2, 3]. Can you try running the example transformer I provided above, with the following script? You will have to change the Python version and the virtual environment path to yours:
#!/bin/bash
#SBATCH --job-name=test_parallelism
#SBATCH --partition=gpu
#SBATCH --nodes=1
#SBATCH --gpus=4
#SBATCH --ntasks-per-node=4
#SBATCH --mem=128G
#SBATCH --time=00:30:00

module purge
module load Python/3.10.8-GCCcore-12.2.0
source $HOME/project/.venv/bin/activate

srun python demo_parallelism.py

deactivate


Always-true Equality for PhantomData to PhantomData

:+1:

PhantomData already implements PartialEq and Eq, as can be seen here (the impls! macro generates this).
The reason that derive doesn't work on the struct is probably due to rust-lang/rust#26925

Looks like it to me! Closing in favour of that issue.


Jquery Validation Doesn't seems to Trigger any Event on browser autofill form

I'm trying to validate a form without submit the form. So what I did so far works greats. The problem is when browser autofill with a saved login and password related to that IP. I erase the autofilled and when I focusout of the input it doesn't trigger the event to validate form.
I'm using the following:
jquery-validation-1.15.0
google-chrome Version 49.0.2623.87 (64-bit)
Steps:
1 - Create a form and submit this form.
2 - Make browser save those information as the default values for that IP
3 - Go back do the form and erase some "autofilled" field and tries to trigger some event so that jquey-validate do its job.
It should validate the field with no need to submit. In my case is not triggering the event so it's no validating.

I think your problem is the same as #1715. If it is the case, you can refer to this comment https://github.com/jzaefferer/jquery-validation/pull/1733#issuecomment-204176028 and try the solution I provided there.

I'll check this later.

Will close for now. Feel free to ask further questions regarding this topic here. We can re-open if required.


Hey Lenni its the only way i can send you a message xD

I wanted to ask how can I use your plugin or if you can somehow send me the jar file
Thanks

First of all, this is the Issues section for my project ClassTransform and not a message Board.
Second, what Plugin do you mean specifically.

First of all, this is the Issues section for my project ClassTransform and not a message Board.
Second, what Plugin do you mean specifically.

Yes, that's right, sorry, what I meant is the cashploit plugin what you have deobf

Just download and compile it yourself because you have to change the trust command


Should palettes be iterables?

Currently, we use palettes just to group discrete colors together. It might be more useful to allow them to be accessed by their indices, e.g. apc.palettes.accent[0:2] might return a Palette containing the first two colors. I suppose users can do this using apc.palettes.accent.colors[0:2], but that feels a little cumbersome.

First of all, nice work you guys! The documentation is extremely helpful and thorough, and the API feels nice, and above all, the plots and color options look very nice.
Speaking as 0.5.0's likely first user here. @mezarque, I noticed this question you made  based on the title "Should palettes be iterables?", because when using the API I intuitively expected Palette to have length and be iterable. After seeing the colors attribute being accessed in the quickstart guide, I realized that Palette isn't actually a color sequence, but it holds a color sequence. Easy enough, but a little confusing.
IMO, the ColorSequence abstract base class should implement length (__len__) and be iterable (__iter__ and __getitem__). This would be more in line with the class name (ColorSequence), since a sequence is a lengthy, indexable iterable.
Here are the method implementations that turn ColorSequence into a true sequence and supports your desire to have slice-based indexing:
    @overload
    def __getitem__(self, index: int) -> HexCode: ...

    @overload
    def __getitem__(self, index: slice) -> T: ...

    def __getitem__(self, index: Union[int, slice]) -> Union[HexCode, T]:
        if isinstance(index, slice):
            return self.__class__(name=f"{self.name}_slice", colors=self.colors[index])
        else:
            return self.colors[index]

    def __iter__(self):
        return iter(self.colors)

    def __len__(self):
        return len(self.colors)

The change in action:
[ins] In [2]: len(apc.palettes.primary)
Out[2]: 12

[nav] In [4]: for color in apc.palettes.primary: print(color)
#5088C5
#F28360
#3B9886
#F7B846
#7A77AB
#F898AE
#73B5E3
#FFB984
#97CD78
#C85152
#F5E4BE
#BABEE0

[ins] In [5]: apc.palettes.primary[2:5]
Out[5]:

   seaweed #3B9886
   canary  #F7B846
   aster   #7A77AB

[ins] In [12]: apc.palettes.primary.reverse().colors == apc.palettes.primary[::-1].colors
Out[12]: True

[ins] In [6]: apc.gradients.blues[:2]
Out[6]:

   lapis  #2B65A1 0.0
   aegean #5088C5 1.0

But if you look at the last example, it's not all roses. Gradient accepts a values parameter that the base __getitem__ doesn't pass, so the default fallback evenly distributes the values erroneously. The workarounds would be (1) to have Gradient overwrite the base __getitem__ with it's own, or (2) put some these dunder methods in Palette and forget about slicing a gradient.
I think both these workarounds illustrate a potential shortcoming in the inheritance relationship between ColorSequence and Gradient, namely, that it exists at all.
Operationally, the Gradient defines anchors (paired colors and values), that can create interpolated color sequences. To me this is not itself a color sequence--it's a color sequence factory. Sure, it's anchors are lengthy, indexable, and iterable, but imo the gradient should have none of those characteristics.
I'm really pulling on the thread here, so I would like to preface this by saying I think the code is perfectly fine and we probably shouldn't touch it, but I would prefer composition over inheritance here, as it solves all the issues that led me to unravel this sweater. Something like this:
@dataclass
class Anchor:
    color: HexCode
    value: float

class Gradient:
    def __init__(self, name: str, anchor_colors: List[HexCode], anchor_values: Union[List[float], None] = None):
        """
        A Gradient is a sequence of pairs of HexCode objects and numeric values
        from 0 to 1 that represent the position of each color in the gradient.

        Args:
            name (str): the name of the gradient
            colors (list): a list of HexCode objects
            values (list): a list of float values corresponding
                to the position of colors on a 0 to 1 scale.
        """
        self.name = name

        if anchor_values is not None:
            (...)

        self.anchors = [Anchor(color, value) for color, value in zip(anchor_colors, anchor_values)]

    @property
    def num_anchors(self) -> int:
        return len(self.anchors)

Not inheriting from a sequence, Gradient has no length and can't be iterated, or indexed (which I think makes sense), but it does have the property num_anchors and its anchors can be iterated and index. And of course any palettes it generates are sequences. As it happens, this anchors attribute now closely resembles the docstring description. That's probably a good sign that we're converging onto something good.
After massaging Gradient's methods to use anchors, the Gradient class works even though it no longer subclasses ColorSequence. That's because the ColorSequence had no method implementations (besides the _get_longest_name_length one-liner), and served only to constrain Gradient with abstract methods.
With Gradient no longer constrained to act like a color sequence, we can just get rid of the ColorSequence class altogether and dump whatever we need (__iter__, __len__, __getitem__) into the true color sequence, Palette. In general, abstract base classes are more warranted when there exists functionality that can process a variety of object types agnostically, so long as they satisfy the abstract class, but I don't see that in this codebase.
Again, I think it's great as is, and I'm really enjoying using it. But I wanted to sketch out a path for how one would cleanly enable the feature described in this issue. Alongside that, I also sketched out some hacky alternatives that could be implemented in the near term if we really want Palettes to be sequences.

Thanks so much for taking the time to try out the package and think about this issue! Overall, I think your suggestions are really helpful. I agree that Gradient needn't inherit from ColorSequence, and that disentangling them would allow us to implement iterable methods for Palette. I'm not sure that we need Anchor to replace the underlying structure of the Gradient class - is the desire mostly to have the attributes of Gradient be sufficiently different from Palette so as to avoid confusion?
That detail aside, I think there's a handful of places that things would need to be rearranged in the package if Gradient doesn't inherit from ColorSequence, particularly for some type checks that we do when registering things to matplotlib, but otherwise this should work. Feel free to open a PR for these changes if you'd like, or we can explore implementing this for the next minor version.

Nice. I'll open a PR the next time I have some down time.

I'm not sure that we need Anchor to replace the underlying structure of the Gradient class - is the desire mostly to have the attributes of Gradient be sufficiently different from Palette so as to avoid confusion?

I was more just thinking of how I would like to structure the class in a world where it doesn't inherit from ColorSequence, and thought of a data structure that reflected the current docstring description. But upon further thought, I agree we don't need to replace the underlying structure... But it could be useful to instead have a property that zips colors and values together in a list of color-value two-ples, since that is an accepted format for passing custom color gradient definitions to plotly, and also the way we create matplotlib LinearSegmentedColormap objects, as illustrated in to_mpl_cmap:
    def to_mpl_cmap(self):
        colors = [(value, color.hex_code) for value, color in zip(self.values, self.anchor_colors)]
        return mcolors.LinearSegmentedColormap.from_list(
            self.name,
            colors=colors,
        )

That sounds good to me! In a previous version we had implemented something like this (particularly to accommodate usage with plotly), but decided to take it out to keep things a bit tidier. Happy to review a PR whenever you have time - no rush!


IndexError: string index out of range

Hello, I am new to shap package.
When I was plotting the waterfall_plot, an error came out.
Here is my codes
shap.waterfall_plot(explainer.expected_value, shap_values[0,:18], catestX_Shap.iloc[0, :18], show=True, max_display=18)
And the Error was shown like this

IndexError: string index out of range

But, when I select the shap_values from shap_values[0, :1 ] to shap_values[0,:17] and my data catestX_Shap.iloc[0, :1] to catestX_Shap.iloc[0, :17], the plot works.
Only when I select the eighteenth variable, the error comes out.
But when I jump over the variable, it works again.
shap.waterfall_plot(explainer.expected_value, shap_values[0,[17,19,20]], catestX_Shap.iloc[0, [17,19,20]], show=True)

Below is my eighteenth variable
catestX_Shap.iloc[:,18]

index values
0        0
1        0
2        0
3        0
4        0
..
48308    0
48309    0
48310    0
48311    0
48312    0

For the contents in the variable
catestX_Shap.iloc[:,18].value_counts()

0                    47869
1                      234
4                      117
3                       51
5                       28
2                       12
Others or Missing        2

Thank you for your reply.

Hey I just ran into a similar error and the culprit was a categorical feature (was using catboost) that had some blank entries (i.e., feature value was '').
I think the sanitation of the feature values may be overzealous. Or a try except framework could be used here:
/databricks/python/lib/python3.7/site-packages/shap/plots/_waterfall.py in waterfall_legacy(expected_value, shap_values, features, feature_names, max_display, show)
    411             yticklabels[rng[i]] = feature_names[order[i]]
    412         else:
--> 413             yticklabels[rng[i]] = format_value(features[order[i]], "%0.03f") + " = " + feature_names[order[i]]
    414
    415     # add a last grouped feature to represent the impact of all the features we didn't show

/databricks/python/lib/python3.7/site-packages/shap/utils/_general.py in format_value(s, format_str)
    232         s = format_str % s
    233     s = re.sub(r'\.?0+$', '', s)
--> 234     if s[0] == "-":
    235         s = u"\u2212" + s[1:]
    236     return s


[sql] Test fix for Managed Instance Start Stop

Related command

There are no new commands added, this is purely a test fix.
Description

This PR is a fix for a leftover item from https://github.com/Azure/azure-cli/pull/26979. It includes a fix for the test to not use existing resources but instead to create and delete a new resource to perform the test on.
Testing Guide
No new commands added.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

sql

@evelyn-ys this PR is the fix for the test that I merged in the last milestone. Please let me know if there is anything else that should be done. Thanks!


ImportError: No module named setuptools

I followed the manual installation instructions but was given an error on the final step.
RoBO $ python setup.py install
Traceback (most recent call last):
File "setup.py", line 3, in
from setuptools import setup, find_packages
ImportError: No module named setuptools

Could you try to install setuptools via:
pip install setuptools

That worked, thanks.
Now it's giving the error: RuntimeError: Required library HODLR not found. Check the documentation for solutions.

The problem is due to george, the GP library we use inside RoBO.
How did you install the requirements of RoBO? Did you execute
for req in $(cat all_requirements.txt); do pip install $req; done
Could you also make sure that you installed all the requirements of george http://dan.iel.fm/george/current/user/quickstart/#installation

Didn't work.
While installing the requirements and george I got errors like:
Command "/usr/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-build-RFWuet/george/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-9DEWsG-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-build-RFWuet/george/

Managed to get george installed by installing the packages python-all and python-all-dev.
Installing reqs seems to not have less issues now.
Tried installing RoBo and got the following:
`Installed /usr/local/lib/python2.7/dist-packages/RoBO-0.2.1-py2.7.egg
Processing dependencies for RoBO==0.2.1
Searching for DIRECT
Reading https://pypi.python.org/simple/DIRECT/
Downloading https://pypi.python.org/packages/2e/31/04e3847b1bf6c0a21f21aecbbe6c242ef1ed9ac7711ae6ce859cb985f738/DIRECT-1.0.1.tar.gz#md5=943d257700a9a8c7297fbca50ef09d38
Best match: DIRECT 1.0.1
Processing DIRECT-1.0.1.tar.gz
Writing /tmp/easy_install-KTBT99/DIRECT-1.0.1/setup.cfg
Running DIRECT-1.0.1/setup.py -q bdist_egg --dist-dir /tmp/easy_install-KTBT99/DIRECT-1.0.1/egg-dist-tmp-TGidFl
Reading fortran codes...
Reading file 'src/direct.pyf' (format:free)
Post-processing...
Block: direct__user__routines
Block: direct_user_interface
Block: fcn
Block: direct
Block: direct
In: src/direct.pyf:direct:unknown_interface:direct
get_useparameters: no module direct__user__routines info used by direct
Post-processing (stage 2)...
Building modules...
Constructing call-back function "cb_fcn_in_direct__user__routines"
def fcn(x,iidata,ddata,cdata,[n,iisize,idsize,icsize]): return f,flag
Building module "direct"...
Constructing wrapper function "direct"...
x,fmin,ierror = direct(fcn,eps,maxf,maxt,l,u,algmethod,logfilename,fglobal,fglper,volper,sigmaper,iidata,ddata,cdata,[n,iisize,idsize,icsize,fcn_extra_args])
Constructing COMMON block support for "directcontrol"...
jones
Wrote C/API module "direct" to file "build/src.linux-x86_64-2.7/src/directmodule.c"
Fortran 77 wrappers are saved to "build/src.linux-x86_64-2.7/src/direct-f2pywrappers.f"
Could not locate executable gfortran
Could not locate executable f95
Could not locate executable ifort
Could not locate executable ifc
Could not locate executable lf95
Could not locate executable pgfortran
Could not locate executable f90
Could not locate executable f77
Could not locate executable fort
Could not locate executable efort
Could not locate executable efc
Could not locate executable g77
Could not locate executable g95
Could not locate executable pathf95
don't know how to compile Fortran code on platform 'posix'
warning: build_ext: f77_compiler=None is not available.
error: Setup script exited with error: extension 'DIRECT.direct' has Fortran sources but no Fortran compiler found`

Installed gfortran package and now it's giving the error:
`... a lot of stuff ...
Warning: Unused dummy argument ‘file’ at (1) [-Wunused-dummy-argument]
src/DIRsubrout.f:1222:30:
  +               l,u,file2,maxfunc,maxdeep,n,maxor,length)
                          1

Warning: Unused dummy argument ‘file2’ at (1) [-Wunused-dummy-argument]
src/DIRsubrout.f:1221:38:
   SUBROUTINE DIRWriteHistBox(point,f,thirds,c,anchor,actdeep,file,
                                  1

Warning: Unused dummy argument ‘point’ at (1) [-Wunused-dummy-argument]
src/DIRsubrout.f:1256:57:
  +               iidata, iisize, ddata, idsize, cdata, icsize)
                                                     1

Warning: Unused dummy argument ‘cdata’ at (1) [-Wunused-dummy-argument]
src/DIRsubrout.f:1256:42:
  +               iidata, iisize, ddata, idsize, cdata, icsize)
                                      1

Warning: Unused dummy argument ‘ddata’ at (1) [-Wunused-dummy-argument]
src/DIRsubrout.f:1256:27:
  +               iidata, iisize, ddata, idsize, cdata, icsize)
                       1

Warning: Unused dummy argument ‘iidata’ at (1) [-Wunused-dummy-argument]
src/DIRsubrout.f:1253:48:
  +               algmethod, maxfunc, maxdeep,
                                            1

Warning: Unused dummy argument ‘maxdeep’ at (1) [-Wunused-dummy-argument]
src/DIRsubrout.f:1252:44:
   SUBROUTINE DIRheader(logfile,version,x,n,eps,maxf,maxT,l,u,
                                        1

Warning: Unused dummy argument ‘x’ at (1) [-Wunused-dummy-argument]
src/DIRsubrout.f:1414:45:
  +               fglobal, numfunc, Ierror)
                                         1

Warning: Unused dummy argument ‘ierror’ at (1) [-Wunused-dummy-argument]
src/DIRsubrout.f:155:0:
       S(maxpos,2) = novaluedeep

^
Warning: ‘novaluedeep’ may be used uninitialized in this function [-Wmaybe-uninitialized]
No eggs found in /tmp/easy_install-651M4j/DIRECT-1.0.1/egg-dist-tmp-rUeKs_ (setup script problem?)
error: The 'DIRECT' distribution was not found and is required by RoBO`

Ran dependencies script again and it seems to have worked now.
Haven't used it yet, just installed it.
Will update if there are any problems.


Frontend Side not opening

The frontend side is not working even with the code check that out.

@asmit203 assign this issue to me

@asmit203 assign this issue to me

assigned


[FIX] Typo in description: should

The current description in the tools.py includes a typo in should. fix that.
note: it works really good, many thanks

Fixed! Thanks for pointing it out


Update run with -run

i dont think this is necessary as it works just fine without the - also i don't know yaml that well so this might end up breaking smtg without me realizing

Btw can u star my repo. ?(@japrozs/spam)


Measurements of the four weight sensors on the Nintendo Balance board are exactly 4 times too big

Back in December of 2007, Mr Hiroyuki Ogasawar (Oga) from Japan, hacked the Wii Balance board, and figured out the formula to get weight values from the 4 weight sensors.
He posted the formula for the calculation, and wrote: (Google translate)
"I calculated this for 4 sensors of A, B, C, and D and took the average,
it matched my weight by itself."
...emphasis on the word "average".
Each weight sensor should return the proper portion of the person's weight that is currently standing on the device...
and the entire person weight will be given by the total of the 4 sensor weight values, not by averaging them!
I.E, a person that is standing so that his balance is a little to the heels of his left foot: BottomLeft:30kg , TopLeft:20kg, BottomRight:10kg, Top Right:5kg.
This guy weighs 30+20+10+5 = 65kg,
This guy does not weigh (30+20+10+5)/4 = 16.25kg!
The bug can be seen with the wiimoteTest program, and also with willBalanceWalker program, etc. all of the 4 sensor values are exactly 4 time too big. and the library divides the overall weight value by 4 (averaging), that's why the overall weight is still correct.
The bug was created when Oga used 68 (kg) in his formulas, instead of 17. I don't know how or who figured out that Nintendo used 17kg and 34kg weights as the calibration values on the wii balance board, but these are the correct numbers (17 / 34), wheres 68 is 4 times 17, or 4 times too big, hence explaining the error.
(If anyone has any internal nintendo documents that they would like to share with me... It might answer some serious questions I got, posted in #8  )
(please see Pull request #7 )

I released my updated library here

Sorry for the offtop, but I have some trouble using these tools and you seem to understand this tool... So I have a Wiimote & Wiimoteplus and trying to connect a nunchuck. When I do that, the testing app crashes and later it just can't start. Have you faced anything like that?

nope, as I'm not using any other wii remote except the balance board. (and it sounds like you're not using it)

I intended to do something with the balance board later (I have it) but currently I can't even fully set up the remote :(


Fix toolstate for rust-lang/rust#85546

cc rust-lang/rust#85780

This is probably out of sync with rust-lang/rust#85546 now because I changed many functions of Machine in the latest commit... I'll update this later.

@bors r+

:pushpin: Commit 9b2d42587f1b12188c1430bd79c058f4590f0ded has been approved by RalfJung

:hourglass: Testing commit 9b2d42587f1b12188c1430bd79c058f4590f0ded with merge 4fa9363ebba236f7c29ae11180db6051d7d2ce3b...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 4fa9363ebba236f7c29ae11180db6051d7d2ce3b to master...


Fix and clarify troubleshooting "The app loads but tests fail to start in SDK >= 28" on android

[x] This is a small change
[ ] This change has been discussed in issue #<?> and the solution has been agreed upon with maintainers.

Description:
Just updates the Getting Started for Android guide.
Previously this said to use <domain-config cleartextTrafficPermitted="false"> which is how you explicitly set domains to not allow cleartext traffic but for Detox we want the opposite.  I also tried to make the readme section a little more explicit on exactly what to do.
I also removed the "untested" part of this because I have tested and confirmed it works.

Pull Request Test Coverage Report for Build 2146

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.962%

Totals

Change from base Build 1183:
0.0%

Covered Lines:
3201

Relevant Lines:
3871

💛  - Coveralls

Thanks for this! I'll embed in our example apps to use this, and further update the docs.


Fix typo in internal server implementation

Typo was 'randombly', changed to 'randomly'

Came across a typo in the comments for the New function in the package server, please review /assign @crwilcox

@googlebot I signed it!

/ok-to-test
/lgtm
/approve


Create Determine Whether Matrix Can Be Obtained By Rotation.cpp

Create Determine Whether Matrix Can Be Obtained By Rotation LeetCode Weekly Contest 244

@creativeyashi add the include statements and main functions and also mention the issue number


Adding a maxUnavailable variable for daemonSet.RollingUpdate

We've recently realised that rolling updates are very time-consuming (if applicable, can also cause timeouts) when the number of pods grows significantly and the default maxUnavailable is set to 1.
This change provides an easy way to adjust the number if needed.

@legoGoat thanks for the contribution!


Fix tag usage in goreleaser

this time it's the right one.

Hopefully this one is the good one !


Check list for dependency update:

This ticket serves as a reminder of the newly added software that required docker.

[x] PEER (update PEER docker to include MOFA) (call it MOFA2 docker)
[x] CUGG (Update cugg package with the updated function, then add cugg to bioinfo docker)
[x] fastp as in #226
[x] SuSiE R update (Some connection error, pending resolve)
[x] STAR updates to 10a

The error message for building the susie container is as followed:
+ apt-key adv --keyserver keyserver.ubuntu.com --recv-keys E298A3A825C0D65DFD57CBB651716619E084DAB9
Warning: apt-key output should not be parsed (stdout is not a terminal)
gpg: keyserver receive failed: Connection timed out

this line makes it possible to add the cran R repo to Debian and therefore install R via apt-get. I dont see why we need it here in the stephenslab.dockerfile ... because you are not installing R here. Should be safe to remove.

Another problem with the susie container is installation of devtools, which seems to be problematic recently. After replacing it with remotes problem solved.

We have recently released a new version on cran for our SuSiE RSS manuscript (recent on PLoS Genetics) which is finally stablized after a coiuple of years work -- we can use cran release of SuSiE now.


Some services added + packages update

1234
camipro
fm
gdrive
gitlab
infowww
lamp
library
mailcleaner
myjob
mynas
mysql
myvm
mssql
nas
poseidon
rauth
tremplin

Coverage remained the same at 100.0% when pulling f97a1045bad50fa549dc81232a676f214fb9dc0e on ponsfrilus:master into 82bc304cad79409d1d66c9ebcb7e9939475cc423 on epfl-devrun:master.

Thanks a lot!


Add secret manager enabled property to properties metadata

This adds the missing secretmanager enable property to the project metadata.
Fixes #2362.

the entry is now duplicated. it was renamed as part of https://github.com/spring-cloud/spring-cloud-gcp/pull/2302

True! @dzou Can you revert this?

Nice catch @eddumelendez ! Will revert. Thanks for the heads up.


add panasonic viera tv media player device

Description:
This PR creates adds support for the Panasonic Viera TV platform.
Related issue (if applicable): #
Example entry for configuration.yaml (if applicable):

Checklist:

[x] Local tests with tox run successfully.
[x] TravisCI does not fail. Your PR cannot be merged unless CI is green!
[x] Fork is up to date and was rebased on the dev branch before creating the PR.
[x] Commits have been squashed.
If code communicates with devices:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

I don't read the code, but is it able to check if the tv is off? I saw that homebridge was able to check it by request the current volume

Yes, requests to the TV will fail if it is switched off and the state is updated accordingly.

I have updated the PR to the HEAD of dev and squashed the commits.

Looks good! :dolphin: 🎉

Thanks!


Display page headings in application steps, not titles

Before

Unbefore

Review app deployed to https://teaching-vacancies-review-pr-3012.london.cloudapps.digital


Update README to fix a couple of typos

Thank you! I have a blindspot for it's vs. its so this is very much appreciated. 🙇🏻♂


Question about MixerBlock

Hello.
In model.modules.py, input for the the MixerBlock first passes through tokenmixer.
However, in your article, it seems that the input first passes through the channelmixer, not the tokenmixer.
Shouldn't the order of tokenmixer and channelmixer be changed? Did I misunderstood something?

Hello @relions01, thanks for opening this issue. Yes, I believe you are right. Thank you for pointing this out.
As the article has already been published, I don't think it will be possible to update the journal article. However, I will try to update the arXiv article with updated figures when I find time. Thanks again.


Make scroll framerate independent

Currently, the framerate determines the speed, damping, friction etc. This means it's impossible to guess the actual end result people will get, since one person might have 30fps and another 500. High FPS results in very slow scroll with high friction, low FPS results in very fast scroll and less friction.
To reproduce, you can change the max FPS in the project settings (enable advanced) to some small value like 30, then remove the limit and test again.

Issue resolved by #34


Embedded JavaScript files are not loaded

OS: Windows 10 x64 21H1

Programming language: C++, using Visual Studio 2019

What did you expect to see and what you saw instead?
I created a local webserver within my app (using cpp-httplib) and then load the HTML file via that. This works fine and embedded stylesheets are loaded as well.
However, embedded JavaScript files are not loaded.
My HTML file, index.html:
<!DOCTYPE html>

    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Test</title>
    <link rel="stylesheet" href="styles.css">
    <link rel="stylesheet" href="buttons.css">

Hello

And alert.js:
alert("From alert.js");

Do I have to enable some option in the OS which would allow WebView2 to load JavaScript files from within an HTML file?
I ask because I had trouble loading CSS files and then came across a post which mentioned doing this from Admin Command Prompt:
CheckNetIsolation.exe LoopbackExempt -a -n="Microsoft.Win32WebViewHost_cw5n1h2txyewy"
And voila, CSS files started getting loaded.
Am I missing something obvious? Or this is just impossible?

@harikvpy Do you also have this issue if you open the .html file without webview using your regular browser? If so, you might want to modify your alert.js to the following:
window.addEventListener('load', (event) => {
  alert("From alert.js");
});

@nicklasfrahm Noted. I posted that comment when I was evaluating WebView to port an existing Electron app. I gave up on that effort after a month or so after I ran into some minor issues (perhaps early days of WebView -- for the framework and for me). Besides the project timeline did not afford an adventure into the uncharted at that time.
Thanks for following up, eventually!


ReferenceError: event is not defined (this.handleClickOutside)

Firefox, 61.0.2 64-bit
Windows 10
Stops drop down boxes from disappearing.
ReferenceError: event is not defined
	[201]/Select/this.handleClickOutside
https://app.dappywallet.com/app.95fbbe2d2c781bdd444a.js:696:2302

ReferenceError: event is not defined
	[841]/ProfilePopUp/this.handleClickOutside
app.95fbbe2d2c781bdd444a.js:948:144

@MichaelFedora Thanks for your report, we will fix it

@MichaelFedora  fix this bug


finish linking module

Codecov Report

Merging #18 (a33bc41) into master (bb76ff0) will decrease coverage by 4.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   95.05%   90.98%   -4.08%
==========================================
  Files           8       10       +2
  Lines         182      255      +73
==========================================
+ Hits          173      232      +59
- Misses          9       23      +14

see 3 files with indirect coverage changes


dockerTools.buildLayeredImage: layers should have a consistent order

Issue description
In #47411 @grahamc states that layers no longer care about the order that they appear in. This is true for image tarballs, but for images "loaded" into the Docker daemon this depends on what driver you use.
overlay2 (currently the recommended driver) and ·device-mapper (the fallback if overlay2 is unavailable) both use a "snapshot" stack to implement layers, meaning that the whole stack up to that point must match in order for the cache to hit.
The only driver I could find that does not seem to use a snapshot stack is the deprecated aufs (but I haven't been able to verify this, since I don't have any systems with AUFS-enabled kernels).
Steps to reproduce

Create a docker image with some dependencies.

with import <nixpkgs> {};
dockerTools.buildLayeredImage {
    name = "test-image";
    config.Cmd = writeScript "test-script"
      ''
        #!${bash}/bin/bash
        echo hi!
        # Let's add some more dependencies
        ${utillinux}/bin/lscpu
      '';
    maxLayers = 120;
}

Build and load it into the daemon (docker load -i $(nix-build --no-out-link)).
Make some trivial change to the image (such as changing the message from hi! to hey!)
Rebuild and reload the image

Expected: Two layers are loaded (the "top" derivation layer and the customization layer), while the rest are reused.
Actual: Almost all layers are reloaded, since the shared snapshot stack is very small.
Technical details

system: "x86_64-linux"
host os: Linux 4.20.0-arch1-1-ARCH, Arch Linux, noversion
multi-user?: no
sandbox: no
version: nix-env (Nix) 2.1.3
channels(teo): "nixpkgs-19.03pre164887.4001dd679f3"
nixpkgs: /home/teo/.nix-defexpr/channels/nixpkgs

Guess: the problem may reside in referencesByPopularity.
With the following expression:
{
  nixpkgs ? import <nixpkgs> {}
}:

with nixpkgs;

let
  content = symlinkJoin {
    name = "xx";
    paths = [
      bashInteractive
      curl
      python37
    ];
  };

  closure = writeText "closure" "${content}";
in referencesByPopularity closure

If I add python37Packages.pip and python37Packages.setuptools to paths, we can get the diff as below:
--- before     2019-02-05 21:43:37.000000000 +0800
+++ after     2019-02-05 21:43:41.000000000 +0800
@@ -1,23 +1,25 @@
 /nix/store/fivq0nbggp4y8mhy3ixprqd7qyn1hy2j-glibc-2.27
 /nix/store/5dphwv1xs46n0qbhynny2lbhmx4xh1fc-zlib-1.2.11
-/nix/store/vs6d2fjkl4kb3jb7rwibsd76k9v2n4xy-bash-4.4-p23
 /nix/store/mi5krns5p204a3rdn1rj4ajnbqn2809i-ncurses-6.1-20181027
+/nix/store/vs6d2fjkl4kb3jb7rwibsd76k9v2n4xy-bash-4.4-p23
 /nix/store/kimqdijh6r0p8d6if8xacnijl2y4ngw5-openssl-1.0.2q
-/nix/store/s5xxfanirj8qya8aly5wwdr7b1v1bbm9-keyutils-1.6-lib
-/nix/store/hia576lm5gb8djx8pbm2lgi3q6c0kdyn-libkrb5-1.15.2
-/nix/store/ji88gwzzif3l2nplg94a615j9krh4l8m-libssh2-1.8.0
-/nix/store/447z0cjmylc3ija9b20xvvwrwkhn8nhh-nghttp2-1.35.1-lib
 /nix/store/cvjhg4cha0yh7gi2sxf31wk3h5y1s68n-bzip2-<IP_ADDRESS>.1
-/nix/store/7a19dg5dczka2yv0ai618dznvi0r6563-curl-7.63.0
 /nix/store/hqmmss40v9iqpwpmv9bgfb1kz9gaxp3z-expat-2.2.6
 /nix/store/8i618nqrx7q6zphbnn9gpkg9k3cv7iq1-gdbm-1.18.1
 /nix/store/qwmw5ddw8lk2pz4fy3irp87vj1cawvjh-libffi-3.2.1
 /nix/store/ycg4d6l6kinq7xkf687ddfvddjiwnwsr-readline-6.3p08
-/nix/store/1f4cikmcp49zs9xsl3h7km9j0var9jhx-readline-7.0p5
 /nix/store/qpa2x9g7xhmhfd12z8lrb830zidbw1b0-sqlite-3.26.0
 /nix/store/bfnknhn58j0z8sdi1980y1rbmcw61v73-xz-5.2.4
+/nix/store/ydk0mfpvn9smcmn72wc9i20slv1d2b79-python3-3.7.2
+/nix/store/s5xxfanirj8qya8aly5wwdr7b1v1bbm9-keyutils-1.6-lib
+/nix/store/hia576lm5gb8djx8pbm2lgi3q6c0kdyn-libkrb5-1.15.2
+/nix/store/ji88gwzzif3l2nplg94a615j9krh4l8m-libssh2-1.8.0
+/nix/store/447z0cjmylc3ija9b20xvvwrwkhn8nhh-nghttp2-1.35.1-lib
+/nix/store/x54cj2603lvj6y5fmpkg7x0hvad8kp85-python3.7-setuptools-40.6.2
+/nix/store/7a19dg5dczka2yv0ai618dznvi0r6563-curl-7.63.0
+/nix/store/1f4cikmcp49zs9xsl3h7km9j0var9jhx-readline-7.0p5
 /nix/store/00aqq7zm73ca5rck3k4yf4z339lxzy2w-bash-interactive-4.4-p23
 /nix/store/k9c8xfqp467nk1b2ijagqsvczx0v1dq7-curl-7.63.0-bin
-/nix/store/ydk0mfpvn9smcmn72wc9i20slv1d2b79-python3-3.7.2
-/nix/store/6vkjbkzfhi0znhj7bvihfcg2a3j324ny-xx
-/nix/store/bb84sazs3429sjnbvq203586k14sg71h-closure
+/nix/store/qmd9d1f419lxkg0mr2wdg7cv1y8h31fm-python3.7-pip-18.1
+/nix/store/2psfxz41m4fc7zw3sj1yzm7424r5h463-xx
+/nix/store/p374d8a6hb19i3a9hv0aymm4mba8h5nw-closure

At the very least, /nix/store/vs6d2fjkl4kb3jb7rwibsd76k9v2n4xy-bash-4.4-p23 should not be reordered after I add these two paths.

They are reordered because the popularity weights change.

On Feb 5, 2019, at 08:54, Limbo Peng<EMAIL_ADDRESS>wrote:
Guess: the problem may reside in referencesByPopularity.
With the following expression:
{
nixpkgs ? import  {}
}:
with nixpkgs;
let
content = symlinkJoin {
name = "xx";
paths = [
bashInteractive
curl
python37
];
};
closure = writeText "closure" "${content}";
in referencesByPopularity closure
If I add python37Packages.pip and python37Packages.setuptools to paths, we can get the diff as below:
--- before     2019-02-05 21:43:37.000000000 +0800
+++ after     2019-02-05 21:43:41.000000000 +0800
@@ -1,23 +1,25 @@
/nix/store/fivq0nbggp4y8mhy3ixprqd7qyn1hy2j-glibc-2.27
/nix/store/5dphwv1xs46n0qbhynny2lbhmx4xh1fc-zlib-1.2.11
-/nix/store/vs6d2fjkl4kb3jb7rwibsd76k9v2n4xy-bash-4.4-p23
/nix/store/mi5krns5p204a3rdn1rj4ajnbqn2809i-ncurses-6.1-20181027
+/nix/store/vs6d2fjkl4kb3jb7rwibsd76k9v2n4xy-bash-4.4-p23
/nix/store/kimqdijh6r0p8d6if8xacnijl2y4ngw5-openssl-1.0.2q
-/nix/store/s5xxfanirj8qya8aly5wwdr7b1v1bbm9-keyutils-1.6-lib
-/nix/store/hia576lm5gb8djx8pbm2lgi3q6c0kdyn-libkrb5-1.15.2
-/nix/store/ji88gwzzif3l2nplg94a615j9krh4l8m-libssh2-1.8.0
-/nix/store/447z0cjmylc3ija9b20xvvwrwkhn8nhh-nghttp2-1.35.1-lib
/nix/store/cvjhg4cha0yh7gi2sxf31wk3h5y1s68n-bzip2-<IP_ADDRESS>.1
-/nix/store/7a19dg5dczka2yv0ai618dznvi0r6563-curl-7.63.0
/nix/store/hqmmss40v9iqpwpmv9bgfb1kz9gaxp3z-expat-2.2.6
/nix/store/8i618nqrx7q6zphbnn9gpkg9k3cv7iq1-gdbm-1.18.1
/nix/store/qwmw5ddw8lk2pz4fy3irp87vj1cawvjh-libffi-3.2.1
/nix/store/ycg4d6l6kinq7xkf687ddfvddjiwnwsr-readline-6.3p08
-/nix/store/1f4cikmcp49zs9xsl3h7km9j0var9jhx-readline-7.0p5
/nix/store/qpa2x9g7xhmhfd12z8lrb830zidbw1b0-sqlite-3.26.0
/nix/store/bfnknhn58j0z8sdi1980y1rbmcw61v73-xz-5.2.4
+/nix/store/ydk0mfpvn9smcmn72wc9i20slv1d2b79-python3-3.7.2
+/nix/store/s5xxfanirj8qya8aly5wwdr7b1v1bbm9-keyutils-1.6-lib
+/nix/store/hia576lm5gb8djx8pbm2lgi3q6c0kdyn-libkrb5-1.15.2
+/nix/store/ji88gwzzif3l2nplg94a615j9krh4l8m-libssh2-1.8.0
+/nix/store/447z0cjmylc3ija9b20xvvwrwkhn8nhh-nghttp2-1.35.1-lib
+/nix/store/x54cj2603lvj6y5fmpkg7x0hvad8kp85-python3.7-setuptools-40.6.2
+/nix/store/7a19dg5dczka2yv0ai618dznvi0r6563-curl-7.63.0
+/nix/store/1f4cikmcp49zs9xsl3h7km9j0var9jhx-readline-7.0p5
/nix/store/00aqq7zm73ca5rck3k4yf4z339lxzy2w-bash-interactive-4.4-p23
/nix/store/k9c8xfqp467nk1b2ijagqsvczx0v1dq7-curl-7.63.0-bin
-/nix/store/ydk0mfpvn9smcmn72wc9i20slv1d2b79-python3-3.7.2
-/nix/store/6vkjbkzfhi0znhj7bvihfcg2a3j324ny-xx
-/nix/store/bb84sazs3429sjnbvq203586k14sg71h-closure
+/nix/store/qmd9d1f419lxkg0mr2wdg7cv1y8h31fm-python3.7-pip-18.1
+/nix/store/2psfxz41m4fc7zw3sj1yzm7424r5h463-xx
+/nix/store/p374d8a6hb19i3a9hv0aymm4mba8h5nw-closure
At the very least, /nix/store/vs6d2fjkl4kb3jb7rwibsd76k9v2n4xy-bash-4.4-p23 should not be reordered after I add these two paths.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I am not sure how this relates to the amount of data being uploaded to a registry, but when I make a one character change, the upload process still uploads the size of the image. (checked via bandwidth monitoring tools).
My expectation is that only a single layer would be uploaded.

@memberbetty: What tool (and version) do you use to upload the images? IIRC, docker push will check for dupe layers before loading, but docker load won't. Skopeo will check both Daemon and Registry targets, but only in very recent versions (0.1.33 and later, I think).

@teozkr docker push
Docker version 18.09.2, build 62479626f213818ba5b4565105a05277308587d5

I am running into the same problem, some containers share a 3GB data file. In the generated tarball, they have the same hashes. But there is no layer sharing after a docker load, nor after docker pushing the resulting images to Docker Hub. Tested with the device-mapper and overlay2 storage drivers.

Found the culprit and submitted a PR: #62719.

Fixed by the merged PR #62719.
@danieldk tip: you can add Fixes #ISSUE in your commit message to automatically close issues (see https://github.blog/2013-01-22-closing-issues-via-commit-messages/).
Thanks.

@nlewo That's a different issue (although it is a prerequisite for this issue's relevance). #62719 ensures that layer tarballs are identical so that the layers are deduplicated at the Docker Registry. However, this issue is about that the Docker Daemon will only deduplicate layers if the whole layer stack up to that point matches, since it doesn't differentiate between the layer diff and the merged overlay.


feat: Add websocket proxy server, refine socket client

todo:
[x] Add socket proxy server
[x] Refactor socket client event emitter with mitt

solve #800


Avoid symlink tests/fixtures

Where does the symbolic link tests/fixtures point to?
During cloning, this causes:
Cloning into 'mistral-finetune'...
remote: Enumerating objects: 121, done.
remote: Counting objects: 100% (121/121), done.
remote: Compressing objects: 100% (92/92), done.
remote: Total 121 (delta 42), reused 91 (delta 25), pack-reused 0
Receiving objects: 100% (121/121), 109.86 KiB | 3.14 MiB/s, done.
Resolving deltas: 100% (42/42), done.
error: unable to create symlink tests/fixtures: No such file or directory
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Thanks for spotting! This was indeed badly designed. Put it in the .gitignore file for now. Will soon updated with better, actual fixture.
cc https://github.com/mistralai/mistral-finetune/pull/19


[HIP] CUDA identifier is unsupported in HIP.

I don't know whether this should be a github issue or not, but what is the policy on unimplemented CUDA identifiers in HIP?
Here are a few which I've encountered:
 warning: CUDA identifier is unsupported in HIP:
   cudaMemoryTypeManaged,
   cudaMemAdvise,
   cudaMemAdviseSetAccessedBy,
   cudaCpuDeviceId,
   cudaMemPrefetchAsync,
   cudaStreamPerThread,
   cudaLimitStackSize

Are these on the roadmap?
Also, if these do not make it into hipify-clang, do they have a natural translation into hip?

cudaMemoryTypeManaged is of CUDA 10.0; thus, I believe it is not of the first priority.
@mangupta, @gargrahul,
what about the rest, which all are of CUDA 8.0 or even older?
I'm also interested in the functions cudaMemAdvise / cuMemAdvise with the corresponding data types cudaMemoryAdvise / CUmem_advise.

Closing this ticket as all mentioned unsupported cuda identifiers are implemented in HIP now.


SIANXSVC-1192: Updated GitHub action path in the publish action

go.anx.io moved to the "anexia" GitHub organisation. Updated the publish action accordingly in this PR.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (39d08e2) 68.75% compared to head (3cf254c) 68.75%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   68.75%   68.75%
=======================================
  Files           4        4
  Lines         128      128
=======================================
  Hits           88       88
  Misses         32       32
  Partials        8        8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Album Art Added In App Puts Mini Player In Bad State

OS: Windows 10
Issue Descriptions:  Album Art Added In App Does Not Populate In Mini Player
Steps to Reproduce:

Navigate to a playlist that has a song with no album art.
Right click the song and click 'Edit Info'
Hover over the Album Art section and click 'Change'
Browse to and select an image.
Click 'Save'
Play the song.
Click the Mini Player button

Result: The album art and song information is not displayed for the song in the mini player.
Notes: I've also had it break album art and song information for the song previous to the song changed in a playlist.

Ha! I was just about to report a related issue. When a song comes up in the mini player that doesn't have any album artwork at all, it continues to display the artwork from the previous song.

It should be pulling in an orange default album art. I'll investigate
further if @marshallofsound doesnt get to it first.
On Jul 5, 2016 2:09 PM, "Noah Andrews"<EMAIL_ADDRESS>wrote:

Ha! I was just about to report a related issue. When a song comes up in
the mini player that doesn't have any album artwork at all, it continues to
display the artwork from the previous song.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/1278#issuecomment-230556659,
or mute the thread
https://github.com/notifications/unsubscribe/AAucnZTxmTuN7Xv9yU-6kZCXWQJyOl-Cks5qSp3DgaJpZM4JFWsH
.

@jostrander
I've had it do that in relation to this issue, but it will also break and not display song information (Title/Artist).

It should be pulling in an orange default album art. I'll investigate
further if @marshallofsound doesnt get to it first.

Does it break anything in the full player, or mini player only?
On Jul 5, 2016 2:15 PM, "Cistoran"<EMAIL_ADDRESS>wrote:

@jostrander https://github.com/jostrander
I've had it do that in relation to this issue, but it will also break and
not display song information (Title/Artist).
It should be pulling in an orange default album art. I'll investigate
further if @marshallofsound https://github.com/marshallofsound doesnt
get to it first.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/1278#issuecomment-230558418,
or mute the thread
https://github.com/notifications/unsubscribe/AAucnQTVsh_uOhHeRbyTVAVnuMjNjX5Iks5qSp9FgaJpZM4JFWsH
.

As far as I can tell, it only breaks things in the mini player.

Hey guys,

I confirmed that the orange art is pulled in when the song doesn't have an albumArt
The steps to reproduce don't obviously "break" anything.  The mini player still works normally.

This sounds suspicously like

I tried to upload a new album art but it ruined my tracks metadata instead

This is nothing to do with GPMDP 👍 We don't manage the metadata or change the albumArt, that is all handled by Google.  If when you upload the image something goes wrong that is on their side not ours.


cover.rfxtrx stops sending signals

Home Assistant release with the issue:
0.78.1
Last working Home Assistant release (if known):
0.77.3
Operating environment (Hass.io/Docker/Windows/etc.):
HassOS 1.10
Component/platform:
https://www.home-assistant.io/components/rfxtrx/
https://www.home-assistant.io/components/cover.rfxtrx/
Description of problem:
Nothing happens then sending signals to open/close cover.
No errorrs in logs.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
rfxtrx:
  device: /dev/ttyUSB0
  debug: true

cover:
  - platform: rfxtrx
    automatic_add: False
    signal_repetitions: 8
    devices:
<PHONE_NUMBER>0101120000:
        name: Bedroom

I thought the same but just found out the signals is switched! So upwards is down and down is up...
Saw this at the forums:
https://community.home-assistant.io/t/rfxtrx-covers-now-reversed-in-0-78/69261/4

Creating template cover is obviously not a solution here. Guys, can we do something about this problem? I'm dangerously getting used to saying "Open covers" when I want to close them ;-)
@Danielhiversen , @balloob - maybe you can take a look what might got messed up there?
Much appreciate your work!

I still use the "cover.close_cover" to open and "cover.open_cover" to close my covers.

hopping this gets resolved soon

Hi,
I have the same issue, seems to be related to pyRFXtrx where open/close are hard coded for all "RollerTrol" blinds (type 0x19):
https://github.com/Danielhiversen/pyRFXtrx/blob/1909fa5c2e9379ca54d5c23dbd9bf75a27d3ad39/RFXtrx/__init__.py#L81
Compared to node-rfxcom, which has many subtypes for blinds (T0, T1, T2...) and also has BLINDS_OPEN and BLINDS_DOWN with the same code 0x00 while the latter would close the blinds:
https://github.com/rfxcom/node-rfxcom/blob/0af6a44dc171e34bac18ae4d581bfec8e61aa882/lib/defines.js#L29
Hope it helps!

Any update on this matter?

i got used to push the close button to open the blinds,
Little bit annoying, but okay i could work with this.
but now trying out the cloud service,
....saying google close all blinds.
to open them this isn't going to work for me..
so no paid cloud service for me till this get fixed..

For now i solved it with a template, maybe also a solution for you @marcootjehhh with that voice is working again with GH (just need to hide the standard entity). But i also prefer to have this solved at the core instead of multiple template's

platform: template
covers:
rolluiken_bureau:
friendly_name: 'Rolluiken Bureau'
optimistic: false
open_cover:
service: cover.close_cover
data:
entity_id: cover.rolluiken_bureau_control
stop_cover:
service: cover.stop_cover
data:
entity_id: cover.rolluiken_bureau_control
close_cover:
service: cover.open_cover
data:
entity_id: cover.rolluiken_bureau_control

Any updates on the issue? Experiencing the same..
The trick doesn't seem to work anymore? Using below config the buttons are still incorrectly showing up/down. Using HA 0.96.5
`cover:

platform: rfxtrx
automatic_add: false
devices:
09190603903002410000:
name: Brel Left

platform: template
covers:
brel_left:
friendly_name: "Brel Left"
optimistic: false
open_cover:
service: cover.close_cover
data:
entity_id: cover.brel_left
stop_cover:
service: cover.stop_cover
data:
entity_id: cover.brel_left
close_cover:
service: cover.open_cover
data:
entity_id: cover.brel_left`

I found another way to fix this instead of creating a template.

Create the folder structure custom_components/rfxtrx into /config.
Copy all the files from the rfxtrx component into custom_components/rfxtrx
Edit cover.py and replace:

   def open_cover(self, **kwargs):
        """Move the cover up."""
        self._send_command("roll_up")

    def close_cover(self, **kwargs):
        """Move the cover down."""
        self._send_command("roll_down")

by
   def open_cover(self, **kwargs):
        """Move the cover up."""
        self._send_command("roll_down")

    def close_cover(self, **kwargs):
        """Move the cover down."""
        self._send_command("roll_up")

I believe this is the commit that broke it for me: https://github.com/Danielhiversen/pyRFXtrx/commit/fefde970dbec7d5a038642819764ac72ca989b11
switching those values back fixes it for me

@HerbDavisY2K  Any comment?

I think we should make it a config option (whether to reverse direction of the blinds) and have it be configurable through home assistant's rfxtrx integration

a reverse option would be perfect.
I got the solution from https://github.com/home-assistant/home-assistant/issues/16788#issuecomment-524471850 working

is there any update? Can we merge in https://github.com/Danielhiversen/pyRFXtrx/pull/87 with fix?

I asked Daniel and he merged it and released 0.25.0 of pyRFXtrx. The version of pyRFXtrx should be updated in HA to use 0.25.0 of course to make use of this. Personally, I don't have a cover device, so someone else with a cover device should test it and make a PR.


FSDPMixedPrecision setting, Logit norm growth, z-loss.

❓ The question
Hi all,
why did you reduce the gradients in float32 as reported in section 3.1 in the OLMo paper?
We have made some experiments on this and observed that when setting the reduce_dtype=bfloat16 for training setups with more than 4 nodes causes the output logit norm to grow.
I am curious, did you make a similar observation? Did you track the output logit norm during training?
More concretely, during training our models we also observed a growth of the output logit norm which lead to Infs in our PPL metrics (NOT in the loss, loss was still fine) at some point later in training.
Even though we observed that we could mitigate this adding by a regularizing loss that pushes down the output logits, we tried do avoid using such a loss similar to the z-loss as suggested by the PaLM paper.
Instead we investigated PyTorch FSDP Mixed Precision settings, as we suspected bfloat16 to cause issues here.
We trained two Transformer like models of size 125M and 1.3B on next-token-prediction on 4, 16 and 32 nodes (see below).
We trained for approx. 10k steps with the hyperparameters specified below.
Note: drd corresponds to the reduce_dtype setting of FSDPMixedPrecision
Experiment 1:
A model with 125M parameters trained on 4 Nodes and 16 Nodes and both with reduce_dtype=bfloat16.
As sharding strategy we use NO_SHARD.
Brown:  B24E768gbs256--s-NO_SHARD-nn-16-drd-bfloat16-sn-125M-utc-1-l-0.0003-wd-0.1-nb-24-ed-768-seed-42
Blue:   B24E768gbs256--s-NO_SHARD-nn-4 -drd-bfloat16-sn-125M-utc-1-l-0.0003-wd-0.1-nb-24-ed-768-seed-0

Experiment 2:
A model with 1_3B parameters trained on 32 Nodes with DDP, FSDP NO_SHARD reduce_dtype=float32 and FSDP NO_SHARD reduce_dtype=bfloat16.
We compare FSDP with sharding strategy NO_SHARD to DDP.
Grey:   B48E2048gbs512--s-NO_SHARD    -nn-32-drd-float32 -sn-1_3B-utc-1-l-0.0002-wd-0.1-nb-48-ed-2048-seed-42
Red:    B48E2048gbs512--s-DDP         -nn-32-drd-bfloat16-sn-1_3B-utc-1-l-0.0002-wd-0.1-nb-48-ed-2048-seed-42
Green:  B48E2048gbs512--s-NO_SHARD    -nn-32-drd-bfloat16-sn-1_3B-utc-1-l-0.0002-wd-0.1-nb-48-ed-2048-seed-42

We observe that setting reduce_dtype=bfloat16 for training setups with more than 4 nodes causes the output logit norm to grow.
When training with FSDP, setting reduce_dtype=float32 or training with DDP (we think that DDP also reduces gradients in float32) the output logit norm did not grow.
In other experiments we even observed that the growth of the output logit norm scales roughly linear with the number of nodes (when using reduce_dtype=float32)
The tricky thing is that this behavior is not visible in the loss (see screenshots), so it is hard to track down this issue to FSDP Mixed Precision.
We think this is a severe issue that needs more investigation, since the reduce dtype has a major impact on training speed and one would actually prefer bfloat16 for higher training throughput.

We did not carefully experiment with this. On our hardware, it makes no difference whether the reduction is in 32 bit or 16 bit, so we chose the safe option.
In general though, cases where reduced precision leads to instabilities, or even just different model behavior, are always interesting! The problem is that many of the real instabilities or divergences don't happen until late in training and/or with big models.


help with installation

can anyone just make a video tutorial on this? i dont understand anything and i dont know what i am doing.

are you using windows or linux?
the best i can do is interpret the steps for u and guide u
there are video tutorials, but they seem to not be in english, but if they are, they arent really good quality

tbh i dont understand how to install it and i need some help to if i can get some and if you have time

sorry for the late response
there should be a guide for linux in the Wiki. Are you perhaps using windows?

can anyone just make a video tutorial on this? i dont understand anything and i dont know what i am doing.

tbh i dont understand how to install it and i need some help to if i can get some and if you have time

I know this is a super late response, but I put together a step-by-step guides (with pictures) here.
In case anyone will find it useful.


Change init signature

Change fn init(allocator: Allocator) !MyType to fn init(self: *MyType, allocator: Allocator) !void allowing in-place initialization.
Best reviewed per commit.

Would be good to work-in the "why?" into commit message (preferable), or PR description!
I think the primary motivation here is to reduce stack space utilization, but this isn't obvious from the relevant commit messages


add temporal extent support to WMS harvesting

For WMS layers which support Extent/@time, map to pycsw:TempExtent_begin and pycsw:TempExtent_end in support of temporal GetRecords queries.

Fixed in master and 1.10 branch.


Add support for full screen video (#447)

Adds support for videos to go full screen based on the solution from here
Have tested on emulator and my Pixel 2 XL

Hi @a-jackson,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

This will close #447
@a-jackson can you confirm if this will also closes #267? I have a feeling the 2 are interlinked by not having full screen enabled in the video player.

@dshokouhi
Fullscreen video and pip are two different issues.
This just enable fullscreen option in video
I tried to have pip and it works like chrome, except that the pip window displays the entire original video in full screen (with black bands, which is not good in vertical orientation) and not only the video

No it doesn't support picture in picture. It looks like there's some more work for that. I found this https://developer.android.com/guide/topics/ui/picture-in-picture but I'm not very experienced with Android devevelopment. I think it was Android 4 the last time I did any, a lot has changed 😄

@JBassett thanks for the review. I've made the changes requested and rebased due to some merge conflicts. You're right ViewFlipper is much cleaner, I didn't know it existed 😄

So it looks like @neopilou got both full screen and PiP implemented in his PR: https://github.com/home-assistant/home-assistant-android/pull/471  Since his covers both cases I'm going to merge his in this case.


Add "in progress" option to status options

I noticed there is only a complete and incomplete option when choosing a status for tasks. I think adding an in progress option could be useful for larger tasks, and better organization of a larger list of tasks. I would also be able to do it myself. Thanks!

Hello! Could you please assign this to me so that I can work on it? Also please add the "hacktoberfest" label on it so that I can get a credit towards it. Thanks!

Hello! Could you please assign this to me so that I can work on it? Also please add the "hacktoberfest" label on it so that I can get a credit towards it. Thanks!

I was hoping that I could tackle this one, given that it is my suggestion. Perhaps, we can let @SauveJeanLuc decide?

a

Don't you think that it's going to ruin the app's simplicity in some ways?
Do you have a creative approach that will lead to the user not having a long list of status to choose ?

Oops, my bad! I misunderstood.
Please work on your idea, I will look for something else.

I think having a third option wouldn't decrease simplicity much. The statuses of "complete", "incomplete", and "in progress" cover every possibility so there is no chance of complexity creep either. Perhaps we could have the order of the tasks auto sort by status? I'm not sold on this solution but it may keep complexity at a minimum


EMI compatibility

Would be cool to have EMI compatibility.

It would, but you can install JEI alongside EMI and EMI will disable it but steal the recipes from it.
Works perfrctly for this mod.


[ClangImporter] Hack. Break deserialization cycle with NSErrorPointer on iOS and watchOS.

Addresses rdar://problem/32226279 .
I haven't yet worked out why this is only occurring on iOS and watchOS, and this is completely not the right long-term fix.

This is gross :(

I think this'll change how we import NSError ** when we can't turn it into throws, which means we need to come up with something a little better here.

Sorry, I skipped a step: good working tracking this down! I'm curious about which declaration is causing the cycle too, but that might not be something we can post on GitHub.

@swift-ci smoke test

Wrote a comment on rdar://problem/32226279 ; move discussion there?

@swift-ci please smoke test

@huonw please file an SR for the less hacky solution

@jrose-apple should this be nominated for the 4.0 branch?

Yes, I think so.

I will nominate this

Thanks, Michael!

@jrose-apple Could you or @huonw help me fill in the explanation, scope, and risk?


cJSON: Update to get rid of memory bug

cJSON 1.6.0 contains a bug causing a too small buffer being allocated, this has been fxed in 1.7.1.
https://github.com/DaveGamble/cJSON/compare/v1.6.0...master#diff-f81629e70775a711645d6df20d975bf5L1118

Thanks for the heads-up! I think a few people have been reporting issues around this. Will update.


Not working in IOS

This code is working perfectly under Android, but not in IOS. in IOS has a problem when dragging.

Should add canCancelContentTouches={false} to the ScrollView in SortList.js will solve the dragging problem for IOS.


Add link to interactive book of spinal cord morphometry in PAM50 space

See article from @valosekj "A database of the healthy human spinal cord morphometry in the PAM50 template space"

Where precisely the link should be added? To this GitHub repo or https://spine-generic.readthedocs.io/index.html?

The link to preprint with interactive figures: https://preprint.neurolibre.org/10.55458/neurolibre.00017/


Execution slowdown

https://github.com/Hickles02/FYP478/blob/f68b061bbf074829398c81c950a77d25ed83e758/MATLAB/simulate_ODEs.m#L20-L26
Note: MM(1:4) are dependent variables for MM1-MM4. MM(5:10) are dependent variables for X1-X4, XB, XD, respectively.

Updated code, new issue raised.


Latency-aware fetch pack target selection

Use the new latency-aware scoring scheme to select the peer we request a fetch pack from.

Have reviewed.  My only comment is one that Nik already made: Please add override to PeerImp::getScore.

Added minor clean up and commenting.  Also rebased against the current develop, necessitating a forced-push.
@nbougalis , @vinniefalco , @JoelKatz please review, thanks.

Howard, you may want to force-push again, reordering the commits, so that the [FOLD] comes under "Latency-aware fetch pack target selection" so when fold it right.

:+1:

Reordered commits per Nik's comment above (hope I did it right!).

Yep, looks good!

:+1:

Very pretty. I'm surprised we're not making a bigger deal out of the potential to get history faster since we're only considering peers that have the range we want.
:+1:


Updates

This resolves #5, as well as making some other changes. In particular, switching the count type from usize to u64. A primary use case for this kind of progress bar is for file transfers, and there's no reason it shouldn't be possible to transfer a file larger than 4GB on a 32 bit system.

Thanks for the PR @sfackler, it looks good!
I'll publish a new version today.


Support for FieldMask with get on transaction

A simple get on a document supports limiting fields with a FieldMask. However, there is no parity for this with a get on a transaction. This would be useful on a transactional get to minimize data transfer.

Thanks for the feature request! This would be helpful indeed, we do not consider this urgent and will add to our to-do list for the future. So maybe don't hold your breath :-)


[TASK] Make DISPATCHES an optional dependency for HERON

Issue Description
Is your feature request related to a problem? Please describe.
Since DISPATCHES is an optional workflow, the package should also be optionally installed during the HERON installation. HERON should additionally check that DISPATCHES is properly installed in the conda environment before running the DISPATCHES workflow.
Describe the solution you'd like
Describe alternatives you've considered

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or task?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

Issue is approved to close via #222


MAC - need fresh start

I have been having some issues with the MAC app and I have been trying to do a fresh start, but for whatever reason when I try to do a delete and a re-install, it retains all of the old information and changes. I have not been able to do a complete fresh start as if it was never installed. Anyone have any suggestions on how to clear this up?

Delete this folder
harddrive>Users>username>Library>Application Support>pokemon-go-map
That should clear out any old data.

it did and I was able to reload it, but I keep receiving the following error when I enable mobile and open it up on my phone:


add OpenBSD support

Hello.
add some defines to build ctpp on OpenBSD
Best Regards, Ilya Pavlov

Also I add MinGW support and fix error: gethostname return !0 on some windows (on my WindowsXP SP3) platform.


[TB] Homepage left nav - Accessibility Insights - WCAG 1.3.1: Ensures that lists are structured correctly (ul)

Problem/Concern
When running Accessibility Insights for Web's automated checker on the homepage, the following issue occurs:
Issue
Ensures that lists are structured correctly (list)
Target application
A11y ThemeBuilder
Element path
ul
Snippet
<ul class="MuiList-root MuiList-padding css-14945rh">
How to fix
Fix all of the following:
  List element has direct children that are not allowed: [role=button]

Environment
Microsoft Edge version <IP_ADDRESS>
This accessibility issue was found using Accessibility Insights for Web 2.41.0 (axe-core 4.7.2), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.
Screenshot

Proposed Solution
Likely need to fix structure so that direct children are <li> elements, e.g. wrap the left nav buttons in <li> elems

i wanted to work on this


Bodyparser branch rewrite

Parsers for both multipart and form-encoded form POST handlers implemented.
The API is geared towards handling file uploads and other large data items, and require the fields to be handled sequentially.
An example program that allows uploading, downloading and editing (for text files) is supplied.

Sorry for the delay.
I did some minor style-related changes (mostly using only spaces for indentation and explicit if-blocks).
Currently, I'm having some trouble with the URL-encoded parser during POST to edit a file. It stops parsing after a few hundred characters, the file is truncated and I get this in the log:
[HTTPS:I:     87460] New connection. Socket FID=59
[HTTPS:I:     89271] Request: POST /edit?filename=test.txt (FID=59)
[HTTPS:W:     89298] Callback function did not parse full request body

I'll have a look at it and try to fix it. Other than that, the parsers seem to work quite well.

The problem is this block. Adding a log statement makes it visible:
size_t readchars = _request->readChars(bodyBuffer, bodyLength);
HTTPS_LOGI("Got %u chars, wanted %u chars.", readchars, bodyLength);

[HTTPS:I:     59535] Request: POST /edit?filename=test.txt (FID=57)
[HTTPS:I:     59541] Got 512 chars, wanted 7612 chars.
[HTTPS:W:     59561] Callback function did not parse full request body

As the internal buffer of the HTTPRequest is limited to 512 bytes, you won't get more there without reading again. So if the url-encoded content of the text field is bigger than that, the remaining body will never be parsed.
Furthermore, relying on knowing the size will break if you don't have the final request length, e.g., if content-encoding: chunked is used.

You're right (of course:-).
I have the feeling that worrying about chunked content may be a bit much (I cannot imagine any implementation in their right mind using chunked encoding together with a url-encoded form... Or am I oversimplifying the world and might this happen because lower layers would select chunked encoding in some implementation?).
So a simple while loop around the readChars should do the trick.
I can add and test, but it may be a week or two before I get around to it so feel free to do it yourself if you think its a good idea.

I wouldn't expect desktop browsers using chunked encoding either, but other clients may. Imagine using a Python script to send data that you generate on the fly, then the HTTP client lib would have to buffer everything or switch to chunked transfer encoding.
But chunked transfer isn't currently implemented anyway. My main concern is only not to rely on Content-Length being present, as that cannot be guaranteed.

So a simple while loop around the readChars should do the trick.

Tried that already, but then you get to the problem that there is no 1:1 representation between input and output bytes and you might read chunks like %2 and 0 instead of %20, and urlDecode() isn't able to cope with that.
I started by writing a second variant for urlDecode which a) works on byte buffers and b) can tell the caller that not all bytes have been processed, quite similar to what I've suggested in the issue linked above. Seems like we don't get around that. I think from there it's not much more work, so I can do that.
And you're right with your comment about buffering, that indeed gets quite excessive. But I think that's a problem of the lower layers (HTTPConnection etc.), and has to be resolved there.
I wouldn't put that into this PR, however, there are some very low-hanging fruits for performance improvement (e.g. this not being at least a memcpy). I'm currently trying to combine hardware-based CI with GitHub Actions. Once that's ready, it'll be much easier to work on the code without breaking things.

Tried that already, but then you get to the problem that there is no 1:1 representation between input and output bytes and you might read chunks like %2 and 0 instead of %20, and urlDecode() isn't able to cope with that

I had a similar issue with the boundary-detection in the multipart reader (you may have CR LF at the end of the buffer but you shouldn't read them until you're sure they're not part of a boundary marker). There I solved it (I hope:-) by never consuming to end-of-buffer, at least not until I know that all data has been read. A similar scheme could be used here, by having the consumer only read at most len()-3 bytes from the buffer until we know that end-of-buffer coincides with end-of-data.

I've implemented reading the whole body into a malloc()ed buffer (either knowing the length or not knowing it). This isn't the most efficient implementation, but I didn't want to go all-out and implement the buffering scheme. And the inefficiency is only an issue if someone builds a website/webserver that transmits large volumes of data through an url encoded POST, and you shouldn't do that:-)

Sorry again for the delay, I'll give it a review asap. I just wanted to have a rudimentary test script in place before, as it eases checking PRs a lot.

If I didn't miss anything, only the comment regarding handling a NULL return value for malloc and realloc in HTTPMultipartBodyParser.cpp remains. With that being fixed, the PR is ready to merge.

Overlooked that one, sorry. Fixed.


StorageV2 not available in selector

Is it possible to make StorageV2 an option in the drop down menu for the selector?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d419a61-a8ac-c3b6-5a09-1a21197519d3
Version Independent ID: 9378b776-1850-ea26-c326-b79c2c65da71
Content: Azure StorageAccountSelector UI element
Content Source: articles/managed-applications/microsoft-storage-storageaccountselector.md
Service: azure-resource-manager
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@ambakshi Thanks for the feedback. We are actively investigating and will get back to you soon.

@ambakshi  Sincere apologies for the delayed response and thanks again for your valuable feedback. Good news is that we have an established channel that allows you to share feedback on feature or service improvements directly with the engineering teams responsible for building these features. Please copy/paste your feedback HERE and don't hesitate to ping if you have any follow-up questions. Will now close this issue.


Align standards and formats across all charts

Each of the Sigstore Helm charts has its own lineage and may not have the same standards and format holistically as others. Seek to define and provide alignment amongst all Sigstore charts.
Acceptance criteria:

All charts offer the same options and parameters so that it's less likely to make mistakes during the configuration

love this idea - we also probably need to make sure that these helm-charts stay general purpose, and things we've found we need added for the public deployment are configurable VS hard coded.

@sabre1041 has been working on a similar initiative. Right @sabre1041 ?

@hectorj2f yup. been throwing some ideas with @flxw in this doc describing the v2 iteration of charts for the project


Unable to Run Lab/03/Work with data.ipynb completely

Module: 00
Lab/Demo: 03
Task: 00
Step: 00
Description of issue: Cannot run the section to read the registered_data_asset using the mltable. I also tried to see what the latest ui of ml studio offers to read. I found this example code, this also won't work.
data_asset = ml_client.data.get("diabetes", version="1")
df = pd.read_csv(data_asset.path)
df
It seems like the mltable is just no installable on Mac M1 machines, neither is azureml-fsspec (which is end of day dependent of dotnetcore2 somehow).
Looking for help, this is import ant for my project.
Repro steps:

Thank you for submitting an issue. The notebook should be run in the Azure Machine Learning workspace using the compute instance. Please follow the instructions as they're stated exactly to avoid these issues.


Which variables can be used -- any variable, or only TargetFramework?

This is rather unclear:
> You can use a condition to control whether a package is included, where conditions can use any MSBuild variable or a variable defined in the targets or props file. However, at presently, only the TargetFramework variable is supported.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ff707668-94d6-25a5-9139-b18cc1b6b446
Version Independent ID: 494847b9-4894-0beb-7ffa-39a2359999fa
Content: NuGet PackageReference format (package references in project files)
Content Source: docs/consume-packages/Package-References-in-Project-Files.md
Product: nuget
GitHub Login: @karann-msft
Microsoft Alias: karann

I have the same question. Could "MSBuild variable" be linked to where those are listed out?
I found the one I was looking for (Env) but don't see it anywhere in the docs. Here is the comment where I found it: https://github.com/NuGet/Home/issues/8741#issuecomment-547220844


Added separateMonthYear option, changes datepicker-switch into two buttons

Added a new option called separateMonthYear (default false) which changes the single datepicker-switch button at the top into two buttons.  The button on the left, which displays the month, directs the user to the month selection mode.  The button on the right, which displays the year, directs the user to the year selection mode.

Hi @louis-wheeler, thanks for the PR! Can you just cleanup some things

Rebase the branch from the current master
Revert the changes in the dist directory (we generate them from time to time in the master)

Thanks!

Reverted changes and re-applied work to files not in dist/ directory.  Rebased onto upstream master, should be up to date unless I slipped up somewhere.

@louiswheeleriv  any plan to accept this PR?
I use this awesome plugin in our project which is a JP UI.
The year/month's position of Japanese and Chinese is different from English.
Japan/Chinese:   (2016年1月)
But English:  (January 2016)
So this feature is very import for non-English UI.

I try the latest 1.5.1, it seems this feature has already be included.
Thanks very much.

@zhoujiealex how has this feature been added?


Increase start timeout

Sometimes on the start page, the timeout shows but the node still starts up successfully. We could increase the start timeout on the frontend to 60 seconds.

Closed by https://github.com/getAlby/hub/pull/773


Add Example for Using Rendering Module in Documentation

This pull request addresses #14 by adding an example demonstrating how to use the qref.experimental.rendering module within the documentation.
Changes Made:

Added a new section to the documentation that includes an alias sampling example of using the qref.experimental.rendering module.

@cla-bot check

@cla-bot check


Table of Contents using :toc:

Does this feature exist in Emacs orgmode?
Yes.
If answer to first question is "Yes", please provide the link to the orgmode manual or any documentation related to the feature
https://orgmode.org/guide/Table-of-Contents.html

This setting is for exporting. As far as I know there's no way to generate TOC as part of org file.
I'm working on export feature in another branch, and this option should work because export is done via emacs.

Exporting is not merged into master. From my tests, setting #+OPTIONS properly works.
To do export, check https://github.com/kristijanhusak/orgmode.nvim/blob/master/DOCS.md#org_export


gcc13: 13.2.0 -> 13.3.0

Changes: https://gcc.gnu.org/gcc-13/changes.html
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build gcc13

error: hash mismatch in fixed-output derivation '/nix/store/m094ajwgzkikf2w82smda5fg0cbfsb2n-gcc-13-darwin-aarch64-support.patch.drv':
         specified: sha256-xekjZDDvbtvdp96axwv3niFigHekgyLOx/PwZMz8JD0=
            got:    sha256-RBTCBXIveGwuQGJLzMW/UexpUZdDgdXprp/G2NHkmQo=

Ah, I completely missed that it's fetchpatch and not fetchurl and used nix-prefetch-url to get the initial hash. Updated. Thank you!


Added ListTile.titleAlignment, ListTileThemeData.titleAlignment

Provides a way to configure a ListTile or a ListTile theme that avoids the problem in https://github.com/flutter/flutter/issues/119861.
Specifying titleAlignment: ListTileTitleAlignment.titleHeight restores the sometimes convenient M2 default behavior, even if useMaterial3 is true. The default for M3 is ListTileTitleAlignment.threeLine which means that the alignment of the leading/trailing widgets will depend on ListTile.isThreeLine, per the M3 spec.
Specifying titleAlignment: ListTileTitleAlignment.center enables one to force the leading/trailing widgets to be centered wrt to the title, even when useMaterial3 is true and isThreeLine is false. That's particularly useful in cases where a subtitle isn't needed and it addresses complaints like this one: https://stackoverflow.com/questions/55168962/listtile-heading-trailing-are-not-centered
For completeness, there's also ListTileAlignment.bottom and ListTileAlignment.top.
This PR isn't ready to submit; it still needs tests for the new feature.

@HansMuller
This looks like a perfect way to match M3 specs while having more control over the leading and trailing alignment.
ListTileAlignment.bottom has legit a use-case as well.
This PR looks great to me. Let me know if you need me to update/write tests for this (co-author this PR).

@TahaTesser - if you're willing to take over this PR and add tests, I'd appreciate that!

@HansMuller
I just added tests and an example. Please take a look

Looks like we have some test failures:
00:47 +93: /b/s/w/ir/x/w/flutter/examples/api/test/material/list_tile/list_tile.4_test.dart: Can choose different title aligments from popup menu
 ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
 The following TestFailure was thrown running a test:
 Expected: <58.0>
   Actual: <48.0>
 When the exception was thrown, this was the stack:
 #4      main.<anonymous closure> (file:///b/s/w/ir/x/w/flutter/examples/api/test/material/list_tile/list_tile.4_test.dart:20:5)
 <asynchronous suspension>
 <asynchronous suspension>
 (elided one frame from package:stack_trace)
 This was caught by the test expectation on the following line:
   file:///b/s/w/ir/x/w/flutter/examples/api/test/material/list_tile/list_tile.4_test.dart line 20
 The test description was:
   Can choose different title aligments from popup menu
 ════════════════════════════════════════════════════════════════════════════════════════════════════```

@HansMuller
Fixed the example test.


actions: Fix incorrect audit logging in bulk_remove_subscriptions

modified_user=sub_info.user and modified_stream=sub_info.stream, added by commit 6d1f9de7d386145d35646b76a413c3f4db2f3fec (#16553), were always coming from the last entry in the loop above, not from the enclosing list comprehension.
Found by the Pylint rule undefined-loop-variable.
Testing plan: Not tested.
Cc @showell.

I think probably we should merge this and then open a follow-up issue for the historical cleanup problem.