Invalid memory write when printing zero width unicode characters

Only seems to happen with EGC support built in. The following presents an invalid write with valgrind:
#include <locale.h>

#define TB_IMPL
#define TB_OPT_EGC
#include "termbox2.h"

int main()
{
    setlocale(LC_ALL, "");
    tb_init();

    /**
     * Invalid write printing any string with a zero width unicode character:
     */

    const char *str;
    // str = "👨👨"; // valid
    // str = "👨\xE2\x80\x8D👨"; // invalid write
    str = "👨👨👨"; // also invalid write
    tb_print(0, 0, 0, 0, str);

    tb_present();
    struct tb_event ev;
    tb_poll_event(&ev); // so we can see the output
    tb_shutdown();

    return 0;
}

Ah I see this was probably fixed in b89b08c


use port passed as argument rather than env variable

The setupWebserver function was being passed the port number from the environment variable, rather than the port argument from the calling function.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Missing iam:PassRole documentation in a bunch of ARC pages and actions

Sorry to keep submitting these ARC issues here but there's not really a good place for me to submit them otherwise!
A handful of ARC pages for services include iam:PassRole as a dependent action, but it seems like most actions that depend on iam:PassRole don't list it as a dependent action. As usual, this is due to missing data from all the service-specific permission data files, but given that it's so pervasive across different services, it's also probably relevant to IAM.
Here's a few common ones off the top of my head that aren't listed on the ARC pages:

ec2:RunInstances
lambda:CreateFunction and lambda:UpdateFunctionConfiguration
codebuild:CreateProject and codebuild:UpdateProject (documented here but not in the ARC page for CodeBuild)

I assume there are others but those are the ones I happened to be looking at. Not all of them are missing, including some of the lesser known services like dax:CreateCluster and sms-voice:CreateConfigurationSetEventDestination.

I started grepping all the AWS documentation for things that claim to use PassRole and got bored, but this is the list I have so far:
    'ec2:RunInstances',
    'ec2:ReplaceIamInstanceProfileAssociation',
    'ec2:AssociateIamInstanceProfile',
    'codebuild:CreateProject',
    'codebuild:UpdateProject'
    'lambda:CreateFunction',
    'lambda:UpdateFunctionConfiguration',
    'transfer:CreateUser',
    'sms-voice:CreateConfigurationSetEventDestination',
    'dax:CreateCluster',
    'shield:AssociateDRTRole',
    'ecs:RunTask',
    'events:PutRule',
    'events:PutTargets',
    'kinesisanalytics:CreateApplication'

Excellent, thanks! I'm passing this to the IAM team so that they can poke all of the service teams to update their files.
I think the key is that if a service uses a service-linked role to perform actions on behalf of customers, then the iam:PassRole permission is required.

@stephswo I just discovered myself that s3:PutBucketReplication API call is not referenced on the documentation, nor that it requires iam:PassRole on the replication role to work. The only error message was that s3:PutBucketReplication Access Denied which is a bit misleading.

Ping for this: a lambda which sets up bucket replication and defines a replication role for S3 (as described in https://docs.aws.amazon.com/AmazonS3/latest/userguide/setting-repl-config-perm-overview.html#setting-repl-config-same-acctowner) needs that permission as well.

Closing this issue or pull request in advance of archiving this repo. For more information about the decision to archive this repo (and others in the 'awsdocs' org), see the announcement on the AWS News Blog.


Multiline raw string literals not formatted correctly

Only the first line of raw string literal is formatted as a string.
R"(This is a multiline
raw string literal)"

So "raw string literal" would show up as normal code.

This is an issue in the upstream Monaco C++ mode, but we've worked around its issues before. Thanks for the report.

The Monaco team has added support for raw strings in the upcoming update. We just have to wait now! 👍

Monaco 0.11 has now been released and will hit the live site some time this week. :D


Use the v9 quickstart branch until the v9 release

Do quickstart testing with the v9 branch until the v9 release

Restore the Functions and Storage quickstart tests to CI

Fix #9635

#no-changelog

The storage failure is a regression or exposure from #9576 that wasn't caught because that PR was from a fork.


Extractor: Only add source files that are also inputs. [phab:D1729]

Created by fromberger at 2017-06-21 16:20:23:
The extract_kindex tool allows the user to use command-line arguments to
identify source inputs, but was not verifying that selected arguments are
actually named as inputs to the compilation.

shahms accepted this revision at 2017-06-21 16:22:42

fromberger closed via commit e09ed7f0af81ee14f872ad4a78999d9b73bb0504 at 2017-06-21 16:24:32


How to use .frag shaders in JS Engine

What is your question?
How to take a shadertoy shader and implement it as a background and or stage?

it's the same as how you would use it in Psych 0.6.3

yes because it’s a psych fork

also should prob mention; @TofpFL in 2 of your js/bambi fansong submissions the links to the songs and flms you sent were both links to the form that you were submitting the songs on

What do you mean? Can you show me images?

What do you mean? Can you show me images or provide context? I'm pretty sure that's how it's supposed to work.  Nor how to actually softcode it in.

the links are both the same link and lead to this form

The only reason it's the same link is because the song isn't on YouTube

The only reason it's the same link is because the song isn't on YouTube. It leads you to the exact same drive. I can't exactly use SNIFF because the BPM is higher than 522

i mean.. if i'm charting it you don't need to exactly use SNIFF


Add syntax highlighting to code snippets in HTTPS.md

@swankjesse Should I create another PR that points to okhttp_3.14.x branch?

@jemaystermind sure.


URI output for 7-digit tokens does not yield correct codes when compared

Hi,
I have several 7 digit tokens (for example Twitch, Twilio, Authy Dashboard) where the QR codes resulting from the URI authy-export outputs does not yield the same tokens in 1Password or Google Authenticator when compared with Authy. Notably the longer secrets for Amazon Web Services with 6 digit tokens work just fine so it would appear there is some special treatment required for those 7 digit ones.

where the QR codes resulting from the URI authy-export outputs does not yield the same tokens in 1Password or Google Authenticator when compared with Authy

This is normal. For those types of tokens, Authy issues a separate OTP secret for every individual device registered to your Authy account. This allows them to revoke access to individual devices. authy-export is itself a separate device, so it gets a different OTP secret. This has always been the case.
More recently, I have read a comment that Authy have begun intentionally breaking compatibility with the RFC2638 TOTP standard for those types of services. If the 7-digit code generated by authy-export for those services does not work, then I would suspect that this change is the reason way. I am as of yet undecided whether I am going to bother cat-and-mousing Authy's changes, as I have long since abandoned Authy.

Well, I signed up to Authy again and double-checked whether the TOTP export for Twitch still produces codes that pass authentication - and it still does. There's not much I can do about the code being different - that's just how Authy works on the backend.
I'm going to close this, but if I have missed the point somewhere, please let me know!


Pass through showHelpText prop.

Pass through showHelpText prop to default-field component

Will add release soon.


Update cloudinary widget

Closes #219.
Before

After

Bug
However, when actually trying to save the resource after uploading the image, I get the following error (I named the model Pic):
ActiveSupport::MessageVerifier::InvalidSignature in Account::PicsController#create

Maybe I'm not creating the model correctly, but if this is legitimately a bug I can look into this too and open a separate PR.
Thanks for reporting, @malachaifrazier!

I was getting the error because I was using attachment instead of string. Using string worked just fine 👍


need to determine which browser instance failed

with multiple browsers (and when a failure occurs), it's hard to tell which browser had the failure.  some visual indicator or something in the console stating which browser is currently selected would be good.

No activity.


fix/test for older versions of rustc

Support for rust <1.6 appears to have regressed with the changes
introduced to support no_std in commit
86196aa4a7d6911455d236614d55331dc1e577ff.  This change properly
boxes off the no_std functionality and adds testing against
1.0.0 to ensure things will work on older versions.
Fixes #10
Signed-off-by: Paul Osborne<EMAIL_ADDRESS>

Excellent, thank you!

Released 1.0.2 with this change.


Update d3-voronoi to 1.1.0:

[ ] update dependencies for module
[ ] update definitions dependency
[ ] Review barrel to ensure they are complete for VoronoiDiagram's new find-method

Definitions update on DefinitelyTyped in progress see PR 12331


README examples work as is

The first two README examples might be confusing using /* done */ instead of the proper callback "last".
minor point

Hi @steveinatorx - The point of returning the conditional there was to illustrate that you can terminate iteration early by returning false or by passing false to the callback.  The if (/* done */) { was meant to signify some arbitrary condition on which to end the iteration early. I don't think using if (last) { would make sense in the example because there would be no reason to request stopping the iteration when it's already at the last iteration.

ok that explanation makes more sense.


Add run summary

The user may need some summary to be reminded which config components were edited for each run. This could be appear as a label in the results table, or as a figure description below the plots. We will explore options to capture and display this information.

I have added UI description field and this information is saved to the runinfo.txt  but let's delay the decision of how to display it  in the next sprint

Modification is to remove columns from results display table (start/end year, catchment pop). Replace these with the description text instead.

if we don't get to test all plots , we will keep start/end year validation and add summary column

@rhanIDM will remove the limitation of plots with different start/end year

Partially done in https://github.com/InstituteforDiseaseModeling/PACE-HRH-UI/commit/f39e452abd520c8193b680c93c59ecbc2e040a12#diff-8077c0ddef2b67270cda7832e5a72ba805f8a0faf2cce8451774b10ed572de03
which add the summary column and remove max_utilization, hrs_per_wk and catchment_pop
we can remove start year /end year when plots can work with time gaps


Migrated codegen to chr.avro instead of official apache.avro, as it is much much better

Codecov Report

Merging #36 (3ab6634) into main (7a7df8a) will decrease coverage by 0.04%.
The diff coverage is 97.86%.

:exclamation: Current head 3ab6634 differs from pull request most recent head 4bb3c8b. Consider uploading reports for the commit 4bb3c8b to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   98.87%   98.83%   -0.04%
==========================================
  Files          30       42      +12
  Lines         266      514     +248
==========================================
+ Hits          263      508     +245
- Misses          3        6       +3

Impacted Files
Coverage Δ

...ntler.Commons.CodeGen.Core/Base/CompilationBase.cs
100.00% <ø> (ø)

...vantler.Commons.CodeGen.Core/FileTemplateLoader.cs
100.00% <ø> (ø)

...er.Commons.StringHelpers/CasingStringExtensions.cs
100.00% <ø> (ø)

...apping.Avro/Mappers/AvroCSharpCompilationMapper.cs
76.19% <76.19%> (ø)

...mmons.CodeGen.Mapping.Avro/AvroSchemaTypeParser.cs
98.14% <98.14%> (ø)

...ure.DataAttributes/AutoNSubstituteDataAttribute.cs
100.00% <100.00%> (ø)

...tler.Commons.CodeGen.CSharp/CSharpCodeGenerator.cs
100.00% <100.00%> (ø)

...ler.Commons.CodeGen.CSharp/CSharpTemplateLoader.cs
100.00% <100.00%> (ø)

...ntler.Commons.CodeGen.CSharp/Models/CSharpClass.cs
100.00% <100.00%> (ø)

...Commons.CodeGen.CSharp/Models/CSharpCompilation.cs
100.00% <100.00%> (ø)

... and 24 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Rebalancing Set cToken Bidding Contract

Pull Request Test Coverage Report for Build 7225

42 of 58 (72.41%)  changed or added relevant lines in 1 file are covered.
967 unchanged lines in 52 files lost coverage.
Overall coverage decreased (-72.02%) to 27.979%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contracts/helper/RebalancingSetCTokenBidder.sol
42
58
72.41%

Files with Coverage Reduction
New Missed Lines
%

contracts/core/tokens/SetToken.sol
1
80.43%

contracts/core/lib/SetMath.sol
2
0.0%

contracts/lib/ScaleValidations.sol
2
0.0%

contracts/core/extensions/CoreOperationState.sol
3
33.33%

contracts/core/lib/SetTokenLibrary.sol
3
46.67%

contracts/core/modules/lib/ModuleCoreStateV2.sol
3
0.0%

contracts/core/lib/Rebalance.sol
4
0.0%

contracts/lib/Authorizable.sol
5
47.06%

contracts/core/lib/ExchangeWrapperLibrary.sol
6
0.0%

contracts/core/tokens/rebalancing-v2/RebalancingBid.sol
6
0.0%

Totals

Change from base Build 7160:
-72.02%

Covered Lines:
423

Relevant Lines:
1406

💛  - Coveralls


Autoplay stops playing after first track

Sometimes the extensions plays the first/actual track (or the track pointed to by the configuration option autoplay/tracklist.index) and then stops. This is probably due to timing "problems" in Mopidy's core (for a discussion see https://discourse.mopidy.com/t/restore-state-not-working-for-dlna-extension/4358) and at the moment there is not known solution.
This behaviour can show up or disappear after an update of extensions/Mopidy.
(Partial) workarounds for hard-coded tracklists:
Remember, that the first track is played, so this works only for satisfactorily for (radio) streams.
If you use hard-coded tracklists in your configuration, put it in the first place of your tracklist autoplay/tracklist.uris.
Help to solve this issue is always appreciated!

This repository has been moved to https://codeberg.org/sph/mopidy-autoplay/ and this one set to read-only.
Please continue at https://codeberg.org/sph/mopidy-autoplay/issues/2


Fix: Build enable trace facility

Fix: Build enable trace facility
Description
Fix: Build enable trace facility
Test Steps
github actions pass
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please update the PR description with details about what was failing and what is fixed in this PR.


CMIN fails with xtb, error: No sub-structure match found between the reference and probe mol

Cy72_rdkitsdf.txt
Hi, I am trying to optimize a set of molecules in SDF format with XTB with the following command (see file attached):
python -m aqme --cmin --program "xtb" --files "Cy72_rdkit.sdf"
But I get an error:
AQME v 1.5.2 2024/04/29 19:00:30
Citation: AQME v 1.5.2, Alegre-Requena, J. V.; Sowndarya, S.; Perez-Soto, R.; Alturaifi, T.; Paton, R. AQME: Automated Quantum Mechanical Environments for Researchers and Educators. Wiley Interdiscip. Rev. Comput. Mol. Sci. 2023, DOI: 10.1002/wcms.1663.

Command line used in AQME: python -m aqme --cmin --program "xtb" --files "Cy72_rdkit.sdf"

   ----- Cy72_rdkit -----

o  Starting xTB optimization

o  Starting xTB optimization

o  Applying filters to intial conformers after xtb minimization

Traceback (most recent call last):
  File "/home/vama/miniconda3/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/vama/miniconda3/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/vama/miniconda3/lib/python3.10/site-packages/aqme/__main__.py", line 19, in <module>
    aqme.main()
  File "/home/vama/miniconda3/lib/python3.10/site-packages/aqme/aqme.py", line 69, in main
    cmin(**vars(args))
  File "/home/vama/miniconda3/lib/python3.10/site-packages/aqme/cmin.py", line 217, in __init__
    total_data = self.compute_cmin(file)
  File "/home/vama/miniconda3/lib/python3.10/site-packages/aqme/cmin.py", line 390, in compute_cmin
    selectedcids = RMSD_and_E_filter(
  File "/home/vama/miniconda3/lib/python3.10/site-packages/aqme/filter.py", line 559, in RMSD_and_E_filter
    rms = get_conf_RMS(
  File "/home/vama/miniconda3/lib/python3.10/site-packages/aqme/utils.py", line 311, in get_conf_RMS
    return GetBestRMS(mol1, mol2, c1, c2, maxMatches=max_matches_rmsd)
RuntimeError: No sub-structure match found between the reference and probe mol

Any suggestion? Thanks

Hi,
Long story short, after xTB optimization, the conversion that RDKit does from SDF to MOL resulted in different sub-structures due to a different organization of double bonds (see image). I fixed the issue in our dev branch, you can download the code and install it with "pip install ." .
Let me know if the code doesn't work for you!

Thanks!


[8.x] Align CSRF cookie duration to session cookie duration

The duration of the session cookie is defined by two configuration variables: session.lifetime and session.expire_on_close. If session.expire_on_close is true, then the cookie expires on close; if it is false (default), then the cookie has a duration of session.lifetime minutes (this happens in the getCookieExpirationDate method of Illuminate\Session\Middleware\StartSession).
The CSRF cookie (XSRF-TOKEN, set by the VerifyCsrfToken middleware) uses the same duration of the session cookies (session.lifetime), but the middleware does not consider the session.expire_on_close variable
(this happens in the addCookieToResponse method of Illuminate\Foundation\Http\Middleware\VerifyCsrfToken).
This is an unexpected behaviour, and looks like a bug. As a result, if session.expire_on_close is true it is possible that the session cookie expires while the CSRF cookie is still valid, or that the session cookie is still valid while the CSRF cookie expires. None of these seems a desirable behaviour.
This pull request aligns the behaviour of the CSRF cookie to the one of the session cookie, by taking into account the value of the session.expire_on_close variable.

I'm not changing this on a patch release.

@taylorotwell fine. Should I propose it for the master branch?


pusher upload updates

merging Pusher code to dev environment to test

Note: This code is not yet production ready - needs correct credentials for Pusher in prod before this is promoted to production.


wal: support auto-cut in wal

WAL should control the cut logic itself. We want to do falloc to
per allocate the space for a segmented wal file at the beginning
and cut it when it size reaches the limit.

/cc @yichengq @barakmich
I did a manual test and it worked.

If other functionality works fine, it should be ok to merge without additional tests.
some question: what happens to file locks when etcd reboots?

@yichengq ReadAll re-locks them.

All make sense to me. lgtm.

Just double-checking my intuition: so we write the entries to the WAL but rarely need to open old WAL files we've already cut, unless we're first coming up and reading it all -- and that we currently read it all (or enough back to snapshot) because the data structures are in memory and not, say, in the upcoming (better) store?
The point being there's no chance there'd be dozens of WAL file descriptors open now. I don't see that being the case here, just making sure that my expectation is correct.

so we write the entries to the WAL but rarely need to open old WAL files we've already cut, unless we're first coming up and reading it all

Restart will not read all but from the newest wal segment that contains the newest snapshot index.

(or enough back to snapshot)

Yeah, alright, I get it.


Caching issue

I have fairly long record to encode. However, whenever I turn on cache=True, I get erroneous results after a few encoding operations. The caches seems to be pointing to the wrong data. I workaround this issue by using the self.data_cache[value] instead of self.data_cache[id(value)]. I wonder there's any shortcoming using this approach? Thanks.

Thank you for raising this issue. Using data_cache[value] is indeed a valid approach and can even be preferable in many cases. It's perfectly fine as long as your value is hashable.
The reason I originally used id(value) as the key was to accommodate scenarios where the cache key might be a mutable object like a dictionary or a list, which aren't hashable by default. This approach allows for more flexibility in the types of objects that can be used as keys.
However, if all your values are hashable, using data_cache[value] directly is more intuitive and can potentially avoid some pitfalls associated with using id().
Regarding the erroneous results you're experiencing, it would be extremely helpful if you could provide a specific example that demonstrates the issue. This would allow me to investigate further and potentially identify any underlying problems with the current implementation.

This is my input for encoding:
{ "continent":  "Asia", "range": "<IP_ADDRESS>/24", "num": 100 }
{ "continent": "Africa", "range": "<IP_ADDRESS>/24", "num": 3200 }
{ "continent": "Asia", "range": "<IP_ADDRESS>/24", "num": 2300 }
{ "continent": "Europe", "range": "<IP_ADDRESS>/24", "num": 2030 }
{ "continent": "America", "range": "<IP_ADDRESS>/24", "num": 2001 }
This is my output after encoding with cache=True.
{"continent":"Asia","network":"<IP_ADDRESS>/24","num":100,"range":"<IP_ADDRESS>/24"}
{"continent":"Africa","network":"<IP_ADDRESS>/24","num":3200,"range":"<IP_ADDRESS>/24"}
{"<IP_ADDRESS>/24":"Asia","network":"<IP_ADDRESS>/24","num":100,"range":"<IP_ADDRESS>/24"}
{"continent":"Asia","network":"<IP_ADDRESS>/24","num":100,"range":"<IP_ADDRESS>/24"}
{"continent":"Africa","network":"<IP_ADDRESS>/24","num":3200,"range":"<IP_ADDRESS>/24"}
I am missing many entries. and some entries are wrong. Example, line 3. Using cache=False fixed the problem. But I have a very large data set and cache=False will have data record more then 32 bits and not feasible beyond certain entires.. So I end up doing fixing this by:
            if not isinstance(value, (list, dict)):
                return self.data_cache[value]

and corresponding code:
            if not isinstance(value, (list, dict)):
                self.data_cache[value] = pointer

I know I will not be caching (list,dict) and lower cache efficiency, but at least my data is correct. I added a "else" use id(value). The result is still not correct. Any idea?

Thank you for providing these detailed insights. It looks like the problem is ID reuse after destruction. This problem is well-documented and discussed in depth in this Stack Overflow question: How unique is Python's id?
After considering the problem, I've come up with a potential solution. Since list and dict are not hashable, we can convert them to tuples, which are hashable. This approach should resolve the caching issues we've been experiencing.
I've implemented this solution in a new branch. Would you mind testing it out? You can find the updated code here:
https://github.com/vimt/MaxMind-DB-Writer-python/tree/12-caching-issue
I'd greatly appreciate your feedback on this implementation. If you encounter any issues or have suggestions for improvement, please let me know.

Thanks for the quick fix. The patch works nicely. I did my verification and the result is similar to using cache=True. Much appreciate.

I've released a new version incorporating this improvement: v0.2.4
You can upgrade to the latest version using:
pip install -U mmdb_writer

If you encounter any issues or have further suggestions, please don't hesitate to let me know. Your feedback is valuable and helps improve the library for everyone.


Front end uses factory Someting() => null as test code.

With null-safety, a factory can no longer return null. The implicit return type is non-nullable, so all these factory constructors become invalid code. The tests need to be fixed before the code can be migrated to null safety.
Example from /pkg/front_end/testcases/extensions/extension_constructor.dart:
factory Extension.fact() => null;

There are also occurrences in /pkg/front_end/lib/src/fasta/source/source_loader.dart.

Test code for NNBD is located in subdirectory pkg/front_end/testcases/nnbd/, and pkg/front_end/testcases/extensions/extension_constructor.dart tests the existing (soon to be known as "legacy") behavior.
Some of our tests are still unmigrated, such as those using the strings with default program parts from source_loader.dart.


Instancing billboards

This is merged with the billboard size-in-meters changes.
For #3001

In Firefox, I get six test failures in master, and 22 in this branch.  The new ones are BillboardCollection and friends.

The vast majority of this code has already been reviewed and is in the instancing-ready-for-master branch (merged in #3048).  This pull request is to bring those changes into master along with fixing merge conflicts from #3043 (billboard size in meters).

@lilleyse please update the task list in #3001 when this is merged (and in general as needed).

This is ready to merge once the test failures in Firefox are fixed.

This should fix the errors.

Looks good, thanks!


Windows - Parameters are added to folder name on x?

Using the current version v56.4 on Windows Server 2022 x64
This runs fine on the first run:
zpaqfranz.exe x "D:\!XYplorer\!Archive\17\40\v17.40.zpaq" "D:/!XYplorer/!Archive/17/40/XYplorerFree 17.40.0100" -to "D:\!XYplorer\!Fresh\XYplorerFree 17.40.0100\"

Now imagine I'd like to extract again and overwrite stuff:
In this case the -force parameter isn't used, it's just appended to the destination folder name?
XYplorerFree 17.40.0100 -force in D:\!XYplorer\!Fresh
zpaqfranz.exe x "D:\!XYplorer\!Archive\17\40\v17.40.zpaq" "D:/!XYplorer/!Archive/17/40/XYplorerFree 17.40.0100" -to "D:\!XYplorer\!Fresh\XYplorerFree 17.40.0100\" -force

Another issue? (or maybe I'm just doing it wrong...)
E.g. extract only a specific version (the archive has 29 versions):
It extracts the whole archive into XYplorerFree 17.40.0100 -until 29  not only the 29th version...
zpaqfranz.exe x "D:\!XYplorer\!Archive\17\40\v17.40.zpaq" -to "D:\!XYplorer\!Fresh\XYplorerFree 17.40.0100\" -until 29

I am refactoring in the handling of internal flags (in build 57),
it is therefore difficult to give an answer.
Can you please attach a debug archive to this post?
You can  make by
zpaqfranz a z:\thedebug.zpaq "d:\!XYplorer" -debug -zero

-debug -zero means retaing everything (file names and size), but filled with 0
Then add the .zpaq into a zip (yep, github wants zip)
Thank you

Don't know if this will help you much (this archive only has a single version) but nonetheless, I've created it (and redirected the output of it into a file).
Put the debug.zpaq and debug_log.txt into a .zip and attached it...
debug.zip

This is the (infamous) " on Windows
zpaqfranz.exe x "D:\!XYplorer\!Archive\17\40\v17.40.zpaq" "D:/!XYplorer/!Archive/17/40/XYplorerFree 17.40.0100" -to D:\!XYplorer\!Fresh\XYplorerFree_WITHOUTSPACE -force

I will seek for a solution :) (now I am porting on... Haiku!!)

Mh. I hope you find one :)
Should this work (extract only that (existing) version)?
It always extract the whole archive, not a single version out of it...
zpaqfranz.exe x "D:\!XYplorer\!Archive\17\40\v17.40.zpaq" -to D:\!XYplorer\!Fresh\XYplorerFree_WITHOUTSPACE -until 29

It is a Windows "thing", require some kind of... kludge
Short version: without " (=> no space inside folder name) should works fine
Avoid as much as possible the spaces (!)
On *nix it is the opposite (use " everywhere, and you will be fine)

As I said, even when I don't use spaces (and no double quotes around the extraction path), it extracts the full archive, not the specific version...

-until something -to whereyouwant

If you can please attach a "real" multiversion test file
thank you

Sorry, I think I got it now... It's extracting everything from the beginning of the archive up to that version with -until K :)
For whatever reason I was thinking it would extract only the version K, not everything before.
My bad, sorry.

If you ONLY want the files added in version K, yes... you can... :)
with -range and -all
zpaqfranz x incrementale.zpaq -to z:\extracted -all -range 300:300

On your's version this will  make a lot of empty dirs, but with the z:\extracted\0300 filled

It's even a bit easier for this archive:
zpaqfranz.exe x archive.zpaq "D:/XYplorerFree 17.40.0100" -to D:\_extracted_\XYplorerFree_17.40.0100

As long as that path (forward slashes are required even under Windows) does only exist once (and for this special archive type that's the case), I can extract it with the command above. No -until or -range required.

Can you please check the attached pre-release?
57_2b.zip
Thank you

Sorry, just got home...
Tried that version and didn't discover any problems with it (creating archives / extracting from archives wise)...

OK for now I close
(PS new 57_2 is released)


Queries and key names

Would be nice to be able to query using the key names from the JSON tag. esp. when doing REST API's.
Second when the name is incorrect it will segfault with:
reflect: call of reflect.Value.Interface on zero Value

This should probably return an error instead of this.

Can you give an example of the failing test so i can try to reproduce it locally please?

Hi,
Here is an example: https://github.com/mickep76/storm_bug

Thank you, the bug has been fixed. Select now returns an error q.ErrUnknownField when the field is not found.

Would be nice to be able to query using the key names from the JSON tag. esp. when doing REST API's.

Concerning this, i don't think this is a good idea to mix transport logic with database logic. A lot of people don't use Storm with a REST api (cli tools, gRPC, etc)


Possibility to add MeatNet Cloud Remote Viewing?

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
I don't have BLE on my server and/or my probe would be too far away anyways.
Describe the solution you'd like
It would be nice to use the MeatNet Cloud Remote Viewing capability that was added some time ago. You can pair a random device like a tablet that is near the probe and publish the temps to the cloud. Another device (like a HA server) could then access them.
Describe alternatives you've considered
None
Additional context
None

Thanks for opening this. I'd love to include support for this as well. As of today, there doesn't appear to be a documented API to enable this. We won't be able to make progress here until an API is exposed by Combustion, Inc.


[FLINK-18074][checkpoint] Ensure task could fail when exception thrown out on notified of checkpoint completed/aborted

What is the purpose of the change
Ensure task could fail when exception thrown out on notified of checkpoint completed/aborted and added test to ensure this.
Brief change log
Correct the logic of exception handling of StreamTask#notifyCheckpointCompleteAsync and StreamTask#notifyCheckpointAbortAsync.
Verifying this change
This change added tests and can be verified as follows:

Added unit test StreamTaskTest#testFailToConfirmCheckpointCompleted
Added unit test StreamTaskTest#testFailToConfirmCheckpointAborted

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

Merged, thanks for fixing the issue :)


Driver crash, clicking on the auto-fit range button.

Description
When viewing a texture, with ranges outside the normal [0.0 ... 1.0] range. Clicking the "auto-range" button cause the AMD driver (latest) to auto-recover from crash. The state of Renderdoc is undefined, if I click on anything else - RenderDoc crashes with no "crash report" util popping up for RenderDoc. This does not happen in the previous major version of RenderDoc. If the crash reporter decides to show up, I'll definitely send the report over!
Steps to reproduce
Capture, and view a texture with data outside the normalized range.
Press the auto-range button.
Environment

RenderDoc version: 1.13 and latest nightly 2021_04_07_c3ca732a_64
Operating System: Win 10 (19042)
Graphics API: Vulkan

Radeon 290, 21.3.1 driver
Vulkan 1.2

Please provide an actual reproducible test case, do not assume that the problem is so general that it can be reproduced on any application at all.

Sorry, I do not understand what you mean by general.
I was able to send a crash report however, and referenced this github issue
for it.
I did not mean anything by my words, the test case here on my machine is
100% reproducible. I have to manually input the maximum value for the
range as a workaround for now.
On Thu, Apr 8, 2021 at 4:40 PM Baldur Karlsson @.***>
wrote:

Please provide an actual reproducible test case, do not assume that the
problem is so general that it can be reproduced on any application at all.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/baldurk/renderdoc/issues/2240#issuecomment-816277673,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHJNP5K4BIMBG74VJ2C2DJTTHYWELANCNFSM42TZZQLQ
.

What I mean is your reproduction steps are very vague. They assume that any texture with values outside of [0,1] from any capture of any vulkan program will crash. I doubt that is true, rather I expect the problem is specific to some circumstances that happen in your case. Even if it were generally true that this crash happens in all cases then it does no harm at all to include a specific reproducible test case. That's why I was asking for you to share the test case you have which is reproducible instead of giving steps which make it potentially very hard to reproduce.
If you've included a capture in a crash report then I can look at it on Monday. Otherwise if you haven't I would still need a reproducible test case as often the minidump in the report is not enough to track down the problem.
If you have time in the meantime it would help to check nightly builds between v1.12 and v1.13 to narrow down where the problem started happening, if you say it didn't happen in v1.12. That is entirely up to you though and if you don't have the time to do that it's not a concern, I will investigate either way.

I can reproduce this with the submitted capture. It looks like a recent driver regression on AMD's part, it works fine for me on 21.2.3 but breaks on 21.3.1 (and 21.3.2). I can't test it on nvidia since the capture is not feasible to port to a different GPU, but I can also reproduce this with a test program using any 3D texture (2D seems to work fine, 3D is the only one broken - I haven't tried other types) and it works fine on nvidia there.
It works for me on latest and on v1.12. Perhaps you upgraded your graphics drivers and then mistakenly thought that the problem started with the latest RenderDoc version instead of the latest driver?
I'll report the issue to AMD, but I can't see any obvious cause or workaround from my side so I'm going to close this issue as there's (currently) nothing I can do. I'll comment here if I add a workaround given more information from AMD. In the meantime I'd suggest downgrading your driver to the last working version (21.2.3 for me) or avoiding the autofit and histogram features.

Thank you Baldur for investigating and isolating this issue. RenderDoc is
such a valuable tool, great work I love RenderDoc!
On Mon, Apr 12, 2021 at 11:55 AM Baldur Karlsson @.***>
wrote:

I can reproduce this with the submitted capture. It looks like a recent
driver regression on AMD's part, it works fine for me on 21.2.3 but breaks
on 21.3.1 (and 21.3.2). I can't test it on nvidia since the capture is not
feasible to port to a different GPU, but I can also reproduce this with a
test program using any 3D texture (2D seems to work fine, 3D is the only
one broken - I haven't tried other types) and it works fine on nvidia there.
It works for me on latest and on v1.12. Perhaps you upgraded your graphics
drivers and then mistakenly thought that the problem started with the
latest RenderDoc version instead of the latest driver?
I'll report the issue to AMD, but I can't see any obvious cause or
workaround from my side so I'm going to close this issue as there's
(currently) nothing I can do. I'll comment here if I add a workaround given
more information from AMD. In the meantime I'd suggest downgrading your
driver to the last working version (21.2.3 for me) or avoiding the autofit
and histogram features.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/baldurk/renderdoc/issues/2240#issuecomment-818009003,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHJNP5KLR4TKTS6EGSULM5TTIMXZ7ANCNFSM42TZZQLQ
.

Regarding #2240
Well as of now, driver 21.5.2 ( last driver supporting Radeon 290 EOL ) it
still crashes the driver when you try to autofit a volume texture.
Is there anything relatively simple that you can do to Renderdoc to fix the
issue? Viewing volume textures is a common need for my usage with captures.
I'm going to try downgrading to version 21.2.3 as you suggest. Unfortunate,
but needed.
Thanks
On Wed, Apr 14, 2021 at 12:33 AM Jason @.***> wrote:

Thank you Baldur for investigating and isolating this issue. RenderDoc is
such a valuable tool, great work I love RenderDoc!
On Mon, Apr 12, 2021 at 11:55 AM Baldur Karlsson @.***>
wrote:

I can reproduce this with the submitted capture. It looks like a recent
driver regression on AMD's part, it works fine for me on 21.2.3 but breaks
on 21.3.1 (and 21.3.2). I can't test it on nvidia since the capture is not
feasible to port to a different GPU, but I can also reproduce this with a
test program using any 3D texture (2D seems to work fine, 3D is the only
one broken - I haven't tried other types) and it works fine on nvidia there.
It works for me on latest and on v1.12. Perhaps you upgraded your
graphics drivers and then mistakenly thought that the problem started with
the latest RenderDoc version instead of the latest driver?
I'll report the issue to AMD, but I can't see any obvious cause or
workaround from my side so I'm going to close this issue as there's
(currently) nothing I can do. I'll comment here if I add a workaround given
more information from AMD. In the meantime I'd suggest downgrading your
driver to the last working version (21.2.3 for me) or avoiding the autofit
and histogram features.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/baldurk/renderdoc/issues/2240#issuecomment-818009003,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHJNP5KLR4TKTS6EGSULM5TTIMXZ7ANCNFSM42TZZQLQ
.

I've asked AMD about it but last I heard it was a shader compiler problem with no obvious workaround unfortunately. If I hear about one that is simple enough to implement I'll do so, I have a number of other driver bug workarounds, but it may not be possible.
The only thing I can suggest is to manually adjust the range instead of autofitting.


Please add content that the tool can not map local users/groups

Please add content that the tool can not map local users/groups.
If it is of local users/groups, they will simply be ignored

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d8379014-03ff-3ab5-aa1f-5d9c3a02be68
Version Independent ID: cfabc646-70ea-6b24-7d16-ea0955479aa5
Content: Create a user-mapping file for data content migration - Migrate to Microsoft 365
Content Source: migration/create-a-user-mapping-file-for-data-content-migration.md
Service: sharepoint-online
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

@jianhuashi2038 Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hi @jianhuashi2038, thank you for your feedback.
Did you mean SharePoint groups? Only AD groups are supported, and there is a note about it:

[!Important]
SPMT only migrates default SharePoint groups.
You can't map an AD group to a SharePoint group in the target site. You can't use SPMT to map a SharePoint Server group to a SharePoint group.

I also understand that local accounts or groups for use in SharePoint are not recommended.

Thanks the follow,  Dario.
The issue occurs with SharePoint On-premise server local user.
Customer set mapping rule for local user to Online user, but found the access right on the file share is not valid on the file at SharePoint online.
Windows の メ`ルhttps://go.microsoft.com/fwlink/?LinkId=550986 から送信
差出人: Dario @.>
送信日r: 2021年8月12日 18:12
宛先: @.>
CC: Jianhua @.>; @.>
件名: Re: [MicrosoftDocs/OfficeDocs-SharePoint] Please add content that the tool can not map local users/groups (#2894)
Hi @jianhuashi2038https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjianhuashi2038&data=04|01|jianshi%40microsoft.com|0bc8bc0285db43b7fcfd08d95d7158c0|72f988bf86f141af91ab2d7cd011db47|1|0|637643563710416114|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=6uTvpG8c4IOkrD4x%2FkC5pJVLdRTigqyz4aqGKQNYte8%3D&reserved=0, thank you for your feedback.
Did you mean SharePoint groups? Only AD groups are supported, and there is a note about it:
[!Important]
SPMT only migrates default SharePoint groups.
You can't map an AD group to a SharePoint group in the target site. You can't use SPMT to map a SharePoint Server group to a SharePoint group.
I also understand that local accounts or groups for use in SharePoint are not recommended.
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SharePoint%2Fissues%2F2894%23issuecomment-897476880&data=04|01|jianshi%40microsoft.com|0bc8bc0285db43b7fcfd08d95d7158c0|72f988bf86f141af91ab2d7cd011db47|1|0|637643563710416114|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=TGmnStiDSSFL3oduwEJ2L4Jqe8glZez2MlPHNKPGJkI%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPTRZTCPMBVRXWKXPK75WY3T4OGAZANCNFSM5BS6DSNA&data=04|01|jianshi%40microsoft.com|0bc8bc0285db43b7fcfd08d95d7158c0|72f988bf86f141af91ab2d7cd011db47|1|0|637643563710426059|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=x1Kh3472yjQA4sXaHjEKagKVL0EjG7aJABtK9BO9F74%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|jianshi%40microsoft.com|0bc8bc0285db43b7fcfd08d95d7158c0|72f988bf86f141af91ab2d7cd011db47|1|0|637643563710426059|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=uAmRHaNpJzll7KC%2B0FtJdxFL1N5Cn%2BtcU4DGgvQ%2FOyA%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26utm_campaign%3Dnotification-email&data=04|01|jianshi%40microsoft.com|0bc8bc0285db43b7fcfd08d95d7158c0|72f988bf86f141af91ab2d7cd011db47|1|0|637643563710436026|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=7UweYEf7ZozoGVuNYKmAu165IbZICxOdk%2BlajsjMti8%3D&reserved=0.

Hello @jianhuashi2038
Can you clarify, a local AD domain user was specified in the column A and an Online user was specified in Column B?
Please provide all the details you can so we can reproduce to see if we have to impact the document.
Thank you


Improved the OpenAPI 3.0 post spec for the GraphQL endpoint.

Improved the OpenAPI 3.0 post spec for the GraphQL endpoint.

mentioning the required query parameter as well as the optional operationName and variables in the payload
mentioning the data and errors properties in the response

/cc @eclarizio  lemme know if this fits the bill.  Thanks !!


Use assert_nil instead of assert_equal

Removes lots of deprecation warnings when running tests.

@scottgonzalez Thanks! I was planning do this today.


Moves single-use extensions from isolated file to caller file

Note, no code change is performed in this PR. This change is progressively performed to clean up the project structure by moving existing single-use extensions from their isolated file to the caller file.

For those that you can (like AGSMap), I would suggest making the extension private. As for the other extensions (like those that add conformance to a protocol), they can't be made private, which is a good argument for keeping them in separate source files. Since they are non-private, they could end up being used elsewhere at any time, making them non-single-use. Just a thought.

I would suggest making the extension private.

This is a good call.

@mhdostal @philium i'm marking this first batch as ready for review. Would you have a look and offer your feedback? Thank you in advance.

@mhdostal have you had a chance to review this PR? what do you think?


add --ssh-config option to drone cli

Allows you to inject a .ssh/config file similarly to how -i allows you to insert id_rsa key.
In our use case we need to inject .ssh/config to force go get to use correct ssh user when fetching/cloning dependencies.

+1

the client was moved to https://github.com/drone/drone-cli and also drone has moved to a netrc instead of ssh keys for cloning


Restart on EADDRINUSE

Describe the problem
uncaughtException: Error: listen EADDRINUSE: address already in use <IP_ADDRESS>:8000
  Server.setupListenHandle [as _listen2] (node:net:1463:16)

Describe the solution
Port is in use by another server, so we can:

wait for timeout
try 3 times
exit 1

@tshemsedinov  It looks like the HTTP server is not returning this error via the error listener: https://github.com/metarhia/metacom/blob/c8565a96eb0b77a536b15f643f4a727321478972/lib/server.js#L213. Will it be normal to catch this error in this way in worker.js:
    process.on('uncaughtException', function(err) {
      if (err.code === 'EADDRINUSE') {
        console.warn(`Address in use: ${options.host}:${port}, retry...`);
        const timer = setTimeout(() => {
          console.log({tryToStartCounter});
          tryToStartCounter++;
          if (tryToStartCounter > 3) process.kill(process.pid, 'SIGINT');
          application.server = new metarhia.metacom.Server(application, options);
        },options.timeouts.bind);
      }
    });

@tshemsedinov It looks like the HTTP server is not returning this error via the error listener. Will it be ok to catch this error in this way in worker.js, or do we need to find a more elegant solution?:
    process.on('uncaughtException', function(err) {
      if (err.code === 'EADDRINUSE') {
        console.warn(`Address in use: ${options.host}:${port}, retry...`);
        const timer = setTimeout(() => {
          console.log({tryToStartCounter});
          tryToStartCounter++;
          if (tryToStartCounter > 3) process.kill(process.pid, 'SIGINT');
          application.server = new metarhia.metacom.Server(application, options);
        },options.timeouts.bind);
      }
    });

@tshemsedinov It looks like the HTTP server is not returning this error via the error listener. Will it be ok to catch this error in this way in worker.js, or do we need to find a more elegant solution?:
    process.on('uncaughtException', function(err) {
      if (err.code === 'EADDRINUSE') {
        console.warn(`Address in use: ${options.host}:${port}, retry...`);
        setTimeout(() => {
          tryToStartCounter++;
          if (tryToStartCounter > 3) process.kill(process.pid, 'SIGINT');
          application.server = new metarhia.metacom.Server(application, options);
        },options.timeouts.bind);
      }
    });

https://github.com/MarhiievHE/impress/blob/594c068dc9e97a9c3734dcc44251e32814aa5492/lib/worker.js#L86-L102

I was wrong, that wasn't the point. The problem was that a wsServer was created in addition to the httpServer, and the error occurred in the wsServer, so the httpServer error listener did not catch it.

It makes three tries to open the server on the specified port with bind timeout and then sends SIGTERM to end with end code 1.

Fixed in https://github.com/metarhia/impress/pull/1908 and published 3.0.7


database/sql: customize JSON marshalling for nullable fields

What version of Go are you using (go version)?

$ go version
go version go1.13.6 windows/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Carlos\AppData\Local\go-build
set GOENV=C:\Users\Carlos\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=D:\code\go
set GOPRIVATE=
set GOPROXY=direct
set GOROOT=c:\go
set GOSUMDB=off
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=D:\code\sample\go.mod
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\Carlos\AppData\Local\Temp\go-build116244046=/tmp/go-build -gno-record-gcc-switches

What did you do?

Serialize any of the database/sql null fields as JSON using encoding/json.
https://play.golang.org/p/_sFxOknJhkH
What did you expect to see?
I expect to see all the database/sql null fields serialized as nulls when their Valid == false.
{
	"bool": null,
	"float64": null,
	"int32": null,
	"int64": null,
	"string": null,
	"time": null
}

What did you see instead?
The zero value.
{
	"bool": {
		"Bool": false,
		"Valid": false
	},
	"float64": {
		"Float64": 0,
		"Valid": false
	},
	"int32": {
		"Int32": 0,
		"Valid": false
	},
	"int64": {
		"Int64": 0,
		"Valid": false
	},
	"string": {
		"String": "",
		"Valid": false
	},
	"time": {
		"Time": "0001-01-01T00:00:00Z",
		"Valid": false
	}
}

This can be solved by implementing MarshalJSON (and also UnmarshalJSON) but I think it qualifies as breaking change so it'd go to Go2. Can somebody confirm it?

I think the current behavior might be the least surprising to me. Null fields marshal like any normal Go struct. I believe leaving the conversion of the data to the caller's target format is best left up to the caller.
/cc @bradfitz @kardianos


feat: support other databases

Ref #331

fixes for other databases.

Support:

OCi8
MySQLi
Postgre
SQLSRV

I would like to merge this. Can someone approve?
If a true Oracle user knows better solution, anytime they can send a PR.

🥳


update the design for the flexible pricing request form

Pre-Flight checklist

[x] Screenshots and design review for any changes that affect layout or styling

[x] Desktop screenshots
[x] Mobile width screenshots

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
fixes #672
What's this PR do?
update the design for the flexible pricing request form
Screenshots (if appropriate)

Codecov Report

Merging #689 (f6ac1c0) into main (e1d8382) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   85.85%   85.84%   -0.02%
==========================================
  Files         124      124
  Lines        5424     5424
  Branches      875      875
==========================================
- Hits         4657     4656       -1
- Misses        630      631       +1
  Partials      137      137

Impacted Files
Coverage Δ

ecommerce/discounts.py
77.19% <0.00%> (-1.76%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d8382...f6ac1c0. Read the comment docs.

Here are the updated screenshots now

Can you take a look at these screen designs? https://projects.invisionapp.com/d/main?origin=v7#/console/21535972/468433645/preview
They are not final yet, but getting close.
Note that the checkbox is a required field, but we don't need to store any data from it.

We will do it in a new PR as it requires some other things to make it like the new UI / design


How do i compile 64 bits?

???

You will have to figure that out yourself.
I compile it against my own stripped down version of Source, but that is not available publicly.

Well, i would need a 64 bit version of volt physics built for SDK 2013.

Well, i would need a 64 bit version of volt physics built for SDK 2013.

That's not really legal, but Jolt builds well on x64 and linux64 CS:GO partner leak.

Oh really? Can you share more detail? @DiegoArmando-27

Oh really? Can you share more detail? @DiegoArmando-27
Firstly I had rewritten the entire CS:GO partner solution to CMake.
Then you may want to change the C++ standard to C++17, to successfully build the Jolt library.
I can share my version of the CMake Jolt implementation. (Can be errors cuz it's not finished yet)


How to get the feature output in different layers for object detection?

How to get the feature output in different layers for object detection?
such as the mobileNetv3 the output in the x/4,x/8,x/16,x/32 layers.
I know hook can solve it ,but hook has problem in the multi gpus and trace process.

This is actually something I'm slowly chipping away at, I plan to make wrapper or accessors so that any of the networks here can be used as backbones in object detection or segmentation tasks. That was one of reasons for formalizing this collection more, but I'm not quite there yet. Still working through what will make the most sense, trying to decide whether to make it fit best with maskrcnn-benchmark, mm-detection, or both...

For any of the gen_efficientnet models, if you want to grab intermediate features, in forward_features replace the x = self.blocks(x) with a loop and collect the outputs you want.
select_feat = {0, 2, 4, 6}
outputs = []
for i, l in enumerate(self.blocks):
    x = l(x)
    if i in select_feat:
        outputs.append(x)

For any of the gen_efficientnet models, if you want to grab intermediate features, in forward_features replace the x = self.blocks(x) with a loop and collect the outputs you want.
select_feat = {0, 2, 4, 6}
outputs = []
for i, l in enumerate(self.blocks):
    x = l(x)
    if i in select_feat:
        outputs.append(x)

ok, I try it and works well. thanks.


better detect invalid rules

closes #1282
Checklist

[ ] No CHANGELOG update needed

[ ] No new tests needed

[ ] No documentation update needed


Remove unneeded brackets from shared helper calls

What
Remove unneeded brackets around calls to the shared helper. Changes:

classes << (shared_helper.get_margin_bottom)

to

classes << shared_helper.get_margin_bottom

Why
I noticed this a while ago and it's been bugging me.
Visual Changes
None.

Sorry, I was probably one of those people adding brackets where brackets weren't needed!

@danacotoran actually I think I might have started this convention - I've certainly done it myself at some point.


Edititing CSS file

Hi!
Love the theme but would like to  make some small edits to customize it (change colors and add logos and things like that) I made a local copy of the theme and started editing and I usually don't have a problem editing css files with a text editor but this one is different from the ones I know. There seems to be no formatting and everything is in a very long line which  makes it hard to edit. Am I missing something? What do you use to edit the css file sheet?
Thanks alot!
Cheers,
Nora

The easiest way to do this is to override the theme css. To do this create a new css file and tell sphinx about it with http://www.sphinx-doc.org/en/stable/extdev/appapi.html#sphinx.application.Sphinx.add_stylesheet

Hm but wouldn't that still mean that I have to copy the CSS from you and edit it? Also, I have tried this with a different theme before and it didn't really work. It took the new CSS but it also took the old CSS and I was not really sure how to change things like that.

Ok, if that is not what you want you can add this project as a Git Submodule then use html_themepath to point to the sphinx_rtd_theme subfolder of this project. You can then make a branch for the theme and make your edits. The thing is that we do not use CSS directly but we use SASS. This means that you will have to compile the modified sass-files to css-files. See the readme of this project for more information on how to do this.
Because this is more complicated I just gave you the easy answer which still can be done by the way.

It took the new CSS but it also took the old CSS and I was not really sure how to change things like that.

You would have to see what CSS properties are defined for a specific element and replace it with something else. For example, to change the color of the blue region with the search bar to green create a css file with:
.wy-side-nav-search {
    background-color: green;
}

Here is a longer example of a project I contribute to: https://developer.blender.org/diffusion/BM/browse/trunk/blender_docs/resources/theme/css/theme_overrides.css


Correct use of hyphens

Correct use of hyphens

This PR also corrects German grammar (use of gleich and selber). This is missing from the PR description.

@MikeMcC399 right, description updated in OP


Bmg remove admin for check

I updated the main powershell script to no longer require admin rights to check the status of the DPST bit.
Pretty straight forward, just moved where the check is done to after the ifelse statement that currently exists since the check case never actually makes it that far. Additionally, I removed some spare spaces at the end of one of the lines because I saw them and it bothered me.
Seems to me like the only command that really needs Admin is the Set-ItemProperty command at the end of the script. Additionally, and the main reason I did this to begin with, it makes it easier to create a script to automatically disable the bit.
If I'm missing something here let me know.

"Bmg" remove admin for check
what's bmg?

"BMG" would be my initials. That's just the convention I use for branches at work.


MSID: 100064 Version: 1 DOI: 10.1101/2<IP_ADDRESS>5795

MSID: 100064
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>5795
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=100064
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>5795

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/100064v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>5795
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/100064/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c5) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c18) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c51) has a publication-type='other'. Is that correct?
warn: [title-upper-case] Content of  element is entirely in upper case: Is that correct? 'EXPERIMENTAL MODEL AND STUDY PARTICIPANT DETAILS'
warn: [title-upper-case] Content of  element is entirely in upper case: Is that correct? 'QUANTIFICATION AND STATISTICAL ANALYSIS'
warn: [empty-parentheses-presence] p element contains empty parentheses ('[]', or '()'). Is there a missing citation within the parentheses? Or perhaps this is a piece of code that needs formatting?


Support ltfs.hash.* EAs

Summary of changes
Support ltfs.hash.* EAs introduced into the LTFS format spec 2.4.

Fix of issue #297

Description
This commit also includes the refactoring about xattr.c.
Fixes #297
Type of change

New feature (non-breaking change which adds functionality)

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have confirmed my fix is effective or that my feature works

Merged into v2.4-stable by cherry-pick


Update README

[approve ci]

add to whitelist

[approve ci]

add to whitelist

[approve ci]

[add to whitelist]

add to whitelist

[add to whitelist]

[add whitelist]

add to whitelist

[approve ci]

[approve ci autest]

[approve ci centos]


Feature request: go to file by full path from git repository root

I want to go to file(Cmd+P) by absolute path from git repository root.
I'm coding with below project structure.
.
├── .git
│   └── ....
├── api
│   └── main.go
└── front
    └── app.ts

and, I open ./front directory with VSCode.
when I execute git status command in project root, I got below result.
Changes to be committed:
  (use "git rm --cached <file>..." to unstage)
	new file:   front/app.ts

so, I copy&paste front/app.ts to go to file input box, but got No matching result.
I understand that I will input app.ts to input box, but sometimes it gets messy...
JetBrains's IDE support it. I hope it will be easier to transfer if this is supported.

There isn't much we can do here. Quick open always runs off the top of the workspace folder, regardless of what your git roots are.
My suggestion is to simply open the terminal from within VS Code. I say this because since you opened the ./folder folder as the workspace folder, the terminal will have its cwd in ./folder and git will return this instead:
Changes to be committed:
  (use "git rm --cached <file>..." to unstage)
	new file:   app.ts

Then, there's a quick tip: hold Ctrl and hover over the file name in the Terminal, you'll be able to click it directly to open, instead of having to copy paste the value.


Issue-6 - Library and Sample App.  Have removed the sample application f...

Issue-6 - Library and Sample App.  Have removed the sample application from this project and introduced a test for the config loader

Come on Anurag, what's taking so long?  It's been 31 minutes since I created this pull request!

Very sorry for the delay. Will look into this tonight.


Add Tensorflow-Blade

In the past weeks, we have open-source some of the cpp and python code for tensorflow-blade, which optimize the tensorflow model for inference. The first stage of tensorflow blade open source is done when the following actions are complete:

[x] cpp code and related tests merged: pr
[x] python code and related tests merged: pr
[x] complete ci pipeline with develop docker: pr
[ ] tutorial for users to use tensorflow-blade
[ ] docs for design of tensorflow-blade
[ ] docs for make contribution to tensorflow-blade

One more thing:

[ ] Add TF-CPU CR tests


Dynatrace Keptn Dashboard Improvements

The "keptn configure monitoring dynatrace" is a great way to enable automatica generation of dashboards. Here a couple of improvements I would like to see
1: Use label "Services in dev", "Services in prod" for the headers where you list the links to the onboarded services
2: Filter the infrastructure tiles on top with the hosts that actually run this keptn instance. This probably requires you to install the OneAGent operator with a dedicated HOST_GROUP property that indicates the keptn installation name, e.g: "keptn k8s pre-prod" - with that you can then filter these tiles based on host group name
3: The section name "Operations" doesnt make sense when it just shows the link to the keptns bridge. I would simply call the section "Keptn" and change the link to "Open Bridge"
4: I would add a Disk and Memory Tile to the "Infrastucture" section as the dashboard then includes all major resources: cpu, network, disk, memory. Or consider
5: Add a section called "Environment Availability" - this would show synthetic tests that are testing the availablity of servies deployed in each stage
Following is a screenshot that includes my suggestions

Closing this issue because it is managed here https://github.com/keptn-contrib/dynatrace-service/issues/153


Generating Reference Token Instead of JWT

Please find below the steps I applied in order to generate Reference Token instead of JWT:

In the [Clients] table, I updated property [AccessTokenType] = 1. Please note that this is the client configured to be used from Angular Frontend app.

[Client] Table

[ClientScopes] Table
  "IdentityGuardsConfig": {
    "oidcSettings": {
      "authority": "http://localhost:5000",
      "client_id": "local_spa",
      "redirect_uri": "http://localhost:4200/#/identity-guards/auth-callback#",
      "post_logout_redirect_uri": "http://localhost:4200",
      "response_type": "id_token token",
      "scope": "openid profile inspection_profile",
      "filterProtocolClaims": true,
      "loadUserInfo": true,
      "automaticSilentRenew": true,
      "silent_redirect_uri": "http://localhost:4200/#/identity-guards/silent-refresh#"
    },
    "enableConsoleLogging": true,
    "postLoginRedirectUrl": "/portal"
  }

OIDC client configuration (Angular App)

Since API (/connect/introspect) is secure, I had to create API Resource and API Secret (as per this thread). Also as per the thread, I had to assign the exact scopes requested from Frontend client (3 scopes ==> opened, profile, inspection_profile)

[ApiResources] Table

[ApiSecrets] Table

[ApiScopes] Table
After applying the above configuration, IdentityServer service is returning reference token, also the reference token is being persisted in [PersistedGrants] table.
To validate the reference token, I was able to do that by hitting (/connect/introspect) API from Postman (below is the converted cURL request)
curl --location --request POST 'http://localhost:5000/connect/introspect' \
--header 'Authorization: Basic bG9jYWxfc3BhOlBAc3N3MHJk' \
--header 'Content-Type: application/x-www-form-urlencoded' \
--data-urlencode 'token=f007eff8fc2a3d8d9af7cb605b93b78d7004880d24356acebf928dae5a48dd8e'

Response:
{
    "iss": "http://localhost:5000",
    "nbf":<PHONE_NUMBER>,
    "exp":<PHONE_NUMBER>,
    "aud": "http://localhost:5000/resources",
    "client_id": "local_spa",
    "sub": "f6a5ccec-9d70-4c7c-ab50-7a932f685cac",
    "auth_time":<PHONE_NUMBER>,
    "idp": "local",
    "amr": "pwd",
    "email"<EMAIL_ADDRESS>    "name"<EMAIL_ADDRESS>    "given_name": "admin",
    "phone_number": "0506198339",
    "role": "SystemAdmin",
    "preferred_username"<EMAIL_ADDRESS>    "active": true,
    "scope": "openid profile inspection_profile"
}

Issue:
When I tried to access (/.well-known/openid-configuration) I’m getting the below exception:

An unhandled exception occurred while processing the request.
Exception: Found identity scopes and API scopes that use the same names. This is an invalid configuration. Use different names for identity scopes and API scopes. Scopes found: openid, profile, inspection_profile
IdentityServer4.Stores.IResourceStoreExtensions.Validate(IEnumerable identity, IEnumerable apiResources) in IResourceStoreExtensions.cs, line 60

Complete Stack trace:

Exception: Found identity scopes and API scopes that use the same names. This is an invalid configuration. Use different names for identity scopes and API scopes. Scopes found: openid, profile, inspection_profile
IdentityServer4.Stores.IResourceStoreExtensions.Validate(IEnumerable identity, IEnumerable apiResources) in IResourceStoreExtensions.cs
IdentityServer4.Stores.IResourceStoreExtensions.GetAllEnabledResourcesAsync(IResourceStore store) in IResourceStoreExtensions.cs
IdentityServer4.ResponseHandling.DiscoveryResponseGenerator.CreateDiscoveryDocumentAsync(string baseUrl, string issuerUri) in DiscoveryResponseGenerator.cs
IdentityServer4.Endpoints.DiscoveryEndpoint.ProcessAsync(HttpContext context) in DiscoveryEndpoint.cs
IdentityServer4.Hosting.IdentityServerMiddleware.Invoke(HttpContext context, IEndpointRouter router, IUserSession session, IEventService events) in IdentityServerMiddleware.cs
IdentityServer4.Hosting.IdentityServerMiddleware.Invoke(HttpContext context, IEndpointRouter router, IUserSession session, IEventService events) in IdentityServerMiddleware.cs
IdentityServer4.Hosting.MutualTlsTokenEndpointMiddleware.Invoke(HttpContext context, IAuthenticationSchemeProvider schemes) in MtlsTokenEndpointMiddleware.cs
Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Cors.Infrastructure.CorsMiddleware.Invoke(HttpContext context)
IdentityServer4.Hosting.BaseUrlMiddleware.Invoke(HttpContext context) in BaseUrlMiddleware.cs
Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.MigrationsEndPointMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.DatabaseErrorPageMiddleware.Invoke(HttpContext httpContext)
Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.DatabaseErrorPageMiddleware.Invoke(HttpContext httpContext)
Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

Important update
This organization is not maintained anymore besides critical security bugfixes (if feasible). This organization will be archived when .NET Core 3.1 end of support is reached (3rd Dec 2022). All new development is happening in the new Duende Software organization.
The new Duende IdentityServer comes with a commercial license but is free for dev/testing/personal projects and companies or individuals making less than 1M USD gross annnual revenue. Please get in touch with us if you have any question.


Cypress: Changes in the existing Cypress tests after Keycloak X Upgrade

Related to Jira#APS-947

[x] Changes in current Keycloak docker file for local execution
[x] Update Cypress tests if required for mew changes of Keycloak X version
[x] Perform Regression tests to make sure all functionalities of APS Portal are working as expected

Completed the activities and changes are merged in dev branch


Typing html:5 does not result in an suggestion in emmet

VSCode Version: Code - Insiders 1.14.0-insider (63def6eb989d62f23d3711ace0f795ce9f23551d, 2017-06-28T05:16:57.588Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author (truncated)
Version

Bookmarks
ale
0.15.2

path-intellisense
chr
1.4.2

gitignore
cod
0.5.0

gitlens
eam
4.2.0

tslint
eg2
0.15.0

LogFileHighlighter
emi
1.1.1

vscode-reveal
evi
0.0.9

php-debug
fel
1.10.1

php-intellisense
fel
1.4.1

auto-close-tag
for
0.4.2

gc-excelviewer
Gra
1.1.15

composer
ika
0.5.0

smarty
imp
0.2.0

json-to-ts
Mar
1.4.3

vscode-apache
mrm
1.1.1

cpptools
ms-
0.12.0

github-issues-prs
ms-
0.2.0

php-docblocker
nei
1.2.0

vscode-code-outline
pat
0.0.6

vscode-versionlens
pfl
0.19.1

vscode-icons
rob
7.10.1

sharecode
Rol
0.4.1

code-spell-checker
str
1.2.0

lorem-ipsum
Tyr
1.0.0

vscode-todo-highlight
way
0.5.5

highlight-trailing-white-spaces
yba
0.0.2

(2 theme extensions excluded)

Steps to Reproduce:

Create a new index.html file
Write html, see there is a html:5 suggestion
Type :, they are gone. 😢

Reproduces without extensions: Yes

@jrieken Looks like something changed in the filtering logic of suggestions. Your recent change around the inComplete:true maybe?
The emmet completion provider returns a completion list with inComplete set to true.
In stable, every letter typed would call the completion provider, but : would just filter existing results.
Stable:

In the current Insiders, every letter typed still calls the completion provider, but : filters out everything
Current Insiders:

Yes, I was curious in the first moment why it stopped working.

Oh, bummer... That's a regression from a change I made yesterday to fix #28400. I'll might revert that change...

Sorry to bother you. :/

Hm, reverting https://github.com/Microsoft/vscode/commit/5ad16183ab248948fdc457af0340321caf1ba987 (which is the fix for #28400) doesn't help. @ramya-rao-a It seems that : is registered as a trigger character and when we see that we invoke the provider in question and merge its results with the existing result. No, the problem is that that provider doesn't return anything and that the existing results don't match anymore...

@jrieken Looks like something changed in the filtering logic of suggestions. Your recent change around the inComplete:true maybe?

So, we did make a change yesterday (I think too early for the version this was reported for) which does the following: When a suggestion result is incomplete and if the word as stopped we don't re-trigger suggestions but filter the suggestions we currently have. So, when typing html: the word ends and we stop asking for new suggestions (that might be a problem with expansions form html:foo"bar but I am unsure that exists). However, since the results already contain html:5 it will be shown and can be selected.
I wonder if this was caused by having another provider that registers with the : trigger character (I believe https://github.com/Microsoft/vscode/commit/7ba1dcff0c5f89c4582598eef4e05830d4dce306). So what happens, and I don't think much has changed there, is that hitting a trigger-character only asks that provider (which doesn't return a result). Its (empty) result is being merged with the existing completions (from the incomplete provider) which didn't get a chance to update and hence fail the filter condition.
In short, there is something off. I am not yet convinced that a recent change caused this but things are complex. I acknowledge that there is a race between incomplete suggestions and trigger-characters, however I am a little scared to make a change late in the endgame.

Ok, the competing provider is the html-extension that registers those completion item provider: https://github.com/Microsoft/vscode/blob/master/extensions/html/server/src/htmlServerMain.ts#L75. Still not sure what as changed but I'll think about a fix

@ramya-rao-a I do have a change ready that makes sure to also resolve incomplete suggest results when a trigger character is being hit. However, when I ask emmet for completions with the html: prefix I just get that back, so no html:5. Fixing this bug uncovers another bug...
I believe that this used to work by accident (more than one thing is off here) and that's because before the completion item would have a filter html:5 and now it's just html. Both get compared to html: and latter won't match because it's shorter.

Thanks for all the digging @jrieken
I agree its too late in the end game for risky fixes.

I believe that this used to work by accident

I have added : as trigger character for emmet completions and updated the completion provider to return expected items.
So after https://github.com/Microsoft/vscode/commit/42ae1fc0f6122e5ca6b5237622bc8adadbb1c4f2 and https://github.com/ramya-rao-a/vscode-emmet-helper/commit/5875048b62a907eb4e7ebcbab7811ce878cb3f68, we get expected outcome.

Still an issue for abbreviations like ul*2
The suggestions disappear when * is typed.
Re-opening

Yeah, whenever we hit a word stops with incomplete results and when the result isn't matching that we cancel. That was done in https://github.com/Microsoft/vscode/commit/5ad16183ab248948fdc457af0340321caf1ba987. Feel free to revert and reopen the corresponding issue. I am on vacation now... 🏖

Happy holidays @jrieken 😃

I add the * and $ to trigger char list as well. So we are good on those fronts.

Note to verifier:

Try abbreivations with * $ : in your abbreviations and check you dont lose the suggestion list
Refer to https://docs.emmet.io/cheat-sheet/
Few things from the cheat sheet is not working due to upstream issue. See https://github.com/emmetio/atom-plugin/issues/27

@ramya-rao-a
Just tested emmett suggestions with : and * and there work fine.  $ also works in my php file but I am not sure if that's coming from emmet or the language server.
Thank you so much for your great work.

Thanks for all the feedback @nanaasumadu and @jens1o


[ci] Initial experiments with backport-bot

Issue and/or context: #1335
Changes:
Notes for Reviewer:
Not sure what else is needed to complete this -- things I've found:

https://github.com/TileDB-Inc/TileDB/pull/1669/files
https://github.com/tibdex/backport/blob/main/README.md
https://github.com/marketplace/actions/backporting

Testing now with this very PR, and branch release-1.2

Action https://github.com/single-cell-data/TileDB-SOMA/actions/runs/5390788414/jobs/9786667557 exists ...

I think I ran into this 'endless queue' with a repo too.  See https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners which lists no ubuntu-18.04 runners.   If it never picks up it may be worth changing to a runner they support.  (And yes I understand that Core's still work but who knows -- maybe they treat 'first runs' differently from 'grandfathered existing runs'.  Just a guess....)


winelib fixes

fix one gcc8 compiler warning
improve setup_dxvk.sh so it works for e.g. meson -Dbindir=bin32 -Dlibdir=lib32

Aren't these 2 unrelated changes?

To some degree, it's just more likely to run into that compiler warning with a winelib build. I didn't think a 2nd PR was justified just for that.

Sounds good to me. I dropped the major/minor patch here and created #689 to drop the unused version info.

Anything I should improve to get this small patch in?


chore: add share icon to collection

This PR resolves [https://artsy.slack.com/archives/C03N12SR0RK/p1710709509110609]
Description
This PR adds the share icon to the collection screen.
Next, I am thinking about how we can have allow sharing all screens easily. I already did the hard work here: https://github.com/artsy/eigen/pull/10199 so it shouldn't be hard to pull.
https://github.com/artsy/eigen/assets/11945712/7834bdca-5b33-405a-9369-ccadba2945e5

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

allow sharing collections - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (allow sharing collections - mounir)

  Generated by :no_entry_sign: dangerJS against cec6eac6e739e31e019d7bb5dd900a0246aa8b2a


Stop working

Describe the bug
That's not working anymore

when you clear the cookies, it will work but you have to do it every time

Please update to https://github.com/besuper/TwitchNoSub/releases/tag/0.7.1


Header now links to homepage

because i find myself clicking on it and being disappointed that it isn't a link

Found the r*dditor.
I don't really like this at all. I think a link to the index at the top is a good idea (maybe in the form of a small icon), but it makes no sense to me for someone to click on the name of the page and that takes you to the homepage. That's a design feature as annoying as Rddit or Twtter.

My caprices have changed and I've decided this is okay. I think it's better than having some extra line stolen by links.

Crap, actually, I'm going to revert this because it doesn't work with the markdown converter.
More reason we need a new static site generator.


If unauthenticated, map doesn't show optional challenges notice

If you're authenticated, this notice shows up at the top of the map:

If you aren't unauthenticated, this notice is hidden for some reason. It shouldn't be.

@QuincyLarson I'm not able to repro this and I can't see anything in the jade that should do this. Maybe it was just a hiccup on your end. Does this happen consistently if you try again?

Also cannot duplicate

I checked as well confirmed can't reproduce.
Closing for now.


DS-4411 Create Integration Tests to prove newly created users have no special rights

https://jira.lyrasis.org/browse/DS-4411
A full report of identified test to verify the correct behavior of each endpoint with a "normal" fresh user is available here
https://docs.google.com/document/d/13DMZ1iYE04D_6_8lrnHrI0uqKkz5RqMU6tWJMrHv88Y/edit?usp=sharing

Merging with one approval, per agreement in today's meeting.


The search does not get all accounts

As I know, the app should retrieve the full profile when I search by username or id. But I'm not able to get the profile for some account, You can try this id: 110866117

If a player has not enabled public match data and never signed into OpenDota through Steam then it's possible we may not have a record of that player.

So we have to enabled public match data AND signed into OpenDota through Steam to get the data, or we can get it by enabled public match data only?

either is fine.  The user needs to play matches after enabling public match data though.


Add uninstalling script

Had to do these changes manually to remove the plugin, thought it would be a nice addition to automate it.

Couple of thoughts:

Should be in the readme too, could you update that in the PR as well? (Same commit preferably)
Why were you uninstalling in the first place? :stuck_out_tongue: I never had it interfering.

I was trying to make use of command_not_found_handler() so had to disable the plugin.

Can you update the readme with uninstall instructions so I can merge this?

Thanks, merged!


Generating TSC declarations fails due to Metadata generator error w/specific imports

mobile platform: iOS
platform version : iOS 13, xCode 11.2.1
Desktop OS: macOS 10.14.6
NativeScript CLI version: 6.1.2
Framework used : Angular with TypeScript
Dependency: We are using the SDK PhotoEditor provided by Img.ly and available on cocoapods
The code source of their iOS native example is available here: https://github.com/imgly/pesdk-ios-examples
Summary:
When adding the cocoapod PhotoEditorSDK and running the the command '$ TNS_TYPESCRIPT_DECLARATIONS_PATH="$(pwd)/typings" tns build ios', the typings files generated doesn't contains inheritance for the class PESDKPhotoEditViewController. When using the same cocoapods in a Native iOS example, the class PhotoEditoViewController inherits from ImglyKit.MediaEditViewController.
Steps to reproduce:
Create a simple helloworld NativeScript app
$ tns create App1
Adding a Podfile to the iOS app
$ vi App_Resources/iOS/Podfile
platform :ios, '9.0'

target 'SwiftExample' do
  use_frameworks!
  pod 'PhotoEditorSDK', '~> 10.6.0'
end

Execute the command to generate the TypeScripts typings file
$ TNS_TYPESCRIPT_DECLARATIONS_PATH="$(pwd)/typings" tns build ios

Open the generated file typings/i386/objc!PhotoEditorSDK.d.ts
Expected: the class PESDKPhotoEditViewController inherits from PESDKMediaEditViewController (delcared in typings/i386/objc!ImglyKit.d.ts
Actual: the class inherits from nothin
Description of the expected result
If you create an iOS native project with Xcode and add the same Podfile, you will see that the class PhotoEditViewController is described like this in the PhotoEditorSDK:
/// A `PhotoEditViewController` is the main starting point for the SDK. It displays the rendered
/// photo and a menu. It can present `PhotoEditToolController` objects and react to changes. It
/// can be presented on its own (thus displaying a toolbar for navigation at the bottom) or be
/// embedded into a `UINavigationController` (thus using the navigation controller's navigation bar
/// for navigation).
@available(iOS 9.0, iOS 9.0, *)
@objcMembers @objc(PESDKPhotoEditViewController) open class PhotoEditViewController : ImglyKit.MediaEditViewController, ImglyKit.BrandedView {
.....
}

Why it's an issue
We need to display a PESDKPhotoEditViewController in the view, for that it must inherits from UIViewController.
MediaEditViewController inherits UIViewController.

Related to t1445343

The reason for the partially missing metadata (and respectively typescript definitions) is that the PhotoEditorSDK pod relies on Clang's modules feature. The metadata generator however, didn't support that, so we had to make it possible to turn modules on with #1236. After we merge the fix and release a version with it, you will just have to add the following line to your build.xcconfig file to correctly generate the metadata:
CLANG_ENABLE_MODULES=YES


Leet PW/AdminPW

Merged (I think) successfully

Nope. :) Looks like it was just closed.

Hang on. I tried to merge this change with a different project because it's my birthday and literally what. Fixing now. :-) Will you please resubmit PR?


Remove NEW_WITHDRAWALS_FLOW_DISABLED feature flag

Given the new withdrawals flow has been live for months now without issue we should remove the feature flag to reduce complexity in the application

@edavey I don't think so. The tests are written to test the app with the feature switch off (new withdrawals flow enabled) and we don't flip the feature switch as part of testing


run jest in project success, but get error from antd

💬 Questions and Help
I run jest in my project , and passed my test, but get error like this:
(node:47921) UnhandledPromiseRejectionWarning: TypeError: (0 , _insertCss.insertCss) is not a function
(node:47921) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:47921) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
 PASS  src/components/BaseList/__test__/index.test.tsx (7.772 s)
  src > components > BaseList
    componentDidMount
      ✓ should call initData & handleSearch (157 ms)
    initData
      ✓ should state panelHeight equals 100  (70 ms)

  console.log
    Current React Version: 16.13.1

      at Object.<anonymous> (jest.setup.js:16:9)
console.error
    Error: Uncaught [TypeError: (0 , _insertCss.insertCss) is not a function]
        at reportException (PROJECT_PATH/node_modules/jsdom/lib/jsdom/living/helpers/runtime-script-errors.js:66:24)
        at invokeEventListeners (PROJECT_PATH/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:209:9)
        at HTMLUnknownElementImpl._dispatch (PROJECT_PATH/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:119:9)
        at HTMLUnknownElementImpl.dispatchEvent (PROJECT_PATH/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:82:17)
        at HTMLUnknownElementImpl.dispatchEvent (PROJECT_PATH/node_modules/jsdom/lib/jsdom/living/nodes/HTMLElement-impl.js:30:27)
        at HTMLUnknownElement.dispatchEvent (PROJECT_PATH/node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:157:21)
        at Object.invokeGuardedCallbackDev (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:237:16)
        at invokeGuardedCallback (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:292:31)
        at flushPassiveEffectsImpl (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:22853:9)
        at unstable_runWithPriority (PROJECT_PATH/node_modules/scheduler/cjs/scheduler.development.js:653:12) TypeError: (0 , _insertCss.insertCss) is not a function
        at PROJECT_PATH/node_modules/@ant-design/icons/lib/utils.js:108:32
        at commitHookEffectListMount (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:19731:26)
        at commitPassiveHookEffects (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:19769:11)
        at HTMLUnknownElement.callCallback (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:188:14)
        at invokeEventListeners (PROJECT_PATH/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:193:27)
        at HTMLUnknownElementImpl._dispatch (PROJECT_PATH/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:119:9)
        at HTMLUnknownElementImpl.dispatchEvent (PROJECT_PATH/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:82:17)
        at HTMLUnknownElementImpl.dispatchEvent (PROJECT_PATH/node_modules/jsdom/lib/jsdom/living/nodes/HTMLElement-impl.js:30:27)
        at HTMLUnknownElement.dispatchEvent (PROJECT_PATH/node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:157:21)
        at Object.invokeGuardedCallbackDev (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:237:16)
        at invokeGuardedCallback (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:292:31)
        at flushPassiveEffectsImpl (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:22853:9)
        at unstable_runWithPriority (PROJECT_PATH/node_modules/scheduler/cjs/scheduler.development.js:653:12)
        at runWithPriority$1 (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:11039:10)
        at flushPassiveEffects (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:22820:12)
        at performSyncWorkOnRoot (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:21737:3)
        at PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:11089:24
        at unstable_runWithPriority (PROJECT_PATH/node_modules/scheduler/cjs/scheduler.development.js:653:12)
        at runWithPriority$1 (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:11039:10)
        at flushSyncCallbackQueueImpl (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:11084:7)
        at flushSyncCallbackQueue (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:11072:3)
        at scheduleUpdateOnFiber (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:21199:9)
        at Object.enqueueSetState (PROJECT_PATH/node_modules/react-dom/cjs/react-dom.development.js:12639:5)
        at Notification.Object.<anonymous>.Component.setState (PROJECT_PATH/node_modules/react/cjs/react.development.js:471:16)
        at Notification._this.add (PROJECT_PATH/node_modules/rc-notification/lib/Notification.js:78:13)
        at Object.notice (PROJECT_PATH/node_modules/rc-notification/lib/Notification.js:235:22)
        at PROJECT_PATH/node_modules/antd/lib/message/index.js:96:16
        at getMessageInstance (PROJECT_PATH/node_modules/antd/lib/message/index.js:48:5)
        at PROJECT_PATH/node_modules/antd/lib/message/index.js:95:5
        at new Promise (<anonymous>)
        at Object.notice [as open] (PROJECT_PATH/node_modules/antd/lib/message/index.js:86:22)
        at Object.error (PROJECT_PATH/node_modules/antd/lib/message/index.js:181:16)
        at PROJECT_PATH/src/lib/request/index.ts:22:15
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

      at VirtualConsole.<anonymous> (node_modules/jsdom/lib/jsdom/virtual-console.js:29:45)
      at reportException (node_modules/jsdom/lib/jsdom/living/helpers/runtime-script-errors.js:70:28)
      at invokeEventListeners (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:209:9)
      at HTMLUnknownElementImpl._dispatch (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:119:9)
      at HTMLUnknownElementImpl.dispatchEvent (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:82:17)
      at HTMLUnknownElementImpl.dispatchEvent (node_modules/jsdom/lib/jsdom/living/nodes/HTMLElement-impl.js:30:27)

  console.error
    The above error occurred in the <IconReact> component:
        in IconReact (created by AntdIcon)
        in span (created by AntdIcon)
        in AntdIcon (created by ForwardRef(CloseCircleFilled))
        in ForwardRef(CloseCircleFilled)
        in div
        in div (created by Notice)
        in div (created by Notice)
        in Notice (created by Notification)
        in AnimateChild (created by Animate)
        in span (created by Animate)
        in Animate (created by Notification)
        in div (created by Notification)
        in Notification

    Consider adding an error boundary to your tree to customize error handling behavior.
    Visit https://fb.me/react-error-boundaries to learn more about error boundaries.

      at logCapturedError (node_modules/react-dom/cjs/react-dom.development.js:19527:21)
      at logError (node_modules/react-dom/cjs/react-dom.development.js:19564:5)
      at update.callback (node_modules/react-dom/cjs/react-dom.development.js:20708:5)
      at callCallback (node_modules/react-dom/cjs/react-dom.development.js:12490:12)
      at commitUpdateQueue (node_modules/react-dom/cjs/react-dom.development.js:12511:9)
      at commitLifeCycles (node_modules/react-dom/cjs/react-dom.development.js:19883:11)
      at commitLayoutEffects (node_modules/react-dom/cjs/react-dom.development.js:22803:7)

I tried any way i can find, but still not get right way to fix it,  i have add   testPathIgnorePatterns: ['<rootDir>/dist/', '/node_modules/(?!@ant-design)(.*)'] and transformIgnorePatterns: ['<rootDir>/dist/', '<rootDir>/node_modules/']  in jest config, but it did't work.
have someone can help me ? Thinks!
Please note that this issue tracker is not a help forum and this issue will be closed.
For questions or help please see:

The Jest help page
Our #testing channel in Reactiflux
The jestjs tag on StackOverflow

Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions. You'll find more on Jest docs help page. Thank you :)

Finally i find the reason
//<EMAIL_ADDRESS>line: 106
......
var _insertCss = require("insert-css");
......
var useInsertStyles = function useInsertStyles() {
  var styleStr = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : iconStyles;
  (0, _react.useEffect)(function () {
    if (!cssInjectedFlag) {
      (0, _insertCss.insertCss)(styleStr, {
        prepend: true
      });
      cssInjectedFlag = true;
    }
  }) : null;
};

the source code is:
export const useInsertStyles = (styleStr: string = iconStyles) => {
  useEffect(() => {
    if (!cssInjectedFlag) {
      insertCss(styleStr, {
        prepend: true,
      });
      cssInjectedFlag = true;
    }
  }, []);
};

it's obviously that insertCss is a function like [Function: insertCss] { insertCss: [Circular] },  but when i test it, I console insertCss  and find _insertCsschanged as { process: [Function: process] }, I don't understand , can some one help me , thanks!