bug: external links don't open in react apps

Bug Report
Ionic version:
[x] 4.x
Current behavior:
IonItems that have href properties are supposed to automatically route to that href.  For "internal" links, this is behaving properly.  However, "external" links do not open.  Instead, they just pollute the URL with the external link
Expected behavior:
External links should open to the desired URL.
Steps to reproduce:

Create a new React based project with ionic start sidemenu-react sidemenu --type=react
Serve the project and open in browser
Click the external links to documentation in the Home page
Notice the URL updates to http://localhost:8100/https://ionicframework.com/docs/building/scaffolding

Related code:
Sample: https://stackblitz.com/edit/ionic-react-tabs

On the "Home" page, click the links to the documentation.

<IonItem href="https://ionicframework.com/docs/" target="_blank">
  <IonIcon slot="start" color="medium" icon={book} />
  <IonLabel>Ionic Documentation</IonLabel>
</IonItem>

Other information:
None
Ionic info:
Ionic:

   Ionic CLI       : 5.2.5 (/Users/jn/.nvm/versions/node/v10.16.3/lib/node_modules/ionic)
   Ionic Framework : @ionic/react 4.8.0-rc.1

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   NodeJS : v10.16.3 (/Users/jn/.nvm/versions/node/v10.16.3/bin/node)
   npm    : 6.9.0
   OS     : macOS Mojave

Have you tried onClick={() => window.open("http://url", "_system")}?

No, it's generally considered best practice to use href because Ionic will create an anchor tag that is accessible.

I have same problem.
According to Ionic React Navigation Docs https://ionicframework.com/docs/react/navigation, this is normal.

There are several options available when routing to different views in an Ionic React app. Here, the UsersListPage uses IonItem's href prop to specify the route to go to when the item is tapped/clicked:

External links are problem, I wrapped Item with  tag to solve problem. It is not good.

Here's an updated tabs sample using RC1.  It shows that external links do not open even when using React Router Does Link tag.
https://codesandbox.io/s/ionic-react-tabs-external-links-fail-rc1-tocey

Meet the same problem when learning ionic4 react at my first touching of front-end.
Actually, I tried some ways to solve this.
But it might be the best practical solution to fix it in creatComponent.

It is said this would change in rc3
deprecationWarning('hrefchange', 'As of RC3, href links no longer go through the router, so transitions will not be applied to these links. To maintain transitions, use the new routerLink prop.');

Yep, RC3 changed the href attribute to do a browser page redirect now, so you should be able to use it in conjunction with target to open pages in new tabs and such. The new routerLink attribute takes the place of what href did before.


add transparency support

Alpha values set for the Base and Shade colors do not affect opacity. This small change fixes that so you can now have translucent objects such as glass in your cel-shaded world.
Basically preserve the alpha of the base and shade colors by changing  vec3->vec4 & rgb->rgba. DIFFUSE_LIGHT is still just rgb and ALPHA is set at the end using the would-be diffuse alpha.
Please let me know if I overlooked something.
Example in action

Ohh! That bottle looks nice.
So... In version 3.0 of this shader I had planned to use the alpha channels of the shade and base textures to control the specular and ambient occlusion, but after seeing this, I think I'll move all that to a completely separate control texture.
I will merge this pull request now, but version 3.0 will completely overwrite the master branch, I will include the changes if I can, as well as add a global alpha uniform variable that will effect the entire material. I'll also include your name in the readme for the nice idea.
No promises of course, but I'll do my best, it's all a big feature balancing act because of the way the Godot light shader is implemented.

Awesome, thank you!


env: node: No such file or directory

I am unable  to add ts watch task  in Visual Studio Code on Mac

VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:23:26.125Z)
OS Version: Darwin x64 16.7.0

Error -
`
env: node: No such file or directory
The terminal process terminated with exit code: 127
Terminal will be reused by tasks, press any key to close it.`

This is the task.json, when i try to run the task, the  above mentioned error is thrown .
tasks.json ->
{

    "version": "2.0.0",
    "tasks": [
        {
            "label": "ts compile",
            "type": "shell",
            "command": "./node_modules/typescript/bin/tsc -w -p .",
            "windows": {
                "command": "node_modules\typescript\bin\tsc -w -p ."
            },
            "group": "build",
            "presentation": {
                "reveal": "always",
                "panel": "new"
            },
            "problemMatcher": [
                "$tsc-watch"
            ]
        }
    ]
}

I guess i figured out the problem,
Under VSCode -> user-settings , I am using
terminal.integrated.shell.osx : "path/to/zsh"

But I guess by default the task runner uses bash on mac/linux. After exporting path/to/node in
~/.bash_profile the error is no longer shown.
But I guess Vscode should pick the shell am using and try to get node's path

@rtalwar26 by default the task runner uses the shell that you see in the intergrated terminal. Will this be bash or zsh in our example?


Hash to field panics in ssa module

Description
Aim
Produce proof for a noir program using the hash_to_field function from the standard library:
use dep::std;
fn main(secret: [Field; 12]) -> pub Field {
    std::hash::hash_to_field(secret)
}

Expected behavior
Produce proof
Bug
➜  nargo prove p
thread 'main' panicked at 'not yet implemented: max value must be implemented for opcode hash_to_field ', crates/noirc_evaluator/src/ssa/integer.rs:494:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This is fixed on Noir source. I believe we just need to update our binaries to not have users run into this error any longer. @phated @kobyhallx

After updating binaries:
Running nargo check create PROVER.toml and VERIFIER.toml so it is not just a check.
When running nargo prove p it will not execute, but the return is not updated, will just leave empty when return = "" set before, this worked before. Might just be that it is never updated in the toml.
Generated proofs are invalid. Generating proof with 0x01 and 0x02 as the field elements going into secret (updated to be length 2 insetead of 12),


docs: dependent resources

for just created branch and a skeleton (well a very skinny one), to start on the docs for dependent resources.
Will continue expanding this.

will take a look on this failing integration  test in a separate PR

Let's merge this and open subsequent PRs for more improvements.


Provide page (with unique URL) for a specific location and date

To help with archiving and sharing, it would be useful to have a page like the summary page but also with a date specified
If available, it should show the smoothed stats (7 day rolling averages) centered around the given date
If not available, it should show the latest available data and linearly extrapolated data
It should provide a link to microCOVID with pre-filled parameters, including the linear extrapolation via the casesIncreasingPercentage parameter

Implemented mainly in 3d1244df06a8b0ef9cefef82d86556ee63c6e55f and 6ad251a61005baf413658e450e51c342be07dc74


myForm.files.$error.minHeight doesn't work?

I want to show validate error message,but it doesn't work.
                               <form name="myForm">

                                        File name: *
                                        <input type="text" size="20" class="form-control" placeholder="Please input file name" name="filename" ng-model="filename" maxlength="50" required />

                                        <input type="file" id="file" ng-model="files" name="files" accept="image/*" ngf-min-height="600" ngf-min-width="600" required/>

                                        The image width or height should be at least 600!

                                        {{alertmessage}}

                                    <button class="btn btn-primary" ng-disabled="!myForm.$valid" ng-click="upload(files)">Upload</button>
                                </form>

myForm.filename.$error

@danialfarid
Hi,I want to valididate the selected image width and height,the above code is correct?

use

@danialfarid
Thank you for your answer,but filename is which user can custom name for file.I guess we need to validate input file model,but it doesn't work.

Follow the sample jsfiddle validation on the docs. That is the name of the form element.

Thank you.It is resolved.


resolve issue #42

ReplicaCall

fix decoding response (#42)
fix ignoring timeout while waiting for future.Get()

Introduce Replicaset.CallAsync and struct Future
Add tests for methods of Replicaset and Future

resolve #42

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 31.87%. Comparing base (696fc12) to head (41db891).

Files with missing lines
Patch %
Lines

replicaset.go
0.00%
23 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   32.24%   31.87%   -0.38%
==========================================
  Files          10       10
  Lines         676      684       +8
==========================================
  Hits          218      218
- Misses        442      450       +8
  Partials       16       16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How should empty() handle missing fields?

$row = $db->fetch("some/query");

if(empty($row->missing_field)) {
// ...
}

Currently throws NoSuchColumnException.

Disallowing empty checks is an action that I consider buggy now, having used this for a while. Applying bug label.


Pull request with all the edits needed to compile the dataset

This ugly pull request contains a ton of edits that were necessary to produce the current version of the dataset. it will close #75

@al-jshen can you look at it and see if there is anything crazy that stands out?

otherwise we should merge it since it corresponds to the current version of the dataset

I think I've fixed all the test, fingers crossed


createStyles typing should take a partial

[X] The issue is present in the latest release.
[X] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
I want to be OCD and ensure I only declare style overrides that a component actually supports, i.e.:
// Overriding button styles
function styles(theme: Theme) {
  return createStyles({
    foobar: {
      boxShadow: "none",
    },
    root: {
      boxShadow: "none",
    }
  });
}

Has an error because foobar isn't a valid class key.
What I'd like to do is go ahead and explicitly say I'm making styles for button:
function styles(theme: Theme) {
  return createStyles<ButtonClassKey, Theme>({
    foobar: {
      boxShadow: "none",
    },
    root: {
      boxShadow: "none",
    }
  });
}

And get a compile error on foobar.
Which, I do, however, I also get a compile error that label, text, and all the other button class keys are missing.
If I specify only root:
function styles(theme: Theme) {
  return createStyles<"root", Theme>({
    foobar: {
      boxShadow: "none",
    },
    root: {
      boxShadow: "none",
    }
  });
}

Then the styles function compiles, but all the instantiations fail.
Expected Behavior 🤔
createStyles takes a Partial but I can't easily represent that in the type.
I'm pretty sure createStyles just needs to be updated to be:
export default function createStyles<ClassKey extends string, Props extends {}>(
  styles: Partial<StyleRules<Props, ClassKey>>,
): StyleRules<Props, ClassKey>;

Also I'm admittedly a little surprised that StyleRules itself doesn't have a Partial, because my understanding is that the style rules structure (as returned by createStyles) are optional keys.
Your Environment 🌎

Tech
Version

Material-UI
v4.4.2

cc @merceyz and @eps1lon since you've touched the createStyles.d.ts file; apologies/thanks! :-)

Duplicate of #15777

@eps1lon ah sorry about that, thanks!

@eps1lon ah sorry about that, thanks!

No worries. Even with knowing that this came up before I had to browse 2 pages of issues.


Have the endpoints return on header version code

We could add that given a parameter of the endpoint class each method returns in the response header its own version.
This should allow, mainly in the external apps to check which version of ecah endpoint is deployed to check that CI/CD processes have worked properly.
This should be added to the response headers with a decorator that it can be a logic that all endpoint methods can use

More information here: https://flask-restful.readthedocs.io/en/latest/quickstart.html
As we inherit from flask_restful Resource we can send back a custom header that gets added to the rest of the headers


Does not work in FireFox

phone.js line 63 uses a search property on an HTMLLinkElement. I couldn't find any documentation on this and since it works in Chrome I assume it is a Chrome only thing?
URI.js is an excellent URI parser with a search feature like your using. Plus it is fully compatible with all browsers. Worth a look maybe.

I'd love to have a pull request, but I'd prefer to use a light-weight library that just handles parsing of the the href.indexOf('?'), such as this http://stackoverflow.com/a/7826782

Hahaha, that's already there.
Like this:
var href = "https://example.com?foo=bar"; // tested against "https://example.com#foo=bar" also
var index = href.indexOf('?') + 1;
var search;

if (0 === index) { index = href.length; }
search = href.substr(index);

Could you make a pull request with a change like that?

Could you make a pull request with a change like that?

I'll put it on my list. Just know that list is quite long right now.

Updated
The repo that has this change is here: https://git.coolaj86.com/coolaj86/browser-authenticator.js


Octoprint plugin

Any chance of this becoming an octoprint plugin?

Making it a octoprint plugin is requires a lot of work. The two main problems are:

Octoprint plugins are written in Python, the current project is written in Javascript. So I cannot reuse any of the existing code.
Octoprint runs on raspberry pi, which has very limited resource comparing to a PC. The code needs to be optimized.
I will consider making it a octoprint plugin when I have some free time, but it will definatly take some time.

Just to push this a little bit ;) Python is just the framework in this case. Most of the plugins do the computation stuff in js.

Hoping for this as well

Have you tried running it as-is on RPi 3 with nodejs? What is the speed as compared to desktop?

I tested it on RPi.  It's about 8 times slower than my computer.  Not too horrible...

@eyal0 The program could take more memory then RPi 3 has with large gcode files, in which case the speed will be even slower than that.
The V2 I'm working on will use much less memory, and have APIs to accept data stream from Octoprint plugin.

Do you have sample large gcode files that use too much memory? In my testing, all large files worked. I'm also able to run Slic3r on really big files on RPi.
What will the OctoPrint plugin do?

I don't have the gcode anymore. The one I used for testing is a little over 100MB.
The plug in will add a button beside the gcode files, once clicked it will open a gcodeanalyser window. The code file and settings will be automatically transferred over.

Okay, so it would just run the analysis and that's it?  Would it incorporate the results into OctoPrint somehow?  For example, a better estimated print time?

I can probably write the result back to OctoPrint. I'll have more detail when I start working on it, I haven't really give too much thought yet.

I'm working on another project that will support gcode processing on the server side, it's a better candidate for Octoprint plugin support. Processing gcode will remain in the browser on the client side for this project.


handle unchecked exceptions in handleHttpResponse()

Issue details
If you look at this file:
https://github.com/libgdx/libgdx/blob/master/gdx/src/com/badlogic/gdx/net/NetJavaImpl.java
On line 204 handleHttpResponse() of the given listener is called. When I override this method in my HttpResponseListener and within this method an exception is thrown some strange happens:
Reproduction steps/code
I made an example project:
https://github.com/TomGrill/NetJavaImplProblemExample
Whenever an exception is thrown within handleHttpResponse() and I do not catch this exception, then the exception will be caught on line 210 and on line 213 the failed() method of my listener is called AFTER handleHttpResponse() has already been called.
So my question is:
Am I supposed to handle unchecked exceptions (for checked exceptions I am of course) within handleHttpResponse() to prevent failed() beeing called? If so I think this is a design flaw since it is very easy to oversee an unchecked exception. Maybe at least put this to the description of the handleHttpResponse() method to warn users about this problem.
It took me quite a while to figure out a bug I had in my code.
Is this good and supposed to be like it is or do we need to rewrite the class above? I am happily making a PR. Just want to discuss what you think before acting.

As you noticed, guarding against unchecked exceptions is essentially a lost battle. Not only in your code, but also in libGDX's code. A case can be made to let the app fail hard and not call the failure callback.


Add paper to NKILA

Annotate URS00008120E1_9606 with doi:10.1007/s11033-021-06482-y.

We now use litscan to handle things like this.


"Soft delete" scans

When we delete scans, we don't want to entirely delete them, because then we won't be able to get information about the actual scan and its schedule when examining its associated scan tasks. Instead, we should allow users to only "disable" / "soft-delete" scans.

Closed in favor of #228.


Is it possible to create short-cut to AnyDesk and MobTime on the task bar by script

It would be great if the scripts could set up a few common shortcuts.

I'm closing this because it's been done - thank you!
https://github.com/JayBazuzi/machine-setup/blob/982619347951bcdbcbc5cc0ca4eb4e49e51e12f6/windows.ps1#L41-L51

I'm closing this because it's been done - thank you!
https://github.com/JayBazuzi/machine-setup/blob/982619347951bcdbcbc5cc0ca4eb4e49e51e12f6/windows.ps1#L41-L51


Edits for public preview launch

Changes:

copy editing for index, metrics, and profiling
add logo
re-order Beyla, will appear after Applicaiton Observability and Frontend Observability under Monitor Applications

Codecov Report
Patch coverage has no change and project coverage change: -30.54% :warning:

Comparison is base (2f620ea) 78.39% compared to head (ff92e7f) 47.85%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #276       +/-   ##
===========================================
- Coverage   78.39%   47.85%   -30.54%
===========================================
  Files          41       33        -8
  Lines        3240     2495      -745
===========================================
- Hits         2540     1194     -1346
- Misses        537     1226      +689
+ Partials      163       75       -88

Flag
Coverage Δ

integration-test
?

unittests
47.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 30 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

It looks like I can merge without a review. Since there no major changes just editing, I will merge and we can make any tweaks afterwards if necessary.


Support for curve secp521r1

Resolved issues:
We use s2n in server mode and need the elliptic curve secp521r1 for specific usage.
Description of changes:
s2n only support secp256r1 and secp384r1, with this change, s2n will support a new curve secp521r1.
And add a new security policies and ecc preference to contains these 3 curves.
Testing:
Add new unit test and integration test. All of test case passed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2344 into main will increase coverage by 5.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2344      +/-   ##
==========================================
+ Coverage   81.56%   87.56%   +5.99%
==========================================
  Files         267      166     -101
  Lines       18163    13923    -4240
==========================================
- Hits        14814    12191    -2623
+ Misses       3349     1732    -1617

Codecov Report

Merging #2344 into main will increase coverage by 5.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2344      +/-   ##
==========================================
+ Coverage   81.56%   87.56%   +5.99%
==========================================
  Files         267      166     -101
  Lines       18163    13923    -4240
==========================================
- Hits        14814    12191    -2623
+ Misses       3349     1732    -1617

Codecov Report

Merging #2344 into main will increase coverage by 5.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2344      +/-   ##
==========================================
+ Coverage   81.56%   87.56%   +5.99%
==========================================
  Files         267      166     -101
  Lines       18163    13923    -4240
==========================================
- Hits        14814    12191    -2623
+ Misses       3349     1732    -1617

Codecov Report

Merging #2344 into main will increase coverage by 5.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2344      +/-   ##
==========================================
+ Coverage   81.56%   87.56%   +5.99%
==========================================
  Files         267      166     -101
  Lines       18163    13923    -4240
==========================================
- Hits        14814    12191    -2623
+ Misses       3349     1732    -1617

Codecov Report

Merging #2344 into main will increase coverage by 5.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2344      +/-   ##
==========================================
+ Coverage   81.56%   87.56%   +5.99%
==========================================
  Files         267      166     -101
  Lines       18163    13923    -4240
==========================================
- Hits        14814    12191    -2623
+ Misses       3349     1732    -1617

Codecov Report

Merging #2344 into main will increase coverage by 5.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2344      +/-   ##
==========================================
+ Coverage   81.56%   87.56%   +5.99%
==========================================
  Files         267      166     -101
  Lines       18163    13923    -4240
==========================================
- Hits        14814    12191    -2623
+ Misses       3349     1732    -1617


Uncaught Error: Module did not self-register.

[Enter steps to reproduce:]

...
...

Atom: 1.40.0 x64
Electron: 3.1.10
OS: Mac OS X 10.14.6
Thrown From: Atom Core
Stack Trace
Uncaught Error: Module did not self-register.
At ELECTRON_ASAR.js:166

Error: Module did not self-register.
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:166:20)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:740:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:180:18)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:559:12)
    at Function.Module._load (internal/modules/cjs/loader.js:551:3)
    at Module.require (/app.asar/static/index.js:72:46)
    at require (internal/modules/cjs/helpers.js:20:18)
    at customRequire (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:1:688158)
    at get_KeyboardLayoutManager (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2744622)
    at get_manager (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2744724)
    at Object.getCurrentKeyboardLayout (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2744850)
    at e.keystrokeForKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:1087821)
    at KeymapManager.keystrokeForKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:1246932)
    at KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:1244917)
    at WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:284329)

Commands
     -1:03.6.0 command-palette:toggle (atom-pane.pane.active)

Non-Core Packages
ide-python 1.5.0

Thanks for contributing!
We noticed that this looks like a duplicate of https://github.com/atom/atom/issues/20049 so you can subscribe there for updates if you'd like.

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Add qingping cgdk2

Add import in init

Rebase the branch, please to the HEAD of this repo

I'm using the rebasing model for branched and until your branch is not rebased on top the button is disabled.
You have to fetch the upstream and rebase you code on top of it.


Fix type annotations for converter types, considering the Converter class

Summary
A converter can either be a callable with a single argument or an instance of the Converter class, fix the type annotation to allow both cases everywhere _ConverterType is used
Also update field() and attr.ib() which are able to take a list or tuple of converters as an implicit pipe, add type annotations for that syntax
Pull Request Check List

[x] Do not open pull requests from your main branch – use a separate branch!

There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
This is not a pre-requisite for your pull request to be accepted, but you have been warned.

[x] Added tests for changed code.
Our CI fails if coverage is not 100%.
N/A New features have been added to our Hypothesis testing strategy.
[x] Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).

[x] ...and used in the stub test file tests/typing_example.py.
N/A If they've been added to attr/__init__.pyi, they've also been re-imported in attrs/__init__.pyi.

N/A Updated documentation for changed code.
N/A Documentation in .rst and .md files is written using semantic newlines.
[ ] Changes (and possible deprecations) have news fragments in changelog.d.
[x] Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

@hynek Would you kindly take a look whenever possible? Thanks!

It looks to me like worthy a changelog entry because apparently converters are better supported now? 🤔

I believe Converters are already mentioned in the changelog for 24.1.0:
"It is now possible to wrap a converter into an attrs.Converter and get the current instance and/or the current field definition passed into the converter callable.
Note that this is not supported by any type checker, yet. https://github.com/python-attrs/attrs/issues/1267"
This just fixes some type annotations but I believe full type checker support would need some mypy changes (see commented out code) so not sure how much is worth mentioning in a changelog.
Having said that, feel free to add a note if you'd like 😃


Check that PyPI supports manylinux wheels

Just a minor check.

This note seems to imply that PyPI does not support platform wheels. But more recently, PEP513 mentions PyPI support for manylinux wheels.
More importantly, there are packages in PyPI (such as Pillow) which already provide manylinux wheels. So I think we are ok.
Also, the way the Pillow wheels are built seems interesting.

Yes, it seems that manylinux wheels can be added to PyPi.
The OS X builds could be done as they are done in the Pillow repo. I think also that we could use the same submodule method for obtaining OpenCV. That way the version could be locked to certain commit and updated manually whenever needed.


Fix infinite redirect loop when redirect property set to - none -

If redirect on the session component is set to - none - then the page ends in an infinite redirect loop. This adds a check and throws an exception rather than redirecting in that specific case.

@SeriousKen it might be a better idea if it throws a different exception, i.e. an actual exception so that the developer knows that they need to set a redirect property. For sites in production it will just take them to the 500 error page instead of showing the message so that should be fine. It's not that their request was denied, it's that the application doesn't have enough information to properly respond to their request.


Reasons for using SerializationFeature.WRITE_ENUMS_USING_TO_STRING

Swagger uses SerializationFeature.WRITE_ENUMS_USING_TO_STRING, which seems as an odd choice especially for generating OpenAPI spec documentation. If toString() returns values different from the actual enum values, then API calls won't work, since the enums won't get deserialized (unless the API uses READ_ENUMS_USING_TO_STRING).
I believe that the default should be changed or that it should at least be configurable. In my experience, I have seen READ_ENUMS_USING_TO_STRING being used,
What was the reason behind setting this value to true? Should it be changed / made configurable?
This caused us problems when upgrading from older Swagger version.

Thank you for your answer @frantuma . I found the configuration and tested - it worked ok.
Thanks again.


Crash on selecting 'Images'

I am running BoilR on Steam Deck, with latest system software and up to date BoilR from Flathub.
The program starts fine, but when 'Images' is selected on the left side of the main Window, it crashes. Here's the output from the terminal:
(deck@steamdeck ~)$ flatpak run io.github.philipk.boilr
Setting for platform EGS are invalid, reason: Manifests not found
Setting for platform Legendary are invalid, reason: No such file or directory (os error 2)
Setting for platform Itch are invalid, reason: Path not found: Some("/home/deck/.config/itch/db/butler.db-wal")
Setting for platform Origin are invalid, reason: Default path not found
Setting for platform Gog are invalid, reason: Could not find path: "/home/deck/Games/gog-galaxy/drive_c/ProgramData/GOG.com/Galaxy"
Found 2 game(s) for platform Heroic
Setting for platform Flatpak are invalid, reason: No such file or directory (os error 2)
thread 'main' panicked at 'source slice length (1620000) does not match destination slice length (2160000)', /run/build/boilr/cargo/vendor/image-0.24.3/./src/codecs/webp/extended.rs:462:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I've tried to run Rust backtrace as suggested in the error, by running flatpak run io.github.philipk.boilr --env='RUST_BACKTRACE=1'  but it does not seem to work. I am uncertain if I'm not doing something right, or the error message is wrong/outdated.
Please let me know if there's anything further I can do to provide diagnostic info.

This seems to be a problem with one of the thumbnails for the images being corrupt or something. I will try to fix it by just letting boilr ignore it if it can't parse the image.

This should be solved in version https://github.com/PhilipK/BoilR/releases/tag/v.1.4.4 now. Let me know if it does not work for you.

@PhilipK This issue is not resolved for me in 1.4.4. I get same symptoms, crashing when I select 'Image', the terminal output is thus:
(deck@steamdeck ~)$ flatpak info io.github.philipk.boilr

BoilR - Add non-steam games to your steam library

          ID: io.github.philipk.boilr
         Ref: app/io.github.philipk.boilr/x86_64/stable
        Arch: x86_64
      Branch: stable
     Version: 1.4.4
     License: MIT-0 OR Apache-2.0
      Origin: flathub
  Collection: org.flathub.Stable
Installation: system
   Installed: 12.8?MB
     Runtime: org.freedesktop.Platform/x86_64/21.08
         Sdk: org.freedesktop.Sdk/x86_64/21.08

      Commit: 8f6627e354200e64674e97c3e3f4ba1fc1172f8abf1f0ba2888573cdf1060540
      Parent: fee4c03e62cc08fa9a5ccf0b4b0ba453c6df760342c34788bac4995a1bd90872
     Subject: Update version to v.1.4.4 (008554d9)
        Date: 2022-08-15 13:22:46 +0000
(deck@steamdeck ~)$ flatpak run io.github.philipk.boilr
Setting for platform EGS are invalid, reason: Manifests not found
Setting for platform Legendary are invalid, reason: No such file or directory (os error 2)
Setting for platform Itch are invalid, reason: Path not found: Some("/home/deck/.config/itch/db/butler.db-wal")
Setting for platform Origin are invalid, reason: Default path not found
Setting for platform Gog are invalid, reason: Could not find path: "/home/deck/Games/gog-galaxy/drive_c/ProgramData/GOG.com/Galaxy"
Found 2 game(s) for platform Heroic
Setting for platform Flatpak are invalid, reason: No such file or directory (os error 2)
thread 'main' panicked at 'source slice length (1620000) does not match destination slice length (2160000)', /run/build/boilr/cargo/vendor/image-0.24.3/./src/codecs/webp/extended.rs:462:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I am going to reopen this, it turns out to be a bug in the library that decodes the images, if the images are webp format.
https://github.com/image-rs/image/issues/1740
I will see if I can make a pull request for the image library or maybe just ignore all webp images or something in boilr.

@ak-42 can you (or anyone that experiences this bug) try to run this beta version?
https://github.com/PhilipK/BoilR/releases/tag/v.1.4.4-beta
I have tried to wrap the library that throw the panic/crashes in a thread of its own, which should let the main thread continue.
Would like to know that this is actually solved before I make a new official release.

@PhilipK I'm having trouble installing the file directly. The documentation says it should be just flatpak install linux_BoilR but that results in response error: No remote refs found similar to linux_BoilR. If I add the extension .flatpak which seems to be expected, the response is error: Invalid checksum of length 0 expected 32.
Am I doing something wrong?

Oh, that is not a flatpak release.
Simply just double click it.
It's a standalone native version (like an exe on windows)

Oh, sorry, didn't even occur to me that it'd be a binary on its own.
Well, it still crashes. Here's the terminal output:
(deck@steamdeck Downloads)$ ./linux_BoilR
Setting for platform EGS are invalid, reason: Manifests not found
Setting for platform Legendary are invalid, reason: No such file or directory (os error 2)
Setting for platform Itch are invalid, reason: Path not found: Some("/home/deck/.config/itch/db/butler.db-wal")
Setting for platform Origin are invalid, reason: Default path not found
Setting for platform Gog are invalid, reason: Could not find path: "/home/deck/Games/gog-galaxy/drive_c/ProgramData/GOG.com/Galaxy"
Found 2 game(s) for platform Heroic
Found 22 game(s) for platform Flatpak
thread 'main' panicked at 'source slice length (1620000) does not match destination slice length (2160000)', /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/image-0.24.3/./src/codecs/webp/extended.rs:462:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The last two lines only occur when the 'Images' is clicked, rest upon launch.

I simply can not figure out that kind of input (image) that would cause this. @ak-42 Would it be possible for you to zip your steam grid folder (the one containing all your custom images) and upload it? It could just be the webp images, as it seem from the log that it is an .webp image that is causing the crash.

@PhilipK You can download all the .webp files from /home/deck/.local/share/Steam/userdata/<ID>/config/grid/via the below link:
https://send.vis.ee/download/0d90a4c137b45ede/#WZoQWJ9npqGy4rXLgJ81SA
Please note that this link will expire after 1 successful download or within 7 days, whichever comes first.
I cannot open<PHONE_NUMBER>p.webp,<PHONE_NUMBER>p.webp or<PHONE_NUMBER>p.webp using a standard image viewer with webp support either, so the culprit is likely one of those.
Also, I have never attempted to manage or modify these files on my own, so if they're corrupted, they were likely corrupted by BoileR's download process. Maybe consider adding a post-download integrity check?

That helps a lot! I will look at doing some validation later today (after work)

I got the files, you can delete all those webp images, that should get you around the crash.
I will try to fix the problem later.

I found the cause of the problem, they are animated webp images, the image library used panics when it tries to load them.

Alright, https://github.com/PhilipK/BoilR/releases/tag/v.1.4.4-beta2 can you try the newest beta.
It should work now, it uses my forked version of the image library, that has the bugfix for the panic/crash.

can you try the newest beta.

@PhilipK If this is for me, I can no longer replicate the crash as I've deleted the webps and the crash no longer occurs even on the current stable unfixed version.

This should be fixed in the newest version, if it comes up again, I will reopen this issue.

Still crash on newest version (both the flatpack or linux executable) on steam deck when choosing "images" tab
thread 'main' panicked at 'source slice length (1620000) does not match destination slice length (2160000)', /home/runner/.cargo/git/checkouts/image-ed333a7345ddf6ae/cb66840/./src/codecs/webp/extended.rs:474:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Found 0 game(s) for platform Lutris
Found 2 game(s) for platform Heroic
Found 14 game(s) for platform Flatpak

Sorry to be that guy, but:
@herbzhao are you 100% sure that it is the newest version? 1.4.7?
Did you run flatpak update ?
I cannot reproduce it with anythig I have thrown at it.
If you have the native version, could you try to run RUST_BACKTRACE=1, so I can see the stacktrace?

Hi , no worries, I am running  the native 1.4.7 (only got my deck 2 days ago)
here are the output
thread 'main' panicked at 'source slice length (1620000) does not match destination slice length (2160000)', /home/runner/.cargo/git/checkouts/image-ed333a7345ddf6ae/cb66840/./src/codecs/webp/extended.rs:474:21
stack backtrace:
   0:     0x7f4c01626d5d - <unknown>
   1:     0x7f4c0164f96c - <unknown>
   2:     0x7f4c0161fb11 - <unknown>
   3:     0x7f4c016286a5 - <unknown>
   4:     0x7f4c016283c6 - <unknown>
   5:     0x7f4c01628c36 - <unknown>
   6:     0x7f4c01628b27 - <unknown>
   7:     0x7f4c01627214 - <unknown>
   8:     0x7f4c01628859 - <unknown>
   9:     0x7f4c00e37bb3 - <unknown>
  10:     0x7f4c00e37df2 - <unknown>
  11:     0x7f4c01002aed - <unknown>
  12:     0x7f4c00faaaad - <unknown>
  13:     0x7f4c00fbdbc2 - <unknown>
  14:     0x7f4c00f72f01 - <unknown>
  15:     0x7f4c00fa6443 - <unknown>
  16:     0x7f4c00ee5534 - <unknown>
  17:     0x7f4c00fc5ddf - <unknown>
  18:     0x7f4c00e9c911 - <unknown>
  19:     0x7f4c00ef37df - <unknown>
  20:     0x7f4c00ef62cd - <unknown>
  21:     0x7f4c00ef667d - <unknown>
  22:     0x7f4c00ea0c86 - <unknown>
  23:     0x7f4c010deadd - <unknown>
  24:     0x7f4c0111d18d - <unknown>
  25:     0x7f4c0111c357 - <unknown>
  26:     0x7f4c010e6339 - <unknown>
  27:     0x7f4c010e6cf2 - <unknown>
  28:     0x7f4c0112972b - <unknown>
  29:     0x7f4c01109531 - <unknown>
  30:     0x7f4c0111d959 - <unknown>
  31:     0x7f4c010f4b45 - <unknown>
  32:     0x7f4c00ea15d8 - <unknown>
  33:     0x7f4c00f49723 - <unknown>
  34:     0x7f4c00f7d889 - <unknown>
  35:     0x7f4c01618c6e - <unknown>
  36:     0x7f4c00ea4ad2 - <unknown>
  37:     0x7f4c0049bb25 - __libc_start_main
  38:     0x7f4c00e37eae - <unknown>
  39:                0x0 - <unknown>

Again, this is some kind of panic in the image-rs package, and again it is related to webp.
I know it is a big ask, but could you look in your grid folder and send me the webp images from it?
Also, you should be able to "solve" your problem by just removing the webp from your grid folder.

Hi, could you tell me where would I find the folder? I have narrowed down to which game causes the crach, it is the Tunic

Nvm, i have narrowed down to these two webp.
grid_1.zip

Thanks, I can reproduce the error with those images


cloudflare pre-clearance integration

🆒 Your use case
Hey there :wave:
I'll be implementing cloudflare turnstile pre-clearance at work; Do you think it is something we should provide through this package ?
Here the doc
🆕 The solution you'd like
I guess we could provide something like an interrceptor for $fetch, even applying it by default :thinking:
🔍 Alternatives you've considered
No response
ℹ Additional info
No response

Let's do it then ! I'll try to implement it next week

hey :wave: , I still haven't implemented this :joy:


CLI: Adds rm and add flags to popper add subcommand

Addresses #148

Hello @UjjwalAyyangar! Thanks for submitting the PR.

In the file cli/popper/commands/cmd_search.py, following are the PEP8 issues :

Line 55:6: W291 trailing whitespace
Line 61:1: W293 blank line contains whitespace
Line 66:1: W293 blank line contains whitespace
Line 69:1: W293 blank line contains whitespace
Line 74:1: W293 blank line contains whitespace
Line 108:1: W293 blank line contains whitespace
Line 112:1: W293 blank line contains whitespace
Line 114:5: E303 too many blank lines (3)

Closing due to unavailability of environment variables in travis to forks.
Explained here


[FAIL] Finch Core E2E Tests Compose build command [It] should build services defined in the compose file specified by the COMPOSE_FILE environment variable

I am having a hard time root causing this test failure. The behavior appears to be correct locally when I run nerdctl v2.0.2

Rerunning tests in https://github.com/runfinch/finch-core/pull/390, my hunch is this test has never successfully worked in finch-core and is not nerdctl 2.0 regression.

Verified the test failure is finch-core only as limactl/nerdctl there is not passing through environment variables and the test requires COMPOSE_FILE environment variable.


RESTEASY-2326 Allow extending resteasy-vertx classes

To address RESTEASY-2326, I have simply made it possible to override the require methods so we can provide our own implementation of authentication for resteasy-vertx, by allowing injection of our own RequestDispatcher and allowing us to override the authenticate method of that class.
(this is a recreation of PR #2138 with target as main branch)
(I submit this PR under the terms of the ASL 2.0 License: http://www.apache.org/licenses/LICENSE-2.0 , and I accept those terms.)

@bentatham Thanks for approving the license! @asoldano @jamezp I have updated our RESTEasy contributor license agreement doc and I guess this can be merged.


to rotate or not to rotate

Looking at your commit log I see you try to rotate the images based on its metadata:
https://github.com/monostream/tifig/commit/5697f12410805e60e09ad3742a8ab27059a51424
However, after testing the output from your binary this does not seem to be the case. The orientation tag is passed to the metadata of the output image, and the image is not rotated. This looks like the desired behaviour if you do not intend to rotate the image.
Is this intentional?

We only try to rotate images when exporting to something else than jpeg. When converting to jpeg, the exif rotation should be kept the same way as it is used in the heic image. Do you have any sample image where the output image is rotated incorrectly?

Aha. That makes sense then. No, everything looks good as of now, I just use IM for rotation.
You should consider embedding the heif exif into the jpegs. As of now I use a very simple tool to just extract the exif blob, but it would be nice to just have one tool.
The tool is made by me, but I am not a c++ developer so its not very pretty:
https://gist.github.com/Eriken/8cc34e27c4581a4340492ff8f7c85c05

Keeping Exif metadata in the converted images is something we have on the radar, I made some first steps in 91ed2bf4e4c3284a5052ceb5bfc6f0f5df79df41 and added the task to our todo list. However, vips seems to not really support setting Exif metadata on newly created image from a binary blob at the moment. Extracting the data to a seperate file first and mergin it into jpeg afterwards is sort of hack for me, I would prefer a cleaner solution where we can do this in one step directly. Keep watching branch preserve_exif for progress, however, I will not give any ETA for this 😋 .
I take the liberty to close this issue, feel free to reopen it when you see any case where we rotate images incorrectly

Btw, check out the current master branch, Exif support has arrived ;)

Awesome, thank you!


strip libdolfin

shrinks from ~150MB installed to ~6MB
It seems like this is supposed to happen by default on conda-forge, but doesn't on libdolfin.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.


Fix silent failure when socket name doesn't contain at least 2 spaces

Philips Hue lights identify their model with a simple string like LWB004 or LWB010, this causes the code
socket = " " + json.getJSONObject("3").getString("1").split(" ")[2];

to throw a silent ArrayIndexOutOfBoundsException
JSON response for my Hue light:
{
  "9001":"Living room",
  "9002":1498931354,
  "9020":1499042697,
  "9003":65548,
  "9054":0,
  "5750":2,
  "9019":1,
  "3": {"0":"Philips", "1":"LWB004", "2":"", "3":"<IP_ADDRESS>36", "6":1},
  "3311":[{"5850":0,"5851":153,"9003":0}]
}

The patch modifies the above line to first check if the model starts with "TRADFRI bulb" before doing a split

Interesting, how did you manage to pair a hue bulb to the Tradfri bridge?
When I implemented this line my compiler didn't warn me about this exception, that's pretty much why I forgot to check it :p
But I think a better approach than checking with startswith() would be to catch the ArrayIndexOutOfBoundsException.

You can pair a Hue bulb with a trådfri gateway in the same way you pair IKEA bulbs, with the remote. Just hold the remote about 5cm away from a Hue bulb and follow the regular procedure. Bulb will start blinking and stop blinking once it's paired. You can then control it through the trådfri gateway. Though if you have the RGB bulbs the app and gateway have no way of controlling that.

I think this patch doesn't work as intended, because socket.startsWith(" TRADFRI bulb ") will never be true because of the leading space.
I would advise to check for a ArrayIndexOutOfBoundsException, like I suggested earlier.

I've taken the leading space out of the test for now, I'll look at a better fix a little later in the week


Add support for SLURM < 21.08.x and improve error handling

In oder SLURM version (< 21.08.x) the mail program is executed without setting any SLURM job environment variables (#4).
We fallback to parsing the subject line that is passed to the mail program to retrieve jobid and other information such as job state and mail type.
Additionally the function for retrieving job related information via sacct and sstat now properly return error messages, if the call fails. This fixes #7
Additonal end2end tests are added to test the above fixes.

Let's  do cosmetics and move metrics to job_data
https://github.com/CLIP-HPC/goslmailer/blob/96a78280e8d93896a25572cc609c07fff9252c30/internal/slurmjob/sacct.go#L13
https://github.com/CLIP-HPC/goslmailer/blob/96a78280e8d93896a25572cc609c07fff9252c30/internal/slurmjob/sacct.go#L41
here, so it's more readable https://github.com/CLIP-HPC/goslmailer/blob/more_e2e/internal/slurmjob/job_data.go
Also perhaps a line here with updated template guide https://github.com/CLIP-HPC/goslmailer/blob/more_e2e/templates/README.md

@tdido Hey, we're wrapping things up in this PR, more-less it's ready to go, some cosmetics will happen but it's functional now.
Would you be interested in helping us to test-drive it before merge?
If you find time, just checkout this branch and run make build (skipping tests until we write up in the README the requirements.

For sure, I'll try it out and let you know.

OK, it's working!
Here's the output I'm getting:
Job 219922 Ended
Created Tue, 31 May 2022 12:40:59 UTC

------------------------------
Job Name         : wrap
Job ID           : 219922
User             :
Partition        :
Nodes Used       :
Cores            : 2
Job state        : COMPLETED
Exit Code        :
Submit           : 2022-05-31T12:40:56
Start            : 2022-05-31T12:40:56
End              : 2022-05-31T12:40:57
Res. Walltime    : 02:00:00
Used Walltime    :
Used CPU time    : 00:00.003
% User (Comp)    : 33.33%
% System (I/O)   : 33.33%
Memory Requested : 4.2 GB
Max Memory Used  : 1.2 MB
Max Disk Write   : 0 B
Max Disk Read    : 0 B
------------------------------

- TIP: Please consider lowering the ammount of requested memory in the future, your job has consumed less then half of the requested memory.
- TIP: Please consider lowering the amount of requested CPU cores in the future, your job has consumed less than half of requested CPU cores
- TIP: Your job was submitted with a walltime of 02:00:00 and finished in less half of the time, consider reducing the walltime and submit it to LONG QOS

The only things of note is that I can't get the "User", "Partition", "Nodes used", and "Used Walltime" fields to populate (even if using the -p and -w arguments to sbatch).

@tdido : For User, Partition and Nodes can you try to use this template instead the default one: https://github.com/CLIP-HPC/goslmailer/blob/more_e2e/test_e2e/cases/test_05/conf/adaptive_card_template.json
The used walltime should work tough. Need to check why

@tdido : I forgot to replace the Used Walltime in the template with the one from the sacctmetrics struct: https://github.com/CLIP-HPC/goslmailer/blob/more_e2e/test_e2e/cases/test_05/conf/adaptive_card_template.json#L141

@tdido : Also I see that your email doesn't render the mail as HTML. For mutt you need to drop following config into /etc/Muttrc.local:
# Local configuration for Mutt.
set content_type="text/html"

Cheers lads, I had forgotten about the templating concept :P All looking great now. Thanks!

Great, then we wrap this pr up, merge and publish a new release tomorrow. Thanks for the help :+1:  :1st_place_medal:


Made custom unboxing closures throw

Consider this JSON
{
  "animals": [
    { "type": "cat", "name": "kitty", "remainingLives": 4 },
    { "type": "dog", "name": "spot", "trained": false }
  ]
}

Now consider following unboxing models
class Animal: Unboxable {
    let name: String
    required init(unboxer: Unboxer) {
        name = unboxer.unbox("name")
    }
}

class Cat: Animal {
    let remainingLives: Int
    required init(unboxer: Unboxer) {
        remainingLives = unboxer.unbox("remainingLives")
        super.init(unboxer: unboxer)
    }
}

class Dog: Animal {
    let isTrained: Bool
    required init(unboxer: Unboxer) {
        isTrained = unboxer.unbox("trained")
        super.init(unboxer: unboxer)
    }
}

enum Type: String, UnboxableEnum {
    case Dog = "dog"
    case Cat = "cat"

    static func unboxFallbackValue() -> Type {
        return .Dog
    }
}

I don't know if you intended it to be but Unbox supports inheritance with let properties which is a really cool thing.
Sadly, though Swift doesn't support class clustering but one can make a Factory-like implementation doing
let animal: Animal = try Unboxer.performCustomUnboxingWithDictionary(dict) { (unboxer) -> Animal? in
    let type: Type = unboxer.unbox("type")
    switch type {
    case .Dog: return try Unbox(unboxer.dictionary) as Dog
    case .Cat: return try Unbox(unboxer.dictionary) as Cat
    }
}

This is a really minor change but it takes away a do catch block inside custom unboxing and re-throws whatever error occurs inside

Really awesome! Thanks for this! 👍


fix: Unvirtualize importer paths in webpack and rspack

I found that unplugin in webpack mode (and rspack mode) virtualized my resolved filenames (because I added a custom extension and the file didn't exist), but didn't unvirtualize the filenames when giving them back to me via the importer second argument to resolveId.
This simple PR fixes this issue by decoding virtualized filenames in importer, so that webpack and rspack behave like other systems. Includes a test with a simple mangling of filename (adding an extra .js to end of .js files).

I guess ideally this should be a non-breaking fix?

I think so... I can't imagine anyone doing something useful with the virtual importer filename. At least, the main use I know of for importer is to resolve relative ids relative to the importer, and without this change, you can't really do that (without painful workarounds). Given that the virtualization is done entirely within unplugin, I think this PR changes the behavior to be in line with expectation.


CarPlay support?

It would be great to have Apple CarPlay support added to this app. I’m not sure how hard this would be, but it seems to be possible with React Native.

Yes, I agree. I just setup Jellyfin and remote access and the app looks really beautiful. Playing music in my car I can access it on my CarPlay screen if I go to Now Playing, but there is no Car Play app for Jellyfin Audio Player.
It has been a year since @luke2m posted his comment. Is Car Play support being worked on?

Hey @scgf! Thanks for tuning in. I agree that getting CarPlay in would be a really cool feature and a nice challenge to work on. Unfortunately I maintain and extend this app in my spare time, and there are other issues and features that are currently higher on my priority list. I would love to see this happen, but this is not going to be picked up in the near future. Now if you are up for a challenge yourself, and if you have a knack for React Native stuff, I am more than happy to give a few pointers how you could come to an implementation. I would love to help out to get this in.

Thanks for your reply @leinelissen . Unfortunately I have no useful expertise with these things!

Kia ora! I've just started using Fintunes and it's great! I searched for this issue because I'd love to help improve the carplay support - I've got experience with react but not RN, but I'd love to hear those pointers if you're still interested!

Hi @jenkshields, thanks for using it from the other side of the planet! React Native is not that different from regular React, other than that the elements are a bit different (i.e. <View />s instead of <div />s) and the build process is a lot more complex and prone to breakage.
You can try getting to a build first: firstly, clone the repo, then, npm install the Node dependencies. Then, make sure you've installed Xcode. If you haven't already, install CocoaPods, and then run pod install in the ios directory. Now that you're mostly setup, you should be able to run npm start in one terminal, and then npm run ios in another. An iOS simulator should be launched containing the app. That concludes the first part.
Once you've done that, you can get to crafting a CarPlay integration. From what I see, the most straightforward package for doing so is react-native-carplay. You should be able to set it up using the instructions that are provided in the repository and run it in the simulator.
Now comes the hard part. From what I can see, you don't have full control over the CarPlay UI, but have to rely on a set of templates that are supplied by Apple. Good news: they look kinda good, and there's one specifically for a Now Playing screen (see PDF). Bad news: this template needs to be wrapped in react-native-carplay, and they don't have a wrapper right now. I don't think implementing it should be insanely hard, but you're going to have to dive in some Objective-C.
If you get as far as fixing this, implementing all the data bindings should be a breeze, since I've built some hooks (useCurrentTrack and useQueue) to retrieve all the relevant data.
Feel free to fork the repo and create a draft Pull Request. More than happy to track how you're faring and help out if necessary. Let me know if anything's unclear!

Any news here? :-)

It appears some people have been successful with getting this set up for CarPlay (https://github.com/birkir/react-native-carplay/issues/175). I think this should be feasible for someone willing to take it up. I'm curious to look at it, but still don't have time right now.


Failed to connect to my own TPU node on GCP

I tested to duplicate the work I did on colab and run on my Google Cloud Platform. Therefore, I followed this tutorial https://cloud.google.com/tpu/docs/tutorials/mnist and used the following ctpu up to set up VM and cloud TPU resources.
ctpu up --zone=europe-west4-a \
--machine-type=n1-standard-8 \
--tf-version=1.15.2 \
--name=mnist-tutorial
It successfully ran the model on a TPU node by using TensorFlow backend. In addition, using the following lines also shows available TPU cores correctly
tpu_address = os.environ['TPU_NAME']
cluster_resolver = tpu_lib.tpu_initialize(tpu_address)
tf.distribute.experimental.TPUStrategy(cluster_resolver)
Then, I tried to connect to my own TPU node on GCP by using JAX backend by the following lines:
from jax.config import config
from jax import random
# The following is required to use TPU Driver as JAX's backend.
config.FLAGS.jax_xla_backend = "tpu_driver"
config.FLAGS.jax_backend_target = "grpc://<TPU-IP-ADDRESS>:8470"
key = random.PRNGKey(0)
x = random.normal(key, (10,))
print(x)
However, I got some errors like

The deployment for the test is as below:
jax==0.1.54
jaxlib==0.1.37
Python 3.6.10
TPU software version = 2.1

Hi HLuSLB,
Thanks for sharing the repro step above, from what I can tell, the TPU backend you created using the ctpu instruction didn't specify the right backend to run.
To run JAX with the right Cloud TPU backend, you may want to follow the steps outlined here:
running JAX on a cloud tpu.
Let us know if after following the instruction you still encounter some issue to run JAX on Cloud TPU.

Hi @henrytansetiawan,
Thanks for your reply. After I specified the right backend to run, I am able to use the cloud TPU nodes I created.
Thanks again.


Server - Goto references

Implement "goto references" to navigate to schemas that reference the location under cursor.

Actually, I'm thinking this isn't a good issue for GSoC. I think it will be a lot easier once #7 is solved. What do you think about taking on that one instead?
I've pinged slack to see if anyone else is still looking for a partner. If we don't get a response by this time tomorrow, I'll be your partner.


Receipt encoding

Prototype receipt encoding, similar to what other ELs approach.
Some references & implementations:
ethereum/go-ethereum#19345
NethermindEth/nethermind#5531

Besu already stores the minimal amount of fields necessary. The changes for Geth and Nethermind were to not store fields that can derived but don't store those fields. E.g. Geth was storing the transaction hash, gas cost, and contract address.
In Besu we are only storing state root | status, cumulative gas, bloom filter and logs and optionally the revert reason. This is also what Geth is storing with the changes that were made.

Closing this as we already storing the bare minimum fields except the bloom filter. We have another ticket to investigate not storing the bloom filters in the receipts storage #6277


Fix bugs in UG and error message of filter command

closes #224
closes #225
closes #239
closes #241
closes #244

Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

...s/logic/parser/FilterContactTypeCommandParser.java
0.00%
3 Missing :warning:

Files with missing lines
Coverage Δ
Complexity Δ

...s/logic/parser/FilterContactTypeCommandParser.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)


Fix Duplicate Links in Auto Curated API Collections

rdar://133964293
Summary
Today if API reference documentation for a symbol contains two different variants, for example Swift and Objective-C languages or iOS and macOS platforms, and if that symbol uses auto curated API collections for inherited symbols, DocC will generate duplicate links.
This is a regression, fall out of a larger code change in PR #856. That change removed the previous logic to perform auto-curation using the topic graph, which does not track variants on language or platform. 856 started to track different lists of child references based on language/platform variants but introduced duplicate links in some cases.
Dependencies
None.
Testing
Find or write documentation for a symbol that exists in both Swift and Objective-C API, and that conforms to a protocol. In this scenario, DocC will automatically generate a child API collection/article called "MyProtocol Implementations," containing task groups called "Instance Properties" or "Instance Methods" for example. These will containing links to the default implementations of each property or function in that protocol. (This will not occur if the symbol actually implements all of the functions from the protocol - only if it uses some of the default implementations. It will also not occur if you curate links to these properties or functions; leave them uncurated and let DocC create auto-generated curation.)
Without this fix, DocC will generate duplicate links on the "MyProtocol Implementations" page, one for each language and platform combination. With this fix applied, DocC should generate a single, unique link to each of the protocol's properties and functions.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran the ./bin/test script and it succeeded
[ ] Updated documentation if necessary

@swift-ci please test

@swift-ci please test


Add an Opbeat error handler

This PR adds an Opbeat error handler.
It needs trying out in my setting, but I'm using both Hutch and Opbeat, so it should be possible soon.

(Psst: cc @mikker, who maintains the Opbeat gem.)

Story checks out 👍🏼

This no longer merges cleanly. Please rebase.

@michaelklishin Rebasé

👍

👀 @roncohen

way cool 🎉
@mikker How hard would it be to do tracing for tasks?

Not sure without taking a deeper dive – but it doesn't take much to set it up manually.


Fix indexing of zero-size nonzero-shape Fortran arrays

Fixes #361.
This is fix (and tests) for indexing a Fortran array that has zero size but has a shape with nonzero elements (e.g. shape (1, 0)). The bug was in indices_iter_f(), but this caused segfaults in ArrayBase::from_shape_fn().

Thanks for the fix and the test!


tonemap.glsl: Ensure color parameter of tonemap_reinhard() is positive

Similar to https://github.com/godotengine/godot/pull/42056 but targeting master as the issue still happens there.
Fixes https://github.com/godotengine/godot/issues/41901

Thanks!


Example on GANs with adaptive discriminator augmentation

This example demonstrates:
-data-efficient GAN training
-a powerful GAN baseline with good generation quality on natural images
-a strong use-case for the keras image augmentation layers
-a comprehensive list of GAN training tips and tricks based on personal experience

Thank you! It is actually exactly 300 lines, I just barely managed to fit it all in. I fixed the formatting based based on your suggestions.

Are sublists supported?

Yes, I believe so. I'll check before publication.
Thank you for the great contribution! Please add the 2 generated files.

I have previewed the example, and could not get sublists to work, so I removed them. I added the generated files as well.


Calculate physics engine data

Purpose
This purpose of this issue is to update the physics engine node to combine the fluid generation class with the boat state class in a timer callback to calculate real values for the physics engine.
Description
Create a method in the PhysicsEngineNode class that will:

Generate new fluid vectors for wind and water.
Update the boat's state using these fluid vectors.

Then call this method in __publish() before any of the other methods are called.
Take a look at the FluidGenerator class for simulating wind and current velocities and the BoatState class for tracking and updating the boat's state based on the fluid vectors.
Ressources

UBC Sailbot Python Conventions and Style Guide

Created the following method in PhysicsEngineNode class:
 def __update_boat_state(self):
        """
        Generates the next vectors for wind_generator and current_generator and updates the
        boat_state with the new wind and current vectors along with the rudder_angle and
        sail_trim_tab_angle.
        """
        self.__boat_state(
            self.__wind_generator.next(),
            self.__current_generator.next(),
            self.__rudder_angle,
            self.__sail_trim_tab_angle,
        )

then implemented it into __publish() method:
    # PUBLISHER CALLBACKS
    def __publish(self):
        self.__update_boat_state()
        """Synchronously publishes data to all publishers at once."""
        ...

did not implement tests as I am not sure how to go about testing this.


support vcr 3.0

minitest-vcr is pinned to 2.x, would be cool to make sure it works well with vcr 3.x

Thanks for opening this.  I released 1.4.0 which should be good to go with vcr 3.0.

Thanks!
Sent from my iPhone
Envoyé de mon iPhone

Le 12 nov. 2015 à 00:21, Mike Piccolo<EMAIL_ADDRESS>a écrit :
Thanks for opening this. I released 1.4.0 which should be good to go with vcr 3.0.
—
Reply to this email directly or view it on GitHub.


Fix playground html dist path

Problem
When i'm trying to run an interface test i stopped with an exception in console saying that autocomplete is not defined so i see that the distribution autocomplete path are wrong.
What i've done

Point to correct distribution path.

Coverage remained the same at 88.6% when pulling 7d36697b926b03fd77a5cc62e37974544f377973 on negherbon:fix-playground-dist-path into c4c3b083d12b81b954febfb98cc05a96deffc30a on algolia:master.

THX looks good.


Can APIFlask support Quart?

Hello, Greyli!
As time has progressed, the AsyncIO ecosystem has significantly matured, making asynchronous support a key component of any excellent web framework. Two years ago, I raised a question in the Flask Issues: Is it possible to natively support ASGI in Flask? At that time, this question was not thoroughly resolved.
Now, I am contemplating the possibility of APIFlask supporting Quart. This improvement would grant developers the freedom to choose between WSGI and ASGI, significantly enhancing APIFlask's adaptability in modern web application development, and potentially winning wider developer favor. I am very willing to participate in the development of this project in my free time (although it may not be in the near future).
I look forward to seeing Flask and APIFlask continue to progress in this direction, thank you!

Hi Cyberbolt, thank you for bringing this suggestion. Unfortunately, we currently have no plan to migrate to Quart. Maintaining two frameworks at the same time will be too expensive.
Welcome to contribute to APIFlask!


⚠ Fortnite has degraded performance

In 318467a, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1658 ms

Resolved: Fortnite performance has improved in b7f9383.


Release pipeline

We want to automate releasing to production
Tasks

[x] Use supply to promote beta track to production and update store listing meta data
[x] Use Deliver to promote TestFlight to production and update store listing meta data

Pre-flight check-list
Before raising a pull request

[ ] Documentation
[ ] Unit tests

Pre-merge check-list

[ ] Link to Trello ticket/GitHub issue (If applicable)
[ ] Any risky areas identified
[ ] Test plan provided
[ ] Tester approved

Tester check-list

[ ] Tested on multiple devices / OS versions (Test on the physical device(s) you have access to, otherwise use BrowserStack):

[ ] Galaxy S8 (Android 7.0/8.0)
[ ] Galaxy S7 (Android 6.0)
[ ] iPhone X (iOS 11.x)
[ ] iPhone 8 (11.x)
[ ] iPhone 7 (iOS 10.x)

Optional:

[ ] Google Pixel 2
[ ] Galaxy S8 Plus
[ ] Galaxy S7 Edge
[ ] Galaxy S6
[ ] iPhone 7+
[ ] iPhone 6

Accessibility Testing (If applicable)

[ ] Text-to-Voice (Android: Voice Assistant / iOS: Speak Selection)
[ ] Large Text (=<200%)
[ ] Landscape Screen orientation

Weak connection testing (If applicable)

[ ] Airplane mode
[ ] 2G/3G Network Settings

Store listing changes #389 #388 #380 & #381 are all pointed at this branch. The idea is to do the release and do any fixes here. Once everything works this can be reviewed and merged.


Added extractors for init compose

Also added network aliases instead of hard-coded IP address to compose files, since they're much easier to work with.
You can pass as many --extractor arguments as you want and they'd all become a unique service in the resulting compose file

Oh also, I should mention. The template is embedded. Tested this with a release build and it's able to generate the compose file as per the required spec


PositionsInListView Empty Database

If you start with a new Database (let XAF create it), you got the Error:
iXISXRM.Win.exe Error: 0 : 18.06.20 12:29:45.991	================================================================================
The error occurred:
Type:       NullReferenceException
Message:    Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
Data:       0 entries
Stack trace:

bei Xpand.XAF.Modules.PositionInListview.PositionInListViewService.<>c.b__6_1(ValueTuple2 _)    bei System.Reactive.Linq.ObservableImpl.Do1.OnNext._.OnNext(TSource value) in d:\a\1\s\Rx.NET\Source\src\System.Reactive\Linq\Observable\Do.cs:Zeile 38.
InnerException is null
And the in every ListView the Up and Down Button is visible.
Xpand.XAF.Modules.Reactive.ReactiveModuleBase.Unload(typeof(Xpand.XAF.Modules.PositionInListview.PositionInListViewModule));
does not work.

We will try to answer all questions that do not require research within 24hr.
To prioritize cases that require research we use the following labels in order. For all other issues the posting time is respected.

❇ Exclusive-Services
❤ Bronze Sponsor
❤ Sponsor
❤ Backer
Installation
ShowStopper
Nuget
Contribution
BreakingChange
ReproSample
Deployment
must-have

This case is prioritized.

i cannot reproduce the issue with the info you posted. Attaching my sample where I installed the eXpandSystemWin and configure the Customer_ListView for PositionInListView. I also added the unload call in Program.cs and as u can see in the sample the Customer_ListView does not have the PositionInListView actions.
Solution14.zip
What about your log?

Issue is deprioritized as no Assignee found and scheduled for auto-close if no activity in the next 60 days. Thanks a lot for your contribution.

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.


HasFactory trait missing from Category Model

Hi! Is there a reason why the Category model doesn't have the HasFactory trait?
Can I create a class that extends Category and "use" the HasFactory trait? Is this the right way?
Thanks for the replies!

Thank you for your suggestion, this has been pushed on develop branch here https://github.com/rinvex/laravel-categories/commit/1ba238f3b91c9dee80aea9cb300bada3f8dd2b0f
And yes, you can always override the default model and easily change the runtime model via configuration https://github.com/rinvex/laravel-categories/blob/master/config/config.php#L20


Investigate why lint task didn't run in CI

Related to https://github.com/wellcometrust/platform-api/pull/638

The CI setup has changed sufficiently that I think it works now (or at least, has changed enough to invalidate the old bug).


Update README.md

I think this should be flagged as spam

Please, don't flagged it as spam. Please I request you.
On Fri, Oct 2, 2020, 02:14 Farhan Kathawala<EMAIL_ADDRESS>wrote:

I think this should be flagged as spam
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Vonage/vonage-python-code-snippets/pull/77#issuecomment-702387002,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIW7TMU7WKZ6TXMQJLPDMCDSITS3XANCNFSM4SAX67HQ
.

This request is invalid.


Added request and response times to RequestInfo (#1464)

This is a relatively straightforward addition to RequestInfo to add two new times:

requestReceivedTime - the start point for x-envoy-upstream-time
responseReceivedTime - the end point for x-envoy-upstream-time

However, this is not ready to be merged because of the way these two new timestamps are being set in the router.  x-envoy-upstream-time is only a duration, so it is measured using the steady_clock, which is monotonic, but not wall-clock time.  This means to get absolute times for the new timestamps, we need to measure the system_clock time at the same points where we're measuring the steady_clock time currently.  I just wanted to see what people thought about the following options:

Measure the x-envoy-upstream-time using the system_clock.  This could create problems if the system clock goes backwards, or if we're expecting more accuracy from this measurement.
Measure the new times as durations from when the startTime was measured.  This would require an additional steady_clock time to be recorded when the normal startTime is measured.
What is currently in the PR: make two measurements (steady_clock and system_clock) at the beginning and end of x-envoy-upstream-time.

I vote for option (2), but curious what other folks think.

+1 option (2). Since ultimately we're after latency/duration measurements, the wall clock doesn't ever need to be recorded.

Updated to taking MonotonicTime and returning Optional<std::chrono::milliseconds>&.  Is there any interest in moving to a smaller time interval for these (and possibly other durations)?  I made them optionals because I was concerned that there may be instances where the times would be set, but the measured duration would be truncated to 0ms, so the optional would allow the RequestInfo user to tell the difference between these cases.  It's unlikely that the total stream duration would be below a millisecond, but it seems quite possible for the duration from request start to receiving the entire request could be below a millisecond.

@mrice32 if you want to move to microseconds no objection from me. I think for access logging which should keep the millisecond output for consistency but could add microsecond output in the future if we want.

Moved all the RequestInfo durations to microseconds but kept the access log formatter printing in milliseconds.


can't continue the game

i create a monster and it sleeping.
i  create the battle, so no pet to choose to continue fight.
in main page http://monstereos.io/ tips i'am join the battle and can't return
another page, so i can't do anything.. maybe should cancel the battle or to wake my pet or create
another pet or other things.

just finished your battle through admin account in the smart contract, sorry by that. I already created a lock that only allow people with available monsters to create/join battles


googlesamples-assistant-hotword run issue

I have followed the guide at
https://developers.google.com/assistant/sdk/guides/service/python
to install assistant on my Raspberry Pi buster device
After performing the credential step, registering the device, saving the credential file to the default location without issues, I then find as per the guide step 6 samples I can run  the following
googlesamples-assistant-pushtotalk
successfully and interact with the assistant.
All good.
But when I try to run
googlesamples-assistant-hotword
which is not covered in the guide, I get the following error
(env) pi@piai:~ $ googlesamples-assistant-hotword
/home/pi/env/lib/python3.7/site-packages/urllib3/util/selectors.py:14: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import namedtuple, Mapping
/home/pi/env/lib/python3.7/site-packages/urllib3/_collections.py:2: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Mapping, MutableMapping
Traceback (most recent call last):
File "/home/pi/env/bin/googlesamples-assistant-hotword", line 8, in
sys.exit(main())
File "/home/pi/env/lib/python3.7/site-packages/googlesamples/assistant/library/hotword.py", line 66, in main
with Assistant(credentials) as assistant:
TypeError: init() missing 1 required positional argument: 'device_model_id'
Which indicates an issue with device_model_id
If I run
googlesamples-assistant-hotword --help
after installing
python -m pip install --upgrade google.assistant.library
I get
googlesamples-assistant-hotword --help
/home/pi/env/lib/python3.7/site-packages/urllib3/util/selectors.py:14: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import namedtuple, Mapping
/home/pi/env/lib/python3.7/site-packages/urllib3/_collections.py:2: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Mapping, MutableMapping
usage: googlesamples-assistant-hotword [-h]
[--credentials OAUTH2_CREDENTIALS_FILE]
optional arguments:
-h, --help            show this help message and exit
--credentials OAUTH2_CREDENTIALS_FILE
Path to store and read OAuth2 credentials
Which indicates the only argument is the credentials file which it is already locating from its default location as per googlesamples-assistant-pushtotalk.
As such I have tried specifying
--project-id my-dev-project --device-model-id my-model
without success.
googlesamples-assistant-hotword --project_id XXX --device_model_id YYY
usage: googlesamples-assistant-hotword [-h]
[--credentials OAUTH2_CREDENTIALS_FILE]
googlesamples-assistant-hotword: error: unrecognized arguments: --project_id XXX --device_model_id YYY
Any ideas on how I can get googlesamples-assistant-hotword to be happy and run for me ?

The solution is
google-assistant-demo --device-model-id XXX


Use Crystal.format instead of shell

This is a small PR which uses Crystal.format instead of calling crystal tool format.

Okay, surprisingly this is a lot slower than using the shell command (maybe compiler is multi-threaded/uses concurrency?), so in this state it's probably a bad idea to use Crystal.format.

One good thing about use crystal tool format is that it doesn't affect the generator compile time.
It probably got slower because the generator is compiled in debug mode by default, since debug compile + generation is way faster than release compile + generation due to the huge time difference in compile time


Consider number type to be equivalent to GraphQLFloat

Currently Swagger type number is considered to be GraphQLInt type, which is incorrect and will lead to errors.
Instead this should be GraphQLFloat

Great, thanks, this change should have been there a long time ago


Implement utmp audit

Implements utmp audit required by policykit.
This commit also flattens the pidtree for the DM by starting the
display environment directly in the first fork which already should
have the environment ready for this purpose.
Fixes https://github.com/cylgom/ly/issues/121

Hi, thanks a lot! I was working on the same thing but you're far more advanced than I so we should probably merge your PR instead.
I also have the issues you and @evgenux described in #121 so I tried to investigate a little bit:

Xorg stays open after the desktop environment is closed
If you kill it, ly will hang
With the proprietary nvidia driver, X11 desktop environments refuse to start

Maybe my understanding is wrong, but for me:

We should keep that extra process to launch Xorg
We can't rely on the existing environment (the linux login from login-utils handles everything itself, so maybe we should, too)
None of this affected Sway, so the issue definitely comes from the X11 side

I am confident we will get this working though, and thanks again for contributing :)

Hi,
Sorry for not replying earlier, that's some good research you did.
I too noticed that Xorg stays open, I also noticed that with this patch, on logout, the pstree of the created fork gets transferred to the init process upon logout, which may indicate that our parent process exits, I wonder if that's caused by the terminal reset that we run or some unhandled signal sent from the child.
I think killing Xorg might be the way for now, if ly hangs, then I'll need to figure out why that is, as that should not happen.
I wonder about the proprietary driver though. I know sway does not like them on purpose, but I didn't know it may cause trouble to X11 desktop environments, too.
I would still like to flatten the processes if there's a way to do that.

@cylgom you were right, dealing with X11 is a bit too painful, I removed the process tree flattening for that.
Please review the changes again, see if they are ok

Wonderful! Thank you very much :)


Claimed missing identifier when typedef unnamed enum/struct/union

Describe the bug
When attempting to use typedef on an enum that has not been given an identifier, norminette outputs "Missing identifier in typedef declaration". Named enums are fine, only unnamed ones give the error.
This might be a quibble about how things are written, but my reading of V3's "An enum's name must start by e_." doesn't require there to be a name, only that if there is it should have a particular format. If that's the case I recommend changing it to read "An enum must have a name beginning with e_.".
All of this also applies to structs and unions.
Erroneous code
typedef enum {
	a
} t_enum;

Additional context

OS: MacOS Darwin 19.6.0
python3 --version: Python 3.9.5
norminette -v: norminette 3.3.54

Hello, we will add this restriction on the pdf V3. But don't forget that the norminette IS the reference, not the pdf. :)


register plugin success but do not match it when i visit the route

I have got the go-runner and put it in the apisix container. when i restart the apisix, i can see the log in console like
register plugin fault-injection
register plugin limit-req
register plugin say
register plugin sign-verify (mine)
and i try to set the route with mine plugin like
{
  "uri": "/message/header",
  "name": "show header",
  "methods": [
    "POST"
  ],
  "host": "mp.test.com",
  "plugins": {
    "ext-plugin-pre-req": {
      "conf": [
        {
          "name": "sign-verify",
          "value": "{\"verify_endpoint\":\"http://service.message:8080/signVerify\"}"
        },
        {
          "name": "say",
          "value": "{\"body\":\"say something\"}"
        }
      ]
    },
    "proxy-rewrite": {
      "uri": "/header"
    }
  },
  "upstream_id": "382988546614493882",
  "labels": {
    "API_VERSION": "V1"
  },
  "status": 1
}

when i visit the route, upstream can response, but plugin sign-verify and say do not trigger.
how it happen?

Could you run the runner with  -m dev and see if it has received the RPC from the APISIX during the request?

Could you run the runner with  -m dev and see if it has received the RPC from the APISIX during the request?

do you mean use running mode with that argument like this?
cmd: ["/path/to/apisix-go-plugin-runner/go-runner", "run", "-m", "dev"]
or use debugging mode? in order to confirm the issue, i used debugging mode locally with apisix docker and go-runner through /tmp/runner.sock file, after set the route and plugin, i found nothing in apisix log or go-runner log like 'register plugin say', and the plugin still did not trigger.

Could you run the runner with  -m dev and see if it has received the RPC from the APISIX during the request?

by the go-runner log, i thought the handleConn function is not be called, but i didn't find any error in apisix log during the request, how to troubleshoot?

Any interesting log in the APISIX? You can add more logs to this function: https://github.com/apache/apisix/blob/b8daf65b3c0690138feccb2ce399fc58349ac7ee/apisix/plugins/ext-plugin/init.lua#L435.

My fault, because I set the route and plug-in through the apisix dashboard before, it did not have any error response after i set, so I did not think that the plugin did not take effect. Yesterday I tried to use REST API to set up, the console directly told me that ext-plugin-pre-req plugin did not work, I found the key reason. Please close the current issue.


feat: port Data.Multiset.Sort

I think you can comment out that repr instance for now, and leave a porting note.
Otherwise, LGTM
bors d+

I fixed the repr instead. Thanks!
bors r+


[UI] Expanded Place details in BrowserPanel

Currently a placeholder screen, do up expanded "Place" screen displaying Name, Location, Country, Rating, Time and full description text for each Place object. "Place" tab will be on the right pane when a "Place" listing is selected on the left pane.

Nice! The details can be seen very clearly now.


Copy-Paste and other keyboard functionality stops working

VSCode Version: Code 1.14.0 (b8cd5b9556d8b70ea560d35b903422363f6c5c40, 2017-07-10T18:36:31.751Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author (truncated)
Version

spellright
ban
1.0.27

prettify-json
moh
0.0.3

cpptools
ms-
0.12.0

PowerShell
ms-
1.4.1

debugger-for-chrome
msj
3.1.6

Steps to Reproduce:

Use vscode for a while

Result: Copy-paste stops working. In addition, other keyboard functionality stops working. For example, if I try to find find some text (Ctrl-F) and then press the Escape key, it will no longer close the find fields. If I close and re-open vscode, the problem is solved (for a while).
I've had this sporadic issue with all versions of vscode, but the problem seems much worse with the most recent version. It happens soon after I re-start.

Reproduces without extensions: Yes

Came across the exact same issue on OSX today.

VSCode Version: Code 1.14.0 (b8cd5b9556d8b70ea560d35b903422363f6c5c40, 2017-07-10T18:24:22.120Z)
OS Version: Darwin x64 16.5.0
Extensions:

Extension
Author (truncated)
Version

postgresql
JPT
0.0.2

swift
Kas
0.0.3

vscode-docker
Pet
0.0.16

project-manager
ale
0.18.1

vscode-puppet
bit
0.4.5

path-intellisense
chr
1.4.2

vscode-eslint
dba
1.2.11

vscode-yaml-validation
dja
0.0.1

python
don
0.6.9

tslint
eg2
0.17.0

vimL
fal
0.0.3

auto-close-tag
for
0.4.3

restructuredtext
lex
34.0.0

Go
luk
0.6.62

MagicPython
mag
1.0.11

mssql
ms-
1.1.0

debugger-for-chrome
msj
3.1.6

java
red
0.7.0

vscode-icons
rob
7.10.1

vscode-nginx
sha
0.3.1

slack
soz
0.0.13

expand-selection-to-scope
vit
0.2.0

vim
vsc
0.9.0

gitblame
wad
2.0.2

jinja
who
0.0.8

change-case
wma
1.0.0

(1 theme extensions excluded)

Steps to Reproduce:

Use VScode for a while.

@logidelic @thekashifmalik did you happen to launch VSCode from tmux?

I did.
On Aug 1, 2017 10:17 PM, "Peng Lyu"<EMAIL_ADDRESS>wrote:

@logidelic https://github.com/logidelic @thekashifmalik
https://github.com/thekashifmalik did you happen to launch VSCode from
tmux?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/30511#issuecomment-319569953,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABQvtnULc8BFTznsMI-DPVhTVenEMkiyks5sUAaFgaJpZM4OVluD
.

@thekashifmalik it's an upstream issue https://github.com/electron/electron/issues/916#issuecomment-68567844 , please follow instructions there to workaround.
Close this first and if @logidelic is not running into the same problem, we can reopen.


[Bug]: Critical Security Vulnerability: Potential NFT Theft Through Inadequate Title Management and Ownership Verification

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
A significant vulnerability has been discovered in the DecentradeMarketplace smart contract, which enables malicious actors to alter NFT ownership due to deficiencies in title management and verification processes. The primary concerns are as follows:
Title Manipulation: There is an absence of validation for unique titles during redeployments, which permits the existence of duplicate listings.
Ownership Verification Deficiencies: There are insufficient checks for ownership prior to listing and inadequate validation of operators.
State Management Issues: There is a potential for race conditions, incomplete state cleanup, and a lack of event logging for changes in title.
Add ScreenShots
No response
What browsers are you seeing the problem on?
No response
Record

[X] I agree to follow this project's Code of Conduct
[ ] I'm a WOB contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

assigned to you @adityajha2005 ,
propose your changes, and go through contributing guidelines,

@4darsh-Dev  I've submitted the PR. Let me know if any adjustments are needed.

Gentle Reminder 🚨🚨
GSSoC-Ext 24 is going to complete in 2 Days. '
Complete your assigned Issues and PR reviews before time to get Points on Leaderboard. '
It was a great experience working with you all, Don't forget to ⭐ star the Repo (only 12 with 62 forks 💔) .
Thanks💗 for your valuable contributions!

Gentle Reminder 🚨🚨
PA and Mentor nominations have been started for GSSoC-Ext 2k24. '
Do share your experiences and connect on Socials. '
It was a great experience working with you all
Thanks💗 for your valuable contributions!


Overriding method using type restrictions

This example from Crystal's doc works as anticipated, i.e. the subclass Employee inherites the greet method from the superclass Person:
class Person
  def greet(msg)
    puts "Hi, #{msg}"
  end
end

class Employee < Person
  def greet(msg : Int32)
    puts "Hi, this is a number: #{msg}"
  end
end

e = Employee.new
e.greet "everyone"
e. greet 1

If I try the same with the initialize method instead of greet, ineheritance doesn't work anymore:
class Person
  def initialize(@msg)
  end
end

class Employee < Person
  def initialize(@msg : Int32)
  end
end

e = Employee.new("everyone")
puts e.msg

# This throws an error:
e = Employee.new(1)
puts e.msg

The initialize difference is expected behaviour, so I'll close this.


Exam mode: Fix test runs for test exams

Checklist
General

[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] I followed the coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I implemented the changes with a good performance and prevented too many database calls.
[x] I documented the Java code using JavaDoc style.

Motivation and Context

The exam test runs were not working, because of an oversight introduced in #5370.
Fixes issue no. 1 and (likely) 15 found during exam mode testing.
Description

Bug fixed by not distinguishing between test exams and real exams in fetchParticipationsSubmissionsAndResultsForExam().
Steps for Testing

Prerequisites:

1 Instructor
1 Exam with different exercises

Log in to Artemis
Navigate to the Exam, then Test Runs
Create and participate in the test run
Ensure no errors occur
Repeat the steps with a Test Exam

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Added test case for the bug.

I tested on ts1 and I'm getting this error when I try the test run (and I change from one exercise to another), including when I click on save and continue:

But when I handed in early, it actually saved all the results.
Other than that seemed to be all good

@dangcosta Did you "continue" an existing test run or "start" a new one?

@dangcosta Did you "continue" an existing test run or "start" a new one?

I created a new test run in an existing exam, and I also created a new exam and a new test run for the exam. I got in all these cases. I did not try to continue an existing test run, however.


option: adds debugfailed option

Prints contents of files in output directory of failed tests
Intent is to debug flasky behaviors
cf https://redmine.openinfosecfoundation.org/issues/3096
We should then update .travis.yml in suricata repository
Follows #145 with code review taken into account

Ping on this ?

Ping on this ?

Next time I do a batch. Won't be long now.

Merged with some minor fixups. Thanks!


Update connectionString for SQL 2014 or later

connectionString currently leads to a SQL error 50: "Local Database Runtime error occurred. Cannot create an automatic instance" when trying to access the local database. Proposed fix taken from accepted StackOverflow answer here:
https://stackoverflow.com/a/26267373/8133586
When creating a new PR, please do the following and delete this template text:

Reference the issue number if there is one:
Fixes #Issue_Number

The "Fixes #nnn" syntax in the PR description causes
GitHub to automatically close the issue when this PR is merged.

@auberginekenobi  Thanks!


Spring Cloud incompatible with Spring Boot 1.4 Actuator

Due to the method signature change in InfoEndpoint (invoke() returns Info instead of Map) I'm unable to start application (Spring Boot 1.4.0.M2):
java.lang.NoSuchMethodError: org.springframework.boot.actuate.endpoint.InfoEndpoint.invoke()Ljava/util/Map;
	at org.springframework.cloud.autoconfigure.RefreshEndpointAutoConfiguration$InfoEndpointRebinderConfiguration.infoEndpoint(RefreshEndpointAutoConfiguration.java:170)

Without actuator dependency application starts fine.

We kind of want to get Spring Boot 1.4 working with Brixton, but it might not be in the first release. Thanks for the explanation of why it isn't working yet.


History Expressions

Add support for History Expressions. This allows an ensures clause to evaluate expressions before the function runs, bing them to anonymous variables and use them after calculating the result to be able to compare to the state before the function evaluation.
TODO

[ ] Update external documentation with information about how history expressions are used
[ ] Update internal documentation with expanded example of how old is implemented
[ ] Test case. I could use some help here both with implementing test cases as well as with suggestions for other things to test. Here is the list so far

[x] Basic pass/fail
[x] pass/fail on using clone and not using clone respectively for a reference
[ ] Using a function call in old
[ ] Using a block expression (e.g. sequence of statements) as argument to old
[ ] Denying nesting of old, e.g. old(... old( ) ... )

Resolves #2803
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

This seems like it would cause problems with the result ident since all idents are lifted, or in the event of someone making a locally bound variable within a closure, so something like ensures((|a| old(a)) (argument)). Wouldn't it be easier to implement if we require that the argument for old be an ident instead of an expression?
Here is an example of something reasonable that breaks
#[kani::ensures((|a| old(*ptr+a))(1) == *ptr)]
fn modify(ptr: &mut u32) {
    *ptr += 1;
}

Here is another example of something reasonable that breaks
#[kani::ensures(old(*ptr+result) == *ptr)]
fn modify(ptr: &mut u32) -> u32 {
    *ptr += 1;
    1
}


Support swiftly on Windows

See https://forums.swift.org/t/introducing-swiftly-a-new-swift-toolchain-installer-and-manager/67254
https://github.com/swift-server/swiftly
There is a platform abstraction layer that would allow for plugging in a Windows implementation (theoretically).

The platform layer won't help. It depends on NIO and thus is not viable to port currently. The removal of NIO would be required or eliminating the support for downloading the toolchain would need to be removed.


Xcode命令行工具管理 - 小彬彬的博客 | YB Blog

https://liaoyibin.top/2018/05/05/Xcode命令行工具管理/
Every failure is leading towards success.

初始化……


feat: cards component with all variant and screenshot testing

Changes description 🧑💻

Context 🤔

Checklist ✅

[ ] I have reviewed the submitted code
[ ] I have tested on a phone device/emulator
[ ] I have tested on a tablet device/emulator
[ ] I have tested on a kiosk device/emulator

Screenshots 📸
Phone

Tablet

Kiosk

Other info 👋

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/4460f7a5-76d0-460f-8301-50ca2b3bb5ee/artifact/4746b1e4c5e39af2/p/8db2592e66f6aa1df83b3afea6bff354

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/584f388d-5116-4558-a849-531b3ee7cc19/artifact/17c8904ad9b16bda/p/ac76065e1dc1706a6edbb52598f07aa3

Specs have changed a lot since this PR. I close it