Create Balls_Demo.py

have adapted the demo.py in the pico_display examples to run full screen on the Pico Explorer built-in display.

Thank you! If you've got a moment to re-apply this to the updated bouncy boundary boxed balls from #69 and update your PR that'd be great. Also "Balls_Demo.py" should be "balls_demo.py".
(And while I would normally use - in lieu of _ I've heard that MicroPython users like to save various demo code on their device and run it with - for example - import balls_demo so underscore is right.)

Hi
please excuse me asking as this is my first ever PR!!
how do i update my PR  with the new code please?

i hope this was the correct way to do it?

Hi
realise you are probably very very busy at the moment but could you let me know if this PR meets your requirements - its my first ever & I'm keen to see if i have done this correctly

Sorry for the lack of feedback- we really have been super busy!
Git-Fu required to correctly update a pull request can be decidedly complicated, but your goal is to get this change to a single commit that adds balls_demo.py into the relevant location. You can opt to close this PR and raise a new one with the one-file-one-commit, or you can delve into some Git-Fu.
Your Create balls_demo.py commit is pretty good, here's the link to the patch: https://github.com/pimoroni/pimoroni-pico/commit/0f98207c4774808c728e4656a31fb09942a2de43.patch
It's adding the file to the wrong location, though so let's create a new patch branch locally and fix that.
In your local copy of your fork, add upstream as a new remote so you can fetch the latest changes:
git remote add upstream git://github.com/pimoroni/pimoroni-pico.git

Fetch the contents of main from "upstream":
git fetch upstream main

Create a clean new branch for your commit, based upon upstream/main:
git checkout patch-balls-demo upstream/main

"Cherry-pick" your desired commit from your old patch-1 branch (assuming you have fetched it locally):
git cherry-pick 0f98207c4774808c728e4656a31fb09942a2de43

That long string "0f98207c4774808c728e4656a31fb09942a2de43" is the commit hash, you'll notice it matches the URL above, it's a unique identifier for your change that will allow you to pull it across from your patch-1 branch into our new patch-balls-demo branch.
Move balls_demo.py into its new home:
mv balls_demo.py micropython/examples/pico_explorer/

Make sure git knows you've moved the file by adding the old and new locations:
git add balls_demo.py
git add micropython/examples/pico_explorer/balls_demo.py

Amend your  commit with this new change:
git commit --amend
Ctrl + X

Voila!
You can inspect the last commit and see how it differs from the previous one to verify this:
git diff HEAD~1 | head -n 5
diff --git a/micropython/examples/pico_explorer/balls_demo.py b/micropython/examples/pico_explorer/balls_demo.py
new file mode 100644
index 0000000..8497d15
--- /dev/null
+++ b/micropython/examples/pico_explorer/balls_demo.py

Finally you can push the branch up and raise an new PR with it... heck you can even delete your local patch-1 re-created it from patch-balls-demo and force push it to rewrite history and update your PR. Force pushes are generally accepted practise for patches and changes, since you want a clean history to join upstream.
Of course you can do all of the above just by copying and pasting the file around and adding it as a new commit... but Git Fu is fun!


Add configurable MIME type to script tag

Some tools (such as partytown) require changing the MIME type of the inserted script tag. For partytown, it should be text/partytown (here).
This PR introduces the optional ability to specify custom MIME type for the inserted script tag with GTM.
There's also a discussion in vue-gtm which asks about the same feature.

Can you add a test?

Sure, I'll add the test some time later this week.

@Shinigami92, tests are added.

I need to update some stuff on main before releasing the next version
give me some hours, so I can handle that after the office work

I need to update some stuff on main before releasing the next version give me some hours, so I can handle that after the office work
But you can expect a release the next few days

Cool, thanks!

https://github.com/gtm-support/core/releases/tag/2.1.0
https://github.com/gtm-support/vue-gtm/releases/tag/2.2.0


⚠ Bofrost.at has degraded performance

In abaf1ad, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1729 ms

Resolved: Bofrost.at performance has improved in 22e72aa after 1 hour, 16 minutes.


Add helm-diff

https://github.com/aquaproj/aqua-registry/issues/858
https://github.com/dex4er/asdf-helm-diff
https://github.com/databus23/helm-diff

Unpack the tarball in your helm plugins directory

It is hard to support.

@suzuki-shunsuke you don't actually have to unpack it in your helm plugins dir. You can set the HELM_PLUGINS environment variable to the path of the helm diff plugin.
I was able to make it work with nix: https://github.com/NixOS/nixpkgs/blob/nixos-24.05/pkgs/applications/networking/cluster/helm/plugins/helm-diff.nix#L31
I've tried it with aqua but i'm getting an error:
ERRO[0000] check file_src is correct                     aqua_version=2.38.0 env=darwin/arm64 error="check file_src is correct: exe_path is directory" exe_path=/Users/.../.local/share/aquaproj-aqua/pkgs/github_release/github.com/databus23/helm-diff/v3.9.12/helm-diff-macos-arm64.tgz/diff/bin file_name=diff package_name=databus23/helm-diff package_version=v3.9.12 program=aqua registry=local

packages:
- type: github_release
  repo_owner: databus23
  repo_name: helm-diff
  description: A helm plugin that shows a diff explaining what a helm upgrade would change
  version_constraint: false
  version_overrides:
  - version_constraint: true
    asset: helm-diff-{{ .OS }}-{{ .Arch }}.{{ .Format }}
    format: tgz
    replacements:
      darwin: macos
    files:
    - name: diff
      src: diff/bin

I read the document. https://helm.sh/docs/topics/plugins/
Helm plugin should be unarchived into $HELM_PLUGINS.
Helm plugin is not an executable file but a directory with plugin.yaml.
aqua creates symbolic links to executable files in $(aqua root-dir)/bin, and the location of entities are changed by package and version.
I don't think Helm plugins match with aqua packages.


Use latest image from docker repo

Description
It has been observed at time, image from project.registry.vmware.com registry with latest tag is not available. This is because this registry is backed with CDN and CDN doesnt work well with mutable tags like latest.
Changes
Updated the code to point latest to docker hub and immutable tag to project.registry.vmware.com (for release only)

/nephe-test-e2e-aws-upgrade, /nephe-test-e2e-aws-azure

/nephe-test-e2e-azure-upgrade

/nephe-test-e2e-aws-upgrade

/nephe-test-e2e-aws-upgrade

/nephe-test-e2e-agentless-upgrade

/nephe-test-e2e-aws


Design

Raising issue to document the design phase. The design phase should spec out each page required. Flow chart for the overall system.
On each page, we will need to explain the UX (if it is interactive, what should be expected to happen and what should happen in the event of an error?)

Pages

Home page (Login)
Login page
Register page
Reset password or username
Dashboard (most interactivity and questions on the spec?)
Page to add data.


Databases cannot be renamed if in explicit sequence reference

Fixes #6908.

Added additional bullet to Considerations on CREATE SEQUENCE page.
Reworked limitations on, added limitation and example to Rename Database page.
Updated examples on Rename Database page.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/080b7a2042bc7ca8293113fe190e5bd13f0e3959/
Edited pages:

v20.1/create-sequence.md
v20.1/rename-database.md

@otan TFTR!
I added an example. Hopefully it's more helpful than it is confusing.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/74f4b75f227ca0bb7f0a43df03caf097fd8a397e/
Edited pages:

v20.1/create-sequence.md
v20.1/rename-database.md

v20.1/rename-database.md, line 48 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Done.

LGTM!


Validation of values

Hello,
Is there a way to validate the value from the config file ?
(like positive ? part of a range ? part of possible values ? etc .. )
If not, what would be the best way to do it ?
Thanks,
Nicolas

OWNER supports events.
Listen for an event (property changed, or properties reload) then verify if the values match your requirements; if not, throw a RollbackException.
http://owner.aeonbits.org/docs/event-support/
OWNER project is looking for sponsors, if you or your company are interested in it, help is welcome.

Declarative validation can be added; but since I am doing other work (on awful codebase), nobody is sponsoring the development on this project, and nobody is working on this.

Thanks for the feedback. By contribution are talking more about money, or time to help ?

code contribution is welcome, as long as

the quality of the code is on the same level of the rest of the project
there are unit tests with near 100% code coverage
changes/new features are documented

If some company uses owner and needs some cool feature that is missing, they can work by themselves and invest time and money, or hire an expert to implement that and make it into the official codebase for everyone to benefit.


Sync function triggers should happen when using the vfs/zip APIs

Today, when vfs or zip APIs are used, the function triggers are not synced, leading to multiple reported cases of user function apps not waking up.
We should consider adding logic that calls /operations/settriggers when those APIs are called on function apps.

@suwatch, does that require FE changes so it would pass the restricted JWT for those? Or does Kudu always get it?

It would require FE change to pass the restricted JWT for those scenarios.   I assume the vfs and zip apis were called explicitly by users (not via certain portal gestures).   There are a few options we could consider.

Document only.   Tell user that they also need to call functions/synctriggers in addition of vfs or zip (or even FTP).

Add these scenarios for FE to pass JWT token + Kudu fix to consume.   Given uncommon and simple workaround (above), users could wait for Antares release cycle for the fix.

We could generalize such that, for dynamic, PUT/PATCH/DELETE verbs will get token (not a day-to-day operations) and certain POST that we already knew of + Kudu fix to consume token.

Since you had to open the issue, I assume we must do something and the 2nd option seems proportional at this point.

I think in the two cases I saw, people were doing command line automation, and using vfs to upload their function files. Workaround is indeed to explicitely do a sync, and I have a PowerShell sample to point them to.
Yes, I think Option 2 is good, even if it takes a while to propagate.

Tracked for next Azure WebApps release (addressing just vfs and zip).

Is there any documentation as to what syncfunctiontriggers actually does?
The reason I ask is I stumbled across this from here after porting the workers (cron jobs in Quartz) of one of our on-premises apps to Functions hosted in an app service plan, and my build server deploys them with WAWSDeploy. Some of the functions can be longish running (like 5-10 minutes), and I noticed that whenever I did a deploy, or App Service boots me to another VM, things would go sideways for 10-20 minutes. Specifically, I get hammered with lots of "Thread was being aborted" or weird errors where AppSettings return null. Looking at the Functions logs, I would see weird patterns of the host keep getting restarted.
I ran syncfunctiontriggers before my deployment and did it after deployment and am knocking on that that fixed it, but am also not sure if it's actually fixed. Does syncfunctiontriggers have something to do with making sure functions aren't fired during a host shutdown or at the wrong time? Thank you.

@npiasecki synctriggers is only meaningful when using Consumption. So if you're using App Service Plan, this is definitely unrelated to what you are seeing.

@davidebbo Thank you! Knowing that and looking back it, I think it was caused by my deployment not containing a host.json, and I had WAWSDeploy set to delete files that aren't in the source to keep things tidy.
Reading the log, deleting host.json triggered a host shutdown immediately. (I guess the WAWSDeploy deletes files first, then goes to upload, and that took longer than the debounce of 500 ms that I see in the code.) The host started up and then started noticing assembly changes as WAWSDeploy went to the upload stage, so it shut itself down and restarted again. This would lead a flurry of errors in my log since it was a short-lived host. Adding a host.json in my deployment seems to have nixed the double startup issue.
(I think the issues with landing on a new VM causing errors is that I just need to deal with some of my long-running functions being a little quicker to shutdown, as they're used to an environment where the worker basically never shut down.) Thanks for confirming that for me, and I'll stop spamming this issue!

@npiasecki seems like a plausible theory. You probably should include a host.json in your deployment to avoid this. It can be as simple as {}.

Is this still in the pipeline? I am running a consumption plan azure function from a package and I am doing a VFS deployment to still be able to do a custom deployment.

Hi
If the problem persists and is related to running it on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


The node and npm commands not available after install.

If this is a question about how to use NVM4W, please use stackoverflow instead.
If this is an issue regarding antivirus, make sure you search the existing issues first.
My Environment

[ ] Windows 7 or below (not truly supported due to EOL - see wiki for details)

[ ] Windows 8

[ ] Windows 8.1

[ x] Windows 10

[ ] Windows 10 IoT Core

[ ] Windows Server 2012

[ ] Windows Server 2012 R2

[ ] Windows Server 2016

[ ] My Windows installation is non-English.

I'm using NVM4W version:

[x ] 1.1.7
[ ] 1.1.6
[ ] 1.1.5
[ ] 1.1.4
[ ] 1.1.3
[ ] 1.1.2
[ ] 1.1.1
[ ] Older
[ ] OTHER (Please Specify)

I have already...

[x ] read the README to be aware of npm gotchas & antivirus issues.
[x ] reviewed the wiki to make sure my issue hasn't already been resolved.
[x ] verified I'm using an account with administrative privileges.
[ x] searched the issues (open and closed) to make sure this isn't a duplicate.
[ ] made sure this isn't a question about how to use NVM for Windows, since gitter is used for questions and comments.

My issue is related to (check only those which apply):

[ ] settings.txt
[ ] proxy support (Have you tried version 1.1.0+?)
[ ] 32 or 64 bit support (Have you tried version 1.1.3+?)
[ ] Character escaping (Have you tried version 1.1.6+?)
[ x] A standard shell environment (terminal/powershell)
[ ] A non-standard shell environment (Cmder, Hyper, Cygwin, git)

Expected Behavior
Once installed and set the node version I want to use, it (and nvm) become available in a new admin shell (Powershell) using node command.
Actual Behavior
The node command is not found, nor is npm. All files are there, env vars are there, but I can't use node at all.
Steps to reproduce the problem:
Download latest and install using nvm-setup.exe. Run nvm install 12.10.0 and nvm use 12.10.0. Launch new Powershell window as Administrator, type node or node -v and hit enter.

@vgjenks I found that I had a similar problem.
After installing, use the "nvm on" command, then try node -v and npm -v to see if they are working.
This worked for me.
I do think that the README is a little vague with this detail if this is the requirement to make nvm-windows working.
@coreybutler I recommend updating your README to clarify this detail if this is expected to get node working properly after installation.

I appreciate the help all, but none of these steps works for me. I even tried the nvm manual install process. When I go that route, the nvm command doesn't work for me at all, I have to navigate to the directory...but that's another bug report for another time.
Regardless - I just can't get this thing to work.

@qBaebs thank you that fixed it for me! :)

@Jessica-Koch no problem! Happy to help :)

@qBaebs That was very helpful, thanks! It's all working now.

@vgjenks Awesome, no problem!

i deleted empty nodejs folder from program files and did nvm off and nvm use

I encountered the same problem and tried the two methods mentioned above, but neither of them worked


User control panel > Add user issues with validation errors

Describe the bug
When adding a user in the User control panel, and when any error occurs, the submit button doubles up.
Additionally one must scroll the panel to view any error messages, and it is not obvious that there may be a problem.
To Reproduce

Login as admin/admin on https://demo.plone.org/
Go to the User control panel https://demo.plone.org/controlpanel/users
Click + to add a new user.
Fill in details but leave the password field blank.
Submit the form.
Scroll to the top to observe the following screenshot.

Expected behavior
Show the errors in some manner that does not require the user to scroll. Auto-scrolling would be OK, but might not be the best option.
Software
plone6-demo 1.0.0
Volto 17.16.0
Plone 6.0.11
plone.restapi 9.6.1
CMF 3.5
Zope 5.9
Python 3.11.9 (main, May 14 2024, 08:32:26) [GCC 10.2.1 20210110]
PIL 9.5.0 (Pillow)

Add-ons
@plone/volto-slate 17.16.0
volto-subblocks 2.0.0
volto-form-block 3.8.3
@eeacms/volto-accordion-block 10.4.6
@kitconcept/volto-button-block 2.3.1
@kitconcept/volto-heading-block 2.4.0
@kitconcept/volto-highlight-block 3.0.1
@kitconcept/volto-introduction-block 1.0.0
@kitconcept/volto-separator-block 4.1.1
@kitconcept/volto-slider-block 6.3.1
@kitconcept/volto-light-theme 3.3.1
volto-demo 0.1.0

hi, can you please assign this issue to me. I want to work on this.

@charanbhatia, no. Please read and follow First-time contributors, especially Things not to do, Contributing to Plone, and Contributing to Volto.

hi @stevepiercy , i went through the volto repo but can't exactly the find the file which should contain this form field and code for control panel in general. can i get some guidance or any advice in general to navigate through the codebase efficiently.

@barelysomethin I don't know.
Also please read and follow First-time contributors, especially Things not to do, Contributing to Plone, and Contributing to Volto.

alright, thanks.

@barelysomethin the file in question is this one:
https://github.com/plone/volto/blob/main/packages/volto/src/components/manage/Controlpanels/Users/UsersControlpanel.jsx

@stevepiercy  yeah, it is not obvious. I have a idea of adding tool tip so that the error can display right after submitting form without scrolling to top. Can you assign to me?

@Srihari2222 no, we don't assign issues, but you can claim it for yourself. See First-time contributors, especially Item 1 in Things not to do.


Android Basics: change-app-icon

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-change-app-icon?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-2-pathway-2%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-change-app-icon#5
In which task and step of the codelab can this issue be found?
6
Describe the problem
Followed instructions, and the manifests folder has disappeared from the project. Project is now corrupted and I cannot run the app (obv)
Steps to reproduce?

Follow instructions per page

Versions
Android Studio version: Build #AI-213.7172.25.2113.9123335,
API version of the emulator: 33
Additional information
Include screenshots if they would be useful in clarifying the problem.

And after replacing AndroidManifest.xml from https://github.com/gitlood/Tip-Time, the project builds okay, but in trying to push to the emulator, I now get the same issue as at https://intellij-support.jetbrains.com/hc/en-us/community/posts/360004329680-IntelliJ-reporting-No-junit-jar-when-running-tests-after-upgrading-2019-2
It's hard to believe I accidentally deleted critical components myself when following the instructions to change the app icon.


[Spanish] localize 'Virtual Machine'

Localize the content/en/virtual-machine.md document to Spanish

what we have to do it here create new file ?

Yes, the idea is to create a new file under content/es/ folder. There are many similar PRs that you can take a look on how and also review the contribution process. Usually, we recommend contributing to native speaking languages.

@electrocucaracha estoy disponible para trabajar en este issue. Gracias!

done by https://github.com/cncf/glossary/pull/1980


Create 0000-01-02-MaryParmar.md

created a branch, created a file and made a commit, and opened a pull request

Completed creating a branch


Fix broken main branch by providing correct getBitSet implementation

Motivation
Currently the main branch is broken by the concurrent merge of https://github.com/apache/pulsar-client-cpp/pull/153 and https://github.com/apache/pulsar-client-cpp/pull/151. It's because when a batched message id is constructed from deserialization, there is no getBitSet implementation of the internal acker.
Modifications
Add a bool parameter to MessageIdImpl::getBitSet to indicate whether the message ID is batched. The logic is similar with
https://github.com/apache/pulsar/blob/299bd70fdfa023768e94a8ee4347d39337b6cbd4/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java#L325-L327
and
https://github.com/apache/pulsar/blob/299bd70fdfa023768e94a8ee4347d39337b6cbd4/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java#L345-L347
Add a testMessageIdFromBuild to test the acknowledgment for a message ID without an acker could succeed for a consumer that enables batch index ACK.
TODO
In future, https://github.com/apache/pulsar/pull/19031 might be migrated into the C++ client to fix the consumer that disables batch index ACK.
Documentation

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

I have a question:

It's because when a batched message id is constructed from deserialization, there is no getBitSet implementation of the internal acker.

Is the code related to this passage here?
https://github.com/apache/pulsar-client-cpp/blob/d03ff20a96de695a6c2837d62862569faf11876b/lib/MessageIdBuilder.cc#L45-L47
Is setting bitSize equal to 0 for lazy initialization? To save memory?
If bitSite is initialized here, subsequent operations such as ack can reuse the logic here. Wouldn't it be better?
https://github.com/apache/pulsar-client-cpp/blob/f860566c05634dd097d8941ea38a2a939fcfd26e/lib/BatchedMessageIdImpl.h#L38-L40


calc_weight fix

Method _estimate_probabilities was recovered.
Minor improvement in our calullate_weights method.

Hello @Roman223! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file bamt/external/pyitlib/DiscreteRandomVariableUtils.py:

Line 646:39: E226 missing whitespace around arithmetic operator
Line 649:29: E226 missing whitespace around arithmetic operator
Line 652:24: E226 missing whitespace around arithmetic operator
Line 653:17: E226 missing whitespace around arithmetic operator
Line 653:40: E226 missing whitespace around arithmetic operator
Line 653:53: E226 missing whitespace around arithmetic operator
Line 656:35: E226 missing whitespace around arithmetic operator
Line 657:37: E226 missing whitespace around arithmetic operator
Line 657:50: E226 missing whitespace around arithmetic operator
Line 669:42: E226 missing whitespace around arithmetic operator
Line 670:32: E226 missing whitespace around arithmetic operator
Line 677:31: E226 missing whitespace around arithmetic operator
Line 677:37: E226 missing whitespace around arithmetic operator
Line 679:31: E226 missing whitespace around arithmetic operator
Line 679:34: E226 missing whitespace around arithmetic operator
Line 694:40: E226 missing whitespace around arithmetic operator
Line 702:42: E226 missing whitespace around arithmetic operator
Line 703:21: E226 missing whitespace around arithmetic operator
Line 703:43: E226 missing whitespace around arithmetic operator
Line 704:43: E226 missing whitespace around arithmetic operator
Line 705:37: E226 missing whitespace around arithmetic operator
Line 705:46: E226 missing whitespace around arithmetic operator
Line 706:37: E226 missing whitespace around arithmetic operator
Line 707:20: E226 missing whitespace around arithmetic operator
Line 709:42: E226 missing whitespace around arithmetic operator
Line 726:42: E226 missing whitespace around arithmetic operator
Line 727:16: E226 missing whitespace around arithmetic operator
Line 737:23: E226 missing whitespace around arithmetic operator
Line 759:24: E226 missing whitespace around arithmetic operator
Line 760:33: E226 missing whitespace around arithmetic operator
Line 761:36: E226 missing whitespace around arithmetic operator
Line 762:42: E226 missing whitespace around arithmetic operator
Line 771:23: E226 missing whitespace around arithmetic operator
Line 771:38: E226 missing whitespace around arithmetic operator
Line 771:46: E226 missing whitespace around arithmetic operator
Line 774:29: E226 missing whitespace around arithmetic operator


Update text_data_release.yml to address PMB review comments.

@janetrbarclay, making the quick changes via PR in the github repo.  THese cahnges were from the doc provided by reviewer:
Outstanding items:

replacing U.S. Geological Survey --> U.S. Geological Survey data release.
Since this is for the citation, this might be something we ask sciencebase to do. or we do on sicencebase

Note sure how to address the Type: Online link note in the comments. Maybe this is also something that can be addressed on sciencebase.gov.

These changes are already visible on the sciencebase page.

I just added "data release" to the citation on the ScienceBase landing page and I removed the two existing external resources (the "Type: Online Link" and "Type: weblink")


convert links array to object if empty in ArraySerializer

If paginator has no links it returns empty JSON array, but when it is not empty it returns object. It will be better if an object will be returned, even empty.

:+1: Thank you  This addresses #348


User Templates for the console

Describe the solution you would prefer

When the admin creates we can improve the user experience by letting him/her by having pre-defined user templates, template can include,
-- Groups
-- Roles
-- Common attributes (Ex: company, country)

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


use ts-node to run dev server directly

This gives faster server-reload time in dev and also makes the stack traces refer to the original code, not the transpiled ones in dist.

This disables the current VS Code debugging setup, which lets you set breakpoints and inspect variables and do other debugging tasks directly in the editor. I'll try to get that working again.

Good point. Looks like there's an alternate way to run ts-node including debugging: https://github.com/TypeStrong/ts-node/issues/537

okay, this appears to work for me in IntelliJ, so fingers crossed VS Code works as before

When I edit a .ts file nodemon isn't restarting for me. Also, sometimes my breakpoints aren't working: I didn't test this for long, but from what I can tell, the breakpoints work for .js files and don't work for .ts files.

don't think there's a better way of achieving this at present whilst maintaining debug capability and fast reloads, so let's close for now


CASSANDRA-15254 Support updates on the virtuabl table SettingsTable (use annotations for property updates validation)

Thanks for sending a pull request! Here are some tips if you're new here:

Ensure you have added or run the appropriate tests for your PR.
Be sure to keep the PR description updated to reflect all changes.
Write your PR title to summarize what this PR proposes.
If possible, provide a concise example to reproduce the issue for a faster review.
Read our contributor guidelines
If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:
<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

@smiklosovic Thank you for the comments.
Do you agree with the proposed solution design? Do you have any comments on that?

@Mmuzaf I think you did a good job and David already saw it too so ... I may go through it next days again but seems robust enough to me! I would be nice to have yet another pair of eyes on this, if you happen to get somebody to take a look, that would be great!

Sorry, been away from this patch for a very long time.  If 2 committers are +1 to this patch please don't wait for me and feel free to merge.  I don't know when I will have time to review again.


ModuleNotFoundError: No module named 'pylatex'

I am trying to run SocialFish using python and God knows the struggle I am having to install this simple software for the past 3 days- some 6 hrs of trouble shooting each day.
I had "No module named nmap" error before and I just resolved it and ran SocialFish.py again. Now I have "No Module named pylatex" error and when I google this error and almost no result had any forum dealing with this error.
When I run "pip3 install pylatex" or "pip install pylatex" it says "Requirement already satisfied". It means pylatex is installed in my system but it still shows "No module named pylatex".
Someone pls help. Why am I experiencing so many "No module" errors with python3.
Thanks in advance.
Here is my commands:
**_```
$sudo python3 SocialFish.py
Traceback (most recent call last):
File "SocialFish.py", line 13, in
from core.report import generate_unique #>> new line
File "/home/proton/Desktop/SocialFish/core/report.py", line 2, in
from pylatex import Document, PageStyle, Head, Foot, MiniPage,
ModuleNotFoundError: No module named 'pylatex'

Must be a problem of your internal system.
Try it on another OS, and tell us if the problem is fixed now.


cherry-pick integration test commits over to 1.x branch

We should have as much test coverage here as in master. Will also help keep the build infrastructure in sync. The 1.x release branch must maintain API compatibility with the 1.0 release but we can drag the build infrastructure into the present as much as we like.

resolved in #454


Session Cookie not being set in safari

Setup everything according to docs and it works like a charm on chrome, firefox and edge.
However the cookie will not be set on safari. Any ideas why or how to solve this issue?

Hey, sorry for the late response!
Can you try setting the secure cookie option to false? I think safari blocks it when not on https
export const handle = handleSession({
	secret: 'SOME_COMPLEX_SECRET_AT_LEAST_32_CHARS',
        cookie: {
            secure: false
        }
});

The default for cookie.secure is now false while in dev


Vinnie updates to text in modules October 2022

I went through the text of all the modules and made updates.
There has been an ongoing concern that when changes are made to text and the project is saved, it changes the state of the tutorial. My understanding is that the way to avoid this is to only have .asset files, which contain the text, in the PR. Currently (10/27/22) there's one .json file in the PR--I'm not sure if that might cause problems so this should be looked at by someone who understands what that .json file does in order to avoid changing anything.

This merge results in the "finished" version of the In-Editor tutorials (i.e., includes updates made by @aprilspeight in October 22, and final reviews/edits/updates by Vinnie Tieto and @MaxWang-MS.


flutter_test is no longer compatible with pem

flutter_test is no longer compatible with pem, since flutter_test requires petitparser ^3.0.0, and pem depends on petitparser ^2.1.1.
I'm currently using the latest stable version of the Flutter SDK: Flutter 1.17.5

Filed https://github.com/google/dart-neats/pull/49 to fix this.

Fixed in version 1.0.1


plots rendered inside a closed section have size 0 #2157

scope.container.node().getBoundingClientRect().width/height gives 0 when section is collapsed, use jQuery width()/height() instead

:+1:

:+1:


Offchain(Lighthouse) subtasks for BNB AMB

https://github.com/connext/monorepo/issues/4517
https://connext.notion.site/Pre-Spec-for-BSC-Amb-3578aea3d7a4485eb63498ece0b22fbd

Action Items

processFromRoot():  we don't need any task for bsc anymore, As Axelar doesn't need any transaction at destination.
propogate & sendOutboundRoot::
[ ] implement relayer fee estimation (https://docs.axelar.dev/dev/axelarjs-sdk/axelar-query-api#estimategasfee)
[ ] encoding for the required params for the call to initiate callContract() and other params based on contract construction.
[ ] update unit test and write test for new shared functions

Acceptance Criteria

[ ] Run local env for testnet.
[ ] Run local environment to complete to process the transfers stuck at mainnet.

https://github.com/connext/monorepo/pull/4659


[Question] is Flutter Web supported by this plugin ?

I would like to use this solution for a Flutter WEB application.
I do not see the WEB flag on the pub.dev
Is web supported ? and if not any plan to this support ?

pls refer to the dev/flutter2 branch.


Facebook Ui

I want to add FaceBook UI
Like this ..

Please assign this , I am interested to contribute in hacktoberfest_23 : )

Hey just now I resolved this issue Facebook _Ui
and I had made a PR #106
Once please check it and merge _Hacktoberfest_23 : )


DDEV config not recognized from subfolders

Is there an existing issue for this?

[X] I have searched the existing issues

Are you sure that this bug is related to this DDEV Integration Plugin?

[X] I am sure

Enter your error report ID (If available)
No response
Describe the bug
I have a project running on Windows 10 WSL2 Ubuntu with DDEV. Everything is working fine from the terminal, but the DDEV Integration Plugin does not recognize the existing config, because it is in a subfolder.
In this project, there are several basic configuration files that are not part of DDEV itself. These files all reside in the git root folder. Then there's a folder www which contains a Magento 2 setup including the .ddev folder. When I select Tools > DDEV > Configure it will create a new .ddev folder in the project root above www.

It would be nice if the plugin could either detect DDEV configurations in subfolders or would allow a config setting in PhpStorm where I can define the folder the plugin should look into.
Steps to reproduce
No response
Additional context
No response

Hey @Dergell,
this is the expected behavior.
If you got a mono repo and www is the actual root of the project you would like to work on, please open this folder as a project in phpstorm.
The ddev config is expected to be at the project root, same as a composer.json for example.


New lang: bg. Updated lang: ru. URL slug ability to group by lang.

Added new language - Bulgarian.
Updated language - Russian.
Ability to add different language sets for URL slugify funtion.
Group sets by lang is required cause some langs may have their own rules for the same symbols (like "Щ" in ru and bg - lines 81 and 116).
Not a perfect solution with slug but in this case I found it the easiest one :)
More info in the commit description..

Thanks for submitting this @thewwwizard! I'll take a look at this in just a bit.

@austintoddj Ok. So I'll create a separate PR with only these 2 commits (lang file changes). And do I need to change anything in the current PR?

No you should be good. Once that new PR is merged in with the language changes, the only change in this one will be the slugify() method.


"tslint.alwaysShowRuleFailuresAsWarnings": false should be the default

Currently, "tslint.alwaysShowRuleFailuresAsWarnings": true is configured by default globally.
It was confusing to me that in oder to make "no-shadowed-variable": {"severity": "error"} be recognized by vs I had to change this setting.

without the proper (should be default) configuration "tslint.alwaysShowRuleFailuresAsWarnings": true

with the proper configuration in settings.json I can see that key will be shadowed and I am warned about this error

It should not be necessary to configure this.
There are many places to treat all linting as warnings already.
Vscode should not by default interpret the linting rules differently!

Here is real-world trouble caused by this: https://github.com/angular/angular-cli/issues/16231

Closing as TSLint has been deprecated in favor of ESLint and this extension is no longer being maintained
Please look into migrating to use ESLint and the ESLint VS Code extension


should not depend on Hijk on Windows

because Hijk does not work on Windows, also Hijk requires Net::Ping which also has problems.

thanks for letting me know - i'll make it optional


test(logging): add logging plugin integration test

Issue #

Description

add logging plugin integration test

General Checklist

[x] Added new tests to cover change, if needed
[x] Build succeeds with all target using Swift Package Manager
[x] All unit tests pass
[x] All integration tests pass
[x] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
[x] Documentation update for the change if required
[x] PR title conforms to conventional commit style
[x] New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
[x] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #3218 (f5bb373) into main (22ea491) will increase coverage by 3.41%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main    #3218      +/-   ##
==========================================
+ Coverage   64.77%   68.19%   +3.41%
==========================================
  Files        1090      675     -415
  Lines       36993    28307    -8686
==========================================
- Hits        23963    19303    -4660
+ Misses      13030     9004    -4026

Flag
Coverage Δ

API_plugin_unit_test
?

AWSPluginsCore
69.55% <ø> (ø)

Amplify
?

Analytics_plugin_unit_test
86.39% <ø> (ø)

Auth_plugin_unit_test
75.14% <ø> (-0.10%)
:arrow_down:

CoreMLPredictions_plugin_unit_test
59.44% <ø> (ø)

DataStore_plugin_unit_test
81.12% <ø> (-0.04%)
:arrow_down:

Geo_plugin_unit_test
54.06% <ø> (ø)

Logging_plugin_unit_test
63.18% <ø> (ø)

Predictions_plugin_unit_test
35.17% <ø> (ø)

PushNotifications_plugin_unit_test
69.69% <ø> (ø)

Storage_plugin_unit_test
54.10% <ø> (ø)

unit_tests
68.19% <ø> (+3.41%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 424 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Local Activities

Implement local activities
Big TODOs that will not be done in this PR b/c it is already too huge:

WFT heartbeating
Time handling stuff (clock advancement)
Cancels

@bergundy I have no reason to believe this will cause history compat issues. It's only additive.


[libzip] Fix patch not applying

Error:
error: git diff header lacks filename information when removing 1 leading pathname component (line 2)

Update patch to avoid this situation.
Related: #8896.

/azp run

/azp run

/azp run


bug: .env is in .gitignore

Provide environment information
Not relevant
Describe the bug
In the template, .env is placed in .gitignore although docs state:

Note: .env, .env.development, and .env.production files should be included in your repository as they define defaults.

https://nextjs.org/docs/basic-features/environment-variables
Is there a specific reason for the .gitignore decision in T3? Should it be just
# local env files
.env*.local

To reproduce
Create new app and check .gitignore.
Additional information
No response

The next docs are bad practice. Don't commit your .env that's a terrible idea.

@TheoBr
Personally I don't think env vars should ever be committed, but Next.js and others disagree:

Vite
Create React App
Next
vue
Symfony
Serverless framework

Wow, ok, I just started googling to see where the origin of .env.local came from. No idea, but i'm shoked by how many "things" suggest:

The .env files should be committed to the repository because they are the same for all developers and machines. However, the env files ending in .local should not be committed because only you will use them.

 I mean, github's suggested .gitignore still ignores .env so that's nice. But I'm still shocked.
So my original point was to say something like: maybe some people have gotten used to .env being committed and public, while .env.local is private. And maybe that's bad, but it's something.
So in the context of a Next.js app, it seems wrong to default to .env instead of .env.local, because of how .env is treated by default in Next.js. (and so many others)
I was 3 minutes into using create-t3-app trying to figure out why the .env.local file was missing. I legitimately thought it was this was just a next thing at the time.
I get that it's ignored by git, but it feels wrong in the context of Next.js and could cause issues for anyone relying on Next's env var load order when running automated tests: https://nextjs.org/docs/basic-features/environment-variables#environment-variable-load-order
It kind of feels like playing too close to the edge. Devs that are used to how .env.local work might be upset that you've defaulted away from that. But maybe more importantly, some less experienced devs might uncomment .env and commit it, because next said to do it. Or they might start a new project without create-t3-app and commit a bunch of secrets into .env accidentally.

Anyway, a proposed solution:

Add a .env.local file to the template
Put the default env vars in there
keep an empty .env file and .env in the .gitignore if you like. Even add a comment saying the file is there because next is wrong but we'd rather play it safe so use .env.local 🤷♀

Prisma migrations:
https://www.prisma.io/docs/guides/development-environment/environment-variables/using-multiple-env-files#migration-script

install dotenv-cli as a dev dependency
Add this to the package.json scripts: "migrate:dev": "npx dotenv -e .env.local -- prisma migrate dev"
use yarn migrate:dev instead of npx prisma migrate dev

We have documented this in both the template: https://github.com/t3-oss/create-t3-app/blob/cad79d18832d1fc904e0186f6920fdb1d7d749ea/cli/src/installers/envVars.ts#L49
And the docs: https://beta.create.t3.gg/en/usage/env-variables

I get that it's ignored by git, but it feels wrong in the context of Next.js and could cause issues for anyone relying on Next's env var load order when running automated tests: https://nextjs.org/docs/basic-features/environment-variables#environment-variable-load-order

How so? Any variables added to .env.test will override .env in that environment.
I think gitignoring .env is the right solution. I'd rather have people spend a few minutes confused where their .env.local file is, than to send their secrets to a public repo.

If I set NODE_ENV to test, then all env vars in .env.local are ignored. By using .env, you aren't providing a way to completely ignore env vars during automated testing. I don't really see this as an amazing feature or an issue, it's just some behaviour that exists that t3 app is taking away.

I think gitignoring .env is the right solution. I'd rather have people spend a few minutes confused where their .env.local file is, than to send their secrets to a public repo. People who prefer it the other way need to change one line in gitignore.

I agree with "I would rather people do x than to send their secrets to a public repo." But I'm afraid that it's currently backwards:

.env.local is never committed and never public
.env is often committed and public. By default is committed and made public

By using .env.local you're making it really difficult for someone to send their secrets to a public repo. They would have to be intentionally exposing secrets and being dumb.
By using .env, you're making it much easier to send their secrets to a public repo.  The docs suggest you commit your .env, it's a common practice for many frameworks, and t3 is going against the grain.

@meech-ward - Prisma CAN'T use env.local. We don't have another option.
Also more than happy to fight the norms in favor of best practice, that's the goal of this repo after all 🙏

T3 Open Source is great, you guys are great, I love and respect everything you're doing here. Please don't take any of my comments the wrong way, i'm just trying to have a friendly dialog and help out where I can.
@t3dotgg

Prisma CAN'T use env.local. We don't have another option.

This is a lie and you know it and it makes me want to set the record straight even though it seems like a distraction from the main point of this issue. So real quick, for the record, Prisma can use env.local, it's just not elegant.
npx dotenv -e .env.local -- prisma migrate dev

I share my thoughts on this in a video https://youtu.be/8DiT-LdYXC0?t=215 from 3:35-6:37
@t3dotgg

Also more than happy to fight the norms in favor of best practice, that's the goal of this repo after all 🙏

This is actually a pretty decent argument for an opinionated project. I really just wanted to see the env vars being used in the "normal" next way, or a note somewhere about why T3 is doing things differently. When I started using create-t3-app, I thought the missing .env.local file was a mistake and so I wanted to make sure I wasn't missing something.
Can we add a note to the README.md about why you're using .env and tell people to never commit .env in their projects.
## T3 Axioms
...
4. Environment Variables

Some frameworks and build tools, like Next.js, suggest that you commit `.env` files to your project and only store secrets in `.env.local` files. This is a bad idea. Never commit `.env` files to your project. Never! In a T3 project, all `.env` files are ignored by git and you should use `.env` to store your environment variables, **not** `.env.local`. This means a T3 app will work seamsly with Pisma instead of having to write `npx dotenv -e .env.local -- ` in front of every Prisma command.

Maybe even a comment in the .gitignore file too:
# environment variables
# Do not commit .env files, leave these alone!
.env
.env.production
!.env.example

I can't suggest changes without actually making a PR: https://github.com/t3-oss/create-t3-app/pull/869
Again, T3 Open Source is great, you guys are great, I love and respect everything you're doing here.

The prisma example here is atrocious. Prisma indeed can't read from .env.local, you proved me right there.
Prisma, like all node apps, can have env variables overridden with a custom start script. Acting like that is an acceptable compromise for npx prisma migrate being broken is laughable.
I'm sorry man, we aren't gonna change this.

@t3dotgg I wanted a discussion where the intent of all this was crystal clear, and you've given that to me, so thank you 🙏
I'm not trying to make you change your Prisma commands. But again, for the record, Prisma has this unacceptable compromise straight in their docs https://www.prisma.io/docs/guides/development-environment/environment-variables/managing-env-files-and-setting-variables#using-dotenv-cli-via-command-line
So if someone reads all the next docs, and all the Prisma docs, you can't really blame them for being curious about the .env decision in a t3 app


notify by email and in syslog when a channel goes up or down

Please, incorporate my changes to the master

Before this pull request can be accepted you must first sign a CLA as described at https://www.pfsense.org/about-pfsense/#cla. Please read for more details.

Just signed up the CLA


INSTANCE_CONNECTION_NAME not used in cloud-sql postgres example

The environment variable INSTANCE_CONNECTION_NAME is used in the readme https://github.com/GoogleCloudPlatform/dotnet-docs-samples/blob/main/cloud-sql/postgres/README.md#deploy-to-cloud-run in the gcloud run deploy run-sql command as an env variable. But this env variable is never used in the code.
 We just updated the samples to no longer use INSTANCE_CONNECTION_NAME and instead use INSTANCE_UNIX_SOCKET. I will put up a PR to update the README in the next day or two to address this.
Thanks so much for noticing this and opening up an issue. Much appreciated :)


Removal of custom media type from Get an issue API

https://developer.github.com/v3/issues/#get-an-issue
https://github.com/google/go-github/blob/master/github/issues.go#L254-L256

Closing inactive issue for lack of activity/interest.  Feel free to reopen.


v0.3.709 is broken

I had not used VS Live Share in a while, but attempted to use it today only to learn that it does not work.  In the VS Code "Live Share" tab, if I select any of the three "Join collaboration session...", "Start collaboration session...", or "Start read-only collaboration session..." links, nothing happens.  If I click on the "Start Collaboration Session (Share)" icon at the top of the tab, I see an error notification pop up in the bottom right saying: command 'liveshare.startFromActivityBar' not found
When I close and open VS Code, I see a "Downloading dependencies...: Finishing VS Live Share installation..." message in the toolbar, but it takes forever to finish.  When it finally does, I don't see the "Share" link/icon in the toolbar.
I tried VS Live Share on a mac and it works w/o issue.

It miraculously works today.

Amazing! Nothing discernible has changed about your setup?

i am facing the same problem "command 'liveshare.startFromActivityBar' not found"
currently I'm on Windows 7 and installed VS Live Share Extension Pack for the first time.
Here's my log
sqawsq.zip

I also see this error message every time i reload the vs code
Failed to install support for joining sessions using a browser link. You can still join sessions manually.
And when trying to sign in
Agent terminated with exit code: 0 and signal null: Failed to load the dll from [C:\Users\AJ.vscode\extensions\ms-vsliveshare.vsliveshare-0.3.1225\dotnet_modules\hostfxr.dll], HRESULT: 0x80070057 The library hostfxr.dll was found, but loading it from C:\Users\AJ.vscode\extensions\ms-vsliveshare.vsliveshare-0.3.1225\dotnet_modules\hostfxr.dllfailed - Installing .NET Core prerequisitesmight help resolve this problem.http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409
error message pops up

@A1K2S3   How did you solve it?

@GeSnowBoy I've faced the same problem and I've solved it through running the command in https://docs.microsoft.com/en-us/visualstudio/liveshare/reference/linux
wget -O ~/vsls-reqs https://aka.ms/vsls-linux-prereq-script && chmod +x ~/vsls-reqs && ~/vsls-reqs

Actullay, I tried many different ways but none of them worked for me, and
after hours of effort finding the solution I uninstalled live share because
none of them were working. But after some time I installed it again and it
worked. No errors occured while installation. I don't have a clear idea
about how it worked it just installed without error.
On Tue, 26 Mar 2019 at 13:14, 孤标傲世<EMAIL_ADDRESS>wrote:

@A1K2S3 https://github.com/A1K2S3 How did you solve it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/live-share/issues/1030#issuecomment-476510239,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AqqMuhtaiCXBIK-CYqiWQfEK6Ihc9rAWks5vac_pgaJpZM4W5V51
.

I had the same issue Windows 10. Restarting vscode worked for me.


Add Engine::destroy(Engine*) to match other APIs

Fixes #1376

I wasn't sure if we wanted to deprecate this. It's a slightly different use case, but probably not very important/useful to keep around.


Project test coverage?

I've just started using ag-grid for a project and it's been pointed out by a colleague that test coverage is pretty much non-existent.
Can you please confirm if this is the case, or are we missing something?
Secondly, how receptive is the project to contributions around this, is it something that's already underway or on the roadmap?
Thanks

He wrote back in the old days somewhere that He won't be providing tests, but the policy he forces on e.g. pull requests requires everyone to update relevant examples and docs. @ceolter am I right?

#10 is the earlier test-releated issue

Thanks @noherczeg & @AkosLukacs :+1:

i am not writing tests and don't intend them any time soon. again due to my massive re-factoring efforts i'm doing and my style of development.
before i release, i do full manual regression testing. all of the features i implement are present in the documentation examples which i use for my manual testing, so in effect the documentation acts as my regression test script.
historically, the grid is very solid, more solid than other projects with lots of tests.
if your colleague uses this as a measure of good quality code, you should use ui-grid, it's poor in comparison IMO, but you can sleep well knowing the poor code has lots of tests!
ps closing this, as it's a duplicate

Thanks @ceolter, appreciate your considered response :)


Could not GET 'https://maven.pkg.github.com/trustwallet/wallet-core/com/trustwallet/wallet-core/2.9.8/wallet-core-2.9.8.pom'.

Describe the bug
I try run example，but I am get a failed
Could not GET 'https://maven.pkg.github.com/trustwallet/wallet-core/com/trustwallet/wallet-core/2.9.8/wallet-core-2.9.8.pom'. Received status code 401 from server: Unauthorized
To Reproduce
I hava setting gpr.user & gpr.key,but I cant  gradle sync success
Screenshots

Additional context
I doubt whether my token is correct, but I can use it to request GitHub API，Successed.
Do you need other permissions or steps？

Take a look at this guide: https://developer.trustwallet.com/wallet-core/integration-guide/android-guide#adding-library-dependency, make sure your token has package read permission

Remove double quotes @saberlpslpsl


One peer can't connect

Background
One of my peers stopped working today. I noticed in the log that it attempts to connect but fails every time.
Your environment

version of lnd: 0.13-beta 756a0ab39240dcfd15dea325c5921ef84e7109d9
which operating system (uname -a on *Nix): Linux 5.10.46-v7l+ #1432 SMP Fri Jul 2 21:17:20 BST 2021 armv7l GNU/Linux (RaspberryPi 4 B)
version of btcd, bitcoind, or other backend: bitcoind 0.21.1

Actual behaviour
Here's the log:
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.333 [INF] SRVR: New inbound connection from <IP_ADDRESS>:50694
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.334 [INF] SRVR: Finalizing connection to 03baa70886d9200af0ffbd3f9e18d96008331c858456b16e3a9b41e735c6208fef@<IP_ADDRESS>:50694, inbound=true
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.543 [INF] PEER: NodeKey(03baa70886d9200af0ffbd3f9e18d96008331c858456b16e3a9b41e735c6208fef) loading ChannelPoint(1bfb6afde67ea8b539f3e9d41ad8f5bee5bf8fb553c01a14f368f13d65ce8c7e:1)
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.544 [INF] HSWC: Removing channel link with ChannelID(7e8cce653df168f3141ac053b58fbfe5bef5d81ad4e9f339b5a87ee6fd6afb1a)
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.544 [INF] HSWC: ChannelLink(686414:2075:1): starting
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.545 [INF] HSWC: Trimming open circuits for chan_id=686414:2075:1, start_htlc_id=205
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.545 [INF] CNCT: Attempting to update ContractSignals for ChannelPoint(1bfb6afde67ea8b539f3e9d41ad8f5bee5bf8fb553c01a14f368f13d65ce8c7e:1)
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.546 [INF] HSWC: ChannelLink(686414:2075:1): HTLC manager started, bandwidth=489198107 mSAT
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.546 [INF] HSWC: ChannelLink(686414:2075:1): attempting to re-synchronize
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.545 [INF] HSWC: Adding live link chan_id=7e8cce653df168f3141ac053b58fbfe5bef5d81ad4e9f339b5a87ee6fd6afb1a, short_chan_id=686414:2075:1
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.548 [INF] PEER: Negotiated chan series queries with 03baa70886d9200af0ffbd3f9e18d96008331c858456b16e3a9b41e735c6208fef
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.548 [INF] DISC: Creating new GossipSyncer for peer=03baa70886d9200af0ffbd3f9e18d96008331c858456b16e3a9b41e735c6208fef
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.661 [INF] HSWC: ChannelLink(686414:2075:1): received re-establishment message from remote side
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.678 [INF] HSWC: ChannelLink(686414:2075:1): sending 2 updates to synchronize the state
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.823 [INF] DISC: Received new remote channel announcement for 686414:2075:1
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.825 [INF] DISC: GossipSyncer(03baa70886d9200af0ffbd3f9e18d96008331c858456b16e3a9b41e735c6208fef): applying new update horizon: start=2106-02-07 09:28:15 +0300 MSK, end=2242-03-16 15:56:30 +0300 MSK, backlog_size=0
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.843 [INF] PEER: unable to read message from 03baa70886d9200af0ffbd3f9e18d96008331c858456b16e3a9b41e735c6208fef@<IP_ADDRESS>:50694: read tcp <IP_ADDRESS>:9735-><IP_ADDRESS>:50694: read: connection reset by peer
Jul 04 23:19:54 fullnode lnd[22879]: 2021-07-04 23:19:54.844 [INF] PEER: disconnecting 03baa70886d9200af0ffbd3f9e18d96008331c858456b16e3a9b41e735c6208fef@<IP_ADDRESS>:50694, reason: read handler closed
Jul 04 23:19:55 fullnode lnd[22879]: 2021-07-04 23:19:55.045 [INF] DISC: Removing GossipSyncer for peer=03baa70886d9200af0ffbd3f9e18d96008331c858456b16e3a9b41e735c6208fef
Jul 04 23:19:55 fullnode lnd[22879]: 2021-07-04 23:19:55.045 [INF] HSWC: Removing channel link with ChannelID(7e8cce653df168f3141ac053b58fbfe5bef5d81ad4e9f339b5a87ee6fd6afb1a)
Jul 04 23:19:55 fullnode lnd[22879]: 2021-07-04 23:19:55.045 [INF] HSWC: ChannelLink(686414:2075:1): stopping
Jul 04 23:19:55 fullnode lnd[22879]: 2021-07-04 23:19:55.045 [INF] HSWC: ChannelLink(686414:2075:1): exited

I see the weird update horizon dates, year 2106? Not sure if it matters of course. That peer claims to be running c-lightning.

Hmm, that's weird. It might be coincidence that the peer disconnects just after updating the horizon.
But setting an update horizon far in the future is how your node tells a peer to not gossip about things: https://github.com/lightningnetwork/lightning-rfc/blob/master/07-routing-gossip.md#rationale-7
So it should be understood by c-lightning.
Hard to say what to do here. I assume the connection has been re-tried several times?
Is there a way to contact the peer and ask for their logs?

There's no contact information, unfortunately. All I have is that page I linked. Surprisingly, it just started working about an hour ago, I didn't do anything. But now I have the same issue with that channel that I described in #5468. Here's the channel info:
        {
            "active": true,
            "remote_pubkey": "03baa70886d9200af0ffbd3f9e18d96008331c858456b16e3a9b41e735c6208fef",
            "channel_point": "1bfb6afde67ea8b539f3e9d41ad8f5bee5bf8fb553c01a14f368f13d65ce8c7e:1",
            "chan_id": "754720174604222465",
            "capacity": "996238",
            "local_balance": "498283",
            "remote_balance": "496299",
            "commit_fee": "1656",
            "commit_weight": "724",
            "fee_per_kw": "2286",
            "unsettled_balance": "0",
            "total_satoshis_sent": "10224268",
            "total_satoshis_received": "9727969",
            "num_updates": "923",
            "pending_htlcs": [
            ],
            "csv_delay": 144,
            "private": false,
            "initiator": true,
            "chan_status_flags": "ChanStatusDefault",
            "local_chan_reserve_sat": "9962",
            "remote_chan_reserve_sat": "9962",
            "static_remote_key": true,
            "commitment_type": "STATIC_REMOTE_KEY",
            "lifetime": "46828",
            "uptime": "3132",
            "close_address": "",
            "push_amount_sat": "0",
            "thaw_height": 0,
            "local_constraints": {
                "csv_delay": 144,
                "chan_reserve_sat": "9962",
                "dust_limit_sat": "573",
                "max_pending_amt_msat": "18446744073709551615",
                "min_htlc_msat": "0",
                "max_accepted_htlcs": 30
            },
            "remote_constraints": {
                "csv_delay": 1008,
                "chan_reserve_sat": "9962",
                "dust_limit_sat": "546",
                "max_pending_amt_msat": "986276000",
                "min_htlc_msat": "1",
                "max_accepted_htlcs": 483
            }
        },

I tried to send 100 sats to myself from this channel and got insufficient local balance.

I just saw your other issue. Might be a problem of data corruption indeed. If your node sends over invalid parameters (because they are read incorrectly from the DB) then the peer can decide to just cut the connection.

Okay, thanks. I'll close these two channels then and reopen them as you suggested there!

If you run into further weird issues, I'd really recommend on not using that SSD any longer...

It's a new SSD, unused and working well. The issue is the power source that I use for my RPi 4, it's an Apple charger. It should provide 3A/5V but I saw some undevoltage errors in dmesg so not sure anymore. I ordered the official PSU (they're surprisingly hard to find in stores) and locked the CPU frequency at 600 MHz, it's working slower now but no errors and freezes so far.

Closing as it appears to be a hardware issue?


Have f-test model

     return np.nan

https://github.com/amichuda/statsmodels/blob/c74f4a6e3b593ad4c2ec4dc4adc1a36d8ab48cf4/statsmodels/regression/linear_model.py#L1853
Right now we don't fun a f-stat for the full model, but the statsmodels table has it. Setting it to np.nan for now.

Yes, sounds good. We can have it once we have access to the full vcov matrix.


Analyzer: poor error message when using nonfunction type aliases without upgrading language version

The following code is erroneous, since it attempts to use both the null safety and the nonfunction type alias features without moving to the 2.13 language version:
typedef A = int;
void main() {
  int? x;
}

The analyzer currently prints the following error messages for this code:
  error • Invalid generic function type. • /Users/leafp/tmp/test.dart:3:11 • invalid_generic_function_type
  error • This requires the 'non-nullable' language feature to be enabled. • /Users/leafp/tmp/test.dart:5:6 • experiment_not_enabled

I can see that in general it may be difficult to tell when a user has merely mistyped a typedef instead of attempted to use a nonfunction type alias, but I wonder whether we can possibly give more useful feedback here?  I'm concerned that users will attempt to use the feature without upgrading their language version, and will get no help from the resulting error message.  Perhaps at least ensuring that the "help" text accompanying this error mentions the possibility of a language version mismatch might help?
cc @bwilkerson @devoncarew @scheglov @eernstg

At the place where the invalid_generic_function_type is emitted, perhaps the analyzer already parses a <type> rather than a <functionType>? In that case it might be useful (when the language version is below 2.13) to emit the message that nonfunction-type-aliases needs to be enabled, unless there is a syntax error.

Yes, we have similar hints for other experiments.
I will update the parse to report such nudge for non-function typedefs as well.

https://dart-review.googlesource.com/c/sdk/+/193100

  error • This requires the 'nonfunction-type-aliases' language feature to be enabled. • /Users/leafp/tmp/test.dart:2:11 • experiment_not_enabled

👍


Send Email only on Fail?

I'm using your script inside a loop. So this is just the chunk that runs in the loop. The code uses Guzzle to hit a URL.
Currently, it sends an email every time a job is run. But, I'm trying to figure out how to only send email if Guzzle gives any status code other than 200... or maybe there is a better way?
$scheduler->call(function() use ($siteUrl, $file, $k, $v) {
	$client = new \GuzzleHttp\Client();
	$res = $client->head($siteUrl . $v['url'], [ 'http_errors' => false ]);

	$data = [
		'status'   => $res->getStatusCode(),
		'datetime' => date('Y-m-d H:i:s'),
	];

	echo json_encode($data);
})
->at($v['runtime'])
->output($file)
->configure([
	'email' => [
		'subject' => "Cron: '{$k}' at {$siteName}",
		'from'      => $config['email']['from'],
		'transport' => $transport,
	]
])
->email([ $toEmail ]);

Any ideas on how to set $toEmail to false inside the anonymous function ... or not send the email?
Thanks.

I just used SwiftMailer inside the anonymous function and checked if the status code from Guzzle was 200. If not 200, then send an email. I then removed the configure() and email() method calls.

@green-plastic sorry for the late reply, yes that's exactly how I would use it.
Another option would be to send the email in the then (but I guess because you're using an anonymous function there would be no benefit).
It's an interesting feature that could be integrated in the core if you want to submit a PR for that.
My only question would be what can be considered an error? An exception? I think the exception can work for anonymous functions, but not if you're scheduling a script.

@peppeocchi The way I laid it out works fine. I use Guzzle to hit a URL. I could get fancier, but mostly just checking that hitting the URL works. Most the URLs that are hit do something fairly basic and log themselves.


Dom like scene

Create a basic scene structure.
Proposed solution
A Scene is composed of a name and a root Node. Every Node has a name and can have from 0 to N child Node.
The Engine should have a method to create the initial state from a scene definition specified in a YAML file.

change of plan.
This issue is no more valid


Link to a template in Getting Started

Hey @sgugger @jph00—awesome job on nbdev. Just wanted to draw your attention to a potentially broken link in the docs under Getting Started: "To begin your own project, click here: nbdev template."—it takes you to https://github.com/fastai/nbdev_template/generate and it's a "404". Thanks from all of us for all your hard work 💪

I can open the link without any problem and checked with several other people they could. Not sure what the problem is.

Thanks @sgugger 🙌


Use a centralized set of pre-recorded messages for Reasons autocompletion (extend to Welcome and Broadcast if easy)

A server owner should be able to define a list of pre-made reason messages (for punish/kick/ban) and save it server side.
So that moderators have those messages ready in the UI.

(Python, rcon module) Create a class leveraging the UserConfig table that is able to store a list of message given a specific name space (CRUD)
(Python, rconweb module) Add API endpoints to use the class above
(React, rcongui) Create a manager UI for the above under the Advanced Rcon settings panel
(React, rcongui) in TextHistory load the list of premade messages on instanciation (don't store on localstorage though, this could cause some weird out of sync behaviour), mayve good to cache them somehow (probably best done in the HTTP layer)

Done. Will be in next release.


CUDA error: CUBLAS_STATUS_NOT_SUPPORTED on Kubuntu 23.04 x86_64 with NVIDIA GeForce RTX 3090 Ti

@agentmorris An EcoAssist user has found a CUDA error while running inference on GPU. See https://github.com/PetervanLunteren/EcoAssist/issues/16 for more information.
I don't think it is an EcoAssist error, since the traceback originates from run_detector_batch.py. It seems that it can be caused if there is a mismatch between the dimension of the input tensor and the dimensions of the nn.Linear module. Any idea what is going on?
The environment is created with the YAML file below.
channels:
  - conda-forge
  - pytorch

dependencies:
  - python=3.8
  # We pin Pillow to make it as likely as possible that images are loaded via a loader that's identical to the training environment
  - Pillow=9.1.0
  - tqdm
  - jsonpickle
  - humanfriendly
  - numpy
  - matplotlib
  - opencv
  - requests

  # So we can run Jupyter notebook this environment
  - nb_conda_kernels
  - ipykernel

  # For running MegaDetector v5
  - pandas
  - seaborn>=0.11.0
  - PyYAML>=5.3.1
  - pytorch::pytorch=1.10.1
  - pytorch::torchvision=0.11.2
  - conda-forge::cudatoolkit=11.3
  - conda-forge::cudnn=8.1

  # For running MegaDetector v4
  # - tensorflow>=2.0

Thanks for the heads-up.  I'm going to close this issue and respond to the issue on the EcoAssist repo.

For posterity: this was resolved by running:
export LD_LIBRARY_PATH=''
...prior to starting EcoAssist.


Add retry for JWT auth to void application startup failed

Fixed https://github.com/eclipse-xpanse/xpanse/issues/2178
Related to https://github.com/eclipse-xpanse/tofu-maker/pull/89
Related to https://github.com/eclipse-xpanse/terraform-boot/pull/171
When connect to IAM server failed will retry:

LGTM

LGTM

LGTM


Couldn't make it work on Android

I did all the steps below:

added the plugin
edited config.xml and added the paths
I've added the <link rel="alternate" href="android-app:... part to my website
in Play Console I added the website URL (and verified it)
in the Search Console I've added the domain and verified it

When I test it with ADB, I still get the Error: Activity not started, unable to resolve Intent message. :-(
What am I missing here?

Allright... I'm halfway done. :-) Now it works using the ADB shell command, after I've added this segment to my AndroidManifest.xml:
            <intent-filter android:label="CubeSmith">
                <action android:name="android.intent.action.VIEW" />
                <category android:name="android.intent.category.DEFAULT" />
                <category android:name="android.intent.category.BROWSABLE" />
                <!-- Accepts URIs that begin with "http://www.example.com/gizmos” -->
                <data android:scheme="https"
                    android:host="cubing.rocks"
                    android:pathPrefix="/deeplink" />
                <!-- note that the leading "/" is required for pathPrefix-->
            </intent-filter>

However, when I use the universal link from another app (or from Chrome), I still get the dialog "Complete action using..." and I have to choose my app or Chrome.

Allright... I'm halfway done. :-) Now it works using the ADB shell command, after I've added this segment to my AndroidManifest.xml:
            <intent-filter android:label="CubeSmith">
                <action android:name="android.intent.action.VIEW" />
                <category android:name="android.intent.category.DEFAULT" />
                <category android:name="android.intent.category.BROWSABLE" />
                <!-- Accepts URIs that begin with "http://www.example.com/gizmos” -->
                <data android:scheme="https"
                    android:host="cubing.rocks"
                    android:pathPrefix="/deeplink" />
                <!-- note that the leading "/" is required for pathPrefix-->
            </intent-filter>

However, when I use the universal link from another app (or from Chrome), I still get the dialog "Complete action using..." and I have to choose my app or Chrome.

Just to be sure.... If I'd like to use universal links like this:
https://mydomain.com/deeplink/something=123
Then I have to add this:
<link rel="alternate" href="android-app://com.mydomain.myapp/https/mydomain.com/deeplink/" />
to the <header> part of https://mydomain.com/deeplink/index.php?

Just to be sure.... If I'd like to use universal links like this:
https://mydomain.com/deeplink/something=123
Then I have to add this:
<link rel="alternate" href="android-app://com.mydomain.myapp/https/mydomain.com/deeplink/" />
to the <header> part of https://mydomain.com/deeplink/index.php?

That is how I understood the docs. Still trying to make this work

Before I embark on this... did you get it working?

Works fine for me.

Just a comment for anyone wondering if it works on Android 12:
Yes it does but you have to verify your domain now. See Android 12 changes and verify-site-associations.


Icons are clipping in awesomewm-vertical on ArchLinux

I have installed both the nerd fonts as instructed in the readme.
As you can see some icons are sized correctly like the brightness and volume slider icons but others are clipping in their containers.
I have not modified anything in the config.
I am using this config on Arch linux, with a screen size of 1920x1080

hm, i don't really know why the fonts aren't working in this case :/ maybe i forget to include some fonts xD, try installing the nerd-fonts-complete from the aur and restarting completely X11, if that doesn't works too, i'll need a bit more of time to reproduce it installing arch. Also, sorry for late response. :/

I'm having the same issue installing nerd-fonts-complete doesn't help, amazing rice btw

im having the exact same issue on the latest arch build

im having the exact same issue on the latest arch build

Me too, the exact same but in horizontal layout

Hm sorry guys, i have to reproduce it in arch then :v

Any update on this issue? I suggest to change the title to "Icons clipping on ArchLinux". Also, temperature doesn't work, can someone confirm? I can fix it for arch, but the right thing to do would be start looking for a long term solution, an os and cpu architecture independent one. What do you guys think?

Any update on this issue? I suggest to change the title to "Icons clipping on ArchLinux". Also, temperature doesn't work, can someone confirm? I can fix it for arch, but the right thing to do would be start looking for a long term solution, an os and cpu architecture independent one. What do you guys think?

Not yet, i didn't had enough time to try to make a fix (or at least install arch on a virtual machine) because i'm in exams :v (sorry for that y'all). Also, i'll try to make a fix for the temperature, but for that i'll need some details, can you open another issue showing some details of the issue? like what the temperature widget do and that stuff.

Also, about the clipping of the icons, can you guys check if the icons clipping problem just happens with the UI of the rice, or it's still happening on others Apps too?

I'm also getting this problem in Void Linux. Installed it on a VM to test it out and am getting the same icon clipping problem.

Also, about the clipping of the icons, can you guys check if the icons clipping problem just happens with the UI of the rice, or it's still happening on others Apps too?

It was just happening on the rice but i didn't have much more installed at the moment of trying

Ok so I've reproduced in a new freshly installed arch Linux, looks like an update on the nerd fonts, I've got a fix for that, I'll push the changes asap, i think i have to change the nerd font, jet brains looks rare lol

ok i pushed the changes, can you guys recheck if with Iosevka Nerd Font works better?

Hi! Can you push the fix to the awesomewm branch too?

ok i pushed the changes, can you guys recheck if with Iosevka Nerd Font works better?

yeah sure, it's done, try pulling the changes and copy again cfg/awesome to ~/.config/

It actually did not solve the problem. It's just a different kind of clipping now, I would say it's worse. I'd also love to see other people following the issue so we could get more feedback.

@fithurriague thanks for your debugging and for every time that you're spending on this for help me! I suspected that iosevka wouldn't solve the problem for this, for some reason on void Linux worked to me, but i think that this could be a problem on an update of NF, because on void i had an outdated version of it, i tried on a fresh arch install and the problem appeared, i solved it by setting theme.nerd_font to an inexistent font (such as Iosevka which i didn't installed on that system) (those changes inside cfg/awesome/theme.lua). Anyways this is so weird because icons aren't working like how should work :/
Don't makes sense that an inexistent font worked and displayed every icon in the UI (and avoided this issue)
So tbh I'll need a very good time of debugging to try to get this working, because i don't understand too much the font issue lol
As @fithurriague said, more ppl feedback could be good for some investigation about this because is so strange and happens on every awesomewm rice :v

I am trying this on OpenSUSE and had the same icon clipping issue while using the Nerd Fonts v2.2.2. However, when I downgraded to the 2.2.1 version it now started working as intended.
This is definitely an issue with the new version of the Nerd Fonts.  Also, I tried the 2.3.0RC version they have up and the issue still persists, I guess it only works with the 2.2.1 version.

Ok so, as I supposed and as @Underscore30 says, it's a nerdfonts update issue.... so i'll need to rework a "little" bit more the configuration to make it look better with the newer ones lol, a temporary fix guys is downgrade the nerdfonts as how @Underscore30 said

@AlphaTechnolog Sorry to disappoint, but the font issue is also happening for me on Void Linux!

@AlphaTechnolog Sorry to disappoint, but the font issue is also happening for me on Void Linux!

they could have updated the nerd fonts then... so basically these dotfiles are running under an outdated version of nerdfonts? maybe some refactor is needed then. People's help is actually heavily appreciated tho! anyways imma try to fix it asap.


FAQ

There is a list of questions people have about Boost. Often these questions take the form of criticisms, because people don't understand the reasons for why Boost maintainers do things one way and not the other. There should be a FAQ page where these questions are answered and criticisms are addressed.

Examples by @pdimov:

"why is boost using b2, isn't that a hassle?" (answer: b2 builds multiple variants at once, the cmake configs support that)

"how can I build boost with cmake, using my custom toolchain?" - point to boostorg/cmake/README

"muh monolith" - when a company gives green light on the monolith / you invest the initial time to integrate the monolith, you get all of the things for no additional cost

"why boost instead of std" - regex, unordered, etc

Paradoxically, another criticism I've heard: Boost is not monolithic enough, that is, rather than using submodules it should use a monorepo.

https://www.reddit.com/r/cpp/comments/130bzj8/comment/jhxgxi8/?utm_source=reddit&utm_medium=web2x&context=3

This page already exists although it doesn't have any content yet. It's site-pages/help.adoc and will get rendered here as a FAQ in the top level of the website hierarchy. This is for more generic criticism. Maybe it should be site-pages/FAQ.adoc. I don't know.
Other common criticisms are being addressed in the corresponding pages, like in the Getting Started guide, which now mentions boostdep, cmake, and even package managers. The FAQ can (should?) also include links to these more specific pages.

Yeah, definitely should.

@grisumbras @alandefreitas @pdimov
I created this FAQ and added it to the User Guide:  https://docs.cppalliance.org/user-guide/faq.html
Should this be moved to the Help page and the questions/answers above added? Or do you have something different in mind for the Help page?

Vinnie wanted that in user-pages because the website will take it from there and render it somewhere else. To avoid duplicate work, you can create a symlink from the page in user-pages into the antora partials directory and just include that partial in the faq.adoc of the user guide.


Bug with alerts

Manual removal should not cause huge delay with auto-removal.

Fixed in this commit:
https://github.com/Paqmind/react-ultimate/commit/35d9d648e1a4f7cebb4bbc6b5938f0eef0dbd20c
Merged in master

Updated master with last changes

Fixed


[FLINK-3229] Flink streaming consumer for AWS Kinesis

I've been using this consumer for a while in off-production environments.
I understand we should have good test coverage for each PR, but since Kinesis is a hosted service, reliable integration tests are hard to pull off. To speed up merging Kinesis connector for the next release, I'm submitting the consumer now for some early reviews.
On the other hand, since @rmetzger is submitting a separate PR for Kinesis producer, I'd like to postpone writing more tests for the consumer, as well as corresponding modification to the document until both the consumer and producer are in place.

Thank you for opening a pull request for the consumer.
How about we proceed like this:

I'm trying to get the producer code merged within the next 24 hours (feel free to test it a bit if you want)
In the meantime, I'm testing and reviewing your code
Once the producer has been merged, we integrate the consumer code into the maven module / code structure from my producer code.
I'll review the consumer again and we merge it ;)

@rmetzger Sure, that seems reasonable. I'll wait until the producer is merged and resubmit a new PR for the integrated consumer.

Cool. You don't need to resubmit a new PR. By pushing new commits to your FLINK-3229 branch, the pull request will update automatically.

Quick update on our plan: I've merged the Kinesis producer. If you want, you can rebase this pull request on the current master.

@rmetzger Hi Robert,
I'm rebasing my PR, but I could not find the merged Kinesis producer / maven module in the current apache/flink master. Please correct me if I'm doing anything wrong. Thanks :)

@tzulitai The producer wasn't merged yet.

ah ok :) see it now, thanks.

The problem was that the github mirror needed some time to sync with the commit. But now its there.

Quick update:

Rebased and integrated the consumer code into the maven module that came with the producer merge.
Appended documentation for the consumer.
Moved the producer's KinesisSerializationSchema into org.apache.flink.streaming.connectors.kinesis.serialization package, where I originally placed deserialization related classes for the consumer.

Great, thank you. I'll review the PR soon.

I could not get the example to work with the current jackson version. Only after upgrading it  to 2.7.3 it was working.
Did you test the kinesis consumer using a separate project (adding the flink-kinesis-consumer as a dependency) ?

Overall, I really like the work you did for the Kinesis Consumer! As you can see I've added some comments on the PR.
Please let me know what's you opinion on my comments.
When you do you think you'll have time to address the issues? I would like to get the code merged as soon as possible because Amazon is asking for having it in Flink soon. If you know already that you won't have time for working on this in the upcoming days, I can also address the comments. Just let me know, I think we can find a solution.

@rmetzger Regarding the need to upgrade Jackson to get the example working:
After updating the code for Flink 1.0.x to prepare for PR, I only tested the consumer with manual tests within the Flink project code.
However, when the consumer was first implemented when Flink was 0.10.1, at the time I did package the consumer and used it as a separate dependency.
I'm wondering would it have anything to do with changes between older & newer Flink version?

@rmetzger
Thank you very much for your detailed review on the PR :)
I've replied to the comments you added, please .
I can address the issues and follow up with corresponding commits within the next 36 hours. I am pretty much free for the next 3 days, and will very much like to get the consumer ready for merging by the end of this week :)
If it still isn't ready by the end of 4/25, I'm afraid I will have to leave any remaining issues for you to address since after then I temporarily won't be able to work on code until June.

Hi,
Cool, if you have time to adress them, go ahead :)
Thanks a lot for doing this by the way! I really like the work you did so far on the connector!
Sent from my iPhone

On 22.04.2016, at 18:01, Tzu-Li Tai<EMAIL_ADDRESS>wrote:
@rmetzger
Thank you very much for your detailed review on the PR :)
I've replied to the comments you added, please .
I can address the issues and follow up with corresponding commits within the next 36 hours. I am pretty much free for the next 3 days, and will very much like to get the consumer ready for merging by the end of this week :)
If it still isn't ready by the end of 4/25, I'm afraid I will have to leave any remaining issues for you to address since after then I temporarily won't be able to work on code until June.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Regarding the Jackson / dependency issue: You don't need to worry about it know. I'll take another look at the problem and make sure it'll work once we merge it.

@rmetzger I've addressed your comments with the latest commits. Thanks in advance for your help on reviewing them :) Please let me know if there is anything else to address!

I wonder why one of the Travis CI builds is failing on flink-ml? My current FLINK-3229 branch is a few commits behind current apache/master, does it have anything to do with that?

The build failure is unrelated to your changes. Its just an instability of the testing infrastructure.

I'm currently busy with some other ongoing tasks. I hope to get back to this PR soon.

@rmetzger
No problem. In the meantime, I've made a few more changes, including more test coverage for the consumer, minor refactoring, and user configuration changes.

I'm currently working on a custom branch based on this pull request.
It seems that we are running into some dependency issues when using the kinesis-connector in AWS EMR.
It seems that there is a clash with the protobuf versions (kinesis needs 2.6.x, but Flink has 2.5.0 in its classpath).
I keep you posted

Thanks Robert. I'll keep notice of your FLINK-3229-review branch for the changes (I'm assuming your working on FLINK-3229-review for the protobuf problem, please tell me if I'm wrong :))
Also, if there is anything I can do / help with (etc. tests on other environments) to further improve the PR, please don't hesitate to let me know :)

Yep, that's the right branch.
I tried working on different approaches, but its just an annoying problem with protobuf.
I'll probably work on it tomorrow again.

As discussed in the JIRA, I'm going to follow the "relocation approach" for fixing the protobuf issue. But we won't release the kinesis connector to mvn central.
In the meantime, we'll try to come up with a better solution regarding the protobuf issue.


Update Convert-WindowsImage to allow creating ARM64 VHDX files

Convert-WindowsImage currently skips ARM64 images since there had been no virtualization platform for them.  Now that HyperV for ARM64 clients is available in Insider builds, that restriction should be removed.

This should be good, so long as this isn't expected to work cross-architecture


There is no debug flag

IIS Service monitor should have a debug flag to show any necessary debugging output.

This work will not be done since we have other priorities at the moment.


inline map types

Codecov Report

Merging #85 (195dfc5) into main (1137a9b) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   82.37%   82.48%   +0.10%
==========================================
  Files          11       11
  Lines         817      822       +5
  Branches      234      236       +2
==========================================
+ Hits          673      678       +5
  Misses        144      144

Impacted Files
Coverage Δ

src/autogenerate/index.ts
95.10% <100.00%> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1137a9b...195dfc5. Read the comment docs.


Add skip_empty option to tf.string_split

This fix add skip_empty to tf.string_split so that it is possible to have tf.string_split behaving similiarly with python.
This fix fixes #12108.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

Can one of the admins verify this patch?

@tensorflow-jenkins test this please

(Looks good for API change, removing the label)

@asimshankar Thanks!

@tensorflow-jenkins test this please

@rmlarsen @asimshankar Thanks for the review. All Jenkins tests passed except //tensorflow/tools/api/tests:api_compatibility_test
The PR has now been updated with
bazel-bin/tensorflow/tools/api/tests/api_compatibility_test           --update_goldens True

Please take a look.

@yongtang thanks for the contribution!


[ENH] Allows multiple values_to when names_pattern is a list/tuple

PR Description
Please describe the changes proposed in the pull request:

Allows multiple values_to when names_pattern is a list/tuple

This PR resolves #1048.

PR Checklist

Please ensure that you have done the following:

[ ] PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.

[ ] If you're not on the contributors list, add yourself to AUTHORS.rst.

[x] Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.

Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks
There will be automatic checks run on the PR. These include:

Building a preview of the docs on Netlify
Automatically linting the code
Making sure the code is documented
Making sure that all tests are passed
Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@ericmjl

🚀 Deployed on https://deploy-preview-1050--pyjanitor.netlify.app

@thatlittleboy if you think things are good here, please do the honours of merging! (Also don't worry about codecov, it's misbehaving again haha.)


[MM-20061] Add System Admin filter to both LDAP and SAML settings in Admin Console

Merge Third
Summary

Adds the front end portion for system admin filter in LDAP and SAML
Ticket Link

https://mattermost.atlassian.net/browse/MM-20061
Related Pull Requests

Has server changes

https://github.com/mattermost/mattermost-server/pull/13534
https://github.com/mattermost/enterprise/pull/557

@srkgupta
I have addressed the caching problem. I also added a Enable Admin Filter and Enable Admin Attribute for LDAP and SAML respectively.  Just to note how the workflow goes

Just one clarification on the note above. We don't distinguish between admins promoted by the filter and admins manually promoted. Even if a user is promoted to admin manually, they will be demoted on next login if they don't match the Admin filter/attribute and the option is enabled.

Documentation PRs: https://github.com/mattermost/docs/pull/3359 and https://github.com/mattermost/docs/pull/3355.


Added Redprint.

Added Redprint (formerly bp-utilities) to the installation docs.

I highly dislike this approach, alongside that, you are attempting to merge workflows.


Add haddock comments

Current implementation of concepts lacks Haddock comments. We need to add them as part of converting concepts into a library package and putting it on Hackage.
Haddock syntax: https://www.haskell.org/haddock/doc/html/ch03s08.html

When you publish a Go package with inline comments (docs), you can then link to godoc.org like this:

Makes it really easy to navigate the docs, especially via the badge. Is there a service like this for Haskell? I couldn't find anything on a quick google search.

I think there is a Hackage badge, e.g.: https://github.com/ndmitchell/shake.
And docs are shown very nicely on Hackage, e.g.: http://hackage.haskell.org/package/shake-0.15.5/docs/Development-Shake.html

Ah, okay then.