New Android embedding does not support dart-flags extra

This is used to provide additional flags to the dart vm, subject to a whitelist in switches.cc
https://github.com/flutter/engine/blob/6f40beed77ef5d80c77a75913f506aa3c141b3e7/shell/platform/android/io/flutter/app/FlutterActivityDelegate.java#L324

cc @matthew-carroll

@jonahwilliams are you using a version of the engine that includes this commit?
https://github.com/flutter/engine/blame/master/shell/platform/android/io/flutter/embedding/engine/FlutterEngine.java#L179

Yes - for more context, the tool expects to be able to pass flags via an intent:
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/android/android_device.dart#L590

Hm, I'm not sure why that's not working. Here is the execution order that should be taking place:
FlutterActivity instructs its delegate to initialize in onCreate():
https://github.com/flutter/engine/blob/master/shell/platform/android/io/flutter/embedding/android/FlutterActivity.java#L418
The delegate instructs FlutterActivity to produce VM args:
https://github.com/flutter/engine/blob/master/shell/platform/android/io/flutter/embedding/android/FlutterActivityAndFragmentDelegate.java#L227
The FlutterActivity creates the arg list from its Intent:
https://github.com/flutter/engine/blob/master/shell/platform/android/io/flutter/embedding/android/FlutterActivity.java#L668
https://github.com/flutter/engine/blob/master/shell/platform/android/io/flutter/embedding/engine/FlutterShellArgs.java#L66
The delegate creates a FlutterEngine, passing those args, which are sent into ensureInitializationComplete():
https://github.com/flutter/engine/blob/master/shell/platform/android/io/flutter/embedding/engine/FlutterEngine.java#L184
Is there anything about the particular place that you're trying to use these flags that would interfere with that execution order?

There is no parsing of dart-flags from the intent though

Ah, I see, there is explicitly an argument called "dart-flags" which may contain an arbitrary number of additional flags.  It looks like that was added only 5 months ago, which was long after I replicated that logic in the new embedding.
FYI @bkonyi if you happen make any adjustments to the arguments coming into Flutter on Android, it would be great if you could make the same adjustments to the new embedding, or you're welcome to file a ticket against me and I can take care of it.
I'll go ahead and get this behavior implemented in the new embedding.

Thanks very much @matthew-carroll !

Ah, I see, there is explicitly an argument called "dart-flags" which may contain an arbitrary number of additional flags. It looks like that was added only 5 months ago, which was long after I replicated that logic in the new embedding.
FYI @bkonyi if you happen make any adjustments to the arguments coming into Flutter on Android, it would be great if you could make the same adjustments to the new embedding, or you're welcome to file a ticket against me and I can take care of it.
I'll go ahead and get this behavior implemented in the new embedding.

Sorry about that! I doubt that this code will be touched any time soon since the whitelist is in C++, but I'll be sure to let you know or make the equivalent changes myself.

This is done now right?

Yep, done. Closing.


Broadcasting property

Is it possible to implement a broadcasting property for the characteristics?

Hi @Mesaman,
This is not supported at this moment. However, you can use bleno.startAdvertisingWithEIRData(...) to specify the advertisement data that contained service data. node-eddystone-beacon has a good example of this.
https://github.com/sandeepmistry/bleno#start-advertising-with-eir-data-linux-only


RS256 key verification on firebase functions

I'm trying to use jwt key verification on a firebase cloud function, asymmetric signing is the only way I see to secure one of those apps.
So, I created the function and used jwt.verify as stated in the commonsJS instructions, and my key wouldn't verify, the error from jsonwebtoken is empty.
{
    "PUBLIC_KEY": "\n-----BEGIN RSA PUBLIC KEY-----\nMIIBCgKCAQEAp6aWR0qcqFeCmK/lxgYfrTSXx7/WTpBqSp18TbLcjr1QV4kyxswG\n+QzDl7EITokSd3yvI6eMbv6NxkRqumG7M50mNKm6DljRMh26/R4z17r4IFgNZr60\nFQ48cHWE7xl5O4INSyjHGIK6vHepDsbHeGJNYAbeNTB0F9CHl6TKYeZNAnYVykPd\nC3/Wp5TzLNP6KgDvGMlyLHh1ZyF0Xau+bupGvvMfnL9hw04/Y7eCr8knVFOVfC5e\nlNt6NMxKtjutm/EqLW49tZRvVG5IvNhFmr2G4QzmRT6WmaWgq19L9eZ4S4qoDsYe\nE7SE3LWqBPR/O3L8GCw9wJEeG+A75k/QqwIDAQAB\n-----END RSA PUBLIC KEY-----\n",
    "err": {},
    "message": "invalid token",
    "token": "eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.eyJlaWQiOiJBTkFETUlOU0VJRCIsImlzX2FkbWluIjp0cnVlLCJ1c2VybmFtZSI6ImFkbWluIiwicm9sZXMiOiJhZG1pbiJ9.P_VOXMgFz3N38qEx7W_8m4fgmj0pQsy1pICMnDsmr9waXhsI12bQqEuJlrSMx3DEj5OLXpxzrOd2HVAPkb0FbZB-MaWOmX_GTAMK-aVfo41skGeCZ3ACOX_S_gmHc6obcVljKtlQsgc5z1JyOvHc7aMPAG4O23Dkbm5sfwrBaiOmhxPFCEkNL0AEWbo-KG_UU_v3iVM0j68NVMvmtTyrfefw0dOHCbkzZrOTet6hGT8Rlg3LFHgE07zCnm1KOTqac4Co3Qcy8LefKcNPHO4IrASxDeJqKbTumGtFsbpBZjK7FnyR7OvPJL75mBrDMi1na8L1LeAlYomcgUP9qka0wg"
}

here's the code https://github.com/tech-teach/noob-holdings/blob/master/functions/index.js, and above there's an example of token, if you happen to need to sign more, here's the sample private key I'm using https://github.com/tech-teach/jwt-authentication/blob/master/auth/rsa-key.
You can post to the function at: https://us-central1-noob-holdings.cloudfunctions.net/addMessage
Any help debugging this one would be greatly appreciated.

I have just tested with your public/private key and that token, I didn't get any error, I've modified the token to make it return error and I get:
{ [JsonWebTokenError: invalid signature] name: 'JsonWebTokenError', message: 'invalid signature' }
Did the code work well locally for you? What version of jsonwebtoken are you using?

Ok, here's my version deal, I have the token working on a react app with the next entry in package.json:
  "dependencies": {
    "jsonwebtoken": "^8.0.1",

and resolves to (by looking to my yarn.lock):
<EMAIL_ADDRESS>  version "8.1.0"

In my firebase functions project, I have the same entry in package.json, however, I do have 2 entries in yarn.lock, one of them referencing an older version of jsonwebtoken:
<EMAIL_ADDRESS><EMAIL_ADDRESS>  version "7.1.9"

In the react app, I was able to run with:
const TOKEN = `
-----BEGIN RSA PUBLIC KEY-----
...
-----END RSA PUBLIC KEY-----
`;

in the one that resolved to 7, I built a little example and realised that the pem key could not be read, hence the silent error, and it was solved by trimming the \n at the beginning and end of the public key.
const TOKEN = `
-----BEGIN RSA PUBLIC KEY-----
...
-----END RSA PUBLIC KEY-----
`.trim();

that did the trick, it maybe worthwhile to back-port that trim to earlier versions of the project. Here's the diff that made it work for me https://github.com/tech-teach/noob-holdings/commit/d8962ed5d0112ee3e3f9e801524bdc1810908da9


Minor changes for clarity

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Deploy preview for modest-edison-79d82e ready!
Built with commit 843fd238ce44b50fc2761f3ca2e84448f55dba4d
https://deploy-preview-7144--modest-edison-79d82e.netlify.com


set default privacy to link

This breaks the unit test /spec/connectors/importer_spec.rb:205.  If a user imports a table as private through the importer it will set it to "with link" instead of private.  Are we expecting users to re-mark datasets as private if they need to instead of the other way around?


CPU consumption

Image: aws-network-policy-agent:v1.0.1
Kubernetes: 1.27.4
AWS instance type: t3.small (credit specification: standard).
When I set "enable-network-policy" to "true", the "CPU credit usage" doubled  and the "CPU credit balance" ends.
After that we have a CPU processor load ~100%.
Is this feature so CPU-consumption?
What can be done to reduce CPU consumption and not change the instance type or credit specification?

This is similar to #47
With enabling network policy, we initialize ring buffer and have a epoll wait to capture policy decision logs. We are looking into making it configurable maybe opt-in.

Closing now that VPC CNI v1.15.1 is released on GitHub: https://github.com/aws/amazon-vpc-cni-k8s/releases/tag/v1.15.1. This release contains the Network Policy agent v1.0.4 image tag, which allows for disabling policy event logs


python3Packages.testrail-api: fix broken build

Description of changes
i updated my nixpkgs and noticed this package is broken ... looks like there were some impacting changes at some point... after browsing upstream it looks like this PR should do it :+1:

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg eval


Draft PPP

Codecov Report

Merging #220 (ea7408e) into master (bc548f0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #220   +/-   ##
=========================================
  Coverage     27.49%   27.49%
  Complexity      409      409
=========================================
  Files           148      148
  Lines          3346     3346
  Branches        397      397
=========================================
  Hits            920      920
  Misses         2361     2361
  Partials         65       65

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc548f0...ea7408e. Read the comment docs.


Please add support for sway

Here's an example on how it works in bash script: https://gitlab.com/msrd0/dotfiles/-/blob/master/HOME/.config/sway/catbg.sh#L13

pull request are welcome

Sway is already supported by using the wallpaper feature flag. But it does currently not support setting a different wallpaper per screen.
Do you want to work on this?


Version number

Can we add a --version option to policyengine-taxsim? Also, we should be able to report the version for policyengine-us. Currently I have the web page report the install date at txmlinux.nber.org, but this isn't satisfactory for the longer run with outside users.

We'd log the version here (currently not updating):
https://github.com/PolicyEngine/policyengine-taxsim/blob/a4485a33710c61035afa4da641380d8238cb6454/pyproject.toml#L7
We can extract the policyengine-us version number too.
In other repos we automate the version bump, but we haven't yet gotten it working with the upgrade from setup.py to pyproject.toml.

I have updated http://txmlinux.nber.org to fetch the currently installed version number for the emulator and echo it to the results page.  With no similar number for policyengine-us, I just echo the last line of changelog.yaml. This seems fine with me so I wouldn't put the effort in to a manual bump.


Kubectl: rethink handling (and surfacing) of errors in the resource visitor loop

We probably need to queue an issue to look at side loaded errors in visitor and see if there's an alternative to the way we have to aggressively continue loops even when errors happen (because someone might want to continueOnError). It might be a change to visitor to allow it to accept an error, like Go's path walker.

From @smarterclayton https://github.com/GoogleCloudPlatform/kubernetes/pull/9357#issuecomment-109600305

@mikedanese Yes, we should continue loops even when errors happen. We could collect errors, put them into errs.ErrorList{}, then aggregate errors, finally show  a user friendly aggregated errors . I wonder if any other has already started working on this? If not, I would like to start on it then!

@feihujiang No one is currently working on this.

@mikedanese OK, I 'm currently working on this now.

Sorry for the delay, I'll finish it as quickly as I can

@mikedanese #9707 just solves the DirectoryVisitor's continue loops. Now I'm thinking  a change to visitor to allow it to accept an error, like Go's path walker.


Spark - Proper read

Implement proper read for sparkcore where quasar will not read all content with single read, but do it in batches

@jedesah please note also that this PR downgrades version of jackson to 2.4.4 as discussed previously on slack backend channel

Wow! I never seen that error before. wierd...

Current coverage is 66.07% (diff: 0.00%)

Merging #1444 into master will decrease coverage by 1.79%

@@             master      #1444   diff @@
==========================================
  Files           287        293     +6
  Lines         13488      13779   +291
  Methods       13119      13397   +278
  Messages          0          0
  Branches        212        213     +1
==========================================
- Hits           9154       9104    -50
- Misses         4334       4675   +341
  Partials          0          0

Powered by Codecov. Last update 5ad981a...66ef2da


Propagate TYPE_USE annotations

@SentryMan I'm not sure if you stumbled on my rant with the original record builder author on the need to propagate TYPE_USE annotations but I recommend you do that.
The basic problem is you cannot not just toString on the TypeMirror to get the correct representation. I believe @bowbahdoe (who has a similar library) filed a JDK bug on it.
Luckily I have a solution you can just copy from JStachio: https://github.com/jstachio/jstachio/blob/main/compiler/apt/src/main/java/io/jstach/apt/internal/util/ToStringTypeVisitor.java
The top static method is what you want to call.
So just for clarity:
@GenerateBuilder // or whatever the annotation is
record Blah(@Nullable String foo){}

Let us assume we are using JSpecify.
When you produce all the setters for the builder it should be:
public Builder foo(java.lang. @org.jspecify.annotations.Nullable String) {
...
}

If you call ToStringTypeVistor.toCodeSafeString(someTypeMirrorFromRecordAccessor)
BTW the above is one reason I do not manage imports on code generation (e.g. FQN everything). It is nontrivial to recreate the correct TYPE_USE annotation declaration and is probably why even the JDK has a bug.
You will have to modify my code heavily if you plan on managing imports.
If I have time later this week I can put in a PR for you.
On another tangent I think I remember you or @rbygrave using Eclipse or perhaps the compiler. I have a great deal of the annotation processing API as well as the JDK API nullness annotated aka Eclipse External Annotations aka EEA. You just copy this directory: https://github.com/jstachio/jstachio/tree/main/etc/eea
Then just copy the checkerframework, errorprone (optional), and eclipse profiles from this pom:
https://github.com/jstachio/jstachio/blob/main/api/jstachio/pom.xml
You will probably have to twiddle some config but that will get you headless null analysis and the Eclipse version is mostly equivalent to Checker (IMO better than Checker because Checker just assumes the entire JDK is nonnull where as eclipse is the opposite).

Hey that's pretty good, thanks.

That toString should be fixed as of 20

https://bugs.openjdk.org/browse/JDK-8281238?jql=text ~ "type use toString"

The basic problem is you cannot not just toString on the TypeMirror to get the correct representation. I believe @bowbahdoe (who has a similar library) filed a JDK bug on it.

oh yeah this thing, I usually use regex to deal with it to extract

so in the case of
@RecordBuilder
public record TypeUse(@NotEmpty Map<@Nullable String, @NotBlank  Map<@NotBlank String, @Nullable List<@Nullable String>> map) {}

does it matter if the nested map has the annotations copied? or do only the top level (@Nullable String, @NotBlank  Map) ones need to be copied to the setter?

does it matter if the nested map has the annotations copied?

Yes it matters. Its like removing the generics if you do... speaking of which the regex to remove annotations there is a way to erase them without doing that as well.
After labor day I can look into contributing to help.

this visitor thing is actually legendary, I didn't know you could do this. You really learn something new every day.

managed to get the annotation copying close to how I wanted, but apparently this signature is invalid:
   TypeUseBuilder  map(
      @NotEmpty @NotBlank
          Map<
                  @NotBlank String,
                  @NotEmpty List<@NotBlank Raven.Weapon>>// <-- this notblank is invalid
              map) {...

So I'm forced to use fqn no matter what after a certain point.

That visitor actually was not my finest moment. I embarrassingly reverted to using System.out debugging when making it because the recursive nature was confusing with a real debugger. I don't normally do that and meant to take those out.

in any case, are the setter changes to your liking?

I think so. I will pull/fork later and try.


Add missing file: hess_camgeom.fits.gz

@kosack – Tests are failing at the moment:
https://gist.github.com/cdeil/6480edb512002e449317#file-gistfile1-txt-L579
Can you please add the missing file to the ctapipe-extra repo?

I can't seem to push to the ctapipe-extra repo. I added several files to my own copy, but doing a git push fails from within the module. It seems to not know where the remote is, so perhaps the submodule clone was not done properly?

I'm not terribly familiar with git submodules. You could try doing a fresh git clone --recursive of ctapipe to make sure it's OK and then try adding the file again. After a quick look at here and here I think though that it might be easier to just to a separate clone of ctapipe-extra and add the files there, then only move the submodule pointer. That's how I've done it so far. I'll try directly adding things in a test repo with a submodule tomorrow.

Ok, checking ctapipe-extra out separately worked. The files should be there now

@kosack – You still have to update the git submodule pointer in the ctapipe repo.
It's still pointing to https://github.com/cta-observatory/ctapipe-extra/commit/e0c632b7a1b17ffa02872be24af3c98108f13382 and now should point to https://github.com/cta-observatory/ctapipe-extra/commit/2b69c31c9a98ca92df30b36ceaed24ce1577e0dc

I'm not really familiar with how submodules work. How do I update the pointer?

doing git submodule ctapipe-extra pull origin master seems to have worked.
I guess we have to do that each time it is updated, and the check it back in?

First look up the SHA of the correct ctapipe-extra version. Usually it will be the last commit (e.g. here: https://github.com/cta-observatory/ctapipe-extra/commits/master), at the moment it's https://github.com/cta-observatory/ctapipe-extra/commit/fda08f3ed016469bedb599cd498bf475b9f05365)
These commands should work:
cd ctapipe/ctapipe-extra # go into the git submodule
git pull
git checkout fda08f
cd .. # go into the parent git module
git add ctapipe-extra
git commit -m 'Update ctapipe-extra submodule pointer'
git push origin master # let other's know

The file is there now and the tests are passing on travis-ci.
https://github.com/cta-observatory/ctapipe-extra/tree/master/datasets
Closing this issue.


Loopback wave

Hi sorry not really an issue but was searching for a way to get loopback wave script for comfyui. I was pointed in this direction, just wanted to ask can I achieve similar batch image outputs like loopback waves scrips from auto1111 with this comfyui extension. I'm sure people will make tutorials soon all very nex and exciting SDXL

This is planned however my hands are tied with AITemplate and it's current issues. I'll make sure this gets on the TODO

Thankyou, I'm pretty sure I'm not the only person who would like this, so to answer my question we can't use the current code to achieve loopback wave type frame animations in comfyui?

The wave interpolation effect between two prompts generated by Loopback is very impressive. I have not found a similar node in ComfyUI so far. Have you found a similar solution?  I'll include some custom workflows demonstrating the impact nodes method (send and recieve latents/images nodes). This will tie in with #9 to get hands-on with examples.


GEOMESA-2113 Upgrade Arrow to 0.10

Signed-off-by: Emilio Lahr-Vivaz<EMAIL_ADDRESS>

replaces https://github.com/locationtech/geomesa/pull/1940

Shoudl we add the 2.1.0 milestone for this?

I added to the 2.1.0 milestone - looks like the current RC for arrow 0.10 is likely to be approved and released today or tomorrow.

this is ready to merge


Only allow using Shoot addons for evaluation clusters beginning with v1.22

How to categorize this issue?

/area usability
/kind enhancement
/priority 3
What would you like to be added:
Only allow to enable addons in .spec.addons in Shoot resources if the .spec.purpose=evaluation if the .spec.kubernetes.version is greater than v1.22.0.
Why is this needed:
The addons are just provided by Gardener to enable "hello-world" use-cases and are not recommended for production usage.  They are not regularly maintained, updated without end-users' control, and don't allow for a lot of customization/configuration.
Hence, let's prohibit using them if the shoot purpose is not evaluation to make clear that end-users who want to use their clusters for production need to deploy their own addons.

if the .spec.kubernetes.version is greater than v1.22.0.

Why with this limitation?

For backwards-compatibility

What about if a 1.21 cluster with purpose production is upgraded to 1.22 and the addons are enabled?
If it is initiated by the shoot owner, ok - he will see the error and find out that cannot upgrade.
But such validation will brake the forceful minor version upgrade in GCM.

Yes, it will be denied by the API and it won't be possible to upgrade.

What do you think to extend the maintenance controller to also disable the addons when it is upgrading non evaluation shoot to k8s version >=1.21? Or to change its purpose to evaluation when at least one addon is still enabled?
The fact that forceful minor upgrade is happening makes me think that the shoot owner does not care much about the cluster and the GCM is allowed to apply such changes.

I would like to avoid any additional complexity. We haven't done such things in the past either (e.g., when we disallowed basic auth for newer Kubernetes versions). I would rather want to let the upgrade fail explicitly instead of silently removing some addons (which potentially break the end-users' workload).

I would rather want to let the upgrade fail explicitly

Agree, but what does this mean for GCM? Will it set the shoot to failed state? If not, then it will be silently failing.

Probably, but this is another problem out of scope of this issue. You might want to open a separate issue to track this.

In this case probably the guestbook tests (and others?) need to be amended by deploying their own ingress controller.
Today they rely on one being present and only create ingress resources.

@dguendisch In which case? We could also allow to enable the addon for both evaluation and testing purposes, would this be good enough for the integration tests?

We intentionally don't set the testing purpose (so that we do have logging&monitoring to test it :) ).
I rechecked, our shoots do have the evaluation purpose, I couldn't find where we set it and @schrodit suggested that it's the default. If this is true, we are good to go and the tests will still find nginx ingress.

/assign @stoyanr


on opening endpoint url its showing access denied. also there is node version compatibility error appearing. once i install node v16.3.0 it gets resolved but comes with new error

@rnqayush Could you clarify what error are you seeing in Cloud 9 with Node 16?
Also have you tried to run this in your local machine and if so do you have the same issue?

Thankyou for response, after installing node v16.3.0 I got the error which is present in last image attached to this issue. Also I have windows OS  so I face error with it hence didnt tried out in local machine. Earlier I tried chime-sdk-js there I didn't found any issue on deploying with cloud9 but this classroom deployment I am facing issues.

Kindly help me with this issue. I followed same way defined in chime-sdk-classroom doc

Hi @rnqayush sorry for late reply.
For endpoint URL showing access denied issue:
This URL is used to download the .zip files from S3 bucket. There is a new option called "Block Public Access settings for this account" in S3 bucket, and by default it's enabled. This is the reason why you met the issue. There're two solutions:

Disable this option
Visit the corresponding S3 bucket and download the file there.

Closing it, feel free to reopen it if you still have problems


SSL certificate creation times out on deploy

I created a Serverless project using this framework, but for some reason the CF resource creation for creating the SSL cert times out after ~500-600 seconds. Is the cert supposed to take this long to create?

@jens-johnson have you updated your DNS settings for your external domain? If so, have you checked that the record expiry is set to a decent (low) timeframe?
The Lambda function that will generate the certificate has a timeout of 900 seconds, meaning that if it can't resolve to NS to the given nameservers of the HostedZone, it'll fail...

@tobilg Thank you for reaching back out; I'm a bit unfamiliar with the DNS process so I might be off here. I have a domain registered through Google Domains, but haven't pointed it any custom DNS servers as I thought that I was supposed to receive these from the output of the CF stack creation. Is there additional configuration on my domain provider through Google needed prior to deploying the stack?

The process is described here: https://github.com/tobilg/serverless-aws-static-websites#manual-update-of-dns-records-on-first-deploy
The certificate is validated via DNS entries.

This ended up fixing it, thank you so much! Not sure how I glanced over that part; I did have to bump up my session token expiry a bit to avoid timeout, but I was eventually able to deploy in ~1,200 sec all-in-all.


Add onLongPress property to DataCell

I'm using the DataTable widget which works like a charm.
Problem
Unfortunately, the DataCells (building blocks for the DataRows) lack a onLongPress property (which would be quite handy in many cases for showing further options).
Proposal
Add a onLongPress (and maybe even onDoubleTap) property to DataCell.

cc @dkwingsmt

This should be closed now.

Close with https://github.com/flutter/flutter/pull/75393


OnSignedIn event regardless of the authentication used

Is there a way to register a delegate to be called on successful login regardless of the authentication method used (Identity, AzureAD, etc), and not on every request, similar to this one?
Right now I'm using ClaimsTransformationMiddleware, but it's called on every request.
public void ConfigureServices(IServiceCollection services)
{
    ...
    services.AddSingleton<IClaimsTransformation, EveryoneGroupTransformer>();
    ...
}
...

public class EveryoneGroupTransformer : IClaimsTransformation
{
    public Task<ClaimsPrincipal> TransformAsync(ClaimsPrincipal principal)
    {
        Console.WriteLine(principal.Identity.Name);
        return Task.FromResult(principal);
    }
}

No, there's no way to have "global" events.


Fix duplicate notifications

There is a bug in current TT that causes notifications to be duplicated.
Turns out it is caused by JS Date objects, which we serialize as strings and then fail to recognize as equal.
As it happens, RSS feeds all include a Date parameter, which is why I noticed this problem.
The first commit is a test I added trying to debug, the second is the actual fix, and the third is more tests.

Pull Request Test Coverage Report for Build 378

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 81.985%

Totals

Change from base Build 375:
0.1%

Covered Lines:
5451

Relevant Lines:
6465

💛  - Coveralls


Added zero link unfurling app installation card for nodejs sample

Executed build pipeline: https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/3604664890
Result:


Unit of use and availability profiles should not be 'kW'

As these are fractions of the storage volume of the tank or battery, I believe these should not have a unit at all. What do you think, @ChaelKruip ?

As these are fractions of the storage volume of the tank or battery, I believe these should not have a unit at all.

True!

Fixed with: 754137b


[BUG] "django.db.utils.OperationalError: error in index cms_cmsplugin_level_0ccc318d after drop column: no such column: level"

Description
I started a new project, following the virtualenv instructions, and sqlite. When trying to run migrations, it fails when trying to drop what appear to be old MPTT fields (level, lft, rght, etc), which don't appear to exist:
Applying cms.0006_auto_20140924_1110...Traceback (most recent call last):
  File "<redacted>/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
  File "<redacted>/site-packages/django/db/backends/sqlite3/base.py", line 357, in execute
    return Database.Cursor.execute(self, query, params)
sqlite3.OperationalError: error in index cms_cmsplugin_level_0ccc318d after drop column: no such column: level

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/jamalex/fle/learningequality.org-v3/le_cms/manage.py", line 22, in <module>
    main()
  File "/home/jamalex/fle/learningequality.org-v3/le_cms/manage.py", line 18, in main
    execute_from_command_line(sys.argv)
  File "<redacted>/site-packages/django/core/management/__init__.py", line 446, in execute_from_command_line
    utility.execute()
  File "<redacted>/site-packages/django/core/management/__init__.py", line 440, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "<redacted>/site-packages/django/core/management/base.py", line 402, in run_from_argv
    self.execute(*args, **cmd_options)
  File "<redacted>/site-packages/django/core/management/base.py", line 448, in execute
    output = self.handle(*args, **options)
  File "<redacted>/site-packages/django/core/management/base.py", line 96, in wrapped
    res = handle_func(*args, **kwargs)
  File "<redacted>/site-packages/django/core/management/commands/migrate.py", line 349, in handle
    post_migrate_state = executor.migrate(
  File "<redacted>/site-packages/django/db/migrations/executor.py", line 135, in migrate
    state = self._migrate_all_forwards(
  File "<redacted>/site-packages/django/db/migrations/executor.py", line 167, in _migrate_all_forwards
    state = self.apply_migration(
  File "<redacted>/site-packages/django/db/migrations/executor.py", line 252, in apply_migration
    state = migration.apply(state, schema_editor)
  File "<redacted>/site-packages/django/db/migrations/migration.py", line 130, in apply
    operation.database_forwards(
  File "<redacted>/site-packages/django/db/migrations/operations/fields.py", line 170, in database_forwards
    schema_editor.remove_field(
  File "<redacted>/site-packages/django/db/backends/sqlite3/schema.py", line 417, in remove_field
    super().remove_field(model, field)
  File "<redacted>/site-packages/django/db/backends/base/schema.py", line 720, in remove_field
    self.execute(sql)
  File "<redacted>/site-packages/django/db/backends/base/schema.py", line 199, in execute
    cursor.execute(sql, params)
  File "<redacted>/site-packages/django/db/backends/utils.py", line 103, in execute
    return super().execute(sql, params)
  File "<redacted>/site-packages/django/db/backends/utils.py", line 67, in execute
    return self._execute_with_wrappers(
  File "<redacted>/site-packages/django/db/backends/utils.py", line 80, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "<redacted>/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
  File "<redacted>/site-packages/django/db/utils.py", line 91, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "<redacted>/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
  File "<redacted>/site-packages/django/db/backends/sqlite3/base.py", line 357, in execute
    return Database.Cursor.execute(self, query, params)
django.db.utils.OperationalError: error in index cms_cmsplugin_level_0ccc318d after drop column: no such column: level

Steps to reproduce
Followed the instructions at https://docs.django-cms.org/en/latest/how_to/install.html#installation
with settings:
"""
Django settings for le_cms project.

Generated by 'django-admin startproject' using Django 4.1.

For more information on this file, see
https://docs.djangoproject.com/en/4.1/topics/settings/

For the full list of settings and their values, see
https://docs.djangoproject.com/en/4.1/ref/settings/
"""

from pathlib import Path

# Build paths inside the project like this: BASE_DIR / 'subdir'.
BASE_DIR = Path(__file__).resolve().parent.parent

# Quick-start development settings - unsuitable for production
# See https://docs.djangoproject.com/en/4.1/howto/deployment/checklist/

# SECURITY WARNING: keep the secret key used in production secret!
SECRET_KEY = "<redacted>"

# SECURITY WARNING: don't run with debug turned on in production!
DEBUG = True

ALLOWED_HOSTS = []

SITE_ID = 1

# Application definition

INSTALLED_APPS = [
    "djangocms_admin_style",
    "django.contrib.admin",
    "django.contrib.auth",
    "django.contrib.contenttypes",
    "django.contrib.sessions",
    "django.contrib.messages",
    "django.contrib.staticfiles",
    "django.contrib.sites",
    "cms",
    "menus",
    "treebeard",
]

MIDDLEWARE = [
    "django.middleware.security.SecurityMiddleware",
    "django.contrib.sessions.middleware.SessionMiddleware",
    "django.middleware.common.CommonMiddleware",
    "django.middleware.csrf.CsrfViewMiddleware",
    "django.contrib.auth.middleware.AuthenticationMiddleware",
    "django.contrib.messages.middleware.MessageMiddleware",
    "django.middleware.clickjacking.XFrameOptionsMiddleware",
]

ROOT_URLCONF = "le_cms.urls"

TEMPLATES = [
    {
        "BACKEND": "django.template.backends.django.DjangoTemplates",
        "DIRS": [],
        "APP_DIRS": True,
        "OPTIONS": {
            "context_processors": [
                "django.template.context_processors.debug",
                "django.template.context_processors.request",
                "django.contrib.auth.context_processors.auth",
                "django.contrib.messages.context_processors.messages",
            ],
        },
    },
]

WSGI_APPLICATION = "le_cms.wsgi.application"

# Database
# https://docs.djangoproject.com/en/4.1/ref/settings/#databases

DATABASES = {
    "default": {
        "ENGINE": "django.db.backends.sqlite3",
        "NAME": BASE_DIR / "db.sqlite3",
    }
}

# Password validation
# https://docs.djangoproject.com/en/4.1/ref/settings/#auth-password-validators

AUTH_PASSWORD_VALIDATORS = [
    {
        "NAME": "django.contrib.auth.password_validation.UserAttributeSimilarityValidator",
    },
    {
        "NAME": "django.contrib.auth.password_validation.MinimumLengthValidator",
    },
    {
        "NAME": "django.contrib.auth.password_validation.CommonPasswordValidator",
    },
    {
        "NAME": "django.contrib.auth.password_validation.NumericPasswordValidator",
    },
]

# Internationalization
# https://docs.djangoproject.com/en/4.1/topics/i18n/

LANGUAGES = [
    ("en", "English"),
    ("es", "Español"),
]

LANGUAGE_CODE = "en"

TIME_ZONE = "UTC"

USE_I18N = True

USE_TZ = True

# Static files (CSS, JavaScript, Images)
# https://docs.djangoproject.com/en/4.1/howto/static-files/

STATIC_URL = "static/"

# Default primary key field type
# https://docs.djangoproject.com/en/4.1/ref/settings/#default-auto-field

DEFAULT_AUTO_FIELD = "django.db.models.BigAutoField"

Expected behaviour
Successful migration run.
Actual behaviour
Traceback shown above is displayed, and migrations are interrupted. Deleting the database and trying to migrate again gives the same result.
Additional information (CMS/Python/Django versions)
$ python -V
Python 3.9.7

$ pip freeze
asgiref==3.5.2
Django==4.1
django-classy-tags==3.0.1
django-cms==3.11.0
django-formtools==2.3
django-sekizai==4.0.0
django-treebeard==4.5.1
djangocms-admin-style==3.2.0

Do you want to help fix this issue?

[ ] Yes, I want to help fix this issue and I will join #workgroup-pr-review on Slack to confirm with the community that a PR is welcome.
[x] No, I only want to report the issue.

I note that commenting out these lines in the migration allow it to complete, but I'm not sure whether that would cause other issues down the line:
from django.db import models, migrations

class Migration(migrations.Migration):

    dependencies = [
        ('cms', '0005_auto_20140924_1039'),
    ]

    operations = [
        migrations.AlterModelOptions(
            name='page',
            options={'ordering': ('path',), 'verbose_name': 'page', 'verbose_name_plural': 'pages', 'permissions': (('view_page', 'Can view page'), ('publish_page', 'Can publish page'), ('edit_static_placeholder', 'Can edit static placeholders'))},
        ),
        # migrations.RemoveField(
        #     model_name='cmsplugin',
        #     name='level',
        # ),
        # migrations.RemoveField(
        #     model_name='cmsplugin',
        #     name='lft',
        # ),
        # migrations.RemoveField(
        #     model_name='cmsplugin',
        #     name='rght',
        # ),
        # migrations.RemoveField(
        #     model_name='cmsplugin',
        #     name='tree_id',
        # ),
        # migrations.RemoveField(
        #     model_name='page',
        #     name='level',
        # ),
        # migrations.RemoveField(
        #     model_name='page',
        #     name='lft',
        # ),
        # migrations.RemoveField(
        #     model_name='page',
        #     name='rght',
        # ),
        # migrations.RemoveField(
        #     model_name='page',
        #     name='tree_id',
        # ),
        migrations.AlterField(
            model_name='cmsplugin',
            name='depth',
            field=models.PositiveIntegerField(editable=False),
        ),
        migrations.AlterField(
            model_name='cmsplugin',
            name='numchild',
            field=models.PositiveIntegerField(default=0, editable=False),
        ),
        migrations.AlterField(
            model_name='cmsplugin',
            name='path',
            field=models.CharField(unique=True, max_length=255, editable=False),
        ),
    ]

Sorry, I missed this line in one of the callouts on the instructions page:

For the cms to work correctly, you will need django version 3.2. Work with newer versions can be unstable.

I downgraded to Django 3.2 and it no longer gave this error with the original migration. Sorry!

@jamalex I note the settings generated using django 4.1. I think django-cms 3.11 supports 4.0, but I don't think we support 4.1 yet.


Biosample UI

This PR has the new UI for the biosample (display only) and the config files for the docker image and the GCP kubernetes deployment (through kubectl) and not automatized yet.

Hi @ielis let me know when you have time to review this PR so I can merge it into the dev branch. thx


nerdctl: update to v0.22.1 ; templates: update archlinux, alpine-lima

https://github.com/containerd/nerdctl/releases/tag/v0.22.1

Failing on Fedora
[suda@lima-fedora ~]$ nerdctl run -it --rm alpine
FATA[0000] failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: can't get final child's PID from pipe: EOF: unknown

It is not obvious why the windows cross unit tests are failing
=== RUN   TestDefaultPubKeys
    sshutil_test.go:12: found 0 public keys
--- PASS: TestDefaultPubKeys (0.02s)
=== RUN   TestParseOpenSSHVersion
--- PASS: TestParseOpenSSHVersion (0.00s)
=== RUN   Test_detectValidPublicKey
--- PASS: Test_detectValidPublicKey (0.00s)
PASS
FAIL	github.com/lima-vm/lima/pkg/sshutil	0.990s

pass + pass + pass = fail ?

@afbjorklund Might be an issue of Wine 🍷 , idk

@afbjorklund Might be an issue of Wine wine_glass , idk

There were some complaints about not installing wine32 (only wine64), but I don't think we have any 32-bit binaries ?
It worked OK, for what is worth. But it did find some keys in C:\users\anders\.lima\_config\user.pub - maybe that was it


pyprql no longer runs in Google Colab

Google Colab has changed something and installing pyprql now causes the runtime to crash and it's unable to reconnect.
I think it's actually because of the ipython dependency. Do we need that for anything actually or is that just a convenience? If it's the latter then could we remove it please?
I thought it might be required by jupysql but that does not appear to be the case and the following notebook runs fine on Colab: https://colab.research.google.com/drive/1eOA2FYHqEfZWLYssbUxdIpSL3PFxWVjk?usp=sharing#scrollTo=siVry2OI7HwF
@eitsupi WDYT?

Do you have a repro? I get this warning but it does seem to run (lightly edited your link with a snippet from the readme):

I think it's actually because of the ipython dependency. Do we need that for anything actually or is that just a convenience? If it's the latter then could we remove it please?

See #374.
I agree with making it an optional dependency.

I think this should be fixed by https://github.com/PRQL/pyprql/pull/383

Indeed, !pip install git+https://github.com/PRQL/pyprql.git now works
Thanks for the issue + the repro @snth !


Add AWS Sigv4 support to scraper and http_sd

Proposal
Currently we've supported AWS Signature v4 in remote write and alert manager. We would also like to support AWS Signature v4 in the scraper as well as HTTP service discovery. So that clients can directly use http_sd to discover and scrape sigv4 metrics endpoint.
This is actually a follow up issue for https://github.com/prometheus/prometheus/issues/3008. Previously we paused the discussion due to lacking of native sigv4 metrics endpoint offered by Amazon. Now EKS is planning to expose sigv4 metrics endpoints for customers to scrape metrics from their Kubernetes clusters. Thus, we would like to support sigv4 to both HTTP SD and Prometheus scraper.
What will be changed?
Sigv4 config will be added to http_config https://github.com/prometheus/common/blob/main/config/http_config.go, as well as scrape_config https://github.com/prometheus/prometheus/blob/main/config/config.go

@haoranleo do you plan to work in this yourself? I think this would be a very welcome feature, but @roidelapluie has more context for sure.

Hi @beorn7, yeah we can add the SigV4 support ourselves. Just wanted to seek opinions from upstream first and ensure there is no major concern of adding that support :D.
We are currently finalizing the discussion on exposing a native SigV4 enabled metrics endpoint, after it is finalized we can start working on the change.

We chose not to implement this because users who only require http_sd shouldn't have to build the entire AWS dependencies. I'm curious if there are enough use cases to justify this approach, or if there's a way to enable AWS SigV4 at compile time specifically for http_sd and Alertmanager.

With SigV4 supported by remote write, maybe we have already linked in most of the required dependencies?

I personally have projects that are using only the discovery.
But I am fine either way, if there is an easy way to only have sigv4 with opt-in, let's do this. otherwise, let's bake it in...

Inclusion/exclusion via build tags would be nice, I guess. (It could also be opt-out, so that users that care about binary size can exclude it, similar to what we do with SD mechanisms.)

We chose not to implement this because users who only require http_sd shouldn't have to build the entire AWS dependencies.

If SigV4 support is added in the http_sd, user can still choose opt out right? They can use other authentication methods same as today like basic_auth/oauth2/tls_config etc... Please correct me if I miss something

I think @roidelapluie is talking about having all the library dependencies linked into the binary, even for those users that don't need SigV4 support.

We chose not to implement this because users who only require http_sd shouldn't have to build the entire AWS dependencies. I'm curious if there are enough use cases to justify this approach, or if there's a way to enable AWS SigV4 at compile time specifically for http_sd and Alertmanager.

Just an FYI, unlike aws-sdk-go (Maintenance mode as of July 31, 2024. EOL as of July 30, 2025) aws-sdk-go-v2 has separate modules for base SDK that does not include any of the service APIs.
If we updated the AWS SDK, would that alleviate the concern about build inclusion for http_sd?


Supported module types

Description
I work at SAP providing support for SCP.
In many examples I see that they use approuter.nodejs module type (here for example).
I know this is vendor neutal, but checking the manifest.yml for the supported module types I see that nodejs is there, but nothing about approuter.
I though maybe it doesn't matter what you put in front, but it does, it won't accept invented.nodejs.
Is there a place where I can see what SCP CF accepts as module type?
Do you know where in SAP can I get this info?
Your environment

Cloud MTA Build Tool version 1.0.12
MultiApps CF CLI Plugin version - 2.3.1
which CF vendor is used - SAP CF

Thanks,
Pedro

Hi @kepair ,
You have reached MTA Deploy Service team. as you find out in our manifest.yml we have defined module-types for OSS project but in SAP SCP we have additional module-types which you can see at this page in MTA Module Types section. About approuter.nodejs module-type we don't have such type in Deploy Service, maybe this is module-type which is resolved by Cloud MTA Build Tool to another module-type. You can try to open github issue to MBT project
Best Regards,
Kristian


CI with Travis + AppVeyor + GitHub Actions (#84)

Fixing #84, here is a pretty complete CI config for Windows / Linux / macOS with Visual Studio / Xcode / gcc / clang in most versions, feel free to comment or remove any system in the configs that you are not interested in.
In every configurations the main steps are:

Install build tools (cmake, ninja, ccache, gcc, clang, ...) depending on the config
Install SFML dependencies (Linux only, SFML repository embed all dependencies for Windows and macOS)
Download, configure, build, install SFML
Download Dear ImGui
Configure imgui-sfml
Build imgui-sfml

Except for Visual Studio on AppVeyor, every build uses ccache and a cache system depending on the provider to keep the cache between builds, it is especially usefull for SFML as most of the source files doesn't change most of the time.
Yeah I wanted the Github Actions build config to work on Windows, Linux and macOS at the same time so I made the scripts in cmake to havoid aving to do it in bash and then again in Powershell.

This is pretty incredible, thank you. I'll take a deeper look into it soon
Did you use any "template" configuration for this which I can diff with so that I can only check the specifics?

Not really, I took the config of my dynamic_bitset which I made through a lot of experimentations, adapted it for imgui-sfml and added "older" C++11 compliant compiler versions as my original config was for C++17. I made a lot of improvements to the GitHub Actions config and added the cache system to the Travis config, I think I will also implement them in my dynamic_bitset configs.
If I remember well when I made the original config I found a lot of good ideas for the Github Actions config in this article: https://cristianadam.eu/20191222/using-github-actions-with-c-plus-plus-and-cmake/ and started the AppVeyor and Travis config with parts of the ones from https://github.com/nlohmann/json.
I enabled the 3 CI services on my fork (up-to-date with the main repository), so you can see what should happen If you merge the modification here:

GitHub Actions: https://github.com/pinam45/imgui-sfml/actions/runs/224264417
Travis: https://travis-ci.org/github/pinam45/imgui-sfml/builds/721125936
AppVeyor: https://ci.appveyor.com/project/pinam45/imgui-sfml/builds/34849485

You can even see my most recent trial and error if you dig in the build history.

Okay, I see, thanks a lot!
After looking at it, this looks great. Merging...


--path command is not working

Hi there!
I'm building a cordova app, I've install ripple using npm, and I'm trying to run ripple using --path
ripple emulate --path platforms/ios/www
It launches an emulator, but it says:
Cannot GET /
The only way I can make it works is going to the path and once there running ripple
cd platforms/ios/www && ripple emulate
By the way, I'm on OSX El Capitan
Hope you can fix this

I recognise this is five years late, but in case anyone else hits this...
You can use the --path parameter with a full path and it will work.  Still... something to be addressed.


I want to create Homepage

Something specific you want to work on would be helpful, as you can see we have a homepage already

for specific in the home page i want to change the colour of scroll bar according to homepagecolour

Do you want to report a UI bug or any other enhancement?

I want to work on this issue

Assign this to me if possible

This is not an issue for now guys, if anyone wants to suggest a major enhancement in the UI/UX or Bug fix, would assign them the issue


Docs 2757

Copied 3.9 HA DR guide to Mule 4.1

Looks good! My only question: Does hadr-guide.adoc need to be added to nav.adoc?

Goes with https://github.com/mulesoft/docs-mule-runtime/pull/171 .


how to specify hostname?

I noticed that in Rendertron.initialize(), it do a this.app.listen(port, callback) which will run the service on the default address <IP_ADDRESS>

i would like to create PR @AVGP,  if you say ?

Sure thing!
On Sun, Oct 6, 2019, 13:23 Qazi Wahaj<EMAIL_ADDRESS>wrote:

i would like to create PR @AVGP https://github.com/AVGP, if you say ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleChrome/rendertron/issues/264?email_source=notifications&email_token=AAC2MRXZL6E435A6OX6KNU3QNHDBHA5CNFSM4GSUXXRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAOHWXY#issuecomment-538737503,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC2MRX6Z37NONQEMBR6KDTQNHDBHANCNFSM4GSUXXRA
.

@AVGP PR created.


Roku Remote Control

This PR contributes keybindings to send keypresses to the Roku device through Roku's External Control API using extension.brightscript.sendRemoteCommand and passing the key to send as the args.
Example Keybindings:
{
	"key": "alt+z",
	"command": "extension.brightscript.toggleRemote"
},
{
	"key": "Backspace",
	"command": "extension.brightscript.sendRemoteCommand",
	"args": "Back",
	"when": "isInRemoteMode && panelFocus && !inDebugRepl && !findWidgetVisible"
},
...

Using the above keybindings as an example, you can toggle the Remote on and off by pressing alt+z. The remote commands will be sent to the Roku IP that is being used in the last launched debugging session or will prompt you to enter the Roku IP address.
The when clause will only send the remote commands if the remote is in an "on" state (isInRemoteMode) AND the Panel has focus (panelFocus) AND the focus in NOT in the Debug Console REPL (!inDebugRepl) AND the Editor Find widget is NOT visible (!findWidgetVisible).
You can see an exmaple keybindings.json file here to grab (and copy) the 106 keybindings to send the full keyboard and Roku remote buttons.

Also, I feel like having every interested user copy a giant keybindings file is not the best solution. Can we discuss some alternatives?  I'm still fine with having the option for keybindings (as I see the benefit in assigning keyboard shortcuts to whatever you wish to type...but I think we need something more "built-in" for this feature. Like perhaps a basic popup window with an on-screen keyboard with all known characters, or a textbox and a "send" button or something?

And great work on this by the way. :D

One thing I noticed is that when you change the color of the bar at the bottom of vscode, this changes it for every open vscode instance. Is there a way to isolate this setting to only the active window? If I enable roku remote, then close that editor, my other vscode windows bottom bar will stay purple.
An acceptable workaround is to disable the purple setting on vscode shutdown....if there is such an event?

@TwitchBronBron, I fixed this to only update the local workspace's settings...hopefully that is acceptable, or I can just remove the color bar change...I just liked it because it made it obvious when it was active.

Also, I feel like having every interested user copy a giant keybindings file is not the best solution. Can we discuss some alternatives? I'm still fine with having the option for keybindings (as I see the benefit in assigning keyboard shortcuts to whatever you wish to type...but I think we need something more "built-in" for this feature. Like perhaps a basic popup window with an on-screen keyboard with all known characters, or a textbox and a "send" button or something?

I agree 100%...I spent a decent amount of time to "capture" the key that triggered the extension.brightscript.sendRemoteCommand command, but could not figure that out.
I tried incorporating all of the keybindings into the extension in the package.json but there seems to be an open issue where args can’t be passed from there, https://github.com/Microsoft/vscode/issues/31372
So until that gets fixed I don't have a better idea...your thoughts?
Thanks,
Blake

Also, I feel like having every interested user copy a giant keybindings file is not the best solution. Can we discuss some alternatives? I'm still fine with having the option for keybindings (as I see the benefit in assigning keyboard shortcuts to whatever you wish to type...but I think we need something more "built-in" for this feature. Like perhaps a basic popup window with an on-screen keyboard with all known characters, or a textbox and a "send" button or something?

I also thought about an on screen remote/text box input, but it was a lot of work to get create a new view in VS Code and we can not put our own views that go where the terminal and debug console are, so I gave up on this idea. I just don't have the time for that right now, and I didn't feel like I would get much value out of it...for my (and @georgejecook's) workflow, the key bindings work brilliantly.

Second that.
Its unobtrusive too: People don't have to use this feature. They just don't
configure it. No problem imho. So I don't see what harm it would do or why
make something that I've been using non stop since Blake wrote it
unavailable, to wait for another more difficult to implement solution; I'd
not use the other solution anyhow. I just focus on the console log and
press my hotkey. Its marvellous.
I bet many people would use it as it is, as well.   We
just want to get keypresses on to our devices. Ask in the slack if you
think I'm exaggerating. It a coalface feature.
On Tue, Dec 18, 2018, 10:52 PM Blake Visin<EMAIL_ADDRESS>wrote:

Also, I feel like having every interested user copy a giant keybindings
file is not the best solution. Can we discuss some alternatives? I'm still
fine with having the option for keybindings (as I see the benefit in
assigning keyboard shortcuts to whatever you wish to type...but I think we
need something more "built-in" for this feature. Like perhaps a basic popup
window with an on-screen keyboard with all known characters, or a textbox
and a "send" button or something?
I also thought about an on screen remote/text box input, but it was a lot
of work to get create a new view in VS Code and we can not put our own
views that go where the terminal and debug console are, so I gave up on
this idea. I just don't have the time for that right now, and I didn't feel
like I would get much value out of it...for my (and @georgejecook
https://github.com/georgejecook's) workflow, the key bindings work
brilliantly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TwitchBronBron/vscode-brightscript-language/pull/59#issuecomment-448460839,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKIUarVWrYGP75v0P3zizXJzxpLh50Mks5u6bgHgaJpZM4ZW6Vy
.

So I don't see what harm it would do or why
make something that I've been using non stop since Blake wrote it
unavailable, to wait for another more difficult to implement solution; I'd
not use the other solution anyhow. I just focus on the console log and
press my hotkey. Its marvellous.

The harm is that once something arrives in this extension, it will need to be supported for a long time. So I only want to put in long-term solutions. This solution works, but it doesn't work out of the box (without a copy-paste action from the user) which means extra setup work for every user who wants this functionality (which let's face it...will probably be most users), and clutters up the kemap file.
I would like to find a solution that solves your desire to watch the console and press [buttons on your keyboard], without needing the manual setup for every single user of this extension.
This PR also introduces a state (isInRemoteMode) to the editor which can be avoided with the right implementation.
Here how I envision this working:

Add the standard Roku buttons as bindable hotkey contributions (like extension.brightscript.sendHomePress,  extension.brightscript.sendBackPress, etc). You can hardcode the actions to specific function calls in code to make them work out of the box without needing users to register the commands themselves. This allows you to send these commands at any time within the editor, and negates the need for isInRemoteMode. A keybinding like alt-win (or alt-apple) and then the key should do the trick.

For sending actual text characters, we can leverage the existing debug console text input. This command vscode.commands.executeCommand('workbench.debug.action.focusRepl'); brings focus to the debug console, and specifically the text input box. So, here's the workflow:

User launches task extension.brightscript.activateKeyboardInput, which

calls vscode.commands.executeCommand('workbench.debug.action.focusRepl');
Tells the extension that the next set of input sent to the debug console should be passed to the roku as "keyboard input" and not evaluated as debug commands.

User types whatever text, and presses the enter key.
The extension fires off keyboard events to the roku for every character entered into the textbox.
Once the user presses enter, the extension goes back to normal mode.

The harm is that once something arrives in this extension, it will need to
be supported for a long time. So I only want to put in long-term solutions.
I understand that; I still don’t see the issue of it, if it works, has a
developer supporting it, and doesn’t cause any side-effects, and is
genuinely useful. It’s hands-down my most used feature right now.
This solution works, but it doesn't work out of the box (without a
copy-paste action from the user) which means extra setup work for every
user who wants this functionality (which let's face it...will probably be
most users), and clutters up the kemap file.
I think it’s my choice if I want to clutter up the keymap file, and I
should be allowed to do so if I choose to, so I don’t mind an extension
that has a ton of hooks, that I can use if I choose too. We’re not forcing
anyone to mess up their keymap if they don’t wan to. Even if we come up
with a solution that has a rotating 3d remote and vr hands, or 3d-prints a
remote for you, I’d still want to be able to configure the keymaps how I'd
like, and see this as useful power-user feature
I would like to find a solution that solves your desire to watch the
console and press [buttons on your keyboard], without needing the manual
setup for every single user of this extension.
This PR also introduces a state (isInRemoteMode) to the editor which can be
avoided with the right implementation.
Here how I envision this working:

Add the standard Roku buttons as bindable hotkey contributions (like
extension.brightscript.sendHomePress,
extension.brightscript.sendBackPress, etc). You can hardcode the actions
to specific function calls in code to make them work out of the box without
needing users to register the commands themselves. This allows you to send
these commands at any time within the editor, and negates the need for
isInRemoteMode. A keybinding like alt-win (or alt-apple) and then the
key should do the trick.
It sounds like you’re saying I’ll need to do a chorded key for every
keypress. Is that the case? That’s no good. If not, then it will still stop
me typing code/navigating and searching, also no good. If I’m not
understanding, then let me know what the intent is here; but it sounds like
this won’t fly in for real-world-usage

For sending actual text characters, we can leverage the existing debug
console text input. This command
vscode.commands.executeCommand('workbench.debug.action.focusRepl'); brings
focus to the debug console, and specifically the text input box.
I don’t like this: I don’t look at the debug console. It’s difficult to
read and can’t be searched. I look at the output window, which has better
formatting/colors/searchable, etc.

So, here's the workflow:

User launches task extension.brightscript.activateKeyboardInput, which
- calls
vscode.commands.executeCommand('workbench.debug.action.focusRepl');
- Tells the extension that the next set of input sent to the debug
console should be passed to the roku as "keyboard input" and
not evaluated
as debug commands.

User types whatever text, and presses the enter key.
The extension fires off keyboard events to the roku for every
character entered into the textbox.
Once the user presses enter, the extension goes back to normal mode.

I think if we’re going to have a sensible discussion about this we need to
discuss a real world use case. With all due respect, we’re dogfooding this
feature 6-10 hours every day of the week and the use case you’ve laid out
doesn’t look like any moment of my full time (and more) roku work (I don’t
just start a roku app and type a password, and done). I suggest we use this
real-world use case to plan the feature:

I start the app
I navigate around the app using remote arrow keys, back, ok, star keys
I’m reading log output while I do this
I navigate some more, using the the arrow keys, back, ok,
I navigate to some code files in vscode to double check some log
output
I navigate some more, back a few times, left , left, right, up
I search my console output for a value
I navigate a bit more, left right, up down
I enter some text in an input field in my roku, by just typing
Press ok a few times
Search my console output
Look for some code files in vscode
Press left, left, left right, down

Currently, I simply activate the roku remote keypress with alt z, and I
have keybindings that only make it work in the log output window when the
search window is not available, and in the console output when not focused
in the repl. I can use hotkeys to jump between my code, the console, the
output window. It’s completely seamless and a delight to use.
I’m sure we can jam out a solution that is less hacky than what we have;
but it has to at least have the same level of comfort and utility. So let’s
focus on the real scenario I’ve provided, and design something that fits
that typical use case.
The ultimate solution will be have a custom window with REPL, roku remote
keypress detection, colored and hyper linkable console output and a preview
coming from a capture card. But the current vscode extension points don’t
support this very well, and I’m not going to invest time to do it using the
html view option, as the LOE doesn’t yield a good enough solution. I’d
never want a custom view, for this as that’s a waste of a left side panel,
imho. I think we have to be realistic about what we want to achieve in
terms of use case and productivity vs vscode limitations.
I hope that I’ve been verbose enough to facilitate a proper discussion
about this now: I’m sure we can find something that works within these
constraints.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TwitchBronBron/vscode-brightscript-language/pull/59#issuecomment-448592842,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKIUSLUjIerNPpuCKzphqAPJQ59qq1Qks5u6juwgaJpZM4ZW6Vy
.

@TwitchBronBron totally understand the wanting to make it not require a user to do a huge key binding file. I think most of the keys like literal letters nobody should have any trouble with but some like play people may want to remap and for sure the key to enable or disable the remote control will definitely want to customize. I would say maybe toggling remote mode could require a keybinding specified by the user. Toggle XML already requires that and while it adds extra effort on the user, it makes the extension not effect global keybindings at all. The others could have defaults set but with the ability to override. Moving the keybindings over to the actual extension itself looks pretty easy as I just looked at an extension doing it https://github.com/Microsoft/vscode-atom-keybindings/blob/master/package.json#L24
I will side with the others on the effort in adding a UI. If there is enough desire it can be built in. With Roku's own remote tool I only use the interface for selecting what device. The rest is keyboard presses.

@triwav As I mentioned above, I tried incorporating all of the keybindings into the extension in the package.json but there seems to be an open (now closed?) issue where args can’t be passed from there, Microsoft/vscode#31372

For the core Roku remote buttons, you shouldn't need to pass in arguments. You would contribute an actual command for each Roku botton in package.json.
"commands": [
    {
                "command": "extension.brightscript.pressHomeButton",
                "title": "Press the home button on the Roku remote",
                "category": "Brightscript"
    },
    {
                "command": "extension.brightscript.pressBackButton",
                "title": "Press the back button on the Roku remote",
                "category": "Brightscript"
    }...

Then register those commands in src/BrightScriptCommands.ts:
subscriptions.push(vscode.commands.registerCommand('extension.brightscript.pressHomeButton', (key: string) => {
    this.sendRemoteCommand('Home');
}));

subscriptions.push(vscode.commands.registerCommand('extension.brightscript.pressBackButton', (key: string) => {
    this.sendRemoteCommand('Back');
}));

Then contribute keybindings for these in package.json (this is untested btw)
"contributes": {
    "keybindings": [{
        "command": "extension.brightscript.pressHomeButton",
        "key": "win+alt+home",
        "mac": "apple+alt+home",
        "when": "editorTextFocus"
    },{
        "command": "extension.brightscript.pressBackButton",
        "key": "win+alt+backspace",
        "mac": "apple+alt+backspace",
        "when": "editorTextFocus"
    }, ...]
}

What's nice is that the end user still has the option to override the keybindings to something else.

I agree for general roku commands.
What happens to typing? i.e. usernames/passwords..
On December 19, 2018 at 3:06:28 PM, Bronley Plumb<EMAIL_ADDRESS>wrote:
@triwav https://github.com/triwav As I mentioned above, I tried
incorporating all of the keybindings into the extension in the package.json
but there seems to be an open (now closed?) issue where args can’t be
passed from there, Microsoft/vscode#31372
https://github.com/Microsoft/vscode/issues/31372
For the core Roku remote buttons, you shouldn't need to pass in arguments.
You would contribute an actual command for each Roku botton in package.json.
"commands": [
{

            "command": "extension.brightscript.pressHomeButton",

            "title": "Press the home button on the Roku remote",

            "category": "Brightscript"

},

{

            "command": "extension.brightscript.pressBackButton",

            "title": "Press the back button on the Roku remote",

            "category": "Brightscript"

}...

Then register those commands in src/BrightScriptCommands.ts:
subscriptions.push(vscode.commands.registerCommand('extension.brightscript.pressHomeButton',
(key: string) => {
this.sendRemoteCommand('Home');

}));
subscriptions.push(vscode.commands.registerCommand('extension.brightscript.pressBackButton',
(key: string) => {
this.sendRemoteCommand('Back');

}));
Then contribute keybindings for these in package.json (this is untested btw)
"contributes": {
"keybindings": [{

    "command": "extension.brightscript.pressHomeButton",

    "key": "win+alt+home",

    "mac": "apple+alt+home",

    "when": "editorTextFocus"

},{

    "command": "extension.brightscript.pressBackButton",

    "key": "win+alt+backspace",

    "mac": "apple+alt+backspace",

    "when": "editorTextFocus"

}, ...]

}
What's nice is that the end user still has the option to override the
keybindings to something else.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TwitchBronBron/vscode-brightscript-language/pull/59#issuecomment-448726870,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKIUXo-50TuRTe9YdMckeyPIAkazmPgks5u6pxDgaJpZM4ZW6Vy
.

vscode already provides an input box popup. What about using it for the keyboard input?

something like win+alt+k (popup appears), then type your keys and press enter.
 var stuffUserTyped = await vscode.window.showInputBox({
    placeHolder: 'Press enter to send all typed characters to the roku',
    value: ''
});

+1 Will implement!

Okay @TwitchBronBron @georgejecook @triwav  I made some time today to add the popup text input that @TwitchBronBron referenced above.  It works nicely, but I am still trying to figure out how to put the focus back to the output panel.  It defaults to the editor after text is entered and you press the enter key.
Check it out and let me know what you guys think.
Thanks!

The focus back to OUTPUT window seems to be a bug https://github.com/Microsoft/vscode/issues/65425

Okay guys, I added the backspace key as the 12th predefined key (cmd+delete)
I also put in a bit of a hacky fix for the focus…In order to bring focus back to the Output panel after inputting text I do
vscode.commands.executeCommand('workbench.action.output.toggleOutput'); I think this will be acceptable until https://github.com/Microsoft/vscode/issues/65425 gets fixed.
Take a look and let me know what you guys think.  I am pretty happy with the result. Thanks for all the input today.

I changed the command to be vscode.commands.executeCommand('workbench.action.focusPanel'); which I think feels better than output.toggleOutput

What's the state of this PR. Have you finished all of your changes?

Yes, I believe it's ready and I have made all the changes as you requested.  This PR is waiting on feedback from you and your approval.


HDDS-2180. Add Object ID and update ID on VolumeList Object.

https://issues.apache.org/jira/browse/HDDS-2180
Adds Object ID and Update ID to VolumeList object.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

0
mvndep
14
Maven dependency ordering for branch

-1
mvninstall
30
hadoop-hdds in trunk failed.

-1
mvninstall
26
hadoop-ozone in trunk failed.

-1
compile
21
hadoop-hdds in trunk failed.

-1
compile
15
hadoop-ozone in trunk failed.

+1
checkstyle
49
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
834
branch has no errors when building and testing our client artifacts.

-1
javadoc
21
hadoop-hdds in trunk failed.

-1
javadoc
19
hadoop-ozone in trunk failed.

0
spotbugs
930
Used deprecated FindBugs config; considering switching to SpotBugs.

-1
findbugs
31
hadoop-hdds in trunk failed.

-1
findbugs
19
hadoop-ozone in trunk failed.

_ Patch Compile Tests _

0
mvndep
18
Maven dependency ordering for patch

-1
mvninstall
35
hadoop-hdds in the patch failed.

-1
mvninstall
29
hadoop-ozone in the patch failed.

-1
compile
24
hadoop-hdds in the patch failed.

-1
compile
19
hadoop-ozone in the patch failed.

-1
cc
24
hadoop-hdds in the patch failed.

-1
cc
19
hadoop-ozone in the patch failed.

-1
javac
24
hadoop-hdds in the patch failed.

-1
javac
19
hadoop-ozone in the patch failed.

+1
checkstyle
56
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
738
patch has no errors when building and testing our client artifacts.

-1
javadoc
21
hadoop-hdds in the patch failed.

-1
javadoc
20
hadoop-ozone in the patch failed.

-1
findbugs
31
hadoop-hdds in the patch failed.

-1
findbugs
20
hadoop-ozone in the patch failed.

_ Other Tests _

-1
unit
28
hadoop-hdds in the patch failed.

-1
unit
24
hadoop-ozone in the patch failed.

+1
asflicense
33
The patch does not generate ASF License warnings.

2364

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1526

Optional Tests
dupname asflicense compile cc mvnsite javac unit javadoc mvninstall shadedclient findbugs checkstyle

uname
Linux 19a38fab1e05 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / bdaaa3b

Default Java
1.8.0_222

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-compile-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-findbugs-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/patch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/patch-compile-hadoop-ozone.txt

cc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/patch-compile-hadoop-hdds.txt

cc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/patch-compile-hadoop-hdds.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/patch-compile-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/patch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/patch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/patch-findbugs-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/testReport/

Max. process+thread count
413 (vs. ulimit of 5500)

modules
C: hadoop-ozone/common hadoop-ozone/ozone-manager U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

0
mvndep
14
Maven dependency ordering for branch

-1
mvninstall
30
hadoop-hdds in trunk failed.

-1
mvninstall
24
hadoop-ozone in trunk failed.

-1
compile
20
hadoop-hdds in trunk failed.

-1
compile
15
hadoop-ozone in trunk failed.

+1
checkstyle
49
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
843
branch has no errors when building and testing our client artifacts.

-1
javadoc
22
hadoop-hdds in trunk failed.

-1
javadoc
20
hadoop-ozone in trunk failed.

0
spotbugs
943
Used deprecated FindBugs config; considering switching to SpotBugs.

-1
findbugs
33
hadoop-hdds in trunk failed.

-1
findbugs
20
hadoop-ozone in trunk failed.

_ Patch Compile Tests _

0
mvndep
19
Maven dependency ordering for patch

-1
mvninstall
36
hadoop-hdds in the patch failed.

-1
mvninstall
30
hadoop-ozone in the patch failed.

-1
compile
24
hadoop-hdds in the patch failed.

-1
compile
19
hadoop-ozone in the patch failed.

-1
cc
24
hadoop-hdds in the patch failed.

-1
cc
19
hadoop-ozone in the patch failed.

-1
javac
24
hadoop-hdds in the patch failed.

-1
javac
19
hadoop-ozone in the patch failed.

+1
checkstyle
57
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
722
patch has no errors when building and testing our client artifacts.

-1
javadoc
21
hadoop-hdds in the patch failed.

-1
javadoc
20
hadoop-ozone in the patch failed.

-1
findbugs
32
hadoop-hdds in the patch failed.

-1
findbugs
20
hadoop-ozone in the patch failed.

_ Other Tests _

-1
unit
28
hadoop-hdds in the patch failed.

-1
unit
24
hadoop-ozone in the patch failed.

+1
asflicense
32
The patch does not generate ASF License warnings.

2356

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1526

Optional Tests
dupname asflicense compile cc mvnsite javac unit javadoc mvninstall shadedclient findbugs checkstyle

uname
Linux becb47a90b3b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / bdaaa3b

Default Java
1.8.0_222

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-compile-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-findbugs-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/patch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/patch-compile-hadoop-ozone.txt

cc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/patch-compile-hadoop-hdds.txt

cc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/patch-compile-hadoop-hdds.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/patch-compile-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/patch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/patch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/patch-findbugs-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/testReport/

Max. process+thread count
446 (vs. ulimit of 5500)

modules
C: hadoop-ozone/common hadoop-ozone/ozone-manager U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Was this committed without a pre-commit run from Anzix?

Looks like it was not run. I did look at the yetus output but the output is too noisy to make any sense.

None that I know of. However we should not commit a patch without CI on principle.

None that I know of. However we should not commit a patch without CI on principle.

This has been broken for quite a while; So I rely on Jenkins/Yetus and hand building before apply the commits.


An error occurs when creating a file with name "."

OS: Win 10
Build: 20220808.1
Regression: Not a Regression
Repro Steps:

Expand a storage account -> Create a file share.
Right click the file share -> Click "Create Directory..." -> Type name "a".
Right click "a" folder -> Click "Create Empty File..." -> Type name ".".
Check whether it can be created successfully.

Expect:
The file can be created successfully.
Actual:
An error occurs when creating a file with name ".".

More Info:

This issue also reproduces on the previous released Storage extension 0.14.2.
The error message is clear when creating a file with invalid name, the invalid name doesn't contain ".".

We could improve the error message here, but this is by design.


Support argo submit output to be in json format

Argo submit shows the result of the command in a nice tabular format. However, for running argo submit in a script, it is a bit hard to parse the output from the tabular format. Instead, it'll be good to have the output of argo submit in the json format.

One caveat. argo submit supports submission of multiple manifests in different files, or even in the same file separated by ---. So the return value would be a list of workflow resources.


Bump Rails from <IP_ADDRESS> to 5.2.6

Fixes CVE-2021-22885 (information disclosure / unintended method execution
vulnerability) See https://github.com/MushroomObserver/mushroom-observer/security/dependabot/Gemfile.lock/actionpack/open
Fixes CVE-2021-22880 (REDoS attack. Doesn't affect us (its a postgres issue) ) See https://github.com/MushroomObserver/mushroom-observer/security/dependabot/Gemfile.lock/activerecord/open

Coverage remained the same at 92.984% when pulling c4613116f28279a42fc3eb40fb358ec627ebe13c on RoR-5.2.6 into bcf3912552b7e689a8f1b27025a5c1e6426ffca4 on master.


ksp-audit-cassandra-stig-v-72635

Based on ref URL, as of now KubeArmor or Cilium doesn't support string parsing as below
%-5level [%thread] %date{ISO8601, UTC} %F:%L - %msg%n


Please add me to the Kivy Garden

Link for a merged garden PR or a proposed new flower:
https://github.com/yoelk/garden.multichoicetogglebutton
Hi,
I tried running the pep8checker upon commit, but it couldn't run the script.
First I gave me the error:
`.git/hooks/pre-commit: line 17:
Kivy Git Pre-Commit Hook to Enforce Styleguide
==============================================
This script is not supposed to be run directly.
Instead, copy it to your kivy/.git/hooks/ directory, call it pre-commit
and make it executable.

If you attempt to commit, git will run this script, which in turn will run
the styleguide checker over your code and abort the commit if there are any
errors. If that happens, please fix & retry.

To install::

    cp kivy/tools/pep8checker/pre-commit.githook .git/hooks/pre-commit
    chmod +x .git/hooks/pre-commit
: No such file or directory
.git/hooks/pre-commit: line 19: import: command not found
from: can't read /var/mail/os.path
from: can't read /var/mail/subprocess
.git/hooks/pre-commit: line 23: syntax error near unexpected token ('
.git/hooks/pre-commit: line 23: curdir = dirname(abspath(__file__))'
 (1)`

And when I followed (these instructions) [https://github.com/kivy/kivy/issues/3893] I got the following error:
Traceback (most recent call last):   File ".git/hooks/pre-commit", line 33, in <module>     import kivy ImportError: No module named kivy  (1)
If you can help me get it to work, I'd appreciate it.
I hope you like my flower,
Joel

Thanks. :+1: The repo will have to be transferred to me or someone else from the team, see the bottom of repo settings.

Great! I just did.
Please tell me if something else is necessary.
Joel
On Wed, May 11, 2016 at 2:27 PM, dessant<EMAIL_ADDRESS>wrote:

Thanks. [image: :+1:] The repo will have to be transferred to me or
someone else from the team, see the bottom of repo settings.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/kivy-garden/kivy-garden.github.io/issues/115#issuecomment-218444343

That's it, you should have write access to https://github.com/kivy-garden/garden.multichoicetogglebutton once the invitation is accepted, thanks a lot.


Removing delete_change from changeset

@tuvistavie ready!

Thank you very much!
I just published as 0.6.0.


issue on example site in main.cpp

in main.cpp
bool ret = config_manager::from_file(cfg, "./cfg/feather.cfg");
returns false. I have to use a absolute path to the file or ../cfg/feather.cfg then it succeeds
after that the "init" function throws:
terminate called after throwing an instance of 'std::invalid_argument'
what():  init failed
Aborted (core dumped)
when calling
dao_t<dbng>::init(cfg.db_conn_num, cfg.db_ip.data(), cfg.user_name.data(), cfg.pwd.data(),
cfg.db_name.data(), cfg.timeout);
what could fix this issue?
compiler g++ 7.3.0
operating system ubuntu

open the feather.cfg file, you will see some configurations, you should config the database itemts, for example:
"db_ip": "<IP_ADDRESS>",
"user_name": "feather",
"pwd": "12345",
"db_name": "feather",
you should fill the right database ip, user_name, pwd and database name.
please check it

Hi i created a mysql db before calling init in main.cpp which compiles but it still throws 'std::invalid_argument'. I appreciate your help.
dbng mysql;
mysql.connect("<IP_ADDRESS>", "feather", "12345", "feather");
mysql.commit();
init(cfg);
cfg/feather.cfg:
{
"thread_num": 4,
"port": "8080",
"db_ip": "<IP_ADDRESS>",
"user_name": "feather",
"pwd": "12345",
"db_name": "feather",
"timeout": 2,
"db_conn_num": 4,
"drop_all_table": 0,
"log_path": "/tmp",
"log_name": "feather.log",
"roll_file_size": 2
}


Support new Crystallize image format

Since we now support a variable variants generation based on the image width, and also WebP, the package needs to be updated to reflect this.
Should we perhaps change the standard export to the <picture> el?

@didrikhegna @danisal

Fixed in - https://github.com/CrystallizeAPI/react-image/pull/2
Hence, closing


strange activity  about join query with the join key condition.

 DB::Exception: Received from localhost:9000. DB::Exception: Cannot get JOIN keys from JOIN ON section: TRUE.

Same, but works if in join clause for IN condition will have 2 items - works as expected
For previous comment if might be as
INNER JOIN shop_member_property b ON ( a.shop_member_id = b.shop_member_id and a.shop_member_id in ( '6d34478f-626d-d162-6758-e9fc98dcd6a3', 'some_unknown_shop_member_id') )

How to reproduce:
On Clickhouse:
`create table default.deals_1_pipedrive
(
date                        Date,
__account_id                String,
__row_hash                  UInt64,
__row_id                    UInt16,
__key_hash                  UInt64,
__sign                      Int8,
__insert_date               DateTime
)
engine = CollapsingMergeTree(__sign)
PARTITION BY toYYYYMM(date)
ORDER BY (date, __account_id, __row_hash, __row_id)
SETTINGS index_granularity = 8192;
CREATE VIEW default.deals_1_pipedrive_fdw
(
date Date,
__account_id String,
__insert_date DateTime
)
AS
SELECT deals_1_pipedrive.date,
deals_1_pipedrive.__account_id,
deals_1_pipedrive.__insert_date
FROM default.deals_1_pipedrive
FINAL;
INSERT INTO default.deals_1_pipedrive (
date, __account_id, __row_hash, __row_id, __key_hash, __sign, __insert_date
) VALUES (
'2019-12-13', '1234',<PHONE_NUMBER>605290501, 0,
8193464384205566314, 1, '2021-06-07 06:33:21'
);
-- auto-generated definition
create table report_accounts
(
id           UInt64,
account_id   String
)
engine = File(TabSeparated);
INSERT INTO default.report_accounts (id, account_id) VALUES (218760, '1234');
`

Hi, thank you for the script to reproduce.
Unfortunately, there is nothing I can do on FDW side, since the conditions changed by postgres optimizer, and FDW gets the conditions as you can see and doesn't change them.
Just to make sure I made a special build of postgres where I disabled process_equivalence function, and it made the query working.
There could be some trick to avoid this optimization.
Another option could be a discussion with the clickhouse developers to enable ON (True) construction.


[Tooltip] Unexpected behaviour onOpen/onClose

[ x ] I have followed (at least) the PR section of the contributing guide.

Closes #23450

Could we add a regression test case? (it should fail without the change)

hm, I gave it a quick try but not quite sure if that is the way to do it. I would really appreciate some hints otherwise! :)

I added another case for closing and reduced the original test case a bit so that it only includes what is needed.
Switched from the negative assertion to the positive one since that has a more helpful failure message. For the negative assertion you wouldn't see in the log what the eventLog actually looks like.

@eps1lon Oh I took a glimpse at your changes and I agree, that seems very reasonable! Thanks for clarifying, I think that will be helpful for me in the future! 👏


Add models SDK to e2e template

I have no idea why but the pre-commit hook for generating markdown is broken now. checks passing even though .md has not been updated

updated GCP code and tested that it works with an existing lora checkpoint:


Add support for lzh format. (with 7zip)

Thank you for really great software!
I like scoop so much.
Please add support for extracting .lzh format.
Because in Japan, some softwares is provided this legacy format...
ex)  http://ftp.vector.co.jp/43/51/2176/SoftTilt111.lzh
7zip can extract .lzh format.

Thanks for this 👍


Switch to cloudnative-pg

Zalando's Postgres Operator doesn't really work that well in my cluster, therefore, it shall be replaced with cloudnative-pg.
After having read like 2 reddit posts and a blog article on it, I have decided it is 420x better than Zalando's Operator.
(for the record: that is a joke and the migration will obviously involve extensive testing to see if it is actually a good fit)

Warning: before deleting the Zalando operator, make sure to verify that it successfully cleaned up all its resources. I saw some "unable to delete PVC" errors (that may be related to a removed node though).


Fix to bower ECONFLICT on angular version.

I'm not sure how this passed the Travis checks the first time...

Merged #428


token-cli: Support transfer hook extension

Problem
There's no support for the transfer hook extension in the token CLI.
Solution
Add basic support for setting a transfer hook at mint creation, updating the program, and specifying transfer-hook-accounts for offline signing.
Fixes #4548

This should be ready for another look


Proposal

As a cluster operator, I'd like control multiple clusters at the same time on the multiple terminal windows.
I'd like to switch kubecontexts via env, not a file.
I'd like to use the same file as a SSoT of kubeconfig

Existing solutions
kubectx

kubectx modifies kubeconfig directly.
The change affect all terminals.

alias kubectl="kubectl --context=$KUBECTX"

Not integrated with k9s
Not integrated with the prompt of terminals

User Scenario

kubectl vctx hook bash/zsh will inject a hook to rewrite KUBECONFIG env.
kubectl vctx init will create a temporary kubeconfig file to save current-context.
kubectl vctx will launch fuzzy finder and rewrite the temporary kubeconfig

init if not initialized

outdated