[Question] Is this indented feature?: Context data is maintained regardless of component lifeCycle if the overlay has the same ID.

hello.
I used a context provider inside the overlay.
Give value to Provider with props.
  const handleFileButtonClick = () => {
    overlay.open(
      ({ isOpen, close }) => (
        <ModalContainer isOpen={isOpen} onClose={close}>
          <FileUploadAndSelectModal providerValue={providerValue} />
        </ModalContainer>
      ),
      { overlayId: `File-Upload-Select` }
    );
  };

// FileUploadAndSelectModal
const FileUploadAndSelectModal = ({providerValue})=>{
return(
<MyContext.Provider value={providerValue}>
{/*....*/}
</MyContext.Provider?
)
}

This modal can be opened with sameID:File-Upload-Select on multiple pages.
Different pages inject different providerValue.
I had to refresh the page to get the desired providerValue within the modal.
I solved this by giving each overlay a different id, such as uuid.
Is this indented feature?

Yeah this is intended. Given the same overlayId, if you don't call unmount callback, the same overlay is in memory.
related issue: https://github.com/toss/overlay-kit/issues/57
So if you want to reset provoderValue, call unmount callback after close or just call unmount for closing the overlay.
  const handleFileButtonClick = () => {
    overlay.open(
      ({ isOpen, unmount }) => (
        <ModalContainer isOpen={isOpen} onClose={unmount}>
          <FileUploadAndSelectModal providerValue={providerValue} />
        </ModalContainer>
      ),
      { overlayId: `File-Upload-Select` }
    );
  };


HTML

HTML
User Story
As a bootcamp student
I want the prework notes to be structured on a webpage
so that I can easily find and read information
Acepptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, GIT, and JavaScript with associated notes listed

#CSS
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
GIVE a Prework Study Guide website
WHEN I view the study guide
THEN I see a dark blue header and footer, and four boxes with a shadow

JavaScript
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

README
User Story
As a boot camp student,
I want the prework notes to be structured on webpage,
So that I can easily find and read the information.
Acceptance Criteria
GIVEN the prework project repository,
WHEN I view the README for the repository,
THEN I can see a professional README that provides information on the project and how to use it

#Deployment
User Story
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
Acceptance Criteria
GIVEN a Prework Study Guide website,
WHEN I visit the website using the URL,
THEN I can access my website from any browser


[WIP] Create board pins controller, spec out Pin model

Ref #3

Coverage decreased (-3.4%) to 96.599% when pulling 995fda833c329c68f11aefa84e59ee89e29af2ed on br.board-pins into 53fcbf3f05fddfdaa27ed4caba3dee5846da4ffd on master.

Coverage decreased (-3.4%) to 96.599% when pulling 995fda833c329c68f11aefa84e59ee89e29af2ed on br.board-pins into 53fcbf3f05fddfdaa27ed4caba3dee5846da4ffd on master.

Coverage remained the same at 100.0% when pulling d66ed8336808efccf03c535f72daea41ad393671 on br.board-pins into 53fcbf3f05fddfdaa27ed4caba3dee5846da4ffd on master.

Coverage remained the same at 100.0% when pulling 6e0c5c68ff640219dbd41d50c28e52fc12530cb3 on br.board-pins into 53fcbf3f05fddfdaa27ed4caba3dee5846da4ffd on master.


Better escaping performance

This is a more efficient algorithm for escaping a JSON string. The new process has time and space complexity of O(n) where n is the length of the string to be escaped (if I account properly), and requires no more than 2 full scans of the string in the worst case and 1 full scan of the string.
In the event a string has none of the characters which need to be escaped, the input string will be returned without additional allocations. Otherwise, a string builder will be allocated with initial capacity set to the length of the input string. For the cost of an additional scan of the string, we could determine the exact length of the output string. Testing indicated that this added extra overhead cost without significant benefit. Then we step through the string, stopping at each character which needs to be escaped and adding the unescaped characters and expanding the target characters. Once we have processed all the values which must be escaped, we return the new string from the string builder.
Also included is a table of escape characters. These are all the characters in UTF-8 that need escaping for JSON. Unicode characters beyond U+FFFF should not need to be further escaped due to encoding the value in UTF-8. As String.IndexOfAny does not take a predicate, this array is necessary to take advantage of the internal BCL optimizations.
On my hardware, I am achieving ~4ms for 2.5MB of string that needs no escaping and ~75ms for 2.5MB of string with significant escaping required.

/cc @etaullaj

This looks great! Definitely a more performant way of doing things 😄  The existing implementation was very much a "do the simple thing idiomatically, don't worry about speed yet" so this is the logical next step.
I'm going to get this merged in, bump versions and update the build (unrelated!). Hopefully it should be out there today at some point...

A bit of a delay at the moment as I can't access my Appveyor account for Xyncro at the moment - http://help.appveyor.com/discussions/problems/5310-access-to-github-organisation-has-disappeared is a bit of a concern! Hopefully that will get sorted shortly...


Property type should not be included in swagger

That prop is set by default in the Model, it shouldn't be passed as a param

interesting, that implies I will create decorators also in the Models in order to include/exclude parameters from the code generation

Or maybe exclude type by default since it's a system property. Later we can introduce advanced granular setups like decorators in models :)

yeah that will be the first and quick solution that at least allows ppl to use it without mistakes

done


Document network policy behaviour for host network pods

The behaviour for both NetworkPolicy and ANP is not defined in the docs for host networked pods, which causes confusion on why those pods are [not] affected by the netpol rules. Need to clarify that in the docs.

/assign @npinaeva

https://github.com/kubernetes/website/pull/39875

/sig docs
/kind documentation

/remove-lifecycle stale

https://github.com/kubernetes-sigs/network-policy-api/issues/187


update placeholders

Fixes #570

Codecov Report

Merging #582 (925f334) into develop (339361a) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop        #582   +/-   ##
=============================================
  Coverage   98.28979%   98.28979%
=============================================
  Files             86          86
  Lines           2105        2105
=============================================
  Hits            2069        2069
  Misses            36          36


Fix disabled test in LargeSplitRowIT

It looks like #3425 may have changed the exception being thrown from AccumuloServerException to AccumuloException. Not sure if that's a big deal or not...

It looks like https://github.com/apache/accumulo/pull/3425 may have changed the exception being thrown from AccumuloServerException to AccumuloException. Not sure if that's a big deal or not...

I suspect thats caused by split moving from a direct tserver RPC to using the RPCs that run fate operations.  I don't think that change is an issue.


Add own implementation of crc32 checksum, remove boost dependancy

Description
This PR adds a custom implementation of the crc32 cyclical redundancy check and by doing so removes the dependancy upon boost::crc (part of issue #2540 ).
How to test
Run tests and see if they fail. If the implementation were incorrect, several Cardano tests would fail as it is used there.
Types of changes

Improvement: This code introduces no features and should be fully backwards-compatible.

Checklist

[x] Create pull request as draft initially, unless its complete.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.
[x] If there is a related Issue, mention it in the description.

@lolcathost , could you check & address the review comments?


Error: Provider can't apply new stackit_network ressource in v0.18.1

After trying the new stackit_network ressource I get a error during the apply.
I can cleanly reproduce the issue with following config:
terraform {
  required_version = "~>1.5"
  required_providers {
    stackit = {
      source  = "stackitcloud/stackit"
      version = "0.18.1"
    }
  }
}

provider stackit {
  region = "eu01"
  resourcemanager_custom_endpoint = "https://resource-manager.api.stg.stackit.cloud"
  objectstorage_custom_endpoint   = "https://object-storage.api.eu01.stg.stackit.cloud"
  ske_custom_endpoint             = "https://ske.api.eu01.stg.stackit.cloud"
  service_account_token = var.service_account_token
}

resource "stackit_network" "my-network" {
  project_id         = "<redacted>"
  name               = "my-network"
  nameservers        = ["<IP_ADDRESS>", "<IP_ADDRESS>", "<IP_ADDRESS>"]
  ipv4_prefix_length = 24
}

Output of terraform apply:
Error: Error creating network
│
│   with stackit_network.my-network,
│   on ske.tf line 23, in resource "stackit_network" "my-network":
│   23: resource "stackit_network" "my-network" {
│
│ Calling API: undefined response type, status code 401, Body: Jwks doesn't
│ have key to match kid or alg from Jwt
│
╵
ERROR: Terraform apply failed.

Hi @Slaizer007, are you using a project in QA? If yes, you need to set the field iaas_custom_endpoint to the QA url of the IaaS API.
This seems like a problem with the authentication, so please also double check your project_id and service_account_token.

Hey @vicentepinto98,
you are right we are deploying to STACKIT QA Portal.
We added the correct iaas_custom_endpoint now and receive a new error:

│ Error: Error creating network
│
│   with stackit_network.hansp-k8s-network,
│   on ske.tf line 23, in resource "stackit_network" "hansp-k8s-network":
│   23: resource "stackit_network" "hansp-k8s-network" {
│
│ Calling API: undefined response type, status code 404, Body:
│ {"status":404,"message":"Not found"}
│
╵

I just tested in QA and everything is working fine.
Which url are you using? The correct one is https://iaas-qa.api.eu01.stg.stackit.cloud

Hey @Slaizer007, I'll close this issue due to inactivity. Please feel free to re-open it if you still have doubts!


Update: SandroMani.gImageReader version ci-latest-master

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.5 schema?

Microsoft Reviewers: Open in CodeFlow

Verifying the non-semantic version number:


Bugfix/1125 generation of templates from external increments does not work

Fixes #1125 .
Implements

Fix the test for generating templates from external increments
Adding templates from DependentIncrement to the list of template in TemplatesConfiguration

@devonfw/cobigen

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 4 committers have signed the CLA.:white_check_mark: LarsReinken:white_check_mark: maybeec:x: Cao:x: lilliCaoCao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[Webpack 5.4] ontput.library unable to work properly

Bug report
What is the current behavior?
Unable to export normally
If the current behavior is a bug, please provide the steps to reproduce.
// webpack.config

entry:{
        mian:'/src/index.ts'
    },
    output: {
        path: path.join(__dirname, '../dist'),
        publicPath: './',
        filename: isDevServer
            ? '[name].[fullhash].js'
            : '[name].[contenthash].js',
        library: 'test',
        libraryTarget: 'umd',
        jsonpFunction: `webpackJsonp_test`,
    }

// index.ts

export function mount() {}
export function bootstrap() {}
export function unmount() {}

// in Browser
console.log(window.test)
// {}

What is the expected behavior?
// in Browser
console.log(window.test)
// {mount(){},bootstrap(){},unmount(){}}

Other relevant information:
webpack version:  5.4.0

here is a working example
https://github.com/code1x1/webpack-library-example-11986
the test property definitely exists

Works fine, I think you use webpack-dev-server, webpack-dev-server doesn't support libraries :disappointed: , we have the issue about this, hope we will fix it in near future

Works fine, I think you use webpack-dev-server, webpack-dev-server doesn't support libraries 😞 , we have the issue about this, hope we will fix it in near future

Yeah, I use webpack-dev-server
thank you


CDC_ACM sample does not work with nrf5340  -- device suspended/resumed  on the host  "device descriptor read/64, error -71"

Describe the bug
I try to compile a sample of a USB device for nrf5340. No one of them work as it should. For example  cdc_acm is not detectable by host's USB driver.  There is what I am doing to see the problem:

My target platform nrf5340 (nrf5340dk_nrf5340_cpuapp)
The toolschain is zephyr-sdk-0.16.1
The nrf SDK 2.4.1 -- but the same result with 2.4.0 and 2.2
So, It is not the regression! Same for SDK  v2.4 and  v2.2?
To diagnose issue was used the next tips:

Enabled Debug level log for USB stack;
Checked wire connection between USB connector and MCU;
Tested all another USB samples: HID, Bulk -- no one work;
Captured the diagrams D+ and D- also connection of VBUS;

To Reproduce
Steps to reproduce the behavior:

copy cdc_acm to ~/
open with VS Code;
edit build settings:

change target "nrf5340dk_nrf5340_cpuapp";
change configuration to prj.conf;

Open run menuconfig and change setting: "Max compiled-in log level for usb device" to the value "Debug";
Build project;
Flash firmware;
Plug USB cable;
Restart MCU;

Expected behavior
In the Linux shell type the dmesg and it should  printout:
   usb 9-1: new full-speed USB device number 112 using uhci_hcd
   usb 9-1: New USB device found, idVendor=8086, idProduct=f8a1
   usb 9-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
   usb 9-1: Product: CDC-ACM
   usb 9-1: Manufacturer: Intel
   usb 9-1: SerialNumber: 00.01
   cdc_acm 9-1:1.0: ttyACM1: USB ACM device

Impact
In fact the Linux OS does not enumerate device -- the device newer send the answer to the host.
Logs and console output
The dmesg on host shows this
[ 6192.854409] usb 3-2: new full-speed USB device number 2 using xhci_hcd
[ 6192.994432] usb 3-2: device descriptor read/64, error -71
[ 6193.241087] usb 3-2: device descriptor read/64, error -71
[ 6193.477736] usb 3-2: new full-speed USB device number 3 using xhci_hcd
[ 6193.611085] usb 3-2: device descriptor read/64, error -71
[ 6193.854425] usb 3-2: device descriptor read/64, error -71
[ 6193.961150] usb usb3-port2: attempt power cycle
[ 6194.367734] usb 3-2: new full-speed USB device number 4 using xhci_hcd
[ 6194.367815] usb 3-2: Device not responding to setup address.
[ 6194.575253] usb 3-2: Device not responding to setup address.
[ 6194.784392] usb 3-2: device not accepting address 4, error -71
[ 6194.907727] usb 3-2: new full-speed USB device number 5 using xhci_hcd
[ 6194.908250] usb 3-2: Device not responding to setup address.
[ 6195.114461] usb 3-2: Device not responding to setup address.
[ 6195.321064] usb 3-2: device not accepting address 5, error -71
[ 6195.321142] usb usb3-port2: unable to enumerate USB device

The log on the MCU side is:
*** Booting Zephyr OS build v3.3.99-ncs1-1 ***
[00:00:00.522,308] <inf> cdc_acm_echo: Wait for DTR
[00:00:00.526,428] <inf> usb_cdc_acm: Device suspended
[00:00:00.627,410] <inf> usb_cdc_acm: Device resumed
[00:00:00.681,884] <inf> usb_cdc_acm: Device suspended
[00:00:00.694,000] <inf> usb_cdc_acm: Device resumed
[00:00:02.076,873] <inf> usb_cdc_acm: Device suspended
[00:00:02.150,695] <inf> usb_cdc_acm: Device resumed
[00:00:03.439,880] <inf> usb_cdc_acm: Device suspended

But when Debug level is activated it is:
*** Booting Zephyr OS build v3.3.99-ncs1-1 ***
[00:00:00.591,003] <dbg> usb_device: usb_enable: lock usb_enable_lock mutex
[00:00:00.591,125] <dbg> usb_device: composite_setup_ep_cb: set cb, ep: 0x81
[00:00:00.591,125] <dbg> usb_device: composite_setup_ep_cb: set cb, ep: 0x1
[00:00:00.591,156] <dbg> usb_device: composite_setup_ep_cb: set cb, ep: 0x82
[00:00:00.591,186] <dbg> usb_device: usb_enable: unlock usb_enable_lock mutex
[00:00:00.591,186] <inf> cdc_acm_echo: Wait for DTR
[00:00:00.595,245] <inf> usb_cdc_acm: Device suspended
[00:00:00.696,472] <inf> usb_cdc_acm: Device resumed
[00:00:00.696,472] <inf> usb_cdc_acm: from suspend
[00:00:00.826,446] <dbg> usb_device: usb_handle_control_transfer: ep 0x00, status 0x00
--- 23 messages dropped ---
[00:00:00.829,254] <dbg> usb_device: usb_handle_control_transfer: ep 0x00, status 0x00
[00:00:00.829,284] <dbg> usb_device: custom_handler: bRequest 0x06, wIndex 0x0000
[00:00:00.829,284] <dbg> usb_device: usb_get_descriptor: Get Descriptor request
[00:00:00.829,315] <wrn> usb_device: Failed to write endpoint buffer 0x80
[00:00:00.829,315] <wrn> usb_device: Failed to write endpoint buffer 0x80
[00:00:00.829,345] <wrn> usb_device: Failed to write endpoint buffer 0x80
[00:00:00.829,376] <wrn> usb_device: Failed to write endpoint buffer 0x80
[00:00:00.832,336] <dbg> usb_device: usb_handle_control_transfer: ep 0x00, status 0x00
[00:00:00.832,366] <dbg> usb_device: custom_handler: bRequest 0x06, wIndex 0x0000
[00:00:00.832,366] <dbg> usb_device: usb_get_descriptor: Get Descriptor request
[00:00:00.832,397] <wrn> usb_device: Failed to write endpoint buffer 0x80
[00:00:00.832,427] <wrn> usb_device: Failed to write endpoint buffer 0x80
[00:00:00.832,458] <wrn> usb_device: Failed to write endpoint buffer 0x80
[00:00:00.832,458] <wrn> usb_device: Failed to write endpoint buffer 0x80

....
....
....
[00:00:03.206,298] <inf> usb_cdc_acm: Device suspended

Environment (please complete the following information):

OS: Linux, Manjaro
Toolschain zephyr-sdk-0.16.1
nrf SDK 2.4.1 same with 2.4.0 and 2.2

You're using NCS, bugs for that go to https://devzone.nordicsemi.com/
If you can reproduce the issue with zephyr i.e. not NCS, then the bug should be reported here

NCS issue or issue caused by the user.

NCS issue or issue caused by the user.


Convert to template repository?

Now that GitHub has template repositories, I wonder if it would make sense to create and maintain one for the community under https://github.com/ietf/. Do you think what you have provided here could be the basis of something like that?

I think making a template is a cool idea. I'm not sure if these scripts -- which really don't do all common workflows, aren't porable, and aren't neatly python-packaged -- are the way to do.  Martin's stuff is key, and your docker image also. I think longer-term this should get finished (yeah, passive voice) and perhaps end up in your docker image?
But maybe I don't understand what you're thinking of.


Fix sites that use about:blank redirect technique

When you open some links with Google Calendar, instead of opening the link directly, the site opens a new window with the location 'about:blank' and then sets the new window's document content to include a refresh directive to open the actual link. This change handles these 'about:blank' windows specially by opening them hidden and then closing them entirely once they finish loading.

This works properly for me in the case where the redirect is to an external link, but I'm not sure what it would do if the redirect is not to an external link. I could make the window.close() conditional on something, but I'm not sure what. In any case, the current behavior is that clicking the link does absolutely nothing, so even if this PR isn't perfect, it seems to be significantly better than nothing.

@bacongravy I was following you until you wrote "and then closing them entirely once they finish loading". What are those links and what do they do, if they're opened then quickly closed?

Sorry, this was part of a bigger change I’m working on and I tried to cherrypick just this fix but it is nonsense in its current form.  I’ll re-push something later that actually makes sense. Sorry for the confusion.

I've updated the branch.
Without this change, the links in Google Calendar do nothing when clicked, because 'about:blank' is passed to shell.openExternal(), which does nothing with it.
This change consists of three commits.
In the first, the linkIsInternal() function has been updated to treat 'about:blank' links as internal so that the redirect technique can work at all. However, while this works, the redirect itself causes another window to be opened (in the external browser, or in a new tab if tabs are enabled), leaving behind a blank, useless window in the nativefier app.
The second commit ensures that the subsequent redirect opens an external window even if tabs are enabled. External links should always be opened externally.
The third commit implements logic to hide the 'about:blank' window until the redirect occurs, at which point it closes the window, thereby avoiding the problem of the blank, useless window being left behind.


need a quick way to rebuild all indexes in a database

For some reason when I import AW CRM database, the bacpac import process hangs on the index enable step. I'm left with all indexes disabled. It's probably some kind of Azure-SSMS version mismatch. Then things go weird running app locally (duplicates allowed, FKs violated). SSMS doesn't have a command to rebuild all indexes at once that I can see. You can rebuild individual tables, but that's really tedious.
I envision a new ScriptGen abstract class that can be implemented for specific tasks that require script gen based on sys info. This would let me extend it for new tasks that require script gen. The UI would show a menu of available ScriptGen classes.

here's example

here's example

available in v1.3.26

available in v1.3.26


Code Sample Not Working: zip File being Downloaded

Issue description
The URL provided downloads a zip file when used with HttpClient for me.  This means the code sample doesn't work, since it expects plain text.  The URL was updated recently by issue #14911.
Am I missing something or is it broken?

[X ] .NET Core 3.0
[X ] .NET Framework 4.8
[ ] .NET Standard

edit by @mairaw: added topic details

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3aeee012-d49e-e096-229c-44d38063b34f
Version Independent ID: 86f4283b-fd68-22b5-c546-afe3c554d434
Content: Walkthrough: Creating a Dataflow Pipeline
Content Source: docs/standard/parallel-programming/walkthrough-creating-a-dataflow-pipeline.md
Product: dotnet
Technology: dotnet-standard
GitHub Login: @BillWagner
Microsoft Alias: dotnetcontent

Thanks for your feedback @rich-newman. We'll have to look into this issue.

@rich-newman I also tried this example out tonight and changed the HttpClient-part to following as a quickfix:
HttpClientHandler handler = new HttpClientHandler()
{
AutomaticDecompression = DecompressionMethods.GZip | DecompressionMethods.Deflate
};
return await new HttpClient(handler).GetStringAsync(uri);


IPMI RMCP Encryption related TC automation

https://github.com/openbmc/openbmc/issues/870
Based on discussion in yesterday's call with Tom/Andrew/rest of development, Decided to automate scenarios related to IPMI .

@rahulmah  Any update here?

@sivassrr : Now we have support sending encrypted ipmi command. This is how most customer will be using. So we should also be running all out test cases with RMCP encryption. Currently we send unencrypted IPMI command using "-C 1".  For encrypted IPMI command we should be using "-C 3" option.
I have checked in the code using https://gerrit.openbmc-project.xyz/#/c/2896/


FilePicker : Add clearAll story

This PR add clearAll docs to storybook.

Codecov Report

Merging #532 (d7fdfd7) into main (a576106) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #532   +/-   ##
=======================================
  Coverage   96.34%   96.34%
=======================================
  Files          70       70
  Lines         847      847
  Branches      124      124
=======================================
  Hits          816      816
  Misses         29       29
  Partials        2        2

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoeyDjr
By the way, I missed a comment in my review, I think we should rename also the clearAll property into showClearAll because the purpose is completely different depending on the name used.
clearAll  refers to the action itself
showClearAll refers to the display of the button

@JoeyDjr By the way, I missed a comment in my review, I think we should rename also the clearAll property into showClearAll because the purpose is completely different depending on the name used.

@fredericvilcot I agree with this. We should consider the change to be clean on the intent carried by this property.

@JoeyDjr By the way, I missed a comment in my review, I think we should rename also the clearAll property into showClearAll because the purpose is completely different depending on the name used.
clearAll refers to the action itself showClearAll refers to the display of the button
What do you think @ccamel @lolottetheclash @ErikssonJoakim ?

I agree but IMO something like hasClearAll makes more sense

@JoeyDjr By the way, I missed a comment in my review, I think we should rename also the clearAll property into showClearAll because the purpose is completely different depending on the name used.
clearAll refers to the action itself showClearAll refers to the display of the button
What do you think @ccamel @lolottetheclash @ErikssonJoakim ?

I agree but IMO something like hasClearAll makes more sense

Or maybe isClearable?

@JoeyDjr By the way, I missed a comment in my review, I think we should rename also the clearAll property into showClearAll because the purpose is completely different depending on the name used.
clearAll refers to the action itself showClearAll refers to the display of the button
What do you think @ccamel @lolottetheclash @ErikssonJoakim ?

I agree but IMO something like hasClearAll makes more sense

Or maybe isClearable?

I think we loose the "all" aspect with this name
I think showClearAll is the best, or displayClearAll


Add lt/gt to SimpleLazyObject

Discussion: https://code.djangoproject.com/ticket/29772

Quite frankly, id like to commit this into 1.11+ and then merged with the higher versions -- if its at all possible.

@kingbuzzman that's not going to happen per our backport policy https://docs.djangoproject.com/en/2.1/internals/release-process/#supported-versions-policy

@charettes ok. No worries.

@kingbuzzman please rebase your PR against the master branch. This is not going to be backported to 2.0 or 2.1 either. It should be in 2.2.

@charettes would this be master?

o_O i don't know what happened, when i rebased it closed the PR, it sorry for the spam

@charettes how do i rebuild tests again? The closing/opening/rinse/repeat i did by mistake, caused 2 of the tests to abort and thus fail.

@kingbuzzman it looks like you're in a good spot now, the mariadb tests are know to fail from time to time so I wouldn't worry about it.

As a follow up. For all those of you that want to use this right now:
Add patch code somewhere at startup:
# Patch code start
import django
from distutils.version import LooseVersion

if LooseVersion(django.__version__) < '2.2':
    import operator
    django.utils.functional.SimpleLazyObject.__lt__ = django.utils.functional.new_method_proxy(operator.lt)
    django.utils.functional.SimpleLazyObject.__gt__ = django.utils.functional.new_method_proxy(operator.gt)
else:
    raise Exception("We made it to 2.2! We can officially delete this patch code now :D")

# Patch code end

The "patch" will alert you when you can delete it.
Then just use it.
# Example:

import datetime
from django.utils.functional import SimpleLazyObject
from django.core.validators import MinValueValidator
from django import forms

min_date_today_validator = MinValueValidator(SimpleLazyObject(datetime.date.today))

class ExampleForm(forms.Form):
    name = forms.CharField(required=True)
    dob = forms.DateField(required=True, validators=[min_date_today_validator])

# Will show you the error...
print(ExampleForm({'name': 'John', 'dob': datetime.date.today() - datetime.timedelta(days=1)}).errors)

# Other examples..
min_date_today_validator(datetime.date.today() + datetime.timedelta(days=1))
min_date_today_validator(datetime.date.today())
# Will raise a validation error
min_date_today_validator(datetime.date.today() - datetime.timedelta(days=1))


Train model on Google colab with TPU

Thanks for the tutorials. I've achieved to get the training work on Google colab in a runtime with setted GPU. In the object_detection folder there is a script to train the model with Google's tpu  (model_tpu_main.py). When I start this script with the same flags you've used in the model_main.py, it surprisingly is detecting the tpu. But it crashes because a mismatch

INFO:tensorflow:TPU job name tpu_worker
I1122 02:07:09.691519<PHONE_NUMBER>95168 tpu_estimator.py:506] TPU job name tpu_worker
INFO:tensorflow:Graph was finalized.
I1122 02:07:13.428853<PHONE_NUMBER>95168 monitored_session.py:240] Graph was finalized.
ERROR:tensorflow:Error recorded from training_loop: From /job:tpu_worker/replica:0/task:0:
Unsuccessful TensorSliceReader constructor: Failed to get matching files on /root/datalab/pretrained_model/model.ckpt: Unimplemented: File system scheme '[local]' not implemented (file:
'/root/datalab/pretrained_model/model.ckpt')

Do you maybe now why? Do I have to use different flags? Or do you know another way to train on Google colab with tpu?

Didn't try it myself but it seems like you need to pass it a tpu_zone flag. I will try it out myself when I find the time.
It would also be good if you ask the question on the official tensorflow models repository so more people can see it.

Thanks for the tutorials. I've achieved to get the training work on Google colab in a runtime with setted GPU. In the object_detection folder there is a script to train the model with Google's tpu (model_tpu_main.py). When I start this script with the same flags you've used in the model_main.py, it surprisingly is detecting the tpu. But it crashes because a mismatch

INFO:tensorflow:TPU job name tpu_worker
I1122 02:07:09.691519<PHONE_NUMBER>95168 tpu_estimator.py:506] TPU job name tpu_worker
INFO:tensorflow:Graph was finalized.
I1122 02:07:13.428853<PHONE_NUMBER>95168 monitored_session.py:240] Graph was finalized.
ERROR:tensorflow:Error recorded from training_loop: From /job:tpu_worker/replica:0/task:0:
Unsuccessful TensorSliceReader constructor: Failed to get matching files on /root/datalab/pretrained_model/model.ckpt: Unimplemented: File system scheme '[local]' not implemented (file:
'/root/datalab/pretrained_model/model.ckpt')

Do you maybe now why? Do I have to use different flags? Or do you know another way to train on Google colab with tpu?

@eneshb Could you share how you managed to use the GPU setting to run the Tensorflow object detection API? It seems like the readme here doesn't come with instructions to set up GPU.

To enable GPU in Google Colab you need to go to Runtime > Change runtime type and select GPU.
Regarding the Tensorflow Object Detection API, it will automatically use GPU if Tensorflow detects and compatible GPU.

Found the following stackoverflow question on the topic:
https://stackoverflow.com/questions/51965950/tensorflow-object-detection-api-w-tpu-training-display-more-granular-tensorbo
I will close this issue for now. If you find any further information feel free to at it here.

You should put the checkpoint folder to Google cloud storage as gs:// to train with TPU

Also take a look at the new Training and Evaluation with TensorFlow 2 documentation, which includes a training with TPU section.

Hi Gilbert, I just started exploring  TF2 OD - So just wanted to check whether there are any tutorial or step-by-step guide for  retraining a pretrained model from model zoo using TPU on google colab?  Everything i could find on google is referring to TPU setup on GCS.  I am successful in retraining on colab using CPU/GPU  but could not progress with TPU.   Any pointers will be of great help.
Thanks
Satya

Hey Satya,
I also only saw TPU scripts that are using Google Cloud and I personally haven't tried using TPU. Maybe it's best to create a issue for the official repository so more people can help you.

Thanks Gilbert for the quick reply. I did some trials and noted that the following is working to train on a TPU in google colab - However it needs the training data as well as the checkpoints to be stored on GCS which is not very convenient.
!python ../models/research/object_detection/model_main_tf2.py
--use_tpu = true
--pipeline_config_path=XXXXXXXXXX
--model_dir=XXXXXXXXXXXXXXXXX
--num_train_steps=XXXXXX
--num_eval_steps=XXX
--training=true
We just need to change the Runtime to TPU in Colab and then the model_main_tf2.py has some initialization code which automatically recognizes the TPU name etc., which is very convenient.
One more observation - if we call model_tpu_main.py directly, it throws some exceptions. Hence model_main_tf2.py is the best way.
With the above command, i could proceed further but did not proceed to actual training as i do not have access to GCS.
It would have been better if we get some facility to use the file system on colab itself for self-learning projects. I will check for any clues in the official repository.
Thanks
Satya


Add flags to set policy err handling

Adding flags to kopia policy set for file and directory read error handling.
Flag value can be true, false, or inherit. Manually tested the different combinations to ensure it was inheriting properly when not explicitly set in a given policy. Opening PR for early feedback to confirm this is the right direction for controlling this behavior.

I understand it's a WIP, the approach seems reasonable.
Comment's above are early feedback.

I just merged https://github.com/kastenhq/kopia/pull/35, so this branch now contains the entire fix. @julio-lopez can you take a final look when you get a chance before I open upstream?

CI failed again for failed with read |0: file already closed

LGTM  ✅
🚢it :shipit:


wayland: 1.19.0 -> 1.20.0

Motivation for this change
Announcements:

Alpha: https://lists.freedesktop.org/archives/wayland-devel/2021-November/042026.html
Beta: https://lists.freedesktop.org/archives/wayland-devel/2021-November/042036.html
RC1: https://lists.freedesktop.org/archives/wayland-devel/2021-December/042053.html

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I haven't investigated this yet but it looks like a regression:
  LTLINK build/libSDL2.la
/nix/store/js66s0xwjnzg0ggi2lq9bcvlk6x2za13-binutils-2.35.2/bin/ld: build/.libs/SDL_waylanddatamanager.o: in function `wl_data_source_destroy':
/build/SDL2-2.0.14/gen/wayland-client-protocol.h:2353: undefined reference to `wl_proxy_marshal_flags'
/nix/store/js66s0xwjnzg0ggi2lq9bcvlk6x2za13-binutils-2.35.2/bin/ld: build/.libs/SDL_waylanddatamanager.o: in function `wl_data_offer_receive':
/build/SDL2-2.0.14/gen/wayland-client-protocol.h:2040: undefined reference to `wl_proxy_marshal_flags'
/nix/store/js66s0xwjnzg0ggi2lq9bcvlk6x2za13-binutils-2.35.2/bin/ld: build/.libs/SDL_waylanddatamanager.o: in function `wl_data_offer_destroy':
/build/SDL2-2.0.14/gen/wayland-client-protocol.h:2052: undefined reference to `wl_proxy_marshal_flags'
/nix/store/js66s0xwjnzg0ggi2lq9bcvlk6x2za13-binutils-2.35.2/bin/ld: build/.libs/SDL_waylanddatamanager.o: in function `wl_data_device_set_selection':
/build/SDL2-2.0.14/gen/wayland-client-protocol.h:2624: undefined reference to `wl_proxy_marshal_flags'
/nix/store/js66s0xwjnzg0ggi2lq9bcvlk6x2za13-binutils-2.35.2/bin/ld: build/.libs/SDL_waylanddatamanager.o: in function `wl_data_source_offer':
/build/SDL2-2.0.14/gen/wayland-client-protocol.h:2341: undefined reference to `wl_proxy_marshal_flags'
/nix/store/js66s0xwjnzg0ggi2lq9bcvlk6x2za13-binutils-2.35.2/bin/ld: build/.libs/SDL_waylanddatamanager.o:/build/SDL2-2.0.14/gen/wayland-client-protocol.h:2341: more undefined references to `wl_proxy_marshal_flags' follow
collect2: error: ld returned 1 exit status
make: *** [Makefile:154: build/libSDL2.la] Error 1

@ofborg test sway
The Sway test passes now but there might be a few additional regressions (that we'll likely have to catch and fix later as this causes too many rebuilds to test - feel free to ping me if you notice some).

Ok, let's give this a try. I'm not aware of any other regressions. I've confirmed the Firefox fix by building firefox and firefox-esr as well as running nixosTests.firefox.


upgrade.el: force fetch

doom-cli-upgrade calls git fetch to fetch remote branch and tags and check output code of this command to complain when it failed.
It fails when remote server isn't available that is good.
But it also fails when it can't to fast-forward a branch that will be used to upgrade doom-emacs.
The last case created a loop and the only way to broke this loop is remote a branch that should be used for upgrade.
Unfortunately user has no idea about branch name and can't do anything, just enjoy crash with Failed to fetch from upstream message.
This commit added --force flag to git fetch that forces it to overwrite branch that is used to upgrade that prevent such loop.
It also fixed https://github.com/hlissner/doom-emacs/issues/4346

Thanks for the help!


Pretrained tsm model cannot be downloaded

Thanks for releasing the code. I found the pretrained tsm model at [https://file.lzhu.me/projects/tsm/models/TSM_kinetics_RGB_resnet50_shift8_blockres_avg_segment8_e100_dense.pth] is missing at the moment. Please fix it : )

See #4 .


Deprecate ModelFilter/DatasetFilter and remove GeneralTags/ModelTags/DatasetTags

From private slack thread. Listing models and datasets on the Hub with filters and tags is overkill at the moment which brings bugs (latest one here) and code complexity both in huggingface_hub and user-side (list_models(filter=ModelFilter(author="HuggingFaceBR4", tags=["tensorboard"])) instead of list_models(author="HuggingFaceBR4", filter="tensorboard").
2 things we can do here:

completely drop GeneralTags/ModelTags/DatasetTags enums => those are >2y old and not suited anymore (requires to list ALL models from the Hub before making a selection) => already not much documented anymore
deprecate ModelFilter/DatasetFilter and simplify their logic. Goal would be to pass the arguments directly to list_models/list_datasets instead of an intermediate object.

This can be done in 2 separate PRs. For each PR, in addition to the logic change,  documentation and tests should be updated.

Can I claim this?

Yes! It would be best to start by the removal of the ModelTags, DatasetTags and GeneralTags. Please let me know if you have any questions or if something is not clear enough. Thanks in advance for your contribution!

Cool, will start working today.

Hi, since this issue has been left open for a bit now, I'd like to pick it up :)

I would think to completely remove author from the ModelFilter as well

Hi @druvdub, first of all thanks for proposing your help on this! It is perfectly fine to take this issue yes, as it's still a topic to tackle :)
These are good questions that I'll try to answer but first, we should distinguish two things:

what we aim for as a consistent API e.g. the final result
what we should do to reach that API without breaking existing usage

In practice, this means we will make changes twice. In a first PR we should allow the new behavior while deprecating the legacy one. In a follow-up PR (in a few months), we will completely remove the existing behavior. This transition period should allow users to adapt to the new API, or at least freeze their dependencies.

Should I just be aiming to deprecate the classes, i.e. just add a Deprecation Warning for these filters so that people can still use them but see the warnings as well or should I be looking to completely remove them.

As said above, supporting the classes while adding deprecation warnings when used is the way to go.

It accepts an author in filter as well as an author argument, does this not cause a conflict when looking up results?

Yep, good catch. This inconsistency is most likely due to legacy work on this part of the code. At the moment it seems that the author parameter is forwarded to the server as ?author={author} while the author in the filter class is forwarded as ?search={author/}. If both are set to different values, I would expect the response to be empty. What we should aim for is to support only the ?author={author} syntax from the main author parameter. And since you'll be deprecating the usage of the ModelFilter class, we will get rid of the inconsistency in a few months.

I wonder how would we want to handle if a user passes both an Iterable in filter and other filter arguments

For now you can build the query with all filters and arguments. Worse case scenario, the filters conflict with each other and the result is an empty list. In that case the user will have to adapt their query (which is fine). The raw arguments (passed to list_models) should keep precedence over the ModelFilter argument, as it's currently done.

I would think it might be best to completely remove author from the ModelFilter as well

Not for now. In the end we aim at removing ModelFilter altogether. The problem with removing author right now is that it might be used by some users that will see their script broken just by updating the huggingface_hub version. This is why we need to deprecate first and remove later.

now both trained_dataset and library can be string or a list of strings, but if trained_dataset is an empty string or an empty list it would still be added as a parameter whereas library in the same case would not be.

Good catch! Having a consistent behavior between these two arguments would definitely be better :)

Hope I've answered all of your questions. I'll have a look at the PR you've opened. Thanks for the contribution! :hugs:

This issue can be closed by the work from @VictorHugoPilled in https://github.com/huggingface/huggingface_hub/pull/2028 and from @druvdub in https://github.com/huggingface/huggingface_hub/pull/1761. Thanks everyone!


Adding a Table Design Component

Hello,
I'm really impressed with the project. I'd like to contribute by adding a new table design component to the project, which I believe would be a valuable addition for users.
Before I start working on it, I wanted to seek guidance on the best way to proceed. Could you please provide me with some insights or guidelines on how to add new components to the project? Any advice or specific requirements you have for contributions would be greatly appreciated.
I'm eager to contribute and ensure that the table design aligns with the project's standards and goals. Your guidance will be invaluable in helping me get started on the right track.
Thank you for your time, and I'm looking forward to your response.
Best regards,
MD Jamil
DEMO::

Hey there @mdjamilkashemporosh,
I have a blog post on the site about how you can contribute to the project, take a look - https://www.hyperui.dev/blog/how-to-contribute, if you have any further questions then please let me know.


Incompatible with cmake 3.19

-- Configuring done
CMake Error: install(EXPORT "aws-c-common-targets" ...) includes target "aws-c-common" more than once in the export set.
-- Generating done

Seems to build fine with cmake-3.18.4
related posts:

stackoverflow: https://stackoverflow.com/questions/64507009/aws-cpp-sdk-fails-during-windows-build-due-to-installexport-foo-targets
nixpkgs: https://github.com/NixOS/nixpkgs/pull/104637#pullrequestreview-537802100

Related: microsoft/vcpkg#14716

This affects multiple AWS C/C++ projects such as aws-c-event-stream as well.

This is a cmake issue, see discussion https://discourse.cmake.org/t/error-when-installing-targets-and-exports-in-3-19-1/2245/6

This should be fixed in the 3.19.2 release of cmake, closing


realloc: handle zero-length arrays.

We saw a problem in devacpi.c when realloc was called
to create a zero-length array: it returned a nil pointer,
not a pointer to a zero-length array, which confused the caller.
Consider the difference between:
char *s = "";
char *s = nil;
The first is a pointer to a zero-length string, the second
a NULL pointer. We want realloc to implement the first,
rather than the second.
Signed-off-by: Ronald G. Minnich<EMAIL_ADDRESS>

Uh oh language lawyer comments ahead:
The thing about:
Consider the difference between:
char *s = "";
char *s = nil;

In the case of 'char *s = "";', 's' actually points to an array of char of length 1, as the '\0' is implicit. Perhaps what we want is something closer to 'char t[0]; char *s = t;'. Unqualified 't' decays to a pointer to a zero-length array object, and 's' is a pointer that object.
The OpenBSD man page for 'reallocarray()' includes this:
'If size or nmemb is equal to 0, a unique pointer to an access protected,
zero sized object is returned.  Access via this pointer will generate a
SIGSEGV exception.'
I think we should return the result of 'malloc(0);' to account for Harvey's 'realloc(p, 0);' returning nil.

It looks good to me, but please do use a logical OR instead of multiplication in the test. I'd shorten the comment, but wordsmith it as you see fit.


Empty results from Waters Synapt HDMS (G1) data

Searching Synapt HDMS (G1)  DDA data (without ion mobility) yields empty results (0 peptides/proteins identified) using MetaMorpheus 0.0.297.
Data
Acquired in a Synapt HDMS (G1) Survey (DDA) in V mode (resolution = 9,000 FWHM), continuum. The .RAW data file was converted to mzML using msconvert (ProteoWizard 3.0.18353-2de7e414e) with peakpicking/centroiding enabled. I have already obtained identifications with MS-GF+ (R package) with a tolerance of 20 ppm.
MetaMorpheus settings
protease = trypsin; maximum missed cleavages = 2; minimum peptide length = 7; maximum peptide length = unspecified; initiator methionine behavior = Variable; fixed modifications = Carbamidomethyl on C, Carbamidomethyl on U; variable modifications = Oxidation on M; max mods per peptide = 2; max modification isoforms = 1024; precursor mass tolerance = ±20.0000 PPM; product mass tolerance = ±20.0000 PPM; report PSM ambiguity = True. The combined search database contained 35663 non-decoy protein entries including 230 contaminant sequences. Data files were processed on a ASUSTeK COMPUTER INC. K45VD computer using Windows version 6.2.9200.0 with a 64-Bit processor and 8 cores operating at 2,295GHz and 6GB installed RAM. The total time to perform the Search task on 3 spectra file(s) was 13,84 minutes.

Thanks for the bug report - MSConvert .mzML is supported and almost always works in MM, though we've gotten one report where recent versions of MSConvert create .mzML files that cause issues in MM. Can you share this file with us for debugging purposes?

Thank you for answering. Please find the .RAW and .mzML files in the following link. The RAW is too big to be attached.

Sorry this has taken so long to investigate. This issue looks like it's being caused because of problems getting the precursor ion's mass. An m/z is reported, but no charge, and the isolation window itself is not reported so there's no easy way to get precursors via deconvoluting the isolation window.
Usually MSConvert provides this info to us via the mzML file, but it looks like it's not there. I guess in these cases we could deconvolute a static 1 or 2 m/z window around the isolated m/z and report the most probable charge/mass. Fair warning, it may be a while before this is working, though.

This file has some weird looking MS1 data, so even the "deconvolution guess" approach I discussed above probably won't work. I suppose you could just blindly guess at charge states randomly but this seems like a poor approach. Do you know why this MS1 data is so strange looking, and why the instrument controller doesn't guess precursor charges?

Hello Robert,
I’m sorry for the delay on my answer .
We have recently obtained Progenesis for Proteomics (Waters – NonLinear
Dynamics), thus I will be using this software to obtain my identifications.
Anyway, I sincerely appreciate your help and the time you took to evaluate
the problem.
I agree in the fact that the problem may come from the absence of charge
state annotation in the MS1 because I have encountered a similar problem
when using SearchGUI. This happens even when I use charge prediction in
MS-convert. Nevertheless, SearchGUI do make an automatic assignment of the
charge and it is working correctly.
What do you mean with weird looking MS1?
I had some problems with the nanospray, which was clogged several times
during the analysis (it was one of my first times using this nanoLC which
was not used for 10 years). I think the instrument controller (MassLynx
from Waters) do guess precursor charge, but maybe it is not being saved or
it is not recovered when converted to mzML. I don’t know if this is a
specific problem of my instrument of it is general to Waters data, which is
often difficult to convert to open formats.
Kind regards,
David
Le ven. 14 juin 2019 à 14:44, Robert Millikin<EMAIL_ADDRESS>a
écrit :

Closed #1614 https://github.com/smith-chem-wisc/MetaMorpheus/issues/1614
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/smith-chem-wisc/MetaMorpheus/issues/1614?email_source=notifications&email_token=ALXYABDEUR5Z47EM2WQ3N3TP2PYJBA5CNFSM4HDNPXUKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOR7WODWQ#event-2414666202,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALXYABCXWTZ5M5HPUY56BXLP2PYJBANCNFSM4HDNPXUA
.


Mistake in espresso cheat sheet

hasMultilineText() mispelled to hasMultilineTest() in the USER PROPERTIES

Good catch! Will make sure it's fixed for the next version, probably not big enough for a 2.1.1 ;)

(Closing because it's not really an issue with the samples.)


Update README.md

On windows 10 dev dependencies for vite failed to install. Using npm install --only=dev fixed the issue.

That sounds more like an install issue. What is the error you see? Please open a bug report instead.


Non valid 07 french mobile number (+33 7 {{phoneNumber07WithSeparator}})

I am using Faker v1.7.1 with PHP 7.1
The following code can return +33 7 {{phoneNumber07WithSeparator}} instead of a valid 07 french mobile number.
use Faker\Factory as Faker;

$faker = Faker::create('fr_FR');
echo $faker->mobileNumber; // +33 7 {{phoneNumber07WithSeparator}}

Fixed by #1304


Add secret scanning to SCM guide, fixes #488

@SecurityCRob - comments?
I did not try to edit best-practices.yml. I'm not sure what that yml file is doing. Is that the source & the README is generated? I don't see any code to do the generation. If the .yml file is generated from the README, then please run that tool. If they're edited simultaneously, well, yuck :-(. In any case, there should be a clear document somewhere what their relationship is.

@SecurityCRob - comments?
I did not try to edit best-practices.yml. I'm not sure what that yml file is doing. Is that the source & the README is generated? I don't see any code to do the generation. If the .yml file is generated from the README, then please run that tool. If they're edited simultaneously, well, yuck :-(. In any case, there should be a clear document somewhere what their relationship is.

I think Randall put that in place.  I'm also unsure how that works.  We should ask him to start.

@SecurityCRob - comments?
I did not try to edit best-practices.yml. I'm not sure what that yml file is doing. Is that the source & the README is generated? I don't see any code to do the generation. If the .yml file is generated from the README, then please run that tool. If they're edited simultaneously, well, yuck :-(. In any case, there should be a clear document somewhere what their relationship is.

I think Randall put that in place. I'm also unsure how that works. We should ask him to start.

I think that might relate to how the Legitify was used to produce these recommendations. maybe @noamd-legit  can comment on this and suggest how to add new ones?

In that case, I suggest removing the .yml file (in a separate pull request). We generally don't want generated files in the source repo.
@noamd-legit - would you mind creating that PR?

@david-a-wheeler
Removed the file here: https://github.com/ossf/wg-best-practices-os-developers/pull/508


Prevent multiple app instances

I have tray icon twice. Please prevent it.

Close one of the applications.
The benefits of multiple instances far outweighs the cons.


all: dashify css selectors

We have a mix of camel case. I think we should do this before we do a breaking change release for the CSS. Get it all the same breaking change.
eg,
.button--iconOnly
to
.button--icon-only
Would probably add this as a css refactor list item.
It's also important for us to recognize that exposing our css selectors as first class citizens will make them public api. Thus, changes to them will be breaking changes into the future. Another reason to refactor at this point.

Of course, this might call into question the core vars.  I'm less sure of this:
eg, should we?:
--psTypeFontSize700
to:
--ps-type-font-size-700

I prefer dash case always in css.

Did checks along the way in the conversion. Marking done.


#68 - Issue 26 improvement in recycler view performance.

Fixes Issue
Fixed the issue , by implementing listAdapter and DiffUtil.ItemCallback class.
Note to reviewers
Some changes have been observed in gradle file and other file stuff, this happened as I pulled the changes from the master branch of project's repository.

Please let me know,If there is any mistake.Thank you.

@Ivan2001otp you could have added more commits to the previous PR, would have been easier to track the requested changes
Nice work by the way.
Hope you have learned something new.

Thank you sir.
On Sat, Jun 10, 2023 at 6:36 PM Vaibhav Jaiswal @.***>
wrote:

@Ivan2001otp https://github.com/Ivan2001otp you could have added more
commits to the previous PR, would have been easier to track the requested
changes
Nice work by the way.
Hope you have learned something new.
—
Reply to this email directly, view it on GitHub
https://github.com/Taaveez/Taaveez-android/pull/70#issuecomment-1585656620,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWYXRHTRXDJHBZ7JPFOMNZ3XKRWOBANCNFSM6AAAAAAZBUB7RQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank you sir.
…
On Sat, Jun 10, 2023 at 6:36 PM Vaibhav Jaiswal @.> wrote: @Ivan2001otp https://github.com/Ivan2001otp you could have added more commits to the previous PR, would have been easier to track the requested changes Nice work by the way. Hope you have learned something new. — Reply to this email directly, view it on GitHub <#70 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWYXRHTRXDJHBZ7JPFOMNZ3XKRWOBANCNFSM6AAAAAAZBUB7RQ . You are receiving this because you were mentioned.Message ID: @.>

Are the changes done?

I have updated it,Already. I
On Fri, Jun 16, 2023, 2:40 PM Vaibhav Jaiswal @.***>
wrote:

@Ivan2001otp https://github.com/Ivan2001otp please make the changes
requested, so we can merge this PR
—
Reply to this email directly, view it on GitHub
https://github.com/Taaveez/Taaveez-android/pull/70#issuecomment-1594370513,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWYXRHTTD4ZKNCVEEMQEFX3XLQPGZANCNFSM6AAAAAAZBUB7RQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I will do the changes in the pr.
On Fri, Jun 16, 2023, 2:52 PM Immanuel Dsouza @.***> wrote:

I have updated it,Already. I
On Fri, Jun 16, 2023, 2:40 PM Vaibhav Jaiswal @.***>
wrote:

@Ivan2001otp https://github.com/Ivan2001otp please make the changes
requested, so we can merge this PR
—
Reply to this email directly, view it on GitHub
https://github.com/Taaveez/Taaveez-android/pull/70#issuecomment-1594370513,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWYXRHTTD4ZKNCVEEMQEFX3XLQPGZANCNFSM6AAAAAAZBUB7RQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sir, now you can check,i have removed the commented line you mentioned.
On Fri, Jun 16, 2023, 2:54 PM Immanuel Dsouza @.***> wrote:

I will do the changes in the pr.
On Fri, Jun 16, 2023, 2:52 PM Immanuel Dsouza @.***>
wrote:

I have updated it,Already. I
On Fri, Jun 16, 2023, 2:40 PM Vaibhav Jaiswal @.***>
wrote:

@Ivan2001otp https://github.com/Ivan2001otp please make the changes
requested, so we can merge this PR
—
Reply to this email directly, view it on GitHub
https://github.com/Taaveez/Taaveez-android/pull/70#issuecomment-1594370513,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWYXRHTTD4ZKNCVEEMQEFX3XLQPGZANCNFSM6AAAAAAZBUB7RQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Ivan2001otp what about the remaining changes. I don't see them updated, please check the requested changes above

I have updated it,Already. I
…
On Fri, Jun 16, 2023, 2:40 PM Vaibhav Jaiswal @.> wrote: @Ivan2001otp https://github.com/Ivan2001otp please make the changes requested, so we can merge this PR — Reply to this email directly, view it on GitHub <#70 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWYXRHTTD4ZKNCVEEMQEFX3XLQPGZANCNFSM6AAAAAAZBUB7RQ . You are receiving this because you were mentioned.Message ID: @.>

I think you might have forgot to push the changes, i cannot see the commit or the changes

Fixed. Removed unnecessary comments .
On Fri, Jun 16, 2023 at 3:54 PM Vaibhav Jaiswal @.***>
wrote:

@.**** commented on this pull request.
In app/src/main/java/com/itssuryansh/taaveez/Notes.kt
https://github.com/Taaveez/Taaveez-android/pull/70#discussion_r1232069482
:

@@ -69,17 +85,54 @@ class Notes : AppCompatActivity() {
}

     lifecycleScope.launch {

       NotesDao.fetchAllNotes().collect {

           val list = ArrayList(it)

           setupListOfDateINtoRecycleVIew(list, NotesDao)

           NotesDao.fetchAllNotes().collect {

               /*

               Log.e("ray", "onCreate submit list: $it")

               Log.e("ray", "onCreate size status: ${it.size}")

               Log.e("ray", "onCreate list-empty status: ${it.isEmpty()}")*/

remove these comments
—
Reply to this email directly, view it on GitHub
https://github.com/Taaveez/Taaveez-android/pull/70#pullrequestreview-1483172929,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWYXRHUVYSP6K6NXBHID7BDXLQX4BANCNFSM6AAAAAAZBUB7RQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Please specify what exact changes I have to make in itemAdapter.kt.
On Tue, Jun 20, 2023 at 12:20 PM Vaibhav Jaiswal @.***>
wrote:

@.**** commented on this pull request.
In app/src/main/java/com/itssuryansh/taaveez/itemAdapter.kt
https://github.com/Taaveez/Taaveez-android/pull/70#discussion_r1234813315
:

 override fun onBindViewHolder(holder: ViewHolder, position: Int)  {

     val context = holder.itemView.context

   val item = items[position]

   val item = getItem(position)

@Ivan2001otp https://github.com/Ivan2001otp make the requested changes
bro
—
Reply to this email directly, view it on GitHub
https://github.com/Taaveez/Taaveez-android/pull/70#discussion_r1234813315,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWYXRHTS7QNFNF65KV22YBDXMFB4LANCNFSM6AAAAAAZBUB7RQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Please specify what exact changes I have to make in itemAdapter.kt.
…
On Tue, Jun 20, 2023 at 12:20 PM Vaibhav Jaiswal @.> wrote: @.* commented on this pull request. ------------------------------ In app/src/main/java/com/itssuryansh/taaveez/itemAdapter.kt <#70 (comment)> : > override fun onBindViewHolder(holder: ViewHolder, position: Int) { val context = holder.itemView.context - val item = items[position] + val item = getItem(position) @Ivan2001otp https://github.com/Ivan2001otp make the requested changes bro — Reply to this email directly, view it on GitHub <#70 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWYXRHTS7QNFNF65KV22YBDXMFB4LANCNFSM6AAAAAAZBUB7RQ . You are receiving this because you were mentioned.Message ID: @.***>

Bro please open https://github.com/Taaveez/Taaveez-android/pull/70 and see all the changes requested


json: Test and code cleanup

This should be an easy review. Just directory file reorg, some new test case and docs.

For #3580

Background

Change List

Reorganize json module
Reorganize test cases
Add test cases for JSONConverter
Re-enable "render" test
Improve deprecation guide based on @ajduberstein 	feedback

Coverage increased (+0.3%) to 82.464% when pulling 163c0b96432f96c5cc699d34f86aa849c18149a4 on ib/json-cleanup-2 into 52a9f7674dca186f1eb765de7cb2bfae2980789a on master.


refresh

@rultor release, tag is 0.5.0

@rultor release, tag is 0.5.0

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.5.0

@yegor256 Oops, I failed. You can see the full log here (spent 11s)

@rultor release, tag is 0.5.0

@rultor release, tag is 0.5.0

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.5.0

@yegor256 Done! FYI, the full log is here (took me 1min)


feat: add os segment

Prerequisites

[x] I have read and understand the CONTRIBUTING guide
[x] The commit message follows the conventional commits guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Description
Add new os segment that display an OS specific string which defaults to an icon.

Sorry for the new PR i totally botched the history on the other one.

Sorry for the new PR i totally botched the history on the other one.

If you're good with the property name change, I think this is good to go as a first cut.  I want to add the WSL support to it, as well as more distro icon support instead of just the generic linux Tux, but those can come in future PRs I think.

Let's rebase and ship this one.


Working demo with rendering wordle and live updating via polling via netlify function

Thanks, this is now fully merged up - I see there is a CSS change I failed to pick up too

The file permission of package-lock.json should be 644 instead of 755.

The file permission of package-lock.json should be 644 instead of 755.

Bump.


Class that handles creating and loading a ScriptingProject

We need to have a class that handles all the variables and settings that can potentially be loaded from the savefile. If such a savefile or some values are not present, this class should return the default settings  in the methods.

This is done in the read/write methods withing ScriptingProject and bij making a new ScriptingProject using the constructor. I don't think we need a seperate class for this.


Prevent rebinding s in Info-mode

When I enable evil-snipe and then C-h i, I find that info's usual s binding to search now starts evil-snipe instead.  I want to keep the old binding in that mode.
I'm not able to work around that using Info-mode-hook to call turn-off-evil-snipe-override-mode and/or turn-off-evil-snipe-mode either.  However, using those functions interactively after entering info, I can use the s binding again.
Can you provide some way to keep that old binding?
I was able to reproduce this using emacs 25.1 and no configuration other than basically pointing emacs at where my elpa packages is on disk, then enabling evil and evil-snipe.

Sorry for the late reply. Does this fix your problem?:
(add-to-list 'evil-snipe-disabled-modes 'Info-mode)

I beat you in slow response :-)
It didn't help, unfortunately.  Are you able to reproduce?  As I say, I could reproduce just by enabling evil and evil-snipe after starting with -q.  Do you not see the problem if you try that?

I can easily reproduce it, and I understand why it happens (the evil-snipe-disabled-modes check occurs before the major-mode is set), but I don't understand why the check happens so soon. I'm looking into it though.

Correction, turn-on-evil-snipe-*mode don't seem to be called at all, skipping the evil-snipe-disabled-modes check entirely. Seems like I've misunderstood how define-globalized-minor-mode works. Back to the drawing board!

Reopening: still not sure if it fixed the issue. Still looking into it.

The docstring for define-globalized-minor-mode could really use improvement regarding the fact that the function (usually) automatically associates MODE with MODE-map (regardless of whether that map already exists)--even the docstring for define-minor-mode (which the former function references) doesn't actually convey that.
Anyway, there are very likely better ways of fixing it than this (hence no PR), but, at the least, here's a proof-of-concept (that ought to not break anyone's existing configuration):
(defvar evil-snipe-mode-global-map
  (let ((map (make-sparse-keymap)))
    map))
(defvar evil-snipe-override-mode-global-map
  (let ((map (make-sparse-keymap)))
    map))

;;;###autoload
(define-globalized-minor-mode evil-snipe-mode
  evil-snipe-local-mode turn-on-evil-snipe-mode
  :keymap evil-snipe-mode-global-map)

;;;###autoload
(define-globalized-minor-mode evil-snipe-override-mode
  evil-snipe-override-local-mode turn-on-evil-snipe-override-mode
  :keymap evil-snipe-override-mode-global-map)

(provide 'evil-snipe)
;;; evil-snipe.el ends here

As of https://github.com/hlissner/evil-snipe/commit/3b333c2d85d8306505d0fac4ce99c038aae6533f this issue should be resolved (so long as you add Info-mode to evil-snipe-disabled-modes or attach turn-off-evil-snipe-modetoInfo-mode-hook`).
Feel free to reopen this if that isn't the case.


Request: update referenced ssh2 version

Hi, I was having issues getting sftp to work and, on a whim, updated the version of ssh2 in package.json to the current 0.5.4.  After that, everything worked.  Is this project still supported and, if so, is an update to this effect in the works?  Would you prefer me to fork and set up a pull request?

Hello!
Using that in my package json as workaround:
"grunt-ssh": "https://github.com/israelroldan/grunt-ssh.git#7175b5548291bb2105a33a45d772573cb888430d",

Thx.  I'll leave this open because it's something that @israelroldan needs to address

It is already here https://github.com/israelroldan/grunt-ssh/issues/137


[object Object] in rolling logger log files

Hello,
I am attempting to use your module to log all requests in a simple Node.js application. I have the logger set up as:
var opts = {
    logDirectory: __dirname + '/log',
    fileNamePattern: 'transactions-<DATE>.log',
    dateFormat: 'YYYY.MM.DD'
};

var log = require('simple-node-logger').createRollingFileLogger(opts);

and am logging requests with:
app.use(
    function (req, res, next) {
        log.info(req.originalUrl);
        next();
    }
);

The resulting log files contain [object Object], like 13:34:30.703 INFO  [object Object] / .
Simple file logger entries do not contain [object Object]. I tested with:
var log = require('simple-node-logger').createSimpleFileLogger('project.log');

with resulting entries to be like 13:39:26.030 INFO  /
Any thoughts on what object the rolling file logger is adding to the entries?

This is a bug. You can find the 'path/to/simple-node-logger/lib/SimpleLogger.js' file, and change the code like this:
`this.createLogger = function(category, level) {
var logger;
    var opts = Object.prototype.toString.call(category) === '[object String]' ? options : dash.merge({}, options, category);
    // opts.category  = category ? category : opts.category; // remove it
    // opts.level     = level ? level : opts.level || dfltLevel; // remove it
    opts.appenders = appenders;

    logger = new Logger( opts );
    loggers.push( logger );

    return logger;
};

`

Or you can:
var log = require('simple-node-logger').createLogManager(opts).createLogger()

Fantastic, thank you very much! I hope to be able to create a pull request
to address this as soon as I have time.
Best,
Matt Thomas
203.632.9322
http://betweenbrain.com/
Sent from mobile. Please pardon any typos or brevity.
On Jul 10, 2016 11:33 AM, "天眼前端"<EMAIL_ADDRESS>wrote:

Or you can:
var log =
require('simple-node-logger').createLogManager(opts).createLogger()
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/darrylwest/simple-node-logger/issues/9#issuecomment-231594971,
or mute the thread
https://github.com/notifications/unsubscribe/AAmtB2Jg9hWbDUTMu46jrs3LYWhU4WAaks5qURDMgaJpZM4JBYtE
.

I made a pull request with a simple fix.

I am also having this issue. Thank you for the help.
Also , is there any way we can append a unique id per request .This will be helpful to debug in case of concurrent requests.

This issue seems to still exist today. I had to manually comment out the lines as suggested by skyeyefront.

New version is now in place.  Thanks for fixing this...


Sound?

I played a game to see what updates are about and how it feels. Still no sound?

I created a bookmarklet for a crude temporary workaround - it's unofficial but it seems to work well in Chrome. The file name in the repo is stones.js.
To the admins and project owner - I apologise for mentioning my fiddle in the official project page. hope it is not considered rude. will remove any and all reference if deemed disrespectful.

As temporary workaround I scripted stone sound into this bookmarklet  https://github.com/darkronin/scriptKGS/blob/master/stones.js

There doesn't seem to be any sound (for time remaining) on Mac OS 11.2.3 Safari 14.0.3


Undefined subroutine &Getopt::Long::GetOptionsFromString

When I have Getopt::Long 2.35 installed (perl 5.8.8.) I get this test failure.
After upgrading to Getopt::Long 2.47 it all went fine.
t/noenv.t .................... 1/5
#   Failed test at t/noenv.t line 97.
#                   'Undefined subroutine &Getopt::Long::GetOptionsFromString called at /data/usr/local/src/.cpan/build/ack-2.14-nwXyph/blib/lib/App/Ack/ConfigLoader.pm line 593.'
#     doesn't match '(?-xism:--noenv found in (?:.*)[.]ackrc)'
# [
#   'Undefined subroutine &Getopt::Long::GetOptionsFromString called at /data/usr/local/src/.cpan/build/ack-2.14-nwXyph/blib/lib/App/Ack/ConfigLoader.pm line 593.'
# ]
# Looks like you failed 1 test of 5.
t/noenv.t .................... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/5 subtests

Looks to have been fixed (but not yet released) in https://github.com/petdance/ack2/commit/9f6c3882c2088d261f00a7789134868c0b0e767f.

This will go out in 2.17_01.


Add catalog list download feature

Users should be able to download a list of strains or plasmids as a file. Start with PDF, consider other file types like CSV.

Use a lower size font for displaying the dropdown list.
i) you could add more items to the list
ii) you create a visual distinction
You could even use a different but similar font and a different color to make a subtle visual distinction.


Support for -, >, < tasks statuses

Is your feature request related to a problem? Please describe.
I'm using several themes (Prism, AnuPpuccin, Border, PLN) and among those only Prism doesn't support any task statuses except for [ ] and [x].
Describe the solution you'd like
It would be great if Prism would display tasks with [-], [<], [>] statuses differently from completed ones, like most popular themes do.
Describe alternatives you've considered
Now I'm using emojis to indicate additional task status, but that adds more manual work and makes dataview queries less universal.
Prism display

AnuPpuccin display

Hi @danipolani,
I've addressed a request like this some time ago and my stance still stands. Please refer to that answer here:
https://github.com/damiankorcz/Prism-Theme/issues/20#issuecomment-1312547229
I've not looked into this in some time so I'm not sure if things have "standardised" per say since. For now I'll keep this issue open and you can try using the ITS Checkboxes snippet mentioned in the comment above.

I understand the hesitation to support this natively, but I'm not in love with the suggested snippet's renditions. If there is no standard, why not work to create one by aligning with one of the more popular takes out there? Then you would have at least 2 very popular themes supporting the same alternative checklists. That should compel new (or hopefully even some existing) themes to join in. In fact, we could publish a post on the Obsidian forums or elsewhere promoting this standard.
If you find this argument compelling/inspiring (and I terribly hope you do, as this is the only aspect of Prism that is still nagging me, despite loving everything else about it and not wanting to switch back to alternatives ever again), then I would suggest aligning with the alternative checklists supported by the Minimal theme (which is currently the most downloaded theme, with nearly twice as many downloads as the runner-up):
https://minimal.guide/checklists

If I'm not mistaken, these same 22 checklist styles are also supported by the Things theme and the LYT Mode theme (feels like the beginning of a standard). I think the AnuPpuccin theme and the ITS theme (from which the snippet you suggested comes from) support these 22 and more. Some themes (like Border and Aura) support a majority of these 22.
If nothing else please consider natively supporting the set of alternative checklists in categorized as basics in the image above, as popular plugins like Tasks support these (well, at least the top 4 of the 6).
Thank you for your (re-?)consideration, and for this great theme!

Hi @kaveh-ahmadian and @danipolani,
I decieded to tackle this issue and help align this for everyone, developers and users. I've made a thread here on the Official Obsidian Discord outlining my concerns and efforts to standardise this: https://discord.com/channels/686053708261228577/1291469509336502272
All discussion on this subject will continue there.


publish bootstrap test

[ ] create kubernetes file - https://gitlab.diamond.ac.uk/lims/pato-helm
[ ] add to the registry https://confluence.diamond.ac.uk/display/CLOUD/Container+Registry
[ ] showcase the window mechanism to the stakeholders

put #7 into here

doing this now, need to copy package-lock.json[3/4] STEP 8/10: RUN npm ci
npm ERR! code EUSAGE
npm ERR!
npm ERR! The npm ci command can only install with an existing package-lock.json or
npm ERR! npm-shrinkwrap.json with lockfileVersion >= 1. Run an install with npm@5 or
npm ERR! later to generate a package-lock.json file, then try again.
npm ERR!
npm ERR! Clean install a project
npm ERR!
npm ERR! Usage:
npm ERR! npm ci
npm ERR!
npm ERR! Options:
npm ERR! [--install-strategy <hoisted|nested|shallow|linked>] [--legacy-bundling]
npm ERR! [--global-style] [--omit <dev|optional|peer> [--omit <dev|optional|peer> ...]]
npm ERR! [--include <prod|dev|optional|peer> [--include <prod|dev|optional|peer> ...]]
npm ERR! [--strict-peer-deps] [--foreground-scripts] [--ignore-scripts] [--no-audit]
npm ERR! [--no-bin-links] [--no-fund] [--dry-run]
npm ERR! [-w|--workspace  [-w|--workspace  ...]]
npm ERR! [-ws|--workspaces] [--include-workspace-root] [--install-links]
npm ERR!
npm ERR! aliases: clean-install, ic, install-clean, isntall-clean
npm ERR!
npm ERR! Run "npm help ci" for more info
npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2024-03-18T15_59_57_679Z-debug-0.log
Error: building at STEP "RUN npm ci": while running runtime: exit status 1

 FROM docker.io/nginxinc/nginx-unprivileged:alpine3.18-slim COPY --from=build /usr/src/app/build /usr/share/nginx/html COPY nginx/conf.d /etc/nginx/nginx.conf

got that to work - with nginx container no need to disable root manually.

got it here https://argus-dashboard.diamond.ac.uk/#/deployment/xma12127/bootstrap?namespace=xma12127

deployed here

done


Image is missing in the RFQ autoresponder

Image of the product is missing in the autoresponder email.
Example -
https://www.moleculardevices.com/quote-request?pid=spectramax-i3x-multi-mode-microplate-reader
https://www.moleculardevices.com/quote-request?pid=3d-cell-models

Old live autoresponder -

@dev-rajneeshkumar assigning this to you because I am assuming this is on the Hubspot side.

@MeghnaTewari can you click on "view in browser" of the mail with missing image and share the link. I agree with @lydiapuric this seems to be a Hubspot issue or a combination of Hubspot linking to an image with fixed URL which we don't have.

@mhaack / @lydiapuric  image value is not being fetched in the iframe url  itself unlike old live.
Current: https://info.moleculardevices.com/rfq?product_family__c=SMax+iX&product_selection__c=SpectraMax+i3x+Multi-Mode+Microplate+Reader&product_primary_application__c=SpectraMax+i3x+Multi-Mode+Microplate+Reader&cmp=70170000000hlRa&google_analytics_medium__c=&google_analytics_source__c=&keyword_ppc__c=&gclid__c=&product_image=NA&requested_qdc_discussion__c=Quote&return_url=https%3A%2F%2Fwww.moleculardevices.com%2Fquote-request-success%3Fcat%3Dspectramax-i3x-multi-mode-microplate-reader
Old : https://info.moleculardevices.com/rfq?product_family__c=SMax iX&product_selection__c=SMax iX&product_primary_application__c=SpectraMax i3x Multi-Mode Microplate Reader&return_url=https://live-md30.pantheonsite.io/quote-request-success?pid%5B223%5D%3D223&product_image=https://live-md30.pantheonsite.io/sites/default/files/styles/related_products/public/products/banners/spectramax-i3x-thumb..png?itok=sMEY6i2m&website=https://www.moleculardevices.com/products/microplate-readers/multi-mode-readers/spectramax-i3x-readers&Primary_Application_geo=SpectraMax i3x Multi-Mode Microplate Reader&cmp=70170000000hlRa&requested_qdc_discussion__c=Quote

Here is the link @mhaack
https://email.moleculardevices.com/request-quote-molecular-devices-2?ecid=ACsprvvi_dTFLGVAIiI-88p1rR62bfls6axnDwvR3JVxx38OmbsbHjUFd5mXyBx0hjaszDTff65O&_hsmi=225898476

@dev-rajneeshkumar I see multiple differences in the URLs. **product_image** is that the correct parameter name? However we set it to "NA"

@mhaack  product_image is the exact name and it should be set to image url and shown in example url of old website.
I think updating it to the value of  'thumbnail' tab in the sheet should work but i am not sure.

Understood, working on a PR

@mhaack found one issue with the links on the image in the autoresponder email.
I submitted 2 RFQs - one for ClonePix 2 and another for 3D Cell Models.
https://rfq-image--moleculardevices--hlxsites.hlx.page/quote-request?pid=clonepix-2-mammalian-colony-pickers
https://rfq-image--moleculardevices--hlxsites.hlx.page/quote-request?pid=3d-cell-models
In the autoresponder email for ClonePix 2, the link on the image is correct and takes you to the ClonePix 2 product page.
But, in the email for 3D Cell Models, the link on the image goes to the previously submitted product rfq i.e ClonePix 2 product page.
I think there is some cache issue.

@MeghnaTewari I double checked with the two links above

https://rfq-image--moleculardevices--hlxsites.hlx.page/quote-request?pid=clonepix-2-mammalian-colony-pickers has https://www.moleculardevices.com/media_176fe19452b51369cd14cc78bb3f6178433db12e0.png?width=750&format=png&optimize=medium as image
https://rfq-image--moleculardevices--hlxsites.hlx.page/quote-request?pid=3d-cell-models has https://www.moleculardevices.com/media_1a7c35ec918098ac37972ea25d059d7f2f58b1602.jpeg?width=750&format=jpeg&optimize=medium as image

We send definitely different images for different products.

@mhaack the images are correct, I was talking about the hyperlinks added on the images in the email. They should go to their respective product pages. But right now, maybe due to some cache issue, the links are incorrect.

Oh sorry I misunderstood that. I have no idea how the links are generated, we don't send any hyperlink which is used in the mail, that must be generated by HubSpot.

It's strange that I could see hyperlinks on these images yesterday, but I can't today.
Can you please implement the hyperlinks for the images in the autoresponder, the links should go to their appropriate page. ( it was the same on old Live)


Fix presetcli

It turns out the VirtualMachineInstancePreset interface was never added to the KubevirtClient. So even though the code was present, it effectively never existed.
In addition to fixing that, this PR cleans up object names to match current conventions, and implements missing unit tests.
Add VirtualMachineInstancePresets to kubecli

ci test please

ci test please

ci test please


Upgrading travis to gcc7

Signed-off-by: Álvaro Jurado<EMAIL_ADDRESS>

@gmacd For ensuring that the native port will work. Last non-c++ dependent version was 4.7, 4.8 is the most closed to that (a few improvements in archs and fortran/c++).


EV Code Sign Certificates provider selection

Please, clarify current status on EV Code Sign Certificates selection guide for UEFI binaries signing.
In a below document :
https://docs.microsoft.com/en-us/windows-hardware/drivers/dashboard/lsa-and-uefi-file-signing
there are links to

Code signing certificate selection guide
https://docs.microsoft.com/en-us/windows-hardware/drivers/dashboard/get-a-code-signing-certificate
UEFI CA Signing policy updates
https://blogs.msdn.microsoft.com/windows_hardware_certification/2013/12/03/microsoft-uefi-ca-signing-policy-updates/

The former document (issued on
04/20/2017) includes the following approved EV Code Signing Certificates providers:

Extended validation code signing certificates (required for UEFI, kernel-mode drivers, and LSA certifications)
Buy a Symantec EV code signing certificate

Buy a Certum EV code signing cert

Buy an Entrust EV code signing cert

Buy a GlobalSign EV code signing certificate

Buy a Comodo EV code signing certificate

Buy a DigiCert EV code signing certificate

while the latter (an older one though, issued on December 3, 2013) mentions only two:

a. Starting March 15, 2014, SysDev will begin accepting EV certificates issued by either DigiCert or VeriSign for new submissions and renewals.

Is it Okay to use, for example, Comodo EV Code Sign Certificate to sign UEFI binary submisions as of autumn, 2018?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b119e13e-5e0a-a598-6799-5bcd1d45cb2f
Version Independent ID: 7bd929b5-490a-1724-152a-5172f480cf80
Content: LSA and UEFI file signing - Windows drivers
Content Source: windows-driver-docs-pr/dashboard/lsa-and-uefi-file-signing.md
Product: windows-hardware
GitHub Login: @aahill
Microsoft Alias: eliotgra

The 'Comodo' link has been tampered with!
The "Microsoft link" currently points to InstantSSL "https://www.instantssl.com/code-signing-certificates"
instead of the new owners of Comodo: https://sectigo.com/products/signing-certificates/code-signing
I would create a pull request myself and correct the Docs, but do not know how to create a new Microsoft shorturl.

@SillyKeith, can you please look at this and Issue #1384

The link was fixed back in March - in OzBob's comment, the "Microsoft Link" takes me to Sectigo.

Yes, it's ok to use Comodo (now Sectigo) EV code signing for UEFI submissions.

Thanks @SillyKeith!

Here are the common documents and verification steps Certificate Authority follows to validate the EV Code Signing Certificate.

Enrollment Form
Organization Authentication
Operational Existence
Physical Address
Telephone Verification
Employment Verification
Final Verification Call

Source: https://codesigningstore.com/documents-required-for-ev-code-signing-certificate-validation

Getting through the Extended Validation process is complex, as a minor mistake can detain you from the procedure. The primary documents you require to pass Extended Validation are as follows:

Company Registration (Report from Dun & Bradstreet, Government License, Bank Statement, Professional Opinion Letter)
Physical Address Proof (Utility Bill, Lease Agreement, Rent Agreement, etc.)
Telephone Number to contact for verification (A working landline or mobile number)
Operational Existence Document (Tax statements, Bank Statement of Demand Deposit account, etc.)

Read more about an EV code signing certificate - https://sslwiki.org/what-is-extended-validation-ssl-certificate/


Add documentation for dotnet nuget trust command to dotnet docs

We (NuGet.Client) team completed development of NuGet side changes for dotnet nuget trust command. This issue is created to add docs to dotnet repo.
https://github.com/dotnet/sdk/issues/17200

I created another https://github.com/NuGet/docs.microsoft.com-nuget/issues/2399 to correct and keep sync nuget trusted-signers vs dotnet nuget trust where only 1 nupkg file acceptable on path


Remove bin and obj folders, update .gitignore

@daschult,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


DEPRECATED

These APIs are deprecated and no longer maintained and may be taken down at any moment.

@brianbaker sad to hear this.  If this is deprecated, is there a replacement?  Thanks.


Add the drivers as a dkms module.

The driver has already been upstreamed, but this serves as a solution for the
time until it is released with a new raspian.
See #8

This is no longer necessary now that #16 points users to the new kernel version.


Problem with custom html attributes having dash characters

I am encountering a problem with custom html attributes having dash characters.
I have HTML that looks like this:
<input id='input-what' data-test='input-what'>
And here is the ERROR I get when I try to use a page-object accessor to access that data-test attribute:
3>     When I query 'A repair'                 # features/step_definitions/hs_steps.rb:8
3>       timed out after 30 seconds, waiting for {:data_test=>"input-what", :tag_name=>"textarea"} to be located (Watir::Exception::UnknownObjectException)
3>       (eval):1:in `process_watir_call'

It works fine if I just change my element to hook to the id instead of the custom attribute:
text_field(:what, id: 'input-what')
Now, I can work around this for the moment, by bypassing page-object (see commented out code below), and using DIRECT Watir calls, with this code  @titusfortner .   This proves that Watir supports these types of elements but page-object currently does not.  :
text_area(:what, data_test: 'input-what')
...
def search_what(term)
    #self.what = term
    @browser.text_field(data_test: 'input-what').set term
  end

Ok, this is working for me:
text_field(:what, data_test: 'input-what')
So, the problem seems to be specific to text_area?   I need to spend a little more time on this until I know for sure that this resolves my issue.  I will update within the next couple weeks if this solution works for me and I find no other related problems.

I believe the only issue is that you were trying to access a text_field with a text_area method.
The page-object code looks like it is working as intended here.

text-area works properly.  The HTML you posted above is not a textarea.  I'm going to close this issue.  If you believe there is still a problem then please feel free to reopen.


update #75: localize calendar and save the selected lang

This pr refers to https://dev.azure.com/survey-project/Survey/_boards/board/t/Survey Team/Issues/?workitem=75 and adds the following:

the calendar in the survey sending policy screen is localized
the selected language is remembered for the browser

center it verticaly
choose either capital or small letter for language choice
consider making the checkbox smaller

center the hamburger button vertically

I belive that the setting the language for calendar is not working correctly.
After choosing Englidh, when I switch to another tab from Surveys and then return to Surveys, the calendar is in Polish.

Wherever there is black font color, it should be changed to dark gray. For example names of the months and days in the calendar, name of the language selected.

center it verticaly
choose either capital or small letter for language choice
consider making the checkbox smaller

By "consider making the checkbox smaller" you mean the "check" icon, or the dropdown editor?

center it verticaly
choose either capital or small letter for language choice
consider making the checkbox smaller

By "consider making the checkbox smaller" you mean the "check" icon, or the dropdown editor?
"choose either capital or small letter for language choice" I was thinking about this and for me this also looks at least strangely. But this is because of the grama, actually. In Polish we name languages with a small letter, in English with a capital one. Another solution I've considered is displaying all the languages' names in a currently selected language. But this is also not a good idea, because the user can potentially not know what language he/she wants to pick. I don't know tbh...

I mean the dropdown editor.
Make both languages with capital letters, that will look clean and uniform.

It maybe could be done better, when it comes to the CSS, but I really was not able to make this "cleaner". I mean there is this ugly "margin" property. Also, I rescaled the dropdown horizontally. Let me know @wgrzesik  if now it looks better and if you accept.
The bug with the language not being loaded after changing the tab is fixed.

Wherever there is black font color, it should be changed to dark gray. For example names of the months and days in the calendar, name of the language selected.

add this

Wherever there is black font color, it should be changed to dark gray. For example names of the months and days in the calendar, name of the language selected.

add this

sorry for forgetting this, I've just added


Add file name as class attribute

We need to keep the file name in the class
This will be useful for:

displaying the file name in the GUI title bar
adding the file name to SMV exported data

fixed by #21


Mods for DemocracyOS to run on Windows

There are two modes one adds make.cmd which emulates the Makefile behaviour.
The other is a hack to fix path.resolve, this seems to effect both Linux and MacOSX as well.

Thank you for this, but we'll be supporting Windows using Vagrant, but in a couple of weeks.
We are also focusing on the 1.0.0 branch so please make next PRs to that branch.
Closing this PR.


[New game]: Automated Rock Paper scissor Game

🎮 Game Request
Game logic and basic description
It is like a normal rock paper scissors game with a change that theres is an option to auto play the game for you
Point down the features
Game points
It follows the rules of rock paper scissors

Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Sypher0Dronzer !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @Sypher0Dronzer ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


[Feature]: Customizable Front Content

Description
It would be fun to be able to customize the skyline with a company logo, etc. to personalize it for gift giving!
There may be cases where the user would want to exclude the year information from the front of the model (for example, when including an image and a date range of the user's entire history, maybe they'd just want to show the company logo in place of the date range)
Requirements

add a flag to include a image file that can be included in the rendering of the information on the front of the skyline
change the y flag/add new flag to also be able to exclude all year information from the face of the model

Definition of Done

[ ] When a valid image file reference is passed with the image flag

[ ] it is rendered on the front of the skyline
[ ] it has the same depth as the invertocat
[ ] it is aligned to the right of the front of the skyline
[ ] if white space is present on the right of the image file, it is respected so that white space in the image file can be used to offset the image from the right side of the face of the skyline
[ ] if white space is present on the right of the image file AND the year is included on the face of the skyline, the white space is respected so that it can be used to center the image between the username and year

[ ] optionally, a flag to control the positioning of the image (center between username and year or right edge, right align with margin. etc.)

[ ] When the y flag is used for exclusion, the year information is omitted on the model face

Additional Notes
No response

Thanks for raising this issue @mkuehn 🙏 This is an interesting feature request, and seems to align with an overarching theme with other issues raised around customisation of the generated skyline 😄
I think I can see the use case, but would like to rubber duck a little bit further. What about a scenario where a user wants to print their Skyline annually (with the image example you suggest), how would they differentiate between different years?

I think I can see the use case, but would like to rubber duck a little bit further. What about a scenario where a user wants to print their Skyline annually (with the image example you suggest), how would they differentiate between different years?

Sure, the year shouldn't always be excluded, just available to be excluded if the user wants. In your scenario, I guess they wouldn't be able to know which print was from which year. Or maybe they'd just recycle last year's print when they run a new one. :-) Or, they could keep the year, whatever they like.
So, you should be able to do any of the following, as you like:
--------------------------------------------------------------------------------
[github logo] @username                                    [company logo] 2024 |
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
[github logo] @username                                                   2024 |
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
[github logo] @username                                         [company logo] |
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
[github logo] @username                  [company logo]                   2024 |
--------------------------------------------------------------------------------

Hope that clears up what I meant!