importYaml is slow

Description of the issue:
Since the Human-GEM.mat file is removed from the repo we are down to using importYaml, which takes several minutes, while load('Human-GEM.mat') takes 1 s. If this is the intended use, it would be beneficial to speed this up. The way the code is written now, it performs tons of small reads from the file, which is super slow. The code could probably be enhanced a lot by reading the file in one big chunk into memory and then parse it from memory.
Expected feature/value/output:
It would just be much faster - right now it is annoyingly slow.
I hereby confirm that I have:

[ ] Tested my code on my own computer for running the model
[ ] Done this analysis in the main branch of the repository
[ ] Checked that a similar issue does not exist already

Aha, so the .mat file will still be available in the main branch. It is still a bit complicated, the code cannot really rely on that the file is there then, such as a tutorial, or can it?

Perhaps you're looking for this tutorial?

Most useful, thanks! But it is still very slow :)

When I look closer at it, it may not be the file reading, but it could be tested easily. The file reading could easily be fixed using readlines(filename), and just loop over the lines instead of checking for eof. But I'm not sure it will help that much. It could also be for example the regexp.

With profile on; model=importYaml('../../model/Human-GEM.yml'); profile viewer it becomes clear it is slow not because it is read one line at a time, but because it is processed one line at a time. More precisely, each field is growing by one entry each time.
line 289 is run 166181 times, taking 61 seconds in total:
    model.(fieldName) = [model.(fieldName); {value}];

Refactoring of the code could greatly speed this up, if the function would instead: (1) read the whole file at once; (2) split the data in the part describing reactions and metabolites and process separately; (3) use regexp to find e.g. first line of each reaction; (4) use regexp to extract all entries for a certain field type (e.g. eccodes) all at once.
I can imagine that the tricky part will be to handle cases where e.g. not all reactions have an entry for a particular field. But with some clever coding, I'm sure this can be managed :).
But maybe you see some other opportunities?

just preallocating the vectors to something large, and fix that in the end, would likely speed this up a lot - that is a very quick fix :)

line 289 is run 166181 times, taking 61 seconds in total:

I'm not sure to what extent this is the problem, since the yml file has 311891 lines, so it's parsing a field in only 50% of the time.

Still 61 seconds to cut :)

#393 addresses the issue of extending model fields.
The next slowest parts are constructS (14-23% of time) from RAVEN, which can maybe be improved a bit, and otherwise tokenizeYamlLine (~10% of time), where I do not see much opportunity for improvement.

Combined with constructS from this PR https://github.com/SysBioChalmers/RAVEN/pull/424, it now takes <40 sec to load the model on my PC.
tokenizeYamlLine is now responsible for ~35% of the duration, could maybe be reduced by first reading the whole file, run tokenizeYamlLine on all lines, and then loop through vectors of line_key and line_value to fill the model fields, where the loop largely follws the current structure.

Nice work! Maybe we can close this then?

I also find that https://github.com/SysBioChalmers/Human-GEM/pull/393 fully resolves this issue.


weired white lines

[

Does this issue occur when all extensions are disabled?: No

VS Code Version: yes
OS Version:

Steps to Reproduce:

/needsMoreInfo including version and platform.

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

version is 1.84.2

Merging to https://github.com/microsoft/vscode/issues/124226
Please disable hw acceleration in the application https://code.visualstudio.com/updates/v1_40#_disable-gpu-acceleration as a workaround


Missing nativejsx-prototype.js

Use a very tiny JavaScript file located in dist, nativejsx-prototype.js. Feel free to include it in your build steps (before any nativejsx-transpiled code runs, of course).

Cannot see nativejsx-prototype.js in dist folder.

Ah! That slipped by during the rebranding. Just use the jsxdom equivalent for now. I'll get the nativejsx versions up and released by the end of the day.
Thanks for catching that @asunar!

Fixed. Thanks again!


Can't connect to remote Center

I have set the $ATACenter variable using the cmdlet but my queries always return this.  Any tips?
Get-ATASuspiciousActivity : Unable to connect to remote server. Your ATACenter url is set to localhost. Run
Set-ATACenterURL '' if this is incorrect.

Hi @hkelley
Are you running the command on the ATACenter itself or are you running on a remote machine?
If your ATACenter is hosted on a different machine, you need to first run Set-ATACenterURL to specify the remote URL. For example, if your ATA portal is accessible by atacenter.contoso.com you need to run:
Set-ATACenterURL -URL "atacenter.contoso.com"

Yes, those are the steps I have taken.
PS C:\temp> Set-ATACenterURL -URL abc.xyz.net
PS C:\temp> $ATACenter
abc.xyz.net
PS C:\temp> Get-ATASuspiciousActivity
Get-ATASuspiciousActivity : Unable to connect to remote server. Your ATACenter url is set to localhost. Run
Set-ATACenterURL '<url>' if this is incorrect.
At line:1 char:1
+ Get-ATASuspiciousActivity

It looks like you are following the correct steps, but the Get-ATASuspiciousActivity command is not recognizing your $ATACenter variable. Could you answer the following questions to help narrow down the cause?

Could you confirm for me where you are using the module? Are you on the ATA Center or on a different machine? What OS are you on?

Could you please run Get-ATASuspiciousActivity -verbose and share with me the output.

Could you please run Get-ExecutionPolicy and share with me the output.

Could you please run Get-Module -Name Advanced-Threat-Analytics and share with me the output.

I did a test on my end using a remote machine and didn't have any issues. I started with localhost, got the same error you did, ran Set-ATACenterURL and pointed to my atacenter, then ran Get-ATASuspiciousActivity with the verbose flag to make sure it's using the correct URL. I put the output below. I'm testing from a 2016 machine, and ATA Center is on a 2012R2 machine.
PS C:\Users\rush.K45515> Get-ATASuspiciousActivity
Get-ATASuspiciousActivity : Unable to connect to remote server. Your ATACenter url is set to localhost. Run Set-ATACenterURL '<url>' if this is incorrect.
At line:1 char:1
+ Get-ATASuspiciousActivity
+ ~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
    + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Get-ATASuspiciousActivity

PS C:\Users\rush.K45515> Set-ATACenterURL atacenter.k45515.com

PS C:\Users\rush.K45515> Get-ATASuspiciousActivity -Verbose
VERBOSE: GET https://atacenter.k45515.com/api/management/suspiciousActivities with 0-byte payload
VERBOSE: received 4477-byte response of content type application/json; charset=utf-8

WindowsEventId                              : 2021
ExclusionUniqueEntityId                     : c52a7c75-21a9-409b-a4bc-26bb104ffeb9
SourceComputerId                            : c52a7c75-21a9-409b-a4bc-26bb104ffeb9
SourceAccountIds                            : {66c3c708-7c49-4095-833c-7c6429fa7c66}
DestinationComputerIds                      : {ff336d33-81f4-458c-b70b-33f0070ffb20}

Windows 10, connecting remotely to the Center (it works fine from the server locally)

Get-ATASuspiciousActivity -Verbose
VERBOSE: GET https://localhost/api/management/suspiciousActivities with 0-byte payload
Get-ATASuspiciousActivity : Unable to connect to remote server. Your ATACenter url is set to localhost.

RemoteSigned

ModuleType Version    Name                                ExportedCommands

Script     0.0.12     Advanced-Threat-Analytics           {Get-ATAMonitoringAlert, Get-ATAStatus, Get-ATASuspiciousA...

I needed the PS module today so I decided to dig into this myself by copying the PSM1 file to a PS1 and dotsourced it into my session (thinking I could debug the script interactively).
However, as soon as I loaded the functions that way, they started working.
Any thoughts on that?

Based on your Feb 27 post (very sorry I missed it), it seems like you hadn't run Set-ATACenterURL. The error message says that the cmdlet is looking for localhost (which is default), but you say you are doing a remote connection. If you are running these cmdlets from a machine other than the ATACenter, you have to run Set-ATACenterURL first and provide the URL of the ATACenter.


@conda-forge-admin,please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/google-cloud-webrisk-feedstock#8.


Update database replication documentation to include date type mapping compatibility

I've converted this to draft for now - please let me know when it is ready for a technical writer's review.

Existing content looks good. Based on the recent questions, I would additionally mention that CLOBs are not supported

No more comments, so passed technical review

@MarkvanMents we performed technical review, the MR should be ready for language review.


Sort artists by ArtistSort

The artist listing should display Artist (or AlbumArtist), and sort the list by ArtistSort.
Can't seem to figure out how to get this out of mpd, though. Maybe newer versions support list albumartist sort albumartistsort?

Nope. list doesn't support sort; only find does.


Support to method decorator that change the method signature

Suggestion
As the title said, I just started using typescript and I want to have a method decorator that is able to change the method signature and have tsc knew about the new signature.
🔍 Search Terms
I have seen a lot of works around class decorators, like #4881 but nothing specifically on supporting the behavior I have described.
✅ Viability Checklist

My suggestion meets these guidelines:

[*] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[*] This wouldn't change the runtime behavior of existing JavaScript code
[*] This could be implemented without emitting different JS based on the types of the expressions
[*] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[ ] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
If not for other things, I would like to understand if there is some way to set the types of decoratorto signal the new decorated function signature.
📃 Motivating Example
As a minimal example, look at
function decorator(_target: any, _propertyKey: string, descriptor: PropertyDescriptor): void {
    const method = descriptor.value;
    descriptor.value = function wrapper(a: number, b: number, c: number): void {
        // here you have access to a, b, c
        console.log(a, b, c);
        return method.call(this, a, b, c);
    }
}

class C {
    @decorator
    method(a: number, b: number): void {
        // here you have access to a, b
        console.log(a, b);
    }
}

new C().method(1, 2, 3); // here you pass a, b and c

tsc sasys that there is an error in the last line, because it doesn't "know" that C.method have a new signature, after applying the decorator.
💻 Use Cases
I'm implementing a simple method wrapper that add a parameter to do pre-checks on method invocation itself

It is usually an anti-pattern as decorators are meant to be transparent - meaning that no changes to method signature must be done by the decorator and only a behavior may be added/changed (like doing validation/logging).

I don't agree that decorators should only be used for validation/logging. I think that adding methods and properties to classes via decorators is one of their main goals and capabilities and typescript should be able to access to the added signatures. In the following example I am forced to create a 'dummy' class and force consumer code to use it, only for new  methods and props to be detected by typescript. Plus, I need to use @ts-ignore-error several times. This manual types-hardcoding doesn't look right to me and I don't see why I should be discouraged from using decorators like follows.
@Table // <-- this adds 'save' and 'delete' methods to the class instance
class Song {
    @primaryKey // <-- this adds a property named 'primaryKey' to the class
    _id: number
    artist: string
    title: string
    year: number
    genre: string[]
}

const song = new Song()

song.artist = 'Michael Jackson'
song.title = 'Thriller'
song.year = 1982
song.genre = ['rock', 'pop']

await song.save() // <-- compiler error
await song.delete() // <-- compiler error

Let's show a basic implementation of the two decorators we just used
function primaryKey(prototype: any, key: string) {
    prototype[key] = generateUniqueID()
    prototype.constructor.primaryKey = key
}

function Table<T extends { new (...args: any[]): {} }>(constructor: T) {
    return class extends constructor {
        async save() {
            // @ts-ignore-error
            return putToSomeDatabase(this, { key: constructor.primaryKey }) // <-- compiler doesn't know this props exists.
        }
        async delete() {
           // @ts-ignore-error
           return deleteFromSomeDatabase(this[constructor.primaryKey]) // <-- same here but the prop is actually there.
       }
    }
}

How can I make typescript aware of the two methods and prop I added via decorators?
class Override {
    primaryKey: string | number
    async save() {
        return {} as SomeDatabasePutResult
    }
    async delete() {
        return {} as SomeDatabaseDeleteResult
    }
}

@Table
class Song extends Override {
    @primaryKey
    _id: number
    artist: string
    title: string
    year: number
    genre: string[]
}

const song = new Song()

// Now compiler is aware of new props and methods
await song.save()
await song.delete()

song.primaryKey //  '_id'

If there is such wish to let decorators remain a 'hidden' thing, maybe the best option would be to have a flag in compiler options like "DecoratorsChangeTypes" ?

I hope it's going to be implemented right after decorators reach stage 4. Currently it doesn't make a lot of sense to be able to change signatures while decorators aren't standardised, unfortunately.

To add onto the validation topic, I believe that is actually a very convenient case for changing the signature. When working with a library like Zod, it is not rare for the result of the parsing operation to have a different type than the input, even if it's just removing null or undefined from property types.
In my case, I wanted to write a decorator to do exactly that, i.e., running a method's input through a provided Zod schema first before calling the method itself, and then passing the result to the method. Since this is a use case that happens in many different places in the code, I thought that a decorator would be a great abstraction to avoid having to replicate the manual parse invocation at all usage sites.


cmd/compile: Go 1.20 recognizes clear built-in and panics

What version of Go are you using (go version)?

$ go version
go version go1.20.6 linux/amd64

Does this issue reproduce with the latest release?
Yes
What did you do?
go run the following file:
package main

func main() {
	clear(([]int)(nil))
}

What did you expect to see?
An error indicating that clear isn't defined, or that it needs Go 1.21
What did you see instead?
./foo.go:3:6: internal compiler error: panic: interface conversion: interface is nil, not ir.Node

When building a package in a module, instead of specifying a file, Go correctly reports that clear needs Go 1.21 if the Go version in go.mod is set to 1.20.  However, if go.mod specifies 1.21, the same panic occurs.

CC @mdempsky

Duplicate of #61074.


Support .NET 5

Why not release. Net 5.0？

You can use gridify in .Net 5.0 without any problem. gridify is using .netstandard2.0 so it is available in almost any version of .Net


Renew access token API

I can't find renew access token API, should I need to renew a token manually when token expired.

Using GitHub App or the older PAT method?

I use the older PAT. My app need to query MS employee profile by GithubID.  I read this doc https://github.com/microsoft/opensource-portal/blob/develop/API.md.

Sorry, I misunderstood and thought that you were trying to use and run this open source project.
If you're a Microsoft employee you can provide different authentication mechanisms:

You can create a PAT at https://ossmsft.visualstudio.com (these expire)
You can create a PAT at https://repos.opensource.microsoft.com/settings (create a new one once expired)
If your team is running an official service or system, you can have a PAT from the opensource site "upgraded" to tie to your team instead of an individual and the expiration can be removed

You may also want to consider directly querying Kusto instead of hitting the API. More information is at https://docs.opensource.microsoft.com/tools/insights/github-insights.html


Remove legacy construction from remaining test files

See: #717

Codecov Report

Merging #1014 into develop will decrease coverage by <.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop   #1014     +/-   ##
=========================================
- Coverage       85%     85%   -<.1%
=========================================
  Files           53      53
  Lines         5340    5343      +3
=========================================
+ Hits          4539    4541      +2
- Misses         801     802      +1

Impacted Files
Coverage Δ

stellargraph/core/graph.py
99% <0%> (-0.3%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17c639...9414f6f. Read the comment docs.


error: The transaction was rejected by network rules.

This is on Android version 2.8.2
When I send some BCC to another address it says:
error: The transaction was rejected by network rules. (16: mandatory-script-verify-flag-failed (Non-canonical DER signature)) ... following by a signature.
My address has enough balance.

i think this be related to the comment @daburra667 made about the fix.

fixed by this:  https://github.com/fyookball/electrum/issues/6


test: fix drone-publish error

test: fix drone-publish error
Signed-off-by: Yang Chiu<EMAIL_ADDRESS>

Yeah this was missed


[SENTRY] TypeError: undefined is not an object (evaluating 'this.store[o].networkStatus=t.NetworkStatus.ready')

I believe this is an Apollo bug and I opened an issue here:
https://github.com/apollographql/apollo-client/issues/3345

https://sentry.io/newspring-church/apollos/issues/530406089/
TypeError: undefined is not an object (evaluating 'this.store[o].networkStatus=t.NetworkStatus.ready')
  at value ([native code])
  at forEach ([native code])
  at value ([native code])
  at value ([native code])
...
(25 additional frame(s) were not displayed)

@IsaacHardy See @conrad-vanl comment above. He created an issue for this on the Apollo Client repo (3345) and he's also got a PR open to fix it (https://github.com/apollographql/apollo-client/pull/3367). Perhaps we should remove this from the sprint while we wait to see if the Apollo folks accept his PR?

That sounds good. Moving it to backlog.


bug:

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have updated the plugin to the latest version before submitting this issue
[X] I have searched the existing issues of LazyVim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
v0.10.1
Operating system/version
ARCH
Describe the bug
Everytime I open neovim it gives this alert
Error detected while processing BufReadPost Autocommands for "*":
Error executing lua callback: .../share/nvim/lazy/LazyVim/lua/lazyvim/config/autocmds.lua:129: attempt to compare nil with number
stack traceback:
.../share/nvim/lazy/LazyVim/lua/lazyvim/config/autocmds.lua:129: in function <.../share/nvim/lazy/LazyVim/lua/lazyvim/config/autocmds.lua:125>
vim/filetype.lua: in function ''
vim/filetype.lua: in function 'match'
/usr/share/nvim/runtime/filetype.lua:14: in function </usr/share/nvim/runtime/filetype.lua:10>
Steps To Reproduce
I just open neovim  and it gives this error.
Expected Behavior
It should not have such.
I noticed that if I remove this from my settings I won't get the error.
require("lazy").setup("core.plugins.auto")
But the idea was to have modularized way that every single plugin had own file that defines settings etc. I removed all the plugins leaving only one it still gives such error.
Repro
Is there bug with this command? I tried to open it with this command but it automatically loads all of my neovim plugins that I haven't set here.

In my default configs which have these set, maybe it somehow affect the minimal repro.lua file?

local lazypath = vim.fn.stdpath 'data' .. '/lazy/lazy.nvim'
if not vim.loop.fs_stat(lazypath) then
	vim.fn.system {
		'git',
		'clone',
		'--filter=blob:none',
		'https://github.com/folke/lazy.nvim.git',
		'--branch=stable', -- latest stable release
		lazypath,
	}
end

-- Remap space as leader key
-- Must be before lazy
vim.keymap.set({ "n", "v" }, "<Space>", "<Nop>", { silent = true })
vim.g.mapleader = " "
vim.g.maplocalleader = ' '

local lazypath = vim.fn.stdpath 'data' .. '/lazy/lazy.nvim'
if not vim.loop.fs_stat(lazypath) then
	vim.fn.system {
		'git',
		'clone',
		'--filter=blob:none',
		'https://github.com/folke/lazy.nvim.git',
		'--branch=stable', -- latest stable release
		lazypath,
	}
end
vim.opt.rtp:prepend(lazypath)

require("lazy").setup("core.plugins.auto")

Adding a value
vim.g.bigfile_size = vim.g.bigfile_size or 1024 * 1024 -- Default to 1MB to ~/.local/share/nvim/lazy/LazyVim/lua/lazyvim/config/autocmds.lua
Somehow fixes it.

You're not using Lazyvim. But you've tried to incorporate Lazyvim to your config. That's the problem. Use the Lazyvim starter template and build from there and you'll see you won't have this error.


perf: optimize functional options

Previously, we wrapped functional options with interface (interface { apply(o *options) }) following the Uber style. While this style (arguably) provides more flexibility, this comes with a trade-off too: "arguments passed to interface's method typically be heap-allocated".
I don't think we need such flexibility in our code and ordinary functional options would be sufficient for our cases. Additionally, we make Decoder to reuse listeners' slices to reduce allocation needed. By doing this, we can get zero allocation when resetting Decoder and Encoder.
Here is the update and the benchmark regarding this change:
Decoder:
goos: darwin
goarch: amd64
pkg: github.com/muktihari/fit/decoder
cpu: Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
                          │   old.txt    │               new.txt                │
                          │    sec/op    │    sec/op     vs base                │
Reset/benchmark_New()-4      4.975µ ± 8%   4.869µ ± 22%        ~ (p=0.447 n=10)
Reset/benchmark_Reset()-4   177.60n ± 1%   49.34n ±  6%  -72.22% (p=0.000 n=10)
geomean                      939.9n        490.2n        -47.85%

                          │   old.txt    │                  new.txt                  │
                          │     B/op     │     B/op      vs base                     │
Reset/benchmark_New()-4     23.54Ki ± 0%   23.49Ki ± 0%    -0.20% (p=0.000 n=10)
Reset/benchmark_Reset()-4     64.00 ± 0%      0.00 ± 0%  -100.00% (p=0.000 n=10)
geomean                     1.213Ki                      ?                       ¹ ²
¹ summaries must be >0 to compute geomean
² ratios must be >0 to compute geomean

                          │  old.txt   │                 new.txt                 │
                          │ allocs/op  │ allocs/op   vs base                     │
Reset/benchmark_New()-4     8.000 ± 0%   6.000 ± 0%   -25.00% (p=0.000 n=10)
Reset/benchmark_Reset()-4   3.000 ± 0%   0.000 ± 0%  -100.00% (p=0.000 n=10)
geomean                     4.899                    ?                       ¹ ²
¹ summaries must be >0 to compute geomean
² ratios must be >0 to compute geomean

Encoder:
goos: darwin
goarch: amd64
pkg: github.com/muktihari/fit/encoder
cpu: Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
                          │   old.txt   │               new.txt                │
                          │   sec/op    │    sec/op     vs base                │
Reset/benchmark_New()-4     24.01µ ± 2%   23.96µ ± 49%        ~ (p=0.579 n=10)
Reset/benchmark_Reset()-4   72.90n ± 1%   30.97n ±  3%  -57.51% (p=0.000 n=10)
geomean                     1.323µ        861.4n        -34.89%

                          │   old.txt    │                  new.txt                  │
                          │     B/op     │     B/op      vs base                     │
Reset/benchmark_New()-4     128.1Ki ± 0%   128.1Ki ± 0%    -0.02% (p=0.000 n=10)
Reset/benchmark_Reset()-4     24.00 ± 0%      0.00 ± 0%  -100.00% (p=0.000 n=10)
geomean                     1.733Ki                      ?                       ¹ ²
¹ summaries must be >0 to compute geomean
² ratios must be >0 to compute geomean

                          │  old.txt   │                 new.txt                 │
                          │ allocs/op  │ allocs/op   vs base                     │
Reset/benchmark_New()-4     7.000 ± 0%   6.000 ± 0%   -14.29% (p=0.000 n=10)
Reset/benchmark_Reset()-4   1.000 ± 0%   0.000 ± 0%  -100.00% (p=0.000 n=10)
geomean                     2.646                    ?                       ¹ ²
¹ summaries must be >0 to compute geomean
² ratios must be >0 to compute geomean

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (master@536d730). Learn more about missing BASE report.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master      #325   +/-   ##
==========================================
  Coverage          ?   100.00%
==========================================
  Files             ?        43
  Lines             ?      3738
  Branches          ?         0
==========================================
  Hits              ?      3738
  Misses            ?         0
  Partials          ?         0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Is Configuring DNS required or optional ?

Hi,
Is the DNS configuration required ? What if i point my VMs NICs to the IPs, instead of of a VNET wide configuration ?
We have a mixed environment, and we don't want to change the DNS configuration of our VNET's DNS.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db354a18-aec3-a624-eb0b-de969d753909
Version Independent ID: 1bbcf33d-9918-574e-e246-0be512cf3bfc
Content: Azure Active Directory Domain Services: Update DNS settings for the Azure virtual network
Content Source: articles/active-directory-domain-services/active-directory-ds-getting-started-dns.md
Service: active-directory
Sub-service: domain-services
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

@SamirFarhat Thank you for the valuable feedback,we are investigating the issue.

Hi @SamirFarhat ,
Required for what? Just to clarify, are you just asking whether DNS configuration is required for using ADDS?

Yes. The portal should this Step as Required, bit IMO, it's not, it's optional. The article should mention that this step is only required if we want to use the managed domain dns service as our primary dns resolution service, in order for example to solve the managed domain name.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Marilee Turscak - MSFT<EMAIL_ADDRESS>Sent: Tuesday, August 20, 2019 2:20:05 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Samir Farhat (MVP<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Is Configuring DNS required or optional ? (#37228)
Hi @SamirFarhathttps://github.com/SamirFarhat ,
Required for what? Just to clarify, are you just asking whether DNS configuration is required for using ADDS?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/37228?email_source=notifications&email_token=ADR7DAEV2FGCP76KLJ6WUGTQFM2DLA5CNFSM4IMGEKH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4UVKTI#issuecomment-522802509, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADR7DAHYKPAXLA5I4BHMRVLQFM2DLANCNFSM4IMGEKHQ.

As the guidance from the portal is that it should be configured, that's how the doc is currently written. You can instead use conditional forwarders in the existing DNS environment to point to the Azure AD DS VMs, but the portal will still show it as being a required configuration. If that guidance changes, the doc will be updated accordingly.
You could also take the default option to configure DNS for the Azure AD DS network and then configure conditional forwarders back to the existing DNS servers - https://docs.microsoft.com/en-us/azure/active-directory-domain-services/manage-dns. That way the portal prompt goes away, and you can resolve all hosts as required.
For now, #please-close


No transparency around "Link confirmation" pop-up when using Catppuccin Mocha theme

Good morning.
As the issue title says, today I noticed that there is no transparency around the "Link confirmation" pop-up when using the Catppuccin Mocha theme:

For reference, here is the same view when Catppuccin Mocha is disabled:

Fixed in #2.


Exclude specified paths from mutants generation

I believe that it would be handy to exclude specified paths from the mutants generation.
Let's say that I want to exclude things like configuration logic or some test helper logic files, located within the src directory. Right now the default behaviour of cargo mutants command is that it tries to generate mutants for every file in the src  directory and in their child directories.
I could envision having a command line parameter as follows:
cargo mutants --exclude <regexes-for-paths-to-be-excluded>

Use case scenario:
Prerequisite:
Git clone test repo
Steps:

Go to the main directory of the cloned repo
Execute the following command

cargo mutants --exclude "(\/src\/tests)" "(\/src\/config)"

Expected behaviour:
Every file which is located in either /src/tests or /src/config directories are excluded from mutants generation.
Actual behaviour:
Because of the default behaviour of cargo-mutants (and due to the non-existency of this command line parameter) there are mutants generated for the files both in /src/tests and /src/config

Yep. There is already -f to say which files you do want to test. We could usefully and easily add the opposite. I think it should be a glob (as -f is) not a regexp.

You are right, glob is indeed a much better one for paths.
I believe that it would be a nice first-issue for me, would be glad to pick this task up. Is it fine by you?

That would be great, thanks! You should be able to work off the existing -f implementation.

PR has been created, ready to be reviewed


Code overview visual issues when fullscreen

VSCode Version: 1.34.0
OS Version: Fedora 30, Gnome 3.32.2, 5.0.17-300

Steps to Reproduce:

Open vscode windowed but covering full screen width (1920x1080)
See issues with overview/code map scroller on right side
Make window smaller - no more issues
See different problem with .js file - no strange characters, but very jumpy/jittery.

I've attached a gif showing this issue - look at the code overview on the right (the pixelated nature of the gif is because I converted it from a screen recording).

Does this issue occur when all extensions are disabled?: Yes

See also #74481.

Same root cause:
/duplicate https://github.com/microsoft/vscode/issues/74481


[BUG]: CSM Authorization Helm Install

Bug Description
Following documentation - https://dell.github.io/csm-docs/docs/authorization/deployment/helm/ - received the following error:
Logs
n/a
Screenshots

re-ran the install command: helm -n authorization install authorization -f myvalues.yaml charts/csm-authorization

Additional Environment Information
RKE1 Kubernetes Version 1.23.7
Steps to Reproduce
Error: INSTALLATION FAILED: An error occured while checking for chart dependencies. You may need to run ' helm dependency build' to fetch missing dependencies: found in Chart.yaml, but missing in cahrts/directory: cert-manager, ingress-nginx
from a node with kubectl access to cluster - cloned the helm-charts.git for authorization - git clone https://github.com/dell/helm-charts.git
kubectl create ns authorization
vi /samples/csm-authorization/config.yaml - edited the secret
created the secret in namespace authorization
copied values to myvalues.yaml
helm -n authorization install authorization -f myvalues.yaml charts/csm-authorization
Error: INSTALLATION FAILED: An error occured while checking for chart dependencies. You may need to run ' helm dependency build' to fetch missing dependencies: found in Chart.yaml, but missing in cahrts/directory: cert-manager, ingress-nginx
ran helm dependency build from the csm-authorization directory
Expected Behavior
n/a
CSM Driver(s)
PowerFlex CSI 2.2.0
Installation Type
No response
Container Storage Modules Enabled
No response
Container Orchestrator
Kubernetes 1.23.7
Operating System
Rocky 8.5

Hi @OA72280, thanks for reaching out, we will investigate this issue.

Hi @OA72280, please run a helm dependency update. It's possible your dependencies are not an acceptable version. I encountered this issue yesterday and running a helm dependency update resolved it.

1st - Ran your command in several locations, and only worked when I was in the csm-installer directory.
2nd - Went to run the installation command and was provided the attached error.

One recommendation that would be beneficial is to remove the csm-installer and karavi-observability directories as that can lead to further confusion. I'd also recommend that any config.yaml and values.yaml files be nested within a single directory from where all commands are to be levied to decrease potential errors.

Hi @OA72280, the csm-installer and karavi-observability are separate helm-charts, they cannot be removed. For installing CSM Authorization, please run helm dependency update in the charts/csm-authorization directory.

Closing this issue since it has not be updated in some time. Please reopen/open a new issue if the problem persists.


Polling restart and interval changing issue

Hi there,
I just started using bullet train with a self-hosted server and so far it's a great, smooth and fun to use tool :-)
However, I stumbled across two issues with updating/restarting polling intervals (client version 0.2.5).
Expected behavior:

Repeated calls to startListening() update the poll interval
After calling stopListening(), a call to startListening() will restart polling

Observed behavior:

The update interval from the initial call continues to apply
After calling stopListener(), polling will not resume on startListening()

How to reproduce:
Note: Uncomment if clause for case 2.
    onChange: (oldFlags, params) => {
      var interval = bulletTrain.getValue('feature_flags_update_interval') || 60000
      if (interval !== currentListeningInterval) {
        // if (oldListeningInterval > 0) {
        //   bulletTrain.stopListening()
        // }
        if (interval > 0) {
          bulletTrain.startListening(interval)
        }
        currentListeningInterval = interval
      }
    }

Is there anything I'm doing wrong here or is this a bug?
Thanks and best regards,
Michael

Hey @miscgithub appologies for the late reply. You are correct on this, the client will now clear old intervals and initialise a new one regardless.
Fixed in 1.1.2 of flagsmith/react-native-flagsmith

Hey @miscgithub appologies for the late reply. You are correct on this, the client will now clear old intervals and initialise a new one regardless.
Fixed in 1.1.2 of flagsmith/react-native-flagsmith


Update evaluation to new API

Summary
Update evaluation to new API.
Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Surpassed by #276


Add pims 0.3.2 and slicerator 0.9.4

New recipes for slicerator and pims

Intentionally, these versions do not begin with 'v'. Trying to keep soft-matter clean from this issue.

Why git url for pims and pypi for slicerator?

Related to the botched deployment on PyPI. :- (
On Thu, Nov 5, 2015 at 6:37 PM Thomas A Caswell<EMAIL_ADDRESS>wrote:

Why git url for pims and pypi for slicerator?
—
Reply to this email directly or view it on GitHub
https://github.com/NSLS-II/conda-prescriptions/pull/93#issuecomment-154232511
.

Superceded by #95


hipscat.inspection takes lsdb.Catalog

Plotting functionality in hipscat.inspection expects the input to be a hipscat.Catalog, and it fails with non-trivial error messages when trying to pass lsdb.Catalog. At the moment, a user needs to know to invoke .hc_structure on their lsdb.Catalog and pass that to the plotting function.
Make it possible for a user to pass lsdb.Catalog to hipscat.inspection in order to plot the results.

Alternatively, we could create a method on lsdb.Catalog like plot_pixels which calls the inspection method, passing in the hc_structure. This may be more intuitive for users, and avoids circular dependencies.


Namespace fallback for annotation logs

Ref: https://github.com/fluxcd/notification-controller/blob/7448a667a0c9b49c0f6c9940034e08e830a37ab6/internal/server/receiver_handlers.go#L96-L105
Currently my logs are showing like resource '<Kind>/<Name>.' annotated. Note the trailing dot after <Name>. It would be nice to either:

Make that dot optional when resource.Namespace isn't defined.
Fallback to receiver.Namespace if resource.Namespace isn't defined.

Isn't this already fixed and can be closed?
Right now the defaultNamespace is set as the namespace and as far as i can tell the method is always called with defaultName set to the namespace of the relevant Receiver resource.
https://github.com/fluxcd/notification-controller/blob/820fe53ce7b549b2ffb11e9296de377a0a042dea/internal/server/receiver_handlers.go#L367-L371
Updated original snippet:
https://github.com/fluxcd/notification-controller/blob/820fe53ce7b549b2ffb11e9296de377a0a042dea/internal/server/receiver_handlers.go#L411-L417

Good catch. Yes, this has been fixed as a side effect of #482 and is included in all version starting from 1.0.0 (i.e. Flux 2.0.0+).


npx create-remix returns errror

Describe the bug
If you create a new node project (node.new) and run the command "npx create-remix@latest" it'll return an error.
Link to the blitz that caused the error
https://stackblitz.com/edit/node-up6dmy?file=.stackblitzrc
Steps to reproduce

https://node.new
Navigate to terminal
run npx create-remix@latest
observer error

Expected behavior
To successfully create a remix app.
Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots

Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

I think this is fixed now that we support native npx. I am going to close this for now but we can open a new ticket if there's still an issue.


Camera

Use Cinemachine to Create a Camera Follow System

[x] Install Cinemachine
[x] Camera follow the Player

Cinemachine is installed.

Camera Follow Created.
https://blog.devgenius.io/camera-follow-system-in-unity-5dd18f3e6818


All my private keys are sent to another place by using this library

I had 3 wallets, all of private keys are sent and used by another one last night, be care

by using this library? So which code sends your keys? can you show it at source?

very interesting to see how? in which section of code?

https://github.com/iexbase/tron-api-python/blob/2da3b705d0bb139ef556d93cf14f3f1a5f938e87/tronapi/common/account.py#L19

https://github.com/iexbase/tron-api-python/blob/2da3b705d0bb139ef556d93cf14f3f1a5f938e87/tronapi/common/account.py#L19

I don't see anything that sending keys outside, can you please let me know?


How to get things from marathon /v2/event in java

Dear all,
I want to write a sse client to get things from marathon /v2/event in java,
first, i used org.glassfish.jersey.media.sse to get event-stream, but i got a 405 error, then i read the code of /v2/event, and found marathon use akka, and I read the doc of akka, but i found it's well supported in java,
Help !

This project is EOL (see the README), please move on to Akka HTTP.


Stable release

Hi.
Is there any plan to publish a stable version?
cheers

Yes... There isn't exact date yet, but we are really close already...

@Dead2, @nmoinvaz: Can you create a build today?
Really important.
Thanks in advance.

@Dead2, @nmoinvaz: Can you create a build today?
Really important.
Thanks in advance.

@Neustradamus I had planned to do a Release Candidate this week, and can likely do that today.
The first release should follow 2-3 weeks after that, unless a major bug is found. At this point I think that is unlikely, but you never know what could crop up with more widespread testing and scrutiny.

@Neustradamus I had planned to do a Release Candidate this week, and can likely do that today.
The first release should follow 2-3 weeks after that, unless a major bug is found. At this point I think that is unlikely, but you never know what could crop up with more widespread testing and scrutiny.

And the release is out :)

Thank you very much dudes! 👍


why heap profiler's memory large then process virtual memory?

This is heap profiler shows
Total: 156298.8 MB
This is process shows
PID USER      PR  NI    VIRT    RES    SHR S  %CPU %MEM     TIME+ COMMAND
45419 web_ser+  20   0 98.092g 0.094t  15076 S 105.0 77.0   4694:46 xxx
heap profiler shows 156GB，but process only show 98G，is heap profiler right？

profiler shows total memory allocated. I.e. sum of all sizes ever malloced. Some of them might be freed.


build.rs fails in dependencies for examples

Hey!
Thanks for this awesome initiative :)
I can build and run separate binaries that links to async-std as extern crate (like the examples in the readme) but I can't run the examples from within async-std.
johannes@jm:~/dev/async-test % rustc -V
rustc 1.39.0-nightly (53df91a9b 2019-08-27)
johannes@jm:~/dev/async-test % cargo -V
cargo 1.39.0-nightly (3f700ec43 2019-08-19)
johannes@jm:~/dev/async-test % uname -a
FreeBSD jm 13.0-CURRENT FreeBSD 13.0-CURRENT r349834+a82ad980c917(dell-fix_iichid-evdev) DELL-NODEBUG  amd64

This is what I get
johannes@jm:~/dev/async-std % cargo run --example hello-world
   Compiling libnghttp2-sys v0.1.2
   Compiling openssl-sys v0.9.49
   Compiling backtrace-sys v0.1.31
   Compiling mime_guess v2.0.1
   Compiling mime v0.3.13
   Compiling tempdir v0.3.7
   Compiling proc-macro-hack v0.5.9
   Compiling rand_chacha v0.2.1
error: failed to run custom build command for `libnghttp2-sys v0.1.2`

Caused by:
  process didn't exit successfully: `/usr/home/johannes/dev/async-std/target/debug/build/libnghttp2-sys-4c6f3caedee97f80/build-script-build` (signal: 11, SIGSEGV: invalid memory reference)
warning: build failed, waiting for other jobs to finish...
error: failed to run custom build command for `backtrace-sys v0.1.31`

Caused by:
  process didn't exit successfully: `/usr/home/johannes/dev/async-std/target/debug/build/backtrace-sys-78dbde0feafa0d65/build-script-build` (signal: 11, SIGSEGV: invalid memory reference)
--- stdout
cargo:rustc-cfg=rbt

warning: build failed, waiting for other jobs to finish...
error: failed to run custom build command for `openssl-sys v0.9.49`

Caused by:
  process didn't exit successfully: `/usr/home/johannes/dev/async-std/target/debug/build/openssl-sys-7d3ff8c9464a6e09/build-script-main` (signal: 11, SIGSEGV: invalid memory reference)
warning: build failed, waiting for other jobs to finish...
error: build failed

Any idea what this might depend on?

This seems like a problem building nghttp2, which is a dependency of libcurl, which is a dependency of (among other things) Surf. We recently had some linking issues there, and fixed them in 1.0.2 (moved from static builds to dynamic builds).
If you're using Surf (or Isahc) anywhere in your tree, perhaps try updating it?

I think this is the issue https://github.com/rust-lang/libc/issues/1489
Closing this.


some issues when running SigProfilerClusters?

Hi,
I am running SigProfilerClusters, and find some issues:

line 223 of SigProfilerSimulator.py:
log_out.write("Project: {}\nGenome: {}\nInput File Path: {}\ncontexts: {}\nexome: {}\nsimulations: {}\nupdating: {}\nbed_file: {}\noverlap: {}\ngender: {}\nseqInfo: {}\nchrom_based: {}\nseed_file: {}\n".format(project, project_path, genome, contexts, str(exome), str(simulations),  str(updating), str(bed_file), str(overlap), gender, str(seqInfo), str(chrom_based), str(seed_file)))

line 594 of of SigProfilerSimulator.py:
sigs.sigProfilerExtractor("table", ref_dir+"output/extraction_clustered/", ref_dir+"output/vcf_files" + path_suffix + "/"+project+"_clustered/SNV/output/SBS/"+project+"_clustered.SBS96.all", genome, startProcess=startProcess, endProcess=endProcess, totalIterations=totalIterations)#, totalIterations=totalIterations)
startProcess should be minimum_signatures
endProcess should be maximum_signatures

chrom_based=Ture but log file of SigProfilerMatrixGenerator says chrom_based=False
seqInfo=False but log file of SigProfilerMatrixGenerator says seqInfo=True

Thank you for the feedback! To address the raised issues:

We have fixed the typo in the simulator tool. Please manually update that tool to see these changes (pip install SigProfilerSimulator --upgrade).
Running extractions directly from the Clusters tool is temporarily deprecated. I have commented out this section of the code to avoid any confusion.
The output that you are seeing from the matrixGenerator is the result of the order of operations when running simulations with chrom_based=True. Ultimately, the final iteration of the matrixGenerator called by the simulator actually uses chrom_based=False, which is what you see in the final log file. If you are seeing this issue when running the matrixGenerator individually, please open a new issue under the SigProfilerMatrixGenerator repository.

I will close this comment as resolved; however, please feel free to open additional issues in the respective repositories if any arise.


fix(dao): page size 1 does not work for lmdb

Summary
We can simply drop the extra result.
Checklist

[x] The Pull Request has tests
[x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference
Fix KAG-5875

need a version bump change log.


tls: add test for tls keywords v1

Description:
Add tests for tls keywords: tls.subject  tls.issuerdn

We're on the right path, good job!
Some inline comments, but just to improve on the work you've done. Partly related: while reviewing this PR I noticed that at least the current tls keywords for these legacy keywords are not covered by suricata-verify tests. Could you please also add tests for those, and check if we are missing any other in the process? The ones I checked were: tls.cert_issuer and tls.cert_subject.

Do you want me to add the tests for those in the same commits?

Followed by #1075


Change "Add Preload Node" action to "Add Node(s)"

The action might also drop Custom Nodes

Thanks!

Cherry-picked for 3.4.


The error “Invalid Authentication Response” appears on the screen.

Probably it is due to fix of https://github.com/pingidentity/mod_auth_openidc/issues/226
We used 2.1.2 and configured the custom error page via OIDCDefaultURL
OIDCDefaultURL https://localhost/logoff.htm?error=longAuthenticationProcess.
In case of the long authentication process we see our custom error.
Recently we upgraded to 2.1.6 and unfortunately in case of the long authentication process we have the following error page:
Error:
Invalid Authentication Response
Description:
This is due to a timeout; please restart your authentication session by re-entering the URL/bookmark you originally wanted to access: https://<IP>/

Can we configure RP to redirect to our custom error and not to show the error page above?

You can use OIDCHTMLErrorTemplate  to handle this error in the way that you want: https://github.com/pingidentity/mod_auth_openidc/blob/master/auth_openidc.conf#L441


DOC: Please add stronger contrast or labeling between notebook input and output blocks

Issue with current documentation:
Page: https://python.langchain.com/docs/modules/memory/
In dark mode, there is very little contrast between inputs and outputs. Especially for pages imported from Jupyter notebooks, it can be really confusing figuring out which code blocks are safe to test in a .py function and which code blocks are intended for use in Jupyter.
Adding in explicit contrast or labeling between input and output blocks would be helpful.

Idea or request for content:
No response

Here, #15137 this might help


Cannot build: SQLite.Interop.dll not found

I tried downloading the compiled server but it's not working since it doesn't let me login with admin/admin.
I downloaded all the code with the hope of debugging that issue, but I cannot even compile it. I'm getting the following error:
1>C:\Program Files (x86)\MSBuild\14.0\bin\Microsoft.Common.CurrentVersion.targets(4105,5): error MSB3030: Could not copy the file "C:\Users\damian\Source\Repos\Bonobo-Git-Server\Bonobo.Git.Server\bin\x64\SQLite.Interop.dll" because it was not found.
1>C:\Program Files (x86)\MSBuild\14.0\bin\Microsoft.Common.CurrentVersion.targets(4105,5): error MSB3030: Could not copy the file "C:\Users\damian\Source\Repos\Bonobo-Git-Server\Bonobo.Git.Server\bin\x86\SQLite.Interop.dll" because it was not found.
Pardon my ignorance

You can copy the files from Bonobo-Git-Server\packages\System.Data.SQLite.Core.<IP_ADDRESS>\build\net45 (copy both x86 and x64 unless you know your server enviroment architecture) to the bin folder of the project.
For some reason, even if you add the files from the above mentioned folder, VS copies them to the bin folder and add the map path from the bin folder to the project... At least for now :)

Or you can replace "PreserveNewest" to "CopyAlways" at 526 and 529 line in Bonobo.Git.Server.csproj

VanKrock's comment did it. Thanks!

I'm not sure if I should close the issue since I don't have it anymore or wait until the fix is pusshed to the project.

I've been trying to get started testing with this project for the past few days; between this and #335 being present in the current install it made the experience less than smooth. Great experience with the product since I worked these two issues out. Would probably be useful to publish a revision to the compiled project download on the main site, and this issue occurred for me on two separate computers, so likely worth leaving open unless the issue is with SQLite?

Implemented to copy libraries from the folder with the nuget-packages #353


Use --porcelain in git plugin

The short output of git status, git status -s may have output when clean if status.branch = true.  Use --porcelain, which is intended for script consumption, instead.

Workaround for anyone having this issue is to add the following to .git/config to switch the option off for the repository.
[status]
branch = false


Email notifications

For Feature Requests
Desired Feature: Would be nice to have the possibility to add subscribers from the existing users to a book/chapter/page (maybe only for pages) and to have notifications when something was modified (with checkbox for not sending them when minor edits).
For Bug Reports
PHP Version:
MySQL Version:
Expected Behavior:
Actual Behavior:

I'm also interested in this, would make it easier to follow important "books".

+1 Notification with diff

Related to #147

+1 for this

+1

+1 for this feature request. Very important feature to notify all useres (opt-out via a setting in the user account should be possible). Great idea to have the author check a box when he wants / does not want an update to be pushed out. To bring it to the max a user could subscribe to a daily digest (one eMail with all the changes of the last 24 hours if any) or immediate notification about a change of (or new) content.

+1
Also related to what @Doctor-Macintosh said above:
Something like send me an automated digest of my new notes/pages every week could help me retain more knowledge and solve this "no spaced repetition" issue - because I tend to never go back to my old notes once I wrote them...

+1 we need this too

If any instances need desperately desire this kind of functionality, I've created a couple of examples of achieving this via our logical theme system.
These are unsupported customizations and there are notes to consider on each:

Email page updates based upon favourite pages
Email page updates based on roles tagged on parent book

Good afternoon, Are notifications planned out of the box?  This functionality is very lacking.

I have just opened #4371 for feedback, with a proposal for an initial implementation of email-based content notifications.

A base implementation, following the proposal in #4371, has been added within PR #4390.
This will be part of the next feature release.
I'll therefore close this off. Additional/related functionality can be opened separately (ideally after gaining experience with the new implementation) if not already covered by an existing issue.


Fix NPE in JSDocInfo

Fixes #2328

Can you squash this into one commit?

It is squashed.

Sorry, I should have said this before asking you to squash commits, but can you add a unit test as well?

No problem. I will let you know when I wrote a unit test and squashed it again.

Unit test is now added.


Duplicate source in path

Debug information:
sourceRoot = "/pathToProject/Project/source/"
sources = ["source/controllers/SchemaController.ts"]
Could not find input file /pathToProject/project/source/source/models/IModel.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Expected behavior:
In gulp-typescript 2.11.0 it compiles properly
Actual behavior:
In gulp-typescript 2.12.1 the path is decorated with source another time
Your gulpfile:
Include your gulpfile, or only the related task (with ts.createProject).
// gulp.sourceDir evaluates to ./source
var sourceDir = path.join(__dirname, config.get('gulp.sourceDir'));

gulp.task('compile', function() {
    var tsResult = gulp.src(sourceDir + '/**/*.ts')
        .pipe(ts(tsProject));
    return tsResult.js
        .pipe(sourcemaps.write())
        .pipe(gulp.dest(buildDestination));
});

How did you define tsProject? And can you post your tsconfig file if present?

var tsProject = ts.createProject(config.get('gulp.tsOptions'));

config:
...
"tsOptions": {
      "sortOutput": true
}
...

What happens when you remove the sortOutput option? What is your directory structure and what is the value of 'gulp.sourceDir'?

When removing "sortOutput": true, then the same errors occur.
gulp.sourceDir evaluates to ./source
I noticed, that even node_modules are loaded from source:
Debug information:
sourceRoot = "/pathToProject/Project/source/"
sources = ["node_modules/json-schema-to-mongoose/lib/json-schema.ts"]
Could not find input file /pathToProject/Project/source/node_modules/json-schema-to-mongoose/index.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Folder structure is
sources: /pathToProject/Project/source
tests: /pathToProject/Project/test
node_modules: /pathToProject/Project/node_modules
gulp script: /pathToProject/Project/gulp.js

I saw this problem on v2.13.1. v2.13.0 works fine, but next version is not.

@falsandtru can you share your project?

@ivogabe here is that error log.
https://travis-ci.org/falsandtru/arch-stream/builds/128067953#L1196

Thanks, I think that I have fixed it with 0aad4f744004c8051572dd95516ce25e69cb8c38. Can you verify that?

I tried on master. Input file paths are fixed, but output paths are not. In my project, expect output path is ./dist/<package>.js, but actual path is ./<package>.js.

repro

Checkout my project.
npm i
rm -rf node_modules/gulp-typescript/
git clone https://github.com/ivogabe/gulp-typescript.git node_modules/gulp-typescript
cd node_modules/gulp-typescript/
npm i --production
cd -
gulp build

@falsandtru That should now be fixed with 9859e4795337da6b490a2c7fbb87565b59a42dd8.

@ivogabe It works fine! Thanks.

@ivogabe
I'm on v2.13.3 and I have the same problem. I get multiple error messages such as
Could not find input file ~/Desktop/Dropbox/Projects/project/front-end/front-end/analytics.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "~/Desktop/Dropbox/Projects/project/"
sources = ["front-end/front-end/analytics.ts"

or
Could not find input file ~/Desktop/Dropbox/Projects/project/front-end/________________empty.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "~/Desktop/Dropbox/Projects/project/"
sources = ["front-end/________________empty.ts"]

This is my tsconfig.json:
{
	"compilerOptions": {
		"rootDir": "./",
		"target": "es5",
		"module": "system",
		"moduleResolution": "node",
    	"emitDecoratorMetadata": true,
    	"experimentalDecorators": true,
		"noImplicitAny": true
	},
	"exclude": [
    	"node_modules",
    	"front-end/node_modules",
	    "typings/main",
	    "typings/main.d.ts"
    ]
}

@maximedupre Can you share your full project? What happens when you remove rootDir?

I have reverted to v2.13.3 for additional tests.
When I first launch the gulp task, the errors mentioned in my previous comment don't appear (although nothing is transpiled), but as soon as I modify a file that is being watched and that the task is executed again, the error messages appear.
My set for gulp-typescript looks like this:
let gulp = require('gulp');
let typescript = require('gulp-typescript');
let typescriptProject = typescript.createProject('tsconfig.json');

let compileToJs = function() {
    let toPipe = typescript(typescriptProject);
    let typescriptResult = typescriptProject.src().pipe(toPipe);
    let gulpDestination = gulp.dest('.');

	return typescriptResult.js.pipe(gulpDestination);
}
let watchForCompiliation = function() {
    gulp.watch('**/*.ts', { cwd: './' }, ['typescript']);
}

gulp.task('default', ['watchForCompiliation']);
gulp.task('typescript', compileToJs);
gulp.task('watchForCompiliation', ['typescript'], watchForCompiliation);

If I remove rootDir from my tsconfig.json as you suggested, there are no more errors and the transpilation does occur, but then the .js are all outputted at / instead of being outputted as a sibling to their respective .ts.

@maximedupre Thanks for the details, I could reproduce it and it should be fixed with https://github.com/ivogabe/gulp-typescript/commit/d2e0054e52d505c8031f6c1854fa476b19c74e3c. I've released the fix as 2.13.4

@ivogabe I confirm that the bug has been fixed. I think you can close this issue. Thanks!

@sebastianwahn Has this issue been solved for you too in the latest version? Or do you still get errors?

Actually, I still get an error, but at least this time it doesn't make my gulp task fail. My configs are the same as the one posted I previously, but the logs that I'm posting are from my production server as oppose to my dev server (although I also get this error on my dev server) because I wanted to take the opportunity to point to another bug that only occurs on my prod server.
The following error is similar to the issue that I posted previously (occurs both on dev and prod servers):
Could not find input file /app/________________empty.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "/app/"
sources = ["________________empty.ts"]

Additionally, on my prod server only, it seems that it's trying to transpile files that I have excluded (see my tsconfig.json above):
/app/front-end/node_modules/@angular/common/src/directives/ng_class.d.ts(72,35): error TS2304: Cannot find name 'Set'.
/app/front-end/node_modules/@angular/common/src/facade/async.d.ts(27,33): error TS2304: Cannot find name 'Promise'.
/app/front-end/node_modules/@angular/common/src/facade/async.d.ts(28,45): error TS2304: Cannot find name 'Promise'.
/app/front-end/node_modules/@angular/common/src/facade/lang.d.ts(4,17): error TS2304: Cannot find name 'Map'.
/app/front-end/node_modules/@angular/common/src/facade/lang.d.ts(5,17): error TS2304: Cannot find name 'Set'.
/app/front-end/node_modules/@angular/common/src/facade/lang.d.ts(70,59): error TS2304: Cannot find name 'Map'.
...

Note that my tsconfig.json is located at /app on my prod server.

@maximedupre Could you create a small example that reproduces this?

Additionally, on my prod server only, it seems that it's trying to transpile files that I have excluded (see my tsconfig.json above):

Files that are referenced are processed even when they are excluded in tsconfig.json, the config file only excludes them as root files. So I don't think that's a bug, but you could compare that with tsc to check that.

#342 has the exact same problem, his project will most likely be able to reproduce that.
As for the second "bug", you are right and it has probably nothing to do with gulp-typescript. I will do some experimentations and if I find out that it's a gulp-typescript bug, I will create an appropriate ticket.

@ivogabe I added you as a collaborator to my private repo so that you can make some tests. Run npm run gulp and start modifying some files, it should compile each time and you should get the error after a short period of time.

@maximedupre Thanks, I could reproduce it. It only happens when a new compilation is triggered, with changed files and without out or outFile. Then the result from the previous compilation is reused, but somehow that error is still shown. I'll work on a fix.

Any progress here? Having the same issue:
gulp.watch([PATHS.src, PATHS.index], ['watch:dev']);
Funny enough, the error only occurs when I change the file behind PATHS.index which is the index.html, when changing something in PATHS.src everything works fine.
Directory structure is:
project/
|- gulpfile.js
|- src/
    |- index.html
    |- app/
        | - **/*.ts

Exact error:
Could not find input file /Users/.../frontend/src/src/app/domain/shop.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "/Users/.../frontend/src/"
sources = ["src/app/domain/shop.ts"]
Could not find input file /Users/.../frontend/src/src/app/domain/country.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "/Users/.../frontend/src/"
...
...
... goes on for a lot of files...

@bzums It should be fixed for most configurations now, though for yours apparently not. Can you share your project? Is it somewhere on GitHub? You may mail it as a zip file privately too.

@ivogabe I just realised that it the compilation actually working, the error is just thrown nevertheless. Still interested in the project or is that known?

Yes, as a lot of false messages is not desired, even when the compilation works.

@ivogabe I figured it out, maybe a known problem?!
My old gulp setup was roughly like this:
var tsProject = typescript.createProject('tsconfig.json');
...
gulp.watch([...], ['watch:dev']);

and watch:dev does something like:
  return gulp
    .src(src)
    .pipe(typescript(tsProject))
    .pipe(gulp.dest(destination));

The fix is to do var tsProject = typescript.createProject('tsconfig.json'); before each compile...
It seems strange to me that one has to "reload" the config for each compile...if its intended this should be documented somewhere I guess.
Anyway, thanks for the support!

That's absolutely not desired. The idea of a tsProject is that it can be reused and reduce the compilation time.  Can you share your project?

The same for me. Reproduced only in gulp.watch task.
Could not find input file G:\Git\example\source\app\app\iAppConfiguration.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "G:/Git/example/source/app/"
sources = ["app\iAppConfiguration.ts"]

@supamax Can you share your project?

I think I can reproduce it very simple with the mgechev/angular2-seed project as described with my comment in issue mgechev/angular2-seed#1145.
owner of the angular2-seed project directed me to this issue and it probably is the same.
I'm don't know whats going on under the hood, so I can't really isolate the problem better.
But hope my reproducible test case can help.
test-case copy from the original issue:

git clone https://github.com/mgechev/angular2-seed.git
cd .\angular2-seed
npm install
npm start -> no errors
touched file app.module.ts without changes -> reloaded without errors
killed npm process
npm install angular2-busy --save
modified app.module.ts (adding import of service and added to providers):

import { NgModule } from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';
import { APP_BASE_HREF } from '@angular/common';
import { RouterModule } from '@angular/router';
import { HttpModule } from '@angular/http';
import { AppComponent } from './app.component';
import { routes } from './app.routes';

import { AboutModule } from './+about/about.module';
import { HomeModule } from './+home/home.module';
import { SharedModule } from './shared/shared.module';
import { BusyService } from 'angular2-busy';

@NgModule({
  imports: [BrowserModule, HttpModule, RouterModule.forRoot(routes), AboutModule, HomeModule, SharedModule.forRoot()],
  declarations: [AppComponent],
  providers: [{
    provide: APP_BASE_HREF,
    useValue: '<%= APP_BASE %>'
  },
  BusyService],
  bootstrap: [AppComponent]

})

export class AppModule { }

npm start -> no errors
touched file app.module.ts without changes -> reloaded with errors:

[13:33:29] Starting 'build.js.dev'...
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\shared\name-list\name-list.service.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\shared\\name-list\\name-list.service.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\shared\name-list\index.ts. This is probably an issue of gulp-typescript.

Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\shared\\name-list\\index.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\shared\navbar\navbar.component.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\shared\\navbar\\navbar.component.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\shared\navbar\index.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\shared\\navbar\\index.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\shared\toolbar\toolbar.component.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\shared\\toolbar\\toolbar.component.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\shared\toolbar\index.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\shared\\toolbar\\index.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\shared\config\env.config.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\shared\\config\\env.config.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\shared\index.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\shared\\index.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\app.component.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\app.component.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\+about\about.component.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\+about\\about.component.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\+about\about.routes.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\+about\\about.routes.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\+about\index.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\+about\\index.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\+home\home.component.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\+home\\home.component.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\+home\home.routes.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\+home\\home.routes.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\+home\index.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\+home\\index.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\app.routes.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\app.routes.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\+about\about.module.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\+about\\about.module.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\shared\shared.module.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\shared\\shared.module.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\+home\home.module.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\+home\\home.module.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\node_modules\angular2-busy\index.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["node_modules\\angular2-busy\\index.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\app.module.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\app.module.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\hot_loader_main.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\hot_loader_main.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\app\main.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\app\\main.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\testing\router\mock-location-strategy.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\testing\\router\\mock-location-strategy.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\testing\router\router-testing-providers.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\testing\\router\\router-testing-providers.ts"]
Could not find input file C:\Data\_git\irt-web\test\angular2-seed\src\client\src\client\________________empty.ts. This is probably an issue of gulp-typescript.
Please report it at https://github.com/ivogabe/gulp-typescript/issues
Debug information:
sourceRoot = "C:/Data/_git/irt-web/test/angular2-seed/src/client/"
sources = ["src\\client\\________________empty.ts"]
[13:33:29] Finished 'build.js.dev' after 80 ms

I'm having the same issue

I'm having the same issue :(
My project is using angular2-seed. Just update to newest version ( rc6 ) and get a lot of errors like this.
But it only happen when I change html file, it's working when I change ts file.

Having the same issue using angular2-seed. Symptoms and reproduce steps are the same as @spali

I deleted node_packages and typings, then reinstall. It's working.

This should happen any more in version 3 of gulp-typescript, since the logic where paths are constructed has been replaced.

Where is the version 3? Npm still installs v2.13.6. Please Feedback, thank you!


Failure on login with empty pass

Please take a look at login methods.
It respond "Expected [TEXT] but found EOL at position 27" when I try to do:
ApiConnection con = ApiConnection.connect();
con.login("admin", "");
--> my credentials of mikrotik are "admin" and no password.

Hi,
I am still having this problem.
I am implementing 'me.legrange:mikrotik:3.0.5' in my gradle file, however, it seems fixes #65 and '66 are not implemented.
When I attempt to login with a blank passwords I get the EOL at position 27 error.
Can anyone help me on how to get this to work as I am not too familiar with Github.
Thanks in advance.
Rgs
ETienne


Setup release automation

This automation uses: release-plan via this npx boilerplate generator, which is a hybrid of the best parts of release-it and changesets, where:

changelog entries are managed via labels (this list is a bit hard coded, but is sufficient)
if a maintainer can merge, they can release
no maintainer needs to have access to npm, nor push-access to main, they only need to be able to merge PRs

The setup:

an NPM_TOKEN
permission for actions to create pull requests
we'll want to enable "releases" in the settings for this repo

an initial git tag pushed (we can checkout the existingly published -- I've determined this to be 0.1.0 for signal-polyfill which was 2024-03-31T19:18:08.630Z, or matching commit: d811fce3c0d67529fe998f7eeaefd357f8369d01 (hopefully -- hard to tell for sure, tbh, but the commit used for publish cannot be newer than the publish timestamp)

I remain very concerned that a TC39 proposal is publishing a polyfill (that it will seem "official" - but TC39 does not publish official polyfills), and I strongly suggest you extract the package to a separate repo.

@ljharb Developing a polyfill has been very helpful for this proposal. If you want to adopt a rule in TC39, please propose this to committee for consideration, rather than expressing your concern to individual proposal authors in random patches (this PR does not introduce the polyfill).

This proposal is in stage 0, and it's not until stage 2 that we usually discuss solutions, so I'm not sure why a polyfill would be necessary merely to describe a problem for us to investigate. In other words, a polyfill doesn't even make sense for a proposal that's this early in the stage process.
Additionally, as I have indeed discussed in plenary before, this was a committee policy for years, but by the time I realized another proposal had done this, there wasn't consensus to block it (and that proposal hasn't sought advancement since). There, however, also is not consensus for a proposal to have a published polyfill, and that certainly is likely to come up in plenary as it seeks advancements.
Since this proposal was developed in secret (which is confusing given your previous feedback to me on the globalThis proposal), it wouldn't have been possible to me to comment on the introduction of the polyfill - this is the first I've been made aware of it.

I hid comments on this topic, which is not related to the PR at hand. Please raise your process proposals separately from development in this repository, and I am happy to keep discussing there.

Thanks for creating this automation. I am not sure of the best strategy for maintaining this (unstable) polyfill, so I am not ready to land this patch yet.

We'll be developing this code in a different repo.


Script connections lost when service worker goes to sleep

With manifest v3, the service worker isn't expected to live long. It seems that the port connections created by the library aren't helping to keep it alive. The library should be able to persist the scripts connections, or at least to re-enable them when the service worker comes back alive.

Fixed in 1.2.0


Specify which versions of BLAST staramr will work with

I should specify (in docs, possible check in software) which versions of BLAST staramr will work with. I suspect older versions of BLAST have a slightly different output format.  I should do a bit of testing to determine the minimum BLAST version required.

I am closing this issue. BLAST is installed by conda by default, and I haven't encountered any issues with different versions of BLAST so far.


[Bug]: @adminjs/bundler is overwriting NODE_ENV

Contact Details
No response
What happened?
If you import @adminjs/bundler
Your NODE_ENV gets set to production.
What is the point of that?
Bug prevalence
Always
AdminJS dependencies version
@adminjs/bundler v3.0.0
What browsers do you see the problem on?
No response
Relevant log output
No response
Relevant code that's giving you issues
https://github.com/SoftwareBrothers/adminjs-bundler/blob/main/src/bundle.ts#L6

There's no reason to use @adminjs/bundler locally but every AdminJS panel hosted remotely must have NODE_ENV set to production to bundle/serve minified files. It's set explicitly to production because there were lots of questions why people's admin panels load slowly in production or weigh over 50 MBs.

I have a staging environment, which acts the same as prod for most things. In that situation @adminjs/bundler changes my NODE_ENV and causes issues.
It shouldn't be a packages responsibility for the user to set the correct NODE_ENV. Nor should a package overwrite process.env

@dziraf is this something you'd be open to change if I created a PR?


Songpal (Sony) Error version 0.100.1

Home Assistant release with the issue:

0.100.1
Last working Home Assistant release (if known):
0.99.3
Operating environment (Hass.io/Docker/Windows/etc.):

Homeassistant in Docker - Ubuntu
Integration:

https://www.home-assistant.io/integrations/songpal/
Description of problem:
Sony receiver not detected by HA, errors in log (listed below)
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):
2019-10-12 10:08:48 ERROR (MainThread) [homeassistant.components.media_player] Error while setting up platform songpal
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 150, in _async_setup_platform
    await asyncio.wait_for(asyncio.shield(task), SLOW_SETUP_MAX_WAIT)
  File "/usr/local/lib/python3.7/asyncio/tasks.py", line 442, in wait_for
    return fut.result()
  File "/usr/src/homeassistant/homeassistant/components/songpal/media_player.py", line 63, in async_setup_platform
    from songpal import SongpalException
  File "/usr/local/lib/python3.7/site-packages/songpal/__init__.py", line 3, in <module>
    from songpal.device import Device
  File "/usr/local/lib/python3.7/site-packages/songpal/device.py", line 31, in <module>
    from songpal.notification import Notification, ConnectChange
  File "/usr/local/lib/python3.7/site-packages/songpal/notification.py", line 69, in <module>
    class SoftwareUpdateChange(ChangeNotification):
  File "/usr/local/lib/python3.7/site-packages/songpal/notification.py", line 77, in SoftwareUpdateChange
    isUpdatable = attr.ib(convert=convert_to_bool)
TypeError: attrib() got an unexpected keyword argument 'convert'

Additional information:

Further information, I just noticed this: could it be related?

Fixed in #27410


Make our Firebase Database Secure

I don't know how we're going to do this, but I know that @Gigabyte-Giant does. However, it's still an important issue to remember.
One way we could do this by making Gigabyte Giant's domain the only one allowed to modify the database instead of allowing localhost (instructions on how to do this here), meaning that all of our local versions would not be able to test out judging or syncing. This makes it so no one can run the app on localhost and delete everything.
I'm not sure if not being able to judge or sync locally is going to be a problem, but I think in any case, we should allow all domains read access because that's not a security issue. It's not like we're storing passwords in Firebase.

Right now, only authorized google users can really do stuff.
It's pretty darn secure if you ask me.

Yep. I've read the docs. I'll do this eventually.

Hm... That would put a bit of a kink in testing efforts by other team members though. Maybe have a list of authorized Google users who are judges and are only allowed to write scores, and another list of "developers" who are allowed all they need (not free reign though)

@MikaalSky  No, only authorized Google users can judge using the interface we have. Anyone could easily use their JavaScript console and erase the whole Firebase database (although I haven't tested this because if I did, then I would have erased the whole Firebase database).
@Gigabyte-Giant Cool! I just wanted to make this an issue so everyone knew about it.

@JavascriptFTW That's also another great idea! I support using user authentication like that.

I'll implement some sort of "role-based" authentication shortly.

You said to break things, so I did:
var firebaseRef = new Firebase("https://contest-judging-sys.firebaseio.com/");
var contestsRef = firebaseRef.child("contests");
contestsRef.set({"hacker": "Noble Mushtak", "explanation": "https://trello.com/c/Pm8BDOQI/32-try-and-break-things"})

Also, anyone can easily judge an entry by just putting authenticated = true; into their JavaScript console and then judging as normal.

I tried erasing /allowedJudges/[child] on Firebase, but it looks like you have security for that pretty good.

UPDATE:
We've almost finished Firebase authentication. All we need to do now is any authentication for the "New Contest" interface and authenticate the KACJS-Angus bot.

The authentication for the "New Contest" interface is done, and I just finished the authentication for the KACJS-Angus bot. Closing this.


Create Media Query CSS File #373

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!
Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

What issue does this fix?
Create Media Query CSS File #373
####Summarize what this PR fixes:-
Created Media Query CSS File and linked it to index.html file and contact.html as well. Media Query has no styles yet.
What issue is it attached to?
Fixes #<373>
Checklist
(Add an x between the brackets to check the items)

[ x ] I have summarized what this PR fixes above
[ x ] I have provided the issue ID/URL above
[ x ] I have not added Bootstrap or jQuery and used the correct styling guide.
[ x ] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[ ] I was the first one to claim the issue or I created the issue

Someone has already completed this issue. Please find an issue that has not been taken already.


Scroll is triggered on continious touch on mobile

If I press and hold to slide to 2 after the scroll another scroll event will be triggered and scroll to slide 3.
Is this intended?

Thanks, fixed it in https://github.com/zwug/react-full-page/commit/34184ea9983dfe0d197bec4111d4a81e6c2e3655

@zwug same thing is happening with touch pad both on macOS and Windows machines


Api version header

Fixes #516
Fixes #569
also sets the auth header

LGTM

This PR supersedes https://github.com/kubernetes-incubator/service-catalog/pull/563

I am gonna merge this now, as it fixes a blocking MVP 2 bug.


Fixing USER_SUSPEND method

Not yet finished
WORK IN PROGRESS
I have to figure out the way accounts balance are updated when an order is cancelled.

Initial idea of users removal was:

External system (gateway) lock trading for specific client, stop accepting new orders.
We assume client's orders and positions (if margin trading is enabled) - are known externally (should be tracked by events or journal). That is needed for steps 2 and 3.
Cancel requests sent for each of them, one by one. Some of them may not succeed because orders can get executed before cancel command arrive, but this is tracked by the external anyway.
If margin trading is enabled: After orders cancelled (received all corresponding events) - close positions by issuing corresponding closing orders, one by one. Because all limit orders were previously removed (and confirmed), resulting positions guaranteed to be closed completely.
Balance adjustment operations (withdrowals) issued to zero all balances.
Suspend command is issued to the core.  User record completely removed from the risk control (if possible) - so it not affecting peformance in any way. However for finantial accounting cosistency, if all steps above were not executed correctly - exchange core can re-create user account in SUSPENDED state. For such account external system can try remove it again - by applying same steps. Fixing positions (if margin trading is enabled) would require RESUME user first (if we apply fix from this PR).

Straight forward removal with just a single command of caurse looks much easier for beginners. It has potential latency penalty. But i think we can add it if can proce consistency gurantees for such commands.

Initial idea of users removal was:
1. External system (gateway) lock trading for specific client, stop accepting new orders.
   We assume client's orders and positions (if margin trading is enabled) - are known externally (should be tracked by events or journal). That is needed for steps 2 and 3.

2. Cancel requests sent for each of them, one by one. Some of them may not succeed because orders can get executed before cancel command arrive, but this is tracked by the external anyway.

3. If margin trading is enabled: After orders cancelled (received all corresponding events) - close positions by issuing corresponding closing orders, one by one. Because all limit orders were previously removed (and confirmed), resulting positions guaranteed to be closed completely.

4. Balance adjustment operations (withdrowals) issued to zero all balances.

5. Suspend command is issued to the core.  User record completely removed from the risk control (if possible) - so it not affecting peformance in any way. However for finantial accounting cosistency, if all steps above were not executed correctly - exchange core can re-create user account in SUSPENDED state. For such account external system can try remove it again - by applying same steps. Fixing positions (if margin trading is enabled) would require RESUME user first (if we apply fix from this PR).

Straight forward removal with just a single command of caurse looks much easier for beginners. It has potential latency penalty. But i think we can add it if can proce consistency gurantees for such commands.

Thank you for your review of the code and all infos you've shared and the way it can be improved.
What if we can allow the admin to choose between issuing a SUSPEND user request to:
1- Only suspend user without cancelling all orders
2- Suspend both: user and related (spot) orders (CURRENCY_EXCHANGE_PAIR)
The command will be sent as orderId (0 or 1), 1 to allow removing orders.


Pass COSMOS_NETWORK env var through in production build

When building, we should be able to specify the COSMOS_NETWORK env var and have the built app bundle use this network. Instead, we currently have to change the default in app/src/main/index.js.
dependencies: #534

If we're going to start the app with a local network by default then isn't this feature superseded by #27?

This is a good point. The purpose of this issue was, to create a quick way to build Voyager for different networks without changing config files. I.e. for our demo in April or for developers that test their own blockchain. Do you think, that we will be able to integrate #27 and the whole process of switching from local to online before then?

Closed via #604


add purge command

Adds a purge command described by #3 and #10 functionality for #10 is done, #3 still needs to be done, draft pr so that it is known I am already working on this.
Adds a purge command:
;purge <number> purges number messages from the channel it is used in.
Useful command for moderation.

Added a command to purge messages only for a certain user, due to the way discord api works it makes some assumptions and may not actually delete the wanted number of messages by that user.
;purge <number> <user>  deletes last number messages sent by user from the channel it is used in.


Disable Bing Search in Start Menu

Description
To disable Bing search in the start menu in Windows 10 version 2004 or later, the following steps need to be done:
For Windows 10 version 2004 or later:

Navigate to "HKEY_CURRENT_USER\SOFTWARE\Policies\Microsoft\Windows" on the left side of the Registry Editor window.
If the key "Explorer" already exists below the key "Windows", click on it. Otherwise, create this key by right-clicking on "Windows" and clicking on "New" -> "Key". After you've entered the name "Explorer", confirm it by pressing Enter.
Then right-click in the free area on the right and create another DWORD value by clicking on "New" -> "DWORD (32-bit) Value". Type "DisableSearchBoxSuggestions" for the name and press Enter.
Double click on this new entry and set the value to 1. Confirm the change by pressing Enter.
Reboot

Source:

This could be done analogously in PowerShell:
function Disable-BingSearch() {
    Write-Status -Types "-", "Misc" -Status "Disabling Bing Search in Start Menu..."
    If (!(Test-Path "HKCU:\SOFTWARE\Policies\Microsoft\Windows\Explorer")) {
        New-Item -Path "HKCU:\SOFTWARE\Policies\Microsoft\Windows\Explorer" -Force | Out-Null
    }
    Set-ItemProperty -Path "HKCU:\SOFTWARE\Policies\Microsoft\Windows\Explorer" -Name "DisableSearchBoxSuggestions" -Type DWord -Value 1
}

Reason
Current implementation only sets "CortanaConsent" and "BingSearchEnabled" in "KEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Search" to 0. This is not sufficient for newer Windows versions.
Examples
No response

@MadhiasM I've inserted this suggestion into the code, just re-download from the develop branch, its inside apply tweaks or personal-tweaks.ps1 file if your want a quick test.
.\src\scripts\personal-tweaks.ps1 # to run

Worked great when running personal-tweaks.ps1. Is there any way to enable the tweak in the GUI version?

Is there any way to enable the tweak in the GUI version?

I'm not planning to do that...sorry