Houdini: Look dev

Feature
Add Look dev support to Houdini. Based on HDAs or USD
🛠 Description work in progress
[cuID:OP-2638]

This PR https://github.com/ynput/OpenPype/pull/5925 should be a kickstart for Houdini Solaris lookdev with USD.
Would be good if maybe in the context of that the Description work in progress could be expanded to lay out any requirements for the feature.

This is implemented in AYON via USD with https://github.com/ynput/ayon-core/pull/295
Outside of USD the best workflow likely is making dedicated HDAs for character's looks.


Wake on Touch - getting the display to work again

I need a bit of help here - I wanted to sleep and then wake from a touch event.  I wake up the screen comes back on but is all sorts of messed up.  When waking from deep sleep I was under the impression that the board effectively resets and so the screen should be initialised as on power on.
Originally posted by @DrJaymz in https://github.com/Xinyuan-LilyGO/LilyGo-T-RGB/issues/23#issuecomment-1999866497
I cobbled the below from various places.  I don't see a sleep example in the current repo.
void deep_sleep(void)
{
    vTaskDelete(batteryMonitorTask);
    Serial.println("DEEP SLEEP !!!!");
    pinMode(TP_INT_PIN, INPUT);
    while (!digitalRead(TP_INT_PIN))
    {
        Serial.println("Wait touch release!");
        // It is necessary to read the touch message, otherwise the interrupt level will remain at 0
           static int16_t x, y;
        panel.getPoint(&x,&y);// touch.read();
        delay(200);
    }
    delay(2000);
    Serial.println("Touch release!!!");
    digitalWrite(pwmChannel,0);
    Serial.println("Enter deep sleep");
    delay(1000);

    // esp_sleep_enable_ext1_wakeup(1ULL << BOOT_BTN_PIN, ESP_EXT1_WAKEUP_ALL_LOW);

    esp_sleep_enable_ext1_wakeup(1ULL << TP_INT_PIN, ESP_EXT1_WAKEUP_ALL_LOW);
    esp_deep_sleep_start();
}

Which model of touch chip do you use?

Which model of touch chip do you use?

Its the 2.8 inch model so thats a gt911 or something (dont have it in front of me)

Examples have been added to test GT911 and CST820 versions


Add tutorials

Summary by CodeRabbit

New Features

Introduced a new section on requesting JSON data from OpenAI.
Added examples of using Pydantic for data validation and schema definition.
Showcased the integration of OpenAI's ChatCompletion API for structured data extraction.
Demonstrated the creation of nested complex schemas with Pydantic.

Documentation

Updated README with instructions for using openai<1.0.0 and instructor libraries.
Added usage examples for async clients and new UserExtract class.
Enhanced project documentation with async client notes and response_model usage.
Included a section on Pydantic validation and error handling in documentation.

Refactor

Added apatch to the public interface in instructor library for async support.
Modified wrap_chatcompletion function to accept an is_async parameter.

Tests

Created new async test functions and integrated pytest.mark.asyncio.
Added tests for UserExtract model and async OpenAI client interactions.

Chores

Updated tutorials with practical examples of structured output for RAG models.
Enhanced knowledge graph handling with new methods and classes in tutorials.
Provided examples of accessing original responses in API calls in documentation.

@coderabbitai review


Revert "cephfs: use new 'ceph fs resize' command when available"

Reverts ceph/ceph-csi#1044

@Madhu-1 PTAL.

@nixpanic #1044 accidently got merged which could update the 2.1 image with the change. Ideally it would have been on 2.1.1-canary. But the release-2.1 havent fall back to canary yet. so reverting the merge and getting back to the state which was previously with this PR. Please see #1044


Resolve build/configuration issues for Apache Flex 4.8.0+

When the Flex SDK moved under the Apache Foundation's flag, Apache had to make a number of changes in order to separate the Flex SDK core from the Adobe proprietary bits, e.g. removing the AIR SDK but included an Ant script to easily download it from Adobe.
Because of these differences, though, this repo's current prepublish.js does not work once we rev to using the Apache Flex SDKs (4.8.0+).
Look into what is necessary to automate this completely... but it may end up faster to just leave it as a Node.js spawn that requires external dependencies like Ant are installed.

Investigate: https://flex.apache.org/installer.html


Undefined styles

:)

Coverage increased (+2.6%) to 67.586% when pulling 61feeca461b59a201f6a78f1786235df3c284632 on undefined-styles into 4598ab1be4a80ce427c64f85133bddb8881947b0 on master.


Transition to Bootstrap for UI positioning

The current UI has a significant amount of CSS for handlign the layout of elements. Transitioning to using Bootstrap Grid will simplify the CSS as well as make the project more maintainable.
c.c.: @loneil @Gavinok

Some notes:

consider implementing size breakpoints for desktop/tablet/phone
don;t be too nitpicky about the theming: as long as the look-and-feel is similar to the current one, it will be good for this iteration. A UI review with a designer will likely lead to additional tweaks.
focus on the overall responsive grid layout, rather than where each item is placed: the UI might change, as mentioned above


Configs - add clarification for "levels"

Hi McJty - I'm not sure what "level" refers to in these cfg lines: "Below this chunk height cities will be level 3". A clarifying line in the cfg file might be helpful.
I'm thinking other users may not understand this either, but maybe its just me.  :)

I think this might have to do with the terraces, and generating in taller biomes like extreme hills. So if a biome would generate terrain above one level but below the other level, it generates at the chunk height indicated by the higher level. But I'm not sure.

The city level concept is explained in the wiki:
https://wiki.mcjty.eu/mods/index.php/Lost_Cities

I hadnot seen the wiki so thanks for sharing!
Unfortunately, I don't see the concept of level in relation to the config options cited. Really having trouble parsing this - apologies.
The reference I found to level was in building chunk generation: "First the chunk gets filled with stone up to the current city level (multiple of 6)"
The config options are
Below this chunk height cities will be level 0=75
Below this chunk height cities will be level 1=83
Below this chunk height cities will be level 2=91
Below this chunk height cities will be level 3=99

are the cfg numbers above a y height or a chunk height (nx16)?
what does a level # determine? (aside from filling up a chunk w/stone to this level)
abstracted, what do changing the numbers above do?  I tried setting them to different values to see if it was something i could easily deduce but wasnt able to tell a difference (at least visually)

I will clarify this further in the wiki.
But basically the concept of 'level' or 'citylevel' is relative to ground level which is 71 by default. So city level 0 corresponds to height 71. City level 1 is 6 higher which means 77. City level -1 is 6 lower which is 65.
Buildings can be at city level 0 through 4.
The subway system is at city level -3

So this does nothing?
Below this chunk height cities will be level 0=75

What? Level 0 is a valid city level. It is the lowest level at which buildings can generate

No, you just said...?
In the config for a profile are "Below this chunk height cities will be level X" config options. What you just said "But basically the concept of 'level' or 'citylevel' is relative to ground level which is 71 by default. So city level 0 corresponds to height 71. City level 1 is 6 higher which means 77. City level -1 is 6 lower which is 65." conflicts with that idea.

I don't see the problem? Below chunk height 75 cities will be at level 0 which corresponds to ground level 71

So what if you set the configs to something wacky like
Below this chunk height cities will be level 0=49
Below this chunk height cities will be level 1=61
Below this chunk height cities will be level 2=91
Below this chunk height cities will be level 3=124

Well that will work fine. When the biome height is less then 49 cities at those chunks will be generated at level 0 which is 71. When biome height is less then 61 cities will be generated at level 1 (77) and so on

Ah, so that's what that means.
#Biomes which would generate chunks with a height below the listed levels will generate cities at the following levels: 71 for level 0, 77 for level 1, 83 for level 2, and 89 for level 3

OK, I understand how you are arriving at the level designation now.
Are there any more values that correspond to the term "levels"?  For example, "more spawners are generated at city level 3"?  I'm just wondering why, as a packdev, I should be concerend with city levels and also why I would want to change the cited cfg options relating to levels.

Well say that you prefer cities to be less variable in height then you could modify that table to make sure cities never go beyond city level 2 (now they can go up to 4). Or if you like cities to be very high above the landscape you can raise the thresshold at which citylevels go higher.

ah.... ding.  that explanation makes this much more clear.  could i suggest you paste it in to your config for your users?


Extract submver from dependencies

Instead of updating submver manually, use whatever is specified as the Submariner dependency. This avoids having to update a variable every time Submariner is released, which means we can rely on dependabot to take care of everything for us.
While we're at it, drop the Submariner CR update; it no longer specifies the version to use.
Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>(cherry picked from commit 6c07797fab23def351f4f2acd6dca3494816b44f)

/cc @sridhargaddam @dfarrell07 @vthapar

/lgtm


UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open 'internal/process/task_queues.js'

When installing and enabling enlighten using the information in the readme, I get this on the console:
(node:29011) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open 'internal/process/task_queues.js'     at Object.openSync (fs.js:465:3)     at Object.readFileSync (fs.js:368:35)     at /Users/yyy/Projekte/xxx/backend/node_modules/nestjs-enlighten/src/Services/Resolver/stack-resolver.ts:18:20     at Array.map (<anonymous>)     at StackResolverService.getProperErrorStack (/Users/yyy/Projekte/xxx/backend/node_modules/nestjs-enlighten/src/Services/Resolver/stack-resolver.ts:16:20)     at processTicksAndRejections (internal/process/task_queues.js:93:5)     at ViewCompilerService.getCompiledView (/Users/yyy/Projekte/xxx/backend/node_modules/nestjs-enlighten/src/Services/ViewCompiler/view-compiler.service.ts:23:36)     at emitUnhandledRejectionWarning (internal/process/promises.js:168:15)     at processPromiseRejections (internal/process/promises.js:247:11)     at processTicksAndRejections (internal/process/task_queues.js:94:32) (node:29011) Error: ENOENT: no such file or directory, open 'internal/process/task_queues.js'     at Object.openSync (fs.js:465:3)     at Object.readFileSync (fs.js:368:35)     at /Users/yyy/Projekte/xxx/backend/node_modules/nestjs-enlighten/src/Services/Resolver/stack-resolver.ts:18:20     at Array.map (<anonymous>)     at StackResolverService.getProperErrorStack (/Users/yyy/Projekte/xxx/backend/node_modules/nestjs-enlighten/src/Services/Resolver/stack-resolver.ts:16:20)     at processTicksAndRejections (internal/process/task_queues.js:93:5)     at ViewCompilerService.getCompiledView (/Users/yyy/Projekte/xxx/backend/node_modules/nestjs-enlighten/src/Services/ViewCompiler/view-compiler.service.ts:23:36) (node:29011) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.     at emitDeprecationWarning (internal/process/promises.js:180:11)     at processPromiseRejections (internal/process/promises.js:249:13)     at processTicksAndRejections (internal/process/task_queues.js:94:32) (node:29011) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string or an instance of Buffer or URL. Received null     at Object.openSync (fs.js:457:10)     at Object.readFileSync (fs.js:368:35)     at /Users/yyy/Projekte/xxx/backend/node_modules/nestjs-enlighten/src/Services/Resolver/stack-resolver.ts:18:20     at Array.map (<anonymous>)     at StackResolverService.getProperErrorStack (/Users/yyy/Projekte/xxx/backend/node_modules/nestjs-enlighten/src/Services/Resolver/stack-resolver.ts:16:20)     at processTicksAndRejections (internal/process/task_queues.js:93:5)     at ViewCompilerService.getCompiledView (/Users/yyy/Projekte/xxx/backend/node_modules/nestjs-enlighten/src/Services/ViewCompiler/view-compiler.service.ts:23:36)     at emitUnhandledRejectionWarning (internal/process/promises.js:168:15)     at processPromiseRejections (internal/process/promises.js:247:11)     at processTicksAndRejections (internal/process/task_queues.js:94:32) (node:29011) TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string or an instance of Buffer or URL. Received null     at Object.openSync (fs.js:457:10)     at Object.readFileSync (fs.js:368:35)     at /Users/yyy/Projekte/xxx/backend/node_modules/nestjs-enlighten/src/Services/Resolver/stack-resolver.ts:18:20     at Array.map (<anonymous>)     at StackResolverService.getProperErrorStack (/Users/yyy/Projekte/xxx/backend/node_modules/nestjs-enlighten/src/Services/Resolver/stack-resolver.ts:16:20)     at processTicksAndRejections (internal/process/task_queues.js:93:5)     at ViewCompilerService.getCompiledView (/Users/yyy/Projekte/xxx/backend/node_modules/nestjs-enlighten/src/Services/ViewCompiler/view-compiler.service.ts:23:36)
Besides this, it seems that the stack displayed on the error page is wrong - or not complete at least.

Which node and nest versions you are using ? @danielkbx

It is Node v14.5.0 and @nest/core 7.3.2, just the currently most fresh versions.

It is Node v14.5.0 and @nest/core 7.3.2, just the currently most fresh versions.

Alright, I will be working on it this weekend.

@danielkbx I have tried the package with Node v14.9.0 and Nest v7.4.4 and I see no errors. There were some issues on nestjs-enlighten v0.0.5-beta but it is definitely not about the errors that you mentioned above.

Closed due to inactivity.


BUG: Cant read elp with read_custom_montage

import os.path as op
import mne
fname = op.join(op.dirname(mne.__file__), 'io', 'kit', 'tests', 'data', 'test.elp')
mne.channels.read_custom_montage(fname)

gives
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/larsoner/python/mne-python/mne/channels/montage.py", line 988, in read_custom_montage
    montage = _read_elp_besa(fname, head_size)
  File "/home/larsoner/python/mne-python/mne/channels/_standard_montage_utils.py", line 273, in _read_elp_besa
    data = np.loadtxt(fname, dtype=dtype, skiprows=1)
  File "/home/larsoner/python/numpy/numpy/lib/npyio.py", line 1128, in loadtxt
    for x in read_data(_loadtxt_chunksize):
  File "/home/larsoner/python/numpy/numpy/lib/npyio.py", line 1059, in read_data
    items = pack_items(items, packing)
  File "/home/larsoner/python/numpy/numpy/core/_internal.py", line 873, in __call__
    return self.func(self, *args, **kwargs)
  File "/home/larsoner/python/numpy/numpy/lib/npyio.py", line 1013, in pack_items
    ret.append(self(items[start:start+length], subpacking))
  File "/home/larsoner/python/numpy/numpy/core/_internal.py", line 873, in __call__
    return self.func(self, *args, **kwargs)
  File "/home/larsoner/python/numpy/numpy/lib/npyio.py", line 1004, in pack_items
    return items[0]
IndexError: list index out of range

However, this is a file from the io/kit module (and it gets used there), so it clearly should be readable. It looks like mne._digitization._read_dig_points is what the KIT code uses to read it, it's unclear why we don't or can't use this in read_custom_montage.

This works:
mne.channels.read_dig_polhemus_isotrak(fname)

Perhaps we should try to detect which type of file we have and warn if it's not BESA ELP?

+1

Closing in favor of  #7591


Missing tests for full screen and maximize

Is it possible to test if app is in full screen and maximizes?

hey @omerson, spectron has a property browserWindow which exposes all the BrowserWindow API. So to test if app is fullscreen, you can probably do something like..


cannot install, fails at pyswisseph

I haven't been able to install this module, it fails when it tries to install the pyswisseph dependency. I've been able to manually install the pyswisseph wheel, but the installer for flatlib still tries to uninstall and reinstall it, causing it to still fail. What's the solution?

same here, the error is
cannot open include file: 'wtypes.h': No such file or directory   error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\VC\\Tools\\MSVC\\14.29.30037\\bin\\HostX86\\x86\\cl.exe' failed with exit code 2
here is link to complete error:
https://pastebin.com/DnM4xKSW
os: windows10pro, latest/gratest
hw: asus a15 (tuf)
best regards,
aum
s love nia

Currently the correct wheels aren't uploaded to pypi, we're planning to at some point, but for the moment i recommend doing the following;

Download these artifacts (they're for 2.08.00-1, which is what flatlib uses rn)
Unzip them. This can be anywhere (even amongst other files in your download folder), just note down the exact path of where.
When installing flatlib, add the following flag; --find-links, and then add that path.
Pip should find the right files to install, and not try to compile pyswisseph for you.

ok, i have irc'd pyswisseph author and pyswisseph pypi maintainer, we solved the issue, i guess pypi will be updated somewhere soon, the error should be resolved for windows users.
lol, jonathan was faster than me, a second or two
have fun,
aum
s love nia

Currently the correct wheels aren't uploaded to pypi, we're planning to at some point, but for the moment i recommend doing the following;

Download these artifacts (they're for 2.08.00-1, which is what flatlib uses rn)
Unzip them. This can be anywhere (even amongst other files in your download folder), just note down the exact path of where.
When installing flatlib, add the following flag; --find-links, and then add that path.
Pip should find the right files to install, and not try to compile pyswisseph for you.

Good night! These page is not working now! Where am I found this now?


Fix requirements.txt. Add login usage to README. Fix empty-line-glitch in campaign.py

A lot of this code (most of whatever is there in main.py) includes code written by Venkkatesh Sekar (Spockuto). Please consider merging his PR before mine, so that due credits are given to him for his work.
In this PR, my contribution is just fixing requirements.txt, updating README and fixing a minor empty-line-glitch in campaign.py (where an empty line in a mailing-list file resulted in an error).

@thakkarparth007 can you fix the merge conflicts please?

@ssundarraj, done!
I've also added user friendly error messages.


Extend devicetree overlays

This adds the gpio-key to the devicetree overlay list.

Thanks @otavio. Merged.


mail notifications for releases are send for user with deactivated e-mail

Description
I've just upated to gitea 1.16.8 and noticed that we're still getting bounce messages for users with deactivated e-mail address. We have several bot users that we don't want to receive mail for.
@Gusted I couldn't comment on #18950, so I've created a new issue intead.
It seems that you've fixed mail notifications for inactive users but not for active users with disabled mail notification
Gitea Version
1.16.8
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Gitea helm chart  gitea-5.0.9
Database
No response

A sample bot user with disabled email notifications:

I wasn't the one who fixed this, please see #19131. Kindly ping @zeripath

A sample bot user with disabled email notifications:

But that user isn't active, right? So the mentioned PR would have effect.

You're right - I must have looked at the wrong commits.
But the fix was scheduled for 1.16.5 - so should be included in v1.16.8 ?
I've received a bounce message right now  for<EMAIL_ADDRESS>because someone created a new release.
Maybe there is still a check missing.

But the fix was scheduled for 1.16.5 - so should be included in v1.16.8 ?

Yup.

I've received a bounce message right now for<EMAIL_ADDRESS>because someone created a new release.
Maybe there is still a check missing.

I don't see any check missing. Looking at the code, the MailNewRelease function will make sure all UserIDs are mailable via GetMaileableUsersByIDs, which has checks to only include active users.

So as an admin I have to login as the (bot) user to disable the users email notifications in Settings -> Account -> Manage Email Addresses - right ?

Yes.


Enable the last test_convert2d config for XPU.

The test is supposed to pass with the latest driver update.


window.location.replace not working

Describe the bug
I can't use window.location.replace in Tauri android build but I can use it in Tauri android dev ?
Reproduction
No response
Expected behavior
No response
Platform and versions
cargo tauri android build

Stack trace
No response
Additional context
No response

This case is related to CSP, would anyone be able to help out?

I just realized window's Webview and Android's Webview give different behaviors like not redirecting to an insecure HTTPS self-sign, different from window's Webview asks the user consent to continue the connection. even when I try to connect to an insecure HTTPS backend in an Android browser it gives the same behavior as a desktop webview. I think Android's Webview is different Compilesdk component


[BUG] StatusNotification Available sent after RemoteStopTransaction -> StopTransaction.

Duplicate issue

[X] I've searched for any related issues and avoided creating a duplicate issue.

Component
Simulator
Description
I am new to this simulator. I got it working, and it definitely seems promising.
The message flow is:

OCPP Server: RemoteStopTransaction
ChargePoint Simulator: StopTransaction
ChargePointSimulator: StatusNotification Available.

That StatusNotification Available is sent automatically, but this does not happen with the actual chargers we are using (ABB). StatusNotification is only sent when the physical connector is unplugged.
Logs from my server:
Nov 25, 2024 @ 12:34:21.604	RAW_RCV: [2, "875d437e-63c6-4c7f-a52b-a0184a4ffe7b", "StatusNotification", {"connectorId"=>1, "errorCode"=>"NoError", "status"=>"Available"}]
Nov 25, 2024 @ 12:34:21.516	RAW_SND: [3,"80226546-d258-4e4f-acff-a3dfbb1fa226",{"idTagInfo":{"status":"Accepted"}}]
Nov 25, 2024 @ 12:34:21.503	RAW_RCV: [2, "80226546-d258-4e4f-acff-a3dfbb1fa226", "StopTransaction", {"idTag"=>"VID:999999999985", "meterStop"=>0, "timestamp"=>"2024-11-25T01:34:21.493Z", "transactionId"=>8346361, "reason"=>"Remote"}]
Nov 25, 2024 @ 12:34:21.471	RAW_SND: [3,"adcb7a93-f27a-4c8a-928e-35e7eecb85e7",{}]
Nov 25, 2024 @ 12:34:21.440	RAW_RCV: [2, "adcb7a93-f27a-4c8a-928e-35e7eecb85e7", "StatusNotification", {"connectorId"=>1, "errorCode"=>"NoError", "status"=>"Finishing"}]
Nov 25, 2024 @ 12:34:21.414	RAW_RCV: [3, "0012cc24-d8a5-4d1e-ad37-cf42a9acdcfb", {"status"=>"Accepted"}]
Nov 25, 2024 @ 12:34:21.235	RAW_SND: [2,"0012cc24-d8a5-4d1e-ad37-cf42a9acdcfb","RemoteStopTransaction",{"transactionId":8346361}]

Version
latest
Node.js version
v22.3.0
System
System:
OS: Linux 6.8 Ubuntu 22.04.5 LTS 22.04.5 LTS (Jammy Jellyfish)
CPU: (12) x64 AMD Ryzen 5 7530U with Radeon Graphics
Memory: 6.00 GB / 14.46 GB
Container: Yes
Shell: 5.1.16 - /bin/bash
Expected result
StatusNotification Available should NOT be sent automatically following a StopTransaction.
StopTransaction may be sent as a result of the RemoteStopTransaction, or the Stop button on the HMI on the charger.
Actual result
Simulator sent Status Notification Available
Steps to reproduce
No response
Attachments
No response

It's the intended behavior since there's no simulation at the connectors level: block/unblock, plug/unplug.

Fair enough. My use case involved potentially multiple remotestart/remotestop commands, which needs the connector to stay connected.
Tool works well in general though, thanks for your work.


Linked Data proof of Verifiable Credential

Support Linked Data Proof of Verifiable Credential.

@kdimak  see this code https://github.com/hyperledger/aries-framework-go/tree/master/pkg/doc/signature


Password rotation

Codecov Report

Merging #25 (5f01c6e) into main (ceeba02) will increase coverage by 0.15%.
The diff coverage is 74.54%.

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   60.11%   60.27%   +0.15%
==========================================
  Files           6        6
  Lines         692      730      +38
  Branches      103      113      +10
==========================================
+ Hits          416      440      +24
- Misses        256      264       +8
- Partials       20       26       +6

Impacted Files
Coverage Δ

src/charm.py
52.77% <72.54%> (+0.59%)
:arrow_up:

src/cluster.py
54.81% <100.00%> (+0.33%)
:arrow_up:

src/constants.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Deploy base adopta installation

Based on the backgrounding, we need to figure out which fork is best to start from and where it will go

This issue was moved to sfbrigade/adopt-a-drain#7


Fix links and images with parentheses

Hi! There were a problem with regular expressions of link and image. Because of greedy matching they matched till the last close parenthesis in the line with several links or images with parentheses inside.

Interesting, nice find :+1:


Add reference to Azure kubelogin

With kubelogin it is possible to prevent kubectl kicking off an unnecessary authentication cycle.
kubelogin will take an Azure access token from the az cli context and inserts it into kubeconfig.
E.g.
az aks get-credentials --resource-group myresourcegroup-rg --name myaks-ks
kubelogin convert-kubeconfig -l azurecli
kubectl get pods

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 92b18eba-07a5-dbbf-b697-0264e326f4d4
Version Independent ID: 8c025ef6-38a6-eca5-7729-8f040fbbbe10
Content: Concepts - Access and identity in Azure Kubernetes Services (AKS) - Azure Kubernetes Service
Content Source: articles/aks/concepts-identity.md
Service: container-service
GitHub Login: @palma21
Microsoft Alias: jpalma

@cveld Thanks for the question! We are investigating and will update you shortly.

@cveld
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@palma21
Can you please check and add your comments on this doc update request as applicable.

#reassign:schaffererin

Hi, @cveld, thank you for your feedback! Apologies for the delay in response.
kubelogin is a part of Azure RBAC for Kubernetes Authorization, which is referenced in the doc here. Within this section, there's a callout, stating that this needs to be enabled before it can be used, linking out to Use Azure RBAC for Kubernetes Authorization. This doc has its own section about using kubelogin.  Since the doc in question links out to an in-depth doc on this topic, I have not made any edits, and I will close this GitHub issue.
Thank you again! #please-close


GPS++ config should produce correct base shapes for muP

[x] Fix #206
[x] Task heads should have fixed output dimension (they currently don't)
[ ] Check that positional encoders have correct dimensions
[ ] Check pre_nn and pre_nn_edges
[ ] Check post_nn and post_nn_edges

@callumm-graphcore , I think this was fixed right? If not, feel free to re-open the issue.


Switch to musl

Use musl in CI on Linux and OS X to allow reproducible build on a wider variety of platforms.
Also perform some minor cleanups in the travis config file.

r? @Fraser999
(maidsafe_highfive has picked a reviewer for you, use r? to override)


typo in typescript-playwright-sample/README.md

Describe the bug
There's a small typo in the Playwright sample readme. On line 48 accessibility is spelled as accessibliity (note the l and i are switched).

Thanks for letting us know. I've updated the Readmes. :)


Cameron Edit profile

You can now edit your profile! Change all fields except for password, and images save too! The format looks ok at best though, and the profile page needs to be formatted correctly too... but it works!

dont merge yet, merged with main and got an error


Safe Mounting of /dev/gdrdrv in a kubernetes environment - HostPath appears to fail

Hi  @pakmarkthub, sorry for the tag but it's related to this one:
https://github.com/NVIDIA/gdrcopy/issues/278#issuecomment-1736701644
Is there a recommend what to enable gdrcopy within a Kubernetes environment, I'm trying to use the HostPath method as a file but this looks to be incorrect.
  host-gdrcopy:
    Type:          HostPath (bare host directory volume)
    Path:          /dev/gdrdrv
    HostPathType:  File

I was hoping I'm not the first person to try and do this?
Thanks

Hi @hassanbabaie,
I am not familiar with Kubernetes. Let me find out if someone might know the answer.

Hi @hassanbabaie, mounting the device node with a hostPath volume will only work if you run your pod as privileged. Otherwise, the container process won't have write permissions on the device node.
We are working on adding gdrcopy support to NVIDIA Container Runtime (see https://gitlab.com/nvidia/container-toolkit/container-toolkit/-/merge_requests/530), and it should make it into the next release. With this feature, you can inject /dev/gdrdrv into your container by setting the NVIDIA_GDRCOPY=enabled environment variable in your container spec. It will not be required to run your pod as privileged.
cc @elezar

Thanks this is great news @cdesiniotis, yes this will be much better as leveraging privileged is not desired.
If possible can you post here when it's released we can then look to try it out

Hi @cdesiniotis I can't seem to access https://gitlab.com/nvidia/container-toolkit/container-toolkit/-/merge_requests/530
Do you happen to have any update on this?

Hi @hassanbabaie,
FYI, we have released a gdrdrv container image on NGC: https://catalog.ngc.nvidia.com/orgs/nvidia/teams/cloud-native/containers/gdrdrv. Running that image will automatically compile and install the gdrdrv driver on your system. It will also expose /dev/gdrdrv. However, you still need to attach that path to your application containers manually.

It looks like this is now covered in v1.15.0-rc.2 and it's worked it's way through to v1.15.0-rc.4,

Do we happen to know the estimated release timeline?

@cdesiniotis Do you have anything that you can share regarding gdrdrv support in NVIDIA Container Runtime?

@hassanbabaie apologies for the delayed response. NVIDIA Container Toolkit 1.15.0 has been released. You can set NVIDIA_GDRCOPY=enabled environment variable in your container spec, and the /dev/gdrdrv device node should be made available to your container.

I tried to deploy this on OpenShift, and at the beginning I was not able to have the /dev/gdrdrv available in the (privileged) container. I found the logs of the gdrcopy installer:
# oc logs  -n nvidia-gpu-operator nvidia-driver-daemonset-414.92.202401121330-0-cmhxv -c nvidia-gdrcopy-ctr

Running gdrcopy-ctr-run-with-dtk
+ [[ ! -f /mnt/shared-nvidia-driver-toolkit/dir_prepared ]]
+ cp -r /usr/local/gdrcopy /mnt/shared-nvidia-driver-toolkit/
+ set +x
Mon May 13 20:45:15 UTC 2024 Waiting for openshift-driver-toolkit-ctr container to start ...
Mon May 13 20:45:30 UTC 2024 openshift-driver-toolkit-ctr started.
Mon May 13 20:45:30 UTC 2024 Waiting for openshift-driver-toolkit-ctr container to build the gdrdrv.ko kernel object ...
Mon May 13 20:45:45 UTC 2024 Waiting for openshift-driver-toolkit-ctr container to build the gdrdrv.ko kernel object ...
Mon May 13 20:46:00 UTC 2024 Waiting for openshift-driver-toolkit-ctr container to build the gdrdrv.ko kernel object ...
Mon May 13 20:46:15 UTC 2024 Waiting for openshift-driver-toolkit-ctr container to build the gdrdrv.ko kernel object ...
Mon May 13 20:46:30 UTC 2024 Waiting for openshift-driver-toolkit-ctr container to build the gdrdrv.ko kernel object ...
Mon May 13 20:46:45 UTC 2024 Waiting for openshift-driver-toolkit-ctr container to build the gdrdrv.ko kernel object ...
Mon May 13 20:47:00 UTC 2024 Waiting for openshift-driver-toolkit-ctr container to build the gdrdrv.ko kernel object ...
Mon May 13 20:47:15 UTC 2024 Waiting for openshift-driver-toolkit-ctr container to build the gdrdrv.ko kernel object ...
Mon May 13 20:47:30 UTC 2024 Waiting for openshift-driver-toolkit-ctr container to build the gdrdrv.ko kernel object ...
+ SRC_SHARED=/mnt/shared-nvidia-driver-toolkit/gdrcopy/src/gdrdrv
+ '[' -d /run/nvidia/driver/usr/src ']'
Waiting for nvidia driver to be loaded and rootfs to be mounted ...
+ echo 'Waiting for nvidia driver to be loaded and rootfs to be mounted ...'
+ sleep 5
+ '[' -d /run/nvidia/driver/usr/src ']'
+ lsmod
+ grep nvidia
nvidia_peermem         20480  0
nvidia_modeset       1499136  0
nvidia_uvm           6455296  4
nvidia               8626176  17 nvidia_uvm,nvidia_peermem,nvidia_modeset
ib_core               491520  9 rdma_cm,ib_ipoib,nvidia_peermem,iw_cm,ib_umad,rdma_ucm,ib_uverbs,mlx5_ib,ib_cm
drm                   581632  5 drm_kms_helper,ast,drm_shmem_helper,nvidia
+ cp -rv /mnt/shared-nvidia-driver-toolkit/gdrcopy/src/gdrdrv/gdrdrv.ko /usr/local/gdrcopy/src/gdrdrv/gdrdrv.ko
'/mnt/shared-nvidia-driver-toolkit/gdrcopy/src/gdrdrv/gdrdrv.ko' -> '/usr/local/gdrcopy/src/gdrdrv/gdrdrv.ko'
Loading gdrdrv kernel module
+ echo 'Loading gdrdrv kernel module'
+ _load_module
+ cd /usr/local/gdrcopy
+ insmod src/gdrdrv/gdrdrv.ko dbg_enabled=0 info_enabled=0 use_persistent_mapping=0
Creating gdrdrv device node
+ echo 'Creating gdrdrv device node'
+ _create_device_node
++ fgrep gdrdrv /proc/devices
++ cut -b 1-4
+ major='505 '
INFO: driver major is 505
+ echo 'INFO: driver major is 505 '
+ mknod /run/nvidia/driver/dev/gdrdrv c 505 0
+ chmod a+w+r /run/nvidia/driver/dev/gdrdrv
Done, now waiting for signal
+ echo 'Done, now waiting for signal'
+ trap 'echo '\''Caught signal'\''; _shutdown && { kill 696326; exit 0; }' HUP INT QUIT PIPE TERM
+ trap - EXIT
+ true
+ wait 696326
+ sleep infinity

and noticed that gdrcopy was not installed in /dev/gdrdrv but in /run/nvidia/driver/dev/gdrdrv. Therefore, I had to modify the volume mounts in the pod as following:
`    - mountPath: /dev/gdrdrv
name: gdrdrv

name: gdrdrv
hostPath:
path: /run/nvidia/driver/dev/gdrdrv
`

I don't know if this is the right way to do it but it works.

@stefanomaxenti yes, if you are leveraging GPU Operator to install the GDRCopy driver, the device node will be present at /run/nvidia/driver/dev/gdrdrv on the host.

While everything works fine on a privilged container, I am unable to use the env. variable NVIDIA_GDRCOPY=enabled inside a non-privileged pod using the NVIDIA GPU Operator. Without hostPath and with the variable, gdrdrv is not visible. But with hostPath, it is not usable since it requires R/W permission and the pod is not privileged.
I think it is related to this issue https://github.com/NVIDIA/gpu-operator/issues/713 on the operator side closed some days after releasing 24.3.0. I will try when it is avaiable to deploy.
Do you maybe have any other ideas to why GDRCopy is not working as expected in this setup? Thank you.

@stefanomaxenti ah I see you are on OpenShift. Unfortunately the NVIDIA_GDRCOPY=enabled envvar will have no effect on OpenShift today because we are not using NVIDIA Container Runtime there, and instead, are using an OCI hook -- so the component which parses this environment variable and adds the gdrdrv character device to the container never gets invoked. Like you observed, only a privileged container which has the /dev/gdrdrv hostPath mounted will work on OpenShift. We are looking to remove this limitation in a future release.


Device tracking not working properly

The problem
Device tracking seems to be broken.
I have many home/not home tracking information in the history of my Access-Point.
Device is working as expected and a continuous ping from my Laptop to the AP shows no lost connection.
Tested on WIFI and wired. Connected to the AP direct and Router.
AP is one of many devices with this strange behaviour.
Screenshots AsusRouter vs AsusWRT below.
AsusRouter

AsusWRT

Your device model
GT-AX11000
Firmware type
Merlin
Firmware version
388.1
Integration version with the issue
0.17.4
Method of the integration installation
HACS
What version and type of Home Assistant installation do you use
2023.1.6
Is there anything useful in the logs?
No response
Diagnostics information
No response
Additional information
Got two GT-AX11000 devices in my house.
One is configured in Router-Mode and one in AP-Mode (No AI-Mesh config).
Connected via 2.5G Cable.

Hello. Please check with the new version 0.18.0 whether the issue persists

Good morning.
installed 0.18.0 last night and looking good so far.

Set a reminder and report next week again.

Good. Just keep in mind, that if you want to compare with AsusWRT, make sure that the consider device at home time interval is set to the same value in both.
A shorter consider home would mean it detects devices offline faster, but might have more short disconnects/reconnects

Why should it detect reconnects on a cable connection?

A shorter consider home would mean it detects devices offline faster, but might have more short disconnects/reconnects

Sadly it looks like the bugfix didn't work 100%.
After Update to 0.18.1 i deleted the integrations for both and did a complete new config. One Router and one Access-Point.
In the Screenshot you can see random disconnects.

Ok, after playing around and digging a little deeper it seems the problem could be the combination of router and ap.
Since router and ap have own client-name lists the integration will generate two different entities.
Don't know if this is the reason or router and ap playint tricks on each other.
Will check a AIMesh-Router and AIMesh-Node config.

A question regarding your router-AP config: so you have AP with the same network names to increase the radius of your WiFi network for end devices? Or is it AP with separate WiFi?
In the first case, AiMesh will really be the better option - in this mode, all the devices communicate correctly and the one responsible for monitoring all the connected devices - is the AiMesh router. So you will have 2 times less entities and all of them should work better
Regarding device_tracker disconnects on wired connection - does it happen to end devices or only to AP connected via wire to the main router?

Hi @Vaskivskyi, your right.
Config is to increase the WIFI.
Yesterday i changed the config to AIMesh-Router and AIMesh-Node. Looks good for the number of devices.
But the issue seems not to be solved at all.
I have a raspberry pi for testing and after a shutdown and disconnect from power the device is still listed as online.
Strange to me, it is also listed in the GUI. But i really don't know if the GUI shows the online devices or the ever seen devices.

Then this would be the main problem. The Web UI should be showing only online devices. And the source is exactly the same as the source for the integration data. The question is only, why RPi stays online for the router.
I will be able to check with RPi connected via wire in the evening (CET) and will let you know, whether it works for me with a similar config.

Ok, i will install the AsusWRT integration this evening and check if this has the same behave.

Tested AsusWRT with the pi.
In AsusWRT the pi is tracked as expected.
Comes online and after shutdown goes offline.
In AsusRouter the pi is online all the time.
Checked log regarding the other issue with CPU usage and there are errors in the log. Will post the result at the other bug.

Hello. Sorry for the delay. I can confirm the bug with the same 388.1 FW and RPi 3B connected in wired mode. At the same time, wireless connection / disconnection works fine
But this is not an integration issue, but rather a router - the wired connected RPi stays online in the Web UI and AsusRouter cannot receive any other information than Web UI shows
Comparison with AsusWRT HA integration is not particularly correct. AsusWRT runs commands directly on the router OS. AsusRouter communicates with the Asus API - this allows abstracting from the exact device peculiarities and being compatible with all the possible Asus routers
Currently, I cannot check whether this behaviour is only on 388.1 or is it a general problem

No problem for being late :-)
Well, maybe the FW on the Router has two different ways to detect online devices.
On for the "normal" router config and one for the AiMesh-Router config.
In Mesh-Router config:
As far as i can see, there is a difference between the online devices when clicking on "Liste anzeigen" (first screenshot) and "Kabelverbindungen" (second screenshot) in the AiMesh part of the GUI.

Yes, the second screenshot really shows three online devices via cable, which is correct.

I will check the other connected devices menu, if it can improve device tracking

Let's continue this discussion in issue #570. The problem with device trackers is happening for different users and it will be much easier to collect all the useful info in a single issue.


Can't start new display, supposedly ILI9486, ESP32-S2.

I ordered a new display on Aliexpress. The seller assured me that his controller was ILI9486.
With driver ILI9486, LV_COLOR_16_SWAP - NO, Display orientation (Landscape inverted): White screen.

With driver ILI9488, LV_COLOR_16_SWAP - YES, Display orientation (Landscape inverted):

With driver ILI9488, LV_COLOR_16_SWAP - NO, Display orientation (Landscape inverted):

With driver ILI9481, LV_COLOR_16_SWAP - YES, Display orientation (Landscape inverted):

To understand what the picture should be. Display with an ILI9488 controller lying next to an unidentified display.:

ESP32-S2 freezes when trying to connect to Wi-Fi. The log is the same in all cases:
I (8321) phy: pll_cap_ext 10
I (8321) phy: pll_cap_ext 10
I (8331) phy: pll_cap_ext 10
I (8331) phy: pll_cap_ext 10

abort() was called at PC 0x400284a3 on core 0

Backtrace:0x4002ec8b:0x3ffe50e0 0x4002f35d:0x3ffe5100 0x40036cc2:0x3ffe5120 0x400284a3:0x3ffe5190 0x400285ed:0x3ffe51c0 0x4016e86a:0x3ffe51e0 0x401718c9:0x3ffe54f0 0x401aef19:0x3ffe5520 0x40035761:0x3ffe5550 0x401a48d9:0x3ffe55a0 0x401a4903:0x3ffe5620 0x4002a79b:0x3ffe5670 0x4015b973:0x3ffe56d0 0x4015ba0b:0x3ffe56f0 0x4015ba7c:0x3ffe5710 0x4015ca4d:0x3ffe5730 0x4015d52e:0x3ffe5760 0x4015d5df:0x3ffe5780 0x4010798c:0x3ffe57a0 0x401079c0:0x3ffe57c0 0x40143a8a:0x3ffe57e0 0x40143b56:0x3ffe5800 0x40141410:0x3ffe5820 0x40038648:0x3ffe5840 0x40032161:0x3ffe5870
  #0  0x4002ec8b:0x3ffe50e0 in panic_abort at C:\Users\Alexander\.platformio\packages\framework-espidf\components\esp_system/panic.c:356
  #1  0x4002f35d:0x3ffe5100 in esp_system_abort at C:\Users\Alexander\.platformio\packages\framework-espidf\components\esp_system/system_api.c:112
  #2  0x40036cc2:0x3ffe5120 in abort at C:\Users\Alexander\.platformio\packages\framework-espidf\components\newlib/abort.c:46
  #3  0x400284a3:0x3ffe5190 in lock_acquire_generic at C:\Users\Alexander\.platformio\packages\framework-espidf\components\newlib/locks.c:138
  #4  0x400285ed:0x3ffe51c0 in _lock_acquire_recursive at C:\Users\Alexander\.platformio\packages\framework-espidf\components\newlib/locks.c:166
  #5  0x4016e86a:0x3ffe51e0 in _vfprintf_r at /builds/idf/crosstool-NG/.build/HOST-x86_64-w64-mingw32/xtensa-esp32s2-elf/src/newlib/newlib/libc/stdio/vfprintf.c:853 (discriminator 2)
  #6  0x401718c9:0x3ffe54f0 in vprintf at /builds/idf/crosstool-NG/.build/HOST-x86_64-w64-mingw32/xtensa-esp32s2-elf/src/newlib/newlib/libc/stdio/vprintf.c:34 (discriminator 5)
  #7  0x401aef19:0x3ffe5520 in esp_log_writev at C:\Users\Alexander\.platformio\packages\framework-espidf\components\log/log.c:189
  #8  0x40035761:0x3ffe5550 in esp_log_write at C:\Users\Alexander\.platformio\packages\framework-espidf\components\log/log.c:199
  #9  0x401a48d9:0x3ffe55a0 in lib_printf at C:\Users\Alexander\.platformio\packages\framework-espidf\components\esp_wifi\src/lib_printf.c:47 (discriminator 13)
  #10 0x401a4903:0x3ffe5620 in phy_printf at C:\Users\Alexander\.platformio\packages\framework-espidf\components\esp_wifi\src/lib_printf.c:57
  #11 0x4002a79b:0x3ffe5670 in pll_vol_cal at ??:?
  #12 0x4015b973:0x3ffe56d0 in set_chan_freq_sw_start at ??:?
  #13 0x4015ba0b:0x3ffe56f0 in set_channel_rfpll_freq at ??:?
  #14 0x4015ba7c:0x3ffe5710 in chip_v7_set_chan at ??:?
  #15 0x4015ca4d:0x3ffe5730 in noise_init at ??:?
  #16 0x4015d52e:0x3ffe5760 in bb_init at ??:?
  #17 0x4015d5df:0x3ffe5780 in register_chipv7_phy at ??:?
  #18 0x4010798c:0x3ffe57a0 in esp_phy_load_cal_and_init at C:\Users\Alexander\.platformio\packages\framework-espidf\components\esp_wifi\src/phy_init.c:619
  #19 0x401079c0:0x3ffe57c0 in esp_phy_enable at C:\Users\Alexander\.platformio\packages\framework-espidf\components\esp_wifi\src/phy_init.c:236
  #20 0x40143a8a:0x3ffe57e0 in wifi_hw_start at ??:?
  #21 0x40143b56:0x3ffe5800 in wifi_start_process at ??:?
  #22 0x40141410:0x3ffe5820 in ieee80211_ioctl_process at ??:?
  #23 0x40038648:0x3ffe5840 in ppTask at ??:?
  #24 0x40032161:0x3ffe5870 in vPortTaskWrapper at C:\Users\Alexander\.platformio\packages\framework-espidf\components\freertos\port\xtensa/port.c:168

ELF file SHA256: 633e65cd4c83096e

CPU halted.

What controller does the display have?

In vain waiting for a response from developers who do not care about the problems of stupid users (they are busy with something else, apparently more important than a broken driver or artifacts on the display), I still figured out which display was sent to me and made it work.
Not with Your drivers.
In the Arduino development environment and with the Arduino_GFX library. A display with an ILI9486 controller.
I shouldn't have thought that the seller on Aliexpress sent me the wrong display...

Everything is sad ...
This display does not work in 16-bit mode. No not like this.
For control via the SPI bus, only 18-bit mode is available.
By adding the correct initialization string in the driver file for 123, the display worked. With the same artifacts...
void ili9488_init(void)
{
	lcd_init_cmd_t ili_init_cmds[]={
		{0x11, {0}, 0x80},
		{0x3A, {0x66}, 1},
		{0xC2, {0x44}, 1},
		{0xC5, {0x00, 0x00, 0x00, 0x00}, 4},
		{0xE0, {0x0F, 0x1F, 0x1C, 0x0C, 0x0F, 0x08, 0x48, 0x98, 0x37, 0x0A, 0x13, 0x04, 0x11, 0x0D, 0x00}, 15},
		{0xE1, {0x0F, 0x32, 0x2E, 0x0B, 0x0D, 0x05, 0x47, 0x75, 0x37, 0x06, 0x10, 0x03, 0x24, 0x20, 0x00}, 15},
		{0x20, {0}, 0},				/* display inversion OFF */
		// {0x36, {0x48}, 1},
		{0x29, {0}, 0x80},			/* display on */
		{0x00, {0}, 0xff},
	};

Now I have 2 displays (ILI9488 and ILI9486) which are of no use.
They work slowly, eat a lot of memory. Information display is accompanied by incomprehensible artifacts.
It took a lot of effort, time, nerves and, by the way, money too to clarify this fact.
The developers don't care.
They are busy with more pressing problems. For example, these.
Good luck gentlemen.


Update locales.rb with belarusian language

Add Belarusian language

@gschlager please take a look

Thanks! Are you going to create a pull request to add Belarusian to Discourse as well?

@gschlager As I understand it's already there in repo
be: { i18n: { plural: { keys: [:one, :few, :many, :other], rule: lambda { |n| n % 10 == 1 && n % 100 != 11 ? :one : [2, 3, 4].include?(n % 10) && ![12, 13, 14].include?(n % 100) ? :few : n % 10 == 0 || [5, 6, 7, 8, 9].include?(n % 10) || [11, 12, 13, 14].include?(n % 100) ? :many : :other } } } },
https://github.com/discourse/discourse/blob/master/config/locales/plurals.rb

The plural rules are just a small part. There's a whole process of adding a new language. See https://meta.discourse.org/t/how-to-add-a-new-language/14970
I'm sorry, I can't merge this PR without the other stuff. You are welcome to submit a PR to the main discourse repository as well as long as you follow all the steps in the topic mentioned above. Otherwise this will have to wait a couple of days until we find the time to add the language.

@gschlager Provided link don't exist, sorry.
Could you please handle this if it's regular process for you?


[co] Rename port co to cocoyaxi

Describe the pull request

What does your PR fix?

Rename co to cocoyaxi.

Which triplets are supported/not supported? Have you updated the CI baseline?
<all / linux, windows, ...>,

Does your PR follow the maintainer guide?
Yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?
<Yes / I am still working on this PR>

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Thanks for posting this issue. VCPKG use supports in vcpkg.json instead of vcpkg_fail_port_install. Could you please remove there codes in portfile.cmake?
if(VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_UWP)
    vcpkg_fail_port_install(ON_ARCH "arm" ON_TAREGT "uwp")
endif()

And if you rename co to cocoyaxi, you need also rename the directory name VCPKG_ROOT/ports/co to VCPKG_ROOT/ports/cocoyaxi.

Thanks for posting this issue. VCPKG use supports in vcpkg.json instead of vcpkg_fail_port_install. Could you please remove there codes in portfile.cmake?
if(VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_UWP)
    vcpkg_fail_port_install(ON_ARCH "arm" ON_TAREGT "uwp")
endif()

And if you rename co to cocoyaxi, you need also rename the directory name VCPKG_ROOT/ports/co to VCPKG_ROOT/ports/cocoyaxi.

@LilyWangLL
Hi, I think I have already renamed it to cocoyaxi. But I don't know how to use supports instead of vcpkg_fail_port_install. Could you help? Thanks!

@idealvin You just need remove these codes in portfile.cmake.
if(VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_UWP)
    vcpkg_fail_port_install(ON_ARCH "arm" ON_TAREGT "uwp")
endif()

@idealvin You just need remove these codes in portfile.cmake.
if(VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_UWP)
    vcpkg_fail_port_install(ON_ARCH "arm" ON_TAREGT "uwp")
endif()

ok, I removed it..

@idealvin You could download and unzip the attached file co.zip, then put directory co into VCPKG_ROOT/ports, and put co.json into VCPKG_ROOT/versions/c-. co.zip

@LilyWangLL ok，thanks! I'll try later. A little busy these days.

This PR is incorrect since it removes history; it should've been caught by CI.
The correct way to rename a port is to have an empty port under the old name, which depends only on the new port. The new port's version.json should only contain the latest version.
What you need to do here is:

restore co as an empty port which depends only on cocoyaxi
restore versions/c-/co.json
have only the latest version of cocoyaxi in versions/c-/cocoyaxi.json

This PR is incorrect since it removes history; it should've been caught by CI.
The correct way to rename a port is to have an empty port under the old name, which depends only on the new port. The new port's version.json should only contain the latest version.
What you need to do here is:

restore co as an empty port which depends only on cocoyaxi
restore versions/c-/co.json
have only the latest version of cocoyaxi in versions/c-/cocoyaxi.json

@strega-nil-ms  Done. Thanks.


Sortedset perf improvement on inserting

util/nativeutils/sortedset currently uses quicksort (sort.Sort()) on each Insert call.  As the elements are kept sorted a  BinarySearch&Shift approach could be an option to experiment with:
Pseudo:
   func (v *Set) Insert(b []byte) {
       ...
        ind := sort.Search(len(data), func(i int) bool {
		return data[i] > iRepr
	})

	data = append(data, &big.Int{})
	copy(data[index+1:], data[index:])
	data[ind] = iRepr

Some observations wrt topic:
https://github.com/dusk-network/dusk-blockchain/issues/169#issuecomment-561630839

Confirmed. Benchmark show a substantial improvement of 87% by using the binary search + shift approach


no run_finetune_rag.sh and missing positional argument: 'logits_processor'

as it, no run_finetune_rag.sh.
i've done all the above in README.md, as that:
export HF_HOME and CHECKPOINTS. (many files have been downloaded to cache and ckpt dir and it seems work.)
cd scripts
./run_download.sh
run_data_preprocessing.sh
run_kb_index.sh
and up to then. it hasn't received any traceback
btw, i didn't create the same conda-env as conda_env.yml do. but have confirmed mainly pkgs the same version. i'll pub that if need as its too long to pub here.
then, as there is no run_finetune_rag.sh, i tried to bash run_finetune_rag_dialdoc.sh. it's maintains ok until a traceback accured after 'validation sanity check'. it seems not a pkg-version error but a coding error.
can u give a solution or just a hint for me to modify it?
Validation sanity check:   0%|                                                                                | 0/2 [00:00<?, ?it/s]
Traceback (most recent call last):
File "/datav/my/multidoc2dial/scripts/rag/finetune_rag_dialdoc.py", line 714, in
main(args)
File "/datav/my/multidoc2dial/scripts/rag/finetune_rag_dialdoc.py", line 676, in main
trainer: pl.Trainer = generic_train(
File "/datav/my/multidoc2dial/scripts/rag/lightning_base.py", line 389, in generic_train
trainer.fit(model)
File "/datav/software/anaconda3/envs/py39th19/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 510, in fit
results = self.accelerator_backend.train()
File "/datav/software/anaconda3/envs/py39th19/lib/python3.9/site-packages/pytorch_lightning/accelerators/accelerator.py", line 57, in train
return self.train_or_test()
File "/datav/software/anaconda3/envs/py39th19/lib/python3.9/site-packages/pytorch_lightning/accelerators/accelerator.py", line 74, in train_or_test
results = self.trainer.train()
File "/datav/software/anaconda3/envs/py39th19/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 532, in train
self.run_sanity_check(self.get_model())
File "/datav/software/anaconda3/envs/py39th19/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 731, in run_sanity_check
_, eval_results = self.run_evaluation(max_batches=self.num_sanity_val_batches)
File "/datav/software/anaconda3/envs/py39th19/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 643, in run_evaluation
output = self.evaluation_loop.evaluation_step(batch, batch_idx, dataloader_idx)
File "/datav/software/anaconda3/envs/py39th19/lib/python3.9/site-packages/pytorch_lightning/trainer/evaluation_loop.py", line 171, in evaluation_step
output = self.trainer.accelerator_backend.validation_step(args)
File "/datav/software/anaconda3/envs/py39th19/lib/python3.9/site-packages/pytorch_lightning/accelerators/gpu_accelerator.py", line 73, in validation_step
return self._step(self.trainer.model.validation_step, args)
File "/datav/software/anaconda3/envs/py39th19/lib/python3.9/site-packages/pytorch_lightning/accelerators/gpu_accelerator.py", line 63, in _step
output = model_step(*args)
File "/datav/my/multidoc2dial/scripts/rag/finetune_rag_dialdoc.py", line 321, in validation_step
return self._generative_step(batch)
File "/datav/my/multidoc2dial/scripts/rag/finetune_rag_dialdoc.py", line 363, in _generative_step
generated_ids = self.model.generate(
File "/datav/my/multidoc2dial/dialdoc/models/rag/modeling_rag_dialdoc.py", line 700, in generate
pre_processor = self._get_logits_processor(
TypeError: _get_logits_processor() missing 1 required positional argument: 'logits_processor'

sry, it's my fault.
with transformers==4.12.1, it works well.
but mine is 4.17.
it's pkg-version problem.
pls close this issue, thx.

No worries! Thank you for sharing the issue and the fix!


[Gekidou MM-41093] CRT - WS Events, Actions, Queries, Thread Follow, Post Query

Summary

Handle websocket events
Includes local & remote actions
CRT related queries
Query change for channel view
Thread screen follow button & mark thread as read

Ticket Link
https://mattermost.atlassian.net/browse/MM-41093
Checklist

[ ] Added or updated unit tests (required for all new features)
[x] Has UI changes
[x] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.

Device Information
This PR was tested on: iOS 15.2
Screenshots

Channel shows only root posts
Thread screen with follow option

Release Note
NONE

@anurag6713 conflicts after merging #5984


Make v24.3

PR for v24.2. Merge into main once the following has been added:

[x] #178
[x] #207
[x] #213
[x] #214
[x] #218

@NicolaCourtier @martinjrobins @agriyakhetarpal feel free to add to the above list, or comment if you think we should release without one of them. Alternatively, we this could be v24.2rc1 and we can iterate release candidates as the above gets completed (probably with a cut-off though). Closes #201.

Hi @BradyPlanden, thanks for preparing the next release!
I'm looking forward to getting all these PRs merged but to be honest, I would be happy to release in the current state. My top priority from the list would be #178 for user-friendliness, but others such as #213 will likely end up part of broader improvements, and so I would be happy to push them into the next release.
(For comparison, in the first release we added 12 features and 1 bug fix. In the current Changelog we already have 11 features and 4 bug fixes.)

Merging this as scheduled tests are passing for pybamm > 23.5 . This will be incremented for future releases as discussed in #251.


KissManga

This isn't actually an issue, but KissManga.com recently added the same captcha your captcha-remover userscript blocks on kissanime.ru
Basically I'm too lazy to install git on this computer to do a pull request(I'm using my Windows boot), so I was wondering if you could add // @match        ://kissmanga.com/ to your userscript for other users who use kissmanga. I already did it on mine and verified your script indeed removes the manga site's captchas as well, so you can just paste it in and it'll work. Thanks for the script, mate.

The script shouldn't work on Kissmanga. It uses Kissanime's captcha-free server.
Nonetheless, I tried the changes you suggested and indeed it didn't work.
By the way, you can always use GitHub's online tools to submit a PR without installing anything on your PC.


Jira-Cloud availability

Hello
Do you know when the plugin will be supported by the Cloud version of JIRA ?
Thanks
Denis

This plugin cannot work with Jira Cloud, because the plugin architecture is completely different.
My company will be looking to switch to Cloud sometime this year, so the plugin will have to be rewritten for Cloud. When that happens it won't be associated with this plugin, which is compatible with Jira Server only.


Minishift Guide / Appendix A: Using Nexus: couple of issues

At the beginning of the chapter, in subchapter A.1, the text reads "You must use oc version 3.6.0 or later". I've just tested with Minishift 1.3.1 and its default version of OpenShift Origin, which is 1.5, and it all works just fine. I think we should just remove this sentence and also, from the code block above, the command minishift config set openshift-version v3.6.0. I don't know who asked to add the 3.6 version callout -- in my experience, it's wrong.
The instructions in subchapter A.2 manually pull a bunch of Docker images, including the one for Nexus. In my experience, this step is completely unnecessary. But it's not wrong either. So maybe mark these steps as optional.
Then, in step 10 of the instructions in subchapter A.3, we have "Go to the section titled Kubernetes Pod Template, click on Add Evironmental Variable", but that's very much wrong. There can be (and will be) multiple pod templates. We have to tell user to find the one called "launchpad-maven", as that's what boosters use.
Also in step 11, the value is of the env variable is specified as nexus-NEXUS_PROJECT_NAME.LOCAL_OPENSHIFT_HOSTNAME/nexus/content/groups/public/, but that's wrong as well, it needs to be a full URL. So just prepend http:// to it. It must read http://nexus-NEXUS_PROJECT_NAME.LOCAL_OPENSHIFT_HOSTNAME/nexus/content/groups/public/.

@inoxx03 you mind taking this?

@Ladicek Thank you for the feedback:)
I'll make the changes and file a PR.


No Inputs working - Outputs are ok

Today I did a huge update, since I didn't update the last two years...
Now I'm on
Home Assistant 2023.10.1
Supervisor 2023.10.0
on a Rpi4 with RaspberryOS 11 (bullseye).
I installed ha-rpi_gpio with HACS, since the original one got lost in this update.
I also changed the config file according to the documentation of the custom integration.
switch:
  - platform: rpi_gpio
    switches:
      - port: 23
        name: "Garagentor"
        invert_logic: true
binary_sensor:
  - platform: rpi_gpio
    sensors:
      - port: 26
        name: "PV_Zaehler"
        bouncetime: 2000
        invert_logic: true

Now the one switch I have (on GPO23) is working, but the one sensor I have (on GPI26) isn't.
There is no error message in the logs, the entity does exist, but it never changes its state.
I didn't touch the installation and it worked until the update.
Can anybody help me out, as I don't actually know where to search.
Of course I tried to find an answer in the www, but didn't...
Greetings

I switched to remote-rpi_gpio, this works.

I switched to remote-rpi_gpio, this works.
Having same issues.

Can you please provide config for binary_sensor.
I wonder how to implement remote-rpi_gpio on localhost with bouncing options.

binary_sensor:
  - platform: remote_rpi_gpio
    host: localhost
    ports:
      26: PV_Zaehler

Looks like the remote-integration doesn't have bouncing options.
In fact, I just left out the previously used option, but it is surprisingly no more needed. It works better than before.
It seems, the remote-integration has internally different bouncing-routines.

binary_sensor:
  - platform: remote_rpi_gpio
    host: localhost
    ports:
      26: PV_Zaehler

Looks like the remote-integration doesn't have bouncing options.
In fact, I just left out the previously used option, but it is surprisingly no more needed. It works better than before.
It seems, the remote-integration has internally different bouncing-routines.

Did you install an additional module?
When I try a configuration like this  i have an error remote_rpi_gpio: Error on device update!

The Raspberry has to be configured for Remote-Access like described here:
https://gpiozero.readthedocs.io/en/stable/remote_gpio.html
Don‘t know if this is possible with HassOS, as I don‘t use it.
Greetings


Policy.Utils.ps1 should not use PSChildResource as parameter type

In Azure PowerShell, not all resources inherit from PSChildResource (class inheritance).
So Get-ComplianceState cannot cast this resources like PSNamespaceAttributes to PSChildResource.
Change to different object parameter like PSObject.

I think the best would be to change it to string as we only need the id resource to filter for the resource.

Fixed, so closing.


Add configurable system prompt in generate

Currently, there is no way to add a system prompt in the generate config. The prompt is treated as a user message only.

we can now add a system prompt after #1895


Translate tutorials/stateless-application/ in Korean

This PR translates content/en/docs/tutorials/stateless-application directory and the followings which is required to pass the hugo build.

content/ko/examples/application/guestbook/frontend-deployment.yaml
content/ko/examples/application/guestbook/frontend-service.yaml
content/ko/examples/application/guestbook/redis-master-deployment.yaml
content/ko/examples/application/guestbook/redis-master-service.yaml
content/ko/examples/application/guestbook/redis-slave-deployment.yaml
content/ko/examples/application/guestbook/redis-slave-service.yaml

12008

fixes #11999

@gochist 의견 반영하였습니다. 감사합니다!

@gochist 추가 수정 반영했습니다!

@Swalloow 감사합니다!
/lgtm
/approve


Place Cloud Run into VPC network

Hey there
I first create this issue to make sure I understand this correctly, before creating a PR.
I want to use my serverless functions with a private IP address. Meaning they should not be accessible from the web at all, only from within my VPC.
In the FAQ I found this:

Can I run Cloud Run applications on a private IP?
Currently no. Cloud Run applications always have a *.run.app public hostname and they cannot be placed inside a VPC (Virtual Private Cloud) network.

Some further research, however, lead to this article. The article explains how to create a function that can only be called within your VPC network. I think it would be great to update the FAQs.
Regards

There's a feature in the works to address this. You still can't have private IPs but there are ways to ensure things are accessible only within the VPC. Keep an eye on the GCP Serverless blog for announcements.


Adding Palcoin Token

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

I can help refer this https://github.com/zakimzf/profile/pull/1
PS: if you don't need my help.. please ignore this!

Any help would be appreciated!
Thank you!
On Sat, Feb 19, 2022, 5:49 AM Mohd Zakiuddin Faiz @.***>
wrote:

I can help refer this zakimzf/profile#1
https://github.com/zakimzf/profile/pull/1
PS: if you don't need my help.. please ignore this!
—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/pull/19246#issuecomment-1045999006,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARX4ZU7XQFKU5BQY2HKWSNTU357TZANCNFSM5OZPAUXA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

I'm new at this so I'm not sure I understand the problem?
Please help!
Thank you!
On Sat, Feb 19, 2022 at 10:49 AM Hal Smith @.***> wrote:

Any help would be appreciated!
Thank you!
On Sat, Feb 19, 2022, 5:49 AM Mohd Zakiuddin Faiz <
@.***> wrote:

I can help refer this zakimzf/profile#1
https://github.com/zakimzf/profile/pull/1
PS: if you don't need my help.. please ignore this!
—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/pull/19246#issuecomment-1045999006,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARX4ZU7XQFKU5BQY2HKWSNTU357TZANCNFSM5OZPAUXA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


RightSidePanel: Cannot read property 'SeriesInstanceUID' of undefined error returned

Bug Report
Describe the Bug
While working with RTSTRUCT and the OHIF viewer you are returned the error message, "RightSidePanel: Cannot read property 'SeriesInstanceUID' of undefined"
What steps can we follow to reproduce the bug?

Open the study <IP_ADDRESS>.4.1.145<IP_ADDRESS>.1706.4009.166062280490896869511085725416
Open the RTSTRUCT tab on the right
Select the second series and drag into the canvas
You are returned the error message, "RightSidePanel: Cannot read property 'SeriesInstanceUID' of undefined"

============= SESSION INFO =============
== App ==
version	4.5.21
== Extensions Versions ==
generic-viewer-commands	4.5.21
cornerstone	2.9.6
vtk	1.7.13
html	1.2.9
microscopy	0.51.3
pdf	1.0.6
com.ohif.dicom-segmentation	0.4.7
rt	0.4.9
dicom-p10-downloader	0.1.6
dicom-tag-browser	undefined
== Browser Info ==
name	 chrome
os	 Windows 10
type	 browser
version	 86.0.4240
== URL ==
URL	 <IP_ADDRESS>.4.1.145<IP_ADDRESS>.1706.4009.166062280490896869511085725416
== Viewport Layout ==
Rows	1
Columns	1
== Viewports ==
[0,0]	<IP_ADDRESS>.4.1.145<IP_ADDRESS>.1706.4009.235001741732391381168268744865

This is probably related to #2117

@madelyngreyes @fedorov fixed here: #2168.
This study contains only CT (which has RTStructs in it) and RTDOSE modalities. Currently we check only for RTSTRUCT in the RT extension, thats why things were broking. Now the panel button will only show for non-empty RTStructs.

This study contains only CT (which has RTStructs in it)

Can you clarify what you mean by the above, that CT contains RTStructs?

Update: The problem was caused by a reactivity bug with the panel and the active viewport, the loading should only appear for rtstructs and be empty otherwise. I have updated the PR so now the panel will behave correctly.

@madelyngreyes can you please confirm if this is fixed in the testing tier?

I seem to be returning a different error with the ToolBarRow this time.

@madelyngreyes so it is the same as in https://github.com/OHIF/Viewers/issues/2117#issuecomment-741823904

Currently PR51 is live in the dev tier, running the steps from the original bug you are no longer returned an error message but, a blank RT Structure sets panel. Study used is, "<IP_ADDRESS>.4.1.145<IP_ADDRESS>.1706.4009.166062280490896869511085725416"

Text could be added, "No data available" to make it clear to the end user.

I think when RTSTRUCT does not apply to the specific image series, the button and the panel should not be shown.

I think when RTSTRUCT does not apply to the specific image series, the button and the panel should not be shown.

@fedorov I think we missed this one during the last call, this one should be prioritized as well?

I think when RTSTRUCT does not apply to the specific image series, the button and the panel should not be shown.

@fedorov I think we missed this one during the last call, this one should be prioritized as well?

this one should be prioritized as well?

Yes!

this one should be prioritized as well?

Yes!


Prevent removal of jQuery data from tags within editor

Hey,
First of all ... ContentTools has been a lifesaver ! .. so thank you for all the effort you guys have put into it.
So in our use case there are several jQuery plugins that attach data to HTML tags within the content, and rely on this data to work properly. However, as soon as the ContentTools editor initializes all data associated with the DOM elements within the editor is removed / unlinked.
This can be because of several reasons, two of which may be:

ContentTools actually removes all data on each DOM element.
ContentTools removes and reinserts the content in a way that does not retain any of the previously attached jQuery data.

jQuery recommends using detach() instead of remove() to preserve any jQuery data attached to the DOM elements, if they need to be removed, modified and appended again.
I hope there's a solution, or a way around this. The inline editor we were previously using did preserve all jQuery data.
Have a great day, and best of luck with everything.

Hey Anthony, just wondering if there are any updates. :) Thanks.

Hi @Smashr,
So as you suspected ContentTools does remove all elements from the page and re-add them (that's effectively the role of mount and unmount against the base Element class.
 I can think of a couple of approaches you might take to get around this, but none are ideal. For example you could override the fromDOMElement against each ContentEdit element type (e.g https://github.com/GetmeUK/ContentEdit/blob/master/src/scripts/text.coffee#L838) and store a reference to the original element against the new editable element, for example:

    @fromDOMElement: (domElement) ->
        # Convert an element (DOM) to an element of this type
        elm = new @(
            domElement.tagName,
            @getDOMElementAttributes(domElement),
            domElement.innerHTML
            )
        elm._originalElement = domElement
        return elm

This would in theory allow you to access the data help against the original element and possibly reattach it (though the approach you take to doing this will depending on what it is your attempting to do).
The other possible approach would be to use datasets (e.g data-foo="bar") and serialize the data you're storing (as ContentEdit would duplicate data- attributes). This is possible the simplest in terms of not having to override anything in ContentEdit/Tools.
I might be able to offer some better solutions if I can see some examples of what your doing with the stored data.
Hope that's of some help at least,
Ant


test

Coverage decreased (-0.4%) to 89.315% when pulling fc04f739a96c3825a5d9fa9920238e75adb4176c on PDC-1719 into acc650a93adafce12a51b7712414639416d0428d on master.

Coverage decreased (-0.4%) to 89.315% when pulling 7da367ef697f6e40ae3487e3ec7a74dd27d8ccbf on PDC-1719 into acc650a93adafce12a51b7712414639416d0428d on master.


Update Proxy SHA to latest (release-1.1).

Signed-off-by: Piotr Sikora<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: PiotrSikora
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hklai
If they are not already assigned, you can assign the PR to them by writing /assign @hklai in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PiotrSikora: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
1740d7cf5eaa379647ec193a271564764cf52182
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PiotrSikora: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
1740d7cf5eaa379647ec193a271564764cf52182
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
1740d7cf5eaa379647ec193a271564764cf52182
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PiotrSikora: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
1740d7cf5eaa379647ec193a271564764cf52182
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
1740d7cf5eaa379647ec193a271564764cf52182
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
1740d7cf5eaa379647ec193a271564764cf52182
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PiotrSikora: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
1740d7cf5eaa379647ec193a271564764cf52182
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
1740d7cf5eaa379647ec193a271564764cf52182
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
1740d7cf5eaa379647ec193a271564764cf52182
link
/test istio-presubmit

prow/istio-integ-k8s-tests.sh
1740d7cf5eaa379647ec193a271564764cf52182
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@PiotrSikora: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
1740d7cf5eaa379647ec193a271564764cf52182
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PiotrSikora: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
1740d7cf5eaa379647ec193a271564764cf52182
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
1740d7cf5eaa379647ec193a271564764cf52182
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/assign @duderino @wenchenglu

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: PiotrSikora, wenchenglu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hklai
If they are not already assigned, you can assign the PR to them by writing /assign @hklai in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Doc header wrapping

Can you adjust the header menu so it doesn't wrap when the window gets narrower before it disappears when the window width reached the threshold where it becomes a burger button?
At about 800 wide:

At 900 or so that I'd like it to keep to down to burger button width:

No longer an issue.


Summary functions added

New Features

summary

allMatch()
anyMatch()
noneMatch()

Stream

allMatch()
anyMatch()
noneMatch()

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

21 of 21 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
470

Relevant Lines:
470

💛  - Coveralls


feat: #119645 Add detection for Samsung internet browser

Prerequisites
Please make sure you can check the following boxes:

[x] My code follows the code style of this project
[x] All new and existing tests passed
[x] Fix any eslint/prettier warnings/errors: npm run lint
[x] Remove unnecessary console.log (use logInfo logWarn if it's needed)
[x] Are variable and function names properly describing what it does?

Type(s) of Changes
Contribution Type
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
[x] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes

Description
Added detection of Samsung Internet browser.
Justification for PR: https://dev.azure.com/EquinorASA/Echo/_sprints/backlog/Discovery one/Echo/Increment 2 - 2023Q2/Sprint 3 (summer)?workitem=119645
https://gs.statcounter.com/browser-market-share/mobile/norway

Thanks @OveBDev! Forgot to change PR to draft, as I was unsure if the us had to be EchoUtils specific or if it could come from another project. Does it look good now?


Include a live demo of streamlit-ace using Streamlit sharing

I absolutely love this component and thought it would be great to have a live demo of it, so I created one here.
Note that I created this demo using my own Streamlit sharing account!
This is suboptimal because any changes you make to the package won't be reflected in the demo. Therefore, I would suggest deploying your own Streamlit sharing demo and updating the links in the Readme.md.
If you don't have a Streamlit sharing invite, you can request one in the forums and we'll fast-track one for you.
Thanks for making such an awesome component!

Hello @treuille, thanks alot for the kind words and this pull request!
I've already asked TC Ricks to get an access (which I have now), for this exact purpose actually, migrate my old example scripts to sharing demos, but I've been quite busy recently. I'll try to get it done by the end of this week, for this ace comp' and the others as well ;)


update README.md

correction of wrong url in the recipe badge.

Pull Request Test Coverage Report for Build 2030

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 95.268%

Totals

Change from base Build 2014:
0.4%

Covered Lines:
9232

Relevant Lines:
9576

💛  - Coveralls

Pull Request Test Coverage Report for Build 2030

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 95.268%

Totals

Change from base Build 2014:
0.4%

Covered Lines:
9232

Relevant Lines:
9576

💛  - Coveralls


Concurrent fetches are slower than sequential

In IPWB (an web archiving replay system) we store archived HTTP headers and payloads in two separate objects for better deduplication of payloads. At the time of replay, we fetch the two objects, combine them, make necessary modifications, and return the response to the client. In our initial implementation we used to fetch the two objects sequentially, but there is an opportunity to perform these fetches concurrently and minimize the response time.
Recently, we experimented with Python threads (https://github.com/oduwsdl/ipwb/pull/425), but the response time became worse than before. A simple ApacheBench test took over 17 seconds with threaded fetches while the same took less than 8 seconds with sequential code.
To ensure that we can reproduce the issue in an isolated environment, I have created a separate repository, IPFS API Concurrency Test, to test this behavior. While the #59 suggests that the API is not async-friendly, I am not sure how related it is to this issue. I would assume, with concurrent threads it should not take any longer to finish if not quicker. The worst case time should still be bound by the sequential access time. However, my profiling results are showing the opposite. The more concurrent requests are made, the slower it becomes.
======= SUMMARY =======
Data Items:      1
Fetch Attempts:  10
Mean Fetch Time (Sequential):  0.0025439024 seconds/item
Mean Fetch Time (Threaded):    0.0021895885 seconds/item

======= SUMMARY =======
Data Items:      2
Fetch Attempts:  10
Mean Fetch Time (Sequential):  0.0037424684 seconds/item
Mean Fetch Time (Threaded):    0.0042521000 seconds/item

======= SUMMARY =======
Data Items:      3
Fetch Attempts:  10
Mean Fetch Time (Sequential):  0.0027309577 seconds/item
Mean Fetch Time (Threaded):    0.0067453702 seconds/item

======= SUMMARY =======
Data Items:      4
Fetch Attempts:  10
Mean Fetch Time (Sequential):  0.0036935270 seconds/item
Mean Fetch Time (Threaded):    0.0087552428 seconds/item

======= SUMMARY =======
Data Items:      5
Fetch Attempts:  10
Mean Fetch Time (Sequential):  0.0041139285 seconds/item
Mean Fetch Time (Threaded):    0.0102155050 seconds/item

There was an issue in my benchmarking script that was calculating the elapsed time wrongly. That's why threaded fetch times are reported longer than they should have been. However, results are still not how I would like them to be. Following are some timing summaries with single iteration for different number of concurrent item fetches.
======= SUMMARY =======
Data Items:      1
Fetch Attempts:  1
Mean Fetch Time (Sequential):  0.0068359375 seconds/item
Mean Fetch Time (Threaded):    0.0084149837 seconds/item

======= SUMMARY =======
Data Items:      2
Fetch Attempts:  1
Mean Fetch Time (Sequential):  0.0067210197 seconds/item

======= SUMMARY =======
Data Items:      3
Fetch Attempts:  1
Mean Fetch Time (Sequential):  0.0077099800 seconds/item
Mean Fetch Time (Threaded):    0.0101859570 seconds/item

======= SUMMARY =======
Data Items:      4
Fetch Attempts:  1
Mean Fetch Time (Sequential):  0.0027137399 seconds/item
Mean Fetch Time (Threaded):    0.0028825402 seconds/item

======= SUMMARY =======
Data Items:      5
Fetch Attempts:  1
Mean Fetch Time (Sequential):  0.0063509941 seconds/item
Mean Fetch Time (Threaded):    0.0098129749 seconds/item

Hmm… Looking at your benchmarking script it immediately strikes me that you create/destroy a thread for each request. That definitely decreses performance, try using concurrent.futures.ThreadPoolExecutor for making these calls instead (keep the thread pool alive during the entire lifetime of the application).
If you're ready for real async please try my async branch; I'd really like to have some feedback on this.
Minimal example code would be something like this (Python 3.5+, untested):
import asyncio
import sys

import ipfsapi

async def do_test(client):
	hashes = await asyncio.gather(
		client.add_bytes(b"bla1"),
		client.add_bytes(b"bla2"),
		client.add_bytes(b"bla3")
	)
	contents = await asyncio.gather(
		client.cat(hashes[0].result()),
		client.cat(hashes[1].result()),
		client.cat(hashes[2].result())
	)

async def amain(argv=sys.argv[1:], loop=asyncio.get_event_loop()):
	async with ipfsapi.connect_async(session=True, loop=loop) as client:
		do_test(client)
loop = asyncio.get_event_loop()
loop.run_until_complete(amain(loop=loop))

Hmm… Looking at your benchmarking script it immediately strikes me that you create/destroy a thread for each request. That definitely decreses performance, try using concurrent.futures.ThreadPoolExecutor for making these calls instead (keep the thread pool alive during the entire lifetime of the application).

While in our actual application we can certainly use persistent thread pools, in the benchmarking script however we are reporting timing in two different ways. If you look at the sample output in the benchmark repo's README file, attempts on individual items are reporting elapsed time only for the cat() call, while the summary of each attempt as well as the overall summary reports the overall execution time which includes any thread overhead. It is surprising to see that cat calls executed in individual threads are taking roughly as much time (sometimes even more) as all the sequential calls combined.

If you're ready for real async please try my async branch; I'd really like to have some feedback on this.

This could be a really good approach, however it will enforce us to use Py3 in IPWB (currently it is only Py2 supported). I am personally in favor of just supporting Py3 and not Py2 (https://github.com/oduwsdl/ipwb/issues/51#issuecomment-350320934), but @machawk1 insists on continuing to support Py2.

Aside: if we can achieve the anticipated speedup using async/threading, it might be worth supporting only Python 3 in ipwb.


completion.bash is missing from fzf/jammy,now 0.29.0-1 amd64

[ X] I have read through the manual page (man fzf)
[ X] I have the latest version of fzf
[ X] I have searched through the existing issues

Info

OS

[ X] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ X] bash
[ ] zsh
[ ] fish

Problem / Steps to reproduce
sudo apt update && sudo apt install fzf
instructions for keyboard integration says:
warning Key bindings (CTRL-T / CTRL-R / ALT-C) and fuzzy auto-completion may not be enabled by default.
Refer to the package documentation for more information. (e.g. apt-cache show fzf)

This asks you to read `/usr/share/doc/fzf/README.Debian`

extract from /usr/share/doc/fzf/README.Debian:
Bash
====

Append this line to ~/.bashrc to enable fzf keybindings for Bash:

   source /usr/share/doc/fzf/examples/key-bindings.bash

Note, since fzf 0.29.0-1, the bash completion is installed for bash
by default. Feel free to ignore the following instruction for fzf >= 0.29.0-1.
Append this line to ~/.bashrc to enable fuzzy auto-completion for Bash:

   source /usr/share/doc/fzf/examples/completion.bash

 /usr/share/doc/fzf/examples/completion.bash is not installed by the package

Please see #2790


Set pipeline thread stack size

PR Summary
Fix #4268
Overlap #5927 (see PowerShell Committee conclusion)
Set default stack size in 10 MB for local pipeline threads.
Each platform uses different default for the thread stack size:
- Windows 2 MB
- Linux   8 Mb
- MacOs   512 KB
We should use the same default for all platforms to get predictable behavior.
PR Checklist
Note: Please mark anything not applicable to this PR NA.

[x] PR has a meaningful title

[x] Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[ ] User facing Documentation needed

[ ] Issue filed - Issue link:

[x] Change is not breaking
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

@daxian-dbw Thanks for fast review and help!


Add Workspace ID to LinearRepository

Enhanced LinearRepository and corresponding Editor to include a 'Workspace ID' field. Users can now specify a workspace ID during configuration, which is stored and presented alongside the team ID. This will allow specific workspace handling within a Linear team.
Fixes #155

Thank you! It works! :heart_eyes:

Thanks for the confirmation!


roswww: 0.1.9-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository roswww to 0.1.9-0:

upstream repository: https://github.com/tork-a/roswww.git
release repository: https://github.com/tork-a/roswww-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.21
previous version for package: 0.1.8-0

roswww
* Changed the target topic to communicate other samples, Rename from chat.launch to start_bridge.launch (#33 <https://github.com/tork-a/roswww/issues/33>)
* add example for talker and listener (#33 <https://github.com/tork-a/roswww/issues/33>)
* [doc] trying to fix that module api doc is gone inaccessible (#32 <https://github.com/tork-a/roswww/issues/32> )
* Contributors: Isaac I.Y. Saito, Kei Okada, Kenta Yonekura

We're in a  quiet period holding indigo releases in preparation for a sync. If it's important for this to be in the sync please comment on the  ros-release thread titled Preparations for final releases for Saucy, Utopic, and Vivid for Indigo and Jade April 1st.


Need an explanation for IPv6 address in firewall rule

[Enter feedback here]
It was not possible to add the IPv6 address for Firewall Rule
Today I tried to configure the Firewall Rule for Azure Database for MySQL by using IPv6 address.
At that time, I faced following issue.
In fact, If I used the IPv6 address ,the command showed following error.
If I changed the IP address from IPv6 to IPv4, it worked fine.
$ export PUBLIC_IP=$(curl ifconfig.io)
$ echo $PUBLIC_IP
240d:1a:***:****:****:****:aa1e:b91c //<-------------IPv6 Address
$ az mysql server firewall-rule create \
>     -g $MYSQL_RES_GRP_NAME \
>     -s $MYSQL_SERVER_NAME \
>     -n allowip_fromcloudshell2 \
>     --start-ip-address $PUBLIC_IP \
>     --end-ip-address $PUBLIC_IP
validation error: Parameter 'FirewallRule.start_ip_address' must conform to the following pattern: '^(([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])$'.

If the environment has an IPv4 restriction, it may be very useful for customer to explain the detail of the restriction.
And also, if there is a workaround for IPv6 client, could you explain how to configure it in the document?
I assume that the information and explanation for IPv6 is needed on following documents.
https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/mysql/concepts-firewall-rules.md
https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/mysql/howto-manage-firewall-using-cli.md
https://github.com/MicrosoftDocs/azure-docs-cli/blob/master/latest/docs-ref-autogen/mysql/server/firewall-rule.yml
And I assume that this is not only affect to MySQL but also PostgreSQL and SQL Server?
If it is so, it is also should be explained.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3943cb2e-ed20-044d-d78f-19280ebc23da
Version Independent ID: d3d718b8-86e5-a28f-0477-e35fb577a61a
Content: Firewall rules - Azure Database for MySQL
Content Source: articles/mysql/concepts-firewall-rules.md
Service: mysql
GitHub Login: @savjani
Microsoft Alias: pariks

@yoshioterada We are checking this and will get back to you.

@yoshioterada Can you please use the same script with raw IP address and not use the $PUBLIC_IP variable and check the results.
Please do share the test results with us.

@NavtejSaini-MSFT - Can you please assign this to @ambhatna to follow-up on this one. We may have to update this limitation in the documentation

Thank you for confirming @savjani.
@yoshioterada We are assigning this case to our doc author @ambhatna for review.

Hi @yoshioterada, Thank you for the feedback. As discussed offline. I have updated the documentation with the limitation. Please refer to the PR: https://github.com/MicrosoftDocs/azure-docs-pr/pull/140348

@yoshioterada , @NavtejSaini-MSFT - Are we good to close this ?

@yoshioterada , @NavtejSaini-MSFT - Are we good to close this ?

I confirmed the document was updated. Thank you so much for adding the explanation.
Please close the bug.
Thank you & Best Regards.
Yoshio.

I confirmed the document was updated. Thank you so much for adding the explanation.
Please close the bug.
Thank you & Best Regards.
Yoshio.