gps: ./hack/lint.bash fixes

What does this do / why do we need it?
This PR fixes ./hack/lint.bash failures, by directly returning errors and removing unused functions/types.
Do you need help or clarification on anything?
Should the errors be wrapped?

we just added the prune funcs - I don't know why the linters are complaining about unused exported funcs (also, wait what, I thought we had tests for those funcs), but we need to keep those. if we have failures, we need to add exceptions for them to the linters, not remove the code

the other change is :+1: though

I don't know why the linters are complaining about unused exported funcs

Because they are internal?

linters generally only take the current package scope into context, since they operate on a per package basis. so, maybe? but it wouldn't be my first guess
On September 24, 2017 9:03:35 AM EDT, Jordan Krage<EMAIL_ADDRESS>wrote:

I don't know why the linters are complaining about unused exported
funcs

Because they are internal?
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
https://github.com/golang/dep/pull/1217#issuecomment-331708760

https://github.com/dominikh/go-tools/tree/master/cmd/unused#whole-program-analysis

(also, wait what, I thought we had tests for those funcs)

I knew something was missing... 🤦♂


NativeAd - Huge Performance issues

Plugin Version : 0.13.2
I have NativeAd widgets inside a ListView.
I am testing on an Android device : version 9, Samsung Note 8.
Without Native Ads:

With Native Ads:

Reproducing is simple, create a listview with 100 items and 5 nativeAds.
Thank you

I have created a public Github repository to reproduce the problem: Link
Here is a video showing the problem from the testing app above:
https://user-images.githubusercontent.com/45078310/124322841-8050ae00-db80-11eb-9e2a-c2d8f1557e5f.mp4

Hi @mkassan , I'm struggling with the setting up for native ad. Can you please show me your settings for this one ?

Hi @ninoorta, you can refer to my example code described in the Link above shared with the video.
It is a mini-app that demonstrates the issue.

Thank you @mkassan . I will check it out.

Excuse me, @mkassan , Did your app just work fine three days ago, right ? Can you check the native ad one more time please ? When I start the project, it gives me the ad error code 0

Excuse me, @mkassan. Your app just worked fine three days ago, right?
Can you check the native ad one more time, please?
When I start the project, it gives me the ad error code 0

hi, @ninoorta
Error Code 0 : ERROR_CODE_INTERNAL_ERROR
This indicates that something happened internally; for instance, an invalid response was received from the ad server.

@tp-coderbabu yup, so it means there is nothing I can do to prevent it , right ?

@tp-coderbabu yup, so it means there is nothing I can do to prevent it, right?

yes wait for sometimes then check it again
please refere: https://support.google.com/admob/thread/3494603/admob-error-codes-logs?hl=en

@tp-coderbabu yup, so it means there is nothing I can do to prevent it, right?

yes wait for sometimes then check it again
please refere: https://support.google.com/admob/thread/3494603/admob-error-codes-logs?hl=en

That's bad. Thank you

Any news about this issue?
If you are facing the same issue, can you upvote this thread please?
Thank you

This has been happening since this plugin existed, no news, this plugin is unusable. You can try native_admob_flutter. Sorry.
I wish I could give my users a better experience with native ads, but sadly no. The code would be ready to ship. If this lag wasn't there.

I have seen native_admob_flutter.
The problem is that in my use case, it will not help.
From what I have seen, It allows a single instance of native ads, so it is not thought to be used inside lists.
On the other hand, from their documentation, it supports NativeAds only for Android and not for iOS.

I know, like I said: since I'm using native_admob_flutter, I can not use native ads either. I already had the code ready with this plugin, but it was too laggy. They won't fix, I'm afraid.  Sorry.

Same issue

We have added a flag to the Flutter master channel that helps improve the performance.
It's not a perfect fix since the Ad may be a few frames behind the Flutter frame, but depending on the layout you use, it could be useful.
Please try it out, and let us know if the performance is improved.
To use this flag, set PlatformViewsService.synchronizeToNativeViewHierarchy(false).  For example:
import 'package:flutter/services.dart';

void main() {
   PlatformViewsService.synchronizeToNativeViewHierarchy(false);
   runApp(MyApp());
}

I'm closing this issue, and moving the conversation to: https://github.com/googleads/googleads-mobile-flutter/issues/269


parentheses rendering error in php file

parentheses rendering error in php file,atom v1.25.1

Thanks for taking the time to contribute!
We noticed that this is a duplicate of https://github.com/atom/language-php/issues/321. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Raspian OS

Raspian OS comes with python 3.9 out the box.

That is a statement not an issue. I belive FTS issnt meant to work/issnt supported on 3.9


Fixes #3692++ - Rearchitects drivers

This is a super set of #3791 and exists to see diff and direction of v2 drivers as discussed in #3821
Fixes

Fixes #3892
Fixes #3692
Fixes #2319
Fixes #2803
Fixes #2610
Might fix #3312
Might fix #3404
Might fix #3374

Progress

Keyboard

[x] Exit
[x] Typing
[x] Backspace

Views

[x] Run/RequestStop
[x] MenuBar

Mouse (see MouseInterpreter)

[x] Button 1 click
[x] Multi clicks
[x] All buttons
[x] Scroll wheel

Other

[x] Clipboard

Proposed Changes/Todos
Splits drivers up into logical components, simplifies and centralizes shared code patterns.

Pull Request checklist:

[x] I've named my PR in the form of "Fixes #issue. Terse description."
[x] My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
[x] My code follows the Terminal.Gui library design guidelines
[ ] I ran dotnet test before commit
[ ] I have made corresponding changes to the API documentation (using /// style comments)
[ ] My changes generate no new warnings
[ ] I have checked my code and corrected any poor grammar or misspellings
[x] I conducted basic QA to assure all features are working

Hope you're ok with me updating the title & first post...

Hope you're ok with me updating the title & first post...

No problem! Always appreciate a clear naming
Now we have fledgling support for

Keyboard
Mouse
Screen size

Net (i.e. native dotnet) and Windows (i.e win 32 api) are the two implementations - I assume we can drop curses?

Working on it but I think this is how I want to handle mouse.  It needs work but goal is to capture all the relevant info as you would on desktop and only release events when sure of end users behaviour:
This would all be internal to the state machines initially and may just surface with the existing API until our events system aligns.
#nullable enable

namespace Terminal.Gui;

public class MouseStateManager
{
    /// <summary>
    /// Function for returning the current time. Use in unit tests to
    /// ensure repeatable tests.
    /// </summary>
    private Func<DateTime> Now { get; set; }

    /// <summary>
    /// How long to wait for a second click after the first before giving up and
    /// releasing event as a 'click'
    /// </summary>
    public TimeSpan DoubleClickThreshold { get; set; }

    /// <summary>
    /// How long to wait for a third click after the second before giving up and
    /// releasing event as a 'double click'
    /// </summary>
    public TimeSpan TripleClickThreshold { get; set; }

    /// <summary>
    /// How far between a mouse down and mouse up before it is considered a 'drag' rather
    /// than a 'click'. Console row counts for 2 units while column counts for only 1. Distance is
    /// measured in Euclidean distance.
    /// </summary>
    public double DragThreshold { get; set; }

    public MouseState CurrentState { get; private set; }

    private ButtonNarrative? [] _ongoingNarratives = new ButtonNarrative? [4];

    public MouseStateManager (
        Func<DateTime>? now = null,
        TimeSpan? doubleClickThreshold = null,
        TimeSpan? tripleClickThreshold = null,
        int dragThreshold = 5
    )
    {
        Now = now ?? (() => DateTime.Now);
        DoubleClickThreshold = doubleClickThreshold ?? TimeSpan.FromMilliseconds (500);
        TripleClickThreshold = tripleClickThreshold ?? TimeSpan.FromMilliseconds (1000);
        DragThreshold = dragThreshold;
    }

    /// <summary>
    ///
    /// </summary>
    /// <param name="e"></param>
    /// <returns></returns>
    public IEnumerable<ButtonNarrative> UpdateState (MouseEventArgs e)
    {
        // TODO: manage transitions

        for (int i = 0; i < 4; i++)
        {
           // Update narratives

           // Release stale or naturally complete ones based on thresholds
        }
    }

    /// <summary>
    /// If user double clicks and we are waiting for a triple click
    /// we should give up after a short time and just assume no more
    /// clicks are coming. Call this method if the state for a given button
    /// has not changed in a while.
    /// </summary>
    /// <returns></returns>
    public ButtonNarrative? ReleaseState (int button)
    {

    }

    private void PromoteSingleToDoubleClick ()
    {

    }
    private void PromoteDoubleToTripleClick ()
    {

    }

    public static double DistanceTo (Point p1, Point p2)
    {
        int deltaX = p2.X - p1.X;
        int deltaY = p2.Y - p1.Y;
        return Math.Sqrt (deltaX * deltaX + deltaY * deltaY);
    }
}

/// <summary>
/// Describes a completed narrative e.g. 'user triple clicked'.
/// </summary>
/// <remarks>Internally we can have a double click narrative that becomes
/// a triple click narrative. But we will not release both i.e. we don't say
/// user clicked then user double-clicked then user triple clicked</remarks>
public class ButtonNarrative
{
    public int Button { get; set; }
    public int NumberOfClicks { get; set; }

    /// <summary>
    /// Mouse states during which click was generated.
    /// N = 2x<see cref="NumberOfClicks"/>
    /// </summary>
    public List<ButtonState> MouseStates { get; set; }

    /// <summary>
    /// <see langword="true"/> if distance between first mouse down and all
    /// subsequent events is greater than a given threshold.
    /// </summary>
    public bool IsDrag { get; set; }
}

public class MouseState
{
    public ButtonState[] ButtonStates = new ButtonState? [4];

    public Point Position;
}

public class ButtonState
{
    /// <summary>
    ///     When the button entered its current state.
    /// </summary>
    public DateTime At { get; set; }

    /// <summary>
    /// <see langword="true"/> if the button is currently down
    /// </summary>
    private bool Depressed { get; set; }

    /// <summary>
    /// The screen location when the mouse button entered its current state
    /// (became depressed or was released)
    /// </summary>
    public Point Position { get; set; }

    /// <summary>
    /// The <see cref="View"/> (if any) that was at the <see cref="Position"/>
    /// when the button entered its current state.
    /// </summary>
    public View? View { get; set; }

    /// <summary>
    /// True if shift was provided by the console at the time the mouse
    ///  button entered its current state.
    /// </summary>
    public bool Shift { get; set; }

    /// <summary>
    /// True if control was provided by the console at the time the mouse
    /// button entered its current state.
    /// </summary>
    public bool Ctrl { get; set; }

    /// <summary>
    /// True if alt was held down at the time the mouse
    /// button entered its current state.
    /// </summary>
    public bool Alt { get; set; }
}

Working on it but I think this is how I want to handle mouse.

Wow. I think I really like this!!
Can you write a paragraph that would go in the intro of mouse.md that describes the overall model in plain English, using the word "narrative"? This will go a long way to helping me understand your intent, and helping ensure your thinking is clear.

I've updated the initial post with the new diagram of how IApplication fits in.  Theres a lot of work to knit things together to work robustly.  Theres just so much complexity in the existing code!

Invoke, Idle and Timeout support in v2.
I refactored into a new class with interface ITimedEvents that is decoupled from main loop.
Currently still same code implementation but in future we can work on it seperately from main loop.

Animation running in v2 with timed events, note the exit code 0, indicating we can also exit the app!

@BDisp I am struggling to figure out this bug I have with the new WindowsOutput
It seems to render correctly to the screen but then clear again immediately or something.
You can see by uncommenting the line:
                // Uncomment this to see that it does render properly :/
                // Process.GetCurrentProcess ().Kill();

I can't figure out what is clearing it or making the terminal not show - do you have any ideas?

It was working correctly in a small test project, and the NetDriver style NetOutput works correctly (you can change to net driver by doing following):
-        if ( p == PlatformID.Win32NT || p == PlatformID.Win32S || p == PlatformID.Win32Windows)
-        {
-            var inputBuffer = new ConcurrentQueue<WindowsConsole.InputRecord> ();
-            var loop = new MainLoop<WindowsConsole.InputRecord> ();
-            _coordinator = new MainLoopCoordinator<WindowsConsole.InputRecord> (TimedEvents,
-                                                                                () => new WindowsInput (),
-                                                                                inputBuffer,
-                                                                                new WindowsInputProcessor (inputBuffer),
-                                                                                () => new WindowsOutput (),
-                                                                                loop);
-        }
-        else
-        {
            var inputBuffer = new ConcurrentQueue<ConsoleKeyInfo> ();
            var loop = new MainLoop<ConsoleKeyInfo> ();
            _coordinator = new MainLoopCoordinator<ConsoleKeyInfo> (TimedEvents,
                                                                    () => new NetInput (),
                                                                   inputBuffer,
                                                                   new NetInputProcessor (inputBuffer),
                                                                   () => new NetOutput (),
                                                                   loop);
-        }

Any help would be greatly appreciated

Sorry I couldn't found the cause of this issue. My laptop overheat running it. I thought the cause was due to the recursive write which doesn't allow the driver show the output, but enabling the conditional if (s != _lastWrite) it still doesn't output anything. I also add this conditional to avoid always clear the contents, but still remain the issue.
        if (OutputBuffer.Cols != size.Width || OutputBuffer.Rows != size.Height)
        {
            OutputBuffer.SetWindowSize (size.Width, size.Height);
        }

You have to see when this issue started happening to check the commit that cause it.

Found one issue,  WindowsConsole which I thought was just helper functions - it actually spins up an infinite loop of its own to read console input with no delay.
I have turned it off based on bool to constructor and now you can at least boot and Esc to exit WindowsDriver and see the output! But still there is the issue of clearing even if you change the wait period to 500ms etc.
One of the tenants of v2 is to prevent any view refreshing, pushing output, clearing screen etc ever.
Instead the view has to notify its intent e.g. via SetNeedsDisplay and then MainLoop (the new loop) does it once at the end of the iteration.
9a72628d354fbc419086ba8232e987b648f60479

Maybe the output is being written to one screen buffer but app has switched to another and it only comes back on exit the app?

Maybe it's using a different output handle than the original.

I have WindowsOutput on one thread and WindowsInput on a different one, perhaps the output is writing to the buffer that the input one is using while also creating its own or something.

Output and input handles are separated from each other. You make ensures recreating the handles after shutdown and not during. Make sure the handles isn't changed during a normal iteration.

Windows Output driver working :) I stopped using WindowsConsole and just copied relevant methods across to WindowsOutput instead.  I think issue was wrong handle.

@tig how far are we along the route of making it so MenuBar and StatusBar are not 'special views' that sit outside of the hierarchy (i.e. outside of Application.Top).
I am trying to get the new main loop to work as follows:

Nobody is allowed to 'ad hoc draw' i.e. Driver.Refresh does nothing
Exclusively operate on NeedsDisplay / NeedsLayout
Draw only once at the end of the main loop and only if views need it

Currently this results in menu/status bar disapearing.  This is the current 'brute force' draw approach:
 public void Iteration ()
 {
     InputProcessor.ProcessQueue ();

     if (Application.Top != null)
     {
         bool needsDrawOrLayout = AnySubviewsNeedDrawn(Application.Top);

         if (needsDrawOrLayout)
         {
             // TODO: throttle this
             var size = Out.GetWindowSize ();

             OutputBuffer.SetWindowSize (size.Width, size.Height);

             // TODO: Test only

             Application.Top.Layout ();
             Application.Top.Draw ();

             Out.Write (OutputBuffer);
         }
     }

     TimedEvents.LockAndRunTimers ();

     TimedEvents.LockAndRunIdles ();
 }

 private bool AnySubviewsNeedDrawn (View v)
 {
     if (v.NeedsDraw || v.NeedsLayout)
     {
         return true;
     }

     foreach(var subview in v.Subviews )
     {
         if (AnySubviewsNeedDrawn (subview))
         {
             return true;
         }
     }

     return false;
 }

Ok most stuff works and cpu sits at about 0%
Now needs loads of tests and to round out a few implementations like all the various key translations, double click etc
I think I will add ILogger support so we can see things like ignored ansi codes, record where/if there is slowdown etc

Ok I need to work a bit on my understanding of how to integrate Application.Run.
The users main entry thread for Program.cs is going to call Application.Init and then Run.
That method will 'block' but it also is the thread that processes Click events e.g. if the user wants to Run another View.
Currently I have 2 main threads

Input Loop
Everything else loop (output, timers, layout, draw etc)

But I'm realizing now that that is an issue for integrating with Run.  Because Run has to appear to block but still process user event code (e.g. click) and be able to put another Run call onto the csharp call stack.
Any insight into my understanding of things or suggestions would be welcome - especially clarifications on how it is currently working as its a bit opaque.
This is my vision for how v2 will work.  At the moment Run just blocks and loops, looking at the state of the coordinator.  But that does not work well for starting a nested Run or exiting a nested Run back into the parent Run.

Ok I have got it! Looking at the existing codebase the 'Iterate/Output' loop that I have on its own thread is actually called repeatedly within Run.  This means that the entry thread the application has in their program is the one that the UI code is all running on.
That makes sense and is 1 less thread so I'm up for it.  Now you can open and close as many scenarios as you want.

Have started looking at logging (using defacto standard System.Extensions.Logging).  I've used Serilog for UICatalog but any logging framework will be compatible in end users applications. It would be nice to throw if user tries to set a console logger but probably impractical to do reliably.
For metrics I'm less certain on the 'standard' approach.  After a couple of false starts I found the Meter class in System.Diagnostics.Metrics which seems to be a good fit for performance logging:
To see metrics realtime for running process you can run:
dotnet tool update -g dotnet-counters
dotnet-counters monitor -n UICatalog --counters Terminal.Gui

File logging in client program UICatalog using Serilog dependency + metrics monitoring via dotnet-counters

I have dialed MouseInterpreter way back to just do the existing click behaviours including repeat click.  It was getting too complicated and it doesnt actually make sense to delay reporting click to see if there is double click - so it is back to reporting click,double then triple.

Ok this is notionally ready for first pass review
I'm onto the final phase now

[ ] Warnings (NRT, xmldoc etc)
[ ] Unit tests
[ ] All the corner cases I'm forgetting about

You can run with:

Once this is merged and well tested we can have an epic deleting session to remove the old drivers - if we want to that is.

@BDisp can you see if you can see why right click context menus are not popping? I guess something about the mouse event(s) in v1 vs v2?


I installed php-5.3.29 sucessfull but testing with phpinfo.php I only get a blank page

Since installation of phpbrew I cannot run php-files. When I open a php-file in browser, it seems only the html-part is decoded.
Opening phpinfo.php I only get a blank page.
Please help!
###Output
===> phpbrew will now build 5.3.29
PHP 5.3 requires +intl, enabled by default.
===> Loading and resolving variants...
Checking distribution checksum...
Checksum matched: c4e1cf6972b2a9c7f2777a18497d83bf713cdbecabb65d3ff62ba441aebb0091
===> Distribution file was successfully extracted, skipping...
Found existing Makefile, running make clean to ensure everything will be rebuilt.
You can append --no-clean option after the install command if you don't want to rebuild.
===> Running make clean: /usr/bin/make -C '/home/michaelyx/.phpbrew/build/php-5.3.29' --quiet 'clean'
===> Checking patches...
Checking patch for replace apache php module name with custom version name
Found existing build.log, renaming it to /home/michaelyx/.phpbrew/build/php-5.3.29/build.log.1531239511
===> Configuring 5.3.29...
Use tail command to see what's going on:
$ tail -F /home/michaelyx/.phpbrew/build/php-5.3.29/build.log
===> Checking patches...
Checking patch for php5.3.29 multi-sapi patch.
Checking patch for php5.3.x on 64bit machine when intl is enabled.
3 changes patched.
Checking patch for openssl dso linking patch
===> Building...
Build finished: 2.8 minutes.
Installing...
---> Creating php-fpm.conf
---> Creating php.ini
---> Copying /home/michaelyx/.phpbrew/build/php-5.3.29/php.ini-development
Found existing /home/michaelyx/.phpbrew/php/php-5.3.29/etc/php.ini.
---> Found date.timezone is not set, patching...
---> Turn off detect_encoding for php 5.3.*
Initializing pear config...
config-set succeeded
config-set succeeded
config-set succeeded
Enabling pear auto-discover...
config-set succeeded
Congratulations! Now you have PHP with 5.3.29 as php-5.3.29
...
Expected Result
phpbrew should provide that I can run my php files
Command
phpbrew install 5.3.29 +default+mysql

Build Log

Platform
OS:    Ubuntu 16.04
Running PHP: 7.0
Installing PHP: 5.3.29

On Restart of Ubuntu I get this Error: "Folgender Fehler wurde beim Laden von /home/michaelyx/.profile gefunden: /home/michaelyx/.phpbrew/init: Zeile 2: Invalid: Befehl nicht gefunden.  Sie sollten so bald wie möglich das Problem beheben."
Content of the File .../.phpbrew/init :
DO NOT EDIT THIS FILE
Invalid argument php-7.2.7
Looks like phpbrew is not correctly initialized?!
What can I do?

Translated:

The following error was found when loading /home/michaelyx/.profile: /home/michaelyx/.phpbrew/init: Line 2: Invalid: command not found. As a result, the session will not be configured correctly. You should fix the problem as soon as possible.

@michaelyx2 Maybe you can fix it manually. The contents of my ~/.phpbrew/init file is;
# DO NOT EDIT THIS FILE
export PHPBREW_ROOT=/home/arnold/.phpbrew
export PHPBREW_HOME=/home/arnold/.phpbrew
export PHPBREW_LOOKUP_PREFIX=
export PHPBREW_PHP=php-7.1.3
export PHPBREW_PATH=/home/arnold/.phpbrew/php/php-7.1.3/bin
# Run this command to configure your shell:
# # eval "$(phpbrew env)"

Change php-7.1.3 with the version you're running, like php-5.3.29.
Alternatively, try doing
phpbrew switch-off
phpbrew switch php-5.3.29


Ensure Jenkins CI jobs use up-to-date base Docker images

In https://github.com/vmware-tanzu/antrea/pull/1951 we ensured that the
Github workflows would use up-to-date base Docker images by building all
images in every run and leveraging Docker caching to reduce build
times. With this new change, we do the same thing for Jenkins jobs.
See #1540

Codecov Report

Merging #2009 (46d431b) into main (08ea67c) will decrease coverage by 8.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2009      +/-   ##
==========================================
- Coverage   65.11%   56.17%   -8.94%
==========================================
  Files         197      191       -6
  Lines       17407    16641     -766
==========================================
- Hits        11334     9348    -1986
- Misses       4884     6079    +1195
- Partials     1189     1214      +25

Flag
Coverage Δ

kind-e2e-tests
56.17% <ø> (+0.01%)
:arrow_up:

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/controller/networkpolicy/endpoint_querier.go
2.85% <0.00%> (-88.58%)
:arrow_down:

pkg/agent/util/iptables/lock.go
0.00% <0.00%> (-81.82%)
:arrow_down:

pkg/apis/controlplane/v1beta1/conversion.go
1.16% <0.00%> (-79.85%)
:arrow_down:

pkg/cni/client.go
0.00% <0.00%> (-75.52%)
:arrow_down:

pkg/util/sets/string.go
25.00% <0.00%> (-75.00%)
:arrow_down:

.../agent/flowexporter/connections/conntrack_linux.go
0.00% <0.00%> (-73.75%)
:arrow_down:

pkg/util/ip/ip.go
21.21% <0.00%> (-59.10%)
:arrow_down:

pkg/apiserver/handlers/endpoint/handler.go
0.00% <0.00%> (-58.83%)
:arrow_down:

.../registry/networkpolicy/clustergroupmember/rest.go
25.00% <0.00%> (-58.34%)
:arrow_down:

pkg/agent/apiserver/handlers/ovsflows/handler.go
16.03% <0.00%> (-57.55%)
:arrow_down:

... and 66 more

/test-all

/test-e2e

/test-all

Rebased PR
/test-all


[rom] Initialize output argument when loading boot_data

Fix #22927.
Initialize the boot_data struct to all zeros before calling boot_data_page_info_update which expects an in-out argument.

I missed that precondition.  Thanks for reviewing!


[modify] remove unnecessary xmlns

Coverage remained the same at 59.175% when pulling 6c846dc532a4981882af71a8c714a342a33f4b39 on sunny4381:fixes/xmlns into f8fa42812163730603689a32b4d11088cffe55f0 on shirasagi:master.


'InputMessage' URI domain field parameter

Instead to evaluate if an URI domain is secured, a new parameter should define if the SSL protocol is expected. This optional field is only available when the 'fs' filesystem parameter is set to false. A logical validation should check if an URI domain is defined with the SSL parameter. The logic should be as follow,

If the specified URI domain is not secured and the SSL field set to true then the protocol will be "https://"
If the specified URI domain is secured and the SSL field set to false then the protocol will be "http://"

For simplicity, it will not have an additional field. When instantiating the 'InputMessage' class, the user is prompted to enter
the full URI by specifying the SSL protocol if required.
Examples,
http://somedomain/pathto either InputMessage('http://somedomain','pathto')
https://somedomain/pathto either InputMessage('https://somedomain','pathto')

For simplicity, it will not have an additional field. When instantiating the 'InputMessage' class, the user is prompted to enter
the full URI by specifying the SSL protocol if required.
Examples,
http://somedomain/pathto either InputMessage('http://somedomain','pathto')
https://somedomain/pathto either InputMessage('https://somedomain','pathto')

For simplicity, it will not have an additional field. When instantiating the 'InputMessage' class, the user is prompted to enter
the full URI by specifying the SSL protocol if required.
Examples,
http://somedomain/pathto either InputMessage('http://somedomain','pathto')
https://somedomain/pathto either InputMessage('https://somedomain','pathto')


Separate the models from the sources

If everybody is ok with that, I propose to move the sources and the models in two separate folders.
The organisation would be like:

src

prepare_data.py
set_images.py
anyothercode.py

models

my_model_0.py
my_cnn.py

run.py

So the code would look like python run.py --source ../data --results ../results --model my_cnn with maybe some extra arguments for the models such as load_weights ?

good idea. how do you get python to load a file that's defined at run time? i've never done that before, but it seems like it should be possible

which file defined at runtime?


allow for alternate display of meshes

allow for a mode where instead of cortex, the sulci skeleton is displayed in the 3D view

implemented as a feature of v2.4.0

specifically https://github.com/FZJ-INM1-BDA/siibra-explorer/commit/899132a9523ce90d14d2d5104ff302d525b80d16


Fire events from golden layout when the user is dragging items around in the layout

Current behavior

No events are fired when the user drags layout items around in the layout
Expected behavior:

We want to have golden layout fire events when the user drags items around in the layout

JIRA Link:
Link to JIRA item if issue is from the Genesis Org: https://genesisglobal.atlassian.net/browse/PTC-616

Issue was fixed in #5


Some questions about GraphConvNet

Hi, I read your paper recently and I have some questions about the "Graph Convolution Network" part, which I am not familiar with:

I noticed this sentence, "Updating object vectors is more complex, since an object may participate in many relationships". I don't quite understand the scope of "many relationships", relationships in a batch? or in the whole dataset? I think your code suggests "in a batch". Is that correct?
I think the graph convolution net is co-trained with the whole model. Is it possible to train graph embeddings as an individual part or as a pre-processed part?

This is actually not a bug but some personal confusions. Actually, I am not a native English speaker, so if you find some expression vague, please feel free to ask me.
Your work is great. :)

Emmm, I suddenly notice how it works. The scope is one graph grounded with an image.
Sorry to bother. Closed.


Emojis are a bit larger.

When I used the ttf file you generated from Release Page, I found that the font of emoji is bigger than the ttf that comes with my mac.
Use the ttf from my mac:

It can be seen from the above that the size of the emoji is the same as the text.
Use the ttf from this repo:

You can see from the above that the size of the emoji is larger than the text.

Hi @luojinrong, thanks for your issue. I'm not sure I'm getting it right... Did you install the font on macOS or Linux?

I'm just comparing the difference between the font you generated and the MAC native font.
I think since what you are doing is an alternative to Apple Emoji on Linux, it should be consistent with the MAC native font on the display.

@dmlls I also met this problem, its on wezterm. and the font is very large. like this

My system is Archlinux, I install font by put the file into ~/.local/share/fonts and run fc-cache -f -v.

@colawithsauce Could you try installing the font from the AUR? This will correctly configure the fontconfig files for you.
Otherwise, could you try adding the fontconfig file manually?

@colawithsauce could you try installing it as a package just to try out all possibilities?
I'm also on Arch Linux (KDE Wayland) and unfortunately I can't replicate this:

Sorry, It should be an issue of wezterm! It seems that it doesn't respect fontconfig settings enough. I config my font at wezterm:
-- Font
config.font = wezterm.font_with_fallback({
	"Apple Color Emoji",
	"Recursive Mono Linear Static",
	"LXGW WenKai Mono",
	"98WB-1",
})

and I got this

However, I have similar configuration on Kitty, the display become normal. Sorry for my disturbing...

@colawithsauce good to hear the issue is solved. And funny those blue emoji! :D


remove invis walls

#12 this removes all the invis walls, if we wanted we could make it basin-only

Its important to have this in boggy as well.

My one thought is there may be some invisible wall somewhere that is beneficial to casuals?


Fix performance issues 1 - adding layers

Description
This PR should fix major performance issues connected with adding new layers.
Add also manger to block repaint until all data point are added.

Type of change

[x] Bug-fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

For sample code from #1923 current execution graph is below (I need to increase the number of points from 50 to 150 to ignore import and initialization impact)
I think that the next two or three-time speedup is possible but need to introduce cache.

@Czaki, I'm loving this, seems like lots of very nice speed ups, but I'm wondering if we can separate out the PR into two, one which just improves moves extent calculation out of the subplot call - which I think is what was giving quadratic time, and improves the extent calculation in the layer list and then another PR which would add the context manager and the caching. I still need to think more about the best ways to implement that. The first part should be a big speed up alone right?

@sofroniewn If my current understanding is correct, then the current version is cubic, the first part of this part reduces to quadratic, and cache allow to go to linear. but I think, that in the current case reduce to quadratic is a big improvement.
Introduce cache may allow to reverse some of the changes, with pulling up extend calls.
But I agree that cache needs to be introduced in a thoughtful way.
Because reduce from n3 to n2 is big improvement I will cutoff cache from this PR and return with it when this PR is merged.

Thanks for dropping cache. Following on from discussions in #1948 about the context manager, and this benchmark https://github.com/napari/napari/pull/1948#issuecomment-734414623 using this PR as is now with no cache adding the 50th layer takes 0.0416 seconds. If I use the blocking_repaint context manager that comes down to 0.0245 seconds.
I can see what that's important, but I think we need to think about the context manager and exactly what it is blocking, what it should be named etc.
I'm going to add the no layerlist reversal to this PR that makes things better too and fix a doc string

Using this add_many_points.py there is a presented time of running the whole script and time of add last layer.

using context manager:

python add_many_points.py  3,80s user 2,62s system 326% cpu 1,966 total
last layer 0.025061845779418945s

without context manager:

python add_many_points.py  4,66s user 3,00s system 326% cpu 2,347 total
last layer 0.0425112247467041s

current master:

python add_many_points.py  47,70s user 17,70s system 219% cpu 29,850 total
last layer 1.6099236011505127s

0.4.0:

python add_many_points.py  47,44s user 5,59s system 125% cpu 42,103 total
last layer 2.333498001098633s

0.3.8:

python add_many_points.py  8,65s user 0,94s system 119% cpu 7,993 total
last layer 0.3759002685546875s

0.3.8:

python add_many_points.py  2,14s user 1,01s system 201% cpu 1,562 total
last layer 0.02425384521484375s

@sofroniewn what you think about this?
I still see a bigger delay, than in 0.3.6 between finish adding the last layer and the moment when the interface is fully interactive.

I still see a bigger delay, than in 0.3.6 between the finish adding the last layer and the moment when the interface is fully interactive.

I definitely think there are still performance improvements to be gained, but I'd rather merge this as is or close and have those come in future PRs.
The big question is if we want to add blocking_repaint and set_block_repaint  to the public API with those names and functionality. I'd prefer to wait, I'm hoping we could make further improvements where it's not even necessary (i.e. we don't loop through grid like that if grid mode is false and hasn't changed) and then we'd have to drop this method as it wouldn't do anything anymore. I'm curious what @jni thinks? If we merge without blocking_repaint I can try and see if we can eliminate those additional calls when grid mode is turned off.

blocking_repaint will always speed up work when You need to add multiple layers.
Blocking repaint until all changes in layers are done is one of a big lack in napari which case some dummy blinking in my case.

blocking_repaint will always speed up work when You need to add multiple layers.
Blocking repaint until all changes in layers are done is one of a big lack in napari which case some dummy blinking in my case.

I definitely agree that blocking repainting is a good idea and we should figure out a way to support that, but I'm not sure in practice that adding a return to the _on_grid_change method is actually achieving as much as we want. If we make the _on_grid_change method do nothing when adding a layer if grid mode is false then this context manager as currently implemented won't add anything additional when grid mode if off, which is the majority of the time. I've done some testing now with and without the context manager compared to with and without disabling the _on_grid_change method and I can't see a continued performance improvement using blocking_repaint in that case.
I very may well be missing something here, but all of this is separate to the amazing performance improvements already present in this PR and I think this will require longer discussion that is best done on a PR only about blocking repainting. We can definitely try to add a way to block repainting though.
Thoughts @jni? Without the context manager we could approve and merge this PR right now as it doesn't change the public API and results in a huge performance gain.

_on_grid_change cause iteration over all currently added layers and call _subplot on it.

_on_grid_change cause iteration over all currently added layers and call _subplot on it.

Yes, but I think that is not doing what you expect (we might want to rename it if it is confusing) If you don't call _subplot the data still gets plotted. Comment out the whole method and see - you do not need to call subplot to plot the data, it gets plotted anyway, which is why this approach to blocking_repaint is not doing what we want it to be doing.

I see.
So maybe rename contex manager to `stop_update_layer_position?

I see.
So maybe rename contex manager to `stop_update_layer_position?

If you put this in a new separate PR we can discuss it there. As I said above, we might actually be able to add a real block_repaint like context manager, but we'll need a couple days to work on it probably.
It's a holiday weekend in the USA right now so i'll be signing off for a while soon, but if you remove the context manager then I can merge this PR as is right now, which will really help a lot of people already! 😄 Thanks!!

I add _on_layers_change block to the context manager.
Current speed is similar to 0.3.6 version  (total execution speed)
Current state:
run 49 in time 0.0077669620513916016
python add_many_points.py  2,78s user 2,21s system 334% cpu 1,495 total
I will wait on @jni decision. I really like context manager which allows to speedup add a bunch of data.

@sofroniewn contextmanager moved to #1949


Test Settings Sync for Preview

Ref - #90129 #2743

[x] mac @roblourens
[ ] win @joaomoreno
[ ] linux @aeschli (test cross platform)

Complexity: 5

Set Up

Follow instructions here
To test, have two insiders open with different user data directories and extension directories

Testing
In this milestone we fine tuned the feature to make it ready for the preview in insiders. Hence we concentrated mostly on core concepts like design, back ups, error handling and UX. So, I would ask the assignees to do an exploratory testing in all sync areas. Also try to step in as an end user and mainly check if user is able to recover from all sorts of issues (worst - data loss/recovery). Here are some key areas to test.

Make sure you get a preview confirmation dialog when you turn on sync for the very fist time. This is for the user to opt in to use settings sync preview feature. If you think wordings can be improved, please provide better suggestions. Also note that the documentation link is in progress hence it is currently pointing to a wrong location.
Test experience of first time syncing from a machine.
Test settings, keybindings, extensions and display language are syncing across devices flawlessly.

Test machine and machine-overridable scoped settings are ignored by default. These are typically settings that has local paths  as values.
Test enablement state of built in extensions are synced
Test advanced settings - ignoring settings, extensions and syncing keybindings across platforms
Test you can able to understand and resolve conflicts if they occur.

Test overall UX. Make sure you can track and monitor sync activity and discover all necessary sync features.
Retrieving local back ups
Turning off experience (test this scenario)
Test client is not making too many requests when there is no sync activity. For eg., if there are no changes to sync, client shall send only one request to server. You can verify this by enabling log level to trace and monitoring sync activity.

Authors: @sandy081 @Tyriar @misolori @roblourens @RMacfarlane

@sandy081 @Tyriar Since auto sync runs every time the window gets focused, this can happen too often. I could get it to run every 2 seconds by focusing in/out of the window. Not sure whether you want to put a rate limiter there, since it will generate lots of traffic once every user uses it.


HTTPError: 400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token

Describe the bug
Command Name
az group list
Errors:
400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 215, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 631, in execute
    raise ex
cli/core/commands/__init__.py, ln 695, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
cli/core/commands/__init__.py, ln 688, in _run_job
    six.reraise(*sys.exc_info())
...
python3.6/site-packages/msrestazure/azure_active_directory.py, ln 486, in get_msi_token
    result.raise_for_status()
python3.6/site-packages/requests/models.py, ln 940, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Open Windows Terminal > Azure Cloud Shell
az group list

Expected Behavior
Environment Summary
Windows Terminal Version: 1.0.1401.0
Windows Build 19041.264
Linux-4.15.0-1082-azure-x86_64-with-debian-stretch-sid
Python 3.6.5
Installer: DEB

azure-cli 2.5.1 *

Additional Context

add to S171

Known issue of Cloud Shell. It is also tracked in #11749.
To workaround, you can run az login and retry the command.


being able to reorder lists

#326

being able to reorder the lists (e.g. the pantries, from the pantry list page)

The list feature is put on ice for now


Remove confirmation message

Reverts https://github.com/alphagov/bulk-merger/pull/52
This shouldn't be necessary anymore after replatforming.

Although all of our apps are continuously deployed now (AFAIK), I think this warning still makes sense for gems.

Although all of our apps are continuously deployed now (AFAIK), I think this warning still makes sense for gems which have to be manually released.

That's a good point. I think that asking for confirmation is way OTT with k8s, though. I'll change this to be a warning pointing at the docs for releasing gems and the docs about the new system.


Question about QdrantLocal

Is there any way we can save RAM when using QdrantLocal ? I tried different params, didn't find a way to save RAM when launching service.
Below is my test code:
client = QdrantClient(path="./data-db")  # Persists changes to disk
client.create_collection(
collection_name="xxx",
vectors_config=models.VectorParams(size=384, distance=models.Distance.COSINE, on_disk=True,
hnsw_config=models.HnswConfigDiff(on_disk=True)),
optimizers_config=models.OptimizersConfigDiff(memmap_threshold=0),
on_disk_payload=True,
quantization_config=models.ScalarQuantization(
scalar=models.ScalarQuantizationConfig(
type=models.ScalarType.INT8,
always_ram=False,
),
),
)

@hanqiushi hi, could you describe your setup?
How many points do you want to store in local mode?
Please, keep in mind that local mode has not been designed to be used in production, it is a tool for fast experiments.
Once you are done with lightweight experiments - you can switch to qdrant server with just replacing path=... to url=... (qdrant server can be e.g.  qdrant launched in docker locally, or any other kind of deployment like cloud or your k8s cluster)

@hanqiushi hi, is this question still actual, or I can close the issue?


Show users their pricing plan & limits

We should show our users that they are API call limited. Get the total API calls made in the last 30 days for the organisation (as per the Org usage graph) and show it in the top banner if the calls are within 30% of the limit, so:
"45k out of 50k API calls" with a CTA to upgrade
pls it should be different from other buttons

Can we get better requirements on this ticket @dabeeeenster

We need to hard code the API call limits for each chargebee plan-id into the back end, and then present that info to the Front end so it can make the appropriate calculations.


Fix trivial typo in command line help message

🦟 Bug fix
Typo in help message.
P.S. There is a correct description in line 68, but I don't know what that description is used for. It doesn't get printed.
Summary
Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

I'm going to update the PR with an fix for @chapulina  comment and re-target to citadel.


Failed to start language services. Please check if mono is in PATH

Hi, I'm trying to get Ionide setup on LinuxMint 18.3 but I keep getting the folowing message when attempting to create a new project "Failed to start language services. Please check if mono is in PATH"
in the debug console for Language service (SERVER) I'm getting this message.
"Running: dotnet /home/USER/.var/app/com.visualstudio.code/data/vscode/extensions/ionide.ionide-fsharp-3.22.1/bin_netcore/fsautocomplete.dll --mode http --port 8982 --hostPID=455
spawn dotnet ENOENT"
And for language service it says.
[16:36:23 ERROR] Failed to start language services. spawn dotnet ENOENT
I have the following settings set
"FSharp.fsacRuntime": "netcore"
"FSharp.monoPath": "/usr/bin/mono"
Any help would be greatly appreciated.
Thanks..

Do you have .Net Core installed and in PATH if you're using "FSharp.fsacRuntime": "netcore" ?

Yes. to both of those questions sir.

Does the fsautocomplete.dll file exist in the path shown in console?

Not sure if it is of any help, but here are the logs from Forge as well...
forge new project -n test -t suave --folder /home/User/PICTURES  --no-prompt
{"code":"ENOENT","errno":"ENOENT","syscall":"spawn mono","path":"mono","spawnargs":["/home/gee5ive/.var/app/com.visualstudio.code/data/vscode/extensions/ionide.ionide-fsharp-3.22.1/bin_forge/Forge.exe","new","project","-n","test","-t","suave","--folder","/home/User/PICTURES","--no-prompt"]}

Yes. the file is present.

Last time, I add a similar problem I needed to uninstall Ionide, restart VSCode, and re-install Ionide.
In my case, it was because the update process had gone wrong.

This is probably outdated due to Ionide 4.0 changes


Update free-programming-books-ru.md + R-book

What does this PR do?
Add resource
For resources
How do we know it's really free?
Available freely on the official site of R-language
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Thanks, and welcome to free-programming-books!


patch: sum_horizontal ignore nulls

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[ ] ✨ Feature
[x] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[ ] ✅ Test
[ ] 🐳 Other

Related issues

Closes #822

Checklist

[x] Code follows style guide (ruff)
[x] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below.
Not sure how to handle non numeric 🤔
In horizontal sum, polars concatenates strings and fill nulls with empty strings, but also concatenates strings with numeric:
df = pl.DataFrame({
    "a": [1, 8, 3],
   "c": ["x", "y", "z"],
})

df.select(pl.sum_horizontal("a", "c"))

shape: (3, 1)
┌─────┐
│ a   │
│ --- │
│ str │
╞═════╡
│ 1x  │
│ 8y  │
│ 3z  │
└─────┘

To extract the dtype in narwhals, we would need to evaluate the expr, or am I missing something trivial?

Not sure how to handle non numeric 🤔

probably fine to ignore them for now? or even, ignore them completely. we could be a bit stricter than Polars here, and guide people towards https://docs.pola.rs/api/python/stable/reference/expressions/api/polars.concat_str.html to concatenate strings

probably fine to ignore them for now? or even, ignore them completely. we could be a bit stricter than Polars here, and guide people towards https://docs.pola.rs/api/python/stable/reference/expressions/api/polars.concat_str.html to concatenate strings

Oh neat, then maybe we want to support concat_str first. As the request for null values came from me, I don't feel like we are in a rush to merge this.

then maybe we want to support concat_str first

Well it turns out that I am facing one of the very painful pandas issue:
import pandas as pd

df = pd.DataFrame({"c1": [1,2,3], "c2": ["x", "y", None], "c3": list("abc")})

df["c2"] + df["c3"]

0     xa
1     yb
2    NaN
dtype: object

but to replicate polars behavior I was casting to string first, and we need nullable string type, otherwise:
df["c1"].astype(str) + df["c2"].astype(str)

0       1x
1       2y
2    3None
dtype: object

I would imagine same issue will present with dask

This would official be a regression. I searched on github if anyone is using the feature on a public repo and ended up empty handed, which is a good sign.
I also added a warning in the docs as the following:

I am moving it to ready for review, but very happy to see if anyone has ideas on how to deal in case of strings


Dataset iterating different behavior in TF 2.1 and 2.2

System information

OS Platform and Distribution: Windows 10 Home
TensorFlow versions:

2.1: v2.1.0-rc2-17-ge5bf8de410 2.1.0
2.2: v2.2.0-rc4-8-g2b96f3662b 2.2.0

Python version: 3.7.6

I was not sure how to report this issue as it might be bug or just expected behavior. There are difference in TF 2.1 and 2.2. This is a code snippet to reproduce my issue:
import math
import numpy as np
import tensorflow as tf

# simple dataset with zeros
batch_size = 32
features = np.zeros((10000, 60, 2))
labels = np.zeros((10000, 1))
train_data = tf.data.Dataset.from_tensor_slices((features, labels)).batch(batch_size)
train_steps = int(math.ceil(features.shape[0] / batch_size))

# simple model with Dense layers
inputs = tf.keras.Input(shape=(features[0].shape[0], features[0].shape[1]))
x = tf.keras.layers.Dense(32, activation="relu")(inputs)
outputs = tf.keras.layers.Dense(1, activation="relu")(x)
model = tf.keras.Model(inputs, outputs, name="example_model")

# model fitting
model.compile(loss="mse", optimizer="adam", metrics=["mse"])
model.fit(train_data, epochs=100, steps_per_epoch=train_steps)

When I run this code in TF2.1 it will produce this error: https://pastebin.com/4M43SE44
After the first epoch, there are warnings about end of sequence, that my input ran out of data. And finally, as you can see in the pasted output, it raises ValueError: Empty training data..
When I change line with dataset creation to

train_data = tf.data.Dataset.from_tensor_slices((features, labels)).batch(batch_size).repeat()

than everything works as expected.
This is behavior I would expect. (Note steps_per_epoch attribute as I wan to control this by myself, of course when I do not use repeat and steps_per_epoch is set to None, it will work under TF2.1 as it will iterate whole dataset every epoch).
When I run the same code with TF2.2 (no repeat, train_steps are specified) it works without any issue. Is this behavior intentional? Why does it work in TF2.2 and not 2.1? Could anyone elaborate on this issue?

@sondracek
I ran the code shared by you, please find the gist for tf 2.1 and tf 2.2 and let us know if this confirms your issue.
If any data is missing please share all dependencies.

The first gist (tf 2.1) is right, it raises ValueError as I would expect.
But the second gist is not right (not sure what is the error about). When I run the same code (from your gist) for tf 2.2, it's running without any issues: gist for tf 2.2
Thank you for your help!

@tomerk could you please take a look? this looks to be rooted in Keras and not tf.data.

@omalleyt12 is this one of the known regressions that have fixes for 2.3 that didn't quite make it in to 2.2? Or is this something to add to the list?

@sondracek Thanks for the issue!
Yep this is something we added support for in 2.2
We can sometimes know the exact size of the Dataset you pass in. If we can know this size, and you pass the exact size in steps_per_epoch, then we will assume that you meant for us to recreate the Iterator each epoch.
This seems to me to be the most intuitive behavior, since what we do if you don't pass steps_per_epoch is we infer it to be the entire size of the Dataset
Closing as intended behavior, but please re-open if you think this behavior is confusing and should be changed, I don't have a strong opinion either way

Thank you for your response, I didn't find any note on this change so I was just a bit surprised that the behavior is different.
I don't have a strong opinion here as well, but it makes sense. It would be worth writing it to documentation (not sure whether it's mentioned somewhere?), however, thank you for your explanation.


[CI] Update pkgs, including Hugo to 0.138.0; use new comment shortcode

Updates to Hugo v0.138.0
Illustrates use of the new Hugo comment shortcode
There are no changes to generated site files other than:

The updated Hugo version as part of the generator ID header element
The HTML comment removed from the page where this PR uses the comment shortcode instead.

Actually, that PR doesn't touch the same region of the file so we should be fine.


[Dropdown] preserveHTML is useless

Hello. According to official documentation HTML inside of .item should be preserved after a value selection, but it's actually don't. Documentation says:

Whether HTML included in dropdown values should be preserved. (Allows icons to show up in selected value)

But my HTML code inside of .item never get copied into a .text element. preserveHTML works only for an icons inside of .item, but should work for any HTML code inside of it.
For example:

  - Russian ruble

    - Japanese yen

Dropdown will be way more intuitive and easy to use after implementing this functionality.
Regards,
Andrew.

Well, my issue has been successfully resolved with description.

  Japanese yen

Since it's resovled I'm closing this topic, but if you still have any comments or suggestions - please feel free to mention me here. Have a nice day!

Hi @JamesJGoodwin, that doesn’t seem to be the case from what I’ve just tested with SVG. I’ll take a look at it if you create a test case from this forkable JSFiddle.

@Banandrew just found the reason for what is happening. You need to remove data-text attribute in order to make preserveHtml option works.


Warn if there if a chat template is provided by the model's tokenizer configuration and a caht_template is defined in the yaml

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.

🔖 Feature description
There might be a mismatch between an existing chat template and a defined one.
✔ Solution
Simply warn the user for now and continue
❓ Alternatives
No response
📝 Additional Context
No response
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this feature has not been requested yet.
[X] I have provided enough information for the maintainers to understand and evaluate this request.

@winglian : Is there a way to tell Axoltl to simply use the chat template of the tokenizer? I couldn't tell. I know that I can tell it what kind of format the dataset is in, but I didn't know how that affected the templating if the tokenizer has a different template defined.


Add work configuration filed for klusterlet

Signed-off-by: zhujian<EMAIL_ADDRESS>issue reference: https://github.com/open-cluster-management-io/work/issues/155

/approve
/lgtm


[Monorepo Builder] Merged keys are not sorted

Ok, so upon investigating my previous issue regarding missing keys, it appears that they are no longer being removed so that solution is not necessary, however, I noticed that the keys are not being sorted. I tried setting the parameter Option::SECTION_ORDER but this was being ignored. This led me down a rabbit hole looking for the cause...
At first I considered the problem to be in SortComposerJsonDecorator
var_dump($this->sectionOrder);

yields the expected array of keys, however
var_dump($orderedKeys);

was showing as empty before it was being set (line 38). Doing the same after retrieving the keys showed that it was again empty, so that explains why nothing was being sorted.
So the question becomes why are the ordered keys not being set for the merge command? Checking the test SortComposerJsonDecoratorTest shows that the method being checked is when the composer json object is first created, which is when the orderedKeys property is initially set.
So then I go back to the merge command and follow it through to where it loads the ComposerJson and has the orderedKeys property set. This is then passed to this method MergedAndDecoratedComposerJsonFactory:39 which is where the decorators are that would sort the keys.
There are 2 issues I can identify here.

The decorators are being run on the merged package file infos but not on the $mainComposerJson object, meaning the main composer json keys are not being sorted.
When the file infos are merged here: ComposerJsonMerger:57 the order keys are not updated. Solutions here would be to create a resetOrderKeys method which is what is first run on createFromArray and can be subsequently called during the merger before the decorators are called. The better fix for the second issue I believe would be to refresh the keys at the end of mergeJsonToRoot, however the more performant fix would be to do that at the end of mergeFilesInfos.

These would obviously require different fixes unless you can see something I'm not? I have everything ready to start working on some tests and fixes but I'm calling it for today.

These would obviously require different fixes unless you can see something I'm not? I have everything ready to start working on some tests and fixes but I'm calling it for today.

Test case and real code would help me understand. Go for it :+1:

Turns out, my real problem running the tests is that I'm not on PHP 8 yet since we use the amqp extension which is not yet released for PHP 8. I'm currently trying to run tests via docker instead.
This is relatively straight forward to check for though, try setting the parameter Option::SECTION_ORDER in monorepo-builder.php and you'll see that it's ignored in the main composer json. More specifically, minimum-stability and prefer-stable are both moved to dead last regardless, and other keys stay in the position that they are already, regardless of their original position.

You can run tests on PHP 7.3 or 7.4 too, see https://github.com/symplify/symplify/pull/3063/checks?check_run_id=2132230458

Closing for lack of feedback.


Fix markdown typo.

Thank you for contributing to kubernetes/charts. Before you submit this PR we'd like to
make sure you are aware of our technical requirements and best practices:

https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements
https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices

For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:

https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md

Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.
When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.

/retest

@mattfarina @audip @timstoop Please have a look. I've bumped PATCH version of the chart.


Use full path to exceptions in specs

Also cleans up unused exceptions.
Related to watir/watirspec#61

Coverage decreased (-0.0%) to 95.78% when pulling 29a175cf782f6237844b2c2734bce6e9d1533a95 on full_exception_path into f59251329f1b56036c59b30ad56aa4f309a35409 on master.


Module .to(rh.here) throws error if rh.here returned "file".

#597  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on  Graphite


No way of monitoring if download was successful or not.

If the connection drops while downloading no error is displayed. Also there is not callback or listener that I can attach to, so i cannot tell if it has finished successfully.

Hi, thanks for the tip, be sure to fix

Look forward to it

Hi, update the version of the library
compile 'com.github.atzcx:AppVerUpdater:1.0.4'
Basic Usage
new AppVerUpdater(MainActivity.this)
                .setUpdateJSONUrl("http://example.com/updateinfo.json")
                .setShowNotUpdated(true)
                .setViewNotes(false)
                .setCallback(new Callback() {
                    @Override
                    public void onFailure(AppVerUpdaterError error) {
                        if (error == AppVerUpdaterError.NETWORK_NOT_AVAILABLE){
                            Toast.makeText(MainActivity.this, "No Internet Connection", Toast.LENGTH_LONG).show();
                        } else if (error == AppVerUpdaterError.NETWORK_DISKONNECTED){
                            Toast.makeText(MainActivity.this, "Internet Disconnected", Toast.LENGTH_LONG).show();
                        }
                        //Toast.makeText(MainActivity.this, "update erro: " + error, Toast.LENGTH_LONG).show();
                    }
                })
                .build();

Perfect! Will try it out

This error has come back. It was resolved in 1.0.3

Hi, update the version of the library
compile 'com.github.atzcx:AppVerUpdater:1.0.5'

Great! now it is working and catches and gives error if I unplug and/or doesn't have internet but it does not catch a fail if there is a SocketTimeoutException

This does not hit onFailure.
Also DISKONNECTED is spelt DISCONNECTED

Hi, update the version of the library
compile 'com.github.atzcx:AppVerUpdater:1.0.6'
all error messages
UpdateErrors.NETWORK_NOT_AVAILABLE
UpdateErrors.NETWORK_DISCONNECTED
UpdateErrors.SOCET_TIMEOUT_EXCEPTION
UpdateErrors.UNKNOWN_HOST_EXCEPTION
UpdateErrors.SOCET_EXCEPTION
UpdateErrors.STRING_URL_IS_EMPTY
UpdateErrors.JSON_FILE_IS_MISSING
UpdateErrors.FILE_JSON_NO_DATA

Added errors handling, as you requested. Thanks for the help

Will test now. Thank You

This is more info. I do not get the onFailure call when there is a SocketTimeoutException. I have debugged it in the AsyncClient class and it hits the catch however it does not call back to the onFailure.

Am I doing something wrong?
Also Note that "Socet" is spelt "Socket"

Hi, everything seems to be fixed, you can use. Update the version of the library
compile 'com.github.atzcx:AppVerUpdater:1.0.7'
MainActivity.java
if that I will be glad to help

Will test tomorrow thanks


Nmap Script

Details

What the features will your script have
Nmap is a network scanning tool used for discovering hosts and services on a network. It provides a wealth of information about open ports, services, operating systems, and other valuable details that aid in vulnerability assessment.

Do I want to work on this:

[x]  Yes
[ ] No

Assign this issue to me under GSSOC'23

Already Present in the Repo


Rich Text widget

Need rich text form widget, in which user can to different rich text operations like make text bold, italic, underline, change text color, change text size etc. When form data save, it will save as html text

Hello @SachinTanpure,
There's currently no widget for this function within the library. You can howver build your own custom widget to use within FormBuilder as indicated in the documentation.

Yes. Thanks. Made custom widget.


SelectPanel2 Optimization: Do not add and remove keydown listener for escape key on every render

Description
SelectPanel2.SelectPanel will call dialogEl.removeEventListener and dialogEl.addEventListener on every render, because the call to React.useEffect is not passed an array of dependencies at this callsite: https://github.com/primer/react/blob/main/packages/react/src/drafts/SelectPanel2/SelectPanel.tsx#L195
The React docs describe this behavior here: https://react.dev/reference/react/useEffect#parameters

If you omit this argument, your Effect will re-run after every re-render of the component.

I suspect the dependency array was an accidental omission.
Why am I filing this bug/optimization issue?
I was interested in making a contribution to this repository, and I wanted to start with a small, low impact change. Select components are interesting to me, so I began reviewing the component to look for ways to help, and I came across this as a potential optimization. It's a nitpick, and may not have any real impact on user performance, so I understand if the maintainers want to close without addressing.
Steps to reproduce
The following test case will fail for me when I added to https://github.com/primer/react/blob/main/packages/react/src/drafts/SelectPanel2/SelectPanel.test.tsx.
Note: This is a fairly "white box" test and relies on implementation details. I find that these kind of tests are useful to check performance optimizations, but the tradeoff is that the tests are more brittle.
// packages/react/src/drafts/SelectPanel2/SelectPanel.test.tsx
  it('should not call addEventListener on each render', async () => {
    const container = render(<SelectPanel title="title">child</SelectPanel>)
    const dialogEl = container.getByRole('dialog', {hidden: true})
    const addEventListenerSpy = jest.spyOn(dialogEl, 'addEventListener')
    const removeEventListenerSpy = jest.spyOn(dialogEl, 'removeEventListener')

    container.rerender(<SelectPanel title="title">child</SelectPanel>)
    expect(addEventListenerSpy).not.toHaveBeenCalled()
    expect(removeEventListenerSpy).not.toHaveBeenCalled()
  })

Version
v36.17.0
Browser
No response

If the maintainers are interested, I prepared a PR to fix the issue. I don't want to push without asking, because I suspect it will trigger some CI jobs. If you'd like me to push a fix for this, please let me know!


add tropoTotal

add function to create troposphereTotal on the fly using gdal PixelFunction
did little clean up, please feel free to reject suggestions

@mgovorcin this PR looks solid, thanks for the integration of the discussed features and clean-up! I was able to get it working on my end with some minor fixes.
I have a few of broader notes:
I removed the function where you computed the total tropo within tsSetup,py, as this is handled in extractProduct.py, and without forcing the user to extract the dry and wet components when they don't want to.
To extract the total tropo by default though (i.e. without the user having to specify it as an argument), I reintroduced the layerCheck function and made some adjustments to the logic. This is intended to check whether or not the tropo layers exist in all standard products in the first place before proceeding.
Hence because of this, I made some changes to the way the default layers are managed and extracted.


old mesh format support

latest neuromancer-seung-import.appspot.com requires info file for the meshes? is there a link supporting old format without the info for mesh? Or is there an easy way to make the data support this new format by adding a info file?

the manifest files are missing!


Bootstrap

What was the feature/problem?
{Please write here}
How does this PR address the above feature/problem?
{Please write here}
Check lists (check x in [ ] of list items)

[ ] Test passed
[ ] Coding style (indentation, etc)

Additional Comments (if any)
{Please write here}

Codecov Report

Merging #5 into develop will decrease coverage by 0.53%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop       #5      +/-   ##
===========================================
- Coverage    86.56%   86.02%   -0.54%
===========================================
  Files           11       12       +1
  Lines          134      136       +2
  Branches        10       10
===========================================
+ Hits           116      117       +1
- Misses          15       16       +1
  Partials         3        3

Flag
Coverage Δ

#api
82.82% <ø> (ø)
:arrow_up:

#ui
94.59% <50%> (-2.55%)
:arrow_down:

Impacted Files
Coverage Δ

ui/src/app/App.js
100% <ø> (ø)
:arrow_up:

ui/src/login/Login.js
96% <ø> (ø)
:arrow_up:

ui/src/common/NotFound.js
50% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de4e2db...06a4b41. Read the comment docs.


Add support for 'sponsorships'

Hi,
The sponsorship links have been added to GitHub. To enable them, a checkbox needs to be ticked and it would be nice to be able to do it via GitHub Settings.
Cheers.

Still relevant.

i agree that this would be valuable, but haven't had a chance to spend time on an implementation. i'd be happy to help guide you if you would be interested in attempting a PR to add this capability.

Hi @travi,
Thank you for your help offer and for having had a look at the GitHub API documentation.
I thought again about the added value of this new feature and I'm actually wondering if it's a good idea in the end. Let's say that the template option is enabled via Probot Settings on a Git repository and that someone clicks on the Use this tempate button of the template's Git repository page. As a result, GitHub will basically clone the repository into another namespace but without keeping the Git history. If Probot Settings is enabled in the target namespace, it will apply the configuration of the template repository to the freshly cloned one, changing even its name which I think is not the desired behaviour.
I look forward to hearing your opinion on the above issue.

I'm not sure i follow the concern fully. If you are simply referring to settings being applied in a new repository created from a template that contains a settings file, that doesn't seem specific to sponsorships. Am i missing a detail that is specific to this issue?
If you are referring to the more general concern, i think my recommendation would be to either only include settings in a template repository that are actually intended to apply when a repo is created from that template. Sometimes that means not including a settings file at all, sometimes limiting what is included, or sometimes limiting what is included by extending from a .github repository and moving account level settings there instead. If this were supported, i would have sponsorship defined at the account level rather than peer project anyway.
Regardless, i don't understand why this would translate into a reason why settings should not support configuring sponsorships specifically. Could you clarify if your concern is sponsorship specific? If there is something more general that you think we should consider, please feel free to open another issue so we can discuss in more detail.

Oh sorry my bad, I commented the wrong issue. It was meant to be for #133 that I also created :face_palm:

I will copy my comment into #133 to keep the integrity of the conversation when I'll be on a larger screen (on my smartphone right now).

Ah, that certainly makes more sense. I'll mark these as of topic then, but feel free to expand to copy across.

A thread has been opened on the official GitHub Support Community Forum to request the possibility to enable the "Sponsor" button via the API: https://github.community/t/how-to-enable-the-sponsor-button-in-a-repository-using-github-api/14879.

That's too bad the API doesn't support it. Confirmed it in the link below for future reference.
https://docs.github.com/en/rest/repos/repos#update-a-repository

From the settings page, I can see the following form data when I disable sponsorship
-----------------------------REDACTED
Content-Disposition: form-data; name="enable_repository_funding_links"

0

and when I enable sponsorship
-----------------------------REDACTED
Content-Disposition: form-data; name="enable_repository_funding_links"

1

But this is completely undocumented.

FYI, this seems to be supported in the GitHub API now:

https://docs.github.com/en/sponsors/integrating-with-github-sponsors

https://docs.github.com/en/sponsors/integrating-with-github-sponsors/configuring-webhooks-for-events-in-your-sponsored-account
https://docs.github.com/en/sponsors/integrating-with-github-sponsors/getting-started-with-the-sponsors-graphql-api


Encrypted Direct Messaging and Asset Commenting Modules

Changes proposed in this PR:

Add encrypted direct messaging module using Orbis SDK
Add commenting module on asset page using Orbis SDK (currently hidden/commented)

Hello, thanks for opening this PR. I tested it a bit, and the messaging part works like a charm on my end.
I did though find a few things:

Can we have the send messages functionality triggered by the two operations?

Via the send message button - this is already working
Via the "Enter" keyboard button - can we add it back?

"Contact publisher" button from the asset page position.
The button is positioned in a place that is rendered dynamically based on the asset's metadata. Sometimes this positioning is good, other times the user needs to scroll a bit to find it. As this button's functionality is tightly related to the owner and not the asset itself, we should place it in the header or close to the header.  I am tagging my team members here as we should take care of this one. cc @matthias @bogdan

The "Contact publisher" button is available on the owner's published assets. We should verify who the owner of the asset is, and if it's the same as the connected wallet, hide the "Contact publisher" button(Like we do with the "Send Direct Message" button). Tapping on the button with the same account used to publish the asset, opens up a previous conversation.

For consistency, I suggest using the same label for the direct messaging functionality. Instead of "Contact publisher" and "Send Direct Message" labels, we can use something like "Send message".

seen there is an empty file in the PR as well content/repo-metadata.json that can be removed

seen there is an empty file in the PR as well content/repo-metadata.json that can be removed

I have removed this file in my last commit

please rebase and fix the merge conflicts, also there are many failures in the CI ( build + tests) that need some attention 😃

I can't send a message. I get the following
need to create new conversation
 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'session')

Hey @mihaisc! Sorry about that this is actually my fault, I pushed by mistake a version of the SDK with a bug this morning, it was live for only an hour but it must be the version of the SDK this version is currently using.  If you install v0.4.40 of the @orbisclub/orbis-sdk the bug should be fixed

Cool one!
Respectfully,
Silvio

If urgent, pls call.

Silvio F. Pupo | Logos Capital
MIA•DC•SEU•TOK•ACC•LAG•BOG
360 NW 27th Street, Miami, FL 33127
Cel: +1.786.355.4261 | Tel: +1.818.564.6708
e<EMAIL_ADDRESS>w: www.LogosCapital.io http://www.logoscapitalgroup.com/

All U.S. securities transactions are handled via SEC registered Broker Dealer(s), Member FINRA, SIPC, MSRB| This message may contain information that is confidential or privileged. If you are not the intended recipient, please advise the sender immediately and delete this message.
https://aka.ms/o0ukef

From: Bogdan Fazakas @.>
Sent: Wednesday, April 5, 2023 1:27:46 AM
To: oceanprotocol/market @.>
Cc: Subscribed @.***>
Subject: Re: [oceanprotocol/market] Encrypted Direct Messaging and Asset Commenting Modules (PR #1870)
@bogdanfazakas approved this pull request.
—
Reply to this email directly, view it on GitHubhttps://github.com/oceanprotocol/market/pull/1870#pullrequestreview-1372176447, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMI4VMOVIPELPXO3LFXFZS3W7T7FFANCNFSM6AAAAAAUHY37AE.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


No check for access modifier for non-trivial class properties

TypeScript Version:  3.7.2
Search Terms: private computed property
Expected behavior:
TypeScript should check the access modifier of class properties with "weird" names that look like computed properties but are given literally (e.g. property names with dashes).
I understand that there is an intended bypass for "real" computed properties where the index is a non-constant expression (https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#413-property-access). But properties explicitly  defined in the class should be checked when accessed literally (see playground example).
Actually, TypeScript even acts a little inconsistent: It fails if trying to access a class property that does not exist, but passes accessing private properties from outside.
Actual behavior:
TypeScript fails for undefined properties, but not for existing private properties.

Related Issues: #26328
Code
class C {
    public p1 = 1;
    private p2 = 1;
    public ["p-1"] = 1;
    private ["p-2"] = 1;
}

const c = new C;
console.log(c.p0); // error (ok)
console.log(c.p1);
console.log(c.p2); // error (ok)
console.log(c["p-0"]); // error (ok)
console.log(c["p-1"]);
console.log(c["p-2"]); // no error!

Compiler Options
{
  "compilerOptions": {
    "noImplicitAny": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "strictPropertyInitialization": true,
    "strictBindCallApply": true,
    "noImplicitThis": true,
    "noImplicitReturns": true,
    "useDefineForClassFields": false,
    "alwaysStrict": true,
    "allowUnreachableCode": false,
    "allowUnusedLabels": false,
    "downlevelIteration": false,
    "noEmitHelpers": false,
    "noLib": false,
    "noStrictGenericChecks": false,
    "noUnusedLocals": false,
    "noUnusedParameters": false,
    "esModuleInterop": true,
    "preserveConstEnums": false,
    "removeComments": false,
    "skipLibCheck": false,
    "checkJs": false,
    "allowJs": false,
    "declaration": true,
    "experimentalDecorators": false,
    "emitDecoratorMetadata": false,
    "target": "ES2017",
    "module": "ESNext"
  }
}

Playground Link: Provided

How is this different from #26328?

From #26328: const n = a[nameN]; with nameN being a variable (well in real-life). Ths issue is specifically about object["literal"]. And ... about undefined vs. private properties behaving different.

This is longstanding behavior to allow (ugh) the access of these properties. It'd be a very substantial breaking change at this point and we don't intend to invoke that pain.


Please explain why this setup is needed

Description:
In README.md please explain why this setup is needed.
Looking at the information for Actions Windows images several versions of Java are already installed and all that seems necessary is to set JAVA_HOME to the value of the home env. var. of the Java version you wish to use, e.g. JAVA_HOME_17_X64. I failed to successfully do that which led me here. The first bullet in the README.md says "Downloading and setting up a requested version of Java". Since Java is already installed in the image, I wondered if I really needed this setup or if it is out of date.
Justification:
So newcomers will not be worried about unnecessary downloads of large packages and how this setup actually relates to the images already having Java.
Are you willing to submit a PR?
No. I don't know the answer.

Hello @MarkCallow. Thank you for your report. For setting up Java you need to add it to the PATH and change JAVA_HOME env variable. The action allows customers to utilize preinstalled versions of Java located in the hosted toolcache directory. Firstly the action will try to check if the version is installed. If it's so the action will use the preinstalled version. If it does not exist the action will try to download it. You can change this behaviour with check-latest input.
Besides, the action allows to specify different distributions of Java, caching dependencies and publishing.
For now I'm going to close the issue because it is described in the documentation. If you have any concerns feel free to ping us.

The part about resolving a version from the tool cache is way down the README in the section about check-latest while the very first thing the reader sees is "Downloading and Setting up ...". A clarification will be helpful such as changing the first bullet to "Setting up a requested version of Java from the tool cache, if available, downloading if necessary".
Saying that it sets up JAVA_HOME and adds the Java bin directory to PATH would also be very helpful.
Are the tools listed in, e.g., https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md in the tool cache you refer to? That page describes them as installed software so one doesn't think of them as being cached.
When I first saw this setup I truly wondered it was needed with the current images that have Java installed or if it was something from an earlier era when Java was not installed in the images.

+1, I think it would be clearer to indicate that in the bullet (for example by adding"or using the one already installed") rather than in the advanced documentation

Same here, I was looking for any existence of JAVA_HOME, but it's unclear what happens. It's only mentioned in the https://github.com/actions/setup-java#install-multiple-jdks section.


[otp_ctrl/doc] Add documentation regarding re-parameterization after D3/V3

This addresses one of the cleanup items in https://github.com/lowRISC/opentitan/issues/13438.
Let me know if you think this should be moved to a different section in the spec.
Signed-off-by: Michael Schaffner<EMAIL_ADDRESS>

do you think your description here sort applies to blocks in general? I'm wondering if it makes sense to have this as a common blurb somewhere that other blocks can simply link to.
What do you think? In addition to calling out the common point about V3 needing requalification, you can point out specific parameters of concern.

That probably makes sense, yes.
How about we add a D3 checklist item with the following description?
### DOC_PARAM_IP

If not otherwise stated in the comportable IP specification, all instantiation parameter combinations are considered legal and do not impact D3/V3 status.
If an IP supports only a subset of parameterizations, it must explicitly document the supported parameterizations in a section called "Parameter Changes after D3/V3" in the design specification.

That probably makes sense, yes.
How about we add a D3 checklist item with the following description?
### DOC_PARAM_IP

If not otherwise stated in the comportable IP specification, all instantiation parameter combinations are considered legal and do not impact D3/V3 status.
If an IP supports only a subset of parameterizations, it must explicitly document the supported parameterizations in a section called "Parameter Changes after D3/V3" in the design specification.

that sounds good to me.

I have moved the paragraph a bit further up in the spec into the Hardware Interfaces section where the instantiation parameters are declared.
I will also separately propose the addition to the D3 checklist as discussed above.


Update DV Gradle plugin to 3.17.4

Title says it all

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build


adding new function: wireresistance

Hi, @engineerjoe440. This is my first attempt to create a pull request and add a new function. I've tried to recreate your style of coding. This wireresistance function is based on https://www.basictables.com/electronics/resistor/wire-resistance.
If there is anything to change or improve, I would be glad to help.

Thanks a lot. GitHub says that only those with write access to this repository can merge the pull request.

Thanks a lot. GitHub says that only those with write access to this repository can merge the pull request.

Ah.... ok! Thanks! I'll slam it in and merge it then! :) Much appreciated!

Here's the resulting documentation as built from the Sphinx runner and docstring in your new content: https://engineerjoe440.github.io/ElectricPy/api/electricpy.wireresistance.html#electricpy.wireresistance
Please let me know if there's anything weird in how it appears, and we can get it fixed. I think it looks great!


Fix Meet the Team margin between picture and name

Looks a little too cramped, especially in dark mode with the picture shadow overlapping the name

I'd like to attempt to fix


Update backbone-paginator to 2.0.2

backbone.paginator 2.0.2
https://github.com/backbone-paginator/backbone.paginator/releases/tag/2.0.2

Thanks!


TableEntity no subclasses?

The documentation is still referencing the ability to extend TableEntity. Should we assume moving forward that will be removed or is it possible that the ability will be added back in?

Hi @Marina132000ae. For the time being, subclassing TableEntity is not supported, however, this doesn't necessarily mean it won't be supported in the future.
Thanks a lot for pointing this out. I will correct the documentation you mention to reflect the actual behavior of the SDK. Would you mind adding a link to where you saw this?

I was talking about the javadoc (specifically this line). It's also here: https://docs.microsoft.com/en-us/java/api/com.azure.data.tables.models.tableentity?view=azure-java-stable, but I'm guessing that's built off the javadoc. Thanks, @vcolin7!

You're correct, this is built off the JavaDoc, so I will correct it to remove the mention to subclassing. Thanks!


How to focus the upper panel (with the list of services) instead of the log ?

in TUI, I've realized that some mappings dont work when the log panel is focused (for instance restarting the service). It doesnt seem to me that this needs to be this strict though I could understand why it's done like this (per mapping component). In which case I would like to know if there is a mapping to switch between the "service panel" and the "log panel" ?

I propose that we restart the currently selected service even when focusing the log panel but not sure about the implications.

Added toggle focus support (TAB) in v1.0.0.

awesome ty


Update components/Node.js in info addon

Issue: #4224
What I did
Change the font color to be accessible
How to test
Is this testable with Jest or Chromatic screenshots? Yes
Does this need a new example in the kitchen sink apps? No
Does this need an update to the documentation? No
If your answer is yes to any of these, please make sure to include it in your PR.
For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Please run yarn test --core --update to update test snapshots

@Hypnosphi is there anything else you want me to do for thiis PR?

No thanks


Calling Nuitka functions from C++

Hi,
I am working on video enhancement software, and I want to run my Python code from C++.
I ran
python -m nuitka --module CSR.py to generate a .so file, and I moved it to the directory /usr/local/lib/eye.
I can compile a file with this .so file (run_python.cpp)
g++ -L /usr/local/lib/eye run_python.cpp -o run -lCSR
This compiles and runs.
However, I want to learn how to call the functions in CSR.py from run_python.cpp. Is there a way to do this?

Checkout how to embedd Python interpreter in the Python C/API documentation.


默认配置 maxConcurrentOperationCount 错误

XMEngine Line:541
#pragma mark - Accessor

- (AFHTTPSessionManager *)sessionManager {
    if (!_sessionManager) {
        _sessionManager = [AFHTTPSessionManager manager];
        _sessionManager.requestSerializer = self.afHTTPRequestSerializer;
        _sessionManager.responseSerializer = self.afHTTPResponseSerializer;
        _sessionManager.operationQueue.maxConcurrentOperationCount = 5; // this is incorrect
        _sessionManager.completionQueue = xm_request_completion_callback_queue();
    }
    return _sessionManager;
}

We should not modify this property maxConcurrentOperationCount
see : https://github.com/AFNetworking/AFNetworking/issues/3720 for detail

thx.

... the operationQueue property does not reflect any network operations, just the delivery of delegate messages as it is equal to the delegateQueue ... setting it's concurrency doesn't effect the concurrency of the operations or task, and this should be done via HTTPMaximumConnectionsPerHost of the NSURLSessionConfiguration.


feat: verify tts engine properties

check the /voices endpoint to make sure any credentials are working, e.g. if azure key is set, make sure azure voices are being returned.

fixed by b5f0da56e86a3f81c666c61189c74f46db85a33a


feat(chat-e2e): updated tests with models grouped by version feature

Description:

updated tests with models grouped by version feature
automated test-case EPMRTC-1945

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix:, feat:, feature:, chore:, hotfix: or e2e:
[x] if contains breaking changes then the pull request name starts with fix!:, feat!:, feature!:, chore!:, hotfix!: or e2e!:
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review

/deploy-review

/deploy-review

/deploy-review

/deploy-review


VerifiableCredential.create make value for type optional

Purpose
From this slack convo we've discovered that if we pass a value to type it will break LD processors who consume it. Since KCC is a JSON-LD construct. Right now we're able to do this in JS but not in KT.
Currently:
        val knownCustomerCredential = VerifiableCredential.create(
            type = "KnownCustomerCredential",
            issuer = issuerBearerDid.uri.toString(),
            subject = customerBearerDid.uri.toString(),
            expirationDate = expirationDate,
            data = KccCredential("US" , "Gold"),
            evidence = evidence,
            credentialSchema = CredentialSchema(
                id = "https://schema.org/PFI",
                type = "JsonSchema"
            ),
        )

Desired goal:
        val knownCustomerCredential = VerifiableCredential.create(
            issuer = issuerBearerDid.uri.toString(),
            subject = customerBearerDid.uri.toString(),
            expirationDate = expirationDate,
            data = KccCredential("US" , "Gold"),
            evidence = evidence,
            credentialSchema = CredentialSchema(
                id = "https://schema.org/PFI",
                type = "JsonSchema"
            ),
        )

thanks 💖

but the actual object that gets created Will have a type of VerifiableCredential right? (this is the spec)

you should be able to add type VerifiableCredential as a workaround do
    val knownCustomerCredential = VerifiableCredential.create(
        type = "VerifiableCredential",
        issuer = issuerBearerDid.uri.toString(),
        subject = customerBearerDid.uri.toString(),
        expirationDate = expirationDate,
        data = KccCredential("US" , "Gold"),
        evidence = evidence,
        credentialSchema = CredentialSchema(
            id = "https://schema.org/PFI",
            type = "JsonSchema"
        ),
    )

@nitro-neal yes @decentralgabe said it's ok for it to have the type verifiableCredential I don't fully understand why that's ok but the other isn't lol so it makes me think that doing this workaround won't work.
@decentralgabe can you clarify some more please

The VC bible says it so lol:
https://www.w3.org/TR/vc-data-model/#types

ah ok perfect I'll use the work around- thanks @nitro-neal

@nitro-neal , @decentralgabe would VerifiableCredential being duplicated cause a problem?

it may not create a problem it would depend on the LD processor, but we should not have duplicate values if we can avoid it

ok cool so yea we need the SDK updated, cause this work around will create a duplicate

yep, @EbonyLouis confirming you're correct - using this
val vc = VerifiableCredential.create(
      type = "VerifiableCredential",
      issuer = issuerDid.uri,
      subject = holderDid.uri,
      data = StreetCredibility(localRespect = "high", legit = true)
    )

will create a vc with the vc.vcDataModel that looks like this

pushing up a pr now :)

@jiyoontbd thank you! 🙌🏾