Distribute Strategy wrong reduction

URL(s) with the issue: https://www.tensorflow.org/guide/distribute_strategy#using_tfdistributestrategy_with_custom_training_loops
Description of issue (what needs changing):
In the documentation the snippet:
def train_step():
  def step_fn(inputs):
    features, labels = inputs
    logits = model(features)
    cross_entropy = tf.nn.softmax_cross_entropy_with_logits(
        logits=logits, labels=labels)
    loss = tf.reduce_sum(cross_entropy) * (1.0 / global_batch_size)
    train_op = optimizer.minimize(loss)
    with tf.control_dependencies([train_op]):
      return tf.identity(loss)

  per_replica_losses = mirrored_strategy.experimental_run(
      step_fn, input_iterator)
  mean_loss = mirrored_strategy.reduce(
      tf.distribute.ReduceOp.MEAN, per_replica_losses)
  return mean_loss

calculates the loss using the distribution strategy. However the loss for each replica is reduced using tf.distribute.ReduceOp.MEAN. I think that the correct loss to return is the loss reduced using tf.distribute.ReduceOp.SUM since every loss is already reduced using the partial mean over the global_batch_size ( tf.reduce_sum(cross_entropy) * (1.0 / global_batch_size)) .
I think a better snippet would be:
def train_step():
  def step_fn(inputs):
    features, labels = inputs
    logits = model(features)
    cross_entropy = tf.nn.softmax_cross_entropy_with_logits(
        logits=logits, labels=labels)
    loss = tf.reduce_sum(cross_entropy) * (1.0 / global_batch_size)
    train_op = optimizer.minimize(loss)
    with tf.control_dependencies([train_op]):
      return tf.identity(loss)

  per_replica_losses = mirrored_strategy.experimental_run(
      step_fn, input_iterator)
  loss = mirrored_strategy.reduce(
      tf.distribute.ReduceOp.SUM, per_replica_losses)
  return loss

Am I wrong?
Submit a pull request?
Maybe I can submit a pull request to fix this.
Are you planning to also submit a pull request to fix the issue? See the docs
contributor guide: https://www.tensorflow.org/community/contribute/docs and the
docs style guide: https://www.tensorflow.org/community/contribute/docs_style

hi @EmanueleGhelfi - you're absolutely right, and looks like we've fixed the documentation too :) thanks for reporting and apologies for the delay!


Using a pressure plate while opening a castle gates is broken

I'm not on the /nl group, but when I stand on the pressure plate the redstone activates, which activates the castle gates.
http://imgur.com/a/n0izc
First Image: Before me standing on the pressure plate.
Second Image: After me standing on the pressure plate.

fwiw I confirmed he isn't on the group.

@ProgrammerDan
Could you please provide castlegates config? (I don't need list of blocks if it is considered as not-for-players info)
@searedOG
Could you please confirm that gearblocks do not belong to your groups as well?
CastleGates is checking /nl groups only for blocks which are currently in the world.
This means that if you haven't access to "bridge" blocks but have access to gearblocks - it could close gates (because of "bridge" blocks are hidden at the moment) but cannot open.

I don't think the gears were reinforced, just the pressure plate ... I'd have to doublecheck

@Aleksey-Terzi
Config:
Settings:
  AllowAutoCreate: true
  MaxPowerTransfers: 8
  MaxBridgeLength: 16
  PlayerStateResetInSeconds: 300
  SwitchTimeout: 1000
  MaxRedstoneDistance: 7
  InteractWithSnitches: true
  LogChanges: true

I don't think the gears were reinforced, just the pressure plate

CastleGates + Citadel is working in the same way as door - should be reinforced only gearblocks and bridge blocks, but there are no difference if redstone mechanism (button, pressure plate, lever and etc) is reinforced or no.
If player with /nl rights is near the gerablocks and bridge blocks or them are not reinforced - then CastleGates will activate gates/bridge.


More than one whitespace not honored for row data

Hey I'm wondering if this is expected behavior but when we pass in row data to the Table component, if a single row element has > 1 whitespace i.e "Ahmed.....Meky" (where periods represent whitespace) the table renders "Ahmed Meky" for that element.
Here is another example:

Is there anything we can do to ensure whitespace is detected by the table?

set css style={{whiteSpace:"pre"}} can solve it

<Column label="Name" dataKey="name" width={200} style={{ whiteSpace: "pre" }} />

@VitoriaTangHeng Ahh perfect this works now. Thank you very much!


[IDEA] Metadata Filtered NFT Voting Strategy

Is your feature request related to a problem? Please describe.
Interested in continuing to test implementations for Ballerz and Gaia but both would require filtering on a setID metadata field.
Describe the solution you'd like
Metadata filtering NFT voting strategy similar to CollabLand's token gated roles. Screenshots attached.
Additional context

@benyarb Hey there -- we're working towards a user-friendly way of creating these kinds of custom strategies in the future, but in the meantime our custom script feature could offer an interim solution. I'll reach out to chat further about how custom scripts work and getting you set up.

hey @markedconfidential, thanks for the reply! sounds good, it should be a pretty simple script. verifying Ballerz requires filtering on the setID metadata attribute on the Gaia contract at A.8b148183c28ff88f.Gaia. Ballerz has a setID value of 2. let me know if there's anything I can do.


Paste functionality not working

Here is a minimal code to reproduce.
import { initialize as initializeMonacoServices } from 'vscode/services';
import 'vscode/localExtensionHost';

wait initializeMonacoServices({});

When I render  a monaco editor, I've noticed that the paste functionality is not working at all. It's impossible to paste a text to the editor. Probably the code that handles pasting got removed by accident or become part of other codingame service override.

Might be related to https://github.com/microsoft/monaco-editor/issues/4438

I confirmed that node_modules/vscode/vscode/src/vs/editor/contrib/clipboard/browser/clipboard.js is executed in browser and that https://github.com/microsoft/monaco-editor/issues/4438 is the source of the problem.

This brings me to the realization that with @codingame/monaco-vscode-editor-api it is not clear at all what version of monaco-editor this represents and how to match issues from https://github.com/microsoft/monaco-editor/issues to releases of @codingame/monaco-vscode-editor-api

You should endure that process is properly not defined

This brings me to the realization that with @codingame/monaco-vscode-editor-api it is not clear at all what version of monaco-editor this represents and how to match issues from https://github.com/microsoft/monaco-editor/issues to releases of @codingame/monaco-vscode-editor-api

We are synchonized on the VSCode releases and not on the editor releases anymore, but they often happen really close in time

We are synchonized on the VSCode releases and not on the editor releases anymore, but they often happen really close in time

Thanks for explanation.
For the time being I'll try to downgrade below the affected versions. Following versions are affected by the issue:
    "monaco-editor": "npm<EMAIL_ADDRESS>    "vscode": "npm<EMAIL_ADDRESS>

We are synchonized on the VSCode releases and not on the editor releases anymore, but they often happen really close in time

Thanks for explanation.
For the time being I'll try to downgrade below the affected versions. Following versions are affected by the issue:
    "monaco-editor": "npm<EMAIL_ADDRESS>    "vscode": "npm<EMAIL_ADDRESS>

Are you sure it's an issue for you to not inject process though? it's not a good practice anyway

Are you sure it's an issue for you to not inject process though? it's not a good practice anyway

I'm already injecting process because I need it elsewhere, so I cannot just set it to undefined to get around the bug.
      new webpack.ProvidePlugin({
        process: 'process/browser.js',
      }),

Would it be possible to apply a patch as part of this repo build process?

Found a workaround for this bug by utilizing default webpack BannerPlugin:
      new webpack.BannerPlugin({
        banner: "globalThis.vscode = { process: Symbol.for('vscode') };",
        raw: true, // This is important, it tells webpack to prepend the code as-is.
        entryOnly: true // This adds the banner only to the beginning of the bundle.
      }),

globalThis.vscode = { process: Symbol.for('vscode') }; - works as a workaround for the new flow logic introduced in https://github.com/microsoft/vscode/pull/200935/files

You seem to considering it as a bug while it's not really a bug. You're not supposed to have a process defined in the browser.

I need have the process defined due to other required dependencies withing the dependency tree.

I'm not sure how to manage to make isWeb = true with that change

It works because of this code.
let nodeProcess: INodeProcess | undefined = undefined;
if (typeof $globalThis.vscode !== 'undefined' && typeof $globalThis.vscode.process !== 'undefined') {
	// Native environment (sandboxed)
	nodeProcess = $globalThis.vscode.process;
} else if (typeof process !== 'undefined') {
	// Native environment (non-sandboxed)
	nodeProcess = process;
}

Then it goes to
if (typeof nodeProcess === 'object') {

and finally to:
else if (typeof navigator === 'object' && !isElectronRenderer) {

...which is what I want.

I need have the process defined due to other required dependencies withing the dependency tree.

Then it's a bug of the other library, or it's not compatible with the browser

It works because of this code.
let nodeProcess: INodeProcess | undefined = undefined;
if (typeof $globalThis.vscode !== 'undefined' && typeof $globalThis.vscode.process !== 'undefined') {
	// Native environment (sandboxed)
	nodeProcess = $globalThis.vscode.process;
} else if (typeof process !== 'undefined') {
	// Native environment (non-sandboxed)
	nodeProcess = process;
}

Then it goes to
if (typeof nodeProcess === 'object') {

and finally to:
else if (typeof navigator === 'object' && !isElectronRenderer) {

...which is what I want.

I've tried this kind of hacks and I had issue because global.vscode.process is also used in vs/base/common/process.tswith a much simpler condition, and your change makesplatform` undefined and a lot of stuff uses that, including the path management, making the window detection not working

Good point. I need to address the root cause...

Unfortunately I'm unable to address the root cause because of the fact that AsyncAPI renderer (which I'm using) is using https://github.com/APIDevTools/json-schema-ref-parser.
It's using a process.prop without any imports. So that's why ProvidePlugin must be used to build the project.

I see no code in https://github.com/APIDevTools/json-schema-ref-parser that use the process object in the browser, what file are you referring to?

https://github.com/APIDevTools/json-schema-ref-parser/blob/7a8806da56a852e28df66d45a2238faa5b3bcf84/lib/util/url.ts#L50

It's only called if window is undefined
btw, their documentation mentions webpack fallback but nothing about process

Yeah, its because I'm using version v9 and v11 doesn't have this issue.

I was able to apply process import just for a single file using webpack rule:
            {
              test<EMAIL_ADDRESS>              loader: 'imports-loader',
              options: {
                type: 'commonjs',
                imports: ['single process/browser process'],
              },
            },

Unfortunately this needs to be done by all downstream consumers until I'm able to update the library.

Note that the issue was fixed in https://github.com/microsoft/vscode/commit/8caaab7a3e63b315dbde77cb159cc7928accf8e2

@CGNonofr thanks for the notice


Housekeeping

Before doing some bigger changes, just taking a moment to catch up with what's current in the RN/JS world.

Travis still isn't integrated (see #2), but it passes locally. So, will merge. brb!


GitHub issue links in WebStorm Git log

Overview
GitHub issue links in WebStorm Git log

Definition of Done
Clickable links in WebStorm Git log
Before - #2236
After -  #2236

Hi @turansky! Most of our internal developers have moved from WebStorm to VSCode. For those still using WebStorm, does this make sense to be an individual developer setting or committed to the project?

For those still using WebStorm, does this make sense to be an individual developer setting or committed to the project?

Commited settings are preferred.

Otherwise I will modify vcs.xml, which already exists in repo.
Usually I fork Cesium from scratch and lose all IDE settings.

Thanks @turansky!


Fix assembling instructions with unknown/don't care context bits

Without this change, if unspecified context bits are provided to the assembler they are defaulted to 0 and the resulting context is used to filter for valid assembly instructions. After this change unspecified bits are kept as unspecified through the assembly process possibly providing additional valid assembly results.
This change is needed to help support Pickled Canary's support for context.
Submitting on behalf of a colleague: Will R

We've just pushed some updated test cases which illustrate (at least some of) the current limitations of this implementation.
The proposed solution in this pull request currently may produce unexpected results when the assembler resolves ^instruction phases/root recursion. The restore instruction in MIPS16 illustrates this issue, as it may be encoded with 16-bits or extended to 32-bits depending on the operands. This extension/prefix is implemented with an ^instruction phase across the board in mips16.sinc. For example, with restore 0x1b8,ra,s0-s1, we only expect to receive 32-bit encodings from the assembler (due to the value of the literal operand).
However, when the context provided to the assembler only has ISA_MODE and RELP set to one (all other context bits unknown), half of the encoding is lost. The result is 0x6477, when we expect something akin to 0xf0306477. Additionally, the same 0xf0306477 disassembles to restore 0x38,ra,s0-s1, which is not what we gave the assembler. We suspect this issue has to do with the implementation and usage of the context transition graph required for pure recursive resolution (AssemblyContextGraph.java). It appears that this class was designed for complete input contexts (see computeOptimalApplications()), and would require some alterations to support unknown context bits.
We have started to experiment with possible fixes, but we'd greatly appreciate any tips about the right way to proceed.

It's been a while since I've read through this code, but yes, the troubles you're having around ^instruction sound very familiar. If I could have my way, I'd ban ^instruction (or any production of the form A->A) and require Slaspec authors to specify an alternative start symbol, but alas.
I think part of the core issue is that context bits get (ab)used for all sorts of interesting purposes, and believe me, I'm no stranger to abusing context bits.... That said, I suspect what you intend to get by leaving the context unspecified is "all possible encodings that might appear in a binary." Though that context may change wildly during disassembly of a single instruction, there's actually only so many possible input contexts when starting an instruction. We have a notion of "default context" and "global sets". The latter is also sometimes called "context commits." When the disassembler starts, it uses the default context for the processor as input. Some instructions in the Slaspec may use the "globalset" function in its context transitions. Those will place context changes that persist at a given address. When the disassembler encounters that address it applies the change to the input context for that instruction. So, what I might suggest:

Scrape all the .pspec files that go with the same .slaspec file (you may have to "go up" to the .ldefs files). I think you can avoid scraping the actual files by just querying the DefaultLanguageService, and accessing the various attributes on each language returned. You should then be able to collect all the possible "default contexts." For that part, I think you can use ProgramContextImpl.
This part may not be necessary, but perhaps scrape for possible globalset-based transitions that could change the input context. It looks like ContextCommit is a subclass of ContextChange, and those are accessible via Constructor.getContextChanges(). Consider whether you must be cognizant of the target address. To try to get a handle on how its fields are interpreted, examine SleighParserContext.addCommit and applyCommits.
Once you have those, you should be able to collect all the possible input contexts. You'll probably just have to provide each one of them, fully defined, in a separate call to the assembler. It's maybe possible you can compress the set of contexts by leaving some bits undefined. Or maybe you can short-circuit the exhaustion in (2) above by just saying "if there's a globalset that can affect this bit, I'll just leave it undefined." In this way, only select bits are undefined. Maybe that would improve things?

Hope this helps.

We gave your suggestions a try; here’s an overview of our scraping attempts and the issues we encountered:
Initially, we attempted to use possibleVals() from AssemblyPatternBlock to generate all the possible input contexts based on a given default context. Unsurprisingly, this resulted in an enormous number of possible input contexts, as the default context may contain many unknown bits (which seemingly correspond to context variables left unset in the .pspec). This issue is exacerbated by the requirement for contextreg to be at least 32-bits long. Additionally, some unknown bits may be for purely local context variables, while others could belong to context variables passed to globalset (the ones we care about). It appears there is no guarantee that a context variable that's globalset will have a default value specified in the .pspec.
We improved this approach by scraping for context variables used in globalset directives and ignoring context variables that were only set locally.  While this significantly reduced the number of possible input contexts (generated by possibleVals()) for some languages, the number was still quite large for languages that make liberal use of context. In some cases, context variables passed to globalset were many bits wide, which exponentially increased the number of possible combinations (most of which were invalid). We have also observed abuse of extra wide context variables and globalset to propagate encoding fields from one instruction to another.
To mitigate these issues, we began scraping the bit pattern section of each constructor to check the constraints of context variables we know get globalset. Our goal is to eliminate the globalset context variables that do not affect constructor selection, and to determine every valid value for the variables that do (not every possible value). However, we are not certain that scraping a language in this way is proper or sufficient.
While our scraping approach appears to work for trivial cases (e.g., ARM/Thumb), an approach that doesn't scrape or call resolveTree() multiple times would likely be superior.
There's a remaining TODO regarding how to best ensure that AssemblyResolutionResults have the proper context. There's a simple function to force this at the bottom of WildSleighAssembler but we'd appreciate any thoughts regarding how to ensure the context isn't lost in the first place, or where makes the most sense to save & restore it.


add support for only retrieving direct children from /api/v4/file/children//

Is your feature request related to a problem? Please describe.
The /api/v4/file/children/<sha256>/ api gives you all children recursively. Given the context of retrieving a child file, this was not expected behavior.
Describe the solution you'd like
To keep the API backwards compatible, add an option to the API that allows you to only retrieve the direct children of a given file hash. Also update the api docs to indicate the default retrieval is a recursive view of all child files extracted.

After some further testing, it seems like there may also be a bug in the existing implementation.
Here's an example submission tree where i noticed an issue.
fileA

fileA.1

fileA.1.1
fileA.1.2

fileA.2
fileA.3

Assuming the above file submission tree, i called the /api/file/children in the following scenarios:
Scenario 1 - retrieve children for fileA

it returned fileA.1, fileA.2, and fileA.3 - all the direct children. In the service's current form, i would have expected all files to be returned, including fileA.1.1 and fileA.1.2.

Scenario 2 - retrieve children for fileA.1

it returned fileA.1.1 and fileA.1.2 as expected

Testing another sample with a bigger hierarchy, of the 14 child files (various child/grandchild+) represented in the UI tree view, only 6 were returned when requesting the children for that root file. The 6 files returned were at various levels of the tree. All of the direct children, a grand-child, and great-great-grand-child in this case.
I have observed that all direct children of a file seem to always be represented. It's everything below the child file that seems to be sporadic.

We'll add a direct_children_only param to the API that will default to false not breaking current behavior and allowing to get only the direct children.

After taking a look at our /api/v4/file/children/, it seems that the API does in fact only return the direct children of the file based on the results generated about that file given.
The file tree view that you see in the UI (generated by /api/v4/submission/tree/<sid>/), does prune duplicate files (even at differing levels) from the original tree so it's possible to see more direct children through the /api/v4/file/children/<sha256> API than what's shown in the UI.

As @cccs-rs was pointing out, like your first fileA example is showing in both scenario 1 and scenario 2, only direct children are returned from the file/children/<sha256> API.
Regarding that second scenario:

Testing another sample with a bigger hierarchy, of the 14 child files (various child/grandchild+) represented in the UI tree view, only 6 were returned when requesting the children for that root file. The 6 files returned were at various levels of the tree. All of the direct children, a grand-child, and great-great-grand-child in this case.
I have observed that all direct children of a file seem to always be represented. It's everything below the child file that seems to be sporadic.

The grand and great-great-grand-children that show up are also children of your original file. If you still have an example to test it on, could you go to https://your-instance/file/detail/<sha256>? You would see the list of Possible Children, among which should be all of the expected direct children, plus the two "unexpected" ones, for a total of six. They should be direct children of your file, and you should be able to find them from one of the service result underneath.
If you go to https://your-instance/file/detail/<unexpected-child-sha256>, you should see in the Possible Parents section your original file, and other(s) that should be part of your original submission, under which it showed up in the file tree. If you then go to those other parents, you should see that unexpected-child-sha256 as part of their children.
In your original submission, you will have the file tree at the bottom, but the submission view does some work to prune duplicate files to alleviate the tree. It shows only once even if the same file/same hash is a child of two different files. You should be able, from the submission view, to click on your original/submitted file, and go through all the results to see the 6 extracted files.
Regarding that API, another situation that could be unexpected would be:
Submission A, sending file A with a certain set of services that extracted 3 files.
Submission B, sending file A (same) with a completely different set of services that extract 4 different files.
By looking at the detail view of file A, you should see 7 Possible Children, even if by looking at any submission, you only see 3 or 4.
The API will therefore return the list of 7 files, as they are all possible children of your file.
I hope the API is clearer now. :)

Thanks for the helpful explanation! I now understand the behavior i was seeing and will go ahead and close this out.


Testing code to adhere to Pylint score (9/10)

As a ...
I need ...
So that ...
Assumptions:
...
Acceptance Criteria
...
Given ...
When ...
Then ...

Detailed out the user story


How to record mobile sized videos

I'm submitting a ...
[ ] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[x] question about how to use this project

Summary
Hey, is there a way to record videos in mobile view? E.g. using mobile view in chromium?
I've tried doing this in pupetteer, setting viewport like this

await page.setViewport({
    width: 375,
    height: 667,
    isMobile: true,
  })

but puppeteer-screen-recorder still records whole page

@mecirmartin I am using following config to record mobile videos.
await page.setUserAgent( "Mozilla/5.0 (iPhone; CPU iPhone OS 12_0 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/70.0.3538.75 Mobile/15E148 Safari/605.1");
await page.setViewport({
    width: 375,
    height: 667,
    deviceScaleFactor: 1,
  });

I am not using isMobile.


Use Rpch provider

Use Rpch provider to decommission secondary server

Or do what @tolbrino suggests. 🍻

Actually, we should revert the Rust changes in this repo, since the currently deployed provider proxy is the one still using JS since that seemed to be faster.
Also is that provider able to handle the load?

So you mean that I revert this PR https://github.com/hoprnet/provider-proxy/pull/13 and then change the URL?

Will be implemented in the Typescript code


Property 'getCallbackUrl' in type 'AutomationWorkflowService' is not assignable to the same property in base type 'IWorkflowService'.

Describe the Bug with repro steps
getCallbackUrl in IWorkflowService returns the type CallbackInfo in designer-client-service lib instead of the CallbackInfo in '@microsoft/logic-apps-shared'. It caused the package consume like us to face Property type miss match error.

here is my code

The error I got:

What type of Logic App Is this happening in?
Consumption (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
No response
Browser
Edge
Additional context
No response

Recommendation for now is to copy the correct type to the host and use it. Will fix in a later breaking change.


add correct contact info to all pages

<EMAIL_ADDRESS>and myself<EMAIL_ADDRESS>on all pages that need contact info (submission form and error pages)

message added to error.html to enp-dev branch

also in tbn-dev as 'date picker'


Video Link Parsing

Video link isn't parsing after START button is clicked

@CovenantJunior hey, thanks for the notice! Sadly the project got a bit down on priority, But I will get back to it sometime soon and will take a look.

@CovenantJunior hey, thanks for the notice! Sadly the project got a bit down on priority, But I will get back to it sometime soon and will take a look.

Alright, that'll be great! 🙂

Should be fixed with PR #3.
A new APK has been uploaded that can be downloaded via the QR code

Awesome, thanks!
On Thu, Apr 21, 2022, 12:34 PM Gergely Hegedis @.***>
wrote:

Should be fixed with PR #3
https://github.com/fknives/TikTok-Downloader/pull/3.
A new APK has been uploaded that can be downloaded via the QR code
—
Reply to this email directly, view it on GitHub
https://github.com/fknives/TikTok-Downloader/issues/2#issuecomment-1105092075,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASUWHNGML634HL4GOOMSY63VGE4LVANCNFSM5QIERAFQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Build an automated test for a dApp

dApp consists of several components;
Some can be tested with GitHub CI; others using plutip, quickcheck, plutus-simple-model, and other tools

Testing
We test contracts using a model of the system, which includes the state(s) of all the agents involved–the on-chain state, the off-chain state on your computer, the off-chain state on anyone else’s computer–everything relevant to the contract(s) under test.
okOKokok; what do I need to do?
Where does this doc leads?
Automatic test generation using QuickCheck.

https://github.com/aleeusgr/nix-things/issues/20


Add pyyaml requirement to rosidl_cli target

This adds the pyyaml requirement and makes the example compile.

This change is

Turns out this is not sufficient to build the example. But it fixes bazel build @ros2.rclcpp//rclcpp:rclcpp at least.


WIP: Use fetchSize, return next page instead of the current one

Fixes #2591
Problem
val queryToRun = quote {
      query[MY_TABLE]
    }

    val observable = ctx.stream(queryToRun, 10000)

The above query would only fetch 5000 pages regardless of value of fetchSize provided.
That's because of 2 reasons:

the fetchSize gets disregarded and the page size defaults to 5000
when streaming the data the paging algorithm never returns the next page. It keeps returning the same page

Solution

Take the fetchSize into account

Return the next page instead of the current one

[x] Unit test all changes

[x] Update README.md if applicable

[x] Add [WIP] to the pull request title if it's work in progress

[x] Squash commits that aren't meaningful changes

[x] Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Dionysios Ntaouros seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@ntaouros Can you rebase your PR, pleae?


Update 100-with-react-three-fiber.mdx

fix the PerspectiveCamera import

Thank you @snsie. Fixed via #15


KAFKA-2886: handle sink task rebalance failures by stopping worker task

@ewencp, @Ishiihara: Note that I've removed the synchronized blocks in WorkerSinkTask since it seems the methods are only called from within the WorkerSinkTaskThread. I'm happy to revert this change and open a separate ticket if you prefer.

@hachikuji The exception handling make sense. It would be nice if we can add a simple unit test to make sure the exception is caught properly to ease future development.
@ewencp I think removing the synchronization code makes sense but I do feel a bit wired with the current threading. It seems that the main thread doesn't do much other than starting the work thread. If performing the work in another thread is not necessary, should we simply it to only use one thread?

@hachikuji Verified the unit tests. LGTM in general. I would like to hear comment from @ewencp on the synchronization and threading.

@Ishiihara Sounds good. I'm just getting started with this code, but the current threading model seems reasonable to me. I see the Worker as just the task manager, which is primarily responsible for managing the task lifecycle. Currently this just means starting and stopping tasks, but it'll probably have to be extended to handle task failures. I assume it'll also need hooks for status tracking. Also, I like the tasks being single-threaded since it makes it easy to reason about their state.

@ewencp As discussed, I removed abort() and changed WorkerSinkTaskThread to allow the exception to propagate to ShutdownableThread.

LGTM -- tests pass locally and the failure in Jenkins looks unrelated.


todo: disable commenting if user is not signed in

If the user is not signed in:

The comment input and button must be disabled
The comment button should maybe change to "Sign in to comment" or similar

Can I work on this issue?

Can I work on this issue?

Sorry, @gaurab-khanal. This is already being worked on in #507.


added Nvidia's binaries folder, getting No module named 'PySide2' error opening a simple usd file.

I added the Nvidia compiled binaries to the "path to op[enusd library" then tried to open a simple .usd ascii file but it failed
here is the usd I am trying to open, simple save the text as a .usd file
#usda 1.0
(
    "Exported from Adobe Substance 3D Painter 8.3.0"
    defaultPrim = "root"
    subLayers = [
        @./MeetMat.material.usda@
    ]
)

def "root" (
    prepend references = @./MeetMat.geo.usd@
)
{
}

and here is the error log:
Command failed: usdview f:\Users\Ahmed Hindy\Documents\Adobe\Adobe Substance 3D Painter\export\MeetMat.usd
Traceback (most recent call last):
  File "G:\Projects\USD<EMAIL_ADDRESS>line 28, in <module>
    import pxr.Usdviewq as Usdviewq
  File "G:\Projects\USD<EMAIL_ADDRESS>line 32, in <module>
    from .qt import QtWidgets, QtCore
  File "G:\Projects\USD<EMAIL_ADDRESS>line 42, in <module>
    PySideModule = GetPySideModule()
  File "G:\Projects\USD<EMAIL_ADDRESS>line 31, in GetPySideModule
    from . import attributeValueEditorUI
  File "G:\Projects\USD<EMAIL_ADDRESS>line 11, in <module>
    from PySide2.QtCore import *
ModuleNotFoundError: No module named 'PySide2'

If you want to use usdview, you should install python dependencies manually such as PySide and etc


[HUDI-1787] Remove the rocksdb jar from hudi-flink-bundle

Remove the RocksDB jar from hudi-flink-bundle to avoid conflicts.
Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
hudi-common and hudi-timeline-service using rocksdbjni:5.17.2
flink-statebackend-rocksdb(flink-dist including this) using com.data-artisans:frocksdbjni:5.17.2-artisans-2.0
both are conflicting.
flink-hudi-bundle depends on hudi-common and hudi-timeline-service.
Remove the RocksDB jar from hudi-flink-bundle to avoid conflicts.
Brief change log

Modify pom.xml in hudi-flink-bundle

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #2807 (97b6f4e) into master (d035fcb) will decrease coverage by 42.90%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #2807       +/-   ##
============================================
- Coverage     52.27%   9.37%   -42.91%
+ Complexity     3681      48     -3633
============================================
  Files           484      54      -430
  Lines         23092    1995    -21097
  Branches       2457     235     -2222
============================================
- Hits          12071     187    -11884
+ Misses         9958    1795     -8163
+ Partials       1063      13     -1050

Flag
Coverage Δ
Complexity Δ

hudicli
?
?

hudiclient
?
?

hudicommon
?
?

hudiflink
?
?

hudihadoopmr
?
?

hudisparkdatasource
?
?

hudisync
?
?

huditimelineservice
?
?

hudiutilities
9.37% <ø> (-60.38%)
0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ
Complexity Δ

...va/org/apache/hudi/utilities/IdentitySplitter.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-2.00%)

...va/org/apache/hudi/utilities/schema/SchemaSet.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-3.00%)

...a/org/apache/hudi/utilities/sources/RowSource.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-4.00%)

.../org/apache/hudi/utilities/sources/AvroSource.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-1.00%)

.../org/apache/hudi/utilities/sources/JsonSource.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-1.00%)

...rg/apache/hudi/utilities/sources/CsvDFSSource.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-10.00%)

...g/apache/hudi/utilities/sources/JsonDFSSource.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-4.00%)

...apache/hudi/utilities/sources/JsonKafkaSource.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-6.00%)

...pache/hudi/utilities/sources/ParquetDFSSource.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-5.00%)

...lities/schema/SchemaProviderWithPostProcessor.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-4.00%)

... and 461 more

Hi @MyLanPangzi, we are planning to use rocksdb as the default state backend instead of hdfs, would you like to take this ticket https://issues.apache.org/jira/browse/HUDI-981

Hi @MyLanPangzi, we are planning to use rocksdb as the default state backend instead of hdfs, would you like to take this ticket https://issues.apache.org/jira/browse/HUDI-981

What do you mean? The hudi-flink connecotr is using rocksdb as state backend now.

Hi @MyLanPangzi, we are planning to use rocksdb as the default state backend instead of hdfs, would you like to take this ticket https://issues.apache.org/jira/browse/HUDI-981

What do you mean? The hudi-flink connecotr is using rocksdb as state backend now.

I meanHoodieFlinkStreamer and HoodieFlinkStreamerV2

Hi @MyLanPangzi, we are planning to use rocksdb as the default state backend instead of hdfs, would you like to take this ticket https://issues.apache.org/jira/browse/HUDI-981

What do you mean? The hudi-flink connecotr is using rocksdb as state backend now.

I meanHoodieFlinkStreamer and HoodieFlinkStreamerV2

this should be a cli option or a yaml conf not hardcode.
follwing options is provided by flink .
e.g
state.backend: filesystem or rocksdb
state.checkpoints.dir: hdfs://nameservice1/
state.savepoints.dir: hdfs://nameservice1user/xiebo/flink/savepoint/backup
state.backend.incremental: true
state.checkpoints.num-retained: 3
execution.checkpointing.interval: 2 min
execution.checkpointing.timeout: 20 min


Change the foreground and background colors

I'm use With context indent highlighted by treesitter

I expect effect scope of reality only the indentation, other indentation line color is the same as the background color (I'm sorry my English is not good)

Not sure if I understand correctly. You want the normal indent character to be the same color as the background?
You can change the color by redefining the highlight group, for example like so highlight IndentBlanklineChar guifg=#00ff00 gui=nocombine

不确定我是否理解正确。您希望普通缩进字符与背景颜色相同吗？
您可以通过重新定义高亮组来更改颜色，例如像这样highlight IndentBlanklineChar guifg=#00ff00 gui=nocombine

Can only modify the normal indentation characters highlight?

Take a look at :h indent-blankline-highlights
you can change

IndentBlanklineChar
IndentBlanklineSpaceChar
IndentBlanklineSpaceCharBlankline
IndentBlanklineContextChar

and there is also

g:indent_blankline_char_highlight_list
g:indent_blankline_space_char_highlight_list
g:indent_blankline_space_char_blankline_highlight_list

Thank you for success in its place, for to such effect is to want


Collaborators for VESRI mini-article

[x] Summarise criteria article idea needs to meet
[x] Present at ICCS Summer School, soliciting article ideas (based on existing paper or something new)

See also:

#1

From Laura Mansfield (Stanford):

Hi both, thanks for a lovely intro to Fluid last Friday! I’m Laura, I am a postdoc based at Stanford on the Datawave project.
Sorry I didn’t get to talk to you afterwards as I had to rush off to the airport. I would be interested in using fluid to create visualizations that show something with underlying uncertainties, if it sounds within your scope. I often work with Bayesian methods that predict probability distributions but it can be difficult to present the results that include both mean and standard deviation, and usually you then need to create two plots. Maybe fluid could help with this e.g., say I have a contour map of predicted temperatures but each grid cell also has some predicted uncertainty levels, I imagine you could hover over a location on the map and it would show the uncertainty either the numbers or even better if it could say high, middle or low uncertainty or a graphic to indicate this. Hope that makes sense. I could give you a better example based on some work from Datawave if that helps. Let me know if you have thoughts.

Steve got in touch today to say his grad student is putting together some data; at a conference this week but should be in touch next week.

Steve’s PhD student Jose sent through some data and R code. It looks fairly manageable size-wise, although the code will probably take a fair bit of figuring out (at which point we will probably need help from them). Main question is whether/when we might find time to look at this.

From Laura:

Sorry I didn’t have a specific example from a past Datawave paper, but there is data and code from this paper, https://agupubs.onlinelibrary.wiley.com/doi/10.1029/2024MS004292?af=R. In that paper, I didn’t actually present maps but it is something I come across quite often and the data would be in the right format for it (geospatial and ensembles). I find myself quite often plotting maps multiple times, once for a mean prediction and once to represent uncertainty e.g., amongst ensemble members. I’ve added an example where I’ve plotted mean and standard deviation on two separate maps (this is different data from the paper but similar example with gravity waves). Its not that easy to interpret because you have to look at two plots and check the different colour bars, etc. I was imagining for presenting it to the public it might be simpler just to have the one plot with the mean and if you click over each region it tells the user if the prediction has high or low uncertainty. There might also be a use case using open access data from ensemble weather forecasts. Does that make sense?


Separate test and publish workflows

Currently, the test suite does not run for pull requests from a forked repository. This PR separates our workflows into publish, which is responsible for publishing new RCs to npm, and test, which runs the test suite and runs on pull_request instead of push.

Is there a way we can still have the Publish workflow dependent on the Test workflow since we only want to publish if all the tests are passing?

@colebemis I considered this but decided against it because (1) the tests run in a separate workflow anyway, (2) it can be useful to have a 0.0.0 build to test quick changes without updating tests, and (3) it makes the publish a lot faster. That said, I have a pretty weak opinion and would be fine with putting it back.

@BinaryMuse That makes sense. I'm fine with keeping what you have here if we require that Tests passes before merging into master, which we can do with branch protections: https://github.com/primer/components/settings/branch_protection_rules/1506040.


ScrollWheelToKey when FlipScrollWheel has been set

I'm inverting the scroll wheel directions on my mouse only (not touchpad!) using the FlipScrollWheel commands.
However, enabling the flip scroll wheel function prevents my custom ScrollWheelToKey mappings from working. How can I use both at the same time?
here is a snippet from my private.xml :
<item>
    <name>Microsoft Sculpt Mouse - Flip scroll wheel directions</name>
    <identifier>microsoft_flipwheel</identifier>
    <device_only>DeviceVendor::Microsoft, DeviceProduct::SculptComfortMouse</device_only>
    <autogen>__FlipScrollWheel__
        Option::FLIPSCROLLWHEEL_VERTICAL,
        Option::FLIPSCROLLWHEEL_HORIZONTAL
    </autogen>
</item>
<item>
    <name>Modifier with scrollwheel to cycle tabs</name>
    <identifier>modifiedscrollwheel</name>
    <device_only>DeviceVendor::Microsoft, DeviceProduct::SculptComfortMouse</device_only>
    <autogen>__ScrollWheelToKey__
        ScrollWheel::UP, ModifierFlag::FN | ModifierFlag::NONE,
        KeyCode::BRACKET_LEFT, ModifierFlag::SHIFT_L, ModifierFlag::COMMAND_L
    </autogen>
    <autogen>__ScrollWheelToKey__
        ScrollWheel::DOWN, ModifierFlag::FN | ModifierFlag::NONE,
        KeyCode::BRACKET_RIGHT, ModifierFlag::SHIFT_L, ModifierFlag::COMMAND_L
    </autogen>
  </item>

Karabiner applies only the first matched .
https://pqrs.org/osx/karabiner/xml.html.en#order
So, please swap items.

thanks, that fixes this issue. The Karabiner tool is awesome!
Another thing I noticed:
The modified scroll wheel behaviour (xml entries above) only works as long as I do not  move the mouse cursor while holding right-click. As soon as I move the mouse cursor even a tiny bit, the right-click menu comes up instead of the modified behaviour...
Would you be able to suggest a method of achieving tolerance to moving the cursor while holding the mouse button that acts as a modifier for the scroll-wheel ?
Ideally, the right-click menu should not appear at all after triggering any action for which the button acts as modifier (i.e. right-click scroll wheel action).
Instead, the right-click menu should only appear when right-clicking and then releasing the button again, without having performed any action for which the button acts as modifier.
Is the behaviour described above possible to configure with karabiner?

Thank you for feedback.
It seems a bug.
Please wait for a while.

I've fixed the __KeyOverlaidModifier__  issue at the latest beta version. (v10.6.70)
How to upgrade to the latest beta version:
https://pqrs.org/osx/karabiner/document.html#check-for-updates

thanks, it's working for me now!

actually, I spoke too soon.
Using the following code now deactivates the 'normal' (os-built-in) left-click drag behaviour (e.g. drag window, etc.)
  <modifierdef>LEFTCLICK</modifierdef>
    <autogen>__KeyOverlaidModifier__
        PointingButton::LEFT, ModifierFlag::NONE,
        KeyCode::VK_MODIFIER_LEFTCLICK,
        PointingButton::LEFT,
    </autogen>
```
Is that expected behaviour? If yes, how can I get the custom modifier for left-click in addition to normal left mouse button behaviour?

That is expected. Please use this autogen.
    <autogen>
      __KeyToKey__
      PointingButton::LEFT, ModifierFlag::NONE,
      PointingButton::LEFT, ModifierFlag::LEFTCLICK,
    </autogen>

Great! all my questions have been answered; Karabiner is truly a marvel!


Retry marking CARRY4_VPR as whitebox

After talking to Eddie, I noticed that CARRY4_VPR was not marked as (* abc9_carry *), so I want to see if this stops ABC9 from sweeping the cells away.
cc @litghost @kgugala

CI failure on xc7 install looks like a kokoro infrastructure error, I'll re-run it in a bit.  xc7 CI was green, so that is good.


doesn't compile with TS 2.9

Works fine on 2.8.4 but on 2.9 tsc returns tons of errors.
Not sure if this project is still maintained?
Thanks!

Since many types don't work anymore, I'm going to release a 0.3 version containing the few that still work.
I'll add the other types one by one, when (if) I'll come up with a working implementation


Few Improvements

Added new example with ScrollView

Fixed issue with ScrollView, throw some exceptions.

👍

👍 LGTM


Cannot use serialport on RasPI 2 when run in sudo

SerialPort version: 4.0.1
NodeJS Version:  4.6.0, npm 2.15.9, Python 2.7.9
Operating System and Hardware: RasPi 2 with Raspbian Jessie (installed on 09/16)
Are you using Electron/Atom/NwJS?: no
(Run node -v && npm -v && python --version to get version numbers)
Summary of Problem
I have both local and global installations of serialport. Application works as expected when started under normal account, but when it is started with sudo (I need it to add raspi-io functionality into the app) it throws the following exception:
`
module.js:327
throw err;
^
Error: Cannot find module '/home/pi/pitron/T1.js'
at Function.Module._resolveFilename (module.js:325:15)
at Function.Module._load (module.js:276:25)
at Function.Module.runMain (module.js:441:10)
at startup (node.js:139:18)
at node.js:974:3
`
I am running T1.js without any arguments
Expected Behavior
app when started under sudo runs in the same way as without sudo
Actual Behavior
app when started under sudo throws exception
Steps and Code to Reproduce the Issue
code attached
T1.js.zip

The error message indicates that the file /home/pi/pitron/T1.js doesn't exist. Are you 100% sure that it's there? Check with ls /home/pi/pitron/T1.js. Note that this issue isn't related to serialport.

I apologize for the dummy issue, please disregard it. I found what was the
problem, and it is not serialport. I was mounting my desktop (Mac)
directory on RasPi 2 (via SSHFS) to have convenient editing experience. I
then sym-linked the file from mounted directory into working directory that
has node_modules (with serialport). I was able to run the application in
non-sudo mode by using that symlink, but it didn't work in sudo (I don't
know why).
Now I reversed the mounting scheme and keep the original JS file on Pi, and
mount project directory from Pi to desktop for editing. With that fix I can
run the app in both sudo and non-sudo mode.
On Mon, Oct 3, 2016 at 3:59 PM, Brian Cooke<EMAIL_ADDRESS>wrote:

The error message indicates that the file /home/pi/pitron/T1.js doesn't
exist. Are you 100% sure that it's there? Check with ls
/home/pi/pitron/T1.js. Note that this issue isn't related to serialport.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EmergingTechnologyAdvisors/node-serialport/issues/950#issuecomment-251209807,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJmNFVhBpZxikXilzlggZ1PPQU4v4cDks5qwV6lgaJpZM4KMFUC
.

--
Simon


⚠ Spryr has degraded performance

In 27d1ecb, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3669 ms

Resolved: Spryr performance has improved in 749f7e1 after 7 minutes.


Expand 80 char line to multi-line in Fossil Note to capture un-truncated items

@LeannePyle  - I thought we'd decided to leave it as a single line but to make the max length longer? (120 chars?) Or did that change?

Yes we can keep one line, but need to make the accepted length longer - can we do 150 char?


Tipi running but inaccessible`

I've tried this on 2 different devices now, both running Ubuntu LTS.
Steps to reproduce:

Run the curl | bash command to install tipi
"Tipi successfully Started, Visit localhost:80 to access the dashboard"
Go to address
"Unable to connect, Taking too long to respond"

Specs:
i9 cpu
3080 gpu
64GB RAM
It's not a low end system problem

Hello @IMJONEZZ we have fixed this bug in the latest version and everything should now work correctly


[9.x] Revert #41557

@nunomaduro Hey, sorry for the ping, but I was wondering if we could get some insight in why this was reverted? This seems to have been a popular feature and I find it odd that it was removed. See https://github.com/laravel/framework/discussions/41597


Patch: Fix up final failing spec in feature/authorization-simple

Notes

This should fix the CI error. I'll wrote more here about why, it's kind of interesting/unexpected. But bottom line it's a spec problem, not a feature-side problem.

Here's the feature-side method that was causing the error:
# student_section_assignments_importer.rb

def delete_rows
  #Delete all stale rows no longer included in the import
  #For the schools imported during this run of the importer
  StudentSectionAssignment.joins(:section => {:course => :school})
                          .where.not(id: @imported_assignments)
                          .where(:schools => {:local_id => school_scope}).delete_all
end

Here's what I imagine this code saying:
"Take all the section assignments. Filter down to the ones associated with the schools we're importing for. Filter out the assignments we imported during this job. Then delete all the ones we have left."
The last line is the one we want to look at. It assumes that school_scope is an array. But in the context of the spec we're looking at in student_section_assignments_import_spec.rb, school_scope is nil because it was never set. At the same time, all the schools generated by our factories also had local_ids of nil (because there was no sequence set up in FactoryGirl to generate them). Since both values default to nil, in the test context this happens to pass.
I think a better solution would be to have the test context assume an array-like school scope, like we have in the live, production importer classes. That would make the specs more precise and a better model of our app. We should do that work in a separate branch though so that we don't make it a blocker for this authorization refactor work, which is high priority.

Gonna merge this in because I'm excited, I wanna see if it'll fix the CI situation, the CI doesn't run unless the branch is against master, and I'm merging into another branch so it's not shipping to prod yet. 👍

selfie!


Update it.json

Suggested-by: fontana8 (Sauro)

Translations need to go through Transifex. Read more about it here: https://github.com/openstreetmap/iD/blob/master/CONTRIBUTING.md#translating

I'm sorry of being lazy! Now I properly submitted it... Closing


Add bug report/RFE templates

Signed-off-by: Kris Dockery<EMAIL_ADDRESS>

@krisdock these template updates look fine to me, would you mind rebasing again? Thanks!

@stevesloka I'm not sure that had the intended effect. Let me know if I need to just delete and redo.

That's fine @krisdock, but now you just need to sign that last commit. We can sqash those commits together on the merge.

@krisdock looks like the sign-off checker is still not happy, and also looks like this needs another rebase. Sorry :(

Redoing since I can't make the sign-off checker happy


Remove hardcoded reference to simulation years preventing simulations being ran with a start date after 2010

This PR edits two modules which have hard coded reference to years in the simulation prevent running of a simulation with a start date after a given year. Therefore running the simulation with a start date later that these years causes the model to crash. This is mainly relevant to attempts to use the model in a cohort mode.
@tdm32 have requested your review as its two of your modules. please let me know if you'd like me to change what i've got here.

@tbhallett are you happy for this PR to go in, sorry only just noticed @matt-graham's review


Support Respect/Validation v2

Fixes #102
Closes #103 (and based on these discussions)
Also completed ignoreErrors to phpstan.neon file since static analysis check is done with PHP 7.2 on GitHub CI.
This is the best thing we can do for the moment.
Adding a DataValidator (see discussion) does not help since we loose a lot of things (auto-completion, static checks,...).
Possibly not the cleanest, but it supports v1 AND v2.
Plus we need to check with class_exists and not method_exists. These methods (numericVal,...) do not really exist, but use magic functions (__call, __callStatic).
One day, we could possibly think about dropping Respect/Validation v1 support (last release more than one year ago, 2019-05-28). Respect/Validation v2.0 supports PHP^7.2, while v2.1 supports PHP^7.3.

Thanks @t0mmy742 !

Thanks @t0mmy742 !


libtorrent, rtorrent: fix updateScript eval

Without the change updater run fails as:
error: function 'anonymous lambda' called with unexpected argument 'tagPrefix'

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks @trofi

Thanks @trofi for the fix!


Don't try to close related PRs when deleting a non-fork repository

Fix #14775

Hmm actually thinking on...
What do you mean you received lots of emails?
What kind of emails?
Are you fixing this at the right level?

I think #14823 is more likely to be the correct thing.

#14823 got merged ...


Adding support to ingest Map and MapValueTransform Factory

Codecov Report

Merging #27 into develop will decrease coverage by 19.51%.
The diff coverage is 68.47%.

@@              Coverage Diff               @@
##             develop      #27       +/-   ##
==============================================
- Coverage      65.14%   45.62%   -19.52%
==============================================
  Files           1049     1050        +1
  Lines          54420    54505       +85
  Branches        7761     7778       +17
==============================================
- Hits           35453    24870    -10583
- Misses         16403    27407    +11004
+ Partials        2564     2228      -336

Impacted Files
Coverage Δ
Complexity Δ

...segment/creator/impl/SegmentDictionaryCreator.java
73.46% <ø> (-14.37%)
0 <0> (ø)

...e/pinot/core/query/reduce/BrokerReduceService.java
79.92% <100%> (+0.48%)
0 <0> (ø)
:arrow_down:

...t/core/query/selection/SelectionOperatorUtils.java
69.28% <100%> (-23.73%)
0 <0> (ø)

...r/transform/function/TransformFunctionFactory.java
55.1% <100%> (-5.32%)
0 <0> (ø)

...time/impl/kafka/AvroRecordToPinotRowGenerator.java
40% <4%> (-60%)
0 <0> (ø)

.../transform/function/MapValueTransformFunction.java
86.95% <86.95%> (ø)
0 <0> (?)

...ain/java/org/apache/pinot/core/util/AvroUtils.java
48.27% <92%> (-4.62%)
0 <0> (ø)

...inot/core/data/readers/GenericRowRecordReader.java
0% <0%> (-100%)
0% <0%> (ø)

.../org/apache/pinot/common/http/MultiGetRequest.java
0% <0%> (-100%)
0% <0%> (ø)

...che/pinot/common/restlet/resources/TablesList.java
0% <0%> (-100%)
0% <0%> (ø)

... and 533 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30fe389...d4671f8. Read the comment docs.


Windows Jetty HTTP ERROR 404 /idp/Authn/ExtCas

Hello, I followed everything on README but when navigating to /idp/Authn/ExtCas
It shows:
HTTP ERROR 404

Problem accessing /idp/Authn/ExtCas. Reason:

    Not Found
Powered by Jetty:// 9.3.9.v20160517

idp.properties:
# Regular expression matching login flows to enable, e.g. IPAddress|Password
idp.authn.flows= Shibcas

# CAS Client properties (usage loosely matches that of the Java CAS Client)
## CAS Server Properties
shibcas.casServerUrlPrefix = https://idp.nxtstp.com:8443/cas
shibcas.casServerLoginUrl = https://idp.nxtstp.com:8443/cas/login

## Shibboleth Server Properties
shibcas.serverName = https://idp.nxtstp.com:1443/idp

Check the web.xml changes. You may need those.

On Apr 27, 2017, at 1:55 PM, Ricky Han<EMAIL_ADDRESS>wrote:
Hello, I followed everything on README but when navigating to /idp/Authn/ExtCas
It shows:
HTTP ERROR 404
Problem accessing /idp/Authn/ExtCas. Reason:
Not Found

Powered by Jetty:// 9.3.9.v20160517
idp.properties:
Regular expression matching login flows to enable, e.g. IPAddress|Password
idp.authn.flows= Shibcas
CAS Client properties (usage loosely matches that of the Java CAS Client)
CAS Server Properties
shibcas.casServerUrlPrefix = https://idp.nxtstp.com:8443/cas
shibcas.casServerLoginUrl = https://idp.nxtstp.com:8443/cas/login
Shibboleth Server Properties
shibcas.serverName = https://idp.nxtstp.com:1443/idp
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
This email has been scanned for spam and viruses by Proofpoint Essentials. Click here to report this email as spam.


output on v-model tag the name base on id

I have an existing tags where in the object looks like this the 2,3,4 value is their respective ID's that needed to be send on backend
autoComplete:Object
    2:"Owen Bins"
    3:"test"
    4:"dsfsdf"

from that i can easily pick a name and output on the users array the ID (2,3,4) and put a result on input tag base on the value of the object (Owen Bins, test, dsfsdf)
However, when i fetch from the backend how can I bind from v-model if the data looks like this
users:Array[3]
    0:Object
        id:4
        name:"dsfsdf"
    1:Object
        id:3
        name:"test"
    2:Object
        id:2
        name:"Owen Bins"

Where in the 4 ,3 and 2 is the ID of the user at the same time i want the result of the name on the input tag

You could add a computed property based on the v-model value. Loop through the v-model value and compile a new array in the required format.


Squared ISWAP fails trace distance bound test

In [1]: import cirq

In [2]: cirq.testing.consistent_protocols.assert_has_consistent_trace_distance_bound(cirq.ISWAP**2)
---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
<ipython-input-2-9d7942dfa2d6> in <module>
----> 1 cirq.testing.consistent_protocols.assert_has_consistent_trace_distance_bound(cirq.ISWAP**2)

~/src/Cirq/cirq/testing/consistent_protocols.py in assert_has_consistent_trace_distance_bound(val)
    109
    110         assert val_from_trace >= val_from_unitary or np.isclose(
--> 111             val_from_trace, val_from_unitary)
    112
    113

AssertionError:

In [3]: cirq.trace_distance_bound(cirq.ISWAP**2)
Out[3]: 1.2246467991473532e-16

I guess we really care about this near identity, but still the protocol explicitly says "Underestimates are not permitted.", so we should fix it in case it's relied on in future.
Other exponents in [1.0029..2.9971] also fail the check.

In error I added a special case that doesn't apply to ISWAP gate. If the _trace_distance_bound_ method of the ISwapPowGate class is removed then the EigenGate version will be used instead which should return accurate results.


Incorrect filter config

Sorry about the screenshot but can't copy the text in my browser.
I followed the instructions to get started with lovelace and I received the same error regarding incorrect filter config. I copied some of the other samples posted here and no matter what I do the filter card will not work. Currently on Hassbian with 0.73b4
All the other cards working fine except for filter.

check the latest docs. filter was reworked

Was able to get that to work but having issues with camera preview now. Do you have a link to the latest docs?


Request: set HTTP statusCode with EJS

Hi @smollweide,
Thank you for maintaining this package!
I have following succes.json:
<%
	var data = {};
	switch (query.Name) {
		case 'noresults':
		    data = response['error-204'];
		    break;
		default:
		    data = response['success_default'];
		    break;
}%>

<%-JSON.stringify(data);%>

Here I would like when Name = noresults, it returns a 204 HTTP status code. But it seems (since this logic is applied from the success.json) always returning a statusCode 200.
When calling the file error-204 directly with response.txt it does show correct statusCode, but this makes it no longer dynamic (input based).
Is there another way node-mock-server supports my use case?

Hi @BuruY,
thank you for creating this issue.
For more complex scenarios like this one you should use the middleware.
Best,
Simon

Thanks for the lightning fast response.
I have following code as middleware:
    middleware: {
        '/rest/xxx/#xxx/GET/mock'(serverOptions, requestOptions) {
            var name = requestOptions.req.query.Name;
            console.log('TEST' + name);

            if (name === 'noresults') {
                requestOptions.res.statusCode = 204;
                return null;
            }

            return 'success';
        }
    }

I do not seem to do it right, I have found no query examples in pointed documentation.
Perhaps you can point me towards correct direction?
Thanks!

Got it to work, documentation is not clear on this one but you need to have a response.txt that states: middleware


Fix TimestampServiceBinder/TimestampBinder text

There's references in a few places to a TimestampServiceBinder which doesn't exist (it's just TimestampBinder). I've just changed the text to use TimestampBinder everywhere (smaller change).

Thanks for the PR!


[Fix] sap.m.BlockLayoutCellRenderer: tag names must be lower case

RM.openStart expects tag names to be lower-case
similar to https://github.com/SAP/openui5/commit/cc23bb01d249e49d585e8661f3164bffa4e956d8

Hello @kagawa23 ,
Thank you for your pull request. I've created an internal record<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.

"Thanks! The pull request has been merged into the openui5 repository. And will be in the 1.99 version"


Fixes resources under SPM

Accessing resources under SPM works differently than in frameworks and app bundles. When using KPCTabsControl via SwiftPM the code crashes whenever a resource is being loaded (because the code assumes the resource files will be always present):

This PR features the following changes:

updates Package.swift to include package resource files
adds a symlink to the Resources folder to satisfy SPM's requirement that the resources are found under the target path
adds a Swift flag when compiled as a package
uses Bundle.module conditionally when compiled as a package

Thanks for the PR! Making an official CocoaPods release will take more time however (for those who use CocoaPods in the room), since I just migrated to a new machine at home.  But this is not needed for the people involved here, I guess.

Thank you for taking a look so quickly!
Yeah, Cocoapods is not affected, only SwiftPM users need to pick master until there's a semantic version tag.
I can set up a tag with a new patch release, 4.0.1, but I don't have CocoaPods trunk access for this repo. You can add me at  me at christiantietze.de if that's simpler than getting your machine up to speed.

Thanks for the proposition, that would be very helpful for me. I let you know when it is done.

@DivineDominion I've added you as an owner of KPCTabsControl! (I've done the same for SwiftAA but it's a mistake.)

Note, you are already a registered collaborator of this repo. Doesn't it allow you to merge PRs?

@onekiloparsec It does! But I don't want to merge willy-nilly into your repo without talking to you about changes by default. (Also, another pair of eyes, if you can spare it, is super valuable :))


Add license

Hi there! Can you clarify the licensing of this project, possibly by adding a LICENSE file in the repository? Without it, nobody can use it or contribute to it.
For reference: https://choosealicense.com/no-permission/

When you make a creative work (which includes code), the work is under exclusive copyright by default. Unless you include a license that specifies otherwise, nobody else can copy, distribute, or modify your work without being at risk of take-downs, shake-downs, or litigation. Once the work has other contributors (each a copyright holder), “nobody” starts including you.

Hi! Thanks for pointing that out. Done.


Fixes for new glibc

This should fix at least one build problem with 6.2.x

[approve ci ubuntu]

[approve ci centos]


How to style .item-media correctly

Hey, I try to reduce the gap between the icon and the text in a list with scoped CSS. For the icon, it works well, but not for the .item-media.
I can change the background color when I remove scoped - with scoped, it doesn't work as well, but anyway, the gap I cannot close :-(
<template>
  <f7-popover>
    <f7-list>
      <f7-list-item title="Homepage">

<f7-icon material="add_box" />

      </f7-list-item>
    </f7-list>
  </f7-popover>
</template>

Check in inspector, you probably need more strict rule like .md .list .item-media {...


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/866 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target.git

Docs Build status updates of commit 63aecd7:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_master_2021-06-02-05-15-07 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


RequestPermissionsAsync returns Denied directly if users denied the first time

Hi, by my tests, if a user denied RequestPermissionsAsync at the first time, after that, it will always directly return Denied, won't show requests again.
Only if I reinstalled APP, RequestPermissionsAsync will show requests again.
Am I right? If so, I don't think that's a good idea because users may change their mind after knowing why we need those permissions.

@hs79hs as far as I know on Operating system will not display that permission request prompt if user decides to Deny (iOS Deny, Android deny and user selects don't show this prompt again). In that case we know that user denied the permission and take them to app settings to re-enable (iOS Ask Next Time, Android allow). This has been the same behavior at least for two years, since we started using this plugin for location and other native permissions. I don't think it is an issue with this plugin, it is the operating system functionality. Hope this helps.

You only have 1 chance with iOS and then it will never open again. That is how iOS works :(


Ingress broken - creates new empty Instance-Group

When I started implementing the Ingress resource in our infrastructure provisioning (2016-05-09) the ingress worked like a charm. Rolling this out to our staging cluster failed yesterday. The ingress successfully creates the L7 HTTP LoadBalancer, creates all entities, but the backend-service did not have any instances configured. Turns out that the Ingress creates a new Instance Group called k8s-ig, which has no instances associated with it (0) where there should be 4 in our case.
Btw.: The health-check path has changed since then from / to /healthz, why is that, and how is it possible to reconfigure it?
Tested on gke against cluster version 1.2.1 and 1.2.4.
The Ingress resource:
{
    "apiVersion": "extensions/v1beta1",
    "kind": "Ingress",
    "metadata": {
        "name": "de-01",
        "labels": {
            "profile": "staging"
        }
    },
    "spec": {
        "tls": [
            {
                "secretName": "staging-de-01"
            }
        ],
        "backend": {
            "serviceName": "nginx",
            "servicePort": 80
        }
    }
}

Image of the empty instance-group, should have 4 nodes (gke-staging-default-506a85c4-group):

Background: We are using K8s since a year, created the L7 LB entities all by ourself previously. We switched to the Network-LB (which works great), but the Network-LB is unable to provide the client-ip, so we have to switch back to the L7 and the Ingress seems like a good opportunity.

Can you run kubectl describe ing, or kubectl logs --namespace=kube-system l7-controller-name ?
There was a GCE schema change that required the new instance group. If you're running multiple kube clusters in the same project, with image versions < 0.6.1 you need to allocate a cluster uid of your own: https://github.com/kubernetes/contrib/blob/master/ingress/controllers/gce/BETA_LIMITATIONS.md#running-multiple-loadbalanced-clusters-in-the-same-gce-project, there's a chance it's not able to add instances to the ig because of this.
The global-to-project uid is auotmatically allocated in 0.6.3

Btw.: The health-check path has changed since then from / to /healthz, why is that, and how is it possible to reconfigure it?

/healthz is only for the default backend. All of your services should still be /
you can configure it by going to compute>healthchecks in the pantheon console.
With the next version (gcr.io/google_containers/glbc:0.7.0) it will scrape the health check url from the readiness probe on your pod endpoints.

Hi Prashanth,
thanks for getting back on me, output follows shortly after creation):
$ kubectl describe ing
Name:			de-01
Namespace:		default
Address:		xxx.xxx.xxx.xxx
Default backend:	nginx:80 (<IP_ADDRESS>:80)
TLS:
  staging-de-01 terminates
Rules:
  Host	Path	Backends
  ----	----	--------
Annotations:
  target-proxy:			k8s-tp-default-de-01
  url-map:			k8s-um-default-de-01
  backends:			{"k8s-be-30237":"Unknown"}
  forwarding-rule:		k8s-fw-default-de-01
  https-forwarding-rule:	k8s-fws-default-de-01
  https-target-proxy:		k8s-tps-default-de-01
  static-ip:			k8s-fw-default-de-01
Events:
  FirstSeen	LastSeen	Count	From				SubobjectPath	Type		Reason	Message
  ---------	--------	-----	----				-------------	--------	------	-------
  2m		2m		1	{loadbalancer-controller }			Normal		ADD	default/de-01
  1m		1m		1	{loadbalancer-controller }			Normal		CREATE	ip: xxx.xxx.xxx.xxx (same as above)

Of course the backend will never become healthy, since there are no nodes to query.
Actually we only have one cluster in our GCE project. Originated in the limitations in the backend-services (3), we decided to put each cluster into an own project. Nowadays you can have up to 30 backend-services, so it should be supported in a release-version of the L7 ingress (the limitations-docu should be updated).
Seems like I have an older version:
l7-lb-controller-v0.6.0-srt50                                  2/2       Running   0          4d

can you give me the output of kubectl logs on the l7-lb-controller? (something like: kubectl --namespace=kube-system logs l7-lb-controller-v0.6.0-srt50  -c l7-lb-controller --tail=100 --follow)

Also, you could always request upto 30 backends but the default is 3, which is what trips people up often (unless something changed recently).

Sure, I deleted the Ingress, and created a fresh one, here is the output:
$ kubectl --namespace=kube-system logs l7-lb-controller-v0.6.0-srt50 -c l7-lb-controller --tail=100 --follow
I0606 07:33:17.480173       1 utils.go:285] Could not find nodeport for backend {ServiceName:nginx ServicePort:{Type:0 IntVal:80 StrVal:}}: Could not find matching nodeport from service.
I0606 07:33:17.480221       1 event.go:211] Event(api.ObjectReference{Kind:"Ingress", Namespace:"default", Name:"de-01", UID:"ef937e3b-2bb8-11e6-94dc-42010af00015", 	APIVersion:"extensions", ResourceVersion:"3364122", FieldPath:""}): type: 'Normal' reason: 'ADD' default/de-01
I0606 07:33:17.705281       1 instances.go:56] Creating instance group k8s-ig
I0606 07:33:22.024072       1 gce.go:1654] Adding port 30237 to instance group k8s-ig with 0 ports
I0606 07:33:22.901913       1 backends.go:116] Creating backend for instance group k8s-ig port 30237 named port &{port30237 30237 []}
I0606 07:33:23.097484       1 healthchecks.go:49] Creating health check k8s-be-30237
I0606 07:33:31.507746       1 loadbalancers.go:128] Creating l7 default-de-01
I0606 07:33:32.283780       1 loadbalancers.go:288] Creating url map k8s-um-default-de-01 for backend k8s-be-30237
I0606 07:33:36.436093       1 loadbalancers.go:304] Creating new http proxy for urlmap k8s-um-default-de-01
I0606 07:33:40.586043       1 loadbalancers.go:397] Creating forwarding rule for proxy [k8s-tp-default-de-01] and ip :80-80
I0606 07:33:44.735414       1 loadbalancers.go:458] Creating static ip k8s-fw-default-de-01
I0606 07:33:48.917516       1 loadbalancers.go:330] Creating new sslCertificates default-de-01 for k8s-ssl-default-de-01
I0606 07:33:53.003353       1 loadbalancers.go:355] Creating new https proxy for urlmap k8s-um-default-de-01
I0606 07:33:57.436092       1 loadbalancers.go:397] Creating forwarding rule for proxy [k8s-tps-default-de-01] and ip xxx.xxx.xxx.xxx:443-443
I0606 07:34:06.379097       1 controller.go:325] Updating loadbalancer default/de-01 with IP xxx.xxx.xxx.xxx
I0606 07:34:06.382901       1 event.go:211] Event(api.ObjectReference{Kind:"Ingress", Namespace:"default", Name:"de-01", UID:"ef937e3b-2bb8-11e6-94dc-42010af00015", APIVersion:"extensions", ResourceVersion:"3364122", FieldPath:""}): type: 'Normal' reason: 'CREATE' ip: xxx.xxx.xxx.xxx
I0606 07:34:06.771371       1 backends.go:212] Deleting instance group k8s-ig
E0606 07:34:07.111357       1 utils.go:92] Requeuing default/de-01, err googleapi: Error 400: The instance_group resource 'k8s-ig' is already being used by 'k8s-be-30237', resourceInUseByAnotherResource
I0606 07:34:07.111408       1 utils.go:285] Could not find nodeport for backend {ServiceName:nginx ServicePort:{Type:0 IntVal:80 StrVal:}}: Could not find matching nodeport from service.
I0606 07:34:13.158152       1 backends.go:212] Deleting instance group k8s-ig
E0606 07:34:13.504396       1 utils.go:92] Requeuing default/de-01, err googleapi: Error 400: The instance_group resource 'k8s-ig' is already being used by 'k8s-be-30237', resourceInUseByAnotherResource
I0606 07:34:13.504445       1 utils.go:285] Could not find nodeport for backend {ServiceName:nginx ServicePort:{Type:0 IntVal:80 StrVal:}}: Could not find matching nodeport from service.
I0606 07:34:19.561356       1 backends.go:212] Deleting instance group k8s-ig
E0606 07:34:19.920335       1 utils.go:92] Requeuing default/de-01, err googleapi: Error 400: The instance_group resource 'k8s-ig' is already being used by 'k8s-be-30237', resourceInUseByAnotherResource
I0606 07:34:19.920441       1 utils.go:285] Could not find nodeport for backend {ServiceName:nginx ServicePort:{Type:0 IntVal:80 StrVal:}}: Could not find matching nodeport from service.
I0606 07:34:26.179462       1 backends.go:212] Deleting instance group k8s-ig
E0606 07:34:26.524984       1 utils.go:92] Requeuing default/de-01, err googleapi: Error 400: The instance_group resource 'k8s-ig' is already being used by 'k8s-be-30237', resourceInUseByAnotherResource
I0606 07:34:26.525029       1 utils.go:285] Could not find nodeport for backend {ServiceName:nginx ServicePort:{Type:0 IntVal:80 StrVal:}}: Could not find matching nodeport from service.
I0606 07:34:32.843356       1 backends.go:212] Deleting instance group k8s-ig
E0606 07:34:33.171923       1 utils.go:92] Requeuing default/de-01, err googleapi: Error 400: The instance_group resource 'k8s-ig' is already being used by 'k8s-be-30237', resourceInUseByAnotherResource
I0606 07:34:33.171994       1 utils.go:285] Could not find nodeport for backend {ServiceName:nginx ServicePort:{Type:0 IntVal:80 StrVal:}}: Could not find matching nodeport from service.
... And so on

The nginx service:
$ kubectl describe svc nginx
Name:			nginx
Namespace:		default
Labels:			application=nginx,profile=staging,ts=1464778920
Selector:		application=nginx,profile=staging
Type:			ClusterIP
IP:			<IP_ADDRESS>
Port:			http	80/TCP
Endpoints:		<IP_ADDRESS>:80
Port:			healthcheck	8081/TCP
Endpoints:		<IP_ADDRESS>:8081
Session Affinity:	None
No events.

As I mentioned in the initial question, it did previously worked in our development-cluster. Here is the output of the echoheaders service, we used to test. Obviously it has created some nodeport:
$ kubectl describe svc echoheaders
Name:			echoheaders
Namespace:		default
Labels:			run=echoheaders
Selector:		run=echoheaders
Type:			NodePort
IP:			<IP_ADDRESS>
Port:			<unset>	8080/TCP
NodePort:		<unset>	31625/TCP
Endpoints:		<IP_ADDRESS>:8080
Session Affinity:	None
No events.

You need a nodeport for ingress, guessing 30237 is the nodeport of the default backend, so it's doing as expected for the most part. If you delete the ingress it will delete the default backend and then be able to free up the associated ig. It's currently confused because the ingress requires a default backend, but the ingress has no node ports.
Can you just kubectl edit the service and changet type:ClusterIP to NodePort?

Yes, I added a dummy NodePort (32000) to the  service, and exactly that one will be used by the L7, which works as expected. From the previous observations and the behavior of the Ingress I expected that the NodePort is automatically added to the service -- which is not the case.
We added a separate NodePort for the health-check, but it wasn't taken into account, so we use now only one port (32000) and switch inside nginx using the http_x_forwarded_for header.
So the answer to the problem was, that the service must be of type NodePort with a dummy-port.
Thank you Prashanth

Yeah the ingress won't mutate your service, because nodeport is only a requirement for GCE and AWS. An nginx ingress for example goes straight to endpoints.

We added a separate NodePort for the health-check, but it wasn't taken into account, so we use now only one port (32000) and switch inside nginx using the http_x_forwarded_for header.

You can also switch on the UA with something like:
events {}
http {
  server {
    listen 80;
    location / {
      if ($http_user_agent ~ (GoogleHC/1.0) ) {
        return 200;
      }
      return 404;
    }
  }
}

0.7.0 will adopt the url of the readiness probe on your endpoints as the health check url, but the port will still be the same.

Good to know, unfortunatly Google uses different UAs like "GoogleHC/1.0" and "Go 1.1 package http" coming from the HCs, so we will continue with the other approach for now.

Ok, the "Go 1.1 package http" comes from the k8s liveness probe. Nevermind :)

+1, the NodePort update helped ended my 4-day struggle finding out why the loadbalancer won't forward requests to my backend instance properly.
this should be highlighted for kubernetes, it's not really well documented, and people who come from tutorials will miss this point.

@karolyi @galan

+1, the NodePort update helped ended my 4-day struggle finding out why the loadbalancer won't forward requests to my backend instance properly.

Can either of you please specify the update taken to get this working? I too am having issues making sure my LB is properly routing to my backend svc and I'm hitting a wall. I specify a NodePort is in my svc, and am manually setting a backend to my gke cluster instancegroup rather than the new one, empty one created, but neither of those solutions are working.
Thanks.

For anyone who was running into this issue, it ultimately ended up being a slew of misconfigurations of the service & ingress on my end, plus my lack of knowledge on how the GLBC operated compared to running my own nginx Ingress Controller.
Ultimately, following https://github.com/kubernetes/contrib/tree/master/ingress/controllers/gce#tls helped me to get past this issue, and achieve my goal of enabling HTTPS ingress, as well forcing the redirection of HTTP -> HTTPS (note: this requires a separate nginx service to serve as the backend for the GLBC + Ingress configuration).

After converting my service to nodeport, I had no success: my backend was recognized but marked as UNHEALTHY. The problem was that my service was responding 404 while getting root path (/) and the ingress was replying me with an error. Adding a dummy router that responds "OK" when GET / fixed the issue. In my opinion, heath check needs should be better documented.


i386: Parity Flag not modeled for some instructions

Describe the bug
Output contains a magic in_PF but doesn't define it.
To Reproduce
Steps to reproduce the behavior:

decompile https://github.com/rfalke/decompiler-subjects/blob/master/from_holdec/stress_int_ia32/ia32_elf_base_inst__1_var__no_complex/subject.exe
Output is:

undefined8 inst_0_flags_var_0(void)

{
  undefined4 in_EDX;
  int iVar1;
  bool in_PF;

  iVar1 = 0;
  if (in_PF) {
    iVar1 = 4;
  }
  return CONCAT44(in_EDX,iVar1 + -4);
}

The adc instruction sets it in this case. There are more cases for other instructions. Search in https://github.com/rfalke/decompiler-subjects/blob/master/from_holdec/stress_int_ia32/ia32_elf_base_inst__1_var__no_complex/by_ghidra.c for "in_PF".
Expected behavior
Output should be:
int32_t inst_0_flags_var_0(void)

{
  return 0;
}

Environment (please complete the following information):

OS: Linux
Java Version: openjdk version "11.0.5" 2019-10-15
Ghidra Version: 9.1.2_PUBLIC

Additional context

Background: http://kronotai.com/wordpress/339/testing-decompiler-semantics/

This has been fixed in 9.2.

As far as I see 9.2 isn't released yet?!

Anything in the master branch will end up in 9.2 when it gets released.  So we usually just call the current master branch 9.2 (technically it's 9.2-DEV).

So far I haven't tried compiling ghidra myself since it is unknown how much effort it required. I will try when I have some time.
Are there any release plans for 9.2?

So far I haven't tried compiling ghidra myself since it is unknown how much effort it required. I will try when I have some time.
Are there any release plans for 9.2?

You can get a pre-built one here if you'd like.

This is no longer an issue in ghidra_10.3.2_PUBLIC.


Empty statements should be removed

This pull request is focused on resolving occurrences of Sonar rule squid:EmptyStatementUsageCheck - Empty statements should be removed
You can find more information about the issue here:
https://dev.eclipse.org/sonar/coding_rules#q=squid:EmptyStatementUsageCheck
Please let me know if you have any questions.
Kirill Vlasov

such rules should be encoded into tool like 'checkstyle'; not fixed case by case.

:+1:


Do metrics work in 0.8.1?

The documentation seems outdated and the code doesn't seem to provide any obvious way to report metrics once you've spun up a MetricSystem. The most I can get to function is
val reporter = MetricReporter(
  MetricReporterConfig(Seq(LoggerSender)),
  system.actorOf(Props(classOf[IntervalAggregator], 5 seconds, Agent(MetricMap.Empty), Some(metricSystem / "sys"))),
  "Stufff"
)

And those report fine, but using anything else or trying to create my own custom Metrics don't seem to work at all.

Ah thanks for point that out.  The section in the docs on reporting was indeed out of date.  I've updated them to reflect the latest release and it should make it more clear what to do.  I also realize there's no published scaladocs for the metrics library and I'm working to fix that.
Basically you don't actually need to create your own reporter or manually spin up any actors, just call the .report method on an existing CollectionInterval of a  MetricSystem, and then all metrics created under that system will get reported according to the frequency of that interval.
Let me know if you get it working or if you get stuck on something.

Hey Dan, that works fine, it just did not seem like the collectionIntervals was meant to be messed with, but is there a way to add intervals to this map? I assume it's done via the config, but can it be done in code?

Ah yeah that's a good point, and I agree it doesn't look intuitive.
You can specify collection intervals either through overriding the defaults in your application.conf (see the reference.conf), or by passing in a MetricSystemConfig object to the MetricSystem when you create it.    So in both cases they need to be set when the system is created.


create the repo through the github api

https://octokit.github.io/rest.js/#api-Repos-create

Issue moved to travi/github-scaffolder #1 via ZenHub


fix for playing dtmf tones

This PR replaces PR #25
I've used a Future and chained futures to help with the queuing of DTMF tones.

LGTM


Stop using any

What version of Hono are you using?
4.5.6
What runtime/platform is your app running on?
any
What steps can reproduce the bug?

Open the Hono source code
You will see

any
/* eslint-disable @typescript-eslint/no-explicit-any */
// eslint-disable-next-line @typescript-eslint/no-explicit-any

Ignoring any error 125 times!?
What is the expected behavior?
any should be excluded from all codes.
Use other safe types or unknown instead.

Some of them are used by necessity due to typescript limitations, but you are right.

Hi @akku1139
Of course it is better not to use any, but inside libraries, especially having complex type declarations, we have to use any for the implementation. For instance, you can see a lot of anys in the source code of Zod. More details will be explained later.


Dataloader should use MapSet for the ids

It seems like if we make multiple duplicate loads, dataloader constructs a SQL query with multiple IDs.
For example, we construct a loader like this:
loader = loader
|> Dataloader.load(:nest_db, NestDB.BuyerOffer, 290)
|> Dataloader.load(:nest_db, NestDB.BuyerOffer, 290)
|> Dataloader.load(:nest_db, NestDB.BuyerOffer, 290)

Now we get a struct like so:
%Dataloader{
  options: [],
  sources: %{
    nest_db: %Dataloader.Ecto{
      batches: %{
        {:queryable, #PID<0.1196.0>, NestDB.BuyerOffer, %{}} => [
          {290, 290},
          {290, 290},
          {290, 290}
        ]
      },
      default_params: %{},
      options: [],
      query: #Function<0.77438868/2 in Eggl.Loader.dataloader/0>,
      repo: NestDB.Repo,
      repo_opts: [],
      results: %{}
    }
  }
}

Which results in a query that looks like this:
...
WHERE (b0."id" = ANY($1)) [[290, 290, 290, 290]]

Could we use a Mapset to remove this duplication?

I believe this is already added in these PR's:

Dataloader.KV - https://github.com/absinthe-graphql/dataloader/pull/23
Dataloader.Ecto - https://github.com/absinthe-graphql/dataloader/pull/20

Bosh! Love it.

Handled via previous PRs.


Record failures in published channels?

Let's say someone's on a channel like nixos-unstable. They ask to build a package and it's not cached because Hydra tried to build it and failed. The user will also try to build the package, and the build will almost certainly fail again for the user, giving a poor experience.
A better user experience would be a way to record (or look up) that Hydra tried to build the thing but failed. Depending on the solution, this ticket might belong more in Nix than Nixpkgs, but I'm leaving it here for now as there are more eyeballs on it.

One approach might be to set up on-the-fly meta.broken overlays somehow, so that meta.broken gets merged with some JSON file produced by Hydra describing whether builds succeed or not. Or meta.platforms since that would account for different platforms succeeding or failing.


FPGA BLAS: GEMV tiles streamed by row

Adds FPGA GEMV implementation for streaming tiles in by row and within tiles by row (tiles, withinTiles)->(row, row). Status:

Works for Xilinx

Should in theory also work for Intel, but there seems to be a bug in the codegen, where instead of a float* only a float is passed in a function declaration and thus leads to compilation errors when trying to dereference.

Side change, adjusted transformation.pys base function expansion to contain all three arguments.

GEMV row-streamed, row-ordered now also supports array-based inputs.


Maintainer needed

I don't have the time to maintain this anymore. Luckily it's very stable, so it won't be deprecated or anything like that. However, there are some minor issues that could use fixing and there might be more in the future when Grunt 1.0 is released. This plugin is used by a lot of grunt projects (443,282 downloads in the last month), so it would be nice if someone stepped up. Happy to add multiple people.

Hi,
I'll be glad when I can maintain this repository.
This may be my first 'not mine' repository which I maintain.
Thx.

Hi,
I have used this for multiple projects of mine and would love to happy out if you are looking for a maintainer.
Thanks,

Thanks for offering @slinto @adrianlee44 ❤ Added you both.
If you need a place to start, maybe triage some issues.

Closing as this project is deprecated because Grunt is no longer actively maintained, so it doesn't make sense for me to maintain this project either.


fix: use codegen hash to calculate chunk hashes & fix runtime chunk hash

Summary

use module codegen cache as workaround

Related issue (if exists)

Types of changes

[ ] Docs change / Dependency upgrade
[ ] Bug fix
[ ] New feature / Improvement
[ ] Refactoring
[ ] Breaking change

Checklist

[ ] I have added changeset via pnpm run changeset.
[ ] I have added tests to cover my changes.

https://github.com/webpack/webpack/pull/11339 use statscase can improve test case, but we don't port the whole statscase features...


test: synchronizing bdd specs

Codecov Report

Merging #1120 into master will increase coverage by 5.48%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1120      +/-   ##
============================================
+ Coverage     60.04%   65.52%   +5.48%
- Complexity       87     2773    +2686
============================================
  Files           327      275      -52
  Lines         14806    13189    -1617
  Branches       2071     1819     -252
============================================
- Hits           8890     8642     -248
+ Misses         5318     3969    -1349
+ Partials        598      578      -20

Impacted Files
Coverage Δ
Complexity Δ

...tracing/impl/OpenTracingBridgeInstrumentation.java

...ic/apm/opentracing/ExternalProcessSpanContext.java

.../agent/hibernate/search/HibernateSearchHelper.java

...afka/ConsumerRecordsRecordListInstrumentation.java

...elastic/apm/agent/grpc/ChannelInstrumentation.java

.../agent/grpc/ServerCallListenerInstrumentation.java

...t/v5_6/ElasticsearchClientSyncInstrumentation.java

.../elastic/apm/agent/grpc/helper/GrpcHelperImpl.java

...agent/opentracing/impl/ApmSpanInstrumentation.java

...acing/impl/ExternalSpanContextInstrumentation.java

... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef369a1...5311b37. Read the comment docs.

Closing, wrong committer


Unable to add new line at the end of the test case name being printed during execution

I have been facing a scenario in which I want to be able to have clean logs in the console, each of which filling its own line. During a test execution, I notice that the Robot Framework prints the test case name when it is going to execute that particular test but it looks like a new line is not being appended after it. This results in any logs being printed right after the test case name also occupying the same line. Would it be possible to print the test case name and append a new line at the end?

The default console output certainly could be enhanced, but I don't think just adding a newline after the test name is a good idea because it makes output a lot longer. Good news is that you can disable the output with --quiet and create a custom output using a listener.


[question] GPU visibility inside the pod does not take effect

Create a POD to apply for GPU, enter the container through kubectl exec, execute nvidia-smi, I can see all GPU (4) device information,。
I should only see one GPU device that has been assigned to this Pod
The GPU visibility is not limited, the reason should be the container internal environment variable env: NVIDIA_VISIBLE_DEVICE=ALL, it should be NVIDIA_VISIBLE_DEVICE=GPU#UUID. How do I solve this problem？
MY Environment:

Koordinator version: 1.5.0
Kubernetes version (use kubectl version): v1.26
containerd :1.7.20
OS: Ubuntu 22.04.4 LTS
GPU：One GPU servder with P40*4
-Linux k8s-node1 6.5.0-41-generic
proxytime: 1.4.0

@ferris-cx It seems to be a problem where the runtime proxy or the device scheduling does not work well.
Please show us the pod YAML when it requests koordinator.sh/gpu-core and gets scheduled at a node for more clues.

@ferris-cx As discussed offline, please describe your use cases for RDMAs and GPUs under #2181 if you have further device management needs.

The problem has been resolved because the feature (GPUEnvInject) is not enabled, i.e.
kc get pod koordlet-2mttc-n koordinator-system-oyaml, which is as follows:
containers:

args:
-addr=:9316
-cgroup-root-dir=/host-cgroup/
-feature-gates=BECPUEvict=true,BEMemoryEvict=true,CgroupReconcile=true,Accelerators=true,GPUEnvInject=true
-runtime-hooks-host-endpoint=/var/run/koordlet/koordlet.sock
--logtostderr=true
--v=5
====================
The GPUEnvInject=true parameter is disabled by default. I just added it manually, and the problem is fixed.

@saintube The problem has been resolved because the feature (GPUEnvInject) is not enabled, i.e.
kc get pod koordlet-2mttc-n koordinator-system-oyaml, which is as follows:
containers:

args:
-addr=:9316
-cgroup-root-dir=/host-cgroup/
-feature-gates=BECPUEvict=true,BEMemoryEvict=true,CgroupReconcile=true,Accelerators=true,GPUEnvInject=true
-runtime-hooks-host-endpoint=/var/run/koordlet/koordlet.sock
--logtostderr=true

--v=5
The GPUEnvInject=true parameter is disabled by default. I just added it manually, and the problem is fixed.

OK.

@saintube The problem has been resolved because the feature (GPUEnvInject) is not enabled, i.e.
kc get pod koordlet-2mttc-n koordinator-system-oyaml, which is as follows:
containers:

args:
-addr=:9316
-cgroup-root-dir=/host-cgroup/
-feature-gates=BECPUEvict=true,BEMemoryEvict=true,CgroupReconcile=true,Accelerators=true,GPUEnvInject=true
-runtime-hooks-host-endpoint=/var/run/koordlet/koordlet.sock
--logtostderr=true

--v=5
The GPUEnvInject=true parameter is disabled by default. I just added it manually, and the problem is fixed.

OK. This issue is closed. Please feel free to re-open it if you meet any other problems.
/close