How to serve in production ?

Hi,
How to serve my app with PM2 manager and express ?

Run ssr:build and then to start the express server run ssr:start. There is also a connect middleware that can be used like this:
import ssrMiddleware from '@akryum/vue-cli-plugin-ssr/lib/app'

module.exports = app => {
  ssrMiddleware(app, { prodOnly: true })
}

with PM2 ?


Provide flashing instructions, point at GUI editor, and format support links.

Looks great aside from the comment about the physical button, if you're ok to tweak that a bit we can get this merged

Hopefully that looks better!

Looks excellent, thank you!


feat: support python 3.13

What I did
Adds in support for Python 3.13
fixes: 2392
Fixes: APE-1855
How I did it

How to verify it

Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

failing test should be fixed with https://github.com/jcrist/msgspec/pull/711

Another random change to remember:

[ ] Update black's language config in pyproject.toml file

failing test should be fixed with jcrist/msgspec#711

He hasn't released it yet and people are asking for it: https://github.com/jcrist/msgspec/issues/777. If it takes too long, would you guys be willing to do something like:
msgspec @ git+https://github.com/jcrist/msgspec@595c33c4a71c6d0c539b82233982a65819e240c

The reason why I ask is that I migrate snekmate to Python 3.13 here: https://github.com/pcaversaccio/snekmate/pull/291.

@pcaversaccio instead I'm just going to remove the msgspec dep. will definitely get this out in next release


list: Add columns to extended output to show stale assets

Add three new columns to the "list --cc-all" output:

LATEST-KERNEL (Newest locally-available kernel)
LATEST-IMAGE  (Newest locally-available image)
STALE         (String describing if the current kernel or image are not current).
Fixes #630.

Signed-off-by: James O. D. Hunt<EMAIL_ADDRESS>

Quick! Someone review before Jenkins notices! ;)

I've created a wiki page describing stale containers and how to deal with them:

https://github.com/clearcontainers/runtime/wiki/Stale-containers


Blackduck scan failing for .Net 6 project and detect version 7

I am trying to run blackduck scan as part of a github workflow where my project is built using .Net Version 6.0.2
My blackduck scan step looks like this:
- name: Perform Blackduck Analysis
        uses<EMAIL_ADDRESS>        with:
          version: 7
          blackduck.url: ${{ secrets.BLACKDUCK_URL }}
          blackduck.api.token: ${{ secrets.BLACKDUCK_TOKEN }}
          args: --detect.project.name="${{ env.BLACKDUCK_PROJECT_NAME }}"
            --detect.blackduck.signature.scanner.upload.source.mode=false
            --detect.project.version.name="${{ env.BLACKDUCK_PROJ_VERSION }}"
            --detect.wait.for.results=false
            --logging.level.com.synopsys.integration=DEBUG
            --detect.risk.report.pdf=false
            --detect.timeout=3600
            --detect.detector.search.depth=9
            --detect.project.codelocation.unmap=true

With this , I am getting error during scan stating
2022-02-26 16:56:53 UTC DEBUG [main-Executable_Stream_Thread] --- It was not possible to find any compatible framework version
2022-02-26 16:56:53 UTC DEBUG [main-Executable_Stream_Thread] --- The framework 'Microsoft.NETCore.App', version '2.0.0' (x64) was not found.
2022-02-26 16:56:53 UTC DEBUG [main-Executable_Stream_Thread] ---   - The following frameworks were found:
2022-02-26 16:56:53 UTC DEBUG [main-Executable_Stream_Thread] ---       6.0.2 at [/home/runner/.dotnet/shared/Microsoft.NETCore.App]
2022-02-26 16:56:53 UTC DEBUG [main-Executable_Stream_Thread] ---
2022-02-26 16:56:53 UTC DEBUG [main-Executable_Stream_Thread] --- You can resolve the problem by installing the specified framework and/or SDK.
2022-02-26 16:56:53 UTC DEBUG [main-Executable_Stream_Thread] ---
2022-02-26 16:56:53 UTC DEBUG [main-Executable_Stream_Thread] --- The specified framework can be found at:
2022-02-26 16:56:53 UTC DEBUG [main-Executable_Stream_Thread] ---   - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=2.0.0&arch=x64&rid=ubuntu.20.04-x64
2022-02-26 16:56:53 UTC INFO  [main] --- Process return code: 150
2022-02-26 16:56:53 UTC DEBUG [main] --- ------------------------------------------------------------------------------------------------------
2022-02-26 16:56:53 UTC DEBUG [main] --- Finished extraction: EXCEPTION

So I tried to install .Net Core v2.0.0 also , but then getting different error
2022-02-26 17:11:36 UTC DEBUG [main-Executable_Stream_Thread] --- Registering MSBuild defaults.
2022-02-26 17:11:36 UTC DEBUG [main-Executable_Stream_Thread] --- No usable version of the libssl was found
2022-02-26 17:11:36 UTC INFO  [main] --- Process return code: 134
2022-02-26 17:11:36 UTC DEBUG [main] --- ------------------------------------------------------------------------------------------------------
2022-02-26 17:11:36 UTC DEBUG [main] --- Finished extraction: EXCEPTION
2022-02-26 17:11:36 UTC DEBUG [main] --- Code locations found: 0
2022-02-26 17:11:36 UTC DEBUG [main] --- Exception: DetectableException: Executing the nuget inspector failed: 134
2022-02-26 17:11:36 UTC DEBUG [main] --- Details:

com.synopsys.integration.detectable.detectable.exception.DetectableException: Executing the nuget inspector failed: 134
	at com.synopsys.integration.detectable.detectables.nuget.NugetInspectorExtractor.executeTarget(NugetInspectorExtractor.java:93) ~[detectable-7.11.1.jar!/:na]

Any idea what I am missing here or how should I solve this issue?

I've got the same problems.
Scanner seems to work on 3.0 and 3.1 but not on 6.x
.NET 6 is now LTS since 8 march 2022: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core

Apparently it was fixed in v7.13.0.
Try using: detect-version: '7.13.0'


Check IP configuration in network test suite

Rebased on latest HEAD, should be ok now

/hold
going to hold on merge until after image releases

/unhold
Ready.


[21941] Fix no output timestamp case

Run Dataflow ValidatesRunner

Thanks @reuvenlax - is there any source to verify that this is the case?
LGTM


CSRF Protection middleware

I feel that the current implementation of CSRF middleware does not provide sufficient protection against CSRF attacks 😅
This code relies heavily on the Origin header: an attacker can easily forge this header, bypassing our protection
After some research, it seems that the best way to implement CSRF protection is to use a token-based verification system with either :

A token stored in a cookie
A token that will be stored in the X-CSRF header that will be returned with each request.

What do you think ?

@AymaneIsmail yeah you're right, a token-based approach is indeed more secure and recommended. Origin header is also not present on some older browsers which is worth remembering.
What do you think about expanding the options so the user has to pass their own getter/setter? I kinda think it's probably more composable than just using the built-in CookieHelper.
Something like this...
<?php

namespace Dumbo\Middleware;

use Closure;
use Dumbo\Context;

class CsrfMiddleware
{
    const SAFE_METHODS = ['GET', 'HEAD', 'OPTIONS', 'TRACE'];
    const TOKEN_LENGTH = 32;
    const TOKEN_NAME = 'csrf_token';
    const HEADER_NAME = 'X-CSRF-Token';

    public static function csrf(array $options = []): Closure
    {
        $tokenName = $options['tokenName'] ?? self::TOKEN_NAME;
        $headerName = $options['headerName'] ?? self::HEADER_NAME;
        $useHeader = $options['useHeader'] ?? false;
        $getToken = $options['getToken'] ?? null;
        $setToken = $options['setToken'] ?? null;

        if (!is_callable($getToken) || !is_callable($setToken)) {
            throw new \InvalidArgumentException('getToken and setToken must be callable');
        }

        return function (Context $ctx, callable $next) use ($tokenName, $headerName, $useHeader, $getToken, $setToken) {
            if (self::isSafeMethod($ctx->req->method())) {
                return self::handleSafeMethod($ctx, $next, $tokenName, $headerName, $useHeader, $getToken, $setToken);
            }

            if (!self::validateToken($ctx, $tokenName, $headerName, $useHeader, $getToken)) {
                return $ctx->json(['error' => 'Invalid CSRF token'], 403);
            }

            return $next($ctx);
        };
    }

    private static function isSafeMethod(string $method): bool
    {
        return in_array(strtoupper($method), self::SAFE_METHODS);
    }

    private static function handleSafeMethod(Context $ctx, callable $next, string $tokenName, string $headerName, bool $useHeader, callable $getToken, callable $setToken): mixed
    {
        $token = $getToken($ctx);

        if (!$token) {
            $token = self::generateToken();
            $setToken($ctx, $token);
        }

        if ($useHeader) {
            $ctx->header($headerName, $token);
        }

        return $next($ctx);
    }

    private static function validateToken(Context $ctx, string $tokenName, string $headerName, bool $useHeader, callable $getToken): bool
    {
        $storedToken = $getToken($ctx);

        if (!$storedToken) {
            return false;
        }

        $receivedToken = $useHeader
            ? $ctx->req->header($headerName)
            : $ctx->req->body()[$tokenName] ?? null;

        return hash_equals($storedToken, $receivedToken);
    }

    private static function generateToken(): string
    {
        return bin2hex(random_bytes(self::TOKEN_LENGTH / 2));
    }
}

Which then means the user can do:
use Dumbo\Middleware\CsrfMiddleware;
use MyApp\Helpers\MyCookie;

$app->use(CsrfMiddleware::csrf([
    'getToken' => function ($ctx) {
        return MyCookie::get($ctx, 'csrf_token');
    },
    'setToken' => function ($ctx, $token) {
        MyCookie::set($ctx, 'csrf_token', $token, [
            'httpOnly' => true,
            'secure' => true,
            'sameSite' => 'Lax',
        ]);
    },
]));

Or with session storage:
use Dumbo\Middleware\CsrfMiddleware;

$app->use(CsrfMiddleware::csrf([
    'getToken' => function ($ctx) {
        return $_SESSION['csrf_token'] ?? null;
    },
    'setToken' => function ($ctx, $token) {
        $_SESSION['csrf_token'] = $token;
    },
]));

One mistake I made above was always using the json response. Perhaps we also provide this an option so users can change the behaviour of the error response?

@AymaneIsmail I think this is good to go, wdyt? Looks really good ⭐

@AymaneIsmail I actually get {"error":"Invalid CSRF token"} on second attempt of the cookie-auth demo. This could well be the demo I created, not your code 😆

@AymaneIsmail are you good if we merge this now? I don't think there is anything outstanding...

@AymaneIsmail are you good if we merge this now? I don't think there is anything es, I totally forgot to tell you about the PR, excuse me.

@AymaneIsmail are you good if we merge this now? I don't think there is anything outstanding...

Yes excuse me, I totally forgot to tell you about the PR 😅


Feature/fe support for leave game

Feature
The API requires that the client send a message whenever leaving the room.
This PR meets that requirement and also adds in the keep-alive message and auto reconnect of closed sockets.

We could put it in our app db (also on the window at window.re_frame.db.app_db), but I mainly went this route because I want to treat our ws framework independently from our state. It really comes down to how we view the ws connection, is it part of our app state or is it something else?


podman-remote: build --file SUBPATH: exit 0, but NOP

Usual setup for podman system server
$ mkdir a
$ echo 'FROM docker.io/library/alpine:latest' >a/Containerfile
$ ./bin/podman-remote --url $MYSOCK build --layers=true -t test --file a/Containerfile a

This exits immediately, with exit status 0, having performed nothing. On server debug log:
DEBU[0449] APIHandler -- Method: POST URL: /v1.0.0/libpod/build?dockerfile=a%2FContainerfile&forcerm=1&platform=linux%2Famd64&rm=1&shmsize=67108864&t=test
INFO[0449] Request Failed(Internal Server Error): error reading info about "/dev/shm/libpod_builder405942463/build/a/Containerfile": stat /dev/shm/libpod_builder405942463/build/a/Containerfile: no such file or directory

Running without --file etc proceeds farther, but with its own weirdness which I will report after this.

@edsantiago it could well be end of day brain for me, but I'm not able to get your command to run using the latest  upstream.  The --url isn't found?  I've not played with the remote side much, so could be a user error here.  Also, what did you set $MYSOCK to and what command did you run for the server?
# ./bin/podman-remote --url $MYSOCK build --layers=true -t test --file ~/Dockerfile.alpine .
Error: unknown flag: --url

@tomsweeney sorry, I left out important steps because I was filing so many issues that day. "Usual setup" means:
$ export MYSOCK=unix:/tmp/mypodmansock
$ ./bin/podman system service --timeout=0 $MYSOCK

That hangs (serving), so you need to set MYSOCK on the other shell.
I'm not seeing the same failure any more though. I will investigate further tomorrow.

Duh. The key is that podman server can't be in the same pwd as podman client. Yep, problem still exists.

@edsantiago I still can't get  podman-remote to find a --url option.  Is that bit correct?

@TomSweeneyRedHat my first and only guess is that somehow you've got the build tags wrong and are building varlink instead of v2? But I have no idea how to even test that. --version doesn't help. Or maybe you're typing make podman instead of make? Can you ls -l bin/podman-remote?
What does plain simple ./bin/podman-remote --url say? For me it says Error: flag needs an argument: --url.


crystal init lib foo creates a dir even when foo directory already exits

I created a directory foo with a file foo.txt. Then i tried running crystal init lib foo. I think this should have failed, but it did not. It adds foo.txt inside foo directory with all other lib files. You can see foo.txt inside foo.
$ mkdir foo

$ touch foo/foo.txt

$ crystal init lib Foo
      create  Foo/.gitignore
      create  Foo/LICENSE
      create  Foo/README.md
      create  Foo/.travis.yml
      create  Foo/shard.yml
      create  Foo/src/Foo.cr
      create  Foo/src/Foo/version.cr
      create  Foo/spec/spec_helper.cr
      create  Foo/spec/Foo_spec.cr
Initialized empty Git repository in /Users/vjdhama/Work/crystal/foo/.git/

$ ls
first.cr       foo

$ ls foo
LICENSE   README.md foo.txt   shard.yml spec      src

As already discussed on IRC, I think it should print an error message for that case too, yes. This is so strongly related to #1472 that I'm close to saying it's a duplicate. In any case both issues should be resolved together.

@jhass I also think they should be resolved together. The other issue didn't have info about this issue. That's why I referenced it.

And I created new issue because in this issue there was no error thrown. Issue #1472  was about printing better error message. That's not the case with this issue.


Razor Components (Blazor 0.8) - "double/float/decimal" error parse

Describe the bug
If i use type="number" parameter I cannot use double / float / decimal in bind.
To Reproduce
@page "/testpage"

@functions {
    protected double sum { get; set; }
}

<input type="number" bind="@sum" />

When I enter 4.1 or 4,1 into input, I get an error message.
Uncaught (in promise) Error: System.FormatException: Input string was not in a correct format.
   at Microsoft.JSInterop.DotNetDispatcher.InvokeSynchronously(String assemblyName, String methodIdentifier, Object targetInstance, String argsJson)
   at Microsoft.JSInterop.DotNetDispatcher.BeginInvoke(String callId, String assemblyName, String methodIdentifier, Int64 dotNetObjectId, String argsJson)
    at endInvokeDotNetFromJS (components.server.js:23)
    at components.server.js:23
    at new Promise (<anonymous>)
    at e.beginInvokeJSFromDotNet (components.server.js:23)
    at components.server.js:16
    at Array.forEach (<anonymous>)
    at e.invokeClientMethod (components.server.js:16)
    at e.processIncomingData (components.server.js:16)
    at e.connection.onreceive (components.server.js:16)
    at WebSocket.i.onmessage (components.server.js:16)
components.server.js:16 Error: Connection disconnected with error 'Error: Websocket closed with status code: 1006 ()'.

Additional context
https://github.com/aspnet/AspNetCore/blob/master/src/Components/Components/src/BindMethods.cs#L155
public static Action<UIEventArgs> SetValueHandler(Action<double> setter, double existingValue)
{
   return _ =>
      {
         var val = (string)((UIChangeEventArgs)_).Value;  // res: 4.1  <= The value is always with a dot.
         var sum = double.Parse(val);                     // System.FormatException
         setter(sum);                                     // Not called
      };
}

Probably you have a system with decimal separator set to comma. Parse without culture uses current culture. They should use InvariantCulture. It looks that similar bug was introduced in new forms components:
https://github.com/aspnet/AspNetCore/pull/7614#pullrequestreview-204526483

@javiercn can you please try to reproduce this? Thanks!

After doing some investigations here are my conclusions.

In this case, the issue is the server parsing a value not using the invariant culture, so when the server is not in a culture compatible with the invariant (which normally is very much english) things can go wrong.
The invariant culture might not be the right choice all the time. It just so happens that when the input is of type number, the browser will normalize the value for us, but when the input does not have a type, that conversion doesn't happen.
I believe this means that potentially we need to somehow flow the culture from the browser to the server and potentially let the user make a choice on a per-binding basis.
Looking at what modelbinding does, it picks the culture from the currentculture, so if there is a middleware that sets that, then that culture gets used.
We don't have a similar mechanism in Blazor apps, so maybe this is something we need to add to the component context and enable setting somehow.

I'm by no means an internationalization expert. @rynowak do you have spicy thoughts on this topic?
As a plan of record, we should start by making things parse data using the invariant culture, and when we can see other options.

Not sure how doable is to write an E2E test for this.

@cores-system What's the locale in your machine?

@Javiercn, ru_RU

@cores-system Thanks.
Here is the confirmation:
double.Parse("1234.5", System.Globalization.CultureInfo.GetCultureInfo("ru-RU"))
Input string was not in a correct format.
  + System.Number.ParseDouble(string, System.Globalization.NumberStyles, System.Globalization.NumberFormatInfo)
  + double.Parse(string, System.IFormatProvider)
> double.Parse("1234,5", System.Globalization.CultureInfo.GetCultureInfo("ru-RU"))
1234.5

Looking forward, he main thing that can cause issues here is the fact that there might be normalized values and non normalized values at play depending on what you use type="number" or type="text" for example.
There might even be cases where choosing a different culture doesn't error out, but produces the wrong value.
It might be ok to say here that if you choose to bind to double it's invariant culture every single time, and that if you have type="text" you need to do the parsing yourself to a number or accept invariant culture as the culture.
That said, we should provide a way to flow the browser culture to the application. navigator.language seems to be the JS way of achieving this.

I think that we should always use invariant culture in double/float/decimal binding. It should be documented that this will work correctly only with input type="number". Here is a small example to demonstrate comma/dot decimal separators in action.
<!DOCTYPE html>

        pl-pl <input lang="pl-pl" id="input-pl" type="number" step="0.01">

        en-us <input lang="en-us" id="input-us" type="number" step="0.01">

        <button onclick="setValues()">Set Values</button>
        <button onclick="getValues()">Get Values</button>

        pl-pl:

        en-us:

In Firefox it works as expected: first input field displays numbers with coma decimal separator and second input field displays dot. Polish Chrome displays comma in both input fields which is in my opinion wrong. Fortunately value property always has dot.
I agree with @javiercn that if I want to use input type="text" I should bind to string property/variable and parse data myself.

Closing this issue as this work will be covered as part of the referenced Globalization support issue.


Reading / writing values from / to frames is broken

The representation of a left value left(a): A + B is [0] * [?]^padL(A,B) * representation(a, A).
The representation of a right value right(b): A + B is [1] * [?]^padR(A,B) * representation(b, B).
Neither the read method nor the write method handle this.
I think this remained undetected because we never initialize the Bit Machine with input values, nor do we ever read output values from the final output frame.

To clarify, it's the read_value and write_value methods that are broken -- which indeed, are only used when providing programs with inputs or outputs.
I'm not terribly surprised these methods are broken. You're right that they've basically never been used and I guess there aren't very good tests since this predates all the ConstructNode/miniscript/text representation stuff. Sorry.


Re-running create-for-rbac Overwrites Existing 'rbac' Credential

Using az ad sp create-for-rbac and generating a password credential enters a credential with the description or customKeyIdentifer value rbac. When re-running this and an existing application is patched by adding a new credential, the patch process sees the same customKeyIdentifer value and overwrites the existing credential password.
Either this needs to be called out in the documentation (currently the documentation doesn't state it will patch/update an existing application or fail out) or the default behavior should be changed. Possibly changing the description value to rbac-YYYY-MM-DD or something similar would be appropriate. The description could also be a CLI parameter.
Description is set here:
https://github.com/Azure/azure-cli/blob/3c3407952bf427c8f3381e4ab27e148bf8b29eb6/src/azure-cli/azure/cli/command_modules/role/custom.py#L1438-L1445
The customKeyIdentifer is encoded here:
https://github.com/Azure/azure-cli/blob/3c3407952bf427c8f3381e4ab27e148bf8b29eb6/src/azure-cli/azure/cli/command_modules/role/custom.py#L1204-L1205
Documentation here:
latest/docs-ref-autogen/ad/sp.yml](https://github.com/MicrosoftDocs/azure-docs-cli/blob/master/latest/docs-ref-autogen/ad/sp.yml

@jiasli for awareness


blitz4j is no longer included in eureka server as part of 1.3.5...

... #714 . Default log4j properties still points to a class that is part of blitz4j, generating an exception at boot time.

NetflixOSS » eureka » eureka-pull-requests #545 SUCCESS
This pull request looks good

Thank you for spotting this.

you're welcome!


cleancss replaces all "null" to "$1 $2]"

If you have class .null in code it will be replaced to $1 $2]

Here's the commit that has an error in code:
https://github.com/jakubpawlowicz/clean-css/commit/134972c693ec26daa860e713d68b7d56f10cf68e

Line 140
https://github.com/jakubpawlowicz/clean-css/blob/08a9505480761942ba7b20c9569c97de7a5e3150/lib/optimizer/level-1/tidy-rules.js

Oh boy, I love JS. Sorry, fix is coming.


Forwarding should not be sent if it is unable to fetch the operation-name while formulating the request body of forwarding

Issue Description:
When /v1/regard-application is executed, it will create http-c, op-c, tcp-c for the regarded application in config file and /v1/add-operation-client-to-link forwarding will be sent.
The request body for the forwarding /v1/add-operation-client-to-link is formulated by fetching the operation-name of the regarded application.
If it is unable to fetch the operation-name for some reason, the forwarding should not be processed further.

Completed in the below PR
https://github.com/openBackhaul/OamLog/pull/386


Create script for setting up Iglu repo and bucket for jsonpath file

The script should take two arguments:

Bucket name for iglu static server repo
Bucket name for jsonpath file

Bonus if script can generate a customized version of https://github.com/snowplow/snowplow-mini/blob/master/resources/iglu/README.md

I don't remember what this issue was about? It makes no sense to me now...

I think this was to allow for loading into Redshift probably with the need for JsonPaths?

Closing, follow https://github.com/snowplow/snowplow-mini/milestone/9 for Redshift loading planning.


support tls connections

this also needs basic SASL auth for libera.chat :)

Thank you so much for this great addition.


revert to original

Reverting the feedstock to its original state before the date feature PR
Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Latest version does not work <IP_ADDRESS>

Hi,
Using HA with HACS. The latest version downloads and installs correctly however previously working sensors either become unavailable or go to an unknown state, whereas some of them work fine.
I left this overnight thinking it was an API issue and no success.
Reverted back to the previous version this morning, all sensors are back online again.
Thanks.

Hello,
i have the same problem. In version 0.0.14 the car was always active. In version 0.0.13 everything works fine. I reverted to this version.
Thanks for your great work.

Hello, i have the same problem. In version 0.0.14 the car was always active. In version 0.0.13 everything works fine. I reverted to this version.
Thanks for your great work.

Since 0.0.14, this is happening with some binary sensors, already reported in #82 and now in #96.

Hi,
Using HA with HACS. The latest version downloads and installs correctly however previously working sensors either become unavailable or go to an unknown state, whereas some of them work fine.
I left this overnight thinking it was an API issue and no success.
Reverted back to the previous version this morning, all sensors are back online again.
Thanks.

Have you tried removing the integration after installing the new version, and re-adding it again?
I know that this last version had some breaking changes somehow outlined in the version changelog:

Same issue even when removing previous install.
This is all that works:

And this is from the entities page:

@vantech14 May I ask which version of id software you have installed in your vehicle?
All this information is ONLY being brought from VW for vehicles with version 3.0+.

@pplucky I'm on version 2 still so that explains it! Thanks

2.4
pplucky @.***> schrieb am Fr., 18. Nov. 2022, 13:12:

@vantech14 https://github.com/vantech14 May I ask which version of id
software you have installed in your vehicle?
All this information is ONLY being brought from VW for vehicles with
version 3.0+.
—
Reply to this email directly, view it on GitHub
https://github.com/mitch-dc/volkswagen_we_connect_id/issues/100#issuecomment-1319918627,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APZSJFT3FW3WO5LMRMTIX5DWI5XCZANCNFSM6AAAAAASEG5IVA
.
You are receiving this because you commented.Message ID:
@.***>

@vantech14 Can you maybe close the issue, as this is actually a non-issue.

Most of the ID user have only softwarw-version 2.4. They are waiting for ota 3.0.

Most of the ID user have only softwarw-version 2.4. They are waiting for ota 3.0.

Yes, but the API does not return the software version, so I suppose no distinction can be made by the component: it works if supported by software/API, otherwise you'd better disable the entities in the integration or ignore them as being unavailable.

I want to add some time in figuring out a way to make this a little more pretty, for now i pulled the last release because people had breaking stuff.

Added try/catch in latest beta release,


Image element not rendered

Hello,
I try to render an embedded png image inside an SVG but it's not rendering at all. I've simplified the SVG so you can look at the element that is causing the problem: shadow_test.svg.zip

Expected
Result

Is the image rendering supported, I see it get parsed in svgdom but I'm not sure the rendering is handled properly.

@Maxador Right, svgren doesn't render <image> elements.
Though, if you just need to achieve the same effect, i.e. blurred rectangle, you can use gaussian blur filter, like this:
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="375" height="235" viewBox="0 0 375 235">

    <defs>
        <filter
                style="color-interpolation-filters:sRGB"
                id="the_blur_filter"
                x="-20%"
                width="140%"
                y="-20%"
                height="140%"
            >
            <feGaussianBlur
                    stdDeviation="10"
                    id="feGaussianBlur4620"
                />
        </filter>
    </defs>

    <rect id="white_background" x="0" y="0" width="100%" height="100%" fill="white" />

    <rect id="grey_blurred_rect" width="264" height="144" x="92" y="72" fill="grey" style="filter:url(#the_blur_filter)"/>

</svg>

Yeah I see, unfortunately I cannot do that because the same SVG is not rendering properly on another platform that doesn't handle filters/blurs properly.

I see. Well, let's keep this ticket open, but I'm not sure that drawing <image> elements will be implemented anytime soon. It is tricky, as the element can have transformations and thus some kind of scaling/rotation/skewing algorithms for raster image will have to be implemented which is far not trivial task. Perhaps you could looks for ways to make that another platform support blur filter.

@Maxador as a workaround, maybe you could have both elements in your SVG, the raster image and the rect with blur effect. One of those will be rendered only on one platform, the other one - only on another platform. But this is a dirty workaround and may lead to sudden breakages in case something changes on any of the platforms regarding the <image> element or blur support.

Thanks for the suggestion but it won't cut it unfortunately. We decided to go through another route and stop using SVGs for this use case. It was getting too hacky 😅.


Created an es5-getter-ember-codemod that might be a good addition

This codemod is intended to automatically convert your usage of get, and getProperties to use traditional object dot notation as proposed by emberjs/rfcs#281.
https://github.com/rondale-sc/es5-getter-ember-codemod

Definitely lets add this. We have minimum version support, so you can add it now with minimum version 3.2, which I believe is the correct version minimum.

3.1 is where the feature was introduced...

@kellyselden I'll put this on my TODO list for tomorrow.


Update @tkey/core peer dependency version to make it compatible with v12

Hi @chaitanyapotti ,
Could not install the @tkey/core peer dependency ^v12 and forced me to install it using --legacy-peer-deps.
I updated package.json and built it successfully.

Superseded by #6.
we also needed to update the deps.

Thanks for your contribution


No redirect to the login page on www.olx.pl

New Issue Checklist (tick off like this: [x])

[x] I checked existing issues (open and closed) for possible duplicates
[x] I can reproduce the problem on the latest stable version (not nightly!)
[ ] If you have a problem with a specific website: adding the domain to your no-skip-urls-list does not solve the problem
[x] The issue is not about adding entries to the default no-skip-urls-list

What is your browser?

[ ] Firefox
[x] Chrome

What is your operating system?

[x] Linux
[ ] Mac
[ ] Windows

Description (please include examples/screenshots where applicable)
Clicking on "Twoje konto" on https://www.olx.pl/ fails to redirect to the login page.

You'll have to add www.olx.pl to your no skip list


Power usage is too high

Comparing the power usage of nodemcu and esp-open-rtos, nodemcu uses about 50% less power with the same program. As both programs have an PWM enabled(100us wake up period), the difference seems to be related to the radio not entering in "modem sleep" mode correctly.
Does anyone have any ideas on how to solve this?

FreeRTOS has an idle-hook feature, and ESP8266 has a minimal ambient-sleep mode.  I am unsure if esp-open-rtos out of the box enables those things, but that might be a place for you to start.

@Governa Did you manage to solve this?  I have a problem with the device consuming about 80mA and I think getting it into modem-sleep mode should help a lot, but I am struggling to find a working example of its use.

I have had a look at the Espressif RTOS Sdk, which has a wifi-station-machine-demo example, which seems to set MODEM_SLEEP mode using:
bool s = wifi_set_opmode(mode);
wifi_fpm_open();
wifi_fpm_set_sleep_type(MODEM_SLEEP_T);
wifi_fpm_do_sleep(0xFFFFFFFF);
The wifi_fpm_xxxx functions appear to be defined in libmain.a, with definitions in esp_wifi.h.   The definition of wifi_fpm_open() says you have to call that to enable the force sleep function as it is disabled by default.
Alas the wifi_fpm_xxx functions to not seem to be in the libmain.a file in esp-open-rtos.   Do you think I should be able to link against the version in the later Espressif SDK to get access to those functions?
Or have I missed something and esp-open-rtos already covers this?

I didn't  found any function working to get moden sleep mode. It is like is not implemented in esp-open-rtos.

Has anyone got any thoughts on how to go about fixing this - I'm happy to put some effort into a pull request for esp-open-rtos, because I don't like the Espressif RTOS sdk (all the GPIO stuff is so complicated!)....but I'm not really sure where to start - there must be some registers that need to be written to the chip to put it into MODEM_SLEEP mode to allow us to create an esp-open-rtos version of wifi_fpm_set_sleep_type etc    I'll ask Espressif, but not sure how helpful they will be - any idea what the other options are for fixing this?   Othewise I'll have to give up on esp-open-rtos and learn the Espressif sdk instead....

not sure how helpful they will be

Worth a try, but this will most likely yield nothing

there must be some registers that need to be written

That's about all we know :)
Debugging and implementing sleep mode will probably require lots of reverse engineering. If you'd like to try that, just say — there are plenty of tools available and I will happily provide some links. For a first step, I think one needs to check whether Espressif SDK uses tick suppression feature of FreeRTOS (portSUPPRESS_TICKS_AND_SLEEP) and what how it's implemented. For wifi_fpm_* stuff again, reverse engineering and decompilation may be the only way.

Thanks - I'd interested in any pointers you have into reverse engineering it - I'm not sure how far I'll get though, because my projects are very limited by spare time availability, and I'm not even sure the ESP8266 will be the final board I use - I'd really prefer a Bluetooth LE equivalent rather than wifi for comms, so I may give up if it sounds too hard - so don't put too much effort into digging things out for me!
I was wondering about  a simpler way out which may be to link to the current version of the Espressif SDK that includes the functions I need, to essentially use a hybrid between the Espressiff SDK and esp-open-rtos - I had a quick go a couple of weeks ago and got loads of linker errors, but I am a bit out of practice so may have made a silly mistake - do you think that approach would be 1) feasible and 2) legal from a license perspective?

reverse engineering

mailing list: https://groups.google.com/forum/#!forum/esp8266-re
tooling: radare2, IDA xtensa plugin
wiki: http://esp8266-re.foogod.com/ (it's down, but should be available in cache/archives)

Also, @ourairquality did a lot of reverse engineering and could probably recommend an optimal approach.

feasible

I don't think they keep binary compatibility, especially for internal functions. You may try to extract separate object files and objects, though.

Managed to get the wificfg example working in part using recent sdk libraries, and with the current FreeRTOS and lwip. There were are lot of hacks to get there. Some patches have been submitted to help bring this closer, such as adding a argument to interrupt handlers, moving the sysparams sectors etc.
I doubt it would be possible to split it up much more, not possible to pick just one of the libraries. For example, there seems to have been a significant change to how the wdev nmi is handled, and that seems baked into the binaries in many places. It was a lot of work just to separate it from the bundled version of lwip. Not sure if or when I'll look at that hack again, and I have not looked at the power usage either but it would be nice to have some control over it.
There appears to be a chunk of code in libpp, pm.o, and it's not clear if it is actually used.
What happens if the network mode is changed to 'none', does it turn off the radios and lower power consumption? I could live with just waking up the radio periodically and then turning it off again if that would have a similar effect.

@ourairquality - Thanks -  I'll have a go at doing sdk_wifi_set_opmode(NULL_MODE); which I think is what you mean?  Unfortunately I don't have a proper meter with me, just a USB tester that measures in 10mA steps, but it looks very different to what I was getting with a DVM so I don't think I believe the results yet...


Appstudio update test-component-pac-wpxr

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-wpxr-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
init

✅ Succeeded
18 seconds
clone-repository

✅ Succeeded
34 seconds
build-container

✅ Succeeded
15 seconds
deprecated-base-image-check

✅ Succeeded
10 seconds
inspect-image

✅ Succeeded
37 seconds
clamav-scan

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
9 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
7 seconds
show-summary

Pipelines as Code CI/test-component-pac-wpxr-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
32 seconds
build-container

✅ Succeeded
11 seconds
inspect-image

✅ Succeeded
10 seconds
deprecated-base-image-check

✅ Succeeded
35 seconds
clamav-scan

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
16 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
8 seconds
show-summary

Pipelines as Code CI/test-component-pac-wpxr-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
32 seconds
build-container

✅ Succeeded
11 seconds
inspect-image

✅ Succeeded
10 seconds
deprecated-base-image-check

✅ Succeeded
35 seconds
clamav-scan

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
16 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
8 seconds
show-summary


Parallel silo read error

Describe the bug
When performing a query over time using the direct database route, each time step is activated before retrieving the variable of interest. It looks something like this:
for ts in timesteps_to_query:
    TRY
        ActivateTimestep(ts)
        GetVar(...)
    CATCH
        ...

In one particular situation, calling ActivateTimestep is throwing an unexpected error; while querying a silo variable when running VisIt in parallel, I see the following:
terminate called after throwing an instance of 'std::length_error'
  what():  vector::_M_default_append

I've traced this down to originating in the DBOpen call from with avtSiloFileFormat.C. Strangely, this error does not show up when running VisIt in serial.
Helpful additional information
(Please click check boxes AFTER submitting ticket)

[x] Did VisIt crash?
[ ] Did you get wrong results?

Impact

[x] High - User productivity significantly degraded
[ ] Medium - User productivity partially degraded
[ ] Low - User productivity trivially degraded

Likelihood

[ ] High - occurrence is not specific to platform, data, config, a combination of operators, queries, etc.
[x] Medium - neither low nor high likelihood
[ ] Low - occurrence is specific to combination of multiple factors such as configuration, data, platform, etc.

To Reproduce
Launch VisIt in parallel. Open a silo dataset, and perform a pick through time using the direct route.

Can you say which silo dataset this is happening on?

I'm currently running wave.visit

@markcmiller86 I was actually going to tag you to see if you had any immediate ideas about this. One thing I'm noticing is that, when visit is initially opening the dataset, it's using the hdf5 route. During the query, though, it's using the SILO_DRIVER route. I'm not sure if that's expected or not.

Scratch that. I misread how the silo reader was handling its DBOpen cases. It's using HDF5 for each of the reads.

Silo has ability to open with explicit driver specific (e.g. DB_PDB or DB_HDF5) or with DB_UNKNOWN and then Silo lib itself will iterate through available drivers until it gets a succesful open.
In VisIt plugin we basically circumvent Silo's guessing by force DB_HDF5 first on the likely chance the file is an HDF5 file we don't waste time down in the lib iterating, trying pdb first (though I think hdf5 is the first thing newer versions of Silo try already). If DB_HDF5 fails, the plugin then tries DB_PDB and finally DB_UNKNOWN (a catchall for less common and more unusual cases).
When you get to a point you want/need me to look over your shoulder, you can webex me.

I'm not quite sure how to proceed at this point, given that the error seems to be coming from DBOpen (which I'm assuming is a silo function). The filenames all look correct. I'm going to need to switch to my other project tomorrow, but I will be back next week if you're available.

If VisIt is launched "in parallel" with only a single processor, everything works without issue. Anything more than that, and this issue occurs.

More info:

This issue only occurs when opening time step files that haven't yet been opened. If I all the requested time steps have been activated using SetTimeSliderState, then the issue does not appear.

This seems to be either a result of or related to the CloseFile method of avtSiloFileFormat.

Calling avtDatabase's GetMetaData with forceReadAllCyclesTimes set to true also causes this error, which seems unexpected.

Calling SaveWindow on the resulting curve, even when in serial, causes a crash (again, only silo):
VisIt: Error - The compute engine running on localhost has exited abnormally.
VisIt: Error - Scalable Render Request Failed (VisItException)
viewer: Obtained null data reader for rendered image for engine localhost

Oddly, this doesn't seem to occur when the test suite is run.

The issue revolved around ActivateTimestep not being called by every processor. A fix is undergoing a pull request.


ci: update github action

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (3c84fa2) 6.01% compared to head (17977f7) 6.01%.
Report is 34 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #220   +/-   ##
=====================================
  Coverage   6.01%   6.01%
=====================================
  Files         63      63
  Lines       3226    3226
  Branches     648     648
=====================================
  Hits         194     194
  Misses      2401    2401
  Partials     631     631

Flag
Coverage Δ

unittests
6.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Handle format translations in format replace

Regex, when doing format replacements, allows for !s, !r, and !a (though !a is omitted in PY2).
For completeness, add support for these even if it is unlikely that these would ever be used.  There isn't really a practical case for this, it would just be nice if these don't break things.
Regex actually applies these to the capture group except when specifying a sub capture {1[2]}.  This is weird and I don't care to mimic that, so this will apply to the captured string always.
Due to the complexity of handling string casing, we mimic formatting without actually calling the "format" function on the template's string object.  For this reason, formatting actually works in byte strings because our algorithm has no restriction in this case. Even though {} style formatting is not officially supported byte strings.
We will most likely implement things like they are in with Python 3.5's % style byte string formatting:

!r == repr(bstring).encode('ascii','backslashreplace')
!a will work like !r
!s probably shouldn't actually be supported as !b would actually make more sense, but for now, we'll make this work like this: bstring.encode('ascii','backslashreplace') and keep things consistent and not add something new like !b.

For Unicode strings, we'll just do the expected things:

!s == str(string)
!a == ascii(string)
!r == repr(string)

It is possible we could figure out a way to take advantage of a string object's actual format string.  This would eliminate support in byte strings.  I imagine we could just save away the actual format string for each group, then apply the transformation to that format group string and insert it between the proper literals.
This would probably make more sense, and be less work for us as we'd just leverage Python's ability to do this, and support whatever Python supports.

https://github.com/facelessuser/backrefs/tree/real-format implements true string formatting.  Testing has been limited.  As mentioned, format strings don't really work in byte strings just like they don't work in Regex, but we we now get full access to all of the format strings features.  Interestingly, this implementation allows for format spec while Regex for some reason does not.  Haven't looked a how Regex implemented theirs.
Because the Regex match object doesn't make it easy to index properly (neither the capture object or match object return the last capture by default), we have to inject explicit indexes for sub-captures when they are implicit.  Because we are also handling each format group separately, we inject the main capture index as well. Afterwards we apply casing.
Like Regex, we are flexible with object indexes and allow for negative values, hex, octal, etc.  Though field names cannot be negative, octal, etc.
I am a little sad that Python does not support this format for byte strings.  I'd have to double check how it processes strings to be sure I can't just drop this in for byte strings.  I could construct a rudimentary byte string format, but I'm not sure if it is worth the effort to duplicate all these features for byte strings.  I could provide a more simplified method that doesn't provide all the format spec stuff...

Added a simplified binary string formatting.  Should support everything but format spec.  One notable change though, in Re, when specifying something like {1[0]}, you won't get the first capture, but the first index of the first capture since Re does not accumulate but 1 capture, and does not return it as a tuple or list.

It should be noted that byte string formatting is mainly useful for indexing multiple captures for groups.
This is why we just assume ASCII when converting objects. I cannot see a real benefit of accessing the object's properties, or even converting types. The format spec is something that could actually be useful if I ever get around to implementing it, but the indexing is the actual import thing we are trying to accomplish with our simulated format environment.
Unicode format strings on the other hand can take advantage of the format spec which will be pretty nice, and is the other real benefit here.

I ended up doing more work than I initially planned.  I mainly wanted to feed format string patterns through Python's format  string handler, but ended up implementing our own as it made sense with the additions we have (and I didn't want to let go of format style with byte strings).  The ability to use fill and alignment was worth the effort.  It will make replacing formatted text very easy.


Add unit tests and small code changes to get back to 100% coverage.

Coverage increased (+0.1%) to 100.0% when pulling 6f8328d4f08e4f2a5ea3ee7634a5e0a66af3c7eb on BackToFullCoverage into a50558783f555c7013a92d2d9fb422cf46f19523 on master.


Do you plan to support @MonotonicNonNullDecl

Do you plan to support @MonotonicNonNullDecl? Recently I added this annotation to guava (https://github.com/google/guava/blob/master/guava/src/com/google/common/reflect/TypeToken.java#L105)
Or more generally, do you support the nullness annotations of the checker framework?

We can easily support interpreting the CF annotations as best as possible within the (less sophisticated) NullAway type system.  Actually enhancing the power of the type system would be more work and would require some further justification in terms of additional reliability in practice, etc.
For this one, I think by default we would just treat the field as @NonNull.  Are you looking for deeper support than that?

Ah, I see.  You're probably looking to not see reports of initialization errors on such fields, yes?  If so, that can easily be handled using the -XepOpt:NullAway:ExcludedFieldAnnotations option (see here).

For this one, should we treat it in the following way,
If a field $f$ annotated with @monotonicnonnulldecl is not initialized in a constructor, NullAway does not emit a warning saying that " initializer method does not guarantee @NonNull fields f is initialized along all control-flow paths"
I am currently focusing on eliminating all warnings on uninitialized fields.

Yeah, for now you can handle this by passing -XepOpt:NullAway:ExcludedFieldAnnotations=MonotonicNonNullDecl as an Error Prone / javac argument.  For CF compatibility we should probably bake in support for this annotation.

Neat. Thank you.


Correct threaded code memory map

Based on my understanding of this section, these values seemed to be incorrect.

Good catch!
Thank you.

No problem. This is a really good resource. Thanks!


Array relations is not working

I have 2 models which is related to each other.
Product.tsProductTranslation.ts
Product
|-- Id: number
|-- Price: number
|-- Translations: Array<ProductTranslation>

ProductTranslation
|-- LanguageId: string
|-- ProductId: Product
|-- Name: string

But I don't see translations array on create, edit or show page.

But when I check network traffic I see that there are already Translation fields responded from server.

I think the issue is related to sequelizejs adapter integration.
I want to achieve this structure:

I've just merged PR which adds arrays. You can try this out by installing latest versions of admin-bro-sequelize and admin-bro. Please let me know if that helped.

Thanks, I will check

it works so closing the issue

hmm - I am reading the docs and not necessarily it works. So arrays are handled but nested objects don't (in sequelize v5)
so let's leave this close but I will open another one for nested objects.

https://github.com/SoftwareBrothers/admin-bro-sequelizejs/issues/45

I'm sorry, I forgot about testing this. I had to write my own admin panel implementation since we needed more customizability and custom features. :/

I would love to hear about problems you had. Our goal is to create the best admin panel ever so every feedback is crucial. If you have couple of minutes you can hit me on AdminBro Slack Community: https://join.slack.com/t/adminbro/shared_invite/zt-czfb79t1-0U7pn_KCqd5Ts~lbJK0_RA and find me there


Quickstart cleaning

Description
Why is this change required? What problem does it solve? Describe your changes in detail:
Clean quickstart, fix syntax error
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[x] Documentation update
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist
List of items to check before submitting your PR. Note that this are only for helping
you remember what you might (also) need to do and are not mandatory requirements

[ ] Documentation is updated
[ ] docs/changelog.md is updated
[ ] Added test cases

@hhsecond why in the setup.py we are installing a (non-existent) branch of Hangar?

@alessiamarcolini Oops, that was from the hackathon. Also, can you give the PR to alternate-master. We cannot make changes to the master until the hackathon evaluation is done (I'll push a fix for the setup.py to alternate-master in few hours)

Marking as a duplicate of #42


[JSON Logic] Part 8: Fieldsets/Group Arrays

LAST PART. Some of this is a little messy but I couldn't get a proper way to fix this, and by the time we've all the other parts merged in - this should be easier to clean up if we need to.

Adds support for fieldsets having JSON logic, and individual items on a group array.
 :D

@brennj what do you think about closing the PR and re-opening it in the future when this becomes necessary to implement?

Closing for now!


Support baseURL

When running behind a reverse proxy, such as NGINX, the app expects to run at the server root path.
A baseURL setting would be great, so that it can run under a subfolder (e.g. domain.com/markereditor).
Thanks!

Thanks for the suggestion! I'll see what I can do here.

There's a new baseUrl setting in 2.8.0-beta.2. Like your other request, this hasn't been tested extensively, so let me know if it's not working as expected.


Reset visibleDays/currentMonth state when enableOutsideDays or numberOfMonths has changed

Address #700
Basically, the state in the DayPickerRangeController would previously be recomputed for a change in enableOutsideDays or numberOfMonths if and only the component had become focused. This change makes it so that they are always recomputed.
cc: @ArtyomResh @ljharb @gabergg @airbnb/webinfra

Coverage increased (+0.01%) to 86.5% when pulling 0ef7c7962c3d877e896132644bd482f21da1dc87 on maja-address-issue-700 into d0996afd7b998c6551fca3bcbddc45069bcbb6b9 on master.


Optionally change relocated dependencies

If you wanted, you could use org.openrewrite.java.dependencies.ChangeDependency as a mechanism to even keep the updating of the dependencies in a single place for both Gradle and Maven.

Thanks for the review and hints! Capturing some of the discussions here as a poor-man's ADR.
That shared ChangeDependency I'd tried for a bit, but didn't work for me; possibly because that uses getRecipeList instead of a shared visitor. I'll separately convert that recipe list into a regualar visitor to see if that works better.
https://github.com/openrewrite/rewrite-java-dependencies/blob/fb1f022fb78ac7492eb5357643b799fde60aed7b/src/main/java/org/openrewrite/java/dependencies/ChangeDependency.java#L90-L95
As for versioning there was some hesitation going for latest.release; not changing the version leads to broken-by-default, as rarely do the versions match across different groupIds and artifactIds. Looking through patch/minor/major versions that might be available seemed needlessly complex, for only a small chance that we stumble upon a change that requires no further work.
As it stands this recipe can be used either to merely find relocated direct dependencies in use, or kick start a migration; In the latter case latest also makes the most sense.


Eliminate null check on attrDefs

Rolled it into this set of changes: https://github.com/atlanhq/atlan-java-samples/pull/72


chore: ignore deno.lock using the config

Can you expand the scope of this PQ and ensure Deno 1.29 compatibility? This includes TS 4.9.3 support.

Pin d2n until @wojpawlik fixes his setup to prevent publishing broken versions

I disabled auto updates until deno-bin is fixed.

@KnorpelSenf We're passing.


[SourceKit] AST manager should use overlays when reading files

SwiftASTManager ignored overlays when reading in files that it would
later replace all inputs with. This meant that files mapped in the
overlay would become empty in all non-completion editor functionality
paths.
Resolves rdar://85508213.

@swift-ci please test

@swift-ci please test

And I didn't realise FileError wasn't passing EC from the base error in stable, cherry-picked in https://github.com/apple/llvm-project/pull/4100

@CodaFi added you since the original frontend code was yours.

@swift-ci please test

@swift-ci please test macOS platform

@swift-ci please test

@swift-ci please test


Error when opening project

I followed your instructions but when I open the unity project there are few errors

Try opening the solution at src/UnityWebBrowser.sln, and build the UnityWebBrowser.Shared project with ReleaseUnity | Any CPU set as the configuration.
It should then copy its Dll to src/Packages/UnityWebBrowser/Plugins/UnityWebBrowser.Shared.dll, but just double check that its there. If its not just manually copy it.
Also make sure Unity is closed when you do this.

oh, I fixed it, thank you so much


Using check_wasm outside of cosmwas_vm is discouraged

Hello !
To develop our clone-testing library at Abstract Clone Cw-Multi-Test, we need to use the check_wasm function to check that the wasm can be uploaded on-chain correctly.
However, it's inside the internal module of the cosmwasm_vm crate and its interface keeps changing in a breaking manner.
Would it be possible to expose a stable check_wasm interface instead ?
Thank you

Hey, that's kind of the point of having it inside the internal module that we have more flexibility with changing it.

Hey, that's kind of the point of having it inside the internal module that we have more flexibility with changing it. Would it be an option for you to pin the cosmwasm-vm version? That way you can upgrade explicitly and adjust to any breaking changes.

yeah that's an idea, will do that :)

Ok, I will pin my version.


Weird NSObject dealloc with Swift 4

Swift 4.
Due to unknown reason NSObjects, that was used with anonymous variables in closures tend to dealloc by unknown reason.
E.g. example app:
func inject(into feedViewController: FeedViewController) {
        defineInjection(into: feedViewController) {
            $0.xkcdService = self.serviceAssembly.xkcdService
            $0.imageService = self.serviceAssembly.imageService
        }
    }

Will crash later, because feedViewController deallocated, and variables to it now works like unsafe unretained.
But this will work:
func inject(into feedViewController: FeedViewController) {
        defineInjection(into: feedViewController) { (_ feedViewController: inout FeedViewController) in
            feedViewController.xkcdService = self.serviceAssembly.xkcdService
            feedViewController.imageService = self.serviceAssembly.imageService
        }
    }

I've tried to make test, which reproduces such behaviour, but it passed normally.

Here's first insane solution:
    func injectObject(object: inout InjectableObject) -> Void {

        guard var injectableObject = object as? ObjectType else {

            return
        }

        #if swift(>=4.0)

            if Mirror(reflecting:object).displayStyle == Mirror.DisplayStyle.`class` {

                var anyObject = object as AnyObject
                var objectPTR = Unmanaged<AnyObject>.passRetained(anyObject).takeUnretainedValue() as! ObjectType
                self.injectClosure?(&objectPTR)
            }
            else {
                print("Injecting nonnobject: \(injectableObject)")
                self.injectClosure?(&injectableObject)
                object = injectableObject
            }
        #else
            self.injectClosure?(&injectableObject)
            object = injectableObject
        #endif
    }

It stops crashes. But it will make invalid references count in tests.

Decided to replace 'inout' closure variable with return value. This brokes API compatibility, but should fix nsobject release issue.

Should work in 1.4.0. Don't forget to add lots of 'return $0'


Use ENV var instead of fixed value in repo_list_spec

Having this value hard coded led to hard to debug failures
when your local HOUND_GITHUB_USERNAME was not "houndci".
This was because the WebMock stubs were stubbing
with "houndci" and the app makes requests
based on the ENV var.

:+1:

Looks like Travis is okay without this?

@croaky In travis we first copy the sample env which has the "correct" env var present here. This came up on my machine because I had it set to something else in my local .env

LGTM


Extra tabs created

I'm using 8.10 beta with 1.30 Obsidian.
When I open a note with one already pinned in the window, it creates three empty tabs as well as opening the note.

Thank you for your bug report, @kmaustral :)
Duplicated with https://github.com/tadashi-aikawa/obsidian-another-quick-switcher/issues/157.


Please don’t color the text by default…

People have their own preference for text color, please don’t force it…
I know ?T exists, but to use it I have to quote the URI, which is annoying.
The color chosen here could be unfriendly to light theme users.

I think colors should be used by default, but it should use the "standard" colors, not the extended color codes. The "standard" colors are adjustable, so they're readable on light themes, but the current colors lack contrast there.

@MetroWind
@kelunik
What do you think about this idea:
what if we use some special domain name where the text only version:
something like "t.cheat.sh" or "t.cht.sh"? In this case we could just access plain text cheat sheets without appending anything to the URL?

@chubin Sounds good to me, but doesn't help users of light themes who want colors but not the current ones (like me).

@kelunik I use pygmentize that just generates this output.
Probably we need some form of colors normalization
By the way, do you know that we have various color schemes?
Have you tried:
curl cht.sh/:styles-demo
?

what if we use some special domain name where the text only version

@chubin That would work for me.
As to @kelunik’s point, I think it would be better if the “main text” part can be uncolored by default, so the terminal would just use the normal text color for those. The “special text” can use the standard colors, and they should look good on all cases (as long as the users takes care of their terminal settings…). Although it could be hard to judge what counts as “main text”.

@MetroWind As a temporary workaround I would suggest you using the cht.sh client (cht.sh),
which has its configuration file, where you can specify query options, so that you always will get answers without ANSI-sequences. It has many other advantages, and can be used in scripts  or wherever you want so gad as curl (the only disadvantage is that you have to install it first, though it is not a big problem because it is a simple bash script).

Is there a way to get a light background on the website? I find it very hard to read with the dark background.

Depending on the background, the default style is not ideal for colorblind users but I finally figured out how to change the style after all these months and hundreds of commands lol.

+1 for using only the standard 16 color ANSI codes and maybe attributes such as "bright" or "dim" in the default case, so that the display naturally adapts to the color theme being used by the terminal, be it light or dark.


The dataset MHL test tank dataset and Jamaica.tar.gz cannot be opened!

The dataset MHL test tank dataset and Jamaica.tar.gz cannot be opened!

Thank you for reaching out about this! I am able to download these links if I copy the link address and paste in the browser. Can you try this and see if you are able to download?
…
On Sat, Mar 4, 2023 at 8:10 PM xln-tj @.> wrote: The dataset MHL test tank dataset and Jamaica.tar.gz cannot be opened! — Reply to this email directly, view it on GitHub <#8>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6GDOCDGLJCC5XOGHFZ2CDW2PRZPANCNFSM6AAAAAAVP3JTIA . You are receiving this because you are subscribed to this thread.Message ID: @.>

Yes, it can be opened, but I have a question, can you tell me the specific environment version of this project, because your version is a bit old, and it does not match the latest version, so I cannot run this project, I hope Thank you very much for your answer!


[BEAM-9341] postcommit xvr flink fix

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @chamikaramj

please run Run XVR_Flink PostCommit and Run XVR_Spark PostCommit

Run XVR_Flink PostCommit

Run XVR_Spark PostCommit

Ready to merge.


Update NPM page to indicate project is no longer maintained

Hi, as you've indicated this project is no longer maintained, could you also update the NPM page to reflect this? Currently the NPM page claims the fork is still maintained, and it features quite highly in the search results when looking for QR code readers for Node: https://www.npmjs.com/package/qrcode-reader
This module cannot correctly parse many QR codes (as indicated in other issues), and I imagine others will make the same mistake as me, losing significant time using the module.
Thanks

I endorse your request.

To anyone that finds this issue and needs another library, I've found jsqr works well.


Logo + site

We should be like all those other cool IRCds and have a logo. I'll look at dis.
And a site later on once I'm more happy with this.

http://oragono.io/
Bit different than most of the other sites I make, but I like how it turned out


Library view into SAS 9.4 extension

Display a panel to view the library allocated through the SAS 9.4 extension, as it is on SAS viya extension.
Not easy to manipulate the data just created into those librairies.

Hey @i0355695! This appears to be a duplicate of https://github.com/sassoftware/vscode-sas-extension/issues/680. This is the next priority on our roadmap, so there should be updates soon.


Login Page Improvement Request

Is your feature request related to a problem? Please describe.
The login page is not working properly. It does not authenticate users correctly, fails to redirect after login, and lacks proper form validation for incorrect inputs.

Describe the solution you'd like
I want the login page to validate inputs before submission, show error messages for failed login attempts, and redirect to the main page upon successful login. I would also like to integrate a backend authentication system using Node.js and MongoDB for secure login.
Describe alternatives you've considered
I have considered implementing third-party authentication services like Firebase or Auth0 but would prefer building the authentication from scratch using a custom backend to better align with my project goals.
Additional context
The login page should include a "Remember Me" option and better UI responsiveness. Adding accessibility features like keyboard navigation would also improve the user experience.
Contributor Information
Please check if you are a contributor from:

[x] GSSoC-ext-YES
[x] Hacktoberfest-YES

@jeevan10017 Could please assign this issue to me under the label of GSSoC-ext and Hacktoberfest.

@samriddhitiwary Integrate it with Firebase, and also with Google authentication feature.

Thank you @jeevan10017  I will start working on it

@jeevan10017 is there any deadline for this submission?

@jeevan10017 is there any deadline for this submission?

No deadline, but finish ASAP.

@jeevan10017 yes I'm working on it

@samriddhitiwary are you working on it?

@jeevan10017 Yes I'm working on it, please give me 1-2 days more

@samriddhitiwary are you working on it?

Yes I am

@jeevan10017 Have you created the Firebase API?

Create it with your own API. We will be changing it later.
Have you worked with creating a firebase earlier?

@jeevan10017 I had done it once while learning ReactJs where they did have a section for Firebase.
Though college commitments have kept me from dedicating my full time, I’m confident that I’ll be able to complete it within 2-3 days.

@samriddhitiwary other people want to contribute to this creating firebase integration who was experienced. If you want any help, I will assign him in this issue. So you both can work on this.

@jeevan10017 I'm confident that I will be able to complete it please just give me time till Monday, if I am not able to do it by then you please do assign the other person also and then we will surely work together.

@jeevan10017 I'm confident that I will be able to complete it please just give me time till Monday, if I am not able to do it by then you please do assign the other person also and then we will surely work together.

Ok go ahead, possible to complete ASAP.

@jeevan10017 Thank you

@jeevan10017 I have implemented the Google Authorization, do I have to also implement the Email and password Authentication?

@samriddhitiwary also work on intake of registration credentials and validation of email/ph no with password in while login login.

@jeevan10017 Can I just Merge the Google Authorization right now and raise separate issue for this.

@jeevan10017 I the Google Authorization is working correctly and the Log In and the Sign-In are working correctly.
I can surely implement the email and the number  Authorization it would be really good if we can raise a separate issue and work on it.

@samriddhitiwary carry on..

@jeevan10017 I'm sorry I did'nt get you

Initiate PR. And create new issue.

@jeevan10017 Thank you

@jeevan10017 I have raised PR please review it the link is below
https://github.com/Open-Code-Crafters/FitFlex/pull/56
If they meet your requirements then could you please also add the labels in PR/MR too

@jeevan10017 ??

@jeevan10017 There was a conflict with my package-lock-json, that's why I took the latest pull today but I a, getting these errors, though the code running is properly in my local machine


Cannot Install, now showing on HA Integrations

Hello,
Just tried to install it and it does not show up on Home Assistant Integrations after reboot, so I cannot configure...
I am using the latest HA version on HassOS.
Thanks,
JS

Solved!
I was installing over android app, i need to force close the app and open so it update the integrations list!
Working now thanks!


Integrate iSDX multi switch concept into the IXP topology

Do we need each logical switch in a topology to be based on actual three switches to support the iSDX inbound, outbound structure?

We will go for a multi table setup for software switches. So only one switch is needed per physical switch.


Auto attributes creation

>>> b = box.Box()
>>> b.o.x = 42
AttributeError: 'Box' object has no attribute 'o'

IMHO this should work, possibly via a subtype (AutoBox) or __init__ keyword arg (auto_attr=True).
Another variant would be OpenBox combined with a close() method – i.e. allow path construction initially, but then switch to default mode (AttributeError) after construction.

I'm personally leaning towards doing keyword arguments, as that would allow for other customization and expansions in the future. I am mulling over how best to name them (so they aren't close to anything someone might have in a dictionary).
Either something like box_auto_attr or _auto_attr. Potentially add a box_auto_default=Box field as well so it's possible to make it more like a true default dict that a user can specify what type of object the default fallback is.
Closing https://github.com/cdgriffith/Box/issues/5 as it was less detailed

Sounds like separation of creating Box variants from using them would be valuable (separate namespaces with no awkward avoidance of overlap). So how about this:
@box.closable
@box.autoattr
class MyClosableAutoBox(Box):
    """Customized ``Box``."""

Chances are you want to use such a beast at several places anyway, and then you'd have to curry the Box construction with those keyword args. :grimacing:
Alas, Python3 only, but you could call the decorators explicitly in Python2.

It's own namespace would be nice and simple, but for https://github.com/cdgriffith/Box/issues/6 need to have some sort of namespace pollution anyways, so I have been working on a way to make it near invisible. https://github.com/cdgriffith/Box/blob/auto_attr/box.py#L269

my_box = Box({"I call Hax!": "totally"}, default_box=True, conversion_box=True)
my_box.i_call_hax
# Out[8]: 'totally'

my_box.sub_box.another_box.boxes_the_whole_way_down = 'Yet another box'
my_box
# Out[10]: <Box: {'I call Hax!': 'totally', 'sub_box': {'another_box': {'boxes_the_whole_way_down': 'Yet another box'}}}>

Could still make it into it's own subclass if those same options will always be repeated (still mulling over just adding a few of these as well for simplicity):
class DefaultBox(Box):
    def __init__(self, *args, **kwargs):
        super(Box, self).__init__(*args, **kwargs)
        self._box_config['default'] = True

Thoughts?

added default_box in 3.0 https://github.com/cdgriffith/Box/commit/6d90e4213365b66585de60676d317a80fe2607bc


Stopped downloading site backup when deleting a user

refs https://github.com/TryGhost/Ghost/issues/15008

Backup process had a slim benefit to keep around. Without it the removal process is much smoother.
The backup still happens on the server side if it's absolutely needed at some point in the future

Codecov Report

Merging #2423 (a16f74d) into main (c573fdf) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2423      +/-   ##
==========================================
- Coverage   40.37%   40.28%   -0.09%
==========================================
  Files         604      604
  Lines       23943    23938       -5
  Branches     4159     4158       -1
==========================================
- Hits         9667     9644      -23
- Misses      14276    14294      +18

Impacted Files
Coverage Δ

app/controllers/settings/staff/user.js
66.37% <100.00%> (+1.00%)
:arrow_up:

app/models/base.js
0.00% <0.00%> (-100.00%)
:arrow_down:

app/components/gh-canvas-header.js
77.77% <0.00%> (-22.23%)
:arrow_down:

app/components/gh-site-iframe.js
34.00% <0.00%> (-16.00%)
:arrow_down:

app/controllers/settings/design/change-theme.js
91.89% <0.00%> (-2.71%)
:arrow_down:

app/components/gh-file-uploader.js
92.30% <0.00%> (-2.31%)
:arrow_down:

app/components/gh-image-uploader.js
92.66% <0.00%> (-1.34%)
:arrow_down:

app/utils/publish-options.js
82.12% <0.00%> (-1.12%)
:arrow_down:

app/controllers/offer.js
44.23% <0.00%> (-0.93%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c573fdf...a16f74d. Read the comment docs.


chore: warn if ADC credentials missing for integration tests

If these credentials are missing, several integration tests will fail.
I've been bitten by this a few times in the past two weeks, and a
warning like this would have helped be debug it quicker.

This change is

This creates a warning in every build, e.g.:
https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/6729/66ebdbfe4b9d6b2856fb6e8963ff6b18661b0978/fedora-34-asan/log-efaee459-9357-4843-b425-ac15ebb7eb42.txt
Step #3: 2021-06-09T15:45:10Z (+18s): WARNING: Integration tests may fail because of missing file: /h/.config/gcloud/application_default_credentials.json
Step #3: 2021-06-09T15:45:10Z (+18s): Fix with: gcloud auth application-default login

I think maybe you want to print this just for interactive builds?

This creates a warning in every build, e.g.:
https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/6729/66ebdbfe4b9d6b2856fb6e8963ff6b18661b0978/fedora-34-asan/log-efaee459-9357-4843-b425-ac15ebb7eb42.txt
Step #3: 2021-06-09T15:45:10Z (+18s): WARNING: Integration tests may fail because of missing file: /h/.config/gcloud/application_default_credentials.json
Step #3: 2021-06-09T15:45:10Z (+18s): Fix with: gcloud auth application-default login

I think maybe you want to print this just for interactive builds?

I wasn't sure if this applied to GCB builds or not. But now that I see that gcb builds do not have this file, I think I'm just going to drop the PR, because it's probably just not worth it.


Include broad .gitignore

Having a broad range of environment-specific stuff is good in my experience. That allows contributors to use whatever tools they want without going through the mess we saw with the .idea/ files. If the Python package is set up properly, the .gitignore won't be included in the PyPI distribution.
In the end, it won't prevent you from git adding files. It just prevents git from suggesting irrelevant files to add.
I read over @PuspenduBanerjee's .gitignore and it looks perfectly good to me. I'd recommend restoring it. Or at the very least find a standard Python-oriented .gitignore from somewhere.

I did add a .gitignore which uses a wildcard to excludes all dot files, except for the two included here.  I copied the technique from a stackoverflow article.  Let me know if that looks about right.

There are many dot files that one typically wants to add to git, e.g. .pre-commit-config.yaml and also many non dots that one wants to exclude, e.g. __pycache__. The minimalist technique is just not very good.

Dot file are hidden files, so excluding them by default seems reasonable.  The package currently includes only one dot file (other than .getignore itself), and like you said it won't prevent you from git adding files.
Other files like pycache can certainly be added to .getignore and I've done so with many of the usual suspects.

Looks much better now, thanks!


Update nf-fltkernel-fltcreatefileex.md

This is a request via Content Idea request 99478 to add this note from FltQueryInformationFile to this function as well.

It’s better to say “do not call with a non null top level IRP”.  If you are calling IoGetTopLevelIrp except in an assert you probably have an architectural issue

@rodwiddowson, I checked with the engineer who asked for the update, and he is fine with using the verbiage you proposed. He would like this text to be updated for the FltQueryInformationFile function as well because that is where he took the text from.

@Cloud-Writer , I was able to get this update made in a private repo along with some other work I was doing, so am just going to close out your PR here. Thanks for flagging this, and thanks to @rodwiddowson for language finesse around top level IRQL.


Timestamp Unit Casts are Unchecked

Describe the bug

Currently some time conversions in arrow-cast do not check for potential overflow

https://github.com/apache/arrow-rs/blob/master/arrow-cast/src/cast.rs#L1685
https://github.com/apache/arrow-rs/blob/master/arrow-cast/src/cast.rs#L1713

They should instead use unary_opt (if safe) or try_unary to return a null or error on overflow.
To Reproduce

Expected behavior

Additional context

label_issue.py automatically added labels {'arrow'} from #3840


deploy: drop custom-server-block and use status_listen

Until Kong 1.4, there didn't exist a way to health-check kong and expose
metrics without also exposing the admin api of kong.
In kong 1.4, a new server KONG_STATUS_LISTEN was added which provides
these capabilities.
This commit removes the reliance on the custom server block that was
provided via a ConfigMap.
With 0.9, the next version of controller, the minimum version of kong
should be 1.4, hence this breaking change.
The error logs have been modified as well to include proxy error logs as
well.

This should be merged after #633


Astronomy 2.3.0 - Casting values

From now I will be releasing one feature per minor version (0.X.0). In Astronomy 2.3.0 I'm going to implement values casting feature. It will allow developers to define casting function for each schema field and perform automatic casting of values coming from form or other data sources.
const User = Class.create({
  name: 'User',
  collection: Users,
  fields: {
    age: {
      type: Number,
      // It's default casting function but it's shown here as an example.
      cast(value) {
        return Number(value);
      }
    }
  }
});

It will automatically cast values like "123" to 123 for fields of the Number type. You will be able to cast values using the set() method.
const user = new User();
user.set(formData, {
  cast: true
});

I also consider implementing automatic casting on save.
const Post = Class.create({
  name: 'Post',
  collection: Posts,
  fields: {
    publishedAt: {
      type: Date,
      // Automatically cast values on the `save()` or `validate()` method call.
      autoCast: true
    }
  }
});

as proposed by @s7dhansh in this #373 issue.
I'm open to discussion about this feature.
If you want to support development of this feature, you can donate on my Patreon page or just create PR :). Thanks!

@s7dhansh @talha-asad I'm working on casting feature and there are several issues. However, right now I'm facing a problem with default String casting function. It looks like:
cast(value) {
  if (isString(value)) {
    return value;
  }
  return String(value);
}

So conversion will look as follow:

123 -> "123"
true -> "true"
new Date() -> "Fri Oct 28 2016 02:20:55 GMT+0200 (CEST)"
new Object() -> "[object Object]"

and as 2 first conversions looks pretty good. Then the last 2 are probably not the best - especially the last one. It might look like not big deal. But accidental wrong assignment might result in properly validated document stored in collection.
I was thinking about turning on casting by default but right now I'm not so sure. What do you think about this problem? How would you solve it?

That is a problematic case. I can't think of anything other than a hard-coded exception for objects, during conversion to String. In such cases the user must manually cast his object (any object, including date, excluding null) before setting/saving.

@s7dhansh There are several things to take into account:

When talking about casting, we probably mean setting values coming from the form.
Values coming from form are mostly plain values like strings, as long as you don't call date.valueAsDate on a date input field.
We should probably exclude casting objects as you said. So the casting functions should look like:

// String
cast(value) {
  if (isString(value) || isObject(value)) {
    return value;
  }
  return String(value);
}
// Number
cast(value) {
  if (isNumber(value) || isObject(value)) {
    return value;
  }
  return Number(value);
}
// Boolean
cast(value) {
  if (isBoolean(value) || isObject(value)) {
    return value;
  }
  else if (isString(value) && value.toLowerCase() === 'false' || value === '0') {
    return false;
  }
  return Boolean(value);
}
// Date
cast(value) {
  if (isNumber(value)) {
    return new Date(value);
  }
  else if (isString(value)) {
    if (/^[0-9]+$/.test(value)) {
      return new Date(parseInt(value, 10));
    }
    else {
      const time = Date.parse(value);
      if (!isNaN(time)) {
        return new Date(time);
      }
    }
  }
  return value;
}

Such casting functions would only cast plain values. Of course developer can still pass custom casting function and cast object if he/she wants to.
The other problem is automatic casting. At the beginning I was agains, later I was for it and right now I'm one more time against :). My current view is: If I would turn on automatic casting by default it could probably break some applications. In deed it would be nice to have automatic casting like this:
doc.set(formData);

But adding one extra line of code shouldn't be a big deal for most people.
doc.set(formData, {
  cast: true
});

Moreover, if you would like to cast values on validation or save operation, you have to explicitly tell Astronomy to do so.
doc.validate({
  cast: true
});
doc.save({
  cast: true
});

It's a common interface that developers will quickly get used to.
There is also a problem with how to treat nested classes. If we have a field address of the Address class type. It should always cast address to Address instance even if cast is set to false. Which looks like inconsistency. So that's why I'm still opened for discussion as I might not see the whole picture.

@jagi Yes excluding object seems good. For Number, I don't think its required though. Those extra timestamp conversion lines are great, I wouldn't have thought of them in the first go.
Automatic casting is a convenience, and since anyways casting is not happening on assignment (if I remember the last discussion correctly), using cast: true is not so bad.
But considering your consistency point, I would suggest: We auto cast, but also have cast: false option in the Class (just like secure: false), which will disable autocast, and would help those marginal applications which may get affected.

When casting Object to String, why not just use JSON representation? Could you use something like JSON.stringify()?

@joefru IMO, it makes not much sense. Why would someone want to store an Object as a String? And if someone does, he should write his own function. Giving an error, seems to be the correct approach, so that accidental saves with bad data do not happen.

JSON.stringify() would work for casting any type to String.  I can't predict why developers would require this functionality, but throwing an error seems harsh when there is a simple, elegant solution for delivering the functionality.

@joefru There were situations when developers accidentally stored objects as JSON strings and they were surprised that Astronomy didn't throw error. So I think it's quite good solution to just throw error. In JavaScript you could actually cast any value to some other plain value but it's not always intended. In most cases it's a result of a bug in a code. In most cases you want to cast plain value to another plain value like: String to Number, or String to Boolean.
@s7dhansh Ok so I will try solution without auto casting. However I will consider adding the top level cast option to the schema, so all field will be casted automatically if set. I will give more details as feature is implemented, so you can test it out and give feedback. I've already implemented most features. I will try doing something tomorrow.

Ok, feature implemented and you can test it out by cloning the feature/casting branch into your local packages directory.
Here are two test files for the cast and merge options, so you can see how to use them:
https://github.com/jagi/meteor-astronomy/blob/feature/casting/test/modules/fields/cast.js
https://github.com/jagi/meteor-astronomy/blob/feature/casting/test/modules/fields/merge.js
I would be glad if you could clone the branch and check if this feature works for you and if you would change or add some feature.

Awesome!
Just checked the tests and code, looks good. Will try to test it over the weekend.

Great! Waiting for feedback :)

I've also added option for casting values on save.
var user = User.findOne();
user.firstName = 123;
user.save(); // Throws validation error
user.save({cast: true}); // Casts fields and does not throw any error

Astronomy 2.3 release

Just converted all my castings from afterInit event to cast and working GREAT! Thank you so much for the fast turnaround and even documentation on this. LOVING Astronomy over SimpleSchema (no offense to that great library).

@zachariahtimothy good to hear that you like it :-).  New features to come soon :-)

@jagi sorry i was not able to take out enough time to test it. still stuck, will do an upgrade and let you know whenever i can. but from the feedback, it looks its working great. kudos!
@zachariahtimothy i am a bit curious, why were you doing casts in afterInit?

@jagi Thanks alot for implementing this. Sorry I have not been very active lately, been a bit over occupied at work these days. Will test this out and get back to you.

@s7dhansh @talha-asad no problem :) just take your time and test it in a free time :). I just wanted to release it. But if there is any bug I can always release bugfix version :). Waiting for feedback :)

I upgraded to the latest, and found this isn't working anymore Geofence.find({}, {fields: {_id: 1}}).fetch()
It works on the previous version.

@talha-asad Hmmm yes it might be a bug in a code. I will take a look at it.

It's very weird, it happens only with that collection at one place. I have no idea why it is generating an error.

@talha-asad I've found a bug. I'm just fixing it. A new version should be available in several minutes.

@talha-asad Ok fixed in 2.3.2 version

That was quick 👍
Was looking at the passed few commits and saw the commit message "renaming helpers back to methods". Should I make this change back in the schema, or is it internal only?

@talha-asad it's internal only :) so you don't have to change anything


Add support for immediate constants for local memory instructions

Currently, the only instruction which supports specifying immediate values via constants is push. This means we can usually use constants for instructions which work with global memory (e.g., mem_load, mem_store) by first doing a push.CONSTand then usingmem_load` etc.. However, we cannot do the same for instructions which work with local procedure memory because these don't take local indexes off the stack.
It would be very helpful for such things as STARK verifier if we enabled support for immediate constants for instructions loc_load, loc_loadw, loc_store, loc_storew (and while at it, we could also add explicit support for mem_* equivalents as well).

Closed by #826.


【HELP】Please！ How to set decimal point accuracy?

Issue Description
my code：
 val ddds = Nd4j.create(Array[Double](0.22222222222d), Array[Int](1,1))        println(ddds)
result:
0.22
it is only two decimal point!

It's just print truncation. Internally it's still float/double/float16, whatever you uses in your session.

@raver119  Thanks!

@raver119
How to print it completely?All decimal points？

You can do that manually, using NDArrayStrings class. It allows you to tweak format.


Likelihood function

Currently fails with:
In [2]: like = likelihood.Likelihood()
TypeError                                 Traceback (most recent call last)
 in
----> 1 like = likelihood.Likelihood()
~/codes/FastPMRunner/likelihood.py in init(self)
129         self.response_matrix = np.zeros((self.ksize,self.Nmax))
130         for i in range(self.Nmax):
--> 131             tmp_resp0 = self.window_response(i)
132             self.response_matrix[:,i] = tmp_resp0[0]
133
~/codes/FastPMRunner/likelihood.py in window_response(self, k_index)
168         r0t2 = self.rmin**(-self.etamR[~f])[:,np.newaxis]
169
--> 170         cmsymr0[f] = r0t1np.conjugate(cmr0[-arr_i[f] + Nmax//2])
171         cmsymr0[~f] = r0t2 cmr0[arr_i[~f] - Nmax//2]
172
TypeError: NumPy boolean array indexing assignment requires a 0 or 1-dimensional input, input has 2 dimensions
In [3]: %debug

/home/spb/codes/FastPMRunner/likelihood.py(170)window_response()
168         r0t2 = self.rmin**(-self.etamR[~f])[:,np.newaxis]
169
--> 170         cmsymr0[f] = r0t1np.conjugate(cmr0[-arr_i[f] + Nmax//2])
171         cmsymr0[~f] = r0t2 cmr0[arr_i[~f] - Nmax//2]
172

Ok, that kind of works for me - in that it runs init() without errors. I cannot actually get fastpm to work on either of my linux machines, so I can't test it further. Could you give it a try?

Actually, why don't we switch to using the pure python version of fastpm? That is pip-installable and likely to be more stable. Plus we don't have to do the writing and reading stuff. There is an example script here:
https://github.com/MP-Gadget/MP-Gadget/blob/master/tools/make_HI_reionization_table.py

This version works for me!

Thanks for the efforts! I will start testing it! I will delete my PR in your repo since that's obsolete.
Do we still plan for using the python version of fastpm?

No, I think that the C version is fine now Yu fixed it.

Thanks!


[Question] no mm_projector.bin after finetune.sh

Question
checkpoint files after finetune.sh (full finetune without lora):
config.json	pytorch_model-00001-of-00002.bin  pytorch_model.bin.index.json	tokenizer_config.json  trainer_state.json
generation_config.json	pytorch_model-00002-of-00002.bin  special_tokens_map.json	tokenizer.model        training_args.bin
there is no mm_projector.bin, but I see projector.bin is in you release checkpoint(https://huggingface.co/liuhaotian/llava-v1.5-7b/tree/main). Is there something I may have misunderstood?

@gd2016229035 did you figure this out?

@gd2016229035 did you figure this out?

maybe it is already in weights, i find model.mm_projector.0.bias in pytorch_model.bin.index.json. But there is also  model.vision_tower in this file, which make me confused that vision_tower is always freeze in training

I have same problem - on inference, it seems a file `mm_projector.bin' is expected
but the output of the fine-tuning does not include that file.

I still do not know how to fine-tune v1.6 - BUT this fork shows how to fine-tune v1.5
https://github.com/mrseanryan/finetune_LLaVA

For me, the problem was using v1.6 LLaVA source code with v1.5 base model.
I still do not know how to fine-tune v1.6 - BUT this fork shows how to fine-tune v1.5
https://github.com/mrseanryan/finetune_LLaVA

The checkpoint folder should contain "lora" and "llava".

checkpoint folder name

For me, the problem was using v1.6 LLaVA source code with v1.5 base model.
I still do not know how to fine-tune v1.6 - BUT this fork shows how to fine-tune v1.5
https://github.com/mrseanryan/finetune_LLaVA

The checkpoint folder name should contain "lora" and "llava".

I see - how do you specify the checkpoint folder name ?

checkpoint folder name

For me, the problem was using v1.6 LLaVA source code with v1.5 base model.
I still do not know how to fine-tune v1.6 - BUT this fork shows how to fine-tune v1.5
https://github.com/mrseanryan/finetune_LLaVA

The checkpoint folder name should contain "lora" and "llava".

I see - how do you specify the checkpoint folder name ?

by --output_dir

Hi, how do you know the training was effecitve? Did you use the default training setting? I LoRA with default parameters and basically no improvement.

Ive heard LlLaVA can work better if image is preprocessed into relevant segments, for example an object detector or element detector.
otherwise perhaps need more data?


Adding gdb, gdbserver, gcc, make, cmake

Added dev tools, for gdb, gdb & gdbserver appear to work, so does make & cmake but if gcc is needed, it needs another look!

@mistyron I didn't mean to merge this to develop

@mistyron It is still WIP


Bugfix: Health check mode omitempty

Signed-off-by: yue9944882<EMAIL_ADDRESS>
otherwise, after marshalling a empty healthcheck mode (which should be logically defaulted to Lease) to yaml, the mode field will become an empty string which constantly fails CRD validation.
/cc @qiujian16 @skeeey
              },
              Status: "Failure",
              Message: "ManagedClusterAddOn.addon.open-cluster-management.io \"addon-n86c2\" is invalid: status.healthCheck.mode: Unsupported value: \"\": supported values: \"Lease\", \"Customized\"",

/approve
/lgtm


Swift Functions don't work (ErrImagePull)

I installed this on a 3.9.14 OpenShift cluster and it works just fine. Except for Swift functions. I keep getting an ErrImagePull error when the pod tries to start. I tried importing the image but that didn't work either.
It is looking for image 'action-swift-3:whisky'.
What needs to be done to fix this?

Thanks @jcrossley3. Just tried it and it seems to work just fine now. :-) Now the first pod deploy takes too long to run the function. But I guess after a few invocations the image will be on all nodes and that won't be an issue anymore.


GHC 8.0 compatibility

https://ghc.haskell.org/trac/ghc/wiki/Migration/8.0#Moreconservativeuseofsuperclassconstraintswhilesolving
https://ghc.haskell.org/trac/ghc/ticket/11762

Really appreciate it - thanks!