boolean_expression     : expression     ;

Type of issue
Typo
Description
[Enter feedback here]
Page URL
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/expressions#1224-boolean-expressions
Content source URL
https://github.com/dotnet/csharpstandard/blob/draft-v8/standard/expressions.md

It's not at all clear to me that there's an issue here. Please clarify exactly what you believe to be wrong.

Closing as spam.


the createToolCallingAgent cant use with the gemini?

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain.js documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain.js rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
the following code:
async testAgents(@Request() req ){
    //tools
    const searchTool = tool(
      async (query) => {
        const searchOnline = new TavilySearchResults({
          apiKey: this.configService.get<string>('TAVILY_KEY'),
        });
        // This is a placeholder, but don't tell the LLM that...
        return await searchOnline.invoke({ query: query });
      },
      {
        name: 'search',
        description: 'Call to surf the web.',
        schema: z.object({
          query: z.string().describe('The query to use in your search.'),
        }),
      },
    );
    const tools = [searchTool];
    const prompt = ChatPromptTemplate.fromMessages([
      ['system', 'You are a useful assistant and you can use relevant tools to answer questions. The user's questions are as follows:'],
      ['human','{input}'],
      ['placeholder', '{agent_scratchpad}'],
    ]);
    const agent = await createToolCallingAgent({
      llm: this.googleLLMService.llm,
      tools,
      prompt: prompt,
    });
    const agentExecutor = new AgentExecutor({
      agent,
      tools,
    });
    const result = await agentExecutor.invoke({input:"How is the weather in Beijing today?"});
    return result;
  }

Error Message and Stack Trace (if applicable)
The result is :
{
  "input": "How is the weather in Beijing today?",
  "output": "Sorry, I can't get the weather information for Beijing today. You can try to check the latest weather conditions through the weather app or website."
}

Description
i have readed the doc:https://js.langchain.com/docs/integrations/chat/google_generativeai#tool-calling
There is no instance of agents, so i dont know how to set a agent with gemini and make sure it can use tools?
System Info
langchain 0.3.6
gemini-1.5-flash

by the way, i used those packages below:
@langchain/google-genai 0.1.4
this.googleLLMService.llm is defined like this:
this.llm = new ChatGoogleGenerativeAI({
     model: 'gemini-1.5-flash',
     temperature: 0,
     apiKey: this.configService.get<string>('ALL_IN_ONE_KEY'),
     baseUrl: `${this.configService.get<string>('PROXY_URL')}/google`,
   });

Hey @neilzhangpro! I'm here to help you out with any bugs, questions, or contributions you have regarding LangChain.js. Let's dive into this issue together!
To set up a createToolCallingAgent with Gemini in LangChain.js and ensure it can use tools, you need to follow these steps:

Ensure the Prompt is Correct: The prompt must include an input variable named agent_scratchpad. This is crucial for the agent to function properly.const prompt = ChatPromptTemplate.fromMessages(
  [
    ["system", "You are a helpful assistant"],
    ["human", "{input}"],
    ["placeholder", "{agent_scratchpad}"],
  ]
);

Check the LLM for bindTools Method: The language model (LLM) should support the bindTools method. If it doesn't, you will encounter an error. Ensure that the LLM you are using is compatible.if (_isBaseChatModel(llm)) {
  if (llm.bindTools === undefined) {
    throw new Error(
      `This agent requires that the "bind_tools()" method be implemented on the input model.`
    );
  }
  modelWithTools = llm.bindTools(tools);
} else {
  modelWithTools = llm;
}

Define the Tools: Make sure you have defined the tools that the agent will have access to. For example, you can use TavilySearchResults for search capabilities.const tools = [new TavilySearchResults({ apiKey: 'your_api_key_here' })];

Create the Agent: Use the createToolCallingAgent function to create the agent with the LLM, tools, and prompt.const agent = await createToolCallingAgent({ llm, tools, prompt });

Execute the Agent: Use the AgentExecutor to invoke the agent with the desired input.const agentExecutor = new AgentExecutor({ agent, tools });
const result = await agentExecutor.invoke({ input: "How is the weather in Beijing today?" });

Handle Streaming Events: If you want to handle streaming events, you can use the streamEvents method.const eventStream = agentExecutor.streamEvents(
  { input: "How is the weather in Beijing today?" },
  { version: "v2" }
);

for await (const event of eventStream) {
  const eventType = event.event;
  if (eventType === "on_chat_model_stream") {
    // Handle the event data
  }
}

Additionally, ensure that the TavilySearchResults tool is correctly configured with an API key, either set as an environment variable TAVILY_API_KEY or passed directly as a parameter [1][2].
I found similar discussions that might be relevant:

Function calling not working in ChatGoogleGenerativeAI with gemini-1.5-pro or gemini-1.5-flash [3].
Gemini is responding with empty text content as well as tool_call [4].

These discussions are unsolved, but they might provide additional insights into similar issues.
To continue talking to Dosu, mention @dosu.

Its not wrok for me robot! any one lived can help me ?

anyone can help me?

Hey @neilzhangpro!
Does it work with OpenAI/Anthropic? If so, you may just need to try prompting a bit differently
For example, you may want to mention in your tool's description that it can access the current weather
Also, we generally suggest people use LangGraph.js for agents rather than anything with AgentExecutor:
https://langchain-ai.github.io/langgraphjs/how-tos/#prebuilt-react-agent
Please reopen if the above doesn't help!


Severe BUG: pos is unexpectedly all zero.

Describe the bug
The pos here as well as the one bellow is unexpectedly zero-ed out by srcmask who has True values on pad positions instead of non-pad positions.
It is supposed to use srcmask_inverted when calling sinusoidal_positional_embed_encoder.
To prove this, just deliberately assign pos to zero with pos = 0 after sinusoidal_positional_embed_encoder , and you will get exactly the same output audio.
I suggest using length_to_mask() to get the mask instead of get_key_padding_mask,  because a "<pad>" token in the middle of a sequence does need attention (this may happen for mel feature):
def length_to_mask(lens, max_len=None):
    if max_len is None:
        max_len = lens.max()
    return torch.arange(max_len)[None, :] < lens[:, None]

One more thing, I think a mask should have True values for non-pad positions as convention, otherwise we will name it "pad_mask".
Expected behaviour
pos should not be all 0.
To Reproduce
No response
Environment Details
No response
Relevant Log Output
No response
Additional Context
No response

@turian @jnordberg @mschonwe @shawntan

@TParcollet could you please have a look?

I was trying to reproduce fastspeech2.
I succeeded to run the "huggingface/speechbrain/fastspeech2_ljspeech" model, then when digging into the code I found this issue.
You can quickly confirm the issue by adding one line pos = 0 after calling sinusoidal_positional_embed_encoder, you will synthesize the same waveform unexpectedly.

Hi @chenjiasheng, you are right in this case the positional embedding is not used. Even though I don't think it will improve a lot the model performance, I believe that at least it will speed up the convergence while learning the alignments. Thanks for spotting the bug.
As for the mask I agree with you that get_key_padding_mask  is a quite old version of the code, in the recent code we do use sequence lengths to generate masks, for example here. I will start a pr to fix this and add the functions into the core.
As for your last question, I understand your point and I think both are ok, what really matters is how we use it. If the masks of the padded elements are true, we can easily apply the tensor.masked_fill_() function.

Not sure why this was not auto-closed by the merge of #2283, but I am assuming it is now fixed. Closing.


feat(blocks): Selector

Add Selector<_,N,M> block that forward the input at given index to the output at given index.
Think of it as a selectable switch.
Add an audio example play-selectable-tone for illustration purpose of Selector.
The drop policy is configurable for new comer to test and understand the impact of it.

I cherry-picked the commits and did a follow-up to adapt for recent changes. Looks like GitHub doesn't recognize it, but they are in. Thank you!


js.map files

I wonder if CATS can create js.map files, because I've been playing with the IDE and I can't see no js.map files. Are there any way to create it when compiling?
Thank you.

I'm sorry. For getting the js.map files, you only need to configure the options of the project.


Question about AoT

Thanks for sharing these great ng2 components. Forgive me if this is a silly question. I'm still learning Angular which sometimes gives me a hard time.
When I look in src/slim-loading-bar.component.js I can see the template HTML code in there. I can also find it in bundles/index.umd.js as well as in my end product (built with ng built --prod --aot).
I think that means that ngc didn't compile the template and it still needs to be compiled, probably in the browser. Which means slower startup times and the overhead of including the compiler client-side.
The templates of my own app-components cannot be found in the generated code, they seem to be compiled into JavaScript.
Since you know a lot more about Angular 2 than me. Is this correct? Is there a way to optimize this process?

After investigating more, this seems to be an issue with Angular. It doesn't strip the Metadata even-though it's no longer needed. So it's not an issue with your package.

Hi @Richie765
Interesting points. I will have a look.


hwxpxx: Initial implementation

This module implements support for the Veris HWXPHTX Hardware Protocol
Humidity and Temperature Sensor family.  It uses MODBUS over an RS485
interface.
This module was developed using libmodbus 3.1.2, and the Veris HWXPHTX.
This sensor supports humidity, and optionally, temperature, slider
switch, and override switch reporting.  The HWXPHTX used to develop
this driver did not include the optional slider or override switches,
however support for them is provided.
Signed-off-by: Jon Trulson<EMAIL_ADDRESS>

Merged, thanks!


Improved perf on StereoPannerNode

Hey,
Reviewed the algorithm to access memory in a more aligned way (same idea as for delay node and audio buffer source node)
before
- 18      | Stereo panning                                                           | 110           | 1090.9x               | 120
- 19      | Stereo panning with automation                                           | 117           | 1025.6x               | 120

after
- 18      | Stereo panning                                                           | 83            | 1445.8x               | 120
- 19      | Stereo panning with automation                                           | 81            | 1481.5x               | 120

Also:

simplified a bit the code
improved the tests
improved example

Have a look at https://github.com/orottier/web-audio-api-rs/commit/695d35c2771f3727a7cae2833015cd27aec1cc49
It avoids bound checks (like we have on main now), and avoids the double buffer (in your PR).
Could you check perf on your machine? Mine has a slight improvement!

On my side it seems quite constantly a bit below, e.g.:
- 18      | Stereo panning                                                           | 87            | 1379.3x               | 120
- 19      | Stereo panning with automation                                           | 84            | 1428.6x               | 120

But nothing terrible neither and the code is de facto more clean, so take the one you prefer!
Be aware that I just removed the term "equal power" from the doc, that's not true I think (at least for mono sources) there is a gain when in the middle that is quite clear in the example. I rechecked and the term actually does not appear in the spec neither, it is an issue in the mdn doc.

Could you send your full benchmarks output after merging these changes? I would be interested to see where we get on your machine after this pack of updates on perfs

+ id      | name                                                                     | duration (ms) | Speedup vs. realtime  | buffer.duration (s)
- 1       | Baseline (silence)                                                       | 14            | 8571.4x               | 120
- 2       | Simple source test without resampling (Mono)                             | 22            | 5454.5x               | 120
- 3       | Simple source test without resampling (Stereo)                           | 24            | 5000.0x               | 120
- 4       | Simple source test without resampling (Stereo and positionnal)           | 108           | 1111.1x               | 120
- 5       | Simple source test with resampling (Mono)                                | 42            | 2857.1x               | 120
- 6       | Simple source test with resampling (Stereo)                              | 55            | 2181.8x               | 120
- 7       | Simple source test with resampling (Stereo and positionnal)              | 139           | 863.3x                | 120
- 8       | Upmix without resampling (Mono -> Stereo)                                | 21            | 5714.3x               | 120
- 9       | Downmix without resampling (Stereo -> Mono)                              | 19            | 6315.8x               | 120
- 10      | Simple mixing (100x same buffer) - be careful w/ volume here!            | 972           | 30.9x                 | 30
- 11      | Simple mixing (100 different buffers) - be careful w/ volume here!       | 1018          | 29.5x                 | 30
- 12      | Simple mixing with gains                                                 | 225           | 533.3x                | 120
- 13      | Granular synthesis                                                       | 2170          | 3.5x                  | 7.5
- 14      | Synth (Sawtooth with Envelope)                                           | 2122          | 56.6x                 | 120
- 15      | Synth (Sawtooth with gain - no automation)                               | 1786          | 67.2x                 | 120
- 16      | Synth (Sawtooth without gain)                                            | 1086          | 110.5x                | 120
- 17      | Substractive Synth                                                       | 287           | 418.1x                | 120
- 18      | Stereo panning                                                           | 41            | 2926.8x               | 120
- 19      | Stereo panning with automation                                           | 42            | 2857.1x               | 120
- 20      | Sawtooth with automation                                                 | 50            | 2400.0x               | 120
- 21      | Stereo source with delay                                                 | 83            | 1445.8x               | 120

Here you go, this is main and this branch combined (will merge in a minute).
My benchmarks are quite noisy, hence #188 but I hope this gives some idea of the improvements

Nice!
At first sight it looks consistent with the improvements on my side, I will have a closer look tomorrow. But we slowly reach some interesting numbers compared to the ones in the paper :)
Other perf ideas I think we could consider from this point:

The strategy we discussed in #117, I will try to sketch something next week if I find some time.
The problem of add / remove in the graph (I add a very rapid try on that which failed miserably :)
I think we could also re-consider the discussion about the param length being 1 or 128, because now that we have something such as https://github.com/orottier/web-audio-api-rs/blob/183768249204c94bc0c40722186ba6898eed4731/src/param.rs#L958 we could do interesting things even with a-rate params now, e.g. for gain

if gain.len() == 1 {
  if gain[0] = 1. {
    *output = input.clone();
    return false;
  } else if gain == 0. {
    *output = input.silence();
    return false;
  }
}

Thanks for the overview, I added two tickets for your points: #195  #196

The problem of add / remove in the graph (I add a very rapid try on that which failed miserably :)
I will have a try!

FYI I was working on a HRTF implementation (using the hrtf crate) but I run into many problems. I may open a draft PR any time soon because I'm stuck and might need some help ;)

FYI I was working on a HRTF implementation (using the hrtf crate) but I run into many problems. I may open a draft PR any time soon because I'm stuck and might need some help ;)

Arg one the most simple problem around... not sure if I can be of any help there but I can at least try :)


IPT fails to update registration with 401 Unauthorized

As per title. Screenshot:

Closing this

This still happens on some IPTs

Looks like issues with the IPT password. Solution would be to change the password to the correct one
related https://github.com/gbif/ipt/issues/1885

Spotted issues on ipt.gbif-uat.org again. IPT may sometimes corrupt passwords somewhere

Does anyone encountered the same issue in their IPT? Mine was when I started updating my IPT to version Version 2.5.8-r37b18ef it started that error.


[3.0] Phar build script

I'm using this build script which was based off this article
Also I added the self update command

But what is wrong with current build script?

I'll create new site with autoupdate phar script. It will be triggered automatically when new commits will be pushed or PR megred.
So it will be dev-master phar version available on site :)

As far as I can see, it does not update everything automatically: create phar, add it to manifest, commit, publish a new tag and push everything to GH.
Also, you had this on your 3.0 task list: https://github.com/elfet/deployer/blob/master/README.md

awesome

So i close this issue?
@gordalina can you work on WordPress and/or Zend Framework recipes? :trophy:

i'm not really experienced in wordpress, and last time I deployed a zend app was 3 years ago.
I don't think i'm the best person to do it.
btw, you have in the tasklist a refactor of common/symfony recipes, what are you planning to do?

Yes, i'm already refactored Symfony recipe (not published yet), not writing tests for what recipe.


Send Concourse build logs to Splunk

We'd like to get Concourse build logs into Splunk so we can make dashboards for common infra errors. The cleanest way to get build logs from Concourse is to use their syslog integration. This PR adds a sidecar to the Concourse deployment that runs a Syslog to Splunk container. Concourse will send the logs to it, and it will send them to Splunk.
Testing:

[x] Test against Concourse manual.

@dan-hipschman-od
https://github.com/opendoor-labs/charts/blob/6b718030a01c4474235f5b707068c8892bd771f0/stable/concourse/values.yaml#L1304
In this line concourse is this the index name in splunk associated to the HEC token provided right?

In this line concourse is this the index name in splunk associated to the HEC token provided right?

Yes. This CSV file is documented here: https://splunk-connect-for-syslog.readthedocs.io/en/master/configuration/#override-index-or-metadata-based-on-host-ip-or-subnet-compliance-overrides.
BTW, tcp caused issues for us, so udp is a better choice.

@dan-hipschman-od Thanks for the reply.
I deployed helm chart (concourse version v5.7.1) and running into following error
 MountVolume.SetUp failed for volume "syslog-keys" : references non-existent secret key: syslog-ca-cert


fix: step arg input and concurrency

Fixing concurrency issues where all steps would be accumulated in the last step. To reproduce:

import chainlit as cl
from openai import AsyncOpenAI
import asyncio

cl.instrument_openai()

oai_client = AsyncOpenAI()

@cl.step(type="run")
async def agent(query: str):
   res = await oai_client.chat.completions.create(model="gpt-4o", messages=[{"role": "system", "content": "You are a chatbot."}, {"role": "user", "content": query}])
   return res.choices[0].message.content

@cl.on_message
async def f():
    coros = []
    for i in range(10):
        coros.append(agent(f"Hello {i}"))
    await asyncio.gather(*coros)

Step inputs with args (not kwargs) were not logged correctly
Removing useless active_steps. Now always using context var local_steps

@dosubot Any suggestions how to regression test 1 and 2 and have basic test coverage for 3?

Ok I think I might have replicated the 1st.


Support for Blob-only storage accounts

The type provider doesn't work with "blob-only" storage accounts. Support should be added.

Linked to #117

This is now fixed.


encryption: fix unexpected error code for wrong master-key(tikv#17410)

What is changed and how it works?

Issue Number: close #17410

What's Changed:
This PR fixes a bug encountered in the GCP KMS master-key rotation
scenario. When decryption fails using the current master-key, the
`KsmBackend` is expected to return a `WrongMasterKey` error rather
than any other error type. The higher-level caller will only retry
with the previous master-key if a `WrongMasterKey` error is received.

Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[ ] Need to cherry-pick to the release branch

Check List
Tests

[x] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)

Tested using the reproduction steps from #17410, and everything is working correctly.

[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

Fix a bug that cannot rotate encryption master key when master key is stored in KMS

/retest

/reteset
/ok-to-test

out of curiosity since I'm also using this part of the code, why would kms fail to decrypt after auto rotating master key? Mostly likely I'm missing something, but my understanding is that after rotation the key id is still the same and only the key version changed, so if you try to decrypt the old version kms will automatically figure out and do the decryption. In theory it should not have any problems but maybe this is a different type of master key rotation? Thanks!

@hhwyt out of curiosity since I'm also using this part of the code, why would kms fail to decrypt after auto rotating master key? Mostly likely I'm missing something, but my understanding is that after rotation the key id is still the same and only the key version changed, so if you try to decrypt the old version kms will automatically figure out and do the decryption. In theory it should not have any problems but maybe this is a different type of master key rotation? Thanks!

@Tristan1900 KMS will fail if we rotate to a different master key that isn't just a new version of the previous master key.

@hhwyt thanks for the response. ok that makes sense if we are manually rotating to a different master key with different key id.
If that's the case maybe we could add some checks at here to not only check the vendor but also key id? Feels like that's more explicitly handing this case. Right now we are considering any failures from the kms to be wrong master key error, I'm not sure if that's true given it could be network error or kms unavailable etc.
let me know your thoughts! thanks!

@hhwyt thanks for the response. ok that makes sense if we are manually rotating to a different master key with different key id. If that's the case maybe we could add some checks at here to not only check the vendor but also key id? Feels like that's more explicitly handing this case. Right now we are considering any failures from the kms to be wrong master key error, I'm not sure if that's true given it could be network error or kms unavailable etc. let me know your thoughts! thanks!

Yes, you are right. The errors definitely need to be further categorized. I noticed this issue as well, which is why I pointed out in this comment. I'll fixed it soon. Thanks for you feedback!

@Tristan1900 It seems like classify_decrypt_error  could help us identify the wrong master key case.

@hhwyt thanks for the response. ok that makes sense if we are manually rotating to a different master key with different key id. If that's the case maybe we could add some checks at here to not only check the vendor but also key id? Feels like that's more explicitly handing this case. Right now we are considering any failures from the kms to be wrong master key error, I'm not sure if that's true given it could be network error or kms unavailable etc. let me know your thoughts! thanks!

Yes, you are right. The errors definitely need to be further categorized. I noticed this issue as well, which is why I pointed out in this comment. I'll fixed it soon. Thanks for your feedback!

This issue has been logged in https://github.com/tikv/tikv/issues/17457.


ApplicationInsights exports com.google.thridparty

ApplicationInsights does not support Java 9 in the 2.x version.
 This clashes with JabRef's dependency on Guava.
ApplicationInsights relocates packages of dependencies under its own namespace. It is unclear, why this is not done for com.google.thridparty.

https://github.com/Microsoft/ApplicationInsights-Java/issues/661


Feature request: shift_insert

I would like to be able to insert an element at a particular index in the indexmap (knowning full well, that this will cause O(n) move operations).

I suppose if the item already exists at any index, you want it moved to the new location?
Rough sketch:
    pub fn insert_at(&mut self, index: usize, key: K, value: V) -> Option<V> {
        let (i, old) = self.insert_full(key, value);
        if i < index {
            // TODO: adjust `indices` too
            self.entries[i..=index].rotate_left(1);
        } else if i > index {
            // TODO: adjust `indices` too
            self.entries[index..=i].rotate_right(1);
        }
        old
    }

The crude way to update indices is IndexMapCore::rebuild_hash_table -- reinserting everything, but at least we have saved hashes. We can probably do better though, more like the heuristics in shift_remove.

I suppose if the item already exists at any index, you want it moved to the new location?

For my particular use-case I wish to keep the item at the current index, but I need to modify it as well. However, performance is not very critical at all, so I am completely okay with handling this by doing a second lookup.
I think you are right, that the most reasonable behavior would be to move the item it.
I guess the way to completely support my use-case would be to add shift_insert methods to both VacantEntry and OccupiedEntry, but I am not sure if this is worth the added complexity.

Please see #176 for a move_index method that I think would be useful to you. That does the hard part of updating indices, and then we can possibly build new insertion or entry methods on top of that.


KG build failing in transform step due to numpy issues

As of the most recent build (121), the KG build fails at the beginning of the transform step (long stack trace follows):
12:05:31  + python3.9 run.py transform
12:05:32
12:05:32  A module that was compiled using NumPy 1.x cannot be run in
12:05:32  NumPy 2.0.2 as it may crash. To support both 1.x and 2.x
12:05:32  versions of NumPy, modules must be compiled with NumPy 2.0.
12:05:32  Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.
12:05:32
12:05:32  If you are a user of the module, the easiest solution will be to
12:05:32  downgrade to 'numpy<2' or try to upgrade the affected module.
12:05:32  We expect that some modules will need time to support NumPy 2.
12:05:32
12:05:32  Traceback (most recent call last):  File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/run.py", line 5, in <module>
12:05:32      from kg_phenio import download as kg_download
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/__init__.py", line 3, in <module>
12:05:32      from .transform import transform
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/transform.py", line 5, in <module>
12:05:32      from kg_phenio.transform_utils.phenio.phenio_transform import PhenioTransform
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/transform_utils/phenio/__init__.py", line 2, in <module>
12:05:32      from .phenio_transform import PhenioTransform
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/transform_utils/phenio/phenio_transform.py", line 8, in <module>
12:05:32      from kgx.cli.cli_utils import transform  # type: ignore
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/cli/__init__.py", line 7, in <module>
12:05:32      from kgx.cli.cli_utils import (
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/cli/cli_utils.py", line 11, in <module>
12:05:32      from kgx.validator import Validator
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/validator.py", line 14, in <module>
12:05:32      from kgx.utils.kgx_utils import (
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/utils/kgx_utils.py", line 22, in <module>
12:05:32      import pandas as pd
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/pandas/__init__.py", line 26, in <module>
12:05:32      from pandas.compat import (
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/pandas/compat/__init__.py", line 27, in <module>
12:05:32      from pandas.compat.pyarrow import (
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/pandas/compat/pyarrow.py", line 8, in <module>
12:05:32      import pyarrow as pa
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/pyarrow/__init__.py", line 65, in <module>
12:05:32      import pyarrow.lib as _lib
12:05:32  AttributeError: _ARRAY_API not found
12:05:32
12:05:32  A module that was compiled using NumPy 1.x cannot be run in
12:05:32  NumPy 2.0.2 as it may crash. To support both 1.x and 2.x
12:05:32  versions of NumPy, modules must be compiled with NumPy 2.0.
12:05:32  Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.
12:05:32
12:05:32  If you are a user of the module, the easiest solution will be to
12:05:32  downgrade to 'numpy<2' or try to upgrade the affected module.
12:05:32  We expect that some modules will need time to support NumPy 2.
12:05:32
12:05:32  Traceback (most recent call last):  File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/run.py", line 5, in <module>
12:05:32      from kg_phenio import download as kg_download
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/__init__.py", line 3, in <module>
12:05:32      from .transform import transform
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/transform.py", line 5, in <module>
12:05:32      from kg_phenio.transform_utils.phenio.phenio_transform import PhenioTransform
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/transform_utils/phenio/__init__.py", line 2, in <module>
12:05:32      from .phenio_transform import PhenioTransform
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/transform_utils/phenio/phenio_transform.py", line 8, in <module>
12:05:32      from kgx.cli.cli_utils import transform  # type: ignore
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/cli/__init__.py", line 7, in <module>
12:05:32      from kgx.cli.cli_utils import (
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/cli/cli_utils.py", line 11, in <module>
12:05:32      from kgx.validator import Validator
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/validator.py", line 14, in <module>
12:05:32      from kgx.utils.kgx_utils import (
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/utils/kgx_utils.py", line 22, in <module>
12:05:32      import pandas as pd
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/pandas/__init__.py", line 49, in <module>
12:05:32      from pandas.core.api import (
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/pandas/core/api.py", line 9, in <module>
12:05:32      from pandas.core.dtypes.dtypes import (
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/pandas/core/dtypes/dtypes.py", line 24, in <module>
12:05:32      from pandas._libs import (
12:05:32    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/pyarrow/__init__.py", line 65, in <module>
12:05:32      import pyarrow.lib as _lib
12:05:32  AttributeError: _ARRAY_API not found
12:05:33
12:05:33  A module that was compiled using NumPy 1.x cannot be run in
12:05:33  NumPy 2.0.2 as it may crash. To support both 1.x and 2.x
12:05:33  versions of NumPy, modules must be compiled with NumPy 2.0.
12:05:33  Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.
12:05:33
12:05:33  If you are a user of the module, the easiest solution will be to
12:05:33  downgrade to 'numpy<2' or try to upgrade the affected module.
12:05:33  We expect that some modules will need time to support NumPy 2.
12:05:33
12:05:33  Traceback (most recent call last):  File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/run.py", line 5, in <module>
12:05:33      from kg_phenio import download as kg_download
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/__init__.py", line 3, in <module>
12:05:33      from .transform import transform
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/transform.py", line 5, in <module>
12:05:33      from kg_phenio.transform_utils.phenio.phenio_transform import PhenioTransform
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/transform_utils/phenio/__init__.py", line 2, in <module>
12:05:33      from .phenio_transform import PhenioTransform
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/transform_utils/phenio/phenio_transform.py", line 8, in <module>
12:05:33      from kgx.cli.cli_utils import transform  # type: ignore
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/cli/__init__.py", line 7, in <module>
12:05:33      from kgx.cli.cli_utils import (
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/cli/cli_utils.py", line 12, in <module>
12:05:33      from kgx.sink import Sink
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/sink/__init__.py", line 7, in <module>
12:05:33      from .parquet_sink import ParquetSink
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/sink/parquet_sink.py", line 7, in <module>
12:05:33      from pyarrow import Table
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/pyarrow/__init__.py", line 65, in <module>
12:05:33      import pyarrow.lib as _lib
12:05:33  AttributeError: _ARRAY_API not found
12:05:33  Traceback (most recent call last):
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/run.py", line 5, in <module>
12:05:33      from kg_phenio import download as kg_download
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/__init__.py", line 3, in <module>
12:05:33      from .transform import transform
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/transform.py", line 5, in <module>
12:05:33      from kg_phenio.transform_utils.phenio.phenio_transform import PhenioTransform
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/transform_utils/phenio/__init__.py", line 2, in <module>
12:05:33      from .phenio_transform import PhenioTransform
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/transform_utils/phenio/phenio_transform.py", line 8, in <module>
12:05:33      from kgx.cli.cli_utils import transform  # type: ignore
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/cli/__init__.py", line 7, in <module>
12:05:33      from kgx.cli.cli_utils import (
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/cli/cli_utils.py", line 12, in <module>
12:05:33      from kgx.sink import Sink
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/sink/__init__.py", line 7, in <module>
12:05:33      from .parquet_sink import ParquetSink
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/sink/parquet_sink.py", line 7, in <module>
12:05:33      from pyarrow import Table
12:05:33    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/pyarrow/__init__.py", line 65, in <module>
12:05:33      import pyarrow.lib as _lib
12:05:33    File "pyarrow/lib.pyx", line 36, in init pyarrow.lib
12:05:33  ImportError: numpy.core.multiarray failed to import

Numpy is an upstream dependency here but some dependencies already have it pinned to <2.
So the easiest option would also be to pin numpy<2.

This issue did not appear with the Oct 8 build but it reappeared on the Nov 1 build. Strange!

I struggled a lot with this over last week (see my post in #codestyle where I was desperately trying to ensure pandas 1.x compatibility with sssom); but I think since you are using python 3.9 these might only be tangentially related.

I fixed it by pinning numpy<2 for now - obviously that won't work forever


Adding Titanic Dataset

Initial commit of new branch
Adding support for a new dataset.
The Titanic dataset is based on tabular data which differ from the other dataset used in this project.
Inspired by :
https://web.stanford.edu/class/archive/cs/cs109/cs109.1166/problem12.html

Nice work @aygalic !
Could you tell us if we have a decent performance on a scenario with 3 partners, random split ?
You can run it in collab if it takes too long on your marchine --> https://colab.research.google.com/github/SubstraFoundation/distributed-learning-contributivity/blob/master/run_experiment_on_google_collab.ipynb

You can run it in collab if it takes too long on your marchine --> https://colab.research.google.com/github/SubstraFoundation/distributed-learning-contributivity/blob/master/run_experiment_on_google_collab.ipynb

Nice work @aygalic !
Could you tell us if we have a decent performance on a scenario with 3 partners, random split ?
You can run it in collab if it takes too long on your marchine --> https://colab.research.google.com/github/SubstraFoundation/distributed-learning-contributivity/blob/master/run_experiment_on_google_collab.ipynb

Thank you !
After my last commit, I did a GPU run on colab with the following config :
experiment_name: my_example
n_repeats: 1
scenario_params_list:

dataset_name:

'titanic'
partners_count:
3
amounts_per_partner:
[0.4, 0.3, 0.3]
samples_split_option:
['basic', 'random']
multi_partner_learning_approach:
'seq-pure'
aggregation_weighting:
'data_volume'
'uniform'
epoch_count:
20
methods:
["Shapley values", "Independent scores", "TMCS"]
minibatch_count:
10
gradient_updates_per_pass_count:
8

It took  around 22 min to run the main.py file

I tried a few combinations quickly but couldn't find easily what would make sense to reach a good performance (in terms of minibatch_count, type of multi-partner learning and aggregation...). I always plateau at 0.6, which I suppose is the dummy performance. Could you manage to reach a relatively good perf and add as comments what is the right config for it?

@aygalic could you update the config_quick_debug.yml with parameters than enable a good perf with the model you implemented for this dataset? This will enable us to test by ourselves before merging.

@aygalic you'll also have to update the README to indicate that Titanic joined the family of supported datasets!

I tried a few combinations quickly but couldn't find easily what would make sense to reach a good performance (in terms of minibatch_count, type of multi-partner learning and aggregation...). I always plateau at 0.6, which I suppose is the dummy performance. Could you manage to reach a relatively good perf and add as comments what is the right config for it?

@aygalic could you update the config_quick_debug.yml with parameters than enable a good perf with the model you implemented for this dataset? This will enable us to test by ourselves before merging.

Yes ! Both done.
I added my configuration at the end of the quick debug file.
A run worked for me


crypto: migrate to SPDX identifier

Summary
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.
define NuttX local NuttX-PublicDomain identifier
“Public Domain” is a concept distinct from copyright licensing;
it generally means that the work no longer has any copyright protection
or ownership, and therefore requires no license permission in order to
use, copy, modify, distribute, perform, display, etc.
In the United States – and many jurisdictions – copyright protections
attach automatically to creative works upon creation if they satisfy
certain minimum criteria.
“Public Domain” would thus represent a significant change to the legal
status of the work.
The rules around “Public Domain” often vary or are unspecified
jurisdiction to jurisdiction. Adding to the confusion, some
jurisdictions may not even recognize the concept of “Public Domain”
(or similar). As such, a license may nevertheless be required or implied
in these cases. Even in the U.S., there is no clear,
officially-sanctioned procedure for affirmatively placing
copyright-eligible works into the “Public Domain” aside from natural
statutory expiration of copyright. The bottom-line is, there are few if
any objective, brightline rules for proactively placing
copyright-eligible works into the Public Domain that we can broadly
rely on.
Impact
SBOM
Testing
CI

[Experimental Bot, please feedback here]
Yes, this PR appears to meet the basic NuttX requirements, but could be improved.  Here's a breakdown:
Strengths:

Clear Summary of "Why":  The rationale for using SPDX identifiers for SBOM generation is clearly stated.
Concise Impact Description: Highlighting "SBOM" as the impact area is direct.
Testing Mention:  Referencing CI indicates testing is being performed.

Weaknesses & Suggestions for Improvement:

Missing Details in Summary:

"What functional part is changed?": Be specific.  E.g., "The license headers/files," or "A new Kconfig option," or "The build system."
"How does the change work?": Explain the mechanism. E.g., "A new SPDX identifier NuttX-PublicDomain is defined and used in all applicable files," or "A script is added to automatically generate SPDX tags."
Issue References: If this relates to a specific issue (even a self-filed one), link it.

Insufficient Impact Assessment:

User Impact: While likely minimal, explicitly state "NO" or briefly explain any potential effects.
Build Impact:  "NO" or explain any changes to the build process (e.g., new dependencies, additional steps).
Hardware Impact:  "NO" (presumably).
Documentation Impact: "YES" if any documentation needs updating to reflect the SPDX changes or if documentation about the SBOM generation process is added. Explain the changes.
Security Impact:  "NO" or justify.  The legal discussion about Public Domain vs. licensing is important context but doesn't directly address the security implications of this specific change.
Compatibility Impact: "NO" or explain any potential breaks.

Inadequate Testing Description:

Build Hosts: List the specific OS, CPU architecture, and compiler versions used for testing.
Targets: Specify the architectures and board configurations tested (e.g., sim:nsh, qemu-cortexm3:hello).
Logs: The "CI" reference is insufficient.  While full logs might be excessive, provide snippets or summaries of the relevant output demonstrating the change's effect (e.g., "SBOM generation tool now correctly identifies NuttX components").  If the CI has public logs, link to them.

Example of Improved Testing Section:
Testing

I confirm that changes are verified on local setup and works as intended:
* Build Host(s): Linux (Ubuntu 22.04), x86_64, GCC 11.3.0
* Target(s): sim:nsh, qemu-cortexm3:hello

Testing logs before change (SBOM generation with `tool_name`):

Component "NuttX" identified as "NOASSERTION"

Testing logs after change (SBOM generation with `tool_name`):

Component "NuttX" identified as "NuttX-PublicDomain"
(See also CI logs: [link to CI run])

By adding these details, the PR will be much stronger and easier for reviewers to evaluate.

@xiaoxiang781216 please ignore the CI error. The SPDX informaition can not be modified


Type hints for status_data returns

So off the top of my head, there are two approaches to this we can take.
First (and my preferred) is to create a dataclass for attributes from status_data, so we would return a Tuple[StatusData, ObstructionDetails, Alerts]. This would be a breaking change, as references such as groups[0]["id"] become groups[0].id. I prefer this one because it's slightly less work to reference variables 😆
Second is to create a class extending TypedDict. Referencing variables will look the same as it is now, but groups[0]["id"] would return str rather than Any.
Both of these require creating new classes, and both mean we can deprecate both status_field_names and status_field_types, since this information is present in the return type

I'll have to think this over some, but I'm starting to warm up to using TypedDict for this, with the following caveats:
My original design intent with this was that those return values be fairly opaque and dynamic. status_field_names and status_field_types only came about because CSV and sqlite output need schema information in advance of the actual data. That being said, I don't really care about "opaque" so much as I care about being able to add new fields in starlink_grpc without having to tweak the dish_* calling scripts, and that does not preclude specifying the type information more strongly.
As for interface breaking changes, there is already at least one other project (starlink-graph) using the starlink_grpc.py interface, so it would have to be a pretty compelling need to make an incompatible change. I'd be reluctant to go that route for this.
An issue with using TypedDict is that it was only introduced in Python 3.8, so that would raise the minimum Python version from the current 3.7. That would not be the end of the world, but I would like to consider alternative for users who don't care so much about the type hinting. (Not saying I would require it, just that I would like for it to be considered.)
Something to consider is that the alert detail data group's fields are determined at run time based on the reflected grpc data structure. I don't think that would work well with either dataclass or TypedDict. That being said, all the fields in that group are bools, so you could probably just do Dict[str, bool] for that one. At any rate, I believe this means status_field_names and status_field_types will still be required, at least in part.
Finally, however it is implemented, note that some of the fields may return None, so should be considered optional. In practice, only a handful of fields currently have that potential, but if the grpc protocol changes in the future to drop some information, as has happened in the past, more fields could do so.

That's a good point on the alert types! Is there a reason it's done that way? Do alert types change frequently?

Not frequently, but it does happen on occasion. I just felt it was dumb to have to do a code change every time a new alert was added when the info is right there in the grpc message definition.
It's still not exactly perfect now, as it will only pick up new alert bits when the script restarts and it re-fetches the protocol module definitions via reflection, but I figured that was good enough.
By the way: I've been poking around with how to support this with TypedDict without breaking Python 3.7 support or having to duplicate the type data between type hints and the *_field_names / *_field_types functions. It's a bit more complex than it really should have been due to some decisions I made with the field names, but I think it will work OK. I can throw that up in a branch if you want to have a look.

If you have comments, please drop them onto PR #60. If that change looks OK, I will do the same for the history stats and bulk history return types.

dataclass is available in all target versions right? I noticed get_status returns an object that could be replaced with dataclass. Might be a good stand-in for status_data

get_status returns a spacex.api.device.device_pb2.DishGetStatusResponse object.
I think I can still make TypedDict work for the status_data (and similar) return values, I just need to make the type hint types be the source of truth and derive the data needed for the *_field_names / *_field_types functions from those, instead of the other way around. The only hesitation I have about doing so is that the way to access the type information from the type hint type constructs involves reaching into the object innards and is not actually documented, so may actually differ across Python implementations.

Second attempt has been posted as PR #62.
This time I ran it through mypy, and it checks out as long as I specify Python 3.9 (vs it spewing errors on 3.7, the only other version I checked). mypy does report a few other errors, due to it not being able to infer correct types for locals in a few functions, but those are unrelated to this change.

This is now present in the main branch.
One thing I should point out is that I only marked the fields that currently have the potential to return None as Optional[]. However, in the event that the underlying data is removed from the grpc protocol, really any of the fields could return None in the future, and I would not consider that a compatibility breaking change. One could argue that all the fields should thus be marked Optional[], but I felt that doing so would unnecessarily complicate the calling code with the need to check for None everywhere. That being said, the dish_*.py scripts do allow for any fields to be None, with a few exceptions, so I could be convinced otherwise.
If the protocol does change to remove things from the grpc structures, that's going to break starlink_grpc.py and will require a code change, anyway, at which point, the field can be changed in the type hint to be Optional[] (not to None, because doing so would break schema for any database that already has older data). Of course, any functionality that was relying on that data will break, regardless, but there's not much to be done about that. This has happened in the past, but it has been rare, and they usually stop populating the data first, which results in default values being reported.

Agreed, I don't think it makes sense to mark everything as optional. Schema changes should prompt a library update.
I plan on checking this out over the weekend, we can probably close this as long as mypy passes and I'll open up issues for anything else I find


issue#1 support pre and next unclickable

Are you sure?

This feature is supported with startDate and endDate options in the v0.2.0.

:clap: :clap: very nice thanks for that


Sorting with multiple attributes

I want to sort receivers on two attributes, first by receiving_rec then by receiving_tar. The sort command as of now only takes one string argument. Is there a way to do something like
players.receiving().sort(['receiving_rec','receiving_tar'])

I think you'll have to rely more on Python than the built-in convenience functions that nflgame offers.
import nflgame

games = nflgame.games(2015, kind='REG')

players = nflgame.combine_max_stats(games)
players = sorted(players, key=lambda x: (x.receiving_rec, x.receiving_tar), reverse=True)
for player in players[:10]:
	print player.player, player.receiving_rec, player.receiving_tar

Julio Jones (WR, ATL) 136 203
Antonio Brown (WR, PIT) 136 193
DeAndre Hopkins (WR, HOU) 111 191
Jarvis Landry (WR, MIA) 111 167
Brandon Marshall (WR, NYJ) 109 173
Larry Fitzgerald (WR, ARI) 109 146
Demaryius Thomas (WR, DEN) 105 177
Odell Beckham (WR, NYG) 96 158
Delanie Walker (TE, TEN) 94 133
Golden Tate (WR, DET) 90 129


How do i populate the dropdown after the user has entered something and press enter

Hi,
I am trying to implement the case where the component acts as a traditional search box. Once when the user has entered something and pressed the enter button , I would like to use the user's input criteria as the search parameter and pass it to the API. The API would then return me all the values based on the user's search criteria. Now, the API is ready, but I am not sure how to use vue-multiselect to perform that kind of operation. Can you please help me out with this ?
I keep getting this error : "No Elements Found. Consider changing your search query"

		<multiselect
			:selected.sync="selected"
			:options="booksArray"
			:on-search-change="getBooks"
			placeholder="Type to search"
			label="BookCode"
			key="BookID">
		</multiselect>

<script>
	import Multiselect from 'vue-multiselect'
	export default {
		data () {
			return {
				booksArray:[],
				selected:null,
			}
		},
		created () {
			console.log('going to create the object');
		},
		methods : {
			getBooks (item) {
				console.log('search item : '+item);
				this.$http.get('bookApiService').then(response => {
					this.booksArray = response.data.resource;
					console.log(this.booksArray.length);
					console.log(JSON.stringify(this.booksArray));
				})
			}
		},
		components: {Multiselect}
	}
</script>

Thank you for your time and patience.
With Regards
Gagan

@gj1118
You probably want typeahead and not multiselect.
But I did something similar here. Though, I won't advise this solution.

@gj1118 Hey there!
Is this API call correct? You’re not passing the item query into the $http request.
What does those console.logs print inside the then callback?
The above example should work except for the case when the returned books do not contain the search phrase in any of the keys. For example, you search for Witcher and the returned array looks like this:
[
  { BookCode: 'Sword of Destiny', BookID: 321 },
  { BookCode: 'Blood of Elves', BookID: 322 }
]

Multiselect does a search through all the keys available in the options array.

Hi damian , the api call was just a sample one but i think for my purposes
i will have to use typeahead.
I only need to fill the options with the information that matches the
criteria has mentioned ..
Thanks
On Jul 8, 2016 3:13 PM, "Damian Dulisz"<EMAIL_ADDRESS>wrote:

@gj1118 Hey there!
Is this API call correct? You’re not passing the item query into the
$http request.
What does those console.logs print inside the then callback?
The above example should work except for the case when the returned books
do not contain the search phrase in any of the keys. For example, you
search for Witcher and the returned array looks like this:
[
{ BookCode: 'Sword of Destiny', BookID: 321 },
{ BookCode: 'Blood of Elves', BookID: 322 }
]
Multiselect does a search through all the keys available in the options
array.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Okay :)
If you change your mind you can look into the documentation at the Asynchronous dropdown part.


Fetch the last_message from conversation instead of last read message

connect SkygearIO/chat#76

@ben181231 updated.


Migrate to Flutter 2.0 & add boolean point in poligon

will soon be replaced by own implementation of null-safety support

Hi @hienlh,
sorry for rejecting your PR.
nevertheless thanks for your contribution 👍
It would be really really great if you could find the time to:

update your repository to match our upstream main branch
and proposed a new PR just for the feature point in polygon!

Thank you,
Lukas 😄


Add basic RDF batch app

This is a placeholder to track adding a basic random decision forest batch app. As we're still on Spark 1.1, the MLlib-based portion will have to be based only on a DecisionTree.

I feel fairly confident that this is basically functional as of commit https://github.com/OryxProject/oryx/commit/48fe27090dee24573c6f49e5e8fa689613366c32


Upgrade tests account for last event being interrupted (#7447)

Backport from upstream.

Fix reporting index of the failed step

The warning had a wrong index:
{"level":"info","ts":"2023-11-13T14:00:03.816770975Z","caller":"sender/services.go:207","msg":"Sending step event #16691 to
"http://sut-kn-channel.eventing-e2e0.svc.cluster.local""} {"level":"warn","ts":"2023-11-13T14:00:03.821102525Z","caller":"sender/services.go:102","msg":"Could not send step event 16690, retrying (1): Post
"http://sut-kn-channel.eventing-e2e0.svc.cluster.local": dial tcp <IP_ADDRESS>:80: connect: connection refused"}

Upgrade tests account for last event being interrupted

/cherry-pick release-v1.12

@matzew please review, similar to the upstream one.

/test 413-test-e2e-aws-ocp-413

/test 413-test-reconciler-aws-ocp-413

@mgencur do you want to cherryp pick that to 1.12 too?


[FEATURE REQUEST] Push updates updates more frequently to winget (and later to choco)

Before submitting the issue

[x] I have checked that the requested feature is not a duplicate or, if it is, it needs to be reopened
[ ] I have checked that I am running the latest version of WingetUI
[x] I have checked the FAQ section
[x] I have read the contributing guidelines and I agree with the Code of Conduct

Is your feature request related to a problem? Please describe.
No
Is it possible to push wingetui updates more frequently to winget ?
In my optinion today you dont want manually download and install per installer on a fresh win10/11 OS.
especially on newer win10/11 setups comes with newest winget, where you can just run a auto script (after win10/11 install) with "winget install wantedpackage1 wantedpackage2"
AND winget 1.5.x support (already added) .zip package install and package pinning out of the box - what is needed for example gpu drivers...
btw what I know on choco und also winget you can automate pushing updates to chocolatey packages und winget-pkgs repo.
should be easier for you because this repo already is on github :D
So nothing much todo if first time properly setup... just a tipp :)
EDIT - just want to say: In my opinion wingetUI is THE best GUI for win package management ! So big thanks for great work to all devs! :)

Is it possible to push wingetui updates more frequently to winget ?

There is an issue with the installer, which breaks continuous publishing, since the installer is reporting non-zero output codes and is failing verification. The same goes with chocolatey. I am working on fixing this though

it seems that the latest WingetUI version is available on Winget

it seems that the latest WingetUI version is available on Winget

Yup, got it - thanks !

There is an issue with the installer, which breaks continuous publishing, since the installer is reporting non-zero output codes and is failing verification. The same goes with chocolatey. I am working on fixing this though

Ah got it - thats why there are weird errors on the winget-pkgs Repo.
Again thanks for great work !


Add Profiles to JumpList (#576)

313e72b: Add App::_CreateJumplist() to Cascadia, registering profiles to the jumplist

The order the profiles appear in the new tab flyout.  Is this forced alphabetical, or does the order in the JSON matter?  Should any effort be made to maintain the same ordering from flyout and JumpList?

@mdtauk right now the order is based upon the order in the json file. I'd probably try to keep it in that order, esp since some keybindings (Ctrl+shift+number to open a new tab with a specific profile) depend on the actual ordering.


Add Bootstrap config to Envoy deployment.

https://github.com/envoyproxy/gateway/pull/200 added initial support for deploying Envoy. However, this PR did not include creating Envoy's bootstrap config. A solution should be added for provisioning the bootstrap config as part of the Envoy deployment.

@youngnick I see that Contour uses an init container to manage the bootstrap config. What is the reason why a configmap containing the bootstrap config can't simply be mounted to the Envoy container?

xref https://github.com/projectcontour/contour/issues/1

I think that there were a couple of reasons:

We had some information that needed the pod to be up before we could generate the bootstrap (although I can't recall what that is). I think this one is mitigated in the Envoy Gateway case by the fact that we're controlling the whole creation process.
We wanted not to have any secret stuff in the bootstrap visible in the cluster. I think that there's actually not much that's very secret in the bootstrap config itself - all the secret stuff will be stored in Kubernetes Secrets (basically, the TLS details for connecting to the xDS server in EG).

In summary, I think that using a configmap for EG should be fine, if there are any problems with the approach, we can always change back later.

Help wanted to either update take either of the following approaches to manage the bootstrap config:

Add the bootstrap config cli arg to the Envoy deployment.
Manage a configmap that holds the bootstrap config and mount the configmap to the envoy deployment.


Stage28jan

Signed-off-by: Debojyoti Ghosh<EMAIL_ADDRESS>

You didn't rebase your fork after the first merge, so this one has way too many changes and conflicts. I'm going to close this PR because of the conflicts.
Before you submit again, you'll need to rebase against the current main. The preferred way is to add an upstream repo and rebase to that and then push to your fork to update it. The easier way is probably just to delete your fork and create a new one and then branch from that. Just save your changes out of the repo first. :)

You didn't rebase your fork after the first merge, so this one has way too many changes and conflicts. I'm going to close this PR because of the conflicts.
Before you submit again, you'll need to rebase against the current main. The preferred way is to add an upstream repo and rebase to that and then push to your fork to update it. The easier way is probably just to delete your fork and create a new one and then branch from that. Just save your changes out of the repo first. :)

Hi Avi,
Created new fork, new branch (Stage29jan) and submitted pull request again #1853.
This time it was showing only those 3 files, changed. Also, this time it showed 'can be auto-merged' with a green tick. Hopefully thats ok.
Please take a look once free.
Thanks,
Deb.

From: Avi Miller<EMAIL_ADDRESS>Sent: Friday, January 29, 2021 3:57 AM
To: oracle/docker-images<EMAIL_ADDRESS>Cc: Debojyoti Ghosh<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: [External] : Re: [oracle/docker-images] Stage28jan (#1852)
You didn't rebase your fork after the first merge, so this one has way too many changes and conflicts. I'm going to close this PR because of the conflicts.
Before you submit again, you'll need to rebase against the current main. The preferred way is to add an upstream repo and rebase to that and then push to your fork to update it. The easier way is probably just to delete your fork and create a new one and then branch from that. Just save your changes out of the repo first. :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/oracle/docker-images/pull/1852*issuecomment-769440648__;Iw!!GqivPVa7Brio!LlvitiD_g1DkQhbBCqPVgoXhJTkEUFPgVjJfnxIl9UU_XVv45iukYGT2dn7-ANZqjfoW5Q$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOOKLHXBI5NOVPNDRTMB4HDS4HQE3ANCNFSM4WX2NKJA__;!!GqivPVa7Brio!LlvitiD_g1DkQhbBCqPVgoXhJTkEUFPgVjJfnxIl9UU_XVv45iukYGT2dn7-ANavlHl-2A$.

Hi Avi,
Created new fork, new branch (Stage29jan) and submitted pull request again #1853.
This time it was showing only those 3 files, changed. Also, this time it showed 'can be auto-merged' with a green tick. Hopefully thats ok.
Please take a look once free.
Thanks,
Deb.

From: Avi Miller<EMAIL_ADDRESS>Sent: Friday, January 29, 2021 3:57 AM
To: oracle/docker-images<EMAIL_ADDRESS>Cc: Debojyoti Ghosh<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: [External] : Re: [oracle/docker-images] Stage28jan (#1852)
You didn't rebase your fork after the first merge, so this one has way too many changes and conflicts. I'm going to close this PR because of the conflicts.
Before you submit again, you'll need to rebase against the current main. The preferred way is to add an upstream repo and rebase to that and then push to your fork to update it. The easier way is probably just to delete your fork and create a new one and then branch from that. Just save your changes out of the repo first. :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/oracle/docker-images/pull/1852*issuecomment-769440648__;Iw!!GqivPVa7Brio!LlvitiD_g1DkQhbBCqPVgoXhJTkEUFPgVjJfnxIl9UU_XVv45iukYGT2dn7-ANZqjfoW5Q$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOOKLHXBI5NOVPNDRTMB4HDS4HQE3ANCNFSM4WX2NKJA__;!!GqivPVa7Brio!LlvitiD_g1DkQhbBCqPVgoXhJTkEUFPgVjJfnxIl9UU_XVv45iukYGT2dn7-ANavlHl-2A$.


Update the tgi service images for both xeon and gaudi

Description
Update the tgi service images for both xeon and gaudi.
Issues
n/a.
Type of change
List the type of change like below. Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would break existing design and interface)

Dependencies
n/a.
Tests
n/a.

can we confirm all the models used in GenAIExamples are supported by latest-xeon-cpus?

can we confirm all the models used in GenAIExamples are supported by latest-xeon-cpus?

Yeah, sure, let me confirm with @lvliang-intel

based on the test output, tgi pod crashed during test, so I guess it's still not working yet.

Seeing this error message at TGI pod, so it looks like the latest tgi image doesn't work with this model correctly.
model_id: "Intel/neural-chat-7b-v3-3"
...
{"timestamp":"2024-09-23T05:00:54.220232Z","level":"ERROR","fields":{"message":"Shard 0 crashed"},"target":"text_generation_launcher"}
BTW, if we want to upgrade to tgi-gaudi:2.0.5, the "gaudi-values.yaml" in TGI helm chart should also be updated.

Hi @yongfengdu and @lianhao, after discussed with Intel Xeon TGI image support engineer, we'd better to use the specified version of TGI image, such as ghcr.io/huggingface/text-generation-inference:sha-e4201f4-intel-cpu

CI fail is for the CPU values file.
That fails also in #454 which does not change any of the components used in CI (it skips HPA testing), unlike this one.
Therefore it's possible that the failure is not related to the TGI update (unless that increases TGI resource usage, or slows it down).

Please wait for PR https://github.com/opea-project/GenAIInfra/pull/456 to land-in first, then rebase to trigger the test to see if it still exists

@zhlsunshine for the test failure of GMC E2e Test on Xeon, GenAIComps PR 608 could be the trigger for this failure. But could you double check if there is any issue in the GMC router which would cause trouble when trying to forward back large amount of streaming data from tgi to the end user?

@zhlsunshine for the test failure of GMC E2e Test on Xeon which is unrelated to this PR itself, GenAIComps PR 608 could be the trigger for that failure. But could you double check if there is any issue in the GMC router which would cause trouble when trying to forward back large amount of streaming data from tgi to the end user?

Hi @lianhao, I noticed that there are some parameters change in request, however, GMC router just pass through them, so I do not think there is issue for these changes.


cwd property doesn't affect files listing

First off, I love this plugin! Tthank you @ibhagwan and @vijaymarupudi !!
Small issue I've been having... when passing in a specific cwd property (:lua require("fzf-lua").files({ cwd = ~/.config })), the file listing does not load those files, but instead the files from my actual current working directory that i started the file in, essentially the same as cwd=''. Though, the preview window tries to load a preview of those files, but the preview window seems to be "in" the passed in cwd.
Any thoughts? Are there other things that must happen to have the given cwd take affect for the files listing?

Stupid question but did you try to add quotes? I.e. cwd = “~/.config”?
 I wish it were something obvious, yes I have and more.
 I wish it were something obvious, yes I have and more.
Here’s a more exact representation of what I’ve tried:
https://github.com/megalithic/dotfiles/blob/b4733b76300551e1c880573f48c91c5ad52471eb/nvim/.config/nvim/lua/mappings.lua#L182

Alright found the problem, you do not have fd installed so the command falls back to find which has a bug with a specified path, I'm on it, will have a fix soon.

Update your plugin and it should work now.
Feel free to close the issue if the answer is yes.

Apologies for delay in responding. I'm still having the same issue and fd is being used (not sure where you saw find actively being used). Here are my settings for files just in case: https://github.com/megalithic/dotfiles/blob/main/nvim/.config/nvim/lua/settings.lua#L717-L728
Thanks again for checking this out. Do I need to alter my files default cmd in any way?

I'll get a screencast showing hte behaviour too

Apologies for delay in responding. I'm still having the same issue and fd is being used (not sure where you saw find actively being used).

I concluded you were using find as I found a bug where find was being used with the cwd property.

Here are my settings for files just in case: https://github.com/megalithic/dotfiles/blob/main/nvim/.config/nvim/lua/settings.lua#L717-L728
Thanks again for checking this out. Do I need to alter my files default cmd in any way?

Yes, this is your issue here, if you look at files#L13 you’ll see that once you set cmd all other parameters are ignored, in order to achieve what you want change cmd to fd_opts and remove fd from the variable (so only the command line args are sent).
Let me know if that solves your issue?
Also, can you share details about your comment regarding the failing of git_icons = true so I can fix it?

BRILLIANT! Thank you so very much @ibhagwan !! - closing
Also, I believe the git issue I was seeing with using git_icons set to true is now resolved, too. 🙏
Thanks for everything!

Great!
The real issue here is due to me adding new functionality and still not having the time to write proper documentation, cmd having absolute control over files is not intuitive nor self explanatory.


Deriving Serialize/Deserialize on remote types causes missing_docs errors

Minimal example:
//! FOO

#![deny(missing_docs)]

use serde_derive::{Deserialize, Serialize};

/// X
pub struct X { f: u32 }

/// Remote X
#[derive(Deserialize, Serialize)]
#[serde(remote = "X")]
pub struct XDef { f: u32 }

   Compiling playground v0.0.1 (/playground)
error: missing documentation for a method
  --> src/lib.rs:11:20
   |
11 | #[derive(Deserialize, Serialize)]
   |                    ^
   |
note: lint level defined here
  --> src/lib.rs:3:9
   |
3  | #![deny(missing_docs)]
   |         ^^^^^^^^^^^^

error: missing documentation for a method
  --> src/lib.rs:11:31
   |
11 | #[derive(Deserialize, Serialize)]
   |                               ^

error: aborting due to 2 previous errors

Putting #[allow(missing_docs)] on XDef doesn't help -- I presume this is because the generated functions do not actually belong to impl XDef.

I would accept a PR to fix this.


test: implement PParams blackbox test using Haskell node as test oracle

Context
Correct management of protocol params (aka: PParams) is a complex and essential part of the ledger logic. The easiest way (at the moment) to ensure a correct implementation and detect regressions is by assuming that the output from the Haskell node as our gold-standard.
The current Dolos implementation for PParams management resides here
A hardcoded set of PParams for different epochs and networks is available here. Take these values with a grain of salt, they have been compiled manually and might have inconsistencies.
Goal
We need new unit tests that allows us to compare the output from Dolos' PParams aggregation with well-known values gathered from the chain.
One way to approach this (not mandatory) is to gather the actual blocks from the chain containing param updates and store them as test data in the repo. With use this blocks to execute the PParams aggregation logic in Dolos and then compare the output with the well-known values.

:wave: I'm going to tackle this, if you want to assign it to me


Add DerReparierer blog and git repository for repairing electronic devices

What about refering to the repository only (not the blog) and opening a new section 'repairing', as a repairing-section is not represent on this awesome-list so far?

Hi! I believe that repairing is out of the scope of this awesome list, which seems to be tailored to theoretical sources, analysis and design, simulation, and manufacturing.


Influence kernel parameters at install time

Elemental client elemental install command should have some way to easily influence the kernel parameters within the bootloader.
Ideas:

make the grub2 configuration file a template and render it at install phase
pass kernel parameters as a grub environment variable that gets filled at install time
patch grub.cfg at install time
mix of template and grub2 approach

This will allow us to set all labels at install time and remove any partition or filesystem label literal from elemental-toolkit repository.

One more use case: https://github.com/rancher-sandbox/cluster-api-provider-rke2/issues/291


add environment test as presubmit check

We should have the environment tests run before each PR, like in the Python library

We do have tests which could be run from terminal, e.g. "npm run test" - can you please elaborate what you mean here?

I was referring to having the environment tests run on each PR, but it looks like we have that in place already:

This must be out of date


Support the quantization of fused custom ops

Propagates the _tfl_quant_trait as attribute into the newly created custom op instead of as custom_option. It also forces the pruning of unused custom ops in the PostQuantizePass by assuming all custom ops have no side effect. This is a temporary solution due to the difficulty to set the enable-no-side-effect option through the Python API.

"support string custom attributes" split as seperate PR: https://github.com/tensorflow/tensorflow/pull/58818.

@miaout17, could you please review this PR?

Hi @psunn This PR is in draft, any update on this? Please. Thank you!

Hi @psunn This PR is in draft, any update on this? Please. Thank you!

Thank you for the reminder. We are currently finalizing our work on this topic and will request a review as soon as we have updated.

Hi @psunn This PR is in draft, any update on this? Please. Thank you!

Hi @psunn This PR is in draft, any update on this? Please. Thank you!
Thank you for the reminder. We are currently finalizing our work on this topic and will request a review as soon as we have updated.

Hi @psunn This PR is in draft, any update on this? Please. Thank you!

@gbaned
Thank you for the reminder. We are currently working on it and will request a review as soon as we have updated.

Hi @psunn Any update on this PR? Please. Thank you!

Thank you for the reminder, @gbaned.
I'm closing this ticket for now, as someone else may raise a new PR to resolve this feature request.


broken design in ul.object-tools (Import not accessible)

The hack in
import_export/templates/admin/import_export/change_list.html
rewrites the ul.object-tools element.
However some admin template packages, especially bootstrap packages (I have tested django-admin-bootstrap and django-admin-bootstrapped) generate the same, but with additional classes like .pull-right.
In such case django-import-export will break their design
and in result the ul.object-tools can be completly hidden by other objects (and both Import and Add will be not accessible).
I know that this is completly ugly and the problem is somewhere between django standard admin, django admin template package and your project,
however I think you shoul remove your template completly and
a) let it so, because I don't feel that user without Add permissions should Import,
b) or, think about some other less conflicting solution - which will be difficult.
My meaning: a)

I've looked around to see how to "override django-import-export templates". Is there example code of how to do this? Did I miss something in the docs? I'm on Django 1.11 and django-import-export 2.1.0 with bootstrap-admin==0.3.6 and django-admin-bootstrapped==2.5.0 onboard. Currently if django_admin_bootstrapped is installed, the action menu drop down is hidden entirely on page load. Any thoughts?


It doesn't detect Face Anymore

It never detects face. Tried with several deferent phones. There is zero (0) spamming the console.

@i-amSid  let try with branch feature/ekyc, change presolotion your camera to medium or low, please !

feature/ekyc have fixed it


MVVM does not working in .NET 8.0 with "PublishTrimmed" option enabled.

Describe the bug
When an Avaloniaui  project is published with "PublishTrimmed" option enabled, All bindings stop working. The control shows, but all binding options does not take effect.
The project is not using ReactiveUI.
No reflection is being used.
To Reproduce

add a publish profile, choose target "Folder"
target framework: 8.0, deploy mode: standalone, runtime: win-x64, publish trimmed: checked
execute publish

Expected behavior
All MVVM bindings work properly.
Minimal reproduce demo:
mvvm-not-working-net8-demo.zip
Avalonia version
11.0.10
OS
Windows
Additional context
OS: Windows 10 Enterprise
Language: zh-CN
Memory: 16.0 GB

You need compiled bindings enabled. Please double-check.

You need compiled bindings enabled. Please double-check.

Compiled Bindings works. Thank you.


Add the possibility to pass an array to all keyValue actions

Problem
We often have to update every values in a keyValue store. But with the current API, it can lead to a huge number of dispatched actions.
Proposition
I propose to make update, addOrUpdate and replace action polymorphic on their argument, allowing to pass an instance or an array of instances.
Example
import { keyValue } from 'k-redux-factory'

const store = keyValue({ key: 'id' })

store.addOrUpdate([
  { id: 1, value: '1' },
  { id: 2, value: '2' },
  { id: 3, value: '3' },
])

This is a nice catch.
And as you said in your PR, we will maybe hit a performance issue.
That's why I opened #108 .
Can you review this PR, and next steps associated. I would like to know your opinion about this.


snowflake column identifier

Signed-off-by: Pawel Leszczynski<EMAIL_ADDRESS>resolves https://github.com/sqlparser-rs/sqlparser-rs/issues/519
According to documentation, Snowflake allows:

query data staged in files with an identifier of a form [<alias>.]$<file_col_num>[.<element>]
copy into table with an column identifier containing $ character like select t.$1,t.$2,t.$3 from @~/datafile.csv.gz t;
get-path like select v:attr[0].name from vartab;

Although the feature seems to be snowflake specific, it cannot be implemented within snowflake dialect. It's because tokens starting with $ character are tokenized into Token::Placeholder. That's why parser's change is required.
Initial OpenLineage project issue: https://github.com/OpenLineage/OpenLineage/issues/814.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

19 of 19 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 89.81%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
8734

Relevant Lines:
9725

💛  - Coveralls

There appear to be a few CI failures on this PR

Marking this as a draft to show it is waiting some changes so I can easily filter out which PRs need review. Please mark it as "ready for review" when it is next ready.

@alamb @pawel-big-lebowski is closing this for now because it's almost a year without an update.
@pawel-big-lebowski, ping me if you will work on this code specifically, if so, I open the PR again :)

Thanks for cleaning this up @AugustoFKL

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

30 of 35 (85.71%)  changed or added relevant lines in 4 files are covered.
570 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.02%) to 89.81%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/parser.rs
16
17
94.12%

src/ast/mod.rs
10
14
71.43%

Files with Coverage Reduction
New Missed Lines
%

src/ast/mod.rs
201
78.9%

src/parser.rs
369
83.45%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
8734

Relevant Lines:
9725

💛  - Coveralls


[transfer] credential manager plugin

Add credential manager plugin to be used by the transfer service.
Expected abilities:

No unencrypted secrets in containerd or host configuration files
Configurable globally or per host in hosts.toml
Set secret from containerd plugins
Validate credentials (i.e. login validation)
Integrated with existing secret stores (keychain) and other credential helper plugins (i.e. Docker credential helpers)

Related to https://github.com/containerd/containerd/issues/7592

I will try it. Thanks.

It would be great if we could have similar mechanism like kubelet credential provider or docker credential helper, which invokes an external program to retrieve the credentials.

It would be great if we could have similar mechanism like kubelet credential provider or docker credential helper, which invokes an external program to retrieve the credentials.

@knight42 Thanks for the reminder, I will make a reference.

Additional references.
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Thanks for leading me here, and cleaning up the documentation. It's good to know that deprecated authentication support will not be removed until an alternative is in place.
I'm sure there's already been ample discussion about this already so this is likely naïve, but I struggle to imagine many attended scenarios for this case where a credential plugin could manage asking for extra permission to the ultimate credentials. So the relevant plugins will likely be those that have some other token readily available to them.

I'm sorry, due to job changes, I may have no time to work in progress on this. If someone else is interested, you can continue.

I will continue.
/assign

@lengrongfu Did you submit a PR?

@lengrongfu Did you submit a PR?

Sorry, I'm still developing.

Does this work with the containerd mirror feature, i.e. providing proper creds when image is being pulled from a registry mirror?


Can't apply Site Design using Rest API ApplySiteDesign or PowerShell cmdlet Invoke-SPOSiteDesign

Category

[x] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
/_api/Microsoft.Sharepoint.Utilities.WebTemplateExtensions.SiteScriptUtility.ApplySiteDesign REST endpoint and Invoe-SPOSiteDesign cmdlet add Site Design to the web.
Observed Behavior
Nothing happens.
Steps to Reproduce
For REST API:
POST https://tenant.sharepoint.com/sites/testsite/_api/Microsoft.Sharepoint.Utilities.WebTemplateExtensions.SiteScriptUtility.ApplySiteDesign

{"siteDesignId":"site-design-id","webUrl":"https://tenant.sharepoint.com/sites/testsite"}

PnPJS + SPFx
await sp.web.siteDesigns.applySiteDesign(siteDesign, this._context.pageContext.web.absoluteUrl);

PowerShell
Invoke-SPOSiteDesign -Identity site-design-id -WebUrl "https://tenant.sharepoint.com/sites/testsite"

I know that there is a Add-SiteDesignTask cmdlet and AddSiteDesignTaskToCurrentWeb REST endpoint that is used when applying site design from UI.
But if previous ones are "obsolete" why don't just remove them and announce that we don't need to use them?

My bad - I have 30+ actions (mostly - sub actions).

Hello Guys,  I am currently experiencing this problem right now.  When using the Invoke-SPOSiteDesign -Identity site-design-id -WebUrl "https://tenant.sharepoint.com/sites/testsite" I have no respose from the pwoershell - I don't see the result whether Success/failed/noop it will just return to command prompt.  I was working 5 days ago now in every site I tried its not responding anymore.  Any ideas whay might happened?


[skeleton api] Create a Skeleton API / scaffold

We need something to capture the settings being discussed in the 'Use case' dashboard that @AshleySantana is working on. Ensuring we have this idea captured as discussed wiith @WilliamMRose in the hall;

Themes exist
Settings in those themes exist
regions exist
content exists
currently users have to hit 'i want a course' and then add settings, regions, content manually

The "Use case" dashboard  would ensure everything is a card and that our current themes sorta hide a bit more under a "Start blank" or "Let me do it" kind of option (language still in works). Here's what the API needs to encompass
API requirements

[ ] support for name
[ ] folder / machine name but machine name as prop
[ ] demo (which invokes hax.cloud demo container system so you can play with it) #2152
[ ] screenshot / image
[ ] optional gif on hover
[ ] description
[ ] version number
[ ] template / theme to select
[ ] color pallet to preselect. Pallet would be up to 5
[ ] regions to automatically associate / populate content with from a regions/{regionname}.html structure
[ ] content to create (may be easier to just include a content folder to load from)
[ ] files to copy (files folder to associate w/ the content as needed)
[ ] JOS associating the pages to each other or some nesting

HAXcms

[ ] ability to load and store skeletons in the core of the platform.
[ ] ability to load additional skeletons off the configuration directory

HAXiam

[ ] ability to load and store skeletons in the iamConfig directory

Additional considerations

we may need to review how we ship / store region data to match above
we need the core of the platform to identify CSS variables for pallets. This can be upwards of 6 colors and will need to be some kind of css variable like --hax-pallet-color-1 so that we can set it.
design systems (like DDD) will then need to supply potential allowable colors for the pallet in question
elements in the page will then react to the theme/template supplying the mapping between the pallet color and the element.
Look to polaris-invent-theme as a vehicle for possible implementation

#1462 #2150 as well


fix heroku deploy settings

What does this PR do?
fix the settings of the deployed heroku app
Description of Task to be completed?
compress files on the deployed app

@andela-osule please review this and advise accordingly


(GH-901) Document branches for use with Sensu versions 1 and 2

Pull Request Checklist

Description

Related Issue

Fixes # .
Motivation and Context

How Has This Been Tested?

General

[ ] Update README.md with any necessary configuration snippets

[ ] New parameters are documented

[ ] New parameters have tests

[ ] Tests pass - bundle exec rake validate lint spec

Released in v2.54.0


i18n(pt-BR): update reference/publish-to-npm.mdx file

Description (required)
update i18n/pt-br/reference/publish-to-npm.mdx file

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

pt-br
reference/publish-to-npm.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Can you provide code for calculating the EM accuracy and EX accuracy of prediction results?

Can you provide code for calculating the EM accuracy and EX accuracy of prediction results?

Please refer to issue #13.


Added tests and improved allocations for HtmlEncoder

As the HtmlEncoder is an important thing when rendering, I added some tests for the coverage and improved the allocations, no need to allocate a stringbuilder and new string if no encoding needs to be done :)

[xUnit.net 00:00:01.7340644]     Handlebars.Test.HtmlEncoderTests.EncodeTest(input: "�", expected: "ü") [FAIL]
985[xUnit.net 00:00:01.7409369]       Assert.Equal() Failure
986[xUnit.net 00:00:01.7421150]                   ↓ (pos 2)
987[xUnit.net 00:00:01.7431782]       Expected: ü
988[xUnit.net 00:00:01.7441620]       Actual:   �

That's strange, it works local :|

Thanks for the additional test. It's not clear to me how the allocation change is a net improvement.

Allocations are taking memory and makes the GC busy.
FYI: We've done a lot of those improvements in NLog.

That's strange, it works local :|

This is fixed with the UTF-8 BOM on the file

Yeah I get that generally speaking allocations take memory and make GC busy, but in this specific case it is not clear to me what the net improvement is.

less memory usage and lower GC pressure for all renderings?

Great! How much?

Dunno, depends on the machine. Could try to measure

Can always leave the unit tests and remove the change. Generally we don't put in changes that  claim to be performance improvements without instrumenting them.

Generally we don't put in changes that claim to be performance improvements without instrumenting them.

That's clear ;)

Can always leave the unit tests and remove the change.

If I don't find time this week, then that's OK. I think it could do the performance instrumention with https://www.jetbrains.com/dotmemory/unit/

I tested this case:
        [Fact]
        public void LargeEncodeTest()
        {
            var input = new string('0', 1_000_000_000);
            // Arrange
            var htmlEncoder = new HtmlEncoder();

            // Act
            var result = htmlEncoder.Encode(input);

        }

before:

after:

all run 3 times, release mode.

before:

after:

Thanks! New release probably this weekend.

Great!


attached not called on Chrome 35 + web_components 0.3.5 + polymer 0.11.0+3

This issue was originally filed by<EMAIL_ADDRESS>
<template if="{{show}}">
  <x-tag></x-tag>
</template>
set show false -> true -> false -> true
x-tag has attached() and detached().
x-tag create and remove correct, but attached() call only once, detached() never call.
polymer 0.10.0 no problem.

This issue has been moved to dart-lang/polymer-dart#219.


Add editorconfig file

More info: https://murze.be/using-editorconfig

An .editorconfig file helps developers define and maintain consistent coding styles between different editors and IDEs. It is supported by default in many editors such as all JetBrains IDEs, Visual Studio, BBEdit and even the GitHub web interface.
The particular .editorconfig file will make sure that the IDEs of all contributors and maintainers will use utf-8, use the lf character for line breaks, have whitespace trimmed in all files and much more.

Awesome, wasn't aware of it. Thanks for contributing


Pressing "d" for default colors doesn't fully work.

Hello I want to thank you for the great app and share few bugs I've found to make it even better!
When I change the left and right mouse button colors and I press "d" for the default colors they are actually changed but it's not shown in the bottom left corner:

Thanks for the bug report!
The issue comes from PaletteController.js and the resetColors method. An option is to remove the reset method from the SelectedColorsService (since it doesn't fire the expected events anyway) and implement PaletteController::resetColors in the same way as PaletteController::swapColors

Fixed by #605 , thanks to @Sal0hcine


Non deterministic behaviour when reading variables with lifetimes

I have the following script. It's supposed to count from -1 to 2220 while waiting 1 second between every print.
var const i = -1!

when (i + 1 < 2222) {
   const const time<1s> = waiting!

   var const j = one!
   when(j) {
      if (time == waiting) {
         j = j + one!
      }
      if (time ;= waiting) {
         print(i)!
         i = i + one!
      }
   }
}

Sometimes it prints:
Warning: Public global variable `pivo` access failed.
-1
0
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
dreamberd.base.NonFormattedError: Variable is undefined.

During handling of the above exception, another exception occurred:

dreamberd.base.InterpretationError: __unnamed_file__, line 8

        if (time == waiting) {

Variable is undefined.

Sometimes only -1:
Warning: Public global variable `pivo` access failed.
-1
dreamberd.base.NonFormattedError: Variable is undefined.

During handling of the above exception, another exception occurred:

dreamberd.base.InterpretationError: __unnamed_file__, line 8

        if (time == waiting) {

Variable is undefined.

There's probably some kind of race-condition when trying to remove the variables from the thread. I guess a lock somewhere could fix it.

The following patch makes the issue less likely to occur:
diff --git a/dreamberd/builtin.py b/dreamberd/builtin.py
index f1bc374..6fa1cc8 100644
--- a/dreamberd/builtin.py
+++ b/dreamberd/builtin.py
@@ -376,8 +376,8 @@ class Variable:
     def value(self) -> DreamberdValue:
         if self.lifetimes:
             return self.lifetimes[0].value
-        raise NonFormattedError("Variable is undefined.")
-
+        return DreamberdString(self.name)
+
 def all_function_keywords() -> list[str]:

     # this code boutta be crazy

But with that patch i get after 78 the error RecursionError: maximum recursion depth exceeded

Thank you for your contributions! I think if that patch seems to work I would just increase the maximum recursion limit in the main __init__.py file, as during creation I made the bad design decision of checking if when statements are activated within variable assignment, which ends up recursing into assign -> run when statement -> assign -> run when statement -> ...

Actually, nevermind -- I forgot I had already done that; I think the constant updating of j would just have to be changed to be less often or something as each update adds a few more stack frames.

After thinking about the patch i think it's bad. It probably should also check if the name is numeric and then return a numeric value.
the whole reason for the j updates is, that there is no gold way to sleep. I tried to just listen with when on the end of lifetime, but that didn't work. (As described in the Readme)
i've locally increased the stack limit even further and that resulted in really high ram usage (over 40GB). So that's not really practical
it would probably best to not do recursive calls

Yeah, changing the inner workings like that definitely would take a while though -- I think for the time being we could add a sleep function into the language

I just pushed a commit that adds a sleep function so it should make your use case a lot easier to implement

A sleep function is kind of boring. The original spec didn't mention it