Update to latest, coherent dependencies

Generated using this script https://github.com/aspnet/AspNetCore-Internal/pull/1830

EF.Design tests fail on .NET Frameowrk with
Unhandled Exception: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
   at System.Reflection.Metadata.Ecma335.MethodDebugInformationTableReader.GetSequencePoints(MethodDebugInformationHandle handle)
   at System.Diagnostics.StackTraceSymbols.GetSourceLineInfoWithoutCasAssert(String assemblyPath, IntPtr loadedPeAddress, Int32 loadedPeSize, IntPtr inMemoryPdbAddress, Int32 inMemoryPdbSize, Int32 methodToken, Int32 ilOffset, String& sourceFile, Int32& sourceLine, Int32& sourceColumn)
   at System.Diagnostics.StackFrameHelper.InitializeSourceInfo(Int32 iSkip, Boolean fNeedFileInfo, Exception exception)
   at System.Diagnostics.StackTrace.CaptureStackTrace(Int32 iSkip, Boolean fNeedFileInfo, Thread targetThread, Exception e)
   at System.Diagnostics.StackTrace..ctor(Exception e, Boolean fNeedFileInfo)
   at System.Environment.GetStackTrace(Exception e, Boolean needFileInfo)
   at System.Exception.GetStackTrace(Boolean needFileInfo)
   at System.Exception.ToString(Boolean needFileLineInfo, Boolean needMessage)
   at Microsoft.EntityFrameworkCore.Design.Internal.AppServiceProviderFactory.CreateFromHosting(String[] args)
   at Microsoft.EntityFrameworkCore.Design.Internal.AppServiceProviderFactory.Create(String[] args)
   at Microsoft.EntityFrameworkCore.Design.Internal.AppServiceProviderFactoryTest.Create_works_when_BuildWebHost_throws()

EF.Design tests fail on .NET Framework with…

Huh? All checks have passed

They passed on retry. Must be a flaky test.

@natemcmaster Any update from Arcade on when they plan to address these issues?

@bricelam hopefully this week


Tronbox3

This is a large refactoring of Tronbox codebase. It dismisses the monorepo approach to use a standard repo, since the hard fork from Truffle does not allow any future merge.
In this new format it will be much easier to remove unnecessary code and add new features.

[x] Compile, migrate and test working
[x] Make the built code working

This version seems to work.
Reviews and debugging are welcome.


Can it handle SPA/JS-only pages?

Is this able to handle single page apps?
If not, you could extend it to fall back to chrome/chromium with its --dump-dom parameter to have a DOM after it has finished loading all resources.

duplicate of #4


[monorepo] Configure Renovate Noise Reduction

Renovate creates many PRs for updates and this can easily get overwhelming.
A solution to this is setting up settings for "Noise Reduction":
https://docs.renovatebot.com/noise-reduction/
Some recommendations:
Package Grouping
Automerging (If tests pass)
Branch automerging (This doesn't create a PR at all, a branch is created with the updates, if tests pass Renovate will push the changes into master/next without a PR. This can dramatically reduce the noise we get from Renovate provided we have good test coverage)

We already group packages by extending config:base, which extends group:monorepos and group:recommended. I'm not sure if group:all is the best idea.
We also now extend group:allNonMajor`, which means we will only get individual PRs for major version updates. This probably makes sense, since there could easily be breaking changes. It also means that the noise experienced this weekend might be a one-time occurrence, getting all deps and devDeps to the latest major version. I would guess that not many packages are introducing major version updates on a weekly basis.
That being said, bumping up the minor version of one of our packages broke tests. I've spent a couple of hours already trying to debug this. Given this, I'm not sure of the value of bumping minor versions without a specific reason. Should we only use renovate bot to ensure we are always using the latest patches, and not more? Or do we get a measurable benefit from also bumping minor versions on a regular basis?

Automerging (If tests pass)
Branch automerging

Currently, we only run tests on packages that have been changed in the current branch. (This PR also separates out some build steps, to only run them in packages that have changed.) I don't think this conflicts with these strategies -- or at least, they don't create any additional issues with it -- but it's something to keep in mind.
I think that automerging is already enabled, but is prevented by branch protection rules requiring a review. That rule in its current form also prevents automerging. We could edit this rule to exempt the renovate bot.


Failed to download Helm in proxy based environments

We are attempting to leverage azure/setup-helm@v1 in a self-hosted runner environment which requires proxy configuration if wanting to access artifacts from the Internet. What we're seeing is that the actual download of the Helm charts is timing out and it looks like the proxy configuration isn't being applied. I've worked with GitHub in attempting to troubleshoot the issue however they've hit a road block and advised to raise an issue due to not being able to further troubleshoot because of typed-rest-client being used to connect to the proxy.
The error we're seeing (debug logs from workflow output):
##[debug]Evaluating condition for step: 'Set up Helm'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Set up Helm
##[debug]Loading inputs
##[debug]Evaluating: github.token
##[debug]Evaluating Index:
##[debug]..Evaluating github:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'token'
##[debug]=> '***'
##[debug]Result: '***'
##[debug]Loading env
Run azure/setup-helm@v1
##[debug]Downloading v3.2.4
##[debug]isExplicit: 3.2.4
##[debug]explicit? true
##[debug]checking cache: /home/actions/actions-runner/_work/_tool/helm/3.2.4/x64
##[debug]not found
##[debug]Downloading https://get.helm.sh/helm-v3.2.4-linux-amd64.zip
##[debug]Downloading /home/actions/actions-runner/_work/_temp/bb2c4ca1-8372-4782-a925-632994ef13e3
##[debug]Enhanced Annotations not enabled on the server. The 'title', 'end_line', and 'end_column' fields are unsupported.
Error: Error: Failed to download Helm from location  https://get.helm.sh/helm-v3.2.4-linux-amd64.zip
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Set up Helm

We are able to validate that we have no issues downloading the .zip file via curl via the proxy.
Logs of our workload run (taken from runner) show the following:
2021-09-11T07:20:19.3964028Z HTTP 22811: call onSocket 0 0
2021-09-11T07:20:19.3982478Z HTTP 22811: createConnection proxy.xxxx.yyyy:zzzz: {
2021-09-11T07:20:19.3983726Z   host: 'proxy.xxxx.yyyy',
2021-09-11T07:20:19.3984463Z   port: '8080',
2021-09-11T07:20:19.3984984Z   method: 'CONNECT',
2021-09-11T07:20:19.3985396Z   path: null,
2021-09-11T07:20:19.3985790Z   agent: false,
2021-09-11T07:20:19.3986584Z   servername: 'proxy.xxxx.yyyy',
2021-09-11T07:20:19.3987617Z   _agentKey: 'proxy.xxxx.yyyy:zzzz:'
2021-09-11T07:20:19.3988213Z }
2021-09-11T07:20:19.4000321Z HTTP 22811: sockets proxy.xxxx.yyyy:zzzz: 1
2021-09-11T07:20:19.4010898Z HTTP 22811: outgoing message end.
2021-09-11T07:20:19.4014411Z HTTP 22811: outgoing message end.
2021-09-11T07:20:19.4021290Z (node:22811) Warning: Setting the NODE_DEBUG environment variable to 'http' can expose sensitive data (such as passwords, tokens and authentication headers) in the resulting log.
2021-09-11T07:20:59.2894936Z HTTP 22811: AGENT incoming response!
2021-09-11T07:20:59.2900502Z HTTP 22811: CLIENT socket onRemove
2021-09-11T07:20:59.2904182Z HTTP 22811: removeSocket proxy.xxxx.yyyy:zzzz: writable: true

We can see that GitHub Actions passed the proxy configuration to the action, however node.js refuses to connect to the proxy server.
I believe a successfully connection would look something like the below:
HTTP 7594: call onSocket 0 0
HTTP 7594: createConnection <IP_ADDRESS>:9090: {
  host: '<IP_ADDRESS>',
  port: '9090',
  method: 'CONNECT',
  path: null,
  agent: false,
  headers: { host: 'pipelines.actions.githubusercontent.com:443' },
  servername: 'pipelines.actions.githubusercontent.com',
  _agentKey: '<IP_ADDRESS>:9090:'
}
HTTP 7594: sockets <IP_ADDRESS>:9090: 1
HTTP 7594: outgoing message end.
HTTP 7594: write ret = true
HTTP 7594: outgoing message end.
(node:7594) Warning: Setting the NODE_DEBUG environment variable to 'http' can expose sensitive data (such as passwords, tokens and authentication headers) in the resulting log.
HTTP 7594: AGENT incoming response!
HTTP 7594: CLIENT socket onRemove
HTTP 7594: removeSocket <IP_ADDRESS>:9090: writable: true
HTTP 7594: AGENT incoming response!
HTTP 7594: AGENT socket keep-alive
##[debug]Upload Resource URL: <redacted>
##[debug]File Concurrency: 2, and Chunk Size: 8388608
HTTP 7594: call onSocket 0 0
HTTP 7594: createConnection <IP_ADDRESS>:9090: {
  host: '<IP_ADDRESS>',
  port: '9090',
  method: 'CONNECT',
  path: null,
  agent: false,
  headers: { host: 'pipelines.actions.githubusercontent.com:443' },
  servername: 'pipelines.actions.githubusercontent.com',
  _agentKey: '<IP_ADDRESS>:9090:'
}

Looks like a configuration issue with the Runner. Closing this ticket.


fix(33836): VSCode - generate accessors fixup on readonly field removes modifier

Fixes #33836

@minestarks Could you take a look at these changes?

@jessetrinity Could you review this (long-lived :muscle:) PR?


netlify: fix build

Pin Sphinx to 1.7.9 until https://github.com/sphinx-doc/sphinx/issues/5417 is fixed.

It seems like this should go in a requirements file, not in the netlify script, right? Did you do it this way deliberately?

It works fine locally with Python 2.7.15, which is why I only patched it for netlify. #1483 is a better alternative if it works.

I don't see how this is relevant, since tox is being used. Just to be clear, I tested locally with a virtualenv using Python 2.7.15, and tox -e docs.

@benoit-pierre I think tox keeps a cache. Try deleting .tox and running it again.
In any case, how is the readthedocs version installed? We should probably try and keep netlify and readthedocs in sync as much as possible. I don't have access to the readthedocs config through my regular account, and they want some sort of write permissions for my account when I try to log in through GH, so I am hesitant to do so.

I did delete .tox before testing, and the output shows Sphinx 1.8.0 is being used.

I have no idea how readthedocs is managed.

And yeah, the site is asking for an awful lot of permissions when trying to login-in with Github...

I have no idea how readthedocs is managed.

I think it's configured in the app under my account. I'll try to move the configuration to a declarative file in the repo. I can grant access to the other maintainers as well - just share your rtd username.

In the upstream ticket, users suggested instead pinning to sphinx!=1.8.0, allowing 1.8.1 and later.

I think #1490 is a cleaner approach.


hdfs mesos try to download java 7

Hi all,
The framework tries to download Java 7 at the startup. Is there any possibility to disable this because the cluster is in an offline network ?
VG

the framework needs to install a jre in the mesos container.
I solve this problem by setuping the following parameters in mesos-site.xml
<property>
    <name>mesos.hdfs.jre-url</name>
    <description>The jre download by mesos container</description>
    <value>http://<IP_ADDRESS>/jre-7u76-linux-x64.tar.gz</value>
</property>

But you need to build a download server by nginx for example.
The jre you can download as following
wget https://downloads.mesosphere.io/java/jre-7u76-linux-x64.tar.gz


Pr/topicpull refactor and bug fix

This is my refactor of topicpullImpl.xsl to use XSLT2 as fully as possible.
The commits reflect 5 refactors, done in stages to make review as easy as possible.
All the integration tests pass for me locally except for the test[lang] test, which was already failing on the develop branch (so not related to or affected by this refactor).
I tried to change the business logic as little as possible so that the overall organization of the templates is the same and to minimize the affect on any potential overriders (should there be any).

Please remove all merge commits. Just rebase on top of develop and force push.

The encodeUri function replaces original code that was only escaping spaces. This is more complete and presumably should be  used in other XSLT code that is handling potentially-unescaped URIs. If that case doesn't occur then the function isn't needed. But it's certainly the case that some source documents will not have correctly escaped their URIs and most processors will silently do the escaping.

I just realized that there's one more refactor I wanted to do: remove the use of "#none#" values for testing non-existence. I'll do that after I do all of Jarno's current comments.

Found two no-longer-used templates from the old get-stuff set of templates and removed those. That change will be included in the comment-response commit.

I think we should just remove encodeUri because the assumption is pretty much that Saxon will handle the URI encoding before using it. It we do actually find a case where manual URI clean-up is needed (and hasn't already been done by debug-filterstep), then we can add this to all XSLTs.

LGTM. I'll merge this manually by squashing some of the commits and will handle the testsuite submodule changes.

@drmacro could you rebase on top of dita-ot/dita-ot develop branch, remove the commit that changes the testsuite submodule, and add the test into the current integration test set (that is in the dita-ot/dita-ot repo).

I'm not sure which commit you mean by "the commit that changes the testsuite submodule". I didn't intentionally commit any change to the submodule or the reference to it. Looking through the commit history for the PR branch I'm not seeing a commit for the submodule but I'm not sure I know what to look for.

@drmacro https://github.com/dita-ot/dita-ot/pull/2473/commits/89134bc2a609d3a5f6a0e69cb8064136526e1e81

Removing the commit is beyond my feeble git skills--can you provide guidance?
I've updated my fork to remove the testsuite submodule, synced with the upstream develop branch, and rebase the PR branch to that version of develop.
The commit in question predates the creation of the PR branch so I'm not sure what it means to remove that commit or precisely how to do it.

Maybe I should just cherry-pick the commits that contain the changes we do need.
You can remove a commit by rebasing interactively, and then remove the commit there.

OK. Let me try doing the interactive rebase since it's something I need to know how to do properly. I was trying to delete the commit from my develop branch but that seemed dicey at best.

OK, I think I did what was necessary to remove the commit. Please confirm and then I'll add the test case (although note that the test case is actually for verify the mappull refactor, I just needed to have it present locally so my test doc that also demonstrated the mappull bug would run)

Merged as 6b2b53990ef5c7677db62e629b7102a974fa7acd after commit cleanup.

:information_source: Useful Tip

It may be helpful to compare develop and the feature branch to list all changed files with:
git diff --name-only develop <branch>
If a file has changed (but should not) you can easily grab the original file from develop with:
git checkout develop -- file.xsl
This may be helpful before doing a rebase.


Documentation

We need it. I'd suggest to go the default route with Documenter.jl and DocStringExtensions.jl for auto-documenting fields of structs etc. Any other suggestions?
Where could we host the docs? (Maybe there's also a "default" for that, but I'm not aware of it...)

The default is to host on Github :) I can get this started and we can the fill jointly

Done, you just need to enable the hosting as per #19 and then we need to fill it :)


Harfbuzz demo

This is a demo of how to use harfbuzz to render complex text.
Example style:
https://alanchenboy.github.io/harfbuzzResource/hindi.json.
Screenshots:
.

https://github.com/maplibre/maplibre-native/assets/5135389/f8f294ec-1d20-4106-b745-51d5f4a1af1d.
https://github.com/maplibre/maplibre-native/assets/5135389/7e3857e9-74c4-405e-b12c-e5722cf76919.

@alanchenboy , the example link doesn't appear to be working.

Can we potentially replace some in-house logic for text-shaping with Harfbuzz to lower the maintenance burden?

Very interesting!

Neat, but it looks like we need some build changes.
FYI @alanchenboy  we are transitioning away from the CMake based setup on iOS.
The topic/drawable branch will be merged into main over the coming weeks. https://github.com/maplibre/maplibre-native/blob/topic/drawable/platform/ios/BAZEL.md

Can we potentially replace some in-house logic for text-shaping with Harfbuzz to lower the maintenance burden?

What part of the codebase are you referring to? MapLibre does not do shaping as far as I know. There is just some line breaking code. But Harfbuzz does explicitly not support line breaking.

@wipfli , I was just trying to learn more - didn't understand if this was an alternative to something we already did or an addition.

By shaping, people commonly mean this: https://harfbuzz.github.io/what-is-harfbuzz.html#what-is-text-shaping

@alanchenboy , the example style link doesn't appear to be working.

link Corrected,  you must use this branch to verify render effect.

Neat, but it looks like we need some build changes.
FYI @alanchenboy we are transitioning away from the CMake based setup on iOS.
The topic/drawable branch will be merged into main over the coming weeks. https://github.com/maplibre/maplibre-native/blob/topic/drawable/platform/ios/BAZEL.md

thanks, will look into these changes

Hi everyone, this pr is closed because the main branch changed huge, so I have to refactor all the change, but it auto close when I try to force push


[T4A2][W09-A1]Teo Tian Song

Ready for Review.

@ephyra Some comments added. Please close the PR after reading comments. Please change your profile picture by next tutorial. Thanks


SaveState as json object in MongoDb instead of String

Describe the feature
Save state in MongoDb as Object instead of string.
If you save state using any SDK it will convert to ByteString when communicate with dapr environment and MongoDb Store component will save it just as string and you cannot use MongoDb in full performance with indexing and quering.

Here it will be always saving as string
https://github.com/dapr/components-contrib/blob/7fdebda09b7177dca38137744b9240ed3b223885/state/mongodb/mongodb.go#L181
So we can just try to unmarshall as json it if true - save object, otherwise as is

https://github.com/dapr/components-contrib/blob/7fdebda09b7177dca38137744b9240ed3b223885/state/mongodb/mongodb.go#L198-L199
Do you mean this request makes mongo always handle it as string, not json?

https://github.com/dapr/components-contrib/blob/7fdebda09b7177dca38137744b9240ed3b223885/state/mongodb/mongodb.go#L198-L199
Do you mean this request makes mongo always handle it as string, not json?

In your lines mongo just save value, but in case when value is string it will be saved just as string, if it will be interger as interger, if it will be object it will be saved as object
But "value" will always string when using Dapr api, because it constructed from ByteString

Good catch, are you interested in enhancing it?

Ran into this today. This should be re-opened as it is making MongoDB and the new state query api useless.
When it's persisted as a string it's not 'search-able' as it's not an object.

@rovangju exactly =)
I think it can be fast way - just to trying deserialize to obj when saving, and if ok then save object instead of string.

Bumping this. Ran into this today as well and makes the utility of using the MongoDB state store much less useful for query use cases (at least via the SDK - assuming http api works as a workaround ).  Open to taking a stab at a PR for a fix (outlined pretty well by @shersh already).

@joshdcar a PR would be highly appreciated 👍

@joshdcar Have you tried setting the contentType metadata to application/json similar to code here https://github.com/dapr/java-sdk/blob/master/examples/src/main/java/io/dapr/examples/querystate/QuerySavedState.java#L77.
Does that help?

I think what we need is a case where we check that contentType  as @mukundansundar suggests. If and only if the content type is set as application/json we should try to store this as something other than string.
What needs to happen is for the string to be unmarshalled into bson, but only in the case where the content type was application/json.
Something like this
if contentType, ok := req.metadata['content-type']; ok && contentType == 'application/json' {
var bdoc interface{}
bson.UnmarshalJSON(data, &bdoc)
update := bson.M{"$set": bson.M{id: req.Key, value: bdoc, etag: uuid.NewString()}}
} else {
 // current approach
}

So Kudos to @mukundansundar for the suggestion on content type. I had tried the content type suggestion previously but while digging through the code to make the "Fix" I realized the constant was looking for "contentType" and I had the metadata key set to "Content-Type".  SaveState within API of the GRPC package was already handling data types correctly when the metadata value is set properly.
Live and learn - On the positive side, I now feel a lot more comfortable working with and debugging component-contrib and dapr locally so I'm sure I'll find some other areas to contribute to in the near future :) My sense is the docs could use a little more clarity here. I'll take a look tomorrow and submit a PR with a suggestion - maybe save someone else a bit of time.
Thanks for your help folks - feel free to close this issue.

Thanks for the update @joshdcar. A docs PR would be greatly appreciated 👍

Any news on this? In 1.11 data still are saved as string...


Add from option

Close #5

Coverage increased (+0.1%) to 92.529% when pulling cd970be90df05ec47519ed59de8a17cbe048c12c on pr/add-from-option into d651416311e3b2d9dab75b7cb68c09ec6909457f on master.


187082933 sensor is input

PR for PT-187082933
⚠ currently based on unmerged 187083005-df-servo
⚠ in draft until DF updates are integration ready

[x]  Change Sensor Block to Input Block
[x]  add choice with circle-dot icon that points to pin A1
[x]  reads simulated input pin selected from the sim
[x]  remove the oxygen, light, particles, and soil moisture sensor choices (comment out).
[x]  reads voltage coming in from pin A1 on arduino (adjust arduino sketch)
[x] validate backwards compatibility
[x] cypress test

reimplemented in https://github.com/concord-consortium/collaborative-learning/pull/2260


Sema: Don't allow PackExpansionType in the generic arguments of a ParameterizedProtocolType

We already had a separate TypeResolverContext::ProtocolGenericArgument that
did not allow PackExpansionTypes, but it was never used.
Fixes rdar://problem/115538574.

@swift-ci Please smoke test


gc-stats make npm/yarn crash in nodejs 14

I'm also getting this error, perhaps these lines indicate the issue?
node-pre-gyp WARN Tried to download(403): https://node-binaries.s3.amazonaws.com/gcstats/v1.5.0/Release/node-v83-darwin-x64.tar.gz
node-pre-gyp WARN Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v83 ABI, unknown) (falling back to source compile with node-gyp)
node-pre-gyp http 403 status code downloading tarball https://node-binaries.s3.amazonaws.com/gcstats/v1.5.0/Release/node-v83-darwin-x64.tar.gz

+1

403 issue same there
crawlers_1  | Exit code: 1
crawlers_1  | Command: node-pre-gyp install --fallback-to-build
crawlers_1  | Arguments:
crawlers_1  | Directory: /music-observer/node_modules/gc-stats
crawlers_1  | Output:
crawlers_1  | node-pre-gyp info it worked if it ends with ok
crawlers_1  | node-pre-gyp info using<EMAIL_ADDRESS>crawlers_1  | node-pre-gyp info using<EMAIL_ADDRESS>| linux | x64
crawlers_1  | node-pre-gyp WARN Using needle for node-pre-gyp https download
crawlers_1  | node-pre-gyp info check checked for "/music-observer/node_modules/gc-stats/build/gcstats/v1.4.0/Release/node-v83-linux-x64/gcstats.node" (not found)
crawlers_1  | node-pre-gyp http GET https://node-binaries.s3.amazonaws.com/gcstats/v1.4.0/Release/node-v83-linux-x64.tar.gz
crawlers_1  | node-pre-gyp http 403 https://node-binaries.s3.amazonaws.com/gcstats/v1.4.0/Release/node-v83-linux-x64.tar.gz
crawlers_1  | node-pre-gyp WARN Tried to download(403): https://node-binaries.s3.amazonaws.com/gcstats/v1.4.0/Release/node-v83-linux-x64.tar.gz
crawlers_1  | node-pre-gyp WARN Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v83 ABI, glibc) (falling back to source compile with node-gyp)
crawlers_1  | node-pre-gyp http 403 status code downloading tarball https://node-binaries.s3.amazonaws.com/gcstats/v1.4.0/Release/node-v83-linux-x64.tar.gz

with node:14.15.4

https://node-binaries.s3.amazonaws.com/gcstats/v1.4.0/Release/node-v83-linux-x64.tar.gz

+1


Javascript snippet does not include Sub Resource Integrity parameters

If you are reporting bug/issue, please provide detailed Repro instructions.
Repro Steps

Add the Microsoft.ApplicationInsights.AspNetCore package to a web application
Follow the steps in https://docs.microsoft.com/en-us/azure/azure-monitor/app/asp-net-core#enable-client-side-telemetry-for-web-applications to add client side telemetery
Run the application and inspect the injected javascript

Actual Behaviour
A script tag is added without SRI fields set
Expected Behaviour
Sub Resource Integrity fields to be set on the script tag
Version Info
.NET Version : NetCore 2.2
How Application was onboarded with SDK(VisualStudio/StatusMonitor/Azure Extension) :
OS : Any
Hosting Info (IIS/Azure WebApps/ etc) : Any

@tcarabine, Thank you for your PR!
I'm reluctant to take this PR because our team does not own the "javascript snippet". We get updates from https://github.com/microsoft/ApplicationInsights-js and if I take your bug fix here, we'll lose it the next time we update.
@Markwolff can I transfer this issue to your repo?

Hi @tcarabine we do not include any SRI in the snippet because we update the underlying file on the CDN to enable auto updating. You can welcome to include it for your own implementation, but it will likely break when we roll out updates. To get around this, you can modify the url to the CDN in the snippet to a hardcoded version, e.g. locate ai.0.js in the snippet and change it to ai.<IP_ADDRESS>.js

I'm closing this issue.
if you still have questions, feel free to reopen.


Malformed variable names

Just some thoughts about potential syntax errors which seem unhandled. I don't know if these are actually common mistakes.

Name containing a space, e.g. my name = "Alex"
Name containing a dash, e.g. my-name = "Alex". There is a special message for this but maybe it could suggest underscores instead of -.
Name starting with a number, e.g. 2x = 3 or 2pi * r. In the former case one would point out that this is just an invalid name, in the latter one might suggest 2 * pi.

Issue noted as well as the other one. I do not know if you get notices when a label is applied.

I do not know if you get notices when a label is applied.

I don't, but it's fine.

Moved to #110


Add boilerplate react UI setup with nav and view stubs

This adds boilerplate for a UI using es-react. No compile, no transpile.
Use "npx servor" as command to host from command line, it will update on code change (you will still need to refresh the page)

Look like a good bootstrap. Thanks!


Add 2FA recovery code display on enrollment

Feature to automatically show 2FA backup recovery codes after successful enrollment. Discussed in PR https://github.com/artsy/gravity/pull/13099.
TO-DOs:

Add copy/download functionality on display modal.

Considerations for future:

When I removed all 2FA options and reenrolled, I received the same recovery codes as the prior enrollment. I would expect that if I removed all 2FA accounts that the previous recovery codes would be deleted automatically. @joeyAghion I saw your and @dblandin's discussion on the linked PR but I'm thinking of slightly different use case. Specifically if a user enrolled in 2FA, then at some point disables it and never reenroll's. I think it's worth considering the value of  holding onto potentially sensitive data for a feature the User has chosen not to use.

Jira: https://artsyproduct.atlassian.net/browse/PLATFORM-2412?atlOrigin=eyJpIjoiMmUyYjBkNWNmODVmNGM1MDgwNGRmYmJlM2QxOGRjN2QiLCJwIjoiaiJ9

Can you add a screenshot of what this looks like?

@dzucconi - screenshot: https://drive.google.com/file/d/1CIqv289hnRC_9dst6Ziio-33FM9ZTbeH/view?usp=sharing

@mc-jones - Thanks for adding the link! but if possible, we generally add screenshots embedded directly in to the description so that folks passing by in PR review can quickly see the change.

@damassi - no problem, makes sense! Definitely will do. I was just being overly cautious since this is a public repo and it included my active recovery keys for the test account I was using


Fix live-restore bug

Codecov Report

Merging #277 (550b763) into int (40d3179) will decrease coverage by 0.87%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##              int     #277      +/-   ##
==========================================
- Coverage   69.22%   68.35%   -0.88%
==========================================
  Files          14       14
  Lines        1511     1520       +9
==========================================
- Hits         1046     1039       -7
- Misses        358      374      +16
  Partials      107      107

Impacted Files
Coverage Δ

dnsconfig.go
53.29% <72.72%> (+0.76%)
:arrow_up:

eventhandler.go
59.31% <0.00%> (-3.81%)
:arrow_down:

procmon_linux.go
70.37% <0.00%> (-2.23%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Marks Spreadsheets don't allow decimal out-of values

http://review.markusproject.org/r/1172/

Thank you! Knocking off issues in record time ;-)


Inference on CPU

Hi @L1aoXingyu
I wanted to do inference on PCU to get the time. But it does not happen if I change MODEL.DEVICE in the config file.
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!
I think somewhere it is going on cuda by default
Can you help it in this?

Sorry for the late reply. Would you please show me the command you use?


add feature in homepage on media

@codiebeulaine please update the template with the trans blocks other wise 👍 🍰 🍰


Publish as a nuget package that contains the binarys directly

Xamarin.Auth on nuget is currently published as a forwarder to a component in Xamarin store.
Please embed the binarys directly inside the nupkg just like Android support libraries.

We are deprecating the Component store, and migrating all the existing packages to Nuget.
Now complete package should be available in the nuget ste


Fix Undefined Error on Exception

num_folders is undefined and probably num_classes is meant. But as the UndefinedError happens in an exception, the program fails anyway.

Can one of the admins verify this patch?

LGTM, thanks.
@vrv feel free to pull (let me know if there is a different protocol to signify changes are ready, I'll just reassign to you)

Merged


Memory is full after ETL process finish

OrientDB Version: <3.0.13>
Java Version: <1.8.0_131>
OS: <Red Hat 7.4>
Memory:16G
Vcpu: 8
After importing data from Oracle database (8 millions record, 8 millions vertex,24 millions edges), the memory has only 1 GB free noting that the total size is 16GB.
Here the configuration for Server.sh
ORIENTDB_SETTINGS="-Dstorage.diskCache.writeCachePageTTL=3600 -Dstorage.useWAL=false"
ORIENTDB_OPTS_MEMORY="-Xms1G -Xmx3G"
here the configuration "orientdb-server-config
.xml"
Config.zip

Any update on this issue?


Support using a pager with mercurial diff

This is documented for git, but not for mercurial.

Is there a recent solution to this matter?

The command motivated me to start working.
 GIT_PAGER_IN_USE=1 hg dft | less


Lightgbm: add note about libomp to our install docs

@cmancuso noticed that lightgbm failed locally for him on his mac until he ran brew install libomp:
[info] E               Exception: An exception occurred while trying to import `lightgbm`: dlopen(/Users/.../Documents/dev/.../env/lib/python3.8/site-packages/lightgbm/lib_lightgbm.so, 6): Library not loaded: /usr/local/opt/libomp/lib/libomp.dylib
[info] E                 Referenced from: /Users/.../Documents/dev/.../env/lib/python3.8/site-packages/lightgbm/lib_lightgbm.so
[info] E                 Reason: image not found

Let's verify that this is needed in order to use lightgbm, and add a mention of this to our install docs.
RE unit test coverage: our CI jobs run on windows and linux, not mac. That said, let's verify that we have unit tests which would at least fail locally on mac if libomp is missing.

@dsherry Do you mean to add unit tests that would fail if libomp is missing, or do you mean that we should check whether the LightGBM tests fail when libomp is missing?

@bchen1116 the latter. Our CI jobs don't run on mac right now, and I don't think we should try to set up a mac-based CI job today. I was suggesting let's make sure that if libomp is missing locally on your mac, we have at least one unit test which would fail, and our docs mention the requirement.
So:

Verify that you have libomp installed on your machine.
Run all the unit tests locally, verify they all pass.
Uninstall libomp on your machine
Run all the unit tests locally, note which fail
If at least one fails, we've verified that libomp is required install on mac in order for lightgbm to work. We should add a note about this to our install guide -- can create "Mac" section at bottom.
If none fail, we should follow up with Chris and try to understand what happened

@dsherry gotcha. The tests for LightGBM do fail when libomp isn't installed, and pass when it is. Creating the PR now.


Does not work in react .13

In 0.13 I receive the error.  Likely due to depreciation of renderComponent
"Cannot read property '__reactAutoBindMap' of null

I've been looking at this for a few hours now and I can't seem to figure out exactly what is causing the error here.

perhaps this: When migrating your code, you may want to use new React.cloneElement API (which is similar to React.addons.cloneWithProps but preserves key and ref and does not merge style or className automatically).

This should be fixed in master, look out for a 0.5.0 release on the horizon after some merges.


BuildVM function added

duplicite block for VM creation converted to function

@mcpjanmarek,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@mcpjanmarek, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

added to Dev


Add graphs

Do the checklist before submitting the PR:

[ ] Have you read the guidelines mentioned in CONTRIBUTING.md?
[ ] Have you squashed your commits?

Q: What version of Node.js you've used in the project? (e.g. Node v10.11.0)
A:
Q: Mention the Issue Number! (e.g. Fixed #8)
A:

Give additional information regarding the PR below:

I have fixed the issue

Codecov Report

Merging #99 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #99   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          55     56    +1
  Lines         672    719   +47
=====================================
+ Hits          672    719   +47

Impacted Files
Coverage Δ

src/index.js
100% <100%> (ø)
:arrow_up:

src/graph/index.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850a49e...31bb197. Read the comment docs.

This is the proper version. Kindly verify if all expectations have been met.

Wow, this is crazy. Last night it showed no errors at all. I'll fix them.

Fixed everything as per Codacy


Format on save add garbage to the file

VSCode Version: 1.30.0
OS Version: Ubuntu 18.04
During C++ editing
Steps to Reproduce:
Enable clang-format
configure format on save "editor.formatOnSave": true
modify multiple files and copy / paste stuff
sometimes (much more frequently after code update to 1.30) autoformat on save pastes garbage into the file.
Extensions enabled
Extensions Added:
clang-format v1.8.0
cmake v0.0.17
cmake-tools v1.1.3
code-settings-sync v3.2.4
cpptools v0.20.1
dark-plus-material v1.4.5
doxdocgen v0.4.1
Doxygen v1.0.0
flatbuffers v0.1.0
gitlens v9.2.0
hg v1.2.3
linkerscript v1.0.0
material-icon-theme v3.6.1
meson v1.1.1
python v2018.12.0
QML v1.0.0
vsc-material-theme v2.6.2
vsc-qml-snippets v0.0.2

I have the same problems.
Are there any workarounds to solve this?

In my setup I discovered that the problem was the symbolic link in the path.
Without any I've never experienced other problems.

In my setup I discovered that the problem was the symbolic link in the path.
Without any I've never experienced other problems.

I forgot to mention that I am on Windows. :)

Maybe a Junction :D

Same issue here on Arch Linux (64bit).
I've noticed that usually happen when I switch from header/source (.h <-> .cpp) and VS Code reopens, by mistake, the file (that was already opened) in a new tab (specifying the full path in the tab name).
It also happen when MS-VScode.cpptools plug-in struggles to parse the code (when I use a lot of lambda expression or structured binding), so I guess that is someway related to the same thing, but I cannot understand why it paste random garbage across my file!
clang-version: 8.0.1
VS Code: 1.37.1
Plug-in version: 1.9.0


Open a merge sort chapter and I can start with a JS and Ruby implementation of it.

Open a merge sort chapter and I can start with a JS and Ruby implementation of it.

Sorting methods are not on my priority list here. They are certainly important, but most sorting algorithms are well-explained elsewhere. That said, if you want to open a merge sort chapter, you can do so as soon as #569 is merged. It might be a lengthy review process, though.


Introduce much more detailed setState error messages

Fixes #66.
This PR replaces the single "you can't use setState here" message with a bunch of new messages, each tailored to the exact case.
They give much more useful information, and where possible, where to put your setState call instead.
It also catches an extra case where the render and reconciliation steps were not being guarded, specifically during reify.

Coverage increased (+0.3%) to 88.689% when pulling 830f8b76d1ccdd93febb7f7d6c095a7d75ca5407 on new-setstate-checks into 7f481756a650070ae2dab28d3d4d1da7d04cac60 on master.

All of the messages are updated.
Any other feedback?

Nah, LGTM!

LGTM as well


swtich to PS handling target size

at this point we only want to need to  use exact bounds for layer comps with resizing causes.

requires https://github.com/adobe-photoshop/generator-core/pull/356

Looks reasonable.  I am curious about pixmapSettings.documentBounds = true  ... was that a bug you found while testing?

document bounds was a rathole i went down to try and get layercomps to export correctly from PS the first time. I backed out the changes, (except for that one)

Getting a g-a-a test failure against m.154.  Can you check it out @pineapplespatula

@mcilroyc Is webP still failing for you? I've never managed to figure out why webp is so inconsistent.

I am seeing one webp-lossy test fail (maui) but it fails on master too, so we can address that separately.  @pineapplespatula I want to make sure that doesn't get swept under the rug during the FLITE redux (for g-a-a).  https://cl.ly/3P2H001L280P

since FLITE doesnt support webp it shouldnt get swept away


Document Build Pipeline

webpack / Babel / PostCSS
Along with JavaScript / CSS production bundling

other work to be done in #31


fix(table): eliminate need for second change detection

Should fix issue with the router and others since now the table does not assume it will have change detection run twice. Now finishes all of its rendering in one pass
Fixes #5593
Fixes #5914

Merge please :)

@kara Please add a comment describing the presubmit failures

One app was failing with "changed after checked" errors. @andrewseguin has already looked into this and has a fix for the app once the next sync goes in.


RichTextEditor cycle in updateUIView

Hello,
The following code in RichTextEditor causes swift warning Publishing changes from within view updates is not allowed, this will cause undefined behavior. Also because we update UI from within updateUI function, it causes infinite loop and does not allow to get past the point.
public func updateUIView(_ view: UIViewType, context: Context) {
        textView.attributedString = text.wrappedValue
        richTextContext.highlightedRange = nil // This causes cyclic update to UIView
    }

https://github.com/danielsaidi/RichTextKit/assets/17381941/2431bbfd-8cb1-4e83-be21-1c698bd3bf33
Workaround:
Delete the assignment of highlightedRange
Xcode Version: 14.3 (14E222b)
iOS 14 Simulator (or any other)

I noticed this too. The new release adds a dispatch queue main async around it, but I think it may still stutter a bit. I will investigate and see if we need a patch update.

Hi again @DominikBucher12
I could reproduce the error and have removed all code from the update functions.
The bug fix is available in the 0.6.1 patch version.
Thanks for notifying me! 👍


Sync controller mappings DB with SDL2 community repo [Nov 2024]

Synced with https://github.com/mdqinc/SDL_GameControllerDB/commit/cfc2bffe0ad29fea2bec7a0f4cb19dead5703ea8
This fixes Issue https://github.com/godotengine/godot/issues/83178 and supersedes PR https://github.com/godotengine/godot/pull/92696
This PR / commit takes inspiration from several commits by @akien-mga over years to sync controller mappings DB; it just happens that updating it, fixes my issue.

cc. @akien-mga @Sauermann

Thanks!


Dependencies: observability updates

Signed-off-by: moderation<EMAIL_ADDRESS>
fmt 7.0.3 (release notes)
spdlog 1.7.0 (release notes)
Lightstep tracer - closes https://github.com/envoyproxy/envoy/issues/12750
msgpack 3.3.0 (release notes)

Risk Level: Low
Testing: bazel --nohome_rc build @envoy_api//envoy/..., bazel --nohome_rc test //test/...
Docs Changes: none required
Release Notes: none required

Looks like https://github.com/lightstep/lightstep-tracer-cpp/compare/v0.13.0...master#diff-84bb10f50b1e594579a9bf23b21bec59R187 is breaking MacOS build /cc @rnburn. Will likely back off to release 0.13.0 until this can get sorted.

/cc @htuch as @lizan may be out of the office


ValueError: too many subscripts in einsum for a circuit containing controlled RZXGate

Environment

Qiskit version: 1.0.2
Python version: 3.11.8
Operating system: Ubuntu 22.04.3 LTS

What is happening?
Running the below code results in the exception copied in the "What should happen" section. I would expect the code to run without error.
This crash happens for num_ctrl_qubits>=9. For num_ctrl_qubits<9, the program hangs for a long time and I need to kill the process.
How can we reproduce the issue?
from qiskit import QuantumCircuit, ClassicalRegister, QuantumRegister
from qiskit.circuit.library.standard_gates import RZXGate

qr = QuantumRegister(11, name='qr')
cr = ClassicalRegister(11, name='cr')
qc = QuantumCircuit(qr, cr, name='qc')
qc.append(RZXGate(0.7773868957129396).control(num_ctrl_qubits=9, ctrl_state=0).power(1), qargs=qr, cargs=[])

What should happen?
Traceback (most recent call last):
  File "/mnt/tests/reproduction/reproduce_too_many_subscripts_in_einsum.py", line 7, in <module>
    qc.append(RZXGate(0.7773868957129396).control(num_ctrl_qubits=9, ctrl_state=0).power(1), qargs=qr, cargs=[])
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/anaconda3/envs/qiskit1.0.2/lib/python3.11/site-packages/qiskit/circuit/gate.py", line 81, in power
    return UnitaryGate(Operator(self).power(exponent), label=f"{self.name}^{exponent}")
                       ^^^^^^^^^^^^^^
  File "/root/anaconda3/envs/qiskit1.0.2/lib/python3.11/site-packages/qiskit/quantum_info/operators/operator.py", line 97, in __init__
    self._data = self._init_instruction(data).data
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/anaconda3/envs/qiskit1.0.2/lib/python3.11/site-packages/qiskit/quantum_info/operators/operator.py", line 707, in _init_instruction
    op._append_instruction(instruction)
  File "/root/anaconda3/envs/qiskit1.0.2/lib/python3.11/site-packages/qiskit/quantum_info/operators/operator.py", line 785, in _append_instruction
    self._append_instruction(instruction.operation, qargs=new_qargs)
  File "/root/anaconda3/envs/qiskit1.0.2/lib/python3.11/site-packages/qiskit/quantum_info/operators/operator.py", line 762, in _append_instruction
    op = self.compose(
         ^^^^^^^^^^^^^
  File "/root/anaconda3/envs/qiskit1.0.2/lib/python3.11/site-packages/qiskit/quantum_info/operators/operator.py", line 505, in compose
    Operator._einsum_matmul(tensor, mat, indices, shift, right_mul), final_shape
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/anaconda3/envs/qiskit1.0.2/lib/python3.11/site-packages/qiskit/quantum_info/operators/operator.py", line 693, in _einsum_matmul
    return np.einsum(tensor, indices_tensor, mat, indices_mat)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/anaconda3/envs/qiskit1.0.2/lib/python3.11/site-packages/numpy/core/einsumfunc.py", line 1371, in einsum
    return c_einsum(*operands, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: too many subscripts in einsum

Any suggestions?
No response

Right now, all the chained methods on Gate, like control and power do things eagerly and (largely) non-symbolically.  This means that your code is attempting to build an 11q matrix and decompose it.  It so happens that there are a couple of tensor contractions we do in places that have happened to explode here, but that eager synthesis is the main problem you're seeing.
You can switch to our (somewhat experimental) symbolic representations of control and power operations by passing annotated=True to the Gate.control and Gate.power methods, but beware that at the moment, we'll still be using inefficient syntheses during transpilation for those.  We're working on improving that, though - you can see some discussion in #11823.

I think this method should work for generating a multi-controlled RZ gate:
q_controls = list(range(num_ctrl_qubits))
q_target = num_ctrl_qubits
qc.mcrz(0.7773868957129396, q_controls, q_target)


Reaction Not Applying (CUB, MIDIQol)

Hello,
I'm not certain what interaction between modules I've got that is causing this problem. I have a custom status named "Reacted" and have properly entered that name per the instructions, but I noticed in other people's submissions that there have been problems with how CUB renames its statuses on the back end.
Please let me know if you need further information.

What type of chat cards are you using for midi?
This is failing to recognise what type of action is being used, not what condition to use for the effect.

I believe this is the section you're referring to. Let me know!

After updating all my modules between the time of my previous posting and now, without changing anything, the reaction condition is being properly added and removed.

Would be interested to know the source, but I did add a few more failsafes for "weird" tokens. I'll claim credit regardless! 😆
Happy gaming 😄


Infinite loading in splash screen

Summary:
The app doesn't open when the Wi-Fi is on, but when I open the app without the Wi-Fi on, and then turning it on, it doesn't work either.
Steps to reproduce:
Just open the app
Device and Android version:
Samsung Galaxy S6 edge
Android 7.0 (touchwiz)
Screen-shots:

Duplicate Issue #793  @teolemon

Is there a working solution for this?

https://github.com/openfoodfacts/openfoodfacts-androidapp/pull/858 Here's an ongoing PR for this issue

Before closing this issue, I would like clarification that this is the same issue. Leave this open for now, but I would like this issue tested again once #858 is merged, to see if this resolves the issue.

@Karljoones https://github.com/openfoodfacts/openfoodfacts-androidapp/pull/858 Merged You can confirm and close this one now.


[SPARK-42592][SS][DOCS][FOLLOWUP] Add missed commit on reflecting review comment

What changes were proposed in this pull request?
This PR addressed missed commit on reflecting review comment (https://github.com/apache/spark/pull/40188#discussion_r1119055652) from previous PR #40188.
Why are the changes needed?
Previously pushed commit didn't reflect all review comments.
Does this PR introduce any user-facing change?
Yes, documentation.
How was this patch tested?
N/A.

cc. @HyukjinKwon @viirya Sorry to bug you but can I get another quick review for this? My bad.

Thanks! Merging to master/3.4.

Looks good to me.


[BUG] Mount NVG plugin order fail

Describe the bug
When I try to send the order to mount the NVG goggles, the ground crew instead rearm the plane. The plugin give a diferent order.

are you in single player or MP? Currently my request HMD or request NVG command is functioning as expected in cold and dark IA missions in the hornet.

Mine are functioning correctly in SP and MP currently as well. We need more information like your log when this happens.

¿Estás en un solo jugador o MP? Actualmente, mi comando Request HMD o Request NVG está funcionando como se esperaba en misiones IA frías y oscuras en el Hornet.

Regardless of whether it is MP or not, the NVGs do not work for me, specifically in the F16. I have also tried the HMD and it does not work either, it does not matter: rearming complete.

In the F18 doesn't go too.

This command doesn't work for me either, neither does the "request HMD" command. Every time I use it, they respond with "rearming complete". However VA reconigzes it well. I leave you a video that I have recorded to see what happens:
https://www.youtube.com/watch?v=bx1TlYqvnNw

To be clear, the will respond with rearming complete. Are you cycling the HMD or NVGs to make sure they are being put on?

Yes i do, in the video after the first try with Vaicom calling "request NVG" and get the "Copy" and "rearming complete" i try with Rshift+H to put night googles and is not working (you can't see it but i really try in my keyboard and HOTAS), however when i did trough the menu ground crew respond with "NVG installed" and  is working with Rshift+H, and then i try to install HMD and the crew respond "HMCS installed" but if i try both commands with Vaicom, the answer is always "Rearming complete"

With newest version continue this problem.

I can confirm the behaviour, appears associated with a different menu tree in use now - Thanks for the report.

Thanks to you, my friend and Merry Christmast


normative: alter formatToParts output

Alter the result of formatToParts based on implementer feedback.
Fixes: https://github.com/tc39/proposal-intl-duration-format/issues/55
cc @FrankYFTang @sffc @romulocintra

I do not believe this PR will create the correct result. Just try some simple case and you will see it won't

@FrankYFTang I realized that and therefore made a comment on #55 and mark it as draft. In order to make this work, I'll first need to make an editorial PR to ecma402.

oh. I see. "Draft" has very different meaning in different proposal.

@FrankYFTang I'm going to present this to the plenary and merge it once approved. Your explicit review would be helpful if you have the time.

new Intl.DurationFormat('en-US', { fractionalDigits: 3, millseconds: 'numeric' }).format({ hours: 7, minutes: 8, seconds: 9, milliseconds: 123, microseconds: 456, nanoseconds: 789 });
/* [
    {type: 'integer', value: '7'},
    {type: 'literal', value: ' '},
    {type: 'unit', value: 'hr'},
    {type: 'literal', value: ', '},
    {type: 'integer', value: '8'},
    {type: 'literal', value: ' '},
    {type: 'unit', value: 'min'},
    {type: 'literal', value: ' and '},
    {type: 'integer', value: '9'},
    {type: 'decimal', value: '.'},
    {type: 'fraction', value: '123'},
    {type: 'literal', value: ' '},
    {type: 'unit', value: 'sec'},
] */

Please also include the unit: "XYZ" field in the parts where relevant.

Example formatToParts output based on this change:

could you also use similar approach to illusrate what would be the output while the style is "digital" ?
const df = new Intl.DurationFormat('en-US', { fractionalDigits: 3, style: 'digital', second: 'numeric', millseconds: 'numeric' });
const a = df.format({ hours: 7, minutes: 8, seconds: 9, milliseconds: 123, microseconds: 456, nanoseconds: 789 });
what should a be?

@sffc

Please also include the unit: "XYZ" field in the parts where relevant.

Good catch! Will do.
@FrankYFTang

could you also use similar approach to illusrate what would be the output while the style is "digital" ?

Sure.

@sffc

Please also include the unit: "XYZ" field in the parts where relevant.

I'd missed out a line change by accident, now the unit property should be properly shown. Updating the example.

still waiting to see the example of the expected output with unit and while the style is "digital" (and with value in microseconds and nanoseconds)

Hello! Sorry for the delay, I was on vacation. Here's an example:
const df = new Intl.DurationFormat('en-US', { style: 'digital', fractionalDigits: 9, millseconds: 'numeric' });
const a = df.format({ hours: 7, minutes: 8, seconds: 9, milliseconds: 123, microseconds: 456, nanoseconds: 789 });
const b = [
    {type: 'integer', value: '7', unit: 'hours'},
    {type: 'literal', value: ':'},
    {type: 'integer', value: '8', unit: 'minutes'},
    {type: 'literal', value: ':'},
    {type: 'integer', value: '9', unit: 'seconds'},
    {type: 'decimal', value: '.', unit: 'seconds'},
    {type: 'fraction', value: '123456789', unit: 'seconds'},
];
assert.equals(a, b);

This result is according to the current spec, but it doesn't "look" correct, but we need a zero pad all the numbers in the digital style? Or should I try to only zero pad the second and following units instead, leaving the first unpadded? The latter would require more spec changes.

OK except that unit strings should be singular per the discussion in https://github.com/tc39/ecma402/blob/master/meetings/notes-2022-12-08.md#singularplural-consistency-of-property-in-table-1-components-of-duration-instances-against-temporal-and-intledatetimeformat-44

@sffc good catch! I'd missed that, now the spec should use singular units for the formatToParts output.

Is that true that the example in https://github.com/tc39/proposal-intl-duration-format/pull/126#issuecomment-1376080304 should be change to output singlar unit now? If so, please update it.

@FrankYFTang that is indeed correct. I updated both examples to reflect this.

Perfect! IIUC this doesn't have TG1 and TG2 consensus and would need to wait for that to be merged, right?

TG2 consensus: https://github.com/tc39/ecma402/blob/master/meetings/notes-2023-01-12.md#normative-alter-formattoparts-output

Hello! Sorry for the delay, I was on vacation. Here's an example:
const df = new Intl.DurationFormat('en-US', { style: 'digital', fractionalDigits: 9, millseconds: 'numeric' });
const a = df.format({ hours: 7, minutes: 8, seconds: 9, milliseconds: 123, microseconds: 456, nanoseconds: 789 });
const b = [
    {type: 'integer', value: '7', unit: 'hour'},
    {type: 'literal', value: ':'},
    {type: 'integer', value: '8', unit: 'minute'},
    {type: 'literal', value: ':'},
    {type: 'integer', value: '9', unit: 'second'},
    {type: 'decimal', value: '.', unit: 'second'},
    {type: 'fraction', value: '123456789', unit: 'second'},
];
assert.equals(a, b);

I think these integer values in minute and second are 08 and 09 since

hour is numeric style because of digital default.
So, in https://tc39.es/proposal-intl-duration-format/#sec-getdurationunitoptions, prevStyle is numeric, and 6.b makes minute and second 2-digits

@Constellation ah, great, thanks! I knew I was missing something but wasn't entirely sure. Will update the examples.

2023-01-31: TG1 consensus (notes link TBW)

ok, I finally recover from my sickness and have time to revise my v8 implementation after the landing of this PR. @ryzokuken could you review and confirm the following two test262 tests truthfully reflect the spec text after the landing of this PR?
https://github.com/tc39/test262/blob/main/test/intl402/DurationFormat/prototype/formatToParts/formatToParts-styles-en.js
and
https://github.com/tc39/test262/blob/main/test/intl402/DurationFormat/prototype/format/style-options-en.js

I belive the current spec text still not generating desired result for formatToParts
Say we have
const duration = {
  days: 2,
  hours: 7,
  minutes: 8,
  seconds: 9,
  milliseconds: 123,
  microseconds: 456,
  nanoseconds: 789,
};
let df = new Intl.DurationFormat('en', { style: "digital", fractionalDigits: 9});
let str = df.format(duration);
let out = df.formatToParts(duration);

I think the out should be
str == "2 days and 7:08:09.123456789"
out == [
  { type: "integer", value: "2", unit: "day" },
  { type: "literal", value: " ", unit: "day" },
  { type: "unit", value: "days", unit: "day" },
  { type: "literal", value: " and " },
  { type: "integer", value: "7", unit: "hour" },
  { type: "literal", value: ":" },
  { type: "integer", value: "08", unit: "minute" },
  { type: "literal", value: ":" },
  { type: "integer", value: "09", unit: "second" },
  { type: "decimal", value: ".", unit: "second" },
  { type: "fraction", value: "123456789", unit: "second" },
]

But the current spec text still does not do so.

sorry I was wrong earlier. I think after DeconstructPattern take the subst as a List, it now work.


Move pkg/api to pkg/apis/servicecatalog

In accordance with how API groups are handled in Kubernetes per #79

Gonna need this for the apiserver.

Not thrilled with the verbose flag being on now, but let's see how other people feel.
In the meantime. LGTM

I'm fine with this. My vote would be to file issues for later improvements rather than hold this PR up with non-major blockers.

verbosity is a debugging thing, I'll fix it.

Fixed, PTAL

@pmorie thanks. Still LGTM once you guys settle on "api" vs "apis"  :-)

why all one word? can we have a dash?

@MHBauer I don't know the origins of the convention, but I ask that we accept it for now.

@deads2k do you know the origin of the convention for api group package names without dashes?

@deads2k @MHBauer we need to feed back description of the convention into https://github.com/kubernetes/kubernetes/blob/master/docs/devel/adding-an-APIGroup.md

@pmorie That looks promising. I haven't seen that before. Thanks!
I've read api-conventions a couple dozen times by now for TPRs. That is a pretty fine document.

@martinmaly I believe your reservations are settled on this particular matter now?

yep.


feat(mqtt): add node lastActive topic

Fixes #2896

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 35 (17.14%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 24.285%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/ZwaveClient.ts
0
3
0.0%

lib/Gateway.ts
6
32
18.75%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
3790

Relevant Lines:
16483

💛  - Coveralls


Verification of tst with openssl is failing

I am using your client gui to create the tst file. The timestamping authority I am using is "https://freetsa.org/tsr". The tst file is successfully created.
However the verification with openssl is showing the following error:
openssl ts -verify -data file.exe -in file.exe.tst -CAfile freetsa.pem -untrusted freetsa2.pem
Verification: FAILED
13376:error:0D0680A8:asn1 encoding routines:asn1_check_tlen:wrong tag:crypto\asn1\tasn_dec.c:1130:
13376:error:0D07803A:asn1 encoding routines:asn1_item_embed_d2i:nested asn1 error:crypto\asn1\tasn_dec.c:290:Type=TS_STATUS_INFO
13376:error:0D08303A:asn1 encoding routines:asn1_template_noexp_d2i:nested asn1 error:crypto\asn1\tasn_dec.c:627:Field=status_info, Type=TS_RESP
The version of openssl is OpenSSL 1.1.1d  10 Sep 2019.
I can reproduce the problem with the timestamping authorities "https://freetsa.org/tsr" and "https://www.safestamper.com/tsa".

@steamonimo, the application saves time-stamp token, not the time-stamp response. You need to add -token_in to the verification command.
openssl ts -verify -data file.exe -in file.exe.tst -token_in -CAfile freetsa.pem -untrusted freetsa2.pem

Thanks, now the verification is working. Wouldn't it be helpful to have a choice between time-stamp response or token as a parameter to the call perhaps? In my case I am switching from openssl and thus have time-stamp responses. To continue this with your client it would be helpful to save the response.


Add Sync Status and Latest Deployment Time (#751, #879)

Signed-off-by: Keith Chong<EMAIL_ADDRESS>What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
For dev console enhancements
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes 751 and 879
How to test changes / Special notes to the reviewer:
The new tests added for sync status and last deployed times should adequately cover the back-end code changes for this enhancement.  UI testing is still required which will also test these changes.

please add info to  "how to test" .

please add info to "how to test" .

I added more tests to represent multiple environments, and multiple deployment histories. (at least 2 should be enough).

/lgtm
/approve
thanks @keithchong


fix: start telemetry independently from the API server

fix(telemetry): start telemetry independently from the API server (#12448)

fix unlock

add changelog

Update CHANGELOG.md

Co-authored-by: Aleksandr Bezobchuk<EMAIL_ADDRESS>
Description

closes: #XXXX
Motivation and context

How has this been tested?

Screenshots (if appropriate):
Checklist:

[x] I followed the contributing guidelines and code of conduct.
[x] I have added a relevant changelog to CHANGELOG.md
[ ] I have added tests to cover my changes.
[ ] I have updated the documentation accordingly.
[ ] I have updated API documentation client/docs/swagger-ui/swagger.yaml

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: tkxkd0159:x: robert-zarembaYou have signed the CLA already but the status is still pending? Let us recheck it.


Do sparse checkout when cloning a git repo

Is your feature request related to a problem? Please describe.
When fetching templates from the git source, Cyclops clones the entire repo. It would be better, memory wise, to clone only the subtree of the repo.

Hey @petar-cvit we can use the git commands like git sparse and git depth and filter. Git sparse will be the specific one.

@RohanMishra315 are you working on this ?

@RohanMishra315 are you working on this ?

Yes

Oh! Sorry to step in but I've been working on this issue a day or two after this issue was opened and I'm close to completion

@petar-cvit can you please let me know in this repo where is that path variable located that is used to take input from user when adding a template, I went through template.go file but I'm still having doubts

Thanks guys for picking this one up! I played around with this issue for a while, and I'm not sure it will help us.
The idea was to reduce the amount of content we clone when fetching a template by cloning just one subloder of a repository. I was hoping it would take less RAM, but even with sparse checkout, it seems like you still need to clone the whole repository and then sparse checkout that subfolder.
I'll close the issue for now, but if you find it to be useful feel free to comment it here and I'd be happy to discuss

Thanks guys for picking this one up! I played around with this issue for a while, and I'm not sure it will help us. The idea was to reduce the amount of content we clone when fetching a template by cloning just one subloder of a repository. I was hoping it would take less RAM, but even with sparse checkout, it seems like you still need to clone the whole repository and then sparse checkout that subfolder. I'll close the issue for now, but if you find it to be useful feel free to comment it here and I'd be happy to discuss

Alright 👍


removing axes-modifiers completely

There are still some "axes_modifier" left around in the code, for example in get_cmorname()
We should remove all the occurrences and make sure their role is taken care of by other attributes like calculation etc.

This has been done on branch pattern with the simplification of axes handling see #180


Enable testing of images in Azure using terraform

This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] create a file in news/unreleased directory if this change should be mentioned in the release news
[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

Hi @atodorov, I believe it's finally ready for review, could you please take a look at this and share your thought about this?
I took aws.sh as a template and made it work with azure with some changes and this is basically how it works:

Osbuild-composer is deployed and all the dependencies are installed first (like azure-cli and terraform)
Then a basic blueprint and azure config is created which is needed for composer-cli
Compose is started which uploads the created image as a page blob to the specified azure storage account and container
Terraform is initialized then which downloads it's own dependencies and prepares to run
The previously uploaded page blob is imported into terraform which makes terraform aware of it's presence and can work with it
terraform plan reads the main.tf file and runs whatever is specified there
The main.tf file is a modified example from the docs with a few additions, I believe it contains the minimum that is needed to spin up a linux vm there
After the vm is up it checks for the smoke-test.txt file which is created by cloud-init
terraform destroy then deletes everything including the page blob uploaded by composer-cli

Please remove the second commit. I'm marking this as a draft so we don't merge it.

Please remove the second commit. I'm marking this as a draft so we don't merge it.

I wanted to do that once I get a review on the test and apply any additional changes, but you're right, it could have been merged like this by accident. Thanks for pointing it out :)

Hi @atodorov and @ondrejbudai , I believe it's ready for another round of review. I addressed your comments and also made sure cloud-cleaner cleans up the created resources if the script fails and terraform destroy is not ran. There are some failures from Schutzbot but I don't think they're related, one seems to be lost connection to slave and I'm not sure what happened with the other.

The test reports PASS but I see something which doesn't look well:

[2021-04-30T18:48:51.367Z]                                                                                -> github.com/Azure/azure-pipeline-go/pipeline.NewError, /builddir/build/BUILD/osbuild-composer-d50ef703d50e225d68c88a44eef81527feb9f943/_build/src/github.com/osbuild/osbuild-composer/vendor/github.com/Azure/azure-pipeline-go/pipeline/error.go:157

[2021-04-30T18:48:51.367Z]                                                                                HTTP request failed

[2021-04-30T18:48:51.367Z]

[2021-04-30T18:48:51.367Z]                                                                                Put "https://travisciuploads.blob.core.windows.net/travisciuploads/image-rhel_84-x86_64-PR-1358-44.vhd?comp=page&timeout=61": read tcp <IP_ADDRESS>:36458-><IP_ADDRESS>:443: read: connection reset by peer

This is at the end of the upload to Azure. Not sure if a real error but maybe we need an error check after commands in the script.
Then I see:
 🛃 Checking for smoke test file

[2021-04-30T18:54:56.536Z] ssh: connect to host <IP_ADDRESS> port 22: Connection refused

[2021-04-30T18:55:01.802Z] ssh: connect to host <IP_ADDRESS> port 22: Connection refused

[2021-04-30T18:55:07.069Z] Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.

[2021-04-30T18:55:08.443Z] Smoke test passed! 🥳

this looks like a retry sequence and the wording can be updated to make it more clear that we're retrying to connect so we don't have to wonder if this is an error or not.

The test reports PASS but I see something which doesn't look well:

[2021-04-30T18:48:51.367Z]                                                                                -> github.com/Azure/azure-pipeline-go/pipeline.NewError, /builddir/build/BUILD/osbuild-composer-d50ef703d50e225d68c88a44eef81527feb9f943/_build/src/github.com/osbuild/osbuild-composer/vendor/github.com/Azure/azure-pipeline-go/pipeline/error.go:157

[2021-04-30T18:48:51.367Z]                                                                                HTTP request failed

[2021-04-30T18:48:51.367Z]

[2021-04-30T18:48:51.367Z]                                                                                Put "https://travisciuploads.blob.core.windows.net/travisciuploads/image-rhel_84-x86_64-PR-1358-44.vhd?comp=page&timeout=61": read tcp <IP_ADDRESS>:36458-><IP_ADDRESS>:443: read: connection reset by peer

This is at the end of the upload to Azure. Not sure if a real error but maybe we need an error check after commands in the script.

I was not able to reproduce it manually and can't see it when ran again, not sure what to do here...

Then I see:
 🛃 Checking for smoke test file

[2021-04-30T18:54:56.536Z] ssh: connect to host <IP_ADDRESS> port 22: Connection refused

[2021-04-30T18:55:01.802Z] ssh: connect to host <IP_ADDRESS> port 22: Connection refused

[2021-04-30T18:55:07.069Z] Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.

[2021-04-30T18:55:08.443Z] Smoke test passed! 🥳

this looks like a retry sequence and the wording can be updated to make it more clear that we're retrying to connect so we don't have to wonder if this is an error or not.

I added a message about retrying connection if that happens again, however it didn't appear now probably because we don't want spot instances anymore and those B1s spin up faster, don't know...
Anyway this should hopefully be everything for this PR.

Looks good, is this ready to be merged? RHEL 8.4 ostree test failure is expected and unrelated.

Thanks, I believe it is, but I'd like to hear from @atodorov if he agrees.

The test reports PASS but I see something which doesn't look well:

[2021-04-30T18:48:51.367Z]                                                                                -> github.com/Azure/azure-pipeline-go/pipeline.NewError, /builddir/build/BUILD/osbuild-composer-d50ef703d50e225d68c88a44eef81527feb9f943/_build/src/github.com/osbuild/osbuild-composer/vendor/github.com/Azure/azure-pipeline-go/pipeline/error.go:157

[2021-04-30T18:48:51.367Z]                                                                                HTTP request failed

[2021-04-30T18:48:51.367Z]

[2021-04-30T18:48:51.367Z]                                                                                Put "https://travisciuploads.blob.core.windows.net/travisciuploads/image-rhel_84-x86_64-PR-1358-44.vhd?comp=page&timeout=61": read tcp <IP_ADDRESS>:36458-><IP_ADDRESS>:443: read: connection reset by peer

This is at the end of the upload to Azure. Not sure if a real error but maybe we need an error check after commands in the script.

I was not able to reproduce it manually and can't see it when ran again, not sure what to do here...

Indeed it is not present. Could have been an unhandled TCP close in one of the upstream libraries. We'll investigate if it happens again.

PUT https://travisciuploads.blob.core.windows.net/travisciuploads/image-rhel_84-x86_64-PR-1358-45.vhd?comp=page&timeout=61

azurerm_linux_virtual_machine.testterraformvm: Creation complete after 1m53s [id=/subscriptions/8d026bb1-2a65-454d-a88f-c896db94c4f8/resourceGroups/travis-ci-osbuild-composer/providers/Microsoft.Compute/virtualMachines/vm-rhel_84-x86_64-PR-1358-45]

I just want to make sure our config/storage bucket is indeed configured with the not so appropriate name of "travisciuploads" !
@ondrejbudai ^^^

Yes, this is probably a leftover from the past.


[ClickHouse] Error "column with this name already exists" after create dictionary

System information:

OS: Windows 10
DBeaver Version: <IP_ADDRESS>004191823

Connection specification:

DB: ClickHouse <IP_ADDRESS>

Describe the problem you're observing:
After adding simple dictionary getting error while open object tree
Include any warning/errors/backtraces from the logs
Error refreshing node
Reason:
SQL Error [44]: ClickHouse exception, code: 44, host: localhost, port: 8123; Code: 44, e.displayText() = DB::Exception: Cannot add column column_name: column with this name already exists: While executing Tables (version <IP_ADDRESS> (official build))

probably it's clickhouse issue clickhouse/clickhouse#10605


Documentation issue in 'boards/espressif/esp32s3_devkitc/doc/index' - ESP32S3-Devkitc Board not supported

Describe the bug
Trying to build ESP32S3-Devkitc with Zephyr
Environment
Linux Ubuntu 20.04

Page: boards/espressif/esp32s3_devkitc/doc/index
Version: main
SHA-1: b29be06ec2560bff36a61a25b4a4f666144c1f98

I am trying to build the application helllo world using the same instructions from the page mentioned above. Unfortunately i am getting an "Invalid Board Error" while cmake is running, and the build stops.
I am not sure if the board is indeed supported, since it is also not mentioned in the list of the supported boards that is printed with the error.
Error : No Board named 'esp32s3_devkitc' found.
Help and support greately appreciated.
Thank you
Rohan Valvekar.

Seemingly you are using zephyr 3.6 or older, this board was added 3 weeks ago, so you need to use main to use this board.


Remove warning about pruned nodes

Pruning is supported since 0.13
Pull Request Checklist
This is just docs change.

Good idea, I noted the version to avoid misunderstanding and pointed out performance implications.

Added.

Thanks! Can you please also the first two commits and update the commit messages according to our guidelines.

Done.


setActive is not working

Hi,
I need to set the steps dynamically to active or not depending on a status.
So I thought I set it programatically. But the setActive is not working.
However setTitle works fine. What is wrong with this code?
I dont want to use the Adapter if there is another way.
SequenceStep step_accepted;

step_accepted = rootView.findViewById(R.id.stepAccepted);
step_accepted.setActive(true);

xml
<com.transferwise.sequencelayout.SequenceLayout
                android:layout_marginTop="10dp"
                android:layout_width="match_parent"
                android:layout_height="wrap_content">

                <com.transferwise.sequencelayout.SequenceStep
                    android:id="@+id/stepAccepted"
                    android:layout_width="match_parent"
                    android:layout_height="wrap_content"
                    app:anchor="13:50"
                    app:title="@string/status_layout_order_accepted"
                    app:subtitle="@string/status_layout_order_accepted_subtitle"
<EMAIL_ADDRESS>                    />
</com.transferwise.sequencelayout.SequenceLayout>

Hey, could you try running sequenceLayout.start() after setting the active step programmatically? And, if you had another step set to active before, call .setActive(false) on that previous step?

@saschoar awesome thanks for the quick help. Calling sequenceLayout.start() worked!

@saschoar Do you know why sometimes it is working and sometimes not. I use it in a BottomSheet and when I open the sheet it displays everything fine. Then on the next app start without codechanges or anything else the active step is not set.

@saschoar it stopped working when I added my layout to a Bottomsheet.
setActive is called and the Logs give me the correct values. However the sequencLayout.start() does nothing.
Any idea what could cause this issue?

@saschoar so I have to call start() everytime when I active next step?
I have 25 steps, can you please tell me step to active it step by step.

Hi,
I need to set the steps dynamically to active or not depending on a status.
So I thought I set it programatically. But the setActive is not working.
However setTitle works fine. What is wrong with this code?
I dont want to use the Adapter if there is another way.
SequenceStep step_accepted;

step_accepted = rootView.findViewById(R.id.stepAccepted);
step_accepted.setActive(true);

xml
<com.transferwise.sequencelayout.SequenceLayout
                android:layout_marginTop="10dp"
                android:layout_width="match_parent"
                android:layout_height="wrap_content">

                <com.transferwise.sequencelayout.SequenceStep
                    android:id="@+id/stepAccepted"
                    android:layout_width="match_parent"
                    android:layout_height="wrap_content"
                    app:anchor="13:50"
                    app:title="@string/status_layout_order_accepted"
                    app:subtitle="@string/status_layout_order_accepted_subtitle"
<EMAIL_ADDRESS>                    />
</com.transferwise.sequencelayout.SequenceLayout>

could you please tell me how to user seqenceLayout.start()?
i declared it as         SequenceLayout sequenceLayout = new SequenceLayout(MainActivity.this);
am new to android studio programming, did I miss something? should I add SequenceLayout class?


Fixing misc. broken lines in create-market integration test

CH issue
Note: This requires https://app.clubhouse.io/augur/story/14312/enable-auto-login-when-running-integration-tests in order to work.

Pull Request Test Coverage Report for Build 924

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.836%

Totals

Change from base Build 916:
0.0%

Covered Lines:
3530

Relevant Lines:
4858

💛  - Coveralls

Pull Request Test Coverage Report for Build 924

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.836%

Totals

Change from base Build 916:
0.0%

Covered Lines:
3530

Relevant Lines:
4858

💛  - Coveralls


Fix Build Issues

fix(dropdown): convert all tabs to spaces

@Munter this is a bit bizarre -- I'm getting all 200s when I go to the actual site or curl it but for some reason on Travis it gets all 502s... I've rerun the build a few times already all with the same result.

$ curl https://jspm.io -I
HTTP/1.1 502 Bad Gateway
Date: Wed, 12 Jul 2017 07:46:38 GMT
Content-Type: text/html; charset=UTF-8
Connection: keep-alive
Set-Cookie: __cfduid=d65c6b17eead63406cc24a080503b3b8d1499845598; expires=Thu, 12-Jul-18 07:46:38 GMT; path=/; domain=.jspm.io; HttpOnly
Expires: Thu, 01 Jan 1970 00:00:01 GMT
Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0
Pragma: no-cache
X-Frame-Options: SAMEORIGIN
Server: cloudflare-nginx
CF-RAY: 37d263cbf89e3cef-CPH

This seems to happen on HTTP HEAD only. I have special casing for retrying with the slower and more resource intensive HTTP GET here: https://github.com/Munter/hyperlink/blob/master/lib/index.js#L172-L175
It seems another case needs to be added here

@Munter ah man that's a pain... what would you even flag on from that response? I may just rethink this link for now as it's not really crucial to our docs -- keep us posted though if you find a good solution and re-release hyperlink.

It's an easy fix. I already have a retry mechanism for when a server hasn't implemented HTTP HEAD. It just doesn't activate on 5xx responses. I'll get this out pretty soon.

I released a new major version that includes this fix and also comes with a new canonicalroot option that should be helpful if you ever need canonical urls in your build output and want to test things locally


Nested ElementalArea's UploadField doesn't update on Save

Module version(s) affected
5.1
Description
I have a Elemental block, with a ElementalArea, so, so an ElementalArea inside another ElementalArea. If inline-editing a block on the 2nd level ElementalArea has an UploadField, on page save, the UploadField value doesn't update (nor any of the other fields). However, if you refresh the CMS the block editor re-renders with the updated information, so it's saving to the DB correctly.
https://github.com/silverstripe/silverstripe-elemental/assets/178039/84a6bbfc-28c2-43de-8fd3-93392e684e1e
How to reproduce
Page with ElementalArea
Block with ElementalArea
class ArticleBlock extends BaseElement
{
    private static $table_name = 'ArticleBlock';
    private static $singular_name = 'Article block';

    private static $has_one = [
        'ElementalArea' => ElementalArea::class,
    ];

    private static $owns = [
        'ElementalArea',
    ];
}

Block with UploadField
class MediaWithCaptionBlock extends BaseElement
{
    private static $table_name = 'MediaWithCaptionBlock';
    private static $singular_name = 'Media with Caption block';

    private static $db = [
        'Caption' => 'HTMLText',
        'Setting_Alignment' => "Enum('left,right','left')",
        'Setting_ImageSize' => "Enum('small,medium,large','small')",
    ];

    private static $has_one = [
        'Image' => Image::class,
    ];

    private static $owns = [
        'Image',
    ];

    function getType()
    {
        return $this->i18n_singular_name();
    }
}

Possible Solution
No response
Additional Context
No response
Validations

[X] Check that there isn't already an issue that reports the same bug
[X] Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

Just to add, when using the individual block actions "save" button, this works correctly

It's a bit hard to tell from the description - is this specifically related to nested elemental blocks?

Yes
Kind Regards,
Christopher Darling  (he / him)
www.christopherdarling.co.uk
On Tue, 19 Mar 2024 at 01:27, Guy Sartorelli @.***>
wrote:

It's a bit hard to tell from the description - is this specifically
related to nested elemental blocks?
—
Reply to this email directly, view it on GitHub
https://github.com/silverstripe/silverstripe-elemental/issues/1156#issuecomment-2005566597,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABLO53TXZBBPAYFKTSUU4TYY6H77AVCNFSM6AAAAABE344EVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGU3DMNJZG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Marking as an enhancement - I don't think that's a use case that has been considered as supported so far.

There are quite a few existing issues (open and closed) referencing nested blocks (e.g. https://github.com/silverstripe/silverstripe-elemental/issues/775 / https://github.com/silverstripe/silverstripe-elemental/issues/824) and there's https://github.com/dnadesign/silverstripe-elemental-list too so I think it's probably used more than you think

Yes my page that contains the first element area isn’t inline editable, just the ArticleBlock that contains the nested Element Area is. So they’re not nested inline editable, but the nested elemental is if that makes sense? The rest of the blocks that don’t contain data relations (grid fields and upload fields) work fine inline editable.

Ahhh okay that changes things.
I've checked thiss - and also tried with a non-page model which has an ElementalArea (i.e. just a regular DataObject which is edited in a ModelAdmin and has ElementalArea) and it doesn't work there either, so it's more to do with the GridFieldDetailForm and nothing to do with nested elemental areas. Updating the issue to reflect this.

Just checked with previous versions - this worked in 4.13 but doesn't work in 5.0, so something broke in the major release.

Linked PRs have been merged. They will be released as part of CMS 5.3


Invalid Property WorkGroupConfigurationUpdates - Athena::WorkGroup

cfn-lint version: 0.59.1
Description of issue.
I get the error shown below when using the latest version of cfn-lint. It worked fine in previous versions of cfn-lint.
E3002 Invalid Property Resources/MyAthenaWorkGroup/Properties/WorkGroupConfigurationUpdates
Please provide as much information as possible:

Template linting issues:

Please provide a CloudFormation sample that generated the issue.

  MyAthenaWorkGroup:
    Type: AWS::Athena::WorkGroup
    Properties:
      WorkGroupConfigurationUpdates:
        EnforceWorkGroupConfiguration: true
        PublishCloudWatchMetricsEnabled: true
        RequesterPaysEnabled: false
        ResultConfigurationUpdates:
          OutputLocation: "s3://abc/xyz/"
      Description: abc
      Name: abc
      State: ENABLED

If present, please add links to the (official) documentation for clarification.
aws-resource-athena-workgroup

This property type looks poorly modeled in the first place, looks like they decided to remodel it by removing that property:
https://github.com/ScriptAutomate/aws-cfn-resource-specs/blob/master/changelogs/v68-CHANGELOG.md#complete-removal-of-resourcetypes-andor-propertytypes

Thank you so much for providing this information. Problem solved.


Update and improve home page and tutorials

Once the UI changes are more stable, we can update the screenshots on the home page and rewrite some of the text to fix grammar errors/reflect new site features/changes.
We probably also want to redo the popup tutorials for each page to be either more concise, or not a popup at all. Maybe something like little tooltips that appear on the various UI elements, assuming that isn't too hard to do. This would be less mental overload for new users, and more interactive as well.

I think the homepage has always been a tad half-assed. I believe as a homepage, its a tad too... wordy. There are also not a lot of distinctions between the sections. Quite a lot of questions needs to be answered:

should it be an index? it only links to like 4 out of our 6 pages, there is a dup link as well, a lot of sub pages(specific character pages) shouldn't be showcased? it is the only accessible link to the scanners page...
separate about page?
Intro is too wordy(how and where to we explain the caveats?)
the discord widget serves no purpose, just a big ugly button to discord server.
layout is uninspired and chunky

My opinion is that we should define the requirements of a "welcome/index" page, and try to condense the content according to those. I think a lot of the bloat here should be moved to another page (about? tooltips?), and design a clean, concise home page.

I think the home page should be more of a dashboard page.

resin counter(link to tools)
server time( use timezone selected in tools)
farmables today(need to hook up ascension mats from character sheet from datamine, but it would only show char/weapons added to GO, that arnt fully ascended.)
overview of # of arts, characters, weapons in inventory

show characters that doesn't have build as quick click to optimize?

excerpt of patch notes(latest minor?)
current banner?
latest guide videos(instead of just link to playlist, embed videos?)

Resolved by 8.10.0


This relative module was not found (Posts)

I follow the instructions and i can't get it to compile, i always get this error:

ERROR  Failed to compile with 1 errors                                                                                14:51:34
This relative module was not found:

../components/content/Posts in ./src/router/index.js

Fixed it renaming the "posts.vue" file in "./components/content/" to "Posts.vue"

Hi, thanks for highlighting this, would include the fix in the upcoming release. How is your testing so far? If there are specific issues or features you would like to see implemented please open issues for them. Thank you


Panic when trying to build 32-bit binary

Panic when trying to build 32-bit binary
GOOS = "Windows"
GOARCH = "386"
CGO_ENABLED = "1"

go version go1.22.0 windows/amd64
panic: compileCallback: expected function with one uintptr-sized result

goroutine 1 [running, locked to thread]:
syscall.compileCallback({0x12fd2e0, 0x13ebc50}, 0x1)
        C:/Go/src/runtime/syscall_windows.go:291 +0x496
syscall.NewCallback(...)
        C:/Go/src/syscall/syscall_windows.go:214
github.com/saltosystems/winrt-go/internal/delegate.init()
        C:/Users/roffe/go/src/github.com/saltosystems/winrt-go/internal/delegate/delegate.go:18 +0x83
exit status 2

It looks like the syscall callbacks need to return a uintptr-sized result, but we are returning a uint64 which messes with 32 bit systems. Thanks for the report!
I was able to reproduce the problem, and I think this branch (feature/fix-callback-return-type) will fix the issue. Could you test it please?

Thank you for the fast response!
It compiles now but my very simple test program using tinygo.org/x/bluetooth crashes after first scan result.
Not sure if it's now a issue for this repo or tinygo.org/x/bluetooth
goarch=386
PS: 19 2024-03-12 13:48:50 bttest >go run .
scanning...
2024/03/12 13:49:09 main.go:26: found device: 67:04:C5:16:96:38, -70,
exit status 0xc0000005

goarch=amd64
PS: 22 2024-03-12 13:52:46 bttest >$env:GOARCH="amd64"
PS: 23 2024-03-12 13:54:03 bttest >go run .
scanning...
2024/03/12 13:54:05 main.go:24: found device: 65:06:17:73:85:23, -90,
2024/03/12 13:54:05 main.go:24: found device: 49:92:32:66:14:17, -70,
2024/03/12 13:54:05 main.go:24: found device: 49:92:32:66:14:17, -70,
2024/03/12 13:54:05 main.go:24: found device: 5F:55:B0:D7:0E:1B, -70,
2024/03/12 13:54:05 main.go:24: found device: 46:46:46:EC:DC:B7, -88,
2024/03/12 13:54:05 main.go:24: found device: 64:B7:08:5F:F6:9A, -88,
2024/03/12 13:54:05 main.go:24: found device: 65:03:49:F6:3A:9C, -70,
2024/03/12 13:54:05 main.go:24: found device: 65:03:49:F6:3A:9C, -70,
2024/03/12 13:54:05 main.go:24: found device: D0:03:DF:AB:78:6F, -72,
2024/03/12 13:54:05 main.go:24: found device: 64:B7:08:5F:F6:9A, -86,
2024/03/12 13:54:05 main.go:24: found device: 64:B7:08:5F:F6:9A, -86, OBDX Pro GT
2024/03/12 13:54:05 main.go:42: connected to 64:B7:08:5F:F6:9A

package main

import (
	"log"
	"time"

	"tinygo.org/x/bluetooth"
)

var adapter = bluetooth.DefaultAdapter

func init() {
	log.SetFlags(log.LstdFlags | log.Lshortfile)
}

func main() {
	must("enable BLE stack", adapter.Enable())
	ch := make(chan bluetooth.ScanResult, 1)

	start := time.Now()

	println("scanning...")
	err := adapter.Scan(func(adapter *bluetooth.Adapter, device bluetooth.ScanResult) {
		log.Printf("found device: %s, %d, %s", device.Address.String(), device.RSSI, device.LocalName())
		if time.Since(start) > 10*time.Second {
			adapter.StopScan()
		}
		if device.LocalName() == "OBDX Pro GT" {
			adapter.StopScan()
			ch <- device
		}
	})
	must("start scan", err)

	var device bluetooth.Device
	select {
	case d := <-ch:
		device, err = adapter.Connect(d.Address, bluetooth.ConnectionParams{})
		if err != nil {
			log.Fatal("failed to connect:", err)
		}
		log.Printf("connected to %s", d.Address.String())
	case <-time.After(10 * time.Second):
		log.Fatal("Did not find any OBDX Pro GT device")
	}

	device.Disconnect()

}

func must(action string, err error) {
	if err != nil {
		log.Fatal("failed to " + action + ": " + err.Error())
	}
}

I get the same result so we may be missing something. After the first scanned device the program closes with exit status 0xc0000005.

I tried debugging the generated binary using WinDbg and I think this is the stack when the error happens:
[0x0]   0xffffffffcccccccc!+   0x315cf784   0x707be2e1
[0x1]   Windows_Devices_Bluetooth!wistd::__function::__func<<lambda_294007b0f2593fc9ac11b79d22635d8e>,long __stdcall(Windows::Foundation::ITypedEventHandler<Windows::Devices::Bluetooth::GenericAttributeProfile::GattCharacteristic *,Windows::Devices::Bluetooth::GenericAttributeProfile::GattValueChangedEventArgs *> *)>::operator()+0x21   0x315cf788   0x707bc2cd
[0x2]   Windows_Devices_Bluetooth!Microsoft::WRL::InvokeTraits<2>::InvokeDelegates<<lambda_060960e27843950aa1a5ff05be23c883>,Windows::Foundation::ITypedEventHandler<Windows::Devices::Bluetooth::GenericAttributeProfile::GattSession *,Windows::Devices::Bluetooth::GenericAttributeProfile::GattSessionStatusChangedEventArgs *> >+0x53   0x315cf7a0   0x707b9bc0
[0x3]   Windows_Devices_Bluetooth!wil::AsyncEventSourceT<Windows::Foundation::ITypedEventHandler<Windows::Devices::Bluetooth::Advertisement::BluetoothLEAdvertisementPublisher *,Windows::Devices::Bluetooth::Advertisement::BluetoothLEAdvertisementPublisherStatusChangedEventArgs *>,Windows::Internal::GitEventSourceSupportsAgile,Microsoft::WRL::InvokeModeOptions<2>,1,wil::err_returncode_policy>::AsyncEventWorkItem::RaiseEvent+0x30   0x315cf7dc   0x707c4257
[0x4]   Windows_Devices_Bluetooth!wil::details::AsyncEventInvocationPolicy<1>::HandleAsyncEventInvoke+0x67   0x315cf7f8   0x707c42ee
[0x5]   Windows_Devices_Bluetooth!wil::details::EventInvocationContext<1>::AsyncEventWorkCallback+0x4e   0x315cf818   0x77cbf4f8
[0x6]   ntdll!$push_thunk$stdcall$v$uuu+0x50   0x315cf830   0x0

Which is crazy because I'm just scanning devices, I'm not connecting not reading any characteristic. But the errors happens in a GattCharacteristic for some reason.
At this point I think someone should try this on a 32 bit machine. There's too many layers of abstraction that could cause issues (a 32 bit binary running on a Windows ARM virtual machine running in parallels on a ARM MacOS).


[BEAM-6590] 2.7.1 LTS cherrypick: Upgrade gcsio dependency to 1.9.13

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

LGTM. Thanks.

run java precommit

Gradle scan shows flake in ElasticSearch as well as compile failures in ApexRunner and examples. Trying to reproduce but I expect it is all false.

Run Java PreCommit

After the re-run all test suites that exist for 2.7 are healthy. Merging.


Does this app work for imported repository from gitlab/bitbucket?

I want to sync reop from GitLab and I know this app works for forked repo, but I wonder whether it works for imported repo.

No it doesn't. You can use my GitHub actions to sync repos between any git providers. https://github.com/wei/pull

Update: fixed the link in my last comment.


NestedTeamsPreview: Add the ListChildTeams endpoint

As per discussion in https://github.com/google/go-github/pull/747#issuecomment-336780818, this endpoint is missing.

I signed it (before). Also, I updated my CLA contact info with my new username, which I hope will prevent this problem from re-occurring in the future.

Should be good.


Redesign

Many thanks to @barche for helping me with using CxxWrap  I saw the mention of your recent presentation about the package at https://twitter.com/MandelKen/status/720247980188659712
In the end I did the typical geek thing of "Why don't I write a native Julia implementation of flatbuffers instead of messing with this C++ library?  I mean, how hard can it be?"  The metadata in a feather file is expressed using a flatbuffers schema.  Once I can extract the metadata the other parts of reading a feather file are straightforward.
It turns out that it wasn't that hard after all.  So much of the work in the C++ library is because you are trying to express dynamic types in a statically-typed language.
I should have an initial commit of the FlatBuffers.jl package later today.

This is really cool. A new C++ library comes out and it gets wrapped in 2 weeks. Then we will get a native julia solution showing both the great C/C++ interop capabilities and the power of julia itself. :+1:
I just thought I would say something nice on the internet today :smile:

Aha, thanks, I was blissfully unaware of that tweet :)
I completely agree that going pure Julia is the best way forward. The experiment benefited CxxWrap anyhow, since we now have support for smart pointers, an issue that would have come up sooner or later anyway.

Change over is ecee6bbb3598b9db6d362a4d554843565c05c143.  Still needs a bit of work because I changed the organization of FlatBuffers.jl while writing its documentation.


After Export of a Excle / Word the site is not responsive... any handels to close?

Where exactly do we have to put XSP.allowSubmit()? Can you post an example code of action please?

Please use instead of xs:this.complete or xp:this.onStart the following:
        <xp:this.script><![CDATA[XSP.allowSubmit()]]></xp:this.script>


Fix protobuf build to properly include directories

@aaronmarkham - I think this should fix the oss build.
@slayton58 FYI
@kmatzen FYI

cc @ajtulloch - this fixes the build.


Landing page carousel not resizing on window resize

The width of the swiper slide is fixed to 1232px and resets to the same even if the window is resized.

[x] Fix the resize issue to make the page mobile responsive

Fixed this