Server stopped after source code change in dev mode (Maven plugin)

Describe the bug
While using the liberty:dev Maven plugin, a source code change that triggered a restart lead to the server being stopped. Here are the last log lines:
[INFO] [2024-04-16T09:54:49.054+0000] 00000035 id=         com.ibm.ws.webcontainer.servlet.ServletWrapper               I doDestroy SRVE0253I: [app] [/] [...RestApplication]: Destroy successful.
[INFO] [2024-04-16T09:54:49.065+0000] 000003ad id=                                                                      R  Exception in thread "Thread-28"
[INFO] [2024-04-16T09:54:49.065+0000] 000003ad id=                                                                      R  java.util.concurrent.RejectedExecutionException: CWWKE1202E: A task cannot be submitted because the executor concurrencyPolicy[defaultConcurrencyPolicy] has been shut down.

[INFO] [2024-04-16T09:54:49.065+0000] 000003ad id=                                                                      R       at java.base/java.lang.Thread.run(Thread.java:840)
[INFO] [2024-04-16T09:54:49.089+0000] 00000035 id=         com.ibm.ws.app.manager.AppMessageHelper                      A CWWKZ0009I: The application app has stopped successfully.
[INFO] [2024-04-16T09:54:49.098+0000] 000003d9 id=         com.ibm.ws.webcontainer.servlet.ServletWrapper               I doDestroy SRVE0253I: [io.openliberty.microprofile.openapi.2.0.internal.servlet.jakarta] [/openapi] [ApplicationServlet]: Destroy successful.
[INFO] [2024-04-16T09:54:49.167+0000] 000003d9 id=         com.ibm.tx.jta.impl.FailureScopeController                   A WTRN0105I: The transaction service has shutdown successfully with no transactions requiring recovery.
[INFO] [2024-04-16T09:54:49.247+0000] 000003d9 id=         rty.security.mp.jwt.v21.config.impl.MpConfigProxyServiceImpl I CWWKS5788I: The MicroProfile JWT version 2.1 mpConfigProxy was deactivated successfully.
[INFO] [2024-04-16T09:54:49.249+0000] 000003d9 id=         com.ibm.ws.security.mp.jwt.impl.MicroProfileJwtConfigImpl    I CWWKS5502I: The MicroProfile JWT configuration [defaultMpJwt] was successfully deactivated.
[INFO] [2024-04-16T09:54:49.250+0000] 000003d9 id=         com.ibm.ws.security.mp.jwt.impl.MicroProfileJwtServiceImpl   I CWWKS5502I: The MicroProfile JWT configuration [MicroProfileJwtService] was successfully deactivated.
[INFO] [2024-04-16T09:54:49.391+0000] 000003d9 id=         ibm.ws.security.authentication.internal.jaas.JAASServiceImpl I CWWKS1124I: The collective authentication plugin with class name NullCollectiveAuthenticationPlugin has been deactivated.
[INFO] [2024-04-16T09:54:49.395+0000] 000003d9 id=         com.ibm.ws.security.ready.internal.SecurityReadyServiceImpl  I CWWKS0009I: The security service has stopped.
[INFO] [2024-04-16T09:54:49.710+0000] 00000001 id=         com.ibm.ws.kernel.launch.internal.FrameworkManager           A CWWKE0036I: The server defaultServer stopped after 4 minutes, 41.521 seconds.
[INFO] Server defaultServer stopped.

And the code involved:
@ApplicationScoped
public class Service {

    @Resource
    private ManagedExecutorService executor;

    public CompletableFuture<Void> runAsync(Runnable task) {
        return executor.runAsync(task);
    }
}

Expected behavior
The dev server should resist exceptions thrown during destruction.
Diagnostic information:

OpenLiberty Version: <IP_ADDRESS>
Java Version: 17

Can you please explain this a bit better?

I'm just using the liberty:dev command, you know? Which restarts the server every time it detects a change in the source code, does it not?

I'm just using the liberty:dev command, you know? Which restarts the server every time it detects a change in the source code, does it not?

Sorry.. I hit the button before I finished typing my comment.   Please take another look.
In general, liberty:dev will restart an application upon a Java source change.  Upon a config change it may restart the server or just the app, depending on the change.

I was indeed changing Java code; specifically, code inside a method with an @Observes @Destroyed(ApplicationScoped.class) argument, though I don't really think this is relevant to the problem, just a coincidence.
As far as I can tell, these were the first relevant log entries, yes.
It isn't the first time I observe a mysterious server stop during development. It happens to me with some regularity, maybe once or twice a month, often without any exception in the vicinity. I'll post more details here when I see it again.

Thanks for clarifying.  Are you able to share more details from the full messages.log from this last time that the server crashed?

I couldn't see anything else of relevance in messages.log; I did not look into any other logs. They are gone now, unfortunately.

Ok, thanks for looking.   Well, I don't think we want to expand dev mode to monitoring the server and introducing an automated restart around the server.
I think what we're left with then is understanding why did the original server crash to begin with ?
I think we would need to see the content of the logs directory to understand that better, either the full logs directory provided via a support case if that is an option for you or whatever you can share publicly if not (maybe some excerpts from the messages.log and maybe some of the FFDC logs would be helpful enough).
In any case, I'm going to close this for now, but please do reopen when you have more detail.   Also going to transfer this back to the other repo since this has moved in the direction of more of a runtime issue than a liberty-maven-plugin issue.
Thank you.


[WIP] switch to ember-cp-validations

This is only a POC for now but I think ember-cp-validations might be the better solution than ember-validations for the long term.
/cc @LevelbossMike

:+1: for changing to ember-cp-validations. The computed idea definitely makes sense and it looks like a clean implementation from what I saw in the ember global meetup presentation

Yeah, will clean this up and merge it.


Feature/us319 feedback link summary

Small html comment but otherwise seems fine.

OK-ish.

Have updated US301 to include a task to replace all instances of links to feedback with an environment variable. This was just placeholder anyway as we will no longer be linking to an email.

LGTM after discussion


Random Anime pics generator

Describe the project you want to add with tech stack
A random anime generator, fetching an image everytime clicked
Expected behavior
Whenever the 'Get anime' button is clicked, we observe a loading effect first, followed by a new picture with a random name.
Screenshots (optional)

@MohitGupta121 @pranjay-poddar


RPC issues

The script is still very flaky due to the RPC.
Example failures from a single update:
[Operator] Unbonding on-chain service 63...
[2024-01-09 12:00:46,661][WARNING] Unable to estimate gas with default state , ValueError: {'code': -32015, 'message': 'wrong transaction nonce'}
Error: Service unbonding failed with following error; ChainTimeoutError(Timed out when waiting for transaction to go through)

[Service owner] Updating on-chain service 63...
Error: Component mint failed with following error; ChainTimeoutError(Timed out when waiting for transaction to go through)

[Operator] Registering agent instance for on-chain service 63...
Error: Service activation failed with following error; ChainTimeoutError(Timed out when waiting for transaction to go through)

[Service owner] Deploying on-chain service 63...
Error: Service deployment failed with following error; ChainTimeoutError(Timed out when waiting for transaction to go through)```

Rerunning the script got me past these issues one by one

Addressed in https://github.com/valory-xyz/trader-quickstart/pull/193


Token TTL in st2.conf doesn't work

Hi there,
We found that the token_ttl in /etc/st2/st2.conf doesn't work.
Below is our configuration:
[auth]
token_ttl = 5184000
host = <IP_ADDRESS>
port = 9100
use_ssl = False
It's version 2.2 and we upgrade it to 2.4.
There is two actions in one flow, it took 3 days for step one and while stackstorm starts step 2 the error occurred:
  "state_info": "{status: 401, cookies: {}, encoding: None, url: http://<IP_ADDRESS>:9101/v1/actionexecutions, elapsed: 0.011803, content: {u'faultstring': u'Unauthorized - Token has expired.'}, headers: {u'Content-Length': u'58', u'Access-Control-Allow-Headers': u'Content-Type,Authorization,X-Auth-Token,St2-Api-Key,X-Request-ID', u'Access-Control-Expose-Headers': u'Content-Type,X-Limit,X-Total-Count,X-Request-ID', u'X-Request-ID': u'3c6a8887-918b-4666-8dac-3fb23e0878dc', u'Server': u'gunicorn/19.7.1', u'Connection': u'keep-alive', u'Access-Control-Allow-Credentials': u'true', u'Date': u'Fri, 16 Feb 2018 09:37:50 GMT', u'Access-Control-Allow-Origin': u'http://<IP_ADDRESS>:3000', u'Access-Control-Allow-Methods': u'GET,POST,PUT,DELETE,OPTIONS', u'Content-Type': u'application/json'}, reason: Unauthorized, history: []}",

So the token_ttl doesn't work in version 2.4? And do we have another option in st2.conf for stackstorm to generate a new token each time it trigger the next action in a flow?
Thanks.
Jason

Hello,
There are two types of TTLs which can be configured:

for regular user accounts - token_ttl config option, defaults to 24 hours
for StackStorm services (actions, workflows, etc.) - service_token_ttl config option, defaults to 24 hours

Changing the service_token_ttl and restarting the services should do the trick.
Please let us know if that works for you.

@Kami Thank Kami. Let me try this and update here.

@wyjuly Any update on this - did that setting work for you? :)

@Kami Thanks Kami, on the way. Will upgrade to 2.6 and test with both service_token_ttl and token_ttl set in st2.conf and update the result here.

@Kami  I've completed testing.
After upgraded from 2.4 to 2.6 and add service_token_ttl in /etc/st2/st2.conf, stop and start service, the flow   continue running after one of the action completes after 26 hours.
So it looks the token ttl configuration works. But I'm not sure which change is the key factor: upgrade to 2.6 or add service_token_ttl.
If it succeeded again because of the new parameter maybe we should put it into the DOC to let more users know that. Thanks.

Jeez - my memory isn't what it used to be. I didn't know I had a hand in this fix...but it looks like you were seeing the results of #3523 which was resolved in #3524. Not certain which release this got put in but I would have assumed 2.4 would have worked for you. Either way glad it is working now. Feel free to re-open if you see anything else going on that's related to this.


commands and options don't localize in HELP command

Version
Microsoft Windows [Versoin 10.0.22621.608] Chinese Edtion
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
No response
Distro Version
No response
Other Software
No response
Repro Steps
wsl --help
Expected Behavior
show english command or option, dotn't translate to chinese.
Actual Behavior

Diagnostic Logs
No response

I have the same problem.

Duplicate of #8857


feat: add flag to init cmd to specify output file path

What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #344
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE

Additional documentation e.g., design docs, usage docs, etc.:

I have read the CLA Document and I hereby sign the CLA

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

15 of 17 (88.24%)  changed or added relevant lines in 2 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.1%) to 59.18%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/cmd/init/options.go
6
8
75.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/engine/operation/parser/parser.go
3
79.27%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
7333

Relevant Lines:
12391

💛  - Coveralls


model_args.hard_negative_weight issue

hi ,I find a problem that your code does not match your paper,
z3_weight = cls.model_args.hard_negative_weight
weights = torch.tensor(
[[0.0] * (cos_sim.size(-1) - z1_z3_cos.size(-1)) + [0.0] * i + [z3_weight] + [0.0] * (z1_z3_cos.size(-1) - i - 1) for i in range(z1_z3_cos.size(-1))]
).to(cls.device)
cos_sim = cos_sim + weights
I think hte weights should multiply cos_sim and [0.0] should replace with [1.1]  ?

HI, here weights are applied in a log form. Weight=0 means the final weight would be e^0=1.


Introduce some delay before closing clients in LameDuck mode.

This will allow to signal multiple servers at once to go in
that mode and not have their client reconnect to one of the
servers in the group.
Signed-off-by: Ivan Kozlovic<EMAIL_ADDRESS>

Coverage decreased (-0.1%) to 91.044% when pulling eb179509718d39779caba8c205ee3faa80a6ef6c on update_lame_duck_mode into 5180a7fbcd88c8c0203a3291606a94758061d38c on master.


ios does not receive background notifications

Background modes should be enabled on the app. See: https://firebase.flutter.dev/docs/messaging/apple-integration

This has been fixed


v0.11 upgrade process

Including:

change template tag to v0.11.0
update configMigration.py to support 0.10 -> 0.11
add plugin migration docs.

Coverage remained the same at 52.647% when pulling ebc1b83ba3e1f23ac325bba60a142ae3f5923197 on zimiao/upgrade_0.11 into 48eb55e39ca6acf6a4982866dd1d20a7d9c8db3a on pai-0.11.y.

Coverage remained the same at 52.647% when pulling ebc1b83ba3e1f23ac325bba60a142ae3f5923197 on zimiao/upgrade_0.11 into 48eb55e39ca6acf6a4982866dd1d20a7d9c8db3a on pai-0.11.y.


Usage of imported classes in effect commands

Is your feature request related to a problem? Please describe.
Title is explaining almost everything. That would be awesome if we can use imported classes in skript's effect commands.
Describe the solution you'd like
!send Bukkit.getServer()
!send SomePluginAPI.chargeXYZ(1, 5, -9)

This was added in the latest release: https://tpgamesnl.gitbook.io/skript-reflect/basics/importing-classes#importing-in-effect-commands

Sorry my bad


PACKAGES: Mod-main prep flutter to be data driven

The golang client is going to act as an API for minio and will be what flutter talks to for it's data.
We need to setup flutter in mod-main  at all steps to be be data driven.
Setup DataModels (if they dont' already exist) to populate the data
Setup ApiAdapters so that future data sources doesn't require a refactor, this will also allow us to setup mock data while waiting for the real data to get setup.
Suggested phasing:

The GRPC Server API is not done yet, but the Flutter code can be setup now with mock data dart class to start to use data driven rendering for mod-main and mod-main dashboard.

The remaining phases will be completed in separate tickets.

https://github.com/getcouragenow/packages/issues/413

https://github.com/getcouragenow/packages/issues/414

Current update:
All the repos and their services are in place
Next:

Building user needs to be responsive to data
Building support roles to be responsive to data
Add Saving methods to repos

Closing. This has been broken out into new issues to prevent scope creep. All relevant PRs have been merged in.


[ENHANCEMENT]: Show total votes count only

Description
Show total votes count instead of showing counts for every candidate, its a over transparency issue 😆. We can publish like this after voting ends.
Screenshots

Additional context
I don't know if this counts shows in a different context. What do you think?

Yeah . You are right @rajmanna-dev . I placed the counts of each candidate to cast vote for the winning candidate to check whether the users vote count added correctly. As the logic works correctly and the votes are counted perfectly we can remove that part. Instead we can show that in results page as you suggested. Do you want to work on this issue?

Yeah sure! Assign me on it


convert deprecated EnvoyFilter to new syntax

Signed-off-by: Shriram Rajagopalan<EMAIL_ADDRESS>

@rshriram: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
261c5af152f3dc4112c32af097a719d02e7033ad
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
261c5af152f3dc4112c32af097a719d02e7033ad
link
/test gencheck_istio

integ-istioio-k8s-tests_istio
261c5af152f3dc4112c32af097a719d02e7033ad
link
/test integ-istioio-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add task detail

Moves healthchecks table to bottom of task detail page, collapsed by default
Reordered healthchecks table to newest --> oldest, instead of oldest --> newest
When the deploy associated with the task is PENDING (meaning a deploy is in progress), additionally display the current healthcheck at the top of the task detail page (underneath the well) with a link to the full healthcheck history

@tpetr - this was opened from hs_staging (otherwise I'd open against master)

closing in favor of #521


Target Time/Memory Are Confusing

For some of the puzzles, the target memory (and time) are impossible to satisfy. E.g. for puzzle 0, I spent some time trying to get from 2621440 to under the target of 2600000 until I realized that the solution notebook also takes 2621440 memory. A few other puzzles have similar impossible memory / time targets.
Should we update the targets to what can actually be achieved in practice? Happy to send a PR if you agree.

Same question here and thanks for noticing that the solution notebook also takes that much memory. Have worked on reducing the memory very hard :-)

Oh I'm sorry. Yes, Would take that PR.

Cool, sent you #7


Change state flow to decrease amount of data passed from state to state.

@hodgestar please review. Have moved "retrieve-location" state (the state that returns all the json data for a specific locationselected) to just before the sms state to prevent all that data moving through states unnecessarily. Have tested on Vumi and logs look cleaner.

Woot for thinking to do this! :smile: :cake:
Let some tiny comments, but this PR is generally awesome. :)

@hodgestar have fixed indentation & removed unnecessary line.

:+1:


ORC-1198: Add stream parameter constructor for PhysicalFsWriter

What changes were proposed in this pull request?
Add stream parameter constructor for PhysicalFsWriter.
Why are the changes needed?
PhysicalFsWriter implementation works on the basis of a Path, but Flink's bulk writer based on stream.
In order to integrate with flink more elegantly,  I think a constructor with stream parameter should be added to PhysicalFsWriter
How was this patch tested?
It won't change behavior of PhysicalFsWriter and passed all existed test cases.

@dongjoon-hyun Could you help me to approve this pr?

Thank you for making a PR, @liujiawinds . Sure, I clicked Approve to run.

It seems that zlib library build fails in C++ module. This is irrelevant to your PR.
CMake Error at zlib_ep-stamp/zlib_ep-download-RELWITHDEBINFO.cmake:49 (message):
  Command failed: 1
   '/usr/local/bin/cmake' '-Dmake=' '-Dconfig=' '-P' '/home/runner/work/orc/orc/build/zlib_ep-prefix/src/zlib_ep-stamp/zlib_ep-download-RELWITHDEBINFO-impl.cmake'

Also cc @williamhyun because this is for Apache Flink integration.

@dongjoon-hyun Do I need to do something about the C++ module error?

No~ Not at all. I can merge your PR after manual review and testing.

It's rerunning now.

To help Apache Flink community use Apache ORC more easier, I strategically set the milestone v1.7.5 for this additional constructor patch.

Merged to main/1.8/1.7. Welcome to the Apache ORC community, @liujiawinds .
I assigned ORC-1198 to you (sonice_lj).


CIV-8923 revert

JIRA link (if applicable)
CIV-8923
Change description
revert changes from 8923
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X] No

CIV-8923 reverting changes


Tick should be property of the Auction mechanism and not the Tradable!

@bherd-rb I think that the tick field should be a property of the auction mechanism itself and not of the particular type of tradable traded via the auction.  Thoughts?

This was fixed in previous commit and should have been closed.


Check 028: Check fails when OFL.txt is present

Observed behaviour
Run fontbakery from the root directory of a font repo containing an OFL.txt file and this test will fail.
Expected behaviour
If valid OFL.txt file is in repo root directory, the test should pass.
Resources and exact process needed to replicate
Version: 0.5.2.dev18+gcff658dd

works for me.

can you please provide further details on how you got it to fail?

ok. I executed it from the data/test/mada/ directory and it failed.
We gotta investigate why that's happening. And also add a code-test for that use-case.

Ok, I'll pull the latest version. I don't update as much as I would like because I always need to manually update Lib/fontbakery/specifications/general.py to get the MSfontVal stuff working on MacOS.

I just pulled from master and now I'm on 0.5.2.dev18+gcff658dd I still get the same FAIL:
:fire: FAIL: Check font has a license.

com.google.fonts/check/028
:fire: FAIL No license file was found. Please add an OFL.txt or a LICENSE.txt file. If you are running fontbakery on a Google Fonts upstream repo, which is fine, just make sure there is a temporary license file in the same folder. [code: none]

I just pulled this and I'm sill getting the same FAIL

hmmm... can you provide further details?
Now it is working for me:

I'm trying this on: https://github.com/googlefonts/staatliches

So, what you mean is that you expect the check to find a license that is not in the same directory as the font files...

The license file should be in the root directory of the git repo. Could we edit the following code so that we keep trying os.chdir('..') until we hit the directory with the .git directory, then check to make sure the OFL.txt file in that directory?
From: Lib/fontbakery/specifications/googlefonts.py

@condition
def licenses(family_directory):
  """Get a list of paths for every license
     file found in a font project."""
  licenses = []
  if family_directory:
    for license in ['OFL.txt', 'LICENSE.txt']:
      license_path = os.path.join(family_directory, license)
      if os.path.exists(license_path):
        licenses.append(license_path)
  return licenses

@condition
def license_path(licenses):
  """Get license path."""
  # return license if there is exactly one license
  return licenses[0] if len(licenses) == 1 else None

@condition
def license(license_path):
  """Get license filename."""
  if license_path:
    return os.path.basename(license_path)

@check(
  id = 'com.google.fonts/check/028'
)
def com_google_fonts_check_028(licenses):
  """Check font has a license."""
  if len(licenses) > 1:
    yield FAIL, Message("multiple",
                        ("More than a single license file found."
                         " Please review."))
  elif not licenses:
    yield FAIL, Message("no-license",
                        ("No license file was found."
                         " Please add an OFL.txt or a LICENSE.txt file."
                         " If you are running fontbakery on a Google Fonts"
                         " upstream repo, which is fine, just make sure"
                         " there is a temporary license file in"
                         " the same folder."))
  else:
    yield PASS, "Found license at '{}'".format(licenses[0])

This needs work because it results in a FAIL when one isn't warranted more often than it prevents an unwarranted PASS.

I agree that we need some routine to infer where's the root dir.
But simply going deep on .. until a .git is found is not safe since a user might run fontbakery on a directory that is not version-controlled at all. And then the proposed algorithm would end at the system root!

Can we start by only accepting the first .. if the current dir is called fonts ?

That would be a HUGE improvement. With variable fonts it most likley will be the first .. if the current dir is called fonts.

But this check should work with not-versioned font projects as well.

Could we just have it check the directory fontbakery is run from for now? I like to run it from the root dir of the fonts repo anyway.
The main problem here is that we shouldn't have to explain to people new to FontBakery that this test is almost always wrong in the markdown output.

Checking pwd, same path as each font file, if they are not in pwd and
deduplicated, and git rev-parse --show-toplevel (if it returns something)
seems sufficient to me

From an email earlier today.

And some of the test fail cases does not make sense.
eg: Check font has a license , There is a LICENSE.txt in repo with OFL. But test fails.

There is a LICENSE.txt in repo with OFL. But test fails.

Correct; OFL should be named OFL.txt which is what was recommended by SIL when the OFL was published by them, and has been used consistently since.
I can see that perhaps if Github does not recognize OFL.txt as a valid license filename, it might be good to change all GF projects to require that. But I think the GF API will always regurgitate OFL licenses as OFL.txt, so its a distracting change that has a lot of costs for the GF team if we want to go down that route. And is such a low priority...

My next step here before closing this issue will be implementing Dave's proposal of "Checking pwd, same path as each font file, if they are not in pwd and deduplicated, and git rev-parse --show-toplevel (if it returns something)"


Make Doppelganger a part of Waffle

Also a general thing. Do we want to keep the name Doppelganger? Maybe something like MockContract would be more descriptive?

Also a general thing. Do we want to keep the name Doppelganger? Maybe something like MockContract would be more descriptive?

I'd keep a name as a tribute to @spherefoundry 😃. Not everything should have a generic title IMO. @marekkirejczyk  What do you think?


UofT-DSI | applying_statistical_concepts - Assignment 2

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Assignment 2 submission
What did you learn from the changes you have made?
I have learned more about how to implement and visualize a linear regression model.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
the statsmodel library contains a nice summary for linear regression but I understand this is an intro course and there would be more time required to go over a different library.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
N/A
How were these changes tested?
This code was run locally to ensure outputs were correct.
A reference to a related issue in your repository (if applicable)
N/A
Checklist

[x] I can confirm that my changes are working as intended

A2: Complete
Please make the small change noted below. Good work
Q1, part (iii) you sorted the values, but did noy capture the top 5 rows with highest hp. In fact you sorted them by MPG


Update to build on latest nightlies

This pr attempts to build this lib on the  nightly-2019-03-14 version of rust.
proc_macro crate had some breaking changes since last commit, so proc_macro2 along with quote and syn are updated, and tql_macros is migrated to new version of syn and quote. Unfortunetly, using sql! macro still requires feature gate (proc_macro_hygiene).
There are currently 2 things left:

tests/select_expr.rs fails to build, due to this line: let table = sql!(TableSelectExpr[result()]).unwrap(); .It seems that cause of it is independent of this pr – when i tried to build master branch on some old nighties (like nightly-2018-04-15) i got the same error. When this line and assosiated assertion is removed, tests work fine. Is it ok to skip this in this pr?
for now, i only fixed compile tests that had trivial errors (just way that those errors are presented  by compiler is slightly diffrent). I am unsure about remaining ones. Majority of them fail because rustc detects more errors, like  missing extern crate rusqlite or cannot find value connection - is it better to just fix those additional errors, or add them to *.stderr file ? . For other cases error message is somehow difrent or error span slightly changed - i yet have to look into it

For the select_expr.rs, you can keep it commented. I'll look into this later.
For the second point, could you please fix the errors? compile_test generate some files that are useful to get the actual end expected errors: this makes updating the .stderr file faster.
Thank you for your contribution.

Thanks for your work.
Is it ready to be reviewed?

Ok, i think that it's now ready for review

Thank you so much.
I'm curious: do you use tql in any of your projects?

To be honest, not yet - this pr was actually prelude to my experimets with tql :P
I found tql's interesting since syntax looks much cleaner than diesel's approach, and i decided to try it. I also wanted to do some proc-macro tinkering for a while but didn't have idea for something bigger, so.. i decided to try this at last :P

Anyway, i just noticed one side offect of this pr -seems that  some of error messages imporved on stable. For example, if i make a typo in a field name when filtering, it shows error with a span of proper ident, not the whole macro. Actually i should expect something like this , sice minimal version of Span is actually stable  :smile:

I hope you'll find this crate useful.


up stimulants (no sleep)

About the PR

in this pull request, I made stimulants to rouse a person from sleep. Also reduced the cooldown on the wake up button.
Why / Balance

Tranquilizers put a person in hardsuit in sleep after only 2 shots. If you shoot more sleep can long minutes.
This is quite disbalanced for nuke ops. With this pr nukies won't be countered by two shots of trancs as long as they have stimpacks. Also you can inject your teammate and after a few seconds wake them up.
Technical details

Stimulants remove ChloralHydrate 10 u per second from the blood, and also remove forced sleep. Also cooldown on the wake up button reduced to 2 seconds
Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

tweak: stimulants removes chloral hydrate from body

waking up cooldown acts as part of nocturine's balance, it probably shouldn't be changed.

waking up button won't work as long as you have nocturine in you

as a warden gamer who liked sleeping entire nukie squads with one enforcer.
I am crying rn.

Can we make other types of stimulants like meth also reduce sleepy time


Quantized model under checkpoint mode performs quite different from the one under jit mode

I have trained an original asr model and i convert it into quantized model in both jit mode (named asr_quant.zip) and checkpoint mode (named asr_quant_checkpoint.pt). But the results from the jit mode and the checkpoint mode are quite different.
Quantized model in jit mode:
test Final result: 甚至出现交易几乎停滞的情况
Quantized model in checkpoint mode:
INFO BAC009S0764W0121 ▁LAWS骑钰阐易ISH燕▁CRITIC▁QUANTITY▁GOING骑燕▁MORE鲨ANSISH致▁GOING燕▁GOING燕▁GOING▁DESIRED▁GOING▁BREATH▁CRITIC俏尺骑▁GOING骑▁PERFECTION燕▁GOING燕▁SH燕▁SH谊▁PERFECTION敷唬诊▁SH定▁OVEN▁ORDERS尹O▁IGNORISH▁PRESIDENTO锣OKA▁PERFECTIONISH燕▁EIGHTEEN笛燕何▁PERFECTION▁INFORMEDLAND何骑▁PRETTY燕湿O▁PERFECTION尺O燕汐辆女何燕翼鲨O▁PERFECTION▁FIRST架燕绘翼盘锣▁THIS▁PRETTY▁SONG▁PERFECTION唬▁INFORMED障渲▁EIGHTEEN锣燕咏劈赌盘涉燕轧▁ABSORB汐O▁PERFECTION锣▁EIGHTEEN燕▁SH燕▁SH敷▁PRESIDENT书敷诊唬治唬唯轧辆▁IGNOR▁DOESN▁PERFECTION▁IGNOR洒翼O▁SAVE▁FIRST▁KISS▁PERFECTION锣▁PERFECTION备惭骑企洒▁PERFECTION洒慌▁SH▁CANDLE▁CHIN▁CANDLE企▁CHIN▁LIBERTY锣▁WEATHER▁FIRST▁COUNTRY敷▁CLERK

We have no idea. Quantized model is for runtime, so it should be in jit mode, why you save it with checkpoint?

I would like to load the quantized checkpoint to speed up the python inference.

quantized checkpoint should be used in QAT mode, see https://pytorch.org/docs/stable/quantization.html


wrong server cert used on api requests to IP but domain name requests ok

This works fine when DNS is setup but for some reason the nginx configuration doesn't like curl requests like like the one below. Note in the header in the curl request should get us to api.cloudfeaster.com but instead it goes to api.cloudfeaster.com.
>curl -s -v --insecure -L -X POST -d @crawl.json -H 'Content-Type: application/json; charset=utf-8' -H 'Host: api.cloudfeaster.com' -u dave:simons https://$CLF_IP/v1.0/crawls | jq
*   Trying <IP_ADDRESS>...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 443 (#0)
* TLS 1.2 connection using TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384
* Server certificate: docs.cloudfeaster.com
* Server certificate: COMODO RSA Domain Validation Secure Server CA
* Server certificate: COMODO RSA Certification Authority
* Server certificate: AddTrust External CA Root
* Server auth using Basic with user 'dave'
> POST /v1.0/crawls HTTP/1.1
> Host: api.cloudfeaster.com
> Authorization: Basic ZGF2ZTpzaW1vbnM=
> User-Agent: curl/7.43.0
> Accept: */*

list issue is old but might still apply given how TLS termination works and how API docs will be deployed

closing since this refers to a very old architecture/implementation of this infrastructure


[FLINK-5890] [gelly] GatherSumApply broken when object reuse enabled

GatherSumApplyIteration uses reduce and join for which extra care must be taken when object reuse is enabled. Adds a check for objects returned by the user to prevent system objects from being overwritten.
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[x] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[ ] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

Fix looks good.
Is this tested implicitly by some other test already?

I'm not understanding the question. I modified an existing test to use mutable types which were previously failing.

@StephanEwen, I updated the test to include the original test plus a new test with object reuse enabled.
@vasia, would you be also be able to review this change?

@greghogan you are right, I overlooked the adjusted tests!
This looks like a good fix, please merge!

@StephanEwen my last comment was ambiguous, I had originally modified a test and then with yesterday's commit reverted that change and added as a new test.
Will merge.


Update Out-RsFolderContent.ps1

Fix for recursion paths and item retrieval

Fix for recursion path and recursive item retrieval. Now folders will properly retrieve and nest as expected.


Merge branch 'develop' into feature/custom-notifications

Hello !
Thanks for your work, this is very useful !
Do believe that you can add a shortcut to delete a conversation ?
Maybe not just "delete", but "ctrl + delete" or "fn+delete" ?
That could be very great !
Bye ;-)
Clément
P.S. Excuse me if I did not post this request at the right place, this is my first GitHub request...

Unfortunately, it's not possible for the moment (Google doesn't offer this functionality from the webapp). Thanks ! 😊

Unfortunately, it's not possible for the moment (Google doesn't offer this functionality from the webapp). Thanks ! 😊


blockchain: zero-knowledge proofs

What's this PR do?

[x] Basic concept about zero-knowledge proofs

@thanhpn is this ready to review?

@thanhpn is this ready to review?

Yes, I am still researching some papers related to this tech and I will release 2-3 posts about it.


Replace all doesn't work when there are > 999 matches

VSCode Version: Version 1.16.1 (1.16.1)
OS Version: macOS High Sierra Version 10.13

Steps to Reproduce:

Open file with lots of text.
Replace text that matches thousands of times
Observe nothing happens

Reproduces without extensions: Yes

Duplicate of #32522. Fixed already in stable starting with 1.17


added 4 books, 1 class, and seaborn

I added two data visualization books, two analysis books, Harvard's data visualization class, and Seaborn, a python plotting library.

FYI - I moved R resources to another md within the repo. The core curriculum focuses on the best resources for python-based data science.
Thanks for the PR! I'll review the resources and look for an amendment.


LfMerge v2

We want to be able to sync CRDTs with mercurial. LfMerge is the ideal place to do this because it already had most of the plumbing to do that.

[ ] Enable multiple sync targets
[ ] add a simple web API to queue jobs and query their status
[ ] implement a crdt sync target

instead we built CrdtMerge in lexbox


PP-4096 update service name

Updated ServiceEntity#addServiceName to act as an add or update if
exists. This is necessary when applying the patch operations and in the end
the entity is persisted to the db.

Updated ServiceNameEntity to be created from ServiceUpdateRequest,
such that when a PATCH operation is received for service name, then it
can be created successfully
Added ServiceUpdatedRequest#getUpdateRequests to return a list of
updated requests from the payload, so the PATCH payload can be deserialised
into individual ServiceUpdateRequests
Updated ServiceRequestValidator to validate for the service_name object as well
Renamed ServiceRequestValidator#FIELD_NAME not to clash with the
actual field FIELD_SERVICE_NAME
Added new validation methods in RequestValidations that will return
an empty collection if no errors, instead of wrapping the collection into
an Optional and then testing if the optional is present. Unnecessary
wrapping into Optional
Added unit tests for the new resource and the new validator
Added JSON files where to keep the payload for testing the request or
the validator. It feels easier to see the JSON object in a separate file
than to create it by hand using lists, maps etc. and to hope that you got
it right first when you try to serialize it into JSON. This is a pattern
we might adopt in other places
Updated ServiceUpdateRequest to handle both arrays and objects for the
PATCH request
Removed the name field from the equals and hash methods from a
ServiceNameEntity such that when adding to the set of service names from
ServiceEntity then the equals method will reflect that a service can
have only one service name for a given language. This is also useful in
addOrUpdate when if the service name for the given language already
exists then it will be updated

The answer to what happens if we get an English service name update where both "path": "name" and "path": "service_name", "value": {"en": …} operations are specified but the names conflict is that one will override the other. This should never happen in practice though (only selfservice will call this endpoint), so we don’t really need to worry about it.


Ignore ruby version and gemset files

Some developers (like me!) want to use RVM (or rbenv) to manage their
Rubies and gems while hacking on this library, but there's no reason to
enforce any one particular version of Ruby since this library would
ideally be portable to multiple versions of Ruby.

Thanks!


resolve:   @vuepress/core/.temp/style.styl

view:
https://github.com/vuejs/vuepress/issues/3065
add:
"devDependencies": {
"@vue/babel-preset-app": "4.5.18"
}

Hi, care to elaborate?

I have a similar problem.
I can succeed by trying the above scheme.
【https://stackoverflow.com/questions/74023189/vuepress-1-x-build-fails-error-in-node-modules-vuepress-core-temp-style-styl】

Ah, thank you so much. I'll bring back the github action to try with it.


Simplify missing Garmin Connect data handling, mark entities un/available

Proposed change

This cleans up missing Garmin Connect data handling as mentioned in #31670:

test for data availability and Noneness and return gracefully early when appropriate instead of testing repeatedly later and handling exceptions
mark entities for which no data is available as unavailable
combine duplicate Duration and Seconds code blocks to one

Caveat: I haven't actually tested this at all, will do later if you want.
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue: #31670 and #31608
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.
[ ] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] The code has been formatted using Black (black --fast homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

[ ] No score or internal
[ ] 🥈 Silver
[ ] 🥇 Gold
[ ] 🏆 Platinum

I like it, it catches the None and prevent KeyError which I didn't expect, maybe we should also set self._available = False in sensor init, and do this to get rid of pylint error:
        await self._data.async_update()

        data = self._data.data
        if not data:
            _LOGGER.error("Didn't receive data from Garmin Connect")
            return

        if data.get(self._type) is None:
            _LOGGER.debug("Entity type %s not set in fetched data", self._type)
            self._available = False
            return

        self._available = True

        if "Duration" in self._type or "Seconds" in self._type:
            self._state = data[self._type] // 60
        else:
            self._state = data[self._type]

        _LOGGER.debug(
            "Entity %s set to state %s %s", self._type, self._state, self._unit
        )

Can you change it in your PR and perhaps also test it?

Pylint error should be fixed now.
I didn't change available=False to be the default, because I don't know how that works or if it has side effects with when disabled entities are added (can they be enabled normally later? any other weirdness?), and I don't think I've seen a case where it has been set to False by default in any other integrations.
Deployed and will leave it running/testing now, and see later what's happened.

Seems to work fine here.

Fine for me too. @MartinHjelmare can this be merged?

Should #31670 be closed when merging here?

Yep, marked as closing.


[WC-1887] Fix: container handles only own events

Pull request type

Bug fix (non-breaking change which fixes an issue)

Description
This PR fixes the issue with keyboard event propagation through the tree node container. Now the tree node container handles only its own events and lets child events pass through, so "enter" and " " (space) keyboard events can pass through and be handled correctly and, as a result, can be seen in input elements.

What should be covered while testing?
You need to create a tree node with a custom header and custom content. Put a text box and a text area as a child.
Expected: After running the project, you should be able to type " " (space) and use "enter" and arrow keys in the input and textarea.

I tested this in the test project of the original ticket. I am able to use space, arrow keys and enter, but when I double click to select text this quickly opens and closes the node. This will be fixed in an upcoming story.


Lossless compression of scaled images

Losslessly compressed the scaled versions of the images.  This reduced the file size by more than 10% but should not affect image quality.  A nice side effect is that sites using these images should have a significantly higher Google Page Speed score.

@chrisgherbert Sounds good.
How did you compress them? Is it something that can be added to resize-photos.sh, so future additions are also compressed.

I used a GUI tool, ImageOptim, but behind the scenes I think it uses JPEGOptim (https://github.com/tjko/jpegoptim).
I could add that to the script, though I don't know if you want another dependency in addition to ImageMagick.

Yes please, do add it to the script, another dependency's fine. I guess if the program's not available, the other conversions will still take place.
In the meantime I'll merge this one.
Thanks!


v1, Typescript typings fix Ripple index export.

issue 1140.

You should probably fix the typings file here instead of changing the API of the project

Well either is fine, but the API does not get changed by this change.


Update package.json

Moved following deps to devDependencies:
rollup-plugin-node-polyfills
rollup-plugin-polyfill-node
vite-plugin-dts

I didn't test extensively!
Also notice that there is a major upgrade for vite-plugin-dts to 3.2.0 available
vite-plugin-dts causes security warnings for npm audit:
# npm audit report

semver  7.0.0 - 7.5.1
Severity: moderate
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
No fix available
node_modules/@microsoft/api-extractor/node_modules/semver
node_modules/@rushstack/node-core-library/node_modules/semver
  @microsoft/api-extractor  7.9.1 - 7.36.2
  Depends on vulnerable versions of @microsoft/api-extractor-model
  Depends on vulnerable versions of @rushstack/node-core-library
  Depends on vulnerable versions of semver
  node_modules/@microsoft/api-extractor
    vite-plugin-dts  >=1.1.0
    Depends on vulnerable versions of @microsoft/api-extractor
    Depends on vulnerable versions of @rushstack/node-core-library
    node_modules/vite-plugin-dts
      @portal-payments/solana-wallet-names  *
      Depends on vulnerable versions of vite-plugin-dts
      node_modules/@portal-payments/solana-wallet-names
  @rushstack/node-core-library  >=3.25.0
  Depends on vulnerable versions of semver
  node_modules/@rushstack/node-core-library
    @microsoft/api-extractor-model  >=7.8.12
    Depends on vulnerable versions of @rushstack/node-core-library
    node_modules/@microsoft/api-extractor-model

6 moderate severity vulnerabilities

Thanks @ronnyhaase !


Loosen the DC/OS version check

Currently it only accepts DC/OS 1.XX. This uses a library instead of a
regex for more flexibility.
It also avoids false-positive by just printing a warning if we can't
parse the version for some reason. It might then still be possible for
the setup flow to install the default plugins, through Cosmos for example.

@mesosphere-ci run integration tests

@mesosphere-ci run integration tests


[Feature]: replace signature_to_json_schema with pydantic

What would you like to see added to NeuroConv?
See demo:
import json
from typing import List, Optional, Union

from pydantic.decorator import ValidatedFunction
from neuroconv.datainterfaces import SpikeGLXRecordingInterface

def print_json(dict_, indent=1):
    print(json.dumps(json.loads(dict_), indent=indent))

json_schema = ValidatedFunction(SpikeGLXRecordingInterface.__init__, None).model.schema_json()
print_json(json_schema)

def my_func(a: Optional[List[List[Union[str,int]]]] = None):
    pass

json_schema = ValidatedFunction(my_func, None).model.schema_json()
print_json(json_schema)

{
 "title": "Init",
 "type": "object",
 "properties": {
  "self": {
   "title": "Self"
  },
  "v__duplicate_kwargs": {
   "title": "V  Duplicate Kwargs",
   "type": "array",
   "items": {
    "type": "string"
   }
  },
  "file_path": {
   "title": "File Path",
   "anyOf": [
    {
     "type": "string"
    },
    {
     "type": "string",
     "format": "path"
    }
   ]
  },
  "stub_test": {
   "title": "Stub Test",
   "default": false,
   "type": "boolean"
  },
  "spikeextractors_backend": {
   "title": "Spikeextractors Backend",
   "default": false,
   "type": "boolean"
  },
  "verbose": {
   "title": "Verbose",
   "default": true,
   "type": "boolean"
  },
  "args": {
   "title": "Args",
   "type": "array",
   "items": {}
  },
  "kwargs": {
   "title": "Kwargs",
   "type": "object"
  }
 },
 "required": [
  "self",
  "file_path"
 ],
 "additionalProperties": false
}
{
 "title": "MyFunc",
 "type": "object",
 "properties": {
  "a": {
   "title": "A",
   "type": "array",
   "items": {
    "type": "array",
    "items": {
     "anyOf": [
      {
       "type": "string"
      },
      {
       "type": "integer"
      }
     ]
    }
   }
  },
  "v__duplicate_kwargs": {
   "title": "V  Duplicate Kwargs",
   "type": "array",
   "items": {
    "type": "string"
   }
  },
  "args": {
   "title": "Args",
   "type": "array",
   "items": {}
  },
  "kwargs": {
   "title": "Kwargs",
   "type": "object"
  }
 },
 "additionalProperties": false
}

Is your feature request related to a problem?
No response
Do you have any interest in helping implement the feature?
Yes.
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Have you ensured this bug was not already reported?

It may require some adjustments to our typehints to play nicely with these tools.

Looking into it now, playing well so far with some minor logic to correcting the format for path types

So apparently standard jsonschema validation doesn't even use the format="file" vs "format" when checking such fields; but pydantic seems to have come a long way since the last time I tried it, they've extended JSON in a number of ways for such complex string types: https://docs.pydantic.dev/usage/schema/#json-schema-types

Good find! It looks like pydantic defines some of their own format specifications for json schema, including "file-path" and "directory-path".

Let's use their typehints:
FilePath = Annotated[Path, PathType('file')]
DirectoryPath = Annotated[Path, PathType('dir')]
NewPath = Annotated[Path, PathType('new')]

Yeah and it works with the above code applied to the .model of the decorator
model = ValidatedFunction(my_func, None).model
json_schema = model.schema_json()

# manually adjust the format to 'file' at the corresponding part

jsonschema.validate(instance=dict(file_path="/folder/path/"), schema=json_schema)  # passes, doesn't check it

model.parse_obj(dict(file_path="/folder/path/")  # throws error

will swap the annotation types to pydantic and swap jsonschema.validate for pydantic.parse_obj on a model

This looks like slightly nicer syntax:
model = ValidatedFunction(my_func, None).model
json_schema = model_schema(model)

as it gives you the json schema in dictionary form instead of as a string

from pydantic.decorator import ValidatedFunction
from pydantic.schema import model_schema
from neuroconv.datainterfaces import SpikeGLXRecordingInterface

model = ValidatedFunction(SpikeGLXRecordingInterface.__init__, None).model

json_schema = model_schema(model)

for prop in ["args", "kwargs", "self", "v__duplicate_kwargs"]:
    if prop in json_schema["properties"]:
        json_schema["properties"].pop(prop)

json_schema["required"].remove("self")

json_schema


Missing file?

I'm trying to run d-voting locally with run_local.sh and get the following error:
Frontend:  > react-scripts start
Frontend:
Frontend:  [HPM] Proxy created: /api  -> http://localhost:6000
(node:93363) [DEP_WEBPACK_DEV_SERVER_ON_AFTER_SETUP_MIDDLEWARE] DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:93363) [DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE] DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
Frontend:  Starting the development server...
Frontend:
Frontend:  Failed to compile.
Frontend:
Frontend:  Error: ENOENT: no such file or directory, open '/Users/ligasser/Programming/C4DT/d-voting/web/frontend/src/pages/utils.ts'
Frontend:  assets by path static/ 9 MiB
Frontend:    assets by path static/media/ 3.75 MiB
Frontend:      asset static/media/d-votingSystem.d5ed0dc747855e1b7ba4.png 3.59 MiB [emitted] [immutable] [from: src/assets/d-votingSystem.png] (auxiliary name: main)
Frontend:      asset static/media/introductionImage.f690b653240897d95d74.png 125 KiB [emitted] [immutable] [from: src/assets/introductionImage.png] (auxiliary name: main)
Frontend:      asset static/media/logo.38814265c75c299336ae.png 36.9 KiB [emitted] [immutable] [from: src/assets/logo.png] (auxiliary name: main)
Frontend:      asset static/media/EPFL_Logo_184X53.0dc977f39277319703b73534b2c1fb38.svg 1.36 KiB [emitted] (auxiliary name: main)
Frontend:    assets by path static/js/*.js 5.25 MiB
Frontend:      asset static/js/bundle.js 5.24 MiB [emitted] (name: main) 1 related asset
Frontend:      asset static/js/node_modules_web-vitals_dist_web-vitals_js.chunk.js 6.92 KiB [emitted] 1 related asset
Frontend:  asset index.html 1.65 KiB [emitted]
Frontend:  asset asset-manifest.json 844 bytes [emitted]
Frontend:  cached modules 4.85 MiB (javascript) 3.75 MiB (asset) [cached] 1073 modules
Frontend:  runtime modules 31.7 KiB 17 modules
Frontend:  ./src/pages/utils.ts 39 bytes [built] [1 error]
Frontend:
Frontend:  ERROR in ./src/pages/utils.ts
Frontend:  Module build failed (from ./node_modules/source-map-loader/dist/cjs.js):
Frontend:  Error: ENOENT: no such file or directory, open '/Users/ligasser/Programming/C4DT/d-voting/web/frontend/src/pages/utils.ts'
Frontend:   @ ./src/pages/form/components/utils/display.tsx 4:0-47 6:9-20
Frontend:   @ ./src/pages/form/components/SelectResult.tsx 7:0-49 29:22-36 105:22-36
Frontend:   @ ./src/pages/form/IndividualResult.tsx 7:0-67 106:96-118
Frontend:   @ ./src/pages/form/Result.tsx 15:0-50 186:45-61
Frontend:   @ ./src/layout/App.tsx 13:0-46 123:44-54
Frontend:   @ ./src/index.tsx 11:0-29 332:39-42
Frontend:
Frontend:  ERROR in No files matching '/Users/ligasser/Programming/C4DT/d-voting/web/frontend/src/pages/utils.ts' were found.
Frontend:
Frontend:  webpack 5.73.0 compiled with 2 errors in 1606 ms
Frontend:  Files successfully emitted, waiting for typecheck results...
Frontend:  Issues checking in progress...
Frontend:  No issues found.

src/pages/utils.ts has been renamed to src/pages/utils.tsx which does not seem to be a problem in the Docker images
maybe you need to remove your current installation and rebuild it?

Have you tried turning it off and on again?


[Bug]: Clicking an Input gives errors in the console

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When you click an Input widget in Appsmith you get two errors in the console:

Executing undefined action
Failed to fetch

This doesn't appear to affect app functionality at the time of writing.
Steps To Reproduce

Drag a new input onto the canvas.
Open the browser console.
Click into the input.
Observe the above errors in the console.

Public Sample App
No response
Environment
Production
Severity
Low (Cosmetic UI issues)
Issue video log
No response
Version
Cloud

Not a valid issue


UI5 fails to load CORS compliant external APIs

OpenUI5 version:
1.56.7
Browser/version (+device/version):
Chrome
Any other tested browsers/devices(OK/FAIL):
IE works fine.
Steps to reproduce the problem:

Use any external CORS compliant (which returns Access-Control-Allow-Origin: * ) API from your UI5 application.
I am using https://services.arcgisonline.com/ArcGIS/rest/services/World_Street_Map/MapServer?f=json, which returns Access-Control-Allow-Origin: *.
But UI5 sends additional http header x-xhr-logon with the API call which is not expected by the external API.

What is the expected result?
Do not send header x-xhr-logon header along with the request to external API.
What happens instead?
Sends unwanted http headers.

Hi @krisho007,
you have the chance for a "destination" also on premise.
CU
Gregor

Hi @gregorwolf , Yeah I am aware of Web Dispatcher. But I do not want to do it as the third party API is CORS compliant (returns Access-Control-Allow-Origin: * ).  SAPUI5 should fix this.

The code you mention is not handled by this project. Run an incident through the support system and my colleagues will route you to the correct team/project in order to get details about authentication in FLP

But I do not have control on (when) this external API call.
Can you elaborate on this? Is this API used somewhere in the SAP standard?

Hi Krisho007,
what is the solution to this issue please suggest.I am also getting same error.
BR,
Ram

@gregorwolf : I use an external JS library, which makes further calls to external CORS compliant library. These 'further calls' are not directly initiated by me, thus I cannot rout them to web dispatcher.

@rkmishra2703 : SAP has replied that issue is with Fiori Launchpad.  (as @matz3 rightly pointed out). I will update here when I get a solution.

SAP has provided a solution. This issue is resolved with SAPUI5 version 1.60.9.

SAP has provided a solution. This issue is resolved with SAPUI5 version 1.60.9.

Hi @krisho007 do you happen to have the SAP Note number for that issue?

@fabiopagoti There is no Note for it. SAP replied that the bug is resolved with 1.60.9 and I have verified it.

@mschleeweiss,
Can you please let me know, how to override the standard XHR methods in the UI5 application?
if possible can you publish it in git repository?


Received transactions : remove votes

See issue #194 for previous work on votes being considered as sent and received.
Something was left : we could still see the votes in the received transactions (and with a red color meaning sent).
So here filtering the votes transactions in receivedByAddress function.

An issue with this is that the count on the wallet page still considers votes to be both sent and received. Therefore this change will introduce inconsistencies between the count and the amount of received transactions that are actually shown. I'm not sure whether that's desirable (@faustbrian ?), as it might result in wallets that have 20 incoming transactions, while the page only shows 10 due to the other 10 being votes that were filtered.
The count is fetched by the receivedByAddressCount function in the same file, but with the current API we cannot fetch the count without votes, as we cannot exclude them in the query due to the API ORing all parameters. I have looked into this recently when discussing PR #146 , where it basically comes down to waiting for v2 before we can correctly handle this.

Yes @ItsANameToo gave me a headache trying to see how we could get the count right 😅 but yes as you say in #146 I think we just have to wait for API v2.
So yes maybe we can wait v2 to do it all right (transactions + transactions count).

As @ItsANameToo said, it would be better to wait for v2 to have better filtering capabilities. Will close this until v2 hits devnet.


Deployment scripts

Should this PR be converted to draft? It looks like the last commit mentions WIP.


Settings Module - Discussion

I think the real catch is the question of how you save all of the settings.  Maybe we would need to send some json back to C# and write that out on disk.  Maybe something that writes out cactbot/user/raidboss-autoconfig.js so that folks can still do manual customization, but this UI could generate the same sort of input that folks are now doing manually.  That's just a thought, though.  Maybe you have some alternative idea of how to persist and reload this data.
Originally posted by @quisquous in https://github.com/quisquous/cactbot/issues/155#issuecomment-425288116

I had a few ideas about the current way the settings works.
You are using a sort of priority system if I understand it correctly

Loads module, for example raidboss
Module loads its default settings as variable Options
UserConfig class loads configuration information from files user\raidboss.js
You have something setup to load the script even when the user is using a remote hosted file. If I understand it correctly.

I had the idea of using localStorage to store the settings information for the current user.
We could, in theory, append these steps to sync to the localStorage.
We would still have the priority system as it is now, but the localStorage would be the final settings location for all of this. If the values didn't exist in localStorage, they would be loaded and then localStorage would be created as part of this process. If they did exist, they would override the settings just as the user settings folder does now.
LocalStorage -> user\raidboss.js -> raidboss.js
We could create an EXPORT/IMPORT function to store the LocalStorage values and this could make it easy for a raid-group to share settings, or custom triggers if added to UI at some point.
Some downsides to this method obviously do exist, for example if someone clears all browser data it could delete these settings.
This would have an advantage though for people using the current version hosted on GitHub, the localStorage settings would be able to work pretty seamlessly.
Other related thoughts:
I had thought it would be neat to extend the UI to add custom triggers, name overrides, adding new triggers could also be done, with some preset conditions for non-technical types. Of course at some point I think it would be ideal to be able to store these locally and you would need some backend to deal with that.
I'm not entirely sure what functionality you can extend within the context of the actual DLL. We would only really need the ability to perform some CRUD operations.

Local storage sure sounds good, except it is not hooked up in CefSharp and doesn't work.  I would have likely used it for the pull counter if I could.
I think that means that we'd need to send the config back to the C# plugin so it can persist it to disk.  The pull counter code already does this (although it stores it in the ACT config for the plugin, which is maybe not what we want to do here).
One option here is to just have this write out something like cactbot/user/raidboss-autoconfig.js, so that it's in a consistent spot with the manual config files and users will know where to delete it if need be.  This can then be included in that priority order (probably before the manual one?).  I'm not sure if that'd be a pain to read back in, though and know what the autoconfig settings were.

Another open question for me is what scope should this config run at, global for cactbot or local per module.  I can kind of picture either option?
Your mock has you click an icon on screen to bring up the config, but most overlays I suspect have click through enabled, so probably we'll need a C# button that says Config that could pop up the config.  On top of that, most overlays on screen aren't sized well to fit that config window.  (For example, oopsyraidsy is pretty small for me, and pull counter is even tinier.  Sending some JS to show a config menu inside the existing overlay wouldn't have any room.) So maybe hitting such a "Config" button would need to pop up another entirely separate overlay that's big enough for the config?
An alternative to all of this would be to have a separate config html file that folks would have to add as a separate overlay if they wanted to configure any of the overlay types, but that seems a bit cumbersome for a tool that's supposed to be making it easier.

An alternative to all of this would be to have a separate config html file that folks would have to add as a separate overlay if they wanted to configure any of the overlay types, but that seems a bit cumbersome for a tool that's supposed to be making it easier.

honestly I would prefer this method - bonus points if it allows for you to switch different timeline/trigger file versions for those who edit them.

So the way I wrote the UI so far was a separate config html file like you are talking about. It's its own module that they would have to setup like this: ui/settings/settings.html
Also on the topic of complexity the settings UI is optional I would think and they could either, continue editing files (arguably more confusing to some) or leave the default settings, or use settings overlay
On the config saving, I think sending it back to the C# plugin isnt a bad idea at all and overcomes some concerns with localStorage anyway (mostly clearing the data somehow losing it)
Here is an update to the UI gif I sent last time: https://gyazo.com/5b18dedcb622434f8263890034f81129
Few concerns with this after some work:
If it got bigger and had more features I found that some things are not working well with the UI and maybe we have a workaround and maybe not specifically focus and input boxes.
I noticed with the UI locked in place it wont show a focus on the input box, it ignores several CSS styling and often wont type in the box. *Is this a setting/config I'm overlooking?

@quisquous - usually just mechanical direction. The most recent example would be Larboard Starboard - cactbot calls the safe spot, when some players prefer having the mech called out directly:
 id: 'O11S Starboard Cannon 1',
      regex: / 14:326[23]:Omega starts using Starboard/,
      condition: function(data) {
        return data.lastWasStarboard === undefined;
      },
      alertText: {
        en: 'Starboard on Right',

vs
 id: 'O11S Starboard Cannon 1',
      regex: / 14:326[23]:Omega starts using Starboard/,
      condition: function(data) {
        return data.lastWasStarboard === undefined;
      },
      alertText: {
        en: 'Left',
      },
      run: function(data) {
        data.lastWasStarboard = true;
      },
    },

This is also the case in Suzaku - Cactbot states "Get In" when I'd rather "Knockback". "Get Out" would be "Draw In". This is also more in line with in game language:

@xDemonessx If there are triggers you don't like, the current way to fix that is to disable them by id in your cactbot/user file and then to add other triggers that do the thing you want in your cactbot/user file.  That way you don't have to keep re-editing.

@xDemonessx If there are triggers you don't like, the current way to fix that is to disable them by id in your cactbot/user file and then to add other triggers that do the thing you want in your cactbot/user file. That way you don't have to keep re-editing.

OK thanks, I keep forgetting about that. Its a lot to keep track of and editing timelines directly was always easier for me.

@quisquous Yeah I found it a little suprising as well. I am not sure but I was looking into how Electron (https://electronjs.org/) does it and it does not seem to be having the same issue  and the concept is similar.  They use webkit specifically to deal with the moving in CSS -webkit-app-region: drag; I couldn't figure out if that was in this codebase somewhere or if its handled by OverlayPLugin in some way.
With more thought on the subject I actually wonder if it might be easier to separate the Settings UI and the Overlays in a way.
You could create an entire interface in electron and have the additional file editing functionality.
Things like editing triggers or getting a list of triggers to disable might be rough in the overlay itself, I think we could do it though if we got creative.
Some of this stuff might be a lot easier with a separate, but full featured UI

Yeah I do agree with you about the flow being a lot easier if everything is is one very consolidated codebase.
In many ways I think you could look at this like a front-end to the back end interface, which could merit the separation.  You might be right that the app region thing is a very specific implementation. I couldn't find any way to override the way it was being handled although anything is possible I'm sure given time/effort input. It seems that it really limits the functionality which is unfortunate.

I think my biggest feedback here is that I think showing JavaScript at all and adding support for adding triggers isn't necessary.  I don't feel super strongly on this point, so if you feel differently, please push back.  I'm just trying to be a little bit opinionated here on what a config tool should look like.
As for showing JavaScript at all, if the goal is to show what potential trigger output looks like, I think there are maybe other ways to do that? It might also be enough to just say "this trigger outputs Alarm" or "Alert or Info" etc.
I also feel a little bit that if folks want to write their own triggers, that cactbot isn't necessarily the easiest way to do that? cactbot's trigger system is flexible, localized, and something that can be checked into source control, but it's also super complicated.  If you're not a programmer, then it's not that easy to write.  (And if you're not a programmer, I'd probably suggest just writing ACT or triggernometry triggers than adding cactbot ones?)   I don't quite know who the audience would be for writing trigger in a config tool.
Also, the o9s image looks nice, but my only thought is that you're signing yourself (or me) up for a lot of ongoing work whenever new things come out.
Unrelated to anything else, I suspect that things you'd want on a per trigger basis would be:

turn this trigger off entirely
play/don't play tts for this trigger, ignoring global settings
play/don't play sound for this trigger, ignoring global settings
show/don't show text for this trigger, ignoring global settings

With the thought being that maybe folks set up global settings for most of what they want and then flip switches on individual triggers that they want to behave differently? I do that for tts when I don't normally have it on.

I think you actually make a lot of good points here on that stuff.
I guess I got carried away a little bit.
I'm going to recap on this some on your thoughts too
Images:
The images can actually be harvested from the game files pretty easily so you dont need to crop or edit them or anything. I think it would be one effort per major patch cycle to get those images and a number of tools exist to help with that already. I would estimate the effort to be less than half an hour if you are already setup.

Alternatively and possibly better we could pull the images from XIVDB or Garland tools which have APIs for dealing with that stuff.

I think the biggest thing a config tool can do for people is to

Create a personal config file
Override default callout functionality.

I wonder if being able to purely "view" the triggers logic would be nice? If so, I would say that it would be best if we kept it hidden until a user asks to see it.
It may help with people reporting issues with specific triggers or not understanding what they should expect to get from the output, or do you think that would just be confusing too?
Thanks again!

Yeah, I think my other concern with images are copyright issues.  I think if it's part of the build process and isn't checked in, maybe that's less bad.  I think I'm just less keen on checking in ffxiv images into an open source repo.
Yeah, maybe some expand button to view the trigger source might be helpful if folks aren't sure what it does? I was trying to think of any easy way to print out examples of all the triggers, but it all just felt really redundant to the triggers themselves and not any easy way to automate it all.  That seems easiest.  it probably doesn't need to be shown by default.  I suspect that the vast majority of folks only care about high level settings.
Thanks for all your work here!  I see a lot of questions about configuring cactbot (even in this thread itself) and so this tool is going to be really great! :+1:

Just wanted to hop in here and say that the UI (from what I could see from the gifs) looks awesome :)

I wanted to check in and see if there was any update on a config tool? Is this still something you're working on?

Fixed with https://github.com/quisquous/cactbot/commit/0eeb44834f4aba1d48090538f9d6dd6ddd619439.


Add date range selection

Be able to select ranges of dates (so if the person clicked Nov 10 and Nov 13 then Nov 10, 11, 12, 13 are all selected

So the calendar can be used for only one range selection, because I don't know how to manage multiple range selections in the same calendar

One range is fine. What I meant was after two clicks on two different dates the calendar would populate days-selected with the range of dates between the two clicked dates (including the two). And on the third click it would clear the days-selected and assume we are selecting a new range. This can be an option that you can turn on in the html. So the calendar can work in two modes: multiple days selection (as it is now) or date range selection. I hope I am making sense :)

:+1:  I have a working sample with date range working, but its rather messy
https://gist.github.com/Freundschaft/b2ded0fa3fc43f5b4ecb

I created a pull request for range selections (very basic)
https://github.com/arca-computing/MultipleDatePicker/pull/43

Awesome, would love to have this added @mgohin.  Thanks @Freundschaft.

Going to check it on Monday, I'm a dad since Feb 5th so wasn't available a lot ;)

I also have updated code, but need to restructure and commit that code, will try to do that til monday

Ok guys, I'm available today.
I checked your PR @Freundschaft but it's not quite the demand of @katyaskr.
How should it work for you :
(1) I select Fev 2nd then Fev 28th and it selects the range 2 -> 28 (I'm ok with that)
(2) I select Fev 15th then Fev 10th, what happens ?
(3) I select Fev 15th and change month, do I keep Fev 15th tracked ?
(4) If the option is used we will not be able to (un)select a single date, it'll always be a range selection

sorry I wasnt able to do a structured PR, here's my current version (unstructured) if you're curious:
https://gist.github.com/Freundschaft/27a843f3405643f859e6
Will do a structured PR hopefully soon as soon as I have time.
(1) that's how I built it
(2) If you select Feb 15th and then Feb 10th, the behavior I implemented follows what most range date pickers do: it selects Feb 10th only and as the start for the range.
(3) yes, in order to allow range selection over multiple months
(4) yes. but I think it will be kind of hard to have a control that offers range and single date at the same time. It should be added as a note that if the range control options are used, the control is only usable in single date afterwards.
Alternatively, it's theoretically possible to only select the start date, then the end date would be undefined, and the surrounding controller could handle that case.

@Freundschaft Looking forward to your PR. As I needed range selection I used your version and it worked well. I had to modify your code to add a way to get the dates within range though. (Currently the dayClick() callback only allows to get the start and end date.)

I'm not available at this time, a lot of work but will look into it as soon as possible. If you do a PR it would be nice.
Will add a callback like rangeSelected

@mgohin Have you merged it or not? Please do it soon as I am in need of this feature too. Date range selection must be the very needed feature of a multi select calendar.

@cwagner22 Can you show your version with modification of @Freundschaft ? That will be really great and let us know how you have handled range selection?

I'm sorry guys I'm very overworked at this moment, don't have time to check it out, if we could have a clean PR I'd be glad to merge it.

I'm currently in holidays. I will try to clean my code this weekend to share what I have but I'm not sure it's ready for a PR yet. (Probably some bugs to fix)

I'm currently on holidays. I will try to clean my code this weekend to share what I have but I'm not sure if it's ready for PR yet (Probably some bugs to fix)

@cwagner22 Dude have you got some time to create a PR? If not can you please share your version and little description how to manage to do that? Will be grateful.

I updated the gist and fixed a bug that existed during seleciton causing visual glitches, and working towards a PR

I updated the PR at https://github.com/arca-computing/MultipleDatePicker/pull/43

let me check ;)

I'm gonna merge it right now and make a release, let me know if something wrong.
So you can still use this datepicker ;)

Well FYI this is my current version: https://github.com/cwagner22/MultipleDatePicker/blob/master/multipleDatePicker.js
I was going to do some tests and code cleaning but I'm having some issue with my environment.

Available in 1.4.2 : https://github.com/arca-computing/MultipleDatePicker/releases/tag/v1.4.2

@Freundschaft can you provide an example ? not quite sure it's what requested @katyaskr

is an example on how to use it.
date-range containes a moment range object that contains the range of the selected dates.
range-start contains the start date of said range for direct binding
range-end contains the end of of said range for direct binding

with your way of doing it you must have a preselected range of dates ?

its two way bound, so binding an existing value to range-start and range-end should just work

but what if I want to enable range selection but don't have any preselected date ?

I think then binding to an empty scoped variable should work, not sure if I tested it though.

I removed 1.4.2 because it doesn't fit the request and isn't working well

what is not working well? and what is not fitting the request? I can make adjustments.

You should use an option to enable or not date range selection, binding an empty scope variable isn't quite clear.
Sorry I said it wasn't working, it's not what I meant, you should test your solution to be sure it's working, then I'll try it on the demo page and then push it to a release.

no worries, I can make the range usage flag explicit and add some samples to the demo
:+1:

Hi,
digging out this topic (too), now with combination of ng-model and ng-click you should be able to select any dates you want.


Fix rotation matrix and mul op

The dot product of a rotation matrix and vector was right, but separately these were wrong.

Coverage remained the same at 98.052% when pulling 484ac5fe6408918036bdf200b47a2d2bd207623c on fix-matrix-mult-op into 0cd1cf269879c561697f37cc9ac00a5276828c98 on master.

This PR has the __mul__ bug fix found by @ToddSmall and also gets the right-handed sense of rotation right. Here's a 90 degree ccw rotation of a unit vector example using numpy:
>>> from affine import Affine
>>> import numpy as np
>>> am = np.array(Affine.rotation(90.0)).reshape(3,3)
>>> am
array([[ 0., -1.,  0.],
       [ 1.,  0.,  0.],
       [ 0.,  0.,  1.]])
>>> point = np.array([1.0, 0.0, 1.0])
>>> np.dot(am, point)
array([  0.,  1.,   1.])

/cc @perrygeo @ToddSmall @mwtoews

Looks good. Here is one suggestion to consider for affine/__init__.py, line 229:

:param angle: Rotation angle in degrees, counter-clockwise about the pivot.

@sgillies Looks great - it's nice to have the rotation direction defined explicitly.
Could we also add @ToddSmall's test for associativity? https://github.com/sgillies/affine/pull/24/files#diff-3ebc029e55f312af9ae346c6433cd770R364

Coverage remained the same at 100.0% when pulling 2dc816de6302a79b5032484bfa847864797d7cee on fix-matrix-mult-op into b4234eac1bb19a7c6e88db25aae299234598c0e1 on master.


Error: while pushing data to elastic

PGSync version: latest (installed from PIP)
Postgres version: 14.1
Elasticsearch version: 6.8.6
Redis version: 5.0.8
Python version: 3.7
Problem Description:
bootstrap pushed a lot of entries to elastic but then throw below error. is it possible it is due to 1 million entries?
Error Message (if any):
2022-02-09 10:05:44.896:INFO:elasticsearch: POST http://<url>:9200/_bulk?refresh=false [status:200 request:14.729s]
2022-02-09 10:05:46.312:INFO:elasticsearch: POST http:/<url>:9200/_bulk?refresh=false [status:200 request:12.743s]
 0:02:10.208489 (130.21 sec)
2022-02-09 10:05:46.489:ERROR:pgsync.base: Exception (psycopg2.errors.UndefinedObject) replication slot "slot_name" does not exist

[SQL: SELECT xid, data
FROM PG_LOGICAL_SLOT_PEEK_CHANGES(%(PG_LOGICAL_SLOT_PEEK_CHANGES_1)s, NULL, NULL)
WHERE CAST(CAST(xid AS TEXT) AS BIGINT) < %(param_1)s]
[parameters: {'PG_LOGICAL_SLOT_PEEK_CHANGES_1': 'slot_name', 'param_1': 48325885}]
(Background on this error at: https://sqlalche.me/e/14/f405)
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1803, in _execute_context
    cursor, statement, parameters, context
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/default.py", line 732, in do_execute
    cursor.execute(statement, parameters)
psycopg2.errors.UndefinedObject: replication slot "slot_name" does not exist

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/pgsync/base.py", line 812, in fetchall
    rows = conn.execute(statement).fetchall()
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1289, in execute
    return meth(self, multiparams, params, _EMPTY_EXECUTION_OPTS)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/sql/elements.py", line 326, in _execute_on_connection
    self, multiparams, params, execution_options
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1491, in _execute_clauseelement
    cache_hit=cache_hit,
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1846, in _execute_context
    e, statement, parameters, cursor, context
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 2027, in _handle_dbapi_exception
    sqlalchemy_exception, with_traceback=exc_info[2], from_=e
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/compat.py", line 207, in raise_
    raise exception
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1803, in _execute_context
    cursor, statement, parameters, context
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/default.py", line 732, in do_execute
    cursor.execute(statement, parameters)
sqlalchemy.exc.ProgrammingError: (psycopg2.errors.UndefinedObject) replication slot "slot_name" does not exist

[SQL: SELECT xid, data
FROM PG_LOGICAL_SLOT_PEEK_CHANGES(%(PG_LOGICAL_SLOT_PEEK_CHANGES_1)s, NULL, NULL)
WHERE CAST(CAST(xid AS TEXT) AS BIGINT) < %(param_1)s]
[parameters: {'PG_LOGICAL_SLOT_PEEK_CHANGES_1': 'slot_name', 'param_1': 48325885}]
(Background on this error at: https://sqlalche.me/e/14/f405)
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1803, in _execute_context
    cursor, statement, parameters, context
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/default.py", line 732, in do_execute
    cursor.execute(statement, parameters)
psycopg2.errors.UndefinedObject: replication slot "slot_name" does not exist

ignore it , fixed it at my side


WarpFieldUpdater.cpp: Nan in node candidate

May I ask, when we run this code has not appeared "Nan in node candidate" this problem, Initializing Quaternion is DualQuaternion(1, 0, 0, 0), Quaternion(0, 0, 0), But there are two dual quaternions declared in SolverIterationData.h and SolverIterationData.cpp
DeviceBufferArray< DualQuaternion >;  node_se3_0_;
DeviceBufferArray< DualQuaternion >;  node_se3_1_;
But node_se3_0_ and node_se3_1_ have no values, they are all DualQuaternion(0, 0, 0, 0), Quaternion(0, 0, 0, 0). So the dual Quaternion is all DualQuaternion(nan, nan, nan, nan), Quaternion(nan, nan, nan, nan).

I get same error
surfelwarp_app [...]/test_data/boxing_config.json
surfelwarp/apps/surfelwarp_app/main.cpp:40: The 0th Frame
surfelwarp/core/geometry/WarpFieldUpdater.cpp:21: Nan in node candidate
terminate called after throwing an instance of 'std::runtime_error*'
Signal: SIGABRT (Aborted)

Note that I had to increase kMaxNumSurfelCandidates
const unsigned surfelwarp::Constants::kMaxNumSurfelCandidates = 100000; to avoid previous error surfelwarp/common/DeviceBufferArray.h:90: The pre-allocated buffer is not enough


Support for multiple Pihole's

Hi,
This extension is what I was looking for.
However I have to Pi-hole's running, and whith the plugin I can only disable 1.
So would it be possible to implement this?
Thx!

Mhh, how do you imagine to control that?
Do you just mean to add one more server to the options and then the slider deactivates both at once?
Because i think otherwise this will be a mess in the UI.

Hi,
The simplest would be able to set two IP or hostnames so that the sliders deaactivates both Pi-holes.
Otherwise if I disable on 1 Pi-hole theirs a chanche the other Pi-hole resolves the querry.
Thx


Easy way to update angular2-seed core?

Is there easy way to update angular2-seed core ?
Can we manage angular2-seed as a core framework ?
this will easy to update seed

The easiest way is:
git remote add upstream https://github.com/mgechev/angular2-seed
git pull upstream master
# resolve the merge conflicts if any


Add a link for Gleam Weekly

I think you mean alongside things here

If so do you have a place you source the svg's from. I would suggest getting an email icon SVG?
Separately to that I think having it next to discord, whereever that might be i.e. here in the footer, makes sense because I think it always catches the people for whom discord is too high frequency. (I spotted a Gleam weekly link in the Gloogle footer which is what gave me the idea)

I'd probably add a section below them as it's not as important as either of those two forums

I'm not entirely sure how you would like this to be added here.

How does this look?


MODEL OVERFITTING ! !

high training accuracy,low testing accuracy

@charlesfufu
I answer through #7.


打印内容未居中对齐

version
0.9.71
Link to minimal reproduction
No response
Steps to reproduce

What is expected?
打印内容需居中对齐
What is actually happening?
打印内容未居中对齐
System Info
No response
Any additional comments?
No response

更多设置，看看选的纸张

我的问题 默认缩放90%


Simplified Chinese support

Great plugin, but it seems like no support for simplified Chinese in my Mac. Is it possible to support Chinese？

Same question. （同样的问题。）

I'll look into making this possible

New release has this feature


ARTEMIS-1740: Add support for regex based certificate authentication

This adds the possibility to have an optional properties file containing regular expressions to match against the DN.

@jbertram can you look into this one? you have more miles on security than I do. :)

This looks good except for a few things:

I would rather not have an additional file for the regex properties. I think it would be better to instead denote the regex in the normal user properties file using the traditional forward slashes (as described in the JIRA).
There's no documentation. The new functionality should be documented in docs/user-manual/en/security.md.
I'd like to see an integration test added to {{org.apache.activemq.artemis.tests.integration.security.SecurityTest}}. There's several tests in there already which test cert-based login.

The intent of  synchronized is to protect the modification of usersByDn.

@LionelCons
And it makes sense, but there are parts like:
String name = usersByDn.get(dn);
that are not synchronized, hence it won't be thread-safe.
My advice is to use a lazy initialization using a Suppliers::memoize or similar construct and always use Supplier::get to access the variable: that would allow to have always a thread-safe access to an unmodifiable resource, lazy initialized.

@franz1981 your comment goes beyond my modifications since the existing code already uses the get method (in getUserNameForCertificates and getUserRoles, at least).

The final code can be seen here.
Just like in the original code, both getUserNameForCertificates and getUserRoles still use get.

Thanks for the changes, @LionelCons. Can you squash your commits?

@jbertram can you squash the commits when merging?

@LionelCons I can.. if this is ready to be merged.

done


Publish multiple notes/assets in a single commit

https://www.npmjs.com/package/octokit-commit-multiple-files

Hope you will implement this as it could help with using vercel - it deploys site after every commit, so editing 10 notes now equals 10 deployments. Free vercel account (for hobbyists mainly) has a daily limit of 100 deployments, not to mentions it' slower.


Fix delete_repo in template

Currently the value doesn't match the model, so selecting it results in a 500.
https://github.com/go-gitea/gitea/blob/e8ac6a9aeacf0adf21982abc51baa8938e5dd6bb/models/auth/token_scope.go#L42

I also feel like this should be moved up nearer the other repo scopes.
Would anyone be opposed to a follow-up PR for that? (or I can do it in this one yet)

Can you give a bit of background/context here? Why _ instead of :?

Can you give a bit of background/context here? Why _ instead of :?

Ah, sorry. It has to match the model, otherwise selecting it ends up being a 500 error.
https://github.com/go-gitea/gitea/blob/e8ac6a9aeacf0adf21982abc51baa8938e5dd6bb/models/auth/token_scope.go#L42

🎺 🤖


Support compatibility keepachangelog  ## [1.1.1] - 2023-03-05

Need to change regex for [1.1.1] to enable if there is square brackets [ ] surrounding version, or not and also for surrounding [Unreleased]
https://keepachangelog.com/en/1.0.0/

Completed in commit: 8d1b06c and 97913d3


mod_header adds geo related variables

Codecov Report

Merging #236 into develop will decrease coverage by 0.06%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
- Coverage    52.98%   52.92%   -0.07%
===========================================
  Files          219      219
  Lines        21735    21760      +25
===========================================
  Hits         11517    11517
- Misses        8912     8937      +25
  Partials      1306     1306

Impacted Files
Coverage Δ

bfe_modules/mod_header/action_header_var.go
0% <0%> (ø)
:arrow_up:

bfe_http2/server.go
71.67% <0%> (ø)
:arrow_up:

bfe_websocket/server_conn.go
76.51% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcfcbf4...f70c68f. Read the comment docs.


Summa Explorer problem report

A problem has been reported with the page located at: http://ift.tt/1WZ2J9v

I don't see the problem here.


[FR] Make Price Range for Bill of Materials sum/multiply the Price range for components that are also assemblies and have components with part data

Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find a similar feature request

Problem statement
When building assemblies out of assemblies, the price data does not propagate up the levels.
Suggested solution
When an assembly is added as a component to another assembly, multiply the total price of the assembly's BOM by the quantity of that assembly being used in the higher assembly.
Describe alternatives you've considered
Another solution would be to not allow assemblies to be components of other assemblies, but that seems opposed to the purpose of inventree
Examples of other systems
No response
Do you want to develop this?

[ ] I want to develop this.

@realstudent01 you will have to provide an example here, but I think that the code is doing what it should be doing...
https://github.com/inventree/InvenTree/blob/58f60d18b6944934ec5db09f6fe0f68280a96a07/src/backend/InvenTree/part/models.py#L2044
    def get_bom_price_range(self, quantity=1, internal=False, purchase=False):
        """Return the price range of the BOM for this part.

        Adds the minimum price for all components in the BOM.
        Note: If the BOM contains items without pricing information,
        these items cannot be included in the BOM!
        """
        min_price = None
        max_price = None

        for item in self.get_bom_items().select_related('sub_part'):
            if item.sub_part.pk == self.pk:
                logger.warning('WARNING: BomItem ID %s contains itself in BOM', item.pk)
                continue

            q = decimal.Decimal(quantity)
            i = decimal.Decimal(item.quantity)

            prices = item.sub_part.get_price_range(
                q * i, internal=internal, purchase=purchase
            )

            if prices is None:
                continue

            low, high = prices

            if min_price is None:
                min_price = 0

            if max_price is None:
                max_price = 0

            min_price += low
            max_price += high

        if min_price is None or max_price is None:
            return None

        min_price = normalize(min_price)
        max_price = normalize(max_price)

        return (min_price, max_price)

The BOM pricing uses the quantity of the BOM line item to determine pricing. Is this not what you are asking for?

Say I have an assembly A made up of x, y, and z, where x, y, and z are each $5. So the BOM total of assembly A is $15.
Now if I make an assembly B that is made up of 2 of assembly A, the BOM total of assembly B should be $30... however currently the BOM total of B is showing as %0. I believe this is because A doesn't have a price specifically for it, but it is made up of things that do have prices.

Sorry, it appears that the issue is that you have to go into each layer of the nested BOMs, go to pricing, and click "Refresh". Is there a similar function to "Refresh" in the API so this can be sped up?

Updating the pricing for a part should automatically cause any assemblies that use that part to be updated too. Are you saying that this is not occuring?

Sort of. In order for the prices to propagate up through the nested BOMs I have I am having to go to the lowest level BOM (leaf node), click "Refresh" in the pricing tab, then go to the next lowest level BOM and hit "Refresh" in the pricing tab to have the data fill in.

Updating the pricing for a part should automatically cause any assemblies that use that part to be updated too. Are you saying that this is not occuring?

It occurs to me that the BOM list price is updated, but the part's overall pricing doesn't get updated automatically and need to fresh to get updated and thus it kind of breaks the link if the part is used as the BOM of another part

Yes, thank you @jesseyu1984918. Is there a way to force part overall price to update? Or make it so that overall pricing syncs with BOM list price (which would make sense that an assembly of x parts should be at least as expensive as those x parts by themselves).

@realstudent01 that should be happening automatically - I will need to look into why the pricing data is not flowing upstream properly.
Any further details you can provide would be helpful here!

Came here looking for this issue, it appears to be present in my Inventree install as well.  We have put together a multiple-level BOM, where each level consists of parts and assemblies down about 5 or 6 levels.  In order for the Pricing tab on the top-level part to show the correct price, we need to drill down to each sublevel and each subassembly and update it manually, they aren't rolling up automatically.

@realstudent01 what version of InvenTree are you running?

Ok, I think I have worked out what is going on - fix incoming in https://github.com/inventree/InvenTree/pull/8090

Will that fix get rolled into the next 15.x release or will we need to upgrade to 16.x to see it?

fixes are only released for the current version so you will have to upgrade to 0.16.1

Good to know, thanks.  I'll watch for it to be implemented before we look into that.


Ramiro Version of Makefile

Hi @RamiroMejia  I have incorporated changes of the README into my PR. For the makefile it should be aligned with my version too except the clean part.