istioctl: fix skip confirmation with dryrun while upgrading istio

Please provide a description of this PR:
I encounter bug behavior while executing istioctl upgrade with skip confirmation and dry-run in 1.9.7 and master branch.
./out/linux_amd64/istioctl upgrade --force --dry-run --skip-confirmation -f /root/infrastructure/community-ops/istio_mesh/cluster.yaml

.
.
Upgrade version check passed: 1.9.7 -> 1.12.0.
.
.
.

Confirm to proceed [y/N]? ^C

waitForConfirmation() function should not be depends on dryRun args. This PR removing the bad logic when calling waitForConfirmation().
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@zufardhiyaulhaq: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
1fe6a528721aa44576ffbd1b77890c0ab88cb3b7
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@zufardhiyaulhaq: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
1fe6a528721aa44576ffbd1b77890c0ab88cb3b7
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@zufardhiyaulhaq: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

integ-helm-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-helm-tests_istio

release-test_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

integ-helm-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-helm-tests_istio

release-test_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test release-test_istio

lint_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

integ-helm-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-helm-tests_istio

release-test_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test release-test_istio

lint_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test lint_istio

integ-cni-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

integ-helm-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-helm-tests_istio

release-test_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test release-test_istio

lint_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test lint_istio

integ-cni-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-cni-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-telemetry-mc-k8s-tests_istio

integ-distroless-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

integ-helm-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-helm-tests_istio

release-test_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test release-test_istio

lint_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test lint_istio

integ-cni-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-cni-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-telemetry-mc-k8s-tests_istio

integ-distroless-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

integ-helm-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-helm-tests_istio

release-test_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test release-test_istio

lint_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test lint_istio

integ-cni-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-cni-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-telemetry-mc-k8s-tests_istio

integ-distroless-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

integ-helm-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-helm-tests_istio

release-test_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test release-test_istio

lint_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test lint_istio

integ-cni-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-cni-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-telemetry-mc-k8s-tests_istio

integ-distroless-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-pilot-multicluster-tests_istio

integ-istiodremote-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-istiodremote-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

integ-helm-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-helm-tests_istio

release-test_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test release-test_istio

lint_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test lint_istio

integ-cni-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-cni-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-telemetry-mc-k8s-tests_istio

integ-distroless-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-pilot-multicluster-tests_istio

integ-istiodremote-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-istiodremote-k8s-tests_istio

integ-security-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

integ-helm-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-helm-tests_istio

release-test_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test release-test_istio

lint_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test lint_istio

integ-cni-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-cni-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-telemetry-mc-k8s-tests_istio

integ-distroless-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-pilot-multicluster-tests_istio

integ-istiodremote-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-istiodremote-k8s-tests_istio

integ-security-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

integ-helm-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-helm-tests_istio

release-test_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test release-test_istio

lint_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test lint_istio

integ-cni-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-cni-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-telemetry-mc-k8s-tests_istio

integ-distroless-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-pilot-multicluster-tests_istio

integ-istiodremote-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-istiodremote-k8s-tests_istio

integ-security-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

integ-helm-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-helm-tests_istio

release-test_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test release-test_istio

lint_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test lint_istio

integ-cni-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-cni-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-telemetry-mc-k8s-tests_istio

integ-distroless-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-pilot-multicluster-tests_istio

integ-istiodremote-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-istiodremote-k8s-tests_istio

integ-security-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-ipv6-k8s-tests_istio

gencheck_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

integ-helm-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-helm-tests_istio

release-test_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test release-test_istio

lint_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test lint_istio

integ-cni-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-cni-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-telemetry-mc-k8s-tests_istio

integ-distroless-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-pilot-multicluster-tests_istio

integ-istiodremote-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-istiodremote-k8s-tests_istio

integ-security-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-ipv6-k8s-tests_istio

gencheck_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

integ-helm-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-helm-tests_istio

release-test_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test release-test_istio

lint_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test lint_istio

integ-cni-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-cni-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-telemetry-mc-k8s-tests_istio

integ-distroless-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-pilot-multicluster-tests_istio

integ-istiodremote-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-istiodremote-k8s-tests_istio

integ-security-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-ipv6-k8s-tests_istio

gencheck_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test unit-tests_istio

integ-helm-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-helm-tests_istio

release-test_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test release-test_istio

lint_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test lint_istio

integ-cni-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-cni-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-telemetry-mc-k8s-tests_istio

integ-distroless-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-distroless-k8s-tests_istio

analyze-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-pilot-multicluster-tests_istio

integ-istiodremote-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-istiodremote-k8s-tests_istio

integ-security-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-ipv6-k8s-tests_istio

gencheck_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-pilot-k8s-tests_istio

integ-security-multicluster-tests_istio
fd56e854d1bee919d49ba4cbe5471fca61ec5baf
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn let me know if we can merge this. thanks!


could you provide assets with more markers?

Hi, thanks for the great work. I found the files in the assets folder only provide 64 markers, which remove the markers on the head. It is appreciated if you can provide markers with 96 points mentioned in the paper.
Thanks very much.

Hi, thanks for your interest.
More configs K=16, 32, 96 of the learned virtual markers can be found here.

@ShirleyMaxx, Thanks again for your help!


WIP: AUTH-482: set required-scc for openshift workloads

Description of the change:
This PR explicitly sets the required SCC to be used to admit pods of the catalogd-controller-manager deployments. The SCC chosen is the one that the pods are already getting admitted with, which means that this brings no change to the SCC used.
Motivation for the change:
In some cases, custom SCCs can have higher priority than default SCCs, which means that they will be chosen over the default ones. This can lead to unexpected results; in order to protect openshift workloads from this, we must explicitly pin the required SCC to all our workloads in order to make sure that the expected one will be used.

Could someone advise, should this be a <carry> or a <drop>?

It should be a <carry> to ensue that we carry this commit on the sync from upstream. <drop> commits get removed on sync.

/approve
/lgtm


Tabbar IndicatorStyle not working

I am reading through the Tabbar documentation and I can modify IndicatorStyle for bottom (the bottom line in tabbar). However, when I try to set that line on top of the tabbar, it does not work. Any ideas where to start looking for the remedy? Here is my code:
tabBarOptions: {
indicatorStyle: {
borderTopColor: '#000000',
borderTopWidth: 4
}
}

https://github.com/react-community/react-navigation/issues/504#issuecomment-282931627

Hi! In an effort to get the hundreds of issues on this repo under control I'm closing issues tagged as questions. Please don't take this personally - it's simply something we need to do to get the issues to a manageable point. If you still have a question I encourage you to re-read the docs, ask on StackOverflow, or ask on the #react-navigation Reactiflux channel. Thank you!


k8s reporter, Remove leftover mutex

Since parallel test execution is done in different processes,
we don't need to mutex anymore, its a leftover.
Signed-off-by: Or Shoval<EMAIL_ADDRESS>None

/lgtm
/approve

thanks
don't think its due to this PR, lets retest first
/retest

/retest
we might want to consider Quarantine some of those storage failures (or at least have some one to look if they are real bugs)
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/6073/pull-kubevirt-e2e-k8s-1.21-sig-storage/1417388686269485056
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/6073/pull-kubevirt-e2e-k8s-1.20-sig-storage/1417388687578107904


On Close, close background widgets and showing black screen

have a problem. When process ids done, and Progress Dialog need to close, it closes background widget, and showing black screen.
Please see attached image below.

Can you share the code so that I can understand how you use it?

I don't understand how you got the "done" message. Because according to your code you are not updating progress to max value anywhere

I think you are operating on the navigator before the dialog closes. That way the dialog stays open and you lose the back screen.

Hello sorry. I found the problem. Problem was in context. I'm creating dynamic context and set it to the ProgressDialog. When reading your sources and found, to problem will causes only if context is wrong.
Thank you for your support.
Have a nice day.

This is not a bug. Sorry.


[R] Create simple example of R HTTP GET Arrow client

Describe the enhancement requested
Contribute an R client example to the set of minimal HTTP GET examples in the arrow-experiments repo.
Component(s)
R

Completed in https://github.com/apache/arrow-experiments/pull/1


Unmuting now publish track if not already publishing

@chrisnyoder
There is problem with this PR.  In multichannel sample, if you Mute then Unmute Video.  You will get errors like this:

In main demo, you get errors:

@chrisnyoder  It seems ok after verifying the latest commit.  But the PR should be merged into dev/refactor4.  Can you make a PR again?


Add flag for stack yaml

Allows for smoother handling of projects with multiple stack.yaml files under different names, for example haskell-ide-engine.

Ah, I noticed this just after opening https://github.com/input-output-hk/stack2nix/pull/90 - you've missed one occurrence.

fixed with #90


The reserved indicator "@" cannot start a plain scalar

The reserved indicator "@" cannot start a plain scalar; you need to quote the scalar at line 9 (near "form: @/plugins/benfreke/menumanager/models/menu/fields.yaml").
/home/pooperpumper/public_html/vendor/symfony/yaml/Inline.php line 259

I am also receiving the same error. Kindly resolve this error as soon as possible. Thank you.

This can be easily by solved by ourselves (developer fix would be totally appreciated, though)
locating config_form.yaml and config_list.yaml
(at /benfreke/menumanager/controllers/menus/)
and replacing
@/plugins/benfreke/menumanager/
for
$/benfreke/menumanager/
Also, in Menus.php (at /benfreke/menumanager/controllers/), line 34:
$this->addJs('/plugins/benfreke/menumanager/assets/js/benfreke.menumanager.js');
for
$this->addJs('/benfreke/menumanager/assets/js/benfreke.menumanager.js');
and, on line 70:
$toolbarConfig->buttons =<EMAIL_ADDRESS>for
$toolbarConfig->buttons = '$/benfreke/menumanager/controllers/menus/_reorder_toolbar.htm';

@mrbohnke thx dude! it works

@mrbohnke perfect!

Hi @mrbohnke,
I have just tried reordering a menu and ran in to the following error:
Creating default object from empty value
/var/www/public/plugins/benfreke/menumanager/controllers/menus.php line 69
it is highlighting the line changed in menus.php:
$toolbarConfig->buttons = '$/benfreke/menumanager/controllers/menus/_reorder_toolbar.htm';
Any ideas how to resolve this?
Thanks

Never mind, I deleted a line by mistake.

I've merged some Pull Requests. They didn't have the change to the JS though, and when I load the backend the JS is still loaded correctly. I'm closing this as it appears to be fixed. If not, please re-open.
Thanks :)


Add config interface via web.

Add a simple interface via web to change things like the bot game, prefix, name, etc.

It should only be able to changes values in environment.rb ? Or is it possible to change $bot on the fly ? I'm not familiar with Discordrb. Should the interface be password protected ? Another issue should be opened on the matter of adding ssl support concerning the whole Sinatra.)
I think I can manage to make a little something.

Okay. Making the web interface is easy. But if I'm going to do it I'll have to know how to reload data. I assume setting the token and the client id should require complete bot reconnection. But I can reload the bot prefix on the fly right ?

Uhm, I don't think you need to reload the $bot variable at any point really, because the instance of the $bot just contains the Discorb instance.
If what you mean is that you wanna re-instantiate the bot with other token and client then ruby allows ovewriting global variables, so I don't think it would be an issue to re-instantiate it and overwriting the previos instance in the same variable.
All things regarding the web interface should be under the sinatra/ folder btw, ideally context separated, so if you're planning on making a dashboard then a folder for assets, views and other things would be needed.

Okay. For consistency I'll start by updating configatron entries and then I'll erase $bot with a new instance. Is there a method for safely disconnecting the bot ?

I finished the web interface pretty straight forwardly. And it updates the configatron entries. But then we'll have to agree on how to reload the bot.
$bot.stop
require_rel '../lib/discord.rb'

It is ugly but that's all I've found for now.

Do a PR so I can check the code.

I modified the code so that both web hooks app and web interface can run at the same time. (It didn't with my conf.) Should I commit that ?

I'm fixing that as well, check my next push to master when it happens.

I kept your idea, I just adjusted it a little bit so it's no so bulky.
You could also add some more fields there, like the bot name and the game it's playing.
Let me know if you're interested in future development, I could add you as a contributor if you're interested.
Thanks a lot!

I'm interested. I was waiting for an opportunity to practice on a project that is not mine.


Copilot - Copilot and regular account actions are displayed the same in #admins room

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/21246
Action Performed:
OldDot:

Create Control policy
Make changes in policy setting both under regular account and then co-pilot (or copilot and then regular account)
NewDot:
Verify there is visual difference between actions taken under regular account and copilot

Expected Result:
Regular account and copilot should be displayed differently.
Actual Result:
All actions taken by both accounts are displayed under the name who did first actions
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/2613adba-c822-4d56-b6c0-be0b1bda60c2
https://github.com/Expensify/App/assets/78819774/8ede2fb7-3bf1-45f5-9c9a-cc7072847ab8
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.

I was able to reproduce

The last message should be sent from a copilot account

When there are time gap between when the actual user and when the copilot edit the policies, the policy log message is sent from a correct person.
However, when the time is short, the the account of first person who make changes to the policy (actual user or copilot user) is used for subsequent messages.

I think these lines should not exists will test on my dev
https://github.com/Expensify/App/blob/50c16acc8365839d0de581701fcdb8811c2ee4eb/src/pages/home/report/ReportActionItemSingle.js#L85-L93

the above method didn't work.
I'm still investigating I gonna ask help on slack

still not working. When the copilot takes action, the policy change log message is shown as taken by the real user, not the copilot.

@yuwenmemon please disregard the screenshot above https://github.com/Expensify/App/issues/21970#issuecomment-1615264600
that is the effect from the code change I made in https://github.com/Expensify/App/issues/21970#issuecomment-1615224701

The fix for this was merged and Cp'd . Marking it off the checklist 👍

This does not need payment it was all internal


add a wiki reference for Mandelbrot set

add a wiki reference for Mandelbrot set

Can one of the admins verify this patch?

Can one of the admins verify this patch?


[DOCFIX] Update caching docs

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.4 please


[Request for External] Codeunit 80 "Sales-Post" - PostItemTrackingCheckReturnReceipt

Please make function PostItemTrackingCheckReturnReceipt externally available.
procedure PostItemTrackingCheckReturnReceipt(SalesLine: Record "Sales Line"; RemQtyToBeInvoiced: Decimal)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 41603.


Fix errors around collab settlement and rollover

There were multiple cases where we would stop trying to finish a protocol instead of appending a "failed" event.
See commits for details (and new tests).

I am not sure about the test that shows the rollover bug... I think we should rather have a failing test (and potentially ignore it, if you don't want to fix it here...).

I added the test as it fixes a concrete problem (that's why I wanted to keep it active) - the fact that it uncovered a different weirdness is orthogonal to this PR.

bors r+


Improvement: Support Shift + click to open project in same window

Regarding opening a project in the current window:
Shift + Enter is great for keyboard heavy users, but for those of us who rely on the mouse more it would be nice to have a "Shift + Left click" option to do the same

I'm open for a PR if you want to implement it yourself.


Facial Emotion Detection

🔴 Project Title: Facial Emotion Detection
🔴 Aim: Create a DL model which will detect the emotions from the facial activities.
🔴 Dataset: https://www.kaggle.com/datasets/mhantor/facial-expression
🔴 Approach: Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best-fitted algorithm for the model by checking the accuracy scores. Also do not forget to do an exploratory data analysis before creating any model.

assign me


Roll engine 77c3512ec85e..f456423cfb82 (4 commits)

git@github.com:flutter/engine.git/compare/77c3512ec85e...f456423cfb82
git log 77c3512ec85e..f456423cfb82 --no-merges --oneline
2019-11-14<EMAIL_ADDRESS>RendererContextSwitch guard flutter's gl context rework. (flutter/engine#13812)
2019-11-14<EMAIL_ADDRESS>Roll src/third_party/skia d860a78fd60c..e57ca4931952 (44 commits) (flutter/engine#13862)
2019-11-14<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from 7XOyl... to VMTIz... (flutter/engine#13861)
2019-11-14<EMAIL_ADDRESS>Roll src/third_party/dart dc35290111..dc808f3fcb (5 commits) (flutter/engine#13859)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/4756080260808704

Commit queue failed; closing this roll.


What happens if the reinstaller is halted by a restart?

Because the dataset status is not changed from ready-for-reinstall in the app db until the uninstall and reinstall succeed an unexpected shutdown will not prevent the reinstaller from seeing the dataset in the future.
Right now the worst case scenario is the shutdown happening during an ISA/BIOM reinstall after the uninstall succeeds but before the reinstall completes.  In this scenario, on next trigger the reinstaller will attempt to uninstall the dataset again but the plugin uninstall script will fail for the missing install manifest.


Remove Extra space Between boxes ?

What are you trying to achieve? Removing Extra Space Between two images.
Have you searched for similar questions? Yes
Are you able to provide a minimal, standalone code sample that demonstrates this question? No
Are you able to provide a sample image that helps explain the question? Yes

I am trying to Crop out set of boxes as a single card from a image. But the space between the boxes is more than i want.
This is the image.

After trimming there's no space at TBLR
I can crop out both of manually and join them with join-images package but the width of images are not always same.
So Manual extraction is not the way i think.
How can i remove the extra space between the cards ?

This is probably more of a general software question better suited to a site such as StackOverflow.


Best practices for your first sensenet ECM project

Create a summary for those who like to try sensenet ECM but don't want to read the whole wiki for quick hints.
Parts (examples):

installation
modules of the software
create a content library / workplace(?)
set up users (?)
manipulate the views of the content/site

this will be a summary/guide that links to multiple wiki sites (for more details).

Closed as obsolete.


Day 2: Gitflow

How clear is the material? What’s confusing?
A recap of the terminology would be useful towards the start. I appreciate this is coming off the back of the mechanics of git lesson but it comes into the tell them, tell them again, tell them what you told them repetition model and I know from past experience it was still not really clear at this stage in learning git what everything did.
The illustrations are very good and very helpful but either on the gitflow or the git mechanics lesson a plain language analogy of the processes of git would be helpful (wrapping presents putting them under a tree etc) I suspect it may be better placed on the mechanics of git but could equally be helpful here. ¿Por qué no los dos?
Are we assuming any knowledge that we shouldn’t be? Where should we add background info?
I think the only real assumption that is made across both of these sessions is that people already kind of have a working understanding of git and want to learn slightly more advanced under-the-hood mechanics a lot of our participants this will be their first exposure to version control at all.
How much time did it take you to complete the assignments?
10 minutes, again I suspect participants will take longer 15-30 minutes probably depending on their experience.

Thanks for the excellent suggestions! I implemented a bunch of these changes, and also moved the presentation from keynote to google slides. Check it out when you have a chance and let me know what you think!

Closing because I believe these comments were addressed, but please reopen if additional thoughts/suggestions!


allow graphql schema as an input on cli

fixes #93

Coverage decreased (-0.7%) to 95.674% when pulling 8eaf437730bf2be71e26cf6e985f0bc8aa4b7c6c on allow_graphql_schema_inputs into e5674e60aa6be967fe8a7048d9e41f928c6d0cd6 on master.

Coverage decreased (-0.7%) to 95.674% when pulling c9e04a1ed884936f97ff2412b4efc4f8a352b554 on allow_graphql_schema_inputs into 3248b6e916c3e4390d18ff8156d5d939c447c8d8 on master.

Checked out the branch, but not sure what to do to build. Do I need to run npm install in every package subfolder, and tsc? Do I need to install and run lerna? It would be great to have some contribution guides in the readme

@felixfbecker sorry, i'll add those. going to move to yarn workspaces, which should simplify things.
to build locally and install globally:
$ lerna bootstrap --hoist graphql
$ cd packages/cli
$ npm i -g .

And I assume npm i -g lerna?
Can I use npm link instead of npm i -g .?
It fails for me with
src/index.ts(9,3): error TS2305: Module '"/Users/felix/git/gql2ts/packages/cli/node_modules/@gql2ts/util/dist/index"' has no exported member 'safeJSONParse'.

that's strange...
i'll clone fresh and try to work through that, while writing a contribution guide.
in the meantime, can you try installing<EMAIL_ADDRESS>?

Seems to work fine! I think there is some help on this missing in the --help output though. Looking forward to see this merged

Coverage decreased (-0.7%) to 95.674% when pulling ce00ab03a99ebca9012413b6f9e9e255cb1db33f on allow_graphql_schema_inputs into 3248b6e916c3e4390d18ff8156d5d939c447c8d8 on master.

Coverage increased (+0.1%) to 96.506% when pulling a67b38c43b7f42fb43f3ca10b584769ae5518635 on allow_graphql_schema_inputs into 3248b6e916c3e4390d18ff8156d5d939c447c8d8 on master.

Is this missing anything from getting merged?

Nope

nice, could you cut a release?

@felixfbecker just released 1.3.0


Tweaks to Access Needs Page

When signing up for an engagement, if the user wants to update their access needs, there is no clear flow from access needs page back to the engagement page:

During engagement sign up process, on the page for confirming access needs, make the “Update access needs” link larger and bolder or turn it into a button (please check the site for this link, it's not reflected in the designs)

Design edits:
Confirm access needs is now two pages, each page having its own task:
https://www.figma.com/file/AXufBnFAVHvGdsxnQMVhNF/The-Accessibility-Exchange-Wireframes?node-id=6186%3A111433&t=UQ94RjcmmcGxyFuc-1

This page confirms ALL the user's access needs, regardless of whether they need further consent to attach the name to the access need for the FRO. The task on this page is for the user to confirm that this is their access needs, or edit it.
https://www.figma.com/file/AXufBnFAVHvGdsxnQMVhNF/The-Accessibility-Exchange-Wireframes?node-id=6186%3A110795&t=UQ94RjcmmcGxyFuc-1
If the user hits "edit", they are taken to this access needs page. The primary button copy below changes to reflect that after they hit it, they go back to the confirm access needs page.
https://www.figma.com/file/AXufBnFAVHvGdsxnQMVhNF/The-Accessibility-Exchange-Wireframes?node-id=6186%3A111650&t=UQ94RjcmmcGxyFuc-1
After the user confirms their access needs, then they're taken to this page to ask them to give consent for certain access needs to be shown beside their names. If they say yes, they go back to the engagement page with a success notification confirming. If they say no, the same thing happens except the service org also gets a notification to reach out to this user.

Wire frames for notification and admin page to managing access needs facilitated by the service.
https://www.figma.com/file/AXufBnFAVHvGdsxnQMVhNF/The-Accessibility-Exchange-Wireframes?node-id=6653%3A111081&t=0jdSn1jMm2xNGPew-1

Access needs that would require us to ask a user to share their identity with an FRO:

Follow up calls or emails
Bring my support person
Everything under the category "For engagement documents"
Additional needs or concerns - I would like to speak to someone to discuss additional needs or concerns

Copy for the notification e-mail should be the same as what is displayed in the system notification.

Access needs that would require us to ask a user to share their identity with an FRO:

Follow up calls or emails
Bring my support person
Everything under the category "For engagement documents"
Additional needs or concerns - I would like to speak to someone to discuss additional needs or concerns

@jobara

Thanks, I looked at the seeder and looks like it's already set up. There were some discrepancies with your list here and the seeder but we talked bout it and the seeder is correct.
https://github.com/accessibility-exchange/platform/blob/8ff1867c10657d529273b8995a683158ca69d3c7/database/seeders/AccessSupportSeeder.php

Updates to handle the case where access needs are updated after signing up for an engagement.

flow
design


The caret moves after ruff format when save on file

Describe the bug
When ruff format is enabled and ruff is set to run on save, the whole file seems to be reloaded by pycharm and the caret ends up in a different place than before (further down in the document).
To Reproduce
Steps to reproduce the behavior:

Enable ruff format
Enable run ruff when the python file is saved
Make a change in a python file and save
See the cursors jumps lower than in the document (the file should fill more than screen height)

Expected behavior
The cursor should be at the same place before and after ruff has been run
Environments (please complete the following information):

IDE: [Pycharm pro 2023.3]
OS: [Windows 11]
Ruff Version [0.1.7 ]
Plugin version [0.0.27 ]

@grundew
I'm sorry for my late reply.
I think we meet the same issue
We should fix it.
Thank you!!

@grundew
I have released the fixed version 0.0.29 .
Thank you very much!!

I am using 0.0.30 and still observing this defective behaviour, I'll raise a new issue


ERROR: Failed to import the TensorFlow module.

I was trying to install tensorflow-gpu. Using the tensorflow self check, it says all the required DLLs are present, but I still have an import error. I get the same error if I try to import numpy. There seems to be an issue with my conda command as well. Any help is greatly appreciated to resolve this issue. Thanks!
PS C:\Users\andrew\Documents> python tensorflow_self_check.py
ERROR: Failed to import the TensorFlow module.

Python version is 3.6.

TensorFlow is installed at: C:\Users\andre\Anaconda3\lib\site-packages\tensorflow

All required DLLs appear to be present. Please open an issue on the
TensorFlow GitHub page: https://github.com/tensorflow/tensorflow/issues

PS C:\Users\andrew\Documents> conda create -n tensorflow_gpu python=3.6
usage: conda [-h]
{keygen,sign,unsign,verify,unpack,install,install-scripts,convert,version,help}
...
conda: error: invalid choice: 'create' (choose from 'keygen', 'sign', 'unsign', 'verify', 'unpack', 'install', 'install-
scripts', 'convert', 'version', 'help')

Please provide details about what platform you are using  (operating system, architecture). Also include your TensorFlow version. Also, did you compile from source or install a binary?  Make sure you also include the exact command if possible to produce  the output included in your test case. If you are unclear what to include  see the issue template displayed in  the Github new issue template.
We ask for this in the issue submission template, because    it is really difficult to help without that information. Thanks!

I apologize but I am having a hard time understanding what the problem is, where the problem is, and what version it affects. Please resubmit and pay attention to the issue template (https://github.com/tensorflow/tensorflow/issues/new) . Please provide all the information it asks. Thank you.


get_open_orders

Hi , someone know how to have the real value of "limit"
when i send for example my_bittrex.get_open_orders('btc-xvg')
the limit is showing bad result 'Limit': 1e-05
other test with get_order_history() the limit answwer correctly

It's not a bad result, it's python output using a mathematic shorthand instead of putting 0.00001 it is making it 1e-05 which is same.


change for django 1.6+

i changed manage.py so as for those who are using django 1.5+ can run the example project.
because unless you get error that you cant import name execute_manager.  because execute_manage was deprecated after django 1.4 (https://docs.djangoproject.com/en/1.4/internals/deprecation/#id3) and  execute_from_command_line() took place.

+1 for that.


Is elasticsearch inside docker accessible?

Or use external elasticsearch

Yes, the image exposes port 9200 (https://github.com/exceptionless/Exceptionless/blob/master/Dockerfile#L109) but we recommend not exposing it publicly and for production instances to run an elasticsearch cluster.


[SSE-42, SSE-43] install ros in env, update dependecies

@f-eisele we (moritz and me) think now everything is adressed. So pls Merge :-)


sink(ticdc): add compression for avro test

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tiflow/issues/5928
What is changed and how it works?
add compression for avro test.
Check List
Tests

Integration test

Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note
None

/merge


Add tag

pficommon currently uses branch based versioning.
But, adding tag is helpful for some package manages like dep and rpm.
So, we should add a versioning tag at each release.

Thanks for adding a tag!
Let's keep this style :)


Config reloading feature

Currently working on it. Hope to have the following features when a SIG_HUP is caught:

"allowed hosts" map reloading (need this since we change/add hosts frequently)
Backend switching, ie. detect if backend config changed, close old backend and spawn a new one
detect if SSL cert changed and reload it (useful since letsencrypt certs expire every few months, so our server would need to reload the ssl certs once per day at least)
Listening interface changes. Detect if interface changed. If changed, shutdown old server(s) and start a new one(s) (Not really needed feature, may leave for later)
Close and re-open log files. (Need this for logrotate)

That way the server can continue working without disrupting the hundreds of connections it may have open.
Going to implement it using an event based approach using https://github.com/asaskevich/EventBus

Since the config can change, another thing to take into account would be thread safety. This should be in handy https://golang.org/pkg/sync/atomic/#example_Value_config

To make it easier, old connections will still use existing config. Subsequent new connections will use the new config.

First draft https://github.com/flashmob/go-guerrilla/pull/19


1milliondocuments

contains AI-enriched documents from Blob Storage (10k PDFs and 90k articles).
This acclerator is already working with 10k pdf and 90k documents , is it supportive on 1 million documents, please cofirm would proceed

The amount of documents it accepts and index has to do with the Azure Cog Search SKU you are using. You will need a bigger Azure Cognitive Search SKU and more replicas and search units so you can ingest 1MM files


Docker Hub gives "invalid repo" when trying to link a repo

Docker Hub gives "invalid repo" when trying to link a repo.
Failed to load resource: the server responded with a status of 404 (NOT FOUND)
https://registry.hub.docker.com/u/adamkdean/node-libvips/settings/links/

I've tried reponame, username/reponame, and username/reponame:tag, reponame:tag ...

Hi!
If you are reporting a new issue, PLEASE make sure that does not have any duplicates already open.
We would like to take this time to remind you of the information we need to debug the problem you are seeing. This is an automated response so if this ticket is not about a bug, do not fret.
If you fail to provide this information within 7 days, we will close this because we cannot debug your issue. We can reopen whenever the information is provided.
Thank you.
Please see:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues
Description of problem:

`docker version`:

`docker info`:

`uname -a`:

Environment details (AWS, VirtualBox, physical, etc.):

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual Results:

Expected Results:

Additional info:

#ENEEDMOREINFO

Hi GordonTheTurtle, I assume you are a bot?
I could not find an issue already relating to this, and it's not on my machine so the other commands are not required. Everything has already been provided. Please take this information to your overlords.
Thanks.
P.S. when I enable the button manually, I get POST https://registry.hub.docker.com/u/adamkdean/node-libvips/settings/links/ 404 (NOT FOUND)

This does work with other images, for example, phusion/baseimage works fine.

Hi, can you send this to<EMAIL_ADDRESS>Thanks!

WTF ... and what is the solution? I have the same situation on my automatics builds.

@silvio all dockerhub related things ought to go to<EMAIL_ADDRESS>

@silvio issues related to Docker Hub are not handled in this issue tracker, but handled via<EMAIL_ADDRESS>


Understand IllegalStateException in Travis build

In build https://travis-ci.org/snowplow/iglu-scala-client/jobs/81756147
[error] ! a Resolver should report its failed lookups when a JSON Schema can't be resolved
[error]   IllegalStateException: Entry.next=null, data[removeIndex]=iglu:com.snowplowanalytics.self-desc/instance-iglu-only/jsonschema/1-0-0=Success({"$schema":"http://iglucentral.com/schemas/com.snowplowanalytics.self-desc/schema/jsonschema/1-0-0#","description":"Top-level schema for the validation process (Iglu-only)","self":{"vendor":"com.snowplowanalytics.self-desc","name":"instance-iglu-only","format":"jsonschema","version":"1-0-0"},"type":"object","properties":{"schema":{"type":"string","pattern":"^iglu:[a-zA-Z0-9-_.]+/[a-zA-Z0-9-_]+/[a-zA-Z0-9-_]+/[0-9]+-[0-9]+-[0-9]+$"},"data":{}},"required":["schema","data"],"additionalProperties":false}) previous=iglu:com.snowplowanalytics.self-desc/instance-iglu-only/jsonschema/1-0-0=Success({"$schema":"http://iglucentral.com/schemas/com.snowplowanalytics.self-desc/schema/jsonschema/1-0-0#","description":"Top-level schema for the validation process (Iglu-only)","self":{"vendor":"com.snowplowanalytics.self-desc","name":"instance-iglu-only","format":"jsonschema","version":"1-0-0"},"type":"object","properties":{"schema":{"type":"string","pattern":"^iglu:[a-zA-Z0-9-_.]+/[a-zA-Z0-9-_]+/[a-zA-Z0-9-_]+/[0-9]+-[0-9]+-[0-9]+$"},"data":{}},"required":["schema","data"],"additionalProperties":false}) key=iglu:com.acme.icarus/wing/jsonschema/1-0-0 value=Failure(NonEmptyList(error: Could not find schema with key iglu:com.acme.icarus/wing/jsonschema/1-0-0 in any repository, tried:
[error]     level: "error"
[error]     repositories: ["Iglu Test Embedded [embedded]","Iglu Client Embedded [embedded]"]
[error] )) size=10 maxSize=10 Please check that your keys are immutable, and that you have used synchronization properly. If so, then please report this to<EMAIL_ADDRESS>as a bug. (LRUMap.java:301)
[error] org.apache.commons.collections.map.LRUMap.reuseMapping(LRUMap.java:301)
[error] org.apache.commons.collections.map.LRUMap.addMapping(LRUMap.java:267)
[error] org.apache.commons.collections.map.AbstractHashedMap.put(AbstractHashedMap.java:284)
[error] com.snowplowanalytics.iglu.client.Resolver$cache$$anonfun$store$1.apply(Resolver.scala:198)
[error] com.snowplowanalytics.iglu.client.Resolver$cache$$anonfun$store$1.apply(Resolver.scala:197)
[error] com.snowplowanalytics.iglu.client.Resolver$cache$.store(Resolver.scala:197)
[error] com.snowplowanalytics.iglu.client.Resolver.recurse$1(Resolver.scala:234)
[error] com.snowplowanalytics.iglu.client.Resolver.lookupSchema(Resolver.scala:247)
[error] com.snowplowanalytics.iglu.client.ResolverSpec.e3(ResolverSpec.scala:131)
[error] com.snowplowanalytics.iglu.client.ResolverSpec$$anonfun$is$1$$anonfun$apply$1$$anonfun$apply$7.apply(ResolverSpec.scala:72)
[error] com.snowplowanalytics.iglu.client.ResolverSpec$$anonfun$is$1$$anonfun$apply$1$$anonfun$apply$7.apply(ResolverSpec.scala:72)

sbt runs tests in parallel, so multiple threads can simultaneously access the TestResolver here and so simultaneously access its LRUCache, which is not thread-safe.

This would be resolved by #28 but for now we can just create a new TestResolver whenever we need it.

Actually, parallel execution in tests seems to be set to false here.
    parallelExecution in Test := false, // Parallel tests cause havoc with LRU cache

I don't know what else could have gone wrong - the keys are definitely immutable.

Pushing back...


[Snyk] Fix for 1 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `rubygems` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

Gemfile

⚠ Warning
Failed to update the Gemfile.lock, please update manually before merging.

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

616/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.9
Web Cache Poisoning SNYK-RUBY-RACK-1061917
No
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Another awesome 'fix' from Snyk.. Rack has a webcache issue, so we've changed 11 lines of your Gemfile, none of them rack, and not run bundle install 🤦♂

It looks like patching is only supported for Node.js, so perhaps we can turn this off?

Tempted to set this to never

They can email me with 'vulnerabilities' but we can continue to use dependabot to actually fix them!


fix: provide doc_ids as a list

Fixes #138
Checklist

[x] Ensure PR title matches the conventional commits format.

CodiumAI Agent Commands
As required run the following CodiumAI Agent commands:

Request PR review using @CodiumAI-Agent /review (and if required, request an incremental update with @CodiumAI-Agent /review -i)
Request PR improvement suggestions with @CodiumAI-Agent /improve --extended
Request PR update using @CodiumAI-Agent /describe

@CodiumAI-Agent /review

PR Analysis

🎯 Main theme: The main theme of this PR is to fix a bug related to the removal of document IDs from a match list.
📝 PR summary: This PR addresses issue #138 by changing the way document IDs are removed from the 'matches' list in the 'sync_project' function. Instead of directly removing the document ID, it is now passed as a list to the 'remove' method.
📌 Type of PR: Bug fix
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 1
This PR is quite small and straightforward, making it easy to review. The change is limited to a single line of code and the purpose of the change is clear.
🔒 Security concerns: No

PR Feedback

💡 General suggestions: The change made in this PR seems to be straightforward and aligns with the Python best practices. However, it would be beneficial to add tests to ensure the correct functionality of the updated code.

 🤖 Code feedback:

relevant file: ado_asana_sync/sync/sync.py
suggestion: It's a good practice to check if the document ID exists in the list before trying to remove it. This can prevent potential ValueErrors from being raised. [important]
relevant line: app.matches.remove(doc_ids=[wi.doc_id])

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.


"libRecommender" Image not found error

I'm trying to use libRecommender with Xcode 10 (beta 2). I get the following error:
dyld: Library not loaded: @rpath/libRecommender.dylib
  Referenced from: /Users/tanmaybakshi/Library/Developer/Xcode/DerivedData/Recommender-arngafrvnniyxzdukcnbytnuedeb/Build/Products/Debug/Recommender
  Reason: image not found

I followed the steps exactly how they are in the user guide.
Thanks.

I think we may be missing a step in the user guide. The dylib needs to be copied into the resulting app bundle, as well as linked against in the framework. I suspect this is not on by default when dragging a dylib into an Xcode project.

Got it. Any estimate as to when the user guide would be fixed? Thanks. Would love to help out in any way as well.

@tanmayb123 I am looking into this today and should have an update later today. Thanks for your patience.

Thank you very much.
There is one more error I'm experiencing:
ld: '/Users/tanmaybakshi/Desktop/Development/MovieRecommendation/tMovieReciOS/tMovieReciOS/libRecommender-arm64.dylib' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. file '/Users/tanmaybakshi/Desktop/Development/MovieRecommendation/tMovieReciOS/tMovieReciOS/libRecommender-arm64.dylib' for architecture arm64
This occurs when I create a fresh new project in Xcode 10 beta 2 on macOS Mojave beta 3, drag in the mlmodel & dylib, and run on my iPhone X running iOS 12 beta 3.
Should I open a new issue for it?

@tanmayb123 Yes, please open a new issue for that one. I think that is a separate issue. In the meantime you should be able to work around it by disabling bitcode for your project (though bitcode has lots of advantages, so we should fix that issue on our end so you can reenable it).

Sure, thanks. I'll do that shortly.

@shantanuchhabra Assigning to you, per our conversation.

Really sorry for asking again - I understand you're busy. It's just that I'm working on a code pattern with IBM, and can't use CoreML until the issue is fixed. I need to use an HTTP backend. Thanks :)

@tanmayb123 One update on this: so far we've discovered that renaming the dylib files after they are built doesn't work (the old name is stored somewhere inside, and is what the app ends up looking for). So please rename libRecommender-arm64.dylib or libRecommender-x86_64.dylib to just libRecommender.dylib in your project, as that's what it will be looking for.
That should solve the image not found issue, but we're seeing other issues now once we get past that, so I'm debugging and hopefully will have a fix soon. Thanks for your patience!

The other issue we ran into was #832 - a fix is in the works and will come out with the next release. In the meantime, if you are running into runtime errors due to int item IDs, try using string item IDs instead when you train the model, and the exported model should work with string item IDs.
I'll leave this issue open until the dylibs get renamed properly during our release process. In the meantime, you'll want to rename the dylib you use to libRecommender.dylib before proceeding with the user guide instructions.

Thanks for the update and for letting me know about the other issue. I'm going to go ahead and add this into my app.

This should be fixed by #778 and https://github.com/apple/coremltools/pull/207

@shantanuchhabra I don't think this is fixed with those changes. There is a separate issue here - our documentation doesn't reflect the fact that when dragging in the libRecommender.dylib, a few things need to happen to make it work:

Users currently need to rename from our arch-specific filenames to libRecommender.dylib before including it in the Xcode project (though the better fix vs. updating docs would be for us to ship a file named libRecommender.dylib for each architecture, rather than requiring the user to rename it).
Make sure the dylib is in "copy to bundle" (update our docs)
Make sure the dylib is in "linked frameworks" (update our docs)

Added the necessary documentation as per #886. Will keep this issue open until we release a new version with different libRecommenders.

We just released Turi Create 5.0 beta 3, you can find the wheels on the release page. there are two separate libRecommender.dylib files, one for each architecture (x86_64 and arm64), zipped up into libRecommender.zip.

@shantanuchhabra Wouldn't it be possible to ship a fat binary?

@insidegui Yep, we're tracking that here: 834


Assignment to 'any'

Also some indentation fixed.

Did this get merged or is that still in your branch's work?

This is still in my branch. This PR is no longer valid as I'm making changes based on your yesterday's branch.

got it. thanks!


Charge caching doesn't check atom ordering

Description
I expect charges to get assigned differently for different atom orders. However, atom re-ordering is ignored when re-generating charges. I haven't looked very deeply into this but I assume the atom order is not getting taken into account in any equality check with caching (perhaps graph isomorphism?)
Reproduction
Please include a minimally reproducing example of this bug.
from openff.toolkit import Molecule, ForceField
sage = ForceField("openff-2.1.0.offxml")
mol1 = Molecule.from_mapped_smiles("[H:3]-[C:1]#[N:2]")
mol2 = Molecule.from_mapped_smiles("[H:1]-[C:2]#[N:3]")
interchange1 = sage.create_interchange(mol1.to_topology())
interchange1.collections["Electrostatics"].charges

{TopologyKey with atom indices (0,): 0.1906999945640564 <Unit('elementary_charge')>,
 TopologyKey with atom indices (1,): -0.372079998254776 <Unit('elementary_charge')>,
 TopologyKey with atom indices (2,): 0.1813800036907196 <Unit('elementary_charge')>}

When I create a different interchange, the charges still remain the same -- perhaps from the _compute_partial_charges class method --
interchange2 = sage.create_interchange(mol2.to_topology())
interchange2.collections["Electrostatics"].charges

{TopologyKey with atom indices (0,): 0.1906999945640564 <Unit('elementary_charge')>,
 TopologyKey with atom indices (1,): -0.372079998254776 <Unit('elementary_charge')>,
 TopologyKey with atom indices (2,): 0.1813800036907196 <Unit('elementary_charge')>}

The correct charges should be:
mol2.assign_partial_charges("am1bccelf10")
mol2.partial_charges

[0.18139000236988068 0.19068999588489532 -0.372079998254776]

Output
Please include the output, including full tracebacks of any errors, resulting from the reproduction.
Software versions

Which operating system and version are you using?
How did you install Interchange?
What is the output of running conda list

  Name                     Version    Build         Channel
─────────────────────────────────────────────────────────────────
  openff-amber-ff-ports    0.0.3      pyh6c4a22f_0  conda-forge
  openff-forcefields       2023.08.0  pyh1a96a4e_0  conda-forge
  openff-interchange       0.3.17     pyhd8ed1ab_1  conda-forge
  openff-interchange-base  0.3.17     pyhd8ed1ab_1  conda-forge
  openff-models            0.1.1      pyhca7485f_0  conda-forge
  openff-nagl              0.3.1      pyhd8ed1ab_1  conda-forge
  openff-nagl-base         0.3.1      pyhd8ed1ab_1  conda-forge
  openff-nagl-models       0.1.0      pyhd8ed1ab_0  conda-forge
  openff-toolkit           0.14.4     pyhd8ed1ab_1  conda-forge
  openff-toolkit-base      0.14.4     pyhd8ed1ab_1  conda-forge
  openff-units             0.2.1      pyh1a96a4e_0  conda-forge
  openff-utilities         0.1.11     pyhd8ed1ab_0  conda-forge

Short answer before I'm able to dig into this more deeply - the caching is not deeply designed and you're probably running into a genuine issue.

Unfortunately I can't blame Omega for this, whether or not there are quirks in its partial atom ordering. I can reproduce this (modulo ELF10) without OEChem installed:
In [1]: from openff.toolkit import Molecule, ForceField
   ...: sage = ForceField("openff-2.1.0.offxml")
   ...: mol1 = Molecule.from_mapped_smiles("[H:3]-[C:1]#[N:2]")
   ...: mol2 = Molecule.from_mapped_smiles("[H:1]-[C:2]#[N:3]")
   ...: interchange1 = sage.create_interchange(mol1.to_topology())
   ...: interchange1.collections["Electrostatics"].charges

Out[1]:
{TopologyKey with atom indices (0,): 0.1903 <Unit('elementary_charge')>,
 TopologyKey with atom indices (1,): -0.3718 <Unit('elementary_charge')>,
 TopologyKey with atom indices (2,): 0.1815 <Unit('elementary_charge')>}

In [2]: interchange2 = sage.create_interchange(mol2.to_topology())
   ...: interchange2.collections["Electrostatics"].charges
Out[2]:
{TopologyKey with atom indices (0,): 0.1903 <Unit('elementary_charge')>,
 TopologyKey with atom indices (1,): -0.3718 <Unit('elementary_charge')>,
 TopologyKey with atom indices (2,): 0.1815 <Unit('elementary_charge')>}

In [3]: mol2.assign_partial_charges("am1bcc")
   ...: mol2.partial_charges
Out[3]: array([ 0.1815,  0.1903, -0.3718]) <Unit('elementary_charge')>

In [4]: mol1.to_smiles(mapped=True), mol2.to_smiles(mapped=True)
Out[4]: ('[C:1](#[N:2])[H:3]', '[H:1][C:2]#[N:3]')

In [5]: mol1.assign_partial_charges("am1bcc")
   ...: mol1.partial_charges
Out[5]: array([ 0.1903, -0.3718,  0.1815]) <Unit('elementary_charge')>

I'm not sure it's caching per se, in the sense that sage.create_interchange(mol2.to_topology()) should not have information about mol1 and its ordering. Probably some re-ordering is happening internally, or in an interaction with an external call. Here I'm guessing that mol1's atom ordering is preferred by some defaults somewhere, and mol2 happens to get re-ordered there at some point. This is where I'll start looking.

Through my winding road of ForceBalance debugging, I did verify that swapping the order of mol2 and mol1 means that mol1 winds up with mol2's charges, if that helps. Turns out I can't look at the cache itself for thread safety reasons, but running the below code still gives me mol1 charges for mol2, even though mol2 has not yet been seen by Interchange and its charges shouldn't have been computed and cached yet:
from openff.toolkit import Molecule, ForceField
sage = ForceField("openff-2.1.0.offxml")
mol1 = Molecule.from_mapped_smiles("[H:3]-[C:1]#[N:2]")
mol2 = Molecule.from_mapped_smiles("[H:1]-[C:2]#[N:3]")
interchange1 = sage.create_interchange(mol1.to_topology())
elec = openff.interchange.smirnoff._nonbonded.SMIRNOFFElectrostaticsCollection
elec._compute_partial_charges(mol1, "am1bccelf10")

[0.1906999945640564 -0.372079998254776 0.1813800036907196]

elec._compute_partial_charges(mol2, "am1bccelf10")

[0.1906999945640564 -0.372079998254776 0.1813800036907196]

If I ask _compute_partial_charges for a different charge method, i.e. something guaranteed not to be in the cache, the order of the atom charges looks more correct:
elec._compute_partial_charges(mol2, "am1bcc")

[0.18139000236988068 0.19068999588489532 -0.372079998254776]

The cache you're referring to - is this the cache in ForceBalance or the "cache" emerging from key mappings in Interchange?

I'm referring to caching in the classmethod in Interchange:
https://github.com/openforcefield/openff-interchange/blob/db845ef0adc730c1e2be814359a23c8774ee52d1/openff/interchange/smirnoff/_nonbonded.py#L457-L465

Ahhhh ... I forgot about that. That makes sense, thanks.

I was wondering if the caching was worth it, and if there could be a workaround. Using mapped smiles as a hash key would get around this I think, and is only a step up from the current (surprisingly generic) hash method of a FrozenMolecule:
https://github.com/openforcefield/openff-toolkit/blob/779565b8e5b676e3a194d15af429a89ca0fbfa5c/openff/toolkit/topology/molecule.py#L1189
import functools

@functools.lru_cache(None)
def _compute_partial_charges_from_smiles(mapped_smiles: str, method: str):
    molecule = Molecule.from_mapped_smiles(mapped_smiles, allow_undefined_stereo=True)
    molecule.assign_partial_charges(method)
    return molecule.partial_charges

def _compute_partial_charges(molecule, method: str):
    return _compute_partial_charges_from_smiles(molecule.to_smiles(mapped=True), method)

def _noncached_compute_partial_charges(molecule, method: str):
    molecule = copy.deepcopy(molecule)
    molecule.assign_partial_charges(method)
    return molecule.partial_charges

I ran some very informal timings with all the caveats of running in a Jupyter notebook on a computer with other processes going on. There may be quite some overhead to setting up the functools cache since invariably the first call takes quite a while.
%timeit _compute_partial_charges(mol1, "am1bccelf10")
The slowest run took 11.35 times longer than the fastest. This could mean that an intermediate result is being cached.
4.57 µs ± 6.2 µs per loop (mean ± std. dev. of 7 runs, 1 loop each)

Weirdly computing for the first time and pulling existing charges out takes about the same amount of time -- converting to/from SMILES probably adds a good amount of overhead.
%timeit _compute_partial_charges(mol2, "am1bccelf10")
1.55 µs ± 13.1 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops each)
%timeit _compute_partial_charges(mol1, "am1bccelf10")
1.54 µs ± 17.9 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops each)

Just not caching at all is an option too, but it does take some time to compute charges each time:
%timeit _noncached_compute_partial_charges(mol1, "am1bccelf10")
122 ms ± 1.98 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)
%timeit _noncached_compute_partial_charges(mol2, "am1bccelf10")
123 ms ± 3.51 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)

There's lots to think about here ... I think the bare minimum solution here fixes the MWE you tidied up, but it would also be nice to keep things like performance scaling with number of similar (for some definition of "similar") molecules in check. This caching may stem from an earlier version of Interchange that didn't have the same access to the toolkit's Topology.unique_molecules functionality that exists today.

the current (surprisingly generic) hash method of a FrozenMolecule

I wonder if it's worth pitching a change into the toolkit itself. Are two molecules "equal" if their atoms are in different order? Hard to say. Notably Molecule.__eq__ also has some (different) magic built-in.

Weirdly computing for the first time and pulling existing charges out takes about the same amount of time

I have to wonder if this is just a feature of this molecule being small - SMILES conversion probably scales linearly with number of atoms or a bit slower, and it could probably be further optimized since the underlying toolkits probably get much more information than they need.

I think simply caching with CMILES fixes your MWE?
diff --git a/openff/interchange/smirnoff/_nonbonded.py b/openff/interchange/smirnoff/_nonbonded.py
index ff56558b..97596b5c 100644
--- a/openff/interchange/smirnoff/_nonbonded.py
+++ b/openff/interchange/smirnoff/_nonbonded.py
@@ -456,7 +456,12 @@ class SMIRNOFFElectrostaticsCollection(ElectrostaticsCollection, SMIRNOFFCollect

     @classmethod
     @functools.lru_cache(None)
-    def _compute_partial_charges(cls, molecule: Molecule, method: str) -> "Quantity":
+    def _compute_partial_charges(
+        cls,
+        molecule: Molecule,
+        mapped_smiles: str,
+        method: str,
+    ) -> "Quantity":
         """Call out to the toolkit's toolkit wrappers to generate partial charges."""
         molecule = copy.deepcopy(molecule)
         molecule.assign_partial_charges(method)
@@ -646,6 +651,11 @@ class SMIRNOFFElectrostaticsCollection(ElectrostaticsCollection, SMIRNOFFCollect

         partial_charges = cls._compute_partial_charges(
             unique_molecule,
+            unique_molecule.to_smiles(
+                isomeric=True,
+                explicit_hydrogens=True,
+                mapped=True,
+            ),
             method=partial_charge_method,
         )

In [1]: from openff.toolkit import Molecule, ForceField
   ...:
   ...: sage = ForceField("openff-2.1.0.offxml")
   ...: mol1 = Molecule.from_mapped_smiles("[H:3]-[C:1]#[N:2]")
   ...: mol2 = Molecule.from_mapped_smiles("[H:1]-[C:2]#[N:3]")
   ...: interchange1 = sage.create_interchange(mol1.to_topology())
   ...: interchange1.collections["Electrostatics"].charges
/Users/mattthompson/mambaforge/envs/openff-interchange-dev/lib/python3.11/site-packages/smirnoff99frosst/smirnoff99frosst.py:11: UserWarning: Module openff was already imported from None, but /Users/mattthompson/software/openff-interchange is being added to sys.path
  from pkg_resources import resource_filename

Out[1]:
{TopologyKey with atom indices (0,): 0.1906999945640564 <Unit('elementary_charge')>,
 TopologyKey with atom indices (1,): -0.372079998254776 <Unit('elementary_charge')>,
 TopologyKey with atom indices (2,): 0.1813800036907196 <Unit('elementary_charge')>}

In [2]: sage.create_interchange(mol2.to_topology())["Electrostatics"].charges
Out[2]:
{TopologyKey with atom indices (0,): 0.18139000236988068 <Unit('elementary_charge')>,
 TopologyKey with atom indices (1,): 0.19068999588489532 <Unit('elementary_charge')>,
 TopologyKey with atom indices (2,): -0.372079998254776 <Unit('elementary_charge')>}

I grant this is more of a band-aid than a fundamental fix, but the chain of logic seems sound. (1. CMILES uniquely represent molecules in terms of how the toolkit might assign different charges; 2. caching is okay as long as the hash does this sort of uniquifying.) Any sort of test cases I'm not imagining?

Perfect, that's pretty much the exact solution I had in mind!

I have to wonder if this is just a feature of this molecule being small - SMILES conversion probably scales linearly with number of atoms or a bit slower, and it could probably be further optimized since the underlying toolkits probably get much more information than they need.

Ah yes you're totally right here -- rerunning the timings above with a larger molecule (57 atoms) does start differentiating between computing charges the first time and pulling charges from the cache.
Interestingly, deepcopying is reliably somewhat slower than re-creating from SMILES, but I agree with your approach to keep deepcopying to avoid possible errors during conversion to/from SMILES.

I believe this is fixed in 0.3.18, which is now online. I'll leave his open for a bit to ensure that's the case, and if we want to split off some of the ideas we discussed above.

I understand this to now be resolved, and future improvements might land in the toolkit

Added context: This bug was likely introduced in this^1 commit which appears to be included in 0.3.3. Likely, 0.3.3-0.3.17 were affected. No released force field is known to be affected by this bug; Sage 2.1 used much older APIs^2 that predate the change that caused this bug.

I might be facing a similar issue with caching - not atom ordering, just caching - that's resulting in leaky tests: https://github.com/openforcefield/openff-interchange/actions/runs/11184054749/job/31094000581
Since the logs are ephemeral, the gist is that I have adjacent tests looking at different molecules. One looks at (TIP4P) water, the other looks at carbon tetrachloride with sigma hole parameters. In some cases (not all CI, and not locally), virtual sites from one test leak into the other. This is hard to pin down but I suspect something is going on with the cache somehow leaking into different instances of SMIRNOFFElectrostaticsCollection._charges. Tests run in parallel so the same test might be run on the same thread, but I'm still confused as to why the thing isn't re-created every time a new Interchange is made.
There was a change here that fixed some other stuff (and passed all tests) which might be related.: https://github.com/openforcefield/openff-interchange/pull/1069/files
Possibly there needs to be a dict.clear() or something to ensure it's not simply updating new key-val pairs on top of an existing cache, though that completely fails to explain why the cache already existed! Notably, the leaking tests only include virtual sites and charge_from_molecules, each of which was covered in many tests before.


Housekeeping

I'm aware we don't use proguard right now, but we probably should at some point

:+1:


strongswan status exit code 3, even when "security associations" is up, duplicate SAs

[nmanos@nmanos ocp-install]$ oc exec submariner-gateway-d4t87 bash -ti -n submariner-operator
strongswan statusall

Status of IKE charon daemon (strongSwan 5.8.2, Linux 4.18.0-147.3.1.el8_1.x86_64, x86_64):
  uptime: 17 hours, since Feb 19 16:24:07 2020
  malloc: sbrk 3313664, mmap 0, used 2204688, free 1108976
  worker threads: 11 of 16 idle, 5/0/0/0 working, job queue: 0/0/0/0, scheduled: 4
  loaded plugins: charon pkcs11 tpm aesni aes des rc2 sha2 sha1 md4 md5 mgf1 random nonce x509 revocation constraints acert pubkey pkcs1 pkcs7 pkcs8 pkcs12 pgp dnskey sshkey pem openssl gcrypt fips-prf gmp curve25519 chapoly xcbc cmac hmac ctr ccm gcm drbg curl attr kernel-netlink resolve socket-default farp stroke vici updown eap-identity eap-sim eap-aka eap-aka-3gpp eap-aka-3gpp2 eap-md5 eap-gtc eap-mschapv2 eap-dynamic eap-radius eap-tls eap-ttls eap-peap xauth-generic xauth-eap xauth-pam xauth-noauth dhcp led duplicheck unity counters
Listening IP addresses:
  <IP_ADDRESS>
  <IP_ADDRESS>
  <IP_ADDRESS>
Connections:
submariner-cable-subm-cluster-b-10-166-0-31:  <IP_ADDRESS>...<IP_ADDRESS>  IKEv2
submariner-cable-subm-cluster-b-10-166-0-31:   local:  [<IP_ADDRESS>] uses pre-shared key authentication
submariner-cable-subm-cluster-b-10-166-0-31:   remote: [<IP_ADDRESS>] uses pre-shared key authentication
submariner-child-submariner-cable-subm-cluster-b-10-166-0-31:   child:  <IP_ADDRESS>/32 <IP_ADDRESS>/16 <IP_ADDRESS>/14 === <IP_ADDRESS>/32 <IP_ADDRESS>/16 <IP_ADDRESS>/14 TUNNEL
Security Associations (1 up, 1 connecting):
submariner-cable-subm-cluster-b-10-166-0-31[6]: ESTABLISHED 2 hours ago, <IP_ADDRESS>[<IP_ADDRESS>]...<IP_ADDRESS>[<IP_ADDRESS>]
submariner-cable-subm-cluster-b-10-166-0-31[6]: IKEv2 SPIs: 47f75baf8a0b2fce_i* c29a132dc3778a4d_r, rekeying in 91 minutes
submariner-cable-subm-cluster-b-10-166-0-31[6]: IKE proposal: AES_GCM_16_128/PRF_HMAC_SHA2_256/MODP_2048
submariner-child-submariner-cable-subm-cluster-b-10-166-0-31{19}:  INSTALLED, TUNNEL, reqid 1, ESP in UDP SPIs: cced9dba_i cc0777f9_o
submariner-child-submariner-cable-subm-cluster-b-10-166-0-31{19}:  AES_GCM_16_128/MODP_2048, 0 bytes_i, 0 bytes_o, rekeying in 20 minutes
submariner-child-submariner-cable-subm-cluster-b-10-166-0-31{19}:   <IP_ADDRESS>/32 <IP_ADDRESS>/14 <IP_ADDRESS>/16 === <IP_ADDRESS>/32 <IP_ADDRESS>/14 <IP_ADDRESS>/16
submariner-cable-subm-cluster-b-10-166-0-31[1]: CONNECTING, <IP_ADDRESS>[%any]...<IP_ADDRESS>[%any]
submariner-cable-subm-cluster-b-10-166-0-31[1]: IKEv2 SPIs: 4fb26e3da8589e82_i*<PHONE_NUMBER>000000_r
submariner-cable-subm-cluster-b-10-166-0-31[1]: Tasks active: IKE_VENDOR IKE_INIT IKE_NATD IKE_CERT_PRE IKE_AUTH IKE_CERT_POST IKE_CONFIG CHILD_CREATE IKE_AUTH_LIFETIME

[root@ip-10-0-59-17 submariner]# echo $?
3

Probably the "CONNECTING" part, with a repeated connection is what we need to investigate. I see those kinds of duplicate connection "SAs".

@manosnoam, we use the VICI interface to control Charon in Submariner Gateway. Its recommended using swanctl, a command-line tool, to configure and control Charon.
So, please use the following command, which ideally should return the proper value.
swanctl --list-sas (or swanctl --list-conn)
Sample output:
[root@cluster2-worker submariner]# swanctl --list-sas
submariner-cable-cluster3-172-17-0-7: #2, ESTABLISHED, IKEv2, e1d379930d5dda7d_i 7fa34a6224864124_r*
local  '<IP_ADDRESS>' @ <IP_ADDRESS>[4500]
remote '<IP_ADDRESS>' @ <IP_ADDRESS>[4500]
AES_GCM_16-128/PRF_HMAC_SHA2_256/MODP_2048
established 1379s ago, rekeying in 13013s
submariner-child-submariner-cable-cluster3-172-17-0-7: #1, reqid 1, INSTALLED, TUNNEL-in-UDP, ESP:AES_GCM_16-128
installed 1379s ago, rekeying in 1883s, expires in 2581s
in  cac21d13,      0 bytes,     0 packets
out cb66f8b2,      0 bytes,     0 packets
local  <IP_ADDRESS>/24 <IP_ADDRESS>/32
remote <IP_ADDRESS>/24 <IP_ADDRESS>/32
[root@cluster2-worker submariner]#
[root@cluster2-worker submariner]# echo $?
0
[root@cluster2-worker submariner]#
Alternately, this would also work, but not recommended (AFAIU)
[root@cluster2-worker submariner]# strongswan stroke statusall
Status of IKE charon daemon (strongSwan 5.7.2, Linux 5.5.5-200.fc31.x86_64, x86_64):
uptime: 23 minutes, since Feb 25 04:33:50 2020
malloc: sbrk 2965504, mmap 0, used 1128352, free 1837152
worker threads: 11 of 16 idle, 5/0/0/0 working, job queue: 0/0/0/0, scheduled: 2
loaded plugins: charon pkcs11 tpm aesni aes des rc2 sha2 sha1 md4 md5 mgf1 random nonce x509 revocation constraints acert pubkey pkcs1 pkcs7 pkcs8 pkcs12 pgp dnskey sshkey pem openssl gcrypt fips-prf gmp curve25519 chapoly xcbc cmac hmac ctr ccm gcm curl attr kernel-netlink resolve socket-default farp stroke vici updown eap-identity eap-sim eap-aka eap-aka-3gpp eap-aka-3gpp2 eap-md5 eap-gtc eap-mschapv2 eap-dynamic eap-radius eap-tls eap-ttls eap-peap xauth-generic xauth-eap xauth-pam xauth-noauth dhcp led duplicheck unity counters
Listening IP addresses:
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
Connections:
submariner-cable-cluster3-172-17-0-7:  <IP_ADDRESS>...<IP_ADDRESS>  IKEv2
submariner-cable-cluster3-172-17-0-7:   local:  [<IP_ADDRESS>] uses pre-shared key authentication
submariner-cable-cluster3-172-17-0-7:   remote: [<IP_ADDRESS>] uses pre-shared key authentication
submariner-child-submariner-cable-cluster3-172-17-0-7:   child:  <IP_ADDRESS>/32 <IP_ADDRESS>/24 === <IP_ADDRESS>/32 <IP_ADDRESS>/24 TUNNEL
Security Associations (1 up, 0 connecting):
submariner-cable-cluster3-172-17-0-7[2]: ESTABLISHED 23 minutes ago, <IP_ADDRESS>[<IP_ADDRESS>]...<IP_ADDRESS>[<IP_ADDRESS>]
submariner-cable-cluster3-172-17-0-7[2]: IKEv2 SPIs: e1d379930d5dda7d_i 7fa34a6224864124_r*, rekeying in 3 hours
submariner-cable-cluster3-172-17-0-7[2]: IKE proposal: AES_GCM_16_128/PRF_HMAC_SHA2_256/MODP_2048
submariner-child-submariner-cable-cluster3-172-17-0-7{1}:  INSTALLED, TUNNEL, reqid 1, ESP in UDP SPIs: cac21d13_i cb66f8b2_o
submariner-child-submariner-cable-cluster3-172-17-0-7{1}:  AES_GCM_16_128, 0 bytes_i, 0 bytes_o, rekeying in 30 minutes
submariner-child-submariner-cable-cluster3-172-17-0-7{1}:   <IP_ADDRESS>/24 <IP_ADDRESS>/32 === <IP_ADDRESS>/24 <IP_ADDRESS>/32
[root@cluster2-worker submariner]#
[root@cluster2-worker submariner]# echo $?
0
[root@cluster2-worker submariner]#

Thanks Sridhar, I will try those commands.
But maybe exit code 3 is an indication of a bug due to: Security Associations (1 up, 1 connecting)
Which seems like an attempt to create a second connection, while it should/can not, cause only one connection is required?

Thanks Sridhar, I will try those commands.
But maybe exit code 3 is an indication of a bug due to: Security Associations (1 up, 1 connecting)
Which seems like an attempt to create a second connection, while it should/can not, cause only one connection is required?

I checked locally in my cluster and even when the connection is successfully established, I see that "strongswan statusall" returns exit code of 3. You can give a try with the commands I suggested and let us know if you still see exit code of 3.

@manosnoam as we now have an API to query the status of IPsec tunnels in a generic manner (irrespective of the cableEngine that is used in the cluster), please continue to use the new API over these commands. I'm closing this issue.
kubectl describe Gateways -n submariner-operator

how to know kernel support AES_GCM_16_128? thanks


Consider making a series of tutorial videos.

Videos should probably start with installing Node + Feri then move on to more advanced topics. Keep videos separate and focused on a particular aspect of Feri.
Videos should definitely be posted on YouTube. Possibly Vimeo too.

I no longer think a video is needed. Especially since I have long term plans to re-write Feri.


Having .. gives incorrect error reports.

Godot version
v4.0.stable.official [92bee43ad]
System information
Ubuntu 22.04
Issue description
When accessing a function, variable, class, etc.. if you accidentally have two periods .. then the editor says
Parse Error: Expected closing ")" after grouping expression
when it should say something along the lines of
Parse Error: Found .. in reference
Steps to reproduce
Place this somewhere in your code.
(something..something_else)
Minimal reproduction project
N/A

The error is correct. .. is not recognized as a token. I think the parser recognizes this as 2 expressions, in which case braces are used for grouping them. Or something. It sees ( and expects ).

I meant incorrect as it's saying you're missing a parenthesis when your not. But I see what you mean since . is usually separating methods or classes.

There is a valid error message, but another message appears before it. This is not the only case, I noticed a couple of times similar in the parser and analyzer.


TypeScript Error

Thanks for the library, looks great.
Having an issue with it in a TypeScript project.
node_modules/openweathermap-ts/dist/types/Constructor.d.ts:3:5 - error TS2411: Property 'units' of type '"standard" | "imperial" | "metric" | undefined' is not assignable to string index type 'string'.

3     units?: Unit;
      ~~~~~

node_modules/openweathermap-ts/dist/types/Constructor.d.ts:4:5 - error TS2411: Property 'language' of type 'string | undefined' is not assignable to string index type 'string'.

4     language?: string;
      ~~~~~~~~

TypeScript isn't my primary skill, any help?

Sure, can you post a snippet of your code that's causing the issue?

I've installed the library and have these errors mentioned above.
Removing the optional flag for units and language removes the error.


v0.12.2 - TEDAPI Cache Expiration Fix

v0.12.2 - Cache Expiration Fix

Fix bug in cache expiration timeout code that was not honring pwcacheexpire setting. Raised by @erikgiesele in https://github.com/jasonacox/pypowerwall/issues/122 - PW_CACHE_EXPIRE=0 not possible? (Proxy)
Add WARNING log in proxy for settings below 5s.
Change TEDAPI config default timeout from 300s to 5s and link to pwcacheexpire setting.

Closes #122

The cache time for config was set to 300s (5m) - I think the basis was to reduce load on TEDAPI for mostly static (config) data, but this impacts the "battery reserve setting" data as well. I can't recall if this was to address any reported issue where the config data timeout helped address stability.
For consistency, I'm updating the 300s to match the status data timeout of 5s. It will also match the explicit cache time setting if provided in the Powerwall object constructor.
I will run this a while in full mode to ensure no negative impact.

Test docker image: jasonacox/pypowerwall:0.12.2t67-beta
Testing to close #122

No issues during tests.  Merged and released v0.12.2:
View at:
https://pypi.org/project/pypowerwall/0.12.2/
Proxy docker image:
jasonacox/pypowerwall:0.12.2t67


Use geopy to calculate the distance between two points(Duplicate of #5339)

Article checklist
Attention
Our Peer Reviewer and Content Moderator teams do NOT provide any revisions services. All revisions and edits should be completed on your own forked repo (as to not take up room in the queue) in order for our team to review them all in a timely manner.
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.

As a rule of thumb - please be sure to only submit articles (pull requests) that are fully polished and ready to be published. Be sure to go through our resources documents for extra and 3rd party (vetted) resources to help improve overall technical writing.

Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels, under 300KB in size, and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[ ] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #issue-number
This closes #5339

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

Plagiarism check done. Please correct the highlighted issues.
New Scan 8_50 AM Copyleaks Report.pdf

@WanjaMIKE I have corrected that

After this review, your article appears quite short minus the code. You will need to add more content for more value.

@Joshuathuo  If you need time, you can rework the PR outside the queue.

@WanjaMIKE you can reopen so that I can submit

Reopened

@WanjaMIKE I have submitted

Your article is still less than 750 words minus the code. It seems you need more time. Please create a duplicate PR when ready. Thanks

@WanjaMIKE according to the topic itself most part of it is the code  which means the words will be lesser.. And may I ask is the code not included in the tally of the 750 words.

No its not included in the word count

But on my side the words excluding the code are more than 750

@WanjaMIKE  The words from my side are more than 750 excluding the code

They are actually about 600 words. You can paste the file in MS Word then remove all code and front matter. Please add more content then create a duplicate PR. Thanks