iOS - New Room - More space between # and roomname in the room name creation field

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the App
Login with expensify account
Click on FAB button->New Room
Enter the name in the field Room Name

Expected Result:
There should not be more space between # and room name
Actual Result:
There is more  space between # and room name
Workaround:
Unknown
Platform:

Where is this issue occurring?

iOS

Version Number: 1.2.12-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/194445174-fcd9eaca-2b3c-48d7-9115-03ddc0c3c891.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub

Proposal

In order to reduce extra space between # and roomname we need to reduce paddingLeft from <BaseTextInput>
Here we are adding width according to prefix text and add extra paddingLeft for 4px StyleUtils.getPaddingLeft(this.state.prefixWidth + styles.pl1.paddingLeft)
In order to reduce we need to decrement 4px -> 1px or 2px in below or we can remove completely (not recommended)
This one will be a global change it will reduce extra space from prefex + textinput

pl1: {          paddingLeft: 1,     },
https://github.com/Expensify/App/blob/0e8fc0274f101453ddeda06158b589b0391e2994/src/styles/utilities/spacing.js#L301-L303
Results

This should be reviewed by design team first.

This should be reviewed by design team first.

Agreed

I think this one has other implications too. For example, I think the chat input on iOS is not vertically centered and thus the text looks like it's shifted towards the bottom too. So I think before we try solving this one in isolation, we should see if there is a bigger problem at hand that needs to be solved for all iOS inputs.

Yup, look how it is pushed down. Perhaps we have another issue open for this?

@shawnborton probably this one you are referring to https://github.com/Expensify/App/issues/10202 ? as this addresses to vertical spacing into text input and this current issue is for horizontal space between prefix - textInput

Ah apologies, taking another look now...

I'm actually just going to go ahead and close this - I don't think this is a bug and this small gap is intended so that there is clear space between the hash and the input.


provide a canonical API to get the OpenShift token

this relates to #20 really.

when using vanilla OAuth then there's only one token (e.g. fabric8-runtime-console).
when using almighty back end  (fabric8-ui) we'll need an API to fetch the openshift token via OSO (using the current keycloak token to fetch it).

Ideally we'd have a single API we can use in downstream apps (e.g.  fabric8-runtime-console and fabric8-ui) to get the openshift token.
Mostly its just a case of adding an API; reusing OAuth token or for almighty talking to almighty/keycloak to the the OSO token

Fixed via #23 -  closing


'x' close button does not render in the correct place in bootstrap plugin

Plunker:
http://plnkr.co/edit/QtOzvr?p=preview

I'm submitting a ...
[x ] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?
Report bug.

What is the current behavior?
Using the showClose(true) results in the 'x' being inserted before the title:

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
See code below.

What is the expected behavior?
'x' close should be on far right of the header/title area.

What is the motivation / use case for changing the behavior?
Incorrect bootstrap template implemented.

Please tell us about your environment:

ngx-modialog version 3.03.
Angular version: 4.3.4
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
When I examine the html, the title h3 is rendered AFTER the close button. If you look at the code in the library:
https://github.com/shlomiassaf/ngx-modialog/blob/master/src/ngx-modialog/plugins/bootstrap/src/message-modal.component.ts
you can see the template is wrong:

@Component({
  selector: 'modal-title',
  encapsulation: ViewEncapsulation.None,
  template: `

      <button *ngIf="context.showClose" type="button" class="close"
              aria-label="Close" (click)="dialog.dismiss()">
          ×
      </button>

{{context.title}}

`
})
export class BSMessageModalTitle {

I believe it should be like this:
@Component({
  selector: 'modal-title',
  encapsulation: ViewEncapsulation.None,
  template: `

{{context.title}}

      <button *ngIf="context.showClose" type="button" class="close"
              aria-label="Close" (click)="dialog.dismiss()">
          ×
      </button>

`
})
export class BSMessageModalTitle {

If you modify the demo plunker by shortening the title you can see the problem clearly:

Hope this example helps: https://github.com/ashfaqch/angular-modal-dialog-example

This problem still exists in ^6.0.0 version

As a workaround I set the following css properties in my own style.css. This places the close button in the upper right corner of the modal header and the title is placed on the left side.
.modal-header .close {
    position: absolute;
    right: 0;
    margin: -1rem 0rem -1rem auto;
}

@bisigc It is working as expected after applying the class.


Tag Release 0.63

Hi @rbock,
Would you be willing to please tag a new release version that includes some of the latest changes added by @CJCombrink ?

I want to confirm #498 first (just came in).
You might have to poke me again. These are busy days.
Thanks for your patience!

No problem, I will sit tight!

Done :-)


Check - disable HOMEBREW_DEVELOPER

We are external homebrew tap, not the Homebrew-core formulae

Closing as outdated


README/help: add info on IPS mode tests creation - v3

Previous PR: https://github.com/OISF/suricata-verify/pull/1965
Describe changes:

it's not a straightforward process to use the test name alternative with createst, so I've removed that association from the README and createst help text.
remove mention to unrelated ticket from 540b1a5a6fad675bebc85efdfb3b0a1b1dae141b

Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/7039

The changes look good to me. The PR and ticket look unrelated now. Ticket seems to be about explaining/adding simulate-ips to createst. Could you please fix the ticket or the PR as seems fit?

Updated the ticket! 🙇🏽

When will you merge this Victor ? Do you have some tool that takes this ?
This is just doc, no need to test...

Merged in #2049, thanks!


feat: Bundle optimization and first load improvements

Description
This is an intermediate branch for the first load optimization
TL;DR
Improves the first load times via bundle optimization, code splitting, and prioritizing delivery of critical code.
Change 1
The Evaluation and Tern workers have several large dependencies:

linkedom/worker
node-forge
tern JSON definitions
This PR removes them from the main bundle. When applied to appsmithorg/appsmith on top of https://github.com/appsmithorg/design-system/pull/389, this makes the bundle 980 minified kB smaller (7.46 → 6.48 minified MB). #20972

Change 2

switches the build target to modern browsers; this means stuff like class, async/await, etc is not transpiled anymore
code-splits away the code editor + sets up ESLint rules to enforce that
code-splits away Lottie + sets up ESLint rules to enforce that

In total, this saves 1.34 minified MBs (8.34 → 7 MB), getting rid of these modules (+ making others smaller, thanks to the modern build target):
Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change
First load optimization and some housekeeping stuff.
Test Plan

Test icons in icon picker and rest of the application. Check if icons are loading properly and they don't have intermedite blank state.
Test code editor how it loads are there any delays in interacting with it, use network throttling when testing.

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

No DP available in this PR
@SatishGandham can you please check

/build-deploy-preview env=release

Observed the following:

change of icons style of autocomplete list of code editor (as discussed with @SatishGandham )

More icons got added in icon lists (Compared with current release version)

Tested this PR and LGTM

No breakage observed
No impact on existing widgets or their working functionalities

/ok-to-test sha=a14184d

/ok-to-test sha=f3e0d4f

/build-deploy-preview

Build running here

After merging this PR, is everything in this guide still valid? https://github.com/appsmithorg/appsmith/blob/release/contributions/ClientSetup.md
I noticed node_modules and ESLint configuration are now in a different level. Does this mean the yarn install has to be done in the app/ folder rather than app/client? Also had to change the ESLint configuration manually in IntelliJ (was automatic before).

You can do yarn install in any folder under app.
We will move all UI related code under client in a couple of weeks.

@SatishGandham Understood. Is there any issue number / branch / PR I can follow to be aware of those updates? Thanks in advance.

@iamenrique , https://github.com/appsmithorg/appsmith/pull/23395/


DataIsolationSample: Exception

I have downloaded the Finbuckle.MultiTenant-release-6.0.0-dev
Open the solution in VS2019, Finbuckle.MultiTenant-release-6.0.0-dev
Run the project ASP.NET Core 3 DataIsolationSample:

System.AggregateException
HResult=0x80131500
Message=Some services are not able to be constructed (Error while validating the service descriptor 'ServiceType: DataIsolationSample.Data.ToDoDbContext Lifetime: Scoped ImplementationType: DataIsolationSample.Data.ToDoDbContext': No constructor for type 'DataIsolationSample.Data.ToDoDbContext' can be instantiated using services from the service container and default values.)
Source=Microsoft.Extensions.DependencyInjection
StackTrace:
at Microsoft.Extensions.DependencyInjection.ServiceProvider..ctor(IEnumerable1 serviceDescriptors, ServiceProviderOptions options)    at Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions.BuildServiceProvider(IServiceCollection services, ServiceProviderOptions options)    at Microsoft.Extensions.DependencyInjection.DefaultServiceProviderFactory.CreateServiceProvider(IServiceCollection containerBuilder)    at Microsoft.Extensions.Hosting.Internal.ServiceFactoryAdapter1.CreateServiceProvider(Object containerBuilder)
at Microsoft.Extensions.Hosting.HostBuilder.CreateServiceProvider()
at Microsoft.Extensions.Hosting.HostBuilder.Build()
at DataIsolationSample.Program.Main(String[] args) in G:\MyProjects_CrossPlatform\Multitenancy\Finbuckle.MultiTenant-release-6.0.0-dev\samples\ASP.NET Core 3\DataIsolationSample\Program.cs:line 15
This exception was originally thrown at this call stack:
Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.CreateConstructorCallSite(Microsoft.Extensions.DependencyInjection.ServiceLookup.ResultCache, System.Type, System.Type, Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteChain)
Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.TryCreateExact(Microsoft.Extensions.DependencyInjection.ServiceDescriptor, System.Type, Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteChain, int)
Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.GetCallSite(Microsoft.Extensions.DependencyInjection.ServiceDescriptor, Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteChain)
Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.ValidateService(Microsoft.Extensions.DependencyInjection.ServiceDescriptor)
Inner Exception 1:
InvalidOperationException: Error while validating the service descriptor 'ServiceType: DataIsolationSample.Data.ToDoDbContext Lifetime: Scoped ImplementationType: DataIsolationSample.Data.ToDoDbContext': No constructor for type 'DataIsolationSample.Data.ToDoDbContext' can be instantiated using services from the service container and default values.
Inner Exception 2:
InvalidOperationException: No constructor for type 'DataIsolationSample.Data.ToDoDbContext' can be instantiated using services from the service container and default values.

I have removed the NuGet and added the project and it works
Something wrong wth NuGet
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>netcoreapp3.1</TargetFramework>
    <IsPackable>false</IsPackable>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="3.1.1" />
    <!--<PackageReference Include="Finbuckle.MultiTenant" Version="6.0.0-preview1" />-->
  </ItemGroup>

  <ItemGroup>
     <ProjectReference Include="..\..\..\src\Finbuckle.MultiTenant\Finbuckle.MultiTenant.csproj" />
  </ItemGroup>
</Project>

@Oleg26Dev Thanks for creating the issue. I suspect it has to do with ITenantInfo not being injected correctly... I'm currently setting up a new computer so I haven't been able to test as usual. I will take a look at it this evening.
-Drew

Andrew, check my comment above

Ah yes, I see it was still referencing the bad nuget package and not the code. Good catch.

The branch is a few commits newer than the preview1 nuget package. I will get a preview2 nuget out this weekend.

@Oleg26Dev Hello again! Preview2 should fix this.

Yes, the Preview2 is better. Thanx.


metrics-exporter-prometheus crashes if port 9000 blocked

If you have something already using port 9000, metrics-exporter-prometheus crashes at https://github.com/metrics-rs/metrics/blob/ca453d31009e1809161a0644943bbf5a8b3eb2e6/metrics-exporter-prometheus/src/exporter/builder.rs#L61, even if you never call install(), and even if you use with_http_listener to tell it to use a different port.
More info: https://github.com/Ptrskay3/axum-prometheus/issues/66

:wave:
I saw and responded on the linked issue, but just to dive in a little here:

If you have something already using port 9000, metrics-exporter-prometheus crashes..

This is expected since we can't bind to a port already in use.

, even if you never call install(), and even if you use with_http_listener to tell it to use a different port.

Now this part makes me pause. Do you have a reproduction for the "even if you tell it to use a different port" part? I'm not actually seeing how that would be possible.

I definitely can't reproduce that last part.
Changed the default http listener in axum-prometheus to:
 let (recorder, _) = PrometheusBuilder::new()
            .upkeep_timeout(Duration::from_secs(5))
            .with_http_listener(([0, 0, 0, 0], 9001))
            .unwrap()
            .build()
            .expect("Failed to build metrics recorder");

then ran netcat -l 9000, and my examples build and work just fine. Without this change they did panic because of the 9000 port already is use.

Ran into this again because I hadn't properly fixed it last time.   I think I have it this time.  But it does mean I cannot use a really nice axum_prometheus helper function.
Would it be possible to add a with_no_listener() builder function that axum_prometheus can use?

Without doing some sort of typestate builder to determine what gets returned/installed by the build/install methods... I don't having a configuration method like that could work.
It feels like what we could get away with is something like...
pub struct PrometheusBuilder {
    // Two builder methods that don't install anything:
    pub fn build(self) -> Result<(PrometheusRecorder, UpkeepFut, ExporterFut), BuildError>;
    pub fn build_recorder(self) -> Result<(PrometheusRecorder, UpkeepFut), BuildError>;

    // This method builds everything, installs the recorder, and spawns the upkeep future
    // and exporter future:
    pub fn install(self) -> Result<(), BuildError>;

    // This method builds everything, installs the recorder, and spawns the upkeep future
    // but returns a handle to the recorder for the caller to manually handle generating
    // the payloads:
    pub fn install_recorder(self) -> Result<PrometheusHandle, BuildError>;
}

I think install_recorder is what axum-prometheus would want, because it handles installing the recorder and spawning the upkeep task, but then returns the handle necessary to wiring up a custom scrape endpoint handler. For people looking to use Push Gateway support, axum-prometheus could conceivably drop down to the low-level build method and install/spawn as much or as little as they wanted to, deferring the rest to the user.
@Ptrskay3 How does that sound? I'm a little fuzzy these days on how axum-prometheus is integrating with metrics-exporter-prometheus, so my mental model might be off here.

That sounds reasonable to me. Currently we use the PrometheusBuilder::build method, but having the install_recorder API in your example seems even better.
The the push-gateway mode is not really thought out in axum-prometheus yet, so we just tell the user to drop down to the lower level APIs, and use the PrometheusBuilder themselves.


Add integration tests

Work in progress, some of the code is cribbed from https://github.com/radian-software/dumbparens

FYI @mohkale @elken


How can this api_server running only with CPU?

Unfortunately, my server has 48 CPUs but no GPU. How can I run your program in this situation?

Hi, this is very late sorry for that :(
But we've just implemented the CPU support

Use this command to run it only with CPU
python3 server.py --model "meetkai/functionary-7b-v1.1" --device=cpu


bump checkout@v3 -> v4

Got this .. might need some updates Load user automation choices
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, <EMAIL_ADDRESS>For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Yup. I know how to solve this problem. Just need to bump up the checkout action versions we are using. @howardbaek is this something you could do?
Let me know if you need more details.

I'm guessing I need to bump up v3 to v4 in these lines?

https://github.com/jhudsl/ITCR_Tables/blob/main/.github/workflows/render-site.yml#L29
https://github.com/jhudsl/ITCR_Tables/blob/main/.github/workflows/render-site.yml#L50

Yes! And anywhere else you find it!


about tooltipHtml

i don't know why my chrome say that
xScale.invert is not a function

in react 15

+1 This is happening for me as well. I can provide code samples of what's going on for me if needed. If you don't mind me asking @sanyuelanv... I'm using the linegraph for the tooltip functionality. Are you using the same?

Thanks for the feedback! Could you provide a code sample of that happening. I'll have a look!

https://gist.github.com/ryanhca/6b8c1f9601abc2626696d2f1668ce362

Thanks I will have a look at it!

Could I have a sample of your data?
Doesn't need to be the original data, just the same format as the input you provide.

Sure. I build an array of these exact values. This is actually the exact format my data gets set to.  Could you test something?
In your case the X scale will be an d3.ordinalScale which doesn't have an invert() function.
I will try to find a way for this case in the future but if you would change your x to be a Date object a time scale should be used and invert will work.
So could you try to add .toDate() in all the 'x' assignments like this:
{'x':moment().subtract(6, 'days').format('ddd MMMM Do').toDate(), 'y':day7},

Yes. that worked. I'd like to be able to format the date at some point in the future. but for now for this iteration I'll be able to use the chart with that date format. Let me know if you ever come across a fix<EMAIL_ADDRESS>is my email. Feel free to reach out. I'd love to look into your library and see if I can't find a fix sometime when I'm not so busy at work. I'll fork it this week and start poking around.

Also, is there a way to hide labels if there is no data to display? example, I have an active vs inactive piechart and often times there are no "inactive" data types to display, but the label still shows up for the pie chart

Thank you for the praise, I welcome any help improving this library. Just send a pullrequest once you have something going.
About your first question with the date format, I think it should be possible by setting the tick format on the axis. I will have a look at it.
Having an option to remove the label if necessary sounds good. Maybe there is even a possibility to split out the label code from the graph code. Not sure.
What exactly do you mean by having several charts in the same 'parent' ?
Do you want to show 3 different pie charts at the same time (3 different rings?)
Do you just want to show different pie chart at the same place?

@ryanhca about your question regarding the timestamp formatting:
I am already doing something similar in the example html file.
<LineChart
xAxis={{tickValues: this.state.xScale.ticks(d3.time.day, 2), tickFormat: d3.time.format("%m/%d")}}

The d3.colorscale option is something that I completely looked over! That worked marvelously. The charts are all sibling components. They receive props from the parent's state regarding the data they're displaying. The problem was that the colorScale was adding a new color to each new arc that d3 created. And I'll give the tickFormatting a shot! Thanks again! Fun stuff here!

<div>                     <BarChart                         groupedBars                         data={this.state.aggregatedObject}                         width={width}                         height={height}                         tooltipHtml={tooltip}                         tooltipMode={'mouse'}                         colorScale={d3.scaleOrdinal()                             .domain(['Hits', 'Success', 'Error', 'Timeout'])                             .range(['#A07EEF', '#78C948', '#2791FF', '#FE0000'])}                         margin={{ top: 50, bottom: 50, left: 50, right: 50 }}                     />                 </div>
This tooltipHtml feature isn't working for me. I have also declared this variable:
var tooltip = function(x, y0, y, total) {  console.log(y.toString())     return y.toString();     };
the console.log(y.toString()) works here but doesn't show on the UI?

How is it supposed to work when I am using strings as elements of the array for x-axis ? I am getting the same error @codesuki

This issue is still not fixed @codesuki


Fix review box viewport overflow issue

Fix regression that came likely from https://github.com/go-gitea/gitea/pull/23271:
Long lines of text currently cause the review box's CodeMirror element to resize which apparently is not recognized by popper's resize detection and which causes the element to go partially out of viewport until a reflow happens:

Fix this by setting the element to a static width derived from viewport width and remove the previously clumsy media queries.

No one else annoyed by this bug? 😉


Defined new revisions for golang dep: github.com/itchyny/gojq

Ran component through the scanners since I noticed it had not been harvested yet. PR matches curation site. Closing.


what's the wecommended amount of dedotated wam i should have to server?

It depends on a few factors, but mainly how many active users you'll have, render distance, etc. It appears that 1 GB of RAM is a good starting point. I just looked at some of my monitoring data and I have a survival server that has had off and on up to 4 players and hasn't gone above 476 MB for the container.


feat: Working docker-compose healthchecks

Listing docker compose containers now shows healthy state:
      Name                    Command                  State                    Ports
---------------------------------------------------------------------------------------------------
zally_postgres_1   docker-entrypoint.sh postgres    Up (healthy)   <IP_ADDRESS>:54321->5432/tcp
zally_server_1     /bin/sh -c java $(java-dyn ...   Up (healthy)   <IP_ADDRESS>:8000->8000/tcp, 8080/tcp
zally_web-ui_1     node server.js                   Up (healthy)   <IP_ADDRESS>:8080->3000/tcp

Closes #1133

:+1:

(I have noticed the CI failure btw - will try and get back to this soon if nobody beats me to it!)

👍

Codecov Report

Merging #1151 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1151   +/-   ##
=========================================
  Coverage     88.04%   88.04%
  Complexity       85       85
=========================================
  Files            69       69
  Lines          1046     1046
  Branches         71       71
=========================================
  Hits            921      921
  Misses           88       88
  Partials         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db6b3c6...7b7ebf5. Read the comment docs.

👍

:+1:


Translate/de json apis and ajax

Type of Change

[X] Add new translation (feature adding new translations)

Description

This is the german translation for the JSON APIs and AJAX challenge.
Proofread required!
Issue #8458

Closes #8458

@john-dederer Thanks for the translation! I added some comments at parts with typos and terminology suggestions.

@john-dederer Translations must be done in the same file as the original challenges. Please relocate them according to the pattern already set.
Happy Coding!


Make it possible to add cdrom to vm

For simplicity I would make this
cl.experimental.kvm.create(name, images, cpu=2, memory=512, port=None, bridge=None, cdrom=None)

Make sure to use new client, since client compatibility is broken with older api (regarding creating KVM domains)

@muhamadazmy Can you add Fixes #87 or similar comment ( https://help.github.com/articles/closing-issues-via-commit-messages/ ) to the commit in the future? This way it's easier for someone else to see the related changes.

@robvanmieghem sure.


Add more indexes

We probably need to find more indexes for the wrapper since we might encounter users reporting the "Unknown Index" errors.

[ ] add possible missing indexes (index 0, index 1 , index 2, etc.)

Can we do some indexing on how many indexes does suaceNao search for potential images?

What?

49427f7 added a bunch of indexes and index aliases. This should cover all the indexes in the range provided by SauceNAO. Closing.


Configuration to compile Rust with any profile

As with wasm-pack, there are only two possible profiles for trunk's Rust compilation: debug and release. While trunk offers direct control over the optimization level, I need to adjust other parameters (debug options, LTO, ...) which are usually set via profiles and detectable in the code itself. Additionally, I do not want to use the release profile. The Wasm web app is just one part of a larger workspace (where all crates share build profiles), and the main executable build in the workspace requires vastly different options in its release build. My current workaround, which I have already been using for wasm-pack, is to reserve the release profile for Wasm and use a custom profile for the main release build. I would prefer the ability to do this the other way around, where the much less important web app gets some custom release profile while the main application gets the default release profile.
(Reopened from #545 since this is still not solved)

Not stale.

Maybe solution is to not use wasm-pack and instead opt for using cargo, so that the PROFILE and other environment variables can be set outside of trunk.
Hence, the onus would be on developers to create profiles or release settings, e.g.
[profile.release]
panic = "abort"
lto = true
codegen-units = 1
strip = true

[profile.web-release]
inherits = "release"
opt-level = 's'
strip = "debuginfo"

And then, under the hood, trunk would fire these commands instead:
trunk build --profile web-release (where --release would be a shortcut to --profile=release)
(Trunk internals)
cargo build -p <package> --target wasm32-unknown-unknown --profile web-release
wasm-bindgen --target web --out-dir bindings ${STAGING_DIR}/out.wasm --no-typescript
...

This issue shouldn't have been closed, as this problem still affects multiple other projects that are using trunk.

Cleaning up issues, I ran into this one.
Currently trunk itself knows two modes (release and non-release). Trunk's --release basically translates into cargo's --release, but also triggers a bunch of other logic intended for release builds.
Ideally, all of those options end up in some profile, and we have two default profiles. One of those fields being the cargo profile.
That's a bigger task though.
Another alternative would be to add some --cargo-profile flag, which can override the cargo profile ad-hoc. That would do the trick, would be quick, but not the best/ideal way.

Another alternative would be to add some --cargo-profile flag, which can override the cargo profile ad-hoc. That would do the trick, would be quick, but not the best/ideal way.

I'd prefer the thoughtful approach.

Another alternative would be to add some --cargo-profile flag, which can override the cargo profile ad-hoc. That would do the trick, would be quick, but not the best/ideal way.

I'd prefer the thoughtful approach, where --profile works as expected and --release is just sugar for --profile release, the same way it works in cargo.

I think it makes sense tracking this in a separate issue. It looks to me as if that will have a bigger impact on the whole arguments/env-vars/config area.

Is there any workaround available to tell trunk to use things like opt-level = "z" when it's not already configured in [release]?

Trunk will "only" spawn cargo. With or without the --release flag. That's the only think that is available right now.

Sorry for the late response. I've not had much time recently for trunk as I would've liked.
You can ping me on Matrix (@ctron:dentrassi.de) if that helps.
I'd like to avoid doing any quick hacks. Simply, because it pulls away time from the actual goal.

@janhohenheim Ok, I did take a second look, and maybe there's a quick, intermediate solution that wouldn't hurt. Here's the PR: https://github.com/trunk-rs/trunk/pull/865
The idea is to allow setting the "cargo profile" only. Ignoring all other "profile" ideas. IIRC, that was one feature anyhow. The idea was to have trunk choose a cargo profile, by choosing a "trunk profile". Now trunk profiles will take more time, but selecting a cargo profile is part of the process.
So now, with that PR, you can use:

--cargo-profile <profile>

    [build]
    cargo_profile = "foo"

data-cargo-profile (common), cargo-profile-dev, and cargo-profile-release (when using trunk --release)

To choose a cargo profile. The former will override the latter. Only the -dev and -release on the index.html are dependent on trunks release flag. All other will override (without a conflict). So you can use trunk --release --cargo-profile dev without conflict.
That's simply the because trunk's --release also has an impact on other things. And those "other things" need to be expressed as independent settings, and be managed by (future) trunk profiles. Having a dev and release profile, just like cargo. But that's something for the future.
@janhohenheim If possible, I'd like you to try out the PR. And provide some feedback. If that solves your issue, I think it's ok to merge this into the upcoming next release.


Fix HTTP API docs for upcoming release

Fixes #871.
Not much has changed, but this transaction now passes validation for me. Might be good to double check on your side :).

Current coverage is 96.72% (diff: 100%)

Merging #882 into master will not change coverage

@@             master       #882   diff @@
==========================================
  Files            27         27
  Lines          1708       1708
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1652       1652
  Misses           56         56
  Partials          0          0

Powered by Codecov. Last update 839035b...536d440

I tested the examples and they all worked.


Add note to config Cloud Run role while installing Piped

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/approve


Fix for browser with partial WebSocket support

Fix for browser with partial WebSocket support for using flash
From Modernizr - https://github.com/Modernizr/Modernizr/blob/master/feature-detects/websockets.js#L28

What exactly is the issue when window.WebSocket.CLOSING is not 2?

When the browser has partial support for WebSocket, it has no header "Sec-WebSocket-Version" and therefore the server can be determined WebSocket version and do a "handshake",
When the browser is "WebSocket.CLOSING == 2" it has full support for WebSocket and has a header "Sec-WebSocket-Version"
This patch uses flash-socket in browsers with partial WebSocket support(Firefox 4-5, Chrome 4-14, Safari 5-5.1, Opera 11.5, iOS Safari 4.3-5.1, Opera Mobile 12)
PS: http://caniuse.com/#feat=websockets
PPS: Sorry for my English =)

Policy of web-socket-js is to use native implementation when available (even if it's incomplete). So I would say the current behavior is intended.
If the user wants different policy (as yours for example), you can control the behavior by performing your own check and set:
WEB_SOCKET_FORCE_FLASH = true;

when you want to force Flash implementation.
Or, I believe your server can still detect the WebSocket version even if it misses Sec-WebSocket-Version. See:
https://github.com/gimite/web-socket-ruby/blob/master/lib/web_socket.rb#L52
Not sure if you want to implement hixie-75 and 76 in your server, though.


Replace selenium with a custom mechanism

Today, Selenium is used to automate execution of a simple test page and wait for its result. There is no real need of automation (other than starting the browser and waiting for the result).
This could be easily replaced with a simpler mechanism that consists in:

Launching the proper browser (spawning a command line)
Running the tests (from a local web browser)
Submit the test results (using the local web browser)
Closing the browser (in the worst situation by killing the spawn'd process)

Need to adapt exec to create test name
Need to add Object.keys(configuration.browsers) to the testTasks in concurrent.js
Need to provide helper to autodetect supported browser (and at least document)

Migrated to selenium 3, need to improve detection to avoid failures
Change the configuration file to remove selenium and replace with browsers and each one has a switch setting between selenium * other mechanism
Put in common url computation (based on parameters)

Not removed but upgraded to Selenium 3, added another mechanism for browsers that can be launched & killed from command line


Congrats

Your plugins are so cool, congratulations! I am impressed with Enhanced Readibilities, Page properties, Inline links preview. It is difficult to know which one is better.
I am promoting VitePress and "helping" VitePress team by opening a few issues and comments here and there.
I requested them to create a "vitepress-awesome" repository to list all the plugins and themes created for VitePress.
I also would enjoy to see a closer integration with Vite new environment API + SSR, instead of still focusing on Vue for SSR.
You are already full of work as I can see in your plugins, (Page properties plugin is in alpha for example), but if I could suggest something for your spare time, it is to bring a few missing plugins that are available for markdown-it or for vuepress, but not yet for VitePress. They are not difficult plugins, and there are workarounds for them, so they are not urgent, but they are relevant.
1."embed/youtube(vimeo, video services...) iframe" syntax support in markdown.
2. Any kind of plugin that enables Authentication would be so good. It may be Auth wrapper, or a plugin that simply extend the router locally according to some configs. At the moment anything related to Login+password, or related to locking some pages or parts of the pages (!), is difficult to achieve. Something similar to these: wordpress.org/plugins/groups/  or  https://authjs.dev/
3. A plugin to export the current page to other file format. There are many plugins that try to "export to pdf". But the name is not what it means. These plugins actually convert all markdown to pdf files at build time. That is good, but...  it could exist a simple button in each page. When you click on this button, JavaScript would then convert the page to pdf and download it in the browser at runtime.
4. There is a "mind map" in each page of your documentation, with the word "Constructing" passing by... That seems like the mind map that Obsidian offers. If that kind of mind map that shows Related Posts ever comes to be released as a plugin for VitePress, that would be so good!  In a first moment, it could simply show the related posts from the links in the page. It doesn't need to be deeper than that in a first moment.
5. Talking about Mind Maps, I would like to see a plugin for "Excalidraw" mind map editor. They offer an editor for React, I don't know how you would wrap this as a Vue component. But you can wrap it as a Web Component.
6. Currently there are new APIs appearing for the first time for translations API that are not from Google. For example, Mozilla released a translations API that they use in Firefox. It would be good to offer a translation plugin, something that shows a "Languages dropdown" and translates the page in real time. Currently, we need to translate before the build time.
I hope you appreciate the ideas and that they can help you in the future.
Probably time will bring some of these ideas, and probably time will tell that VitePress is going to become closer to Vite and Web Component instead of Vue SSR and Vue components. I think this is a misconception in VitePress at the moment.
Thank you

it is to bring a few missing plugins that are available for markdown-it or for vuepress, but not yet for VitePress.

Both VitePress and VuePress use MarkdownIt, and you can configure the Markdown It plugin yourself.
see https://vitepress.dev/guide/markdown#advanced-configuration

Currently there are new APIs appearing for the first time for translations API that are not from Google. For example, Mozilla released a translations API that they use in Firefox. It would be good to offer a translation plugin, something that shows a "Languages dropdown" and translates the page in real time. Currently, we need to translate before the build time.

Personally (and not on behalf of the nolebase community), I don't think it's a good idea to get translations from the API at build time, and I don't even think it's a good idea to automate translations like that. With translations built into all major browsers, and many browser translation extensions available, there seems to be absolutely no need to request an API at build time.

Also, many of your plugins need to be configured in config.js and index.js at the same time.

no ideas, see https://github.com/vuejs/vitepress/issues/3966

Hey, welcome to Nolebase community! Thank you for your suggestions!

Any kind of plugin that enables Authentication would be so good. It may be Auth wrapper, or a plugin that simply extend the router locally according to some configs. At the moment anything related to Login+password, or related to locking some pages or parts of the pages (!), is difficult to achieve. Something similar to these: wordpress.org/plugins/groups/ or https://authjs.dev/

This was actually an ongoing PR over #75 , but it has been blocked so long due to my insufficient knowledge to lazy hydration of Vue x Vite SSG. Perhaps, @northword, @LittleSound, and @kwaa would somehow get interested in it and help me out. Perhaps, if you would like to do some research on this and help us, feel free to do at anytime.

A plugin to export the current page to other file format. There are many plugins that try to "export to pdf". But the name is not what it means. These plugins actually convert all markdown to pdf files at build time. That is good, but... it could exist a simple button in each page. When you click on this button, JavaScript would then convert the page to pdf and download it in the browser at runtime.

Nice request tho, I understand many of you folks may use Nolebase and it's plugins to directly host Zotero or thesis knowledge bases, sometimes an "Export as" option would help a lot if ever wanted to share it to someone in a format of file. However, this is kind of hard to support, since for any rendered pages, withthe native print functionalities from browsers, tons of CSS styles, and layout features are not supported and we can do nothing. The only one way to achieve such capabilities is rendering when SSG (but the styles and layouts are still a hell of supporting issue).

There is a "mind map" in each page of your documentation, with the word "Constructing" passing by... That seems like the mind map that Obsidian offers. If that kind of mind map that shows Related Posts ever comes to be released as a plugin for VitePress, that would be so good! In a first moment, it could simply show the related posts from the links in the page. It doesn't need to be deeper than that in a first moment.

Yes it is, the same functionalities, and the similar looking. The only problem is I haven't had a time to implement it with relations extracted from tagging and pages. Will be a big plugin, stay tuned!

Talking about Mind Maps, I would like to see a plugin for "Excalidraw" mind map editor. They offer an editor for React, I don't know how you would wrap this as a Vue component. But you can wrap it as a Web Component.

Wait, why do you want t drawable canvas in a static site? Could you please share more thoughts and explain your need in detail? We would love to hear from you.

Thanks for your long writing though, very much impressed by your motivation and thoughts.

The user would click a fixed button at any time within the VitePress interface to create a new excalidraw map in a modal/popup and save it to the computer.

Are you saying you want to have VitePress to be interactive to user's computer? Where does this happen? With development server or with deployed static site? With only a downloadable file? Or not
Or... should I understand your needs like "Export canvas as image" then prompt users to save.
Well, while we surely have abilities to access and manipulate files and directories of users through https://developer.mozilla.org/en-US/docs/Web/API/File_and_Directory_Entries_API, I think we can achieve further capabilities for "save" and "export" features. For example: we could have a "save & export" plugin that adds a little hoverable button to images, audios, videos, embedded PDFs, Obsidian Canvas, Excalidraw, and tldraw files so that users can interact with.
What do you think @northword and @LittleSound? This should be quite small thing to implement.

to avoid me doing this manual work every time a cognitive map is created.

What is cognitive map?

to insert that image directly into the markdown file that is currently being viewed.

Still not sure what do you mean by "insert that image directly into the markdown file".
But I have tried a few experiment back in a year ago that I think that probably related to.
I tried to use OpenAI's API with ChatGPT to automatically add and summarize tags for my Nolebase documentations at that time. However, the implemented for development server only, which means the capabilities to read the source Markdown file and manipulate with newly summerized tags is only available when you are in vitepress dev command.
https://github.com/user-attachments/assets/07164054-aba6-4608-b822-3f19487e3833
(This was the demo I recorded for the LLM generated tags, sorry it's in Chinese)
Was this the "such functionality" you want?
If that's true, may I ask you the reason why you would like to use VitePress as an editor, rather than using Obsidian, Logseq to manage your knowledge base?

For example: we could have a "save & export" plugin that adds a little hoverable button to images, audios, videos, embedded PDFs

That's a good idea. We can have that.

Saving the creations on the computer would be enough. In turn, it would be cooler if the Excalidraw editor within VitePress would also able to ask the person if they want to save their cognitive map as an image, to insert that image directly into the markdown file that is currently being viewed. The plugin would take care of saving the photo in a folder and adding the URL link inside the markdown file, to avoid me doing this manual work every time a cognitive map is created.

If I understand you correctly, you want to export the edited Excalidraw file as an image and insert it into the MD file. This seems like it should be an editor plugin (like obsidian or vscode), not a vitepress plugin. vitepress is just a static page generator, not an editor.
I think it's closer to vscode-plugin-drawio-integration or something like that?
My workflow is to edit the file in vscode/obsidian, with the vitepress page only as a rendered result. And you actually want to turn vitepress into something similar to obsidian, editing files on pages generated by vitepress (like Excalidraw)?
(Please point out if I have misunderstood.)


ID USER

How do you save all user ids in a file? and above all how do I save it when the user presses / start? is it possible that I save only, I would like to save the new ids only the new ones, can you help me?

hello it seems you are new to coding. After saving the ids just add code to check if it already exists in the file .if not save it

i need a example working,


mcmicro_io.zip cell and nucleus bitmasks are the same

Is this expected?

It also could be improved by having more meaningful labels in channels_metadata - it seems like there are good names in table.var.index
"channels_metadata": {
        "channels": [
            {
                "label": 0
            },
            {
                "label": 1
            },
            {
                "label": 2
            },
            {
                "label": 3
            },
            {
                "label": 4
            },
            {
                "label": 5
            },
            {
                "label": 6
            },
            {
                "label": 7
            },
            {
                "label": 8
            },
            {
                "label": 9
            },
            {
                "label": 10
            },
            {
                "label": 11
            }
        ]
    },

@keller-mark could you please try using this PR, which improved the mcmicro reader: https://github.com/scverse/spatialdata-io/pull/28?

Actually, this doesn't fix the problem, I will check for a solution.

Getting back to this. The incoming PR (I'll try to merge it today) https://github.com/scverse/spatialdata-io/pull/28 assigns the channel names to the image (and generalizes the reader to support more complex outputs of the mcmicro pipeline).
Regarding the cell vs nuclei, I examined the code and the files, and realized that problem is already present in the data, and therefore is not due to our reader. I reported this in the mcmicro repository https://github.com/labsyspharm/mcmicro/issues/531.


Fix CodeQL Analysis

Changes
CodeQL Analysis was recently enabled on Results, but it's failing with "fatal: not a git repository (or any of the parent directories): .git".
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[ ] Tested your changes locally (if this is a code change)
[ x] Follows the commit message standard
[x ] Meets the Tekton contributor standards (including functionality, content, code)
[ x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

found .github/workflows/codeql-analysis.yml
.github/workflows/codeql-analysis.yml
  3:1       warning  truthy value should be one of [false, true]  (truthy)
  5:16      error    too many spaces inside brackets  (brackets)
  5:21      error    too many spaces inside brackets  (brackets)
  8:16      error    too many spaces inside brackets  (brackets)
  8:21      error    too many spaces inside brackets  (brackets)
  24:20     error    too many spaces inside brackets  (brackets)
  24:25     error    too many spaces inside brackets  (brackets)
  52:6      warning  missing starting space in comment  (comments)

This probably won't fix Codeql. From what I can see:
https://github.com/tektoncd/cli/blob/main/.github/workflows/codeql-analysis.yml
We don't have spaces between bracket in cli.

/hold

@enarha I removed that temporarily. Let's recheck.

It looks like we have a competing PR: #494

I think we can safely close this because codeql-analysis was removed and it is still not working.


Add note regarding Files.ReadWrite and OneDrive buisness accounts

Fix #1474
cc @k-tsoi

Docs Build status updates of commit 7414e57:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-Forbidden.GitAuthorization] Error occurred when accessing GitHub. Details: (Unauthorized) Bad credentials

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 90fb7c4:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-Forbidden.GitAuthorization] Error occurred when accessing GitHub. Details: (Unauthorized) Bad credentials

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

The "contributor guides" are 403ing my account. I cannot resolve any issues with the OpenPublishing check.

The "contributor guides" are 403ing my account. I cannot resolve any issues with the OpenPublishing check.

If this policy is still blocking an admin can squash and merge.


[UI] Navigator Collapse Chevron Position

Current Behavior
The chevron is not responsive with respect to the aspect ratio.
https://user-images.githubusercontent.com/65453826/144587094-626c1ed0-c999-4b59-93bb-2e919e837ce7.mp4
Desired Behavior
The chevron should also hide when the navigator is fully collapsed/hidden accordingly to the window aspect ratio.
Screenshots/Logs

Environment

Browser: Chrome Safari Firefox
Host OS: Mac Linux Windows
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Platform: Docker Kubernetes

Contributor Guides and Resources

🎨 Wireframes and designs for Meshery UI in Figma
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

@sahilsuman933 Would you like to give this a shot?

@Chadha93 I would love to fix this issue. But it may take a few weeks to fix this issue cause this will be my first issue on Javascript. So if it isn't urgent, please assign me to this task.

@Chadha93 Can you please look into the video and tell me whether I have to make any other changes or not?
https://user-images.githubusercontent.com/34382211/144684068-a37cc231-059e-42f3-a089-65a97ac72e6f.mp4

@sahilsuman933 almost there, basically what needs to be done is that the chevron should hide with the drawer itself, we don't want to remove the chevron all together.

Yess +1 with @warunicorn19, @sahilsuman933 you just need to make changes with the positioning and breakpoints of chevron, not hiding.

@warunicorn19 @Chadha93
Yeah, I got your point. I need to do the following stuff:-
i) Hide that chevron in mobile.
ii) When the user clicks on the hamburger button, the chevron should be re-displayed with its functionality.
But I am not getting how I can hide the chevron when the user clicks on the outside (to close it) the navigation bar. That's the issue I am facing right now.

Sorry @Chadha93  and @warunicorn19  I am not able to solve this problem. I will learn to react after that I will solve this problem if someone didn't fix that issue till that time. Sorry once again.

I would like to take this up

Thanks for the heads up @sahilsuman933, Please go ahead @Prakhar-Agarwal-byte.


[move source language] Fix transitive deps for IR targeting

Motivation

Fixed issue where structs in function dep's signature were not added to the set of struct deps

Test Plan

New test
Cargo test

@bors-libra r=sblackshear

:pushpin: Commit 54a7a92 has been approved by sblackshear

:hourglass: Testing commit 54a7a92c10d8aa88ec1e6abf98421e51e56d36d8 with merge 3c98d2ea4aaee656755aa4492d701fa3786d701d...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sblackshear
Pushing 3c98d2ea4aaee656755aa4492d701fa3786d701d to master...


Linebreak

Hello
How to insert line break in d3-tip text?
Thanks!

Regular <br> helped. Tried &#013 \n


Rpc serializer fails when deploying to Azure

I have a set of code that runs remotely:
    let makeMashup (user1:string) (user2:string) =
        let mashup =
            match getValue user1 user2 with \\returns a (string*string*string) option
            | Some m -> m
            | None -> ("Error :(","","")
        async {
            return mashup
        }

This code works fine when I run it on my machine using Visual Studio 2015, but when I deploy it to Azure, it treats the response as not a tuple but a single string. I'm not sure what would be different on Azure to cause this issue.

Sorry, this ended up having to do with the files being deployed incorrectly and not websharper. For some reason the changes don't always seem to make it to the server.


keep-until label

Checking keep-until label, see https://intranet.giantswarm.io/docs/dev-and-releng/test-environments/#label-the-cluster
Checklist

[x] Update changelog in CHANGELOG.md.

Should the label not be keep-until ?

Should the label not be keep-until ?

My bad 🤦🏻, I'm was somewhere else 🤣

Are you updating the code as well ?

Thank you Marcus, I was totally ignoring Before as an option. This makes it much easier to read. Awesome!

To be honest, until I noticed you were returning in both cases, I'd have done it the same way.


Model Plugin - time-sync

What: A core "built-in" model plugin which synchronizes all the observations in the provided series into a series.
Why: So we can place all the outputs and impacts onto a grid which can then be aggregated up.
DoD:
[ ] Does the model meet the specification?
[ ] Does the model have complete test coverage, including edge cases, happy path and error cases?
[ ] Has documentation been written for someone writing an IMPL using this model?
[ ] Has the units.yml been updated to take into consideration the params used in this model

Config

start-time: The date-time to start the series.
end-time: The end time to finish the series.
duration: The number of seconds in each interval duration.
count: The number of buckets in the series.
weighting: The algorithm to use to weight the values in buckets, the default is time (the only current algorithm is time)

NOTE: Both start-time and end time cannot be provided at the same time, it's either one or the other.
Observation
List the variables this model expects in an input observation

N/A

Impacts
List the variables this model exports out as an impact

N/A

Behavior
Overview

Every component has a time series of observations but there is no guarantee they match is duration, times, overlap. No guarantee of any form at all.
This model define a global time series, with a fixed start and end time, consistent set of buckets of the same duration.
The goal of this model is to snap all the time series for all the components (where this model is configured on the pipeline) to that global time series.

Global Time Series
If start-time has been defined then we create a series which starts at the start time and then moves forward in time. Each bucket duration seconds long and there are count buckets. We start in the past and move forward in time.
If end-time has been defined then we create a time series which ends at end time and then create the time series by going backwards in time.
We suspect the most useful use case is to choose an end-time of now and go backwards rather than to choose a start time and go forwards but we provide both.
NOTE: A possible v2 feature might be a way for models to scan the whole graph and automatically determine the start-end times from the observations present in the system.
Normalization
The goal of this model is to snap the observations to this global time series.

[!note]
The output observation might be zero for a given time and duration. It means nothing was running then, so there could not be any emissions from the component.

An observation might be of a longer or smaller duration than the new globally defined duration or overlaps the new duration in some way. There can be many algorithms we can use to bucket/slice up the values, but a good default strategy is to use a weighting of time.
Example
Take, for example the below, it has mixed durations, some are 5, and some are 15mins.

Timestamp
Duration
Energy
Location
Grid
Operational

2023-07-06T00:00
15
43
west-us
500
4.7

2023-07-06T15:00
5
20
west-us
490
2.9

2023-07-06T20:00
5
18
west-us
470
2.8

If we had decided to bucket the outputs in 5 mins increments, we would specify a duration of 5 mins. How to normalize the buckets to 5 min durations?
This effectively boils down to a choice of what weighting to use. The simplest would be to weight by time. So the first duration is 15 mins long; if we wanted to visualize in 5 min buckets, we would divide the impacts by 3.

Timestamp
Duration
Energy
Location
Grid
Operational

2023-07-06T00:00
5
14.3
west-us
500
1.57

2023-07-06T05:00
5
14.3
west-us
500
1.57

2023-07-06T10:00
5
14.3
west-us
500
1.57

2023-07-06T15:00
5
20
west-us
490
2.9

2023-07-06T25:00
5
18
west-us
470
2.8

[!important]
The decision to weight an observation to the new duration or just copy it is determined by its aggregation param in the units.yaml https://github.com/Green-Software-Foundation/ief/blob/dev/src/config/units.yaml. If the aggregation is "sum" then we would divide it. If the aggregation is avg (or another) then we simply copy it. This needs further thought and clarification, there may be many other cases that we are not thinking about clearly here.

Assumptions
What are the core assumptions this model makes?

One core assumption is that a time weighting is the right approach.
Another assumption is that we can decide the weighting using the aggregation param in the units.yaml.

Limitations
In what situations is this model limited in it's function, behaviour, accuracy etc...
Example
Provide at least one example of some input config and observations. This is in pimpl format not rimpl format, so the config is the global config and all parameters must be present on the observation.
Input
config:
  start-time: 2023-07-06T00:00
  duration: 300
  count: 5
  weighting: time
observations:
  - timestamp: 2023-07-06T00:00
    duration: 900
    location: west-us
    energy: 42.9
    grid-ci: 500
    operational-carbon: 4.71
  - timestamp: 2023-07-06T15:00
    duration: 300
    location: west-us
    energy: 20
    grid-ci: 490
    operational-carbon: 2.9
  - timestamp: 2023-07-06T25:00
    duration: 300
    location: west-us
    energy: 18
    grid-ci: 470
    operational-carbon: 2.8

Output
config:
  start-time: 2023-07-06T00:00
  duration: 300
  count: 5
  weighting: time
impacts:
  - timestamp: 2023-07-06T00:00
    duration: 300
    location: west-us
    energy: 14.3
    grid-ci: 500
    operational-carbon: 1.57
  - timestamp: 2023-07-06T05:00
    duration: 300
    location: west-us
    energy: 14.3
    grid-ci: 500
    operational-carbon: 1.57
  - timestamp: 2023-07-06T10:00
    duration: 300
    location: west-us
    energy: 14.3
    grid-ci: 500
    operational-carbon: 1.57
  - timestamp: 2023-07-06T15:00
    duration: 300
    location: west-us
    energy: 20
    grid-ci: 490
    operational-carbon: 2.9
  - timestamp: 2023-07-06T25:00
    duration: 300
    location: west-us
    energy: 18
    grid-ci: 470
    operational-carbon: 2.8
observations:
  - timestamp: 2023-07-06T00:00
    duration: 900
    location: west-us
    energy: 42.9
    grid-ci: 500
    operational-carbon: 4.71
  - timestamp: 2023-07-06T15:00
    duration: 300
    location: west-us
    energy: 20
    grid-ci: 490
    operational-carbon: 2.9
  - timestamp: 2023-07-06T25:00
    duration: 300
    location: west-us
    energy: 18
    grid-ci: 470
    operational-carbon: 2.8

Story
As a user I want to be able to view time series of impacts and aggregate imapcts. In order to do this the data in the graph needs to be synchronized into consistent time buckets.
Rationale
In order to accurately aggregate over a graph, each component has to be cast onto a uniform time line.
Implementation details
please see this comment for up to date implementation plan https://github.com/Green-Software-Foundation/if/issues/320#issuecomment-1845560004
Priority
4/5
Scope
This will be a model plugin that operates over a single component using global config.
Size
1 day
What does "done" look like?
a model plugin exists that operates over a single graph node and redistributes impacts over a new time line. Unit tests have 100% coverage and all pass.
Does this require updates to documentation or other materials??
This will require model documentation plus explanation on the gSF website.
What testing is required?

Is this a known/expected update?
Discussed extensively among the core devs, with project leads and on the IF weekly calls.


Can't show image in vscode chat markdown panel

Extension sample
chat-sample
VS Code version
1.91 - VS Code Remote
What went wrong?
I've tried many ways to load the image file with no luck:
 const markdownStr = new vscode.MarkdownString();
        markdownStr.supportHtml = true;
        markdownStr.value='![image](https://westusdallestore.blob.core.windows.net/public/b52b7f8ff97ba775ff1f92587485c8d62d2cc0bb.png)';
		stream.markdown(markdownStr);

        const markdownStr1 = new vscode.MarkdownString();
        markdownStr1.supportHtml = true;
        const imagePath = vscode.Uri.from({ scheme: 'https://', path: "westusdallestore.blob.core.windows.net/public/b52b7f8ff97ba775ff1f92587485c8d62d2cc0bb.png" });
        markdownStr1.value=`![image](${imagePath})`;
        stream.markdown(markdownStr1)
        stream.markdown(`![image](https://westusdallestore.blob.core.windows.net/public/b52b7f8ff97ba775ff1f92587485c8d62d2cc0bb.png)`)
        stream.markdown(`![image](file:///tmp/chat-agent-dalle/9fa80e2015fac7bdb84d1e4248e15b9469c348be.png-small.png)`)

Images from remote domains are only rendered if the user has added that domain to their trusted domain list- run the command "Manage Trusted Domains" to configure this. In the future I'd like to render something more helpful, like a button to load the image.
The local image should work though. My "dall-e" chat participant actually does this. Rendering as vscode-file is expected. Maybe you can get a clue from the network tab? Maybe it works as an absolute path instead of a file URI?


Changed calls to endsWith in JS code to use match instead.

Using endsWith was throwing undefined method error in console in Chrome and toolbar buttons were not working.
#1465
@AparnaKarve can you please test this.
@dclarizio please test/review.

@h-kataria @dclarizio Verified the fix. Now, it works well in both - Chrome and Firefox.


'make test' is really slow

Our test-go.sh script invokes 'go test' serially for each pkg - currently taking 2 minutes on my laptop.  Running a single 'go test' for all pkgs cuts the time down to 45 seconds.  Even running with -race is only 1:15.
As far as I can tell, the only time we HAVE to run serially is when coverage is on.
Does anyone have time to fix this?

I'd created #4686 on Friday to fix this, though it's not yet been reviewed.

I cobbled together #4717 but I'll review yours since it is probably better
:)
On Sun, Feb 22, 2015 at 12:36 PM, Jeff Grafton<EMAIL_ADDRESS>wrote:

I'd created #4686
https://github.com/GoogleCloudPlatform/kubernetes/pull/4686 on Friday
to fix this, though it's not yet been reviewed.
--
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/4713#issuecomment-75456281
.


Use stable ID generation in HTML5 for choicetables, properties tables

Description
Earlier PR#2276 stabilized most generated IDs except for choicetables & properties tables. This PR adds stable ID generation for choicetables & properties tables.
Motivation and Context
Amends #2276 for improved stability of generated HTML5 output.
How Has This Been Tested?
Generated output building the WebAssign help content to verify the change.
Type of Changes

Bug fix (non-breaking change which fixes an issue)

Checklist

I have signed-off my commits per http://www.dita-ot.org/DCO.

Original issue made obsolete by #2811


Cube does not implement Aabb

Is this intentional?

Cube is a collision primitive, not a bounding volume. Aabb3 is the bounding volume.

But is a Cube not conceptually an Aabb3? Why does it not implement its behaviour?


ETELEGRAM 400 Bad Request: host is invalid

Searching through the issues, I haven't found any matching my problem.
I used Puppeteer to screenshot webpages and send them to users using the bot.
But I keep getting this:
Unhandled rejection Error: ETELEGRAM: 400 Bad Request: host is invalid     at request.then.resp (d:\Documents\Bots\node_modules\node-telegram-bot-api\src\telegram.js:280:15)     at tryCatcher (d:\Documents\Bots\node_modules\bluebird\js\release\util.js:16:23)     at Promise._settlePromiseFromHandler (d:\Documents\Bots\node_modules\bluebird\js\release\promise.js:517:31)     at Promise._settlePromise (d:\Documents\Bots\node_modules\bluebird\js\release\promise.js:574:18)     at Promise._settlePromise0 (d:\Documents\Bots\node_modules\bluebird\js\release\promise.js:619:10)     at Promise._settlePromises (d:\Documents\Bots\node_modules\bluebird\js\release\promise.js:699:18)     at _drainQueueStep (d:\Documents\Bots\node_modules\bluebird\js\release\async.js:138:12)     at _drainQueue (d:\Documents\Bots\node_modules\bluebird\js\release\async.js:131:9)     at Async._drainQueues (d:\Documents\Bots\node_modules\bluebird\js\release\async.js:147:5)     at Immediate.Async.drainQueues (d:\Documents\Bots\node_modules\bluebird\js\release\async.js:17:14)     at runCallback (timers.js:781:20)     at tryOnImmediate (timers.js:743:5)     at processImmediate [as _immediateCallback] (timers.js:714:5)
This started out when I added the sendPhoto function.

Post the bot code. R you somehow trying to pass in a URL as a para to sendPhoto ?

I'll post the code once I get home. I didn't pass URL, I set a relative path to file instead.

Hi, I got the same error when I tried to send local path of image but path was incorrect. Try to use fs.createReadStream and you will get error in case of file is not found.


Missing Checkpoints

Hi,
Thanks for the great implementation. I was wondering when the rest of the checkpoints were going to be released.

Hi, thank you for the kind comment.
We have released all the best models for each set of local feature extractors tested and reported in our manuscript. For example, for SuperPoint we released weights for the two best OpenGlue models: one used SuperPoint with KITTI, and the other used weights trained on the COCO dataset.
For SIFT descriptors, on the other hand, you can find two models: rotation and with scale-rotation included during training. The combination of rotation and scale showed better results in our experiments, but the difference was not severe, so we decided to include both options.

I am getting very bad results with the coco version of openglue. I used this configuration :
name: 'SuperPointNetBn'
descriptor_dim: &DIM 256
parameters:
max_keypoints: 2048
descriptor_dim: *DIM
nms_kernel: 9
remove_borders_size: 4
keypoint_threshold: 0.005
weights: '/home/ostap/projects/pytorch-superpoint/logs/superpoint_coco_heat2_0/checkpoints/superPointNet_170000_checkpoint.pth.tar`
For the kitti version, the results are better but very far from the matching produced by superGlue, I used this configuration :
data:
root_path: '/datasets/extra_space2/ostap/MegaDepth'
train_list_path: '/home/ostap/projects/superglue-lightning/assets/megadepth_train_2.0.txt'
val_list_path: '/home/ostap/projects/superglue-lightning/assets/megadepth_valid_2.0.txt'
test_list_path: '/home/ostap/projects/superglue-lightning/assets/megadepth_valid_2.0.txt'
batch_size_per_gpu: 2
dataloader_workers_per_gpu: 4
target_size: [ 960, 720 ]
val_max_pairs_per_scene: 50
train_pairs_overlap: [0.15, 0.7]
inference:
match_threshold: 0.2
superglue:
descriptor_dim: &DESCRIPTOR_DIM 256
laf_to_sideinfo_method: 'none'
positional_encoding:
hidden_layers_sizes: [32, 64, 128]
output_size: *DESCRIPTOR_DIM
attention_gnn:
num_stages: 9
num_heads: 4
embed_dim: *DESCRIPTOR_DIM
attention: 'softmax'
use_offset: False
dustbin_score_init: 1.0
otp:
num_iters: 20
reg: 1.0
residual: True
features:
name: 'SuperPointNetBn'
descriptor_dim: &DIM 256
parameters:
max_keypoints: 1024
descriptor_dim: *DIM
nms_kernel: 3
remove_borders_size: 4
keypoint_threshold: 0.005
weights: '/home/hc266914/workspace/pose_estimation/OpenGlue/experiment_1/superPointNet_50000_checkpoint.pth.tar'
Are these configurations the right ones ? and is there a way to get the a version of openglue with the exact same architecture as superglue without any changes (like the positional encoding) ?


Create "non-disabled" data for every local authority

Currently each LA has the data calculated for the number of people with disabilities, but not without disabilities.
Previously this was understood (wrongly) to be included in all the other data, but these are totals for the other aggregates and disaggregations.
Each LA needs the calculations for "non-disabled" while every other dimension is "Total" (blank).

@Antonio-John  I am going to pick this up

Notes on investigation:
I am going to work out if the columns add up with each other.
1) Does  "Day-to-day activities limited a lot" +   "Day-to-day activities limited a little" ==   'Day-to-day activities not limited' ?
2) If not, do any or all of these add up to the total population for each OA?

Creating a population df from the la_pop_df with la_pop_only = la_pop_df[['OA11CD','pop_count']]
merging with disab_with_total_pop = la_pop_only.merge(disability_df, on="OA11CD")

Running inquiries:

any(disability_df.iloc[:,1] + disability_df.iloc[:,2] == disability_df.iloc[:,3])

False
So that means that none of the rows pass test (1)

We now have a "non-disabled" column

More changes need to be made so this comes through in the results.

The non-disabled stats are now feeding through into the outputted csv

We have been looking at the definitions of disability to make sure this calculation is consistent with GSS harmonized disability data.
To understand the data, we looked at the questions and their possible responses in the Measuring disability for the Equality Act 2010 harmonisation guidance.

Question
Response options

Do you have any physical or mental health conditions or illnesses lasting or expected to last 12 months or more?
Yes / No

Does your condition or illness\do any of your conditions or illnesses reduce your ability to carry-out day-to-day activities?
Yes, a lot Yes, a little No

People who will be considered "Non-disabled":

Person who answers no to the first question
Person who answers yes to the first question, but no to the second question.

"A person who says yes, they have physical or mental health condition(s) or illness(es) lasting or expected to last for 12 months or more, but it doesn’t restrict their activity are non-disabled."

Therefore the
"Total people with disabilities" = "Day-to-day activities limited a lot" + "Day-to-day activities limited a little"
or
disab_total = disab_ltd_little + disab_ltd_lot
And the total
"Non-disabled" = "Total Population" - "Total people with disabilities"
or
non-disabled = pop_count - disab_total

I am happy with that the new non-disabled data is being calculated correctly. However the code is repetitive, so I will create a ticket to clean that up.
https://github.com/ONSdigital/SDG_11.2.1/issues/187


Cannot find jupyter executable

kerwin@XUHENGXIAO D:\Program Files\Racket
$ raco iracket install
Warning: found different racket.exe command in executable search path
found in search path: "D:\Program Files\Racket\.\racket.exe"
currently executing:  "D:\Program Files\Racket\racket.exe"
Cannot find jupyter executable.
kerwin@XUHENGXIAO D:\Program Files\Racket
$ jupyter --version
jupyter core     : 4.6.3
jupyter-notebook : 6.0.3
qtconsole        : 4.7.5
ipython          : 7.16.1
ipykernel        : 5.3.2
jupyter client   : 6.1.3
jupyter lab      : 2.1.4
nbconvert        : 5.6.1
ipywidgets       : 7.5.1
nbformat         : 5.0.7
traitlets        : 4.3.3

kerwin@XUHENGXIAO D:\Program Files\Racket
$ raco iracket install
Warning: found different racket.exe command in executable search path
found in search path: "D:\Program Files\Racket.\racket.exe"
currently executing: "D:\Program Files\Racket\racket.exe"
Cannot find jupyter executable.
kerwin@XUHENGXIAO D:\Program Files\Racket
$ jupyter --version
jupyter core : 4.6.3
jupyter-notebook : 6.0.3
qtconsole : 4.7.5
ipython : 7.16.1
ipykernel : 5.3.2
jupyter client : 6.1.3
jupyter lab : 2.1.4
nbconvert : 5.6.1
ipywidgets : 7.5.1
nbformat : 5.0.7
traitlets : 4.3.3

I read source code , found below
(define (cmd:check args)
(command-line
#:program (short-program+command-name)
#:argv args
#:once-any
[("--jupyter-exe") jupyter
"Use given jupyter executable"
(use-jupyter-exe jupyter)]
#:args ()
(with-handlers ([exn:fail:user?
(lambda (e) (printf "~a\n" (exn-message e)))])
(do-check-iracket))))
--jupyter-exe !!!
so : raco iracket install --jupyter-exe "D:\Anaconda3\Scripts\jupyter.exe"   , it work well .


Add option to copy tags in copy-based creation mode

The current implementation copies only the size of the selected box. It would be great if we could allow copying other attributes as well (like in copy/paste scenario).
Maybe we just should do it by default? #6

Seems like a reasonable default to me

Covered in #15


about using pretrain model to continue training on the other data

i want to ask should i change the n_class（the number of speaker）， if i only change the n_class，it will go to error because of the difference of embedding size when loading the pretrain model.Thank you so much!

If you change the n_class, the classification layer is different. You should load the pretrain model without the classification layer only.

Hi, I am trying the same thing, and should I change the code so that it can load model without the classification layer? Because I think that is not implemented.


Remove IStringMethods.cat

Summary:
 IStringMethods.cat parameter too complicated and can only support a limited form efficiently. Remove for now.
But support "+" operator on String column -- which is most useful.
We may want to support cat method with simplified
API in the future.
Differential Revision: D31601427

As @OswinC  pointed out, we can simulate cat with + fairly straightforward. Here is the example code:
def cat(cols: List[IStringColumn], sep: str = ""):
  to_join = [cols[0]]
  for i in range(1, len(cols)):
    to_join.append(sep)
    to_join.append(col[i])
  return reduce(operator.add, to_join)


added infrastructure specs for community calendar

/assign @jlewi

We should reuse this project not just for sync'ing the calendar but also sync'ing Google groups (kubeflow/internal-acls#22).
So we should pick a more appropiate name then calendar. Maybe "kf-infra-gitops"

@karlschriek any update on this?

@jlewi have pushed changes as suggested

Relates to https://github.com/kubeflow/community/issues/274

/lgtm
/approve


doors breaking and opening by itself

https://user-images.githubusercontent.com/67587410/113575679-8933f100-961e-11eb-8c9a-7603d35e146b.mp4

I can't see the video, I can only hear it

I can't see the video, I can only hear it

If you download and play it you can actually see it, i also don’t know why i/you can’t see it on the site.


bug: AwsSolutions-RDS10 and AwsSolutions-RDS15 are duplicates

What is the problem?
Looks like AwsSolutions-RDS10 and AwsSolutions-RDS15 are duplicates. They're using the same rule behind the scenes:

RDS10
RDS15

Reproduction Steps

Create Aurora Cluster with disabled termination protection in your stack.
Add AwsSolutionsChecks aspect to your stack.
Synthesize the stack.

What did you expect to happen?
One error about disabled termination protection for the Aurora Cluster.
What actually happened?
Two errors about disabled termination protection for the Aurora Cluster.
cdk-nag version
2.14.45
Language
Typescript
Other information
No response

Thanks for reporting 🤦!
It looks like we can just get rid of AwsSolutions-RDS15 without causing any problems


Remove unnecessary imports

Description
Remove unnecessary imports from the helper file, because helper doesn't use these modules.
Jira Ticket
https://bloomtechlabs.atlassian.net/browse/BL-1039
Type of Change

[x] Bug fix

Checklist

[x] My code follows PEP8 style guide
[x] I have removed unnecessary print statements from my code
[x] I have made corresponding changes to the documentation if necessary
[x] My changes generate no errors
[x] No commented-out code
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

Loom Video
Changes too small to make a loom video.

The only change I would make is to remove the boilerplate (template) code in the description and replace with why the imports were unnecessary, put a link to the Jira ticket in the description, and it's good to go 👍

Changes accepted and implemented!


Add button

Todo

[ ] check if the button appears
[ ] check if the button shows a message when pressed
[ ] check if the button blurs the post

Motivation
To blur the image that ocr/ backend couldn't detect.
Summary of changes
added the CSS file for the button, modified js file based on #45
Attached GitHub issue
Checklist

Documentation

[ ] Updated the readme documents (README.md etc.)
[ ] New functions and methods have additional comments added to document their usage

Local Build

[ ] Ran all pre-commit hooks pre-commit run --all-files
[ ] Extension has been tested to build correctly cd extension && yarn && yarn build
[ ] Extension test suite has been run locally cd extension && yarn && yarn test

GitHub

[x] Target branch has been set correctly
[ ] PR has been rebased onto target branch
[ ] PR has been assigned an owner
[ ] Author has performed a self-review of the code
[ ] Removed the WIP message from the top of this PR

Codecov Report

Merging #46 (4289752) into main (45d7b5a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   75.19%   75.19%
=======================================
  Files           8        8
  Lines         262      262
  Branches       41       41
=======================================
  Hits          197      197
  Misses         42       42
  Partials       23       23

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Closing this PR as this was left by the previous group. All new changes must be made to the Release 1.0 branch.


FormFlow Template attribute throws exception for fields of type string

System Information

SDK Pletform: .NET
SDK Version: 3.8.1
Development Environment: localhost

Issue Description
Today I updated BotBuilder to version 3.8.1. Unfortunately since then I get the following exception for an FormFlow dialog which before was running like a charm.

Missing resources System.Collections.Generic.List`1[System.String]

I identified that this error is raised when calling the .Build() method on the FormBuilder due to the following reason:
In my FormFlow dialog I am using the following fields and the following attributes
[Pattern(@"^[\w\s]+$")]
[Template(TemplateUsage.NotUnderstood, "\"{0}\" ist kein gültiger Wert für den Rezeptnamen.")]
[Prompt("Wie soll das neue Rezept heißen?")]
[Describe("Rezept")]
public string RecipeName;

I found out that the attribute causing this exception is the [Template(...)] attribute. I also found out that this problems only occurs for fields of type string (I've got many other fields of many different types in my FormFlow dialog which also use the [Template(...)] attribute, but they don't make any problems).
Before I was using BotBuilder version 3.3.3. There the problem did not occur. Thus I assume that something must have changed.
My question now is: is this a bug or a feature. If it is a feature why do you not support the [Template(...)] attribute for strings anymore. This was quite useful for us.
Example Code
(see above)
Steps to Reproduce

Create a new FormFlow dialog including the string field and attribute I have posted above.
Debug FormBuilder().Build()

Expected Behavior

Missing resources System.Collections.Generic.List`1[System.String]

exception is thrown.

The dialog in question uses resource files to generate the prompts and answers in different languages.
These resources files were generated using the rview tool mentioned in the documentation.
For, at least to me unknown reasons, the tool does not generate a resource key for the NotUnderstood template from the RecipeName property. In the previous sdk version this seems to have been ignored. Now the formflow dialog appears to be stricter and throws the error.
Manually adding the resource key
NotUnderstood;RecipeName;TEMPLATE

solved the error.

Thank you for reporting this issue. I'm glad you've found a solution!


tests/drivers/i2c/i2c_api

Describe the bug
enable the i2c_api test with attached patch, I find that the twrke18f board missing defines the int2 gpio for the FXOS8700_0
To Reproduce
Steps to reproduce the behavior:

mkdir build; cd build
cmake -DBOARD=twr_ke18f ..
make
See error

Expected behavior
missing in2_gpio define on twrke18f board
Impact
What impact does this issue have on your progress (e.g., annoyance, showstopper)
Screenshots or console output
/home/shared/disk/zephyr_project/zephyr/drivers/sensor/fxos8700/fxos8700.c:569:15: error: 'DT_NXP_FXOS8700_0_INT2_GPIOS_CONTROLLER' undeclared here (not in a function); did you mean 'DT_NXP_FXOS8700_0_RESET_GPIOS_CONTROLLER'?
  .gpio_name = DT_NXP_FXOS8700_0_INT2_GPIOS_CONTROLLER,
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
               DT_NXP_FXOS8700_0_RESET_GPIOS_CONTROLLER
/home/shared/disk/zephyr_project/zephyr/drivers/sensor/fxos8700/fxos8700.c:570:14: error: 'DT_NXP_FXOS8700_0_INT2_GPIOS_PIN' undeclared here (not in a function); did you mean 'DT_NXP_FXOS8700_0_RESET_GPIOS_PIN'?
  .gpio_pin = DT_NXP_FXOS8700_0_INT2_GPIOS_PIN,
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
              DT_NXP_FXOS8700_0_RESET_GPIOS_PIN
zephyr/drivers/sensor/fxos8700/CMakeFiles/drivers__sensor__fxos8700.dir/build.make:62: recipe for target 'zephyr/drivers/sensor/fxos8700/CMakeFiles/drivers__sensor__fxos8700.dir/fxos8700.c.obj' failed
make[2]: *** [zephyr/drivers/sensor/fxos8700/CMakeFiles/drivers__sensor__fxos8700.dir/fxos8700.c.obj] Error 1
CMakeFiles/Makefile2:2310: recipe for target 'zephyr/drivers/sensor/fxos8700/CMakeFiles/drivers__sensor__fxos8700.dir/all' failed
make[1]: *** [zephyr/drivers/sensor/fxos8700/CMakeFiles/drivers__sensor__fxos8700.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

Environment (please complete the following information):

OS: (e.g. Linux)
Toolchain (e.g Zephyr SDK)
Commit SHA

@henrikbrixandersen  @MaureenHelm

0001-enalbe-i2c_api-for-twrke18f.zip

need config CONFIG_FXOS8700_TRIGGER_NONE=y

0001-enalbe-i2c_api-for-twrke18f.zip

seems the device driver changed, I need update my test settings

The first part of handling this was already submitted in #16116.


Fix number property accessors, small tslint fixes

Property keys are currently compared using strict equality. This should be loose equality since that's how they work natively too.
Example:
const obj1 = { 2: 'text' };
const obj2 = { '2': 'text' };
obj1[2] === obj1['2'] // true
obj2[2] === obj2['2'] // true
obj1[2] === obj2[2] // true
obj1['2'] === obj2['2'] // true

This PR fixes that. Closes #474
Also disabled formatOnSave and set the tslint sdk path in .vscode/settings.json because otherwise any contributer with other global settings will have to manually change this in the settings.json (or it's impossible to save any file with the correct formatting). And fixed a small linting error.

@jdanyow Done. I had to make a few additional changes to properly "expose" the numeric property option in the api.
The test should verify that any combination of passing number/string property to the validator, against an underlying object with either number/string property, works the same.
The final validation message simply shows the property name as it was defined in the rule (regardless of the property key type in the object).
Is that ok?

looks great! :dancing_women:


New Post about Design Patterns

Hey guys,
This PR adds a new article about the Template design pattern.
Please check it out, thanks!

Thanks for your comments @mauro-oto. I just updated this PR.


Default requests timeouts are too short and can't be configured easily

The default is 10s for read and 60s for connect, neither of which makes much sense considering that the server is going to be an AWS API Gateway which has a timeout of 30s max. We should default to 40s for read (so the server has a chance to send the 504 back in case it times out) for read and 10s for connect. I don't see why a longer connect timeout is necessary.
This should also be easier to configure. I would think via environment variables so it can be changed at runtime and hanging the default timeout off the client instance rather than _ClientMethodFactor.

Consensus is 20 for connect and 40 for read (so that API Gateway can send back the 504 when it times out)


"Disable Device Access for Universal Apps" is missing formally included value

The registry category "Disable Device Access for Universal Apps" used to include the value: {21157C1F-2651-4CC1-90CA-1F28B02263F6} which relates to letting apps read or send messages (text or MMS).
Is this removed by design?

These registry settings are no longer implemented; however, some were omitted from previous versions of the script because they caused issues during the OOBE and setup process.


Leave the previously selected IdPs in the 'select another IdP' list

In the previous situation the previously selected IdPs where only shown in the shortlist. This is not very intuitive when clicking the 'select a different IdP' link from the short list. As the IdPs you used before are no longer available for selection.

Merging this despite the dailing cypress tests, will fix those on my next PR


[Bug]: RemoteState.Guard will return success for a null value in release mode and error in debug mode

Describe the bug
If you pass a future to RemoteState.Guard that returns a null value, in release mode it'll go through as a success but in debug mode the assert that the value can't be null will be prevent it and an error state is returned.
Expected behavior
An error state should be returned for for both instances or a different state might need to be addressed.
Screenshots
N/A
Smartphone (please complete the following information):

No device specific

@chadrickman that assertion sounds like it is happening inside the dart language.  Also, is null a valid value?

@chadrickman thinking about it further, I'm not sure if this is a bug so much as it is just not conveying that the return type could be nullable.
Pretending that there is a future that can return an int or null
  Future<RemoteState<int>> getCount() async {
    RemoteState<int> state = RemoteState.loading();

    state = await RemoteState.guard(() => _counterClient.getCount());

    return state;
  }

In this case, if _counterClient.getCount() can return null then it is probably better to change the function to forward the nullable value or to handle the null scenario explicitly.
  Future<RemoteState<int>> getCount() async {
    RemoteState<int> state = RemoteState.loading();

    /// getCount returns Future<int?> forcing us to handle null.
    state = await RemoteState.guard(
        () => _counterClient.getCount().then((count) => count ?? 0));

    return state;
  }

/// Example where we forward null up.
  Future<RemoteState<int?>> getCount() async {
    RemoteState<int?> state = RemoteState.loading();

    /// getCount returns Future<int?> so we just forward null up the chain.
    state = await RemoteState.guard(
        () => _counterClient.getCount());

    return state;
  }


⚠ Anthelion has degraded performance

In 289a312, Anthelion ($ATH) experienced degraded performance:

HTTP code: 200
Response time: 2501 ms

Resolved: Anthelion performance has improved in 1c862d7 after 410 days, 20 hours, 51 minutes.


Investigate how to compare fonts with/without name changes

Roozbeh suggested on another issue
(https://github.com/googlei18n/noto-fonts/issues/301#issuecomment-110101465)
"For comparing fonts when one has glyph names and another doesn't, it may be a
good idea to convert the name table to format 3.0 and then compare then. The
subsetter can do that."
Look into this.

Moved from googlei18n/noto-fonts#324


Renaming default branch from 'master' to 'main'

Following https://github.com/github/renaming, I've renamed the default branch on CTRLF from master to main. You can update your local copy following these instructions:
git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a

Let me know if this change causes any disruption and I can see what I can do to mitigate!

Looks like this went over well.


with_format() function returns bytes instead of PIL images even when image column is not part of "columns"

Describe the bug
When using the with_format() function on a dataset containing images, even if the image column is not part of the columns provided in the function, its type will be changed to bytes.
Here is a minimal reproduction of the bug:
https://colab.research.google.com/drive/1hyaOspgyhB41oiR1-tXE3k_gJCdJUQCf?usp=sharing
Steps to reproduce the bug

Load the image dataset
apply with_format(columns=["text"])
Check the type of images in the "image" column before and after applying with_format

Expected behavior
The type should stay the same, but it does not
Environment info
datasets==2.14.6

Thanks for reporting! I've opened a PR with a fix.


[7.x] Add renameForeignKey method to MSSQL Grammar

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Pip errors

Collecting<EMAIL_ADDRESS>(from -r requirements.txt (line 5))
Cloning https://github.com/KAIR-BAIR/nerfacc.git (to revision v0.5.2) to c:\users\user\appdata\local\temp\pip-req-build-5b9xhi73
Running command git clone --filter=blob:none --quiet https://github.com/KAIR-BAIR/nerfacc.git 'C:\Users\user\AppData\Local\Temp\pip-req-build-5b9xhi73'
Running command git checkout -q d84cdf3afd7dcfc42150e0f0506db58a5ce62812
Resolved https://github.com/KAIR-BAIR/nerfacc.git to commit d84cdf3afd7dcfc42150e0f0506db58a5ce62812
Running command git submodule update --init --recursive -q
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [21 lines of output]
Traceback (most recent call last):
File "C:\Users\user\threestudio\stable\Lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 353, in
main()
File "C:\Users\user\threestudio\stable\Lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\user\threestudio\stable\Lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\user\AppData\Local\Temp\pip-build-env-4llz8r2l\overlay\Lib\site-packages\setuptools\build_meta.py", line 325, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=['wheel'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\user\AppData\Local\Temp\pip-build-env-4llz8r2l\overlay\Lib\site-packages\setuptools\build_meta.py", line 295, in _get_build_requires
self.run_setup()
File "C:\Users\user\AppData\Local\Temp\pip-build-env-4llz8r2l\overlay\Lib\site-packages\setuptools\build_meta.py", line 480, in run_setup
super(_BuildMetaLegacyBackend, self).run_setup(setup_script=setup_script)
File "C:\Users\user\AppData\Local\Temp\pip-build-env-4llz8r2l\overlay\Lib\site-packages\setuptools\build_meta.py", line 311, in run_setup
exec(code, locals())
File "", line 123, in
File "", line 27, in get_extensions
ModuleNotFoundError: No module named 'torch'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
[notice] A new release of pip is available: 23.2.1 -> 23.3.2
[notice] To update, run: python.exe -m pip install --upgrade pip

I'm running into this too, where my system is Fedora 38 and the system python is python3.11.
I've had trouble with python 3.11 working with various AI projects since it seems many assume python 3.10.
I've set up python 3.10 virtual environments for other projects and they work fine.
If I activate this project's virtual environment and then invoke python manually, I can 'import torch' at the command prompt and it works since torch is installed.
However, when I run pip install -r requirements.txtin the same terminal session, the import torch fails.
I'm wondering if there's somewhere in the installer code for this package there's an explicit invocation of /bin/python or /bin/python3 (or /usr/bin) instead of just invoking puthon and relying on $PATH to be set. In my case, that gets me python 3.11, which would fail.
Just sort of wondering if this might be what's going on.

I could try to use python 3.10 I am windows though

I got the same issue but after downgrading pip to 23.0.1, it solved. I'm using python 3.11.

Im having the same issue python 3.12 pip 24.0.0

Same issue with python 3.10.12 pip 24.1.2

Same issue with python 3.10.12 pip 24.1.2

downgrading to pip to 23.0.1 solved it