NTR: Mosquito Magnet Liberty Plus trap

parent: Mosquito Magnet trap
label: Mosquito Magnet Liberty Plus trap
definition: An arthropod trap that is manufactured by the American Biophysics Corporation and is designed with counterflow technology, allowing it to draw air into the device as it expels carbon dioxide, in order to draw in arthropods attracted to it.
definition source: VEuPathDB | J Am Mosq Control Assoc, 26(3):287–294
term editor: John Judkins
contributor: Sarah Kelly | Jie Zheng | John Judkins

More feedback from domain experts is needed before submitting this definition. Will reopen then.

Updating request:
Label: Mosquito Magnet Liberty Plus trap
Definition: An arthropod trap that is designed to emit a combination of carbon dioxide, heat, water, and oct-1-en-3-ol attractants while simultaneously using suction to trap arthropods. This trap has the same design as the Mosquito Magnet Pro trap but is smaller, is more lightweight, and uses a main line electricity supply instead of propane to power itself. Both use propane to produce the arthropod attractor.
Parent: Mosquito Magnet trap
I also request changing the label for Mosquito Magnet trap to 'Mosquito Magnet Pro trap'.

Discussed 2022-08-15. No objection to the change/addition.


Fix order set function

https://github.com/ccsm-cds-tools/ccsm-cds-with-tests/blob/main/cql/OrderSetLibrary.cql#L27
This element should be "text" since this is supposed to be a CodeableConcept.

This was resolved in https://github.com/ccsm-cds-tools/ccsm-cds-with-tests/commit/762b5b75ef1c6fb2067e034d8c1698be1b0c5d72.


Opening the sidebar and clicking a link makes the sidebar fullscreen and impossible to close

Fixed, now it just pushes onto the nav stack!


Plan for Solutions

Plan for Solutions in FlashDevelop
Definition
A solution:

is an ordered list of projects,
is a file distinct from the projects, ie. defined in a new file (.fdsln),
is optional and automatic (the solution file is implicit).

Design of solutions should aim for a "minimum viable product" with little to no UI creation and changes.
Creation
Solution context is automatic
Opening a project file (as for a solution file) closes the current solution and defines a new implicit solution context.
User actions:

Project > New Project...
Project > Import Project...
Project > Open Project...
or using the Recent Projects and Solutions lists.

Solution file appears when required
Adding a second project to an implicit solution (see Population section) should cause the automatic creation of a solutions file with the same name and location as the first project.
It is up to the user to move and edit the solution file to another location if he prefers.
Recent projects list
Solution files should be included in the Recent Projects lists which we should now call Recent Projects and Solutions.
To handle seamlessly the automatic "promotion" of a project to a solution we could:

when opening a project file, automatically favor a solution file (limited to the same name and location?),
or replace the history entry for the project file by the solution file in the list of Recent Projects and Solutions.

Population
Adding projects to a solution should go through additional menu actions, like:

Project > Add > New Project...
Project > Add > Existing Project...
or from the Solution properties dialog,
or possibly in the Solution node's context menu.

Q: Should new projects be inserted before or after the main project in the list? Maybe existing projects are added before (ie. adding a library dependency) and new projects added after (ie. creating a new module).
Managing the list
Ordering/removing/adding projects would be managed through a simple dialog.
Let's start with a mock-up.
Solution properties
Xml / json / yaml / ini format?
The format should be simple to edit manually and reuse code and practices already present in FlashDevelop (ie. maybe not yaml if that means adding yet another piece of code / library in the codebase).
Editing manually the solution file could trigger a (more or less smart) reloading of the solution.
Properties

dependencies: to keep things simple we should let the user manage the dependencies as one flat list; we don't want to resolve per-project dependencies,
build: what projects should be built? some dependencies don't need to be built,
run: one (or none) project is the Run target. By default it would be the initial project.

Future improvements
We want to avoid any complication at first but we can avoid locking ourselves in another "Debug/Release" locked situation.

Solution-wide properties/arguments?
Multiple solution "targets"? like allowing desktop VS mobile configurations.

Debug/Release, target build
For our sanity the build configuration is expected to be shared by all the projects.

Debug/Release can be safely applied to all the projects,
Target build is subtly more problematic because of targets like OpenFL or AIR: the target build combo is pre-populated depending on the project type and we will have to use an arbitrary project as reference (the first?).

Q: Are there objections?
Project panel
We need to mock up the project panel and thing it through:
will it work with a 100 projects in one solution?
Solution node and project properties
It seems useful to have a Solution node, it would allow the Properties button to be contextual to the selected node (solution or project).
References
Keeping the explorable References folder in each project isn't likely to scale well. Maybe being clever and keeping only one reference subtree for all the occurences? But it's complicated by the fact that you can choose the main class of one project inside a reference tree (re-render?).
Q: How do we solve that considering we can have etherogenous (PHP + Flash + Haxe) or highly redundant (100 Flixel projects) cases?
Multiple projects in the same folder
It is a common practice in the FlashDevelop world to put several projects in the same folder (or subfolders) - we should probably not support that as it would greatly complicate the projects tree and project tracking (see below).
Projects tracking
Active project
FlashDevelop completion is suited to work with one active project.
Switching the active project is a light enough operation considering we won't re-explore the filesystem so we should do (at first) a simple tracking of the current document:

opening a project/solution sets the main project as active project,
switching to a class (AS, Haxe,...) directly under one project's folder sets the active project,
switching to any other file or class in an external reference should NOT change the active project.

Q: how do we hint the active/runnable project(s) in the project panel?
Projects to build
At first we could go with building all the projects (unless explicitly set as "do not build") but it might be reasonable to track "any filesystem change" under one project folder as a reason to rebuild it.
Other aspects
Application title
Should reflect the name of the solution file, if one is explicitly used.
Find in files
Do we add a <Solution> case for the Top Folder search option?

We are working on a quite big project with lots of project files. We have shared stuff (libraries, shared project code etc) that is used on all projects . If we now refactor/rename/move classes in the shared sources, the references/imports in the current project are resolved, but not in the other projects (which is completely understandable from what I know about the current setup).
I saw this ticket which has a plan to nail this issue. I wonder if there is something already available that could solve this issue. For me correct refactoring across projects is the most important, I don't need imports or search on other files in that project.

@markknol can you describe (maybe privately) the structure of your project? Even with solutions, considering how inefficient FD refactoring is we would probably not risk going much further than what it does - unless we get to use more compiler services of course.

What's the status on this feature, is it in dev for FD 6?
I wanted to know, are these Solutions really such a useful feature?
My project include several nested projects, I've created a separate FD project for each of them, using Recent projects to switch between them, I accomplish building with Ant build scripts, which are quite easy to modify and quite powerful, once I've figured out how to write them.
My thoughts are, maybe FD can have these new features:

Solution is a group of projects. Having a solution makes it convenient to select a (sub-)project, and see all the projects in a nice tree view.
Each project can have it's own Ant build file, maybe add some GUI editor for these. Projects that depend on other projects can reference their build files, again that GUI could offer editing the dependencies. Ant's uptodate task can be used in build files to recompile only if out of date.
I understand, of course, if you don't want to introduce a dependency on Ant. And doing all of that in native FD code will of course be faster - but could be a lot of work as well.


[Suggestion] More intuition settings

Using mooch or not according intuition buff.
Tks

Thanks for the feedback, ive added this in the new version.

Sorry for the mistake, now you can mooch only when under the effect of intuition


Create the ability to promote/copy/export questions and programs from Staging to Production

Is your feature request related to a problem? Please describe.
We aren't currently using staging due the complexity and time constraints required to create a program with a large number of questions, visibility conditions and eligibility criteria. It's not an efficient use of time to completely build an elaborate program in production and then rebuild it in production. Consequently, our production site is being used as a testing / vetting area. Because there is no ability to archive or delete programs, the programs page has become quite disorganized and cluttered. We'd love to use staging for it's intended purpose.
Describe the solution you'd like.
If it was possible to export/copy/promote questions and programs from staging to production, that would solve a several issues for us. Please also see issue #5806. The inability to promote is partially why we have a mess on our programs page.
What priority is this?
This has become a high priority for us. The problem is only compounding over time.
Associated civic entity
State of Arkansas
User Group
Program admins are impacted by this.
Done when:
A simplified method to transfer questions and programs from staging to production is developed.

+1 from Seattle

Duplicate of #5034


fix(designer): Add gateway service config to allow hiding subscription dropdown for gateway connection creation

This change adds the option to send a custom config as part of gateway connection creation. As such we can specify with the config whether we want the subscription dropdown to be enabled (default) or not. When it is disabled through the config, the gateway dropdown should remain enabled and visible. The new methods and params are optional and will not affect current behavior.

Please Include Screenshots or Videos of the intended change:

AB#25351748

@microsoft-github-policy-service agree company="Microsoft"

@pranaydubeymicrosoft please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"


Does the paket version constraint >= download the next version up if it's not available?

I have the following version constraint in my packet.lock file
Arachne.Core (2.3.23)
  FParsec (>= 1.0.1)
  FSharp.Core (>= <IP_ADDRESS>)

I understand that this means that it requires at least version 1.0.1 of FParsec however what if 1.0.1 is not available? When restoring will paket proceed to download the next version up? I ask this question because I want to lock down all my packages to ensure a consistent output in my application for safety reasons.
Should I manually change the paket.lock to:
Arachne.Core (2.3.23)
  FParsec (1.0.1)
  FSharp.Core (<IP_ADDRESS>)

During restore it will only use exactly the pinned versions or raise an
exception. That's the whole point of the lock file.
Imran Azad<EMAIL_ADDRESS>schrieb am Di., 3. Dez. 2019, 16:58:

I have the following version constraint in my packet.lock file
Arachne.Core (2.3.23)
FParsec (>= 1.0.1)
FSharp.Core (>= <IP_ADDRESS>)
I understand that this means that it requires at least version 1.0.1
however what if 1.0.1 is not available? When restoring will paket proceed
to download the next version up? I ask this question because I want to lock
down all my packages to ensure a consistent output in my application for
safety reasons.
Should I manually change the paket.lock to:
Arachne.Core (2.3.23)
FParsec (1.0.1)
FSharp.Core (<IP_ADDRESS>)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/issues/3740?email_source=notifications&email_token=AAAOANGVD7SBUKJXQHKSTKTQWZ625A5CNFSM4JU2MDEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H5XABSQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAOANGMDQ65LDX6SWJAAQTQWZ625ANCNFSM4JU2MDEA
.

@forki That's brilliant, thank you!


Add a button list style to the Choices for prompts

Is your feature request related to a problem? Please describe.
I am upgrading a v3 bot to v4 and am working on the prompts. I am currently using a ConfirmPrompt but would like to use buttons rather than just text.
Describe the solution you'd like
It would be great to have a button list style that would display the options as a card action inside a hero card attachment.
Describe alternatives you've considered
I have looked at creating a hero card and adding card actions to it and adding that to the prompt activity. However this displays the options "(1) Yes or (2) No" as text above the card still.
Additional context
This is what I am looking for:

I do have some custom css styling to in the webchat.
[enhancement]

Adaptive Cards should be able to address this issue for the customer

I'm working with this developer on this and the primary channel we're using is Skype for Business which doesn't support many cards from what I've seen.

This issue was moved to Microsoft/BotBuilder#5121


Sync NuGet package versions.

I went through all the NuGet packages we referenced and got them in sync. Horrible manual process unfortunately. I also removed the daily feeds so it wouldn't look there since it shouldn't be needed right now.
This now builds on my machine, hopefully the CI will pass.

LGTM

This is failing because of registry access which is no longer available on the Windows build. @rainersigwald is working on disabling those tests.


Add pn.panelize or at least improvements to pn.depends

Background
I have been playing around with the stock APIs example which is totally great and has really been helping me understand the various APIs.
In the course of my experiments I was surprised that while you can do:
def get_plot(ticker, window_size):
    df = get_df(ticker, window_size)
    return df.hvplot.line('date', 'close', grid=True, width=600)

pn.interact(get_plot, ticker=tickers, window_size=(1, 21, 5))

When working with depends the syntax becomes:
ticker = pn.widgets.Select(name='Ticker', options=tickers)
window = pn.widgets.IntSlider(name='Window Size', value=6, start=1, end=21)

pn.depends(ticker=ticker.param.value, window_size=window.param.value)(get_plot))

This is just one example of how the interact and depends methods are different in kind of strange and surprising way. I know that these methods have been discussed at length, but it seems worth ironing out a little more since these are the first places that users get stuck when first starting out with panel.
Proposal 1 (less ambitious)
To make depends more user-friendly, pn.depends should:

accept a function or class method as the first argument, so that the syntax is the same as pn.interact
accept widgets in addition to parametrized values.
return a panel object (as if you had done pn.Pane(get_plot))

Example 1
PROPOSED:
pn.depends(get_plot, ticker=ticker, window_size=window)

CURRENT:
pn.depends(ticker=ticker.param.value, window_size=window.param.value)(get_plot)

Example 2
PROPOSED:
ticker = pn.widgets.Select(name='Ticker', options=tickers)
window = pn.widgets.IntSlider(name='Window Size', value=6, start=1, end=21)

@pn.depends(ticker=ticker, window_size=window)
def get_plot(ticker, window_size):
    df = get_df(ticker, window_size)
    return df.hvplot.line('date', 'close', grid=True, width=600)

get_plot

CURRENT:
ticker = pn.widgets.Select(name='Ticker', options=tickers)
window = pn.widgets.IntSlider(name='Window Size', value=6, start=1, end=21)

@pn.depends(ticker=ticker.param.value, window_size=window.param.value)
def plot(ticker, window_size):
    df = get_df(ticker, window_size)
    return df.hvplot.line('date', 'close', grid=True, width=600)

pn.Pane(plot)

Proposal 2 (more ambitious)
I'd like for there to be a combined decorator (perhaps called pn.panelize) that would act like pn.interact or like pn.depends based on what the inputs to the decorator are.
Example 1 (maps to interact)
@pn.panelize(ticker=tickers, window_size=(1, 21, 5))
def get_plot(ticker, window_size):
    df = get_df(ticker, window_size)
    return df.hvplot.line('date', 'close', grid=True, width=600)

get_plot

Example 2 (maps to depends)
ticker = pn.widgets.Select(name='Ticker', options=tickers)
window = pn.widgets.IntSlider(name='Window Size', value=6, start=1, end=21)

@pn.panelize(ticker=ticker, window_size=window)
def get_plot(ticker, window_size):
    df = get_df(ticker, window_size)
    return df.hvplot.line('date', 'close', grid=True, width=600)

get_plot

One wrinkle I can see is that the depends one should not return the widgets whereas the the interact one should. So that might feel unexpected to the user.

For proposal 1:

To make depends more user-friendly, pn.depends should:

accept a function or class method as the first argument, so that the syntax is the same as pn.interact

Do we ever show something like pn.depends(ticker=ticker.param.value, window_size=window.param.value)(get_plot)) in the docs?  pn.depends is normally used as a decorator, right?  Of course it can be called directly, but as far as I know the intent was purely for it to be used with the decorator syntax, and I think it will confuse users to use it in other ways. People are already uncomfortable enough with decorators used in the typical way!

accept widgets in addition to parametrized values.

If that's practical, sounds great!  I'd be very happy to get rid of the extra syntax and leave it easier for people to remember. Note that what they currently accept is not actually a parameterized value (i.e. not the value of a parameter), but the Parameter object named "value" on the widget.  So really the proposal is to accept widgets in addition to Parameter objects, automatically finding the "value" Parameter object of the widget and substituting that. Seems like a good idea to me.

return a panel object (as if you had done pn.Pane(get_plot))

Doesn't that conflict with the semantics of decorators?  Normally a decorator applied to a function will leave that function defined in the namespace, but replaced with a wrapper function.  With the above proposal, any subsequent call to get_plot as a function will fail, right?
The issues with 1 and 3 here suggest to me that you maybe want something other than @pn.depends, i.e. some other call that behaves the way that you like, and is not a decorator?

For proposal 2, I'm not quite sure what the plan would be, but I don't think it works, because in both cases get_plot should be a function (as a decorated function should still be a function), not a set of widgets or a panel.

That is an interesting point that decorators shouldn't alter the type of the inner function. This is not the case in the current version of pn.interact:

For interact we are copying the interface from ipywidgets, but for pn.depends we are following standard usage of decorators.  In ipywidgets the decorator usage is an extra bonus (it's mainly meant as a direct call, but in panel pn.depends is intended entirely (or almost entirely) as a decorator.  So I think pn.depnds() should work like a normal decorator, without any shenanigans like returning a non-function, and we should leave any other behavior to other functions.  @philippjfr would be the one to make the call, really, ,though.

Ok so maybe an in-between would be to allow interact to accept widgets and param.values and allow depends to also accept widgets.

I'd be very happy to see that!

Here is a WIP implementation of panelize anyways.
def panelize(func, **kwargs):
    parametrized = True
    for k, v in kwargs.items():
        if not isinstance(v, pn.param.param.parameterized.Parameter):
            pass
        elif isinstance(v, pn.widgets.base.Widget):
            kwargs[k] = v.param.value
        else:
            parametrized = False
            continue
    if parametrized:
        return pn.Pane(pn.depends(**kwargs)(func))
    return pn.interact(func, **kwargs)


ResultSet.getString() should work for non-String columns

Is your feature request related to a problem? Please describe.
When calling ResultSet.getString(), it fails in Spanner for non-String columns, whereas every other database JDBC driver will convert the column to String for you.
Our callstack is:
java.lang.IllegalStateException: Column 0 is not of correct type: expected STRING but was INT64

	at com.google.common.base.Preconditions.checkState(Preconditions.java:854)
	at com.google.cloud.spanner.AbstractStructReader.checkNonNullOfType(AbstractStructReader.java:342)
	at com.google.cloud.spanner.AbstractStructReader.getString(AbstractStructReader.java:132)
	at com.google.cloud.spanner.ForwardingStructReader.getString(ForwardingStructReader.java:112)
	at com.google.cloud.spanner.jdbc.DirectExecuteResultSet.getString(DirectExecuteResultSet.java:176)
	at com.google.cloud.spanner.jdbc.JdbcResultSet.getString(JdbcResultSet.java:126)

Describe the solution you'd like
The callstack shows that the driver knows what the actual column type is. Could the driver get it as the correct type and return the value converted to String itself?
Describe alternatives you've considered
The alternative we considered is switching on every type based on the metadata but this isn't required on any other database driver and bloats the code when the driver can do it internally.

@DoodleBobBuffPants Which version are you currently using? As this issue should have been fixed in version 1.16.0 by this PR.

Using 1.16.0 worked! Thanks!


Possible Security Problems

Hey there! I noticed some possible problems in some code in this repo. A quick summary of a few of them is below, but let me know if you're interested in seeing a full report or talking about cloud security in general.

severity: serious
filename: ./cloudformation/aws-account-baseline-templates/aws-iam-suspend-inactive-users/aws-iam-suspend-inactive-users.yaml
line number(s): [52]
resource(s):
IAM policy should not allow * resource with PassRole action

severity: warning
filename: ./cloudformation/aws-account-baseline-templates/aws-iam-suspend-inactive-users/aws-iam-suspend-inactive-users.yaml
line number(s): [73, 157]
resource(s):
IAM role should not allow * resource on its permissions policy

severity: warning
filename: ./cloudformation/aws-account-baseline-templates/aws-iam-suspend-inactive-users/aws-iam-suspend-inactive-users.yaml
line number(s): [64]
resource(s):
Resource found with an explicit name, this disallows updates that require replacement of this resource

severity: warning
filename: ./cloudformation/aws-account-baseline-templates/aws-risk-credentials-exposed/risk_credentials_exposed.serverless.yaml
line number(s): [65, 126, 175, 216, 255]
resource(s):
IAM role should not allow * resource on its permissions policy

severity: warning
filename: ./cloudformation/aws-account-baseline-templates/aws-iam-user-roles-groups/aws-iam-instanceprofiles.yaml
line number(s): [36]
resource(s):
IAM managed policy should not allow Allow+NotAction

severity: warning
filename: ./cloudformation/aws-account-baseline-templates/aws-iam-user-roles-groups/aws-iam-instanceprofiles.yaml
line number(s): [36, 91, 129, 206, 282]
resource(s):
IAM managed policy should not allow * resource

severity: warning
filename: ./cloudformation/aws-account-baseline-templates/aws-iam-user-roles-groups/aws-iam-instanceprofiles.yaml
line number(s): [36, 91, 129, 206, 282, 16, 71, 109, 186]
resource(s):
Resource found with an explicit name, this disallows updates that require replacement of this resource

Hi @ctindall Thank you for taking the time to raise these concerns. I've contacted our security team, who will look into this. We appreciate you making the effort to help us improve our code.

Hi @ctindall, thank you for submitting this issues, I'm working for the security team here.
Firstly, I appreciate the way you're promoting your services by using a bot which would scan public GitHub repos and open issue reports on these repos.
I also appreciate that we need to promote best practices when writing IAM policy and avoid using wildcards * in our resource declaration.
Now, unfortunately your bot flag legitimate codes such as follow:
  DenyAllPolicy:
    Type: "AWS::IAM::Policy"
    Properties:
      PolicyName: DenyAllPolicy
      PolicyDocument:
        Version: "2012-10-17"
        Statement:
          Effect: "Deny"
          Action: "*"
          Resource: "*"

or this:
                ...
                  - iam:GetUser
                  - iam:DeleteLoginProfile
                  - iam:DeleteUserPolicy
                  - iam:ListAccessKeys
                  - iam:ListGroupsForUser
                  - iam:ListMFADevices
                  - iam:ListUsers
                  - iam:ListAttachedGroupPolicies
                  - iam:ListAttachedUserPolicies
                  - iam:ListUserPolicies
                  - iam:RemoveUserFromGroup
                  - iam:UpdateAccessKey
                  - sns:Publish
                Resource: "*"

Something that even AWS would document and advice to use.
There isn't one-size-fits-all solution, thank you to review this report and make sure that's actually accurate case by case

Thank you for taking the time to explain this! I appreciate the feedback and will be working to improve the service, both by catching cases like these and by motivating me to better review these before letting my bot spam innocents like you!

Glad that my comment was helpful, I believe we can close this issue now. Don't hesitate to open a new one in our repos if you see any other potential security issues.

Closing as per conversation above.


Selecting one namespace at a time

Select one namespace by default, using "shift clicking" as a way to select multiple namespaces.
react-select contains "onKeyDown" props, but doesn't contain "onKeyUp". Wdyt?
fixes: https://github.com/lensapp/lens/issues/2773

What I suggest to do in current PR:

Leave All namespaces as is.
Check (select/tick) all namespaces in list when clicked All namespaces. This will allows us to uncheck some of the namespaces from the full list.

Duplicate Shift behavior to Cmd (on mac) and Ctrl on windows which is more intuitive on win.

@vshakirova @jim-docker wdyt?

What I suggest to do in current PR:

Leave All namespaces as is.
Check (select/tick) all namespaces in list when clicked All namespaces. This will allows us to uncheck some of the namespaces from the full list.

Duplicate Shift behavior to Cmd (on mac) and Ctrl on windows which is more intuitive on win.

@vshakirova @jim-docker wdyt?

Sounds good to me. If we feel there's a need for range selecting we could add it via shift-click (and Ctrl/Cmd-shift-click) in a follow-up PR


Set up initial structure of deformation model

Creates a model that draws a grid that can animate between states.
There's a WIP commit that adds it to app.tsx, which I left in for now, but if it would be easier to merge it with your work I can rebase it out.

I merged this code into the work on setting up the deformation tab and other framework pieces so that all the tests would be able to pass. This included adding a simple block in the new Deformation category that, when placed and run, will start the deformation simulation. I'll therefore close this PR and make a new one that includes @sfentress work on the underlying model.


This wastes our CI money and reviewer bandwidth. If you want to add value, please figure out how this failed our format checks and fix that also. Thanks!


Casting fails in Swift 6

Description
When compiling code with the Swift 6 compiler and running in a Swift 5 environment, such as an iOS 17 simulator, casting of values to protocols fails. When running the same code in other environment, such as an iOS 18 simulator, the casting succeeds as I would expect.
I'm not totally sure if there are specific requirements for the protocol or how it's used. The reproduction steps listed below are based off of the part of my codebase that's exhibiting this behavior, and I've confirmed that the issue exists in a fresh project with this code snippet.
Reproduction
protocol OptionalProtocol {}
extension Optional: OptionalProtocol {}

let value = Optional<Int>.some(0) as Any
if let optionalValue = value as? OptionalProtocol {
    print("The value is wrapped in an optional")
} else {
    print("The value is not wrapped in an optional")
}

Expected behavior
When running with Xcode 16 and targeting an iOS 17 simulator (that is, when using the Swift 6 compiler and targeting a device with a Swift 5 runtime), we should see "The value is wrapped in an optional" printed. Instead, we see "The value is not wrapped in an optional" printed. We see the correct behavior on the iOS 18 simulator. This code also behaves correctly when compiled with the Swift 5 compiler in Xcode 15.
Environment
Xcode 16 Beta 2 (16A5171r)
iOS 17.4 simulator, macOS 14
Apple Swift version 6.0 (swiftlang-<IP_ADDRESS>.52 clang-16<IP_ADDRESS>.3)
Additional information
I think whatever is causing this behavior, might be causing the behavior in #74333? They're similar enough that I'm suspicious, but I'm also not knowledgable enough with the compiler code to know if that's actually true or if I'm incorrectly relating two issues together.

Maybe related to #74282

Yes, it does seem to be related to #74282 which should be fixed by #74604.


feat: aligned contribution guide button on dasboard

Description
Aligned Contribution Guide button of dashboard

Related issue(s)

fixes #1391

@sambhavgupta0705 Can there be another way to align these buttons as these buttons look slightly squeezed in terms of width in mobile view?

@akshatnema PTAL

@sambhavgupta0705 Kindly make the buttons 1 in a row, i.e. flex column for the screens less than sm size of tailwindcss

Ok 👍

Hey @akshatnema PTAL

Is it looking good with text aligned in center??

@sambhavgupta0705 If you look at this screen now, it is too much expanded. You can display these buttons in desktop format here till the screen width become so much small that it requires 1 button in a row.

@akshatnema PTAL

/rtm


Running taffybar with two monitors

Hi,
When I run taffybar with the example configuration (or default config) I get the following message when launching from a terminal:
Monitor 0 is not available in the selected screen

A white bar is displayed at the top of the display on DP2, instead of the expected black taffybar.
$ xrandr
Screen 0: minimum 8 x 8, current 3760 x 1920, maximum 32767 x 32767
LVDS1 connected (normal left inverted right x axis y axis)
   1366x768      60.02 +
   1280x720      60.00
   1024x768      60.00
   1024x576      60.00
   960x540       60.00
   800x600       60.32    56.25
   864x486       60.00
   640x480       59.94
   720x405       60.00
   680x384       60.00
   640x360       60.00
DP1 disconnected (normal left inverted right x axis y axis)
DP2 connected primary 2560x1440+0+0 (normal left inverted right x axis y axis) 597mm x 336mm
   2560x1440     59.95*+
   1920x1080     60.00    60.00    50.00    59.94
   1920x1080i    60.00    50.00    59.94
   1680x1050     59.88
   1600x900      60.00
   1280x1024     75.02    60.02
   1280x800      59.91
   1152x864      75.00
   1280x720      60.00    50.00    59.94
   1024x768      75.08    60.00
   832x624       74.55
   800x600       75.00    60.32
   720x576       50.00
   720x480       60.00    59.94
   640x480       75.00    60.00    59.94
   720x400       70.08
DP3 disconnected (normal left inverted right x axis y axis)
HDMI1 disconnected (normal left inverted right x axis y axis)
HDMI2 disconnected (normal left inverted right x axis y axis)
HDMI3 connected 1200x1920+2560+0 left (normal left inverted right x axis y axis) 518mm x 324mm
   1920x1200     59.95*+
   1920x1080     60.00
   1600x1200     60.00
   1680x1050     59.88
   1280x1024     60.02
   1280x960      60.00
   1024x768      60.00
   800x600       60.32
   640x480       60.00
   720x400       70.08
VGA1 disconnected (normal left inverted right x axis y axis)
VIRTUAL1 disconnected (normal left inverted right x axis y axis)

Any idea on what the issue might be and how to resolve it?
Many thanks,

When you say white bar, do you mean an empty white bar, or a white bar with widgets?
A recent commit (be60703daf6a60ffdd417a6733fcf90772af826d) fixed the issue with the desktop number error.  If the bar has widgets and is just the wrong color, another commit (45ff40992c8fe5593d5f3e03ef0765168c6325fb) probably took care of that.

Hi,
I've just tried building from master, this has fixed the issue of a white bar with no widgets appearing and I now get my expected bar, however I still get the error message on the command line, what exactly is it referring to?
Do monitors refer to actual physical monitors and screens xrandr's concept of a screen which can be made up of multiple monitors?

I had to go back and check.  The monitor number refers to a physical monitor in an X screen (on the default display), at least as interpreted by gdk/gtk

How I use taffybar with multiple monitors is as following:
So taffybar shows up on only one monitor at a time. On my PC this creates problems, swapping workspaces between monitors causes a good amount of flickering and shifting (~500ms or more) because of the different amount of vertical space available on the two monitors.
I proceeded to let one taffybar running, and then went to my config, changed the default monitor to 1, and then started another instance of taffybar. Stashed the changes on my config. This works for me, as I don't shutdown my PC often.
There should be a better way to have taffybar on both the monitors.

@travitch, thanks for your help (apologies for the very delayed response), I'm now happily using taffybar!
@saksham0808, thanks for weighing in, it'd be nice if taffybar had better support, I'd try my hand at dipping in and helping, but my Haskell knowledge is probably insufficient :(

@sakshamsharma I know this discussion is quite old, but if someone in the future is wondering how to run taffybar on two monitors simultaneously, you can do this:
import Control.Concurrent
...
main = do
...
  forkIO $ defaultTaffybar $ myTaffybarConfig { monitorNumber = 0 }
  defaultTaffybar $ myTaffybarConfig { monitorNumber = 1 }

Don't forget that you can use all of Haskell to run/customize your taffybar. :-)

@jirkamarsik taffybar has internal support for multiple monitors now, so that approach should no longer be necessary


SPDX-2.3 is misidentified as SPDX-2.2

What happened:
When using formats.Decode or formats.Identify with an SPDX-2.3 document, it is misidentified as SPDX-2.2
What you expected to happen:
The document is parsed as the correct type.
Steps to reproduce the issue:
See https://github.com/anchore/syft/pull/2111's example tests added.
Anything else we need to know?:
It appears to be due to the fact that the validator only checks that the document can be parsed, but does not that it's the right version.
Changing the order of formats.Formats() works, but then SPDX-2.2 is parsed as SPDX-2.3.
I had a quick look at it, but may need a nudge from the maintainers in how best to approach this so it still fits within the sbom.Decoder and sbom.Validator interfaces.

fixed by https://github.com/anchore/syft/pull/2186


[WIP] chore: add detailed description for tracepoint

Signed-off-by: hsgwa<EMAIL_ADDRESS>

I'll close this PR for now.


[WIP] feat: docker setup

Need db migrations added to start. See https://elixirschool.com/blog/releasing-an-umbrella-app-with-docker-and-mix-release/


c2m dump the generated assembly

I have a few questions, if you wouldn't mind answering them. Firstly, I was wondering whether there are any command line flags in c2m that would allow for dumping the generated assembly code. Additionally, I was curious as to whether there are any similar flags for dumping the optimizing pipeline, similar to what is available in LLVM, which would allow us to easily see what changes have occurred between each optimization step.

Oh, I find -dg comes in handy.


metanode support config memRation of the machine

Is your feature request related to a problem? Please describe.
totalMem need to be different for different total memory machine. it's not easy to manage.
Describe the solution you'd like
"memRatio": "70", support config memRation for metanode

fixed by https://github.com/cubefs/cubefs/pull/1722


Update Dev Deps to WP6.1

[x] Min PHP7.2 (Drop all support for PHP7.1)
[x] Tests on WP5.9 | WP6.0 | WP61
[ ] Shared Badges
[x] Project on Codecov
[x] Project on Scrutizer
[ ] Project on codeclimate
[x] Project Dev Dependencies
[x] Uusing .env for test wp-config
This has partially been done

codeclimate badge

shared


[Development Setup] [tool.poetry] section not found in magika/python/pyproject.toml

While i follow the Development Setup steps, poetry shell gives follow error:
[root@exarch python]# pwd
/root/magika/python
[root@exarch python]# poetry --version
Poetry (version 1.7.1)
[root@exarch python]# poetry shell

[tool.poetry] section not found in /root/magika/python/pyproject.toml
[root@exarch python]#

My test environment:
OS: arch linux with kernel 6.10.2
poetry version: 1.7.1

Apologies! We moved to use uv and we are revamping the docs as we speak. Here is the draft PR with more updated details, which is still heavy WIP: https://github.com/google/magika/pull/740.

Merged the new docs. See https://github.com/google/magika/blob/main/python/README.md#development-setup for dev setup information, and feel free to open another issue if anything is unclear. Thanks!


Tackle roundtrip ser/de issues related to arbitrary Float and Int

          Follow-up: create an issue to tackle roundtrip ser/de issues mentioned here: https://github.com/ChainSafe/forest/blob/ec7e65bace51b4de7a3d43f466d983ac5a3f28c8/src/utils/encoding/cid_de_cbor.rs#L218-L228

Originally posted by @ruseinov in https://github.com/ChainSafe/forest/issues/3379#issuecomment-1682457050
https://github.com/ChainSafe/forest/blob/ec7e65bace51b4de7a3d43f466d983ac5a3f28c8/src/utils/encoding/cid_de_cbor.rs#L218-L228

@ruseinov Is this done?

@ruseinov Is this done?

It's done, but it hasn't been released yet, unfortunately. I'll poke the guys.
Here's the issue: https://github.com/ipld/serde_ipld_dagcbor/issues/16


"prime" after product is put in the wrong place

Writing product' in typst puts the prime on top of, instead of to the top right of, the product sign.

The corresponding latex:

Is this intended behaviour or a bug?

Seems like a bug I think. This works fine:
$product'$
while if you turn it into a block equation, it gets put on the top:
$ product' $

Related to (if not duplicate of) #2070

Oh nevermind, I misremembered how latex works. Apparently behaves the same there! (cf https://tex.stackexchange.com/questions/332256/prime-on-the-product-symbol)


Nameplate visibility doesn't respect config

Minecraft Version
1.20.x
Mod Loader Version
Quilt 0.21.0-beta.4
Mod Version
1.1.4+1.20.1
Describe the Issue
Nameplates for passive animals still show with the "Show Hostile Only" config flag set to true.
Adding the entity's names e.g. "minecraft:sheep" to the exclusion list also does not have any effect.
Adding the entity's names to the exclusion list for RpgDifficulty does make the entities stay at level 1, but the nameplate still shows.

latest.log
https://mclo.gs/7xzsbyr
Do you use any other mods except the required ones?
Yes this issue arose as part of a modpack I'm building, but I've tested with only Nameplate and RpgDifficulty, and the problem is present then too.

How about freshly spawned passive mobs?

The problem persists with mobs spawned in new chunks, and mobs created with /summon

Have to look into this


auto-publish tagged released to pypi

Status
IN DEVELOPMENT
Migrations
NO
Description
improve circle pipeline to publish automatically when release is tagged.
NOTE: require TWINE_USERNAME and TWINE_PASSWORD env variables for CI

Pull Request Test Coverage Report for Build 237

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 64.884%

Totals

Change from base Build 227:
0.02%

Covered Lines:
4235

Relevant Lines:
6527

💛  - Coveralls

@jupe is this ready for merging? The descripition still says in development?


Testcase cleanup

Codecov Report

Merging #7949 into master will increase coverage by 0.01%.
The diff coverage is 97.14%.

@@            Coverage Diff             @@
##           master    #7949      +/-   ##
==========================================
+ Coverage   55.02%   55.04%   +0.01%
==========================================
  Files         481      481
  Lines       53965    53938      -27
  Branches    10480    10471       -9
==========================================
- Hits        29694    29689       -5
+ Misses      19995    19983      -12
+ Partials     4276     4266      -10

Impacted Files
Coverage Δ

tests/posix/pthread_join/src/main.c
73.07% <ø> (ø)

tests/posix/pthread_cancel/src/main.c
86.04% <ø> (ø)

tests/posix/clock/src/main.c
76.47% <ø> (ø)

...ed/schedule_api/src/test_sched_is_preempt_thread.c
96.96% <ø> (ø)

...ched/schedule_api/src/test_sched_timeslice_reset.c
100% <ø> (ø)

tests/posix/pthread/src/main.c
74.46% <ø> (ø)

tests/posix/mqueue/src/main.c
86.04% <ø> (ø)

.../sched/schedule_api/src/test_priority_scheduling.c
100% <ø> (ø)

tests/kernel/sched/schedule_api/src/main.c
66.66% <ø> (ø)

...nel/sched/schedule_api/src/test_slice_scheduling.c
96.96% <ø> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eabea3...d6d2b25. Read the comment docs.


Fix audio 'scroll to element' for horizontal

Tested on both books.

Hey I tested and worked perfectly for horizontal, but for vertical scroll it is not working for me, I have tried but seems that there is something wrong. May we have to check  the direction and do only one direction scroll. What do you think?

I have being playing with some code, I found a solution based on your code. I don't know if it is the best way to handle this:
function goToEl(el) {
    var top = document.body.scrollTop;
    var elTop = el.offsetTop - 20;
    var bottom = window.innerHeight + document.body.scrollTop;
    var elBottom = el.offsetHeight + el.offsetTop + 60

    var clientWidth = document.documentElement["clientWidth"];
    var scrollWidth = document.body["scrollWidth"];

    if (scrollWidth > clientWidth) {
        var elLeft = document.body.clientWidth * Math.floor(el.offsetTop / window.innerHeight);
        document.body.scrollLeft = elLeft;
    } else if(elBottom > bottom || elTop < top) {
        document.body.scrollTop = el.offsetTop - 20
    }

    return el;
}

It is working for both orientations.

I was just finishing up testing my fix too.
I just added this before setting scroll left:
if( document.body.scrollTop == 0 ){

Perfect! Much better solution as always 👍


Add theming for the "Chat with us" chatbox

This one may be a bridge too far.
WK appears to be using inline styles in the markup for the chatbox.

I added a wontfix label. Please close this issue if you concur.

The inline styles should be overrideable, but the classes are what worries me. Im not sure if they are user-specific or not. I would be inclined to believe that they are, as the names are complete jargon.
For now, I will leave this issue open, but since the priority is currently low, I will leave the wontfix flair up.

Since the chat facility is intended to contact WK for support, I'm strongly inclined not to touch the styling here.  The fact that the class names and inline styles appear to be auto-generated just adds more motivation not to fix this (becomes a game of whackamole with !important tags).
I'm going to close this one. Please reopen if you disagree.


Router Redirect is not working

As the title says, stencil-route-redirect is not working.
Versions: core, router and dev-server are set to "next" while utils are set to "latest".
<stencil-route url="/" exact="true">
  <stencil-route-redirect url="/another-path" />
</stencil-route>
<stencil-route url="/another-path" component="app-component" />

Regards,
Bogdan

The actual name of the redirect is 'stencil-router-redirect'. Here is an example: https://github.com/ionic-team/stencil-router/blob/master/src/components/tests/test-app.tsx#L42

link no longer works.
I am attempting to use stencil-route-redirect in my render to cause the router to go to my 403 page when a wrapping component checks permissions.... it just doesn't work....

Should be reopened as a documentation bug since the Wiki refers to the component as "stencil-route-redirect"
https://github.com/ionic-team/stencil-router/wiki/stencil-route-redirect


Create itispolistena school file

italian secondary school with computer science course www.itispolistena.edu.it

@paoloviafora lib/domains/it/edu/itispolistena: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

i think that the error was missing file extension
Thanks and sorry for mistake :)

@paoloviafora First stage of verification passed, official domain is itispolistena.edu.it as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@paoloviafora Pull request merged. Thank you!


fix: added default-params-in-modal-stories

#175
What kind of change does this PR introduce?
Bug fix,
What is the current behavior?
Modal default params button text not set.
What is the new behavior?
{ .....   onCancelText: 'Cancel',   onConfirmText: 'Confirm', ..... }
Feel free to include screenshots if it includes visual changes.

@cmcWebCode40 thanks for the PR 👍
I'm not sure this actually fixes the issue though.
I don't think we should manually add the labels into stories if they are just the same as the default because there's no visual check as to wether the default values are working, and what they are.
default params seem to work fine when using the components in an app, it just seems to be storybook doesn't display them.
It seems to only affect strings though which is weird.

@MildTomato
Thanks for the feedback regarding this fix,
I was actually having some issues installing the application on my machine to get started (I will get a screenshot and update later),
I would suggest there's proper documentation on how to get started on the readme file, that would go a long way.
Thanks

thanks for the feedback 😄 @cmcWebCode40
There's an old dev markdown on running storybook locally but it might be a bit outdated.

I'm just closing this for now, but feel free to make changes
I still can't work out what is wrong, might just be a storybook bug.


radare2: 3.8.0 -> 3.9.0

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build radare2

so fast, so furious :racing_car: :dash:


Simplify boilerplate for monoT5 and monoBERT

closes #80
usage is like so:
from pygaggle.rerank.pretrained import monoBERT, monoT5
reranker = monoBERT()
or
reranker = monoBERT('model-name', 'tokenizer-name')
or
reranker = monoBERT(model, tokenizer)

tested outputs are the same as https://github.com/castorini/pygaggle#a-simple-reranking-example
I was a bit confused on the goal of these two functions, see my comment here: https://github.com/castorini/pygaggle/issues/80#issuecomment-690599468

Can you also change the README accordingly?

hey @rodrigonogueira4 - do you prefer this impl or the alternative of folding the boilerplate code into constructors for existing models? e.g., https://github.com/castorini/pygaggle/blob/master/pygaggle/rerank/transformer.py#L25

hey @rodrigonogueira4 - do you prefer this impl or the alternative of folding the boilerplate code into constructors for existing models? e.g., https://github.com/castorini/pygaggle/blob/master/pygaggle/rerank/transformer.py#L25

Yes, it is actually better to rename T5Reranker to monoT5 and add the option to initialize it without arguments.

@rodrigonogueira4 @lintool which do you prefer?
folding into constructors:
class T5Reranker(Reranker):
    def __init__(self,
                 model: T5ForConditionalGeneration = None,
                 tokenizer: QueryDocumentBatchTokenizer = None):
        if not model:
            device = torch.device('cuda' if torch.cuda.is_available() else 'cpu')
            model = T5ForConditionalGeneration.from_pretrained('castorini/monot5-base-msmarco').to(device).eval()
        self.model = model

        if not tokenizer:
            tokenizer = T5BatchTokenizer(AutoTokenizer.from_pretrained('t5-base'), batch_size=8)
        self.tokenizer = tokenizer

        self.device = next(self.model.parameters(), None).device

class SequenceClassificationTransformerReranker(Reranker):
    def __init__(self,
                 model: PreTrainedModel,
                 tokenizer: PreTrainedTokenizer):
        if not model:
            device = torch.device('cuda' if torch.cuda.is_available() else 'cpu')
            model = AutoModelForSequenceClassification.from_pretrained('castorini/monobert-large-msmarco').to(device).eval()
        self.model = model

        if not tokenizer:
            tokenizer = AutoTokenizer.from_pretrained('bert-large-uncased')
        self.tokenizer = tokenizer

        self.device = next(model.parameters()).device

or
making subclasses:
class MonoT5(T5Reranker):
    def __init__(self,
                 model: T5ForConditionalGeneration = None,
                 tokenizer: QueryDocumentBatchTokenizer = None):
        if not model:
            device = torch.device('cuda' if torch.cuda.is_available() else 'cpu')
            model = T5ForConditionalGeneration.from_pretrained('castorini/monot5-base-msmarco').to(device).eval()
        if not tokenizer:
            tokenizer = T5BatchTokenizer(AutoTokenizer.from_pretrained('t5-base'), batch_size=8)
        super().__init__(model, tokenizer)

class MonoBERT(SequenceClassificationTransformerReranker):
    def __init__(self,
                 model: T5ForConditionalGeneration = None,
                 tokenizer: QueryDocumentBatchTokenizer = None):
        if not model:
            device = torch.device('cuda' if torch.cuda.is_available() else 'cpu')
            model = AutoModelForSequenceClassification.from_pretrained('castorini/monobert-large-msmarco').to(device).eval()
        if not tokenizer:
            tokenizer = AutoTokenizer.from_pretrained('bert-large-uncased')
        super().__init__(model, tokenizer)

My vote is for option 1, but renaming the classes monoT5 and monoBERT. I know this is against Python conventions, but is started with lowercase "m" really that bad? Makes it consistent with our papers, etc.
@ronakice should chime in also...
Also, once we build these abstractions we should propagate to the replications also, e.g.,:
https://github.com/castorini/pygaggle/blob/master/pygaggle/run/evaluate_passage_ranker.py

I agree with @lintool, lowercase "m" as it is consistent with our previous work!

I agree with @lintool, lowercase "m" as it is consistent with our previous work!

But re: Option 1 vs. Option 2? I.e., is there something special about our current abstractions that we should keep?

the main things I can think of with using lowercase are

pretty much every linter will complain unless it's added as an exception
it's not exactly clear from seeing from pygaggle.rerank.transformers import monoBERT, monoT5 that those are classes

I'd avoid it unless the consistency w/ paper is particularly important and worth ignoring Python's conventions

Hey @yuxuan-ji  sorry I got a bit carried away with some other work.
Firstly, yes I think option 1 is better. You make a fair point about linters complaining about monoBERT/monoT5 as well as the lack of clarity to the general dev. So I concede, I think it is better to go with MonoBERT and MonoT5. @lintool what do you think?
As to the usage of MonoBERT in the general form, I think it is mostly fine since all these other Sequence Classification transformers are kinda BERT derived and use the same "principles", unlike monoT5 which signified a bit of a shift. Also, we currently only support MonoBERT so until we find a better name :)/add support for other models, we shouldn't worry about it.

Okay, we've converged. Option 1, MonoBERT and MonoT5 as class names.
FWIW - huggingface made the model names fugly, favoring conformance to conventions - see Bert and MBart.
@yuxuan-ji please execute.


Implement usage of ammunition (Arrows, Bolts) for Bows/Crossbows

At the moment, Bows and Crossbows can probably be used without consuming ammunition (Arrows, Bolts).

Ideas:

The durability of an item could act as a consumable stat attribute.
A stat like “ammo consumption rate” which is 1 by default. Skills like Infinite Arrow multiply this stat by 0 via MagicEffect, so no consumption happens while the effect is active.
Skills which need ammo have this stat attribute in their ConsumeRequirements.

I will start working on this feature.


[Enhancement]: Increase size of tilting maze and instruction text.

Do you want to have the enhancement of existing game ? 😀 Describe yourself..
Game enhancement
The size of instruction text and tiling maze is very small .We should zoom in full screen.
Describe the solution you'd like
Solution steps
Update CSS style for tilting maze and text to zoom it in full screen.

Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @theashikagupta !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @theashikagupta ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Twitch provider

Hey! 👋 this is super cool! And extremely useful! I use Nest and have been looking at using https://github.com/supabase/gotrue for an OAuth server. And then I found this, perfect!
And now for my request, could you add the Twitch provider? I use https://github.com/Nigh7Sh4de/passport-twitch-new currently. With some time I could implement it myself, but I wanted to post this issue first in case someone else gets to it before me.
Note: You should add the hacktoberfest topic to this repo to make it eligible for the event!

Sure @alexweininger thanks for the recommendation. Will do that shortly.

Awesome!

@alexweininger Added Twitch authentication in the package. Please visit
https://www.npmjs.com/package/@nestjs-hybrid-auth/twitch
https://nestjs-hybrid-auth.manishjangir.com/docs/providers/twitch

Added Twitch authentication. Closing this issue.


Wrench visual deadzone

I strongly dislike the behavior I'm getting of hiding the arrows if they become "shorter than they are wide". It seems like a good idea, but it should be optional and perhaps a separate parameter should decide the threshold.
It doesn't really seem like it's working as intended:
https://youtu.be/6kV5kS81WsQ
(notice how the deadzone really is too big. the arrows materialize out of nowhere, losing a huge range of sensitivity.)
Though from reading the code, I can't tell why:
https://github.com/ros-visualization/rviz/blob/7970ba08cee3810cfa1609c3b0f5136970eb2f7c/src/rviz/default_plugin/wrench_visual.cpp#L63

We just hit this bug too. I would propose to add a boolean flag "hide small forces" for this feature. Would that be ok for you @wjwwood ?

Fine by me.


Add a reticle that moves with the user's head

https://aframe.io/examples/showcase/cursor/

oh cool. check this  out. Look down where your feet would be and you can see the prev next interaction.


Outstanding issues

[x] patching did not update the list
[x] limiting only works with pagination
[ ] paginated metadata should be updated
[ ] re-fetch when list size < $limit value (on the client)
[ ] caching
[x] Make Rx an option (no hard dependency)
[ ] investigate replaying events (time travel)

Is there an ETA on when this will be ready?

You can use it already. The list items not checked off can be solved by using the always strategy when needed.

From using it so far I found it fairly solid so we can track individual issue separately.
For this one I have only one follow-up: https://github.com/feathersjs/feathers-reactive/issues/24


Fix raw

Fix a bug when using raw option in common.log

@pose @indexzero Only webhook tests fail atm which are tests we removed anyway. Merging to unblock myself. Will take scrutiny later if needed


DEAD

rip
dead
🐸

pls fix

is this true? saw it on reddit (lol)

@clapbr Joshua plans to work on a d3d9 module in dxvk instead of DXUP

@clapbr https://github.com/Joshua-Ashton/d9vk

that was fast, thanks frogs

is this true? saw it on reddit (lol)

What subreddit?
Also its kind of true. I'm taking a break from this project for a while. I'll probably come back to it if and when I need to.

is this true? saw it on reddit (lol)

What subreddit?
Also its kind of true. I'm taking a break from this project for a while. I'll probably come back to it if and when I need to.

linux_gaming vk9 dead thread


Make the project yml more efficient

Currently, the project yaml is fairly inefficient with more copy and paste that should be necessary. It might be ideal to cut down on this by adding arguments to workflows and calling the same functions. Assuming that is possible.

metrics are currently note saved with the model name
Similarly, the model is trained is saved under the name model-best and model-last instead. Which doesn't allow for running multiple models at once.

Update: Seemingly this is currently not an option. I will leave this issue here in case people find it useful.


Add ARM NEON intrinsics to align

Changes:

adding align_neon class

neon-align.cpp is based on the code in sse-align.cpp
tested on Ubuntu 22.04, OrangePi5 (RK3588s, 8GB of RAM) and RealSense D435.

I optimized depth align processing for ARM CPUs.
Please review it.

Can one of the admins verify this patch?

@fateshelled  I merged the other PR and now we have a conflict.
Please rebase and see if fixed.
Thanks

@Nir-Az Thanks for reviewing. I rebased and fixed it.


Swagger correctness fix

ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[x] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

For linter failure, looks like this path is already existed and you are just adding the missing GET on it?

For linter failure, looks like this path is already existed and you are just adding the missing GET on it?

@zizw123 : yes that is correct. we're just fixing the completeness with GET recoverypoints API.

For linter failure, looks like this path is already existed and you are just adding the missing GET on it?

@zizw123 : yes that is correct. we're just fixing the completeness with GET recoverypoints API.

Yeah, in this case, please take a look at https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process
Also if you guys have any future plans to fix this bad pattern?

For linter failure, looks like this path is already existed and you are just adding the missing GET on it?

@zizw123 : yes that is correct. we're just fixing the completeness with GET recoverypoints API.

Yeah, in this case, please take a look at https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process
Also if you guys have any future plans to fix this bad pattern?

@zizw123 : will suppress the warning for now for the existing pattern. going forward we'll be mindful for any new APIs

For linter failure, looks like this path is already existed and you are just adding the missing GET on it?

@zizw123 : yes that is correct. we're just fixing the completeness with GET recoverypoints API.

Yeah, in this case, please take a look at https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process
Also if you guys have any future plans to fix this bad pattern?

@zizw123 : will suppress the warning for now for the existing pattern. going forward we'll be mindful for any new APIs

@zizw123 suppressed the linter error, pls review

For linter failure, looks like this path is already existed and you are just adding the missing GET on it?

@zizw123 : yes that is correct. we're just fixing the completeness with GET recoverypoints API.

Yeah, in this case, please take a look at https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process
Also if you guys have any future plans to fix this bad pattern?

@zizw123 : will suppress the warning for now for the existing pattern. going forward we'll be mindful for any new APIs

@zizw123 suppressed the linter error, pls review

Please also include a work item for fixing the pattern in future, thanks.

@raych1 - Please help review the error: https://github.com/Azure/azure-rest-api-specs/pull/24211/checks?check_run_id=14393884870, thanks!

@scbedd - Could you help check the ModelValidation error here: https://github.com/Azure/azure-rest-api-specs/pull/24211/checks?check_run_id=14393835433. The author thinks this error has nothing to do with this PR, can we just ignore it? Thanks for your help in advance!

@kalyanachakravarthikarri-az , please fix duplicated schema issue that caused Go sdk generation failure.
error   | PreCheck/DuplicateSchema | Duplicate Schema named 'MultiUserAuthorization' (4 differences):
cmderr	[generator automation-v2] [ERROR] - type: "object" => "string"
cmderr	[generator automation-v2] [ERROR] - properties: {"multiUserAuthorization":{"x-ms-enum":{"name":"MultiUserAuthorization","modelAsString":true},"$ref":"#/components/schemas/MultiUserAuthorization"}} => <none>
cmderr	[generator automation-v2] [ERROR] - enum: <none> => ["Invalid","Enabled","Disabled"]
cmderr	[generator automation-v2] [ERROR] - x-ms-enum: <none> => {"name":"MultiUserAuthorization","modelAsString":true}; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
cmderr	[generator automation-v2] [ERROR] fatal   | Error: 1 errors occured -- cannot continue.

@kalyanachakravarthikarri-az , please fix duplicated schema issue that caused Go sdk generation failure.
error   | PreCheck/DuplicateSchema | Duplicate Schema named 'MultiUserAuthorization' (4 differences):
cmderr	[generator automation-v2] [ERROR] - type: "object" => "string"
cmderr	[generator automation-v2] [ERROR] - properties: {"multiUserAuthorization":{"x-ms-enum":{"name":"MultiUserAuthorization","modelAsString":true},"$ref":"#/components/schemas/MultiUserAuthorization"}} => <none>
cmderr	[generator automation-v2] [ERROR] - enum: <none> => ["Invalid","Enabled","Disabled"]
cmderr	[generator automation-v2] [ERROR] - x-ms-enum: <none> => {"name":"MultiUserAuthorization","modelAsString":true}; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
cmderr	[generator automation-v2] [ERROR] fatal   | Error: 1 errors occured -- cannot continue.

looking into this

@kalyanachakravarthikarri-az , please fix duplicated schema issue that caused Go sdk generation failure.
error   | PreCheck/DuplicateSchema | Duplicate Schema named 'MultiUserAuthorization' (4 differences):
cmderr	[generator automation-v2] [ERROR] - type: "object" => "string"
cmderr	[generator automation-v2] [ERROR] - properties: {"multiUserAuthorization":{"x-ms-enum":{"name":"MultiUserAuthorization","modelAsString":true},"$ref":"#/components/schemas/MultiUserAuthorization"}} => <none>
cmderr	[generator automation-v2] [ERROR] - enum: <none> => ["Invalid","Enabled","Disabled"]
cmderr	[generator automation-v2] [ERROR] - x-ms-enum: <none> => {"name":"MultiUserAuthorization","modelAsString":true}; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
cmderr	[generator automation-v2] [ERROR] fatal   | Error: 1 errors occured -- cannot continue.

looking into this

Hi @raych1 , can you pls check, if the duplicate schema issue is now resolved ?

/azp run

Approved modelValidation as not introduced in this pr.


Disable default pygments stylesheet inclusion

I am running this command:
bundle exec asciidoctor-epub3 book-highlights.adoc -v -D /Users/ryanbigg/books/rails_book/build/epub -o book.epub -B /Users/ryanbigg/books/rails_book -a generation_date=2020-05-01 -a git_version=f0ebc069d -a pdf-fontsdir=pdf-styles/fonts -a pdf-stylesdir=pdf-styles -a epub3-stylesdir=epub-styles -a pdf-style=book -a icons=font -a pygments-css=class -a pygments-style=dracula -a copycss! -a stylesdir=epub-styles

But what ends up happening is that the default pygments css gets appended to the end of the book's HTML document. This ends up clobbering my own pygments styles because the stylesheet is the final thing in the document.
What attribute do I need to specify to prevent this from happening?
After looking at the code, I've come across this linkcss variable which looks like it might toggle the behaviour that I want... but it is fixed to false.
I want to be able to specify my own pygments stylesheets in the epub-styles stylesheets, and not have the default one included at all.

We have linkcss forced to false because we currently cannot include pygments css as a standalone file.

Yeah, I was looking at the code earlier and came to a similar conclusion.
Is there a way to disable that CSS being inserted for ePub books at all?

You can change them. You currently cannot remove them outright. See https://github.com/asciidoctor/asciidoctor-epub3/issues/43
I am in favor of the request to allow the stylesheets that get loaded / imported to be customized.
One way to do this would be to honor the stylesheet (or stylesheets) attribute, which could accept a comma-separated list (still relative to epub3-stylesdir).

linkcss doesn't make sense in this context. That's only for the default HTML converter.

Maybe I am misunderstanding something here.
What I am talking about is the pygments style sheet that gets appended to the bottom of the HTML file when the ePub is generated. I thought ePub-styles directory was just for the OTHER styling for the ePub, not pygments specifically?

I'm refreshing my memory...

We had pygments-css: style hardcoded from the very beginning of asciidoctor-epub3: https://github.com/asciidoctor/asciidoctor-epub3/commit/876185b42a6995cda542e737a52641da921fcd53#diff-9f5d719f2acedfb9bfc208ef70b63496R47
Later, in 8e93e26c43006f3033ba35a981a20251e2de7725, when I was adding support for other highlighters, I transformed that into a highlighter-agnostic solution via linkcss: false.
But there wasn't ever a moment in asciidoctor-epub3 history when it supported specifying styles via CSS classes and (using a separate CSS file for those classes or disabling of built-in pygments CSS styles).

First, I want to mention that you can change the built-in Pygments style / theme that is used using -a pygments-style=pastie (or similar).
Marat is correct that this converter has never had support for doing anything other than dumping the CSS from the theme into chapter HTML file. If that is a feature we want, it would have to be designed (from requirements to design to implementation).

I believe that moving highlighter CSS into a separate file and inclusion of custom user CSS after that one would be enough.
If you think there is room for more advanced support, I'm all ears.

Agreed. Instead of embedding the CSS, it should be written to a file in the archive (like epub3-pygments.css or something). But you'd still need to think about how a user might provide the file from a custom location without also having to replace all the other stylesheets too.

@mojavelinux Appending CSS to the end of HTML is causing error on Moon+ Reader app for Android. The app is displaying the stylesheet

@slonopotamus is the person to ping.

@zorro thanks for the report, I'll make sure it renders properly in Moon+ when will be moving highlighter style to separate CSS file.

@mojavelinux I suddenly understood that moving CSS to a separate file is not going to work because highlighter CSS file reference is added at the end of HTML body. How do people override highlighter theme when using HTML backend?

Okay, current position of CSS reference is illegal. It was fixed in HTML5 backend in https://github.com/asciidoctor/asciidoctor/issues/3462. We should do the same.

I think I overconfused myself in previous comments. We currently inject syntax highlighter CSS at the end of <head>, not <body>. So everything is fine and this issue can be closed.


build: remove sphinx-book-theme constraint to use latest release

Description
This PR removes the existing sphinx-book-theme to use the latest release. Here's the comment we realized we need to utilize the constraint: https://github.com/openedx/openedx-events/pull/169#discussion_r1073980224
Also, we updated the theme configurations for the latest suggested on the open edx docs: https://docs.openedx.org/en/latest/developers/how-tos/add-sphinx-docs-to-a-repo.html.

Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@mariajgrimaldi 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


Common Tenants Folder

@jland-redhat suggested the idea of creating a "common" overlay folder that can be included in the app-generator for the tenants when there is no difference between the different tenants.
This update adds his suggestion and cleans up many of the tenant folder overlays.

Example app successfully synced with common folder:


Issue #SB-22183 fix: removing pattern check in white list file

This is already handled as part of a different PR. Hence closing this.

This is already handled as part of a different PR. Hence closing this.


Glitchy view while stuck in spider webs

The physics for spider web seems to be a bit buggy (no pun intended):

You can get stuck on top of the web and your view is constantly attempting to drop. It may be better to allow players to drop down to the block the web is on and/or only prevent horizontal movement while in the air
The view is very shaky while stuck in web, as if it's spamming a position set rather than disabling movement

As a side-note, I wonder if copying the way Minecraft's spider webs are handled would help with the glitching view issue; the movement-slowing effect could be increased to the point where the player doesn't move. Falling speed could remain the same as vanilla spider webs so as to fix the first point.

I like your suggestion, I've noticed the same and it's on my todo list. I will take a look at the code for it.

A short-term fix was added in 4.0.8.


Support for DesktopDatePicker

Hello,
thanks for the library, it looks great.
Is there a way to integrate DesktopDatePicker from https://mui.com/x/api/date-pickers/desktop-date-picker/
Any hints would be great.

Added DatePicker as you wanted
Time Picker & DateRange Picker coming soon

DatePicker

<HookDatePicker />
<HookStaticDatePicker />
<HookDesktopDatePicker />
<HookMobileDatePicker />


UF-337: Rich Text HTML Editor

+1  just some minor comments.
@paulovmr thanks !

@ederign Fixing it now, thanks for the review! I'll let you know when it is ready for merge.

@ederign Done.

thanks @paulovmr , waiting for jenkins


Display permission tab in pages only if user has permission

Refactors the content navigation and applies a security check for the permission tab in the page form.
Needs to be merged with https://github.com/massiveart/husky/pull/472 and https://github.com/sulu-io/sulu-standard/pull/440
tasks:

[ ] test coverage
[ ] gather feedback for my changes
[ ] submit changes to the documentation

informations:

q
a

Fixed tickets
fixes #406

BC breaks
none

Documentation PR
https://github.com/sulu-io/sulu-docs/pull/25

Tested, seems fine.

Created a new issue for our discussion on the exception handling: https://github.com/sulu-io/sulu/issues/1024


From the second upload, the files value gets repeatedly.

The first upload will work normally.
But from the second upload, it returns the files value twice.
When you restart the node server, it behaves as the first upload case again and returns the files value twice as the second upload case. Anyway caching on the server? Looks like it did.
I do not know the details.
I left the source code and log below.
sample code
router.post('/upload', (req, res) => {
  form.parse(req, (err, fields, files) => {
    if (!err) {
      console.log('=============================');
      console.log(files);
      console.log('=============================');
      res.end('success');
    }
  });
});

first log
{ 'img_files[]\'':
   File {
     domain: null,
     _events: {},
     _eventsCount: 0,
     _maxListeners: undefined,
     size: 33241,
     path: '/Users/cheese/WebstormProjects/s3_img_upload/temp/upload_a4e94f43ef8aa09c947ba4adc5e27012.png',
     name: 'IMG.png',
     type: 'image/png',
     hash: null,
     lastModifiedDate: 2017-02-23T13:40:00.508Z,
     _writeStream:
      WriteStream {
        _writableState: [Object],
        writable: false,
        domain: null,
        _events: {},
        _eventsCount: 0,
        _maxListeners: undefined,
        path: '/Users/cheese/WebstormProjects/s3_img_upload/temp/upload_a4e94f43ef8aa09c947ba4adc5e27012.png',
        fd: null,
        flags: 'w',
        mode: 438,
        start: undefined,
        autoClose: true,
        pos: undefined,
        bytesWritten: 33241,
        closed: true } } }

second log
{ 'img_files[]\'':
   File {
     domain: null,
     _events: {},
     _eventsCount: 0,
     _maxListeners: undefined,
     size: 162672,
     path: '/Users/cheese/WebstormProjects/s3_img_upload/temp/upload_09b29717e30a95ed44dac9ef28aaff3c.png',
     name: 'Visual_SQL_JOINS_V2.png',
     type: 'image/png',
     hash: null,
     lastModifiedDate: 2017-02-23T13:41:37.037Z,
     _writeStream:
      WriteStream {
        _writableState: [Object],
        writable: false,
        domain: null,
        _events: {},
        _eventsCount: 0,
        _maxListeners: undefined,
        path: '/Users/cheese/WebstormProjects/s3_img_upload/temp/upload_09b29717e30a95ed44dac9ef28aaff3c.png',
        fd: null,
        flags: 'w',
        mode: 438,
        start: undefined,
        autoClose: true,
        pos: undefined,
        bytesWritten: 162672,
        closed: true } } }
{ 'img_files[]\'':
   File {
     domain: null,
     _events: {},
     _eventsCount: 0,
     _maxListeners: undefined,
     size: 162672,
     path: '/Users/cheese/WebstormProjects/s3_img_upload/temp/upload_09b29717e30a95ed44dac9ef28aaff3c.png',
     name: 'Visual_SQL_JOINS_V2.png',
     type: 'image/png',
     hash: null,
     lastModifiedDate: 2017-02-23T13:41:37.037Z,
     _writeStream:
      WriteStream {
        _writableState: [Object],
        writable: false,
        domain: null,
        _events: {},
        _eventsCount: 0,
        _maxListeners: undefined,
        path: '/Users/cheese/WebstormProjects/s3_img_upload/temp/upload_09b29717e30a95ed44dac9ef28aaff3c.png',
        fd: null,
        flags: 'w',
        mode: 438,
        start: undefined,
        autoClose: true,
        pos: undefined,
        bytesWritten: 162672,
        closed: true } } }

Hm, strange. Don't seems like a cache to me.

solution
before
const form = new formidable.IncomingForm();
router.post('/upload', (req, res) => {
  form.parse(req, (err, fields, files) => {
    if (!err) {
      console.log('=============================');
      console.log(files);
      console.log('=============================');
      res.end('success');
    }
  });
});

after
router.post('/upload', (req, res) => {
const form = new formidable.IncomingForm();
  form.parse(req, (err, fields, files) => {
    if (!err) {
      console.log('=============================');
      console.log(files);
      console.log('=============================');
      res.end('success');
    }
  });
});

I created an instance of the form within the logic for problem-solving.

The other was the same source code from the development environment to function normally. (v7.2.0)

Node version issue. As a result of the same version as the version test normal operation with the same problem

I'm not sure exactly why.

A simple summary.

English is difficult to use. Please understand

Hm, yea creating the instance make sense to be inside the route.


Open Popover via jQuery and unbind after certain event

Hi Sandy, thank you for this, great work.
I am building a form validation and if a field is empty I want to show this popover, Maybe I'm a bit off with this implementation. What I go so far is to bind the popover to the right input field. Two things I am missing:

Open the popover from jQuery ($('input#emptyfield').click(), $('input#emptyfield').toggle(), and $('input#emptyfield').webuiPopover('show') don't work for me)
Unbind the popover from the inputfield so that I can bind it to another one.

This is probably similar to issue " is it possible to initialize pop and show in one click #53 ", however this doesn't work for me.
Do you have any idea how to implement this / is this something your solution can do?
Thank you, Didadan

Thanks very much for your advice,I didn't consider this situation when wrote the plugin.
The problem is that the plugin auto handled the click event on both trigger element and body, I'm trying to fixed this, my solution is add  trigger option : 'manual' ,  if  trigger is 'manual', the plugin will not handle the    click events.
Then you can write code like this
        $('#input').webuiPopover();
        $('#input').on('click',function(){
            $(this).webuiPopover('show');
        });

I'm testing on the solution and will update the code.Hopes it will help you!

I guess the same will then possible for 'hide'.
Thanks very much! And also for the quick response.

Hi sandy , thanks for your plugin.
Here i'm trying to add this plugin with react component.
In click event of button , I have written the following code.
  $("#openPopover").webuiPopover({url:'#popoverContent',trigger:'manual',closeable:true});
   $("#openPopover").webuiPopover('show');

popover is opening and content is showing .
but inside content i have React components , there events are not firing due to this i'm unable to change the state of that particular component.
Can you please give me some suggestion , How can I use ?
Thanks.


VCF header fields missing

Hello Fritz & SURVIVOR dev team,
What.
I attempted to use the VCF file generated by SURVIVOR with bcftools, as for instance recommended in issue https://github.com/fritzsedlazeck/SURVIVOR/issues/173. However, bcftools suffers from a bug that originates from SURVIVOR I think.
Error.
When using bcftools (sort+index) on SURVIVOR's truthset VCF, I get warnings and an error regarding the VCF header not matching the FORMAT fields.
bcftools sort -o simulated.sorted.vcf.gz -O z simulated.vcf; bcftools index -t simulated.sorted.vcf.gz

Writing to /tmp/bcftools-sort.9eyTIT
[W::vcf_parse_format] FORMAT 'GL' is not defined in the header, assuming Type=String
[W::vcf_parse_format] FORMAT 'GQ' is not defined in the header, assuming Type=String
[W::vcf_parse_format] FORMAT 'FT' is not defined in the header, assuming Type=String
[W::vcf_parse_format] FORMAT 'RC' is not defined in the header, assuming Type=String
[W::vcf_parse_format] FORMAT 'DR' is not defined in the header, assuming Type=String
[W::vcf_parse_format] FORMAT 'DV' is not defined in the header, assuming Type=String
[W::vcf_parse_format] FORMAT 'RR' is not defined in the header, assuming Type=String
[W::vcf_parse_format] FORMAT 'RV' is not defined in the header, assuming Type=String
[E::bcf_write] Unchecked error (2), exiting

I looked into the code at https://github.com/fritzsedlazeck/SURVIVOR/blob/ed1ca5188a2d9286d582417b7a65938c768df995/src/simulator/SV_Simulator.cpp#L951 where the FORMAT field for SNP variant records is written. In case the print_vcf_header2 function above is the corresponding header than the FORMAT fields indeed do not match.
Solution.
I propose two trivial solutions here:

Removing the FORMAT fields from the SNP variant records.
Adding the FORMAT fields to the function that generates the header.

I am voting for solution 1 here because:
a) I think FT, RC, DR, DV, RR, RV are ancient relics of Lumpy unrelated to SNPs. Also these FORMAT fields have been commented out throughout most of SURVIVOR.
b) The missing fields are not part of the VCF4.2 standard and should not be present if not defined and used.
c) I tested that the VCF file generated by SURVIVOR works flawlessly with bcftools if the fields are removed from SNP records. (see hotfix below)
Hotfix.
sed -i 's/GT:GL:GQ:FT:RC:DR:DV:RR:RV/GT/g ' simulated.vcf where simulated.vcf is the VCF by SURVIVOR.

I am suffering the exact same problem here as you were. But I did not set SNP cuz I am not intended to study SNP, only SVs are of my interest.
So does it mean that I can use the:
sed -i 's/GT:GL:GQ:FT:RC:DR:DV:RR:RV/GT/g ' simulated.vcf

To fix it?
Thanks

OK I figured it out, besides that line of code, we also need to add headers like this manually:
##FILTER=<ID=LowQual,Description="Low quality">
##INFO=<ID=PRECISE,Number=0,Type=Flag,Description="Precise variant">

Hi @rl4940,
the issue I had, the hotfix I proposed (in this issue) as well as the PR #190 aim for a format correction of SNV records only. However, I hypothesize that if your callset does not include the additional fields (GQ:FT:RC:DR:DV:RR:RV) it's probably safe to use the sed command from above.

(disclaimer: I am not a maintainer of SURVIVOR, I just tried to fix a bug here)


Accordion: use details summary instead?

Any opinions on According using <details>/<summary> instead of the current implementation?
IMO it's more native, plus on chromium it will automatically expand the relevant <details> when a user CTRL+F the page.
Downside is you can't have different level headings in the title/summary.
<details>
  <summary>{title}</summary>
  {children}
</details>

In any case, would also like to see the Accordion automatically expand when printing the page.

Can try a PR if you'd like

Hello @svict4 👋
For the accordion component, we have tried our best to follow the official WAI-ARIA Authoring Practices which does not include the details/summary elements.
These elements are handy when you have no other option, like in a GitHub issue or something. But they do have significant short-comings though in regards to accessibility, styling, animation, event handling etc.
There are couple of articles which talk about this in more detail:

https://daverupert.com/2019/12/why-details-is-not-an-accordion/
https://adrianroselli.com/2019/04/details-summary-are-not-insert-control-here.html

In regards to your use case, we haven't really much effort into print styles yet. But I've put down on our backlog that it's something you are interested in 👍


Add tests for IPC link

Codecov Report

Merging #95 (6ca8737) into main (3cb91a7) will increase coverage by 31.18%.
The diff coverage is 42.42%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main      #95       +/-   ##
===========================================
+ Coverage   22.30%   53.48%   +31.18%
===========================================
  Files           9       10        +1
  Lines         408      430       +22
  Branches       18       44       +26
===========================================
+ Hits           91      230      +139
+ Misses        317      200      -117

Impacted Files
Coverage Δ

...kages/electron-trpc/src/main/exposeElectronTRPC.ts
0.00% <0.00%> (ø)

packages/electron-trpc/src/types.ts
0.00% <0.00%> (ø)

packages/electron-trpc/src/renderer/ipcLink.ts
85.71% <73.68%> (+85.71%)
:arrow_up:

packages/electron-trpc/src/renderer/utils.ts
67.56% <0.00%> (+67.56%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


multi-entry: temporarily change docs to singular "module"

I spent ten minutes with adding globs and comma-separated paths before giving up going into the issues and searching/finding #175 / #367.
Maybe delete the (s) until the issue is resolved to prevent other people from doing the same. :)

Done, I simply used the "edit"-buttons in GitHub, guess you can squash when you merge?

@allcontributors please add @KATT for docs


Shuffle button gone missing

When you go to Collection / Likes the shuffle button next to the view options no longer appears. It used to be there a week or so ago.

This app uses the actual SoundCloud website for it's UI so if it's gone, that was SoundClouds decision.

Weird, it's gone from the website now too but when I first posted this issue, it was definitely still there because I reverted to using the website for a few days just so I could use the shuffle feature.

That was most likely the website being cached.


feat(CXF-8752): list of redirectable verbs configurable.

https://issues.apache.org/jira/browse/CXF-8752

Looks OK to me, if we can add a test for it. @reta any major objections?

Left a comment, also agree that tests are needed, thanks @coheigea !


Travis no longer compiles, tests any code.

Since build #102, corresponding to commit b11898b, Travis no longer runs the ./configure && make && make check line. I can't see anything in that commit that may have broken the Travis integration.

Really weird :(

Must have been a problem on Travis' side. Everything seems to be fine now.


tap: update core tap --force messaging

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Per this suggestion: https://github.com/Homebrew/brew/pull/17227#discussion_r1590630520
CC: @MikeMcQuaid

Thanks again @apainintheneck!


Add support for networking opts

allows to customize public network name
according to the cloud provider

Fixes #88
/assign @dims
Special notes for your reviewer:
first impl.
don't know where to update the docs

superseeded by #94


Added EmbedBuilder#setFooter for convenience

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[x] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation
[ ] Other: _____

Closes Issue: NaN
Description
I only added EmbedBuilder#setFooter without the icon url parameter for convenient use so that we wouldn't have to pass a null object when we don't want to use a footer icon.

I'm not sure that this is necessary (albeit I don't have a strong opinion either way). However, your implementation should be no more complicated than something like this:
public EmbedBuilder setFooter(String text)
{
    return setFooter(text, null);
}

Neccessity is subjective. For me this is needed qol addition. There is really no point at passing null object to a method. Also it's confusing. Fixed the code btw.

In any case, feature additions should only go to the v4 branch.

Isn't v4 complete rewrite? People still use v3 and development branch is for v3. Besides this is not exactly new feature it's just a simple qol addition and there is no harm in merging it.

No it is not a rewrite it just does a lot of breaking changes, this can easily be added there. v3 only receives important bug fixes now.

Closed in favor of #980


Video Caption Model

Hi,
Thanks for your great work, I wanna know how can i use the video caption model?
Kangning

I'm not sure about your specific problem, but to use VideoChat for caption, you can follow the demo in https://github.com/OpenGVLab/Ask-Anything/blob/main/video_chat/demo.ipynb

sorry to bother, I wanna ask another question.
When running video_chat_with_ChatGPT/app.py, I got this problem:
RuntimeError: CUDA error: CUBLAS_STATUS_INVALID_VALUE when calling cublasSgemmStridedBatched( handle, opa, opb, m, n, k, &alpha, a, lda, stridea, b, ldb, strideb, &beta, c, ldc, stridec, num_batches)
Could you tell me how to fix it?

I find the solution, that is you should change the torch version to 1.12.1 and the torchvision version to 0.13.1

Thanks for your try~


Scripts fail for Xiaomi firmware images

we noticed that there were no results stored for Xiaomi images sourced from https://new.c.mi.com/global/miuidownload/index
It happens to all of the images we tested until now.
Following I send you the stack trace:
INFO  - done
Scanning app: com.google.android.marvin.talkback
APP com.google.android.marvin.talkback scanned before.
The results of the com.google.android.marvin.talkback app were obtained from App Defence Aliance.
mkdir: cannot create directory '/usr/src/app/android/': File exists
mkdir: cannot create directory '/usr/src/app/android/': File exists
Traceback (most recent call last):
  File "/usr/src/app/utils/collect_data.py", line 177, in <module>
    collect_data_script(uuid_execution)
  File "/usr/src/app/utils/collect_data.py", line 77, in collect_data_script
    value = formula.calculate_formula(0.01, 0.01, tests_list, uuid_execution)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/app/./utils/formula.py", line 82, in calculate_formula
    M = get_m_value(p, tests, uuid_execution)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/app/./utils/formula.py", line 53, in get_m_value
    total_fails += r[i]
TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType'
Analysis successfully executed
[+] Ran the Dekra script

proposed fix:
check if the permission exists in the configs (i.e. r[i] is not None) before adding to the total_fails and other variables.

Hello Ernst,
This issue has been resolved in the latest version of the script uploaded today. This problem didn't occur because of any permission issue in config file, it was because a Python file was being launched as a process and we were taking what it displayed as the output. However, in some cases, an exception was thrown, so the expected value by the test case was an integer, but it captured the exception instead. This has been fixed, and now even though the exception is displayed on the screen, the expected value (an integer) is returned as a parameter. Due to this error, both the verdict value for this test case in the Report table and the matches found value in the Total_Fail_Counts table were NULL, due to to this exception.
Check it and we will close the issue.

Quickly tested it with one image and the fix seems to work, thanks.


Add support to Wireguard VPN

It might make sense to switch to Wireguard instead of using OpenVPN for the VPN part, or at most support both.
-Ease of configuration
-Supports the most advanced encryption standards
-More performing than OpenVPN
And the interesting thing is that it is no longer so niche, now the largest VPN providers support it.
FYI:
https://protonvpn.com/blog/wireguard-donation/
https://mullvad.net/en/help/why-wireguard/

Hi, thank you for the feedback.
Yes I'm definitely willing to add wireguard support because of it's low cpu usage.
I'll check what can be done.

It's not exactly what you  asked for but #83 if you care to try.
Are you wanting wireguard to mask torrents/transmission or for connecting to another location to access the stack?