Added support for custom animations

You can now pass in animation schema objects in addition to animation names. For more information on what these objects look like, see here.

Thanks @Nickersoft , are you able to address the stuff I detailed in the issue? Otherwise I'll merge it right now and I'll do it as soon as I have some free time, butI won't release it on npm until it has been done though.

Merged! Thank you @Nickersoft, I'll give it a try right now and if it works I'll publish it on NPM asap.

Oh crap! I just force pushed a fix I noticed in my latest commit and it was too late! I forgot to add a "props" argument to _buildAnimations(). The function should look like this:
  _buildAnimations(props: Props => {}) {
    let animationIn = props.animationIn;
    let animationOut = props.animationOut;

    if (this._isObject(animationIn)) {
        this._makeAnimation("animationIn", animationIn);
        animationIn = "animationIn";
    }

    if (this._isObject(animationOut)) {
        this._makeAnimation("animationOut", animationOut);
        animationOut = "animationOut";
    }

    this.animationIn = animationIn;
    this.animationOut = animationOut;
  }

and both times its called the right props need to be passed in. It's an easy fix if you want to just do it before publishing.

I'll do it, no worries :)

Great thanks!

Fixed and landed on v4.0.0.
Willing to give it a test @Nickersoft? :)

@mmazzarolo Just tested it now and it works great!


Dask trying to save file with too long name

This happens when working with huge dataframe larger than available RAM and dask computational graph is very big. Dask tries to spill data to disc and create too long file names for this.
Traceback from DASK worker:
DaskErrorToLog.txt
Error was obtained on Ubuntu 18.0.4 with file system ext4 (maximum filename length is 255)
DASK version is 2.1.0

@denisvlah not sure how this error is manifesting but I would recommend two things:

upgrade to dask 2.3.0 is possible
build a minimal reproducible example we can run: https://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports

@quasiben
The error is reproduced on dask 2.3.0.
Cannot provide a tiny code snippet to reproduce this because it would require to port all my code and data.
Created a fix and a pull request for it:
https://github.com/dask/zict/pull/27

Should be fixed by https://github.com/dask/dask/pull/5383.


External review housing production

still need to wait for Max changes merged in to create the final combined external review files. Script ready to be reviewed.

Hey @SashaWeinstein  I think I was able to side step the join issue by setting the dataframe index to the geographies and then do pd.concat. I think it should handle the general case. Please let me know if this makes sense and happy to talk through if needed.

This looks good to me as well - I think we should try to settle on same naming conventions for our csv's similar to the way we write issues. happy to chat about this whenever

Hey @SashaWeinstein could you point to the file I made .csv.csv mistake. I don't think the final merged final has an extra csv extension

ok got it. I think this doesn't impact this work for now. Should we merge this in?

Ok I think I figured out the issue, it's the historic indicators that are saved as .csv.csv in the internal review folders that these read from. Can you rename these and then we merge?
Also @mbh329 can you do an eyeball check that the numbers for your indicator are the same in the internal review and the external? As an additional set of eyes for quality just to be sure.
Sorry if this is overkill, we have a couple minutes before standup and I feel like we might as well just use this time to clean and check

Eyeball checked housing production myself, it all looks good

The data for my indicator looks good, I checked it against a few pumas and boroughs

Uploaded to digital ocean, all looks good

Awesome, looks great

Haven’t checked digital ocean and but this all look good.


Adding option to set primary key on modifyIncrement

Currently modifyIncrement adds PRIMARY KEY by default to column:
https://github.com/laravel/framework/blob/master/src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php#L735
Would be fine if is possible to add an option to NOT add primary key to this column, when adding another primary key.
Example that fails:
$table->unsignedInteger ('id', true);
$table->integer('foo')->unsigned ();
$table->primary(array('id', 'foo'));

Error: 1068 Multiple primary key defined.
If there is an option to adding an autoincrement index without primary key, like: $table->unsignedInteger ('id', true, false);, would help to fix this error.
References:

http://stackoverflow.com/questions/23923148/how-to-create-multiple-primary-key-with-auto-increment-include-in-laravel-migrat
http://laravel.io/forum/06-21-2014-migration-add-primary-key-to-id-username-email?page=1

Why don't you add a unique index for the id & foo columns and keep the id primary?

First Paragraph of the accepted answer in the below link will give you the reason of not having an auto-incremented column as your primary key.
http://dba.stackexchange.com/questions/3467/mysql-why-is-auto-increment-limited-to-just-primary-keys

I'm closing this since it's not actually a bug report.
For suggestions and feature requests please use the https://github.com/laravel/internals repo.


feat(repo update): Add flag for failing command if any update of a repo fails

What this PR does / why we need it:
The current implementation of helm repo update command is to return success (exit code 0) even if it fails to update 1, many or all repositories in the list.  The behaviour cannot be changed in Helm 3 as it would break backward compatibility (rightly or wrongly , users expect it to work in a certain way).  This PR adds a flag fail-on-repo-update-fail which when set will fail when any repo fails to update.
The addition of the flag for Helm 3, provides users with being able to test if any update of repositories fail without having to parse the output of the Helm command. A proposal on how the behaviour should work in future Helm major release will be submitted for Helm 4.  Check out #10016 for more details.
Partial #10016
Special notes for your reviewer:
If applicable:

[x] this PR contains documentation
[x] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

Cherry picks are not necessary for major/minor releases; just patch releases. Major/minor releases are cut straight from main, whereas patch releases cherry-pick patches into the release branch.
https://helm.sh/docs/community/release_checklist/#patch-releases
Removing the label.

My bad, sorry @bacongobbler. I think it might have been an auto response.


Mismatched data

It looks like for many of the timezones, the value and text properties reflect the values for standard time, whereas the abbr and offset properties refect the values for DST.
For example, for Eastern Standard Time, value === 'Eastern Standard Time' and text has an offset of UTC-05:00, which are the correct values for standard time. However, offset === -4, and abbr === 'EDT', which stands for Eastern Daylight Time.

@BehindTheMath fell free to make pull request

PST is "pacific standard time" but here it says "pakistan standard Time"

When isdst=true, abbr and offset follow.
In my use case, I only use Text and utc[0] = "America/Detroit".
I use the TZ database to do the rest.

pakistan standard Time should be PKT

I think it should have been abbr_dst and offset_dst.
But this is a breaking change.

@dmfilipenko How about if we would change the format to something like this:
interface TimezoneDetails {
  value: string;
  abbr: string;
  offset: number;
  text: string;
}
export interface Timezone extends TimezoneDetails {
  dst: TimezoneDetails | false | null;
  utc: string[];
}

Here's an example of what it would look like:
  {
    "value": "Eastern Standard Time",
    "abbr": "EST",
    "offset": -5,
    "text": "(UTC-05:00) Eastern Time (US & Canada)",
    "dst": {
      "value": "Eastern Daylight Time",
      "abbr": "EDT",
      "offset": -4,
      "text": "(UTC-04:00) Eastern Time (US & Canada)",
    },
    "utc": [
      "America/Detroit",
      "America/Havana",
      "America/Indiana/Petersburg",
      "America/Indiana/Vincennes",
      "America/Indiana/Winamac",
      "America/Iqaluit",
      "America/Kentucky/Monticello",
      "America/Louisville",
      "America/Montreal",
      "America/Nassau",
      "America/New_York",
      "America/Nipigon",
      "America/Pangnirtung",
      "America/Port-au-Prince",
      "America/Thunder_Bay",
      "America/Toronto",
      "EST5EDT",
    ],
  },
  {
    "value": "Venezuela Standard Time",
    "abbr": "VST",
    "offset": -4.5,
    "text": "(UTC-04:30) Caracas",
    "dst": false,
    "utc": [
      "America/Caracas",
    ],
  },

The value, abbr, offset, and text properties would be in the root object for standard time, and again as properties of the dst property if applicable.
This would be a breaking change, and would require a major version bump.

@BehindTheMath This is a huge change. Unfortunately, I don't have much time to do this

I might do it myself and submit a PR.
What do you think of such a schema?

@BehindTheMath from a first view it might be useful. But what if we wouldn't make a nested object and add another timezone
{
 	"value": "Eastern Daylight Time",
    "abbr": "EDT",
    "offset": -4,
    "dst": true,
    "text": "(UTC-04:00) Eastern Time (US & Canada)",
    ...
},
{
	"value": "Eastern Standard Time",
    "abbr": "EST",
    "offset": -5,
    "text": "(UTC-05:00) Eastern Time (US & Canada)",
	"dst": false
}

I prefer to left this structure a flat

@dmfilipenko My issue with that way is that there's no relationship between standard and daylight timezones. So if I have one, there's no easy way to get the other.

@BehindTheMath I was thinking about and seemed like it is reasonable. Lets try to do this

@BehindTheMath any progress on this? This is so close to what we need

I kind of gave up on it and started using Luxon instead.


docs: update root_validator references to model_validator in v2

Change Summary
Some documentation references to root_validator from v1 have persisted, so I updated them to model_validator.  The changes made in this PR do not impact functionality.
Related issue number
NA
Checklist

[ ] Unit tests for the changes exist
[X] Tests pass on CI and coverage remains at 100%
[X] Documentation reflects the changes where applicable
[X] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review


Add fontsize property to ListView

This should be simple.  Look at ListView.ItemsToColoredText and include AbsoluteSizeSpan similar to ForegroundColorSpan.   Set dp flag to true. Or do we really want RelativeSizeSpan?

Is this fixed with https://github.com/mit-cml/appinventor-sources/commit/231a2b0d376f4239305872d66f5cdae32ff6cc6e ? Please close if that's the case (ignore the comment if it's not) cc/ @cooper-sloan @halatmit


Questions about the project

Hi there! I stumbled upon this project from this discussion: https://github.com/apache/datafusion/issues/970
First of all - thanks everybody for this repo! The federation support for DataFusion insanely relevant to me, and I was thinking about building similar thing, until I found this project. I have a few questions regarding the performance of certain situations, which are mostly relevant for me.
The first one is - how performant is the join of two remote tables, and how is it works? Are you doing smth like querying join eq operands, doing hash join in memory and fetching relevant tables? (for example, a join of two different PostgreSQL tables from different servers, a.k.a FDW). Or there's no optimisations yet in this regard?
Also, I was curious about the final goal of the project - would it be merged into mainstream of DataFusion repo, or it is expected to be in different repo and crate? Thanks in advance

Thanks for the info! I'll look forward to your progress in experimenting with query federations .


AA fails to import Avalon

Testing with this:  https://demo.avalonmediasystem.org/media_objects/pk02cb02n/manifest.json
Import errored consuming label:
item.label = manifest['label']['en'][0]
AA (incorrectly) expects labels to have an English key; the manifest's key is '@none'.  Next step: fix AA client to handle language keys robustly.

@tanyaclement is seeing an undefined method [] for nil for this now.


Lesson 4 PropTypes: TimeoutOverflowWarning

There is written:

After editing the index.jsx file, run your code with learnyoureact run program.js.
When I run it, I have some error TimeoutOverflowWarning. It looks like this:

$ learnyoureact run program.js
Express server is up on port 3000
(node:26965) TimeoutOverflowWarning:<PHONE_NUMBER>000 does not fit into a 32-bit signed integer.
Timer duration was truncated to<PHONE_NUMBER>.
...

Where is the problem? Any ideas?
Node: v10.15.0
  "dependencies": {
    "babel": "^5.8.23",
    "body-parser": "^1.19.0",
    "express": "^4.17.1",
    "express-react-views": "^0.9.0",
    "prop-types": "^15.7.2",
    "react": "^16.9.0",
    "react-dom": "^16.9.0"
  }

Pretty much the same thing happens at the Isomorphic -exercise.
... Except that verify just flood the screen with something like:
(node:11374) TimeoutOverflowWarning:<PHONE_NUMBER>000 does not fit into a 32-bit signed integer.
Timer duration was truncated to<PHONE_NUMBER>.

... Until eventually crashing with:
✗ ?exercises.ISOMORPHIC.fail.connection || common.exercise.fail.connection || fail.connection?


[release-1.25] Backports for 2023-10 release

Types of Changes
Backports for:

https://github.com/k3s-io/k3s/pull/8402
https://github.com/k3s-io/k3s/pull/8458
https://github.com/k3s-io/k3s/pull/8470
https://github.com/k3s-io/k3s/pull/8604
https://github.com/k3s-io/k3s/pull/8602
https://github.com/k3s-io/k3s/pull/8064
https://github.com/k3s-io/k3s/pull/8342
https://github.com/k3s-io/k3s/pull/8624

Verification

Testing
See linked issues
Linked Issues

https://github.com/k3s-io/k3s/issues/8429
https://github.com/k3s-io/k3s/issues/8486
https://github.com/k3s-io/k3s/issues/8473
https://github.com/k3s-io/k3s/issues/8607
https://github.com/k3s-io/k3s/issues/8610
https://github.com/k3s-io/k3s/issues/8614
https://github.com/k3s-io/k3s/issues/8621
https://github.com/k3s-io/k3s/issues/8627

User-Facing Change

Further Comments

S390x is having issues, all other tests are passing. Merging.


Add Jackson 2.15 Configuration Support

Description
#35602
Updates azure-core and azure-core-serializer-json-jackson to configure StreamReadConstraints when Jackson Core and Jackson Databind 2.15.0 and above is on the classpath. StreamReadConstraints configuration is hardcoded to update the maximum String read length to 50MB instead of the default (5MB in Jackson 2.15.0 and 20MB in Jackson 2.15.1 and above). This will be monitored to ensure it resolves all issues reported about String length validations, if it doesn't this configuration may be exposed publicly for consumer setting.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Fixed timer button

I noticed something wrong with the timer button when I was using it. First issue was that if you used the timer more than once before the timer reaches 0, the timer will start counting two seconds at a time. The second issue is that there wasn't a cancel button which is sort of required for a timer button like this. So, I added one for you guys.

submitted merge request to the wrong repo


Add support of experimental transmit_power feature to zigbee2mqtt.

Correction for https://github.com/danielwelch/hassio-zigbee2mqtt/pull/304.
Looks like negative integer values are not supported in range matcher. Range matcher has been removed as it was done in edge version.

Nice, thanks. Looks good.

@danielwelch Is there a second chance for this pull request to be merged? :-) Thanks!


Kibana fails to start if password contains '!' character

We have an '!' character in kibana. This failed the kibana startup with following error:
FATAL CLI ERROR YAMLException: unknown tag !<!*************> at line 7, column 1: Jun 27 23:11:06 eskibana kibana[3411]:     xpack.security.encryptionKey: "L ... Jun 27 23:11:06 eskibana kibana[3411]:     ^

@sukrit007 Could you please provide more information

how are you deploying the template
what git branch are you targeting
what parameters are you providing (please obfuscate sensitive parameters)
could you provide the var/logs/arm-install.log from the Kibana VM

Thanks @sukrit007. This issue has been fixed in #187. In the meantime and as a workaround, avoid starting a password with !.
I would recommend that you not deploy from the master branch as it may contain changes that are not yet deemed finished for a release.


Epic: Read-only replicas

Motivation
Users must be able to start reading replicas on top of existing storage to execute such queries.
DoD
Implementation ideas
Tasks

[ ]

Other related tasks and Epics

https://github.com/neondatabase/neon/issues/1952
https://github.com/neondatabase/neon/issues/769

Added a bunch of related issues. It may be a dup of #769

Duplicates #769


Add assign-class-label mutating webhook

Closes: https://github.com/nerc-project/operations/issues/637
If you want to test this yourself. It is currently deployed in both prod and test cluster. Just add yourself to a group ee440, cs210, or cs506. Request to create a pod in rhods-notebooks namespace (from jupyter tile) and check your pod labels afterward and see if you have a class label. You can also check the logs of the webhook here: https://console.apps.shift.nerc.mghpcc.org/k8s/ns/rhods-notebooks/pods/assign-class-label-webhook-7f6db498fd-rwdmt/logs which should show it assigning label to your pod.
README pending

Also, the organization of the docker/ directory seems a little suspect (you've got a top-level docker/Dockerfile, but then you have `docker/src/python/assign-class-label/Dockerfile underneath it). I would at least separate your two Python apps, maybe:
docker/
├── assign-class-label
│   ├── Dockerfile
│   ├── mutate.py
│   ├── requirements.txt
│   └── wsgi.py
└── group-sync
    ├── Dockerfile
    ├── group-sync.py
    └── requirements.txt

@larsks Please review the changes to this PR when you get a chance.


The organisation would like a report on the top populated cities in a continent

A report which need to contain the following columns

Name.
Country.
District.
Population.

provide a Report on The top number of  populated cities in a continent where the number is provided by the user.
e.g. provide a report on the top 5 cities in the world.


fix a compiler warning

With g++, using numeric value<PHONE_NUMBER>0000000000 without U modifier will cause a compiler warning:
In file included from ../../src/count.cpp:1:0:
../../src/countdecimaldigit.h:68:9: warning: integer constant is so large that it is unsigned
<PHONE_NUMBER>0000000000
         ^
../../src/countdecimaldigit.h:68:9: warning: this decimal constant is unsigned only in ISO C90

Thanks


Implement Union All

Co-Authored-By: Martin Junghanns<EMAIL_ADDRESS>

@DarthMax suggested to put with TagSupport on CAPSSchema and not SchemaImpl since the latter is being used by all implementations (and thus the TagSupport methods could also live on the Schema trait). wdyt?


Exclude unnecessary files from the npm package

Listed a few files and folders which are currently included in the published npm package, while they should not be.

We are using a file array instead https://github.com/node-formidable/formidable/blob/master/package.json#L10
Result<EMAIL_ADDRESS>

Cool. I was looking at the 1.2.1 version which had few unnecessary files.


Exception: Layer lambda_1 does not support masking, but was passed an input_mask: Elemwise{neq,no_inplace}.0

today I am trying insurance_qa_eval.py, got exception below :+1:
File "C:\Users\Deep_QA_System\data\insurance_qa_eval.py", line 261, in
model.compile(optimizer=optimizer)
File "C:\Python35\lib\site-packages\keras\keras_models.py", line 111, in compile
qa_model = self.get_qa_model()
File "C:\Python35\lib\site-packages\keras\keras_models.py", line 96, in get_qa_model
self._models = self.build()
File "C:\Python35\lib\site-packages\keras\keras_models.py", line 247, in build
question_pool = merge([maxpool(question_f_rnn), maxpool(question_b_rnn)], mode='concat', concat_axis=-1)
File "C:\Python35\lib\site-packages\keras\engine\topology.py", line 485, in call
self.add_inbound_node(inbound_layers, node_indices, tensor_indices)
File "C:\Python35\lib\site-packages\keras\engine\topology.py", line 543, in add_inbound_node
Node.create_node(self, inbound_layers, node_indices, tensor_indices)
File "C:\Python35\lib\site-packages\keras\engine\topology.py", line 149, in create_node
output_masks = to_list(outbound_layer.compute_mask(input_tensors[0], input_masks[0]))
File "C:\Python35\lib\site-packages\keras\engine\topology.py", line 578, in compute_mask
'but was passed an input_mask: ' + str(input_mask))
Exception: Layer lambda_1 does not support masking, but was passed an input_mask: Elemwise{neq,no_inplace}.0
Using Python 3.5 Keras-1.0.6

This is addressed here

Thanks , it was solved.


feat: more SIP-40 errors

SUMMARY

Make more SQL Lab error message SIP-40 compliant.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Hi @betodealmeida this PR cause Sql Lab can not handle some error message correctly:

I have reverted this from airbnb's release branch, but you probably have to fix it in open source master branch.


Add logging to the plugin

As a user of the plugin, it would be useful to have logging functionality. This will make it easier to track what project are being injected, and which models are being referenced.

Coming back to this, I wonder if it would be difficult to tap into dbt-core event system. If not, we could probably use that for logging. The benefit is that we would also have access to structured logging, which is fantastic.


Does metrics-server require read-only port

Does metrics-server require the --kubelet-read-only-port=10255 to be set on Kubelets still? Or is it possible to connect with TLS directly to the API now, defining the certs and keys credentials?

You can connect using the secure port -- you just have to pass some options via the --source flag, the same way they're passed to Heapster
For example: https://github.com/openshift/origin-metrics/blob/c4142ae378b4b7c8ec82f4645fac93b8abf039f5/deployer/templates/heapster-standalone.yaml#L79


market participant market roles added

Description
market participant market roles added
References

#0000

Codecov Report

Merging #538 (1656386) into main (abf379f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #538   +/-   ##
=======================================
  Coverage   66.32%   66.32%
=======================================
  Files          11       11
  Lines         196      196
  Branches       19       19
=======================================
  Hits          130      130
  Misses         61       61
  Partials        5        5

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

question: Have you considered adding tests? The team was introduced to testing, so we can also start implementing tests as PRs.
You have a better idea of what is most important in this feature and what needs to be tested. One suggestion could be to add tests that renders the DhMarketParticipantActorMarketRolesComponent with some test input data and verifies that:

a list of options is rendered
a list of pre-selected options is rendered
clicking on a options triggers an output
... other tests that you think are important

If you need help, @frontend-specialisten and I are ready for sparring.


terraform cloudformation template timeouts should be tweaked to match the CF ones

aws_cloudformation_template resources have two timeout notions. The first one is the one for CloudFormation. It is defined as a variable in our module and defaults to 60':
https://github.com/enthought/terraform-modules/blob/master/aws_docker_cluster/main.tf#L67
The second one is the Terraform timeout which defaults to 30' but is not defined in our module. See https://www.terraform.io/docs/providers/aws/r/cloudformation_stack.html#timeouts
We should at least synchronize the two.

I don't think this is still in use now that we have deprecated the old EDS. @dbolack thoughts?

I don't think this is still in use now that we have deprecated the old EDS. @dbolack thoughts?


uerrno is not listed in table of contents

Combining exceptions and error codes makes sense since they are closely related. But from the point of view of discoverability (e.g. a user, familiar with Python but not Pybricks, sees import uerrno and wants to known what this is) it is not possible to find uerrno in the docs without resorting to the search function unless you already know that it contains error codes. And from the point of view of consistency, all other modules get their own page, so why not uerrno?

For discoverability, we could get it to show up in the table of contents by just changing the header line to ==== and change the title so it looks consistent:

Once we do that, I don't think a separate page would be worth it just for consistency. uerrrno is of little use without OSErrors, and it makes sense to keep examples about exceptions together so it's easier to see which one to use.

just changing the header line to ====

If I'm remembering right, this probably isn't the best solution. It seems like we have had subtle issues with styling, pdf generation, etc. in the past when files contain more than one top-level heading - the tooling doesn't seem to be designed to handle this case. (also the uerrno module would not be in alphabetical order, which looks a bit sloppy).

Fixed by commit referenced above.


doc: format references for easier integration into docs.carto.com

Pull Request Test Coverage Report for Build 643550738

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.255%

Totals

Change from base Build 643346978:
0.0%

Covered Lines:
583

Relevant Lines:
698

💛  - Coveralls


Remove Open Liberty community operator (duplicate)

Signed-off-by: leochr<EMAIL_ADDRESS>Certified Open Liberty Operator is available from https://access.redhat.com/containers/#/registry.connect.redhat.com/ibm/open-liberty-operator
Currently, there are 2 entries shown in OpenShift's embedded OperatorHub, one for community and one for certified. This could be confusing to the users. They should just use our certified operator. So our community operator can now be removed.

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

@kaczyns Could you please sign to approve this change as the original committer? Thank you.

Signed-off-by: Tim kaczynski<EMAIL_ADDRESS>


Handling uncertain matched data in special cases

Most of the getXXXX function contains (among others) these two input parameters:
•	inclUncertain
This is only relevant when a function is called with one or more filtering criterions – e.g. a list of species to be used to filter the set of animals to be returned.
If inclUncertain=TRUE, uncertain rows (i.e. rows where the species cannot be confidently identified) are included in the result set with the explanation included in column UNCERTAIN_MSG.
If an input set of e.g. animals are included in the function call, generated UNCERTAIN_MSG values are concatenated to eventual already existing UNCERTAIN_MSG values in the corresponding rows from the input data set.
If inclUncertain=FALSE, only rows which can be confidently matches to the input filtering criterions are included – and no column UNCERTAIN_MSG is added.
But in this case, I have realised, that I haven’t thought about the scenario where the input data set includes uncertain records – i.e. contains UNCERTAIN_MSG which may include some non-empty values. What is the correct way to handle these data:
1.	Include the uncertain rows from the input data in the filtering executed by the current function. And the set of these uncertain input rows which confidently matches the filter in the current function are included in the output set with their original UNCERTAIN_MSG kept
2.	Exclude the uncertain rows from the input data set before executing the filtering in the current function
3.	Do not execute the current function, and report an error telling that if input data contains uncertain data, the function must be executed with inclUncertain=TRUE.
•	noFilterReportUncertain
This is only relevant when a function is called without any filtering criterions – i.e. when the purpose is to add values for a given parameter/column – e.g. study start date or sex of animal.
If noFilterReportUncertain=TRUE, a column NOT_VALID_MSG is added to the output data set, and if the actual parameter/column value cannot confidently be identified, the reason is reported in NOT_VALID_MSG. And if the input data set (if such has been given in the function call) include a NOT_VALID_MSG, generated NOT_VALID_MSG values are concatenated to eventual already existing NOT_VALID_MSG values in the corresponding rows in the input data set.
If noFilterReportUncertain=FALSE, no reason is reported for rows where the actual parameter/column value cannot confidently be identified and no column NOT_VALID_MSG is added.
But again – equal to the case described for handling of uncertainties - I have realised, that I haven’t thought about the scenario where the input data set includes the NOT_VALID_MSG –what is the correct way to handle these data:
1.	Keep the NOT_VALID_MSG column with the existing values from the input dataset in the output data set
2.	Do not include the NOT_VALID_MSG column from the input dataset in the output data set
3.	Do not execute the current function, and report an error telling that if input data contains the NOT_VALID:MSG, the function must be executed with noFilterReportUncertain =TRUE
Also here, I’m in doubt of the right solution for this – so please let me here your opinion also for this.
A solution is needed for these two open questions....

Answer from Kevin:
My thought is that option 2 would be best in both cases, i.e. exclude the uncertain rows from the input data. I think that in practice, it would not be good to mix “certain” queries from some getXXXX functions with “uncertain” queries from other getXXXX functions, i.e. ideally inclUncertain and noFilterReportUncertain would be set to the same value for all getXXXX functions that are strung together for an analysis. Option 2 would practically ensure that this is the case as the user would need to set these parameters to TRUE in all getXXXX functions, otherwise the if any are set to FALSE, the output would be as if all were set to FALSE.
Answer from Bill:
I think option 1 would be the most complete solution; however, I can imagine this is more complicated to program and test.  I agree that this extra effort wouldn’t be necessary because a series of confident searches can be followed by a series of “uncertain” queries.  After reviewing the results, a new query can be constructed that includes the desired records from the uncertain results in a new “confident-only” query.
I’m worried that option 2 could lead programmers to wonder why their uncertain results vanished.  If we added a new function to strip uncertain results, we could effectively give programmers option 2 but without the mysterious disappearance of results.

It has been decided to go for option 1 to ensure no data are excluded unexpected.
All the get..... functions must be updated to handled this behaviour correctly.


Provide top level methods to set custom http handlers

Overview
This is the first of two PRs needed to bring first class support for providing custom http headers and parameters to search, routing, and tile requests. This work adds MapzenSearch#setHttpHandler(MapzenSearchHttpHandler ), MapzenRouter#setHttpHandler(MapzenRouterHttpHandler ), and MapzenMap#setHttpHandler(MapzenMapHttpHandler ) methods.
Proposed Changes

Adds top level APIs to set custom http parameters and headers
Adds relevant test coverage
Adds SDK LogLevel enum for mapping to internal implementation log level (future PR will provide ability to set log level on search and map handlers as well https://github.com/mapzen/android/issues/445)
Updates MapzenRouterHttpHandler to allow setting base url and log level

A follow up PR will provide support for pulling the API key from MapzenManager automatically (https://github.com/mapzen/android/issues/444)
Closes #443

I'm going to merge this so I can start on https://github.com/mapzen/android/issues/444. I'll address any issues in the PR for that (related) work.


Skip empty pages when not restoring

This PR causes pages that only contain fill to be skipped if not restoring unwritten data. Additionally it fixes two off-by-one errors that were causing restoring unwritten data to panic.
On my targets this means instead of programming 16kB of flash every write, it typically only needs to program 1kB, which is a big time saver.

I've modified the tests to pass the new argument to build_sectors_and_pages, but because the old saved values were wrong (due to the page_index off by one error) the tests still fail. Should I regenerate the snapshots somehow?

I've updated to fix the snaps of the broken tests and add a new test for when skipping empty pages.

LGTM, thanks for this fix!


Disable distributed lock and recreation on Check Enforcer

This PR disables use of the distributed lock for Check Enforcer (it is possible that in a future PR I'll be able to rip it out completely. I also disabled the recreation logic since that could cause problems.

/check-enforcer-dev reset

/check-enforcer-dev reset

/check-enforcer reset


Renaming jsx to js

Enhancement

Rename all jsx files into js

Reason to enhance/problem with existing solution

It's really bugging me that we use jsx. This is the remnant of the past when we wanted to differentiate between a jsx and js file. Given that this boilerplate is a react app, I don't see value in naming it jsx now.
Keep kode klean.

eslint-plugin-react recommends jsx file extension though...
Link

I think I side with @ZeroCho, if a file contains jsx inside it then I think there is some benefit in the file keeping that extension, being explicit about things helps understanding. I don't think there is any real benefit to streamlining the file extensions.

Agreed, .jsx is a very good visual queue for differentiating between components and other script assets inside the same directory (especially at quick glance in a tree-view). Solid attempt to save a few K tho! ; )

Hahaha alright peeps. I've tried to save us from those few keystrokes.
One last attempt: when we are moving towards the component shuffle (I.e. we
have an index file that exposes the components within the folder), just
hurts my soul when I see jsx and js.
Also we can disable that warning for eslint plugin react.
But this is purely a matter of preference - there are pros and cons either
way. Happy to keep as is. 😉
On Thu, 1 Sep 2016 04:39 John Rodler<EMAIL_ADDRESS>wrote:

Agreed, .jsx is a very good visual queue for differentiating between
components and other script assets inside the same directory (especially at
quick glance in a tree-view). Solid attempt to save a few K tho! ; )
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/reactGo/reactGo/issues/478#issuecomment-243803090,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADnMbbtQylqsmUoxnao48sOQssTox2bRks5qlZ6bgaJpZM4JwTf8
.


swiss: report performance counters in benchmarks

This adds a dependency on github.com/aclements/go-perfevent

This change is

Do you know differently?

Unfortunately, that's generally true. Hardware performance counters are quite difficult to virtualize safely. I believe AWS does support hardware PMUs on some instance types, but I haven't tried it: https://www.intel.com/content/www/us/en/developer/articles/technical/intel-vtune-amplifier-functionality-on-aws-instances.html

Thanks for the contribution.


Allow filtering/custom handling of with_locals values

Including locals in the stacktrace for errors can be very useful, but we've found that we'd like some more control of those values.
Example:
Calling repr on a django queryset will evaluate the query if it's not cached, which might both slow the error reporting down and even affect the database performance (if it's a costly query).
It could also be used to control which locals to include, in case we'd like to scrub some out.
The data scrubbing could be done in before_send I guess, but all values would have been evaluated already so it would not help us with expensive repr calls. And it would require us to dive into the nested(?) stacktrace data. How about having some option, similar to before_send or before_breadcrumb but for before_locals that could receive the locals and should returned some new dict as the locals?
Or is there any ideas on other way's to prevent lazy queryset evaluation in sentry, other than disabling all locals with with_locals=False?

I agree that something needs to be done here. My preferred solution would be to delay the call to repr() such that before_send still sees the raw local. It can then filter it out or use an alternative repr.

On reading the OP again, I don't understand the argument that this would affect the DB performance. Why do you have the queryset around if evaluating would hit the DB too hard?

In our case, it was a queryset of a moderately large table and some select_related (causing joins) and a sort_by on a non-indexed column. It was executed without filters as it was in a local variable in the stack of an error handled by sentry-sdk. Because it was sorted by the unindexed column, the db still had to read the full table and sort it.
The same thing would of course happen if we executed that queryset, but the application code would not evaluate the queryset as it was. It would use that queryset and apply some .filter(...)-calls which would reduce the number of items to be sorted to a manageable state.
I'm not sure if that should be considered bad practice, but I think it's fairly common in the django ecosystem to construct querysets in multiple steps, and not considering the safety in executing the queryset as it is at every stage but just rather when it's used by the application code.
More generally, I can think of these risks in calling repr on all querysets in the stack trace's locals:

querysets that have an ordering, if not on an indexed column (as above)
the number of queries (even if each is quite quick):
it's possible the stack contains a bunch of querysets (multiple frames, multiple locals), I don't think that 10-20 queryset's would be uncommon for a django app's stack trace(?)
the repr call on each object in the queryset could perform queries, if it uses any related object from it's __repr__ method (though that would surely be bad practice). But then we could get 21 queries just form a single repr on a queryset.
Lock contention. The sentry handler could be called within a transaction, where locks are held or where the query has to wait for other locks. That could result in significant delays for the query itself or for other queries, or cause deadlocks.
Querysets with select_for_update, which would lock the selected item's.

I'm not sure how often people would use select_for_update without applying the valid filter's at the same time, but I don't think that I would raise my eyebrows for code such as (written to create or update a user in an atomic manner):
obj, created = User.objects.select_for_update().update_or_create(
    id=42,
    defaults={'first_name': 'Bob'},
)

But if an error is raised within that call, such as in a signal or in the save method, the frame for update_or_create will contain the local self which is an unevaluated queryset that if repred will lock 21 users for the duration of the transaction.

Or consider
qs1 = User.objects.filter(id__in=request.session['friends']).order_by('last_post')
qs2 = User.objects.order_by('last_post').filter(id__in=request.session['friends'])

I would consider them functionally equivalent, but if the second would raise an exception in the filter call (the session not having the data, or it being the wrong type for the filtering etc) it would have a local (self in the filter frame) that is the full queryset with a sort, which could be very expensive.
Upon thinking about it, I find it quite scary to call repr on any django queryset in sentry.
For reference, I found this ticket interesting (about django's querysets calling the db on repr): https://code.djangoproject.com/ticket/20393

What solution would you have in mind, @untitaker? Delaying the repr-call until after the before_send and make make it possible to filter them out? My initial idea of before_locals? Some modification to the django integration to stop calling repr on querysets?

I think this is very related to https://github.com/getsentry/sentry-python/pull/229 and I have the feeling that there exists a solution that satisfies both. I am no longer sure what I want to have implemented.

Oh heh, I didn't even look for an open bug. :)

Reading up, I'm a bit horrified that repr would ever cause a query to happen -- I realise it's beyond your control, and the Sentry API should work despite it, but ugh (my expectation would be that it summarised data it had available at the time but didn't pull in any extra data except possibly by recursive repr calls).
My suspicion is that this would be better served by creating a type adapter layer which understood how to encode these values rather than overriding the encoder itself (else you're forced to duplicate much of the encoder's behaviour). It's an approach used in some JSON encoding modules and psycopg2, I think.
If you're having problems in the field, you might consider monkey-patching __repr__ on the ResultSet object to do something less awful until you can find a better fix.

Thinking harder, I could replace the CapturePicker with a CaptureGenerator which could have a (recursively called) to_json_obj() which @alvinlindstam could override. My OneTimeCapturePicker would simply override get_locals() (or something) to return None mostly. It probably results in a positive refactoring of that code, too. It's a bit strange to have a persistent object for generating captures (it must be thread-safe, for instance), but perhaps I could pass a class with a static traceback field.

And looking closer at @alvinlindstam's suggestion (presumably replacing locals with raw_locals in the event dictionary until after before_send) I think that'd work for both of us, too, though it'd still have to do work enumerating the locals of the full stack even if it didn't format them. I seem to recall when I did the profiling of our death loop almost all of the cost was in stringification, so I suspect that's relatively cheap.

This is completed in #247. You will be able to filter out local vars by type and value. Right now it's not possible to filter by key.
Please don't use this for PII stripping! If this seems like an attractive hook for stripping PII we'd love to know how we can improve before_send.

That's seems awesome, haven't gotten to look into the solution in detail or test it yet but it seems that it will do what it says :)


Session Permissions

I am not reporting this as a bug, I was messing with apache configurations & disabled suphp which created a session with the apache user information, after re-enabling suphp which switched to my userid I've got these errors from session files driver.
This one is normal:
Severity: Warning
Message: fopen(/var/lib/php5/ci_session1df5c5147c908bc476d886e8cb106942ac5022a4): failed to open stream: Permission denied
Filename: drivers/Session_files_driver.php
Line Number: 162

but these, should be handled differently as on line 162 we are returning boolean, but it's never checked afterwards, which causes the following errors to appear:
Severity: Warning
Message: rewind() expects parameter 1 to be resource, boolean given
Filename: drivers/Session_files_driver.php
Line Number: 188

Severity: Warning
Message: fread() expects parameter 1 to be resource, boolean given
Filename: drivers/Session_files_driver.php
Line Number: 194

This requires some checking so only the relevant warning appear (which is the permission denied one).

If you're not reporting this as a bug ... what is it? What are you suggesting?

I am expecting 1 warning only from this, which is the permission denied; it shouldn't try to re-wind a file it cannot access nor fread it.
A boolean is returned, and it's being used as a resource.

I got that from the initial description, but it doesn't answer my question ...

Nevermind my previous comments ... it looks like a bug to me and you said you're not reporting it as such, so I wanted to know what are you reporting it as, but that's a moot point.
I'm more interested in how you managed to trigger these warnings. read() shouldn't be called more than once unless you've executed session_reset() and so you shouldn't be getting the one on line 188 ...

I am not calling anything manually, I'm just autoloading the library, maybe when you're trying to read session data it calls read again ignoring the fact that it doesn't have permission in which case the _file_handle is already set to FALSE which results in having the other 2 errors.
The session file was already created using different uid/gid & had data when I switched back to suphp to have it use my uid/gid.

Well, that doesn't sound logical (there's no reason for repeated read() calls other than session_reset()), but I'll have to do some low-level testing either way ...

That should do it ... Although, another PHP bug is actually the cause for read() even being executed.
PHP 7 finally fixes it: https://wiki.php.net/rfc/session.user.return-value
I'll work on that later.


Do you have support centos6 version of frida - go version

I currently use the frida - go [frida - core - the latest version of the devkit - 16 compiled can support the use of, on the part of centos7 on centos6 compared with the old system cannot be used

Hi, what is the error there exactly


Default Node Version

By default mup installs node version 0.10.36 however meteor requires 0.10.40 to function resulting in failed deployments.

You should be able to set "nodeVersion": "0.10.40" in your mup.json file.


AWS::Serverless::SimpleTable not Created in DynamoDB Local

Based on the spaces vs. tabs example https://aws.amazon.com/blogs/aws/new-aws-sam-local-beta-build-and-test-serverless-applications-locally/
It appears the SAM local YAML configuration with AWS::Serverless::SimpleTable should automatically create the table in DynamoDB Local, which in my case it is not.  The voting lambda works as intended if I manually create the table with AWS CLI or the Dynamo Shell.
Should this create our table?
The specific output with error stack returned is:
2017/08/31 16:35:47 Invoking lambda.lambda_handler (python3.6)
START RequestId: 7477bb46-6a7f-42bb-89bd-8819de055637 Version: $LATEST
dynamodb.Table(name='spaces-tabs-votes')
An error occurred (ResourceNotFoundException) when calling the UpdateItem operation: Cannot do operations on a non-existent table: ResourceNotFoundException
Traceback (most recent call last):
  File "/var/task/lambda.py", line 29, in lambda_handler
    ReturnValues='ALL_NEW'
  File "/var/runtime/boto3/resources/factory.py", line 520, in do_action
    response = action(self, *args, **kwargs)
  File "/var/runtime/boto3/resources/action.py", line 83, in __call__
    response = getattr(parent.meta.client, operation_name)(**params)
  File "/var/runtime/botocore/client.py", line 310, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/var/runtime/botocore/client.py", line 599, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.errorfactory.ResourceNotFoundException: An error occurred (ResourceNotFoundException) when calling the UpdateItem operation: Cannot do operations on a non-existent table

END RequestId: 7477bb46-6a7f-42bb-89bd-8819de055637
REPORT RequestId: 7477bb46-6a7f-42bb-89bd-8819de055637

Note: the table name is printed out for verification of correct Environment Variable usage

Here's my configurations:
template.yaml
AWSTemplateFormatVersion: '2010-09-09'
Transform: AWS::Serverless-2016-10-31
Resources:
  VotesTable:
    Type: "AWS::Serverless::SimpleTable"
  VoteSpacesTabs:
    Type: "AWS::Serverless::Function"
    Properties:
      Runtime: python3.6
      Handler: lambda.lambda_handler
      Policies: AmazonDynamoDBFullAccess
      Environment:
        Variables:
          TABLE_NAME: !Ref VotesTable
      Events:
        Vote:
          Type: Api
          Properties:
            Path: /
            Method: post
        Query:
          Type: Api
          Properties:
            Path: /
            Method: get

I tried running DynamoDB local both as:
docker run -p 8000:8000 dwmkerr/dynamb  -sharedDb

and using
java -Djava.library.path=./DynamoDBLocal_lib/ -jar DynamoDBLocal.jar -sharedDb

Same result for both.
Initializing DynamoDB Local with the following configuration:
Port:	8000
InMemory:	false
DbPath:	null
SharedDb:	true
shouldDelayTransientStatuses:	false
CorsParams:	*

I am connecting to dynamo okay though, as seen by:
$ aws dynamodb list-tables --endpoint-url http://<IP_ADDRESS>:8000
{
    "TableNames": []
}

The votes_table assignment appears:
#lambda.py

import os
import json
import boto3

if os.getenv('AWS_SAM_LOCAL'):
  votes_table = boto3.resource('dynamodb', endpoint_url='http://docker.for.mac.localhost:8000/').Table(os.getenv('TABLE_NAME'))
else:
  votes_table = boto3.resource('dynamodb').Table(os.getenv('TABLE_NAME'))

def lambda_handler(event, context):
    print(votes_table)
.
.
.

And this is invoked by
TABLE_NAME=spaces-tabs-votes sam local start-api

then
curl -d '{"vote": "spaces"}' http://<IP_ADDRESS>:3000/

on
macOS Sierra 10.12.6
aws-cli/1.11.142 Python/3.6.2 Darwin/16.7.0 botocore/1.7.0
sam version 0.2.0
Docker version 17.06.1-ce, build 874a737

Thank you!

Sorry for the confusion. SAM Local currently only does anything with AWS::Serverless::Function resources, other resources are ignored. You will need to create the table.

Sounds good. I'll make a post to see if he can update the tutorial to alleviate the confusion.  Thanks for the quick reply!

In the mean time, you can use this CLI command to create the local Table:
aws dynamodb create-table --endpoint-url http://localhost:8000 --table-name spaces-tabs-votes --attribute-definitions AttributeName=id,AttributeType=S --key-schema AttributeName=id,KeyType=HASH --provisioned-throughput ReadCapacityUnits=1,WriteCapacityUnits=1
You can also use this same command to create the table in DynamoDB service.
Regards

@mrrobby if that helps, I simply user DynamoDB Local in a Docker Container and use both SAM Local and DynamoDB Local in the same Docker Network.
I also use a Bootstrap script to create my table with same basic data.
DynamoDB Local in a docker container
docker run -d -v "$PWD":/dynamodb_local_db -p 8000:8000 --name dynamodb cnadiminti/dynamodb-local

Inside my code I have a simple check for SAM_LOCAL env variable and initialize my DynamoDB differently:
# Quick sanity checks and predefined local dev
if os.getenv("AWS_SAM_LOCAL", ""):
    ddb = boto3.resource('dynamodb',
                         endpoint_url="http://dynamodb:8000")
    ddb_table = "users"
    # ret = requests.get("https://google.com")
    # print("Status --> ", ret.text)
else:
    ddb = boto3.resource('dynamodb')
    ddb_table = os.getenv("TABLE_NAME", None)

Source code: https://github.com/heitorlessa/sam-local-python-hot-reloading

@PaulMaddox wrote:
Sorry for the confusion. SAM Local currently only does anything with AWS::Serverless::Functionresources, other resources are ignored. You will need to create the table.

Seems to be an important limitation that should be noted in the docs.

Thanks guys.  I like @heitorlessa's approach.  Good call.  That actually seems like a worthwhile future implementation for SAM Local.

There are big issues with the tutorial. Very frustrating for me, and potentially other people new to the tech.
Actually getting this to work requires

getting dynamodb-local to work with sam, using a solution like that suggested by @heitorlessa
manual creation of the dynamodb table

Figuring out those steps helped me learn, but the tutorial does not even hint that they will be necessary. If you just follow the tutorial, it won't work, and that makes it a bad tutorial.

@revmischa Looks like the feature to be able to have a custom name on the SimpleTable is in progress. If we upvote this issue, we might see a resolution sooner: https://github.com/awslabs/serverless-application-model/issues/252
I don't know of any way to reference the SimpleTable's generated table name. This was a big reason I didn't adopt SAM immediately after it was announced last year. This is my #1 feature I'd love to see.
If we can set a static name on the table, then you can create a local table with the same name going through the suggestions of using dynamodb-local, as stated above.

I second that. My team is getting into sam and we love the local feature. If SAM prioritizes this feature I will also be quite happy. This is my #1 feature i'd love to see.

I just read Tabs or Spaces tutorial and I was wondering if the table should be created or not. And YES! That's kind of confusing. I had to google a lot to figure out that that's not currently supported.
As @phstc pointed The more SAM local can provision locally, the less we need to configure, and the better.
Maybe an integration with LocalStack to provision all services we require would be great.

@rtalexk Yea same happened to me. Please if there is still no solution then at least rework the tutorial.


Confusion about mesos role and default accepted roles

I'm noticing an issue with my running installation of Marathon 0.13.0.
I have started up marathon with the following flags --mesos_role other --default_accepted_resource_roles *.
I created an app, with the 'acceptedResourceRoles' value set to *, but when it starts it appears to get a port resource assignment in the 'other' role (verified by looking at /master/roles.json on the mesos master  -- mesos v 0.22.2).
First. Am I seeing an issue here, or are things actually working as expected, and its my model of how things should be that is wrong?
And if it is an error, is it one of configuration or is this a known issue -- I didn't see an existing issue, but perhaps its not an obvious problem I'm encountering.
In general I'd like to ask for some clarity on the idea of --mesos-role and --default_accepted_resource_roles. If I understand correctly, without --mesos-role set the framework and all tasks will only accept offers of role *, with it set you gain the ability to also start tasks in the role passed as the argument to --mesos-role, but that is the limit currently -- up to two possible roles to accept offers from, right?

Hey @hellertime can you please post your AppDefinition?

I'll produce a pared down version, sans env vars and the like:
{
                    "instances": 1,
                    "container": {
                        "docker": {
                            "network": "HOST",
                            "image": "my_app:1.0"
                        },
                        "type": "DOCKER"
                    },
                    "id": "my_app",
                    "cmd": "/run.sh",
                    "contraints": [
                        [
                            "hostname",
                            "UNIQUE"
                        ]
                    ],
                    "cpus": 2,
                    "mem": 1024
                }

Yeah that's fine, but to make sure we can reproduce this you should at least add the ports-section.
To answer your questions in between:

If you set --mesos_role other, Marathon will register with Mesos for this role – it will receive offers for resources that are reserved for this role, in addition to unreserved resources.
If you set default_accepted_resource_roles *, Marathon will apply this default to all AppDefinitions that do not explicitly define acceptedResourceRoles. Since your AppDefinition defines that option, the default will not be applied (both are equal anyways).
If you set "acceptedResourceRoles": ["*"] in an AppDefinition (or the AppDefinition inherits a default of "*"), Marathon will only consider unreserved resources for launching of this app.
In fact, the current limit is one role – a Mesos Framework can only register for one role, and will always receive offers for unreserved resources (I figure it feels like two roles, but unreserved resources are actually not reserved, so not associated with a role).

As far as I can tell, Marathon should not launch your app on a "other" resource – and the code of 0.13 looks correct to me at a first glance. @gkleiman pointed out that a Mesos agent does not complain if you declare ports bot both * and other. Can you look for line like
slave.cpp:463] Slave resources: ports(*):[500-505]; ports(foo):[500-505]; cpus(*):8; mem(*):15360; disk(*):470816

So there our agent will offer ports [500-505] both as unreserved as well as statically reserved for foo. Haven't tested how that turns out in practice, but please provide your Mesos master and agent configuration as well.

I'm not sure what you mean to "add the ports-section". I'm not actually asking for ports with this app config, marathon is just grabbing a port anyway. The more interesting issue isn't that the port gets associated with the 'other' role, but that the cpu get allocated from there. Thats more problematic.
Here is the master config for roles:
export MESOS_ROLES="*,other"
Here is the slave config:
export MESOS_RESOURCES="ports(*):[10000-20000,31000-32000];cpus(*):2;mem(*):3072;cpus(rum-collector):4;mem(other):1024;ports(other):[25000-26000]"

I just discovered that, at least in mesos 0.22.2, if a framework registers with mesos with a specific role, and it accepts offers from the * role those resources get reported under the role which the framework registered, not under *. Which is very likely what I'm seeing here.

@hellertime I wasn't aware that your CPU gets allocated from the other share, you didn't say so in your initial issue description and was assuming that your AppDefinition actually requests a port (you can Marathon prevent from doing that by defining "ports": [] btw ...)
Now I realized that you rely on information as queried via /master/roles.json. I've checked back with the Mesos team re: this. This endpoint only serves information from a roles -> framework perspective. That means, what you see there is a listing of known roles, the frameworks registered with these roles, and the total allocated resources for each framework disregarding the role. The docs on this endpoint are a little unclear.
So, yes, you understood the matter correctly, but you cannot read the actual resource allocation from the roles endpoint. Does that cover all your questions?

Oh I just saw your message from Saturday – exactly, this is still the case. Feel free to open a docs issue in Mesos so they may document this better …


chore: online-store to 0.0.9

chore: Promote online-store to version 0.0.9

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


chore(main): release 0.16.0

:robot: I have created a release beep boop
0.16.0 (2023-03-07)
Features

add restart action (1b94e8d)
add ume plugins (eb3efaf)
me: add build type to about (4d4b127)
settings: add desc for devTools (eede45b)
settings: enable ume iff show dev tools (e2f36a5)
ume: log to console (4870b7a)

Bug Fixes

ume: disable some plugins in release mode (9058450)
universal_io (0562e4c)

Reverts

Revert "build: flutter pub remove flutter_launcher_icons" (427118e)
Revert "build: override dependency" (f9bd357)
Revert "docs: add comment for flutter_launcher_icons" (688270a)

Documentation

add comment for flutter_launcher_icons (b03f64d)

Code Refactoring

dart fix (5e1e0c9)
logger: update home logger name (31de3a2)
main: extract AppCore (2fdf551)
simplify imports (9f8e735)

Miscellaneous Chores

save idea config (2c5263d)

Build System

add ume packages (a050dec)
flutter pub add restart_app (c2dba73)
flutter pub add universal_io (21cecfb)
flutter pub get (cbb6f35)
flutter pub remove flutter_launcher_icons (b2a3e6f)
flutter pub remove flutter_ume_kit_dio (9b5ef2c)
flutter pub upgrade (f324aac)
flutter pub upgrade (1feb8ac)
override dependency (0cf896a)
override ume dependencies (aace266)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/CCXXXI/ecg_monitor/releases/tag/v0.16.0 :sunflower:


Add folder-based approach

I would like to add the possibility to get rit of the metadata keeping in the list.json. I would like to suggest to just order the slides by alphabet.
I usually order my slides like this:
/1-chapter1/0-chapter1-introduction.md
/1-chapter1/1-slide1.md
/1-chapter1/2-slide2.html
/2-chapter2/0-chapter2-introduction.md
/2-chapter2/1-chapter2-slide1.md
/3-chapter3-one-slide-only.md

Maintaining my list.json file becomes tedious to say the least.
I'm a big fan of the generator-reveal, just this one thing is bothering me. If you agree, i can do a PR. How would you suggest it would work? Just use the list.json if its there, otherwise do the folder ordering mechanism?

Hi @nicojs, thank you for the suggestion.
Here is my take on it:
Essentially you are taking the metadata from list.json and putting it into the filename (and the file in case you need to specify attributes like style and data). I suppose this is a matter of taste, but I think the nice part about list.json is that the *.md files used in the presentation can be totally clean with respect to the presentation logic of the reveal framework. They can be simple markdown files with filenames that respresent their content and not their position in the presentation.
Of course we could always add options, but looking at https://github.com/slara/generator-reveal/blob/master/app/index.coffee we already have 7 options and I would rather have less options than more. So I would rather then switch completely to another approach instead of adding yet another configuration variable; but for my taste (as I outlined above) the list.json version is a nicer fit to separate mere content from presentation logic.
What do you think @slara?

@janraasch  Good point about the specifying the attributes like style and data. I would also opt for not using the content of a file for the presentation logic. But i don't see the 7 options that you are talking about.
My filenames also represent their content, but i number them so i can easily see the order of my slides in my file explorer.

The prompts array has a length of 7, see https://github.com/slara/generator-reveal/blob/master/app/index.coffee#L32.

Ah ok, i thought you meant that there were already 7 ways of configuring the slides order. The way i see it, there will not be a new option: if the lists.json file is there, it will be used, if its not there it won't be used.

Hi @nicojs and @janraasch,
thanks @nicojs for your suggestion.
As @janraasch said, I think we could have a problem with slide attributes configuration. I can't see how we could set this attributes without altering the markdown files.
Having folder-based slide sorting and a list.json file with the configuration at the same time could create a lot of confusion.
Another problem that I see is that if you need to add one slide in the middle of your presentation, you will need to change every filename after that slide.

Very good points, @slara.
@nicojs:

The way i see it, there will not be a new option: if the lists.json file is there, it will be used

The problem is that all our yo reveal:slide "Slide Title" commands also rely on the list.json file, so the user has to tell our generater whether to scaffold it out our not. Thus we would need to prompt the user when first running yo reveal "My Presentation".
I figure, you can easily adjust the code in the generated Gruntfile.coffee of your presentation (see https://github.com/slara/generator-reveal/blob/master/app/templates/_Gruntfile.coffee#L118) to create the slides Array in a way that fits your needs, @nicojs.
So we will not pull this into the generator itself as we try to cover the most common use case; and then the great thing about generators after all is that it gives you a quick start, but you can adjust everything to your own individual needs after that.

@slara

So we will not pull this into the generator itself as we try to cover the most common use case; and then the great thing about generators after all is that it gives you a quick start, but you can adjust everything to your own individual needs after that.

Fair enough.


OAuth2AccessToken Class Serialize And Deserialize Problem

When my project is using FastJson as a serialization tool, other projects using JaskJson will not get the AccessToken correctly through ClientCredentials.

@wangzhangmao thanks for reaching out. Would you please log this issue to the Spring Security OAuth project since that is where that code is maintained?
Please link that ticket here so that folks in the future can follow the conversation. Also, when you are reporting there, you will likely reach a resolution faster if you describe there exactly what problem you are seeing and a reproducer that demonstrates the flaw.


no_traffic_edge_interval

Feature request for no_traffic_edge_interval
Description:
We have a setup where we have two envoys pointing to the same cluster. At the moment we have traffic routing to only one of the envoy instances. What is problematic is that we have no_traffic_interval set to 100ms. Which is great when we only have one envoy instance, since when a cluster is first up, we want to check to ensure it is healthy before any requests goes upstream. But when we only have traffic going to one envoy instance, the other envoy will be spamming the cluster every 100ms thinking that there has been no traffic.
We could increase the no_traffic_interval to something reasonable like 1 second to reduce the spam, however if once there is traffic coming over, from what I understand, envoy will hold onto the request before letting it go upstream which leads to slower latency?
Proposed solution
Add a no_traffic_edge_interval that specifies the interval to run the health check after a cluster is marked healthy during the no_traffic_interval stage

I'm unsure why you think that longer no_traffic_interval would cause initial requests to be delayed. The first host check is sent immediately when a cluster is loaded. Yes, the requests may be queued until health check response comes back and cluster fully warms up, but this time is not affected by the no_traffic_interval. In fact the no_traffic_interval is used specifically to reduce the spam from Envoy's that have not yet seen any traffic, so making it shorter than the interval is not using it right.
@snowp in case I'm not right on some points.

So my thinking is this.

Envoy starts Up
Envoy sends HC to Cluster
HC fails since the cluster is not up yet
Envoy will wait no_traffic_interval to HC
Cluster starts up
Request comes into Envoy but since the last HC has failed, we don't send the request and will have to wait for the no_traffic_interval to complete before running the next HC

Let me see if I can repro to make sure my understanding is correct.

I'm unsure why you think that longer no_traffic_interval would cause initial requests to be delayed.
Actually sorry that is an implementation filter on our end.

However I expected that without our filter, Envoy would either fail the request immediately or send a HC before sending off the first request if the cluster is marked unhealthy.
So perhaps i am misunderstanding the purpose of health checks.
Here is what happens.

Envoy Starts up
Envoy sends HC to cluster and fails

{"health_checker_type":"TCP","host":{"socket_address":{"protocol":"TCP","address":"<IP_ADDRESS>","resolver_name":"","ipv4_compat":false,"port_value":8081}},"cluster_name":"worker_endpoint","health_check_failure_event":{"failure_type":"NETWORK","first_check":true},"timestamp":"2020-09-24T17:36:26.896Z"}

Envoy will wait no_traffic_interval to do the next HC
The cluster starts up
I curl envoy and receive a 200

I expect in step #5 that we fail the request.
Current config that I am using
static_resources:
  listeners:
  - name: listener_0
    address:
      socket_address: {
        address: <IP_ADDRESS>,
        port_value: 8080
      }
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        typed_config:
          "@type": envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
          stat_prefix: ingress_http
          codec_type: AUTO
          stream_idle_timeout: 3600s
          http_protocol_options:
            enable_trailers: true
          route_config:
            name: local_route
            virtual_hosts:
            - name: local_service
              domains:
                - "*"
              routes:
              - match:
                  prefix: "/"
                route:
                  cluster: worker_endpoint
                  timeout: 300s
          http_filters:
          - name: envoy.filters.http.router

  clusters:
  - name: worker_endpoint
    connect_timeout: 5s
    type: STRICT_DNS
    lb_policy: ROUND_ROBIN
    load_assignment:
      cluster_name: worker_endpoint
      endpoints:
      - lb_endpoints:
        - endpoint:
            address:
              socket_address:
                address: <IP_ADDRESS>
                port_value: 8081
    health_checks:
      - no_traffic_interval: 100s
        timeout: 60s
        healthy_threshold: 1
        tcp_health_check: {}  # empty payload indicates envoy will perform "connect only" TCP health checking.
        interval: 86400s
        unhealthy_interval: 86400s
        unhealthy_threshold: 1
        always_log_health_check_failures: true
        event_log_path: "/tmp/envoy_hc.txt"

Maybe I'm missing something but what is the purpose of health checking if you're just doing TCP health checks to one instance? Envoy will never delay a request based on upstream health (besides during retries, but that's a bit different), so checking to see if its accepting connections before trying to open a connection isn't really buying you anything

Maybe I'm missing something but what is the purpose of health checking if you're just doing TCP health checks to one instance? Envoy will never delay a request based on upstream health (besides during retries, but that's a bit different), so checking to see if its accepting connections before trying to open a connection isn't really buying you anything

Sorry I should have mentioned that we have a custom health check filter in our filter chain which is not illustrated in my previous post. It basically delays the filter until the cluster is healthy. Otherwise without the at filter, if there is no healthy host available, envoy will fail the request with 503 Service Unavailable.
So back to my original request, we want the tcp health check, however if we have two Envoy instances set up, one of them may see no traffic for quite some time and will bombard the upstream with tcp health checks. Which is why I think a no_traffic_edge_interval would be useful here.

Have you tried setting reuse_connection to true? That way instead of continuously reconnecting, it will open one connection and treat it as healthy while that connection remains open.
I'm not necessarily against adding more configuration options here, just want to make sure we've explored the options before adding more options to the API

Have you tried setting reuse_connection to true? That way instead of continuously reconnecting, it will open one connection and treat it as healthy while that connection remains open.

Oh I did not know we had that. Looking at the docs, this is enabled by default.
I tried enabling both true and false for that config and running my upstream cluster as the following
nc -lkv  8081

Which is netcat listening on port 8081 with verbose logging
When starting up envoy, I see this every no_traffic_interval
nc -lkv  8081
Listening on <IP_ADDRESS> 8081
Connection received on localhost 51342
Connection received on localhost 51344
Connection received on localhost 51346
Connection received on localhost 51348
Connection received on localhost 51350

Envoy debug logs shows this
[2020-09-25 11:34:03.657][977893][debug][connection] [third_party/envoy/src/source/common/network/connection_impl.cc:201] [C4] closing socket: 1
[2020-09-25 11:34:03.657][977893][debug][connection] [third_party/envoy/src/source/common/network/connection_impl.cc:614] [C4] close during connected callback
[2020-09-25 11:34:05.605][977893][debug][upstream] [third_party/envoy/src/source/common/upstream/upstream_impl.cc:286] transport socket match, socket default selected for host with address <IP_ADDRESS>:8081

And it looks like it should be reusing the connection here
https://github.com/envoyproxy/envoy/blob/b0d0bb87f71d46831d7214d5c4bab6feb545eece/source/common/upstream/health_checker_impl.cc#L471-L473

Are those logs with it enabled or not? I can imagine the upstream might be closing the connection due to idle timeouts, so that might be what's triggering the reconnects.
Seems like ideally we'll get persistent connections working, but if not then I think I would be more in favor of a "unhealthy interval" rather than trying to add variations to the no traffic one. I think that might be more useful to other people that don't have your delay filter :)

Yea those logs happen regardless if we reuse connections or not.

Seems like ideally we'll get persistent connections working

Yea I think with the persistent connection, that will be more ideal.

but if not then I think I would be more in favor of a "unhealthy interval" rather than trying to add variations to the no traffic one. I think that might be more useful to other people that don't have your delay filter :)

Yea for our use case, this would not work since we are using the higher frequency check to make sure our filter unblocks the request as soon as possible. And for our use case, we can't use the http health check.
So I dug around some more and I think this is intended behavior as documented here. And my logging confirms that we are terminating the tcp connection in this block of code despite having reuse_connection on.
https://github.com/envoyproxy/envoy/blob/b0d0bb87f71d46831d7214d5c4bab6feb545eece/source/common/upstream/health_checker_impl.cc#L489-L506


OpenAPI doc is deprecated

At the time of bug bash early Dec 2021:
https://github.com/microsoft/cadl/blob/main/docs/cadl-for-openapi-dev.md#path-item-object
@resource("/pets")
namespace Pets {
  op @get list(): Pet[];                  // get on path "/pets"
  op @get read(@path petId: int32): Pet;  // get on path "/pets/{petId}"
  @post("{petId}:walk")
  op walk(... PetId): {};                 // post on path "/pets/{petId}:walk"
}

is incorrect

@lmazuel Fixed by this PR: #102 Please verify and close.

I think there is still a need to reverse the order of op and @get ? I start to forget my bush bash CADL day now :p


Update 'Note' Feature : Update Note Content UI

Codecov Report

Merging #104 (d05980a) into master (262ee48) will decrease coverage by 0.91%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262ee48...d05980a. Read the comment docs.


Download button

Codecov Report

Merging #10 (2183f6b) into dev (9e4494e) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev     #10   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files          1       1
  Lines          1       1
=====================================
  Misses         1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4494e...2183f6b. Read the comment docs.


Fix colored text and MessageComponent not being found

Fixes #567 / #570 and BDV2.MessageComponent being undefined because of some internal changes on discord.
Thanks @Strencher for providing the fix for the MessageComponent.

@jaimeadf wait do u know a way how to fix colored text? If so, pls tell me

@teixeira4 It's a pull request. The fix is literally in the commit above named "Fix colored text"

literally confused on how i fix it, could someone tell me in steps pls, im a bit slow

literally confused on how i fix it, could someone tell me in steps pls, im a bit slow

Wait for this pull request to be merged.

oh kk, ty

coloured text works for me now, I hat to install.


Add about section to README

Just 1 - 2 sentences what this is all about.

Any ideas how to wrap this up?
/cc @jnbt @rrrene

Puh, two sentences?

Duty is an extendable framework for the creation, composition and execution of pre-defined tasks running Ruby code or shell commands in one or more working directories. Its design evolved around the abstraction of common workflows for projects involving one or more Git repos with consistently named branches and tags.

Maybe a bit academic, but shorter is always more difficult :wink: Feel free to modify!

Pretty good starting point.
Any other suggestions / modifications?
If not i would just put it into the README for now.


[Table] ability to update TableToolbar/TableToolbarSearch search placeHolderText

Have the ability to update the search place holder text that is integrated with the Table/TableToolbar/TableToolbarSearch component
Expected behavior
The ability to use any text/sentence place holder in TableToolbarSearch

I found I can use the i18n.searchPlaceholder to change the place holder text


Not working with Visual Studio Team Services / Web Access

GhostText for Chrome is unable to detect the content editable areas in Visual Studio Team Services / Web Access. You can get access to the pages if you have a msdn account at https://www.visualstudio.com/products/visual-studio-team-services-vs
After some debugging in the browser I've tracked the problem down, and it's due to the content editable areas being loaded in an iframe where the only body element is the content editable area.
<iframe frameborder="no" tabindex="0">
<html>
	<head>
		<link href="https://link.to/EmbeddedPage.css" type="text/css" rel="stylesheet">
		<link href="https://link.to/RichEditor.css" type="text/css" rel="stylesheet">
	</head>
	<body contenteditable="true"> Text area </body>
</html>
</iframe>

https://github.com/GhostText/GhostText/blob/master/chrome/scripts/input-area.js#L184
This line is looking for content editable areas under the body of the document, which doesn't exist so  the solution that works for me would be to start the querySelectorAll() at the document rather than the document.body.
I noticed the Google content editable detector isn't searching from the body so maybe you had similar issues with detecting their editable areas?

To add support for input areas inside iframes, GT needs a big rewrite and currently ain't nobody got time for that, unfortunately.
Will be tracked in #75


Log in udp stream and dynamic upstream

Cannot figure out how to query redis backend to determine upstream server.
I have tried directly in balancer_by_lua_block, but I get 'openresty/site/lualib/resty/redis.lua:59: API disabled in the context of balancer_by_lua*'. I have tried access_by_lua in the server and upstream, but that is not allowed there. Is there any directive that will allow me to query redis in my config?
My config is below.
stream {
    log_format simple '$remote_addr [$time_local] '
        '$protocol $status $bytes_sent $bytes_received '
        '$session_time';

    upstream dns_servers {
        server <IP_ADDRESS>:53;

        access_by_lua '

           local Redis = require "resty.redis"
           local redis = Redis:new()
           redis:set_timeout(1000)
           local conn,err = redis:connect("<IP_ADDRESS>", 6379)
           if not conn then
               ngx.log("failed to connect: ", err)
               return
           end

           server, err = redis:get(ngx.var.remote_addr)
           ngx.var.server = server

        '

        balancer_by_lua_block {
           -- local table = {
           --    ["<IP_ADDRESS>"] = "<IP_ADDRESS>"
           -- }
           local balancer = require "ngx.balancer"
           -- local server,err = table[ngx.var.remote_addr]
           if ngx.var.server then
              ngx.log(ngx.OK, "server defined as: ", ngx.var.server)
              local ok,err = balancer.set_current_peer(ngx.var.server, 53)
           else
              ngx.log(ngx.ERR, "source could not be found")
              return
           end
        }

        # keepalive 10;
    }

    server {
        listen 53 udp;
        listen 53;

        proxy_pass dns_servers;
        error_log /var/log/openresty/dns-error.log debug;
        access_log /var/log/openresty/dns-access.log simple;
    }
}

I was able to solve this with the preread_by_lua_block directive in server.

Yes preread_by_lua_block is the way to go.


Exclude file is being ignored

After updating from restic 0.8.1 to 0.8.3 (with no other changes to my setup) restic has started throwing a permissions error on a path that is listed in an exclude file, so should be getting ignored.

Output of restic version
restic 0.8.3
compiled with go1.10 on linux/amd64

How did you run restic exactly?
restic-0.8.3 backup --exclude-file /path/to/exclude --no-cache -r gs:bucket:/restic /mnt/project
using parent snapshot e3f71c8b
scan [/mnt/project]
error for /mnt/project/.glusterfs: open /mnt/project/.glusterfs: permission denied
...

The exclude file contains:
.glusterfs
.glusterfs/*
.migrated
.migrated/*
.trashcan
.trashcan/*
css/*
ctools/*
js/*
styles/*
temp/*
tmp/*
xmlsitemap/*

What backend/server/service did you use to store the repository?
Google Cloud
Expected behavior

I want restic to not try to access the paths listed in the exclude file.
Actual behavior

Restic tries to access files and directories under paths listed in the exclude file.
Steps to reproduce the behavior

Do you have any idea what may have caused this?
I updated from restic 0.8.1 to 0.8.3.
0.8.1 did not throw the permissions error on the .glusterfs directory when running backups and restoring a snapshot made with 0.8.1 does not restore a .glusterfs dir (or any of the other paths listed in the exclude file), so it was happy with my exclude file syntax.
Do you have an idea how to solve the issue?
Other than downgrade to 0.8.1, sorry, no.
Did restic help you or made you happy in any way?

Restic makes me happy, but not nearly as happy as the helpfulness and responsiveness of the developer :-)

Should you be using --exclude-file=/path/to/exclude instead of --exclude-file /path/to/exclude?

Perhaps, but the current syntax worked fine on 0.8.1. I would expect that to also not work if I got the syntax wrong.

Thanks for the report! I think this is a bug. Both will work, --exclude-file=foo and --exclude-file foo.
As far as I can remember, we haven't changed anything in the exclude handling code since 0.8.1.
If you know how to do a git bisect between 0.8.1 and master, that'd be a good starting point to find out where the change in behavior was introduced. Do you know how to do that?
For each tested commit, you then run restic with a local repo and only list the path in question for backup, like this:
$ backup --exclude-file /path/to/exclude --no-cache /mnt/project/.glusterfs

That should produce the same error.

For the record: I'm unable to reproduce it. Can you please check that neither the file/dir /mnt/project/.glusterfs nor the lines in the exclude file have any leading/trailing spaces?

I’m running into a similar error, see https://github.com/restic/restic/issues/1706.
I’ve decided to open a separate issue because I was able to reproduce it in v0.8.1 and because it’s not limited to --exclude-file. Still, it might very well be the same underlying issue.

Ah, I only now saw your comment here. I think you're right, it's the same issue. I did not recognize the underlying cause before, thank you!

So, in summary: This issue is caused by restic trying to stat a directory before checking if it would be excluded. It's hard to change that with the way the code is structured right now. I'll try to get this one done after #1494 is finished. :)

Ha! I only just got around to checking this yesterday and found I get the same access warning locally on 0.8.1 that I did on 0.8.3. Remotely I hadn't seen it on 0.8.1, so I was about to close this issue assuming I screwed up the invocation or listing of subdirs in the exclude file. Glad I didn't :-)

This should be fixed with the new archiver code (https://github.com/restic/restic/pull/1494) in restic 0.9.0 🙂

Indeed, can somebody confirm?

I did a quick test run and 1.9.0 no longer prints a “permission denied“ error for excluded folders.
restic 1.8.3:
$ mkdir /tmp/restic /tmp/restic/source /tmp/restic/destination
$ mkdir -m 000 /tmp/restic/source/verboten
$ restic init --repo /tmp/restic/destination
enter password for new repository:
enter password again:
created restic repository 085b3c76b9 at /tmp/restic/destination

Please note that knowledge of your password is required to access
the repository. Losing your password means that your data is
irrecoverably lost.
$ restic --repo /tmp/restic/destination backup /tmp/restic/source --exclude=verboten
enter password for repository:
password is correct
scan [/tmp/restic/source]
error for /tmp/restic/source/verboten: open /tmp/restic/source/verboten: permission denied
scanned 1 directories, 0 files in 0:00
[0:00]   0B / 0B  1 / 1 items  0 errors  ETA 0:00
duration: 0:00
snapshot 40dc1520 saved

restic 1.9.0:
$ mkdir /tmp/restic /tmp/restic/source /tmp/restic/destination
$ mkdir -m 000 /tmp/restic/source/verboten
$ restic init --repo /tmp/restic/destination
enter password for new repository:
enter password again:
created restic repository 085b3c76b9 at /tmp/restic/destination

Please note that knowledge of your password is required to access
the repository. Losing your password means that your data is
irrecoverably lost.
$ restic --repo /tmp/restic/destination backup /tmp/restic/source --exclude=verboten
enter password for repository:
repository 085b3c76b9 opened successfully, password is correct

Files:           0 new,     0 changed,     0 unmodified
Dirs:            2 new,     0 changed,     0 unmodified
Added:      1.287 KiB

processed 0 files, 0 B in 0:02
snapshot 40dc1520 saved

Cool, thanks for the confirmation, I'm closing this issue.

close?

I bumped my install to 0.8.3 last week and the warning has indeed gone away - thank you :-)

Yep, forgot to close. thanks everyone ;)


[YUNIKORN-311] Code coverage is not updating for the core builds

Hey @adamantal,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 5fe745e0-d26a-11ea-9c70-53a116b43db5

I checked the logs of the codecov report, and the hash matches to me.
Tried another approach: added codecov.yaml and set the wait_for_ci flag to false. This should theoretically force the codecov bot to comment on the PR. Let's wait.

Hey @adamantal,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: d9e26d00-d32f-11ea-8b20-77bf1110b312

Hey @adamantal,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: b0eac240-d595-11ea-8ca9-c37e1b84d109

Hey @adamantal,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 153b98e0-d64b-11ea-8693-3322afd57804

Hey @adamantal,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: f8641a10-d6a1-11ea-8693-3322afd57804

Other builds are pushing codecov updates into the PR. I think we currently have this fixed.
Should we close this?

Yes, I think so. Closed.


[usm] Build lookup table test programs as Go modules

What does this PR do?
Build Go test programs used for generating the lookup tables (Go TLS monitoring).
Motivation
Enable use of 3rd party library types.
Currently our test programs (for example pkg/network/protocols/http/gotls/lookup/internal/program.go) used for the purposes of binary inspection can't rely on 3rd party libraries because the go build command is not able to automatically resolve dependencies.
This PR addresses that by making use of go modules.
Additional Notes
Depends on https://github.com/DataDog/datadog-agent/pull/24202

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@p-lambert looks good, but take care of the CI issues :)


Fixed some typos in  deploy_sample_app.md

While browsing the documentation I found a few typos that I have fixed.
There might be one more that I wasn't sure about on row 90 "You have deployed your first ICP dapp locally" Not sure if "ICP" should not be "IC"?

Thanks for much for these @aubort !

@aubort can you please accept the CLA so we can merge this? Thank you!

@dprats thanks, I thought I had accepted them yesterday. Done now, hope it worked: https://github.com/dfinity/cla/issues/224#issuecomment-1548119793

@aubort hmm should have worked. Let me see

@aubort I found the issue. It seems your original message you replied to via email since it has extra quoted text. The CLA bot is not start enough for that (we are working on it).
Can you please reply with just the phrase:

I, aubort, hereby agree to the DFINITY Foundation's CLA.

Sorry about the back and forth!

Ok @dprats. I've resent the email, pasting the sentence as plain text. Did it work now?

@aubort appears not... i think you may have to write it via github UI directly... :/

@aubort it worked! thanks!

@dprats it worked now! Thanks and sorry for the effort it created on your side for 3 typos :|


feat: add explicit pod version for ios

This PR sets AdGem iOS SDK pod version explicitly in AdGemDependencies.xml so that CI can later track it updates automatically.
Related to #1

Summary by CodeRabbit

New Features

Updated the AdGem integration to version 2.0.0 for improved performance and compatibility.

@dakotawashok Thanks. I'll give it a try and let you know if I encounter any issues with updating the workflow file.

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add Linux ARM64 to the supported platforms for the Delta extension

ah shit, sorry for missing this one @szarnyasg

no worries!


new(action): add report name suffix to prevent conflicts

As per title. Will fix GHA upload issues here: https://github.com/falcosecurity/falco/pull/3428

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 66553836a9e8daf2b5b05d9b7176bd3e4777ca54


WTM.Shared - Setup ISO15765 IDs

User is able to set IDs of ISO15765

Implemented setting via XML file


Swift refactor/rewrite [WIP] [NEED ASSISTANCE]

Here is some progress on the refactor to Swift. This is pre-alpha, and I am really looking for some help and assistance for getting these Swift errors ironed out.
Normally I'm embarrassed to publish half-baked efforts like this, but judgement defers to the maxim: RELEASE EARLY, RELEASE OFTEN!

This is now at the limit of my Swift knowledge. Seeking someone who knows what they are doing to help.