TextField inputRef type is wrong

It looks like useRef not working with React.Ref properly, because current is readonly there.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
TextFieldProps expects RefObject with readonly current in inputRef from useRef
Expected Behavior 🤔
TextFieldProps expects MutableRefObject with mutable current in inputRef from useRef
Steps to Reproduce 🕹

Here is the TS error in Codesandbox
https://codesandbox.io/s/material-demo-forked-2ij3f?file=/field.tsx:1222-1276
Context 🔦

I try to combine outer and inner refs of components levels for managing focus
Your Environment 🌎

Tech
Version

Material-UI
v4.11.0

React
16.13.1

Browser
Chrome last

TypeScript
3.9.7

etc.

@vadimshvetsov The provided ref should be readonly

@oliviertassinari Thanks, but useRef always returns MutableRef

@vadimshvetsov Remove react-hook-form and it should work fine

But there is no issue with react-hook-form. I think it should work with useRef without issues.


feat(tutorial): complete step 5

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

https://carbon-tutorial-ewensteele.eu-gb.mybluemix.net/#/

IBM Cloud link: https://carbon-tutorial-ewensteele.eu-gb.mybluemix.net/#/


Field suggestions for "fill_in"

This changes save me alot of time. Because when I make mistake in field name is annoying.
module Capybara::Node::Actions
  def fill_in(locator, options = {})
    raise "Must pass a hash containing 'with'" if not options.is_a?(Hash) or not options.has_key?(:with)
    with = options.delete(:with)
    find(:fillable_field, locator, options).set(with)
  rescue Capybara::ElementNotFound => exception
    all_fields = [];
    all(:fillable_field).each do |el|
      all_fields << el[:id] || el[:name]
      if el[:id].present?
        label_selector = %{label[for=#{el[:id]}]}
        if has_css?(label_selector)
          label = find(label_selector)
          all_fields << label.text
        end
      end
    end
    raise Capybara::ElementNotFound.new(%{Unable to find field "#{locator}", did you mean one if this: #{all_fields}})
  end
end

Unable to find field "Transaction fee1", did you mean one if this: ["Transaction fee", ...]

I think it would be nice to have it in capybara, what do you think?

Has anything like this been implemented yet? I think it sounds useful and I'd be interested in implementing a solution like this. Perhaps something similar for all ElementNotFound exceptions where it would recommend any elements with similar names. I can't count the number of times a field like "Title" hasn't been found because I was searching for "Title:" instead or something similar.

You can use this monkey patch. It works for me
How you want to detect possibilities for every ElementNotFound?
If I do find('.page_title') I don't know how to make it, list all possible css selectors will give too much information.

The problem I have with this is that the locator can be id, name, or label text - so printing out only some of those is incomplete and can lead to more confusion, yet printing everything could lead to huge strings of text on some pages.  This also misses the label text for labels with nested inputs and no 'for' attribute

So you suggest to use only one selector? last?
find('section div.some-class') # => suggest for other classes?

I just had other problem now: hidden elements, I think need to make suggestion for that too

@Paxa This should not be done for #find - It is impossible to determine what the user may have wanted there.  I was referring to your initial code, which only outputs id or name and some label text, it ignores name (if an id exists),  placeholder, and some labels text in its suggestion list.  I think an incomplete suggestion list is actually worse than no suggestion list since it creates the illusion of having all the info when in fact you don't.

So are you thinking you wouldn't want to see something like this implemented at all? Or would you be willing to consider some sort of implementation for adding the extra output to the ElementNotFound exception? I was thinking about trying to work on an implementation when I get some free time this weekend, but if it's something you aren't interested in at all, I won't bother with the PR.

@chrisccerami your description of doing it for all ElementNotFound errors is basically impossible,  those errors can come from any valid CSS or XPath selector, and trying to determine the users intention for that isn't really doable

@twalpole I think if we make it for find it will give wrong suggestions. For example fill_in, select, click_link etc using find inside. I think better to make decorators for errors every case. And may be make special case to detect if find called from capybara or from user's test

I have one more thing: (looks ugly but it works)
module Capybara::Node::Actions
  def select(value, options = {})
    orig_options = options.dup

    if options.has_key?(:from)
      from = options.delete(:from)
      find(:select, from, options).find(:option, value, options).select_option
    else
      find(:option, value, options).select_option
    end

  rescue Capybara::ElementNotFound => exception

    # Lets transfor 'Unable to find option "X"' to more helpful message
    if exception.message =~ /Unable to find option/
      if orig_options.has_key?(:from)
        options = find(:select, from, options).all('option')
        options_titles = options.map(&:text)
        #p options_titles
        raise Capybara::ElementNotFound, "#{exception.message}, options: #{options_titles}"
      else
        raise exception
      end
    else
      raise exception
    end
  end
end

before:
Capybara::ElementNotFound:
       Unable to find option "Cancel1"

after:
Capybara::ElementNotFound:
       Unable to find option "Cancel1", options: ["Process", "Cancel"]

@pavel - The "if we make it for find it will give wrong suggestions" is exactly my point about not being able to do it for all ElementNotFound errors.  Doing it for all the methods in actions.rb is probably possible.
The issues I have with your other two suggestions are

Your #fill_in method is incomplete in the suggestions it offers (as detailed in a previous message)
Both of these methods have a race condition where it's possible to get an error like
Unable to find field "Title" did you mean one of these ["Title", ....]
Where it's telling you it couldn't find a field and then asking if you meant that exact same field.  This is because of the time delay between the field not being found and then getting all the available things on the page.   I don't think there's really a clean way to fix that possibility so it should probably be checked for when the error message is generated and make a statement about the race condition if it happens.  This may have to take into the match mode currently being used.
This behavior would need to be turned on/off with a setting  -  Capybara.suggest_on_action_failure  or something like that

Closing due to age, and the nebulous chance of this even being doable in a complete manner than is useful


Prominent "error message"

Description
The "Found an error?" message is quite big and and prominent. In combination with the background color I get the feeling that I'm met with an error message. Perhaps it could be rephrased to something along the lines of "Improve this data"?

Thank you, that is great feedback!
Perhaps with #178 adding a new button, we should also address this issue to make room for more topical actions front and center and move the Wikidata to the top right corner. It could also then perhaps also be a bit more discrete.
I guess the question is if it should be a call to action, or rather serve more of an explaining provenance purpose.

Related to #87

#180 removes this for agency pages, the problem still exists for country pages which would be harmonized with topic pages design-wise at one point.

I have noticed that Google sometimes thinks these are soft 404s.


add details about why format is useful in itself

Many researchers want tools which use the DLx format on the backend, but the format itself is still more useful than existing ones, because of how easily it can be converted between other formats, and scripted over in any programming language. Give some examples of how the format enables these types of tasks / outputs.

 [spec] add details about why format is useful in itself


[BUG] Official Vevo Youtube Links throw an error

Bug Description
When trying to stream songs, songs that are official vevo links (ex: https://www.youtube.com/watch?v=pDFCCBxNX7c and https://www.youtube.com/watch?v=QYh6mYIJG2Y) the bot will throw
TypeError: Cannot read property 'contents' of undefined: There was an Unknown Error.     at \node_modules\discord-music-player\dist\managers\Queue.js:185:23     at processTicksAndRejections (node:internal/process/task_queues:96:5)
Reproduction Steps
Steps to reproduce the behavior:

Use play command with any "vevo" official release music link. (some examples linked above, but it is consistent on every vevo track I've tried.)
The play function I use is the following, in case it is relevant for debug purposes: let song = await queue.play(query).catch((err) => {      console.log(err);      if (!queue) queue.stop();    });
Upon attempting to play the song, the bot will throw the error in the console, and my error handler message is sent to my discord channel.

Expected Result
The song to play and not error, all other songs seem to work.
Attachments
If applicable, add screenshots to help explain your problem.
Versioning:

OS: Windows 10
Node Version v16.8.0
Module Version v8.0.2

Additional Comments
I posted this in the Discord server but wanted to make an official issue just to keep things organized.

Hey, thanks for letting me know. I will be looking into it today, and hotfix this issue.

Hi, i had the same problem, and it is a problem from the 'youtubei' library! the version '0.0.1-rc.20' has a bug with the videos that have purchase sections, u need to update to version "0.0.1-rc.24"

I will be updating all the dependencies today. Thanks for letting me know.

Can confirm that using npm i youtubei@latest to update to '0.0.1-rc.24' fixes the issue.

Fixed in v8.1.0.
npm i<EMAIL_ADDRESS>


success markers / cleanup

Proposed changes:

change tags to tags used in rules (as far as possible)
changed iter -> flatten()
removed ambiguous len (can be replaced with explicit len(marker.sub_markers) or len(marker.flatten())
upper-case operators (that was the choice for slot mappings until that got removed - but think it's nice to make it easier to differentiate)

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

... whatever we do with the tags, as long as can please change that len and iter, I'm happy cause I think that is a bit too confusing really :D
Again: There was some feedback from those feedback exercises (or was it Vincent? 🤔 ) pointing out that it is strange that it's a new set of tags one has to learn (that could be replaced by those from rules), which is why I suggested these changes. If people think this is too confusing, then let's switch back 🤷♀

Again: There was some feedback from those feedback exercises (or was it Vincent? 🤔 ) pointing out that it is strange that it's a new set of tags one has to learn (that could be replaced by those from rules)

I think it was both the feedback exercises and then Vincent. I recall Greg and Ben also mentioning something similar.


ZQVL & 0P6G

The Gurmukhi and Commentary are swapped on these two

Key
Value

View
https://database.shabados.com/sources/7/page/1/line/26

Source
Ganj Nama

Page
1

ID
ZQVL

Line
aus dw nwm nwnk pwqSwh hY qy auh s¤cy Drm vwlw hY [

Broken into separate issues #1258 & #1259


Cannot read property 'text' of undefined

Log:
Cannot read property 'text' of undefined: TypeError: Cannot read property 'text' of undefined
    at CodeParserController.check (C:\Users\MateuszPaluszkiewicz\.vscode\extensions\cschlosser.doxdocgen-0.3.1\out\CodeParserController.js:44:42)
    at CodeParserController.onEvent (C:\Users\MateuszPaluszkiewicz\.vscode\extensions\cschlosser.doxdocgen-0.3.1\out\CodeParserController.js:85:19)
    at CodeParserController.vscode_1.workspace.onDidChangeTextDocument (C:\Users\MateuszPaluszkiewicz\.vscode\extensions\cschlosser.doxdocgen-0.3.1\out\CodeParserController.js:26:22)
    at e.fire (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:96:784)
    at e.$acceptDirtyStateChanged (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:685:973)
    at e.$acceptModelSaved (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:685:723)
    at e._doInvokeHandler (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:636:832)
    at e._invokeHandler (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:636:550)
    at e._receiveRequest (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:635:631)
    at e._receiveOneMessage (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:635:400)
    at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:634:315
    at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:637:395
    at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:95:432
    at e.fire (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:96:764)
    at Socket.<anonymous> (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:154:338)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at readableAddChunk (_stream_readable.js:178:18)
    at Socket.Readable.push (_stream_readable.js:136:10)
    at Pipe.onread (net.js:560:20)

I need more information.
VSCode version, when did this happen, what were you trying to do?

Happens while editing any file format.
Version:
Version 1.24.1
Commit 24f62626b222e9a8313213fb64b10d741a326288
Date 2018-06-13T17:51:32.889Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

This is super strange and I can not reproduce it. This can only occur when the extension receives an event from the VS Code runtime and the event becomes undefined while we're reading a property from it.
Another thing is that JSON should not trigger the extension at all!
I added another check if the event exists. I will release it today hope this fixes it. Once you updated to 0.3.2 it would be great to hear back from you.

@christophschlosser looks like that's a breaking change inside the VSCode. I noticed the same bug in other package.


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2024-10-11)
Features

initial release (7d70ca8)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.0.0
:sunflower:


Failed to create Zip Archive reader

V0.21.3
Encountered an error:
Failed to create Zip Archive reader
Caused by:
invalid Zip archive: No valid central directory found
Location:
src/bookkeeping/mod_manager.rs:355:48
I received this error after updating.
I received it after downloading manually and extracting.
I received it when running as administrator

"mod.zip" exists in the extracted folder next to the noita_proxy.exe

Marked that version as pre-release for now.
The zip library refuses to open that zip file for some yet unknown reason.

Should be fixed in 0.21.4


Update on the README.md file to change the repo name from master to main

Hello @chandrikadeb7,
I made a few changes to the README.md file to reflect the change that GitHub had made recently with the renaming of the default repository from master to main.

@jcastle13 Thanks, this readme update counts so much! Well done.

Thanks @chandrikadeb7 😊


headed playwright chrome with --disable-blink-features=AutomationControlled not detected

Headed chromium is only detected by navigator.webdriver, which can be disabled with the --disable-blink-features=AutomationControlled launch option.
Technically this also applies to Webkit, as there only navigator.webdriver is detected too, but I haven't found a launch option to do that yet. (It can still be done with stealth scripts but those are easier to detect)
Reproduction code:
from playwright.sync_api import sync_playwright, TimeoutError

with sync_playwright() as p:
    print("Testing chromium")
    # disable headless & navigator.webdriver
    browser = p.chromium.launch(headless=False, args=["--disable-blink-features=AutomationControlled"])
    page = browser.new_page()
    page.goto('https://fingerprintjs.github.io/BotD/main/')
    try:
        handle = page.wait_for_selector("#result.result-detected", timeout=1_000)
    except TimeoutError:
        print("Chromium is undetected.")
    else:
        print("Chromium is detected.")

    # input("press enter to continue> ")  # just incase you want to see the site yk
    browser.close()

Hi @Le0Developer.
You are right, that detecting webdriver can be bypassed using flags. We won't fix it though, because it's not the scope of BotD OSS. If you want more sophisticated bot detection, see our BotD Pro https://fingerprint.com/products/bot-detection/
I'm closing for now, if you have any other questions, lmk.


WaitForSidecarAsync works only if there is a daprd.exe instance running on port 3500

Expected Behavior
DaprClient.WaitForSidecarAsync() to correctly detect sidecar
Actual Behavior
If there is not an instance of daprd.exe running on port 3500, it fails
Steps to Reproduce the Problem
Debug a dapr application in VS code using the daprd task with an http dapr port different from 3500
N.B.  if a daprd.exe instance on port 3500 (also different from the one under debugging) is running, the issue disappears.
Seems related to 4557

@francotiveron - I suspect what's going on in your case is that the DAPR_HTTP_PORT and DAPR_GRPC_PORT env-vars are not set.
There's a set of environment variables that dapr sets for you when you do dapr run ... to launch your app. The SDK is aware of these variables and uses them to configure things like ports.  The SDK also gives you ability to set these values manually if you want to get them via some other mechanism.
We're not experts in what the VS Code extension does here, so hopefully this explanation helps you solve the issue. @philliphoff any insights?

@rynowak The VS Code task has settings for those ports, hence I think that is not the problem
        {
            "label": "daprd-debug-mine",
            "type": "daprd",
            "config": ".dapr/localhost/config.yaml",
            "componentsPath": ".dapr/localhost/components",
            "appId": "yatp-mine",
            "appPort": 5162,
            "httpPort": 3500,
            "grpcPort": 50002,
            "metricsPort": 9092,
            "dependsOn": "build-mine",
            "presentation": {
                "close": true,
            }
        },

@francotiveron - I'm also not super familiar with the VSCode extension, but taking a quick look at it and the VS Code Task settings, I wonder if it's looking for the args and command values:
https://github.com/microsoft/vscode-dapr/blob/main/src/tasks/daprCommandTaskProvider.ts#L31
This makes me think that the dapr sidecar and the application are being run in separate commands which would mean that the environment variables aren't being set for the application, hence the lack of availability.
Have you tried manually setting the environment variables? It'd help to narrow this down until we can get some input from someone who knows the extension better.

@halspang Tried, no difference. The env variable gest overridden by the task settings, as expected

So if you add logging into your app, what does it think the env variable is?
Similarly, what does the output your dapr list command look like?

@francotiveron Ah, yes, @rynowak is correct.  The Dapr sidecar is started entirely independent of the .NET process being debugged, so if using the Dapr SDK and non-standard ports, you'll need to supply the same Dapr ports as environment variables to the .NET debug launch configuration as supplied to the Dapr task itself.
VS Code can't use dapr run for debugging because that CLI doesn't allow a pipe to be established for the debugger to communicate with the debuggee.  The VS Code API also doesn't allow for propagating the output of build tasks (such as the one that starts the Dapr sidecar) to the input of the launch configuration (that starts the .NET process and debugger), so we're often not able to do convenient things such as automatically configure environment variables of the debug process based on dynamically chosen values (e.g. ports) from a build task.

see https://github.com/dapr/docs/issues/2417


Add concurrent.cr

Link
https://github.com/didactic-drunk/concurrent.cr
Checklist

[x] - Shard is at least 30 days old.
[x] - Shard has CI implemented.
[ ] - Shard has daily/weekly periodic builds (ideally with Crystal latest and nightly).

Can you setup periodic builds? And seems CI is using some older Crystal versions.

Done


Using loadTheme to dynamically change the background color crashes and freezes the whole page

Hello, love this package but running into problems with loadTheme. I want to be able to have one canvas and to be able to dynamically change the background and particle colors using a state change. However when using loadTheme it freezes the web page if I try to change background color (particle color is fine). I've simplified the code as much as possible and it still isn't working
const ParticleGallery = () => {
  const particlesInit = useCallback(async (engine: Engine) => {
    await loadFull(engine);
  }, []);

  const particlesLoaded = useCallback(
    async (container: Container | undefined) => {
      setTimeout(() => {
        container && container.loadTheme("theme_example");
      }, 3000);
    },
    []
  );

  return (
    <Particles
      id="tsparticles"
      init={particlesInit}
      loaded={particlesLoaded}
      options={{
        fpsLimit: 60,
        fullScreen: {
          enable: false,
          zIndex: 0,
        },
        background: {
          color: "#802129",
        },
        particles: {
          color: {
            value: "#000000",
          },
          number: {
            value: 40,
            density: {
              enable: true,
              value_area: 800,
            },
          },
          shape: {
            type: "square",
          },
          opacity: {
            value: 1,
            random: false,
          },
          size: {
            value: 300,
            random: true,
          },
          move: {
            enable: true,
            speed: 1,
            direction: "none",
            random: false,
            straight: true,
            out_mode: "out",
          },
        },
        interactivity: {
          detect_on: "window",
          events: {
            onHover: {
              enable: true,
              mode: "repulse",
            },
            onClick: {
              enable: true,
              mode: "push",
            },
            resize: true,
          },
          modes: {
            grab: {
              distance: 400,
              lineLinked: {
                opacity: 1,
              },
            },
            bubble: {
              distance: 500,
              size: 500,
              duration: 2,
              opacity: 1,
              speed: 3,
            },
            repulse: {
              distance: 200,
            },
            push: {
              particles_nb: 4,
            },
            remove: {
              particles_nb: 2,
            },
          },
        },
        themes: [
          {
            name: "theme_example",
            options: {
              background: {
                color: "#ffffff",
              },
              particles: {
                color: {
                  value: "#5F65FF",
                },
              },
            },
          },
        ],
        retina_detect: true,
      }}
    />
  );
};

@matteobruni further to this I have tried your codepen example https://codepen.io/matteobruni/pen/MWopjRP in React and it also causes the page to freeze when changing theme. Any ideas how I can fix this?

const ParticleGallery = () => {
  const particlesInit = useCallback(async (engine: Engine) => {
    await loadFull(engine);
  }, []);

  const particlesLoaded = useCallback(
    async (container: Container | undefined) => {
      container?.canvas.initBackground();
      setTimeout(() => {
        container && container.loadTheme("red");
      }, 3000);
    },
    []
  );

  return (
    <Particles
      id="tsparticles"
      init={particlesInit}
      loaded={particlesLoaded}
      options={{
  themes: [
    {
      name: "light",
      default: {
        value: true,
        mode: "light",
      },
      options: {
        background: {
          color: "#ffffff",
        },
        particles: {
          color: {
            value: ["#000000", "#0000ff"],
          },
        },
      },
    },
    {
      name: "dark",
      default: {
        value: true,
        mode: "dark",
      },
      options: {
        background: {
          color: "#000000",
        },
        particles: {
          color: {
            value: ["#ffffff", "#ff0000"],
          },
        },
      },
    },
    {
      name: "red",
      options: {
        background: {
          color: "#ff0000",
        },
        particles: {
          color: {
            value: ["#ffffff", "#000000"],
          },
        },
      },
    },
    {
      name: "green",
      options: {
        background: {
          color: "#00ff00",
        },
        particles: {
          color: {
            value: ["#000000", "#0000ff"],
          },
        },
      },
    },
    {
      name: "blue",
      options: {
        background: {
          color: "#0000ff",
        },
        particles: {
          color: {
            value: ["#ffffff", "#00ff00"],
          },
        },
      },
    },
    {
      name: "yellow",
      options: {
        background: {
          color: "#ffff00",
        },
        particles: {
          color: {
            value: ["#000000", "#ff0000"],
          },
        },
      },
    },
    {
      name: "cyan",
      options: {
        background: {
          color: "#00ffff",
        },
        particles: {
          color: {
            value: ["#000000", "#ff00ff"],
          },
        },
      },
    },
    {
      name: "grey",
      options: {
        background: {
          color: "#777777",
        },
        particles: {
          color: {
            value: ["#ffffff", "#000000"],
          },
        },
      },
    },
  ],
  fpsLimit: 60,

  particles: {
    number: {
      value: 30,
      density: {
        enable: true,
        value_area: 800,
      },
    },
    shape: {
      type: ["circle", "square"],
    },
    opacity: {
      value: 1,
    },
    size: {
      value: 30,
      random: {
        enable: true,
        minimumValue: 15,
      },
    },
    rotate: {
      value: 0,
      direction: "random",
      animation: {
        speed: 5,
        enable: true,
      },
    },
    move: {
      enable: true,
      speed: 6,
      direction: "none",
      out_mode: "out",
    },
  },
  interactivity: {
    detectsOn: "canvas",
    events: {
      onHover: {
        enable: true,
        mode: "repulse",
      },
      onClick: {
        enable: true,
        mode: "push",
      },
      resize: true,
    },
  },
  detectRetina: true,
}}
    />
  );
};

Sorry for the delay, I wasn't home. I have seen the issue, but I don't know why, I need to inspect it deeper. I'll let you know when I have news

It will be fixed in the next version, the deep equal library has a bug with circular objects. I've changed it but it will be fixed when the next version will be released


Post-deployment: Remove obsolete tables and other database objects

After some time has passed and we have confidence in the stability of the application and correctness of the migrated data, archived and obsolete database objects should be removed, including:

[ ] _archive_* tables
[x] gora.* views and schema
[x] admin.* objects and schema to be migrated in #682 682

use ComplaintTracking

drop view gora.ClosedComplaintActions;
drop view gora.ClosedComplaints;
drop view gora.ComplaintCounts;
drop view gora.OpenComplaints;
drop schema gora;

use ComplaintTracking

drop table _archive_AspNetRoleClaims;

drop table _archive_AspNetUserClaims;

drop table _archive_AspNetUserLogins;

drop table _archive_AspNetUserRoles;

drop table _archive_AspNetRoles;

drop table _archive_AspNetUserTokens;

alter table _archive_AspNetUsers
    drop constraint FK_AspNetUsers_LookupOffices_OfficeId;

drop table _archive_Attachments;

drop table _archive_ComplaintActions;

drop table _archive_ComplaintTransitions;

drop table _archive_Complaints;

drop table _archive_EmailLogs;

drop table _archive_LookupActionTypes;

drop table _archive_LookupConcerns;

drop table _archive_LookupCounties;

drop table _archive_LookupOffices;

drop table _archive_AspNetUsers;

drop table _archive_LookupStates;


"Botești", "Barticești" and "Nisiporești" are listed in the drop-down menu

Description:
"Botești", "Barticești" and "Nisiporești" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Botești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Botești, NEAMȚ (Botești)" and "Comuna Botești, NEAMȚ".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Barticești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Barticești, NEAMȚ (Botești)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Nisiporești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Nisiporești, NEAMȚ (Botești)".


Convert OAuth login page into native RTV

RTV currently performs OAuth by opening an external web browser, and having the user login to accept the OAuth request. This can lead to problems if the user doesn't have an external web browser installed on their system, or it isn't properly configured.
IMO it would be better if RTV could open the OAuth window internally through the app. This would probably involve scraping the OAuth page HTML (beautiful soup is already a dependency). I should look into this further and see if there are any other options.

The user could just set the browser as a cli one like elinks or w3c.


[Task]: analytics event for navigation in the DP

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks

The timer starts when the user hits the more button
The timer ends when the user navigates to the next page
This should be added to a new event called DP_NAVIGATION_TIME

Start timer when user clicks on more, end timer when we switch to a different entity.


[Minor]Resolve sbt warnings during build (MQTTStreamSuite.scala).

cc @andrewor14

Test build #25362 has started for   PR 3989 at commit a6e967e.

This patch merges cleanly.

Test build #25362 has finished for   PR 3989 at commit a6e967e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25362/
Test PASSed.

Merging this. Thanks!


Automated cherry pick of #4545: elastic account add random password

Cherry pick of #4545 on release/2.13.
#4545: elastic account add random password

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.13@eb1f2e0). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.13   #4547   +/-   ##
==============================================
  Coverage                ?   6.84%
==============================================
  Files                   ?     522
  Lines                   ?   88786
  Branches                ?       0
==============================================
  Hits                    ?    6078
  Misses                  ?   82202
  Partials                ?     506

Flag
Coverage Δ

#aFlag
6.84% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/elasticcache_accounts.go
3.52% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb1f2e0...d301fd1. Read the comment docs.


custom can't work

@andyoulovexy that error usually means that it can't read the log files. Can you verify in the container by trying to access the mapped volume? Also, it doesn't look like you provided the entire configuration file. If you can provide the whole thing that would be great.

Closing this for now... open again if you want me to work on it.


Fix unsafe lowering of fast path for String.charAt

We optimistically load a cached value into the result operand. But if the cached value is null, we'll have to call a helper to complete the operation, and if the result operand and string source have the same symbol, then we have overwritten the string we pass to the helper with null. Use a temp in such a case and copy it to the result operand only if it is non-null.

:shipit:


StraberryShake unlisted from nuget

Seeing this warning  The owner has unlisted this package. This could mean that the package is deprecated, has security vulnerabilities or shouldn't be used anymore.
https://www.nuget.org/packages/StrawberryShake/
Which is a relevant tool to use now to generate client side classes?

Hi @VarunSaiTeja
We unlisted the preview because we now have rewritten strawberry shake and do not want new people to start working with this old preview.  You can still use it though.
The blogpost about it will follow soon.

@PascalSenn, @michaelstaib   Please provide the steps to generate client-side classes with the new strawberry shake.
Due to the lack of documentation about the new strawberry shake. My development work is stopped.

StrawBerry Shake is in preview, the documentstion will come soon
why is your development work stopped? you can still use 11.0.0-preview.137


[32228] csrf_exempt decorator async support

Patch for ticket 32228.

Thanks for this patch :+1: Closing in favor of #13483 which makes all built-in decorators async compatible. It would be great if you could check it out.


Updated for cache auto-configuration

Removed the explicit cache manager bean and updated the guide accordingly.

Looks great.
Can you drop the "Since version 3.1" clause? We don't need to drag along new vs old Boot behavior.
Have you signed the CLA?

I've removed that now.
Yes, I have signed the ICLA

Looks perfect. If I could trouble you to squash that, I'll merge it.

I'm quite new to Git, so I'm not entirely sure whether I did it right.

git rebase -i master
Mark every commit, except the first, as "s" for squash. You'll have an interactive opportunity to polish the final commit message. Then "git push --force" to your branch.
Read this for more details. http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Thanks. I missed the --force at first, so did a pull and created a mess.

Perfect!


Corrected a grammatical error

Fixed a grammatical error from
- instead of have to litter
+ instead of having to litter

Thank you!


vendor: Re-vendor virtcontainers

Bring the CPU constraints changes.
12f35ce qemu: enable CPU hotplug
925a70c pod: hot add/remove vCPUs before starting containers
4a84438 qemu: Add support for CPU hot add/remove
c17c48d vendor: Constraint containerd vendoring
c9996f3 filesystem: set correct access mode for pod dir tree
4f9cb18 kata_agent: Add nouuid option for xfs filesystem
085848b kata_agent: Provide hotplugged device the right rootfs path
9ef18a6 kata_agent: Update host and guest paths for Kata
2c88b8e kata_agent: Wait for rootfs if it is a hotplugged device
15a4d17 kata_agent: Support block device passthrough
fd5b27f vendor: Update Kata agent protocol
0519e89 check: lint: ineffassign in qemu.go
ae661c5 network: Fix lint errors
5c73774 shim: Start shims inside PID namespace
6d7f6e5 shim: Add ability to enter any set of namespaces
f318b77 shim: Add the ability to spawn the shim in new namespaces
fefb087 pkg: nsenter: Introduce a generic nsenter package
43c05c2 utils: setup: Add some more prereq checks to the setup script.
1a25bad docs: developers: Add some developer docs
Fixes #219
Signed-off-by: Gabriela Cervantes<EMAIL_ADDRESS>

LGTM

Thanks for the PR @GabyCT !
@amshinde please take a look and merge if you're okay with it.

lgtm

lgtm
Just a reminder - if you indent the list of commits by a couple of spaces, they get rendered in a fixed-width font which is much easier to read (atleast for me ;)


Bug: JS error at Full Text Search management

Environment
Host

item
version

OS
CentOS 7.6

GROWI
3.5.0-RC (703215f9b1ddc727486e2036bb03edfbf52581dc)

node.js
10.16.0

npm
6.9.0

Using Docker
yes (Kubernetes)

Using growi-docker-compose
no

Client

item
version

OS
macOS 10.14.5

browser
Chrome 75.0.3770.80

How to reproduce? (再現手順)

Open Full Text Search management

What happens? (症状)

In JS console, TypeError happened.

What is the expected result? (期待される動作)

No error

@shield-9 Thank you for your report. I have confirmed it was reproduced. I'll fix this soon.


error installing react

npm ERR! code ENOENT
npm ERR! syscall spawn C:\gradle\gradle-6.4.1\cmd.exe
npm ERR! path C:\Users\User\Downloads\multiple-news\EMAIL-TEMPLATE 2
npm ERR! errno -4058
npm ERR! enoent spawn C:\gradle\gradle-6.4.1\cmd.exe ENOENT
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR!      C:\Users\User\AppData\Local\npm-cache_logs\2022-10-05T12_27_40_797Z-debug-0.log

use npm install create-react-app
In order to create React application, you will need to have a Node that is >= 14.0. 0 and npm >= 5.6

Done, what next?
On Fri, Oct 7, 2022, 6:42 PM Aarize Siddique @.***>
wrote:

use npm install create-react-app
In order to create React application, you will need to have a Node that is

= 14.0. 0 and npm >= 5.6

—
Reply to this email directly, view it on GitHub
https://github.com/facebook/create-react-app/issues/12762#issuecomment-1271871141,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2SLSKZFUJFS2RNVGRLNC7TWCBOHZANCNFSM6AAAAAAQ5RIAWM
.
You are receiving this because you authored the thread.Message ID:
@.***>

try
npx create-react-app myapp

step1: Make a new directory and in the terminal type: "npx create-react-app myapp"
step 2: If you are still getting an error, uninstall node js from your system, reinstall it carefully, and again try step 1.
Follow this as a step-by-step guide for nodejs installation.


Hdrheap more modernization

This depends on #4953.
This is a generic pass for C++17 fixing, before I start on the actual project of extending HdrHeap to support easily adding more heap types. I would end up doing this anyway, and it's better to have it separate to reduce confusion.

Change #define constants to C++ constants.
Add more const on character pointers.
Get rid of the ROUND #define.
Convert C style casts to C++ style casts.

[approve ci autest]


Public API release 1

First setup of the public API, includes initial ground work and the following endpoints:

api/v1/version
Obtain current app version.
{
  "number": "0.4.0",
  "name": "Lucina"
}

api/v1/player/{name}/salt
Obtain player's Salt-y-Meter score and rank.
{
  "score": 32,
  "rank": 2
}

Done


in webgpu, how did you achieve image transparency with the dice.png texture?

The transparent pixels in my own texture are just being rendered black.

nevermind, I figured it out. I'm not configuring blend correctly/at all. Sorry for the noise!
By the way it's great to see your flurry of webgpu related activity lately!

Glad you figured it out! I've definitely been bitten by the same issue before.

btw on gl-matrix, do you foresee the library remaining largely unchanged to be usable within webgpu? I think the NDC, framebuffer and coordinate systems are all the same, but maybe I'm missing something that would make it incompatible.


Custom errors set in Per-VIRTUAL_HOST default configuration

Hi,
I am intercepting all errors, from all containers (bar.com and foo.bar.com), to display custom pages.
I am able to do this using a /etc/nginx/vhost.d/default file :

proxy_intercept_errors on;
error_page    400 401 402 403 404 500 502 503 504   /404.html;
location = /404.html {
root   /usr/share/nginx/html;
internal; # I tried without this too
}

The custom error is displayed, but the problem is I cannot get the style and images of it doing :

src="/img/image.gif"
or even
src="image.gif"

The browser still seem to try to get the static files from the location of the website

https://foo.bar.com/img/style.css
not from  /usr/share/nginx/html

I tried several methods but can't get this to work, any help would be well appreciated :D
Thanks,

Maybe embed all resources into the page? if you have a dedicated url for the error resources you could use <base>.

I don't have any dedicated URL for the errors ; and embedding can be a solution, but isn't there a way to do it the 'normal' way ?

You could try something like:
location = /error-resources {
    root /usr/share/nginx/html;
}

And then use <img src="/error-resources/img/image.gif">
But then i think you will intercept all "/error-resources/..." request for the proxied web servers. The internal directive is to tell nginx that the location is only valid for error_page etc and not accessible by http clients over network, in your case images and css files can't be internal as the browser will fetch them


[201] [Jitsi Facelift] Update connection related styles from the new design

Treelo Card
Description
In this PR we are adding an updated participant low connection information display.

makes connection indicator to resize according to the connection status - worse status bigger icon
makes participants video layout to have a red shadow if the connection is low
makes poor connection notification to show if the connection of participants lower, if the connection improves the notification is removed without user interaction
fixes participants video layout hover styling
moves _participants-right-strip.scss to _participants.scss as this module is responsible not only for the right strip styling

@Jazastry Can you please update changelog.md to add your changes, thanks!


Update readme-dt.md for ctor usage and interfaces as per #23

The readme file for the dt repo (i.e. for the d.ts usage) needs to be updated to explain how to use either the callback or promise ctors, and why there are two promise interfaces. See #23.

It also needs to explain why pouchdb-loose.d.ts and pouchdb-plugins.d.ts exist, and how to use them.


[containers/metrics/provider] Log collector ID in debug msg

What does this PR do?
Adds a missing collector ID in a debug log from the containers metrics provider.
Motivation
Useful for debugging.
Describe how to test/QA your changes
Skip.
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] The appropriate team/.. label has been applied, if known.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

Closing because it has been included in https://github.com/DataDog/datadog-agent/pull/10001


feat(operators): combineAll operator

Description:
An operator to combine values from source observables. The values emitted by early observers are saved until the last observer emits, following which all the previously saved values are emitted.
first$: ---a---b---c--
second$: ---------------d--
result$: [ad, bd, cd]

@benlesh @cartant Can you please take a look and let me know what your thoughts on the changes? Please consider it a draft change. I want a green light before I add more to this PR. Thanks in advance.

Same as prior feature implementation requests (https://github.com/ReactiveX/rxjs/pull/5939#issuecomment-758284916, https://github.com/ReactiveX/rxjs/pull/5089, and others)
Core team strongly suggest to create new features via userland custom operators instead of including it in core as we generally trying to reduce core api surface, also with pipe it is straightforward to create a new operator as separate library. If a new features should require core lib change we'd like to ask to have some details what part of core lib change is required & usecases it should be included in core.

@kwonoj I have been implementing operators in my library and would have preferred to do the same for this operator as well. But looking at the implementation of the combineAll operator, it looked like I needed to have access to some internals like OperatorSubscriber and executeSchedule methods. If there is a replacement of these internals, that is already present in the exposed APIs, I will be happy to use those and close this PR.
From what I further understand from your comment is that the direction of this library development now is towards making it a framework which can be used to implement the operators in user libraries or perhaps even make the current operators available in a separate library which would rely on this core library. Is that right?

It seems like this PR is reimplementing combineLatestAll? I guess I'm not sure I understand this PR. Is there an issue that this is solving?


Updated Gtag

Google has released a newer tag for GA.

I have tested this for my website and it works.

You seem to have refactored the code, it'll be great if you can test this out on your version.
Thanks!

Hi, thanks for pointing this out. I didn't get why you closed this PR. If you don't mind submitting another PR that updates Google Analytics, it'd be very much appreciated. Thanks!

There was a bug in this one :-D
Thanks for considering my PRs!


Corrected typo in README for refreshClusters()

Corrected typo on line 134 and slightly improved explanations about refreshIconOptions() method.
Improved clarity of example for L.Marker.refreshIconOptions method.

Thanks for all the PRs.
Go get your tshirt if you haven't already

Hi Dave,
Thank you for the link, I was not aware of it! :-)
I love goodies.
Cheers!


Rotated images appear not rotated in uploading preview

If you are reporting a bug please:

Check the bug has already been reported (https://github.com/yarl/pattypan/issues).
Explain the current issue.

Some cameras rotate images in a way that in a file browser (Nautilus) these appear ok. However the pattypan preview show them in landscape orientation and not potrait. Example is this file: https://commons.wikimedia.org/wiki/File:Bernartice,_pohled_před_rybník_ke_kostelu_svatého_Petra_a_Pavla.jpg

Describe the expected behavior.

The uploading preview in Pattypan should show this images as rotated.

Add the problematic spreadsheet and a example media file (drag & drop here).

The media file is mentioned above. This bug is not related to the table per se. The camera used is SONY DSC-HX400V. The pattypan version is 20.04

Add the PattyPan log file (drag & drop here). You find a link to the PattyPan log at the application start screen.

Yeah, it behaves similar to how UploadWizard does it, but is indeed a bug.


Api should enable setting the model quality

Thank you for this great project.
I'm developing a web app where I show multiple thumbnail-sized viewers in a grid layout. By default all the viewers download the highest available model quality which in the thumbnail preview is unnecessary and creates memory issues.
If there's currently a workaround to set model quality manually please let me know.

Hi @Solcany ,
Yes, you can use the 'quality' parameter either in the component attributes or url.
https://smithsonian.github.io/dpo-voyager/story/launch/

Thank you @gjcope no idea how I missed that


feat: enable strict mode

Part of https://github.com/taiga-family/taiga-ui/issues/8410

@vladimirpotekhin please, review me


Adds option to force cppcheck to run

Adds an option to force cppcheck to analyze files that are otherwise too large normally. Of course this option may slow down VS Code, so the option defaults to false.

I'll probably merge in the force parameter tomorrow. I don't understand why you have the added 'let runArgs ...' to runCppcheck() in analyzer.ts. The 'outputCommandLine' config option is provided for this purpose.


xlsx - The filetype you are attempting to upload is not allowed.

When using upload library

PHP 5.2.17 Centos
Codeigniter develop branch

$config = array(
'allowed_types' => 'xlsx',
);

will throw "The filetype you are attempting to upload is not allowed."

PHP 5.3 Windows
Codeigniter develop branch

$config = array(
'allowed_types' => 'xlsx',
);

no problem at all

No still doesn't work on live server for the code.
'xlsx' => array('application/vnd.openxmlformats-officedocument.spreadsheetml.sheet', 'application/zip', 'application/vnd.ms-excel', 'application/msword', 'application/x-zip'),

@cyberformed When I told you to post on our forums, I didn't mean to comment on other threads here.


REFACTOR : _run_config() should not return file_writer_config.

Now, _run_config returns that :
https://github.com/ManimCommunity/manim/blob/1a516dbc64b0f105914e5a9be6d66aa839cec964/manim/config/config_utils.py#L536
4 things, including file_writer_config.
I do think file_writer_config should be computed outside this function, as now there are several others config type (in particular cfg subcommand, logger, and later livestream subcommand).
file_writer_config should use config_parser like the other configs, outside of _run_config()
Cc @leotrs

I'm working on #337 which is going to make this problem go away.
I never liked having separate file_writer_config and config. The former was meant to be used only internally, and the latter was meant to be exposed to the user. But they ended up being pretty similar. In the future, I'm planning on removing file_writer_config and having a single config dict. The config dict will be used (almost always) internally, and the user will have access to another object, a frame, which contains things like pixel_width and pixel_height, which are the config options most used by users, but also things like UP and LEFT_SIDE, which refer to the geometry of the frame.
Also in the future, the whole mess of cfg subcommands, logger, config, _run_config, _parse_cli etc etc etc will be refactored so nothing is really parsed twice.

Done. See #337


tweak duplicate keyword javascript error message

Why was this change made? 🤔
Fixes #2518
AFTER

BEFORE

How was this change tested? 🤨
⚡ ⚠ If this change involves consuming from or writing to another service (or shared file system), run integration test create_object_h2_spec.rb and/or test manually in [stage|qa] environment, in addition to specs. ⚡

@jcoyne I didn't change the behavior at all;  I just changed the error text.   The app works the same as before for empty keywords -- it removes the field if it is empty.


pytest-mypy only checks test files when providing testpaths

With a src layout for files, and this setup.cfg:
[options]
package_dir=
  = src
packages = find:
setup_requires =
  pytest-runner

[options.packages.find]
where = src/
exclude =
    test
[tool:pytest]
python_files = *.py
# providing testpaths makes pytest-mypy only check tests
testpaths = test
addopts =
  --mypy
[mypy]
# this line sadly gets ignored using pytest-mypy
files = src

mypy is only applied to the files in test folder (fails on imports from src folder). This might even be following the spec of mypy (which says setup.cfg "files" will only be used if no other argument is provided), but it makes pytest-pylint less useful.

This is essentially a duplicate of #67.
tl;dr:

[Using the Mypy files setting with pytest-mypy is] a pretty wonky thing conceptually. In some sense, the point of this plugin is to let pytest handle collection 🤔

testpaths affects Pytest collection, which can definitely affect what gets tested with mypy, but it doesn't affect the behavior of files.
You nailed the reason files gets ignored: pytest-mypy passes all collected .py files to mypy, so arguments are always provided.

If no .py files are collected by Pytest, then execution ends after collection (i.e. there are no MypyItems to run, so there is nothing to even invoke mypy).
Even if files wasn't ignored, a file that wasn't collected by Pytest would have no corresponding MypyItem with which to report the outcome of the mypy check.

Please feel free to chime in over there if you have thoughts to share 😊


UTF-8 character in output has incorrect display width

Hi! We use buildpack-deps as a base image for some Devcontainer images for interactive development environments, and we got a bug report about UTF-8 characters in a bash shell causing output to be overwritten.
Here's a minimal repro:
docker run --rm -it buildpack-deps:jammy-curl
root@7cfc2546c1ac:/# echo ➜

Then, alternate between the up and down arrow keys to cycle through commands in the command history and notice characters in the shell getting overwritten.
https://github.com/docker-library/buildpack-deps/assets/746020/f1deae6a-78ff-4329-b45e-5f60e59372d3
You can also verify the computed display width using echo ➜ | wc -L which should output 1 but instead outputs 0.
This issue does not reproduce when using ubuntu:jammy as the base image. Going through the Dockerfile one step at a time, the issue happens after gnugp is installed, although it's not clear to me why: https://github.com/docker-library/buildpack-deps/blob/93d6db0797f91ab674535553b7e0e762941a02d0/ubuntu/jammy/curl/Dockerfile#L14
Manually setting LANG=C.utf8 fixes the issue. Would it make sense to set this directly in the buildpack-deps image? Or is there some other reason the default lang/locale works on ubuntu:jammy but not on buildpack-deps?

We (intentionally) don't do much/any configuration here -- we just install a bunch of upstream Debian and Ubuntu packages. :sweat_smile:
I would imagine that installing gnupg is installing some locale related files (or regenerating them?) but I'm 100% guessing.  I would suggest that this bug is probably more productive to chase somewhere in Ubuntu/Debian instead. :see_no_evil:


Doesn't ever stop

It doesn't seem to ever stop. I've had this running all day! :smile:
Every now and then it will reshuffle, but it's always been at 66%. (This is using the demo SVG)

If infinite time is available :) you could loosen the constraint about biggest size down just a little - which might jostle them into an even tighter config.
Perhaps by having two versions of polygonarea().
One of which is used only for the order selection part and randomly returns a number "slightly smaller" than the real polygon area... ??

so the biggest size thing is the starting point. The more iterations that are run, the farther you get away from that order via mutation.
material utilization is a bit misleading right now. The area used is just the sum of the area of all the parts divided by the area of the bin. Effectively it will be the same as long as the number of bins stays constant.
Should probably replace that with the are of the rectangular bounds, but the bin is not guaranteed to be rectangular so that wouldn't be completely accurate either. Think of the utilization number as a hint rather than a hard stat.

but the bin is not guaranteed to be rectangular

no problem [1]
[1] http://www.codeproject.com/Articles/13467/A-JavaScript-Implementation-of-the-Surveyor-s-Form

So to answer the original question (in case you weren't kidding). The solution space is too vast to find the exact optimal solution, so the GA continuously searches for better solutions until you tell it to stop.
As for the utilization parameter, the exact area is what it displays now. But I think using the rectangular bounds would be a better reflection of the quality of the nest.

Jack000,
I used to work for a company that did optimization solutions.  They had a 'good enough' limit to stop unlimited iterations.  Once you got within a half percent between iterations (if I remember right) it was considered 'good enough' nesting.  You might implement something like that, even with a settable 'good enough factor' (like default to .1% but allow any percent to be entered). ... Just a thought.

yeah I guess that is a viable solution. I think this is more of a UX issue though - the expectation is that it will find a solution and stop, whereas the search is actually open-ended and could continue indefinitely.
I'm thinking a message could appear when nesting starts, that says something like "stop the program when you're satisfied with the solution"


Add Omar Aguinaga to contributors list

@OmarAguinaga, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


Extend e2e pipeline with EdgeDNS coverage

#91 implements end-to-end testing of most of ohmyglb functionality with exception of EdgeDNS part which includes

Zone Delegation
Associated split brain handling.

As it is very special part of the codebase and very environment specific (Infoblox, Route53, ...) we need to address it separately from the rest of terratest e2e pipeline.

Duplicate of https://github.com/AbsaOSS/k8gb/issues/351


Zipper breakdown

An attempt to break Zipper into traits as per #76.
Not sure whether this is the most elegant way to do this...
As there's a bunch of ZipperXXX files now, I decided to move them into a separate folder.
Should we move them into a separate sub-package as well?

Wow, I'm really on the ball here…  Taking a look now, should have some feedback tonight.

Wow, I'm really on the ball here…  Taking a look now, should have some feedback tonight.

And just because I'm a horrible person, I didn't take care of this last week.  I have now though!  Everything looks good.  I do think you're right though that the zipper stuff (minus Zipper.scala) should be in its own package.  I went through and implemented that change, which is now pushed to my djspiewak:zipper-breakdown branch.  Let me know if there's anything I did wrong or something you want to change, otherwise I'll merge that branch into master this week.
Sorry again for taking so long!

I still have reservations about the readability of the whole thing, feels like the Zipper is being spread too thin between the numerous traits.
Also, before merging into master, the comments on #76 should be addressed (efficiency and usability).
I don't expect that the whole "zipper shifting" implementation is production ready, it was intended to be used only as a concept.

I still have reservations about the readability of the whole thing, feels like the Zipper is being spread too thin between the numerous traits.

That is the downside, to be sure.  It really only makes sense if we have something like ZipperAxes that we're trying to enable.  In other words, I wouldn't merge these changes separately; they belong together.

Also, before merging into master, the comments on #76 should be addressed (efficiency and usability).

Addressing…

I don't expect that the whole "zipper shifting" implementation is production ready, it was intended to be used only as a concept.

Gotcha.  How would you like to proceed?

I can think of multiple possible bottlenecks in the code:

Freely hashing and sorting paths.
Using ZipperHoleMap for depth first iteration. As noted in the code it was not optimized for it.
Redundant traversals of the tree: first collecting paths, then converting to values.

Of course, I don't have any benchmarks to prove that, but I do know that addressing these issues would make the shifting code even uglier than it's already is.
The first step should probably be making some sort of pseudo benchmark, just to get a feel of whether the performance is anywhere near acceptable.

Adding the operations discussed in #76.
The same comments about performance still apply.


[FLINK-17822][MemMan] Use private Reference.tryHandlePending|waitForReferenceProcessing to trigger GC cleaner

What is the purpose of the change
#11109 did not export jdk.internal.misc package used by reflection for GC cleaners of managed memory. Our PR CI does not run Java 11 tests atm. The package has to be exported by a JVM runtime arg: --add-opens java.base/jdk.internal.misc=ALL-UNNAMED;
If this arg is set for Java 8, it fails the JVM process. Therefore, the fix is complicated as we have to do it also for e.g. Yarn CLI where client and cluster may run different Java versions.
This PR suggests a quicker fix. We call directly the private method (has to be made accessible via reflection):

java.lang.ref.Reference.tryHandlePending(false) // for Java 8
java.lang.ref.Reference.waitForReferenceProcessing() // for Java 11

Unfortunately, this leads to the annoying warning for Java 11 about Illegal reflective access.
We can do the quick fix and think how to tackle the warning in a follow-up.
Verifying this change
Existing unit tests but also running them and e2e tests with Java 11.

@flinkbot run azure

Thanks for the review @tillrohrmann
merging this


test: Make tests pass on cultures without . as decimal point

E.g. de-DE

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>7:
0.0%

Covered Lines:
3752

Relevant Lines:
3752

💛  - Coveralls

Good catch! I’m usually better about thinking about i18n issues.


Verbose Error Flag Request

Metro2 Version: v0.2.6
What were you trying to do?
Print more verbose errors on what field / location in the input file is causing the error.
What did you expect to see?
A specific part of the file which caused the program to error so I could resolve it.
What did you see?
Generic error

How can we reproduce the problem?
Run the print command on unpacked_fixed_file.dat for instance.

Agreed. I think these enhanced messages should be the default. Seems we were just naive before when returning errors.

I am tried to print error message contained exact field name and record(segment) name and reason
example:
./metro2 validator --input test/testdata/unpacked_fixed_file.dat
Error: total_consumer_segments_j1 in trailer record has an invalid value

please let me know another approach to have nice error message

@adamdecaf Will @mfdeveloper508's updates get pushed to a docker hub build?

@mattbernardo yea we can make a v0.3.0 release.
@mfdeveloper508 do you have anything else to add before a release is made?

I haven't now

@mattbernardo v0.3.1 is released, can you try it out? Let us know if you have any problems or questions. Thanks!


embedded-kafka. Not possible to change docker image base

I have private repository with proxy to docker hub.
In configuration properties I can change only dockerImageVersion
but base docker image always is "confluentinc/cp-kafka" (taken form testcontainers.kafka)
Constructor with confluentPlatformVersion is deprecated in testcontainers.kafka in prefer to constructor with final DockerImageName dockerImageName as argument
Is it possible to add dockerImage property in KafkaConfigurationProperties
and use DockerImageName instead dockerImageVersion as argument for KafkaContainer constructor?

Hi. Please prepare PR with required changes. You can check the following PR as an example: https://github.com/Playtika/testcontainers-spring-boot/pull/770/files


Added download icon to Claim Previews

PR Checklist

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Fixes
Issue Number: #3623
What is the current behavior?
On hover of claim preview nothing happens
What is the new behavior?
On hover the claim preview will show a download icon
Other information

Thanks for getting this in so quickly @Meantub ! We had a PR that went in earlier, so it looks like there's a conflict, can you take a look?
Once we get it reviewed and merge, shoot me a DM on Slack so we can show you some appreciation!

Included your changes in https://github.com/lbryio/lbry-desktop/pull/3640


Layout 'page' requested in docs/dev.markdown does not exist.

Build Warning: Layout 'page' requested in docs/dev.markdown does not exist.

It is missing information what command have been launched.


No Transparency

Hi i using arch with gnome 3.10. I would love to use gnome-pie but the menu is not transparent. It shows a black square as background.
I installed gnomepie from aur and compiled it by myself. Both dont work. I can't find any errors in logs.
I think the problem is, that the bg.svg is not shown transparent. But i could not fix it.
any suggestions?

Hi! This should be fixed  6d9b7ba. I'll update the master branch soon!


Snapshot test for component with uuid

I have an interesting test issue. I've got custom components that use the uuid node package to generate unique IDs which I can map to labels for accessibility purposes. Here is a sample Checkbox component, for instance:
import React, {PropTypes} from 'react';
import classNames from 'classnames';
import {v4} from 'uuid';
import Label from './Label';
import Icon from './Icon';

const Checkbox = ({
    label,
    className,
    name,
    defaultChecked,
    disabled,
    toggle,
    onChange
}) => {
    const classes = classNames(
        'Checkbox',
        {'Checkbox-toggle': toggle},
        'FormElement',
        'FormElement-optional',
        className
    );
    const id = `Checkbox-${v4()}`;

    return (

            <input
                className="FormElement-item"
                id={id}
                type="checkbox"
                name={name}
                onChange={onChange}
                defaultChecked={defaultChecked}
                title={label}
                aria-label={label}
                disabled={disabled}
            />
            <Icon id="check" />
            {!toggle && label}

    );
};

Checkbox.propTypes = {
    className: PropTypes.string,
    name: PropTypes.string,
    label: PropTypes.string.isRequired,
    defaultChecked: PropTypes.bool,
    onChange: PropTypes.func,
    disabled: PropTypes.bool,
    toggle: PropTypes.bool
};

Checkbox.defaultProps = {
    defaultChecked: false
};

export default Checkbox;

This works fantastic in my app and keeps accessibility happy. Now, I'm adding Jest snapshot testing to my setup and testing this component. The issue obviously happens when v4() runs because it creates a unique ID every single test run so the snapshots never match up.
What is the suggested way to deal with this? I can't imagine I'm the only one in the world doing something like this but you never know :)

Disregard, just mocked it as such:
jest.mock('uuid', () => {
    return {
        v4: jest.fn(() => 1)
    };
});

Wrote this up too quickly :)

This was really helpful to me.  Just gonna add some context in case other people find this.
I used the jest.mock() function posted above in my test files and made sure to import uuid/v4 as 'import { v4 } from 'uuid'' in the corresponding component files.
Thanks for this post and for posting your solution - was really helpful!

I am having a really weird problem.
I have the exact same scenario, only mocks that were working fine, no longer work. I can't see why.
my components import thusly;
import uuid from 'uuid';
my mock looks like this;
jest.mock('uuid', () => { 	let value = 1; 	return () => (value++) });
this used to generate snapshots with 1,2,3,4 etc through the components. Now, the mock is being completely ignored and I'm getting UUIDs there. I haven;t changed any of my tests so I can only assume it's something environmental? Any ideas?

Hey @Bappy1988 I'm not sure why your mock has stopped working.
An alternative way to test this is with the new Snapshot Property Matcher released in Jest@23. See here
You should be able to write your test like this instead:
it('renders component with any uuid number', () => {
  // create component
  expect(component).toMatchSnapshot({
    propSetToUuid: expect.any(Number),
  });
});

// Snapshot
exports[`renders component with any uuid number 1`] = `
Object {
  "propSetToUuid": Any<Number>,
  "other": "props",
}
`;

Where propSetToUuid is the prop that uses the generated ID.
I hope this helps :smile: if not feel free to ask for help over in our discord channel in Reactiflux

Hi @mattphillips
Thanks for the quick response!
I've got to the bottom of the mock failing - it appears to be an issue with 22.4.4 - downgrading to 22.4.3 and ensuring all its dependencies/related packages are also on 22.4.3 has fixed the mocking.
Should I raise a separate bug for that?
I'll switch over to Snapshot Property Matcher in future tests.
Thanks :)
Ben

that's definitely a bug, 22.4.4 should only contain 1ea05fbe4147b8e3f22cedd36ad2e37f088cf7ea and bed949b4c31f01fc0ebdb8c95934a3fa7fbf53ca on top of 22.4.3

@SimenB
Thanks, I'll put together a separate bug report. I suspect the issue may be more to do with how yarn is installing related packages but I'll include everything I have found out thus far.
Thanks

The solutions suggested here don't seem to work with the recommended way to import uuid.
import uuidv4 from 'uuid/v4';
I've tried several different ways to mock uuid/v4, but none seem to work. Any ideas?

@icd2k3, it sounds like subfolders aren't supported (not likely to be anytime soon, per #226). But! This should still be doable via jest.mock in the offending test(s):
jest.mock('uuid/v4', () => () => '00000000-0000-0000-0000-000000000000');

thanks @rjz
also note setting this in jest.setup.js will mock it for the entire test suite.

Just for completeness sake, if you need different UUIDs but with deterministic values for testing, this is how you would do it:
jest.mock("uuid/v4", () => {
  let value = 0;
  return () => value++;
});

I have found this works really nice.
At the top of test file:
// your regular imports here

jest.mock('uuid', () => ({ v4: () => '00000000-0000-0000-0000-000000000000' }));

// describe('test suite here', () => {

in the actual code:
import { v4 as uuidv4 } from 'uuid';

Just for completeness sake, if you need different UUIDs but with deterministic values for testing, this is how you would do it:
jest.mock("uuid/v4", () => {
  let value = 0;
  return () => value++;
});

This does not appear to work across multiple tests.  The counter resets.

For anyone thats wants to use mockImplementationOnce or other jest.fn() features you can do so like this.
jest.mock("uuid", () => ({
  v4: jest.fn(),
}));

beforeEach(() => {
  const mockUuid = require("uuid") as { v4: jest.Mock<string, []> }; // "as" is TypeScript you can ignore
  mockUuid.v4
    .mockImplementationOnce(() => "uuid-1")
    .mockImplementationOnce(() => "uuid-2");
});

afterEach(() => {
  jest.resetAllMocks();
});

For anyone thats wants to use mockImplementationOnce or other jest.fn() features you can do so like this.
jest.mock("uuid", () => ({
  v4: jest.fn(),
}));

beforeEach(() => {
  const mockUuid = require("uuid") as { v4: jest.Mock<string, []> }; // "as" is TypeScript you can ignore
  mockUuid.v4
    .mockImplementationOnce(() => "uuid-1")
    .mockImplementationOnce(() => "uuid-2");
});

afterEach(() => {
  jest.resetAllMocks();
});


Fix range comparison

The start of ranges in LSP is zero-based.
I don't know is this function still in use, just fix it while reading source codes.

I added test cases to cover all my changes. For the range comparison, here is a reference implementation from vscode: https://github.com/microsoft/vscode/blob/addd445017c9c5531b89851dc8dc9bec4f1dd0f8/src/vs/editor/common/core/range.ts#L420C16-L420C31


Optimizations to the way we handle ledger close times in RPC

Add SerialIter::Skip, needed for extracting just the close time
Add a "tx" option to the "ledger" command so you can now do ledger validated tx to see all transactions in the validated ledger. (Previously, you had to build the query in JSON to do that.)
Add a function to get a ledger's close time without constructing the ledger and crowding the ledger cache. Use this function to date-stamp transactions for RPC.
Use the ledger close time function to avoid falsely claiming that the delivered_amount is unavailable. We still use only the ledger sequence number in the vast majority of cases.

Needs a #include for nouninty:
diff --git a/src/ripple/rpc/impl/Utilities.cpp b/src/ripple/rpc/impl/Utilities.cpp
index bc6215a..389df1d 100644
--- a/src/ripple/rpc/impl/Utilities.cpp
+++ b/src/ripple/rpc/impl/Utilities.cpp
@@ -17,6 +17,7 @@
 */
 //==============================================================================

+#include <ripple/app/ledger/LedgerMaster.h>
 #include <ripple/rpc/impl/Utilities.h>
 #include <ripple/app/misc/Transaction.h>
 #include <ripple/json/json_value.h>

Except for the missing #include, my comments are nitpicks.  This passed tests for me.  Needs rebasing against develop, but will do so cleanly.

Rebased and comments addressed

Current coverage is 49.24%

Merging #1396 into develop will decrease coverage by -0.02% as of b1670dc

@@            develop   #1396   diff @@
=======================================
  Files           963     963
  Stmts         66880   66907    +27
  Branches          0       0
  Methods           0       0
=======================================
+ Hit           32946   32947     +1
  Partial           0       0
- Missed        33934   33960    +26

Review entire Coverage Diff as of b1670dc

Powered by Codecov. Updated on successful CI builds.

Grrr. Github ate all my pre-rebase comments.

:+1: Everything passes for me, looks good.

:+1:

:+1: if you don't want to reorder those constants in getCloseTimeByHash. The CI failures appear to be spurious.

Merged as c726377012f4d2f438a6a64e69b7ca7af600f8f6, d9905ec7191f5c8903a15d19e1e16625363a9673, 3a039fff66c46861c96e697e8d2eda8dfb57c4cb and 9f96d7ea38c0e8aa536455c777991e3910d220f0.


added mud to presets natural

Refs: https://github.com/openstreetmap/iD/issues/4923

Not 100% sure about terms here, but I left it as wetlands. Mainly because I'm following the fact that in sand.json the value used in terms is desert, which is pointed out here: https://wiki.openstreetmap.org/wiki/Tag:natural=sand
Found the similar term in mud and adopted this.

Looks good, thanks @Xavier-J-Ortiz ...
Adding wetland in the terms is fine.. These are just words that users can search for to find the preset.


Control via YAML files

It can be useful to collect all the relevant variables like:

gridsize
dt
Nsimulations
loss subparameters (nunroll, ecc..)
NN model for closure

into a single configuration_x.yaml. This will allow us to run generate.jl configuration_x.yaml or postprocess.jl configuration_y.yaml on a server without using a REPL.
This approach is better than training all the different models via a single train_array.jl because it allows more flexibility.

I see that the current code is prone to error in the following case:
train a-priori, the batch_size is used (i.e. manually and explicitly specified) in preprocess_priori.jl to create the dataloader. Then in train_priori.jl for the creation of the callback there is a new batch_size that needs to be passed. I do not think is problematic if they do not match exactly but is weird that we do not have it as a global param of the training.


Ended up with state containing only pinLogo

I was experimenting with the logo click effect and ended up with demo.html listing only pinLogo in the list of sensors.
No error was logged.
Presumably this is a state update bug of some sort though I couldn't reproduce it. Hopefully it will be clear from reviewing the code.

I did a quick review and can't see how this can happen, though it clearly did and, if the bug is in the sim not the demo seems pretty bad. I'll try to have another look before launch.

Spent more time trying to reproduce this with no joy. Perhaps I confused the version I was testing. Closing this unless we see it again.


villager trades are very broken

a lot of villager trades get randomly locked when they level up, or in the case of one villager i have, all of his trades are locked despite never trading with him, making leveling him up or just trading with him impossible

i think what's happening for trades being locked is that for some reason, the mod sets the required villager level for an item trade at something absurd like level 30, despite villagers max level being 5

i don't know what's causing trades to suddenly become locked behind another level they didn't require before

Seems like trades have their requiredLevel field set to either 1 or a multiple of 5. May be related to another bug that we were experiencing that for some reason gave emeralds bought from villagers an NBT tag of requiredLevel as well, making them both unstackable with other emeralds and also untradeable with villagers.

Please tell me the version of the mod where this is happening, currently 1.20.6 and 1.20.4 are completely different versions in this regard

Please tell me the version of the mod where this is happening, currently 1.20.6 and 1.20.4 are completely different versions in this regard

1.20.6

Fixed in version 1.6.7, thanks for reporting!


[BugFix] Show proc backends should not forward to leader

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #12697
Problem Summary(Required) ：

Show proc '/backends' should not forward to leader
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

starrocks_be_unittest succeeded.

starrocks_be_unittest succeeded.

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

run starrocks_admit_test


Http status command randomness

Relevant Issues

#731

Closes #731
Description

When cat or dog subcommands are not invoked the parent command (http_status) will show a cat or dog picture, relating to the status code given, randomly.
Did you:

[x] Join the Python Discord Community?
[x] Read all the comments in this template?
[x] Ensure there is an issue open, or link relevant discord discussions?
[x] Read the contributing guidelines?

I think I fixed all the issues. Sorry for the troubles. When I committed it went to the wrong branch so I had to revert it and that deleted my code on my PC somehow. So I had to redo it and must have forgot to lint.


AWS Sagemaker Docker

hey, I think if a Docker was provided that people could use to deploy vLLM to AWS Sagemaker it would increase usage of vLLM dramatically.  Is one available?

We do have an official docker image vllm/vllm-openai for our OpenAI compatible server. I'm not quite sure what would it take for SageMaker to use vLLM container.

It seems like the container is only maintained by AWS Sagemaker team and we have no control over image distribution? I believe just running pip install vllm on one of the PyTorch image should work. But for official image, you might need to ping your account manager or support to get this prioritized in Sagemaker team.


Showing leaderboard precision value dynamically

Fix #284  : Add option to change leader-board decimal precision
Changes proposed in this pull request:
Removed static leaderboard score value and added code to dynamically get the value from input box for precision value
http://pr-287-evalai.surge.sh

TO be honest, I found difficulty in materialize css I think it is better to use bootstrap (yeah, I understand for this we need to change it in each page).

@Abhi58 Can you please fix the build?
And also why are there @Shekharrajak commits :arrow_down:

Oh! It looks like because I cherry-pick few commits.

TO be honest, I found difficulty in materialize css I think it is better to use bootstrap (yeah, I understand for this we need to change it in each page).

Hi @Abhi58, What difficulty/issues did you find in materialize CSS?


Details polyfill often not necessary

We currently polyfill most features of our details/summary element ("progressive disclosure"). But most modern browsers support it nowadays and according to HTML5 Accessibility even its accessibility is 100% supported in Chrome, Firefox and Safari.
It's only IE, Edge and older browsers which need some special treatment. It would make sense to only use the polyfill for those browsers and use the native version for those which fully support it.
Cons
Changing the polyfill that way would need a lot of testing.
And there will be an intersection of older browsers which support the element but aren't accessible yet. Those will get a worse experience than before, but then again, the amount of users using old Firefoxes, Chromes and Safaris should be extremely small.
Pros
Doing this would reduce complexity of the polyfill.
And it would fix things which work better natively than with our polyfill (e.g. in VoiceOver on iOS).
I guess it would probably not make sense to change this for the sake of it, but rather when touching the code anyway or if there is a specific problem which would better be fixed by this than complicating it further.

This seems like a good idea, we seem to be polyfilling sections already.
https://github.com/alphagov/govuk_frontend_toolkit/blob/master/javascripts/govuk/details.polyfill.js#L15
Our check looks to be brittled based on https://github.com/Modernizr/Modernizr/blob/master/feature-detects/elem/details.js
👍

Do we think the development of GOV.UK Frontend is a good opportunity to revisit this code and make the polyfill more targeted?

I've raised an issue on GOV.UK Frontend to explore reducing the scope of polyfilling which I hope will address these issues, thanks again Anika.
See https://github.com/alphagov/govuk_elements/issues/573#issuecomment-419465180


Add support for strings longer than 64 kB

The Data{Input,Output}Stream classes only support [de]serializing
strings up to 64 kB of length, because they store/expect the length
of the string as a short. Sometimes, we need to read/write
longer strings. This commit does that by not using the built-in
support for strings, but doing a very similar thing manually.
A string is serialized as a number of bytes of an UTF-8 encoding
of the string (using our custom variable-length encoding of numbers),
followed by the byte array of the UTF-8 encoding of the string.
This only applies in a new persistent index format version. Older
versions are still handled using the old encoding.
Note that while Data{Input,Output}Stream uses a custom encoding
for strings, called "modified UTF-8", we use UTF-8 directly. For our
purposes, it shouldn't make a difference.
Fixes #49

This was a wrong solution, see https://github.com/wildfly/jandex/issues/49#issuecomment-932308817
Gonna submit another PR with a proper fix.


vale: 1.0.3 -> 1.2.6

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build vale

Success on aarch64-linux (full log)
Attempted: vale
Partial log (click to expand)
shrinking /nix/store/c4fx37kk96cpmy85lg4gpxf9mff4zwik-vale-1.2.6-bin/bin/docs
cannot find section .dynamic
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c4fx37kk96cpmy85lg4gpxf9mff4zwik-vale-1.2.6-bin/bin
patching script interpreter paths in /nix/store/c4fx37kk96cpmy85lg4gpxf9mff4zwik-vale-1.2.6-bin
checking for references to /build in /nix/store/c4fx37kk96cpmy85lg4gpxf9mff4zwik-vale-1.2.6-bin...
cannot find section .dynamic
cannot find section .dynamic
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
/nix/store/c4fx37kk96cpmy85lg4gpxf9mff4zwik-vale-1.2.6-bin

Success on x86_64-linux (full log)
Attempted: vale
Partial log (click to expand)
shrinking /nix/store/4cih5lvgqxkqcwdlqchawgx65v2gfdvk-vale-1.2.6-bin/bin/vale
cannot find section .dynamic
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4cih5lvgqxkqcwdlqchawgx65v2gfdvk-vale-1.2.6-bin/bin
patching script interpreter paths in /nix/store/4cih5lvgqxkqcwdlqchawgx65v2gfdvk-vale-1.2.6-bin
checking for references to /build in /nix/store/4cih5lvgqxkqcwdlqchawgx65v2gfdvk-vale-1.2.6-bin...
cannot find section .dynamic
cannot find section .dynamic
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
/nix/store/4cih5lvgqxkqcwdlqchawgx65v2gfdvk-vale-1.2.6-bin

Success on x86_64-darwin (full log)
Attempted: vale
Partial log (click to expand)
find: '/nix/store/xh28y5hjah79xgv7gzhhk9z39f79wahi-vale-1.2.6': No such file or directory
find: '/nix/store/xh28y5hjah79xgv7gzhhk9z39f79wahi-vale-1.2.6': No such file or directory
find: '/nix/store/xh28y5hjah79xgv7gzhhk9z39f79wahi-vale-1.2.6': No such file or directory
find: '/nix/store/xh28y5hjah79xgv7gzhhk9z39f79wahi-vale-1.2.6': No such file or directory
find: '/nix/store/xh28y5hjah79xgv7gzhhk9z39f79wahi-vale-1.2.6': No such file or directory
find: '/nix/store/xh28y5hjah79xgv7gzhhk9z39f79wahi-vale-1.2.6': No such file or directory
find: '/nix/store/xh28y5hjah79xgv7gzhhk9z39f79wahi-vale-1.2.6': No such file or directory
find: '/nix/store/xh28y5hjah79xgv7gzhhk9z39f79wahi-vale-1.2.6': No such file or directory
find: '/nix/store/xh28y5hjah79xgv7gzhhk9z39f79wahi-vale-1.2.6': No such file or directory
/nix/store/n7c90iqwv7pilvjd0j15nfwqgba31qnz-vale-1.2.6-bin


Namecoin / Emercoin support

Would it be possible to add support for Namecoin / Emercoin?
Thanks greetings

Gonna close this now, might look into this in the future.

Seems EthDNS is not working, dnslookup ens.eth https://dns.dnswarden.com/ returns NXDOMAIN.


Support compilation on GHC 8.6

This makes it possible to build at least concat-examples and its dependencies with the GHC 8.6 beta release. I believe it should now build with 8.0 or later (earlier versions are not supported, please let me know if this is a problem).
To find a build plan it is necessary to specify allow-newer: base, ghc, Cabal, stm because not all dependencies have been updated yet. In addition the vector-sized package needs a tiny fix to build on 8.6, see expipiplus1/vector-sized#48.
The verilog package, a dependency of concat-hardware, doesn't build with GHC 8.4 or later. Should concat-hardware be marked as unbuildable? (This is similar to the situation with concat-graphics due to language-glsl, see #45.)
There are two failures due to unexpected output in gold-tests on 8.6, see here for details. It's possible that these are harmless changes, I'm not familiar enough with the code, but the differences in complex-mul-syn look non-trivial.
In 4490d14 I introduced an explicit call to error in place of the previous partial pattern match. Presumably this case doesn't arise in practice, but I thought it should be pointed out.
In 6f98f47 I specify that the plugins should never force recompilation, using the new machinery in GHC 8.6. Is this correct? It may be that a finer-grained recompilation check is needed; I'm not sufficiently familiar with the plugins to know.

Wow. Great stuff. Thanks a bunch, Adam! I've tested with GHCs 8.0.2, 8.2.2, and 8.4.3, and all looks fine. How are you testing with GHC 8.6?

I'm using the 8.6.1 release candidate (actually <IP_ADDRESS>80823) from hvr's PPA along with a cabal.project.local that specifies the allow-newer options I mentioned above. I checked out vector-sized locally with https://github.com/expipiplus1/vector-sized/pull/48/commits/8c8d6942dc856722bfd47d2ace137cf6dbca12a9 and pointed to it from cabal.project.
On the subject of testing, I'm wondering if it is desirable to get better coverage using Travis CI. At the moment it seems only GHC 8.0.2 is used, and the tests aren't built/executed. Is there any reason we can't build with multiple GHC versions as far as possible (modulo unsupported dependencies), running the tests but not failing the build for "expected" golden test failures? Would it be helpful if I worked up a PR to adjust the Travis config?

Thanks for the explanation, @adamgundry. I had not heard of cabal.project or cabal.project.local files. I guess I'm behind the times. A few questions:

Are these files new in Cabal 2.0?
Are these files for declarations that could instead go into stack.yaml?
Do you recommend abandoning Stack in favor of modern Cabal features?
Requiring anyone who uses concat to make a local copy of vector-sized with your commit seems burdensome. Could we instead point to that commit on GitHub, as I sometimes do in stack.yaml?

I'm all for improved testing. I know next to nothing about Travis. The setup I use now came from someone else. Yes, please do rework the testing as you think best, especially if you can try it yourself to make sure it works and that it's practical to use. I'm a little concerned about testing taking too long to be useful if we use multiple compilers and gold tests, but I'm eager for advice and help.

Ah, sorry, since there was a cabal.project file in the repo and it was used in the CI I assumed too much familiarity! These are indeed a new feature of cabal-install 2.0, and they make it much easier to work with multiple packages simultaneously across multiple GHC versions, using cabal new-build. There is certainly some overlap with what can be specified in a stack.yaml file, but it's not a precise mapping.
To some extent new-build is still being polished, and it requires learning slightly different workflows, so I wouldn't universally recommend switching from Stack at the moment. For example, specifying a dependency based on a Git commit is possible only in the latest development version of cabal-install.
I'll take a look at the testing/CI setup. I can also try to come up with an alternative stack.yaml for use on GHC 8.6 (e.g. addressing the vector-sized issue).

Thanks for the tips about cabal-install 2.0.
Funny. I'd forgotten or maybe hadn't noticed that cabal.project file.
Probably the only file in the repo I've not read or written.
I've pinged @expipiplus1 via email about your pull request. Perhaps he'll merge your PR soon.

@adamgundry We're now getting vector-sized from GitHub, including the merge of your PR needed for GHC 8.6.

@adamgundry AFAICT, the verilog package is building under 8.4.3. Are you seeing something different?

Sorry, my mistake, I was missing your commit to verilog that fixes the build under 8.4.3. Thanks for making the vector-sized related changes.