Sporadic failure in Synthetix repo

Definition of Done
All tests are succeeding in the synthetix repo

After merging https://github.com/NomicFoundation/hardhat/pull/4889 & https://github.com/NomicFoundation/hardhat/pull/4911, all tests are succeeding


Some overflow panics found by fuzzing

Hi, I am trying to do some fuzzing for this crate, and I found some panics related to overflow. I have filtered some panics which I think it is not a bug. But there still have some panics I wonder if it is a bug. I list the code snippets below.
I believe this one is a bug.
let _: i8 = num::integer::mod_floor(-128, -1); // panic at 'attempt to calculate the remainder with overflow'

The expected output of mod_floor is 0, which is not out of range of i8. The problem also exists on other types.
println!("{:?}",num::integer::mod_floor(i32::MIN, -1));
println!("{:?}",num::integer::mod_floor(i64::MIN, -1));
println!("{:?}",num::integer::mod_floor(i128::MIN, -1));

The following cases are caused by out of range result. I wonder if they should be considered as bugs.
let _: (i8 ,i8) = num::integer::div_rem(-128, -1); // panic at 'attempt to divide with overflow'
let _: i8 = num::traits::sign::abs(-128); // panic at 'attempt to negate with overflow'
let _: i64 = num::abs_sub(3544668469065756977, -9209525551093438927); // panic at 'attempt to subtract with overflow'
let _: (u128 ,u128) = num::integer::gcd_lcm(12009965891327239886941778839922608393,<PHONE_NUMBER>1328373236456281444243278208); // panic at 'attempt to multiply with overflow'
let _: u8 = num::integer::lcm(255, 127); // panic at 'attempt to multiply with overflow'

The mod_floor panics are consistent with Rust's % operator -- e.g. i8::MIN % -1 also panics.

The following cases are caused by out of range result. I wonder if they should be considered as bugs.

They should be considered bugs in the code that provided those inputs. There's no correct value that the library can return, but some of them will use Rust's wrapping-overflow semantics in release mode instead of panicking.
See also: https://doc.rust-lang.org/reference/expressions/operator-expr.html#overflow


feat: add missing import

I found this a little bit confusing, does this work without importing? So I submitted this PR, maybe I am wrong.

Thank you, leant a lot


adding   google_maps_flutter: ^0.5.11 to my dependencies.

if I had the following line :
google_maps_flutter: ^0.5.11
My App won't launch even if it wsa launching right before.
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:preDebugBuild'.

Android dependency 'com.google.android.gms:play-services-base' has different version for the compile (15.0.1) and runtime (16.0.1) classpath. You should manually set the same version via DependencyResolution

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 1s
Gradle task assembleDebug failed with exit code 1
Exited (sigterm)

Per google_maps_flutter pub package, the current version is 0.5.19. Can you confirm if that is the version in your pubspec.lock? If yes, please head directly over to flutter/flutter issues. Thanks!

the problem is that I was using google_maps_flutter (version didn't matter) but I was also trying to use location at the same time causing the above error.


Drug Profile Page

Current GraphQL schema. Using the drug query from the new endpoint should be enough to build an initial profile.

Epic ticket closed as alpha version of drug profile page complete


Not an ISSUE but a solution to all issues.

So yea I was so down for the past couple months trying to upgrade and update remnux but with no success.
What I did was re-read the installation guide "scratch".
If you guys use the Ubuntu Mini. And enable desktop

Ended up with a successful installation.

@wabass thanx, yeah i knew about that just wanted to avoid it. guess there was no avoiding it.
i can confirm that it works using this stock image. dont run any apt update/upgrade or it will not work.
https://releases.ubuntu.com/focal/ubuntu-20.04.6-desktop-amd64.iso

Cheers bud!

@Cr4wlerx Cheers bud!

@Cr4wlerx and @wabass , you both mention getting errors when installing with a different version of the 20.04 ISO. Any chance you might still have the error logs from those? I'd like to take a look and maybe find a solution that will work with all of the ISO's.


exclude non-Page/Article objects from keyword search results

Addresses #99

Ran multiple tests and the added functionality operates as expected.


How to load certain number of childs with FirebaseRecyclerViewAdapter

Ex: lets say GeoFire returns me 50 keys, i need to iterate the key list, how we can achieve this.
please help me out

Can you give a code sample of what you're trying to do and where you're having trouble (see http://stackoverflow.com/help/mcve)? I see no relation between FirebaseUI and Geofire, but might well be missing something crucial.

Hi @puf  i want to load the data depending on the location.
Ex: hotels
how we can achieve with FirebaseRecyclerViewAdapter ?

Geofire is a library on top of Firebase. It fires its own events when keys enter and exit from the range that you query for. FirebaseUI does not respond to these events.
So you'll have to create your own adapter class that does the same as FirebaseRecyclerViewAdapter, but then for Geofire events. When key_entered fires you add the item to the underlying array, when key_exited fires you remove the item from the array and when key_moved fires you move it to its (potentially) new spot in the array.
https://github.com/firebase/geofire-js#geoqueryoneventtype-callback

@puf  thanks done :+1:


Draw labels name

Draw labels name next to corresponding bounding boxes when the mapping of id to names is specified.
 I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Hi, the community has passed to vote about associating the code changes with JIRA<EMAIL_ADDRESS>We have updated the guidelines for contributors in https://cwiki.apache.org/confluence/display/MXNET/Development+Process, please ensure that you have created a JIRA at https://issues.apache.org/jira/projects/MXNET/issues/ to describe your work in this pull request and include the JIRA title in your PR as [MXNET-xxxx] your title where MXNET-xxxx is the JIRA id
Thanks!

@lvaleriu ping. Could you do a rebase?

Yes!

@lvaleriu rebounce: can you please do a rebase?

@lvaleriu looks like you have sanity test failing: RAT (licensing) and lint - kindly take a look at the Jenkins output.
@marcoabreu any guidance you can provide about RAT check failing?

@lvaleriu bouncing - you have sanity test failing: RAT (licensing) and lint - kindly take a look at the Jenkins output.

I'm still trying to understand what is the RAT licensing thing.

@lvaleriu please remove the c++ files, they are no longer required by SSD networks. And by doing this, you are free from the RAT license issue.

Hope this will do it!
@zhreshold Thanks!

Resolved, thanks for contribution @lvaleriu


Stuck on black screen

Describe your bug here.
So whenever i open psych engine every single time its stuck on a black screen with the fps and memory in the corner
it does this on every single mod that uses psych engine, earlier versions too.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
no

nevermind its unrelated to psych engine issues


No consistent value ordering for composite requests

Version(s)
all
Which components
leshan core
Tested With
Leshan demo client / our internal client
What happened
Situation
We've discovered an edge case  problem in the way how Eclipse Leshan implements the values for composite operations, most notably composite writes.
First of all, let's take a precise look at the LWM2M 1.1 spec to table 7.4.5 on page 83: We see that the SenML-JSON here uses an Array. Arrays are an  ordered data structure. It would be fantastic if we had a chance to control the orders in the resulting SENML-JSON / CBOR.
Why it currently does not work
To create a WriteCompositeRequest in Leshan, the values are passed as a general map (which is unordered):
 public WriteCompositeRequest(ContentFormat contentFormat, Map<String, Object> values) {

Internally, Leshan then takes the value map (which theoretically could have an order, for example if one uses a SortedMap or similar) and pushes the map entries to a HashMap. At this time, any order would be lost. In effect, there  is no way to define the order
Why this is a only a smaller problem
Arguably, any client that expects entries to have a certain order in SenML-JSON is a poor implementation.
See LWM2M spec section 6.3.9:

The "Write-Composite" operation is atomic and cannot have partial success. That is, if the client supports this
operation, it MUST reject a Server request where it cannot successfully write all the requested values to the requested
list of Resources. Therefore, before processing Write-Composite, the client MUST ensure that all addressed objects exist
and that the Server has write access to those Objects and Resources

Still, to be on the safe side, it would be fantastic if there was a way to control the order...
How to reproduce
Create a WriteComposite operation and observe the order of values in SenML
Relevant Output
No response

Could you explain a bit more why order is important ?
I get that this is about client implementation but I'm curious to better understand this "client bug" ? :thinking:

@sbernard31 We are seeing this issue in an override sequence which goes something like

Set Override timer
Turn Light On
Set Light Brightness.

It's a sequence where 2 is dependent on 1 and 3 is dependent on 2.
We can of course do this in 3 separate writes, waiting for the acknowledges etc, but if we could do this with an ordered compound write, it would simplify it and be far faster, especially in a slow network.
Obviously we can add custom code which handles a compound write with these 3 attributes and executes them in the correct order, but in general it would be better if we could rely on the order of the commands in the compound write.
The issue really is that the LwM2M Spec doesn't indicate that the order of the writes is respected.

It's a sequence where 2 is dependent on 1 and 3 is dependent on 2.

I'm not sure to get what means "override timer"
But for "turn light on" and "set light brightness", I'm not sure to see why order should be critical. :thinking:
At first sight, that's really looks like client implementation issue. (Maybe a good idea to try to also fix client at mid/long term ?)

The issue really is that the LwM2M Spec doesn't indicate that the order of the writes is respected.

Maybe I missed something but I can not see why this would be a specification issue.
Currently, I think is not wrong to state that Write Composite Operation should be considered as atomic.
It  makes sense with Write Composite using CoAP iPatch which is idempotent.
Not sure, but I guess your client should not like too much that you execute those WriteCompositeRequest twice if order is important ? (so not really idempotent)

Obviously we can add custom code which handles a compound write with these 3 attributes and executes them in the correct order, but in general it would be better if we could rely on the order of the commands in the compound write.

Generally, I prefer letting user being able to provide custom code for their out of spec use case. (see Real Life is about dealing with non-compliant foreign peer behavior.)
But here a solution could be that we use LinkedHashMap  instead of HashMap in WriteCompositeRequest.
This would at cost  of  2 additional object reference by maps entry : 2 x 32 bits or 64 bits (depends of JVM)  by entry.
This would only keep order in WriteCompositeRequest then no guarantee that decoder/encoder will respect it.
If we don't want to pay that cost, another solution would be to provide, a protected constructor in WriteCompositeRequest which allow you to create a OrderedWriteCompositeRequest using whatever map you want internally.
Oh I also just see that if you use this constructor : WriteCompositeRequest.WriteCompositeRequest(ContentFormat, Map<LwM2mPath, LwM2mNode>, Object) order should be respected. (If I read the code correctly)
Let me know your opinion about that :pray:

We can of course do this in 3 separate writes, waiting for the acknowledges etc, but if we could do this with an ordered compound write, it would simplify it and be far faster, especially in a slow network.

Do you have numbers about how this will really impact in real world.
Keep free to give real numbers because in call cases (even if number seems very low) we will try to find a solution for you use case.
I just try to have a better vision of real world.

Re: Maybe I missed something but I can not see why this would be a specification issue.
My point here is that because there is no mention of order of compound writes being respected in the spec, there is no onus on anyone to implement it that way, so in general one could not rely on that.
The fact that compound commands are atomic is great, and I guess that's the whole point of compound commands, but I think it would be more powerful if the order of commands was respected too.
As regards numbers on timing, Cat-NB has a maximum latency of 10 seconds, so sending 3 commands and waiting for acknowledges would take up to 60 seconds, versus 20 seconds, which might not seem a lot, but it becomes important when there is scale involved.
Regarding running the commands twice, that might work, but it might take 3 times to satisfy the dependencies.
Thanks for your consideration. I think we have the answers we need.

As regards numbers on timing, Cat-NB has a maximum latency of 10 seconds, so sending 3 commands and waiting for acknowledges would take up to 60 seconds, versus 20 seconds, which might not seem a lot, but it becomes important when there is scale involved.

Thx that's really help me to better understand this kind of use case.

Regarding running the commands twice, that might work, but it might take 3 times to satisfy the dependencies.

An idempotent function should have same result if it is applied 1 or several time.
In that case, if you send it 1 or 2 times, the state of the client should be the same.
So, Regarding your answer, I understand the implementation is not idempotent.
(But I agree, this is very theoretically and I can understand that some implementation doesn't full respect that)

Thanks for your consideration. I think we have the answers we need.

That means that using WriteCompositeRequest.WriteCompositeRequest(ContentFormat, Map<LwM2mPath, LwM2mNode>, Object)  works for you ?
If yes, let me know.
If you think this would be better to introduce LinkedHashMap for the other constructor let me know too.
I wait for you confirmation before to close the issue.
Thx for taking time to share your issue, all feedback are welcome.

Thanks Simon. I think we can close the issue.
We need to work with the situation where the order is not determinate.

You're welcome. :slightly_smiling_face:
Do not hesitate to reopen if needed.


Running vim produces a strange row of text at the top.

[X] I am on the latest Hyper.app version
[X] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: macOS 10.12.6
Hyper.app version: 1.4.7

Issue

Running vim produces a strange top bar of random text within hyper. Doesn't happen in other terminal applications.

Could you give me more details to reproduce the error :)

Sure thing.
I simply cd into a folder and run vim <filename>.js
The vim plugin called vim-airline is installed.
Update: Really strange but I am unable to reproduce the error (the top bar is no longer showing up.

I don't think you meant to close this. Also I've run into this as well.

Feel free to open it back up.
I simply closed it because I thought it was a one-off type of an error. But if you're having it too, it's best to keep the issue open.

Same as #1037? I've been having this issue for a while.

Yes, let's close this one then.


Issues with accessing CombinatorialDerivation value

@JMante1 and I have been working on reading through the CombinatorialDerivations of an SBOL3 file, and ran into a slight issue. We tried to access the value as a dictionary, as was the case when working with SBOL2, but received a list of URIs instead. For example:
for c in doc.objects:
     for prop in c.properties:
          print(c.properties)

This is the example result over the first iteration of properties:
['http://sbols.org/v3#displayId', 'http://sbols.org/v3#name', 'http://sbols.org/v3#description', 'http://www.w3.org/ns/prov#wasDerivedFrom', 'http://www.w3.org/ns/prov#wasGeneratedBy', 'http://www.w3.org/1999/02/22-rdf-syntax-ns#type', 'http://sbols.org/v3#hasNamespace', 'http://sbols.org/v3#hasAttachment', 'http://sbols.org/v3#strategy', 'http://sbols.org/v3#template']

We were wondering how we could access the actual value of the CombinatorialDerivation, and were also wondering if other parts of the SBOL3 document had a specific way in which to be accessed.

Just a clarification:
We would like to iterate over the properties of objects in sbol. In pysbol2 this seems possible by calling the object.properties dictionary. However in pysbol3 the object.properites appears to just be list and be absent from combinatorialderivation objects.

You can get this information by accessing _properties, but as you can see from its name that it not a recommended approach when others will work.
If you're doing what I think you are, however, in attempting to serialize an arbitrary SBOL object into Excel, then I suspect that is actually a reasonable approach to take.

My initial suggestion is to access the properties of the CominatorialDerivation through the front door, using the appropriate accessors. This way the library will handle various things for you.
cd = sbol3.CominatorialDerivation(<ARGUMENTS HERE>)
cd.strategy
cd.template
cd.variable_features

cd.properties is a list of properties, as you have found out. It is not a dict as it is in pySBOL2. The .properties accessor on pySBOL3 objects is only a partial list and does not include any SBOL3 properties that contain child objects (depicted with a filled diamond in the SBOL3 specification).
If you choose to use cd._properties, beware that you will be using internal data structures and may have to do type conversions and lookups to find the information that you want or need. That's an example of the kind of thing the library does for you if you use the "front door" property accessors.

However in pysbol3 the object.properites appears to just be list and be absent from combinatorialderivation objects.

.properties should not be absent from CombinatorialDerivation. If that's the case, can you send an example that will help me reproduce it? I see .properties on CombinatorialDerivation.
>>> import sbol3
>>> cd = sbol3.CombinatorialDerivation('http://example.com/cd1', 'http://example.com/c1')
>>> cd.properties
['http://sbols.org/v3#displayId', 'http://sbols.org/v3#name', 'http://sbols.org/v3#description', 'http://www.w3.org/ns/prov#wasDerivedFrom', 'http://www.w3.org/ns/prov#wasGeneratedBy', 'http://www.w3.org/1999/02/22-rdf-syntax-ns#type', 'http://sbols.org/v3#hasNamespace', 'http://sbols.org/v3#hasAttachment', 'http://sbols.org/v3#strategy', 'http://sbols.org/v3#template']

Note that this list is missing http://sbols.org/v3#hasMeasure and http://sbols.org/v3#hasVariableFeature because these are SBOL3 properties that hold child objects.
Also note that the visitor pattern might work for you. See https://pysbol3.readthedocs.io/en/v1.0b10/visitor.html for more information.

As Jake surmised we want to iterate over all properties for conversion to an excel template. We could do this using the code below so as to use the accessors and still be able to access an arbitrary list of properties.  However, we would then miss the child object properties. To get the full list we could then do some kind of difference with the properties found and the _properties list?
for prop in obj.properties:
    prop_val = obj.get(prop)

@abamaj can you provide the file which you were using when the combinatorial derivation wasn't giving any properties?

Would it be better to work in triple space in RDFLib rather than in SBOL3? You could iterate over the triples of an object there, entering information into Excel. This would be a "front door" approach. You can get an RDFLib graph from a document, then run SPARQL queries on it or access various triples programatically. pySBOL3 does this when loading a document from file or string.

As Jake surmised we want to iterate over all properties for conversion to an excel template. We could do this using the code below so as to use the accessors and still be able to access an arbitrary list of properties. However, we would then miss the child object properties. To get the full list we could then do some kind of difference with the properties found and the _properties list?
for prop in obj.properties:
    prop_val = obj.get(prop)

@abamaj can you provide the file which you were using when the combinatorial derivation wasn't giving any properties?

@JMante1
@jakebeal
@tcmitchell
Yes, here is the file that I used: https://github.com/SynBioDex/pySBOL3/blob/main/test/resources/simple_library.nt

Thanks @abamaj for posting the file. I used it below to demonstrate that I can access the properties attribute of a combinatorial derivation. I'm doing some recap here because I don't know where things stand for the two of you.
@JMante1 said:

However in pysbol3 the object.properites appears to just be list and be absent from combinatorialderivation objects.

As I've said above, in pySBOL3 object.properties is a list. And that holds for all objects that derive from Identified in the SBOL3 specification. CombinatorialDerivation objects are included. I don't have any trouble accessing the properties list of a combinatorial derivation in https://github.com/SynBioDex/pySBOL3/blob/main/test/resources/simple_library.nt:
>>> import sbol3
>>> doc = sbol3.Document()
>>> doc.read('test/resources/simple_library.nt')
>>> len(doc)
67
>>> cd1 = doc.find('http://sbolstandard.org/testfiles/FPs_small')
>>> isinstance(cd1, sbol3.CombinatorialDerivation)
True
>>> cd1.properties
['http://sbols.org/v3#displayId', 'http://sbols.org/v3#name', 'http://sbols.org/v3#description', 'http://www.w3.org/ns/prov#wasDerivedFrom', 'http://www.w3.org/ns/prov#wasGeneratedBy', 'http://www.w3.org/1999/02/22-rdf-syntax-ns#type', 'http://sbols.org/v3#hasNamespace', 'http://sbols.org/v3#hasAttachment', 'http://sbols.org/v3#strategy', 'http://sbols.org/v3#template']

The code example listed by @JMante1 above was:
for prop in obj.properties:
    prop_val = obj.get(prop)

That code doesn't work because there is no get method defined on the SBOL3 objects. Here's what happens if I continue my example above to use the given code:
>>> obj = cd1
>>> for prop in obj.properties:
...     prop_val = obj.get(prop)
...
Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
  File "/Users/tmitchel/Projects/sd2/pySBOL3/sbol3/object.py", line 33, in __getattribute__
    result = super().__getattribute__(name)
AttributeError: 'CombinatorialDerivation' object has no attribute 'get'

Neither of you have responded to my suggestion to work in triple space in RDFLib. Have you considered that?
Or identify the object as a combinatorial derivation and operate on it as such using the provided accessors?
>>> cd1.variable_features
[<sbol3.varcomp.VariableFeature object at 0x7f82d06bceb0>]
>>>
>>> cd1.template
'http://sbolstandard.org/testfiles/FPs_small_template'
>>> cd1.template.lookup()
<sbol3.component.Component object at 0x7f82e02cfaf0>

Thank you Tom for this information. After continued testing with SBOL3, @JMante1 and I realized that we will have to work in triple space in RDFLib, as it is more scalable. We will continue to update you with our progress.

I'm assuming you're all set on this issue since there hasn't been any new activity in 2 months. If anything else crops up please either reopen this issue or open a new issue. I hope everything is going well on your project.

I'm assuming you're all set on this issue since there hasn't been any new activity in 2 months. If anything else crops up please either reopen this issue or open a new issue. I hope everything is going well on your project.

Yes! The information you provided @JMante1 and I regarding RDFLib was extremely helpful. Thank you very much.


Update minimum versions for pip packages

Required to resolve some security vulnerabilities in the smart agent.

You can probably remove tests for py 2.6 if you can't figure out how to fix them easily.

You can probably remove tests for py 2.6 if you can't figure out how to fix them easily.

@rmfitzpatrick believes this is a circleci issue. I can take a look to see if 2.6 can be excluded/skipped when running in circleci.

Remembered that it's not a circle issue, but a breaking update in themattrix/tox.  We would likely need to roll our own based on a working commit.  Removing 2.6 runs from circle seems acceptable.


Sm/qa-oclif-oclif-qq

What does this PR do?
qa for new tarball build without qq
uses beta release from https://github.com/oclif/oclif/actions/runs/3578722086/jobs/6019192371
https://github.com/oclif/oclif/pull/1035
a good run is here: https://github.com/salesforcecli/sfdx-cli/actions/runs/3579646358/jobs/6021385250 [note: I also switched the tarball machine to be an 8-core ubuntu to take advantage of the parallelization for both tarballs and smoke test).
I also had to make one change to the pretarball calls for cwd.
What issues does this PR fix or reference?

oclif beta is now on https://github.com/salesforcecli/sfdx-cli/pull/787


Typos in tutorial

@jluk,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


add more tests in physical app

Codecov Report

Merging #636 (204e155) into master (4807f49) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
+ Coverage   42.39%   42.40%   +0.01%
==========================================
  Files         330      330
  Lines       23311    23311
==========================================
+ Hits         9882     9886       +4
+ Misses      13429    13425       -4

Flag
Coverage Δ

unittests
42.40% <ø> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

dbaas/physical/models.py
75.21% <0.00%> (+0.48%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4807f49...204e155. Read the comment docs.


searching flakes and everything what flakes expose

Currently most of packages/options are in nixpkgs. While discoverability is not great it was good enough for developers who just grepped the repo. One of the bigger reasons why everything is in one repo is that it is not easy for somebody - especially newcomer to nix - to combine multiple repositories with nix packages.
With flakes this will change since the basic unit that we will have is a flake. While nixpkgs is still going to be the repository with the biggest set of packages, we might also see other repositories showing up (eg. like NUR repository).
First step would be to do some UI wireframes and define what are the main user stories that we will optimize UI for.

closing this in favor of #125 (didn't know we already have this issue there)

Right now the NUR flake exposes the nur attribute as an overlay. This does not make it easy to index packages in our repositories though. It is feasible to add all repositories to the packages output as well however there might be problems with the standard nix tooling that does not support nested attributes under packages i.e. nur.packages.mic92.cntr, when searching for it.


could not resolve support-v4

When including version 1.0.3 as a dependency from maven central using gradle,
the build fails due to the following error:
"Could not resolve all dependencies"
"Could not find com.google.android:support-v4:r13"
and it seems that the latest version of support-v4 on maven central is actually r7..

I am also having a similar issue. I get the message:
A problem occurred configuring project ':app'.  Artifact 'compatibility-v4.jar (android.support:compatibility-v4:21.0.1)' not found.
Searched in the following locations:
https://jitpack.io/android/support/compatibility-v4/21.0.1/compatibility-v4-21.0.1.jar
I tried excluding the group like pkliang said but it doesn't help.

are you using the maven android SDK deployer, as described in the readme?

I am pretty new to android and am using gradle with compile com.fizz-buzz:fb-android-dagger:1.0.6'. I don't really know what I need to add to my build.gradle. The readme really only says that the project uses the Maven Android SDK Deployer, not what you need to do with it. Do I need to do a mvn install on the SDK Deployer source to build the jar file? I tried that and got some errors. I wasn't sure if it was worth looking into them if that step wasn't needed.

The link to the maven android SDK deployer provides instructions (pretty lengthy ones at that, but you were on the right track with "mvn install").  By default, it tries to install pretty much everything available in the SDK.  If you haven't installed everything via the SDK Manager, then it will trip over things that are missing.  You can follow the instructions to only install certain parts, but I confess I find that more tedious and error-prone than just making sure I have everything installed first using SDK Manager, and then doing an "mvn install" on the maven android SDK deployer.
That being said, fb-android-dagger only depends on compatibility-v4, so technically that's all you need to have installed in your maven repo.

adennie, I installed everything via the SDK manager and was able to mvn install the Android SDK Delpoyer successfully. What jar file should i include in my libs folder? compatibility-v4-21.0.1.jar? That is the one that gradle is complaining about.  Thanks.

I don't think you should have to copy it into your libs folder. Have you
done an "mvn install" on fb-android-dagger? If so, then it should be in
your local maven repo (along with v4 compatibility lib). If you're
specifying a dependency on fb-android-dagger in your gradle build file,
it should find it in your maven repo, and also resolve its dependency on
the v4 compatibility lib.
enantiomer2000 wrote:

adennie, I installed everything via the SDK manager and was able to
mvn install the Android SDK Delpoyer successfully. What jar file
should i include in my libs folder? compatibility-v4-21.0.1.jar? That
is the one that gradle is complaining about. Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/adennie/fb-android-dagger/issues/6#issuecomment-88270568.

adennie, I am able to build it from the latest github source. This source version is 1.0.7-SNAPSHOT and seems to be dependent on compatibility-v4 version 22.0.0 rather than 21.0.1. My system has version 22. On the other hand, 1.0.7 doesn't seem to be officially released yet so I guess I can't link to it via my gradle.build file. I will try manually adding the SNAPSHOT jar file and the compatibility-v4-22.0.0.jar file to my libs folder and see if that works...

to build the 1.0.6 version, just checkout that tag first, and then do
the "mvn install".
enantiomer2000 wrote:

adennie, I am able to build it from the latest github source. This
source version is 1.0.7-SNAPSHOT and seems to be dependent on
compatibility-v4 version 22.0.0 rather than 21.0.1. My system has
version 22. On the other hand, 1.0.7 doesn't seem to be officially
released yet so I guess I can't link to it via my gradle.build file. I
will try manually adding the SNAPSHOT jar file and the
compatibility-v4-22.0.0.jar file to my libs folder and see if that
works...
—
Reply to this email directly or view it on GitHub
https://github.com/adennie/fb-android-dagger/issues/6#issuecomment-88283478.


Make a dashboard page

Display amount of replays uploaded in last month (by game date) - our goal is to reach hotslogs level in this stat. Display total and HL.
Display top 10 uploaders (by last month games), this may incentivize some players to upload more.

 qwe


Mistake in Fibonacci Closure on the main page

Sequence should start from 0, not from 1.
func fib() func() int {
a, b := 0, 1
return func() (r int) {
r = a
a, b = b, a+b
return
}
}

It's fine either way
http://mathworld.wolfram.com/FibonacciNumber.html
closing this.


Remove handler

Remove handler
The handler has caused additional complexity with multiple levels of
indirection.
Remove the ABC and include the free functions in an "interface" module.
The main app and cli tests are rewritten to look more like unit tests.
This PR is to be followed up by further refactoring to replace the
singleton class with cached functions and restructuring the modules.
Fixes #434.

Had a play locally, when I reload the environment it doesn't appear to import new changes.


Harfbuzz warning loop variable '_' is always a copy

Seeing this failure on presubmit on an unrelated PR:
In file included from ../../third_party/harfbuzz/src/hb-subset.cc:35:
../../third_party/harfbuzz/src/hb-ot-hdmx-table.hh:110:40: warning: loop variable '_' is always a copy because the range of type 'hb_map_iter_t<hb_range_iter_t<unsigned int, unsigned int>, (lambda at ../../third_party/harfbuzz/src/hb-ot-hdmx-table.hh:126:15), hb_function_sortedness_t::NOT_SORTED, nullptr>' does not return a reference [-Wrange-loop-analysis]
    for (const hb_item_type<Iterator>& _ : +it)

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8830924246644624817/+/u/build_ios_debug_sim_arm64/stdout
I'm not sure what changed on the builder, do we need to disable range-loop-analysis warning in the GN build rules? Or cherry pick in harfbuzz/harfbuzz@86993c0?

I know there was a harfbuzz roll but that was weeks ago. You're right that we need to disable loop range analysis but I can't tell why you are running into this issue now. Perhaps a ToT rebase is in order?

Nevermind, that PR is pretty close to ToT today :/

Very weird, none of the other PRs from today are hitting this error.  Maybe it's a cache error?  Rebasing and running again.

cc @godofredoc may have thoughts on this perhaps.

The test succeeded on a re-run.

We looked at this code in detail in triage and we can't tell how a unary add to an iterator would even be legal. It is templated so, perhaps thats how the compiler is letting go of it? But it seems like a bug. Seems like a special iterator type that is specific to HB. Per @jason-simmons reading of the code, it seems intentional on the code authors part but it is certainly weird.
Since this was a weird LUCI one-of and since it is not actionable, I am closing this. We can reopen if this keeps happening.


Black Artifacts With Omni Light Present In Scene

Tested versions

Reproducible in v4.2.2.stable.official [15073afe3], v4.0.stable.official [92bee43ad], and v4.3.dev6.official [89850d553]
Does not occur in v3.5.3.stable.official [6c814135b]

System information
Godot v4.2.2.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated AMD Radeon RX 7800 XT (Advanced Micro Devices, Inc.; 31.0.24031.5001) - AMD Ryzen 5 7600X 6-Core Processor (12 Threads)
Issue description
Black artifacts flicker in and out as the camera moves. They appear on meshes illuminated by a light, particularly on larger flat surfaces. They appear both in-editor and in-game.
https://github.com/godotengine/godot/assets/48959058/4a2e16cd-046c-4ed8-9e03-612d32b92ca4
Additional Notes:

This issue only occurs on my desktop (the specs reported) and did not occur when testing using the same project on my laptop
The issue only occurs in the Forward+ renderer
The issue appears to be focused around the edges between faces. It becomes more noticeable with more subdivisions (the plane in the video has 50x40 subdivisions) but it is still present along the diagonal on an unsubdivided plane
The issue only occurs when the camera is outside the range of the light
My graphics drivers are up to date. All Godot project settings are at default

Steps to reproduce
The issue is visible in Test.tscn in the MRP.
It is also visible from a new project by following the below steps:

Create a new 3D scene
Add a MeshInstance3D and an OmniLight
Assign a new plane mesh to the MeshInstance3D, rotate it 90 degrees in the x-axis and move it along the z-axis such that the OmniLight illuminates it
Zoom out such that the camera is not within the range of the OmniLight and rotate the view
This causes the artifacts to appear on my PC. The issue can be made more visible by increasing the subdivisions of the plane mesh

Minimal reproduction project (MRP)
Light Issue Test.zip

Try running this on your IGPU on the processor and/or DX12, it's RDNA2, while the DGPU is RDNA3, and it might be an RDNA3 issue, as I distinctly remember hearing someone reputable (MLID IIRC) state that one of the Reasons why the Actual uplifts of RDNA3 were less then advertised pre launch was black corruption artifacts appearing in some scenarios, and ended up that the only way to resolve it was to add a delay to sth in the drivers.. Might be that the delay is somehow bypassed by the Vulkan Forward+ renderer
If the IGPU is running fine, and it only appears on RDNA3 GPUs, you should send AMD a bug report using Adrenaline Software, and give them this Github issue.
And eh, who knows, maybe, just maybe if it is the issue they've had pre-RDNA3-launch, given this is quite the minimal MRP for the issue it might help them find a better solution and claw back some of the performance they've lost with their current solution that reportedly made them fall short of pre-launch marketing numbers
For what it's worth, on an RX6600 on my machine I'm unable to reproduce this issue, and I expect the same will be true for your IGPU. Question is Intel Arc and Nvidia cards and older AMD cards (such as Polaris, Vega, RDNA1), and it'll likely be the answer is no if what I stated at the top is accurate and is indeed what you bumped into.

The issue appears to be focused around the edges between faces. It becomes more noticeable with more subdivisions (the plane in the video has 50x40 subdivisions) but it is still present along the diagonal on an unsubdivided plane

I wonder if this is due to the same cause as https://github.com/godotengine/godot/issues/62073.

wouldn't that then effect me too?

@mrjustaguy
Thank you for the detailed response.
Running the project on my integrated GPU (monitor physically connected to integrated GPU, integrated GPU memory displayed in use in Task Manager) doesn't seem to fix the issue. However, it also freezes Godot completely so I am unable to test thoroughly. For reference, my integrated GPU is also AMD (listed as AMD Radeon(TM) Graphics in Device Manager).
How would I run Godot using DX12? I see from the release notes of 4.3 Dev Snapshot 3 that I need to download a .dll file. I have done that but am unsure how to then activate DX12 support within Godot as I have been unable to find any tutorial or documentation for the process.
Further, would there be any downsides feature- or compatibility-wise for development or builds to switching to DX12 instead of Vulkan?

Update: With some trial and error, I figure it out and switching to DX12 does indeed resolve the issue.
For anyone else who is trying to switch, here's what I did:

Download the DirectX Shader Compiler from this link: https://github.com/Microsoft/DirectXShaderCompiler/releases
Copy the .dll for your platform (it was x64 for me) from the bin folder of the downloaded .zip and paste it in the same folder as your Godot executable
In Project Settings, make sure Advanced Settings is enabled and change Rendering->Rendering Device->Driver.windows to d3d12

I would still appreciate clarification however on what the effects of this change will be. Will I lose access to any features or be unable to export for specific platforms? I would prefer to know in advance before I commit to developing a project using it.
Thank you very much for the help.

I would still appreciate clarification however on what the effects of this change will be. Will I lose access to any features or be unable to export for specific platforms? I would prefer to know in advance before I commit to developing a project using it.

All features should be working on D3D12 (barring bugs that haven't been discovered yet) and the change only affects Windows, so it won't affect your ability to export to various platforms.

This sounds like a good solution then. Thank you for the help. I'll make sure to report any D2D12 bugs I encounter.

well if the IGPU is having the same issue the RDNA3 hypothesis can be scratched off, it is however weird that I am unable to reproduce it, on an RX 6600 with the latest drivers, as it's the same architecture as the IGPU.

My test wasn't very thorough due to Godot freezing when run on the IGPU. For reference, here's what I did:

Launch the MRP on my dedicated GPU
Place the scene camera such that the artifacts are visible
Save the scene
Close Godot and switch to the IGPU
Launch Godot again
At this point, Godot is completely frozen but the artifacts are still visible

Godot v4.3.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated AMD Radeon RX 7900 XTX (Advanced Micro Devices, Inc.; 31.0.24033.1003) - AMD Ryzen 7 7800X3D 8-Core Processor (16 Threads)
https://github.com/user-attachments/assets/7d7107ea-bdf0-4b1c-9489-859e14e940ec
This is happening to me on 4.3 stable.  It gets way more noticeable with a lower resolution.
This doesn't happen on the D3D12 renderer.

I can confirm this is happening to me as well. AMD 7800 same as the others.
If I switch to using D3D12, does that mean my regular shaders are not going to work? I see a comment above about downloading a new shader compiler, is it going to be a slightly different shader language as well (because if so I might take a break from game dev until this is fixed)

@rosebrt: From my understanding, Godot shaders are compiled to whatever the backend is

They will be in the same shader language regardless of Vulkan/DX12, and the differences are really on the backend side of things that Godot is Handling.

I can't reproduce with:
Godot v4.3.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated AMD Radeon RX 6900 XT (Advanced Micro Devices, Inc.; 31.0.24019.1006) - AMD Ryzen 5 3600 6-Core Processor (12 Threads)
Trying with an updated driver right away


How to do "For now, let’s remove unnecessary files: $ rm -rf server client"?

This is in the first page in the WhatsApp tutorial whenever I put in "$ rm -rf server client" I get an error saying this is not an internal or external command. How would I fix this? Thanks!

Try the command without the $ sign ==> rm -rf server client

Hi i tried this without the dollar sign    rm -rf server client   but still got a message in command prompt saying.
C:\Windows\System32\whatsapp>rm -rf server client
'rm' is not recognized as an internal or external command,
operable program or batch file.


Change:

fixed eslint issue while building project;
.npm ignore added;
package.json update to correct urls;
cmd for building project is added (npm run build);

npm package update to this version.

Looks good.


Prevent creating locks for empty batches

Fixes #1
This PR changes the takeFirstN and takeLastN functions to only store a lock if there are items in the returned batch. This prevents empty batches from being taken and subsequently the locks never being released for them.

Published to 1.0.3. Thanks again!

Thanks for the quick response!


Set a shorter timeout for the initial connection attempt in proxy.

In case we try to connect to an outdated address that is no longer valid, the default behavior of Kubernetes is to drop the packets, causing us to wait for the entire timeout period. We want to fail fast in such cases.
A specific case to consider is when we have cached compute node information with a 5-minute TTL (Time To Live), but the user has executed a /suspend API call, resulting in the nonexistence of the compute node.
Related to #4617

few open items here:

separate settings for link auth? Or we can just disable cache for it
think of unifying connection code (and errors) with http endpoint

separate settings for link auth? Or we can just disable cache for it

Yes, not sure, but I think it's possible to hit 2s timeout for link auth with US->Asia connection. Mentioned disabling cache for it in #4617 too
But just disabling cache won't help, I guess? Due to the network latency it should be still possible to hit 2s timeout

Yes, not sure, but I think it's possible to hit 2s timeout for link auth with US->Asia connection. Mentioned disabling cache for it in https://github.com/neondatabase/neon/issues/4617 too
But just disabling cache won't help, I guess? Due to the network latency it should be still possible to hit 2s timeout

My point was that without cache this situation should not happen. But anyway we actually don't have cache in link auth, so I just did that 2s conditional only for console backend.

Do we need to apply this change to sql_over_http?

Do we need to apply this change to sql_over_http?

I'm looking into reusing the same code in sql_over_http. I think current state with copy-pasted implementation emerged after series of fixes (first it was just a rust-postgres connection, then we re-used cache, then added retries -- each time fixing something asap)

I'll submit fix for sql_over_http as a separate PR -- it is a bit trickier code with more opportunities to break stuff, would be easier to fix after https://github.com/neondatabase/neon/pull/4625
So let's merge this one


Add Joshwoo69's Random mods! from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of joshwoo69, to add Joshwoo69's Random mods! to CKAN.
Please direct questions about this pull request to joshwoo69.

Closed in favor of #2740


Hero component

Problem
As a prospective attendee,
I want to immediately pick up a vibe of what CruzHacks will be like this year upon landing on the website.
Link to Asana Ticket
Solution
Spooling up the finalized hero described in the mock here
Screenshots (optional):

@mocklee, this component looks insanely good! I am excited to finally see our mock-up come together!
I made some comments about slight design adjustments and structure pointers, but this looks really great overall!

@PriyaRajarathinam - Well, the screenshot above isn't really accurate, because the Mission section should be squeezed in between that (and the grid on Mission is right-aligned).
What I think is a better question is to see if we can fix the different grid sizes. The Milestones grid is really small and the Hero grid is much less dense.

Just a quick comment, again about the commit histories. This is a good example of why we want to keep them separate from one another. You've added a package.lock to this PR, which does not belong. Problem is, since you have the same commit history in #139 then it's double the work you have to do in order to clean up the PR's 😬

@PriyaRajarathinam - Well, the screenshot above isn't really accurate, because the Mission section should be squeezed in between that (and the grid on Mission is right-aligned).
What I think is a better question is to see if we can fix the different grid sizes. The Milestones grid is really small and the Hero grid is much less dense.

There's definitely room to make the grid in Mission more responsive with mobile breakpoints; it's worth keeping continuity with the design. I also agree that we should adjust the grid density in Milestones.. @w-gao do you have any time to sync up the grid sizing in your components with hero & mission?


Getting Response to preflight request doesn't pass access control check when using during development

I keep getting this error when trying to access your APIs while developing.
Access to XMLHttpRequest at 'https://api.exchangeratesapi.io/latest?base=MYR' from origin 'https://*.dev' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.

I am experiencing the same problem. Is it because the request is coming from a local/development domain ending with *.test?

@aimensasi not sure if you ever got this sorted out, but in my axios defaults I had this header:
Axios.defaults.headers.common['X-Requested-With'] = 'XMLHttpRequest';

Removing that fixed the issue. Apparently it causes the preflight. I have a lot more to learn about these http headers!

Ehm, CORS policy is problem in the backend, but I solved this in my own auth api by setting content type to text/plain instead of application/json

Thanks @swthate that worked for me

This issue is caused by the OPTIONS request that is sent by the browser. Please enable CORS for OPTIONS request, otherwise we cannot query this API by a lot of client side frameworks like Angular for example.


Licenses of modules

Hi,
Can you please let me know the license of the file, 'https://github.com/circe/circe/blob/series/0.14.x/modules/numbers/shared/src/main/scala/io/circe/numbers/BiggerDecimal.scala'?

https://github.com/circe/circe/blob/series/0.14.x/LICENSE


Sort into sections

Current dependencies on/for this PR:

main

PR #275   👈

This comment was auto-generated by Graphite.


Replace arrow picture with CSS

Menu on the left uses an image for the active menu entry:

We could use CSS to achieve the same effect, removing the need for an extra image and HTTP request. Plus, it's more elegant.
Example: add a <div> to the active <li> element, with this CSS:
    width: 0;
    height: 0;
    border-top: 13px solid transparent;
    border-bottom: 13px solid transparent;
    border-right: 15px solid white;
    position: absolute;
    right: 0px;
    top: 3px;
    z-index: 1;

Other suggestion: simply replace the PNG with an inline SVG for the active <li>:
background-image: url("data:image/svg+xml,%3Csvg width='13px' height='25px' viewBox='0 0 50 100' xmlns='http://www.w3.org/2000/svg'%3E%3Cpolygon points='0,50 50,0 50,100' fill='white' stroke='none'/%3E%3C/svg%3E");


How to build

Hey, cool project.
I wanted to write nix expressions for this but it's not clear to me how it's supposed to be built.

I'm using qmake for build the project from Qt6.6.2:
/home/mh4x0f/Qt/6.6.2/gcc_64/bin/qmake /home/mh4x0f/git/zmkBATx/zmkBATx.pro -spec linux-g++ CONFIG+=qtquickcompiler && /usr/bin/make qmake_all

make -j8 in /home/mh4x0f/git/zmkBATx

the qt requires somes libraries then you can get on release .tar.gz file.

In general (modulo some workarounds) it's not possible running pre-built binaries in NixOS, and its philosophy is more about re-building everything more sources.
I've packaged it, here the PR.
If you have nix installed you can already try to build it with nix (and then start it) using:
nix run github:aciceri/nixpkgs/zmkbatx#zmkBATx

If you want I can add a reference to the fact that it's packged in nipxkgs in the README (after the PR is merged).
Anyway it works great anyway!

yeah, nice job brow. send me a PR after merge on nix package.


Openpredict no results Workflow A.5

https://arax.ncats.io/?source=ARS&id=df3f226a-571a-4219-ba5e-a37b7040ee18
No predicates or categories, CURIE on subject

{
  "message": {
    "knowledge_graph": {
      "edges": {},
      "nodes": {}
    },
    "query_graph": {
      "edges": {
        "e01": {
          "object": "n1",
          "subject": "n0"
        }
      },
      "nodes": {
        "n0": {
          "categories": [
            "biolink:Gene"
          ],
          "ids": [
            "NCBIGene:23221"
          ]
        },
        "n1": {}
      }
    },
    "results": []
  },
  "validation_result": {
    "message": "",
    "n_edges": 0,
    "n_nodes": 0,
    "size": "0.88 kB",
    "status": "PASS",
    "version": "1.1.1"
  }
}

Vicki has an update to add here

OpenPredict contains predictions of drug-disease associations, so we don't expect to get results when asking for genes
Is there anything we need to do?

Closing.


fsautocomplete: 0.73.2 -> 0.74.1

Description of changes
There are no straight roads in dotnet/F# wonderland, however I finally managed to establish a semi-automated reproducible update scenario with this package.
Need to do a cleanup and maybe discuss some of the hacks with nixos/dotnet team.
Should fix #340194 once completed

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Superseded by https://github.com/NixOS/nixpkgs/pull/360986


Condition for uploading codacy report action is incorrect

It is possible that the condition for uploading the codacy report is not working correctly?
It seems that the latest action runs always skip the upload step: https://github.com/dfetch-org/dfetch/actions/runs/7126301482/job/19403900008
Code
        env:
          secrets.CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }}
        if: "${{ (!!env.CODACY_PROJECT_TOKEN) }}"

https://github.com/dfetch-org/dfetch/blob/3f55e9d173fa7413e4a11000e957af082bc189d4/.github/workflows/test.yml#L45C12-L45C12
I think that the env variable should drop the secret. prefix.
        env:
          CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }}
        if: "${{ (!!env.CODACY_PROJECT_TOKEN) }}"

Fixed by #559


new tear gas sprite

About the PR

tear gas isnt in the same perspective as other grenades
Why / Balance

kinda bothered me, so i decided to make a new sprite in GIMP that matches the perspective as the other grenades (if anything is wrong im sorry,)
Technical details

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

hopefully i didnt leave any mistakes

At least center it fam.

Needs in game screenshots side by side with other grenades.


Add Integration tests on TravisCI

It is not possible to run minikube on Travis CI but https://github.com/Mirantis/kubeadm-dind-cluster should be able to do so. At least they state it ;)

We now have minikube running on Travis.


sunrise-sunset returns string not parseble by Circadian in Germany

When running this very snipped (with calendar-latitude/longitude set)
(setq circadian-themes '((:sunrise . whiteboard)
                         (:sunset . tsdh-dark)))
(circadian-setup)

I recieve the following error:
Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
  replace-regexp-in-string(".m" "" nil)
  circadian-clear-12h-postfix(nil)
  circadian-parse-time-string("Wed")
  circadian-match-sun(:sunrise)
  circadian-mapc((:sunrise . whiteboard))
  mapc(circadian-mapc ((:sunrise . whiteboard) (:sunset . tsdh-dark)))
  circadian-setup()
  (progn (setq circadian-themes (quote ((:sunrise . whiteboard) (:sunset . tsdh-dark)))) (circadian-setup))
  (condition-case err (progn (setq circadian-themes (quote ((:sunrise . whiteboard) (:sunset . tsdh-dark)))) (circadian-setup)) ((debug error) (ignore (display-warning (quote use-package) (format "%s %s: %s" "circadian" ":config" (error-message-string err)) :error))))
  (if (not (require (quote circadian) nil (quote t))) (ignore (message (format "Cannot load %s" (quote circadian)))) (condition-case err (progn (setq circadian-themes (quote ((:sunrise . whiteboard) (:sunset . tsdh-dark)))) (circadian-setup)) ((debug error) (ignore (display-warning (quote use-package) (format "%s %s: %s" "circadian" ":config" (error-message-string err)) :error)))) t)
  (progn (use-package-ensure-elpa (quote circadian) (quote t) (quote nil) :ensure) (if (not (require (quote circadian) nil (quote t))) (ignore (message (format "Cannot load %s" (quote circadian)))) (condition-case err (progn (setq circadian-themes (quote ((:sunrise . whiteboard) (:sunset . tsdh-dark)))) (circadian-setup)) ((debug error) (ignore (display-warning (quote use-package) (format "%s %s: %s" "circadian" ":config" (error-message-string err)) :error)))) t))
  eval((progn (use-package-ensure-elpa (quote circadian) (quote t) (quote nil) :ensure) (if (not (require (quote circadian) nil (quote t))) (ignore (message (format "Cannot load %s" (quote circadian)))) (condition-case err (progn (setq circadian-themes (quote ((:sunrise . whiteboard) (:sunset . tsdh-dark)))) (circadian-setup)) ((debug error) (ignore (display-warning (quote use-package) (format "%s %s: %s" "circadian" ":config" (error-message-string err)) :error)))) t)) nil)
  eval-last-sexp-1(nil)
  eval-last-sexp(nil)
  call-interactively(eval-last-sexp nil nil)
  command-execute(eval-last-sexp)

The problem appears to be that Circadian is expecting some string format from (sunrise-sunset) but the function returns the following for me:
#("Wed, Apr 18, 2018: Sunrise 6:41am (Mitteleuropäische Sommerzeit), sunset 8:38pm (Mitteleuropäische Sommerzeit) at Aachen, DE (13:57 hours daylight)" 35 63 (charset windows-1252) 81 109 (charset windows-1252)).
Sadly, this breaks the whole package for me

Hey @phuhl,
thanks for reporting that bug - That output of sunrise-sunset seems to be uncommon. Which kind of Emacs version are you running, and on which operating system: looks like Windows (because of the charset windows-1252 part)? Do you have other packages installed, that might ?

emacs-version:
GNU Emacs 24.5.1 (i686-pc-mingw32) of 2015-04-11 on LEG570
Windows 10
I know that i am running quite an old version of emacs but the newer one on windows had a bug (maybe) that broke some behaviour for me but did not add enough value for me to figure it out.
If you want to take a look at my packages and my setup i have my .emacs.d files here: .emacs.d. My currently installed packages (without build-in ones) are:
ace-jump-mode      20140616.115
async              20171015.2239
auto-complete      20170124.1845
bind-key           20161218.1520
circadian          20180307.954
company            20171017.1638
company-tern       20161004.1147
dash               20171028.854
dash-functional    20171028.804
diminish           20170419.1036
epl                20150517.433
expand-region      20170514.1309
flycheck           20171109.216
git-commit         20171007.346
google-translate   20170713.119
haskell-mode       20171022.26
ido-vertical-mode  20160429.1037
indium             20171106.916
js-doc             20160714.2134
js2-mode           20171107.333
json-mode          20170719.2205
json-reformat      20160212.53
json-snatcher      20150511.2047
let-alist          1.0.5
macrostep          20161120.1306
magit              20171112.348
magit-popup        20171109.1438
multiple-cursors   20170908.1452
org                20171113
origami            20170129.805
paredit            20170405.1149
pkg-info           20150517.443
popup              20160709.729
restclient         20180316.851
rjsx-mode          20171029.1156
s                  20171102.227
seq                2.20
slime              20171106.1331
ssh-agency         20170807.1152
tern               20170925.1333
tern-auto-complete 20170521.1235
use-package        20171030.1428
web-mode           20171112.1324
websocket          20171113.2045
with-editor        20171006.352
yasnippet          20170923.1646

I guess, you already figured out that I am in Germany. I don't know how that effects that sunrise-sunset function though.

Thanks for the details - I'm currently running ciradian package in Emacs 25.3 on Windows 10 on my workstation without any issues. Maybe the sunset-sunrise changed from version 24 🤔 I'll try it as soon as I get to it.
Grüße aus Hockenheim 🙃

Hey @phuhl thanks to @sarg your issue should be fixed 🎉  - would you mind testing circadian 0.3.3 on your system? Thanks in advance!

That fixed it, good work 🎉

@phuhl Cool, thanks for testing and closing the issue 🎉


HSEARCH-2930 + HSEARCH-2931 + HSEARCH-2932 JSR-352 test fixes

https://hibernate.atlassian.net//browse/HSEARCH-2930
https://hibernate.atlassian.net//browse/HSEARCH-2931
https://hibernate.atlassian.net//browse/HSEARCH-2932
Note: this does not fix tests on MariaDB completely, only part of it. We'll have to wait for https://hibernate.atlassian.net/browse/HSEARCH-2933[HSEARCH-2933] to be fixed before JSR-352 can work with the MariaDB JDBC driver.

merged! thanks


Added more cities to libs/cityReference.json

In response to Issue #6 , took bigger list of cities and formatted that to match the bot's parsing.  libs/va.json was the larger list of cities Stanley Z found, and addCenter.js is just what I wrote to format libs/va.json to libs/cityReference.json, they are not required for the bot to perform.

merged  :+1:


Collab Summit Berlin 2019 is less than a month away, let's register ✍

This Collab Summit will be held before JSConfEU at the Marriott Courtyard Berlin City Centre.
The registration link is: https://www.eventbrite.com/e/openjs-collaborator-summit-tickets-55985971548 and the password is: collabsummit.
To get your visa for this event: Email<EMAIL_ADDRESS>and cc<EMAIL_ADDRESS>after registration!
Call for Papers now open: https://github.com/nodejs/summit/issues/new/choose
Volunteers: We will work publicly on the agenda: if you are interested, we meet every week. Follow along or join us! nodejs/summit#135
Ref: nodejs/summit#152
Y'all are amazing and it would be great to meet in-person ✨

Sadly I was not able to join :( Next time we'll plan it better.


Cannot find module *.vue or its corresponding type declarations when components live in hidden directories

Summary

Encountered Cannot find module './C2.vue' or its corresponding type declarations. issue when opening a component that lives in a hidden directory (with . prefixed) in Visual Studio Code with Volar with the following behaviors:

vue-tsc --noEmit with no errors.
can navigate to the correct component when holding CMD and clicked the imported path in source code files.
the components lives in the non-hidden directories (without . prefixed) directories are fine, such as src, dot.
can be compiled, bundled successfully and working properly when in development, production modes, previews.

Such issue was initially appeared when I was developing some extension components for my VitePress site and the components was lived in .vitepress directory.
Reproduction
GitHub Reproduction Repo: https://github.com/nekomeowww/reproduction_volar_cannot_find_vue_module
Stackblitz Reproduction: https://stackblitz.com/github/nekomeowww/reproduction_volar_cannot_find_vue_module
Already done troubleshooting

I almost checked every issues, webpages that appeared under GitHub, StackOverflow and Google with the term "Cannot find module" "vue" with no luck.
Tried different content, filenames of shims.d.ts for declare module '*.vue' statement:

declare module '*.vue' {
  import type {DefineComponent} from 'vue'
  const component: DefineComponent<object, object, any>
  export default component
}

declare module "*.vue" {
  import Vue from 'vue';
  export default Vue;
}

Tried configure more includes path for tsconfig.json with **/*.d.ts, **/*.vue with no luck.
Tried to copy and paste the tsconfig.json from either antfu/vitesse and vuejs/vitepress with no luck.
Tried to globally or workspace partially disable @builtin typescript JavaScript and TypeScript language feature extension within VSCode with no luck.
Tried the latest Vue StackBlitz playground and default configuration with no luck.

Envs and Confs
Extensions
Visual Studio Code

Version: 1.79.2 (Universal)
Commit: 695af097c7bd098fbf017ce3ac85e09bbc5dda06
Date: 2023-06-14T08:58:52.392Z (2 wks ago)
Electron: 22.5.7
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.5.0

Extensions
TypeScript Vue Plugin (Volar) v1.8.3
Vue Language Features (Volar) v1.8.3

Runtime and package manager
Node.js v18.16.1
Pnpm v7.0.0

Dependencies
package.json:
{
  "devDependencies": {
    "@vitejs/plugin-vue": "^4.2.3",
    "typescript": "^5.1.6",
    "vite": "^4.3.9",
    "vue": "^3.3.4",
    "vue-tsc": "^1.8.3"
  },
  "type": "module"
}

tsconfig.json:
{
  "compilerOptions": {
    "module": "ESNext",
    "target": "ESNext",
    "strict": false,
    "esModuleInterop": true,
    "jsx": "preserve",
    "skipLibCheck": true,
    "isolatedModules": true,
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "noUnusedLocals": true,
    "strictNullChecks": true,
    "allowJs": true,
    "forceConsistentCasingInFileNames": true,
  },
  "exclude": [
    "**/node_modules/**",
    "**/dist/**",
  ]
}

Any updates?

Same problem here jumping from 1.8.1 to 1.8.5 (I didn't check versions between them)

This is a duplicate of See https://github.com/vuejs/language-tools/issues/3328
As should be clear from the linked issue you can explicitly state which vue files to process by adding include to tsconfig.json:
  "include": [
    "./.dot/**/*.vue",
    "./dot/**/*.vue",
    "./src/**/*.vue",
  ]

or something more generic.

Duplicate of #3328

And should be fixed by #3450并且应该由#3450修复

volar 1.82.7 is not fix it.

I fixed this by creating vue.d.ts in src with the contents:
declare module '*.vue';

helpful, it has solve the problem,


Fix maps * command

Fixes the maps * command not detecting all maps

Before

After

Also adds NSGetLoadedMapNames which returns an array of loaded map names

What is this command used for, actually?

The title is somewhat misleading. This PR fixes the function which gets all maps the game can load ( by fixing the regex ). This function is used for the maps * command which just lists all maps you can load and the map command auto completion.


feat: Add epub support

Enables RAG with EPUB documents.

Facing python dependency issue on macos :/ Taking a look!

Facing another issue, was it working from your end?

Yes, I was testing via the Docker container (on Linux), and pypandoc_binary was working successfully.  I originally tried the pandoc/pypandoc combo, but it wasn't able find pandoc so I switched to the binary package.
I tried a variety of different epub files and they all worked without issues once the dependency got sorted out.

pypandoc_binary does not seem to support macos (apple silicon), we're going to have to find other alternatives before we merge.

Alright, so pip's pandoc package is just a wrapper library, not Pandoc itself.  Pypandoc has an auto-download feature, but it didn't work for me. I think the best thing to do is to require Pandoc to be installed separately to enable epub support.
I updated the Dockerfile to install it during the build, this works.  I haven't tested outside of Docker, but the installation is going to depend on the OS.
If Pandoc is not installed, it throws a specific error message.  I also updated the frontend to display a toast and remove the file if any errors occur during the upload.  I saw there was a doc.error field but I didn't see it being used so I left that alone.

Hi, I am also interested in it
From my experiments with llama index it uses:
ebooklib
html2text
https://github.com/run-llama/llama-hub/tree/956aa44b6dfa3e085b9b9a80c3caec0144b1bbbf/llama_hub/file/epub
Is this a better option?

Rebased to fix merge conflicts with other changes.

Just tested everything, seems to be working fine! everything LGTM, Thanks!

First of all, thank you very much for your efforts and current results, I'm very excited to see the support for this feature, the first time I tried it with an epub file of 174M size, it is a document containing html content (GodotEngine.epub), when I uploaded it the page prompted me:
Unknown File Type 'application/epub', but accepting and treating as plain text
I checked the code related to type judgment, and it supports "application/epub+zip", but not "application/epub". Since I'm not familiar with the implementation mechanism of these functions, I'd like to ask you guys if it's possible to support "application/epub"?


RRMap broken for >1D chare arrays

Original issue: https://charm.cs.illinois.edu/redmine/issues/854

The built-in RRMap CkArrayMap only does a true round-robin mapping for 1D arrays. For >1D arrays it hashes the indices of each element modulo a big prime number and the number of PEs. This leads to unbalanced mappings of chares to PEs (some PEs might not get any chares in some cases or some PEs will have more than others), and the behavior is not true to the API.
This is seemingly because the map interface does not know the extent of the array dimensions, only the indices of each chare array element.

Original date: 2016-11-02 15:30:11

Abandoned patch for this: ~~https://charm.cs.illinois.edu/gerrit/#/c/1053/~~ https://github.com/UIUC-PPL/charm/commit/95cdcfaf800581538141f5a6f6c3a3036c6ed27b
BlockLB similarly does not take into account the dimensionality of a chare array.
CkArrayOptions already provides an interface (opts.setBounds()) to let users gives us the number of chares per dimension of their array, but this information is not passed through the location manager to the ArrayMap and LB objects.
A further cleanup for this issue is that section 13.2.1 of the manual should be rewritten to encourage users to use setBounds and the other things that CkArrayOptions exposes.

Original date: 2017-02-07 03:16:45

The real work here is in passing the bounds from CkArrayOptions through to CkArrayMap, so that RRMap can linearize the index space of multidimensional arrays for a true round-robin mapping.
The case of BlockLB is basically the same, BlockLB needs to know the bounds but currently doesn't.

Original author: Dong Hun Lee
Original date: 2017-04-19 15:11:23

RRMap using Nikhil's previous code.
~~https://charm.cs.illinois.edu/gerrit/#/c/2421/~~ https://github.com/UIUC-PPL/charm/commit/04a4c404d2aff8d4f324828c13ba49433fda0a15

Original date: 2017-05-02 16:14:52

Note that the patch implements this for RRMap, and adds the mechanism to do it in BlockLB, but I think BlockLB will need to explicitly be fixed too.


Add append_captions feature to wd14 tagger

This feature allows for appending new tags to the existing content of caption files.
If the caption file for an image already exists, the tags generated from the current
run are appended to the existing ones. Duplicate tags are checked and avoided.

Thank you.


[SWOC'24] Issue Templates

Issue templates for your project like,

Styling Request
Documentation Request
Bug Report
New Features Request, etc.

This will help contributors and maintainers both to segregate which are related either styling, new features, bug, etc.

@pinak-dhir please assign this work to me to contribute in your repo under SWOC'24

happy coding @Avdhesh-Varshney


Parsing error in class attributes doesn't report the line number

Reported by Keith Snyder on Twitter, e.g. due to a missing end quote:

blah blah

the error will be "Error while parsing file: the value of attribute class etc."
This is likely reported by Jing, see why the line number is not reported and if it can be fixed.

Clearing assignee and removing from 4.1.0 milestone. Feel free to work on it and assign it back to 4.1.0 as long as we're still working on it.


Simplifying hashimoto_full and miner

You can get full_size from the dataset, no need to hand it as an argument

doesn't merge anymore


Provides locale / en_us.UTF-8 in docker images

Feature request
Default docker image does not have locale packages.
Locale is not set in Ubuntu.
Is your feature request related to a problem? Please describe.

We are serving in Korea, and we need to log using auditLoader.
If there is korean in the query, It is recorded as ??? in the log.
Describe the solution you'd like

RUN apt-get update -y && \
    apt-get -y install --no-install-recommends locales && \
    apt-get clean && \
    rm -rf /var/lib/apt/lists/*

RUN locale-gen en_US.UTF-8

Describe alternatives you've considered

Additional context

fixed in #41039

@kevincai We use audit loader. I think it should work for frontend too.

I see, this locale is needed for FE docker image as well.


SPIKE: Research Video widget options

Can you research...

if we hosted the video ourselves in s3?
if it was just a link we pulled over?

we can stream from both s3 and multiple platforms (Youtube, facebool, vimeo, etc.) using npm react-player. We just pass the url. For s3 the videos need to be public, if not we can generate a signed url via the backend that is authenticated to stream the video


Add file extension automatically if not added by user

If user does not supply a file extension, add one based on output_type.

Added modified_path to report spec object to capture added extension.  That way we can still retain the original value in file_path.  So different output type functions now use modified_path as the primary path.


FW landing optionally disable heading hold

Test flew this on multiple fixed wing aircraft the past couple days.  Here are a couple example logs with FW_LND_HHDIST set to 0.  The ground track was nice a straight all the way up to landing.
http://review.px4.io/plot_app?log=14d27700-aff7-415b-9037-99e07c978c85
http://review.px4.io/plot_app?log=ca87e562-25a4-41f0-83ce-64febd33c96c
Without this PR heading hold was forced to kick in at flare which turned the body of the aircraft in-line with the landing approach and had the effect of being blown sideways in a crosswind.


Serve using UNIX domain socket

Would it be possible to make datasette serve using UNIX domain socket similar to Uvicorn's --uds?

This sounds like a valuable feature for people running Datasette behind a proxy.

Looks pretty easy to implement - here's a hint from Uvicorn source code: https://github.com/encode/uvicorn/blob/b5af1049e63c059dc750a450c807b9768f91e906/uvicorn/main.py#L368
Need to work out a simple pattern for testing this too.

You could actually run Datasette like this today without modifications by running a thin Python script that imports from datasette.app, instantiates the ASGI app and passes that to uvicorn.run - but I like this as a supported feature too.

I wonder if --fd is worth supporting too? Uvicorn documentation says that's useful for running under process managers, I'd want to understand exactly how to use that (and test it) before adding the feature though.

This sounds like a valuable feature for people running Datasette behind a proxy.

Yes, in some cases it is easer to use e.g. Apache's ProxyPass Directive with Unix Domain Socket like  unix:/home/www.socket|http://localhost/whatever/.

Can test this with:
curl --unix-socket ${socket} -i "http://localhost/"

I can run tests against it using httpx: https://www.python-httpx.org/advanced/#usage_1

>>> import httpx
>>> # Connect to the Docker API via a Unix Socket.
>>> transport = httpx.HTTPTransport(uds="/var/run/docker.sock")
>>> client = httpx.Client(transport=transport)
>>> response = client.get("http://docker/info")

I don't have the Datasette test suite running on Windows yet, but I'd like it to run there some day - so ideally this test would be skipped if Unix domain sockets are not supported by the underlying operating system.

Apparently Windows 10 has Unix domain socket support: https://bugs.python.org/issue33408

Unix socket (AF_UNIX) is now avalible in Windows 10 (April 2018 Update). Please add Python support for it.
More details about it on https://blogs.msdn.microsoft.com/commandline/2017/12/19/af_unix-comes-to-windows/

But it's not clear if this is going to work. That same issue thread (the issue is still open) suggests using hasattr(socket, 'AF_UNIX')) to detect support in tests.

Figured out an example nginx configuration. This in nginx.conf:
daemon off;
events {
  worker_connections  1024;
}
http {
  server {
    listen 8092;
    location / {
      proxy_pass              http://datasette;
      proxy_set_header        X-Real-IP $remote_addr;
      proxy_set_header        X-Forwarded-For $proxy_add_x_forwarded_for;
    }
  }
  upstream datasette {
    server unix:/tmp/datasette.sock;
  }
}

Then run datasette --uds /tmp/datasette.sock
Then run nginx like this:
nginx -c ./nginx.conf

Then hits to http://localhost:8092/ will be proxied to Datasette.

I wonder if --fd is worth supporting too?

I'm going to hold off on implementing this until someone asks for it.

Documentation: https://docs.datasette.io/en/latest/deploying.html#nginx-proxy-configuration

Wrote up a TIL: https://til.simonwillison.net/nginx/proxy-domain-sockets


fix: Interaction's comment should be string not array

Currently I have to do this in pact-php to make the tests pass:
$this->interaction->setComments(['text' => json_encode([$value])]);

I think it should be this:
$this->interaction->setComments(['text' => $value]);

cc @JP-Ellis

I agree, there seemed to be a bit of a discrepancy when I implemented this. Should get @rholshausen to weigh in.

The format in the Pact file is an array so that multiple comments can be provided. For context see https://github.com/pact-foundation/pact-specification/issues/45

When I implemented the FFI, and taking into consideration that the comment field allows for any valid JSON value, I specifically have deserialised the input string.
For example:

FFI
Value

set_comment("a", "foo")
{"a": "foo"}

set_comment("a", '["foo"]')
{"a": ["foo"]}

set_comment("a", "true")
{"a": true}

set_comment("a", NULL)
{}

set_comment("a", "123")
{"a": 123}

Using set_comment with the same key will overwrite the key/value pair.
This is all tested in the test I implemented.
Perhaps this wasn't the intended way to specify comments? Though for the FFI, it ensures it is very flexible, allowing arbitrary content to be added.

Not sure my approach is a good way:
Since:

I assume only me and @JP-Ellis using this feature
It is not intended way to add comment. We only allow end-user to modify comments -> text

May be remove set_comment(key, value) and add add_comment(value) to modify comments -> text only

hmmm so looking at the spec, its a map with a string for the key and a json value, which seems odd (it is that reason in the metaData section)
Looking at the original; request, should it be a string, or string array for our value, rather than json.
so Map[ string | List[string] ]

Field
Required?
Type
Description

comments
optional
Map[string, JSON]
Comments that are applied to the interaction. See comments section below

https://github.com/pact-foundation/pact-specification/tree/version-4?tab=readme-ov-file#comments

Key
Description

testname
Stores the name of the test that ran and generated the Pact file

text
List of free-form text comments to display

The only thing here is that I don't particularly like having the redundancy between the two methods. As an end-user, I think each FFI should have a clear and distinct purpose, and set_comment and add_text_comment are too similar in my opinion.

Agreed,
maybe as testName and comments are the examples in the spec, we could have them as dedicated  methods along with one for arbritrary keys
setTestName(string)
setCommentText(List[string])
setCommentTextArray(List[string])
setComment(key,string|List[string])

Given the Pact specification is quite explicit that the comments field is an optional field of type Map[string, JSON], then there should be a way of adding a boolean, string, array, or even an object within the comments.
Having said that, and as pointed out by Ron (as well as the spec itself), the text key within the comments does seem to be special in some way.
As a result, I think it might be best to leave the set_comment(key, value) as is in the FFI as it is a quite general function providing compatibility with the spec as it is written; and I can add a new add_text_comment(value) FFI method which will append text to the text key within the comments. This would ensure it works with the initial intent for comments as discussed in pact-foundation/pact-specification#45.
I would want to avoid having dedicated methods for each value type. Ultimately, this FFI should remain somewhat low level, and the libraries making use of the FFI can be responsible for the encoding of values into JSON strings.

Closing this as the underlying FFI addresses this issue.

Done!


Ability to clone the prod DB to local env

It would be great to backup & restore the prod DB to my local env with just a single command (e.g. nhost clone-db).
Or at least give a hint on how to do it. I've tried pg_dump and pg_restore but something always breaks (hasura cannot access hdb_catalog, nhost_auth_admin cannot access auth, etc).

I support this. It would be an amazing feature!
I had to recreate my cloud env twice before.

Did you try this?
https://github.com/nhost/cli/issues/227#issuecomment-1298554205

Apologies for the super late response.
While the CLI doesn't do it automatically you can do this already. You could do something like:
pg_dump --data-only --file=nhost/seeds/prod.sql $conn_str

Just make sure you add it to .gitignore. Let me know if it doesn't work.

Pulling my hairs over this because it doesnt work. It is not as simple as running one pg_dump command and pg_restore command. Please nhost, you guys need to give a documentation to this as this is such a crucial feature.
I am deploying my local development environment to amazon so that I can give my test mobile application to my testing team. I need to clone the production db to my local db but there is no specific way. pg_dump/pg_restore just doesnt work.

Given you are self-hosting that might be an issue with your self-hosted instance. What error are you getting. pg_dump/pg_restore certainly works or I am sure a lot of people would be mad at Postgres :)

I followed Nuno Patos' guide on discord. Basically, doing pg_dump bymyself was causing alot of issues. I simply downloaded the backup from nhost since I am on pro plan, and then did pg restore pg_restore -h localhost -p 5432 -d local -U postgres data_backup where data_backup is my backup file which i downloaded. Ran this command a couple of times and my data got restored.


Questions about Chunk_size using Triton optimization in SSD kernel

Thank you for your great work，I found that in Mamba2, chunk_size defaults to 256, while my sequence length is only 200 and still runs normally. In issue #439 , you pointed out that this is due to the optimization of the SSD kernel (Padding on sequence length?) to meet the requirement of seq_len% chunk_size=0, but I didn't quite understand the content related to pointer offset in the implementation of triton. Can you give me some answers on how to implement seq_len=200 and chunk_size=256 in the above example to run normally?
Additionally, I attempted to set chunk_size to 50 and 40 to accommodate the divisible seq_len=200 in my task (although your perfectly implemented kernel can ignore this issue), but a loss=nan situation occurred. Afterwards, I checked your kernel source code and found that there were block optimizations in the triton section, all of which were powers of 2. Therefore, I attempted to set chunk_size to 64, there was no loss=nan issue. However, due to the issue of precompiling the Triton source code, I am not sure how to debug the SSD kernel in your original version. Therefore, I would like to ask if it is best to set chunk_size to the power of 2 for the Triton block optimization you have implemented in your version of the SSD kernel? I am deeply sorry to disturb you with such a foolish question, but I hope you can give me some answers. Thank you very much!

Yes chunk size should be a power of 2, that's what Triton supports.
To deal with seqlen not divisible by chunk_size, we load with a mask. Anything outside the seqlen is masked to be zero here for example:
https://github.com/state-spaces/mamba/blob/8ffd905c91d207f5c0cc84fc2a2fb748655094f0/mamba_ssm/ops/triton/ssd_chunk_state.py#L225
There are similar masks for other triton kernels in this repo.

Yes chunk size should be a power of 2, that's what Triton supports. To deal with seqlen not divisible by chunk_size, we load with a mask. Anything outside the seqlen is masked to be zero here for example:
https://github.com/state-spaces/mamba/blob/8ffd905c91d207f5c0cc84fc2a2fb748655094f0/mamba_ssm/ops/triton/ssd_chunk_state.py#L225
There are similar masks for other triton kernels in this repo.

I see! Thank you for your prompt response and perfect work!


createAddress recursion problem

Hello,
I try to generate many addresses for many wallets to make mass txProposal. As I found I can't generate them in simple cycle, GET /insight-api/addr/ begin to return 500 code very soon.
So I try to generate addresses recursively like:
WalletsProcessor.prototype.getAddress = function(res, list, i, outputs, wfile, wpwd)
{
    console.log("getAddress");
  var self = this;

	// 1. Open wallet & request address
	var client = new Client({
  		baseUrl: BWS_INSTANCE_URL,
    	verbose: false,
    });

    var walletName = list[i].wallet;

  try
  {
	// Open wallet's file
    client.import(fs.readFileSync(walletPath+walletName).toString());
	// Get address
	client.createAddress({}, function(err,addr)
    {
        console.log("createAddress callback");
    	if (err)
        {
        	console.log('error: ', err);
            return;
        }
		var address = addr.address;
        console.log(address);
        var output = {amount:helper.BTCtoSatoshis(list[i].amnt), toAddress:address, message:i.toString(10)};
        outputs.push(output);
		client = null;
        i++;
        if(i<10)
        {
            self.getAddress(res, list, i, outputs, wfile, wpwd);
        }
	});
  }
    catch(e)
    {
        self.showMessage(res, 'Wallet access error', e);
    }
}

When I executed
    var i=0;
    self.getAddress(res, list, i, outputs, wname, wpwd);

I expect to see 10 addresses generation.
But I see following:
getAddress
[2016-06-22T15:01:06.805Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/mskVqs5idhsjJGyXRkWfbaAVc14radtz8x" 200 257 8.945 "bws-1.9.0"
[2016-06-22T15:01:06.817Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/mgQZpTXQmnypEUiPbiYuRTxhTYjqxDkHX6" 200 257 3.754 "bws-1.9.0"
[2016-06-22T15:01:06.824Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/mzB3PNDX47YE7FdhUn5GQAYSXdWRqffDUU" 200 257 3.253 "bws-1.9.0"
[2016-06-22T15:01:06.830Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/mxDM71gkCbTmXDFAcTAsZKJH19TDxdrq5Q" 200 257 2.979 "bws-1.9.0"
[2016-06-22T15:01:06.838Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/n3F6Sd3qS8L1WDb1sYhKSa82xsgTuZ9Bh8" 200 257 3.982 "bws-1.9.0"
[2016-06-22T15:01:06.845Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/n3D4LWZX9gGXZ1pSdWCZWjffXzX22PfSxA" 200 257 2.463 "bws-1.9.0"
[2016-06-22T15:01:06.858Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/moMNybQuP45YQspc8r6reQ5ozLD7cqvtVt" 200 257 3.054 "bws-1.9.0"
[2016-06-22T15:01:06.865Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/mvNhi4fVpu3mUHDANRv6GDXSQTakaHMKdn" 200 257 3.212 "bws-1.9.0"
[2016-06-22T15:01:06.870Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/mq5UiiMYLECfjAiRpjuXh7r1BCNs598e6a" 200 257 2.273 "bws-1.9.0"
[2016-06-22T15:01:06.877Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/mhUd6vCXL9ayvrDJqR4ewuEQag26VfBbpH" 200 257 2.693 "bws-1.9.0"
[2016-06-22T15:01:06.882Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/mh8G2koVSCrCz9RtgEi3aMdharkkWwLrze" 200 257 2.222 "bws-1.9.0"
[2016-06-22T15:01:06.889Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/msfWtyrkCBadWHT1QDdFgQaFfY1B4XFLiT" 200 257 3.303 "bws-1.9.0"
[2016-06-22T15:01:06.896Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/mhCu2oCiEUtK8Bjn965g3UX6XrCuqwVU5o" 200 257 3.698 "bws-1.9.0"
[2016-06-22T15:01:06.902Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/mo2rCEsyeZ1kLvUrHQARn4xMrm8s8KZoD7" 200 257 2.991 "bws-1.9.0"
[2016-06-22T15:01:06.908Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/mwMpQzXFiVpqSNsXrFLRNU6rUZwSpU9NxB" 200 257 2.700 "bws-1.9.0"
[2016-06-22T15:01:06.914Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/mjQeyBb7qVgovaka6o19GAJVgTQrZKeEsu" 200 257 2.691 "bws-1.9.0"
[2016-06-22T15:01:06.920Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/miCztTgweARAqTjJA2SaGgZhez7KTHReyh" 200 257 2.941 "bws-1.9.0"
[2016-06-22T15:01:06.927Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/mztFFFypSDQThL3HVaiZNhh2jGCtjhAg98" 200 257 2.621 "bws-1.9.0"
[2016-06-22T15:01:06.933Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/mfvVe2EfdLoxbR8QwqF85eJUFztWMw3ABD" 200 257 3.294 "bws-1.9.0"
[2016-06-22T15:01:06.939Z] info: ::ffff:<IP_ADDRESS> "GET /insight-api/addr/muQJu1HAF8vdAemMZT3a3AyafrLXExUZdj" 200 257 3.567 "bws-1.9.0"
info Client Err: 400 /v3/addresses/ <ClientError:MAIN_ADDRESS_GAP_REACHED Maximum number of consecutive addresses without activity reached>
 ::ffff:<IP_ADDRESS> 2016-06-22T15:01:06.943Z "POST /bws/api/v3/addresses/" 400 112 177.758 "-" 7c56481a-4b84-4976-a547-9833a2e9def3 6c01c83aa08da31f99a34e251d979536602770d44286d7a65238b1bc9557b67c
[error] Error: MAIN_ADDRESS_GAP_REACHED
[2016-06-22T15:01:06.948Z] error: uncaught exception: [TypeError: Cannot read property 'type' of undefined]
[2016-06-22T15:01:06.948Z] error: TypeError: Cannot read property 'type' of undefined
    at Function.Verifier.checkAddress (/Users/iev/Documents/bitcore-wallet-service/node_modules/mynode/node_modules/bitcore-wallet-client/lib/verifier.js:28:42)
    at /Users/iev/Documents/bitcore-wallet-service/node_modules/mynode/node_modules/bitcore-wallet-client/lib/api.js:1811:19
    at Request._callback (/Users/iev/Documents/bitcore-wallet-service/node_modules/mynode/node_modules/bitcore-wallet-client/lib/api.js:813:14)
    at Request.self.callback (/Users/iev/Documents/bitcore-wallet-service/node_modules/mynode/node_modules/bitcore-wallet-client/node_modules/request/request.js:200:22)
    at emitTwo (events.js:87:13)
    at Request.emit (events.js:172:7)
    at Request.<anonymous> (/Users/iev/Documents/bitcore-wallet-service/node_modules/mynode/node_modules/bitcore-wallet-client/node_modules/request/request.js:1067:10)
    at emitOne (events.js:82:20)
    at Request.emit (events.js:169:7)
    at IncomingMessage.<anonymous> (/Users/iev/Documents/bitcore-wallet-service/node_modules/mynode/node_modules/bitcore-wallet-client/node_modules/request/request.js:988:12)
[2016-06-22T15:01:06.949Z] info: Beginning shutdown
[2016-06-22T15:01:06.949Z] info: Stopping user
[2016-06-22T15:01:06.950Z] info: Stopping bitcore-wallet-service
[2016-06-22T15:01:06.950Z] info: Stopping insight-api
[2016-06-22T15:01:06.950Z] info: Stopping web
[2016-06-22T15:01:06.950Z] info: Stopping admin
[2016-06-22T15:01:06.950Z] info: Stopping bitcoind
[2016-06-22T15:01:11.758Z] warn: ZMQ disconnect: tcp://<IP_ADDRESS>:28332
[2016-06-22T15:01:11.759Z] warn: ZMQ connection delay: tcp://<IP_ADDRESS>:28332

Looks like the only part of callback executed is getAddress func.
list =
[ { wallet: 'testwallet1', amnt: 0.0101 },
  { wallet: 'testwallet2', amnt: 0.0102 },
  { wallet: 'testwallet3', amnt: 0.0103 },
  { wallet: 'testwallet4', amnt: 0.0104 },
  { wallet: 'testwallet5', amnt: 0.0105 },
  { wallet: 'testwallet6', amnt: 0.0106 },
  { wallet: 'testwallet7', amnt: 0.0107 },...

etc. 200 entries

[error] Error: MAIN_ADDRESS_GAP_REACHED
GAP REACHED
so if you look at createAddress, the options say:
 * @param {Boolean} opts.ignoreMaxGap[=false]

So make it true. Now you can generate unlimited.
    // Get address
    client.createAddress({ignoreMaxGap: true}, function(err,addr)

By the way, createAddress will always generate a brand new address, but if you want to view all your addresses up until now (maybe utilize unused old addresses for something)
Use
client.getMainAddresses Instead

@dabura667 thanks a lot for your help.
Seems was my bag, sorry.


Add environment variables templates

With this change it becomes possible for containers to setup it's own configuration template. By default it is disabled.

Thanks a bunch! :+1: I really appreciate your effort for doing this. I will give it a try and let you know, however, by looking at the code it is what I was after :)

This looks very interesting for a setup I have in mind.
Is it correct that when both the template argument and the environment variable is set the priority is to use the environment variable (at least that's how I read the code -- and what would make sense to me)?

@arnested Exactly. With this change if the container is started with the template environment variable set then it is used. If not the template set as parameter of the docker-gen is used. We've been used this for some months at my company and looks stable.
Also, we've been planning on adding another feature to "group" the containers with the same template so that docker-gen can put them on the same grouped template, and do things like NGINX upstream server with multiple addresses. I've just need to find some time to implement this... :)

@arnested Just pushed the "grouping" feature I talked about. Please have a look, if you're still interested. :)

Any news?

I was thinking about this change and I noticed that the variable name VIRTUAL_HOST_TEMPLATE seems too coupled with the nginx-proxy project. I'll edit the changes and instead use something like DOCKERGEN_CUSTOM_TEMPLATE, as soon as I find time to do so.

Hi @ldnunes,
I finally got around to giving your code a test ride, but I'm stuck on building it:
$ make
Building docker-gen
# _/home/arne/go/src/github.com/jwilder/docker-gen/cmd/docker-gen
cmd/docker-gen/main.go:155: unknown field 'UseEnvVarTemplate' in struct literal of type dockergen.Config
cmd/docker-gen/main.go:173: config.UseEnvVarTemplate undefined (type dockergen.Config has no field or method UseEnvVarTemplate)
Makefile:10: recipe for target 'docker-gen' failed
make: *** [docker-gen] Error 2

Never mind ... I forgot go get ./... after I switched to your branch ....

First impression.
Running docker-gen without options will normally result in the output of --help.
Your branch will output an error message:
2017/05/06 13:07:32 Error: missing template file argument or the "use environment variable template" option parameter or configuration has not been set.

Probably some kind of check implemented too early in the process?

Second impression.
It seems to make no difference whether I include the -use-environment-variable-template option or not (or if I set it to -use-environment-variable-template=false.
The VIRTUAL_HOST_TEMPLATE  variable always affects the generated file.

Third impression.
I need to provide the template in the environment variable? Not let the environment variable refer to a template file?
I can see how this is necessary given we don't know if docker-gen is running inside a docker container itself and cannot be guaranteed to see the template file.
On the other hand shuffling a complete template into a environment variable is not easy and does not increase readability of your docker-compose file or whatever you use to start your containers.

Thanks for the PR.  I'm going to close this as this is not a feature I'd like to support currently.

Is there any reason why we can't get this pushed? I would like to get container ENV from the new container that I using to build the container with.


Tweak WatchYourStep to be more similar to other models

This does 2 things:

splits build into build and __call__ to match GCN (and most others)
moves the get_embeddings function to be a method on WatchYourStep, similar to ComplEx, DistMult and DeepGraphInfomax (this includes checking that the input Keras Model seems to come from the right WatchYourStep model, similar to DeepGraphInfomax)

I'm going to wait for #1102 for this, since it will allow us to simplify the embeddings function dramatically.


Webgl images look broken

Testing the WebGL module renderer that @AshrafSharf and @samreid worked on, things seem broken:

@AshrafSharf can you take a look?

Sure. Will see where the problem is.

Fixed in d1c473e07af804c1814b0c411511e87e1493469e thanks to @AshrafSharf!  Closing.