How to map join using customSelect

Describe the bug
I am trying to self join the category with its parent but I cannot do or I do not know how to do it using custom select, Here my function
/// Watch Categories
  Stream<List<Category>> watch({required CategoryQueryArgs args}) async* {
    List<Variable> variables = [];

    String queryStr = 'SELECT'
        ' parent.*,'
        ' category.*,'
        ''' (
        SELECT COUNT(*)
          FROM categories children
          WHERE parent.id = children.parent_id
        ) AS childrenCount'''
        ' FROM categories category'
        ' LEFT JOIN categories parent ON parent.id = category.parent_id'
        ''' WHERE json_extract(category.details, '\$.type') = ?;''';

    variables.add(Variable<String>(
        TransactionType.values.elementAt(args.type.index).name));

    if (args.parentId != null) {
      queryStr += ' AND category.parent_id IS NULL'
          ' AND category.parent_id = ?';
      variables.add(Variable<int>(args.parentId));
    }
    if (args.keyword != null) {
      queryStr +=
          """ AND json_extract(category.details, '\$.name') LIKE '%${args.keyword}%' """;
    }

    final qyery = customSelect(
      queryStr,
      readsFrom: {
        categoriesTable,
      },
      variables: variables,
    );

    yield* qyery.watch().map((rows) {
      return rows.map(
        (row) {
          return Category(
            // parent: categoriesTable.map(row.data),
            data: categoriesTable.map(row.data),
            hasChildren: row.read<int?>('childrenCount') != 0,
          );
        },
      ).toList();
    });
  }

LIKE '%${args.keyword}%'

First of all, please use ? here and add a variable instead.
Then, I'm not sure why you'd want to use a custom select here, all of this is supported by drift now. The problem is that parent.* and category.* expand to the same column names (there's no parent. prefix on the names chosen by sqlite3), so there is no reliable way to distinguish them. With the way the SQL is written, this is simply not possible. You'd have to explicitly use parent.id AS "parent.id" for every single column.
Or, you just write this query with drift APIs. I admit it's a mouthful, but so is the original query:
import 'package:drift/extensions/json1.dart';

  Stream<List<Category>> watch({required CategoryQueryArgs args}) {
    final parent = alias(categories, 'parent');
    final query = select(categories).join(
        [leftOuterJoin(parent, parent.id.equalsExp(categories.parentId))]);

    final children = alias(categories, 'children');
    final childrenCount = subqueryExpression(selectOnly(children)
      ..addColumns([countAll()])
      // NOTE: This counts the amount of siblings of the category, since you're
      // comparing to the parent id (as in your original query). Are you sure
      // you don't want `categories.id.equalExp(...)`?
      ..where(parent.id.equalsExp(children.parentId)));
    query.addColumns([childrenCount]);

    query.where(categories.details
        .jsonExtract(r'$.type')
        .equals(TransactionType.values.elementAt(args.type.index).name));

    if (args.parentId != null) {
      // Note: This was IS NULL in your original snippet, a mistake I guess.
      // But you don't need the IS NOT NULL check either way, since a comparison
      // with NULL evaluates to NULL which doesn't include the row in the
      // result.
      query.where(categories.parentId.isNotNull() &
          categories.parentId.equals(args.parentId));
    }

    if (args.keyword != null) {
      query.where(categories.details
          .jsonExtract<String>(r'$.type')
          .like('%${args.keyword}%'));
    }

    return query.watch().map((rows) {
      return [
        for (final row in rows)
          Category(
            parent: row.readTableOrNull(parent),
            data: row.readTable(categories),
            // If you only want to know whether there are any children, using
            // COUNT(*) may be inefficient. Use `existsQuery` instead.
            hasChildren: row.read(childrenCount) != 0,
          ),
      ];
    });
  }

First of all, thank you so much for your response and all your instructions, really appreciated it.
And I think the documentation may need to be enhanced a little bit more.
So, for example, there's no mention at all of the jsonExtract methods and even after you mentioned it here I didn't know how to import it as it says undefined, before checking #235
it will be better in my opinion to make the documentation more like this
https://www.javatpoint.com/sqlite-tutorial


[Airbrake] [Staging] undefined method `attributes' for nil:NilClass

Airbrake error: #1172
Airbrake project: ETMoses
Error type: NoMethodError
Error message: undefined method `attributes' for nil:NilClass
Where: gas_asset_lists#update
Occurred at: Jul 27, 2016 10:32:12 UTC
First seen at: Jul 27, 2016 10:32:12 UTC
Occurrences: 1 (1 since last deploy on Jul 25, 2016 16:43:32 UTC)
URL: https://beta-moses.energytransitionmodel.com/testing_grounds/663/gas_asset_lists/671
File: [PROJECT_ROOT]/app/models/gas_asset_list_decorator.rb
Backtrace:
[PROJECT_ROOT]/app/models/gas_asset_list_decorator.rb:21:in block in decorate
[PROJECT_ROOT]/app/models/gas_asset_list_decorator.rb:18:in map
[PROJECT_ROOT]/app/models/gas_asset_list_decorator.rb:18:in decorate
[PROJECT_ROOT]/app/controllers/gas_asset_lists_controller.rb:11:in update

Duplicate of #1335 and closed by 061f66a4.


ci(release-please): activate npm publish by removing dry-run argument

Activates the npm publish.
🚧 Wait for submitting until:

[x] UA review is finished
[ ] repository is public.

LGTM
Also, the second prerequisite is met :)


Toolbar buttons may be hard to see

I am using a modified version of Dracular theme. The toolbar button is a bit hard to see with white content.

I think logseq native image overlay could be a solution.

emm, good idea


Start adding a performance section to the guide.

We discussed this quite often and I though that even if it is only a single thing, just making a start would improve our chances of getting it finished eventually.

@davidhewitt I added another subsection on implicit access to GIL token. Please have another look before this is merged.
Also do you remember any other topics when wanted to discuss here? I do think I remember that there about four different things we wanted to have here, but I am unable find a list anywhere in the older issues, pull requests or discussions.

Also do you remember any other topics when wanted to discuss here?

Is dictionary dispatch, i.e. look-up tables based on type object identity, something we want to discuss here or is this too specialized?

Personally I think that's quite application-specific, but I'm not against having that section if you want to write it.
Some other topics I recalled over the day:

Overhead of conversions (i.e. PyList vs Vec etc.)
Threading / allow_threads
String intern!
Vec<u8> becoming list[int] (and thus being very slow)
#[pyo3(get)] deep-cloning non-Py data

We can potentially move these into an issue rather than write them all in this PR?

Threading / allow_threads

Shouldn't this be covered by the "parallelism" section?

We can potentially move these into an issue rather than write them all in this PR?

Yes, I'd like to limit this PR to the two small sections already written.

Personally I think that's quite application-specific, but I'm not against having that section if you want to write it.

Ok, let's include a note in the issue. Certainly not in this PR.

Sorry for the slow reply - I got a bit sidetracked by the various PRs I have pushed in the last 24h...

Shouldn't this be covered by the "parallelism" section?

Yes, though I think it can't hurt to call it out i.e. "how do I multithread? See parallelism section". More visibility :)


[Ionic 4.0.0-beta.16] popover modes ios - md style conflict in same page

Bug Report
Ionic Info
ionic (Ionic CLI)             : 4.3.1 (/Users/shbhat/.npm-global/lib/node_modules/ionic)
Ionic Framework               : @ionic/angular 4.0.0-beta.16
@angular-devkit/build-angular : 0.10.6
@angular-devkit/schematics    : 7.0.6
@angular/cli                  : 7.0.6
@ionic/angular-toolkit        : 1.2.0
System:
NodeJS : v8.12.0 (/usr/local/bin/node)
npm    : 6.4.1
OS     : macOS Sierra
Describe the Bug
A clear and concise description of what the bug is.
In Ionic 4.0.0-beta.16, when we create a custom iOS popover, it messes up style of other MD popovers and vice versa.
Styles affected : backdrop, z-index, width, height and positioning.
Steps to Reproduce
Steps to reproduce the behavior:

Create a button which opens an iOS mode popover via popover controller.
Create another button which opens md mode popover via popover controller.

Related Code
Made a git repo reproducing this behavior.
https://github.com/shreeshbhat/ionic-v4-popover-ios-md-issue
Expected Behavior
Expecting that we should be able to use iOS and md mode popovers without styling issues with backdrop, z-index, width, height and positioning.
Additional Context
Screenshots below :

@manucorporat : Awesome. Thanks!
Can you please post which commit from stencil would fix this issue?
Would love to understand why it was happening and how it was fixed. :)


Error only when piping through Merge node.

The Highway node receives an error when piping in from a Merge. I haven't tested it on values other than String.
Output "StringName" is not defined or is not of type "STRING". Expected "str".
If I pipe directly from another Highway, this error does not occur. Only when piping in from a Merge node.

Can you share the buggy workflow?

@Pojo267 just a reminder


ci: Try to make the MSRV job faster

Codecov Report

Merging #36 (9440d57) into main (53ed676) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   86.40%   86.40%
=======================================
  Files           7        7
  Lines         493      493
=======================================
  Hits          426      426
  Misses         67       67


Please split the archive. The size is nearly 500MB! (Save energy, money and time)

Hi
Please  create extra archives for Aspect Ratio mods and Lazy Packs.
Reasoning: Aspect Ratio mods are rarely used and take up the most space. Steam hardware survey shows that ~80% have 16:9 monitors and using 16:9 ratio for 16:10 monitors is fine too. (Interestingly, almost 5% have monitors with a ratio of 683/384. I assume that's the Steam Deck.) And Lazy Packs take up more than 1/5 the space.
This means that in 80% of the downloads 45.4% (208MB) is wasted traffic due to aspect ratio mods! - (and potentially 22.7% (104MB) wasted due to lazy packs.
Assuming there are a couple thousand times more downloads than people watching (44): That might be 88,000 * 312MB = 27.456 TB wasted traffic! (Reasoning: I am one of the few downloaders with a Github account and I don't see a reason for watching any repo.)
This will save energy, money and time.
Kind regards

perhaps you could *.7zip it's 130 MB vs 457 MB ?

Yes, but that's not entirely the point.
Sent from Proton Mail mobile
-------- Original Message --------
On Jul 10, 2023, 04:22, jaycc3000 wrote:

perhaps you could *.7zip it's 130 MB vs 457 MB ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Everything is 7zip in releases
This include more automation and with zip per versions, it's a bit too much releases files.

Just download the 7z archive.

I know this is a closed issue, but just want to point out to the managers of @vasilvestre and me which are available to use, where you can pick what you need


Can not Execute Binary File

I am using preinstalled version. I have chrome installed too but when i try to execute ppfuzz from /usr/local/bin it says binary not executable and when it is placed somewhere else it says command not found. I have also tried chmod +x ppfuzz command but still same error.

What is your environment?  Which file did you download? Please explain as clearly as possible, @awais922609.

I downloaded X64 arch linux pre-built version from this link https://github.com/dwisiswant0/ppfuzz/releases. When I downloaded it I am unable to run it after even installing dependencies. I also change mode to executable. Also tried to clone it but facing same error.

I downloaded X64 arch linux pre-built version from this link https://github.com/dwisiswant0/ppfuzz/releases. When I downloaded it I am unable to run it after even installing dependencies. I also change mode to executable. Also tried to clone it but facing same error.

Attaching a screenshot will be more helpful to replicate your problem.

I have clone it and then build it using this command cargo build --release. I am still getting this error which is shown in image.

I have clone it and then build it using this command cargo build --release. I am still getting this error which is shown in image.

Looks like this is a pre-built file and not compiled from cargo.
If you have done cargo build --release, binary files are in target/release/ppfuzz.

Thanks alot man I found it .


Add integration tests

This is an ongoing work item to add integration tests for the entire library.  Unlike the existing unit tests that spin up a local HTTP server that mimics certain behavior of the API, these integration tests will call against the live GitHub API.  As such, they will likely take a lot longer to execute and will not be run near as often.  I've set things up with aff0a13d884ff5dc09bccb6c1ce081a82213bfab and will continue working from there.
I'm not 100% settled yet on how extensive these tests need to be.  For example, we don't need to test the value of every field in a response.  The biggest goal is to have a test suite that can be run when things like the default media type changes to make sure the library is still working properly.  I also have a separate test suite that I'm working on to identify fields in responses that we aren't mapping into our Go structs.

I am new to go as well as go-github project. I am trying to set up the go repository and was able to run the basicauth example. How are the tests set up? I am unable to test the individual test files here. I am running these tests locally.

I am new to go as well as go-github project. I am trying to set up the go repository and was able to run the basicauth example. How are the tests set up? I am unable to test the individual test files here. I am running these tests locally.

the go repository

What repository exactly?

How are the tests set up? I am unable to test the individual test files here. I am running these tests locally.

The go-github project uses standard Go tests. They're inside the github.com/google/go-github/github package, so running go test github.com/google/go-github/github would run all the tests there.

I am new to go as well as go-github project.

Please see here for the best places to ask Go questions:
https://github.com/golang/go/wiki/Questions

I am sorry for spelling out the repository wrong. I am using the go-github repository.
After cloning the repository, i tried running the integration test cases in the tests/integration folder with GITHUB_AUTH_TOKEN set in environment.
Here is what I did from the GitHub folder
go get -t -v ./...
go test -v ../tests/integration/*
Here is the error I got
../tests/integration/repos_test.go:117: branch.Protection undefined (type *github.Branch has no field or method Protection)
../tests/integration/repos_test.go:121: branch.Protection undefined (type *github.Branch has no field or method Protection)
../tests/integration/repos_test.go:122: branch.Protection undefined (type *github.Branch has no field or method Protection)
../tests/integration/repos_test.go:123: unknown github.RequiredStatusChecks field 'EnforcementLevel' in struct literal
../tests/integration/repos_test.go:126: client.Repositories.EditBranch undefined (type *github.RepositoriesService has no field or method EditBranch)
../tests/integration/repos_test.go:131: branch.Protection undefined (type *github.Branch has no field or method Protection)
../tests/integration/repos_test.go:134: branch.Protection undefined (type *github.Branch has no field or method Protection)
../tests/integration/repos_test.go:135: branch.Protection undefined (type *github.Branch has no field or method Protection)
../tests/integration/repos_test.go:139: branch.Protection undefined (type *github.Branch has no field or method Protection)
../tests/integration/repos_test.go:140: branch.Protection undefined (type *github.Branch has no field or method Protection)
../tests/integration/repos_test.go:140: too many errors
FAIL	command-line-arguments [build failed]
Is the integration folder broken, can i raise an issue and try to solve?

I am sorry for spelling out the repository wrong. I am using the go-github repository.

No problem, I just wanted to make sure I'm not misunderstanding you.

Is the integration folder broken, can i raise an issue and try to solve?

Yes, it is. Please do. Open a new issue, and feel free to work on a PR to resolve it. The integration tests are run manually, so they got out of date after some breaking API changes in the library. Thanks!
By the way, don't forget to read over the integration tests README. You should run them with -tags=integration, instead of specifying individual .go files via *.
(Also, feel free to review PR #506 since it's related.)

Possibly related to: https://github.com/google/go-github/issues/310#issuecomment-894425615


[CORE] Upgrade Custom Elements version

Please review if #856 missed update of these files.

Messy. Hope that a0ee741 should be enough for review.

close this PR, will open separate PRs later.


🚀 Feature: Discord Embeded Application

🔖 Feature description
A command to start a custom discord embeded application.
Example:

Watch youtube videos with  your friends in any discord vc
Play chess with your friends in any discord vc

🎤 Pitch
I think this feature will help users be more interactive in discord voice channels. And users might use this to make their server more active.
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

Yes I would like to be assigned to this task.
I would like to work in the development environment
I would also like to know which folder/cog should I add this command to (If I was assigned this task)

Ok go ahead. The folders should be game and general respectively.


feat: add when constraint

Not ready for review yet. I haven't even started. Just fixed the typings and added a test
I'll finish it after my exams. In the meantime, if anyone else is interested then u can create a pr and I'll close this one
The code is ready for review. It works but some code styles need fix suggest changes.
TODO:

[ ] Add tests. Lots of tests
[ ] Optimize typings if possible

Codecov Report
Base: 99.35% // Head: 99.24% // Decreases project coverage by -0.10% :warning:

Coverage data is based on head (9698bd6) compared to base (ef17e9a).
Patch coverage: 94.11% of modified lines in pull request are covered.

:exclamation: Current head 9698bd6 differs from pull request most recent head 9e14feb. Consider uploading reports for the commit 9e14feb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   99.35%   99.24%   -0.11%
==========================================
  Files          57       59       +2
  Lines        3397     3464      +67
  Branches      811      827      +16
==========================================
+ Hits         3375     3438      +63
- Misses         13       15       +2
- Partials        9       11       +2

Impacted Files
Coverage Δ

src/constraints/ObjectConstrains.ts
88.57% <88.57%> (ø)

src/constraints/util/getObjectValue.ts
100.00% <100.00%> (ø)

src/lib/errors/BaseConstraintError.ts
100.00% <100.00%> (ø)

src/validators/BaseValidator.ts
100.00% <100.00%> (ø)

src/validators/ObjectValidator.ts
97.87% <100.00%> (+0.01%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Roll Flutter Engine from 5cd5b13779fd to 98ba80097eb5 (1 revision)

https://github.com/flutter/engine/compare/5cd5b13779fd...98ba80097eb5
2023-05-30<EMAIL_ADDRESS>[Impeller] Bias towards sampling from lower mip levels (flutter/engine#42386)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


[WIP] Add support for Jottacloud

Summary
This is my work adding support for Jottacloud as requested in #307. The basic Interfaces are implemented and working but there are still some things to do.
Some open stuff.
The Jottacloud API situation:

Jottacloud does not publish any documentation on there API but they do seem to allow API usage. Therefore I mostly used the implementations in havardgulldahl/jottalib and albertony/jafs as reference.
I'm only using the https://www.jottacloud.com/jfs/ API (this one is somewhat documented in there forum) even tough there seems to be newer API on https://api.jottacloud.com/files/v1 but so far only their own jotta-cli tool uses it and it's not documented anywhere.
In fact there seems to be a third api https://www.jottacloud.com/rest/webrest.
None of these API's seem to implement all the functions.

What's left to do

[x] Add config opions for device and mountpoint
[x] Implement the optional Purger, Copier, Mover, DirMover interfaces
[x] Maybe look into the newer upload API
[ ] Cleanup

On a final note this is pretty much the first time I have written anything in go so there may be some mistakes / bad practices in here.

That is looking really good :-)
The tests are failing because errcheck is failing due to Sprintf parameters.
You can use
 make build_dep

To install the checkers locally
Then
 make check

To run them.
What is the status of the integration tests? Are they passing?
If you can get the tests passing then I'll give it a review and try it locally.
Well done getting this far, it is a lot of work.

I implemented the Purger, Copier, Mover, DirMover interfaces. Current implementation is kind a redundant will still be simplified. All unit tests pass however the TestCopyFile integration test fails if run together with the other tests (It does pass if run on it's own). This seems to be a problem with how Jottacloud handles deleted files. If I find some free time I'll look into it tomorrow. Everything else should be in a reviewable state and some manual testing could also be done.

@buengese I made a local build and tried it, however it fails on,
2018/08/04 10:35:39 Failed to create file system for "jcloud:/test": couldn't get account info: strconv.ParseUint: parsing "-1": invalid syntax
Seem's to be related to username which looks like get-12345678 (and I also tried<EMAIL_ADDRESS>with the same result)

@jkaberg It's fixed. Didn't expect negative values there.

Seem's to be working as expected (copy, move etc), haven't tried mount or anything more advanced but I will soon enough 😄
Well done @buengese!

An impressive piece of work - thank you!  And most importantly it works! I ran some tests by hand copying things about and it worked very well.
The unit tests pass.  The operations test pass.  The sync tests give one test failure which seems repeatable
~/go/src/github.com/ncw/rclone/fs/sync$ go test -v -run TestServerSideCopy -remote TestJottacloud:
=== RUN   TestServerSideCopy
2018/08/06 19:22:11 ERROR : sub dir/hello world: Failed to copy: copy failed: Error 404: no.jotta.backup.errors.NoSuchPathException: Destination parent path /8vopdox6wjnjmz3l0mfiitae/Jotta/Sync/rclone-test-lofokod4weqesez0yuyaduv1/sub dir does not exist (Not Found)
2018/08/06 19:22:11 purge failed: directory not found
--- FAIL: TestServerSideCopy (7.17s)
	run.go:173: Remote "jottacloud root 'rclone-test-wuxaqog6sazecah5fitalav2'", Local "Local file system at /tmp/rclone454131250", Modify Window "1s"
	sync_test.go:118: Server side copy (if possible) jottacloud root 'rclone-test-wuxaqog6sazecah5fitalav2' -> jottacloud root 'rclone-test-lofokod4weqesez0yuyaduv1'
	require.go:794:
			Error Trace:	sync_test.go:121
			Error:      	Received unexpected error:
			            	Error 404: no.jotta.backup.errors.NoSuchPathException: Destination parent path /8vopdox6wjnjmz3l0mfiitae/Jotta/Sync/rclone-test-lofokod4weqesez0yuyaduv1/sub dir does not exist (Not Found)
			            	copy failed
			            	github.com/ncw/rclone/backend/jottacloud.(*Fs).Copy
			            		/home/ncw/go/src/github.com/ncw/rclone/backend/jottacloud/jottacloud.go:538
			            	github.com/ncw/rclone/fs.(Copier).Copy-fm
			            		/home/ncw/go/src/github.com/ncw/rclone/fs/fs.go:527
			            	github.com/ncw/rclone/fs/operations.Copy
			            		/home/ncw/go/src/github.com/ncw/rclone/fs/operations/operations.go:269
			            	github.com/ncw/rclone/fs/sync.(*syncCopyMove).pairCopyOrMove
			            		/home/ncw/go/src/github.com/ncw/rclone/fs/sync/sync.go:306
			            	runtime.goexit
			            		/opt/go/go1.10/src/runtime/asm_amd64.s:2361
			Test:       	TestServerSideCopy
FAIL
exit status 1
FAIL	github.com/ncw/rclone/fs/sync	8.898s

So I would say, bar a few little cleanups and fixes the code is done :-)
So looking at the writing a new backend checklist I'd say you've got down to the part beginning "Add your fs to the docs..." so nearly done!
Let me know if you want any help with anything.
I'm hoping we can land this in time for the 1.43 release at the end of the month.

I've looked through all that - and it looks really good - well done!
The failing test passed when I tried it.  I don't know whether you fixed it or whether it is to do with this (from the docs).

Jottacloud exhibits some inconsistent behaviours regarding deleted files and folders which may cause Copy, Move and DirMove operations to previously deleted paths to fail. Emptying the trash should help in such cases

I'm going to merge this now.
You can see the daily integration tests run here: https://pub.rclone.org/integration-tests/ - so we can keep an eye on what happens there
If you'd like to be added to the project as a maintainer then drop me an email to<EMAIL_ADDRESS>to discuss.
Thank you very much for a great contribution :-)


GITHUB_ACTION: __self isn't documented

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables
What part(s) of the article would you like to see updated?

The name of the action currently running, or the id of a step. For example, for an action, __repo-owner_name-of-action-repo. GitHub removes special characters, and uses the name __run when the current step runs a script without an id.

Additional information
https://github.com/check-spelling-sandbox/sub-actions-0/actions/runs/7790252174/job/21243707001
GITHUB_ACTION: __self

@jsoref Thanks for opening this issue! I'll get this triaged for review ✨

Personally I'm not too worried about this. I'm wondering whether this will complicate the docs. I would advise against depending on generated default IDs. If customers want stable/predictable IDs then I would suggest explicitly setting IDs. Unless there is some existing patterns or use cases I'm overlooking. Thoughts?

@ericsciple Thank you weighing in here! It sounds like we would prefer not to document this 💛 I'll go ahead and close out this issue.


Add GameBox engine

SteamDB app page links to a few games using this

Trackmania
Trackmania² Lagoon
Trackmania® Turbo
TrackMania² Valley
TrackMania² Stadium
TrackMania² Canyon
TrackMania Nations Forever
Trackmania United Forever

Brief explanation of the change
Find Nadeo.ini

After running changed rules in this pull request (this bot only tests rules.ini changes):
Changed technologies: Engine.GameBox
These apps now match: (16) 7200 11020<PHONE_NUMBER>70<PHONE_NUMBER>50<PHONE_NUMBER>60<PHONE_NUMBER>50<PHONE_NUMBER>00<PHONE_NUMBER>20<PHONE_NUMBER>070
Please confirm that all these changed apps are correct.


Fix incorrect question-mark replacements in parser.rs

Build failed because of #61.

r=me once #63 lands.


Uppercase letters in domain names can cause issues

Even though the domain names are case insensitive, database may contain values which contain uppercase letters.
This is not being handled in PowerDNS Admin interface right now.
Displaying such zone would cause all records to also have zone name in the record (instead of '@').
Stripping fails due to records not being uppercase, while zone is.
If you change and commit those records to PowerDNS it would then append zone name again to the records.
Example zone:
www  CNAME  Active  3600  example.com
@  A  Active  3600  <IP_ADDRESS>

When it is in database noted as 'Example.com' instead of 'example.com' it would be displayed like this:
www.example.com  CNAME  Active  3600  example.com
example.com  A  Active  3600  <IP_ADDRESS>

After adding record and refreshing domain names would get corrupted:
www.example.com.example.com  CNAME  Active  3600  example.com
example.com.example.com  A  Active  3600  <IP_ADDRESS>
new.example.com  A  Active  3600  <IP_ADDRESS>

This should be easily fixed by first converting zone name to lowercase on stripping.
Even though it is not expected to have zones in uppercase in the database, I think interface should not corrupt the zone if it appears.

Hey Thomas,
The issue is, if database contains domains with uppercases, this will not be handled correctly in PowerDNS Admin.
Most likely fix is to convert everything to lowercase prior to actually parsing and constructing the UI.
Please let me know if this doesn't clarify the problem.
Kind regards,
Momo.

Hi, I've tried to reproduce the issue. Steps I've done:

Create new Domain "Test.com"
Manage Domain and add A-record test1 -> <IP_ADDRESS>
Save and Apply Changes
Refresh Domain (F5)

My new a-record is not suffixed by test.com.
Am I doing right reproducing the issue? Which pdns-version do you use?


Allow custom password rules

With one setting, allow to set the rules for the password.
Closes #35

Thank you very much. I think this is a good idea. It would be incredibly helpful if you could write a test to verify it works as expected under user.spec.js.

Very sorry for the delay, got distracted by other projects.
I updated the test to reflect the changes.

Thank you very much @micky2be ... You have been a huge help to this project!!!

Did this ever make it into a release? running 0.6.1 it doesn't seem to be working


Stops after lit houses on first block if you don't have a single item outfit for dark houses.

Another thing which is easily fixable if you know what the issue is (as in, have read the README.MD) but I found that on a new account which I hadn't already purchased a single item outfit (e.g. beholed bedsheet) it looted the lit houses in the current block then stopped as if it were done without any error message or warning etc.
Perhaps printing a list of acceptable items with current mall_price of each and telling the user why it's stopping would be a more user friendly experience for less technically savvy users.

It should try to buy one; was the price too high for your autoSatisfy setting?:


Added Alerts to several response structs

What does this PR (Pull Request) do?

Adds the Alerts struct to several response structs.
In addition, several response structs were added where needed.

[X] This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

Traffic Control Go Client

What is the best way to verify this PR?

Run Traffic Ops API Tests
Run Go Client tests
If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

[X] This PR includes tests OR I have explained why tests are unnecessary
[X] This PR includes documentation OR I have explained why documentation is unnecessary
[X] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[X] This PR includes any and all required license headers
[X] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[X] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Why'd you add all those new structures? They aren't used anywhere as far as I can see.

They will be used when testing the multiple federation routes.

But you didn't add them to any tests?

No, they'll be useful in replacing the similar structures that exist in the internal tests. We wouldn't need to redeclare them, because we could use the ones declared here.


Paper-item inside core-menu freezes ripple effect item change

Hello,
I was trying to use core-menu and paper-item together like this:
<template is="auto-binding">

In a core-menu ({{route}})

        <paper-shadow>
            <core-menu selected="{{route}}" valueattr="hash">
                <template repeat="{{ item in items }}">
                    <paper-item hash="{{item.hash}}">{{item.description}}</paper-item>
                </template>
            </core-menu>
        </paper-shadow>

    </template>

But the the ripples get stuck when changing from item to item, if I then click the item once more, the ripple effect starts to work correctly.

Am I using this wrongly?
Here's an example of it happening inside the very demo.html inside components/paper-item/
Please let me know what's going on.
Thanks!
Update!
If the core-selector is populated statically instead of using <template repeat="{{item in items}}"> then ripple and valueattr work perfectly, the iteration of items is somehow messing with upAction. This could be another workaround for other people.

Closing this issue due to age and the release of version 1 of Polymer - please feel free to re-open if this is incorrect.


ConnectionNotFound or bad routing results close to the border of the map.

I ran into some cases where the edge-based routing did not find a path close to the 'border' of the graph.
For example this: http://localhost:8989/maps/?point=48.250955%2C13.033712&point=48.252921%2C13.023304&locale=en-US&vehicle=car&weighting=fastest&elevation=false&edge_based=true&use_miles=false&layer=Omniscale
does not find a connection on bayern-140101.osm.pbf (for different algos dijkstra/astar ch/non-ch does not matter). With edge_based=false a route is calculated, but it is rather useless:

Not sure if anything can or needs to be done about this. The only thing that came to my mind is that we do a connectivity check in PrepareRoutingSubnetworks, but it does not pay attention to turn restrictions.

Oh, this is indeed tricky and as you say: to fix this we would have to do the PrepareRoutingSubnetworks with considering the turn restrictions. Not that this is not possible but maybe the benefit is too low to justify the slower preparation?

Not that this is not possible but maybe the benefit is too low to justify the slower preparation?

Yes I agree :) Especially because then we would get a bad route similar to the one in the screenshot instead of ConnectionNotFound. I was thinking if there is a way to detect/warn if a from/to point is (too) close to the border, but no idea really.

I mean 'bad route' depends on the way of thinking. Assuming that the map in use is the graph we are routing on it is not a bad route, but still can be somewhat unexpected if one does not have in mind that the graph 'ends' somewhere.

If the roads would be not reachable with turn restrictions we make them inaccessible in PrepareRoutingSubnetworks, so this would result in a different snapping but the route would probably be ok (as snapping could be 1km away)

can be somewhat unexpected if one does not have in mind that the graph 'ends' somewhere.

would it be feasible to draw the polygon that represents the border of the graph (should be similar to how the polygons are obtained in isochrones) ? could be useful at least for debug view (#1572). the bounding box can be misleading with this regard.

would it be feasible to draw the polygon that represents the border of the graph (should be similar to how the polygons are obtained in isochrones) ?

The algorithm of the isochrones can't be used as it currently does not scale to large areas. But #1572 would solve the issue already without such a polygon (?)

But #1572 would solve the issue already without such a polygon (?)

Oh yes ;) sure if we see the graph no need to draw a border :D


feat: add flake with mycelium package

add a flake.nix to package the mycelium binary. with a flake-compat layer consisting of {default,shell}.nix
add a rudimentary job to the CI workflow that builds the package

I have no experience with nix flakes, so I'll assume this is good. I just have one question after skimming through this.

I have no experience with nix flakes, so I'll assume this is good. I just have one question after skimming through this.

WDYT about building the package exposed by the flake on CI? it could also run the tests. if they don't require WAN access they will most likely just work. if they do we'd have to change a few things so they can reach WAN.

I'm all for adding it to CI, right now tests don't really use networking (some tests create peers but those use an in memory connection). Some more in depth tests will probably be added later which do create sockets and connections, but even then I'd say those will only be local to eachother.
To make sure we are on the same page, you mean adding an entirely new CI workflow which builds the package and then  runs the tests, next to the current one which just runs the tests, right?

Can you include https://github.com/nix-community/flake-compat, so this is accessible for people who use Nix, but who don't have flakes enabled? It's still an experimental feature, after all ;-)

Can you include https://github.com/nix-community/flake-compat, so this is accessible for people who use Nix, but who don't have flakes enabled? It's still an experimental feature, after all ;-)

added! it's not covered by CI as is, so i'd appreciate if i could rely on you as a reviewer :slightly_smiling_face:

Seems there is a linker error on darwin for ring: note: ld: library not found for -liconv. Possible missing dependancy?

I was able to invoke nix-build -A outputs.packages.x86_64-linux.mycelium and nix-build -A outputs.packages.aarch64-linux.mycelium, and nix-shell also worked.

Thanks


Some confusing wording and my suggestions

I have read this book recently, it is good, but a little wording seems to be confusing to the reader, so I sent my comments here for improvement.

and there are never any unencrypted QUIC connections. in feature-tls.html
This sounds a bit like there is no plaintext messages, even if it is a handshake message. I understand it is saying there is no leak of the transmitted data.

official QUIC protocol in proc-status.html
I understand the Google's QUIC protocol is proprietary, but it is popular and used, so the "official" is confusing, The used The IETF QUIC protocol may be better.

Based on UDP it also then uses UDP port numbers to identify specific servers on a given machine. in feature-udp.html
"specific servers on a given machine." is a less obvious concept, I used to think that it said "services", but it may also be saying that the servers is behind a NAT router. Maybe it can be said "identify specific servers behind a given address."?  Or it's my problem, I first think of the servers as a host rather than running server software behind a port.

Version negotiation in quic-connections.html
This mechanism seems similar to the TLS handshake, but as a general reader, I can't quite understand why and how to select the protocol version from the client.

Back then, QUIC was still claimed to be an acronym for "Quick UDP Internet Connections", but that has been dropped since then. in proc.html
I hope it provides a reference as it seems not easy to find.

feature-http.md and h3.md have the same subtitles, although they have different directorie (SUMMARY.md) titles.

In quic-connections.html, change the "wifi" to "Wi-Fi", "download" to "downloads"? I am not sure.

It means that all QUIC connections are encrypted and secure. There are no clear-text/plain-text versions like for TCP (and HTTP/1 and HTTP/2). As mentioned somewhere, there are one or a few unprotected packets in the early handshake, but this sentence speaks of connections.

Agred. Will update.

Services it is then. I checked and the wikipedia article on "port" says "network services".

New version:

Based on UDP it also then uses UDP port numbers to identify specific network services on a given IP address.

A user would probably never select QUIC version, but there might still be implementations that implement multiple versions and thus can use one out of of several available.

I suppose that can be explained a bit better...

I hope it provides a reference as it seems not easy to find.

QUIC is a name, not an acronym

why the first request from the client is not belong to requesting the supported versions list

You're here asking why the protocol is defined to work as it is, and that's a question for the QUIC working group. This document explains exactly how it works and what is defined in the QUIC drafts. I actually have not seen the exact discussion that led up to this specific design. If you read the draft and think the current explanation isn't doing it justice, then please let us know.


Create default environments on openapi import using server url

Fixes: #1239
Closes PRs: #1240, #2261

Instead of separate variables protocol and host, this change creates a single environment variable basePath
Loops through all server urls and create environments for each of them separately
Creates environments using the server description if that doesnot exists creates environment as Environment 1(2, 3, ...)

https://github.com/user-attachments/assets/b45b1cb8-99bd-4576-984f-d5603159c051

Looks fantastic, so I can finally use OpenAPI imports with Bruno. Up until now this missing piece is the one major pain point and the reason why I never really used Bruno since I purchased it months ago. Thanks for working on it 👍

@helloanoop this PR was supposed to close #2261 - see initial description - but it is still open


Unicode Encode Error

the issue and its solution:
UnicodeEncodeError: 'latin-1' codec can't encode character '\u2026' in position 116: Body ('…') is not valid Latin-1. Use body.encode('utf-8') if you want to send it encoded in UTF-8

I was running into a similar issue but the error was about utf8 encoding. My workaround was to use iconv to clean the file of non-utf8 characters as outlined here: https://www.baeldung.com/linux/remove-non-utf-8-characters


Add the GitHub pages site

I'm creating this as a draft because I need to get your feedback but it's basically done at this point. Ignore the outdated docs directory, all that needs to be changed is the bit of metadata at the top of each file. I also haven't verified that the github action is right, it would be great if you could review or test that somehow (not too familiar with that stuff)

Also I want to add that post-writer page with the verbose mode stuff to this site, shouldn't take very long though I might have to do a little refactoring


Edit node after creation with sort plugin enabled

I have this code:
tree.jstree("create_node", "#", obj, "last", (function(node) {
    tree.jstree("edit", node);
}).bind(this));

The idea is to let the user create a node and edit it inline inside the tree. Works fine but when I enable the sort plugin it stops working.
I guess because the thing goes this way:

Node created.
callback fired, so edit is called.
sort detects the addition, so reorders, breaking the edit.

Is there a better way of editing a node right after creating it?

Add a setTimeout to the mix. - wrap the .edit call in a setTimeout(function () { ... }, 0). I will try to improve on this in v.4, but for now it should work properly.

Ok, I'll try it. Thanks.


demo: arxiv summarizer

build a chat application that can summarize the latest papers for a given area

to begin with, let's focus on computer science papers
arxiv has some paper taxonomy,perhaps we can use it to select sub areas of CS (e.g., AI/ML)
once the user selects an area  we can display the abstracts for the most recent papers
we can produce a 1-2 sentence summary by passing the abstract through OpenAI
then users can ask other questions like: please tell me more about paper X, or give me alink to download paper Y

some code to get started: arxiv.ipynb.zip

you can use this as an example: https://github.com/ploomber/doc/blob/main/examples/panel/rag-news/app.py
but let's use solara for this one.
and here's a tutorial that I wrote on RAGs: rag.ipynb.zip
we can use function calling to do this: https://platform.openai.com/docs/guides/function-calling

btw, let's get this one done without any RAG libraries (just the openAI API), they often add a lot of dependencies and make the deployment process clunky.

some feedback:

allow typing enter to send the message
move chat box to the bottom
instad of "AI system" let's but "Built by Ploomber" and link to our website
order of messages is inverted, most recent ones should appear at the bottom
change the title from "Scientific Artcicle Chat" to "Arxiv Chat"
asked: is there anything new on LLMs?

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/reacton/ipyvue.py", line 23, in handler
    callback_ref.current(*args)
  File "/usr/local/lib/python3.11/site-packages/solara/components/button.py", line 84, in <lambda>
    ipyvue.use_event(btn, click_event, lambda *_ignore: on_click and on_click())
                                                                     ^^^^^^^^^^
  File "/srv/chat.py", line 115, in ask_chatgpt
    for new_message in oc.article_chat(input):
  File "/srv/ai.py", line 182, in article_chat
    content = self.call_tool(function_call)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ai.py", line 143, in call_tool
    content = getattr(self, func_name)(args)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ai.py", line 95, in get_authors
    article = self.get_article_by_title(arguments["title"])
                                        ~~~~~~~~~^^^^^^^^^
KeyError: 'title'

asked: tell me about the most recent cryotpgraphy papers (tip: use tiktoken to count the tokens to prevent this), also happened when doing "tell me about the most recent ML papers"

got:
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/reacton/ipyvue.py", line 23, in handler
    callback_ref.current(*args)
  File "/usr/local/lib/python3.11/site-packages/solara/components/button.py", line 84, in <lambda>
    ipyvue.use_event(btn, click_event, lambda *_ignore: on_click and on_click())
                                                                     ^^^^^^^^^^
  File "/srv/chat.py", line 113, in ask_chatgpt
    load_articles_from_topic_query(input)
  File "/srv/chat.py", line 103, in load_articles_from_topic_query
    for new_message in oc.article_chat("Summarize each article in a sentence"):
  File "/srv/ai.py", line 157, in article_chat
    response = self.client.chat.completions.create(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/openai/_utils/_utils.py", line 271, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/openai/resources/chat/completions.py", line 659, in create
    return self._post(
           ^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/openai/_base_client.py", line 1200, in post
    return cast(ResponseT, self.request(cast_to, opts, stream=stream, stream_cls=stream_cls))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/openai/_base_client.py", line 889, in request
    return self._request(
           ^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/openai/_base_client.py", line 980, in _request
    raise self._make_status_error_from_response(err.response) from None
openai.BadRequestError: Error code: 400 - {'error': {'message': "This model's maximum context length is 4097 tokens. However, your messages resulted in 4557 tokens (4411 in the messages, 146 in the functions). Please reduce the length of the messages or functions.", 'type': 'invalid_request_error', 'param': 'messages', 'code': 'context_length_exceeded'}}


[Bug Title here]

What happened?
After clicking on let's go in register section form is get submitted without even entering any infromation
form should not be submitted without entering a information
How can we reproduce this bug?
we can remove this error by making a filed of form compulsory
Desktop Information (Optional)
No response
Urgency (Optional)
High priority
Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Issue assigned already before


Automate deployment and config updates

This is low priority.
We could leverage Github Actions and Github Variables to dynamically update the config file from Github. This means we won't have to SSH into the server and update the config.

See https://mainawycliffe.dev/blog/github-actions-trigger-via-webhooks/
We could setup a custom webhook that triggers a gh action run when the variables get changed


amazonec2 security-group option confusing

We use Terraform to stand up our AWS infrastructure, and as such, can pre-provision the security group and rules that we want to enforce.  docker-machine's amamzonec2 driver does have an option to pass the security group information.  However it is by NAME, not by ID, and that was not intuitive (as most other options use the ID) nor obvious (the help text is technically correct, but could be interpreted incorrectly if you are expecting to use ID).
Personally, I'd prefer to pass the ID, not the NAME, but I'm somewhat ambivalent, now that I know what the driver is looking for.
It would be nice to change to using by ID, but at least maybe this issue report will help someone debug the same issues that we ran into today.  :)

Related issue,  we don't allow end users to modify security groups. As such docker-machine wants to open ports to <IP_ADDRESS>/0.  docker-machine will fail if the docker-machine group already exists and has a more restrictive ruleset.

Does this issue have any eta for resolution? It's making it extremely difficult to automate autoscaling gitlab runners in aws since cloudformation only allows you to reference security group ids, not the name.


feat(gui): Add ability to read settings from a config file

This adds the capability to configure settings via a .etcherrc file,
either in the user's home directory, or the current working directory.
The defined settings are merged with localStorage settings, and preceding
configuration files.
If both are present, the current working directory takes precedence.
Change-Type: minor
Changelog-Entry: Add support for configuration files
Connects To: #1356

It would be nice not to put files directly in the users home directory.
We should use ~/.config/etcherrc on Linux (XDG) and equivalents on other platforms.

Also if it's a json file, we could keep the .json extension.

There are some linting problems left.


More RTD fixes

More fixes to keep theme loading from happening when being processed by RTD.

Seems logical :+1:


Docstring for TiledView indicates a optional data type

Thanks for the package.
However, I saw in the docstrings
TiledView([T], data::F, tile_size::NTuple{N,Int}, tile_overlap::NTuple{N,Int}; pad_value::T)

which apperently doesn't work.
You might also change rel_overlap in the docstring.
Cheers,
Felix

Thanks for the hint. Indeed the [T] was wrong and several smaller things were not documented correctly. Should be OK now.


UIPFPAT-16: Packages/Titles: multiple tag and access status type selections are being AND' and not OR'd

Description

Fix formatting of Tags, Access Types and other filters for search
Hide Tags and Access Types filters for Titles

Issue
UIPFPAT-16

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-plugin-find-package-title/job/PR-42/1/

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-plugin-find-package-title/job/PR-42/1/

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-plugin-find-package-title/job/PR-42/3/

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-plugin-find-package-title/job/PR-42/3/

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-plugin-find-package-title/job/PR-42/4/

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-plugin-find-package-title/job/PR-42/4/

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-plugin-find-package-title/job/PR-42/2/

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-plugin-find-package-title/job/PR-42/2/


osbuild2: update cloud-init stage with new options

Related to: https://github.com/osbuild/osbuild/pull/866/
This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

We had a discussion recently about doing the option validation in the NewXStage() constructor instead of the MarshalJSON() method. #1785

Yeah, I read that one. Actually that's why I created all those validate() functions, so that I can call it in the NewXStage. Just forgot to actually call it :facepalm:

@achilleas-k Please have a look again. I wasn't sure whether to leave the validate() calls in the MarshalJSON functions or not. Right now the constructor as well as the marshalers call the functions, but it is a lot of boilerplate code. If we are ok with removing the validation from marshalers, we can remove a lot of lines and call the validation recursively (I didn't want to call validate() on internal variables in all the structures, because MarshalJSON calls MarshalJSON for every internal variable and in turn it calls validate())

Looks good.  Having a nested/recursive validate() call that starts from the NewStage() is much nicer I think.  Let's clean the custom marshallers, which should also remove the need for the type aliases.  The whole thing should look much cleaner then.

I agree. The PR is updated and simplified now :-)


Add fields and update status of custom resources to keep user informed

This only applies to node pools at the moment, because observations and decisions have been removed in v0.7.0.

Node pools have been removed in v0.8.0 and the new pod chaperons get status updates from their respective pods.


Visual Desginer for creating/ updating Workflow

Visual Designer for creating/updating workflows with drag drop feature for tasks and wiring connections.

I am also interested in this feature, let me know if anyone is wanting to pick it.

This is a big undertaking but indeed possible! It would require creating an IDL, format and persistence for these features.
Next step for this would be to create a proposal document:
https://github.com/uber/cadence/blob/master/PROPOSALS.md (currently the template has a broken link)
Proposal document is a simple document with the following sections:
Proposal: [Title]
[Author] [Date] [Links to discussion]
Abstract
Background
Proposal
Rationale
Implementation
Open issues (if applicable)


Add a title to "My Wallet" page

V2 designs have page title for "My Wallet" and "Discover". For the moment, only the page "Discover" has a title. We need to add one to the "My Wallet" page : https://www.figma.com/file/gNQ9POVTHhxZQbzRQl6Qks/Altme?node-id=2436%3A8110

to be discussed as the information part of the screen is quite small. We cannot display more than 6 credentials or 6 NFTs at the moment

Size: M


Download from muzu.tv fails in some cases

Hi and thanks first for your great work you done on youtube-dl!
Unfortunately, muzu.tv has been documented as a supported site but fails some times. I. e. http://www.muzu.tv/5-seconds-of-summer/she-looks-so-perfect-musikvideo/2175408 or http://www.muzu.tv/kylie-minogue/sexercize-musikvideo/2185057 ends  in an error 404; with other targets like http://www.muzu.tv/mr-probz/waves-musikvideo/2162365 it works well.
Here are the details of a failed download:
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', 'http://www.muzu.tv/kylie-minogue/into-the-blue-musikvideo/2161323']
[debug] Encodings: locale 'UTF-8', fs 'utf-8', out 'UTF-8', pref: 'UTF-8'
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 3.4.0 - Linux-3.13.7-1-ARCH-x86_64-with-arch
[debug] Proxy map: {}
[muzu.tv] 2161323: Downloading video info
ERROR: Unable to download webpage: HTTP Error 404: Not Found; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
File "/usr/lib/python3.4/site-packages/youtube_dl/extractor/common.py", line 194, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 1198, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib/python3.4/urllib/request.py", line 461, in open
response = meth(req, response)
File "/usr/lib/python3.4/urllib/request.py", line 574, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib/python3.4/urllib/request.py", line 499, in error
return self._call_chain(*args)
File "/usr/lib/python3.4/urllib/request.py", line 433, in _call_chain
result = func(*args)
File "/usr/lib/python3.4/urllib/request.py", line 582, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
Hope you are able to solve this problem, and thanks in advance.
Martin.

muzu.tv seems to have shutdown in october 2015. We should close this issue

Yeah. Thanks!


sodium_memzero() - removed invalid param $length

http://php.net/manual/function.sodium-memzero.php

Thanks for noting this problem!
Please note, that we use Travis continuous integration and this PR have failed checks.
In this case reflection based test fails cause for some reason ReflectionFunction("sodium_memzero")->getParameters() returns two parameters but really it accepts only one.
We need to mute this problem till we find a better way to test stubs signatures or till reflection bug will be fixed. Please, add sodium_memzero to tests/mutedProblems.json with problem "parameter mismatch" to fix failed test.
Please, remove commit 59d684e with .gitignore, it's better to solve one problem per PR.

ahrg. i should learn to create branches instead of pushing to master... i'm gonna do this again in a clean fork. brb.


SHELLCHECK_OPTS is not passed to docker

I wrote an issue about enabling use of .shellcheckrc file in actionlint but then I was informed that SHELLCHECK_OPTS should work just fine. Unfortunately this env var is not passed by this action to docker container.
Maybe you could consider adding -e SHELLCHECK_OPTS to docker run or add input parameter to action and pass it as -e SHELLCHECK_OPTS="${{ inputs.shellcheck_opts }}" or something like this?
Thank you :pray:

Fixed by releasing it as v0.1.3. Thanks @piotrekkr !


[AMORO-1716] [Improvement]: sort the table list returned by server

Why are the changes needed?

Close #1716
Brief change log

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.chenyuzhi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@chenyuzhi459 You may need to sign NetEase's CLA before you start to contribute to Amoro, you can conveniently complete the signing via the link: https://cla-assistant.io/NetEase/amoro

@chenyuzhi459 You may need to sign NetEase's CLA before you start to contribute to Amoro, you can conveniently complete the signing via the link: https://cla-assistant.io/NetEase/amoro

done


Fix doc build

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Unable to moon publish package due to timeout error

I was trying to publish the initial version of this package:
https://github.com/gmlewis/moonbit-fonts/releases/tag/v0.1.0
but got a timeout error when running moon publish:

I made three attempts, all of which failed.

Never mind, I've decided to break up this huge repo into separate font packages.
Closing.


Add sltsheryl skeleton PPP

Fixes #16.
Add skeleton PPP.
Details to be filled up are temporarily placed with placeholders.

Codecov Report

Merging #31 (1373d9a) into master (6158a44) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add List and Delete Task feature (command line only)

Reviewer. Please note that there was a bug in the equals method for task description class. Also, there was no implementation for the equals method in the task priority class. I have fixed those bugs. Please merge those fixes into the main repo.

Coverage increased (+0.6%) to 81.334% when pulling e8adad744a1c9d260e571d0b9009f60bc1f9c03a on lancehaoh:master into cb1158bc66ab48c11066e3f0af7abc30f5db3094 on CS2103AUG2017-W11-B1:master.

Coverage increased (+0.6%) to 81.334% when pulling 02c17fbecfc78793580f7d5674666df062eca3d9 on lancehaoh:master into cb1158bc66ab48c11066e3f0af7abc30f5db3094 on CS2103AUG2017-W11-B1:master.

As suggested by Ms Anita,  a name from a third party is recommended to be used in your figures to give examples, if the teammate's name is used without consent. This is to avoid discomfort when demo or present the project. I would be greatly appreciative if you can make a change. 😉

Fixed. Sorry about that.

Coverage increased (+0.6%) to 81.334% when pulling cb1a29c7e8b733db82601a05b41c7aaf7cb27b82 on lancehaoh:master into cb1158bc66ab48c11066e3f0af7abc30f5db3094 on CS2103AUG2017-W11-B1:master.


Working with BulkDataExchangeService throws Guzzle [Guzzle\Http\Exception\ServerErrorResponseException] Server error response [status code] 500

Hello,
im using your Library since several months but now suddenly i get a Response and i dont know how to debug it.
Exception:
[Guzzle\Http\Exception\ServerErrorResponseException]
  Server error response
  [status code] 500
  [reason phrase] Internal Server Error
  [url] https://webservices.ebay.com/BulkDataExchangeService

Code:
$exchangeService = new BulkDataExchange\Services\BulkDataExchangeService(array(
					    'authToken' => $config[$config['current']]['usertoken'],
					    'sandbox' => $config['current'] == 'sandbox'
					));
					$transferService = new FileTransfer\Services\FileTransferService(array(
					    'authToken' => $config[$config['current']]['usertoken'],
					    'sandbox' => $config['current'] == 'sandbox'
					));
					$merchantDataService = new MerchantData\Services\MerchantDataService();

$request = new BulkDataExchange\Types\GetJobsRequest();
					$response = $exchangeService->getJobs($request); -> throws exception

Looking at the exception is appears that you are connecting to the production server https://webservices.ebay.com/BulkDataExchangeService. Make sure that the credentials that you are passing to the SDK are correct for that environment as passing the wrong ones, i.e. your sandbox credentials,  can trigger the eBay error.

im sending the right ones and it worked with them until yesterday

forget it... it Expired yesterday and that was the only problem... I wish eBay would send a better Error to catch that exception

Interesting to know that it also triggers on an expired token as I've never come across that.

I may look at seeing if I should have the SDK not throw an exception for a 500 status code. It would allow people to obtain the error message from eBay.

It is possible to catch the exception thrown by Guzzle. It's a bit hacky but it does show the XML response from eBay which can help tracking down the cause of the error.
try
{
    $response = $exchangeService->getJobs($request);
}
catch (GuzzleHttp\Exception\RequestException $e) {
    if ($e->hasResponse()) {
        echo $e->getResponse()->getBody()->getContents();
    }
    exit();
}


MB-14310: Updates Go version to 1.19.2

Description
Updates go from 1.19.1 to 1.19.2. Includes release with security fixes.
Following instructions from https://transcom.github.io/mymove-docs/docs/backend/guides/how-to/upgrade-go-version/
Changelog or Releases

golang

go1.19.2 (released 2022-10-04) includes security fixes to the archive/tar, net/http/httputil, and regexp packages, as well as bug fixes to the compiler, the linker, the runtime, and the go/types package.

@eeeady Thanks for the review -- but do you not have write access to this repo? (Who does?)


How to derive K from focal length and principal points

Thanks for the helpful project! Would it be possible to clarify how you derive the K matrix mentioned in https://docs.gsplat.studio/conventions/data_conventions.html given fx, fy, cx, cy (which may not be centered)? The internet gives different slightly different answers depending on the source (ie: some axes will be negative or not) and it would be very helpful to have this explicitly confirmed (and whether it lines up with the official GS 3D implementation).

I have a similar question: why is the formula provided here for calculating the projection matrix K different from the matrices given by OpenGL? Why isn't K[2,3] multiplied by a coefficient of 2, and why is K[3,2] 1 instead of -1?

The left image is from gsplat, and the right image is from OpenGL. Looking forward to your response!

Thanks for the helpful project! Would it be possible to clarify how you derive the K matrix mentioned in https://docs.gsplat.studio/conventions/data_conventions.html given fx, fy, cx, cy (which may not be centered)? The internet gives different slightly different answers depending on the source (ie: some axes will be negative or not) and it would be very helpful to have this explicitly confirmed (and whether it lines up with the official GS 3D implementation).

I think it will be work that replacing top、bottom、right and left use function as follows:
top = n * cy / fy
bottom = -n * (H - cy) / fy
right = n * (W - cx) / fx
left = -n * cx / fx


Url of Page

This page url is not working and this page is not founded on your url address.

Hi @Aman-8955 🙂
Sorry for replying at this late. Do you still need some help or guidance?
Right now I am working on major updates (mostly fixing all the issues Simplefolio has).
I will let know to all the community via Discord.

It's deployment is inactive and this site is showing not found.

HI @Aman-8955 - you can find the url here: https://the-simplefolio.netlify.app/
That's the deployment from the master branch, which is working.
You should be able to deploy your own version as well.

Now everything is fine thank you @cobiwave


Ability to group requests under a single connection in Mass Import from Postman

We are doing mass import of endpoints using Postman collection/requests into Swagger Explore API/operation.
We are following the instructions in the Explore.cli. Explore What's New - Import Postman Collection | SmartBear Community
The import of a Postman collection current brings in each Postman request as an API and within the API contains a singular Operation. For example, if I have 2 endpoints in the json file (e.g. GET /user/ and GET /user/all), each endpoint is imported as two (2) separate API with a single endpoint.
The desired outcome would be a single API with the two (2) endpoints. The ability to group requests under a single connection when within the same Postman folder level would be tremendously helpful.
Reference: https://community.smartbear.com/discussions/SwaggerHubExploreQuestions/mass-import-postman-collectionrequests-into-swagger-explore-apioperation/264865

Thanks for reporting/requesting @mikel-k-khui
It should be possible to get this added in the near future. Could you attach or share a sample collection?

Here is a sample json
sample.postman_collection.json


Added OpenGL support on Android

What does the pull request do?

Added OpenGL support on Android.

What is the current behavior?
There's no hardware acceleration on Android.
What is the updated/expected behavior with this PR?
OpenGL is enabled on Android by default. Control Catalog is no longer too slow on Android, but still a bit slow.
Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Avaloniaui.net with user documentation

I guess the only thing left is to make it work from a background thread so DeferredRenderer could do its thing

I guess the only thing left is to make it work from a background thread so DeferredRenderer could do its thing

I believe that as well, unfortunately I don't know exactly how it works. If you could point me in the right direction I would be thankful, but don't be bothered to explain if it's too complex.

I believe that as well, unfortunately I don't know exactly how it works. If you could point me in the right direction I would be thankful, but don't be bothered to explain if it's too complex.

It's actually pretty simple

implement IRenderTimer that ticks on the background thread and is synchronized with the display refresh rate (or use SleepLoopRenderTimer for now), pay attention to not trigger ticks when app is in background
change the renderer to DeferredRenderer and set RenderOnlyOnRenderThread to true
add the relevant locks

It's actually pretty simple

implement IRenderTimer that ticks on the background thread and is synchronized with the display refresh rate (or use SleepLoopRenderTimer for now), pay attention to not trigger ticks when app is in background
change the renderer to DeferredRenderer and set RenderOnlyOnRenderThread to true
add the relevant locks


bedrock geyser users bug

Bug Report 🐛

Plugin Version
1.5.6
Server Version
1.19.3 paper
StackTrace
N/A
Steps to Reproduce
join from bedrock edition with geyser plugin

that error appear


Xcode14: Rename "Embed App Extensions" to "Embed Foundation Extensions"

Xcode 14 beta 3 is giving a warning about the "Embed App Extensions" name saying it should be renamed to "Embed Foundation Extensions" not to conflict with "Embed ExtensionKit Extensions" (which was implemented in #1224)

I want to know how could I just ignore it, cause when I accept this change, my app crash. but, unfortunately Xcode 14 force me to do it.

I've found this warning myself which is currently sitting in my project (using Tuist v3.15.0 which is the current latest)

@Dennisdezhangaho, interesting that you say your app crashes after allowing Xcode to make this change. Has anyone else seen this?
Nope didn't happen to me. Don't remember Xcode ever crashing on me after grabbing the suggested changes. Sounds like a fluke if it was just once.


NPU Baichuan2 Multi- Process example

NPU Baichuan2 Multi- Process example.
How to test?

[ ] N/A
[ ] Unit test: Please manually trigger the PR Validation here by inputting the PR number (e.g., 1234). And paste your action link here once it has been successfully finished.
[x] Application test
[ ] Document test
[ ] ...

@sgwhat @plusbang please take a look

Merge it first as initial support and will open another PR to fix.


Data Mock: Add scripts to create mock data for our project

installing django-extensions and factory_boy
The script create a mock houses data with 500 items
to run the run:
python manage.py runscript create_mock_data
to add more scripts :

create a file in the scripts directory
define a function called run
write your code inside
relevant docomontatins:
https://factoryboy.readthedocs.io/en/stable/index.html
https://django-extensions.readthedocs.io/en/latest/


hasOne custom attribute not showing

Version information

Laravel: 5.7.19
Voyager: 1.1.11
PHP: 7.2
Database: MySql 5.7

Let's say I have Orders table and Payments table,
Order.php
/** * @return \Illuminate\Database\Eloquent\Relations\HasOne */  public function payments() { return $this->hasOne('App\Model\Payment');  }
Payment.php
/** * @return \Illuminate\Database\Eloquent\Relations\BelongsTo */  public function order() { return $this->belongsTo('App\Model\Order');  }
I created a bread for orders table and trying to create relationship with payments but I need to display the  custom attribute from payment.
I added the ff code in Payment.php
public $additional_attributes = ["test"];  public function getTestAttribute(){ return "test" }
When I create a relationship from Order bread I cannot see the custom attribute I added in Payment.php
Can anyone tell me if I miss something or is this a possible bug?

Same issue here.  Did you deal with the problem?

I figured it out, the custom attribute is not visible in the drop-down list in the relationship settings, but I manually entered it in the data_rows table in the details column under the label key. Now it works like a charm.

Make sure you scroll down the list for me it appears as last option.
Following instructions in https://voyager-docs.devdojo.com/customization/custom-realtionship-attributes:

Hi. you should delete and recreate the BREAD for Payment so as the title of additional field become visible for you.

Please update Voyager and if you are still experiencing the problem open  another issue


IndexError: list index out of range when running

I have executed commands from the README.md and #2
docker pull soulteary/docker-gfpgan
cd docker-gfpgan/model
wget https://github.com/TencentARC/GFPGAN/releases/download/v0.2.0/GFPGANCleanv1-NoCE-C2.pth
cd ..
docker run --rm -it -v `pwd`/model/GFPGANCleanv1-NoCE-C2.pth:/GFPGAN.pth -v `pwd`/data:/data soulteary/docker-gfpgan:2022.05.20
But got this error when running:
 Traceback (most recent call last):   File "/entrypoint.py", line 22, in <module>     towhee.glob['path']('*.jpg')    File "/opt/conda/lib/python3.9/site-packages/towhee/functional/mixins/display.py", line 157, in show     header = tuple(contents[0].__dict__) if not header else header IndexError: list index out of range
Is there any way to fix it?

Seams like it it because of data folder having no images. So coping images solves the problem.

I'm still getting the IndexError: list index out or range even when the data folder is populated with a jpg:
/opt/conda/lib/python3.9/site-packages/torch/nn/functional.py:718: UserWarning: Named tensors and all their associated APIs are an experimental feature and subject to change. Please do not use them for anything important until they are released as stable. (Triggered internally at  /pytorch/c10/core/TensorImpl.h:1156.)
  return torch.max_pool2d(input, kernel_size, stride, padding, dilation, ceil_mode)
Traceback (most recent call last):
  File "/entrypoint.py", line 22, in <module>
    towhee.glob['path']('*.jpg')
  File "/opt/conda/lib/python3.9/site-packages/towhee/functional/mixins/display.py", line 154, in show
    contents = [x for i, x in enumerate(self._iterable) if i < limit]
  File "/opt/conda/lib/python3.9/site-packages/towhee/functional/mixins/display.py", line 154, in <listcomp>
    contents = [x for i, x in enumerate(self._iterable) if i < limit]
  File "/opt/conda/lib/python3.9/site-packages/towhee/functional/data_collection.py", line 361, in inner
    return unary_op(x)
  File "/opt/conda/lib/python3.9/site-packages/towhee/engine/factory.py", line 95, in __call__
    res = self.__apply__(*arg, **kws)
  File "/opt/conda/lib/python3.9/site-packages/towhee/engine/factory.py", line 78, in __apply__
    return self._op(*args, **kws)
  File "/opt/conda/lib/python3.9/site-packages/towhee/engine/operator_registry.py", line 192, in wrapper_call
    return old_call(self, *args, **kws)
  File "/entrypoint.py", line 19, in __call__
    return restored_faces[0][:, :, ::-1]
IndexError: list index out of range


有关重定向过程中的问题

CurlInfo.REDIRECT_COUNT>0时CurlInfo.REDIRECT_URL)=“”是什么原因呢？或者说作者是否能考虑一下实现一下requests下response.history的功能

如果你用底层的 curl-API 的话，怎么重定向，读取 Location header 返回的 URL 都是可以自己实现的。requests-API 中支持 history 在考虑，有空了会弄下。

+1 for this feature

Sorry, there is no direct way to extract the redirect history of a curl request, if you let curl follow redirects automatically, and that's why this issue has been kept open for so long. You can, however, view the history via debug=True in the debug info.
If you disallow curl to follow redirect automatically, it's possible to extract the next redirect from the Location header, record it, and then follow it manually. However, that might be less performant.

+1 for this feature


PoC of Backstage application packaging system

Context
As a Backstage end-user, I'd like to deploy my organization Backstage-based image by composing a set of plugins (both in-tree and npms), and specifying target platforms. So that I can easily prepare a ready-to-deploy package for my organization.
Proposal
I'd like to propose a YAML-based configuration tentatively called, Application, to help describe what we'd like to package and deploy.
The specification is similar to those used in Kubernetes.  The main reason of using YAML and not JSON because the current draft spec allows us to generate and overwrite Root.tsx with snippets specified in spec.rootComponent.
Example
The following is an example of how could we compose a Backstage application by:

Having the master branch as the application template.
Patch package.json of the app to contain only a set of plugins, which are 3 in the example app. One of them is pulling directly from npm, other twos are in-tree plugins.
Patch the Root.tsx file to show only links we needed.
Generate Kubernetes as our deployment target.

apiVersion: backstage.spotify.com/v1alpha1
kind: Application
spec:
  templateRepository:
    url: https://github.com/spotify/backstage
    revision:
      branch: master
  containerImageRepositoryPrefix: chanwit/my-welcome-
  plugins:
    - name: MyWelcomePlugin
      package: "@chanwit/plugin-my-welcome"
      version: "^0.1.1"
    - name: LighthousePlugin
      package: "@backstage/plugin-lighthouse"
      version: "^0.1.1-alpha.4"
    - name: TechRadar
      package: "@backstage/plugin-tech-radar"
      version: "^0.1.1-alpha.4"

  # TODO support backends: {}
  deploymentTargets:
  - kubernetes

  rootComponent:
    path: packages/app/src/components/Root/Root.tsx
    imports: |
      import HomeIcon from '@material-ui/icons/Home';
      import AccountCircle from '@material-ui/icons/AccountCircle';
    sidebar: |
      <Sidebar>
        <SidebarLogo />
        <SidebarSpacer />
        <SidebarDivider />
        <SidebarItem icon={HomeIcon} to="/" text="Home" />
        <SidebarItem icon={AccountCircle} to="/login" text="Login" />
        <SidebarDivider />
        <SidebarSpace />
        <ToggleThemeSidebarItem />
      </Sidebar>

PoC Implementation
A PoC implementation is called backstage-package, which can be downloaded from here:
https://github.com/chanwit/backstage-package/releases/tag/v0.1
I provide PoC binaries for both Linux (tested) and macOS (untested yet).
After download the binary. Please run the following command.
backstage-package -f application.yaml generate
Under the dist, we'll have ready-to-deploy manifests, for kubernetes.
Planned

Support installation of this PoC binary via npm
Support API and Backend package and deployment

Thank you @leemills83 @soapraj for inputs and discussion.

Looks interesting! I think something like this can be significantly easier to implement once we have config in place.

Yes it is.
Some area for example Apis is still difficult to generate by this PoC.

I'm curious by having JSX / React into the YAML, I haven't seen this done before. How would imports be done? Do you have an example of another FOSS project that has successfully implemented such a model?
From a purely developer experience, this file looks like a dream. A single config has extremely low cognitive load and allows the smallest of orgs to deploy Backstage. Big fan of the idea!

I'm curious by having JSX / React into the YAML, I haven't seen this done before. Do you have an example of another FOSS project that has successfully implemented such a model?

Hmm I'm not sure about that. I'm not a very frontend guy. But in Kubernetes' world, we normally use this pattern by embedding JSON, YAML into a parent YAML file, especially in something called a ConfigMap. The idea came from this pattern.

From a purely developer experience, this file looks like a dream. A single config has extremely low cognitive load and allows the smallest of orgs to deploy Backstage. Big fan of the idea!

I'm so glad you like it.

Now we can try out the program by:
npm install @chanwit/backstage-package
then
npx backstage-package --help will show briefly how to proceed.

Thinking a bit more about this I think one long-term implementation could be something like a --build flag to @backstage/cli create-app.
For example
@backstage/cli create-app --build app.yaml

Could consume a yaml to build a production version of the app directly to an output directory.
You could then just call that in a dockerfile and use mutli-stage builds to move the output into an nginx container.
Then if you want to create a git repo with the same config you could just do
@backstage/cli create-app app.yaml

to create a new repo with the same config.
With that we can support both simply building a backstage app from a config, and creating a new app from a config, and having an app that you've been deploying with a config but want to upgrade into a git repo with code that you can modify.


Bringing the library up to the latest version of the spec

Merged as 641108c1ae992b43d683dd71db2ad41a56e1d8c0 -- I cleaned up some further style issues and squashed the commits down.
For future reference, the make check command is very good at pointing out style issues (of which there were still quite a few left in this patch) -- please run it in future on any other patches you want to PR.


Improved the scientific Calculator html and css part

Description 📜
In scientific calculator numbers are randomly arranged. so I have updated index file so that all numbers will be in sequence and will be more user friendly.
I have also improved the CSS part to make it more attractive.
Fixes # 60

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GSSOC'22 contributor
[x] Have you added a working video of your calculator ?

Screenshots / Gif (Optional) 📸
Before

After

@vasu-1 @Chayan-11 please review the PR and merge it.


Tensorflow Federated notebook for Pill dataset

This notebook trains and evaluates the faulty pill recognition dataset using the same federated model as the flower one.
Nevertheless, I still need some help formatting the outputs to the same standard as your other notebooks.

I went through the notebook! The image size should be 224,224,3 with same num rounds and num epochs as mine.


[Windows] Include variant in file path errors

A small typo causes file path errors on Windows to not include the variant of the API that produced the error. This patch ensures we pass the variant down to the error constructor
Resolves https://github.com/swiftlang/swift-foundation/issues/1084

@swift-ci please test


Add purging for notifications using expires_in

Purges based on the expires_in for the given notification_type on a notification

This requires 1 extra query, but I think Keenan will survive (trust me, I tried to make this work in a single query... but gave up)

Puring runs every six hours (clears out 24 hour notifications faster)
Clears out notification recipients as well

This is a alternative to https://github.com/ManageIQ/manageiq/pull/17046 in which a global setting was used to determine when to clear up notifications.  This could still be done in here as a well, but I left it only using the expires_in for now.
Info on the .purge_scope query
The query for the Notification.purge_scope is a little complex, so let me walk through it:

First, it collects all of the notification_types and groups the ids by the expires_in value

From there, it builds a where clause as a collection of "OR" statements for each expires_in/type_ids group.  An example sub-condition looks like:
(notification_type_id IN (type_ids) AND created_at < {{expires_in_value}})

The full query looks something like this:
SELECT *
FROM "notifications"
WHERE ((("notifications"."notification_type_id" IN (1,2,3)
       AND "notifications"."created_at" < '2000-01-13 00:00:00.000000')
   OR ("notifications"."notification_type_id" IN (4,5,6)
       AND "notifications"."created_at" < '2000-01-07 00:00:00.000000'))
   OR ("notifications"."notification_type_id" IN (7,8,9)
       AND "notifications"."created_at" < '2000-01-01 00:00:00.000000'))

Hopefully it isn't terribly unoptimized doing that, but it might need an index to scale properly...
Links

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1544890
Still pretty much a copy-pasta of this PR:  https://github.com/ManageIQ/manageiq/pull/16754

(minus using the orphan purger)

Original Attempt:  https://github.com/ManageIQ/manageiq/pull/17046

cc @jrafanie @carbonin

This requires 1 extra query, but I think Keenan will survive (trust me, I tried to make this work in a single query... but gave up)

I came here for a funny comment in all of those words and was not disappointed.  This is a :gem:.

I came here for a funny comment in all of those words and was not disappointed. This is a 💎.

The hidden goal of all of my PR descriptions.

Line 13, Col 32 - Style/FormatStringToken - Prefer template tokens (like %{foo}) over unannotated tokens (like %s).

haha @miq-bot, really?
All joking aside, the code looks good in spite of @NickLaMuro not removing the expires_in column.  I  defer purging to @kbrock.  If expires_in is used, this PR is good but I would still prefer https://github.com/ManageIQ/manageiq/pull/17046 for the simpler code.

haha @miq-bot, really?

I think that is actually a bug in rubocop.  I am neck deep in that code today, so I am going to see if I can put together a fix for that... Just kidding, there is already one:
https://github.com/bbatsov/rubocop/pull/5230
So, I think it might just be an issue of the bot not being up to date with the latest rubocop version?  Looks like it, so I will open up a PR on the bot.

Line 13, Col 32 - Style/FormatStringToken - Prefer template tokens (like %{foo}) over unannotated tokens (like %s).

I dunno, %s has worked for me since 1991... but I guess I also used assembler at the time and am not advocating that.

reindexes
    "notifications_pkey" PRIMARY KEY, btree (id)
    "index_notifications_on_cause_type_and_cause_id" btree (cause_type, cause_id)
    "index_notifications_on_notification_type_id" btree (notification_type_id)
    "index_notifications_on_subject_type_and_subject_id" btree (subject_type, subject_id)
    "index_notifications_on_user_id" btree (user_id)

so deleting by any date is not optimial.
this may warrant changing index_notifications_on_notification_type_id from notification_type_id to notification_type_id, created_at

Adding [WIP] label as well to make sure this doesn't get #yoloMerged

@kbrock @Fryguy Added a script to generate some seed data for notifications here:
https://github.com/NickLaMuro/miq_tools/pull/6
I basically tested the two different queries that would be generated against it, and they are effectively the same, but I think we can all agree the current form is much easier to grok what is going on.  Curious if you are getting similar results with that script or if you think I am missing something with my tests.
Want to try a full purge with NotificationRecipient records as well, but haven't figured out how to get a random sample for that yet.
My Results

At 510k notifications, about 128k of which were expired, both queries took .25 seconds to complete a .count.
At 5.1 million notifications, and about 1.28 million expired, both queries took about 2 seconds to complete a .count.

@NickLaMuro can we ship it?

Closing in favor of the original:  https://github.com/ManageIQ/manageiq/pull/17046


Fails to invoke in Azure

Hi,
Tried this through Azure customer support but they seem to not get anywhere.
[03/22/2016 09:00:00 > 06e143: SYS INFO] Next schedule expected in 00:14:59.6671203
[03/22/2016 09:15:00 > 06e143: SYS INFO] WebJob invoked
[03/22/2016 09:15:00 > 06e143: SYS INFO] Next schedule expected in 00:14:59.6165515
[03/22/2016 09:30:00 > 06e143: SYS INFO] WebJob invoked
[03/22/2016 09:30:00 > 06e143: SYS INFO] Next schedule expected in 00:14:59.6742936
[03/23/2016 12:13:20 > 06e143: SYS INFO] Scheduling WebJob with 0 0,15,30,45 * * * * next schedule expected in 00:01:39.5604435
[03/23/2016 12:15:00 > 06e143: SYS INFO] WebJob invoked
[03/23/2016 12:15:00 > 06e143: SYS INFO] Next schedule expected in 00:14:59.7110876
We are using cron for scheduling and we have Always On and it has been working for like 6 months without any issues. Is there anything that can cause Kudu to not start the webjobs?

mind sharing the sitename here or indirectly?

@iremmats This could have been caused by #1940, which is now fixed. But having your site same would allow us to double check that you in fact hit that issue.

Hi,
Azure support told us the same too. So most likely we found the reason. How can I send you the sites names privately? They contain partner names etc which I dont want to reveal here. :)

Mats, here's the wiki on how to do that in the open - https://github.com/projectkudu/kudu/wiki/Reporting-your-site-name-without-posting-it-publicly

Hi
Kudu will continue to run in Azure App Service. However, this repo will no longer be maintained.
If the problem persists and is related to running on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


[Doc][Development] Contributing Guides  page not accessible(Not Found error)

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Contributing Guides is not found

And chinese documentation, 贡献者指南 is also not found

Documentation Links
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @staneyffer thanks for the feedback, we were migrated all development doc to https://dolphinscheduler.apache.org/en-us/docs/dev/user_doc/contribute/join/security.html, you can see the latest docs in that link, related PR is #11313 .
And BTW, after we related the version 3.0.0, we will and those docs to Docs tabs

@zhongjiajie ,  Thank you for your reply, i got it~


Accept <- chan struct{} in Worker.Run

Is your feature request related to a problem? Please describe.
The worker.Run() function accepts a <- chan interface{} parameter. This makes it impossible to directly pass, e.g., ctx.Done() (which seems to me is the most common use case besides internal.InterruptCh()).
Describe the solution you'd like
It'd be great if the worker.Run() function accepted a <- chan struct{} instead. The internal.InterruptCh should then also return a <- chan struct{}.
Describe alternatives you've considered
Since this would be a breaking change, a viable alternative would be to add a RunCtx(context.Context) function to the worker interface that you directly pass a context. Would also be idiomatic.
Additional context

Since it's irrelevant what you pass to the channel, a <- chan struct{} might also more clearly express that this channel is just used for signalling that some event happened.
If you decided to change the signature of internal.InterruptCh, that func could then be implemented as a two-liner by utilizing signal.NotifyCtx(...).

I am afraid we cannot make a breaking change here.

So the provided alternative is also not an option, I suppose?

Unfortunately adding helpers/shortcuts on the worker interface is probably not the best thing. But they could be added top level. For instance, anyone could do (untested, just typed here in GH):
func RunWorker(ctx context.Context, worker worker.Worker) error {
  doneCh := make(chan interface{})
  errCh := make(chan error, 1)
  go func() { errCh <- worker.Run(doneCh) }()
  select {
    case <-ctx.Done():
      close(doneCh)
    case err := <-errCh:
      return err
  }
  return <-errCh
}

Then maybe something to keep in mind for v2 of the SDK.

For sure


Standardize See also sections

Hi @mightypen - Would you be able to review the pull request and indicate whether it can be merged? Thanks much.

@ktoliver Hi, I receive dozens of these from-GitHub emails per day, and they contain little info beyond the title and link.  So I often must ignore them, because they waste too much of my time.
In the present case of PR #3725, I would reject this large PR because the combination of being large and of being a very minor value change - makes me feel the value is not worth the churn. There was a similar PR some days ago where I did formally Review and wherein I stated the same assessment.
I am fine with this PR being Closed (not merged).
Thanks, G.

Thanks for the information @MightyPen


Write shortest possible code: python how to rename file (python)

Please write shortest code example for this question:
python how to rename file in python
How to do it:

Go to python codes
Create new file (named in underscore case, should contain key words from title) with md extension (markdown file).
Propose new file with following content (please use all three blocks if possible - title, code itself and explanations list):

# python how to rename file

```python
code part1 part2 part3 ...
```

- part1 - explain code part 1
- part2 - explain code part 2
- ...

More advanced template for examples and linked solutions. More docs here.

Can I join in this issue?


In-memory zip generation

In my app, I'd like to generate the data for a zip file entirely in-memory without touching the disk. The data is to be uploaded to a remote server, so there's no need for it to touch the local disk, and avoiding so means no file access errors can occur.
Looking through ZZMutableArchive, this looks a bit tricky to achieve. It seems the current code is built atop NSFileHandle. I could create a custom subclass of NSFileHandle that is backed by data, but that seems rather messy, and perhaps would fail in some places.
Using NSOutputStream instead would make my life easier. So, what in NSFileHandle are we dependent on? Looking at the code:

-offsetInFile to track how much data has been written so far; this could be replaced by passing round integers as arguments/return values
If an error occurs while writing an entry, winds the file handle back to where it was before that entry was written
-truncateFileAtOffset called once writing is finished; as I understand it, that mostly is to handle archives which are now smaller than when they were read

Have I got those right, missed anything?

I agree with @ndusart some example of in-memory reading and writing would be great.

I can't find ZZMutableArchive in the current code. I tried initializing a ZZArchive instead in Swift based on the sample code above:
let zipArchive = try ZZArchive.init(data: NSMutableData())
It throws this error:
The operation couldn’t be completed. (com.pixelglow.ZipZap error 0.)
Error Domain=com.pixelglow.ZipZap Code=0 "(null)" UserInfo={NSUnderlyingError=0x14a3a1af0 {Error Domain=NSCocoaErrorDomain Code=260 "The file couldn’t be opened because it doesn’t exist."}}

I'll take a look at the error. Meanwhile please raise this as a separate issue.

Done. Thank you.
https://github.com/pixelglow/ZipZap/issues/145
From: Glen Low<EMAIL_ADDRESS>Sent: Monday, July 04, 2016 4:09 AM
To: pixelglow/ZipZap
Cc: Ilya Kazakov; Comment
Subject: Re: [pixelglow/ZipZap] In-memory zip generation (#8)
I'll take a look at the error. Meanwhile please raise this as a separate issue.
�
You are receiving this because you commented.
Reply to this email directly,
view it on GitHub, or
mute the thread.