add :wait parameter for Docker::Exec#start!

I just add :wait parameter for Docker::Exec#start!

Please remove the increment version.  We handle that on master.
Looks like your VCR wasn't added.  Can you add that as well?

@tlunter thank you for response!
i add vcr record and fix that.

@tlunter How about here?!

@vexus2 sorry about that, been busy with work.  Looks great. Thanks.

Just pushed v1.23.0 with this!

The :wait parameter is not passed to the exec.start!().So it doesn't take affect when call container.exec with :wait
    start_opts = {
      :tty => tty,
      :stdin => stdin,
      :detach => detach
    }

    if detach
      instance.start!(start_opts)
      return instance
    else
      instance.start!(start_opts, &block)
    end

https://github.com/swipely/docker-api/blob/master/lib/docker/container.rb#L77


grpc-json transcoder: Large response triggers internal server error

Title: Large gRPC responses converted to JSON get an internal server error response
Description:

I'm using the grpc-json transcoder filter and when I attempt to send a proto response which when serialized is probably ~2.5 MB, I get a 200 response with a grpc-message of Internal Server Error and the rs_too_large stat counter gets incremented. I changed the per_connection_buffer_limit_bytes config for the downstream cluster to 50 MB, but that doesn't appear to fix the issue.

Is there a config option that can raise the buffer high watermark in this case so that we can raise the response limit?

Related to https://github.com/envoyproxy/envoy/issues/5012.
IIRC if you have an HTTP/2 downstream you might need to tune the per stream buffer, but I think this defaults to something really big. I agree we need more documentation on how to configure this properly. cc @lizan @alyssawilk who might have quicker thoughts without looking through the code.

@warhammerkid what is the grpc-status? Do you use streaming?

I can't believe I missed the fact that per_connection_buffer_limit_bytes can be set on the cluster AND the listener. Moving my limit setting from the downstream cluster to the listener fixes my issue. If I throw in a buffer filter is it possible to use that to lower the request limit for DoS protection while still allowing the server response size to be much larger? Are there any other consequences of raising the listener buffer limit?
@lizan I'm not currently using streaming and the grpc-status was a 2.

AFIK the DoS potential is pretty much it.  It affects a few different buffers (listener write buffer, HCM request / response buffers, etc.) but a buffer filter should mitigate the DoS opportunities as you say.
Docced up a bit in #6059 - please take a look and let me know if I can make that more clear and/or helpful

Thanks so much for the help on this question!


Remove JobMetadataConfig class

This PR removes also the support for the old osolete key dist-git-brach.
Usage of metadata key in the yaml files is still supported.
If the same key, let say branch, is used both netsted to job and
netsted to job -> metadata then the job -> metadata -> branch value
in the code.
Fixes https://github.com/packit/packit/issues/1515
Merge after packit/packit#1569
RELEASE NOTES BEGIN
Metadata dictionary is no longer required when specifying a job.
Keys which used to belong to the yaml metadata dictionary are now keys of the job dictionary itself.
RELEASE NOTES END

recheck

\recheck

recheck

recheck


Missing Hue-Light and Hue-Group

Just updated this and I have now two missing node types as above?

Can you try to update to the latest version (2.0.1)? I found an error in the Hue group node but Hue Light nodes shouldn't be affected from this. For me, it looks like the new dependency get-image-colors was not be installed during your update process.
Are you running NodeJS 10+?

10 Aug 17:52:32 - [info] Waiting for missing types to be registered:
10 Aug 17:52:32 - [info]  - hue-light
10 Aug 17:52:32 - [info]  - hue-group
node-red-contrib-huemagic
2.0.1
[object Object]
[object Object]
 11 nodes http://<IP_ADDRESS>:1880/#in use http://<IP_ADDRESS>:1880/#
Foddy,
Above are some of the reports I get, the first is from the ’start’ script and the second the Manage display.
Still complains about both nodes as missing!

On 10 Aug 2019, at 17:09, Foddy<EMAIL_ADDRESS>wrote:
Can you try to update to the latest version (2.0.1)? I found an error in the Hue group node but Hue Light nodes shouldn't be affected from this. For me, it looks like the new dependency get-image-colors was not be installed during your update process.
Are you running NodeJS 10+?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Foddy/node-red-contrib-huemagic/issues/89?email_source=notifications&email_token=ACWZRXF4LF3BIEJP76OH7V3QD3K4DA5CNFSM4IKZOOR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4APH6Y#issuecomment-520156155, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWZRXAKQJ5A4N2VZWZP2ETQD3K4DANCNFSM4IKZOORQ.

Sorry I can't reproduce this error. I removed HueMagic completely and installed it from the Node-RED web interface again without any problems.
If you already checked if you are running a supported NodeJS (10+) and Node-RED version, please try removing huemagic and reinstalling. Your flows / configuration will not be deleted during a fresh install.

My bad,
Seems my Nodjs is hopelessly out of date. My attempt to upgrade has thrown new errors and I guess a new build from scratch might be the best way forward.
Thanks

On 10 Aug 2019, at 18:23, Foddy<EMAIL_ADDRESS>wrote:
Sorry I can't reproduce this error. I removed HueMagic completely and installed it from the Node-RED web interface again without any problems.
If you already checked if you are running a supported NodeJS (10+) and Node-RED version, please try removing huemagic and reinstalling. Your flows / configuration will not be deleted during a fresh install.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Foddy/node-red-contrib-huemagic/issues/89?email_source=notifications&email_token=ACWZRXGH4R4PWL6YUWTGBADQD3TOZA5CNFSM4IKZOOR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4AQT3Q#issuecomment-520161774, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWZRXGURF7HCOZOLVZ6CHTQD3TOZANCNFSM4IKZOORQ.


React mixin requires component to have state

It seems that the React mixin requires the using component to have its items in state only. I have made an example jsfiddle where the component uses props and the "snapping-back to original" problem occurs.
http://jsfiddle.net/tcxe69bs/1/

I submitted a pull request with a fix for this.

I can not accept such a PR.
Because of inconsistencies code-style, changed each line.
https://www.dropbox.com/s/446fvlh02k9hk04/Screenshot 2015-10-07 18.46.21.png?dl=0

Use tab.

Will do. I was in a rush today and I just pulled it off my project with settings from there.

Use .editorconfig-plugin for IDE:

http://editorconfig.org/
https://github.com/RubaXa/Sortable/blob/master/.editorconfig

Why did you close the issue if the problem is still in the code?

Sorry.

Experiencing the same thing, want to use the mixin, however keeping everything in state isn't really an option for me.

Actually after thinking about this and talking it over with a coworker, there doesn't seem like there is really a better way to go about this. What seems logical is having a componentWillReceiveProps that merges the new state with your current state.
One thing that would be nice is the addition of a sort order on the actual state itself.

@loktar00 I'm having issues with getting this to work, could you provide some sample code that worked for you? I opened an issue with my code here: https://github.com/RubaXa/Sortable/issues/688

Dear all! Meteor is moved to the separate repository. If this issue is still actual, please create it there once again and this rojects needs a maintainer:

ES2015+: https://github.com/SortableJS/react-sortablejs 🆘
mixin: https://github.com/SortableJS/react-mixin-sortablejs


nan's were being prepended to cells when recode(..., append=True) was being used

.. when the original cell was empty.

:+1:


Price data should be fetched async and configured for reporter

I added my own CMC API key. Sometimes the column usd (avg) does not contain any value and sometimes it does.
Does anyone have the same issue? It is enough to just run the test like 5 times in a row to get the price at some point.

@SimonHausdorf Could you share your config (without the key value) just to double-check that it's ok?

I created a small example: https://github.com/SimonHausdorf/GasFeeTest
I changed the cmc key in the config. My current output looks like this
·-----------------------|----------------------------|-------------|----------------------------·
|  Solc version: 0.8.3  ·  Optimizer enabled: false  ·  Runs: 200  ·  Block limit: 9500000 gas  │
························|····························|·············|·····························
|  Methods                                                                                │
·············|··········|··············|·············|·············|··············|··············
|  Contract  ·  Method  ·  Min         ·  Max        ·  Avg        ·  # calls     ·  usd (avg)  │
·············|··········|··············|·············|·············|··············|··············
|  Box       ·  burn    ·           -  ·          -  ·      35973  ·           1  ·          -  │
·············|··········|··············|·············|·············|··············|··············
|  Deployments          ·                                          ·  % of limit  ·             │
························|··············|·············|·············|··············|··············
|  Box                  ·           -  ·          -  ·    1502095  ·      15.8 %  ·          -  │
·-----------------------|--------------|-------------|-------------|--------------|-------------·

I guess my current location slows it down.
I added this to my tests to temporarily solve the problem:
await new Promise((r) => setTimeout(r, 500));

Yes, coinmarketcap used to have open endpoints as well ... would definitely prefer if this feature was zero-config. But I'm hesitant to change data providers because it's almost inevitable that they'll add an API key eventually to prevent DDOS.

coinpaprika exists since a long time too, and their promise is: Delivered at No Cost - because “Information wants to be free”
Guess there are a few people which might oversee the point with CMC's API key configuration. Maybe a warning when starting the test would be nice? Warning: You did not configure your own CMC key, something like that.
Anyways, thanks for the work :)
I will not maintain the issue any longer, so feel free to close it or to keep it for a backlog.

Will keep open and consider coinpaprika, thank you. Renaming.

I think this issue needs to be renamed?  IIUC, the race condition was already fixed and released, and so this is open for the purposes of considering switching to another price feed service like coinpaprika, which sounds like a fantastic idea to me.
BTW, https://www.coingecko.com/en/api says:

so that's another possibility.

This is fixed in the latest version. All price data is fetched async at the end of the test run.
https://github.com/cgewecke/hardhat-gas-reporter/releases/tag/v2.0.0


Feature/test deskktop version

[x] fixes issues with notes actions

Can't use the star "Favorite" feature. Clicking in preview mode doesn't do anything, clicking when in list mode opens the item.

The "Save Changes" button should be in the blue color.

Remove the "Shared with" column until we can share
Make the Documentation link go to https://github.com/verida/markdown-notes-demo/blob/main/README.md (note it is to the main branch)

Can we make the purple outline go around the inactive button as well, but keep it in the light shade to indicate inactivity? Currently it looks a bit like it is a button that can't be pressed.

Getting close.
Two problems:

Clicking the star here does add it to favourites, BUT also opens the item at the same time (in Firefox anyway)

Make the Documentation link go to https://github.com/verida/markdown-notes-demo/blob/main/README.md (note it is to the main branch)

That looks good now


Feature Request: Run out of order

I am suggesting an option to allow migrations to be run out of order and allow re-numbering of migrations in earlier environments.
This is based on experience of teams working on multiple branches which make their way to earlier team environments out of order before merging to master in their final order.
Some might also have this requirement in prod environments based on the Stack Overflow article you reference as inspiration says:

Note that the above aren’t all in file number order. That’s because 724 and 725 were in a branch for a few days. That’s not an issue, order is not guaranteed. Each migration itself is written to be idempotent, e.g. “don’t try to add the column if it’s already there”, but the specific order isn’t usually relevant.

Thanks for the suggestion.
This library guarantees that order, it's intentionally different from the Stack Overflow model in that respect. The order guarantee makes the migrations more predictable and consistent across environments, which was one of the goals of making it. Not respecting the order would be a big breaking change, and not one I'm willing to make. Even as an option, I'm quite reluctant - I'd need to understand the use-cases and implications better.

re-numbering of migrations in earlier environments

Could you elaborate on how this would work?

but the specific order isn’t usually relevant.

Which implies it sometimes is :wink:
For example, let's imagine we have two migrations:
ALTER TABLE t ADD COLUMN IF NOT EXISTS c VARCHAR(16);
and
ALTER TABLE t ADD COLUMN IF NOT EXISTS c VARCHAR(100);
For any given environment, which type will the c column have? If the order is deterministic, it will be the same for all. If not, then who knows? This is how you get into a situation where your database schemas diverge across environments.


Implement streaming flag

Implement a flag that the user can add so that the message gets streamed rather than outputted all at once.

Resolved by pr b2a8f89


Queues (for communications and other)

We don't have a queue for dispatching tasks. Currently, the only area we really could use it is in dispatching email and sms messages via API to the backend providers. The initial implementation of that uses Node's event emitters to dispatch these jobs, but there is no management of such jobs like retry etc.
It would be good if we could have a simple queue framework that uses Postgres, to reduce the out of the box dependencies for the code base, but probably we'll go for a rabbit mq or redid backed queue framework.

@pwalsh not sure I understand the core of this issue, can you elaborate a bit?

@noamoss in our context, queuing systems are used to robustly manage asynchronous jobs that do not need (for various types of "need" - performance, application semantics, etc.) to be dispatched and returned in the request/response cycle of a web app.
Dispatching emails is a classic example of this. Dispatching them in a request/response cycle means the web app has more processing to do before it can respond back to the client (especially true in languages like python).
So, what is commonly done is to dispatch a "job" (a job might be a function and its arguments), put it "somewhere", and call it "later", allowing the response to return without calling the job. This design has additional benefits like the ability to retry the job if there is a failure, to set dependencies across jobs etc.
In GovFlow, because Node is an event-driven web server (it is asynchronous by design), we do the "dispatch" part using some node functionality, but, we don't get the benefit of the ability to re-run jobs, inspect job health, etc.
A concrete example is, if we try to dispatch an email and they receiving server is temporarily down, we don't know and we can't try again later.
A job queue will allow us to manage such tasks, which run run the background of the web server, more robustly.

@noamoss @amirozer I looked into it last week and it seems this is probably the best solution for this in node:
https://github.com/OptimalBits/bull
@amirozer if you have other choices that are in use, let me know.

So, SendGrid has a send_at functionality - and it turns out that Twilio does too. This basically solves our whole issue:

we dont need to manage our own queue or schedule - they do it
we just dispatch message tasks to those backends as we normally do
we do need to update our communication model like in the previous comment to ensure we are tracking what got send properly (enough), and save some rendered message data for potential debugging purposes

This is now done in https://github.com/govflow/govflow/commit/ba32772574756922f837a01a8870ef9bfb47c89f by using the functionality of our service providers Twilio and SendGrid.


keyboard input blocked when enabled with vscodevim

👓 What did you see?
When both the vscodevim/Vim plugin and the Cucumber plugin is enabled, the keyboard input is blocked and unresponsive. When Cucumber is disabled, vim key input works as normal. When Cucumber is enabled and Vim is disabled, normal keyboard input also works as normal.
📦 Which tool/library version are you using?
vscodevim: 1.26.2
cucumber: 1.7.0
vscode: 1.84.2
🔬 How could we reproduce it?
Steps to reproduce the behavior:

Install both plugins
Start editing files

Closing as a duplicate of #183.

Closing as a duplicate of https://github.com/cucumber/vscode/issues/183.


Add pool of preconfigured networks for sandboxes

When creating a lot of sandboxes at the same time the biggest bottleneck right now is the network setup that takes more and more time depending on the number of networks being created. When creating 20+ sandboxes the additional delay starts to cross 1+ seconds.
The solution here is to create a pool of pre-created networks that we can then immediately use while refilling the pool.

We added the pool of preconfigured networks. Adding a pool for the FC was more complicated.


CssStyleSheet.addRule() is not present on Firefox

When using hte CssStyleSheet.addRule() method, Chrome works fine, however Firefox throws an Exception:
"NoSuchMethodError: method not found: 'addRule' (sheet.addRule is not a function)
Their API only allows insertRule:
https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleSheet
Here, the Dart documentation does not mention what the experimental status means:
https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart:html.CssStyleSheet#id_addRule
Suggested fix: implement the addRule's functionality for browsers that does not have that method, or remove it altogether.

Also, insertRule method in Firefox requires an index parameter, it is not optional:
https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleSheet/insertRule

@vsmenon
Mapping insertRule to addRule is doable - however, it's yet another polyfill.  Your thoughts?


[AST Verifier] Hack: don't look for destructors of Clang nodes.

The AST verifier is causing late deserialization of generic
environments, which in turn is causing the Clang importer to import
more classes, which don't end up getting proper destructors... causing
an AST verification error. For now, disable this AST verifier check,
because it's causing lots of brokenness rdar://problem/29741827.
A proper fix will take a bit more work.

@swift-ci please smoke test and merge


Remove upper keyword from eigh and eigvalsh.

As per the title
Fixes #217
cc @rgommers @asmeurer @kgryte

This PR can be merged once gh-243 is merged, which adds tril and triu to the specification.

gh-243 has now been merged. Merging...


Endless loop when selecting to Show Task Manager

Hi, just wanted to drop a quick note. I'm far from an expert powershell guru, but I did run across something that the script was not doing properly.
When selecting the option to show the task manager, it gets stuck in an endless loop while waiting for a value to show up that just won't ever.
Lines 2060 and 2065 (Script version 3.2.8 end with piping the output of the variable assignment to Out-Null. So the variable ends up with a null value.
Removing the pipe to null solves the problem.
Before:
$TaskManKey = Get-ItemProperty -Path $Path -Name "Preferences" | Out-Null
If(!($TaskManKey)) {
	$taskmgr = Start-Process -WindowStyle Hidden -FilePath taskmgr.exe -PassThru
	While(!($TaskManKey)) {
		Start-Sleep -m 250
		$TaskManKey = Get-ItemProperty -Path $Path -Name "Preferences" | Out-Null
	}

After:
$TaskManKey = Get-ItemProperty -Path $Path -Name "Preferences"
If(!($TaskManKey)) {
	$taskmgr = Start-Process -WindowStyle Hidden -FilePath taskmgr.exe -PassThru
	While(!($TaskManKey)) {
		Start-Sleep -m 250
		$TaskManKey = Get-ItemProperty -Path $Path -Name "Preferences"
	}

Like I said, I'm still at an intermediate level with Powershell, so if my thoughts are wrong, please let me know.  Otherwise, I hope I helped.
-- David

thanks for posting this issue.
Issue fixed in v3.2.9


Quail Bookmarklet

Is this feasible? I think it would make Quail more available to people if they could just drag a button to their browser bar and then click it. If it's not feasible, what about a chrome plugin?

Send a PR!


humanize and diacritcs

Hi!
humanize doesn't uppercase diacritcs.
{{ "death" | humanize }} -> Death
{{ "óbito" | humanize }} -> óbito

Tested on Hugo Static Site Generator v0.31.1 darwin/amd64 BuildDate: 2017-11-27T13:55:00-02:00
Thank you!

https://github.com/markbates/inflect/issues/6


Check methods for Safe class

Is it something missing or can something be improved? Some code was written long time ago (related to https://github.com/safe-global/safe-eth-py/issues/1208)

Safe was refactored a few months ago, and added some new methods like the ones using the SimulateTxAccessor. Nothing is missing for now. Let's revisit again when Safe v1.5.0 is released


Aurora stops working if restart or wake up from sleep with Coolermaster Pro L RGB attached.

Expected behavior:
Whenever the computer starts fresh/restarts with my Coolermaster Pro L RGB, the Aurora software's lighting settings that I customised should be running without any user intervention
Actual behavior:
Aurora will capture the device briefly with custom lighting before reverting back to my original coolermaster portal saved RGB lighting setup. I have to restart the Aurora software/process by qutting the program and restarting before the device is captured again and custom RGB lighting works. Aurora software however captures the keystrokes for reactive effects while my board displays Portal's RGB effects.
How often does this problem occur?

This problem occurs every time the computer starts fresh, restarts or wake up from sleep.
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

Restart (or wake up from standby) the computer with the Pro L RGB attached.
Device should be captured by Aurora and work briefly with custom lighting, but will stop capturing and board reverts back to Coolermaster portal saved settings. I do not have Coolermaster's Portal software installed anymore and this still happens.
Kill and restart the Aurora program/process, then the custom lighting will revert back.

What is the version of Aurora you are experiencing this issue with?

My version is... (0.64-127)
Does the previous version of Aurora have this issue?
0.64-124 (3 versions behind if I recall correctly).
Please include any logs, screenshots, or files that are related to this issue:

2019-06-13 21.01.48.log
2019-06-13 21.03.24.log
2019-06-13 21.04.35.log
Uploading 2019-06-13 20.01.18.log…
Uploading 2019-06-13 20.02.16.log…
Uploading 2019-06-13 20.57.10.log…

2019-06-13 20.02.16.log
2019-06-13 20.57.10.log
2019-06-13 21.01.48.log
2019-06-13 21.03.24.log
2019-06-13 21.04.35.log
2019-06-13 20.01.18.log


No response while Installing clang-format for atom on Mac OS X

Before try "apm install clang-format", I have installed clang-fomat itself and put it into directory.
Here is the output when I input "clang-format --version" in terminal
clang-format version 5.0.0 (tags/google/stable/2017-03-17)
After that I try the command "apm install clang-format", but it always stuck at
Installing clang-format to /Users/ysh/.atom/packages......
Can anyone help me out?
By the way, the following is my apm version.
apm  1.16.1
npm  3.10.5
node 6.9.5 x64
python 2.7.13
git 2.13.1

I think this issue might be fixed as of 2.0.5 so i'm going to close this. if it is not fixed let me know and ill look into it


Table rows don't materialize on scroll if height is too large

Given a table with a fixed height
Inputs.table(penguins, { height: 400 })

scrolling through the table won't materialize new rows.
The exact height is dependant on various factors like page zoom. I tested (and found) the issue in Chrome, Firefox and Safari. Note that Safari may still load new rows on the first scroll.
Demonstration:
https://user-images.githubusercontent.com/322014/222896160-7881d4a1-1b59-418c-9bc4-66894dfa245a.mp4

Reproduction: https://observablehq.com/d/686eb071dc56c459. For me, it breaks at ≥ 379px tall, and above ~555px you can see even before you try to scroll that only the first page has loaded.

@simond shared the correct workaround in #261: Increase the number of rows until they expand enough beyond the visible area.
(I used to set - and recommend - {rows: Infinity} because I misunderstood what the option actually does.)

A fix might be to attach an IntersectionObserver to the last row and have that trigger the materializing of the next chunk.


how to add placeholder to ADM-dateTimePicker

How can I add placeholder to ADM-dateTimePicker?
<adm-dtp class="datetime-picker" ng-model='fromDate' options='{format: "YYYY/MM/DD", autoClose:true}'></adm-dtp>

if you want show anything else from datetime ,use placeholder and options at same time like below:


TentantId changes when none is configured with PublishEventsToWolverine

Hello,
When using Marten with IntegrateWithWolverine and PublishEventsToWolverine and no configuration about tenants, I noticed that the tentantId seems to change when handling published events.
Take the following code:
// start the stream:
session.Events.StartStream(id, new InitialEvent(id));

// then handle this event:
public static void Handle(IEvent<InitialEvent> @event, IDocumentSession session)
{
<EMAIL_ADDRESS>new SecondEvent(@event.Data.Id));
}

The tenantId for InitialEvent is *DEFAULT*, and the tenantId for SecondEvent is Marten. It seems to happen in the WolverineSubscriptionRunner code:

Is there a setting I'm missing?

There's no magic setting. If you'd like, that's a quick pull request to propagate the tenant id correctly


@conda-forge-admin,please add bot automerge

[ ] I read the conda-forge documentation and could not find the solution for my problem there.

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/bcj-cffi-feedstock#6.


update lang JA

@44uk Apologies for the failed preview. It should be fixed now. Feel free to reopen this PR!


Right-clicking anywhere on the map should bring up a 'paste' option, but nothing happens.

After copying an entity, right-clicking the map anywhere on the background (not on an entity) should bring up the  context menu with one option: paste.

Fixed in e8839fde2. Right-clicking anywhere on the background will nothing copied will open a greyed-out paste option just the way it used to:

Once we copy something, the paste option becomes selectable:


Add live option

When a protocol stream is live, the stream will not close after all existing channels are closed. This is useful for dynamically adding channels after the initial channel has been closed.

7.2.0


Added the missing code

Added the missing code for adding the ITodoRepository to the service.

Hi @dubeme, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

The missing code is actually due to incorrect line numbers in the literal include. Fixed: 8bfbd304ba5491347497dfe33d43b5f35f1ab75c


Body text size

Hello Anis,
first, thank you for all the effort to adapt the template to IMT Atlantique format. Is looks beautiful.
I understand that the body text is size 11pt Arial. Is there a way to change this value?
Thank you very much.

All these settings are defined in the class file IMTA-report.cls .
The general body size value is given by the line :
\LoadClass[12pt, oneside, a4paper]{report}

And font are defined , for example here :
\parindent 12pt
\RequirePackage{mathspec}
% use Arno Pro instead of standard LaTeX fonts
\setmathsfont(Digits,Latin,Greek)[
Path = fonts/,Extension = .ttf,
UprightFont=Arial-Regular,
BoldFont=Arial-Bold,
ItalicFont=Arial-Italic,
BoldItalicFont=Arial-BoldItalic,
Numbers={OldStyle,Proportional}]{Arial}
\setmathrm
[Path = fonts/,Extension = .ttf,
UprightFont=Arial-Regular,
BoldFont=Arial-Bold,
ItalicFont=Arial-Italic,
BoldItalicFont=Arial-BoldItalic
]{Arial}

\RequirePackage{xltxtra,xunicode}
\defaultfontfeatures{Mapping=tex-text}
\aliasfontfeatureoption{Ligatures}{Historic}{Historical}
\setromanfont
[Path = fonts/,
Extension = .ttf,
Mapping=tex-text,
Ligatures={Common},
UprightFont=Arial-Regular,
BoldFont=Arial-Bold,
ItalicFont=Arial-Italic,
BoldItalicFont=Arial-BoldItalic
]{Arial} %

If you wanna add some fonts, make sure that you add them before in the folder fonts.

Thanks a lot for your answer, works great. I was wondering if in that file there is a way to justify the text. The default is to be aligned to the left, but I found no option to change it. You have an idea to change this behavior? Thanks a lot.

Yes I make a modification to justify the text in the all document. I'm going to push this enhancement :) .

Pushed in the file IMTA-report.cls
% incluude each chapter...
--
  | **\justify**
  | \include{chapters/chapter1}
  | \include{chapters/chapter2}
  | \include{chapters/chapter3}

would this need a modification somewhere else (define the command)?
Undefined control sequence. \justify
Thank you.

@theevilcat  new push to IMTA-report.cls file. Please pull this file. If you get any issues please provide me more details. Thank you.

Tested it and works great. Thank you very much, you have been very helpful.

You're welcome, thank you for you contribution.
I close the issue. Don't hesitate to open it again or create an other if you still to have problem.


Code in GEOSldas is out-of-date to JP_GEOSldas_forGit2019-07-11

As the title says, the GEOSldas codebase is out-of-date wrt the CVS tag JP_GEOSldas_forGit2019-07-11

I think this is not true.


Update synapse installation doc

Description
This PR updates the documentation for installing a local synapse instance on Mac OS machines.

Would it be possible to point to the Synapse docs and ensure those are correct instead of duplicating them here?

Would it be possible to point to the Synapse docs and ensure those are correct instead of duplicating them here?

@clokep for what I saw the official documentation explains how to install synapse using prebuilt packages or as a PyPI module.
The goal of this update is being able to run a demo from sources which is useful especially for devs.
Do you think this knowledge is useful outside this repo? If yes, where do you think it should go?

Would it be possible to point to the Synapse docs and ensure those are correct instead of duplicating them here?

@clokep for what I saw the official documentation explains how to install synapse using prebuilt packages or as a PyPI module. The goal of this update is being able to run a demo from sources which is useful especially for devs. Do you think this knowledge is useful outside this repo? If yes, where do you think it should go?

There's a section on what you need to install for macOS: https://matrix-org.github.io/synapse/latest/setup/installation.html#macos
There's also information in the developer guide of requirements: https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#2-what-do-i-need
That seems to already mention rust though.

There's a section on what you need to install for macOS: https://matrix-org.github.io/synapse/latest/setup/installation.html#macos

This seems to be under PyPI. The scope is probably different.

There's also information in the developer guide of requirements: https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#2-what-do-i-need
That seems to already mention rust though.

Yeah it's mentioned.
So I guess most of dependencies are covered.
I think just icu4c and pg_config aren't.
The problem I guess is that there aren't platform specific sections for devs?
If so, it seems like there isn't a good spot where to merge this info in.


Latest timestamp Warning

HI
I see a warning on Latest timestamp componet. Is there any fix for this?

@fabiojose


Feature/traces comparer (power analysis)

Added traces comparer and trace classifier functionality.

Thank you @martinftlsx for really nice addition to the tool functionality!


By Phase/By Mode color toggle (WFRC)

Transportation Tab:

...we would like the ability for the user to click a control (ideally atop the layer/legend panel) that toggles the coloring from 'By Phase' to` 'By Mode' similar to how the awesome new RTP Projects map works. This does not need to include any of the advanced filter functionality as I think we'll direct people to the new map for that.

The new idea/plan is to switch the WC map to use the RTP map.
FY24 Q1 Sprint 1 Tasks:

[ ] Obtain test RTP web map from Sarah L.
[ ] Determine workload and next steps

Sprint 2 Tasks:

[ ] onto resolving this enhancement

Sent this to the client yesterday for feedback.


ReadMail operator need to handle FolderClosedException

When connected to a mail server, the server may disconnect when we are connected for too long.
The operator will get this exception:
javax.mail.FolderClosedException: * BYE JavaMail Exception: java.io.IOException: Connection dropped by server?
at com.sun.mail.imap.IMAPFolder.throwClosedException(IMAPFolder.java:2749)
at com.sun.mail.imap.IMAPFolder.idle(IMAPFolder.java:2551)
at com.sun.mail.imap.IMAPFolder.idle(IMAPFolder.java:2467)
at com.ibm.streamsx.mail.ReadMail.produceTuples(ReadMail.java:216)
at com.ibm.streamsx.mail.ReadMail.access$0(ReadMail.java:181)
at com.ibm.streamsx.mail.ReadMail$1.run(ReadMail.java:146)
at java.lang.Thread.run(Thread.java:785)
at com.ibm.streams.operator.internal.runtime.OperatorThreadFactory$2.run(OperatorThreadFactory.java:137)
We should handle this exception and reconnect to the server.

Fixed

Hi @chanskw, I want to know how did you fixe this error!please I realy need this solution

@amasj2d please see this around line 216:
https://github.com/IBMStreams/streamsx.mail/blob/master/com.ibm.streamsx.mail/impl/java/src/com/ibm/streamsx/mail/ReadMail.java
I caught the exception and reconnect after waiting for a period of time.

@chanskw many thanks for your quick answer, I'll see that and I'll give you a feedbaack. :)

@chanskw I guess calling the same method again in catch block for every FolderClosedException will result in OutOfMemoryError as the catch block never completes..Please Correct me if i am wrong.

I mean calling produceTuples() again and again


check if the maryMotherOfTheChurch is Obligatory Memorial in all calendars

While I’m gathering all (to me) available sources of Slovakian national celebrations, I came across this website. It talks about the Memorial of Blessed Mary, Mother of the Church. Vatican made it an Obligatory Memorial, i.e. it must be celebrated throughout the Church on Monday after Pentecost, with only one exception: Where the Monday or Tuesday after Pentecost are days on which the faithful are obliged or accustomed to attend Mass, the Mass of Pentecost Sunday may be repeated, or a Mass of the Holy Spirit may be said. (as the Roman Missal’s rubrics says).
I’ve already checked that the celebration is a memorial in general.mjs (and feast in national cals of Poland and Ukraine). But I am not sure how to check if it takes precedence in the event of coincidence with ‘another memorial of a saint or blessed; and when this happens, the feast of Mary, Mother of the Church, will take precedence’, as the document says.

Move maryMotherOfTheChurch to general section in src/locales/*mjs.


refactor(ajax): Move to simple Observable implementation. Fix errors.

Refactors ajax to use a simple Observable implementation.
Moves code to a new ajax-specific folder.
Adds a lot more documentation to classes and support classes.
Differentiates between the configuration passed to ajax (AjaxConfig) and the request values used to make the HTTP request (AjaxRequest), as the latter has more required values.
Ensures that no configuration values are mutated while making the request. (resolves #2801)
Ensures there is at least one valid test for ajax.patch. The old one was sketchy.
Adds better comments throughout the code.
Adds better typing to ajax functions.
Also ensures x-requested-with header is set properly
Adds comments
Code clean up
Normalize headers to be lowercase, since they are case insensitive.
Updates tests
Remove superfluous checks in unsubscribe
Ajax will now allow default behavior as defined in the specs:

https://xhr.spec.whatwg.org/#the-send()-method
https://fetch.spec.whatwg.org/#concept-bodyinit-extract

if the body is set to: Blob, ArrayBuffer, any array buffer view (like a byte sequence, e.g. Uint8Array, etc), FormData, URLSearchParams, string, or ReadableStream, default handling is use. If the body is otherwise typeof "object", then it will be converted to JSON via JSON.stringify, and the Content-Type header will be set to application/json;charset=utf-8. All other types will emit an error. (resolves #2837)
Puts the behavior in-line with Axios, et al.

BREAKING CHANGE: For TypeScript users, AjaxRequest is no longer the type that should be explicitly used to create an ajax. It is now AjaxConfig, although the two types are compatible, only AjaxConfig has progressSubscriber and createXHR.
BREAKING CHANGE: ajax body serialization will now use default XHR behavior in all cases. If the body is a Blob, ArrayBuffer, any array buffer view (like a byte sequence, e.g. Uint8Array, etc), FormData, URLSearchParams, string, or ReadableStream, default handling is use. If the body is otherwise typeof "object", then it will be converted to JSON via JSON.stringify, and the Content-Type header will be set to application/json;charset=utf-8. All other types will emit an error.
BREAKING CHANGE: The Content-Type header passed to ajax configuration no longer has any effect on the serialization behavior of the AJAX request.

As I'm going through the backlog of issues, I keep finding stuff related to ajax, so I've added a couple more commits to fix another (nasty) issue.

This also seems to need an API guardian update.

The API guardian is killing me. It seems like there's an issue where you have to rebase, THEN update api_guardian before it actually works. This is the third PR where I've had issues. The thing it's complaining about is unrelated to the PR.


Fix typescript client code

Fix various pieces of the client code. Introduce an end-to-end node test
that validates basic market creation and order book behavior. This
commit addresses the following major refactors on the Rust side:

Move callback info to the end of the slab
Case MarketState instead of deserializing

Tests are run via: npx jest

All right, this looks good to me, thanks a lot!


Fix/add decayed value to withdraw event

Fixes the remaining issues found during the MerkleDrop audit
closes https://github.com/trustlines-protocol/merkle-drop/issues/46
closes https://github.com/trustlines-protocol/blockchain/issues/223

Did you see my comment about the require(token.transfer(...))?
This is missing I would say.

Did you see my comment about the require(token.transfer(...))?
This is missing I would say.

Sorry,  forgot to add it. It is added now.

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   73.13%   73.13%
=======================================
  Files           6        6
  Lines         268      268
=======================================
  Hits          196      196
  Misses         72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f26694a...4446043. Read the comment docs.


adds support for deploying a docker-compose.yml (closes #10)

fargate service deploy <service-name> --file docker-compose.yml

Any chance to get this merged and released soon?

Closing since we've released this in our fork.
https://github.com/turnerlabs/fargate/releases/tag/v0.3.0

Closing since we've released this in our fork.
https://github.com/turnerlabs/fargate/releases/tag/v0.3.0

Closing since we've released this in our fork.
https://github.com/turnerlabs/fargate/releases/tag/v0.3.0


Report the number of vertices used per point.

Report the number of vertices used per point so that the internal use can be abstracted.

LGTM I believe 5bba24fabe460807bc8f66c1e250aafd031b1691 VGL sha now points to master?


added algorithms by languages section

Description
added algorithms for 3 languages in DSA .
Closes #759
Type of change

[x] Adding a new Resource
[x] Adding a new Category
[ ] Documentation enhancement or fixes
[ ] Website enhancement or fixes

Checklist:

[x] I read carefully CONTRIBUTING.md
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

Screenshots (if appropriate):
Please add screenshots to help explain your changes.
Additional

You just need to add '>' before the description, why did  you close? After that change I can merged it

This branch has conflicts shall I create new branch and open new PR for review,if it is okay I will close it.

You can fix it if you want here


Fix typo in StorgeRewrite

This PR correctly disables smem reusing when target is vulkan

cc: @MasterJH5574

A bit more context here: when building to Vulkan, we don't want to enable shared memory reuse, in order to avoid dtype mismatch issues when reusing smem from buffers with different dtypes.
Previously the flag for Vulkan is incorrectly set, which didn't effectively disable the shared memory reuse for Vulkan.
And this PR corrects the issue.


camera instrinsics change caused by images croped and resized

Hi~, thanks for your brilliant work again, I was wondering whether the camera intrinsics need to be recomputed after crop and resize process in the dataloader.

We don't make use of any of the camera intrinsics. We only predict camera extrinisics.


in utils>tools.ts create a function to manage the server logs

We need to prioritize this. Maybe pick a format that aligns best with google logs


Fix Bazel coverage.

Looks like Bazel 0.5.1 caused the .gcda to appear under runfiles, which
confuses gcov as it doesn't match the location of the .gcno.

@mattklein123 I need to head out now. This is roughly the fix, but I don't have time to wait for it to verify. Feel free to take over this PR to unblock coverage.

@dnoe can you just merge this fix into your PR so we can test it all together?

As long as this still passes on the old image, can also just merge this. Then merger master into the other PR. Can do it later.

I believe this change is independent of mine.  There is no expected change to the coverage in my change (death tests never reported coverage for covered lines).  Unfortunately this still seems to be failing the coverage test, it looks like there is something else wrong.  Let me see what I can find.

@htuch this isn't passing current CI. @dnoe this is related to your issue and should be the fix for why your PR can't pass CI. I think it would be best for the two of you to merge your PRs into something that passes, but whatever works.

Fix merged in @dnoe commit. Closing.


[Access] Get protocol snapshot by block id and block height

onflow/flow-go#4869
This pull request introduces two new requests for protocol state related to new methods GetProtocolStateSnapshotByBlockID and GetProtocolStateSnapshotByHeight.

Looks good so far, but you'll need rpc definitions for the new methods as well

Sorry, my bad. Added rpc definitions.


Misleading error for this invalid versionreq

Version 0.5.0
semver::VersionReq::parse("0.14.00").unwrap() fails with OpAlreadySet. Maybe it should fail with InvalidVersionRequirement
I assume the current behavior is because it's being treated like "0.14.0 0"

Yeah, errors are very much not great right now, and one of the reasons this isn't 1.0 yet. Thanks! This is a good case.

The error in 1.0.0 is a lot better.
fn main() {
    println!("{}", semver::VersionReq::parse("0.14.00").unwrap_err());
}

invalid leading zero in patch version number


[Dev-174968] Implement client id in ios sdk

This PR add cid and sessionCid behavior in the iOS SDK.

👍


Is this lab able to support output reference has ten sets of different value in each steps? If so, which file should I refer to? Thanks

I'd like to make a path planning with your lib. However, in your examples, it only has a constant output reference. However in my case, each step should has differenct values for output. Could you please help me to figure out how to do it?

For example, I have a desired path for each step as [x y z]T, and for each step it is differenct, I want the output in each prediction horizon approach to the desired output value. So the output value is not constant, how can I set the output reference and how to edit the constrain or objective function? Is there any option I can choose to realize it?

@nicolapiccinelli

Hi @ZhYGu are you talking about the linear MPC module? If so, I can add it or if you wish you can open a pull on this and contribute to the lib.

Yes, I am talking about LMPC. I am not sure how to input the different output references. I have not used osqp before, so it may be difficult for me to add it to this lib. However, I found in the problembuilder, it says varied reference is possible.
Could you tell me when the changing references are doable? Thanks.
获取 Outlook for iOS
发件人: Nicola Piccinelli @.>
发送时间: Thursday, November 10, 2022 4:00:50 AM
收件人: nicolapiccinelli/libmpc @.>
抄送: Z. Gu @.>; Mention @.>
主题: Re: [nicolapiccinelli/libmpc] Is this lab able to support output reference has ten sets of different value in each steps? If so, which file should I refer to? Thanks (Issue #5)
Hi
@ZhYGu are you talking about the linear MPC module? If so, I can add it or if you wish you can open a pull on this and contribute to the lib.
―
Reply to this email directly,
view it on GitHub, or
unsubscribe.
You are receiving this because you were mentioned.Message
ID: @.***>

Also, for the result, I found in your version only the first input will be returned. Is there any way I can get the result for each prediction horizons?
获取 Outlook for iOS
发件人: Nicola Piccinelli @.>
发送时间: Thursday, November 10, 2022 4:00:50 AM
收件人: nicolapiccinelli/libmpc @.>
抄送: Z. Gu @.>; Mention @.>
主题: Re: [nicolapiccinelli/libmpc] Is this lab able to support output reference has ten sets of different value in each steps? If so, which file should I refer to? Thanks (Issue #5)
Hi
@ZhYGu are you talking about the linear MPC module? If so, I can add it or if you wish you can open a pull on this and contribute to the lib.
―
Reply to this email directly,
view it on GitHub, or
unsubscribe.
You are receiving this because you were mentioned.Message
ID: @.***>

I will answer both your questions here:

Regarding the possibility of having different reference at each prediction horizon there is not a limit in the solver. As it is now it's just a matter of adding a new API in the LMPC class and then rework a bit the internal mechanism to provide the full reference to the optimizer instead of just copying the reference to all steps.
In this case I would have a new API to retrive the optimal sequence, since generally in the MPC we apply just the first optimal command in the sequence. Anyway, this could be useful in some cases.

Now the options are: I can take in charge of adding these functionalities to the current code base but it will take about 1 week, or if you feel confident enough you can take in charge of doing that (maybe just one of them) and then we can review your solution

@ZhYGu I’m working on the first point, probably tomorrow I will give a look into the retrieval of the optimal sequence. Unfortunately, there will be breaking changes in the LMPC api.

P {margin-top:0;margin-bottom:0;}
Thank you so much!
发件人: Nicola Piccinelli @.>
发送时间: 2022年11月12日 3:19
收件人: nicolapiccinelli/libmpc @.>
抄送: Z. Gu @.>; Mention @.>
主题: Re: [nicolapiccinelli/libmpc] Is this lab able to support output reference has ten sets of different value in each steps? If so, which file should I refer to? Thanks (Issue #5)
@ZhYGu I’m working
on the first point, probably tomorrow I will give a look into the retrieval of the optimal sequence. Unfortunately, there will be breaking changes in the LMPC api.
―
Reply to this email directly,
view it on GitHub, or
unsubscribe.
You are receiving this because you were mentioned.Message
ID: @.***>

@ZhYGu version 0.1.0 released, cheers!

！thats great
获取 Outlook for iOS
发件人: Nicola Piccinelli @.>
发送时间: Saturday, November 12, 2022 1:34:05 PM
收件人: nicolapiccinelli/libmpc @.>
抄送: Z. Gu @.>; Mention @.>
主题: Re: [nicolapiccinelli/libmpc] Is this lab able to support output reference has ten sets of different value in each steps? If so, which file should I refer to? Thanks (Issue #5)
@ZhYGu version 0.1.0
released, cheers!
―
Reply to this email directly,
view it on GitHub, or
unsubscribe.
You are receiving this because you were mentioned.Message
ID: @.***>


[ENG-4261] License validation

Ticket: ENG-4261
Feature flag: n/a

Purpose

Address some issues discovered when validating collection submission licenses

Summary of Changes

Fixed an issue where Year validation errors were being shown, even when the license did not require a year
Fixed an issue where a validation error for an unacceptable license was showing up when a user didn't change the license, but changed a different field in the Project Metadata section.

changes.license would be set to an empty object after changing other metadata fields, so validation to see if the currentLicense was acceptable by the provider would fail

Screenshot(s)

On collections/providerId/submit

Side Effects

Registration License validation should now also check the year format

QA Notes

Please check that the license validation works properly when submitting to a collection. Particulary when the license is already set to one that the provider doesn't accept, when it is changed to one that requires a year and copyright holder and when the year format is incorrect.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 5 (80.0%)  changed or added relevant lines in 1 file are covered.
9 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 71.75%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/packages/registration-schema/validations.ts
4
5
80.0%

Files with Coverage Reduction
New Missed Lines
%

app/packages/registration-schema/validations.ts
9
80.15%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
5574

Relevant Lines:
7546

💛  - Coveralls


PostgreSQL: object ID = 0 for columns

Object ID is always 0 for created columns (PostgreSQL 10).

Fixed.
There is no OID for PG columns but there is attnum (ordinal position) instead.
We'll use it and we'll refresh table after column create

verified


⚠ Bofrost.be has degraded performance

In 5b858ac, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1374 ms

Resolved: Bofrost.be performance has improved in 52d6754 after 8 minutes.


Feature:Hinge Max Margin one vs max hinge loss function

This is a one vs Max Margin loss (current hinge only one vs all).
An alternative to this function would be to modify the hinge function to take an argument comparison='one_vs_all' (current and default) or 'one_vs_max' this implementation.  I am open to either implementation.  Also I would suggest adding hinge support for 'Huber' "norm".
3 norms 'L2' (default,margin squared), 'L1' (margin) and Huber (quadratic for margin less than 2, else linear)
2 reduce methods 'mean' (default, average by example) and 'along_second_axis' (loss for each example)
Thank you.

+1 for providing it as a separate function.

@OrionWolfe The Travis tests failed. Could you check the errors and fix them?

Can I take over this?

Yes,
Best,
Orion
On Sat, Jun 15, 2019 at 4:37 AM Masaki Kozuki<EMAIL_ADDRESS>wrote:

Can I take over this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chainer/chainer/pull/5376?email_source=notifications&email_token=AB7CYULW6RE6MQFYTRWKADDP2TIBFA5CNFSM4FWDFQFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXYWINY#issuecomment-502359095,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB7CYUKAMVCVKPYRF7O2H5TP2TIBFANCNFSM4FWDFQFA
.

--
Orion Wolfe
925-366-3561


add learn-more.md

Description of your changes
Add docs/learn-more.md and minor update to roadmap.md
Checklist
I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[ ] Updated any relevant [documentation], [examples], or [release notes].
[ ] Updated the RBAC permissions in [clusterrole.yaml] to include any new types.

[skip ci]

@jbw976 done, thanks for the suggestion!


Ultimate Student OS

Experience
Anytype.20240611.144250.75.zip
Title
Ultimate Student OS
Screenshots

Description
The ultimate space for students! Student OS provides everything you need to take effective notes and ace all your classes. Student OS is also built to be extendable and customizable.
Categories
Dashboard, Education
Language
en-US
Terms

[X] I agree that this Experience is licensed under the MIT License.
[X] I have intellectual property rights and/or permission to contribute the Experience and its content.
[X] I confirm that the Experience does not contain any harmful or malicious content.

/gallery approve


Azure Language Summarization November 2023 Preview Features

Data Plane API - Pull Request
Add parameters for new public features:

Query-based extractive summarization
Custom aspect conversation summarization

API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

Link to API Spec engagement record issue:

Is this review for (select one):

[ ] a private preview
[x] a public preview
[ ] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

Design Document: https://microsoft-my.sharepoint.com/:p:/p/dahung/EdHa42sBGZdIuT4mADFxG0wBk2UdajKDnR5ONCPiDT47BA?e=ke8JlB
Previous API Spec Doc: https://microsoft.sharepoint.com/:w:/t/TextAnalyticsTeam/EcYf7VnUDBNNl8YCBFOBDWEB6KWE5UquOqUl4xugDZ0rig?e=gCu24H
Updated paths:

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Azure REST API Guidelines
OpenAPI Style Guidelines
Azure Breaking Change Policy

Helpful Links

Azure DevTools Wiki

@heaths any idea why the breaking change check is comparing against 2022-10-01-preview instead of actual latest preview 2023-04-15-preview?

@heaths any idea why the breaking change check is comparing against 2022-10-01-preview instead of actual latest preview 2023-04-15-preview?

Probably a bug in the validator, but we shouldn't actually be doing any breaking change detection (at least, not blocking a PR merge) between previews anyway. /cc @mikekistler @maririos

Please be sure to schedule a review. This is much larger than we typically do "over email".

@heaths most of the changes are from "rebasing" the dev/ contents from latest stable 2023-04-01 to latest preview 2023-04-15-preview in order to apply the proposed 2023-11-15-preview changes on top of them. Please let me know if there's a better way to reflect this.
The proposed API changes went through scheduled review per #25886

There's quite a few endpoints. All those went through review? Was review feedback from APIView as well as the board incorporate yet?

There's quite a few seemingly new endpoints. All those went through review? Was review feedback from APIView as well as the board incorporate yet?

The new endpoints were already in the existing 2023-04-15-preview API; the proposed 2023-11-15-preview API adds no new endpoints, only a few fields to existing endpoints. Feedback from the API review/board have already been incorporated.
If it would be helpful, I can remove the changes to the dev/ path to focus the comparison on specification/cognitiveservices/data-plane/Language/preview/2023-04-15-preview vs specification/cognitiveservices/data-plane/Language/preview/2023-11-15-preview

The dev/ folder is where changes should be made, then copied to specifications/ so it's fine there. It's actually easier to review the dev/ folder because you see changes and not a bunch of new files. That methodology is used in TypeSpecs as well.
Going forward, all changes should be made in dev/. The final PR should copy those to the right folder under specifications/ as an output. That's how TypeSpec generation of swaggers will effectively work as well. This process was documented for Cognitive Services internally. TypeSpecs will be under specifications/, but effectively work the same way.

Got it. I believe the problem was the 2023-04-15-preview specification was not copied to dev/ (#24891), which meant this PR introduced a lot of diffs when I copied the 2023-04-15-preview contents into dev/. Added you to an e-mail thread about this

@mikekistler @JeffreyRichter the breaking swagger changes are all in the dev/ folder and should not be triggering.
 Your team added required properties, which is a breaking change. These should be optional. Our SDKs are multi-version, and this requirement changes the class/input in ways that are breaking. Please see https://aka.ms/AzBreakingChangesPolicy.

Removing the suppressions label. It was added originally and never cleaned up when suppressions were removed. From a screenshot taken just now:


[BUG] ModuleNotFoundError: No module named 'discord'

You have selected A: Virtual Python Environment
Traceback (most recent call last):
File "C:\Users\MY COM\PycharmProjects\PalCON-Discord\main.py", line 3, in
import discord
ModuleNotFoundError: No module named 'discord'
The Python version is 3.11
i run start.bat, get the same error as above.
Is it a problem if I use a language other than English for config?

Seems like your venv file did not properly download?
Can you try the command : venv\scripts\activate.bat in the root directory of the project (This enters you into the python virtual environment which I assume was generated when you ran start.bat
And then enter pip install -r requirements.txt and let me know if the bot works after that.
Your project should have a venv created like this:

It has been created. If it seems to be a 3.12 version problem, the same problem will be issued even if it is deleted and only 3.11 version is laid out.

ok good work .
my work thx.

ok good work .
my work thx.

I will take it that you managed to fix the problem.
If you could document what you did here it would be great for future users, in the mean time I will close this issue thanks!

Found another problem. Can I comment here?

Found another problem. Can I comment here?

I prefer if you open up another issue post!

when i run python.exe -m pip install --upgrade pip i get this error at the end
       [^1]: For Python, any directory (with suitable naming) can be imported,                     even if it does not contain any.py` files.
On the other hand, currently there is no concept of package data
directory, all directories are treated like packages.
********************************************************************************
  !!
    check.warn(importable)
  copying multidict\__init__.pyi -> build\lib.win-amd64-cpython-312\multidict
  copying multidict\py.typed -> build\lib.win-amd64-cpython-312\multidict
  running build_ext
  building 'multidict._multidict' extension
  error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for multidict
Failed to build multidict
ERROR: Could not build wheels for multidict, which is required to install pyproject.toml-based projects`


Added some definition/notes on terms discussed at OSS-LA

Not sure if it's best to add these texts directly under this page or under ..metrics/activity/metrics as separate documents....

Sorry, I am afraid not. My notes for that group were not very detailed.

Because the definitions relate directly to the discussion from OSSNA, I think it's okay to have them in this document for easy access and to advance the conversation.


QPPSF-8850, SSL TF changes for Prod & Dev-pre Environments

Information

Fixes #_.
QPPSF-8850

Changes proposed in this PR:

Added variables for certificate_arn, ssm_secret for prod and dev-pre

Checklist

[ ] All JUnit tests pass (mvn clean verify).
[ ] New unit tests written to cover new functionality.
[ ] Added and updated JavaDocs for non-test classes and methods.
[ ] No local design debt. Do you feel that something is "ugly" after your changes?
[ ] Updated documentation (README.md, etc.) depending if the changes require it.

DevPre:

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:

create
~ update in-place

destroy
-/+ destroy and then create replacement

Terraform will perform the following actions:
module.conversion-tool.aws_ecs_cluster.conversion-tool-ecs-cluster will be updated in-place
~ resource "aws_ecs_cluster" "conversion-tool-ecs-cluster" {
arn                = "arn:aws:ecs:us-east-1:003384571330:cluster/qppsf-conversion-tool-devpre"
capacity_providers = []
id                 = "arn:aws:ecs:us-east-1:003384571330:cluster/qppsf-conversion-tool-devpre"
name               = "qppsf-conversion-tool-devpre"
tags               = {
"Name"            = "qppsf-ct-ecr-devpre"
"application"     = "ConversionTool"
"git-origin"      = "https://github.com/CMSgov/qpp-conversion-tool.git"
"owner"           = "qppar-final-scoring"
"pagerduty-email" =<EMAIL_ADDRESS>"project"         = "qppsf-ct"
"sensitivity"     = "PII/PHI"
"terraform"       = "true"
}
  + setting {
      + name  = "containerInsights"
      + value = "enabled"
    }
}

module.conversion-tool.aws_ecs_service.conversion-tool-service must be replaced
-/+ resource "aws_ecs_service" "conversion-tool-service" {
cluster                            = "arn:aws:ecs:us-east-1:003384571330:cluster/qppsf-conversion-tool-devpre"
deployment_maximum_percent         = 100
deployment_minimum_healthy_percent = 0
desired_count                      = 1
enable_ecs_managed_tags            = false
- health_check_grace_period_seconds  = 0 -> null
~ iam_role                           = "aws-service-role" -> (known after apply)
~ id                                 = "arn:aws:ecs:us-east-1:003384571330:service/qppsf-conversion-tool-devpre/conversion-tool-service-devpre" -> (known after apply)
launch_type                        = "FARGATE"
name                               = "conversion-tool-service-devpre"
platform_version                   = "1.4.0"
- propagate_tags                     = "NONE" -> null
scheduling_strategy                = "REPLICA"
tags                               = {
"Name"            = "qppsf-ct-ecr-devpre"
"application"     = "ConversionTool"
"git-origin"      = "https://github.com/CMSgov/qpp-conversion-tool.git"
"owner"           = "qppar-final-scoring"
"pagerduty-email" =<EMAIL_ADDRESS>"project"         = "qppsf-ct"
"sensitivity"     = "PII/PHI"
"terraform"       = "true"
}
~ task_definition                    = "arn:aws:ecs:us-east-1:003384571330:task-definition/qppsf-conversion-tool-td-devpre:6" -> (known after apply)
  - deployment_controller {
      - type = "ECS" -> null
    }

  - load_balancer { # forces replacement
      - container_name   = "conversion-tool" -> null
      - container_port   = 8080 -> null
      - target_group_arn = "arn:aws:elasticloadbalancing:us-east-1:003384571330:targetgroup/conversion-tg-devpre/61a11137fccb8427" -> null
    }
  + load_balancer { # forces replacement
      + container_name   = "conversion-tool"
      + container_port   = 8443
      + target_group_arn = (known after apply)
    }

    network_configuration {
        assign_public_ip = false
        security_groups  = [
            "sg-021c06e58040a87ed",
            "sg-0535b1c550ac2cc5c",
            "sg-07205d6051519c30a",
            "sg-0dbc84bd77b8b70e5",
        ]
        subnets          = [
            "subnet-0385992d38126623d",
            "subnet-0555e670ea8b3a3c9",
            "subnet-09cd2f786f9bb8533",
        ]
    }

  + placement_strategy {
      + field = (known after apply)
      + type  = (known after apply)
    }
}

module.conversion-tool.aws_ecs_task_definition.conversion-tool must be replaced
-/+ resource "aws_ecs_task_definition" "conversion-tool" {
~ arn                      = "arn:aws:ecs:us-east-1:003384571330:task-definition/qppsf-conversion-tool-td-devpre:2" -> (known after apply)
~ container_definitions    = jsonencode(
~ [ # forces replacement
~ {
command          = [
"/usr/src/run/qppConverter.sh",
]
- cpu              = 0 -> null
environment      = []
essential        = true
image            = "003384571330.dkr.ecr.us-east-1.amazonaws.com/qppsf/conversion-tool/devpre:latest"
logConfiguration = {
logDriver = "awslogs"
options   = {
awslogs-group         = "/qppsf/conversion-tool-devpre"
awslogs-region        = "us-east-1"
awslogs-stream-prefix = "devpre"
}
}
mountPoints      = []
name             = "conversion-tool"
~ portMappings     = [
~ {
~ containerPort = 8080 -> 8443
~ hostPort      = 8080 -> 8443
protocol      = "tcp"
},
]
secrets          = [
{
name      = "APP_ENV"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/APP_ENV"
},
{
name      = "AR_API_BASE_URL"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/AR_API_BASE_URL"
},
{
name      = "BUCKET_NAME"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/BUCKET_NAME"
},
{
name      = "CPC_END_DATE"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/CPC_END_DATE"
},
{
name      = "CPC_PLUS_BUCKET_NAME"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/CPC_PLUS_BUCKET_NAME"
},
{
name      = "CPC_PLUS_UNPROCESSED_FILTER_START_DATE"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/CPC_PLUS_UNPROCESSED_FILTER_START_DATE"
},
{
name      = "CPC_PLUS_VALIDATION_FILE"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/CPC_PLUS_VALIDATION_FILE"
},
{
name      = "DB_APP_PASSWORD"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/DB_APP_PASSWORD"
},
{
name      = "DB_APP_USERNAME"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/DB_APP_USERNAME"
},
{
name      = "DB_MASTER_PASSWORD"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/DB_MASTER_PASSWORD"
},
{
name      = "DB_MASTER_USERNAME"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/DB_MASTER_USERNAME"
},
{
name      = "DEPLOY0A_PUBLIC-I-P"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/DEPLOY0A_PUBLIC-I-P"
},
{
name      = "DYNAMO_TABLE_NAME"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/DYNAMO_TABLE_NAME"
},
{
name      = "FMS_TOKEN"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/FMS_TOKEN"
},
{
name      = "GDIT_NESSUS_PUB_KEY"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/GDIT_NESSUS_PUB_KEY"
},
{
name      = "JAVA_OPTS"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/JAVA_OPTS"
},
{
name      = "KMS_KEY"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/KMS_KEY"
},
{
name      = "NEWRELIC_API_KEY"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/NEWRELIC_API_KEY"
},
{
name      = "NEXUS_CREDS"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/NEXUS_CREDS"
},
{
name      = "NEXUS_HOST"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/NEXUS_HOST"
},
{
name      = "ORG_NAME"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/ORG_NAME"
},
{
name      = "SPLUNK_TOKEN"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/SPLUNK_TOKEN"
},
{
name      = "VALIDATION_URL"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/VALIDATION_URL"
},
{
name      = "RTI_ORG_NAME"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/devpre/conversion_tool/RTI_ORG_NAME"
},
]
volumesFrom      = []
} # forces replacement,
]
)
cpu                      = "2048"
execution_role_arn       = "arn:aws:iam::003384571330:role/qppsf-ct-execution-role-devpre"
family                   = "qppsf-conversion-tool-td-devpre"
~ id                       = "qppsf-conversion-tool-td-devpre" -> (known after apply)
memory                   = "5120"
network_mode             = "awsvpc"
requires_compatibilities = [
"FARGATE",
]
~ revision                 = 2 -> (known after apply)
- tags                     = {} -> null
task_role_arn            = "arn:aws:iam::003384571330:role/ecsTaskExecutionRole"
}
module.conversion-tool.aws_lb_listener.conversion-tool will be destroyed

resource "aws_lb_listener" "conversion-tool" {

arn               = "arn:aws:elasticloadbalancing:us-east-1:003384571330:listener/app/qppsf-conversion-tool-lb-devpre/2eac7db7d01559fc/39f181a38cb721b1" -> null

id                = "arn:aws:elasticloadbalancing:us-east-1:003384571330:listener/app/qppsf-conversion-tool-lb-devpre/2eac7db7d01559fc/39f181a38cb721b1" -> null

load_balancer_arn = "arn:aws:elasticloadbalancing:us-east-1:003384571330:loadbalancer/app/qppsf-conversion-tool-lb-devpre/2eac7db7d01559fc" -> null

port              = 80 -> null

protocol          = "HTTP" -> null

default_action {

order            = 1 -> null
target_group_arn = "arn:aws:elasticloadbalancing:us-east-1:003384571330:targetgroup/conversion-tg-devpre/61a11137fccb8427" -> null
type             = "forward" -> null
}
}

module.conversion-tool.aws_lb_listener.conversion-tool-ssl will be created

resource "aws_lb_listener" "conversion-tool-ssl" {

arn               = (known after apply)

certificate_arn   = "arn:aws:acm:us-east-1:003384571330:certificate/11076543-8f28-4cbd-955b-d78db666e05a"

id                = (known after apply)

load_balancer_arn = "arn:aws:elasticloadbalancing:us-east-1:003384571330:loadbalancer/app/qppsf-conversion-tool-lb-devpre/2eac7db7d01559fc"

port              = 443

protocol          = "HTTPS"

ssl_policy        = "ELBSecurityPolicy-2016-08"

default_action {

order            = (known after apply)
target_group_arn = (known after apply)
type             = "forward"
}
}

module.conversion-tool.aws_lb_target_group.conversion-tg will be destroyed

resource "aws_lb_target_group" "conversion-tg" {

arn                                = "arn:aws:elasticloadbalancing:us-east-1:003384571330:targetgroup/conversion-tg-devpre/61a11137fccb8427" -> null

arn_suffix                         = "targetgroup/conversion-tg-devpre/61a11137fccb8427" -> null

deregistration_delay               = 300 -> null

id                                 = "arn:aws:elasticloadbalancing:us-east-1:003384571330:targetgroup/conversion-tg-devpre/61a11137fccb8427" -> null

lambda_multi_value_headers_enabled = false -> null

load_balancing_algorithm_type      = "round_robin" -> null

name                               = "conversion-tg-devpre" -> null

port                               = 8080 -> null

protocol                           = "HTTP" -> null

proxy_protocol_v2                  = false -> null

slow_start                         = 0 -> null

tags                               = {

"Name"            = "qppsf-ct-ecr-devpre"
"application"     = "ConversionTool"
"git-origin"      = "https://github.com/CMSgov/qpp-conversion-tool.git"
"owner"           = "qppar-final-scoring"
"pagerduty-email" =<EMAIL_ADDRESS>"project"         = "qppsf-ct"
"sensitivity"     = "PII/PHI"
"terraform"       = "true"
} -> null

target_type                        = "ip" -> null

vpc_id                             = "vpc-0c315d14e8fe5482a" -> null

health_check {

enabled             = true -> null
healthy_threshold   = 3 -> null
interval            = 30 -> null
matcher             = "200-499" -> null
path                = "/health" -> null
port                = "traffic-port" -> null
protocol            = "HTTP" -> null
timeout             = 2 -> null
unhealthy_threshold = 3 -> null
}

stickiness {

cookie_duration = 86400 -> null
enabled         = false -> null
type            = "lb_cookie" -> null
}
}

module.conversion-tool.aws_lb_target_group.conversion-tg-ssl will be created

resource "aws_lb_target_group" "conversion-tg-ssl" {

arn                                = (known after apply)

arn_suffix                         = (known after apply)

deregistration_delay               = 300

id                                 = (known after apply)

lambda_multi_value_headers_enabled = false

load_balancing_algorithm_type      = (known after apply)

name                               = "conversion-tg-devpre-ssl"

port                               = 8443

protocol                           = "HTTPS"

proxy_protocol_v2                  = false

slow_start                         = 0

tags                               = {

"Name"            = "qppsf-ct-ecr-devpre"
"application"     = "ConversionTool"
"git-origin"      = "https://github.com/CMSgov/qpp-conversion-tool.git"
"owner"           = "qppar-final-scoring"
"pagerduty-email" =<EMAIL_ADDRESS>"project"         = "qppsf-ct"
"sensitivity"     = "PII/PHI"
"terraform"       = "true"
}

target_type                        = "ip"

vpc_id                             = "vpc-0c315d14e8fe5482a"

health_check {

enabled             = true
healthy_threshold   = 3
interval            = 30
matcher             = "200-499"
path                = "/health"
port                = "traffic-port"
protocol            = "HTTPS"
timeout             = (known after apply)
unhealthy_threshold = 3
}

stickiness {

cookie_duration = (known after apply)
enabled         = (known after apply)
type            = (known after apply)
}
}

module.conversion-tool.aws_security_group.ct_app will be updated in-place
~ resource "aws_security_group" "ct_app" {
arn                    = "arn:aws:ec2:us-east-1:003384571330:security-group/sg-07205d6051519c30a"
description            = "Allow inbound traffic"
egress                 = [
{
cidr_blocks      = [
"<IP_ADDRESS>/0",
]
description      = ""
from_port        = 0
ipv6_cidr_blocks = []
prefix_list_ids  = []
protocol         = "-1"
security_groups  = []
self             = false
to_port          = 0
},
]
id                     = "sg-07205d6051519c30a"
~ ingress                = [
- {
- cidr_blocks      = []
- description      = ""
- from_port        = 8080
- ipv6_cidr_blocks = []
- prefix_list_ids  = []
- protocol         = "tcp"
- security_groups  = [
- "sg-0dbc84bd77b8b70e5",
]
- self             = false
- to_port          = 8080
},
- {
- cidr_blocks      = []
- description      = ""
- from_port        = 80
- ipv6_cidr_blocks = []
- prefix_list_ids  = []
- protocol         = "tcp"
- security_groups  = [
- "sg-0dbc84bd77b8b70e5",
]
- self             = false
- to_port          = 8080
},
+ {
+ cidr_blocks      = []
+ description      = ""
+ from_port        = 8443
+ ipv6_cidr_blocks = []
+ prefix_list_ids  = []
+ protocol         = "tcp"
+ security_groups  = [
+ "sg-0dbc84bd77b8b70e5",
]
+ self             = false
+ to_port          = 8443
},
]
name                   = "conversion-tool-app-devpre"
owner_id               = "003384571330"
revoke_rules_on_delete = false
tags                   = {
"Name" = "conversion-tool-app-devpre"
}
vpc_id                 = "vpc-0c315d14e8fe5482a"
}
module.conversion-tool.aws_security_group_rule.allow_http will be destroyed

resource "aws_security_group_rule" "allow_http" {

cidr_blocks       = [

"<IP_ADDRESS>/21",
"<IP_ADDRESS>/24",
] -> null

from_port         = 80 -> null
id                = "sgrule-2843567321" -> null
ipv6_cidr_blocks  = [] -> null
prefix_list_ids   = [] -> null
protocol          = "tcp" -> null
security_group_id = "sg-0dbc84bd77b8b70e5" -> null
self              = false -> null
to_port           = 8080 -> null
type              = "ingress" -> null
}

module.conversion-tool.aws_security_group_rule.allow_https will be created

resource "aws_security_group_rule" "allow_https" {

cidr_blocks              = [

"<IP_ADDRESS>/21",
"<IP_ADDRESS>/24",
]

from_port                = 443
id                       = (known after apply)
protocol                 = "tcp"
security_group_id        = "sg-0dbc84bd77b8b70e5"
self                     = false
source_security_group_id = (known after apply)
to_port                  = 8443
type                     = "ingress"
}

module.conversion-tool.aws_security_group_rule.ct-ingress-from-http-elb-to-ui will be destroyed

resource "aws_security_group_rule" "ct-ingress-from-http-elb-to-ui" {

cidr_blocks              = [] -> null
from_port                = 80 -> null
id                       = "sgrule-2328014962" -> null
ipv6_cidr_blocks         = [] -> null
prefix_list_ids          = [] -> null
protocol                 = "tcp" -> null
security_group_id        = "sg-07205d6051519c30a" -> null
self                     = false -> null
source_security_group_id = "sg-0dbc84bd77b8b70e5" -> null
to_port                  = 8080 -> null
type                     = "ingress" -> null
}

module.conversion-tool.aws_security_group_rule.ct-ingress-from-https-elb-to-ui will be created

resource "aws_security_group_rule" "ct-ingress-from-https-elb-to-ui" {

from_port                = 443
id                       = (known after apply)
protocol                 = "tcp"
security_group_id        = "sg-07205d6051519c30a"
self                     = false
source_security_group_id = "sg-0dbc84bd77b8b70e5"
to_port                  = 8443
type                     = "ingress"
}

module.conversion-tool.aws_ssm_parameter.ssl_secret will be created

resource "aws_ssm_parameter" "ssl_secret" {

arn         = (known after apply)
description = "SSL KeyStore Password"
id          = (known after apply)
key_id      = (known after apply)
name        = "/qppar-sf/devpre/conversion_tool/SSL_SECRET"
overwrite   = true
tags        = {

"Name"            = "qppsf-ct-ssm-devpre"
"application"     = "ConversionTool"
"git-origin"      = "https://github.com/CMSgov/qpp-conversion-tool.git"
"owner"           = "qppar-final-scoring"
"pagerduty-email" =<EMAIL_ADDRESS>"project"         = "qppsf-ct"
"sensitivity"     = "PII/PHI"
"terraform"       = "true"
}

tier        = "Standard"
type        = "SecureString"
version     = (known after apply)
}

Plan: 7 to add, 2 to change, 6 to destroy.

Note: You didn't specify an "-out" parameter to save this plan, so Terraform
can't guarantee that exactly these actions will be performed if
"terraform apply" is subsequently run.

PROD:

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:

create
~ update in-place

destroy
-/+ destroy and then create replacement

Terraform will perform the following actions:
module.conversion-tool.aws_ecs_cluster.conversion-tool-ecs-cluster will be updated in-place
~ resource "aws_ecs_cluster" "conversion-tool-ecs-cluster" {
arn                = "arn:aws:ecs:us-east-1:003384571330:cluster/qppsf-conversion-tool-prod"
capacity_providers = []
id                 = "arn:aws:ecs:us-east-1:003384571330:cluster/qppsf-conversion-tool-prod"
name               = "qppsf-conversion-tool-prod"
tags               = {
"Name"            = "qppsf-ct-ecr-prod"
"application"     = "ConversionTool"
"git-origin"      = "https://github.com/CMSgov/qpp-conversion-tool.git"
"owner"           = "qppar-final-scoring"
"pagerduty-email" =<EMAIL_ADDRESS>"project"         = "qppsf-ct"
"sensitivity"     = "PII/PHI"
"terraform"       = "true"
}
  + setting {
      + name  = "containerInsights"
      + value = "enabled"
    }
}

module.conversion-tool.aws_ecs_service.conversion-tool-service must be replaced
-/+ resource "aws_ecs_service" "conversion-tool-service" {
cluster                            = "arn:aws:ecs:us-east-1:003384571330:cluster/qppsf-conversion-tool-prod"
deployment_maximum_percent         = 100
deployment_minimum_healthy_percent = 0
desired_count                      = 1
enable_ecs_managed_tags            = false
- health_check_grace_period_seconds  = 0 -> null
~ iam_role                           = "aws-service-role" -> (known after apply)
~ id                                 = "arn:aws:ecs:us-east-1:003384571330:service/qppsf-conversion-tool-prod/conversion-tool-service-prod" -> (known after apply)
launch_type                        = "FARGATE"
name                               = "conversion-tool-service-prod"
platform_version                   = "1.4.0"
- propagate_tags                     = "NONE" -> null
scheduling_strategy                = "REPLICA"
tags                               = {
"Name"            = "qppsf-ct-ecr-prod"
"application"     = "ConversionTool"
"git-origin"      = "https://github.com/CMSgov/qpp-conversion-tool.git"
"owner"           = "qppar-final-scoring"
"pagerduty-email" =<EMAIL_ADDRESS>"project"         = "qppsf-ct"
"sensitivity"     = "PII/PHI"
"terraform"       = "true"
}
~ task_definition                    = "arn:aws:ecs:us-east-1:003384571330:task-definition/qppsf-conversion-tool-td-prod:6" -> (known after apply)
  - deployment_controller {
      - type = "ECS" -> null
    }

  - load_balancer { # forces replacement
      - container_name   = "conversion-tool" -> null
      - container_port   = 8080 -> null
      - target_group_arn = "arn:aws:elasticloadbalancing:us-east-1:003384571330:targetgroup/conversion-tg-prod/bf1235d1aec5bb66" -> null
    }
  + load_balancer { # forces replacement
      + container_name   = "conversion-tool"
      + container_port   = 8443
      + target_group_arn = (known after apply)
    }

    network_configuration {
        assign_public_ip = false
        security_groups  = [
            "sg-0ddf985740c094a69",
            "sg-0e171ff1419a3a8ce",
            "sg-669c0815",
            "sg-c15807b5",
        ]
        subnets          = [
            "subnet-383e245d",
            "subnet-3df1b275",
            "subnet-624ecd38",
        ]
    }

  + placement_strategy {
      + field = (known after apply)
      + type  = (known after apply)
    }
}

module.conversion-tool.aws_ecs_task_definition.conversion-tool must be replaced
-/+ resource "aws_ecs_task_definition" "conversion-tool" {
~ arn                      = "arn:aws:ecs:us-east-1:003384571330:task-definition/qppsf-conversion-tool-td-prod:2" -> (known after apply)
~ container_definitions    = jsonencode(
~ [ # forces replacement
~ {
command          = [
"/usr/src/run/qppConverter.sh",
]
- cpu              = 0 -> null
environment      = []
essential        = true
image            = "003384571330.dkr.ecr.us-east-1.amazonaws.com/qppsf/conversion-tool/prod:latest"
logConfiguration = {
logDriver = "awslogs"
options   = {
awslogs-group         = "/qppsf/conversion-tool-prod"
awslogs-region        = "us-east-1"
awslogs-stream-prefix = "prod"
}
}
mountPoints      = []
name             = "conversion-tool"
~ portMappings     = [
~ {
~ containerPort = 8080 -> 8443
~ hostPort      = 8080 -> 8443
protocol      = "tcp"
},
]
secrets          = [
{
name      = "APP_ENV"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/APP_ENV"
},
{
name      = "AR_API_BASE_URL"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/AR_API_BASE_URL"
},
{
name      = "BUCKET_NAME"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/BUCKET_NAME"
},
{
name      = "CPC_END_DATE"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/CPC_END_DATE"
},
{
name      = "CPC_PLUS_BUCKET_NAME"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/CPC_PLUS_BUCKET_NAME"
},
{
name      = "CPC_PLUS_UNPROCESSED_FILTER_START_DATE"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/CPC_PLUS_UNPROCESSED_FILTER_START_DATE"
},
{
name      = "CPC_PLUS_VALIDATION_FILE"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/CPC_PLUS_VALIDATION_FILE"
},
{
name      = "DB_APP_PASSWORD"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/DB_APP_PASSWORD"
},
{
name      = "DB_APP_USERNAME"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/DB_APP_USERNAME"
},
{
name      = "DB_MASTER_PASSWORD"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/DB_MASTER_PASSWORD"
},
{
name      = "DB_MASTER_USERNAME"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/DB_MASTER_USERNAME"
},
{
name      = "DEPLOY0A_PUBLIC-I-P"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/DEPLOY0A_PUBLIC-I-P"
},
{
name      = "DYNAMO_TABLE_NAME"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/DYNAMO_TABLE_NAME"
},
{
name      = "FMS_TOKEN"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/FMS_TOKEN"
},
{
name      = "GDIT_NESSUS_PUB_KEY"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/GDIT_NESSUS_PUB_KEY"
},
{
name      = "JAVA_OPTS"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/JAVA_OPTS"
},
{
name      = "KMS_KEY"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/KMS_KEY"
},
{
name      = "NEWRELIC_API_KEY"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/NEWRELIC_API_KEY"
},
{
name      = "NEXUS_CREDS"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/NEXUS_CREDS"
},
{
name      = "NEXUS_HOST"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/NEXUS_HOST"
},
{
name      = "ORG_NAME"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/ORG_NAME"
},
{
name      = "SPLUNK_TOKEN"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/SPLUNK_TOKEN"
},
{
name      = "VALIDATION_URL"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/VALIDATION_URL"
},
{
name      = "RTI_ORG_NAME"
valueFrom = "arn:aws:ssm:us-east-1:003384571330:parameter/qppar-sf/prod/conversion_tool/RTI_ORG_NAME"
},
]
volumesFrom      = []
} # forces replacement,
]
)
cpu                      = "2048"
execution_role_arn       = "arn:aws:iam::003384571330:role/qppsf-ct-execution-role-prod"
family                   = "qppsf-conversion-tool-td-prod"
~ id                       = "qppsf-conversion-tool-td-prod" -> (known after apply)
memory                   = "5120"
network_mode             = "awsvpc"
requires_compatibilities = [
"FARGATE",
]
~ revision                 = 2 -> (known after apply)
- tags                     = {} -> null
task_role_arn            = "arn:aws:iam::003384571330:role/ecsTaskExecutionRole"
}
module.conversion-tool.aws_lb_listener.conversion-tool will be destroyed

resource "aws_lb_listener" "conversion-tool" {

arn               = "arn:aws:elasticloadbalancing:us-east-1:003384571330:listener/app/qppsf-conversion-tool-lb-prod/4f73b9db1b13baf2/982692373de5419f" -> null

id                = "arn:aws:elasticloadbalancing:us-east-1:003384571330:listener/app/qppsf-conversion-tool-lb-prod/4f73b9db1b13baf2/982692373de5419f" -> null

load_balancer_arn = "arn:aws:elasticloadbalancing:us-east-1:003384571330:loadbalancer/app/qppsf-conversion-tool-lb-prod/4f73b9db1b13baf2" -> null

port              = 80 -> null

protocol          = "HTTP" -> null

default_action {

order            = 1 -> null
target_group_arn = "arn:aws:elasticloadbalancing:us-east-1:003384571330:targetgroup/conversion-tg-prod/bf1235d1aec5bb66" -> null
type             = "forward" -> null
}
}

module.conversion-tool.aws_lb_listener.conversion-tool-ssl will be created

resource "aws_lb_listener" "conversion-tool-ssl" {

arn               = (known after apply)

certificate_arn   = "arn:aws:acm:us-east-1:003384571330:certificate/9d8f082e-c572-4a62-ab29-e2c88877471a"

id                = (known after apply)

load_balancer_arn = "arn:aws:elasticloadbalancing:us-east-1:003384571330:loadbalancer/app/qppsf-conversion-tool-lb-prod/4f73b9db1b13baf2"

port              = 443

protocol          = "HTTPS"

ssl_policy        = "ELBSecurityPolicy-2016-08"

default_action {

order            = (known after apply)
target_group_arn = (known after apply)
type             = "forward"
}
}

module.conversion-tool.aws_lb_target_group.conversion-tg will be destroyed

resource "aws_lb_target_group" "conversion-tg" {

arn                                = "arn:aws:elasticloadbalancing:us-east-1:003384571330:targetgroup/conversion-tg-prod/bf1235d1aec5bb66" -> null

arn_suffix                         = "targetgroup/conversion-tg-prod/bf1235d1aec5bb66" -> null

deregistration_delay               = 300 -> null

id                                 = "arn:aws:elasticloadbalancing:us-east-1:003384571330:targetgroup/conversion-tg-prod/bf1235d1aec5bb66" -> null

lambda_multi_value_headers_enabled = false -> null

load_balancing_algorithm_type      = "round_robin" -> null

name                               = "conversion-tg-prod" -> null

port                               = 8080 -> null

protocol                           = "HTTP" -> null

proxy_protocol_v2                  = false -> null

slow_start                         = 0 -> null

tags                               = {

"Name"            = "qppsf-ct-ecr-prod"
"application"     = "ConversionTool"
"git-origin"      = "https://github.com/CMSgov/qpp-conversion-tool.git"
"owner"           = "qppar-final-scoring"
"pagerduty-email" =<EMAIL_ADDRESS>"project"         = "qppsf-ct"
"sensitivity"     = "PII/PHI"
"terraform"       = "true"
} -> null

target_type                        = "ip" -> null

vpc_id                             = "vpc-fa45d483" -> null

health_check {

enabled             = true -> null
healthy_threshold   = 3 -> null
interval            = 30 -> null
matcher             = "200-499" -> null
path                = "/health" -> null
port                = "traffic-port" -> null
protocol            = "HTTP" -> null
timeout             = 5 -> null
unhealthy_threshold = 3 -> null
}

stickiness {

cookie_duration = 86400 -> null
enabled         = false -> null
type            = "lb_cookie" -> null
}
}

module.conversion-tool.aws_lb_target_group.conversion-tg-ssl will be created

resource "aws_lb_target_group" "conversion-tg-ssl" {

arn                                = (known after apply)

arn_suffix                         = (known after apply)

deregistration_delay               = 300

id                                 = (known after apply)

lambda_multi_value_headers_enabled = false

load_balancing_algorithm_type      = (known after apply)

name                               = "conversion-tg-prod-ssl"

port                               = 8443

protocol                           = "HTTPS"

proxy_protocol_v2                  = false

slow_start                         = 0

tags                               = {

"Name"            = "qppsf-ct-ecr-prod"
"application"     = "ConversionTool"
"git-origin"      = "https://github.com/CMSgov/qpp-conversion-tool.git"
"owner"           = "qppar-final-scoring"
"pagerduty-email" =<EMAIL_ADDRESS>"project"         = "qppsf-ct"
"sensitivity"     = "PII/PHI"
"terraform"       = "true"
}

target_type                        = "ip"

vpc_id                             = "vpc-fa45d483"

health_check {

enabled             = true
healthy_threshold   = 3
interval            = 30
matcher             = "200-499"
path                = "/health"
port                = "traffic-port"
protocol            = "HTTPS"
timeout             = (known after apply)
unhealthy_threshold = 3
}

stickiness {

cookie_duration = (known after apply)
enabled         = (known after apply)
type            = (known after apply)
}
}

module.conversion-tool.aws_security_group.ct_app will be updated in-place
~ resource "aws_security_group" "ct_app" {
arn                    = "arn:aws:ec2:us-east-1:003384571330:security-group/sg-0e171ff1419a3a8ce"
description            = "Allow inbound traffic"
egress                 = [
{
cidr_blocks      = [
"<IP_ADDRESS>/0",
]
description      = ""
from_port        = 0
ipv6_cidr_blocks = []
prefix_list_ids  = []
protocol         = "-1"
security_groups  = []
self             = false
to_port          = 0
},
]
id                     = "sg-0e171ff1419a3a8ce"
~ ingress                = [
- {
- cidr_blocks      = []
- description      = ""
- from_port        = 8080
- ipv6_cidr_blocks = []
- prefix_list_ids  = []
- protocol         = "tcp"
- security_groups  = [
- "sg-0ddf985740c094a69",
]
- self             = false
- to_port          = 8080
},
+ {
+ cidr_blocks      = []
+ description      = ""
+ from_port        = 8443
+ ipv6_cidr_blocks = []
+ prefix_list_ids  = []
+ protocol         = "tcp"
+ security_groups  = [
+ "sg-0ddf985740c094a69",
]
+ self             = false
+ to_port          = 8443
},
]
name                   = "conversion-tool-app-prod"
owner_id               = "003384571330"
revoke_rules_on_delete = false
tags                   = {
"Name" = "conversion-tool-app-prod"
}
vpc_id                 = "vpc-fa45d483"
}
module.conversion-tool.aws_security_group_rule.allow_http will be destroyed

resource "aws_security_group_rule" "allow_http" {

cidr_blocks       = [

"<IP_ADDRESS>/21",
"<IP_ADDRESS>/24",
] -> null

from_port         = 80 -> null
id                = "sgrule-1541217536" -> null
ipv6_cidr_blocks  = [] -> null
prefix_list_ids   = [] -> null
protocol          = "tcp" -> null
security_group_id = "sg-0ddf985740c094a69" -> null
self              = false -> null
to_port           = 8080 -> null
type              = "ingress" -> null
}

module.conversion-tool.aws_security_group_rule.allow_https will be created

resource "aws_security_group_rule" "allow_https" {

cidr_blocks              = [

"<IP_ADDRESS>/21",
"<IP_ADDRESS>/24",
]

from_port                = 443
id                       = (known after apply)
protocol                 = "tcp"
security_group_id        = "sg-0ddf985740c094a69"
self                     = false
source_security_group_id = (known after apply)
to_port                  = 8443
type                     = "ingress"
}

module.conversion-tool.aws_security_group_rule.ct-ingress-from-https-elb-to-ui will be created

resource "aws_security_group_rule" "ct-ingress-from-https-elb-to-ui" {

from_port                = 443
id                       = (known after apply)
protocol                 = "tcp"
security_group_id        = "sg-0e171ff1419a3a8ce"
self                     = false
source_security_group_id = "sg-0ddf985740c094a69"
to_port                  = 8443
type                     = "ingress"
}

module.conversion-tool.aws_ssm_parameter.ssl_secret will be created

resource "aws_ssm_parameter" "ssl_secret" {

arn         = (known after apply)
description = "SSL KeyStore Password"
id          = (known after apply)
key_id      = (known after apply)
name        = "/qppar-sf/prod/conversion_tool/SSL_SECRET"
overwrite   = true
tags        = {

"Name"            = "qppsf-ct-ssm-prod"
"application"     = "ConversionTool"
"git-origin"      = "https://github.com/CMSgov/qpp-conversion-tool.git"
"owner"           = "qppar-final-scoring"
"pagerduty-email" =<EMAIL_ADDRESS>"project"         = "qppsf-ct"
"sensitivity"     = "PII/PHI"
"terraform"       = "true"
}

tier        = "Standard"
type        = "SecureString"
version     = (known after apply)
}

Plan: 7 to add, 2 to change, 5 to destroy.