Fixed a broken test

Also running the tests on our jenkins

appengine/flexible/metadata/test/DeployTest.php, it must have been broken for a while. I think it happened with refactoring. The fix in datastore/tutorial/test/FunctionsTest.php is for less flakiness.

The test is still failing with:
1) LocalTest::testHome
Google\Cloud\Exception\ServiceException: {
 "error": {
  "errors": [
   {
    "domain": "global",
    "reason": "forbidden",
    "message": "Caller does not have storage.objects.get access to object cloud-samples-tests-php/hello_flex.txt."
   }
  ],
  "code": 403,
  "message": "Caller does not have storage.objects.get access to object cloud-samples-tests-php/hello_flex.txt."
 }
}

/workspace/php-docs-samples/appengine/flexible/storage/vendor/google/cloud/src/RequestWrapper.php:219
/workspace/php-docs-samples/appengine/flexible/storage/vendor/google/cloud/src/RequestWrapper.php:136
/workspace/php-docs-samples/appengine/flexible/storage/vendor/google/cloud/src/RestTrait.php:80
/workspace/php-docs-samples/appengine/flexible/storage/vendor/google/cloud/src/Storage/Connection/Rest.php:173
/workspace/php-docs-samples/appengine/flexible/storage/vendor/google/cloud/src/Storage/StorageObject.php:135
/workspace/php-docs-samples/appengine/flexible/storage/app.php:35
/workspace/php-docs-samples/appengine/flexible/storage/vendor/symfony/http-kernel/HttpKernel.php:144
/workspace/php-docs-samples/appengine/flexible/storage/vendor/symfony/http-kernel/HttpKernel.php:64
/workspace/php-docs-samples/appengine/flexible/storage/vendor/silex/silex/src/Silex/Application.php:586
/workspace/php-docs-samples/appengine/flexible/storage/vendor/symfony/http-kernel/Client.php:79
/workspace/php-docs-samples/appengine/flexible/storage/vendor/symfony/browser-kit/Client.php:315
/workspace/php-docs-samples/appengine/flexible/storage/test/LocalTest.php:56

It fails when the file in question was uploaded by another service account, because the service account used in the test can not read that file.
I have just updated our Travis config to use the same service account as the one used on our jenkins.

Still failing:
There was 1 error:

1) Google\Cloud\Samples\Kms\KeyCommandTest::testListCryptoKeys
Google_Service_Exception: {
  "error": {
    "code": 400,
    "message": "Resource name 'projects/cloud-samples-tests-php/locations/global/keyRings/' does not match pattern 'projects/([^/]+)/locations/([a-zA-Z0-9_-]{1,63})/keyRings/([a-zA-Z0-9_-]{1,63})'.",
    "errors": [
      {
        "message": "Resource name 'projects/cloud-samples-tests-php/locations/global/keyRings/' does not match pattern 'projects/([^/]+)/locations/([a-zA-Z0-9_-]{1,63})/keyRings/([a-zA-Z0-9_-]{1,63})'.",
        "domain": "global",
        "reason": "badRequest"
      }
    ],
    "status": "INVALID_ARGUMENT"
  }
}

/workspace/php-docs-samples/kms/api/vendor/google/apiclient/src/Google/Http/REST.php:118
/workspace/php-docs-samples/kms/api/vendor/google/apiclient/src/Google/Http/REST.php:94
/workspace/php-docs-samples/kms/api/vendor/google/apiclient/src/Google/Task/Runner.php:181
/workspace/php-docs-samples/kms/api/vendor/google/apiclient/src/Google/Http/REST.php:58
/workspace/php-docs-samples/kms/api/vendor/google/apiclient/src/Google/Client.php:789
/workspace/php-docs-samples/kms/api/vendor/google/apiclient/src/Google/Service/Resource.php:232
/workspace/php-docs-samples/kms/api/vendor/google/apiclient-services/src/Google/Service/CloudKMS/Resource/ProjectsLocationsKeyRingsCryptoKeys.php:130
/workspace/php-docs-samples/kms/api/src/functions.php:397
/workspace/php-docs-samples/kms/api/src/KeyCommand.php:106
/workspace/php-docs-samples/kms/api/vendor/symfony/console/Command/Command.php:262
/workspace/php-docs-samples/kms/api/vendor/symfony/console/Tester/CommandTester.php:86
/workspace/php-docs-samples/kms/api/test/KeyCommandTest.php:51

@bshaffer Can you look at it and add a commit to this branch?

It looks like there are no KMS related envvar on our jenkins. I change the test to skip when the envvar is not present.

Travis seems busy. I kicked off our jenkins build.

The tests are still failing. Note: there must be one deployment is leaking in one of our e2e tests, and there were lots of versions deployed. I'm cleaning them up, and run the tests again.

Getting better, but it's still not green.
running phpunit in kms/api
+ phpunit
PHPUnit 4.8.24 by Sebastian Bergmann and contributors.
Warning:	The Xdebug extension is not loaded
		No code coverage will be generated.

EEESESESES..........ES

Time: 3.77 seconds, Memory: 17.75Mb

There were 7 errors:

1) Google\Cloud\Samples\Kms\EncryptionCommandTest::testEncrypt
Google_Service_Exception: {
  "error": {
    "code": 403,
    "message": "The caller does not have permission",
    "errors": [
      {
        "message": "The caller does not have permission",
        "domain": "global",
        "reason": "forbidden"
      }
    ],
    "status": "PERMISSION_DENIED"
  }
}

@bshaffer If you can take over this CL, that would be great since you're the most knowledgeable on those tests.


Support median in Groupby.aggregate

Blocked by ~https://github.com/dask/dask/pull/10835~ ~dask/dask#10840~
Closes #592
Sibling to https://github.com/dask/dask/pull/10832

the dask/dask pr is merged

Empty commits with [skip-caching] don't seem to be doing anything. See https://github.com/dask-contrib/dask-expr/pull/804

CI failure is #806

@hendrikmakait I'm confused.
These are still failing in the dask-expr CI:
FAILED ../../../micromamba/envs/dask-expr/lib/python3.9/site-packages/dask/dataframe/tests/test_groupby.py::test_groupby_aggregate_partial_function_unexpected_args[disk-<lambda>0] - AssertionError: Regex pattern did not match.
 Regex: "doesn't support positional arguments|'Series' object cannot be interpreted as an integer"
 Input: "cannot convert the series to <class 'int'>"
FAILED ../../../micromamba/envs/dask-expr/lib/python3.9/site-packages/dask/dataframe/tests/test_groupby.py::test_groupby_aggregate_partial_function_unexpected_args[disk-<lambda>1] - AssertionError: Regex pattern did not match.
 Regex: "doesn't support positional arguments|'Series' object cannot be interpreted as an integer"
 Input: "cannot convert the series to <class 'int'>"
FAILED ../../../micromamba/envs/dask-expr/lib/python3.9/site-packages/dask/dataframe/tests/test_groupby.py::test_groupby_aggregate_partial_function_unexpected_args[tasks-<lambda>0] - AssertionError: Regex pattern did not match.
 Regex: "doesn't support positional arguments|'Series' object cannot be interpreted as an integer"
 Input: "cannot convert the series to <class 'int'>"
FAILED ../../../micromamba/envs/dask-expr/lib/python3.9/site-packages/dask/dataframe/tests/test_groupby.py::test_groupby_aggregate_partial_function_unexpected_args[tasks-<lambda>1] - AssertionError: Regex pattern did not match.
 Regex: "doesn't support positional arguments|'Series' object cannot be interpreted as an integer"
 Input: "cannot convert the series to <class 'int'>"

However, if I run manually in dask/dask, I get everything green. Same pandas version...

thx


Pull Requests controller sometimes doesn’t re-adjust after pull to refresh

Tough to repro, I've only seen it a few times. Figure that makes this the lowest of low priority
Sent with GitHawk

I bet this and #490 are related... I hate this bug
Sent with GitHawk

😭 How do you think they are related tho @rnystrom?

Oh I read this as “update” not adjust, lol. Ignore me.
Sent with GitHawk


Feedback after going through the lab

Using W10 clients can overcomplicate the lab configuration!

with W10 a lot of additional steps than the ones mentioned in the lab documentation are required to get this exact scenarios working. Test using W7 clients!

If you really want to configure the SAM-R capabilities, the easiest way is to add a WS2016 DC in the domain and edit the policy on that machine, as you will not find the setting: "Network access: Restrict clients allowed to make remote calls to SAM" on the 2012R2 even after patching.
In the documentation, the screenshot for the output of the command: Get-NetLocalGroup <IP_ADDRESS> is actually wrong, that's the output for a different command: Get-NetLocalGroupMember <IP_ADDRESS> -GroupName Administrators.
In my case, when I ran klist (at the documentation section: "Additional lateral move") I noticed that there were no tickets. After taking network traces, I noticed that was because I was using W10 and Kerberos was failing with: Err_Preauth_required (after following all the steps in the documentation) and it was using NTLM, so I decided to test with W7 and noticed that with W7 I was able to get the needed TGT.
The "Remote code execution attempt" alert appears in the portal but it does not show the user under the column: accounts.
The following 2 alerts do not appear in my case :

"Suspected DCSynck attack (replication of directory services)" alert does not appear in the portal, although I followed the steps and got the NTLM hash for the KRBTGT account.

"Suspected golden ticket usage (encryption downgrade)"
(if these 2 will appear later, I'll come back and remove the entry)

Hope this helps anyone who's also going through this lab!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b4bfe698-05a4-8d4c-75b8-024ab912e18c
Version Independent ID: 4d58c76d-b7b5-9900-9c14-557f892cc54e
Content: Microsoft Defender for Identity Security Alert Lateral Movement Playbook
Content Source: ATPDocs/playbook-lateral-movement.md
Service: microsoft-defender-for-identity
GitHub Login: @dcurwin
Microsoft Alias: dacurwin

Thanks for your comments. We'll investigate and get back to you.

Thank you again for your comments. The engineers are currently working on a new lab, and so we will replace the documentation when that is ready.


Update dependencies

Update dependencies to use Guzzle ~6.0.

The code doesn't need to change?

Tested it and everything seems to work :smiley:


customVariablesWhitelist would benefit from scoping

We have currently implemented some exceptions for array properties which come from an external object. As we don't have control over the property styling, this seems like a good way to prevent any errors.
<rule ref="WordPress.NamingConventions.ValidVariableName">
        <properties>
            <property name="customVariablesWhitelist" type="array" value="pageUrl,responseCode,siteEntry,siteUrl,countPerTypes,urlCrawlErrorSample,buyUrl,infoUrl" />
        </properties>
</rule>

What I see happening is, that the properties on any array will be accepted.
So if somebody would use responseCode on an object internally, it would be not be caught.
Perhaps it would be possible to provide a function or class scope in which this whitelist will be enforced.

Duplicate of #1623
While #1623 is more recent, it contains more information about a possible solution direction, so I'm closing this issue in favour of continuing the discussion in #1623.


FileNotFoundException on Bullseye

Hi,
I made a new SD based on Bullseye today and after finally getting it to boot with the touch screen, I am now running into backlight issues because the /sys/class/backlight/rpi_backlight folder does not exist. Apart from this, the screen, including touch, works perfectly normal.
Full trace:
pi@retinapi:~ $ rpi-backlight -b 100
Traceback (most recent call last):
  File "/home/pi/.local/bin/rpi-backlight", line 8, in <module>
    sys.exit(main())
  File "/home/pi/.local/lib/python3.9/site-packages/rpi_backlight/cli.py", line 78, in main
    backlight = Backlight(
  File "/home/pi/.local/lib/python3.9/site-packages/rpi_backlight/__init__.py", line 75, in __init__
    self._max_brightness = self._get_value("max_brightness")  # 255
  File "/home/pi/.local/lib/python3.9/site-packages/rpi_backlight/__init__.py", line 92, in _get_value
    raise e
  File "/home/pi/.local/lib/python3.9/site-packages/rpi_backlight/__init__.py", line 84, in _get_value
    return int((self._backlight_sysfs_path / name).read_text())
  File "/usr/lib/python3.9/pathlib.py", line 1255, in read_text
    with self.open(mode='r', encoding=encoding, errors=errors) as f:
  File "/usr/lib/python3.9/pathlib.py", line 1241, in open
    return io.open(self, mode, buffering, encoding, errors, newline,
  File "/usr/lib/python3.9/pathlib.py", line 1109, in _opener
    return self._accessor.open(self, flags, mode)
FileNotFoundError: [Errno 2] No such file or directory: '/sys/class/backlight/rpi_backlight/max_brightness'

Duplicate of #45. You can provide a custom path as shown in that issue. If this is Raspberry Pi OS and not plain Debian I'd be happy to incorporate a change to set the default path conditionally - PRs welcome.

This is raspbian.


Guidance on event titles

Encourage to make them understandable.

Post-merge comment: It's also good to remember that event names are often truncated in calendars and people often have multiple calendars open which makes the first few words of the title important. I tend to use ISC but that may fall under the jargon banner. Some examples of goiod and bad titles would be useful.


[luci] mac try bots failing to reboot after task failure

1135 2020-05-31 22:09:27.050 E: force rebooting via health checker failed
Traceback (most recent call last):
File "injected.py", line 232, in on_after_task
File "/b/s/swarming_bot.1.zip/utils/subprocess42.py", line 560, in init
super(Popen, self).init(args, **kwargs)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 394, in init
errread, errwrite)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1047, in _execute_child
raise child_exception
OSError: [Errno 2] No such file or directory

54 failed reboots in 3 days

Link to dead bot caused by this problem:
https://chromium-swarm.appspot.com/task?id=4c917f37e76af310
Also you can take a look at any bot_died tasks in the following list:
https://chromium-swarm.appspot.com/bot?id=flutter-try-mac-1

Fixed all the issues causing the flakiness and the bot reboots. The remaining work needed to close this bug is just to remove the noise from bot logs.


[opt] (binlog) Support Modify ViewDef binlog #41167

cherry pick from #41167

run buildall

run buildall


Plugin breaks intellisense

Enabling plugin / installing vscode-styled-components extensions (which uses this plugin) results into this issue:

video version here
I think the gif is self-explained - TS returns global completion instead of x, z
I thought it was TS issue initially and filed this bug in TS repo first, but looks like it's completely related to this plugin

Workaround:
Replace node_modules/typescript-styled-plugin/lib/index.js with following:
"use strict";
var decorator = require("typescript-template-language-service-decorator/lib/template-language-service-decorator");
// disable getOutliningSpans, this is causing problem
decorator.default.prototype.tryAdaptGetOutliningSpans = function () { }
var _plugin_1 = require("./_plugin");
module.exports = function (mod) {
    return new _plugin_1.StyledPlugin(mod.typescript);
};

The problem that editor sends getOutliningSpans on every keystroke and template decorator enumerate all nodes in the sourcefile each time, i'm assuming this should be pretty slow (Does TS do any locking of program/source file? copying? - this would explain the stale diagnostic)

Why closing this issue? Has this been fixed?


Can't use a parameter as an array index in mapFields

In a modal to edit a specific client details I am trying to load the infos about that client.
In the Vuex store clients are stored as an array of objects, normally I would load a client details by its index however the syntax shown in the examples to handle arrays works only with an explicitly set value. If I pass a prop or other parametrized value the mapped fields reports "error during evaluation" in the Vue Components computed inspector.
example of mapped field
  computed: {
    ...mapFields(['clients[this.id].name'])
  },

value shown in the Vue inspect tool
name:"(error during evaluation)"

Is this a bug or a the package can't actually parse the passed value this.id?

@Maxiride It's not a bug. Firstly your javascript is wrong, it won't parse as javascript, nevermind via this library. What you probably mean is this:
computed: {
    ...mapFields([`clients[${this.id}].name`])
  },

However even that won't work because mapFields isn't designed to handle collections, only trees. If you have collections, then see mapMultiRowFields example https://codesandbox.io/s/yj1xxx8kn1

Thanks @geoidesic for answering!


Can't type backslash with Latam (Spanish) keyboard.

While I was giving atom a try today, unfortunately I found it impossible to write down a single backslash with my current keyboard layout (Latam/Spanish).
I was trying to write down PHP namespaces but it was not possible unless I changed my keyboard to the English layout.

Guessing this is https://github.com/atom/atom-keymap/issues/35 ?

This is what I was looking for, thanks :+1:


client/db broken feature

While working on #6267 I came across a feature that would not compile properly when activated.
Seems like the subdb feature of client/db does not compile, or at least runnning:
cd client/db; cargo build --features subdb

fails to build.
Side note: would it be a good idea to have CI try and build each feature of every crate? Maybe something like https://github.com/frewsxcv/cargo-all-features ?

(subdb does not exist as a feature YET, #6267 needs to be merged before it appears as a feature)

@pscott please attach labels to issues


Support concave initial shapes

It can happen that the generated building is upside down, when applying a RPK to a concave shape and changing from static mesh to splines for further processing.
Tasks:

Compute the polygon orientation using a more sophisticated algorithm (There might already be something implemented in Unreal like for example in PolygonTriangulation::ComputePolygonPlane)
Use the orientation to properly order the vertices of the polygon

Fixed with #64.


ModuleNotFoundError: No module named 'bs4'

Hello,
I'm getting the following error when running this program:
$ python main.py
Traceback (most recent call last):
  File "\cinequiz\main.py", line 1, in <module>
    from bs4 import BeautifulSoup
ModuleNotFoundError: No module named 'bs4'

What am I doing wrong?

Thank you! Working as intended now :) Great job.
Welcome to CineQuiz!
To make your guess, please enter the digit associated with your answer.

Who directed this film?
>>> Toy Story
1: Guy Ritchie
2: Alfred Hitchcock
3: John Lasseter
1
Incorrect. Correct answer: John Lasseter.

When was this film created?
>>> The Matrix
1: 1999
2: 2004
3: 2003
1
Correct! +1


Support for Reading/Writing from pipes

Pull Request Test Coverage Report for Build 24

9 of 23 (39.13%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.9%) to 65.831%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/simplify/lexer.c
9
23
39.13%

Totals

Change from base Build 20:
-0.9%

Covered Lines:
709

Relevant Lines:
1077

💛  - Coveralls

Nice!


Install to a subfolder

Summary
I'm planning to install two Postleaf instances to

blog.mydomain.com/en
blog.mydomain.com/zh

for my English blog and Chinese blog respectively.
After installation and configuration (Nginx as the reverse proxy). I found there are a lot of absolute references hard-coded in Postleaf, which prevents my instance work properly.
Expection
I thought in .env, APP_URL should be a full web-access URL (instead of just https://example.com/), and used to compose internal references.
Thanks for your wonderful work.
Steps to Reproduce

Install Postleaf
Configuration
Access from browser.

Additional info

Postleaf version: 1.0
Node version: 8.11.1
Operating system: Debian 9

This isn't currently supported. I would welcome a PR to allow this but it's going to take some effort :)


Fix Struct() argument 1 must be string, not unicode.

Short Description:
Fix Struct() argument 1 must be string, not unicode:
Traceback (most recent call last):
  File "pokecli.py", line 530, in <module>
    main()
  File "pokecli.py", line 96, in main
    bot.tick()
  File "/home/pi/PokemonGo-Bot/pokemongo_bot/__init__.py", line 458, in tick
    if worker.work() == WorkerResult.RUNNING:
  File "/home/pi/PokemonGo-Bot/pokemongo_bot/cell_workers/move_to_fort.py", line 67, in work
    data=fort_event_data
  File "/home/pi/PokemonGo-Bot/pokemongo_bot/base_task.py", line 27, in emit_event
    data=data
  File "/home/pi/PokemonGo-Bot/pokemongo_bot/event_manager.py", line 65, in emit
    handler.handle_event(event, sender, level, formatted_msg, data)
  File "/home/pi/PokemonGo-Bot/pokemongo_bot/event_handlers/colored_logging_handler.py", line 130, in handle_event
    terminal_width = self._terminal_width()
  File "/home/pi/PokemonGo-Bot/pokemongo_bot/event_handlers/colored_logging_handler.py", line 171, in _terminal_width
    struct.pack('HHHH', 0, 0, 0, 0)))
TypeError: Struct() argument 1 must be string, not unicode

Basically convert
struct.pack('HHHH', 0, 0, 0, 0)

to
struct.pack(str('HHHH'), 0, 0, 0, 0)

Fixes (provide links to github issues if you can):
https://github.com/PokemonGoF/PokemonGo-Bot/issues/3373

I've confirmed that this issue can be reproduced with python version <=2.7.6, seems fixed in 2.7.7: https://hg.python.org/cpython/raw-file/f89216059edf/Misc/NEWS

@douglascamata please review this


rollbar-rails-runner doesn't work on Rails 5.1.1

Steps to reproduce
bundle exec rollbar-rails-runner "puts 'hello'"
Expected behavior
System should output 'hello'
Actual behavior
bundler: failed to load command: rollbar-rails-runner (/home/deployer/app/shared/bundle/ruby/2.4.0/bin/rollbar-rails-runner)
Errno::ENOENT: No such file or directory @ rb_sysopen - /home/deployer/app/shared/bundle/ruby/2.4.0/gems/railties-5.1.1/lib/rails/commands/runner.rb
/home/deployer/app/shared/bundle/ruby/2.4.0/gems/rollbar-2.14.1/lib/rails/rollbar_runner.rb:39:in read'   /home/deployer/app/shared/bundle/ruby/2.4.0/gems/rollbar-2.14.1/lib/rails/rollbar_runner.rb:39:in eval_runner'
/home/deployer/app/shared/bundle/ruby/2.4.0/gems/rollbar-2.14.1/lib/rails/rollbar_runner.rb:30:in block in run'   /home/deployer/app/shared/bundle/ruby/2.4.0/gems/rollbar-2.14.1/lib/rails/rollbar_runner.rb:47:in rollbar_managed'
/home/deployer/app/shared/bundle/ruby/2.4.0/gems/rollbar-2.14.1/lib/rails/rollbar_runner.rb:30:in run'   /home/deployer/app/shared/bundle/ruby/2.4.0/gems/rollbar-2.14.1/bin/rollbar-rails-runner:5:in <top (required)>'
/home/deployer/app/shared/bundle/ruby/2.4.0/bin/rollbar-rails-runner:22:in load'   /home/deployer/app/shared/bundle/ruby/2.4.0/bin/rollbar-rails-runner:22:in <top (required)>'
System configuration
Rails version: 5.1.1
Ruby version: 2.4.0

Hi there, I’m closing out all issues opened before 2018 that haven’t had any activity on them since the start of this year. If this is still an issue for you, please comment here and we can reopen this. Thanks!

@rivkahstandig3636 I'm having the same issue here using rails 5.1.1. With a brief investigation I've figured out that the implementation of commands changed in the new Rails version. Take a look at https://github.com/rails/rails/blob/master/railties/lib/rails/commands.rb and https://github.com/rails/rails/blob/master/railties/lib/rails/commands/runner/runner_command.rb, they are very different from https://github.com/rails/rails/blob/4-2-stable/railties/lib/rails/commands/runner.rb.
I've solved the problem just changing the method eval_runner to invoke the command using the new api:
def invoke_runner
  Rails::Command.invoke 'runner', ARGV
end

However, the above code is compatible with Rails 5 only, do you have any thoughts on how to keep backward compatibility?

@ArturMoczulski Any thoughts?

I'm seeing this on an app running Rails 5.1.6. @marcospy seems to have found the underlying issue.

@ArturMoczulski could you investigate this issue?


Improve site navigation

The site has been built on the premise the content is very sparse and has grown the initial one simple page size. It would be nice to redesign and restructure it for the gained amount of content.
The top level goals should remain to:

[x] Explain what toolbx is
[ ] Provide common use cases it covers
[x] Show supported distros (now that it's not just Fedora and RHEL)
[ ] Ouline how to contribute
[ ] Potentially expose more of the documentation/man pages.

Debarshi suggested special casing super wide layout. I'd just do multicolumn using media question.

Debarshi suggested special casing super wide layout. I'd just do multicolumn using media queries.

Suggested is a strong word.  :)
I leave the final choice to you.  Whatever you decide is fine with me.


Add subtitle text to single choice and multiple choice view in sdc.

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1233
Description
Subtitle text to single choice view.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

have you tested your fix on lower API levels?
is this not going to break lower API levels (<26)?
can you use margin top and bottom instead?

Interestingly, it worked when item was added to the layout file, but if it presents in style then it does not apply the margin.
Now, top and bottom margin are added.


TimedMetadataTrack - no default constructor available

Hi,
I am currently in the process of porting a large-ish library from C++/CX to C++/Winrt
I have been battling with a compiler error for the past few days and I have no idea how to fix it.
Basically, I have a class hierarchy, with an abstract class on top. So the hierarchy looks like this:
abstract class < class A < class B < class C
All those classes are standard C++ classes (no winRT stuff but they do consume some winRT classes)
Class B contains fields of TimedMetadataTrack, CoreDispatcher and TimeMetadataTrackKind.
All 3 types cause a compiler error "No appropriate default constructor available". While I could trick the CoreDispatcher and TimeMetadataKind fields with a list initialization (they are passed as constructor parameter), the TimedMetadataTrack is "lazy loaded" and should be inited to nullptr.
But it just doesn't work.
The "winrt/Windows.Media.Core.h" header is included in "pch.h"
I tried both using namespace directives and fully declare the type
other things I tried:

Fully declare the type with namespace (winrt::Windows::Media::Core::TimedMetadatatTrack)
Various ways of initing with nullptr ( field= nullptr, field{nullptr}, field{TimedMetadataTrack{nullptr}}. Same errors
Taking the constructor implementation out of the header into a cpp file. Same problem.
Trying to declare the field outside of the header file using cpp files. Like TimedMetadataTrack B::Field. Nope.

Then I decided to try to reproduce the problem with another project. And much to my surprise the other project works fine.
So I looked at some of the generated files and I see the other project declares it so

struct __declspec(empty_bases) TimedMetadataTrack : Windows::Media::Core::ITimedMetadataTrack,
        impl::require<TimedMetadataTrack, Windows::Media::Core::ITimedMetadataTrack2>
    {
        TimedMetadataTrack(std::nullptr_t) noexcept {}
        TimedMetadataTrack(void* ptr, take_ownership_from_abi_t) noexcept : Windows::Media::Core::ITimedMetadataTrack(ptr, take_ownership_from_abi) {}
        TimedMetadataTrack(param::hstring const& id, param::hstring const& language, Windows::Media::Core::TimedMetadataKind const& kind);
        TimedMetadataTrack(TimedMetadataTrack const&) noexcept = default;
        TimedMetadataTrack(TimedMetadataTrack&&) noexcept = default;
        TimedMetadataTrack& operator=(TimedMetadataTrack const&) & noexcept = default;
        TimedMetadataTrack& operator=(TimedMetadataTrack&&) & noexcept = default;
    };

while my porting work declares it like this
 struct __declspec(empty_bases) TimedMetadataTrack : winrt::Windows::Media::Core::ITimedMetadataTrack,
        impl::require<TimedMetadataTrack, winrt::Windows::Media::Core::ITimedMetadataTrack2>
    {
        TimedMetadataTrack(std::nullptr_t) noexcept {}
        TimedMetadataTrack(void* ptr, take_ownership_from_abi_t) noexcept : winrt::Windows::Media::Core::ITimedMetadataTrack(ptr, take_ownership_from_abi) {}
        TimedMetadataTrack(param::hstring const& id, param::hstring const& language, winrt::Windows::Media::Core::TimedMetadataKind const& kind);
    };

I am not sure if this is a problem, but at this point I am running out of ideas.
Thanks.

I fixed this by reverting to C++/WinRT v2.0.210211.2, which caused visual studio to detect other errors that were indirectly causing the problem.


[1.9.x] [KOGITO-5573] Kogito Operator Data-Index Unable to connect to Infinis…

…pan Instance
Signed-off-by: Karel Suta<EMAIL_ADDRESS>https://issues.redhat.com/browse/KOGITO-5573
Many thanks for submitting your Pull Request :heart:!
Please make sure your PR meets the following requirements:

[x] You have read the contributors' guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains a link to the JIRA issue
[x] Pull Request contains a description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Your feature/bug fix has a unit test that verifies it
[ ] You've ran make before-pr and everything is working accordingly
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster
[x] You've added a RELEASE_NOTES.md entry regarding this change

Cherrypick of https://github.com/kiegroup/kogito-operator/pull/955

/jenkins test


Write documentation

The documentation is the barebones documentation that comes with CookieCutter. We should write it.

Closed via 288e8aa


Airgap Environment Setup is unable to start Tika server

Setting the TIKA_SERVER_JAR environment variable to a local file successfully tells python-tika to "download" this file and move it to /tmp/tika-server.jar, but returns the following errors:
2023-02-20 07:16:35,173 [MainThread  ] [INFO ]  Retrieving file:////opt/pdf2xlsx/tika_server_files/tika-server-standard-2.6.0.jar to /tmp/tika-server.jar.
2023-02-20 07:16:35,180 [MainThread  ] [INFO ]  Retrieving file:////opt/pdf2xlsx/tika_server_files/tika-server-standard-2.6.0.jar.md5 to /tmp/tika-server.jar.md5.
2023-02-20 07:16:35,180 [MainThread  ] [INFO ]  Retrieving file:////opt/pdf2xlsx/tika_server_files/tika-server-standard-2.6.0.jar to /tmp/tika-server.jar.
2023-02-20 07:16:35,189 [MainThread  ] [WARNI]  Failed to see startup log message; retrying...
2023-02-20 07:16:40,190 [MainThread  ] [WARNI]  Failed to see startup log message; retrying...
2023-02-20 07:16:45,191 [MainThread  ] [WARNI]  Failed to see startup log message; retrying...
2023-02-20 07:16:50,192 [MainThread  ] [ERROR]  Tika startup log message not received after 3 tries.
2023-02-20 07:16:50,194 [MainThread  ] [ERROR]  Failed to receive startup confirmation from startServer.
Unable to start Tika server.

Installed on a Docker container:
Docker base image: FROM python:3.11
Kernel version: Linux afabe325295c 5.15.0-60-generic #66-Ubuntu SMP Fri Jan 20 14:29:49 UTC 2023 x86_64 GNU/Linux
Distribution info: Debian GNU/Linux 11

Local JAR files downloaded:

tika-server-standard-2.6.0.jar
tika-server-standard-2.6.0.jar.md5

Java version:
openjdk version "11.0.18" 2023-01-17
OpenJDK Runtime Environment (build 11.0.18+10-post-Debian-1deb11u1)
OpenJDK 64-Bit Server VM (build 11.0.18+10-post-Debian-1deb11u1, mixed mode, sharing)

Setup works as expected after unsetting the TIKA_SERVER_JAR environment variable, forcing python-tika to download the same version of the JAR file from Apache.
I tried setting the JAVA_HOME environment variable to the Java installation directory, as well as the PATH variable, with no further success.

what does the /tmp/tika*log file return? I need to see what that is showing to debug this thanks @Marcos-A

Hi, @chrismattmann, thank you for your response. This is the content of the tika.log file:
2023-02-23 23:55:03,003 [MainThread  ] [INFO ]  Retrieving file:////opt/pdf2xlsx/tika_server_files/tika-server-standard-2.6.0.jar to /tmp/tika-server.jar.
2023-02-23 23:55:03,016 [MainThread  ] [INFO ]  Retrieving file:////opt/pdf2xlsx/tika_server_files/tika-server-standard-2.6.0.jar.md5 to /tmp/tika-server.jar.md5.
2023-02-23 23:55:03,017 [MainThread  ] [INFO ]  Retrieving file:////opt/pdf2xlsx/tika_server_files/tika-server-standard-2.6.0.jar to /tmp/tika-server.jar.
2023-02-23 23:55:03,030 [MainThread  ] [WARNI]  Failed to see startup log message; retrying...
2023-02-23 23:55:08,032 [MainThread  ] [WARNI]  Failed to see startup log message; retrying...
2023-02-23 23:55:13,033 [MainThread  ] [WARNI]  Failed to see startup log message; retrying...
2023-02-23 23:55:18,034 [MainThread  ] [ERROR]  Tika startup log message not received after 3 tries.
2023-02-23 23:55:18,037 [MainThread  ] [ERROR]  Failed to receive startup confirmation from startServer.

On the other hand, this is the content of tika-server.log:
Caused by: java.lang.ClassNotFoundException: org.apache.tika.server.core.TikaServerCli

Please, let me know if you need more information.

thanks @Marcos-A in your /tmp directory are you seeing the corresponding tika-server-standard-2.6.0.jar file? the error in tika-server.log seems to indicate that the jar file is somehow corrupt. Can you check the contents of the jar file?

Thank you so much, @chrismattmann, your suspicions were correct. The JAR file was corrupt. The strangest thing is that I tried downloading it several times before, even with different versions of Tika Server without much success. Anyway, I tested it downloading the file again and it worked flawlessly. Thank you very much for your support and hard work.

anytime thank you @Marcos-A !

also thank you so much for the tip @Marcos-A !


A larger idea

CSS modules has the idea of generating unique class names (like this package) and integrating with webpack and browserify. You might want to contribute there https://github.com/css-modules

Sure, css-modules is a larger and completely idea to solve existing css problem.
But for some small projects or existing library, use this plugin can decrease your configuration time and still can do the trick.


Per user disable authentication not working

I have a website where each user shows that two-factor auth is disabled, even if they actually are enabled (in the database, practically). It seems like the issue is resolved temporarily when you clear the Craft CMS cache. Not sure how else to debug from here.
Thanks,
– Clark

Hi @clarknelson, do you mean the "2-Factor Auth" column in the user overview in Craft's CP? I can't reproduce this myself. Can you give some info on Craft and plugin versions?

Is this fixed with 3.3.0?

Sorry for the delay, I think the issue was on our end... I believe the user's permissions to access the plugin were removed somehow.


Complete API documentation

API documentation with usage examples and detailed explanations
Update of old documentation

@mila411 Hi, before I ask you if I can take this issue, I have some questions if is not a problem for you:

I assume the API documentation is about every function in the library and not just the main functions, right?
Should the API documentation be included in the README? Usually there are automatic generators that allow you to generate the API documentation from the comments in the code.

So if you are interested in using frameworks like Sphinx (or rustdoc more appropriate for Rust), the generated documentation should only be about the API? Because at this point you could choose to create (for free of course) a hosted documentation on readthedocs that is about the whole project.
I ask these questions because I found your project interesting and I'm trying to learn Rust. Thanks in advance!

@AndreVale69 Hi! Thanks for your comment!
This issue covers all functions, including those that are not yet published, so there's no problem if you make progress little by little. And your understanding of publishing is correct. In the case of Rust, it is compiled when publishing by rustdoc and hosted on crates.io
Therefore, it is not necessary to include it in README.md.

@AndreVale69 Hi! Thanks for your comment!
This issue covers all functions, including those that are not published, so there's no problem if you make progress little by little. And your understanding of publishing is correct. In the case of Rust, it is compiled when publishing by rustdoc and hosted on crates.io
Therefore, it is not necessary to include it in README.md.
If you are using VSCode and rust-analyzer is enabled, a button to run the documentation tests will appear when you write the documentation. You can use this to make sure you are making progress one step at a time.

Thanks for the explanation.
If the priority is not too high, I'll take this issue. I will study the project structure first, and then read the contribution file.
Is there another communication channel (like discord) or will I post the questions here? Because it will take some time if we want a great documentation 😁.

@AndreVale69 It is not a high priority so you can proceed slowly. Let's enjoy doing it!

@AndreVale69

Is there another communication channel (like discord) or will I post the questions here? Because it will take some time if we want a great documentation 😁.

ohhhhh I had overlooked this. There is no Discord at the moment. I'm hoping to communicate through LinkedIn or here

@AndreVale69

Is there another communication channel (like discord) or will I post the questions here? Because it will take some time if we want a great documentation 😁.

ohhhhh I had overlooked this. There is no Discord at the moment. I'm hoping to communicate through LinkedIn or here

Ok, don't worry about it 😁.


incorrect session restored

session was restored from one of the "allowed_dirs" and I was in a seperate directory.

Do you have a reproducible example I can look at?

I simply installed the plugin and added three paths to auto_session_allowed_dirs, I launch nvim from the directory one of dirs mentioned in the list and then open some random buffers to allow to auto-session to create a session file. I exit from nvim and then open the second directory mentioned in the list and the original session is opened, one from the previous directory.

local u = require("utils")
require('auto-session').setup {
  log_level = 'info',
  auto_session_enable_last_session = true,
  auto_session_root_dir = vim.fn.stdpath('data') .. "/sessions/",
  auto_session_enabled = true,
  auto_save_enabled = nil,
  auto_restore_enabled = nil,
  auto_session_suppress_dirs = {"/Users/user"},
  auto_session_allowed_dirs = {
    "/Users/user/Projects/Application Development/crimson",
    "/Users/user/Projects/Application Development/lernit",
    "/Users/user/Projects/Application Development/flutter_clean_auth_architecture"
  }
}

require('session-lens').setup {
  -- path_display = {'shorten'},
  -- theme_conf = {border = false},
  previewer = true
}

require("telescope").load_extension("session-lens")

u.kmap('n', '<leader>s',
       '<CMD>lua require("session-lens").search_session()<CR>',
       {noremap = true, silent = true})

This is how I have set it up

I believe you will just have to check whether the session directory and the current directory match before restoring it.

Hey @Chaitanyabsprip I just noticed, this is likely because you have auto_session_enable_last_session = true, as a setting.
Here's the readme piece about it.
https://github.com/rmagatti/auto-session#last-session

Ah, makes sense. I should read the "README" more closely. Thank you for your help.


Amend correlation holder and add tests

With this PR we amend the correlation holder to use consistent value types. This is required for AD sensitivities. Moreover, we add tests for gradient calculation.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (90501d9) 98.76% compared to head (92766c7) 98.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   98.76%   98.76%
=======================================
  Files          59       59
  Lines        2988     3001   +13
=======================================
+ Hits         2951     2964   +13
  Misses         37       37

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Feedmereadmes edit of README

Pretty good job already. I just moved some things around a bit. Some questions/tips:

use this product template (https://github.com/zalando/zalando-howto-open-source/blob/master/producttemplate.md) or something similar to assess your audience and then bring some of the user more into the README. Especially:

why would I use this?
is this different/better/newer/simpler than similar tools out there? Or are there no similar tools like it (which could be a good thing to mention)?
how has this helped you and/or others work faster/more effectively/more simply?

how do you quantify the words you use to "sell" Chemfiles: "Modern" (compared to what?); "easy-to-use" (because of its object-oriented nature? what does that actually look like, concretely, such that it's easy to use?)
why five classes?
why the languages you've chosen? because they're most popular among researchers at the moment?
for contributors, I wonder what the labels in the Issues Tracker mean? Maybe you can identify some "quick starters" items for brand-new contributors to work on?
wondering why you chose BSD license

Thank you for submitting to FMRM!

Who, thank you very much! This is very appreciated.

use this product template (https://github.com/zalando/zalando-howto-open-source/blob/master/producttemplate.md) or something similar to assess your audience and then bring some of the user more into the README.

I'll try to think about this, looks interesting!

is this different/better/newer/simpler than similar tools out there? Or are there no similar tools like it (which could be a good thing to mention)?

I have a bit about this in the documentation, do you think I should move it to the README ?

how do you quantify the words you use to "sell" Chemfiles: "Modern" (compared to what?); "easy-to-use" (because of its object-oriented nature? what does that actually look like, concretely, such that it's easy to use?)

Modern is more about the usage of C++11 vs older standards. You make me realize it might not be the best word to appeal scientists. The easy-to-use part is a goal of the code, which I try to illustrate in the example. Do you think I should extend this part a bit? I am a bit afraid that a README too long might be worst.

why five classes?

This is actually left-over from previous version. The "five classes" was an emphasis on the easy-to-use side, as the most known competitor (openbabel) contains a lot of classes and functions.

why the languages you've chosen? because they're most popular among researchers at the moment?

This, and because they are the one I know enough to write C bindings. I am thinking to extend the list with JavaScript (either with emscripten or node) and Java (actually all JVM languages), but this takes quite a bit of time.

for contributors, I wonder what the labels in the Issues Tracker mean? Maybe you can identify some "quick starters" items for brand-new contributors to work on?

We do have the E-easy label, maybe I should link to it more. I'll add explanation for the other labels on the Contributing.md file.

wondering why you chose BSD license

Asking the hard questions here =). Most of the competitors are GPL licensed, and I wanted something that could be used by companies in commercials products as well as in open source work. I already talked to one company that showed interest in using chemfiles because it is BSD. On the BSD vs MIT, I still like the citation/attribution clause of BSD.

Thank you for submitting to FMRM!

Thank you for taking the time to do this !

I have a bit about this in the documentation, do you think I should move it to the README ?
Yes, possibly in a briefer form. But definitely something. :)

Do you think I should extend this part a bit? I am a bit afraid that a README too long might be worst.
I wouldn't extend it so much as just make the point clear. For example, quantify it like "modern (C++11)".

I would include the plan for JS. That could get you some contributors. If it's already listed in the issues tracker, you can point to the relevant issues. :)

license stuff
You might add the point about getting commercial products/companies in your "why use this?" section near the top, to point out your intended users.

You're asking cool questions and thinking about this in a great way!

Thank you again for your help here @LappleApple

:1st_place_medal:


Formatting of list of several files added together

Hi,
thanks for your work, it is very useful.
If I am not mistaken, line 488 in jquery.MultiFile.js should be
if(i>0) names.append(', ');

(rather than i>1). As it is now, between the first and second entries there is no comma, if multiple files are selected together.
Ulrich

Well, shucks. I did a pull request to fix this yesterday. If I had known the issue was sitting with a solution for nine months without the owners fixing it, I wouldn't have bothered. It looks like Fyneworks doesn't support this product anymore.

@Micteu - fair. And I'm sorry. I've been busy but I will make time.
Let's continue this discussion over on https://github.com/fyneworks/multifile/pull/35


Header and footer spacing in summaries

Is your feature request related to a problem? Please describe.
The format of all summaries in CARE needs to be improved. This includes

discharge summaries
treatment summaries
Investigation summaries

The pages have no spacing at the header and footer.
The page breaks between sentences
Describe the solution you'd like

[ ] Add spacing at the head and the foot of each page
[ ] Do not allow page to break sentences.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi @aparnacoronasafe ,
I've reviewed the issue regarding the formatting of summaries in CARE. To better understand the problem, could you please provide a video or screenshots that illustrate the current formatting issues, particularly the lack of spacing at the header and footer, and the page breaks between sentences?
This will help ensure that the proposed solutions address the issues effectively.
Thanks!


Add Testing

Do you know how to setup CI testing? If not, I can get someone else to do that
Could the tests be parameterized so that new tests can be added easily and to check what cases failed easily
An example can be found here
To do this, may require splitting the file up. I think this is fine with each function having its own file for testing.
This would allow us to have multiple different testing functions for each jumpy function in the file to allow testing of different cases.
For functions that do no work other than _which_np(x).func then these can be done in a single file (test_jumpy.py)
These functions should need to do much than just to pass in arguments to check that the function runs as expected

@alessandrostockman Thanks for upgrades, they generally look good.
Could you continue to add more tests along with a short docstring on what you are testing.
This should help ensure that the tests reflect the idea, this is particularly helpful in the future when we no longer work on the project
We won't merge this PR until testing CI has been merged which should hopefully happen soon

@alessandrostockman Since https://github.com/Farama-Foundation/Jumpy/pull/6 has been merged, could you rebase on the main branch and remove the dummy test_to_be_removed.py file?

@alessandrostockman How many more functions are there to add to this PR?

@alessandrostockman How many more functions are there to add to this PR?

I'm adding something very basic for every function, today I'll push everything.


I wrote demo script, there seem to be problems with the model

Hi, please check the Readme of my fork: https://github.com/hcl14/3dfacefill
There are problems:

Occlusion model seems to predict random rectangular occlusion
UV texture is white noise

Can you please take a look and say what might be the problem? Also, was your occlusion model tested on real-world occlusions?
Also, if you want to write demo script, you can use mine as a start point

Did you find a workaround this issue?


MITRE ATT&CK Mappings for MS Rules

Background
It became apparent that some rules don't have MITRE mappings associated with them. This PR addresses the issue for Microsoft rules.
Changes

Added MITRE report mappings for all 4 Microsoft rules
Ran the auto formatter for 2 helper modules

Testing

Good 'ol make test - nothing beats that

Idk why lint failed - I explicitly fixed both those helpers with this PR, and it works fine on my local env with make lint...


Implement Clone for Channel and Stream

Based on the prior discussion in https://github.com/alexcrichton/ssh2-rs/issues/158 I would like to propose implementing Clone for additional interior locked structures to further improve ergonomics.
I extended their documentation accordingly to align with the behavior described by Session.

Thank you for the code, and sorry for the long wait.
I don't see inherently wrong with the logic so I'm fine with merging this.


REST API support for limiting returned language versions

Using the REST API, the WooCommerce products endpoint returns all language versions.
Based on #23 and my measly testing, it seems like using a parameter like "lang" to filter the language versions that the products endpoint returns is not currently possible.
Adding support for a param like this seems trivial, but I haven't looked into where and how to best place it in this plugin or even if the maintainer feels like a feature like this is desirable in this plugin (❤ this plugin hyyan, hope you find your maintainer).
There might be a better (less general) hook to use, but here is some example code to help illustrate the feature:
add_action('parse_query', 'add_lang_support', 1);

function add_lang_support($query) {
  $lang = $_GET['lang'];
    if ($lang) {
    $lang = sanitize_text_field($lang);
    $query->set('lang', $lang);
  }
}

I agree, the code suggested looks along the right lines, you are welcome to submit a pull request..!
as there isn't rest customisation currently I'd suggest a new file.
To follow the existing plugin scheme it would be a new class file in src/Hyyan/WPI and a line to create it in registerCore() in Plugin.php... potentially also added as a setting in Features.php which allows the various features to be turned on and off.
at least that's how the other bits are implemented in this plugin.


Strikethrough not working

https://www.loom.com/share/a23299e19a58401ebb91f34d5195abfa
Can't strikethrough points. ~ get's escaped as ~ and strikethrough stops working

Working on a quick fix

Should be fixed by a93470515fc01aa40df66ea40a16b5ec4692ee3c


Merge Flight-Booking into Dev

Did you pull the latest version from dev and check again that your work is compatible and still there?


config: print minimal config

When calling {cs,border,sciond,godispatcher} -help-config the full configuration file, including all configurable fields, is dispalyed.
We should have a -help-minimal-config that displays the minimal required configuration

Instead of having a minimal-config we should just make sure the config produced by help-config works in a docker container. For an operator it is ok to have all config options (with their default configured) in the config file.

Also make sure the container is able to run without bind-mounts configured.

This probably needs to be split into 4 different issues (one for each of cs, border, sciond, dispatcher), with each one also explaining what a minimal config would mean.

Also make sure the container is able to run without bind-mounts configured.

Isn't this difficult to do because the Dispatchers exposes its API on a UNIX domain socket? How would the default configuration for a dockerized cs look like, given no binds?

Ok, for the dispatcher it's not possible. But in general there are many bind-mounts that would not be necessary (e.g. for caching).

Do those bind mounts affect how the minimal config might look like? The docker container has its own root, so every file touched in there is local to the container unless the user explicitly bind-mounted something, so any default file paths would work as long as they are valid paths.

Exactly, the default paths need to exist inside the image and not rely on being bind-mounted.


Cannot use wstunnel socks5 on Telegram application

Hi,
After setting Wstunnel on both server and client, still cannot use it in Telegram desktop application as a Socks5 proxy. What is the problem?
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing Websocket stream
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing Websocket stream
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing Websocket stream
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing Websocket stream
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing Websocket stream
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing tcp connection to <IP_ADDRESS>:8080
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing Websocket stream
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing Websocket stream
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing Websocket stream
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing tcp connection to <IP_ADDRESS>:8080
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing tcp connection to <IP_ADDRESS>:8080
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing tcp connection to <IP_ADDRESS>:8080
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing tcp connection to <IP_ADDRESS>:8080
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing tcp connection to <IP_ADDRESS>:8080
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing tcp connection to <IP_ADDRESS>:8080
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing tcp connection to <IP_ADDRESS>:8080
Nov 20 12:13:48 xxxx wstunnel[7300]: DEBUG :: Closing tcp connection to <IP_ADDRESS>:8080
Nov 20 12:13:49 xxxx wstunnel[7300]: DEBUG :: Oppening Websocket stream
Nov 20 12:13:49 xxxx wstunnel[7300]: CLOSE tunnel :: <IP_ADDRESS>:8888 <==WS==> <IP_ADDRESS>:8080 <==TCP==> <IP_ADDRESS>:80

I guess the problem is something with dns, do you have clue?
Regards

Hello,
Can you provide the command you use with wstunnel server and client please ?
Also how do you indicate telegram to use socks5 protocol ?

Client:
wstunnel -v -D <IP_ADDRESS>:8888 ws://a.b.c.d:8080

Server
wstunnel --server ws://<IP_ADDRESS>:8080

Would you mind taking a tcpdump of the traffic and sharing the pcap ?

This is an issue on your device / network perhaps. Telegram desktop works fine for me with wstunnel socks5.
However, Telegram desktop calls don't work over proxy due to this bug https://github.com/telegramdesktop/tdesktop/issues/23916


Exercise Solutions

Deleted the previous solutions and added an updated version of them.
Ignore the import plot_model

hey brother, thank you for these!
as a side note for next time, emojis in file paths make committing really hard :P
best to keep to keep to text only, like:
00_tensorflow_fundamentals_exercise_solutions.ipynb


storage: retain debond end time when converting genesis

we've been entering them as all zero

oh do I need to rebuild the caches again

but why did the analysis succeed if it would have been missing the right cache?

I guess that's just nexus's style, if one analyzer fails, the rest continues fine, even if the rest is 0 other analyzers


Pick up requested citation from bitbucket readme page?

e.g., https://bitbucket.org/biobakery/biobakery/wiki/Home

Might mean searching for a PMID in addition to a DOI?


Refactor BuildPlatform to make it easier to work with and customize.

Creating a class works well enough, but some people may be less inclined to tangle with code. Converting BuildPlatform into a ScriptableObject (or a field in another ScriptableObject) that can be instantiated and customized from the inspector may work better.

Closed by https://github.com/Chaser324/unity-build/commit/c27e651ef0406452e0e80a868ce8621f7d14d135


Fix broken release: Don't exclude built files from npm package

The latest release didn't include the produciton and development builds since they were included in .npmignore.

Thanks @dentrado!

Published as 7.1.1


Use Magnific Popup with AJAX-loaded content

Hi,
I have some content that is loaded through AJAX. Magnific doesn't work with that content because the event listeners fire on page load, but the the AJAX-loaded content is not yet inserted in the page at that point.
The only workaround for this that I know of is to use inline javascript on the AJAX-loaded content. I tried to do something like:
Open popup
But unfortunately it doesn't seem to work. I get ReferenceError: magnificPopup is not defined, even though the magnific-popup.js file is included in the page.
Any help on how to get this to work would be appreciated. Thanks!

On document load initialize mp as normal:
jQuery(function () {
    $(this).magnificPopup();
});

In your ajax call, trigger the binding of magnific popup after the ajax content is loaded:
$.ajax({
        type: 'get',
        url: '/get-ajax-content',
        success: function (data) {
            // Rebind modal events
            $(this).magnificPopup();
        }
    });

In your magnificPopup jQuery function:
(function ($) {
    $.fn.magnificPopup = function () {
        $('[data-modal]').magnificPopup({
            // options
        });

        return this;
    };
})(jQuery);

use document as main selector, and then put your own selector to delegate options
$(document).magnificPopup({
    delegate: '.your-class-selector',
});

It works for me

Thanks, it works.

If I use delegate then how do I get clicked element? is there any way of getting the click event?


[Test] Vm::check_meta_section

check_meta_section ensures the versioning integrity of wasm contracts, but there is no direct tests for its logic (which is simple but critical).

This was done as part of https://github.com/orgs/stellar/projects/39/views/12?pane=issue&itemId=43253249


libskk: fix parse error

https://github.com/ueno/libskk/issues/89
https://github.com/ueno/libskk/pull/90
Fix parse errors in default.json. This eliminates errors when loading fcitx5-skk add-on.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

👀I'm looking forward to this PR being merged, but this file looks moved to pkgs/by-name/li/libskk/package.nix.
Btw, it might be a good idea to mention the people maintaining this file for it to be merged.

I'm closing this because I made a mistake and I'm really sorry.


"Can't set headers after they are sent" when calling res.redirect from getInitialProps

Hi folks, really loving Next so far, just ran into one issue:
When I redirect on the server from getInitialProps, like this:
import React from 'react'

export default class extends React.Component {
  static getInitialProps ({ res }) {
    // assume we're on the server for this example, obviously this won't work on the client
    res.redirect('/')
    return {}
  }
  render () {
    return
Hello

  }
}

I get a server-side error:
Error: Can't set headers after they are sent.
    at ServerResponse.setHeader (_http_outgoing.js:371:11)
    at sendHTML (/Users/booker/Code/next-minimal-oauth-authentication-demo/node_modules/next/dist/server/render.js:422:7)
    at Server._callee17$ (/Users/booker/Code/next-minimal-oauth-authentication-demo/node_modules/next/dist/server/index.js:767:73)
    at tryCatch (/Users/booker/Code/next-minimal-oauth-authentication-demo/node_modules/regenerator-runtime/runtime.js:65:40)
    at Generator.invoke [as _invoke] (/Users/booker/Code/next-minimal-oauth-authentication-demo/node_modules/regenerator-runtime/runtime.js:303:22)
    at Generator.prototype.(anonymous function) [as next] (/Users/booker/Code/next-minimal-oauth-authentication-demo/node_modules/regenerator-runtime/runtime.js:117:21)
    at step (/Users/booker/Code/next-minimal-oauth-authentication-demo/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /Users/booker/Code/next-minimal-oauth-authentication-demo/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
> Building page: /

Also note that this code works (the user is redirected to /), but I see this error in the console. Weird!
Also note that I'm using express and next (the npm lib, not the cli)
Any thoughts?

I'm not sure if you can do a redirect like this inside of Next.js on the server side, but curious to know if that is possible.
There is next/router on the client, but I'm not sure that it runs server side (it doesn't AFAIK):
import Router from 'next/router'
Router.push('/redirect-route')

I wonder if it's worth adding a route handler in express to take of server side redirection?
server.get('/example-route', (req, res) => {
  return res.redirect(301, 'https://example.com/redirect-route')
})

Oh, it is definitely possible! Andnext/router is definitely for the client only. If you attempt to run it from the server, you'll get an error.
I too suspect that the solution here is to define my routes on the server however, for context, I am working on an authentication module that looks like this:
export default Component => {
  return class extends React.Component {
    static async getInitialProps ({ req, res }) {
      let session = {}
      if (req) {
        console.log('on the server...')
        if (req.user) {
          session = {
            user: req.user
          }
        } else {
          res.redirect('/admin/login')
        }
      } else {
        const response = await fetch('/auth/session', {
          credentials: 'same-origin'
        })
        const json = await response.json()
        console.log('json', json)
        if (json.user) {
          session = {
            user: json.user
          }
        } else {
          Router.push('/admin/login')
        }
      }

      let isAuthenticated
      if (session.user && session.user.id) {
        isAuthenticated = true
      }
      console.log('returning...', JSON.stringify({ isAuthenticated, session }))
      return { isAuthenticated, session }
    }

    render () {
      if (this.props.isAuthenticated) {
        return <Component {...this.props} />
      }
      return null
    }
  }
}

As you can see, there is a certain symmetry to my client and server authentication logic that I'm attached to (maybe I shouldn't be)
Like I say, it works, I just get an error in the terminal which bothers me.

hehe, this is based on starter.now.sh. I'm endeavouring to build a simpler example, focusing on one OAuth provider only.

Just published the latest version if you want to check it out: https://github.com/bookercodes/next-minimal-oauth-authentication-demo
Remember to yarn install and to create .env if you want to run it locally:
GOOGLE_CLIENT_ID=
GOOGLE_CLIENT_SECRET=
SESSION_SECRET=123123123123123123123123123123123123123123123123
PORT=8080

@bookercodes @iaincollins https://github.com/timneutkens/next-universal-redirect/blob/master/index.js#L6-L30 I made this a while back 👍

@timneutkens I got the same error as described in the OP and saw it disappeared when removing my express-session middleware. Haven't had yet time to debug more.

Thanks @timneutkens!
@sedubois aah yes that rings a bell, thanks for the tip.

@timneutkens Will check it out, thanks
@sedubois Interesting. Can't remove express-session without breaking my app though!

Would be great to test if tim's package combined with express-session shows the issue. If yes, then this ticket could be reopened?

@sedubois either way it's related to express And not next.js cause without that package it works right. So in theory you could reproduce it with a simple request handler that does the same thing as getInitialProps.

@timneutkens I'm not really following you. Do you mean that server.get('/test', (req, res) => res.redirect('/admin/login') should throw the same error? It doesn't

Yeah, I just tried
res.writeHead(301, {
  Location: '/admin/login'
})
res.end()

... Same error :(

@bookercodes Hmmm, okay, I'll re-open this then, cause we're still discussing it 😄

@bookercodes one thing I'm thinking right now is, have you tried production mode?

@timneutkens Yeah, same problem :(

I am starting to notice that this happens sporadically now, eek!

Just tested, and this happens with Hapi too.
Also tested next@beta as well as the latest stable release (just in case)

Also having this issue... was working 5 minutes ago.

@bookercodes @timneutkens are you setting res.finished = true after you've sent the response? e.g.
if (res) {
  res.redirect(`/article/${doc.id}/${doc.slug}`)
  res.finished = true
}
return {}
``

No, I'm not. I can't remember off the top of my head, but doesn't res.redirect do that automatically?

@bookercodes res.redirect will set the 301 status code, write the location header and end the response. However res.finished is a next.js construct only, that tells next.js you have handled the entire request/response lifecycle in getInitialProps, so that it knows not to continue writing to the response.
See https://github.com/zeit/next.js/blob/87e01f681bc2d82e59ee30c026180d6984157a34/server/render.js#L67

@mattfysh does that mean doing that works? 😄

@timneutkens yea this is working for me now :)

Oh wow, good to know.
Will test this this afternoon :)

Amazing. TIL 😲

Documented here https://github.com/zeit/next.js/wiki/Redirecting-in-`getInitialProps`

Quick comment on this issue:
When using res.finished = true the connection never seemed to finish and ran till timeout.
When i replaced res.finished = true with res.end() it seemed to work.
I got that idea from this example -
https://github.com/zeit/next.js/blob/dff20eae0137ee121c703733fbb87084a8cd86d3/test/integration/basic/pages/nav/redirect.js
I'm unsure if this is the correct way to do this, but it worked in a way that the code on the wiki page did not.

You need to do both.
On Mon, 17 Jul 2017 at 9:23 pm, dajomu<EMAIL_ADDRESS>wrote:

Quick comment on this issue:
When using res.finished = true the connection never seemed to finish and
ran till timeout.
When i replaced res.finished = true with res.end() it seemed to work.
I got that idea from this example -
https://github.com/zeit/next.js/blob/dff20eae0137ee121c703733fbb87084a8cd86d3/test/integration/basic/pages/nav/redirect.js
I'm unsure if this is the correct way to do this, but it worked in a way
that the code on the wiki page did not.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zeit/next.js/issues/2152#issuecomment-315729132, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAcs8ovGCkAwNcOYm7z3wyuaNHIs5Avwks5sO0QygaJpZM4Nuxwb
.

Ah, ok, thanks

After adding res.finished = true I get the timeout issue again, so I've removed it for now.

@dajomu hmmm... this doesn't sound right, if you're getting a timeout its because you're not handling the request/response lifecycle correctly.
Setting res.finished = true tells next.js you've already processed the entire request lifecycle, and that it does not need to do anything further with the req or res objects. Can you upload an example repo?

This should work:
res.finished = true
res.end()

@dajomu I noticed the wiki only had writeHead and res.finished = true ... which will result in the timeout because the response was never ended. I've updated the wiki example - https://github.com/zeit/next.js/wiki/Redirecting-in-`getInitialProps`

Thanks @mattfysh

Just out of interest, is this something that can/will be abstracted by Next?
Having to write,
res.finished = true
res.end()

Is neither intuitive nor "clean", you know?
Not a complaint as  I am aware of the solution (and I don't feel like I'm in a position to propose a change), just advocating for future Next users who might trip over this.
I wonder if this need to write res.finished = true, res.end() stems from something internal that could be tweaked?

Perhaps next could pass in a redirect function and make the request/response management opaque to getInitialProps?

Just for the record: in my case, the same error appeared when using compression middleware with a custom express server.


feat(RHTAPWATCH-371): add script mapping namespace to workspace

For each cluster, the script searches for namespaces with label toolchain.dev.openshift.com/type set to tenant and maps the namespace name to the value of label toolchain.dev.openshift.com/space.

Given the oc --prefix option, the xargs --delimiter option and the jq add command and --slurp option, this script can probably be reduced to a single shell pipeline:
xargs <<<"$CLUSTER_PREFIXES" --delimitr=: --replace=C oc --prefix=C get ... | jq --slurp "add(.)"

Where CLUSTER_PREFIXES is a colon-delimeted list of prefixes, though using space as a delimiter may be better in this case.

Given the oc --prefix option, the xargs --delimiter option and the jq add command and --slurp option, this script can probably be reduced to a single shell pipeline:
xargs <<<"$CLUSTER_PREFIXES" --delimitr=: --replace=C oc --prefix=C get ... | jq --slurp "add(.)"

Where CLUSTER_PREFIXES is a colon-delimeted list of prefixes, though using space as a delimiter may be better in this case.

@ifireball Can you point me to documentation for the --prefix option? I can find some mentions of it, but not to the extent that I could tell what it does.

@ifireball Can you point me to documentation for the --prefix option? I can find some mentions of it, but not to the extent that I could tell what it does.

s/prefix/context/  :facepalm:


ApplicationSet grouping

open-cluster-management/backlog#11584

/retest

@birsanv This one is ready to go. If it's OK with you, I will handle any design updates in a subsequent PR.

sure @KevinFCormier let's get this in and use separate PRs for other changes


admin auth erros in log when running API acceptance tests

Running API acceptance tests is introduced in PR #166 and they pass - great.
What can be done about the many messages in https://cloud.drone.io/owncloud/ocis/271/1/11 ocis-server log:
6:33AM WRN srv/app/pkg/mod/github.com/cs3org/reva@v0.1.1-0.20200320145721-40c4334849c3/internal/grpc/services/authprovider/authprovider.go:107 > error authenticating user error="authsvc: error in Authenticate: error: not found: admin" pid=306 pkg=rgrpc traceid=b642fa5c569ce1a933958d5017dec137

Is there "bonus" stuff happening in test setup/teardown or... that is trying to do stuff with an admin user that does not exist? Or what?
To-do: investigate if we need to adjust/control what the tests are doing in setup/teardown etc or some other change in OCIS itself or what should be done?

@individual-it you are familiar with the QA-assigned tasks here. Please sort out priority and who to assign...


Let more people know about NumSharp

I've written an article here which introduce NumSharp.
@dotChris90 Can you start with the docs.

@Oceania2018 just one little thing. Sorry I mention it.
Shouldn't it be:
var a = np.arange(9).Reshape(3,3)?
So with capital R instead of small r?
The output of arange is a NDArray object. So we call its Reshape method.
What we are doing is method chaining. So we do not use the np.reshape method (if exist didn't look ^^') but the NDArray Reshape method.

@Oceania2018 and question : shall we start doc with python sphinx? Or maybe take docfx? https://dotnet.github.io/docfx/
Just idk if sphinx can parse c# for api documentations by doc comments.

We should use both of them, docfx is for generating md files, Sphinx is for organizing them, and make docs readable on readthedocs.io.
I prefer arange().reshape(), keep same as numpy as much as possible.

@Oceania2018 at the moment I experiment with docfx - it does not look as bad as i though. Especially the API documentation and the style looks promising. Moreover docfx is the one which is used from Microsoft I though. The hosting we could do on Github Pages.
Just feel annoyed at sphinx python doc, that it highlight my C# code but it thinks it is python lol so the code looks not good. And was investigating for C# docs at moment.
How you think of docfx? i tried at https://dotchris90.github.io/NumSharp/ I will not merge it to Scisharp/NumSharp - so dont worry but I will see how well this can look like.

Does docfx generate markdown file? I think docfx is used to generate developer's API reference, because it is generated from souce code directly. Sphinx is often used to make tutorial document, like quick start.

Yes they are now able to do it. I was also surprised. Seems they developed quite well.
You can write so called articles which is equivalent sphinx tutorials. Using markdown. Very easy seems. So tutorials and api and swagger rest api and more seems (ok rest API is not important for us....).
I can maybe experiment with it and upload to my repo. If we think it looks good we can go with it. If not we take sphinx.

@Oceania2018 an example for our api
https://dotchris90.github.io/NumSharp/api/NumSharp.NDArray-1.html
And example for article :
https://dotchris90.github.io/NumSharp/articles/NDArray.Creation.html
@Oceania2018 if u not too angry with me. I would like to go with docfx. They plan to support multiple languages besides c# in future and using 100% md for articles. Plus the generated docs folder can be hosted 100% on github for free.
The only thing that I am not satisfied is... The style. I look now for better template...

@dotChris90 Docfx looks awesome. keep going.

@Oceania2018 thanks. Before thinking about pull requests. Is NumSharps github page active? If not, could you activate it? Not sure if I can since u the founder / constructor of SciSharp organizations. :)

@Oceania2018 thanks a lot. Then today maybe write some more user tutorials. ;)
And push.

Sounds great. NumSharp got 80+ stars now. Seems like people  really need it.

Totally. Before c# was not the language of numeric. Since this year Microsoft push this AI and ML topics so hard... But Microsoft didn't give us a numerical stack.
But people deserve and need a numerical stack like NumSharp. :)

Ok it worked. Just merged the docs which I already made. Nothing new. But will write some tutorials for user and also a small Readme how to use docfx best.
It's time we dotnet developers go deeper to science, machine learning and numerics.

docfx is looking good.

@henon @Oceania2018, Should we implement a documentation page like discussed here?
https://dotnet.github.io/docfx/


Remove develop branch reference

Let's use this PR to do a bunch of README cleanup. Mostly small grammar things. I'll push some changes by the end of the day   :+1:

This addresses #74 by splitting .repos files.


not all queries being written to log

Description
I have my configuration set to 'save to log files' which has written every query I run files in my 'Log Files Folder' but since upgrading I only get 1 or 2 queries written to the logs before it just stops writing them. I think this started happening at the prior version.
DBeaver Version
Community edition Version <IP_ADDRESS>404211624
Operating System
macOS Sonoma 14.4.1
Database and driver
I'm connecting to both postgres (PostgreSQL standard driver) and BigQuery (simba Google BigQuery driver)
Steps to reproduce
Start DBeaver
execute a query against either DB
Hit and miss if the query gets written to the log file
Additional context
No response

Seems to be fine in Version <IP_ADDRESS>403091004

Unfortunately, I can't reproduce the issue. Did you notice, if it happen with some specific queries?

No, I just start DBeaver, the first 2 or 3 queries get written to the log then nothing after that. I've reverted to 24.0.0 and everything is being written. It appears the same issue exists in the query manager view in that I only see a handful of the queries I am executing.

@TobyHewing do you have all these options checked?

You can open it by right-clicking in Query Manager view

I have User, User filtered, User script, Transactions and Queries ticked. In version 24.0.0 as soon as I execute a query it appears in the query manager view and in the log but in version 24.0.4 it does not. Changing the setting to include all of the above causes the BEGIN SESSION message to be written to the query manager view / log but no others are written

Hello @TobyHewing, Could you please send a video with your issue?

It's been a while since no update here. If the issue is still actual please let me know and provide additional information.

Having upgraded to 24.1.0 all queries are now logging correctly.


Nullable support

If the value is null, the .toString is not called

Hi @coplas thank you so much for the bug report and the PR.
I think the fix itself can be simplified by just adding  ?: "" after getItem(value).
Would you mind updating your PR with this?

Hi @coplas any feedback on this?

Hi @coplas, given the absence on reply I've published version 1.4.1 with a fix for your reported issue.
If you have the time please report back with feedback regarding the issue and thanks for the support.


Support customization of Envoy bootstrap config (#11559)

Already merged into master: https://github.com/istio/istio/pull/11559#issuecomment-462656579

Support customization of Envoy bootstrap config

This change allows override the default Envoy bootstrap configuration
for a resource. A sample is included to show how it can be used.

Format code

Fix tests

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @howardjohn. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign @costinm

/ok-to-test

Saw a
*** Test killed with quit: ran too long (26m0s).
FAIL	istio.io/istio/tests/e2e/tests/galley	1560.005s
make: *** [test/local/e2e_galley] Error 1

in the galley e2e tests.  https://circleci.com/gh/istio/istio/324127?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
@ozevren @ayj FYI
/retest

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
85304e2a4d4f70d8fa2d8a16042c43a977ffdc5b
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I think the circleci tests need to be restarted from circleci (not /retest)? Which I cannot do since I do not have permissions. But both the e2e-galley and lint fail look unrelated to my change

* command failed: "Error from server (BadRequest): container \"prometheus\" in pod \"prometheus-646dbcbbbf-wfjh5\" is waiting to start: PodInitializing\n" exit status 1
namespace "istio-system" deleted

It looks like this is a setup issue with the test. @ayj had a PR that helped identify such issues more clearly.

I've restarted the test

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
85304e2a4d4f70d8fa2d8a16042c43a977ffdc5b
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
85304e2a4d4f70d8fa2d8a16042c43a977ffdc5b
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-integ-k8s-test usually fails:  https://k8s-gubernator.appspot.com/builds/istio-prow/pr-logs/directory/istio-integ-k8s-tests
istio-pilot-multicluster-e2e almost always fails:  https://k8s-gubernator.appspot.com/builds/istio-prow/pr-logs/directory/istio-pilot-multicluster-e2e
I'll merge this as soon as I see a looks good to me

/lgtm, already reviewed in master.

Also: circle is not restarted by retest, you need to go to the circle page, click on the workflow and
hit 'rerun failed'.
They have an API and could be integrated in retest - but nobody had time to do it.


Live departure feed - transport to/from

Add a live departure board for public transport to transport.html (e.g. ruter MON or rtd.opm.jbv.no:8080/web_client/std?station=GDM)

Resolved, see commit 0a1741d


CMake configure error on Windows 10

Following is the configure error reported by cmake. It sounds a file named libfunctionalityTargets.cmake can't be found in the root directory of libfunctionality.
CMake Error at D:/GitHub/osvr/libfunctionality/libfunctionalityConfig.cmake:1 (include):
include could not find load file:
D:/GitHub/osvr/libfunctionality/libfunctionalityTargets.cmake

Call Stack (most recent call first):
CMakeLists.txt:189 (find_package)

I am having this problem as well.

Well I managed to find a sort of fix. This is for running CMake on OSVR-Core. I have no issues running CMake on libfunctionality on its own.

git clone https://github.com/OSVR/libfunctionality.git
CMake the source directory
grab libfunctionalityTargets.cmake from the bin path
Add libfunctionalityTargets.cmake to the original source folder

Do like the picture
Configure
Generate

When building OSVR-Core, I usually set CMAKE_PREFIX_PATH to point to the location where libfunctionality is installed. Then CMake will automatically find the libfunctionality cmake files and everything else it needs to make use of libfunctionality.

Ok I was going around in circles for a while and forgot to try that. It works. It is what I did for jsoncpp. I'm still having an issue with build errors though. My current issue is closer to https://github.com/OSVR/OSVR-Core/issues/437.

Per https://github.com/OSVR/OSVR-Core/issues/437#issuecomment-236320079, this issue has been solved.


PHP Error when processing credit cards

Received PHP error when attempting to process credit card for badge sales. Member received an error message when paying for guest via credit card. However, the transaction processed through our merchant account.

Unfortunately this was caused by horrendous network latency.  I will look into making the error display better.

This should work much better now that we have moved off Intuit.  https://github.com/sharkbit/BadgeApp/issues/64


Bumped androidx.security:security-crypto to 1.1.0-alpha05

Change log: https://developer.android.com/jetpack/androidx/releases/security?authuser=1#1.1.0-alpha05
It should fix issue: https://issuetracker.google.com/issues/164901843
issues from this repo: https://github.com/Liftric/KVault/issues/14

Closed in favour of af184f327e3d4400dd485d9c8b556157eb49ebc9


Implement LightClientModule interface for Celestia DA light client

Pre-requisites:

[x] https://github.com/cosmos/ibc-go/pull/5806 merged to main
[x] https://github.com/cosmos/ibc-go/pull/5813 merged to feature branch

Then, we can adopt the new client routing design for Celestia DA light client.

Closed by https://github.com/cosmos/ibc-go/pull/6053


Warning recommends using unexisting tf.keras.layers.CuDNNLSTM layer

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): pip install tensorflow-gpu==2.0.0-alpha0
TensorFlow version (use command below): 2.0.0-alpha0
Python version: 3.7.3
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 10.0
GPU model and memory: GeForce GTX 1080 Ti, 11175MiB

Describe the current behavior
In TF-GPU 2.0
Describe the expected behavior
Either have a tf.keras.layers.CuDNNLSTM or remove the warning.
Code to reproduce the issue
This to raise the warning
import tensorflow as tf
import tensorflow.keras.layers as ll
input_ = ll.Input((100,50))
x = ll.LSTM(100)(input_)

This to try to use CuDNNLSTM
import tensorflow as tf
import tensorflow.keras.layers as ll
input_ = ll.Input((100,50))
x = tf.keras.layers.CuDNNLSTM(100)(input_)

Other info / logs
The warning message:
W0428 17:18:46.256715<PHONE_NUMBER>39168 tf_logging.py:161] <tensorflow.python.keras.layers.recurrent.UnifiedLSTM object at 0x7fd8c75a9940>: Note that this layer is not optimized for performance. Please use tf.keras.layers.CuDNNLSTM for better performance on GPU.

When trying to call CuDNNLSTM:
AttributeError: module 'tensorflow.keras.layers' has no attribute 'CuDNNLSTM'

@Jsevillamol Able to reproduce the issue. TF 2.0.0-alpha0 uses tf.compat.v1.keras.layers.CuDNNLSTM Please check the reference link
I had updated the code with this alias as below and I dont see cuDNNLSTM warning.Please let us know how it progresses. Thanks!
import tensorflow as tf
import tensorflow.keras.layers as ll
input_ = ll.Input((100,50))
x = tf.compat.v1.keras.layers.CuDNNLSTM(100)(input_)
WARNING:tensorflow:From /usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/resource_variable_ops.py:435: colocate_with (from tensorflow.python.framework.ops) is deprecated and will be removed in a future version.
Instructions for updating:
Colocations handled automatically by placer.

I also have encountered this issue.
As @muddham mentioned, when I used tf.compat.v1.keras.layers.CuDNNLSTM to replace it, the warning message was gone.
However, I found that although the warning appears when using tf.keras.layers.CuDNNLSTM,
the training efficiency are the same as  tf.compat.v1.keras.layers.CuDNNLSTM
(Of course both are many times faster than tf.compat.v1.keras.layers.LSTM)
I wonder if it is just fine to remove the warning.

@hchungdelta I noticed that I am confused.  In my installation of TF 2.0 there is no longer a tf.keras.layers.CuDNNLSTM, just the the tf.compat.v1.keras.layers.CuDNNLSTM one.

@Jsevillamol  You are right. And I must apologize since I misuse the name in previous comment.
I use tf.keras.layers.LSTM  not tf.keras.layers.CuDNNLSTM.  (I edited the previous comment, sorry about making confusing)
tf.keras.layers.CuDNNLSTM no longer exists in TF 2.0. Since it was already combined into LSTM.(So you might see the function name of LSTM is "UnifiedLSTM").

@Jsevillamol Please confirm if you are happy to close this issue.

@muddham I am happy to close the issue if you are - I personally think that the warning should be removed in TF 2.0 since it is misleading for new users, but it is not causing me any major trouble.

@Jsevillamol I could reproduce the Attribute Error but I don't see any warning as you mentioned. Please check my GitHub gist and try to run it on your system. If you see the warning, please let me know I could work on resolving the warning. Thanks

I Could reproduce the warning message using tensorflow gpu. please see attached

@Jsevillamol Could check my gist and may be upgrade your TF2.0.0-alpha0 and run it again. If you see any error, we would like to resolve that. Thanks!

@jvishnuvardhan I can no longer reproduce the issue!

tf.compat.v1.keras.layers.CuDNNLSTM  works for me. Is it going to be available on non-beta1 platforms? What replaces it in TF 2.0.0-beta1 ?


TAS: validate the preferred and required annotations for Job and JobSet

What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #2724
Special notes for your reviewer:
Only covering Job and JobSet in the PR, but I would like to follow this up extending the support for all Job types hopefully for alpha. If the pattern is established it should be rather fast.
Does this PR introduce a user-facing change?
NONE

/cc @PBundyra @tenzen-y

actually, @tenzen-y wdyt about instead of webhook validation just deactivate the workload in workload controller? it would be much less code and work for free for all integrations?

actually, @tenzen-y wdyt about instead of webhook validation just deactivate the workload in workload controller? it would be much less code and work for free for all integrations? it would be a form of 'soft' validation as we plan for CQs.
/hold to clarify on the approach, I can prototype it in a separate pr next week

I believe that the validation approach is better than deactivation since, in the case of deactivation, they need to seek the reason why their Job was not admitted.
They do not have knowledge of the TAS limitations that can not be specified in both fields (preferred and required) at the same time. So I guess that they often fall in rabbit hole.

Yeah, I agree it is better from user's perspective to fail fast. I was just thinking it might be less code to validate at the workload level. If you think it is more important pros the user experience then I consider the PR ready to review and merfe

Yeah, I agree it is better from user's perspective to fail fast. I was just thinking it might be less code to validate at the workload level. If you think it is more important pros the user experience then I consider the PR ready to review and merge

Yeah, your POV also has a point, but I believe that the UX is more important.
So, let me merge this PR.

/hold cancel


now.sh => vercel.app

Prevent 308 status code by replacing now.sh in URLs with vercel.app

View rendered _apps/auto-comment.md
View rendered _apps/branch-switcher.md
View rendered _apps/delete-merged-branch.md
View rendered _apps/dep.md
View rendered _apps/deploy.md
View rendered _apps/first-timers.md
View rendered _apps/gitpod.md
View rendered _apps/handlebar-templates.md
View rendered _apps/polls.md
View rendered _apps/pr-label-enforcer.md
View rendered _apps/release-drafter.md
View rendered _apps/tap-release.md
View rendered _apps/tests-checker.md
View rendered _apps/triage-new-issues.md
View rendered _apps/weekly-digest.md

if you don't mind, I'd merge it in. It solves one problem. We can do that and then continue with the next

I've removed the draft status of this PR, let's merge it in 😄


Fix clippy warnings in rust nightly 1.85

Ah annoying. With newer rust version, the error output changed a bit (hence why CI is failing).

I added (and removed) a gate for different rust versions before: https://github.com/rinja-rs/rinja/commit/5955ba23c172ef6bbc0116b9ab0d6f068b86a688. But duplicating everything felt kinda wrong. Should we simply ignore nightly for now in the CI?

I think so yes. Or just run some tests, not ui ones.

Thanks!


Added sizeOffsets option

The sizeOffsets option is an array of ints that represent pixels of extra offset (besides the gutter) that may be needed in calculating the size (width or height) of each pane.

Thanks for the PR! I'm having trouble understanding, it looks like it's passing the element position, 0, 1, 2, etc and not pixel values?

Hi @nathancahill - thanks for taking a look! The new sizeOffsets option is an array of pixel values corresponding to the desired offset for each pane. There's no offset by default, so it's an array of zeros. You would use it like this (in this example, there are 2 panes, a top and bottom):
Split([topFrameElem, bottomFrameElem], {
sizes: [50, 50],
direction: 'vertical',
snapOffset: 0,
minSize: [20, 70],
sizeOffsets: [0, 48],
gutterSize: 8,
elementStyle: function (dimension, size, gutterSize, sizeOffset) {
var totalOffset = gutterSize + sizeOffset;
return { 'flex-basis': 'calc(' + size + '% - ' + totalOffset + 'px)' };
},
gutterStyle: function (dimension, gutterSize) {
return { 'flex-basis':  gutterSize + 'px' };
}
});
So there I'm specifying a 48 pixel offset for the bottom frame. Now to your question, if I'm understanding it correctly - the added parameter on setElementSize() (the 4th and last parameter) is simply passing in the index of the sizeOffsets array, which is needed to allow different offsets to be specified for different panes. Does that make sense?

Oh, I see. I think the same thing could be accomplished directly in the elementStyle function if the element index was passed?
if (elementIndex === 2) {
    // style with offset
} else {
    // style without offset
}

If so, we wouldn't need to add a new `sizeOffsets` option.

Ah, I see, yes that's true - I like it!

Published in v1.5.4.

Awesome - thanks!


Build failed

Module parse failed: Unexpected token (6:128)
File was processed with these loaders:

../node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
|  * This source code is licensed under the MIT license found in the
|  * LICENSE file in the root directory of this source tree.

/import React from'react';var ThemeContext=/#PURE*/React.createContext(undefined);ThemeContext.displayName="ThemeContext"export default ThemeContext;
Client bundle compiled with errors therefore further build is impossible.

Could you please give the reproduce code and tell us what's problem you are facing to?