Displaying versions of projects in Project Manager

Feature Request for Project Manager - Project Manager could display version information about projects. If you have many projects created on different versions of Godot, sometimes you might lose compatibility of some features, so you optimally want to finish the project (or create patches/updates) on version of Godot which is suitable for your project and/or newer if you re-import it and you know it will work. Project could have some version information line displayed next to it, just for keeping better order of your projects before you open them.

In Unity that information is available in a separate ProjectVersion.txt, which allows their project manager to show and check versions. Even if the project.godot format does not change, it may matter for users due to features they rely on or bugs in other versions.
If a TXT file is too messy, maybe we can put this in a header section of the project.godot file (so we don't need to parse it entirely), and if it's not present then we infer the version from config_version?

I wonder if it's okay to add this functionality/version field right now.
On the other hand, we have much of backward-incompatible features in 3.1 vs 3.0.*, so maybe it's time :)
Having a separate text file seems okay, though.

It's a gamble to open a project with unknown Godot version. In best case I wish the latest Godot version will convert the project or tell me: Sorry, this project comes from older unsupported Godot version (x.y.z). Just want to know that. Currently the only thing I get is when I try to open a scene: Unexpected end of file. -.-

Closing in favor of https://github.com/godotengine/godot-proposals/issues/237, as feature proposals are now tracked on the Godot proposals repository.


doc: it8xxx2: Documentation improvements

Better documentation describing the flashing and booting process.
Signed-off-by: Fu Haolei<EMAIL_ADDRESS>

The linux flash tool has been uploaded to ITE's website.

Hi，@keith-zephyr, @jackrosenthal , @brockus-zephyr , I have addressed your comments, could you help me review my PR?


Link main headlines - closes #297

As discussed with @SimonKoehl I also linked "Serlo" to the homepage. If there's a reason why we shouldn't do this, please comment.

thanks!


⚠ Bofrost.be has degraded performance

In 5968210, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1207 ms

Resolved: Bofrost.be performance has improved in 646cd08 after 8 minutes.


fix ftp script wrong var name

looks like this got missed!

Yep, it did. As with #19 I'm going to wait until menu2 is merged to avoid git screwery, but once it is this will be added.


[BUG] "si il" not contracted in French

Describe the bug
"si il" should become "s'il" in French
same for "si ils"
but not "si elle"
Expected behavior
"si il" => "s'il"
"si ils" => "s'ils"
Context:

RosaeNLG version: 2.1.4
Language: fr_FR

published v2.1.5


Building-Comfort: Create dev-container with postgresDB

Description

Add config for launching a VS Code Dev Container with Postgres installed.
Add script to generate and load data into Postgres.

Testing

Manually verified that launched Dev Container has required dependencies
Script to generate and load data into Postgres was tested and verified

We should probably update the readme file to include a set of instructions for using the dev container approach

Yes, that's the plan.
At this point we're just adding a hidden directory (prefixed with dot) and an unused script.
These should not impair the current experience of any users.
Once the example is revamped, I plan to remove all references to Azure from the existing ReadMe file and write steps to either run in Dev Container, GitHub CodeSpaces, or otherwise locally.


Nondifferentiated positional args beyond x?

@mohamed82008 and I had a council meeting before the next release, and we reconsidered the question of nondifferentiated positional arguments, introduced in #89 by @thorek1 (thanks for the contribution!).
Our current position is that the risk of a user mistake (expecting a derivative where there will be none) outweighs the practical benefits. This is reinforced by the fact that:

we don't yet have a short MWE of the things that are harder to do without this feature
while some things may be harder to do, they remain far from impossible with a bit of additional sweat

As things stand, the "positional args" feature will be rolled back before v0.5. Still, we are opening this issue to add more pros and cons, so feel free to weigh in!

here is a short MWE which works with the current version:

using ForwardDiff: ForwardDiff
using ImplicitDifferentiation: ImplicitFunction, identity_break_autodiff
using Zygote: Zygote, ZygoteRuleConfig
using RuntimeGeneratedFunctions
RuntimeGeneratedFunctions.init(@__MODULE__)

function mypower(x::AbstractArray, p)
    return identity_break_autodiff(abs.(x)) .^ p
end

RTGconditions = :(conditions(x, y, p) = y .^ (1 / p) .- abs.(x))
test_conditions = @RuntimeGeneratedFunction(RTGconditions)

RTGfunct = :(function test_implicit(X)
    impl = ImplicitFunction(mypower, test_conditions)
    return impl(X,0.5)
end)

test_implicit = @RuntimeGeneratedFunction(RTGfunct)

test_implicit([1.0,2.0])

ForwardDiff.jacobian(test_implicit,[1.0,2.0])

Zygote.jacobian(test_implicit,[1.0,2.0])[1]

if you don't have non differentiated positional arguments you need to write something along these lines:
function implicit(X::Vector{<: Real},p::Float64,conditions::Function)
    ImplicitFunction(x->mypower(x,p), (x,y) -> conditions(x,y,p))
end

function mypower(x::AbstractArray, p)
    return identity_break_autodiff(abs.(x)) .^ p
end

RTGconditions = :(conditions(x, y, p) = y .^ (1 / p) .- abs.(x))
test_conditions = @RuntimeGeneratedFunction(RTGconditions)

RTGfunct = :(function test_implicit(X)
    impl = implicit(X,.5,test_conditions)
    return impl(X)
end)

test_implicit = @RuntimeGeneratedFunction(RTGfunct)

test_implicit([1.0,2.0])

ForwardDiff.jacobian(test_implicit,[1.0,2.0])

Zygote.jacobian(test_implicit,[1.0,2.0])[1]

I find the latter less intuitive and having more unnecessary syntax.
these examples work only in these ways because of the constraints of RuntimeGeneratedFunctions: no opaque closure, no kwargs
Irrespective of this  non differentiated positional arguments are a natural and intuitive extension and add to usability in my view. The risk of confusion can be diminished by documenting the interface. In my view this risk of confusion is small given that users of ImplicitDifferentiation will be aware of the syntax of other Julia AD interfaces and they allow derivatives wrt one element only.

Thanks for the MWE!

I find the latter less intuitive and having more unnecessary syntax.

That may be true but the difference in LOCs is very small, so for advanced Julia users I think this is okay.
I had never even looked up RuntimeGeneratedFunctions.jl before today, and it definitely doesn't seem like the kind of thing a casual Julia user would employ.

these examples work only in these ways because of the constraints of RuntimeGeneratedFunctions: no opaque closure, no kwargs

Outside of the framework of this weird package, can you think of another example where what is achievable with args... cannot be achieved with kwargs...?

other Julia AD interfaces [...] allow derivatives wrt one element only.

That is not necessarily the case: ChainRules.jl allows derivatives for all positional arguments, but it returns meaningful tangents for each of them.
Indeed ForwardDiff.jl only works with a single argument, but as a result it doesn't allow passing multiple.
If we kept the feature we're discussing, we would be in a weird middle ground where we accept arguments but do not differentiate them, and that's what I fear will be confusing.

users of ImplicitDifferentiation will be aware of the syntax

I don't want this to be a package for experts, the whole point is to make it as accessible as possible.
So the standard that I'm aiming for is that even beginners should understand intuitively how it works.

@ChainRules cool feature :) I didn't know about it. I take the common ground in interface between forward and reverse mode is: diffable 1st positional arg, non-diffable positional args; non-diffable kwargs
In that case, it is confusing for reverse mode users that they have to use ComponentArrays or similar tricks to get their other positional args diffable and I see that you documented that well.
In my view the non-diffable args are a feature forward mode users might be missing (even though they can go around it with kwargs). I see that providing it might confuse reverse mode users but then again you explain already how they have to handle other diffable args using ComponentArrays.
At the very least I would then explain how to use non-diffable args (the kwargs option and the non-kwargs workaround) in case users want to do so.
@LOCs in my case I have about 10 arguments so it gets a bit more ugly (larger code blocks I posted in other threads)

To be honest I still wasn't convinced, but then I remembered the key difference between positional and keyword arguments: keyword arguments do not participate in dispatch. Therefore, if a user needs some form of multiple dispatch for forward or conditions, this is the only way to enable it.

Case closed :)


Move creating clients to top level

Creating client may be somewhat expensive, so it's better to avoid
having to recreate them. This moves their definition to the top
level.

In hindsight, this is not really worth the overhead of needing to have credentials in the top level.


Unable to exit full screen normally

I can enter the full screen normally, but there are some bugs when I exit the full screen。

Exit full screen button does not work
After exiting the full screen, there is still sound and video playing in the background。

It's strange that I can run the code alone, but bug appears in my project。
Is it because of conflicts with other dart packages?

It`s my fault.
I used the FutureBuilder component， and ignored the issue of FutureBuilder redrawing.


issue with web3modal contructor

Uhoh! There was an error!
TypeError: import_web3modal.default is not a constructor
    at EthersModalConnector.loadCore (http://localhost:3000/node_modules/.vite/chunk-LNEPW6E3.js?v=08d3923f:314:43)
    at autoConnectToBurner (http://localhost:3000/src/components/main/hooks/useScaffoldAppProviders.ts:44:19)
    at http://localhost:3000/src/components/main/hooks/useScaffoldAppProviders.ts:59:19
    at invokePassiveEffectCre

...

/.vite/chunk-RJUD5BXP.js?v=08d3923f:3671:22)
    at Object.invokeGuardedCallbackDev (http://localhost:3000/node_modules/.vite/chunk-RJUD5BXP.js?v=08d3923f:3696:24)
    at invokeGuardedCallback (http://localhost:3000/node_modules/.vite/chunk-RJUD5BXP.js?v=08d3923f:3730:39)
    at flushPassiveEffectsImpl (http://localhost:3000/node_modules/.vite/chunk-RJUD5BXP.js?v=08d3923f:16819:17)
    at unstable_runWithPriority (http://localhost:3000/node_modules/.vite/chunk-RJUD5BXP.js?v=08d3923f:346:20)
    at runWithPriority$1 (http://localhost:3000/node_modules/.vite/chunk-RJUD5BXP.js?v=08d3923f:8468:18)

I'm seeing bug with the provider modal, I'm not sure if it's related to this issue or not. When I change the target network env variable from local host a test network, the provider modal won't open when I restart the app. I just get a spinner on the connect button, but the modal never opens.
If I open an incognito tab, or clear local storage, then the modal does show when I try to connect.

Also encountering this issue.


Load KeyStore on a background queue.

Codecov Report

Merging #34 into master will increase coverage by 0.56%.
The diff coverage is 97.97%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   87.33%   87.89%   +0.56%
==========================================
  Files          23       23
  Lines        1398     1471      +73
  Branches       55       55
==========================================
+ Hits         1221     1293      +72
  Misses        169      169
- Partials        8        9       +1

Impacted Files
Coverage Δ

Tests/KeyStoreTests.swift
100% <100%> (ø)
:arrow_up:

Sources/KeyStore.swift
67.92% <92%> (+1.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a0ee4...9d3d8b5. Read the comment docs.


[SOLR-16515] Remove synchronized access to cachedOrdMaps in SlowCompositeReaderWrapper

https://issues.apache.org/jira/browse/SOLR-16515
The SlowCompositeReaderWrapper uses synchronized read and write access to its internal cachedOrdMaps. By using a ConcurrentHashMap instead of a LinkedHashMap as the  underlying cachedOrdMaps implementation and the ConcurrentHashMap#computeIfAbsent method to compute cache values, we were able to reduce locking contention significantly.
Background
Under heavy load we discovered that application halts inside of Solr are becoming a serious problem in high traffic environments. Using Java Flight Recordings we discovered high accumulated applications halts on the cachedOrdMaps in SlowCompositeReaderWrapper. Without this fix we were able to utilize our machines only up to 25% cpu usage.
Description
Our Solr instances utilizes the collapse component heavily. The instances run with 32 cores and 32gb Java heap on a rather small index (4gb). The instances scale out at 50% cpu load. We take Java Flight Recorder snapshots of 60 seconds
as soon the cpu usage exceeds 50%.

During our 60s Java Flight Recorder snapshot, the ~2k Jetty threads accumulated more than 16h locking time inside the SlowCompositeReaderWrapper (see screenshot). With this fix applied, the locking access is reduced to cache write accesses only. We validated this using another JFR snapshot:

Solution
We propose the following improvement inside the SlowCompositeReaderWrapper removing blocking synchronized access to the internal cachedOrdMaps. The implementation keeps the semantics of the getSortedDocValues and getSortedSetDocValues methods but moves the expensive part of OrdinalMap#build into a producer. We use the producer to access the ConcurrentHashMap using the ConcurrentHashMap#computeIfAbsent method only.
The current implementation uses the synchronized block not only to lock access to the cachedOrdMaps but also to protect the critical section between getting, building and putting the OrdinalMap into the cache. Inside the critical section the decision is formed, whether a cacheable value should be composed and added to the cache.
To support non-blocking read access to the cache, we move the building part of the critical section into a producer Function. The check whether we have a cacheable value is made upfront. To properly make that decision we had to take logic from MultiDocValues#getSortedSetValues and MultiDocValues#getSortedValues (the SlowCompositeReaderWrapper already contained duplicated code from those methods).
Summary
This change removes most blocking access inside the SlowCompositeReaderWrapper and despite it's name it's now capable of a much higher request throughput.
This change has been composed together by Dennis Berger, Torsten Bøgh Köster and Marco Petris.
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[x] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

It's a WrappedQuery object.

Hey, this looks excellent! The code looks a bit deja-vu... do you think we could & should factorize out anything common?

@dsmiley We could factorize out most of SlowCompositeReaderWrapper::getSortedDocValues and SlowCompositeReaderWrapper::getSortedSetDocValues to MultiDocValues just like it was. But to me it looks like as the two MultiDocValues methods were used in SlowCompositeReaderWrapper only. So I'm not sure that it would be worth the effort. Moreover since the usage of MultiDocValues seems to be discouraged anyway.

I don't mean change Lucene code, I mean change SlowCompositeReaderWrapper internals only.  Yeah Multi-stuff is kind of discouraged... more of a  -- hey, use this if your algorithm can't easily loop over segments, which is probably what you should do if you cant. These Multi-classes are not going away.
It's also okay to accept some duplication if you are only duplicating the Lucene code since at least then it's easier to verify we are keeping in sync with possible changes in Lucene.

OK, got it. We refactored the implementation a bit to seperate the algorithm from the access to SortedDocValues and SortedSetDocValues. This allows us to have the algorithm only once. It is a different style now compared to the style from MultiDocValues. I like the refactored one better but it depends a bit on ones taste.


Add prune config for Yarn in the offline mirror

Add prune config for Yarn in the offline mirror. Also updates our Yarn version in TravisCI
Changelog
New
Changed

.yarnrc now has prune option enabled
.travis.yml now uses Yarn v1.9.4

Removed

@joshblack Do you want to possibly update the offline mirror, or other stuffs that are needed for Travis to go through? Thanks!


Implement Difficulty into GUI

closes #157

Codecov Report

Merging #158 into master will decrease coverage by 0.33%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
- Coverage     68.63%   68.29%   -0.34%
  Complexity      597      597
============================================
  Files            96       96
  Lines          2031     2041      +10
  Branches        237      241       +4
============================================
  Hits           1394     1394
- Misses          533      543      +10
  Partials        104      104

Impacted Files
Coverage Δ
Complexity Δ

...in/java/quickcache/logic/commands/EditCommand.java
83.14% <ø> (ø)
10.00 <0.00> (ø)

src/main/java/quickcache/ui/FlashcardDisplay.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ed776...b780eb4. Read the comment docs.


Update code plan and change and Improve test coverage

Features

Split CODE_PLAN_AND_CHANGE into DEVELOPMENT_PLAN and IMPLEMENT_CHANGE and update prompt
Update zip files to maintain consistency with TASK_PDF_FILE_REPO of const.py
Adjust the position of the log for WriteCodePlanAndChange
Improve test coverage

Codecov Report
Attention: Patch coverage is 81.48148% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.81%. Comparing base (3acefa3) to head (853d3d5).
Report is 54 commits behind head on main.

Files
Patch %
Lines

metagpt/roles/engineer.py
50.00%
5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   81.19%   81.81%   +0.61%
==========================================
  Files         226      226
  Lines       12478    12469       -9
==========================================
+ Hits        10132    10201      +69
+ Misses       2346     2268      -78

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How to run Ionic commands

How can I run a Ionic command like "ionic generate" or "ionic cordova resources"?
Ionic CLI does not recognize the project as ionic project and therefore throws an error

You cannot use ionic cli for now, it will work after the release of ionic@v4 as it's announced to be compatible with angular-cli.
Instead of ionic generate you can use ngx generate with any of the https://github.com/angular/angular-cli command.
However to use ionic cordova resources you can trick ionic to think it's a ionic project by adding a ionic.config.json:
{
  "name": "anything",
  "app_id": "",
  "type": "ionic-angular",
  "integrations": {}
}

and it should work.

thanks, I'll try it


Where to find API/docs?

It seems like http//:idangero.us/swiper/api/ doesn't work.
Where can I find Swiper API?

It seems like http//:idangero.us/swiper/api/ doesn't work.
Where can I find Swiper API?

https://swiperjs.com/api/

Thank you!


conditional logic or props to layouts?

First I really have to say I love what you do with the framework amazing just started yesterday and creating my first project with nuxt.js already!
I was wondering what will be the best approach on the following? this is my default layout:
<template>

    <nuxt/>
    <my-footer/>

</template>

I want to reuse the layout but to add additional logic or props based on routes so it works really well for / but when ever I go to /search I want an extra prop for  something like that:
<template>

    <nuxt/>
    <my-footer/>

</template>

Because the routes are hidden/generated I'm not really sure what the best way to approach this without duplicating the layout?
Thanks a lot

Hi @voidale
You can do it pretty easily by checking this.$route.path:
<template>

    <nuxt/>
    <my-footer/>

</template>


Since update to Home Assistant OS 7.2, it is broken

Please check Services, Known Bug / Issues and Troubleshooting over here first: https://github.com/fuatakgun/eufy_security/blob/master/README.md
Describe the bug
Since update to Home Assistant OS 7.2, it is broken.
**Log
2022-01-25 07:28:25.030  INFO  Eufy Security server listening on port 3000
2022-01-25 07:28:27.656  INFO  Connected to station T801xxxxxxx on host <IP_ADDRESS> and port 16408
2022-01-25 07:28:28.471  INFO  Push notification connection closed
2022-01-25 07:28:28.604  INFO  Push notification connection successfully established
2022-01-25 07:28:33.732  INFO  Push notification connection successfully established
**Hardware Information about Home Assistant
RPI4
**Hardware Information about Cameras

Eufy Cam 2c
Live Streaming Protocol: RTSP

Additional context
No entitie is available any more

Close my issue. After a while it works again.


cant run eosc commands on Server using my IP address!

I have configured my RPC interface with "http-server-endpoint" and Chain_API plugin in the config.ini file.
Whenever I run eosc commands on localhost, Im able to get relevant output. But when I use IP address of my cloud server, I get following error:
Failed to connect to eosd at localhost:8888; is eosd running?

Although my eosd was running. When I ran my eosd after editing config.ini file, I got following output:

Blocks were still producing and my eosd was running.

Yes sir I have

@heifner Sir Im in trouble please help me with this!

If your eosd is not running on localhost then you have to pass host and port to eosc. See eosc help for host and port options.

Sir I have provided that too but eosc is not accessing eosd on that ip address and port

Sir my eosd is running perfectly on provided IP address and all the plugins are successfully loaded but still eosc is not able to access eosd on my IP address although I've provide host and port in the eosc commands! @heifner

can you access the api via browser?

no sir i cant
On Nov 27, 2017 2:10 PM, "nanonano7"<EMAIL_ADDRESS>wrote:

can you access the api via browser?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EOSIO/eos/issues/783#issuecomment-347112968, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVFFBLYaQ9KaudUYp7OX6ijTF6cKYy5Sks5s6nWUgaJpZM4Qqs7f
.

well then its not eosc. can you provide your eosd config?

@nanonano7 Hi I'm having the same issue after I changed http-server-endpoint with myHost:myPort. eosd config has http_plugin:

Although i can access API via browser to get chain-info with following url
http://myHost:myPort/v1/chain/get_info

But can't access any other info related to wallet-list, account-info, etc.
Also i faced the same error as @jatinmehta420 faced.

Please help!

Please use telegram EOS Developers or EOS.IO Testnet Developers for support.
If myPort != 8888 then you will need to specify port on the command line to eosc.


so....

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

privacy.docx

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

code --verbose --vmodule="/components/os_crypt/=1"


Add name to FlexRender component

Inside the Vue devtools, I think this is currently an Anonymous Component. This would give it the correct name, right?

If this is still important, can we open a new PR without conflicts? Sorry for the delay/inconvience.


Get the sheetnames from excel

Hi,
Is there a way I could get the all the worksheet names in the workbook using alasql?
Thanks

Not at the moment


Intro to Postgres Planner

Workshop Title
Melanie Plageman, PGCon 2019, Intro to Postgres Planner
Date: December 2024
Resources

Video: https://www.youtube.com/watch?v=j7UPVU5UCV4

Frédéric: I watch Melnanie's presentation for the next workshop and look at her pointers. I'm not too sure I understand what a path is in  planner's jargon. Is it a simplified representation of a potential plan whole tree? Or could it be a subtree?
Robert Haas: Subtree.
You can think if a Path as the precursor to a Plan. We have Plan nodes (like SeqScan and IndexScan) and then we have path nodes (like SeqPath and IndexPath) from which the corresponding Plan nodes are constructed.
A Path takes less work to construct than a Plan, so initially we make Paths, and then the losers are thrown away and the winning Path is turned into a Plan.

Robert's talk that discussed the Plan data structure: What's in a Plan -- PGCon 2018 & Slides

Guidelines for new Optimizations

Does it always retain semantic correctness?
Does it inhibit downstream optimizations?
Is the improvement in execution time worth the cost in planning time?
Is the complexity cost commensurate the performace benefit?


Add two buttons instead of just one

Hi!
I am using mailgen for sending out transactional mails. For a new feature I need two different buttons in one mail. Just tried it out to simply use two action-objects but mailgen seems to just take the second one and ignore the first. Does someone know how to do it?
Cheers

Hi @gemueselasagne!
Great suggestion! Displaying more than one action button in generated e-mails is currently not possible out of the box, but that could definitely be changed!
A PR could be submitted to make it possible to pass in body.action as an array (and support an object as well) to mailGenerator.generate, as well as modifying each built-in theme to render all passed in action buttons in the respective templates' HTML and TXT files.
Let me know if anyone would like to work on this. 😄

@eladnava i'd like to give it a shot!

@collnwalkr Awesome! Would you like some tips on how to implement this? 😄

@eladnava sure! But first this is what I've done so far.
First, I edited welcome.js's email.action to be an array:
var email = {
    body: {
        // removed for brevity
         action: [
             {
                 instructions: 'instruction',
                 button: {
                     color: '#22BC66',
                     text: 'button',
                     link: 'https://www.google.com/'
                 }
             },
             {
                 instructions: 'instruction 2',
                 button: {
                     color: '#33BC66',
                     text: 'button2',
                     link: 'http://www.bing.com/'
                 }
             }
         ],
        // removed for brevity
    }
};

Then that led me to ejs.render on index.js line 71. It looks like the fix might have to be applied to every theme. Do you think that would be an acceptable solution? I could also edit THEME.md to reflect the upgrade.

@collnwalkr Absolutely! You are on the right path. You will indeed need to modify each theme separately, adding support for more than one action (and also supporting just one action if passed in). Specifically, in the default theme for example, this would be the section to modify:
https://github.com/eladnava/mailgen/blob/461ab1c84ad99488161deb2d71457f2b547e4f56/themes/default/index.html#L307-L318
You could employ an ejs forEach loop like so
https://github.com/eladnava/mailgen/blob/461ab1c84ad99488161deb2d71457f2b547e4f56/themes/default/index.html#L338-L340

@eladnava thanks. I've already made good progress. I'm wondering what Gmail Go-To Actions are? Will these be impacted?

alright here's my solution: #18

@collnwalkr Great!
No need to worry about the Gmail Go-To Actions. There seems to be no way to provide more than one according to the docs.


cambio

Does this occur consistently?
Repro steps:

Action: appService.Deploy
Error type: Error
Error Message: fatal: your current branch 'master' does not have any commits yet
Version: 0.19.0
OS: win32
OS Release: 10.0.19041
Product: Visual Studio Code
Product Version: 1.49.2
Language: en

Call Stack
Object.<anonymous> extension.bundle.js:164:522736
rejected extension.bundle.js:164:522163
processTicksAndRejections task_queues.js:94:5

Looks like you're trying to deploy via local git. You should either commit a change to your branch or you can configure your deployment source to be "None" which leverages zip deploy.


Critical vulnerability: Insufficient validation when decoding a Socket.IO packet

Hello,
We are currently facing a critical vulnerability in our project that depends on karma.
https://github.com/advisories/GHSA-qm95-pgcg-qqfq
Steps to reproduce:
npm install
npm audit
Console message:
├─ socket.io-parser: 4.0.4
│  ├─ Issue: Insufficient validation when decoding a Socket.IO packet
│  ├─ URL: https://github.com/advisories/GHSA-qm95-pgcg-qqfq
│  ├─ Severity: critical
│  ├─ Vulnerable Versions:
│  ├─ Patched Versions: >=4.0.5
│  ├─ Via: karma, karma-htmlfile-reporter, karma-jasmine-html-reporter
│  └─ Recommendation: Upgrade to version 4.0.5 or later

Thank you in advance.

yeah experienced the same thing.

I've tried updating my Karma stack to 6.4.1 but a few of my Karma suites are halting/failing to complete.  When I view in the browser, I see pending localhost/socket-io requests that never complete, they just restart after 30 seconds.  Feels awfully related to either this dependency or socket.io-parser.

I've tried updating my Karma stack to 6.4.1 but a few of my Karma suites are halting/failing to complete. When I view in the browser, I see pending localhost/socket-io requests that never complete, they just restart after 30 seconds. Feels awfully related to either this dependency or socket.io-parser.

6.4.1 is using the vulnerable socket.io
i made a PR bumping it and waiting on it to get reviewed.
#3825

I tried adding these two resolutions along with 6.4.1 but ran into the same problem.
"resolutions": {
    ...
    "**/socket.io": "4.5.2",
    "**/socket.io-parser": "4.2.1",
    ...
}

I'm experiencing the same problem

Any timeline on getting this PR merged?

+1，   waiting for the patch version...

+1， waiting for the patch version...

+1, we are also waiting for the patch version...

+1, waiting for the patch version...


Fixed tar options and path for restoring images

Proposed changes
-z option for tar is used to filter through gzip. This should be excluded for the restore as it was not used during the backup.
The path is also fixed as it recreated the entire path within the volumes folder.
Unreleased project version (optional)

Related issues (optional)

@cherylq26 Thanks for making our docs better 🙌
Let's ship it 🚀


ipfsstore.it possible issue

ipfsstore.it seems to be dead
https://developers.cloudflare.com/distributed-web/ipfs-gateway/connecting-website

eternum.io is pretty much done too, they're no longer accepting  new credits and plan to shut down when all current credits are used up

@kodster28 we have some dead links on this page. Would you mind investigating and updating? Thanks.


change: [M3-7703] - Hide error message for $0 regions

Description 📝
Hide error message for $0 regions since that is not technically an error. Continue to display the error icon otherwise.
Changes  🔄
List any change relevant to the reviewer.

Error message tooltip no longer displayed for $0 region prices in Linode and Kubernetes Create
Plus and minus and Add buttons are no longer disabled in Kubernetes Create Plan table if the price is $0

Preview 📷

Linode Create Before
Linode Create After

Kubernetes Create Before
Kubernetes Create After

How to test 🧪
Reproduction steps

On another branch/prod, go to Linode/Kubernetes Create
Select the Madrid region
Notice the error icon for both the $0 hourly price and $--.-- monthly price
Notice the disabled plus, minus, add buttons in the Kubernetes Create Plan table

Verification steps

Go to Linode/Kubernetes Create and select the Madrid region
You should no longer see an error icon for the $0 hourly price. You should continue to see an error icon for the $--.-- monthly price
The plus, minus, add buttons should no longer be disabled in the Kubernetes Create Plan table

yarn test KubernetesPlanSelection
yarn test PlanSelection

As an Author I have considered 🤔
Check all that apply

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[ ] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

@mjac0bs Addressed the $0 view. Updating the HA price from $60 will be a bigger lift due to hardcoded values and coupled code. I created M3-7732 to address that since it's a bit out of scope for this ticket


Is this based on CodeMirror 1 or 2?

This is based on CodeMirror 5.

Oops, thank you!

This may be another silly question but is it possible to pack CodeMirror into a single .js file instead of the mess it is now?

https://github.com/Dominator008/CodeMirror-minified/blob/master/lib/codemirror.js
I believe this is what you meant by a single .js file.

Currently I'm using Editor.md which is based on CodeMirror and as a result I have to include so many folders and files.  So I was wondering if it is possible to combine CodeMirror's addons, modes, themes etc. together with its core library into a bundle of one or a couple of files instead of many folders and files?

It might be possible to do so by adding the files you need to CodeMirror’s Rollup config:
https://github.com/codemirror/CodeMirror/blob/master/rollup.config.js
I haven’t tried it myself though.

Thank you for pointing that out, I posted this question in their forum and got this answer.

CodeMirror doesn’t come with anything like this, and its rollup.config.js is just used to build the core library (lib/codemirror.js). Bundler software like webpack can create such files for you, though. (Or, if you don’t want to use a module system, just concatenating the files should work too.)

Hi Michael, how hard do you think bundling CodeMirror into a single file or just a few files would be and is that something your project would consider? Thanks!

https://raw.githubusercontent.com/Dominator008/CodeMirror-minified/f4a96bd282b46664a3f0d302d05c1cec82c6ad6c/lib/codemirror-bundled.js
Could you check if this file works? I simply concatenated all the minified JS files.

I created this demo repo for you to see what's happening, I got this error

Uncaught ReferenceError: test is not defined
at codemirror-bundled.js:584


nixos/knot: allow XDP usage

Provide the relevant capabilities and allow AF_XDP, when the xdp section
is configured in the declarative configuration.
https://www.knot-dns.cz/docs/3.3/singlehtml/index.html#pre-requisites## Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg test knot

I wonder if we should introduce an explicit option that turns off configuration checks, and this option would default to cfg.keyFiles == [] && !withXDP currently.

I think both situations break really hard under the configured conditions, so I can't image why we'd want to allow someone to enable them. Is it, because it gives people more chances to experiment with knot? Is it because then we expose the basis for the decision better?

I meant it for the ability to disable the checks.  There might be some more corner cases that we haven't discovered yet.

Added two options in the latest change:

enableXDP with the same default as before, but now everyone may enable it at their own discrection
checkConfig as discussed

I like the approach.  It's nice to utilize NixOS's knowledge of the daemon configs in this way.

run an eBPF program on your NIC

Nit: I believe almost no hardware supports doing that.  Certainly none of the cards that we've tested (mainly Intel cards).
I see nothing wrong in the diffs.

Right, that may be something cards like Bluefield or Netronome can do. Let me reword that.

Yes, I do remember from years ago that some Netronome card could do it and maybe it was the only one at that point.

Added a link to the limitations on the enableXDP option.


reset form setting values nested in an array to undefined (v4.0.5)

I have a form which contains the fields:
'group.members[].name',
'group.members[].age'

I am setting initialValues, which is a deep JS object, through the mapStateToProps function
// initialValues
{
  group: {
    members: [{name: 'Bob', age: 40}]
  }
}

The form is properly initialized;
// this.props.fields
{group:
    members: [
      {
        name:  {defaultValue: 'Bob', initialValue: 'Bob', value: 'Bob'},
        age:  {defaultValue: 40, initialValue: 40, value: 40}
      }
      ...
   ]

however, after resetting the form, the values are set to undefined, instead of being set to the initialValue.
// this.props.fields
{group:
    members: [
      {
        name:  {defaultValue: 'Bob', initialValue: 'Bob', value: undefined},
        age:  {defaultValue: 40, initialValue: 40, value: undefined}
      }
      ...
   ]

I'm working around the problem by destroying the form and reinitializing.
I'm using the 'data' property instead of 'initialValues' because the initialValues prop seems to be intercepted by Redux Form and isn't available inside of componentWillReceiveProps.
componentWillReceiveProps(nextProps) {
  if (this.props.editing && !nextProps.editing) {
    this.props.destroyForm();
    this.props.initializeForm(this.props.data);
  }
}

It occurred to me that the name of the properties, which I changed in the example, might be the reason.  The properties are actually 'name' and 'value'.  I realized it when using getValues() returned the value of the 'value' property as the value of the whole object.  I'm going to close this issue and open up a new issue that focuses on properties named 'value'.


1.0.3 doesn't seem to be published anywhere

I can't find 1.0.3 published anywhere, only 1.0.0

Hi @lucamtudor  , i'm sorry, you right, the jar wasn't uploaded to mavenCentral, hadn't noticed it, because of local cache. It's online now

Hi @lucamtudor  , i'm sorry, you right, the jar wasn't uploaded to mavenCentral, hadn't noticed it, because of local cache. It's online now


Feature Request: Default profile for powershell

Hi,
I spent always long minutes to setup terminal for people and i didn't understand why the following profile is not the default one for powershell :
Import-Module PSReadLine

Set-PSReadLineKeyHandler -Key Tab -Function MenuComplete
Set-PSReadlineKeyHandler -Key UpArrow -Function HistorySearchBackward
Set-PSReadlineKeyHandler -Key DownArrow -Function HistorySearchForward
Set-PSReadLineOption -predictionsource history
Set-PSReadLineOption -HistorySearchCursorMovesToEnd

It requiert "PSReadLine 2.1.0-beta2"
(didn't know why these features are just in beta, because they exist on every other OS since many years, but that's not the point.)

The only one in beta currently as far as I'm aware is the -PredictionSource option.
As for the rest, the default settings are handled by PSReadLine itself, so it might be better to ask in that repository instead of this one. 🙂

PSReadLine is added by default on powershell right ?

Yeah it's pulled into the default build. 🙂

Those have been the default options for PowerShell since windows PowerShell V1. On linux default tab behaviour is different and setting edit mode allows you to get a different one.
TBH, it is so ingrained for every existing PowerShell user , and included in so many documents that changing it to someone else's preference has very little chance of happening.  I'd leave users to set their own preferences, most of us have our own customizations and I would impose mine on my user community.


Fixed: Overriding CSS Properties of Google Translate Bar

Fixes: #1350
Bug Fixed:-
In the navbar below the translate searchbar "Powered By" is written whose sense is incomplete without "Powered by Google".
Upon inspecting I found that CSS has been written to hide it, "Google Translate" img is hidden by that but it is not being reflected on "Powered By", it is being overridden by some other properties.
I have fixed that issue.
Before

After

Thanks for contributing!!

@akshitagupta15june Thank you so much ma'am for merging at this last moment.


Sport stream issues

From Samuel S.:
We are currently investigating a bug which has been reported by SRF users. (SRF has an open ticket here: https://srgssr-ch.atlassian.net/browse/OS-3720).
In short, users report that on MacOS livestreams get interrupted and a message “Der Inhalt kann nicht abgespielt werden” (“Content cannot be played”) is shown.
Since this seems to primarily affect Mac users, I thought I’d touch base with you first. Please let me know if you think somebody else would be more suitable.
In a first step, we would like to grasp the scope of the bug in order to narrow down the root cause. I fear that this might be a complicated analysis which includes teams all along the signal chain, so I’d like to do this as systematic as possible.
First of all: Have you heard of this bug? Do you maybe already have some analysis on your end? I remember we had a similar issue with RTS during the football Euro in June, but after RTS switched to the new cloud-based version, I have not heard of this again.
Some questions I am trying to answer:

Does this only concern SRF or are RTS/RSI/RTS also affected?
Does it only affect Mac users or does the same error occur on Windows?
Does it only affect MacOS or are other versions iOS/tvOS also affected?
Which Player versions are affected?
Which system is handling & displaying the exception message (“Der Inhalt kann nicht abgespielt werden.”) – player or  the application/website? What are the causes which trigger this message?
Does somebody have a stack trace of the bug (ideally also with a couple of seconds of http traffic before the exception occurs).

Tilman R. mentioned that the bug does not appear in simulcast livestreams but only with sports (=events) livestreams. On our end, the transcoding configuration for both simulcast and events are exactly the same. The packaging, however, has some slight differences (e.g. DRM for simulcast which is not activated for events). I will put together a table which lists the packaging differences between simulcast and event livestreams. (We are tracking the investigation in this ticket: https://srgssr-ch.atlassian.net/browse/STXTBROAD-1404 ).
We are happy to change packaging configs, we just need to be careful, since there is only one HLS config for all event livestreams –when fixing a bug for one platform we want to avoid side-effects for other platforms.
Maybe it would be a good idea to organize a call between Streamteam and Pillarbox team to kick this off and then see how we want to proceed with the analysis and who else we might need.
Would you be fine if we send you an invite for a call somewhere next week?

Does this only concern SRF or are RTS/RSI/RTS also affected?

A

Does it only affect Mac users or does the same error occur on Windows?

A

Does it only affect MacOS or are other versions iOS/tvOS also affected?

A

Which Player versions are affected?

A

Which system is handling & displaying the exception message

A

Does somebody have a stack trace of the bug (ideally also with a couple of seconds of http traffic before the exception occurs).

A


Update universal-packages.md

Fixed typo on an example and updated vstsFeedPublish attribute to clarify what it will take.

@Thomas-Leung : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@chasewilson Could you review this pull request? Thank you.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Thomas-Leung sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@Thomas-Leung Would you take a moment to sign the CLA? Then we can review your pull request.
@juliakm I've added this PR as an example in an open bug:  https://ceapex.visualstudio.com/Engineering/_workitems/edit/168950
#hold-off until the CLA is signed by the contributor
Thanks!

Unfortunately, this PR isn't mergeable unless the contributor signs the CLA. The PR was opened in December. If the content team finds the update helpful, you might choose to implement it in the private repo. Then, we would close this PR.

@juliakm : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Sorry for the late response. The CLA has been signed.

@Thomas-Leung : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Thomas-Leung : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks @Thomas-Leung - It looks like your commits ended up with the same revisions that were approved by @juliakm and @ramimsft so we'll merge the PR.


go list -m all doesn't work with vendor directory present

Hello, when trying to run the microsoft/sbom-tool  with a Go project I get the following error:
[INFO] Go CLI was found in system and will be used to generate dependency graph. Detection time may be improved by activating fallback strategy (https://github.com/microsoft/component-detection/blob/main/docs/detectors/go.md#fallback-detection-strategy). But, it will introduce noise into the detected components.
[ERROR] Go CLI command "go list -m -json all" failed with error:
 go: can't compute 'all' using the vendor directory
	(Use -mod=mod or -mod=readonly to bypass.)

[ERROR] Go CLI could not get dependency build list at location: /home/sysop/project/go.mod. Fallback go.sum/go.mod parsing will be used.
[INFO] Go CLI was found in system and will be used to generate dependency graph. Detection time may be improved by activating fallback strategy (https://github.com/microsoft/component-detection/blob/main/docs/detectors/go.md#fallback-detection-strategy). But, it will introduce noise into the detected components.
[ERROR] Go CLI command "go list -m -json all" failed with error:
 go: can't compute 'all' using the vendor directory
	(Use -mod=mod or -mod=readonly to bypass.)

[ERROR] Go CLI could not get dependency build list at location: /home/sysop/project/go.sum. Fallback go.sum/go.mod parsing will be used.

I'm using go 1.18.3 on my system, removing the vendor directory before the component-detection seems a bit annoying to me. Would it be possible to add the -mod=readonly in some circumstances?

Is there any reason why we wouldn't want so use -mod=readonly all the time?

I am stuck on this too. Temporary workaround seems to be to use the DisableGoCliScan=true (as explained here) but we should definitely update this command to support -mod=readonly option.

Here is my understanding of the issue so far (feel free to correct me if I am wrong):
The purpose of running go list -m -json all is to get a list of all the dependencies (along with the version of those dependencies, in the json format) and then to report if any of those dependencies have any security vulnerabilities.
However, go doesn't support go list all if you are using the vendoring mode as explained here. Starting from go1.14 mode is by default set to vendor if a vendor directory is found in the go module. That's why everyone is seeing these failures after upgrading to go 1.14 and above.
This means that in order to get a list of all the dependencies we either have to use go list -mod=mod or go list -mod=readonly.  I think always running with go list -mod=readonly -m -json makes sense since -mod=mod has a side effect that it can change the go.mod file.


Added check for invalid hostname

The exception class has to be "fixed"
You may register a serviceId with invalid URI characters (e.g.: '_'), but the URI::getHost() fails when such chars are found.

@dsyer @adriancole @marcingrzejszczak what do you think? If using RestTemplate+ribbon, serviceid's need to be formatted as though they are valid dns hostnames. It's essentially a requirement because an exception is already thrown.

@zanella have you signed the contributor's agreement?

@spencergibb hadn't, did now.

@spencergibb - I've already had one idea how to check if the value passed for Ribbon is a valid hostname (since in Ribbon as you said the value has to be a hostname - in Zookeeper where you can have a nested structure we have the aliases approach).
You can try to resolve the value to an address like here: https://github.com/4finance/micro-infra-spring/blob/54a5a2b5013491511efb908ef575c3bbb11be149/micro-deps/micro-deps-spring-config/src/main/java/com/ofg/infrastructure/discovery/UrlValidator.java#L7 . It should involve the entries in /etc/hosts or sth like that so all the custom entries would work. For insance in /etc/hosts you can have entries that have Polish chars (I've tested that ;) ) and it will still route to a proper ip.

I don't think it should need to resolve to a real domain using /etc/hosts.

It won't access that file. I'm just saying that it will work for valid entries in /etc/hosts

@marcingrzejszczak as far as I can tell in tests, the InetAdress method requires a resolvable hostname.

Agree with validating early as possible,  or at least not too late :p the
prefix original hints we can.
Wrt the URI/URL woes,  this is a normal  problem and why sometimes I avoid
these types. Here's one attempt to get the features without the problems:
https://github.com/square/okhttp/blob/master/okhttp/src/main/java/okhttp3/HttpUrl.java

Merged with a test via 8d259b9d8f3a43d29df48d7b62f09029fdca34e0


GPG signatures for source validation

Hi,
you know what to do :)
I will ask try to get the python progressbar2 into [community] of archlinux. Could you please tell me what is compatible and what not with the old/other version? I want to simply replace the package instead of creating another one.

Also correct:
https://python-utils.readthedocs.io/en/latest/

Done, should be a fully signed release now :)
Let me know if you have any issues


bug, styled-comp, checksum was invalid on page reload

What I do

yarn run dev
load page
reload page

Get error
Warning: React attempted to reuse markup in a container but the checksum was invalid. This generally means that you are using server rendering and the markup generated on the server was not what the client was expecting. React injected new markup to compensate which works but you have lost many of the benefits of server rendering. Instead, figure out why the markup being generated is different on the client or server:
 (client) ="1">
<div class="sc-jzJRlG fzsTbP" data-

related https://github.com/styled-components/babel-plugin-styled-components/issues/52
will look tomorrow

I'm also experiencing this issue - Update here with your finding if you can! :)

@bliitzkrieg can you create pull request with your solution to ran?

@BjornMelgaard I'm not using ran and my code is IP for my company but the fix for me was putting the styled-components stuff in both environments.
"next: "3.0.6",
"styled-components": "2.1.2",
"babel-plugin-styled-components": "1.1.7"
{
  "env": {
    "development": {
      "presets": "next/babel",
      "plugins": [
        ["styled-components", {
          "ssr": true,
          "displayName": true,
          "preprocess": false
        }]
      ]
    },
    "production": {
      "presets": "next/babel",
      "plugins": [
        ["styled-components", {
          "ssr": true,
          "displayName": true,
          "preprocess": false
        }]
      ]
    },
    "test": {
      "presets": [
        ["env", { "modules": "commonjs" }],
        "next/babel"
      ]
    }
  }
}

@bliitzkrieg hm, didnt help, still error on reload, seems like you changed all styled.extend to styled(Comp) and with change in bablerc it helped, no?

https://github.com/styled-components/babel-plugin-styled-components/issues/79

I never used styled.extend in my application

Hey all, It's fixed after some changes on "styled components" plugin and also the integration of new extend functionality of "styled components". I'm closing now. Please inform me if it still continues on your system.


Fix #838: Freeze version of scapy package.

Quick turn fix for travis failures in ncp-sim build due to IP address parsing regression in scapy.
Fixes #838.  Freeze version of scapy package.

Current coverage is 73.71% (diff: 100%)

Merging #839 into master will decrease coverage by 1.34%

@@             master       #839   diff @@
==========================================
  Files           107        111      +4
  Lines         14940      16525   +1585
  Methods        2065       2261    +196
  Messages          0          0
  Branches       1783       1986    +203
==========================================
+ Hits          11213      12181    +968
- Misses         3141       3682    +541
- Partials        586        662     +76

Powered by Codecov. Last update be73d98...ce9b286


Keep HUD under inputAccessoryView

Is there a way to keep HUD under inputAccessoryView?

This is not an issue but a questione. Please read here.

@PGLongo sorry, I can't create a question at SO with pkhud tag:

Ok, create a question without a tag and post also here the link.

@PGLongo https://stackoverflow.com/questions/44840460/ios-keep-pkhud-under-inputaccessoryview

thanks 👍

@PGLongo now keyboard covers HUD :( I've created gist  with pic, have a look please


chore: Update gas limit from 216M->240M

Add another mainnet gas limit increase record, this time from 214M->240M, setting the effective gas target to 60M/block

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


error: gpg failed to sign the data

error: gpg failed to sign the data
fatal: failed to write commit object

Fuggitive is failing to run GPG password prompt.
GPG_TTY=$(tty) nvim . also does not help.
My GPG_TTY environment variable is set.
If i run git commit from another terminal, then it's all good. I can enter the password.

One solution is to increase cache ttl in ~/.gnupg/gpg-agent.conf, but... that kind of sucks from security perspective.
default-cache-ttl 7200
max-cache-ttl 7200

With this you can do initial commit/authentication in separate terminal and gpg secret will be cached for 2 hours. Within those 2 hours you can commit from Fugitive itself.

One solution is to increase cache ttl in ~/.gnupg/gpg-agent.conf, but... that kind of sucks from security perspective.
default-cache-ttl 7200
max-cache-ttl 7200

With this you can do initial commit/authentication in separate terminal and gpg secret will be cached for 2 hours. Within those 2 hours you can commit from Fugitive itself.

Hmm... I installed sudo dnf install pinentry-qt and now i'm getting GUI for pinentry

So... there seems to be one working minimal setup:
sudo dnf install pinentry pinentry-qt

Then append for_window [app_id="pinentry-qt"] floating enable in ~/.config/sway/config.
Reload Sway config.
Add the GPG Agent config
pinentry-program /usr/bin/pinentry

# 2 hours (THIS IS BAD!!! Make it minimal or use default!)
default-cache-ttl 7200
max-cache-ttl 7200

Reload gpg-agent
gpg-connect-agent reloadagent /bye

or
systemctl --user restart gpg-agent.service

You can test it with
echo GETPIN | pinentry-qt

You must see the floating pinentry prompt now.
BUT...
This still does not solve the original issue in a way i would expect it.
Ideally i would like to see the password prompt right there in Vim commit buffer.

https://github.com/tpope/vim-fugitive/issues/1836#issuecomment-918677504


bug: Propagate errors from micromamba-shell

If the micromamba-shell command fails, the exit command is not propagated, leading to silent failures.
Consider if possible switching to bash for -o pipefail support.

Woah, thanks @pavelzw for the instant response!
Do you know offhand if it would be safe to assume that bash is available?
I'm wondering now if exec would be better here; I think that should propagate the error code and also free us from the parent shell.

Ok, I need to do a few quick tests first since I'm wondering what's going on in terms of shell processing and if we would lose that with exec

Ok @pavelzw, I checked and micromamba seems to be already doing the right thing by acting as a shell with -o pipefail enabled, so I believe exec should do the trick! I rebased with the exec solution, so ready for re-review. Thanks!!!


[Bug] Saving reorder results in error

Bug report
What I did
Click reorder items, click save on the reorder page
What I expected to happen
Order saved
What happened
Error: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'name' in 'field list'
What I've already tried to fix it
Created an entirely new project, then a new model + crud, exactly followed the instructions for Reorder at https://backpackforlaravel.com/docs/6.x/crud-operation-reorder. Same error.
I fixed it by editing vendor/backpack/crud/src/app/Library/CrudPanel/Traits/Reorder.php and commenting the following lines (36-37):
//            $item['name'] = '';
//            $item['slug'] = '';

Is it a bug in the latest version of Backpack?
After I run composer update backpack/crud the bug... is it still there?
Yes
Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:
### PHP VERSION:
8.3.9

### PHP EXTENSIONS:
Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, bz2, calendar, ctype, curl, dba, dom, hash, FFI, fileinfo, filter, ftp, gd, gmp, json, iconv, SPL, session, standard, mbstring, igbinary, imagick, imap, intl, ldap, exif, mysqlnd, mysqli, pcntl, PDO, pdo_mysql, pdo_pgsql, pdo_sqlite, pgsql, Phar, posix, random, readline, redis, Reflection, shmop, SimpleXML, soap, sockets, sodium, sysvmsg, sysvsem, sysvshm, tokenizer, xml, xmlreader, xmlwriter, xsl, zip, zstd, Zend OPcache

### LARAVEL VERSION:
<IP_ADDRESS>

### BACKPACK PACKAGE VERSIONS:
backpack/basset: 1.3.5
backpack/crud: 6.7.20
backpack/generators: v4.0.5
backpack/pro: 2.2.8
backpack/settings: 3.1.1
backpack/theme-tabler: 1.2.11

may be related with #5342
Thanks for the report @eleven59 , I will investigate.

Thanks @eleven59 for the report. 🙏  I've just released a fix for the issue.
Let me know if you are still experiencing issues.
Cheers


rec FAIL formats: can't open output file jarvis-record.wav: Permission denied

Hi @alexylem
I get this error. Any idea why I don't have access with the current user ?

Thank you = :)
Consequencies: I can't continue the installation because I'm in a loop where it ask me everytime to select the card and device ;)

I don't know why but I remove and clone again your repository and it works ;)

Yes most probably cloned wrongly with sudo thus Jarvis not able to create jarvis-record.wav


Update readme cloudshell

I’d be fine just going to $HOME. Makes sense, really.

Hey guys,
Thanks @cptera - I read through the new text completely (as preview) and looks good - I think all previous comments are addressed.
I'm left with a bit of uncertainty of what 'done done' means here right now because we want to port a bunch of the text here to the admin guide and then just link back. So there's no point in porting admin guide text to here to just copy it back, for example. Perhaps @msweeney1955 and @cptera read these comments and then we can have a quick discussion on the plan:
‘Deployment Parameters’ section

Can/should we get rid of that and just modify/expand the text in step 6 of “Deploying Cloud Access Manager with Azure Cloud Shell”

‘The CAM solution consists of the following components’

This is outdated – is there a newer version in the admin guide? I think so. In which case we can just ignore this section and not bother updating it to save effort.

Updating the image (as per my email) – is it just emailing a file to Chad? Or I guess with the current plan it just goes in the admin guide in which case we don’t have to email anyone.
EULA – let’s add it!
Known Issues with Deploying the Solution

I think we just ended up removing a few, which is good – Admin guide has other ones I’m sure. Michael – do you have a good feeling for what needs to be here?

Deploying Cloud Access Manager using Microsoft PowerShell

I’d put in the environment requirements:
o	AzureRM 5.0.1 or newer
o	Must be running as administrator
o	Must be running on a modern OS such as Windows 10 or Server 2016 – Windows 7 and Server 2008R2 will not work for generating the gateway certificate

Hey Bill,
I have been working with Charanpreet, and got him to carry out a review on the guide. We are working on ensuring the information in the admin guide is accurate and matches the information in the Readme.md file:

I paired back the ‘Deployment Parameters’ section to only include the parameters that are being dealt with in the cloud shell deployment.

I have the same list of components in the admin guide as is in the readme file.

A different initial image, showing the Cloud Access Manager Services and its role with the different components, is at the beginning of the admin guide.

The EULA is displayed in a note prior to the steps on ‘Deploying Cloud Access Manager through Cloud Shell’.

I have added the issue relating to the time delay with the TLS connection to CAM via Firefox.

I added the environment requirements to the ‘Deploying Cloud Access Manager through Microsoft PowerShell’ section.

I have attached the latest version of the guide in this email,
Michael
From: Bill Dall<EMAIL_ADDRESS>Sent: Thursday, November 23, 2017 10:16 AM
To: teradici/deploy<EMAIL_ADDRESS>Cc: Michael Sweeney<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [teradici/deploy] Update readme cloudshell (#56)
Hey guys,
Thanks @cpterahttps://github.com/cptera - I read through the new text completely (as preview) and looks good - I think all previous comments are addressed.
I'm left with a bit of uncertainty of what 'done done' means here right now because we want to port a bunch of the text here to the admin guide and then just link back. So there's no point in porting admin guide text to here to just copy it back, for example. Perhaps @msweeney1955https://github.com/msweeney1955 and @cpterahttps://github.com/cptera read these comments and then we can have a quick discussion on the plan:
‘Deployment Parameters’ section

Can/should we get rid of that and just modify/expand the text in step 6 of “Deploying Cloud Access Manager with Azure Cloud Shell”

‘The CAM solution consists of the following components’

This is outdated – is there a newer version in the admin guide? I think so. In which case we can just ignore this section and not bother updating it to save effort.

Updating the image (as per my email) – is it just emailing a file to Chad? Or I guess with the current plan it just goes in the admin guide in which case we don’t have to email anyone.
EULA – let’s add it!
Known Issues with Deploying the Solution

I think we just ended up removing a few, which is good – Admin guide has other ones I’m sure. Michael – do you have a good feeling for what needs to be here?

Deploying Cloud Access Manager using Microsoft PowerShell

I’d put in the environment requirements:
o AzureRM 5.0.1 or newer
o Must be running as administrator
o Must be running on a modern OS such as Windows 10 or Server 2016 – Windows 7 and Server 2008R2 will not work for generating the gateway certificate

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/teradici/deploy/pull/56#issuecomment-346678126, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AbGRVk8olZqMFGBjLJ-f9qkPE6WfT8IJks5s5bZZgaJpZM4QmcbR.


Does not match 465 new emoji

The emoji-cheat-sheet version loaded in the current rumoji does not have 465 emoji defined in the Unicode standard.
The real issue is that it doesn't seem that there's a shorthand defined yet for these emoji, so if rumoji were to support them it would need to make them up. What to do? I don't know.

¯_(ツ)_/¯
Closing this for now. Rumoji is all about translations between the cheat-sheet markup and the unicode characters. Both need to be supported for this to make any sense at all, unfortunately.


Issue with ttkbootstrap.Checkbutton after Python 3.12 install

Desktop (please complete the following information):
ttkbootstrap~=1.10.1
OS: Windows 11 Home 22H2
Describe the bug
When running code in which a ttkbootstrap.Checkbutton is implemented, my IDE (PyCharm 20230.2.3 Community Edition) seems to terminate the code's execution with this output: Process finished with exit code -1073741819 (0xC0000005). Nowhere else does this appear when running the code apart from when a  ttkbootstrap.Checkbutton is implemented in the code such as this:
        checkbutton: ttkbootstrap.Checkbutton = ttkbootstrap.Checkbutton(
            bootstyle=self._bootstyle,
            master=checkbutton_frame,
            onvalue=True,
            offvalue=False,
            variable=self._boolean_var,
        )
        checkbutton.pack(
            padx=10,
            pady=5,
            side=LEFT,
        )

Commenting out these lines will result in the code running without any issue.
To Reproduce
Update your Python install to 3.12 and use PyCharm IDE Version 2023.2.3 and implement a ttkbootstrap.Checkbutton in your code such as this:
        checkbutton: ttkbootstrap.Checkbutton = ttkbootstrap.Checkbutton(
            bootstyle=self._bootstyle,
            master=checkbutton_frame,
            onvalue=True,
            offvalue=False,
            variable=self._boolean_var,
        )
        checkbutton.pack(
            padx=10,
            pady=5,
            side=LEFT,
        )

Run the code and observe the output: Process finished with exit code -1073741819 (0xC0000005)
Expected behavior
No response
Screenshots
No response
Additional context
No response

Something interesting I discovered:
When using the same setup, but changing the bootstyle to "round-toggle" seems to have the effect of the application not crashing:
checkbutton: ttkbootstrap.Checkbutton = ttkbootstrap.Checkbutton(
bootstyle=f"{self._bootstyle}-round-toggle",
master=checkbutton_frame,
onvalue=True,
offvalue=False,
variable=self._boolean_var,
)
checkbutton.pack(
padx=10,
pady=5,
side=LEFT,
)

Thank you for your reply. I have noticed, that there must have been an update, maybe to ttkbootstrap or somewhere else, as I myself am no longer able to reproduce the issue. So I think it might be best to close the issue. As for the self._bootstyle variable it is a str of "primary" used in the constructor of the class of the ui I was building.


Add some basic docs on how to access the API with Azure Stack

There doesn't appear to b anything here and this took us a while to fathom. This should be useful for others new to Microsoft and Azure Stack

@mattbriggs Could you address what needs to be done here?

#sign-off

@mattbriggs: I'm sorry - only the author of this article, @cblackuk and charliejllewellyn, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@charliejllewellyn can you sign-off on this doc? I can review and update once it is has been incorporated into the TOC. Thanks again for your contribution! Cheers, Matt

@PRMerger8  @mattbriggs Hi All, what do I need to do to Sign it off? :-) I am happy for it to be published if that is what is being asked here :-)

@cblackuk I tried to sign off for you above. :) All you need to do is type: #sign-off
Hopefully, that will go through. The editors may have some feedback. Once it is incorporated, I will probably have some things I will want to update. We are just beginning to work out how we want to tell the Azure Stack REST story (as you noticed!). Thanks, Matt

@mattbriggs: I'm sorry - only the author of this article, @cblackuk and charliejllewellyn, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#sign-off

@cblackuk: I'm sorry - only the author of this article, @cblackuk and charliejllewellyn, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@cblackuk: Oh no. It looks our robots are out of control. I'll contact their handlers! and get back to you. Cheers, Matt

@matt-gibbs Does not look like it went through ;-( I have a lot more docs internally that I will be willing to push eventually upstream to you guys, it is just having the time to do so :-) I am always up for sharing and making AzureStack successful and better for everyone.

@cblackuk We should talk! You can send me an email at mabrigg (at) microsoft (dot) com.

I pulled the topic and added it a PR and submitted. Please close this PR. #please-close


Linux/Windows - Provide direct links to download the agent from non-GUI machines

Please provide direct links for Linux/Windows Agents on the Readme/Documentation. Specifically on the Download/Configure Agent Section
https://www.visualstudio.com/en-us/docs/build/actions/agents/v2-linux.
https://github.com/Microsoft/vsts-agent/blob/master/README.md
https://www.visualstudio.com/en-us/docs/build/actions/agents/v2-windows
Use Cases:
Operating Systems without a Graphical User Interface are unable to see the "Download Agent link"
People shouldnt have to use Chrome/IE F12 Developer tools to track down the binary file for the agents

Instead of having it in the docs (which can tend to go stale), we built it right into the product.
There's a copy to clip board url right in the product which gives the right url.

I don't understand the point about no GUI - the documentation is web based so it's a GUI.  Chrome/IE F12 is also a GUI.
What's the scenario here?  Do you have a linux or windows cli vis ssh and need to get the agent?

That product also advertises the CLI way to get that agent for each platform:

Yes when using a CLI you need the actual path.
When Copying to clipboard it brings you to a Microsoft Download Forwarder not the actual github download location.
After I have the file, there is no problem installing it.

This is what is copied to the clipboard https://go.microsoft.com/fwlink/?linkid=851127

Yes, and that 302s correctly to the actual download.  Most cli download tools should follow redirects. It allows us to (1) patch the version on prem release uses and (2) change where we get binaries (it's github and there's plans to change that but keep release metadata @ github)
You can also use the convenience url: https://github.com/Microsoft/vsts-agent/releases/latest
It goes to latest (119.1) which is fine for 2017 on-prem and beyond.  Server keeps back compat.  The one server points to for on prem release is just the one that we tested with at the time of the release (and if there's a critical fix we can update the fwlink).

The filename is saved as https://go.microsoft.com/fwlink/?linkid=851127 instead of vsts-agent-ubuntu.14.04-x64-2.119.1.tar.gz. Don't you think that is a bit confusing for people?
wget https://go.microsoft.com/fwlink/?linkid=851127
--2017-07-09 18:01:39--  https://go.microsoft.com/fwlink/?linkid=851127
Connecting to XXX.XXX.XXX.XXX... connected.
Proxy request sent, awaiting response... 302 Moved Temporarily
Location: https://github.com/Microsoft/vsts-agent/releases/download/v2.117.2/vsts-agent-ubuntu.14.04-x64-2.117.2.tar.gz [following]
--2017-07-09 18:01:39--  https://github.com/Microsoft/vsts-agent/releases/download/v2.117.2/vsts-agent-ubuntu.14.04-x64-2.117.2.tar.gz
Connecting to XXX.XXX.XXX.XXX... connected.
Proxy request sent, awaiting response... 302 Found
Location: https://github-production-release-asset-2e65be.s3.amazonaws.com/53052789/5066287c-5cd7-11e7-9783-a7b30ca83abc?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20170709%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20170709T220140Z&X-Amz-Expires=300&X-Amz-Signature=ec959ff9cb39a01624124428c7972171f4f63b11bf17d3e346d84ac59564bfff&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B filename%3Dvsts-agent-ubuntu.14.04-x64-2.117.2.tar.gz&response-content-type=application%2Foctet-stream [following]
--2017-07-09 18:01:40--  https://github-production-release-asset-2e65be.s3.amazonaws.com/53052789/5066287c-5cd7-11e7-9783-a7b30ca83abc?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20170709%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20170709T220140Z&X-Amz-Expires=300&X-Amz-Signature=ec959ff9cb39a01624124428c7972171f4f63b11bf17d3e346d84ac59564bfff&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B filename%3Dvsts-agent-ubuntu.14.04-x64-2.117.2.tar.gz&response-content-type=application%2Foctet-stream
Connecting to xxx.xxx.xxx.xxx... connected.
Proxy request sent, awaiting response... 200 OK
Length: 72790638 (69M) [application/octet-stream]
Saving to: ‘index.html?linkid=851127’
100%[===================================================================================================================================================================================================>] 72,790,638  1.79MB/s   in 36s
2017-07-09 18:02:17 (1.91 MB/s) - ‘index.html?linkid=851127’ saved [72790638/72790638]

No, it's not confusing at all.  That's the way http works.  It's pretty clear from the output exactly what's going on - it shows it's getting redirected.
This is actually a requirement.  The opposite would be a problem.  If folks write automation / scripts to download the agent, then their scripts have an url baked into it.  If we release a critical update, security update, or move storage then their scripts should still work and not break.
It's also the way MS download center works - the url is a moniker and it redirects to the actually download storage location.

I do not agree, The actual way to effectly distribute packages to Linux systems is via Package Management.
DotNot Core is doing this appropriately
https://www.microsoft.com/net/core#linuxubuntu


More details on how to set the algorithm's hyperparameters in the configuration file ?

Hello,
First of all, thank you for your work on this very useful library.
I would like to have more details about the hyperparameters of the algorithm (especially of the Hypothesis model) and how I need to set them in the config file regarding my specific data. I work on cell tracking, and typically have several hundreds of images and around a hundred cells within each image. For now, I've only used the algorithm with the default json config file given in the tutorial and this works fine as long as the number of images remains fairly low (~100). When I go a bit beyond (~300 images), the "Optimizing" step never ends. This is must be due to a poor optimizer configuration, as underlined in Issue #13.
I understand that I should change the Hypothesis Model hyperparameters in the config file, but the problem is that I couldn't find any detailed information about what is each hyperparameter useful for,  and how it should be regarding the data (not enough details in the wiki or in the referenced papers). Did I miss something, or could it be possible to have more information regarding this ?
Thank you!

Hi @hugovaysset - thanks - I hope it's proving useful!
We've been meaning to update the documentation for a while. There's a new CONFIGURATION.md in the root directory with some details now. Can you let me know which parameters in particular you're having trouble with?

Hi @quantumjot, thanks for the quick answer!
Actually, my questions are very broad and basic about the algorithm that is used in btrack.
I solved the computation time issue by just removing the optimisation step. What is the point of this step ? In other words, what do I loose when I don't do it ? I suppose that this step can substantially increase the quality of the tracking results, so I would like to better understand it. In issue #13, you said "you probably need to change some parameters in the config to better to describe what you are trying to track and what you care about.". Could you please tell me more about which parameters are the most important ones ? Are they more in the Motion model or in the Hypothesis model? I suppose that the number and the type of hypotheses that we test must be important, should I tune them to save computational time?  Is the precise value of each numerical parameter in the Hypothesis model (lambda_time, lambda_dist, eta, etc.) really important?
Additionally, I would also be interested in knowing what could be done with the Object model (that is empty in the config file given in the documentation). Is it possible to describe the cells that we want to track, in order to integrate not only the position but also for example the surface of the cells to improve the quality of the tracking results ?
Thanks again.


Break JavaScript syntax color

VSCode Version: 1.16.1
OS Version: Ubuntu 16.04 LTS

Steps to Reproduce:

Select sytax JS
Typewrite correct code:

A.B = async(C, D, {
    E = 'F',
} = {}) => {
    // Comment
    if (!Func.J(C))
        throw new Error('Field C ...');
    if (!D || !OWNERS.includes(D))
        throw new Error('Field D ...');
};

Syntax coloring not work :(

Reproduces without extensions: Yes

Thanks. Should already be fixed in insiders builds:


SCORED | 5.4.4 Ensure default user umask is 027 or more restrictive

Edit the /etc/bashrc and /etc/profile files (and the appropriate files for any other shell supported on your system) and add or edit any umask parameters as follows:
umask 027

Besides Ansible Tower and python pip packages umask 027 also breaks:

OpenShift installation
npm packages
any deployments that are web related and require public permissions

We agree that umask 027 or even 077 can increase security in the following conditions:

In a production environment that everything has been already configured and deployed and this should not affect the deployment scripts
In a shared user environment that requires user interaction through shell scripts and not in an Ansible automated environment
As the subject says, this should apply to default user but it should not apply to root

It should not be used in:

Dev environments or integration environments (pip, npm, web)
Before installation or automation scripts run (ansible, chef, puppet)

In my opinion, this particular CIS rule should be in a hardening playbook and should be applied at the end, after everything has been installed and deployed on a server. Every deployment script should be aware of that and be able to maintain permissions.

Yes I agree that the restrictive umask setting is problematic in many respects. One simple workaround is setting umask prior to running installs with package managers like pip, npm, etc. Yes it trips up people that are not familiar/aware of this setting but that is typically the case with hardening a system.
We can look at making this task run at the end of the role though. I'm not opposed to that.

Couldn’t the Ansible Tower installer do a better job with regards to these permissions? The issue has been around for years now.

@bbaassssiiee it's not just the Ansible Tower, it's a lot of applications that will fail.
Making this task run at the end of the rule is a good idea. How about also adding some tags like "--post-app-installation" and add it to the documentation.
This would make things a lot easier because we will be able to run the hardening that are application-installer-safe by skipping this tag, then run the installers like Ansible Tower and then run again the ones that include the tag. What do you think?

Hello,
I wanted to reach out and let you know that this issue is being closed. We have re-worked the role and want to start with a fresh issues list with this latest version. There was a post in the Ansible-Lockdown google group (https://groups.google.com/g/ansible-lockdown) with the details of the changes that are coming. Please checkout the thread titled RHEL 7 CIS and STIG Changes for all of the details, I also have the message pasted at below.
Please as you use the latest version and open issue tickets as you find them, it is the best way for us to improve the role for everyone. Thank you for being part of the community and providing awareness of problems or advice on improvement. Reporting is a huge part of improving this project.

Hello,
Thank you to everyone in the Ansible-Lockdown community who has contributed to RHEL7 STIG/CIS. Our team at MindPoint Group has been working with the entirety of the Ansible-Lockdown project, and we have some significant updates for both RHEL 7 STIG and CIS. With these updates, some larger changes have been made. I have these changes/updates outlined below.
Testing:

CI/CD - We have implemented some automated testing pipelines to test pull requests into the devel and main branches. With the current workflow, the community will PR into the devel branch (never the main branch) for review by the administrators. When your PR is created, the first check will remain the DCO check. The second check is a functional testing pipeline that will automatically perform a functional test of the branch the PR is initiated from. Once both tests pass, someone from the Administrator Team will review the changes and merge them into the devel branch. From there, an additional review is completed before the devel branch is merged into the main branch. Only the Admin Team will perform PRs/merges into the main branch. There is also an automated pipeline for PRs from devel to main. Please do not edit the .github/workflows files since those are used as part of the pipeline.
Compliance Checking – MindPoint Group has been working to create our own compliance audit scan tool. The tool uses a goss framework executable to run custom checks that we have created. The goal is to provide a more thorough check for control compliance and decrease the number of false positives/negatives. For example, it will check the configuration file related to the control and as well as checking if that configuration is active. With a smarter scan, we can hopefully identify attempts to trick scanners as well (for example stacking a parameter in a config file where the first instance is enabled and second disabled. Most audit tools search for the first instance but the application might look for the last instance of the parameter, thus making the scanning tool think it's enabled). In testing, we have found that our audit scan runs significantly faster than other audit tools, reducing audit times. Our audit tool and profiles will have their own repositories in the Ansible-Lockdown org, but within the remediation role there will be an integrated way to incorporate the audit. Keep an eye out for the audit tools as they are released. We plan on developing a goss audit profile for each current remediation role. Going forward, we plan to release a remediation role and goss audit tool profile simultaneously.
Role Updates:
RHEL 7 STIG/CIS – We have re-written much of the RHEL 7 STIG and CIS roles to increase clarity and readability and address some functionality items. We performed these updates while creating our goss testing framework for each of these roles. We plan on pushing our update to the devel and main branches. We will move the current devel and master branches to a devel_stable_ and master_stable_ branch in the respective repositories. Accordingly, community members who rely on the current version can still use that version going forward; this process will not remove what is currently there. The latest versions of the roles have also been updated to comply with the latest benchmarks.
Role Architecture – All roles will change with regard to the structure in the tasks folder. Taking CIS as an example, there will be a folder per section and yaml files for each sub-section. For example control 1.2.1 in CIS will be located in RHEL7-CIS/tasks/section_1/cis_1.2.x.yml. The cis_1.2.x.yml file will contain all controls related to section 1.2.x. This will hopefully make updates to roles a bit easier with less risk. This matches the architecture of our audit tool, creating consistency across remediation and audit platforms. The end goal is to repeat this architecture (the best we can) on STIG roles, but we are starting with CIS.
Existing PRs and Issues – With all of these changes comes the task of cleaning up existing PR’s and issues. Our plan is to close all of the existing PR’s and issues because of the re-work. Our team is growing and should be able to stay on top of the new issues and PRs as they come in.
Again, I would like to thank the community for your involvement in this project. The input and work from the community has contributed significantly to the success of this project. Please keep an eye out for these changes, which will be rolling out in the coming weeks.


Add GLM package

Fixes #281

Thanks, please set target branch to develop (see wiki).

Argh, and I'm in the process of adding other packages on master... when I finish the new packages I'll merge the changes into develop and send a new pull request with several new packages, if that's ok.
That wiki page is not visible enough. You should have a CONTRIBUTING.md file at the root as explained here: https://help.github.com/articles/setting-guidelines-for-repository-contributors/
Honestly though I would just drop the "develop" branch... it's an unnecessary complexity. The master branch should be the only "eternal" branch, while all development is done in temporary branches/forks and merged back into master as often as possible to minimize integration problems.  This will make things much simpler for you and all contributors...

You should have a CONTRIBUTING.md file at the root as explained here: https://help.github.com/articles/setting-guidelines-for-repository-contributors/

Oh... I have this file before but removed it. Returning it back: https://github.com/ruslo/hunter/commit/f0a8d0c70e02f3671067a391cdd34d0151e6db73

Pull requests and automated tests already give you enough protection on master

No. Even if 2 pull requests doesn't break build the merge commit of them may. Also I do experiments in develop sometimes.

As you wish... but experiments are better done in temporary branches. The chance of having two simultaneous non-conflicting pull requests break each other is low, especially if you review each pull request well (something you should do anyway). Meanwhile having an eternal "develop" branch requires more work and will probably bring you (and/or contributors) problems every so often. Just mark my words ;)

but experiments are better done in temporary branches

Okay, I agree

The chance of having two simultaneous non-conflicting pull requests break each other is low, especially if you review each pull request well (something you should do anyway).

I'm using this flow in all my project, it may be true for Hunter but not for others. I simply don't like an idea of pushing untested code to master :)

Meanwhile having an eternal "develop" branch requires more work and will probably bring you (and/or contributors) problems every so often.

What work? The only problem I'm experiencing is that users who contribute first time do pick master branch as a target often. Usually it's users fault since I've mention it in CONTRIBUTING (in this particular case it's my fault).
Anyway I will think about it. May be will change this in future.

It's not untested though, you seem to have fairly good automated tests. If you think they are not enough, just make them better. The more automated things are, the more hunter will evolve. Right now you have this manual step of testing things on "develop" and manually pushing to "master". This won't scale if you start to receive many pull requests. It's better for scale to trust your tests, merge to master as fast as possible and then fix any (rare) problem that may happen. You will get more users and more contributors, because people want to see their new packages and updates merged as soon as possible for their projects.

It's not untested though

It is untested. Assume we have state A in develop and have two pull requests P1 and P2. Automated testing do test A + P1 and A + P2. When I do merge them I have state A + M where M is the merge commit of P1 and P2. M is new untested commit. In case of develop -> master flow we test P1, P2 and do test M. Then do merge M to master: git merge --ff-only. As you said it's quite unlikely case when problems may happens but it may.

Right now you have this manual step of testing things on "develop"

What step is manual?

manually pushing to "master"

It's true. I don't know how to fix it easily since we need to manage two services Travis CI and AppVeyor. So it should be some external service that check last state of branch develop and do merge if everything OK.

This won't scale if you start to receive many pull requests

Why? What's the difference?

hehehe I know, my point is that you're worrying about something very unlikely, and "perfection is the enemy of progress". What's the worst that can happen if you merge a pull-request into master and something breaks? Someone will find the problem and fix it. The benefits of accepting contributions faster (including fixes) outweigh the benefit of "never breaking the master" (something you can't guarantee anyway).
BTW you can re-run the tests in a Pull Request after merging another PR. What doesn't scale is manually testing the "develop" branch and manually merging into "master". If you automate the merges it will scale, but personally I don't think the extra complexity is justified. If someone updates hunter and suddenly cannot build their projects anymore, they can just rollback to an earlier version :-)

As I said I'm using this flow in several projects so I'll be talking in general terms now.

Someone will find the problem and fix it

Not exactly. Someone will clone my repo with default branch set to master, probably integrate it into some code and run compilation, then something will fail. Then user need to figure out that it's my project fault, report a bug... Or some user want to try my project, clone default master run and it fails, he decide that project is crap and move to another one :) Anyway fixing a bug may not be a trivial task so you have to revert. And so on. That's why having "blessed" repository is a good idea, it "just works".

Removing barriers for contribution will also bring more contributors, obviously. The simpler things are, the better

What barriers? Set target branch to develop is a barrier? Developer open pull request - the rest is mine responsibility.

BTW you can re-run the tests in a Pull Request after merging another PR

How? I'm not awared of it.

What doesn't scale is manually testing the "develop" branch

Why manually? What does it mean?

If you update hunter and suddenly cannot build your projects anymore, you can just rollback to an earlier version :-)

See above.

Not exactly. Someone will clone my repo with default branch set to master, probably integrate it into some code and run compilation, then something will fail. Then user need to figure out that it's my project fault, report a bug... Or some user want to try my project, clone default master run and it fails, he decide that project is crap and move to another one :) Anyway fixing a bug may not be a trivial task so you have to revert. And so on. That's why having "blessed" repository is a good idea, it "just works".

If you have enough contributors that won't happen. Contributors will notice the problems and fix them. I would focus on attracting contributors and wouldn't be afraid of the scenario you described.

What barriers? Set target branch to develop is a barrier? Developer open pull request - the rest is mine responsibility.

It's an extra complexity that you have to explain to every new contributor, and it gives the impression that their contributions won't be merged into master so soon. Contributors will assume that the develop branch may be unstable and you may take some time to merge their PRs into master.
Ignore what I said about re-running the tests of a PR. Even if you restart the tests, they won't include the new code merged upstream. The only solution is to ask the author of the other PRs to pull changes from upstream, and then that will re-run the tests. But I bet that would seldom be necessary in practice.

Contributors will notice the problems and fix them, with very high probability (proportional to the number of current users/contributors you have)

May be I don't need testing at all in this case? Why do writing unit-tests, setting up CI environment and so on if you have "a lot of" users who will fix all the problems...

I would focus on attracting contributors and wouldn't be afraid of the scenario you described

Why I can't do the both? :)

It's an extra complexity that you have to explain to every new contributor

Every project have some contributing rules. If developer can't handle "set target branch to develop" there is a high probability that he will violate all other rules.

and it gives the impression that their contributions won't be merged into master so soon. Contributors will assume that the develop branch may be unstable and you may take some time to merge their PRs into master

Why do they will assume so. It's pretty clear:. "...against the branch develop. After a successful build this branch will be merged to master..." as wiki page states.
To summarize: I will think about changing delelop -> master flow in future. At least for the Hunter it make a little sense. But I don't see a big deal about fixing it now. I think it's not a significant barrier.


export externally useful test code

there is some test funcitonality that would be of use to clients, such as matchers, that I have annoyingly replicated elsewhere.

wrong repo!


EIP merged but unavailable at eips.ethereum.org

PR - 4393 is merged to create a new EIP in Draft.

But I am unable to find the EIP

Can someone please look into the issue? Thanks!

Known issue, @mryalamanchi said they were going to fix it in https://github.com/ethereum/EIPs/issues/4614#issue-1090395253

Known issue, @mryalamanchi said they were going to fix it in https://github.com/ethereum/EIPs/issues/4614#issue-1090395253

I am on it!

I am on it!

Done!
PR created: https://github.com/ethereum/EIPs/pull/4619

Done!
PR created: https://github.com/ethereum/EIPs/pull/4619