Improper status of air purifier (thinq1 server) on homebrige

Describe The Bug:
After running home bridge server for few hrs, it starts showing improper status of air purifier (thinq1 server) on HomeKit and home bridge.

Even though the air purifier is running on, but the status shows it stays turned off (But it shows only the status of light from air purifier properly.)

However, After running the "LG thing app" through my iPhone, then the status starts to shows proper info (Like all status back to normal and working properly on home bridge.)

But few hrs later, the issue showing improper info of status pops up again.

Expected behavior:
With considering that the light from air purifier always shows right status on home bridge, Please check whether to fix this issue...
Thanks for your support.

My log
[6/18/2022, 12:36:15 PM] [LGThinQ] [공기청정기 상준] Received snapshot:  {"airState.opMode":13,"airState.operation":true,"airState.tempState.current":40,"airState.tempState.target":0,"airState.windStrength":8,"airState.wDir.vStep":0,"airState.wDir.hStep":0,"airState.circulate.rotate":1,"airState.lightingState.signal":1,"airState.quality.overall":1,"airState.quality.sensorMon":1,"airState.quality.PM1":8,"airState.quality.PM2":8,"airState.quality.PM10":9,"airState.wMode.jet":0,"online":true,"raw":{"Operation":"1","OpMode":"13","WindStrength":"8","TempUnit":"NS","TempCur":"40","TempCfg":"0","GroupType":"12","SleepTime":"0","OnTime":"0","OffTime":"0","RacAddFunc":"NS","ExtraOp":"0","DiagCode":"00","TimeBsOn":"0","TimeBsOff":"0","AirClean":"0","AutoDry":"0","PowerSave":"0","WDirVStep":"0","WDirHStep":"0","TempLimitMax":"0","TempLimitMin":"0","DuctZoneType":"0","ZoneControl":"0","DRED":"0","SensorPM1":"8","SensorPM2":"8","SensorPM10":"9","AirPolution":"1","HumidityCfg":"0","WaterTempCoolMin":"NS","WaterTempCoolMax":"NS","WaterTempHeatMin":"NS","WaterTempHeatMax":"NS","HotWaterTempMin":"NS","HotWaterTempMax":"NS","SensorHumidity":"30","TotalAirPolution":"1","SensorMon":"1","CleanDry":"0","ProductStatus":"0","AirMonitoring":"0","Humidification":"0","AirFast":"0","AirRemoval":"1","AirUVDisinfection":"0","WatertankLight":"0","SignalLighting":"1","WDirUpDown":"0","WDirLeftRight":"0","WSwirl":"0","Jet":"0","LowHeating":"0","CirculateStrength":"6","CirculateDir":"1","AntiBugs":"0","IceValley":"0","Humsave":"0","WaterTempCur":"0","HotWaterTempCur":"0","HotWaterTempCfg":"0","HotWaterMode":"0","HotWater":"0","AWHPTempCfgSwitch":"0","AirTempCoolMin":"NS","AirTempCoolMax":"NS","AirTempHeatMin":"NS","AirTempHeatMax":"NS","WaterInTempCur":"0","AWHPWATempControlSta":"0","DisplayControl":"0","SmartCare":"0","TwoSetCoolTemp":"0","TwoSetHeatTemp":"0","TwoSetCoolUSL":"0","TwoSetCoolLSL":"0","TwoSetHeatUSL":"0","TwoSetHeatLSL":"0","TwoSetACOState":"0","TwoSetModeDeadband":"0","TwoSetState":"0"}}
[6/18/2022, 12:36:15 PM] [LGThinQ] [request] post https://kic.lgthinq.com:46030/api/rti/rtiResult
[6/18/2022, 12:36:15 PM] [LGThinQ] [공기청정기 거실] Received snapshot:  {"airState.opMode":13,"airState.operation":true,"airState.tempState.current":40,"airState.tempState.target":0,"airState.windStrength":8,"airState.wDir.vStep":0,"airState.wDir.hStep":0,"airState.circulate.rotate":1,"airState.lightingState.signal":1,"airState.quality.overall":1,"airState.quality.sensorMon":1,"airState.quality.PM1":8,"airState.quality.PM2":8,"airState.quality.PM10":11,"airState.wMode.jet":0,"online":true,"raw":{"Operation":"1","OpMode":"13","WindStrength":"8","TempUnit":"NS","TempCur":"40","TempCfg":"0","GroupType":"12","SleepTime":"0","OnTime":"0","OffTime":"0","RacAddFunc":"NS","ExtraOp":"0","DiagCode":"00","TimeBsOn":"0","TimeBsOff":"0","AirClean":"0","AutoDry":"0","PowerSave":"0","WDirVStep":"0","WDirHStep":"0","TempLimitMax":"0","TempLimitMin":"0","DuctZoneType":"0","ZoneControl":"0","DRED":"0","SensorPM1":"8","SensorPM2":"8","SensorPM10":"11","AirPolution":"1","HumidityCfg":"0","SensorHumidity":"30","TotalAirPolution":"1","SensorMon":"1","CleanDry":"0","ProductStatus":"0","AirMonitoring":"0","Humidification":"0","AirFast":"0","AirRemoval":"1","AirUVDisinfection":"0","MoodLuminosity":"0","SignalLighting":"1","WDirUpDown":"0","WDirLeftRight":"0","WSwirl":"0","Jet":"0","LowHeating":"0","CirculateStrength":"2","CirculateDir":"1","AntiBugs":"0"}}
[6/18/2022, 12:36:15 PM] [LGThinQ] [request] post https://kic.lgthinq.com:46030/api/rti/rtiResult
[6/18/2022, 12:36:15 PM] [LGThinQ] [공기청정기 누나] Received snapshot:  {"airState.opMode":13,"airState.operation":false,"airState.tempState.current":40,"airState.tempState.target":0,"airState.windStrength":8,"airState.wDir.vStep":0,"airState.wDir.hStep":0,"airState.circulate.rotate":0,"airState.lightingState.signal":0,"airState.quality.overall":1,"airState.quality.sensorMon":1,"airState.quality.PM1":8,"airState.quality.PM2":8,"airState.quality.PM10":10,"airState.wMode.jet":0,"online":true,"raw":{"Operation":"0","OpMode":"13","WindStrength":"8","TempUnit":"NS","TempCur":"40","TempCfg":"0","GroupType":"12","SleepTime":"0","OnTime":"0","OffTime":"0","RacAddFunc":"NS","ExtraOp":"0","DiagCode":"00","TimeBsOn":"0","TimeBsOff":"0","AirClean":"0","AutoDry":"0","PowerSave":"0","WDirVStep":"0","WDirHStep":"0","TempLimitMax":"0","TempLimitMin":"0","DuctZoneType":"0","ZoneControl":"0","DRED":"0","SensorPM1":"8","SensorPM2":"8","SensorPM10":"10","AirPolution":"1","HumidityCfg":"0","WaterTempCoolMin":"NS","WaterTempCoolMax":"NS","WaterTempHeatMin":"NS","WaterTempHeatMax":"NS","HotWaterTempMin":"NS","HotWaterTempMax":"NS","SensorHumidity":"30","TotalAirPolution":"1","SensorMon":"1","CleanDry":"0","ProductStatus":"0","AirMonitoring":"0","Humidification":"0","AirFast":"0","AirRemoval":"0","AirUVDisinfection":"0","WatertankLight":"0","SignalLighting":"0","WDirUpDown":"0","WDirLeftRight":"0","WSwirl":"0","Jet":"0","LowHeating":"0","CirculateStrength":"8","CirculateDir":"0","AntiBugs":"0","IceValley":"0","Humsave":"0","WaterTempCur":"0","HotWaterTempCur":"0","HotWaterTempCfg":"0","HotWaterMode":"0","HotWater":"0","AWHPTempCfgSwitch":"0","AirTempCoolMin":"NS","AirTempCoolMax":"NS","AirTempHeatMin":"NS","AirTempHeatMax":"NS","WaterInTempCur":"0","AWHPWATempControlSta":"0","DisplayControl":"0","SmartCare":"0","TwoSetCoolTemp":"0","TwoSetHeatTemp":"0","TwoSetCoolUSL":"0","TwoSetCoolLSL":"0","TwoSetHeatUSL":"0","TwoSetHeatLSL":"0","TwoSetACOState":"0","TwoSetModeDeadband":"0","TwoSetState":"0"}}

may be you got same issue on #159 , please try install test version v1.2.17-test.1 and see if it's worked

may be you got same issue on #159 , please try install test version v1.2.17-test.1 and see if it's worked

Hi sir. I'm currently using v1.2.17-test.1. But I have same issue on it. Also, this issue has been found from 1.2.13 i think

may be you got same issue on #159 , please try install test version v1.2.17-test.1 and see if it's worked

Hi sir. I'm currently using v1.2.17-test.1. But I have same issue on it. Also, this issue has been found from 1.2.13 i think

unfortunately I don't have any thinq1 device to debug it
please turn on homebridge debug mode, wait until that issue happened and see if any debug message appear

may be you got same issue on #159 , please try install test version v1.2.17-test.1 and see if it's worked

Hi sir. I'm currently using v1.2.17-test.1. But I have same issue on it. Also, this issue has been found from 1.2.13 i think

unfortunately I don't have any thinq1 device to debug it please turn on homebridge debug mode, wait until that issue happened and see if any debug message appear

As shown on pic, the status shows only for light properly, but not the air purifier.
Also, I've attached two version of my log.

First log got collected before running LG THINQ APP on iPhone
Second one got collected after running LG THINQ APP on iPhon

MY LOG before running "LG THINQ APP"
(Except for this error log, haven't found any other log related to air purifier.)
[6/18/2022, 5:00:48 PM] [LGThinQ] [request] post https://kic.lgthinq.com:46030/api/rti/rtiControl
[6/18/2022, 5:00:50 PM] [homebridge-lg-thinq] This plugin threw an error from the characteristic 'On': Unhandled error thrown inside read handler for characteristic: Cannot read properties of null (reading 'AirFast'). See https://homebridge.io/w/JtMGR for more info.
[6/18/2022, 5:00:50 PM] [homebridge-lg-thinq] TypeError: Cannot read properties of null (reading 'AirFast')
at On.getHandler (/usr/local/lib/node_modules/homebridge-lg-thinq/src/v1/devices/AirPurifier.ts:72:60)
at On. (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:1528:32)
at step (/usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:144:27)
at Object.next (/usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:125:57)
at /usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:118:75
at new Promise ()
at __awaiter (/usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:114:16)
at On.Characteristic.handleGetRequest (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/dist/lib/Characteristic.js:689:38)
at Bridge. (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:1569:27)
at step (/usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:144:27)
[6/18/2022, 5:00:50 PM] [homebridge-lg-thinq] This plugin threw an error from the characteristic 'On': Unhandled error thrown inside read handler for characteristic: Cannot read properties of null (reading 'AirFast'). See https://homebridge.io/w/JtMGR for more info.
[6/18/2022, 5:00:50 PM] [homebridge-lg-thinq] TypeError: Cannot read properties of null (reading 'AirFast')
at On.getHandler (/usr/local/lib/node_modules/homebridge-lg-thinq/src/v1/devices/AirPurifier.ts:72:60)
at On. (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:1528:32)
at step (/usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:144:27)
at Object.next (/usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:125:57)
at /usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:118:75
at new Promise ()
at __awaiter (/usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:114:16)
at On.Characteristic.handleGetRequest (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/dist/lib/Characteristic.js:689:38)
at Bridge. (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:1569:27)
at step (/usr/local/lib/node_modules/homebridge/node_modules/tslib/tslib.js:144:27)
**LOG AFTER RUNNING the "LG THINQ APP"
[6/18/2022, 5:04:15 PM] [LGThinQ] [request] post https://kic.lgthinq.com:46030/api/rti/rtiResult
[6/18/2022, 5:04:15 PM] [LGThinQ] [공기청정기 첫번째] Received snapshot:  {"airState.opMode":13,"airState.operation":true,"airState.tempState.current":40,"airState.tempState.target":0,"airState.windStrength":13,"airState.wDir.vStep":0,"airState.wDir.hStep":0,"airState.circulate.rotate":1,"airState.lightingState.signal":1,"airState.quality.overall":1,"airState.quality.sensorMon":1,"airState.quality.PM1":8,"airState.quality.PM2":8,"airState.quality.PM10":10,"airState.wMode.jet":0,"online":true,"raw":{"Operation":"1","OpMode":"13","WindStrength":"13","TempUnit":"NS","TempCur":"40","TempCfg":"0","GroupType":"12","SleepTime":"0","OnTime":"0","OffTime":"0","RacAddFunc":"NS","ExtraOp":"0","DiagCode":"00","TimeBsOn":"0","TimeBsOff":"0","AirClean":"0","AutoDry":"0","PowerSave":"0","WDirVStep":"0","WDirHStep":"0","TempLimitMax":"0","TempLimitMin":"0","DuctZoneType":"0","ZoneControl":"0","DRED":"0","SensorPM1":"8","SensorPM2":"8","SensorPM10":"10","AirPolution":"1","HumidityCfg":"0","WaterTempCoolMin":"NS","WaterTempCoolMax":"NS","WaterTempHeatMin":"NS","WaterTempHeatMax":"NS","HotWaterTempMin":"NS","HotWaterTempMax":"NS","SensorHumidity":"30","TotalAirPolution":"1","SensorMon":"1","CleanDry":"0","ProductStatus":"0","AirMonitoring":"0","Humidification":"0","AirFast":"1","AirRemoval":"1","AirUVDisinfection":"0","WatertankLight":"0","SignalLighting":"1","WDirUpDown":"0","WDirLeftRight":"0","WSwirl":"0","Jet":"0","LowHeating":"0","CirculateStrength":"6","CirculateDir":"1","AntiBugs":"0","IceValley":"0","Humsave":"0","WaterTempCur":"0","HotWaterTempCur":"0","HotWaterTempCfg":"0","HotWaterMode":"0","HotWater":"0","AWHPTempCfgSwitch":"0","AirTempCoolMin":"NS","AirTempCoolMax":"NS","AirTempHeatMin":"NS","AirTempHeatMax":"NS","WaterInTempCur":"0","AWHPWATempControlSta":"0","DisplayControl":"0","SmartCare":"0","TwoSetCoolTemp":"0","TwoSetHeatTemp":"0","TwoSetCoolUSL":"0","TwoSetCoolLSL":"0","TwoSetHeatUSL":"0","TwoSetHeatLSL":"0","TwoSetACOState":"0","TwoSetModeDeadband":"0","TwoSetState":"0"}}

I just published v1.2.17-test.2 to improve AirFast issue on above debug log, please try it

I just published v1.2.17-test.2 to improve AirFast issue on above debug log, please try it

Hi sir. Thanks for your supports.
The debug log above (#172) is related to status issue for air purifier, not about air fast issue.
Also, after updating to 1.2.17-test.2, the air fast mode starts not working and no log related to air fast pops up after turning on the air fast mode.

I just published v1.2.17-test.2 to improve AirFast issue on above debug log, please try it

Sorry mate. I think this happens cuz of issue from my internet server. I will check it when my server is back to normal.
Sorry for confusion.. really sorry. Please ignore my previous comment.
Hi sir. Thanks for your supports.
The debug log above (#172) is related to status issue for air purifier, not about air fast issue. Also, after updating to 1.2.17-test.2, the air fast mode starts not working and no log related to air fast pops up after turning on the air fast mode.

don't worry, I heard about that issue before but I don't have thinq1 to debug it
in v1.2.17, air fast mode may need to be enabled in plugin setting before it's can work normally
about device status not correctly, just wait it happen again, then check debug log, or try do some action (ex: turn on/off via homebridge) and check debug log again

I just published v1.2.17-test.2 to improve AirFast issue on above debug log, please try it

Sorry mate. I think this happens cuz of issue from my internet server. I will check it when my server is back to normal.
Sorry for confusion.. really sorry. Please ignore my previous comment.
Hi sir. Thanks for your supports.
The debug log above (#172) is related to status issue for air purifier, not about air fast issue. Also, after updating to 1.2.17-test.2, the air fast mode starts not working and no log related to air fast pops up after turning on the air fast mode.

don't worry, I heard about that issue before but I don't have thinq1 to debug it in v1.2.17, air fast mode may need to be enabled in plugin setting before it's can work normally
about device status not correctly, just wait it happen again, then check debug log, or try do some action (ex: turn on/off via homebridge) and check debug log again

Hi. Sir.
Here is what I got from 1.2.17-test.2
About Air fan mode, It's not working and also no log following after turning on or off this function.
Seems like my air purifier can't retrieve any signal from home bridge.
I think if it's possible, better to give options to turn off this function, air fan mode.
(My air purifier model is AIR_910604_WW)
About status issue. #172
Before opening LG thing APP on my iphone, there's no log shown on home bridge and no updates on status from Air purifier.
But some logs got found after doing some action (Turn on & off)
[6/19/2022, 5:01:30 PM] [LGThinQ] [request] post https://kic.lgthinq.com:46030/api/rti/rtiControl
[6/19/2022, 5:01:30 PM] [LGThinQ] [request] post https://kic.lgthinq.com:46030/api/rti/rtiControl
BUT After running on LG thing APP, I got this log.
[6/19/2022, 5:02:33 PM] [LGThinQ] [공기청정기 첫번째] Received snapshot:  {"airState.opMode":13,"airState.operation":true,"airState.tempState.current":40,"airState.tempState.target":0,"airState.windStrength":8,"airState.wDir.vStep":0,"airState.wDir.hStep":0,"airState.circulate.rotate":1,"airState.lightingState.signal":1,"airState.quality.overall":1,"airState.quality.sensorMon":1,"airState.quality.PM1":8,"airState.quality.PM2":8,"airState.quality.PM10":10,"airState.wMode.jet":0,"airState.miscFuncState.airFast":false,"online":true,"raw":{"Operation":"1","OpMode":"13","WindStrength":"8","TempUnit":"NS","TempCur":"40","TempCfg":"0","GroupType":"12","SleepTime":"0","OnTime":"0","OffTime":"0","RacAddFunc":"NS","ExtraOp":"0","DiagCode":"00","TimeBsOn":"0","TimeBsOff":"0","AirClean":"0","AutoDry":"0","PowerSave":"0","WDirVStep":"0","WDirHStep":"0","TempLimitMax":"0","TempLimitMin":"0","DuctZoneType":"0","ZoneControl":"0","DRED":"0","SensorPM1":"8","SensorPM2":"8","SensorPM10":"10","AirPolution":"1","HumidityCfg":"0","WaterTempCoolMin":"NS","WaterTempCoolMax":"NS","WaterTempHeatMin":"NS","WaterTempHeatMax":"NS","HotWaterTempMin":"NS","HotWaterTempMax":"NS","SensorHumidity":"30","TotalAirPolution":"1","SensorMon":"1","CleanDry":"0","ProductStatus":"0","AirMonitoring":"0","Humidification":"0","AirFast":"0","AirRemoval":"1","AirUVDisinfection":"0","WatertankLight":"0","SignalLighting":"1","WDirUpDown":"0","WDirLeftRight":"0","WSwirl":"0","Jet":"0","LowHeating":"0","CirculateStrength":"4","CirculateDir":"1","AntiBugs":"0","IceValley":"0","Humsave":"0","WaterTempCur":"0","HotWaterTempCur":"0","HotWaterTempCfg":"0","HotWaterMode":"0","HotWater":"0","AWHPTempCfgSwitch":"0","AirTempCoolMin":"NS","AirTempCoolMax":"NS","AirTempHeatMin":"NS","AirTempHeatMax":"NS","WaterInTempCur":"0","AWHPWATempControlSta":"0","DisplayControl":"0","SmartCare":"0","TwoSetCoolTemp":"0","TwoSetHeatTemp":"0","TwoSetCoolUSL":"0","TwoSetCoolLSL":"0","TwoSetHeatUSL":"0","TwoSetHeatLSL":"0","TwoSetACOState":"0","TwoSetModeDeadband":"0","TwoSetState":"0"}}


Use slash as path separator regardless of OS

I was looking at things in bugsnag today and noticed this:

Seems like bugsnag is not smart enough to figure out that these should be the same exceptions, so it doesn't group them (the errorClass is the same, the line is the same, and the path is the same if you ignore OS-specific separators).
Let's help bugsnag with grouping these correctly by using the same separator regardless of OS when sending exceptions to bugsnag. That will give us a more accurate picture of the exceptions that are happening.
cc @kevinsawicki @nathansobo for :thought_balloon: and :eyes:

Friendly ping, @nathansobo @kevinsawicki -- would love to hear what you think of this approach when you find a few minutes. :hourglass:

Looks good to me.

:ship: Sorry for the delay in reviewing.


Need more configurability in fd handling behavior

So I have a program that uses x11rb to implement xtrace-like functionality on copies of the data that flows over the x11 socket. When I parse messages I have copies of them but the fds don't actually exist in my program. RawFdContainer will try to close fds when it goes out of scope which could stomp on other fds in my process.
The most correct solution here is probably to replace RawFdContainer with a FdType parameter for all of the functions and structs that use it for encoding/decoding. (A dynamic trait probably won't work because there are structs that #[derive(Eq)] with RawFdContainer and Eq is not an object-safe trait). That's going to be rather invasive though. So I'd like to know if that's something you'd be open to before I do any work. If not, I'll just keep a local fork with the close in RawFdContainer patched out.

When I parse messages I have copies of them but the fds don't actually exist in my program. RawFdContainer will try to close fds when it goes out of scope which could stomp on other fds in my process.

If I understood correctly, RawFdContainers with dangling FDs are being created. How does this actually happen?

The problem is more that I can't (safely) create the RawFdContainers in the first place. I have a copy of the control messages from the recvmsg(2) but the corresponding fds don't actually exist in the kernel's fd table.

but the corresponding fds don't actually exist in the kernel's fd table.

...why? How do you get the control messages without also getting the FDs that they refer to? And how are you creating the RawFdContainers currently for the dangling FDs? Couldn't you just patch that code to open /dev/null instead so that they have a FD to close?
I feel like I do not understand what is going on here. Do you have some code that I could look at?

I feel like I do not understand what is going on here. Do you have some code that I could look at?

I have an rr[0] recording of a process. That recording contains the results and memory written by each syscall, so from that I can reconstruct the traffic over the x11 socket. I have the complete struct msghdr including things like the control messages that tell which fds were transferred over the socket, but the socket doesn't actually exist in the process that's parsing the messages, nor do these transferred fds. I just have a copy of all the messages.
Right now I don't create any RawFdContainers so messages that expect to receive fds just fail to deserialize. I would like to fix that, hence this issue. Opening /dev/null to make fds is an option I guess but there's no guarantee I can get the precise fd number that was used in the original recording (since that fd number may be used for something different in the process that's processing this data) so it's not my preferred option.
[0] https://rr-project.org/

Ah, thanks for that info. That clears things up a bit.
So... basically, it is impossible to get the FDs correct... I guess

but there's no guarantee I can get the precise fd number that was used in the original recording

Is that required for anything? Or do you want to avoid having to patch the msghdr instances to give them the right FDs?
Uhm... I'm not really sure how you are going about this, but why are the msghdrs important at all? Are you somehow replaying something with rr and using the RustConnection? Or which API of x11rb are you using?
Since this is just about parsing, I would expect that TryParseFd is the API to go to (plus some additional magic to figure out the right type for this call). If so, one can just provide a Vec containing a hundred FDs for /dev/null and the parsing code will fetch them from the Vec as needed.

Ah, thanks for that info. That clears things up a bit.
So... basically, it is impossible to get the FDs correct... I guess

but there's no guarantee I can get the precise fd number that was used in the original recording

Is that required for anything? Or do you want to avoid having to patch the msghdr instances to give them the right FDs?

It's not strictly required but I think it would be better to preserve the fd numbers if possible so that the output matches the original program precisely.

Uhm... I'm not really sure how you are going about this, but why are the msghdrs important at all? Are you somehow replaying something with rr and using the RustConnection? Or which API of x11rb are you using?

The msghdr contains the information needed to know if any fds were transferred with the message.

Since this is just about parsing, I would expect that TryParseFd is the API to go to (plus some additional magic to figure out the right type for this call). If so, one can just provide a Vec containing a hundred FDs for /dev/null and the parsing code will fetch them from the Vec as needed.

Yeah, TryParseFd is what I'm using.
For the time being I'm just carrying a fork with a changeset that comments out the parts of RawFdContainer that actually do kernel operations with the fds (e.g. dup/close). Supporting this behavior in mainline x11rb in addition to the current behavior may be too much work.


feat: Allow deserialization of unmatched enum values

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

13 of 13 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
3689

Relevant Lines:
3689

💛  - Coveralls


Add option for setting STAR command line option (--outFilterMismatch)

Hi there,
to allow for a stringent RNA-seq analysis of similar allelic copies, I would like to set --outFilterMismatch 2 during the STAR alignment of the nf-core/rnaseq pipeline.
I assume it is currently set and hard coded to the STAR default of --outFilterMismatch 10 since I could not find anything about how the option could be configured. It would be nice if one could adjust it.
Many thanks in advance for your help!

This should be possible now using the --star_options parameter added here -> https://github.com/nf-core/rnaseq/pull/455/commits/eda41d08be2d841623db43f200a917169f725e13


Fix parsing list[openmm.unit.Quantity] and parse openmm.Vec3

Description
Resolves #35
Todos
Notable points that this PR has either accomplished or will accomplish.

[x] Explicitly deal with the special case of list[openmm.unit.Quantity]
[x] Attempt to convert openmm.Vec3 to numpy.ndarray

Status

[ ] Ready to go

Seems to not break out infrastructure: https://github.com/openforcefield/status/pull/58


Don't throw error codes, throw exceptions

See https://github.com/torquem-ch/silkworm/pull/197/files#r602887209

Duplicate of Issue #203


http client: cannot provide a CA certificate path

Logic for validating TLS arguments in http client is currently broken:
host = ...
url = "https://{host}"
http = HttpClient(url, ca_cert_path="bundle.pem")

Results in

File caikit-nlp-client/src/caikit_nlp_client/http_client.py:67, in HttpClient.__init__(self, base_url, ca_cert_path, client_cert_path, client_key_path)
     56 self._ca_cert_path = ca_cert_path
     57 if (
     58     any(
     59         (
   (...)
     65     and not self._mtls_configured
     66 ):
---> 67     raise ValueError(
     68         "Must provide both ca_cert_path, client_cert_path, client_key_path "
     69         "for mTLS"
     70     )

ValueError: Must provide both ca_cert_path, client_cert_path, client_key_path for mTLS

this is a valid usecase, in which the user provides a custom ca bundle to handle self-signed certificates.

@vaibhavjainwiz
diff --git a/src/caikit_nlp_client/http_client.py b/src/caikit_nlp_client/http_client.py
index bda36d6..b4db375 100644
--- a/src/caikit_nlp_client/http_client.py
+++ b/src/caikit_nlp_client/http_client.py
@@ -55,13 +55,7 @@ class HttpClient:
         self._client_key_path = client_key_path
         self._ca_cert_path = ca_cert_path
         if (
-            any(
-                (
-                    self._client_key_path,
-                    self._client_cert_path,
-                    self._ca_cert_path,
-                )
-            )
+            any((self._client_key_path, self._client_cert_path))
             and not self._mtls_configured
         ):
             raise ValueError(


TestNG Support Module

Added support module for TestNG. Including a TestNG-Listener, Browserclasses and test cases. The TestNG support module shows the same behavior as the JUnit support module.

This change is

Heck, codacy-bot just spammed my inbox, hating on package private.

Integrated it with some minor adgustments.


Adds support for deleting into a list item from an unindented block.

This is the only thing missing to be able to backspace from the end of the document to the beginning continuously.

bors r+

bors r+

bors r+


Remove deprecated docs

Yarn and Mesos deployment are no longer supported since 2.0.

@madanadit @calvinjia PTAL.

@bf8086 doesn't seem like yarn was marked for deprecation in the code even though the decision might have been made. do you mind adding the @Deprecated annotation to those classes?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6763/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6766/
Test PASSed.

alluxio-bot, merge this please.

alluxio-bot, cherry-pick this to branch-2.1 please.


There can be only indexes without store in elasticsearch. Can crateDB achieve the same function?

**CrateDB **:
3.1.0
Environment description:
centos6.5 64bit

Problem description:
There can be only indexes without store in elasticsearch. Can crateDB achieve the same function?

Steps to reproduce:

Yes, see https://crate.io/docs/crate/reference/en/latest/general/ddl/fulltext-indices.html#disable-indexing.


Automate rollout of Istio module

Description
Changes proposed in this pull request:

Create action to automate rollout of Istio module

Related issues

/wip
need to check labelling


[FIX][TOPI][X86] schedule dense pack

Fix bug for topi x86 dense schedule _declaration_dense_nopack function.  It's in topi/python/x86/dense.py. The original config defined in this function says the tile_y and tile_x have num_outputs=2, but at line 174 in the same file, the _schedule_dense_pack_template function needs 'tile_y' and 'tile_x' knobs to provide three split parts. I fixed the num_outputs to 3 and it works.

@tqchen

Can this fix be merged? @tqchen

Thanks @KnowingNothing


Smaller spec numeric definition

Small refactor to reduce code duplication.

I don't know that happened with the docs. @bilelmoussaoui any idea?


Memory leakage due to tf.Variables

Currently memory in optimization is strongly increasing with every iteration. Using a memory profiler this tracks down to redifining tf.Variables in the propagation of method in tensorflow:
https://github.com/q-optimize/c3/blob/ebb13e49f004551efb24b65ef1a746ebf7ba180c/c3/experiment.py#L333-L345
Here are memory profiling of 20 iterations using
a) dt = tf.variable...

and b) dt =tf.constant

It therefore seems that there is memory leakage due to the change to tf.Variables as introduced in  46be03f860ea080a3e14cd24dce45eda5d9e873f by @lazyoracle  what has been the main point of changing the definition. If there was no  specific reason, except for explicitely having to watch constant in the gradient tape I would suggest to revert tf.Variables to tf.constant.

The original motivation for switching to tf.Variable was that it allowed the flexibility to directly access the whole suite of Gradient based optimizers defined in tf.keras.optimizer. I can go back and check if there is another way to continue that integration without fully rewriting parts of the tensorflow related codebase.

We should integrate the tf.Variable with the Paramatermap and C3Obj, such that only the elements that need gradients are made into variables, the others are made tf.constant

Possibly closed in #46


Uses HTTPX instead of Requests.

Describe the problem
Requests and other libraries without HTTP 2 support are not performing well, causing problems due to protections in some cases.
Describe the solution
Replacing Requests with HTTPX (along with some request header settings) can improve the approach and perform better results.
Additional context

How exactly would this benefit yfinance? Have you done benchmarking?


Update "get info" comp to use lists instead of a DataFrame

Is your feature request related to a problem? Please describe.
This is relates to the components of common/get_metric_info and common/get_method_info:
In the components the yaml files from the benchmarking results are imported as dataframes. This introduces some caveats that we have to circumvent. e.g. flattening of a list which introduces multiple rows wereas we only want on row and a col with multiple values.
Describe the solution you'd like
Import the data as a list of lists. This better reflects how the data will be outputted (json).
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
This might introduce some issues for importing the data to the website which will need to be addressed either at the website level or in the updated components

closed in #324


[WIP] Refactor of score processing pattern

I think the confusion largely comes from github not showing you clean diffs of files that were renamed.  I'm not sure why that is the case.

Closing in favor of https://github.com/wiki-ai/ores/pull/155


fix Fix group commit failed because access denied in cloud mode

Proposed changes
The inner group commit tvf does not need check user password.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


c++ loading model memory exception at LearningModel::LoadFromFilePath(modelPath)

in Windows 10 + Visual Studio 2019
when I'm testing the samples
D:\Windows-Machine-Learning-master\Samples\SqueezeNetObjectDetection\Desktop\cpp
and testing this tutorial
https://docs.microsoft.com/en-us/windows/ai/windows-ml/get-started-desktop
I got the same problem: memory exception
model = LearningModel::LoadFromFilePath(modelPath);
The exception popup windows says:
0x750D2CD2 处(位于 SqueezeNetObjectDetectionCPP.exe 中)引发的异常: Microsoft C++ 异常: winrt::hresult_error，位于内存位置 0x00F3EC60 处。
It seems there is some serious model loading problem.
The sample model is exactly from microsoft tutorial (in my disk the location is give as below)
D:\Windows-Machine-Learning-master\SharedContent\models\SqueezeNet.onnx
This problem is the same as this closed one
https://github.com/microsoft/Windows-Machine-Learning/issues/265
changing the version of the onnx model seems not working.
I tested all the sample onnx models from microsoft, none of them work correctly.
Then I traced a little bit of the code, found that the exception comes from check_hresult(hr) in base.h when I'm using SDK 10.0.18362.0
(path: C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\cppwinrt\winrt\base.h)
WINRT_EXPORT namespace winrt
{
template
auto get_activation_factory(param::hstring const& name)
{
impl::com_ref object;
hresult hr = WINRT_RoGetActivationFactory(get_abi(name), guid_of(), put_abi(object));
    if (hr == impl::error_not_initialized)
    {
        void* cookie{};
        check_hresult(WINRT_CoIncrementMTAUsage(&cookie));
        hr = WINRT_RoGetActivationFactory(get_abi(name), guid_of<Interface>(), put_abi(object));
    }

    check_hresult(hr);
    return object;
}

}
it seems that
hresult hr = WINRT_RoGetActivationFactory(get_abi(name), guid_of(), put_abi(object));
will give some negative value  {value=0x80040154 }, I don't know what it means.
thus check_hresult(hr) throw the first exception.
subsequently, the check_hresults in Windows.AI.MachineLearning.h  continues to trigger exceptions.
I also tried SDK 10.0.17763.0, the results are the same.
Testing with Visual Studio 2017 gives similar results.

Similar issue while loading the model.
Exception thrown at 0x00007FFAD551A799 in WinMLTest.exe: Microsoft C++ exception: winrt::hresult_error at memory location 0x0000005C103FEDC8. occurred

I am able to load SqueezeNet.onnx model and given sample example is running fine but I developed sklearn and xgboost model for which it is it fails to load the model.

@SpaceView - can you confirm which version of Windows 10 you are on? run "Winver.exe" and you will get a version and OS build number. Since Windows ML is not in older versions of Windows 10, we first want to check to make sure you have it.
@Karnav123 - please open a new issue for the one you mentioned.
closing as this is old, please re-open if you're still seeing issues.


minimal-bootstrap.findutils: init at 4.4.2

Description of changes

Related #227914
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg eval

Result of nixpkgs-review pr 245846 run on x86_64-linux 1

2 packages marked as broken and skipped:

minimal-bootstrap.findutils
minimal-bootstrap.test

My nix daemon might be misconfigured so it thinks my system can't build i686-linux.
[davidak@gaming:~/code/nixpkgs]$ nix run github:Mic92/nixpkgs-review -- pr --post-result 245846
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/245846/head:refs/nixpkgs-review/1
remote: Enumerating objects: 16, done.
remote: Counting objects: 100% (12/12), done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 16 (delta 7), reused 9 (delta 7), pack-reused 4
Unpacking objects: 100% (16/16), 274.59 KiB | 2.16 MiB/s, done.
From https://github.com/NixOS/nixpkgs
   e24d9ffc2da7..1b29ae46568e  master                -> refs/nixpkgs-review/0
 +<PHONE_NUMBER>4b...52ec937b7786 refs/pull/245846/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/davidak/.cache/nixpkgs-review/pr-245846/nixpkgs 1b29ae46568ef048c99d8dda95b3bbb17b6c4ff5
Preparing worktree (detached HEAD 1b29ae46568e)
Updating files: 100% (36477/36477), done.
HEAD is now at 1b29ae46568e Merge pull request #246208 from XYenon/master
$ git merge --no-commit --no-ff 52ec937b7786187feb97c4570839b100745cb1e6
Automatic merge went well; stopped before committing as requested

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/245846

2 packages marked as broken and skipped:
minimal-bootstrap.findutils minimal-bootstrap.test

error: cannot find flake 'flake:None' in the flake registries
error: cannot find flake 'flake:None' in the flake registries
Posting result comment on https://github.com/NixOS/nixpkgs/pull/245846
$ /run/current-system/sw/bin/nom-shell /home/davidak/.cache/nixpkgs-review/pr-245846/shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-245846]$ nix build -f nixpkgs/ minimal-bootstrap.findutils
error: Package ‘tinycc-mes-unstable-2023-04-20’ in «unknown-file» is not available on the requested hostPlatform:
         hostPlatform.config = "x86_64-unknown-linux-gnu"
         package.meta.platforms = [
           "i686-linux"
         ]
         package.meta.badPlatforms = [ ]
       , refusing to evaluate.

       a) To temporarily allow packages that are unsupported for this system, you can use an environment variable
          for a single invocation of the nix tools.

            $ export NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1

        Note: For `nix shell`, `nix build`, `nix develop` or any other Nix 2.4+
        (Flake) command, `--impure` must be passed in order to read this
        environment variable.

       b) For `nixos-rebuild` you can set
         { nixpkgs.config.allowUnsupportedSystem = true; }
       in configuration.nix to override this.

       c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
         { allowUnsupportedSystem = true; }
       to ~/.config/nixpkgs/config.nix.
(use '--show-trace' to show detailed location information)

This leads to an error that might be helpful?
[nix-shell:~/.cache/nixpkgs-review/pr-245846]$ nix build -f nixpkgs/ minimal-bootstrap.findutils --impure
error: hash mismatch in fixed-output derivation '/nix/store/rivkjf3vnb267xl9xpjwj8wyzis4y0hs-bash-2.05b.tar.gz.drv':
         specified: sha256-ugPUEpmMxUvQsPLWwyEAln0xNwmK/9wtMubnwRsWP+Q=
            got:    sha256-S/si3tvSbXziBieGKi3JU4wmA/aUgJQSJnQGmguDfnk=
error: 1 dependencies of derivation '/nix/store/cfzyqgmrf2z3yh3jx8a096bj25hx3mbm-bash-2.05b-builder.drv' failed to build
error: 1 dependencies of derivation '/nix/store/36xhz8d1q0abnsn9rq3kkb6pg9r8gy1g-bash-2.05b.drv' failed to build
error: 1 dependencies of derivation '/nix/store/jf3n45sqqaa5n4srsb9jc0j8f1ri0a6w-findutils-4.4.2.drv' failed to build

Result of nixpkgs-review pr 245846 run on x86_64-linux 1

2 packages marked as broken and skipped:

minimal-bootstrap.findutils
minimal-bootstrap.test


simple tls problems when using the dr to tls original traffic

Bug description
I want to test the function of ClientTLSSetting in DR。
I find the DR didn't work sometimes when it's created in other namespace where the workload not exist.
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[X ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Steps to reproduce the bug

install a k8s with single master node.
isntall the istio
deploy the workload in namespace https with the config

apiVersion: v1
kind: Service
metadata:
  labels:
    app: goserver-tls
  name: goserver-tls
spec:
  ports:
  - name: https
    port: 9090
    protocol: TCP
    targetPort: 8080
  selector:
    app: goserver-tls
  type: NodePort
---
apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app: goserver-tls
  name: goserver-tls
spec:
  replicas: 1
  selector:
    matchLabels:
      app: goserver-tls
  template:
    metadata:
      labels:
        app: goserver-tls
    spec:
      containers:
      - image: goserver-tls:v1.0.0
        imagePullPolicy: IfNotPresent
        name: goserver
        ports:
          - name: https
            containerPort: 8080
            protocol: TCP

to make sure it works fine whether in container or node environment
# kubectl -nhttps get po
NAME                            READY   STATUS    RESTARTS   AGE
goserver-tls-6fdcf6f5db-bmrlp   1/1     Running   0          4d1h
# kubectl -nhttps get svc
NAME            TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)         AGE
goserver-tls    ClusterIP   <IP_ADDRESS>     <none>        9090/TCP        11d
# curl -s -HHost:goserver-tls --resolve "goserver-tls:9090:<IP_ADDRESS>" --cacert ./ca.crt  https://goserver-tls:9090/healthz
{"status":"healthy","hostName":"goserver-tls-6fdcf6f5db-bmrlp"}

this is a binary written in golang just with codes like this
func CheckHealthyHandler(w http.ResponseWriter, r *http.Request) {
        hostName, _ := os.Hostname()
	respData := &HealthyStatus{
		Status: "healthy",
		HostName: hostName,
	}
	bts, _ := json.Marshal(respData)
	fmt.Println("request url of '/healthy' success.")
	io.WriteString(w, string(bts))
}

func main() {
	http.HandleFunc("/healthz", CheckHealthyHandler)
	http.ListenAndServeTLS(":8080", "server.crt",
		"server.key", nil)
}

inject the sidecar
also to make sure it works fine
create dr in namespace https like this

apiVersion: "networking.istio.io/v1alpha3"
kind: "DestinationRule"
metadata:
  name: "goserver-tls"
spec:
  exportTo:         # export to all namespace explicitly
  - "*"
  host: goserver-tls.https.svc.cluster.local
  trafficPolicy:
    tls:
      mode: SIMPLE
      caCertificates: /etc/sleep/tls/goserver-tls/ca.crt

create deploy of sleep in namespace https

# kubectl apply -f samples/sleep/sleep.yaml -n https

mount the cert file into the sidecar like this

kind: Deployment
spec:
      containers:
      - name: sleep               # sleep container
        image: curlimages/curl
      - name: istio-proxy         # sidecar container
        image: proxyv2:1.9.2
        volumeMounts:
        - mountPath: /etc/sleep/tls/goserver-tls    # the path used by DR
          name: cert
      volumes:
      - hostPath:
          path: /path/to/cert       # where the ca.crt exists
          type: ""
        name: cert

make sure the DR works fine

# kubectl -nhttps exec -it deploy/sleep -c sleep -- curl -i http://goserver-tls:9090/healthz
HTTP/1.1 200 OK
...
{"status":"healthy","hostName":"goserver-tls-6fdcf6f5db-bmrlp"}

# kubectl -nhttps exec -it deploy/sleep -c sleep -- curl -i --cacert ./ca.crt  https://goserver-tls:9090/healthz
curl: (35) error:1408F10B:SSL routines:ssl3_get_record:wrong version number

create deploy of sleep in namespace foo and bar and mount the cert file into the sidecar as above shows
the DR works fine
delete the DR in namespace https and create it in namespace foo or bar
to test

# kubectl -nfull exec -it deploy/sleep -c sleep -- curl -i http://goserver-tls.https.svc.cluster.local:9090/healthz
HTTP/1.0 400 Bad Request

Client sent an HTTP request to an HTTPS server.
#
# kubectl -nhttps exec -it deploy/sleep -c sleep -- curl -i http://goserver-tls:9090/healthz
HTTP/1.1 200 OK
Date: Fri, 25 Jun 2021 02:42:07 GMT
Content-Length: 63
Content-Type: text/plain; charset=utf-8

{"status":"healthy","hostName":"goserver-tls-64b8d888f9-hmwqv"}

when the DR is deployed in root namespace , all works fine.  I dont't know why sometimes the DR didn't work when it's deployed in other namespace though it's export to all namespace explicitly.

Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
# istioctl version --remote
  client version: 1.9.2
  control plane version: 1.9.2
  data plane version: 1.9.2 (9 proxies)
# kubectl version --short
  Client Version: v1.18.2
  Server Version: v1.18.2

How was Istio installed?
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
spec:
  hub: ${registry_url}
  meshConfig:
    accessLogFile: /dev/stdout
    enableTracing: true
    defaultConfig:
      holdApplicationUntilProxyStarts: true
  values:
    global:
      imagePullPolicy: IfNotPresent
  components:
    egressGateways:
    - name: istio-egressgateway
      enabled: true
    pilot:
      k8s:
        podDisruptionBudget:
          minAvailable: 1

As per https://istio.io/latest/docs/ops/best-practices/traffic-management/#cross-namespace-configuration ,

Setting the visibility of destination rules in a particular namespace doesn’t guarantee the rule is used. Exporting a destination rule to other namespaces enables you to use it in those namespaces, but to actually be applied during a request the namespace also needs to be on the destination rule lookup path:

client namespace
service namespace
the configured meshconfig.rootNamespace namespace (istio-system by default)


Event handlers are not applied

Event handlers on styled components are not working. It seems the created component is not applying the right vue properties that contain things like event handling.
Recreation:
const Button = styled.button``;

const Component = Vue.component("test-component", {
	functional: true,

	render() {
		return <Button onClick={() => console.log("I am never fired")}>Click me!</Button>;
	}
});

Expected behavior: Clicking the button should log I am never fired in the console
Actual behavior: Nothing gets logged in the console

Hi @Munter,
I assume this is the same problem as router-link and any vue-components.
You must apply the native modifier, but I don't know how to do in jsx.
Can you try this?

Yeah, we got it to work with <Button nativeOnClick={() => console.log("I am never fired")}>Click me!</Button>. I can move forward without being blocked, but I guess it would be nice to get the higher level event handlers integrated into vue-styled-components in order to retain the semantics that the rest of the ecosystem provides

I can easily achieve this issue. Just give me some time to update, also PR's are well accepted.

I'm trying to clear some time at work to contribute here, but it's not my core responsibility, so it might be a bit difficult unless we hit a hard blocker

Any updates on this issue?

@Munter @kurikaesu I am trying to achieve this but it's quiete difficult because to bridge the vue event you have to emit from the base component:
https://jsfiddle.net/Linusborg/q4j5xm98/
We can't know which component will be rendered. any ideas?

I bridged click so for now you will be able to use "click" handler.
I don't know which events are you also interested.


fix: remove go.exe as argument to go command

Description of changes

Issue #, if available
https://github.com/aws-amplify/amplify-cli/pull/13789
closes: https://github.com/aws-amplify/amplify-cli/issues/13790

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for contributing @redjonzaci

glad i was able to assist!


Add user auth and jwt

Hello @tomuhenry! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file users/migrations/0001_initial.py:

Line 20:80: E501 line too long (114 > 79 characters)
Line 21:80: E501 line too long (88 > 79 characters)
Line 22:80: E501 line too long (103 > 79 characters)
Line 23:80: E501 line too long (196 > 79 characters)
Line 24:80: E501 line too long (329 > 79 characters)
Line 25:80: E501 line too long (103 > 79 characters)
Line 26:80: E501 line too long (102 > 79 characters)
Line 27:80: E501 line too long (165 > 79 characters)
Line 28:80: E501 line too long (203 > 79 characters)
Line 29:80: E501 line too long (117 > 79 characters)
Line 30:80: E501 line too long (104 > 79 characters)
Line 34:80: E501 line too long (266 > 79 characters)
Line 35:80: E501 line too long (229 > 79 characters)

In the file users/views.py:

Line 6:1: E302 expected 2 blank lines, found 1


Won't display any bereals

Upon accessing no bereals are showing- keeps showing "error" message.

same - bereal changed something again..

looking into

updated based on befake issue thread


University student post from Edoardo

Student is going for an extended holiday, will meet with him in Mid Aug and should get the post out within sept.


Fixes to servedocs (+minor release)

closes #125
closes #126
Testing

Ran servedocs(skip_dir="docs/src/generated") on the Literate.jl repo, modified outputformats.md (picked up ✔) modified outputformats.jl (picked up ✔)

@fredrikekre I intend to merge this soon but there's one element I'd like your opinion on, could you ran the following example with this branch:
using LiveServer, Documenter, Literate
LiveServer.servedocs_literate_example()
cd("servedocs_literate_example/")
servedocs(literate=joinpath("docs", "literate"))

There's a bunch of <unknown> added e.g.:
```@meta
EditURL = "<unknown>/docs/literate/man/pg1.jl"
```

I think this comes from Literate. It looks like stuff works fine but it shows a bunch of warnings in the REPL. Anything that could be done to maybe disable some checks on that front? or is it a Documenter issue? Thanks!

Great, thanks.

I think this comes from Literate.

Yep, and those are expected to be <unknown> unless running on GH Actions or similar.

Anything that could be done to maybe disable some checks on that front?

I mean, you can filter out those log messages I suppose, but personally I am not bothered by them since I am generally not looking at that terminal window anyway. It is also happening from just julia docs/make.jl so people using Literate have probably already seen them. I don't think it is LiveServers job to hide them.

Sounds good, thanks for the clarifications


feat(sidebar): add menu sidebar updating

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

A new feature - sidebar menu entries updating.

What is the current behavior? (You can also link to an open issue here)

The sidebar menu is loaded at the beginning when baSidebar.component is instantiated and remains unchanged since. It is also very hard to update it afterward.

What is the new behavior (if this is a feature change)?

baMenu.service is exposed to the application and via updateMenuByRoutes, which takes in the object of the type similar to app.menu.ts(essentially how the menu is structured), allows easy sidebar menu updating.

Other information:

I believe this change does no harm and only provides benefits, as this feature was requested by a few people in issue #236.
If you have any questions, opinions or suggestions I would be happy to hear them.
To use this in a component/service of yours simply import baMenu.service from the theme directory, inject it into the constructor of your component/service and use the updateMenuByRoutes method when the menu needs to be modified. You don't have to clone your menu, it will remain unchanged, opposed to the default behavior or baMenu.service methods that mutate their inputs.
To test if this works you can modify the constructor of the baMenu.service:
  constructor(private _router:Router) {
    this.updateMenuByRoutes(<Routes>MENU);

    setInterval(() => {
      let menuPart = _.cloneDeep(MENU);
      menuPart[0].children = menuPart[0].children.filter(() => Math.random() > 0.5);
      console.log('Updating routes', menuPart);
      this.updateMenuByRoutes(<Routes>menuPart);
    }, 4000);
  }

Every 4 seconds the menu will be updated, items that should remain will be chosen randomly.

Hello Gelio, just curious, why did you remove lodash import? is it imported somewhere else?

@abedzantout I think it's imported as a vendor dependency. Removing it caused no errors and moreover less code to maintain is overall for the better.

@Gelio It caused an error from my side. The way i fixed it was adding declare var _: any; in custom_typings.d.ts

@abedzantout That's strange. I was able to successfully run that without any errors on the most recent master branch. Are you perhaps any commits behind master?

@Gelio yes i noticed that is way i asked. The only thing differing are the packages that i am using, i am using lodash 4.17.2 and lodash types 4.14.38. Maybe this could be the reason.

Hey @Gelio, this is great, many thanks!
While we are on it, probably it would make more sense to move the https://github.com/akveo/ng2-admin/pull/548/files#diff-49e9fb1e5d9b20de76e3c3e0cec8defeR15 part into the app component?
So that at the end the menu service becomes a global one and menu component won't depend on the app at all (will become an independent) and thus we will device the source of the menu items from the menu component.
What do you think?

@nnixaa 👍 Yes, definitely, that's a great suggestion! I knew it should be structured differently but I just didn't have any idea how to initialize the menu. I will change it later today and let you know when I'm finished

@nnixaa I've moved initializing the menu into app.component.ts. While doing so I found out that baMenuService was in component's providers instead of module's ones, so it was impossible to change the menu outside of baMenu.component. I fixed that as well.
I'm looking forward to seeing your opinion on this.

@Gelio probably let's move the menu service into the services folder https://github.com/akveo/ng2-admin/tree/master/src/app/theme/services? So that it becomes more of a global service, rather than a local component service.

Sure, I'll do it. Do you have any other suggestions?
19.12.2016 2:23 PM "Dmitry Nehaychik"<EMAIL_ADDRESS>napisał(a):

@Gelio https://github.com/Gelio probably let's move the menu service
into the services folder https://github.com/akveo/ng2-
admin/tree/master/src/app/theme/services? So that it becomes more of a
global service, rather than a local component service.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/akveo/ng2-admin/pull/548#issuecomment-267962865, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA2SJ6J84dEM6Z-sHFdEV1hfO1HgB7_oks5rJoVXgaJpZM4LP44E
.

@nnixaa I've moved baMenu.service to a separate directory in the services directory, just as you asked. If there's anything more I can do just let me know

@Gelio just merged this, many thanks again!

Not a problem, I'm glad I could help!

It is worth noting that for those who are wondering how the test provided by @Gelio at first works after the additional changes he made. Modify the constructor in app.component.ts :
`
constructor(private _state: GlobalState,
private _imageLoader: BaImageLoaderService,
private _spinner: BaThemeSpinner,
private _config: BaThemeConfig,
private _menuService: BaMenuService,
private viewContainerRef: ViewContainerRef ) {
this._menuService.updateMenuByRoutes(<Routes>MENU);

 setInterval(() => {
		let menuPart           = _.cloneDeep(MENU);
		menuPart[ 0 ].children = menuPart[ 0 ].children.filter(() => Math.random() > 0.5);
		console.log('Updating routes', menuPart);
		this._menuService.updateMenuByRoutes(<Routes>menuPart);
}, 4000);`

Happy coding!

Could you review again this fix, i have tested the last changes but they are not working. The menu is not expanded when i write the URL and the component "baContentTop" is not loading the variable "activePageTitle".

@Gelio Thank you for the sidebar update feature.
I'm new to Angular2 and Typescript and I'm having trouble implementing the update feature. I'm trying to pull the navigation in via URL using a service but haven't been able to figure out how to use the updateMenuByRoutes to modify the navigation. Any advice on what to do next is greatly appreciated or if anyone has an example that I could learn from.
Modified app/pages/pages.menu.ts:
  {
    path: 'pages',
    children: [
      {
        path: 'summary',
        data: {
          menu: {
            title: 'Summary',
            icon: 'ion-android-home',
            selected: false,
            expanded: false,
            order: 100
          }
        }
      },
      {
        path: 'dashboard',
        data: {
          menu: {
            title: 'Project',
            icon: 'ion-android-radio-button-on',
            selected: false,
            expanded: true,
            order: 0
          }
        }

      }
    ]
  }
];```

**Navigation Service app/theme/services/nav/nav.service.ts:**
```import {Injectable} from '@angular/core';
import {Router, Routes} from '@angular/router';
import { Http, Response, Headers, RequestOptions } from '@angular/http';

import {Observable} from 'rxjs/Rx';

import {BaMenuService} from '../baMenu/baMenu.service';
import {BaMenu} from '../../components/baMenu/baMenu.component';
import { MENU } from '../../app.menu';

@Injectable()
export class NavService {

	constructor (
		private _http: Http,
		private _menuService: BaMenuService,
		private _router: Router
	)
		{
			this._menuService.updateMenuByRoutes(<Routes>MENU);
		}

	getNavs() {
		return this._http.get(this.navsUrl)
			.map((res:Response) => <Routes[]>res.json()
			.subscribe(onNext, error => console.log("An error occurred when requesting nav.json.", error));
	}
}```

**Navigation file nav.json:**
```[
  {
    "path": "pages",
    "children": [
      {
        "path": "dashboard",
        "data": {
          "menu": {
            "title": "Project1",
            "icon": "ion-android-radio-button-on",
            "selected": false,
            "expanded": true,
            "order": 0
          }
        }
      },
      {
        "path": "dashboard",
        "data": {
          "menu": {
            "title": "Project2",
            "icon": "ion-android-radio-button-on",
            "selected": false,
            "expanded": true,
            "order": 0
          }
        }
      }
    ]
  }
]```

@raposok Unfortunately, I haven't used this feature much. I recommend you to learn basics of Javascript and Typescript first before trying out Angular.
From what I can tell, your NavService contains the following mistakes:

getNavs returns a subscription, not an Observable, which I guess is the intended behavior. Consider replacing the subscribe function with the do operator.
In getNavs you're missing a closing bracket on the line with the map operator.
In getNavs the onNext function is not defined, which surely produces compilation and runtime errors. The navsUrl property of the service is not defined as well. You should consider setting it first.

Moreover your import of a lot of variables is redundant (namely Headers, RequestOptions, Observable, BaMenu).


depositories: require validation again after AccountNumber or RoutingNumber is upserted

I noticed we didn't require validation again after changing the AccountNumber or RoutingNumber, which we need to do (via micro-deposits) to prevent subtle changes that would withdraw funds from an account the user wasn't authorized to access.

Codecov Report

Merging #115 into master will increase coverage by 0.34%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   53.03%   53.38%   +0.34%
==========================================
  Files          23       23
  Lines        3128     3136       +8
==========================================
+ Hits         1659     1674      +15
+ Misses       1125     1111      -14
- Partials      344      351       +7


⚠ Bofrost.nl has degraded performance

In 12a4442, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1274 ms

Resolved: Bofrost.nl performance has improved in aee9284.


Adding student domain for Lehigh Valley Charter High School for the Arts in Bethlehem PA USA

Accredited high school in Bethlehem, Pennsylvania, USA.

@teefal First stage of verification passed, official domain is charterarts.org as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@teefal Thank you for your patience while waiting for a review and processing your request. Pull request merged.

Thanks!
On Fri, Jul 21, 2023 at 8:55 AM Philip Torchinsky @.***>
wrote:

@teefal https://github.com/teefal Thank you for your patience while
waiting for a review and processing your request. Pull request merged.
—
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/18054#issuecomment-1645542802,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAV5CACJQZQZDG3UJHDL53LXRJ35NANCNFSM6AAAAAA2L5GHFA
.
You are receiving this because you were mentioned.Message ID:
@.***>


test: update WPT submodule

@OrKoN FYI: Some viewport tests seem to be failing in this new batch. Will disable them as usual.


Column labels are being converted into upper case

Column labels are being converted to upper case. It is very random, though. Some label are not being converted.
const columns = [
  {
    name: 'id',
    label: 'Id',
    options: {
      display: false,
      filter: true,
      sort: true,
    },
  },

  {
    name: 'photo',
    label: 'Photo',
    options: {
      filter: false,
      sort: true,
      customBodyRender: (value) => <Avatar src={value} sx={{ height: '60px', width: '60px' }} />,
    },
  },
  {
    name: 'studentName',
    label: 'Student',
    options: {
      filter: true,
      sort: true,
    },
  },
  {
    name: 'phone',
    label: 'Phone',
    options: {
      filter: true,
      sort: true,
    },
  },

  {
    name: 'course',
    label: 'COURSE',
    options: {
      filter: false,
      sort: false,
    },
  },
  {
    name: 'enrolledOn',
    label: 'Admission Date',
    options: {
      filter: false,
      sort: true,
    },
  },
  {
    name: 'paidFees',
    label: 'Paid Fees',
    options: {
      filter: true,
      sort: true,
    },
  },
  {
    name: 'dueFees',
    label: 'Due Fees',
    options: {
      filter: true,
      sort: false,
    },
  },
];

 <MuiDataTable
          data={getEnrolledStudents(enrollments)}
          columns={columns}
          options={{
            filterType: 'checkbox',
            rowsPerPage: 5,
            selectableRows: 'none',
            rowsPerPageOptions: [5, 10, 15, 20],
          }}
        />

Image
Your Environment

Tech
Version

Material-UI
5.5.3

MUI-datatables
4.2.2

React
^18.0.0

I am facing the same issue

We are also getting this bug using;
"mui-datatables": "^4.3.0",
"react": "^16.13.1",
"react-content-loader": "^6.2.0",
"react-dom": "^16.13.1",
it seems randomly appearing.

same issue

I'm reproing this in 4.3.0 as well.
When I set the column option sort to false, the case is preserved, if I set it to true, then the label is converted to upper case. The behavior is consistent for me:
     name: "target",
     label: "Target",
     options: {
      filter: true,
      sort: false,
     }
    }

I am also seeing this issue. Is there any workaround at the moment?

I'm facing the same issue, even ussing the customHeadLabelRender prop the label gets rendered in full uppercase.

I've found a workaround for this but it's hacky. By using inline HTML and styling, I was able to capitalize the text in the column label:
columns = [
.... { name: 'check_in_datetime', label:
Checkin
 }
]

It seems to be due to the use of the MUI button (when sorting is enabled)  that capitalize the header.
.mui-theme-1w1rijm-MuiButtonBase-root-MuiButton-root {
    ...
    text-transform: uppercase;
    ...
}

I was able to resolve this with a bit of CSS :
th.MuiTableCell-root.MuiTableCell-head button {
    text-transform: none;
}

Some more class may be usefull to avoid unwanted change but that's enought for me.


Can i access firebase phone auth users suing firebase-admin-dotnet

I have plan to create flutter app with phone auth, but I have a doubt, can I access phone auth users through this library.

https://firebase.google.com/docs/reference/admin/dotnet/class/firebase-admin/auth/firebase-auth#getuserbyphonenumberasync


Added file download automation

Chromedriver is now saved in cache and doesn't need to reinstalled at each play
model weights are now downloaded automatically from drive and saved in supporting_files directory

we'll decide later


Can`t use reset or cancel methods in onBeforeUpload callback.

When trying reset or cancel queue in onBeforeUpload callback it is an error "TypeError: this.jqXHR is null".

I found a way to accomplish this by doing the following in onNewFile. below is a simplified way to do this:
onNewFile: function(id, file){
if(file.type){
ui_multi_add_file(id, file);
} else {
alert(file.name + ' '+t_i18n('must have a file type.'));
file = null;
return false;
}
}


How can I assign the all value of src_data1 to input0 without FOR loop?

Hi, I want to assign the value of src_data1 to input0 without FOR loop.
neon_gemmlowp.cpp
.
.
.
Tensor input0;
.
.
.
const char src_data1 = a; //a is a single-dimensional array
.
.
.
//For input0
for(  int z = 0; z < ifm_src_img; ++z)
{
for(  int y = 0; y < height_src1_image; ++y)
{
for(  int x = 0; x < width_src1_image; ++x)
{
* reinterpret_cast<char>( input0.buffer() +input0.info()->offset_element_in_bytes(Coordinates(x,y,z))) = src_data1[ z * (width_src1_imageheight_src1_image) + y * width_src1_image + x];
}
}
}
//std::cout << "Look"<<std::endl;
//For input1
for(  int z = 0; z < ifm_src_img; ++z)
{
for(  int y = 0; y < height_src2_image; ++y)
{
for(  int x = 0; x < width_src2_image; ++x)
{
* reinterpret_cast<char>( input1.buffer()+input1.info()->offset_element_in_bytes(Coordinates(x,y,z))) = src_data2[ z * (width_src2_image*height_src2_image) + y * width_src2_image + x];
}
}
}
.
.
.

Hi, you can use the iterator and execution window instead. You can memcpy each row. There is an example at https://github.com/ARM-software/ComputeLibrary/blob/master/examples/neon_copy_objects.cpp.

But this method even runs slower than my method.

Unfortunately as the the tensor has padding around the two-dimensional image, one can't simply memcpy the whole single dimensional array into a Tensor. You have to at least iterate each row.

Thanks a lot, I'd seek other method

That's sad. I would like to be able to use the buffer directly like NNPACK.

we are planning zero-copy method by which you can use the buffer directly. Hopefully, it could be ready at next quarter.

Hello @duhuanxianzi,
Well you could create a tensor with the shape that you want and allocate upfront without passing it to any function which might add padding to it. Then you could directly memcpy the buffer to it, but be aware that any Function you configure with this tensor might shrink the execution window as it doesn't have the padding that a kernel might require. While this is OK for vision functions might be destructive for Neural Network ones (depending on your model).
Concerning the zero-copy method we are planning to add, I think the current limitation will be the same as the one I mentioned above. You could directly say to a tensor use this memory and do not allocate yourself but then again the tensor will lock and will have to shrink the execution window in case padding is required.

Hi, I have solved this problem. And the efficiency of the new method is faster than before.
Thanks a lot!

Closing. Reopen if required.


Forbid implicit types conversions for at least null and undefined.

I need an option that forbids implicit conversion from null and undefined to other types.
Possibly in two flavors:

forbid all cases where JS will convert types
forbid all cases where JS will convert types except implicit casting to bool

const qwe: string | null = null;
const asd: string | undefined = undefined;

console.log(`${qwe}`); // should fail
console.log(`${asd}`); // should fail
if (qwe !==null)
    console.log(`${qwe}`); // should NOT fail
if (asd !==undefined)
    console.log(`${asd}`); // should NOT fail

What common in all these cases? Automatic conversion to a string from some types should be forbidden. The list of such types should be configurable, and null/undefined should be in the list by default. Objects/Arrays—the same. Objects—except those who don't have ValueOf or other explicit convertors to string.
In general, I see only one case where implicit conversion should be allowed: something -> bool. Other cases are almost always are bugs. A possible exception is some logging code.
For example, in my project—it's not allowed to implicitly convert numbers to strings. Because locale-aware formatting is required. And also scientific form is not ok.
Possibly all these things can be checked by ESLint ?

You are right that all these can be handled by ESLint.

restrict-template-expressions
restrict-plus-operands
strict-boolean-expressions


[PE-D][Tester A] Undo command has wrong message

When I undo an add command, the message says Retrieved most recent deleted event: Empty string for Undo action now, when it should say that the added event has been removed.

Labels: severity.VeryLow type.FeatureFlaw
original: glozxi/ped#4

Duplicate of known bug, see #112 .


Web - Chat - Compose box gets disappeared after cancelling the edit comment

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to URL http://staging.new.expensify.com/[](javascript:)
Select any existing chat or create a new chat by clicking + and click New chat
If New chat selected, enter name, email, or phone number
Write something and hit Send
Hover over the text you just sent and click on Pencil to edit comment
Don't make any changes and click Cancel

Expected Result:
User should be able to continue to post or write something in the compose box
Actual Result:
The compose box disappeared and user can no longer write anything. This issue also affects all existing chats until you logout and log back in again.
Workaround:
Log out and re login
Platform:

Where is this issue occurring?

Web (Happens with touch pad laptops only)

Version Number: v1.1.46
Reproducible in staging?: Y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/160126065-699f9e94-637a-49ef-8e59-48c3c4b42b0a.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub

Whoops! This issue is 2 days overdue. Let's get this updated quick!

Huh... This is 4 days overdue. Who can take care of this?

Still overdue 6 days?! Let's take care of this!

Issue not reproducible during KI retests. (First week)

Bumped to Weekly since it doesn't appear to be reproducible

Let's wait one more 'overdue' round to see if it's reproducible then we'll close

Closing, @kavimuru please reopen or/or comment if you're able to reproduce


Setup GitHub actions.

Here is the test output:
https://github.com/voxik/builder/actions/workflows/test.yml
The test failures are related to #13


[Issue-6143][helm]: Add the rbac policy to give the brokers permissions to deploy functions

Motivation
Fixes feature enhancement request #6143:
Currently, there are quite a few undocumented steps that are needed to be performed manually in order to make sure that the functions can be submitted as pods in K8s runtime environment. It would be much better if this process would be automated.
Proposed solution:
Automate this process via helm install and update the helm charts with templates.
Modifications
I've added an additional functionsAsPods filed in extra components inside the values file. If the setting is set to yes, then it would add serviceAccount to the broker deployment. It will also add the rbac policy to give the brokers permissions to deploy functions. The policies can be found in the new broker-rbac.yaml template file. Moreover, it will also change the functions_worker settings and set the function runtime factory setting that can be found inside broker-configmap.yaml.
Verifying this change

Set functionsAsPods: yes inside helm values yaml file.
Follow the instructions on how deploying helm and run:
helm install pulsar --values pulsar/values-mini.yaml ./pulsar/.
Wait until all the services are up and running.
Set up tenant, namespace.
Create a function, sink and source and submit it using the CLI to make sure the pods are running alongside the Pulsar cluster. In addition, set up such a flow where the data is flowing from source to topics, the processed by a function and sink outputs the data
Push data into cluster through the source and make sure it comes out of the sink into destination. There shouldn't be any errors in the logs of brokers, bookie, sources, sinks and functions.

Modules affected:
The changes in the PR are affecting the deployment using the helm charts. Now the if the flag functionsAsPods is set to yes inside the `values.yaml. file, the functions would run as pods.
Documentation
Currently, the documentations explaining the helm chart deployment process is lacking and this should be updated.

Thanks @roman-popenov for the help. @sijie @wolfstudy to help review it.

Hi, some blame game ;) you messed up broker-configmap.yaml by adding two spaces first on row 47. The generate yaml is now invalid.


Question about the input of attribute

I found that you use 'att' to be the input of E1 not 'original_att'.
what the difference between 'att' and 'original_att'?

Each class attribute vector is normalized to have the unit l2 norm. So att is the normalized version of original_att.

Further clarification:
The line
self.aux_data = torch.from_numpy(matcontent['att'].T).float().to(self.device)

would be equivalent to:
self.aux_data = torch.from_numpy(matcontent['original_att'].T).float().to(self.device)
self.aux_data = torch.nn.functional.normalize(self.aux_data, p=2, dim=1)


notebook visualisation does not run due to wrong dimensionality of attention_weights

Hi all,
I am playing with the visualisation notebook and after some work, i manage to get everything apart from the last cell running. I find that enc_attn and dec_attn has different shape and therefore in the last cell, during get_attention, they wont concat. It would be great if somebody could take a look and see if i am missing something.
I have attached the visualisation code here.
TransformerVisualization.log
which is basically the IPYNB file with the ending changed to log. (since github does not support ipynb upload) It recorded also the output at runtime and the stack trace as well.
Thank you very much!

I believe this has been fixed.

I have yet to verify it because I am having trouble visualizing byte2byte models because of json dump format. I will report back after I get the byte serialization problem fixed, will report back afterwards and reopen if needed.


added condition for no-menu in PN

Summary of changes
Add Condition in Primary navigation for No Menu (no-menu machine-name) that will force a page to have no menu displayed even if it gets put into a menu.
Frontend
Modified file page.js to have a condition for the no-menu in primary navigation
[X] My changes are accessible (at minimum WCAG 2.0 Level AA)
[X] My changes are responsive and appear as expected on mobile and desktop views.
[X] After merging, I will update the Content Hub documentation and ensure the Content Hub trainer understands how my changes will affect users.
##. Backend
Note: The following Taxonomy Term has been added to the Taxonomy Primary Navigation
Name : No Menu
Machine-name : no-menu
Test Plan
Multdev - https://sns-nomenu-chug.pantheonsite.io/ - for testing
can use the live site, as the Taxonomy Term has been updated (or test)
Edit a page and see if Primary Navigation is required

Create a basic page do not add it to a menu, but add No Menu under the Primary Navigation.

page should be created as normal - but, not have a menu.

add page to a menu (either via the page add to menu or via the menu add buttion).

page should still not have a menu

all other pages should have a menu if set.

@snschau Existing pages seem to be working as expected, but I don't have access to your multidev so I can't test creating a page

I have added your account to the local login on that mulidev - try logging in (not using SAML).


Tofi not respecting anchor and resolution/scaling on Niri

As the title and the image say tofi doesn't seem to acknowledge screen parameters on Niri. I don't know how to debug so this is all I got (in theory Niri supports layer-shell).

I faced the same issue, which also happens with bemenu albeit in a different manner (anchor is ignored, but the sizing is too and the content doesn't get stretched as in tofi).
After some testing, it turns out that anchoring is ignored also by plasma's kwin (so maybe the code in tofi and bemenu uses something specific to wlroots), while the sizing issue happens only in compositors using smithay like niri (so it may be a bug/omission in smithay).
See the related issues:

bemenu: https://github.com/Cloudef/bemenu/issues/422
niri: https://github.com/YaLTeR/niri/issues/575

As a side note, both anchoring and sizing work properly under kwin and smithay compositors when using fuzzel, so maybe there's a way to implement these options in a more "generic" way which works across wlroots, kwin and smithay at the same time

I found the cause of the bug by comparing tofi's code for centering to fuzzel's code: basically, instead of specifying all anchors to center the surface, as tofi does, it should specify no anchor at all. See this fuzzel commit.
I'll try writing a patch this evening.


[GLUTEN-5622] Add new added Spark3.5 UTs in Gluten

What changes were proposed in this pull request?
In Spark 3.5, there are some new added UTs vs Spark3.4 which haven't been added in Gluten yet. In this PR, we ported the ones under spark/sql but excluding folders like streaming, execution/command, execution/benchmark.
(Fixes: #5622)
How was this patch tested?
CI

@zhouyuan Please help review this PR. Thanks!

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_5623_time.csv
log/native_master_05_06_2024_72e787c64_time.csv
difference
percentage

q1
35.97
36.58
0.610
101.69%

q2
23.67
23.74
0.066
100.28%

q3
35.50
38.97
3.463
109.75%

q4
37.78
38.09
0.308
100.82%

q5
69.64
68.56
-1.082
98.45%

q6
7.48
6.78
-0.696
90.70%

q7
84.20
83.29
-0.910
98.92%

q8
86.17
87.34
1.171
101.36%

q9
120.44
122.36
1.927
101.60%

q10
44.69
46.26
1.569
103.51%

q11
20.36
20.36
0.001
100.00%

q12
28.40
27.48
-0.924
96.75%

q13
56.43
54.80
-1.624
97.12%

q14
23.81
20.20
-3.617
84.81%

q15
30.07
30.34
0.265
100.88%

q16
13.63
15.88
2.247
116.48%

q17
103.76
101.90
-1.857
98.21%

q18
146.02
146.06
0.035
100.02%

q19
16.12
14.65
-1.462
90.93%

q20
27.13
26.35
-0.788
97.10%

q21
279.33
291.97
12.633
104.52%

q22
14.84
15.01
0.173
101.16%

total
1305.47
1316.98
11.509
100.88%


Whitespace inserted with unicode BOM

VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:34:22.110Z)
OS Version: Linux x64 4.12.12-custom
Extensions:

Extension
Author (truncated)
Version

vscode-eslint
dba
1.4.3

python
ms-
0.8.0

cpptools
ms-
0.14.2

JavaScriptSnippets
xab
1.5.0

Steps to Reproduce:

Launch VS Code and create a new JavaScript file
use VSCode to insert BOM.
run eslint filename.js this will throw illegal whitespace error on 1:1

if we copy BOM and paste it into file using normal text editor, no irregular whitespace error is thrown by linter

Reproduces without extensions: No (since eslint is disabled)

@aaayushsingh can you please file the issue against VS Code directly since the ESLint extension is not involved in this using the same steps as provided here.

As reported in https://github.com/Microsoft/vscode/issues/39258#issuecomment-348209471 it looks like a quick fix was used to "fix the bom" issue. That quick fix is not from VS Code.

@bpasero thanks. I interpreted use VSCode to insert BOM as your save with BOM action.

API request is: https://github.com/Microsoft/vscode/issues/39558

Apparently vscode removes BOM from file before loading it into memory. That could be a reason why vscode-eslint can't detect BOM and double BOM is inserted on saving.

Exactly. This is what I was trying to say. However to find that out I need the API request.

It might be possible to use https://github.com/owent-contrib/vscode-clang-format-provider/commit/86e773b4acce9e14b8610d2576c11fb56de43433 as inspiration for a workaround

@andrewmiller1 the ESLint extension depends on the ESLint module (https://github.com/eslint/eslint) for this. The reason why this fails right now is that the checking happens in memory to get validation on type and not only on save. The content in memory doesn't have a BOM hence ESLint complains correctly about it.

The corresponding VS Code issue https://github.com/microsoft/vscode/issues/39558 which I need to address this got closed as out of scope. Will close this one as well since there is nothing I can do without the additional API.


HowTo: git diff

This seems like it should be trivial, but I've been digging around in the repo, code, and old issues for an hour now. Sorry if I've complete missed it.
How can I get a string of the result of git diff <file>
$ git diff test
diff --git a/test b/test
index 9daeafb..4b410d3 100644
--- a/test
+++ b/test
@@ -1 +1 @@
-test content
+tested content

No exactly what your after I think, but I just found this https://godoc.org/gopkg.in/src-d/go-git.v4/plumbing/object#Tree.Diff which provides the changes between two trees

Thanks Ben. I did see the difference between two trees, but I can't figure out how to apply that to the case where there is uncommitted code, which this git diff is to display the diff between head and uncommitted code.

Hey @dustingraham,
There currently isn't support for diffing file contents in this library. In the past I've used sergi/go-diff for diffing byte slices. There are a handful of other libraries available that do something similar.
We are definitely open for contribution to anyone who'd like to add diff support for git blobs.
Cheers

Although, there may not be enough information in a File to produce the necessary Change and ChangeEntry structs (because we need information about the parent tree and full path). Maybe instead we need an API at the (*Tree) level that allows filtering down to only certain file paths? Perhaps:
plubming/object.(from *Tree).DiffPaths(to *Tree, paths ...string) (Changes, error)
@mcuadros, thoughts?

@orirawlings Does this approach handle staged / added changes? (because staged changes are not shown in git diff)
I don't understand where do the two trees come from (we are comparing the current files with staged/added files)

Files in the staging area are not yet referenced by tree objects (which are not created until commit). So no, these APIs would probably not be used for diff-ing the staging area against committed files.

@orirawlings You mentioned "Turns out, there IS support for producing content diffs, but the API doesn't expose anything directly for diffing plubming/object.(*File)" could you point me to an example that showcases producing content diffs between two tree (in my case, I'm interested in diff a commit with the parent commit(s)).
Doing a rewrite of https://github.com/zricethezav/gitleaks and want to build it with src-d's go-git plumbing


fix: [#1340] Calendar Skill - Marking an event tentative throws an error to the user

Fixes # 1340
#minor
Purpose
This PR fixes the error thrown when marking an event as tentative.
It was trying to send a response when the event's organizer had disabled the responses for the event.
The same fix was applied to accept and decline event actions.
Also, it fixes the error thrown when the organizer tries to respond to its own event.
Changes

Updated RespondToEventDialog.dialog:

Moving the actions inside the elseActions block in the event.isOrganizer condition.
Adding a condition to evaluate event.responseRequested property before sending the responses.
Passing the event property instead of only the event.Id to update the event.

Updated RespondToEventDialog.en-us.lg including 3 new activities in the case the event's responses are disabled.
Updated CalendarSkillEventModel class including the mapping for the ResponseRequested property.

Tests
These images show the calendar bot working as expected in the different scenarios.

/promoted 1374


Skeleton Poser issue on Oculus

Hello there,
We've been implementing the poser system for our game without a problem for both Vive controllers and Knuckles. Recently when trying it out on Oculus, we've discovered that the pose system drift the grabbed object out of alligment by a hand aproximately.
No error reports have been warned to indicate what could be causing the error.

Pretty sure this has been fixed. If not please create a new issue with repro steps and ideally an example project. Thanks!


Update EXT_NRAYTRACING.md

Hi @mads-bertelsen,
Suggested updates:

Use polarisation rather than spin
UnitDimension for weight should be n/s

I am unsure about the n/s as it can not really be expressed in terms of SI units, which is what the 7 numbers express afterwards. I guess technically the unit should be mol/s, but it seems wrong.


Multiple pages when clicking on "Go back home" button

🐛 The bug
There's a bug with @nuxtjs/tailwindcss that'll make the tailwind's viewer not work when accessing it from the devtool.
Once faced with the 404 we have a button to go back home which I assume should take me back to the devtool's home page.
It does indeed but while doing so it also open a nested devtool page and repeats this behaviour everytime the same button is clicked

🛠 To reproduce
https://stackblitz.com/edit/nuxt-starter-jwoekj?file=nuxt.config.ts
🌈 Expected behavior
I suppose it should just take me back to the homepage without opening an actual page.
Best behaviour would be to actually have access to Tailwind's viewer but I suppoe that an issue with @nuxtjs/tailwindcss
ℹ Additional context
No response

I am not sure if there is anything that can be done on the DevTools side. As we give an iframe to the custom tab, and how it renders is up to the module to control. I think it should be fixed on the tailwind module


Binding issues inside ListView

I have a view with a list of items fetched from the variable items which is of type ObservableArray<Observable<item>>
<ActionBar title="My App" class="action-bar">
</ActionBar>
<StackLayout class="page">

    <ListView [items]="items" class="list-group">
      <ng-template let-item="item" let-i="index">
        <ng-container *ngIf="(item | async) as itm">

        </ng-container>
      </ng-template>
    </ListView>

    <ng-container *ngIf="(items.getItem(0) | async) as itm">

    </ng-container>
</StackLayout>

Here, the ng-template gets generated but the contents inside the template doesn't showup.
I can verify that the item Observable gets subscribed by adding a log before the Observer.next of that Observable.
What should I do to get this right?
Here is the minimal project:
ListBinding.zip

@Jai-Krish you are using ObservableArraybfrom NativeScript core modules along with RxObservable from rxjs. I would suggest using only one of the concepts preferably the Angular one (Rxjs) entirely in your implementation. You can also directly create the async pipe for your items source instead of using structural directive depending no the same asynchronous source. Example of async pipe with RxObservable source can be found here

@NickIliev As shown in the example, I've converted the items into Observable<Array<Observable<Item>>> and also changed the template into <ListView [items]="items$ | async" class="list-group"> but still it just shows the empty Labels without any text in it. Since I'm fetching these items from a real time database, I definitely need to listen to them individually for changes thats why the every item is being served from an Observable.

<ListView [items]="groceryList" row="0" class="small-spacing" [class.visible]="listLoaded" >

<StackLayout orientation="horizontal" (longPress)="itemSelect(item)" >
<CheckBox  width="40" #CB1 [checked]="item.isSelected" class="medium-spacing" visibility="{{isCheckBoxVisible === 'visible' ?'visible' : 'collapsed'  }}">

itemSelect(item:Order){
this.isCheckBoxVisible = 'collapsed';
this.isImageVisible = 'visible';
}
Checkbox and Image visibility is not binding for me as well.

@nmongiya are you still experiencing this issue? Let me know and log a new separate issue if you have project to reproduce this behavior with the latest tns-core-modules and nativescript-angular.


ClusterOutput is running even with the wrong credentials.

Describe the bug:
We have passed the wrong credentials while passing the logs to the aws, cloudwatch, etc. But the cluster output/output doesn't show any errors while passing wrong credentials. The error is only shown in fluentd logs. Can the error message be shown if the logging operator is unable to connect with AWS, cloudwatch, or another provider?
Expected behaviour:
While passing the wrong credential while creating clusteroutput/output the clusteroutput should show the error. The error is only shown on fluentd logs. I need to show the error message if the logging operator is unable to connect with AWS, cloudwatch, or another provider in my application. I have difficulties showing the error message if the logging operator cannot connect with the aws or another provider in my application. As I cannot show the error by filtering the logs from fluentd.
Environment details:

Kubernetes version (e.g. v1.15.2):v1.25.12
Cloud-provider/provisioner (e.g. AKS, GKE, EKS, PKE, etc):
logging-operator version (e.g. 2.1.1):3.17.10
Install method (e.g. helm or static manifests): helm
Logs from the misbehaving component (and any other relevant logs):
Resource definition (possibly in YAML format) that caused the issue, without sensitive data: Logging CRD v1beta1

/kind bug

There is no method currently to highlight the fact that fluentd cannot connect to an output in the output status directly. However you can use the timeout based configcheck strategy that will at least prevent the configuration to take effect and you can understand the issue from the configcheck pod output directly.
See an example here or in the latest release update: https://kube-logging.dev/docs/whats-new/
Note: you have to upgrade to 4.4 to have this

I want to contribute in the code and create the method that will update the status of output to false if the fluentd have errors while passing wrong credentials. Are there any contributing guides or guidelines for this repo as I will be droping a PR.

Please join our discord to have a discussion about the implementation plan first: https://discord.gg/NAuSQUAdF9