VS Code freezes debugging ASP.Net Core application

Environment data
Version:          Code 1.30.2 (61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8, 2019-01-07T22:54:13.295Z)
OS Version:       Windows_NT x64 10.0.15063
CPUs:             Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz (4 x 2712)
Memory (System):  7.86GB (1.54GB free)
VM:               0%
Screen Reader:    no
Process Argv:
GPU Status:       2d_canvas:                    enabled
                  checker_imaging:              disabled_off
                  flash_3d:                     enabled
                  flash_stage3d:                enabled
                  flash_stage3d_baseline:       enabled
                  gpu_compositing:              enabled
                  multiple_raster_threads:      enabled_on
                  native_gpu_memory_buffers:    disabled_software
                  rasterization:                enabled
                  video_decode:                 enabled
                  video_encode:                 enabled
                  webgl:                        enabled
                  webgl2:                       enabled
CPU %   Mem MB     PID  Process
    0       68   16920  code main
    0      115   17476     gpu-process
    0      231   17896     window (XXXXX.html - XXXXX - Visual Studio Code)
    0       47   13324       C:\Users\XXXXX\.vscode\extensions\ms-vscode.csharp-1.17.1\.debugger\vsdbg-ui.exe
    0        6    9100         console-window-host (Windows internal process)
    0      151   13712         "C:\Program Files\dotnet\dotnet.exe" C:\Users\XXXXX\Documents\Source\Repos\XXXXX\src\XXXXX\bin\Debug\netcoreapp2.1\P3Group.Daimler.Trucks.QPortal.dll
    0        6   19140           "cmd" /c npm run start -- --port 50198
    0       26   15884             electron_node npm-cli.js
    0        6   17080               C:\Windows\system32\cmd.exe /d /s /c ng serve "--port" "50198"
    0      506    1208                 node   "C:\Users\XXXXX\Documents\Source\Repos\XXXXX\src\XXXXX\ClientApp\node_modules\.bin\\..\@angular\cli\bin\ng" serve "--port" "50198"
    0      175   17696                   electron_node worker.js
    0       21   17552       searchService
    0       11   18084       electron-crash-reporter
    0       14   18152       watcherService
    0        6   18164         console-window-host (Windows internal process)
    0       91   18216       extensionHost
    0       31   17568         "C:\Users\XXXXX\AppData\Local\Programs\Microsoft VS Code\Code.exe" "c:\Users\XXXXX\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\html-language-features\server\dist\htmlServerMain" --node-ipc --clientProcessId=18216
    0       29   19040         C:\Users\XXXXX\.vscode\extensions\ms-vscode.csharp-1.17.1\.razor\rzls.exe -lsp --logLevel None
    0        6   19108           console-window-host (Windows internal process)
    0        5   19264         cmd /s /c "C:\Users\XXXXX\.vscode\extensions\ms-vscode.csharp-1.17.1\.omnisharp\1.32.8\OmniSharp.exe -s c:\Users\XXXXX\Documents\Source\Repos\XXXXX\XXXXX.sln --hostPID 18216 --stdio DotNet:enablePackageRestore=false --encoding utf-8 --loglevel information --plugin C:\Users\XXXXX\.vscode\extensions\ms-vscode.csharp-1.17.1\.razor\OmniSharpPlugin\Microsoft.AspNetCore.Razor.OmniSharpPlugin.dll formattingOptions:useTabs=false formattingOptions:tabSize=4 formattingOptions:indentationSize=4"
    0        6   19292           console-window-host (Windows internal process)
    0       93   19336           C:\Users\XXXXX\.vscode\extensions\ms-vscode.csharp-1.17.1\.omnisharp\1.32.8\OmniSharp.exe  -s c:\Users\XXXXX\Documents\Source\Repos\XXXXX\XXXXX.sln --hostPID 18216 --stdio DotNet:enablePackageRestore=false --encoding utf-8 --loglevel information --plugin C:\Users\XXXXX\.vscode\extensions\ms-vscode.csharp-1.17.1\.razor\OmniSharpPlugin\Microsoft.AspNetCore.Razor.OmniSharpPlugin.dll formattingOptions:useTabs=false formattingOptions:tabSize=4 formattingOptions:indentationSize=4
    0       61   18268     shared-process
Workspace Stats:
|  Window (XXXXX.html - XXXXX - Visual Studio Code)
|    Folder (XXXXX): 2989 files
|      File types: js(943) dll(280) scss(232) html(178) md(175) cs(162)
|                  json(134) css(130) map(99) png(98)
|      Conf files: package.json(23) tsconfig.json(4) csproj(3) tslint.json(2)
|                  grunt.js(2) sln(1) launch.json(1) settings.json(1)
|                  tasks.json(1)
|      Launch Configs: chrome coreclr

VS Code version: 1.30.2
C# Extension version: 1.17.1
Problem
I am debugging a fairly simple ASP.Net Core application and it freezes the whole VS Code window. The system is still running smoothly. VS Code doesn't respond to clicks or keystrokes and I am not even able to abort the debugging session.
Looking at the environment data the freeze seems to come from the C# extension. I never had problems debugging this application before and a restart doesn't fix the problem either. Is there any other information I can attach to this bug report?

+1
The CPU usage seems to be exaggerated when the VS Code window is out of focus with the debug console active. If the window is still somewhat responsive, clearing the Debug Console output alleviates the issue for a short while.

cc @gregg-miskelly

Same problem, any solution?

Are there any solutions to this? My vscode freezes for up to 20 seconds when a breakpoint is reached or any exception in my code  was thrown.


roles is not working with hardening umask

with a hardening umask, the role is not working due to 2 failing parts :
ssl part
i have modify the ssl.yml to add mode :
  - name: Ensure Sensu SSL directory exists
    file:
      dest: "{{ sensu_config_path }}/ssl"
      state: directory
      owner: "{{ sensu_user_name }}"
      group: "{{ sensu_group_name }}"
      mode: "0755"
    when: sensu_ssl_gen_certs and sensu_ssl_manage_certs

  - include: ssl_generate.yml
    when: sensu_ssl_gen_certs
    static: false

  - name: Deploy the Sensu client SSL cert/key
    copy:
      src: "{{ item.src }}"
      owner: "{{ sensu_user_name }}"
      remote_src: "{{ sensu_ssl_deploy_remote_src }}"
      group: "{{ sensu_group_name }}"
      dest: "{{ sensu_config_path }}/ssl/{{ item.dest }}"
      mode: " {{ item.perm }}"
    with_items:
      - {src: "{{ sensu_ssl_client_cert }}", dest: cert.pem , perm: "0644" }
      - {src: "{{ sensu_ssl_client_key }}" , dest: key.pem  , perm: "0640" }
    notify: restart sensu-client service
when: sensu_ssl_manage_certs

--> this modification can also improve the security : previously  if the umask was too open, the key.pem was readable by everybody
plugins part
(we use sensu_user_name = sensu )
sensu-install -p will install plugings not readable by every body , my modification :
  - name: Ensure any remote plugins defined are present
    shell: umask 0022; sensu-install -p {{ item }}
    with_items: "{{ sensu_remote_plugins }}"
    changed_when: false
when: sensu_remote_plugins > 0

If it's installing plugins with "bad" umask, sensu service failed to start :
/etc/init.d/sensu-client start
Starting sensu-client/opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/stub_specification.rb:111:in `initialize': Permission denied @ rb_sysopen - /opt/sensu/embedded/lib/ruby/gems/2.3.0/specifications/net-ldap-0.11.gemspec (Errno::EACCES)
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/stub_specification.rb:111:in `open'
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/stub_specification.rb:111:in `data'
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/stub_specification.rb:202:in `valid?'
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/specification.rb:749:in `select'
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/specification.rb:749:in `gemspec_stubs_in'
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/specification.rb:774:in `block in map_stubs'
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/specification.rb:771:in `each'
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/specification.rb:771:in `flat_map'
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/specification.rb:771:in `map_stubs'
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/specification.rb:763:in `installed_stubs'
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/specification.rb:831:in `stubs'
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/specification.rb:1036:in `find_by_path'
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems.rb:209:in `try_activate'
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/core_ext/kernel_require.rb:126:in `rescue in require'
	from /opt/sensu/embedded/lib/ruby/site_ruby/2.3.0/rubygems/core_ext/kernel_require.rb:40:in `require'
	from <internal:gem_prelude>:6:in `<internal:gem_prelude>'

https://github.com/sensu/sensu-ansible/pull/132 should have taken care of this, let me know if you hit anything else!


Ss.alignement of totals

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] The code follows the code style and conventions of this project.
[ ] The change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.

Description of the change
Alignment of summaries of map control.
...
Motivation for the change

...

@swetha571,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: swetha571 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


support for Resnet50 V1.5

Modified argmax layer to support INT64 type ouput

Modified anntest.cpp to support INT64 type output

Modified tensor_matrix_multiply layer to support all combinations of 2D tensors

Modified model_compiler for argmax and matmul

@LakshmiKumar23 let me know when this is ready to be merged

@kiritigowda This is ready to be merged as soon as @rrawther approves it.

@kiritigowda ready to be merged


Removed heardcoded 10 second timeout for an activity under test

What was changed
Removed hardcoded 10-second timeout for TestActivityEnvironment.
Why?
We want to support unit testing activities that take longer than 10 seconds.
Reported at https://community.temporal.io/t/activities-run-in-tests-using-testactivityenvironment-intermittently-fails-with-java-util-concurrent-timeoutexception/10397/3

Just wondering, when would this change be available? If it's on the next release, would it be possible to know approx. when that would be?


Setting IndentBlanklineContextChar highlights

Hello, I'm struggling to override the default highlight colour for show_current_context. As can be seen in my config, I am setting the appropriate highlight group. However, the colours do not appear unless I explicitly run the command again manually (:highlight IndentBlanklineContextChar guifg=#C678DD gui=nocombine) once nvim loads. Not sure if this is due to Packer being annoying, or if reset_highlights isn't working properly.
My configuration can be found here
Thanks!
VimEnter:

Manual highlight (expected behaviour):

Most color schemes reset all highlight groups when they load.
Can you try to set the highlight group after you load your color scheme?

Unfortunately I've tried that already but it still doesn't work :(

It gets overwritten somewhere, that's the only explanation.
You can check where it was last set with :verbose highlight IndentBlanklineContextChar

I've tried manually setting it after applying any colorschemes, as well as at the end of my nvim config, yet it still does not seem to work. The verbose command also says Last set from anonymous :source, which may or may not be Packer.

You could try to run an autocommand after the color scheme is set with autocmd ColorScheme *
But sorry, I can't really help you with this, you need to debug your config.
This is not a bug of the plugin.

Thanks for the help! Unfortunately, the autocmd didn't work, but it turns out that my material.nvim theme overrode its highlights.


Detach generation of derivation to make it modular

Currently, Nixago is tightly bound to CUE. This decision was made early on due to the capabilities CUE provides in terms of validating and generating configuration files. However, recent refactors of Nixago have allowed the backend system generating configurations to be modularized.
This issue proposes the following:

[ ] Standardize generate such that it only relies on invoking an expression that generates a derivation.
[ ] Implement a backend system for defining backends capable of generating derivations for usage by generate.
[ ] Migrate eval to be a backend that uses CUE for generating derivations.
[ ] Modify the request module to integrate the new backend system.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/validate-and-generate-configuration-files-using-nix-and-cue/19326/6

After further offline discussions, it's been decided that along with this refactor, we should move away from CUE and use pkgs.formats by default.
This will be accomplished by abstracting the generation utility into an engine. Thus, Nixago can work with any number of engines. The sole job of an engine is to produce a derivation that generates the desired configuration file. One could use CUE, Nickel, Dhall, etc. to accomplish this.


React Native Support

Is your feature request related to a problem? Please describe.
openlayers does not work with React Native because it depends on the "document" concept (and maybe for more reasons). As a developer I'd like to be able to use openlayers in my react native app.
Describe the solution you'd like
The ability to use openlayers in react native.

Can you provide a minimal example of the code you are trying to run and describe what you expect it to do?  Not all of OpenLayers relies on the DOM.

Hi
I had the same problem trying to show a map with openlayer on React Native / Android app
    this.olMap = new OLMap({
        layers: [
            new TileLayer({
                source: new XYZ({
                    url: 'https://server.arcgisonline.com/ArcGIS/rest/services/World_Imagery/MapServer/tile/{z}/{y}/{x}',
                    maxZoom: 19
                })
            }),
            new VectorLayer({source: new Vector({features: []})})
        ],
        view: this.view,
        target: this.target
    });

First problem was the dependency to fs, that I solved by doing a patch / removing the GeoTiff feature.
But the whole map display seems to be relying on documents and div, so it will be so much more complicated to do :/


How to keep reference to a connection?

I need to keep a reference to a specific connection, how can I do this?
Problem is, I want to make use of advisory locks, but this kind of lock is bound to the connection that started the lock, so I need to query the same connection from that point on until I release that lock. Releasing that lock must be done through the same connection again of course.

You can use Pool::extractConnection() to extract a single connection object from the pool. Once you're done with the connection it is destroyed instead of being put back in the pool

Ah great, I must have missed that method, thanks!


Bot: Missing THREAD_MEMBER_UPDATE in createBotGatewayHandlers

We have a threadMemberUpdate handler in createEventHandlers, but not in createBotGatewayHandlers.
reported by @Larsundso and @AwesomeStickz

Fixed in node branch


chore(release): 1.151.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 7a1451f7fa3550baef49e3200bf466baabb36968
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 15aaad634b0ad34febff540ebbe672231421c16d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 15aaad634b0ad34febff540ebbe672231421c16d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 7a1451f7fa3550baef49e3200bf466baabb36968
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 735c6d27c79d6633dd5713b9bd98a52937853f9b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 735c6d27c79d6633dd5713b9bd98a52937853f9b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


CAMEL-12908: Cannot start route using rest dsl due to a mysterious  duplicate route id

@davsclaus could you please to look at PR

Thanks @onderson and @oscerd


Datagrid: Content doesn't align well when icon and button are present in cell

Describe the bug
We have UX design where we have buttons/icons in datagrid cell. However after putting the Clarity button (with btn-sm) and icon (with default size 16px), the datagrid overall alignment is not ideal and the rows (normally has height as 35px with text only) get expanded.
How to reproduce
https://clarity-light-v1-0-datagrid-with-button-and-icon.stackblitz.io

Expected behavior
As a component consumer using only Clarity elements (datagrid, clr-icon and button), I'm expecting this to work out of the box. Expanding rows might be ok but the current alignment doesn't look pleasing to the user.
I have to do CSS overrides on the data grid cell to make it look satisfying and match our design, which in my opinion is not a sustainable approach as it depends on existing Clarity styles.
Versions
App

Angular: 7
Clarity: 0.13.8, also reproduce in 1.0 in above link.

Device:

OS: Mac OS
Browser: Chrome latest.

Hi @yaooluu.
Datagrid cells will grow to fit the content thats put inside of them, I think it would be better to remove the margin from the element (button e.g) with a class that only gets added to elements in datagrid cells that have a margin already applied to them:
<button class="btn btn-sm dg-cell-element">Action</button>

css
.dg-cell-element {
  margin: 0;
}

I'm leaving this open since I know there has been some internal discussion re: the margin around buttons and the issues that are caused by it. @colinreedmiller - am I correct that there was discussion re: removing the margins from buttons as part of the Hawaii refresh? If so could this issue be closed?

There are a couple factors at play re: margins.

We have some irregularities regarding margins and padding, and they effect the vertical rhythm and create layout concerns that require overrides such as in this issue. I'd like to address this as part of HawaiiFresh but @mathisscott and I need to examine the systemic consequences of opening this up.
Regardless of what we do with our layout attributes and paradigm, we need to start being thoughtful about 44px touch targets for WCAG 2.1 - unless buttons grow to 44px tall there is some handling of the area around them that we we need to be mindful of @chlane might contribute some insight since it is somewhat complex regarding what is AA vs AAA / mobile / responsive etc.

Regarding this issue: I agree with @hippee-lee suggestion of overriding the margin - it is consistent to the way other spacing issues are currently handled.


Fix doctest

Closes #111

Thanks @KristianHolsheimer! It was my intention to update the docs to use plain dict (we're hoping to make this the default soon) since they are a little less verbose like that, and additionally "FlatMapping" itself should not be an important detail (this type is just a regular Mapping that is faster to use with JAX).
I think the reason our GitHub actions tests are failing here is because we set the env var (HAIKU_FLATMAPPING) controlling dict vs. FlatMapping in if __name__ == '__main__' but when running under pytest this block is not evaluated. I'll fix this forward in #113.

Ah I see, yeah that makes more sense. Thanks!


1.6.0 fails to start even though VM appears to be up

Boot2Docker-cli version: v1.6.0
Git commit: 9894ae9
2015/04/16 22:51:10 executing: C:\Program Files\Oracle\VirtualBox\VBoxManage.exe showvminfo boot2docker-vm --machinereadable
2015/04/16 22:51:11 executing: C:\Program Files\Oracle\VirtualBox\VBoxManage.exe guestproperty set boot2docker-vm /VirtualBox/GuestAdd/SharedFolders/MountPrefix /
2015/04/16 22:51:11 executing: C:\Program Files\Oracle\VirtualBox\VBoxManage.exe guestproperty set boot2docker-vm /VirtualBox/GuestAdd/SharedFolders/MountDir /
2015/04/16 22:51:12 executing: C:\Program Files\Oracle\VirtualBox\VBoxManage.exe sharedfolder add boot2docker-vm --name c/Users --hostpath C:\Users --automount
VBoxManage.exe: error: Shared folder named 'c/Users' already exists
VBoxManage.exe: error: Details: code VBOX_E_OBJECT_IN_USE (0x80bb000c), component SessionMachine, interface IMachine, callee IUnknown
VBoxManage.exe: error: Context: "CreateSharedFolder(Bstr(name).raw(), Bstr(hostpath).raw(), fWritable, fAutoMount)" at line 1008 of file VBoxManageMisc.cpp
2015/04/16 22:51:12 executing: C:\Program Files\Oracle\VirtualBox\VBoxManage.exe setextradata boot2docker-vm VBoxInternal2/SharedFoldersEnableSymlinksCreate/c/Users 1
2015/04/16 22:51:12 executing: C:\Program Files\Oracle\VirtualBox\VBoxManage.exe startvm boot2docker-vm --type headless
Waiting for VM "boot2docker-vm" to power on...
VM "boot2docker-vm" has been successfully started.
error in run: Failed to start machine "boot2docker-vm": exit status 1
Interestingly, boot2docker status still claims poweroff state.

@ndarilek can you please run the command
boot2docker up -v

and paste the output here?

I already have, the bug report is a up -v transcript.
I did seem to fix the issue by uninstalling/reinstalling VirtualBox. I had an older version installed. I forget, does the Boot2Docker installer install VirtualBox as well? If so, maybe there was an issue running the upgrade of the old install? We can close this if digging deeper into what may have failed isn't worthwhile, but the failure persisted across several reboots and didn't go away until the reinstall of VB.

@ndarilek yeah it looks like external dependencies like VirtualBox and Git are causing various issues on various installations. I'm not even sure if it's a version problem or a config issue. We're seeing similar issues at #102.
@ndarilek if you run the Boot2Docker installer again, you'll see that the install checkbox next to VirtualBox is unchecked if any VirtualBox installation exists on the system at that time. If not checked, it doesn't install vbox. If it is checked, then it installs the vbox version bundled with the B2D installer MSI. (see this code)

Sorry, this repository is long-since deprecated in favor of Docker Toolbox (whose usage is now also discouraged in favor of Docker for Windows and Docker for Mac).


Update contributors information

Add additional contributors (will be displayed on site\team-list.html page)

Thanks for adding me ;)
:+1:


Grammar for Elisp mistakes ?"  as beginning of string

The Elisp syntax for " as a character literal is ?"
The highlighter doesn't recognize it, and highlights everything that follows as a string.
Example:
https://github.com/emacsmirror/paredit/blob/master/paredit.el#L790

I just ran into this bug as well. Here's another example: https://github.com/syohex/emacs-editutil/blob/master/editutil.el#L131

I'm afraid this is a bug with the Elisp grammar. Please could you report this issue here: https://github.com/textmate/lisp.tmbundle

Oh right.. looks like there's already an issue for this here: https://github.com/textmate/lisp.tmbundle/issues/1

Looks like that project is a little stale (no updates for a couple of years). It might be worth looking for alternative grammars? You can test them here: https://lightshow.githubapp.com/


chore: update directory structure for monorepo

The goal of this PR is to update directory structure to match monorepo:

src -> packages/react/src
test -> packages/react/test
types/utils.d.ts -> packages/react/types

Why so simple?
This allows to avoid us merge conflicts and super big PRs from one side. From other side this allows to focus on other changes in tooling separately.
I will introduce Lerna setup in other PR.

[x] yarn test
[x] yarn lint
[x] yarn start
[x] yarn build
[x] yarn perf

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


Switch to Chalk recursive solver

Before:
Expressions of unknown type: 5526 (3%)
Expressions of partially unknown type: 5415 (3%)

After:
Expressions of unknown type: 4600 (2%)
Expressions of partially unknown type: 4645 (2%)

On the other hand,
'./target/release/rust-analyzer analysis-stats -q . # old solver' ran
    1.24 ± 0.04 times faster than 'rust-analyzer analysis-stats -q . # new solver'

I think part of this just comes from the fact that we're inferring more types now; but apart from that, it should be possible to improve the performance a bunch, and I'll make looking into that a priority.

bors r+
Might be a good idea to run through issues linked to https://github.com/rust-analyzer/rust-analyzer/issues/2603 and add tests


[DOC]: Sphinx theme doesn't expand header backgrounds for long headers

How would you describe the priority of this documentation request
Low (would be nice)
Please provide a link or source to the relevant docs
https://docs.nvidia.com/morpheus/_modules/morpheus.messages.multi_inference_ae_message.MultiInferenceAEMessage.html
Describe the problems in the documentation
For long headers, which are common in the API build where the H1 is the fully qualified Python name, the black background doesn't extend horizontally to match the content.
ex the API docs for morpheus.messages.multi_inference_ae_message.MultiInferenceAEMessage

(Optional) Propose a correction
Update the CSS for our Sphinx theme
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I have searched the open documentation issues and have found no duplicates for this bug report

Fixed in #547


how to keep alive connection with php?

PLEASE DO NOT POST A QUESTION HERE.
This form is for bug reports and feature requests ONLY!
For general questions and troubleshooting, please ask/look for answers at StackOverflow, with "grpc" tag: https://stackoverflow.com/questions/tagged/grpc
For questions that specifically need to be answered by gRPC team members, please ask/look for answers at grpc.io mailing list: https://groups.google.com/forum/#!forum/grpc-io
This issue will be closed down once seen by the repo managers.

See https://github.com/grpc/grpc/blob/master/doc/keepalive.md

Since this ranks on google... the keepalive params (and all the other) are listed on https://github.com/grpc/grpc/blob/v1.36.x/include/grpc/impl/codegen/grpc_types.h
Pass options into the channel as an array, eg
$opts = ['grpc.keepalive_time_ms' => 2000];
...


Source labels for dimensions

The labels for the dimensions need to be sourced like they do in BLW.

[x] Basic version with statically generated labels (generated via SPARQL)
[ ] Refactored version that sources them directly from the dimension pipeline

That's now done via the postinstall step that fetches it from SPARQL. This is still kind of chicken-egg as it can be that we don't have labels the first time a new dimension is published.
We could probably generate that from the dimensions pipeline and make sure that those are run before the cubes itself.


Change to LoggingEventBuilder

Description

Updates the static key string to a static start JSON string which reduces the number of StringBuilder.append calls
context is tracked as null initially instead of Collections.emptyList()
addKeyValue(String, Object) no longer eagerly converts the object to string and defers that until log time
Split performLogging into two methods, one which has message formatting and another overload with no message formatting to remove a useless call to MessageFormatter.arrayFormat(format, args)
Many single character String appends replaced with char appends
Simplified type checking on Object to determine if it needs to be quoted
Added simple check to determine when to add a , to remove a deleteCharAt call

All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Make emitFile ensure the folders exists prior to writing to path

Fixes #1178.
This is just a port of what I did in Cadl APIView.

@nguerrera thanks for the review. All comments should be addressed now.


Add transport.closing property

In aiohttp project I have an issue (KeepSafe/aiohttp#370).
Long story short: for handling static files aiohttp uses code like:
        with open(filepath, 'rb') as f:
            chunk = f.read(self.limit)
            while chunk:
                resp.write(chunk)
                yield from resp.drain()
                chunk = f.read(self.limit)

When client closes HTTP connection (by socket shutdown for example) transport._force_close(...) schedules _call_connection_lost on next loop iteration and assigns transport._closing flags (as well as transport._conn_lost).
Actual transport closing will be done on next loop iteration, but aiohttp static file handler has no chance to be informed about transport closing: stream.write() and underlying transport.write() don't check for ._closing flag and always succeed.
transport.write() does check for ._conn_lost but sends log message only, not raises exception -- and the behavior is pretty correct.
aiohttp static file handler sends no data on resp.write(chunk) call, stream buffer is never overloaded and yield from resp.drain() always returns without pausing.
Thus all multi-megabyte file may be iterated over and pushed into stream. Actual data will not be sent via wire of course but the whole process is
a) takes longer than required
b) sends a lot of warning messages 'socket.send() raised exception.' to asyncio logger
I propose to add public readonly bool property .closing (return ._closing internal value).
It gives me a way to check if transport is on the middle of closing procedure.
aiohttp.StreamWriter also should be modified: I guess to add .closing property to StreamWriter to mimic transport.
StreamWriter.drain() coroutine should check for stream.closing first and call yield from asyncio.sleep(0) to run previously scheduled transport._call_connection_lost at first.
Sorry for long message, I hope I've described my problem well enough. Feel free to ask if my (complex enough) scenario is still unclean.
If no objections I will prepare a patch.

+1
I don't understand everything, but I trust in you to push a good solution in aiohttp ;-)

I propose to add public readonly bool property .closed (return ._closed internal value).
It gives me a way to check if transport is on the middle of closing procedure.

The fact that '.closed' will be set while the transport is in the process of being closed (not already closed) bothers me a bit, but I think I'm OK with that.
Would be great to hear what @gvanrossum and @haypo think about this first.

Sorry, I have no bandwidth left until PEP 484 is squared away.
On Thu, May 21, 2015 at 1:42 PM, Yury Selivanov<EMAIL_ADDRESS>wrote:

I propose to add public readonly bool property .closed (return ._closed
internal value).
It gives me a way to check if transport is on the middle of closing
procedure.
The fact that '.closed' will be set while the transport is in the process
of being closed (not already closed) bothers me a bit, but I think
I'm OK with that.
Would be great to hear what @gvanrossum https://github.com/gvanrossum
and @haypo https://github.com/haypo think about this first.
—
Reply to this email directly or view it on GitHub
https://github.com/python/asyncio/issues/248#issuecomment-104415036.

--
--Guido van Rossum (python.org/~guido)

Sorry, I have no bandwidth left until PEP 484 is squared away.

Absolutely NP. We can consider this even after beta-1, right?

For such a small thing, yes.
On Thu, May 21, 2015 at 1:56 PM, Yury Selivanov<EMAIL_ADDRESS>wrote:

Sorry, I have no bandwidth left until PEP 484 is squared away.
Absolutely NP. We can consider this even after beta-1, right?
—
Reply to this email directly or view it on GitHub
https://github.com/python/asyncio/issues/248#issuecomment-104417980.

--
--Guido van Rossum (python.org/~guido)

@1st1 Sorry, .closed should be .closing. My bad. I've updated my first post.
.closing is False both on connection establishment (until protocol.connection_made() called) and on socket handling stages.
After scheduling ._call_connection_lost() procedure .closing becomes to be True.
After protocol.connection_lost() call it's still True.
I don't think we need .closed property -- protocol.connection_lost() provides transport state change explicitly.
But in time window between disconnection scheduling and actual transport closing the .closing flag may be useful for prevention writing data to the transport.
And, as I've mentioned above, asyncio stream writer may use .closing to waiting for actual closing in .drain() coroutine.

transport.write() does check for ._conn_lost but sends log message only, not raises exception -- and the behavior is pretty correct.

Wait, I'm not sure that it is a good design to not raise an exception here.
Would it be an issue to modify transport.write() to raise an exception if transport.close() was just closed?
What is the use case of calling write() just after close()?

pause_reading() and resume_reading() methods of transports already raises a RuntimeError if the transport is being closed.
IMHO pause_writing() and resume_writing() methods of StreamReaderProtocol and SubprocessStreamProtocol should also raise an exception if the transport is being closed. So I agree that a closing property (or method?) is needed.
Example of patch (PoC) to check the closing attribute of transport: https://gist.github.com/haypo/a8a38ae21d50cd42adce (proactor_events.py should also be modified).
If we block write() after close(), should we also block write_eof()? Currently, write_eof() can be called on a closed socket. It probably fails, since self._sock attribute is set to None in _call_connection_lost().

This is exactly my problem as well.  But I would go one step further: StreamWriter.write() should raise an exception if the underlying transport is closed or closing.

I created the pull request https://github.com/python/asyncio/pull/257 to fix this issue.
I have question: should transport.closing should return True or False when the transport is closed (which is different than being closed or "closing")?

My pull request disallow write operations on transports when the transport is closing. It may break application. It would feel more confident if you can try it on your favorite asyncio library or application.

+1
I need the closing attribute too in pulsar project.
Whether or not closing changes value to False after connection_lost is called is not very important in my case. However I would leave it as True even if the transport is actually closed.

Someone needs to make a PR that adds the is_closing() method to the Transport base class and to all its implementation subclasses.

Please see PR #291.

Closing the issue -- #291 has been merged. Thanks!


Multiple async validating fields

It seems, that in current design, it is impossible to show spinners for multiple asynchronously validated fields (since only "asyncValidating" field name is provided by the redux-form). Is there any way this will change in the future?

Wow, issue #900!
I'm not sure what you want. You could show spinners on everything if(this.props.asyncValidating). How would you specify a subset of them?

I would like something like the field.error, so there would be field.asyncValidating. Then I could show spinners to those properties, that are currently being validated.
So instead of writing:
<input type="text" placeholder="Username" {...username}/>
{asyncValidating === 'username' && <i /* spinning cog *//>}

I would write
<input type="text" placeholder="Username" {...username}/>
{username.isAsyncValidated && <i /* spinning cog *//>}

+1

What's the motivation behind this change?
The below snippet works as expected.
{asyncValidating === "username" &&
  <Icon glyph="cog" spin />
}

The only use case I see is for v6 API so when isAsyncValidating changes, the entire field gets recreated and then field !== nextField.

There might be more values, that are async validated simultaneously. Let's say, that I have username and email. I change both (or for example a form fill browser plugin changes them in the same time). Now, both fields are async validated, but redux-form doesn't say which fields are asyncValidated at the moment.

To clarify this issue:
In v6/v7 http://redux-form.com/7.0.3/docs/api/Field.md/#-code-meta-asyncvalidating-boolean-code- allows you to know if the validation function is being called because this field was blurred.
However, only one field can have this status at once, even if the validation from the first field has not returned before the second field is blurred.
I believe this enhancement is to allow for each validation call to be tracked to each fields asyncValidating individually, and when it returns change only that individuals prop, to allow overlap.


rqt_gui issue

When I try running "rosrun rqt_gui rqt_gui" in my terminal, I got a error :
Traceback (most recent call last):
  File "/opt/ros/melodic/lib/rqt_gui/rqt_gui", line 13, in <module>
    sys.exit(main.main())
  File "/opt/ros/melodic/lib/python2.7/dist-packages/rqt_gui/main.py", line 65, in main
    hash(os.environ['ROS_PACKAGE_PATH'])))
  File "/opt/ros/melodic/lib/python2.7/dist-packages/qt_gui/main.py", line 600, in main
    plugin_manager.discover()
  File "/opt/ros/melodic/lib/python2.7/dist-packages/qt_gui/plugin_manager.py", line 125, in discover
    self._plugin_menu.add_plugin(plugin_descriptor)
  File "/opt/ros/melodic/lib/python2.7/dist-packages/qt_gui/plugin_menu.py", line 82, in add_plugin
    self._enrich_action(action, action_attributes, base_path)
  File "/opt/ros/melodic/lib/python2.7/dist-packages/qt_gui/plugin_menu.py", line 133, in _enrich_action
    action_attributes['icon'], action_attributes.get('icontype', None), base_path)
  File "/opt/ros/melodic/lib/python2.7/dist-packages/qt_gui/icon_loader.py", line 46, in get_icon
    raise UserWarning('icon "%s" not found' % str(path))
UserWarning: icon "/opt/ros/melodic/share/rqt_virtual_joy/resource/input-gaming.png" not found

ROS Version- Melodic
I have also tried "sudo apt-get install ros-melodic-rqt" its showing that I have latest version than why is there a issue .
Please help!!!

similar error with rqt in foxy , but it change a little to line 11


how to build this?

could you please provide the detailed steps of building this app?

What platform are you on and what are you trying to build for?
For Linux you can just run
git clone --recursive https://github.com/Mobile-Artificial-Intelligence/maid.git
cd maid
source ./setup_flutter.sh
flutter build linux
With windows its very similar except instead of source ./setup_flutter.sh you just run ./setup_flutter.bat


Port to React-Native >= 0.7x and<EMAIL_ADDRESS>

Summary by CodeRabbit

New Features

Introduced a new React Native example application with splash screen functionality using Lottie animations.
Added support for different React Native versions and updated installation instructions.

Documentation

Enhanced the README.md with detailed setup instructions, version compatibilities, and troubleshooting tips.

Bug Fixes

Updated the splash screen management to ensure smoother transitions and animations.

Configuration

Added new configuration files for Yarn, ESLint, and Prettier to improve development experience.

Tests

Introduced unit tests for the new application to ensure component rendering and functionality.

I have no idea when the repo owner wants to do it but meanwhile, you can add this to your package.json.
    "react-native-lottie-splash-screen": "https://github.com/attarchi/react-native-lottie-splash-screen",

@attarchi I did try using your fork, but getting this error with RN 0.75.4

@attarchi I did try using your fork, but getting this error with RN 0.75.4

I have tested 0.75.4, and there is no error. Please remove the previous one and set it up from begin with this instruction.

@attarchi It was some issue with the build schemes configured in my project. Recreated the scheme and build was successful.
However, the lottie splash is immediately removed after load, and does not complete the animation. (tried with setAnimationFinished true/false, but its removed immediately)

@HwangTaehyun Cloud you please check this PR?

I have no idea when the repo owner wants to do it but meanwhile, you can add this to your package.json.
    "react-native-lottie-splash-screen": "https://github.com/attarchi/react-native-lottie-splash-screen",

Thanks for updating the package,
I have installed the package from your repo,
but when I use
RNRestart.restart()
the lottie splash it's run again on the iOS, until I close the app and reopen it
and when I use LottieSplashScreen.show()
the app froze with no response
"react-native": "0.74.0",
"react": "18.2.0",
"react-native-lottie-splash-screen": "https://github.com/attarchi/react-native-lottie-splash-screen",

Hi @QaysTrad,
Thank you for your feedback and for testing the package!
I'll look into the issue with RNRestart.restart() causing the Lottie splash screen to reappear on iOS. There might be a conflict there that I'll need to resolve.
Regarding LottieSplashScreen.show(), I have actually removed that method as it didn't align with the package's purpose. This package is designed to handle the native splash screen while React Native is initializing. Once the app is fully loaded and you have access to React components, it's better to control Lottie animations directly using the lottie-react-native package. This package's focus is on the startup process, so handling splash screens beyond that isn't necessary.
Let me know if you need any further clarification!

Hi @ashwini-ksingh,
I've added an example project to the source code for running this app with RN 0.7x, and updated the package. Please check out the latest version.
Regarding your issue, keep in mind that when setAnimationFinished is set to true, the application won’t wait for the Lottie animation to finish before removing the splash screen. To ensure the splash screen waits for the animation to complete, set this value to false and clear the build folder inside your iOS project directory.
Here’s how you can set it in your code:
// AppDelegate.mm file

    // Make the splash screen wait for the Lottie animation to finish
    [RNSplashScreen setAnimationFinished:false];

After making these changes, rebuild the project, and the splash screen should behave as expected in the release build. Let me know if this resolves the issue!

Hi again, I just followed instructions and all seem to be right, app is running without problems using this package v2, but I'm not sure if it 'cuz I'm using latest versions of all, I mean I'm testing new project with latest version of Xcode, metro<EMAIL_ADDRESS><EMAIL_ADDRESS>iOS simulator with iOS 16 and I notice it runs very quick, I can see my splash-screen only for 0.5 seconds and it only shows it when I close and reopen the app, nothing is displayed if I reload it in terminal.
Note: I know Lottie file is in the splash-screen because that little black square in right side is part of it, it's like a watermark.

I just read the latest version of metro and react-native help to improve build time but I'd like to be sure that's the reason.

@erie-e9 I am also facing the same behavior (though I am on RN 0.75.4)
Not sure why, its the same using the example in the repo as well (example/RN.0.7x-cli) @attarchi

@erie-e9 Have the same issue. The lottie doesn't finish but the screen is removed

@singhayush1403
@ashwini-ksingh
@erie-e9
Thank you very much for your collaboration. I noticed the issue but couldn’t fix it, as I don’t have extensive experience with Objective-C and iOS app initialization. I’ll publish this version in my repo as is. Could you please open a separate issue to address the iOS problem in a future update? If anyone can help with this, feel free to jump in with a PR. Thanks!

I've published the latest changes to npm! You can check out the package here: @attarchi/react-native-lottie-splash-screen on NPM.
Feel free to install it and continue bug fixing.
$ yarn add @attarchi/react-native-lottie-splash-screen

@attarchi
This seems to be an issue with the default zIndex given to App component, compared to the LottieAnimationView view added for splash.
I added animationView.reactZIndex = 1; in createAnimationView function, and it started working for me on 0.75.4 with new architecture and bridgeless enabled.

@ashwini-ksingh
Thanks! Your solution worked perfectly.
Since the old architecture doesn’t support reactZIndex, I set animationUIView.layer.zPosition = 1 in AppDelegate.mm, and it resolved the issue.
@erie-e9
The example project has been updated and should work as expected. Also, you can also add animationUIView.layer.zPosition = 1 directly to your AppDelegate.mm file.

Somebody else facing these errors on Android?
Steps:

[ ] Init new RN project - @0.76.x.
[ ] Install latest version of this dep - yarn add<EMAIL_ADDRESS>[ ] Sync gradle on Android studio.
[ ] Rebuild project: Build output will display next problem.

Error 1

Error 2
Unresolved reference Lottie in MainActivity.kt

I already tested Clear project and run rm -rf android/app/build android/app/.cxx android/build but error still happens.

Somebody else facing these errors on Android?
Steps:

[ ]  Init new RN project - @0.76.x.
[ ]  Install latest version of this dep - yarn add<EMAIL_ADDRESS>[ ]  Sync gradle on Android studio.
[ ]  Rebuild project: Build output will display next problem.

Error 1

### Error 2
Unresolved reference Lottie in MainActivity.kt
I already tested Clear project and run rm -rf android/app/build android/app/.cxx android/build but error still happens.

Solution enable next ones in gradle.properties:
android.useAndroidX=true
android.enableJetifier=true

@erie-e9
I tested this with React Native 0.76.2 and encountered the same error. It seems this issue isn’t directly related to this package; version 0.76.x might still have some unresolved bugs. Here's how I resolved it:

Yarn vs. npm
I'm using yarn instead of npm, which might help avoid dependency issues.

Gradle settings
Make sure your gradle.properties file includes the following settings:
android.useAndroidX=true
android.enableJetifier=true
newArchEnabled=false

Fix for MainActivity.kt
You might have missed adding this import to the header of your MainActivity.kt file:

import android.os.Bundle

Ensure correct lottie-react-native version
Verify that the lottie-react-native package is installed with the exact version 6.7.2:

yarn add<EMAIL_ADDRESS>
Let me know if these steps work for you!

Thank you for your detailed answer. I edited my comment with fix for me, as we mentioned solution is enable those flags. Anyway, I'm using new arch, so for me is working fine without newArchEnabled=false


Consider using records instead of structs

There are numerous locations in the core where we're using structs but we don't need them to have all benefits of structs, maybe using records will be better? They might be slightly faster.
https://groups.google.com/forum/#!msg/elixir-lang-talk/6kn7J2XnFg8/I5poTNCEHwAJ

According to the planning meeting on 25.06.2018 seems like something that is not our first requirement.


(#131) - add --sqlite option

Tested manually, and this seems to be working. But just
to be prudent, I've added an extra Travis test.

looks good, :+1:.

Updated to use<EMAIL_ADDRESS>and to avoid the prefix hack. As long as it's still green, I'll merge and publish.

PhantomJS seems perma-broken. I'm going to disable it and then open a new issue.

03faee046b8b0d565bee8c62c0b80446f54b0211


[QUERY] What is the best (cheapest) way to check if a BlockBlob already exists in a container?

Query/Question
What is the best (cheapest) way to check if a BlockBlob already exists in a container?
Why is this not a Bug or a feature Request?
Usage-question I have found no documentation or examples for.
Setup (please complete the following information if applicable):

Version: 11.0.0

Thank you for opening this issue! We are routing it to the appropriate team for follow up.

@kagkarlsson Sorry for the delay. The best way to do this is to make a getProperties call and handle a 404 if it doesn't exist. Please let us know if you have any further questions or concerns. A few thoughts to consider:

Depending on your application architecture, you should be a little wary of using exists as the result is immediately invalid. In distributed systems, there is no guarantee that the resource wasn't deleted/created immediately after this call by some other role.
While this sort of thing is not available in v11, we will be adding convenience methods to v12, the preview for which is out now if you'd like to try it.
We are generally recommending that customers either stay on v8 if they are comfortable there or be prepared to upgrade to v12 once it goes GA. There were some stability issues when v11 went to scale that are resolved in v12, but the upgrade also does come with a bit of a facelift that will slightly modify the api surface. I just wanted to give you a heads up on that as well.

Ok, thanks.
Are there artifacts in maven central for the preview or do I build it myself?

There's an artifact on maven central. If you give it a go, we'd love to hear what you think!

Close the issue since answer provided. Please reopen if there is still question.

@rickle-msft Is this the documentation reflecting the facelift?
(Btw, the link here 404s: https://github.com/Azure/azure-storage-java )

Trying out the preview client some now.
Am I supposed to use the async client if the data I upload is of unknown length? cc @rickle-msft

Will 12.0.0-preview.2 also be made available? Would like to use the new DefaultAzureCredential() to get a node managed identity.
                .endpoint(endpoint)
                .credential(new DefaultAzureCredential())
                .buildClient();```

cc @rickle-msft

@kagkarlsson. Yes, that is the location of the new source. Thank you for mentioning the 404; the structure of this repo has changed a bit since we updated that README, so I'll go fix that.
Perhaps this sounds meaningless, but the async client is for async operations. It'll support a completely different paradigm, and in most cases you'll still need to know the length of your data. If you are working in a sync environment and don't know the length of your data, we recommend working with a BlobOutputStream, which you can open using the BlockBlobClient.
Preview 2 will be released today.

@rickle-msft
Thanks! I did not see the BlobOutputStream, this is what I needed.
Eagerly awaiting Preview 2 then :)

Preview 2 is out now!

Hmm I had assume the release would make it in sync with documentation, but I still cannot do this:
BlobServiceClient storageClient = BlobServiceClient.storageClientBuilder()
        .endpoint(endpoint)
        .credential(new DefaultAzureCredential())
        .buildClient();

How do I currently setup my storage-client to get credentials via NodeManagedIdentities?
@rickle-msft

I think I found my way.
When do you think 12.0.0 will be released @rickle-msft ?

"I had assume the release would make it in sync with documentation" is there documentation you've found that doesn't match the SDK? If so, we'd like to update it.
I can't give a guaranteed date, but we are on a schedule to release at least one preview per month until we GA. I think the hope is that preview 4 (October ) will be a release candidate, and we'll GA a couple weeks after that. Depending on customer adoption/feedback that may change a bit

Yes, the documentation here has some minor errors:
https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/storage/azure-storage-blob#authenticate-with-azureidentity

Ok, thanks for the rough roadmap. I think I have to look at v8 then, because we are looking at production in October and not sure I want to depend on a preview-version

@kagkarlsson Which version of the preview are you using? And when you say you can't use the code you shared, is that because it doesn't compile or it throws an error or doesn't behave as expected? Thanks for your help in this.
Totally understandable. We will be on deck to help you upgrade should that ever be of interest to you and we will also be providing some resources in the repo to ease that process.


Project website for CS4OD

GH pages
EOS pages
Other CMS? Drupal, Joomla, Wordpress

Wordpress website up and running, on https://cs4od.web.cern.ch/
I've chosen some template and put some basic content, but we'll have to discuss what should go on the website.


use old qm7 loader with proper centering mechanism

This might be a small issue, but the molecule will be aligned such that the total average of coordinate is zero, when align=True in load_qm7 function. I believe this is not what we want because we don't want to count dummy atoms. I just slightly modify the old qm7 loader and put in to the package. However, I do notice some small performance difference.

Yes!  I realized that I had reverted back to something I had debugged months ago :)
Weirdly, I have noticed that for the machine learning after scattering transform the bug in alignment sometimes led to better results. But this we should be able to achieve consciously by adding positional jitter if necessary.
I'll be back in around an hour to review and merge this!


start-storybook command freezes at 25%, JS heap OOM

If you are reporting a bug or requesting support, start here:
Bug or support request summary
What did you expect to happen?
I expected storybook to build modules using webpack and launch the storybook UI in the browser
I expected  What happened instead?_
The module building process in the terminal stopped at 25%, froze for several minutes, and then produced a Javascript heap Out-of-Memory error
Steps to reproduce
start-storybook --port 6001
will create an OSS repro repo soon.  don't have an easy to share example at the moment.
Please specify which version of Storybook and optionally any affected addons that you're running
    "@storybook/addon-actions": "^3.4.1",
    "@storybook/addon-links": "^3.4.1",
    "@storybook/addons": "^3.4.1",
    "@storybook/react": "^3.4.1",

Affected platforms
MacOS High Sierra 10.13.5
nodejs v8.11.1
yarn 1.7.0

Screenshots / Screencast / Code Snippets (Optional)

$ yarn storybook --port 6001
yarn run v1.7.0
$ start-storybook --port 6001
info @storybook/react v3.4.8
info
info => Loading custom .babelrc
info => Loading custom webpack config (extending mode).
 25% building modules 131/155 modules 24 active ...ook/core/node_modules/qs/lib/utils.js
<--- Last few GCs --->

[24764:0x102801e00]   247386 ms: Mark-sweep 1655.7 (1727.1) -> 1655.6 (1727.1) MB, 1428.8 / 0.0 ms  allocation failure GC in old space requested
[24764:0x102801e00]   248949 ms: Mark-sweep 1655.6 (1727.1) -> 1655.4 (1694.6) MB, 1562.4 / 0.0 ms  last resort GC in old space requested
[24764:0x102801e00]   250500 ms: Mark-sweep 1655.4 (1694.6) -> 1655.4 (1694.6) MB, 1550.8 / 0.0 ms  last resort GC in old space requested

<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x2f7f75e257c1 <JSObject>
    1: push(this=0x2f7faf2102f9 <JSArray[50855]>)
    2: /* anonymous */(aka /* anonymous */) [/Users/m/workspace/repo-name/node_modules/babel-core/lib/transformation/file/merge-map.js:~253] [pc=0x70a8a9f35fc](this=0x2f7f64402201 <null>,m=0x2f7fda0f28b1 <Object map = 0x2f7f0de78341>)
    3: arguments adaptor frame: 3->1
    4: forEach(this=0x2f7faf210361 <JSArray[54629]>)
    5: eachMapping(...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [/Users/m/.nvm/versions/node/v8.11.1/bin/node]
 2: node::FatalException(v8::Isolate*, v8::Local<v8::Value>, v8::Local<v8::Message>) [/Users/m/.nvm/versions/node/v8.11.1/bin/node]
 3: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [/Users/m/.nvm/versions/node/v8.11.1/bin/node]
 4: v8::internal::Factory::NewUninitializedFixedArray(int) [/Users/m/.nvm/versions/node/v8.11.1/bin/node]
 5: v8::internal::(anonymous namespace)::ElementsAccessorBase<v8::internal::(anonymous namespace)::FastPackedObjectElementsAccessor, v8::internal::(anonymous namespace)::ElementsKindTraits<(v8::internal::ElementsKind)2> >::ConvertElementsWithCapacity(v8::internal::Handle<v8::internal::JSObject>, v8::internal::Handle<v8::internal::FixedArrayBase>, v8::internal::ElementsKind, unsigned int, unsigned int, unsigned int, int) [/Users/m/.nvm/versions/node/v8.11.1/bin/node]
 6: v8::internal::(anonymous namespace)::ElementsAccessorBase<v8::internal::(anonymous namespace)::FastPackedObjectElementsAccessor, v8::internal::(anonymous namespace)::ElementsKindTraits<(v8::internal::ElementsKind)2> >::GrowCapacityAndConvertImpl(v8::internal::Handle<v8::internal::JSObject>, unsigned int) [/Users/m/.nvm/versions/node/v8.11.1/bin/node]
 7: v8::internal::(anonymous namespace)::ElementsAccessorBase<v8::internal::(anonymous namespace)::FastPackedObjectElementsAccessor, v8::internal::(anonymous namespace)::ElementsKindTraits<(v8::internal::ElementsKind)2> >::Add(v8::internal::Handle<v8::internal::JSObject>, unsigned int, v8::internal::Handle<v8::internal::Object>, v8::internal::PropertyAttributes, unsigned int) [/Users/m/.nvm/versions/node/v8.11.1/bin/node]
 8: v8::internal::JSObject::AddDataElement(v8::internal::Handle<v8::internal::JSObject>, unsigned int, v8::internal::Handle<v8::internal::Object>, v8::internal::PropertyAttributes, v8::internal::Object::ShouldThrow) [/Users/m/.nvm/versions/node/v8.11.1/bin/node]
 9: v8::internal::Runtime_SetProperty(int, v8::internal::Object**, v8::internal::Isolate*) [/Users/m/.nvm/versions/node/v8.11.1/bin/node]
10: 0x70a8a8842fd
error Command failed with signal "SIGABRT".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

not sure if this is user error, a problem with yarn, or a problem with storybook. will post this here in case smarter people that me can spot the cause quickly, on the chance that the cause is storybook-related 😅

for what it's worth, my yarn script I use is "storybook": "start-storybook",
I then use it like this:
yarn storybook --port 6001

things I've already tried:
rm-rf node_modules
yarn install

maybe the problem is something to do with babel and source maps?
node_modules/babel-core/lib/transformation/file/merge-map.js

here's the .storybook/webpack.config.js I'm using in my project, in case this is helpful
// you can use this file to add your custom webpack plugins, loaders and anything you like.
// This is just the basic way to add additional webpack configurations.
// For more information refer the docs: https://storybook.js.org/configurations/custom-webpack-config

// IMPORTANT
// When you add this file, we won't add the default configurations which is similar
// to "React Create App". This only has babel loader to load JavaScript.

module.exports = {
  plugins: [
    // your custom plugins
  ],
  module: {
    rules: [
      {
        test: /\.jsx?$/,
        exclude: /node_modules/,
        use: [
          {
            loader: 'babel-loader'
          }
        ]
      },
      {
        test: /\.css$/,
        use: [
          {
            loader: 'style-loader'
          },
          {
            loader: 'css-loader'
          }
        ]
      },
      {
        test: /\.styl$/,
        use: [
          {
            loader: 'style-loader'
          },
          {
            loader: 'css-loader',
            options: {
              modules: true,
              sourceMap: false,
              localIdentName: '[name]-[local]-[hash:base64:5]'
            }
          },
          {
            loader: 'stylus-loader',
            options: {
              sourceMap: false
            }
          }
        ]
      },
      {
        test: /\.(eot|ttf|woff|woff2|svg|jpe?g|png)$/,
        exclude: /node_modules/,
        use: {
          loader: 'file-loader',
          options: {
            name: 'static/[name]-[hash:8].[ext]'
          }
        }
      }
    ]
  }
}

So happy we've RubberDucked you 🦆
👍

For anyone who might stumble across this issue with a similar error, if you're using Typescript and you've recently upgraded Storybook you may just need to remove ts-loader from the webpack config for Storybook 👍


Your computer is low on memory

Hi - I am running some large json files (some as large as 2.5GB) and am getting a windows memory error popup like this:
"
Close programs to prevent information loss
Your computer is low on memory.  Save your files and close these programs:
python.exe
Windows will only close enough programs to restore needed memory.
"
json2csv stops at that point and no CSV is created.  Is there a way to have python continue parsing, even against memory issues?
Note that I keep all other programs closed while running the program.
Thanks,
SJB

Hi, as you can tell I don't have much time for open source projects these days.
I'd started a fix for this issue in https://github.com/evidens/json2csv/tree/13-direct-transcription and I've been told it works. I didn't get around to writing tests for it, which is why I didn't merge it into master.
Sorry if this reaches you too late for your project. Good luck.

Your fix seems to have worked perfectly.  Instead of maxing out my memory, the program stayed at around 7Gb the entire time.  I was able to parse json files as big as 2.2Gb that have fairly deep nests.
I really appreciate your help!
Best,
SJB


ESLint

Replaces Standard with ESLint.
ESLint is set to use Standard ESLint configuration.
Then adds additional validations.
ref https://github.com/feross/eslint-config-standard

Hey @ChristianMurphy I really appreciate the hard work you put into this pull request, but a big part of why I love @feross' standard is that it leaves no . eslintrc to argue about.
Rather than accepting this pull request, I encourage you to start a conversation regarding some of these stylistic additions on the standard repo, I will happily update yargs' style to match any additions to standard.

Thanks @bcoe and @isaacs for the prompt feedback. :smile:
@bcoe would you be interested in any of the changes made here being merged, but not being enforced?
The most notable changes being

strict mode
replacing var === undefined with typeof var === 'underfined'
replacing throw Error() with throw new Error()
applying standard style on examples


Clicking the asm button in an empty mod crashes the game

How to reproduce:

Start a new game
Click the mods button
Create bob-the-mod (the bug is present in non-bob-themed mods too)
Click the asm button
:tada: Get a free segfault! :headstone:

[...]
GL_VERTEX_ATTRIB_ARRAY_BUFFER_BINDING_ARB (0), GL_VERTEX_ATTRIB_ARRAY_BUFFER_BINDING_ARB (1), GL_VERTEX_ATTRIB_ARRAY_BUFFER_BINDING_ARB (2), GL_VERTEX_ATTRIB_ARRAY_BUFFER_BINDING_ARB (3), and GL_ARRAY_BUFFER_ARB, usage hint is GL_DYNAMIC_DRAW) will use VIDEO memory as the source for buffer object operations (20071)
src/engine/engine.c:100: [gl:api:other:info] Buffer detailed info: Buffer object 14 (bound to GL_ELEMENT_ARRAY_BUFFER_ARB, usage hint is GL_DYNAMIC_DRAW) will use VIDEO memory as the source for buffer object operations (20071)
[1]    491319 segmentation fault (core dumped)  ./build/legion

Blarg, there's always a million problem in that part of the code but I should be able to hunt down the issue relatively easily tomorrow.

Fixed https://github.com/RAttab/legion/commit/41e2dd6f75a9267c9055d70d2fb24c5b037589c9
Although the fixed is probably a bit brittle and I'm too tired to reload the entire state machine of the code editor to do a proper fix at the moment.


Windows 11 rdp version 10.0.22621.1778  down sessions issue..

rdp-tcp#22        usr16                    25  Active
rdp-tcp#23        usr15                    26  Active
rdp-tcp#25        usr12                    27  Active
28  Down
29  Down
30  Down
I see this Down sessions on cmd using command query session and i cannot enter to another user without logout a user
also after 30 sessions i need to logout a user to login to others

Check "Single session per user in RDPConf".

First user will be disconnected. Sexond and others will OK.

im afraid the problem is windows 11, i will install windows 10..


Arc-enabled SQL Server best practices assessment failing with error

Is your issue related to a Jumpstart scenario, ArcBox, or HCIBox?

Describe the bug

To Reproduce

Expected behavior

Environment summary

Have you looked at the Troubleshooting and Logs section?

Screenshots

#1782
Additional context

Closed #1782


Molds are still cooked in a fire.

The mirror molds are still cooked in a fire and not fired in a pit kiln. I don't know if that was an oversite or a decision, figured I'd mention it incase it was an oversite.

Fixed in 1.7.0


Xai update: V2 staking pools

~As soon as stakingEnabled in the PoolFactory is true, admin roles in this part of the rollup system should be reviewed. (Currently there is a new ProxyAdmin still owned by the Xai Deployer)~
edit: done
Discovery for this change is configured.

also added an issue on linear to add upgradeability to the orbitstack template.


Bar Chart with Step Chart

Aligning the steps with the centre of the bar does not really work as a chart.
If it is possible instead to have an option where the steps are flat above bars, and change value in between bars this would be much more effective.
This is only an issue when combining step charts with bar charts.

@masayuki0812 Hi, where do I have to place this "step-after" on my step chart function? Thank you!

Hi
This is working fine for regular charts, but when the axis is rotated (like in the first screenshot), it doesn't look good.
This is due to the step interpolation that works in a "horizontal" way.
...I think I can provide a PR, if you agree this is something that needs to be fixed

For a single data point, it's showing nothing. Is there any way to show a vertical line for a single data point?
var chart = c3.generate({
data: {
columns: [
['data1', 300]
],
types: {
data1: 'step'
}
}
});


Add support for feature state

Maybe add a test with the new ctor just to make sure the == operator behavior will not break. It looks correct to me, but good to be future proof.

Added a test for the == operator.


[feature request] automatic disable pager and spinner if piped

The usually way in C is to call isatty() on stdout. If it is not tty, disable interactive features, like pager and spinner.
This is related to #118 (solve the same problem in another way)

How about moving this information to that issue? I'd rather have all this information in one place.

up to you. i'm okay.

Btw had you ever noticed the pager or spinner turned on when using --piped? I have never noticed this kind of behaviour before. Closing this, please re-open if you see any of this present.

Not only "push -piped". I expect that no pager and spinner for "drive list -r -m=-1"

And for jobs running in cron, no pager and spinner by default.

Broad scope, limited feature request title. Also explain to me why recursive listing would not allow for pagination?

Basically you are asking for every operation not to have pagination nor spinner

oh, not really related to recursive.... just an example.
No pager and spinner for "drive list | wc"  as well.

That was the purpose of have --quiet which I just added.

As well as --no-prompt.

My feature request is that drive detect interactive mode automatically.
For example, "git log" has pager if the output is long. But no pager for "git log | wc"
Users no need to pass additional flags.

You are welcome to submit a PR for this, but this information is coming way late and seems to be covering a different case than the request asked for.

Never mind my comments, I just re-read your title.

My apologies, your original comment cuts the deal, mentions what needs to be done.

Fix coming up, this was just me purely not understanding the requirements.

My apologies @kcwu this was a case of me not reading clearly and not understanding your requirements, please take a look at PR #127


chore: unity 2019.4.19f1 update

What?
...
Why?
...

I'm having issues with the sound as well. In any case the rest looks good, I will drop an approve since Santi already requested changes. Good job!


Can't Load Game with "Disable Limitlesss Rage" Disabled

If both the "Path of Rage (1.3.5)" and "Dark Codex (latest version)" mods are installed and "Path of Rage" has the option "DarkCodexLimitlessRageDisable" set to "false", the game can't load to the menu and remains blocked indefinitely on the loading bar screen.

This problem is still present. Can nothing be done about it?

Sadly, you reminded me of this issue at the worst time, as my PC currently cannot turn on. So, for now, nothing can be done. That being said, a workaround would be to just disable the Demon Rage patches. This will revert Demon Rage to its vanilla state.

Sorry for the late reply! Yes, I had been using the mod disabling the changes to Demon Rage simply to be able to load the game in the meantime.
I noticed that after the last release, I can actually load the game with the changes to Demon Rage activated and "Limitless Demon Rage" from DarkCodex active. Does that mean that they're now compatible with "Limitless Demon Rage", meaning that the Demon Rage remains always active, or does it simply ignore that functionality from DarkCodex?


Calculate (Strahler) stream order

Calculate Strahler stream order for a network (i.e. headwaters = 1)
Required for:

Branch ID identification
Segmentation

Refer to Arcpy GNAT Calculate Stream Order tool.

Is this as easy as finding the headwaters and assigning everything downstream an order?

Generally, yes. The arcpy script is slow due to creating and selecting multiple layers per iteration (actually, this is quite fast at the start/headwaters, but slow when it works down the network). Things like multi-threaded channels (cycles) or disconnections need to be overcome as well.

I think we can get there quickly by:

Finding the headwater (which we can do now)
reversing the networkx network (so we can traverse it backwards)
doing a depth-first-search and incrementing orders based on traversal depths.


[Enhancement] Add UT tools to verify the procedures of replay & image

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #8942
Problem Summary(Required) ：

Add ImageHelper to help to verify the procedure of image on metadata.
Add JournalReplayerHelper to help verify the procedure of replay on metadata.
Use the above tools on some unittest as demo.

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

run starrocks_admit_test

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)


Allow 3-op script cmds to use regs as 3rd operand.

This is a simple hack to allow the 3rd operand of certain 3-op commands to be a register (v? / p?) rather than only a constant.  We utilize the previously-ignored opt[3] field for this purpose.  In my application this allows me to use the HP command with script-controlled duty cycle.
This change is entirely backward-compatible; no existing programs or scripts should be affected in any way.

I'll have a look when I get a decent amount of time.  It seems like a good idea.


Managing focus

Environment
Flutter version: 2.0.2
Plugin version:  5.2.0
Android version:  9.0
iOS version: 14
Description
What you'd like to happen:
I'm using flutter_inappwebview to load in our text editor on Android and iOS. We need a way to manage the focus state of the text box within the webview. I've tried focusing/blurring within javascript and it's not actually doing anything. I've looked through all the code for the word "focus" and there doesn't seem to be a way to focus the actual window, or an element within it. There is a function to get the text selection and to clear the focus, as well as callbacks to check window focus, but it seems that we can't actually modify that focus state.
I'm not sure what to do, if there's any hacks that can be done to manage the focus state (autofocusing when the webview first renders). I might also be missing something.

@hworld I'm also getting same issue, did you find any solution?

@tneotia I also tried to manage the focus but it's not working I think issue is with inapp_webview plugin

@pichillilorenzo do you have any input on this? I'd really like to know if what @hworld said is possible.


Setup milestones & release schedule

To keep expectations & issues manageable, there should be a clear version schedule, maybe a tick-tock between implementation and application. For instance

v0.0.x - initial prototyping w/ Jax
v0.1.x - initial TVB backend + show cases
v0.2.x - field performance issues
v0.3.x - stimulation 💉
v0.4.x - solver performance issues ⏳
v0.5.x - generalized neural masses 🥅
v0.6.x - documentation push? 📝
v0.7.x - multi-connectome cases? ꙮ
v0.8.x - revisit inversion use cases #5
...
v1.0.0rc - summer break 😮💨🍸  first v1 release candidate
v1.0.0 - API is stable ⛱
v1.0.x - fix bugs in v1.0.x 👾

@i-Zaak let's identify priorities/dates; it'd be nice to hit v1 by end of September

Once we have a better sketch, I'll set up the milestones in the tracker here.

Cool! I'd throw in showcase 1 use-case for v0.1. That would be any or all of following:

paramenter sweep for MPR
SBI with MPR
optimization with AdEx

I've mapped out the most relevant bits to milestones + issues.


How to handle/manage existed k8s resource(daemonset/deployment, etc) but not yet managed via application

Describe the bug
Try to deploy the application as type of k8s-objects whose resource already applied via kubectl before, and got error as screenshot as below
Screenshots

KubeVela Version
1.9.2
Cluster information
1.25.4

you can try vela adopt

@nuclearwu  Thx very much and it worked.
Then I have another relevant question. Seen from this doc https://kubevela.io/zh/docs/cli/vela_adopt/

Could you plz guide me how to handle exited resources in non-local managed clusters via kubevela ?
Thx in advance

It's supported in 1.8.x. We need to update the doc.

It's supported in 1.8.x. We need to update the doc.

Cool ! I am using 1.9.2, then it should match the requirements. Plz inform me when doc updated. Thx !

It's supported in 1.8.x. We need to update the doc.

Any updates？

ping @basuotian would you like to update the doc site in kubevela.io repo?
@zhangyang-bytedance you can check the description in the PR https://github.com/kubevela/kubevela/pull/5635 as a  quick solution.

hope the doc can be updated  quickly. its an important feature

Any news ？Seems not updated yet


Including az cli functionality in powershell

It's great to be able to manage Azure devops boards and pipelines from the CLI, but is there any thought to providing similar access via powershell (PS Core of course)?
Referencing issue thread from az cli extension repo - https://github.com/Azure/azure-cli-extensions/issues/815

See https://github.com/MicrosoftDocs/vsts-rest-api-specs/issues/161
Specifically the azure devops cli piggybacks on the python az cli, which was recently deprecated. A new powershell core based cli could be generated with https://github.com/Azure/autorest.powershell.

https://github.com/Azure/autorest.powershell/issues/153 calls out a few attempts of individuals trying to use autorest to generate an api from vsts-rest-api-specs.
https://github.com/Azure/autorest.powershell/issues/153#issuecomment-468400882
https://github.com/Azure/autorest.powershell/issues/153#issuecomment-488436809

Thanks for the info, @daveneeley . I'll give that a try when I have some spare time.


Adding scotch.io article

Very straight forward tutorial for automating common tasks.
https://scotch.io/tutorials/automate-your-tasks-easily-with-gulp-js

look good to me


Mapillary: while drawing (lines), suspend all interaction with mapillary elements

Szenario/Issue:
I have the mapillary images visible with their green elements on the map.
No I want to draw a linke very near by or over a mapillary image.
Current behaviour: I trigger the hover of the image. This makes it harder to draw since I dont know if it will work (will it have some snapping effect?) and also the hover is bigger than the image so it hides more of the map.
Expected behaviour: While drawing, all interaction with the mapillary elements are suspended.

Perfect, I tested it on http://preview.ideditor.com/master/#background=Berlin-2017&disable_features=boundaries&map=20.00/52.47331/13.44813 and it works great. Thanks!


fix handling of large and many custom-field-sets

1. Why is this change necessary?
Handling of more than 100 Custom-Field-Sets were broken. (For Sets which were not within the first 100 were unable to populate its fields.
2. What does this change do, exactly?
Fixes the described scenario.

Fetches the Product Fieldset without a limit and its related fields. (increases performance when there are 500 custom-field-sets for products (approx. 15MB were transfered before the page was usable))
Populates only the attached Field-Sets with fields
when adding new Sets to the Product we fetch the associated fields for this set only.

3. Describe each step to reproduce the issue or behaviour.

Create more than 100 Product Custom Field Sets (with at least 1 Field)
Create a product
Try to attach the 101st Field-Set

4. Please link to the relevant issues (if any).
#2448
5. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@keulinho the renderer itself should work as before (but with the async field fetching under the hood). I will check for other places and change them to fix without fields relations

@keulinho i reworked this PR so it should work in all places. i checked a few, all seemed good to me. maybe someone from your side can check more specialized use-cases (im not familiar enough with shopware)

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-21408
Please use this issue to track the state of your pull request.

Hello, your MR is missing a changelog file. Could you please provide this?

I have just checked out your MR and the solution does not work, if no individual sets are selected for a product, as seen in the screenshot.
Before:

Maybe we need to do it the old way with higher limit, if no individual sets are selected? On the other hand I guess that a user will always select individual sets if he has 100+ custom field sets...
Perhaps we need another UI for managing so many custom fields.
Or we just hide all custom fields, if the user has more than 100 and no individual sets are selected.
I will involve someone from UX/Design here.

I think we would need also loading spinner, when selecting new individual sets and the request loads the fields.

When selecting individual sets, the fields are not loaded when the page is refreshed. The requests are fired, but the UI does not show the fields.
Other considerations:
Before we had one request fetching all custom field sets with fields, and now we send a request for every selected custom field set. If a user has many field sets selected, many requests are fired when opening the page.

@taltholtmann thanks for the review. Thats not the Product-Fieldset UI right? Where did you test it?

i will add a changelog once its done
with 100+ custom-field-sets nobody would not want "select individual custom-field-sets", i dont know how to solve this UI / UX wise (maybe solve it with last point in the list)
simply increasing the limit is not feasable, in our case 100 fieldsets results into a response-size of 15MB intially transfered each time with no option to cache this (POST) that makes the UI unusable AND the when discarding the limit or e.g. set it to 500 we have a payload of ~75MB on each product ui load, and the server might cancel it anyways with 413 or something like that
fetching all fieldsets (when not indivually selected) at once leads to the same problem as above.
maybe lazy load only the selected tab would solve this? (with a spinner)

im open for ideas which leads to resolving this issue

i think lazyloading only the selected tab is the solution to all problems

i think lazyloading only the selected tab is the solution to all problems as the defined custom-field values are separatly stored

I talked to a college and we liked the idea of lazy loading. You could try to implement that non-breaking, or it will be a feature of the next major release(6.5).
Please use the "skeleton loading" as loading indicator.

@taltholtmann thanks for doublechecking. i think it can be implemented without a BC. will do

@taltholtmann i reworked everything, and it looks good to me

lazy load only the visible tab
skeleton until the customFields are loaded for a set
only load a customFieldSet once

all issues looks resolved to me. can you recheck the feature and give me feedback? once its done i will provide a changelog too.

I just tested your branch and everything seems to work as it should. I like the implementation :+1:
Could you finalize your MR? Adding a changelog, adding jest-tests, make sure the e2e tests still work? Then I will make a demo with someone from the QA and we can merge this change.
Great Work :100:

Hello, your MR is missing a changelog file. Could you please provide this?

done

@taltholtmann i fixed the jest-tests and added a new one for this feature. added a changelog as well.
the failing e2e seems unrelated to me and i wasnt able to properly setup local e2e testing. maybe you can step in on this one?!

Hellooo, I have just checked out your branch and there are also many failing jest test. Just started the pipelines here so that you can also see them.
What setup are you using? Running the e2e tests should be easy. Maybe I can help.

im utterly confused, on my local machine i have many different test-failures then on CI, only a subset fails on both machines... i think its related to entity-schema.json which is probably different on CI than on my machine. when fiddeling around with the file (remove some plugins) all jest tests working fine now (at least on my machine).
tbh i think thats not a reliable way todo things, best would be to commit the entity-schema along the tests, so everyone can run the same configuration like on CI.
Test Suites: 1 skipped, 553 passed, 553 of 554 total
Tests:       5 skipped, 5022 passed, 5027 total
Snapshots:   9 passed, 9 total
Time:        139.638 s, estimated 156 s
Ran all test suites.

i was not able to get the e2e tests running on my machine, i dont have a working local sw6 (with test data and all the necessary stuff), so i tried using our POC-system, that failed obviously. maybe you can step in on that? again, afais the failing test is completely unrelated:
Running:  administration/rule-product-stream/sw-product-streams/add-boolean-fi          (68 of 94)
            elds-to-condition.spec.js

  Dynamic product group: Add Boolean fields to condition
    ✓ @base @rule: can preview products with boolean field (20344ms)
    1) @base @rule: can preview products with custom field is boolean

  1 passing (3m)
  1 failing

  1) Dynamic product group: Add Boolean fields to condition
       @base @rule: can preview products with custom field is boolean:
     AssertionError: Timed out retrying after 30000ms: Expected to find content: 'my_custom_boolean_field' within the element: [ <li.sw-select-result.sw-select-option--0.sw-select-option--id>, 29 more... ] but never did.
      at Context.eval (http://localhost:8000/__cypress/tests?p=cypress/integration/administration/rule-product-stream/sw-product-streams/add-boolean-fields-to-condition.spec.js:416:58)

[mochawesome] Report JSON saved to /__w/platform/platform/var/log/e2e/results/mocha/mochawesome_067.json

  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        2                                                                                │
  │ Passing:      1                                                                                │
  │ Failing:      1                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  3                                                                                │
  │ Video:        false                                                                            │
  │ Duration:     3 minutes, 27 seconds                                                            │
  │ Spec Ran:     administration/rule-product-stream/sw-product-streams/add-boolean-fields-to-cond │
  │               ition.spec.js                                                                    │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘

Have you taken a look at the shopware docker project? Im using that for an easier installation of sw6: https://github.com/shyim/shopware-docker/wiki
just follow the installation steps and then use:

swdc up
swdc create-project (with platform only)
swdc build --without-demo-data platform
create a .env.local in your platform folder with:

APP_ENV=e2e

swdc e2e platform -> then the e2e console should start

Tell me if it wont work at all for you. Maybe I can help you out with the e2e tests. Since the failing tests has something to do with boolean custom fields, that may be related to your changes.

phew no it wont work et all: (osx user) (stated in the docs that it wont work on osx, giving it a try:
$ swdc create-project sw6-platform
Dialog is needed to use this command (apt install dialog)

$ swdc build --without-demo-data platform
bash: /opt/swdc/swdc-inside: No such file or directory

the containers are running after fixing port bindings on localhost:443 (who does this anyway?)
this whole shopware-docker project is making so much assumptions on paths (/var/www...) and files (/opt/swdc/swdc-inside) and such stuff, i surely dont want to spoil my local dev machine with all that clutter.
so again, as i dont think the failing e2e is related (this PR didnt changed any behaviour to the end-user), its probably some mocking api-responses (you dont want mocking  in e2e tests anyway). i wasnt able to find the problem.
again, i would be glad if you can take a look whats wrong (assuming you have all that up and running since its probably your daily job)
im not even a shopware developer and have no clue about mosts of the things. sorry, i did my best to fix this bug and followed all your advices, but im not able to fix the last thing, and im afraid i cant get any further on this e2e stuff...

Thank you very much for all the work :blue_heart:
I will take over here and take a look at the e2e tests :-)

I tried...really hard :)

Yes looks good so far. There is just the one e2e test that Im looking at

But in the last run it succeeded?

maybe flaky. i will have a deeper look at it, since it failed several times for this MR.

To keep you updated: The e2e test was flaky. The problem was on the dynamic products detail page, that the custom fields request could be slower than the e2e test expecting that the custom fields are available. I fixed it so far. Now we need 100% code coverage. Im working also on that and then the MR will go throw our internal review process.
At the moment, nothing to do from your side ;-)

Merci bien

@taltholtmann anything i can help to get this out of the door?

already seen it, thank you so much for lifting this over the last steps! ❤

@keulinho i noticed its sadly not part of 6.4.12. Any ETA for this fix?

Yep did not make it into the last release, but it will land in the next minor release. ✌


fake4swift - Better arg parsing

Add enhanced argument parsing and error reporting, including barebones "usage" output.

Hey @tjarratt - I'm wondering if you missed the notification about this one? Bump!

Just rebased this on top of master, since some of my recent changes caused a merge conflict.
Thank you @briancroom! This was entirely unexpected, and very generous of you.


Alter FailFast behaviour of memcpy

This commit changes the codegen for error messages for failed memcpys.
This no longer generates a stack frame and correctly tail calls the
error messages generator.
It also turns the error messages on in Release builds.  This will lead
to better adoption experience.

When we're just doing this for memcpy, the increase in (source) code size in the checked function is fine.  My intent with this code was that we'd be able to gradually instrument any libc (or external) function that takes pointer arguments with bounds checks.  There's going to be a lot more code duplication for this in the new version than the old.