Protocol https doesn't work

In sitemap.rb when i add:
protocol "https" and generate sitemap, i get this:
Generating sitemap...
rake aborted!
NoMethodError: undefined method protocol' for #<DynamicSitemaps::Generator:0x007fef3c755548> /home/anubix/projects/flies/config/sitemap.rb:3:ingenerate'
Most of websites need https urls in sitemap, please check it, thanks.

See #43

Actually the method protocol= doesn't exist in any branch.
You can't assign the protocol "Gem wide" but Sitemap specific.
Then all you have to do is point your gem to master
gem 'dynamic_sitemaps', github: 'lassebunk/dynamic_sitemaps', branch: 'master'
and in config/sitemap.rb add the following line at the top
protocol "https"


Add docs and example of custom reporter implementation

For wider adoption, gemini should be able to write report in different formats. TAP? JSON? XUNIT? It would be too much work for gemini team to implement all popular formats.
To implement one reporter and document this process is not so hard (still time-consuming, of course, but I think it worth it).
Ref #403

@arikon asked here why someone prefer webdrivercss.
Take a look, for example, on this
Just an example, but...


Outdated documentation about Node version

The current documentation cites requirements of

Node.js v8.5 or higher, and npm v5.2 or higher"

But the frontend build seems to require at least Node 10. The docs should be updated.
Markdown source is here, live version is here.
Screenshots

Fixed in https://github.com/cfpb/cfgov-refresh/pull/5114


add missing change logs for previous PRs (#44, #45, #48)

relates to

#44
#45
#48

Ah change logs!


fix: encoder dynamic protocol version validator

After allowing dynamic protocol version, we didn't set the validator to validate based on the current protocol version that being used. When users use default protocol version 1 but the messages contains developer data or basetype that is not supported by version 1, the resulting file will not be correct even if maybe it can still be decoded. This PR fix that bug.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (0616e92) to head (7fc102c).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #417   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           41        41
  Lines         3695      3695
=========================================
  Hits          3695      3695

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: remove engines from package.json

As discussed in #417 this package does not need the engine field. This PR gets rid of it.

For reasons I've stated in #417, closing this.


Proposal: Some way to snapshot & restore pair states

Right now, pairs are constructed by looking up the on-chain registry.
If a web UI is to be built on top of swappa, we need server-side acceleration.
The way it could work:

a backend server looks up all of the pairs and subscribes to new block to constantly refresh all pairs
state information for ALL available pairs are snapshotted per refresh and stored in Redis
web UI asks the server for the pair snapshots, and instantiates all of the pairs locally without querying for on-chain
websocket subscription can have the server publish per-block refreshed pairs to the client as well

This will reduce the load on Forno significantly and bypass the all pair discovery lag on the web clients.
My proposed API change to Pair interface to support streaming in a snapshot state:
type Snapshot any
public snapshot(): Snapshot
public restore(snapshot: Snapshot): void

Probably also need something in the registry to snapshot the list of all discovered pair & addresses (the arguments we need to initialize the pair). After the pairs are instantiated locally, the state can be restored.
The snapshot interface is something I need as well for arbbing because i snapshot & execute & restore states to pairs continuously.

Pair state snapshot is implemented https://github.com/terminal-fi/swappa/pull/11
Next step is figure out how to cleanly snapshot / restore registries and pairs.

Now that pairs can be snapshotted, then we can make it possible to take a registry, and snapshot the information needed to re-initialize each pair, & then restoring the snapshot state into these re-initialized pairs.
For each pair, there's the static state that is discovered from the registry and this information does not change per-block.
There's also the dynamic per-block pair state, that changes with each refresh()
Registry snapshot should only contain the static initialization data for all discovered pairs of that registry.

I need to complete this snapshotting feature now that there's helper smart contracts to accelerate the registry initialization and pair refresh process.
The idea is that the registry helper contracts need to provide enough information to generate a pair Snapshot and then per block, we just restore the state in bulk from the helper contracts on-chain.


Show whether the "latest" pip version is supported

Ever since I started using it, I've been a bit cautious about updating pip because I'd rather not break pip-tools. I don't really know how they version pip (I would assume semver) so I'm wondering when changes cause pip-tools to "break". Could a command in pip-tools or could the README be updated to display what the latest version of pip is that pip-tools supports? A command would be great so I don't have to keep checking the repository and just update pip-tools and check it then.
Would love to hear what you have to say too of course.

@AndreasBackx There is a kind of check at startup, but for the moment it is a lower bound at pip 8.0. Unfortunately, pip does not provide a programmatic API, but pip-tools depends on it to do it's work, so it theoretically break at a future pip version.
see assert_compatible_pip_version() in utils.py (https://github.com/jazzband/pip-tools/blob/master/piptools/utils.py#L27)

For the record, the lastest  version of pip is tested for every change.
(https://github.com/jazzband/pip-tools/blob/master/tox.ini#L6)
so the latest version is pretty safe.
A nice idea though would be to add a test with the master branch of pip (but configure it as an "allowed to fail" configuration) to see if the upcomming pip release is going to break pip-tools, and prepare accordingly.

Closing. We will make sure to support latest pip.


Add workaround for possible classloader deadlock when trying to load …

…JNI code
Motivation:
netty_epoll_linuxsocket_JNI_OnLoad(...) may produce a deadlock with another thread that will load IOUtil in a static block. This seems to be a JDK bug which is not yet fixed. To workaround this we force IOUtil to be loaded from without java code before init the JNI code
Modifications:
Use Selector.open() as a workaround to load IOUtil
Result:
Fixes https://github.com/netty/netty/issues/10187

@netty-bot test this please


Allow spaces in scenario titles. Fixes #73

Allows spaces in scenario titles. Works but now there is a popup with a warning. Can probably be disabled somehow but not sure how. Maybe just make a new issue for that? :D

Interesting this doesnt seem to work on Squeak 5.0 but works perfectly fine in our 6.0 and on 5.1

when saving a normal scenario, without white spaces, an error occures, but the scenario is saved correctly

When saving an scenario with a space in the name another error occures. With a note you are hinted that there may be a problem with the source files, but its fine just to say ok

@MarcelSchmidberger I actually can't recreate the first issue you are having. Did you do anything else to that class beforehand?

@Askir I am also not able to reproduce this error on a new squeak setup. I probably broke something within the old image... I think no further action is necessary


Store everything in SQLite

Content is currently stored in a mix of file system and database. There are benefits to storing all in the Database, since the majority of instances will be fairly small and having a single file for the content makes management simpler.


Would it be possible to release a first version

Hi!
After having played a bit with UniFlow, I would like to use it in one of my apps, instead of a similar(-ish) home made redux-like setup.  But in order to use it, I'd like to make the reference in my bower.json to point to a defined version, not to the head of the repository.
Would it be possible to put a tag and declare it as an initial version?

Done.

Wow, that was fast, thank you!!


Ubuntu/Debian Packages?

It would be great if this were packaged for Ubuntu. Has anyone thought of doing this?

Just as a heads-up:
As mentioned in https://github.com/cool-RR/PythonTurtle/issues/107#issuecomment-426899642, in addition to the GNU/Linux application bundle we now build on Travis, we'll probably build an AppImage, which is a format that allows packaging a single binary for all GNU/Linux distributions.
It's portable due to it's nature of complete isolation, easy to install (by end users) and can be distributed with configuration management tools, automatically. (Simply copy the binary, no need for a specific installation procedure -- apart from providing a desktop shortcut, probably.)
This obviously makes it totally optional to build a Debian package, a Snap package, a Flatpack package. If someone contributes this as an additional possibility for installers, fine.

For future reference, details about adding a Snap to Ubuntu Software: "Getting Python and wxPython apps into the Ubuntu app store" (blog post from the current Python newsletter)

I just git cloned this repo, cd PythonTurtle did a sudo apt install python3-wxgtk4.0  then python3 -m pythonturtle... working fine on my chromebook here, running in the ChromeOS' linux container thing.


StringDict implements Value and HasAttrs

allows StringDict to act as a package, containing Values
and responding to attribute queries.

This change is unnecessary. We already have a data type that has the characteristics this PR proposes for StringDict: starlarkstruct.
That said, I think we may want a variant of starlarkstruct to represent modules, if only so that when printed it doesn't show all its keys, but StringDict is not it.


Fix Config overrides

Fix the conf_styles_mapping() method
The current implementation of conf_styles_mapping() was incorrect and would return the value from settings of WAGTAIL_WORDPRESS_IMPORT_PREFILTERS. This is not the desired behaviour.
The desired behaviour for using an override for WAGTAIL_WORDPRESS_IMPORT_PREFILTERS is for a developer to provide a list of pre-filters to run on the HTML content.
If the config needs to be overridden or options passed in then as an example this is how the settings variable could be used:
WAGTAIL_WORDPRESS_IMPORT_PREFILTERS = [
    {
        "FUNCTION": "wagtail_wordpress_import.prefilters.linebreaks_wp",
    },
    {
        "FUNCTION": "wagtail_wordpress_import.prefilters.transform_shortcodes",
    },
    {
        "FUNCTION": "wagtail_wordpress_import.prefilters.transform_inline_styles",
    },
    {
        "FUNCTION": "wagtail_wordpress_import.prefilters.bleach_clean",
        "OPTIONS": {
            "ADDITIONAL_ALLOWED_ATTRIBUTES": {
                "wagtail_block_anchor_image": "data-href",
                "wagtail_block_anchor_image": "data-src",
            },
        },
    },
]

Here we are passing in OPTIONS of ADDITIONAL_ALLOWED_ATTRIBUTES. The result is that bleach filter will have extra attributes on a specific HTML tag that are not removed.
Ticket URL: https://projects.torchbox.com/projects/wordpress-to-wagtail-importer-package/tickets/107

Testing

[x] CI passes
[x] If necessary, tests are added for new or fixed behaviour
[x] These changes do not reduce test coverage

Documentation.

[x] Documentation changes are not necessary because: the documentation is already included in prefilters.md

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@e930c8f). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage        ?   65.09%
=======================================
  Files           ?       32
  Lines           ?     1255
  Branches        ?      224
=======================================
  Hits            ?      817
  Misses          ?      395
  Partials        ?       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e930c8f...5e6e243. Read the comment docs.

Thanks Nick. I just made the changes for the DEFAULT_PREFILTERS constant.
I also altered the tests a little I don't think they can be combined because each test initialises WordpressItem where the config is read each time.

Please excuse me pressing resolve button I couldn't see where the other changes requested is :)


Error in XML Format file examples leading to unexpected element "BCPFORMAT" error when used

XML Format files examples quoted on this page do not work.  Using example as is in SQL statement of the form:
BULK INSERT [TABLE_NAME] WITH (FORMATFILE = [FILENAME);
results in:
Msg 4855, Level 16, State 1, Line 1
Line 2 in format file ...... unexpected element "BCPFORMAT"."

Root cause is the xmlns being https in the example.  Change from:
<BCPFORMAT xmlns="https://schemas.microsoft.com/sqlserver/2004/bulkload/format" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
to:
<BCPFORMAT xmlns="http://schemas.microsoft.com/sqlserver/2004/bulkload/format" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
and the BULK INSERT using the XML format file will then work.
I expect it's because the XSD itself at https://schemas.microsoft.com/sqlserver/2004/bulkload/format/bulkloadschema.xsd specifies http, not https
<xsd:schema xmlns:xsd="[http://www.w3.org/2001/XMLSchema]()" xmlns:bl="[http://schemas.microsoft.com/sqlserver/2004/bulkload/format]()" targetNamespace="[http://schemas.microsoft.com/sqlserver/2004/bulkload/format]()" elementFormDefault="[qualified]()" attributeFormDefault="[unqualified]()">
Is it exceptionally unhelpful to have MS documentation providing examples that do not actually run successfully.  Issue has been raised by people on Stackoverflow https://stackoverflow.com/questions/54373618/why-does-format-file-cause-error-during-sql-server-bulk-insert

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bb0962c3-2d6a-9120-c5b7-70d2fb93cd23
Version Independent ID: e1a70d77-ace8-1a16-bbc8-ccd7acde5880
Content: XML Format Files (SQL Server) - SQL Server
Content Source: docs/relational-databases/import-export/xml-format-files-sql-server.md
Product: sql
Technology: data-movement
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

@petergoodrum -- thank you for your well-researched feedback.  I am updating this article.

@MashaMSFT -- Masha, please review this change in private PR 21351.


The built firmware cannot be flashed in: Data length error

I'm sorry to raise the problem again. I successfully compiled the firmware, but bootloader will display 'data long error' when it is flashed in. How can I solve it? Thank you very much!

The error means the binary to be flashed not fit in the particular partition, please check the binary size and compare with size in the mkrelease.sh mkfw command ( in bytes size )

I changed it mkrelease.sh  OK, but there is another problem: partition length alignment error. Is this the problem of data partition table?

Yes, there's problem with the partition table. The partition table must be 64 byte align. This partition table created automatically by mkfw when flashing, so the size length must be 64 bytes align.

Thank you very much for your reply. The problem has been solved. I will compile the firmware suitable for me.
CLOSE ISSUE


Mrs sophia l. Jackson

https://github.com/plaid/pattern-account-funding/blob/9387717ffecd08b0aa1891c29a1d7930317fb3da/server/routes/items.js#L81-L135

Why I can't get my investments money

Hi! These forums are for Plaid developers -- if you are having trouble with a Plaid-powered app, please contact the company that makes the app directly.

Yes I am how u get in touch with them


Need examples of acceptable syntax and formats for .PFX file path name in Az KeyVault Secret Store component

Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[ ] Read the contribution guide
[ ] Commands include options for Linux, MacOS, and Windows within codetabs
[ ] New file and folder names are globally unique
[ ] Page references use shortcodes instead of markdown or URL links
[ ] Images use HTML style and have alternative text
[ ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description
  I have not made any changes since I have never used the documents technology.  But here is what needs to happen, copied from Issue #1128.
The Azure Key Vault Secret Store component definition requires a name value pair for the certificate .pfx file:
name: spnCertificateFile
value : "[pfx_certificate_file_local_path]"
For the above value field, please provide examples of acceptable paths. Like fully qualified path, or just the .pfx file name in the .components directory (which does not seem to work -- does it always have to be a fully qualified path?  If so, say that.).
Please provide examples of acceptable path syntax. For Linix based systems I assume C:/something/somethingelse/ttt.pfx works, but this will not work on Windows systems which needs C:\something\somethingelse\ttt.pfx with each backslash escaped with another backslash.  Any single backslash produces an error.
Issue reference
  Issue #1128

@georgestevens99 - It looks like this PR bunches a lot of things from branch v0.11 to v1.0-rc3 and includes 23 files. If there is a specific change you'd like to propose to address the issue you mention please open a PR with that change only.

@georgestevens99 - It looks like this PR bunches a lot of things from branch v0.11 to v1.0-rc3 and includes 23 files. If there is a specific change you'd like to propose to address the issue you mention please open a PR with that change only.

Closing as the PR includes unrelated change and should come from a dev branch. Please open a separate PR to address specific issue mentioned for the correct target branch

Closing as the PR includes unrelated change and should come from a dev branch. Please open a separate PR to address specific issue mentioned for the correct target branch


Content from CCD Ahmedabad

Date: 24th September 2022
Event: Cloud Community Day
City: Ahmedabad
Name: Kaivalya Shah
Linkedin: https://linkedin.com/in/kaivalyashah
Talk topic: An Introduction to Serverless and Cloud Run
Presentation: https://docs.google.com/presentation/d/1_FxtpbEbmR9HVwSgOWmXO7QXAYFadphe_UOZMHfG6lc/edit?usp=sharing

Thank you.


Podman run fails to respect command arguments

/kind bug
Description
ls /root is respected that /root refers to the container.
cp -f /root/vmlinux-* /output not so.
Steps to reproduce the issue:

File list shows the file is there:
oci_name=kernel
semver=0.0.8
$ podman run --authfile ${auth_file} \
           --rm \
           --volume ${orig_cwd}/launch/artifacts/firecracker/kernels:/output \
           --entrypoint=busybox \
           yelgeb/${oci_name}:${semver} \
           ls /root
control_port.sh
vmlinux-5.3

The copy command is looking in the host
$ podman run --authfile ${auth_file} \
           --rm \
           --volume ${orig_cwd}/launch/artifacts/firecracker/kernels:/output \
           --entrypoint=busybox \
           yelgeb/${oci_name}:${semver} \
           cp -f /root/vmlinux-* /output
cp: can't stat '/root/vmlinux-*': No such file or directory

Same happens if you remove the --entrypoint flag and use the command busybox ...,

Describe the results you received:
cp: can't stat '/root/vmlinux-*': No such file or directory
Describe the results you expected:
Copy completed.
Additional information you deem important (e.g. issue happens only occasionally):
Output of podman version:
$ podman version
Version:            1.8.1
RemoteAPI Version:  1
Go Version:         go1.10.1
OS/Arch:            linux/amd64

Output of podman info --debug:
debug:
  compiler: gc
  git commit: ""
  go version: go1.10.1
  podman version: 1.8.1
host:
  BuildahVersion: 1.14.2
  CgroupVersion: v1
  Conmon:
    package: 'conmon: /usr/libexec/podman/conmon'
    path: /usr/libexec/podman/conmon
    version: 'conmon version 2.0.11, commit: '
  Distribution:
    distribution: ubuntu
    version: "18.04"
  IDMappings:
    gidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
    uidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
  MemFree:<PHONE_NUMBER>
  MemTotal:<PHONE_NUMBER>0
  OCIRuntime:
    name: runc
    package: 'containerd.io: /usr/bin/runc'
    path: /usr/bin/runc
    version: |-
      runc version 1.0.0-rc10
      commit: dc9208a3303feef5b3839f4323d9beb36df0a9dd
      spec: 1.0.1-dev
  SwapFree:<PHONE_NUMBER>
  SwapTotal:<PHONE_NUMBER>
  arch: amd64
  cpus: 2
  eventlogger: journald
  hostname: desktop.local.lan
  kernel: 5.3.0-40-generic
  os: linux
  rootless: true
  slirp4netns:
    Executable: /usr/bin/slirp4netns
    Package: 'slirp4netns: /usr/bin/slirp4netns'
    Version: |-
      slirp4netns version 0.4.3
      commit: unknown
  uptime: 118h 45m 3.21s (Approximately 4.92 days)
registries:
  search:
  - docker.io
  - quay.io
store:
  ConfigFile: /home/hedge/.config/containers/storage.conf
  ContainerStore:
    number: 77
  GraphDriverName: vfs
  GraphOptions: {}
  GraphRoot: /home/hedge/.local/share/containers/storage
  GraphStatus: {}
  ImageStore:
    number: 181
  RunRoot: /run/user/1000
  VolumePath: /home/hedge/.local/share/containers/storage/volumes

Package info (e.g. output of rpm -q podman or apt list podman):
$ apt list podman
Listing... Done
podman/unknown,now 1.8.1~1 amd64 [installed]

Additional environment details (AWS, VirtualBox, physical, etc.):
Physical.

Are you sure your shell isn't expanding the wildcard itself? Can you try /bin/sh -c "cp -f /root/vmlinux-* /output" as an alternative command, which should force the wildcard to be expanded by a shell within the container?

Not sure if this is intended behavior?
All commands have to be passed in like that?

If you enter a command on the command line,  the shell is going to interpret it. There is nothing podman or any other tool can do about it.  Bash sees the command first and interprets it before handing the arguments to the podman program.  This is the way shells work.

@rhatdan.  Point taken.  My apologies for cutting corners in the original report:
The original command I expected to work is:
$ podman run --authfile ${auth_file} \
           --rm \
           --volume ${orig_cwd}/launch/artifacts/firecracker/kernels:/output \
           --entrypoint=busybox \
           yelgeb/${oci_name}:${semver} \
           'cp -f /root/vmlinux-* /output'
: applet not found

Then by trial and error I got to a point where podman at least fed busybox a command busybox understood - the report I opened.
My understanding is that podman surrently handles the input for an entrypoint such that you have to provide cp in a way that the host's shell becomes involved. I'll spare you all the permutations of inputs I've tried.
I'm not sure, but I believe the above should work?
Apologies if I have overlooked something obvious.

By making cp -f ... into one large argument by wrapping it with quotes, Busybox is interpreting it in its entirety as the command to invoke (as opposed to command + arguments). Adding sh -c in front will make this work, as Busybox will invoke a shell to interpret the string, not treat it as a single command.
So podman run --entrypoint=busybox $IMG sh -c 'cp -f /root/vmlinux-* output/' should work.


StakeQueryInput does not support stake_lte query

Fixed by #1517

Found an issue with the implementation and must fix.

Fixed by #1519.


Cannot get plugin to work...

The handlebars syntax is still white:

I've installed, uninstalled and installed again. Restarted atom multiple times etc.
Am I missing a step?

I have the same problem. For me, the highlighting only works outside of HTML... which isn't very useful. Any Handlebars I call inside of an HTML tag doesn't get highlighted.
When I inspect with dev tools, I can see this is because the scope classes aren't being applied.

+1

Strange. Maybe the latest update changed something. I'll look into it.


Bugfix: radiation_daysim.create_gml.building2d23d() can not read number of floors from input files

bugfix for reading inputs from dbf in radiation_daysim.create_gml.building2d23d()

closed after merging


Is there an updated list of available symbols?

How did you get this list? Is there a script for this? Thanks for your tame, this list looks insanely useful.

Updated.


Fix: upgrade to the latest @lwce/router

This fixes some critical bugs where the routeParams and history wire adapter weren't properly getting initialized on page load. This means that currently, if you try to search a product in the app using the top navigation, there is a critical error. Also, if you navigate to a product and refresh the page, you will also see an error.
The fix lies within @lwce/router. See the change here for more information: https://github.com/LWC-Essentials/router/commit/c9b447ced812d658f27dd1ef895dcdccea0b5a11#diff-6a1ee8738e4ad22fe971367a75800387R34
Essentially I should have been using connectedCallback instead of renderCallback because the latter doesn't run until after children are rendered. I need it to run before children are rendered, because the children of the component need access to the wire adapter context.
All Pull Requests:

[x] Have you considered Security (e.g. XSS)?
[x] Have you considered desktop, mobile and tablet form-factors?
[x] Have you considered Accessibility best practices?

Code

[x] Are the commits squashed into one commit?
[x] Is the branch name and commit message following team convention?
[x] Is the code linted?
[x] Are all open issues, questions and concerns by Reviewers answered, resolved and reviewed?

Quality Assurance

[x] If applicable, are Unit Tests written and all tests are passing?
[x] If applicable, are Integration Tests written and all tests are passing?
[x ] If applicable, are UI Automation Tests written and all tests are passing?

Documentation

[x] Are there meaningful code comments included?
[x] If applicable, are test cases written?
[x] If applicable, is Change Log updated?
[x] If applicable, are UI Texts reviewed by Documentation?

Security

[ ] If applicable, has Security reviewed this code?
[ ] If applicable, is a 3PP request submitted?

Archiving this Repo closing this PR


Implement short description of indicator in sidebar

Description
We need to give a short description of each indicator in the sidebar. Ideally this comes from the YAML file for each indicator.
Tasks

[ ] Decide how to represent this in the YAML file
[ ] Finalize copy for short descriptions
[ ] Define contract between frontend/backend and where is handoff
[ ] Test!
[ ] Implement front end code to pull this field from JSON generated in data-pipeline

Definition of Done

Website shows short descriptions for each indicator in sidebar

https://app.zenhub.com/workspaces/justice40-60993f6e05473d0010ec44e3/issues/usds/justice40-tool/428


update dependencies

Coverage remained the same at 96.721% when pulling 6444b67641915a23c9cc64dcb453fcaee453ed4a on dev into b13e103d23ec62aca289af76338291e1e6d4e0f5 on master.


TODO: Bitcart roadmap February 2020

[ ] Add more server management settings to admin (lightning management?)
[ ] Finalize docs
[ ] Add more examples of usage and new features to SDK(MrNaif2018/bitcart-sdk#3)
[ ] Tor and using your own node support(MrNaif2018/bitcart-docker#8)
[ ] Add omni layer support(electrum-omni probably)
Previous month: #96

A massive update came out, we have switched our auth scheme to OAuth tokens.
Next month(skipping March due to some issues): #103


shims: repair the build for android

The math long double variants are only on x86/x86_64 (FP128 is
currently unsupported so ARM64 support is excluded).  However, Windows
and Android are FP64 and should not define the long double variants.
The original condition was completely incorrect as the double variants
are available everywhere.  This repairs the builds on android ARM64.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test tensorflow

sigh linter on a different file.


Fixed issue #16749

The merging is blocked. On my screen, it failed at the "import/copybara" step. The "Details" link on the right hand side points to "http://go/import-review/176740" which does not make sense to me. I tried relative links "https://github.com/keras-team/keras/pull/go/import-review/176740", "https://github.com/keras-team/keras/go/import-review/176740", etc., but they did not work.
Would you please tell me what I should do to clear the block? Thanks!

The merging is blocked. On my screen, it failed at the "import/copybara" step. The "Details" link on the right hand side points to "http://go/import-review/176740" which does not make sense to me. I tried relative links "https://github.com/keras-team/keras/pull/go/import-review/176740", "https://github.com/keras-team/keras/go/import-review/176740", etc., but they did not work.
Would you please tell me what I should do to clear the block? Thanks!

Hi @asukakenji  This is to inform you that, nothing to do from your side at this moment. We are processing this PR internally. Thank you!


Some more predefined Metrics

Fixes #342
Addresses #309 a bit!!

Hello @ritzvik! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/einsteinpy/symbolic/predefined/minkowski.py:

Line 16:1: W293 blank line contains whitespace

In the file src/einsteinpy/symbolic/predefined/vacuum_solutions.py:

Line 18:75: W291 trailing whitespace
Line 20:1: W293 blank line contains whitespace


Problem with display calendar on MacOS

If I run calendar on mac os then I see the following additional lines on the left side.

Are you using indentLine plugin?

Yes, but I use indentLine on my work pc (Ubuntu 14.04 and RedHat 7.0) and I don't have the same lines. Is it possible to disable this plugin only for calendar.vim?
Also, today I updated version of calendar.vim on my mac machine and calendar isn't working now. I got the following error:
Error detected while processing function 137[16]..129[2]..134[4]..181[27]..212[1]..253[1]..414[8]..413[21]..279[8]..277[1]..287[16]..calendar#google#calendar#getEvents:
line   27:
E706: Variable type mismatch for: c
Error detected while processing function 137[16]..129[2]..134[4]..181:
line   27:
E706: Variable type mismatch for: r
Press ENTER or type command to continue

Do you know what is it?
Thank you in advance.

Oops, the E706 error was due to my small error, sorry.

I think you can use g:indentLine_fileTypeExclude to disable the plugin in calendar buffer.

Thank you. Now it works. Unfortunately g:indentLine_fileTypeExclude isn't working for this case. But I'll try to find solution.


ops: update gitignore

Description:
add .envrc to gitignore

:tada: This PR is included in version 1.2.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Release version v0.0.25

Description of changes:
Releases version v0.0.25 to release new image with the updated Dockerfile in code-generator
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


Namespace details, Collections tab - use the same filter as Collections screen

Fixes https://issues.redhat.com/browse/AAH-245, https://issues.redhat.com/browse/AAH-544, https://issues.redhat.com/browse/AAH-555
This unifies filtering on both collection list screens:
Collections > Collections

(no change)
Collections > Namespaces > View Collections > tab Collections
before:

after:

This also allows EmptyStateFilter to reset the filters, enabled in Collections and in Namespace detail:

Two remaining differences remain:

no card view on namespace detail page, only list view
clearing filters doesn't clear the search input (also present in users, but not groups, with a similar issue in containers)

Cc @ZitaNemeckova , @sbuenafe-rh this should be ready :)

@himdel On the namespace page, the list view of all the collections, the toolbar should be connected to the list.

Adding backport-4.3, as all 3 issues are slated for 4.4cloud*


v2.0.0: Use Node crypto.scrypt

Any updates on this?

@Cretezy Did you end up using another module?

My fork is using the Node built-in crypto. You can try it out, @Cretezy/phc-scrypt


Release v. Next

@dblock Any chance you can get around to this soon?

This weekend unless someone beats me to it.

I will take care of that on this weekend, most likely, today :smile:

Thank you @dnesteryuk and @dblock. 1.3.2 looks great. I think we can close this out.

I guess we can keep this thread, so people can request next release :wink:

There are some changes inroduced in 1.3.0 (and still valid for 1.3.2) that broke our production app after update.
We have app1 (Rails + Grape), app2 (Sinatra), frontend app. Frontend app communicates with app2 which in turn proxy requests to app1 using curb gem. When we used Grape 1.2.5 - everything was OK. But when we just changed version number in Gemfile and run the app with 1.3.0 - frontend app started to show infinite loader for requests. While debugging I found that Grape API start to respond to curb with Transfer-Encoding chunked O_o
I'll try to create a reproducable script for this, but don't sure how long it ill take. Maybe maintainers have an idea what could face such issue? I reviewed all the changes in git between 1.2.5 and 1.3.0 and didn't find the culprit :( Maybe I'll also try "by-commit" strategy to investigate

And app2 starts to receive response headers with Transfer-Encoding chunked and never finish the request. Should I create an issue for that? I don't know if could create a reproducable example..

Thanks for bringing this up and for hunting down what changed. You should open a new issue either way. I think we need two things:

Find a workaround. You should figure out why your app stopped working and how to fix the app - IMO transfer-encoding and request not finishing are just symptoms, why would it break a client?
A new paragraph in UPGRADING once we figure out what the issue is.

OK I created a reproducable example with small readme on how to test it: https://gist.github.com/nbulaj/bd89ba366290033bf71c0f9b60927709
So before the changes I pointed above it worked, and with a new changes it doesn't

And app2 starts to receive response headers with Transfer-Encoding chunked and never finish the request

just a bit clarification, it starts to receive but unable to proxy those requests properly(the browser waits for a proper chunk).
without proxy/with proxy

Transfer-Encoding is a hop-by-hop header, that is applied to a message between two nodes, not to a resource itself.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Transfer-Encoding

You should figure out why your app stopped working and how to fix the app

on a quick look, grape does not set Content-Length header on its side and relies on rack
so, according to the information above
before https://github.com/ruby-grape/grape/pull/1956 the payload was prepared with https://github.com/rack/rack/blob/master/lib/rack/content_length.rb
but after the response was changed to "chunked" one with https://github.com/rack/rack/blob/master/lib/rack/chunked.rb
this broke the proxy client, as it unable to properly forward chunked requests(either chunk by chunk or collect and send all chunks together;Content-Length and Transfer-Encoding: chunked cannot be used at the same time)

Yep, thanks for clarification @dm1try . Seems like you right about the reason. I created an issue for this (https://github.com/ruby-grape/grape/issues/2051) as this one is about releasing process and requests, so maybe let's move our discussion there. Thanks!

I guess we can keep this thread, so people can request next release 😉

Would love to see 1.3.3 for https://github.com/ruby-grape/grape/pull/2040 🙇

1.3.3 was released 2020/05/23

Time for a v1.3.4? The recent changes concerning Ruby 2.7 compatibility definitely deserve a release.

I'd like #2072 to go in at least.

👍 as per demonstrated interest in https://github.com/ruby-grape/grape/issues/2075 :P

Since #2072 got merged v1.3.4 should be unblocked, right? Any chance you could get a new release out to rubygems.org @dblock? ❤

We want https://github.com/ruby-grape/grape/pull/2084 too.

Yeah, could we get v1.3.4 to pull in #2084? That one is quite concerning.

I released 1.4.0.


Wrong TypeScript version is shown when using a workspace version

VSCode Version: 1.11.2
OS Version: Windows 10 1607

Steps to Reproduce:

Start a new node project.
Install a local version of TypeScript from node: npm install<EMAIL_ADDRESS>--save-dev.
Add the setting to use the workspace version of TypeScript: "typescript.tsdk": "./node_modules/typescript/lib"
Switch to the workspace version:

The command palette has picked up the correct version, but it's not shown at the bottom of the window:

Did you also reload the VSCode window? This is required in 1.11 for the TypeScript version change to take effect

@mjbvz yes I reloaded the window when it prompted me to.
I don't know what has happened since Monday because it's working in my sample project and another production project now.
Thanks for the quick reply.


Move lua branch code under single api-umbrella repository

Move the lua-router-integration branch from the gatekeeper project to a lua branch under this api-umbrella repo. I'll detail my thinking more later, but in short, I think this will make it much easier to manage all the core components that make up API Umbrella.

Moved: https://github.com/NREL/api-umbrella/tree/lua


Functional tests not passing when Minio server has a new default region

When I set Minio region to "us-west-2" in ~/.minio/config.json, functional tests won't pass anymore:
$ go run functional_tests.go
...
INFO[0015]                                               file=functional_tests.go function:=main.testGetObjectClosedTwice line#=665
FATA[0041] Error:Put http://localhost:9000/minio-go-testiuzn23cfq9jrzlcnz/1yzgz903xtgj9tceycazirws0cmlla: Connection closed by foreign host http://localhost:9000/minio-go-testiuzn23cfq9jrzlcnz/1yzgz903xtgj9tceycazirws0cmlla. Retry again.minio-go-testiuzn23cfq9jrzlcnz1yzgz903xtgj9tceycazirws0cmlla  file=functional_tests.go function:=main.testGetObjectClosedTwice line#=705
exit status 1

testGetObjectClosedTwice() test creates a bucket on us-east-1 and does  a PutObject request - server rejects the request because of signature mismatch (server uses u-west-2). Perhaps we should make SERVER_REGION an optional environment variable for Mint so that it isn't hard coded for functional tests.

@poornas, the test testPutObjectWithMetadata is successful though server region is us-west-2, I don't see why testGetObjectClosedTwice would fail. I think there is a bug somewhere.

The cause is Unexpected EOF when the http request is executed, seems to be related to limitReader implementation(PR #780).  Not identified a fix yet.

package main

import (
	"bytes"
	"fmt"
	"io/ioutil"
	"log"
	"math/rand"
	"time"

	minio "github.com/minio/minio-go"
)

func main() {
	// Seed random based on current time.
	rand.Seed(time.Now().Unix())

	// Instantiate new minio client object.
	c, err := minio.New("localhost:9000", "minio", "minio123", false)
	if err != nil {
		log.Fatal("Error:", err)
	}

	bucketName := fmt.Sprintf("minio-go-test.%d", rand.Int())
	err = c.MakeBucket(bucketName, "us-east-1")
	if err != nil {
		log.Fatal("Error:", err, bucketName)
	}

	bufSize := rand.Intn(1<<20) + 32*1024
	var reader = ioutil.NopCloser(bytes.NewReader(bytes.Repeat([]byte("a"), bufSize)))
	defer reader.Close()

	// Save the data
	objectName := fmt.Sprintf("obj.%d", rand.Int())
	_, err = c.PutObject(bucketName, objectName, reader, "binary/octet-stream")
	if err != nil {
		log.Fatal("Error:", err, bucketName, objectName)
	}
}

This is the code that reproduces the issue, the reason is that a wrong region is specified when creating the bucket. MakeBucket() can manage when the user passes an empty or wrong region but it looks it doesn't update internally the correct region, I guess after calling bucket location API. That's why PUT fails.

Is this still a problem @poornas @vadmeste ?

With the given sample code, I am unable to reproduce the issue with the latest version of minio-go connecting to my local Minio server (Version: 2017-09-01T19:22:40Z) with the region attribute in config.json file set to "us-west-2".

yeah @kannappanr , sorry.. That example only shows an error log in Minio output which is a normal thing since the passed region is wrong. The following code reproduces the issue seen in minio-go function tests:
package main

import (
	"bytes"
	"fmt"
	"io"
	"log"
	"math/rand"
	"os"
	"time"

	minio "github.com/minio/minio-go"
)

type sizedReader struct {
	io.Reader
	size int
}

func (l *sizedReader) Size() int {
	return l.size
}

func (l *sizedReader) Close() error {
	return nil
}

type randomReader struct{ seed []byte }

func (r *randomReader) Read(b []byte) (int, error) {
	return copy(b, bytes.Repeat(r.seed, len(b))), nil
}

// read data from file if it exists or optionally create a buffer of particular size
func getDataReader(filePath string, size int) io.ReadCloser {
	if _, err := os.Stat(filePath); os.IsNotExist(err) {
		return &sizedReader{
			Reader: io.LimitReader(&randomReader{seed: []byte("a")}, int64(size)),
			size:   size,
		}
	}
	reader, _ := os.Open(filePath)
	return reader
}

func main() {
	// initialize logging params
	startTime := time.Now()
	function := "GetObject(bucketName, objectName)"
	args := map[string]interface{}{
		"bucketName": "",
		"objectName": "",
	}

	// Seed random based on current time.
	rand.Seed(time.Now().Unix())

	// Instantiate new minio client object.
	c, err := minio.New("localhost:9000", "minio", "minio123", false)
	if err != nil {
		log.Fatalln(function, args, startTime, "", "Minio client object creation failed", err)
	}

	// Enable tracing, write to stderr.
	// c.TraceOn(os.Stderr)

	// Set user agent.
	c.SetAppInfo("Minio-go-FunctionalTest", "0.1.0")

	// Generate a new random bucket name.
	bucketName := fmt.Sprintf("minio-go-test.%d", rand.Int())
	args["bucketName"] = bucketName

	// Make a new bucket.
	err = c.MakeBucket(bucketName, "us-east-1")
	if err != nil {
		log.Fatalln(function, args, startTime, "", "MakeBucket failed", err)
	}

	// Generate 33K of data.
	bufSize := 33 * 1024
	thirtyThreeKiB := bufSize

	var reader = getDataReader("datafile-33-kB", thirtyThreeKiB)
	defer reader.Close()

	// Save the data
	objectName := fmt.Sprintf("obj.%d", rand.Int())
	args["objectName"] = objectName

	_, err = c.PutObject(bucketName, objectName, reader, "binary/octet-stream")
	if err != nil {
		log.Fatalln(function, args, startTime, "", "PutObject failed", err)
	}
}

datafile-33-kB should not exist in file system to reproduce the issue.
I am currently investigating the exact origin of the problem.

The fix for this issue is to not set the BucketLocationCache in MakeBucket method in the file api-put-bucket.go .
func (c Client) MakeBucket(bucketName string, location string) (err error) { 	defer func() { 		// Save the location into cache on a successful makeBucket response. 		if err == nil { 			c.bucketLocCache.Set(bucketName, location) 		} 	}()
This will require the PutObject to request the Bucket Location from the server and then calculate the signature.

@kannappanr, thanks for bringing up this.
Actually it seems there is more than one bug here,
The first one which is catching my attention is that we are retrying requests even when the user passes a io.Reader. We can't seek to the beginning of data before we retry the request. That's why we have that weird error "Connection closed by foreign host" in minio-go.
The second one, is that PutObject() is still signing requests with us-east-1 region (I added some log to detect that), so the correct region must be updated in MakeBucket()

@harshavardhana, it looks like Minio server doesn't refuse a make bucket request with wrong region, minio-go doesn't even know if it sent a correct or wrong region in contrast to other API calls.
In that case, I think @kannappanr suggestion makes sense now, we shouldn't cache bucket location after a make bucket call. It doesn't seem there is another solution. Besides, it seems to me an acceptable solution since MakeBucket() is not kind of functions that will be heavily called.

@vadmeste that was done on purpose . We used to refuse but did that for requirements of gateway. Also region is sort of meaningless we also support region as empty as well. So any region based tests are not valid with Minio.

Make bucket can cache but only on success..

Make bucket can cache but only on success..

I am not sure I understood this, Make bucket already makes only one successful request to create a bucket even if the passed region is wrong. How caching only on success will resolve the problem ?

This is the related PR https://github.com/minio/minio/pull/4969

This is fixed in Minio server @vadmeste , feel free to close it if it fixes the minio-go problem.

Fixed by https://github.com/minio/minio/pull/4969


impl std::error::Error

why does failure::Error not implement std::error::Error ? this makes it rather annoying to use with libraries that don't use failure.
in my case:
Deadline::new(something_that_returns_failure, ....)
.map_err(|e|Error::from(e))
.and_then(move |rq|{
     return Err(Failure...

176 |                     .map_err(|e|Error::from(e))
    |                                 ^^^^^^^^^^^ the trait `std::error::Error` is not implemented for `failure::Error

That's not possible b/c there's an impl<T: ::std::error::Eror> Fail for E. If you add an impl in the opposite direction, you'll get overlapping impls.
There's compat method, which you are probably looking for: https://docs.rs/failure/0.1.2/failure/trait.Fail.html#method.compat

Thanks, got it


Directories cleanup

Rearranged directories so that docs, keycloak, scripts are not in backend anymore and
are easier to find. Moved some files around as well. Top level directories are now:
/.github
/backend
/docker
/docs
/frontend
/scripts

I'm wondering is it possible to change "keycloak" to "clowder_keycloak"; as well as "keycloak.py" to "clowder_keycloak.py" to avoid confusion when important and potential naming collision? We are installing the python keycloak package it's also named "keycloak".
But ^ this doesn't break anything so far so it's not very necessary at least for now.

PR looks good. Approving.

I'm wondering is it possible to change "keycloak" to "clowder_keycloak"; as well as "keycloak.py" to "clowder_keycloak.py" to avoid confusion when important and potential naming collision? We are installing the python keycloak package it's also named "keycloak".
But ^ this doesn't break anything so far so it's not very necessary at least for now.

The /scripts/keylcloak folder? It's not a python folder so it shouldn't be an issue?
Or the /backend/app/routers/keycloak.py module? maybe keycloak_routes.py?  or kc.py? I would rather avoid repeating the word clowder.

I'm wondering is it possible to change "keycloak" to "clowder_keycloak"; as well as "keycloak.py" to "clowder_keycloak.py" to avoid confusion when important and potential naming collision? We are installing the python keycloak package it's also named "keycloak".
But ^ this doesn't break anything so far so it's not very necessary at least for now.

The /scripts/keylcloak folder? It's not a python folder so it shouldn't be an issue?
Or the /backend/app/routers/keycloak.py module? maybe keycloak_routes.py? or kc.py? I would rather avoid repeating the word clowder.

maybe just keycloak.py to keycloak_routes.py


Allow for discriminated unions in OpenAPI schema

This PR enhances the schema transformation logic by recognizing discriminated unions and skipping the forced additionalProperties: false constraint for them. As a result, complex, variant-based schemas remain flexible and validate correctly. Testing against the OpenAI API confirms that this approach is supported.

Thanks! Is there a chance for a test maybe?

The approach I'm suggesting removes an existing, untested workaround that forces additionalProperties=false when it is unnecessary. I've verified through testing that OpenAI accepts discriminated unions without this property, but there's no spec for this behavior.
The current implementation in ChatRequestBody automatically applies provider-specific schema transformations. Given that different API providers may have varying expectations, a more robust approach might be to allow users to supply their own final OpenAPI schema for structured outputs, rather than automatically applying provider-specific workarounds on top of it.
I think merging the PR short-term to address a current functionality limitation and then moving away from making assumptions about provider behavior or at least offering override options would help get us to a more reliable solution faster than adding tests for undocumented provider behavior.

Ok, thanks, let's see how it works :) Would you be able to work on the target solution? Either way, if you could create an issue describing the work to be done, that would be great.

Thanks for the merge. I'll create an issue for the provider specific adaptation question.


v3: Assumes global $, does not play well with Browserify and ES6 modules

Would you take a patch so that all classes receive a reference to the jQuery object?

Hm I am building the project using browserify, but admittedly there are only es5 modules.

Hey! What if we do something like this:
!((factory) => {
  if (typeof module === 'object' && typeof module.exports === 'object')  {
    try {
      const jquery = require('jquery')
      factory(jquery)
    } catch (_) {
      factory(window.jQuery)
    }
  } else {
    factory(window.jQuery)
  }
})(($) =>

To initialize the plugin, so if we have the require we would use that to load jquery, in case we can't we fallback for window.jQuery
So it would work well in es6 modules + browserfy and I think it would keep the same behavior as today if we have window jquery.
Let me know what do you guys think and if that sounds good for you I will open a PR

yeah, wrapping the entire bundle in that should work. we'd also need to derequire the bundle in order for it to be browserified again by users, else browserify will try to resolve the require() calls inside the generated bundle.

PR https://github.com/transloadit/jquery-sdk/pull/63

❤

I'll keep this issue open until new version is deployed to the CDN. Thanks!

👋 Can you please let us know when this is deployed? Thanks!

Wanted to but ran into: You do not have permission to publish "transloadit-jquery-sdk". @tim-kos can you do this?
Happy holidays!
--
Kevin van Zonneveld (kvz.io)
Co-founder at Transloadit (transloadit.com)
Core-author of tus (tus.io)
On 19 December 2017 at 05:32:38, Damian Janowski<EMAIL_ADDRESS>wrote:

👋 Can you please let us know when this is deployed? Thanks!
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/transloadit/jquery-sdk/issues/56#issuecomment-352637157


[Testing] PR #3251

This issue is intended to track #3251.
It must be tested in Windows (@bernatx and @XGodina) and Linux (@Axel1092).

Make sure the client colors mimic the original UE4 colors.
Make sure all the semantic tags are correctly displayed.

Works!

Works for me also, in windows.

This issue is intended to track #3251.
It must be tested in Windows (@bernatx and @XGodina) and Linux (@Axel1092).

Make sure the client colors mimic the original UE4 colors.
Make sure all the semantic tags are correctly displayed.

Works for me also, in windows.

Where can we download 0.9.10?

Hi @pangxiao2013
You can download here: http://carla.org/2020/09/25/release-0.9.10/


[Draft] Transfer call spike

What

Can test adhoc calling test Teams users and then transfer to another Teams users.
Can test calling a Call Queue as an ACS/CTE user and see that a Teams user set to answer for Call queue will be transferred to ACS/CTE user

James the Manual Stale PR Bot: Closing old draft PR that has not seen activity in over 1+month. Please reopen as necessary.


task(prettier): add diff view

Current dependencies on/for this PR:

main

PR #1428   👈

This stack of pull requests is managed by Graphite.

Oh wow this is pretty nice! Thank you!


fix openms test data workaround

The workflow sync messed up the test data generation (needed for OpenMS). The workaround is to call test-data.sh for all repos (and not only those in the chunk) .. which makes no difference as long as OpenMS is the only tool using this.
I guess it would be good if I could find time to work on something like this https://github.com/galaxyproject/tools-iuc/pull/2908

@bernt-matthias how stable are the test file URLs. I would really like to enable Galaxy to upload test data from a URL.
This way we don't need any hacks and Galaxy could pull the datasets whenever we need it.

The input file should be part of the openms release + 2 external sources https://github.com/galaxyproteomics/tools-galaxyp/blob/5e4f8567c0145de8c6f9344fe4ee4c3bf2a81e59/tools/openms/test-data.sh#L105 https://github.com/galaxyproteomics/tools-galaxyp/blob/5e4f8567c0145de8c6f9344fe4ee4c3bf2a81e59/tools/openms/test-data.sh#L113. But outputs and parameter files are re-computed https://github.com/galaxyproteomics/tools-galaxyp/blob/5e4f8567c0145de8c6f9344fe4ee4c3bf2a81e59/tools/openms/test-data.sh#L203 (the script is dynamically generated and outputs might differ with improvements to the generation an ctdopts/ctdconverter).


Re-ordering config validation

according to this breaking changes #1686, adding more explicit error message would help.

The canonical way for checking additional fields is checkOverflow(), see e.g. https://github.com/prometheus/prometheus/pull/1728/files#diff-3baf47c64847a8fb8aaa8cc2e088513bR643. My idea was more to just move the checkOverflow() call to the top of the validation method in general, and in all cases (not only for the file SD). But since that's a more fundamental change, it might make sense to hear @fabxc's opinion on that general approach before implementing it.

ah i didn't notice, sorry :/. ok then let's wait for @fabxc

Yes, swapping validation order seems right here.
On Sun, Jun 12, 2016, 4:37 PM Ali Reza<EMAIL_ADDRESS>wrote:

ah i didn't notice, sorry :/. ok then let's wait for @fabxc
https://github.com/fabxc
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/prometheus/prometheus/pull/1728#issuecomment-225438447,
or mute the thread
https://github.com/notifications/unsubscribe/AEuA8i5-_ts2VW3uHYWKp7gjL1BZ5RGNks5qLBmegaJpZM4IzzX9
.

i'll make the changes then

Thanks 👍


ENH: bump boost-headers-only to 1.80.0

Reference issue

Closes gh-15136

What does this implement/fix?

upgrades Boost 1.75.0 -> 1.80.0

Additional information

FreeBSD patch may need to be remade

@h-vetinari CI failure here looks unrelated to Boost changes -- no rush, but if you have a chance to look at impacts to conda-forge and it works, besides the OpenBSD/FreeBSD patch and updating scipy/boost-headers-only, this might be ready to go

Could you rebase on main? There are several CI fails on macosx_arm64 that I'm hoping my get fixed by this PR. The CI infrastructure isn't present yet in your branch.

Could you rebase on main? There are several CI fails on macosx_arm64 that I'm hoping my get fixed by this PR. The CI infrastructure isn't present yet in your branch.

Should have latest main now as well as latest upstream patch for M1 compiler bug

Do I understand that this will fix gh-14901? Any chance it also fixes gh-17101?

It doesn't fix the issues we're seeing on macosx_arm64 on cirrus.

Do I understand that this will fix gh-14901? Any chance it also fixes gh-17101?

These should both be fixed in Boost 1.81.0.
https://github.com/scipy/scipy/issues/14901 was fixed with https://github.com/boostorg/math/pull/827
https://github.com/scipy/scipy/issues/17101 will be fixed with https://github.com/boostorg/math/pull/846

It looks like gh-17146 is fixed by https://github.com/boostorg/math/pull/847, too. Thanks @mborland!
Will all these make it in this PR, @mckib2?

It looks like gh-17146 is fixed by boostorg/math#847, too. Thanks @mborland!
Do you think we can get 1.81 before SciPy 1.10.0 releases, @mckib2?

Boost 1.81 is scheduled to release the 14 of December. Do you use the standalone version of Boost.Math, or the Boost super project? If you are using the standalone we can cut a 1.80.1 in the event 1.81 doesn't meet your timeline.

We have been generating headers from the "regular" Boost distribution which includes most of the super-project.  I believe we did it this way as we thought we might anticipate using other Boost libraries, but I don't think that's a huge concern for us now. Boost.Math is really all we need.
@mdhaber @rgommers Is it worth the small refactor in scipy/boost-headers-only to use the standalone version of Boost.Math?  It's unclear to me if anyone else is now relying on that repo to provide more than just Boost.Math.

Anyone else in SciPy? I don't think so. I think you reviewed the only other use of Boost in SciPy that I know of, which is (presumably Math) in scipy.special.

@mdhaber @rgommers Is it worth the small refactor in scipy/boost-headers-only to use the standalone version of Boost.Math? It's unclear to me if anyone else is now relying on that repo to provide more than just Boost.Math.

That does sound like a good idea to me - smaller checkouts, and more flexible in terms of releases it looks like.
No one else should be relying on that repo, and in case they do they can just fork it and do their own thing. This is meant for SciPy only.
One thing to keep in mind is to not lose the old commits in the boost-headers-only repo. It can be a disconnected commit history in the main branch though.

Please revert as much of gh-17272 as possible when this PR gets merged.

If we use the standalone version of Boost.Math, we may no longer need the machinery around the Boost headers-only repo.  In this case, closing this PR in favor of gh-17432 which includes Boost.Math directly

On the other hand, we've discussed using additional parts of Boost, like the odeint and polygon. Would these still be available with gh-17432?

It can always be reverted. Boost is huge, so adding a dependency on more of it probably needs a separate conversation. Looking at those topics, it also seems that those may not materialize. scipy.integrate gets very little attention, and polygon would be for scipy.spatial I guess? We also have no owner for QHull there at the moment.


Update

This small PR updates the code so that polo compiles again without any deprecation or warning.
All tests pass.

Thanks!


Adding release 1.3 schedule to features repo

Adding this for parallelism to 1.4.  Will update other wikis to point here authoritatively.
@idvoretskyi @erictune

@goltermann I am not really familiar with this document or where it comes from. Could you add some context to your commit message? Thanks!

Sorry, yeah, more details.  This is just a cut and paste from elsewhere.
We used to have this 1.3 doc under kubernetes/kubernetes/wiki/release-1.3.  The similar 1.4 doc was created under kubernetes/community/wiki/release-1.4.  Now we're removing them from the kubernetes and community repos to re-home them in the features repo, and under source control rather than wiki format.  I've updated those previous locations to point here.
The "approval" was just me marking the day it was presented in the community hangout and agreed on as plan of record.

@philips we have approved, but had zero bandwidth to commit. Thank you, @goltermann!


setOptions

Is there a way of using visjs methods, like setOptions, what using vis-react?
What I would like to do, is change options after some visjs event is trigged, or change options after stabilization is finished.

Hi,
sorry, I missed this on my documentation.
I already exposed vis instance through the prop name vis. you can access all vis methods through this prop
<Graph
   graph={this.state.graph}
   style={this.state.style}
   options={options}
   getNetwork={this.getNetwork.bind(this)}
   events={this.events}
   vis={vis => (this.vis = vis)}
/>

looking forward to more suggestions

Hi, thank you so much for your quick response.
I'm not sure did I understand you correctly, I need both getNetwork and vis props to access vis instance? So I need to have vis variable and getNetwork method in my parent?


docs/Maintainer-Guidelines: retire lead maintainer position in Febuary.

On February 1st 2019 I will step down as the lead maintainer of Homebrew.
I've been following a bunch of the recent public and private discussions and it seems there's a broad consensus that the lead maintainer position should not exist in its current form but that we're not yet ready to make a clean break to a new leadership format. As a result I've decided to announce a date well in advance to step down so those interested (myself included) can get involved with planning what the future looks like after we've moved beyond an unelected lead maintainer. This may include elections, a project leadership committee and/or technical steering committee (which itself may be per-repo or for the project as a whole). I've documented some of the reading for inspiration here; I'd encourage others to suggest more links/reading for there.
As we have the funds to do so: I'd also like to make an early suggestion of considering having Homebrew maintainers and others who may join a PLC or TSC physically meet up somewhere before (or even on) February 1st 2019 in order to bond as a team and have some high-bandwidth communication together.
Thanks everyone for your input and hard work on Homebrew @Homebrew/maintainers. This has been a bit of a bumpy time but we'll figure it out together and end up with something even better.
💝

recent public and private discussions and it seems there's a broad consensus that the lead maintainer position should not exist in its current form

I haven’t felt consensus from the public discussions, and now I regret not relaying my support in private, regarding the good work you do.
But I have said in public that I like the system as is, with a lead maintainer and you in that position, so I’m against this PR. Not that it makes a difference if you’re adamant, as we can’t force you to keep the position, but for what it’s worth I’d like for you to reconsider.

I haven't really contributed to the discussions lately and I don't know if my opinion counts really anyways but I just wanted to say that I am quite happy with how Homebrew has been run over the last couple of years and I think that Mike has been doing an absolutely outstanding job.
@MikeMcQuaid I do hope that once things have cooled down a bit you will reconsider your retirement plans.

Thanks all for the kind words, folks!
I have not yet decided whether my retirement as lead maintainer will result in my retirement as a maintainer too and whether I'll continue to sit on a PLC, TSC or run for an elected position within Homebrew.

I have commented publicly before, but will repeat here: that I think both that the leader maintainer position is a good thing to have, and that you are an absolutely perfect person for the job.
I will be glad to participate in discussions about the future of Homebrew leadership, but they should not cast too much shadow over the fact that the project overall is running very well (even though there is always room for improvement!). I have also stated my belief that a stronger steering committee / PLC — or maybe more communication from the steering committee / PLC — would be beneficial for the community, for all involved, and for the lead maintainer as well :)

@MikeMcQuaid  I agree with having a lead maintainer too, especially having you as the lead maintainer.
Being the face of a hugely popular project like Homebrew there's currently no one else with demonstrably so many years of experience, contributions, welcoming new contributors and mentoring people.
To be able to do that it takes a lot of dedication, taking out personal time (although I think we agree that we all do this for the fun of hacking too :D ) and for that I hold a lot of respect for you.


fix some go default value

[ ] Did you create an Apache Jira ticket?  (not required for trivial changes)
[ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[ ] If your change does not involve any code, add  [skip ci] at the end of your pull request to free up build resources.

I will describe my change in short.I use golang as develop language usually.I found in thrift go, it's dangerous to call in chain style due to lack of nil check in Get method and init variable use var rather than new method, the  former get a nil pointer and the latter get a empty pointer.
I create a code snippet to show my change solve case here

Felix, it seems you have missing parentheses:
[  7%] Building CXX object compiler/cpp/CMakeFiles/thrift-compiler.dir/src/thrift/generate/t_go_generator.cc.obj
C:\projects\thrift\compiler\cpp\src\thrift\generate\t_go_generator.cc: In member function 'void t_go_generator::generate_go_struct_definition(std::ostream&, t_struct*, bool, bool, bool)':
C:\projects\thrift\compiler\cpp\src\thrift\generate\t_go_generator.cc:1443:10: error: expected '(' before 'is_pointer_field'
 1443 |       if is_pointer_field(*m_iter){
      |          ^~~~~~~~~~~~~~~~
      |          (
compilation terminated due to -fmax-errors=1.
mingw32-make[2]: *** [compiler\cpp\CMakeFiles\thrift-compiler.dir\build.make:203: compiler/cpp/CMakeFiles/thrift-compiler.dir/src/thrift/generate/t_go_generator.cc.obj] Error 1

Felix, it seems you have missing parentheses:
[  7%] Building CXX object compiler/cpp/CMakeFiles/thrift-compiler.dir/src/thrift/generate/t_go_generator.cc.obj
C:\projects\thrift\compiler\cpp\src\thrift\generate\t_go_generator.cc: In member function 'void t_go_generator::generate_go_struct_definition(std::ostream&, t_struct*, bool, bool, bool)':
C:\projects\thrift\compiler\cpp\src\thrift\generate\t_go_generator.cc:1443:10: error: expected '(' before 'is_pointer_field'
 1443 |       if is_pointer_field(*m_iter){
      |          ^~~~~~~~~~~~~~~~
      |          (
compilation terminated due to -fmax-errors=1.
mingw32-make[2]: *** [compiler\cpp\CMakeFiles\thrift-compiler.dir\build.make:203: compiler/cpp/CMakeFiles/thrift-compiler.dir/src/thrift/generate/t_go_generator.cc.obj] Error 1

I am really sorry to break ci running,I'm not quite familiar with cpp, I'll try to fix it ASAP

No need to be sorry. You didn't break anyone else's work. These checks are here to prevent that.
It just means your change is not ready yet.
Change the line to:
     if (is_pointer_field(*m_iter)) {

and it'll be ok. I didn't check further tests, just compilation.

No need to be sorry. You didn't break anyone else's work. These checks are here to prevent that.
It just means your change is not ready yet.
Change the line to:
     if (is_pointer_field(*m_iter)) {

and it'll be ok. I didn't check further tests, just compilation.

I fix it.Really thanks for you correct it for me.

Thanks for the PR! Couple of things before this can be merged:

Please open a Jira ticket and discuss why this change is needed. It's not obvious to me why we should preallocate pointer fields.
Please add a test case.
Please squash your commits and write a commit message that follows the contribution guidelines.

I'm going to close this now. After discussion on Jira, we can reopen if necessary.


Setup GRPC endpoint testing

https://stackoverflow.com/questions/42102496/testing-a-grpc-service

Sample test already exists under pkg/proto/handler


Emphasis before dash in hyphenated words generates invalid output according to CommonMark standards

Emphasis before dash in hyphenated words generates invalid Markdown output according to CommonMark standards.
Example:
mean-spirited
generates
mean_\-spirited_
which is not to be emphasized according to https://spec.commonmark.org/dingus/
Similar issues occur for strong emphasis.

This one is difficult to solve, as you have to

either keep it as HTML, i.e. mean-spirited
or intervene in the content and move the dash outside of the emphasis, i.e. mean-_spirited_

The second option is already implemented for ascii and unicode whitespace, where the unicode whitespace is "more preserved" (#315). This might be similar to the unicode whitespace (where mean spirited becomes mean\u00A0_spirited_), but it needs careful analysis regarding other effects. Is this what you suggest?
P.S. I originally thought this is related to intraword emphasis, where using * and ** instead of _ and __ improves the situation.


[SPARK-20966][WEB-UI][SQL]Table data is not sorted by startTime time desc, time is not formatted and redundant code in JDBC/ODBC Server page.

What changes were proposed in this pull request?

Question 1 : Table data is not sorted by startTime time desc in JDBC/ODBC Server page.

fix before :

fix after :

Question 2 :  time is not formatted in JDBC/ODBC Server page.

fix before :

fix after :

Question 3 :  Redundant code in the ThriftServerSessionPage.scala.
The function of 'generateSessionStatsTable'  has not been used

How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

@srowen @ajbozarth @jerryshao Help to review the code, thanks.

@zsxwing
Help to review the code, thanks.

Test build #3774 has started for PR 18186 at commit 4c3dbeb.

Test build #3774 has finished for PR 18186 at commit 4c3dbeb.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #3776 has started for PR 18186 at commit 4c3dbeb.

Test build #3776 has finished for PR 18186 at commit 4c3dbeb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Ping @guoxiaolongzte

@srowen
Is there anything you need to modify, sir?

You saw my comment at https://github.com/apache/spark/pull/18186#discussion_r119982964  above right?

@srowen
I have replied to your review, thank you.

Merged to master


[NTR] add designation of spatial resolution

Preferred term label
"point distance X", "point distance Y", "point distance Z"
Synonyms

Textual definition
~The number of points per unit length in the X direction.~
The distance between two adjacent points in each direction.
Suggested parent term
Please look in the hierarchy in a browser such as the NFDI4Chem TS
Examples
A usual quantification of the resolution is the distance between adjacent points, which can be compared with the minimum resolvable distance as defined by the Abbe's criterion:
$$ d = \frac{\lambda}{2\cdot n\cdot\sin\theta} = \frac{\lambda}{2\cdot NA}$$
(Remark: another definition of resolution would be the ratio of nr points over length, i.e. the reciprocal of our choice.)
The resolution is reported separately in all three spatial directions.
Attribution
ORCID:0000-0001-7694-5519

@Zack-83 please provide more context what you mean, as the textual definitions are not comprehensible enough. They should be understandable by non Raman expersts as well. Am I assuming correctly, that with "region of interest" you are refering to a section of the sample with 3 dimensions (width X, length Y, depth Z)? So we need to be able to say that the part of the sample that was assayed has a specific spacial extend (e.g. 3.0 x 4.0 x 5.0 mm) and that this assayed section was observed with a certain resolution?

Exactly. Of course the wording can be improved.
We can define it "The extension of part of the sample essayed in the X direction", etc.
For each dimension, we have three nonindependent parameters: extension, number of points, resolution = n°points/width.
(Of course, neglecting nonrectangular sampling "gratings")

We decided to simplify the picture. We drop the two "extensive" quantities (nr points and length) and reciprocate the definition of resolution. The pull request comes in few minutes.

In order to find the right parent for these classes and thus also improve their definition, I need to know what kind of entity this is. Is it a setting, or a quality (in terms of specification) of the spectrometer?

It is a property of a spectrum, which can be used to select or compare data. Apparently no primary variable / setting, which may be calculated from spatial width and number of points (@RainerStosch , do you confirm?)

OK, I was asking because after reading https://en.wikipedia.org/wiki/Diffraction-limited_system, due to the current textual definition as proposed in the associated PR speaking of "distance" and due to the provided formula in the editor note containing only qualities (wavelength and numerical aperture (NA)), I interpret these three distances also as qualities of the spectroscope (as  obi:device setting subclasses to be precise).
Also the current textual definiton only states that they must always be bigger than the "minimum resolvable distance as defined by the Abbe's criterion". But it does not state how the difference to that minimum comes into being. And it is this difference, which imo determines this quality. So the question to be answered is this: Does the Raman specialist specify this distenace at some point directly or indirectly?

Ig we want to be ontologically precise we will need to also define the "region of interest" as a entity of itself (see: https://wiki.charisma.ideaconsult.net/wiki/Item:Q57) which has the hight, width and depth used here as attributes.

If we want to be ontologically precise we will need to also define the "region of interest" as a entity of itself (see: https://wiki.charisma.ideaconsult.net/wiki/Item:Q57) which has the hight, width and depth used here as attributes.

OK --> https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/pull/62/commits/782e57ce81bcd23afbf9dca90ef1936f482dfc82


Where is path condition and solution result stored in?

Hi there, I'm new here and I have just investigated JDart about half a month. My requirement now is to extract the path condition of a pair of specific test input, and I just do not know how solve it. I have read paper about JDart and I found similar problem at issue#27. I followed the discussion there and implement a function to parse Node root in InternalConstraintTree but I doesn't work for me (maybe my implementation is not right).
I think I'm now still very confused about how JDart works. I looks like JDart will maintain a symbolic tree during execution and will dynamically update this tree when solved. Thus I want to know is there possible to extract the symbolic tree or maybe there are some more simplistic way to extract path condition for a specific test input? Such as instrument some codes and then execute to obtain path constraints? Anything relevant is welcome, I would very appreciate it if you could help me! Thx!

You could set jdart.tree.json.print to otain a json representation of the tree.
The call to ca.getConstraintsTree().getAllPaths() in JDart.java (line 268) actually retuns all paths with constraints. You could work with these.
Also, please check out current development version:
https://github.com/tudo-aqua/jdart
We have rewritten the constraints tree last year:
https://github.com/tudo-aqua/jdart/tree/sv-comp-2021/src/main/gov/nasa/jpf/jdart/constraints/tree
We are happy to provide support for the current version. Please ask a question here:
https://github.com/tudo-aqua/jdart/issues

You could set jdart.tree.json.print to otain a json representation of the tree.
The call to ca.getConstraintsTree().getAllPaths() in JDart.java (line 268) actually retuns all paths with constraints. You could work with these.
Also, please check out current development version:
https://github.com/tudo-aqua/jdart
We have rewritten the constraints tree last year:
https://github.com/tudo-aqua/jdart/tree/sv-comp-2021/src/main/gov/nasa/jpf/jdart/constraints/tree
We are happy to provide support for the current version. Please ask a question here:
https://github.com/tudo-aqua/jdart/issues

Hey! Thank u for replying! Your advice is really helpful yet unfortunately cannot fully cater my needs.  In particular, I do obtain json output of the constraint tree following the configuration you gave, though I all I need is a constraint of a path with respect to a certain set of test inputs. Suppose I have a simple program under test like below :
public class Main1 {

    int foo(int x) {
        if (x > 10) {
            if (x < 100) {
                System.out.println("[Main1] (x > 10) && (x < 100)");
                return 100;
            }

            else {
                System.out.println("[Main1] (x >= 100)");
                return 1000;
            }

        }
        else {
            if( x > 1 )
                System.out.println("[Main1] x > 1 && x <= 10");
            else if (x > 3)
                System.out.println("[Main1] x > 3 && x <= 10");
            else
                System.out.println("[Main1] x <= 1");
            return 0;
        }

    }

    public static void main(String[] args) {
        int val = new Main1().foo(5);
    }

}

Now I want to extract constraint of  the path corresponding to the execution of x = 5, which should be x > 3 && x <= 10 in my example. To achieve this, what I'm doing currently is to put a constraint of x == 5 within my jpf config, like follows:
@include=../global/config.jpf

## Must tagged as concolic otherwise the testing process will be executed concretely.
concolic.method.foo=simple.Main1.foo(i:int)
concolic.method.foo.config=foo

########################## Main part

target=simple.Main1

concolic.method=foo

jdart.configs.foo.constraints=(i==5)

However, the execution result didn't as my expectation. It turns out that I can only got a constraint tree of one single branch, which usually looks like true OK: [  ], using the configuration like above.  I wander is it possible for JDart to realize the functionality I have mentioned directly or through some modification? I haven't read your project carefully. Maybe your modified version is just able to finish this? Please let me know If you have any advice, thx : -) !

Yeah, I don't know an easy fix for this in the current version of the code. The Constraint Tree will aggregate constraints in this way. You could explore the complete tree and then test on the paths, which paths are satisfiable for the assumption i==5 externally. But that would, of course, be a lot of unnecessary effort.
Are you interested in individual paths for concrete input values or in bigger slices?

Yeah, in fact I'm interested in an individual path with respect to a certain group of inputs. I implemented my single path extraction by making  concolic execution stopped right after initValuation. I do this modification because I found that JDart is always started its search for valuations with the values I give it. It works for me at present, but if there exists any problems in my implementation or there are another better choices, please let me know.

Hi @QRXqrx have you solved this problem? I also want to record a certain patch with respect to a certain input.


How to make it loop

I want to use it to show quotes from people, displaying different sentences that rotate, displaying one at a time. is this possible?

I've been trying to do the same but I just cant make it to work ... Did you made it ?

nope :(

Do you have an example or what you're trying to do? Textillate has looping built in with the [loop option] (https://github.com/jschr/textillate#options).

I am trying to do this: http://fpa-voices.com/wheel3/example/leo2.html
the problem is that the wheel on the right behaves differently...

I am trying to do this: http://fpa-voices.com/wheel3/example/leo.html
the problem is that the wheel on the right behaves differently...

@leonix2015 I don't see where textillate is being used. Please provide a code snippet of how you are using textillate and I might be able to help.

@jschr - sorry I meant to ask about a different plugin:
https://github.com/PixelsCommander/Propeller

@leonix2015 I have no affiliation with that plugin so you'll need to open an issue on that repo

thanks!


I met a problem: http: panic serving [::1]:55909: runtime error: index out of range [1] with length 1

I built it on my win-10 computer and when I pressed the url : http://localhost:8888/example.org/80 I saw the panic :
http: panic serving [::1]:56291: runtime error: index out of range [1] with length 1
D:/goProject/src/micro-bastion/main.go:49 +0x2a3
main.handleRequest(0x750100, 0xc0001c4460, 0xc0000c0200)
D:/goProject/src/micro-bastion/main.go:18 +0x83
net/http.HandlerFunc.ServeHTTP(0x6fffe0, 0x750100, 0xc0001c4460, 0xc0000c0200)
C:/Go/src/net/http/server.go:2012 +0x4b
net/http.serverHandler.ServeHTTP(0xc0000ce000, 0x750100, 0xc0001c4460, 0xc0000c0200)
C:/Go/src/net/http/server.go:2807 +0xaa
net/http.(*conn).serve(0xc000064c80, 0x750640, 0xc00010c340)
C:/Go/src/net/http/server.go:1895 +0x873
created by net/http.(*Server).Serve
C:/Go/src/net/http/server.go:2933 +0x363
I do't know why it happened.
thx

oldPathParts := strings.Split(oldPath, "/")[1:] log.Println("This is oldPath:", oldPath, strings.Split(oldPath, "/"), oldPathParts)   // what I add
Hello , I add this code to test why it happen.
I find when I test the url:http://localhost:8888/example.org/80,the log would be :
This is oldPath: /favicon.ico [ favicon.ico] [favicon.ico]
so,I think the code in next line might be something wrong.
newURL.Host = oldPathParts[0] + ":" + oldPathParts[1]


Fix bug in selecting comments to print.

Fixes AQCU-668. We weren't printing the first comment of SRS reports because lastDate was never initialized.

Coverage remained the same at 87.114% when pulling 866bde9dd67e987d68aab484e320fa35c25ec4c2 on dpattermann-usgs:master into c1df2734a85c43968aa9a0ed40978c4aa5d8e470 on USGS-R:master.


feat: Add row polymorphic records

This PR implements row polymorphic records which should make records much more flexible at the expense of some performance.
Left to do:

[x] Add comments
[x] Handle polymorphic records in the vm
[x] Fix pretty printing of polymorphic records
[x] Add tests to test row kinds specifically
[x] Improve row polymorphism related error messages

Fixes #92

What semantics are we using for field shadowing?

Shadowing like?
{ x = 1, x = "" }

I have just assumed that should be an error.

This compiles without error which is pretty bad (at least in how I think it may interact with the current typechecker and vm which assume fields are unique). :sweat_smile:
#[test]
fn double_field_declared() {
    let _ = ::env_logger::init();
    let text = r#"
{ x = 1, x = "" }
"#;
    let result = support::typecheck(text);
    assert!(result.is_err());
}

I think in Elm the semantics are that if you re-specify a field it is the same as removing and adding a field. Not sure if that's what we want though.

That may make sense as well. I think 1ML has the same semantics given how it even desugars let bindings into modules/records (Page 3 bottom left https://www.mpi-sws.org/~rossberg/1ml/1ml-extended.pdf)

The problem I have had with the vm part is that I wanted to keep that same compact representation as it is currently and only add a header which then points to a map off the field offsets.
+------------------------+
| Map<FieldName, Offset> |
+------------------------+
     ^
     |
+----+------------+------------------+----------------+
|                 |                  |                |
|  Header         |  Field 1         |     Field 2    |
+-----------------+------------------+----------------+

Unfortunately that map needs to be owned by something and I couldn't decide where. I think however that with #135 each thread can intern all necessary maps which will let all values owned by the thread take a pointer to each map.

Other than adding some more comments (let me know if there is something I should explain better) and running rustfmt I think this should be done. Let me know if you have any questions @brendanzab or thoughts on it!

As usual I find your code pretty dense and monolithic, but I can't really give much constructive advice yet. I will try to think about it... I would like our codebase to be as nice at rustc is these days! :D Their comments are also incredibly helpful - I would look to them for inspiration!
Some tests for the new errors would be great. I understand it might be hard though given that we do not have syntax for extensible records yet. I would also look at Elm's errors for records - they are very helpful, showing a 'diff' of the expected and found record types. Perhaps for another time.

Tried to expand a bit more in the comments but I am afraid I was not able clean up the code itself much. If you could point out some specifics that are hard to follow that would be helpful since I am afraid I am rather blind towards the problems :/.
This would be ready except I found a problem as I added the last doc commit.
#[test]
fn different_order() {
    let _ = env_logger::init();

    let text = r#"
if True then
    { x = 1, y = "" }
else
    { y = "", x = 1 }
"#;
    let result = support::typecheck(text);

    assert!(result.is_ok());
}

This passes (which is fine if #114 is fixed) but currently the records does have a different representation which will lead to runtime errors. I guess normalizing the field order is the best idea here? I could maybe add a special case in typechecking to still care about order for non-polymorphic records but maybe it is better to do it properly right away (though that complicates code generation grumble grumble...).

Added some comments, but will have to look at it again after work.

Took the quick and easy way out and just enforced that when unifying two non-polymorphic records the field order matters. Its easy enough to remove and lets me skip out on deciding on and implementing #114.
r?

Fixed the nits and threw in polymorphism over type fields as well which as it didn't seem to tricky. There is probably some more simplifications possible but that could be done later (assuming no other nits appear from these changes :) ).

Let's just merge this! :)

:tada:


ROX-18482: Add structured logs to reprocessor

Description
This PR adds structured logs to the reprocessor. The reprocessor will be the first package that will be moved to structured logs to later enable it to send the log entry to the event service.
The reason for choosing the reprocessor is that it currently does expose probably the most interesting async info for customers: whether there's trouble scanning images or not.
The existing Errorw/Warnw were used. We may think about adding Infow as well, I personally do not mind adding it in this PR.
As a caveat:
Introduced multiple wrappers for common fields we want to have in structured logs: image, image_id, cluster_id, node_id.
Additionally, also refactored existing usages of zap.Error to use logging.Err instead. Reason for this is that the wrapper (both the one for zap.Error as well as our own Logger interface for zap.SugaredLogger) is to avoid other clients to directly import zap, if not necessary.
While client packages may still import zap to e.g. introduce their own, package-specific fields, we should reduce the imports of zap as much as possible.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

Current dependencies on/for this PR:

master

PR #7257

PR #7423

PR #7424

PR #7425   👈

This comment was auto-generated by Graphite.


2022/04/05 progress

HI, @ZhengPeiRu21 , thanks for your hard work.
This is the result of today's compilation: Compilation failed

maybe you are using the old mod or wrong branch, because here for me everything is normal.

maybe you are using the old mod or wrong branch, because here for me everything is normal.

Sadly, I recompiled and it still failed,

try to do everything manually, download the playerbots branch and then the playerbots mod and put it manually in the modules folder.  there is no longer the term "mod-playerbots-AzerothCore".  And that's even why I'm thinking you might be getting confused and using the old mod.

The correct directory name should be mod-playerbots, not mod-playerbots-AzerothCore. Because CMake uses special defines for this directory name, it is necessary to use this specific name. Can you please try changing the directory name and see if this resolves your compile issues?

It's really a bit strange. I changed the names of the two folders back to the original ones, and the compilation was successful. The strange thing is that these two names were used before, but the compilation failed.

I can finally start playing, I am so happy, I have to go and experience it.


Compression time on Android

I'm noticing the following behavior in compression times on Andriod if I try to compress a video that is 10 sec in length everything is fine but I try anything about 45 sec it's taking a really really long time to compress, is this how it should be?

Hi @AlmogRnD .
Yes - that's how much takes FFMPEG to convert/compress the video files.


Small improvements to docs

Added some small improvements to the README.md file, like better Markdown formatting and adding better descriptions.

👍 👍 👍

Released as v1.15.0.


BLE instance in service

I wanted to use the library in Foreground Service, but at the moment it's not possible. Could you please add a context-only constructor?

Hello, Thank you for your issue
It is theoretically possible, although I have never tested this on a Service, so it would need testing.
Would you be so kind to offer help to test the library given that I expose a new constructor for you?

Closing due to inactivity.

I'd be happy to play around with this - I have a need for BLE in a Foreground Service in a small project I'm working on and I'd love to use this library to make it happen!

Thank you for volunteering!
I will put out a prototype with this as soon as I get time to it, so we can get this into a new version.

Just updating this with my findings.

We need special permission to handle connected devices on a foreground service
Couldn't find a way to handle the jetpack contracts on the services, so it may be possible that using helpers like hardware availability, permission checking and so on wouldn't work
It may be only possible to start the BLE instance on an Activity, Fragment or Jetpack compose activity, connect to a device and then pass the connection instance to the service.


Add Japanese Number Converter extension

Description
This extension lets you convert japanese kanji symbols for numbers into Number format.
examples:
三十 --> 30
35万 --> 350,000

Under the hood the value is passed into the package @geolonia/japanese-numeral
 and converted with kanji2number()
Why use this over google translate?
I find myself using this a bit as when you put '三十万' into google translate it will output 'Three hundred thousand' which I almost never need
However if you think its too similar to (the many) translation extensions, then its fine to decline 😄
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi!
Thank you for your contribution! My name is Milena and I will be reviewing it today.
We have one for Chinese numerals, so I think that having one for Japanese makes sense. https://www.raycast.com/raffeyang/chinese-numbers/commands
One thing that came to mind was to either have more outputs for each number and the user could chose which one they would like OR make this a one line command, where the input would be inline and "enter" would paste the output directly to the frontmost app or add to the clipboard. What do you think?

Ping @mrsideshowjack :)


Supplying a complex object (i.e. buffer) as an argument to md5Hash or crc32c does not invoke server validation

In the course of investigating #1829 we discovered that if a complex object (buffer in the example) is provided as the argument to metadata.md5Hash or metadata.crc32c the server ignores the argument and does not perform server validation. The expectation in testing was that when invalid input was provided the server would return a 400 error complaining that the provided hash/checksum was not encoded correctly. If an invalid string is provided, an error is correctly returned.

Reducing this to a p3 as when provided a string this works as expected.

Tagged as external because this is an issue with the gaxios dependency.

Re-visiting this today I took a look at the JSON docs. Both MD5 and CRC32C are defined as strings. As such I do not think the library should handle the case of different types being supplied as the argument. This will also become more evident when we add stronger typings: https://github.com/googleapis/nodejs-storage/issues/1817. As a result I am going to close this out as I think the real work is captured there.


Vjera turk/refactoring to mint on c chain

Why this should be merged
To lose the T-chain for C-chain and to demonstrate the early stage of the BookingTokenV0 NFT contract.
How this works
This change introduces interaction with the BookingToken digital contract. Tokens are minted to be bought by a specified party within a certain timeframe. The BookingToken is an ERC-721 NFT contract. The contract is deployed to the Columbus testnet, contract address: 0xd4e2D76E656b5060F6f43317E8d89ea81eb5fF8D
On CaminoScan: https://columbus.caminoscan.com/address/0xd4e2D76E656b5060F6f43317E8d89ea81eb5fF8D
The bot references it via configuration booking_token_address.
The Solidity contract (BookingToken.sol) and its dedicated BookingTokenV0.abi file are available within the repository, referenced in bot configuration with booking_token_abi_file.
The bot configuration now requires rpc_url  to connect the Ethereum (evm) client (instead of the T-chain tvm client) and  evm_private_key for signing the transactions on C-chain.
The change alters the logic of handling the MintRequest request type. The Supplier bot registers the Supplier by its name, and mints the token for the Distributor bot to buy.
Supplier will act upon receiving a mint response by registering the Supplier by Name and minting an NFT.
Mint action - Supplier side
Mints a BookingToken with the supplier's private key and reserves it for the buyer's address.
The Token will be reserved for the buyer address specified in request.MintRequest.BuyerAddress.
Additional token-related data is propagated to the mint function as uri (currently the data is mocked base64 encoded JSON). The expiration  defines after how many seconds it is no longer possible to buy the token.
A New transaction calling the safeMint contract function is issued, signed, sent and mined with gassLimit set to a safe value of uint64(1200000) for now.
Mint functions return the unique tokenID that gets attached to the response.MintResponse.BookingToken
alongside the response.MintTransactionId and sent to the buyer.
Distributor will post-process a mint request to buy the returned NFT
Buy action - Distributor side
Buys a Token with the buyer's private key. The token must be reserved for the buyer's address.
A New transaction calling the buy contract function is issued, signed, sent and mined with gassLimit set to a safe value of uint64(1200000) for now.
gRPC Server Reflection
gRPC Server Reflection provides information about publicly accessible gRPC services on a server, and assists clients at runtime to construct RPC requests and responses without precompiled service information. It is used by gRPCurl, which can be used to introspect server protos and send/receive test RPCs.
https://github.com/grpc/grpc-go/blob/master/Documentation/server-reflection-tutorial.md
It was added to the Partner Plugin example for easier testing from the Postman API Client.
How this was tested
This was tested manually by issuing the MintRequest gRPC calls via Postman issued to the distributor bot.

Please, add PR description. If possible/reasonable, follow this template:
## Why this should be merged
## How this works
## How this was tested

Also, I briefly looked at first files and I see, that there are some new evm config fields/flags like networkID - are they used now? If not, please remove them

I think the 1 change request is failing because I've deleted the file to address the change :/