Entire code base PR

Hey @kosgrz,
Thanks for opening this PR! @jfrerich will review it in time.

Items discovered during plugin testing with dylan:

create issue to add autocomplete

Items discovered during plugin testing with dylan:

create issue to add autocomplete

Hi @kosgrz,
I have done a round of testing with Bitbucket cloud. Here is a list of issues and questions I have so far. Testing with Jira integration and on server instance of BitBucket is ongoing.
Sorry the list is long as this is quite a large undertaking as the plugin has alot of functionality. I have tried to organize the issues loosely by priority.

Attach and create post menu option are visible when no Jira instance has been added to BitBucket Trying to use the functionality results in erros showing in the modal when you try to use them
Not sure Enable Private Repositories is doing anything. My repo is only available to users I have invited and regardless of this setting, my connected user can freely create subscriptions. This could have broad security implications. Should the security work the same as GitHub? It's unclear to me if the exact same design would work.
To expand on @jfrerich's point above, There are numerous cases where subscription events will post to the target channel saying the target brach has been created and deleted even though the branch status has not changed on the Bitbucket side. Note: When actually deleting a branch the feature for deletes when you would expect
3A - When making a commit (without a PR) - The subscription also shows that the branch in question was created and deleted these 2 events are confusing as the status of the branch has not changed.
3B - PR merge does not show an event for PR being merged. It only shows that master branch was created and deleted
Creating a new branch is very noisy when pull_reviews is enabled. All initial commits are shown as pushes and merges.

todo is not working "Encountered an error getting your to do items." note: LHS data looks correct and refresh is working.
pull-reviews feature will deliver an event for all comments on a PR. Is this intentional?
Notification DMs  for at mentions are sent twice
Notifications DM for at mentions are still sent when they are off
I'm not sure what the Bitbucket equivalent is "closed" status on a PR. But neither decline or merge deliver an event
Creates and deletes show Mattermost username instead of corresponding Bitbucker username

Other questions...
A. Approve and Unapprove on a PR send a DM but Request Changes does not seem to. No sure if this is a large feature to add?
B. PR subscription features does not include PR description text. This is a relatively minor issue since the titles are included.
@aaronrothschild maybe these features could wait for a later release?

Hi @kosgrz,
I have done a round of testing with Bitbucket cloud. Here is a list of issues and questions I have so far. Testing with Jira integration and on server instance of BitBucket is ongoing.
Sorry the list is long as this is quite a large undertaking as the plugin has alot of functionality. I have tried to organize the issues loosely by priority.

Attach and create post menu option are visible when no Jira instance has been added to BitBucket Trying to use the functionality results in erros showing in the modal when you try to use them
Not sure Enable Private Repositories is doing anything. My repo is only available to users I have invited and regardless of this setting, my connected user can freely create subscriptions. This could have broad security implications. Should the security work the same as GitHub? It's unclear to me if the exact same design would work.
To expand on @jfrerich's point above, There are numerous cases where subscription events will post to the target channel saying the target brach has been created and deleted even though the branch status has not changed on the Bitbucket side. Note: When actually deleting a branch the feature for deletes when you would expect
3A - When making a commit (without a PR) - The subscription also shows that the branch in question was created and deleted these 2 events are confusing as the status of the branch has not changed.
3B - PR merge does not show an event for PR being merged. It only shows that master branch was created and deleted
Creating a new branch is very noisy when pull_reviews is enabled. All initial commits are shown as pushes and merges.

todo is not working "Encountered an error getting your to do items." note: LHS data looks correct and refresh is working.
pull-reviews feature will deliver an event for all comments on a PR. Is this intentional?
Notification DMs  for at mentions are sent twice
Notifications DM for at mentions are still sent when they are off
I'm not sure what the Bitbucket equivalent is "closed" status on a PR. But neither decline or merge deliver an event
Creates and deletes show Mattermost username instead of corresponding Bitbucker username

Other questions...
A. Approve and Unapprove on a PR send a DM but Request Changes does not seem to. No sure if this is a large feature to add?
B. PR subscription features does not include PR description text. This is a relatively minor issue since the titles are included.
@aaronrothschild maybe these features could wait for a later release?

@kosgrz one quick follow-up on this. After integrating a Jira instance into my Bitbucket repo, I still see the same errors when trying to use the create and attach functionality. I have tried disconnecting and recxconnecting my user but, this did not change the behavior.
{"id":"","message":"failed to create issue: Sorry, either you don't have access to the repo DHaussermann/helloworld with the user dkh-sysadmin or it is no longer available","status_code":404}

Please let me know if you have any thoughts?

@kosgrz one quick follow-up on this. After integrating a Jira instance into my Bitbucket repo, I still see the same errors when trying to use the create and attach functionality. I have tried disconnecting and recxconnecting my user but, this did not change the behavior.
{"id":"","message":"failed to create issue: Sorry, either you don't have access to the repo DHaussermann/helloworld with the user dkh-sysadmin or it is no longer available","status_code":404}

Please let me know if you have any thoughts?

Thanks @DHaussermann for the review!

Not sure Enable Private Repositories is doing anything. My repo is only available to users I have invited and regardless of this setting, my connected user can freely create subscriptions. This could have broad security implications. Should the security work the same as GitHub? It's unclear to me if the exact same design would work.

We should lock this capability down to ensure it is being observed.

To expand on @jfrerich's point above, There are numerous cases where subscription events will post to the target channel saying the target brach has been created and deleted even though the branch status has not changed on the Bitbucket side. Note: When actually deleting a branch the feature for deletes when you would expect

It's important to get this working so the user can trust the system's messages to be accurate.

3A - When making a commit (without a PR) - The subscription also shows that the branch in question was created and deleted these 2 events are confusing as the status of the branch has not changed.
3B - PR merge does not show an event for PR being merged. It only shows that master branch was created and deleted

Yes, we should fix these before release.

Creating a new branch is very noisy when pull_reviews is enabled. All initial commits are shown as pushes and merges.

I'm 1/5, but this can be cleaned up in a future revision.

todo is not working "Encountered an error getting your to do items." note: LHS data looks correct and refresh is working.

We need to fix this before shipping.
@DHaussermann For #6-10 I created issues in this repo.  @kosgrz sorry, I created them before I realized I couldn't label them with a "release" version.  some of these are more important than others.  We wanted to have the first release of this plugin by the end of this month hopefully.

Thanks @DHaussermann for the review!

Not sure Enable Private Repositories is doing anything. My repo is only available to users I have invited and regardless of this setting, my connected user can freely create subscriptions. This could have broad security implications. Should the security work the same as GitHub? It's unclear to me if the exact same design would work.

We should lock this capability down to ensure it is being observed.

To expand on @jfrerich's point above, There are numerous cases where subscription events will post to the target channel saying the target brach has been created and deleted even though the branch status has not changed on the Bitbucket side. Note: When actually deleting a branch the feature for deletes when you would expect

It's important to get this working so the user can trust the system's messages to be accurate.

3A - When making a commit (without a PR) - The subscription also shows that the branch in question was created and deleted these 2 events are confusing as the status of the branch has not changed.
3B - PR merge does not show an event for PR being merged. It only shows that master branch was created and deleted

Yes, we should fix these before release.

Creating a new branch is very noisy when pull_reviews is enabled. All initial commits are shown as pushes and merges.

I'm 1/5, but this can be cleaned up in a future revision.

todo is not working "Encountered an error getting your to do items." note: LHS data looks correct and refresh is working.

We need to fix this before shipping.
@DHaussermann For #6-10 I created issues in this repo.  @kosgrz sorry, I created them before I realized I couldn't label them with a "release" version.  some of these are more important than others.  We wanted to have the first release of this plugin by the end of this month hopefully.

Thanks @DHaussermann for the review!

Not sure Enable Private Repositories is doing anything. My repo is only available to users I have invited and regardless of this setting, my connected user can freely create subscriptions. This could have broad security implications. Should the security work the same as GitHub? It's unclear to me if the exact same design would work.

We should lock this capability down to ensure it is being observed.

To expand on @jfrerich's point above, There are numerous cases where subscription events will post to the target channel saying the target brach has been created and deleted even though the branch status has not changed on the Bitbucket side. Note: When actually deleting a branch the feature for deletes when you would expect

It's important to get this working so the user can trust the system's messages to be accurate.

3A - When making a commit (without a PR) - The subscription also shows that the branch in question was created and deleted these 2 events are confusing as the status of the branch has not changed.
3B - PR merge does not show an event for PR being merged. It only shows that master branch was created and deleted

Yes, we should fix these before release.

Creating a new branch is very noisy when pull_reviews is enabled. All initial commits are shown as pushes and merges.

I'm 1/5, but this can be cleaned up in a future revision.

todo is not working "Encountered an error getting your to do items." note: LHS data looks correct and refresh is working.

We need to fix this before shipping.
@DHaussermann For #6-10 I created issues in this repo.  @kosgrz sorry, I created them before I realized I couldn't label them with a "release" version.  some of these are more important than others.  We wanted to have the first release of this plugin by the end of this month hopefully.

Thanks @DHaussermann for the review!

Not sure Enable Private Repositories is doing anything. My repo is only available to users I have invited and regardless of this setting, my connected user can freely create subscriptions. This could have broad security implications. Should the security work the same as GitHub? It's unclear to me if the exact same design would work.

We should lock this capability down to ensure it is being observed.

To expand on @jfrerich's point above, There are numerous cases where subscription events will post to the target channel saying the target brach has been created and deleted even though the branch status has not changed on the Bitbucket side. Note: When actually deleting a branch the feature for deletes when you would expect

It's important to get this working so the user can trust the system's messages to be accurate.

3A - When making a commit (without a PR) - The subscription also shows that the branch in question was created and deleted these 2 events are confusing as the status of the branch has not changed.
3B - PR merge does not show an event for PR being merged. It only shows that master branch was created and deleted

Yes, we should fix these before release.

Creating a new branch is very noisy when pull_reviews is enabled. All initial commits are shown as pushes and merges.

I'm 1/5, but this can be cleaned up in a future revision.

todo is not working "Encountered an error getting your to do items." note: LHS data looks correct and refresh is working.

We need to fix this before shipping.
@DHaussermann For #6-10 I created issues in this repo.  @kosgrz sorry, I created them before I realized I couldn't label them with a "release" version.  some of these are more important than others.  We wanted to have the first release of this plugin by the end of this month hopefully.

Hi, thank you for the review and testing!
@aaronrothschild, I will start fixing these bugs from today. I think I will finish it before the end of the week :+1: .

Hi, thank you for the review and testing!
@aaronrothschild, I will start fixing these bugs from today. I think I will finish it before the end of the week :+1: .

todo is not working "Encountered an error getting your to do items."

@DHaussermann, it works on my instance. Could you send me logs with this error? It will help me with debugging.

todo is not working "Encountered an error getting your to do items."

@DHaussermann, it works on my instance. Could you send me logs with this error? It will help me with debugging.

@kosgrz I have started another round of testing with your latest commit. I notice issues 8. and 9. Seem top be resolved but I'm not sure what else has changed.
Regarding your question on 5. When I have no issues assigned to me in the paired jira instance (I do have PR to review) I see ERRO[2021-01-25T17:01:49.364203-05:00] Encountered an error getting your to do items  caller="mlog/sugar.go:25" err="error occurred while searching for assignments: error occurred while fetching issues: error occurred while fetching issues: Status: 404 Not Found, Body: {\"type\": \"error\", \"error\": {\"message\": \"Repository has no issue tracker.\"}}" plugin_id=bitbucket
To take a bit of  a tangent here...
This may be related to what I'm seeing for issue 1. above. I have a Bitbucket repo paired to a Jira cloud instance but the functionality that would expose the Jira issues does not seem to be working. In addition to issue 1. Even when I have issues assigned to me in my corresponding Jira cloud instance, I still see this error and a 0 count of issue in the LHS
How should this work exactly? My connected user has a Workspace  with 2 Repositories and 1 of the repositories is configured to use Jira for issues. Should I just be able to create a Bitbucket issue by selecting a repository
cc @aaronrothschild  Just a heads up as 1. did not show up on your must fix list. For me the functionality where BitBucket is aware of a corresponding Jira project does not seem to be working.
Also, this is actually kind of weird... As the Issue tracker for Bitbucket is Jira, we would actually have 2 plugins capable of creating Jira issues and attaching comments to them?

@kosgrz I have started another round of testing with your latest commit. I notice issues 8. and 9. Seem top be resolved but I'm not sure what else has changed.
Regarding your question on 5. When I have no issues assigned to me in the paired jira instance (I do have PR to review) I see ERRO[2021-01-25T17:01:49.364203-05:00] Encountered an error getting your to do items  caller="mlog/sugar.go:25" err="error occurred while searching for assignments: error occurred while fetching issues: error occurred while fetching issues: Status: 404 Not Found, Body: {\"type\": \"error\", \"error\": {\"message\": \"Repository has no issue tracker.\"}}" plugin_id=bitbucket
To take a bit of  a tangent here...
This may be related to what I'm seeing for issue 1. above. I have a Bitbucket repo paired to a Jira cloud instance but the functionality that would expose the Jira issues does not seem to be working. In addition to issue 1. Even when I have issues assigned to me in my corresponding Jira cloud instance, I still see this error and a 0 count of issue in the LHS
How should this work exactly? My connected user has a Workspace  with 2 Repositories and 1 of the repositories is configured to use Jira for issues. Should I just be able to create a Bitbucket issue by selecting a repository
cc @aaronrothschild  Just a heads up as 1. did not show up on your must fix list. For me the functionality where BitBucket is aware of a corresponding Jira project does not seem to be working.
Also, this is actually kind of weird... As the Issue tracker for Bitbucket is Jira, we would actually have 2 plugins capable of creating Jira issues and attaching comments to them?

@kosgrz!  Thanks for the prompt PR changes!
@aaronrothschild, I'm approving, from a code review standpoint.  We need a Security Review and the final QA review and we have a great bitbucket plugin

@kosgrz!  Thanks for the prompt PR changes!
@aaronrothschild, I'm approving, from a code review standpoint.  We need a Security Review and the final QA review and we have a great bitbucket plugin

@DHaussermann, thank you for the logs. It was very helpful. Command todo didn't work when a repo doesn't have any issue tracker enabled. I've just fixed that in my latest commit. Issues 7. and 10. are also fixed 👍 .

@DHaussermann, thank you for the logs. It was very helpful. Command todo didn't work when a repo doesn't have any issue tracker enabled. I've just fixed that in my latest commit. Issues 7. and 10. are also fixed 👍 .

Thank you for the last commit @kosgrz I will do another round of testing as soon as I get a chance.
The strange thing is. My Bitbucket repo does have a Jira instance attached so, I'm not sure why the plugin is not aware of this or if there is a config change I can make to resolve it. On a similar not. The post menu options should not be available if the pluging does not see a Jira instance associated to the Repo. Any thoughts on what's happening here?

Thank you for the last commit @kosgrz I will do another round of testing as soon as I get a chance.
The strange thing is. My Bitbucket repo does have a Jira instance attached so, I'm not sure why the plugin is not aware of this or if there is a config change I can make to resolve it. On a similar not. The post menu options should not be available if the pluging does not see a Jira instance associated to the Repo. Any thoughts on what's happening here?

Hi @kosgrz I have done a round of testing on the last commit. Just to add clarity here - I have re-tested all the issues and summarized below.
1. Not able to use create and attach options even when I have a Jira instance connected
2. Subscribe is not respecting the flag to allow private repos
3. Subscriptions post on commits that the branch was created and deleted. They also post on merged that the destination branch such as master was created and deleted
4. The create event shows the commit history of the origin branch you created from. This makes the subscription very noisy.
5. The error seems fixed and the command returns data now 👍   However, when I click the list icon from the LHS something is null and it breaks the CSS so the browser goes blank. Can you let me know if you can repro this?

6. Regarding pull-reviews feature may not be needed for release but it is a bit noisy
7.  and 8. are both resolved 👍
9. Is maybe a enhancement we can add later. Certainly not needed for release.
10. Yes - thak you this has also now been resolved.

Hi @kosgrz I have done a round of testing on the last commit. Just to add clarity here - I have re-tested all the issues and summarized below.
1. Not able to use create and attach options even when I have a Jira instance connected
2. Subscribe is not respecting the flag to allow private repos
3. Subscriptions post on commits that the branch was created and deleted. They also post on merged that the destination branch such as master was created and deleted
4. The create event shows the commit history of the origin branch you created from. This makes the subscription very noisy.
5. The error seems fixed and the command returns data now 👍   However, when I click the list icon from the LHS something is null and it breaks the CSS so the browser goes blank. Can you let me know if you can repro this?

6. Regarding pull-reviews feature may not be needed for release but it is a bit noisy
7.  and 8. are both resolved 👍
9. Is maybe a enhancement we can add later. Certainly not needed for release.
10. Yes - thak you this has also now been resolved.

@DHaussermann, thanks for testing! I have some questions below:

Not able to use create and attach options even when I have a Jira instance connected

Unfortunately, I could not reproduce that. I had errors, only when I wanted to create an issue in a repository that does not have a Jira instance connected. What happens exactly when you try to create an issue?

Subscribe is not respecting the flag to allow private repos

It is true that this flag does not work. Sorry, I somehow missed that feature. I can add it quickly, but I would need to disable the option to subscribe to a whole organization when the flag is enabled. If a user wants to subscribe to a specific repository, I can check whether they have access there. But, if they want to subscribe to a whole organization, I cannot. Would this solution be ok for now?
Are points 4 and 5 needed to be fixed before release?

However, when I click the list icon from the LHS something is null and it breaks the CSS so the browser goes blank. Can you let me know if you can repro this?

Fixed 👍 .

@DHaussermann, thanks for testing! I have some questions below:

Not able to use create and attach options even when I have a Jira instance connected

Unfortunately, I could not reproduce that. I had errors, only when I wanted to create an issue in a repository that does not have a Jira instance connected. What happens exactly when you try to create an issue?

Subscribe is not respecting the flag to allow private repos

It is true that this flag does not work. Sorry, I somehow missed that feature. I can add it quickly, but I would need to disable the option to subscribe to a whole organization when the flag is enabled. If a user wants to subscribe to a specific repository, I can check whether they have access there. But, if they want to subscribe to a whole organization, I cannot. Would this solution be ok for now?
Are points 4 and 5 needed to be fixed before release?

However, when I click the list icon from the LHS something is null and it breaks the CSS so the browser goes blank. Can you let me know if you can repro this?

Fixed 👍 .

Confirmed 5. is fixed. Todo and issues icon on Team sidebar both work as as expected. No breaking CSS  👍
For issue 1., we may need a couple changes. One to resolve whatever issue I'm seeing and another to remove the post menu options where there is no Jira instance associated or the connected Bitbucket user does not have access. Here are some details of what I see happen...

Ensue there is a Jira instance associated to the Bitbucket repo
Click ... on a post and select and select Create Bitbucket Issue
When the modal open note that the repo with Jira instance is visible in the repo
Click Submit
Observed
The request to createissue returns a 404 with"id":"","message":"failed to create issue: Sorry, either you don't have access to the repo DHaussermann/helloworld with the user dkh-sysadmin or it is no longer available","status_code":404}

I double checked the mapped user and when visiting Bitbucket with the same user I have access to the issue. Tried to disconnect and reconnect to see if anything would change. I also tried with the 2nd user on my Bitbucket. When I connect with the plugin, I see that the repos change (and repos without issues are listed which seems like an issue). But when I use create, I see the same problem but with the other Mattermost username.
What type of issues does the plugin attempt to create? I notice this can't be defined in the modal. 0/5 Maybe it's because the specific issue type cannot be created in my  Jira project or a similar issue which makes the error a bit misleading?

Are points 4 and 5 needed to be fixed before release?
To my understand 5. is resolved but, 4. is still needed. @aaronrothschild may also have some thoughts on this.

Confirmed 5. is fixed. Todo and issues icon on Team sidebar both work as as expected. No breaking CSS  👍
For issue 1., we may need a couple changes. One to resolve whatever issue I'm seeing and another to remove the post menu options where there is no Jira instance associated or the connected Bitbucket user does not have access. Here are some details of what I see happen...

Ensue there is a Jira instance associated to the Bitbucket repo
Click ... on a post and select and select Create Bitbucket Issue
When the modal open note that the repo with Jira instance is visible in the repo
Click Submit
Observed
The request to createissue returns a 404 with"id":"","message":"failed to create issue: Sorry, either you don't have access to the repo DHaussermann/helloworld with the user dkh-sysadmin or it is no longer available","status_code":404}

I double checked the mapped user and when visiting Bitbucket with the same user I have access to the issue. Tried to disconnect and reconnect to see if anything would change. I also tried with the 2nd user on my Bitbucket. When I connect with the plugin, I see that the repos change (and repos without issues are listed which seems like an issue). But when I use create, I see the same problem but with the other Mattermost username.
What type of issues does the plugin attempt to create? I notice this can't be defined in the modal. 0/5 Maybe it's because the specific issue type cannot be created in my  Jira project or a similar issue which makes the error a bit misleading?

Are points 4 and 5 needed to be fixed before release?
To my understand 5. is resolved but, 4. is still needed. @aaronrothschild may also have some thoughts on this.

@DHaussermann, thank you for explaining the issue in detail. It was very helpful 👍.

For issue 1., we may need a couple changes. One to resolve whatever issue I'm seeing and another to remove the post menu options where there is no Jira instance associated or the connected Bitbucket user does not have access.

Unfortunately, according to my knowledge, this is not possible with the current Mattermost Plugin API.
I added some extra logging when creating an issue. Now, in the logs you should see something like this:
ERRO[2021-02-02T19:59:26.348181+01:00] failed to create issue: Status: 404 Not Found, Body: {"type": "error", "error": {"message": "Repository has no issue tracker."}}  caller="mlog/sugar.go:25" plugin_id=bitbucket
Could you try to create an issue again and send me logs?

I see that the repos change (and repos without issues are listed which seems like an issue)

Fixed. Now you should see only repos with issue tracker enabled 👍.

To my understand 5. is resolved but, 4. is still needed.

Ok, I will try to push a fix for 5. tomorrow 👍.

@kosgrz thank you for the logging. Interestingly, when I deployed this build now, the behavior changed which may shed some light on the issue. In the modal, I no longer see the repos listed to attempt ticket creation.
When the user opens the create modal everything looks fine expect that it behaves as though there are simply no repos to return see screen.

The request to /plugins/bitbucket/api/v1/repositories gets a response of []
So then I looked at what happens earlier when the user connects....
From the Ui it looks successful but... I see these 2 errors happen 6 times in the logs (all within a couple seconds of connecting):
ERRO[2021-02-03T11:48:34.233195-05:00] Error occurred while searching for repositories  caller="mlog/sugar.go:25" err="error occurred while fetching repositories: error occurred while fetching repositories: Status: 429 Too Many Requests, Body: Too Many Requests" plugin_id=bitbucket`
ERRO[2021-02-03T11:48:34.268189-05:00] error occurred while searching for repositories  caller="mlog/sugar.go:25" err="Status: 429 Too Many Requests, Body: Too Many Requests\nerror occurred while fetching repositories\nmain.(*Plugin).fetchRepositoriesWithNextPagesIfAny\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/plugin.go:391\nmain.(*Plugin).getUserRepositories\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/plugin.go:359\nmain.(*Plugin).getYourPrs\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:486\nmain.(*Plugin).extractUserMiddleWare.func1\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:142\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2042\ngithub.com/gorilla/mux.(*Router).ServeHTTP\n\t/Users/dylanhaussermann/go/pkg/mod/github.com/gorilla/mux@v1.7.4/mux.go:210\nmain.(*Plugin).ServeHTTP\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:170\ngithub.com/mattermost/mattermost-server/v5/plugin.(*hooksRPCServer).ServeHTTP\n\t/Users/dylanhaussermann/go/pkg/mod/github.com/mattermost/mattermost-server/v5@v5.3.2-0.20200723144633-ed34468996e6/plugin/client_rpc.go:365\nreflect.Value.call\n\t/usr/local/go/src/reflect/value.go:476\nreflect.Value.Call\n\t/usr/local/go/src/reflect/value.go:337\nnet/rpc.(*service).call\n\t/usr/local/go/src/net/rpc/server.go:377\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374\nerror occurred while fetching repositories\nmain.(*Plugin).getUserRepositories\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/plugin.go:361\nmain.(*Plugin).getYourPrs\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:486\nmain.(*Plugin).extractUserMiddleWare.func1\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:142\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2042\ngithub.com/gorilla/mux.(*Router).ServeHTTP\n\t/Users/dylanhaussermann/go/pkg/mod/github.com/gorilla/mux@v1.7.4/mux.go:210\nmain.(*Plugin).ServeHTTP\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:170\ngithub.com/mattermost/mattermost-server/v5/plugin.(*hooksRPCServer).ServeHTTP\n\t/Users/dylanhaussermann/go/pkg/mod/github.com/mattermost/mattermost-server/v5@v5.3.2-0.20200723144633-ed34468996e6/plugin/client_rpc.go:365\nreflect.Value.call\n\t/usr/local/go/src/reflect/value.go:476\nreflect.Value.Call\n\t/usr/local/go/src/reflect/value.go:337\nnet/rpc.(*service).call\n\t/usr/local/go/src/net/rpc/server.go:377\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374" plugin_id=bitbucket
ERRO[2021-02-03T11:48:34.304404-05:00] Error occurred while searching for repositories  caller="mlog/sugar.go:25" err="Status: 429 Too Many Requests, Body: Too Many Requests\nerror occurred while fetching repositories\nmain.(*Plugin).fetchRepositoriesWithNextPagesIfAny\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/plugin.go:391\nmain.(*Plugin).getUserRepositories\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/plugin.go:359\nmain.(*Plugin).getUserRepositoriesWithIssueTracker\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/plugin.go:368\nmain.(*Plugin).getYourAssignments\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:734\nmain.(*Plugin).extractUserMiddleWare.func1\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:142\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2042\ngithub.com/gorilla/mux.(*Router).ServeHTTP\n\t/Users/dylanhaussermann/go/pkg/mod/github.com/gorilla/mux@v1.7.4/mux.go:210\nmain.(*Plugin).ServeHTTP\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:170\ngithub.com/mattermost/mattermost-server/v5/plugin.(*hooksRPCServer).ServeHTTP\n\t/Users/dylanhaussermann/go/pkg/mod/github.com/mattermost/mattermost-server/v5@v5.3.2-0.20200723144633-ed34468996e6/plugin/client_rpc.go:365\nreflect.Value.call\n\t/usr/local/go/src/reflect/value.go:476\nreflect.Value.Call\n\t/usr/local/go/src/reflect/value.go:337\nnet/rpc.(*service).call\n\t/usr/local/go/src/net/rpc/server.go:377\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374\nerror occurred while fetching repositories\nmain.(*Plugin).getUserRepositories\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/plugin.go:361\nmain.(*Plugin).getUserRepositoriesWithIssueTracker\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/plugin.go:368\nmain.(*Plugin).getYourAssignments\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:734\nmain.(*Plugin).extractUserMiddleWare.func1\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:142\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2042\ngithub.com/gorilla/mux.(*Router).ServeHTTP\n\t/Users/dylanhaussermann/go/pkg/mod/github.com/gorilla/mux@v1.7.4/mux.go:210\nmain.(*Plugin).ServeHTTP\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:170\ngithub.com/mattermost/mattermost-server/v5/plugin.(*hooksRPCServer).ServeHTTP\n\t/Users/dylanhaussermann/go/pkg/mod/github.com/mattermost/mattermost-server/v5@v5.3.2-0.20200723144633-ed34468996e6/plugin/client_rpc.go:365\nreflect.Value.call\n\t/usr/local/go/src/reflect/value.go:476\nreflect.Value.Call\n\t/usr/local/go/src/reflect/value.go:337\nnet/rpc.(*service).call\n\t/usr/local/go/src/net/rpc/server.go:377\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374" plugin_id=bitbucket

Strangely on an earlier build I was seeing the repos in my modal. Can you take a look and see why this may be occurring?

So then I looked at what happens earlier when the user connects....
From the UI it looks successful but... I see these 2 errors happen 6 times in the logs

Thank you for notifying me about this issue. I fixed it in the latest commit. You should now see error information when fetching repos failed.

Strangely on an earlier build I was seeing the repos in my modal. Can you take a look and see why this may be occurring?

I think you just reached the limit of requests to the Bitbucket API. You can send 1,000 requests per hour: https://support.atlassian.com/bitbucket-cloud/docs/api-request-limits/.
I've tried to fix the issue:

The create event shows the commit history of the origin branch you created from. This makes the subscription very noisy.

but there is no simple way to do it. The push event contains also commits that were not pushed, but are the most recent commits of the original branch. According to the documentation, there is no option available to turn off that. More info here:
https://support.atlassian.com/bitbucket-cloud/docs/event-payloads/#Push

If someone created the reference recently, it could have commits that have been pushed to the repository, but they have not been pushed to this specific reference. If that is the case, the array includes these previously pushed commits as well. For example, if you create a new feature branch off of a master branch with a lot of commits, and then you push a single commit to it, the array in the payload contains 5 commits that are all new to the feature branch.

Hi @kosgrz Thanks for the last commit. Sorry for the late reply. I have some time to focus on this in the next few days and would like to see it wrapped up :) So, Just to outline where we are....
On 1. One of the error is resolved but, I still see ...
ERRO[2021-02-10T09:06:54.8696692-05:00] error occurred while searching for repositories  caller="mlog/sugar.go:25" err="Status: 429 Too Many Requests, Body: Too Many Requests\nerror occurred while fetching repositories\nmain.(*Plugin).fetchRepositoriesWithNextPagesIfAny\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/plugin.go:391\nmain.(*Plugin).getUserRepositories\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/plugin.go:359\nmain.(*Plugin).getYourPrs\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:486\nmain.(*Plugin).extractUserMiddleWare.func1\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:142\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2042\ngithub.com/gorilla/mux.(*Router).ServeHTTP\n\t/Users/dylanhaussermann/go/pkg/mod/github.com/gorilla/mux@v1.7.4/mux.go:210\nmain.(*Plugin).ServeHTTP\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:170\ngithub.com/mattermost/mattermost-server/v5/plugin.(*hooksRPCServer).ServeHTTP\n\t/Users/dylanhaussermann/go/pkg/mod/github.com/mattermost/mattermost-server/v5@v5.3.2-0.20200723144633-ed34468996e6/plugin/client_rpc.go:365\nreflect.Value.call\n\t/usr/local/go/src/reflect/value.go:476\nreflect.Value.Call\n\t/usr/local/go/src/reflect/value.go:337\nnet/rpc.(*service).call\n\t/usr/local/go/src/net/rpc/server.go:377\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374\nerror occurred while fetching repositories\nmain.(*Plugin).getUserRepositories\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/plugin.go:361\nmain.(*Plugin).getYourPrs\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:486\nmain.(*Plugin).extractUserMiddleWare.func1\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:142\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2042\ngithub.com/gorilla/mux.(*Router).ServeHTTP\n\t/Users/dylanhaussermann/go/pkg/mod/github.com/gorilla/mux@v1.7.4/mux.go:210\nmain.(*Plugin).ServeHTTP\n\t/Users/dylanhaussermann/go/src/github.com/mattermost-plugin-bitbucket/server/api.go:170\ngithub.com/mattermost/mattermost-server/v5/plugin.(*hooksRPCServer).ServeHTTP\n\t/Users/dylanhaussermann/go/pkg/mod/github.com/mattermost/mattermost-server/v5@v5.3.2-0.20200723144633-ed34468996e6/plugin/client_rpc.go:365\nreflect.Value.call\n\t/usr/local/go/src/reflect/value.go:476\nreflect.Value.Call\n\t/usr/local/go/src/reflect/value.go:337\nnet/rpc.(*service).call\n\t/usr/local/go/src/net/rpc/server.go:377\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374" plugin_id=bitbucket

@kosgrz, I'm not sure hitting the request limit is the issue since it's quite high and resets daily. So, you would think I sometimes see my repo? Can you clarify a couple things please:
A. Could this error ☝ be the reason I don't see my repos in the modal?
B. Is this part err="Status: 429 Too Many Requests, Body: Too Many Requests\nerror occurred while fetching repositories happening in your code or a response from the Bitbucket side? I'm not clear on what's happening here.
@aaronrothschild 0/5 if we can't get this part tested soon, how would you feel about removing issue and comment creation for the initial release in the interest of getting this wrapped up?
On 2. This was already answered above...

It is true that this flag does not work. Sorry, I somehow missed that feature. I can add it quickly, but I would need to disable the option to subscribe to a whole organization when the flag is enabled. If a user wants to subscribe to a specific repository, I can check whether they have access there. But, if they want to subscribe to a whole organization, I cannot. Would this solution be ok for now?

@aaronrothschild  We have 2 options here. 0/5 can we just remove the flag from the UI and document that this release will not prevent user from making subscriptions based on Public / Private repo? The alternative provided seems quite limiting.
On 3. This seems to have been reolves by one of the last couple commits. I have all features tunred on and did some testing. I never see confusing subscription data about branches being deleted and recreated.  👍
On 4. Yes, I've done some testing and you're correct! it only shows a max of 5 commit in the branch creation payload. I misunderstood and thought it would just keep adding the entire history. That being said - This is far less serious an issue. We should address this if needed after we ship it. 👍

Hi @DHaussermann,

A. Could this error ☝ be the reason I don't see my repos in the modal?

Yes, this is the reason.

B. Is this part err="Status: 429 Too Many Requests, Body: Too Many Requests\nerror occurred while fetching repositories happening in your code or a response from the Bitbucket side? I'm not clear on what's happening here.

It's not happening on my machine. To how many repos you do have access to on your test account in Bitbucket? So, you cannot see your repos in the modal at all? Even when you use the plugin for the first time after a few days? It sounds very strange :/

Hi @kosgrz,

I only have one repo in the Bitbucket
No, I never see any repo in the modal even when I have not tried in a couple days.

Strangely, today I don't see any error when connecting the user but, I still see the same behavior where there is no repo returned in the list of reps.
Seems you need to be able to see the issue before you can help further with this :)
Just a thought... Would it help if I invited you to my test instance of Bitbucket and corresponding test instance of Jira  Cloud?

@DHaussermann, sure. You can invite me. It will be much easier to investigate the issue :)

@kosgrz sure, I would need to do it via email. Seems I can't get an email for you by looking at your GitHub handle. Can you please share an email address? You could DM it to me on the Mattermost Community server maybe?

Hey @kosgrz Propose:

for #1: @aaronrothschild 0/5 if we can't get this part tested soon, how would you feel about removing issue and comment creation for the initial release in the interest of getting this wrapped up?

Yes, let's removing issue and comment creation to get this out to beta while we try to fix this.

@aaronrothschild We have 2 options here. 0/5 can we just remove the flag from the UI and document that this release will not prevent user from making subscriptions based on Public / Private repo? The alternative provided seems quite limiting.

Agreed, Propose we cut this functionality.

@aaronrothschild, Good news for the issue creation and comment creation. I was confused on what type of Issue tracker this works with on the Bitbucket side. This does seem to be working as expected when using the out-of-the-box issue tracker. @kosgrz helped me sort this out.
So we only only be missing a change that removes the flag for Provate repos (as it is non-functional)

/check-cla


Create Menu Interface

Once logged in, display a menu with the following options:

Check Balance
Deposit Money
Withdraw Money
Change PIN
Exit

    // show login menu
    cout << "Login successful." << endl;

    string menuFunctions[5] = { "Check Balance", "Deposit Money", "Withdraw Money", "Change PIN", "Exit" };
    for (int i = 0; i < 5; i++)
    {
        cout << i + 1 << ". " << menuFunctions[i] << endl;
    }


SVN - install individual folder

I have a library of utilities that I want to use across projects, but don't want to set up individual git repos for.

Bower is deprecated now, and in maintenance mode. Because of this we won't implement new features like this one. We recommend switching to Yarn or npm, and migrating with bower-away


List<> of List<> collection initializer fails to populate the list if another project has an internal generic class named List under some circumstances

If you create an internal generic class named List in one project and namespace, then include a using statement for that namespace in a file in another project, and that file also references System.Collections.Generic and attempts to instantiate a System.Collections.Generic.List<> of a System.Collections.Generic.List<> using a collection initializer, then the collection initializer's corresponding JS will be generated incorrectly and fail to populate the collection.
This also only happens so long as a method instantiating that internal generic class is invoked by code outside its project, even if that code is itself not used.
This was originally a rather mysterious bug in collection initialisers not working in a large project but working every time I tried to replicate outside of the project which got narrowed down by iteratively removing code.
It looks like some kind of fault in type resolution getting confused by C# internal classes.
Steps To Reproduce
Unfortunately can't be replicated on deck.net due to requiring multiple projects.
You have to create two Bridge.Net projects in the same solution- a main project and a library project that the main project references, both referencing the Bridge assembly.
Each should contain one file. Main should contain App.cs as follows:
using System;
using System.Collections.Generic;
using LibraryProject;

namespace Main
{
    public class Program
    {
        public static void Main()
        {
            var inputTable = new System.Collections.Generic.List<System.Collections.Generic.List<string>>
            {
                new List<string>()
            };

            Console.WriteLine(inputTable.Count);
        }
    }

    public class UnusedClass
    {
        public void UnusedMethod()
        {
            ListMaker.Make();
        }
    }
}

LibraryProject should contain List.cs as follows:
namespace LibraryProject
{
    internal class List<T> {}

    public static class ListMaker
    {
        public static void Make()
        {
            new List<string>();
        }
    }
}

Interestingly, it fails to replicate if you do any of the following:

Remove UnusedClass

Move UnusedClass into LibraryProject; testing while cutting down the replication to this tells me that it's allowed to be in a third project of its own, but if I move it into LibraryProject itself the bug goes away.

Change

            var inputTable = new System.Collections.Generic.List<System.Collections.Generic.List<string>>
            {
                new List<string>()
            };

to
            var inputTable = new System.Collections.Generic.List<System.Collections.Generic.List<string>>
            {
                new System.Collections.Generic.List<string>()
            };

Move "using System.Collections.Generic" inside the "namespace Main" block. Still broken if you move "using LibraryProject" inside the namespace block as well, though.

Move the List class inside the ListMaker class.

Expected Result
1

Actual Result
0

Hi @jbeshir – Thank you for the excellent report. We will investigate and try to fix right away.

I've gotten a copy of a solution replicating the bug uploaded at https://drive.google.com/file/d/0B_GA-etkVzZWb3dnaWVfRXBqYWs/view?usp=sharing, which might save time putting one together.

The associated pull request has just been merged in. The fix will be available to Bridge 16.4.0.


Errors: could not find tokio in udsocket & incorrect number of function parameters

Getting the following error:
error: the main function cannot accept arguments
  --> src/server.rs:17:10
   |
17 | async fn main(notify: Sender<()>) -> Result<()> {
   |          ^^^^

error[E0432]: unresolved import `interprocess::os::unix::udsocket::tokio`
 --> src/server.rs:9:39
  |
9 | use interprocess::os::unix::udsocket::tokio::{UdStream, UdStreamListener};
  |                                       ^^^^^ could not find `tokio` in `udsocket`

error[E0580]: `main` function has wrong type
  --> src/server.rs:17:7
   |
17 | async fn main(notify: Sender<()>) -> Result<()> {
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ incorrect number of function parameters
   |
   = note: expected fn pointer `fn() -> Result<_, _>`
              found fn pointer `fn(tokio::sync::oneshot::Sender<()>) -> Result<_, _>`

I'm guessing it's because I'm not adding include!("../../example_main.rs");
Can you please provide an example that doesn't involve include!("../../example_main.rs");?

The examples as they are written now aren't meant to demonstrate how you'd write a trivial async program, but rather how to use the crate's interface. This means that the signatures of main() and the imports aren't really supposed to be looked at; furthermore, they won't work if copypasted without modification. Some mistakes you've made right out of the gate:

The compiler is correctly telling you that main() doesn't accept arguments. It does in the example because example_main.rs provides a wrapper main() function that provides synchronization, stalling the client until the server fully boots up; the main() functions you see in the examples aren't the real entry points to the client and server programs. A full-fledged program would employ a different kind of synchronization – or perhaps none at all, depending on what you want the code to do if the client is started at a time when the server isn't running – and implement it within its own main().
Because you're not supposed to use the example_main.rs wrapper, your main() function needs to be annotated with #[tokio::main], else it won't be allowed to be async. Alternatively, it could start its own Tokio runtime manually and run an async function of your choosing.
Unrelated to the peculiarities of the example, you haven't enabled the tokio_support feature flag as described in the top-level readme, which means that the Tokio dependency isn't included in your build of interprocess at all. To fix this, apply the following change to your Cargo.toml:- interprocess = "1.2.1"
+ interprocess = { version = "1.2.1", features = ["tokio_support"] }

The reason the examples are the way they are is that they're the remnants of a failed attempt to unify examples and tests. I'm planning to move them back to the Rustdoc documentation where they used to be in an older version, so I'll consider this unsolved for now and will close the issue when I do.

As the examples now reside entirely within Rustdoc, this issue is no longer applicable, and, I assume, is solved.


couchbase lite java listener is thread safe?

Hi Folks,
1)CBL DB with lots of data.
2)When async REST request are made to couchbase lite java listener back to back from JavaScript.
3)Could couchbase lite java listener able handle this use case?
4)See that router code has synchronised most of the part.
https://github.com/couchbase/couchbase-lite-java-core/blob/1.4.0/src/main/java/com/couchbase/lite/router/Router.java#L2498
How thread safe is the couchbase lite java listener code.? Is there possibility of deadlock?

Each instance of {@code HttpURLConnection} may be used for one
 * request/response pair. Instances of this class are not thread safe.

@hideki @pasin please share your thoughts..
Randomly we see listener stops responding, below is the last statement then all the requests are stuck in getDatabase and no response.

[08/10 02:31:52.880] [17619] Listener: [REQUEST] (Acme.Utils.ThreadPool(1)-PooledThread: Acme.Serve.Serve$ServeConnection@d69e0c8) GET: https:mydomin:35898/dbdata/_design%2FgetHistory/_view/getHistory?key=%22tel%3A%2B918888800024%22&reduce=false&group=false
[08/10 02:31:52.881] [17619] Listener: authHeader is null
[08/10 02:31:52.882] [17619] Listener: remoteURL() addr=mydomain
[08/10 02:31:52.883] [17619] Database: getDatabase() com.couchbase.lite.Manager@ac06bc6 <EMAIL_ADDRESS>
PS: detail logs will be shared soon.
Thanks
Nithin

Hi @NitzDKoder,
Web server CBL uses as a listener creates a thread per a request. So the listener is a thread-safe.
And CBL database is a thread safe.
If you can observe the multithreading issue, please share it with us.
Thanks!


Feat/loadYeastModel.py

Main improvements in this PR:
See issue #101. It's temporary, until cobrapy updates its parser. At that point we will switch to a dictionary as input to the parser, as mentioned by @matthiaskoenig
@hongzhonglu could you try running it in your machine as well to confirm we have a working model in python for both PC and MAC?
I hereby confirm that I have:

[X] Tested my code with all requirements for running the model
[X] Selected devel as a target branch (top left drop-down menu)
[X] If needed, asked first in the Gitter chat room about this PR

@BenjaSanchez  I will test it.


[FLINK-23944][Test] Unstable PulsarSourceITTest.testTaskManagerFailure

https://issues.apache.org/jira/browse/FLINK-23944 It has been a long hanging issue.

I think we can close this issue now.


Translated 'Côte d’Ivoire' to spanish

Côte d’Ivoire is known in spanish as Costa de Marfil (Wikipedia). I changed it in all spanish variations.

The data is coming form ICU database, we don't change it by hand. If you want to change it, please refer to ICU.

Sorry @umpirsky, didn't know that. Can you please tell me from where the data is taken?. Don't find it on readme or code...

http://site.icu-project.org/

Thanks, will make the changes on ICU project.


Refactor config

Refactor the config file now that there is a common URL base for the binary downloads. Also add an announcements config section to ensure consistency there.

Zowe v1.0.0 is signed by Matt, if you see https://projectgiza.org/Downloads/post_download.1.0.0.html. We may continue this pattern by major version releases will be signed by Matt. So currently I have a file indicate which signature should be used for each release. I'm not sure if it's good idea to put it in release config yaml as a property of each release?

What about having the signing information in another file that could be download ( much like the .asc and .sha512 files are ). This would enable us to hook this into automation.

In a past discussion, CLI team doesn't want to "promote" people to download history builds. So we didn't list CLI download link in the history builds section. We may confirm with Broadcom about their strategy.

Not sure why Broadcom needs consulted - it's a project decision which is best practice.

We used to host pre-GA releases, legal page is different. So I have a release property saying which EULA version should be used. Since pre-GA versions had been removed, currently all releases have same EULA. But in the future, it may be changed, like the LTSR and non-LTSR could have different EULA. Anyway this is not in priority, we can handle when it comes.

There shouldn't be a need for a different EULA.

SMP/e package file may not follow the other download pattern like builds/v1.?.?/file-1.?.?.pax, and another issue is for each alpha release, it has 2 files, one is pax.Z and another is readme.txt. For alpha releases, we may not sign it, but for formal release, we will sign both files like other releases.

We can add another form handler for those as needed.

Another potential change come with SMP/e is we may in the future release convenient build and SMP/e build in same release cycle. For example, if we start to release SMP/e with 1.6.0, then before 1.6.0, we have zowe pax, CLI to download. And after 1.6.0, we have zowe pax, cli zip, and also 2 SMP/e files as a combination to download. So for each release, we need a way to defne what artifacts we have for that release. Another potential usage for this is in the future when we delivery a hot fix on zowe pax only. Example is we have released v3.1.0, and we want to delivery a hot fix for v2.6.0 as v2.6.1. We can release v2.6.1 for zowe pax only, no cli will be included for that hot fix release.

I'd suggest that not happen - remember that framework releases are all components and not just some components.

I was thinking to host lagel/post download pages under https://github.com/zoewe/zowe.github.io, as another layout. It will be easier for us to fix issues. Do you have concerns on this comparing hosting on S3?

They need to be on S3. There shouldn't be a need to edit these often, and we can coordinate updates.


Add docs contribution guide

Signed-off-by: Frank Liu<EMAIL_ADDRESS>

Codecov Report

Merging #1088 (59fcb99) into main (b051737) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1088      +/-   ##
==========================================
+ Coverage   69.84%   69.87%   +0.02%
==========================================
  Files         213      213
  Lines        9474     9496      +22
  Branches     1567     1573       +6
==========================================
+ Hits         6617     6635      +18
+ Misses       2400     2399       -1
- Partials      457      462       +5

Impacted Files
Coverage Δ

towhee/functional/mixins/state.py
82.60% <0.00%> (-3.76%)
:arrow_down:

towhee/functional/data_collection.py
86.22% <0.00%> (-2.49%)
:arrow_down:

towhee/functional/mixins/entity_mixin.py
89.61% <0.00%> (-1.94%)
:arrow_down:

towhee/functional/__init__.py
70.73% <0.00%> (-1.07%)
:arrow_down:

towhee/hub/repo_manager.py
79.48% <0.00%> (+0.85%)
:arrow_up:

towhee/dataframe/dataframe.py
74.15% <0.00%> (+1.04%)
:arrow_up:

towhee/engine/factory.py
90.41% <0.00%> (+1.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 293bbcb...59fcb99. Read the comment docs.

/lgtm
/approve


change numberTrainingSegmentsLoadedOnGpuPerSubep

Hi,
When I change the numberTrainingSegmentsLoadedOnGpuPerSubep=10000, it always shows a error as,
A fatal error has occured during the function execution
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/ppworker.py", line 97, in run
self.pickle_proto)
SystemError: error return without exception set
Traceback (most recent call last):
File "./deepMedicRun", line 119, in
deepMedicTrain.deepMedicTrainMain(absPathToTrainConf, absPathToCnnModelGivenInCmdLine, cnnInstanceLoaded, filenameAndPathWhereNewlyCreatedModelWasSaved, args.reset_optimizer)
File "/home/by354/mywork/testcode/Segmentation_myimplement/deepmedic-freezeLayers/deepmedic/frontEndModules/deepMedicTrain.py", line 496, in deepMedicTrainMain
do_training(*trainSessionParameters.getTupleForCnnTraining())
File "/home/by354/mywork/testcode/Segmentation_myimplement/deepmedic-freezeLayers/deepmedic/trainValidateTestVisualiseParallel.py", line 1203, in do_training
labelsForCentralOfSegmentsForSubepTrain] = parallelJobToGetDataForNextTraining() #fromParallelProcessing that had started from last loop when it was submitted.
TypeError: 'NoneType' object is not iterable
However, when I set numberTrainingSegmentsLoadedOnGpuPerSubep=1000 or 5000, it would run successfully.
Is anyone have the same problem?

Hi, I would say it is because of memory. Have you checked how much it costs load the 10K segments? You should also check the Batch Size for the number of optimization steps.
You can always run it with 5k and have no problem :)
Javier

Hello,
Thank you very much for the help Javier. I will agree. I also suspect memory problems, on your main RA, running out of it when the 10k segments are extracted. (They wouldn't fit in GPU memory either, but the problem hits duriong their extraction on the CPU).
Depending on your data, possibly 10k segments could exceed 32GBs RAM I believe, possibly significantly more than this. Do an htop and see how much your RAM fills up during the segments-extraction phase.
I can see one useful reason to extract more segments per subepoch: To do more GPU processing after every round of loading from the disk (which can be slow). So, to balance CPU image loading with GPU processing and achieve the optimal usage of both vs wall-clock time. But for that, make sure your RAM can handle it. The default config is definitely not optimal for every machine, but was made to be somewhat good while affordable for even rather average machines. Further tinkering will need care from you :)
Thanks viridiu for your interest and feedback. Extra thanks to Javier for your help on this :)
Kostas

Thank both of you very much. I guess it's the memory problem.


vDevModeKeyProvisioning() with ATECC608A chip

Hi,
I am currently using an esp32 dev_kit C with external atecc608A chip connected. From what I understood, this function either stores the certificate in NVS flash or provisions them to the eccx08 chip. Is this correct and if so what exactly is the process or flow of operations ? The goal is to be able to store certificate and the private key (aws generated credentials for tls) in the chip. Is it possible with using vDevModeKeyProvisioning() function to do all of this and are there any requirements ?

I have replied on the forums https://forums.freertos.org/t/vdevmodekeyprovisioning-with-atecc608a-chip/12156/2

Hi, as the discussion is continuing on the forums, I am closing this issue. Feel free to open a new issue if you have more questions.


Deduplicate builder layers by diff id

This will remove duplicate layers that result from two buildpacks in a builder that have the same layer diff id

Codecov Report

Merging #1268 (6f85b7c) into release/v0.10.x (79126fe) will decrease coverage by 0.31%.
The diff coverage is 78.57%.

:exclamation: Current head 6f85b7c differs from pull request most recent head 0f042c8. Consider uploading reports for the commit 0f042c8 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@                 Coverage Diff                 @@
##           release/v0.10.x    #1268      +/-   ##
===================================================
- Coverage            70.25%   69.95%   -0.31%
===================================================
  Files                  124      124
  Lines                 6219     6243      +24
===================================================
- Hits                  4369     4367       -2
- Misses                1445     1470      +25
- Partials               405      406       +1

Impacted Files
Coverage Δ

pkg/cnb/builder_builder.go
86.46% <78.57%> (-0.64%)
:arrow_down:

... and 3 files with indirect coverage changes

It looks like this is backfix. Could you add a description of why?

It looks like this is backfix. Could you add a description of why?

Hey Matt! I was working on patching this backwards to deal with issues where flattened versions of paketo buildpacks potentially causing issues with older versions of kpack.


Privacy Accounting Under Sequential Composition

I am unclear about how privacy accounting works under sequential composition for the gaussian distribution. What I take from your example is that, for epsilon = 1 and assuming three queries, the epsilon for each query would be 1/3 (assuming queries for overlapping records). Since epsilon enters the mechanism only once (to determine the initial value of rho), it seems that the number of queries determines the budget for each query (and not the fraction of epsilon used per query, as with the Laplace mechanism). Therefore, this would imply that epsilon would be evenly divided among all the queries (by whatever the number of queries). So, epsilon could not be varied on a per query basis (i.e., assuming n queries, epsilon_per_q = epsilon/n, and not some other scheme, i.e., where epsilon/n1 + epsilon/n2 + ... + epsilon/nk = epsilon).
Is this correct? Thanks.

Hi!
So, to clarify, the example uses concentrated differential privacy composition (where the "rho" parameters add up), rather than pure DP composition (where the "epsilon" parameters add up). This gives better results.
The example starts with epsilon=1 and delta=10^-6 and converts this to a concentrated DP guarantee rho. That rho can be divided arbitrarily between the queries; the example divides it evenly (i.e., rho_per_q = rho / k). More generally, each query i will satisfy a guarantee rho_q[i]. The overall system satisfies the privacy guarantee if sum(rho_q) <= rho.


recreate images db from /var/lib/lxd/images

lxd.db got corrupted in upgrade between 0.14 and 0.15, first 'table tmp already exists' and when I dropped that 'foreign key constraint failed'. Unfortunately, lxd.db was wiped, and there are no logs left either :person_frowning:
It would be great if there is a method in the FAQ on how to recreate images db from the files in /var/lib/lxd/images. I use btrfs.

I just did
mv /var/lib/lxd/images /var/lib/lxd/images.o
mkdir /var/lib/lxd/images
chmod 700 /var/lib/lxd/images
and then imported one of the tar.gz files from /var/lib/lxd/images.o/ using lxc import.
Works fine. I guess this issue can be closed.


fix :fix image[0] into image

本次修改

fix image[0] into image

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.unknown seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


add some hooks for transaction service

closes: #ISSUE_Number

Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:

[ ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
[ ] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
[ ] Learn the coding contribution guide, including our code conventions, workflow and more.
[ ] List your communication in the GitHub Issues or Discussions (if has or needed).
[ ] Document changes.
[ ] Add tests for the change
[ ] Pass make installcheck
[ ] Pass make -C src/test installcheck-cbdb-parallel
[ ] Feel free to @cloudberrydb/dev team for review and approval when your PR is ready🥳

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.kongfanshen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

After discussion with @kongfanshen-0801 , let's close the PR.


outdated storybook configuration with TSDX create

Current Behavior
When creating a new bootstrapped project with npx tsdx create my-app TSDX installs the latest versions of @storybook/react (currently 8.0.9) and other @storybook dependencies. However, TSDX seems to configure the project to support an outdated version of storybook (I think version 6.x.x). As a result you are unable to use storybook from a freshly built tsdx project.
The project's storybook scripts also reference deprecated storybook scripts that are not installed by tsdx.
"storybook": "start-storybook -p 6006",
"build-storybook": "build-storybook"

Expected behavior
Be able to run storybook from a fresh project created by tsdx create, without the need for re-configuration.
Suggested solution(s)
With an additional dependency @storybook/cli the storybook scripts should become:
"storybook": "sb dev -p 6006",
"build-storybook": "sb build"

Additional context
Similar to #1179, but re-opening because of storybook V8 release.
It would seem some users have had success running npx storybook@next automigrate in order to migrate the tsdx project to a compatible version of storybook. However, this did not work for me - it is also not really ideal to have to manually patch configuration hence the solution even if it works is not desirable.
Your environment
  System:
    OS: Windows 11 10.0.22631
    CPU: (28) x64 Intel(R) Core(TM) i7-14700K
    Memory: 13.15 GB / 31.78 GB
  Binaries:
    Node: 20.11.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.21 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 10.2.4 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (123.0.2420.97)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    tsdx: ^0.14.1 => 0.14.1
    typescript: ^5.4.5 => 5.4.5

Same problem!


Manual setting of chemical shift tolerance value and default value in general settings

We need a possibility (column/field) to set a chemical shift tolerance value when we do the shift matching of same nucleus type between spectra.
For example, we want to figure out which signals (delta values) in a 1D 13C spectrum match against signals in 2D HSQC spectrum (on y axis in this case for 13C).
To have a tolerance window we need such general settings per nucleus.
@lpatiny @hamed-musallam
But where to place it exactly?
And what is the default value per nucleus?

For tolerance maybe a new tab in general preferences make sense because I suspect that we may have more than just a value per nucleus. Could depends about the actual resolution of the spectrum in fact. For example it could be 3 times the distance between 2 points of the worse resolved spectrum.


Update the URL link of SDK package and SDK automation run log to azure blob from openapi hub url

As the openapi hub adds a redirection rule for the URL access because of the network restriction. We would like to use azure blob url directly for package link and log link.

@lirenhe , this is the testing PR. The log link and sdk package link are prefixed with azure blob url. Clicking on it would download them directly.
https://github.com/openapi-env-test/azure-rest-api-specs/pull/3667#issuecomment-1669210304

@lirenhe , this is the testing PR. The log link and sdk package link are prefixed with azure blob url. Clicking on it would download them directly. openapi-env-test/azure-rest-api-specs#3667 (comment)

Is it possible to use aka.ms link instead of showing the blob URL directly?

aka.ms link cannot be used as part of the URL then append the extra paths and query.  Changes were deployed to PROD.


Adds a nodePort for .Values.coordinator.additionalExposedPorts

When deploying on Kubernetes I was faced with additionalExposedPorts nodePorts that kept changing after each deploy due to the nodePort not being specified in the Helm chart, as explained here https://trinodb.slack.com/archives/CGB0QHWSW/p1727943085442609?thread_ts=1722396654.245879&cid=CGB0QHWSW
The purpose of this pull request is to allow something like:
  additionalExposedPorts:
    https:
      servicePort: 8443
      name: https
      port: 8443
      nodePort: 30443
      protocol: TCP

not only for https but also for other services.

@cla-bot check

@nineinchnick I submitted the CLA the same day I did the PR. Thanks.

@cla-bot check


Timeline view has no media around the scrub bar

Checklist:

[X] I updated to the latest version available
[X] I cleared the cache of my browser

Release with the issue:
5.1.1
Last working release (if known):
Never worked for me
Browser and Operating System:
Firefox/Windows
Chrome/Windows
Home Assisstant/Android
Description of problem:
The timeline view for my cameras never displays any media around the scrub bar. There is no visual feedback to determine if the point in the timeline has the footage I am trying to find. Instead, it always appears like this screenshot. I've tried changing all the settings I can find for the card, nothing ever impacts the timeline preview. Note that my debug info below is an older card release, but this issue exists for me on 5.1.1.

Frigate card diagnostic information
{
  "ha_version": "2023.6.1",
  "card_version": "5.0.0",
  "browser": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/114.0",
  "date": "2023-06-11T11:22:11.079Z",
  "frigate_version": {
    "fbd21801935293b1eb4da59bc53456ad": "4.0.0/0.12.0-da3e197"
  },
  "lang": "en",
  "timezone": "America/Chicago",
  "git": {
    "build_version": "5.0.0-HEAD+gd7b150a",
    "build_date": "Sat, 22 Apr 2023 17:18:25 GMT",
    "commit_date": "Sat, 22 Apr 2023 10:10:23 -0700"
  },
  "config": {
    "type": "custom:frigate-card",
    "cameras": [
      {
        "camera_entity": "camera.yellow_room"
      }
    ],
    "timeline": {
      "media": "all",
      "style": "ribbon",
      "controls": {
        "thumbnails": {
          "mode": "above",
          "size": 75
        }
      }
    }
  }
}

Javascript errors shown in the web inspector (if applicable):
ReferenceError: t is not defined 25b80e56-e397-46de-b1f8-f6ebbfd2bcb3:1:100
    e blob:http://ha.9914.us:8123/25b80e56-e397-46de-b1f8-f6ebbfd2bcb3:1
    <anonymous> blob:http://ha.9914.us:8123/25b80e56-e397-46de-b1f8-f6ebbfd2bcb3:1

I don't understand the issue as described: the timeline view is not supposed to show media, it's just a timeline.
If you are intending to display the mini-timeline under the live media, you can enable that with something like this:
live:
  controls:
    timeline:
      mode: below

This will show the timeline under the live media, which is perhaps what you are expecting?

Thank you for taking the time to correct my misunderstanding of the docs.
That does make a timeline appear below the live feed, but doesn't seem to allow scrubbing. When I click and drag it immediately loads a recording/clip on mousedown instead of letting me move the timeline around.
Here's a my new config after applying the changes you suggested.
type: custom:frigate-card
cameras:
  - camera_entity: camera.green_room
    live_provider: go2rtc
view:
  default: image
image:
  mode: camera
  refresh_seconds: 3
menu:
  buttons:
    cameras:
      enabled: false
    substreams:
      enabled: false
    snapshots:
      enabled: false
    recordings:
      enabled: false
    download:
      enabled: false
live:
  controls:
    timeline:
      mode: below
      style: ribbon
      media: all

Turn it on for both live and the media-viewer and I think it will be closer to what you want?
live:
  controls:
    timeline:
      mode: below
media_viewer:
  controls:
    timeline:
      mode: below

Beautiful, thanks for your help. That's exactly how I expected the scrub bar to operate.


Fix: Download bug for download path not being present

Download function does not check for or create the directories in the download, resulting in FileNotFoundError incase the directories are not already present.
Extra: Updated .gitignore to ignore vscode settings.

Thanks, I've merged this.


InvalidCastException when setting DatePicker SelectedDate property - 'Specified cast is not valid'

Describe the bug
When trying to set SelectedDate property of DatePicker, an InvalidCastException is thrown.
Steps to reproduce the bug

Create a new WinUI 3 in Desktop app (Reunion 0.5)
Add a DatePicker to the MainWindow in a Grid like here:

  <Grid Loaded="Grid_Loaded">
    <DatePicker x:Name="datePicker"/>
  </Grid>

In the codebehind file, add the Grid_Loaded handler and set the SelectedDate property to a new DateTimeOffset instance:

private void Grid_Loaded(object sender, RoutedEventArgs e)
{
  var timeOffset = new DateTimeOffset(new DateTime(2021,10,10);
  datePicker.SelectedDate = timeOffset;
}

This should just work, but it throws an InvalidCastException when trying to set the SelectedDate property. The Date property works fine, but SelectedDate does not, so maybe it has something to do with Nullable<DateTimeOffset>, as that's the type of the SelectedDate property, while the Date property is just of type DateTimeOffset.
Expected behavior
Selected date should be set without throwing an InvalidCastException.
Screenshots

Version Info
NuGet package version:
[WinUI 3 - Project Reunion 0.5: 0.5.0]
Windows app type: Win32

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

October 2020 Update (19042)
Yes

May 2020 Update (19041)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Xbox

Surface Hub

IoT

Additional context
I was not able to reproduce that error on my SB2, but I was able to reproduce it on my desktop. Both have Windows 19042, I haven't found out why it happens on one machine, but not on the other. But many people reached out to me because of this issue, and using Date property instead of SelectedDate property is a workaround.

Sample project for repro: DatePickerIssue4719.zip
Repros here on 19042.906

Does not repro on 18363,1440.

I can repro on Insider build 21343.1000 (running on a Surface Book 2)

This was an issue fixed in C#/WinRT 1.1.4 - the fix will be available in an upcoming .NET SDK update, or a workaround for now is referencing the latest CsWinRT package.

Closed per Angela's recommendation

For those looking for step-by-step:

Add Microsoft.Windows.CsWinRT NuGet package reference (1.1.4 or higher) to your project
Edit your .csproj and add <CsWinRTWindowsMetadata>$(TargetPlatformMinVersion)</CsWinRTWindowsMetadata>
Rebuild / Run

@riverar - instead of step 2, we recommend adding <CsWinRTEnabled>false</CsWinRTEnabled> for overriding the runtime (although both ways work)

@angelazhangmsft Agreed. Edited to prevent confusion.

Thanks @angelazhangmsft and @riverar, great that we have an easy workaround for this.

Update: In the meantime I also found out why it worked on the SB2, but not on the desktop machine. The SB2 had the .NET SDK 6.0.0 preview 1 installed. After I uninstalled that SDK, the error also arrived there.
Next, I installed .NET SDK 5.0.300-preview21201.25. Looks with that one the error is also gone. Thanks again everyone here for the help and great support!


Popup placement is wrong

In constrast to #1733, this issue is about xdg-popups of xdg-toplevels. The issue is reproducible in both Sway and Wayfire, so I assume the problem is in wlroots. Just look at the following screenshot:
Note that this happens only in some cases. From my tests so far the problem happens if the toplevel is in the lower half of the screen (it works for the left terminator window for example):

Can you describe how to reproduce? Which client is this?

Sorry, I was just debugging this. The client is terminator. It seems that it does not call set_constraint_adjustment at all, and according to the protocol, this means we should not constrain the popup at all (so everything is good on our side). I'll report the issue to terminator/GTK.


Terraform checkov detection: CKV_AZURE_166: "Ensure container image quarantine, scan, and mark images verified"

Check: CKV_AZURE_166: "Ensure container image quarantine, scan, and mark images verified"
FAILED for resource: module.container_registry.azurerm_container_registry.container_registry
https://www.checkov.io/5.Policy Index/terraform.html

Previously added to .github/workflows/validate_terraform.yml skip_check.


Checking devices should have a clear command

python -m sounddevice is used to see the list of devices. I think that's a bit awkward, because the command is not descriptive. I know that it's the only command that sounddevice needs to offer, but I do think it'll be more elegant as something like python -m sounddevice list_devices.

That's already implemented!
You can also use something like:
python3 -m sounddevice gimme_my_devices --and-hurry-up-please

Therefore, supporting a special command (like list_devices) explicitly doesn't make too much sense, or does it?
What should happen if a unsupported command is used?
What if no command is used?

Yeah, I'd understand the resistance to this issue, it might be OCD on my part.
The issue is that once you support calling python -m sounddevice to show the list of devices, it becomes difficult to change it in the future because of backward compatibility. You might want to change it in the future to support more commands, or for example --version to get the versions of both sounddevice and portaudio. So changing it as soon as possible is beneficial.
To your questions:

What should happen if a unsupported command is used?

An error message, same as if you tried an unsupported command on any other CLI tool:
$ pip floof
ERROR: unknown command "floof"

What if no command is used?

Showing the list of commands would be reasonable, like pip does.
I'd understand if you'd close this issue.

The issue is that once you support calling python -m sounddevice to show the list of devices, it becomes difficult to change it in the future because of backward compatibility.

That is true, but now it would be too late anyway. This functionality has been there since the initial commit, now slightly more than 5 years ago.
I knew that it was a risk not to use sub-commands, but I was willing to take it.

You might want to change it in the future to support more commands, or for example --version to get the versions of both sounddevice and portaudio.

That's a good idea.
But why not just print the version information unconditionally every time, before or after the device list?
I'm not considering the actual text content of the output to be part of the API, so I would feel free to add some text any time. This is meant for human consumption, I don't think adding some version information would hurt. On the contrary, it might be very helpful information for debugging.
If we just add version information to the output, we don't need any additional command line options (at least for now).
Alternatively, we could just check for --version and make a separate version output, I don't see any conflict with the current behavior.

What if no command is used?

Showing the list of commands would be reasonable, like pip does.

I think this would be annoying, since we would have at most two options. So why not show everything immediately?
It sure makes sense with pip to have sub-commands, because it actually has several sub-commands.
To give a counter-example, this module doesn't have sub-commands (but it takes some optional arguments):
python3 -m http.server

We could of course make a sub-module like sounddevice.devicelist which could be used like this:
python3 -m sounddevice.devicelist

... but I don't think this is actually an improvement in ergonomics and I don't think it would be worth the implementation effort (re-structuring the module/package).

I'd understand if you'd close this issue.

I'm very much open to suggestions like this.
I've mentioned my concerns and some counter-suggestions, probably we can find some middle ground?

Hmm, this issue is small enough that I don't see the point in a compromise. If you're happy with the current situation that's fine, if you'd like to change it that's fine too.

I really don't see any reason for artificially creating an obstacle for users by requiring an explicit sub-command (especially since there will be only a single sub-command in the foreseeable future).
I would be fine with optional sub-commands (or flags), though, if there is need for them.
I do like your idea of providing version information (be it in addition to the device list or separately).
And I'm open for further suggestions!


Tree checkboxes don't always get API proposal check

Found here: https://github.com/microsoft/vscode/issues/173810

That was fast. You could have waited for @benibenj so he has a welcome back bug 😊


Make a list of all chosen standards

In our assessment we did not meet the requirement:

Any standard chosen for use within the codebase MUST be listed in the documentation with a link to where it is available.

Make a list of all standards that the governance game codebase is using.

Are file formats standards?

Are file formats standards?

Possibly, but it might be a stretch? However, if that's all the standards we got, let's just list that.


fix kafka client err when kafka produce failed

Codecov Report
Base: 41.31% // Head: 41.68% // Increases project coverage by +0.36% :tada:

Coverage data is based on head (ce1f0a0) compared to base (48d3c79).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   41.31%   41.68%   +0.36%
==========================================
  Files          33       33
  Lines        2268     2272       +4
==========================================
+ Hits          937      947      +10
+ Misses       1215     1207       -8
- Partials      116      118       +2

Impacted Files
Coverage Δ

pkg/kafsar/kafsar_impl.go
41.94% <0.00%> (-0.30%)
:arrow_down:

pkg/network/kafka_metadata.go
0.00% <ø> (ø)

pkg/kafsar/group_coordinator_standalone.go
68.05% <0.00%> (+2.18%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Updated single component to handle quantites on front end

As well as error handling on front end when users put too many or less than 1 item in the input

Further changes needed


[e2e] Try to fix e2e tests timeout by updating kafka image version

Purpose
Currently e2e tests constantly suffers from initialization timeout, due to zookeeper not running. This PR tries to fix this issue by updating kafka image version.
Reference: https://github.com/confluentinc/cp-docker-images/issues/925

+1


Bundling throws require()/ESM error

I'm using tsup and when I add the following import, it errors when trying to build my package:
import universalMiddleware from "universal-middleware/esbuild";

Error:
npm run build

><EMAIL_ADDRESS>build
> tsup

Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/<somepath>/node_modules/universal-middleware/dist/esbuild.js from /Users/<somepath>/tsup.config.bundled_hcben34iihi.cjs not supported.
Instead change the require of esbuild.js in /Users/<somepath>/tsup.config.bundled_hcben34iihi.cjs to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (/Users/<somepath>/tsup.config.bundled_hcben34iihi.cjs:37:30)

Turns out I was missing "type": "module", in my package.json.


[Spec Decode] Disable Log Prob serialization to CPU for spec decoding for both draft and target models.

In this PR we disable the serialization of the LogProbs to CPU for both draft and target models. To that end we make the following changes

Add top level flags to allow users to configure if they want token log probabilities during speculative decoding
Introduce a light weight TargetModelRunner using which we can set the SamplingMetadata.skip_sampler_cpu_output as needed.
Made changes to SpecDecodeWorker to skip serialization of log probability tensors if not needed.
Fixed clearing out the appropriate tensor in SamplerOutput. E.g. earlier we were clearing sampler_output.probs which is not a valid tensor.
Fixed failing tests as needed.

/Ready

@cadedaniel this pr is now ready for review. PTAL.

Thanks for the review. Addressed all comments. PTAL.

Enabling auto merge


Support tarball installation, small improvement of pr #44

Add support to install from tarball binary. Target in first from Redhat system that do not provide any ActiveMq RPM.
Improvement of PR https://github.com/puppetlabs/puppetlabs-activemq/pull/44

Fix conflicts
Keep defaults for mq_admin_username and mq_admin_username
Fix https support on binary url
Modify log directory to /var/log/activemq
Do not warn about default password when a external configuration template is used
Adding sample on README
Include PR https://github.com/puppetlabs/puppetlabs-activemq/pull/43

+1

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Yves Galante seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Openssl customer comms article

Added an update on OpenSSL security vulnerability as part of the customer comms.

Hi @cybermax-008 thanks for this contribution. docs.aiven.io contains evergreen documentation that we maintain. For product and security related updates, consider writing a blog like this one.

Thanks for letting me know about this. yes, we will go ahead with a blog post

Thanks for letting me know about this. yes, we will go ahead with a blog post


Identification request

Would it be possible to add a feature which goes through your inventory and identifies all unid items? Spend so much time clicking!

No, that would be too much automation. Right click an ID kit and select an option from the menu that appears instead


CODEOWNERS: add @NixOS/acme

Description of changes
We would like to have the @NixOS/acme team assigned for review to changes of this module.
Rationale is that changes to ACME module need to be carefully reviewed as breaking changes can be quite high-impact for end-users.
See e.g.: https://github.com/NixOS/nixpkgs/pull/270221#issuecomment-2144614920
Note that I need a github admin to set up permissions for us as I currently get the following error:

Unknown owner on line 107: make sure the team @NixOS/acme exists, is publicly visible, and has write access to the repository

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

The error could easily be bypassed, by just listing the individual people of the team which can merge PRs

Please list the individual members, because otherwise we can only allow committers to join that team.

@arianvp poke - can you finish this with individual contributor names? ;-)

Oh I didn't push this from my fork but form the main repo. let me reopen a new one.


Destroy command not working.

Destroy command not working.
AWS: instances, security groups, and key pair still there.
DigitalOcean: droplets still there.
root@kali:/opt/terry-the-terraformer# ./terry.py -o test4 -v destroy -r
[+] Start of script run with command: "./terry.py -o test4 -v destroy -r"
[+] Destroying the "test4" plan
[] Parsing the build manifest
[+] Validating that we have all required credentials
[+] All required credentials found
[] Successfully found "terraform" binary
[+] Destroying Terraform plan
Error: Missing required argument
on test4_plan.tf line 15, in provider "aws":
15: provider "aws" { }
The argument "region" is required, but no definition was found.
Error: Missing required argument
on test4_plan.tf line 16, in provider "namecheap":
16: provider "namecheap" { }
The argument "api_user" is required, but no definition was found.
Error: Missing required argument
on test4_plan.tf line 16, in provider "namecheap":
16: provider "namecheap" { }
The argument "user_name" is required, but no definition was found.
Error: Missing required argument
on test4_plan.tf line 16, in provider "namecheap":
16: provider "namecheap" { }
The argument "api_key" is required, but no definition was found.
[x] Fatal Error: Error when destroying "test4". Please try again.

Fixed.


[SDK Library] Consider supporting parsing binary integers

For some content I'm working on it would be nice if int.parse and int.tryParse natively supported parsing binary integers prefixed with 0b similar to how it handles hexadecimal 0x ones currently.
Implementing this work now would also simplify the implementation of binary integer literals in the future as included in the considered small and useful features list documented in the language repo. The CFE/analyzer currently use the method for their conversion of the literals to consistent decimal values.
Analyzer:
https://cs.opensource.google/dart/sdk/+/master:pkg/analyzer/tool/summary/mini_ast.dart;l=478
https://cs.opensource.google/dart/sdk/+/master:pkg/analyzer/lib/src/fasta/ast_builder.dart;l=2972
CFE:
https://cs.opensource.google/dart/sdk/+/master:pkg/front_end/lib/src/fasta/kernel/body_builder.dart;l=2444
If this is a development that would be welcome, I would be happy to work on the implementation and testing across the different platforms.
cc @lrhn

I'm not particularly happy with supporting 0xF00 as input to int.parse now. I'd have preferred to not support that, and only support inputs which can come from int.toString(), along with int.parseRadix to match toRadixString and perhaps int.parseLiteral to handle things that have alternative representations like 0x or 0b prefixes.
Doing everything in one function makes that function slower and more complicated, and every caller needs to pay for that, whether they use it or not.
Maybe we should just add int.parseRadix(String source, int radix, [int start = 0, int end]) which can parse a substring at any radix, then you can do if (string.startsWith("0b")) return int.parseRadix(string, 2, 2);. Having to create a substring to pass it to int.parse is also an overhead.


Feature Request: TabView

The TabView would implement the Tabs described here
http://www.getmdl.io/components/index.html#layout-section/tabs
The TabView can be placed in a main page or a dialog. The tab panels are implemented as a container which the App can fill with its own content.
I have written  an experimental TabView using as a ListView for the Tab Bar which can be downloaded from  here
http://www.museumoftechnology.org.uk/ken/tabbed.zip
The methods in this prototype are those I used in another Tkinter application and are not sacrosanct

Already done. An example in tabbox.py .


feat(armv7): optimize armv7 assembly.

feat(armv7): optimize armv7 assembly to make statistics more precise.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.chenxiaoqiang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@ruiyoua  Thanks, please sign the CLA. Otherwise, we can NOT merge your code.


Istanbul University

ogr.edu.tr added domain for Istanbul University

ogr.edu.tr added domain for Istanbul University

ogr.iu.edu.tr added domain for Istanbul University

@bdegirmen I am sorry, the domain ogr.iu.edu.tr is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


gpio_viewer.h Spelling error

Spelling error in method printPWNTraps() line 1.
Changes
Serial.printf("%d pins are PWM\n", ledcChannelPinCount); to Serial.printf("%d pins are PWN\n", ledcChannelPinCount);

The spelling is correct, it's PMW : Pulse Width Modulation


Internal IDs purpose?

What is the purpose of internal id. Is it a unique GUID for each element in application insights?
I'm using continuous export with a stream analytics and what to make sure the internal ID can be used as a check constraint on my SQL table (should I want to backfill my data)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db382c01-f666-1dc6-ffc1-6c26780b924c
Version Independent ID: e54233ce-e067-13af-e5c2-332af5749e2a
Content: Azure Application Insights Data Model
Content Source: articles/application-insights/app-insights-export-data-model.md
Service: application-insights
Product: unspecified
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@fusionet24 Thank you for the question!  We are investigating this and will get back to you shortly.

I have also updated the doc to clarify that this is a unique id. This change has been merged and will go-live in the public docs between 3:00 - 3:30 PM today. Thank you for helping us make our docs better!

#please-close


Make some block geometry files

Since the Bedrock Edition geometry files do not have UV rotation, the model converted through blockbench is not satisfactory.
It will take me some time to create the geometry files for these blocks.
由于基岩版几何文件没有uv旋转，通过blockbench转换的模型效果强差人意。
我需要耗费一些时间去制作这些方块的几何文件。

I'm starting to think that there could be tomatoes for April Fools' Day.
我开始认为愚人节也可以有番茄。
I don't know how this error arises.
我不知道这个错误是如何产生的。

Bad cabbage :(

Since the Bedrock Edition 1.21 update, blockbench conversion models have become better.
自从基岩版1.21更新后，blockbench转换模型的效果就变好了。

Sadly I need to disconnect from the internet for a year to do something important.
遗憾的是我需要断开一年的互联网去做一些重要的事情。