Unify text link colors and styles (part 1 of link component refactor)

This will unify all text and headline link styles. Standard CSS theming are removed due to CSS variables not working in IE. This is only an interim solution until we finish refactoring theming and bolt-text component. Link styles have been an on-going issue and it shouldn't be waiting on the refactor epic to fix it, because links are too fundamental to be broken just because we haven't figured out CSS variables.

@mikemai2awesome @remydenton duplicate work from a PR I opened last week?
https://github.com/bolt-design-system/bolt/pull/674/files#diff-de64e407a8ed3a42a16079d23747ad41


Playing multiple tracks desync audio

I am developing a multi-track player with the lib but struggling with audio synchronization.

You can try with the current lib api but if you struggle in your use case there would need to be a native implementation for handling multiple tracks. Please share what exactly you want to build and what issues do you face


Add the ability to set the number value for Select and Combobox

Motivation
String is currently the only possible value type in Select and Combobox. But a frequent case when we need to specify a number (different kind of ID) as a value. Is it possible to add "number" as a valid value type for Select and Combobox components?
Usage example
const state = useSelectState({
   defaultValue: 123,
});
...
<SelectItem value={123}>Some number</SelectItem>
<SelectItem value="apple">Apple</SelectItem>

Requirements

The Select component must accept a 'number' type for the value
The Combobox component must accept a 'number' type for the value

Workaround
No response
Possible implementations
No response

Can't you use a string and parseInt(value) when consuming it as a number?

@diegohaz Yes, I can convert to a string as input and back to a number as output, but that makes it a little more difficult to use. It would be easier if the number type is initially valid


Adding Power support(ppc64le) with ci and testing to the project for architecture independent

Adding power support for this package to support arch independent
I am working for IBM to port cpu arch ppc64le for open sources.
This PR adds CI support for the IBM Power Little Endian (ppc64le) architecture. The idea is to ensure that the builds on this architecture are continuously tested along with the Intel builds (amd64) as this is part of the ubuntu distro
on that architecture as well and detecting (and fixing) any issues or failures early would help to ensure that we are always up to date.
This helps us simplify testing later when distributions are re-building and re-releasing,We typically build applications for customers and ISVs, and while we don't use this package directly, we do count on all of the packages in debian/ubuntu to build other packages. So we more likely have this as a second or third level dependency and couldn't tell you explicitly which features we use or our usage model.
Please help to verify and merge.

Thanks, @asellappen !


Added turn_to_turn config option

This PR adds a new config option so that both PeerConnection use TURN servers only. Enabling the option results teh communication path going from a triable into a trapezoid.

I've been thinking can we change the flag to TestModes or something like that? Instead of it being a boolean it would be a slice of strings (maybe)?
I want to give the flexibility of being able to say we'll test relay on pc 1 but relay on pc2, or relay on pc1 but host on pc2. I was thinking about a cli flag like -mode relay:srflx and -mode relay:relay for example...
I'm not sure if theres a better way to do that in Go. Whether maybe its as simple as  a slice of slices.... In javascript I'm thinking it owuld be an array of arrays with two elements in the array....
[
  ['relay', 'srflx'],
  ['relay', 'relay']
]

For example... and then we could still have a command line flag which is -mode relay:relay,relay:srflx (not asking you to do the CLI flag!)
Any modes that aren't implemented just continue over the test...
The idea being that from the API or even ice server uris created from the config file, you could list test modes against against a specific uri.

Just to clarify: do you ever see the offerer doing anything else then Turn/relay?
I'm asking, because having the offerer always would simplify this quite a bit. And on the other hand this project seems to be focused on testing TURN so far.
If we keep the offerer always on TURN/relay the TestMode would only become a list of possible strings for how to filter ICE candidates on the answerer side, right?

I think that's a fair assumption to make currently.
Longer term we do want to test SFUs for connection time for example... but those would be different tests and outside of this config.
So yes, I think the assumption that the offerer is always relay and it's the answerer that can change which kind of candidate is passed back to the offerer (as well as changing its ice configuration to all vs relay ) is fine!


Could coordinates arrays be TypedArray slices?

This wouldn't work if this uses integers and e6 encoding, but could, instead of creating Array objects, coordinate (2 element or 3 element) arrays are slices into the TypedArray?

Pushed a flagged-off impl in #8


Open Source License

Hey, great work with zcrun!
Any chance you'd be willing to put this under an open source license?

Sure!


Toggle

Pls add toggle msg to input node. For one stateless button ON/OFF.

Can you not do this with a trigger node ?

I have added an "toggle" keyword for the "on" property, for it to work good you should also send an brightness because it becomes zero when the light is turned off

Thanks 👍🏻

Thanks 👍


build(client): Externalize fluid-build config

The config used by fluid-build was stored in the fluidBuild node in package.json. Now it's stored in an external JS file.
Benefits:

The config can now be commented to explain inline what it does and why.
Changes in package.json and the config will be isolated, making main/next merges easier and reducing churn in package.json.

Thanks for the review, @curtisman.


feat(client): DataProxy query logs

Tracked in https://github.com/prisma/client-planning/issues/158
Sibling to https://github.com/prisma/prisma-engines/pull/3618
In progress.

Closes: https://github.com/prisma/client-planning/issues/144

I added a test for non-interactive transaction logging. I think we should merge this.


add xml pn balance

Pull request template
Checklist

[x] I have read the CONTRIBUTING guide
[ ] branch rebased on develop
[x] styleguide check npm run validate
[x] good naming
[x] keep simple
[ ] video or screenshot attached
[ ] testing instruction attached
[x] check your PR once again

Description

Video or screenshot

What and how to test

Он называется XLM


Adding realtime segment metrics

Adding realtime segment metrics for number of segments and number of documents.
Current NotifyCommit method call will do closeSegment then addSegment, which will do segment number -1 then +1 which means the realtime segment metrics are not updated any way.

LGTM. Subbu, I am merging this. I am assuming this should not interfere with incrementing/decrementing read/write locks

close as already pushed.


Frontend: remove -emit-ldadd-cfile-path. NFC

ld should now fully support $ld$previous$, so we shouldn't need this workaround
to generate a C source file to include $ld$add$ definitions.

@swift-ci please smoke test

@swift-ci please smoke test


GEOPY-510

GEOPY-510 - Fix/standardize app_initializers

followup of https://github.com/MiraGeoscience/geoapps/pull/316


Video stream isn't closed on Player component removal

Current Behavior
Video stream isn't closed when we stop player and remove component.
Expected Behavior
Component either closes the stream on removal phase or has the method for this.
Steps to Reproduce

Open player with video stream and remove component.
Check in network that stream still fetches the video.

Environment
Nothing special about environment. Current machine I have this one is: MacBook Pro M1, Chrome. But this can be found on demo page of this project as well. UPD. It occurs with FLV.

Have the same behaviour, this seem critical

faced this issue for flv format

Having the same issue with webm-format HTTP streams. The connection doesn't close even if I reset the url to empty state inside useEffect() return as an unmount cleanup.

I have the same problem, has anyone fixed this?


COmmand line arguments not overriding defaults

--cluster-queue-manager slurm not overriding sge when supplied on command line

Yeh I noticed this a while back but wanted to wait for a meeting with others before deciding on the option priority as I think this may need revisiting

I have a different issue here in that the options in my .cgat.yml file are not overriding the sge default, however if I supply the arguments on the command line, then my pipelines run fine with slurm.
I am also having the issue (not sure whether it is related) that if I run my pipeline from a particular Conda environment, the pipeline statements don't seem to be run within that environment unless I add the following:
P.run(statement, job_condaenv = PARAMS["conda_env"])

cgatcore                  0.6.7                      py_0    bioconda
drmaa                     0.7.9                   py_1000    conda-forge

Hmm that's strange that the .cgat.yml isn't overwriting the sge defaults. I am now on a slurm cluster and can debug to find the issue.
This is the opposite of what David has reported, yours seem to be overwriting through command line.
Regarding the conda env issue, that's strange and suggests that your environment may not being copied to the non-interactive shell on the cluster for some reason.

Yes that's the strange thing that it's the opposite of what David is saying - command line seems to overwrite for me.

@Acribbs I am still having this issue on the CCB server and I know several others who are as well, including @deevdevil88.  Any thoughts?

Hi Lucy,
Things are pretty busy at the moment with grant writing and paper submission. But I will try and take a look in next few days. In meantime, can you share your .cgat.yml file and a test dataset that highlights the issues?
Thanks

This is the contents of my .cgat.yml file that is in my home directory - GitHub doesn't support the yml file ending.
cluster:
  queue_manager: slurm
  queue: batch

I have to run my pipelines as follows:
python pipeline.py --cluster-queue-manager slurm --cluster-queue batch make full
I also have to specify the conda environment for each statement within P.run().
It works fine on the BMRC SGE server, so I think it is a Slurm issue.
I will send you an example mini pipeline and input files.

Hi Adam!
similarly to what @lucygarner explains, i found that on my SLURM cluster , the worker node won't inherit the environment activated on the login node hence variables and packages are not being picked up altogether.
Our solution to this is to specify the conda environment in the .cgat.yml file (or separately in each pipeline.yml file, if different environments are needed for each pipeline) and change the P.run(...) commands in the pipeline.py to activate the conda env param, i.e. P.run(statement, job_condaenv = PARAMS["conda_env"])
I was hoping for a different workaround though, one that doesn't rely on having to rewrite the P.run() statements but defines the same conda env for all jobs.
Any idea?
thanks!!
fabiola

@bio-la, are your pipeline scripts picking things up from the .cgat.yml file? I seem to be having the additional issue that the info in that file is not picked up.

yes, my pipeline script picks PARAMS from .cgat.yml as well as pipeline.yml
I wasn't aware of this until charlotte pointed that out to me and it works, just tested that.

Hi,
python pipeline.py printconfig may help troubleshoot the issue. Specifically there should be a section: List of .yml files used to configure the pipeline in the output with the list of yaml files being picked up and their associated priority to load them up (higher priority overrides lower ones)
I hope that helps.
Best regards,
Sebastian

Hi,
Please paste the output of:
python pipeline.py printconfig | grep "cluster_queue"
python pipeline.py printconfig --cluster-queue-manager slurm | grep "cluster_queue"

I would like to compare the values of cluster_queue_manager in the lines of the output starting with and without #.
Best regards,
Sebastian

Hi Sebastian,
I met with Lucy and I sorted out her issues (basic issues), but in the process realised that while the pipeline submits jobs to the slum correctly, it prints out values at the beginning of the pipeline as the default sge. I can take a look at this, but I suspect it may be displaying the params before they are updated.

Hi Adam,
Sorry to open this again.
im also having the same problem as Lucy, so would be good to know what the fix is and what i need to add or remove from my bashrc to fix this.
Best
Devika

Can you share your bashrc with me and I can see if it has the issue?

sure thing . here you go

Hmm, there doesn't seem to be a major issue with your bashrc, however can you try commenting out the SHARED_TMPDIR and the DRMAA_LIBRARY and try running the pipeline. Was was you specific issue? You cannot submit jobs to the cluster?

The issue that fixed @lucygarner was related her environment not inheriting variables in non interactive shells, fixed by:
if [[$PS1]]; then
#bash code
fi

@Acribbs  same issue as  @lucygarner , that when i run cgatcore pipelines, it doesnt inherit the params from .cgat.yml file in my home directory. i m able to run the pipeline if specify the --cluster-queue-manager and --cluster-queue  params in the pipeline make command when run the pipeline but not otherwise

do you get drama API errors? Can you show me a failed log trace please and one that works?

you know what i actually dint check running my pipelines recently without setting the --cluster-queue and --cluster-queue-manager since i last encountered the error back when we discussed this on the issue and seems like it works now. i magine it must be to do with my .bashrc originally and i guess back in May last year when we all used the same .bashrc for CCB based Charlies example, that must have sorted it out. But i dint realise. Sorry seems like it works now

Ah brilliant!


Quotes appear escaped in the webapplication

If a Java class has a JavaDoc containing quotes, the quotes appear escaped in the Frank!Doc webapplication. You cannot have JavaDocs like The name of the thing is "your name". Such a text appears as The name of the thing is \"your name\"

This must be fixed in the webapplication, there the javadoc text must be properly unescaped


[Preview 8] Blazor: @ref:suppressField leads to a JavaScript DOMException

Describe the bug
A html element with a @ref:suppressField="btn" leads to a JavaScript exception:
Uncaught (in promise) DOMException: Failed to execute 'setAttribute' on 'Element': '@ref:suppressfield' is not a valid attribute name.
To Reproduce
@page "/counter"

<button @ref:suppressField="btn" @onclick="IncrementCount">Click me</button>

@code {
    ElementReference btn;
    void IncrementCount()
    {
        var test = btn.ToString();
    }
}

Screenshots

Additional context
Add any other context about the problem here.
Include the output of dotnet --info
.NET Core SDK (reflecting any global.json):
 Version:   3.0.100-preview8-013656
 Commit:    8bf06ffc8d

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.17134
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.0.100-preview8-013656\

Host (useful for support):
  Version: 3.0.0-preview8-28405-07
  Commit:  d01b2fb7bc

.NET Core SDKs installed:
  2.1.202 [C:\Program Files\dotnet\sdk]
  2.1.508 [C:\Program Files\dotnet\sdk]
  2.1.800 [C:\Program Files\dotnet\sdk]
  2.2.103 [C:\Program Files\dotnet\sdk]
  3.0.100-preview8-013656 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.0-preview8.19405.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0-preview8-28405-07 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.0.0-preview8-28405-07 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

We expect ref and ref:suppressField separately. This should be a compiler error.

Closing this as we have a separate issue tracking the work which is left here: #13137


Add descriptive text for each image in tt blog

Hi all,
this is not ready for merge but wanted to share to get thoughts on the look.
Still to do = image 3

Also the build is failing because I added html code to a md file.  If we are happy with this approach  for descriptive image text, I can rename the file as html (had to do this for the Team page also).

Ok, I've made the changes to image three - removed 'tribe' and added the text description. This is ready to go...just needs a review to ensure the text description is a good representation of what the image is showing.  Also, I think this branch is now a few commits behind the master...I forget how to fix that.


AKS issuer URL is different from configured format

Description
It appears that AKS has updated the OIDC Issuer URL format and it no longer matches what Fulcio expects. The AKS cluster that I have running in the East US region has the following OIDC Issuer URL for the workload identity preview:
%~> az aks show -n myCluster -g myGroup --query "oidcIssuerProfile.issuerUrl" -otsv
The behavior of this command has been altered by the following extension: aks-preview
https://eastus.oic.prod-aks.azure.com/****

This may also be a difference in the specific region that the AKS cluster is provisioned in.
Version

cosign: v2.0.0-rc.0
fulcio: Public instance (https://fulcio.sigstore.dev)

@yorinasub17 Do you want to try now, https://fulcio.sigstore.dev/api/v2/configuration shows it should be rolled out

Just tried and it worked! I was able to successfully get a signing certificate from fulcio using cosign! Many thanks for the review and help getting this rolled out!


Image URL doesn’t resolve

Hi Mike! I love this boilerplate. My issue is the images does not include in /dist after run  npm run build:prod.

my way to solve is following Jvalen post.
https://github.com/AngularClass/NG6-starter/issues/139
`//webpack.dist.config.js
var CopyWebpackPlugin = require('copy-webpack-plugin');
...
config.plugins = config.plugins.concat([
new CopyWebpackPlugin([
{ from: 'client/assets', to: 'assets' }
]),
...
]);`


Cydia menu won’t work properly

Describe the bug
When I’m on Cydia on iOS 7,2 version 12.2 and Cydia version 1.1.32 beta 16 and I cannot use the home screen features. I am on the latest Unc0ver version 3.4.2
Screenshots

Place an "x" between the brackets if true:

[?] this is a bug others will be able to reproduce
[x] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[x] this issue is present after a rootfs restore
[x] this issue is present on the latest version of unc0ver

Known issue. Swipe right on the cells slightly I believe

@xMilesManx That worked! Thanks for the workaround!


⚠ ClamAV has degraded performance

In 747e45d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 235 ms

Resolved: ClamAV performance has improved in ffc20e6 after 6 minutes.


Can't open webpage.

I'm trying to flash the firmware on a generic nodemcu board using the "UNOWIFIDEVED" parameters
firmware flashes successfully and SSID appears (and connects). I've also uploaded sketch data folder using "esp8266 sketch data uploader" tool.
But the webpage doesn't seem to open by pointing my browser to <IP_ADDRESS>
Am I missing anything?

please try <IP_ADDRESS>

@jandrassy tried it without any success. Anyways, default IP in the code is set to <IP_ADDRESS>
Also I noticed just now that my android phone fails to obtain IP address from the AP. which means DHCP might not be running?

try to flash the firmware with Tools menu option "Erase flash: Sketch + WiFi Settings"

Did that aswell. no change. webpage still wont load.

I found the error. Fix is committed. It was an old bug by arduino.org coders. I should have noticed it much earlier.

Thanks. but it still wont load. I can't even ping to the module.

try to flash some ESP8266 example for example  BasicHttpClient to connect to your AP and let the esp8266 store the ssid and password. Then upload the WiFiLink firmware and it should connect to AP and be accessible in that network

I hope you didn't select Arduino/Uno WiFi to upload the firmware. it would not work on NodeMcu

yes ofcourse. the  wouldn't compile on "Arduino/Uno WiFi". anyways. Connecting nodemcu to a AP is not an option here As I plan to use it only in AP mode.

try to flash some ESP8266 example for example BasicHttpClient to connect to your AP and let the esp8266 store the ssid and password. Then upload the WiFiLink firmware and it should connect to AP and be accessible in that network

Just did that. and it does work when connect to  an access point( i.e. in STA mode)

and SoftAP still doesn't work?

and SoftAP still doesn't work?

No.

could you try to switch modes in WebPanel? to STA and the back to AP+STA

could you try to switch modes in WebPanel? to STA and then back to AP+STA

Yes. works in this way in AP+STA mode. but not when I freshly upload the code.

and after fresh upload now is it available as STA?

and after fresh upload now with flash erase is it available as STA?

Yes works with STA mode.

AP is not started if esp8266 has stored STA mode
https://github.com/jandrassy/arduino-firmware-wifilink/blob/c634eca7f34a117f0f3a8167f482636c74c616d1/ArduinoFirmwareEsp/ArduinoFirmwareEsp.ino#L110

I've found a potential fix. by commenting out the initHostname(); function in void setup() the code works normally in both STA mode and AP mode.


Flag for global vs local secret, registry

Add some sort of metadata to the registry and secret so that we know its source (e.g. local, global, vault, etc)

due to design changes in 0.9, this will no longer be required


Image Distortions should be able to be applied to batches. [Feature Request?]

The tf.image distortion functions only accept a single image as an input whereas it would be much more useful to be able to place the distortion within your graph flow so any batches of images that pass through it get distorted too. I believe a current solution is as suggeested by @mrry here on Stack Overflow however it feels like, much like the other ops for images work, being able to take batches would be much more useful.
Is the solution proposed by @mrry the accepted method or should the distortion functions be taking batches?

I made a similar changed to resize_image_with_crop_or_pad in https://github.com/tensorflow/tensorflow/pull/7369.

@cancan101 that would be great, something like that. The map_fn method is looking promising for the mean time (as i'm short on time to go and patch TF myself) but I had some PIL/Pillow tools built already in Python so might look at trying to feed in and out of that (although would much rather prefer an in-graph solution!)

@mrry, since you commented on the Stackoverflow, could you comment on this?

I think it makes sense to make the image API more consistent (in a similar manner to what @cancan101 did), but I'll defer to anyone who feels more ownership over the image API (e.g. @martinwicke, @shlens?).

See also #1029, #521. @cancan101 did #7369 fix #521?

And https://github.com/tensorflow/tensorflow/issues/8465?

Just to chime in, it seems that some image ops (e.g. tf.image.random_brightness(), tf.image.random_contrast()) allow batches, while others (e.g. tf.image.random_saturation(), tf.image.random_hue()) do not – it would make sense to either make all the image ops accept batches, or at least note on the documentation that they don't.
(also, does the "awaiting tensorflower" flag mean a TF dev is working on this, or is this open to contributions?)

Stale tags. Fixed now.

Automatically closing due to lack of recent activity. Since this issue is old at this point, please reopen the issue if it still occurs when tried with the latest version of Tensorflow. Thank you.

@itsmeolivia It is a little bit strange to close an issue with tag awaiting tensorflower. Tensorflower arrived to close just close the issue 😄? And now only the issue owner or a tensorflower could reopen it.

@bhack Hey! I don't see what's strange.  It was not awaiting a tensorflower as per the tags.  It hasn't been commented on in almost two months so my original statement, "Automatically closing due to lack of recent activity. Since this issue is old at this point, please reopen the issue if it still occurs when tried with the latest version of Tensorflow. Thank you"  still makes sense, especially in light of 1.2 coming out today 😄

Was not commented cause we was awaiting a tensorflower tagged by a tensorflower. Cause is old I don't know if the owner (@jubjamie) is still interested on this topic. If he is not active anymore only  a tensorflow could reopen this issue.

@martinwicke Can we considered this to be solved by tf.map_fn()?

Nah, last comment was April 19, I removed awaiting label April 20, marked contributions welcome, no activity since then.
map_fn is not the perfect solution, but it's a solution. If you think it's valuable to leave open as contributions welcome, we can leave it open. There's not enough demand to prioritize this though, and nobody's lining up to do it (although it would be a fairly good entry-level contribution).

You a right I've missed the contributions welcome label. I think that this issu was linked to many other issue about batch in image api some of that are closed in this closing run. Can we live one issue opened for all realted to batching in image api?

I think also an unique issue doesn't make sense cause resize_image_with_crop_or_pad in image api now support batch

I'm very much still active! However I don't have time to work on the contribution. I raised it as an inconsistency that I thought the Devs would want to fix but if it's being left as contributions only for this long with no response then I guess we'll just have to wait until someone else has the same issue but with more time than me!

>>> import tensorflow as tf
>>> tf.__version__
'1.2.0'
>>> x = tf.placeholder(tf.float32, [None, 32, 32, 3])
>>> tf.image.random_brightness(x, max_delta=0.125)
<tf.Tensor 'adjust_brightness/Identity_1:0' shape=(?, 32, 32, 3) dtype=float32>
>>> tf.image.random_contrast(x, lower=0.5, upper=1.5)
<tf.Tensor 'adjust_contrast/Identity_1:0' shape=(?, 32, 32, 3) dtype=float32>
>>> tf.image.random_flip_left_right(x)
...
ValueError: 'image' (shape (?, 32, 32, 3)) must be three-dimensional.
>>> tf.image.random_flip_up_down(x)
...
ValueError: 'image' (shape (?, 32, 32, 3)) must be three-dimensional.
>>> tf.image.random_saturation(x, lower=0.5, upper=1.5)
...
ValueError: Shape must be rank 3 but is rank 4 for 'adjust_saturation/Slice' (op: 'Slice') with input shapes: [?,32,32,3], [3], [3].
>>> tf.image.random_hue(x, max_delta=0.2)
...
ValueError: Shape must be rank 3 but is rank 4 for 'adjust_hue/Slice' (op: 'Slice') with input shapes: [?,32,32,3], [3], [3].

Not all image ops support batch still, can we reopen? I raised a separate issue about making the image module API more consistent (#9318) but closed it because this issue existed. This has been on the back of my mind to contribute to because it would benefit a model I have but I haven't had time to look into it recently.

Let's keep this open to track progress on this issue.

I know this has been briefly mentioned, but I've had great results just using tf.map_fn.
hue = lambda x: tf.image.random_hue(x, 0.5)
hue_imgs = tf.map_fn(hue, input_imgs)

This seems to work on the whole batch.
+1 to the fact that it is annoying how some ops (random_brightness) work on batches, but others (random_hue) do not :-/

tf.image.random_flip_left_right() on batch would be fine indeed ...

I would like to volunteer to fix these functions:

flip_left_right
flip_up_down
random_flip_left_right
random_flip_up_down

There are two I'm not familiar with but will also try if I think I can manage:

transpose_image
rot90

The batch support for adjust_hue should have been enabled through PR #14187. And the batch support for adjust_saturaton will likely be addressed if PR #14794 is accepted.

Hi,
Would it be possible to make the distortion functions applicable not only on the entire batch, but also with a different seed per batch element ? This would lead to batches that have both the original and distorted examples, hence more diversity.
Something like:
inputs = tf.map_fn(lambda item: tf.image.random_flip_left_right(item[1], seed=item[0]), enumerate(inputs))
although it doesn't work this way, as there's an enum-to-tensor conversion.
I was also thinking about computing the seed as a function of the image (e.g. sum of all pixels), but it doesn't work with seed as Tensor, only int.


This Is Issue 20

This Is Issue 20
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688285170064149

Proposal
This is test proposal for https://expensify.slack.com/archives/C049HHMV9SM/p1688285170064149


feat: support new auth types

OAuth 2.0 authorization code test
specVersion: 1.0.0
integrations:
  - name: hubspotCRM
    displayName: Hubspot CRM Integration
    provider: hubspot
    module: crm
    proxy:
      enabled: true

Basic auth test
specVersion: 1.0.0
integrations:
  - name: mailgunTest
    displayName: Mailgun Test Project
    provider: mailgun
    proxy:
      enabled: true

API key test
specVersion: 1.0.0
integrations:
  - name: jotformTest
    displayName: Jotform
    provider: jotform
    proxy:
      enabled: true

OAuth 2.0 client credentials test
specVersion: 1.0.0
integrations:
  - name: domoTest
    displayName: Domo
    provider: domo
    proxy:
      enabled: true

@eberle1080 in a follow up PR, can you please do the following:

instead of a "show" button, can you use the eye icon that we use in our console so we are consistent? (you can use this PR as an example)

Another follow up, you should use LoadingIcon instead of Loading... text


Test Explorer doesn't run mocha tests with fs.readFileSync and possibly more

When I have unit tests that call fs.readFileSync, the test does not show up in Test Explorer, but the code runs fine.
fs.readFile also works fine.

Hmm, could you provide some sample code?  I can't repro this using the code below.
var assert = require('assert');
var fs = require('fs')

describe('Test Suite 4', function() {
	it('Test 3', function () {
		var txt = fs.readFileSync('hello.txt');
		console.log(txt);
		assert.ok(true, "this should pass");
    })
})

Also just verify that the test framework is marked as "mocha" for every file and try building the project. (Ctrl+Shift+B) We currently discover tests when you modify a file, but you'll have to build when you add new files.

The code you provided works, but when the fs.readFileSync is moved out of the test, such as when requiring other files, it doesn't show up in test explorer.
var assert = require('assert');
var fs = require('fs')
var txt = fs.readFileSync('hello.txt');

describe('Test Suite 4', function() {
    it('Test 3', function () {
        assert.ok(true, "this should pass");
    })
})

The above does not work. This is an issue because my test code is something like this.
var app = require('server');
describe('Test Suite', function() {
    it('Test', function () {
    })
})

And the server has a fs.readFileSync.

Just looked into this. The issue appears to be that test discovery is running in a different path than expected (try running the file from a different directory, and you'll see what I mean).
In general, it's best to do something like path.join(__dirname, filename) instead of just the filename to make sure that your working directory is what you're expecting it to be.
Anyways, the fix I'll commit soon will mitigate the confusion by setting the process directory to the project folder, and also print out the working path in the beginning so that it's easier to debug similar issues in the future.


[DNM]coverage test 2

What problem does this PR solve?
Issue Number: ref #5599
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-unit-test


[BUG] - connect-pnponline with -accessToken and -url, doesn't create context(current connection holds no SharePoint context)

Reporting an Issue
I am trying to run the command Connect-PnPOnline -Url $siteUrl -AccessToken $accessToken in Powershell and function App both with a valid access token but when I call any SharePoint pnp command after the connection I keep getting the Issue:  The current connection holds no SharePoint context. Please use one of the Connect-PnPOnline commands which uses the -Url argument to connect.
Expected behavior
As the command Connect-PnPOnline is called with valid URl and accesstoken I should be able to call any Get-PnP* commands for the site successfully.
Actual behavior
Any sharepoint PnP commands for the site (Url used in the Connect-PnPOnline ) fails with the Issue The current connection holds no SharePoint context. Please use one of the Connect-PnPOnline commands which uses the -Url argument to connect.
Steps to reproduce behavior

Getting the AccessToken in the function app using the code below :
$ClientApplicationBuilder = [Microsoft.Identity.Client.PublicClientApplicationBuilder]::Create($clientId)
[void]$ClientApplicationBuilder.WithAuthority($authority)
[void]$ClientApplicationBuilder.WithRedirectUri($redirectUri)
$appBuilder = $ClientApplicationBuilder.Build()
 [Microsoft.Identity.Client.AuthenticationResult] $authenticationResult  = $null
 $SecurePassword = $(ConvertTo-Securestring $Password -asplaintext -force)
 $AquireTokenParameters = $appBuilder.AcquireTokenByUsernamePassword($scopes, $username, $securePassword)
 $authenticationResult = $AquireTokenParameters.ExecuteAsync().GetAwaiter().GetResult()
 $accessToken = $authenticationResult.AccessToken

2.Executing Connect-PnPOnline -Url $siteUrl -AccessToken $accessToken and then calling any Get-PnP* command for the site
like $site = Get-PnPSite -Includes RootWeb
What is the version of the Cmdlet module you are running?
I have tried with versions 0.1.25, 0.1.30 and latest one 0.2.2 but getting the same Issue.

cc: @patrick-rodgers if you have any suggestions on who we can tag on this?  thanks!

Hi, thank you for reporting this. We'll have a look in this specific case. We noticed that you're using MSAL to acquire an access token, which is the same we're using internally in PnP PowerShell. For that reason we made a small change that will allow you to authenticate like this:
Connect-PnPOnline -Url https://yourtenant.sharepoint.com -Credentials (Get-Credential) -ClientId <yourclientid>

Nevertheless we will check out where it goes wrong with the -AccessToken parameter.

We fixed this in the upcoming nightly build, version 0.2.17. Please install this version when available tomorrw and please try again. I will close this issue now but do not hesitate to create a new one if required.

@erwinvanhunen - Thanks for looking into the Issue. It works fine now.

Hi @erwinvanhunen I don't know if this is the right place, but by googling I landed on this site. I am using SharePointPnPPowerShellOnline version 3.29.2101, and I log in with token. But when I try to run the Get-PnPSubWebs command I get the same error as @syedmdanish
Could you help me ?


Crash on format field

format doesn't seem to be supported (spec says it can even be an arbitrary string):
(node:11785) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: unknown format "int64" is used in schema at path "#/properties/path/properties/customerId"

or
(node:12123) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: unknown format "password" is used in schema at path "#/properties/requestBody/allOf/1/properties/password"

Hi! Probably a good idea to ignore unknown formats by default. Right now we are using default Ajv behaviour.
https://ajv.js.org/#formats
Let's add unknownFormats: 'ignore' to our default AjvOpts

The default behaviour for validation is now to emit a warning when an unknown format is encountered in JSON schema. If you wish to get rid of the warning, you can pass ajvOpts.unknownFormats an array with allowed custom formats.
const api = new OpenAPIBackend({
  definition,
  ajvOpts: { unknownFormats: ['myCustomFormat'] },
});

Damn, that was fast :smiley:.


Initial draft of nftables support

This implementation lacks isolation support at present (that'll be a followon PR) and has only very minimal testing at the moment (including absolutely 0 testing for IPv6), but does handle all core tasks including forwarding and all types of port forwarding.
Fixes #816

Stripping WIP. Passes testing I've thrown at it. Now needs integration tests.

@Luap99 One last failing test, and it's a firewalld reload one. Any idea what might be going on?

Looks like you do not call into firewalld again to set the subnet trusted. (Do we even have to do that when using nftables?)
The VM is using f39 which has firewalld 2.0 which no longer flushes our custom fw rules by default, looking at your code you check that the nft rule exists then skip (continue) the subnet loop so the firewalld call is never done thus it is not trusted.
But because nftables - port forwarding ipv4 - tcp with firewalld reload passes I wonder if we even need to be trusted with nftables?

The firewalld folks said it was safer to do so. I'll move the firewalld make-trusted call to the top of the loop.

Alright, that should get tests passing. This is ready for review.

FYI CI is stucked likely due github outage.
Either way you can remove some of the clone() calls:
diff --git a/src/firewall/nft.rs b/src/firewall/nft.rs
index e362a0c..0b6e843 100644
--- a/src/firewall/nft.rs
+++ b/src/firewall/nft.rs
@@ -346,7 +346,7 @@ impl firewall::FirewallDriver for Nftables {
                         match statement {
                             stmt::Statement::Match(m) => match &m.right {
                                 expr::Expression::Named(expr::NamedExpression::Prefix(p)) => {
-                                    match *p.addr.clone() {
+                                    match p.addr.as_ref() {
                                         expr::Expression::String(s) => {
                                             if *s == subnet.addr().to_string() {
                                                 return true;
@@ -560,16 +560,16 @@ impl firewall::FirewallDriver for Nftables {
                                 _ => continue,
                             },
                             stmt::Statement::Jump(j) => {
-                                if let Some(v4) = dnat_chain_v4.clone() {
-                                    if j.target == v4 {
+                                if let Some(v4) = &dnat_chain_v4 {
+                                    if &j.target == v4 {
                                         if match_port {
                                             return true;
                                         }
                                         match_jump = true;
                                     }
                                 }
-                                if let Some(v6) = dnat_chain_v6.clone() {
-                                    if j.target == v6 {
+                                if let Some(v6) = &dnat_chain_v6 {
+                                    if &j.target == v6 {
                                         if match_port {
                                             return true;
                                         }
@@ -636,16 +636,16 @@ impl firewall::FirewallDriver for Nftables {
                     batch.delete(schema::NfListObject::Rule(rule));
                 }

-                if let Some(v4) = dnat_chain_v4.clone() {
+                if let Some(v4) = &dnat_chain_v4 {
                     for rule in
-                        get_matching_rules_in_chain(&existing_rules, &v4, match_all_ports_in_range)
+                        get_matching_rules_in_chain(&existing_rules, v4, match_all_ports_in_range)
                     {
                         batch.delete(schema::NfListObject::Rule(rule));
                     }
                 }
-                if let Some(v6) = dnat_chain_v6.clone() {
+                if let Some(v6) = &dnat_chain_v6 {
                     for rule in
-                        get_matching_rules_in_chain(&existing_rules, &v6, match_all_ports_in_range)
+                        get_matching_rules_in_chain(&existing_rules, v6, match_all_ports_in_range)
                     {
                         batch.delete(schema::NfListObject::Rule(rule));
                     }
@@ -941,7 +941,7 @@ fn get_dnat_rules_for_addr_family(
                 if let Some(stmt) = &daddr_cond {
                     localhost_jump_statements.push(stmt.clone());
                 }
-                localhost_jump_statements.push(dport_cond.clone());
+                localhost_jump_statements.push(dport_cond);
                 localhost_jump_statements.push(get_jump_action(MASKCHAIN));
                 rules.push(make_rule(&subnet_dnat_chain, localhost_jump_statements));
             }

Diff applied, TY

I noticed these errors in the journal when testing this on my host:
Jan 10 16:44:31 pholzing-fedora /usr/bin/podman[42596]: time="2024-01-10T16:44:31+01:00" level=info msg="netavark: [DEBUG netavark::firewall::firewalld] Removing firewalld rules for IPs <IP_ADDRESS>/16\n"
Jan 10 16:44:31 pholzing-fedora firewalld[2202]: ERROR: UNKNOWN_ERROR: rule ref count bug, missing ref count: rule_key '{"%%POLICY_SORT_KEY%%": [0, 1, "trusted", "<IP_ADDRESS>/16", "", 0, 1, "trusted", "<IP_ADDRESS>/16", "", 0, -1], "chain": "filter_FORWARD_POLICIES", "expr": [{"match": {"left": {"payload": {"field": "saddr", "protocol": "ip"}}, "op": "==", "right": {"prefix": {"addr": "<IP_ADDRESS>", "len": 16}}}}, {"match": {"left": {"payload": {"field": "daddr", "protocol": "ip"}}, "op": "==", "right": {"prefix": {"addr": "<IP_ADDRESS>", "len": 16}}}}, {"jump": {"target": "filter_FWD_policy_netavark_portfwd"}}], "family": "inet", "table": "firewalld"}'
Jan 10 16:44:31 pholzing-fedora firewalld[2202]: ERROR: COMMAND_FAILED: UNKNOWN_ERROR: rule ref count bug, missing ref count: rule_key '{"%%POLICY_SORT_KEY%%": [0, 1, "trusted", "<IP_ADDRESS>/16", "", 0, 1, "trusted", "<IP_ADDRESS>/16", "", 0, -1], "chain": "filter_FORWARD_POLICIES", "expr": [{"match": {"left": {"payload": {"field": "saddr", "protocol": "ip"}}, "op": "==", "right": {"prefix": {"addr": "<IP_ADDRESS>", "len": 16}}}}, {"match": {"left": {"payload": {"field": "daddr", "protocol": "ip"}}, "op": "==", "right": {"prefix": {"addr": "<IP_ADDRESS>", "len": 16}}}}, {"jump": {"target": "filter_FWD_policy_netavark_portfwd"}}], "family": "inet", "table": "firewalld"}'
Jan 10 16:44:31 pholzing-fedora /usr/bin/podman[42596]: time="2024-01-10T16:44:31+01:00" level=info msg="netavark: [WARN  netavark::firewall::firewalld] Error removing subnet <IP_ADDRESS>/16 from firewalld trusted zone: org.fedoraproject.FirewallD1.Exception: COMMAND_FAILED: UNKNOWN_ERROR: rule ref count bug, missing ref count: rule_key '{\"%%POLICY_SORT_KEY%%\": [0, 1, \"trusted\", \"<IP_ADDRESS>/16\", \"\", 0, 1, \"trusted\", \"<IP_ADDRESS>/16\", \"\", 0, -1], \"chain\": \"filter_FORWARD_POLICIES\", \"expr\": [{\"match\": {\"left\": {\"payload\": {\"field\": \"saddr\", \"protocol\": \"ip\"}}, \"op\": \"==\", \"right\": {\"prefix\": {\"addr\": \"<IP_ADDRESS>\", \"len\": 16}}}}, {\"match\": {\"left\": {\"payload\": {\"field\": \"daddr\", \"protocol\": \"ip\"}}, \"op\": \"==\", \"right\": {\"prefix\": {\"addr\": \"<IP_ADDRESS>\", \"len\": 16}}}}, {\"jump\": {\"target\": \"filter_FWD_policy_netavark_portfwd\"}}], \"family\": \"inet\", \"table\": \"firewalld\"}'\n"

I don't think they are related to this PR but I have to retest with the main/fedora version. Do you see this as well?

Nope. Don't see anything like that in journal (F38, fully updated, Podman from main, Netavark from my branch)

f39 ships with firewalld 2.0 and f38 with 1.X I think? So likely a firewalld change then. Anyway we can debug this if you get around to the firewalld stuff, doesn't seem related to this at all as I can reproduce using the fedora version with iptables.

One question though:
	chain NETAVARK-HOSTPORT-DNAT {
		tcp dport 80 jump nv_10_88_0_0_nm16_dnat
		tcp dport 81 jump nv_10_88_0_0_nm16_dnat
		tcp dport 82 jump nv_10_88_0_0_nm16_dnat
	}

	chain NETAVARK-HOSTPORT-SETMARK {
		meta mark set meta mark | 0x00002000
	}

	chain nv_10_88_0_0_nm16_dnat {
		ip saddr <IP_ADDRESS>/16 tcp dport 80 jump NETAVARK-HOSTPORT-SETMARK
		ip saddr <IP_ADDRESS> tcp dport 80 jump NETAVARK-HOSTPORT-SETMARK
		tcp dport 80 dnat ip to <IP_ADDRESS>:80
		ip saddr <IP_ADDRESS>/16 tcp dport 81 jump NETAVARK-HOSTPORT-SETMARK
		ip saddr <IP_ADDRESS> tcp dport 81 jump NETAVARK-HOSTPORT-SETMARK
		tcp dport 81 dnat ip to <IP_ADDRESS>:80
		ip saddr <IP_ADDRESS>/16 tcp dport 82 jump NETAVARK-HOSTPORT-SETMARK
		ip saddr <IP_ADDRESS> tcp dport 82 jump NETAVARK-HOSTPORT-SETMARK
		tcp dport 82 dnat ip to <IP_ADDRESS>:80
	}

What is the point of the dport match in NETAVARK-HOSTPORT-DNAT? The ..._dnat chain has to match the dport again anyway so just a direct jump should be easier?

Comments addressed (added network ID to subnet chain names). Should be ready for merge.
I'm on the firewalld stuff now, so clearly I need to do a dist-upgrade to f39 and see how badly we're broken (and what fixing it will mean - I really don't want to have to conventionalize on firewalld version)

I think that jump is mostly to prevent the NETAVARK-HOSTPORT-DNAT chain small. We could eliminate the nv_10_88_0_0_nm16_dnat chain entirely and stuff everything into NETAVARK-HOSTPORT-DNAT but that would get long and messy (especially if one container decides to do something like a 1000-port range forward). And so long as we have per-network DNAT chains, might as well only jump to them if we actually have to.

Ok I assumed a port range would actually only result is one rule not in one per port but seems like such feature (https://bugzilla.netfilter.org/show_bug.cgi?id=1501) is not yet implement or very new, not sure what the status is (finding out if patches on ML are merged is always such a chore)

If it is merged, it's not in the JSON schema yet, so we can't make use of it. It's unfortunate because it's the only place ranges don't work.
RE: Firewalld - The release notes say 2.0 has no breaking changes. I'm looking deeper.

/hold cancel


Adding Synthetic Step to Synthetic Package

r: @lgajowy
I am currently relying on the same workaround as you are for your PR. We need to figure out how hashFunction is meant to be used properly...

@pabloem fyi, I've spent some time on this PR but still need to check some things. Please expect the review the next day.

@pabloem https://github.com/apache/beam/pull/6083 this PR fixes the problem with hashFunction we talked about.

I haven't addressed your comments as of now. I am trying to get tests to pass, and then I'll address your comments. Thanks!

Retest this please

Sorry for the long delay. I've addressed most low-hanging fruit comments. I'll do another round a bit later.

I've addressed the comments, except for adding the extra tests, which I'd like to add as a second PR if you'd be okay with that.

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit

The test run for this is here: https://builds.apache.org/job/beam_PreCommit_Java_Phrase/276/

Cool! Thanks Pablo!


HER MPI broadcasting issue with non-Reach environments

The following command runs fine:
time mpirun -np 8 python -m baselines.run --num_env=2 --alg=her --env=FetchReach-v1 --num_timesteps=100000

However, if I try changing the environment to the FetchPush-v1 or FetchPickAndPlace-v1, I get the following error:
When trying to run multiple MPI threads
Training...
Traceback (most recent call last):
  File "/home/vitchyr/anaconda2/envs/baselines2/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/vitchyr/anaconda2/envs/baselines2/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/vitchyr/git/baselines/baselines/run.py", line 246, in <module>
    main(sys.argv)
  File "/home/vitchyr/git/baselines/baselines/run.py", line 210, in main
    model, env = train(args, extra_args)
  File "/home/vitchyr/git/baselines/baselines/run.py", line 79, in train
    **alg_kwargs
  File "/home/vitchyr/git/baselines/baselines/her/her.py", line 181, in learn
    policy_save_interval=policy_save_interval, demo_file=demo_file)
  File "/home/vitchyr/git/baselines/baselines/her/her.py", line 59, in train
    logger.record_tabular(key, mpi_average(val))
  File "/home/vitchyr/git/baselines/baselines/her/her.py", line 20, in mpi_average
    return mpi_moments(np.array(value))[0]
  File "/home/vitchyr/git/baselines/baselines/common/mpi_moments.py", line 22, in mpi_moments
    mean, count = mpi_mean(x, axis=axis, comm=comm, keepdims=True)
  File "/home/vitchyr/git/baselines/baselines/common/mpi_moments.py", line 16, in mpi_mean
    comm.Allreduce(localsum, globalsum, op=MPI.SUM)
  File "mpi4py/MPI/Comm.pyx", line 714, in mpi4py.MPI.Comm.Allreduce

These different environments work for me if I run them without MPI.
I am using anaconda. My Python version is 3.6.2 and this is the output of pip freeze:
absl-py==0.7.0
astor==0.7.1
baselines==0.1.5
certifi==2018.11.29
cffi==1.12.2
chardet==3.0.4
Click==7.0
cloudpickle==0.8.0
Cython==0.29.6
dill==0.2.9
future==0.17.1
gast==0.2.2
glfw==1.7.1
grpcio==1.19.0
gym==0.12.0
h5py==2.9.0
idna==2.8
imageio==2.5.0
joblib==0.13.2
Keras-Applications==1.0.7
Keras-Preprocessing==1.0.9
lockfile==0.12.2
Markdown==3.0.1
mock==2.0.0
mpi4py==3.0.1
mujoco-py==<IP_ADDRESS>
numpy==1.16.2
opencv-python==<IP_ADDRESS>
pbr==5.1.3
Pillow==5.4.1
progressbar2==3.39.2
protobuf==3.7.0
pycparser==2.19
pyglet==1.3.2
python-utils==2.3.0
requests==2.21.0
scipy==1.2.1
six==1.12.0
tensorboard==1.13.0
tensorflow==1.13.1
tensorflow-estimator==1.13.0
termcolor==1.1.0
tqdm==4.31.1
urllib3==1.24.1
Werkzeug==0.14.1

Hi, I have the same problem, have you sovled this?

I run into this error as well.

Same here

I've temporarily fixed the issue in my custom environment by having the success rate over 100 rather than 1 (ie. multiplying the success rate by 100 in rollout.py). The issue lies somewhere in mpi_moments.py when calculating the meansqdiff with non-zero success rate with multiple cpus. Hope this is useful.

It seems like an issue related to x.dtype. Probably workers are for some reason generated a different x.dtype and MPI is not able to reconcile them. A workaround is to force the dtype of localsum in line 12 to be np.float64. The right fix would be figure out why different dtypes.

The above work around works for me thanks

time mpirun -np 8  meams  num-cpu=8? and  if i want use mpi,the command  "mpirun "must be added ？

time mpirun -np 8 meams num-cpu=8? and if i want use mpi,the command "mpirun "must be added ？

Yes, that's how it works. Check out the mpi documentation about mpirun, but you need to add it to use mpi.


Restrict access to adapter configurations by organisation

Currently all organisations can use all available adapter configurations. There should be a restriction in place that limits the set of available configurations for a specific organisation.
This is something that should be configurable by admins.

Solution:

restrict set of usable adapters of an organisation
there should also be a set of default adapters, that can automatically be used in all organisations

Add new tables
CREATE TABLE organisation_adapter (
  organisation_id integer,
  adapter_id text,
  md5_hash text NOT NULL, -- MD5 hash of the whole configuration file to check if changes have been made
  created_at timestamp,
  created_by integer REFERENCES user_table (user_id) ON UPDATE CASCADE ON DELETE SET NULL,
  PRIMARY KEY(organisation_id, adapter_id)
);

CREATE TABLE default_adapter (
  adapter_id text PRIMARY KEY,
  md5_hash text NOT NULL,
  created_at timestamp,
  created_by integer REFERENCES user_table (user_id) ON UPDATE CASCADE ON DELETE SET NULL
);

Admins should be able to add adapters by their ID to the set of available adapters for a specific organisation or to the set of default adapters available to all organisations.

When an adapter is removed, respective DB entries will become orphans.
Updating an adapter results in a new MD5 hash, which makes the adapter unusable if DB entries are not updated as well.

add TOP API endpoints that are only available to admins for:

[ ] add default adapter
[ ] get list of default adapters
[ ] remove default adapter
[ ] accept MD5 hash difference in default adapter and update to new MD5 hash
[ ] add adapter to a specific organisation
[ ] get list of available adapters of an organisation
[ ] remove adapter from organisation
[ ] accept MD5 hash difference in organisation adapter and update to new MD5 hash

[ ] implement storage of adapter mappings in DB
[ ] add components to modify adapter mappings to the frontend

Drop MD5 hash restrictions, because they make handling adapters too complicated.

Postponing the implementation of default adapters. Not sure whether we need them.
I am going to push the current state to the main branch.


Fix TypeError when closing rendering

Fixes #438
Description
Fixes TypeError exception that can appear when finishing with an environment that was rendered.
Fixes #438
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

LGTM, from my testing it does fix the issue, and does not appear to break anything here or in Gymansium-Robotics


Extract type from Rails enums

Description 📖
This adds support for enums in Rails. Defined enums will be converted to a union type with its allowed values.
Background 📜
Rails enums are currently converted to "any" types. In our own app we've been adding manual types with something like this:
class SongSerializer < BaseSerializer
  attributes(
    :id,
    :title,
    genre: { type: "'pop'|'rock'|'classical'" },
  )
end

This PR aims to make it automatic.
The Fix 🔨
This extracts the possible values for the enum and adds them as a type:
class Song < ApplicationRecord
  belongs_to :composer
  has_many :video_clips

+  enum genre: { disco: "disco", rock: "rock", classical: "classical" }
+  enum tempo: %w[slow medium fast]
end

export default interface Song {
  id: number
  composer: Composer
+  genre: "disco" | "rock" | "classical"
+  tempo: "slow" | "medium" | "fast"
  title?: string
}

I've added a test for the integer-enum as well as string-enum.
The added code in the generator is mildly atrocious - perhaps we can pass in the model here? Feedback welcome.

Any idea when this could be merged?

This would be an awesome addition to the library 👍

This is a nice addition, thanks @tijmenb!


Applying this tutorial to other regions and modified otp.jar

Hello Marcus,
First of all thank you for this tutorial !
I'd like to apply this technique on other places of the globe and I'm wondering about the impact of your modified otp.jar (In the pdf you say "This has been compiled (...) that includes a UK Way Property Set".
Apart from the OSM and GTFS data for the region I want to apply this technique to, do I need to do something similar for this additional data that you compiled directly in otp ?
Best,
Alexandre

@alexandrebarsacq The way property set is specified during graph build within build-config.json. There are three available (UK, Norway, and default (California-based). See the documentation here:
https://github.com/opentripplanner/OpenTripPlanner/blob/dev-1.x/docs/Configuration.md
You can see the settings used by the way property sets in the relevant files located here:
https://github.com/opentripplanner/OpenTripPlanner/tree/dev-1.x/src/main/java/org/opentripplanner/graph_builder/module/osm
If none of these are suitable, you'll need to create a modified one, and you'll need to build OTP from source to use it.
Hope that helps.

It helps a lot, thank you for your fast response !


Bot restarting when losing connection

So I don't know if it an issue, but I am going to monitor it. On staging the bot will disconnect and I think it will get throttled by Discord and it will then restart due to a time-out. I will keep an eye out for this and post logs whenever it happens.
09:49 13-11-2018
[8:48:19 AM] [EVENT] (Commands Antispam) releaseUser
[8:48:25 AM] [EVENT] (Performance) execute
[8:48:55 AM] [EVENT] (Performance) execute
[8:49:17 AM] [EVENT] (Commands Antispam) releaseCommand
[8:49:17 AM] [EVENT] (admin.js) fiveMinCheck
[8:49:17 AM] [INFO] (Mention Antispam) No roles were found in muteRole.members
[8:49:17 AM] [EVENT] (Command Channel Antispam) commandChannel release timer
[8:49:19 AM] [EVENT] (discordbot) reconnecting
[8:49:19 AM] [STATUS] (bot-events) Client disconected, attempting reconnection...
[8:49:19 AM] [WARNING] (bot-events) Bot got disconnected from Discord, reconnecting...
[8:49:19 AM] [DEBUG] (server) Wiped guild: "DigBot-staging"
[8:49:19 AM] [DEBUG] (discordbot) Restart clock started
[8:49:25 AM] [EVENT] (Performance) execute
[8:49:25 AM] [EVENT] (discordbot) message
[8:49:55 AM] [EVENT] (Performance) execute
[8:50:19 AM] [EVENT] (Commands Antispam) releaseUser
[8:50:19 AM] [EVENT] (discordbot) restart
[8:50:19 AM] [WARNING] (discordbot) Restarting bot due to connection timeout
[8:50:19 AM] [WARNING] (discordbot) Bot connection handling failed, destroying bot, re-attempting connection...
[8:50:19 AM] [EVENT] (discordbot) restart bot.destroy
[8:50:19 AM] [EVENT] (discordbot) restart bot destroyed
[8:50:19 AM] [DEBUG] (Bot succesfully destroyed, restarting) undefined
[8:50:19 AM] [EVENT] (discordbot) initBot
[8:50:19 AM] [DEBUG] (discordbot) Start clock started
[8:50:19 AM] [INFO] (discordbot) DIGBot, starting up.
[8:50:20 AM] [EVENT] (discordbot) disconnect
[8:50:20 AM] [DEBUG] (discordbot) Restart clock wiped
[8:50:20 AM] [STATUS] (bot-events) Client disconected
[8:50:20 AM] [INFO] (server) Server was marked as unready!
[8:50:20 AM] [DEBUG] (discordbot) Restart clock started
[8:50:20 AM] [EVENT] (discordbot) ready
[8:50:20 AM] [DEBUG] (discordbot) Restart clock wiped
[8:50:20 AM] [STATUS] (bot-events) Client succesfully reconnected
[8:50:20 AM] [INFO] (server) Updated server: DigBot-staging
[8:50:20 AM] [INFO] (server) Set connection time
[8:50:20 AM] [INFO] (server) Server was marked as ready!
[8:50:20 AM] [EVENT] (server) setMembersOnServer
[8:50:20 AM] [EVENT] (server) setMembersPlaying
[8:50:20 AM] [INFO] (server) Detected members playing change. New count: 0
[8:50:20 AM] [INFO] (bot-events) DIGBot, Online.
[8:50:20 AM] [DEBUG] (discordbot) Start clock wiped
[8:50:20 AM] [EVENT] (discordbot) login
[8:50:25 AM] [EVENT] (Performance) execute
[8:50:55 AM] [EVENT] (Performance) execute
[8:51:25 AM] [EVENT] (Performance) execute

If you check the warning logs on live discord you'll see it happens a lot with our current bot too so it's not a new thing. I don't think we're being rate limited as we are nowhere near limits so I'm not really sure what we can do about this other than maybe handle it a bit more gracefully.
Unfortunately, it's obviously hard to repro on demand so it's hard to build better systems for it

Maybe, I am not sure, but having the bot restart 3 times in less then 24 hours after an update got my attention. That is why I will post the logs, then we can eventually zero-in on the problem if there is any.

15-11-2018
[9:53:09 AM] [EVENT] (Performance) execute
[9:53:39 AM] [EVENT] (Performance) execute
[9:54:09 AM] [EVENT] (Performance) execute
[9:54:39 AM] [EVENT] (Performance) execute
[9:54:47 AM] [EVENT] (discordbot) reconnecting
[9:54:47 AM] [STATUS] (bot-events) Client disconected, attempting reconnection...
[9:54:47 AM] [WARNING] (bot-events) Bot got disconnected from Discord, reconnecting...
[9:54:47 AM] [DEBUG] (server) Wiped guild: "DigBot-staging"
[9:54:47 AM] [DEBUG] (discordbot) Restart clock started
[9:54:53 AM] [EVENT] (discordbot) message
[9:55:08 AM] [EVENT] (admin.js) autodelete check
[9:55:08 AM] [WARNING] (server) Guild "503229946898939922" doesn't exist!
[9:55:08 AM] [EVENT] (Commands Antispam) releaseCommand
[9:55:08 AM] [EVENT] (admin.js) fiveMinCheck
[9:55:08 AM] [WARNING] (server) Guild "503229946898939922" doesn't exist!
/usr/src/digbot/src/lib/server/server.js:137
        if (this.getGuild(guild).roles.array().length === 0) {
                                ^

TypeError: Cannot read property 'roles' of null
    at Object.getRoles (/usr/src/digbot/src/lib/server/server.js:137:33)
    at Object.getRole (/usr/src/digbot/src/lib/server/server.js:127:19)
    at Object.release (/usr/src/digbot/src/lib/admin/antispam/mentionspam.js:163:31)
    at Timeout.fiveMinCheck [as _onTimeout] (/usr/src/digbot/src/lib/admin/admin.js:118:17)
    at ontimeout (timers.js:436:11)
    at tryOnTimeout (timers.js:300:5)
    at listOnTimeout (timers.js:263:5)
    at Timer.processTimers (timers.js:223:10)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `node src/bot.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-11-15T09_55_08_285Z-debug.log

><EMAIL_ADDRESS>start /usr/src/digbot
> node src/bot.js

[9:55:10 AM] [EVENT] (discordbot) initBot
[9:55:10 AM] [INFO] (discordbot) DIGBot, starting up.
[9:55:11 AM] [EVENT] (discordbot) ready
[9:55:11 AM] [INFO] (bot-events) DIGBot, Online.
[9:55:11 AM] [INFO] (server) Set connection time
[9:55:11 AM] [INFO] (server) Channel digbot-log was set
[9:55:11 AM] [INFO] (server) Channel digbot was set
[9:55:11 AM] [INFO] (server) Channel developers was set
[9:55:11 AM] [INFO] (server) Channel staff was set
[9:55:11 AM] [INFO] (server) Channel general was set
[9:55:11 AM] [INFO] (server) Channel events was set
[9:55:11 AM] [INFO] (server) Channel streams was set
[9:55:11 AM] [INFO] (server) Channel ps2dig was set
[9:55:11 AM] [INFO] (server) Channel 💬 Chit Chat was set
[9:55:11 AM] [INFO] (server) Channel herebedragons was set
[9:55:11 AM] [DEBUG] (bot-events) Succesfully sent message
503229946898939922
[9:55:11 AM] [INFO] (server) Updated server: DigBot-staging
[9:55:11 AM] [EVENT] (server) setMembersOnServer
[9:55:11 AM] [EVENT] (server) setMembersPlaying
[9:55:11 AM] [INFO] (server) Detected members playing change. New count: 0
[9:55:11 AM] [INFO] (bot-events) Server member count: 7
[9:55:11 AM] [EVENT] (subBots) ready
[9:55:11 AM] [INFO] (server) Server was marked as ready!
[9:55:11 AM] [INFO] (server) Server boot marked as complete!
(node:16) DeprecationWarning: TextChannel#sendMessage: use TextChannel#send instead
[9:55:11 AM] [DEBUG] (discordbot) Start clock wiped
[9:55:11 AM] [EVENT] (discordbot) login
[9:55:11 AM] [EVENT] (discordbot) message
[9:55:13 AM] [EVENT] (admin.js) startchecks
[9:55:13 AM] [EVENT] (Channels Master) checkPositions
[9:55:13 AM] [EVENT] (Channel Positions) globalCheck
[9:55:20 AM] [DEBUG] (subBots) Sub bot succesfully sent message

23-11-2018
[5:43:37 PM] [INFO] (server) Stored server: DigBot-staging
[5:43:37 PM] [EVENT] (server) setMembersPlaying
[5:43:37 PM] [INFO] (server) Detected members playing change. New count: 1
[5:43:53 PM] [EVENT] (Commands Antispam) releaseUser
[5:43:53 PM] [EVENT] (Performance) execute
[5:44:23 PM] [EVENT] (Performance) execute
[5:44:50 PM] [EVENT] (discordbot) presenceUpdate
[5:44:50 PM] [INFO] (server) Stored server: DigBot-staging
[5:44:50 PM] [EVENT] (server) setMembersPlaying
[5:44:50 PM] [INFO] (server) Detected members playing change. New count: 1
[5:44:53 PM] [EVENT] (Commands Antispam) releaseCommand
[5:44:53 PM] [EVENT] (admin.js) fiveMinCheck
/usr/src/digbot/src/lib/admin/events.js:46
            logger.warning(TAG, `Was unable to get role ${eventObject.roles[i]} for event ${eventObj.name}`);
                                                          ^

ReferenceError: eventObject is not defined
    at alert (/usr/src/digbot/src/lib/admin/events.js:46:59)
    at preHourCheck (/usr/src/digbot/src/lib/admin/events.js:170:13)
    at Object.check (/usr/src/digbot/src/lib/admin/events.js:25:21)
    at Timeout.fiveMinCheck [as _onTimeout] (/usr/src/digbot/src/lib/admin/admin.js:116:12)
    at ontimeout (timers.js:436:11)
    at tryOnTimeout (timers.js:300:5)
    at listOnTimeout (timers.js:263:5)
    at Timer.processTimers (timers.js:223:10)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `node src/bot.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-11-23T17_44_53_653Z-debug.log

><EMAIL_ADDRESS>start /usr/src/digbot
> node src/bot.js

[5:44:55 PM] [EVENT] (discordbot) initBot
[5:44:55 PM] [INFO] (discordbot) DIGBot, starting up.
[5:44:55 PM] [EVENT] (discordbot) ready
[5:44:55 PM] [INFO] (bot-events) DIGBot, Online.

On my developer bot I added more information to the log that logs disconnect events. After looking in to it is a normal disconnect with code 1000 and has something to do with cloudflare. There is a fix maybe, but I need to test it first. Stay tuned.


[#5411] cleanup

Codecov Report

Merging #5540 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5540      +/-   ##
==========================================
+ Coverage   40.78%   40.79%   +0.01%
==========================================
  Files        2822     2822
  Lines       84902    84907       +5
  Branches    11314    11315       +1
==========================================
+ Hits        34625    34636      +11
+ Misses      47257    47245      -12
- Partials     3020     3026       +6

Impacted Files
Coverage Δ

...rcorp/pinpoint/collector/service/TraceService.java
0% <0%> (ø)
:arrow_up:

...vercorp/pinpoint/rpc/packet/ServerClosePacket.java
52% <0%> (-16%)
:arrow_down:

...pc/server/LoggingServerMessageListenerFactory.java
90% <0%> (-10%)
:arrow_down:

...rp/pinpoint/rpc/server/PinpointServerAcceptor.java
84.82% <0%> (-4.83%)
:arrow_down:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
66.66% <0%> (-3.34%)
:arrow_down:

...ofiler/sender/StandbySpanStreamDataSendWorker.java
80.59% <0%> (-2.99%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
72.87% <0%> (+0.32%)
:arrow_up:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
80.28% <0%> (+1.05%)
:arrow_up:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
59.57% <0%> (+2.12%)
:arrow_up:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
85.36% <0%> (+2.43%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b48c22...831967b. Read the comment docs.


Add convenience overload AmbientTasks.Add(Func)

This comes up just about all the time. Instead of pushing you towards a local function or a method, a lambda should just be an option so that you don't have to come up with a name:
From the current readme:
private void SomeEventHandler(object sender, EventArgs e)
{
    // Update UI

    AmbientTasks.Add(UpdateInfoAsync());

    async Task UpdateInfoAsync()
    {
        var info = await GetInfoAsync(...);

        // Update UI using info
    }
}

This would be nicer as:
private void SomeEventHandler(object sender, EventArgs e)
{
    // Update UI

    AmbientTasks.Add(() =>
    {
        var info = await GetInfoAsync(...);

        // Update UI using info
    });
}

I wasn't sure at first, but my own usage and examples like in #2 have convinced me.

Implemented in 8c84311b3380e07aae50be796b4ed9b8f3aae7f3


feat: handle display name and namespace

Types of changes

[ ] Hot fix (emergency fix and release)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Documentation (change which affects the documentation site)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Release (develop -> main)

Quality assurance (all should be covered).

[x] My code follows the code style of this project.
[ ] Documentation for my change is up to date?
[x] My PR meets testing requirements.
[x] All new and existing tests passed.
[x] All commits are signed-off.

Summary
Handle display name as a special property in the markdown header
Allow specifying its namespace value with new default-namespace parameter
This only applies to profile-generate and assemble
closes #1161
Key links:

Sonar coverage

Before you merge

Ensure it is a 'squash commit' if not a release.
Ensure CI is currently passing
Check sonar. If you are working for a fork a maintainer will reach out, if required.

There is a questionable behavior of default-namespace, when trying to overwrite it.
Scenario 1. Overwrite existing default-namespace in profile-generate and profile-assemble.
Start with profile with no ns in props (example current profile in test-profiles repo)

Run author profile-generate --output md_profiles/SOMEPROFILE --name SOMEPROFILE -ns "https://some_ns"

Observe that markdowns generated with default-namespace:https://some_ns - Good

Run author profile-assemble --markdown md_profiles/SOMEPROFILE --output SOMEPROFILE --set-parameters -ns "https://some_ns"

Observe that Json has ns:https://some_ns added to props - Good

Now we want to change default-namespace, run author profile-generate --output md_profiles/SOMEPROFILE --name SOMEPROFILE -ns "https://ovewriten_ns"

Expected: default-namespace: https://some_ns/ is changed to default-namespace: https://ovewriten_ns/ in all markdowns
Observed: No changes to mds, i.e. default-namespace: https://some_ns/ stayed

Continue with this profile.
4. Run author profile-assemble --markdown md_profiles/SOMEPROFILE --output SOMEPROFILE --set-parameters -ns "https://ovewriten_ns"
Expected: ns in props changed to “https://overwriten_ns/”
Observed: No changes to JSON
Now no changes to markdown default-namespace in steps 3 seems like a bug to me. Step 4 behaviour is also seems odd.

Also there is a possible artifact that I noticed. Profile-generate will add x-trestle-set-params for params that are not in set-parameters in Json profile. Maybe it has something to do with the fact that set-params in Json start with prm_2 rather than prm_1.
Example Json:
"set-parameters": [
        {
          "param-id": "ac-1_prm_2",
          "props": [
            {
              "name": "display-name",
              "ns": "https://default_namespace",
              "value": "AC-1 (b) (1)"
            }
          ],
          "values": [
            "at least annually"
          ]
        },
        {
          "param-id": "ac-1_prm_3",
          "props": [
            {
              "name": "display-name",
              "ns": "http://some_url",
              "value": "AC-1 (b) (2)"
            }
          ],
          "values": [
            "at least annually"
          ]
        },

Markdown AC-1 will have three set-parameters
x-trestle-set-params:
  ac-1_prm_1: <-- Where did this came from?
    label: organization-defined personnel or roles
  ac-1_prm_2:
    profile-values: at least annually
    values:
    display-name: AC-1 (b) (1)
  ac-1_prm_3:
    profile-values: at least annually
    values:
    display-name: AC-1 (b) (2)
    ns: http://some_url

Doing any changes to this "ghost" set-param in markdown will not change anything in Json

Thanks for doing these sanity checks - and those are all good questions.  I need to write documentation for it, in which case I hope it makes sense.
The intent is to allow specifying ns for things that don't have ns defined in the header.  Anything else will get that ns - and if something in the header has ns that matches the default - it will not be shown - to avoid cluttering the header.
The issue with ns not changing on second generate is that generating on top of existing contents is intended only to add in some sense - and that needs to be figured out better.  Any prose found in the md will not be altered by generate - only new sections will be added.  It's not clear why the second generate is happening and what we want it to do, but we want to avoid overwriting edits made to the markdown.  The user could have edited the value in the yaml header and it would have been changed by the generate operation.  I think we should do a high level review of this stuff and how it relates to the relevant use cases - so this is less confusing.
The second issue is due to the header capturing everything known about set-parameters in the profile.  What is shown in the generated header is every parameter as it exists in the resolved catalog - along with changes that are made by the set-parameters of this profile.  ac-1_prm_1 only has a label in the original catalog and there is no set-parameter for it in the profile.  So that is what is shown, and at this point a user could change the label and/or add values - whatever.  Then, if assembly is done with set-parameters True, the new set-parameters should appear along with their changes.
This behavior evolved in the work with Doug and I think this is an ok way to do things.  The goal is to be empowered to make additions to the profile during assembly, but careful with existing markdown when doing generate.

Thanks for the detailed response, some further comments.

It's not clear why the second generate is happening and what we want it to do, but we want to avoid overwriting edits made to the markdown.

The intent here was to test a scenario if the user would like to change the default namespace. Say URL changed or something and now it needs to be updated. Since there is no way to change default namespace in the markdown (it is rightfully not printed), the only current way is to modify default-namespace in the header which will work but which user should not do. The cli option seems to be a second choice, but currently it will not overwrite things. The only other way is to delete md folder and regenerate from scratch. How we should go about it?

Then, if assembly is done with set-parameters True, the new set-parameters should appear along with their changes.

I think this is where I was confused about it, since if I change the label of ac-1_prm_1 from     label: organization-defined personnel or roles to label: organization-defined time period (or do any other changes to it, even deleting it entirely) and then assemble it using author profile-assemble --markdown md_profiles/SOMEPROFILE --output SOMEPROFILE --set-parameters it will not do anything to Json profile (i.e. it will not add set-param for ac-1_prm_1). Is this expected?

Thanks for the detailed response, some further comments.

It's not clear why the second generate is happening and what we want it to do, but we want to avoid overwriting edits made to the markdown.

The intent here was to test a scenario if the user would like to change the default namespace. Say URL changed or something and now it needs to be updated. Since there is no way to change default namespace in the markdown (it is rightfully not printed), the only current way is to modify default-namespace in the header which will work but which user should not do. The cli option seems to be a second choice, but currently it will not overwrite things. The only other way is to delete md folder and regenerate from scratch. How we should go about it?

Then, if assembly is done with set-parameters True, the new set-parameters should appear along with their changes.

I think this is where I was confused about it, since if I change the label of ac-1_prm_1 from  label: organization-defined personnel or roles to label: organization-defined time period (or do any other changes to it, even deleting it entirely) and then assemble it using author profile-assemble --markdown md_profiles/SOMEPROFILE --output SOMEPROFILE --set-parameters it will not do anything to Json profile (i.e. it will not add set-param for ac-1_prm_1). Is this expected?

I didn't express myself well for the first part.  I know why you did the second profile generate, but I don't know what the main use case need is for doing it a second time.  I believe the current approach is that it is able to add new guidance sections, but it cannot alter existing prose.  I need to clarify what is allowed to happen in the yaml header.  The yaml header may be overwritten by contents of a yaml header being handed in - but that is different from new set-parameters coming in.
For the second part, the documented behavior is only to change set-parameters on assemble if new values have been assigned.  I don't think there is a big need to change only a label value - but providing a value along with changing the label makese sense.
I will try to make a list of these ambiguities as I review the new documentation needs - and make changes for things that seem problematic.

Addressed the PR feedback per discussion.  default-namespace will now change in the header if requested on each profile-generate.  namespace for properties is handled more cleanly.  More tests added.


Tooltip marker fillColor array

When i put an array of colors in the tooltip marker fillColor, it only applies the first color in the array to everything.
I expect it to work the way legend marker fillColor works with array and use he array of colors passed.
I noticed this only happens when i add shared: true to tooltip
tooltip: {
    marker: {
       fillColors: [],
     },
}

Can you please create a codepen so I can easily reproduce it?

Fixed it. A new patch release 3.19.3 will be released with this fix.

I have the same issue. I am passing an array of colors and it always takes the first color.
I'm using - "apexcharts": "^3.32.1"


Fix scale_SVG

This function replaces the scale of the SVG with a given input. SVG file uses float numbers, but this function searched for integer numbers, which did not exist.

Wonder why it worked before. Hmm...anyway, examples work. thanks!


Terminal links + Preferences

Codecov Report

Merging #15 (c00124a) into master (8548165) will decrease coverage by 5.53%.
The diff coverage is 63.41%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   83.89%   78.36%   -5.54%
==========================================
  Files           5        5
  Lines         236      245       +9
==========================================
- Hits          198      192       -6
- Misses         38       53      +15

Impacted Files
Coverage Δ

src/JuliaCon.jl
87.50% <0.00%> (-12.50%)
:arrow_down:

src/preferences.jl
46.15% <46.15%> (ø)

src/schedule.jl
89.14% <100.00%> (-0.49%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8548165...c00124a. Read the comment docs.


SMTP Send Timeout

I'm experiencing SMTP send timeouts when postal tries to forward mail to a specific server.
[worker.4:3138] [2020-07-23T23:07:12.480] INFO -- : [RBHDZO3U] Cannot connect to ipv6-address:25 (redacted-domain.com) (Net::OpenTimeout: execution expired)
[worker.4:3138] [2020-07-23T23:07:42.483] INFO -- : [RBHDZO3U] Cannot connect to ipv4-address:25 (redacted-domain.com) (Net::OpenTimeout: execution expired)
[worker.4:3138] [2020-07-23T23:07:42.534] INFO -- : [RBHDZO3U] -> No SMTP server available for support.redacted-domain.com
[worker.4:3138] [2020-07-23T23:07:42.534] INFO -- : [RBHDZO3U] -> Hostnames: ["redacted-domain.com"]
[worker.4:3138] [2020-07-23T23:07:42.535] INFO -- : [RBHDZO3U] -> Errors: ["execution expired"]
[worker.4:3138] [2020-07-23T23:07:42.578] INFO -- : [RBHDZO3U] Finishing up

I'm able to connect via telnet to this specific server from the postal server:
root@vulture:~# telnet ipv4-address 25
Trying ipv4-address...
Connected to ipv4-address.
Escape character is '^]'.
220 redacted-domain.com ESMTP Hi, I'm a Mail-in-a-Box (Ubuntu/Postfix; see https://mailinabox.email/)
ehlo postal-redacted-domain.com
250-redacted-domain.com
250-PIPELINING
250-SIZE 134217728
250-VRFY
250-ETRN
250-STARTTLS
250-ENHANCEDSTATUSCODES
250-8BITMIME
250-DSN
250-SMTPUTF8
250 CHUNKING
quit
221 2.0.0 Bye
Connection closed by foreign host.

Postal is able to send and receive mail from eg. Gmail. And so is the server I'm trying to reach, that server also sends emails to postal that get processed correctly. Just connection from postal to that server timeouts. I don't even get any SMTP logs on the other side.
Are there any troubleshooting steps I can perform?

Any chance it was a temporary error? I think you can try re sending the message in the Postal UI.
Might also be worth asking your server provider to see if there is anything on their end that would prevent consistent connections on port 25.

I've re-tried delivery multiple times in the postal UI with the same results, both machines are on the same provider, I'll be contacting their support to be sure.

telnet is certainly correct, I'd wonder if there was some kind of firewall internal to the provider that would be doing something to break the connection or if your Postal needs a restart maybe

Is there a way to see from which IP is postal trying to send the message, or is there a way to force postal to use a specific address. I must add that I've enabled IP pools once, but since I've disabled them.

I get No SMTP servers were available for bmsd.ir. Tried bmsd.ir Could not resolve bmsd.irerror. is that related to this issue too?
It's worth noting the domain does resolve and have MX record set up as well. I have no idea why it does not send the email

I've talked with technical support on my provider and they narrowed down the issue to a /64 IPv6 prefix that was causing the issue, removed it from the config and now it's sending emails correctly.
That said, is there a way to specify which IP address postal uses for sending?

@hadifarnoud you should try using the dig command from the server to see if the DNS records are available to it, there might be a resolving error
@AndyTempel glad you figured it out, I believe it will use whatever the default IP address is like any other program that connects to the internet unless you're using the IP Pools feature


feat: add enter event

Hello, @ziontee113.
I have added a custom user event when the minimap window opens. It will help us to run some advanced functions/tasks.
Thanks.

Hi @hasansujon786 thanks for the PR. I'd be amazing if you could explain / give some simple demos or use cases for the feature in README for users who's not aware of it? Thank you very much :+1:


Update xcopy-msbuild in arcade

Arcade-validation official is failing, requesting a new xcopy msbuild: https://dev.azure.com/dnceng/internal/_build/results?buildId=2581219&view=logs&j=b11b921d-8982-5bb3-754b-b114d42fd804&t=fb192a8b-e433-5fc8-e2b0-276ab015e7d5

##[error].packages\microsoft.dotnet.arcade.sdk\10.0.0-beta.24563.3\tools\SdkTasks\SigningValidation.proj(0,0): error : Could not resolve SDK "Microsoft.NET.Sdk". Exactly one of the probing messages below indicates why we could not resolve the SDK. Investigate and resolve that message to correctly specify the SDK.
Version 9.0.100 of the .NET SDK requires at least version 17.11.0 of MSBuild. The current available version of MSBuild is <IP_ADDRESS>03. Change the .NET SDK specified in global.json to an older version that requires the MSBuild version currently available.

Instructions here: https://dev.azure.com/dnceng/internal/_wiki/wikis/DNCEng Services Wiki/1074/Updating-Microsoft.DotNet.Arcade.MSBuild.Xcopy-WAS-RoslynTools.MSBuild-(xcopy-msbuild)-generation

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

I've uploaded a new version of the package, and I'm testing it in https://dev.azure.com/dnceng/internal/_build/results?buildId=2581359&view=results. If that is successful I'll prepare a PR to Arcade

Hitting some macos signing errors that seem unrelated as the xcopy msbuild is not used in those legs. I'll need to look at it if it repros on retry

No repro on retry. PR here: https://github.com/dotnet/arcade/pull/15248

Arcade flow is now unblocked: https://dev.azure.com/dnceng/internal/_build/results?buildId=2581568&view=results


docs: add CONTRIBUTING.md

Fixes #35

Awesome! Thanks for taking care of this. I haven't read the content yet. Just a minor suggestion: let's add a link to the guide to README.md to increase its visibility


Machavity: Watch promodo.com

Machavity requests the watch of the watch_keyword promodo\.com. See the MS search here and the Stack Exchange search here.

promodo\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Spam from https://stackoverflow.com/posts/55139280/revisions

Approved by Makyen in Charcoal HQ


Failed to lookup symbol (undefined symbol: TfLiteGpuDelegateV2Create)

When I try to run the model with GpuDelegate I receive this error:
Unhandled Exception: Invalid argument(s): Failed to lookup symbol (undefined symbol: TfLiteGpuDelegateV2Create).
I searched that on the internet and looks like it's a problem with the ffi.

@left-brain Can you please confirm if you are using binaries with delegate build, i,e. libtensorflowlite_c_arm64_delegate.so or libtensorflowlite_c_arm_delegate.so from here

No, I am not! Thanks for the help!! I’ll check it out :)

Closing this issue. Please feel free to reopen if you face any other problems.

how to check if you are using binaries with delegate build?


⚠ Processors has degraded performance

In fc25cd8, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 71 ms

Resolved: Processors performance has improved in 544681d.


add more persistent antennal lobe projection neurons [sf#35]

Reported by jefferis on 2014-06-27 20:47 UTC
http://www.virtualflybrain.org/site/tools/anatomy_finder/index.htm?id=FBbt:00007456&name=persistent antennal lobe projection neuron
is missing some persistent PNs
See Fig 4 of
See http://www.plosbiology.org/article/info%3Adoi%2F10.1371%2Fjournal.pbio.1000461

Commented by mmc46 on 2014-07-11 16:21 UTC
I've added the missing PNs, but they only be visible after the release on the 27th November.

Updated by mmc46 on 2014-07-11 16:21 UTC

status: open --> closed


[ie/asobichannel][ie/asobistage] remove

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

These two extractors should not be supported due to copyright issue.
Copyright claims are here
■権利帰属について
本サービス（それらに含まれる発明、考案、意匠、商標、標章、画像、映像、文章、プログラムその他の一切の情報等を含みます。）にかかる知的財産権その他の一切の権利は、当社または当社がその利用の許諾を得ている第三者に帰属します。

cc @Snack-X @pzhlkj6612
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[ ] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

The videos are neither DRM protected, and is not pirated content. So there's no reason for us to remove it


[#168643765] Fix SPID login for new users

This PR aims to fix a bug in SPID login for new users: an error on the user save is currently returned from the backend, this PR fix the code in order to avoid that error and to perform a redirect to the proper client page if any error still occurs. The error log was missing, it has also been added.

Affected stories

🐞 #168643765: Fix login con SPID

  Generated by :no_entry_sign: dangerJS against e642a92de2b77a4210d95f2cebe0373211501fbd


fix: configuration override order

ℹ Overview

moves initConfig to commands
better wildcard endpoint address handling
fallback to algod.net when all else fails
fix configuration load order
gracefully fail on invalid configuration

📝 Related Issues

resolves https://algorandfoundation.atlassian.net/browse/ENG-620
https://algorandfoundation.atlassian.net/browse/ENG-621

✅ Acceptance:

[X] Pre-commit checks pass

Confirmed that the order is correct (#1 --server,  #2 .algorun.yaml, #3 ALGORAND_DATA). But problem with providing <IP_ADDRESS>:8080 as url, as discussed on Slack.

LGTM


.bashrc-like file

Would be neat to have a file that could be included from a .bashrc (e.g. source ~/.bashrc-bash-bible). This could also be useful to reproducibility with test.sh

The "extract text between markers" function is what I used to create such a file.


New version: CCTV.CBox version <IP_ADDRESS>

I tried using komac to update the manifest, but I get the 403 return code:
Error:
   0: https://download.cntv.cn/cbox/v6/ysyy_v<IP_ADDRESS>_1001_setup_x64.exe returned 403 Forbidden

I also tried downloading the previous version using winget and it still returns 403:
执行此命令时发生意外错误：
Download request status is not success.
0x80190193 : 已禁止(403)。

I tried to download it manually from the official website and it downloaded successfully. Got the same link as in the manifest. But when I access the installer url directly from the manifest, I get the ERR_INVALID_RESPONSE error in Edge.
I'm not sure if I should remove all versions of this package or if this is only a problem in some areas?

Microsoft Reviewers: Open in CodeFlow

https://github.com/microsoft/winget-pkgs/pull/198735#issue-2737673311


Preview media types

Note: If one would need a bunch of different preview content types, then writing a
data MyPreviewTypes = A | B | C

data P (p :: MyPreviewTypes)

would work. It's a bit roundabout, but better than making GenRequest polykinded.


refactor(grammar): simplify grammatical categories

and introduce some renamings to make it sound more standard
Closes #341
Incidentally, it should fix #332, because we forbid constant and function declarations everywhere except for traits.

[x] I have updated CHANGELOG.md
[x] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
[x] I have run all the tests locally and no test failure was reported
[x] I did not do unrelated and/or undiscussed refactorings

Especially the Module = Import* ModuleItem*, which makes imports allowed only at the top-level right in the grammar.

The change just made this restriction explicit, because before this refactoring it was later done in the parseImports function, which can now be simplified. In a subsequent refactoring we'll most likely make imports a separate field in the module AST (this is out-of-scope for this PR)

And while we're at it, you may consider adding rule descriptions (in .ohm) to some of the rules, because they directly affect the syntax error messages produced by Ohm. Although adding them may complicate things a little, see: https://github.com/ohmjs/ohm/issues/302

Let's try to avoid "while-at-it" changes in the development process and create an issue that explains why this needs to be done and resolve it via a follow-up PR. This is especially important for refactoring PRs that need to be merged asap to not mess with other PRs that add new Tact features


feat: (replicator) Index channel metadata when a new channel is found

What is the feature you would like to implement?
Index channel metadata when a new channel is found
Why is this feature important?

Developers need to use manually updated solutions like this

Easier to read dashboards for channel data like this one

Will the protocol spec need to be updated??
No changes are needed to the protocol
How should this feature be built? (optional)
An example implementation of how Opencast is scanning for channel metadata
https://github.com/stephancill/opencast/blob/main/src/lib/topics/resolve-topic.ts
h/t @stephancill
For RPC providers, we could potentially use a list of RPC providers on this page for well-known chains. https://www.alchemy.com/chain-connect

Channels are not yet defined in any FIP. We should wait until their definition is formally specified in an FIP.
Or is this ticket suggesting any cast with a URL as a parent (rather than another cast) is automatically a channel? (but perhaps without an accompanying image, etc.)

Will include this as part of the FIP once channels are solidified from a product perspective.


Do checking of tW links from original Heb/Grk resources

Pull Request Test Coverage Report for Build 353

7 of 65 (10.77%)  changed or added relevant lines in 3 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.5%) to 56.463%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

webhook.py
0
3
0.0%

preprocessors/preprocessors.py
5
60
8.33%

Files with Coverage Reduction
New Missed Lines
%

preprocessors/preprocessors.py
3
41.22%

Totals

Change from base Build 351:
-0.5%

Covered Lines:
2988

Relevant Lines:
5292

💛  - Coveralls


Any way to Skip the Booting Screen?

Hello and TNX to UR FB Work!
A minute ago, I flashed a firmware made by this repo and it works fine (honestly, the best thing is the AM-FIX !) .But when I check the repo again, I did not find the option to skip the booting screen (which makes the UVK5 Boots waaaaaay more faster).
Since it is available on the other UVK5-FW-Patching project, I wonder if it will be available on this project too.
73
BA7MQN

Oh, I find the way.
Just turn to the 50th setting item (which named PONMSG) and change it to NONE. All problems are gone!
thank you again for your excellent work!


LookupTables will assert when closing Cycles

Asserts on this line:
https://github.com/boberfly/cycles/blob/master/src/render/tables.cpp#L34
Not sure why as I don't touch this part of Cycles...

Fixed in https://github.com/boberfly/GafferCycles/commit/9c49c4dcf39ab15c7bcb4dabecfe9513b63d85f5


decode MTA files!

I mean it's the same thing except for all the details that actually matter

Added release 0.3.39 with release notes, close this issue.

Added release 0.3.39 with release notes, close this issue.


dart2js -O1 breaks angular tests - then dead code fixes it O_o

I'm not sure if it is dart2js or angular_test related issue. Due to lack of better idea, I'm pretty much duplicating https://github.com/angulardart/angular/issues/1952 here too.
Basically what I have observed is that having a bit of specially prepared dead code influences the compilation/optimization process of dart2js in such a way that it makes things work. I expect my code to work without the dead code but it doesn't. Without further ado, repro code here
Repro steps:

grab a stagehand angular starter project
throw in the test and the build.yaml file from gist
pub run build_runner test -r -- -p chrome

-r command line argument is important. DDC works fine.
There are a number of things that must be present in order for this to happen:

Component should use AsyncPipe  on a special Stream
The implementation of that Stream must be "mockito-like" - overriding noSuchMethod
dart2js compiler must have -O1 or above optimization level

Until this point, component test fails, though I think it should pass. To fix it, there are 2 approaches:

add a bit of dead code like in the gist
use -O0 optimization level for dart2js

My expectation:
Both reachable tests pass without dead code
What happens:
Without dead code, the component test fails, though it shouldn't
Env

Dart SDK version: 2.10.4 (stable) (Wed Nov 11 13:35:58 2020 +0100) on "linux_x64"
Angular 5.3, 6

Uhm, so I'm wondering, is it an angular_test bug or did I stumble onto something compiler related?


Vert.x 4 web-site missing pages

A few pages are missing and lead to 404.
While we don't want to have these pages linked on the web-site, they should be still on the new web-site

https://vertx-web-site.github.io/download/
https://vertx-web-site.github.io/materials/
a few recents blog pages

assigned to you @michel-kraemer the page are done and should have only a few minor modification in the future (with Docker)

Closed in 881e1f2608f9e986fe8b648923cabf14567a9ebb


Ensure that markdown renderers in javascript and python match

Right now there are subtle differences between e.g. font sizes in preview vs production.

this appears to be fixed in the new style.