Treeview with clrRecursiveFor gives Error: Multiple components match node with tagname clr-tree-node in Angular 9

Describe the bug
Treeview with clrRecursiveFor gives "Error: Multiple components match node with tagname clr-tree-node" in Angular 9  Also shows "ERROR TypeError: Cannot read property 'context' of undefined"
How to reproduce
The "Recursive Tree" sample doc  from Clarity reproduces this error in Angular 9. Works in Angular 8
Steps to reproduce the behaviour:

      {{file.name}}

root = [
{
name: "src",
selected: ClrSelectedState.INDETERMINATE,
files: [
{
name: "app",
selected: ClrSelectedState.INDETERMINATE,
files: [
{
name: "app.component.html",
selected: ClrSelectedState.UNSELECTED
},
{
name: "app.component.ts",
selected: ClrSelectedState.UNSELECTED
},
{
name: "app.module.ts",
selected: ClrSelectedState.SELECTED
},
{
name: "app.routing.ts",
selected: ClrSelectedState.UNSELECTED
}
]
},
{
name: "environments",
selected: ClrSelectedState.SELECTED,
files: [
{
name: "environments.prod.ts",
selected: ClrSelectedState.SELECTED
},
{
name: "environment.ts",
selected: ClrSelectedState.SELECTED
}
]
},
{
name: "index.html",
selected: ClrSelectedState.UNSELECTED,
},
{
name: "main.ts",
selected: ClrSelectedState.UNSELECTED,
}
]
},
{
name: "package.json",
selected: ClrSelectedState.UNSELECTED
},
{
name: "tsconfig.json",
selected: ClrSelectedState.UNSELECTED
}
];
getChildren = (folder: any) => folder.files;
Expected behavior
A clear and concise description of what you expected to happen.
Should show a tree instead of crash
Versions
App

Angular: 9.0.1
Node: 12.16.0
Clarity:v2

Device:
Chrome

Type: MacPro
OS: Catalina
Browser chrome
Version [e.g. 22]

Additional notes
Add any other no

tes about the problem here.

@ygoron have you tested it with Clarity v3? https://clarity.design/news/3.0.0-next.8

No - I will give it a try.
Thanks,
Yuri

On Feb 19, 2020, at 11:59 AM, Shijir Tsogoo<EMAIL_ADDRESS>wrote:
@ygoron https://github.com/ygoron have you tested it with Clarity v3? https://clarity.design/news/3.0.0-next.8 https://clarity.design/news/3.0.0-next.8
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/vmware/clarity/issues/4282?email_source=notifications&email_token=AA6TXZPRUKG7WMZBDRX6I7TRDVQP7A5CNFSM4KV3INK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMISQ7I#issuecomment-588327037, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6TXZJH36XGWIKQHJX25FTRDVQP7ANCNFSM4KV3INKQ.

Clarity v2 and Angular 9 are not compatible because of changes in Angular and TypeScript. Please update as this issue was fixed in #4232 and is in the latest v3 release.
Closing as resolved, unless you have a specific demo of the issue persisting with Clarity 3 and Angular 9.


Fix for "cursor jumps beyond end of line when pressing $ and text is concealed #5214"

To fix the issue I propose this PR. It provides a test too. For mail readers' convenience, the patch is listed below.
Tom
diff --git a/src/move.c b/src/move.c
index d340f0223..9e9c90e10 100644
--- a/src/move.c
+++ b/src/move.c
@@ -1175,6 +1175,10 @@ curs_columns(
 	redraw_later(SOME_VALID);
 #endif

+    // Now w_leftcol corresponds to wrow, wcol and virtcol, no need
+    // to invalidate them just because of its change.
+    curwin->w_valid_leftcol = curwin->w_leftcol;
+
     curwin->w_valid |= VALID_WCOL|VALID_WROW|VALID_VIRTCOL;
 }

diff --git a/src/testdir/test_matchadd_conceal.vim b/src/testdir/test_matchadd_conceal.vim
index 83eadce5a..25bff3dea 100644
--- a/src/testdir/test_matchadd_conceal.vim
+++ b/src/testdir/test_matchadd_conceal.vim
@@ -316,3 +316,31 @@ func Test_cursor_column_in_concealed_line_after_window_scroll()
   call StopVimInTerminal(buf)
   call delete('Xcolesearch')
 endfunc
+
+func Test_cursor_column_in_concealed_line_after_leftcol_change()
+  CheckRunVimInTerminal
+
+  " Test for issue #5214 fix.
+  let lines =<< trim END
+    0put = 'ab' .. repeat('-', &columns) .. 'c'
+    call matchadd('Conceal', '-')
+    set nowrap ss=0 cole=3 cocu=n
+  END
+  call writefile(lines, 'Xcurs-columns')
+  let buf = RunVimInTerminal('-S Xcurs-columns', {})
+
+  " Go to the end of the line (3 columns beyond the end of the screen).
+  " Horizontal scroll would center the cursor in the screen line, but conceal
+  " makes it go to screen column 1.
+  call term_sendkeys(buf, "$")
+  call term_wait(buf)
+
+  " Are the concealed parts of the current line really hidden?
+  call assert_equal('c', term_getline(buf, '.'))
+
+  " BugFix check: Is the window's cursor column properly updated for conceal?
+  call assert_equal(1, term_getcursor(buf)[1])
+
+  call StopVimInTerminal(buf)
+  call delete('Xcurs-columns')
+endfunc

Codecov Report

Merging #5224 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5224      +/-   ##
==========================================
+ Coverage   82.04%   82.05%   +0.01%
==========================================
  Files         134      134
  Lines      147343   147344       +1
==========================================
+ Hits       120882   120900      +18
+ Misses      26461    26444      -17

Impacted Files
Coverage Δ

src/move.c
87.58% <100%> (+0.01%)
:arrow_up:

src/window.c
88.33% <0%> (+0.03%)
:arrow_up:

src/os_unix.c
63.5% <0%> (+0.04%)
:arrow_up:

src/gui.c
63.79% <0%> (+0.05%)
:arrow_up:

src/ui.c
71.4% <0%> (+1.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab85ca4...3695b32. Read the comment docs.


Revert "Reword user activity info from "Last active:" to "Active"."

This PR reverts zulip/zulip#25012 as it had unwanted byproduct.
CZO discussion
Screenshots:

Followed up with #25037


Fix batching for nested flatmaps at different levels of composition

A coworker found an edge case that meant we weren't optimally batching in the flushDownstream method. I had to make the getClumpsByLevel a bit more sophisticated to handle this.

@fwbrasil @williamboxhall - look good to you?

:+1:


Only the fee invoice amount is added to the ListPeers RPC paid fee

Only the fee invoice at the time of swapout is recorded in the paid fee displayed in ListPeers.

https://github.com/ElementsProject/peerswap/blob/master/peerswaprpc/peerswaprpc.proto#L12

Related: https://discord.com/channels/905126649224388629/905127419466350613/1191356265549533284.
Example Situation
Swap in and swap out once each from initiator node.

initiator_node_id:<PHONE_NUMBER>7db2522ed467ab2e7a108cd771a994e39ef3945175fe1a24d4aba5a2
responder_node_id:031872bccffbff6203d68bcaac7d2a088bc13e35026b31fdabe32a6d272397fe1a

peerswap1 listswaps
{
  "swaps": [
    {
      "id": "b963683c9ea47dbf23b74e35c131f262d6673d62739946b367eda0c8fbf6bf1c",
      "created_at": "1704244509",
      "asset": "btc",
      "type": "swap-out",
      "role": "sender",
      "state": "State_ClaimedPreimage",
      "initiator_node_id": "03926095277db2522ed467ab2e7a108cd771a994e39ef3945175fe1a24d4aba5a2",
      "peer_node_id": "031872bccffbff6203d68bcaac7d2a088bc13e35026b31fdabe32a6d272397fe1a",
      "amount": "10000000",
      "channel_id": "110:1:1",
      "opening_tx_id": "10912f55649640f8f829ddf029a0ad9462eb2c65ef335c2945c64d5c16887af0",
      "claim_tx_id": "f4965e25d53f509464153f088594db67c23d080949ba38732a165a10b1b06dbf",
      "cancel_message": "",
      "lnd_chan_id": "120946279120897"
    },
    {
      "id": "25ec85b3e22af44c1eeb862ae664949a11bb0ee49919ef0058352cceb75898cf",
      "created_at": "1704244534",
      "asset": "btc",
      "type": "swap-in",
      "role": "sender",
      "state": "State_ClaimedPreimage",
      "initiator_node_id": "03926095277db2522ed467ab2e7a108cd771a994e39ef3945175fe1a24d4aba5a2",
      "peer_node_id": "031872bccffbff6203d68bcaac7d2a088bc13e35026b31fdabe32a6d272397fe1a",
      "amount": "1000000",
      "channel_id": "110:1:1",
      "opening_tx_id": "8a7bbaed84cf0250f5051df15161e34ef14fcf2732ea00982628cddbf46ac1bf",
      "claim_tx_id": "",
      "cancel_message": "",
      "lnd_chan_id": "120946279120897"
    }
  ]
}

Initiator
The paid fee is the amount of the fee invoice.
./bin/pscli peerswap1 listpeers
{
  "peers": [
    {
      "node_id": "031872bccffbff6203d68bcaac7d2a088bc13e35026b31fdabe32a6d272397fe1a",
      "swaps_allowed": true,
      "supported_assets": [
        "btc",
        "lbtc"
      ],
      "channels": [
        {
          "channel_id": "120946279120897",
          "local_balance": "90979030",
          "remote_balance": "9017500",
          "active": true
        }
      ],
      "as_sender": {
        "swaps_out": "1",
        "swaps_in": "1",
        "sats_out": "10000000",
        "sats_in": "1000000"
      },
      "as_receiver": {
        "swaps_out": "0",
        "swaps_in": "0",
        "sats_out": "0",
        "sats_in": "0"
      },
      "paid_fee": "17500"
    }
  ]
}

Responder
The paid fee is 0.
peerswap2 listpeers
{
  "peers": [
    {
      "node_id": "03926095277db2522ed467ab2e7a108cd771a994e39ef3945175fe1a24d4aba5a2",
      "swaps_allowed": true,
      "supported_assets": [
        "btc",
        "lbtc"
      ],
      "channels": [
        {
          "channel_id": "120946279120897",
          "local_balance": "9017500",
          "remote_balance": "90979030",
          "active": true
        }
      ],
      "as_sender": {
        "swaps_out": "0",
        "swaps_in": "0",
        "sats_out": "0",
        "sats_in": "0"
      },
      "as_receiver": {
        "swaps_out": "1",
        "swaps_in": "1",
        "sats_out": "10000000",
        "sats_in": "1000000"
      },
      "paid_fee": "0"
    }
  ]
}

Idea for improvement
It would be good if the cost of onchain(opening tx/claim tx) incurred is additionally accounted for.

This command is pretty ancient and the naming seems to be completely off. It uses roles called "sender" and "receiver" for the "initiator" and the "responder" as they are referred to by the protocol. IIRC the fee named  here is only the fee that we needed to pay via the "fee invoice" and it was meant to also include the "premium" at some point to evaluate peers on how pricey they are.
I suggest a rework after we defined what we really want to show here since we don't have a premium.


Introducing frontend tests using playwright

just to keep things in check some front end tests might come in handy.
I will be expanding them as we go , creating a pull request for you guys to comment on on the way to expansion of the pack

I'm down to experiment with this!


Updated compilation info.

The compilaton was tested against MacOS Mojave (10.14.6) and the necessary information was added to the file.
Description
The information originally provided in the file is related to MacOS X Catalina. A revision of the file was made by following the instructions in a machine running MacOS X Mojave (10.14.6) and the necessary information to prepare the compilation environment using the referred operational system version was added accordingly.
Definition of Done
The revision of the compilation instructions lets the user to properly compile fv3-bundle code against MacOS X Mojave (10.14.6).
Issue(s) addressed
There is no issues oppened for this PR.
Dependencies
There is no dependencies.
Impact
Since the revision does not change the original information regarding MacOS X Catalina, there should be no impact to what is already known.

@cfbastarz I just came across this PR, I think it's seriously outdated by now ... apologies for that. Do you agree to close?

@climbfuji yes, thanks 👍

@climbfuji yes, thanks 👍

Thanks, and sorry again.


Add tests for the inline svg tag helper

Wrote these tests by accident (long story) but thought they might find some use here!
All changes to the our-svg tag helper class itself are to make it more testable and have no functional change, with the sole exception of an additional null check on the media source URL. The additional constructor parameter should be taken care of by dependency injection in normal usage.

Thanks @profcinders for the improvement


cal change

can you change the cal PA0CAB lastfligt to PA0CAB memorial
He is nouw silant key
plays remove 15, PA0CAB-4FSK and 449, PA0CAB and 449, PA0CAB
Thanks pe1glg han van der sterre

This should have been on the horusdemodlib repository, but I'll fix it here.
I'll change these callsigns all to PA0CAB-SK - hopefully this is OK!


Add Windows CI runner.

It passed but did not appear to do anything lol

The main ruby repo builds on windows on github actions so we could probably borrow what we need from there:
https://github.com/ruby/ruby/blob/master/.github/workflows/windows.yml
https://github.com/ruby/ruby/blob/master/.github/workflows/mingw.yml

Debugging this via CI has been obnoxious. I looked into whether there is a prebuilt VM available with the tools used to build this project, but the github actions team does not distribute the images they build (actions/virtual-environments#176) and I can't find anything else similar out there. I'm not really interested in getting a vanilla Windows vm and having to install rust, ruby, visual studio, etc.
I'd happily debug the build if something like this were available, but it appears this is not the case, so I'm closing this.

Someone on twitter pointed me to this windows 10 image with visual studio from microsoft, which appears to be about 25% of what I wanted: https://developer.microsoft.com/en-us/windows/downloads/virtual-machines/


Project doesn't run at all.

Tried both a clean install and normal install (which changes the package-lock due to different npm versions).
After installing all the packages and running npm run start or npm run build  I get the following errors after which the script just exists and can't finish.
 ERROR #11321  PLUGIN

"gatsby-plugin-webfonts" threw an error while running the onPreBootstrap
lifecycle:

getaddrinfo EAI_AGAIN fonts.googleapis.com

  Error: getaddrinfo EAI_AGAIN fonts.googleapis.com

 ERROR #98124  WEBPACK

Generating development SSR bundle failed

Can't resolve '/.cache/webfonts/webfonts.css' in
'/home/ivailo/Reactive-Resume/node_modules/gatsby-plugin-webfonts'

If you're trying to use a package make sure that '/.cache/webfonts/webfonts.css'
 is installed. If you're trying to use a local file make sure that the path is
correct.

File: node_modules/gatsby-plugin-webfonts/gatsby-ssr.js:24:39

And the whole log if it's required.
I tried my best at debugging the issue and fixing it myself but I'm out of ideas and this is why I'm posting the issue.
I was able to build the project just fine a few months ago (on Windows now on Linux so that might be why) but after doing a merge on my fork and pulling it, it just fails to build.
Editing to add that I also tried building with docker and that also fails with roughly the same log, just takes more time because it's well docker.

From my understanding the problem is with the link "gatsby-plugin-webfonts" is using. Looking at it's source it uses fonts.googleapis.com which not valid anymore, the actual link is fonts.google.com now.
I could be totally wrong but this is the first thing I noticed and wanted to mention it.

Switching the package to gatsby-plugin-web-font-loader fixes it.
Both package do the same exact thing but the implementation is different and this one works for me. If anyone else is encountering the same issue it might be worth switching over to web font loader.

Closing this in favor of Reactive Resume v3 release.
If you continue to face this issue, please raise a new one and I'll have a look at it as soon as I can.
In the meantime, if you are able to, please consider donating to keep supporting the project: https://www.buymeacoffee.com/AmruthPillai :)
Thank you!


The UnstructuredLoader constructor does not have an extractImageBlockTypes parameter.

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain.js documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain.js rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
  import { UnstructuredLoader } from "@langchain/community/document_loaders/fs/unstructured";
 const options = {
        apiKey: "",
        apiUrl: "",
        combineUnderNChars: 1000,
        pdfInferTableStructure: true,
        // extractImageBlockTypes: ["image"],

        chunkingStrategy: "by_title",
        multiPageSections: true,
        maxCharacters: 10000,

    };

    const loader = new UnstructuredLoader(
        {
            buffer: Buffer,
            fileName: 'xxx.pdf'
        },
        options
    );
    try {
        const docs = await loader.load();
        // console.log(docs)
        docs.map((doc, _index) => {
            console.log(doc.metadata.category)

        }
        )
    } catch (e) {
        console.log(e)

    }

In UnstructuredClient's own JS SDK, there is a parameter called extractImageBlockTypes.

import { UnstructuredClient } from "unstructured-client";
const client = new UnstructuredClient({})
client.general.partition({
        partitionParameters: {
            files: Bolb
            strategy: Strategy.HiRes,
            splitPdfPage: true,
            chunkingStrategy: ChunkingStrategy.ByTitle,
            maxCharacters: 10000,
            combineUnderNChars: 1000,
            extractImageBlockTypes: ['image'],

            splitPdfConcurrencyLevel: 10,

        },

    }).then((res: PartitionResponse) => {
        console.log("res", res);
        if (res.statusCode == 200) {
            console.log(res.elements);
        }
    }).catch((e) => {
        console.log(e);

    });

### Error Message and Stack Trace (if applicable)

_No response_

### Description

Without this parameter, it is not possible to parse images in PDFs. Will it be supported in the future?

### System Info

   "@langchain/community": "^0.2.16",
    "@langchain/openai": "^0.2.1",

I added support for this parameter in the Unstructured Loader. Please try it again in the next version. @kknono

Thank you for adding support for this parameter.


Unit and UI-Tests

Implement unit and ui-tests

Assign this to me.

Alright

Hey If you had started, kindly pause because I have rewritten most of the things, will let you when done


Add Tags to Describe blocks to make scoping easier

In larger environments one (or in this case I) might want to limit the scope of Pester tests to run.  As an example in one of my vCenters ( >350 hosts and  > 4000 vms) might want to run tests just against the clusters and hosts and not against VMs.  These changes use the Tags option on Describe blocks to give a way to control which tests get run.
Part of this for me is decreasing the amount of time it takes to run the tests esp given the variability of our vm configuration.
Examples:
Invoke-Pester  -ExcludeTag vm -Script @{Path = '.\Vester\Tests'; Parameters = @{ Remediate = $false ; Config = '.\Vester\Tests\Config.ps1' }}
runs ALL tests other than those tagged with VM (in this case skips: snapshots and the CDROM checks).
Invoke-Pester  -Tag host -Script @{Path = '.\Vester\Tests'; Parameters = @{ Remediate = $false ; Config = '.\Vester\Tests\Config.ps1' }}
runs only tests that are tagged with host.  (in this case skips: snapshots and the CDROM checks on vms, as well as cluster DRS checks etc).

:point_up: Been thinking about this. I have no NFS in my environments, and being able to easily exclude via tags is awesome.

Same here, and running the NFS tests against my big environment  the NFS tests alone take a couple of hours to run.....

This is brilliant. I didn't even notice the -Tag param on Pester. Love the idea!
:shipit:


homebrew: use homebrew-core for fallback link

This makes it so that homebrew formulae in other taps are properly
linked to their dependencies in the default tap. For example:
https://github.com/Homebrew/homebrew-science/blob/1acf4f470fc8c87f6bcbf19b721ebcd09c7fb025/octave.rb#L44
shows a dependency on autoconf, but the relativeFile resolver points to:
https://github.com/Homebrew/homebrew-science/blob/1acf4f470fc8c87f6bcbf19b721ebcd09c7fb025/autoconf.rb
which does not exist. Instead, use a new resolver to fall back to:
https://github.com/Homebrew/homebrew-core/blob/master/Formula/autoconf.rb

LGTM 👍  Just one note. I know our code coverage is quite low, but I would like to improve it. Therefore if you could write a test for homebrew-file.js that would be a first step in the right direction.


Publishing new version to Gradle Plugin Repo

Hi!
Thanks for plugin, it's usefull!
There were added a couple of nice fetures since 0.0.8,
Can you please publish the latest version to gradle repo (https://plugins.gradle.org/plugin/com.jetbrains.python.envs) ?

Done. Published version 0.0.9


Update Transform3DParallax.csproj

The App.xaml.cs is pointing to the wrong folder at ApplicationDefinition Include="......\SharedContent\xaml\App.xaml"
It should be:
ApplicationDefinition Include="......\SharedContent\cs\App.xaml"

Thanks. We'll include this in tomorrow's refresh.

Fixed in 4968d97b7ecc92a8772796ae79e703c78012ac68 Thanks for reporting it.


Add SubMenus (I have included a working example)

I took what you have been doing, (which is impressive) and I have added submenus. The working code is here:
https://github.com/coderdnewbie/Tailwind.SimpleBlazorWebAppTemplate
If you want to use the ideas from this then feel free, especially the Sub Menu feature.

I took what you have been doing, (which is impressive) and I have added submenus. The working code is here:
https://github.com/coderdnewbie/Tailwind.SimpleBlazorWebAppTemplate
If you want to use the ideas from this then feel free, especially the Sub Menu feature.

Thanks for taking interest in this template. I did try checking the link, but it returns a 404. Was this deleted, or is your repo set to private perhaps?

When you click the link it correctly returns a 404 as I have not written those pages yet (basically the code which needs to be fixed is href="subitem1" and href="subitem2" to the correct pages). This was just a demo that sub menus work. I am hoping your repo will be able to show the technique to more of the community. The code is just my test rig of ideas. With your starter code, the whole this is now pure tailwind (but I have versions with bootstrap 5, Havit, and Fluent UI).
The code for submenus is not mine, but bootstrap 5 code I found a while ago. My contribution is converting the code from bootstrap 5 to pure tailwind. The next step is to convert the submenu code into components, which I will attempt sometime in the future.
What you have done is good work, you should be happy with what you have done.


Support Storing/Reading/Deleting comments in the Datastore

Tim will be doing this review but I am going to cc myself on this PR @megankj

Once I pushed this, I noticed that clear comments does not remove the comments from the DOM so I am looking into how to fix that.


Brazil census addresses

This PR is preliminary. The dataset covers the whole country, but I have included only São Paulo state as a sample. If you would like to accept it, please let me know how to upload the preprocessed data to OA's cache. I will then prepare the data for the whole country (one source file per state) and update the pull request.
There are a few choices I made in the preprocessing script that I will be happy to discuss if necessary.

São Paulo data LGTM. About 60% have lat/lon but that's still ~740k addresses, virtually all of which have house number (or SN for sem numero), street, city, and postcode.
@migurski there seem to be a few different patterns for caching in the existing scripts. Is there a preference and are these scripts automated or run manually?

The scripts are not automated, they get run manually. There's not a strong preference, but if it’s possible to wrap it up in a container like Docker, it may make them easier to run in the future. Tennessee, New Zealand, and Australia follow that pattern.

I have updated the script to reflect the discussion on https://github.com/openaddresses/openaddresses/issues/2303. I'd say it's ready to merge.
I also have the preprocessed data for the whole country ready to upload (just tell me where). If you prefer to run the script on your end, use https://gist.github.com/astoff/5dc8f0df2e5a63a6750ce981ee1414b5 to generate the JSONs.

This is super exciting, thanks for your hard work on the PR with repeatable scripts and 1-time data builds :)
The OpenAddress S3 uploader will take files up to 256 mb in size:

https://results.openaddresses.io/upload-cache

To use it you'll need to be logged in via Github AND publicize your membership in the OpenAddresses organization.

Connects with https://github.com/openaddresses/openaddresses/issues/2303.

In the GIST you say:
#        ('53', 'Distrito Federal',         'DF'), #This has a funny address format, needs special conform
Has that been fixed subsequently, or will we need a followup issue to resolve the special conform for the capital's address format?

Fantastic! FYI @nvkelso, I fixed the bug where membership must be public. It can be private now and the upload will still work. Can also raise the limit above 256MB if needed.

@nvkelso There are two things with Distrito Federal: First, there is a better statewide dataset (https://github.com/openaddresses/openaddresses/pull/2311, but it is failing to download). Second, I am not really sure how to map Brasilia's address scheme to the usual number + street scheme—i'm trying to check with a local.

Looked into addresses in Brasilia a little while back. The city uses a grid system that's unlike anywhere I've ever seen. The UPU example is:
Sr. Luis Carvalho
SBN – Quadra 13 – Bloco B – 8º andar
BRASÍLIA – DF
70002–900
BRAZIL

Here "SBN" would be a sector of the city, which together with "Quadra 13" (usually combined and shortened, so "SBN 13") is sort of like a neighborhood, but also the name of the principal street within said neighborhood. Then "Bloco B" is a named/numbered building (and "8º andar" = 8th floor).
For OpenAddresses it probably makes the most sense to call "SBN 13" the street and "Bloco B" the house number.

@thatdatabaseguy That's how I did it in https://github.com/openaddresses/openaddresses/pull/2311. In the census, everything is concatenated in the street field, so there's no realiable way to split out the "bloco".

Ah ok. Would a regex in the transform work? Haven't looked at the raw census files for DF yet but it seems like the addresses there are very structured so something like this might do the trick if everything's concatenated:
    "number": {
        "function": "regexp",
        "field": "street name",
        "pattern": "^(?:.*?)(?:\\s*(Bloco\\b.*))?$"
    },
    "street": {
        "function": "regexp",
        "field": "street name",
        "pattern":  "^(.*?)(?:\\s*Bloco\\b.*)?$"
    }

Well, there are many variants (bloco, bl, lote, lt) so it would need testing. But I think the other PR (local gov data) is much better anyway. Should we not worry?

All right, so (assuming it builds) I will let somebody else do the merging, so others get a change to see if it looks OK.
Please squash and merge—there is a large deleted file in an intermediate commit.

Looks good to me! It's probably worthwhile to investigate the other source for Distrito Federal.

🇧🇷 a whole new country of data! 🇧🇷

On Jan 12, 2017, at 10:11 AM, Al Barrentine<EMAIL_ADDRESS>wrote:
Merged #2315.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

The data was only for this one region as a sample? I think there may be
some more work to do to get everything in?
On Thu, Jan 12, 2017 at 10:20 AM, migurski<EMAIL_ADDRESS>wrote:

🇧🇷 a whole new country of data! 🇧🇷

On Jan 12, 2017, at 10:11 AM, Al Barrentine<EMAIL_ADDRESS>wrote:
Merged #2315.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openaddresses/openaddresses/pull/2315#issuecomment-272240298,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0EOz3gJYW7iPhrc9xuyTMrUDcOErTHks5rRm7zgaJpZM4La7CX
.

I do see 30 files in this PR!

For whatever reason the map only shows São Paulo, but all the states were built as part of the PR.

Thanks for the links, I see them now :)
On Thu, Jan 12, 2017 at 11:45 AM, Al Barrentine<EMAIL_ADDRESS>wrote:

For whatever reason the map only shows São Paulo, but all the states were
built as part of the PR
http://results.openaddresses.io/jobs/5ad2e0f1-9cfa-4a81-bfba-73d0564c596e
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openaddresses/openaddresses/pull/2315#issuecomment-272262485,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0EO6HnrhmSU3cFLg2D8i8UbTYnxJxfks5rRoLFgaJpZM4La7CX
.

Ah yeah, sorry, the part of machine that decides which map to post back is not the most reliable thing. That’s a bug for me.


Adding changes

Hey @Som612  @smukhopa I made the changes, check it out and then I can push to the master.

@smukhopa @Som612 look at the last three files, etc.


Beginners question: Problems adding org-journal-dir to org-agenda-files

hello,
i stuck try to install and configure org-journal.
you wrote
"add all the calendar files to your org-agenda by adding org-journal-dir to org-agenda-files"
therefore i try to customize org-agenda group and insert the variable org-journal-dir as '(org-journal-dir).
But i dont see any journalfile inside my agenda.
After i inside the "real directory" and delete regex i see the files.
i checked the regex
\[^.].*\\.org\\'\\|\\[0-9]+\'
and find out, that deleting it completely shows them.
Unfortunately after that org complains journal file is no org file. I think because the missing extension *.org.
Any help welcome!
I will try org-journal :-)
Regards
Poul
PS: I'm running emacs 25 with org 9 on windows 8.1 64bit

Might it be the regexp?
I used the Meta-x customize-variable RET org-agenda-file-regexp RET method to change the variable, and entered in
\`[^.].*\.org\'\|\`[0-9]+\'

hello,
thank you !
it seems, that it works (files in journal directory with names as dates are recognized) but unfortunately the pure date as filename is not recognized as org-file.
I cannot use the command m-x org-journal-update-auto-mode-alist because my emacs dont know it.
Should i install anything else for that?
Regards
Poul

You should put (org-journal-update-auto-mode-alist) somewhere in your init.el. It is not meant to be run interactively. If you absolutely need to, it's M-x eval-expression [RET] (org-journal-update-auto-mode-alist) [RET].

I have updated the readme. This should now be more clear.
Putting this in the init file of emacs should work (tested).
(setq org-agenda-file-regexp "\\`\\\([^.].*\\.org\\\|[0-9]\\\{8\\\}\\\(\\.gpg\\\)?\\\)\\'")
(add-to-list 'org-agenda-files org-journal-dir)

I have this problem despite using the lines above in .emacs.
That is, I get there error "Agenda file MYDIR/notes/journal/20190802 is not in Org mode", and indeed the buffers corresponding to those files are not in org-journal mode.
I also tried M-x eval-expression [RET] (org-journal-update-auto-mode-alist) [RET], and it does not fix the problem.
auto-mode-alist contains (("MYDIR/notes/journal/\\(?1:[0-9]\\{4\\}\\)\\(?2:[0-9][0-9]\\)\\(?3:[0-9][0-9]\\)\\(\\.gpg\\)?\\'" . org-journal-mode). Is it correct?
MYDIR is a placeholder for this post.

@nano-o Have you tried to reproduce this with =emacs -Q=?
Do you use spacemacs? What org-journal version do you use? What does your org-journal setup look like?

I do not use spacemacs and I have org-journal version 20190914.1643.
My setup looks like this:
(require 'package)
(package-initialize)
(require 'org-journal)
(custom-set-variables
 '(initial-buffer-choice "MYDIR/notes/main.org")
 '(org-agenda-file-regexp "\\`\\([^.].*\\.org\\|[0-9]\\{8\\}\\(\\.gpg\\)?\\)\\'")
 '(org-agenda-files
   (quote
    ("MYDIR/notes/journal/" "MYDIR/notes/archive.org" "MYDIR/notes/main.org")))
 '(org-default-notes-file "MYDIR/notes/main.org")
 '(org-directory "MYDIR/notes/")
 '(org-journal-dir "MYDIR/notes/journal/")

Will try to reproduce with emacs -Q when I get the time.

This minimal configuration works for me.
cat <<EOF>> ~/org-journal-setup.el
(add-to-list 'load-path "MYDIR/.emacs.d/elpa/org-journal-20190914.1643")
(require 'org-journal)
(custom-set-variables
 '(initial-buffer-choice "MYDIR/notes/main.org")
 '(org-agenda-file-regexp "\\`\\([^.].*\\.org\\|[0-9]\\{8\\}\\(\\.gpg\\)?\\)\\'")
 '(org-agenda-files
   (quote
    ("MYDIR/emacs/org/journal/")))
 '(org-default-notes-file "MYDIR/emcas/org/main.org")
 '(org-directory "MYDIR/emacs/org/")
 '(org-journal-dir "MYDIR/emacs/org/journal/"))
EOF

emacs -q --load ~/mini-journal-setup.el

This minimal config does not work for me: I still get "Agenda file MYDIR/journal/20190802 is not in Org mode"

Is your org-journal setup still the same as in https://github.com/bastibe/org-journal/issues/92#issuecomment-532367898?

Yes, still the same.

What is the value of MYDIR in your case? Does it include "weird" characters such as umlauts, spaces, or anything else that might trip up Emacs?
What operating system and version of Emacs are you running?

Sorry, that was obvious: MYDIR points to a directory in a fuse volume managed by Keybase.

Does the problem occur in a "normal" directory as well?

No, the problem does not occur in a "normal" directory.

Interesting. Could you share a short recipe or description of how to set up such a failing path? I'm sure it'll be fixable once one of us can reproduce it.


Validation: Updated Metadata and Removed Absolute Links

Updated metadata and removed absolute links.

Docs Build status updates of commit c08b9ab:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/legacy/sql.md
:warning:Warning
View (azure-java-legacy)
Details

docs-ref-services/legacy/storage-blob-batch-readme.md
:warning:Warning
View (azure-java-legacy)
Details

docs-ref-services/legacy/storage-blob-cryptography-readme.md
:warning:Warning
View (azure-java-legacy)
Details

docs-ref-services/legacy/storage_legacy.md
:warning:Warning
View (azure-java-legacy)
Details

docs-ref-services/legacy/storage_preview.md
:warning:Warning
View (azure-java-legacy)
Details

docs-ref-services/legacy/storage.md
:bulb:Suggestion
View (azure-java-legacy)
Details

docs-ref-services/legacy/sql.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs-ref-services/legacy/storage-blob-batch-readme.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 27, Column 3: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.

docs-ref-services/legacy/storage-blob-cryptography-readme.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/legacy/storage_legacy.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs-ref-services/legacy/storage_preview.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/legacy/storage.md

Line 88, Column 133: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /java/api/overview/azure/storage/client?view=azure-java-stable. Otherwise, remove the view parameter.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit eb21171:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7ea53d2:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7ea53d2:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/legacy/storage-blob-cryptography-readme.md
:warning:Warning
View (azure-java-legacy)
Details

docs-ref-services/legacy/sql.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage-blob-batch-readme.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage_legacy.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage_preview.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage-blob-cryptography-readme.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 37967f4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/legacy/sql.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage-blob-batch-readme.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage-blob-cryptography-readme.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage_legacy.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage_preview.md
:white_check_mark:Succeeded
View (azure-java-legacy)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit fbec0ee:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/legacy/sql.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage-blob-batch-readme.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage-blob-cryptography-readme.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage_legacy.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage_preview.md
:white_check_mark:Succeeded
View (azure-java-legacy)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!

Docs Build status updates of commit c62d53a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d2cb546:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/legacy/storage-blob-batch-readme.md
:bulb:Suggestion
View (azure-java-legacy)
Details

docs-ref-services/legacy/storage-blob-cryptography-readme.md
:bulb:Suggestion
View (azure-java-legacy)
Details

docs-ref-services/legacy/sql.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage_legacy.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage_preview.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage-blob-batch-readme.md

Line 21, Column 63: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/blob-service-rest-api' will be broken in isolated environments. Replace with a relative link.
Line 21, Column 101: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/blobs/storage-blobs-overview' will be broken in isolated environments. Replace with a relative link.
Line 27, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 27, Column 3: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.
Line 29, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 44, Column 45: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-account-create?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 44, Column 77: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-cli' will be broken in isolated environments. Replace with a relative link.
Line 154, Column 27: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/blob-service-error-codes' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/legacy/storage-blob-cryptography-readme.md

Line 26, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/' will be broken in isolated environments. Replace with a relative link.
Line 28, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 43, Column 45: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 43, Column 94: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-cli' will be broken in isolated environments. Replace with a relative link.
Line 55, Column 118: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-dotnet-shared-access-signature-part-1' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d2cb546:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/legacy/storage-blob-batch-readme.md
:bulb:Suggestion
View (azure-java-legacy)
Details

docs-ref-services/legacy/storage-blob-cryptography-readme.md
:bulb:Suggestion
View (azure-java-legacy)
Details

docs-ref-services/legacy/sql.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage_legacy.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage_preview.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage-blob-batch-readme.md

Line 21, Column 63: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/blob-service-rest-api' will be broken in isolated environments. Replace with a relative link.
Line 21, Column 101: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/blobs/storage-blobs-overview' will be broken in isolated environments. Replace with a relative link.
Line 27, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 27, Column 3: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.
Line 29, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 44, Column 45: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-account-create?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 44, Column 77: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-cli' will be broken in isolated environments. Replace with a relative link.
Line 154, Column 27: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/blob-service-error-codes' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/legacy/storage-blob-cryptography-readme.md

Line 26, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/' will be broken in isolated environments. Replace with a relative link.
Line 28, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 43, Column 45: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 43, Column 94: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-cli' will be broken in isolated environments. Replace with a relative link.
Line 55, Column 118: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-dotnet-shared-access-signature-part-1' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 20c40f3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/legacy/storage-blob-batch-readme.md
:bulb:Suggestion
View (azure-java-legacy)
Details

docs-ref-services/legacy/storage-blob-cryptography-readme.md
:bulb:Suggestion
View (azure-java-legacy)
Details

docs-ref-services/legacy/sql.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage_legacy.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage_preview.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/storage-blob-batch-readme.md

Line 21, Column 63: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/blob-service-rest-api' will be broken in isolated environments. Replace with a relative link.
Line 21, Column 101: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/blobs/storage-blobs-overview' will be broken in isolated environments. Replace with a relative link.
Line 27, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 27, Column 3: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.
Line 29, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 44, Column 45: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-account-create?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 44, Column 77: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-cli' will be broken in isolated environments. Replace with a relative link.
Line 154, Column 27: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/storageservices/blob-service-error-codes' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/legacy/storage-blob-cryptography-readme.md

Line 26, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/' will be broken in isolated environments. Replace with a relative link.
Line 28, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 43, Column 45: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
Line 43, Column 94: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-quickstart-create-account?tabs=azure-cli' will be broken in isolated environments. Replace with a relative link.
Line 55, Column 118: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/storage/common/storage-dotnet-shared-access-signature-part-1' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Spanish and opening exclamation mark (¡)

Hi! I'm trying to configure kmonad for my Thinkpad X1 Carbon with a Spanish keyboard and I'm having trouble because I have a key which is labelled "¡" and I can't seem to find the right code for that. If I write the symbol directly in my defsrc section, I get a syntax error ("unexpected '¡'"). What's the right way to tell kmonad about that key?
It'd be nice to have a Spanish keyboard example in the templates section. If I make it work, I'd be glad to provide it.

On Wed, Aug 16 2023 10:49, inwit wrote:

If I write the symbol directly in my defsrc section,

The usual way to go about these things is to assume a US layout in the
`defsrc', and then set the actual layout after kmonad has loaded.

Thanks!


FCOS3D KITTI training

Hello, whether the training pipeline of the FCOS3D KITTI dataset has been supported

Actually, it is originally supported but there is just no suitable config. You can refer to this PR for some reference.


WIP: filter paramterized expressions

DEPENDS ON #1688 #1736 and  #1710
adds parameterized expressions

I am closing this one since it is out of sync.


[Suggestion] Add the ability to use %crate% placeholder in "Given-A-Player-Keys" message

As the title said. To be able to add the %crate% placeholder to messages in the messages.yml file  like "Given-A-Player-Keys" and "Given-Everyone-Keys". This would be nice to have if for example the command gets issues through console by an operator or by a different plugin you would then be able to see what type of crate key the player received. Currently it just shows up as %crate% if you insert the placeholder into those messages.

You can use the %key% placeholder to have it show the display name on the key item.

Ah. Didnt know that. Thanks


XSS vulnerability in third-party library

Be relying on spin.js, ladda is also not compliant with strict CSP (Content Security Policy). See: https://github.com/fgnass/spin.js/issues/115

This is preventing me from even thinking about using this project.

Is it indeed a vulnerability? It seems that there is no intention of fixing this from spin.js collaborators, at least not in the near future.

I made a pull request for spin.js yesterday that fixes it, but none of the spin.js collaborators have commented on it yet: https://github.com/fgnass/spin.js/pull/343.


Prevent crash when a non-numeric value is passed to a ModelSelectField(widget=ModelSelect2Widget(...))

If the form value for a ModelSelectField for numeric foreign key is non-numeric, rendering the form
crashes with:

Field 'id' expected a number but got "13'[0]".

(full traceback)
This proposes ignoring non-numeric values for numeric fields. A small test case is included.

Almost 3 years ago already!
We use the widget as part of a django-filter filterset. I'm not sure why this weird values get in the query string, but crash reporting shows lots of crashes related to this.
When I use the default widget for ModelSelectField and pass a non-numeric value, the form is considered invalid (which is different from what I propose here), and rendered as such. But it does not result in a crash.
In my opinion it is a reasonable expectation for this widget not to crash. Dealing with the origin of the weird values might become a little harder, but the UI should make clear to the user that no item is selected in the widget.

I see, hm… If this comes from a programmatic error I am hesitant to silence the error. To my knowledge a user can't pass a non-numeric value, only a developer can. I would agree to maybe provide a better exception message, to silence it, seems wrong. Besides, I just explained in another post, why cleaning value for a primary key in Django is almost impossible, since all different field types raise different errors.


Flattener testing in parallel

Basic testing setup to run the flattener in parallel, checking for any breaking changes during flattener dev work. test_flattener.py will create one process per inputed ProcessedMatrixFile to run the main() function from the flattener.
Defaults:

Run on demo, processed matrix files from test_processed_matrix_files.txt

Command line arguments:

--mode/-m [ENVIRONMENT] = demo or prod; defaults to demo if no argument provided
--processed-matrices/-p [MATRICES] = list of ProcessedMatrixFiles to test; this list is used if --file/-f argument also provided
--file/-f [FILE] = txt file with name of one ProcessedMatrixFile per line; defaults to test_processed_matrix_files.txt if no argument provided AND if no --processed_matrices/-p argument present

Final terminal printout will show either:

{ProcessedMatrixFile}: SUCCESS   OR
{ProcessedMatrixFile}: FAILURE {with Traceback}

After, can use concurrent_validation.py to quickly check that flattened files meet CXG schema.
This script should catch both handled and unhandled exceptions from the flattener.
Full run with 10 ProcessedMatrixFiles in test_processed_matrix_files.txt takes 6-7 min with about 50 GB of memory usage on ec2 and 30 GB of memory on local MacBook Pro. Accessing the demo on the browser seems slightly slower but this testing script does not appear to cause excessive stress on the demo or prod servers.
Tested both locally and on the flattener ec2 instance (conda env test and lattice).
Points of concern:

Each process needs its own Lattice connection object to query Lattice. This involves passing the object as an argument in numerous helper functions. The restructuring of the flattener with the GlobalVals class made this very easy, but I am still concerned I could have missed some of the changes.
There was initially a circular import with the download_file() function; I moved this to mods/gather.py
Possible areas with race conditions or data corruption: downloading the same RawMatrixFile, writing to the same flattened file if testing on prod and demo concurrently with the same ProcessedMatrixFiles. Reading the same file simultaneously should be safe. My biggest concern is downloading the same RawMatrixFile from two or more processes. This could be overcome by adding a function that creates a list of all h5/h5ad files needed before flattening and downloads them locally before spawning the separate worker processes.

Amazing work, @brian-mott! Here's what I've tested:

ran test_flattener.py with my own set of ProcMatrixFiles
ran test_flattener.py with -p parameter
ran flattener.py just to double check things are running smoothly

Thoughts:

I went through and looks like the connection was all added and didn't see any that were missed
Thank you for moving download_file() to gather.py, as it makes more sense to put it there so that things in uns_functions.py and flattener.py can both access it.
So far, did not come across any issues downloading. I think the user would just need to be mindful of what they are trying to download.
Logging is great for summarizing at end of script

Looks great! I just left one comment on that one random line of code that has been there for a while.

Looks great! Thank you, @brian-mott


Automatically initialize git submodules

Currently when running make serve or something similar, we get just a warning says
WARNING: Submodule not initialized: <module path>

Even if submodules are not initialized, we always go to the next steps and get failed.
Better if we could automatically initialize these submodules before build and serve.

@sftim I've pushed a new commit, which

Add a new rule module-init
If uninitialized modules detected, print a message in module-check to tell users to run make module-init, and then break the build chain.

Would you think it is a better way?

/assign @bradtopol

Looks like @sftim is engaged here so making him the assignee.
/assign @sftim
/unassign

Looks like @sftim is engaged here so making him the assignee.
/assign @sftim
/unassign

Hi @sftim
Could you review this PR if you are free? Thank you! 😃

Hi @sftim
Could you review this PR if you are free? Thank you! 😃

@rayw000 ,
I suggest to rename this pull request to describe the new make target (module-init)?

Hi @rayw000 .
I ran the targets. My local website repository has the theme installed.
I ran the module-init target and the api-ref-generator sub-module installed successfully.
The module-check target did not return a message.
If I remove the theme submodule, the module-check target returns (as expected .git is not there):
fatal: not a git repository: '.git'
fatal: failed to recurse into submodule 'themes/docsy'

I am not sure the module-check (original or modified) is working as expected.
Are you able to rebase your changes into a single commit?
I think the module-init target is useful.

Hi @kbhawkey

The module-check target did not return a message.

The original module-check target works as its name suggests, it only checks and outputs submodules which are not initialized, otherwise, it outputs nothing. So if you have all your submodules initialized, empty output is just what it is expected.
The mainly difference between original and current module-check is on return code. The original module-check always returns zero even if there are uninitialized submodules. It doesn't stop make serve or similar targets from trying to build website (of course, failed). I make it return non-zero in this situation in order to break the rules chain.

If I remove the theme submodule, the module-check target returns (as expected .git is not there):
fatal: not a git repository: '.git'
fatal: failed to recurse into submodule 'themes/docsy'

I have no idea how do you "remove" your theme submodule. Would you like to provide more details?
I ran the following command
git submodule deinit -f <submodule>

and then make module-check, I got the following output as expected.
WARNING Submodule not initialized: api-ref-generator
WARNING Submodule not initialized: themes/docsy
You need to run make module-init to initialize missing modules first
make: *** [module-check] Error 1

And then if we run command make serve, we'll get the same error message as make module-check, and stop the current make procedure. That's why I introduce this target.

Are you able to rebase your changes into a single commit?

Rebased.

Hi @rayw000 .
I cloned a new website repo and ran make module-check. The output is:
You need to run make module-init to initialize missing modules first
Makefile:27: recipe for target 'module-check' failed
make: *** [module-check] Error 1

Hi @kbhawkey
This output means there're uninitialized submodules. But there should be lines saying something like "Warning: Submodule not initialized: ". I have no idea why they're missing.
It's weird that variable err used in awk is non-zero in your environment but no uninitialized submodules detected. I'll try to reproduce when I at my laptop.

Hi @kbhawkey
I cloned  a new website (head on ebb3d6a14d106f0ba9cc6f0d4c1f4467e1bec932)
git clone --depth=1 https://github.com/kubernetes/website website.tmp

and applied changes of this PR.  make module-check and make module-init worked as expected.
Would you please provide more details?

/remove-lifecycle stale

Hi @rayw000 .
Sorry for the delay in testing these changes.
I tested by removing the submodules from an existing website repository.
In addition, I created a new repository and ran module-check. I received the expected error message.
WARNING Submodule not initialized: api-ref-generator
WARNING Submodule not initialized: themes/docsy
You need to run make module-init to initialize missing modules first
Makefile:25: recipe for target 'module-check' failed
make: *** [module-check] Error 1

I also tested this on a local Ubuntu installation.
/approve


ACK RDS: can't create encrypted db from snapshot.

Good day!
I have an ACK toolkit RDS controller v.1.4.6.
I want to create a DB from snapshot encrypted by KMS.
I prepared the next manifest:
apiVersion: kms.services.k8s.aws/v1alpha1
kind: Key
metadata:
  name: dbserver5
spec:
  description: "Key for dbserver5"
  enableKeyRotation: true
  tags:
    - tagKey: Name
      tagValue: dbserver5
    - tagKey: env
      tagValue: uat
---
apiVersion: kms.services.k8s.aws/v1alpha1
kind: Alias
metadata:
  name: dbserver5
spec:
  name: alias/dbserver5
  targetKeyRef:
    from:
      name: dbserver5

for KMS and these resources were applied properly.
Then I want to create DB:
apiVersion: rds.services.k8s.aws/v1alpha1
kind: DBInstance
metadata:
  name: dbserver-5
spec:
  dbSnapshotIdentifier: "arn:aws:rds:eu-west-2:******:snapshot:******"
  allocatedStorage: 20
  dbInstanceClass: db.r5.large
  dbInstanceIdentifier: dbserver-5
  engine: mysql
  engineVersion: "5.7"
  masterUsername: "root"
  masterUserPassword:
    namespace: infra-uat
    name: dbserver-5-db-password
    key: password
  dbSubnetGroupRef:
    from:
      name: rds-subnet
  publiclyAccessible: false
  availabilityZone: 'eu-west-2c'
  storageEncrypted: true
  kmsKeyRef:
    from:
      name: dbserver5

In fact I am getting the next:
apiVersion: rds.services.k8s.aws/v1alpha1
kind: DBInstance
metadata:
  annotations:
    rds.services.k8s.aws/last-applied-secret-reference: infra-uat/dbserver-5-db-password.password
  resourceVersion: '642548767'
  name: dbserver-5-uat
  namespace: infra-uat
  finalizers:
    - finalizers.rds.services.k8s.aws/DBInstance
  labels:
    kustomize.toolkit.fluxcd.io/name: infra-management
    kustomize.toolkit.fluxcd.io/namespace: flux-system
spec:
  engine: mysql
  preferredMaintenanceWindow: 'fri:23:40-sat:00:10'
  caCertificateIdentifier: rds-ca-rsa2048-g1
  kmsKeyRef:
    from:
      name: dbserver5
  dbInstanceClass: db.r5.large
  storageThroughput: 0
  deletionProtection: false
  availabilityZone: eu-west-2c
  masterUserPassword:
    key: password
    name: dbserver-5-db-password
    namespace: infra-uat
  licenseModel: general-public-license
  storageEncrypted: false
  autoMinorVersionUpgrade: true
  dbSnapshotIdentifier: 'arn:aws:rds:eu-west-2:*****:snapshot:*****'
  publiclyAccessible: false
  monitoringInterval: 0
  copyTagsToSnapshot: false
  dbSubnetGroupRef:
    from:
      name: rds-subnet
  multiAZ: false
  preferredBackupWindow: '05:01-05:31'
  allocatedStorage: 20
  storageType: gp2
  engineVersion: '5.7'
  performanceInsightsEnabled: false
  masterUsername: root
  dbInstanceIdentifier: dbserver-5
  backupRetentionPeriod: 1
status:
  pendingModifiedValues: {}
  dbSubnetGroup:
    dbSubnetGroupDescription: ololo
    dbSubnetGroupName: rds-subnet
    subnetGroupStatus: Complete
    subnets:
      - subnetAvailabilityZone:
          name: eu-west-2a
        subnetIdentifier: *****
        subnetOutpost: {}
        subnetStatus: Active
      - subnetAvailabilityZone:
          name: eu-west-2b
        subnetIdentifier: *****
        subnetOutpost: {}
        subnetStatus: Active
      - subnetAvailabilityZone:
          name: eu-west-2c
        subnetIdentifier: *****
        subnetOutpost: {}
        subnetStatus: Active
    vpcID: *****
  latestRestorableTime: '2024-10-19T09:25:00Z'
  dbInstanceStatus: available
  ackResourceMetadata:
    arn: 'arn:aws:rds:eu-west-2:*****:db:dbserver-5'
    ownerAccountID: '474417630776'
    region: eu-west-2
  certificateDetails:
    cAIdentifier: rds-ca-rsa2048-g1
    validTill: '2027-10-19T09:10:58Z'
  optionGroupMemberships:
    - optionGroupName: 'default:mysql-5-7'
      status: in-sync
  customerOwnedIPEnabled: false
  dbInstancePort: 0
  dbiResourceID: *****
  endpoint:
    address: *****
    hostedZoneID: *****
    port: 3306
  conditions:
    - lastTransitionTime: '2024-10-19T09:30:15Z'
      status: 'True'
      type: ACK.ReferencesResolved
    - lastTransitionTime: '2024-10-19T09:30:16Z'
      status: 'False'
      type: ACK.ResourceSynced
    - lastTransitionTime: '2024-10-19T09:30:16Z'
      message: Late initialization successful
      reason: Late initialization successful
      status: 'True'
      type: ACK.LateInitialized
  iamDatabaseAuthenticationEnabled: true
  vpcSecurityGroups:
    - status: active
      vpcSecurityGroupID: *****
  instanceCreateTime: '2024-10-19T09:11:46Z'
  dbParameterGroups:
    - dbParameterGroupName: default.mysql5.7
      parameterApplyStatus: in-sync

I want to point out that kmsID is not put into the target object for some reason and the flag storageEncrypted is false.

Hi @gecube - thank you for reporting this! I quickly checked the RestoreDBInstanceFromSnapshot API and it doesn't look like it provides a way to restore DBInstances with encrypted storage https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_RestoreDBInstanceFromDBSnapshot.html - looks like this is only possible with DBClusters


Don't convert function name with '_' to '-' - instead let CLI catch functions with invalid names

https://github.com/firebase/firebase-functions-python/pull/25

Hello! After updating to the latest versions of the firebase function and firebase tools, I am still running into the issue where my "main.py" file does not found the module "flask_restful" when i try uploading it to cloud via "firebase deploy --only functions". I have already included "flask_restful" and its version in the "requirements.txt" file under the "functions" folder, however, it still does not recognize it. Any advice?


return empty array in case that json_decode returns not an array.

currently we are using the AbstractClient for a subscription implementation. There is as example the following API https://developer.paypal.com/docs/api/subscriptions/v1/#subscriptions_cancel wich returns a "204 - no content" result. This will fail with the current implementation because the strict check throws a type error.
Since i don't want to catch a TypeError the fix could be like in this pull request.
I didn't find any tests regarding this, so i didn't wrote anything

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/PT-11982
Please use this issue to track the state of your pull request.

thanks for your contribution @dominikmank  :+1: :tada: :blue_heart:


Responsive problem

in the mobile responsive background video not playing

@sadiksheikh7 On mobile devices, Autoplay videos will not play in the background. The user has to opt-in to play them.

Is this still a thing ?
Even on mute, the autoplay video in background still not play on mobile ?

@remyg4g  As far as I know, video will not autoplay on iOS devices because you're required to 'opt in' by clicking a play button. Looking at the Vide website on my new Android (I switched from iOS), it seems that the background video does play. Hope that helps.


GEODE-3457: Linking fails on Solaris SPARC due to -xatomic=none option

Fixes Solaris SPARC linking error. For more information: https://docs.oracle.com/cd/E60778_01/html/E60746/gqhbq.html
Testing: built on solaris sparc

Going to merge this before CI completes since we don't CI Solaris.


Use our own PI

Turns out, M_PI is not officially required to be in math.h or cmath, so we define our own. (building in google's skia discovered this).
While we're at it, we also define it to explicitly be a float (not a double).
This does create some tiny differences, as some of our math is different (not using the double pi). I posit these are effectively arbitrary, and think the faster, more consistent float version is fine. Happy to discuss more...

Sounds good. +1!

Having it typed is a good advantage.

I also like that we can define factors of pi more clearly like this. I never know if I want M_PI_2 or M_2_PI and have to look up which is which. HalfPI and TwoPi would be so much clearer.


Dataframe does not have into_robj() method

One can create a Dataframe using IntoDataFrameRow. However, once created it cannot be converted into an Robj using into_robj().
You can, though use into_dataframe().unwrap().as_robj().clone()
#[derive(IntoDataFrameRow)]
struct MyStruct {
    a: String,
    b: Option<i32>,
}

fn test() -> Robj {
    let a = MyStruct {
        a: String::from("hello"),
        b: None,
    };
    vec![a].into_dataframe().unwrap().into_robj()
}

What should be the solution for this? IntoRobj takes Self, which is a little harsh.
Should we make a
pub trait AsRobj {
   fn get(&self)->&Robj,
   fn get_mut(&mut self)->&mut Robj,
 }

Since it is "cheaper" to copy &Robj,  and those can be used everywhere (atleast supposed to be able to used everywhere).
Now, of course there are as_robj, but I intend to Implement AsRobj on anything that wraps an Robj.

Dataframe implements GetSexp, thus one may do .as_robj(), which may yield a &Robj. You may use this for almost everything you want to do with an Robj, as it is preferred to be thrown around, instead of Robj, as Robj increases ref-count, and thus is more costly to copy, than &Robj.
Of course, this should be documented somehow.


unified WAL rather than per block

Due to large amount of lock contention, we maybe moving to a unified WAL (as well as a single in-mem datastructure rather than several head-blocks).
// WAL is a write ahead log that can log new series labels and samples.
// It must be completely read before new entries are logged.
type WAL interface {
Reader() WALReader
LogSeries([]labels.Labels) error
LogSamples([]RefSample) error
LogDeletes([]Stone) error
Truncate(int64)
Close() error
}

We just keep appending to the WAL and whenever the database chugs out a persistent block, it will call the Truncate(mint) function and we need to drop any old segment files and also mark the overlapping segment file so that we only read the values after mint.
I think allocating the first 16bytes of each segment file to store the mint, maxt would allow for most things. When reading the WAL back, we just look at the mint and then read only the values that popup after mint.
Another issue is that the labels --> seriesID entry could be in the first WAL segment and if the series never expires, then we might be dropping the seriesID entry when we drop the first segment. For that the alternate is to dump the active series everytime a new block is cut. Do we want to extend Truncate(int64) to Truncate(int64, series)?
@fabxc

think allocating the first 16bytes of each segment file to store the mint, maxt would allow for most things. When reading the WAL back, we just look at the mint and then read only the values that popup after mint.

I think we don't have to store it at all. On startup we read each segment and thereby have to compute the ranges anyway.
On any segments written afterwards, we can also compute it easily. So keeping it in memory should be sufficient.

Another issue is that the labels --> seriesID entry could be in the first WAL segment and if the series never expires, then we might be dropping the seriesID entry when we drop the first segment. For that the alternate is to dump the active series everytime a new block is cut. Do we want to extend Truncate(int64) to Truncate(int64, series)?

Yea so a dump file is the easy option I think. It could just be a WAL file as well which just has serie s entries and which we give the first ordinal file name before the remaining segments.
Probably Truncate(mint int64, exits func(id uint32) bool) error is the saner option as we don't have to pass a list of series. Though an iterator (Postings) could work as well.

This is in master.


[AppBar] Title not quite vertically centered with iconElementLeft

See the image:

This is the code I am using:
                        <AppBar
                            title={application.name}
                            iconElementLeft={
                                 <Avatar
                                    style={{ width: '60', height: '60'}}
                                    src={application.icon}
                                 />}
                        />

maybe work :/
  <AppBar
         style={{lineHeight:'100px'}}
         titleStyle={{verticalAlign:'middle'}}
          title={application.name}
          iconElementLeft={
                       <Avatar
                         style={{ width: '60', height: '60'}}
                         src={application.icon}
                    />}
           />

maybe work
  <AppBar
         style={{lineHeight:'100px'}}
         titleStyle={{verticalAlign:'middle'}}
          title={application.name}
          iconElementLeft={
                       <Avatar
                         style={{ width: '60', height: '60'}}
                         src={application.icon}
                    />}
           />

@af7 The AppBar is not really designed to support resolutions outside of 64px (or 56px on mobile). The title is vertically centered by using CSS line height, which does not correspondingly grow as the height of its parent div increases. While adjusting the lineHeight manually like @ayhankuru suggested should work, you also may want to consider to just decreasing the size of your Avatar to be more in line with the standard.
The link below also has some other useful guuidelines for designing AppBars. For example, according to the spec, you may want to consider using an icon that has a single color rather than multiple colors.
https://www.google.com/design/spec/layout/structure.html#structure-app-bar


[Feature]: Add transformation for explicitly set configuration from AWS.config

Self-service

[ ] I'd be willing to implement this feature

Problem
Example input:
import AWS from "aws-sdk";

AWS.config.region = "us-east-1";
const client = new AWS.DynamoDB();
console.log(await client.listTables().promise());

Solution
Expected output:
import { DynamoDB } from "@aws-sdk/client-dynamodb";

const client = new DynamoDB({ region: "us-east-1" });
console.log(await client.listTables());

Alternatives
Manually copying values from AWS.config in places where clients are created.
Additional context
No response

@trivikr
Any news on this issue? I'm also facing similar issue.

The transformations for aws-sdk-js-codemod are prioritized based on users requests, and whenever we can get time from working on other high priority issues. I've added a standard priority for this issue.
This work can be taken up after basic support for AWS.Config is provided in https://github.com/awslabs/aws-sdk-js-codemod/issues/528
Please run codemod on your production applications, and create/upvote bug reports and/or feature requests which are blocking you. That will help us understand the pending work which is impacting customer code in production.


Use TF reference for aws_lambda_permission

This is the same PR as #7, but from a branch of azul-chalice instead of my personal fork.

@noah-aviel-dove, if you're wondering why this PR looks familiar, it's because this is the same as #7 which you approved, but @hannes-ucsc asked me to remake the PR with a branch of this repo instead of a fork.

Merged and tagged as https://github.com/DataBiosphere/azul-chalice/tree/1.18.0+6


Update to Gradle 8.5

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Update to Gradle 8.5
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Part of https://github.com/opensearch-project/OpenSearch/issues/10334
Check List

[x] Backport Labels added.
[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Seems like we have hard dependency on https://github.com/opensearch-project/performance-analyzer/pull/617


Adding update and remove methods to LazoIndex

This pull requests adds a remove and an update method to LazoIndex (an update, in this case, is a removal followed by a new insertion). In addition, it also adds a method to set the cardinality in a LazoSketch, which is useful to load existing sketch information saved in some store.
This will be particularly useful for Lazo Index Service, a service we have been developing to index textual/categorical data using Lazo.

Fantastic!


Freehand touch

adds touch support to FreehandMouseTool
I appreciate your comments.
remaining issues:

lines are not correctly moved in the touchMoveHandle animation
needs a global variable for the touchMove aboveFinger offset

@dannyrb, I had a look through the code, but would you be able to chime in on the touch-specifics, and check this works well on an actual touch device?

pencil mode works for me. when increasing config.spacing, it gets easier to complete the drawing, but the polygon becomes more jagged

thanks for offering to invite me to slack, here is my email at gmail.com: vsaase

@vsaase aha, nice that you got pencil mode too. I send you an invite to the cornerstonejs slack.
I replied to your comment, other than that I'm happy, but I'll wait on @dannyrb  to chime in before we merge.
Thanks again for the contribution and nice job 💯 .

On my list to review this -- Bit of a crazy day. I have the first part of tomorrow blocked off on my calendar to take a peak :+1:

touchStart.js and touchMoveHandle.js are the only items that need scrutinized a little harder before I'd merge this, as they have the potential to mess with other tools. I'll look into the TOUCH_PRESS event a little further.
@vsaase please let me know your thoughts. If we can tidy up those two parts, and assuming you have the green light from @JamesAPetts, I think this should be merge-able fairly soon 👍

After a little tidying/comment up of handleSelectedCallback, and when the TOUCH_PRESS stuff is resolved, I'm rather happy. I made a comment about _drawingMouseMoveCallback, if it makes sense to make a touch version instead of piggybacking on this method, feel free.

@vsaase is this ready for review? I see some outstanding conflicts -- not sure what/if you need from us.

hi, yes, this is ready for review, might be outdated though. atm i cant find time to further work on this I am afraid

Hey, I've picked this up as inspiration and packaged it in #892. Feel free to have a look at my attempt there, thanks a lot for this!

@all-contributors please add @vsaase for his helpful ideas!


Feature : pthread_cancel() (IDFGH-8242)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution.

@kewelspintly We'll take a look at this PR and come back to you afterwards.

@kewelspintly could you sign CLA and also rebase this PR to master?

@kewelspintly We're closing this issue since the CLA has not been signed. Additionally, there are cancellation handlers and other POSIX-defined aspects which need to be considered, or else the cancelled thread might, e.g., leave a locked mutex or create other synchronization problems. We might consider adding this API in the future, albeit not having concrete plans at this moment.
If you change your mind and still plan to work on this PR, please feel free to re-open this issue.


Pulsar function replicas auto scaling

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
Pulsar function and connector in Kubernetes runtime should be able to auto scale based on resource usage or the input topic backlog size or some other metrics. The auto scale should be horizontal scaling.
Solution
No response
Alternatives
Use the existing Kubernetes HPA. But the state of replicas won't be saved because function stop removes the function statefulset. The parallelism is save in bookkeeper not Kubernetes (upon statefulset removal) in the current implementation.
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

maybe this is interesting
https://github.com/streamnative/function-mesh/issues/457

Thanks for the suggestion @hpvd. I think this issue is requesting an improvement to the kubernetes runtime that ships with pulsar.

jep. Sorry the issue was not the right target to link (it's a preview how function scaling in function mesh should/will work in the near future -> using keda)
Wanted to point to a solution how functions could be auto-scaled today (with additional tool: function-mesh)

With Kubernetes Horizontal Pod Autoscaler (HPA), Function Mesh supports automatically scaling the number of Pods (Pulsar instances) that are required to run Pulsar functions, sources, and sinks.
Function Mesh auto-scales the number of Pods based on the CPU usage, memory usage, and custom metrics.

source:
https://functionmesh.io/docs/scaling


Fix uniform paramaters fit.

Current coverage is 100.00%

Merging #114 into master will not affect coverage as of c1be490

@@            master    #114   diff @@
======================================
  Files           30      30
  Stmts          966     966
  Branches         0       0
  Methods
======================================
  Hit            966     966
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of c1be490

Powered by Codecov. Updated on successful CI builds.

This should fix a scipy bug that returns the parameters of uniform distribution in random order, and the problem that @juanchopanza mentioned about setting min-max twice.

I guess the JSON file is added by accident? For the .py file, I have a related change, see #115

Removed json file.

Looks good, but I think the changes in #115 supersede this.

Closing as superseded by #115


Create operator table

Describe the task
A clear and concise description of what the task is.
Acceptance Criteria

[ ] the operator table exists
[ ] the operator table has a legal_name column
[ ] the operator table has a trade_name column
[ ] the operator table has a bc_registry_id column

merged with #128


Migrate from Docker Hub to GitHub Container Registry

Docker Hub is shutting down its free service for public repositories / open source projects, effective 2023-04-15, so we need to switch to another service.
We're already enthralled by GitHub, and the GitHub Container Registry (ghcr.io) is well integrated with GitHub Actions and free for open source / public repositories so... that seems like it's probably the top contender!

Not sure this makes any difference given that we are "commercial" and it seems like that excludes us from their open source program, but Docker apologized.

@zaneselvans I'd be interested in taking a stab at this, though I may need organizational permissions

Although it says Docker reversed their decision so I don't think this is required unless you want to move to their open source plan (which is also free)
https://www.docker.com/blog/no-longer-sunsetting-the-free-team-plan/

We're still thinking about doing this, but it's been deprioritized since they reversed course. I don't think we can do their open source plan because we as an entity do try and make a little money at least.


Capitalizing Title in Cite Keys

[x] I have verified that I am on the latest release of BBT (https://github.com/retorquere/zotero-better-bibtex/releases/latest) and Zotero
[x] I am posting a single question, bug or feature request
[x] I have included a descriptive subject of the problem
[x] I am available for follow-up questions and testing

I'm not sure whether this is expected behavior, but I think it may be a bug. I would like to have the [shorttitle] and [title] commands for generating Cite Keys capitalize the words of the title they're extracting. I've tried to use the 'capitalize' filter, but is still not capitalizing. Here are three examples of generated Cite Keys for a journal article with title "Effectiveness of prehospital trauma triage systems in selecting severely injured patients: Is comparative analysis possible?":
[auth]_[year]_[shorttitle]: vanRein_2018_Effectivenessprehospitaltrauma
[auth]_[year]_[shorttitle:capitalize]: vanRein_2018_Effectivenessprehospitaltrauma
[auth]_[year]_[title]: vanRein_2018_EffectivenessofprehospitaltraumatriagesystemsinselectingseverelyinjuredpatientsIscomparativeanalysispossible

It's not a bug, [title] and [shorttitle] were made to mimic the JabRef behavior, which lowercases the result. I can't change that behavior now as it would affect citekeys for existing users.
capitalize works only on space-separated words; [title] and [shorttitle] don't deliver space-seperated words, but [Title] does (the meaning of the capitalized Title is explained here). You could try something like [auth]_[year]_[Title:capitalize:skipwords:select,1,3].

Great, thank you for explaining and providing the suggested command, I confirm that it works!


Functional tests for DOS and changes to existing SSP test

Includes refactoring of existing SSP code
Changes to existing SSP tests to account for changes in screen flow
Changes to existing SSP code so that it works for both G-Cloud and DOS submissions

Closing this as have merged Kevins branch  instead


fix sync between widget + map on dashboards

Overview
Brief description of what this PR does, and why it is needed.
Demo
If applicable: screenshots, gifs, etc.
Notes
If applicable: ancilary topics, caveats, alternative strategies that didn't work out, etc.
Testing

Include any steps to verify the features this PR introduces.
If this fixes a bug, include bug reproduction steps.

Closing, this will be refactored.


Get the viewer server to listen to <IP_ADDRESS>

Is there any way to launch the viewer on <IP_ADDRESS>? I have to run it on a machine that I can't ssh to (so I can't port forward), but if I could get the viewer to listen for connections from any address then I could open it. Thanks!

Hi! I'll be fixing this with PR #698! You can take a look already. It's close but quite done.


Automatic etcd provisioning

HA setup with etcd
Additionally you have to deploy the etcd-operator to the cluster as well:
kubectl apply -f operator/deploy/etcd-operator.yaml

Now deploy a HA vault which connects to an etcd storage backend:
kubectl apply -f operator/deploy/cr-etcd-ha.yaml

From now on, if you deploy a Vault CRD into the cluster which has an Etcd Storage Backend defined in its configuration the Vault operator will create an EtcdCluster CRD for the Vault instance, and the etcd-operator will orchestrate the etcd cluster. After the etcd cluster is ready the Vault instance can connect to it and will start up. If the Vault CRD is deleted from the cluster the etcd cluster will be GCd as well. You have to make sure you define backup and restore for the etcd cluster to prevent data loss, this part is not handled by the Vault operator, see this document for more details.
Please note that TLS is not added for Vault -> etcd communication yet, for that I will create a separate issue: #80
Fixes: #78

@bonifaido awesome, thanks. Yes #80 would be a key for security

Great! #80 goind to be implemented in the following days. I will keep you informed.