Support databricks

Add test support of Databricks connector.

Also, needs to be rebased over master; there are conflicts to resolve. (sorry, we're at a fast moving dev stage)

@erezsh I think we'll also need the rounding support in here, no?

Also, needs to be rebased over master; there are conflicts to resolve. (sorry, we're at a fast moving dev stage)

@erezsh , I resolved but I see that a new version failed because it could not compare object of ColumnName class. I've added a fix in this PR for it.

Hi, I'm sorry but a lot has changed in the last week.
Database classes now also need to "normalize" the values, based on the column type. For example, dates need to have the form of YYYY-MM-DD HH:MM:SS.FFFFFF. They also need to provide table schema, so we know the column types.
We plan to make the 0.1 release sometime next week. I believe the pace of internal changes will slow down after that.

We've released v0.1 and things should be a bit more stable from now on.

@erezsh granted access

@pik94  The tests are failing for numbers. They are expected to be 0.00000000..., but instead databricks formats them as 0E-10
For example:
======================================================================
test_types_mysql_num65_10_databricks_double_50 (tests.test_database_types.TestDiffCrossDatabaseTables)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Python310\lib\site-packages\parameterized\parameterized.py", line 533, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "C:\code\datafold\xdiff\tests\test_database_types.py", line 630, in test_types
    self.assertEqual(expected, diff)
AssertionError: Lists differ: [] != [('-', ('1', '0.0000000000')), ('+', ('1',[116 chars]0'))]

Second list contains 6 additional elements.
First extra element 0:
('-', ('1', '0.0000000000'))

- []
+ [('-', ('1', '0.0000000000')),
+  ('+', ('1', '0E-10')),
+  ('-', ('14', '0.0000000000')),
+  ('+', ('14', '0E-10')),
+  ('-', ('15', '0.0000000000')),
+  ('+', ('15', '0E-10'))]

@pik94 I also had a look at the URI, and I don't think it's a good idea to put the "http_path" as the user, because then you'll have to escape the slashes.
I think this should be the URI instead:
databricks://:access_token@server_name/http_path?schema=..&catalog=..

This also reflects that "schema" and "catalog" are optional parameters.
I already have a patch for this, so if you agree, I'll push it on to this PR.

:wave: Hi, y'all. Just here to say that I would like to try data-diff on Databricks. Happy to see this PR being merged.


No issues found / Error during capture phase, exiting on "infer -- mvn install"

Environment:

infer git-a50ecde01cf990555f2d2e9e5da05af87b8965d7
Java 1.7.0_71
Maven 3.3.3
Python 2.7.10

Running the following commands
mvn clean
infer -g --log_to_stderr -- mvn install

no issues are found on a project which surely has issues and the file "target/infer-out/toplevel.log" contains
[INFO] Running command /Applications/infer/bin/infer -i -o [OMISSIS]/target/infer-out -- javac [OMISSIS] -d [OMISSIS]/target/javacOut -classpath [OMISSIS]
[INFO] Path to infer script /Applications/infer/bin/infer (/Applications/infer/bin/infer)
[INFO] Infer version git-a50ecde01cf990555f2d2e9e5da05af87b8965d7
Copyright 2009 - present Facebook. All Rights Reserved.

[INFO] Platform: Darwin-14.5.0-x86_64-i386-64bit
[INFO] PATH=[OMISSIS]
[INFO] SHELL=/bin/bash
[INFO] PWD=[OMISSIS][INFO] Starting analysi[INFO] [INFO] Starting analysis
[INFO] Capture phase was successful
[u'inferJ', u'-g', u'-a', u'infer', u'javac', '[OMISSIS]']

[ERROR] Error during capture phase, exiting

I can't find anywhere which error the logs are referring to.
Moreover, the logs seem not properly "flushed" and the rows mix in different ways each time I run that command.

Hi @giacgbj, sorry for the delay. Is there any chance you could share the project you are trying to analyse, or provide a reproducible example?
In "toplevel.log", the line [u'inferJ', u'-g', u'-a', u'infer', u'javac', '[OMISSIS]'] has java files instead of '[OMISSIS], right? Just checking that infer actually sees some files being compiled.
Lastly, you might want to have a look at #38.

Hi @jvillard, unfortunaly I cannot share the project: I would be probably fired :-)
[OMISSIS] had a lot of file.
I just installed the stable version v0.4.0 and I tried again: from the error I have now I understood that I had to increase the number of open files, as suggested in #22;
However, still no issues are found.
I don't know if it can help you, but infer-out/log/analyzer_err contains
Found 591 source files in [OMISSIS]/infer-out
[OMISSIS]
Procedures defined in more than one file:
Found 0 defined procedures in 0 files.
Analyzing 0 files.

Minimal clusters:

Combined clusters with max size 50

Hi @giacgbj, does the latest infer work for you? If not please re-open this issue and paste the full output of infer somewhere (such as gist.github.com). Thank you!


Add goofy mode

Address #2 .
Though I should have asked specifics in the issue first... I will ask now.

LGTM


Export 'createStyleTagMarkup' was not found in 'fela-utils'

I'm using typescript and it throws warning
WARNING in ./~/fela-dom/es/server/renderToMarkup.js 15:16-36 "export 'createStyleTagMarkup' was not found in 'fela-utils'

I have updated library to 6.0.3. And now got this errors

My fault)


Windows Native Docker bug report location

Hi
just wondering for windows native docker, the docker engine that runs windows kernal based docker images. do we report the bug here?

@Shuliyey yes!, you can report bugs here.

I am going to close this as the question is answered, but looking forward (!) to your bug report @Shuliyey


Issue 244

elevator can create content that uses the new extension-definitions.
The extension-definitions are in extension_definitions.py.  They are just stand-ins.  There is no json schema behind them

PR #247 already contains changes and suggestions from this request


Pinchable inside a pressable component

Library works awesome: great job!
One minor inconvenience is that if the pinchable component (image) is inside a parent pressable item, upon leaving the pinched image to zoom, it will trigger the pressable component behind.
is there any way that when the pinch is triggered, it disables any "background" event?

I had the same issue and noticed onPressIn is triggered at the start of the pinch action. I created a new pressable component which essentially ignores the press if the action is longer than some time (200 ms below) and this works perfectly in my situation so far.
import React from 'react'
import { Pressable } from 'react-native'

const PressableDelayed: React.FC = ({ onPress, style, children }) => {
  const timer = React.useRef(0)

  return (
    <Pressable
      onPressIn={() => {
        timer.current = new Date().getTime()
      }}
      onPress={() => {
        if (new Date().getTime() - timer.current > 200) return
        if (onPress) onPress()
      }}
      style={style}
    >
      {children}
    </Pressable>
  )
}

export default PressableDelayed

Any answer about that?

We need solution for this issue very much. Anyone know how to mention any related people about this issue?

I use this custom parent component to wrap around the rn-pinchable. If the pinchable action is more than 160 milliseconds, it will avoid triggering the press.
import React from 'react'
import { Pressable } from 'react-native'

const PressableDelayed: React.FC = ({ onPress, children, ...props }) => {
  const timer = React.useRef(0)

  return (
    <Pressable
      onPressIn={() => {
        timer.current = new Date().getTime()
      }}
      onPress={() => {
        if (new Date().getTime() - timer.current > 160) return
        if (onPress) onPress()
      }}
      {...props}
    >
      {children}
    </Pressable>
  )
}

export default PressableDelayed

      <PressableDelayed onPress={...}>
            ...
      </PressableDelayed>


Highlight certain customers

It would be be able to display notes when entering certain customers, e.g. if someone forgot to sign the rental agreement, it can be highlighted in red the next time the person makes a rental. same goes for remarks for people, e.g. if we decide to block someone.
Until now this was solved by adding e.g. "AUSWEIS" to their last name, such that the next person typing "923" will get the name "Mustermann AUSWEIS" as a name. Maybe we can solve this differently?

I think we also have these issues when someone forgets to insert any required data for new rentals / customers / items. Therefore we could build some kind of notification system. This would include a notification symbol in the upper right corner where the user could expand a list of all notifications (e.g. "Missing Mail / Ausweis / Date / ... for User / Rental / Item x"). This way we would have an overview of all missing data.
We could also create a notifications for failed Woocommerce updates. This is important so that we can retry them or do the changes in Woocommerce manually.
As you suggested we could display these notifications while editing the corresponding customer / item / rental.

I think we also have these issues when someone forgets to insert any required data for new rentals / customers / items. Therefore we could build some kind of notification system. This would include a notification symbol in the upper right corner where the user could expand a list of all notifications (e.g. "Missing Mail / Ausweis / Date / ... for User / Rental / Item x"). This way we would have an overview of all missing data.
We could also create a notifications for failed Woocommerce updates. This is important so that we can retry them or do the changes in Woocommerce manually.
As you suggested we could display these notifications while editing the corresponding customer / item / rental.

I have two concepts how we could implement the reminder for people besides the notifications
Version 1: color cell / row, and let user choose a color. This could be implemented both for customers and for items. Advantage: We can use different colors to display different things. Hovering over the cell could show the remark of the item/customer

Version 2: Show a small exclamation mark, clicking/hovering on exclamation mark will open the issue

what do you think?

I have two concepts how we could implement the reminder for people besides the notifications
Version 1: color cell / row, and let user choose a color. This could be implemented both for customers and for items. Advantage: We can use different colors to display different things. Hovering over the cell could show the remark of the item/customer

Version 2: Show a small exclamation mark, clicking/hovering on exclamation mark will open the issue

what do you think?

I like the colored cells best. When clicking on a highlighted customer_name cell in rentals we could also link to the customer table. Maybe if in the customer table we also highlight cells we might not even need popups.

I like the colored cells best. When clicking on a highlighted customer_name cell in rentals we could also link to the customer table. Maybe if in the customer table we also highlight cells we might not even need popups.

I've started implementing, and could use SELECTION input for it nicely

It would also not be a problem to highlight things in the customer page&popup, however, I struggle to color the background cell in the rentals tab, as there is no direct connection to the customer-db. I guess querying the highlight-status for each rental row from the customer-table would be quite a workload?

I've started implementing, and could use SELECTION input for it nicely

It would also not be a problem to highlight things in the customer page&popup, however, I struggle to color the background cell in the rentals tab, as there is no direct connection to the customer-db. I guess querying the highlight-status for each rental row from the customer-table would be quite a workload?

I've started implementing, and could use SELECTION input for it nicely

It would also not be a problem to highlight things in the customer page&popup, however, I struggle to color the background cell in the rentals tab, as there is no direct connection to the customer-db. I guess querying the highlight-status for each rental row from the customer-table would be quite a workload? Do you have an alternative idea how this could be solved without too much strain on performance? we would also need to query items-db at some point i guess.

Ah, so you are planning to add a new field like is_highlighted to customers and rentals? Then those rows as well as the corresponding cells in rentals should be highlighted correct?
To highlight rental cells I would edit this rowBackgroundColorFunction so that it can color cells instead of rows here https://github.com/leih-lokal/LeihLokalVerwaltung/blob/53f5760465d2e7729219adeeac7a6bc2ae817f40/Frontend/src/components/TableEditors/Rentals/Rentals.svelte#L27
and here
https://github.com/leih-lokal/LeihLokalVerwaltung/blob/53f5760465d2e7729219adeeac7a6bc2ae817f40/Frontend/src/components/Table/Row.svelte#L50
In the rowBackgroundColorFunction you would need to query the item and customer databases. Row.svelte should already render everything without the color if the database queries did not finish yet. When they finish it could just rerender and add the colors. You could use promises to achieve that (see https://svelte.dev/tutorial/await-blocks).
Feel free to open a PR, even if it is not finished yet, then I can comment on your code and help out.

I've started implementing, and could use SELECTION input for it nicely

It would also not be a problem to highlight things in the customer page&popup, however, I struggle to color the background cell in the rentals tab, as there is no direct connection to the customer-db. I guess querying the highlight-status for each rental row from the customer-table would be quite a workload? Do you have an alternative idea how this could be solved without too much strain on performance? we would also need to query items-db at some point i guess.

Ah, so you are planning to add a new field like is_highlighted to customers and rentals? Then those rows as well as the corresponding cells in rentals should be highlighted correct?
To highlight rental cells I would edit this rowBackgroundColorFunction so that it can color cells instead of rows here https://github.com/leih-lokal/LeihLokalVerwaltung/blob/53f5760465d2e7729219adeeac7a6bc2ae817f40/Frontend/src/components/TableEditors/Rentals/Rentals.svelte#L27
and here
https://github.com/leih-lokal/LeihLokalVerwaltung/blob/53f5760465d2e7729219adeeac7a6bc2ae817f40/Frontend/src/components/Table/Row.svelte#L50
In the rowBackgroundColorFunction you would need to query the item and customer databases. Row.svelte should already render everything without the color if the database queries did not finish yet. When they finish it could just rerender and add the colors. You could use promises to achieve that (see https://svelte.dev/tutorial/await-blocks).
Feel free to open a PR, even if it is not finished yet, then I can comment on your code and help out.

@daniel17903 this is already live or?
When I just tried it on the github pages, it didn't seem to work - it highlights things in Rentals, but the rows are not highlighted in Customers

@daniel17903 this is already live or?
When I just tried it on the github pages, it didn't seem to work - it highlights things in Rentals, but the rows are not highlighted in Customers

@daniel17903 this is already live or?
When I just tried it on the github pages, it didn't seem to work - it highlights things in Rentals, but the rows are not highlighted in Customers

Yes, I think I broke it when I merged it. It will be fixed again with #154

@daniel17903 this is already live or?
When I just tried it on the github pages, it didn't seem to work - it highlights things in Rentals, but the rows are not highlighted in Customers

Yes, I think I broke it when I merged it. It will be fixed again with #154


Change the calculation of max for service metrics

The current calculation does not work and always returns 0. As the mean works correctly, I assume the max function on Timer does not return a useful value. As the code iterates through all requests anyway, it can also use the total time of one request and then take the largest value.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@krusche Not sure this is the good option because it will return same value as the totaltime

@krusche Not sure this is the good option because it will return same value as the totaltime

The lambda expression within reduce is different.
totaltime sums up the values
max takes the larger value
So I guess it should be fine, right?

@krusche You are right, my mistake 😅

@DanielFran can we merge it and create a new release so that we can use the improved implementation in our app?

@krusche sorry, forgot to merge it...

I can launch a release of the lib tomorrow if needed
It will be desync with generator-jhipster but it's not a problem for "patch" version

@krusche Thanks for the contribution

No confirmation from @krusche : do you need a release of jhipster-bom?

It's not urgent, so if you plan another release in the next 10-15 days, it should be fine as well. But I would not like to wait several weeks.

I tried to release the version v7.5.1 but I got a lot of error locally, related to remote nexus.
But it seems here: https://repo.maven.apache.org/maven2/tech/jhipster/jhipster-parent/7.5.1/
Can you try this version ?

Thanks, I will try it out

Seems to work. I had to adjust metrics-endpoints-requests.component.html to display the max values:

Endpoints requests (time in millisecond)

                Method
                Endpoint url
                Count
                Mean
                Max

            <ng-container *ngFor="let entry of endpointsRequestsMetrics | keyvalue">

                    {{ method.key }}
                    {{ entry.key }}
                    {{ method.value!.count }}
                    {{ method.value!.mean | number: '1.0-3' }}
                    {{ method.value!.max | number: '1.0-3' }}

            </ng-container>

The 2 lines with max are new. I guess those have to be added in the corresponding jhipster template


[FEATURE REQUEST] Add available APIs to service metadata

Area of the resources that should be enhanced?
Metadata of services
Description
Hi,
first of all I am really happy to have a service metadata like this.
As feature request to me would be quite interesting to see the APIs - including currently active semantic version - that can be used to interact with each service. I can see a link to the API documentation but having the APIs listed separately would be helpful.
In this way you can track which APIs are available to work with the service and if you are using the latest version.
Please let me know if you need any further input or if there any questions.
Thanks
Flo
Link to resource
No response

Hi @flop36 , thanks for your request. We were working on this feature already and have just added it to the repository. Please let us know if there are further questions.

Hi @rui1610, wow, this was fast :)
Looks great. Would it be possible to add the latest/active version of each API?
Thanks and kind regards,
Flo


can´t change "the environment variable TS3SERVER_LICENSE to "accept""

Greetings!
my ts inside this container seems to had an update. After that, every docker start is stopped after 1 sec with

Please set the environment variable TS3SERVER_LICENSE to "accept" in order to accept the license agreement.

"docker start" has no -e option available and i can´t exec the container because it´s not running longer than one second.
Kind regards from germany

Just use docker run instead of docker start.
Alternativly create a file named .ts3server_license_accepted in the data directory.


Feedback on Tutorial: End-to-End Weather App Scenario Part 4

using the pom.xml link in the tutorial I copy and paste the contents into my pom.xml and just saving the file and I get errors that prevent anything from building. Subsequent steps also throw errors.
Links on the Maven site all seem to refer to Java Web Tomcat 8 web applications, but that isn't what the tutorial prerequisites seems to have specified.
Any help would be appreciated.
// errors listed when saving pom.xml with contents from tutorial's link to github pom.xml
Errors occurred during the build.
Errors running builder 'Maven Project Builder' on project 'weatherapp'.
Could not calculate build plan: Plugin org.apache.maven.plugins:maven-resources-plugin:2.5 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-resources-plugin:jar:2.5
Plugin org.apache.maven.plugins:maven-resources-plugin:2.5 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-resources-plugin:jar:2.5
Could not calculate build plan: Plugin org.apache.maven.plugins:maven-resources-plugin:2.5 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-resources-plugin:jar:2.5
Plugin org.apache.maven.plugins:maven-resources-plugin:2.5 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-resources-plugin:jar:2.5
// ---------------------------------------
// errors listed for  element after saving pom.xml with contents from github
//---------------------------------------------------
CoreException: Could not calculate build plan: Plugin org.apache.maven.plugins:maven-compiler-plugin:2.5.1 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-compiler-plugin:jar:2.5.1: ArtifactResolutionException: Failure to transfer org.apache.maven.plugins:maven-compiler-plugin:pom:2.5.1 from https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced. Original error: Could not transfer artifact org.apache.maven.plugins:maven-compiler-plugin:pom:2.5.1 from/to central (https://repo.maven.apache.org/maven2): connect timed out

Hi there, I am experiencing the exact same problem with the pom files. Tutorial so far was very good and helpful, however with the Maven Project Generation there seems to be some stumble stones to get around. Can someone provide an answer to the question above?

So, this problem is actually a communication problem with the Maven server.

Failure to transfer org.apache.maven.plugins:maven-compiler-plugin:pom:2.5.1 from https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced.

This error is trying to say "I couldn't talk to the Maven server, so I'm relying on the cached data".
This is usually caused by a firewall or proxy server in your organization.  One possible way to fix this is to use the proxy settings for maven.  You can find more information on that here.  Note that the settings are not in Eclipse, but in the .m2 folder.
Another way to solve this problem is to move your computer to a public network.  (Any coffee shop will do.)
To force Eclipse to try again, and determine if the error is still occurring, follow these steps:

Right click on the project folder
Choose the Maven --> Update Project
In the dialog, click the Force Update of Snapshots/Releases setting at the bottom of the screen.
Click OK

If Maven is able to contact the server, the errors should go away.

Hi Jonathan,
I have done what you've told in your previous response to do.
To force Eclipse to try again, and determine if the error is still occurring, follow these steps:
1.Right click on the project folder
2.Choose the Maven --> Update Project
3.In the dialog, click the Force Update of Snapshots/Releases setting at the bottom of the screen.
4.Click OK
If Maven is able to contact the server, the errors should go away.
but I'm getting this error
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project weatherapp: Fatal error compiling: tools.jar not found: C:\Program Files\Java\jre7..\lib\tools.jar -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException


Assessment - header color

https://openedx.atlassian.net/browse/MA-1441

@saeedbashir you'll need to update the snapshot tests. To do this you can do the following at a terminal:
./gradlew recordSnapshots --continue

@aleffert I ran the command and updated screenshot but it still failing :(

@saeedbashir did you include --continue? It looks like you didn't update the RTL screenshots. It does two passes one for LTR, one for RTL and if you don't include that command it will stop after the first pass.

@aleffert yes I did again but surprisingly now it changes few more screenshots but it still failing :(

@saeedbashir hrrrm, I'm not sure what the problem is, but when I update them locally, I only get changes for that screen. I pushed a change that cancels out the other screens and the tests seem to pass.
Maybe we can set up some time so I can watch you try to update them and maybe we'll figure out what the difference is?

@aleffert I figure out the issue. At me end NSDate(timeIntervalSinceReferenceDate: 100000) this results in 2nd January but in your case its returning 1st January.

@aleffert I figure out the issue. At me end NSDate(timeIntervalSinceReferenceDate: 100000) this results in 2nd January but in your case its returning 1st January.


Font: Add eFontFormatFlag_WrapText and implement it in DrawText.

Formal Notes

This PR fixes:

RN:
RN:
RN:

Description, Motivation and Context

Link to issue: Fixes ?
Link to reference doc: ?

How Has This Been Tested?

Command line to run all the tests that I run locally:
ham Run_ci

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that cause existing functionality to change)
[ ] Documentation (code docs, comments, or changes to the doc systems)
[ ] Testing/Build (test coverage or the test/build subsystems themselves)
[ ] Packaging (adds examples or modifies a release package)

Current dependencies on/for this PR:

main

PR #40

PR #41

PR #42

PR #43

PR #44   👈

This comment was auto-generated by Graphite.


Added option for async transport building

Codecov Report
Attention: Patch coverage is 83.95904% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 44.18%. Comparing base (4bfda68) to head (5bd0d93).

Files
Patch %
Lines

...main/java/tech/ydb/core/impl/YdbTransportImpl.java
74.28%
4 Missing and 5 partials :warning:

...src/main/java/tech/ydb/core/impl/YdbDiscovery.java
92.45%
5 Missing and 3 partials :warning:

...java/tech/ydb/core/impl/MultiChannelTransport.java
0.00%
7 Missing :warning:

...n/java/tech/ydb/core/impl/pool/PriorityPicker.java
85.71%
4 Missing and 3 partials :warning:

.../java/tech/ydb/core/grpc/GrpcTransportBuilder.java
61.53%
5 Missing :warning:

...ain/java/tech/ydb/core/impl/BaseGrpcTransport.java
28.57%
3 Missing and 2 partials :warning:

.../java/tech/ydb/core/impl/auth/AuthCallOptions.java
50.00%
2 Missing and 3 partials :warning:

...ava/tech/ydb/core/impl/SingleChannelTransport.java
0.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #264      +/-   ##
============================================
+ Coverage     41.42%   44.18%   +2.75%
- Complexity     1460     1554      +94
============================================
  Files           295      294       -1
  Lines         11363    11344      -19
  Branches       1112     1107       -5
============================================
+ Hits           4707     5012     +305
+ Misses         6296     5936     -360
- Partials        360      396      +36

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Wrong contentInsets when connected mouse

If i connected mouse, then scrollView has wrong contentInset because of scroller, without mouse is fine.

Have you set content inset on the scroll view, or do you mean the bounds are off? Unfortunately I don't have a mouse to test with at the moment. You might want to check what the bounds are in the -layout method in JNWCollectionViewFramework.m.

Bounds of the collectionView are fine, if i connect mouse then scroller is making some magic stuff and there is more space, and if i turn off mouse then it is relayouting and content is okay. I will debug it around weekend

Hi, @m1entus, have you found the solution?

@jwilling Before connecting mouse:
(lldb) po self.collectionView.contentInsets
▿ NSEdgeInsets

top : 0.0
left : 0.0 { ... }
bottom : 0.0 { ... }
right : 0.0 { ... }

(lldb) po self.collectionView.contentSize
▿ CGSize

width : 151.0
height : 440.0

After connecting mouse:
(lldb) po self.collectionView.contentSize
▿ CGSize

width : 136.0
height : 440.0

(lldb) po self.collectionView.contentInsets
▿ NSEdgeInsets

top : 0.0
left : 0.0 { ... }
bottom : 0.0 { ... }
right : 0.0 { ... }

@danielmartinprieto No i haven't found because i didn't invastige to it

@danielmartinprieto http://stackoverflow.com/questions/15249563/force-nsscrollview-to-use-nsscrollerstyleoverlay-independently-from-input-device this solve issue, i added code to scrollView as a temporary solution

Ok found solution, preparing PR...


OSError: /usr/lib/libgdal.so.20: undefined symbol: sqlite3_column_table_name

Hi,All, what is the problem is to solve?Thanks.
~$ python manage.py syncdb
Traceback (most recent call last):
  File "manage.py", line 16, in <module>
    execute_from_command_line(sys.argv)
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
    utility.execute()
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/core/management/__init__.py", line 357, in execute
    django.setup()
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/apps/registry.py", line 114, in populate
    app_config.import_models()
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/apps/config.py", line 211, in import_models
    self.models_module = import_module(models_module_name)
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/auth/models.py", line 2, in <module>
    from django.contrib.auth.base_user import AbstractBaseUser, BaseUserManager
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/auth/base_user.py", line 47, in <module>
    class AbstractBaseUser(models.Model):
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/db/models/base.py", line 117, in __new__
    new_class.add_to_class('_meta', Options(meta, app_label))
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/db/models/base.py", line 321, in add_to_class
    value.contribute_to_class(cls, name)
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/db/models/options.py", line 204, in contribute_to_class
    self.db_table = truncate_name(self.db_table, connection.ops.max_name_length())
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/db/__init__.py", line 28, in __getattr__
    return getattr(connections[DEFAULT_DB_ALIAS], item)
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/db/utils.py", line 201, in __getitem__
    backend = load_backend(db['ENGINE'])
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/db/utils.py", line 110, in load_backend
    return import_module('%s.base' % backend_name)
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/gis/db/backends/postgis/base.py", line 6, in <module>
    from .features import DatabaseFeatures
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/gis/db/backends/postgis/features.py", line 1, in <module>
    from django.contrib.gis.db.backends.base.features import BaseSpatialFeatures
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/gis/db/backends/base/features.py", line 3, in <module>
    from django.contrib.gis.db.models import aggregates
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/gis/db/models/__init__.py", line 3, in <module>
    import django.contrib.gis.db.models.functions  # NOQA
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/gis/db/models/functions.py", line 4, in <module>
    from django.contrib.gis.db.models.fields import BaseSpatialField, GeometryField
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/gis/db/models/fields.py", line 3, in <module>
    from django.contrib.gis import forms, gdal
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/gis/forms/__init__.py", line 3, in <module>
    from .fields import (  # NOQA
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/gis/forms/fields.py", line 2, in <module>
    from django.contrib.gis.gdal import GDALException
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/gis/gdal/__init__.py", line 28, in <module>
    from django.contrib.gis.gdal.datasource import DataSource
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/gis/gdal/datasource.py", line 39, in <module>
    from django.contrib.gis.gdal.driver import Driver
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/gis/gdal/driver.py", line 5, in <module>
    from django.contrib.gis.gdal.prototypes import ds as vcapi, raster as rcapi
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/gis/gdal/prototypes/ds.py", line 9, in <module>
    from django.contrib.gis.gdal.libgdal import GDAL_VERSION, lgdal
  File "/home/lcy/.local/share/virtualenvs/django-rest-framework-gis-oE3eL-dx/lib/python3.6/site-packages/django/contrib/gis/gdal/libgdal.py", line 47, in <module>
    lgdal = CDLL(lib_path)
  File "/home/lcy/.pyenv/versions/3.6.6/lib/python3.6/ctypes/__init__.py", line 348, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: /usr/lib/libgdal.so.20: undefined symbol: sqlite3_column_table_name

$ dpkg -l | grep "gdal-bin"
ii  gdal-bin                                          2.1.2+dfsg-5                       amd64        Geospatial Data Abstraction Library - Utility programs

python manage.py syncdb is not a valid django command. change your commands to python manage.py makemigrations and then python manage,py migrate. and move to the latest django releases.


Showcase Submission for challenges/179-wolfram-ca

Thank you Jake Beamish for your contribution! A member of the Coding Train team will review it shortly.

ECA Marching Squares
Jake Beamish

Fantastic!


test(plugin-optimize): initial tests

part of #1019
Changes
Adds initial tests fro plugin-optimize
Testing
☝🏼
Docs
no code changes

resolved the bug via d84e5874
I removed the preloadModules option from the test. It would be good to have a test for that option as it makes up 1/4 of the code. I'd suggest we make a dedicated follow up issue for someone else to pickup, as it's not critical


Added Banner

Hopefully the image actually shows. Also delete the other pull request I made, it's already in conflict with a lot of the other stuff we merged

note: if this doesn't work, upload banner.jpg to imgur.


feat: apply groupchannel enableMessageSearch config flag

Description Of Changes
https://sendbird.atlassian.net/browse/UIKIT-4085
Applied enable_message_search config flag by adding showSearchIcon to lib/Sendbird component prop which is not a completely new one but it can be passed from App component which already has showSearchIcon prop.

[x] group_channel.setting.input.enable_message_search

@sravan-s Oh thanx. I missed that. I added showSearchIcon prop to SendbirdProviderProps interface https://github.com/sendbird/sendbird-uikit-react/pull/616/commits/d00f4a07589db848f930b72c44235784919091a9


Debug issues with polygons not showing

debug-lonboard.geojson.zip
they have self-intersections:

whoops this was because I didn't actually bump to 0.2.0 in lonboard when I thought I did... but it's actually fixed by https://github.com/developmentseed/lonboard/pull/142!


Remove requests dependency from PyPIClient

This should fix latestdependency from failing. @kristapratico @xiangyan99

Ok I think this is solid. Merging. A follow-up PR is coming later today to clean up the remaining requests usage in the proxy side.


Add benches for 'propose' and 'ready' of RawNode

Add benches for RawNode::propose and RawNode::ready as they are two of the most essential API to upper layers.
Part of https://github.com/pingcap/raft-rs/issues/109
@Hoverbear @hicqu
Signed-off-by: Fullstop000<EMAIL_ADDRESS>

I refactored the bench for RawNode::propose by Benchmark which makes configuring measurement for single benchmark become possible.
@Hoverbear @BusyJay

@hicqu @gengliqi PTAL

Seems it can't work with criterion 0.2. In my environment it only works after I update criterion to 0.3. Could you check it @Fullstop000 ? If you also meet the same problem, please update the depencency in Cargo.toml.

rest LGTM. Good job!

Can I update Criterion to 0.3.0 directly? I'm worried that there might be some dependency concerns involved.
@brson @hicqu

According to my test, it's ok to update criterion to 0.3.

Seems the CLA is stuck but you have already signed it. xD


Support justinrainbow/json-schema version 6

Fixes https://github.com/DEVizzent/cebe-php-openapi/issues/20

@DEVizzent When will this PR reviewed and merged?

@DEVizzent When will this PR reviewed and merged?

@panvid Thank you for pinging me. I have to check my notification options, but I didn't realize about this MR.


Use similarity.tf() in MoreLikeThis

Description
MoreLikeThis picks terms by their TF-IDF score. The TF part of the score was used by taking the term frequency directly, without applying a square root through ClassicSimilarity.tf(). The result is that how common a term is in an input can have too much weight on whether it's selected as a search term. An example of a negative effect is that this can make more stop words make their way into the final query.
Tests
Ran MoreLikeThis tests with:
./gradlew -p lucene/queries test --tests TestMoreLikeThis

Thanks for taking look at this. The change makes sense and looks consistent in the usage of TFIDFSimilarity to me.
I think the problem is that we have no test corpus to measure the MLT search quality, so we can't directly know if taking square roots of raw term frequency improves the search quality. I'm not against the change at all, just can't estimate the possible effects of this change.

Thanks for taking a look @mocobeta - your comment makes sense. I have a dataset and have noticed the problem on it. I'll create a short analysis with examples.

@pminkov thank you for the thorough analysis!
Looking at the result, with this fix too common words do not appear, as expected, and too rare words still not be selected - so the result will be more balanced I think.

Here are the terms that are selected for each document: https://gist.github.com/pminkov/1432b04f794b97d1fc042ffc1ac0dce2

Could you attach the .txt file to this PR? It's a good reference for others and I think it'd be great to directly have it here.
I think the improvement in quality is clear now. On the other hand, MLT query is a very widely used feature, I've been thinking about having a bool parameter (say useRawTermFreq, maybe) to switch back to the old behavior so that we give users an option to stick to the old results if it's needed. We can set the default to false to use TFIDFSimilarity.tf(freq) for main (opt-out), and true for 9x (opt-in).

As for backward compatibility, my thought on that was slightly changed - let's commit this into main without adding extra configuration parameters if there are no objections, it's a major release anyway. I'll add a flag to opt-in for branch_9x when backporting (we would need to preserve the current behavior as default in 9.x).

i can try to do some tests this weekend (using query-expansion approach). i've just been busy with work and it is a bit time-consuming (need to find some external hard drives and so on)

I'll add a flag to opt-in for branch_9x when backporting (we would need to preserve the current behavior as default in 9.x).

why add flag? The similarity is already pluggable. So I think there is already plenty of configuration knobs. If someone is unhappy they can pass one that doesn't saturate tf?
mlt.setSimilarity(new DefaultSimilarity() {
  @Override
  public float tf(float freq) { return freq; }
});

But first, i'd like to try to measure any improvement. I'm just not able to do this during the week.

Thanks @rmuir for your suggestions.
I have a deadline myself this month so can't help in trying extensive experiments right now, but I'll try to be responsive here.

I haven't closely looked at the SimpleQQParser yet, but I imagine this measures something like the performance of pseudo relevance feedback?

It does not do this by default, but can be easily modified to do so... I have done it before. It is one way to measure how well the mlt is working relatively easily, albeit indirectly. At least it is a reasonable use of mlt, if numbers become very bad, we might want to investigate further.

Personally, I'd love to commit this to the upstream branch.
I think we'd need a reproducible quality check (or regression test?) in Lucene as Robert suggested; I just haven't been able to take enough time to look at it.

It looks like this PR is a nice improvement to MLQ quality, and we agree we should just enable it by default (Similarity can turn it off if the old way is really needed), and the PR is quite close?

I can reawaken it and get it to closure. I need to carve out time on Sunday unless someone else picks it up.

Is the idea for using SimpleQQParser that we would add another parse method, maybe parseWithMoreLikeThis that combines mlt and quality query parset to build a query or two separate queries that are then compared?


ValueError in diffusers dependency

After installing dependencies and models successfully, I receive this error when placing the MLOPS SD Pipeline node.
I am on windows 10 using Houdini 20.0.547 production build with houdini python 3.10.10
I tried previous versions on Houdini 19.5 with python 3.9 and was not able to get as far installing the the dependencies and models as I was on H20. Maybe it just fell behind over the holidays? It would be great if the readme had the exact versions of Houdini, python and git that are confirmed working. Thanks for any help!
Error
Invalid source /obj/txt2img/sd_solver1/solver.
(Error: Python error: Traceback (most recent call last):
File "<stdin>", line 52, in <module>
File "C:\dev/MLOPS/scripts/python\sdpipeline\image_solve.py", line 183, in run
noise_pred = unet(
File "C:\dev\MLOPS\data\dependencies\python\torch\nn\modules\module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "C:\dev\MLOPS\data\dependencies\python\diffusers\models\unet_2d_condition.py", line 956, in forward
sample, res_samples = downsample_block(
File "C:\dev\MLOPS\data\dependencies\python\torch\nn\modules\module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "C:\dev\MLOPS\data\dependencies\python\diffusers\models\unet_2d_blocks.py", line 1086, in forward
hidden_states = attn(
File "C:\dev\MLOPS\data\dependencies\python\torch\nn\modules\module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "C:\dev\MLOPS\data\dependencies\python\diffusers\models\transformer_2d.py", line 315, in forward
hidden_states = block(
File "C:\dev\MLOPS\data\dependencies\python\torch\nn\modules\module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "C:\dev\MLOPS\data\dependencies\python\diffusers\models\attention.py", line 218, in forward
attn_output = self.attn2(
File "C:\dev\MLOPS\data\dependencies\python\torch\nn\modules\module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "C:\dev\MLOPS\data\dependencies\python\diffusers\models\attention_processor.py", line 420, in forward
return self.processor(
File "C:\dev\MLOPS\data\dependencies\python\diffusers\models\attention_processor.py", line 1006, in __call__
batch_size, sequence_length, _ = (
ValueError: too many values to unpack (expected 3)
).

I am seeing the same error in the solver node inside the sd_solver. I am on H20.0.547 and macOS. I switched "coda" to "cpu" since I needed to do that on all nodes on Mac. But sd_solver still shows the error above. I was unable to find a solution so far.
Anybody any ideas?

Yep, very same issue here.

Were either of you able to find a fix yet?

I noticed that 'encoder_hidden_states' in 'attention_processor.py' is atleast part of the problem. I'm able to get the sd_pipeline node to generate an image using all the node defaults and prompts.
The error goes away when I comment out lines 1006-1008, and add the following line:

batch_size, sequence_length, _ = hidden_states.shape

I suspect the error happens because 'encoder_hidden_states' doesn't return a value, not even a value of 'None' when it has no value.  I don't know enough about how 'encoder_hidden_states ' is supposed to be handled, but hopefully this helps someone implement a fix.

cool thanks for the hint. I finally got around to take another look at this. You are right, I believe encoder_hidden_states is causing trouble here. We do need batch_size later in the code though, so I don't think we can just comment out the whole thing. I just replaced this:
batch_size, sequence_length, _ = (
hidden_states.shape if encoder_hidden_states is None else encoder_hidden_states.shape
)

with this:
batch_size, sequence_length, _ = hidden_states.shape
and that seems to work. I got an image in the sd pipeline example.

I had the same error. I reverted back to H19.5.805. Python3.9.13. MLOPS- v2.
Works now.

I had the same issue when attempting to run MLOPs v2 in Houdini 20.0.547.  Replacing each batch_size with the line from https://github.com/Bismuth-Consultancy-BV/MLOPs/issues/133#issuecomment-1891547890 worked.
For some reason, Houdini 19.5.605 will not work due to many python errors.  Hopefully this fix continue to keep H20 and MLOPs in a working state.

@howitzer99 Thanks! I also now have H20 working after editing

I had the same issue when attempting to run MLOPs v2 in Houdini 20.0.547. Replacing each batch_size with the line from #133 (comment) worked.

Seems to work! Thanks!

Latest commit fixed this!


[Bug]: The workspaces are getting created at random places instead at the bottom of workspace section

Is there an existing issue for this?

[X] I have searched the existing issues

Description
The workspaces are getting created at random places instead at the bottom of workspace section
Steps To Reproduce

go to https://ee-4987.dp.appsmith.com/
login as a google
in the home page
Click on create workspace
view the place where the workspace got created

Public Sample App
No response
Environment
Deploy Preview
Severity
High (Blocker to building or releasing)
Issue video log
No response
Version
deploy preview

@RakshaKShetty This is fixed, check the dp 4517.

@RakshaKShetty let's recheck and close if this is fixed.

@RakshaKShetty Closing this issue from our last conversation.


Large bundles with the generate-azure feature fail

If you try and translate a bundle with approx. 5000 characters it fails with the error:
Error: Failed to translate: The maximum request size has been exceeded.
Looking at the code, if you reduce the character limit down to say 4000 here https://github.com/microsoft/vscode-l10n/blob/main/l10n-dev/src/translators/azure.ts#L44
Then it works, however the resulting translations are then all mixed up.
With a small bundle, and no manual change to the character limit:
"Name": "Nome",
With a larger bundle, and a reduction of the character limit:
"Name": "Modificare la connessione",

Where is this string supposed to go, just so I know: Modificare la connessione

I'm thinking I'm just not handing large bundles well. I need to rework it. It's tough when Azure Translate only supports so much

The incorrect string was from a different text key that was sent to translation. So it was a correct translation, just from a different key to the one it gets matched to in the output files

@mikeburgh this should be fixed in the latest version of @vscode/l10n-dev, 0.0.34. Can you give it a try and let me know how it goes?

Thanks, on the road this week.. will test and confirm as soon as I get back

Tracking this as basic functionality as part of this https://github.com/microsoft/vscode-l10n/issues/154

I upgraded to the latest version, but still having issues with request size:
Error: Failed to translate: The server rejected the request because the client has exceeded request limits.
at batchTranslate (/dev/node_modules/@vscode/l10n-dev/dist/cli.js:631:17)


missing parent GO:0044695

Should GO:0044695 ! Dsc E3 ubiquitin ligase complex have a path to GO:0000151 ! ubiquitin ligase complex?

Hi Midori,
Done, thanks.
I think that @ukemi was going to work on ubiquitin-related complexes, so I'll leave this open for him so he knows. But, David, I assume you may close this ticket.
Thanks,
Paola


Remove NuGet.CommandLine

While updating a few needed nugets, i noticed PT Run has Nuget.CommandLine but nothing actually references it

[ ] PT Run needs to be updated
[ ] Installer needs to be updated

This is fixed in 0.53, get it at https://aka.ms/installPowerToys


Add coverage

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0fda6b2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   88.55%
=========================================
  Files             ?       22
  Lines             ?      367
  Branches          ?        0
=========================================
  Hits              ?      325
  Misses            ?       42
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fda6b2...35e920f. Read the comment docs.


Add the ablitity to create a Team Administrator

Haven't seen a real API for this, and I'd be interested in your take :wink:

Challenge accepted! :-)
Jokes aside, I don't know how to do it, but I agree it'd be a useful addition. I'll take a look at it.

This one also took a "bit" longer than I expected :-), but hopefully it's not "too little too late". PR #85 just fixed that. You might want to take a look at today's release.


Issaw bugfixes 10 4

Contributing guide
https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md
Changelog

Description of the change

Ship it!


Respect gitignore file even when not in a git repository

If a .gitignore file exists in a workspace, we currently only respect it
if we're also in a git repository. This is because of ripgrep's default
behavior. Pass an extra flag to ripgrep so that it always respects the
.gitignore file if it exists.
Fixes #182958

@microsoft-github-policy-service agree

Looks good! Haven't tested it quite yet, but could you fix the failing test here? https://github.com/microsoft/vscode/blob/efb49cc271d6eea5634ac395e36e1e4cd108a447/src/vs/workbench/services/search/test/node/ripgrepTextSearchEngineUtils.test.ts#L301
Seems that it's not passing CI.

@andreamah , the test should now be passing. Anything else needed to get this in?


Path parameter confusion when relying on routing priority

What version of Hono are you using?
3.12.3
What runtime/platform is your app running on?
Cloudflare Workers
What steps can reproduce the bug?
import { Hono } from "hono";

const app = new Hono();

app.get("/prefix/:a", (c) => c.json({ a: c.req.param("a") }));
app.get("/:a", (c) => c.json({ a: c.req.param("a") }));
app.get("/:b/:a", (c) => c.json({ a: c.req.param("a"), b: c.req.param("b") }));

What is the expected behavior?
Each of these routes should return proper responses according to the routing rules:

/prefix/hello matches the first route and returns { a: "hello" }
/hello matches the second route and returns { a: "hello" }
/another/hello matches the third route and returns { a: "hello", b: "another" }

What do you see instead?
What the third route actually ends up returning is
{
    "a": "another",
    "b": "another"
}

Additional information
This bug does not occur without the /prefix/:a route.

@ryanccn
Thanks for raising the issue. That's the bug of TrieRouter! I'll investigate it. Please wait a bit.

i create sandbox on stackblitz for this issue.
https://stackblitz.com/edit/stackblitz-starters-z45okh?file=index.js

I have confirmed the situation in this screenshot.
image

@ryanccn @EdamAme-x
I've fixed this issue and released v3.12.4, including the change. Try it.

It's working now! Thanks for the timely fix


Chinese is not supported

When the LDAP group information name is in Chinese, it will directly report an error and exit

Hi @mojie126 feel free to fork the github and submit a PR to deal w/ any charset issues with Chinese characters. In general the tool was never deployed to support full internationalization but we can take this as a future enhancement request but currently there is no ETA on when this may be delivered.


clean_up function runs if SUS is unavailable

If the Software Update Server can't be reached during runtime, the clean_up function will run and remove the LD and PLIST, thus resetting the Deferral-times.
Not sure what the smartest solution would be, maybe adding a test like this
Catalog=$(python -c 'from Foundation import CFPreferencesCopyAppValue; print CFPreferencesCopyAppValue("CatalogURL", "com.apple.SoftwareUpdate")')

if curl -s --head --request GET "$Catalog" | grep "200 OK" > /dev/null; then
   # Catalog is available, continue with cleanup
else
   # Catalog is unavailable, skip cleanup
fi

to either the clean_up function or even earlier in the process could help.

#19 should fix this

Fixed in #19.


Feature show image original dimensions in label

Hi,
I would like to add the feature to show the original dimensions of the image in label, something like logo.png - 128x128 pixels
It could be useful somewhat, i think.

Great idea! Thanks for the PR


Use of KeycloakVersion.of('XX.XX.XX') appends instead of replaces once keycloak stack used twice

I have a single repo where i initiated the Keycloak Stack 2 times. However what happens is the following:
  // part of DEV STACK
  new KeycloakStack(app, 'DevKeycloak', {
    env: awsEnvironments.test.env,
    keycloakVersion: KeycloakVersion.of('23.0.3'),
    // ... other config
  });

  // part of PROD STACK
  new KeycloakStack(app, 'ProdKeycloak', {
    env: awsEnvironments.prod.env,
    keycloakVersion: KeycloakVersion.of('23.0.3'),
    // ... other config
  });

Above results in 23.0.323.0.3 which breaks the deployment for ProdKeycloak (since there is the 2nd trigger of KeycloakVersion.of('23.0.3'))
        [ ] ],
        [ ] "Essential": true,
        [+] "Image": "quay.io/keycloak/keycloak:23.0.323.0.3",
        [ ] "LogConfiguration": {
        [ ]   "LogDriver": "awslogs",
        [ ]   "Options": {

I just ran into this issue but I only have one instance of Keycloak in my stack:
const keycloak = new KeyCloak(stack, "KeyCloak", {
  hostname,
  certificateArn: certificate.certificateArn,
  keycloakVersion: KeycloakVersion.V22_0_4,
});

It looks as though this problem likely impacts most uses cases, as the version is borked even in the test snapshots:
https://github.com/aws-samples/cdk-keycloak/blob/1b33a79ea1e7130b97095633241281af782fb3ed/test/__snapshots__/integ.snapshot.test.ts.snap#L697


Split OneDrive 2.3 into two policies

💡 Summary
Split and clarify the current OneDrive 2.3 baseline v.0.1 policy "Link Permissions SHOULD Be Set to Enabled Anyone Links to View" into two separate policies to make it easier for readers to understand and for automation to report.
Motivation and context
The current baseline policy is a solid best practice, but the wording does not make it clear that there are two separate settings needed to properly protect links: one to make the default sharing link only be to others within the organization (i.e., not anyone) and a second to make sure when a user does make a link available to anyone that the default permissions on that link are view only.
This would be useful because right now the baseline does reference the Microsoft best practice that includes both settings, but the implementation section 2.3.4 in the baseline itself only shows the setting changes to address the view only portion.
Implementation notes
Recommended update would be to split this policy into two policies to address both the default link sharing type and the anyone link default permissions. Both policies would still include references to the same Microsoft best practices document, but the implementation details would differ.
The new policies would be something like the following:
2.3 Default Link Sharing Type SHOULD NOT Be Set to Anyone
If Anyone link sharing is enabled, the default when creating a link is set to Anyone. Providing a more secure default option can mitigate unintentional sharing with unauthenticated anonymous third parties. To do so, set the default sharing type to be limited to people within your organization instead.
The implementation details would then be as follows:
To set the default file and folder sharing link for the organization:

Open the SharePoint admin center, and select Sharing.
Under File and folder links, select Only people in your organization or Specific people (only the people the user specifies).
Select Save

2.4 Anyone link permissions SHOULD be Set to View Only
The implementation section would include instructions

Open the SharePoint admin center.
In the left-hand navigation pane, expand Policies, then select Sharing.
Under Advanced settings for Anyone links, set the Files permissions to View.
Under Advanced settings for Anyone links, set the Folders permissions to View.

Acceptance criteria
How do we know when this work is done?
Updated policy has the changes noted in Implementation notes.

I checked the Emerald branch and it appears that this work has been incorporated into the baseline. Please check and close this if appropriate.
The new policies in the baseline that seem to align with this issue are below:
MS.SHAREPOINT.2.1v1
File and folder default sharing scope SHALL be set to Specific People (only the people the user specifies).
MS.SHAREPOINT.3.2v1
The allowable file and folder permissions for anyone links SHALL be set to View only.


Add AMP Error check to PPC

Adds a new check to the checklist for stories that are published that will show a checklist priority card if there are AMP errors not covered by other checks present in the story.
Includes a link in copy to go test the story URL to get more details externally.
See epic for more info.

@csossi  there's testing instructions in the PR

hey @csossi - any update on QA for this?

Verified in QA


Clarify the version of PE used

I believe this profile uses basic PEv1 capabilities + only SIOP optimized capabilities in PEv2 - which would be a specific commit within PE v2

@Sakurann will add clarification in a pr

It's PE v1 adding only the ability to add formats to input descriptors:

The Input Descriptor Object MAY contain a format property. If present, its value MUST be an object with one or more properties matching the registered Claim Format Designations (e.g., jwt, jwt_vc, jwt_vp, etc.). This format property is identical in value signature to the top-level format object, but can be used to specifically constrain submission of a single input to a subset of formats or algorithms.


Move from console args to config file

Try to marry customer feedback with config file generation...

Change -s and -a to optional instead of required.  Add logic to skip sections if missing from config.


feat: Allow nyc instrument to instrument code in place

This PR addresses #1135
This change adds the --in-place switch to nyc instrument
If --in-place is specified, the output directory will be set to equal the input directory for the instrument command.
This has the effect of replacing any file in the input directory that should be instrumented, with its instrumented counterpart.
The command will throw an error if the --delete option is specified.
The only way to instrument in place is with the --in-place switch, setting the input and output directories to be the same will not work
If --in-place is set the instrument command ignores any output directory specified with the command
If --in-place is set the instrument command will disable the --complete-copy switch as it is unnecessary.
I've made a few small code improvements to the instrument command spec.
I've also added tests to the old integration tests folder, I figured I could put tests here for the time being before they get moved to the new tap format (by me or someone else).

Just a quick note that the I'm aware that this breaks the test snapshot and you probably don't want additions to the old integration test file.  Since I'm a little low on time at the moment I figured that it'd be good to get this out there and it'd be quicker to make tests for the old integration set that I'm familiar with.  Anyway let me know what needs to be done from here, thanks

Additional note the snapshots getting broken by this test is actually referenced in #1096.  I just haven't had time to tweak those tests which use --all to use an isolated directory.

Coverage increased (+0.4%) to 97.854% when pulling bfd6e62e01dbc819926cbe5a9184ae895749def4 on AndrewFinlay:instrument-overwrite into e94e2e75d27c10afac4646ff6822bcefe7e8aa7b on istanbuljs:master.


Remove OIDC Endpoints from 'Info' Section in M2M Applications

Is your suggestion related to an experience ? Please describe.
Currently the info section in M2M application displays the OIDC related endpoints. Since M2M applications don't involve direct user participation and uses client credential grant, the endpoints should be removed from the info tab

Fixed with: https://github.com/wso2/identity-apps/pull/5970


Push TransactionPlan into WitnessRequest RPC

Is your feature request related to a problem? Please describe.
See https://github.com/penumbra-zone/penumbra/issues/1555
In #1568, the Rust wrapper around the protobuf RPC was changed to take a TransactionPlan, but this change wasn't pushed out into the actual RPC. So the problem that #1555 describes is still present for any user of the view protocol who doesn't use the Rust wrapper. (In general, we should aim to have that wrapper trait just do conversions between domain and proto types, and not more complicated logic).
Describe the solution you'd like
Push the TransactionPlan into the WitnessRequest proto, and move the logic currently in the wrapper trait into the view service itself.

From planning meeting today: @aubrika can you prioritize this over the ongoing work in https://github.com/penumbra-zone/penumbra/pull/1663 ? The changes requested here are (hopefully) rather mechanical and can be ground out in an afternoon. (Famous last words. <3)

To perform the dummy proof generation in the service itself, do you think it is better to add an Rng field to the service or as a parameter to the witness function specifically, or is it alright to have non-deterministic generation for the dummy proofs as so:

Yeah, having non-deterministic dummy proofs seems fine, they're fake padding data anyways so I'm not sure what benefit there is to having them be deterministic.


Further cleanup addressing more copied code

Extract an interface with default method implementations common to the strategy and the properties (as opposed to the existing one that only did code common to properties), an interface for their descriptors, and a new abstract converter.
Untested.

Fixes JENKINS-46923

Merging to get a beta-2 out, further feedback is always appreciated @oleg-nenashev


Update create-or-configure-an-availability-group-listener-sql-server.md

Minor format for code example.

@PhilipBarry : Thanks for your contribution! The author(s) have been notified to review your proposed change.

confirm correction


Allow --dev to run without wasm

There isn't any point to build wasm if we want to run with --dev, however if an empty wasm code was provided, the node will fail with Error: Service(Client(Execution(Other("InvalidModule")))).
Is it possible to defer the Wasm code validation on when the client is actually attempting to invoke the wasm executor? So for native execution mode, no wasm validation is needed (so that I can pass a dummy wasm instead to build a valid one).

This will not be supported. Wasm execution is one of the main point of Substrate and we need to check if the Wasm spec_version is compatible to the native spec_version. This is the reason we need to have the Wasm code available. However you could provide some dummy wasm binary that only exports Core_version and exports the correct version.

That will work. Can you reopen this and make this to improve the generated dummy wasm so it exposes Core_version?
I guess some other work are needed so we can get spec_version easily. Now we are using crates version for pallet version, maybe we can do similar thing for spec_version? Use the value from Cargo.toml instead of configure it in source code?

No, if you need this kind of stuff, implement it. The "dummy wasm" is just Code = None. This is no code and I clearly don't want to invest in building more stuff to bloat this up for a very niche use case.


use the resque branch with better logging

Trying to figure out what's up in prod

used this, but no need to merge at this point


fix: Charge fees on calculated settlement amount

After reviewing our initial approach, it turns out there is no easy way of achieving enforced fee payment without any rust-dlc changes. To simplify things I've reverted the corresponding change impacting the payout curve and margins.
A proper solution should be tackled with #250.

The payout function is incorrect either way. Closing this PR as it doesn't make it better. #250 should get prioritized!


Fix misleading pegout logs and variables

Update misleading pegout logs with meaningful log messages according to the context.
Also, update misleading pegout variable names with meaningful names according to the context.

pipeline:run


Update Lock up seed phrase illustration

https://github.com/AlphaWallet/alpha-wallet-ios/issues/1701

I have just updated this illustration. Please overwrite the existing one.

Fixed in #1258


Possibility to convert a line into a node

It would be nice to have a possibility to convert a line into a node preserving all tags.
I envision as

dragging a node from a line with some modifier key pressed
merging all line nodes into one or deleting all but one line nodes.

I think we could implement #3774 in a way that handles "merging all line nodes into one".

@bhousel #3774 is a totally different thing.
@yaugenka Doesn't #839 cover your usecases?

merging all line nodes into one or deleting all but one line nodes.
Doing it silently would generate much gartbage, especially in case the remaining node is connected to a different way.

Deleting a way with valuable tags (e.g. not just a feature type), iD should generate some kind of warning anyway to avoid deleting valuable information accidently. This warning could offer a copy tags button. This way we can make the warning to appear as a userfriendly wizzard.

@slhh Yes, the copy-pasting feature as discussed in #839 would let achieve the same result but with extra steps.
Compare the case with copy-pasting:

copy tags from a line
create a node
paste the tags into the node
delete the line

to the suggested alternative: just drag a node from a line with some modifier pressed.

merging all line nodes into one or deleting all but one line nodes.

Currently the line gets deleted silently and a node with not tags is create, so I agree, there should be at least some warning generated.

BTW it would also be nice to have a possibility to convert a node into a line with all tags copied. This one should be much simler via an extra "+" menu item (same as "continue line" for a line-ending node).

iD mostly doesn't let users switch geometry because it usually doesn't make sense to do so.
You wouldn't want people to easily or accidentally create a single node highway=residential or linear amenity=drinking_water, etc.  Obviously advanced mappers can create stuff like this by editing the raw tags, but we try to guide users towards creating features that make sense.  This is why iD's preset system uses geometry as a primary criterion for matching an OSM entity to a preset.  We don't want new mappers to have to think about whether the features they draw make logical sense.
Additionally, I have said this before, but I don't see a point to preserving feature history in most cases.  It's nice to do, but aside from a few people who run statistical analysis tools, nobody cares about this.  It's totally fine to delete and redraw things.
I'm closing this because it's not clear to me why anybody would want to convert a point to a line or a line to a point.  I'm willing to reopen if anyone can suggest a situation where they have actually needed this feature.

Expand place node into an area and collapse place area into locality node.

Node to area isn't something this issue would address, as it's about lines to nodes. It's already possible to turn a node into an area, draw an area, select both, and merge.


load odm result and create dataset

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.044%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
18535

Relevant Lines:
23449

💛  - Coveralls

 ODM in Geo Engine integrieren: Wie?


Update Json.NET

https://www.nuget.org/packages/Newtonsoft.Json/8.0.4-beta1
Targets netstandard1.0 - no more imports!

Is there a reason it's still a beta version?

FYI, JSON.NET is also used by a few other ASP.NET Core/.NET Core projects (e.g the OAuth2/OIDC middleware or IdentityModel). That would be great to update it everywhere at the same time to avoid package resolution warnings during dotnet restore :smile:

Yes, we will update it across as much as possible.
See https://github.com/dotnet/cli/issues/3198 for some info regarding some issues we have to resolve.

Done. Here is the command I used to verify that we updated all our dependencies across repos. Clone universe, run build pull and then Get-ChildItem -Recurse project.json | select-string "Newtonsoft"

@javiercn build pull doesn't pull a number of repos. One of them that does use Json.NET is Coherence.
Suggest using build pull-all instead. Probably also need to double-check at least the Performance repo.

I didn't know about pull-all. At least everything we need to build the product is in pull. I'll try pull all later and update any missing dependency, thanks for the tip!

@dougbu Did a pull all, the only one not in 9.0.1 was Coherence\src\CoherenceBuild\project.json:7:    "Newtonsoft.Json": "8.0.3", so it's fine

@javiercn suggest a PR to make Coherence consistent. It's low-priority but we don't have a reason to stick w/ 8.0.3.

@dougbu it's already ipsa


Changing the enchantment level: Is it possible?

why do the spells disappear by increasing the levels in the configs?
I change their minimum and maximum level in the configs for some enchantments (yes, increasing them at times), and in the game when I try to enchant in the table, these charms simply disappear, or rather the table does not give me these charms. Is this normal or not? By the way, the level I enter is in the range 1-127, (for example, the minimum level of some charms was 10, and the maximum was 30, 40, 50 or 80). I put 0 on some charms, but they are still charmed, although only the 1st level
Version 1.15.2

I don't really know what it is that you're asking, but 1.15 is not supported.


WIP: Deploy container instances in separate ASGs

This commit splits the one-ASG-with-three-instances into
three-ASGs-with-one-instance-each.
The goal I am going for with this commit is: we need to be able to
tell each separate prometheus service
aws_ecs_service.prometheus_server to run on a separate instance.  I
would also like to make our code flexible enough that dev environments
can run one single instance, and staging and production could scale
down to 2, or up to 4 (with two prometheis in a single AZ), if desired.
I had considered telling the services to run with placement contraints
pinning each prometheus service to a specific availability zone.
However, if there are only 1 or 2 instances, then some of the AZs will
be empty, and pinning a service to that AZ will mean it can never run
at all.  Moreover, there's no clean way to know which AZs are
available.  Finally: if an instance in an ASG dies, will the instance
that replaces it be in the same AZ, or could it come back in a
different one?
I thought a better way of doing this would be to set an explicit
placement attribute in the ECS agent for each instance.  In order to
do this, each instance needs to be created by a separate ASG (because
an ASG has a single user data script, and the user data script sets up
the ECS agent settings).  Now we can pin prometheus services to
specific instances using the custom prometheus-instance attribute,
and have confidence that those specific instances exist.
Unfortunately, terraform modules don't currently support the count attribute,
so the only way to have multiple ASGs using this module
is to copy/paste the module multiple times.  This feels like the
least-worst option to me.  (In future, to scale up we would need to
copy/paste more.  To make the number of instances configurable, we can
make each ASG conditional based on the desired number of instances.
For details, see the module docs.)
This has a side benefit that we can now specify the exact volume id in
user data again, rather than doing the trick where we grab a list of
volumes from the API and select the one that's in the same AZ as
us.  (This also enables us to deploy multiple instances in the same AZ
in future if we want.)
In order to be certain that we're pairing up availability zones,
private subnets, ASGs and volume ids correctly, I introduced a
data.aws_subnet.private_subnets data source, and pull availability
zone config from there to configure the aws_ebs_volumes.  This means
we can be confident that the EBS volume is in the same AZ as the ASG
it's paired with.
Note that the number 3 is still hardcoded throughout
app-ecs-instances/main.tf; actually making things configurable will
come in future commits.
I'm issuing this as a PR on its own, even though it isn't the whole multi-AZ story, for a number of reasons:

it's big enough by itself and worth making visible
I want to deploy this change and ensure that the ECS attributes are present on the instances before deploying any changes that rely on those attributes

To maybe make things clearer, this commit is laying the groundwork so that something like 4325c27 can pin ECS tasks to specific EC2 instances.

Marking as WIP while I explore an alternative solution that doesn't involve splitting the ASG

closing in favour of #40


Create Diagram of the Dormant Users Process

User Need
As a Operations Engineering Team Member
I want to easily understand the Dormant Users Process
so that I can effectively resolve issues and improve the process
Value
Help existing and new team members understand the Dormant Users Process
Functional Requirements:

Visualises the AS IS Dormant Users Process(es)

Non-Functional Requirements:

Easy to understand

Acceptance Criteria:

[ ] A diagram has been created that visualizes the Dormant Users Process

Notes:

🆙 Update

Started the diagram with @imkatiewatson - which can be found here

I've taken a slightly different approach to the diagram. I've outlined the process in a workflow diagram.
https://drive.google.com/file/d/1L2-Kx_TFTAcXj5gfRuGp4Shc7gL3LewU/view?usp=sharing

@connormaglynn, do you have any thoughts on what's captured here?

Just had read through of the runbooks Dormant User Steps and yes this nice flow diagram is much easier to understand! I'm assuming the detail of what to to rename stuff doesn't name to be here. How does the GitHub Dormant Users export deal with the 2 different orgs? Ie can you run through this on an org basis or it is both orgs; do you always need to generate the People Page Export for both orgs?

It's a fair point, @tamsinforbes. Both orgs' People Page need to be exported, but not "Dormant Users" as this is an Enterprise-level export. I can make the People Page export a parallel process - I think it's double lines in UML. I'll change it and let you know what it looks like.

Parallel should read concurrent

Not super attractive

It's OK, it indicates better what is happening; it is weird that we have one process that acts at an enterprise level and the others at the individual org level; perhaps there is a way to get the people page info for the enterprise so in one step rather than 2 (when we come to automate this)

I'm going to mark this issue as resolved, as we have a diagram that accurately outlines the "known" process for deleting dormant users.


Add missing config file sync feature to the README

Pull Request Test Coverage Report for Build 505587553

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+74.8%) to 74.787%

Totals

Change from base Build 505576112:
74.8%

Covered Lines:
439

Relevant Lines:
587

💛  - Coveralls

Pull Request Test Coverage Report for Build 505587553

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+74.8%) to 74.787%

Totals

Change from base Build 505576112:
74.8%

Covered Lines:
439

Relevant Lines:
587

💛  - Coveralls


Processing style attribute

In svg, we can used style attribute:
<path style="stroke-width: 4px; stroke-dasharray: 12px, 6px;" d="M62.9 14.9c-25-7.74-56.6 4.8-60.4 24.3-3.73 19.6 21.6 35 39.6 37.6 42.8 6.2 72.9-53.4 116-58.9 65-18.2 191 101 215 28.8 5-16.7-7-49.1-34-44-34 11.5-31 46.5-14 69.3 9.38 12.6 24.2 20.6 39.8 22.9 91.4 9.05 102-98.9 176-86.7 18.8 3.81 33 17.3 36.7 34.6 2.01 10.2.124 21.1-5.18 30.1" fill="none" stroke="#ffffff"></path>

Although we can direct writing:
@svg path {
  @path {
    stroke-width: 4px;
    stroke-dasharray: 12px, 6px;
  }
}

But also we need a syntax to directly convert style attribute.
cc @tabatkins

...why do you need that? Like you said, you can just write them directly.

Thankfully, this functionality is already available to us.
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-width
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-dasharray


🐛 Lens switching 'broken' on iOS 18

What's happening?
Since upgrading to iOS 18, we are seeing a regression in lens switching behavior. It only switches lenses once when using a virtual device, but doesn't switch back, or is almost impossible to get to switch back. We verified this also happens in the ShadowLens demo app. Try getting close to an object, the lens switches, then move back away until the lens switches again. From that point on, it's impossible to get closer without the image being blurry (the lens doesn't switch back anymore).
Reproduceable Code
No code involved here, just a default triple back camera virtual device.

Relevant log output
-

Camera Device
{
    "formats": [],
    "hardwareLevel": "full",
    "hasFlash": true,
    "hasTorch": true,
    "id": "com.apple.avfoundation.avcapturedevice.built-in_video:7",
    "isMultiCam": true,
    "maxExposure": 8,
    "maxZoom": 123.75,
    "minExposure": -8,
    "minFocusDistance": 2,
    "minZoom": 1,
    "name": "Back Triple Camera",
    "neutralZoom": 2,
    "physicalDevices": [
      "ultra-wide-angle-camera",
      "wide-angle-camera",
      "telephoto-camera"
    ],
    "position": "back",
    "sensorOrientation": "portrait",
    "supportsFocus": true,
    "supportsLowLightBoost": false,
    "supportsRawCapture": false
  }

Device
iPhone 14 Pro (18.0.1)
VisionCamera Version
4.5.3
Can you reproduce this issue in the VisionCamera Example app?
Yes, I can reproduce the same issue in the Example app here
Additional information

[X] I am using Expo
[ ] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

@mrousavy Marc, curious to hear if you have observed this as well on iOS 18. Getting XCode logs is a bit more involved, as I'm just seeing this using the ShadowLens app from the app store as well, and I use Expo so I don't run my RN projects through XCode. Lmk if you need any additional information!

You can run your Expo app through Xcode as well. Without logs, I cannot help.
This clearly needs a video demo as well

I'm having the same issue, although I don't know if iOS 18 is a factor in my case.
minZoom is being reported as 1, same as neutralZoom, and I don't see a way to switch to wide angle.
@mrousavy If you can point me to instructions on how to run my Expo project through Xcode and get those logs, I will post them. I'm afraid I haven't done this before.

tbh I am almost 100% sure that this is expected iPhone behaviour. There is nothing I can do about it.

tbh I am almost 100% sure that this is expected iPhone behaviour. There is nothing I can do about it.

I understand, but it would be unfortunate if there was no way to use the wide angle lens with react-native-vision-camera. Just to clarify, is that the case?


Support Keenhome.io variant's pressure data

Updated read attribute handling pressure calcs to additionally support attrId "0020", in order to make this handler suitable for the Keenhome.io variant of this device.

I looked over the code changes and it looks fine to me - Thanks for this!
I had no idea that any Xiaomi devices had been re-purposed for use in a different custom-hub solution as Keen Home is doing. They must be making good profit charging $40 US for a sensor that Xiaomi sells for $15!
Since I don't own one myself - can you confirm that all other functions (temperature / humidity / battery) of the Keenhome.io sensor variant work correctly with the Aqara Temp-Humidity Sensor SmartThings device handler?

Battery reporting doesn't seem to work on these units, since I see zero battery "catchall:" messages in the debug log.  temp, humidity and pressure are all working.  I have seen some odd "network issue" messages whenever I go to the "Recents" tab in the device UI in the app, but it seems to be an innocuous error since I'm seeing continuous temp/humidity/pressure events.
One point to note: I am running a v1 hub, thought I don't think that will make a difference.
Thanks,
Paul

From: Keith G<EMAIL_ADDRESS>Sent: Tuesday, July 17, 2018 4:01 PM
To: bspranger/Xiaomi
Cc: Gr1mR3aver; Author
Subject: Re: [bspranger/Xiaomi] Support Keenhome.io variant's pressure data (#119)
I looked over the code changes and it looks fine to me - Thanks for this!
I had no idea that any Xiaomi devices had been re-purposed for use in a different custom-hub solution as Keen Home is doing. They must be making good profit charging $40 US for a sensor that Xiaomi sells for $15!
Since I don't own one myself - can you confirm that all other functions (temperature / humidity / battery) of the Keenhome.io sensor variant work correctly with the Aqara Temp-Humidity Sensor SmartThings device handler?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbspranger%2FXiaomi%2Fpull%2F119%23issuecomment-405726410&data=02|01||293c90c8b50745a7aba008d5ec2866ee|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636674580615629775&sdata=dfB5CKVOzsFlYb0f%2B3j%2FXPd9VnXhU%2F%2FGcPMK4gV9Wow%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWGnYjR-9FppJ-k-mXJOkjmiGz_Slm3Zks5uHlCLgaJpZM4VOLQu&data=02|01||293c90c8b50745a7aba008d5ec2866ee|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636674580615629775&sdata=8vXPJOgT8odoB9pt7n6%2BevkBCl%2BsE8E3rAbn4%2BdlTbQ%3D&reserved=0.


opcpublisher disconnected due to Communication_Error - now Disconnected_Retrying...

OPCPublisher is unable to connect to OPC-UA Server and is raising an error:
[19:47:41 INF Root] Starting module OpcPublisher version <IP_ADDRESS>.
[19:47:41 INF Root] Initiating prometheus at port 9702/metrics
[19:47:41 INF Root] Prometheus metric server started.
opcstacktracemask set to: 0x0
[19:47:41 WRN Microsoft.Azure.IIoT.Module.Framework.Client.IoTSdkFactory] Bypassing certificate validation for client.
[19:47:41 INF Microsoft.Azure.IIoT.Module.Framework.Client.IoTSdkFactory] Running in iotedge context.
[19:47:46 INF Microsoft.Azure.IIoT.Module.Framework.Client.IoTSdkFactory] 0: Module _opcpublisher disconnected due to Communication_Error - now Disconnected_Retrying...
We checked connectivity between IoT Edge and OPC UA Server and it was successful. We are using ip address to connect for OPC UA Server. However OPC Publisher seems to have a challenge and we are unable to resolve.
iotedge check
Configuration checks (aziot-identity-service)
√ keyd configuration is well-formed - OK
√ certd configuration is well-formed - OK
√ tpmd configuration is well-formed - OK
√ identityd configuration is well-formed - OK
√ daemon configurations up-to-date with config.toml - OK
√ identityd config toml file specifies a valid hostname - OK
‼ aziot-identity-service package is up-to-date - Warning
Installed aziot-identity-service package has version 1.2.4 but 1.2.5 is the latest stable version available.
Please see https://aka.ms/aziot-update-runtime for update instructions.
√ host time is close to reference time - OK
√ preloaded certificates are valid - OK
√ keyd is running - OK
√ certd is running - OK
√ identityd is running - OK
√ read all preloaded certificates from the Certificates Service - OK
√ read all preloaded key pairs from the Keys Service - OK
√ ensure all preloaded certificates match preloaded private keys with the same ID - OK
Connectivity checks (aziot-identity-service)
‼ host can connect to and perform TLS handshake with iothub AMQP port - Warning
Could not retrieve iothub_hostname from provisioning file.
Please specify the backing IoT Hub name using --iothub-hostname switch if you have that information.
Since no hostname is provided, all hub connectivity tests will be skipped.
‼ host can connect to and perform TLS handshake with iothub HTTPS / WebSockets port - Warning
Could not retrieve iothub_hostname from provisioning file.
Please specify the backing IoT Hub name using --iothub-hostname switch if you have that information.
Since no hostname is provided, all hub connectivity tests will be skipped.
‼ host can connect to and perform TLS handshake with iothub MQTT port - Warning
Could not retrieve iothub_hostname from provisioning file.
Please specify the backing IoT Hub name using --iothub-hostname switch if you have that information.
Since no hostname is provided, all hub connectivity tests will be skipped.
√ host can connect to and perform TLS handshake with DPS endpoint - OK
Configuration checks
√ aziot-edged configuration is well-formed - OK
√ configuration up-to-date with config.toml - OK
√ container engine is installed and functional - OK
√ configuration has correct URIs for daemon mgmt endpoint - OK
‼ aziot-edge package is up-to-date - Warning
Installed IoT Edge daemon has version 1.2.5 but 1.2.7 is the latest stable version available.
Please see https://aka.ms/iotedge-update-runtime for update instructions.
√ container time is close to host time - OK
‼ DNS server - Warning
Container engine is not configured with DNS server setting, which may impact connectivity to IoT Hub.
Please see https://aka.ms/iotedge-prod-checklist-dns for best practices.
You can ignore this warning if you are setting DNS server per module in the Edge deployment.
caused by: Could not open container engine config file /etc/docker/daemon.json
caused by: No such file or directory (os error 2)
‼ production readiness: container engine - Warning
Device is not using a production-supported container engine (moby-engine).
Please see https://aka.ms/iotedge-prod-checklist-moby for details.
‼ production readiness: logs policy - Warning
Container engine is not configured to rotate module logs which may cause it run out of disk space.
Please see https://aka.ms/iotedge-prod-checklist-logs for best practices.
You can ignore this warning if you are setting log policy per module in the Edge deployment.
caused by: Could not open container engine config file /etc/docker/daemon.json
caused by: No such file or directory (os error 2)
‼ production readiness: Edge Agent's storage directory is persisted on the host filesystem - Warning
The edgeAgent module is not configured to persist its /tmp/edgeAgent directory on the host filesystem.
Data might be lost if the module is deleted or updated.
Please see https://aka.ms/iotedge-storage-host for best practices.
× production readiness: Edge Hub's storage directory is persisted on the host filesystem - Error
Could not check current state of edgeHub container
caused by: docker returned exit code: 1, stderr = Error: No such object: edgeHub
‼ Agent image is valid and can be pulled from upstream - Warning
skipping because of previous failures
Connectivity checks
‼ container on the default network can connect to upstream  AMQP port - Warning
skipping because of previous failures
‼ container on the default network can connect to upstream HTTPS / WebSockets port - Warning
skipping because of previous failures
‼ container on the default network can connect to upstream MQTT port - Warning
skipping because of previous failures
‼ container on the IoT Edge module network can connect to upstream AMQP port - Warning
skipping because of previous failures
‼ container on the IoT Edge module network can connect to upstream HTTPS / WebSockets port - Warning
skipping because of previous failures
‼ container on the IoT Edge module network can connect to upstream MQTT port - Warning
skipping because of previous failures
20 check(s) succeeded.
9 check(s) raised warnings.
1 check(s) raised errors.
7 check(s) were skipped due to errors from other checks.

This publisher logged error:

[19:47:46 INF Microsoft.Azure.IIoT.Module.Framework.Client.IoTSdkFactory] 0: Module _opcpublisher disconnected due to Communication_Error - now Disconnected_Retrying...

refers to the upstream connectivity to the IoT hub. It has nothing to do with the connectivity to the OPC UA Server.
To me it looks like the IoT Edge runtime is not running properly. If troubleshooting/reinstalling the runtime does not help, I would recommend you try with IoT edge 1.1 (LTS) as well.

Thank you @cristipogacean. You are correct. it was a problem with edgeAgent and as we debug we found the issue and got it resolved.... OPCPublisher is working fine now.


Use Gov Notify for Collaborator Related Emails

Background

We are considering using Notify for the GH Collaborator Notifications. Instead of the standard GH notifications an owner would receive an email via the Notify service.
It is felt that users may act upon an email that looks more "official" and engage more with the process of extending review bay dates.
We have no data to support this assumption and we view this story at nice to have.
Approach

Replace current email notifications with the Notify service.
Questions / Assumptions

Acceptance Criteria

[ ] Create a template for notifications
[ ] Set up notify service for Collaborators

Reference
How to write good user stories

Duplicate.