Interrupt on no target should be off by default or settable

When using a distance threshold mode the interrupt also gets triggered when there is no target or the target is out of range. This is in usually not intended e.g. if used as an external wake up source if a target is entering the allowed window.
The according parameter in the API function is defaulted to 1 by the abstraction (see code below), which enables the "out of window" interrupts.
In my opinion this should be set to 0 by default or settable.
Current code:
void SFEVL53L1X::setDistanceThreshold(uint16_t lowThresh, uint16_t hiThresh, uint8_t window)
{
	_device->VL53L1X_SetDistanceThreshold(lowThresh, hiThresh, window, 1);
}

Proposed correction:
void SFEVL53L1X::setDistanceThreshold(uint16_t lowThresh, uint16_t hiThresh, uint8_t window)
{
	_device->VL53L1X_SetDistanceThreshold(lowThresh, hiThresh, window, 0);
}

Please pull the library and check Example 8. Cheers!


Write Tests For The Endpoint

Description
Please include a summary of the change and relevant motivation and context.
I wrote the tests for the teacher endpoints
List any dependencies that are required for this change.
supertest
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added necessary inline code documentation
[x] I have added tests that prove my fix is effective and that this feature works
[x] New and existing unit tests pass locally with my changes

Nice work


df.sample() much slower than df.iloc[randint]

It seems like the Dataframe sample function is much slower than directly selecting a randomly indexed row:
import pandas as pd
import numpy as np
from time import time

test_df = pd.DataFrame(np.random.randint(0, 100, size = (400, 600)))
def f():
...  start = time()
...  for _ in range(100):
...   test_df.sample()
...  print(time() - start)
...
def g():
...  start = time()
...  for _ in range(100):
...   test_df.iloc[np.random.randint(0, test_df.shape[0])]
...  print(time() - start)
...
f()
0.571173906326
g()
0.0156011581421

these are not the same thing.

.sample takes the the number of rows (when axis=0, the default), in this case its 1
.sample uses np.random.choice which allows replacement (or not), default is not to replace

This takes about 5ms not sure this can actually matters anyhow.


[DCR] make DialogContext a field of turnContext

This is a requirement came from the LG debugging experience.
Today we do debugging instrumentation in the base class AdaptiveDialog, where have access to the DialogContext, but we don't have access to DialogContext (do we?) when executing a specific action, for example, a SendActivity action, which have LG text to debug with.
Ideally we want have access to DialogContext, and attach with the LG context returned in LG evalution and send them to debugger.
Since we only have access to turnContext in executing actions, i wonder if can make DialogContext a property of turnContext?

I would recommend either:

Pushing DialogContext as service via turnContext.TurnState.Get() (this would probably require DCR #3577 to be done correctly)
Changing ActivityTemplate data binding method to allow passing a Dialogcontext, and plumbing that all the way into LG as optional method signature.

We are going to do #3577, so this DCR is rejected.


Daikatana

Project link: https://bitbucket.org/daikatana13/daikatana/src/master/
Project license: Unknown
Does it work on 64-bit only Linux: MAYBE
Is source code available?: NO
Is source code stored in Git?: NO
List of Steam AppIds of supported games:

https://steamdb.info/app/242980/

Additional information
https://www.gamingonlinux.com/articles/you-can-play-controversial-fps-daikatana-on-linux-now-thanks-to-a-fan-patch-endorsed-by-john-romero.7674

Added support in https://github.com/luxtorpeda-dev/packages/pull/188
Let me know if you run into issues.

Added support in https://github.com/luxtorpeda-dev/packages/pull/188
Let me know if you run into issues.


Unintended retention of old MPI values if mbedtls_mpi_fill_random fails

There are 5 places in the library where mbedtls_mpi_fill_random is called, but its return value isn't checked:

mbedtls_dhm_make_params
mbedtls_dhm_make_public
dhm_update_blinding
ecp_randomize_jac
ecp_randomize_mxz

The function itself is defined as follows:
1866 int mbedtls_mpi_fill_random( mbedtls_mpi *X, size_t size,
1867                      int (*f_rng)(void *, unsigned char *, size_t),
1868                      void *p_rng )
1869 {
1870     int ret;
1871     unsigned char buf[MBEDTLS_MPI_MAX_SIZE];
1872
1873     if( size > MBEDTLS_MPI_MAX_SIZE )
1874         return( MBEDTLS_ERR_MPI_BAD_INPUT_DATA );
1875
1876     MBEDTLS_MPI_CHK( f_rng( p_rng, buf, size ) );
1877     MBEDTLS_MPI_CHK( mbedtls_mpi_read_binary( X, buf, size ) );
1878
1879 cleanup:
1880     return( ret );
1881 }

f_rng can fail due to entropy shortage, memory shortage, or for any other reason if a custom RNG implementation is used for f_rng.
mbedtls_mpi_read_binary can fail due to memory shortage:
 667 int mbedtls_mpi_read_binary( mbedtls_mpi *X, const unsigned char *buf, size_t buflen )
 668 {
 669     int ret;
 670     size_t i, j, n;
 671
 672     for( n = 0; n < buflen; n++ )
 673         if( buf[n] != 0 )
 674             break;
 675
 676     MBEDTLS_MPI_CHK( mbedtls_mpi_grow( X, CHARS_TO_LIMBS( buflen - n ) ) );
 677     MBEDTLS_MPI_CHK( mbedtls_mpi_lset( X, 0 ) );
 678
 679     for( i = buflen, j = 0; i > n; i--, j++ )
 680         X->p[j / ciL] |= ((mbedtls_mpi_uint) buf[i - 1]) << ((j % ciL) << 3);
 681
 682 cleanup:
 683
 684     return( ret );
 685 }

Every failure path leaves the X MPI untouched.
For ecp_randomize_jac and ecp_randomize_mxz failure in mbedtls_mpi_fill_random is not important, because the MPI variable they operate on ("l") is initialized prior to the loop in which mbedtls_mpi_fill_random is called, and the loop condition guarantees that l is set to a non-zero value at some point:
ecp_randomize_jac:
1085
1086     mbedtls_mpi_init( &l ); mbedtls_mpi_init( &ll );
1087
1088     /* Generate l such that 1 < l < p */
1089     do
1090     {
1091         mbedtls_mpi_fill_random( &l, p_size, f_rng, p_rng );
1092
1093         while( mbedtls_mpi_cmp_mpi( &l, &grp->P ) >= 0 )
1094             MBEDTLS_MPI_CHK( mbedtls_mpi_shift_r( &l, 1 ) );
1095
1096         if( count++ > 10 )
1097             return( MBEDTLS_ERR_ECP_RANDOM_FAILED );
1098     }
1099     while( mbedtls_mpi_cmp_int( &l, 1 ) <= 0 );

ecp_randomize_mxz:
1468     mbedtls_mpi_init( &l );
1469
1470     /* Generate l such that 1 < l < p */
1471     do
1472     {
1473         mbedtls_mpi_fill_random( &l, p_size, f_rng, p_rng );
1474
1475         while( mbedtls_mpi_cmp_mpi( &l, &grp->P ) >= 0 )
1476             MBEDTLS_MPI_CHK( mbedtls_mpi_shift_r( &l, 1 ) );
1477
1478         if( count++ > 10 )
1479             return( MBEDTLS_ERR_ECP_RANDOM_FAILED );
1480     }
1481     while( mbedtls_mpi_cmp_int( &l, 1 ) <= 0 );

mbedtls_dhm_make_params and mbedtls_dhm_make_public both operate on ctx->X as the MPI where ctx is a mbedtls_dhm_context. I haven't really traced back all the possible call path to see whether execution can arrive in either of these functions with a ctx->X that has retained a previous value (and thus leaving that value intact should mbedtls_mpi_fill_random fail), but in dhm_update_blinding its obvious from the function that the MPI in question (ctx->Vi) is already initialized to a certain value:
304     /*
305      * Ok, we need blinding. Can we re-use existing values?
306      * If yes, just update them by squaring them.
307      */
308     if( mbedtls_mpi_cmp_int( &ctx->Vi, 1 ) != 0 )
309     {
310         MBEDTLS_MPI_CHK( mbedtls_mpi_mul_mpi( &ctx->Vi, &ctx->Vi, &ctx->Vi ) );
311         MBEDTLS_MPI_CHK( mbedtls_mpi_mod_mpi( &ctx->Vi, &ctx->Vi, &ctx->P ) );
312
313         MBEDTLS_MPI_CHK( mbedtls_mpi_mul_mpi( &ctx->Vf, &ctx->Vf, &ctx->Vf ) );
314         MBEDTLS_MPI_CHK( mbedtls_mpi_mod_mpi( &ctx->Vf, &ctx->Vf, &ctx->P ) );
315
316         return( 0 );
317     }
318
319     /*
320      * We need to generate blinding values from scratch
321      */
322
323     /* Vi = random( 2, P-1 ) */
324     count = 0;
325     do
326     {
327         mbedtls_mpi_fill_random( &ctx->Vi, mbedtls_mpi_size( &ctx->P ), f_rng, p_rng );
328
329         while( mbedtls_mpi_cmp_mpi( &ctx->Vi, &ctx->P ) >= 0 )
330             MBEDTLS_MPI_CHK( mbedtls_mpi_shift_r( &ctx->Vi, 1 ) );
331
332         if( count++ > 10 )
333             return( MBEDTLS_ERR_MPI_NOT_ACCEPTABLE );
334     }
335     while( mbedtls_mpi_cmp_int( &ctx->Vi, 1 ) <= 0 );

Here, a mbedtls_mpi_fill_random could cause the previous ctx->Vi to be retained.
So I suggest you put a MBEDTLS_MPI_CHK around these calls.

ARM Internal Ref: IOTSSL-1151

Fixed in PR's #749, #762 and #763 which are now merged. This issue can be closed.


Update holding location firestone$pf - circulates: false, keep only microforms for delivery locations.-Update location templates

Update holding location firestone$pf - circulates: false, keep only microforms for delivery locations.
Update location templates
closes #1852

https://bibdata-staging.princeton.edu/locations/holding_locations/firestone$pf


How to use standard in conjunction with eslint-config-standard-react

How does one use standard in conjunction with eslint-config-standard-react? Add eslintrc and extend it with eslint-config-standard-react? Isn't that going against the philosophy of standard (no config, no eslintrc)?
Its dupe of https://github.com/feross/standard-react/issues/13 but hoping it'll get an answer here.

Yes, it would have to be done using eslint directly instead of standard itself.
Take a look at standard's eslintrc file for a sample of how to do this. Just be sure to npm install all the eslint configs you're referencing and use eslint to run linting.
Closing this issue, but feel free to respond!

For now, the only way to use that config is to set up eslint yourself. It didn't make sense to force React rules on everyone since there are actually lots of frameworks that use JSX these days besides React and it was causing trouble for those users.
There are some proposals for how to enable using little add-on rule sets that I've been thinking about, but none implemented yet.


Use Spoom backtrace filter

Motivation
Use the new Sorbet backtrace filter added in https://github.com/Shopify/spoom/pull/457
Implementation
bundle update spoom then update test_helper.rb and require.rb
Automated Tests
n/a
Manual Tests
n/a

One question though, currently Spoom as a runtime dependency on sorbet-static, are we sure we want to import this transitive dependency to the Ruby LSP?
We could make Spoom not depend on sorbet-static in its Gemfile and just assume it would be here, but that causes problems regarding versions requirements that we would need to address first.

I don't understand why it's failing on Window...
D:/a/ruby-lsp/ruby-lsp/test/test_helper.rb:15:in `require': cannot load such file -- spoom/backtrace_filter/minitest (LoadError)

Because Spoom is not available on Windows. That will need to be a conditional require.


MissingLibraryException: Could not find 'libc++_shared.so'

I am compiling this project and build successfully but I got this error when the app just started:
Caused by: com.getkeepsafe.relinker.MissingLibraryException: Could not find 'libc++_shared.so'. Looked for: [arm64-v8a, armeabi-v7a, armeabi], but only found: [].
        at com.getkeepsafe.relinker.ApkLibraryInstaller.installLibrary(ApkLibraryInstaller.java:173)
        at com.getkeepsafe.relinker.ReLinkerInstance.loadLibraryInternal(ReLinkerInstance.java:180)
        at com.getkeepsafe.relinker.ReLinkerInstance.loadLibrary(ReLinkerInstance.java:136)
        at com.getkeepsafe.relinker.ReLinkerInstance.loadLibrary(ReLinkerInstance.java:92)
        at com.renard.ocr.TextFairyApplication.loadLibaries(TextFairyApplication.java:57)
        at com.renard.ocr.TextFairyApplication.onCreate(TextFairyApplication.java:45)

I am using windows 10 and android studio 4.0.1
Thank for any suggestion

i just modernized the libraries and fixed the travis build. Could you try again with latest master?


Remove some settings that are best left to cdap-defaults.xml in CDAP

Leave the bind addresses as <IP_ADDRESS> and don't set dashboard.bind.port or the deprecated (in 4.0) log.saver.run.memory.megs so we default to the CDAP defaults on all of these.

👍 lgtm


Explicitly expose version to avoid release script failure

lazyDerivation limits which attributes are exposed, and version is not currently one of them, so we need to explicitly expose it.
This fixes this CD failure:
https://github.com/NixOS/nixpkgs-check-by-name/actions/runs/8637321506/job/23679230914
This was accidentally introduced in #40 (should've made a separate PR for the first commit after all!)

Oh I like that idea more, lemme try something..

Done, I like it more like this :D

Nice suggestions, done!


HMM notebook

I've added a fifth notebook introducing the use of hidden Markov state models.

Thanks for the review @marscher!


Rename lib/domains/ru to lib/domains/ru/rksi

File needs to end in .txt.

@asiman161 Flagging as inactive.


Dark Mode Features/Diff/Preview Modals Need Border

We either need to add a border to these modals or change the background color of the modal to add a contrast between the modal and the application background:

Hah. Another design oversight, the shadow is black that would show on a not pure black bg.

Closed by #29


[CI] Add OpenGL to test environments

This PR sets-up Travis and Appveyor to have OpenGL > 2.1 available:

Out-of-the bos for Travis/MacOS
By installing packages on Travis/Linux
By downloading a pre-compiled Mesa DLL for Appveyor

It adds a test logging OpenGL version and a test for plot3d.ScalarFieldView.
It fixes a minor issue with OpenCL tests (when disabled).
It uses requirements.txt in appveyor configuration.
Close #959

For Windows, OpenGL tests are only run with Python3.
There are issues with Python2, where it would probably be needed to rebuild mesa3d with the right compiler...

LGTM


5.1.4. Grouped Animations first line : "Often animations will be more complex then just animating one property."

should't it be 'than'?

Already fixed in master. We just need to regenerate the output. Thanks for reporting!


feat: Add authentication for GraphQL requests

Motivation: https://github.com/usebruno/bruno/issues/354
This adds the Auth tab to GraphQL requests. This kills two birds with one stone:

you can use authentication methods in your GraphQL requests more easily (no need to manually set headers)
the schema introspection query can use the specified authentication credentials as well

The second point was my main motivation, see the linked issue. Schema introspection only works when passing the bearer token in our case.

This is great!
Merged!
Thanks @grubersjoe !


[cxx-interop] Re-land part of 6ba7a1e. Fix an issue with extending nested namespaces across modules.

No one should be using C++ interop yet, so this part of the change cannot break anyone (as it only touches namespaces).

@swift-ci please test.

Build failed
Swift Test Linux Platform
Git Sha - ce85f9da8ebe27625ab06d6c1cb945dbe9fb660d

Build failed
Swift Test OS X Platform
Git Sha - ce85f9da8ebe27625ab06d6c1cb945dbe9fb660d

@swift-ci please smoke test.

@swift-ci please test.

Build failed
Swift Test OS X Platform
Git Sha - cead6ca46c742dd567a63103757ce761a50d8596

@swift-ci please test.

@swift-ci please test.

@swift-ci please test.


[BUG] The CategoriesPage of the NEXTJS version of the website is not responsive on smaller screen sizes

Description
I will add appropriate Tailwind classes and restructuring to make it responsive for small screen sizes.
Kindly assign me this issue! :)
Screenshots

Any additional information?
No response
What browser are you seeing the problem on?
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@ShivanshPlays you are assigned.


upstream timed out

Hello,
i'm getting timeouts:
2023/08/25 21:02:30 [error] 205#205: 34 upstream timed out (110: Operation timed out) while reading response header from upstream, client: <IP_ADDRESS>, server: _, request: "GET /?host=<IP_ADDRESS>&port=623&user=&password=* HTTP/1.1", upstream: "fastcgi://<IP_ADDRESS>:9000", host: "localhost:9595"

I think i have fixed the problem.
Changed init.py Line 91 the value from 10 to 60
async with async_timeout.timeout(60):
Seems to fix the timeouts for me

I think i have fixed the problem. Changed init.py Line 91 the value from 10 to 60 async with async_timeout.timeout(60):
Seems to fix the timeouts for me

Great to hear that! You can either submit a PR or I can fix that in the code.

https://github.com/ateodorescu/home-assistant-ipmi/releases/tag/v1.1.1


Layout tabs always show a tab index of 1

The layout tabs always show a tab index of 1 for all tabs

This seems to be only a visual problem as switching to a tab with a certain index via e.g. 3gt still works as expected.

It's not the tab index but the number of windows/splits in the tab. Vim behaves the same way, except it doesn't show the count if it's 1.

That's strange. My vim show the tab indices:

Ok, it's probably from the lightline plugin.
Starting vim without any plugins (vim -u NONE) and opening new tabs will behave as you described.
I will adjust the description, because I still think, that showing the tab index is more useful, than showing the number of splits inside a tab.

Closing this in favour of #2233.


Be notified of progress using the callback closure also for data request

Alamofire provide also Progressfor DataRequest.
Any reason to not use it? Maybe not available when implementing the new progress callback in Moya
Following that Progress could be also provided at the end with response
https://github.com/phimage/Moya/commit/c13fcd6ded55309cd6cf5e6d789f50420fedd04d

          2 Warnings

:warning:
Any changes to library code should be reflected in the Changelog. Please consider adding a note there.

:warning:
Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

SwiftLint found issues
Warnings

File
Line
Reason

MoyaProviderSpec.swift
768
Lines should not have trailing whitespace.

MoyaProviderSpec.swift
770
Lines should not have trailing whitespace.

MoyaProviderSpec.swift
774
Lines should not have trailing whitespace.

MoyaProviderSpec.swift
780
Lines should not have trailing whitespace.

MoyaProviderSpec.swift
787
Lines should not have trailing whitespace.

MoyaProviderSpec.swift
790
Lines should not have trailing whitespace.

MoyaProviderSpec.swift
892
File should contain 400 lines or less: currently contains 892

Errors

File
Line
Reason

MoyaProviderSpec.swift
7
Type body should span 350 lines or less excluding comments and whitespace: currently spans 530 lines

  Generated by :no_entry_sign: Danger

@phimage Thank you for the PR 🎉 I've only skimmed the changes but I know this will conflict with changes made to TargetType from #1147 in the 9.0.0-dev branch. If we move forward on this PR, maybe you could submit your work to 9.0.0-dev?

Ok I can redo my commits for 9.0.0-dev
and use my fork until release
PS: Any reason to not have swiftlint in build phase of xcode targets. I think I have added some trailing whitespaces


Format events as json

I'd like to be able to make assertions about the contents of the logging when encoded to json. Would it be possible to support this? Perhaps #[traced_test(json)] or something like that could be made to work?
Might be a bit related to #5?

One way how this might be achieved is using the new (in 0.2) logs_assert function that's injected into your test function. You get access to a slice of logs, and can do whatever you want with it in order to validate the contents. For example, you could write a helper method and then call logs_assert(my_json_content_assertion); in your test.

We are using structured logging and have other systems which will expect certain fields to exist so I would like to validate we were really generating them in the expected JSON object structure.
I think logs_assert currently gives me the plain-text/non-json logs (fmt::format::Full I think?). If it gave me the json encoded string I could happily parse it to perform my checks. I think to enable that get_subscriber would need to gain a conditional .json() in the builder chain.

Ah, I see what you mean. Yes, this is most certainly related to #5. I'm not familiar with the .json(), but that might actually be a way to implement #5 if it's supported out of the box.

I could have been more helpful and linked to .json() which switches the subscriber to fmt::format::Json.
As well as injecting the .json I suspect the matching in logs_with_scope_contain would need to adjusted since it won't match anymore.
As an alternative to a macro option I think a crate level feature would be ok too if that simplifies things

I'd welcome a generic solution that switches internal log record storage to a more structured format (i.e. #5). I think with that, we wouldn't need a JSON option, because it would already allow accessing structured fields. This might be implemented through JSON though.
If all structured records would be accessible when doing assertions against logs, would that solve the issue for you? If yes, would you be OK with closing this issue in favor of #5?

Yes, I think I could live with that.
I'd like to be able to test the serialisation side of things, but that could as well be separate/unrelated test.


support rabbitmq plugin

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[x] New feature provided

[ ] Improve performance

Related issues

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.

Coverage increased (+0.1%) to 24.677% when pulling 2b0f1845d63ec009ec4acee21c84b229be35812a on WithLin:rabbitmq-5.x into 6a0ae6b80dd3672a977eda7b8a70fa2d480bbffb on apache:5.x.

Is this time test ready?

Is this time test ready?

Is this time test ready?

no, i am not sure. you can run test by now.


Added Info on what Captain Stack is doing

Added progress information by showing if captain stack is loading something or is finished in the bottom left corner of vscode. Resolves questions similar to "Why is nothing happening?" from impatient users.

I made an update with the search.ts but not the search.js (maybe let it regenerate the js file)

Nice PR by the way. I was wonder why VSCode didn't do it automatically


Support Solution Filters

Support was added but failed because it relied on System.Text.Json.
Reverted here:
https://github.com/microsoft/msbuild/pull/5142

Fixed by #5182. This should ship with 16.7 preview 3.


Stuck at Building

Simple nodejs application with this command
"build": "NODE_ENV=production PORT=1565 node index.js"
It stucks at building. Help!

Indeed, this will never build because you are invoking node to listen instead of build.
It sounds like you probably don't need a build step. So instead you can create an api folder with an index file like this: /api/index.js
See an example introduction here: https://zeit.co/docs/v2/serverless-functions/introduction

Yeah, it makes sense. Its same alike AWS Lambda Functions.


Fixing compilation of theme during AMI build

The theme wasn't being compiled fully during the AMI build because the configuration necessary to point the update-assets script at the right location isn't getting loaded until the instance is launched. This adds the necessary Ansible values to the playbook file so that the minimal necessary config is in place at build/compilation time.

👍


[DRAFT] glTF interactivity and flow graph update (For snapshot)

I open this PR just to update the snapshot.
No reviews needed, as it will be closed right after.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

I think the build failed because of some TypeScript errors @RaananW

I think the build failed because of some TypeScript errors @RaananW

should be fine now

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Here's one more:
https://dev.azure.com/babylonjs/ContinousIntegration/_build/results?buildId=34911&view=logs&j=8c3f0989-617d-5669-63ad-dc4309b25f44&t=1f7a1b4b-d9c8-5792-a01a-a4c2a11af4fd&l=532

Or not. I'm away for a few minutes, will solve this right after im back

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Have to close it for now, will keep you updated.

Thank you. So just that I don't keep looking, there's no new build with available Sandbox for now, correct?

Thank you. So just that I don't keep looking, there's no new build with available Sandbox for now, correct?

i'll let you know here and on the forum once it is available. Something's off with the internal build of some packages and I have to find the source. You can always pull this locally and run the babylon server (which works, as this is the way I am developing), but I assume I will find a solution pretty soon.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/15810/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15810/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15810/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15810/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15810/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15810/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15810/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15810/merge#BCU1XR#0

Snapshot stored with reference name:
refs/pull/15810/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15810/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15810/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15810/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15810/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15810/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15810/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15810/merge#BCU1XR#0

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15810/merge/testResults/webgl2playwright/index.html

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15810/merge/testResults/webgpuplaywright/index.html

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15810/merge/testResults/webgpuplaywright/index.html

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15810/merge/testResults/webgl2playwright/index.html

Thank you, I was able to do some tests. The built version seems to hide exceptions, so I tested locally as well.
Here are some test files:

Setting KHR_node_visibility pointers doesn't work

test file: SetActiveOnStart.glb.zip
does not work here: https://sandbox.babylonjs.com/?snapshot=refs/pull/15810/merge
locally, I get an exception (extensions/KHR_node_visibility/visible should be in the _infoTree I believe):

I tried to fix it [^1] but didn't get it to work
works here: https://gltf-interactivity.needle.tools, scroll down, select Babylon Engine, load the GLB

Setting visibility every few moments with a delay node

test file: ToggleEverySecond.glb.zip
does not work in Sandbox, same reason as above likely
works here: https://gltf-interactivity.needle.tools

[^1]: My unsuccessful attempt at adding this (and the types) in objectModelMapping.ts:
```ts
extensions: {
KHR_node_visibility: {
visible: {
get: (node: INode) => (node instanceof AbstractMesh ? node.isVisible : true),
set: (value: boolean, node: INode) => {
// eslint-disable-next-line no-console
console.log("setting visibility", value);
if (node instanceof AbstractMesh) {
node.isVisible = value;
}
},
getTarget: (node: INode) => node._babylonTransformNode,
getPropertyName: [() => "isVisible"],
type: "boolean",
},
},
},

Do you want me to open issues against your fork instead? If so, please enable Issues there :)

Do you want me to open issues against your fork instead? If so, please enable Issues there :)

Would actually be great to keep it outside of github. the forum would be the best place for this.

Thank you!
Is there some kind of logging flag (a query parameter or so?) to have the execution model log some debugging steps?
(The "Logging Engine" of the Graph Authoring Tool does that, and it's quite useful to not having to slap console nodes on everything when just trying to understand what's happening when.)

It seems I'm not yet allowed to upload files on the forum, so here's some more failing test files. They work in the Graph Authoring Tool implementation. Upon clicking the blue button the traffic light should go red-yellow-green-yellow-red.

pointer/set with colors – results in wrong colors
TrafficLight_Simple_SetColorPointer.glb.zip

pointer/interpolate with colors – results in wrong colors
TrafficLight_Simple_Interpolate.glb.zip

I believe these could have the same root issue.

It seems I'm not yet allowed to upload files on the forum, so here's some more failing test files. They work in the Graph Authoring Tool implementation. Upon clicking the blue button the traffic light should go red-yellow-green-yellow-red.

pointer/set with colors – results in wrong colors
TrafficLight_Simple_SetColorPointer.glb.zip
pointer/interpolate with colors – results in wrong colors
TrafficLight_Simple_Interpolate.glb.zip

I believe these could have the same root issue.

Quick note on the files you provided, there is an error in the glTF that partly prevents us from parsing the types correctly (interpolation demo). The pointer's configuration is this:
"configuration":[{"id":"pointer","type":11,"value":"/materials/1/pbrMetallicRoughness/baseColorFactor"}], (expected float4)
and the value is this:
"values":[{"id":"value","type":7,"value":[0.9921569,0.7337824,0.0,1.0]}
value is a float4, but type:7 is float3. There are duplicated float3 as well, but we don't check that yet, so that's perfectly fine. So even if I make sure to parse vector4/vcolor4 correctly, this will fail. I will try finding a proper solution for this.
Anyhow, the set is already fixed (as I suspected it was an issue with vector-to-color, interpolation is being worked on.

Thanks for fixing, good catch about float3/float4! – here's a file with the corrected type for color:
TrafficLight_Simple_SetColorPointer2.glb.zip
I think this might happen more often, as colors (typically float4 in all systems) can be either float3 or float4 in glTF, depending on usage, so I expect exporters to mess that up occassionally...

Thanks for fixing, good catch about float3/float4! – here's a file with the corrected type for color: TrafficLight_Simple_SetColorPointer2.glb.zip
Not sure if the sandbox should already be updated – I can see the "red" color correctly but upon clicking the blue button the colors still go to some kind of dark purple.
I think the float3/float4 mixup might happen more often, as colors (typically float4 in all systems) can be either float3 or float4 in glTF, depending on usage, so I expect exporters to mess that up occassionally...

The sandbox will be updated in 15-20 minutes (waiting for the build to finish). Interpolation should also be working now.
The new file doesn't reset the colors to gray, so it only shows red yellow and green. Is that the correct behavior?

Sorry, it was indeed not the correct file.
✅  This should be correct now (and works in the updated sandbox – thanks!):

TrafficLight_Simple_SetColorPointer.glb.zip

❌  The pointer interpolation file does not behave correctly yet –

File: TrafficLight_Simple_Interpolate.glb.zip

Expected
Actual

Problems:

Interpolation flickers (whenever a pointer interpolation starts, the value seems to "snap" somewhere else for a frame)
my guess is that pointers never "stop" on their own after being done interpolating – thus the transition backwards (green-yellow-red) doesn't have any effect. I believe that independent of whether the transition is already done or not, newer pointer/interpolate calls should beat older ones as per the spec

Interpolation flickers (whenever a pointer interpolation starts, the value seems to "snap" somewhere else for a frame)
my guess is that pointers never "stop" on their own after being done interpolating – thus the transition backwards (green-yellow-red) doesn't have any effect. I believe that independent of whether the transition is already done or not, newer pointer/interpolate calls should beat older ones as per the spec

That is true, I am not tracking currently running interpolation. Not yet, at least.

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15810/merge/testResults/webgl2playwright/index.html

Interpolation flickers (whenever a pointer interpolation starts, the value seems to "snap" somewhere else for a frame)
my guess is that pointers never "stop" on their own after being done interpolating – thus the transition backwards (green-yellow-red) doesn't have any effect. I believe that independent of whether the transition is already done or not, newer pointer/interpolate calls should beat older ones as per the spec

Both were fixed in the last commit. The issue was not the interpolation running already. The issue was reusing already-existing blocks, which was prevented deliberately. I believe there was a discussion about that a long time ago (and this is why it was implemented this way originally), but I can't find it in the current state of the specs. So - blocks can now be reused and re-triggered.
The flickering was because of an issue we had in our bezier curve implementation, and that was fixed as well.

Here's a test file that contains additional nodes not known by the engine. My understanding as per the spec is that these should simply be ignored, as they could be defined in extensions that the engine simply doesn't support at the moment.
SimpleMath_SubGeneric_Logging.glb.zip
Currently, it causes an exception because the node is not known.

Here's a test file that contains additional nodes not known by the engine. My understanding as per the spec discussions is that these should be ignored, as they could be defined in extensions that the engine simply doesn't support at the moment.

Should be fine now.

Thanks!
Here's another test file, this time one that "just works" for a change :)
Counter (simple standalone)_Calculator.glb.zip

Here's two more currently failing test assets (errors in the console):
SnailRace.zip
Should look like this:

Here's two more

math/select was not attached. Should work now (i.e. once the build is done)

You have changed file(s) that make changes to the playground.
You can test the snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/
The snapshot playground with the CDN snapshot (only when available):
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/?snapshot=refs/pull/15810/merge
Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

Here's a file using KHR_node_hoverability that doesn't currently seem to be implemented: Hover.glb.zip

Correct, hoverability was not yet implemented. I'll test with this file once it is implemented

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/15810/merge/

You have made possible changes to the playground.
You can test the snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/
The snapshot playground with the CDN snapshot (only when available):
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/?snapshot=refs/pull/15810/merge
Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

Building or testing the playground has failed.
If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/testResults/

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/15810/merge/

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/15810/merge/

You have made possible changes to the playground.
You can test the snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/
The snapshot playground with the CDN snapshot (only when available):
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/?snapshot=refs/pull/15810/merge
Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

Here's a couple more files that aren't working in this PR's Babylon Sandbox at the moment:

Waypoints.glb.zip
PlaceOnClick_.glb.zip

Building or testing the playground has failed.
If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/testResults/

Building or testing the sandbox has failed.
If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/15810/merge/testResults/

You have made possible changes to the playground.
You can test the snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/
The snapshot playground with the CDN snapshot (only when available):
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/?snapshot=refs/pull/15810/merge
Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/15810/merge/

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/15810/merge/

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/15810/merge/

You have made possible changes to the playground.
You can test the snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/
The snapshot playground with the CDN snapshot (only when available):
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/?snapshot=refs/pull/15810/merge
Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

PlaceOnClick_.glb.zip

The reason this doesn't work is the math/mix node. According to the specs, c should be a floatN (which should be the same as a and b), but the value you provide is a float. Thus, position setting fails. One could argue that for math/mix the c value could be a float (applying to all dimensions of the floatN), but this is not the case currently.
Now checking the second one.

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/15810/merge/

You have made possible changes to the playground.
You can test the snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/
The snapshot playground with the CDN snapshot (only when available):
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/?snapshot=refs/pull/15810/merge
Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.


jgclark.repeatExtensions: dueDate calculation adjustment

adjust new data calculation: when there is no task due date, use the note date if it exists, otherwise default to (current behavior) of task completion date.

so, I made the requested changes, but cannot figure out how to submit them to existing PR. or are they already there?


Kubernetes Repository URL HTTPS

If you follow the instructions for
Install kubectl binary using native package management

On Ubuntu 18.04 you'll get this apt error:
Err:3 http://apt.kubernetes.io kubernetes-xenial InRelease

Which means that apt was unable to get repository information because it was a 403 (forbidden).
Changing to HTTPS eliminates error.

I have signed the CLA

/lgtm
/approve


posix: eventfd: nonblocking reads greater than writes

Describe the bug
When using an eventfd(0, EFD_SEMAPHORE | EFD_NONBLOCK), it should never be possible to read the semaphore more times than it is written.
However, the current eventfd() implementation seems to fail that test.
Please also mention any information which could help others to understand
the problem you're facing:

What target platform are you using? qemu_riscv64_smp
What have you tried to diagnose or workaround this issue? wrote a testsuite / stress test
Is this a regression? No, it has always been broken

To Reproduce
Steps to reproduce the behavior:

add the stress.c file to tests/posix/eventfd/src/ and the Kconfig file to tests/posix/eventfd/
west build -p auto -b qemu_riscv64_smp -t run tests/posix/eventfd/
See error

Expected behavior
The testsuite should succeed
Impact
It's a showstopper for anyone expecting proper operation of eventfd().
Logs and console output
*** Booting Zephyr OS build v3.4.0-rc1-101-g5d67c8a8037d ***
Running TESTSUITE eventfd
===================================================================
START - test_overflow
 PASS - test_overflow in 0.006 seconds
===================================================================
START - test_poll_timeout
 PASS - test_poll_timeout in 0.518 seconds
===================================================================
START - test_read_nonblock
 PASS - test_read_nonblock in 0.003 seconds
===================================================================
START - test_set_poll_event_block
 PASS - test_set_poll_event_block in 0.004 seconds
===================================================================
START - test_set_poll_event_nonblock
 PASS - test_set_poll_event_nonblock in 0.003 seconds
===================================================================
START - test_stress
I: BOARD: qemu_riscv64_smp
I: TEST_DURATION_S: 5
I: UPDATE_INTERVAL_S: 1
D: spawning thread 0
D: spawning thread 1
D: joining thread 0
D: 999 reads
D: 788 writes
D: 1933 reads
D: 1624 writes
D: 2858 reads
D: 2459 writes
D: 3787 reads
D: 3293 writes
I: avg: 941 reads/s
D: joining thread 1
I: avg: 842 writes/s

    Assertion failed at WEST_TOPDIR/zephyr/tests/posix/eventfd/src/stress.c:96: eventfd_test_stress: (count[WRITER] >= count[READER] is false)
read count (4705) > write count (4210)
 FAIL - test_stress in 5.042 seconds
===================================================================
START - test_unset_poll_event_block
 PASS - test_unset_poll_event_block in 0.005 seconds
===================================================================
START - test_unset_poll_event_nonblock
 PASS - test_unset_poll_event_nonblock in 0.004 seconds
===================================================================
START - test_write_then_read
 PASS - test_write_then_read in 0.004 seconds
===================================================================
START - test_zero_shall_not_unblock
 PASS - test_zero_shall_not_unblock in 0.002 seconds
===================================================================
TESTSUITE eventfd failed.

------ TESTSUITE SUMMARY START ------

SUITE FAIL -  90.00% [eventfd]: pass = 9, fail = 1, skip = 0, total = 10 duration = 5.591 seconds
 - PASS - [eventfd.test_overflow] duration = 0.006 seconds
 - PASS - [eventfd.test_poll_timeout] duration = 0.518 seconds
 - PASS - [eventfd.test_read_nonblock] duration = 0.003 seconds
 - PASS - [eventfd.test_set_poll_event_block] duration = 0.004 seconds
 - PASS - [eventfd.test_set_poll_event_nonblock] duration = 0.003 seconds
 - FAIL - [eventfd.test_stress] duration = 5.042 seconds
 - PASS - [eventfd.test_unset_poll_event_block] duration = 0.005 seconds
 - PASS - [eventfd.test_unset_poll_event_nonblock] duration = 0.004 seconds
 - PASS - [eventfd.test_write_then_read] duration = 0.004 seconds
 - PASS - [eventfd.test_zero_shall_not_unblock] duration = 0.002 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION FAILED

Environment (please complete the following information):

OS: macOS
Toolchain: Zephyr SDK v0.16.1
Commit SHA or Version used: 44e691e20e0b323ad67227ee072bd4166c75d894

Additional context
This is luckily already fixed in #58492, but I will add the testsuite to that PR as well.

Might have been a false positive.


test(vOn): update test for capitalize dynamic event names

Ah, thanks, didn't see this when I was working on 380c6792


Question: how do one solve unsatisfiable constraints that require both ssl libs?

EDIT (17h after): ~ # apk add openssl-dev qt-dev
ERROR: unsatisfiable constraints:
  openssl-dev-1.0.2k-r0:
    conflicts: libressl-dev-2.5.5-r0[pc:libcrypto=1.0.2k] libressl-dev-2.5.5-r0[pc:libssl=1.0.2k] libressl-dev-2.5.5-r0[pc:openssl=1.0.2k]
    satisfies: build-deps-0[openssl-dev]
  libressl-dev-2.5.5-r0:
    conflicts: openssl-dev-1.0.2k-r0[pc:libcrypto=2.5.5] openssl-dev-1.0.2k-r0[pc:libssl=2.5.5] openssl-dev-1.0.2k-r0[pc:openssl=2.5.5]
    satisfies: qt-dev-4.8.7-r6[libressl-dev]```

Can you provide a reproducer?
This works for me...
Dockerfile:
FROM gliderlabs/alpine:3.6
RUN apk add --no-cache qt-dev

Build it:
$ docker build --rm -t qtdev .
Sending build context to Docker daemon 2.048 kB
Step 1 : FROM gliderlabs/alpine:3.6
 ---> 2a67891a149d
Step 2 : RUN apk add --no-cache qt-dev
-snip-
(121/121) Installing qt-dev (4.8.7-r6)
Executing busybox-1.26.2-r5.trigger
Executing glib-2.52.1-r0.trigger
No schema files found: doing nothing.
Executing ca-certificates-20161130-r2.trigger
OK: 325 MiB in 130 packages
 ---> b774b41fbf06
Removing intermediate container 7d54e2802d73
Successfully built b774b41fbf06

Dockerfile
FROM gliderlabs/alpine:3.6
RUN apk add --no-cache openssl-dev qt-dev

alpine linux packages, including qt-dev related packages, are compiled with libressl, not openssl.
openssl-dev and libressl-dev provide many files that have the same path, therefore the two packages cannot be installed at the same time.
example for /usr/lib/libssl.so: https://pkgs.alpinelinux.org/contents?file=libssl.so&path=&name=&branch=v3.6&repo=&arch=x86_64

more info:

the issue to migrate from openssl to libressl is here.
It was also announced on the mailing list here.

hth.

Nice! That's what I was looking for! About to test it.

Can you give an example of what you are building that needs openssl-dev if this is not yet solved?

@andyshinn sure. I'm building gr-gsm with PyBOMBS under Alpine.
Basically a RUN that should go smooth like:
apk --update add --no-cache --virtual build-deps $DEPS
printf "[list]\nformat=columns\n" >> /etc/pip.conf
pip install PyBOMBS
pybombs auto-config
pybombs recipes add-defaults
pybombs prefix init ./gnur -a gnur
pybombs -p ./gnur install gr-gsm
ldconfig

@jumanjiman regarding on the mailing list email I see "you will have to replace
it with", since the objetive is to have /usr/lib/libssl.so didn't it makes sense to have some sort of  meta-package linking with names for eg. libssl or libssl-dev ? That would increase redundancy and smooth-upgrading to future versions of Alpine.
ps: I don't know Apk nor Alpine's from a developer point of view, so I don't know if it's already implemented.

Apk are giving me these errors also.
(310/312) Installing wxgtk-dev (3.0.2-r0)
ERROR: wxgtk-dev-3.0.2-r0: trying to overwrite usr/bin/wxrc owned by wxgtk2.8-dev-<IP_ADDRESS>-r4.
ERROR: wxgtk-dev-3.0.2-r0: trying to overwrite usr/bin/wx-config owned by wxgtk2.8-dev-<IP_ADDRESS>-r4.
ERROR: wxgtk-dev-3.0.2-r0: trying to overwrite usr/share/bakefile/presets/wx_win32.bkl owned by wxgtk2.8-dev-<IP_ADDRESS>-r4.
ERROR: wxgtk-dev-3.0.2-r0: trying to overwrite usr/share/bakefile/presets/wx.bkl owned by wxgtk2.8-dev-<IP_ADDRESS>-r4.
ERROR: wxgtk-dev-3.0.2-r0: trying to overwrite usr/share/bakefile/presets/wx_unix.bkl owned by wxgtk2.8-dev-<IP_ADDRESS>-r4.
ERROR: wxgtk-dev-3.0.2-r0: trying to overwrite usr/share/aclocal/wxwin.m4 owned by wxgtk2.8-dev-<IP_ADDRESS>-r4.

After 5 days on this I am tired of my CPU's performance already. This is the actual state of my gr-gsm.Dockerfile @andyshinn

trying with alpine:3.8 now...


[cocoon] Create BigQuery service

flutter/cocoon has BigQuery operations throughout the codebase. We should consolidate them under one BigQuery service to make it easier to discover what metrics Cocoon pushes, and the format they are in.

Closing because the bug has not been updated for more than one year.
Feel free to reopen any bugs that you believe are important but please provide updates on how to resource the fix of the bug and what can be done to prevent the issue from not getting updates for another year.


missing go.sum entry for module providing package github.com/shopspring/decimal

Originally posted by @imkh in https://github.com/prisma/prisma-client-go/issues/402#issuecomment-811171430

Thanks @steebchen! I ran into some issues while updating but after running some commands, I can confirm that it works. I'm not sure if it should be expected to have to run these commands, so here are the logs below.

It's definitely not expected to do something manual, in theory it should just works. It does for me, meaning I wasn't able to reproduce your issue. I'd be grateful if you could help me out with this by creating a new project and adding the Go client and see if you run into the same issue. Also, does your prisma schema use the type Decimal or not?

Unfortunately I can't reproduce. Would be great if you could also try this in a new project and see if this happens consistently.

I recreated the project from scratch (the one from the original issue #402) and I still get the error :confused:
The schema does not use the type Decimal.
I pushed the project on GitHub with all the info in the README so you can have a closer look: https://github.com/imkh/prisma-client-go-issue-452. Let me know if you need anything else.

Can't reproduce on the first try. I'll do some more experiments (maybe go mod cache clean) later this week.

Alright, got it reproduced. This apparently only happens with go1.16, which I thought I had installed, but actually had go1.15.
Seems like the related issue is https://github.com/golang/go/issues/44129.
I don't quite understand what's happening here. The mod/sum files in the Go client seem to be fine and up-to-date. For now, a go mod tidy in the project repo fixes this.

Thanks for the feedback. Indeed, a go mod tidy fixes the error. Hopefully, the issue on the Go repo's side gets fixed soon.

Looks like this may have someething to do with our code generation where go modules doesn't (and can't) figure out some dependencies after the codegen ran. Will look into it.


Unable to attach or mount volumes: unmounted volumes=[test], unattached volumes=[test default-token-l52vd]: failed to get Plugin from volumeSpec for volume "test" err=no volume plugin matched

Hi
We are currently planning to mount blob storage with AKS, before that we are trying to implement the same on minikube installed on Linux VM but not able to get it to work.
As mentioned in the documentation, I have followed the below steps:

Installed blobfuse driver on Linux VM
Installed blobfuse as a daemon set
create a secret which stores Azure storage account name and account key
create a secret which stores Azure storage account name and account SAS token [command not working, as we already created the credentials with the same name, Skipped]
Created PV, PVC, and pod.
Installed SMB with the below command.
curl -skSL https://raw.githubusercontent.com/Azure/kubernetes-volume-drivers/master/flexvolume/smb/deployment/install-smb-flexvol-ubuntu.sh | sh -s --

After installing the SMB, the status is the same below is the error message.
Normal   Scheduled    14s               default-scheduler  Successfully assigned default/nginx-flex-blobfuse to liferaydockerization
  Warning  FailedMount  1s (x2 over 14s)  kubelet            Unable to attach or mount volumes: unmounted volumes=[test], unattached volumes=[test default-token-l52vd]: failed to get Plugin from volumeSpec for volume "test" err=no volume plugin matched

Thanks

you are messing up blobfuse with smb, try this: https://github.com/Azure/kubernetes-volume-drivers/tree/master/flexvolume/blobfuse, and for blobfuse, it's suggested to use CSI driver: https://github.com/kubernetes-sigs/blob-csi-driver

OK.. understood to use Blobfluse, CSI driver is required. Still, the link which you have mentioned  "https://github.com/Azure/kubernetes-volume-drivers/tree/master/flexvolume/blobfuse", I have followed the same only the errors while running the pod is because of the CSI plugin right? ( Just want to be sure)
Can this be implemented on minikube?
Thank you for your amazing support.

I am not sure whether it works on minikube

as I know, SMB csi driver works on minikube, so blob csi driver could also work on minikube

Hi Andy
After running the below command to install CSI Drive getting the pod status as Error/Crashloopback  and pending
curl -skSL https://raw.githubusercontent.com/kubernetes-sigs/blob-csi-driver/v0.9.0/deploy/install-driver.sh | bash -s v0.9.0 --
"Warning  FailedScheduling  29s (x2 over 29s)  default-scheduler  0/1 nodes are available: 1 node(s) didn't have free ports for the requested pod ports."
Normal   Created    2m22s                kubelet            Created container liveness-probe
Normal   Started    2m22s                kubelet            Started container liveness-probe
Normal   Pulled     96s (x4 over 2m22s)  kubelet            Container image "mcr.microsoft.com/k8s/csi/blob-csi:v0.9.0" already present on machine
Normal   Created    96s (x4 over 2m22s)  kubelet            Created container blob
Normal   Started    96s (x4 over 2m21s)  kubelet            Started container blob
Warning  BackOff    93s (x7 over 2m20s)  kubelet            Back-off restarting failed container

Blob CSI driver needs azure credential file, make sure you have configured it correct: https://github.com/kubernetes-sigs/blob-csi-driver#prerequisite
Here is the way about how to troubleshooting the driver crash:
https://github.com/kubernetes-sigs/blob-csi-driver/blob/master/docs/csi-debug.md#case1-volume-createdelete-issue


docs: adjust help for config

Per https://github.com/iterative/dvc/pull/5090

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.
Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Adjusted code and docs. Thanks!


Update comment and doc for build_id

For container images, build_id is actually the build task id,
the name is easy to make some confusions, update doc and comment
for this.
See #99

I added my changes into https://github.com/redhat-exd-rebuilds/freshmaker/pull/101


MVP of some internal Network Load Balancer

The main reason for this repository is be a Application Load Balancer (since most people would likely to not use a full project like this for somethig that could maybe be done directly with HAproxy).
But some things (even if faster enough) could be more complex to do with NGinx server blocks that we use for our L7 LB and also put too much pression on logging.
This issue is for we consider to test or add some way to redirect ports. But, as my initial idea on #1, maybe this could the main reason for use the AP-ALB.

https://www.haproxy.com/blog/haproxy-2-0-and-beyond/
https://haproxy.debian.net/#?distribution=Ubuntu&release=bionic&version=2.0

Ubuntu 18.04.2 by default have only HAProxy 1.8 (at this moment, 1.8.8)

root@testserver:~# cat /etc/haproxy/haproxy.cfg
global
	log /dev/log	local0
	log /dev/log	local1 notice
	chroot /var/lib/haproxy
	stats socket /run/haproxy/admin.sock mode 660 level admin expose-fd listeners
	stats timeout 30s
	user haproxy
	group haproxy
	daemon

	# Default SSL material locations
	ca-base /etc/ssl/certs
	crt-base /etc/ssl/private

	# Default ciphers to use on SSL-enabled listening sockets.
	# For more information, see ciphers(1SSL). This list is from:
	#  https://hynek.me/articles/hardening-your-web-servers-ssl-ciphers/
	# An alternative list with additional directives can be obtained from
	#  https://mozilla.github.io/server-side-tls/ssl-config-generator/?server=haproxy
	ssl-default-bind-ciphers ECDH+AESGCM:DH+AESGCM:ECDH+AES256:DH+AES256:ECDH+AES128:DH+AES:RSA+AESGCM:RSA+AES:!aNULL:!MD5:!DSS
	ssl-default-bind-options no-sslv3

defaults
	log	global
	mode	http
	option	httplog
	option	dontlognull
        timeout connect 5000
        timeout client  50000
        timeout server  50000
	errorfile 400 /etc/haproxy/errors/400.http
	errorfile 403 /etc/haproxy/errors/403.http
	errorfile 408 /etc/haproxy/errors/408.http
	errorfile 500 /etc/haproxy/errors/500.http
	errorfile 502 /etc/haproxy/errors/502.http
	errorfile 503 /etc/haproxy/errors/503.http
	errorfile 504 /etc/haproxy/errors/504.http

root@testserver:~# cat /etc/haproxy/errors/400.http
HTTP/1.0 400 Bad request
Cache-Control: no-cache
Connection: close
Content-Type: text/html

400 Bad request

Your browser sent an invalid request.

root@testserver:~# cat /etc/haproxy/errors/403.http
HTTP/1.0 403 Forbidden
Cache-Control: no-cache
Connection: close
Content-Type: text/html

403 Forbidden

Request forbidden by administrative rules.

root@testserver:~# cat /etc/haproxy/errors/408.http
HTTP/1.0 408 Request Time-out
Cache-Control: no-cache
Connection: close
Content-Type: text/html

408 Request Time-out

Your browser didn't send a complete request in time.

root@testserver:~# cat /etc/haproxy/errors/500.http
HTTP/1.0 500 Internal Server Error
Cache-Control: no-cache
Connection: close
Content-Type: text/html

500 Internal Server Error

An internal server error occurred.

root@testserver:~# cat /etc/haproxy/errors/502.http
HTTP/1.0 502 Bad Gateway
Cache-Control: no-cache
Connection: close
Content-Type: text/html

502 Bad Gateway

The server returned an invalid or incomplete response.

root@testserver:~# cat /etc/haproxy/errors/503.http
HTTP/1.0 503 Service Unavailable
Cache-Control: no-cache
Connection: close
Content-Type: text/html

503 Service Unavailable

No server is available to handle this request.

root@testserver:~# cat /etc/haproxy/errors/504.http
HTTP/1.0 504 Gateway Time-out
Cache-Control: no-cache
Connection: close
Content-Type: text/html

504 Gateway Time-out

The server didn't respond in time.

We actually already have HAProxy as Network Load Balancer. It is enabled by default, stays in front of OpenResty (that is not open to the world). At #7 we started to have some extra features more explicit on HAproxy.
But as this initial issue, we're already have some MVP on NLB.


Correct typos especially in VaGABfS.sh

It would be good if there were no more typos in the VaGABfS.sh code.

[x] Correct typos in comments
[ ] Correct typos in the whole code (You have to be careful here)

Corrected typos in comments

maybe you should alsow rename the picture


Update to compile in Overleaf and meet 2020 standards

This PR contains changes I needed to make to adhere to standards listed as of Fall 2020, when building in Overleaf. It does not seem like any of the actual standards changed, but the existing code to meet those standards was not working in Overleaf. The updates I made should work using other compilers and were primarily just moving a few command definitions within the blocks of code where they were used. The draft dissertation produced using the updated code was approved by OGSR as of November 2020.

Just wanted to add some clarification on specific Overleaf settings: I used the pdfLaTeX compiler and the 2019 TeX Live version.

@sgoodm Thanks a lot for keeping this template up to latest standard. Do you mind also update the README to update your contribution, which also indicates the users this template complies with latest requirement(2020 Nov.)

@yishanhe Absolutely, just pushed the update. Glad I could contribute back


plot progress offset index fix

added function and flag within utils.py to correct the offset index previously seen in plot_progress, the process_pbt flag in the function is defaulted to False

Thanks!


Dbi shortcircuit

https://groups.google.com/d/msg/dropwizard-user/SLi4deSPXus/Q0Bz1De_vfYJ

:ship: :it:...

I'll make the changes discussed, plus get the tests passing.

I've made the changes discussed, and squashed the commits. The biggest concern I have is the centralized executorService. It's not configurable, and should Environment own it?

Some minor improvements and, I think, we are done.

thanks for the feedback

Great, looks amazing.
Thanks for your contribution.


Run the bootstrap script AFTER the buildkite-agent user is created

This allows end-users to reference the buildkite-agent user in their bootscript to handle things like setting file/folder permissions.
My exact use case is that I install additional standalone binaries and folders that I need the buildkite-agent user to have access to even if they are not in the Administrators group.
Signed-off-by: Tom Duffield<EMAIL_ADDRESS>

Makes sense!


Exception: 400-{"code":"400002","msg":"Invalid KC-API-TIMESTAMP"}

I am trying to create a bot in python and I am using the python-kucoin-futures library. Every time I try to use the Trade module it throws me the exception:
Exception: 400-{"code":"400002","msg":"Invalid KC-API-TIMESTAMP"}.
Can someone help me to solve it.
Thank you.

Please try updating to the latest version of the SDK and modify your code to try again. If you encounter any issues, feel free to provide feedback.


Enums

Define how to represent enums.

Michal has agreed to describe the approach to this.

added in the latest version


DilBERT

Preparing the release for DilBERT (smaller, faster, lighter, cheaper version of BERT)

@VictorSanh Thanks for adding this :heart: (I'm currently adding this model to Flair)
One question: the BERT model configuration has a key hidden_size. For DilBERT it is now dim. Is this change intended 🤔


Update stored procedure example for latest Java SDK

The example of invoking a stored procedure in Java here seems to use an outdated SDK?
e.g. the code based around this call...
asyncClient.executeStoredProcedure(sprocLink, requestOptions, storedProcedureArgs)
    .subscribe(storedProcedureResponse -> {
        String storedProcResultAsString = storedProcedureResponse.getResponseAsString();
        successfulCompletionLatch.countDown();
        System.out.println(storedProcedureResponse.getActivityId());
    }, error -> {
        successfulCompletionLatch.countDown();
        System.err.println("an error occurred while executing the stored procedure: actual cause: "
                + error.getMessage());
    });

is not something that features anymore in the V4 SDK, which has (in my opinion anyway) a much simpler syntax.
See: https://github.com/Azure-Samples/azure-cosmos-java-sql-api-samples/blob/main/src/main/java/com/azure/cosmos/examples/storedprocedure/async/SampleStoredProcedureAsync.java
Wondering if we could update the example code here?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 239e3b2d-4a09-c6a1-ab36-70b60a18f8b5
Version Independent ID: 10a323f6-5a10-8b38-6339-48ee7a4c54b3
Content: Register and use stored procedures, triggers, and user-defined functions in Azure Cosmos DB SDKs
Content Source: articles/cosmos-db/sql/how-to-use-stored-procedures-triggers-udfs.md
Service: cosmos-db
Sub-service: cosmosdb-sql
GitHub Login: @timsander1
Microsoft Alias: tisande

Hi @dgpoulet Thanks for your findings,We will investigate and update as appropriate

I'm assigning this to the author for the feedback review

@dgpoulet, thank you for your feedback!
You are correct, multiple examples on this page aren't used the simplest and easiest to understand syntax with the latest SDK  version. This is a bigger update so stay tune for changes coming to this article.
#reassign:seesharprun

We have just made the changes. Expect to see them live very soon!
Thank you.


updating Date() object methods

I have updated Date object methods info according to current standards.
Reference : https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date

@nalkrish Thank you


Sieve Registry not loading

I have double checked my sieveregistry.json file with jsonlint.com

I have checked and made sure ex nihilo creatio mod and its dependency are up to date, and they are unless ive missed something.
Pastebin of Sieve Registry: https://pastebin.com/r2vFWaHN
Config file: https://pastebin.com/PKDNJpU3
If you need anything else let me know.

I solved my own issue. Upon further investigation the sieveregistry.json file had entries in there for mods no longer in the pack, and for some reason - rather ExNihiloCreatio skipping over these entries, for some reason it was marking the entire JSON invalid... After removing the Applied Energistics 2 and Natura entries the sieve registry loaded completely fine. Advise to add a feature in the mod to make erroneous or non existing entries in the sieve registry be skipped, rather than forcing someone to have to manually edit it every time a mod is removed or disabled for some reason.


[WIP] Fix/merge state bug

:white_check_mark: Build AElf <IP_ADDRESS> completed (commit https://github.com/AElfProject/AElf/commit/0f94e0353c by @zhxymh)


Apply background/distributed/gridded seismicity to inversions

As SRM team,
we want to apply an NZ model of background (off-fault) seismicity
so this information can be incorporated in rate models.

[ ] where/how is this data applied in ucerf3 (we believe the term "gridded seismicity" is used)
[ ] what data format is required (csep or similar?)

Hi @mcg-gns have I got the terms and the intent clear enough here?

Hi @mcg-gns have I got the terms and the intent clear enough here?

We will also need to implement uniform rate models which is a special case of gridded models in OpenSHA. The models probably aren't in CSEP format, that was just an optimistic hope. :)
We need to know if the format and model is any different in the spatial PDF (in the inversion constraints) than for what we will need for the hazard calcs.

Hi @mcg I got this is from @thingbaijam. I'm beleive  'smoothed seismicity' is a synonym for 'distributed seismicity', but we'll take a look at the code to try to confirm this.

@chrisbc About the input file format for smoothed seismicity models:
I locate these files at scratch.UCERF3.data.seismicityGrids.  These are *.txt (ascii) files with entries made in three columns (without heading) which can be identified as "latitude', 'longitude' and 'annual rate of seismic activity'.


Update sbt-scoverage to 2.0.10

About this PR
📦 Updates org.scoverage:sbt-scoverage from 2.0.9 to 2.0.10
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scoverage", artifactId = "sbt-scoverage" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scoverage", artifactId = "sbt-scoverage" }
}]

labels: sbt-plugin-update, early-semver-patch, semver-spec-patch, commit-count:1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-1.0%) to 75.595%

Files with Coverage Reduction
New Missed Lines
%

scassandra/src/main/scala/com/evolutiongaming/scassandra/CreateClusterJ.scala
1
54.55%

scassandra/src/main/scala/com/evolutiongaming/scassandra/ReplicationStrategyConfig.scala
1
74.07%

scassandra/src/main/scala/com/evolutiongaming/scassandra/SocketConfig.scala
1
69.23%

scassandra/src/main/scala/com/evolutiongaming/scassandra/util/FromGFuture.scala
1
78.57%

Totals

Change from base Build<PHONE_NUMBER>:
-1.0%

Covered Lines:
381

Relevant Lines:
504

💛  - Coveralls

Superseded by #242.


[azure-mgmt-monitor] Cannot get activity logs following documentation

I was following https://github.com/Azure/azure-sdk-for-python/blob/master/doc/sample_azure-monitor.rst#id1 to obtain activity logs for my Azure resource group and found few issues (possibly out-of-date documentation)

Importing from azure.monitor import MonitorClient fails
Importing from azure.mgmt.monitor import MonitorMgmtClient fails
Using UserPassCredentials fails with error adal.adal_error.AdalError... Due to a configuration change made by your administrator, or because you moved to a new location, you must enroll in multi-factor authentication to access...

The below is what I did to obtain the activity logs:

Import from azure.mgmt.monitor import MonitorManagementClient
Use service principal
Use monitor_mgmt_client to query for activity logs

See below for snippets of the functional code
from azure.mgmt.monitor import MonitorManagementClient
from azure.common.credentials import ServicePrincipalCredentials

subscription_id = '[redacted]'
TENANT_ID = '[redacted]'
KEY = '[redacted]'
CLIENT = '[redacted]'

credentials = ServicePrincipalCredentials(
    client_id = CLIENT,
    secret = KEY,
    tenant = TENANT_ID
)

monitor_mgmt_client = MonitorManagementClient(
    credentials,
    subscription_id
)
.
.
.
activity_logs = monitor_mgmt_client.activity_logs.list(
    filter=filter,
    select=select
)

Here is an useful resource for creating service principal through Azure portal (https://docs.microsoft.com/en-us/azure/active-directory/develop/howto-create-service-principal-portal). It will be great if someone can update the documentation accordingly! Thank you!

Hi, can you look at this updated sample? Thank you for bringing this to our attention and apologies for the old doc still existing, we will take actions to remove it. Thanks!

@iscai-msft Thanks for the change. Closing this ticket...


Is there a direct way to add Flex delegate to options in Android Tensorflow Lite 2.5 on C API ?

I'm trying to use tflite 2.5 and  a tflite model converted from tensorflow model and I need to use flex delegate  in android on a native level C api.
There is a method in c header lite\c\c_api.h
TFL_CAPI_EXPORT extern void TfLiteInterpreterOptionsAddDelegate(
TfLiteInterpreterOptions* options, TfLiteDelegate* delegate);
But: there is no api for creating TfLiteDelegate object.
Is it possible to use this TfLiteInterpreterOptionsAddDelegate method or  is this method just a prank?
I need an api for creating flex TfLiteDelegate  object and If such a method exitsts, where is it?

Hi @sachinprasadhs ! Could you please look at this query?

@karimnosseir could you help take a look? Thanks!

@fatihkiralioglu
You can use TfLiteInterpreterOptionsAddDelegate for sure. How to get TfLiteDelegate ? TfLite delegates expose C API functions to create TfLiteDelegate instances
example,
GPU
XNNPACK
Hexagon
For Flex Delegate, you don't need to add it as long as you're using TFLite which already built with TF Select support - see here for android build that links Flex.
We apply it automatically underneath.
Let me know if you have more questions.
Thanks

Closing. Please feel free to reopen if you have other questions/issues.
Thanks


RenderPixi.js - Add missing dependencies

When bounds are passed to the Pixi render, the Bounds and Vector objects are used but are not imported

Good spot, thanks!


Update to bevy 0.11

Waiting for renet release.

Codecov Report
Patch coverage: 96.93% and project coverage change: +1.12 :tada:

Comparison is base (03dd0d5) 94.67% compared to head (ab4be43) 95.80%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   94.67%   95.80%   +1.12%
==========================================
  Files          13       12       -1
  Lines         714      691      -23
==========================================
- Hits          676      662      -14
+ Misses         38       29       -9

Impacted Files
Coverage Δ

src/network_event.rs
50.00% <0.00%> (-25.00%)
:arrow_down:

src/server.rs
96.87% <95.00%> (+2.67%)
:arrow_up:

src/client.rs
100.00% <100.00%> (+5.10%)
:arrow_up:

src/lib.rs
100.00% <100.00%> (ø)

src/network_event/client_event.rs
96.66% <100.00%> (+1.21%)
:arrow_up:

src/network_event/server_event.rs
97.43% <100.00%> (+0.88%)
:arrow_up:

src/network_event/test_events.rs
90.62% <100.00%> (ø)

src/parent_sync.rs
100.00% <100.00%> (ø)

src/server/despawn_tracker.rs
100.00% <100.00%> (ø)

src/server/removal_tracker.rs
100.00% <100.00%> (ø)

... and 1 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Updates error messages to be more generic. Passes error stack to 500 …

Now the stack trace is shown in the 500 html page as well as console.error to the console for logging.
fixes #81

I'd love to make this pretty. Going to work on that next.

Minimal styling added.


Use VPTERNLOGD on GOAMD64=v4

Experimental. Test on Go 1.18 before release.

(Waiting for Go 1.18 release before merge)


Profile not accessible

Problem: I cannot access my Codewars profile in any way I try. Other people's profiles are accessible.
Error: 500 response with message "undefined method `getlocal' for<PHONE_NUMBER>:Fixnum"
Ways to reproduce:

Access via this kata and access profile via hover tab profile pic.
Access via main page and access profile via hover tab profile pic.
Access via going to the profile directly.
Access via going to the profile incognito/private mode.

Profile is accessible again.


Available physical on exact dimensions, not extra

Available physical on extra dimensions
The available physical quantity for all the dimensions that are shown in the grid.

This should be Available physical on exact dimensions, not extra

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5815c391-19d5-d867-1993-109e8c3f7612
Version Independent ID: a375dfbc-9f5b-c2ca-0d5f-9521c7fa96ca
Content: Inventory on-hand list - Supply Chain Management | Dynamics 365
Content Source: articles/supply-chain/inventory/inventory-on-hand-list.md
Service: dynamics-365-supply-chain
Product: ****
Technology: ****
GitHub Login: @yufeihuang
Microsoft Alias: yufeihuang

Bug 805365 has been logged to address this issue.

@cavensjan , thank you for reporting this error. We have now fixed it.


chore: refactor roots of unity to avoid PNat

This is an attempt to refactor the definition of rootsOfUnity using a Nat instead of a PNat.

In the definition of rootsOfUnity, we replace (n : ℕ+) by (n : ℕ). The definition does not require n to be nonzero; it gives that rootsOfUnity 0 M is the top subgroup of the unit group of M.
For results that need a positive n, we replace (n : ℕ+) with (n : ℕ) [NeZero n] in the parameters. In this way, they transparently apply when a PNat is used for n since n gets coerced to Nat and an NeZero (n : ℕ) instance is available.

The main benefit is that one no longer needs constructions like rootsOfUnity ⟨n, <proof that n is positive⟩) R when n is a natural number; one can simply use rootsOfUnity n R. (One may need to turn the positivity proof into an NeZero instance, however, if that is not available automatically.)
In addition, the code in Mathlib.RingTheory.RootsOfUnity.Basic can be simplified a bit in places, e.g., x ^ (k : ℕ) can be replaced by x ^ k and ∃ (i : ℕ), i < k ∧ P i can be replaced by ∃ i < k, P i. One result (eq_pow_of_mem_rootsOfUnity'; it was translating between Nats and PNats) can be removed altogether.
Since I was going through this file anyway, I took the opportunity to replace => by ↦ and to do some golfing as well.
What this PR does not do is also refactoring cyclotomic extensions to not use (sets of) PNats. This is a more complex matter and requires more thought and discussion.

Thanks a lot for doing this!
maintainer merge

Thanks :tada:
bors merge


update: bump libs version to b4c198773bf05486e122f6d3f7f63be125242413

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
/area engine
/area tests
What this PR does / why we need it:
This syncs Falco to the latest libs version. Some extra work is required in the code and the tests to align with the changes introduced in:

https://github.com/falcosecurity/libs/pull/392
https://github.com/falcosecurity/libs/pull/474
https://github.com/falcosecurity/libs/pull/491

Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
update: bump libs version to b4c198773bf05486e122f6d3f7f63be125242413

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.33.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 63469a135f7f719c2de874ac2aa234061037a76f


Failed angular build on master

Check that this is really a bug

[X] I confirm

Reproduction link
use the current master branch
Bug description
Failed npm run angular build. Cloned the project - run npm i then run npm run angular
Expected Behavior
To build a demo
Actual Behavior
Fails with

Swiper version
7.0.5
Platform/Target and Browser Versions
macOS
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

run npm run build:prod first

@nolimits4web  thanks. Got the demos working. Now I want to get a demo into my angular app.
Seeing the following when trying to follow the demos approach to adding it to my app. Slightly unsure of the approach though. I just want to use it in one component.
Perhaps I've missed something in the docs. But seeing the following error


Integrating with 3rd party PO/SO generation

First off, really impressive piece of software that fills a large hole in the open source community for SMB needs!  I have a question regarding 3rd party integration.  I would assume a large amount of people using InvenTree are small companies that use QB Online to handle purchase orders and Shopify/WooCommerce to handle sales orders.  I know InvenTree has an API, but I wasn't able to find any discussions on how people have specifically integrated InvenTree with other common applications.
Has anyone come up with a script to push PO's from Inventree to QB online, and/or pull sales orders from Shopify/WooCommerce into Inventree?  Or the more general question would be: how are people handling POs/SOs in multiple systems?

Hello @miniPCR-Jesse
Good questions and definitely relevant topic. My company does have a online shop but it's not yet connected to our inventory. It would be very interesting to develop tools to connect shopping systems to InvenTree.
I'm sure in the near future this is something we're going to want, and I'm going to volunteer to make it happen :smile:
In the meantime, could you share your experience in the details of such implementation such as:

connection between commerce/book-keeping platforms and InvenTree's API (do commerce platform have APIs too?)
chain of events after a sales order is placed on commerce platform
chain of events after a purchase order is recorded on InvenTree

@miniPCR-Jesse glad you are excited about the project :)
Currently I am working on a branch which adds a very crucial feature required for third party integration. It adds support for a background process runner, which can handle periodic tasks like checking third-party services for updates, and performing other actions like sending email, etc.
Once that branch is merged, then considerations of other third party integrations will be much easier!
In the mean time, as @eeintech  says, any information on how you might want to see such features integrated would be helpful.

I've been trying to get detailed info from our operations person, but he's been out for a bit.  Figure in the meantime I'll write out my best guess.
We use WooCommerce to handle all of our orders (orders are manually entered into WooCommerce if they're not made online) and Quickbooks Online for our accounting.  Both seem to have pretty thorough APIs implemented (documentation here and here).  QB has pseudo inventory-management but it's laughably bad (just a "qty on hand" field).
I think fundamentally there's three main events that require passing information between the systems:

Pushing PO info from Inventree to QB (one way)
Syncing Item information from Inventree to QB (one way)
Pushing Sales info between Inventree and WooCommerce (two way) and Inventree and QB (one way)

In my opinion the inventory management system should be the default source of info when it comes to vendors, part/BOM info, and sales orders (at least when it comes to part fulfillment) and so it acts as a middle man between WooCommerce and QB.
Purchase Orders
When a purchase order is marked as placed in Inventree the following actions would occur:

QB is queried to see if the vendor is in its database.  If not, the vendor is added to QB.
For each line item of the PO, QB is queried to see if the IPN in Inventree matches a SKU in QB.  For any that don't have a match, the item is added to QB.
The purchase order is created in QB and marked as open.

When a purchase order is marked as complete in Inventree the following actions would occur:

The purchase order is edited in QB to reflect the final line items and quantities.
The purchase order is marked as closed in quickbooks.
The QtyOnHand field in QB is updated for each line item.

Syncing item information
While not strictly necessary, this would make end of year tax prep much simpler.  The idea is that either at a regular interval or via a manual trigger Inventree will sync all item information and quantities with QB.  When the event happens the following actions would occur:

For each item in Inventree, QB is queried to see if the IPN matches a SKU in QB.  For any that don't have a match, the item is added to QB.
QB's QtyOnHand value for each item is updated with Inventree's quantity.
Optional: A report is generated that lists "dangling" items in QB (i.e. items in QB that have a SKU that does not match an Inventree IPN), along with its QtyOnHand.

Sales
This one is a little trickier since there's two systems and bi-directional info.
Either at a regular interval or via a manual trigger WooCommerce is queried for any sales order numbers that don't match an Inventree sales reference number.  For each one:

The customer is checked to see if there's a matching entry in Inventree, and a new customer is created if there is not.
A new sales order is created by matching the WooCommerce SKU to Inventree's IPN for each order line.

When a sales order is marked as shipped in Inventree, the actions would occur:

Update date_completed field of WooCommerce order.
Update stock_quantity for each item in WooCommerce.
Optional: WooCommerce has a shipping tracking extension that adds additional accessible fields to its API.  Ideally there would be a shipping tracking field that could be populated in Inventree that would be pushed to WooCommerce.
QB is queried to see if the customer is in its database.  If not, the customer is added.
For each item in the sales order, QB is queried to see if the IPN matches a SKU in QB.  For any that don't have a match, the item is added to QB.
A SalesReceipt is generated in QB.
The QtyOnHand field in QB is updated for each line item.

I think that covers all the major interactions between the systems.  There's some minor interactions (e.g. refunds/returns) which could be handled manually.  While I wrote this up with regards to the two platforms we use, I would guess that the flow of information would be similar across most accounting and e-commerce software.  I believe the other two big ones typically used in small companies are Wave and Shopify.  Hope this info is helpful!

I do not have experience with WooCommerce itself but when working with ticket-/inventory-/chat-systems  I came to appreciate webhooks for those tasks.
A Webhook is a api-call made to another system with a payload informing the other system of the triggering action and some additional information in the json-payload. Modern webhooks are singed for security. One can greatly reduce the number of background tasks required with webhooks as they just need to establish an (DRF) API-endpoint and the logic in the own system, ignoring the auth and api-structure for the triggering system.
Implementing a Webhook-system for calling other systems on a trigger is also not to difficult - although I do not like the library's I used so far for this project as all of them were either outdated or used celery for background tasks.
WooCommerce provides webhooks as well as QuickBooks.

@miniPCR-Jesse @SchrodingersGat I just had to implemented webhooks in a project and found this libary to be very fast in implementing and running, could be async with django-g. Also it is made by zapier, who i admire for their great webhook / api-based plattform

Looks very interesting @matmair !

Has there been any development on this? I'm looking at integrating inventree into an existing door and hardware supply company and 3rd party apps like quickbooks is a big deal for the end user. I'm considering setting up a test environment to play around with links to QB but in the past I've always looked at QB as an island that's very difficult to get data in and out of. Any insight that anyone has would be appreciated. Thanks

@Matthewmads not that I know of. From my side it seemed like there was low interest in this, so I did not pursue it further.
Intuit provides Webhooks so you could use django signals or DRF Webhooks to get changes to QB, a API-endpoint for call-backs from QB and background tasks for regular tasks. Maybe a changed Plugin-Interface will impact this effort (https://github.com/inventree/InvenTree/issues/749#issuecomment-873354778).

As far as I'm aware this issue is what's stopping the small startup I work for from using Inventree for inventory management. Given that we're actively looking at paid solutions, I may be able to convince them to back a paid bounty for successful implantation of integration QuickBooks / WooCommerce. Has something like this been done for any Inventree features in the past?

@miniPCR-Jesse the tech for getting and setting data would not be difficult but at least for QB there are strict security requirements.
Generally, if you or anyone else wants to try to implement it: be aware that especially handling the keys for 3rd party APIs has to be done right to avoid leaking financial data! I recommend asking @SchrodingersGat if he wants such confidential data in the mainline app before developing stuff.

Similar integrations have been requested for services such as opencart and shopify. In principle I am open and encouraging of the idea. The major caveat is that integration with any of these platforms would require intimate knowledge of them (which I don't currently have)!
However some of the recent major features implemented in InvenTree have been done so (at least partly) to be able to support these integrations.
For example, the addition of the "background worker" which could be extended to periodically communicate with an externally connected service.
As @matmair rightfully points out we would need to closely consider any security requirements...
If we can come up with a clear proposal and development path, I'd be supportive.

@SchrodingersGat I would be open to make a prototype implementation for a simple async webhook integration - would be for some sort of OSS website though.
The question is how proper implementations - which should be easy to be added and updated - should integrate into InvenTree. If they are directly in InvenTree it could be inferred that you/the project are responsible. A implementation like action plugins could be working used with git submodules. There should also be some sort of compatibility check (maybe via API version or version string).

@SchrodingersGat made a quick and dirty test implementation and there is a lot to figure out with this. Will loose reliable internet for the next week soon so I will leave my thoughts here for whomever wants to poke around.
I suggest a single API-Endpoint that will be called by incoming webhooks. API-Plugins (working title) register functions against a signal that triggers every time this endpoint is called. This enables multiple plugins to act on the same incoming hook. Each Plugin can define settings for itself in its modules init.py, which get shown in a separate tab in the InvenTree settings. This way we can handle keys safely (encrypting at rest etc.).
Additional webhooks get implemented and maybe a function for plugins to register additional hooks.
We should also establish a list with people that want to do specific implementations so we have people to ping about testing.

@Matthewmads @miniPCR-Jesse what plattforms would interest you and would you be up to develop and/or test the specific implementations for these? I would love to do the groundwork but I am reluctant to do stuff for things I do not know and use.

I like the idea of implementing a "plugin" system here. Even "first party" plugins that are developed could be implemented in this manner.
For example, we might have a "plugins" directory, under which each sub directory defines a plugin system.
Each "plugin" could have the following features (among others):
API Endpoint
An endpoint specific to that plugin / a way to hook into the plugin via the API
Settings
A sub-page under "settings" for that plugin to control it's own run-time configuration. For example, configuration of API keys, etc.
Tasks
A given plugin may wish to implement some background processes ("tasks") which run periodically
=======
Implementation
The first thing here would be to decide what a stable plugin architecture might look like. Previously I would have just started writing one and "winging it" - but InvenTree is now large enough that I'd like to consider it properly.

https://github.com/inventree/InvenTree/projects/1

@matmair yes I'd be interested in testing a quick books integration and potentially some others but im still learning so I think I would need some guidance. My role in this project is as a consultant helping to streamline workflows and make things more digital in an aging company.
I need to speak to my customer but a part of my deal is to set up a working inventory system and a training program for whatever system we end up on. I don't think they are opposed to putting a training program in the open domain but I will ask today and update this thread.

@matmair Similar answer to Mathewmads regarding interest.  My background isn't SW development, so I don't know how much help I'd be in that regard.  But if you're looking for someone to test some usage scenarios I'd be happy to lend a hand.

So I did a lot of prototyping and testing and here is a small roadmap what needs to be done (right, I have a very bad copied together prototype that works with QB).

[ ] OAuth / OpenID (and maybe SAML Login) is needed for managing logins for a lot of old systems --> django-allauth (also covers parts of #625, #634, #1693)
[ ] Webhooks themself (that seems to be a simpler one) --> something like rest-hooks not just that because it is unmaintained
[ ] Definition of all actions that need to have Webhooks (that will be WIP for a long time) --> RFC: I need input of what actions your applications need to be informed @Matthewmads  @miniPCR-Jesse
[ ] Plugin definition (that seems also to be ok, we basically can use what was done for action plugins)
[ ] Settings for plugins (no idea how to make that transferable -> so only stationary)
[ ] Update strategy for plugins --> git-submodules
[ ] plugin security (I am thinking of either checking hashes against GitHub or just using gpg singing) - this is very long term

@SchrodingersGat could you add issues #2036, #2037. # 2038 to the milestones for the plugin system as todo? I do not have sufficient rights to change anything in projects/milestones.

The plugin system is great. Does anyone know of a QuickBooks plugin that is functional?


avoid unnecessary fetch of related resources that are not included

@mathematikoi can you fix the linter errors?

will do