Roll Flutter Engine from de83ef6d2c26 to a3d5b5bc54ef (1 revision)

https://github.com/flutter/engine/compare/de83ef6d2c26...a3d5b5bc54ef
2022-10-21<EMAIL_ADDRESS>Add strong qualifier to dartEntrypointArguments. (flutter/engine#36929)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Multiple printers same PC not working.

I am trying to run Spoolman on two instants of moonraker on the same machine. They are separated by ports. One is port 7125 and the other 7126. They each have their own moonraker config in the following folders (7125 in RedRover_data/config and 7126 in WhiteLighting_data/config).
The version that has been working and still is, is 7126. When I change the active spool, in that machine, it works no problem. But when I try on the 7125 (RedRover) printer. Nothing happens. I have both moonraker.conf with the following.
[spoolman]
server: http://<IP_ADDRESS>:7912
I also try setting it manually with the curl commands but both old and new commands do not work for either machine. See txt file for details.
spoolman commands with errors.txt

The curl command has changed recently. You need to add /server before /spoolman in the URL.
See if that works.

Yup, that works for WhiteLighting (7126) but not for RedRover (7125). Which makes sense, since that is what I am experincing when I set in mainsail.

moonraker (3).log
It doesn't look like moonraker is recording anything for that command. I ran the command multiple times but I am not seeing any entry in the log.

Are you sure your moonraker is updated properly? POST /server/spoolman/spool_id should not be a 404 if you run the latest.

Yea, I don't think the WhiteLighting printer would work if I wasn't. But I did confirm.
solo@SoLoServer:~/moonraker$ git pull
hint: Pulling without specifying how to reconcile divergent branches is
hint: discouraged. You can squelch this message by running one of the following
hint: commands sometime before your next pull:
hint:
hint:   git config pull.rebase false  # merge (the default strategy)
hint:   git config pull.rebase true   # rebase
hint:   git config pull.ff only       # fast-forward only
hint:
hint: You can replace "git config" with "git config --global" to set a default
hint: preference for all repositories. You can also pass --rebase, --no-rebase,
hint: or --ff-only on the command line to override the configured default per
hint: invocation.
Already up to date.
solo@SoLoServer:~/moonraker$

You may be tricked that it is up to date if you're on the wrong branch. Do a git checkout master then git pull again. After that, in the update manager in Mainsail, you should see the following version:

I confirmed that I am on the correct version that you took the screenshot
of and I also did the get checkout branch and get pull still says I was up
to date.
I have a print going now but when it finishes I will reboot the server.
I also went to the web browser to check the active pool like you suggested
in the other thread and it works for my white lightning but not for this
one we're having issues with. I get the 404 error
On Fri, Jun 30, 2023, 2:30 PM Donkie @.***> wrote:

You may be tricked that it is up to date if you're on the wrong branch. Do
a git checkout master then git pull again. After that, in the update
manager in Mainsail, you should see the following version:
[image: image]
https://user-images.githubusercontent.com/2332094/250168364-295f0ad9-5ab2-4dcc-a2de-f3801335de51.png
—
Reply to this email directly, view it on GitHub
https://github.com/Donkie/Spoolman/issues/21#issuecomment-1615041691,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOQWWRJREMTO2X7SD2MNLDXN4LLNANCNFSM6AAAAAAZ2CAAKQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Maybe a restart is what's necessary then, keep me updated :)

Reboot did it. thanks again!

Great, no problem!


Angular 13: Use HttpContextToken to make handling of special case errors easier

For https://github.com/keptn/keptn/issues/6297 a special case workaround had to be introduced. If we would make use of the HttpContextToken (https://angular.io/guide/http#creating-a-context-token) we could handle such cases in a more generalized way.
The prequisite for that is the update to Angular 13, as this is only supported > 12.
My suggestion would be, if special errors are needed to have it with a Bypass code.

Set the BYPASS_CODE => 409 for the request.
In Interceptor: Check if the token is set and if the error code matches

This can be handy for i18n.
DoD

Introduce the bypass
Remove the workaround of #6297
Unit tests

Dependencies

#6731

This tickets depends on Barista to be updated to Angular 13


Allow site-wide asset replacement on DoltLab

Allow DoltLab administrators to replace the DoltLab logo with custom assets so that they can supply their own logos/brand instead. The DoltLab instance can then display the custom assets but say "powered by DoltLab" below.

This includes allowing administrators to change colors/themes/fonts

Available in https://github.com/dolthub/doltlab-issues/releases/tag/v0.7.6


Fix initialScore and finalScore (#37)

The cutDistanceScore was not included in the initialScore and finalScore.

Fix initialScore and finalScore calculation (fixes #37)
Expose cutDistanceScore
Included cutDistanceScore in protocol.md

This is a mergeback from the upstream repo.


Github and Twitter pickers do not highlight active colour on init

When initialized with prop color, the Github and Twitter pickers do not highlight the active colour.
All of the other colour pickers appear to update their active colour state, highlighting the active one.
This issue can be easily reproduced in the demo:

Select a colour in the Github picker (or the Twitter picker)
Copy its hex value from any of the pickers that display it to your clipboard
Choose a different colour by clicking any of the pickers
Paste the copied colour from your clipboard into one of the pickers that support receiving hex values

Results:

Twitter does not update its active colour state
Github does not update its active colour state
Circle does update its active colour state (as do all the others)

Expected results (when receiving one of its included colours):

Github picker has the 2px white outline
Twitter picker has the active/hover state

Hello. I think the native behavior of these components is to, first after being selected stay highlighted ant then, after clicking any other element (Even if they are not the color pickers) the highlights disappear.
I don't know If this is what the creator intended but, If it's not, I think there should be a way to, in order to update the colors, modify the state of those components to "re-highlight" the choice.
I think I actually works like this because of the "limited pallete" the pickers have.

This is indeed the expected behaviour and is a bug. I am tagging it in the next release to make sure it gets fixed.


picpick: Update the download link

What type of Apps related PR is this? (check all applicable)

[ ] ✨ Add Manifest
[ ] ♻ Refactor
[x] 🐛 Bug Fix
[ ] 👷 Optimization
[ ] 🚩 Other

Description
Change the download URL to fit the new one
Related Tickets & Documents
Fixes #122
[optional] What gif/emoji best describes this PR or how it makes you feel?
👽 🐛
Did you verify the followings
Add/Modify a description in the manifest?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Check URLs?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Update to the latest version?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Update Hashes?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Format the json manifest?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Did you identify extra steps
Notes in the manifest?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Application Dependencies?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Application Suggestions?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Pre-installation steps to perform?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Post-installation steps to perform?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

File persistence to perform?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

All changes look good.
Wait for review from human collaborators.
picpick

[x] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate


Add a lexer for .spec files used for creating RPM packages (Linux distros)

This is WIP still, I don’t know what’s wrong with it, but vis doesn’t show anything.

Commited via https://github.com/orbitalquark/scintillua/commit/ecafeda70fc29602773101620ed345e10bd3325b with some styling changes and substitution for deprecated functions.


Fix iam-users output.

When a user gets deleted from user list Terraform will fail
creating a plan complaining that number of keys doesn't match
number of values.
Th solution is taken from https://github.com/terraform-google-modules/terraform-google-cloud-storage/pull/23/files
Example error seen:
  19:   value       = zipmap(var.user_list, aws_iam_user.u.*)
    |----------------
    | aws_iam_user.u is tuple with 8 elements
    | var.user_list is list of string with 7 elements

Call to function "zipmap" failed: number of keys (7) does not match number of
values (8).

Confirmed in slack.

It looks like using count is a problem here and it makes sense to switch to using for_each instead with a set of user names


[GPU] update debian OS to use latest nvidia driver.

Seems like there are issues when creating custom images with debian OS and nvidia driver, upgrade driver version. Latest driver version works all cuda versions.

/gcbrun


Several issues in discord

Q
A

Issue Type
Bug

Deployer Version
6.2

Recipes Version
6.1

Local Machine OS
Ubuntu 17.10

Remote Machine OS
Debian GNU/Linux 8 (jessie)

Description
I'll just want to notify you that in the Discord recipe the namespace Deployer; statement is missing. Without that it comes to this error [Error] Call to undefined function set()    . I think there was also some API changes? The callback gets called once cause of config cache for callbacks result? And the placeholders in the array doesn't got replaced.
Solution
I edited the discord file and came to the following solution. This solution fix all the above issues.
<?php
/* (c) Lucas Mezêncio<EMAIL_ADDRESS> *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Deployer;

use Deployer\Task\Context;
use Deployer\Utility\Httpie;

set('discord_webhook', function () {
    return 'https://discordapp.com/api/webhooks/{{discord_channel}}/{{discord_token}}/slack';
});

// Deploy messages
set('discord_notify_text', ':information_source: **{{user}}** is deploying branch `{{branch}}` to _{{target}}_');
set('discord_success_text', ':white_check_mark: Branch `{{branch}}` deployed to _{{target}}_ successfully');
set('discord_failure_text', ':no_entry_sign: Branch `{{branch}}` has failed to deploy to _{{target}}_');

set('discord_type', 'discord_notify_text');

// Helpers
task('discord_send_message', function(){
    Httpie::post(get('discord_webhook'))->body(['text' => get(get('discord_type'))])->send();
});

// Tasks
desc('Just notify your Discord channel with all messages, without deploying');
task('discord:test', function () {
    set('discord_type', 'discord_notify_text');
    invoke('discord_send_message');
    set('discord_type', 'discord_success_text');
    invoke('discord_send_message');
    set('discord_type', 'discord_failure_text');
    invoke('discord_send_message');
})
    ->once()
    ->shallow();

desc('Notify Discord');
task('discord:notify', function () {
    set('discord_type', 'discord_notify_text');
    invoke('discord_send_message');
})
    ->once()
    ->shallow()
    ->isPrivate();

desc('Notify Discord about deploy finish');
task('discord:notify:success', function () {
    set('discord_type', 'discord_success_text');
    invoke('discord_send_message');
})
    ->once()
    ->shallow()
    ->isPrivate();

desc('Notify Discord about deploy failure');
task('discord:notify:failure', function () {
    set('discord_type', 'discord_failure_text');
    invoke('discord_send_message');
})
    ->once()
    ->shallow()
    ->isPrivate();

Thanks! Fixed in 4b66561afe0e48c8c85b0865bb61494f20f0fb1c

@antonmedv As I mentioned there are some more bugs.
Cause of the option cache for configuration (https://github.com/deployphp/deployer/blob/master/src/Configuration/Configuration.php#L87) the callback can‘t be executed. They don’t receive the argument that is given here https://github.com/deployphp/recipes/blob/master/recipe/discord.php#L34
I also receive messages without the replacement of the placeholders. That comes from here https://github.com/deployphp/deployer/blob/master/src/Configuration/Configuration.php#L120 cause parse of arrays isn’t implemented.

Can you send PR to fix it?

@antonmedv sure, what do you think about the solution I posted above? Are there any other ways ?


Release/2.6.0 pt2

Something went wrong with PR preview build please check

Preview is available here:http://laboratory-pr670.previews.kube001.services.stellar-ops.com/


user provided compression/decompression for record batches

PR for #80
this makes #79 a non-issue and allows this lib to focus on kafka protocol instead of various decompression routines.

I'm not sure I agree that compression is unrelated to the library's function. Is there a reason why we can't improve the ability to configure the particular codec configuration rather than rip everything out? Alternatively, we could add a "bring your own compression lib" option without removing the existing options?
As it stands, this PR would cause churn for our existing production users without much benefit to them.

this library has never really supported compression fully.
2 of the 4 compression algos have been contributed by members of our team. and we are constantly having to create bug reports to add fixes to it.
the compression part simply isnt production ready. it doesnt have the testing it needs and scenarios like choosing custom compression levels are not covered.
making the compression user provided is the best way to go.

I think that compression is very much a part of the kafka protocol.
And since this crate allows users to encode and decode the entire kafka protocol it should support all kafka supported compression out of the box.
However:

We should put each compression algorithm behind a feature flag enabled by default
Exposing a way for users to provide custom compression algorithms could be nice, I can see use cases where a service might be kafka compatible but support extra compression algorithms.

For your team this should be equivalent to ripping out the existing compression and adding custom compression logic: just disable all the compression features and then provide a custom compression algorithm.
If collaborating with upstream is too much overhead for your team feel free to fork the project and implement it yourself.
Since there is a clear split between the kafka protocol and the record level protocol (where compression occurs) you can continue using upstream version of this library for the kafka protocol, and then use a fork of this library for the record level protocol.

i have modified the PR so the change might work for all parties.
The provided custom compression/decompression method is now an Option.
So if the user wants to use the inbuilt compress/decompress of this lib, he can just pass None.
Otherwise he can provide a function via Some(my_func) to do custom compression/decompression as needed.
this way existing users only have to pass a None when upgrading.


fix: Token now pattern matches correctly

I've added fixes as per https://github.com/lark-parser/lark/issues/1180#issuecomment-1214921614. I don't think that the backward compatibility is possible in this case, as the original argument is positional, e.g.
Token(type_="TEST", value="test") # this will break no matter what, as positional arguments are not set properly

Token("TEST", "test") # this doesn't require any backwards compatibility changes

Please correct me if I'm missing something.
I've also added a bunch of tests (which only are run if the version is 3.10 or higher).
I wasn't sure how to use assert statements in structural pattern matching, but it does the job.
closes #1180

Also, the update method should also be updated with the changed parameter name.

Fixed, also added setter for .type_.

It is possible to provide backwards compatibility by not making type and value be required positional arguments, but instead use *args and **kwargs and have the actual supported signature(s) be only present in @overload declarations. But I am not sure if this should be done, you are correct that this is more work than I originally thought.

Please let me know if you think this should be added, I'm happy to figure it out.

I was thinking we'll just add a new param, type_=None, and change inst.type = type to inst.type = type_ if type_ is not None else type
The downside is we'll have to set type and value to None too. But it doesn't break anything.
Btw, why not just do __match_args__ = __slots__ = (...) ?

I was thinking we'll just add a new param, type_=None, and change inst.type = type to inst.type = type_ if type_ is not None else type

That would make the typing inconsistent between new and the parameters.
The args thing seems to be ok.

Btw, why not just do match_args = slots = (...) ?

Does order of __slots__ matter? Because I think that __match_args__ should be in the same order as args to new and update

P.S. we'll also need a deprecation warning for any use of type_

On it.

Hey,
I've figured out that the easiest way to use *args and **kwargs with @overload, was to create methods for the old and new signatures and call them from the overloaded one.
Otherwise, I would have to manually write all the parsing of *args and **kwargs including errors etc. which would've been a huge mess.
Also, this way will allow you to replace the code with the new version easily.
One caveat is that the errors will contain one of the wrapped functions names (still should be easily readable), e.g.:
TypeError: Token._deprecated_new() got multiple values for argument 'type_'

Also DeprecationWarnings are supressed by default. I'm not sure if you want to change this, so I left it as it is.

Also, I'm pretty sure it would be nice to add proper typings to Token.__new__ and to fix the typings for Token (most of the stuff there should be Optional), but it's not really in scope of the PR.

Why did you write
    def __new__(cls, *args, **kwargs):
        if "type_" in kwargs:
            return cls._deprecated_new(*args, **kwargs)

        return cls._future_new(*args, **kwargs)

Instead of just - ?
    def __new__(cls, *args, **kwargs):
        if "type_" in kwargs:
            kwargs["type"] = kwargs["type_"]

        return cls.same_new(*args, **kwargs)

Also DeprecationWarnings are supressed by default.

What do you mean?

most of the stuff there should be Optional

That's true! We should fix that.

Why did you write
def __new__(cls, *args, **kwargs):
    if "type_" in kwargs:
        return cls._deprecated_new(*args, **kwargs)

    return cls._future_new(*args, **kwargs)

Instead of just - ?
def __new__(cls, *args, **kwargs):
    if "type_" in kwargs:
        kwargs["type"] = kwargs["type_"]

    return cls.same_new(*args, **kwargs)

Both should be fine, but in the first one, errors will be more readable:
TypeError: Token._deprecated_new() got multiple values for argument 'type_'

makes more sense if you put in something like Token("a", "A", type_="a"), as opposed to (which would be the error in your version):
TypeError: Token._deprecated_new() got multiple values for argument 'type'

It's supposed to be removed, so I wouldn't worry too much about code duplication.

Also DeprecationWarnings are supressed by default.

What do you mean?

The warnings don't really show until we change the configs:
https://stackoverflow.com/a/20960427/7416999
At least they didn't show to me, when I tested this.

Earlier you wrote about adding a type_ parameters.

That would make the typing inconsistent between new and the parameters.

Can you please explain that a little bit more?

Unless we want to allow Token.type and Token.value to be optional, which would be a relatively big, and unnecessary change (as the @overload solution works), having type and value as optional in __new__ would lead to undefined behavior or require us to add runtime errors like TypeError("at least one of type and type_ has not to be None"). Having types properly statically checked might save some errors from happening on runtime.

That's true! We should fix that.

Fixed types and added typings to Token.__new__.

errors will be more readable:

That's a bit of a nitpick. I can easily add this, and get an even better error -
def __new__(cls, *args, **kwargs):
    if "type_" in kwargs:
        if "type" in kwargs:
             raise TypeError("Error: using both 'type' and the deprecated 'type_' as arguments.")
        kwargs["type"] = kwargs["type_"]

    return cls.same_new(*args, **kwargs)

The warnings don't really show until we change the configs:

That link is from 2014. But when I test it in Python 3.10 -
>>> import warnings
>>> warnings.warn('test', DeprecationWarning)
<stdin>:1: DeprecationWarning: test

errors will be more readable:

That's a bit of a nitpick. I can easily add this, and get an even better error -
def __new__(cls, *args, **kwargs):
    if "type_" in kwargs:
        if "type" in kwargs:
             raise TypeError("Error: using both 'type' and the deprecated 'type_' as arguments.")
        kwargs["type"] = kwargs.pop("type_")

    return cls.same_new(*args, **kwargs)

I don't know if this is necessarily a better error, as it does nothing to address my use case (which while valid, I admit is really minor). It's just a different error.
Nevertheless, I've added it, as I believe it makes a lot of sense here.
As I've said, both versions are fine to me, so I've changed to the one you prefer.

That link is from 2014. But when I test it in Python 3.10 -
>>> import warnings
>>> warnings.warn('test', DeprecationWarning)
<stdin>:1: DeprecationWarning: test

That link is 100% valid still. Please look at python docs regarding warnings.
Also, you can test it by importing from a module that warns DeprecationWarning. As far as I understand, warning filters are different in the interactive shell.
The issue can be solved by adding:
warnings.simplefilter('default', DeprecationWarning)

to the top of this file, but it breaks the standalone version, which I really don't understand. So, I'm leaving this the way it is.

Thanks!
I see, you're right, the behavior changes for imported modules. I'll look into adding it.

In regards to Deprecation Warnings: They should be silenced by default, if someone cares they need to add it themselves We shouldn't do that in the library.


[CDS-88535]: Add notes for creating file store api with different identifier.

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screenshot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65f27b150579a27340cb285f--harness-developer.netlify.app


[ADD] Handle regex to exclude specific rules from module

Hello,
first of all thanks for this great tool !
I have a question about the documentation of modularization.([https://snakemake.readthedocs.io/en/stable/snakefiles/modularization.html])
In the sub section Modules, you show an example of excluding rules from specific modules.
I was wondering, is there any way to exclude rules based on regex expression ? For example 'exclude ruleC_*'.
Thanks for your answer.
Best regards,
Kevin

Not currently possible afaik, but looks like a potential addition. If you want to edit your title, this can be recast as a feature request

Thanks Peter, I updated the title.


before/after hooks

Allow components to hook into other instance methods.
The API is not yet decided but one proposal is something like:
// for server hooks filtering by function name
static async before({invoker}) {
  if(invoker.methodName === 'somePrivateMethod') {
    response.status(401);
  }
}

// for instance hooks that run after every method
prepare({instances}) {
  instances.counter.after(({invoker}) => {
    invoker.count++;
  })
}

hooks should be able to modify the context
static async before(context) {
  const {database, request} = context;
  const user = await database.collection('users').findOne({email: request.session.email});
  if(user) {
    context.user = user;
  } else {
    response.status(401);
  }
}

The best idea so far is to extend plugins to allow them to control the flow of client and server functions

this was a bad idea and can be replaced by express middlewares :poop:


debug: surface StackFrame moduleId in the debug CALL STACK UI

Go debug adapter (delve) has been using the fully qualified go function names as the stack frame names.
These names include the full package path (e.g. example.com/foo/bar) and the function name (e.g. pkg.ACoolFuncName), and many users requested to shorten the names presented in the CALL STACK view. For example,  https://github.com/microsoft/vscode/issues/178964, https://github.com/golang/vscode-go/issues/2707.
One way to handle this is to shorten the name by dropping the full package path.
For example, our contributor is proposing to control this by adding a new launch config setting.
https://github.com/go-delve/delve/pull/3497 I think it makes sense to show the function name,
but I wonder if we can still carry the package info ("module" in other languages).
StackFrame has the moduleId field.
The current VS Code doesn't seem to utilize this field at all.
How about utilizing the moduleId field and surfacing it in the UI?
I think the tooltip shown when hovering over the stackframe name is a good option.
Screenshot with a small change in callStackView.ts and a delve-side change:

One concern is it will be surprising for other language debug adapters that use the moduleId field already for other purposes.
cc @suzmue @stefanhaller @aarzilli

Your proposal seems fine to me! I would take that PR

Wait a sec, moduleId is a number, so I think it won't be a string here and you need to resolve this to a Module with that id, right? https://github.com/microsoft/vscode/compare/main...hyangah:vscode:debugstackframe#diff-4ae236e16b22d9f993abf02e13ede86c77b7dd429159cb0be03c3c449335d54eR592

moduleId is number | string.
Even though the StackFrame spec is not explicitly stating the meaning of moduleId, I think you are right. moduleId seems to be Module's id and the client has to use ModulesRequest to retrieve the module information. And client has to use ModulesRequest only if the debug adapter declared supportsModulesRequest=true.
Unfortunately, VS Code does not seem to use the Modules Request feature yet. (Correct me if not true) Not many debug adapters implement that either.
llvm/llvm-project's  lldb-vscode (module id is a uuid) and microsoft/debugpy dap (unique number) are one of the few that has supportsModulesRequest=true.  For them, showing the moduleId value wouldn't be ideal.
Alternative proposals:

If the debug adapter does not support ModulesRequest but the moduleId is not empty, include the value in the tooltip. - exploiting unspecified part of DAP. When VS Code eventually implements and can issue ModulesRequest, it may choose to show the resolved module name. This way, we won't break the existing debug adapters, and we won't break the future VS Code that implements ModulesRequest.

Promote https://github.com/microsoft/vscode/issues/148125 and wait for VS Code to provide StackFrameFormat in StackTrace requests.  (However, it's still unclear to me what DA is supposed to do when StackFrameFormat has module=true).

I also tried to format StackFrame's name in a way that can fit better in a narrow debug callstack panel, by placing the module path at the end. But that hides the source location info. That's not great.

Oh, I misread it. To me it's clear that this is meant to refer to the id of Module and I wouldn't try to hack around that to display the value directly. I would like to close some of the DAP implementation gaps in vscode, so #148125 and supporting ModuleRequest would be the best fix in the long run, but those won't be added soon. The DebugAdapterTracker possibility mentioned in that other issue would be a good one for you too. I'm going to close this in favor of the other issue.

Thanks. Agree that closing the gap is the best.
However I don't understand how the DebugAdapterTracker solution could be a workaround for this tbh (note that the workaround was suggested in the context of the value presentation, not the stack frame name presentation) - we want to present both function name and module name in a user friendly way. Concatenating all and supplying a long string as a stack frame doesn't produce good outcome. Can you please help us understand how the tracker can help control what to present on tooltip?


Add support for Microsemi Mi-V softcore

This PR adds support for the Microsemi Mi-V soft core. The code has been tested on the M2GL025 IGLOO2 FPGA development board.
The PR adds three commits:
The first one disables the PLIC (RISC-V Platform Level Interrupt Controller) driver for the QEMU target. This is required because QEMU does not use PLIC. Without this change the second commit of this PR would not build for the QEMU target.
The second one moves the generic RISC-V code from the FE310 board to the common/ folder, so it can be reused by other platforms.
The third commit adds support for the Microsemi Mi-V soft CPU.
There are two things to discuss in this PR:

This PR does not add DTS support for the RISC-V boards. There is a PR open for the QEMU target which should be merged first (#7543)
We think that the riscv-privilege folder should be renamed to riscv-privileged as this is the correct name of this version of the RISC-V ISA (https://riscv.org/specifications/privileged-isa/). Nonetheless, the renaming is not a part of this PR, but could be discussed here.

Codecov Report

Merging #8319 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8319   +/-   ##
=======================================
  Coverage   64.53%   64.53%
=======================================
  Files         420      420
  Lines       40122    40122
  Branches     6763     6763
=======================================
  Hits        25892    25892
  Misses      11110    11110
  Partials     3120     3120

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f9a642...c9bd293. Read the comment docs.

Hi, I think we need @dbkinder to ACK us here and we're good to go?


Error resolving route - layer.match is not a function

Hi,
We are running into an issue where we are seeing sometimes express server going to a bad state and all requests started to fail with the following stack trace.
Versions
"express": "4.16.1"
"inversify-express-utils: "6.3.2"
TypeError: layer.match is not a function
at matchLayer (/sample-api/node_modules/inversify-express-utils/node_modules/express/lib/router/index.js:574:18)
at next (/sample-api/node_modules/inversify-express-utils/node_modules/express/lib/router/index.js:220:15)
at Function.handle (/sample-api/node_modules/inversify-express-utils/node_modules/express/lib/router/index.js:174:3)
at Function.handle (/sample-api/node_modules/inversify-express-utils/node_modules/express/lib/application.js:174:10)
at Server.app (/sample-api/node_modules/inversify-express-utils/node_modules/express/lib/express.js:39:9)
at emitTwo (events.js:126:13)
at Server.emit (events.js:214:7)
at Server.wrapped (/sample-api/node_modules/newrelic/lib/transaction/tracer/index.js:181:22)
at Server.wrappedHandler (/sample-api/node_modules/newrelic/lib/instrumentation/core/http.js:215:47)
at Server.wrapped (/sample-api/node_modules/newrelic/lib/transaction/tracer/index.js:181:22)
at Server.wrapTransactionInvocation (/sample-api/node_modules/newrelic/lib/transaction/tracer/index.js:108:8)
at Server.wrappedEmit [as emit] (/sample-api/node_modules/newrelic/lib/instrumentation/core/http.js:487:28)
at parserOnIncoming (_http_server.js:660:12)
at HTTPParser.parserOnHeadersComplete (_http_common.js:119:17)

Looking at the latest code, it seems fine. Can you please check and update ?

Hi @keerthy-cf I'm sorry you're having issues here. I have honestly never seen that error before (myself or reported), so definitely strange. The error is saying that the layer variable is defined, but there was no match property on it. All the objects in the layers array should be of the Layer type (which have this method: https://github.com/expressjs/express/blob/master/lib/router/layer.js#L110).
Is there any way we can reproduce the issue to determine what is happening?

Hi @dougwilson
Ya it's very starange as layer object always have match defined during the creation. There is no proper repro for this. We are  running into this problem randomly once in a while and all of a sudden this error will start happening. Once went to this state we have to restart the process to get it back to working. 3 instances of this occurrence in last one week.

I saw some stackoverflow link but with no clear resolution there too - https://stackoverflow.com/questions/54761100/layer-match-is-not-a-function

Hi @keerthy-cf thanks for that link. Yea, it also doesn't have any indication as to the cause, and as such, there is no clear course of action to make a fix. If there is anything you can provide to help, be it a fix to the issue, a heap dump at the time of the error, code that you're running, that would help a lot.

We experienced this problem on a production server as well. It only affected one instance. Stacktrace is below, showing that this triggered even without inversify-express-utils in the loop as well.
Annoyingly we don't know the trigger so were not able to replicate. @dougwilson if we encounter this problem again in production, how'd you like us to go about a head dump? Easiest thing to capture for us seems to be a coredump through gcore
TypeError: layer.match is not a function
    at matchLayer (/usr/local/src/app/node_modules/express/lib/router/index.js:574:18)
    at next (/usr/local/src/app/node_modules/express/lib/router/index.js:220:15)
    at Function.handle (/usr/local/src/app/node_modules/express/lib/router/index.js:174:3)
    at Function.handle (/usr/local/src/app/node_modules/express/lib/application.js:174:10)
    at Server.app (/usr/local/src/app/node_modules/express/lib/express.js:39:9)
    at emitTwo (events.js:126:13)
    at Server.emit (events.js:214:7)
    at parserOnIncoming (_http_server.js:619:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:115:23)

I'm not familiar with gcore do cannot comment on that. As long as I can open the v8 heap using the v8 debugger, then it is fine.
You can also send the node process the USR2 signal when it is in this state to get a dump.
Or you can use https://www.npmjs.com/package/heapdump and add some logic to see when this error happens and write out the dump.

We have started getting this in production more and more in the last few weeks. Our symptoms and attempts to diagnose it are the same as @keerthy-cf

So there has been no release of Express recently and I have looked at the stack trace and code and no solution came to mind. All I can guess is something is manipulating Express internals? The error itself happens within a try block and is forwarded like any other error to be written as a response.
Until there is some kind of reproduction case here or heap dump or something, there isn't much I can do, unless you have any suggestions?

I've noticed this error happens only in production in my app, and tracked it down to the @sentry/node package, specifically when both the Sentry requestHandler and errorHandler middlewares are being used. I'm not sure if this is actually a bug with Sentry, a bug with my usage of Sentry, or a bug in a dependency used by Sentry. Curious if anyone else on this issue has had this issue who is not using Sentry.

Updating @sentry/node to 5.1.0 seems to have fixed this issue for me. Again, no idea if it's the only package that causes this issue, so don't know if this is resolved, but for anyone else running into this issue it may be worth checking.

Thanks @thomasboyt . Was this the same cause for you @keerthy-cf @freenerd and @webdevian ?

Yes, I think this was the same cause for me too, just updated it @dougwilson

We updated to node 10 and retained sentry @4.6.2 and ran into a memory leak problem caused by node 10 + sentry 4.6.2 described here https://github.com/getsentry/sentry-javascript/issues/1762. Now our current setup is node 11 + sentry @4.6.2 and have not seen the issue so far. Mostly looks like something to do with sentry but not clear as what exactly caused this.
With respect to  updating @sentry/node to 5.1.0, there seems to be a memory leak issue along side node 10 / 11 described in the same link - https://github.com/getsentry/sentry-javascript/issues/1762.

@dougwilson We found that it happens whenever headers are sent twice. We found a culprit package that was calling a callback twice (https://github.com/openexchangerates/npm-exchange-rates/issues/9) and thought replacing that had fixed it, but we've had one more incident since.
We do use Sentry<EMAIL_ADDRESS>so it looks likely that that is the cause, I will try upgrading that now.

Any reproduction steps narrowing it down to something express can fix would be helpful, otherwise I think we can close this issue as a known bug (that's fixed) in a third party module?

Closing since I guess the answer is no.

I am trying to do the following: app._router.stack.splice(0, 0, express.json()); and getting the error above.
My goal is to insert a route at the begging of my app after the app has been exported. I am doing this for testing purposes.


Fkey and pke

MAJOR changes introduced, not backwards compatible.
Note to reviewers, please check out and test locally.

primaryKey has been removed from input csv and its use in the scripts has been altered to instead generate a primary key on the fly called pg_id
When importing an oracle layer, objectid is always imported into the non spatial table and new join key pg_id is created
primary key for gr_skey table is set to gr_skey and a foreign key constraint was added on pg_id to non spatial table
When importing a geopackage, shapefile, gdb, or raster, the script now copies the layer from its source path to out_tif_path, imports data and then removes it. This was done to ensure the pgid created during the ogr2ogr import will be the same as the pgid created during the gdal_rasterize step. An additional benefit is the user does not have to copy locally for speed improvement.
Added comment to non spatial and gr skey table with metadata from input CSV
Tested on inputting shapefile, geopackage, fgdb, oracle layer with & without where query, with & without fields2keep
input csv has been renamed from inputsDatasets2load2PG.csv to config_parameters.csv
changed default mask_tif from S:\FOR\VIC\HTS\ANA\workarea\PROVINCIAL\BC_Lands_and_Islandsincluded.tif to the same directory but new tif: BC_Boundary_Terrestrial.tif. BC_Boundary_Terrestrial.tif lines up with the current coastline better and includes previously missing Gregory Island and the southern half of Kaien Island (Prince Rupert)
Altered formatting, variable and function nameing to follow: http://adv-r.had.co.nz/Style.html
notes column was added to config_paramters.csv
metadata table inserted into / modified upon new table import, defaults to whse.data_sources
R library name changed from faibDataManagement -> faib_dadm_tools
some documentation updated
example published for new usage of str_sql_joins (previously know as sqljoins_asstring)

Change log for filename & function name change:
filename:  add_data_2_pg_grskey_grid.R --> import-to-pg-gr-skey.R
fun name:  add_data_2_pg_grskey_grid   --> import_to_pg_gr_skey
batches add_data_2_pg_grskey_grid
filename:  add_batch_2_pg_grskey_grid.R --> batch-import-to-pg-gr-skey.R
fun name:  add_batch_2_pg_grskey_grid   --> batch_import_to_pg_gr_skey
-- this should probably be the above with a flag
filename:  add_data_2_pg_grskey_with_overlap.R --> import-to-pg-gr-skey-overlap.R
fun name:  add_data_2_pg_grskey_with_overlap   --> import_to_pg_gr_skey_overlap
filename:  createMaskFromVect.R --> create-mask-tif.R
fun name:  createMaskFromVect   --> create_mask_tif
filename:  createOracleFDWpg.R --> create-pg-fdw.R ## make sure it works for creating pg FDW
fun name:  createOracleFDWpg   --> create_pg_fdw
filename:  df2PG.R --> df-to-pg.R
fun name:  df2PG   --> df_to_pg
filename:  dfColNames2lower.R --> lowercase-df-colnames.R
fun name:  dfColNames2lower   --> lowercase_df_colnames
filename:  fdwTbl2PGnoSpatial.R --> fdw-to-tbl.R
fun name:  fdwTbl2PGnoSpatial   --> fdw_to_tbl
filename:  fdwTbl2PGSpatial.R --> fdw-to-geom-tbl.R
fun name:  fdwTbl2PGSpatial   --> fdw_to_geom_tbl
filename:  getDatePatternTableList.R --> get-pg-tbl-by-pattern.R
fun name:  getDatePatternTableList   --> get_pg_tbl_by_pattern
returns SQL with the created id (faib_fib) and geometry field
filename:  getFDWtblSpSQL.R --> get-sql-fdw-id-geom.R
fun name:  getFDWtblSpSQL   --> get_sql_fdw_id_geom
filename:  getGeomNamePG.R --> get-pg-geom-name.R
fun name:  getGeomNamePG   --> get_pg_geom_name
filename:  getGrskeyExtent.R --> get-gr-skey-extent.R
fun name:  getGrskeyExtent   --> get_gr_skey_extent
filename:  getTableQueryPG.R --> sql-to-df.R
fun name:  getTableQueryPG   --> sql_to_df
filename:  get_oracle_conn_string.R --> get-oracle-conn-string.R
fun name:  get_oracle_conn_string   -->
filename:  get_ora_conn_list.R --> get-ora-conn-list.R
fun name:  get_ora_conn_list   -->
filename:  get_pg_conn_list.R --> get-pg-conn-list.R
fun name:  get_pg_conn_list   -->
filename:  gr_skey_tif_2_pg_geom.R --> import-gr-skey-tif-to-pg-rast.R
fun name:  gr_skey_tif_2_pg_geom   --> import_gr_skey_tif_to_pg_rast
filename:  is_blank.R --> is-blank.R
fun name:  is_blank   -->
filename:  pgRas2rows.R --> pg-rast-to-tbl.R
fun name:  pgRas2rows   --> pg_rast_to_tbl
filename:  pg_rast_2_centroid.R --> pg-rast-to-centroid.R
fun name:  pg_rast_2_centroid   --> pg_rast_to_centroid
filename:  rasterizeSF.R --> rasterize-sf.R
fun name:  rasterizeSF   --> rasterize_sf
filename:  rasterizeTerra.R --> rasterize-terra.R
fun name:  rasterizeTerra   --> rasterize_terra.R
filename:  rasterizeWithGdal.R --> rasterize-gdal.R
fun name:  rasterizeWithGdal   --> rasterize_gdal.R
filename:  runSQL.R --> run-sql-psql.R
fun name:  runSQL   --> run_sql_psql
filename:  sendSQLstatement.R --> run-sql-r.R
fun name:  sendSQLstatement   --> run_sql_r
filename:  sqljoins_asstring.R --> str-sql-joins.R
fun name:  sqljoins_asstring   --> str_sql_joins
filename:  tif2grskeytbl.R --> tif-to-gr-skey-tbl.R
fun name:  tif2grskeytbl   --> tif_to_gr_skey_tbl
filename:  updateFKfldTablePG.R --> update-gr-skey-tbl-flds.R
fun name:  updateFKfldTablePG   --> update_gr_skey_tbl_flds
filename:  updateFKlookupPG.R --> add-pk-to-gr-skey-tbl.R
fun name:  updateFKlookupPG   --> add_pk_to_gr_skey_tbl
filename:  updateFKsrcTblpg.R --> update-pg-metadata-tbl.R
fun name:  updateFKsrcTblpg   --> update_pg_metadata_tbl
filename:  writeNoSpaTbl2PG.R --> ogr-to-tbl.R
fun name:  writeNoSpaTbl2PG   --> ogr_to_tbl

Thanks Hailey, I'm going to add these changes to alpha_version branch in the main bcgov repo and test from there.


Code signing certificate

http://tomtalks.uk/2012/03/how-to-get-a-personal-code-signing-certificate-from-a-public-ca-to-sign-powershell-scripts/

https://www.digicert.com/code-signing/digicert-certificate-utility-to-sign-code.htm


python312Packages.oracledb: 2.4.1 -> 2.5.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.oracledb is: Python driver for Oracle Database
meta.homepage for python312Packages.oracledb is: https://oracle.github.io/python-oracledb
meta.changelog for python312Packages.oracledb is: https://github.com/oracle/python-oracledb/blob/v2.5.0/doc/src/release_notes.rst
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.5.0 with grep in /nix/store/85skxdf31rha8sgb1vv6j4r6rd2ggjl2-python3.12-oracledb-2.5.0
found 2.5.0 in filename of file in /nix/store/85skxdf31rha8sgb1vv6j4r6rd2ggjl2-python3.12-oracledb-2.5.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.oracledb
python312Packages.oracledb

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/85skxdf31rha8sgb1vv6j4r6rd2ggjl2-python3.12-oracledb-2.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.oracledb https://github.com/r-ryantm/nixpkgs/archive/0a9a533112f63392f37949fe0bfbcb94acc380f1.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/0a9a533112f63392f37949fe0bfbcb94acc380f1#python312Packages.oracledb

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/85skxdf31rha8sgb1vv6j4r6rd2ggjl2-python3.12-oracledb-2.5.0
ls -la /nix/store/85skxdf31rha8sgb1vv6j4r6rd2ggjl2-python3.12-oracledb-2.5.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.oracledb
python311Packages.oracledb.dist
python312Packages.oracledb
python312Packages.oracledb.dist

Maintainer pings
cc @harvidsen for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.oracledb is: Python driver for Oracle Database
meta.homepage for python312Packages.oracledb is: https://oracle.github.io/python-oracledb
meta.changelog for python312Packages.oracledb is: https://github.com/oracle/python-oracledb/blob/v2.5.1/doc/src/release_notes.rst
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.5.1 with grep in /nix/store/0bpvvbbs2d7y6cxvbng1j63wc4i0agd1-python3.12-oracledb-2.5.1
found 2.5.1 in filename of file in /nix/store/0bpvvbbs2d7y6cxvbng1j63wc4i0agd1-python3.12-oracledb-2.5.1

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.oracledb
python312Packages.oracledb

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0bpvvbbs2d7y6cxvbng1j63wc4i0agd1-python3.12-oracledb-2.5.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.oracledb https://github.com/r-ryantm/nixpkgs/archive/ee560a51058b6a2ca9b7165122e6436b1e04ef96.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/ee560a51058b6a2ca9b7165122e6436b1e04ef96#python312Packages.oracledb

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0bpvvbbs2d7y6cxvbng1j63wc4i0agd1-python3.12-oracledb-2.5.1
ls -la /nix/store/0bpvvbbs2d7y6cxvbng1j63wc4i0agd1-python3.12-oracledb-2.5.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.oracledb
python311Packages.oracledb.dist
python312Packages.oracledb
python312Packages.oracledb.dist

Maintainer pings
cc @harvidsen for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Done in #368309.


git-aliases: Add version 0.3.5

[x] I have read the Contributing Guide.

Why not use nupkg?
https://psg-prod-eastus.azureedge.net/packages/git-aliases.0.3.5.nupkg

Why not use nupkg?
https://psg-prod-eastus.azureedge.net/packages/git-aliases.0.3.5.nupkg

Direct to source if possible. I also see posh-git doing it.

posh-git is created before added to PSGallery, so source is used. Use a more stable and accessible host is preferred.

A suggest for git should be added

posh-git is created before added to PSGallery, so source is used. Use a more stable and accessible host is preferred.

I don't think so, posh-git has been in PSGallery since the beginning.

Switched to using PSGallery.


Error: /usr/lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found

Hello,
I am trying to publish my application that uses nodegit to Openshift, but i am getting this error:
Error: /usr/lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /var/lib/openshift/*/app-root/runtime/repo/node_modules/nodegit/build/Release/nodegit.node)
    at Error (native)
    at Object.Module._extensions..node (module.js:597:18)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/var/lib/openshift/*/app-root/runtime/repo/node_modules/nodegit/dist/nodegit.js:11:12)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)

Your deployment environment used a different (probably lodem) runtime C++ library libstdc++. The easiest way to fix this is to build node-git on your target environment from source, capture and deploy the binding.node file as a binary. Please note it might be incompatible with the environment your are deploying from.

For others: I've been using this in my package.json to make it work for now, it's not ideal but it works for my production and dev environments.
...
"scripts": {
    "preinstall": "npm install nodegit --build-from-source"
}
...


[NCL-8775] Make ssh details visible for admin users

This PR is on hold due to missing backend support, see NCL-8756.

looks good, is it stil meant to be a draft?

looks good, is it stil meant to be a draft?

@patrikk0123 due to NCL-8756, this pr has to remain on hold because backend support for fetching the ssh details by pnc admin user is not implemented.

Will it start working automatically once backend support is ready? If yes and there is currently no other issue being present (?), then we can merge it?

Will it start working automatically once backend support is ready? If yes and there is currently no other issue being present (?), then we can merge it?

Yes, as long as the backend supports, this change would be valid. I will merge it now.

moved to https://github.com/project-ncl/pnc-web-ui-react/pull/555


show comments in yaml files

Is it possible to toggle comments in yaml files? It would be super useful for large commented yaml config files (e.g. helm chart value files)
Thanks!

Hey so this works with at least version 0.9.0

some file foo.yaml

---

key:
  - value
  - value
  - value

key2:
  - object:
      key: value
      key: value
  - object:
      key: value
      key: value
  - object:
      key: value
      key: value

and then doing
jless -m line foo.yaml

yields
{
  "key": [
    "value",
    "value",
    "value"
  ],
  "key2": [
    {
      "object": {
        "key": "value"
      }
    },
    {
      "object": {
        "key": "value"
      }
    },
    {
      "object": {
        "key": "value"
      }
    }
  ]
}


Game hangs forever during API auth flow

Continued from #2 since this is not quite related anymore and I don't want to fill that person's email 🙂
I've tested version <IP_ADDRESS> for 1.20.1 on both Fabric and Quilt without any other mods present and both hang up at the same point. Here's a full client log: https://files.lostluma.net/ouhpHg.txt

It's probably because https://sessionserver.mojang.com/session/minecraft/hasJoined returns an 204 instead of an 200.
Sadly i got no clue why this happends... Maybe an invalid serverid and username combo?

Okay i'm now kinda sure it's the fault of this:
    // Code from Web App
    const serverHash = crypto.createHash("sha1")
        .update(body.username)
        .digest();
    const serverId = BigInt.asIntN(
        160,
        serverHash.reduce((a, x) => a << 8n | BigInt(x), 0n)
    ).toString(16);

which gets sent to mojang here
// Code from Mod
Minecraft.getInstance().getMinecraftSessionService().joinServer(
    CloudSettings.getUser().getGameProfile(),
    CloudSettings.getUser().getAccessToken(),
    serverIdResponse.getServerId() //<--- value from above
);

and here
// Code from Web App
const mojangLoginResponse = await fetch(`https://sessionserver.mojang.com/session/minecraft/hasJoined?username=${encodeURI(body.username)}&serverId=${encodeURI(login.serverId)}`, {
        headers: {
            "Content-Type": "application/json",
            "Accept": "application/json",
        },
        method: "GET"
    });

I'm probably using it wrong. Do you maybe know what I did wrong?

I've changed a the way how serverIds get generated. Could u try it again please?

Works fine for me now, thanks 🙂


Design Report: Abstract and Description A+B

Closes #58, #60

Revisions:

[ ] Abstract should be less features, more approach/concept/scope and justification (novel, sustainable, innovative)
[ ] Reduce system description detail in A - remember, this is a design concept submission
[ ] Mention assumed life support etc. systems - A or B?

Use "Venturi Tube" before using Venturis
@narvcharv venturi as a noun is actually a common thing, they use it like that in both automotive and gardening stuff


quota limiter: support online config

Signed-off-by: glorv<EMAIL_ADDRESS>
What is changed and how it works?

Issue Number: Close #12257
What's Changed:

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression

Release note
None

LGTM, did you confirm these config items in a tidb cluster? Looks like it could also be merged into release-6.0?

I tested in a local test cluster, the config change can quickly affect the overall cpu usage.

/test

/test

/merge

/merge

/test

/hold seems the unit test is not very stable, I will try to enhance it.

/unhold

/merge

/test

/test

/test

/test


Ensure we truly don't overwrite an existing dh1024.pem

I have what is an unusual config where we have multiple VPN servers in various locations and would like to allow users to use the same signed certificate for each.  So, we store dh1024.pem (and other items) in encrypted data bags.  Unfortunately it was being overwritten on each run by server.rb.

@cjs226 could you please remove the metadata and changelog changes (next version will be v3, we have significantly changed the cookbook in master).
@jtimberman could you please review too, there is now use of unless wrapped around the resource as well as not_if on the resource.

I don't know why this would be necessary with the unless around the resource itself.

Closing for now.


/auth/confirm does not exist

hi, for the magic link it redirects to auth/confirm?token_hash=pkce_8f32441e43a8c465c022a629d7891269c6bf0bbe74a48f1156e130e4&type=email
but it looks like you removed the /auth/confirm route in commit 9232d739e016a668bb7d28d4f1b76760e09d38d1, visible here: https://github.com/astriaai/headshots-starter/tree/9232d739e016a668bb7d28d4f1b76760e09d38d1
is there sth I am missing or like how is it supposed to work from supabase?

Hi, for me this gets me a 404, do you know how to solve the issue?

@Fdelro yes, here you go: https://github.com/astriaai/headshots-starter/issues/112
I expect you did step 5, which is not needed (and auth/confrim does not exist so won't work). Change your magic link template in Supabase to the same one as signup and it'll work fine

Thanks a lot!


ui-material-tabs break on back navigation (ios)

Which platform(s) does your issue occur on?

iOS 15

Please, provide the following version numbers that your issue occurs with:

CLI:8.1.4
Cross-platform modules:  "@nativescript/core": "8.1.5",
Runtime(s): JSC and 8.1.0
Plugin(s): "@nativescript-community/ui-material-tabs": "~6.2.2", I tried down to 5.x versions, same problem with older packages as well. I suspect it to be related to IOS 15, IOS 11 on emulator does not show the problem

Please, tell us how to recreate the issue in as much detail as possible.
As can be seen in the attached video, when transitioning back to the view, the top tabbar is shifted by a certain amount into the page. Could have to do with OverflowSaveArea?
Forward/Backword navigation with vertical slide transition is responsible for the bug to show up, other page transitions do not lead to this error
https://user-images.githubusercontent.com/43253483/139599962-45c453cd-12a8-412f-b1c8-febfa60fa942.mov
<MDTabs animationEnabled="false" offscreenTabLimit="4" swipeEnabled="false" [selectedIndex]="_selectedIndex"
		(selectedIndexChanged)="onSelectedIndexChanged($event)" class="border-top">
		<MDTabStrip>
			<MDTabStripItem>

			</MDTabStripItem>

			<MDTabStripItem>

			</MDTabStripItem>

			<MDTabStripItem>

			</MDTabStripItem>

			<MDTabStripItem>

			</MDTabStripItem>
		</MDTabStrip>

		<MDTabContentItem>
			<ContentView>
				<ns-search-tab *ngIf="_showSearchTab"></ns-search-tab>
			</ContentView>
		</MDTabContentItem>

		<MDTabContentItem>
			<ContentView>
				<ns-custom-tab *ngIf="_showCustomTab"></ns-custom-tab>
			</ContentView>
		</MDTabContentItem>

		<MDTabContentItem>
			<ContentView>
				<ns-meals-tab *ngIf="_showMealsTab"></ns-meals-tab>
			</ContentView>
		</MDTabContentItem>

		<MDTabContentItem>
			<ContentView>
				<ns-quickly-add-tab *ngIf="_showQuicklyAddTab"></ns-quickly-add-tab>
			</ContentView>
		</MDTabContentItem>
	</MDTabs>

@cjohn001 would be good to try and replicate that issue with N core version (no plugin). It could help pinpoint where the issue comes from

@farfromrefug. I do not know how to work with N core, only Angular.

@cjohn001 you can use ns create to create a simple example on which you can try and replicate the issue. It is essential to be able to pinpoint the issue

Well I currently do not have the time to look into it. I need to see how to find a workaround the problem first.

@farfromrefug : I will close the issue as there seems to be black magic happening (behavior was 100% repeatable yesterday).
I have rebuild the app this morning and cannot see the reported behavior anymore. As all packages are in the same version like they were yesterday and I made no code changes, I do not understand whats happening. I think it makes no sense to debug something which is not repeatable, therefore I close the issue


Use collection if

I don't really care if this is used or not, but you asked me about it here.

Changed in 9daf7b152e90b121ed2aa9cb8c79e7841b08c414.
By the way the condition I used to insert the SizedBox in between is if (title != null && description != null) to handle the case where title is null but not description (the SizedBox shouldn't be added in this case).


Fix module errors

This fixes several several module errors that I encountered while building for dev. Including but not limited to:
ERROR  in ./pkg/new-feature/NewFeature.vue                                                      friendly-errors 13:55:17

Module Error (from ./node_modules/eslint-loader/dist/cjs.js):                                    friendly-errors 13:55:17

/home/phillip/Development/rancher-plugins-example/pkg/new-feature/NewFeature.vue
   3:9  warning  Missing space before value for key 'name'                  key-spacing
   3:9  warning  Property name "new-home-page" is not PascalCase            vue/component-definition-name-casing
  17:1  error    Too many blank lines at the end of file. Max of 0
  allowed  no-multiple-empty-lines

Signed-off-by: Phillip Rak<EMAIL_ADDRESS>

@rak-phillip is this PR still valid or can we close it?

Judging by the age, I'd close this as stale.


Framework change

Overview:

Remove mdpy.Simulation class
Replace mdpy.Ensemble class with mdpy.core.Ensemble class
Remove mdpy.dumper package

The main job to conduct a simulation with MDPy currently is to create an Ensemble object. The integration and energy minimization is accomplished by create Minimizer or Integrator object and using visiting paradigm to modify Ensemble instantce

Good


chore(main): release 0.1.1

:robot: I have created a release beep boop
0.1.1 (2024-02-02)
Features

Add default list (fa3ee03)
Add link to delete, tick and un tick todos (7b941e6)
Add simple creation form (49437fb)
Add simple database creation script (7bddeb2)
Add simple static class to access database (e13804e)
Add tailwind for simple styling (814079f)
Add twig templating (a07923c)
Change nav active ling based on active route (78e69da)
Display list of todos from DB (276e8f2)
Form to edit todos (d1e0ca7)
Install carbon and var dumper (95914b6)

Miscellaneous Chores

Fresh slim installation (52f06b9)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/jobtrek/php-slim-todo/releases/tag/v0.1.1 :sunflower:


fix: openssl is compiled twice, once not vendored in linux

It’s broken since the workspace-hack change (#12961).
Openssl-sys is compiled twice on Linux, because features are not unified.
The one for build-dependency doesn’t have openssl-sys feature. It’s depended by tls-native, which is depended by sql-x, which is build-dependency in workspace-hack. (Since we didn't configure hakari to unify target os-specific dependencies, hakari unified it only partialy, and this cause them unnecessarily compiled twice.)
Simply put, it’s now a build-dependency so

Feature is not unified. This can be fixed easily and is done in this PR.
It will be compiled twice in release mode. Unless #12362, but it’s broken. Not a large problem(? Well, I’m not sure But it has been so). Just slower…

This only happens on linux, but not mac, because native-tls works differently for different os.
Temporary workaround this by manually unify feature in workspace-config to unblock daily pipeline and stuff. Later, we might delete [build-dependencies] for docker/release. Or completely get rid of workspace-hack.
TLDR: After this change, on Linux openssl is compiled once in debug mode, and still twice in release mode. Both once on mac.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

docker build passed


We are working on a fix.


Merge in upstream Bitcoin Core improvements

@lbrynaut once you've thought about this some more, can you write some details about what the steps are

Rebase on 0.17 is done.


*: Remove RocksDB

PR: https://github.com/cockroachdb/cockroach/pull/55509
From release notes:

RocksDB can no longer be used as the storage engine. Passing in --storage-engine=rocksdb now returns an error. [#55509][#55509] {% comment %}doc{% endcomment %}

As @mattcrdb mentioned in a Slack thread, we also need to think about this in the context of rolling upgrades:

On this topic though, we should call out that during upgrade if customers are expecting some type of forward compatibility and were already specifying rocksdb as their storage engine on 20.2 that their rolling upgrade might run into some problems.
I guess that guidance would have to be in the Upgrade to 21.1 Document. FWIW Cockroach Cloud would probably have this same obstacle when upgrading the fleet. I wonder how they are solving it.

I think that, at the least, we would call this out when we ask customers to review breaking changes and deprecations, e.g., https://www.cockroachlabs.com/docs/v20.2/upgrade-cockroach-version.html#review-breaking-changes. We may also need a tip in the rolling update instructions themselves as well.


Welcome to Hacktoberfest 2024

What is Hacktoberfest?
Hacktoberfest is a month-long celebration of open source. Projects, such as freeCodeCamp, can opt-in to participate. When they have done so, contributors (just like you!) can make pull requests to the project that are eligible for the event.
Contributors who have made four eligible pull requests (PRs which receive an "approve" review or are merged into the default branch) can earn a digital badge through Holopin - this is customisable and evolves over time.

[!NOTE]
Contributors who have a PR merged for this issue may also reach out to Naomi on Discord to claim a special Hacktoberfest 2024 role.

How to Participate
We are in the process of overhauling our interactive curriculum. This change will include new lesson formats such as videos, lectures, interactive labs and workshops, and more.
Part of this initiative requires creating knowledge comprehension quizzes. We are asking contributors to participate in Hacktoberfest by making pull requests to create the content for these quizzes.
We need pull requests for each of the following quizzes.

Show List
### Tasks
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56174
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56175
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56176
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56177
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56178
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56179
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56180
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56181
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56182
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56183
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56184
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56185
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56186
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56187
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56188
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56189
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56190
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56191
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56192
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56193
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56194
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56195
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56196
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56197
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56198
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56199
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56200
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56201
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56202
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56203
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56204
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56205
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56206
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56207
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56208
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56209
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56210
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56211
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56212
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56213
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56214
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56215
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56216
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56217
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56218
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56219
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56220
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56221
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56222
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56223
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56224
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56225
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56226
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56227
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56228
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56229
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56230
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56231
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56232
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56233
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56234
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56235
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56236
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56237
- [ ] https://github.com/freeCodeCamp/freeCodeCamp/issues/56238

[!IMPORTANT]
To allow as many contributors to participate as possible, we kindly ask that:

Each pull request create exactly one (1) quiz
Each contributor create no more than one pull request for this issue

How to Write a Quiz
All quizzes can be found in the new front-end-development directory.
A quiz is contained in a single markdown file, such as the Design Fundamentals quiz.
These markdown files use a template:
---
id: id-goes-here
title: Semantic HTML Quiz
challengeType: 8
dashedName: semantic-html-quiz
---

# --description--

Answer all of the questions below correctly to pass the quiz.

# --quizzes--

## --quiz--

### --question--

#### --text--

Placeholder question

#### --distractors--

Placeholder distractor 1

---

Placeholder distractor 2

---

Placeholder distractor 3

#### --answer--

Placeholder answer

Quizzes are all multiple choice. The "distractors" are incorrect answers to the question. You may list the distractors in any order. The --answer-- should be the answer which is correct.
A quiz should have a total of 20 questions related to the topic. We will attempt to provide a list of sub-topics to choose from before the event starts.
Examples
Here is an example of what a completed quiz file should look like: https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/25-front-end-development/quiz-basic-html/66df3b712c41c499e9d31e5b.md
Here is an example of a pull request which follows our contributing guidelines might look like: https://github.com/freeCodeCamp/freeCodeCamp/pull/56417
Plagiarism and AI-generated Content
Do NOT copy questions directly from other sources, even if paraphrased. Questions you submit should be your own creations. This includes using generative AI to create questions - please do NOT use AI (ChatGPT, Claude, etc) to create questions.
Interested in Contributing?

[!TIP]
Before contributing, be sure to read our documentation thoroughly. If you have any questions, reach out to us in Discord and we will be more than happy to assist you.

If you are interested in contributing, please respond OH THE ISSUE YOU'D LIKE TO WORK ON. We will then add you to the issue so other contributors know you have claimed that quiz.

[!CAUTION]
If you have claimed a quiz, and we have seen no activity within 7 days, we will release the quiz so another contributor may claim it.

We look forward to seeing your contributions. Happy Coding! 💜

Thank you for your interest in contributing. This issue will be unlocked and opened for contribution when Hacktoberfest starts on October 1st.

[!CAUTION]
Pull requests which are created before October 1st will not be eligible for Hacktoberfest. We appreciate enthusiasm, but encourage you to hold off on contributing to this issue until the event has begun.

If you wish to be notified when this issue is opened for contribution, subscribe to notifications:

When you create a pull request
The template asks for an issue number that your PR closes. PLEASE do not use this top-level 56170 issue. INSTEAD, you should use the number for the specific quiz issue you are assigned.

This issue is now open
If you would like to work on this issue, please leave a comment so we can assign it to you.
Be sure to read our contributing guidelines.

Closing this issue since all of the corresponding issues have been closed. 👍


Support Bash pipe/redirect operators

There is a problem with bash pipe | or redirect > operators that perform ops between stdouts and stdins of forked process, needs further investigation on the issue.
Some operations fail some just halt the further execution of the process managed by mirrord
possibly related: #258

Just did some digging:
conceptually I believe, pipe operators call pipe() then dup on the pipe fd with the stdout of one end and otherway around on the receiving end of the pipe. However strace does not show any calls to dup, dup2, dup3, fcntl..
https://gist.github.com/infiniteregrets/1838c511792353116d071ee1bfd17c0a

This seems to work now.


Allowing intercepting of keyboard inputs (such as arrow keys and enter)

I'm working on a separate PR for this

I actually have a working copy of this on my personal branch. If you want I can merge it. I did just merge backspace detection into main. I use the same method to detect key presses there.

Added into the macOS branch


Async

This change is

r? @vinipsmaker
(maidsafe_highfive has picked a reviewer for you, use r? to override)

Review status: 0 of 10 files reviewed at latest revision, 3 unresolved discussions.

src/service.rs, line 86 [r2] (raw file):

/// A structure representing a connection manager.
pub struct Service {
    cm: Arc<Mutex<HashMap<PeerId, Context>>>, // This is the connection map -> PeerId <-> Context

better to name this as conn_map - cm might be too short :)
Or still better have pub type ConnectionMap = Arc<Mutex<HashMap<PeerId, Context>> defined then we can use cm throughout.

src/service.rs, line 101 [r2] (raw file):

        let mut event_loop = try!(EventLoop::new());
        let mio_tx = event_loop.channel();
        // let sender = event_loop.channel();

Let's delete them if not necessary

src/service.rs, line 221 [r2] (raw file):

impl Drop for Service {
    fn drop(&mut self) {
        // let _ = self.sender.send(Box::new(|el: &mut EventLoop<Core>, _: &mut Core| el.shutdown()));

delete ?

Comments from Reviewable

Reviewed 3 of 9 files at r1, 6 of 8 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Token pair icons and pricing

Listings need a bit more visual and pricing data.

Please take a look and review. As always comments and critics are appreciated.
https://zpl.io/a8r6lL6
Clicking on the icon next to the price listing will invert the price.


Vectorization builder optimization

For a project I'm working on I needed to remove the restriction of only newbuilders in loops for them to be vectorized. More importantly, I changed the code so that not every builder is always vectorized, but only when this actually makes sense (so when there is an appender or a merger in the loop). This highly reduces compilation times for some loads I had (from something like 1 second to 400ms for a somewhat complex query).

I did try a loop with a dictmerger and an appender in the REPL and that worked fine, but I did not run the actual code. Note that it does not change the vectorised code that is generated, it only means that vectorised code is generated in less cases.
However, to be sure, I will create some extra integration tests tomorrow (it's night in my timezone) to verify this.

I added a test with a dictmerger and an appender in a single loop (based on the simple_dictmerger test). All tests pass.

Hey @Frumbasjt,
This looks good, but is there a way you can gate this feature for now (e.g., look at conf.rs, and add an option there to explicitly turn this on: you can call it something like weld.compile.vectorizeAll or something like that). The reason is that vectorizing dictmerger actually causes a runtime performance regression: that builder doesn't support vectorization natively, so when you merge a SIMD value, it extracts each element and merges the element individually.  It can be useful in some cases, like if there are a bunch of appenders with a single dictmerger or something.

Sure, no problem. But I'm a bit confused now, because my pull request does the opposite of "vectorize all". It makes sure that code is vectorized in less cases. Without this PR dictmerger is always vectorized, but with it only when there is an appender or merger in there, so it should be an improvement of performance for dictmergers rather than a regression.
Anyway, just to make sure we're on the same page: turning this code on would mean setting weld.compile.vectorizeAll to false right?

Ah you’re right — I was misreading the PR/didn’t realize that’s what the
default behavior right now was! In that case, this is actually good to go
:) I’ll merge it in as is. Thanks for the contribution and apologies for
the confusion!!
On Fri, Mar 30, 2018 at 12:14 AM Frumbasjt<EMAIL_ADDRESS>wrote:

Sure, no problem. But I'm a bit confused now, because my pull request does
the opposite of "vectorize all". It makes sure that code is vectorized in
less cases. Without this PR dictmerger is always vectorized, but with
it only when there is an appender or merger in there, so it should be an
improvement of performance for dictmergers rather than a regression.
Anyway, just to make sure we're on the same page: turning this code on
would mean setting weld.compile.vectorizeAll to false right?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/weld-project/weld/pull/331#issuecomment-377463504,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABTCY4mj0BBOfU33YYsEpDgK-1o1aOK9ks5tjdtEgaJpZM4S8sAf
.

--
Shoumik


WebSocketNamespace constructor error

[REQUIRED] Environment

Browser version:
Alchemy SDK version: v2.2.3

[REQUIRED] Describe the problem
WebSocketNamespace constructor failed to save config
How to reproduce:
create an instance of Alchemy and then try to listen to some alchemy event
Relevant code or sample repro:

@adacai1982 Can you provide a more detailed repro? Which part of the config is the SDK failing to save? You should not be trying to instantiate the WebsocketNamespace directly.

Closing due to the lack of activity.


Support more themes

Suggested new feature or improvement
Support more themes.
Scenario
More theme colors.
Additional details
No response

We're planning to stick to Windows theming for now. If we plan to support more themes, we can re-open this issue :)


SD Card init issue when CONFIG_SPEED_OPTIMIZATIONS=y

Describe the bug
When I'm turning on CONFIG_SPEED_OPTIMIZATIONS=y I'm getting  sd:Card never left busy state error.
To Reproduce
Steps to reproduce the behavior:
prj.conf
CONFIG_STDOUT_CONSOLE=y

CONFIG_CPLUSPLUS=y
CONFIG_STD_CPP20=y
CONFIG_NEWLIB_LIBC=y
CONFIG_LIB_CPLUSPLUS=y

CONFIG_MAIN_STACK_SIZE=90000

CONFIG_DEBUG=y
CONFIG_PRINTK=y
CONFIG_LOG=y
CONFIG_USB_DRIVER_LOG_LEVEL_ERR=y
CONFIG_USB_DEVICE_LOG_LEVEL_ERR=y

CONFIG_DISK_ACCESS=y
CONFIG_FILE_SYSTEM=y
CONFIG_FAT_FILESYSTEM_ELM=y
CONFIG_DISK_DRIVER_SDMMC=y
CONFIG_SPI=y

CONFIG_LOG_MODE_IMMEDIATE=y
CONFIG_PWM_LOG_LEVEL_DBG=y

CONFIG_FS_LITTLEFS_BLK_DEV=y
CONFIG_APP_LITTLEFS_STORAGE_BLK_SDMMC=y
CONFIG_FILE_SYSTEM_LITTLEFS=y

CONFIG_TIMING_FUNCTIONS=y

CONFIG_SPEED_OPTIMIZATIONS=y
CONFIG_FS_FATFS_NUM_FILES=10

            if (disk_access_init(disk_pdrv) != 0) {
                LOG_ERR("Storage init ERROR!");
                break;
            }

west flash

I don't have this problem when i setup comment out CONFIG_SPEED_OPTIMIZATIONS=y from my config file.
Expected behavior
I'm able to read from SD card files with CONFIG_SPEED_OPTIMIZATIONS=y
Impact
I can't use CONFIG_SPEED_OPTIMIZATIONS=y
Logs and console output

Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr SDK
Commit SHA or Version used: 3.1.99

Additional context
Add any other context that could be relevant to your issue, such as pin setting,
target configuration, ...

static int sdmmc_send_ocr(struct sd_card *card, int ocr_arg)
{
	struct sdhc_command cmd;
	int ret;
	int retries;

	cmd.opcode = SD_APP_SEND_OP_COND;
	cmd.arg = ocr_arg;
	cmd.response_type = (SD_RSP_TYPE_R3 | SD_SPI_RSP_TYPE_R1);
	cmd.timeout_ms = CONFIG_SD_CMD_TIMEOUT;
	/* Send initialization ACMD41 */
	for (retries = 0; retries < CONFIG_SD_OCR_RETRY_COUNT; retries++) {
		**LOG_INF("retries=%d", retries);**
		ret = sdmmc_app_command(card, 0U);
		if (ret == SD_RETRY) {
			/* Retry */
			continue;
		} else if (ret) {
			return ret;
		}
		ret = sdhc_request(card->sdhc, &cmd, NULL);
		if (ret) {
			/* OCR failed */
			return ret;
		}
		if (ocr_arg == 0) {
			/* Just probing, don't wait for card to exit busy state */
			return 0;
		}
		/*
		 * Check to see if card is busy with power up. PWR_BUSY
		 * flag will be cleared when card finishes power up sequence
		 */
		if (card->host_props.is_spi) {
			if (!(cmd.response[0] & SD_SPI_R1IDLE_STATE)) {
				break;
			}
		} else {
			if ((cmd.response[0U] & SD_OCR_PWR_BUSY_FLAG)) {
				break;
			}
		}
		sd_delay(10);
	}
	if (retries >= CONFIG_SD_OCR_RETRY_COUNT) {
		/* OCR timed out */
		LOG_ERR("Card never left busy state");
		return -ETIMEDOUT;
	}
	LOG_DBG("SDMMC responded to ACMD41 after %d attempts", retries);
	if (!card->host_props.is_spi) {
		/* Save OCR */
		card->ocr = cmd.response[0U];
	}
	return 0;
}

After add of this LOG_INF line problem stop to occur.

@asarbs what board are you building for?

I'm using mimxrt1020_evk

I have do some more investigation and  i have information that if i set CONFIG_SPEED_OPTIMIZATIONS=y, mount point flags suggest that this is READ ONLY File system.

@asarbs  Interesting that this fixes the issue- based on your initial description I expected the issue was that CMD55 (app command) was being sent to the card too soon after CMD8. If you replace the LOG_INF statement with k_busy_wait(100) is the issue also resolved?

@danieldegrasse sorry last comment was my mistake, if we are talking about initial issue I still don't have solution.

@asarbs, sorry, missed this notification and was on PTO this past week. Will changing the LOG_INF statement out for k_busy_wait work to fix the issue?

@danieldegrasse yes.


debug mode support

I'm using this module with debug mode and I'm not getting this issue. Can you make a small example repo where you reproduce the issue?


Trade: Countdown

Source: https://www.spigotmc.org/threads/trade-system-custom-layouts.327308/page-3
Iskandarluqman: "Just a quick suggestion, if you disable in config the money, then in the editor you shouldnt be force :D But that is a way for improvement. I actually looking forward if you can make it have animations? For example in my layout. When both agree then the glass panes in the middle (5 black stained) in this picture will change to yellow one by one until its done countdown. This will give like extra time if they want to change their mind. Maybe in the editor add an option in Functions perhaps called Countdown {Optional}. With optional which mean they can still continue to amigious althought its not been set. Then in the Countdown section, add a 1 second, 2 second , 3 second, 4 second and 5 second. When you press the 1 second, it will just show like the GUI editor, you can select which one you wanna make it the first thing to be change when a countdown begin. Im bad at explaining this, bacisly can you add a countdown which will have an awesome animations? xD"

Any updates?
Looking forward to this

I want this too.
Please. You can make it.


update Document.doi to uri

https://github.com/ga4gh/va-spec/blob/28dc31166815a0ad5f0e16795a9578ba1c3ed05c/schema/annotation-source.yaml#L129
☝ update Document.doi to uri to support any external reference system

revising this to an array of xrefs to support multiple public identifiers. @korikuzma please note this change.


Installation failed and dependencies have no versions

no versions
https://github.com/lucianolorenti/ceruleo/blob/4e952966dbc3389e0e1f1cd7635c81eeccfbec12/setup.cfg#L12
current installation error
Command
pip install ceruleo

Error
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
tensorflow 2.12.0 requires numpy<1.24,>=1.22, but you have numpy 1.21.6 which is incompatible.

Hi! I uploaded a new version to pypi with an improved setup and pinned libraries. Let me know if works now

@lucianolorenti Yes it works now


@storybook-extras/variants with transclusion

I have a component that displays a simple message card with variable severity (colour / icon) via a type input and an optional close button via a closeBtn input.
The text content of the message is passed via transclusion, so usage looks like this
<message [type]="'info'" [closeBtn]="true">This is my text content!!</message>

I want the text content to be descriptive of the variant, i tried like this
export const VariantsStory: StoryObj<MessageComponent> = {
  render: (args) => ({
    template: '<aw-message #control [type]="type" [closeBtn]="closeBtn">Label Text {{ control.type }} / {{ type }}</aw-message>',
    props: args
  }),
  parameters: {
      variants: {
          enable: true,
          autoCalculate: true,
          groupBy: ['closeBtn'],
          include: ['type', 'closeBtn'],
      },
  },
};

But the result is that each variant successfully renders but the values in the text content are all "info" which is the first severity
value.
Is there any existing built in mechanism to achieve what i'm looking for?

I think i have found a solution in a modification to variants.model.ts. Currently it identifies a single instance of the key to replace with its variant value in the template, specifically it looks for the key wrapped in double quotes assuming it being passed to an input e.g.  [input]="keyToReplace"
this is the current code
story.template = story.template.replace(`"${key}"`, `"${replacedValue}"`);

Would you be open to an update that would support replacing the value for one or more inputs, and also for anywhere its printed in the template?
const inputAndPrintValueSearch = new RegExp(`("${key}"|{{\\s*${key}\\s*}})`, 'g');
story.template = story.template.replace(inputAndPrintValueSearch, `"${replacedValue}"`);

This would let me use variants to render a story for a component that relies on other components as wrappers / content that also need to get the variant params, and it lets me add some label text that includes the params
<button-decorator [type]="type">
    <button-component [type]="type">This is a "{{ type }}" button</button-component>
<button-decorator>


Add color temperature to light card

Add the color temperature button to the light cards

Fixed in #93


Remove myself from maintainers

Motivation for this change
I'm not using NixOS/Nixpkgs anymore. This makes me sad, but I was spending way too much time fixing Nixpkgs, packaging and working around problems. Don't get me wrong, I love Nix and NixOS. Please keep going. I hope better times will come and let me come back.
I hope this will remove me from hydra report logs.

:-(
You may need to do the same for 16.09.

I picked it directly.  There are still a few references of your name on both branches.

I'll miss you, thank you for all your hard work over the past few years.

Do you have any suggestions on people you've noticed taking care of these packages / the gnome ecosystem that I could ping in the future?

That's too bad. To avoid spam, perhaps you'd want to add an entry to the mentionbot blacklist as well?

Do you have any suggestions on people you've noticed taking care of these packages / the gnome ecosystem that I could ping in the future?

sorry, I don't
I will continue to read news from the community. Keep the good work going!

Yes, I think that was the problem; Damien was lately doing most of all the gnome-specific work.

Damien was lately doing most of all the gnome-specific work

not most of it, but still a bit too much compared to the time I have. And I changed job in September which took me some time also.

I'm back by the way :-).

So you want to get listed on some meta.maintainers again?  I think especially for packages without any maintainers it would be nice...

Vladimír Čunát<EMAIL_ADDRESS>writes:

So you want to get listed on some meta.maintainers again?  I think
especially for packages without any maintainers it would be nice...

do you have any specific one in mind? Otherwise, I will add myself when
I find packages that need someone and that I'm willing to help.
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

I meant nothing specific.  There's generally low meta.maintainers coverage, and this (old) diff also showed you were the only one in most cases.

I'm back by the way :-).

why? :-) Don't get me wrong, I'm excited, but what triggered your return?

why? :-) Don't get me wrong, I'm excited, but what triggered your return?

I never wanted to leave. I joined a new company and had a hard time installing everything I needed in NixOS. I was spending a lot of time improving NixOS instead of learning my new job. Nowadays, I'm more one of the experts than one of the juniors in the company, we have much less things to install, and NixOS got much better!
I might have to go back to Fedora again because it seems NixOS is sucking all my battery power and is making my CPU really hot really fast on my new laptop. In Fedora I will see if I can replicate the problem. I hope to get back to NixOS really soon.

@DamienCassou oh noes! Do you have services.tlp.enable set? You may also check this https://github.com/NixOS/nixos-hardware/pull/101/files#diff-a48130f1addab5c8712fc73f37aa7f2fR52-R79, as it has some hacks to reduce power drain.
There is also another hack for Intel CPUs, which reduces frequency hardway, which reduces battery usage - https://github.com/NixOS/nixos-hardware/pull/101/files#diff-b3acb2a24fc098d15130f0261a43ed78R38-R50

@danbst I do have tlp running. I'm trying your suggestions. It would be great if I could stick with NixOS. Currently, I'm migrating everything I can to home-manager to keep a Nix feeling if I have to go back to Fedora. Is it ok for me to contact you if I have questions about this problem? This thread is not appropriate though. Can I use discourse instead?

yes :+1:


Is XFA layer and Text layer mutually exclusive?

Hi,
I am trying to render xfa support to our product using pdf.js. I have a few clarifications.
Currently I am using the below code to render xfa :
               `if(page.isPureXfa)`
                    {
                     page.getXfa().then(function(xfaHtml){
                    var pdfJSGlobal = @com.daeja.viewone.ajax.client.renderer.PDFNativeBridge::pdfJSGlobal;
                    var xfaDiv = document.createElement("div");
                    var parameters = {
                    viewport: viewport.clone({ dontFlip: true }),
                       div: xfaDiv,
                       xfaHtml:xfaHtml,
                       annotationStorage: pdfJSGlobal.annotationStorage,
                       linkService: pdfJSGlobal.linkService,
                       intent:"display",
                       };
                    pdfJSGlobal.XfaLayer.render(parameters);
                    imageCallback.onCompleted(xfaDiv, imgSrc, cappedScale,null);
             });
        }
       else  //Render text layer

If I try to render xfaDiv also along with textDiv, I get errors.  So I am assuming, xfa layer is different from a text layer.
I want to know if xfa layer and text layer are mutually exclusive ? Should we use isPureXfa to render XFA Forms separately and handle text forms in the else block ?
Thanks
Sushma Raghupathi

I want to know if xfa layer and text layer are mutually exclusive?

Yes, XFA documents don't use a separate textLayer since they are different (in lots of ways) from "normal" PDF documents

Should we use isPureXfa to render XFA Forms separately and handle text forms in the else block?

There's not really a question of should, you need to handle XFA documents separately.

When opening an issue, please provide all of the information requested in https://github.com/mozilla/pdf.js/blob/master/.github/ISSUE_TEMPLATE.md rather than ignoring the template.
Also, note that code snippets are not really useful; please see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.


Quoted field - yaml driver

Allow the usage of quoted field mapping option in yaml mappings
Example:
MyModel:
    type: entity
    fields:
        values:
            type: string
            quoted: true

Closing as invalid due to the incorrect rebase: only bigfoot/doctrine2@6c394ac should be part of this branch (based on master)


Use path to reference files

Ex for common/config.js the reference to ../features.json assumes a linux/mac. For windows users this will cause an issue. Use path to qualify file.

Thanks for the heads up. I ran everything on Win10 and hadn't had a problem, but will check out path .