[release-v1.15] Add Konflux configurations

Add Konflux components and pipelines

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release-v1.15@382b5e2). Learn more about missing BASE report.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff                @@
##             release-v1.15     #937   +/-   ##
================================================
  Coverage                 ?   66.59%
================================================
  Files                    ?      129
  Lines                    ?    11961
  Branches                 ?        0
================================================
  Hits                     ?     7965
  Misses                   ?     3027
  Partials                 ?      969

Flag
Coverage Δ

e2e-test
37.62% <ø> (?)

e2e-test-runtime-go
26.66% <ø> (?)

e2e-test-runtime-node
26.05% <ø> (?)

e2e-test-runtime-python
26.05% <ø> (?)

e2e-test-runtime-quarkus
26.14% <ø> (?)

e2e-test-runtime-rust
25.16% <ø> (?)

e2e-test-runtime-springboot
25.22% <ø> (?)

e2e-test-runtime-typescript
26.13% <ø> (?)

integration-tests
53.09% <ø> (?)

unit-tests
51.29% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add new no-inline-anonymous-functions-to-schedule-once rule

Is there a way I check that scheduleOnce and once or run are being imported from @ember/runloop? I'm worried about false positives if a user-defined function with the name once has an anonymous function passed to it.

PR accepted upstream


How to set edge label font size globally?

Hi, I'm currently trying to adjust the edge label font size globally across all diagrams. In LaTeX, using the tikzcd package, the edge label text is smaller by default, as the following image shows:

I'm looking for a way to achieve a similar appearance with typst-fletcher. Could you provide guidance on how to globally set the edge label font size?
Additionally, I would like to know if there are any plans to make smaller edge labels the default appearance in future versions, considering its common use in math books. Thank you for your help!

This is currently a gap in fletcher. I think it's worth adding a label-size option to diagram() (and edge() for completeness) which inserts a set rule before the label, since this is probably common.
At the moment, the thing one might do is to define a wrapper that applies the desired style:
#let ls(it) = text(0.8em, it) // [l]abel [s]ize

#diagram(
  $
  f edge("d", ->) edge(->, ls(f)) & f \
  f edge("ur", ->)
  $,
)

#diagram(
  node((0,0), [A]),
  edge(ls[hello]),
  node((1,1), [B])
)

Of course, this isn't as elegant as it could be, since it requires you to define a function and call it on every label yourself.

Added in

@Jollywatt Thanks for your awesome work on the recent commit 6e7b5f3. It's a lifesaver!
Could we consider bumping the version number for the Typst official package? This would allow users to start taking advantage of the new features right away.

Yeah, one thing I don't have the hang of is best practices for versioning and release cycles:P
This feature has been bundled with a whole lot of other changes for version v0.5.0, which is slightly breaking. That will happen this week. Hopefully it won't be too painful to update!


fix #85 ad uoh and ami logos

Adds University of Hawaii to associate members and AMI to silver.

@tgorochowik thoughts on why the preview link is 404-ing?

Yay preview is working now!


js_inject: String interpolation bug

PLEASE READ THE POSTING GUIDELINES AND ANSWER THE QUESTION BEFORE POSTING, OTHERWISE ISSUE WILL BE CLOSED AND MARKED AS INVALID

I hereby declare the following issue is a [tool specific question/bug report] and it is NOT a help request about creating a phishlet.
I am fully aware that this is not a customer support portal, I can't demand answers and I'm aware I am using a free tool.
I am not going to use Evilginx to hax my girlfriend's account or use it for any other illegal purpose.
I am not trying to set up a domain on FreeNOM (also read the sentence above again).
I am not a robot.

Please type in "I CONFIRM" below if you confirm the sentences above or otherwise make some funny remark:
I CONFIRM
Thanks!
It seems there is an issue with parsing the JS inject parameter in the yaml file. Specifically, if one uses string backtick syntax which is standard ES6 and common practice for any JavaScript programmer, the code will not be executed as expected- I spent a few hours banging my head against the wall trying to understand what was going on until I realized internally evilginx2 is performing some kind of sanitization on the JavaScript code that gets injected. TLDR Don't use string interpolation for ES6- use stone age techniques.

Thanks!
I think you may need to check with YAML documentation on how to properly escape backticks. It should be doable.


Still can't download, shows error

Version
V 1.10.11
Platform
Windows 10
Steps to reproduce
Still can't download, show Error. "V1.10.11"

Details

Checklist

[X] I have looked through existing issues to make sure that this bug has not been reported before
[X] I have provided a descriptive title for this issue
[X] I have made sure that this bug is reproducible on the latest version of the application
[X] I have provided all the information needed to reproduce this bug as efficiently as possible
[ ] I have sponsored this project

I might have a similar error:

I use Win 11 (actual patch installed) and the YoutubeDownloader v1.10.11
Am I right and this is also a symptom of the same problem or should I open another thread?

some issue


[DO NOT MERGE] GOV.UK faceted navigation prototype

This prototype allows you to generate lists of GOV.UK content to support navigational journeys on GOV.UK.
See https://gov-uk.atlassian.net/wiki/spaces/GFED/pages/814710952/GOV.UK+faceted+navigation+prototype?atlOrigin=eyJpIjoiZDNlM2U1YmI0M2E2NDZlOWFmYWI0ZmM5NjFiMDYyNWYiLCJwIjoiYyJ9

Closing, as this Pull Request looks to be inactive.


[Feature request] Search

A search function for when you have a long list of workflows.

this feature is added in the latest version


flutter doctor error

I am trying to run flutter doctor but what I get is "Running 'flutter pub get' in flutter_tools..." forever.
Useful information:
I already tried a lot of possibles solutions on internet, like checking variable path,  internet connection,  and installing other versions of Flutter.
I'm using a  dell windows 10 pc.
Flutter was working  before but i formatted my pc intalled git and the sdk  and suddenly stopped working because of this.
Thanks in advance

.

@Dera-codes
Since you formatted your pc, it would have wiped off some priveleges that were there previously. Try to run your command prompt as admin or try to run your flutter console as admin and check if that helps. Or you can re try to download stable version again, a fresh copy and see if it helps.
Note: please don't post screenshots.


Intro to collaborating on GH / OSS contributions

Last year @nnja gave a great intro to collaborating to GH. Would you be up for doing this again?

yes, I'd love to give the same intro again

Thanks a lot Nina! Will go ahead and close this


Use HashWithIndifferentAccess for metadata

json_api_client consistently returns strings, but json_api_resource wanted to use symbols in some cases and now we have them mixed together sometimes.  This means application-side bugs creeped in because we expected string but got symbol and vice-versa.  This will solve that in a simple way, and then consumers of json_api_client can use whatever their preference is - symbol or string.

can you add a test for this use case?

Added a test for accessing meta values with either strings or symbols.


Migrate to golang-jwt v4

For:
https://github.ibm.com/symposium/track-and-plan/issues/23486
https://github.com/dgrijalva/jwt-go/issues/478

see #316 for latest


Bug: Allow users to ask a question even when the table does not exist.

Currently, upon user registration, thier LanceDB table does not exist. This causes an issue if they try to ask a question with an empty knowledge-base. Fix: use Cognito post confirmation trigger to create an empty table or manage the exception and provide a user friendly message.

error specimen
2024-06-16T12:00:41.012Z	62d1406d-056c-416d-9443-60107eb9f94e	ERROR	Invoke Error
{
    "errorType": "Error",
    "errorMessage": "LanceDBError: Table 'us-west-2:14b3a170-REDACTED-5acdc' was not found",
    "stack": [
        "Error: LanceDBError: Table 'REDACTED' was not found"
    ]
}

This is coming from inference Lambda

addressed in #19

addressed with #19


Track simplification : tolerance ?

Hello,
Is it possible to add the tolerance value (in meters) to the simplify tool ?
Actually, there is only possibility to set the number of resulting points, but, like it is a Douglas-Peucker algorithm, I think it could be interesting to have also possibility to specify the tolerance, which is the main parameter for this algorithm.
Best regards,

Even if it is in meters, showing this parameter might be misleading for users that don't know how the algorithm works (= almost all of them).

I'm not very convinced...
I know how the algorithm works, and knowing the number of resulting points is fuzzy data for me, which does not reflect the real reduction performed on the trace. Wanting to reduce the number of points to a certain value without measuring the real consequences on the route seems to me to be an approach devoid of common sense. But hey... it's your choice.
I was just asking for an addition, not a replacement.


1-aedison: bug fix for switching less than three characters

Hi, my first bug fix for a public repo here. Let me know if you need me to do anything more.

I believe this fix might be better around here
https://github.com/knausj85/knausj_talon/blob/a31c7f162dd17c51a789fb7cfea43ad7621567b8/code/switcher.py#L182
to prevent the short words from entering the dictionary in the first place?

Agreed. I'll put the change there.

you may need to restart talent after changing this file if you're not on the current beta; that's probably why the commands are being recognized

Even after restarting, the "focus" command is not working, and "running list" shows an empty list. And even after I switch back to my feature branch without this change, the same behavior occurs. Scratching my head...

does that include apps that are launched after talon?

Just by performing that test, the problem disappeared. I think it's necessary to exit Talon Beta before switching branches.

The fix in the place indicated does not seem to filter the "i" application...

Working now.

Should I squash this branch for you?


diy: add meson support

Also print the path to put files into if no build system was determined.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew tests with your changes locally?

Thanks so much for your first contribution!  You rock, @z3ntu!


Update feedback generator to listen to SystemTestResponse topic

Update the feedback generator node to listen to SystemTextResponse messages and forward those to the ARUI as notifications (AruiUserNotification).

@derkmed, FYI I made a live system config here that I tested this with. Is #299 still needed?

@derkmed, FYI I made a live system config here that I tested this with. Is #299 still needed?

Nope


when is it planned to get @ngx-config/fs-loader: 6.0.0 on npmjs.org?

When is it planned to get the @ngx-config/fs-loader: 6.0.0 on https://www.npmjs.com/package/@ngx-config/fs-loader ?
thank

+1

+1

+1

We need this ASAP.
If you need some help just let me know.

+++

+1


Add FreeBSD-aarch64 build

No special logic seems to be needed in OSInfo. uname -m is arm64, uname -p is aarch64.
mvn test passes (Tests run: 298, Failures: 0, Errors: 0, Skipped: 2)
The build was done using openjdk 11. The binary is for FreeBSD >= 12 (64-bit inode ABI):
% readelf -r src/main/resources/org/sqlite/native/FreeBSD/aarch64/libsqlitejdbc.so | rg FBSD_1.5
00000012a910<PHONE_NUMBER>01 R_AARCH64_ABS64<PHONE_NUMBER>000000<EMAIL_ADDRESS>+ 0
00000012a928<PHONE_NUMBER>01 R_AARCH64_ABS64<PHONE_NUMBER>000000<EMAIL_ADDRESS>+ 0
00000012ab38<PHONE_NUMBER>01 R_AARCH64_ABS64<PHONE_NUMBER>000000<EMAIL_ADDRESS>+ 0

Any chance you could compile the native lib against the latest version? I'm using it in my fork and that would allow me to upgrade 🙂

@xerial we can close this following the merge of #642


Single page category search

This PR adds the dynamic category page that uses React and Relay to fetch and filter products.
Fixes #674

Current coverage is 61.01% (diff: 8.71%)

Merging #686 into demo-store will decrease coverage by 2.50%

@@           demo-store       #686   diff @@
============================================
  Files              93         96     +3
  Lines            4361       4558   +197
  Methods             0          0
  Messages            0          0
  Branches          471        496    +25
============================================
+ Hits             2770       2781    +11
- Misses           1496       1682   +186
  Partials           95         95

Powered by Codecov. Last update b2efa83...4f42a3b

@benekex2 There are two things we have to improve in sidebar filters:

now it is possible to collapse the whole checkbox group, but we should hide only unchecked filters
the whole filter header should be clickable, not only the arrow on the right

@elwoodxblues Could you rebase or merge with demo-store once again?

As we discussed, we'll firstly merge demo-store branch into master and then this branch to master. This will avoid potential merge conflicts

@benekex2 I've updated this branch to the latest master. There is some problem with bootstrap grid in product list, also something is broken in price range filter. Could you fix it?


fix(github): fix codeball permissions

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.436%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
190

Relevant Lines:
195

💛  - Coveralls


Outdated webcord-deb: 4.6.1 -> 4.8.0

Hello,
webcord-deb is in version 4.6.1 while a version 4.8.0 has been released.
Regards

My friend is now the owner of the flatpak version package.
I update now pacstall.
I take it as mine.


Tackle some low-hanging fruit in "test_grammar.py"

The latest copy of the CPython grammar tests in test_grammar.py has several @skips and FIXMEs. Some of them seem easy to fix, e.g. some parser bugs or missing warnings that would be helpful, others are entire features. We should fix the easy ones and make sure there are tickets for the rest.

Attempting to fix use_old_parser(). Trying to use PDB in order to examine the Cython.Compiler.Main.CompilationResult object at 0x7fc06fc49990> created in the compile() method; however, unable to access breakpoints in test_grammar.py when running runtests.py. Any suggestions for debugging?
Thanks!

If you run runtests.py with --no-capture the debugger should work.

For some reason the breakpoints are still not being stopped at.
Snippet of the commands being run:

@zdutta Thinking about it more,  I think that test_grammar.py is compiled in Cython rather than run as a regular Python module. I wouldn't expect the debugger to work on it.
I think there are some methods to debug Cython code but I've never really tried using them myself (and I especially don't know how to do them with the test-suite). Sorry!

Sorry, the "FIXME" in use_old_parser() is actually a FIXME from CPython (hopefully the only one), not from Cython. The test file is copied from the CPython test suite. Nothing to fix here.
Note that you need to debug Cython itself here, not the test that it compiles.
For debugging, I suggest copying the failing code out of the module and running it through Cython manually, rather than always compiling the huge file completely and trying to end up in the right spot to debug it.

Very good and thank


[gtest] Build error

Host Environment

OS:  Windows11
Compiler: vs2022

To Reproduce
Steps to reproduce the behavior:
./vcpkg install gtest
Failure logs
Computing installation plan...
The following packages will be built and installed:
    gtest[core]:x86-windows -> 1.12.1
Detecting compiler hash for triplet x86-windows...
Restored 0 package(s) from C:\Users\竺沛\AppData\Local\vcpkg\archives in 133.7 us. Use --debug to see more details.
Installing 1/1 gtest:x86-windows...
Building gtest[core]:x86-windows...
-- Using cached google-googletest-release-1.12.1.tar.gz.
-- Cleaning sources at C:/Users/竺沛/source/repos/vcpkg/buildtrees/gtest/src/ase-1.12.1-edf1a9f963.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Users/竺沛/source/repos/vcpkg/downloads/google-googletest-release-1.12.1.tar.gz
-- Applying patch clang-tidy-no-lint.patch
-- Applying patch fix-main-lib-path.patch
-- Using source at C:/Users/竺沛/source/repos/vcpkg/buildtrees/gtest/src/ase-1.12.1-edf1a9f963.clean
-- Found external ninja('1.11.0').
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Installing: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/src/gtest.cc
-- Installing: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/src/gtest_main.cc
-- Installing: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/src/gtest-all.cc
-- Installing: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/src/gtest-assertion-result.cc
-- Installing: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/src/gtest-death-test.cc
-- Installing: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/src/gtest-filepath.cc
-- Installing: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/src/gtest-internal-inl.h
-- Installing: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/src/gtest-matchers.cc
-- Installing: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/src/gtest-port.cc
-- Installing: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/src/gtest-printers.cc
-- Installing: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/src/gtest-test-part.cc
-- Installing: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/src/gtest-typed-test.cc
-- Fixing pkgconfig file: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/lib/pkgconfig/gmock.pc
-- Fixing pkgconfig file: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/lib/pkgconfig/gmock_main.pc
-- Fixing pkgconfig file: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/lib/pkgconfig/gtest.pc
-- Fixing pkgconfig file: C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/lib/pkgconfig/gtest_main.pc
-- Using cached msys-mingw-w64-i686-pkg-config-0.29.2-3-any.pkg.tar.zst.
-- Using cached msys-mingw-w64-i686-libwinpthread-git-<IP_ADDRESS>73.5be8fcd83-1-any.pkg.tar.zst.
-- Using msys root at C:/Users/竺沛/source/repos/vcpkg/downloads/tools/msys2/9a1ec3f33446b195
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:31 (message):

  C:/Users/竺沛/source/repos/vcpkg/downloads/tools/msys2/9a1ec3f33446b195/mingw32/bin/pkg-config.exe
  --exists gmock failed with error code: 1

      ENV{PKG_CONFIG_PATH}: "C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/lib/pkgconfig;C:/Users/竺沛/source/repos/vcpkg/packages/gtest_x86-windows/share/pkgconfig;C:/Users/竺沛/source/repos/vcpkg/installed/x86-windows/lib/pkgconfig;C:/Users/竺沛/source/repos/vcpkg/installed/x86-windows/share/pkgconfig"
      output: Package gmock was not found in the pkg-config search path.

  Perhaps you should add the directory containing `gmock.pc'

  to the PKG_CONFIG_PATH environment variable

  No package 'gmock' found
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:154 (z_vcpkg_fixup_pkgconfig_check_files)
  ports/gtest/portfile.cmake:48 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:147 (include)

error: building gtest:x86-windows failed with: BUILD_FAILED
error: Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
    https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+gtest
You can submit a new issue at:
    https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[gtest]+Build+error
Include '[gtest] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
    vcpkg-tool version: 2022-10-17-3247920fbdd47d08f36cbd480addd9890d3c2435
    vcpkg-scripts version: a4013afe6 2022-11-03 (8 hours ago)

Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.

The build worked .
So thanks for your help!

Since this issue has been resolved, I am closing this issue for now.


[data2vec] different config between released model[cfg] and default config

Hi, I am trying to reproduce data2vec on speech.
I found that the config of the released model you provided is inconsistent with what is stated in the documentation. And some fields are not declared in the code, such as "diversity_weight". So can you please provide a new config or update the code?
And I found that you set ema_layers_only: false in the released model, which means you do ema for the whole transformer including position encoding. Is this setting a better one than the paper claims (share the position encoding)?
Many Thanks!
@alexeib

Hi,
I can't find the "diversity_weight" that you are talking about anywhere in the fairseq codebase.
Also, may I ask where you find this parameterization of ema_layers_only: false? Both in Data2VecAudioConfig and in [base_librispeech.yaml](https://github.com/pytorch/fairseq/blob/edb25c6b08c0631184b50f0c9cc7c5cb7ff01ef4/examples/data2vec/config/audio/pretraining/base_librispeech.yaml#L80) it is set to true (and it is not overriden by the CLI in the [readme](https://github.com/pytorch/fairseq/tree/main/examples/data2vec) either).

hi, the model that has been released was trained in a separate branch with a bunch of experimental settings that have not been released. we updated the model config so it can be loaded by the released code. please use the official yaml config files to repro the results - you should get very close to what the released model obtains.

Got it. Thanks!


Add API referance based on the docstrings

This make it easier to keep the docs up to date well we are changing things.

I would also like to switch the README to an rts file rather then a markdown file.


Update README.md

@floriankrb can we merge? This is just the README and the test failure is unrelated (need to add ipywidgets apparently)


Clicking wrench (fix) icon for validation issue fails

 Issue by landonreed
Wednesday May 09, 2018 at 13:25 GMT
Originally opened as https://github.com/catalogueglobal/datatools-ui/issues/130

If feed has not been loaded into the editor and for certain entity types, the wrench icon does not work.  We should disable the wrench button if there is no active feed in the editor and fix the behavior for other entity types.

 Comment by landonreed
Wednesday May 09, 2018 at 14:21 GMT

Duplicate of #89


New features: output to file with logfile rotation

It will be really useful to have a dnstap-receiver with output to file and logfile rotation settings, like as rotate if file more than N megabytes.

will be release in next release


[CLI] Authentication failure when trying to create stack from custom catalog template

Rancher Version:
v1.2.1
Docker Version:
v1.10.3
OS and where are the hosts located? (cloud, bare metal, etc):
AWS EC2
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node rancher + RDS DB
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
rancher --url <URL> --access-key <ACCESS_KEY> --secret-key <SECRET_KEY> catalog install --name <STACK_NAME> <TEMPLATE_NAME>
Where
URL=/v2-beta/projects/<PROJECT_ID>
ACCESS_KEY/SECRET_KEY=account API keys from an Admin user
Results:
FATA[0004] Bad response 401 looking up <DOMAIN_NAME>/v1-catalog/templates/<TEMPLATE_ID>
Looking at local proxy details it only shows Unauthorized but no further details.
Expected:
The stack being created
Since the originating URL is different from the actual URL being called (i.e. /v2-beta/projects/PROJECT_ID vs /v1-catalog/templates/<TEMPLATE_ID>), maybe there's an issue with passing the auth credentials?

Extra info from the request:
GET /v1-catalog/templates/ecom:cluster:0 HTTP/1.1
Host: <HOSTNAME>
User-Agent: Go-http-client/1.1
Accept-Encoding: gzip

Final piece of information I could dig up was: https://github.com/rancher/cli/blob/master/cmd/catalog.go#L321

We don't allow installing based on names. Only IDs.
I've created a PR to update the help for rancher catalog install

@deniseschannon well it does work except for the authentication part that is. In any case, I made a PR for that, how does it further?

same 401 response is coming when trying to install from rancher-cli (Version: v0.4.1)
rancher catalog install private/app:0.0.1 --name stack_name -a answers.txt
FATA[0000] Bad response 401 looking up https://rancher.wizeapps.io/v1-catalog/templates/private:app:0


Parse elevation precision from verbatim label of CE

Codecov Report

Merging #2448 (1ec789f) into development (c4f5c79) will decrease coverage by 19.62%.
The diff coverage is 100.00%.

:exclamation: Current head 1ec789f differs from pull request most recent head a1b5fd9. Consider uploading reports for the commit a1b5fd9 to get more accurate results

@@               Coverage Diff                @@
##           development    #2448       +/-   ##
================================================
- Coverage        87.63%   68.00%   -19.63%
================================================
  Files             1809     1378      -431
  Lines            62611    41963    -20648
================================================
- Hits             54870    28538    -26332
- Misses            7741    13425     +5684

Impacted Files
Coverage Δ

spec/lib/utilities/elevation_spec.rb
100.00% <ø> (ø)

lib/utilities/elevation.rb
94.11% <100.00%> (+4.46%)
:arrow_up:

spec/support/concerns/random_token_methods.rb
2.63% <0.00%> (-97.37%)
:arrow_down:

spec/support/concerns/feature/authorization.rb
9.25% <0.00%> (-90.75%)
:arrow_down:

spec/support/concerns/request/api.rb
11.11% <0.00%> (-88.89%)
:arrow_down:

spec/support/concerns/feature/index_list_show.rb
12.50% <0.00%> (-87.50%)
:arrow_down:

app/models/identifier/global/issn.rb
14.28% <0.00%> (-85.72%)
:arrow_down:

app/models/identifier/global/isbn.rb
8.33% <0.00%> (-85.42%)
:arrow_down:

app/controllers/concerns/token_authentication.rb
22.58% <0.00%> (-77.42%)
:arrow_down:

app/models/identifier/global/lccn.rb
11.53% <0.00%> (-76.93%)
:arrow_down:

... and 980 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4f5c79...a1b5fd9. Read the comment docs.


antibody: 3.5.1 -> 3.6.1

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build antibody

Success on x86_64-darwin (full log)
Attempted: antibody
Partial log (click to expand)
find: '/nix/store/4v3dbvs83q72bad445cf83ygw82wpvvy-antibody-3.6.1': No such file or directory
find: '/nix/store/4v3dbvs83q72bad445cf83ygw82wpvvy-antibody-3.6.1': No such file or directory
find: '/nix/store/4v3dbvs83q72bad445cf83ygw82wpvvy-antibody-3.6.1': No such file or directory
find: '/nix/store/4v3dbvs83q72bad445cf83ygw82wpvvy-antibody-3.6.1': No such file or directory
find: '/nix/store/4v3dbvs83q72bad445cf83ygw82wpvvy-antibody-3.6.1': No such file or directory
find: '/nix/store/4v3dbvs83q72bad445cf83ygw82wpvvy-antibody-3.6.1': No such file or directory
find: '/nix/store/4v3dbvs83q72bad445cf83ygw82wpvvy-antibody-3.6.1': No such file or directory
find: '/nix/store/4v3dbvs83q72bad445cf83ygw82wpvvy-antibody-3.6.1': No such file or directory
find: '/nix/store/4v3dbvs83q72bad445cf83ygw82wpvvy-antibody-3.6.1': No such file or directory
/nix/store/wv0crykz1wbghmavyw1nzmj2mxfjxa5g-antibody-3.6.1-bin

Success on aarch64-linux (full log)
Attempted: antibody
Partial log (click to expand)
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5ma1ra0lr8c0pdwqzb8kwli3l9xh6fjw-antibody-3.6.1-bin
shrinking /nix/store/5ma1ra0lr8c0pdwqzb8kwli3l9xh6fjw-antibody-3.6.1-bin/bin/antibody
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5ma1ra0lr8c0pdwqzb8kwli3l9xh6fjw-antibody-3.6.1-bin/bin
patching script interpreter paths in /nix/store/5ma1ra0lr8c0pdwqzb8kwli3l9xh6fjw-antibody-3.6.1-bin
checking for references to /build in /nix/store/5ma1ra0lr8c0pdwqzb8kwli3l9xh6fjw-antibody-3.6.1-bin...
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
/nix/store/5ma1ra0lr8c0pdwqzb8kwli3l9xh6fjw-antibody-3.6.1-bin

Just to make sure: are there no updates to deps.nix ?

Nope, I ran dep2nix and it produced identical files.


Show hidden args/opts/flags with --help-hidden

This includes arguments, options, and flags that have .hidden visibility when a user requests the extended version of help with --help-hidden. Previously, only hidden option groups were included.
Checklist

[x] I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test macOS platform

@swift-ci Please test

@swift-ci Please test


Update setup

Is it better to allow root? I have to add "--allow-root" every time I setup Chalk on my VPS!

Why would you install bower assets with root?

@migueldemoura
I do not know  your running environment, I ran it  on Linux Debian 8.
First, I try to run  bin/setup  command without sudo or root, here comes the log, says
npm ERR! Please try running this command again as root/Administrator.
wuy@debian7:~/chalk-master$ bin/setup
The Gemfile's dependencies are satisfied
Fetching gem metadata from https://rubygems.org/..............
......
......
Your user account isn't allowed to install to the system RubyGems.
  You can cancel this installation and run:

      bundle install --path vendor/bundle

  to install the gems into ./vendor/bundle/, or you can enter your password
  and install the bundled gems to RubyGems using sudo.
  Password:
Bundle updated!
npm ERR! Error: EACCES, mkdir '/usr/local/lib/node_modules'
npm ERR!  { [Error: EACCES, mkdir '/usr/local/lib/node_modules']
npm ERR!   errno: 3,
npm ERR!   code: 'EACCES',
npm ERR!   path: '/usr/local/lib/node_modules',
npm ERR!   fstream_type: 'Directory',
npm ERR!   fstream_path: '/usr/local/lib/node_modules/bower',
npm ERR!   fstream_class: 'DirWriter',
npm ERR!   fstream_stack:
npm ERR!    [ '/usr/lib/nodejs/fstream/lib/writer.js:171:23',
npm ERR!      '/usr/lib/nodejs/mkdirp/index.js:46:53',
npm ERR!      'Object.oncomplete (fs.js:107:15)' ] }
npm ERR!
npm ERR! Please try running this command again as root/Administrator.

npm ERR! System Linux 3.16.0-4-amd64
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "i" "-g" "bower"
npm ERR! cwd /home/wuy/chalk-master
npm ERR! node -v v0.10.29
......
.....
npm ERR! not ok code 0

Second, After I ran it with sudo or root, Here comes the log, says
bower ESUDO         Cannot be run with sudo and  run a command with sudo using --allow-root option
wuy@debian7:~/chalk-master$ sudo bin/setup
The Gemfile's dependencies are satisfied
.....
.....
Using jemoji 0.8.0
Bundle updated!
/usr/local/bin/bower -> /usr/local/lib/node_modules/bower/bin/bower
<EMAIL_ADDRESS>/usr/local/lib/node_modules/bower
bower ESUDO         Cannot be run with sudo

Additional error details:
Since bower is a user command, there is no need to execute it with superuser permissions.
If you're having permission errors when using bower without sudo, please spend a few minutes learning more about how your system should work and make any necessary repairs.

http://www.joyent.com/blog/installing-node-and-npm
https://gist.github.com/isaacs/579814

You can however run a command with sudo using --allow-root option

After I add --allow-root option in the bin/setup Everything is OK! :-)
Here all my steps before I run Chalk successfully:
$ sudo apt-get install ruby-full build-essential npm git

$ sudo ln -s /usr/bin/nodejs /usr/bin/node

$  sudo gem install jekyll bundle

~/chalk-master$ sudo  bundle install
add --allow-root to bin/setup
~/chalk-master$ sudo bin/setup

Hope it helps improvement!

@95uxin Mostly this means you have everything setup with sudo on your dev machine which is not a good practise. I won't add this to the script because of that. Feel free to add it in your script of course.

@95uxin, check out RVM, using it fixes this issue (and is a much better practice).

@migueldemoura Thanks! I will try!


Add ability to grant permissions to all tables

Can you update your branch and push?

@dholopik can you also run make docs :)

@dholopik I had to revert this from master due to test failures (that I couldn't quickly fix).
Have a look and let's try again.


Changes to get mamba_train_example running.

Note that I also have to comment out "fast_ssm": True, on my machine.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have not rewritten tests relating to key interfaces which would affect backward compatibility

You have tested formatting, typing and unit tests (acceptance tests not currently in use)

[ ] I have run make check-ci to check format and linting. (you can run make format to format code if needed.)

Fixes #311

Looks like there's a test failure (should be a quick fix). This is also fixed in https://github.com/jbloomAus/SAELens/pull/226

Thanks @chanind -- I just rebased and changed the base to your branch.


[QUESTION] Any API to include data on deployment

public class Customer
{
    public ObjectId CustomerId { get; set; }
    public CustomerType type  { get; set; }
    public string Name { get; set; }
    public DateTime CreateDate { get; set; }
    public List<Phone> Phones { get; set; }
    public bool IsActive { get; set; }
}

public class CustomerType
{
    public ObjectId Id { get; set; }
    public string Type{ get; set; }

}

I wanted to include default data for Customer type while deploying the WPF app. Any API for that?
Id Type
1 Loyal
2 Normal

@meteorsnows Sorry, I didn't understand your question. Could you explain what you're trying to do?

I am trying to include default data for CustomerType Table
Id Type
1 Loyal
2 Normal

@meteorsnows There is no specific collection initialization functionality. You would have to do it manually, something like this:
var types = db.GetCollection<CustomerType>();
if(types.Count() == 0)
{
	types.Insert(new CustomerType { Type = "Loyal" });
	types.Insert(new CustomerType { Type = "Normal" });
}

Okie, fair enough.
Good enough for me.


Adapt allow-to-dns networkpolicy to also work with node local dns in cilium case

How to categorize this PR?

/area networking
/kind enhancement
What this PR does / why we need it:
Adapt allow-to-dns networkpolicy to also work with node local dns in cilium case.
Furthermore an unneeded ip block was removed from the networkpolicy.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

Adapt `allow-to-dns` networkpolicy to also work with node local dns in cilium case.

/approve
/cc @ScheererJ

/test pull-gardener-e2e-kind


Update add event command to throw the correct exception

Codecov Report

Merging #247 into master will decrease coverage by 0.06%.
The diff coverage is 40.00%.

@@             Coverage Diff              @@
##             master     #247      +/-   ##
============================================
- Coverage     61.37%   61.31%   -0.07%
  Complexity      923      923
============================================
  Files           140      140
  Lines          3350     3355       +5
  Branches        396      397       +1
============================================
+ Hits           2056     2057       +1
- Misses         1117     1120       +3
- Partials        177      178       +1

Impacted Files
Coverage Δ
Complexity Δ

...address/logic/commands/events/AddEventCommand.java
52.77% <40.00%> (-2.45%)
10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e28518...b3001e9. Read the comment docs.


when scanning QR-Code to add vaccination receiving error VC_PREFIX_INVALID

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[x] Bug is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[x] Bug is not already reported in another issue

Technical details

Device name: iPhone
iOS version: 14.6
App version: 2.3.2

Describe the bug
When scanning QR-Code to add vaccination to CWA by scanning vaccination confirmation QR-Code receiving:
Fehler
Dieser QR-Code ist kein gültiges Impfzertifikat. (VC_PREFIX_INVALID).

Steps to reproduce the issue
Followed in-app steps to add vaccination and scan QR-Code.
Expected behaviour
Expected for vaccination to be added to app.
Additional context
Standard vaccination in vaccination center. Identical QR-Code on all documentation. BioNTech was used.

Internal Tracking ID: EXPOSUREAPP-7703

This is not a valid EU certificate you can receive this next week in pharmacy. Can you please share the structure of your code and from which center you receive this.

Will have to followup later as my contact running into this is sleeping at this very moment. What do you mean by "structure of your code"? What exact info do you want me to provide?

You can scan the qr code with a qr code scanner app and post the structure in an anonymized way.

I have scanned the one from my wife, I replaced the name with XXX and the name of the doctor with YYYYYYYY and the birthdate with 000.
This is the barcode she got at the Impfzentrum München after her second shot.
v6c780418797{"state":3,"v3":"000000000000000","v4":true,"v5":true,"v6":true,"v7":true,"v8":true,"v9":false,"va":true,"vb":false,"vg":2,"vk":"YYYYYYY YYYYYY","vl":"","vo":false,"vp":"XXXXXXXXXX XXXXXXX.XXXXXXX.0000-00-00.81735","vc":"8.6.2021","vd":"002","ve":"FA5833","vf":20210702,"vh":false,"vi":"1","vj":"30"}

Same problem here, iOS 14.6 and “Impfbescheinigung gemäß Paragraf 22 Impfschutzgesetz” from Kreisimpfzentrum produces VC_PREFIX_INVALID

These are not valid EU digital vaccination certificates they were not yet handed out you have to go to a pharmacy next week and they'll give you the right QR-Code.
See https://www.aponet.de/artikel/corona-digitaler-impfnachweis-ab-14-juni-in-apotheken-24262

@Ein-Tim thanks for elaborating. It is what Thomas also said. Maybe an improved error message will help to convey this to users as the current error message is not very helpful.

@foss-
Since the error message under Android is the same, I suggest to open an issue in the wishlist repository.
Besides of improving the error message there's nothing we can do here, so I suggest to close this.

Hi!
I'm here with a group at TU Darmstadt. We got our first Astras last week because the university got us all into Prio 3.
But we have only our first shot. The Impfzentrum gave us QR codes on a piece of paper.
Can we scan this? And then the second code from the second dose? Or are we supposed to wait for another document?
Many of us are not EU citizens so we don't have a "yellow passport," just this xeroxed QR code. The German citizens all have a yellow passport with a numbered sticker AND a QR code.
Please give us a FAQ on what the workflow for the user is supposed to be & which of the several QR codes we all now have are supposed to scanned.
Thanks for all your great work!
Your favorite confused American,
MelancholyAeon

I am having the same issue.
Impfort: Impfzentrum Kitzingen
Adresse: Marshall-Heights-Ring 15, 97318 Kitzingen

A detailed FAQ entry will follow soon. But this QR Code is not valid EU certificate. If you get your second vaccination next week the vaccination center should print out a EU vaccination certificate:
Example:

Ty!
This more than the hotline knew. Both Spiegel & Tagesshau stories are vague
on what we're supposed to do.
Have a great day.
 But this QR Code is not valid EU
certificate. If you get your second vaccination next week the vaccination
center should print out a EU vaccination certificate:
Example:
[image: pdfExample]
https://user-images.githubusercontent.com/6367738/121354638-59aba880-c92f-11eb-98bb-9dcbc42d6742.jpg
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/corona-warn-app/cwa-app-ios/issues/2871#issuecomment-857654042,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APY2ILVYYAGJLKET7ARSTW3TR5NLBANCNFSM46KZ2HNA
.

Hey all, we will se an improvement reg. the error message: #2886

@foss- @melancholyaeon see:

EN https://www.coronawarn.app/en/faq/#vac_cert_invalid
DE https://www.coronawarn.app/de/faq/#vac_cert_invalid

@All: The FAQ entries exist and will be updated continuously - next update today. We are trying to stay ahead with the dynamics of the events, valid information is given only infrequently, sorry.
So, I recommend to check the above-mentioned FAQ daily until you find the expected guidance.
First news: Beginning next week, a network of pharmacies will be capable to issue digital vaccination statements that can be scanned by the CWA to convert them into the digital European vaccination certificate.

Would it be reasonable to change the text which is written in the app respectively make in more precise? At the moment the app it is clearly says, that I should scan the QR code I received after getting vaccined ("Um ein Impfzertifikat in die App hinzuzufügen, scannen Sie den QR-Code, den Sie bei der Impfung erhalten haben.").
But as @thomasaugsten already mentioned, the QR codes aren't yet handed out when receiving the vaccination, the pharmacies will start with this on monday.
For me it was quite clear what would happen when I scanned the QR code which I got from the Impfzentrum in Munich, because I followed the media. But there might also be other persons which don't know what to do, even if there is now an entry in the FAQ.

@GisoSchroederSAP
TY! Very grateful.
Once again you all here give more precise info than the hotline staff can
or the not-so-helpful Tagesschau stories that simply say "on Monday some
pharmacies can issue EU QR codes," but give no useful details on the
process.
Thanks for all your work.
On Thu, Jun 10, 2021 at 09:56 GisoSchroederSAP @.***>
wrote:

@ALL https://github.com/ALL: The FAQ entries exist and will be updated
continuously - next update today. We are trying to stay ahead with the
dynamics of the events, valid information is given only infrequently, sorry.
So, I recommend to check the above-mentioned FAQ daily until you find the
expected guidance.
First news: Beginning next week, a network of pharmacies will be capable
to issue digital vaccination statements that can be scanned by the CWA to
convert them into the digital European vaccination certificate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/corona-warn-app/cwa-app-ios/issues/2871#issuecomment-858400862,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APY2ILRGXW4U4C7ZEBUMSPTTSBV23ANCNFSM46KZ2HNA
.

@mbw83
Yes, it is reasonable! We will see a hot fix for this: https://github.com/corona-warn-app/cwa-app-ios/pull/2886

@Ein-Tim Thanks, right. As @Ein-Tim mentioned message has improved and also FAQ had been updated some time ago:

EN https://www.coronawarn.app/en/faq/#vac_cert_invalid
DE https://www.coronawarn.app/de/faq/#vac_cert_invalid

Dear @foss-, @melancholyaeon , @mbw83   @bleft, @MichaelDzsida @bockchristian  and all others in the community: Thanks for contributing here. Closing this issue now. Best wishes, DS

Corona-Warn-App Open Source Team


Adds Build Integration Test

Adds some full-build integration tests

The current failure appears to be an issue with rattler-build, which I've communicated over the build tools chat.

This is really stale. I'm going to formalize a plan for this work and track it with Issue #228


Week 7 Review Ticket

Period 4 Mortensen
CB Error Testing Video and Quiz Notes
Python Identifying and Correcting Errors + Challenge
API
Submenu
Program Design
Fixing Merge Conflicts Picture
CS Terms

Program design on phone background, looked at Marvel pages.  Looked at 6 CB items.  Very good initial thinking.  1/1
Kaylee - quizzes and notes.   Blogging notes.  Really nice formatting looks like extra work.    Marvel api.  Need to work on formatting, not attempt.   2.6
Trey - No attempt at parsing the API.  AP college board, did some significant captures of key concepts.  Discussed participation in project.   Worked on similar structure.  2.6


ProcessExitedException caused by SIGKILL

When I excute python -u train.py --config config/refcoco/cris_r50.yaml, there is an exception occured:
2023-11-29 06:51:23.492 | ERROR    | main::224 - An error has been caught in function '', process 'MainProcess' (524921), thread 'MainThread'<PHONE_NUMBER>7824):
Traceback (most recent call last):

File "train.py", line 224, in
main()
└ <function main at 0x147b5e2a7280>

File "train.py", line 62, in main
  mp.spawn(main_worker, nprocs=args.ngpus_per_node, args=(args, ))
  │  │     │                   │                          └ CfgNode({'dataset': 'refcoco', 'train_lmdb': 'datasets/lmdb/refcoco/train.lmdb', 'train_split': 'train', 'val_lmdb': 'dataset...
  │  │     │                   └ CfgNode({'dataset': 'refcoco', 'train_lmdb': 'datasets/lmdb/refcoco/train.lmdb', 'train_split': 'train', 'val_lmdb': 'dataset...
  │  │     └ <function main_worker at 0x147b5e2a7550>
  │  └ <function spawn at 0x147b64ccd670>
  └ <module 'torch.multiprocessing' from '/ext3/miniconda3/lib/python3.8/site-packages/torch/multiprocessing/__init__.py'>

File "/ext3/miniconda3/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 230, in spawn
  return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
         │               │   │     │       │     └ False
         │               │   │     │       └ True
         │               │   │     └ 1
         │               │   └ (CfgNode({'dataset': 'refcoco', 'train_lmdb': 'datasets/lmdb/refcoco/train.lmdb', 'train_split': 'train', 'val_lmdb': 'datase...
         │               └ <function main_worker at 0x147b5e2a7550>
         └ <function start_processes at 0x147b64ccd3a0>
File "/ext3/miniconda3/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 188, in start_processes
  while not context.join():
            │       └ <function ProcessContext.join at 0x147b64ccd550>
            └ <torch.multiprocessing.spawn.ProcessContext object at 0x147b5e235340>
File "/ext3/miniconda3/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 130, in join
  raise ProcessExitedException(
        └ <class 'torch.multiprocessing.spawn.ProcessExitedException'>

torch.multiprocessing.spawn.ProcessExitedException: process 0 terminated with signal SIGKILL

I doubt this error occurs because of the version conflict and I have tried python 3.8.15 with pytorch1.9+cuda10.2 and pytorch1.8_cuda10.2. But this error still exist. Have anyone met this before or can the authors release their specific package version used in this  repo? @DerrickWang005  @aniki-ly

Hi，have you met this problem when run evaluation code.
Evaluation code run error: ValueError: operands could not be broadcast together with shapes (480,640) (640,427)


[TS migration] Migrate 'Profile' page to TypeScript

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/25199
PROPOSAL:
Tests

Go to a report (Chat)
click on the avatar of any user
Verify that the Profile Screen appears to the right and all options are normal

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to a report (Chat)
click on the avatar of any user
Verify that the Profile Screen appears to the right and all options are normal

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android-native-converted.webm

Android: mWeb Chrome
android-web-converted.webm

iOS: Native
https://github.com/Expensify/App/assets/23215729/c7ca7435-0894-49cc-abfd-077698750589

iOS: mWeb Safari
https://github.com/Expensify/App/assets/23215729/e4184a13-da58-4e8b-8160-694296b7fbd3

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/23215729/badec577-5afb-455a-8ea6-b6e8b711fbf7

MacOS: Desktop
https://github.com/Expensify/App/assets/23215729/038b2bcf-a95b-4de8-944b-d8f6b7276848

On hold till this PR is merged

@pasyukevich Bump on this one

@pasyukevich One more comment here and also resolve conflict

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@pasyukevich  There are some errors (lint, TS check), please help to resolve it

Problem was solved with this PR
I will merge the  main and check

@pasyukevich Please merge main

Problem was solved with this https://github.com/Expensify/react-native-onyx/pull/482

PR is merged and it bumps Onyx version, so TS should be fixed once we merge main here.

Looks like it's still failing...@fabioh8010 do you think we might have not fixed it fully or we missed a case? error in this PR is:
Error: src/pages/ProfilePage.tsx(257,5): error TS2322: Type '{ key: "report_"; selector: (report: OnyxEntry<{ chatType?: ValueOf<{ readonly POLICY_ANNOUNCE: "policyAnnounce"; readonly POLICY_ADMINS: "policyAdmins"; readonly DOMAIN_ALL: "domainAll"; readonly POLICY_ROOM: "policyRoom"; readonly POLICY_EXPENSE_CHAT: "policyExpenseChat"; readonly SELF_DM: "selfDM"; }> | undefined...' is not assignable to type 'OnyxPropMapping<ProfilePageProps, ProfilePageOnyxProps, "reports"> | OnyxPropCollectionMapping<ProfilePageProps, ProfilePageOnyxProps, "reports">'.
  Types of property 'selector' are incompatible.
    Type '(report: OnyxEntry<Report>) => OnyxEntry<Report>' is not assignable to type 'Selector<`report_${string}`, ProfilePageOnyxProps, OnyxCollection<{ chatType?: ValueOf<{ readonly POLICY_ANNOUNCE: "policyAnnounce"; readonly POLICY_ADMINS: "policyAdmins"; readonly DOMAIN_ALL: "domainAll"; readonly POLICY_ROOM: "policyRoom"; readonly POLICY_EXPENSE_CHAT: "policyExpenseChat"; readonly SELF_DM: "self...'.
      Type '(report: OnyxEntry<Report>) => OnyxEntry<Report>' is not assignable to type 'Selector<`report_${string}`, ProfilePageOnyxProps, OnyxCollection<{ chatType?: ValueOf<{ readonly POLICY_ANNOUNCE: "policyAnnounce"; readonly POLICY_ADMINS: "policyAdmins"; readonly DOMAIN_ALL: "domainAll"; readonly POLICY_ROOM: "policyRoom"; readonly POLICY_EXPENSE_CHAT: "policyExpenseChat"; readonly SELF_DM: "self...'.
        Type 'OnyxEntry<{ chatType?: ValueOf<{ readonly POLICY_ANNOUNCE: "policyAnnounce"; readonly POLICY_ADMINS: "policyAdmins"; readonly DOMAIN_ALL: "domainAll"; readonly POLICY_ROOM: "policyRoom"; readonly POLICY_EXPENSE_CHAT: "policyExpenseChat"; readonly SELF_DM: "selfDM"; }> | undefined; ... 66 more ...; reportFields?: Rec...' is not assignable to type 'OnyxCollection<{ chatType?: ValueOf<{ readonly POLICY_ANNOUNCE: "policyAnnounce"; readonly POLICY_ADMINS: "policyAdmins"; readonly DOMAIN_ALL: "domainAll"; readonly POLICY_ROOM: "policyRoom"; readonly POLICY_EXPENSE_CHAT: "policyExpenseChat"; readonly SELF_DM: "selfDM"; }> | undefined; ... 66 more ...; reportFields?...'.
          Type '{ chatType?: ValueOf<{ readonly POLICY_ANNOUNCE: "policyAnnounce"; readonly POLICY_ADMINS: "policyAdmins"; readonly DOMAIN_ALL: "domainAll"; readonly POLICY_ROOM: "policyRoom"; readonly POLICY_EXPENSE_CHAT: "policyExpenseChat"; readonly SELF_DM: "selfDM"; }> | undefined; ... 66 more ...; reportFields?: Record<...> |...' is not assignable to type 'OnyxCollection<{ chatType?: ValueOf<{ readonly POLICY_ANNOUNCE: "policyAnnounce"; readonly POLICY_ADMINS: "policyAdmins"; readonly DOMAIN_ALL: "domainAll"; readonly POLICY_ROOM: "policyRoom"; readonly POLICY_EXPENSE_CHAT: "policyExpenseChat"; readonly SELF_DM: "selfDM"; }> | undefined; ... 66 more ...; reportFields?...'.
            Type '{ chatType?: ValueOf<{ readonly POLICY_ANNOUNCE: "policyAnnounce"; readonly POLICY_ADMINS: "policyAdmins"; readonly DOMAIN_ALL: "domainAll"; readonly POLICY_ROOM: "policyRoom"; readonly POLICY_EXPENSE_CHAT: "policyExpenseChat"; readonly SELF_DM: "selfDM"; }> | undefined; ... 66 more ...; reportFields?: Record<...> |...' is not assignable to type 'Record<string, ({ chatType?: ValueOf<{ readonly POLICY_ANNOUNCE: "policyAnnounce"; readonly POLICY_ADMINS: "policyAdmins"; readonly DOMAIN_ALL: "domainAll"; readonly POLICY_ROOM: "policyRoom"; readonly POLICY_EXPENSE_CHAT: "policyExpenseChat"; readonly SELF_DM: "selfDM"; }> | undefined; ... 66 more ...; reportFields...'.
              Property 'chatType' is incompatible with index signature.
                Type 'ValueOf<{ readonly POLICY_ANNOUNCE: "policyAnnounce"; readonly POLICY_ADMINS: "policyAdmins"; readonly DOMAIN_ALL: "domainAll"; readonly POLICY_ROOM: "policyRoom"; readonly POLICY_EXPENSE_CHAT: "policyExpenseChat"; readonly SELF_DM: "selfDM"; }>' is not assignable to type '({ chatType?: ValueOf<{ readonly POLICY_ANNOUNCE: "policyAnnounce"; readonly POLICY_ADMINS: "policyAdmins"; readonly DOMAIN_ALL: "domainAll"; readonly POLICY_ROOM: "policyRoom"; readonly POLICY_EXPENSE_CHAT: "policyExpenseChat"; readonly SELF_DM: "selfDM"; }> | undefined; ... 66 more ...; reportFields?: Record<...> ...'.
                  Type 'string' is not assignable to type '{ chatType?: ValueOf<{ readonly POLICY_ANNOUNCE: "policyAnnounce"; readonly POLICY_ADMINS: "policyAdmins"; readonly DOMAIN_ALL: "domainAll"; readonly POLICY_ROOM: "policyRoom"; readonly POLICY_EXPENSE_CHAT: "policyExpenseChat"; readonly SELF_DM: "selfDM"; }> | undefined; ... 66 more ...; reportFields?: Record<...> |...'.
                    Type 'string' is not assignable to type '{ chatType?: ValueOf<{ readonly POLICY_ANNOUNCE: "policyAnnounce"; readonly POLICY_ADMINS: "policyAdmins"; readonly DOMAIN_ALL: "domainAll"; readonly POLICY_ROOM: "policyRoom"; readonly POLICY_EXPENSE_CHAT: "policyExpenseChat"; readonly SELF_DM: "selfDM"; }> | undefined; ... 66 more ...; reportFields?: Record<...> |...'.

@DylanDylann PR updated

@pasyukevich There are some minor comments. Let's address it

@pasyukevich there is conflict to resolve

@MonilBhavsar Updated

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Heroku client internal error.

Hi I installed Heroku tool belt for windows and I ran the heroku login in GIT bash command window.
I got the error like.,
Heroku client internal error.
connect timeout reached
I tried more times but it's not working.

@nkrishnamoorthi could you please rerun the command after running the following (will only work with Git bash).  Also, are you behind a network proxy or firewall?
export HEROKU_DEBUG=1

Hi Ransombriggs - I ran the command and tried but its not working. Yes I am behind the network proxy and firewall. Please help me on this.

@nkrishnamoorthi Could you please try setting the HTTPS_PROXY environment variable as described https://devcenter.heroku.com/articles/using-the-cli#using-an-http-proxy

@ransombriggs  - I followed your command and the heroku installed successfully.
But Once I use the "Heroku login" and I am giving my heroku credentials then I am getting below error.
post https://api.heroku.com/login: net/http: TLS handshake timeout
Please help me on this.

@nkrishnamoorthi It appears that it is timing out at your proxy server, could you try contacting your network administrator to see if they could provide any insight?


Create an attractive separate About Us and Contact Us Page

Is your feature request related to a problem? Please describe.
There is no about us page or contact us page
Describe the solution you'd like
There should be a separate and attractive, dedicated About Us Page and Contact Us page

@avinashkranjan Kindly assign me this issue so that I can start creating the required pages

Go Ahead @r7projects-shayan

@avinashkranjan should I update the About Us and Contact Us page in the website branch?

please assign this issue to me

please assign this issue to me


Json formatted CQL fails to deserialize via JsonCqlLibraryReader

I am running on latest from the develop branch. When I try to use JsonCqlLibraryReader to deserialize ELM in JSON format, I get  the exception below. Looking at the generated JSON and comparing it to the sample JSON-formatted CQL in the test resources, there is clearly a difference of missing "type" properties in several places in the newly generated JSON.
Attached is a test patch that will reproduce the problem.
test-patch.txt
com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.cqframework.cql.elm.execution.Library]: missing type id property 'type' (for POJO property 'library')
 at [Source: (StringReader); line: 40, column: 4] (through reference chain: org.opencds.cqf.cql.engine.elm.execution.LibraryWrapper["library"])
	at com.fasterxml.jackson.databind.exc.InvalidTypeIdException.from(InvalidTypeIdException.java:43)
	at com.fasterxml.jackson.databind.DeserializationContext.missingTypeIdException(DeserializationContext.java:1768)
	at com.fasterxml.jackson.databind.DeserializationContext.handleMissingTypeId(DeserializationContext.java:1297)
	at com.fasterxml.jackson.databind.jsontype.impl.TypeDeserializerBase._handleMissingTypeId(TypeDeserializerBase.java:299)
	at com.fasterxml.jackson.databind.jsontype.impl.AsPropertyTypeDeserializer._deserializeTypedUsingDefaultImpl(AsPropertyTypeDeserializer.java:164)
	at com.fasterxml.jackson.databind.jsontype.impl.AsPropertyTypeDeserializer.deserializeTypedFromObject(AsPropertyTypeDeserializer.java:105)
	at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.deserializeWithType(BeanDeserializerBase.java:1178)
	at com.fasterxml.jackson.databind.deser.impl.MethodProperty.deserializeAndSet(MethodProperty.java:138)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:288)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:151)
	at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4202)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3218)
	at org.opencds.cqf.cql.engine.execution.JsonCqlLibraryReader.read(JsonCqlLibraryReader.java:27)
	at org.opencds.cqf.cql.engine.execution.CqlEngineTests.readJson(CqlEngineTests.java:74)
	at org.opencds.cqf.cql.engine.execution.CqlEngineTests.toLibrary(CqlEngineTests.java:62)
	at org.opencds.cqf.cql.engine.execution.CqlEngineTests.toLibrary(CqlEngineTests.java:53)
	at org.opencds.cqf.cql.engine.execution.CqlEngineTests.test_simpleLibraryJson_returnsResult(CqlEngineTests.java:119)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:95)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:55)
	at java.lang.reflect.Method.invoke(Method.java:508)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:89)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:41)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:542)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:770)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:464)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:210)

Hi @csandersdev .
There are actually two JSON serialization formats supported by the CQL translator one for Jaxb (JSON) and one for Jackson (JXSON). The CQL Engine supports the Jackson format.
The translator options are here.

Thanks, @JPercival. I am trying to import libraries that our users create using the CDS authoring tool codebase and execute those in the CQL engine. The CDS authoring tool uses the cqframework/cql-translation-service docker image to stand up a web service that will translate the CQL and provide results, then it can export the CQL and compiled JSON as a ZIP file. I'm processing the exported ZIP files. The parse errors are coming when I try to read in the JSON libraries from those exported ZIP files. It looks like we can update the CDS code to request XML instead of JSON format, but would be nice if I didn't have to do that. I'd be happy to try to add support for JSON format in the CqlEngine, but it wasn't clear to me how I would do that.

I remember the JXSON PR for the translator -- and based on the conversation there, we merged it since it was only an option and did not deprecate JAXB.  But we also noted that further regression needs to be done and annotations need to be fixed.
So... it looks like JXSON serialization is a requirement for the Java engine now but the CDS Authoring Tool exports using JAXB serialization.  @JPercival , @brynrhodes -- Do you have a better understanding now of any possible regressions and have you addressed (or plan to address) the annotations issue?  If so, then I can consider moving AT to JXSON serialization.

We initially introduced the use of Jackson because of lack of JAXB support on Android. At the time we did the merge we thought it was likely backwards compatible though it was not extensively tested. We've since discovered that there are significant differences between the two formats. I've done some preliminary exploration that sets various options on both the Jackson export and import to make it compatible with JAXB and I haven't managed to rule that out as a possibility but I've not pushed far enough to achieve parity either. Assuming we do achieve parity there wouldn't be the need for both formats.
I've not done any further work on the annotations specifically.
The cql-engine also supports the XML format which is much more extensively tested. Would it be possible to use that instead?

The cql-engine also supports the XML format which is much more extensively tested. Would it be possible to use that instead?

I'm not sure if that was a question for me or for @csandersdev -- but we could look into having the CDS Authoring Tool export JSON and XML.  I assume it wouldn't be a big deal, but we'd need to look at it more closely.  I'm not sure the translator supports exporting both; we might have to run it twice, which is kind of unfortunate.

@cmoesel , the translator component does support producing all the serialization formats off the same translation, but the translation service doesn't expose that. The integration we did with the FHIR Publisher does support that capability though, and we added multiple output formats to the cql-options structure specifically to support that use case, so it should be straightforward to expose that in the service.
Ideally, we wouldn't have to produce both, but as @JPercival noted, we are still working on getting to parity between all the formats and target environments.

How would you folks like to move forward with this issue? Should I move the conversation to the CDS authoring repo since it appears that the CqlEngine is working as designed right now? Or maybe the CQL Translation service repo? My naive point of view is that the simplest possible change would be to update the CQL Translation Service to export JXSON vs JSON, but I have no idea what kind of impact that might on downstream processing.

Based on @JPercival's comments above, I'm not sure we can/should outright switch the translator to JXSON -- or switch the CDS Authoring Tool to JXSON.  My concern is that there are other engines out there (like the JavaScript one) that currently assume the JAXB serialization and may not work correctly w/ the JXSON serialization.  This is directly relevant because the CDS Authoring Tool uses the JavaScript engine in its "Testing" tab.
We could update the translation service to support more modes/formats -- so you could ask it for JAXB JSON, JXSON JSON, XML, or some combination of those.  After that, we could update the CDS Authoring Tool to invoke the translation service and ask for JAXB JSON and XML -- and you could use the XML w/ the CqlEngine.
Or if you're running your own instance of the CDS AT (not the AHRQ-hosted instance) and you're comfortable w/ the risk of JXSON, we could expose a configuration parameter that allows you to say that your instance of CDS AT should export JXSON JSON.
Last -- I don't know your workflow, but another approach would be for you to take the CQL that the CDS Authoring Tool provides and re-translate it using the JXSON serialization.  CDS AT gives you the .cql files and the .json files, so there's no reason you couldn't just re-translate the .cql files (if you have a workflow where you could integrate such a step).

It seems like a reasonable step would be to surface the ability to request multiple translation formats in the translation service. Submit a tracker to that effect on the translation service repository: https://github.com/cqframework/cql-translation-service ?

I've dug into this enough to confirm that the JAXB and Jackson formats can't be fully reconciled at this time. I did a fair amount of investigating on getting JAXB working on Android and the general consensus appears to be "don't do that". There's a related issue with translating CQL on Android, which is that the ModelInfos are currently specified in XML. The solution that appears to be the most compatible with the largest spread of Java platforms is Jackson-based JSON (as opposed to JAXB-based XML, JAXB-based JSON, or XML serialized via some other framework).
The next step from the translator perspective is to support JSON-based ModelInfos.These would need to be Jackson-based in order to support translation on Android.  The ModelInfo format is not a normative part of the ELM specification so that change could be relatively easily made.
I think it makes sense to have the discussion as to whether to support both JSON and JXSON going forward or to standardize on Jackson. This would be a backwards-incompatible change for all the ELM out in the wild. Unfortunately, we're in that position already as there's not currently a way to distinguish between the two formats based on mime-type, AFAIK.

Is it possible to enumerate the differences between JAXB-produced JSON and Jackson-produced JSON (for ELM)?  That would be helpful in trying to determine the implications of deprecating JAXB-produced JSON.

We can definitely do a detailed comparison on a body of ELM, I have a whole bunch of ELM in the engine that I use for regression of the reader and we can produce a diff based on that, but at the highest level, the biggest change is to the way the content serializes inside annotations. Which has long been a sore spot anyway, and I'm actually wondering if we would be better served by just turning that into an HTML string, instead of trying to represent as mixed content. How much effort would be involved from your perspective in consuming an HTML string instead of reconstructing it from the JSON mixed-content representation?

So are the next steps here to shoot an e-mail to the Bonnie team to discuss the possibility of annotations as HTML?

I think so, and I'd also reach out to the Abacus team at MITRE.  I think I already pointed a few of them to this before (as a heads up), but I'll let them know that you are looking to talk to them.

We (MITRE Abacus) rely pretty heavily on the current JSON structure of the annotations to do clause highlighting of the CQL. We need some way to look back into the execution results for localIds to know if a clause was truthy or falsy, and the r property on an annotation helps us do that.
Assuming that annotations being an HTML string would just be an un-styled nested structure of HTML tags, would there be a way to preserve some ability for the localIds to persist? Otherwise, it could be really difficult to keep the same highlighting functionality.

Hi @mgramigna , the HTML string contents would actually be the XML that comes out in the XML rendering, so:
            <a:s r="4">
               <a:s>define HelloWorld:
  </a:s>
               <a:s r="3">
                  <a:s r="1">
                     <a:s>'Hello'</a:s>
                  </a:s>
                  <a:s> + </a:s>
                  <a:s r="2">
                     <a:s>'World'</a:s>
                  </a:s>
               </a:s>
            </a:s>

Then JSON-escaped of course. So it would still have the localId ties to the expression nodes, it would just be represented as embedded XML, rather than trying to serialize it as mixed-content XML as part of the ELM. Does that help?

What are the next steps on this? Does the XML structure Bryn posted above work for your use case @mgramigna ?

@JPercival yeah, we could update our measure highlighting code to support this.
@brynrhodes -- do you envision the Measure bundles that exist and connectathon/ecqm-content-r4 to have ELM that is updated with the new annotation format once that exists?

@mgramigna , yes, and we'll make the change with a switch to make sure we support a transition phase.

So, I understand the resolution to be that we're phasing out JAXB in favor of Jackson with a transition period. Post transition period it'll all be Jackson, and it'll include the annotations as Bryn described above.
What's a reasonable transition period? The last cql-engine release was about 6 months ago. Is 6 months from now a good target?

@JPercival  Sounds good from our side

I'd like to press for quarterly releases, I think 6 months is too long. So once the smoke has cleared from this release, we should plan the next one for end of year.

There are some pending updates to the cql-translator that supersede some of this discussion: cqframework/clinical_quality_language/pull/752


fix(MOPLAT-196): fix app restarting when taking photo

The type of this PR is: Bugfix

This PR is about MOPLAT-196
Description
The app restarts when the user takes a picture to pass to react-native-image-crop-picker. We do not know exactly why this is happening. And it seems to happen on random devices, but mostly on android-10 and android-11s. This hack silently clears the cache on android before taking the photo.

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

fix app restarting when taking photo - kizito

This PR contains the following changes:

Dev changes (fix app restarting when taking photo - kizito)

  Generated by :no_entry_sign: dangerJS against 0479b8fb7ed7c65a438ef372e757eebec2cd0268

wow. blows my mind that this workaround works. i guess that crop lib is wonky. nice work kiz!
maybe change the PR desc to This PR is about <jira link>, so that it doesnt close it, and we can use this to track this issue? 🤔

Thanks, it needs to be tested on many devices. Does it work fine in yours?

mine was working fine even before this, but ill give it a go now with this PR.

Should we merge this already after fixing the merge conflicts?

I will go ahead and merge but unfortunately I do think this is still a bug on some devices


IOS breaks with threaded socket

Library version: [commit id (31589e6)
Framework: [Unity]
OS: [iOS]
For whichever reason this only seems to happen in developer builds, not release. I start LNL on a thread to prevent blocking during the connect/disconnect process and on iOS the client fails silently.
The offending bit is where the 'Start' method inside NetManager.Socket creates the 'UnitySocketFix' gameObject. This fails because LNL is on a thread and GameObjects can only be made on the main thread.
I've created a solution and it's been tested by two users with success but I've not been able to validate thoroughly myself as I do not own iOS. Before I make a PR I want to be certain my changes make sense to the LNL team.
First I noticed that UnitySocketFix was closing the connection when the application lost focus. I'm not sure if that's ideal as it can cause all sorts of problems for real-time games or applications. Instead I made a few changes to only reconnect if not connected.
        private void TryReconnect()
        {
            if (_netManager == null)
                return;
            //Was intentionally disconnected at some point.
            if (!_netManager.IsRunning)
                return;
            //Socket is still running.
            if (_netManager.SocketActive(false) || _netManager.SocketActive(true))
                return;

            //Socket isn't running but should be. Try to start again.
            if (!_netManager.Start(_ipv4, _ipv6, _port, _manualMode))
            {
                NetDebug.WriteError($"[S] Cannot restore connection. Ipv4 {_ipv4}, Ipv6 {_ipv6}, Port {_port}, ManualMode {_manualMode}");
                _netManager.CloseSocket(false);
            }
        }

        public bool SocketActive(bool ipv4)
        {
            if (ipv4)
            {
                if (_udpSocketv4 != null)
                    return _udpSocketv4.Connected;
                return false;
            }
            else
            {
                if (_udpSocketv6 != null)
                    return _udpSocketv6.Connected;
                return false;
            }
        }

My new implementation resides in a class that does not derive from MonoBehaviour, therefor no reason to use Update to destroy itself as it will leave memory when it's references are lost.
I also added this to the constructor/deconstructor in place of the OnApplicationPaused event. I wasn't able to test this part but the idea is to use FocusChanged to attempt a reconnect when needed.
        public PausedSocketFix()
        {
            UnityEngine.Application.focusChanged += Application_focusChanged;
        }
                ~PausedSocketFix()
        {
            UnityEngine.Application.focusChanged -= Application_focusChanged;
        }
    private void Application_focusChanged(bool focused)
        {
            ApplicationFocused = focused;
            //If coming back into focus see if a reconnect is needed.
            if (focused)
                TryReconnect();
        }

Very last I removed the UnitySocketFix and all parts used by it within NetManager.Socket. Where the UnitySocketFix was previously initialized in the 'Start' method I just did something like this...
private PausedSocketFix _pausedSocketFix;

//In Start(IPAddress, IPAddress, int, bool)
if (_pausedSocketFix == null)
   _pausedSocketFix = new PausedSocketFix(ipv4, ipv6, port, manual);

If all of this makes sense let me know and I can definitely get the PR in.

I've had several more individuals test with success. Even while minimizing their apps/putting them in the background connections held and/or were re-established when connections dropped.
I made a PR here https://github.com/RevenantX/LiteNetLib/pull/514


运行环境
版本号：最新2.18
运行平台：win10
运行架构：
Python版本：
配置文件
{

"format": "ts",
"interval": 5,
"user": [
{
"platform": "Twitcasting",
"format": "ts",
"id": "ym7ix",
"name": "θ 桃天ユエ ໒꒱"
}]
}

复现步骤（可选）

...
错误描述
见日志
错误日志
[2023-07-20 22:01:33][ERROR][main][stream_writer:156][Twitcasting][θ 桃天ユエ ໒꒱]直播录制未知错误
No data returned from stream
Traceback (most recent call last):
File "threading.py", line 973, in _bootstrap
File "threading.py", line 1016, in _bootstrap_inner
File "threading.py", line 953, in run
File "concurrent\futures\thread.py", line 83, in _worker
File "concurrent\futures\thread.py", line 58, in run
File "main.py", line 133, in run_record

File "main.py", line 146, in stream_writer

File "streamlink_cli\main.py", line 320, in open_stream
streamlink.exceptions.StreamError: No data returned from stream
[2023-07-20 22:01:33][INFO][main][run_ffmpeg:161][Twitcasting][θ 桃天ユエ ໒꒱]开始ffmpeg封装：[2023.07.20 22.01.31][Twitcasting][θ 桃天ユエ ໒꒱]心が楽になるASMR🩹ྀིマウサ2400.mp4
[2023-07-20 22:01:33][ERROR][main][start:57][Twitcasting][θ 桃天ユエ ໒꒱]直播检测未知错误
Error('ffmpeg error (see stderr output for detail)')
Traceback (most recent call last):
File "main.py", line 397, in
File "asyncio\runners.py", line 44, in run
File "asyncio\base_events.py", line 636, in run_until_complete
File "asyncio\windows_events.py", line 321, in run_forever
File "asyncio\base_events.py", line 603, in run_forever
File "asyncio\base_events.py", line 1909, in _run_once
File "asyncio\events.py", line 80, in _run

File "main.py", line 49, in start

File "main.py", line 353, in run
File "asyncio\threads.py", line 25, in to_thread
File "concurrent\futures\thread.py", line 58, in run
File "main.py", line 136, in run_record
File "main.py", line 168, in run_ffmpeg
File "ffmpeg_run.py", line 325, in run
ffmpeg._run.Error: ffmpeg error (see stderr output for detail)
错误截图（可选）
No response

你确认主播已经开播了吗，这个是streamlink那边的报错，可能是没找到直播地址

我觉得程序应该对没开播的情况，进行提示说明，而不应该抛出异常

已尝试对异常捕获优化了提示，请下载v2.19版本测试是否正常出现提示

点个赞


Bulk add-to collections tool is clearing items that were previously added to collections individually

There must be a "replace" rather than "add" logic bug in the code

@bwhicks this is a good candidate for writing the unit test first to confirm you can duplicate the bug in tests before correcting the logic.

Testing notes (since I'm reluctant to edit a non team members issue post)
Suggested work flow:

[ ] individually add a digitized work to a collection (or bulk add several)
[ ] then bulk add some other works to the collection
[ ] both the works added in the first step and the works in the second step should remain set (in admin and front end)

I searched "dictionary" and added a few results individually, then bulk added a few. All of the works added in both steps remained in the set on the admin and front end. I also successfully added works to multiple collections individually and in bulk. Bug fixed! One thing would be nice if it wouldn't take too much time--after individually adding via the change form, it takes me back to the table view and retains my keyword search (showing me 126 results)--great! When I bulk add, it refreshes, clears my search, and shows me all (5007) results. It would be nice if the bulk add would refresh back to the initial keyword search--useful but not essential.

@mnaydan Normally this would be a separate issue and development cycle, but that feature happens to be something we have the code for. I'll put it together and push it to QA this afternoon after discussing it with @rlskoeser.

@mnaydan This is back at you when you have a moment with the change you requested, with an extra testing task. Last issue before the release can be finalized!

Tested by searching "dictionary," bulk added 5 works, it successfully redirected to same search page. Perfect! Thank you @bwhicks !


Basic Manager functionality

Manager allows to enqueue and dequeue jobs.

[x] Enqueuing
[x] Dequeuing

Closed by 6a8bd82083ecc6a50a353484333ab001d1abed3a


Pool by Team Scope Creeps / EWAN

issue #140

Please rebase this on your team's branch @okwme - not master... So, that would be team/#3-EWAN


Reason binding: PhenomicPresetReactApp.jsEdgeToReason should accept a option(fun) as second argument

This is an accompany request to #1217. If I use JS Object directly, there is no need for a transformer.
Example component with such usecase:
open Helpers;

let component = ReasonReact.statelessComponent("Package");

type package = {
  .
  "id": string,
  "name": string,
  "body": string
};

let make = (~package, _) => {
  ...component,
  render: _self => {
    let render = () =>
      switch (package: PhenomicPresetReactApp.edge(package)) {
      | Inactive
      | Loading => "Loading ..." |> text
      | Errored => "An error occured" |> text
      | Idle(package) =>
        <div>
          <h1> (package##name |> text) </h1>
          <BodyRenderer body=package##body />
        </div>
      };
    <IndexLayout render />;
  }
};

/* TODO: fix upstream package to allow not passing a converter */
let doNothing = a => a;

let jsComponent =
  ReasonReact.wrapReasonForJs(~component, jsProps =>
    make(
      ~package=
        PhenomicPresetReactApp.jsEdgeToReason(jsProps##package, doNothing),
      [||]
    )
  );

let queries = props => {
  let package =
    PhenomicPresetReactApp.query(
      Item({path: "packages", id: props##params##splat})
    );
  {"package": package};
};

Make sense. @bloodyowl thoughts?


Use pyvenv instead of virtualenv

Python 3.3+ contains pyvenv which works like virtualenv:
https://docs.python.org/3/library/venv.html
We should change the OpenSlides install instruction (in README and manual?) to switch to pyvenv.
Note: Python3.3 does not install pip automatically. Python 3.4 does it.

Test this once more with ubuntu 14.04

@normanjaeckel It would be great if you can update the install instruction. Can you please test if pyvenv works on windows? (In my last short test it does not work...)

For Ubuntu 14.04 the command sudo apt-get install python3.4-venv is necessary.