Send different key codes for Tab and Ctrl+I (READ: support modifyOtherKeys)

Description of the new feature/enhancement
When using ms-terminal, Tab and Ctrl+I send the same key codes. This makes it impossible to map them differently, for example in vim or nvim (which support this functionality: https://github.com/neovim/neovim/pull/17932#issue-1188088238).
If ms-terminal sent different key codes (like for example kitty or alacritty terminal), then it would be possible to map these keys to different functionalities in software running inside the terminal. This would enhance user experience and make it easier to migrate from the aforementioned terminals.

Proposed technical implementation details (optional)

Okay this sounds like we just need to support modifyOtherKeys. There was previous discussion in

#8719
#11509

From the docs

When modifyOtherKeys is set, ordinary keys may be sent as escape
sequences:

When modifyOtherKeys is set to 1, only the alt- and meta-modifiers
apply.  For example, alt-Tab sends CSI 2 7 ; 3 ; 9 ~ (the second
parameter is "3" for alt, and the third parameter is the ASCII value
of tab, "9").
When modifyOtherKeys is set to 2, all of the modifiers apply.  For
example, shift-Tab sends CSI 2 7 ; 2 ; 9 ~ rather than CSI Z (the
second parameter is "2" for shift).

Does anyone have a workaround for this problem in the interim?
My concrete issue: I have different mappings for <TAB> and <C-i> in neovim. In macOS, Kitty can differentiate just fine, but in Terminal on Windows (ubuntu wsl2) it seems to view them as the same input.

Hi @zadjii-msft,
As the comment above mentioned, is there a temporary workaround that we can use while this issue is being worked on?

You could probably manually add a sendInput action in the Terminal settings, bound to ctrl+I, that sends ~ some escape sequence ~, and then configure your editor to be bound to that escape sequence instead of just C-i.
What ~ some escape sequence ~ actually is would depend on the rest of your config, I'd reckon. I'm not super familiar with keybinding editing for neovim, so I don't really have a good end-to-end recommendation here, I'm afraid.

No worries, thanks for pointing me in the right direction, I will look into it!

It doesn't work by default for me on alacritty. In fact, it straight up ignores those key combos altogether.
If anyone has a working hack to fix this, making all of these keys be sent correctly, please share. It's a really draining issue for me


fix error in small typos in matmul_forward.cu

The sqrt_block_size is 32 in     matmul_forward(kernel_num, d_out, d_inp, d_weight, d_bias, B, T, C, OC, 32);
thus the printf should have 1024.

bleh copy paste and debugging gone wrong, ty


typeorm encryption nopt working in case of unique true column

@Entity()
export class UserEntity extends BaseEntity {
@PrimaryGeneratedColumn()
id: number;
@Column()
name: string;
@Column()
age: string;
@Column({
type: "varchar",
nullable: false,
unique: true,
transformer: new EncryptionTransformer({
key: 'e41c966f21f9e1577802463f8924e6a3fe3e9751f201304213b2f845d8841d61',
algorithm: 'aes-256-gcm',
ivLength: 16
})
})
email: string;
}    in this case it always generate new cyper even if the email is same expected it need to throw error of duplicate please take a look at this issue

Good to know @jvdutrag . I've been too busy lately to keep up with this. If there are other people open to help maintaining it, I'd be happy to include them as a maintainer.

I'm gonna try it and if it works will request a PR @generalpiston


Unpin pandas and use new pip features

I think the install failures are a pip issue not our scmdata packaging...

Ahh didn't know about that feature. I would have assumed that it follows the children deps, but I was wrong

ye it's bizarre that this wasn't the default, anyway

yore


Added validation for nested keys

Prevented users from adding a key under an already existing key, which causes inconsistencies in tweek-repo and shouldn't happen anyway.
Currently it's half-blocked in the editor UI itself, but under some cirumstances around archiving, it can reach an inconsistent state and still let users create such keys.
This PR mitigates that on the Publishing side.

It might worth adding test on deeper nesting


Pre-requisite checks for ckcp/openshift_dev_setup.sh

Tasks

Add a pre-requisite check function in the script to ensure that dependencies are satisfied.
Add appropriate error messages on failure of installation of resources for e.g.- here

fixed in PR #100

Thanks @xinredhat, I'll close it then.


Request - Passing just the image/raw data to decoder

I want to pass raw data to the decoder instead of using the whole library.
Please expose a function that accepts images data and return decoded data if any.

Abdurrahim Hacıoğlu
SMMM & Bilgi İşlem Uzmanı
apoleptika.wordpress.comhttps://apoleptika.wordpress.com

From: Ray Luxembourg<EMAIL_ADDRESS>Sent: Wednesday, July 25, 2018 2:03 PM
To: schmich/instascan
Cc: Subscribed
Subject: [schmich/instascan] Request - Passing just the image/raw data to decoder (#169)
I want to pass raw data to the decoder instead of using the whole library.
Please expose a function that accepts images data and return decoded data if any.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/schmich/instascan/issues/169, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AC-ikCxdUiKxI9uwifQ_djQUjjaKWeVMks5uKFBvgaJpZM4Vf4Wj.


feature: e164 standard for the phone number as another user field

Hi Casdoor Team,
Can we have a e164 standard for the phone number as another user field? so get-user can find user by the full phone number.

Thanks

@andrewvmail why need this?

Hi @hsluoyz
Thanks for the quick response.
We need a phone number to be searchable and our app is global. Casdoor does have an API to search by phone number thats great. We can do it like so  https://demo.casdoor.com/api/get-user?phone=6045524211
I found an edge case with the system though.
It's possible to have this case:
User from the US/Canada, country code: +1  phone:<PHONE_NUMBER>
User from India, country code: +91  phone:<PHONE_NUMBER>
Currently Casdoor unique indexed the phone number so if you have a user from india and some from us/canada with the non country code part of the number the same, you will get

UK + Australia, Indonesia + Russia to name a few that can cause overlaps problem as well. I think a standardized field on top of the existing that can also be searchable is good to have.
Thank you


Multiple implementations of same method should give error

  METHOD moo.
  ENDMETHOD.
  METHOD moo.
  ENDMETHOD.

https://rules.abaplint.org/method_implemented_twice/
closing


Observed errors

On injex 0.1.0:

404 error (at the very beginning)

An error occurred: 2 columns passed, passed data had 8 columns

addressed with #4


Tracking issue - Support using Alloy/Titanium CLI

This is the overall tracking issue for supporting using Alloy/Titanium CLI from VS Code. It will list all items involved in the project as well as the order they should be done. Any general comments should go here, comments specific to an issue that is filed should go in the related issue.
First Steps
[ ] #32 Determine method of how preferred setup will be chosen.

We need a way for users to indicate they wish to use the Alloy/Titanium CLIs in place of the Appc CLI. I believe a config setting would be best to do this.

Building projects
Creating projects
Environment info gathering
Miscellaneous

Released in v0.11.0


Update row column data after change de ItemSource

Hi, in runtime using mvvm community toolkit is possible to update a cell, after some property change?
I set my binding in the view with C#
dataGrid.SetBinding(DataGrid.ItemsSourceProperty, nameof(attachmenListViewModel.Attachments), BindingMode.TwoWay);
in the viewmodel:
public ObservableCollection Attachments { get; } = new();
I load the data and it shows the info Ok in the Grid
later in a command
Attachments.First().Status = "Requested";
Nothing happens
Can you please help me with this issue, I'm missing something ? Thanks

The Attachment object would need to inherit from INotifyChanged and the Status property would need to fire an OnPropertyChanged event in the setter.
If you do that, then the properties should update.
I just tried it, and it works fine.


Add support for reversing FIELD order

Motivation / Background

This Pull Request has been created because [REPLACE ME]
Detail
This Pull Request changes [REPLACE ME]
Additional information

Checklist
Before submitting the PR make sure the following are checked:

[ ] This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
[ ] Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
[ ] Tests are added or updated if you fix a bug or add a feature.
[ ] CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.
[ ] CI is passing.

Closing this one since I have a real one opened in the rails/rails repo: https://github.com/rails/rails/pull/46464.


403 Forbidden on RealSense repository

403 error if one follows these instructions:
https://github.com/IntelRealSense/librealsense/blob/master/doc/distribution_linux.md

Hello @dheera ,
The debian packages are currently supported for Ubuntu 16 LTS. It seem that you're trying to install it from Ubuntu 18 though.
Please follow the instructions and build the SDK from source code.  (related to #1670 )

[Realsense Customer Engineering Team Comment]
Hi @dheera,
Did you follow the instruction to build from source?

Instructions has been updated to support Ubuntu 18

Thanks!


Use Perl's switch parsing argument to pass variables to scripts

This is in the same line as commit 7c4b4545c07e273a815135fc04c4d1ee3a140f1b.

I've been running this patch for a while now, but I'm not sure I have tested everything. Please look over the patch and let me know if you see any issues.

This is a more robust way of passing variables into Perl. I made this patch for two reasons, i) to use the same pattern as was done in commit 7c4b4545c07e273a815135fc04c4d1ee3a140f1b, that fixed an issue (#240) with parsing spaces in properties files, to simplify future code debugging, and ii) it actually fixes a bug I found while working on new code for msc-gui.

i see, very nice !


[ACR] API review update

Async PUT/PATCH follow 201+provisioningState model now.
Change webhook isEnabled from bool to status string enums.
Remove pull from webhook actions.
Use storage account resource id rather than name+accessKey.
Complete enum values for provisioningState.
Add status to registry and replication resources.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

This change is

No modification for Ruby

No modification for NodeJS

No modification for Python


fix(file-upload): separated validation from file-upload (#DS-2554)

Summary
Enhancements to kbq-file-upload Component:
• Hints Behavior: Hints now function similarly to those in form fields. BREAKING CHANGES
• Validation Changes: errors and customValidation properties are deprecated. Use abstract control validation or external validation instead.
• New Events: Added filesAdded and fileRemoved events for handling multiple file uploads.
• Examples: Included examples demonstrating custom validation and hints, as well as validation using reactive forms.
List of notable changes:

changed representation of errors and hints. Now you can use them via kbq-hint inside
added 2 new output emitters for multiple file. filesAdded - representing currently added files. fileRemoved - representing file and it's index at the moment of removal.
added examples of custom validation  and new hints output
added examples of validation with reactive forms.
fixed focus in multiple file upload in file list keyboard navigation
removed usage of form-field related CSS-variables in file-upload styles, used global vars instead

по хорошему нужно оборачивать поле в kbq-form-field, но для этого нужно рефакторить компонент
в данном случае получается дублирование логики отображения ошибок и подсказок
(на будущее)


pythonPackages.sfepy: init at 2019.2

Add Sfepy finite element solver.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@risicle, all your suggested changes have been included now.

Hmm. The tests seem to be taking a lot longer than they were previously for me. I wonder if it would be better to blacklist a few of the worst offenders by adding them to the rm list.

I filed an issue with the Sfepy developer regarding having a --fast option for the tests, but in the meantime I removed the slowest ones so we can move forward with this. The tests run in ~20s now for me.

Cool. For some reason test_splinebox.py fails for me now under py27/macos 10.13. Investigating, because it's fine on linux and also on py37...

Ok, the problem seems to be a fairly standard matplotlib/macos one that can be solved with a modification to the checkPhase:
   checkPhase = ''
     export HOME=$TMPDIR
     mv sfepy sfepy.hidden
     mkdir -p $HOME/.matplotlib
     echo "backend: ps" > $HOME/.matplotlib/matplotlibrc
     ${python.interpreter} run_tests.py -o $TMPDIR/test_outputs --raise
   '';

I've added the -o option and kept --raise to help the next person who breaks these tests - otherwise the exact reason for failure requires a bit of digging.

@riscle, ping reminder that I made necessary changes.


Bump metrics-server tag to 0.7.0 for Kubernetes 1.29

Bump metrics-server tag to 0.7.0 for Kubernetes 1.29.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/woof
/meow

/lgtm

/approve


Upgrade Lucene to 9.4.2 and other libs to latest version

No changes between 9.4.0 and 9.4.2 for the test files we override.

Unrelated io.crate.integrationtests.disruption.seqno.ConcurrentSeqNoVersioningIT.testSeqNoCASLinearizability: timed out

retest this please

Can we separate the version bumps of the libs ? Are they depending on each other ?

Can we separate the version bumps of the libs ? Are they depending on each other ?

ah you did that already.


Add tests for imaging exceptions

Just a couple of tests for the exceptions.

Coverage increased (+0.07%) to 74.902% when pulling fa39b5d397b7708ca3e0768f630f953adcec6a41 on kinow:cover-exceptions into 7bad38419c9712ef68723c38b2c07d682a22a077 on apache:master.


[Feature] 可以加一个长按的按键种类

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

用技能类型按键并在设置中选择”无方向技能“就能实现长按按键


Add conda instructions for October release

As promised, this PR adds the conda instructions for the release next week.
I've set it to draft so that it doesn't accidentally get merged.
Change it to ready for review, when you are ready for review :)

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
AcrolinxScore
LowestCategoryScore
Issues
Scorecard
Processed

articles/install-guide/index.md
96
91
4
link
:white_check_mark:

More info about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues

Docs Build status updates of commit 43fdbce:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/install-guide/index.md
:white_check_mark:Succeeded
View (qsharp-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
AcrolinxScore
LowestCategoryScore
Issues
Scorecard
Processed

articles/install-guide/index.md
96
91
4
link
:white_check_mark:

articles/install-guide/update.md
86
72
7
link
:white_check_mark:

More info about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
AcrolinxScore
LowestCategoryScore
Issues
Scorecard
Processed

articles/install-guide/index.md
96
91
4
link
:white_check_mark:

articles/install-guide/update.md
86
72
7
link
:white_check_mark:

More info about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues

Docs Build status updates of commit a8ecff1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/install-guide/index.md
:white_check_mark:Succeeded
View (qsharp-preview)

articles/install-guide/update.md
:white_check_mark:Succeeded
View (qsharp-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Closed--conda is postponed


feat: sub flag key config support

Summary

Checklist

[ ] Does your PR title have the correct title format?
Does your PR have a breaking change?:

lg, maybe get the build pass later

Yes, the current test only works for the local server. Need to fix the test until we deployed the skylab API.


Disable fail fast for qps driver

Fixes #6174

LGTM. Didn't realize that this was in here.

It brings alignment with the other stacks.

... and a saner experience when using long lived streams


ServerBuilder interface cleanup

Nothing is added or removed in this PR.
Instead, methods are re-ordered so that important methods are read
first, and less important customization methods are seen later.
The intent here is to simplify the "I just want to bring a server up"
learning path.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]      +8  +0.0%

  [ = ]       0 TOTAL       +8  +0.0%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]      +8  +0.0%

  [ = ]       0 TOTAL       +8  +0.0%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


Discuss whether it makes sense to provide a separate AF category for consanguineous pops

Spoke with Mark recently about this, and he said consanguineous pop AFs should not be significantly different from the general population AFs. Their value is in enriched for homozygous alternate genotypes.


Intermittently ignoring a custom type adaptor

Here is my code:
    OutputStreamWriter(GZIPOutputStream(FileOutputStream("financials-0.0.1.json.gz"))).use {
        GsonBuilder()
                .registerTypeAdapter<Instant> {
                    serialize {
                        it.src.epochSecond.toJson()
                    }
                }
                .registerTypeAdapter<LocalDate> {
                    serialize {
                        it.src.toString().toJson()
                    }
                }
                .create().toJson(financials, it)

For some reason, it seems to be intermittently ignoring the Instant custom serializer and serializing an Instant field to {"seconds":1452211200,"nanos":0}
Sorry I can't reliably reproduce it, but can you think of any reason this could occur?

Sorry, I can't.
Instant is a final class, so there should not be any need for registerTypeHierarchyAdapter.
I've tried to reproduce this but I couldn't.
Are you using other means to configure GSon, such as the JsonAdapter annotation ?

A little confused, I used registerTypeAdapter, not registerTypeHierarchyAdapter ... ?

Are you using other means to configure GSon, such as the JsonAdapter annotation ?

Nope, the code you see is the only code in which I use Kotson or Gson in my codebase.

Well, I have tried to reproduce this, without any success.
Indeed, you do not need registerTypeHierarchyAdapter, I was "thinking out loud".
I have no idea what's causing this, but I can't figure out any reason why the library would behave like that.

Hi,
any update ?
I've tried again all I could to reproduce, but couldn't...

No, haven't seen the problem since :(
On Thu, Mar 24, 2016, 10:53 Salomon BRYS<EMAIL_ADDRESS>wrote:

Hi,
any update ?
I've tried again all I could to reproduce, but couldn't...
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/SalomonBrys/Kotson/issues/13#issuecomment-200898783

I'm closing the issue for now.
If you encounter this behaviour again, feel free to reopen ;)

Roger wilco :)
On Thu, Mar 24, 2016 at 11:17 AM, Salomon BRYS<EMAIL_ADDRESS>wrote:

I'm closing the issue for now.
If you encounter this behaviour again, feel free to reopen ;)
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/SalomonBrys/Kotson/issues/13#issuecomment-200907171

--
Ian Clarke
Blog: http://blog.locut.us/


Creating a new plugin which may be deemed as a duplicate of a no longer maintained plugin?

I'm looking to create a gulp plugin that will create a templates file consisting of a user defined namespace of different files. Say a user picks TMPL.
var TMPL = {
  'templates/template': '<html>...</html>'
};

This could either be blocks of HTML or a keyed object of lodash functions. With the latter, it would be best to provide interpolation options naturally.
This type of file is used similarly to angulars template cache and would be used in a concatenation of scripts for deployment.
If I am to create this plugin, I can foresee it being blacklisted as a duplicate of gulp-jst-concat although gulp-jst-concat doesn't offer the ability to use lodash options and I find its options to not be as intuitive as possible.
The other issue here is that gulp-jst-concat hasn't been touched in over a year nor has it's owner been active for over a year although people are posting issues. It would seem unfair to be blacklisted if I was to implement a newer version that was actively maintained by myself. I can see this being an issue with other plugins too.
@jh3y

We want what's best for the gulp ecosystem. We're happy to blacklist the existing one if it's unmaintained and yours is better.

Sweet. I'll get to work. Thanks @sindresorhus !


Config generation process keeps removing a readme line for "cypress/base:16.13.2"

This is in base/README.md

Obsolete due to replacement Factory generation process.


Fixing the Crop size but allowing the user to position the crop

Hello, I was having a look at this component and I was wondering if it would be possible to fix the size of the crop but allowing the user to position the crop anywhere on the image ? The minHeight and minWidth property allow us to do this in part but the user would still be able to increase the crop.
Will it be possible to achieve this in the current state of the component or would it need additional max height and Width props ?

Hi, it may be possible to limit the width from the parent by modifying the values in onChange and re-rendering the component, however that sounds like a hack and might not work/be efficient. Having maxWidth and maxHeight props sounds reasonable though so I'll add them in the next week.

Released in rc7

Thank you so much for this feature in the awesome plugin @DominicTobias  :+1:


Refactor(ItemWithIndex): remove ItemWithIndex type

An index was manually added to every iterable data passed to VirtualizedLists.
In convertToGrid function (dedicated to VirtualizedGrids), we saw that map gives access to the index of every item of data.
We can use the same for VirtualizedLists by using the index passed inside the renderItem prop.
The refactoring is cut in 2 parts :

Pass index to all components that use one (from bottom layers to top layers)
Delete ItemWithIndex.

Tests realized on Web :
https://github.com/bamlab/react-tv-space-navigation/assets/74320569/98aba34f-bb20-44d7-ad65-c70072b1cc15

This is awesome, thank you so much. I think there might be a bug though on the virtualized grid indices!

vs

@pierpo I fixed it !


Example - Get/Set device properties (numbers of channels, sample rate, frame size…)

Hi there,
I'd love to set the sample rate for a given AudioDevice. Unfortunately I couldn't figure out how to do this. Is there any chance you could add an example file showing how you can set device properties?
Thanks!

Hello samaaron.
I'm so sorry for my late response.
I'll check and merge xavriley's pull request later but it seems good example for setting sampling rate.
And there's no options for numbers of channel and frame size etc... I'll investigate the way to add these options by CoreAudio API, but I cannot say it's possible or not just now.


WIP: Feat/SaveSolidDatasetInContainer in access Grants

New feature description
This PR adds the saveSolidDatasetInContainer method to our access grants library.
Also updates our solid-client library as this was necessary for this function to be added.
Checklist

[x ] All acceptance criteria are met.
[x ] Relevant documentation, if any, has been written/updated.
[ ] The changelog has been updated, if applicable.
[x ] New functions/types have been exported in index.ts, if applicable.
[NA ] New modules (i.e. new .ts files) are listed in the exports field in package.json, if applicable.
[NA ] New modules (i.e. new .ts files) are listed in the typedocOptions.entryPoints field in tsconfig.json, if applicable.
[ x] Commits in this PR are minimal and have descriptive commit messages.

I need to update the Change Log before merging - I'll follow this comment for instructions.

I am running into two errors during the e2e check process. FYI I have no yet written the E2E tests for this function so there is still more to be done for this PR but these two errors don't look related to my PR. Are these known or is this something I need to add to my code?

      35 |   async handleRedirect() {
      36 |     // Wait for the backchannel exchange
    > 37 |     await this.page.waitForRequest(
         |                     ^
      38 |       (request) =>
      39 |         request.method() === "POST" && request.url().includes("/token")
      40 |     );```

and

```You should use `import { createTheme } from '@material-ui/core/styles'````


CVE-2018-1258 - false positive

Similar to this issue https://github.com/jeremylong/DependencyCheck/issues/1383
False positive on library https://mvnrepository.com/artifact/org.springframework.security/spring-security-core/4.2.13.RELEASE - reported as cpe:2.3:a:pivotal_software:spring_security:4.2.13:*:*:*:*:*:*:*
According to https://pivotal.io/security/cve-2018-1258:
"Users leveraging Spring Framework 4.x (Spring Security 4.x or Spring Boot 1.x) are not impacted so no steps are necessary."

There are two aspects to this.  First, an update request should be made to the NVD for this CVE.  If there data is wrong there is not much we can do about it. Second, ODC does not correctly utilize the and/or configurations defined in the NVD JSON data feeds.  We should enhance ODC to only flag this if an affected version of Spring is present AND spring-security is present.

I think this is basically a dupe of #1827 which has a fuller explanation of the issue with the AND not being supported.

@chadlwilson You're absolutely right, closing this one.


"Warning: Potential Security Risk Ahead" for the web site

Opening the "Click me!" link on the README page results in:

Warning: Potential Security Risk Ahead

Further:

Firefox detected an issue and did not continue to zykrah.me. The website is either misconfigured or your computer clock is set to the wrong time.
It’s likely the website’s certificate is expired, which prevents Firefox from connecting securely. If you visit this site, attackers could try to steal information like your passwords, emails, or credit card details.

Cheers, I will have a look into it. Just has to do with the nginx reverse proxy.

Resolved. Thanks for bringing it up.


test_filter_for_freshest_data occasionally fails

After merging #2948 into dev some of us started getting sporadic failures for the Hypothesis based test_filter_for_freshest_data test
 pytest test/unit/io_managers_test.py::test_filter_for_freshest_data

On some machines (e.g. Zane's laptop) it failed every time. On others (like the CI on GitHub) it only fails rarely (see error output below).  It doesn't seem to be a material problem and @jdangerx is out this week, so for the moment it's been marked XFAIL, until he can take a look at it upon his return.
________________________ test_filter_for_freshest_data _________________________

    @hypothesis.given(example_schema.strategy(size=3))
>   def test_filter_for_freshest_data(df):

test/unit/io_managers_test.py:372:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

df =   entity_id       date utility_type              publication_time  int_factoid  float_factoid str_factoid
0           ...0
2           1970-01-01     electric 1970-01-01 00:00:00.000000000            0            0.0

    @hypothesis.given(example_schema.strategy(size=3))
    def test_filter_for_freshest_data(df):
        # XBRL context is the identifying metadata for reported values
        xbrl_context_cols = ["entity_id", "date", "utility_type"]
        filing_metadata_cols = ["publication_time", "filing_name"]
        primary_key = xbrl_context_cols + filing_metadata_cols
        deduped = FercXBRLSQLiteIOManager.filter_for_freshest_data(
            df, primary_key=primary_key
        )
        example_schema.validate(deduped)

        # every post-deduplication row exists in the original rows
        assert (deduped.merge(df, how="left", indicator=True)._merge != "left_only").all()
        # for every [entity_id, utility_type, date] - th"true"e is only one row
        assert (~deduped.duplicated(subset=xbrl_context_cols)).all()
        # for every *context* in the input there is a corresponding row in the output
        original_contexts = df.groupby(xbrl_context_cols, as_index=False).last()
        paired_by_context = original_contexts.merge(
            deduped,
            on=xbrl_context_cols,
            how="outer",
            suffixes=["_in", "_out"],
            indicator=True,
        ).set_index(xbrl_context_cols)
        hypothesis.note(f"Found these contexts in input data:\n{original_contexts}")
        hypothesis.note(f"The freshest data:\n{deduped}")
        hypothesis.note(f"Paired by context:\n{paired_by_context}")
>       assert (paired_by_context._merge == "both").all()
E       AssertionError: assert False
E        +  where False = <bound method Series.all of entity_id  date        utility_type\n           1970-01-01  electric        False\n                       electric        False\nName: _merge, dtype: bool>()
E        +    where <bound method Series.all of entity_id  date        utility_type\n           1970-01-01  electric        False\n                       electric        False\nName: _merge, dtype: bool> = entity_id  date        utility_type\n           1970-01-01  electric         left_only\n                       electric        right_only\nName: _merge, dtype: category\nCategories (3, object): ['left_only', 'right_only', 'both'] == 'both'.all
E        +      where entity_id  date        utility_type\n           1970-01-01  electric         left_only\n                       electric        right_only\nName: _merge, dtype: category\nCategories (3, object): ['left_only', 'right_only', 'both'] =                                   publication_time_in  int_factoid_in  float_factoid_in str_factoid_in          publication_time_out  int_factoid_out  float_factoid_out str_factoid_out      _merge\nentity_id date       utility_type                                                                                \n          1970-01-01 electric              1970-01-01             0.0               0.0                                          NaT              NaN                NaN             NaN   left_only\n                     electric                     NaT             NaN               NaN            NaN 1970-01-01 00:00:00.000000001              0.0                0.0                  right_only._merge
E       Falsifying example: test_filter_for_freshest_data(
E           df=
E                 entity_id       date utility_type              publication_time  int_factoid  float_factoid str_factoid
E               0           1970-01-01     electric 1970-01-01 00:00:00.000000000            0            0.0
E               1        0 1970-01-01     electric 1970-01-01 00:00:00.000000001            0            0.0
E               2           1970-01-01     electric 1970-01-01 00:00:00.000000000            0            0.0
E           ,
E       )
E       Found these contexts in input data:
E         entity_id       date utility_type publication_time  int_factoid  float_factoid str_factoid
E       0           1970-01-01     electric       1970-01-01            0            0.0
E       The freshest data:
E         entity_id       date utility_type              publication_time  int_factoid  float_factoid str_factoid
E       1        0 1970-01-01     electric 1970-01-01 00:00:00.000000001            0            0.0
E       Paired by context:
E                                         publication_time_in  int_factoid_in  float_factoid_in str_factoid_in          publication_time_out  int_factoid_out  float_factoid_out str_factoid_out      _merge
E       entity_id date       utility_type
E                 1970-01-01 electric              1970-01-01             0.0               0.0                                          NaT              NaN                NaN             NaN   left_only
E                            electric                     NaT             NaN               NaN            NaN 1970-01-01 00:00:00.000000001              0.0                0.0                  right_only
E       Explanation:
E           These lines were always and only run by failing examples:
E               /Users/zane/miniforge3/envs/pudl-dev/lib/python3.11/site-packages/_pytest/assertion/util.py:134
E               /Users/zane/miniforge3/envs/pudl-dev/lib/python3.11/site-packages/numpy/core/_dtype.py:336
E               /Users/zane/miniforge3/envs/pudl-dev/lib/python3.11/site-packages/pandas/core/array_algos/putmask.py:107
E               /Users/zane/miniforge3/envs/pudl-dev/lib/python3.11/site-packages/pandas/core/array_algos/putmask.py:112
E               /Users/zane/miniforge3/envs/pudl-dev/lib/python3.11/site-packages/pandas/core/array_algos/putmask.py:138
E               (and 66 more with settings.verbosity >= verbose)

test/unit/io_managers_test.py:398: AssertionError

OK, after some digging... it looks like somehow we're not actually identifying the correct "original contexts" in test, due to some very surprising df.groupby behavior...
You can see in the error message above that the 0 entity ID context is not being detected, only the "" entity ID:
E       Found these contexts in input data:
E         entity_id       date utility_type publication_time  int_factoid  float_factoid str_factoid
E       0           1970-01-01     electric       1970-01-01            0            0.0

And if you get a debugger in there (I used hypothesis.settings(print_blob=True, max_examples=10_000) to get a reproducible binary blob, then pasted that into @hypothesis.reproduce_failure("6.87.3", b"AXicY2BgYGBkAANGJBIF4JVnZIhiJKwKAA9lAGY=") to, well... reproduce the failure)
> df
  entity_id       date utility_type publication_time  int_factoid  float_factoid str_factoid
0           1970-01-01     electric       1970-01-01            0            0.0
1           1970-01-01     electric       1970-01-01            0            0.0
2        0 1970-01-01     electric       1970-01-01            0            0.0
> df.entity_id.value_counts()
entity_id
      2
0    1
Name: count, dtype: int64
> df.groupby("entity_id", dropna=False).groups.keys()
dict_keys([''])

This... isn't how I expect groupby to work - I expect it to show up with '' and '0' as possible keys.

Indeed! The null byte seems to break pandas string handling since sometimes it gets passed through to a C library: https://github.com/pandas-dev/pandas/issues/53720 changing this test to not allow \x00 in the entity ID.


OKTA-672843 include response for next() during paging operation

This change adds a parameter to api_response.next() which causes the response to be returned as the third tuple value during paging operations; this provides access to rate limit headers.

so, when u first call list_users, it's users, resp, err and the 2nd time it's users, err, resp ???
also, in the example below (from the readme), it should be resp, not response
from okta.client import Client as OktaClient
import asyncio

async def main():
    client = OktaClient()
    users, resp, err = await client.list_users()
    while True:
        for user in users:
            print(user.profile.login)
        if resp.has_next():
            users, err, response = await resp.next(True) # Specify True to receive the response object as the third part of the tuple for further analysis
        else:
            break

@gabrielsroka Yes, at least we don't break existing scripts for users but now we have the functionality for those who requested

There are no existing scripts that pass in True. Or you could just create a new function.
also, in the example (from the readme), should it be resp or response ?

also, since you're adding a new feature, maybe u could take another look at the 2-line PR i submitted last year, which @justinabrokwah-okta approved, but then got rolled back
https://github.com/okta/okta-sdk-python/pull/328

why is it includeResponse and not include_response?

in the example (from the readme), should it be resp or response ?

to answer my own q, it looks like u need 2 different variables: resp and resp2. so you can't reuse the get_headers(), either. if u change resp2 to resp, it doesn't work (i get a weird error, it looks like dicts aren't being converted to objects -- idk if this is a bug)
import okta.client
# import okta.api_response
import asyncio

async def main():
    # async with reuses the session, so it's much faster.
    async with okta.client.Client() as client:
        # Paginate users
        # resp: okta.api_response.OktaAPIResponse
        params = {'filter': 'profile.lastName eq "Doe"', 'limit': 1}
        users, resp, err = await client.list_users(params)
        print(resp.get_headers().get('x-rate-limit-remaining'))
        while True:
            for user in users:
                print(user.profile.login)
            if resp.has_next():
                users, err, resp2 = await resp.next(True)
                print(resp2.get_headers().get('x-rate-limit-remaining'))
            else: break

asyncio.run(main())


GH Runner going out of memory with frogbot 2.8.4 release

Describe the bug
Our GH runners are going out of memory with latest release 2.8.4. Rolling down the version back to 2.8.3 seems to solve the problem.
Current behavior
Enabling JFROG_CLI_LOG_LEVEL=DEBUG we found this Auth issue below
  19:35:45 [Debug] Sending HTTP GET request to: https://XXXXXXXXX.jfrog.io/artifactory/api/system/version
  19:35:45 [Info] Running Frogbot "scan-pull-request" command
  19:35:46 [Debug] Usage Report: Couldn't get Artifactory version. Error: failed while attempting to get Artifactory version:
  server response: 401
  {
    "errors": [
      {
        "status": 401,
        "message": "Token failed verification: audience"
      }
    ]
  }

After the above error, frogbot parses package.lock.json and goes in an infinite loop printing the below logs.
19:35:58 [Debug] buildXrayDependencyTree exceeded max tree depth
19:35:58 [Debug] buildXrayDependencyTree exceeded max tree depth
19:35:58 [Debug] buildXrayDependencyTree exceeded max tree depth
19:35:58 [Debug] buildXrayDependencyTree exceeded max tree depth
...........
...........

Reproduction steps
No response
Expected behavior
No response
JFrog Frogbot version
2.8.4
Package manager info
package.json
Git provider
GitHub
JFrog Frogbot configuration yaml file
No response
Operating system type and version
windows, ubuntu
JFrog Xray version
No response

@neatcoder -
Thank you for reporting this issue, and our apologies for the inconvenience caused by this!
We're currently investigating this issue.
We're suspecting that one of the following PRs caused this, but we're a bit puzzled by this, because version  2.8.3 also includes these changes:
https://github.com/jfrog/build-info-go/pull/151
https://github.com/jfrog/jfrog-cli-core/pull/771
We're working to resolve this as soon as possible, and we'll keeo you posted here.

@neatcoder -
If you're able to share with us your package.json, this may help us pinpoint the isseu, beucase we're unable to reproduce it currently.

@neatcoder,
We ween't able to reproduce the issue, but hopefully the above PR will resolve the issue.
We'll release it soon and let you know.

@neatcoder,
We've just released version 2.8.5 which includes https://github.com/jfrog/frogbot/pull/351.
We're looking forward to your feedback for it.

Confirming that the issue has been resolved. Thanks for the quick action, @eyalbe4


Refactor InstanceMethodHandler in agent

// Describe your PR here; eg. Fixes #issueNo

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

cc @yu199195 @HessTina-YuI

Codecov Report

Merging #2905 (c308008) into master (f932fcc) will decrease coverage by 0.48%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #2905      +/-   ##
============================================
- Coverage     60.01%   59.52%   -0.49%
+ Complexity     4462     4424      -38
============================================
  Files           692      693       +1
  Lines         19978    20012      +34
  Branches       1782     1784       +2
============================================
- Hits          11989    11913      -76
- Misses         6983     7091     +108
- Partials       1006     1008       +2

Impacted Files
Coverage Δ

...tebuddy/interceptor/InstanceMethodInterceptor.java
0.00% <0.00%> (ø)

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
68.75% <0.00%> (-31.25%)
:arrow_down:

...yu/sync/data/http/refresh/AbstractDataRefresh.java
70.00% <0.00%> (-13.34%)
:arrow_down:

...henyu/admin/service/impl/UpstreamCheckService.java
42.85% <0.00%> (-12.70%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
52.12% <0.00%> (-11.71%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

...apache/shenyu/admin/utils/ShenyuDictH2Trigger.java
63.63% <0.00%> (-9.10%)
:arrow_down:

...ache/shenyu/admin/utils/PluginHandleH2Trigger.java
63.63% <0.00%> (-9.10%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
75.55% <0.00%> (-8.15%)
:arrow_down:

.../apache/shenyu/admin/model/dto/BatchCommonDTO.java
50.00% <0.00%> (-7.15%)
:arrow_down:

... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb2d1e3...c308008. Read the comment docs.


📝[Docs]:new nav bar

Issue
The navbar style is looking old i made a new design of it
OLD ONE:

NEW ONE:
https://github.com/akshitagupta15june/PetMe/assets/168094736/de5798b1-6d35-401f-a1fc-97739b788754
hey @akshitagupta15june please assign this issue to me under GSSoC'2024

Go for it!

@akshitagupta15june please check it and merge


Add flag to allow for sending messages without running init

slacknotif run -i <script.py> [job_name] token=[API_TOKEN] channel=[CHANNEL_ID] success_message=[MSG] failure_message=[MSG]
slacknotif run -ic "<BASH_COMMANDS>" [job_name] token=[API_TOKEN] channel=[CHANNEL_ID] success_message=[MSG] failure_message=[MSG]
Should bypass the check for config file and load directly from the args
Can probably be done just by editing the parser setup

Hi, I've created a pull request (#3) that implements the requested feature. The PR adds support for sending Slack messages without requiring the init command by introducing --token and --channel arguments to the run command. These arguments allow users to bypass the configuration file and directly provide the necessary credentials via the command line.
Please feel free to review and let me know if there are any changes or improvements you'd like to see!

Thanks! Had to make some edits to get it working, but merged!


EmailSender plugin should support HTML emails

MessageBuilder can take an HTML type, so if we can add a flag to the API for type, we should be able to accept both Plain text and HTML emails in this API.

Did anything come of this? We need to send html in the body of an email using invokeEmailComposer?
Thanks,
Todd

This should be supported by the plugin - you can get it from this repo, or from the plugin registry using the cli: http://plugins.cordova.io/#/package/com.blackberry.community.emailsenderplugin


Position control landing and takeoff

This pull request suggests subtle but fundamental changes to the position controller and landing detector to achieve an intuitive all the time manual controlled takeoff and landing of a multicopter.
Summary:

hover throttle is used as feed forward term against constant gravitational force
(misusing the thrust integration control for this purpose caused problems)
land detector keeps vehicle landed until a mode dependent manual throttle input is exceeded
(this unlocks position control takeoff with spring loaded throttle sticks)
good refactor commit by @julianoes
thrust amount calculation in position control takes 3D projection onto the real vehicle thrust direction
(useful in general but added here especially because horizontal position control corrections while landing produced vertical thrust and didn't allow proper landing)

Foremost the last point still needs real world testing.

@PX4TestFlights This should include the standard mission test but most importantly takeoff and landing in position control mode.

Rebased on master
Changed the two thumb upped things in @julianoes review with history rewrite, force push
added a commit with a raised minimum throttle threshold
because of testing experience where landing was not detected

My findings during real world tests: It generally works and is a good first solution.
It's not perfect yet, foremost the landing detection needs some further analysis. Landing not detected can occur in some rare situations but at least no false positives.

2 Flights
http://logs.px4.io/plot_app?log=daa57100-6845-4dbb-9c1b-24e5c2e92195
http://logs.px4.io/plot_app?log=7491753f-d123-4fc6-9a1b-46a14ca4a0e7

@MaEtUgR Note the altitude controller oscillation when the vehicle was hovering. We might need to scale the current default gain. We should not require users to re-tune their system.

I see the landing not detected problem, I also had that in my tests. The land detection needs a guaranteed throttle ramp down when on the ground. This should be realized in a two stage manner. If certain conditions are met we assume we are landed and ramp down the motor thrusts such that we could still recover. And in a second stage when the thrusts are low and nothing changed we are landed for sure. Working on it now.
About the hover problem: I don't really get where I can see it. The PR should theoretically not change anything in steady state hovering but might potentially interfere there and if it does I have to find the cause.

@MaEtUgR I'll give this a test on my beloved Bebop.
I already tested in SITL and just have one comment:
I think hover thrust is applied instantaneously once takeoff is detected which I find too abrupt.
The rest seems to work as expected, will report back with a log.

I tested this pr in sitl with uneven ground, and in contrast to the current masters I was not able to reproduce the "not" detected landing. This is mainly due to the correct thrust projection onto the desired thrust axis. In addition, in simulation the hoverthrust is very close to the approximated 0.5 hover thrust and therefore landing works better than in reality where the two thrust values differ more. @MaEtUgR is it not possible to split this pr into two pr's? One for the projection onto the desired thrust vector which does improve landing and flight for quads, and another pr for the  takeoff with the hoverthrust as feedforward? And eventually we will have a third for better landing detection

Can you do a few trials with an incorrectly set thrust param and see if that reproduces it?

noticed this PR was still open, here are a couple flights taking off and landing in Position mode
http://logs.px4.io/plot_app?log=312af812-9dfb-4884-a442-6aa6e007cea7
http://logs.px4.io/plot_app?log=ad824ea3-489e-4bc5-8c66-e9a585179eb8

I tried to set different thrust hover values, but nothing made a difference. I looked at the landing detection, and all flags are correctly set when threshold is reached. In addition, the hysteresis is doing the correct thing  where states are only changed after 2seconds.
I also looked again at http://logs.px4.io/plot_app?log=daa57100-6845-4dbb-9c1b-24e5c2e92195, and I dont think that the actuator outputs / thrust values are the issue, but rather they are increasing due to setpoint changes in roll, pitch and yaw caused by position estimate drift:
. I also dont get wht gps altitude inreases as well.

Done in https://github.com/PX4/Firmware/pull/6327.


add sooperlooper

had to change the license from gpl to gpl1 due to travis complaining.
tried to squash my commits but failed, sorry!

Isn't it GPL2? https://github.com/essej/sooperlooper/blob/master/COPYING (I believe GPL1 is extremely rare).

tried to squash my commits again, and failed. again...  :(
this is turning into a bit of a mess, sorry.


Edite-README.md

کپی از #

#1710
در تاریخ چهارشنبه ۲۶ اوت ۲۰۲۰، ۱۷:۰۴ Mike McQuaid<EMAIL_ADDRESS>نوشت:

Closed #1710 https://github.com/github/explore/pull/1710.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/explore/pull/1710#event-3694576393, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQXF5X2NKN5UZN6DHLGIGIDSCT6NLANCNFSM4QLK6SBQ
.


need opentelemetry spans in every function

every function, especially those in computenode requesternode controller ipfs storage and verifier, need opentelemetry spans, many are missing. this makes the spans we see much less useful than they could be. add spans to all the code that gets touched in a typical execution

@enricorotundo are you working on this? i'm happy to pick it up if not.

go ahead  👍


C#: anonymous functions as arguments aren't indented properly

This is an issue with C# and possibly Java. When I try to define an anonymous function in an argument, the indentation doesn't work. I guess this is due to cindent having a specific behaviour for parameters on multiple lines.
An example of what I get using lambdas:
files.Aggregate(new List<string>(),
		(acc, s) =>
		{
		if (!acc.Contains(s))
		acc.Add(s);
		return acc;
		});

An example using delegates:
files.Aggregate(new List<string>(),
		delegate(List<string> acc, string s)
		{
		if (!acc.Contains(s))
		acc.Add(s);
		return acc;
		});

For Java works fine:
files.Aggregate(new List<string>(),
        (acc, s) =>
        {
            if (!acc.Contains(s))
                acc.Add(s);
            return acc;
        });


[DO NOT MERGE] analyzing prior regression

A prior PR silently broke the gmp port and necessitated a revert. The reason being that the gmp port calls vcpkg_find_acquire(CLANG) which downloads LLVM as a .7z.exe. The problem was that the asset was not a real 7z archive so when the tool tried to extract it -> 💥
The question is why didn't our CI catch this regression?
This PR purposely tries to break vcpkg_find_acquire(CLANG) to see if it triggers a build for gmp or any other port that calls vcpkg_find_acquire(CLANG)
If it doesn't build gmp it means there is a gap in our CI that we need to address.

The question is why didn't our CI catch this regression?

AFAICT it is expected to use clang-cl which may come with Visual Studio.
(And users reported problems when they didn't have the component installed.)
Testing is implmented in scripts/test_ports/vcpkg-find-acquire-program/portfile.cmake, but it will probably also accept tools from the path instead of doing download/extract. Might make sense to have a way to enforce the download, for testability.


chore(deps-dev): ADDON-58172 Bumping the dependencies version to fix vulnerabilities

:tada: This PR is included in version 1.14.1 :tada:
The release is available on:

v1.14.1
GitHub release

Your semantic-release bot :package::rocket:


I have a question about this code

Hi  @ReykCS  !
I have another question about your code. it is that "why did you evaluate only collision episode?".
It means that you did not evaluate arrived robot which is avoiding collision. you can see a reference code in a line.
[link(scenario_eval.py)]
can you explain why? Thank you :)

Thank you for your information!


Squahsfs driver

The initramfs is a utility that most modern-day operating systems use to store vital data before we have drivers to read from the disk. We currently have the initramfs loaded, and the beginning of a SquashFS driver, but this issue is intended to track those changed from here forward.

this commit completes this issue 7f216fdfdd7e9948410011ffe819c837d8160da1


Error while fetching server API version

I keep getting this error :
--> 221     raise DockerException(
    222         f'Error while fetching server API version: {e}'
    223     )

DockerException: Error while fetching server API version: ('Connection aborted.', FileNotFoundError(2, 'No such file or directory'))

But I only kept gpt4 api key , don't have azure, could that be a problem?
Thanks

Hi @legaltextai , thanks for reaching out. Do you have docker installed?

the docker is fixed and running :-) now, it 's stuck after this command (the arxiv paper exampe):
Please run this Python script to extract the title and abstract of the paper. Based on the content, I will then suggest who should read this news.

--------------------------------------------------------------------------------

>>>>>>>> USING AUTO REPLY...

>>>>>>>> EXECUTING CODE BLOCK 0 (inferred language is python)...
Pulling image python:3-alpine

This image doesn't allow pip install. If you need to perform package install, please set use_docker="python:3"

Thank you so much. It worked!

use_docker="python:3"

Hi! How do we set this? Should it be in the main python file?

It's in code_execution_config

Is this valid? (doesn’t run for me)

It's in code_execution_config

is this valid? (doesn’t work for me)
code_execution_config = (”work_dir”:”web”, use_docker = ”python:3”,),
When I initially go the error it said
code_execution_config = (”work_dir”:”web”, ”docker”:”python:3”,)

I just make my first try on autogen with panel UI and it displays the same error. My request is very simple: Ask the system to create an empty txt file on d drive. After I read the comment, I don't understand how the whole system works. Is it use docker to create an docker image which runs python3 to create an empty file for me?

Hi @fenixlam , could you please open a new issue, and paste more details of your settings, code and results? Thanks.


Fully qualify SC apiserver DNS name

Fixes https://github.com/jim-minter/azure-helm/issues/17
@jim-minter

NB, the same work is applicable for at least all references to master-etcd as well.

@amanohar we discussed adding a side-channel struct that would have the hcp namespace available at the point where the helm generation took place, but it turns out that doesn't help us because it is after the point where we want to have finished generating certificates :(  Can we get that information earlier?

Interesting. Let's continue the discussion in https://github.com/jim-minter/azure-helm/issues/17, no reason to keep this open for now.


Memory management issues

Hi everyone,
After update to the latest stable release 1.1.54127 we have got an issues with ClickHouse.
The point is that ClickHouse server started to eat all available RAM until it will be full then OOM come and kill it.
The behavior  change could be clearly seen on Munin memory graph:

I tried to make lower values to uncompressed_cache_size and mark_cache_size parameters but this didn't help, below our current ClickHouse config:
config.txt
Our server configuration:
RAM: 96G
OS: Centos 6.8
ClickHouse server running using Docker 1.12.2, inside Ubuntu 14.04.5 container.
What could be the reason of the issues?
Please let me know if you will need any additional information.

Please show graphs of following metrics:
ClickHouse.Metrics.MemoryTracking
ClickHouse.Metrics.MemoryTrackingInBackgroundProcessingPool
ClickHouse.Metrics.Merge

If I understood you right these metrics available from system.metrics table:
│ Merge                                    │         0
│ MemoryTracking                           │     21581646
│ MemoryTrackingInBackgroundProcessingPool │ -23638864

Do these values grow with growing of total memory usage?
Also, please provide result of
SELECT * FROM system.merges
query at some time after server startup.
What kind of tables do you use?
If you also provide structure of corresponding tables, it will help.

Do these values grow with growing of total memory usage?
MemoryTracking metric could be lower or higher,  MemoryTrackingInBackgroundProcessingPool is growing (or lowering?), now it has value -253653632. BTW what - symbol mean for this value?

Also, please provide result of
SELECT * FROM system.merges
The result of the query most time is empty, after few tries I can get some non empty result:

┌─database─┬─table──┬─────elapsed─┬───────────progress─┬─num_parts─┬─result_part_name──────────────────────┬─total_size_bytes_compressed─┬─total_size_marks─┬─bytes_read_uncompressed─┬─rows_read─┬─bytes_written_uncompressed─┬─rows_written─┬─columns_written─┐
│ prod     │ ctr_kr │ 0.035895109 │    0.7335205078125 │         2 │ 20170105_20170105_1613740_1616758_845 │                      759257 │               26 │                 2968446 │    156234 │                    2801664 │       147456 │               0 │
│ prod     │ ctr_nl │ 0.029025295 │ 0.3530203683035714 │         2 │ 20170105_20170105_1940820_1942040_182 │                     1004489 │               35 │                 1923142 │    101218 │                    1712128 │        90112 │               0 │
└──────────┴────────┴─────────────┴────────────────────┴───────────┴───────────────────────────────────────┴─────────────────────────────┴──────────────────┴─────────────────────────┴───────────┴────────────────────────────┴──────────────┴─────────────────┘

What kind of tables do you use?
We are using CollapsingMergeTree for most tables an Merge for largest one.

If you also provide structure of corresponding tables, it will help.
Tables structure available by link:
prod.sql.txt

BTW what - symbol mean for this value?

It means, that memory was freed in context of background job (like eviction of old data from cache), but was allocated in other context. Usually, this is fine.
I had hypothesis, that memory usage is due to merges, but your data shows that this is not true.

I still cannot guess, why this issue happens.
Try to isolate possible dependencies. For example, try to enable/disable some types of queries.
Maybe, you could temporary disable queries from Merge table and leave other queries, and see what happens.

Unfortunately we can't disable queries to Merge table since the bug happened on our prod environment.
Instead we had tried temporary switch off  all write activity to ClickHouse and got the similar picture for RAM usage:

To keep environment stable we have switched back to previous ClickHouse version.
As you can see on screenshot everything was fine until we have started again version 54112.

Please try to update to 54135.

After the week of testing I can confirm that issue has gone.
What was the reason, could you make a comment?
Thanks.

The reason was incorrect implementation of move-assignment in Field.
The issue was presented only in cases when column of String or Array type was used in primary key.

1.Create tablea(memory).
2.Create tableb(mergetree).  Primary key is column with type Int.
3. Load csv into the memory.
4.Check clickhouse-server cached 4G memory.
5.Exe SQL: Insert into tableb select * from tablea;
6.Exe SQL: Drop table tablea;
7.Check clickhouse-server still cache 4G+ memory.
Why?


Wolfram alpha

LONG:wolfram alpha API integration. I have an AppID: XJA93W-225U2U4XKJ

Shut down that api key.
This is not being implemented.


Small redesign of the main page

As you can read in this issue @alireza-ahmadi began to redesign parts of the Hugo website, as he teased in a screencast. But he had limited time  to complete the redesign in the past. Therefore, I gave it a try and began to recreate the header and navigation as shown in the video. The current state of my work can be seen here. It should get very close to the original.
Since my CSS experience is limited I would encourage one someone to check the browser compatibility. My developement environment is Ubuntu Linux 15.04 and Chrome 43 / Firefox 40.
If you're are interested I would create a PR.
Currently I don't implemented a responsive menu for the navigation. @alireza-ahmadi  - did you have a specific idea for this, something like an off-canvas menu with a hamburger icon?

I haven't thought about how should navigation look on small screens, Maybe, as you say, adding a hamburger menu is the solution of this problem.
@digitalcraftsman I have started implementing new idea for Hugo's home page, Please take a look at my sample image and videos and code. For the next two weeks, I am completely free so If you (and other members of Hugo team) prefer new design, I can complete implementation of it and if you prefer the old design, I can add responsive navigation to your work.

@alireza-ahmadi that looks very, very good. As too the "zoom variants", I liked the second best (light color version).

@alireza-ahmadi that are great news. Since now we've three design prototypes. Personally I like the original one and the second version (light color version) as @bep. My implementation of your original design can be found here.
Furthermore, we should talk a better way to communicate than this issue. The implementation of details could cause long discussions and would mess up this issue. Otherwise the discussions shouldn't be closed for the public since everybody should be able to track the changes, give feedback or even to participate.
Since the redesign breaks out in a new direction in comparison the current 'design language' of Hugo we could enhance a redesign to the docs too. But this is maybe out of scope for now and I don't know how long the redesign of the frontpage will take (which defenitely should be in the spotlight for now).
Finally, it would be interesting what @spf13 thinks about this topic.

Well, I will complete the implementation of the home page and until that time we can discuss how can we redesign all pages of the website.

This sounds more or less like creating a whole new theme for the Hugo site(s). The current setup uses Bootstrap and your implemenation are build with the more minimalistic Skeleton framework. Therefore, do we switch entirely?

@digitalcraftsman & @alireza-ahmadi I absolutely love the new designs you guys are coming up with. I really like the cleaner look of @digitalcraftsman's homepage. I love the updated effects and layout @alireza-ahmadi has for the homepage.
I agree a completely new design for the docs should be a longer term goal. I think we should focus on the homepage first and get that out the door.
We definitely should a responsive design. A good amount of visitors are from mobile.
I agree hamburger works well for this.

My screencast just showed the implementation of one of @alireza-ahmadi's earlier designs. Furthermore it seems to be the case, that we will use some sort of taskrunner like Gulp or Grunt to minify, concetenate,  ....files or preprocess Sass or Less code. This would require the installation of node.js and the taskrunner as dependencies in order to build and deploy the site.
This would give us benefits us with more flexible stylesheets and smaller (minified) assets, as examples. The disaddvantage would be, that users who want to access the docs offline would need the dependencies if they want to read the docs.
Another great aspect would be the use of amber or ace templates if we've finished the design.

I'm fine with using a taskrunner to prepare the site when working on it. It shouldn't be a requirement to just run hugo server -s docs on it and be able to view the docs.
I've been looking into adding support for Sass directly into Hugo, but not sure if it's a good idea or not yet.

The integration of Sass would be part of the long discussion of wether and how plugins should be integrated. But this would be off topic.
If it shouldn't be a requirement, we would need to have a pre-built version of the docs in the repo, which wouldn't be pragmatic. Furthermore you can't now further changes of dependencies that are required to build the docs.

@digitalcraftsman using skeleton as a framework is temporarily and we should use a more popular framework like Bootstrap or Foundation in the final version.
@spf13 I can apply the the current design. And we can also improve fix minor design issues in the current version of Hugo's website, Then we can plan for a complete overhaul of homepage and docs of hugo.
@digitalcraftsman as the Hugo's website(homepage+docs) is not a complex web application, while using task runner is a plus but it's not necessary, So we can remove it.

@alireza-ahmadi you showed in a screencast the current website redesigned. Do you use some sort of sketch from Photoshop or do you code right away?
Because this is a redesign, will we use the old codebase or do we make a complete rewrite?

@digitalcraftsman It's was a super simple prototype and the code had not ability for development. Currently, we can apply minor improvements on the current code base and plan for a complete rewrite in the future.

#1725 is related to the thoughts about a redesign.

This issue has been automatically marked as stale because it has not been commented on for at least four months.
The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still valuable, please open a proposal at https://discuss.gohugo.io/.
This issue will automatically be closed in four months if no further activity occurs. Thank you for all your contributions.

Note/Update: This issue is marked as stale, and I may have said something earlier about "opening a thread on the discussion forum". Please don't.
If this is a bug and you can still reproduce this error on the latest release or the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.

@alireza-ahmadi  thanks for the your initial idea to redesign the homepage of Hugo. This issue is stale since a while and a few others pushed this idea further to a redesign that is likely to be deployed soon. Those are namely @rdwatters for the editorial part and @budparr who's finalizing the design.
Cheers,
Digitalcraftsman


[WIP] Test CRCRLF is not in popen's output

Consider this PR only for demonstration a bug. See #1231.


Quickwin transfer code to user service

The ResetPasswordController now does not handle that much business logic anymore. The UserService now also checks if the token exists or is expired.

 Transfer code from ResetPasswordController to UserService.


Updating the api code in GetTweetReplies

The endpoint in GetTweetReplies method is GET  https://twitter.com/i/api/graphql/ldqoq5MmFHN1FhMGvzC9Jg/TweetDetail. This returns 404 to me. Upon inspecting in brower the request was made with a different code (in place of ldqoq5MmFHN1FhMGvzC9Jg). Do we know what decides the value of this code? Or at least I think we should make it configurable. I can do this...but I am new to golang and will take some time catching up.

@MrNomad123 checked right now and endpoint works, this hash is id for specific revision of endpoint so if you change this hash to newer/older the response may be diffrently structured and wouldn't be parsed correctly. some endpoint hashes in this codebase is 2-3 years old and works perfectly twitter don't expire them
can you provide tweet url that you trying to fetch?

This is the tweet id I am trying to fetch:<PHONE_NUMBER>054182414

@MrNomad123 works for me. did you set your auth credentials before making request?

Yeah...works fine. Not sure what the issue was. Anyways, thanks for the help!


Feats for ESXi Manage

这个 PR 实现什么功能/修复什么问题:

add 'ip-list' for esxicli
虚拟机的网络推荐不再是一整个C段网络，而是存在的连续IP组成的网段，
这样更准确，用户可以根据自己的需要，合并或者扩充建议的网段
使用 DefaultNetworkGatewayAddressEsxi 来配置子网默认的网关地址。
filter esxi ip by CIDR
support fake template vm via regex filter
add vlanId for suggested network

[x] 功能、bugfix描述
[x] 冒烟测试

是否需要 backport 到之前的 release 分支:

release/3.4

/area region esxiagent
/cc @swordqiu @zexi

Codecov Report

Merging #8126 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #8126      +/-   ##
=========================================
- Coverage    6.21%   6.18%   -0.04%
=========================================
  Files         759     150     -609
  Lines      117256   20950   -96306
=========================================
- Hits         7289    1296    -5993
+ Misses     109308   19505   -89803
+ Partials      659     149     -510

Flag
Coverage Δ

#aFlag
6.18% <ø> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/multicloud/ucloud/utils.go

pkg/mcclient/options/k8s/pvc.go

pkg/appsrv/handlerinfo.go

pkg/mcclient/options/k8s/service.go

pkg/baremetal/tasks/create.go

pkg/compute/models/loadbalancerawscachedlbbg.go

pkg/compute/models/loadbalancerresource.go

pkg/compute/models/loadbalancerbackendgroups.go

pkg/mcclient/options/base.go

pkg/compute/guestdrivers/google.go

... and 591 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e901bd...bf2cbd5. Read the comment docs.

/lgtm

/lgtm

/approve


Aspire vs Steeltoe

The Aspire Project seems remarkably related to Steeltoe (https://steeltoe.io/)
Given that Steeltoe is mature with over 50 Million downloads, I'm curious if this project was ever considered and why Microsoft decided to rather create a new project.
Are there specific design goals / directions that differ from Steeltoe?
We developed an in-house microservice chassis about 8 years ago, when .Net Core 1 launched. We were just about to rewrite our implementation based on top of Steeltoe when we saw the Aspire announcement.
We now have to decide if we stick to Steeltoe, or whether we should use Aspire (and possibly wait longer until GA).
I think it would be hugely beneficial to the overall developer community to have some clarity from Microsoft's point of view regarding the differences between Aspire and Steeltoe.

@davidfowl

Several of us were involved very early on when Steeltoe was created and the philosophy at the time was about making sure that shops with both Spring and .NET developers could share assets (config server, and eureka) and concepts from spring as a baseline. Spring lineage bleeds throughout the Steeltoe implementation as a result.
Some similarities and differences:

Orchestration - Steeltoe does not have this. It should be possible to use Steeltoe with the aspire app model.
Components - https://docs.steeltoe.io/api/v3/connectors/ - These are extremely similar. Aspire went a bit further with what get wired up by default.
Service Discovery - https://docs.steeltoe.io/api/v3/discovery/index.html - Their service discovery implementation relies on the eureka server by default (again a spring ism).
Dashboard - Steeltoe works with the https://docs.steeltoe.io/api/v3/management/springbootadmin.html dashboard if you configure the actuator endpoints.

I think their choices made sense for the audience they were going after, but it's not the way we wanted to build a .NET first, cloud native story. I would love to work with the Steeltoe team again to figure out how it evolves in a world where aspire exists, or if it makes sense to collaborate on the remaining gaps.
The aspire local orchestration developer experience is the thing that is unambiguously unique between the 2 projects, and should in theory be decoupled enough to work with Steeltoe.

@davidfowl Chris Sterling, PM of Steeltoe, has already connected with Glenn about collaborating :-)

@davidfowl (and others here), the Steeltoe team has made significant progress on getting commitment to engage with the .NET Aspire OSS project. Here is an issue that announces this commitment and also requesting feedback from the existing Steeltoe community:
https://github.com/SteeltoeOSS/Steeltoe/issues/1244
We will be engaging more with .NET Aspire maintainers in the near future so stay tuned for more details on this collaboration.


Missing _signal module on WASI

Summary
If you try to import platform you get the following error:
>>>>> import platform
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "platform", line 119, in <module>
  File "subprocess", line 49, in <module>
  File "signal", line 1, in <module>
ModuleNotFoundError: No module named '_signal'

It seems that the _signal module is missing. Any idea what this could be or how we could resolve this?

What is your platform? I cannot reproduce on macOS (Ventura, M1) or Linux (Arch Linux, x86_64).
Welcome to the magnificent Rust Python 0.2.0 interpreter 😱 🖖
>>>>> import platform
>>>>> exit()

Oh sorry, I should have said it's when you compile to WASI.

CC @youknowone

#4964 is similar issue.
I believe _signal is not mendatory for platform. Implementing _signal will be the long term correct goal, but patching python library will also make it working.

Oh, I was not talking about about user-side, but about updating Lib/platform.py from RustPython project to not to refer _signal.
Another point. I think WASI anyway will not support _signal, right? Then maybe a fake _signal module with empty functions like gc will be enough.
I also found platform is updated in python 3.11 not to require _signal when importing. #5060
But still there are encodings problem, so it doesn't work.

oh, it was my mistake. platform will be fixed by #5060

It depends what that signal module does but WASI has a syscall to send signals to the host process, it's proc_raise.

But I think as long as it's mostly empty that's fine or at least if we add what we can support.

Can confirm that importing platform now works 👍 Where would we go to implement things like platform.release()?


Cannot change the value of "focusOnSelect" if it's set initially.

When the value of "focusOnSelect" is set to true (or false) initially and is changed in the responsive breakpoint settings, the change never occurs. Check jsfiddle for demo.
====================================================================
[  http://jsfiddle.net/fmo50w7n/1373/  ]
====================================================================
Steps to reproduce the problem

InitiallySet the "focusOnSelect" option to true.
Set it to false inside the settings of a responsive breakpoint.
Resize the window - the option is always set to true and never re-set to false.

====================================================================
What is the expected behaviour?
The "focusOnSelect" option should be re-settable from true to false (or vice versa) inside a responsive breakpoint.
====================================================================
What is observed behaviour?
The "focusOnSelect" option is not re-settable from true to false inside (or vice versa) a responsive breakpoint.
====================================================================
More Details
I'm not sure if this is a feature that many people would use, but it's applicable in my case. I know how to fix this. I will do that and submit a PR.

I'm ready to create a PR for this.


Fix server uri storage to support having no workspace

For #4037
The JupyterServerUriStorage class would throw an exception while trying to save the 'serverType' setting if the user doesn't have a workspace open. This makes the enter key actually not close the quick pick dialog.

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[x] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Codecov Report

Merging #4291 (dc7c53d) into main (365fab1) will increase coverage by 3%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##            main   #4291     +/-   ##
=======================================
+ Coverage     70%     74%     +3%
=======================================
  Files        384     389      +5
  Lines      25206   25392    +186
  Branches    3604    3632     +28
=======================================
+ Hits       17880   18949   +1069
+ Misses      5929    4956    -973
- Partials    1397    1487     +90

Impacted Files
Coverage Δ

src/client/datascience/jupyter/serverUriStorage.ts
81% <100%> (+1%)
:arrow_up:

...t/common/application/webviewPanels/webviewPanel.ts
10% <0%> (-58%)
:arrow_down:

src/client/common/application/webviews/webview.ts
13% <0%> (-53%)
:arrow_down:

.../application/webviewPanels/webviewPanelProvider.ts
43% <0%> (-50%)
:arrow_down:

...nt/datascience/interactive-common/debugListener.ts
34% <0%> (-40%)
:arrow_down:

...datascience/interactive-common/showPlotListener.ts
33% <0%> (-39%)
:arrow_down:

...c/client/common/application/customEditorService.ts
25% <0%> (-33%)
:arrow_down:

...c/client/common/application/invalidCustomEditor.ts
8% <0%> (-23%)
:arrow_down:

src/client/datascience/dataScienceSurveyBanner.ts
69% <0%> (-20%)
:arrow_down:

...ent/datascience/interactive-common/linkProvider.ts
16% <0%> (-19%)
:arrow_down:

... and 96 more

Codecov Report

Merging #4291 (dc7c53d) into main (365fab1) will increase coverage by 3%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##            main   #4291     +/-   ##
=======================================
+ Coverage     70%     74%     +3%
=======================================
  Files        384     389      +5
  Lines      25206   25392    +186
  Branches    3604    3632     +28
=======================================
+ Hits       17880   18949   +1069
+ Misses      5929    4956    -973
- Partials    1397    1487     +90

Impacted Files
Coverage Δ

src/client/datascience/jupyter/serverUriStorage.ts
81% <100%> (+1%)
:arrow_up:

...t/common/application/webviewPanels/webviewPanel.ts
10% <0%> (-58%)
:arrow_down:

src/client/common/application/webviews/webview.ts
13% <0%> (-53%)
:arrow_down:

.../application/webviewPanels/webviewPanelProvider.ts
43% <0%> (-50%)
:arrow_down:

...nt/datascience/interactive-common/debugListener.ts
34% <0%> (-40%)
:arrow_down:

...datascience/interactive-common/showPlotListener.ts
33% <0%> (-39%)
:arrow_down:

...c/client/common/application/customEditorService.ts
25% <0%> (-33%)
:arrow_down:

...c/client/common/application/invalidCustomEditor.ts
8% <0%> (-23%)
:arrow_down:

src/client/datascience/dataScienceSurveyBanner.ts
69% <0%> (-20%)
:arrow_down:

...ent/datascience/interactive-common/linkProvider.ts
16% <0%> (-19%)
:arrow_down:

... and 96 more


Adding a User Role

As a Product Owner
So that I can encourage ubiquitous language and understanding across my teams
I want to define key User Roles used in my Product

Resolved in commit https://github.com/gust/feature-creature/commit/8982eb8a019271d2188fbe72e536205e7f380472


Fixed #27690 -- Removed sleep before test db drop

Removed the call to time.sleep before dropping the test db

buildbot, test on oracle.


Audio files cut off?

Some audio files appear to have been cut off. For example: accept/64926.ogg in the tetiana dataset (original text is "Уве́чері при ля́мпі ми сиді́ли в кімна́ті вчи́теля і розмовля́ли.").
I'm working on a tool to flag files that might not match the text by assuming speakers maintain a fairly consistent speaking rate. I'll post more here when I get results, but was curious if anyone else had seen this.

Hi, it will be awesome, @synesthesiam !
Thanks.

It was done faster than I expected! Here are the files flagged for each speaker: ukrainian-tts_filtered.json.zip
Here is the way this tool works (source code here):

Punctuation is removed from text
Silence is removed from audio (using silero vad)
The speaking rate is calculated as len(text) / duration_sec for each audio file (characters per second)
Outliers are found in a similar manner to this article -- basically any file with a speaking rate far above/below the average

Based on the tool, there were:

563/6962 files flagged for lada
725/6977 files flagged for mykyta
230/5417 files flagged for tetiana

Should still be enough data to train with, but it might be good for humans to review those files :)

Thank you, @synesthesiam!

I will look into the files later


[otbn] style guide/secure coding guidelines for otbn assembly

For the sake of consistency across OTBN assembly files and as much as possible across OTBN and RISC-V assembly we should come up with a style guide for OTBN assembly.
As a starting point this can just be a copy of the RISC-V style guide.
Some initial thoughts:
Comments

Only C style comments (due to toolchain restrictions)

Letter case

mnemonics: lower case
registers: lower case
flags and flag groups: upper case
half word identifiers in multiplication instructions: upper case

Indentation:

Same as with RISC-V guidance for directives
The RISC-V guide does not mandate any indentation for operands. We should come up with some for OTBN, since we have more often coherent blocks:

We should include a proposal on arranging sequences of multiplication instructions
We could come up with something for loops (loop kernel being indented) or not, if this is a no-go
In multi-limb adds and subs registers should be right-aligned across all lines forming a block

Pseudo instructions: (see also #2967)

use ret, li and nop whenever possible
prefer loop/loopi pseudo instructions with end labels over the ones with immediate loop length (once this is available)
...

Subroutine and label naming

Is there sth. here?

ABI names for register

If we come up with sth. here we should enforce the usage. Special purpose is only x0 and x1 at the moment.

Named CSR and WSR

Currently we don't support named WSRs and CSRs in the assembly. If we support this, we should encourage it to be used

Subroutine doxygen header

Like in the RISC-V guide every input and output parameter shall be listed as a doxygen style @param[in]/@param[out] statements
Ideally usage of temporary registers should be described but at least every clobbered registers shall be named
All clobbered Flag Groups shall be named

Constants in the .data section (see also #3604 for some context)

Prefer the .word directive over .quad

There are other aspects where I am not sure if the style guide is the right place for such information:

How to write constant time code, avoid data dependent branching, use BN.SEL whenever possible
Use of the ecall instruction and wrappers such that subroutines can be called internally and externally

Further thoughts?

Only C style comments (due to toolchain restrictions)

If this is really annoying, we could always call cpp in otbn-as: I didn't so far, because I wanted to make something that looked like the binutils as, but I guess that a call to cpp wouldn't change any files that were already valid. If we do this, it will actually make the work of otbn-as easier (since it no longer needs to care about parsing comments).
About indentation: I agree. I rather like tabulating blocks of operands. I think I'd avoid being too prescriptive, so would suggest something like "tabulate operands in blocks that look sensible" or similar.

Currently we don't support named WSRs and CSRs in the assembly.

Good point. We should! I'll open an issue to track that.

I would prefer the assembly style guide was not forked into a separate style guide just for OTBN. What about making it clear that https://docs.opentitan.org/doc/rm/asm_coding_style/ is a general style guide, with RISC-V- and OTBN-specific sections? (Like we have C and C++ specific sections in the C/C++ style guide).
Comments:
I don't really have an issue if we require .S files to all have /* */ comments, we can easily fix that in existing assembly, if it makes everything easier for the OTBN tooling. This is probably what we should have done anyway, but we failed to notice that the .S files in meson were being run through gcc, which preprocesses them first. (Aside: do we want to preprocess the OTBN files? if not, they should be using .s)
Operand Blocks
I have no issue here requesting indenting operands, it makes sense given loop is both an instruction, and something like a label. Yes we can suggest operands are all aligned together, or at the very least allow and heavily suggest doing so.

Re pseudo instructions: I think, we should not be too strict in enforcing their usage. There might be more obvious reasons to not use them, compared to standard RISC-V assembly. E.g. if you want to have two subroutines having a similar timing and power profile, but loading two different constants. If the number of machine instructions depends on the loaded value, this can be critical and an assembly author might choose to directly use addi instead of li to make this explicit.
We also need to think about what should be the guidance to handle pseudo instructions in loop bodies (see #3607).

Two more points in this discussion:
We do have currently programmer's guidance in a user guide at https://docs.opentitan.org/doc/ug/otbn_sw/ and in the OTBN reference docs at https://docs.opentitan.org/hw/ip/otbn/doc/index.html#writing-otbn-applications.
In addition to a pure style guide we also need a programmers guide which discusses practical conventions of programming routines for OTBN (e.g. how to best pass arguments between Ibex and OTBN), and a secure programmers guide, which discusses things like clearing of intermediate secrets at the end of an operation.
With probably a fair amount of overlap between purely cosmetic style, programmers guidance for functionality, and guidance for security, it might make sense to have all that content in a single document.

Another point for the coding guidelines: Prefer BN.MOV over BN.ADDI xd, xs, 0 to maintain integrity protection when copying data between registers (see also https://github.com/lowRISC/opentitan/issues/6482).