Incorrect newline added

In 1.16.3, the following would rule would not change the code, but now it does (1.16-dev):
[
    'blank_line_before_statement' => ['statements' => ['return']]
]

Input:
<?php

function foo()
{
    switch ($foo) {
        case 1:
            return 'bar';
        case 2: // comment
            return 'baz';
        case 3:
            return 'test';
        default:
            return 'foo';
    }
}

Diff:
@@ -6,6 +6,7 @@ function foo()
         case 1:
             return 'bar';
         case 2: // comment
+
             return 'baz';
         case 3:
             return 'test';

PHP 7.4.6, PHP-CS-Fixer c0f3b0a44f4c465ef15af89378e02b9cd94d885e.

This seems to have been caused by https://github.com/FriendsOfPHP/PHP-CS-Fixer/commit/77234a0ed6ca5414e567b98db312fcc52837d435#diff-7512cf0f0abcd38c0e402b20788674fd.

Thanks for reporting!
I'm 98% sure I did this on 2.15 so I send a PR to fix it here

🚀

fixed in https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/4999


Inconsistent return value when two imports differ only by case

The isort check passes inconsistently if:

order_by_type config is disabled
two imports from the same package differ only by their case

Consider the following example:
.isort.cfg:
[settings]
order_by_type=false

my_file.py:
from sqlalchemy.dialects.postgresql import ARRAY, array
...

Shell script for running isort:
#!/bin/bash

for i in 1 2 3 4 5
do
   echo "isort check no. $i:"
   isort --check-only my_file.py
done

returns
isort check no. 1:
ERROR: /Users/vesauimonen/Documents/isort-bug/my_file.py Imports are incorrectly sorted.
isort check no. 2:
isort check no. 3:
ERROR: /Users/vesauimonen/Documents/isort-bug/my_file.py Imports are incorrectly sorted.
isort check no. 4:
ERROR: /Users/vesauimonen/Documents/isort-bug/my_file.py Imports are incorrectly sorted.
isort check no. 5:

I'm using isort version 3.9.4.

Hi @vesauimonen,
I'm unable to reproduce this issue after running tests over 100 times. I went ahead and added a test case to the suite to try and reproduce it - but so far it consistently works. If you can provide more details / a failing test let me know and I will reopen this issue.
Thanks!
~Timothy

Hi @vesauimonen,
After adding the test to the test_suite and merging in I can see the issue reproduced within travis occasionally will reopen and think of a fix
Thanks!
~Timothy

This has now been fixed in develop:
https://github.com/timothycrosley/isort/pull/245/files
And will be included in the next release.
Thanks!
~Timothy

This is now officially fixed in 3.9.6
Thanks again!
~Timothy


Package request: Phidget

Project description
Phidgets are building-blocks for sensing and control using a computer, tablet, or phone. Phidgets enable your software application to interact with the physical world.
Metadata

homepage URL: https://www.phidgets.com/
source URL:

https://www.phidgets.com/docs/OS_-_macOS
https://www.phidgets.com/docs/OS_-_Linux

license: LGPL-3.0-or-later and BSD-2-Clause and BSD-3-Clause
platforms: Linux, Darwin

Add a :+1: reaction to issues you find important.

Hi.
Could you try https://github.com/NixOS/nixpkgs/pull/337398 this to see if it works for you?
It only contains the libphidget22 and libphidget22extra

Thank you I didn't see this!

Thank you I didn't see this!

Let's keep the issue open until it's merged.
Let me know if you could test it and whether it worked or not.


fix: move graphToken into body, fix http call header too large

Description
Someone's arm token was too large, and we pass both arm token and graph token in provision call header, so that the http call will throw 431 header fields are too large error.
Reason: The HTTP protocol parser that Node uses appears to be hard-coded with a maximum header size.
Solution:

set --max-http-header-size in server package.json.      But it have no effect.
move graph token from header into body.                   I take this one in this fix.
change a http parse, like used http-parser-js instead.

Task Item
close #5335
Screenshots

Coverage decreased (-0.009%) to 54.496% when pulling 567d0d881d769b5e3707fe4be57722f5f9b0b7dc on wenyluo/fixHeader into dc4bb80d9ee6a92634a5d227d58d864cb12de05a on main.


New Version?

In your readme.md you make reference to a buildRootScope(). However, if someone uses your latest published version of v0.16 this will not be available as this was added about 28 days ago. https://github.com/square/mortar/blob/master/mortar/src/main/java/mortar/MortarScope.java#L46
I understand that you put a disclosure on your readme as well that this is in rapid development, and you can't promise breaking changes won't happen. However, it seems confusing to a new user to not be able to implement the example of the readme with the latest version that is published to public gradle / maven repositories.
I understand that this might not be a top priority, but I just wanted to bring it to your attention.

This is not the version published to the repo, it's the tip of master. See
https://github.com/square/mortar/tree/0a3b52e972003748da1a7bd54287083390ffafcf

This caught me too. Luckily there was a post for this :)

Btw, compile 'com.squareup.mortar:mortar:0.17-SNAPSHOT' does not work

On 1.6 the doc sample does this:
Mortar.getMortarScope(this);
the 1.6 lib does not support that method.
:(

0.17 has been released.


Feature Request: Enhance Curation Card with Comprehensive Functionalities

Summary
Improve the Curation Card in the Gene Curator application to include prefilling of fields with data from both the pre-curation form and gene card, introduce a curation score calculation, add dropdown selectors for MONDO and OMIM diseases, PubMed (PMID) and GeneReviews selectors, and implement validation for input fields to adhere to specified cutoffs.
Description
The current Curation Form can be significantly enhanced for a more seamless and robust curation experience. The proposed updates involve prefilling form fields with data from the pre-curation form and gene card, calculating a curation score, providing dropdown selectors for disease databases like MONDO and OMIM, integrating selectors for PubMed references and GeneReviews articles, and validating inputs against defined cutoffs to ensure data accuracy and consistency.
Acceptance Criteria

[ ] Autofill curation card fields with relevant data from pre-curation and gene card.
[ ] Develop and integrate a scoring system for the curation process.
[ ] Include dropdown menus for selecting MONDO and OMIM diseases.
[ ] Add selectors for PubMed IDs and GeneReviews articles for references.
[ ] Implement input validation to enforce cutoffs and data integrity.

User Stories

As a curator, I want to have relevant information autofilled from pre-curation forms to streamline my workflow.
As a researcher, I would like an integrated scoring system to aid in evaluating curated data.
As a geneticist, I need easy access to disease databases and literature references for thorough curation.
As a data manager, I want to ensure that all curated data adhere to specific standards and cutoffs for consistency.

Implementation Details

Utilize Vue.js data binding to prefill form fields based on pre-curation and gene card data.
Design a scoring algorithm based on the curated information and integrate it into the form.
Integrate API calls or database queries for MONDO and OMIM to populate the disease dropdown selectors.
Implement selectors for PubMed IDs and GeneReviews with search and autofill capabilities.
Set up validation rules for the form fields to ensure adherence to established cutoffs and standards.

Code Snippet
<template>
  ...
  <v-select
    v-model="curationData.disease"
    :items="mondoDiseases"
    label="Disease (MONDO)"
    outlined
    dense
  ></v-select>
  ...
  <v-autocomplete
    v-model="curationData.pmid"
    :items="pubmedReferences"
    label="PMID"
    outlined
    dense
  ></v-autocomplete>
  ...
</template>

<script>
export default {
  ...
  data() {
    return {
      ...
      mondoDiseases: [], // Array populated with MONDO diseases
      pubmedReferences: [], // Array populated with PubMed IDs
      ...
    };
  },
  ...
  methods: {
    fetchMondoDiseases() {
      // API call to fetch MONDO diseases
      ...
    },
    fetchPubmedReferences() {
      // API call to fetch PubMed references
      ...
    },
    ...
  },
  ...
  created() {
    this
.fetchMondoDiseases();
this.fetchPubmedReferences();
...
},
};
</script>

This issue will require to change the output format off kidney-genetics into JSON for easier parsing.


Feature request: sample showing reads from EventLog through Win32 API

Motivation
Show some examples between win32 C++ Eventlog code and what a rust-based example would look like(if possible).
Looking to see if some of the code here could be translated to rust, and shown as a sample.
Drawbacks
Since its more along the lines of a sample request than a feature, the following is just speculation on possible reasons:

Not enough time
Outside the scope of this project
The resulting sample is too large to include as a sample

Rationale and alternatives
Having tried to work through some of the initial translation, I became overwhelmed pretty quickly. I have a feeling that someone more seasoned with Win32 and rust would be able to make pretty quick work out of this example.
Additional context
No response

I'm not opposed to including a sample, but I don't know if anyone's got time to write such a sample. We also already have Win32-style API samples so there's sufficient examples to follow to figure things out. I generally just want to make sure there's a sample for each kind of API and we've already covered COM, WinRT, Win32, and more.


Engine API: adjust error codes with JSON-RPC 2.0 spec

According to JSON-RPC 2.0 spec, the range [-32768; -32000] is reserved for pre-defined errors. Applications should use values outside of this range.
This PR updates existing error codes. It might be a breaking change if a logic of any CL client relies on exact error code value (-32001).

Good catch. I don't think the actual number matters, but as a point of reference I see the LSP spec starts their LSP-specific errors at -32899 and ends it at -32800.

Credits to @MicahZoltu on this finding. If we want to have this spec as a reference, let us have -32800: Unknown payload, and so forth


Eslint simple-import-sort

This is ready to merge, we can later integrate the rule in our eslint-config-opencollective.


Wal e recovery

Add LWRP for wal-e envdir.
Add seperate recovery and archive recipes for wal-e.
@mbautin
@vnivargi

We should probably merge this.

LGTM. A few minor comments inline.

Good to merge?


Updated Mas OS kext

The dummy kext wasn't allowing me to claim the device on Mac OS El Capitan 10.11.2.
I updated the plist with kpi libraries but -- in the end -- it was essential to declare IOProviderClass as IOUSBDevice and not IOUSBInterface. Please note the libkern library could likely be sent back a few versions. Importantly, the attached is unsigned so SIP must be disabled to use it.
Info.plist.txt

Thanks a lot. I haven't tested on OS X in a long time.
I know someone who has a kernel extension code signing certificate, so I was planning to ask them to sign the kext for me. I'll do that once I've had a chance to test your changes.
Looks like github messed with the formatting, can you create a gist instead?

You're welcome. Here's the gist, hope it's better. https://gist.github.com/ben-knt/3332c930c04e4892bef2

By the way, I went through the Perl scripts and have some comments. Lampoff.pl crashes daliserver... for what reason, I don't know? I'm happy to help find out why. We can discuss offline sometime if you would like.

Uh, what?
I know that usbdali.pm is a bit buggy and doesn't return the response correctly. I fixed that problem locally, but haven't pushed it to github yet.
Are you positive it crashes daliserver?

Ok, fixed usbdali.pm in bae41b12.

I pulled in the changed file but no change. Lampoff.pl successfully turns off a lamp but the server crashes after.  Two commands issued below:
Braque:perl benknuth$ perl allset.pl 255
Writing 4 bytes to socket, address=254 command=254
Received status:success response:0
Braque:perl benknuth$ perl lampoff.pl 12
Writing 4 bytes to socket, address=25 command=0
Braque:perl benknuth$
[2016-00-22 20:28:13] INFO Starting daliserver
[2016-00-22 20:28:13] INFO Server ready, waiting for events
[2016-00-22 20:28:32] INFO Got connection from <IP_ADDRESS>:27089
[2016-00-22 20:28:32] INFO Got frame: 0x02 0x00 0xfe 0xfe
[2016-00-22 20:28:32] INFO Enqueued transfer (0x7fb7abc06cc0,0x7fb7abc06a90)
[2016-00-22 20:28:32] INFO Sending data to device:
0x00000000 12 01 00 03 00 00 fe fe 00 00 00 00 00 00 00 00 ................
0x00000010 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
0x00000020 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
0x00000030 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................

Direction: USB<->DALI Type: Send response Response: ff Status: 008a Sequence number: 01
[2016-00-22 20:28:32] INFO Response to (0x00 0x00): 0xff [0x008a]
[2016-00-22 20:28:32] INFO Connection 9 was disconnected
[2016-00-22 20:28:32] INFO Closing connection 9
[2016-00-22 20:28:45] INFO Got connection from <IP_ADDRESS>:27345
[2016-00-22 20:28:45] INFO Got frame: 0x02 0x00 0x19 0x00
[2016-00-22 20:28:45] INFO Enqueued transfer (0x7fb7abe01520,0x7fb7abe03090)
[2016-00-22 20:28:45] INFO Connection 9 was disconnected
[2016-00-22 20:28:45] INFO Closing connection 9
[2016-00-22 20:28:45] INFO Sending data to device:
0x00000000 12 02 00 03 00 00 19 00 00 00 00 00 00 00 00 00 ................
0x00000010 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
0x00000020 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
0x00000030 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................

Direction: USB<->DALI Type: Send response Response: ff Status: 008a Sequence number: 02
[2016-00-22 20:28:45] INFO Response to (0x00 0x00): 0xff [0x008a]
[2016-00-22 20:28:45] ERROR Error writing 4 bytes to connection<PHONE_NUMBER>: Bad file descriptor
Segmentation fault: 11
Braque:~ benknuth$

Ouch!
I'll look into this right away. It's clear that the connection is killed before the response can be sent, as some of the Perl scripts don't read the response at all. But the crash is in no way ok!
Can you run daliserver in gdb and produce a backtrace?

Here's the backtrace. Hope this helps!

These two commands sent were:
perl lampset.pl 12 255
Writing 4 bytes to socket, address=24 command=254
Received status:success response:0
perl lampoff.pl 12
Writing 4 bytes to socket, address=25 command=0

Umm... I didn't get your backtrace. Did you forget the link?
But no matter, I found the bug. It's just a bit hard to fix. Need to think about it some more.
As a temporary workaround, I pushed a modified lampoff.pl that checks the server response. This should prevent the crash.

I moved the crash report into a new issue #12, please post there.

To get back to the issue, can you change com.apple.kernel.libkern back to 1.8 and see if it still works on your system?

Changed it back and it works with no apparent problems.

Sorry, I completely missed your message.
I'll commit the updated Info.plist then.


Add patches for inductor tests

Note that this patch should be applied to pytorch source code

@Stonepia @RUIJIEZHONG66166 Could we also enable the inductor UT test in our CI/Nightly workflows by this PR?

close this pr because we don't use this method for enabling inductor tests


codec-dns not usable in an mDNS scenario.

Expected behavior
A pipeline containing both Question and Response decoders should work.  If you write your own mDNS responder, you're connected to to a multicast socket, and therefore see all traffic, both questions and responses.
Actual behavior
The current implementation assumes that your pipeline only wants to consume questions and produce responses, xor ask questions and consume responses.  An mDNS responder does both.
Steps to reproduce
Involve this handler in your pipeline, and connect to the mDNS multicast socket. On a network with mDNS-SD devices being chatty, quickly you'll see an exception thrown:
https://github.com/netty/netty/blob/master/codec-dns/src/main/java/io/netty/handler/codec/dns/DatagramDnsQueryDecoder.java#L83-L85
This is not due to a corrupted frame, but rather simply a valid non-question message arriving (unprompted), which is legal in mDNS.
Minimal yet complete reproducer code (or URL to code)
Netty version
4.1.39.Final (and seems to also exist similarly in #master
JVM version (e.g. java -version)
openjdk version "11.0.3" 2019-04-16 OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.3+7) OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.3+7, mixed mode)
OS version (e.g. uname -a)
Darwin MacBook-Pro.localdomain 18.7.0 Darwin Kernel Version 18.7.0: Tue Aug 20 16:57:14 PDT 2019; root:xnu-4903.271.2~2/RELEASE_X86_64 x86_64

fwiw, "working" variant of DNS codecs built out of band:
https://github.com/yokelhost/yokelhost-java

Sure, next time I cycle back around to this, I'd be glad to.
You're prefer a PR as opposed to directly committing to the repo, yeah?


[Feature Request] 🇪🇺 Euro currency  [€]  🇪🇺

€ € € € € € € € € € € € € € €
Thanks from all the europeans within the ⚡ eurozone ⚡

euro currency is supported by LubeLogger, if you're running this in Docker you just have to set the LC_ALL and LANG environment variables and you will start seeing euro currencies and dates :)
more info see here:
https://docs.lubelogger.com/Getting Started


webhook_features: Parse body_text instead of body

Fixes #15.
The current octocrab crate does not have a body_text for the Review struct, while the Comment struct has it. I submitted a PR to fix this in the original repo https://github.com/XAMPPRocky/octocrab/pull/271. I used my octocrab fork in this PR in the meantime.
I cannot add a unit test for the parsing of

ACK [d9bd628](https://github.com/bitcoin/bitcoin/commit/d9bd628ac9d1e6272cb2f8f67b86376a13233f90)
ACK https://github.com/bitcoin/bitcoin/commit/xxxxxxxxxxxxxxxxxxxxx
ACK https://github.com/bitcoin/bitcoin/pull/12345/commits/xxxxxxxxxxxxxxxxxxxxx

because we rely on GitHub's API to pre-parse the comment. Though I manually tested that they all get parsed correctly.

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews
See the guideline for information on the review process.
A summary of reviews will appear here.

Other crates in this package, such as conflicts, won't compile currently with this PR because of the conflicting crate octocrab that the util crate uses (my fork). And I'm not sure it's desirable to use my fork across all crates until https://github.com/XAMPPRocky/octocrab/pull/271 is merged.

I had to use the master branch of octocrab in every crate, I don't think there is another way to achieve compatibility between the crates otherwise.

You could duplicate the util library (ugly), or maybe make it a trait or so (more code). But the current approach is probably fine.


Added library-detectors 1.2 plugin & configured pom to skip

Added list of our exceptions for the classes we currently use

Can one of the admins verify this patch?

Sorry. Didn't get a chance to merge your change to my previous branch, and rebase on master. But, this PR works, too. :smile:

I ended up merging this onto a rebase'd #298


change call_user_func_array() with instance->method(...$args)

ref: https://3v4l.org/fADiJ

While I'm for removing call_user_func_array, I think this version is harder to grasp what it does than it needs to be. I think it would be clearer just simply write them like you're actually calling the method. So:
$result = $this->db->$name(...$params);

instead of
$result = [$this->db, $name](...$params);

updated


feat: Add k6 to TRIAL

@SnigL Looks good, you need to rebase and fix the inital commit from "feature: .." to "feat: .."

@SnigL Looks good, you need to rebase and fix the inital commit from "feature: .." to "feat: .."

Done and done


TypeScript type of withCookie does not take into account other HoCs

The type definition of withCookies can't handle situations where there are multiple HoCs applied to one component. For instance: withCookies(withRouter(App)). It needs quite a complex typing to handle these situations but there are libraries where it's done right, for instance react-router. Here's more information on subject: React Higher-Order Components in TypeScript

I got this problem too, and solved temporarily by modifying:
node_modules/react-cookie/cjs/withCookies.d.ts
// ...
export default function withCookies<T extends ReactCookieProps>(WrapperComponent: React.ComponentType<T>): React.ComponentType<T>;

But, the repo's code is already changed like above. I guess that modified version is not published to npm.

Release in v3.0.5


Implement source code listing widget with line wrapping

Line-wrapping code is non-trivial: since newlines matter in source code, we have to differentiate between auto-wrapped lines and actual newlines. (This is why even source-code-heavy websites in the wild, like stackoverflow.com, rarely use this approach.)
I think the way to achieve this, UX-wise, is via line numbers which make it easy to tell the actual newlines visually.
Alternatively, wrapped newlines can be indented.
Neither of those approaches are doable with CSS from my research so far, but we’ll see. Likely this calls for a JS-based widget, which may be already available under suitable license (perhaps CodeMirror supports this), or it can be developed.

Adding line numbers is a great suggestion.
Then maybe the accompanying approach is to break up long commands.
Let's not spend too much time in code widgets, just adopting a good enough one is sufficient.

Agreed about breaking longer commands, though I believe long lines may be unavoidable in some cases (either to demonstrate a certain feature or because of language limitations).

One upcoming change in a near release is new code listing font. Google Web Fonts offers good alternatives that are more readable and narrower than the default, letting more code fit in a line without making text really small.

Here’s an example of wrapping longer lines in command-line listings: https://github.com/metanorma/metanorma.com/commit/6090fc84764f39814bbbe505232bd116ce1bbab2
I’ll go over other content in a similar fashion in spare time, though I’ll mostly stay away from AsciiDoc examples since I am not 100% sure on how newlines behave there.

AsciiDoc: newlines do not matter in text in AsciiDoc. Newlines very much matter in commands  (which are any line not starting with a letter or number.)

@opoudjis is right but AsciiDoc does cares about newlines in the document header (where there are attributes) though.

Implementing line numbers in lengthy code blocks makes sense. Maybe not as much for short examples. The one complication is that they would make copy-paste operations a bit inconvenient for anyone wanting to paste an example onto the command line (or possibly anywhere else).

I’ve seen places where line numbers even when highlighted gets excluded from the copied text. I’m sure we can find an example of that?

+1 @ronaldtse, I'm sure I've seen that behavior too, somewhere.

Implementing line numbers in lengthy code blocks makes sense. Maybe not as much for short examples. The one complication is that they would make copy-paste operations a bit inconvenient for anyone wanting to paste an example onto the command line (or possibly anywhere else).

If we want to wrap long lines, line numbers are crucial, otherwise it’s unclear where actual new lines start.
Line numbers must not be selectable, of course—this requirement is what warrants the complexity of a widget (like CodeMirror) I mentioned in issue description in the first place.

I’ve seen examples of AsciiDoc markup where newlines matter, for example:
:very-long-document-attri
bute-name

This is not mentioning that sites deal with not just AsciiDoc but long shell commands and other languages. (Long shell command is what originally triggered Ronald’s concern.)

It should be noted that copy-pasting code, especially shell commands, from websites is an unsafe practice (it’s possible to produce a command that looks like string X but is actually completely different malicious string Y with the help of smart Unicode characters).

Closed accidentally.


'Canary versions are unsupported' message comes too late to be useful

The error message that the Flutter Plugin doesn't support canary versions of Android Studio appears only after starting a new Flutter Project and is too late to be helpful or useful. This is a warning that should appear on the 'New Flutter Project' screen to warn a user first. Further, it's unclear whether this message is accurate given the release notes on the Flutter Plugin home page which suggests that as of version 69, Canary Build 221 is supported in addition to the 2022.2.2 EAP.
Flutter Plugin 70.0.4
Android Studio Electric Eel | 2022.1.1 Canary 10
flutter_doctor.txt
Build #AI-221.6008.13.2211.8963757, built on August 18, 2022
Runtime version: 11.0.15+0-b2043.56-8887301 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 11.6.8
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 8
Registry:
external.system.auto.import.disabled=true
ide.text.editor.with.preview.show.floating.toolbar=false
Non-Bundled Plugins:
Dart (221.6008.17)
io.flutter (70.0.4)
Jetbrains TeamCity Plugin (2022.4.108706)

Hello @strangedreamsNY. This issue is related to the IntelliJ plugin for Flutter, therefore, it might be better if it was raised in flutter-intellij. Closing as this is not an issue with Flutter itself.


Dynamically get rule name from within an action

It would be useful to be able to retrieve the current rule name for use inside actions.
As an example for usage: building an AST from parsed text could utilize the current rule name as the node's type - without requiring specifying  the rule name explicitly.
Schematic example:
{
    // having a ruleName() would simplify grammar maintenance
    var tok = new token("tokenType", offset);
    tok.addChild(a);
    tok.addChild(b);
    return tok;
}

I moved this after 1.0.0 as I’d like to get to that version quickly. I’m now mostly focusing at polishing existing functionality and I’m deferring minor features that “only” fix annoyances.
Also, the implementation of this is somewhat harder than one might think — it has to account for inlined rules (currently only proxy rules, but this will change in the future) and ideally have no performance impact.

This is an old issue, but I would still be interested.
Even if inline rules are not supported (e.g. the rule name is undefined for those)

This would be extremely useful to me, and if @dmajda will help me get this repo back into a healthy, releasable state, by re-cutting 0.10.0 as 0.12.0, then I will happily make an effort to include this, in a fashion that resembles .text()
This would be one of the very early features I'd like to add

This would be extremely useful to me, and if @dmajda will help me get this repo back into a healthy, releasable state, by re-cutting 0.10.0 as 0.12.0, then I will happily make an effort to include this, in a fashion that resembles .text()

I no longer have any rights to the project. Resolving this is up to @futagoza. Thanks for understanding.

@dmajda - oh :(  i didn't realize that.
ok.  i hope you might consider encouraging him to release this work back to the community, since he's more likely to listen to you than anyone else
that said, i won't bother you about this again.  i'm sorry.  thank you for one of the most important libraries in my life.  it's been wonderful for me.

@futagoza - we need you to please consider allowing someone else to maintain this project now.  nothing has been released or maintained since you took over, and you said that you're in the process of throwing everything away
i encourage you to write another peg parser.  competition is great.  chevrotain, canopy, ometa, om, and lots of others have happy healthy interesting communities with large interesting variant feature sets
but also, since you took over peg.js, literally nothing has been released, and the quality of the information in the repo has declined dramatically
this isn't just some library.  this is one of the most heavily used parsers on earth.
it's been three years.  please let someone make this library work again.  a fork won't do the job, and you know that, because you've forked this library three times since you took over
if you will let me be maintainer, i can make this library healthy again immediately.  the same day i see it happen


runtime: ingest LLVMSupport into the runtime

This adds a new copy of LLVMSupport into the runtime.  This is the final
step before changing the inline namespace for the runtime support.  This
will allow us to avoid the ODR violations from the header definitions of
LLVMSupport.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @mikeash @jckarter

I'll be updating the commit message to include this, but LLVMSupport was forked at 22492eead218ec91d349c8c50439880fbeacf2b7.  The allocation updates are corresponding to upstream changes.

Do we need all of llvmSupport? Can we bring over only the bits we use?

@jckarter I believe that we dont need all of LLVMSupport.  My intention is to bring it in its entirety to compile.  Im going to more or less immediately follow this up with 2 changes:

introduce an inline namespace for avoiding the ODR violation that this causes (which is the original motivation for all the work)
begin to strip this down to just the pieces that we are actually using.

I want to introduce the library in its complete form because its much easier to track the provenance that way.  It makes it simpler to split the operation into copy, delete rather than do it as one.  However, Im happy to just stack that into this change and merge the entire thing at once, as long as the steps remain to help make it easier to follow what happened.

@swift-ci please test

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 9212b373c5713e280a16cc6baac3b84fd089efee

Build failed
Swift Test Linux Platform
Git Sha - 9212b373c5713e280a16cc6baac3b84fd089efee

Please test with following PRs:
apple/llvm-project#1205
@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 9212b373c5713e280a16cc6baac3b84fd089efee

Build failed
Swift Test Linux Platform
Git Sha - 9212b373c5713e280a16cc6baac3b84fd089efee

Please test with following PRs:
apple/llvm-project#1206
@swift-ci please test

Please test with following PRs:
apple/llvm-project#1206
@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - ff38fb4729fc480710b8f1d873cc14e13a0fa62a

Please test with following PRs:
apple/llvm-project#1206
@swift-ci please test macOS platform

Please test with following PRs:
apple/llvm-project#1206
@swift-ci please test windows platform

Build failed
Swift Test OS X Platform
Git Sha - ff38fb4729fc480710b8f1d873cc14e13a0fa62a

Build failed
Swift Test Linux Platform
Git Sha - ff38fb4729fc480710b8f1d873cc14e13a0fa62a

Please test with following PRs:
apple/llvm-project#1206
@swift-ci please test

Please test with following PRs:
apple/llvm-project#1206
@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 09eaf69951b75037d6b78790ca9a22940d91cb72

Build failed
Swift Test Linux Platform
Git Sha - 09eaf69951b75037d6b78790ca9a22940d91cb72

Please test with following PRs:
apple/llvm-project#1206
@swift-ci please test

Please test with following PRs:
apple/llvm-project#1206
@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 09eaf69951b75037d6b78790ca9a22940d91cb72

Build failed
Swift Test Linux Platform
Git Sha - 70d4f3454e13ddf98274f04f2d8cec7cd359c041

Going to have to do the namespacing and pruning together to avoid growing dependencies on ncurses

Verifying leakage with:
$ nm -C --defined-only lib/swift/linux/x86_64/libswiftCore.so | grep -v -e __swift::__runtime -e ' swift::' -e ' std::' | grep llvm::

There are current a couple of small leaks which will be cleaned up by the pruning.
0000000000639430 t llvm::ilist_iterator<llvm::ilist_detail::node_options<llvm::AllocatorList<llvm::yaml::Token, llvm::BumpPtrAllocatorImpl<llvm::MallocAllocator, 4096ul, 4096ul, 128ul> >::Node, true, false, void>, false, false> llvm::simple_ilist<llvm::AllocatorList<llvm::yaml::Token, llvm::BumpPtrAllocatorImpl<llvm::MallocAllocator, 4096ul, 4096ul, 128ul>>::Node>::eraseAndDispose<llvm::AllocatorList<llvm::yaml::Token, llvm::BumpPtrAllocatorImpl<llvm::MallocAllocator, 4096ul, 4096ul, 128ul> >::Disposer(llvm::ilist_iterator<llvm::ilist_detail::node_options<llvm::AllocatorList<llvm::yaml::Token, llvm::BumpPtrAllocatorImpl<llvm::MallocAllocator, 4096ul, 4096ul, 128ul> >::Node, true, false, void>, false, false>, llvm::AllocatorList<llvm::yaml::Token, llvm::BumpPtrAllocatorImpl<llvm::MallocAllocator, 4096ul, 4096ul, 128ul> >::Disposer)
0000000000611850 t unsigned int llvm::ComputeEditDistance<char>(llvm::ArrayRef<char>, llvm::ArrayRef<char>, bool, unsigned int)
000000000061b8d0 t llvm::sys::UnicodeCharSet::rangesAreValid() const

@swift-ci please test

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 15983dfb10b51d85a6f126bdd74521cec4a26cb2

Build failed
Swift Test OS X Platform
Git Sha - 70d4f3454e13ddf98274f04f2d8cec7cd359c041

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 15983dfb10b51d85a6f126bdd74521cec4a26cb2

Build failed
Swift Test Linux Platform
Git Sha - 147d6afe954da2a9740f40154117c09887edf5a8

@swift-ci please test windows platform

@swift-ci please test Linux platform

@swift-ci please test

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - fafbdeb3abe2c4d3787575ce7d810a4b3ebec501

@swift-ci please test Windows platform

$ nm --defined-only -demangle ./lib/swift/macosx/x86_64/libswiftCore.dylib | grep -v -e '__swift::__runtime::llvm' | grep -e 'llvm::'
00000000003cb3c0 t (anonymous namespace)::OldDemangler::demangleIdentifier(llvm::Optional<swift::Demangle::Node::Kind>)
0000000000441c30 s (anonymous namespace)::OldDemangler::demangleIdentifier(llvm::Optional<swift::Demangle::Node::Kind>)::op_char_table

This symbol is actually leaked on all the platforms, and can be cleaned up subsequently

@swift-ci please test macOS platform

$ nm --defined-only --demangle lib/swift/linux/libswiftCore.so | grep -v
 -e '__swift::__runtime::llvm' | grep llvm::
0000000000589810 t (anonymous namespace)::OldDemangler::demangleIdentifier(llvm::Optional<swift::Demangle::Node::Kind>)
000000000001a6f0 r (anonymous namespace)::OldDemangler::demangleIdentifier(llvm::Optional<swift::Demangle::Node::Kind>)::op_char_table

Linux is also in sync with macOS here

Build failed
Swift Test OS X Platform
Git Sha - fafbdeb3abe2c4d3787575ce7d810a4b3ebec501

@swift-ci please test

@swift-ci please test

@swift-ci please test Windows platform

Spoke with JoeG and MikeA about this offline.  We all agree that this is bringing us into a better state for stability moving forward, addresses the ODR violation issue.
This allows for a transitioning state where we could start vending the ADTs as part of the runtime and work towards removing the some of the C++-ness of the ABI definitions to allow for easier sharing between the runtime and the compiler.  It would also allow for easier use of the ABI type definitions in the Swift code.


Support multi-call in actors

Context
sometimes you need to make a group of method calls of the contract(s). At the same time, in certain situations it makes sense to make such a group call within a single transaction
current solution is to build script by one of:

manually via io.BufBinWriter and emit package(example)
make several Call method calls and concatenate resulting scripts
??? mb some other one

and then call MakeRun.
while both approaches are working, i see 1st as too low-level and requiring deep VM knowledge while 2nd as suboptimal
Proposal
i can suggest two APIs
1.
type CallPrm struct {
  Contract util.Uint160
  Method string
  Args []any
}

func (*Actor) MultiCallScript(ps []CallPrm) ([]byte, error)
func (*Actor) MakeMultiCall(ps []CallPrm) (*transaction.Transaction, error)
func (*Actor) SendMultiCall(ps []CallPrm) (util.Uint256, uint32, error)

type ScriptBuilder struct { ... }
func (*ScriptBuilder) AddCall(contract util.Uint160, method string, args ...any)
func (*ScriptBuilder) Close() []byte

func (*Actor)  InitScriptBuilder() *ScriptBuilder

P.S. mb such ScriptBuilder is more generic than actors and then should be placed in other package

You're right, currently only 1-st way can be safely used, but I think we can consider implementing some API that is similar to MultiTransfer with several call targets. So I like the first example from your description.

We've just discussed this issue, I think we may close it as unplanned.

smartcontract package API is exactly what i was looking for, thx

smartcontract package API is exactly what i was looking for, thx

Take a look at the Roman's link, it suits better than smartcontract API. You can concat multiple calls to Builder's InvokeMethod or InvokeWithAssert.


docs: add tutorial on data and model drift

Description
Add a tutorial on which we simulate a real scenario where we have fine-tuned a model on historical data and observe a degradation in the accuracy using this model. Then we analyze data to understand why data drift happened.
TO DO:

[x] Add more info on some parts
[x] Rerun some outputs

NOTES:
-I used Ollama as not all people usually have access to an openai api.key, and we're using it in most of the tutorials.
-To analyze data drift I provide two options so that they don't have to install everything. I also included text descriptions, as in many articles, were mentioned.
Closes #4448
Type of change
(Remember to title the PR according to the type of change)

[x] Documentation update

How Has This Been Tested
(Please describe the tests that you ran to verify your changes.)

[x] sphinx-autobuild (read Developer Documentation for more details)

Checklist

[ ] I added relevant documentation
[x] I followed the style guidelines of this project
[ ] I did a self-review of my code
[ ] I made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I filled out the contributor form (see text above)
[ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@davidberenstein1957 The last commit should fix the logs issue.


Make extensions identifiers contain . to separate extensions where multiple used

origin:

https://github.com/bids-standard/bids-specification/pull/1749#discussion_r1545497672

Dots are separators in the schema. This seems like a bad idea.

We could use an underscore instead.

good idea, done, taking out of draft.

After https://github.com/bids-standard/bids-specification/pull/1749, we need to update the anchors in these links:
❯ grep -rI 'tsvgz\|niigz' src/**/*.md
src/common-principles.md:[compressed tab-delineated (TSV.GZ) files](glossary.md#tsvgz-extensions) when
src/modality-specific-files/physiological-recordings.md:([TSV.GZ file](../glossary.md#tsvgz-extensions)) and a corresponding
src/modality-specific-files/task-events.md:([TSV.GZ file](../glossary.md#tsvgz-extensions)) and a corresponding

sorry , I am missing why this PR is "relevant" or why they were not spotted/adjusted in #1749 - don't linkchecker tests those as well?

I don't think anchors fail to resolve.

I don't think anchors fail to resolve.

at least in the past I made sure they did... may be when we reverted to use upstream version of linkchecker we lost that... might want to make sure some time so we do not breed them

Impact on rendered doc is essentially nil. Invoking admin privileges.


Backend and Frontend Image Workflow for Docker are not Working

Current Behavior
Backend:

https://github.com/eclipse-tractusx/digital-product-pass/actions/runs/8707847347
Frontend:

https://github.com/eclipse-tractusx/digital-product-pass/actions/runs/8707847351
Expected Behavior

Problems:
All the workflow steps that were shared are not moved to the respective steps, after refactor for splitting the logic in between two different jobs
Missing checkout repository for frontend:
https://github.com/eclipse-tractusx/digital-product-pass/compare/v2.2.0..15e73dbc005481d78c315ca22e1e9f29cee8c9f6#diff-e2568d644336fa1d58208a8dc4dbb8ab90925066d7916f8eee597ac8ad297d4fL59-L62
Missing build java for backend:
https://github.com/eclipse-tractusx/digital-product-pass/compare/v2.2.0..15e73dbc005481d78c315ca22e1e9f29cee8c9f6#diff-bcb4660648686ea5e55a0ca08b6ec2f8e2713d20c9a722f55560526df29bc8b7L62-L63

Fixed the issues in respective workflow files:
Last successfull runs:
Frontend:  https://github.com/eclipse-tractusx/digital-product-pass/actions/runs/8709170583
Backend: https://github.com/eclipse-tractusx/digital-product-pass/actions/runs/8709170587
Solved in: https://github.com/eclipse-tractusx/digital-product-pass/commit/646e4f5f6fb137e51ed258caaabd78266312f377


error processing launch options at field value

When I click the debug button, the error appears as above, it seems to be a problem in the launch file, but there is novalueparameter in my launch.json file, I can't locate where the problem is, please help me thanks!

Please provide your launch.json file

Please provide your launch.json file

"version": "0.2.0",
"configurations": [
{
"name": "vis",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build/MSVC2019-x86_x64_debug/debug/install-root/mmind_viz_debug.exe",
"args": [],
"stopAtEntry": false,
"cwd": "${fileDirname}",
"environment": [],
"console": "internalConsole",
"visualizerFile": "${workspaceRoot}/.vscode/qt5.natvis",
},
{
"name": "planning_test",
"type": "cppvsdbg",
"request": "launch",
"program": "${workspaceFolder}/build/MSVC2019-x86_x64_debug/debug/install-root/mmind_planner_test_debug.exe",
"args": [],
"stopAtEntry": false,
"cwd": "${fileDirname}",
"environment": [],
"console": "internalConsole",
"visualizerFile": "${workspaceRoot}/.vscode/qt5.natvis"
}
]
Sorry for my negligence

I have solved this error, thanks!

Ok, then I close this task.


Add new binary metrics

This pull request adds new binary metrics. The added metrics include:

BinaryMetric: Lets you pass in an arbitrary function that evaluates to true or false

RegexMetric: Searches response matching regex

AnswerMatchMetric: Checks answer matches exactly

DuplicationMetric: Checks whether or not there's duplicate information in the response

ResponseLengthMetric: Checks that response is within a certain number of characters

ContextLengthMetric: Checks that context length is within a certain range

ContainsTextMetric: Checks whether or not response contains the given text

How do you envision these metrics being used with ValidateScorer and logged to the UI? Or do you not envision that?
I ask because a lot of the metrics would depend on the question, and so could not be used on a batch of questions and answers like how ValidateScorer uses the already existing metrics. The regex, answer match, and contains text metrics I'd imagine you'd want the metric to change for each question.

How do you envision these metrics being used with ValidateScorer and logged to the UI? Or do you not envision that?
I ask because a lot of the metrics would depend on the question, and so could not be used on a batch of questions and answers like how ValidateScorer uses the already existing metrics. The regex, answer match, and contains text metrics I'd imagine you'd want the metric to change for each question.

Yeah, they should all be compatible with the UI. I did not really think much about it changing per question though. Simply because the way I imagined it is that you have some format you want for your LLM responses and those text matching metrics allow you to check that it meets your desired format. The answer match is probably the least useful at checking if it matches the desired format, but could be used still to make sure if given a certain question (e.g. asking the rag system to give you sensitive info) then the rag system will always return the same refusal answer. Anyhow, I can definitely see the usefulness for changing it question by question (which we should allow in the future)

How do you envision these metrics being used with ValidateScorer and logged to the UI? Or do you not envision that?
I ask because a lot of the metrics would depend on the question, and so could not be used on a batch of questions and answers like how ValidateScorer uses the already existing metrics. The regex, answer match, and contains text metrics I'd imagine you'd want the metric to change for each question.

Yeah, they should all be compatible with the UI. I did not really think much about it changing per question though. Simply because the way I imagined it is that you have some format you want for your LLM responses and those text matching metrics allow you to check that it meets your desired format. The answer match is probably the least useful at checking if it matches the desired format, but could be used still to make sure if given a certain question (e.g. asking the rag system to give you sensitive info) then the rag system will always return the same refusal answer. Anyhow, I can definitely see the usefulness for changing it question by question (which we should allow in the future)

In this case, we need clear documentation in the docs and perhaps in doc strings for intended use of these metrics. It's not clear at the moment because I imaged the regex, answer match, and contains text metrics would change what they are looking for question to question.

Re docs: Adam mentioned given the number of metrics we should just add them to the gitbook docs and not to the readme itself. So when janice does the docs for that, I think she can mention that


Uncaught (in promise) Error: startCleanup: Page 1 is currently rendering.

Attach (recommended) or Link to PDF file here:
We are currently using pdfjs version pdfjs-1.6.210, which has xss issues. To esolve that I am trying to upgrade to pdfjs-3.8.162.
As per doc https://github.com/mozilla/pdf.js, I took the pdfjs-3.8.162-dist.zip from https://github.com/mozilla/pdf.js/releases/tag/v3.8.162 and updated pdf.js as mention in the doumentation
Configuration:
-Web browser and its version: 115.0.2 (64-bit)
-Operating system and its version: windows 10
-PDF.js version: pdfjs-3.8.162
-Is a browser extension: no
Steps to reproduce the problem:
-update the new pdf.js
-try to view in viewer
What is the expected behavior? (add screenshot)
PDF should be rendered
What went wrong? (add screenshot)

At first time, PDF is rendering, But when I scroll down and scroll up again first few pages are not rendering and throwing
VM7991:2477 Uncaught (in promise) Error: startCleanup: Page 1 is currently rendering.
at WorkerTransport.startCleanup (eval at  (eval at  (dojo.js:1:1)), :2477:15)
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

This is completely impossible to debug using nothing but a screen-shot, which also appears to be from a custom viewer; hence please see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.

@Snuffleupagus I checked this https://github.com/stephanrauh/ngx-extended-pdf-viewer/issues/645 issue and it seems it is fixed. But still I am getting this. Atleast tell me workaround to fix the issue before closing the ticket

I checked this stephanrauh/ngx-extended-pdf-viewer#645 issue and it seems it is fixed.

Sorry, but that's a different project that we cannot provide help/support for here.

Atleast tell me workaround to fix the issue before closing the ticket.

Given that this doesn't happen in the default viewer, see https://github.com/mozilla/pdf.js#online-demo, as already mentioned in https://github.com/mozilla/pdf.js/issues/16727#issuecomment-1646626615 it's simply impossible for anyone to provide assistance without being able to reproduce the issue; hence why a runnable example is needed here.

That's okay but what's the work around here, The pdf isn't loading because of this.


Implement selfDesctruct in the WebSite SC

Implement a self destruct function in the website SC. This should allow users to completely remove their SC from deployment and by extension remove it from the indexer list

  onlyowner();
  if( !website_empty() ) {
      raise "website not empty, please clear all files first";
      // this check ensures that the self destruct function won't take an infinite amount of gas and fail if there are 10000000 files to delete
  }
  owner = get_owner();
  // TODO delete the Owner datastore entry
  // TODO delete all website-level metadata
  if storage.has("DEWEB_VERSION") {
    storage.del("DEWEB_VERSION");
  }
  set_bytecode("")
  if(owner != "") {
     transfer_coins(get_balance(), owner);
  }
}```


Capitalise 'Hub' in 'hidden profile' blurb

I think it's better to write 'the new Hub' not 'hub', or 'the new EA Hub' or 'Effective Altruism Hub'.

Ooh also 'Profile hidden until user confirms that they want to make public'. This needs an 'it' between 'make' and 'public'. If we want to be totally correct we will add 'This profile is' at the start.

Done


Animation Tree Player improvements (mostly GUI)

We need to have the following improvements to ATP:

There is a feature called filters. If you don't know, you can't avoid using it if you blend
several animations or using oneshot node for things like blinking, as it limits scope of your animations.
We need to have separate filters "node" from blend/oneshot nodes in GUI.
This node will allow us eventually implement general animation filtering, which will make
animation composition hardships go away. Basically all important functionality
is already implemented, this is small readjustment.
Nedd to mention we don't want to attach this "node" to Animation node.
Animation node needs to have multiple output in GUI. This
can be generated into multiple animation "nodes" for each output, or some other things,
but this have to be done, as lots of nodes with the same animation really clutters scene output.

Imagine you have "blink" animation and "breathe" animation.
 If you have hundred main animations ,only these 2 detail animations will
make your setup into 300 nodes hard to navigate and manage.
Internally this can be the same as now, but for GUI something needs to change.

The filter editor for animations with many tracks (like skeletal animations) looks like mess.
It is very hard to navigate. Probably it should be replaced by something useful, but probably
if possible the existing one can be improved by a few simple things:

Add search for simple substring with immediate display (like quick search in some apps)
not requiring press Enter after each result, just reducing output with additional character entered.

Add "invert selection", "select all", "unselect all" buttons
Disable treeish view (probably a checkbox with immediate reaction), replacing it with plain table), that would really help with bones,

@bojidar-bg what do you think?

@slapin Well, I haven't used AnimationTreePlayer yet, but I will try it and see if those changes are reasonable :)

I think it is just start, I have some other ideas, but these are most simple ones and are most annoying issues.

Well, this is core node needed to implement character animation in 3D and
keep sanity,
so going 3D you will have to use it eventually
On Mon, Apr 25, 2016 at 4:02 PM, Bojidar Marinov<EMAIL_ADDRESS>wrote:

@slapin https://github.com/slapin Well, I haven't used
AnimationTreePlayer yet, but I will try it and see if those changes are
reasonable :)
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/4438#issuecomment-214306430

The AnimationTree GUI code is a mess: I'm guessing it was written before the GUI nodes existed because it's mostly hard-coded. So changing the GUI isn't easy.
The core functionality for filtering is not all implemented: you can have one filter on any given path through the tree, so it's quite limited. The filters don't combine at all; they just overwrite each other.  The easiest thing would be to add filtering directly to leaf nodes (Animation nodes) to work around this limitation.  But even there, adding it to the GUI is a nuisance (I did this the other day for personal use and ended up adding a "Edit Filters" entry in the animation popup menu because that was the only way to do it without rewriting the whole AnimTree GUI). I could push that code to github if you're interested.
Multiple output: it sounds to me like you're doing it backwards. Why can't you select between walk, stand, sit, lay down, idle, etc., and then blend your breathe/blink oneshot on top of that at the very end?  Then you would only need one copy. The code is not set up to have multiple outputs: each connection makes time pass by recursing up from the out node, so if you added N outputs the animation would play N times as fast. And what if you want it to play at a different speed from one output as from another output?
Filter editor: again, look at the code. It's not set up so it's simple to make those kinds of modifications. If you want to take it on, good for you.

As of 2016, AnimationTreePlayer is still severely lacking. Lacks signals, plays Animations in a heavily erratic manner whereas AnimationPlayer can play them correctly, causes errors all over the place.
It's really a shame because I was trying to use it for simple cutscenes (by "Transitioning" to the next input index), but it breaks everywhere (and I'm almost sure I'm doing things right).
I hope someone can take a thorough look into this one!

It will be completely rewritten for Godot 3.0
On Aug 9, 2016 10:12 PM, "António Sarmento"<EMAIL_ADDRESS>wrote:

As of 2016, AnimationTreePlayer is still severely lacking. Lacks signals,
plays Animations in a heavily erratic manner whereas AnimationPlayer can
play them correctly, causes errors all over the place.
It's really a shame because I was trying to use it for simple cutscenes
(by "Transitioning" to the next input index), but it breaks everywhere (and
I'm almost sure I'm doing things right).
I hope someone can take a thorough look into this one!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/4438#issuecomment-238739283,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2-N7MBEH_OQUnvVLlMdAUyeWehMhks5qeSVygaJpZM4IOxac
.

For now you can write your own blender in GDScript using Animation
resource, it is quite easy.
ATP also can be used with a few hacks.
The main problem with 3D animations with ATP is that they consume too much
CPU
if you have complex tree (about 20-30 nodes is noticeable), I really don't
know why.
To overcome this you can write your own game-specific animation blender
looking at ATP code, strangely, you don't need it in C++ - GDScript version
works fine.
But the code will be really hairy, so I hope that this eventually be fixed
in some way.
On Wed, Aug 10, 2016 at 4:21 AM, Juan Linietsky<EMAIL_ADDRESS>wrote:

It will be completely rewritten for Godot 3.0
On Aug 9, 2016 10:12 PM, "António Sarmento"<EMAIL_ADDRESS>wrote:

As of 2016, AnimationTreePlayer is still severely lacking. Lacks signals,
plays Animations in a heavily erratic manner whereas AnimationPlayer can
play them correctly, causes errors all over the place.
It's really a shame because I was trying to use it for simple cutscenes
(by "Transitioning" to the next input index), but it breaks everywhere
(and
I'm almost sure I'm doing things right).
I hope someone can take a thorough look into this one!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/godotengine/godot/issues/4438#issuecomment-238739283
,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF-Z2-N7MBEH_
OQUnvVLlMdAUyeWehMhks5qeSVygaJpZM4IOxac>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/4438#issuecomment-238740660,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAX01kFEFlOLWCjmRaoTTJ4ck1bbd-Lks5qeSeugaJpZM4IOxac
.

@Slapin Actually, it's a 2D game; I was trying to get from one animation to another with just a transition node in the cutscene, and drawing a more complex tree for a "Move Set" specific to a character.

The Animation resource is easy to work with and you can make quite
powerful animation system with GDScript without much effort.
Especially for 2D. For 3D the set of workarounds can do a trick too,
but it is much harder work, and as all things made of sticks, not very
reusable, which is sad.
On Wed, Aug 10, 2016 at 5:51 PM, António Sarmento<EMAIL_ADDRESS>wrote:

@Slapin https://github.com/Slapin Actually, it's a 2D game; I was
trying to get from one animation to another with just a transition node in
the cutscene, and drawing a more complex tree for a "Move Set" specific to
a character.
Sadly, this causes errors all over the place,
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/4438#issuecomment-238891604,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAX0zuflCHnhi1nbpIVUcagrMfQ1lVrks5qeeVygaJpZM4IOxac
.

Voting to close this, not a priority at all. Juan told me on reddit.

AnimationTreePlayer is deprecated in Godot 3.1 and will be removed in Godot 3.2. It is replaced by AnimationTree, which was written from scratch and likely fixes/deprecates this issue.
If the issue is still relevant in some form with AnimationTree in Godot 3.1, please open a new issue about it (potentially linking this one if there is relevant discussion to keep track of).


feat: add exception logs to file

:tada: This PR is included in version 2.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


UI/ux

pulling for video

pulling for video

I think you meant to PR onto your own project

I think you meant to PR onto your own project


Updated for latest Nim version

Removed expr/stmt metatypes to make it compile + removed deprecations. Fixes https://github.com/oprypin/nim-random/issues/19

Thanks!


Add official api docs

Python lego mindstorms has some official docs. Could they be added here? (just pull them out of the apk)

Sure the docs for each release could definitely be added here.
It'd be nice to see how they change between versions.
I'm not sure how to extract them from the Mindstorms apk, but I can probably extract them from the windows SPIKE Prime apps.

I know how to pull them out of the APK:
a) get split_asset_pack.apk
b) unpack assets/webapp/static/knowledge
c) you are done!

From the SPIKE Prime apps the app.asar archive contains the reference under the path: ./app/renderer/static/knowledge/*

From the SPIKE Prime apps the app.asar archive contains the reference under the path: ./app/renderer/static/knowledge/*

Also see https://lego.github.io/MINDSTORMS-Robot-Inventor-hub-API/index.html

Lego have done this for us!
https://lego.github.io/MINDSTORMS-Robot-Inventor-hub-API/


app集成了极光推送，Pdf417Mobi demo license key配置进去报错，错误信息：不支持。

Before opening an issue, check that you are using the latest version of the PDF417 SDK.
Also, make sure your issue isn't on the list of common problems.

Description
Issue description goes here.
Please try to provide steps to reproduce the issue, or minimal code sample. It will help us resolve the issue faster.
Environment Details
**PDF417 version:**Latest SDK version: | 7.0
Device model: 红米note4
**Device Android version:**android 6.0
Device ABI (processor architecture, e.g. ARMv7): arm
Log file
Please enable logging by following instructions here and attach full log file.
Additional information
If there is anything else that you think can help us resolve the issue, write it here.

Hi @manuchen,
can you please give us more information if you have any problems or questions about our SDK?


Fix deprecated consts and error linked to async call within thread

Fix warning linked to use of deprecated constants.
Fix the error raised by the call of sensor.async_schedule_update_ha_state

Merci Philippe !


[Node.js] Application is not restarting after node_modules deployment

When only changes are made within the root node_modules folder, files are deployed but the application is not restarted.
To force restart of the application I added a final step to my deploy.sh :
touch "$DEPLOYMENT_TARGET/host.json"

It's working but it looks kind of a hack.

Why is [azure-something] not watching for changes within node_modules folder? Should [azure-something] watch node_modules?
Is there a way to restart the application within my deploy script? (see this question)

Context :

Using Azure Function with Node.js
Building my application on my own CI machine : The builds already includes all dependencies in node_modules
The build is deployed on Azure with git
Default deploy strict is making an npm install --production and because I already have all my dependencies in ma build, I made a custom deploy script that skips the npm install

My structure looks like :
function1/
    function.json
    index.js
function2/
    function.json
    index.js
node_modules/
.deployment
deploy.sh
host.json
package.json

Originally opened on projectkudu/kudu : https://github.com/projectkudu/kudu/issues/2109
@davidebbo points me out that this issue is more relevant here on azure-webjobs-sdk-script

Yes, we're currently not watching for file changes in the root node_modules folder. We should. As it stands now, we watch for changes under each function directory recursively, as well as watching for host.json changes. Thanks for reporting this - we'll address ASAP.

Thanks for reporting. Fixed by https://github.com/Azure/azure-webjobs-sdk-script/pull/613. We'll get this out with our next release in a week or so.


Bump requests from 2.26.0 to 2.32.2

I encountered an issue when using PyVespa v0.42.0 installed with Poetry. Attempting to import Vespa using the following code:
from vespa.application import Vespa
results in the following error:
ImportError: cannot import name 'JSONDecodeError' from 'requests.exceptions'
Upon investigation, I found that the JSONDecodeError class was added to requests.exceptions starting from version 2.27.0. However, your pyproject.toml file specifies requests v2.26.0, which is why this error occurs.
I suggest updating the requests dependency to v2.32.0 to resolve this issue. The same error is present in PyVespa v0.43.0 and potentially in other versions as well.
Thank you for addressing this.

Do you accept pull requests from external developers? Would you prefer I submit a PR next time, or should I wait for your fix?

External contributions are very welcome. Will be fixed faster then.

Thank you for reporting this quickly.
The requests-dependency is actually unpinned in pyproject.toml (dependencies).
The pinned one is for [build] only.
Also want to update our CI-pipeline, which are run with [dev] so that we have locked version of main dependencies, to catch similar issues earlier in the future.

Fixed in version 0.44.0


fix(genesis): separate genesis param and chain param

Description
Related issue

Fixes #1341

@b00f requested changes are done. but I can't make fee parameters private in genesis params since we will get linter errors.


[DEV] Add TPM Attestation and Chain-loading process

Objective
Implement an extensible and reusable initrd solution with TPM attestation to enable a secure bootstrapping process. The initrd will verify the system's trustworthiness via TPM attestation and facilitate the downloading of files to faciliate secure bootstrapping process ( including secure, more permanent kernel)
Definition of Done
The initrd includes TPM attestation capabilities and successfully verifies the system's trustworthiness during the bootstrapping process.
The initrd dynamically retrieves and boots into a verified kernel and initrd, supporting secure environments.
Artifacts (initrd, Dockerfile, build scripts) are extensible to other OpenChami environments, adhering to modular and reusable design principles.
The TPM attestation flow:

Generates TPM attestation keys during the build process.
Attestation keys and PCR values are used to create a TPM quote.
The quote is verified with an attestation server.
All changes are tested and verified:
A sample kernel and initrd are downloaded and booted after successful attestation.
PCR values and attestation server interactions are logged for auditability.
Failure scenarios (e.g., missing TPM device, failed attestation) are gracefully handled and logged.
Provide clear instructions for testing, including:
Building the initrd and attestation server.
Configuring kernel parameters.
Running the initrd with QEMU or other testing environments.

Additional Context
Enhancements: Explore integrating Keylime (https://keylime.dev/) for advanced TPM-based remote attestation workflows. Keylime can augment this solution by adding higher-level trust policies and automated integrity verification.
Uni-Kernels: Investigate the feasibility of using Uni-kernels to create lighter, purpose-built boot environments that can streamline and optimize the secure bootstrapping process.
Extensibility: The artifacts (initrd, scripts, server) should be modular and adaptable to any OpenChami environments. This ensures long-term maintainability and ease of integration with different secure boot workflows.
Purpose: The ultimate goal is to create an initrd that establishes a trusted bootstrapping mechanism. This mechanism enables the system to securely download and transition to a verified kernel, setting the foundation for a robust and secure operating environment.

https://github.com/OpenCHAMI/aria2-initrd/tree/aria2-initrd-tpmattest


brainflow: init at 5.12.1

Description of changes
Continuation of https://github.com/NixOS/nixpkgs/pull/303718, since I goofed up my rebase command and pinged like 100 people. Sorry :(
Closes https://github.com/NixOS/nixpkgs/pull/278412 (supersedes)
Closes https://github.com/NixOS/nixpkgs/issues/303517

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

CC @kirillrdy

Result of nixpkgs-review pr 324462 run on x86_64-linux 1

5 packages built:

brainflow
python311Packages.brainflow
python311Packages.brainflow.dist
python312Packages.brainflow
python312Packages.brainflow.dist


load_pgn duplicates last half-move if it has a comment

If there's a comment on the last half-move, load_pgn will duplicate that move, which either results in returning "false" (if it wasn't a legal move) or an actual duplicate ending up in the history.
Example:
testgame = new Chess()
testgame.load_pgn("1. e4 e5 2. Nf3 Nc6 3. Bb5 d6 4. d4 Bd7 5. Nc3 Nf6 6. Bxc6 {comment}")

Now testgame.history() returns ["e4","e5","Nf3","Nc6","Bb5","d6","d4","Bd7","Nc3","Nf6","Bxc6","Bxc6"]. Notice the extra Bxc6 at the end, which happens to be a legal move in this position.
If you do
testgame = new Chess()
testgame.load_pgn("1. e4 e5 2. Nf3 Nc6 3. Bb5 d6 4. d4 Bd7 5. Nc3 Nf6 6. Bxc6")

then testgame.history() will instead be ["e4","e5","Nf3","Nc6","Bb5","d6","d4","Bd7","Nc3","Nf6","Bxc6"], which is the expected value for both these examples.

Thanks for the report.  This is fixed in master.


CPI Bosh::Clouds::CloudError: 'Timed out waiting for Server `X' to be terminated, deleted' in 'delete_vm' CPI method

https://github.com/cloudfoundry-incubator/bosh-openstack-cpi-release/blob/a51ca01830666a8dbc2f582d6afc2d5ef85196d9/src/bosh_openstack_cpi/lib/cloud/openstack/openstack.rb#L201
How to get more detailed logs?
How to enable debug level on this class and where can I find this debug logs?

Hey, @wildloop, thanks for your issue. Could you please provide some context on what you're doing, which error you're experiencing and what you're trying to achieve?
Thanks!

We are trying to deploy CF on OpenStack IaaS.
OpenStack is configured via Terraform, Bosh is deployed and running, cf-deployment.yml is created according to the documentation found on the official website.
While deploying CF OpenStack instances are properly booted, responsive, all machines are available to connect to each other yet we still receive timeouts.
To deploy cloud foundry we use these commands:
bosh -e bosh-1 upload-stemcell https://bosh.io/d/stemcells/bosh-openstack-kvm-ubuntu-trusty-go_agent
bosh -e bosh-1 -d openstack upload-release
bosh -e bosh-1 -d openstack deploy cf-deployment.yml

The third command always returns the same error after several minutes of deploying and running instances:
12:22:40 | Compiling packages: haproxy/ad6e9e08a6d7a0f8951322f9a2ce394105df7fcf (00:21:36)
           L Error: CPI error 'Bosh::Clouds::CloudError' with message 'Timed out waiting for Server `98c9c450-4509-
464f-96a3-d4436799c74f' to be terminated, deleted' in 'delete_vm' CPI method
12:23:22 | Compiling packages: nginx/e77a07866c05979b49389fe36d66846411ba08a2 (00:22:18)
           L Error: CPI error 'Bosh::Clouds::CloudError' with message 'Timed out waiting for Server `d3037420-2cf4-
42a7-966a-c12109550bfe' to be terminated, deleted' in 'delete_vm' CPI method
12:23:56 | Compiling packages: golang1.7/46105d4480ca083a6cafb8ca307d5e5084c655c4 (00:22:52)
           L Error: CPI error 'Bosh::Clouds::CloudError' with message 'Timed out waiting for Server `2e3d702b-ca3f-
4739-9c9f-6c71f84fd08f' to be terminated, deleted' in 'delete_vm' CPI method
12:24:34 | Compiling packages: cli-network-policy-plugin/330209a6db78c64b3983e94a46b2586c05087bcc (00:23:30)
           L Error: CPI error 'Bosh::Clouds::CloudError' with message 'Timed out waiting for Server `e7e72526-e801-
4495-a71f-20cad630a5bb' to be terminated, deleted' in 'delete_vm' CPI method
12:25:32 | Compiling packages: cli/6e22370bfb380059b856a1b397bc14ae9ec1633c (00:24:28)
           L Error: CPI error 'Bosh::Clouds::CloudError' with message 'Timed out waiting for Server `3b4785aa-c6f6-
47aa-9c0e-9b51670eccc4' to be terminated, deleted' in 'delete_vm' CPI method

That certainly looks interesting. By default, the openstack-cpi waits for 5 minutes until resources have reached a certain state: http://bosh.io/jobs/openstack_cpi?source=github.com/cloudfoundry-incubator/bosh-openstack-cpi-release&version=33#p=openstack.state_timeout
Feel free to adjust the above value to something higher, such that you don't run into a timeout.
5 Minutes should be actually enough to delete a reasonable big disk. What kind of OpenStack are you running this on? Is this a virtualized environment or a DevStack?

Thanks @voelzmo for helping us.
We are using PackStack Ocata,  nova-manage --version 15.0.4.
We tried to set the state_timeout parameter in the cf-deployment.yml file:
compilation:
  cloud_properties:
    instance_type: m1.medium
  network: cf1
  reuse_compilation_vms: true
  workers: 6
director_uuid: d38df326-1fb8-4bfd-874a-f3c4eb8adf23
# [...]
properties:
    openstack:
        state_timeout: 1800

but it probably wasn't passed correctly to bosh-openstack-cpi (command: bosh -e bosh-1 -d openstack deploy cf-deployment.yml). We don't know where to set it.
We tried to change defaults in the source code: DEFAULT_STATE_TIMEOUT = 1800, but we don't know how to build custom release :)
Could you give us some tips?

We are going to try to change defaults in the source code: DEFAULT_STATE_TIMEOUT = 1800 and create the custom release using BOSH 2 command:
bosh create-release --force --tarball=/home/workspace/bosh-openstack-cpi-release.tgz

We'll let you know about the effects.

Hi @wildloop,
its a bosh director property. Should be at this level: https://github.com/cloudfoundry/bosh-deployment/blob/b1f8d1bfa95fee6c8b89c678781e94912c41b31a/bosh.yml#L46

Closing due to inactivity. Please re-open with new information when you need more help.

Thanks @beyhan, but this property (at level that you point) is not working for me.
Work around:

reduce the number of compilation workers:

 compilation:
  reuse_compilation_vms: true
  workers: 1

after timeout (waiting for server to be deleted)... wait until the server is actually deleted

repeat deploy command with the fix flag: bosh -e bosh-1 -d openstack deploy  --fix cf-deployment.yml

I have the same problem, I also want to change the state_timeout in my environment. Is it work on your environment?  Please let me know

Thanks

Hey @zhongjun2,
I'm not sure what you're asking. If you want to adjust the state timeout, you can adjust the property as mentioned in my comment above: https://github.com/cloudfoundry-incubator/bosh-openstack-cpi-release/issues/82#issuecomment-323102090
Does that solve your issue?

I got the following error, but my image status changed to 'active' after 10 minutes.
My question is how to change state_timeout: 300    to state_timeout: 3000.
Is it a env parameter?  export  state_timeout=30000?  It looks like it doesn't work. Do you have another advice?
bosh upload-stemcell bosh-openstack-kvm-ubuntu-trusty-go_agent?v=3541.9
Using environment '<IP_ADDRESS>' as client 'admin'
######################################################### 100.00% 444.56 MB/s 0s
Task 3
Task 3 | 11:00:02 | Update stemcell: Extracting stemcell archive (00:00:03)
Task 3 | 11:00:05 | Update stemcell: Verifying stemcell manifest (00:00:00)
Task 3 | 11:00:07 | Update stemcell: Checking if this stemcell already exists (00:00:00)
Task 3 | 11:00:07 | Update stemcell: Uploading stemcell bosh-openstack-kvm-ubuntu-trusty-go_agent/3541.9 to the cloud (00:05:51)
L Error: CPI error 'Bosh::Clouds::CloudError' with message 'Timed out waiting for Image c9bf26a2-ae67-4f10-b5d1-2fc04cba2373' to be active' in 'create_stemcell' CPI method Task 3 | 11:05:58 | Error: CPI error 'Bosh::Clouds::CloudError' with message 'Timed out waiting for Image c9bf26a2-ae67-4f10-b5d1-2fc04cba2373' to be active' in 'create_stemcell' CPI method
Task 3 Started  Thu Mar 22 11:00:02 UTC 2018
Task 3 Finished Thu Mar 22 11:05:58 UTC 2018
Task 3 Duration 00:05:56
Task 3 error
Uploading stemcell file:
Expected task '3' to succeed but state is 'error'
Exit code 1


[using stable PyTorch 1.9] RuntimeError: The expanded size of the tensor (64) must match the existing size (66) at non-singleton dimension 2.  Target sizes: [256, 66, 64].  Tensor sizes: [256, 66]

Regarding https://github.com/mvasil/fashion-compatibility/pull/13
If you run the code in the current stable version of PyTorch 1.9, we will have:
(fashcomp) [jalal@goku fashion-compatibility]$ python main.py --test --l2_embed --resume runs/nondisjoint_l2norm/model_best.pth.tar --datadir ../../../data/fashion/
/scratch3/venv/fashcomp/lib/python3.8/site-packages/torchvision/transforms/transforms.py:310: UserWarning: The use of the transforms.Scale transform is deprecated, please use transforms.Resize instead.
  warnings.warn("The use of the transforms.Scale transform is deprecated, " +
=> loading checkpoint 'runs/nondisjoint_l2norm/model_best.pth.tar'
=> loaded checkpoint 'runs/nondisjoint_l2norm/model_best.pth.tar' (epoch 5)
/scratch3/venv/fashcomp/lib/python3.8/site-packages/torch/nn/functional.py:718: UserWarning: Named tensors and all their associated APIs are an experimental feature and subject to change. Please do not use them for anything important until they are released as stable. (Triggered internally at  /pytorch/c10/core/TensorImpl.h:1156.)
  return torch.max_pool2d(input, kernel_size, stride, padding, dilation, ceil_mode)
Traceback (most recent call last):
  File "main.py", line 312, in <module>
    main()
  File "main.py", line 149, in main
    test_acc = test(test_loader, tnet)
  File "main.py", line 244, in test
    embeddings.append(tnet.embeddingnet(images).data)
  File "/scratch3/venv/fashcomp/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
  File "/scratch3/research/code/fashion/fashion-compatibility/type_specific_network.py", line 119, in forward
    masked_embedding = masked_embedding / norm.expand_as(masked_embedding)
RuntimeError: The expanded size of the tensor (64) must match the existing size (66) at non-singleton dimension 2.  Target sizes: [256, 66, 64].  Tensor sizes: [256, 66]

changed line 118 of type_specific_network.py
from:
norm = torch.norm(masked_embedding, p=2, dim=2) + 1e-10
to:
norm = torch.norm(masked_embedding, p=2, dim=2, keepdim=True) + 1e-10


ENH: Add NumberOfCorners and ComputeCorners() to BoundingBox

Added BoundingBox::NumberOfCorners, evaluated at compile time, which
was used to replace a run-time std::pow(2.0, VPointDimension) call.
Added BoundingBox::ComputeCorners(), returning an std::array of
points, to allow users to get the corners of a bounding box without
the performance cost of dynamic memory allocation of a point container.
Adapted GetCorners(), now doing a reserve of the expected number of
points, and calling ComputeCorners() to compute those corner points.
Replaced calls to GetCorners() by ComputeCorners(), in the
implementation of SpatialObject.

Honestly, I would prefer to just deprecate the old BoundingBox::GetCorners(), and then remove (if ITK_LEGACY_REMOVE) the data member m_CornersContainer, which is returned by GetCorners(). But is it still OK to deprecate functions for ITK5, today, May 17?

Wow, I wasn't even aware of this class...

@N-Dekker With good rational for deprecation justification, we can/should still deprecate functions.

@aylward Thanks for your feedback

I'm not a big fan of having "ComputeCorners()" compute and return one variable type and "GetCorners()" internally call ComputeCorners but simply return a different type.

Me neither. I would prefer to just remove the old "GetCorners()". But then, there should be legacy-support for a little while, right?
Various issues of the old "GetCorners()" are solved by the new "ComputeCorners()":

GetCorners() is non-const
GetCorners() has its own dynamically allocated data member, BoundingBox::m_CornersContainer, that should not be necessary
GetCorners() does not make optimal use of the fact that the number of corners is known at compile-time
GetCorners() returns a pointer, instead of the container itself, leaving it up to the user to check if the pointer is valid.

Technically it would be possibility to name the new member function "GetCorners()" as well, as an overload, because the new one is const!
Personally, I still think it's OK to name the new one "ComputeCorners()", as it does actually do computations, to estimate those corners.
I think a fixed size array (either std::array or FixedArray) is the most logical choice for the return type, as the number of corners are known at compile-time.

Agreed.
I think make old GetCorners LEGACY and then have the new one be either
GetCorners (my slight preference) or ComputeCorners.   I'll leave it to you
/others to decide which of those two options is most consistent with the
rest of ITK's API   @Matthew McCormick<EMAIL_ADDRESS>?  @Dzenan
Zukic<EMAIL_ADDRESS>s
On Fri, May 17, 2019 at 11:38 AM Niels Dekker<EMAIL_ADDRESS>wrote:

@aylward https://github.com/aylward Thanks for your feedback
I'm not a big fan of having "ComputeCorners()" compute and return one
variable type and "GetCorners()" internally call ComputeCorners but simply
return a different type.
Me neither. I would prefer to just remove the old "GetCorners()". But
then, there should be legacy-support for a little while, right?
Various issues of the old "GetCorners()" are solved by the new
"ComputeCorners()":

GetCorners() is non-const
GetCorners() has its own dynamically allocated data member,
BoundingBox::m_CornersContainer, that should not be necessary
GetCorners() does not make optimal use of the fact that the number
of corners is known at compile-time
GetCorners() returns a pointer, instead of the container itself,
leaving it up to the user to check if the pointer is valid.

Technically it would be possibility to name the new member function
"GetCorners()" as well, as an overload, because the new one is const!
Personally, I still think it's OK to name the new one "ComputeCorners()",
as it does actually do computations, to estimate those corners.
I think a fixed size array (either std::array or FixedArray) is the most
logical choice for the return type, as the number of corners are known at
compile-time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/InsightSoftwareConsortium/ITK/pull/892?email_source=notifications&email_token=AACEJL57RMEK6IZX7ZT3BL3PV3GONA5CNFSM4HNUWYXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVVDGDQ#issuecomment-493499150,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACEJLYAF57GXKFY6BJQ2T3PV3GONANCNFSM4HNUWYXA
.

--
Stephen R. Aylward, Ph.D.
Senior Director of Strategic Initiatives, Kitware, Inc., North Carolina
Kitware: Advancing the frontiers of understanding
by developing innovative open-source software platforms
and integrating them into research, processes, and products.

Technically it is possible to have both a const GetCorners() (the new member function) and a non-const GetCorners() (for legacy only), but I'm afraid that it would be very confusing.
@aylward Would you like GetCornerPoints(), for the new one?

I am fine with either GetCorners or ComputeCorners.

As I'm running out of time, I'll try to just finalize this PR (proposing ComputeCorners() and deprecating the old GetCorners()), and then leave it up to you all to rename the new member function afterwards, if you would like to.

Still need to add an extra commit to deprecate the old GetCorners().... Please wait

Allowed edits from maintainers. I think it's OK now, but you may edit, if you would like to. (Going offline now!)


Support loading test cases from git repository

Expected usage: atest run -p https://github.com/LinuxSuRen/api-testing/tree/master/sample --auth personal-token
We need to consider the git branch and auth. Usually, the branch name could found from the URL. We could manipulate the git repository via jenkins-x/go-scm.
UI
In many cases, people will deploy a private Gitlab, and provide it to the team. Having an oauth integration might be a good idea for the users. They could login with their own account. So, we don't need to consider the user management.
See also the similar issue https://github.com/LinuxSuRen/api-testing/issues/94

Read raw data from a git respository and unmarshall the raw content into Suits ?

Read raw data from a git respository and unmarshall the raw content into Suits ?

Yes, I'm thinking about making a git repository as the storage backend. So, we don't have a central storage. And users could choose a private git repository to store their test cases. For example, store them into a private Gitlab.

Read raw data from a git respository and unmarshall the raw content into Suits ?

Yes, I'm thinking about making a git repository as the storage backend. So, we don't have a central storage. And users could choose a private git repository to store their test cases. For example, store them into a private Gitlab.

Get it. Let me try to create a pr to handle it

Get it. Let me try to create a pr to handle it

Sure. I'm looking forward it.

In many cases,

I have a question:
atest run -p https://github.com/LinuxSuRen/api-testing/tree/master/sample
the [pattern ](https://github.com/LinuxSuRen/api-testing/tree/master/sample) will point to a specific yaml file or a directory?

In my view, some basic information of a git repo are necessary. Such as: repo URL, branch name, directory. For a private git repository, the auth is required as well.

hi @cestlive , you can create a new extension with the git feature. See also the existing ones:
https://github.com/LinuxSuRen/api-testing/tree/master/extensions

go-git/go-git is a good candidate too. For the extension part, developers could get the connection information from the following code:
https://github.com/LinuxSuRen/api-testing/blob/1e45dd165dc7c6e5bd21ab32d31a612e5da63715/extensions/store-orm/main.go#L85

Another solution is that making git repository as a SQL server. Such as: dolthub/dolt.

hi @cestlive , I'm going to take over this due to no active response in 3 month. Feel free to join me if you're still intested in it.


NEW Add FieldsValidator to ensure fields get validated

I've also created https://github.com/silverstripe/silverstripe-framework/issues/10908 for some follow-up breaking changes that should be made in CMS 6.
Issue

https://github.com/silverstripe/silverstripe-admin/issues/1539

Sorry, I add this comment as my suggestion / question in other PR.
But my small concern and question, will this solution work if user decided somehow to override parent method or add another validator.


Support for Rendering within a Shadow DOM

Do you want to request a feature or report a bug?
Request a Feature
What is the current behavior?
Currently the draft editor throws errors at various times when rendered within a shadow dom.
Here is a CodePen I created to simplify the issue. This shows both the errors thrown when mounting, as well as when trying to focus().
https://codepen.io/michael_cox/pen/OmBPBm
More information can be found in this ticket for react-shadow:
https://github.com/Wildhoney/ReactShadow/issues/31
A couple things I've found while diving into this:

document.documentElement is assumed to be present
onSelect doesn't seem to fire when mounted to a shadow dom

What is the expected behavior?
Ideally the draft editor can be loaded in a shadow dom with the same functionality as when rendered normally.
Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?
Testing draft 0.10.1 in Chrome 58, but I assume this is currently unsupported and would be an issue in any version.

Thanks for reporting this! This is not a priority for Facebook but we are open to pull requests that improve the support for Draft in the shadow dom.

For now I'm tagging this as a feature request rather than a bug, because we don't support the shadow dom right now.

@flarnie Hey!
This issue was opened more than 3 years ago. Do you know if shadow root support is planning or it is not in top priorities?
I guess it won't be a difficult task and some work can be copied from here https://github.com/ianstormtaylor/slate/pull/3749#pullrequestreview-459648387

Hello @flarnie , any update on this topic?

Hi @flarnie, any updates?

Any updates on this one?

Joining the "Any updates on this" queue.


Set hard limit for line wrapping

Is your feature request related to a problem? Please describe.
I'm trying to use pyhtml2md as a more performant replacement for html2text.  One current difference is that html2text will do a hard wrap at 78 (default) characters.
Describe the solution you'd like
It would be nice to be able to configure the line length limit and use it as a "hard stop" instead of having it somewhere between 80 and 100 characters.  It would be nice to be able to configure the line length limit and use it as a "hard stop" instead of having it somewhere between 80 and 100 characters.
Describe alternatives you've considered
I'm currently using python's textwrap module.  But its slow and a bit hacky.

Of course I can add an option for that

Should be implemented with this commit, I'll create a release tomorrow, if not, feel free to reopen this issue!


How to Install ResinOS in vmware?

I tried to do this:
qemu-img convert resinos.img -O vmdk resinos.vmdk

In the VMware Fusion menu > New... > More Options > Create a custom virtual machine
Select Other Linux 4.x 64-bit as OS
Use an existing virtual disk > Select 'resinos.vmdk' as disk > Continue > Customize Settings > Save
In the VM setting panel, select the Hard Disk > Advanced options >Set 'Bus type': IDE > Apply settings changes
Start VM

The virtual machine starts and I can ssh using ssh<EMAIL_ADDRESS>-p22222 but it takes me to a busybox that doesn't have docker or anything else.
I'm guessing this is because ResinOS is designed to boot and then install itself onto another hard drive. Is there a workaround to make this work in VMWare or alternatively an image version that is self-contained rather than an installer?

Are you using a NUC image? If yes, you are right. The default image is wrapped into a flasher which is intended to be burned on the internal device. You can use https://github.com/resin-os/resin-image-flasher-unwrap to get the image which you can boot directly.

Sorry for the late reply, that worked great, thank you :)


Some little fixes on the release

Added a thread id in the log.
If the server isn't functioning or the network is unavailable, we can resort to local sign in. This should partially address issue #15.

The name of the branch has nothing to do with contents it hold.

Well, in fact the second precaution only works if the server has a RE, but doesn't if the server gives a WA.

Let's temporarily close this issue, since the local sign in should take care of a few cases.


disable coredns loop plugin when testing noOverlayMode

Signed-off-by: samuel.elias<EMAIL_ADDRESS>

Coverage remained the same at 75.342% when pulling 9c7c01cd64213fc8e485952b411bce48455ae331 on samelias:coredns_loop into 3acc69b7b912d56b23250a4e5149a7232868a3b5 on contiv:master.


Change target_clusters to accept bool optional param target_highest

Allow targeting clusters with lowest value of given metric. Default is targeting highest value.
Results are shown above: cluster 1 is target and 2 is non-target.

target_highest = true
target_highest = false

Close #451

@ConnectedSystems I propose we close this PR and Issue#451 as this is already addressed in PR #463

Very efficient - thanks @Zapiano


Set user properties

It doesn't seem like there's method to to set user properties (for identified or non-identified users) (this endpoint specifically https://developer.mixpanel.com/reference/user-profiles).
Can we add this to the API?

Ah nevermind, I just realized that you get do mixpanel.getPeople().set(...)!


Finishing a keg by drinking the last of it does not trigger a KEG_ENDED event

Offending line
This should be moved after the drink calculation. Then it can make a determination if it should fire a KEG_VOLUME_LOW or a KEG_ENDED event depending on if it is empty or not.

Cleaning up some ancient issues. In case it is still of interest: Kegs ending, and the corresponding KEG_ENDED event, can only happen manually.

Why is that? All the information for sending the event is readily available in that call, just further down. Or would a separate KEG_EMPTY event be more appropriate?

Right now the semantics of KEG_ENDED indicate someone has manually marked the keg as finished (which in turn can trigger things in plugins, such as tweeting).
Another real-world consideration is that buggy controllers can sometimes over-report volume, which can be fixed by adjusting or canceling the drink. Automatically ending the keg would be an extra side-effect.
I'd be +1 to a patch adding a new event.


Fixed - The Bloom filter encounters an error if a contains() request …

issues/6197

Thanks for contribution!