Colorized output

Working on adding color to cibyl output
Appreciate your input on this.
Not sure if this will interfere when out to file.

I think that we should have some mechanism to turn off color output, in case for example the user wants to redirect the output to a file. I am not sure how we could do that, maybe having method in the Colors class that would set all the attributes to an empty string?

I think that we should have some mechanism to turn off color output, in case for example the user wants to redirect the output to a file. I am not sure how we could do that, maybe having method in the Colors class that would set all the attributes to an empty string?
That is actually a great idea.
I will explore it.
Thank you!


Proxy from environment variables is ignored if no_proxy or NO_PROXY environment variable is present

Current Behavior
Proxy is completly ignored in http request node from HTTP_PROXY env variable if NO_PROXY environment variable is present.
Expected Behavior
HTTP_PROXY and NO_PROXY works as expected.
Steps To Reproduce
set HTTP_PROXY and NO_PROXY vars and try to make request with http request node.
Example flow
No response
Environment

Node-RED version: 3.0.2
Node.js version: v12.22.12
npm version: 6.14.16
Platform/OS: official docker container node:12-alpine
Browser: Chrome

Problem seems to be here: https://github.com/node-red/node-red/blob/master/packages/node_modules/%40node-red/nodes/core/network/21-httprequest.js#L519
I have hostname telegram in no_proxy but because of this line request url api.telegram.org is a match for that method.

can you please provide an example.

What did you set NO_PROXY to
What did you set HTTP_PROXY to
What was the http request requesting to?

Proxy is completly ignored in http request node

Can you clarify what you mean by "proxy" here.  The proxy set in the HTTP Request node?  the PROXY setting in ENV var?
A demo flow and ENV settings would be useful to understand if there is really an issue or not.

Proxy configuration provided with ENV vars (HTTP_PROXY and NO_PROXY).
HTTP_PROXY is internal company proxy server.
NO_PROXY contains telegram,viber which are hostnames of other containers in docker-compose.
Tested url is https://api.telegram.org/bot/getMe
From what I understand if NO_PROXY contains any part of url used in request, proxy is ignored, which is wrong.
Expected NO_PROXY behavior is here (used in axios which we use in nodejs application with proxy in envs)
https://www.npmjs.com/package/proxy-from-env#no_proxy

@Steve-Mcl Is there anything else i can provide you for fixing this issue?

I think the issue is now well understood - thanks for the detailed information @Vovcharaa
The fix is relatively straightforward to apply - however we need to consider the impact this will have. We've supported this property for a long time without any issues raised. So either no-one has been using it, or they have used it and might rely on the existing partial-matching approach it uses.
If we change the behaviour to do more strict checking, it will break their flows. That is something we try to avoid - especially in a maintenance release.
Our default position on breaking changes is that they go into the next major release (4.x next April). But when it's a fix, we'd want to find a way to ship it sooner whilst minimising the disruption to users.
Options for us to consider:

Ship in a maintenance release (3.0.x) and risk breaking users
Ship in milestone release (3.1.x) and still risk breaking users - but with more ability to highlight the change
Ship in 4.x next April - as a breaking change that would be our default position - but that doesn't help you today

Another option would be, in 3.0.xintroduceNO_PROXY_STRICTas a new env var that behaves as you expectNO_PROXYto behave. We can then updateNO_PROXY` as a breaking change in 4.0 to match. That gives you a way to move forward sooner and avoids breaking other users.

Another option would be to introduce NO_PROXY_STRICT in 3.0.x/3.1.0 as a new env var that behaves as you expect NO_PROXY to behave. We can then update NO_PROXY as a breaking change in 4.0 to match. That gives you a way to move forward sooner and avoids breaking other users.

I think this is a reasonable direction Nick.
As a slight iteration - perhaps it might be sensible to keep this behaviour beyond v4 as it is well established (in node-red) & simply introduce the "stricktness" via a bool flag like PROXY_STRICT  that defaults to false in 3.1.x (i.e. as is now) and default it to true in v4.x?  If missing, we default to expected condition based on the version of node-red.
Note to self: double check how the built in proxy works - may have to apply PROXY_STRICT or introduce a checkbox in the proxy UI

A quick update for anyone following this thread.
I have this 95% complete but in doing this work a number of issues have been realised. I want to get this out there
Issues with the current *_proxy implementation in Node-RED:

In the http-request node, the proxy URL is only determined when the node is instantiated - meaning when using a dynamic URL, the proxy is NOT re-evaluated per request
no_proxy should not be case-sensitive

i.e. if no_proxy contains "example.com", then "example.com" and "EXAMPLE.COM" should both be excluded

no_proxy with protocols that have a default port are not considered

i.e. if no_proxy contains "example.com:443", then "https://example.com" should be excluded
i.e. if no_proxy contains "example.com:80", then "http://example.com" should be excluded
i.e. if no_proxy contains "example.com:1880", then "mqtt://example.com" should be excluded

Does not consider NPM proxy configuration at all

i.e. if npm_config_proxy is set, then it should be used
i.e. if npm_config_https_proxy is set, then it should be used
i.e. if npm_config_http_proxy is set, then it should be used
i.e. if npm_config_no_proxy is set, then it should be used

Doesn't consider https_proxy or HTTPS_PROXY

i.e. if https_proxy is set, then it should be used
i.e. if HTTPS_PROXY is set, then it should be used
i.e. incorrectly uses HTTP_PROXY 'http://http-proxy' when the url is 'https://example'

Incorrectly prioritises HTTP_PROXY over http_proxy. HTTP_PROXY is not always supported or recommended

i.e. if HTTP_PROXY and http_proxy are both set, then http_proxy should be used
Use lowercase form. HTTP_PROXY is not always supported or recommended

doesn't consider all_proxy or ALL_PROXY

i.e. if all_proxy is set, then it should be used
i.e. if ALL_PROXY is set, then it should be used

The proposed implementation is based on the following sources:

https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/ (GitLab)
https://www.npmjs.com/package/proxy-from-env (MIT License)

The proposed implementation proposal follows the following rules:

Support the following PROTOCOL_proxys

i.e. http_proxy, https_proxy, mqtt_proxy, ws_proxy, wss_proxy, mqtt_proxy, mqtts_proxy

Support all_proxy

i.e. if all_proxy is set, then all URLs will be proxied

Use comma-separated hostname[:port] values for no_proxy.

no_proxy should contain a comma-separated list of domain extensions proxy should not be used for
Each value may include optional whitespace.
port is optional and is inferred if the protocol has a default port (supports http, https, mqtt, ws, wss, mqtt, mqtts)
Use * to match all hosts

Support .example (host suffix)
Support sub.example (host sub domain)
Upper case forms of *_PROXY are supported but not recommended
Lower case forms of *_proxy will take precedence over upper case forms
Does not perform DNS lookups or use regular expressions
Does not perform validation on the *_proxy urls
Does not support CIDR block matching
Support IPv6 matching

Proposed means of use (open to discussion)

Presence of env var NODE_RED_PROXY_MODE with value of 'strict' or 'legacy'
Presence of settings.js entry proxyMode  with value of 'strict' or 'legacy'

Further testing has revealed more worrying issues with proxying.
TLDR;
As far as I can see, the HTTP Request node doesn't work with all proxies. Additionally, it seems the tests are flawed and the proxying is not ever tested.

@knolleary @hardillb I know you guys had some issues with tests and proxy when implementing GOT, could you please comment on my findings?  Am I missing something?

Long version...
Tests and modifications were carried out on both Windows 11 + nodeJS 16 AND alpine linux + nodeJS 18
(1) Run tests (as is) master 3.0.2
mocha test/nodes/core/network/21-httprequest_spec.js

All tests pass.
(2) Re-enable disabled parts of proxy tests
Currently, all lines msg.payload.headers.should.have.property('x-testproxy-header','foobar'); are disabled in 21-httprequest_spec.js.
After removing the comment marks, the tests now fail:
 1) HTTP Request Node
       protocol
         should use http_proxy:
     AssertionError: expected Object {
  'user-agent': 'got (https://github.com/sindresorhus/got)',
  'content-length': '3',
  host: 'localhost:10236',
  connection: 'keep-alive'
} to have property 'x-testproxy-header

PROBLEM: This suggests the HTTP Request node is NOT hitting the proxy
Since the tests complete when the header test is disabled, it suggests the proxy is not used. It is not altogether proof that the proxy is not working just that the onProxyReq was not called.
(3) changing the agent in http-request to ensure proxy is "hit"
Changing the proxy agents to use "http-proxy-agent" and "https-proxy-agent" packages (instead of "hpagent")
  1) HTTP Request Node
       protocol
         should use http_proxy:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/steve/github/node-red/test/nodes/core/network/21-httprequest_tests_enabled_spec.js)

This suggests the HTTP Request Node Agent is now calling to the proxy IP:PORT but in-fact the proxy lib being used in the tests doesnt actually work!
(4) Modify test _spec to use different proxy
Using "express" and "http-proxy-middleware", I rewrote the proxy endpoints in the tests
Now the proxied endpoint gets called, adds the x-testproxy-header header, calls to the proxied IP:HOST - all tests passing.

It's been a while, but I think the problem is as you found that the simulated proxy used in the tests was what didn't work, not that GOT didn't work with proxies.

It's been a while, but I think the problem is as you found that the simulated proxy used in the tests was what didn't work, not that GOT didn't work with proxies.

I (kinda) agree but if I am being honest, that is only due to lack of complaints. But the other part of me suspects that may be down to using proxies is far less common for most users.  I am just a little uncomfortable changing stuff in an area where the test dont work correctly.
The short of it:
In the efforts to be as close as possible to a "standard" (i.e. more like cURL - see previous post about "standards") while remaining compatible with legacy - I cannot confirm everything works unless I update the agent to "http-proxy-agent" and "https-proxy-agent" packages (instead of "hpagent") & include fixed up tests.
For a bit of a comfort blanket: http(s)-proxy-agent averages over 120M downloads per month (hpagent averages around 3M/mon) : https://npmcharts.com/compare/hpagent,http-proxy-agent,https-proxy-agent?interval=30
So I will raise a PR with the modifications I made to get all proxy tests working property along with this feature (and additional related tests for this feature). I will include a detailed description of reasons for choices & info that should be useful for DOCS once PR vetted & accepted (in principle)


Talk to Hermine teams for user stories

The result of the Hermine internal user research can be found here:
https://docs.google.com/spreadsheets/d/1BGRHsgQsOMS8QahhsivA7yB_ayR9TJiGn5AJF2uJgX0/edit?usp=sharing
https://docs.google.com/document/d/1bZQyHNYDCgPZtZZj-5bD0kCQlFLMhWYvnIBcAIzdaWQ/edit?usp=sharing

closed and moved to slack canvas


No active terminal buffer to attach to.

hello,
great plugin, thanks for sharing your hard work, looks like a great idea.
I have installed this as per the README and when I run a test the floating window appears saying "Running test" .. but it then disappears and nothing else happens.
If I try to attach a terminal is reports "No active terminal buffer to attach to.".
I am using neovim v0.7.2
Wondered if you knew what steps I could take to try to locate the cause of my problem?

Here too:
^I...m/site/pack/packer/start/ror.nvim/lua/ror/test/rspec.lua:32: in function 'get_examples'
^I...m/site/pack/packer/start/ror.nvim/lua/ror/test/rspec.lua:37: in function <...m/site/pack/packer/start/ror.nvim/lua/ror/test/rspec.lua:8>

Thanks for the issue, I think this should be fixed once I pushed my local code up. Currently on holiday so my laptop is not with me.

Please try with the latest main branch and see if it fixes the problem. Thank you.

Currently, there is no way to change the command used to execute the test, but here's the command this plugin is using to run a rspec test:
bundle exec rspec path/to/spec.rb --format j
bundle exec rspec path/to/spec.rb:line_number --format j

Do you mind sharing your spec file and also the output of running the above commands in your console?

It seems like it's an empty spec file is it? Cause I don't see any examples in the test result. Are you trying to attach to the terminal running the test? This is useful only when you put a debugger somewhere to debug your test. Otherwise, once the Running test on line ... indicator goes away meaning the test finish running and the terminal will no longer be there for you to attach to.

the spec file is not empty.. here is an example:
require "rails_helper"

RSpec.describe Organisation, type: :model do
  it { should_not allow_value("123").for(:notification_email ) }

when I run in a terminal, like so
bundle exec rspec spec/models/organisation_spec.rb:4 --format j
is see:
E, [2022-10-11T09:40:51.874589 #14536] ERROR -- : Failed to connect fluentd: getaddrinfo: Name or service not known
E, [2022-10-11T09:40:51.874688 #14536] ERROR -- : Connection will be retried.
{"version":"3.10.2","messages":["Run options: include {:locations=\u003e{\"./spec/models/organisation_spec.rb\"=\u003e[4]}}"],"seed":54145,"examples":[{"id":"./spec/models/organisation_spec.rb[1:1]","description":"is expected not to allow :notification_email to be ‹\"123\"›","full_description":"Organisation is expected not to allow :notification_email to be ‹\"123\"›","status":"passed","file_path":"./spec/models/organisation_spec.rb","line_number":4,"run_time":0.092197735,"pending_message":null}],"summary":{"duration":0.093451714,"example_count":1,"failure_count":0,"pending_count":0,"errors_outside_of_examples_count":0},"summary_line":"1 example, 0 failures"}

so looks ok.. except the STDERR output, perhaps that is causing the problem :shrug:

Glad that it's working, you can try updating the plugin again, the output shouldn't be there, I forgot to remove it while debugging the other day.
Customizing the command should be possible, but it might be tedious to make sure all the commands are returning the result this plugin is expecting. I am using overmind myself as well, what's the difference with and without overmind run?

what's the difference with and without overmind run?

I use overmind because its great but also as a common way help manage the enviroment vars across different projects (like and .env file but .overmind.env) .. so when running with overmind run I get a env I want

I see, I have been using overmind to run those processes defined in the Procfile.dev, but never use it to run the test.
To answer your question, I am open to PR to allow customizing the test command.


Added Georgian Flag

View Live Example on Codepen
Screenshot:

@bumbeishvili Hey!
Thank you for contributing. :smile: Apart from the fixes commented, see if you find a better alternative to + you have used. Flag doesn't look like one mentioned in Wikipedia. :blush:

@ManrajGrover
I have fixed commented issues, I will see if i find better alternative of + in the future

@bumbeishvili Awesome. I'll wait for further updates. :smile:


workflows: End-to-end test

This new workflow will run on a schedule to validate the linus and bpf-next trees. It will both generate the encodings for those trees and run the verification.
Successful run: https://github.com/bpfverif/agni/actions/runs/10374722808. To test it, I changed the triggers so that it triggers on a PR push.

Apart from the comments above, it looks good to me. Please feel free to merge it.


integrate drone with coveralls

we can drop travis at that point, as its quite a bit slower.

I’ll need access to the Coveralls config to work on this. Not sure if I’d need to change anything in Drone or not, but that access wouldn’t hurt. I’m not sure how either manages access, but if it’s easier, just create a generic “sixfeetup” account for us.


BETA new branch "newSkinVisual" for (new) plotting of skin events opened

Problem: need a reliable taxel address map for each skin patch
To do (?)

[x]  make a parent class for both skin events and samples
[x] read from file taxel map instead of hardcoding it
[x] draw contours of triangles
[x] (major) make also an iso plot with time

Closing since I made #78 to highlight the left issues.


[DOCFIX] Update unified namespace doc example comment

the alluxio fs ls -R / command with the R flag will list out the files recursively, including the /demo/hello file

alluxio-bot, merge this please

@Xenorith cherry-pick?

alluxio-bot, cherry-pick this to branch-2.7 please


Allow passing a file-like object to torchvision.io.video.read_video

🚀 The feature
As the title states, I'd like to be able to pass a file-like object to read_video.
Motivation, pitch
As far as I can see, there should be no issue allowing this, as pyav supports that. The current if not os.path.exists(filename): is the only thing preventing this, as I see it. It could be specially useful e.g. for webdataset, which currently extracts the videos to /tmp, but could also pass it directly from memory, which would be much more efficient.
I wonder if there is any reason to not expose this interface?
Alternatives
No response
Additional context
No response

Hi @voegtlel , thank you for the feature request. Can you detail exactly what you mean by a "file-like object"? What Python type would that be exactly? Thank you!

Hi @NicolasHug,
sure, but I can only refer to the documentation of pyav

av.open(file, mode='r', **kwargs)
Main entrypoint to opening files/streams.
Parameters:
file (str) – The file to open, which can be either a string or a file-like object.

Although I must admit, that this is misleading, because typing only states str as type, but the documented string says, that file-like objects are allowed. I believe they refer to io, which is also what I'd understand:

The io module provides Python’s main facilities for dealing with various types of I/O. There are three main types of I/O: text I/O, binary I/O and raw I/O. These are generic categories, and various backing stores can be used for each of them. A concrete object belonging to any of these categories is called a file object. Other common terms are stream and file-like object.

Do you think this is already handled by some of the private APIs like _read_video_from_memory ?
For context, the video decoders of torchvision aren't really maintained lately and we hope to provide better support for video decoding soon. It is possible for us to address some minor improvements as long as they're super easy, but big changes may not be in scope for torchvision. TBH, it's still not clear to me what exactly this feature request is about (i.e. what types need to be supported), so it's hard for me to give you a definite answer just yet

Thanks for the details.
OK, I guess we can move the     if not os.path.exists(filename): within the if get_video_backend() != "pyav": block and just let pyav do its own input checking.

@NicolasHug Thank you so much for the quick implementation! :) One week OOO and it's already in there, great! 👏


slightly cleaner fix for error spam

In lieu of #6330, this fix is slightly cleaner -- put the delay logic in to the UserKeysAPI logic.

meaning might you wind up double-waiting, once while the API call is out, and once after the err is handled?

I don't believe that can happen reading the Web code....

Yeah, double wait. If there's no risk of that then this looks good.


🐛 Bug: prettier-plugin-curly crashes on literate-ts repo

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Expected
I expected to be able to run pnpm format with prettier-plugin-curly on literate-ts.
Actual
$ npx prettier src/ts-checker.ts
src/ts-checker.ts
[error] src/ts-checker.ts: SyntaxError: ',' expected. (85:5)
[error]   83 |       const start = m.index + 1;
[error]   84 |       const end = start + m[1].length;
[error] > 85 |       errors.push({line: lastCodeLine, start, end, message});
[error]      |     ^
[error]   86 |     }
[error]   87 |   });
[error]   88 |   return errors;

Additional Info
Here's the file in question, no syntax errors in sight:
https://github.com/danvk/literate-ts/blob/5d04101f895285d838cb4cdccadc8941c86b0771/src/ts-checker.ts#L85
This was quite confusing because there's nothing in the error message indicating that the error is coming from prettier-plugin-curly, rather than prettier itself.

Basically this is caused by nested if statements:
if (a) {
	if (a) {
		if (a) {

		}
	}
}

become
if (a) { {
        if (a) {
                if (a) {

                }
        }
} }if (a) { {
                if (a) {

                }
        } }if (a) { {

                } }
        }
}

in older versions, and
if (a) {
        if (a) {
                if (a) {

                }
        }
}if (a) {
                if (a) {

                }
        }if (a) {

                }
        }
}

in 0.1.4.

@all-contributors please add @danvk for bug.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

To be extra confusing the reported error was 40 lines below the nested if statement.
BTW this bug was added in "prettier-plugin-curly": "0.1.4" while "prettier-plugin-curly": "0.1.3" is bug free with my code!

I'm hopeful that the refactors in #309 take care of any issues around nested nodes. It should change the parsing to avoid nested nodes altogether, and print modified ranges with @babel/generator.
Thanks for reporting & discussing everyone! This thread was quite useful. 😊


openContactForm function not support the formattedAddress in Android

I am using the latest version of react-native-contacts and as I said in the title the formattedAddress is not support in the openContactForm function.
Also, I checked the module and that is missing.
Please update the code asap.
Thank you

please submit a pr

I did, please check


⚠ Processors has degraded performance

In cd371e8, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 117 ms

Resolved: Processors performance has improved in 410fbb8.


Switch accounts used to authenticate Google Calendar for Teams add-on

I need to know how to switch the account used to authenticate the Google Calendar for Teams add-on in Google Calendar. I need to change it from a free personal account to my licensed work account but cannot find any way to do so in the Teams app or in Google Calendar.

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

It turns out that you can re-authenticate by using the Teams icon at the far left flyout menu. Problem solved!


Limited Support Commands

Currently the only way to enable limited support is via ocm API. This PR introduces three new commands to osdctl to make dealing with limited support easier for SRE:
1.  osdctl cluster support status <internalClusterID>
2.  osdctl cluster support post <internalClusterID> -t <limitedSupportTemplate.json>
3.  osdctl cluster support delete <internalClusterID> -i <limitedSupportReasonID>

Here's how I've tested this
❯ osdctl cluster support status 1sqen55r91ppvep84f3jcdpn7j1a3d8q
Reason ID                              Summary                             Details
54033567-eb32-11ec-af34-0a580a82040e   [Testing] Limited Support Summary   [snguyen - testing] Limited Support Details

❯ osdctl cluster support post 1sqen55r91ppvep84f3jcdpn7j1a3d8q -t lsReason.json
The following limited support reason will be sent to 1sqen55r91ppvep84f3jcdpn7j1a3d8q:{
  "id": "",
  "summary": "[Testing] Sample summary",
  "details": "[snguyen - testing] sample details"
}
Continue? (y/N): y
limited support reason has been sent successfully%

❯ osdctl cluster support status 1sqen55r91ppvep84f3jcdpn7j1a3d8q
Reason ID                              Summary                             Details
54033567-eb32-11ec-af34-0a580a82040e   [Testing] Limited Support Summary   [snguyen - testing] Limited Support Details
b3e251e8-eb59-11ec-90c3-0a580a820212   [Testing] Sample summary            [snguyen - testing] sample details

❯ osdctl cluster support delete 1sqen55r91ppvep84f3jcdpn7j1a3d8q -i 54033567-eb32-11ec-af34-0a580a82040e
limited support reason deleted successfully

Thanks for this, Sam. The functionality here looks good to me!

Per the discussion we had in the meeting to review this PR today, this looks good.
/lgtm


Analysis results not appearing

@urbanphes, ever since the Geocode workflow change, the Analysis results screen is not appearing after running the the Geocode analysis? I'm noticing this for all Geocode TYPES selected.
FYI: The Analysis results still appear correctly after other analysis (not Geocode) are run. However, there is some weirdness where I won't see the analysis results if I re-run an analysis?
Can you define the expected Analysis Results behavior? This impacts several use cases in Learn.

ahoy @csobier ! from now on @alonsogarciapablo will take care of this discussions, so as much background info on the topic you could provide it will be highly appreciated 🙏

I guess we're referring to this overlay with info about the result of the analysis:

I'm missing some context here but I talked to @matallo and he explained to me that right now that overlay is only displayed the first time a given analysis finishes.

This is already fixed.


hdmap

Q 1： 在 Apollo/modules/map/proto/ 下的  map_overlap.proto文件 ，   这块的overlap是怎么定义的？  对于人行横道 停止线 红绿灯等交叠区域怎么填充字段？  或者说怎么表征交叠区域这个字段信息。 有木有示意图或者示例说明。  ？

It is a bridge between the lane and others(lane, traffic light, stop sign). You can find the overlap ids in the lane, and then find its associated objects according to the overlap.
below is an example, you should also add overlap id in the associated objects 287a_1_-1 and 3038
overlap {
  id {
    id: "overlap_3794"
  }
  object {
    id {
      id: "287a_1_-1"
    }
    lane_overlap_info {
      start_s: 20.5262
      end_s: 20.8895
      is_merge: false
    }
  }
  object {
    id {
      id: "3038"
    }
    crosswalk_overlap_info {
    }
  }
}

Seems to be resolved, we will close this issue. If the problem persists, pls feel free to reopen it or create a new one and refer to it.


Breaking change in type alias with bound

The formatting of the declaration
type W<'a> = T::W<'a> where T: 'a;

changed in nightly-2024-09-22. The above code is formatted on stable, now it gets formatted to
type W<'a>
    = T::W<'a>
where
    T: 'a;

This was an expected change. Previously rustfmt didn't format type aliases that had trailing where clauses and now it does based on the prescription in the style guide.
For a full list of things that changed in the 1.8.0 release see the changelog.


feat(abigen-plugin): add support for auto-generating bindings for foundry projects

Description
closes #81

Solution

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#156  👈
#155
#154
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArtificialPB and the rest of your teammates on  Graphite


fix: login stays open sometimes

Why

Noticed during spotify decoupled flow, login modal stayed open.

Root cause
During login we do router.push(/login). router.pop was being done in a callback that would be called in a useEffect post login. Leading to weird race conditions.

How
We make sure to call router.pop in login() function synchronously instead of useEffect. This makes sure it works well with our promise based await loginPromise(); await onboardingPromise() setup.

Test Plan

Test music drop decoupled flow

do we need to rebuild the native app?

we can do a codepush!


feat(ci-cd): CI/CD | 010 - Setup Environments

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a01426c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   83.33%
=========================================
  Files             ?        3
  Lines             ?       48
  Branches          ?        8
=========================================
  Hits              ?       40
  Misses            ?        0
  Partials          ?        8

Flag
Coverage Δ

#unittests
83.33% <0.00%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01426c...7a75c73. Read the comment docs.


Persist swagger access token on local storage (#1799)

This done #1799

@ysmoradi
is the solution implemented in this PR a valid one?

PING! @msynk Could you please review?

PING! @msynk


Webview2: Window blur and focus event always firing when clicking a button

When clicking a button the blur and focus event always seem to fire on the window.

Steps to reproduce the bug

Create basic WinUI3.0 desktop app only embedding a Webview2 control
Set the source of the control to https://stackblitz.com/edit/window-focus-test-amkv5c?file=src/app/app.component.ts
In the right panel only click the button
Notice numbers are going up for the focus and blur event on the window as well

Expected behavior
Number should only increase for button clicks.
Other numbers should only increase if the focus is moved outside or back to the window.
Screenshots
Screenshot from WinUI app after clicking the button twice. Notice the blur and focus event being triggered as well.

Screenshot from Edge browser after clicking the button twice. Notice the blur event not being triggered and the focus event triggered once when user clicks the button and at same time gives focus to the window.

Version Info

Packaged WinUI3.0 Desktop app, WindowsAppSDK 8.0
NuGet package version:
WinUI 3 - Windows App SDK 0.8: 0.8.0

Windows app type:

UWP
Win32

Yes

Windows version
Saw the problem?

Insider Build (xxxxx)

October 2020 Update (19042)

May 2020 Update (19041)
Yes

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Xbox

Surface Hub

IoT

Additional context
This is imporant since now in our web app we listen to the blur event on the window to close some modal dialogs automatically when the focus moves to another window. This issue prevents the user of just clicking on the button because the dialog is already closed at the moment the button click event is being handled.
Also this works both in Edge and a Win32 C++ app (taken from here https://github.com/MicrosoftEdge/WebView2Samples/tree/master/SampleApps/WebView2APISample) so seems related to WinUI3.0. Hence I'm reporting it here instead of on the Webview2 feedback repo.

@koenvd This sounds like it might be a known issue where the WebView2 control thinks it loses focus when the Edge WebView2 inside it gets focus. It's something I'm actively working on -- clearly it has a lot of unfortunate side effects, like (probably) this one.

Thanks for the update and already working on this @krschau!
I think now #5570 is also probably one of the unfortunate side effects.
Leaving it up to you if you want to keep both issues open.

FYI but this also works on UWP with the backported Webview2 part of WinUI 2.7.0-prerelease.210827001.

FYI but still seems to fail with WindowsAppSdk v1.0.0-preview1.

Fixed in Windows App SDK 1.0.1, check out the release notes for more info.


popgenstat behavior is strange

I might be doing something quite stupid here, but it seems that popgenstat is returning strange results:
import dendropy
from dendropy.calculate import popgenstat
cm = dendropy.DnaCharacterMatrix()
cm.from_dict({'a': 'AT', 'b': AA})
popgenstat.num_segregating_sites(cm)

This returns
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/tiago_antao/anaconda3/lib/python3.6/site-packages/DendroPy-4.2.0-py3.6.egg/dendropy/calculate/popgenstat.py", line 171, in num_segregating_sites
    ignore_uncertain)
  File "/home/tiago_antao/anaconda3/lib/python3.6/site-packages/DendroPy-4.2.0-py3.6.egg/dendropy/calculate/popgenstat.py", line 116, in _num_segregating_sites
    for i, c1 in enumerate(char_sequences[0]):
IndexError: list index out of range

Am I forgetting something obvious?

ping @martavohnoutova

Hi @tiagoantao
This may be poor documentation on our part, but from_dict is actually a factory function that returns a DnaCharacterMatrix, rather than a method to populate an existing character matrix. So, your code should look more like this:
#! /usr/bin/env python
# -*- coding: utf-8 -*-
import dendropy
from dendropy.calculate import popgenstat
cm = dendropy.DnaCharacterMatrix.from_dict({'a': 'AT', 'b': "AA"})
popgenstat.num_segregating_sites(cm)

No, the documentation is correct.
 Sorry


Python2.7 install fails on Antergos(Arch Linux)

Because of problems below, build fall into error.

Arch Linux's gcc is too new (8.2.1),
rpc/rpc.h
libssl

Maybe this is difficult to solve now so, I write a current solution.
I hope this post will help you faced similar problems.
sudo pacman -S gcc7
export CC=/usr/bin/gcc-7
export CXX=/usr/bin/g++-7
export CFLAGS=-I/usr/include/tirpc
asdf install python 2.7.13

Hi, sorry for the delay. The actual build is handled by python-build so hopefully it will be fixed upstream.


Adds a content-type assertion to the multi-part request

Good enough for now, would be nice to get something more robust in eventually but this should catch most stuff really 🤙🏻


Enforce compact style naming of class and module children

This came up in a discussion we had on Platform Health during review of a PR (https://github.com/alphagov/local-links-manager/pull/421#discussion_r2776071940).
I prefer this style of naming classes as I think it looks cleaner and avoids unnecessary indentation and module lines at the top and bottom of the file.
The downside to enforcing this is that classes defined in this way can't be loaded until the parent module has already been defined. In practice, with Rails autoloading, this means that each module would need its own file module.rb containing just module ModuleName; end.
There are both styles currently present in the GOV.UK code base:

https://github.com/alphagov/local-links-manager/blob/be4ad1f3bc0dee0d73f50c0819c89cb0af8c0584/lib/local-links-manager/import/links.rb#L3-L5
https://github.com/alphagov/publishing-api/blob/fbd0e07dc3aaec156b8361d5e157ec1775ff6550/lib/link_expansion/link_reference.rb#L1

We should decide on a style and enforce it using govuk-lint. Personally, I prefer the compact style but if the majority would prefer the nested style, we can enforce that instead.

@thomasalanlee I like the compact style too, mainly for the reasons you said and because it makes it easier to find where a class is defined (especially useful in big codebases). For example, if in the code you find Module::Class.new.foo, you can search the entire codebase for Module::Class (cmd+shift+F in atom) and find
classe Module::Class
  def foo
    # ...
  end
end

whereas with the nested style you wouldn't.
As per the downside you mentioned, it will be short lived. The new autoloader for Rails 6, Zeitwerk, will solve this:

Directories without a matching Ruby file get modules autovivified automatically by Zeitwerk. For example, in app/controllers/admin/users_controller.rb -> Admin::UsersController, Admin is autovivified as a module on demand, you do not need to define an Admin class or module in an admin.rb file explicitly.

See also Xavier Noria's post.

@thomasleese I like the compact style too, mainly for the reasons you said and because it makes it easier to find where a class is defined (especially useful in big codebases). For example, if in the code you find Module::Class.new.foo, you can search the entire codebase for Module::Class (cmd+shift+F in atom) and find
classe Module::Class
  def foo
    # ...
  end
end

whereas with the nested style you wouldn't.
As per the downside you mentioned, it will be short lived. The new autoloader for Rails 6, Zeitwerk, will solve this:

Directories without a matching Ruby file get modules autovivified automatically by Zeitwerk. For example, in app/controllers/admin/users_controller.rb -> Admin::UsersController, Admin is autovivified as a module on demand, you do not need to define an Admin class or module in an admin.rb file explicitly.

See also Xavier Noria's post.

Handy!

@AlanGabbianelli That's good to know! Since merging this is likely to cause a lot of our apps to start failing the linter, perhaps we should wait until Rails 6 before making this change? That way we don't have to create all those small module files. Rails 6 is due at the end of this month anyway.
And @elliotcm I'll see what we can do about including a nice message in the linting output.

@AlanGabbianelli That's good to know! Since merging this is likely to cause a lot of our apps to start failing the linter, perhaps we should wait until Rails 6 before making this change? That way we don't have to create all those small module files. Rails 6 is due at the end of this month anyway.
And @elliotcm I'll see what we can do about including a nice message in the linting output.

@thomasleese Don't worry too much about it if there's a built-in solution coming that soon.

Seems reasonable, it's not something I'm massively opinionated on. It's easier to read in nested form but I do think it's disadvantaged of not knowing whether you're dealing with a module or a class in a namespace.
I was wondering whether you've tried running this rule against some of our codebases to see if you get any annoying cases? apps I'd consider trying it on are Whitehall, Publishing API and Search API

Closing until nearer the time.


ngAnimate leave class removed before element is removed from the DOM

When running $animate.leave(element) (in Angular 1.2.16), the following events occur in order:

.ng-animate is added to the element.
.ng-leave is added to the element.
.ng-leave-active is added to the element.
The element animates.
.ng-leave-active is removed from the element.
.ng-leave is removed from the element.
.ng-animate is removed from the element.
The element is removed from the DOM.

On mobile, this ordering is causing the element to flash to a pre-animation state between steps 5 and 8 due to the .ng-leave classes being removed.
Particularly in the case of ng-leave, since the element is being removed from the DOM it should be possible to avoid removing those classes to ensure that the element is removed from the DOM without there being any point in time where the classes are not applied.

Closing due to lack of feedback.


Should we use invariantIgnoreCase when checking if the header contains "application/x-www-form-urlencoded" ?

Should this do something like
StringComparer.OrdinalIgnoreCase.Equals("application/x-www-form-urlencoded", request.Content?.Headers.ContentType?.MediaType)
To catch the cases when the header is sent with different casing? The spec explicitly calls out this as all lowercase, but not sure if all implementations will follow it.
We should also move that string to a constant.

Fixed with #19


⚠ Bofrost.de has degraded performance

In 2b820be, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1480 ms

Resolved: Bofrost.de performance has improved in 848cfeb after 16 minutes.


Web: At end of step 5, tell users which directory to configure

At the end of step 5, the doc tells the user to run
$~> firebase use --add
and then to "select your Project ID and follow the instructions". The tool will ask
What alias do you want to use for this project? (e.g. staging)
which confuses some users, as they don't know what to enter and there is no guidance in the doc. I propose including an instruction telling users to enter "." (current directory) at this prompt.

Fixed :) added a  suggestion for this


fix: Unable to do addSegment and then do ('PV1.1', ) --> Invalid Index

const message = new Message({
    messageHeader: {
      msh_9_1: "ADT",
      msh_9_2: "AO1",
      msh_10: "CONTROL_ID"
    }
  })

  let segment = message.addSegment('PV1')
  segment.set('PV1.1', 1) // this should be a valid since it's not MSH, BHS, or FHS.

Current getting error:
Can't have an index < 1 or not be a valid number.
HL7FatalError: Can't have an index < 1 or not be a valid number.
    at Segment.writeCore (/Users/userdirectory/Documents/projects/GIT.nosync/fastify-hl7/node_modules/node-hl7-client/lib/cjs/builder/modules/segment.js:100:19)
    at Segment.write (/Users/userdirectory/Documents/projects/GIT.nosync/fastify-hl7/node_modules/node-hl7-client/lib/cjs/builder/modules/nodeBase.js:183:21)
    at Segment.set (/Users/userdirectory/Documents/projects/GIT.nosync/fastify-hl7/node_modules/node-hl7-client/lib/cjs/builder/modules/segment.js:71:22)
    at Object.<anonymous> (/Users/userdirectory/Documents/projects/GIT.nosync/fastify-hl7/__tests__/fastify.tests.ts:31:14)
    at Promise.then.completed (/Users/userdirectory/Documents/projects/GIT.nosync/fastify-hl7/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/Users/userdirectory/Documents/projects/GIT.nosync/fastify-hl7/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/Users/userdirectory/Documents/projects/GIT.nosync/fastify-hl7/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async _runTest (/Users/userdirectory/Documents/projects/GIT.nosync/fastify-hl7/node_modules/jest-circus/build/run.js:252:3)
    at async _runTestsForDescribeBlock (/Users/userdirectory/Documents/projects/GIT.nosync/fastify-hl7/node_modules/jest-circus/build/run.js:126:9)
    at async run (/Users/userdirectory/Documents/projects/GIT.nosync/fastify-hl7/node_modules/jest-circus/build/run.js:71:3)
    at async runAndTransformResultsToJestFormat (/Users/userdirectory/Documents/projects/GIT.nosync/fastify-hl7/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at async jestAdapter (/Users/userdirectory/Documents/projects/GIT.nosync/fastify-hl7/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at async runTestInternal (/Users/userdirectory/Documents/projects/GIT.nosync/fastify-hl7/node_modules/jest-runner/build/runTest.js:367:16)
    at async runTest (/Users/userdirectory/Documents/projects/GIT.nosync/fastify-hl7/node_modules/jest-runner/build/runTest.js:444:34)

Need to figure out where it is. I check the based NPM that I used as a base, but can't find the cause. Backlog for now..

Still failing... help!


Fix status icon for HTMLHint and CSSLint when there are no problems.

The HTMLHint and CSSLint main functions return a 0-length array when there are no problems. This causes the status icon to show the yellow "warning" sign, but the tooltip to indicate that there are 0 problems.

I added checks for this condition to both plugins.

This is a great find.  But I think we are probably better off checking in lintIndicator itself so that plugins arent concerned with the fact that en empty array and not retuning has a different behavior.
We can probably do the change right here https://github.com/MiguelCastillo/Brackets-InteractiveLinter/blob/master/lintIndicator.js#L61
Basically check change the check to
        if (messages && messages.length) {
            setStatus(INDICATOR_STATUS.WARNING);
            $statusBarIndicator.attr('title', StringUtils.format(INDICATOR_TOOLTIPS.WARNING, messages.length));
        }
        else {
            setStatus(INDICATOR_STATUS.OK);
            $statusBarIndicator.attr('title', INDICATOR_TOOLTIPS.OK);
        }

Fixed with https://github.com/MiguelCastillo/Brackets-InteractiveLinter/pull/130

I'll be out for a few hours, I'll test it as soon as I get back to my computer. Thanks!


linuxKernel.kernels.linux_lqx: 6.5.6-lqx1 -> 6.5.7-lqx1

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

CC @thiagokokada if you want to look over it.

My Git client is seemingly not able to understand git fetch upstream properly. In this branch, zen is at 6.5.6-zen2 again. Does that matter?


Request: Map input

Can I request for a map input?
Thanks in advance.

I'll see how soon I can be able to implementation.
Again, great idea. Thanks for the contribution.

Thanks for the consideration!

@danvick have you made any progress on this?

I've created this in a separate package, have a look at it here
Kindly note that the package is still work in progress and suggestions and PRs are welcome.

@danvick,  Thank you.  I will look at it and provide updates or feedback.


Add template to Cloudflare repository

Add Hono's starter template to cloudflare/templates https://github.com/cloudflare/templates

Enough to use our original repository.
npm init cloudflare my-app https://github.com/honojs/hono-minimal


Fix/support init scripts with quotes

Fixes https://github.com/loambuild/loam/issues/130
Adds subcommand support and uses shlex to parse the arguments so that it properly respects quoted string arguments.
Limitations
This will not work if you escape quotes inside of quotes. The escaped characters get stripped out by the toml parsing. If you need double quotes in an argument you will need to use single quotes. Or you can escape the escape characters.
To get the init script in the issue to work use this:
[development.contracts.data_feed]
client = true
init = """
admin_set --new-admin me
sep40_init --resolution 300000 --assets '[{"Stellar": "$(stellar contract id asset --asset native)"} ]' --decimals 14 --base '{"Stellar":"$(stellar contract id asset --asset native)"}'
"""

Another limitation is that I run the subcommands through sh if on linux and cmd if on windows. Perhaps we could add an argument to pass the preferred shell. Also, if the subcommand errors, program execution will stop and the error will be printed.

One thing I was thinking about is how if the init script fails, it wont be rerun on subsequent build commands since the alias for the contract will be present. This makes me think perhaps we should add a --force-init or something of that nature in case the user wants to force it to be run.

One thing I was thinking about is how if the init script fails, it wont be rerun on subsequent build commands since the alias for the contract will be present. This makes me think perhaps we should add a --force-init or something of that nature in case the user wants to force it to be run.

yeah, I agree that would be nice. Separate PR for it?

This looks good enough for me. The ideal way to solve this is (and perhaps I can take a look at it since I did it for smartdeploy) to extract the clap logic from stellar-cli, we could also see about exposing it. This way we don't need to use Command since we can parse the data and do the invoke directly.


Add go.mod

Summary

This PR adds go.mod to start using go modules in this project. No need to include a new version because by now we don't have dependencies
Ticket Link

@metanerd Oh, cool. Add a new Jira ticket with the Mattermod revamp label :D


[Bug] "Release Notes" link in iOS 404's

Problem:
The "Release Notes" link 404's if clicked on in iOS apps.
Expected Response:
The "Release Notes" link opens a release notes page.
Actual Response:
The "Release Notes" link reaches a Github.com 404 error page.
Workarounds
Visit the release notes page manually, but otherwise no.
Possible Corrections
It seems the dynamic URL builder in this section is prone to error since it requires making sure the Github tag exists first. This URL should Fall back to https://github.com/Ranchero-Software/NetNewsWire/releases perhaps if the tag is unavailable from Github?
Related Issues
Related to #3814

@brentsimmons You have already changed the release notes URL to https://github.com/Ranchero-Software/NetNewsWire/releases/ in https://github.com/Ranchero-Software/NetNewsWire/commit/799d3f38946b6c424f54575a711ad7c7583c601e. Has this issue been resolved?


tileset.json lat/lng

Hi, I'm able to convert obj to 3dtiles. but not sure how to setup the bounding and geometricError in tileset.json. Should I get it from the .obj or what is the way to setup tilesetoptions. Thanks

Hi, Yang.
You can set these parameters in customTilesetOptions.json file, and here is the full optional parameters list.
Hope that can make some help, BW.

@CrashedBboy
I just get a transform matrix by a Cesium giving function, if you want know more detail about the matrix, may be you can search TRS Matrix.

Hi @PrincessGod. cesium's demo tileset options is like this("Longitude": {
"minimum": 2.0818461850713565,
"maximum": 2.0819858114115157
},
"Latitude": {
"minimum": 0.4551993222126411,
"maximum": 0.4553389485528006
})  ,but customTilesetOptions.json longitude and latitude is only support number. so how to use customTilesetOptions.json when I have bounding info of min/max latlng.


Tidy up CHANGELOG.md

Sorted 3.1.1 items by their language
Minor consistency tweaks (phrasing, markup)
Linkified 3.1.1 release heading

Dunno WTF happened with the original title!  Fixed.  Oh well. :P


feat: snippets for argocd integration

@ilan-pinto this needs rebasing.

Looks good.
What about tests?
I think we mentioned we should add unit tests for the new command. Something similar to what we have for the newProject command: https://github.com/open-cluster-management-io/ocm-vscode-extension/blob/main/test/test-files/commands/new.project.test.ts.


amtm, after upgrading 3.6, there will be intermittent network disconnection

amtm, after upgrading 3.6, there will be intermittent network disconnection, hope to fix it, thank you

I'm afraid I don't know what you say. What does "3.6" mean? I guess it may be a version number, but the latest version of AriaNg is just 1.3.4.

AMTM, 3.6 is a program of ASUS router, Asuswrt-Merlin firmware. Upgrading to the latest version of the Entware platform will experience intermittent network outages.
发自我的 iPhone
在 2023年5月6日，20:59，mayswind @.***> 写道：

I'm afraid I don't know what you say. What does "3.6" mean? I guess it may be a version number, but the latest version of AriaNg is just 1.3.4.
—
Reply to this email directly, view it on GitHubhttps://github.com/mayswind/AriaNg/issues/716#issuecomment-1537137106, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQYZPEGEVKMF5G72CGJ2Q7DXEZDJRANCNFSM6AAAAAAXYBRJLA.
You are receiving this because you authored the thread.Message ID: @.***>

AMTM, 3.6 is a program of ASUS router, Asuswrt-Merlin firmware. Upgrading to the latest version of the Entware platform will experience intermittent network outages. 发自我的 iPhone 在 2023年5月6日，20:59，mayswind @.> 写道：  I'm afraid I don't know what you say. What does "3.6" mean? I guess it may be a version number, but the latest version of AriaNg is just 1.3.4. — Reply to this email directly, view it on GitHub<#716 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQYZPEGEVKMF5G72CGJ2Q7DXEZDJRANCNFSM6AAAAAAXYBRJLA. You are receiving this because you authored the thread.Message ID: @.>

I think you should go to the firmware developer for help, I cannot do anything about your problem.

Ok,thank you
发自我的 iPhone

在 2023年5月8日，11:25，mayswind @.***> 写道：
I think you should go to the firmware developer for help, I cannot do anything about your problem.


FutureWarning in ordinal encoder when downcasting objects

Expected Behavior
No FutureWarning is thrown.
Actual Behavior
Currently the following warning is thrown.
category_encoders/ordinal.py:198: FutureWarning: Downcasting object dtype arrays on .fillna, .ffill, .bfill is deprecated and will change in a future version. Call result.infer_objects(copy=False) instead. To opt-in to the future behavior, set `pd.set_option('future.no_silent_downcasting', True)`
  X[column] = X[column].astype("object").fillna(np.nan).map(col_mapping)

Neither suppressing warnings, setting the pandas option or changing the types on caller side is sufficient for correctness.
Steps to Reproduce the Problem

create data frame with object dtype.
fit  data frame to CountEncoder (or similar)
notice the warning

Specifications

Version: 2.6.3

For what it's worth, these local changes fixed things for me & kept tests passing.
diff --git a/category_encoders/ordinal.py b/category_encoders/ordinal.py
index 45d333e..94804c0 100644
--- a/category_encoders/ordinal.py
+++ b/category_encoders/ordinal.py
@@ -195,7 +195,7 @@ class OrdinalEncoder(util.BaseEncoder, util.UnsupervisedTransformerMixin):

                 # Convert to object to accept np.nan (dtype string doesn't)
                 # fillna changes None and pd.NA to np.nan
-                X[column] = X[column].astype("object").fillna(np.nan).map(col_mapping)
+                X[column] = X[column].astype("object").infer_objects(copy=False).fillna(np.nan).map(col_mapping)
                 if util.is_category(X[column].dtype):
                     nan_identity = col_mapping.loc[col_mapping.index.isna()].array[0]
                     X[column] = X[column].cat.add_categories(nan_identity)

Thanks for reporting!
Your proposed fix seems fine, but I wonder whether something else might be better. The cast to object is just there (according to the comment) to accommodate np.nan as the fill, and we're about to map to numeric, so the dtype itself isn't critical information, and downcasting in particular isn't needed. Should we just opt in to the future behavior?


docs(gcb): Adds provisional instructions for trigging pipelines on Go…

…ogle Cloud Build builds.
We obviously need to make this way easier, but here's how one could do pipeline triggers from GCB using GCB's pubsub topic.
cc @duftler @skim1420
Rendered Preview:

+1, but I don't see how we don't expose the underlying implementation here.
Lars, would you be opposed to hal config ci gcb --subscription ____ --projectID ____ --jsonPath ___?
On Fri, Aug 17, 2018, 8:33 AM Lars Wander<EMAIL_ADDRESS>wrote:

@lwander commented on this pull request.
In setup/ci/index.md
https://github.com/spinnaker/spinnaker.github.io/pull/975#discussion_r210894272
:

@@ -22,6 +22,7 @@ independently of one-another, enumerated below.

These are the CI systems currently supported by Spinnaker:
I would say GCB should be classified as a supported CI system since we
can not only trigger off of builds, but also consume artifacts produced by
it.
If we want to add hal commands to give it the appearance of a typical CI
system, that's definitely worth doing and thinking over as we simplify our
artifact flows to abstract event streams into trigger types (i.e. a user
should be thinking of getting a docker image from GCB, not translating a
pub/sub message from a certain subscription).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spinnaker/spinnaker.github.io/pull/975#discussion_r210894272,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMiGLhHbtiER8G1efXJdSUklIzv5ZiXjks5uRrgTgaJpZM4V-vDL
.

That sounds good - but let's wait to implement that until we decide how we refactor triggers. For now I think it's OK to treat it as pub/sub until we have something better. In the end, we will always leave pub/sub as an escape hatch for more advanced use cases.

@dorbin Quick ping on this? spinnaker/echo#319 has been merged now, and it would be great if searching for "Cloud Build" in the Spinnaker site would explain how to use this new integration

dorbin approved these changes 18 hours ago

@ttomsu @lwander Is the content still accurate?

@demobox Yup

Gonna go ahead and merge this. Ultimately, we want docs in /guides/user/ for how to trigger, but in the mean time this is useful, and as @demobox points out it gets gcb into site search results.

Looks good to me!

Gonna go ahead and merge this

Thanks, all!


Adding feedback option

Description

in submit query there is showing 404 error so in that adding rate us and feedback options
Screenshots
Assign this to me under gssoc ext
Checklist

[X] I have starred the repository
[X] I have checked the existing issues
[X] I have read the discussion tab thoroughly and got the project idea
[X] I am willing to work on this issue (optional)

Please assign this task to me.


Complete remaining conversion of unified_mode resources

These are the only resources not done yet:
./windows_env.rb
./windows_feature.rb
./windows_package.rb
./windows_path.rb
./windows_service.rb
./windows_task.rb
./windows_workgroup.rb

Done


Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../miniconda3/envs/esmvaltool-fromlock/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
esmvaltool/diag_scripts/climate_patterns/climate_patterns.py:41: in <module>
    from plotting import (
E   ImportError: cannot import name 'plot_timeseries' from 'plotting' (/home/runner/work/ESMValTool/ESMValTool/esmvaltool/diag_scripts/arctic_ocean/plotting.py)
____ ERROR collecting esmvaltool/diag_scripts/climate_patterns/plotting.py _____
import file mismatch:
imported module 'plotting' has this __file__ attribute:
  /home/runner/work/ESMValTool/ESMValTool/esmvaltool/diag_scripts/arctic_ocean/plotting.py
which is not the same as the test file we want to collect:
  /home/runner/work/ESMValTool/ESMValTool/esmvaltool/diag_scripts/climate_patterns/plotting.py
HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules

All the checks were passing on the PR. Is it possible to update the PR checks to catch issues like this?
I will open a PR now with a fix 😊

I have been looking into this issue and have discovered the following:

For historical reasons, pytest defaults to the prepend import mode instead of the importlib import mode pytest recommends for new projects. This results in a drawback; test files must have unique names, see https://docs.pytest.org/en/7.1.x/explanation/goodpractices.html#choosing-an-import-mode.
Due to the specification of the --doctest-modules option for pytest in ESMValTool's setup.cfg file, pytest imports the code, meaning our code files must also have unique names (so the above situation, where a diag_scripts/arctic_ocean/plotting.py module exists alongside a diag_scripts/climate_patterns/plotting.py module, would not be possible).
A workaround is to add __init__.py files to your tests folder and subfolders (in our case that would be the diag_scripts folder and subfolders), changing them to packages. (Note there is also a diag_scripts/autoassess/stratosphere/plotting.py module, but the diag_scripts/autoassess/stratosphere/ directory contains an __init__.py file, so the plotting.py module here retains its namespace.)
However, given pytest recommends importlib for new projects, and that they did intend for this mode to be the default mode, see https://docs.pytest.org/en/7.1.x/explanation/pythonpath.html#import-modes, I would suggest making the following change to enable this:

diff --git a/setup.cfg b/setup.cfg
index c738c5d71..e28f8079a 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -1,5 +1,6 @@
 [tool:pytest]
 addopts =
+    --import-mode=importlib
     --doctest-modules
     --ignore=doc/sphinx/source/conf.py
     --cov=esmvaltool

This causes different import errors, e.g.:
__________________ ERROR collecting esmvaltool/diag_scripts/climate_patterns/climate_patterns.py ___________________
ImportError while importing test module '/ESMValTool/esmvaltool/diag_scripts/climate_patterns/climate_patterns.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
esmvaltool/diag_scripts/climate_patterns/climate_patterns.py:40: in <module>
    import sub_functions as sf
E   ModuleNotFoundError: No module named 'sub_functions'

which will need updating. I would be happy to do this, but I would like some input from the @ESMValGroup/technical-lead-development-team whether you would prefer absolute or relative imports. For example:

Absolute import fix:

    import esmvaltool.diag_scripts.climate_patterns.sub_functions as sf

Relative import fix:

    import .sub_functions as sf

I like absolute imports, as it's really clear what is being imported, but the relative imports make it easy to relocate subpackages without needing to edit import statements in modules within the subpackage.
What are your preferences? 🤔

Pep8 recommends absolute imports, so those should be preferred: https://peps.python.org/pep-0008/#imports
Maybe you could use some of the changes from #3646

Pep8 recommends absolute imports, so those should be preferred: https://peps.python.org/pep-0008/#imports

Great!

Maybe you could use some of the changes from #3646

Yes, I see about 15-20 import changes within the diag_scripts directory that appear to align with changes from #3646; would you be happy for me to capture those in a new PR against this issue so we can solve the failing tests on main, please? 😊


Handle multiple chart in PNChartDelegate

I think that the delegate should handle multiple charts (as Objective-C usually does), actually it necessary to have multiple delegate.
userClickedOnPieIndexItem(pieIndex: Int)

Should be
userClickedOnPieChart(pieChart:PNPieChart, index: Int)

Do you agree?

Yes you are right

Currently, the pie Chart supports only one dimensional dataset. Any suggestion how to achieve multiple datasets? Or if you can quickly put up rough code to draw interactive graph like this...

Here is the jsfiddle using d3.js
http://jsfiddle.net/wuhbamnc/


[staging & production] Text hangover in add links modal

Similar to #1778
Steps

Go to project on which you have admin access
From the Project Overview page, click "Add Links" from the toolbar on the right
On staging, search for "super" and then click "supercalifragilisticexpialidocious"
Click the plus sign to add the link.

Expected
I expect that all text will stay within the modal outlines.
Actual
Some text hangs over if the name is long:

Hi Natasha, I just tried to replicate the bug, but it didn't show me the same problem. And also I don't see the example link --"supercalifragilisticexpialidocious" any more. Is it because of the length of the name?

Hi Haoyu, I'm able to replicate it on staging and on production. If you search for just "super" when on staging, that project will appear and you'll see that the name extends past the modal. The same problem occurs on production (I just created a private sample project with a similar name) and it extends past the modal, as well. If you have trouble replicating again, come and find me!


[QUESTION] CI of pull requests

Question
I am working on adding Azure AD support to the Go language SQL server driver and a question that has come up in that project is how to do continuous integration for future pull requests.
I see this project has a continuous integration system set up for pull requests that runs in Azure DevOps - does it run against an Azure SQL server instance? Is it possible to authenticate using Azure AD and managed identities to support testing different authentication methods?
Please let me know if this is better handled as direct messages to the team - I realize this is not strictly on-topic for the JDBC driver, though you are definitely the closest thing I can find!
Relevant Issues and Pull Requests
https://github.com/denisenkom/go-mssqldb/pull/547

Hi @wrosenuance ,
azure-pipelines.yml will give you an idea. You should be able to run the CI both on custom and Azure hosted VMs/SQL Servers, assuming Azure Devops pipelines have access to the resources. More details can be found here .

Thanks!
It looks like an Azure Subscription is required - I'm guessing that means for this project that Microsoft manages / pays for the Azure Subscription used for CI? If so then we would need to find a way to fund / manage that for the Go driver project.

You are correct. You can contact Chris for further clarifications, he actively works with GO driver.

Thank you! This is good to know!


Correction for raw affiliation LIP, CNRS UMR 5668, INRIA, ENS de Lyon, Universit Claude Bernard Lyon 1, France

Correction needed for raw affiliation LIP, CNRS UMR 5668, INRIA, ENS de Lyon, Universit Claude Bernard Lyon 1, France
raw_affiliation_name: LIP, CNRS UMR 5668, INRIA, ENS de Lyon, Universit Claude Bernard Lyon 1, France
new_rors: 029brtt94;02kvxyf05;04zmssz18;02feahw73;04msnz457
previous_rors: 029brtt94;02kvxyf05;04zmssz18;02feahw73
works_examples: W1538843523
contact: 39d1a5e7844edb83b36fe5095d7f4c2b:7f1ee834f1a7587bf211768e1d7a @ ens-lyon.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Clarification

Hi, this article was last updated 3 years ago and wanted some clarification of the text in the "notes" section at the top of the page is still correct.  Q. Are you 100% saying it is not possible \ supported to set the DSCP tags in a hybrid Azure AD joined machine via intune? This either has to be done via a GPO or some PowerShell script maybe triggered via intune?
It is this sentence
"Currently, this CSP is not supported on Azure AD Hybrid joined devices and for devices using GPO and CSP at the same time"
Ideally the above sentence could  be clarified / bullet pointed or improve the punctuation,  as someone may read it that "its not supported on hybrid azure AD joined devices if some policies are also set by GPO but otherwise it is supported".
Effectively modern desktops are typically updated by intune Policies, alot of large enterprise customers are hybrid azure ad joined and for Teams and OneDrive applying QOS via GPO seems like a step backwards, so can we use CSP to set QOS policies on Hybrid Azure AD joined machines?"
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4bb8b93e-0c1a-8b47-472f-effef5f9209e
Version Independent ID: 8a2615e2-a77b-c08e-b91c-3ce33e0539b2
Content: NetworkQoSPolicy CSP - Windows Client Management
Content Source: windows/client-management/mdm/networkqospolicy-csp.md
Product: w10
Technology: windows
GitHub Login: @ManikaDhiman
Microsoft Alias: dansimp

Hello,
this article was last updated 3 years ago - it was edited many times since then (last change was 3 month ago), but for some reason the date attribute of the article wasn't updated.
Are you 100% saying it is not possible \ supported to set the DSCP tags in a hybrid Azure AD joined machine via intune? - yes, it is not supported yet
It is this sentence
"Currently, this CSP is not supported on Azure AD Hybrid joined devices and for devices using GPO and CSP at the same time"
Ideally the above sentence could be clarified / bullet pointed or improve the punctuation, as someone may read it that "its not supported on hybrid azure AD joined devices if some policies are also set by GPO but otherwise it is supported". - yes, that make sense, since it is not obvious whether "at the same time" related to "GPO and CSP" or to "Azure AD Hybrid joined devices and for devices using GPO". I will create a PR.
applying QOS via GPO seems like a step backwards - it sure is a step backwards, may be in future it will work.
Thank you


Do not change the Stage by NPC kill

Hello,
i have the problem, that the Stage will not change if the npc is killed. Bevor a week all works fine and now it is so bad :(
The problem affects all quests where the goal of a stage is to kill an npc. In the chat it says that it is finished but the stage is not changed.

quests.txt
Quest "Jonas der lästige", "Ein Fischerdorf in Nöten" and some more

@oneboyreal Thanks for the report. Please try https://ci.codemc.io/job/PikaMug/job/Quests/231/


Bring in updated code from N2

Think of this as the first phase to N2. I'm just bringing in some of the rewrite I did with resources over before I add Riven data searching.

Well everything seems to be working out fine, expect for searching which is getting a refresh to accommodate for riven searching.
This is good to go.


.NET Core Task - Clean up 'Publish test results' to prevent duplicate test results in VSTS

dotnet Core Task v2.* (Preview)
Use "test" command with "Publish test results" check box enabled.
This appends --logger trx --results-directory $(Agent.TempDirectory) to the command line arguments.
However the output .TRX files hang around after the results are published to VSTS causing duplicate results when the Task is used more than once.
Repro Steps
Add a dotnet Core v2.* (Preview) Task
Command = test
Projects = **/*xUnitTest*.csproj
Publish test results = enabled
Add a second dotnet Core v2.* (Preview) Task
Command = test
Projects = **/*xIntegrationTest*.csproj
Publish test results = enabled
Expected Result
The results of both Tasks are published to VSTS
Actual Result
The results of both Tasks are published to VSTS but results of the first Task are duplicated in VSTS.
Action
The publish to VSTS matches all .TRX files in temp directory resulting in duplication when the Task is used more than once.
Deleting the temp .TRX files immediately after publishing them to VTS should solve this issue.
Alternatively use  --results-directory $(Agent.TempDirectory)/<uniquefoldername> so that the publish to VSTS step only publishes the newly created TRX files, ignoring previously generated TRX files in other folders.

@nigurr Please could you help me with this. I think it would be one line code change but am not familiar with the code.

@mikejonestechno
There are two ways to resolve the issue.

Clean up Agent.TempDirectory - before calling the Test command to make sure there are no previous TRX files exists - https://github.com/Microsoft/vsts-tasks/blob/master/Tasks/DotNetCoreCLI/dotnetcore.ts#L95
Add an explicit powershell task/cmd task to clean up this folder after dotnet task so that subsequent task don't publish the duplicate trx - temporary workaround.

Thanks nigurr, I might try the temporary workaround so that our builds continue.
I have not contributed to vsts-tasks before and not confident with the code or even how to check changes work locally. I'm happy to help if I can but I would need a lot of help to get started!

@mikejonestechno https://github.com/Microsoft/vsts-tasks/blob/master/docs/contribute.md is a great place to start. We love to get feedback on getting started and improve this for contributions

Creating a bug to track internally and will be fixed soon. Closing this thread

Any status? Hit this today...


optionally set suite name in xunit reporter

My use case is that I am running the same tests in different browsers, and so it would be useful for reporting in our CI system to have the suites named "ie_11" and "firefox_33", etc.

Could you add documentation on suiteName (git grep suiteName returns nothing) and a testcase?

Closed for inactivity.


broadcasts the bottom-reached event each time the bottom is reached

See the README.md for more information.
==> setup a callback function that will be triggered by the "bottom-reached" event.
This event is broadcast each time the bottom of the page is reached.
	$scope.$on('bottom-reached', function() {
		// do whatever you want
	});

We needed that in our current project to be able to get more content from the REST API each time the bottom of the page is reached.
In our case, we planned to use this new feature with a counter in order to limit the $http request every x bottom-reached event.

Hi,
Thanks a lot  for your pull request. It is a good addition that I would like to include in the library.
I have gone through your changes and I have some remarks.
Is there a specific reason why you are firing the event from inside the safeApply function? I would instead fire it in the window scroll listener. (semantically more relevant)
Also, maybe it would be useful to add 2 events (bottom-reached-before and bottom-reached-after) for the more general case.
Lastly, there were no tests for the new functionality. I will add some tests for the new fired events, so that everything is tested and documented in the library. If you keep using the library and you want to make further improvements, it would be nice to accompany your pull requests with tests for the extra code so at any time we know that no functionality is broken.
Just for future reference, I will not merge any pull requests that are not accompanied by tests for the new code changes (however small they may be)
Thanks again for using the library and contributing. I will merge your pull request and commit my changes on top of that. Let me know if my changes still work for your case (since there were no tests committed, there is no way to be sure)
Best regards

I probably made a mistake by putting this event in this function.
I checked what you have done and it is way better.
I will write some tests for any further improvements.
Florian


search_creators with tag result incomplete and missing entries

Summary
The search_creators with a tag result does not contain all creators that have content with that tag and the creators that are returned are missing entries
The Problem
When using search_creatorswith a tag, the result
a) does not contain all creators that have content with that tag. Like if I search on the website for a tag, the creator of almost every result on the website is not in the API result with the same tag.
b) is missing entries, at least for description and links, those are not filled like they would be if I query a single creator.
The Ideal Solution
search_creators, when called with a tag, should return all creators that have content with that tag. Ideally the result contains a count of content of each creator that matches that tag.
Also the fields links and description should be filled correctly.
The Current Solution
No response
Additional Context
No response

Please open a bug report with a suitable explanation and code. You just opened a feature request issue.