Bump rook version to 1.1.0-beta.0 and enable managed PDBs

Haven't tried it out here. I'll comment when I have done a sanity check.

/ok-to-test
/hold
Holding till we have a verification from @rohantmp

@kshlm I think what's left is to generate a CSV with the rook image pointing at the 1.1 beta image

The CephNFS CRD is not being pulled in causing problems when rook attempts to watch for it.
The rook image needs to update to rook/ceph:v1.1.0-beta.0
The OCSInitialization object is being created, but the cephfilesystem, cephobjectstore, and cephblockpools are not being initialized.

Adjusting for everything mentioned here, I have verified that everything is working with this patch.

The CephNFS CRD is not being pulled in causing problems when rook attempts to watch for it. @davidvossel

Right now the only issue with this is that the logs get noisy. Apart from that, we don't have other issues.

The rook image needs to update to rook/ceph:v1.1.0-beta.0
The OCSInitialization object is being created, but the cephfilesystem, cephobjectstore, and cephblockpools are not being initialized.

OCSInitialization does nothing. All of this is to be handled by StorageClusterInitialization. This isn't being created automatically now, but will be.

The rook image needs to update to rook/ceph:v1.1.0-beta.0
@kshlm any updates on this? Should I generate the CSV or generate 0.0.2?

Fixed the Makefile issue. Had commited in another branch.

@kshlm any updates on this? Should I regenerate the current CSV or generate 0.0.2?

Just regenerate the CSV with the current version. Is there a 1.1 beta image of rook available? If there is, regenerate the CSV and submit it in this PR.

The CephNFS CRD is not being pulled in causing problems when rook attempts to watch for it. @davidvossel

if ocs-operator doesn't support cephnfs, then we probably need rook to provide a flag to disable cephnfs entirely.

The failing CI seems to be a missing Make target @davidvossel ?

CI is good. Your CSV doesn't seem to have been updated properly.

The failing CI seems to be a missing Make target @davidvossel ?

"uncommitted CSV changes. run 'make gen-latest-csv' and commit results."
Some files are missing from the CSV generation made in this pr.

You also need to commit the hack/latest-csv-checksum.md5 file.

Gotta love that CI! Didn't know about gen-latest-csv

Gotta love that CI! Didn't know about gen-latest-csv.

e2e test fails because of a merge issue that's preventing the build compiling.
pkg/controller/storagecluster/storagecluster_controller.go:68:1: syntax error: unexpected <<, expecting }
the e2e test attempts to merge and test thsi PR with the current master branch, which is why that error is showing up.

Rebased!

@kshlm CI passed! Can we merge?


The app doesn't run in native resolution

To the raspberry pi 4 we have connected a screen with resolution 1480x320.
The problem is that it display an image with black bar around it.
Docker-compose.yml:
version: '2.1'
volumes:
    # we create a shared volume so that the xserver can mount its socket file, and our application container will be able to use it to display
    xserver-volume:
services:
    xserver:
        image: balenablocks/xserver
        restart: always
        privileged: true
        volumes:
            # when we start, a UNIX socket is mounted in this directory, for communication to the X server
            - 'xserver-volume:/tmp/.X11-unix'
        labels:
            io.balena.features.dbus: 1
            io.balena.features.kernel-modules: 1
        environment:
            - DISPLAY_ORIENTATION=left
            - CURSOR=true
            - DISPLAY_RESOLUTION=1480x320
            - DISPLAY_RATE=30
    balena-electron:
        build: .
        restart: always
        privileged: true
        depends_on:
            - xserver
        # network_mode: host
        # ports:
        #     - 8080:8080
        volumes:
            # We will have access to the UNIX socket shared by xserver after it has started up.
            - 'xserver-volume:/tmp/.X11-unix'
        environment:
            # We need to specify which display we want to use for the X server. :0 is the first display that we have plugged in. This because there is no default display specified.
            - DISPLAY=:0
        group_add:
            - video
        labels:
            io.balena.features.dbus: 1
            io.balena.features.kernel-modules: 1

also experiencing this, would love a solution

I found a solution.
when I flashed SD card and before first boot I attached it and edited config.txt.
I added values:
hdmi_force_hotplug=1
config_hdmi_boost=4
hdmi_group=2
hdmi_mode=4
disable_overscan=1

disable_overscan is the important value.
there are no black bars all around anymore.


Destroyed walls still appear on the map

"This room consists of a(n) stone wall to the north..."
"a(n) stone wall to the north" should read "a pile of rubble to the north".

Duplicate of #27

Not a dupliate of #27, just a bad title. Re-opening and renaming.

The issue name was in error. The issue name has been edited to refer to the issue in the description, which has been resolved.
Updates will be pushed to binaries once milestone is complete.


New device added for supervisor after losing connection to PVS6

This morning I woke up and the integration wasn't communicating with my PVS6. I rebooted the router the PVS6 connects to and everything showed back up, However now I have a new supervisor device along with the old one. The old one has all the history but shows all entities as unavailable, the new one works fine.
I also notice in device info the new supervisor device does not show the hardware version but the old one does.
I've reloaded the integration multiple times and restarted HA.
The integration is up to date according to HACS

A lot of robustness has been added since this post.  If you do see this again getting a copy of the devices list output would be great plus the entity names and unique ids (old and new) would probably be the next debugging steps.  Even screenshots of each could be helpful.  Hardware version aren't part of any of the keys used to tell apart.
I have seen Sunpower change some fields from time to time..  but the ones used for IDs should be stable.
Please re-open if you see this again.


Footprints deduplication

Work towards fixing #169.
This does three-step process for removing duplicate footprints introduced by joining with census blocks when the footprint overlaps more than one census block:

Add a surrogate _tmp_id to act as a unique identifier for footprints. As long as this isn't treated as a stable identifier or joined with anything else, seq4() should be fairly cheap and sufficient. uuid_string() would also be fine, and basically impossible to collide with, but I expect that seq4() is cheaper as you can more easily do comparisons and (possibly) micropartition logic.
For footprints with more than one census block, compute the area of the intersection with the census block. We don't worry too much about SRIDs here, as we are mostly interested in ranking the intersections.
Select the footprint with the largest intersection, partitioned/grouped by _tmp_id. I'm investigating two approaches, one with window functions and QUALIFY, the other with GROUP BY. The latter seems provisionally significantly faster.
Test that the final number of footprints is identical to the initial.

Still a work in progress, but would appreciate feedback from @britt-allen and @AeriShan-ODI!

Dropping a few things I've learned from performance profiling here. There are a few questions I had when writing this:
Intersections for some or for all?
We only need to compute the intersection for footprints which intersect more than one census geometry. Intersection is an expensive operation! So I used a window function to identify the duplicated footprints (PARTITION BY _tmp_id), then only computed the intersection for those footprints. But window functions are also expensive! Is it more expensive to do the window function, or unnecessary intersections?
What kind of temporary ID?
Is it better to use an incrementing integer to track unique footprints or UUIDs? It's probably integers for a couple of reasons:

They are cheaper to generate and compare
They can be sorted for possible micropartition-based logic.

Performance considerations for CTEs
If incrementing integers are indeed useful for micropartition-based logic, do we need to add them to a materialized table to effectively "commit" the partitions? Or is the query planner smart enough to also do the same logic if we keep the table-with-temporary-ids as a CTE?
Deduplicating with window functions vs aggregations
There are (at least) two approaches to deduplicating the footprints once the intersection is calculated. Which is faster?

Window function, order by intersection, QUALIFY row_number() = 1
Group by the id, aggregate by the maximum intersection

I ran some tests across a few different dimensions:

UUID vs SEQ4
CTE vs base model for temporary IDs
Window vs Aggregation for deduplicating
Window+CASE vs intersecting for all

Here are some summary tables (with result times in seconds).
First, investigating CASE + Window vs always computing intersections. In this table, deduplication is always done the same way using aggregation:
| CASE + Window | Always compute intersection
-- | -- | --
UUID in CTE | 326 | 195
UUID in table | 366 | 231
SEQ4 in CTE | 326 | 190
SEQ4 in table | 359 | 222
Second, investigating windowing vs aggregation for deduplicating:
| Window | Aggregation
-- | -- | --
UUID in CTE | 717 | 195
UUID in table | 441 | 231
SEQ4 in CTE | 703 | 190
SEQ4 in table | 433 | 222
There are a few interesting thing here:

Using SEQ4() is usually slightly faster than using UUID_STRING() for temporary IDs. But not so much faster that I think that Snowflake is doing clever things with partitions. It's probably just reflecting the relative cheapness of comparing and sorting integers vs UUIDs.
Aggregation is always faster than windowing for deduplication. This seems to be due to the shuffle that is triggered by windowing. There is tons of bytes spilling to disk for the windowing cases, and very little for the aggregation cases. There is a certain sense to this, since shuffling is one of the most expensive things you can do. But in this case, a shuffle shouldn't be necessary, as the footprints effectively come pre-sorted. But Snowflake isn't smart enough to know that they are pre-sorted, so it does the shuffle anyways.  So even though it isn't obvious that windowing would be slower, in practice it seems to be by almost a factor of 2.
Most of the time keeping the temporary ID generation as a CTE is preferable to pre-generating it as a materialized table. Which makes a certain amount of sense, in that there is likely less I/O in the latter case, and the query optimizer can do more things if the query isn't broken up into separate models. There is a weird exception to this, however! The windowing approach to deduplication has a HUGE performance difference when using a CTE vs a pre-materialized table, and the CTE is much worse! I don't know what is going on there. It's not hugely consequential, as aggregation is preferred basically everywhere, but it would be nice to understand it!
It's not worth it to use a window function to filter for footprints that need intersections. In all cases, it's cheaper to just compute intersections for all footprints. This is disappointing. As above, Snowflake could be smart enough to know that the dataset is already pre-sorted, and avoid an expensive shuffle. But it seems not to be.

TL;DR
Tentative answers to my questions above:

Intersections for all
Use SEQ4()
It's okay to use CTEs here
Aggregation instead of window+QUALIFY

This is brilliant, this could have all easily lived in your head and in worksheets, but the knowledge transfer and explanation behind choices made is so helpful! Thanks Ian. @jasonlally can we get this on the caldata and/or ODI blog? I'd like for us to post more educational pieces and more of our work in general. That is if @ian-r-rose is okay with that? :)

Thanks for the review and merge @britt-allen! I do think things like this could be interesting for a blog post (or at least a lunch and learn :) )

Yeah I think we have a lot of things we can start blogging about. Let me check on process and where most appropriate to post. To clarify, what would the subject be? Would it be on the development of a model to deduplicate geo data using dbt + Snowflake?

To clarify, what would the subject be? Would it be on the development of a model to deduplicate geo data using dbt + Snowflake? @ian-r-rose

I would probably frame it as a case study in performance optimization of a dbt model in Snowflake on geospatial data. That's where most of the interesting stuff are to me. It would be pretty technical, but there's probably ways to structure things so that different parts are accessible to people at different levels.

I like that framing Ian. I also like Jason's framing and think performance optimization could be one area of focus as well as what were are doing with abstracting data tables to code with macros and using macros to house other repeatable patterns. I was thinking it could be a long deep dive-y article or a 2-3 part mini series.


zappa update errors in docker container with AWS profile/env vars

zappa update dev in docker container errors:
Warning! Couldn't get function prop-scrape-serverless-dev in ap-southeast-2 - have you deployed yet?

I get this error in either of the two scenrios:

Set AWS_XXXX env vars and removed "profile_name" from zappa_settings.json.
Defined "default" AWS profile and set "profile_name": "default"

Yes virtual on 3.7
Expected Behavior

Should update AWS lambda function
Actual Behavior

Warning! Couldn't get function prop-scrape-serverless-dev in ap-southeast-2 - have you deployed yet?
Possible Fix

Verbose logging would help to understand what the actual problem is
Steps to Reproduce

Set environment vars on docker host (passed in in next step)
docker run --rm -it -e AWS_DEFAULT_REGION="%AWS_DEFAULT_REGION%" -e AWS_ACCESS_KEY_ID="%AWS_ACCESS_KEY_ID%" -e AWS_SECRET_ACCESS_KEY="%AWS_SECRET_ACCESS_KEY%" -v "%CD%":/var/task lambci/lambda:build-python3.7 bash
python -m venv aws_venv
source aws_venv/bin/activate
pip install -r aws_requirements.txt
zappa update

Get error
Your Environment

Zappa version used: 0.48.2

Operating System and Python version: Docker host: Windows 10
Docker container: lambci/lambda:build-python3.7

The output of pip freeze:
argcomplete==1.9.3
boto3==1.9.233
botocore==1.12.233
certifi==2019.9.11
cfn-flip==1.2.1
chardet==3.0.4
Click==7.0
docutils==0.14
durationpy==0.5
future==0.16.0
hjson==3.0.1
idna==2.8
jmespath==0.9.3
kappa==0.6.0
lambda-packages==0.20.0
placebo==0.9.0
python-dateutil==2.7.5
python-slugify==1.2.4
PyYAML==5.1.2
requests==2.22.0
s3transfer==0.2.1
selenium==3.141.0
six==1.11.0
SQLAlchemy==1.3.8
toml==0.10.0
tqdm==4.19.1
troposphere==2.5.1
Unidecode==1.1.1
urllib3==1.24.1
Werkzeug==0.16.0
wsgi-request-logger==0.4.6
zappa==0.48.2

Link to your project (optional):

Your zappa_settings.py:
{
"dev": {
"aws_region": "ap-southeast-2",
"project_name": "prop-scrape-serverless",
"use_apigateway": false,
"runtime": "python3.7",
"s3_bucket": "gaia-zappa-deploy",
"keep_warm": false,
"timeout_seconds": 120,
"memory_size": 1024,
"environment_variables": {
"PATH": "/var/task/chrome"
},
"events": [
{
"function": "prop_search_scope.lambda_handler",
"event_source": {
"arn": "arn:aws:sqs:ap-southeast-2:XXXXXXX:YYYYYYYY",
"batch_size": 1,
"enabled": true
}
},
{
"function": "prop_search_page.lambda_handler",
"event_source": {
"arn": "arn:aws:sqs:ap-southeast-2:XXXXXXX:YYYYYYYY",
"batch_size": 1,
"enabled": true
}
},
{
"function": "prop_listing_page.lambda_handler",
"event_source": {
"arn": "arn:aws:sqs:ap-southeast-2:XXXXXXX:YYYYYYYY",
"batch_size": 1,
"enabled": true
}
}
]
}
}

#1928

Have you figured anything out about this problem? I have been running into the same problem with no progress... When I try to update from my CI build step, it injects the directory name before the environment for some reason. So...
Files are in /tmp/src
zappa update test from /tmp/src
I get the following error message:
Couldn't get function src-test in us-east-1 - have you deployed yet?

Yes, I get the user that I expect, and the region is in us-east-1. For some reason it is prepending src- to the environment name. I even replaced it with "zappa deploy test" to see what happens, and it deploys "src-test" which I know shouldn't be possible...
Not sure if this is the same error that is being reported here. This is all being done in AWS CodeBuild.

Ah I see the problem, zappa appends the directory name to make it unique... of course!


problem in compiling the code using 'ant all'

I have downloaded the code of MorphoChain. When I am trying to compile using the command 'ant all' in ubuntu terminal, the following error occurs.
BUILD FAILED
.../module_morphology.xml:89: .../tools/lbfgsb_wrapper-1.1.2-src does not exist.

Hi Abhisek,
The path to the lbfgsb library was incorrect. I've fixed the build file - it should work now. Please try compiling now and let me know.
Also, if you install your own copy of liblbfgsb, make sure to change the path accordingly in build.xml.

Hi Karthik,
The path to the lbfgsb library is fixed in the build file but the corresponding changes in module_morphology.xml are not set resulting error in compilation.
However, I have changed the path to lbfgsb library in the module_morphology.xml file in my machine but still the following error occurs.
BUILD FAILED
.../module_morphology.xml:89: .../lib/lbfgsb_wrapper-1.1.2-src does not exist.
I checked the 'lbfgsb_wrapper-1.1.2.jar' in lib/ directory and found that it does contain 'src'. It does not contain 'raw_wrapper' also which is required.
So, if you upload the correct version of 'lbfgsb_wrapper-1.1.2.jar', then it will be helpful.

I see. The path for the source was incorrect. Fixed it now.

@abhisek-Chakrabarty Could you compile it now? Let me know and I can close the issue.

Still, there are two problems in compilation. They are

the path for jdk.home.1.7 in the build.properties file is currently a particular machine specific. I think it should be set by the user.
The package junit.framework is not available.

Could you try setting the path to your local jdk? Also, try installing Junit using Maven and see if it compiles. Another way you can do this easily is to just import it in IntelliJ or Eclipse (if you use either of these IDEs) and compile.


Add option to hide overflow titles

This PR addresses https://github.com/imaNNeoFighT/fl_chart/issues/603
This is a simple feature to add the option to hide top and bottom titles IF they overflow the left or right borders of the chart.
All it does is check if the text will be drawn outside the bounds on the left and right sides of the canvas area. If the title does overflow the boundary, then it is not painted.
I could not figure out a way to write a test for this but would gladly update this if anyone has any ideas on a good test.
Usage:
topTitles: SideTitles(
          showTitles: true,
          hideTitleOnOverflow: true,
          ...
),
bottomTitles: SideTitles(
          showTitles: true,
          hideTitleOnOverflow: true,
          ...
)

Hi
Thanks for contributing.
I think it doesn't solve the problem. we are just ignoring it (by hiding the first and last titles).
For example in the issue that you've mentioned, as we need to show 3 bottom titles, we can't only hide the last title.


Add the ability to deploy a remotecfg block

This would enable the alloy instances deployed by the chart to be interoperable with the fleet management work.

There can only be one remotecfg, so add something like this inside each alloy instance block:
  remoteConfig:
    url: ""
    auth:
      type: "basic"
      username: ""
      password: ""
    id: <cluster-name>-<namespace>-<pod-name>
    pollFreq: 60s
    attributes:
      platform: kubernetes
      workloadType: statefulset

https://grafana.com/docs/alloy/next/reference/config-blocks/remotecfg/


.create() call broken in Swift as of Swift 1.2 (xcode 6.3-beta)

The create() call fails because, in createInContext: the call to [self entityName] returns 'ModuleName.Classname" instead of just "Classname" as it did in Obj-c. The format of the return type of NSStringFromClass changed in the latest Swift release.

This could be solved by inspecting the result of NSStringFromClass, breaking the string up in components separated by ., and returning the last component.
+ (NSString *)entityName {
    NSString *entityName = NSStringFromClass(self);

    if ([entityName<EMAIL_ADDRESS>{
        NSArray *components = [entityName<EMAIL_ADDRESS>        if (components.count > 1) entityName = components.lastObject;
    }

    return entityName;
}

My work around was to override entityName in a subclass.
On Thursday, February 19, 2015, Bart Jacobs<EMAIL_ADDRESS>wrote:

This could be solved by inspecting the result of NSStringFromClass,
breaking the string up in components separated by ., and returning the
last component.

(NSString *)entityName {
NSString *entityName = NSStringFromClass(self);
if ([entityName<EMAIL_ADDRESS>{
NSArray *components = [entityName<EMAIL_ADDRESS>if (components.count > 1) entityName = components.lastObject;
}
return entityName;
}

—
Reply to this email directly or view it on GitHub
https://github.com/supermarin/ObjectiveRecord/issues/115#issuecomment-75058296
.

I've been struggling with class names in my frameworks as well, here's the solution a came up with:
https://github.com/DenHeadless/DTModelStorage/blob/master/DTModelStorage/Utilities/DTRuntimeHelper.m#L13-L22
This is basically NSStringFromClass, but language-independent, which returns class name in objective-c, and second part of class name in Swift(first is module name).

This will fix your woes
@objc(MyManagedClass)
class MyManagedClass: NSManagedObject {

}

NSStringFromClass(MyManagedClass)

I use Swift 1.2 and XCode 6.3 and I'm still getting the Cannot create an NSPersistentStoreCoordinator with a nil model error.
Any ideas where I failed? Here's what fails and my steps:
var sample = Sample.create() as! Sample

Removed obsolete CoreData code from AppDelegate (earlier I have added it manually).
Created new xcdatamodeld named like my project, let's say: MyProject.xcdatamodeld.
Added new entity Sample with few fields and generated a class or it. In the configuration I tried both MyProject.Sample and Sample as a class.
Tried with entityName and @objc annotation.

Just popped a swift version.
Cheers!
https://github.com/arkverse/SwiftRecord


Vuetify strange reload bug

Environment
Nuxi 3.4.1                                                                                12:17:43 PM
12:17:44 PM
RootDir: /mnt/c/Users/.../Desktop/workspaces/.../account-web                                                         12:17:44 PM
Nuxt project info:                                                                                12:17:44 PM

Operating System: Linux (WSL)
Node Version:     v18.13.0
Nuxt Version:     3.4.1
Nitro Version:    2.3.3
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      ssr, app, build, vite, modules, pinia, runtimeConfig
Runtime Modules:  vue-recaptcha/nuxt<EMAIL_ADDRESS><EMAIL_ADDRESS>()
Build Modules:    -

👉 Report an issue: https://github.com/nuxt/nuxt/issues/new                                                                              12:17:44 PM
👉 Suggest an improvement: https://github.com/nuxt/nuxt/discussions/new
👉 Read documentation: https://nuxt.com
Reproduction
https://stackblitz.com/edit/github-g9pt8g?file=app.vue
Describe the bug
Triggering a reload on this specific tree fails.
Seems like having a v-sheet > div (conditional) > div > v-text-field does not manage to complete the reload.
Additional context
Using the latest version of Nuxt and Vuetify.
There is some comment inside the stackblitz reproduction, you just need to trigger a reload of some sort, the easier way is to change the max-width property.
Logs
TypeError: Cannot read properties of null (reading 'style')
    at patchStyle (vue.js:8018:1)
    at patchProp (vue.js:8221:1)
    at patchProps (vue.js:5952:1)
    at patchElement (vue.js:5907:1)
    at processElement (vue.js:5766:1)
    at patch (vue.js:5698:1)
    at patchKeyedChildren (vue.js:6305:1)
    at patchChildren (vue.js:6265:1)
    at patchElement (vue.js:5875:1)
    at processElement (vue.js:5766:1)

This seems to be resolved upstream.


Create LICENSE

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@080b9c2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   83.37%
  Complexity        ?      141
=========================================
  Files             ?       27
  Lines             ?      433
  Branches          ?       59
=========================================
  Hits              ?      361
  Misses            ?       54
  Partials          ?       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 080b9c2...803d77d. Read the comment docs.


[feature request] An option to get machine-readable output from zenn new:book

Like #63, now zenn new:book prints files that created with colors (by ANSI escape charactors) like below:
created: \e[32mecba19abfa3c41371a4a/config.yaml\e[39m
created: \e[32mecba19abfa3c41371a4a/example1.md\e[39m
created: \e[32mecba19abfa3c41371a4a/example2.md\e[39m

But I want an output which can be parsed easily.
e.g.
$ zenn new:book --machine-readable
books/ecba19abfa3c41371a4a/config.yaml
books/ecba19abfa3c41371a4a/example1.md
books/ecba19abfa3c41371a4a/example2.md

NOTE: Also a subcommand new:article has --machine-readable option.

ありがとうございます。bookの作成においても、パイプなど後続の出力で処理可能な形式になるようにオプションを検討してみます。


name 'log_uniform' is not defined

$ sudo $BLENDER --background --python tools/generate_individual_assets.py -- -f BoulderPileFactory -n 4 --save_blend
Blender 3.3.1 (hash b292cfe5a936 built 2022-10-05 00:14:35)
Traceback (most recent call last):
File "/home/wb/work/infinigen/worldgen/tools/generate_individual_assets.py", line 61, in build_scene_asset
asset = factory.spawn_asset(idx)
File "/home/wb/work/infinigen/worldgen/placement/factory.py", line 102, in spawn_asset
placeholder = self.spawn_placeholder(i=i, loc=loc, rot=rot)
File "/home/wb/work/infinigen/worldgen/placement/factory.py", line 72, in spawn_placeholder
obj = self.create_placeholder(i=i, loc=loc, rot=rot)
File "/home/wb/work/infinigen/worldgen/assets/pile.py", line 55, in create_placeholder
scale = [1, log_uniform(.4, .6), log_uniform(.2, .4), log_uniform(.2, .4), log_uniform(.2, .4),
NameError: name 'log_uniform' is not defined
BoulderPileFactory(0).spawn_asset(idx=0) FAILED!! name 'log_uniform' is not defined
name 'log_uniform' is not defined
Traceback (most recent call last):
File "/home/wb/work/infinigen/worldgen/tools/generate_individual_assets.py", line 61, in build_scene_asset
asset = factory.spawn_asset(idx)
File "/home/wb/work/infinigen/worldgen/placement/factory.py", line 102, in spawn_asset
placeholder = self.spawn_placeholder(i=i, loc=loc, rot=rot)
File "/home/wb/work/infinigen/worldgen/placement/factory.py", line 72, in spawn_placeholder
obj = self.create_placeholder(i=i, loc=loc, rot=rot)
File "/home/wb/work/infinigen/worldgen/assets/pile.py", line 55, in create_placeholder
scale = [1, log_uniform(.4, .6), log_uniform(.2, .4), log_uniform(.2, .4), log_uniform(.2, .4),
NameError: name 'log_uniform' is not defined
BoulderPileFactory(1).spawn_asset(idx=1) FAILED!! name 'log_uniform' is not defined
name 'log_uniform' is not defined
Traceback (most recent call last):
File "/home/wb/work/infinigen/worldgen/tools/generate_individual_assets.py", line 61, in build_scene_asset
asset = factory.spawn_asset(idx)
File "/home/wb/work/infinigen/worldgen/placement/factory.py", line 102, in spawn_asset
placeholder = self.spawn_placeholder(i=i, loc=loc, rot=rot)
File "/home/wb/work/infinigen/worldgen/placement/factory.py", line 72, in spawn_placeholder
obj = self.create_placeholder(i=i, loc=loc, rot=rot)
File "/home/wb/work/infinigen/worldgen/assets/pile.py", line 55, in create_placeholder
scale = [1, log_uniform(.4, .6), log_uniform(.2, .4), log_uniform(.2, .4), log_uniform(.2, .4),
NameError: name 'log_uniform' is not defined
BoulderPileFactory(2).spawn_asset(idx=2) FAILED!! name 'log_uniform' is not defined
name 'log_uniform' is not defined
Traceback (most recent call last):
File "/home/wb/work/infinigen/worldgen/tools/generate_individual_assets.py", line 61, in build_scene_asset
asset = factory.spawn_asset(idx)
File "/home/wb/work/infinigen/worldgen/placement/factory.py", line 102, in spawn_asset
placeholder = self.spawn_placeholder(i=i, loc=loc, rot=rot)
File "/home/wb/work/infinigen/worldgen/placement/factory.py", line 72, in spawn_placeholder
obj = self.create_placeholder(i=i, loc=loc, rot=rot)
File "/home/wb/work/infinigen/worldgen/assets/pile.py", line 55, in create_placeholder
scale = [1, log_uniform(.4, .6), log_uniform(.2, .4), log_uniform(.2, .4), log_uniform(.2, .4),
NameError: name 'log_uniform' is not defined
BoulderPileFactory(3).spawn_asset(idx=3) FAILED!! name 'log_uniform' is not defined
name 'log_uniform' is not defined
No images found
Blender quit

Hello, this part of the code is not actively used in the current version of the main infinigen renderer and it appears now has some bugs. If your goal is to generate one of every asset you can simply skip this one. Otherwise, I think you could fix it by adding from util.random import log_uniform, this will be fixed in v1.1 which I hope to release next week.


Uninstalling UCR

Uninstalling UCR from a PC, Need help.
If I uninstall interception from command prompt and delete all the UCR and Interception files, does that mean I have completely uninstalled UCR and Interception or do I need to execute an Uninstall file(which apparently didn't exist in the folder).
Label : help wanted

Yes, UCR does not create any files outside of it's base directory, so deleting the folder is all that is necessary.


Update naming Starknet ID

Hello !
I changed some namings cause it can create confusion :) (A dev asked me what are the differences between domain_contract and naming_contract when it's the same).
And I add one of our recent contracts.

Perfect 👍


Fix: Renames 'previousPageLabel' translation key to 'prevPageLabel'

Renames 'previousPageLabel' translation key to 'prevPageLabel' actually used by primeng

I have said this before previousPageLabel is correct and used by PrimeReact and PrimeFaces.  PrimeNG needs to update to use these proper labels.


xkeyboard_config: 2.33 -> 2.39

Description of changes
The release notes aren't really helpful and given it's a new build system, I did a diff because I'm not too familiar with this package (ignoring etc and lib that are just symlinked in overrides.nix):

Javanese hasn't been removed, just moved.
A lot of updates, new translations and layouts (nearly two years worth of updates).

Explanation of changes:

-Dxorg-rules-symlinks=true replaces --with-xkb-rules-symlink=xorg, without that share/X11/xkb/rules/xorg* wouldn't be generated.
There's a new Perl script hence the dependency on Perl.
gettext is necessary to generate the translations.
I edited overrides.nix and did not special case xkeyboardconfig in generate-expr-from-tarballs.pl as that seems to be the way to go (I believe we could drop pkg-config in default.nix, but again, not sure we want to special case).

Things done

Apparently, there are more than 5k packages impacted (at least that's what nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD" tells me) so I followed https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging and couldn't really rebuild everything locally. I believe the CI will?

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

2.39 is out now.
The diff looks good to me and the tests in nixosTests.keymap build with it.

Pushed another commit for 2.39 and rebased. Whom should I notify (there's no maintainer)?

A good chunk of this has landed with https://github.com/NixOS/nixpkgs/pull/241220 . Can you rebase and see what is still missing? xkeyboard_config is currently broken for me, at least with a custom keyboard layout.

They appear to be equivalent, let's close this one.


the vq-diffusion implementation

curious about the vq-diffusion code, would you mind release the part of it

We will release the code in the near future.


ScrollView inside card

Is it possible to have a ScrollView that works inside a card?
 Right now when I try to scroll on the scrollview, I can't, it just drags the card.

Hi. Have you got any solutions for this..?

So as far as I can tell, I just put this into the ScrollView (and also the child View, but I don't think that was necessary):
              onStartShouldSetResponder={() => true}
              onTouchEnd={e => {
                e.stopPropagation();
              }}

Let me know if that helps


Changed unit to component, removed xunit as a dependency.

Right, categories are running through the command line. Test explorer has nothing, which I've raised before.

What are we defining as Unit vs Component?
Also, did you get latest; looks like you only updated one of the test projects? (There's two)

I Forked and committed to dev, so fairly sure that's the latest. I saw a ComponentTests file so I thought these were component tests?

Was going to ask the same question - damn you @smudge202 beat me to it!

I feel like these tests should still be [Unit] though, @herecydev let me know if I'm wrong!

Component was shorthand for Entity Component System which is a bit of a mouthful. That's twice the name has bitten me in the ass; should I go for EntityComponentSystem instead then?

@smudge202 I think it would be better to rename, we know / should know that Component is the Entity Component System but would be clearer for others looking/contributing going forward.

I would call a unit tests file: nameoffiletotest+tests
In this example you are using DI to resolve an instance of ComponentSystem. This would make these a component test at minimum. For unit tests you would target the class directly. Thoughts?

@smudge202 @herecydev  works for me :shipit: :D

As per above comments, the tests in EventStream.Tests will also need to be promoted to Component.
I've raised #22 to cover the Component naming issue.

:shipit:

:shipit:

As per above comments, the tests in EventStream.Tests will also need to be promoted to Component.

#23 beat this PR to the line so is conflicted. I'll sort it tonight if someone doesn't beat me to it.

See PR #24

Replaced by #24


Ability to change which council you are testing with

Another big one. Addresses #139.

Will add in instructions for how to add council variables and a council stylesheet in a future pull request. This one just adds the ability to switch, which is stored in the session.
@kaydale Would particularly appreciate feedback on where I could link to the council picker page.

When you get to verify land in the unbranded prototype if still reads as if it is Argleton

@sanjaypoyzer
Ahhh so when I went through the success verify path it sent me back to Argleton was it supposed to do that?

Just to show that I did select unbranded council - and it worked prior to hitting the verify prototype

@kaydale Ah yes, good catch. I need to add a variable in the link to Verify, and also need to set up the unbranded council on the stable prototype. I'll need to remember to set up the councils on the Verify prototype as well when they add their own.

@kaydale conflicts fixed

So are you still working on all the other stuff @sanjaypoyzer

@kaydale Which other stuff?

@sanjaypoyzer https://drive.google.com/open?id=0B5wEPxglOrqoY05kaGtlaVJCRWc
Video showing how unbranded prototype doesn't work.

@kaydale Ok I think I've fixed the issue, and also put it all on one page which makes it a lot more usable. I also added Argleton as the default because it was breaking before users picked a council.

@sanjaypoyzer
on this page: /council-picker
"change council" button does not link

@kaydale Works on my machine :/

@sanjaypoyzer
So I figure out what happened - you will see in the video that unbranded works but I just didn't get how to navigate to the service start. I think before this if you clicked "Change council" it would go directly to https://verify-local-patterns.herokuapp.com/ and continue as unbranded.
Video is here:
https://drive.google.com/open?id=0B5wEPxglOrqoY05kaGtlaVJCRWc

@kaydale That works as expected. What were you expecting to happen?

@sanjaypoyzer
Also realised its still sending Argleton across when it gets to the verify prototype

Will that work ok when its merged?

@kaydale Ok that should all work now!

@kaydale Just had a little go at doing an error message for if the council picked is already chosen (which is the thing you were doing) but it's pretty complicated and requires quite a bit of rewrite, so I'm going to leave it for now as this feature only has a few users right now. (ie The people facilitating usability testing in councils.)

@sanjaypoyzer
Works better but still links though to argleton branded confirm address page
https://drive.google.com/open?id=0B5wEPxglOrqoNWRFUTFIUzVIcUE

@kaydale Yep, that's because it has to link back to the deployed version. In other words, that should work once it's merged.


localtime, gmtime, and timelocal shouldn't raise exceptions

localtime, gmtime, and timelocal shouldn't raise exceptions, even if you give them crazy arguments.

Fixed in  v1.003


type reflect.StructField has no field or method IsExported

What happened:
sigs.k8s.io/json/internal/golang/encoding/json
/Users/phil/go/pkg/mod/sigs.k8s.io/json@v0.0.0-20211020170558-c049b76a60c6/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
/Users/phil/go/pkg/mod/sigs.k8s.io/json@v0.0.0-20211020170558-c049b76a60c6/internal/golang/encoding/json/encode.go:1255:18: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

Clarify go1.17 is required


profiler: Expose missing profile stacks count as a prometheus metric

Signed-off-by: Sumera Priyadarsini<EMAIL_ADDRESS>

:rocket:


question: should the middleware inject the trace context into the http.Request?

I'm implementing a simple http reverse proxy in Go using chi.  The proxy routes requests to microservices, and handles service to service requests as well as the initial "front door" request.  I added otelchi.Middleware in hopes of getting a trace tree of all requests (eg: initial/parent request and child spans for called services) , but all spans were created as root spans.  I eventually figured out that the trace context was not injected into the http request in func (tw traceware) ServeHTTP()
I worked around this by creating a middleware that injects the context, called after the otelchi middleware:
type Injector struct {
	next http.Handler
}

func (injector Injector) ServeHTTP(w http.ResponseWriter, req *http.Request) {

	jaegerPropagator.Inject(req.Context(), propagation.HeaderCarrier(req.Header))
	injector.next.ServeHTTP(w, req)
}

note that jaegerPropagator is a file scoped variable, just a hack to get this working.
Is there any reason why the otelchi middleware does not inject the trace context from the span it creates? It seems to me that is probably always the right thing to do, but I am pretty new to all this.  Thanks.

Hello, @burritts
Sorry for the super late reply. I've been busy these days. 😅🙏🏻

Is there any reason why the otelchi middleware does not inject the trace context from the span it creates?

Yes, because otelchi is just the receiver middleware that act as gateway to receive request from client. So it doesn't call TextMapPropagator.Inject().
If you want to send the trace context to another service, you should also use otelhttp client. It is already done the trace context injection for you (see here).

I've also created example specifically to demonstrate this. You could access it here.

Thank you for the detailed response.  It took me a while to absorb the information.  My question is answered, and I have a better understanding of the purpose of the otelchi middleware, and how to use the otel APIs in general.


TimeDistributed with masking

This PR fixes two issues with TimeDistributed:

It passes the mask that's input to TimeDistributed on to the wrapped layer, so that wrapped layers can use the mask properly.
It allows for layers taking multiple inputs to work directly with TimeDistributed.

There are three things to note:

It appears you removed the mask=None kwarg to the Layer.call() method.  That makes handling masking correctly in TimeDistributed hard, which is why I added it back in Dense and _Conv.  Is there a better way to handle this?
In compute_mask, this implementation only passes through the input mask.  This is clearly not what you want to do in general - you really want to use the wrapped layer's compute_mask method, but to get that to work correctly would require much more sweeping changes to the code.
I haven't added any tests yet, as I'm not sure what exactly you would like to see tested.  I'm happy to add whatever tests you would like, though.

You mentioned in the contributions requested issue that TimeDistributed still needed work, so I thought it wasn't handling the mask right.  But it appears there's some magic going on in Keras 2 with passing the mask around that I don't understand well enough yet, so I'll just wait on trying to improve things until I've had more time to understand Keras 2.


Azure Stack support for the new Azure Go SDK

Original requirement:
Azure Stack wants us to provide an SDK which could only contains operations belonged to a sub-set of resource types and each resource type uses a specific API version.
Previous solution:
In the previous version of Azure Go SDK, we use profile to support it. Since track1 compose all RPs with all API versions in one module, the profile sub-package will map the model and operation with needed RPs and API version. Package here<EMAIL_ADDRESS>Possible solutions:
The new version of Azure Go SDK only supports single API version and releases different RPs with separated modules. So, if we need to support Azure Stack, we have two ways:

We generate and release a dedicated profile module that contains all the needed RPs’ packages, this is somehow follow what we do in previous SDK version. I did a proto work in this PR. Currently, data plane packages have not been added to profile module
We generate and release several modules, and each contains only one RP, this is somehow a batch of parallel modules of the current SDK module but generated with different API version.

Discussion:
JS and Java all apply the second way and released a batch of separated packages for Azure Stack. But the disadvantage is that customer will need to import several packages when using Azure Stack. Do we need to keep consistency for all the languages? And which solution will be better?

cc @mikekistler @xboxeer @jhendrixMSFT @JeffreyRichter @RickWinter @lirenhe @ArcturusZhang @sandeep-sen

I don't know enough about Azure Stack and profiles yet. Please educate me on exactly what a profile is in concept and how this maps to service api-versions. Ignore any thinking about Go packages/modules for the moment. Then, after I/we understand this well, we can apply the knowledge as to how to best address this with Go Track 2 packages/modules.

@JeffreyRichter Profile offer a means of virtualizing the API Versions of services that should be targeted by an application or SDK. You could find a profile config here. Azure Stack uses it to specify RP, resource types and API version they are using. They want us to provide SDKs according to the profile config.
For Go track1, we have sub package for this profile: https://github.com/Azure/azure-sdk-for-go/tree/main/profiles/2020-09-01. For JS track2, they have separated packages for the RPs configured in profile: https://www.npmjs.com/search?q=hybrid-profile. For Java track2, they do the same with JS: https://mvnrepository.com/artifact/com.azure.resourcemanager/azure-resourcemanager-network/1.0.0-hybrid.

@JeffreyRichter Is there anything else I could help to explain? I don't know much about the profile design history. Maybe @jhendrixMSFT could help to add more context.

See email thread I added you to today
-- Jeffrey Richter

From: Chenjie Shi @.>
Sent: Monday, November 7, 2022 4:02:13 AM
To: Azure/azure-sdk @.>
Cc: Jeffrey Richter @.>; Mention @.>
Subject: Re: [Azure/azure-sdk] Azure Stack support for the new Azure Go SDK (Issue #5044)
@JeffreyRichterhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffreyRichter&data=05|01|jeffreyr%40microsoft.com|a0116aaa8ef0412ee49a08dac0b7e8ad|72f988bf86f141af91ab2d7cd011db47|1|0|638034193365231150|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=QQgXyxdASTjLVm3Bl%2BOwACZxnCLQ5GFzI%2BKZ9f9xW3M%3D&reserved=0 Is there anything else I could help to explain? I don't know much about the profile design history. Maybe @jhendrixMSFThttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FjhendrixMSFT&data=05|01|jeffreyr%40microsoft.com|a0116aaa8ef0412ee49a08dac0b7e8ad|72f988bf86f141af91ab2d7cd011db47|1|0|638034193365231150|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=n3baYAmtBmazpEMAk%2FHMRHTHW4w%2BT9DlB4SkQKJ6daY%3D&reserved=0 could help to add more context.
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk%2Fissues%2F5044%23issuecomment-1305503268&data=05|01|jeffreyr%40microsoft.com|a0116aaa8ef0412ee49a08dac0b7e8ad|72f988bf86f141af91ab2d7cd011db47|1|0|638034193365231150|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=TUqZeSpsXV9T5rT1vVCoQ2BNBkR%2BGaZM7u3102WIt2U%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAARLJP63E3XRAZVKF5MMY6DWHDVULANCNFSM6AAAAAARVCSC44&data=05|01|jeffreyr%40microsoft.com|a0116aaa8ef0412ee49a08dac0b7e8ad|72f988bf86f141af91ab2d7cd011db47|1|0|638034193365231150|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=jlFShu46WD4fqFXfP8ZzL%2BhFRcQimfK95v8kaZQkH3E%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>


[Enhancement] Adding Tool-tips on icons

Currently there is tool-tip on the save request icon.

But there aren't any on the other icons

Adding tool-tips greatly enhances the experience as one doesn't have to press to see what does what do.

It seems like the referenced issue only added tooltips to one area. I think the request overall should be that icons in general should always have tooltips, so likely there should be an icon component that forces specifying tooltip-text.
I dont see https://github.com/usebruno/bruno/pull/1888 in v1.17.0 to confirm, but it appears to only address one of the two areas shown above.


[IS 6.0.0] Incorrect configuration in the Identity Server DocumentationConfigure Account Confirmation Methods for Self-Registration page

Is your suggestion related to a missing or misleading document? Please describe.
Below configurations are provided the the page[1] to configure default notification channel and to enable notification channel resolving.
[identity_mgt.user_self_registration]
default_notification_channel = ""
enable_resolve_notification_channel = true
Describe the improvement
Above tags are incorrect and should be corrected as below.
[identity_mgt.notification]
default_notification_channel = ""
resolve_notification_channel= true
[1] https://is.docs.wso2.com/en/6.0.0/guides/identity-lifecycles/self-register-verification/#!

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


1.11.2-1.4.3 Grid Null Pointer Exception Render Screen Crash

Issue description:
Sometimes there are slots in the grid that show 0 (Must be air?) When hover over them or scrolling in the inventory it seems to crash to desktop.
What happens:
Crash to desktop when rendering a null stack (null pointer exception renderscreen)
What you expected to happen:
Not to crash/ have empty item stacks rendered
Steps to reproduce:
1.Open grid
2.Shift-click items into the system.
3.When looking at the items in your system notice a slot with 0 and nothing in it.
...
Version (Make sure you are on the latest version before reporting):

Minecraft: 1.11.2
Forge: <IP_ADDRESS>2
Refined Storage: 1.4.3

Does this issue occur on a server? [yes/no]
Yes and single player also
If a (crash)log is relevant for this issue, link it here:
https://pastebin.com/sSAtuWpC
This is what the issue looks like :)
https://gyazo.com/bc051332bf0959ba7c0a62533c733a04

I can't reproduce this issue with your provided reproduction steps. Please provide better reproduction steps.

Interesting :/ but it happens and I have the image showing what is happening. Maybe its because I am using the external storage with drawers?

I need exact reproduction steps

Okay I think I have it now.
With using an external storage hooked to a drawer controller
1.Open crafting grid (things look fine)
2.Place down another drawer next to your drawer controller
3.Check crafting grid
4.Repeat a few times and this 0 item appears in the list when hovered over it crashes the game.
Simply breaking the external storage and replacing gets rid of this 0 item but it will occur every few extra drawers you add on AFTER the external storage is already hooked into the drawers set up.
Hopefully this will help :3

Interesting, let me look into this

Duplicate of #1183


Set of fixes

Coverage increased (+0.05%) to 87.454% when pulling a68d1506fc6a0f75a6fe354da9a814b67b975c95 on set_of_fixes into 09142e413cbf7532f427fd5632c75b472132026e on master.


Generated code for insert func,  individual parameters vs single struct

Not an issue just a question.  I see the example here of the generated code for authors uses go types and individual parameters
e.g. based on that I would expect something like this
func InsertSomething (ctx context.Context, name string, address string,...)
Instead for my query  it generates something like this:
func InsertSomething (ctx context.Context, params InsertSomethingParams).
Can this behavior be controlled?

Current behavior: if there's 0, 1, or 2 parameters, the parameters are inlined. If there's 3 or more parameters, pggen generates a struct.
The behavior is not configurable. I'm conservative with adding toggles since each one increases the testing surface.


Tied operands with different size

In https://immunant.com/blog/2020/01/quake3/ it was noted at the "Tied Operands in Inline Assembly" section that gcc and clang use the biggest of the operands as register size and then truncates when necessary. LLVM however leaves this undefined.

This is already covered in the draft RFC:

If an inout is used where the output type is smaller than the input type then some special handling is needed to avoid LLVM issues. See this bug.


serial communication with arduino

use jSerialComm to communicate with a serial port to send data to an Arduino. To be done in the backend package.

Determined that scanning then auto selecting a port would lead to too many errors, changing to using a user supplied port. Feedback to the user will be returned as a string so that it can be easily placed onto the frame.

moved from serial to serialconnection to ditch bloat and improve clarity while writing. No errors and should work fine


Reuplod function

Make a safe you fool

Great

Great

Nothing just testing a few things

Nothing just testing a few things


DO_NOT_MERGE CI smoke test #74

[https://github.com/thaliproject/CI/issues/74]
Added script which creates one native and one node test. Then edit proper files to execute only these tests.
This PR is not finished, there is no test for iOS. The final PR will be also to vNext, this one is to vNext_yarong_417_812 because this is the branch where node tests are working, so I can check if everything is ok with testing node layer.

This change is

PR is added to the queue for testing as 1. task. (526c333)

Hi @mlesnic, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Test (Success) 85019474 build is completed (526c333)
See https://github.com/ThaliTester/TestResults/tree/85019474526c333_Create_CI_smoke_test__74_mlesnic/ for the logs

Test<PHONE_NUMBER>6c333(526c333) has failed
See https://github.com/ThaliTester/TestResults/tree/85019474526c333_Create_CI_smoke_test__74_mlesnic/ for the fail logs

test/www/jxcore/CITestMode.js, line 41 at r1 (raw file):

  try {
    var path = '../../../src/android/test/io/jxcore/node/CITestClass.java';
    var content = 'package io.jxcore.node;\nimport org.junit.Test;\nimport static org.hamcrest.CoreMatchers.is;\

Better would be to copy these files instead of create them on the fly

Comments from Reviewable

For some reason phones are not connecting to Coordination Server.

PR is added to the queue for testing as 5. task. (3366852)

Test (Success) 85019474 build is completed (3366852)
See https://github.com/ThaliTester/TestResults/tree/850194743366852_DO_NOT_MERGE_CI_smoke_test__74_mlesnic/ for the logs

Test<PHONE_NUMBER>66852(3366852) has failed
See https://github.com/ThaliTester/TestResults/tree/850194743366852_DO_NOT_MERGE_CI_smoke_test__74_mlesnic/ for the fail logs

PR is added to the queue for testing as 2. task. (bab212f)

Test (Success) 85019474 build is completed (bab212f)
See https://github.com/ThaliTester/TestResults/tree/85019474bab212f_DO_NOT_MERGE_CI_smoke_test__74_mlesnic/ for the logs

Test 85019474bab212f(bab212f) has failed
See https://github.com/ThaliTester/TestResults/tree/85019474bab212f_DO_NOT_MERGE_CI_smoke_test__74_mlesnic/ for the fail logs

PR is added to the queue for testing as 3. task. (d947a2e)

Test (Success) 85019474 build is completed (d947a2e)
See https://github.com/ThaliTester/TestResults/tree/85019474d947a2e_DO_NOT_MERGE_CI_smoke_test__74_mlesnic/ for the logs

Test 85019474d947a2e(d947a2e) has failed
See https://github.com/ThaliTester/TestResults/tree/85019474d947a2e_DO_NOT_MERGE_CI_smoke_test__74_mlesnic/ for the fail logs

PR is added to the queue for testing as 3. task. (fcda771)

Test (Success) 85019474 build is completed (fcda771)
See https://github.com/ThaliTester/TestResults/tree/85019474fcda771_DO_NOT_MERGE_CI_smoke_test__74_mlesnic/ for the logs

Test 85019474fcda771(fcda771) has failed
See https://github.com/ThaliTester/TestResults/tree/85019474fcda771_DO_NOT_MERGE_CI_smoke_test__74_mlesnic/ for the fail logs

PR is added to the queue for testing as 3. task. (898df24)

Test (Success) 85019474 build is completed (898df24)
See https://github.com/ThaliTester/TestResults/tree/85019474898df24_DO_NOT_MERGE_CI_smoke_test__74_mlesnic/ for the logs

Test<PHONE_NUMBER>8df24(898df24) has failed
See https://github.com/ThaliTester/TestResults/tree/85019474898df24_DO_NOT_MERGE_CI_smoke_test__74_mlesnic/ for the fail logs

PR is added to the queue for testing as 1. task. (dae17e3)

Test (Success) 85019474 build is completed (dae17e3)
See https://github.com/ThaliTester/TestResults/tree/85019474dae17e3_DO_NOT_MERGE_CI_smoke_test__74_mlesnic/ for the logs

Test 85019474dae17e3(dae17e3) has failed
See https://github.com/ThaliTester/TestResults/tree/85019474dae17e3_DO_NOT_MERGE_CI_smoke_test__74_mlesnic/ for the fail logs

There is something wrong with running node tests. It seems that after native tests are finished, the application is restarted and unit native tests are executed over and over until timeout.


Issue in GAN-MNIST example, TypeError.

@gheinrich
Hello, I am trying to replicate the GAN example but it throws the following error in model create stage (Tensorflow visualiser also fails with same error).
Any opinions on what may cause this ?
Alp
2018-03-07 17:01:24.584062: I tensorflow/core/platform/cpu_feature_guard.cc:140] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2018-03-07 17:01:24.784821: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1212] Found device 0 with properties:
name: GeForce GTX 1080 Ti major: 6 minor: 1 memoryClockRate(GHz): 1.721
pciBusID: 0000:0a:00.0
totalMemory: 10.92GiB freeMemory: 10.60GiB
2018-03-07 17:01:24.784843: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1312] Adding visible gpu devices: 0
2018-03-07 17:01:24.990362: I tensorflow/core/common_runtime/gpu/gpu_device.cc:993] Creating TensorFlow device (/device:GPU:0 with 10262 MB memory) -> physical GPU (device: 0, name: GeForce GTX 1080 Ti, pci bus id: 0000:0a:00.0, compute capability: 6.1)
Traceback (most recent call last):
File "/home/alper/digits/digits/tools/tensorflow/main.py", line 743, in <module>
tf.app.run()
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/platform/app.py", line 126, in run
_sys.exit(main(argv))
File "/home/alper/digits/digits/tools/tensorflow/main.py", line 494, in main
train_model.create_model(UserModel, stage_scope)  # noqa
File "/home/alper/digits/digits/tools/tensorflow/model.py", line 150, in create_model
y=batch_y_split[dev_i])
File "/home/alper/digits/digits/tools/tensorflow/model.py", line 226, in add_tower
tower = obj_tower(x, y, input_shape, self.nclasses, is_training, is_inference)
File "<string>", line 220, in __init__
File "<string>", line 292, in dcgan_init
File "<string>", line 369, in build_model
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/histogram_ops.py", line 143, in histogram_fixed_width
values, value_range, nbins, dtype=dtype, name=name)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/gen_math_ops.py", line 1840, in _histogram_fixed_width
nbins=nbins, dtype=dtype, name=name)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/framework/op_def_library.py", line 720, in _apply_op_helper
attr_value.type = _MakeType(value, attr_def)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/framework/op_def_library.py", line 179, in _MakeType
_SatisfiesTypeConstraint(i, attr_def, param_name=attr_def.name)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/framework/op_def_library.py", line 60, in _SatisfiesTypeConstraint
", ".join(dtypes.as_dtype(x).name for x in allowed_list)))
TypeError: Value passed to parameter 'dtype' has DataType float32 not in list of allowed values: int32, int64

Last output:
Train batch size is 16 and validation batch size is 16
Training epochs to be completed for each validation : 1
Training epochs to be completed before taking a snapshot : 1.0
Model weights will be saved as snapshot_<EPOCH>_Model.ckpt
Found 52500 images in db /home/alper/digits/digits/jobs/20180307-162335-d97e/train_db

Here is some info about my linux:
$ uname -a
Linux alpcomp 4.13.0-36-generic #40~16.04.1-Ubuntu SMP Fri Feb 16 23:25:58 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

$ nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2017 NVIDIA Corporation
Built on Fri_Sep__1_21:08:03_CDT_2017
Cuda compilation tools, release 9.0, V9.0.176

$ pip show tensorflow-gpu
---
Metadata-Version: 2.0
Name: tensorflow-gpu
Version: 1.6.0
Summary: TensorFlow helps the tensors flow
Home-page: https://www.tensorflow.org/
Author: Google Inc.
Author-email<EMAIL_ADDRESS>Installer: pip
License: Apache 2.0
Location: /usr/local/lib/python2.7/dist-packages
Requires: astor, protobuf, gast, tensorboard, six, wheel, absl-py, backports.weakref, termcolor, enum34, numpy, grpcio, mock
Classifiers:
  Development Status :: 4 - Beta
  Intended Audience :: Developers
  Intended Audience :: Education
  Intended Audience :: Science/Research
  License :: OSI Approved :: Apache Software License
  Programming Language :: Python :: 2
  Programming Language :: Python :: 2.7
  Programming Language :: Python :: 3
  Programming Language :: Python :: 3.4
  Programming Language :: Python :: 3.5
  Programming Language :: Python :: 3.6
  Topic :: Scientific/Engineering
  Topic :: Scientific/Engineering :: Mathematics
  Topic :: Scientific/Engineering :: Artificial Intelligence
  Topic :: Software Development
  Topic :: Software Development :: Libraries
  Topic :: Software Development :: Libraries :: Python Modules
Entry-points:
  [console_scripts]
  freeze_graph = tensorflow.python.tools.freeze_graph:main
  saved_model_cli = tensorflow.python.tools.saved_model_cli:main
  tensorboard = tensorboard.main:run_main
  toco = tensorflow.contrib.lite.toco.python.toco_wrapper:main
  toco_from_protos = tensorflow.contrib.lite.toco.python.toco_from_protos:main
You are using pip version 8.1.1, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

Solved after downgrading to tensorflow 1.4.1.


Insert original ID column of uploaded MS1 file into exported document-csv files

Could we ensure that all the columns before mass and RT in an uploaded MS1 peak list csv file are copied into document-csv files exported (i.e., the csv file that contains information on the associated motifs and their probabilities and overlap scores). That would facilitate downstream data handling as those (ID) columns often contain unique identifiers. Now, the document IDs usually become mz_RT concatenations, which is very handy for the ms2ldaviz (as it is telling you the mass and RT of the parent mass directly) but not so much if you want to link the documents back to other (meta)-data.

Current code just ignored all the columns before "mass", so we can not recover that info from existing experiments.
But we may modify code to store all the columns before "mass" column, and put it into document-csv file in future experiments.

That would be very neat Frank! 🙂

Hi Justin,
How about this:

Looks good - I am assuming that the Peaklist Index column comes from the original MS1 csv file?

Yes, if there are some columns before "mass" in peaklist file, then assume it is users' index, and put it as 'Peaklist Index' in the table. If nothing before "mass", ignore this in the table.

Two questions:
i) What if there are two columns before? Otherwise we should (re-)specify the required format on the website to indicate that unique identifiers should be in front of the mass.
ii) can't we copy the name of columns over? Or is that not so easy? Otherwise, we should point out that the unique identifiers will be called 'Peaklist index"....

i) Currently I just concatenate everything before "mass" as index. But yes, I think keep them as two columns would be better.
ii) Yes, copy the name of columns would be better, will do ;)

re i) it is even essential if users want to use the values in those columns as unique identifiers to map to other tools/workflows :-)
re ii) cool!


Exit to photo grid programmatically?

Is there any function that I can use to exit to photo grid without pressing the 4-square button?

Hi @lincdh. I'm afraid there isn't anything to support that. Your best bet is to fork the library and make your modifications.


bug: item-right class no more interpreted in ion-item

Type: bug
Ionic Version: 2.x
Platform: all
I had some list items with either ion-badge tag or ion-icon tag set with item-right attribute. Since alpha 53 they are no longer right aligned.

What does your markup look like? I am not seeing this using the following markup switching between ion-badge and ion-icon:
<ion-item-sliding *ngFor="#session of group.sessions" #slidingItem [attr.track]="session.tracks[0] | lowercase" [hidden]="session.hide">

  <button ion-item (click)="goToSessionDetail(session)">

{{session.name}}

      {{session.timeStart}} —
      {{session.timeEnd}}:
      {{session.location}}

    <ion-badge danger item-right>24</ion-badge>
  </button>

  <ion-item-options>
    <button favorite (click)="addFavorite(slidingItem, session)" *ngIf="segment === 'all'">
      Favorite
    </button>
  </ion-item-options>

</ion-item-sliding>

Here is my markup. The sliding part is ok (Both icons are still on the right part)
`

 <ion-item-sliding #slidingItem *ngFor="#item of items | async">
    <ion-item (click)="itemTapped($event, item)">
          {{item.title}}
          <ion-span item-right [hidden]="!item.sawOn" class="timeAgo">{{item.sawOn}}</ion-span>
          <ion-icon danger name="heart" item-right [hidden]="!(item.fav && !filterFavorite && !item.sawOn)"></ion-icon>
    </ion-item>
    <ion-item-options>
       <button [hidden]="!(!filterFavorite && !item.sawOn)" (click)="favorite(item, slidingItem)">
          <ion-icon style="padding: 10px" danger name="heart" [isActive]="!item.fav">
       </ion-icon></button>
       <button (click)="share(item,slidingItem)">
          <ion-icon style="padding: 10px" name="share"></ion-icon>
       </button>
    </ion-item-options>
 </ion-item-sliding>

`

I copied your code in ion-item, changed item to session and just removed the hidden attribute from the icon and I am able to see it:
<ion-item-sliding *ngFor="#session of group.sessions" #slidingItem [attr.track]="session.tracks[0] | lowercase" [hidden]="session.hide">

     <ion-item (click)="itemTapped($event, item)">
           {{session.name}}
           <ion-span item-right [hidden]="!session.sawOn" class="timeAgo">{{session.sawOn}}</ion-span>
           <ion-icon danger name="heart" item-right></ion-icon>
     </ion-item>
     <ion-item-options>
        <button [hidden]="!(!filterFavorite && !session.sawOn)" (click)="favorite(session, slidingItem)">
           <ion-icon style="padding: 10px" danger name="heart" [isActive]="!session.fav">
        </ion-icon></button>
        <button (click)="share(session,slidingItem)">
           <ion-icon style="padding: 10px" name="share"></ion-icon>
        </button>
     </ion-item-options>

</ion-item-sliding>

Can you try running the conference app, compare your code against it and see if you notice anything different? https://github.com/driftyco/ionic-conference-app

By the way, may be I have an issue here for the inputs components since alpha 53 are disabled somewhat

ion-input in  read-only
ion-toggle in read-only
ion-checkbox in read-only

For the toggle, the (click) event is still handled however but the switch stays deselected although the inner button with role=checkbox" is set with the following: aria-disabled="false".
For the ion-toggle here is the markup:
`

     <ion-item>
       <ion-label>{{ 'Daily notifications' | translate }}</ion-label>
       <ion-toggle (click)="toggleNotifs()"></ion-toggle>
    </ion-item>

`
I'm waiting your return before opening another issue

Yes I'll do that for it seems an issue from my side :( It's a good chance to at last clone the conf app :)
Thanks for your help and time. I'll let you know.

I'm not seeing any issues with the toggle either. Did you find any cause for the previous issue that maybe is the same?

I suspect that both issues are related. I tested the conference app and it is working as expected.
I tried a 'npm install -g ionic@beta' command to replace my version but without better results. I'm at lost here. I'll try to create a simplistic page to see the result and check if any previous alpha directory may remain and may be the cause

Can you run ionic info and paste the output? Running npm install -g ionic@beta is updating the CLI, not the framework.

Thanks I'm still struggling with all the npm things (new to me).
The good news is that I fixed the icon, toggle and badge issues (I found your post in the forum explaining how to update ionic (thank bis) plus I hadn't created the new theme directory holding the scss when migrating to 51).
Now this is the sliding items (working previously) which does not work anymore whereas they are working in the conference app (I copied the sliding item conference app markup into my app and it's still not working, so it's on my side) :(.

Cordova CLI: 5.4.1
Ionic Version: 2.0.0-alpha.53
Ionic CLI Version: 2.0.0-beta.17
Ionic App Lib Version: 2.0.0-beta.8
OS: Windows 7 SP1
Node Version: v5.3.0

We created a section on npm in the docs to try to help explain it: http://ionicframework.com/docs/v2/resources/using-npm/
Is the item-right working correctly now?

Yes it works correctly, and the sliding item issue also. In fact it didn't work either on the conference app but to reproduce the issue I had to be in iPhone 4 config in google chrome. In larger config and ionic view it works both for the conference and my apps


[BUG] - Docker container does not shutdown cleanly on SIGTERM

Internal/External
External
Area
Docker
Shutdown hook
Summary
On bare metal, we can cleanly shutdown a node with SIGINT (i.e. Ctrl+C). The console reports this as Shutting down... In the log we see
Closed db with immutable tip at 9ecca9b01becb4647629d2aac28c661311890609a3a06da8d5a9708f02b1e5d4 at slot 18392924

Shutting down..

This is the desired behavior and perhaps most importantly, the node can startup again without significant delay
In a container environment, we may not get SIGINT but SIGTERM instead, see Gracefully Stopping Docker Containers
As a result, a containerized cardano node does not cleanly close the database and requires full database validation when started again. This may lead to a > 15min delay before the node is operational again
Steps to reproduce
docker run --rm \
  --name=relay \
  -e NETWORK=mainnet \
  -v shelley-data:/data/db \
  inputoutput/cardano-node

docker stop relay
docker start relay

Expected behavior
On restart the node should not need to validate the db. The shutdown hook should work for SIGTERM as it does for SIGINT
Additional context
You can leave this to me, I'll provide a PR.
CrossRef: https://github.com/tdiesler/nessus-cardano/issues/11

This would be great! 👍

Thanks. Most of the functionality talked about in [#2360] is already available in nessusio/cardano and I only just now feel brave enough to touch the upstream Nix build ;-)

I very quickly skimmed through your repo and will definitely spend some more time there looking into how you've set up some things.
I am currently playing around with a docker based set up for a stake pool. I really just started two days day ago, so I am pretty much exploring the tools and understanding how things are connected.

There is also this gitbook
https://app.gitbook.com/@tdiesler/s/cardano/

PR #2375

This is now part of #2393

This is now part of #2393

Merged

Fixed in 952ce084373908f275110f57a43cea338604c4b3.


Libdoc: List enums and TypedDicts used as argument types in HTML automatically

Libdoc does now store data types like Enums and TypedDicts in the JSON and XML output.
These data types shall be readable in Libdoc HTML

[x] List of custom DataTypes shall be part of the Keyword list

[x] Data types shall be searchable

[x] Data types shall be linked from floating text and from argument interface

[x] Data types shall show the doc information that is stored in them.

This functionality still needs to be documented in the User Guide.

I documented this functionality in cd8a0b19fc46ab51fb126a00fa6199c106097adb. Could you @Snooz82 take a look and close this issue if you consider it good enough?

No feedback but I guess docs are good enough.


Update iOS example to use graphhopper 1.0

Most of the work in this PR has done by @oflebbe. My repository is forked from his https://github.com/oflebbe/graphhopper-ios
If it's incorrect way to make a contribution I'm ready to direct my PR to @oflebbe repository first and wait for his approval.
Main changes from my side:

[x] Updated iOS code to use graphhopper 1.0 method names
[x] Point graphhopper submodule to use proper state of ios_compatibility branch
[x] Removed failing architectures from build script
[x] Changed script that downloads map to retrieve Isle of Man as it's small and it's visually clear where to try directions calculation.
[x] Updated instruction how to use example

Thanks for the credits. I think this PR is correctly placed to this repository.

Thanks!

It works for me as well!

Thanks @OlKir for finishing it!

Really nice! Thank you @OlafFlebbeBosch & @OlKir !

Just tweeted a just history summary of this project :)
https://twitter.com/graphhopper/status/1443869754855469056


Stack Club meeting on Friday Nov. 30

Stack Club members,
We will have our weekly Stack Club session this coming Friday, Nov. 30th, usual time, 9AM PST:  we will use the usual zoom http://stanford.zoom.us/j/946390572 .  The "featured presentation" will be by Simon Krughoff - it will cover the new notebooks from the Camera/Commissioning bootcamp which took place the week before Thanksgiving.
--Alex, Greg and Phil

We will start in a few minutes.  See you at zoom!  --Greg

This was a good session - great to hear more about the data for, and notebooks from, the Camera/Commissioning Bootcamp! Video is now up, on the Meetings page.

Thanks for adding it!  I missed that meeting, and am glad the videos are now available!
Best regards,
Douglas
--
Douglas L. Tucker
Fermilab                        Tel:    +1-630-840-2267
MS 127                          FAX:    +1-630-840-8274
PO Box 500                      E-mail<EMAIL_ADDRESS>Batavia, IL 60510 USA           http://home.fnal.gov/~dtucker/
From: Phil Marshall<EMAIL_ADDRESS>Reply-To: LSSTScienceCollaborations/StackClub<EMAIL_ADDRESS>Date: Thursday, December 6, 2018 at 1:09 PM
To: LSSTScienceCollaborations/StackClub<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [LSSTScienceCollaborations/StackClub] Stack Club meeting on Friday Nov. 30 (#161)
This was a good session - great to hear more about the data for, and notebooks from, the Camera/Commissioning Bootcamp! Video is now up, on the Meetings pagehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_LSSTScienceCollaborations_StackClub_blob_master_Meetings.md&d=DwMFaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=R-57Mm7OJX1IswbY4ezVTQ&m=G17lRy5VL5d7W1K6xJN_JlIC-E-JFsbj7lAjxebwYy4&s=FqrzTraRmqVMjJa4wnyOMAnOyVupQNLuauR-3kqp6c0&e=.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_LSSTScienceCollaborations_StackClub_issues_161-23issuecomment-2D444991679&d=DwMFaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=R-57Mm7OJX1IswbY4ezVTQ&m=G17lRy5VL5d7W1K6xJN_JlIC-E-JFsbj7lAjxebwYy4&s=85CWeZ4QHCaoACPm3vkroccPy3QSvqna0Tvr_ts-wU4&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ACIDuXpsT60ujviAxQcU7CmzdIuNo6-2DLks5u2WtHgaJpZM4Y4TuG&d=DwMFaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=R-57Mm7OJX1IswbY4ezVTQ&m=G17lRy5VL5d7W1K6xJN_JlIC-E-JFsbj7lAjxebwYy4&s=rIjkSX9oks3FK1PUyPf2bwwlmvFRxhCAUO2GlTSC0X4&e=.


Add SAP ASE link to ANF solution architectures

Hi team,
Can you please add the following link:
https://docs.microsoft.com/en-us/azure/virtual-machines/workloads/sap/dbms_guide_sapase
To the AnyDB section:
https://docs.microsoft.com/en-us/azure/azure-netapp-files/azure-netapp-files-solution-architectures#sap-anydb
Thanks,
Gr. Rutger

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06cdfa32-759b-d946-00ff-3a43420fd375
Version Independent ID: 04675450-c497-88a8-3c4c-67b91163baa5
Content: Solution architectures using Azure NetApp Files
Content Source: articles/azure-netapp-files/azure-netapp-files-solution-architectures.md
Service: azure-netapp-files
GitHub Login: @b-hchen
Microsoft Alias: anfdocs

@RutgerKostersThanks for the question! We are investigating and will update you shortly.

@RutgerKosters - Thanks, Rutger!  We'll implement after confirming with Geert.
cc: @b-ahibbard

#please-close


new style for pv pvc

What type of PR is this?

What does this PR do?

Which issue(s) does this PR fix?

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

/lgtm
/approve


add recursive version of fibonacci algorithm

Done.

Please add Hacktoberfest label.

Thanks

Added my implementation on FibonacciRecursive.java #345

@Thuva4 please check pull request #442

@CarlosPadilla Fibonacci program is added pull request #442


Undeclared dependency

With React+TS, when I run 'yarn dev' for the first time there is an error:
Error: vite-express tried to access picocolors, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: picocolors

HI @shaheerszm, can you tell me if you installed vite-express as a dependency yourself or did you use create-vite-express package to setup the project? For me it looks like you don't have Vite installed as a dependency because I rely on it to have picocolors installed, that's why it is defined as a peer dependency instead of a dependency. We can rely on the Vite to have it because you need to have Vite installed either way to use the vite-express package. If you don't have it installed you can try installing Vite. If that doesn't help, please provide me some more info so I can help you. Thanks in advance!

I used the command yarn create vite-express to setup the project. yarn version 3.4.1 and node version 18.9.0 in WSL2.0 (Ubuntu). I've used Vite to create other React+TS projects without issues before.
I don't know if this is relevant but I'm also using Yarn  @Plug'n'Play
@szymmis

Thanks for your reply @shaheerszm. Info about using plug-n-play is very relevant because I think that it is a root cause why you have that problem and I don't. I've published fix in v0.5.1, can you check if the problem was solved or not?

Should be fixed by #32.


Support<EMAIL_ADDRESS>

getting the following errors:
npm i<EMAIL_ADDRESS>npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@apollo/federation
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/typegraphql-nestjs
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/sgentile/.npm/eresolve-report.txt for a full report.

If I switch to 0.29, then it wants "@nestjs/graphql": "^8.0.2", but then it requires Conflicting peer dependency<EMAIL_ADDRESS>so it cascades down etc...
These are the defaults right with latest NestJS:
"dependencies": {
        "@apollo/federation": "^0.33.0",
        "@nestjs/common": "^8.0.0",
        "@nestjs/config": "^1.0.1",
        "@nestjs/core": "^8.0.0",
        "@nestjs/graphql": "^9.0.5",
        "@nestjs/platform-express": "^8.0.0",
        "@nestjs/swagger": "^5.1.0",
        "@nestjs/terminus": "^8.0.1",
        "@prisma/client": "^3.1.1",
        "apollo-server-express": "^3.3.0",
        "graphql": "^15.6.0",
        "reflect-metadata": "^0.1.13",
        "rimraf": "^3.0.2",
        "rxjs": "^7.2.0",
        "ts-morph": "^12.0.0"
    },

getting the following errors:
npm i<EMAIL_ADDRESS>npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@apollo/federation
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/typegraphql-nestjs
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/sgentile/.npm/eresolve-report.txt for a full report.

If I switch to 0.29, then it wants "@nestjs/graphql": "^8.0.2", but then it requires Conflicting peer dependency<EMAIL_ADDRESS>so it cascades down etc...
These are the defaults right with latest NestJS:
"dependencies": {
        "@apollo/federation": "^0.33.0",
        "@nestjs/common": "^8.0.0",
        "@nestjs/config": "^1.0.1",
        "@nestjs/core": "^8.0.0",
        "@nestjs/graphql": "^9.0.5",
        "@nestjs/platform-express": "^8.0.0",
        "@nestjs/swagger": "^5.1.0",
        "@nestjs/terminus": "^8.0.1",
        "@prisma/client": "^3.1.1",
        "apollo-server-express": "^3.3.0",
        "graphql": "^15.6.0",
        "reflect-metadata": "^0.1.13",
        "rimraf": "^3.0.2",
        "rxjs": "^7.2.0",
        "ts-morph": "^12.0.0"
    },

I stuck on this issues, same with you
Workaround downgrade @apollo/federation to 0.29.x to solve this but don't know how to fix that in another way

Closing in favor of #32 🔒


Include line and column number for invalid character errors

Users can choose to add text to their game with addText. However, the font has a limited support for special characters. An error will appear when the user tries to character add text with unsupported characters. This change was implemented in (#1030) and can be seen in the Sprig Engine.
The example of the current error looks as follows.
Error: Character $ is not in the font. It will be rendered incorrectly.

As a quality of life change, it would help to include information about where the invalid character is.
An example of how this could look:
Error: Character $ is not in the font. It will be rendered incorrectly.
    at <game>:39:16

@SamDev-7 I am sorry for the slow response on this issue - however, I do not see sufficient information here for this issue to be actionable.  Can you please update the description and title of this issue to be more clear re: exactly what the feature request is - because I read this and while I could jump to conclusions, I'd rather not...
Please assign this back to me once you've added info here to make this actionable...

I have updated the description, let me know if further clarification is needed.

@leomcelroy please weigh in on your approval/disapproval re: this feature request.  If you approve, do please specify the full set of characters you feel we should support.  If you do not approve, plz close w/ commentary.

These characters are supported
!"#%&'()*+,./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ\^_-`abcdefghijklmnopqrstuvwxyz|~¦§¨©¬®¯°±´¶·¸ÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖ×ÙÚÛÜÝÞßàáâãäåæçèéêëìíîïñòóôõö÷ùúûüýþÿĀāĂăĄąĆćĊċČčĎĐđĒēĖėĘęĚěĞğĠġĦħĪīĮįİıŃńŇňŌōŒœŞşŨũŪūŮůŲųŴŵŶŷŸǍǎǏǐǑǒǓǔˆˇ˘˙˚˛˜˝ẀẁẂẃẄẅỲỳ†‡•…‰⁄™∂∅∏∑−√∞∫≈≠≤≥◊
I do support improving the error messages to include error location when possible.


:bug: Only include probes which ran for probe format

What kind of change does this PR introduce?
bug fix

[X] PR title follows the guidelines defined in our pull request documentation

What is the current behavior?
All probes are evaluated when the probe format is specified, regardless of which checks run. Since the rawdata wasn't fetched by the various checks, the extra probes are not only distracting but the results are wrong.

Click to see example
SCORECARD_EXPERIMENTAL=1 go run main.go --repo github.com/ossf/scorecard --checks Binary-Artifacts --format probe
{
  "date": "2024-04-02",
  "repo": {
    "name": "github.com/ossf/scorecard",
    "commit": "d58bfb03aab496807d8489e09da9883928465f59"
  },
  "scorecard": {
    "version": "",
    "commit": "unknown"
  },
  "findings": [
    {
      "probe": "freeOfUnverifiedBinaryArtifacts",
      "message": "Repository does not have binary artifacts.",
      "outcome": 12
    },
    // all other 50+ probes
    {
      "probe": "webhooksUseSecrets",
      "message": "Repository does not have webhooks.",
      "outcome": 20
    }

What is the new behavior (if this is a feature change)?**
Just the probes which correspond to the --checks which ran are included in the output.

Click to see example
SCORECARD_EXPERIMENTAL=1 go run main.go --repo github.com/ossf/scorecard --checks Binary-Artifacts --format probe | jq
{
  "date": "2024-04-02",
  "repo": {
    "name": "github.com/ossf/scorecard",
    "commit": "d58bfb03aab496807d8489e09da9883928465f59"
  },
  "scorecard": {
    "version": "",
    "commit": "unknown"
  },
  "findings": [
    {
      "probe": "freeOfUnverifiedBinaryArtifacts",
      "message": "Repository does not have binary artifacts.",
      "outcome": 12
    }
  ]
}

- [ ] Tests for the changes have been added (for bug fixes/features)
Which issue(s) this PR fixes
Fixes #3049 (but left one TODO for #3979)

Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

/scdiff generate Pinned-Dependencies,Security-Policy,Binary-Artifacts,Dangerous-Workflow,Branch-Protection,Dependency-Update-Tool,Fuzzing,Signed-Releases,CII-Best-Practices,Maintained,CI-Tests,Vulnerabilities,Code-Review,Contributors,License,Token-Permissions,SAST,Packaging


Line position is not getting updated when 'endElement' position changes

Hi , I'm trying to create a some connection between two tree nodes using 'Leader-line'

Connection lines are loading properly when we add the connections, later if we expand the parent nodes or child nodes in the tree, the line connections are misplaced.

What can be done for this issue ?

Hi @Albinvadakan, thank you for the comment.
You have to call position method when you changed the layout of the page.

No reply came, then this abandoned issue is closed.


Nicer API error returns

Currently a lot of erroneous API calls, like trying to insert duplicates into the database, result in horrific return responses with full stack traces for the error that Python raised in the backend. These should be replaced with more informative and concise messages like "400: This sensor already exists".

This came up again as a feature request from UPC.


HttpRequestMessage disposes user-provided Stream object

Wrapping HttpRequestMessage in using block causes it to call .Dispose() on underlying Content object
https://github.com/TelegramBots/Telegram.Bot/blob/a58445e42b2d34cceedfdcbf477b027c9b3e9e68/src/Telegram.Bot/TelegramBotClient.cs#L119-L122
Since we do not own this Stream we should either get rid of using block, or document this behaviour.

Discussion links:
https://t.me/c/1142631927/89907
https://t.me/c/1142631927/89911

Done in #1102


Some improvements and a new shape get_points()

New improvements and the new shape get_points().
New shape: get_points()
from termshape import get_points
points_array = [(0, 0), (0, 9), (9, 0), (9, 9)]
print(get_points(10, 10, points_array, bg='.'))

 *

Other changes

Big changes in docstrings (better style)
validate_positive_params() is now a hidden function (_validate_positive_params())
_validate_positive_params() automatic raises a TypeError("Only positive integers are allowed")
In all the shapes, foreground and background characters is now fg and bg keyword arguments
fg and bg must always be keyword arguments (for style purpose)
The parameter fpercent of get_circle() expects a percent of type float (fpercent=0.05 for 5%), now is an integer (fpercent=5 for 5%)
All expressions lists inside the shapes functions is sets (for optimization)
Minimal changes in the code style

Info
The __version__ is "PLACE VERSION HERE", so change it.
I placed a example of get_points() in README.md and maked compatibly with this pull request, but not an example in test_termshape.py.
I think that i mentioned all the changes, you can change anything if i forget something.

There's 1 error because i dont changed test_termshape.py.

Great!

On the version variable i didn’t understand why did you change from 1.0.0 to something else.
On the function get_points - you don’t need the 2 first parameters- you can calc it in the function. At least you can leave them as optional parameter.

Thank again.

Using the bigger (x, y) as the width and height?


Route change scroll behavior

Added anchor link functionality to UniversalLink component.
New logic for ScrollToTop to handle anchor links and scroll restoration with configurable scroll behavior (auto or smooth)

Just to say: I'm not a huge fan of big JavaScript manipulations, if I click on a link I'm not expecting much JS to run, I'd only expect a navigation.
This said, I think this can be very pleasant for users navigating the website.
Maybe is there a lighter way to do this? I know there are libraries like https://www.npmjs.com/package/react-scroll-restoration to accomplish a part of this, thus we can lighten UniversalLink.
UniversalLink is my worry and I'd like to keep it as simple as possible.

This is indeed a big UX problem we currently face in Volto. From the user's perspective scroll sometimes happens randomly and ends up. That being said I fully agree with @nzambello here. We tried to tinker around with scrolling in our projects and failed every single time. This is a very complex use case and the right response to this is to simplify things, not add more complexity. We should discuss this in our next @plone/volto-team meeting.
cc @iFlameing

This really needs to be fixed: https://github.com/plone/volto/blob/master/src/helpers/ScrollToTop/ScrollToTop.jsx#L32
It interferes with the SearchBlock facets.

@tisto @nzambello @razvanMiu  I think that this is a complex problem. I already spend several days on this. Every time I tried to fix this, it is not 100%. I also tried the use the library like  https://www.npmjs.com/package/react-scroll-restoration but had hard luck. When I throttle my CPU and network I always see the browser scrolling to the top. Same with the browser back button. I really would like to check how the browser back button works with this implementation because changing scroll behavior to manual has some consequences.

@tiberiuichim @tisto I did a fair amount of testing on this branch as well as master. Here is some finding.

The current implementation changes how the route changes. Previously, we first got to the top of the page and then changed the route, but this implementation changes the route first and then scroll to the top of the page. The smooth transition doesn't make much sense in the current implementation.
We still have the scrolling effect which we don't want.
3.Then only major difference this implementation makes is the first point. Other than that I don't think it adds anything because the current implementation is able to handle all the cases. Yes! there will be some time when the browser messes the scroll position using the back and front buttons. The current implementation handles it more effectively.

@iFlameing when you say the current implementation, what are you referring to? This PR's? or the one in master?

@sneridagh this pr.

@nzambello @tisto @sneridagh  Hi, sorry for not answering, I've been in holidays so:

For anchor links the current implementation scrolls to top for any changes of the route and doesn't handle anchors so to keep the scroll to top behavior and also handle the anchor links I overwrite the click event on UniversalLink (https://github.com/plone/volto/pull/2592/files#diff-c0021190896d8196577b4d304ac09c44abff5437fcf56791f7832c522f43ea01R86-R107), if the url has hash string into it, only to change the route (history.push) with a state (volto_scroll_hash -> needed so that we can strip the hash from url and keep the corresponding element id, volto_scroll_offset -> needed so that we can add y-offset) and also to add some optional delay before the link get triggered (a use case for this would be if you have an animated dropdown menu with anchor links and if you press a link you want to scroll to the corresponding element after the closing animation of the dropdown menu has finished - I can get into more details about this). @iFlameing You said Previously, we first got to the top of the page and then changed the route, but this implementation changes the route first and then scroll to the top of the page but in both implementation, master and this, the scroll happens after the change of the route so I'm not sure if I understand you correctly (https://github.com/plone/volto/blob/master/src/helpers/ScrollToTop/ScrollToTop.jsx#L33). Maybe your problem is that the scrolls happens after the content is loaded (https://github.com/plone/volto/blob/route_change_scroll_behavior/src/helpers/ScrollToTop/ScrollToTop.jsx#L80 -> line 83) but this is needed,  in my opinion, because the route is changed before the content of the new page is loaded.
For the scroll restoration part my implementation is based on https://www.npmjs.com/package/react-scroll-restoration and is needed only to add the smooth scroll behavior and make use of the scrollTo function that waits for content load before scrolling. So we can keep the basic javascript scroll restoration but we can't make it smooth and we can't make sure that it will scroll to the right position (https://github.com/plone/volto/pull/2592/files#diff-1712f4ab0dc421cacb610886108bb1e5cd7978212604901774cf341a5fcf9ed1R9).
@tiberiuichim I'll take a look to see what is the incompatibility with SearchBlock facets.

@tiberiuichim I'll take a look to see what is the incompatibility with SearchBlock facets.

No need, it was a side-issue, not relevant in this PR. Just something to keep into consideration.


GH-2796: Fix partition count related issues

If a target middleware (Kafka for ex) topic has more partitions than what is set on the partition-count producer property, the binder never updates the original producer partition-count property to the partition count from the middleware if it is higher than what was given through the property. Because of this, te PartitionAwareFunctionWrapper which evaluates and assigns the partition header in Spring Cloud Stream does not compute the correct partition since the hash operation still using the original partition-count from the producer binding property. This commit is addressing this issue.
Resolves https://github.com/spring-cloud/spring-cloud-stream/issues/2796

I think we are maybe hitting this bug with Spring Cloud Stream 4.0.4. Does it need to be backported to the 4.0.x branch for the next Spring Cloud 2022 release?


generate and hide root node and make it unable to be deleted

Can godot please automatically add and hide root node in the scene?
I am using 3.0.6 and it's very frustrating that I need to add a root node every time I make a scene.
on top of that the root node isn't even able to be saved as a object so if someone accidently adds a node
and children of it and tries to save it as a prefab they can't because it's the root node!
the scene itself should be a root node and then the scene editor should be what is in the root node.
I don't even see what the point in having the root node is in the editor when the who scene should be a root node anyways.
this would solve problem with people needing to reparent the root since it it would be automatically generated, hidden, and non removable.
here is another example of the problem with not generating a root node

as you can see when I open my prefab it doesn't generate root node so I can't save the modifications I do to it.

Well, in 3.1 this is handled in elegant way, so you could wait for 3.1 or use master branch or backport that feature.

how did they do it in 3.1?

Just show menu of nodes on new scene with some common defaults, you
can see for yourself.
On Mon, Feb 11, 2019 at 6:28 AM Shadowblitz16<EMAIL_ADDRESS>wrote:

how did they do it in 3.1?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

All scenes have a root node, if you hide it, you would not know how to access, add scripts, etc., is the way Godot scene tree works.
That root is also the owner used for serialization, you must to be able to see it.
I recommend you to read the documentation to understand how the scene and node system.

@slapin ok i will check it out.
@eon-s  even if it wasn't hidden it should still be generated on every new scene as the root node.

No, the root node should not be "generated". It's something that you should choose according with what you want your scene to be. The root node can be any kind of node, and its type has a big influence on how your set up your scene and write your code.
You seem to be unfamiliar with Godot scenes and what the root node actually is, so I would advise to review the Step by Step tutorial: http://docs.godotengine.org/en/3.0/getting_started/step_by_step/scenes_and_nodes.html