fix: use revm to calculate gas stipend

This also includes 21k+ for initial tx cost, idk if this is right, cc @mattsse @klkvr

Right, missed that

Also some extra perf because revm calculation is better


Unique fields

The scaffold generator does not allow a model to be updated if it contains a unique field.
For example field a is unique, field b is not. If i update field b it will not save.

In the updaterequest, set rules method to:
    public function rules()
    {
        $rules = Model::$rules;
        //$rules['unique_field'] = $rules['unique_field'] . ',unique_field,' . $this->id;
        return $rules;
    }

@NightZpy that didn't work, unfortunately.

@showFocus Some error?

@NightZpy "The name has already been taken."

Is strange, for me, works! :(

@NightZpy Strange indeed! Here are my model, controller and Request file.
public function rules()
    {
        $rules = Category::$rules;
        $rules['name'] = $rules['name'] . ',name,' . $this->id;
        return $rules;
    }

public function update($id, UpdateCategoryRequest $request)
    {
        $category = $this->categoryRepository->findWithoutFail($id);

        if (empty($category)) {
            Flash::error('Category not found');

            return redirect(route('categories.index'));
        }

        $category = $this->categoryRepository->update($request->all(), $id);

        Flash::success('Category updated successfully.');

        return redirect(route('categories.index'));
    }

public static $rules = [
        'name' => 'required|unique:categories,name'
    ];

My UpdateREquest:
<?php

namespace App\Http\Requests\API\Kitchen;

use App\Models\Kitchen\Provider;
use App\Http\Requests\API\MyAPIRequest;

class UpdateProviderAPIRequest extends MyAPIRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        $rules = Provider::$rules;
        $rules['name'] = $rules['name'] . ',name,' . $this->id;
        $rules['email'] = $rules['email'] . ',email,' . $this->id;
        return $rules;
    }
}

Rule set:
  public static $rules = [
       'name' => 'required|min:1|max:128|unique:providers',
       'specialty' => 'required|min:1|max:128',
       'district' => 'min:1|max:128',
       'address' => 'min:12|max:512',
       'phone' => 'required|numeric|digits_between:7,20',
       'movil1' => 'numeric|digits_between:7,20',
       'movil2' => 'numeric|digits_between:7,20',
       'contact' => 'min:1|max:128',
       'email' => 'required|email|min:3|max:128|unique:providers'
   ];

In your rule, delete name at last of the rule definition!

@NightZpy No, that didn't work.

I will be working on it in next week. Will post update once its done.

This is what I came up with, in my update request
public function rules()
    {
        $rules = Category::$rules;
        if ($this->isMethod('patch'))
        {
            $id = $this->categories;
            $rules['name'] = $rules['name'].',name,'.$id;
        }
        return $rules;
    }

@showFocus What is $this->categories ?

It's a reference to the 'id' of the model instance. Without it you can't pass the id of the model instance to the next statement. You get an 'undefined variable' error

For me the hack work with my table name :

$rules = Client::$rules;
$rules['nom'] = $rules['nom'] . ',nom,' . $this->clients;
return $rules;

I have just come across this problem today, and have found the following worked for me:

In the view file (which contains the form to update a particular entity), create a hidden input field, e.g:

{!! Form::model($user, ['route' => ['users.update', $user->id], 'method' => 'patch']) !!}
	{{ Form::hidden('user_id', $user->id, array('id' => 'user_id')) }} ## The hidden input field ##

	## The rest of the fields are in the partial below: ##
	@include('users.fields')

{!! Form::close() !!}

2. Modify your entity's request object's rules() method as follows:

/**
* Get the validation rules that apply to the request.
*
* @return array
*/
public function rules()
{
$rules = User::$rules;
if($this->isMethod('patch')){
	    // Retrieve the entity's i.d from the hidden input field.
        $id = $this->input('user_id');

        $rules['username'] = $rules['username'].', '.$id;
        $rules['email'] = $rules['email']. ', '.$id;
        //dd($rules);
    }
    return $rules;
}

3. In your entity's Model class, make sure your rules array looks like the following:

// Here, I have two unique fields that could need updating.
//
// NOTE: I put the min/max/email requirements at the end, and that did not work. Putting
//       them at the front, as in this example, worked for me.
public static $rules = [
    'username' => 'min:5|max:25|required|unique:users,username',
    'password' => 'required|min:6',
    'email' => 'email|required|unique:users,email',
    'firstname' => 'required|max:100',
    'lastname' => 'max:100',
    'phone' => 'max:15'

];

4. Once you have done the above three steps, updating your entities should work as intended (unless you also have other logic implementations that could affect updating).

I figured i would share the simple change that has been working for me and requires updating only one file/function. It also helps to prevent the case where the update function will allow you to update the field to a value already in the database.
In this example I'm working with the model Job
Verify that your model has valid rules set
    public static $rules = [
        'job_name' => 'required',
        'job_code' => 'required|unique:jobs'
    ];

Then open the update request file for the model App\Http\Requests\UpdateJobRequest.php
By default, the scaffold generator will create the following rules function.
    public function rules()
    {
        return Job::$rules;
    }

Change it to the following...
    public function rules()
    {
        $rules = Job::$rules;

        // get ID of the job being edited.
        $requestID = (int)$this->job;

        // get job code from the request (form data), cast the value per your models design.
        $requestCode = (int)$this->job_code;

        // fetch current job code from db, if there is a better way to do this part, please let me know
        $job = Job::where('id', $requestID)->first();

        // get current job code
        $currentCode = $job->job_code;

        /**
         * Now check if the "job_code" field will be updated.
         * If the "job_code" field isn't being updated, we need to change the rule to ignore the unique value.
         * If "job_code" is being updated we want to make sure it's unique.
         */
        if($requestCode == $currentCode){
            // update didn't change job code, so we want to ignore this id for the unique validation.
            $rules['job_code'] = $rules['job_code'].',id,'.$requestID;
        }

        return $rules;
    }

Now the validation rules will ignore the job_code field if it's not being changed in the request. However, if the value is being changed, the validator  will check if it's unique.

Thats Worked for me
public static $rules = [     'title'  => [       'required',       'min:2',       'max:255',     ],     'locale' => [       'required',       'min:2',       'max:255',     ],   ];
CreateLanguageRequest.php
public function rules()     {       $rules = Language::$rules;       $rules['title'][] = 'unique:languages';       $rules['locale'][] = 'unique:languages';       return $rules;     }
UpdateLanguageRequest.php
public function rules()   {     $rules = Language::$rules;     $rules['title'][] = Rule::unique('languages')->ignore($this->language);     $rules['locale'][] = Rule::unique('languages')->ignore($this->language);     return $rules;     // return Language::$rules;   }

I was a bit confused  with previous comments, so the simpler solution (as posted before in some comments, but more explicit :P):

Your model's name is 'Utilizador' and you want the email field to be unique and avoid "update error validation"
`public static $rules = [
  'email' => 'required|email|unique:users,email,',
  'name' => 'required|string|min:4'

];`

So go to your 'UpdateUtilizadorRequest' and change function rules:
`public function rules()
{
$rules          = Utilizador::$rules;
$rules['email'] = $rules['email'].$this->utilizadors;
  return $rules;

}`

Don't forget your current object use the "plural name" or else you won't get current object id.

Are there updates on this issue?


svg render is a bug on archlinux

On 11.05, after the system update of archlinux, the render of svg is totally a bug

seems the wp_viewporter does not works for svg anymore.. I do not know if it is the bug of sway something  else

I have tried niri... it works good on niri.. so emm, it is the bug of sway or the lib used by sway? then what lib?

ok. it is the problem of nvidia


shock_history instead of history namespace for read_shocks

Fixes #808
Please ensure your pull request adheres to the following guidelines:

[X] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
[x] Update CHANGELOG.md with major/minor changes.

merge before #803


poor conversion between lchab and srgb

lchab may be converted to value that is not optimal. For example LCHabColor(89, 7, 75) is converted to rgb(231, 222, 211) but for example rgb(233,222,211) would be a better target.
rgb(231, 222, 211) converted back to lchab is (88.9, 6.8, 79.8)
rgb(233, 222, 211) converted back to lchab is (88.7, 6.9, 74.2) what is closer to (89, 7, 75)
It is also possible that rgb to lchab conversion is broken. According to http://www.brucelindbloom.com/index.html?Math.html lchab -> srgb conversion works and srgb -> lchab is broken.
Curiously, http://www.colorhexa.com/ has different results for lchab -> srgb conversion but the same for srgb -> lchab.
According to brucelindbloom lchab(89, 7, 75) = rgb(231.3, 222.1, 210.7)
According to colormath it is (231, 222, 211)
According to colorhexa.com it is (233, 222, 211).
According to brucelindbloom rgb(231, 222, 211) = lchab(89.0, 6.8, 74.7)
According to colormath it is lchab(88.6, 6.7, 79.5)
According to colorhexa.com it is lchab(88.9, 6.6, 79.5)
Either there is something broken somewhere or I am missing parameter that is set differently in these tools. I see no way to set reference white and adaptation in python-colormath and colorhexa, so it seems that d50 and Bradford may be assumed to be defaults. sRGB nearly certainly may be assumed to be default in colorhexa.
from colormath.color_conversions import convert_color
from colormath.color_objects import LabColor, LCHabColor, SpectralColor, sRGBColor, \
XYZColor, LCHuvColor, IPTColor

lch = LCHabColor(89, 7, 75)
rgb = convert_color(lch, sRGBColor)
print(rgb.get_upscaled_value_tuple())
lch = convert_color(rgb, LCHabColor)
print(lch.get_value_tuple())

other_rgb = sRGBColor(233.0/256,222.0/256,211.0/256)
lch = convert_color(other_rgb, LCHabColor)
print(lch.get_value_tuple())

other_rgb = sRGBColor(231.0/256,222.0/256,211.0/256)
lch = convert_color(other_rgb, LCHabColor)
print(lch.get_value_tuple())

Current python-colormath seems correct overall, it is probably just related to whitepoint assumptions and the being CAT used:
import colour

# Assuming linear integer values.
sRGB = np.array([231., 222., 211.])
sRGB /= 255.

D50 = colour.ILLUMINANTS['cie_2_1931']['D50']
# CAT02 CAT by default in Colour.
print(colour.Lab_to_LCHab(colour.XYZ_to_Lab(colour.sRGB_to_XYZ(sRGB, D50), D50)))
# [ 88.98067605   6.90235558  75.13893553]

print(colour.Lab_to_LCHab(colour.XYZ_to_Lab(colour.sRGB_to_XYZ(sRGB, D50, 'Bradford'), D50)))
# [ 88.96687738   6.8042839   74.74557839]

D65 = colour.ILLUMINANTS['cie_2_1931']['D65']
print(colour.Lab_to_LCHab(colour.XYZ_to_Lab(colour.sRGB_to_XYZ(sRGB), D65)))
# [ 88.89177036   6.59010903  79.54149464]

So the problem is that in conversion from lchab to srgb and from srgb to lchab default whitepoint is different?

@KelSolaar How can I run this code? Adding import numpy as np is not enough, it still crashes with AttributeError: 'module' object has no attribute 'ILLUMINANTS' on

D50 = colour.ILLUMINANTS['cie_2_1931']['D50']

It is using an alternative colour science API for Python I'm contributing to: Colour
I'm watching closely Python-Colormath though :)

python-colormath behaviour is correct here, probably a mix of different CAT and precision settings as per https://github.com/gtaylor/python-colormath/issues/56#issuecomment-126456655


add extraConfigPre option to prepend settings in PulseAudio module

Description of changes
The PulseAudio module first includes the default config that comes from compiled package and then applies user defined settings from extraConfig.
Unfortunately since the compiled package default config loads most modules, and arguments cannot be changed in a module once the module is loaded, there's not a whole lot you can do with settings that come after.
Hence this patch adds the extraConfigPre option to prepend settings so you can load modules with the arguments you wish before the default file does so.
For instance, you might want to use
    pulseaudio = {
      enable  = true;
      package = pkgs.pulseaudioFull;
      extraConfigPre = ''
        load-module module-card-restore restore_bluetooth_profile=true
      '';
    };

restore_bluetooth_profile means if you had set your bluetooth headset in "phone" mode (low quality, low delay, microphone on), pulseaudio won't set it back to A2DP (high quality, high delay, no microphone) every time you switch it off and on.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Fixes https://discourse.nixos.org/t/automatic-profile-switching-of-bluetooth-headset/5384

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/automatic-profile-switching-of-bluetooth-headset/5384/3

cc @lovek323

cc @lgoette @adisbladis @worldofpeace

cc @Yarny0 @Luflosi @wegank @lucasew @pennae

Why not make the config content an option then use mkBefore and mkAfter to put stuff in the beginning or the end of file?


Skip and Continue buttons not working

Hi,
The skip and continue buttons are not working. Can you help me with this please?

You have to add actions to them. You can tweak them by implementing swiftyOnboardViewForOverlay. Here is an example
@objc private func onContinue() {
    guard let swiftyOnboard = swiftyOnboard else { return }
    swiftyOnboard.goToPage(index: swiftyOnboard.currentPage + 1, animated: true)
}

@objc private func onSkip() {
    // TODO: Add implementation
}

func swiftyOnboardViewForOverlay(_ swiftyOnboard: SwiftyOnboard) -> SwiftyOnboardOverlay? {
    let overlay = SwiftyOnboardOverlay()
    overlay.continueButton.setTitle("continue", for: .normal)
    overlay.continueButton.addTarget(self,action: #selector(onContinue), for: .touchUpInside)
    overlay.skipButton.setTitle("skip", for: .normal)
    overlay.skipButton.addTarget(self, action: #selector(onContinue), for: .touchUpInside)
    return overlay
}

You can also change the functions later with swiftyOnboardOverlayForPosition
func swiftyOnboardOverlayForPosition(_ swiftyOnboard: SwiftyOnboard, overlay: SwiftyOnboardOverlay, for position: Double) {
    overlay.continueButton.removeTarget(self, action: #selector(onDone), for: .touchUpInside)
    overlay.continueButton.removeTarget(self, action: #selector(onContinue), for: .touchUpInside)
    if position == 2 {
        overlay.continueButton.setTitle("done", for: .normal)
        overlay.continueButton.addTarget(self, action: #selector(onDone), for: .touchUpInside)
        return
    }
    overlay.continueButton.setTitle("continue", for: .normal)
    overlay.continueButton.addTarget(self, action: #selector(onContinue), for: .touchUpInside)
}


Fix a few typos in the QL grammar

Typos:

atlowerId -> atLowerId
:: = -> ::=

There is also a trailing ; in the start symbol definition (ql). I don't know what it is supposed to mean. Should it be removed?

Thanks @aibaars. Over to @p0 to review and merge this change.


Refactor Ci jobs

We could add something like https://github.com/akka/akka-guide/blob/54a81ce729ef07e1f9b97f0f15a4ff7d60e4d0ed/scripts/format-all.sh and even remove the separate Travis jobs.
WDYT?

Code, click to exapnd
#!/usr/bin/env bash

declare -r tutorial_root="docs-source/docs/modules/microservices-tutorial/examples"

find ${tutorial_root} -name .scalafmt.conf |
while read result
do
	pushd $(dirname $result)
	sbt scalafmtAll
	popd
done

find ${tutorial_root} -name pom.xml |
while read result
do
	pushd $(dirname $result)
	mvn spotless:apply
	popd
done

Originally posted by @ennru in https://github.com/playframework/play-samples/pull/116#discussion_r518005653

I think running the most stable samples in a single travis job could be benefinicial.
If memory serves, here's the usual suspect with more recent flakiness or failures:

play-xxx-grpc
play-xxx-websocket
play-scala-tls

At least.

I like the idea of running scalafmt / javafmt for all examples. We currently have that commented out: https://github.com/playframework/play-samples/blob/f2a88965af5a574edff65dc15b33b3fd954cd6f5/.github/workflows/build-test.yml#L15-L25
We could place a global scalafmt config in the root folder and have format script that copies that scalamt config into each project and then goes through the projects and runs validateCode. Very similiar to the test script (even combine those two).
Also maybe same approach is needed with the commons.sbt files which contains the validate commands.


ApolloFirmware support for i2c screen module [est. 12h]

Get values from the screen module or from DMX
Write values from art-net to i2c for correct display on screen

[ ] 2 I2C port support
[ ] Client implementation to answer "Test" as 4 chars
[ ] Micropython code to read the I2C device addr 0x38?
[ ] Client implementation to answer parameters as string python tuple
[ ] Client write values from python tuple
[ ] Apollo Screen Controller Apollo Package

https://randomnerdtutorials.com/esp32-i2c-communication-arduino-ide/
ide how to support multiple ports


Implement GetTempPath()

Fixes #124.

@rodrigc, PTAL

Codecov Report

Merging #135 into master will increase coverage by <.01%.
The diff coverage is 100%.


(maint) Update Ruby testing to currently supported versions

2.0.0 was end-of-lifed in February, so support latest patches of all
later versions.

@kylog got some issues to fix :)

@MikaelSmith this works great (I also tested the specs locally and everything is good) 👍

CLA signed by all contributors.


Can this thing do the .apk obfuscation and what abotu the scoore.

This is a .NET obfuscation tool, so .apk is out of scope.


mod_pagespeed directives in htaccess are ignored when requesting a php file

Hello,
First thank you for this amazing module,
I am facing an issue while adding directive to .htaccess related to mod page speed, they get completely ignored but only when requesting a php file, they work normally if the requested file is an html file.
the .htaccess only contains
<IfModule pagespeed_module>
  ModPagespeed off
</IfModule>

the module is always loaded for .php files and is turned off for .html file
Please advise.
Regards,

Looks like this was reported earlier via https://github.com/pagespeed/mod_pagespeed/issues/963
Closing this as a duplicate


Allow Wiki page editing

Sometimes the information on the pages is incomplete or could include more information to make it easier for people to use, case in point - The Using CI Builds Wiki Page

which could be improved to -

Installing CI Builds of the Visual F# IDE Tools
To install the Visual F# IDE Tools from Release.zip, first run sn.exe (Strong Name Tool) from
the developer command prompt
sn -Vr *,*

to turn of strong name checking on your machine, and then run
Release\net40\bin\EnableOpenSource.vsix

to run sn.exe from the standard command prompt you can locate it at
C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6 Tools\

But if you don't want to open access to allow wiki editing you can copy the md from this issue.

Yes ... I agree ...

Wiki is now editable.


beIN Entertainment EPG

Source
bein.com
Channels
Hello,
Requesting the addition of the beIN Entertainment channels. The sports channels are added but most of the entertainment channels are not. Most of these channels are English with only a few in Arabic (noted below).
Some channels are available through El Cinema but having the EPG from the official source can be more accurate, so I'm requesting the addition of these channels to bein.com
Sources
EN: https://www.bein.com/en/tv-guide/?c=sa
AR: https://www.bein.com/ar/جدول-البث/?c=sa
Channels Available on El Cinema
beIN Movies 1
beIN Movies 2
beIN Movies 3
beIN Movies 4
beIN Series 1
beIN Series 2
beIN Gourmet (AR and EN)
beIN Drama (AR)
Channels in Database with no Guide:
### UAE
Fatafeat (AR)
Cartoon Network Arabic (AR and EN)
Star Movies
Star World
### UK
BBC Earth Middle East
### Qatar
Jeem
Baraem
BeJunior
Channels NOT in Database and No Guide:
Food Network Middle East
FOX Middle East
Fox Movies Middle East
Fox Action Movies Middle East
Fox Life Middle East
HGTV
MTV 80s
MTV 90s
Club MTV
Bloomberg
National Geographic Middle East
National Geographic Wild Middle East
Discovery Channel Middle East
BBC Cbeebies
Baby TV
Cartoon Network Middle East
DreamWorks
Notes
Thanks!

Entertainment and Sports channels now available in English and Arabic
EN: https://iptv-org.github.io/epg/guides/en/bein.com.xml
AR: https://iptv-org.github.io/epg/guides/ar/bein.com.xml


[Bug]: namespace includes common variable names

What happened?
In _integrators.jl,
export state
export controls
export timestep
export comps
export dim

Version
stable release
What does this bug affect?

[ ] quantum system construction
[ ] problem setup
[ ] problem solution
[ ] problem performance
[ ] solution analysis
[ ] plotting
[ ] documentation
[ ] tests
[ ] other (please specify below)

Other information
No response

these should all be prefixed with get_ probably

closed by #149


Support base_path less content

Some link types are base_path less e.g. contact, government and world_location. Presenting null api_path, web_url and api_url for these formats makes them invalid with the frontend schemas.
This commit removes those fields when their value is null.

I think we still end up with invalid schemas despite these changes. Since base_path is a required field
And with additional properties being false I guess any types that have additional fields end up being invalid.
Sorry...

😢 @kevindew I've made base_path optional now for this link type, well, I will do if I can ever find the magic combination to allow me to get CI to pass. https://github.com/alphagov/govuk-content-schemas/pull/629 Does that work?

@gpeng yup that looks good. What do you think about also making additionalProperties to true for both sets of link types?

Sure... I'll sort that out. Thanks for your help :+1:


When is this project transferred to github?

So I can star on it:)

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 17 Mar 2015 at 2:15

ah, now.


How to get full html via ajax.

I'm using AngleSharp with WebClient get html page. But result response only html static without content return via ajax jquery.
How to using AngleSharp complete this task.
Thanks !

AngleSharp itself only delivers an HTML and CSS parser. What you want is JavaScript evaluation. It could be that AngleSharp.Scripting.JavaScript is already good enough for you, however, some things are not implemented and not all scripts will work at the moment. I would just give it a try.

Thanks FlorianRappl !
I know and I'm using AngleSharp.Scripting.JavaScript in my project. But I don't know step by step get content return ajax.
You can provide a sample step by step about using AngleSharp.Scripting.JavaScript get content return ajax ?
Thanks so much.

What exactly is the scenario you try to cover? You need to be as explicit as possible. Also: Did you look already at the samples? Maybe the answer is already there.


C18342: Missing asterisk on target version

Hello, @rpetrusha,
Localization team has reported source content issue that causes issue for localization. We need to escape the asterisk to avoid loc problems.
Please review the comment tag added and reply with explanation if fix is needed or not. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)

Hello, @mairaw,
I've just commited the changes requested. Could you check if everything is okay and help yo merge?
Thank you.

Sorry, @mairaw. I didn't notice that you'd already reviewed the PR. In any case, @carolinacmoravia addressed the formatting issue.


Update Tekton and Kubernetes dependencies

Changes
Fixes #910
This was more invasive than expected. Basically there were signature changes in the Kubernetes interfaces that I had to adopt to.
The minimum Kubernetes version comes from Tekton 0.30. Was a little surprised that it does not support 1.19 anymore.
Submitter Checklist

[x] Includes tests if functionality changed/was added
[x] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

Release Notes
action required: We updated our used Tekton and Kubernetes dependencies. The minimum Kubernetes version now is v1.20

/approve

I saw all the doc updates I was expecting, and the k8s related signature updates are in line with what I recall from similar k8s bumps in other projects I work on.
That said, given the breadth of this change, let's get multiple eyes reviewing this one.  I'll defer to @adambkaplan for taking a pass at this and being in charge of applying the lgtm if he is also good with it.

/assign @adambkaplan
/assign @gabemontero

The minimum Kubernetes version comes from Tekton 0.30. Was a little surprised that it does not support 1.19 anymore.

Is this true? The current installation doc claims the min supported version is 1.19. See https://github.com/tektoncd/pipeline/blob/main/docs/install.md#before-you-begin.

The minimum Kubernetes version comes from Tekton 0.30. Was a little surprised that it does not support 1.19 anymore.

Is this true? The current installation doc claims the min supported version is 1.19. See https://github.com/tektoncd/pipeline/blob/main/docs/install.md#before-you-begin.

For reference here, as discussed in slack: caused by https://github.com/tektoncd/pipeline/pull/4354#pullrequestreview-810972518


Unknown trigger hits parent instead of child (that has unknown trigger)

Scenario

Bot with child dialog.
Prompt at child for user text input
Enter utterance that should be detected as unknown
Handle with recognizer (Orchestrator in my case)

Results
Expected: Child dialog unknown trigger handles utterance
Actual: parent dialog unknown trigger handles utterance.
Version
Version:  1.4.0-nightly.235171.cfc0c11
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0

Visuals
Expecting child unknown trigger to fire

--
Actual: parent trigger fires. Note also, 3 calls to recognizer

Update:

With LUIS recognizer at child the behavior is as expected.
WIth Orchestrator at child, LUIS in parent the unexpected behavior reproduces.

This sounds like an orchestrator issue. Please work with that team if there is a bug to address.


Updated API listCollectionNames and listIndexes so now match respective ...

...commands
JAVA-1589

Initial review complete.

Todos

[ ] Make listCollections fluid - so can set the batchSize from the client api and to help be future compatible.
[ ] Make listIndexes fluid - so can set the batchSize from the client api and to help be future compatible.
[ ] Test batchSize in listCollections - can we do an initial batchSize (0) and then change it?
[ ] Test batchSize in listIndexes - can we do an initial batchSize (0) and then change it?
[ ] Add Tests for listCollections* - to ensure its covered in async

Have pushed an update - was more in depth than I initially thought but we now support batchSize and maxTimeMS.
We currently force the listCollection & listIndex methods to read from primary but the spec says:

Drivers MUST run listCollections on the primary node in "replicaset" mode, unless directly connected to a secondary node in "standalone" mode.

I'm not sure how best to achieve that, the operation however just uses the passed in readPreference - so I'm hoping thats acceptable.

Inprogress

I did a some what painful rebase onto 3.0.x and actioned all points in aea41f4
I updated FindFluentSpecification as thats where I based the fluent specs from and also added unit tests to check results for the various interfaces to ensure they handle the canned data as expected.  The Operation Specs themselves will handle any logic in execute based on server version and the acceptance tests / smoketest also test the functionality.

Ready for review again @jyemin :)

lgtm

Rebased and merged


Error in installation of .yml file

Hi, thank you for the great work!
After trying a few hours to solve the installation problems, I still face errors while running the conda environment from VIP_conda_R.yml.
Solving environment: failed
ResolvePackageNotFound:
....
I then put the required functions under --pip, and the package conflict of several package showed up.
Would anyone face the same issues and how to deal with this error?  Many thanks to your reply!

Sorry for the delayed reply!
conda solver could be very slow. Please try the following by using mamba:
conda install -c conda-forge mamba
conda create -n <your envname>
mamba env update -n <your envname> -f VIP_conda_R.yml
conda activate <your envname>

This should be much faster.
Please let me know. Thanks!

Please checkout new one step installation: install_VIPlight.sh (linux) install_VIPlight.macOS.sh (mac OS).


Unity Intellisense problem may be caused by C# extension error

Environment data
 Version:   3.1.301
 Commit:    7feb845744

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.14
 OS Platform: Darwin
 RID:         osx.10.14-x64
 Base Path:   /usr/local/share/dotnet/sdk/3.1.301/

Host (useful for support):
  Version: 3.1.5
  Commit:  65cd789777

.NET Core SDKs installed:
  3.1.201 [/usr/local/share/dotnet/sdk]
  3.1.301 [/usr/local/share/dotnet/sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.App 3.1.3 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.1.5 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 3.1.3 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.5 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

VS Code version:
1.49.0
C# Extension version:
1.23.2
OmniSharp log
    Target: /Users/Flickso/mirrormirroronthewall/mirrormirroronthewall.sln

OmniSharp server started.
    Path: /Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/run
    PID: 19986

[info]: OmniSharp.Stdio.Host
        Starting OmniSharp on MacOS 10.14.5 (x64)
[info]: OmniSharp.Services.DotNetCliService
        DotNetPath set to dotnet
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 1 MSBuild instance(s)
            1: StandAlone 16.8.0 - "/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        MSBUILD_EXE_PATH environment variable set to '/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/MSBuild.exe'
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: StandAlone 16.8.0 - "/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin"
            CscToolExe = csc.exe
            MSBuildToolsPath = /Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin
            CscToolPath = /Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Roslyn
            BypassFrameworkInstallChecks = true
            MSBuildExtensionsPath = /Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in '/Users/Flickso/mirrormirroronthewall'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Could not find any Cake files
[info]: OmniSharp.MSBuild.ProjectSystem
        Detecting projects in '/Users/Flickso/mirrormirroronthewall/mirrormirroronthewall.sln'.
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Telepathy.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Websocket.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Cloud.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Components.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Ninja.WebSockets.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Examples.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Runtime.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Examples.Cloud.GUI.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Assembly-CSharp.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Examples.Cloud.Pong.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Common.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Performance.Runtime.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Authenticators.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.example.RigidbodyPhysics.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Tests.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Weaver.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Editor.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Performance.Editor.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/WeaverTestExtraAssembly.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.CompilerSymbols.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Generated.csproj'
[info]: OmniSharp.Script.ScriptProjectSystem
        Detecting CSX files in '/Users/Flickso/mirrormirroronthewall'.
[info]: OmniSharp.Script.ScriptProjectSystem
        Could not find any CSX files
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.csproj
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.Completion.CompletionOptionsProvider, Order: 0
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.ImplementTypeWorkspaceOptionsProvider, Order: 110
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.BlockStructureWorkspaceOptionsProvider, Order: 140
[info]: OmniSharp.WorkspaceInitializer
        Configuration finished.
[info]: OmniSharp.Stdio.Host
        Omnisharp server running using Stdio at location '/Users/Flickso/mirrormirroronthewall' on host 19907.
[info]: OmniSharp.OmniSharpWorkspace
        Miscellaneous file: /Users/Flickso/mirrormirroronthewall/Assets/agoodtest/Scripts/hgfdsahg.cs added to workspace
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Telepathy.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Telepathy.csproj'.
/Users/Flickso/mirrormirroronthewall/Telepathy.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Websocket.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Websocket.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Websocket.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Cloud.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Cloud.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Cloud.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Components.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Components.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Components.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Ninja.WebSockets.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Ninja.WebSockets.csproj'.
/Users/Flickso/mirrormirroronthewall/Ninja.WebSockets.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Examples.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Examples.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Examples.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Tests.Runtime.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Runtime.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Runtime.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Examples.Cloud.GUI.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Examples.Cloud.GUI.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Examples.Cloud.GUI.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Assembly-CSharp.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Assembly-CSharp.csproj'.
/Users/Flickso/mirrormirroronthewall/Assembly-CSharp.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Examples.Cloud.Pong.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Examples.Cloud.Pong.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Examples.Cloud.Pong.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Tests.Common.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Common.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Common.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Tests.Performance.Runtime.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Performance.Runtime.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Performance.Runtime.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Authenticators.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Authenticators.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Authenticators.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.example.RigidbodyPhysics.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.example.RigidbodyPhysics.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.example.RigidbodyPhysics.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Tests.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Tests.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Tests.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Weaver.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Weaver.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Weaver.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Editor.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Editor.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Editor.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Tests.Performance.Editor.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Performance.Editor.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Performance.Editor.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/WeaverTestExtraAssembly.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/WeaverTestExtraAssembly.csproj'.
/Users/Flickso/mirrormirroronthewall/WeaverTestExtraAssembly.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.CompilerSymbols.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.CompilerSymbols.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.CompilerSymbols.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/Flickso/mirrormirroronthewall/Mirror.Tests.Generated.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Generated.csproj'.
/Users/Flickso/mirrormirroronthewall/Mirror.Tests.Generated.csproj
/Users/Flickso/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1178,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Telepathy.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Websocket.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Cloud.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Components.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Ninja.WebSockets.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Examples.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Tests.Runtime.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Examples.Cloud.GUI.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Assembly-CSharp.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Examples.Cloud.Pong.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Tests.Common.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Tests.Performance.Runtime.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Authenticators.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.example.RigidbodyPhysics.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Tests.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Weaver.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Editor.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Tests.Performance.Editor.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/WeaverTestExtraAssembly.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.CompilerSymbols.csproj
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/Flickso/mirrormirroronthewall/Mirror.Tests.Generated.csproj

Steps to reproduce
Load up VS code with C# extension
Expected  behavior
Unity intellisense would work
Actual behavior
C# extension doesn't work and (what I presume happens) is it messes up the unity intellisense

    The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

@Daytae Sorry you are running into issues. Unity relies on some .NET Full Framework reference assemblies that are not part of OmniSharp's minimal MSBuild. You will need into install the latest stable Mono for your platform. https://www.mono-project.com/download/stable/

@JoeRobich
This does not solve the problem.

@Daytae I should have mentioned that you will need to set "omnisharp.useGlobalMono" to "always".

@JoeRobich  where should I set this? getting similar issue

I went to preferences and disabled useGlobalMono, but it still isn't working, and my mono version is 6.10

you need to set use global Mono to always, not disable it

@Daytae I should have mentioned that you will need to set "omnisharp.useGlobalMono" to "always".

@JoeRobich I can't stress enough, you should really put this in the README - you already have a section https://github.com/OmniSharp/omnisharp-vscode#note-about-using-net-core-31401-or-net-5-preview-8-sdks-on-mono-platforms but I don't think it will be clear to most developers until they really dig, what even the problem is.
My understanding after a lot of frustration is that OmniSharp pulls its own version of dotnet in along with the extension, but that at least in my case on Mac OSX where I have installed Mono and .NET Core, in order to be able to use with Unity, I need to make sure it is using my system version of Mono and not the one omnisharp is bundling? I have to imagine there are a lot of Unity devs on Mac OSX who just got frustrated and walked away from not having auto-complete, because the error messages that show up from Omnisharp are helpful only for windows folks. For example, this call to install the Developer Pack which is available only as an .exe from MS site (https://docs.microsoft.com/en-us/dotnet/framework/install/guide-for-developers) - it is a dead-end for Mac users.
In my case, setting this global config did solve the problem and get me back to auto-complete functioning. Thank you!

Solved the problem for me as well!
For those wondering where the setting omnisharp.useGlobalMono should be set: go to VSCode, click on Preferences > Settings, and then use the search bar to search for omnisharp.useGlobalMono. Then you should see the dropdown and set it to always. 😀

Recommend using the Unity extensions for VS Code.


Automated cherry pick of #1962: add copyright api climc

Cherry pick of #1962 on release/2.11.
#1962: add copyright api climc

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@ca7c434). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.11   #1963   +/-   ##
==============================================
  Coverage                ?   7.51%
==============================================
  Files                   ?     418
  Lines                   ?   64867
  Branches                ?       0
==============================================
  Hits                    ?    4876
  Misses                  ?   59580
  Partials                ?     411

Flag
Coverage Δ

#aFlag
7.51% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca7c434...4e145b5. Read the comment docs.

/lgtm
/approve


Implement string representation (__repr__) in sparse matrix classes

CuPy:
>>> cupyx.scipy.sparse.coo_matrix((10,10))
<cupyx.scipy.sparse._coo.coo_matrix object at 0x7fa5716da280>

SciPy:
>>> scipy.sparse.coo_matrix((10,10))
<10x10 sparse matrix of type '<class 'numpy.float64'>'
        with 0 stored elements in COOrdinate format>

I want to take the issue. Are we trying to make the repr exactly like that of scipy?

Hey @kmaehashi, If this issue is still open,I can take this up.


[UPDATE] 0.43.2

Hey, Thank you for this! I had been away for a short bit. It's very much appreciated.
Feel free to drop an LBC address and I'll get some your way for this PR.


Create the template for orders

This template shows the customer their previous orders.
This means the template must be able to take several orders and show complete info about each of them.
The template must look like "Main Menu" in the main template index.
orders list view (views.index) will give you this context: { "orders": <CURRENT_SESSION_ORDERs>}

completed in #99


keep a local .pylintrc file

This makes it easier to use tools like vscode that rely on the local .pylintrc file. Otherwise one would see a lot of warnings the first time opening the file, as we use non-standard (google) python idioms.

@fabianp @vroulet If .pylintrc is meant to stay, why does test.sh delete it? This "tug-of-war" seems to be causing issues when running tests: https://github.com/google-deepmind/optax/issues/1067.
IMO: Running tests should be free of side effects; we don't want running tests to yield different results depending on whether they were run previously.

Absolutely, that's a bug. We should not be deleting the .pylintrc file. Could you send a PR fixing that? Thanks 🙏!

@fabianp Should test.sh also be amended to not modify .pylintrc, as it currently does on line 64?


Updated packages and formatted. Also fixed 3 warnings.

I updated all packages to latest versions (so that they do not make SUPER compile some of them twice) and fixed 3 warnings. I also updated the format with a cargo fmt.

Coverage decreased (-0.9%) to 80.396% when pulling bdc31a85d3c992e0e23174a85ff0dc460c2dd9d7 on Razican:update into 17abb6eb5671ed88b629f3a08a61482b4401bd17 on gnieto:develop.

Coverage decreased (-0.9%) to 80.396% when pulling ec152c280da06a9697d0b322338260965bc42b5f on Razican:update into 17abb6eb5671ed88b629f3a08a61482b4401bd17 on gnieto:develop.

Thanks!


sort timeline UI by time

Summary
Currently timeline is sorted alphabetically, any interesting in sort based on first appear?

Sounds reasonable to me.  Sorting alphabetically was just easier, so that's what I did.


remove startup script and alias creation to auto_install.sh in vocalf…

…usion_3510_avs_setup

This PR is obsolete and the changes are not required anymore.


Fix usage of bash arrays

After the recent changes to the way bash arrays are used, if you have a rule like
bazeldnf(
  name = "ldd_test",
  command = "ldd",
  ...
)

then calling
$ bazel run //:ldd_test

will result in
Error: unknown command "\"ldd" for "bazeldnf"

This is caused by the excessive number of (nested, escaped) quotes that are present in the expression. The new version follows the recommendations from https://stackoverflow.com/questions/7577052/ accurately and as such doesn't exhibit the problem.

Well obviously CI won't pass until #20 has been merged O:-)

Let's see if this needs a rebase. #20 is now merged.

@andreabolognani yep we need a rebase to make the check pass ...


Cli: Implement sweep address call

This can be used to salvage funds from funding addresses in case something goes wrong.

Codecov Report

Merging #517 (90f5ca0) into main (42ee892) will increase coverage by 0.5%.
The diff coverage is 2.0%.

@@           Coverage Diff           @@
##            main    #517     +/-   ##
=======================================
+ Coverage   11.8%   12.3%   +0.5%
=======================================
  Files         34      34
  Lines       9896   10129    +233
=======================================
+ Hits        1163    1241     +78
- Misses      8733    8888    +155

Impacted Files
Coverage Δ

src/cli/command.rs
22.4% <0.0%> (-2.6%)
:arrow_down:

src/databased/runtime.rs
40.7% <0.0%> (+7.2%)
:arrow_up:

src/farcasterd/runtime.rs
0.0% <0.0%> (ø)

src/walletd/runtime.rs
0.0% <0.0%> (ø)

src/rpc/request.rs
18.1% <12.5%> (+2.2%)
:arrow_up:

src/cli/opts.rs
43.7% <33.3%> (-0.6%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ee892...90f5ca0. Read the comment docs.


rsaz_exp_x2.c: Avoid potential undefined behavior with strict aliasing

Fixes #19584

The code looks rather complicated, did you compare the generated assembler code with and without this patch?
Does it look the same as before, or does this cause a performance degradation?

I do not think any small performance degradation in these from_words52/to_words52 is relevant. It would surely depend on how much optimizing the compiler is. These functions are called only as the first and last step of the algorithm so they should not have big impact on the overall performance of the mod_exp computation.

Did you know there is also a may_alias attribute, why no using it instead ?

Did you know there is also a may_alias attribute, why no using it instead ?

It's not portable.

Okay, when I wrote #19394 I had no way whatsoever to test anything,
only a 1:1000 chance that the CI picks up an affected CPU arch.
Are you able to effectively test this, and maybe get performance numbers
with/without this patch?

I have no readily available computer that I could test the performance impact on. As for correctness of the code, I'd suggest merging it to master branch and wait a few days to see if there is any CI regression detected due to this. The probability to get a CI build on machine capable of AVX512_IFMA is much higher than 1:1000, so within a few days we would see if there is any regression or not.

We've found Intel SDE to be extremely useful for this thing. (To the point that we even run it in CI.) I'd suggest getting that out and running through the usual suite of sanitizers, etc.

You probably remember this?

Yes, on the other hand there were CI failures after that change which we ignored as at that time we did not recognize the connection to the change. That's why I am saying we should merge this only to master and wait to see if there are any CI failures.

Of course if anyone has AVX512_IFMA capable machine and/or the Intel SDE installation readily available, it would be welcome to test this right away.

@t8m this does not seem like an acceptable strategy. Putting a hold on this so it is discussed within OTC. i.e. This needs to have a CI solution.

While I get the point, with that rationale, you want to revert the original and disable the code entirely for the timebeing if you feel it can't be adequately tested.

I don't have a problem with your PR,
but I do think it would be quite embarrassing if OpenSSL shipped another release that crashed with a similar issue.
If there is some way to address this via CI is should be added.

I'm giving SDE a go in CI, but no promises yet. It's not the fastest so we'll see how it goes.

I'm giving SDE a go in CI, but no promises yet (I'm also new to the tool). It's not the fastest so we'll see how it goes.

Thanks for having a look...

Not sure if this is helpful
https://ci.chromium.org/ui/p/boringssl/builders/ci/linux32_sde/b8798585425292411169/steps

On a phone so I can't look it up easily, but we just use the flags that tell it to simulate a particular CPU model and run through a bunch of them. (Though we haven't yet taken any AVX512 code so I'm not sure if we currently run with one of those.)
If setting it up in CI is tricky, probably at least manually test the PR with it to confirm it works.

Of course if anyone has AVX512_IFMA capable machine and/or the Intel SDE installation readily available, it would be welcome to test this right away.

It is trivial to set up an AWS machine that meets the requirement. That is what I did last time we had to check something. This is something the team should be able to do.

It is trivial to set up an AWS machine that meets the requirement. That is what I did last time we had to check something. This is something the team should be able to do.

Would it be possible to add as a buildbot runner?

That'd be great. So far, my efforts with GH aren't going well, as the job keeps expiring (they have a limit when using their runners) 😢

Well, all the trouble to get a test setup for this fragile piece of code (and we would need at least a test for each
of the following Compilers to be sure: GCC, CLANG, and MSVC) this looks to me like the maintenance cost
of this code is not worth the benefit for an optimization that runs only on on very very few devices out there.
So, I'd say I am
+1 for removing the AVX512_IFMA optimization altogether.

@thesamesam We didnt get time to cover this one in this weeks OTC meeting, It will hopefully be looked at next week.

OTC: We would like at least one-off test run on AVX512_IFMA capable machine to confirm this is OK. Otherwise this is subject to the normal review process.

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

I've run tests that cover the RSAZ exponentiation on a build from this PR with Intel SDE. (Run under SDE reproduced the issue with 3.0.4 release.)
Unfortunately the run of tests under Intel SDE is too slow to be executed in regular CI.
Ping for second review.

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests.  Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

Merged to master, 3.1, and 3.0 branches. Thank you for the reviews.


ci: add commitlint fallback job

Each PR gets tested by the commitlint app (which is deprecated). On
occasion the app does not pickup the change in a PR, and the only way to
start a retest is to re-push the PR. All tests will then get executed
again, even if only commitlint was needed.
The new commitlint CI job introduces '/retest commitlint' and runs in
the CentOS CI like other Jenkins jobs. However, the job does not start
automatically on each (updated) PR, but needs manual starting with the
'/test commitlint' or '/retest commitlint' comments. The normal way of
running commitlint is with the app (at least for now).

Thanks


OSF-5239 Two Factor Auth bug

Purpose
Two factor authentication code still exists after disabling and enabling. Fixed
Changes
In "twoFactorUserConfig.js", added a line so that it resets the field after disabling.
Side effects
None. At least not that I may think of.
Ticket
OSF-5239
https://openscience.atlassian.net/browse/OSF-5239

Quick fix. I'd like to see a test but our js tests are weak. I guess we'll let QA handle it.

Okay, okay. I felt guilty about not functional-testing this one. However, I don't have a smart phone, so I can't use Google Authenticator or Authy or whatever ... sooooo I hacked a fun little script to solve for acceptable 2fa verification codes, given the secret key:
#!/usr/bin/env python2
from __future__ import absolute_import, division, print_function, unicode_literals

import sys
from base64 import b32decode
from binascii import hexlify

from oath import accept_totp

class GloriousHack(object):
    def __str__(self):
        class BelieveIt(str):
            def __eq__(self, other):
                print(other)
        return BelieveIt()

accept_totp(hexlify(b32decode(sys.argv[1])), GloriousHack())

Per discussion in Flowdock, this script works for both initial configuration and subsequent login attempts (just be sure to hang on to the secret key!).
osf.io| $ python ~/Desktop/solve-totp.py SZS46AHELO5PV6IT
802608
819414
585652
osf.io| $

Alright, fix confirmed. :-)

👍


Change authentication method

The current method of inputting passwords for private notepads is not secure, as the password is passed directly in the query of the link. Add an unlock button which will prompt the user to input the correct password before allowing access to the notepad.

This issue was fixed in commit e7b6fa0 - "Refactor password authentication"


Add dataclassess package

This recipe was copied over from https://github.com/conda-forge/dataclasses-feedstock.
Closes #665.

Thank you, @danielballan!


Fix NPE while cloudstack agent failed to connect to mgt server

Description
If ramOvercommitRatio field is missing in user_vm_details table
is missing then agent throws NPE after restarting
It is because in user_vm_details, there are 'cpuOvercommitRatio' for all
vms, but for vms the field 'ramOvercommitRatio' is missing in the table.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[X] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[X] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

 SL-JID 98

[S] Trillian test result (tid-104)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34123 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4779-t104-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_migrate_VM_and_root_volume
Error
67.22
test_vm_life_cycle.py

test_02_migrate_VM_with_two_data_disks
Error
50.11
test_vm_life_cycle.py


add contributor graph

Describe the bug/feature
I want to add contributor graph in readme
To Reproduce

Steps to reproduce the behavior:
1.Changes in readme file

Expected behavior
Contributors shown in readme file
Environment (please complete the following information):

OS: any
Browser:any

Additional Context
Please assign this issue to me

Go ahead!


MacOS 10.10.2 Fail at haste-boot. Failed to download haste-libs-0.5.0.tar.bz2

I installed haskell-platform, I followed the instruction using Cabal
And I got the following:
$ cabal update
$ cabal install haste-compiler
$ haste-boot

The following are the error message:
Downloading base libs from GitHub
Sending:
GET /haste-libs/haste-libs-0.5.0.tar.bz2 HTTP/1.1
Host: valderman.github.io

Creating new connection to valderman.github.io
Received:
HTTP/1.1 404 Not Found
Server: GitHub.com
Content-Type: text/html; charset=utf-8
ETag: "550a6965-247d"
Content-Security-Policy: default-src 'none'; style-src 'unsafe-inline'; img-src data:; connect-src: 'self'
Content-Length: 9341
Accept-Ranges: bytes
Date: Mon, 23 Mar 2015 18:52:07 GMT
Via: 1.1 varnish
Age: 97
Connection: keep-alive
X-Served-By: cache-dfw1830-DFW
X-Cache: HIT
X-Cache-Hits: 1
X-Timer: S1427136727.961983,VS0,VE0
Vary: Accept-Encoding

Failed to download http://valderman.github.io/haste-libs/haste-libs-0.5.0.tar.bz2: Not Found

Did you, by any chance, have had development version from GitHub previously installed? Try cleaning the installation first

Sorry for the late reply, I still have same problem. It seems like haste-libs-0.5.0.tar.bz2 not fount is persistent.

What does hastec --version (or hastec --version --unbooted if that complains about not being properly booted) and which haste-boot show? No version on Hackage should request haste-libs-0.5.0.tar.bz2, so somehow the dev version of Hastec must be lying around, getting in the way.

So, the version is 0.5.0 and
the which haste-boot is
/Users/DarwinSenior/Library/Haskell/bin/hastec

It all looks normal.

So it's the github version then?
If so, try haste-boot --force --local from the source directory (I can't try it myself because I'm having other problems but its the way to do it according to the readme).

I think I just came out on the other end of this problem. Some things to keep in mind that I more or less contributed to solving it for me:

here is a clean slate procedure if you've messed up your environment bad
sandboxes can interfere in unexpected ways causing weird conflicts, I made sure to clear out my sandboxes before running the clean slate solution. Sandboxes in plural because I used "advanced" sandbox features
If using the github version it's:

$ cabal install
$ haste-boot --force --local

and not
$ cabal install haste-compiler
$ haste-boot

as described in the readme.

Closing this, since it is specific to 0.4.x. If a similar issue appears for 0.5.x, please reopen.


Please add Notification.requestPermission()

https://developer.mozilla.org/zh-CN/docs/Web/API/notification/Using_Web_Notifications

We try not to put non-standardized things in lib.d.ts.
You can always include a .d.ts file yourself that includes definitions for these APIs.

Isn't the Notification API actually a standard? https://notifications.spec.whatwg.org/

This was closed over 13 months ago, when Notification was from standard.
This can be addressed by contributing to the TS-Lib-Generator.

Thank you @kitsonk I had a look to the TS-Lib-Generator to contribute but I couldn't guess the correct approach to add the Notification type in the addedTypes.json file (as the contribution guidelines state), since the interface has static/readonly properties not covered by the build script.

I am a little bit surprised that it hasn't come over yet, though I haven't looked at master.  It is in Edge 14, so the IDLs for Edge should reflect that, which should generate it without overrides... I don't know enough, about the specifics, but do new APIs automagically appear when added to Edge's IDLs and what version of the IDLs are used when building (is it only released)?

Ah, I see, the browser IDLs are currently 4 months old... which means it is likely they are "Edge 13" ones. @zhengbli how often/when do you update them?

We used to take the Edge spec files along with official windows 10 releases, therefore the last update was the same as TH2. However, it makes more sense to do a more frequent update to avoid wasted efforts from the community, we are taking to the Edge team trying to make a monthly update happen. Also, NotificationOptions is indeed available in the latest Edge build. It should be covered next update, which should be soon.

@zhengbli Is there any update on this issue?

By the way, I have made an updated defintion for Notification:
type NotificationPermission = "default" | "denied"| "granted";

type NotificationDirection = "auto" | "ltr" | "rtl";

interface NotificationPermissionCallback {
	(permission: NotificationPermission): void;
}

interface NotificationOptions {
	dir?: NotificationDirection;
	lang?: string;
	body?: string;
	tag?: string;
	image?: string;
	icon?: string;
	badge?: string;
	sound?: string;
	vibrate?: number | number[],
	timestamp?: number,
	renotify?: boolean;
	silent?: boolean;
	requireInteraction?: boolean;
	data?: any;
	actions?: NotificationAction[]
}

interface NotificationAction {
	action: string;
	title: string;
	icon?: string;
}

declare class Notification extends EventTarget {
	constructor(title: string, options?: NotificationOptions);

	static readonly permission: NotificationPermission;
	static requestPermission(): Promise<NotificationPermission>;
	static requestPermission(deprecatedCallback: NotificationPermission): void;

	static readonly maxActions: number;

	onclick: EventListenerOrEventListenerObject;
	onerror: EventListenerOrEventListenerObject;

	readonly title: string;
	readonly dir: NotificationDirection;
	readonly lang: string;
	readonly body: string;
	readonly tag: string;
	readonly image: string;
	readonly icon: string;
	readonly badge: string;
	readonly sound: string;
	readonly vibrate: number[];
	readonly timestamp: number;
	readonly renotify: boolean;
	readonly silent: boolean;
	readonly requireInteraction: boolean;
	readonly data: any;
	readonly actions: NotificationAction[]
}

Great work! I improved it a bit: the 'close' method on the Notification class was missing, and the definition for the deprecated requestPermission method wasn't entirely correct.
type NotificationPermission = "default" | "denied" | "granted";

type NotificationDirection = "auto" | "ltr" | "rtl";

interface NotificationPermissionCallback {
	(permission: NotificationPermission): void;
}

interface NotificationOptions {
	dir?: NotificationDirection;
	lang?: string;
	body?: string;
	tag?: string;
	image?: string;
	icon?: string;
	badge?: string;
	sound?: string;
	vibrate?: number | number[],
	timestamp?: number,
	renotify?: boolean;
	silent?: boolean;
	requireInteraction?: boolean;
	data?: any;
	actions?: NotificationAction[]
}

interface NotificationAction {
	action: string;
	title: string;
	icon?: string;
}

declare class Notification extends EventTarget {
	constructor(title: string, options?: NotificationOptions);

	static readonly permission: NotificationPermission;
	static requestPermission(): Promise<NotificationPermission>;
	static requestPermission(deprecatedCallback: (permission: NotificationPermission) => void): void;

	static readonly maxActions: number;

	onclick: EventListenerOrEventListenerObject;
	onerror: EventListenerOrEventListenerObject;

	close(): void;

	readonly title: string;
	readonly dir: NotificationDirection;
	readonly lang: string;
	readonly body: string;
	readonly tag: string;
	readonly image: string;
	readonly icon: string;
	readonly badge: string;
	readonly sound: string;
	readonly vibrate: number[];
	readonly timestamp: number;
	readonly renotify: boolean;
	readonly silent: boolean;
	readonly requireInteraction: boolean;
	readonly data: any;
	readonly actions: NotificationAction[]
}

@marcovdb I made a notification.d.ts out of your code but it shows me error in this section:
readonly title: string;     readonly lang: string;     readonly body: string;     readonly tag: string;     readonly icon: string;     readonly timestamp: number;     readonly silent: boolean;     readonly requireInteraction: boolean;     readonly data: any;

I'm getting this error for all above properties.
All declarations of 'propertyName' must have identical identifiers

Can you please help me with this issue?

Should be added in the next release. See https://github.com/Microsoft/TSJS-lib-generator/blob/cd60588b72a9188e89346b3c440a76508b4c0e76/baselines/dom.generated.d.ts#L8360-L8381

How do you watch for a action click?

@mwent-cray StackOverflow is the place for questions.

@marcovdb is Notification definitions still in TS 2.4? Because I can't seem to find it there :-|
https://github.com/Microsoft/TypeScript/blob/master/src/lib/dom.generated.d.ts

Yes. It's in a different file.
https://github.com/Microsoft/TypeScript/blob/master/src/lib/webworker.generated.d.ts

@marcovdb is there a reason why the interface is different from code mentioned in your last post in thread?

Sorry, no idea. You'd have to ask the person that actually contributed the definitions. That would be @zhengbli.

@zhengbli why were all but 5 of the NotificationOptions omitted? 😞

@ialexryan please file a new issue and give us some context about the issue, and i would be happy to look into it.


Update README.md

Added some open source implementations of the HackerNews API

Thanks for the PR! And sorry to disappoint, but I don't think we're able to merge it. I fear that linking to unofficial libraries here will be difficult to maintain, and we don't want to mislead users if they become inaccurate or out-of-date.


Clean output types and verbose arguments in epacems_to_parquet.py

The extract and transform functions no longer accept a verbose argument
A few of what were category types are actually integers
Parquet doesn't benefit from using specialized integer types (16-bit or unsigned)

They're apparently all treated as int32, int64, or int96 internally

This commit is giving me errors now. Please don't merge yet.

Apparently parquet has the same limitations as numpy and pre-0.24 pandas: integers can't be NaN, so integer-NaN columns have to be cast as floats. I've done this in d42e7b3.

Yeah, I think the NaN for int values is still experimental in 0.24. Hopefully in 0.25 it will be more fully integrated. Thank's for fixing these things! Maybe we can functionalize some of this and add a test case for the csv to parquet transformation.


csi-driver: add env param to disable node conformance checks

Problem:

In some of the OS distributions(Atomic/CoreOS), we cannot inject systemd files or install
packages as OS is immutable.

Implementation:

Add env param DISABLE_NODE_CONFORMANCE which user can specify to bypass package checks and installation

Testing: tested with env param set and verified no conformance/systemd file are copied.
Review: gcostea, rkumar
https://github.com/hpe-storage/csi-driver/issues/51
Signed-off-by: Shiva Krishna, Merla<EMAIL_ADDRESS>

lgtm. maybe just add it to the documentation wherever we claim support
Yes, will add this param to helm charts to allow disabling. But we can do that once we support CoreOS/Atomic. I have added env to allow users to try it out on CoreOS with YAML changes.


LauraTTS: no attribute of "text_encoder"

Description: Directly running demo.sh as guided in the Readme will throw an error as :
AttributeError: 'Namespace' object has no attribute 'text_encoder'

Thanks for your bug report. I take a mistake on the model name in the README.  I have fixed it in the last commit, please check it. The model name should be speech_synthesizer-laura-en-libritts-16k-codec_nq2-pytorch, the whole script should be like this:
cd egs/LibriTTS/text2speech_laura
model_name="speech_synthesizer-laura-en-libritts-16k-codec_nq2-pytorch"

# 1. free generation, the synthesized files are saved in results dir
bash demo.sh --stage 1 --model_name ${model_name} --output_dir results --text "nothing was to be done but to put about, and return in disappointment towards the north."

# 2. zero-shot generation given prompt text and audio, the synthesized files are saved in results dir
bash demo.sh --stage 2 --model_name ${model_name} --output_dir results --text "nothing was to be done but to put about, and return in disappointment towards the north." \
  --prompt_text "one of these is context" --prompt_audio "demo/8230_279154_000013_000003.wav"


[Story]: Fix inconsistent header in Global Model Serving view

Goal
Fix inconsistent header in Global Model Serving view
Dependency issue
No dependencies
Itemized goals

Right now, we have "Deployed models" as the header in the Model Serving Global view
The header should be all Upper Case
But we should have the same content in the nav link (which currently has Model Serving as the value)
We need to fix the inconsistency and find the right title

Aspects continued elsewhere
No response
Mocks

https://www.sketch.com/s/113593f8-5970-49d6-a352-709b07639127/a/j4MLjez

@vconzola We still have this opened, it would be great to unblock it in the future


Limit selectable range with [max] and [min]

Is there any way to use [max] and [min] like in mat-datepicker? https://github.com/angular/material2/blob/master/src/material-examples/datepicker-min-max/datepicker-min-max-example.html

Yes, it's fully support original angular material datepicker API https://material.angular.io/components/datepicker/api

Thanks

Yes, it's fully support original angular material datepicker API https://material.angular.io/components/datepicker/api

This can be used with Range date inline?


remove deprecated CompositeSchemaResolver - make it internal

Notes:
Deprecated CompositeSchemaResolver is now removed. Please replace all usages of CompositeSchemaResolver.of(...) with SchemaResolver.compose(...).