There was an error when Run Test Method with pytest.

Environment data

Steps to reproduce:

Launch VSC and create python file named pytest_test.py
a. Clear the part of workspace configuration in setting.json
Enter below code
def test_passing():
assert 42 == 42
def test_failure():
assert 42 == -13
Run command: "Run All Tests"
a. triggers the prompt to configure the test runner, select pytest
i. pytest gets installed
b. Tests are discovered (as shown by code lenses on each test)
Click the part of test results in status bar that brings command list
Run Unit Test Method

Expected behaviour
Brings up new list which includes all tests.
Actual behaviour
There was an error when Run Test Method.

@linette-zyy Was there any error stack for this error in the output logs or console logs?

Python Test Log
python c:\Users\vting\.vscode-insiders\extensions\ms-python.python-2021.6.864643163-dev\pythonFiles\testing_tools\run_adapter.py discover pytest -- --rootdir c:\Users\vting\Downloads\folder4 -s --cache-clear .
============================= test session starts =============================
platform win32 -- Python 3.8.8, pytest-6.2.3, py-1.10.0, pluggy-0.13.1
rootdir: c:\Users\vting\Downloads\folder4
plugins: anyio-2.2.0
collected 1 item

pytest_test.py F                                                         [100%]

================================== FAILURES ===================================
________________________________ test_failure _________________________________

    def test_failure():
>       assert 42 == -13
E       assert 42 == -13

pytest_test.py:4: AssertionError
============================== warnings summary ===============================
..\..\..\..\ProgramData\Anaconda3\lib\site-packages\pyreadline\py3k_compat.py:8
  C:\ProgramData\Anaconda3\lib\site-packages\pyreadline\py3k_compat.py:8: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
    return isinstance(x, collections.Callable)

-- Docs: https://docs.pytest.org/en/stable/warnings.html
- generated xml file: C:\Users\vting\AppData\Local\Temp\tmp-65726jigDcdpJnwY.xml -
=========================== short test summary info ===========================
FAILED pytest_test.py::test_failure - assert 42 == -13
======================== 1 failed, 1 warning in 0.11s =========================
Error: Error: unsupported status (Discovering)

Log [Extension Host]
[2021-05-25 03:11:21.411] [exthost] [error] Error: unsupported status (Discovering)
    at c.getMessagePrefix (c:\Users\vting\.vscode-insiders\extensions\ms-python.python-2021.6.864643163-dev\out\client\extension.js:59:572264)
    at a.getDiagnosticMessage (c:\Users\vting\.vscode-insiders\extensions\ms-python.python-2021.6.864643163-dev\out\client\extension.js:9:515018)
    at a.createDiagnostics (c:\Users\vting\.vscode-insiders\extensions\ms-python.python-2021.6.864643163-dev\out\client\extension.js:9:514608)
    at a.updateDiagnostics (c:\Users\vting\.vscode-insiders\extensions\ms-python.python-2021.6.864643163-dev\out\client\extension.js:9:513574)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async a.runTestImpl (c:\Users\vting\.vscode-insiders\extensions\ms-python.python-2021.6.864643163-dev\out\client\extension.js:59:653304) python.selectAndRunTestMethod


User setting - Default organization

for some of the functions to work an organization is required. Having a user customizable settings that provide the users default organization will meet this need.

added 2m of time spent

marked this issue as blocking #27

mentioned in commit abbd6a49d64fc24eb2c27191b594e8cefdb9042b

mentioned in commit 3481350bf21dca366bfb33a630e0d8494412d93d

mentioned in commit 2034a57b5ce7c1c7bdd9367ec88d0a9f8927706a

mentioned in commit 433c69adfbdc274910d83e5334e4b6cdf3cfd3db

mentioned in commit ee7977fe4a5e78844e8652c313af49eda901bdad

mentioned in commit 62c0bb77fe5134669e77b198acc02c28ea073696

mentioned in commit e66e9b8dca740ffe411b74c8f50c53c732acef2f

mentioned in commit 90f95672aa71c0a5358238f491949fb356503ff3

mentioned in commit 7f3bf95b4627be434732b1045120e59fcae21cf3

mentioned in commit 9f5e5d25ec574caa0aeec91c5763f7f64c8b11c2

mentioned in commit 96777f1beadb24328b3d90061220b6632b1bc575

mentioned in commit 4c002bc259062fc4926deda8a943d165496c8a25


Add ToggleFuelCells.netkan, closes #2022

KerbalStuff mods:

[ ] Compare the name of the mod, the mod author, and the folder it installs to, in order to make sure the identifier makes sense.
[ ] Ensure the KerbalStuff page has a homepage set. If it doesn't google to try and find a KSP forum page. If you can't find one add the KerbalStuff page as a homepage.
[ ] Ensure the KerbalStuff page has an abstract and it it doesn't, write one for it.
[ ] Ensure we have the correct license, and that it's identical across .netkan, mod .zip, KerbalStuff page, mod's homepage, any other resources related to the mod.
[ ] Is the $kref accurate? If you copy and pasted from the KerbalStuffBot PR, you should be set.
[ ] Check for a .version file that we can use for "$vref" : "#/ckan/ksp-avc".
[ ] Check the install stanza for: files correctly installed, extraneous files filtered out.
[ ] Using the KerbalStuff page, homepage, the mod's zip, and any other resources related to the mod to check for conflicts, depends, recommends, and suggests as appropriate.
[ ] After everything is written, look over the .netkan and verify your spec_version is appropriate.
[ ] Verify the file with netkan.exe
[ ] Verify the file with a CKAN install
[ ] Submit PR, check back on the PR later on for Jenkins feedback (pass/fail).


Add Icon before IP Address shown on Discover page

Note: This issue is reserved for SLoP Contributors.
The icon used here is from Feather Icons. You can either use dart package for feather icon or .svg itself.

Hi @sanket143
I would like to work on this issue.
Thanks.

@majeedyaseen Awesome

Is the issue resolved?

Is the issue resolved?

No please take it over @Sirsho29 my machine got some issues unfortunately :/
@sanket143 can reassign it to you.

@sanket143 can I take this, as it's only reserved for SLoP contributors?

@ritvij14 yes

@majeedyaseen If you face any issue, you can discuss on the #sinix-android channel on Discord or with us, we can help you.


Optional WorkflowTemplate parameter values

Summary
It would be nice to allow WorkflowTemplate parameters to have no defined values.
Use Cases
I'm using a fully parameterized WorflowTemplate and I would like to parameters with no value
and to fail if required parameters are not provided on submit.
apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
spec:
  entrypoint: regen-start
  arguments:
    parameters:
      - name: required-parameter
      - name: parameter-with-default-value
        value: default-value
...

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

To play back: rather than use the template's value when undefined, throw an error. This would mean we would have to allow templates with no default values.

rather than use the template's value when undefined, throw an error

Exactly.
I have edited the issue, you're right, it was unclear.


update instructions for installing into an existing VPC

Update for the changes in https://github.com/convox/rack/pull/1439.
Specify that an Internet Gateway ID must be passed.
Release Playbook

[ ] Rebase against master
[ ] Code review
[ ] Merge into master
[ ] Verify changes at http://site-staging.convox.com
[ ] Promote release on site-production in the convox/production Rack

 Better Document Installing into an Existing VPC


Problems with installing vendors

When I try to install vendors as per your instructions, few of the bundles are asking for account username and password.
[doctrine-fixtures]
git=http://github.com/doctrine/data-fixtures.git
[DoctrineFixturesBundle]
git=http://github.com/symfony/DoctrineFixturesBundle.git
target=/bundles/Symfony/Bundle/DoctrineFixturesBundle
[doctrine-migrations]
git=http://github.com/doctrine/migrations.git
[DoctrineMigrationsBundle]
git=http://github.com/symfony/DoctrineMigrationsBundle.git
target=/bundles/Symfony/Bundle/DoctrineMigrationsBundle

I'm having the same problem. I've tried updating the deps file to:
[DoctrineFixturesBundle]
    git=http://github.com/doctrine/DoctrineFixturesBundle.git
    target=bundles/Doctrine/Bundle/FixturesBundle

[DoctrineMigrationsBundle]
    git=http://github.com/doctrine/DoctrineMigrationsBundle.git
    target=bundles/Doctrine/Bundle/MigrationsBundle

And the appKernel.php file to:
new Doctrine\Bundle\FixturesBundle\DoctrineFixturesBundle(),
new Doctrine\Bundle\MigrationsBundle\DoctrineMigrationsBundle(),

I'm still getting this error when I run php bin/vendors install:
PHP Fatal error:  Class 'Doctrine\Bundle\FixturesBundle\DoctrineFixturesBundle' not found in /home/laptop/projects/symblog/app/AppKernel.php on line 17

Fatal error: Class 'Doctrine\Bundle\FixturesBundle\DoctrineFixturesBundle' not found in /home/laptop/projects/symblog/app/AppKernel.php on line 17
PHP Fatal error:  Class 'Doctrine\Bundle\FixturesBundle\DoctrineFixturesBundle' not found in /home/laptop/projects/symblog/app/AppKernel.php on line 17

Fatal error: Class 'Doctrine\Bundle\FixturesBundle\DoctrineFixturesBundle' not found in /home/laptop/projects/symblog/app/AppKernel.php on line 17

What am I missing to get this to work properly? Cheers.


Pack localized assemblies.

Second attempt at #1806.

Should fix #1810.
Printing warning instead of throwing if satellite dll is not found. Added integration test for this.
Better pattern for finding languages.
Checking that matches for the regex is a culture name.

Thank you for all the help @smoothdeveloper!

Why do we show warnings and when? I mean having no satellite assemblies is the 95% case

The warning is shown here, it happens when:

A language is found in the project file.
No matching ../culture/foo.resources.dll is found.
In the previous version I threw here but it was too harsh I think.
I can remove it of course but think it can be a good reminder to build before running paket pack.

there is still one related test failing on mono: https://travis-ci.org/fsprojects/Paket/builds/145555619

Checking it out, didn't see that one before, strange.

I assume there is something not commited

#1816 pack localized happy path fails on my machine with:
System.Exception : Paket failed with:
Could not find 'paket.dependencies'. To use Paket with this solution, please run 'paket init' first.
If you have already run 'paket.init' then ensure that 'paket.dependencies' is located in the top level directory of your repository.
Like this:
MySourceDir
  .paket
  paket.dependencies

Looks like the templates are missing, must have dumbed it during some rebase. Opening a new WIP PR for fixing it.


Add screenshot to README

Adding a screenshot to the README would help people deciding whether this is the right IRC client for them.

Once the light/dark themes are figured out I'll upload screenshots and put them on the README.md

also Very good issue thank you


exported pdfs don't have pictures

yikes

yeah its incredibly yikes

They don't get saved to JSON either. The reason is simple. See this export:
{"qboard-version":1,"pages":[{"version":"4.2.0","objects":[{"type":"image","version":"4.2.0","originX":"center","originY":"center","left":583.15,"top":581.96,"width":218,"height":80,"fill":"rgb(0,0,0)","stroke":null,"strokeWidth":0,"strokeDashArray":null,"strokeLineCap":"butt","strokeDashOffset":0,"strokeLineJoin":"miter","strokeMiterLimit":4,"scaleX":1,"scaleY":1,"angle":0,"flipX":false,"flipY":false,"opacity":1,"shadow":null,"visible":true,"backgroundColor":"","fillRule":"nonzero","paintFirst":"fill","globalCompositeOperation":"source-over","skewX":0,"skewY":0,"cropX":0,"cropY":0,"id":1,"strokeUniform":false,"src":"blob:https://pihart.github.io/9d963524-c115-487a-b0eb-96ae3f1fa6d9","crossOrigin":null,"filters":[]}],"background":"white"}]}

The images get saved as blob urls which means something like canvas.toDatalessJSON is being called internally somewhere.

Actually, I think fabric doesn't update the url after you do fabric.Image.fromURL

we can override the toJSON method or something of the object to embed the image too? or i think just replacing toDatalessJSON with just toJSON or whatever it was called should fix this

No, I think the issue might be different. I don't know fabric very well, but I think you have to do something else when creating an image from a blob url.

A temporary fix would be to store an array of the blob urls and the actual image data; then add that in the json at save-to-json time. When opening, the json file, so a search and replace against that array and create a new blob.


Bug on fabric server when connection

Hello when i connect to my fabric server it crashed with midnight mod here crash log
crash-2024-04-07_12.53.49-server.txt

Sorry it took a sec, this should be fixed in the latest version!


Update sbt-scalafmt to 2.4.3

Updates org.scalameta:sbt-scalafmt from 2.4.2 to 2.4.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "sbt-scalafmt" } ]

labels: sbt-plugin-update, semver-patch

Codecov Report

Merging #521 (0b172a1) into main (fbbe4ad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #521   +/-   ##
=======================================
  Coverage   90.23%   90.23%
=======================================
  Files          15       15
  Lines         758      758
  Branches       43       40    -3
=======================================
  Hits          684      684
  Misses         74       74

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbbe4ad...0b172a1. Read the comment docs.


Cloud function routing

Notes:

Gear route is changed from /{gear}/* to /_{gear}/*.
I've come up with the name CloudCode / cloud_code in code level as a general name for cloud function and microservices, in response to https://github.com/SkygearIO/features/pull/278#discussion_r258941485.
Context is used to pass data between middlewares and handlers, which is against what we have discussed at the very early stage.

connect #898

Context is used to pass data between middlewares and handlers, which is against what we have discussed at the very early stage.

I think passing data with context is suitable in the case of this PR. However, if we want to ensure type safety, which is the biggest argument for not using context, I suggest we use a struct to contain data for the whole gateway and pass it in context.

Update: defined struct for context.

@kaojohnny See if it looks good for you too when you have time?


Add a spec for Application State

This draft pull request (Review link) introduces a specification for "cross-session" app state that isn't stored in the user's settings.json.
PR Checklist

[x] Specs #8324
[x] CLA signed. If not, go over here and sign the CLA
[x] Tests added/passed
[x] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[x] Schema updated.
[x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Review link

@carlos-zamora clarify? A whole section was dedicated to why (the applications). Any questions I can answer?

@carlos-zamora clarify? A whole section was dedicated to why (the applications). Any questions I can answer?

I don't mean it as a bad thing haha. I mean more that I'm curious what the design for "don't ask me again" or "keep the profile deleted" would look like. But I'm guessing the specific design for those settings is a bit out of scope here (if they even need a design, frankly).
Like, I'm curious if we should move disabledProfileSources over or how that would interact with the plan for "keep the dynamic profile deleted"? But that's probably out of scope.

So, disabledSources is twofold:

It means “do not run the expensive profile search code” (like the VS Generator!)
When extensions exist, they could be suppressed.

Disabling the source is a bigger hammer than deleting one profile generated by the source.

Reasonable question though!


Allow empty git commit

With some of our salt config we sometimes need to push an empty commit (with the commit message being the name of the service we need to redeploy).
It's also good if you need to trigger any other sort of commit hooks where the commit message is used for some purpose.
I tried as much as possible to just slimly insert this feature alongside the rest of the git stuff.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: tombasche sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks! :beers:


Added Favicon, fixed link and formatted code

Accept This PR🚀
by adding hacktoberfest and hactoper-accepted
before merge
Thanks

Hi, lots of good stuff here.
However, to keep things organized, can this pull request only have the code related to the favicon?
And then a separate PR for the code formatting, and a separate one for any other details/changes...
I can create and assign to you a reformat issue with the hacktober stuff if you'd like.

You have done a fantastic job so far btw :)

favicon is good √
<meta name="viewport" content="width=device-width, initial-scale=1.0"> is affecting mobile interface. dont worry about it. ill investigate that later.
that netlify link is cool. nice way to demo ! thanks for showing me that

merged and added the labels. Thank you.
but yeah i would say next time, try to break up changes in different PRs. ie. "reformatting" should not introduce features or functionality. but i dont know hacktoberfest that much and this project is super simple (haha) so it's ok √√


NETOBSERV-754: add pprof, improve memory footprint

Description

Dependencies

n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

[ ] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
[ ] Does this PR require product documentation?

[ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

[ ] Does this PR require a product release notes entry?

[ ] If so, fill in "Release Note Text" in the JIRA.

[ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

[ ] If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

[ ] Standard QE validation, with pre-merge tests unless stated otherwise.
[ ] Regression tests only (e.g. refactoring with no user-facing change).
[x] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

As suspected, watchers for certificates are consuming a lot:

If I remove the cert watchers:

This overhead would grow with cluster size.
So there's definitely something to do here

@msherif1234 @OlivierCazade I think this PR can be merged as is and I'll work on the actual memory improvements in a different PR

In blue: without this PR; in green: with this PR

Will run this as a pre-merge test next week

/ok-to-test

/approve


renamed docker-compose files to sample

Description
This PR cleans up some of the files in our root directory, specifically related to sample files for docker-compose
Related PRs
List related PRs if applicable
Todos

[ ] Tests
[ ] Documentation
[ ] Link to Trello

 Rename docker-compose.<env> files to sample


chore(wmg): update tissue mapper to use owlready2 instead of pronto

In #4493 we wish to use the ontology hosted in the curation repo, which is a .owl file. The tissue mapper, however, uses pronto, which requires a .obo file. The tissue mapper should be updated to use owlready2 instead.
This is the function that must be updated:
https://github.com/chanzuckerberg/single-cell-data-portal/blob/523312c9bdf2b1dae3a28c8916b1832622bf66c1/backend/wmg/data/transform.py#L74

If there is a strong rationale for requiring the obo format rather than owl, the mitigation could be to also download the .obo for a specific pinned version. Generally, there are obo, owl, and json formats.
In addition, I've been curious about the JSON format. See A JSON graph-oriented model for ontologies:

One consequence of this is that the central object is an existential graph (I’ll get to that term in a second). We call this subset Basic OBO Graphs, or BOGs, roughly corresponding to the OBO-Basic subset of OBO Format. The edge model is pretty much identical to every directed graph model out there: a set of nodes and a set of directed labeled edges (more on what can be attached to the edges later).

@ebezzi - it appears that you implemented the original function. Can you comment?

Also, point that needs clarification:

The tissue mapper, however, uses pronto, which requires a .obo file. The tissue mapper should be updated to use owlready2 instead.

The tissue mapper (here) does not use pronto.

Ah, dang, thanks for the correction. The _cell_type_ordering function uses pronto, not the tissue mapper.

The cell ordering function was a port from an R notebook written by @pablo-gar. If I recall correctly, using owlready2 yielded significantly different results from the original notebook while using pronto worked reasonably well with minimal manipulation, so I ended up choosing it, especially since this was a time sensitive issue.
It is possible that the same result could be achieved with owlready2 but I think it will take time. Also pronto should support owl files as well so it might be worth giving it a try.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/107 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit 0109334:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: Docs Build is busy, currently there are 7 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 0109334:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: Docs Build is busy, currently there are 7 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 0109334:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/index.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/sql-database-engine.png
:white_check_mark:Succeeded

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 0109334:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/index.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/sql-database-engine.png
:white_check_mark:Succeeded

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


requirements: Upgrade moto to latest version.

Fixes #5454

Automated message from Dropbox CLA bot
@sinwar, it looks like you've already signed the Dropbox CLA. Thanks!

Codecov Report

Merging #5485 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #5485   +/-   ##
=======================================
  Coverage   86.65%   86.65%
=======================================
  Files         431      431
  Lines       53522    53522
  Branches     2088     2088
=======================================
  Hits        46378    46378
  Misses       7144     7144

Impacted Files
Coverage Δ

zerver/tests/test_upload.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96dc204...56af0b9. Read the comment docs.

@showell I think now it's ready to merge.

Merged, thanks @sinwar!


Add document identifier and committee for MEP and "Brochure Appendix" documents

From @intelligent2013:
@opoudjis in source XML this data are absent:

to produce a cover page. Could you add it please?
Originally posted by @Intelligent2013 in https://github.com/metanorma/metanorma-bipm/issues/5#issuecomment-704943147

I've already done this in response to https://github.com/metanorma/metanorma-bipm/issues/5#issuecomment-704943147. The document identifiers are BIPM SI MEP __1 (and in one case __2), where the __ is populated by a title case version of the unit discussed (so S for s, Kg for kg).
The full name of the committee has been differentiated from the abbreviation; both are now document attributes.


add schinese translation

I don't know how to build the mod.
Just add some text.
Maybe some fix are needed.

thanks, fixed the folder name.


Adjust padding in batch generation

What does this PR do?
Fix a bug in the batch_generation function where we try to concatenate tensors that can be of different dimensions (sequence_length) when generating with mini_batches.
Before submitting

[X] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[X] Did you read the contributor guideline,
[X] Did you write any new necessary tests?

Who can review?
@kashif @qgallouedec

@gaetanlop  can we use the pad helpers?
padded_query_responses = pad(query_responses, padding_value=pad_token_id)
padded_logitss = pad(logitss, padding_value=float('-inf'))

@kashif, the pad function expects the tensor to have no leading dimension corresponding to the batch size.
Here is an example query_responses:
query_responses = [
  torch.randint(vocab_size, (bs, seq_length1)),
  torch.randint(vocab_size, (bs, seq_length2)),
  torch.randint(vocab_size, (remaining_samples, seq_length3))
]

Using the pad function as it is would require the following change before passing the query_responses to the pad function:
query_responses=[query_reps[i] for query_reps in query_responses for i in range(query_reps.size(0))]

We can also change the pad function? What do you prefer?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

This won't work @kashif, it still requires reshaping the tensors

ah damn! my bad sorry!

This should be fixed now


error on pyw extention

hi, it's me again, sorry again for bad English
I tried this code in py file, open using python IDLE, run -> run module F5 ===> no problem
then rename the extension to pyw, open like exe (double click), and this is the result:
Traceback (most recent call last):
  File "D:\Script\translate.pyw", line 67, in FB_Loading
    import dl_translate as dlt
  File "C:\Python\Python39\lib\site-packages\dl_translate\__init__.py", line 3, in <module>
    from ._translation_model import TranslationModel
  File "C:\Python\Python39\lib\site-packages\dl_translate\_translation_model.py", line 5, in <module>
    import transformers
  File "C:\Python\Python39\lib\site-packages\transformers\__init__.py", line 43, in <module>
    from . import dependency_versions_check
  File "C:\Python\Python39\lib\site-packages\transformers\dependency_versions_check.py", line 36, in <module>
    from .file_utils import is_tokenizers_available
  File "C:\Python\Python39\lib\site-packages\transformers\file_utils.py", line 58, in <module>
    logger = logging.get_logger(__name__)  # pylint: disable=invalid-name
  File "C:\Python\Python39\lib\site-packages\transformers\utils\logging.py", line 119, in get_logger
    _configure_library_root_logger()
  File "C:\Python\Python39\lib\site-packages\transformers\utils\logging.py", line 82, in _configure_library_root_logger
    _default_handler.flush = sys.stderr.flush
AttributeError: 'NoneType' object has no attribute 'flush'

any guide to fix this?

I never tested on pyw files and I'm not very familiar, so not sure it's something supported.
Maybe can you write a simple script that runs
import transformers
print(transformers.__version__)

and open in pyw? If that works in py but not pyw then it's likely a transformers issue and you can log a issue there

thank you for your reply,
when using idle
import transformers
print(transformers.__version__)
input("press any key to continue...")

it shows: 4.12.5
when open as pyw, the window/cmd do not appear,
I think this is the source
I tried to update it using
pip install --upgrade transformers
successful to update to 4.15.0
but the  pyw, the window/cmd still do not appear

In this case I believe this is an issue with the transformers library. Feel free to open an issue there: https://github.com/huggingface/transformers

thank you again xhlulu for the reply, I close this issue


ENH: [CI / Docker]: Create a workflow to temporarly build docker images in case dockerfiles are modified

As per title, just testing it for now

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@glegendre01 do you think it's ok to move forward with this new workflow?

Thanks for the review!
I think that it should be all good as we don't push any docker image using that workflow and we use a GHA pinned on a specific commit (from @glegendre01 comment), in any case all PRs needs a maintainer approval before running the CI so we should be careful when reviewing PRs where we have some doubts (by pinging @glegendre01 if we have some strong doubts 🙏 )

Also I need to merge this PR before properly testing it as GH does not allow to add new workflow from PRs :D


GDScript instances lock(Thread Safe)

ah this is a good one, I totally missed it. I'll review this one properly and merge as soon as I can.

There seem to be merge conflicts, could you have a look @sanikoyes?

problem with this is that i don't think it will work with containers, or might trigger an infinite loop given size keeps changing

Adding for review for 3.0 then.

@reduz I think you meant to comment on some other PR/issue, right?


Feign or Ribbon Configuration based on HTTP request method

It would be great if it was possible to config Feign clients or Ribbon to use different retry and timeout policies based on the request methods. For example, for GET requests it is acceptable to have short timeouts and retry on multiple servers. However, for POST, PUT and DELETE requests that are not idempotent it is not acceptable to retry on next servers since it may lead to undesirable states. Also, timeouts for this types of requests can normally be higher that GET ones.
I don't know if it is possible to do this kind of configuration right now. If it is possible, I appreciate it if someone share the configuration with me. If not, it can be a good feature.
I have also added this issue to spring-cloud netflix project spring-cloud/spring-cloud-netflix#1063

Issue was (in somehow a bit hackish way) resolved in this stackoverflow topic:
http://stackoverflow.com/questions/34456075/pass-request-headers-to-ribbon-irule-key-parameter
Setting the serverLocator param with the whole request object would allow to do what you want with a proper IRule implementation (it is then used as a key object in IRule).
Would be nice to be able to customize LoadBalancerCommand with composition (LocaBalancerCommandFactory?), NOT by overwriting AbstractLoadBalancerAwareClient.executeWithLoadBalancer method as this requires overwriting of FeignLoadBalancer and CachingSpringLoadBalancerFactory (AFAIK).


Change auto-detection of column count

Is your feature request related to a problem? Please describe.
Currently, the column count is decided as the largest among the lines read for each purpose; upload preview, sampling, and generating snapshots.
Variable column count for time by time could lead to critical misunderstanding.
Describe the solution you'd like
Make the column count of the first line divided by the delimiter given to be the established count.
Describe alternatives you've considered
Read at least the preview lines ("maybe" 25 rows), but this is not preferable because, there's "maybe" and it can be changed by the release. (for not enough good reason)
Additional context
There was a bit of debate on this. The correct way or mor preferable was can be changed later on.

Check this out. I think this issue had been resolved already.

Column count should not vary according to sampling size.
Currently, the column count is the max column count within the dataframe.
So, when preview and when snapshot, the count is different.
I think we should set column count by the 1st line.
Of course, we must give a way to manually set the count.
BTW, limiting on column count should be applied in this chance.
We'll limit the column count up to 2000.
I think it will probably be caused by a wrong delimiter.

Integrated test done.


Library support?

Hello,
It appears that there are mainly examples for compiled languages.
Is it possible to do fuzzing for general-purpose libraries as well?
For example, libcurl, libpcap
Thanks.

Yes it is definitely possible, as long as these libraries take in some inputs which can be of some file format containing semantically meaningful strings. You can setup these libraries similar to how you may setup the existing targets and feed them generated fuzzing inputs for Fuzz4All to perform fuzzing.

Thank you for your reply. Let's try it!


[5.9] Add sortKeysByPrimary to collection

If you need to place keys in your order in sorting
collect([
    'size' => 10,
    'name' => 'Desk',
    'price' => 100,
    'orders' => 10,
])->only(['name', 'price', 'size'])->sortKeysByPrimary(['size'])->all()
// [
//     "size" => 10,
//     "name" => "Desk",
//     "price" => 100,
// ]

The idea of a functional from https://github.com/laravel/framework/pull/27926
However, placing this functionality in Arr :: only, in my opinion, violates the principle of single responsibility

Isn't this something you can perfectly do in user land? Seems like a bit overkill to add to core.

Isn't this something you can perfectly do in user land? Seems like a bit overkill to add to core.

@driesvints Do you mean that is better to do so?
$data =collect([
    'size' => 10,
    'name' => 'Desk',
    'price' => 100,
    'orders' => 10,
])->only(['name', 'price', 'size'])->sortKeys()->all();
array_merge(Arr::only(['size'],$data),$data);

Or something else. I just mean that the extra param to these methods seems out of place.

Or something else. I just mean that the extra param to these methods seems out of place.

Is it better to do like this?
collect([
    'size' => 10,
    'name' => 'Desk',
    'price' => 100,
    'orders' => 10,
])->only(['name', 'price', 'size'])->sortKeysByPrimary(['size'])->all()

It's a way to do it. Not saying it's better. I'm just saying that I think it's better to let this be handled in user land.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Add Crafting Pattern awereness to the Crafting Terminal

EMI currently doesn't account for items that could be crafted using the crafting patterns stored in the system.

e.g. Tech Reborn's Iron furnace should be displayed since it that's its crafting recipe.

Expected Behaviour:
The user should be prompted with the auto crafting chain for all items that can be crafted, even if there are missing items on the recipe.
Nice-to-haves:

Preferably those items that can be autocrafted could be highlighted with a different color, indicating that they currently don't exist but can be crafted by the system.

Items that the system is aware on how to craft but can't since some ingredients are missing should be highligted using another color.

The crafting tree should take into account the patterns, if the player is on a crafting terminal.

basically, its multiple autocraft request screens in a row, is this realizable?

Honestly this goes against the idea that craftables should only show items that exist and not those that can be crafted. This would be convenient but I'd need to think if this can be done in a inteligent way or if emi would even support that.


autotype

When importing files, autoType should not be by default. It should be an option.

I removed autoType. It can lead to errors.


Model Naming

Describe the bug
Naming error, Can add verbose_name and verbose_name_plural
To Reproduce
Steps to reproduce the behavior:

Go to the admin panel
See error

Expected behavior
Should be Plural like Working Hours
Screenshots

Desktop (please complete the following information):

OS: Ubuntu 24.4
Browser : Firefox

Possible Solution
Adding the verbose name
Can you fix the bug?

[ yes] Yes, I can fix the bug and will open a pull request.
[ ] No, I can't fix the bug, but I can assist in testing and providing feedback.
[ ] No, I can't fix the bug, but I can provide more information to help you fix it.
[ ] No, I can't fix the bug, but I can open an issue to report it.

Hi @Abhimanue-rajesh, thanks for noticing. I will wait for that pull request.


constants are not recognized when used inside of constant expressions

rust-analyzer does not recognize consts if they are used inside expressions that define other consts
E.g.:
const N:usize = 2;

struct Test {
    b: [u32; N],
}

rust analyzer does not recognize N in the array declaration as contant, nor can it move to its definition with F12 in VS code. It shows "no definition found for N".
The same issue also appears if you try to use a const inside other expression in functions.

Duplicate of #7432


add method tag for metadata access monitoring

a label(method anme) is added to the opDist metrics collector of metadata operations at pkg/meta/base.go:217
so that we can clearly view the time duration and qps of different methods through monitoring, which is useful for troubleshooting problems and analyzing performance bottlenecks.

Codecov Report
Patch coverage: 59.52% and project coverage change: -31.62 :warning:

Comparison is base (d95ad52) 56.51% compared to head (7a7f7dd) 24.90%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3501       +/-   ##
===========================================
- Coverage   56.51%   24.90%   -31.62%
===========================================
  Files         149       24      -125
  Lines       36306    14094    -22212
===========================================
- Hits        20520     3510    -17010
+ Misses      13543    10206     -3337
+ Partials     2243      378     -1865

Impacted Files
Coverage Δ

pkg/meta/redis.go
0.11% <0.00%> (-66.82%)
:arrow_down:

pkg/meta/sql.go
0.00% <0.00%> (-58.67%)
:arrow_down:

pkg/meta/base.go
59.51% <100.00%> (-4.38%)
:arrow_down:

pkg/meta/tkv.go
59.99% <100.00%> (-11.70%)
:arrow_down:

... and 142 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Usually we use access log and juicefs profile if we want to know details of each operation.

@shichanglin5 Could you keep the original opDist (so juicefs stats still works), and add a new HistogramVec for the metrics with tags?

@shichanglin5 Could you keep the original opDist (so juicefs stats still works), and add a new HistogramVec for the metrics with tags?

This way is feasible, but there will be two opDist; How about modifying the stats code and merging the different label statistics of this opDist?


og.url is not mapped

@otiai10
In the current implementation, opengraph.URL defaults to the parsed request URL and doesn't maps the og.url meta tag.
Is it okay to add a new field called Value in opengraph.URL struct which maps the og.url meta tag value?
Or if I am missing something here, please let me know. I want fetch the og.url meta tag from the parsed HTML.
Thank you.

ah... nice catch. You caught the problem correctly. Thank you.
If og:url exists, it should be preferred over the URL which is parsed from initial input.
Thus, we don't need Value field in opengraph.URL, but just overwrite it if og:url exists.
What do you think?

The reason I would prefer a different value is that if og.URL is overwritten we won't have any clear mechanism to know if it was fetched from the meta tag or is the default value. Also, I believe maybe passing the value as string instead of URL would be better due to validity issues. What do you think?

What kind of validity do you mean?

What kind of validity do you mean?
If the content/URL set on og:url meta property is invalid then parsing it might cause an error which might not be what we want maybe? Just returning back the content fetched from the property as string should be okay acc. to me.

Also, if we overrite it do we have any way to check if og.url property was found or not?

Closing this now. Thank you!


Broken screenshot link in README.md

This happened for a split second when I was testing something, it is now fixed!


🚀 Feature: Support GA Release

🔖 Feature description
Any plans to officially support the Appwrite server version 1.x, now that it's gone to GA?
🎤 Pitch
Would be nice to support the latest, full release. (Please). :D
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

We want to add proper response model support before going 1.x with the SDK.

We want to add proper response model support before going 1.x with the SDK.

I'm happy to help with perfecting the Appwrite Client SDK, Feel free to drop a comment on this. Will move ahead with further plans

Would love to see the Appwrite DotNet Client SDK getting on Par with other Client SDKs, Currently DotNet Maui, Uno Platform, Avalonia, etc.. getting lots of traction. DotNet devs would love to have option of using Appwrite as a backend for many different DotNet Applications


NETStandard / .NET Core support

Currently Refit does not work with .net core projects. With .NET Core moving to use msbuild, we should still be able to invoke the targets in the same way.
The easiest course of action is to just expose refit as netstandard and rely on mono to exec the tool as per today. The next option is to make the generator tool a netcore app itself or a dotnet command (dotnet-refit) and enable a pre-build script to invoke it.

Workaround for now:
VS 2015 Update 2 adds support for changing a regular CSProj PCL to support .NET Standard, so create a csproj pcl and set it to .net standard 1.4
then use this project.json for it:
{
  "dependencies": {
    "NETStandard.Library": "1.5.0-rc2-24027",
    "refit": "2.4.1",
    "Newtonsoft.Json": "8.0.3"
  },
  "frameworks": {
    "netstandard1.4": {
      "imports": ["dotnet", "portable-net45+win8"]
    }
  }
}

the imports are needed because refit doesn't explicitly support netstandard yet
Because it's a csproj, the targets work as expected. You can then add a reference to it from your asp.net 1.0 website or from another xproj like this:
"MyPclLibrary": {
      "target": "project"
    }


Add support for adding custom comment header to INI files

Is your feature request related to a problem? Please describe.
Currently, it is not possible for a user to add custom header comments.
    @priscavdsluis Hi Prisca, thanks for the answer. I am specifically looking to add comments on top, so where "# written by HYDROLIB-core 0.3.0" is now located. Something like "#Values in this file are derived from DCSM-FM 3D version 20220510. The points are locations on the RMM 2D j19 extended model". So not something in the general block or behind instances, but a global comment at the top of the file. Is that also possible?

Originally posted by @veenstrajelmer in https://github.com/Deltares/HYDROLIB-core/issues/130#issuecomment-1272963902
Describe the solution you'd like
Make the header of the file customizable for users.
Possible technical solution
Currently, In the INIModel._to_document function, a header variable is created with the content written by HYDROLIB-core <version>.
Suggestion: this variable could also be class attribute that is customizable per ParsableFileModel instance.

@arthurvd, I wonder the following:
If the user is able to edit the header comment, should we also be able to read it?
Now we always write: written by HYDROLIB-core <version> to INI files.
This makes sense, since it is true.
Should the header be "write-only"?


Can i query the data on the console with work->Queries ?

or make the data query-able somehow? for a work item page extension...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8490096d-54dd-697b-62a3-9c930d0733d1
Version Independent ID: 04f42aed-a8c2-f124-1c32-37daf54e8400
Content: Data and Setting Storage
Content Source: docs/extend/develop/data-storage.md
Product: devops
GitHub Login: @elbatk
Microsoft Alias: elbatk

Hey @ellifshi , sorry we left you hanging here. I think you'd find an answer more efficient either on Stack Overflow or the Azure DevOps Developer Community, which are both monitored by the product team. If there is a docs consequence from your inquiries, feel free to come back here and let me know! Closing this now as a docs issue.


Not working on Ubuntu 15.04

I just tried to use this on Ubuntu 15.04, and running docker run -d tobert/cassandra -name "Test Cluster" results in the container starting and immediately dying. There is no output from docker logs. I tried with both Docker 1.3.3 (from the Ubuntu repos) and 1.5.0 (from here).
Is this a known issue, or do you have any idea that could point me in the right direction to get this working?

same here

I'll fire up a VM when I get a chance and check it out.
How much memory does the host OS have available? The most common cause of problems is not enough memory to run the default memory size in the container. Try with "-heap 512 -new 128" if you have 512MB of memory available. It should work OK down to 256M or so.

So it looks like the issue, at least for me, was that I was using -name "John's Cluster", and for some reason it doesn't like the ' in the name. Running with any name without the ' works for me, even without -heap 512 -new 128.  I must have just copied and pasted that command with the name Test Cluster from the readme instead of the one I was actually running, which is sloppy on my part; sorry about that.

Oh! yeah I should check for single quotes and auto-escape them in the entrypoint. The yaml uses single quotes around the name so it's probably causing breakage there.

Huh. I'm also just running docker run -d tobert/cassandra -name "Test Cluster" and it immediately exits with nothing in docker logs. Fresh Ubuntu 14.04 x64 DigitalOcean VPS.

For what it is worth I think in the latest version of docker the name argument has changed.    If I do docker run -d  tobert/cassandra -name "My Cluster"  docker will ignore the name option and give it a dynamic name like stoic_mayer.   However if I do docker run -d  --name="My Cluster" tobert/cassandra I get an invalid name error but if I do docker run -d  --name="my_cluster" tobert/cassandra it names it properly

The name argument isn't for the name of the docker instance, it's the name of the Cassandra cluster and will be put into the cassandra config file.

Maybe I should rename -name to -cluster_name to remove the confusion? Thoughts?

I think that probably adds some clarity.


chore: added eventsApiProxyURL option for proxying to a different url than the sdk config

#194  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsalaber and the rest of your teammates on  Graphite


Consider use of circles instead of boxes

Boxes look wonky in places. Maybe circles would look better?

Drawing is now done using hollow circles (to minimize the number of pixels written in the laziest way possible). It's been that way for more than a year now, btw... Just saying.


Add a mention about video recording feature on the landing page

I think it may attract attention. We could do it after an implementation some other debugability features and highlight them all in one section.

Live mode is a very valuable feature. We can add mention about live mode on the landing page too.
Cypress put info about the same feature on its landing page.


Do not immediately fail if git is not available

Fix gh-312.
There are several ways of doing this, I picked one that I considered simple enough. The idea is to always import git from a centralized place, and in that place do a soft fail if git fails to be imported from plumbum.cmd.
This is how copier --version looks like with these changes:
root@885f691c5e79:/# which git || echo "git is not available"
git is not available
root@885f691c5e79:/# copier --version
/usr/local/lib/python3.10/site-packages/copier/vcs.py:25: UserWarning: git command not found, some functionality might not work
  warnings.warn(
copier 7.1.0a0.post98.dev0+5d600ff

On the other hand, I made copier.vcs.is_git_bundle more consistent with is_git_shallow_repo and is_in_git_repo, and now it returns False if there is an OSError or ProcessExecutionError error. Thanks to that, now copier can work with gitless templates as well, as mentioned in https://github.com/copier-org/copier/issues/1045#issuecomment-1492956700:
root@885f691c5e79:/# copier /home/copier-pylib-main/ /tmp/
/usr/local/lib/python3.10/site-packages/copier/vcs.py:25: UserWarning: git command not found, some functionality might not work
  warnings.warn(
🎤 Your account or organization
   astrojuanlu
...

Copying from template version None
 identical  .
    create  .gitignore
...

I have two questions:

First, I have no idea how to test this. Initially, I tried some form of mocking or monkeypatching, but since plumbum.cmd.git is not an actual attribute, things are more complicated:

    @pytest.fixture
    def no_plumbum_git(monkeypatch):
>       monkeypatch.delattr("plumbum.cmd.git")
E       AttributeError: git

tests/test_main.py:6: AttributeError

I could do a very deep patching of how plumbum.local retrieves the command, but wanted to ask for advice first.

As I explained in the second commit, one could actually consider that copier.vcs.is_git_bundle, is_git_shallow_repo, and is_in_git_repo should return None or something else than True or False, if the git status could not be determined because the git command is missing. In this scheme, returning None would mean "I don't know if this directory is actually a git repo". For this reason, I preferred to wait before proceeding any further adding tests.

Let me know what you folks think.
For the record, I too was a bit puzzled by the heavyweight requirements to run the linter https://github.com/copier-org/copier/issues/931 so going forward I think I'll use Gitpod to continue this PR (I have only used Nix a bit when experimenting with Replit earlier this year, not sure if I already want to commit to installing it on my home laptop).

This is ready for a second pass again. I think this now will be easier to test (haven't started doing it yet).
On the other hand, my other question still stands:

As I explained in the second commit, one could actually consider that copier.vcs.is_git_bundle, is_git_shallow_repo, and is_in_git_repo should return None or something else than True or False, if the git status could not be determined because the git command is missing. In this scheme, returning None would mean "I don't know if this directory is actually a git repo". For this reason, I preferred to wait before proceeding any further adding tests.

As I explained in the second commit, one could actually consider that copier.vcs.is_git_bundle, is_git_shallow_repo, and is_in_git_repo should return None or something else than True or False, if the git status could not be determined because the git command is missing. In this scheme, returning None would mean "I don't know if this directory is actually a git repo". For this reason, I preferred to wait before proceeding any further adding tests.

I don't think this is a good solution.
Instead, those functions should be able to return a boolean without relying in the presence of git. That shouldn't be too hard (just check if there's a .git file/dir in the folder or any of its parents, usually).
This way, if it really is a git repo and git is not available, then copier should fail.

Applied changes and ran poe lint (doing so from Gitpod was more or less straightforward 👍🏽)

As I explained in the second commit, one could actually consider that copier.vcs.is_git_bundle, is_git_shallow_repo, and is_in_git_repo should return None or something else than True or False, if the git status could not be determined because the git command is missing. In this scheme, returning None would mean "I don't know if this directory is actually a git repo". For this reason, I preferred to wait before proceeding any further adding tests.

I don't think this is a good solution.
Instead, those functions should be able to return a boolean without relying in the presence of git. That shouldn't be too hard (just check if there's a .git file/dir in the folder or any of its parents, usually).
This way, if it really is a git repo and git is not available, then copier should fail.

I'm reverting this commit for now

Apologies if this is not the right place to bring it up, but after this merge, I am still seeing a failure when attempting to run copier without git installed.
is_git_bundle is still calling get_git without handling the exception when it fails

See https://github.com/copier-org/copier/pull/1074#issuecomment-1694355508, left it out of this PR


Frontend should support keep-alive connections from major clients.

Long lived HTTP connections suppor in Cowboy does not work very well with nodejs http.Agent, nor curl. We should fix that.

Fixed.


webp animation not works in assets

What version of starlight are you using?
0.1.2
What version of astro are you using?
2.6.2
What package manager are you using?
pnpm
What operating system are you using?
Linux
What browser are you using?
Chrome
Describe the Bug
When whe try to compile an image in a .md file, the WEBP animation image does not work propely and crash the dev server with this error:
[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "Cannot read properties of null (reading 'data')".] {
code: 'ERR_UNHANDLED_REJECTION'
}
Link to Minimal Reproducible Example
https://codesandbox.io/p/sandbox/github/PabloBagliere/example-error-astro/tree/main
Participation

[ ] I am willing to submit a pull request for this issue.

Thanks for the report! I think we can fix this with the next minor release. We’re going to switch Starlight to use Sharp instead of Squoosh for image optimisation, and I just tested and looks like Sharp handles this animated WebP successfully — very useful to have that as a test case.
Will report back here once we fix this, but if you follow this “Using Sharp” guide in the Astro docs, that should unblock you for now: https://docs.astro.build/en/guides/assets/#using-sharp

Sharp needs to be a direct dependency of projects, so I’m not able to enable it by default in the next release as I hoped, but I still recommend switching to it. There is a full guide in Astro’s docs on how to enable Sharp. Let me know if you still see any issues!


Remove unused never feature to support stable rust

Big sorry. I completely missed this.
This should work on stable now.


Add TaskQueueSwarm documentation

Added a simple md doc for Taskqueue-swarms

📚 Documentation preview 📚: https://swarms--608.org.readthedocs.build/en/608/

@Occupying-Mars overall great but we need to add swarm_models instead of swarms.models

@Occupying-Mars put the file path of the docs in mkdocs.yaml


Decorator

Project requirements

Check the usage of Decorator pattern in Ruby
Think about how you can use two decorators in order to capitalize and trim people's names.
In the following steps you will get instructions for implementing the Decorator design pattern for this case.

Interface

Create a class Nameable.

Implement a method called correct_name that will raise a NotImplementedError.

Turn your Person class to Nameable

Make sure that your Person class inherits from Nameable
Make sure that this class has a method correct_name implemented. It should simply return the name attribute.

Prepare base Decorator

Make sure that it inherits from Nameable.
In the constructor assign a nameable object from params to an instance variable.
Implement the correct_name method that returns the result of the correct_name method of the @nameable.

Prepare CapitalizeDecorator and TrimmerDecorator

For the CapitalizeDecorator:

Create a class that inherits from the base Decorator class.
Implement a method correct_name that capitalizes the output of @nameable.correct_name.

For the TrimmerDecorator:

Create a class that inherits from the base Decorator class.
Implement a method correct_name that makes sure that the output of @nameable.correct_name has a maximum of 10 characters. If it's longer it should trim the word.

Hi @heintayzar-hm,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You do not have a descriptive readme file
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Sea-Level collectors: don't collect empty data

I wondered, why the collectors return empty arrays. when debugging I can see the phpstan workers shuffling arround huge arrays, which mostly contain of empty data.

How is this useful? Returning nullable arrays would lead to verifiction of nullable arrays.
The other docblocks are now wrong as well.

My thinking was:

phpstan needs to handle a lot of empty arrays which is unnecessary work
the change does not break tests therefore should't make the analysis less correct

At the moment it creates more complexity for no gain. How faster it is?
The non-failing test might be accidental, as there is no test for nullable values and docblocks are still incorrect.

I don't agree but thats fine.
Also, I don't see why the phpdocs are wrong. But doesn't matter.

Here it would crash on iterate on null:
https://github.com/symplify/symplify/blob/main/packages/phpstan-rules/src/Rules/Explicit/ParamTypeDeclarationSeaLevelRule.php#L62
I wish collectors would use jsonable objects, so this is more obvious. Arrays can hide these bugs easily :)

Nulls won‘t be collected: https://github.com/phpstan/phpstan-src/blob/80ba5a0a570834bc96b81ccc614a9cc84fe54c9a/src/Analyser/FileAnalyser.php#L148

Good to know :+1:
Seems a bit counter-intuitive, while errors are always arrays.


[Suggestion] Remove html type from CSS selectors.

To define transitions, the readme specifies using the pattern html.is-animating, html.is-leaving, and similar constructs.
However, CSS selectors attached to element types cause issues with over-specificity: they will take precedence over selectors which do not include the element type, no matter how deep those selectors may be nested, leading to !important declarations or additional over-specific selectors to combat the original culprit.
I suggest removing html from the CSS, leaving .is-animating, .is-leaving, etc. as class names only. However, this could potentially conflict with 3rd party libraries that use the same class names, since they are common. I can imagine two solutions:

Prepend swup- to existing document-level classes. (So .is-animating becomes .swup-is-animating, .is-leaving becomes .swup-is-leaving.) This benefits from clarity: unfamiliar users would be able to immediately understand what library is responsible for adding the classes. It would leave the existing structure intact. However, it would break installations for any users who upgraded—they would have to update their class names.

Add a .swup class at the document level and combine that with existing classes. (.is-animating becomes .swup.is-animating, .is-leaving becomes .swup.is-leaving.) This contains the benefits above, but without breaking existing installations. It could potentially cause issues if the class .swup is used elsewhere (unclear) but otherwise I think it would help solve the issue with over-specificity.

Readme states this format for the sole purpose of repeating that the classes are applied to the html tag. Web beginners or people new to swup often overlook little details in the documentation, so repeating things where possible turned out to be helpful over time. The styles are also more specific, as you mentioned, which is generally bad... but I see that as a plus for less skilled users.
I usually use something like the following pattern in stylus.
.transition-fade
    opacity 1
    transition .4s

    .is-animating &
        opacity 0

I use libraries very rarely, and when I do, I know that they are not going to cause any trouble with swup, so this pattern is just fine for me. I'm also used to keeping the structure pretty flat (minimal nested classes, usually each element has its own class... classic BEM stuff), so overwriting styles is easy.
I'm sure that more skilled users have no problem figuring out how to best structure their CSS once they are familiar with how swup works, as you did as well. For the less skilled users, I think it's better to keep the html.is... recommendation in place.
FYI - swup applies a class to the html tag at the start in a form of swup-enabled. The purpose of this class is to be able to restyle elements in case swup fails to run (similar to the common usage of js/no-js classes on the same tag. You can also use this class in your styles as you suggested in point 2.

That makes a lot of sense. I like your way of structuring CSS with the & parent selector. :)
Since swup makes other assumptions about the required format for CSS and I had run into trouble getting that working, I worried that html was there specifically to override other classes, and that removing it could pose unknown problems. I'm glad that it doesn't!

The functionality of the styles is similar to hover for example (describing different styles of the same element in some particular state), which most people probably define as &:hover with preprocessors, so I think it kinda makes sense to use a similar nesting technique. :)
Anyways, thanks for pitching some ideas!


no CHANGELOG entry for 1.6.2

looks like there's a newer version on npm than what's listed in the CHANGELOG

Odd...should have been generated by the release script. Oh well, thanks for the head's up @brandly. Should be fixed now.

thanks for the quick fix and the great package!


V2 : Enable coverage reports

These changes enables coverage reports for packages with test suites.
The coverage reports can be viewed by opening the "coverage_reports.html" file in the project directory.
All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Does your submission pass tests?

@z3dev tried to run this today, but sadly, as I feared , it does not work unless you add nyc as a dependency of all the sub packages (I think it worked for you because you had a version with nyc already installed in there, you will likely have the same issue if you run lerna clean before running the coverage command).
I understand why you wanted to remove the dependency from each individual package, but I fear it is not that trivial (I tried to do this a while back with ava , which is also a similar devdependency) and failed

there is a lerna command to achieve something like that, trying to solve it now
https://github.com/lerna/lerna/blob/master/doc/hoist.md

aha ! Found a solution ! Shall I edit your PR a tiny bit @z3dev  ? it is just a minor change in the main package.json

@z3dev  ?

aha ! Found a solution ! Shall I edit your PR a tiny bit @z3dev ?

@kaosat-dev Please amend.

@kaosat-dev looks good.
I thought you might use hoist. Do you know if lerna.json can be used for hoist as well?

@z3dev , hmm good question, the docs are not clear on the subject at all : does it matter if it is in the command or lerna config ?

Nope. I’m fine. We are both learning a lot. 😃

@kaosat-dev please merge.


BudFox - Advanced Usage question

I'm following the documentation on gekko internals and particularly BudFox.
How can I utilize the usage example? Which file do I edit/create with the following?  ( example from docs quoted below)
Thank you so much in advance.

var config = {
exchange: 'Bitstamp',
currency: 'USD',
asset: 'BTC'
}
new BudFox(config)
.start()
// convert JS objects to JSON string
.pipe(new require('stringify-stream')())
// output to standard out
.pipe(process.stdout);

Out of interest what are you trying to do?

I'm trying to do a custom export of BudFox data and take advantage of the fact that gekko already knows how to communicate with various exchange APIs.  I could then feed the data to another tool.

Ah-ha, I had not realised that was possible. Interesting.

Hey @kbimplis! Great question:
Here is a gist, if you place that in your gekko root it will work: https://gist.github.com/askmike/4ed86723f6b13895eed9e234fdd1425a
You can move it anywhere else if you want but you need to update the pathToGekko var to match.

When you run this code BudFox will connect to an exchange and every time there is a new 1 minute candle pump it over stdout (your terminal / command prompt).

Since I wrote those docs a few bug fixes now require some verbose stuff (everything with a temp.. comment at the end. If you want let me know and I can fix those, might make the code a bit later.

@askmike,  much appreciated. That did the job, thank you!


Swift 4.2 update

Good Day!
When can we expect this library to be updated for Swift 4.2?
I'm running XCOde 10 GM Seed  which uses this latest version of swift.
However, I'm reluctant to locally update the library to mitigate adverse  and unforeseen impacts.

Hi,
I'll try to do this next week. But can't promise anything as well have some other projects to work on.

waiting for this update :)

So the macOS Mojave comes on 24 Sept. And I guess XCode 10 will be available together. We should wait for the final version, in my opinion.

@philips77. Xcode 10 GM was released today (in the US at least). The BETA and seed versions were previously updated.
I'm running it on MacOS 10.13.6. The main thing Mojave introduces as it relates to Xcode is [Dark Mode]. I'm perfectly ok with waiting until 9/24. Thanks!

Yep, I got the update. See you on the other side! ;)

@philips77 any update on Swift 4.2 timeline?

@philips77 We are waiting for this update :)

@mostafaberg ?

Depending on your level of desperation, I found it wasn't that hard to clone and build the iOSDFULibrary.framework with swift 4.2 in XCode 10 as a stopgap until official support is available.  There didn't appear to be any significant code changes required.  But I'm also a bit of a newbie for iOS development, so I may have missed something.

@philips77 @mostafaberg any timeline for official release?

Hi, porting to 4.2 was easy, but the #206 did break some things so we need to fix it before releasing. We are now both busy with some other things... I'll try to look into it tomorrow. Sorry for the delay!

Check out #227

@philips77 what does that mean?

@andreyz- Essentially, it means there are two related issues which the team is diligently working on. They are also busy with other activities. So, we just need to be patient and respect this.

We'll try to release it today as 4.2.

@philips77 thanks for the update.

Version 4.2 with Swift 4.2 is out (Coincidence? I don't think so!).
Closing the issue new. If you have any troubles, feel free to open a new issue and describe it there.


feat: Hide back & next button for elements with only 1 failure

Description of changes
Hide back & next button for elements with only 1 failure
1 failure

2 failures (or more)
Note: this is the same as production/master

Pull request checklist

[x] Addresses an existing issue: Completes #549
[x] Added relevant unit test for your changes. (npm run test)
[x] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
[x] Ran precheckin (npm run precheckin)
[x] (UI changes only) Added screenshots/GIFs to description above
[x] (UI changes only) Verified usability with NVDA/JAWS

The margins/spacing at the bottom of the dialog without the buttons looks a bit odd.
Can we get @cheade's opinion

The margins for the dialog box should be 20px on all sides.


feature/SKED-3980: Update Node from 9.x to 10.x

See JIRA: https://skedify.atlassian.net/browse/SKED-3980

package-lock.json should use the npm registry instead of the team registry.


Provided Pascal evaluation code get very diffferent results with Official Pascal Evaluation Method?

❓ Questions and Help
When I use provided voc evaluation code for evaluating results of Pascal Voc(trained with 07+12trainval and test on 07test), I use your codes will get 82.6 mAP(Faster-RCNN-FPN-ResNet101). However, if I use official evaluation codes provided in https://github.com/rbgirshick/py-faster-rcnn/blob/master/lib/datasets/voc_eval.py, I got different results, not sure whether you can check it and support using official evaluation codes? Thank you so much

Hi,
One thing to verify is that there are two modes for evaluation: using voc2007 metric or using voc2012 metric.
From experience, both metrics give different results, as the 07 metric is much coarser when evaluating.
Can you see if this is the reason for the difference? If not, then I'd be very interested in get the differences removed.

Hi,
Thanks for pointing this out.
I haven't myself implemented those evaluation metrics, it as a contributor that added this feature.
We should definitely find the reason why there is so much discrepancy, those functions where originally taken from py-faster-rcnn, so there shouldn't be much difference.

cc @lufficc who originally sent the PR with the implementation

Hi, I got different results. I train with 07trainval+12trainval and tested on 07 test. I trained with Faster-RCNN-R-50-C4 got 79.6 mAP(voc evaluation), 73.3 mAP(official evaluation) and 43.3 mAP, 72.7<EMAIL_ADDRESS>and 46.6 mAP@0.75(coco evaluation). For Faster-RCNN-R-50-FPN, I got 81.34 mAP(voc evaluation), 74.3 mAP(official evaluation), and 45 mAP, 74.1<EMAIL_ADDRESS>and 48.6 mAP@0.75(coco evaluation). For Faster-RCNN-R-101-FPN, I got 82.56 mAP(voc evaluation), 76.2 mAP(official evaluation), and 47.7 mAP, 75.5<EMAIL_ADDRESS>52.5<EMAIL_ADDRESS>For Faster-RCNN-ResXt-101-FPN, I got 83.19 mAP(voc evaluation), 75.9 mAP(official evaluation), and 48.1 mAP, 75.1<EMAIL_ADDRESS>53.2<EMAIL_ADDRESS>All codes are trained with 8 gpus, each holds two images. lr=0.02 and weight decay is 10k and 14.5k.(decay in 5 epochs and max is ~7 epochs, epochs number is the same as provided config file). I didn't change any codes.

Do you use official code correctly？Could I have a look at your code to evaluate using official code? Then we may find the problem，because I got similar result when using official code.

I will save all the detection results of each class to be in the format of:
image_id + " " + score + " " + xmin + " " + ymin + " " + xmax + " " + ymax + "\n".
Then save all the same class predictions in the same txt file as 'ClassName'_test.txt. Then simply use official voc_eval.py to read all these files to get the official evaluation results.
I am not sure whether you can send your evaluation code to me, I can test it with your implementation methods and provide the new testing results on all of my experiments.
In current voc evaluation methods, Faster-RCNN-ResNet50's mAP reached 0.7947, which is much higher than any publication results. The highest results for Faster-RCNN-ResNet101 in published work is 79.8, ResNet50 should reach about 76~77 mAP. So, I don't think 79.47 is reasonable, also, I tested with COCO evaluation methods(using coco format provided in https://github.com/facebookresearch/multipathnet/blob/master/README.md), the<EMAIL_ADDRESS>for coco evaluation methods, i.e, 72.7<EMAIL_ADDRESS>is also very different from the voc evaluation results. I am not sure whether I can have a look at your

Replace this https://github.com/facebookresearch/maskrcnn-benchmark/blob/55d3ab44aa9ff5261afb8244ab5e265266d8436f/maskrcnn_benchmark/data/datasets/evaluation/voc/voc_eval.py#L12 with:
def do_voc_evaluation(dataset, predictions, output_folder, logger):
    class_boxes = {dataset.map_class_id_to_class_name(i + 1): [] for i in range(20)}
    for image_id, prediction in tqdm(enumerate(predictions)):
        img_info = dataset.get_img_info(image_id)
        if len(prediction) == 0:
            continue
        image_width = img_info["width"]
        image_height = img_info["height"]
        prediction = prediction.resize((image_width, image_height))
        pred_bbox = prediction.bbox.numpy()
        pred_label = prediction.get_field("labels").numpy()
        pred_score = prediction.get_field("scores").numpy()

        for i, class_id in enumerate(pred_label):
            image_name = dataset.get_origin_id(image_id)
            box = pred_bbox[i]
            score = pred_score[i]
            class_name = dataset.map_class_id_to_class_name(class_id)
            class_boxes[class_name].append((image_name, box[0], box[1], box[2], box[3], score))
    aps = []
    tmp = os.path.join(output_folder, 'tmp')
    if not os.path.exists(tmp):
        os.makedirs(tmp)
    for key in dataset.CLASSES[1:]:
        filename = os.path.join(output_folder, '{}.txt'.format(key))
        if os.path.exists(filename):
            os.remove(filename)
        with open(filename, 'wt') as txt:
            boxes = class_boxes[key]
            for k in range(len(boxes)):
                box = boxes[k]
                txt.write('{:s} {:.3f} {:.1f} {:.1f} {:.1f} {:.1f}\n'.format(box[0], box[-1], box[1], box[2], box[3], box[4]))
        devkit_path = '/data7/lufficc/voc/VOCdevkit/VOC2007'
        annopath = os.path.join(devkit_path, 'Annotations', '{:s}.xml')
        imagesetfile = os.path.join(devkit_path, 'ImageSets', 'Main', 'test.txt')
        rec, prec, ap = voc_eval(filename, annopath, imagesetfile, key, tmp, ovthresh=0.5, use_07_metric=True)
        aps += [ap]
        print(('AP for {} = {:.4f}'.format(key, ap)))
    print(('Mean AP = {:.4f}'.format(np.mean(aps))))
    print('~~~~~~~~')
    print('Results:')
    for ap in aps:
        print(('{:.3f}'.format(ap)))
    print(('{:.3f}'.format(np.mean(aps))))
    print('~~~~~~~~')
    print('')
    print('--------------------------------------------------------------')
    print('Results computed with the **unofficial** Python eval code.')
    print('Results should be very close to the official MATLAB eval code.')
    print('Recompute with `./tools/reval.py --matlab ...` for your paper.')
    print('-- Thanks, The Management')
    print('--------------------------------------------------------------')

Thanks, I will test it now.

Hi, I compared official evaluation methods and your methods with two different datasets Pascal VOC0712 and KITTI, I will use voc style format for training and testing both of them. For pascal voc0712, the difference between your method and official evaluation method is in the range of 0.3~0.5 mAP. For KITTI, the difference between official evaluation method and your method will be over 10~20 mAP. In fact, originally, I thought maybe the evaluation method is different from the official one is because I got very different results on KITTI Official Benchmark even though I got almost same mAP with your voc evaluation methods as my previous results got from other implementation pytorch-faster-rcnn. I double checked your method and your provided official evaluation codes, I didn't find the reason, but the gap exists, which are smaller for Pascal and larger for KITTI. Following is my testing results using your original evaluation code and your official evaluation code:
Original:
2018-12-11 15:05:36,741 maskrcnn_benchmark.inference INFO: mAP: 0.5585
pedestrian      : 0.5833
cyclist         : 0.4626
car             : 0.8606
dontcare        : 0.3273
Official:
AP for pedestrian = 0.3188
AP for cyclist = 0.2444
AP for car = 0.4326
AP for dontcare = 0.1824
Mean AP = 0.2945
The official evaluation results matched the results I got in KITTI Official Benchmark.
I didn't find the reason, but I think maybe we should stick with official evaluation methods as what you provided in previous answers. Anyhow, thank you so much for supplying these codes and kind reply, It really helped me a lot.

One question @xuw080 : are you using python 2?
It might be a matter of integer / float division differences between different python versions?

I am using python3.7.

@lufficc were you using python 2 when evaluating the code?
Also, could you try once more to see if you manage to reproduce the same results as before, or if you get results similar to @xuw080 ?
Thanks!

I am using python3.6. I tried again and got very close result. And I use the same code in my another project which got very close result compare to the official code. I cannot fingure out why @xuw080 got so big difference on KITTI dataset.

Maybe the two lines below cause the huge difference? Because if no object detected, will not do evaluating.
https://github.com/facebookresearch/maskrcnn-benchmark/blob/55d3ab44aa9ff5261afb8244ab5e265266d8436f/maskrcnn_benchmark/data/datasets/evaluation/voc/voc_eval.py#L19-L20
@fmassa @xuw080

That might be the reason? I'd need to compare against the original implementation, but good spot!
Could you see if removing it bring the results closer?

Now I am sure is the two line cause this.
After I change it to :
if len(prediction) == 0 or image_id % 2 == 0:
    continue

The official code got 0.3840, ours got 0.7252. Without change to this, still close.
So If It didn't detect any object on many images, Official code got low mAP, ours still got higher because not take in account them, this why @xuw080 got higher mAP on KITTI.
@fmassa

We should remove the if len(prediction) == 0 skipping, this is probably not right...

Yee, We should remove the if len(prediction) == 0 skipping.

does this break the rest of the evaluation pipeline?

No, it doesn't.

Now the evaluation pipeline is right?

@dby2017 should hae been fixed in https://github.com/facebookresearch/maskrcnn-benchmark/pull/648


Issue 1159 - Bug: Exception "A transaction is already in progress; nested/concurrent transactions aren't supported." when using explicit transaction with PostgreSQL bulk operations #1159

PR for fixing bug of throwing exception when using explicit transaction for bulk operations https://github.com/mikependon/RepoDB/issues/1159

Thanks for this PR. 👍


[GoPlay] Unable to download JSON metadata: HTTP Error 403: Forbidden

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2023.01.06 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[x] I've read about sharing account credentials and I'm willing to share it if required

Region
Belgium/EU
Provide a description that is worded well enough to be understood
Unable to download JSON metadata: Error 403 forbidden.
Found an issue that might be related (6016) I am not knowledgable enough to confirm if same problem or not
using Debian on WSL2, Windows 10, same problem on Fedora 37
$ ~/yt-dlp -u <username> -p <passwd> https://www.goplay.be/video/de-verhulstjes/de-verhulstjes-s4/de-verhulstjes-s4-aflevering-1#autoplay
[GoPlay] Logging in
[GoPlay] Authenticating username
[GoPlay] Authenticating password
[GoPlay] Extracting URL: https://www.goplay.be/video/de-verhulstjes/de-verhulstjes-s4/de-verhulstjes-s4-aflevering-1#autoplay
[GoPlay] de-verhulstjes-s4-aflevering-1: Downloading webpage
[GoPlay] 7fdf2a78-5dfd-4e84-bdad-676fa6496da8: Downloading JSON metadata
ERROR: [GoPlay] None: Unable to download JSON metadata: HTTP Error 403: Forbidden (caused by <HTTPError 403: 'Forbidden'>); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
$ ~/yt-dlp -U
Latest version: 2023.01.06, Current version: 2023.01.06
yt-dlp is up to date (2023.01.06)

Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', '-u', 'PRIVATE', '-p', 'PRIVATE', 'https://www.goplay.be/video/de-verhulstjes/de-verhulstjes-s4/de-verhulstjes-s4-aflevering-1#autoplay']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2023.01.06 [6becd25] (zip)
[debug] Python 3.9.2 (CPython x86_64 64bit) - Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.31 (OpenSSL 1.1.1n  15 Mar 2022, glibc 2.31)
[debug] exe versions: ffmpeg 4.3.5-0, ffprobe 4.3.5-0, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.9.7, brotli-1.0.9, certifi-2020.06.20, mutagen-1.45.1, pyxattr-0.7.2, sqlite3-2.6.0, websockets-8.1
[debug] Proxy map: {}
[debug] Loaded 1760 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2023.01.06, Current version: 2023.01.06
yt-dlp is up to date (2023.01.06)
[GoPlay] Logging in
[GoPlay] Authenticating username
[GoPlay] Authenticating password
[GoPlay] Extracting URL: https://www.goplay.be/video/de-verhulstjes/de-verhulstjes-s4/de-verhulstjes-s4-aflevering-1#autoplay
[GoPlay] de-verhulstjes-s4-aflevering-1: Downloading webpage
[GoPlay] 7fdf2a78-5dfd-4e84-bdad-676fa6496da8: Downloading JSON metadata
ERROR: [GoPlay] None: Unable to download JSON metadata: HTTP Error 403: Forbidden (caused by <HTTPError 403: 'Forbidden'>); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "/home/emversch/yt-dlp/yt_dlp/extractor/common.py", line 680, in extract
    ie_result = self._real_extract(url)
  File "/home/emversch/yt-dlp/yt_dlp/extractor/goplay.py", line 78, in _real_extract
    api = self._download_json(
  File "/home/emversch/yt-dlp/yt_dlp/extractor/common.py", line 1034, in download_content
    res = getattr(self, download_handle.__name__)(url_or_request, video_id, **kwargs)
  File "/home/emversch/yt-dlp/yt_dlp/extractor/common.py", line 998, in download_handle
    res = self._download_webpage_handle(
  File "/home/emversch/yt-dlp/yt_dlp/extractor/common.py", line 868, in _download_webpage_handle
    urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal, data=data, headers=headers, query=query, expected_status=expected_status)
  File "/home/emversch/yt-dlp/yt_dlp/extractor/common.py", line 825, in _request_webpage
    raise ExtractorError(errmsg, cause=err)

  File "/home/emversch/yt-dlp/yt_dlp/extractor/common.py", line 807, in _request_webpage
    return self._downloader.urlopen(self._create_request(url_or_request, data, headers, query))
  File "/home/emversch/yt-dlp/yt_dlp/YoutubeDL.py", line 3730, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python3.9/urllib/request.py", line 523, in open
    response = meth(req, response)
  File "/usr/lib/python3.9/urllib/request.py", line 632, in http_response
    response = self.parent.error(
  File "/usr/lib/python3.9/urllib/request.py", line 561, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.9/urllib/request.py", line 494, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.9/urllib/request.py", line 641, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: Forbidden

Changed account checkbox: I am willing to provide my account

https://github.com/add-ons/plugin.video.viervijfzes/pull/114 might help us get this fixed here as well.

I've implemented a fix in https://github.com/yt-dlp/yt-dlp/pull/6151.


Indexeddb Delete from is not working

Hi Team,
        Indexed dB Delete from not working

@SathishRamV Thank you for letting us know. Any chance you have an example that is not working?

TypeError: alasql.engines[db.engineid].loadTableData is not a function
at statement (alasql.js:15032)
at Function.alasql.dexec (alasql.js:4654)
at Function.alasql.exec (alasql.js:4607)
at alasql (alasql.js:138)
at alasql.js:5232
at new Promise ()
at promiseExec (alasql.js:5231)
at Function.alasql.promise (alasql.js:5280)
at WebdevComponent_SAT.js:388
function clearIDBData1(IDDBName) {
var Database = IDDBName;
console.log(Database);
var Query = 'DELETE FROM ' + Database;
alasql.promise('CREATE INDEXEDDB DATABASE IF NOT EXISTS ' + Database + ' ;')
    .then(function () { return alasql.promise('ATTACH INDEXEDDB DATABASE ' + Database + ' ;'); })
    .then(function () { return alasql.promise('USE ' + Database + ' ;'); })
    .then(function () { return alasql.promise(Query, []); })
    .then(function (res) {
        var a = res;
        //var SqlStr1 = 'SELECT ' + HTAlsqlCol + ' FROM ?'
        //var DataForGraph = alasql(SqlStr1, [a]);
        //hot3.loadData((DataForGraph));
    })
    .catch(function (r) {
        console.log(r);
    })

}

@mathiasrw
function clearIDBData1(IDDBName) {
var Database = IDDBName;
console.log(Database);
var Query = 'DELETE FROM ' + Database;
alasql.promise('CREATE INDEXEDDB DATABASE IF NOT EXISTS ' + Database + ' ;')
.then(function () { return alasql.promise('ATTACH INDEXEDDB DATABASE ' + Database + ' ;'); })
.then(function () { return alasql.promise('USE ' + Database + ' ;'); })
.then(function () { return alasql.promise(Query, []); })
.then(function (res) {
var a = res;
//var SqlStr1 = 'SELECT ' + HTAlsqlCol + ' FROM ?'
//var DataForGraph = alasql(SqlStr1, [a]);
//hot3.loadData((DataForGraph));
})
.catch(function (r) {
console.log(r);
})
}

Looks like we enforce where 1 from https://www.w3schools.com/sql/sql_delete.asp

i have to use Where Condition for Delete FROM? @mathiasrw

I have a feeling that will work - yes. I have not verified... But its still a bug that you found it...

Any update on this @mathiasrw

Hello Guys Any update ? @mathiasrw

@SathishRamV We have not yet received any PR fixing this.

Hi Guys, I would like to help in this regards. I am still new to contributing to open source projects, but I want to help. Is there any way I can contribute to this repo ?

Lovely. Have a look at https://github.com/agershun/alasql/blob/develop/.github/CONTRIBUTING.md and let me know if you have any questions :)

Thanks, Will Do.


feat: update to eye v3.1.0

feat: update to eye v3.1.0

:tada: This PR is included in version 4.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v4.1.0

Your semantic-release bot :package::rocket:


Upgrading to latest Chat SDK

GMDX-138-upgrading and updating imports to the newer chat SDK, JFrog published artifacts.
removal of conditional dependencies, and apps need to include kotlin plugin.
updating README file according to those changes.

@bjdupuis  { changing = true } Whether or not Gradle should always check for a change in the remote repository
It's not redownloading if nothing was changed.

Excellent, that makes sense. Thanks for talking through!


Website: Wrong spelling of 'Visualization'

The website reads: An Open Source JavaScript Visualiztion Library
It should be: An Open Source JavaScript Visualization Library
This is not adequate for this really impressive product.
See: https://echarts.apache.org/en/index.html

I hope a human is reading this.

I hope a human is reading this.

@stolp Thank you for your feedback. This typo has been fixed in apache/echarts-www#22. But the website doesn't get updated     yet. @pissang Would you mind helping make an update for the website? Besides this, I've corrected some other issues, including echarts-www and echarts-doc.

@stolp Thank you for your feedback. This typo has been fixed in apache/echarts-www#22. But the website doesn't get updated     yet. @pissang Would you mind helping make an update for the website? Besides this, I've corrected some other issues, including echarts-www and echarts-doc.

@plainheart Sure

@plainheart Sure

Updated. Thanks for the feedback.

Updated. Thanks for the feedback.


Fix clear prompt (DONT MERGE YET)

Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

.../seedu/address/logic/parser/AddressBookParser.java
0.00%
1 Missing and 2 partials :warning:

Files with missing lines
Coverage Δ
Complexity Δ

...ava/seedu/address/logic/commands/ClearCommand.java
100.00% <ø> (ø)
12.00 <0.00> (ø)

...ogic/commands/eventcommands/ClearEventCommand.java
100.00% <ø> (ø)
7.00 <0.00> (ø)

...ic/commands/personcommands/ClearPersonCommand.java
100.00% <ø> (ø)
7.00 <0.00> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
95.45% <0.00%> (-4.55%)
52.00 <0.00> (-2.00)


Support for ES Modules

Aligning the module import style with the lib capabilities used in the project to allow the use of ES Modules with this library.
I have run a test build and the provided unit tests in order to prevent breakage. If there are any relevant additional tests to be run, please let me know or run them as you see fit.

https://github.com/tada5hi/typeorm-extension/pull/389


AYON Save option under vanilla Save in File Menu

Is there an existing issue for this?

[X] I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?
Add "AYON Save" option under native/vanilla save options in File menu to create shortcut for saving workfile in AYON specific way.
How would you imagine the implementation of the feature?
.
Are there any labels you wish to add?

[X] I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:
No response
Additional context:
No response

For information,
This issue is easy to implement (about 2 lines of code that add a button called AYON Save As... that opens workfile tool).
But, there were many internal discussions that discouraged doing so.
Mentioning @BigRoy @antirotor @dee-ynput @m-u-r-p-h-y they can provide further insights.
For reference here's how the button would look like:

Why do we need it? We are using the Workfiles feature in the AYON tab which is working flawlessly!

Why do we need it? We are using the Workfiles feature in the AYON tab which is working flawlessly!

I only ported it to GH issues, but I don't know about the motivation/need behind the request.

It was requested to save a lot of unnecessary clicks to create a new workfile version

click AYON Menu
click Work Files
click Save as
click Ok

to save your work as new workfile. Artists are not very comfortable with it and I have to agree . . .


Cell text should not be a window item

Broken resize preview lines

This is happening because the cell text for each cell is a label in a window. Windows are drawn above everything on a canvas.
Cell text should be changed to use a text canvas item so that it works like other canvas items. A the same time, text items should only be created for cells that have text in them. This might speed things up some (both using less items and not using full label widgets).
Label widgets and windows were used originally to allow the label to easily be cut off to a specific square. A new way will need to be worked out... possibly just reducing the number of characters in each text item based on size.
Originally posted by @pladams9 in https://github.com/pladams9/hexsheets/pull/42#issuecomment-640319122

Current thought on correcting this: use Pillow to create an image for each cell's text, and display that as an image item on the canvas.
See: https://pillow.readthedocs.io/en/stable/index.html

Another question to be answered: how should cut off text be displayed?

With an ellipsis (...),
With an obscuring mark (Excel uses #####),
With a simple square cut that could land mid-letter, or
With a hexagonal cut, allowing the text to flow to the very edge of the cell?


Make samplesheet

While creating this PR, I figured it's not that easy after all to use patterns instead of an extension (it breaks the sample name sanitation).
However, I cleaned up a bit and fixed another potential issue when merging replicates:
Globs do not yield sorted results, so it could have happened that e.g. R1 from replicate 1 is matched with R2 from replicate 2 in the samplesheet.

PR checklist

[x] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!

[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.

[ ] Make sure your code lints (nf-core lint .).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

Tested locally and works like a charm