using clipstart removes the poster image

Using web components.
i found that when playing a Youtube video, if we use clipstart the poster image won't show. This is because the video seem to be actually played and then paused to get to the clip time. but this means the video has then been played (the data-started attribute is added to the player) and therefore the data-visible is never added to the poster component.
ideally we'd be able to use clipstart and poster images together.

Repro.. https://codepen.io/wplit/pen/PorbYjJ
Notice that when the clipstart prop is used, we lose the poster image as it's now hidden at the start.


Stuck

"Create the Pipeline" fails with the following error:
Set-AzureRmDataFactoryV2Pipeline : HTTP Status Code: BadRequest
Error Code: BadRequest
Error Message: The document creation or update failed because there were duplicate properties in the json payload.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f66fe032-5362-4b8e-2155-9c7237f2e2cc
Version Independent ID: 7e4c70fe-7f75-5e57-1f70-cafef3bc0a28
Content: Incrementally copy multiple tables by using Azure Data Factory
Content Source: articles/data-factory/tutorial-incremental-copy-multiple-tables-powershell.md
Service: data-factory
GitHub Login: @linda33wj
Microsoft Alias: jingwang

The issue is in the IncrementalCopyPipeline.json file, line 57 and 58.  But I don't know how to resolve it.
                            "SqlWriterTableType": "@{item().TableType}",
                            "SqlWriterStoredProcedureName": "@{item().StoredProcedureNameForMergeOperation}"

If these are removed, the error goes away - but these are critical functionality.  As soon as EITHER of these lines is re-added, it reports the "duplicate properties" error given previously.

@JimFoster
Thanks for the feedback! We are currently investigating and will update you shortly.

@dearandyxu please double confirm the tutorial

@djpmsft for awareness

any update on this failure?

#please-close

Anyone stumbling across this 'The document creation or update failed because there were duplicate properties in the json payload' error in the future via Google, what I found useful was to head to the associated Resource Group in Azure Portal, and in the main pane of the Overview page for the Resource Group there will be a Deployments field showing on the right.
Hopefully you can click on a '# Failed, # Succeeded' link there to show a list of deployments happening on the Resource Group, clicking on the Deployment name of the failed jobs listed there breaks it down to all the ADF components in the deployment and helped me pinpoint a specific pipeline in ADF that had an invalid reference in it. Easy when you know where to look.


Does this quickstart work on a mac?

I have .net core on my mac and VS for Mac 17.6. However, when I try to install the necessary NuGet package, I can't find it.

I  was able to manually install the nuget package using the statement below that allowed me to compile and run the program.
dotnet add package  Azure.AI.Vision.ImageAnalysis --prerelease
However, when I  compile and run the program it throws this error:
System.TypeInitializationException: The type initializer for 'native' threw an exception.
---> System.TypeInitializationException: The type initializer for 'Azure.AI.Vision.Common.Diagnostics.Logging.VisionEventSource' threw an exception.
---> System.DllNotFoundException: Unable to load shared library 'Azure-AI-Vision-Native' or one of its dependencies. In order to help diagnose loading problems, consider setting the DYLD_PRINT_LIBRARIES environment variable: dlopen(libAzure-AI-Vision-Native, 0x0001): tried: 'libAzure-AI-Vision-Native' (no such file), '/System/Volumes/Preboot/Cryptexes/OSlibAzure-AI-Vision-Native' (no such file), '/usr/lib/libAzure-AI-Vision-Native' (no such file, not in dyld cache), 'libAzure-AI-Vision-Native' (no such file), '/usr/local/lib/libAzure-AI-Vision-Native' (no such file), '/usr/lib/libAzure-AI-Vision-Native' (no such file, not in dyld cache)

Is  this supposed to work on a mac with .net core? Are there some prerequisites I am missing?

---
#### Document Details

⚠ *Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.*

* ID: 3370ee1e-7205-b5b2-add1-77fec0ce4366
* Version Independent ID: a6d25469-a52e-2233-5a15-cfbb6ed2a3c6
* Content: [Quickstart: Image Analysis 4.0 - Azure AI services](https://learn.microsoft.com/en-us/azure/ai-services/computer-vision/quickstarts-sdk/image-analysis-client-library-40?tabs=visual-studio%2Cwindows)
* Content Source: [articles/ai-services/computer-vision/quickstarts-sdk/image-analysis-client-library-40.md](https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/ai-services/computer-vision/quickstarts-sdk/image-analysis-client-library-40.md)
* Service: **cognitive-services**
* Sub-service: **computer-vision**
* GitHub Login: @PatrickFarley
* Microsoft Alias: **pafarley**

@shermes
Thanks for your feedback! We will investigate and update as appropriate.

@shermes
Thanks for your updates. I've assigned this issue to the author and PG team who will investigate and update as appropriate.

@PatrickFarley
could you please review this and update as appropriate.

Hi @shermes, this is Darren from the Azure AI Vision SDK team. The SDK is not yet supported on MacOS. Only Windows and Linux x64 platforms are supported at the moment. We are working to add more platforms.

#please-close

Hi, do we use the older SDK for computer-vision services to use on macOS?

@steveoshima You can certainly use the older SDK (the one that uses REST 3.2 APIs) if that meets your needs. However if you need access to improved models that come with REST 4.0 APIs, and you are running on MacOS, we do not yet have an SDK for you. You will have to call the REST 4.0 APIs directly from your source code.

@dargilco Is there any update on when the MacOS support is coming?

@JurgenPostelmans I do not have an ETA. Please write code to call the REST APIs directly.


Migrate UI in from Mockup to Play Scala Templates.

Now that we have the Play based framework setup, we need to start migrating the mockup layout into the actual application.  I'll start some work on that tonight.

For the next push on this, need to fix references to .html files in links throughout the site.

This is pretty much resolved; at this point it's creating new content that isn't already up.  Closing.


Sweep: different seed in every run for bayesian search of hyperparams [Q]

In my code, I run each experiment with a random seed generated from random.choice(range(n)). Does having different seed for each run affect the hyperparameter search using bayesian searching technique? Should I be using the same seed across all the runs created by the sweep?

Using a different seed will be fine for Bayesian search.
I would recommend logging the seed so that your runs are reproducible.


Collapsed children are not expanded when changing date

Before changing date:

After going back:

Attribute seems to be not saved with date and then updated incorrectly

I don't understand this issue.
It seems that the child features are not there at the date of the second screenshot.
How could they be expanded?

In t1 there are the collapsed 4 features (which are already existent in t0) when going back to t0, they are also collapsed but the decorator is not drawn, so someone might think the features do not exist.

Indeed, this is strange.
@gilengel please have a look at this. Also happens with fixed attached models - not urgent
NavigationSystem.zip


Expose Vulkan dynamic rendering

Exposes two new properties for the Vulkan implementation:

useDynamicRendering - for use in more modern dynamic rendering pipelines
colorAttachmentFormat - required to enable dynamic rendering

Relevant Vulkan docs:

https://github.com/KhronosGroup/Vulkan-Docs/blob/main/proposals/VK_KHR_dynamic_rendering.adoc

There may be more considerations here, but this seems to work as-is so far as I can tell.

I don't know enough about the pipeline to understand why the Cachix job failed. Any guidance? Happy to address if I can

@jtnuttall It seems like the CI is being fixed in #201


Data completeness - Beacon during GPS/EMA/Fitbit nights

Data completeness for "complete" nights
The final piece of data completeness is looking at the amount of data collected during nights when participants are home, wearing their Fitbits, and complete a survey the following morning.

Currently looking into this. The data is there, just need to parse out the data availability.


Add pyBuildingEnergy

Insert URLs to the project here:
https://github.com/EURAC-EEBgroup/pyBuildingEnergy

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as 'Good First Issue' of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.

@DanieleAntonucci20


Add an example of mrenclave upgrades

Needs a policy for which mrenclaves are approved. Right now the creator of the Andromeda contract unilaterally can add add mrenclaves to a list. Here are some minimum features to make this upgradable.
Governance:

[ ] There should be a multisig policy for approving updates

Due notice:

[ ] Upgrades to the mrenclave should go in a pending pool where they can be reviewed before it is applied

:eyes:


Support for php-cs-fixer 2

Are there any plans for supporting the new major release?
Using this config produces some warnings
# .styleci.yml
preset: symfony

enabled:
  - binary_operator_spaces
  - combine_consecutive_unsets
  - long_array_syntax
  - linebreak_after_opening_tag
  - no_php4_constructor
  - no_useless_else
  - ordered_class_elements
  - ordered_imports
  - php_unit_construct
  - php_unit_strict

finder:
  exclude:
    - 'Tests/Fixtures'

Fixer "align_double_arrow" does not exist, skipping.
Fixer "align_equals" does not exist, skipping.
Fixer "long_array_syntax" does not exist, skipping.
Fixer "unalign_double_arrow" does not exist, skipping.
Fixer "unalign_equals" does not exist, skipping.
Fixer "concat_without_spaces" does not exist, skipping.
Fixer "no_spaces_inside_offset" does not exist, skipping.
Fixer "no_tab_indentation" does not exist, skipping.
Fixer "phpdoc_type_to_var" does not exist, skipping.
Fixer "print_to_echo" does not exist, skipping.
Fixer "unix_line_endings" does not exist, skipping.

Are you planing to wrap the old name to the new syntax?

TBH, upgrading this package to the new styleci rules and php-cs-fixer will be hard, because there are 26 virtual fixers that don't exist in php-cs-fixer, and the mappings are closed source for now.

I'm toying with the idea of exposing a config file styleci to php-cs-fixer converter on the API.

Ok, I've done that then, similar to the "validate" endpoint, just pass the config file as the "config" parameter. For example: https://api.styleci.io/rules?config=preset: psr2. Unlike the validate endpoint, empty config is supported. The design decision with not permitting this on the other endpoint was because it was targeted at validation, so we wanted to be sure people weren't accidently passing nothing. On this endpoint, nothing is treated like the empty config file, you get all the rules generated from the recommended preset with risky enabled.

Just added a wrapper list for version 2: https://github.com/Soullivaneuh/styleci-fixers/pull/14
This list must be implemented after merging.

@core23 styleci-fixers package was updated according to the StyleCI API data.
Anything better?

Just tried the latest master versions and the error(s) still occur
Btw: There was an other update some days ago: https://styleci.readme.io/docs/change-log

What is the status on this issue? @core23 have you given up?

Not working on this anymore, sorry

Replaced by https://github.com/StyleCI/CLI.


Allow complete deactivion of repo deployment

For certain customer "offline" installations it would be helpful to deactive any creation of confluent repository files, since everything is already mirrored towards a Satellite or orcharhino.
I propose a "no_repository" flag in hosts.yml that can be included in the common tasks for each OS

@Fobhep Thanks for the suggestion.  Can you clarify further?  Do you mean that the packages are already present on the OS? I ask because typically a satellite will still involve pulling the packages from the satellite and installing them locally which we can do already via the custom repo functionality.  So I am not completely clear on the use case described here.

of course - let me try to explain better.
So eg at the customer I am currently at (and the previous one as well), all servers are deployed via Satellite and corresponding hostgroups, so they have already all repos and repofiles included they need for confluent platform.
We cannot break this workflow, since different teams are in charge of base provisioning and middleware.
Currently I simply removed the part that deploys repos. I am wondering if allowing that generally would be an useful feature for more people. Of course you could probably also deploy an "empty" custom repo file as well :thinking:
Let me know if I explain it still better

@Fobhep I think this is a great idea. Im thinking we could have a variable like repository_option: none/confluent/custom which defaults to confluent. This is to replace the custom_repo variable. Well have to think on backwards compatibility...
I'm not that satisfied with the variable name haha, if you come up with something better LMK.
Would you like to create the PR? I don't want to jump the gun like last time, but I can do it also.

@domenicbove great :) I can do that probably monday or tuesday - if you are up for it before - go for it :)

@Fobhep I have some bandwidth! I'll work on it today and include you in the PR. Since I'm not considering this a bug, I'm planning to make the PR into 6.0.x branch which is our 6.0.0 dev branch. Hope that's ok

@Fobhep can you review this: https://github.com/confluentinc/cp-ansible/pull/370
For some reason I can't add you as a reviewer on the PR.
Essentially you set repository_configuration: none to get what you are seeking with this issue... Java installation must happen though

Closing, as https://github.com/confluentinc/cp-ansible/pull/370 has been merged. Will be released with 6.0.0!


How can I shut down automatically distributing data when using StreamingDataset?

🚀 Feature

Giving the option to shut down the automatic data distributed sampler when using StreamingDataset.
Motivation

When I use StreamingDataset in 'DDP' environment, the dataset_len of StreamingDataset seems always be original_len/world_size.
But I want the different processes (with different local_ranks) to share the totally same StreamingDataset, without any data splitting.
Pitch

How to stop the automatic data distribution when using StreamingDataset in DDP? Or could you provide a setting to this? Or could you explain why we can't shut down the distribution?
Alternatives

Additional context

Hey @ygtxr1997. You can override the distributed env on the dataset. It is inferred automatically from torch.
What is your use case ?

Hey @ygtxr1997. You can override the distributed env on the dataset. It is inferred automatically from torch.
What is your use case ?

I think overriding the litdata class should be a method to solve my above issue.
Initially, I want to use litdata to optimize my dataset which consists of ~500k small files (each is about 200KB file size). All these files are stored in a remote storage server. However, which is a bit different from other image datasets, my dataloader needs to read from two distinct files, and the indices between the two file vary in [20,50], like a sliding window. For instance, the file indices in a data batch (batch_size=4) could be like this:
batch: [100,120], [1000,1030], [1020,1070], [500,550]

According to your example of usage and distributed data loading illustration GIF, litdata seems not good at dealing with such random-read-like case, am I right? Maybe the performance depends on how the original files are merged into a litdata chunk. Maybe keeping the order of original files (from small index to large index) could result in a faster loading speed, but this potentially impact the learning of deep models?
Therefore, I don't know if litdata could help me and boost the data loading speed in my case.


[2.6] Add initial loading indicator

For 2.6, the Dashboard UI will be the default login experience.
This PR adds a simple loading indicator for the Dashboard app that the user will see ahead of the app being loaded. Currently the user only sees an empty page.

Closing - already merged from another PR


Rawkit 0.6.0 does not support libraw 0.19.x

The documentation page for rawkit says that it supports libraw 0.19.x, but it will fail to run with such a version of libraw installed. The code at libraw/bindings.py:42 basically specifies the supported versions of libraw. At the 0.6.0 tag (the latest release), it is the following:
        try:
            structs = {
                16: structs_16,
                17: structs_17,
                18: structs_18,
            }[self.version_number[1]]
        except KeyError:
            raise ImportError(
                'Unsupported Libraw version: %s.%s.%s.' % self.version_number
            )

If libraw 0.19.0 is installed, a KeyError will be raised here. However, the very latest code on master adds 19: structs_19  to that dictionary, effectively supporting libraw 0.19.x.
When can a version of rawkit be released that supports libraw 0.19.x? And in the meantime, can the documentation be changed so as not to mislead users?

The documentation page for rawkit says that it supports libraw 0.19.x, but it will fail to run with such a version of libraw installed

@c-anna can you provide the links to the docs you're reading? I suspect you're reading the docs for the latest master version (which has support for libraw 0.19.1+, but is slightly broken and thus hasn't been released) and not 0.6.0.
These are the docs for 0.6.0: https://rawkit.readthedocs.io/en/v0.6.0/ (which are actually missing 18)

When can a version of rawkit be released that supports libraw 0.19.x?

And in the meantime, can the documentation be changed so as not to mislead users?

The documentation is not broken, but it would make sense to set v0.6.0 (or whatever the latest actual release is) to the default. Unfortunately, Read The Docs doesn't appear to allow that (or if it does, I couldn't find a setting for it without changing the default source control branch, which isn't really the same thing and it makes sense for that to be master, even if the release version is older).

Yes, I was reading the docs at https://rawkit.readthedocs.io/ (no version specified), which as you say was probably for the latest master version. I was just confused because I assumed that the docs I was viewing were tied to the "latest" release, which wasn't true then (but seems to be true now). Thank you!


App crashes at processPendingRequests() from didReceive()

Thread 126: "-[__NSTaggedDate count]: unrecognized selector sent to instance 0x8000000000000000"
Please help @neekeetab

Resolved the issue by cancelAndInvalidate the playeritem session

@neekeetab
Now I am cancelling download an ongoing session by playerItem?.resourceLoaderDelegate.session?.invalidateAndCancel(). Made resourceLoaderDelegate.session public.
Will this cause the crash? Actually crash happens very rarely. To reduce crash rate In processPendingRequests() I have added a main async now

@neekeetab Now I am cancelling download an ongoing session by playerItem?.resourceLoaderDelegate.session?.invalidateAndCancel(). Made resourceLoaderDelegate.session public.
Will this cause the crash? Actually crash happens very rarely. To reduce crash rate In processPendingRequests() I have added a main async now

Can you please show how?


problem to push images in registry v2

Hi,
I'm trying to migrate my images from a v1 registry to a v2 registry. To do so, I use a reverse proxy to add SSL but I'm not using authentication.
I've got no problem to pull images from registry v1 but when I push I've got this error :
[OK] Verified v2 registry (registry.si3si.com) is available
[!!] Please login to registry.si3si.com:
Username:
FATA[0001] Error response from daemon: no successful auth challenge for https://registry.si3si.com/v2/ - errors: []

I also tried to add NO_LOGIN=true env variable but in this case I've got another error :
cat: /root/.dockercfg: No such file or directory

[ERROR] Non-zero exit code
[ERROR] Migration from v1 to v2 failed!

I've got no other idea of what I can tried
If you need any other information, do not hesitate
Gilles DEHAUDT

I think I see the issue.  It is still trying to decode user credentials even if NO_LOGIN is set to true.  PR incoming to fix.

Please test when you are able and let me know if this solves the problem for you.

I've just tested it and it works fine
Thanks for your quick reaction


npm audit scan: make dedupe work with hashes in paths

fixes #4306
Whenever a dependency is installed via git, npm audit obscures the name and replaces it with a hash in the path attribute. This hash is different for every run, consufing the dedupe algo in defect dojo:
run x:
      "findings": [
        {
          "version": "1.3.4",
          "paths": [
            "c748e76b6a1b63450590f72e14f9b53ad357bc64632ff0bda73d00799c4a0a91>send>mime",
            "express>serve-static>send>mime"
          ],
          "dev": false,
          "optional": false,
          "bundled": false
        }
      ],

run x +1:
      "findings": [
        {
          "version": "1.3.4",
          "paths": [
            "7f888b06cc55dd893be344958d300da5ca1d84eebd0928d8bcb138b4029eff9f>send>mime",
            "express>serve-static>send>mime"
          ],
          "dev": false,
          "optional": false,
          "bundled": false
        }
      ],

We could remove the file_path from the dedupe settings, but that may lead to confusion as well. So I decided to replace all these hashes with a static value to that it's always the same: censored_by_npm_audit>send>mime.
updated unit tests

@valentijnscholten your PR is excellent but considering how this parser manage the file_path attribute give me the filling that we should modify the de-duplication configuration for this one to rely on something else.

Yeah, I was thinking the same. But still might be good to have a predictable/constant file path between runs.

Although we may decide to remove filepath from the hashcode fields, some people might still want to use it that way, so I am proceeding with merging this PR.


value of the output temperature is 0.005078125. In the paper, I see it is 1.3. Why is this?

          Hi @orrzohar During the reasoning process, when I execute class PostProcess, the value of the output temperature is 0.005078125. In the paper, I see it is 1.3. Why is this?

Originally posted by @YH-2023 in https://github.com/orrzohar/PROB/issues/43#issuecomment-1712822568

Hi,
The reason is that I devide the temperature by the hidden_dim:
https://github.com/orrzohar/PROB/blob/10b6518f90495e07b7baf0d1bfa353f0e583eb8e/models/prob_deformable_detr.py#L639
I do this so the objectness prediction won't be as dependent on the hidden_dim of the transformer model. As hidden_dim=256,
1.3/256 = 0.005078125
Best,
Orr


API functions not working in Flashfallback

i'm trying to create buttons to control the video player to make it more accessible.
When the Browser supports HTML5, everything works great, but in Flash the functions are not working.
Code example, working on your demo:
var myVideo=document.getElementById("player2");
function playPause()
{
myVideo.play();
}

@Starkmann Is this still an issue?

@Starkmann Closing old issues. If you'd like to reopen this, let us know. Thanks!


no such package available : accept-language-parser

Hi, I'm having an issue on exercise: Exercise 5.1: Modules and Express.  The moment i start running the core_js module, i get the error below. which is mainly about accept-language-parser, in which by right it should be able to see in the central repository.  Is this an issue on xsa runtime or something else?  I'm on hana2_sps2.  Thanks!
[INFO] Injecting source code into builder...
[INFO] Source code injection finished
[INFO] ------------------------------------------------------------------------
npm ERR! Linux 3.12.67-60.64.24-default
npm ERR! argv "/hana/shared/H03/xs/app_working/appsrv13/executionroot/cbddfdb3-afc8-4d00-9b53-83bcd25188d3/app/META-INF/resources/nodejs/vendor/node6.11/bin/node" "/hana/shared/H03/xs/app_working/appsrv13/executionroot/cbddfdb3-afc8-4d00-9b53-83bcd25188d3/app/META-INF/resources/nodejs/vendor/node6.11/lib/node_modules/npm/bin/npm-cli.js" "install" "--registry" "https://hostname.com:51040"
npm ERR! node v6.11.1
npm ERR! npm  v3.10.10
npm ERR! code E404
npm ERR! 404 no such package available : accept-language-parser
npm ERR! 404
npm ERR! 404  'accept-language-parser' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 It was specified as a dependency of 'core-js'
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.
npm ERR! Please include the following file with any support request:
npm ERR!     /hana/shared/H03/xs/app_working/appsrv13/executionroot/cbddfdb3-afc8-4d00-9b53-83bcd25188d3/app/META-INF/.sap_java_buildpack/tomcat/temp/builder/sap.nodejs/builds/build-6176383983240492414/core_js/npm-debug.log

I found answer to my issue, therefore, im sharing it here:
https://answers.sap.com/questions/329766/hana-express-edition-20-building-live5-from-hana-a.html
basically, it is necessary to setup the environment variable UPSTREAM_LINK to be able to access the central repository of npm:
xs set-env di-local-npm-registry UPSTREAM_LINK "http://registry.npmjs.org/"


Vcov

Updates small sample adjustments to use (N-1) / (N-K) for heteroskedastic errors when adj = True, 1 if adj=False, which is in line with the fixest docs.
Reorganizes unit tests to skip non-required tests in test_vs_fixest.py.
Adds dedicated tests for exact equality for vcov matrices in test_vcov.py and also in test_vs_fixest.py.

Note that this is labelled a "breaking change" as inference results will slightly deviate. But for medium N and small k, differences will be negligible.
Example:
%load_ext autoreload
%autoreload 2

import numpy as np
import rpy2.robjects as ro
from rpy2.robjects import pandas2ri
from rpy2.robjects.packages import importr

import pyfixest as pf
from pyfixest.utils.utils import ssc
import pandas as pd

pandas2ri.activate()

fixest = importr("fixest")
stats = importr("stats")

data = pf.get_data(N = 100, model = "Feols")

cluster_adj = False
fml = "Y ~ X1 + X2 | f1"
vcov = "hetero"

py_mod = pf.feols(
    fml, data=data, vcov=vcov, ssc=ssc(adj=adj, cluster_adj=cluster_adj)
)
r_mod = fixest.feols(
    ro.Formula(fml),
    data=data,
    vcov=vcov,
    ssc=fixest.ssc(adj, "none", cluster_adj, "min", "min", False),
)

py_mod_vcov = py_mod._vcov
r_mod_vcov = stats.vcov(r_mod)

py_mod_vcov - r_mod_vcov
# array([[6.93889390e-18, 1.08420217e-19],
#        [3.25260652e-19, 0.00000000e+00]])

adj = False
cluster_adj = False
fml = "Y ~ X1 + X2 | f1"
vcov = "hetero"

py_mod = pf.feols(
    fml, data=data, vcov=vcov, ssc=ssc(adj=adj, cluster_adj=cluster_adj)
)
r_mod = fixest.feols(
    ro.Formula(fml),
    data=data,
    vcov=vcov,
    ssc=fixest.ssc(adj, "none", cluster_adj, "min", "min", False),
)

py_mod_vcov = py_mod._vcov
r_mod_vcov = stats.vcov(r_mod)

py_mod_vcov - r_mod_vcov
# array([[6.93889390e-18, 1.08420217e-19],
#        [3.25260652e-19, 0.00000000e+00]])

Thanks @juanitorduz! I want to take one last close look at the fixest codebase before I merge this - I want to avoid having to revert this change again. I am still a little confused where I got the defaults from that this PR is over-writing. If all goes well I will merge this this weekend =)


cherry-pick: fix bug,some times clusternode created without podcidr

What type of PR is this?
/kind bug
What does this PR do?
Which issue(s) does this PR fix?
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

PLZ cherry-pick to release-0.3.0 too

/approved
/lgtm


Install dpl < 1.9 if travis_internal_ruby returns 1.9*

This is for transitioning dpl to drop MRI 1.9 support and add 2.3 (and later) support.
We examine the output of travis_internal_ruby, and if it matches the glob pattern 1.9*,
we run gem install dpl -v '< 1.9'.
When dpl 1.9.0 is released and drops MRI 1.9 support, those images with travis_internal_ruby not matching 1.9* (Trusty, practically speaking) will be able to use dpl 1.9.0.

It seems that travis_internal_ruby returns some variation of 2.2.x on all images in production at the moment.
(This is not to say that this PR is meaningless.)

A thorough test: https://staging.travis-ci.org/BanzaiMan/travis_staging_test/builds/639839
All of these jobs have travis_internal_ruby returning 2.2.x,(e.g, https://staging.travis-ci.org/BanzaiMan/travis_staging_test/jobs/639848#L537) and we run gem install dpl (--pre, since it has edge: true).

https://staging.travis-ci.org/BanzaiMan/travis_staging_test/builds/639881 forces 1.9 to be returned for travis_internal_ruby().


Capture pages that have fixed position footers

Currently the application has a buffer for capturing the top of the screen in order to try and not repeat fixed position content in the header. There is nothing to handle this issue with footers.
Example pages with this problem:

http://www.designboom.com/design/interview-with-graphic-designer-gareth-hague-06-23-2014/
https://www.grafik.net/category/talent/kathy-lam (some other issues that might be tough to stop on this one)

This is also a problem with Facebook chat (a floating bar).
I'd say, all elements with style="position: fixed" should be temporarily hidden during the save. Only the topmost screenshot should contain them.

you could try changing position: fixed to position: absolute

Ya, lately I’ve just been telling people to just switch things to position: absolute using Chrome Developer Tools and then taking a screenshot afterwards :smile: but at some point I might make a change to better support this use-case.

The webstore version has a number of improvements to this. It’s a pretty finicky problem to solve though and will probably take a good deal of iteration to handle the varying use-cases out there.


Deflakes ExtensionsCheck and BackupBucketsCheck controllers integration tests

How to categorize this PR?

/area testing
/kind flake
What this PR does / why we need it:
Deflakes the seed ExtensionsCheck controller integration test and also aligns the seed BackupBucketsCheck controller integration test as there's a chance that it was affected by the same flake.
The reason for the flake is the cached client that is used in the reconciler. The ExtensionsReady condition is set to Progressing in this Eventually call:
https://github.com/gardener/gardener/blob/8a7d7b08f54a005be62c6bbfca50f91bb15246cf/test/integration/controllermanager/seed/extensionscheck/extensionscheck_test.go#L135-L139
However, subsequent reconciliations might still read an outdated seed object, which still has a True ExtensionsReady condition. This can lead to a case where the clock is stepped, after that a reconciliation occurs that reads the condition with status True and accordingly sets it to Progressing with the new timestamp retrieved from the clock. The condition will then remain Progressing forever as the clock is not stepped anymore.
With this change we make sure that the cached client has observed the changed condition state before stepping the clock.
Which issue(s) this PR fixes:
Fixes #6679
Special notes for your reviewer:
Before this change:
$ stress -ignore "unable to grab random port" -p 16 ./test/integration/controllermanager/seed/extensionscheck/extensionscheck.test
12m30s: 1576 runs so far, 4 failures (0.25%)

After the change:
$ stress -ignore "unable to grab random port" -p 16 ./test/integration/controllermanager/seed/extensionscheck/extensionscheck.test
33m15s: 4230 runs so far, 0 failures

I also added some temporary logs to make sure that this was the reason for the flake:
--- a/pkg/controllermanager/controller/seed/extensionscheck/reconciler.go
+++ b/pkg/controllermanager/controller/seed/extensionscheck/reconciler.go
@@ -121,6 +121,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, request reconcile.Request) (
        condition := helper.GetOrInitCondition(seed.Status.Conditions, gardencorev1beta1.SeedExtensionsReady)
        extensionsReadyThreshold := utils.GetThresholdForCondition(r.Config.ConditionThresholds, gardencorev1beta1.SeedExtensionsReady)

+       log.Info("Processing condition", "condition", condition)
        switch {
        case len(notValid) != 0:
                condition = utils.SetToProgressingOrFalse(r.Clock, extensionsReadyThreshold, condition, "NotAllExtensionsValid", fmt.Sprintf("Some extensions are not valid: %+v", notValid))

Which produced the following:
    STEP: Patch conditions to False of foo-1-frs7k 09/17/22 21:46:08.893
    STEP: Wait until condition is Progressing 09/17/22 21:46:09.026
    {"level":"info","ts":"2022-09-17T21:46:09.028+0300","msg":"Processing condition","controller":"seed-extensions-check","object":{"name":"extensionscheck-controller-test-88csb"},"namespace":"","name":"extensionscheck-controller-test-88csb","reconcileID":"5aaaebd0-0442-42e9-83b8-b5342604c6e3","condition":{"type":"ExtensionsReady","status":"True","lastTransitionTime":"2022-09-17T18:51:59Z","lastUpdateTime":"2022-09-17T18:51:59Z","reason":"AllExtensionsReady","message":"All extensions installed into the seed cluster are ready and healthy."}}
    {"level":"info","ts":"2022-09-17T21:46:09.028+0300","msg":"Patching condition","controller":"seed-extensions-check","object":{"name":"extensionscheck-controller-test-88csb"},"namespace":"","name":"extensionscheck-controller-test-88csb","reconcileID":"5aaaebd0-0442-42e9-83b8-b5342604c6e3","conditionType":"ExtensionsReady","conditionStatus":"Progressing"}
    STEP: Step clock 09/17/22 21:46:09.251
    STEP: Wait until condition is False 09/17/22 21:46:09.251
    {"level":"info","ts":"2022-09-17T21:46:09.251+0300","msg":"Processing condition","controller":"seed-extensions-check","object":{"name":"extensionscheck-controller-test-88csb"},"namespace":"","name":"extensionscheck-controller-test-88csb","reconcileID":"b757a233-cc6f-4486-805f-c08635120f99","condition":{"type":"ExtensionsReady","status":"True","lastTransitionTime":"2022-09-17T18:51:59Z","lastUpdateTime":"2022-09-17T18:51:59Z","reason":"AllExtensionsReady","message":"All extensions installed into the seed cluster are ready and healthy."}}
    {"level":"info","ts":"2022-09-17T21:46:09.251+0300","msg":"Patching condition","controller":"seed-extensions-check","object":{"name":"extensionscheck-controller-test-88csb"},"namespace":"","name":"extensionscheck-controller-test-88csb","reconcileID":"b757a233-cc6f-4486-805f-c08635120f99","conditionType":"ExtensionsReady","conditionStatus":"Progressing"}
    {"level":"info","ts":"2022-09-17T21:46:09.752+0300","msg":"Processing condition","controller":"seed-extensions-check","object":{"name":"extensionscheck-controller-test-88csb"},"namespace":"","name":"extensionscheck-controller-test-88csb","reconcileID":"d46bb98f-8389-4ea6-928b-16ee8242c6e5","condition":{"type":"ExtensionsReady","status":"Progressing","lastTransitionTime":"2022-09-17T18:53:59Z","lastUpdateTime":"2022-09-17T18:53:59Z","reason":"SomeExtensionsProgressing","message":"Some extensions are progressing: map[foo-1-frs7k:]"}}
    {"level":"info","ts":"2022-09-17T21:46:10.252+0300","msg":"Processing condition","controller":"seed-extensions-check","object":{"name":"extensionscheck-controller-test-88csb"},"namespace":"","name":"extensionscheck-controller-test-88csb","reconcileID":"3a878fbd-b6fe-4027-b9c3-0169daea154f","condition":{"type":"ExtensionsReady","status":"Progressing","lastTransitionTime":"2022-09-17T18:53:59Z","lastUpdateTime":"2022-09-17T18:53:59Z","reason":"SomeExtensionsProgressing","message":"Some extensions are progressing: map[foo-1-frs7k:]"}}
    {"level":"info","ts":"2022-09-17T21:46:10.752+0300","msg":"Processing condition","controller":"seed-extensions-check","object":{"name":"extensionscheck-controller-test-88csb"},"namespace":"","name":"extensionscheck-controller-test-88csb","reconcileID":"81c41d4c-dd8a-49a0-850d-007e8fd27c3f","condition":{"type":"ExtensionsReady","status":"Progressing","lastTransitionTime":"2022-09-17T18:53:59Z","lastUpdateTime":"2022-09-17T18:53:59Z","reason":"SomeExtensionsProgressing","message":"Some extensions are progressing: map[foo-1-frs7k:]"}}

It's visible that the condition is patched to Progressing, but on the next reconciliation it is read as True.
Release note:

NONE

/approve


SourceLink integration?

It would sure be nice to be able to download and debug source code from our packages at nuget.org as well as our private feed.  We are currently publishing the packages but it's still not working.  I think we need to do more configuration to enable source link:
https://github.com/dotnet/sourcelink/blob/main/README.md
https://queil.net/2019/08/seamless-debugging-of-nuget-packages/

The second link might be more useful.

This requires the source to be checked into source control before building/publishing which the neonKUBE publish scripts don't do at this time.  We build and publish first and then we're manually pushing afterwards right now.

This also requires a nuget package to be added to the library projects that handles source code provider specifics (like a custom provider for GitLab).  I don't know whether a custom package is required for BaGet is required or available.,

Tracking this here now: https://github.com/nforgeio/neonSDK/issues/32


Plugin seems to not re-authenticate

Hey there;
I'm seeing a lot of this in my logs (entry at every configured update interval):
[midea-air] [MideaPlatform.ts] sendCommand (Intent: [updateValues] (fetch params?) attempt 1/2) returned error invalidSession, 3106

I'm not a JS/TypeScript dev, so I don't think I can submit a PR, but I think MideaPlatform.js calls sendCommand when trying to update the devices' statuses here in a try catch, which should handle the re-authentication process, but the error doesn't seem to be bubbling up?  In other languages I'm familiar with, when an error is caught (in this case, within sendCommand) it doesn't get bubbled up to the calling function. Does reject() in JS/TypeScript enable for this, or does it still need to be thrown?
Initially, I thought if I launch the app on my phone, it would invalidate my session. But even after being very careful not launching the app, it seems to pop up, and I'm not sure how to mitigate it. Would be great if we can get to the bottom of this and have the plugin re-authenticate automatically so I don't need to restart my HomeBridge every so often to keep this in sync.
Thanks!

Sorry, forgot to mention, I'm on 1.3.4:
    "homebridge-midea-air": "^1.3.4",

What is your AC model?

The device is Danby DAP120B9IBDB-6, which is a rebrand of Midea MP12SVWBA3RCM. The plugin identifies it as:
[midea-air] Created device: Office, with ID:<PHONE_NUMBER>7715, and type: 172

I have the app installed, but once I have Homebridge activated, I force quit the app and make sure it is not running. The plugin checks and works for a few hours, and then throws that message. It also seems to throw intermittent error as:
Command was not accepted by device: Office<PHONE_NUMBER>7715)

However, the command message does not seem to be directly related to this authentication error as it continues to work fine for several more hours until it fails again.

According to Midea this model has US-OSK103 Wifi module. My plugin don't support yet this module. It will create accessory but won't function properly.

Sorry, work ramped up and I missed the reply.
Aside from what I've already shared, there's nothing else related to this plugin, which is why I am thinking it has to do with the try/catch handling. I guess it is better to know that this is result of unsupported module, and will hopefully eventually be supported.
Thanks!


Dump() does not print out public fields

if you create a public class with public fields like
public class MyClass { public uint MyNumber; }
and call Dump() on it you just get an empty table with the header
but if you change the fields to properties it will work, i.e
public class MyClass { public uint MyNumber { get; set; } }

Hi @dyster, this feature is actually available but is turned-off by default, so you need to enable it.
You can do that either globally (for all Dumps) or on per-dump basis.
Enabling it globally:
DumpConfig.Default.MembersConfig.IncludeFields = true;

Enabling it on per-dump basis:
new Test().Dump(members: new MembersConfig { IncludeFields = true });

Btw, you can include nonpublic members as well, example:
DumpConfig.Default.MembersConfig.IncludeNonePublicMembers = true;

Yes I just branched the code to have a look and realised quickly there was a MembersConfig where I could set it.
My next thought on that was then is that the correct default behaviour?
Followed by well, if you follow good practice then you should not have public fields on your class so maybe it shouldn't be the default (I was only fooling around with some test code).
Followed again by, well, what does it do when you use public fields on a struct?
Which I just tried and no it does not print public fields by default, but that is (I think at least) how you are normally supposed to use structs?
So should the default behaviour be different for a class or a struct, and should the MembersConfig also differentiate between the two?

@dyster, sorry about the delay in my response. I agree with you that we should consider changing the default behavior with structs and once that is done, we should find a better way to separate the class/struct behaviors.


In what environment are you building?


Info window coming top left not on marker

I am using SlidingMarker to show maker moving whenever position change. Also we are show marker info window so that any one can click and see marker details. But the issue is Info Window comes on top left for all the markers when I use SlidingMarker and works fine with google.maps.Marker.
Please look at the issue and suggest how can I fix this issue so that is should work same as google.maps.Marker.

I''ll take a look at this today

Thank you for finding this.
I fixed the issue with InfoWindow in v0.2.2.
Here's demo with InfoWindow integrated: http://terikon.github.io/marker-animate-unobtrusive/demo/unobtrusive/markermove-infowindow.html

Please tell me if it fixed your issue.

Thanks @viskin for quick turn around. It fixed issues.


feat(execution): implement a versioned validator for implementing con…

…currency

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.10%. Comparing base (25920ad) to head (501987d).

Additional details and impacted files
@@                         Coverage Diff                         @@
##           mohammad/versioned-db/client-state    #1578   +/-   ##
===================================================================
  Coverage                               70.10%   70.10%
===================================================================
  Files                                      59       59
  Lines                                    8330     8330
  Branches                                 8330     8330
===================================================================
  Hits                                     5840     5840
  Misses                                   2008     2008
  Partials                                  482      482

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Implement jump to matching brace

I think this issue can be closed.  paging @peterflynn

@peterflynn How about incorporating that extension into core Brackets. We could use VIM-like shortcut for it Ctrl + %.

Definitly should use CTRL + B like Notepad++. This is like a standard in most text editors. Go for standards, thanks.

This does not seem to even work on American keyboards. It is not working on my Macbook Pro, not even when I press the button from the menu, instead of using the key binding. No effect whatsoever. (the extension)


doc: filename conventions

If I have simply missed where this is documented, please let me know where I should have looked, and close this out.

Many places describe how custom filename suffixes interact with the toolchain: _test, _linux, _arm. However I cannot find anywhere that says you should use snake case for multi-word file names, as is suggested by the standard library: e.g. time/zoneinfo_read.go/os/removeall_at.go not time/zoneinfoRead.go/os/removeallAt.go or time/zoneinfo-read.go/os/removeall-at.go.
This may seem self evident to experienced users, but I have seen many people get confused by the fact that variables use CamelCase := "", while files use snake_case.go.

I am not certain where this convention is documented, but I feel like @ianlancetaylor or @bradfitz might have some guidance.

To my knowledge, there isn't a documented convention for .go file names (other than meaningful things like _test.go, leading . or _, trailing _goos_goarch, etc.) anywhere. I've checked https://golang.org/doc/effective_go.html and https://golang.org/s/style.
The Go project itself tends to prefer short names like io.go, pipe.go, etc. In the rare cases two words are needed, they are joined without an underscore, like debugcall.io. For more complicated packages with many files, underscores are sometimes used when additional separation is needed.

That is useful to note. It led me down a bit of a rabbit hole, and it looks like even the standard library is not consistent. Should we make a standard?
file.extension.go
out:
- cmd/internal/obj/arm/a.out.go
- cmd/internal/obj/arm64/a.out.go
- cmd/internal/obj/mips/a.out.go
- cmd/internal/obj/ppc64/a.out.go
- cmd/internal/obj/s390x/a.out.go
- cmd/internal/obj/wasm/a.out.go
- cmd/internal/obj/x86/a.out.go

snake_case.go
marshaling:
- encoding/json/example_marshaling_test.go
- encoding/json/example_text_marshaling_test.go
- encoding/xml/example_marshaling_test.go
- encoding/xml/example_text_marshaling_test.go
mmap:
- cmd/compile/internal/gc/mapfile_mmap.go
- cmd/internal/bio/buf_mmap.go
- cmd/link/internal/ld/outbuf_mmap.go
- runtime/cgo_mmap.go
- runtime/export_mmap_test.go
- runtime/runtime_mmap_test.go
string:
- cmd/compile/internal/gc/class_string.go
- cmd/compile/internal/gc/op_string.go
- cmd/compile/internal/syntax/operator_string.go
- cmd/compile/internal/syntax/token_string.go
- cmd/compile/internal/types/etype_string.go
- cmd/internal/obj/abi_string.go
- cmd/internal/obj/addrtype_string.go
- cmd/internal/objabi/reloctype_string.go
- cmd/internal/objabi/symkind_string.go
- cmd/link/internal/sym/symkind_string.go
- debug/dwarf/attr_string.go
- debug/dwarf/class_string.go
- debug/dwarf/tag_string.go
- debug/macho/reloctype_string.go
- html/template/attr_string.go
- html/template/delim_string.go
- html/template/element_string.go
- html/template/jsctx_string.go
- html/template/state_string.go
- html/template/urlpart_string.go
- math/big/accuracy_string.go
- math/big/roundingmode_string.go
- regexp/syntax/op_string.go
sysnum:
- internal/syscall/unix/at_sysnum_darwin.go
- internal/syscall/unix/at_sysnum_dragonfly.go
- internal/syscall/unix/at_sysnum_fstatat64_linux.go
- internal/syscall/unix/at_sysnum_fstatat_linux.go
- internal/syscall/unix/at_sysnum_linux.go
- internal/syscall/unix/at_sysnum_netbsd.go
- internal/syscall/unix/at_sysnum_newfstatat_linux.go
- internal/syscall/unix/at_sysnum_openbsd.go

lowercase.go
gccgoinstallation:
- go/internal/gccgoimporter/gccgoinstallation_test.go
loopreschedchecks:
- cmd/compile/internal/ssa/loopreschedchecks.go
mkfastlog2table:
- runtime/mkfastlog2table.go
mksizeclasses:
- runtime/mksizeclasses.go
obscuretestdata:
- internal/obscuretestdata/obscuretestdata.go
reproduciblebuilds:
- cmd/compile/internal/gc/reproduciblebuilds_test.go

CamelCase.go
386Ops:
- cmd/compile/internal/ssa/gen/386Ops.go
"387":
- cmd/compile/internal/x86/387.go
AMD64Ops:
- cmd/compile/internal/ssa/gen/AMD64Ops.go
ARM64Ops:
- cmd/compile/internal/ssa/gen/ARM64Ops.go
ARMOps:
- cmd/compile/internal/ssa/gen/ARMOps.go
MIPS64Ops:
- cmd/compile/internal/ssa/gen/MIPS64Ops.go
MIPSOps:
- cmd/compile/internal/ssa/gen/MIPSOps.go
PPC64Ops:
- cmd/compile/internal/ssa/gen/PPC64Ops.go
S390XOps:
- cmd/compile/internal/ssa/gen/S390XOps.go
WasmOps:
- cmd/compile/internal/ssa/gen/WasmOps.go
arithBoundary:
- cmd/compile/internal/gc/testdata/arithBoundary_test.go
arithBoundaryGen:
- cmd/compile/internal/gc/testdata/gen/arithBoundaryGen.go
arithConst:
- cmd/compile/internal/gc/testdata/arithConst_test.go
arithConstGen:
- cmd/compile/internal/gc/testdata/gen/arithConstGen.go
deferNoReturn:
- cmd/compile/internal/gc/testdata/deferNoReturn_test.go

Although the compiler made a different choice, for the standard library we've historically preferred all lowercase just to avoid confusion on case-insensitive systems.  I don't know that this is written down anywhere.  I don't know that we have any particular guidance for file names in packages outside the standard library.

I don't know that we have any particular guidance for file names in packages outside the standard library.

To make progress on this issue, we need to decide if we should change that and attempt to offer guidance by adding an entry to https://golang.org/doc/effective_go.html or https://golang.org/s/style, or if we should not.
At this time, I'm inclined to believe we should not.
People who care about this can look at the .go file naming strategies used by the Go standard library and mimic it. Those who don't care can choose a naming strategy that they prefer.
There are additional resources where people write down their opinions on Go style, such as https://medium.com/@dgryski/idiomatic-go-resources-966535376dba. Perhaps an entry in one of those lists would be more viable.

I opened this issue because I have colleagues that asked, what filename conventions should I use with go?
I can understand that trying to stabilise this now may be problematic, noisy, or too late. But the lack of consensus will cause some amount of confusion and cognitive overhead. Because the community (seems to) understand the benefits of standardisation, see gofmt, even a soft recommendation in a blog post would go a long way.

Related, documenting that's allowed as opposed to recommended might be useful too.
https://github.com/golang/go/blob/d09e09bc615a50e9f2f1144991ebeba08a7c6f05/src/cmd/go/internal/load/pkg.go#L1883-L1895
https://github.com/golang/go/blob/d09e09bc615a50e9f2f1144991ebeba08a7c6f05/src/cmd/go/internal/load/pkg.go#L2196-L2211

Any progress/plan to document this somewhere?

@peterbourgon, can we just add your text to the wiki? I did not see strong consensus, but this is an easy one and we should probably just fix it.

I agree with all lowercase with underscore separation when necessary,  apparently greet_controller.go or greet_handler.go is more readable than greetcontroller.go and greet_handler.go.
you can gh repo clone golang/go  or gh repo clone kubernetes/kubernetes source code to your local and run find . -iname "*_*.go" | egrep -v 'test|arm|darwin|openbsd|unix|windows|plan9', most file names are lowercase with underscore separation style.
this is the convention, just undocumented yet.

The downside of blah_thing.go is that thing might get added as a new recognized architecture or operating system. It's just an unpleasant namespacing clash.
Imagine writing a game with npc_human.go, npc_monster.go, npc_android.go, and then Android gets released.
Imagine having embed_svg.go, embed_html.go, and embed_js.go, and then the platform js/wasm gets added.
Neither blahthing.go nor blahThing.go are vulnerable to that. Generally all lowercase is less likely to get damaged by OS X users. I'm almost tempted to use - where needed just to avoid that build tag collision.

no standards defined yet?

In addition to a recommended naming convention, I'd also like to see a list of all specially handled filenames and directories. E.g. *_test.go only compiled with go test, and nothing in internal directories exported outside the module. I'm not sure what else there might be. Is testutil special? I'm sure there's others that are special too.

@peterbourgon, can we just add your text to the wiki? I did not see strong consensus, but this is an easy one and we should probably just fix it.

Peter's comment has more likes than the original issue lol. I was looking for the same thing on Golang file naming conventions and was surprised to see that effective go doesn't discuss it even though it touches on naming for pretty much everything else.
@tv42 makes a valid point, so we could add it as a disclaimer under Peter's text so we at least have something listed in Effective Go for this (as opposed to telling people to read other sites for a convention 🙃 ).
@urandom2 Since you've already merged a PR here before, how easy is it to just raise a PR in the effective go docs and add this section? Do you already know which file to update to add a new subsection to the docs?

how easy is it to just raise a PR in the effective go docs and add this section?

A better place would be https://go.dev/doc/modules/layout, since Effective Go is frozen, as mentioned at the end of its 'Introduction' section.

So is snake case the standard according to @peterbourgon's comments?

I rather like @tv42 's comment contemplating the use of -
This way there is no potential conflict with the special handling of some _suffix 's
The only downside is that it isn't ever used in the standard library filenames near as I can tell.  So it feels like breaking convention.  Is there any good reason aside from that though to not use - 's?

I've also been gravitating heavily toward kebab-case over the last few years since I find sometimes I want to visually grep files in tree views.
As an example I'm working with an internal models package which stores model definitions as well as helper methods with shared functionality between these models. As such, I name each model definition model-a.go and model-b.go and so on to avoid visual conflicts with other files that do not pertain to a single model and rather shared concepts and generics.
That way, I can easily find a shared.go. I understand that an argument would be to decompose these into further packages but this adds needless complexity. At the same time I find bunching these into a single models.go feels bloated and leads to long and hard to navigate code that is not easily separable in terms of concept.

source_file--linux.go
text_marshaling--test.go

I like the idea of using - suggested by @zealsprince @tv42 as I am new to learning go, and with mild dyslexia, having a separator between words makes life easier for me.


Testing

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

this is a very wise comment


Link parsing not accepting closing ')'

When try to render a link with an ending ')' it is failing.
var marked = require('./lib/marked');
var link = '[snapshot](http://en.wikipedia.org/wiki/Snapshot_(computer_storage\))';
console.log(marked(link));

The result has the closing ')' is outside the link.

snapshot)

#27


usePureState

Use the same as useState but with shallow compare

Do you mean it would not re-render if props didn't change?

Could react-fast-compare help here ?

react-fast-compare does deep compare, as I understand, not shallow.

I mean that if use useState with object like this.setState, it would be great to skip update using shallow compare of object values like that
function Component() {
  const [state, setState] = usePureState({ a: 1, b: 2 })

  // skip update
  setState({ a: 1 }) // merges automatically
  // updates
  setState({ a: 2})

}

Yeah, sounds like something useful. I guess, could be easy to do, too, just with just a single loop that shallow-checks all values.

This is how React do shallowEquals:
https://github.com/facebook/react/blob/master/packages/shared/shallowEqual.js
I would hope that usePureState could get included as a built-in hook. Saves us all re-implementing (read copy-pasting) the above comparator.

Could this be implemented via a hook that allows a custom comparator function to be used for state updates? It looks like useState already avoids re-renders for shallowly equal updates, we would just need to expand the concept of what an "equal" update is.
// using default useState comparator
const [ state, setState ] = useDistinctState('a')
setState('A') // will update
...
// using a custom comparator
const [ state, setState ] = useDistinctState('a',
    (prev, next) => prev.toUpperCase() === next.toUpperCase()
)
setState('A') // won't update
...
// solving issue use case
function usePureState (initialValue) {
   return useDistinctState(initialValue, shallowEqual)
}

(I just came from reading #92 so that's part of my consideration here.)


[iOS] Test Idp token

Scenario: Create Idp Token

Precondition: The initialized was called and title, license, payable and receipt then call Idp Token
Steps to reproduce:

Generate a new ID
Call TikiSdk.config().initialize
Generate an PTR
Call TikiSdk.instance.trail.title.create sending ptr, Tags with TagCommon.ADVERTISING_DATA
Call TikiSdk.instance.trail.license.create sending titleId, uses and terms
Call TikiSdk.instance.trail.payable.create sending licenseId, amount and type
Call TikiSdk.instance.trail.receipt.create sending payable.id, amount
Call TikiSdk.instance.idp.token and wait the callback

Expected result:

The method has an callback who return the token

done in #307


Changed zero to $rootDepthValue in MaterializedPathQueryTrait.

It will be useful for integration this behaviour into exist code with his values of depth.

Oh. Excuse me for second pull request instead commit in the first. I'm not very good in github interface.

Thanks!


JQuery Version on NPM

I was downloading the materialize-css package from npm https://www.npmjs.com/package/materialize-css and found that the package is for browserfy using process but I would like to not use process. I am using systemjs and do not need process. Any way I can remove dependency on process?

Not sure what you mean by process, but you can remove it from the package.json


Removing Cortex-M peripheral API

The imxrt-ral crate provides not just an API for i.MX RT peripherals, but also an API for cortex-m peripherals. While it might be nice to have a consistent API for CM peripherals, it duplicates what's already available from the cortex-m crate.
Given that the cortex-m crate already provides these peripherals, would anyone be opposed to removing the cortex_m module from imxrt_ral?

Merged in #15.


Filtering

Depends on https://github.com/livebook-dev/kino/pull/229

Additional items:

[ ] Move "nulls" in categorical items to appear at the bottom. (let's have nulls always at the bottom so it is the same across all types
[ ] Fonts are not loading on Firefox (you need to do a hard refresh). They only load on mouse-over selection, and then you end-up with a mixed state:

[ ] Let's make the dropdown look similar to VegaLite dropdown. Here is a mockup (the borders don't have to be rounded):

And then once you select a filter:

If it is any help, here is the CSS of the first button:
{
  background-color: var(--gray-100);
  border: 1px solid var(--gray-200);
  border-radius: 3px;
  padding: 5px 10px;
  width: 100%;
  margin-bottom: 5px;
}

The button on the input is similar. :)


Issue 13 fix. Added 'next' arg in README.md

When a function actually sends a response, you don't actually need next. Additionally, if the examples were run through a linter, it would complain about an unused variable.

I tried the /signup e.g. in the README.md as is currently shown. Without the next, the error handler is not called by express when you make a POST without a body (it should as e.g. name in body is required).
It seems express is not registering the function as an error handler unless it has 4 arguments. i.e. I'm not adding next because I'm afraid the next middleware won't be called (as you pointed out, you don't need it when you send a response). It needs to be there because express works in mysterious ways…
Re the linter, if you're using eslint, you can add the following rule:
"no-unused-vars" : [1, { "argsIgnorePattern": "^_" }]

and then prepend next with an underscore: _next.

My bad! I didn't realize this was the the express error handler. You're right, "express works in mysterious ways."
Thanks for the PR.


[feature] GUAC-Neptune database connection

Is your feature request related to a problem? Please describe.
Implement the connection logic for AWS Neptune DB with GUAC.
Describe the solution you'd like
Users should be able to configure a connection with their Neptune clusters. This could be implemented as a part of the guacone command where users can pass in additional params.
Describe alternatives you've considered
N/A
Additional context
You can use this documentation as a reference https://docs.aws.amazon.com/neptune/latest/userguide/access-graph-opencypher-bolt.html#access-graph-opencypher-bolt-golang-iam-auth
We would want to implement this in a configurable manner such that users can plug and play with cluster endpoints in different regions.

@lumjjb there's still a fix to do but we're holding it off for now since AWS would be releasing SDKs capable of querying the Neptune DB (in a week's time or so). Might be worth the wait in order to avoid reinventing the wheel.


Add Spacing Specimen

@kyleoliveiro thanks for submitting this and sorry for the silence on our end! As outlined in #423, I think the right way for Catalog is not to keep adding more Specimens to the core package but rather enable custom plugins which is a more sustainable solution for the long-term. Once this is done on our end, I'd like to encourage you to do this. I'm thankful for your effort but can't accept your contribution at this time. I hope you can understand my reasoning and I'm happy to answer questions related to this decision.


c_nonce and jwt proof

in the issuance flow we use c_nonce and jwt proof without a proper definition of them
for instance, the c_nonce is a String containing a nonce to be used when creating a proof of possession of the key proof (see Section 7.2). When received, the Wallet MUST use this nonce value for its subsequent requests until the Credential Issuer provides a fresh nonce.
we have a quick definition here https://github.com/italia/eudi-wallet-it-docs/blob/versione-corrente/docs/en/pid-eaa-issuance.rst#token-response
we could imrpove this by giving more impl guidance about how this nonce is produces and how it can be used/verified with the jwt proof

scope
why we use c_nonce and why in italy we bind dpop with jwt proof


Smalltime has vanished?!

This is probably something I'm doing wrong but my Smalltime bar has vanished from my screen? It's still an option under the lighting section for the scene but I just can't seem to get it to appear on screen? Any thoughts?

 Thanks for the help - unsurprisingly, it's now back!


Add singleton support to node

https://github.com/Azure/azure-webjobs-sdk/issues/1429#issuecomment-344346805
Need to be able to specify singleton functions in the node env.

This is not isolated to node. For example, you can't write a csx function that runs in singleton mode. The work to expose this for node and other languages is tracked by https://github.com/Azure/azure-webjobs-sdk-script/issues/912 so I'm closing this as a dupe.


Default Splash Screen Implementation; Splash Screen Generator

Please verify the following:

[x] yarn ci:test jest tests pass with new tests, if relevant
[x] README.md has been updated with your changes, if relevant

Describe your PR

adds default Ignite iOS splash-screen assets and registers it using react-native-bootsplash
adds default Ignite Android splash-screen assets and registers it using react-native-bootsplash
adds default Ignite Expo splash-screen assets and references them in app.json
creates a new Ignite generator called splash-screen
adds icon template file to ignite/templates/splash-screen
closes #1809

Notes
For vanilla react-native apps, we're using react-native-bootsplash. It would be nice to use a unified approach between flavors(expo-splash-screen), but expo doesn't yet support Android 12 splash-screen API yet https://github.com/expo/expo/issues/16084#issuecomment-1100144155 .
Proofs

Validations
Generator
Splash Screen

no background color parameter
vanilla
vanilla Android

source equality check
expo
vanilla iOS

wrong input file size
vanilla (without react-native-bootsplash)
expo Android

wrong hex format

expo iOS

android size too large

size too small

We'll include this in Maverick


Applied torque has no effect if CollisionShape2D starts disabled

Godot version: v3.1.stable.official
OS/device including version: Windows 10 Pro
Issue description:
This issue was found while working on the Space Rocks example of the Chris Bradfield book.
When the CollisionShape2D starts disabled (either in the inspector or in the _ready() method), applied_torque has no effect. Debugging show that the torque is indeed applied but the transform matrix doesn't account for it. Forces are applied normally, though. I can thrust forward, but not rotate it.
If the CollisionShape2D starts enabled and then gets disabled (by a timer of 0.01s, for example), enabling it again works as expected (I can rotate it by applying a torque).
I didn't add this interaction in the minimal example, but if another RigidBody2D collides with the player, it is pushed back (force is applied) but no rotation is applied.
The original Space Rocks source, when imported into 3.1, suffers from this aswell. In 3.0.6 it doesn't, though.
Minimal reproduction project:
test.zip
You can either disable the CollisionShape2D in the inspector or enable it and uncomment _ready() to test both cases.

I was just looking into this myself. Confirmed torque is applied but the body ignores it when collision shape is disabled.

Hi, I encountered the same bug while reading the book, How did you manage to get it working ?
Even with adding timers I can't


API of received rewards in dashboard

Tasks

[ ] create API of query received rewards

support: HKD, USDT, LIKE
appreciations (clap counts)

[ ] list last 6 months statistics on desktop, and list last 4 months on mobile

References

Product doc
Design

Issue requires review and rearrangement. Close it.

Issue requires review and rearrangement. Close it.


Keep original error in reader

Previously, when the reader fails to consume a message, the only error shown is "Unable to read messages" with the original error as nil.
Now the error is kept in the log.
Note: the previous PR was auto-closed due to having renamed the branch.

@davidgomesdev Released in v0.25.1.


Fix key encoding in windows reloader.

Alternate fix of https://github.com/pallets/werkzeug/pull/1320

Can we merge it?

Thanks!


angular-meteor-auth.bundle.js doesn't pass minification

I suppose now it does.

@idanwe

@Urigo @ThomsC The fix should be at the source code
and then create new bundle

@ThomsC do you want to create another PR?

Ok sure I'll do it


/Users/mackuser/Desktop/cls/Pods/Kingfisher/Sources/SwiftUI/KFImageRenderer.swift:48:63 Initializer for conditional binding must have Optional type, not 'AnyView'

Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

[ ] I have read the wiki page and cheat sheet, but there is no information I need.
[ ] I have searched in existing issues, but did not find a same one.
[ ] I want to report a problem instead of asking a question. It'd better to use kingfisher tag in Stack Overflow to ask a question.

Issue Description
What
[Tell us about the issue]
Reproduce
[The steps to reproduce this issue. What is the url you were trying to load, where did you put your code, etc.]
Other Comment
[Add anything else here]

Anyone have solution??

Xcode 14.3.1 related issue.

The fix is at 7.6.1 version:
https://github.com/onevcat/Kingfisher/releases/tag/7.6.1


CSS object manipulator

In this project, we have an object whose size shape position, and color we can change dynamically in real-time dom.
used the concept of dom manipulation

This is not the correct repo for this issue. If you are gonna use js raise this in js repo else in frontend templates repo


Feature page list block cache improvements

Adds support for Page List blocks to be cached.
If there's no pagination or external filtering, Page List block will be cached same length as autonavs.

and what happens if I rename a page shown in the pagelist? It will show an out-dated title, description and probably even worse link..?

Which is exactly what'll happen with the AutoNav as well.

oh I see what you mean. We've done that in the past with some blocks because performance was pretty bad, didn't take long till we've received the first phone... While I'd more than appreciate if 5.7 was faster, I'm a bit hesitant about this. But since it isn't my call.. ;-)

True, caching is always a trade off of time vs stale content.

300 seconds is low enough that it'll refresh itself fairly quickly.
How often are you going to make URL changes? This is bad for lots of reasons, so there should be 301s set up
Changing URLs of a page, would also break if you had links to them inside of content blocks

If you have an idea of how we can make this even better, I'm all for it - I just don't see a better solution at the moment. Thoughts?

Well, 300 isn't a problem for me, but users who rename something, and even if it's just a page description and then check if it worked will be surprised that it kind of didn't work.
301 redirects aren't a problem when you rename a concrete5 page as it keeps the old path and redirects you, but see comment above, happens for the description, attributes etc. too
No, changing the URL of a page isn't a problem if you don't cache the output as it saves the page id and then converts it when rendering the block.
--
No, I don't see a better solution, concrete5 was quite a beast and has just become bigger and partially slower with the 5.7 release. I've analysed a few profiles with blackfire and couldn't find anything obvious.
Only things that pops into my mind is a custom page list block we've built where we cleared the block cache using events. on_page_add and all those events cleared the cache which also had the benefit that we could cache it forever. Might work with pagelist and autonav..

Totally had the same idea! Actually, there might be a fairly sophisticated solution in here, but it'd require a larger system. Blocks should be able to opt into page events and clear their own block caching.
So for example, in the PageList block, you can have the on_page_add, modified, etc hooks, and it would clear the output cache for that block. I don't think there's a way to target just the blocks that were affected, so you'd probably have to clear all PageList blocks. But maybe?
This could in theory, serve as a huge performance drain on larger sites if there are a lot of pages being added/removed, so it might make sense to make this an optional feature? And we'd have to consider whether or not it should invalidate the Full Page Caches as well.

I tried to clear the blocks that are actually affected once, but that meant that we'd run all "get page list" methods of all list blocks in our site. Since there was no nice async system (I love laravel in combination with beanstalk) I've decided to clear all "page blocks" which has the down side that you might clear the cache rather frequently but it was still much faster.

what if there was a property $clearBlockCacheOnEvents = ['on_page_add', 'on_page_update']; which would clear the block cache if any of the listed events is executed?

That could work.
So, thinking out of the box here... this solution might end up being more time intensive than the savings we get. what if we determined some type of dependency tree? For example, let's say you set the AutoNav or PageList to show pages directly below a particular cID, well then you'd want to listen to any and all page events that affect that page and lower.
This could be implemented in the above blocks so that they would be aware when they were saved as to what criteria they'd be listening too. In theory, we could always have 100% fresh results this way, while still preserving the cache, and not invalidating huge portions of unchanged blocks
The dependency tree wouldn't necessarily even have to be just related to pages.

well, clearing the block cache is easy and quick as long as you don't have to check for anything specific, I don't think that would cause any problems. A dependency tree would be nice, but simply listening for events is much easier and not limited to pages.
Maybe we should wait for Andrew and see what he thinks. I'm definitely interested in seeing a faster 5.7, already seen too many slow page requests in the few little projects I've created so far.

Agreed. C5 is too slow, thus my attention to a lot of the caching systems. I'm hoping to greatly improve how many things can be cached, and then turn to profiling to try and figure out the next bottlenecks to tackle.

Installed 5.7.5 and less than a day later the first customer was confused that his new page didn't show up in his navigation :D We should really have a better way to cache such slow blocks, or make them faster..


Pyrotechnic chamber design

I added the 3D STEP files for the pyrotechnic chamber. These include the piston, fire-bolts, ejection cup and aluminum plate


Skip APM test that is flaky because of docker-compose up issue

What does this PR do?
Skip APM test that is flaky because of the Pulumi update operation.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


SidePanel::rights with an exact_width  have incorrect padding

Describe the bug
SidePanel::right incorrectly pads the right side of the panel when it has an exact_width set.
To Reproduce
The following update function roughly implements the screenshot below:
fn update(&mut self, ctx: &egui::Context, _: &mut eframe::Frame) {
    egui::SidePanel::right("right").exact_width(100.).show(ctx, |ui| {
        ui.label("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA");
    });
    egui::SidePanel::left("left").exact_width(100.).show(ctx, |ui| {
        ui.label("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA");
    });
    egui::CentralPanel::default().show(ctx, |ui| { });
}

Screenshots

Desktop (please complete the following information):

OS: Linux.

Additional Information
As implied, the padding is correct when an exact_width is not given.

Closely related to #3006, I wouldn't call it a duplicate but I'd be happy to close this if need be.

I am also experiencing this problem! Here is what I'm seeing:

The 'saved moves' panel is being rendered on top of 'Nxf6' and the multiline text widget. Heres' my src:

(screenshot cuz my editor is being weird about copying)
I'm calculating what I want the width to be (40% of the screen space for the notes panel, and 10% for the moves panel), then assigning it by using exact_width(). However, this results in the aforementioned issue.
Thanks!
- Rylan Yancey


0.12.1 - Vite local development 504 error .vite/deps/worker.js?type=module&worker_file

Describe the bug
Using 0.12.1 - in a vite react browser application
This throws a 504
https://localhost:5173/node_modules/.vite/deps/worker.js?type=module&worker_file

To Reproduce
Steps to reproduce the behavior:

Create a vite react app
Call await ffmpeg.load(opts);

Expected behavior
Library should load
Screenshots
Attached
Desktop (please complete the following information):

OS: All
Browser: All
Version: All

Additional context
Tried to exemplify in a code sanbox https://codesandbox.io/p/sandbox/hopeful-ptolemy-j5cjpn but the sandbox has some issues

I had the same and fixed it by adding this to defineConfig in vite.config.ts
 optimizeDeps: {
    exclude: ["@ffmpeg/ffmpeg", "@ffmpeg/util"],
  },

Yeah, I think optimizeDeps.exclude is a great solution! Will add it to the doc when possible.

This helped unblock me. Cheers!

Unf, thanks SO MUCH for this @JanMisker. Was scratching my heads for days on this one.

Awesome, this solved it, wiki notes updates


WIP: Unbound vars

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>

/close
wrong path... :sweat_smile:


Add missing doc comments

Looks like there are a lot of places where we lack doc-comments. Filing this issue to track the work of filling in the gaps.

Closing this as done.


Create process metadata

Regroup sources.json and statistics.json in metadata.json
Add lastUpdate (close #186)
Update global build script
Update website build script (need update of HTML templates to display datetime of last update)
Update documentation

Will update statistics.equalstreetnames.eu soon, seems like it shouldn't be too hard to do.

That didn't take too long: https://github.com/RobinLinde/statistics/commit/025f1a0aecdbdca68ab8602754efe64e8077f51d

That didn't take too long: RobinLinde/statistics@025f1a0

I see that you're still using statistics.json and sources.json.
Both will be deleted for all the cities after the next update, all the information are now available in metadata.json.

I see that you're still using statistics.json and sources.json.

As of now it completely rebuilds the data from the git commit history, and I'm still including them for older statistics. Currently it combines both statistics.json + sources.json and metadata.json, but should also work if only metadata.json exists.


feat(pa): dynamic backscraper and update to new source

Implemented a new scraper targeting the API instead of the RSS feed. Since we needed to backscrape, that way we can target custom dates Also, updated the example files
Helps solve #967

This is indeed an enhancement we've been tracking for months. The OpinionCluster model has a one-to-many relation to the Opinion model, so it is what we should be doing. However, we would need to change both Juriscraper's OpinionSite(Linear) and cl_scrape_opinions for it to work. I bundled this and other changes into a proposed new scraper/site class some time ago, but is still pending of review. You can check it some more here https://github.com/freelawproject/juriscraper/issues/883#issuecomment-1981884866

@grossir can we figure out the conflicts here and does this need the enhanced v3 juriscraper?

To actually return and use OpinionClusters, we will indeed need a different approach both in juriscraper and courtlistener, and that's not ready yet
It seems there were no conflicts, I just merged main

@flooie I updated the PR with the suggested changes; also added support for getting "per_curiam"

This is great thanks @grossir


Soft wrap hanging indentation spaces

Closes https://github.com/atom/atom/issues/6003
/cc: @nathansobo

Bloody brilliant! :sparkling_heart:

Excited about the feature, but I'm wondering if anyone has any ideas for the name of the setting. softWrapHangingIndentationSpaces feels a bit wordy. Maybe softWrapIndentationOverhang? Not loving that either. We could go with it I'd just like to kick around some alternatives.

Excited about the feature, but I'm wondering if anyone has any ideas for the name of the setting. softWrapHangingIndentationSpaces feels a bit wordy. Maybe softWrapIndentationOverhang? Not loving that either. We could go with it I'd just like to kick around some alternatives.

Yeah, naming things is hard :disappointed: To be honest I simply borrowed the term from the referenced pull-request but it feels wordy to me as well. Maybe we could involve @atom/non-github-maintainers to help us with this? Your help would be much appreciated :+1:
As usual, thank you @nathansobo for the interesting discussion and for your always great feedback! :pray:

I just stumbled across this PR and the naming conversation.
From the typography perspective I like either the current softWrapHangingIndentationSpaces or a shorter softWrapHangingIndentation. In typography, the general paragraph shape that results from line-wrapping like that which results from having the option in this PR enabled can come about one of two ways: either the paragraph has an outdentation or a hanging indentation. (I personally have not seen any other names, and a quick flip through all the typography books I have at hand seems to confirm this.)
An outdentation is when the paragraph extends into the left margin by some amount. The analogue in a text editor would by a negative-valued indentation width, which doesn't really make sense. But this brings up another interesting concern I'll mention at the end of this comment.
A hanging indentation is is an indent of all lines after some _n_th line of the paragraph by some amount, which, in my opinion, corresponds exactly to the behavior of this PR. So having HangingIndentation somewhere in the naming makes it very clear what is going on. In particular, the original issues was created used TeX as an example, where this type of output is controlled by the lengths \hangindent and \hangafter, which may be why the author of that issue used the term hanging in the name of the issue.
The outdentation discussion bring up an interesting point: this PR results in some odd behavior if softWrapHangingIndentationSpaces is negative and its magnitude is larger than the main indent level. I would expect the soft-wrapped lines to be aligned with the left side of the editor view, but they indent themselves by the difference between the value of softWrapHangingIndentationSpaces and the number of spaces by which the first line is indented. (It will be clear if you try some negative values.)

indentSoftWrap?  That sounds like it could be a bit misleading though so perhaps a comment could be added stating "this is relative to the original indent" or something?

@50Wliu @grizzilus: thank you for answers!
Based on @grizzilus thorough explanation (thank you for that), I renamed the config variable for now to softWrapHangingIndent but, most importantly, we discovered an interesting edge case, which I didn't take into account. As I intended the feature, the value of this config setting must always be positive and, therefore, I fixed that accordingly (https://github.com/atom/atom/commit/e5fa44171df82962efb185d6b5d36ab2b8329f86).
Let's wait for @nathansobo final take on this :fireworks:

I'm actually not getting any handing indent if I build the last commit here but I can't find any error (or anything missed) in 7c33b9b...

@grizzilus: could you post here your config.cson, please? Also, make sure you have updated the setting to:
softWrapHangingIndent: <number>

@as-cii Nevermind, it is fine, sorry about that. I rebuilt but when changing the value in the GUI it wasn't updating. Removing the old setting from the config file allowed me to set directly or from the GUI.
On a side note, I wonder if it is reasonable to allow for negative indents. I know you originally intended for positive values only, but what if we did allow negative indents and just cap it at the maximum of 0 and the sum of the regular indent and the hanging indent? While I can't think of an really useful example (other than easily seeing where there are long lines nested very deep more easily), it seems like a straightforward change to allow more flexibility.

While I can't think of an really useful example (other than easily seeing where there are long lines nested very deep more easily), it seems like a straightforward change to allow more flexibility.

Thank you for pointing this out @grizzilus. I must say I have considered this option while implementing the change, but as you're pointing out I couldn't find a meaningful example and, therefore, I opted to simply make the configuration stricter allowing only positive values. Supposedly, this makes its intent a bit clearer (or does it?) sacrificing a bit of flexibility (e.g. negative values).
On the other hand, if we find a good use-case for negative values I'll be happy to implement that feature as well. :dancers:
/cc: @AlexLog @jtkiley

The more I think about it, you are right. I can't imagine the magnitude of this being more than twice the indentation amount, and if text starts that close to the margin, there are bigger issues to deal with than the hanging indent. But great work @as-cii on this and the original indented softwrap; it is such a help to people who use TeX-based files regularly.

How about wrapHangingIndentation - Atom doesn't do hard-wrap, and "IndentationSpaces" seems redundant

@as-cii @grizzilus I can't think of a good use of negative values, either. I thought about it briefly when I was writing up the issue, and I thought about it after seeing the discussion this morning. Someone may come up with a cool use case, but a negative indent would actually look like the old behavior (i.e. wrapped lines beginning at the left margin) in some cases. If anyone is clamoring for the old behavior as an option, I haven't seen it.
Echoing @grizzilus, thank you @as-cii for the awesome work on indented soft wrap and the hanging indent. It's a huge help for TeX work.

@nathansobo: thank you for all the great suggestions: hopefully, I have implemented them all :+1:
Please, have one final look and feel free to commit on this branch if you need to :smile:

:joy: :joy_cat: Members of every species thank you for your contribution.


[Feature Request] Adjust fish alarm to reflect actual availability

Specifically, fish that require Fisher's Intuition currently ping their alarm even if there's a catch dependency that isn't fulfilled. The fish log itself reflects this, but the alarms do not.
Example: Aquamaton's available time window is 10:00-16:00, but requires Intuition from 1x Shadeshifter (weather & time dependent) and 5x Shapeshifter (always up), The alarm for Aquamaton's availability will trigger for 10:00 in game, even if Shadeshifter is not available during the 6 hour window.
Example 2: Warden of the Seven Hues does not show up as a triggerable alarm because it is "Always Up". It may technically be "Always Up" but requires Intuition from 3 separate fish that all have various uptimes.

Dependency uptimes are not strict requirements, and can not be incorporated into a fishes uptime in a sensible way. No.


update quickstart-validium for 0.6.4-cdk

Summary
we completed the updates for zkValidium-quickstart with the 0.6.4-cdk.
Now all the updates are under the branch v0.0.3, and we will merge it to main once this PR is merged and polygon-docs is published.

remove docker-compose
remove sudo docker-compose pull
add 2.4 useful commands

make ps/ps-exited/run-resume


There is a duplicate "Wordpress Scan 1" entry

https://github.com/frizb/Vanquish/blob/6f738b6d4641950622b8fdbf3d33c42f307a1953/config.ini#L418

My mistake, sorry. It is for http and https.


Add AbortController to eslint globals

Summary
Fix eslint complaining about AbortController not being defined.

@maltoze could you please rebase so that CI errors are fixed, and run correctly.

@maltoze could you please rebase so that CI errors are fixed, and run correctly.

@dulmandakh Sorry... I created a new one #30691

@dulmandakh Sorry... I created a new one #30691


Visualization

Hi Ziyue,
Thanks for releasing this fantastic work. I have a quick question about your video demo. Can you give some suggestions about point cloud visualization? like any tools or software etc.
Thanks,
Hang

Hi brandley:
Thank you for your interest, I use open3d for point cloud visualization, it has python interface that you can update the point cloud automaticly


chore(deps): set Graphback version to next in templates

This PR sets Graphback dependency version to next in each of the templates. next is an alias for the latest beta version and we need the templates to use this. This saves a manual bump of the version.
@wtrocki maybe there is a better way to do this with renovate?

I think there is better way do do this with yarn workspaces, but this is something that solves current problem and renovate/workspaces is something we tried and it might require research so.. Good to have it this way


EXSWHTEC-36 - Implement tests for basic hipMemPool APIs

Implement negative tests for hipMemPoolCreate, hipMemPoolDestroy and hipMemPoolTrimTo
Refactor positive test for hipMemPoolTrimTo

PR has been merged into develop branch via commit dbc1a9d07383f3700e1da2b81144ef9e78adba94.


Addition of Soft Delete to the MongoDB

while this works this feature is not complete

queries still fetch deleted element
lack of indexing on deleted field
lack of tests

The last two points are clear to me and i am working on them.

sir indexing is done when the database is created.., could you pls specify the file which is responsible for the creation of the database.

@jaskeerat789 We do not have anything that creates collections for mongo.
Basing on my understanding collections are also created then the element is inserted. This is definitely a challenge.

The index is updated automatically on every insert operation. You don't have to do this manually but have it in mind. This is what makes insert operations expensive. The more indexes you have the longer it takes to insert a document and update all of them.

this from the official docs

should I make the DB migration package? @wtrocki @craicoverflow

I guess we might need some form of mongo related dbmigration package that will simply apply indexes?? @craicoverflow WDYT?

From some quick Googling it seems there might be a few reasons to have MongoDB migrations.

should I make the DB migration package? @wtrocki @craicoverflow

No, not yet. This requires further planning and discussion on our side to see what is needed. We may not need to create our own since there may already be another open source project that does this.

@wtrocki @craicoverflow Sir pls let me know what changes need to be done in this PR

Actually I am unable to understand the flow of the package. I define whose functions in MongoDBDataProvider which directly control the DB.
What does OffixMongoDBDataProvider do?  what is offix is general?
Cause of this, I am unable to understand the point that @wtrocki  and @craicoverflow made in the previous comments. To see where are the other functions from MongoDBDataProvider are used, I tried using VSCode's references feature, but couldn't find the file where the softDelete function needs to be used

@jaskeerat789 thanks a lot for the PR! Right now this is not a focus of our roadmap so we will revisit it at a later stage - but going to close for now.


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 3.0.58 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add to psc-package

Can you add this library to psc-package main package set https://github.com/purescript/psc-package

I've created https://github.com/purescript/package-sets/pull/112 to hopefully get this out there soon


new:usr: checkin paper incomplete draft

checkin paper - incomplete draft

I'm reverting this as it breaks the build.

@mmccombe it looks like you don't have the readme. Please check the Travis log. You may need to resubmit.


BetterDiscord.BetterDiscord version 1.2.1

[x] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @Twig6943,
The installation isn't unattended. It requires the user to accept an EULA:

Is there an installer switch to accept this and have it install automatically?

no I don't think there is would it work if it wasn't a slienced installer?

no I don't think there is would it work if it wasn't a slienced installer?

Pending:

https://github.com/microsoft/winget-cli/issues/910


Make an astroplan slack

Inspired by @bmorris3's comment in #9 I thought I'd offer another option for our purposes: we could try making a Slack team.  The nice thing about slack is that it allows either e-mail like async discussion or real-time chat in the same context. I've used it for a couple science collaborations and it seems good as a replacement for e-mail/chat...  Should I make a slack team for us to try it?

Oh, and in case it's not clear, I'm thinking this might be better than gitter because of the online/offline thing: as @adrn said, gitter hasn't ended up getting used so much because there aren't people regularly there.  Slack (at least to me) is better about that because it works about as well real-time as it does in a more e-mail like way, so even if someone can't be online all the time it's still useful.

Sounds cool.

  I get the impression this sort of small team is what it's designed for, but I'm guessing it sort of needs group buy-in to be useful.

It's not clear to me yet what combination of Slack / Email / Gitter / Github comments is good for us ... there is a risk that things get too scattered.
But if one of you is willing to set it up, :+1: to try Slack for astroplan for a while and see how it works / if we like it.

alright, done: see https://astroplan.slack.com/ .  I guess let the best medium win ;)


chore(main): release 2.6.0

:robot: I have created a release beep boop
2.6.0 (2024-11-12)
Features

switched .mjs to .js to fix import issue (eaacb58)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/nico-i/eslint-config/releases/tag/v2.6.0 :sunflower:


refactor(ui): improve first time alerting experience

Closes #14911
The goal is to make it more obvious what to do first in order to get set up with the Monitoring & Alerting feature

Added explainer tooltips to all alerting page column headers
Swap the placement of Endpoints and Rules columns

This should hypothetically indicate that you need to create an endpoint before creating a rule

Disable the "Create Rule" button until at least 1 endpoint exists
Show a "first time" panel if no checks, rules, or endpoints exist

[ ] CHANGELOG.md updated with a link to the PR (not the Issue)
[x] Well-formatted commit messages
[x] Rebased/mergeable
[x] Tests pass
[ ] http/swagger.yml updated (if modified Go structs or API)
[ ] Documentation updated or issue created (provide link to issue/pr)
[ ] Signed CLA (if not already signed)

Not 100% sold on the column orderings but i think it's a net positive for launch.


chore: hotfix receipt call

created from https://github.com/FuelLabs/fuels-ts/pull/2407 which was created from 0.88.1

close in favor of https://github.com/FuelLabs/fuels-ts/pull/2479


Improve usability of manifest types from Rust SDK

Adds some helper functions for creating a manifest, mostly helpful for the Rust SDK
Renames ManifestWasm to Wasm
Renames ManifestMemory to MemoryOptions
ManifestWasm and ManifestMemory have been marked as deprecated
Adds an alias from MemoryOptions::max_pages to MemoryOptions::max in serde specification

I believe it was this: https://jlblcc.github.io/json-schema-viewer/
There is probably a way to render it in the docs.

Since we've committed to the API, can we do this in a backwards compatible way? or save it for 1.0?

If we're going to make some changes like this, there's another I'd like to consider in the HttpRequest type: header -> headers

This PR should be backward compatible, with the old names marked as deprecated - the only thing changing in the JSON schema is the type names and max is changed memory_max (but max still works)
@steve - I will add headers as an alias for header right now

I just realized the max/max_pages and header/headers changes weren't present in the json schema because they were only aliases so I swapped the name of the struct fields and the alias names.

Added a commit to include similar name changes throughout the SDKs. Figure we should be consistent. This breaks backward-compatibility though, so we should discuss.


add AGPL

Please add the AGPL license to the list of available licenses! Thanks

@browniebroke It might just be worth it to use GitHub's choosealicense.com. We could vendor all the licenses from here (in case GitHub changes where they are stored or how they're laid out) and update anytime there is a change in their directory: https://github.com/github/choosealicense.com/tree/gh-pages/_licenses

Or instead perhaps make separate directories for each license rather than storing everything in a single file?

Interesting idea to get them from that repo. A couple of things I noticed:

the files content are a bit more than just the license, they are templates with some sort of front matter
templates variables (year and author) seems to be using square brackets while cookiecutter (jinja) uses double curly braces

We could pull them and convert them regularly with a github workflow, but it might not be worth the trouble...
Splitting the current file into multiple ones would be a nice improvement on the maintenance front, would make it easier to see what we support.

Agreed; too much trouble. On the second thought, having to parse for a bunch of dashed lines to indicate the beginning of the license file is not really that good of an idea. But definitely splitting the licenses is an improvement, and importing each license from that repo and replacing them with the jinja curly braces would be needed.