fix: tcp port in /signalk and mdns

Fix the default port for deltas over tcp to be 3858. Replace the hard coded
value in /signalk response with the one actually used and omit the tcp
service if it is not active. Fix mdns to use the actual port in use
in the service instead of the http/ws port.
Fixes #191

Ping @sailoog


Does this gem support Broadcast API?

Does this gem support Broadcast API?
https://developers.facebook.com/docs/messenger-platform/send-messages/broadcast-messages

@soulfly No. Currently it does not support the Broadcast API. Broadcast API is only available in v2.11 and this gem is still on v2.9. So it has to update to v2.11 first then it will be possible to support Broadcast API.

Thanks @amrutjadhav
I have just created a monkey patch for this in a case somebody will need it
module Facebook
  module Messenger
    module Broadcast
      include HTTParty

      # Define base_uri for HTTParty.
      base_uri 'https://graph.facebook.com/v2.11/me'

      format :json

      module_function

      def create_message_creative(messages, access_token:)
        response = post '/message_creatives',
                      body: JSON.dump(messages),
                      format: :json,
                      query: {
                        access_token: access_token
                      }

        Facebook::Messenger::Bot::ErrorParser.raise_errors_from(response)

        response.body
      end

      def send_broadcast(message_creative_id, notification_type, schedule_time, access_token:)
        data = {:message_creative_id => message_creative_id,
                :notification_type => notification_type}
        data[:schedule_time] = schedule_time if schedule_time

        response = post '/broadcast_messages',
                      body: JSON.dump(data),
                      format: :json,
                      query: {
                        access_token: access_token
                      }

        Facebook::Messenger::Bot::ErrorParser.raise_errors_from(response)

        response.body
      end
    end
  end
end

Cool. I'll be happy to merge a pull request for this, too.


Add a Home Page for Better Navigation and User Experience

Currently, the website includes login, signup, and a password generator page. However, there is no central home page that serves as a starting point for users which contains information and features provided by the website.
I propose adding a home page that users land on. This home page would provide a simple overview of the site
This page would give users a comprehensive overview, helping them understand what the site offers. The features of the site and what the website is all about.
Please assign me this issue with gssoc and hacktoberfest labels

Assigned @Tamanna225


Fixed minor layout issues on projector and pdf.

Especially for motion diff view.

@normanjaeckel I have to merge it now. Please review later. Thanks.

Hm. All divs seam to be correct but the indention is messy.


Use case 1: Engineering Manager who needs a lot of integrations built

User Story
"how can we get all of these things built with the resources we have?"
Summary
What Frigg enables for this person is the ability to look externally for engineering help with external APIs.

Instead of having their core engineering learn an external API and its nuances/intricacies once, they can either leverage the ever-increasing value of Frigg abstractions,
or they can hire an external team to contribute their knowledge just to an isolated integration codebase (so, they don't need a contractor to have access to their core code/they can just hire expertise in a specific application/marketplace/ecosystem).
Or they can combine approaches.
The point here is that leveraging Frigg is beneficial for what it unlocks with getting external expertise in the door to help.

Questions

@seanspeaks, do you meant to say that the external expertise is hiring lefthook to build things for them? Or just that the code is open source and has been developed, therefore it saves time?

"what it unlocks with getting external expertise in the door to help"

@seanspeaks when Frigg is all done and perfect, 😉 , is the intent that consumers of Frigg will very rarely need to read the docs of the APIs that they are interfacing with since all the code will interface with all APIs in the same way?

Well, right now, it's Left Hook because we're really the only ones who have the combined "Frigg plus target API" knowledge. The whole purposes of open sourcing it is to garner experts from around the world, from around the different ecosystems, to pick up and try to nurture along their part of Frigg's library. At some point, the idea is that through that gained expertise, common helper functions, testing harness, scaffolding tools, code patterns, and schema validation should allow someone who hasn't ever touched the HubSpot API docs (for example) to quickly build a HubSpot App that has some HubSpot-specific features built in (CRM Extensions, Timeline Events, Workflows, Custom Schemas, etc)
That's certainly the end goal, though the hope/idea is that you can "get started quickly" and then break out of any sort of abstraction or training wheels if you need to get into the weeds for whatever reason.

Expanding on #2 a bit... and this really should go in Core Frigg, API module development notes... I want to have all APIs broken down by Resources and their Schemas, and corresponding Verbs/Methods. I'm leaning towards something like:
listResource = returns array
getResource = returns an object, probably with query filters/options
getResourceById returns an object expects ID
updateResource, createResource, deleteResource (normal CRUD)
someResourceSpecificMethod = i.e. "sendEmail", "pauseWorkflow", "startWorkflow" etc.
and each one is explorable by both exposed Types and by a common interface such that we could build out easy helper tooling "Select a resource to find out what it can do", "Explore a resource in more details, including fields, events, common workflows", "here are the most popularly used methods"
When you combine that ^^ with auth "figured out for you" and normalized developer notes on how to get started... it'd be like an Integration Dev Cookbook

Added to docs. Great stuff!


accessories reforges

Adds a recap of all the reforges applied to the accessories (included "no reforge"). Useful if you want to copy a reforge setup from someone or if you want to check your own 😄

I feel like it might be easier to read if the variable rr had a more descriptive name

I feel like it might be easier to read if the variable rr had a more descriptive name

in that moment I had 0 creativity xD
It's an object containing rarities -> reforges
{
    "mythic": {
        "strong": 4,
        ...
    },
    ...
}

So like rr = RarityReforges... any idea on what to name this? I'll make another commit changing it

any idea on what to name this? I'll make another commit changing it

maybe "rarityReforgeCounts"
it's a bit long but it is descriptive


Why not just include a guide to installing an ubuntu vm for windows users?

Install oracle VM virtualbox
Download then create an Ubuntu 16.04 VM
Run terminal command Ifconfig to get local address of the VM
Use local address to create proxy

I don't know if this is easier but it should have a 100% success rate.
Awesome app!

Probably easier to just run it in Docker. There are instructions for getting started with Docker on Docker's site.
(I think this issue can be closed)

From the README: "Currently, it is very difficult to get this program working on Windows. Until a fully javascript implementation of protobuf can be utilized, Windows support will not be provided. For the time being, the recommended solution is Docker. If anyone would like to contribution documentation on how to get this project running flawlessly on Windows with Docker, please contact me."
This led to me to assume that the docker method was inconsistent and buggy, so I didn't bother with it. Anyways closing.

That was actually put there when we had JUST added the Docker method. There's still not really any doc on using netsh for Windows, though.


How to run in Mac M2 cpu?

The Google Colab version always got interrupted. So I try to run it locally in my Mac M2 machine.
Based on the document, I run run.sh and got the following error message:

raise ValueError(f'mutable default {type(f.default)} for field '
ValueError: mutable default <class 'fairseq.dataclass.configs.CommonConfig'> for field common is not allowed: use default_factory

Any idea? Is there anybody having experience running RVC in a Mac machine? Thanks.

Same problem on M1 pro machine.

just run infer_webui.py directly in the zsh

Finally I fixed the issue by following the way to install Sovits environment. Here is what I did:

conda create -n rvc python=3.10
conda activate rvc
python -m pip install -U pip setuptools wheel
pip install torch torchvision torchaudio

After this, just run ./run.sh.


Fix issue when running shards on Android (#1853)

Proposed changes
https://github.com/mobile-dev-inc/maestro/blob/53e31b47e43ff7482fe52e26c6d6cb05285bd2fa/maestro-client/src/main/java/maestro/drivers/AndroidDriver.kt#L180-L182
The issue seems to originate in the simultaneous call to blockingStubWithTimeout.deviceInfo in AndroidDriver#deviceInfo() from Maestro#deviceInfo() which causes the following error:
Stacktrace "java.net.ConnectException: Connection refused"

io.grpc.StatusRuntimeException: UNAVAILABLE: io exception
	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:275)
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:256)
	at io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:169)
	at maestro_android.MaestroDriverGrpc$MaestroDriverBlockingStub.deviceInfo(MaestroDriverGrpc.java:634)
	at maestro.drivers.AndroidDriver$deviceInfo$1.invoke(AndroidDriver.kt:182)
	at maestro.drivers.AndroidDriver$deviceInfo$1.invoke(AndroidDriver.kt:181)
	at maestro.drivers.AndroidDriver.runDeviceCall(AndroidDriver.kt:1070)
	at maestro.drivers.AndroidDriver.deviceInfo(AndroidDriver.kt:181)
	at maestro.Maestro.fetchDeviceInfo(Maestro.kt:63)
	at maestro.Maestro.access$fetchDeviceInfo(Maestro.kt:39)
	at maestro.Maestro$cachedDeviceInfo$2.invoke(Maestro.kt:47)
	at maestro.Maestro$cachedDeviceInfo$2.invoke(Maestro.kt:46)
	at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
	at maestro.Maestro.getCachedDeviceInfo(Maestro.kt:46)
	at maestro.Maestro.deviceInfo(Maestro.kt:57)
	at maestro.orchestra.Orchestra.initJsEngine(Orchestra.kt:217)
	at maestro.orchestra.Orchestra.runFlow(Orchestra.kt:107)
	at maestro.cli.runner.TestSuiteInteractor.runFlow(TestSuiteInteractor.kt:250)
	at maestro.cli.runner.TestSuiteInteractor.runTestSuite(TestSuiteInteractor.kt:82)
	at maestro.cli.command.TestCommand$handleSessions$1$1$results$1$1$1.invoke(TestCommand.kt:280)
	at maestro.cli.command.TestCommand$handleSessions$1$1$results$1$1$1.invoke(TestCommand.kt:258)
	at maestro.cli.session.MaestroSessionManager.newSession(MaestroSessionManager.kt:101)
	at maestro.cli.session.MaestroSessionManager.newSession$default(MaestroSessionManager.kt:54)
	at maestro.cli.command.TestCommand$handleSessions$1$1$results$1$1.invokeSuspend(TestCommand.kt:258)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:104)
	at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:111)
	at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:99)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:585)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:802)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:706)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:693)
Caused by: io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/[0:0:0:0:0:0:0:1]:7078
Caused by: java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.pollConnect(Native Method)
	at java.base/sun.nio.ch.Net.pollConnectNow(Net.java:672)
	at java.base/sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:973)
	at io.netty.channel.socket.nio.NioSocketChannel.doFinishConnect(NioSocketChannel.java:337)
	at io.netty.channel.nio.AbstractNioChannel$AbstractNioUnsafe.finishConnect(AbstractNioChannel.java:334)
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:776)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562)
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:1589)

Even though cachedDeviceConfig is lazy which means it's synchronized, it seems that the issue happens because all the calls come from on same thread.
https://github.com/mobile-dev-inc/maestro/blob/f9f4cc864116cc0e843fc64f795dbada2e7c42e2/maestro-client/src/main/java/maestro/Maestro.kt#L46-L48
I added a semaphore in AndroidDevice#runDeviceCall to ensure it can only be called once at a time.
https://github.com/mobile-dev-inc/maestro/blob/95ee50bb1109b4b8bfd61b4e11097a89eaae0c9a/maestro-client/src/main/java/maestro/drivers/AndroidDriver.kt#L1065-L1067
This seems to have fixed the issue. From now on, calls to runDeviceCall will not happen synchronously.
Testing

I removed the workaround by deleting the Thread.sleep and rebuilding
Launched 2 emulators
Ran maestro test --shards 2 flows/ with a folder with around 7 successful flows
I had the issue way more than half the time
Detected the origin of the issue and added the semaphore
Couldn't get the issue again after running multiple times

Issues fixed
Linked #1867
Fixes #1853

Hey @tokou, it seems that this is never starting the test on CI. Any idea?

@bartekpacia No maybe just retrigger it?

I did retrigger, unfortunately the result is the same

@bartekpacia I need some help here. I couldn't repro the issue and don't have access to more details from the CI. So I don't really know what to do next.

Hey, unfortunately I don't have any ideas too (aside from capturing as much log output with adb logcat into some file and then exposing that file as a workflow artifact, and trying to go from there).


React Native suddenly stops firing fetch requests to server

Description
When starting the app everything works fine, networks requests are being fired, and data is being loaded. At certain (unknown) conditions the app suddenly stops loading new data, and most of the time doesn't even send data to the remote server. Instead it gets the mystical error "Network Request Failed".
React Native version:
info Fetching system and libraries information...
System:
OS: macOS 10.15.6
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Memory: 3.66 GB / 16.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 12.18.3 - ~/.nvm/versions/node/v12.18.3/bin/node
Yarn: 1.22.5 - /usr/local/bin/yarn
npm: 6.14.6 - ~/.nvm/versions/node/v12.18.3/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.9.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.0, DriverKit 19.0, macOS 10.15, tvOS 14.0, watchOS 7.0
Android SDK:
NOT RELEVANT
IDEs:
Android Studio: 4.0 AI-193.69<IP_ADDRESS>26763
Xcode: 12.0/12A7209 - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_265 - /usr/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: ~16.11.0 => 16.11.0
react-native: ^0.62.2 => 0.62.2
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps To Reproduce

Fire working fetch request
Fetch request suddenly stops sending to the server.

Expected Results
Fetch request should fire normally
Snack, code example, screenshot, or link to a repository:
There's not too much to it, it's a simple GET request with no headers.

Also experiencing this today with 0.64 and xcode 12 🤔

I'm suffering from same issue. Typically it works fine, but sometimes fetch start to throws "Network request failed" error before communicate with server. App termination and restart doesn't work, but reconnect to router or internet connection make it work. Any one have solution?

I'm suffering from same issue. Typically it works fine, but sometimes fetch start to throws "Network request failed" error before communicate with server. App termination and restart doesn't work, but reconnect to router or internet connection make it work. Any one have solution?

i'm suffering the same issue on ios.
this is stupid and critical error.
fetch is the main lib is required to function almost all react apps.

So a small update on this:
I was able to circumvent the issue by deploying a small proxy backend, so basically instead of communicating directly with the backend I deployed a small DigitalOcean Node.js/Express server that just mirrors the requests to the actual backend. This solved the problem for me. Trying to figure out why.

@petter-kaspersen were you able to find the reason?


v2.2.2 does not update the readings. Question

I upgraded to V2.2.2 yesterday. But in this version, the measured values are no longer updated. If I switch back to V2.2.0 they will be updated again. Do I have to slightly delete and reinstall the integration to get it working. Do I lose the recordings in Grafana.

Same for me, since v2.2.2 no updates of values. Only possibility is to reload manually the device.
Modbus values from Solurfocus software are updated regularly

Thanks for reporting. I'll have a look.

@Vaszago did you only check your HA dashboard, or also on the device section in the settings? Usually, I'd say that if the entities on your dashboard are not grayed out, they should be updated by the integration.
@Vaszago @PhilippRettenmeier are there any logs / error messages from solarfocus integration? The only changes from v2.2.0 to 2.2.2 were regarding the translation keys. In my setup, I did not have to re-install the integration.
@Vaszago I'd assume, you will not loose the recordings in the database you use for Grafana. However, it could be that the entities get renamed (depending on when you last installed the integration). However, Grafana allows to combine multiple entities within one graph, so you could still show them as "one" in Grafana. Or you could even migrate the values in the database, if you feel like it.

Thanks @LavermanJJ for the reply.
I couldn't find any errors in my logfile for the solarfocus integration. As mentioned by @Vaszago, when downgrading to v2.2.0, the values for the Solarfocus entities are updated again... Upgrading to v2.2.2, and the values are not updated again.
Since I am using the values e. g. for Thermal Power to update config sensors (manually calculating the COP & "Arbeitszahl"), I will wait for the next version of the integrations ;)

@PhilippRettenmeier thanks for providing more insights. TBH I have no clue at the moment, why that is happening. As this is a "local_polling" integration, HA regularly triggers the integration to reload the values. Why this is not happening is unclear to me. If it is fine for you, I'd invest my time in finalizing v3.0.0. and not debugging further.
If you want do dig deeper into it, you could activate the debug logs for the integration and check if there are either one of the logs statements:
https://github.com/LavermanJJ/home-assistant-solarfocus/blob/6140137d6f7c6da526efae0d66493185594d042c/custom_components/solarfocus/coordinator.py#L97-L100
that would indicate whether or not HA is requesting the integration to update.
To set the logger see https://www.home-assistant.io/integrations/logger/
should be something like
# Example configuration.yaml entry
logger:
  default: info
  logs:
    custom_components.solarfocus: debug

Fine for me since v2.2.0 is working fine, thanks @LavermanJJ - great job so far!

I am now 21 days on KUR. Can't test at the moment.

I have the same Problem.
Maybe I can help a little bit.
I have a Therminator with 22.021 and 3.0.0-beta4

Modbus TCP send Messages every 30 seconds.
Refreshtime setup is 50 seconds

Refresh in HA is just after a reboot.

Here the last LOG:
2023-05-04 18:45:46.222 ERROR (MainThread) [homeassistant.helpers.entity] Update for select.solarfocus_heating_circuit_1_cooling fails
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 554, in async_update_ha_state
await self.async_device_update()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 784, in async_device_update
await coro
File "/config/custom_components/solarfocus/entity.py", line 128, in async_update
await self.coordinator.async_request_refresh()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 211, in async_request_refresh
await self._debounced_refresh.async_call()
File "/usr/src/homeassistant/homeassistant/helpers/debounce.py", line 95, in async_call
await task
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 237, in async_refresh
await self._async_refresh(log_failures=True)
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 349, in _async_refresh
self.async_update_listeners()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 146, in async_update_listeners
update_callback()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 585, in async_write_ha_state
self._async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 649, in _async_write_ha_state
state = self._stringify_state(available)
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 591, in _stringify_state
if (state := self.state) is None:
File "/usr/src/homeassistant/homeassistant/components/sensor/init.py", line 561, in state
raise ValueError(
ValueError: Sensor sensor.solarfocus_boiler_1_mode provides state value '3', which is not in the list of options provided

in 3.0.0-beta4
the mode range is wrong - but already fixed in the current latest main branch

temporary you can edit this value in Home Assistant using Studio Code Server Addon and edit custom_components/solarfocus/sensor.py
and change 3 to 5

@saschaguilliard Thanks for providing additional logs 👍
I'll create a new beta release

As version 3.0.0 is now finally released, I'll close this issue.


implement rules:[]:when:never

Love
Thank you very much for this great tool that will help me a lot with a few more features 🥰
Request
Description
rules:[]:when:never is not implemented or not as expected, especially for the pattern "launch everytime except a few cases".
Symptom / minimal script
when-never:
  stage: .pre
  image: curlimages/curl:7.69.1
  script:
    - env | sort
  rules:
    - if: $GITLAB_CI
      when: never
    - if: $GITLAB_CI == "false"
      when: never
    - when: on_success

The job is launched an should not be.
Workaround
Description
Change all rules using when:never by a negative equivalent.
Impact

low : needs actions once before/after a debugging session
✅ medium : fixed using another top level .gitlab-ci.yml
high : needs deep refactoring, everywhere in templates or everytime or both

@bcouetil Sounds like a made a bug, if what you write is true.
I shall investigate...

test('https://github.com/firecow/gitlab-ci-local/issues/117', () => {
    const rules = [
        {if: "$GITLAB_CI", when: 'never'},
        {if: "$GITLAB_CI == 'false'", when: 'never'},
        {when: "on_success"}
    ];
    const rulesResult = Utils.getRulesResult(rules, {GITLAB_CI: 'false'});
    expect(rulesResult).toEqual({when: 'never', allowFailure: false});
});

This is the test you want to PASS right ? @bcouetil

I just pushed a commit in #121, sorry :sweat_smile:

@bcouetil Lets keep pears and apple separate :smile:

https://github.com/firecow/gitlab-ci-local/pull/123 @bcouetil Here you go.


Enable Stripe promo codes via config

Stripe have released a feature for applying promo codes to subscriptions.
Ghost should expose (via config) an option to enable this functionality in Stripe. There's an open PR to enable this in Members, but the value is not taken from config.
The config flag (and the allow_promotion_codes flag passed to Stripe) should be disabled by default.

hey @matthanley! i'm interested in helping bring this over the finish line alongside my open PR in the members repo if you're interested - can you give me some guidance re: where to implement this?

@signalnerve check out the docs for config here.
The config module is implemented here, and you can see a usage example (with compress) here.

thanks @matthanley! Finally have some to look at this today. Would it be appropriate to add a bool like enableStripePromoCodes? happy to add documentation too, just want to make sure I'm going about it the right way.

@signalnerve I think we'd pass the config from Ghost core, into the members-api instance. Probably around here: https://github.com/TryGhost/Ghost/blob/master/core/server/services/members/api.js#L144-L146 :relaxed:


Fix #67

Fix #67.
In ClientEventListener security is not used and i remove it.

:+1:
I will try it as soon as possible, thank you @piotrantosik


Optional arguments and typedef properties

This marks a few optional arguments and typedef properties as optional (not the same as type|undefined).
Before:
$ npx tsc | wc -l
    1374

After:
$ npx tsc | wc -l
    1329

Hmm, I see that we use another syntax in other places.  @property {type} [name] instead of @property {type=} name.  I kind of like the latter better but I think we use the former in more places (and it does work better with default values), so I'll update this.


Style of svg tag gets discarded.

I reduced a file generated by Batik to the following minimal example:
<svg style="stroke:black" width="1000" height="1000" >
<line style="fill:none" x1="900" x2="100" y1="100" y2="900" />
</svg>

As interpreted by Inkscape, this contains a visible line. I tried to use this as follows:
import svgutils.compose as sc
sc.Figure( "16in", "16in", sc.SVG("input.svg") ).save("output.svg")

This produces an output.svg with the following content:
<?xml version='1.0' encoding='ASCII' standalone='yes'?>
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" width="16.0in" viewBox="0 0 16.0in 16.0in" height="16.0in">
  <g>
    <g><line style="fill:none" x1="900" x2="100" y1="100" y2="900"/>
</g>
  </g>
</svg>

Here, the line is not visible anymore since the stroke:black style has gone.
I am not sure whether this is a problem with Batik not producing standard-conforming SVGs or a problem with SVG utils.
This issue seems related to it, but the issue as well as the answer are somewhat cryptic.

hi, thanks for the report, indeed we do ignore the style attributes in svg tag, but I am not sure whether style is allowed in <svg> by the the standard.

I am not sure whether style is allowed in <svg> by the the standard.

If I understand this correctly, it is: style is listed amongst the possible attributes of <svg>.

Indeed, thanks for checking. We should probably copy the style attribute from svg tag to the enclosing <g> attribute, something like this should work:
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" width="16.0in" viewBox="0 0 16.0in 16.0in" height="16.0in">
  <g  style="stroke:black">
    <g><line style="fill:none" x1="900" x2="100" y1="100" y2="900"/>
</g>
  </g>
</svg>

https://jsfiddle.net/reco8wy9/1/
Would you like to submit a PR?


Toni's changes to poster

Codecov Report

Merging #129 into master will increase coverage by 13.81%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #129       +/-   ##
===========================================
+ Coverage   83.66%   97.47%   +13.81%
===========================================
  Files           5        6        +1
  Lines         551      555        +4
  Branches      148      148
===========================================
+ Hits          461      541       +80
+ Misses         90       14       -76

Impacted Files
Coverage Δ

contracts/OpenOracleView.sol
50.00% <0.00%> (ø)

contracts/Uniswap/UniswapConfig.sol
98.21% <0.00%> (+19.84%)
:arrow_up:


Update MD file on new branch 2017-11-09_17-31-09

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/content1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[mesheryctl] Issue Converting Helm Chart to Kubernetes Manifest when Importing Design via URL

See mesheryctl Command Tracker for current status of commands.
Current Behavior

The error occurs importing design patterns via URL with mesheryctl pattern import. The issue arises during Helm Chart to Kubernetes Manifest conversion. Importing succeeds with local files.
File link: https://raw.githubusercontent.com/meshery/meshery.io/master/catalog/c40ae08b-deaa-4fc5-a1e8-8081907b64a3.yaml
Desired Behavior

Screenshots/Logs

Environment

Host OS: Mac Linux Windows
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Platform: Docker Kubernetes

Contributor Guides and Handbook

📚 mesheryctl Contributing Guide
📺 Beginner's guide to contributing to Meshery and mesheryctl
⌨ mesheryctl Command Tracker
⌨ Meshery CLI Commands and Documentation
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@MUzairS15

Add links/files that you are trying with.

Add links/files that you are trying with.

Added to the description.

@singh1203 I tested this issue and have the same behavior

After dig in it seems the server only return error 500 will continue investigate and grab more details to see if I could make a fix so that mesheryctl display an error more useful for end user

@saurabh100ni You are using a design file but specifying helm as source type in imports.

So @lekaf974 the issue is that meshsryctl is not handling sourcetype flag correctly.
On local file import if source type specified is helm even then it should fail as we have provided a design file.
will you ensure source type is used correctly.
If source type is other than helm supported options are local imports and remote url imports.
otherwise for helm only remote url imports and if loval file ref is provided it should give appropriate error.

As a next iteration we can support importing helm charts from local files with mesheryctl.


Dark Mode

I looked through the settings and did not see Dark mode. Is this something that can be enabled or potentially road mapped?
Thank you,
Taylor Miller

I see that is at the very on of the start-up message. Thank you

Thank you so much to take the time to respond. Thank you for all the work that you are doing.


Only copy tracked files to containers

@moberghammer Can you try it out on one of your big projects. And paste the rsync timings?

@bcouetil and @moberghammer I'm awaiting rsync measurements from you guys, to make sure we don't impose unreasonable cost to everyone using the tool.

Yes I don't forget, it's just that I have been busy lately. Please don't rush this, it's supposed to gain performance, it should not be otherwise 😊

@bcouetil No rush, adding WIP to pull request

I tested it.
You say untracked, but I guess you mean ignored, because new files get into containers (I was afraid of that, being forced to commit new files, but it is OK).
I loose multiple seconds in the process. But I think we can do better : If I'm not mistaken, you rsync the exact same data to n folders (for n jobs), then copy this to each one.
Either we should :

rsync once, copy each job
rsync each job, simply mount folders

I think I prefer 1., there may be root files in 2.
What do you think ?

Copy takes longer than rsync doesn't it?

Volume mounting will leave root owned files yeah....

Oh, you mean docker copy, not fs copy

Well, we gonna need shell-executor eventually, so having a build folder for each job, will be a requirement soon...

We gonna need shell-executor build folder isolation eventually, so having a build folder per job, will be a requirement soon...

I always forget that, sorry.
So I suggest this algo :
rsync root files to .gitlab-ci-local/builds/.docker/  <-- we are safe because a job cannot start with "."
for each stage
  in parallel, for each job of the stage
    if docker job
      docker cp from .gitlab-ci-local/builds/.docker/
    else
      rsync root files to .gitlab-ci-local/builds/job-name
    fi
    [...]
  end
end

This way, there is only one rsync for docker jobs and one rsync for each shell-job. Most of the time, with only docker jobs, there is only one set of duplicated files.

Elegant.... :smile: On it

@bcouetil It's pushed

Tested it again, this works great 💪
But I had to do multiple ctrl+c in the middle of a stage with 7 jobs, and each time I have this error :

Wouldn't it be better to ignore docker rm errors ?
    public async removeContainer() {
        if (this.containerId) {
            try {
                await Utils.spawn(`docker rm -f ${this.containerId}`);
            } catch (e) {
                // false alarm, deletion is already in progress
            }
        }
    }

Tested it again, this works great
But I had to do multiple ctrl+c in the middle of a stage with 7 jobs, and each time I have this error :

Wouldn't it be better to ignore docker rm errors ?
    public async removeContainer() {
        if (this.containerId) {
            try {
                await Utils.spawn(`docker rm -f ${this.containerId}`);
            } catch (e) {
                // false alarm, deletion is already in progress
            }
        }
    }

Yeah, i'll make an issue on that.
@bcouetil Shall we merge ?


Map with Bootstrap collapse

I'm using this inside a bootstrap collapse. My map is gray (blank but with controls) and I need to action a resize (had this issue before with BS). Can anyone help with using this inside a bootstrap collapse or tab with Angular or this directive?

@ottz0
you need to do $scope.$on('mapInitialized', function (evt, map) { 				console.log("map initialized."); 				google.maps.event.trigger(map, 'resize');                                });
in your controller, or within your collapse callback if there is one, or where ever. This isn't really an issue with ngmap but just javascript google maps in general.

Thank you so much @luncht1me , i have the same problem while using map inside modal. And now it solved.


at_onboarding widget has version compatibility issues with kotlin version and flutter keychain.

Describe the bug
I am trying to use the at_onboarding widget for an app in development, and whenever I try to run the code, I get an error saying android gradle version only supports kotlin version 1.3.40+ despite the fact that all versions are up-to-date.
To Reproduce
Steps to reproduce the behavior:

First I install at_onboarding, at client in my flutter app.
Then I write the code for the onboarding widget.
And then I run the code, and get the error that the android plugin only support kotlin 1.3.40+.

Expected behavior
Code should run without any error, and users should be able to onboard through AtSign.
Screenshots
The Android Gradle plugin supports only Kotlin Gradle plugin version 1.3.40 and higher.  The following dependencies do not satisfy the required version:  project ':flutter_keychain' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.21

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org``

Smartphone (please complete the following information):

Device: Pixel 4 (Used Android Emulator)
OS: Android 12

Were you using an @application when the bug was found?
No, just the onboarding widget.

Similar/duplicate of https://github.com/atsign-foundation/at_client_sdk/issues/586

issue is related to the buzz issue as i have same problem with onboarding widget compatibility and that it wont run on android devices.

When I dig deeper, at_onboarding_flutter has at_client_mobile utilisation in it. And as the error says, flutter_keychain was used in at_client_mobile. So the packages which have at_client_mobile dependency, it throw this error and it will reflect as the package error. So as I already have raised #586 Which is related to it, I marked it as duplicate.


Pyrsia node: don't read from stdin

The pyrsia_node still reads from stdin for what it looks like demo or debugging purposes.
It might not a problem, but the node probably shouldn't do this. All interactions with the node should happen using exposed APIs (at the moment either using the docker client or the CLI client)

@prince-chrismc I talked to Mitali today. She confirmed that she is not using the "peers" command, so we can get rid of that. If @efrisch  confirms that we are not using "magnet", then it can all go.

If @efrisch needed the magnet one then we can move move that too also to message event as we have for peers

I can confirm the problems with running in the background are related to this reading from stdin
I'll await @efrisch's response on the magnet topic: either remove it or convert it to a message

@MitaliBo I think we should convert it to a message event.


Fixes for v10.0.0

As per the v10 upgrade instructions.

Extraneous v9 files have been (manually) removed.
Program.cs updated with the new IHostBuilder APIs.

I've inadvertandly done this myself now in the v3/dev branch so I'll close this off.


[Visual requirement-Command Palette]-Luminosity ratio is 4.046:1 which is less than 4.5:1 for the shortcut text appended to the Commands.

User Experience:
Vision impairment users will not be able to view the text clearly if the Luminosity ratio is less than 4.5:1 .
Test Environment:
App: Windows Terminal Preview
Feature: Command Palette
OS: Win 10 2004 Build (19041.508)
Repro Steps:
1.Open Windows terminal Preview app
2.Open Command Palette using shortcut (Ctrl+shift+p)
3.verify the Luminosity ratio for shortcut text.
Actual:
Luminosity ratio is 4.046:1 which is less than 4.5:1 for the shortcut texts appended to the commands.(For Example: Luminosity ratio of Close pane command shortcut text Ctrl+Shift+W is 4.04:1 )
Expected:
Luminosity ratio should be greater than 4.5:1 for the short cut texts which are appended to the commands

Yep this is reasonable. I bet we could make the background of the keys even darker (in dark mode) relative to the cmdpal background, and that'll probably look good.

I’m going to work on this

This issue was fixed in #7937 and deployed to production in November.

This issue was fixed in #7937 and deployed to production in November.

@awalia13 / @DasaradhaKamjula If this is confirmed as fixed, can we close this issue now?

@Chandresh1007  If this is confirmed as fixed, can we close this issue now?

Issue is fixed. Verified on Windows terminal version: 1.8.1521.0 and OS version: Win 10 build 21390.2025. Hence, closing the bug.


Action interface sanity check doesn't actually confirm that trajectory start and current postion agree

The comments (and technical report) allude to the driver checking new trajectories for sane values however it is currently possible to send trajectories in which the trajectory's start does not agree with the robot's current position.
The issue seems to be with the if check in line 332 of ur_ros_wrapper.cpp
This can be replicated using the URSim with the driver along with RViz MoveIt! plugin with the following steps:

launch simulator, ur_modern_driver, and Rviz/MoveIt!
drag the goal some significant distance from the initial state and click Plan
confirm the plan is valid and then click Execute (Robot executes plan as expected)
without adjusting the goal state click Plan again (generates plan from original/initial state)
click Execute (plan is sent despite differing start positions, resulting in a protective stop in URSim)

-- Note: using Execute and Plan seems to use current robot position as the start state instead of the previously set start state via the Query GUI.

I believe this was fixed by your pull request, so I'll close this issue.


Project cleanup: workspaces, headers, imports, oh my!

Lo! I think I've gotten this to a point where the project/workspace integration doesn't drive me insane. A brief rundown:

KKGridView project: new settings for public headers dir and installation dir (tweaked to make archive build work)
GridViewDemo project (and any other host project): you don't have to specify your header search paths anymore. Not even joking.
Now, you import stuff as if it were a framework: #import <KKGridView/KKGridView.h>.
Made Definitions.h public, since it's getting used in other exported headers.

This works great on my end running on the latest public release of Xcode 4.2.

<3

At some point, I should probably add some documentation to the README on this. Everyone is so used to getting raped by Xcode workspaces that they probably own't be able to comprehend how simple this is…

Indeed.  We should probably add screenshots as well and a copy of the reader on the wiki.
Sent from my iPhone
On Oct 17, 2011, at 3:12 PM, Jonathan<EMAIL_ADDRESS>wrote:

At some point, I should probably add some documentation to the README on this. Everyone is so used to getting raped by Xcode workspaces that they probably own't be able to comprehend how simple this is…
--
Reply to this email directly or view it on GitHub:
https://github.com/kolinkrewinkel/KKGridView/pull/45#issuecomment-2435514


please don't open blank issues to get badges.

it's considered spam. open them in your own repos if you want to, please.

Opening an issue in your own repo and closing it does not work anymore.

It does work! I tried it and I did for myself as well

what batch do we get ?


ScrollContainer's scrollbar visibility is now enum

As discussed in #48008, this PR changes ScrollContainer's scroll bar visibility and enabled to an enum:

Also I cleaned up some code. I don't know why in some places the scroll bars were explicitly set to enabled, even though that's a default.

Thanks!


Can't execute two auth in parallel

Can't execute two auth in parallel
Currently I am trying to login with facebook but i got error " Can't execute two auth in parallel" .
how can I solved this issue.
Please help me urgent.

@chetan1011 we have made a large number of changes to the App in the last few months. Please can you update to the newest version and check if the problem still persists. If it does then please re-open this issue.


Issue 60

this branch added functionality to get the gpp string (issue #60)
some sites that have gpp for testing: sites_w_gpp.xlsx

The command to create the sql table is: CREATE TABLE entries (id INTEGER PRIMARY KEY AUTO_INCREMENT, site_id INTEGER, domain varchar(255), dns_link BOOLEAN, sent_gpc BOOLEAN, uspapi_before_gpc varchar(255), uspapi_after_gpc varchar(255), usp_cookies_before_gpc varchar(255), usp_cookies_after_gpc varchar(255), OptanonConsent_before_gpc varchar(800), OptanonConsent_after_gpc varchar(800), gpp_before_gpc varchar(4000), gpp_after_gpc varchar(4000));

The command to create the sql table is

Great! @katehausladen, can you put that into the readme? Maybe, a new section or under a current one. "The crawler relies on a database ... This is how you set it up ... ."

Yes, I'll update the wiki once this gets merged

Everything looks good on my end, I'll go ahead and merge


Issue at container connection : Provided user was not an "AzureUser"

Describe the bug
We have integrated fluid framework into our platform, as soon as 2 different users try to connect the same container id, we get an error at the getContainer level : Provided user was not an "AzureUser".
We are using an Azure Fluid Relay and the InsecureTokenProvider.
Our front-end is based on Angular v16 and we are using :

fluid-framework: 2.0.0-rc.1.0.3
fluid-experimental/data-objects: 2.0.0-rc.1.0.3
fluidframework/azure-client: 2.0.0-rc.1.0.3
fluidframework/test-runtime-utils: 2.0.0-rc.1.0.3

To Reproduce
To reproduce this issue, we only have to connect the same container with 2 different accounts and sometimes with the same account on different chrome tabs.
Expected behavior
It's obvious, but be able to have multiple users connected to the same container.

A recent change in FRS caused the id and name fields of the IUser to be removed from the quorumMembers snapshot.
1.x clients are generally unaffected, since the Audience was always completely recreated from initialClients. This meant the faulty quorumMembers were never seen by the ServiceAudience. In 2.x the Audience now retains the quorumMembers (as of #12094), so the ServiceAudience does see these faulty members and hits these asserts.
We have made changes #20131 as a minimal mitigation to unblock load on 2.x clients while the service-side fix is made. Once the fix is in, we'll restore these checks to their stronger form.
Please try the release Fluid Framework v2.0.0-rc.2.0.0 and let us know if you see any issues.


Issue56 hard fork hf26

Testing against Hive post HF26

Fixes #56

I've done extensive testing of this release against the post HardFork HF26 version of Hive using the dedicated fakenet APIs.
This update also includes a new test which looks for and uses a fakenet/testnet if one exists and performs at least one test on it.


Nginx exited after restart

Hi,
after first start everything is ok, but after restart containers exited with error:
nginx: [emerg] open() "/etc/nginx/vhost.d/default" failed (2: No such file or directory) in /etc/nginx/conf.d/default.conf:41.
I used docker-compose.yml from examples for v1: https://github.com/fatk/docker-letsencrypt-nginx-proxy-companion-examples/blob/master/docker-compose/v1/simple-site/docker-compose.yml
Could you tell me what is wrong?
Thanks

Hi, actually I'm getting the same error as well recently. I found that default.conf is pointing to another non existing .conf. Deleting it before starting again seems to resolve this issue. I've yet to dig deeper.

The first time the nginx container starts, /etc/nginx/conf.d/default.conf contains default configuration from the nginx image, and starts up successfully.
/etc/nginx/vhost.d/default is later created by letsencrypt-nginx-proxy-companion, and if that file exists while docker-gen parses the template to regenerate /etc/nginx/conf.d/default.conf, the following line gets added to the newly-generated server block:
    include /etc/nginx/vhost.d/default;

When letsencrypt-nginx-proxy-companion stops, /etc/nginx/vhost.d/default is removed, but the previously-generated /etc/nginx/conf.d/default.conf is left in place. The next time the nginx container is started, the include directive still exists, but /etc/nginx/vhost.d/default no longer does, so nginx fails to start.
docker-gen does notice when letsencrypt-nginx-proxy-companion is stopped, so it eventually regenerates a /etc/nginx/conf.d/default.conf without the include, but when both letsencrypt-nginx-proxy-companion and docker-gen are stopped in rapid succession, the regeneration doesn't have a chance to take place.
Since nginx starts fine with no /etc/nginx/conf.d/default.conf at all, and the file will get regenerated anyway within a few seconds of letsencrypt-nginx-proxy-companion stopping (if only that one container is being stopped), might it be helpful to automatically remove /etc/nginx/conf.d/default.conf in addition to /etc/nginx/vhost.d/default when letsencrypt-nginx-proxy-companion is stopped?

+1

Same issue here. I have to delete nginx, nginx-gen before a restart (up > down > up). Please let me know if I can help with debuging. I can share my docker-compose files (edited)

+1

@JrCs The fact that the nginx container can start outside of the control of the nginx-gen container seems error-prone to me.  I'd much rather see nginx (or some plugin) be able to evaluate a script to generate the config each time it runs, much like a lot of JS tools now use JS files for config instead of JSON.

For instance: https://www.nginx.com/blog/launching-nginscript-and-looking-ahead/

i'm still having this issue.
system reboot, nginx-proxy starts up with .vhost.d/default missing, let'sencrypt-companion comes back up and now all the certs disappear, i think because on restart it wants to regenerate them, however without the existing ones nginx-proxy is now running without the certs and lets encrypt fails well/known with too many requests and your down for hours after that.
I can't figure this one out.