host.lima.internal should be defined inside running containers

A note though - host.lima.internal should be defined inside running containers. That's what docker desktop has always done, it provides that name resolution. People don't really want to get to the host just from inside the lima container, they want to get to the host from inside containers they're running.
Originally posted by @rfay in https://github.com/lima-vm/lima/discussions/389#discussioncomment-1855625

I thought this would already work automatically, but I can see how this might fail on non-systemd setups (Alpine) when e.g. coredns just forwards DNS queries to the nameserver from /etc/resolv.conf, which in this case would forward to the host resolver and not the guest resolver.
@rfay Did you observe this issue with Alpine (e.g. Rancher Desktop or the latest colima), or also with other guests?

RFC https://github.com/containerd/nerdctl/issues/355

Yeah, same thing on colima: you see host.lima.internal resolved inside colima ssh but not inside a running container.
Docker Desktop has always provided this name resolution (for host.docker.internal of course)
On linux ddev figures out the correct host IP address from docker inspect bridge, but that doesn't seem to work with lima.
I'm just running any old Debian container,
docker run debian:buster ping -c 1 host.lima.internal
ping: host.lima.internal: Name or service not known

I'm just running any old Debian container,

Yes, but what is the guest OS? I think colima used to use Ubuntu but has switched to Alpine (or is just about to make the switch). My questions is if this happens even when the guest runs systemd-resolved, or not?

The guest OS here is debian the way I think about it. Host is macOS arm64. But colima ssh gives "Alpine Linux 3.14.3". It's a confusing world where you have two levels of host.

I would use this terminology:

host: macOS
guest: Alpine
container: Debian

Anyways, you have confirmed that you observe the issue on an Alpine guest. I still think it should work correctly on any systemd-based guest:

on Alpine /etc/resolv.conf points to a nameserver running on the macOS host. That means any names defined in /etc/hosts in the guest are invisible

with systemd, the nameserver points to <IP_ADDRESS>, which is implemented by systemd-resolved. It will try to resolve names inside the guest (so can see /etc/hosts, but still forwards DNS to the server on the macOS host.

At least that's what I think is going on, so we need a solution just for the Alpine use case, which doesn't have systemd.

And, just checked on Rancher Desktop, it's also Alpine 3.14.3. Same issues.

RFC containerd/nerdctl#355

I'm not convinced about this proposal, as it would only work for nerdctl. E.g. it would not work for k8s because coredns would just delegate DNS lookup to the nameserver from /etc/resolv.conf. Would the feature be useful for nerdctl outside the context of lima?
I rather think that the lima DNS forwarder needs to know about the /etc/hosts names and resolve them internally.
We could do this by forwarding the names via the guest agent, but I think it would be simpler to add a hostnames section to lima.yaml:
hostnames:
# - host.lima.internal (always defined)
- host.docker.internal
- my-custom-hostname

I don't know if there is a valid use case for adding other local names with fixed IP addresses to the guest. I would argue they should be added on the host and then will work automatically. This mechanism is only for adding aliases for the host inside the guest.
If the internal DNS server can resolve them, then we also no longer need to add them to /etc/hosts inside the guest at all.

This mechanism is only for adding aliases for the host inside the guest.

I just realized that we might still want to define additional aliases for external IP addresses provided via vmnet, so the mechanism needs to be more flexible. Will think through this at a later time.

Did https://github.com/lima-vm/lima/pull/650 fix this?

Did #650 fix this?

Thanks for the reminder, it does indeed fix this issue, so I'm going to close this.

I just realized that we might still want to define additional aliases for external IP addresses provided via vmnet, so the mechanism needs to be more flexible. Will think through this at a later time.

I'm not sure why I thought we might want this. #650 doesn't provide any names for additional interfaces, but it defines the hostname (lima-$INSTANCE) with SLIRP IP of the instance itself (<IP_ADDRESS>).

host.lima.internal is there now, but really host.docker.internal should be there for compatibility. Seems a shame to skip that.

host.lima.internal is there now, but really host.docker.internal should be there for compatibility. Seems a shame to skip that.

You can easily do this yourself, and it is defined for examples/docker.yaml. Both colima and Rancher Desktop define it as well.
Not sure why it should be defined for other configurations.

Yes, ddev automatically adds host.docker.internal already, but AFAIK neither colima nor Rancher Desktop do it (I just tested with colima, it doesn't, haven't tested with Rancher Desktop in the last few weeks). It's a shame to just add a one-off like host.lima.internal when host.docker.internal has been the standard for years.

neither colima nor Rancher Desktop do it (I just tested with colima, it doesn't, haven't tested with Rancher Desktop in the last few weeks).

It is my understanding that both colima and Rancher Desktop add host.docker.internal in /etc/hosts already, but that is not available inside containers when using the host resolver. This new mechanism makes it possible to add arbitrary names to the host resolver, so they resolve both inside the guest and inside containers. It will require new releases to make use of this feature.

t's a shame to just add a one-off like host.lima.internal when host.docker.internal has been the standard for years.

I fail to see the issue. lima is a general tool providing Linux VMs. Why does it need to include special settings for Docker Desktop compatibility even in VMs that are unrelated to Docker? It is a tool that provides the generalized capabilities, and other tools built on top of it (like colima and Rancher Desktop) can add whatever specializations they want (like installing moby and defining host.docker.internal).
It is really trivial to do, and you can even do it yourself in a $LIMA_HOME/_config/override.yaml file with:
hostResolver:
  hosts:
    host.docker.internal: host.lima.internal

This should work right now with current releases of lima and colima and will define the alias in all your instances under that $LIMA_HOME.

You're the maintainer, of course, but loads of existing code and docs point out "host.docker.internal", and lima is a replacement for docker, so in many ways it makes sense for it to provide compatibility. It does in many, many other ways, so much be a priority.
Yes, I think that "host.docker.internal" may be there but not inside a running container, which is the only place (that I know of) that it's useful.
Again, ddev, which I maintain, has had to add host.docker..internal itself on linux for years, so I added it for colima/lima/rancher deesktop, no big deal. The point is, when aiming for compatibility as a design goal, which lima has done wonderfully, this is the small stuff and easy to do.

Hi @rfay, I just realized that one reason I was pushing back here is that you kept repeating "it is a shame", a condemnation of a moral failure on my part, which was taking me aback:
It is a shame when a country is unwilling to protect its children from being murdered at school. But this issue is more akin to your favourite restaurant not providing a plastic straw with your soft drink unless you explicitly ask for it. The restaurant has a reason for the policy, and while you may not agree with the reasons behind it, the policy is not a moral failure of the restaurant. It is just an inconvenience to you. You still get your straw, free of charge, you just have to ask for it. No need for moral judgement and shaming...
Maybe I'm overly sensitive to this (and there is a wider context beyond software behind this, but I don't want to go into it here), so back to technicalities:

lima is a replacement for docker

As I wrote before, lima has a much wider purpose than being a replacement for docker. E.g. one could consider it a replacement for vagrant, and your request is more like asking that vagrant should unconditionally inject host.docker.internal into each VM it manages.

Yes, I think that "host.docker.internal" may be there but not inside a running container

This is not correct:
$ limactl start examples/docker.yaml
? Creating an instance "docker" Proceed with the default configuration
[...]
$ docker info | grep Name:
 Name: lima-docker
$ docker run --rm busybox ping -c 1 host.docker.internal
PING host.docker.internal (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: seq=0 ttl=254 time=0.568 ms
[...]

For colima and Rancher Desktop you will need new releases before you see this working.
So the only thing that remains is the request that users of containerd/podman/aptainer, or just plain Linux VMs also all get host.docker.internal pre-configured.
I continue to fail to see the need and don't really think we have to promote the docker name outside the docker context, but I also don't see much harm in defining it either.
So if @AkihiroSuda agrees with you that we should globally define this alias in the lima core, then I will create a PR for it.

So if @AkihiroSuda agrees with you that we should globally define this alias in the lima core, then I will create a PR for it.

No 😛

@jandubois thanks for letting me know about your reaction.

I just realized that one reason I was pushing back here is that you kept repeating "it is a shame", a condemnation of a moral failure on my part, which was taking me aback

I've never heard of that reaction to the phrase "it's a shame" or "what a shame". To me that's a "transparent metaphor" which has nothing at all to do with shame. It's not transparent for me any more though! I appreciate you letting me know how it affects you.
At a note of my own background reaction to this issue... I was subscribed to the docker (linux) issue about adding resolution of host.docker.internal for all those years, which is still running and still confusing people. As you know, I worked around the lack years ago for linux (and now Lima) but wow, has there been so much angst and confusion about that over many years.
Lima is a wonderful project with oh-so-responsive maintainers. My hope is that it can grow and mature with good governance and without using up the maintainers.
Do you plan to do GitHub Sponsors or another way to financially support the project? ddev has recently set up GitHub Sponsors and one of the stated goals is to send 10% to upstream projects, and Lima would be an obvious target.

I've never heard of that reaction to the phrase "it's a shame" or "what a shame". To me that's a "transparent metaphor" which has nothing at all to do with shame.

Thank you for letting me know; I guess I've been misunderstanding the phrase. In my mind in the bad-worse-worst transition it worked like "it is unfortunate", "it is a disgrace", "it is a shame". I'm going to remember that it doesn't necessarily have the literal meaning. Sorry for the misunderstanding!

Do you plan to do GitHub Sponsors or another way to financially support the project?

I can't speak for @AkihiroSuda, but personally I'm not looking for support and would refuse it, if offered: I work for SUSE on Rancher Desktop, and probably 80% of what I do for Lima could be considered in support of it, so I'm already being paid for my work. If anything would be setup for Lima, then I would not want to be involved in the administration of it either.

I didn't know you were paid for your work, but appreciate the work and its quality, and Rancher's support of it! It's such a delight to work with responsive maintainers. Anyway, Lima is a great upstream for ddev now, and lots of people are trying to get farther away from Docker Desktop of course, so it's great for them. And this looks like it will get better all the time.


Added portfolio for Marcus

Add Marcus Chen portfolio
MarcusChen.adoc

Pull Request Test Coverage Report for Build 72

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.925%

Totals

Change from base Build 70:
0.0%

Covered Lines:
1575

Relevant Lines:
1833

💛  - Coveralls


Rendering issue: ? is invisible while typing.

Bug reports
Expected Behavior
? have to be rendered properly.
Current Behavior and Steps to Reproduce
? is invisible while typing. You can see on a following GIF.

Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Operating System: macOS 10.12.6
Terminal Emulator: iTerm2
tag of go-prompt or commit revision: 7c05c0763ad15c362f3636e02624e84b2a43c902

reproduced it on my ubuntu 17.10 at the same revision (tmux on gnome-termianl)


On hovering link must be highlighted.

Improvement: The username field link is not highlighted, it must be highlighted (The color of the link must be changed when the user hovers the cursor on it).
Note: Highlighted color should match according to the theme of the website.

assign it to me

i can help

I can do this

@niteshjitender Hey i can do this work

assign it to me

Hi @grawish
Assigning this issue to you. Please raise PR after completing this.
Don't forget to give a start. 😉
Thanks & Regards
Jitender Singh Chhapola

Hi @patil-prathamesh, @shreyas20003
These issues are assigned already. If you have any ideas for improvement or want to implement any new feature or encountered any bugs in the website. Please feel free to raise an issue. And have an eye on the issue section there may be any new issue raised that you can resolve.
Thanks & Regards
Jitender Singh Chhapola

Can you please assign it to me.? Thanks!

Hi ,Can you assign this issue to me please?


Last update cc73d38...afb438e


pose_transformer_v2 (BERT style transformer) use while running model on video

In the run tracking demo on videos, the paper mentions that the BERT-style transformer model(pose_transformer_v2) enables future predictions and amodal completion of missing detections within the same framework.
However, in the PHALP.py script, after running the (pose_transformer_v2), its output is deleted at line 260(in PHALP.py), and I can't find the model output/values used anywhere.
Where exactly does the code utilize the pose transformer v2? Is it involved in the rendering process?

The pose transformer is used to predict future poses for each tracklet (and compare them with the detected poses when doing identity tracking). These future poses are not visualized. Currently, we only visualize the single-frame estimates from HMR2.0.

Thanks for clarifying!

Has there been any work done to evaluate the performance of this pose_transformer_v2(BERT style transformer)?
I have looked into the LART paper but the transformer model looks different from 4D-Humans.


Feature - build dependencies without executing local project src/main/java folder

Hi,
I have the issue that when i want to build the objectiveC sources from the java third party libary sources in my parent.pom file the execution fails because in my parent project is no src/main/java directory.
My goals is to build all third party dependencies in the parent.pom once without running j2objc  for the local src/main/java directory. So maybe someone can add a additional flag for that issue because i am not familiar with forking this project and uploading the plugin to the central maven repository.
If there is already a solution for my issue, please let me know.

Hi @shutter92 ,
could you please try to specify sourcePath param, be default it points to /src/main/java and you can put any path you want

Hi thanks for the fast reply, but my problem is that I want to say the plugin that it should skip searching for the src/main/java directory. If I leave it blank or don't specify it, it always searches for the the default maven path. So my goal is to skip searching for the path in my parent pom file and then compile the sources of the third party libs with this plugin.

Ok, now I see. Can't you just create an empty project and specify dependencies in pom file? Did you try it already?

@shutter92
I pushed 1.1.4-SNAPSHOT contains new dependenciesOnly param. Default is false, could you try it please?

I didn't tried it with an empty project but it should work. In my opinion this is not the best solution to fix the use case.
Thanks I will try it later.

@vicmosin
It works for me. Thanks a lot:)


fix: 修复数据导出时列头被格式化 close #2688

👀 PR includes

🐛 Bugfix

[x] Solve the issue and close #2688

📝 Description

  meta: [
    { field: 'area', formatter: (v) => `${v}-#` },
    { field: 'city', formatter: (v) => `${v}-@` },
    { field: 'number', formatter: (v) => `${v}-$` },
  ]

🖼 Screenshot

Before
After

🔗 Related issue link

🔍 Self-Check before the merge

[ ] Add or update relevant docs.
[ ] Add or update relevant demos.
[ ] Add or update test case.
[ ] Add or update relevant TypeScript definitions.

Codecov Report
Attention: Patch coverage is 86.36364% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.05%. Comparing base (ecdc9c8) to head (5448361).
Report is 333 commits behind head on next.

Files
Patch %
Lines

...-core/src/utils/export/copy/base-data-cell-copy.ts
83.33%
0 Missing and 1 partial :warning:

...core/src/utils/export/copy/pivot-data-cell-copy.ts
83.33%
0 Missing and 1 partial :warning:

packages/s2-core/src/utils/export/method.ts
75.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2694      +/-   ##
==========================================
+ Coverage   75.77%   80.05%   +4.28%
==========================================
  Files         257      176      -81
  Lines       11994    10090    -1904
  Branches     2464     2312     -152
==========================================
- Hits         9088     8078    -1010
+ Misses       1398      620     -778
+ Partials     1508     1392     -116

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:tada: This PR is included in version @antv/s2-v2.0.0-next.19 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Translation Request: This Page in Your Language

Hello!
ja: @bobstrange @DuGlaser @sasurau4 @Quramy
es: @KingDarBoja @fanyCaz
zh: @Kingwl @laosb
pt: @khaosdoctor @alvarocamillont  @danilofuchs
I have just added a new feature which kinda requires translating. Normally I do not want to make requests about translations, which is why English fallback is totally OK in my mind. For this feature though, I really do need to have it translated for anything to make sense. Sorry!
In #802 I added a popup when you are on a page which is not your browsers language, and there is a native version.

There are two design elements:

"In En" in the top nav
"This page is available in English" at the bottom

So, I am on a Chinese page, but my browser is in English, so it offers the English page.
However, if I were on a Spanish page on a Japanese browser, the link would redirect correctly but the text would say "Available in English" right now! 😸 This makes it very weird.
Can you add the equivalent to this file: /packages/typescriptlang-org/src/copy/inYourLanguage.ts
So, for Portugese it would look something like:
export const inYourLanguage: Record<
  string,
  { body: string; open: string; cancel: string; shorthand: string }
 > = {
  en: {
    shorthand: "In En",
    body: "This page is available in English",
    open: "Go",
    cancel: "Don't ask again",
  },
+  pt: {
+    shorthand: "Em Pt",
+    body: "Isso pagina tem em Portugues",
+    open: "Avancar",
+    cancel: "Nao pergunte novamente",
+  },
}

You should be able to see it in action at:

https://www.staging-typescript.org/zh
https://www.staging-typescript.org/pt

Sure, glad to help with this task 🚀

Sure! I will create a PR for the Portuguese version

Just a note, @orta: The don't ask again button may overflow depending on the translation:

I'll improve the layout, thanks @danilofuchs  - who knows if German could ever fit into a space like that
Thanks everyone! - I'll keep this open till I fix the layout issue


[T5A3][W11-B4] Charlton Lim

Ready for review. Will tryout more UI stuff once I learn more about Javafx


Update electron-builder deps

CI is green for PR but macOS travis fails when I merge them. Try to updatethe builder deps to see if it is enough.
PS1: squirrel-windows is deprecated
PS2: package.json is modified because was autoindented because it is how npm 3 --save works.

if it is enough

I was optimistic...

I added GH_TOKEN env variable on CI systems and now they are green.


Updated german translation for v.0.15.9

Adresses  #306
Check if this PR fulfills these requirements:

[x] My changes respect the Kodi add-on development rules
[x] I have read the CONTRIBUTING document.
[x] I made sure there wasn't another one Pull Requests opened for the same update/change
[x] I have successfully tested my changes locally

Types of changes

[ ] New feature (non-breaking change which adds functionality)
[ ] Feature change (non-breaking change which change behaviour of an existing functionality)
[x] Improvement (non-breaking change which improve functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Update of the german translation (see #306)

it is good thanks!


add cython dep to setup.py

Looks like this fixes the vanilla install (as referenced in #220). Might also be worth adding a warning about missing Cython in setup.py too, rather than just catching the ImportError and carrying on... what do you think?

A couple more changes.. To build correctly on macos seemed to require the addition of a pyproject file to specify cython as a build dep. Also changed the Extension params as got a warning about include not being a valid parameter.
With this branch it now installs and builds a wheel correctly on both MacOS and windows.

We currently rely on internal CI systems which only run code we've pushed - so I've created a new version of this PR in #222


remove cluster components store and use global components

Describe the Bug
remove cluster components store and use global components
Versions Used
Kubernetes:
Kubeclipper:
Environment
How many nodes and their hardware configuration:
For example: CentOS 7.5 / 3 masters:  8cpu/8g; 3 nodes: 8cpu/16g
(and other info are welcomed to help us debugging)
How To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.

/milestone v1.1.1


"meta traits" or combining traits into one

I need to create a trait which is a combination of other traits. I tried doing something like this:
export default Factory.extend({
  'traitOne': trait({
    // ...
  }),
  'traitTwo': trait({
    // ...
  }),
  'allTraits': trait('traitOne, 'traitTwo')
});

...however, that did not work. Is there a way to define a trait which is a combination of multiple traits ("meta trait")?

Currently there is not, for now I would suggest writing a reusable function. I've added a card to the Roadmap if anyone can take this on. The API should look like
export default Factory.extend({
  traitOne: trait({
    // ...
  }),

  traitTwo: trait({
    // ...
  }),

  allTraits: trait('traitOne, 'traitTwo', {
    some: 'override'
  })
});

Closing for now because I'm trying to keep the issue list actionable, but please work on this if you have time!


Report error message in helm when required configs are not set

https://github.com/ArroyoSystems/arroyo/issues/611

@mwylde  Please help me review

Thanks, this is great!


(Modal/Alert Dialog/Menu/Select/Popover) are render behind the screen that set the stack screen presentation to "modal" using expo router

Description
I have a screen called create.js that sets the presentation on the screen option to "modal". Now, within this screen, I'm attempting to incorporate a (SELECT/MODAL/ALERT DIALOG/POPOVER) components on this screen. The mention  components above are rendered behind the create.js screen. I've attempted to resolve this by setting the z-index of those components to the highest value, but it still renders behind the create.js screen. Even utilizing a custom modal to create a custom select doesn't solve the issue, as it also appears behind the create.js screen, which is configured with the stack screen option representation set to "modal".

Please refer to this if the image did not display which a screenshot illustrating the problem: https://kargax-qat-bucket.s3.ap-southeast-1.amazonaws.com/drivers/J09BykLmqF6i1jWVkdovja73c75JEaUDgV0nO8bc.png
CodeSandbox/Snack link
No response
Steps to reproduce
Structure
|-- root/
|    |-- app/
|        |-- _layout.tsx
|        |-- create.tsx // <---- this is the screen where i set the stack screen option presentation to "modal" (see the code below)

_layout.tsx code
function RootLayoutNav() {
    const colorScheme = useColorScheme();

    return (
        <GluestackUIProvider config={config}>
            <OverlayProvider>
                <Stack>
                    <Stack.Screen name="(tabs)" options={{ headerShown: false }} />
                    <Stack.Screen
                        name="create"
                        options={{ headerShown: false, presentation: 'modal' }}
                    />
                </Stack>
            </OverlayProvider>
        </GluestackUIProvider>
    );
}

gluestack-ui Version
1.0
Platform

[X] Expo
[X] React Native CLI
[ ] Next
[ ] Web
[ ] Android
[X] iOS

Other Platform
*Emulator
Additional Information
No response

Hey @leouie28, our Devs are looking into the issue.

Hey @leouie28, currently all the overlay components use context based portal. In this case expo uses NativeModal which will always comes on top. We are finding solutions to resolve this.
for now you can use useRNModal prop which will render component inside RNModal so it comes on top.
PS:- Multiple Modal is not support in this case. Also Toast doesn't support RNModal.
export default function ModalScreen() {
  const [showActionsheet, setShowActionsheet] = React.useState(false);
  const handleClose = () => setShowActionsheet(false);
  return (
    <View style={styles.container}>
      <Center>
        <Button onPress={() => setShowActionsheet(true)}>
          <ButtonText>Open</ButtonText>
        </Button>
        <Actionsheet isOpen={showActionsheet} onClose={handleClose} useRNModal>
          <ActionsheetBackdrop />
          <ActionsheetContent>
            <ActionsheetDragIndicatorWrapper>
              <ActionsheetDragIndicator />
            </ActionsheetDragIndicatorWrapper>
            <ActionsheetItem onPress={handleClose} isDisabled>
              <ActionsheetItemText>Delete</ActionsheetItemText>
            </ActionsheetItem>
            <ActionsheetItem onPress={handleClose}>
              <ActionsheetItemText>Share</ActionsheetItemText>
            </ActionsheetItem>
            <ActionsheetItem onPress={handleClose}>
              <ActionsheetItemText>Play</ActionsheetItemText>
            </ActionsheetItem>
            <ActionsheetItem onPress={handleClose}>
              <ActionsheetItemText>Favourite</ActionsheetItemText>
            </ActionsheetItem>
            <ActionsheetItem onPress={handleClose}>
              <ActionsheetItemText>Cancel</ActionsheetItemText>
            </ActionsheetItem>
          </ActionsheetContent>
        </Actionsheet>
      </Center>
      <StatusBar style={Platform.OS === "ios" ? "light" : "auto"} />
    </View>
  );
}

@Viraj-10  currently working on my solution for this issue, i might create a pr if get luck experimenting solutions.

@leouie28 Looking forward to your contribution!


No install target in v1.1.1 [5654]

When attempting to install the client, or when attempting to build the micro generator (which installs the client), I get a "No rule to make target `install'. Stop." This doesn't seem to be an issue with the previous v1.0.2 release that I was using.
Starting process 'Gradle Test Executor 4'. Working directory: /Micro-XRCE-DDS-Gen Command: /usr/lib/jvm/java-1.8.0-openjdk-<IP_ADDRESS>.b04-0.el7_6.x86_64/bin/java -Dbranch -Djava.security.manager=worker.org.gradle.process.internal.worker.child.BootstrapSecurityManager -Dorg.gradle.native=false -Dfile.encoding=US-ASCII -Duser.country=US -Duser.language=en -Duser.variant -ea -cp /root/.gradle/caches/4.10.2/workerMain/gradle-worker.jar worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Test Executor 4'
Successfully started process 'Gradle Test Executor 4'

com.eprosima.uxr.integration.MicroXRCEDDSGenIntegrationTest > runTests STANDARD_OUT
    Executing command: mkdir -p build/test/integration
    Executing command: rm -rf Micro-XRCE-DDS-Client
    Executing command: git clone -b master https://github.com/eProsima/Micro-XRCE-DDS-Client.git
    Executing command: mkdir build
    Executing command: cmake .. -DTHIRDPARTY=ON -DCMAKE_INSTALL_PREFIX=install
    Executing command: make install
    make: *** No rule to make target `install'.  Stop.

com.eprosima.uxr.integration.MicroXRCEDDSGenIntegrationTest > runTests SKIPPED

> Task :test FAILED
:test (Thread[Task worker for ':',5,main]) completed. Took 2.748 secs.

FAILURE: Build failed with an exception.

Hi @raveious,
I've opened a pull request in Micro XRCE-DDS Gen that should fix this bug.


chore: make sentry optional and add webpack plugin to upload sourcemaps

Interbtc UI Pull Request Template
Description

Add a brief description

Current behaviour (updates)

Please describe the current behaviour that you are modifying

New behaviour

Please describe the behaviour or changes this PR adds

Reproducible testing steps:

Please list all testing steps required for the reviewer to test this specific issue. Consider regressions and edge cases.

Closing this one—we'll look at adding sentry (alongside other tools) as part of the upcoming UI testing work


Smart completion - Support editing context-path of the uris

Currently we only support URI parameters, eg (foo=bar&me=you).
However the Camel endpoints have the context-path part which we can have smart completion / code assistance for. This is a bit more tricky because each component can have a bit different syntax of the context-path (some uses / others : etc to separate multi values). So we need to parse the syntax and understand which value your are editing and provide the right suggestion.

Got a little bit on this. But the trick is to come up with a nice way as the separator between the options are not the same, eg as & as they can be : or '/` etc.

It would be nice if we can show the syntax in the top of the list, and let it be non-selectable, so it shows
jms:destinationType:destinationName (not selectable)
destinationType
destinationName

Or we just only show the syntax, so it can help people a bit and let it not be selectable but at least ctrl + space is a quick way to see the syntax.

This is probably better


This code solves issue #181.

This program takes 2 arrays from user. The second array is with extra elements.
This program prints the excess elements.

Sir, should i edit it in the same text box and commit changes?
On Sun, Apr 4, 2021, 22:00 Sayantani Saha @.***> wrote:

@.**** requested changes on this pull request.
In Code/C++/Excess_Elements.cpp
https://github.com/Algo-Phantoms/Algo-Tree/pull/1441#discussion_r606824186
:

   cin >> m;

   cin >> n;

   //Inputs the elements of the first array

   cout <<"Enter the first array: ";

   for(int i=0;i<m;i++)

           cin >> a[i] ;

   //Inputs along with the extra elements of the second array

   cout << "Enter the second array (With the excess elements): ";

   for(int j=0;j<n;j++){

           cin >> b[j];

           pos[j]=0;  // Corrseponding array used for comparison

   }

   //Loop for comparing the elements

   for(int  i=0;i<m;i++)

Use the concept of function
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Algo-Phantoms/Algo-Tree/pull/1441#pullrequestreview-627554400,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANSTD6FYZ5PFI5423XOP6YTTHCHYTANCNFSM42J6LZTA
.

Changes made and commited
On Sun, 4 Apr 2021 at 22:00, Sayantani Saha @.***>
wrote:

@.**** requested changes on this pull request.
In Code/C++/Excess_Elements.cpp
https://github.com/Algo-Phantoms/Algo-Tree/pull/1441#discussion_r606824186
:

   cin >> m;

   cin >> n;

   //Inputs the elements of the first array

   cout <<"Enter the first array: ";

   for(int i=0;i<m;i++)

           cin >> a[i] ;

   //Inputs along with the extra elements of the second array

   cout << "Enter the second array (With the excess elements): ";

   for(int j=0;j<n;j++){

           cin >> b[j];

           pos[j]=0;  // Corrseponding array used for comparison

   }

   //Loop for comparing the elements

   for(int  i=0;i<m;i++)

Use the concept of function
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Algo-Phantoms/Algo-Tree/pull/1441#pullrequestreview-627554400,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANSTD6FYZ5PFI5423XOP6YTTHCHYTANCNFSM42J6LZTA
.


Add ability to select multiple feature folders and files

Hello,
It would be great if the plugin supported specifying multiple feature folders and files, since cucumber options support them.
The use case is the following:
My feature files are organized by feature groups, like features/group1, features/group2, features/group3 and so on. In cucumber options, I can specify multiple feature folders if I want to run only group1 and group3, I just add "features/group1 features/group3" to my cucumber options, and it does not run group2 features.
I realize that I could also use tags to filter the features, but it seems unnecessarily (cu)cumbersome.
Thanks for considering.

Contributions are welcome!


WIP: feat(exporter): add self monitor metrics for otel-exporter

I think this file collector/consumer/exporter/otelexporter/metrics.go should be renamed since the term metrics in the otel-exporter module is used to represent the general metrics data. self_telemetry.go may be a choice.


Allow building with dynamic libssl

The cmake build will always statically link libssl and libcrypto. In some cases, it may be preferable to dynamically link them. This adds -DSSL_DYNAMIC=1 which will build libxquic dynamically linked to libssl and libcrypto and also disable libxquic-static.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Rebased and fixed the format problem.
Please note the "not found" message is no longer required. If the library is not found, cmake will print the following:
-- Could NOT find SSL (missing: SSL_LIBRARY_STATIC CRYPTO_LIBRARY_STATIC)
CMake Error at CMakeLists.txt:63 (message):
  ssl module not found


Broken on Laravel 5 (gasp!)

Although it's a bit taboo right now - this is of course broken on L5.
Easy to fix though. Remove the boot method from your provider. It's not needed. The package does not require any config or anything.
I have a fork and did just that and have been using it happily for probably a month.
Cheers!

Dropped it in the last commit. I don't think it is even needed in L4.

Killer! Thanks for the quick reply man.

Minor version bump? ^_^

Done

You rock


Regression when spreading Types in an Alias: TS1265: A rest element cannot follow another rest element.

🔎 Search Terms
TS1265
🕗 Version & Regression Information

This changed between versions 5.3.3 and 5.4.2

⏯ Playground Link
https://www.typescriptlang.org/play?ts=5.4.2#code/MYewdgzgLgBAZgSwE7QPICMBWBTYsC8MA3nCCAFwwDkpIVAvjAIYQyiRQDcAUO9DBFzgAJhhx4YhIuiZJKVGUgbNWfLt17h+iFFADCWqEzAEYAbSpMANlaoAaGADpnACjG4ojgNbYAnhBcdNCwPAEpQgF0VNkMeNQEhMGEDDmNTC2tbB2dHNxC8bz8AwXZRfKhwqJYYjh5uKF8AB2wYADFkaAAVJpbCBuaQOHgO-UM0nn6WgGVE4W7myRhJwYTSlOhxjUmYAwBbdAQwbDmexaRsJmFwK19zbhgnZ3bdeew7e8fHGdLX94ieIA
💻 Code
const firstObject = {foo: 'foo'} as const;
const secondObject = {bar: 'bar'} as const;

const firstConstant = ['all', ...(Object.keys(firstObject))] as const;
const secondConstant = ['all', ...(Object.keys(secondObject))] as const;

type FirstType = typeof firstConstant;
type SecondType = typeof secondConstant;

type CombinedType = readonly [
  ...FirstType,
  ...SecondType,
];

Workbench Repro
🙁 Actual behavior
A rest element cannot follow another rest element.(1265)
🙂 Expected behavior
No error
Additional information about the issue
No response

This is working as intended now and was changed here, see the discussion before this comment

This is working as intended now and was changed here, see the discussion before this comment

Is it? In my example it's all strings, the tuples aren't of mixed types.

It doesn't matter what are the types contained in those arrays. The reported error is pretty generic and is only concerned with the fact that you are using multiple rest elements:

A rest element cannot follow another rest element.(1265)


Minimal golang binding with tdjson

I think this example is too simple,
take a look to L11R example, I've found it really useful
https://github.com/L11R/go-tdjson

It's just to illustrate how to use CGo to create the binding. I am aware of @L11R's and that it is more practical.


precompile(true) but require failed to create a precompiled cache file

Hi, I'm getting this error when I do using DataFrames from the Juli console in Atom Editor. Oddly, in the terminal, it works fine. It's something to do with precompiling Compat:
WARNING: Module Compat uuid did not match cache file
  This is likely because module Compat does not support  precompilation but is imported by a module that does.
WARNING: deserialization checks failed while attempting to load cache from /Users/bward/.julia/lib/v0.4/Docile.ji
INFO: Precompiling module Docile...

I'm not entirely sure if this is a DataFrames issue, a JunoLab issue or a bit of both.
Best,
Ben.

Looks like this is related to Docile or Compat. Please file issues there or ask for help on the mailing list.


Re-raise error for attributes during shader creation to a little better description.

Should resolve #1056 sufficiently.
This will re-raise the error from passing an invalid sized list of data with a newly created list via program.vertex_list_indexed and program.vertex_list:
From:
ValueError: Can only assign sequence of same size
to:
ValueError: Invalid data size for 'position'. Expected 12, got 13.
Did benchmarks and could not find any big difference in speed. With 6000 set_attribute_data calls, time with and without a try: block was 12 ms and own time was 9 ms with a 1-2ms variance. Tried and assertion was measurably slower. Although it can be optimized out, I wasn't sure if it was worth it, as it requires checking the size every call without optimizing.
When assigning invalid data from vertex_list.position[:] this will produce a ValueError: Can only assign sequence of same size. I think this should be sufficient clue when someone gives the wrong sized data when setting attribute data manually. With the initialization you don't know which attribute is erroring, but when you are setting the attribute directly, you know. I don't think we need to re-raise for that, we should let the assigning after creation be as fast as possible.

I agree with this approach. "No-cost" exception handling was implemented in Python 3.11, so try statements shouldn't cause much (any?) impact.


give me cool role inm discord

morgan submitted a feature request: give me cool role inm discord
#DABEEF

Despite being a smart bot, I can not automagically respond to the user if you have any feedback to give them. Thus, if you wish to tell 'em something, respond here: https://ripple.moe/index.php?p=114&id=76

wtf howl


Add Solvenius

Add Solvenius - a logic game written in Elm and packaged as a progressive web application.

@giancosta86 Thanks for your contribution.


Add tvOS Focus Engine Support

Currently, the carousel does not focus or handle  swipes when presented in a tvOS app.
Expected Behavior: The entire carousel should receive focus. When a user swipes right or left on their remote, the slides should advance forward or backward. Arrows should not be touchable. Bullets should not be touchable.
This may require the main container to be a Touchable and we may need to register a TV guesture handler when focused.

The latest docs show how to register focus and blur even handlers as well as listening for remote events using the TVEventHandler class. http://facebook.github.io/react-native/releases/next/docs/building-for-apple-tv.html


Hoppity dataset generation

Hi,
I'm trying to run the data generation script using the cooked graphs from my dataset. However, i see in your code that you use something called hoppity_cg.tar.gz (https://github.com/google-research/plur/blob/main/plur/stage_1/hoppity_single_ast_diff_dataset.py#L61) to get some json files. What is this used for? This was not available in the hoppity repo - is this some pre-processing that you have done on your end?

@smoitra87 can you please help us understand how you generated the hoppity_cg.tar.gz file? We dont find this file in the hoppity repository.
      'hoppity_cg.tar.gz': {
          'url': 'https://drive.google.com/u/0/uc?id=1JdXaehWO4UocjXqIXzWtUmVpRWWBtqmE&export=download',
          'sha1sum': '9f4a635408f86974a8e9739769d3ed2a52c2b907',
      }

How is this file generated? Can you please provide us all the steps?


V2

@dshafik this is the work created by @migueloktaio. Let's review this later.
Cheers
Jorge

Just a quick heads up: this code hashes the body of PUT and POST requests, but the Akamai Traffic Management API (and maybe others) assumes the PUT body is not hashed.  Calling that api with this code results in 401 signing errors. The v1 edgegrid signer only hashes POST requests, which is consistent with the Traffic Management behavior.

@cart does @gfirem's latest commit solve your issue here?


docs: update README for 3.8+

I noticed that something was adding 3.8+, I guessed it might be setup-cfg-fmt, so I checked the README, and it claimed the default is still 3.7+. I was able to find #208, so it was setup-cfg-fmt, the README was just not updated there too. In this PR I touched up the readme's mentions to be consistent with the current behavior.

I'd rather just remove it and check help


How to map circuit Id with proof type?

How do we deduce if it is BJJ, SMT etc?

you can use directly the proofType, we are in app side translating these proof specific proof types to natural language to follow the design requests:
if (proof['type'] == "Iden3SparseMerkleProof" ||             proof['type'] == "Iden3SparseMerkleTreeProof") {           proofType += '- SMT Signature\n';         } else if (proof['type'] == "BJJSignature2021") {           proofType += '- BJJ Signature\n';         } else {           proofType += '- ${proof['type']}\n';         }

Hello @rauljareno ,
For example if I get following json in auth
{
  "id": "fe581ff0-f591-4b8a-a0c0-a499b0a597b0",
  "typ": "application/iden3comm-plain-json",
  "type": "https://iden3-communication.io/authorization/1.0/request",
  "thid": "fe581ff0-f591-4b8a-a0c0-a499b0a597b0",
  "body": {
    "callbackUrl": "https://self-hosted-demo-backend-platform.polygonid.me/api/callback?sessionId=412207",
    "reason": "test flow",
    "scope": [
      {
        "id": 1,
        "circuitId": "credentialAtomicQuerySigV2",
        "query": {
          "allowedIssuers": [
            "*"
          ],
          "context": "https://raw.githubusercontent.com/iden3/claim-schema-vocab/main/schemas/json-ld/kyc-v3.json-ld",
          "credentialSubject": {
            "birthday": {
              "$lt": 20000101
            }
          },
          "type": "KYCAgeCredential"
        }
      }
    ]
  },
  "from": "did:polygonid:polygon:mumbai:2qH7XAwYQzCp9VfhpNgeLtK2iCehDDrfMWUCEg5ig5"
}

How to get proof['type'] in this case?

you need to search a credential that fulfills the proof request:

context: "https://raw.githubusercontent.com/iden3/claim-schema-vocab/main/schemas/json-ld/kyc-v3.json-ld"
Type: "KYCAgeCredential"
issuer: Any "*"
birthday field lower than 20000101

for that, you need to call the following method from iden3comm:
Future<List<ClaimEntity>> getClaims({     required Iden3MessageEntity message,     required String genesisDid,     BigInt? profileNonce,     required String privateKey,   });

also, from proof request, to see the link between proof type and circuitId, check this snippet of code
if (widget.data.proofScopeRequest.circuitId ==             "credentialAtomicQuerySigV2" ||         widget.data.proofScopeRequest.circuitId ==             "credentialAtomicQuerySigV2OnChain") {       proofTypeMsg = " - BJJ Signature";     } else if (widget.data.proofScopeRequest.circuitId ==             "credentialAtomicQueryMTPV2" ||         widget.data.proofScopeRequest.circuitId ==             "credentialAtomicQueryMTPV2OnChain") {       proofTypeMsg = " - SMT Signature";     }

ok.. thank you..

Hello @rauljareno ,
i was wondering how is text produced based on credentialSubject. We are trying to make common texts.
For e.g.
{countyCode: {$nin:[840,120,340,509]}}
- countryCode is not one of the following values:

- 840
- 120
- 340
- 509

Also, what are the probable values of Allowed issuers and mapping
e.g.

=> All

@bibash28 about the countryCode question, you will need to generate a vocab file inside the credential schema to translate those values to specific strings. For doing so, please rise that question in this repository https://github.com/iden3/claim-schema-vocab.
About allowed issuers, it will accept a list of dids string of the issuers or an asterisk for any issuer.


Support for complex object in ETag configuration (useful for MongoDB $oid)

Similar support implemented for id tags, to support the MongoDB $oid also into the etag and not only in the id field by configuring the RestangularProvider as following:
RestangularProvider.setRestangularFields({
etag: '_etag.$oid'
});
Please integrate this pull request or resolve the problem in any other kind of way! :)
Thank you.

Would you mind submitting some tests as well?

Hi, thank you for your fast answer. I added 4 tests:
testing ETag header
✔ Should GET an object with returning header ETag and set the ETag header value inside a simple etag attribute
✔ Should GET an object with returning header ETag and set the ETag header value inside a complex etag attribute
testing If-Match header to support ETag
✔ Should put the If-Match header with value retrieved by a simple etag attribute
✔ Should put the If-Match header with value retrieved by a complex etag attribute
**testing ETag header ** tests that the ETag header is correctly retrieved by the response headers andits value is injected into the object (in the _etag attribute in the first test and _etag.$oid attribute in the second one). The first one was supported before, infact it's a regression test, the second test shows that with my improvements now Restangular can fill also complex object). The support is really similar to the 'id' field, I just made the things the same as for the id field.
testing If-Match header to support ETag tests that the If-Match header is populated correctly if it's declared inside the object. In the first test the etag is inside _etag attribute. For the second one is inside the _etag.$oid.

Thank you.

Awesome thanks. I'll see what I can do about merging this.

One more thing, sorry. Would you mind updating the docs to include the changes you made in this PR?

Made it, I added into the FAQ after the "I use Mongo and the ID of the elements is _id not id as the default. Therefore requests are sent to undefined routes" because they are really close problems ;)

Great thanks. Can you squash those three readme commits into one?
I'm waiting for the other contributors to review this before merging.

Done the squash of the three last commits! Hope for good news about merging soon ;) In a project I had to invalidate etag support of restangular and introduce the etag support on my own and this PR will fix it!

Awesome thanks. I need to test this a little more, then I'll merge it before the next release

Good :) Take the required time to review and test my PR ;)

any news on this PR?

Sorry, life's been a bit crazy. I was trying to test this with a PHP server, but I was unable to ever get Restangular to save the Etag header to the element. Can you confirm that this is the case? Or am I completely misunderstanding the way this works?

As you can see from the tests and test description it should assign the value of ETag header inside the object, my PR fix the fact that the etag object can be a complex object, example _etag.$oid. The implementation is the same made to support complex object on the id field.
"testing ETag header tests that the ETag header is correctly retrieved by the response headers andits value is injected into the object (in the _etag attribute in the first test and _etag.$oid attribute in the second one). The first one was supported before, infact it's a regression test, the second test shows that with my improvements now Restangular can fill also complex object). The support is really similar to the 'id' field, I just made the things the same as for the id field.


Allow users to specify their own OpenAI key in the settings

Closes https://github.com/getappmap/appmap-intellij-plugin/issues/675
This PR adds a new setting to configure a custom OpenAI key.
There's currently no additonal action (e.g. AppMap: Set OpenAPI key), but it could be added if it's needed.
Settings are persisted in the IDE's password safe.
When the OpenAI key changed, a notification is displayed in each open project to allow the user to reload it.
The application-wide JSON-RPC process is restarted immediately after the change of the OpenAI key, regardless of the user's interaction with the notification.
The notification is sticky, which means that it won't hide automatically. Otherwise the user might miss the required reload.
This PR is moving applyServiceEnvironment from the application settings class to the command line handler class, because it's now using both ApplicationSettings and the new SecureApplicationSettings.
https://github.com/getappmap/appmap-intellij-plugin/pull/628 is needed, because "Reopen project" added by this PR is triggering the bug fixed by #628 .
Testing:

Because the secure storage is used for the first time in the plugin, we need to make sure that it's working on macOS, Windows and Linux. In the past (with earlier SDKs), I've had problems on macOS because the OS's password access confirmation was blocking IDE startup.

Updated settings UI:

If the RPC process is restarted, then why does the user need to restart JetBrains?

macOS because the OS's password access confirmation was blocking IDE startup.

do you have more information on this? We are using a facility provided by JetBrains and it results in the IDE being blocked from starting?

If the RPC process is restarted, then why does the user need to restart JetBrains?

I understood that all webview editors and also the JSON-RPC process need to be restarted. If it's only the process, then I could implement it that way.

If the RPC process is restarted, then why does the user need to restart JetBrains?

I understood that all webview editors and also the JSON-RPC process need to be restarted. If it's only the process, then I could implement it that way.

You’re right because the RPC ports are out of date and I don’t think they can be updated.
We can work on that in a future version.

macOS because the OS's password access confirmation was blocking IDE startup.

do you have more information on this? We are using a facility provided by JetBrains and it results in the IDE being blocked from starting?

I'd need to test this with the current IDEs. I think it was caused by requesting secure storage during startup, but I'm not sure if that's still happening.

I tested on macOS Sonoma and it worked well.

I've made a few changes to the first version of this PR:

after a change of the key, the JSON-RPC is NOT restarted. It would invalidate the key
the notification does not contain an action to reload the project

@jansorg can you look into the build failure?

@ahtrotta It was a flaky test. I restarted the tests.
The unstable test which will hopefully and finally be fixed by https://github.com/getappmap/appmap-intellij-plugin/pull/674.

:tada: This PR is included in version 0.65.0 :tada:
The release is available on:

v0.65.0
GitHub release

Your semantic-release bot :package::rocket:


397442: Update caf-common parent to release version

https://internal.almoctane.com/ui/entity-navigation?p=131002/6001&entityType=work_item&id=397442

CI Build Link:
https://jenkins.swinfra.net/job/SEPG/job/UXAspects/job/UXAspects~buildenv-node12-image~397442~CI


Circuits should be nameable

When a circuit is created you should be able to pass a name and have that state stored internally within the circuit breaker.

This issue has been fixed in release 2.0

The name of the circuit should be part of the CircuitBrokenError.


Error message of [Object object] when sending from Ledger Nano S while MEW is also viewing Trezor wallet info in another browser

I was trying to move all of my ETH from my Ledger Nano S (purchased because Trezor hadn't added support yet) to my Trezor. I opened the Trezor wallet from Firefox and the Nano S from chrome. When I clicked "Send Transaction" I get an error [Object object]. I'm guessing it should say "You can't connect two devices at the same time" or similar. I got an error on the Trezor screen "Another U2F device was used to register on this application".
In the screenshot, the Nano S is on the left and Trezor is on the right.

I will look into this and see if we can detect / show better error message. Can you confirm if your Trezor works in Firefox when you don't have 2 devices connected?

Yes both devices work when only one is connected at a time.
This is probably reproducible regardless of the browser e.g. you could open a second private browsing window in Chrome so that MEW sees two sessions. Firefox is my main browser, but the Nano S doesn't support it so that's why I used both.

Thank you for the add'l info! I knew that Ledger didn't support Firefox but interesting to note that Trezor does.
We will definitely look into this.

I don't think it has anything to do with Trezor. I just received Ledger Nano S and was playing with it, when I got the same error. It was the only device plugged into USB ports.
My guess is that there is some sort of timeout occurring during communication with Ledger, perhaps caused by the U2F plugin. I can generate a transaction if I confirm it within 10 seconds. So after I click on Generate Transaction:

If I wait more than 10 seconds, I get the error [object Object]
If I confirm within 10 seconds, the transaction is generated
If I deny within 10 seconds, I get an error Invalid status 6985

Windows 7 64bit, Firefox 51.0.1 (32-bit), https://addons.mozilla.org/en-GB/firefox/addon/u2f-support-add-on/?src=api v1.0.1

@kvhnuke  Need better error messages for this. Returning [object object] -> straight to ALL your inboxes. #motivation?


Karate does not suppress * commands in scenarios.

I am using a main.feature file to call other feature files. I want to generate a report to only show the pass/fail condition of each API calls in each feature file called by main.feature. The default report provides a lot more information than I need and I want to leave only the comments, Given, And, When, Then in my report. However, following the documentation and including * configure report = false does not remove steps starting with * in my report. I also tried to do * configure report = {showLog: false, showAllSteps: false}, but only showLog is working as expected and steps starting with * still appears in the HTML report. I tried including karate.configure('report', {showLog: false, showAllSteps: false}); and karate.configure('report', false); in my karate-config.js, but the issue was still not resolved. I then tried running each individual feature file following the above steps only to end up with the same result. I saw that related issues were marked as fixed. Please let me know if this is still an ongoing bug and if there's something I can do to resolve this issue.

@seankim227 this is a wontfix and not a priority for us - and you can consider writing a custom report or contributing code. I replied to your double-post on stack overflow, please read the link there has explains more.


Update variable name in topshot_admin_templates.go

i wouldn't call this a value add pr, but it does fix a typo.

Thank you for fixing this! We really appreciate it. 😃


Bring back tags as an array please

I do prefer my tags in frontmatter as an array. This was changed after v0.3.10
Please bring this back as an option. With the current version if I change any frontmatter tag value and use the suggester, it converts my tags from an array to the list. I know a lost of people prefer the list method, but the array method is perfectly valid and I prefer it that way.

I think I stumbled on this as well. Just realized my tags are being formatted automatically into a list and was scratching my head as to why, had to do some debugging to figure out it was due to this add-on.
I would also like this to either revert back or provide an option. Right now it is a bit wonky, also a bit redundant when using the linter plugin.
Thanks you!

Hi, I totally get your point.
This is a design pattern that has been introduced in 1.1.9 for all plugins modifying the frontmatter. We've discussed that with the Obsidian team, and there is currently no plan to provide a "display as an array" formating option for the frontmatter section.
The team will eventually work on some UI improvements to display the frontmatter section in a more fancy way, but I'm afraid I have no precise information about that so far.

Hi you can test it in 0.4.11

Thank you, works great! I had gone back to v3 to keep my tags the way I use them but now I can enjoy all the new features you have added. 👍


Binary files not showing up in editor?

I built this (marketplace version) plugin into a prototype, but now that we are moving into production I've migrated the project to an installed build (5.2.1)
The first hurdle I had was that it wouldn't load/compile from the marketplace version no matter what I did (I even tried recompiling it with RunUAT.bat BuildPlugin (found here). So on a whim I checked the Readme file in the plugin - which led me here!
Fortunately this resolved the compile issue and I was able to get the plugin to compile with the project (in the next build I'll add it to our Installed Build).
BUT: Now the blueprints aren't showing up in the editor. There aren't even any messages about "failed to load" or anything in the logs. There are 7 files in the folders, and data validation on the folder in the editor shows 7 files - all checked and all valid.
My assumption is that it's one of three things:

I loaded the project without the plugin activated and it discarded a reference to them somehow
Switching the engine to an installed build removed an engine dependency used in the BPs
Switching from the Marketplace plugin to the Github plugin doesn't register as the same dependency

My money is on number three, as the .uproject references the marketplace plugin for identification, so I've removed it from the .uproject file (but it didn't change anything).
My next thought was to try packaging the plugin from the Plugins menu... Which told me I can't package it because I didn't package the engine with the shipping target! 🤣 The engine is 160GB with symbols, 60GB stripped, and 17GB zipped - WITHOUT the shipping target. Is it worth going back and rebuilding the engine so I can package the plugin and test that?
My team is really enjoying the plugin, I'm going to create a new workspace and see if I can rebuild them tomorrow. Any other ideas here?

Exact same thing here, no Blueprint and therefore no "BP_GameMode" or "BP_PlayerController"

I still haven’t found a solution, the plug-in is disabled and any nodes referencing it are disconnected.
It didn’t work perfectly in 5.1 anyways, so if this plug-in is no longer in active development or is only for legacy support can the creators please comment below so I can find another solution?

Hi,
The plugin is still actively supported and maintained. It works fine in the new versions 5.1 and 5.2.  In your case, I couldn't reproduce it on my PC, so unfortunately, there are weird bugs for each game project, so I can't help much in this situation.

Looking at what gets installed via Marketplace there is no BP at all included anyway?

Looking at what gets installed via Marketplace there is no BP at all included anyway?

Sorry, I am a bit confused. The plugin doesn't contain any blueprints at all. You don't have to call it in the blueprint. All you need is to configure your loading screen in Project Settings > Game -> Async Loading Screen. Please follow the plugin Tutorial  to understand how it works.

OK think I see where the confusion comes from, my bad! I saw this and assumed you had some BP included:

Now even with the configuration setup now I do not see anything but I will test again with empty maps, etc... Thanks!

Now even with the configuration setup now I do not see anything but I will test again with empty maps, etc... Thanks!

To see the loading screen in Editor. You need to play Standalone Game, not Play in the Editor (Selected Viewport). Also, the loading screen only triggers with the "OpenLevel" node.


[WIP] Handle UnsupportedVersionException for limited Kafka clients

This PR adds fixes to support Kafka compatible backends that have limited support for Kafka client API like Azure Event Hubs.

Sorry for the delay, do you have try this modification ?
I don't have any Azure acccount to test ?
Seems to be a minor modification, seems strange :smile:

closing due to inactivity, fell free to reopen


Support Kotlin 1.3 new multiplatform model

Now that this is announced, let's support it! https://discuss.kotlinlang.org/t/kotlin-1-3-m2-new-multiplatform-projects-model/9264

Still need:

[ ] samples in various configurations
[ ] plugin automatically adding dep
[ ] ios runtime

Ima close this. We'll have samples. The open PR is on the way


Refactor site maps

The resolveSiteMap() function is used by navi-scripts to find a map of all routes during static builds, but in my opinion, it's currently the weakest part of Navi's design. It's heavy, complicated code that isn't frequently used, and it's getting in the way of #60 .
Before 1.0, I want to refactor this so that instead of outputting an object mapping URLs to Route objects, it just outputs a list of URLs (which can then be resolved separately).
The new map function should work by setting the request's method property to Symbol(map) instead of the standard GET method. Then, matchers themselves will be tasked with creating a list of all of their possible children, probably putting them on a new "map" Chunk.
For custom matchers that don't understand the "map" method, they should just treat it as a GET and return a standard route. This shouldn't be a problem, as they'll still pass the request through to their children, which can add more map segments. To facilitate this, it may make sense to remove "GET" as the default, and replace it with undefined?
Since map is a special method, map configuration can be added to the request body, including predicate/url parameters extraction.

Also since this won't be backwards compatible, let's change the name from SiteMap to Index. I think router.index() makes a lot more sense.

Have just pushed a new crawl() function, and withCrawlPatterns() matcher. These will be part of the next release.


Make a Fragment version of the ImagePicker

I'm planning to do this, and I'd like to get feedback and advice about it.
I'd like to use the ImagePicker as one part of a larger Activity. One part of the Activity would be the ImagePicker, and another part would be a preview of the most recently selected image.
To make this possible, I want to move most of ImagePickerActivity's logic into a new class called ImagePickerFragment. Developers like me could create their own Activity class to take the place of ImagePickerActivity.
Please let me know what you think.

@Ruberik well actually i'm planning on moving the the picker to views. WDYT?

I haven't done a lot of Androids programming, so please take my opinion only for what it's worth.
I like that Fragments have their own lifecycle management. For example, in a Fragment you could retain what's been selected, what Album was open, and where the user has scrolled to. That's possible to do with a View, but requires work from the developer.
To me, broadly, a Fragment is a good place to put something interactive. A View is where you put something to look at. Android Image Picker is heavily interactive, with lots of state, so I'd use a Fragment.
That said, I don't have a lot of Android experience, and I'm not the primary maintainer of this library, so my opinion is only useful inasmuch as it informs yours. :-)

@esafirm, following up: What do you think is the best approach here? Do you prefer Fragments or Views, and should I be working on it, or would you prefer to?

See #164.

Fixed in #166.


Main Website SSL Certificate Expired.

Main website SSL certficate expired. They are cheap at SSLs.com

They're free at letsencrypt

Fixed. Thanks


Add vim to image

Where is Vim on all these Docker images....!?  BLASPHEMY lolz

Uhhh my bad I had the upstream set incorrectly...this was meant for my fork 🤦🏻♂


Refactor Parameters

ParamaterSet now iterates Parameters which have a name and a String version of the parameter value.
added a fluent interface to work with ParameterSets.
added unit tests
updated usage in README.md

I couldn't really assess the code relating to differences and places of usage for uri and url (www..) encodings, because I am not that familar with the related specifications.
README
Maybe there could be a note in the "Decorators" section that they are behind the Fluent usage, otherwise I wouldn't know what's the relation, why is these two sections.
This new ValueType<T> looks good to me, too. Also I like this approach to fluent interface, that it implements the original interface, not a separate Builder type. It's nice I think.
Parameter also got more straighforward for me with simply representing the name and value texts.
You mentioned you want to enforce type safe usage of parameters with the sort of mandatory use of ParameterType<T> for both parsing and creating Parameter. But I also see UrlEncodedParameter which can take a UriEncoded. What is the use-case for that?
That's all, I haven't checked implementation correctness and unit tests, just the design, usage around the new types.


Problems with Proton

When I try to launch it with Proton on Linux the following things happens:

If I launch it before tekken then tekken simply does not start.
If I launch it after tekken the tekken might freeze or not freeze after "Injecting DLL... Successful." message. Seems completely random, but it freezes a lot more than not freezing. If it does not freeze then nothing happens - the F1 menu does not pop-up when F1 is pressed and game displays the same way as if the overlay does not exist.

The version of Proton that I used is 5.0. I did install VC_redist.x64.exe. The script that I use to install VC_redist.x64.exe and to run overlay is the following:
#!/bin/sh

# Application path
APP_PATH="$(dirname "${BASH_SOURCE[0]}")"
cd "$APP_PATH"

# Executable file
APP_EXEC="$APP_PATH/$1"

# Steam / IDs
export SteamAppId="389730"
export SteamGameId="389730"

# Steam / Client path
export STEAM_COMPAT_CLIENT_INSTALL_PATH="$HOME/.steam/steam"

# Steam / Apps path
STEAM_APPS_PATH="$HOME/SSD/Games/SteamLibraryLinux/steamapps"

# Steam / Compat data path
export STEAM_COMPAT_DATA_PATH="$STEAM_APPS_PATH/compatdata/$SteamAppId"

# Proton / Path
PROTON_PATH="$HOME/SSD/Games/SteamLibraryLinux/steamapps/common/Proton 5.0"

# Proton / Executable script
PROTON_EXEC="$PROTON_PATH/proton"

python "$PROTON_EXEC" run "$APP_EXEC"

The same setup works with TekkenBotPrime without any issues.

I have no idea how dll injection works in proton. You are better off making your own dll injector and inject the tekken-overlay.dll manually yourself.


part configuration

should be able to configure part dirctory
When I use part the documentation doesn't show where the parts folder should live or how to configure parts
add the ability to configure parts directory and add a default search path

dry-view doesn't have any opinion about where and how you define your part classes. All it does is attempt to find the class constants by name, and if it can't, it falls back to the base part class.
See PartBuilder#resolve_part_class for details. This is already set up to work nicely with class autoloaders, too.
As such, there's no need for a "search path" to be configured for parts. It's the application author's job to make sure the part classes are already available by the time the view is called.
To make this clearer, I've added this note to the documentation: https://github.com/dry-rb/dry-view/commit/201d522458c55c7911d6fc762c66085478f20fad
Thanks for your report! I'd be happy to further clarify this aspect of dry-view and more, but I think the best place to do this is in the dry-rb forums: https://discourse.dry-rb.org


Clear a Warning?

The MG file employs a temporary variable titled ccs which is identical to something pulled from Language.Drasil on line 201/203 and causes multiple warning messages.  Would it be alright to adjust that variable name? (I tested it on my computer by changing it to ccs' and it worked fine but since this is the MG file I would rather check before committing anything.)

I didn't notice this issue earlier, sorry, but I've already fixed all the warnings as of ee49839aac77554e7727ff7624f78edce0eb6f57


Optimise dependencies based on TFM

Is your feature request related to a problem? Please describe.
I want to minimise dependencies in my project by utilising framework dependencies wherever possible
Describe the solution you'd like
Atleast 1 if not both the dependencies can be removed as they are provided via the framework.
Describe alternatives you've considered
Accept the additional dependency
Additional context
n/a

Which dependency do you mean?

@ssg In the end, it ended up being both dependencies are able to be provided by the framework see #11

Please be more specific. What problem does removing that dependency solve?

it does 2 things, reduce compilation size and reduces chance of CVE's/conflicting versions. Think of those dependencies like System.IO you don't need to add that package if you want access to the file system due to the framework already guranteeing tha the library will be available.


DCR: Define IPropertyManager interface and make BotState implement it

Let’s define an interface IPropertyManager for the CreateProperty() which ConversationState and UserState implement and clearly communicates that UserState and ConversationState are simply implementations of the IPropertyManager interface.
public interface IPropertyManager
{
      IStartPropertyAccessor<T> CreateProperty<T>(string name);
}

public class BotState : IPropertyManager
{
}

It then looks like this:
public class MyDialog
{
       public MyDialog(IPropertyManager propManager)
       {
              this.MyStateProperty = propManager.CreateProperty<MyState>("MyProperty");
       }

       public IStartPropertyAccessor<MyState> MyStateProperty { get; set;}

}

This delta is:

Add interface IPropertyManager definition
Change BotState class to implement IPropertyManager
Update our samples to consume IPropertyManager
I think that’s pretty surgical

[ ] botbuilder-js
[ ] botbuilder-dotnet


🐛 [cloud_firestore] Need working example for Firestore Emulator in Widget tests - initializeApp hangs indefinitely

What feature would you like to see?
Issue Description
When trying to use the Firestore Emulator in Widget tests (testWidgets), Firebase.initializeApp() hangs indefinitely. We need a working example of how to properly set up and use the Firestore Emulator in Widget tests.
Current Code
testWidgets('test emulate', (tester) async {
  WidgetsFlutterBinding.ensureInitialized();
  await Firebase.initializeApp(
    options: const FirebaseOptions(
        apiKey: 'fake-api-key',
        appId: 'fake-app-id',
        messagingSenderId: 'fake-sender-id',
        projectId: 'demo-project',
      ),
    );
    FirebaseFirestore.instance.settings = const Settings(
      host: 'localhost:8085',
      sslEnabled: false,
      persistenceEnabled: false,
  );
});

Why This Matters
Fake Firestore don't support all Firestore features. Having the ability to test with the actual Firestore Emulator would allow us to:

Test with real Firestore behavior
Use features not available in fake implementations
Have more confidence in our tests

What I'm Looking For

A working example of how to properly set up the Firestore Emulator in Widget tests
If this is not currently possible, guidance on what needs to be implemented to make it possible

Environment

firebase_core version: 3.4.0
cloud_firestore version: 5.5.0
Platform: Mac OS M1 chip
Flutter version:

Flutter 3.24.4 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 603104015d (4 weeks ago) • 2024-10-24 08:01:25 -0700
Engine • revision db49896cf2
Tools • Dart 3.5.4 • DevTools 2.37.3

Thank you for your response.
Is it okay to use dummy values like 'fake-api-key' in the test environment, or do I need to use real Firebase credentials?

I ran that and got an error:
PlatformException(channel-error, Unable to establish connection on channel., null, null)
package:firebase_core_platform_interface/src/pigeon/messages.pigeon.dart 210:7  FirebaseCoreHostApi.initializeCore

You'll have to use your real Firebase credentials. Did you start your firebase emulator before running the test?

@normidar - we have firestore test setup in the repository that you can follow. https://github.com/firebase/flutterfire/blob/main/packages/cloud_firestore/cloud_firestore/example/integration_test/e2e_test.dart
Pay attention to test_driver/ and integration_test directory setup.
Here is how to run: https://github.com/firebase/flutterfire/blob/main/.github/workflows/android.yaml#L90
As @SelaseKay mentioned - run firebase emualtors.


Always apply round_func to service times; update instances

This PR:

[x] Closes #390.
[x] Adds and passes relevant tests.
[x] Has well-formatted code and documentation.

Notes:

It is essential that you add a test when making code changes.
This keeps the code coverage level up, and helps ensure the changes work as intended.
When fixing a bug, you must add a test that would produce the bug in the master branch, and then show that it is fixed with the new code.
New code additions must be well formatted. Changes should pass the pre-commit workflow, which you can set up locally using pre-commit.
Docstring additions must render correctly, including escapes and LaTeX.

I'll run a benchmark on the VRPTW instances to make sure everything checks out. I think it does, but I'd like to know for sure.


[Storage] Patch Release for Blobs to include hotfix from previous release

This PR only affects the hot fix branch.
This is to allow us to release off the hotfix branch to point to the correct Azure.Storage.Common package, include all the correct version bumps and also include the previous Blobs patch release.

API change check
API changes are not detected in this pull request.


Review Mobile Trading Page

There are little things that i feel should/could be improved:
like padding on the sides near the title
having the title be above the fee % and so it doesn't get squished over to the left.
...
When design is worked out move this to Frontend to be impl.
-bthaile
...
@serena @mattbullock Please assign a priority.
-adrake33

subset of #385


Test tunnels via shared process

[x] anyOS @DonJayamanne
[ ] anyOS @aeschli

Complexity: 4
Authors: @alexr00 @alexdima
Create Issue

The first assignee please test using remote containers.
The second assignee please test using remote SSH.

Connect to a remote and launch there a server.
Use Forward a Port or any of the auto gestures (ctrl+click, etc) to get a tunnel going
Access the tunnel in a browser and check that you can reach your remote server
Go to the Ports view and remove the forwarded port
Check that you can no longer reach the remote server
Forward the port again
Close the window
Check that you can no longer reach the remote server
(only for SSH) forward a port, simulate a disconnection by disabling network connectivity, wait for the disconnection dialog, re-enable the network, wait for reconnection to succeed, check that the tunnel still works.

I've test this with desktop vscode insiders & Github Codespaces & it works as expected.

Tested with Linux and MacOS servers and Win/MacOS/Ubuntu UI.


Patch for /trunk/styles/sons-of-obsidian.css

Proper Code Formatting

Original issue reported on code.google.com by securecloud.biz on 2 Jul 2015 at 1:10
Attachments:

sons-of-obsidian.css.patch

:)


Design Pagination and Results Selector

📘 Description
A pagination layout is essential to enhance user experience in the Marketplace by dividing product listings into manageable sections. This visual structure prevents overwhelming users with a continuous scroll of items, instead allowing them to navigate through pages. Additionally, a selector to customize the number of items displayed per page improves flexibility. Although the pagination won't be functional yet, designing it now aligns the interface with future usability goals and ensures consistency in the Marketplace layout.
🔢 Steps

Create a new file named products-pagination.tsx inside the components/marketplace directory. If the directory does not exist, create it.
Name the component ProductsPagination.
Implement the pagination and selector layout using shadcn/ui components:

Pagination
Select

Ensure the layout is responsive and integrates seamlessly with the Marketplace design.

✅ Acceptance Criteria

Include a pagination component.
Include a results selector with options to display 10, 20, 30, and 50 items per page.
The design should be responsive.

🌎 References

Reference attached images for design inspiration, but the final implementation does not need to be identical.

📜 Additional Notes

Focus solely on the visual implementation; functionality is not required at this stage.

⚠ Do not apply until the ODHack begins.
⚠ Read our guidelines before applying.

About Me
Hello  @danielcdz, I'm Levi
I am a web3 full stack developer with expertise in blockchain technology and frontend engineering. I build on EVM compatible (Solidity) and Starknet (Cairo) blockchains.
In the blockchain domain, my expertise in solidity and Cairo has enabled me to design, develop, and deploy smart contracts on the Ethereum and Starknet based platforms, facilitating decentralized applications (dApps) that are revolutionizing industries.
Tackling this issue

To tackle this issue, first i will create a directory named Marketplace where the products_pagination.tsx page will be.
Then I will create the products_pagination.tsx file inside the Marketplace directory that was created in the Component.
Then I will write a  logic that implemets the pagination and the selector layout.
I will use shadcn/ui component, making it simple to maintain a consistent look and feel across your application.

If assigned the task, I will ensure compliance with the team's guideline.
ETA - 10 -12 hours max

Hello @danielcdz , I’d love to work on this issue as I have strong experience with front-end development.
My Approach:

I will create a ProductsPagination component inside the components/marketplace directory.
It will use shadcn/ui components for pagination and a results selector to display 10, 20, 30, or 50 items per page.
The layout will be responsive and integrate seamlessly with the Marketplace design.

Please assign this to me, and I’ll deliver an efficient and secure PR within 12-24 hours.

Hi, I'm a product designer who has worked on variety of projects with a pagination requirement.
You can view some of them here: https://www.figma.com/design/8LwReCqiZXDYzSoBK3uGAq/pagination?node-id=0-1&t=3eKNPcEApC6w8jp8-1
I'd love to be assigned to this!


GraphQL BTreeMap

Motivation
The GraphQL server fails to serialize some operations due to the presence of maps indexed by something other than strings (Epoch, ValidatorName).
cf async-graphql
Proposal
Implement Serialize and Deserialize on committees and validators BTreeMap to change the keys to string.
Test Plan

Checking GraphiQL for the block 0 after a run_local.sh. The OpenChain operation should be visible and not null as before this PR
Adding an OpenChain operation in tests in #975 PR

Release Plan

[ ] All good!
[x] Need to bump the major/minor version number in the next release of the crates.
[ ] Need to update the developer manual.
[ ] This PR is adding or removing Cargo features.
[ ] Release is blocked and/or tracked by other issues (see links above)

Reviewer Checklist

[ ] The title and the summary of the PR are short and descriptive.
[ ] The proposed solution achieves the goals stated in the PR.
[ ] The test plan is reproducible and provides sufficient coverage.
[ ] The release plan is adequate.
[ ] The commits correspond to distinct logical changes.
[ ] The code follows the coding guidelines.
[ ] The proposed changes look correct.
[ ] The CI is passing.
[ ] All of the above!

Unfortunately this doesn't solve the issue. I think the async-graphql scalar macro is checking the type of the key of the map without checking if it can be serialized in a human readable string, so the serialization needs to be modified at the BTreeMap level.
I will try to incorporate your changes so that it doesn't fail on the tests

Ah no my bad, I just need to use serializer.serialize_str(&self.0.to_string()) for the Epoch.
I will close this PR and open an other one with your changes


Timestamp column + sorting

Description
issue #4092
mitmweb has no functionality to show timestamp and sort by timestamp.
I added the functionality.

Thanks for the PR. I'm sorry if I wasn't clear in #4092, but it is a deliberate design decision to not include a timestamp column in the default view. It just doesn't work as well on smaller displays. If we reach the point where the user can add/remove columns a timestamp column is one of the first things we want to add though!
Long story short, we'd need to following things:

Add an option to specify columns here: https://github.com/mitmproxy/mitmproxy/blob/master/mitmproxy/tools/web/webaddons.py#L6
Make the web ui respect that option.
Add a timestamp column (off by default)
Add an easy way to dynamically add/remove columns from mitmweb.

Closing this in favor of #4188. 😃


Consolidate arguments in LoadOrCreateSecurityConfig

This fix tries to address the issue in #1731 so that the args in LoadOrCreateSecurityConfig could be consolidated, and not a long arg list.
This fix fixes #1731.
cc @aaronlehmann @diogomonica @stevvooe
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

Current coverage is 55.05% (diff: 89.47%)

Merging #1751 into master will decrease coverage by 0.11%

@@             master      #1751   diff @@
==========================================
  Files           101        101
  Lines         16500      16505     +5
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           9103       9087    -16
- Misses         6262       6282    +20
- Partials       1135       1136     +1

Powered by Codecov. Last update efd44df...ae01a8b

/cc @cyli

Close as the issue has been taken care of in #1757


Fix self-impl. log controller impossible to get RequestParam spanId and applicationName

For PinPoint 1.8.x only.

Codecov Report

Merging #5997 into 1.8.x will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##            1.8.x    #5997      +/-   ##
==========================================
- Coverage   40.63%   40.63%   -0.01%
==========================================
  Files        2673     2673
  Lines       80441    80446       +5
  Branches    10901    10901
==========================================
+ Hits        32690    32691       +1
- Misses      44783    44787       +4
  Partials     2968     2968

Impacted Files
Coverage Δ

.../web/controller/BusinessTransactionController.java
0% <0%> (ø)
:arrow_up:

...rp/pinpoint/web/view/TransactionInfoViewModel.java
0% <0%> (ø)
:arrow_up:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
68.96% <0%> (-3.45%)
:arrow_down:

...tor/metric/datasource/DefaultDataSourceMetric.java
75% <0%> (-3.13%)
:arrow_down:

...ofiler/sender/StandbySpanStreamDataSendWorker.java
80.59% <0%> (-2.99%)
:arrow_down:

...java/com/navercorp/pinpoint/rpc/DefaultFuture.java
72.5% <0%> (-1.67%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
80.55% <0%> (+0.69%)
:arrow_up:

.../pinpoint/rpc/client/PinpointClientHandshaker.java
66.42% <0%> (+1.42%)
:arrow_up:

...m/navercorp/pinpoint/rpc/client/ConnectFuture.java
90% <0%> (+5%)
:arrow_up:

...p/pinpoint/rpc/client/WriteFailFutureListener.java
75% <0%> (+18.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52cc74c...ba91e80. Read the comment docs.

@yjqg6666
Thank you for your contribution.
Unfortunately, this feature doesn't seem to be backported. The backport target only targets bug fixes or critical features.

This one could be treated as a bugfix. As the doc stated "https://github.com/naver/pinpoint/blob/master/doc/per-request_feature_guide.md#3-expose-log-in-pinpoint-web"

@Controller

public class Nelo2LogController {
@RequestMapping(value = "/????")
public String NeloLogForTransactionId(@RequestParam (value= "transactionId", required=true) String transactionId,
                                        @RequestParam(value= "spanId" , required=false) String spanId,
                                        @RequestParam(value="time" , required=true) long time ) {

      // you should implement the logic to retrieve your agent’s logs.
}

Now the self-impl. could not get spanId.


Update IFTTT listing to show 2FA support.

Just merged ifttt in another PR, so you'll get merge conflict here. Please sync your fork and make PR to that.

@tswestendorp is :zap: quick!


HHH-12964 - Upgrade to dom4j 2.1.1 - 5.1

https://hibernate.atlassian.net/browse/HHH-12964
(cherry picked from commit e66da8af0076c2fbca9c190e8e708441be5bfcd3)

@gbadner Not sure if this belongs to you, sorry if it does not.
Can we make an effort to backport this to 5.1 as well?
Thanks in advance.

Duplicate of https://github.com/hibernate/hibernate-orm/pull/2533.


Add quick organization switcher

In the desktop app you have the convenient sidebar to switch between organization.
maybe having a menu option?
another idea would be to use the same idea as in rocket.chat, they use a two finger swipe up to change the server when the app is starting

We don't have the gesture detection atm, but the switch works from the drawer -> settings!
Thanks for the suggestion 👍

@kunall17 while there is a switcher, I think ideally we'd want it to be faster than it is and allow you to receive push notifications for multiple Zulip realms at the same time.

Yeah, we will want to store the server icon's urls and make the picker more easily accessible.
Assigning this to me, as I have a decent idea how to do that, but we'll focus on the big issues we discussed with Tim, until all of them are resolved before doing this.

To add to the conversation here, I would like to point out that there's no way to know what the currently active realm is except going to the switcher. Would be useful to have the realm icon visible somewhere.

@mkaito as with many other things a mobile app has to have much more focused screens with way less extra details.
While we will not make the account icon always visible, we are going to make the account switcher faster to access which will be quite an improvement.

Without the ability to conveniently monitor multiple realms, the mobile Zulip app is basically useless to me. What can I do to help get the development process restarted for this feature? I am not really a JS programmer, so PRs are probably out, but I am happy to help how I can.


Do I just have to run the torsoNeRF for the test for rendering?

Hello,
Do I just have to run the torsoNeRF for the test for rendering with the command
'''python NeRFs/TorsoNeRF/run_nerf.py --config dataset/$id/TorsoNeRFTest_config.txt --aud_file=dataset/$id/aud.npy --test_size=300''?
Why did we learn the headNeRF separately, which you wrote like that in README?
BTW, thank you for sharing your work

Finally, I got the process

Finally, I got the process

So why?

Just follow "Run AD-NeRF for Rendering" of Readme.
I was confused about the use of TorsoNeRF. But it is also used for the combined use of Head Part and Torso Part, depending on its arguments.


How to obtain HTTP status codes?

Hello Marcin, I hope you are doing well.
As you may know, HTTP status checkers don’t do great on Twitter. Tweets that have been deleted or simply don’t exist can be shown as 200 despite them being 403 or 404.
I’m wondering: is there a way I can feed stweet a text file containing Tweet URLs and have stweet ask Twitter to tell me the status codes for these Tweets?
Thank you!

Hello @Mennaruuk 😉,
Could You share me some example? I don't have Twitter API documentation 😞 and I will prepare all on my own by seeing different responses.

Absolutely!
Example of an active Tweet: https://twitter.com/EA/status/1488940167780048900
Example of a deleted Tweet: https://twitter.com/eascaaa/status/1230668542577692673

API doesn't return 403 or 404, let you check the inspector when you open https://twitter.com/eascaaa/status/1230668542577692673 url there are everywhere 200 response code.
I have error in this code:
import stweet as st

ACTIVE = '1488940167780048900'
DELETED = '1230668542577692673'

def test_id(tweet_id: str):
    id_task = st.TweetsByIdTask(tweet_id)
    output_json = st.JsonLineFileRawOutput('output_raw_id.jl')
    output_print = st.PrintRawOutput()
    st.TweetsByIdRunner(tweets_by_id_task=id_task,
                        raw_data_outputs=[output_print, output_json]).run()

if __name__ == '__main__':
    test_id(ACTIVE)
    print('--------')
    test_id(DELETED)

Have you the same results?
I will consider how to fix it.

Sadly, I have the same results.
One trick I found was specifying a user agent of a crawling bot in the headers. A good one is DuckDuckGo's bot DuckDuckBot. (Others include BingBot, YandexBot, and Applebot.) Examples:
import requests, re

tweet_url ="https://twitter.com/EA/status/1488940167780048900 "
headers = {'user-agent':'Mozilla/5.0 (compatible; DuckDuckBot-Https/1.1; https://duckduckgo.com/duckduckbot)'}

response = requests.get(tweet_url, headers=headers, allow_redirects=False)
status_code = response.status_code
print(status_code)
------------------
200

import requests, re

tweet_url ="https://twitter.com/EA/status/1488940167780048900 "
headers = {'user-agent':'Mozilla/5.0 (compatible; DuckDuckBot-Https/1.1; https://duckduckgo.com/duckduckbot)'}

response = requests.get(tweet_url, headers=headers, allow_redirects=False)
status_code = response.status_code
print(status_code)
------------------
404

Of course, some users may not want to send their URLs over to Apple, Bing, DuckDuckGo, or Yandex, but stweet can tell them upfront that accurate status checking requires one of these bots, and DuckDuckGo is known for their privacy advocacy so I think that's a pragmatic solution.


delete day entry gives [Error: deleting time requires an id]

I'm using angular.js to send delete request to node using this:
$http.delete('/daily/delete/' + entriesArray.id)
        .then(function(response){
                console.log(response);
                if(response.data == "ok"){
                    console.log("Deleted time entries");
                }
         }, function(response){
         console.log("error", response);
});

With express.js Router class I'm doing this call:
router.delete('/daily/delete/:id', function(req, res) {
    var harvest = new Harvest(req.session.user);
    var id = req.params.id;
    harvest.TimeTracking.delete(id, function(err, res){
        if(err){
            console.log(err,res);
        } else{
            res.send("ok");
        }
    });
});

The log of the request looks like this:
DELETE /daily/delete/id
where id is correct from my entry.
But right after that log it gives an error log of:
[Error: deleting time requires an id] undefined
Where I'm doing it wrong, it seems it should work?
//Markus

Hi Markus,
You need to pass an object as the first argument, with id as a key. Like this:
var id = req.params.id;
harvest.TimeTracking.delete({ "id": id }, function(err, res) {})

Please use markdown styling for your messages in future.

Added markdown to the initial issue and closing.


Confused about the batch_size for PV-RCNN.

Hi, @sshaoshuai
Thanks for your great work.
I recognized that the batch_size used in the paper is 24 with 8 1080ti GPUs for KITTI dataset training.
but i found that for a 1080ti GPU with 11GB memory, it only can handle a batch of 2 which means that 8 1080ti GPUs can only support batch of 16. it doesn't match the number in the paper(24).
Did i ignore something, or it is just a text error?
Looking forward to your reply.

Maybe OpenPCDet consumes slightly more GPU-memory than my previous version, since it records lots of tensors in the forward data dict. You just need to use batch size 2 since it could also achieve similar performance with batch size 3 .

Maybe OpenPCDet consumes slightly more GPU-memory than my previous version, since it records lots of tensors in the forward data dict. You just need to use batch size 2 since it could also achieve similar performance with batch size 3 .

Thank you, i got it.
I only have 1 2080ti GPU, so i need to ajust the lr on the basis of actual batch size.


Constructing blocks and loading from XML should not trigger events.

Incoming change (PR #568) adds BlocklyEvent in response to several Block setter methods. These methods are call in the constructor and when loading blocks from XML. This ties the loading method, incorrectly, to the main UI thread.
Need a way to detect that the block is not done loading, and should not emit events yet.  Possibly only emitting events when attached to a BlockContainer (also new).

Probably fixed in #568 in later updates.  Needs tests to verify.


[MRG] Improve readability of changelog with github subsitution

any reviews/opinions here or should we merge? I just copied this from mne-bids. Basically it helps avoid incorrect links in our whats_new.rst

Sweet sugar, thanks @jasmainak :)


Add feature to export/import current resources

It would be nice if we can export the resources at that time and can import and restore the resources.

/kind feature

Hi @sanposhiho, I'm interested in this issue.
It is expected that exported files should be editable?
Is binary format not suited for the purpose?
thanks.

Thanks for taking this one. Feel free to ask me if you have questions or need some helps.

It is expected that exported files should be editable?
For example, is binary format not suited for the purpose?

IMO it would be better if it is easy to edit/read for humans.
So, the simplest idea would be to export all resources in Kubernetes yaml format. We can import them as it is.
(we need to check if we can apply exported yaml as it is when we import.)

@sanposhiho
If k8s API is updated and the simulator supports a greatly changed format, we may not be able to import files that have already been exported.
Therefore, I'd like to export it with a version number (build version of simulator..?)
It will also be possible to switch processing by version.
what do you think about it?

@196Ikuchil

Therefore, I'd like to export it with a version number (build version of simulator..?)

I don't think it's a good idea.
Such break changes should be controlled by major version in semantic versioning. It means we can add breaking changes when we increment major versions.
So, if a user exports resources in simulator v1.X.X and tries to import it in simulator v2.X.X, importing may fail. But, it's okay.

It will also be possible to switch processing by version.

It means "we have to maintain all old logics related to import/export forever". We cannot/don't want to do that.

@196Ikuchil
Could you please add a brief description of what you'd like to add to frontend here before starting to implement the frontend?

@sanposhiho

I will implement import/export button like this.
In export, we can get a YAML format file of current resources. (But the server responds in JSON, so we need to convert to YAML on the client-side.)
In import, we can put a YAML file, and it will be applied to the scheduler. (And before it, I call reset API. Because import overwrites all existing resources. Therefore, it is safer.)

Looks good. Let me ask some questions.

Why do you think it is better to export as yaml? (not json)
What happens when users click import/export button? New Dialog comes up and users will choose export or import in that dialog?

Another possible design is to display import and export as separate buttons in the first place.

Why do you think it is better to export as yaml? (not json)
I followed this.

Write your configuration files using YAML rather than JSON. Though these formats can be used interchangeably in almost all scenarios, YAML tends to be more user-friendly.

https://kubernetes.io/ja/docs/concepts/configuration/overview/#一般的な設定のtips

What happens when users click import/export button?
yes, I will display a new dialog. And also I will implement 2 buttons. (similar to yours.)

Current behavior

export

import

Hi @sanposhiho
we must call get API of each resource after importing has been done.
But I think it is to be complicated because we are going to call each API on import component.
So, I'd like to prompt users to reload the browser. What do you think?
Thank you.

But I think it is to be complicated because we are going to call each API on import component.

Yes. It's better to call each get API after requesting import API.

/reopen