Does not mention about file size limit

[Enter feedback here]
Findstr fails for vmware vmdk files. Please mention file size.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0b90f482-f48a-7d60-7ba9-bb5a1e837989
Version Independent ID: 5a8e1ac5-3f4d-4da9-67c3-15a08d9a1b61
Content: findstr
Content Source: WindowsServerDocs/administration/windows-commands/findstr.md
Product: windows-server
Technology: windows-commands
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

Hey lapaz17,
Thanks again for contacting Microsoft. We value your feedback.
The findstr command searches for patterns of text in files and does not have any inherent limitations on the size of the file it can search. However, it may take longer to search larger files, and there may be practical limitations based on the amount of memory available on the system running the command.
A VMDK file is not a plain-text file.
I'm not completely positive, but you may need to mount the VMDK first if you intend to use findstr against it (if possible). Please utilize our other channels for assistance in this matter:

Open a ticket with Microsoft Support.
Search or engage with Microsoft TechNet.
Search or engage with the Microsoft Developer Network.
Search or engage with the Microsoft Support Community.

As this is a non-documentation issue, we’re closing this thread.
Thank you and have a most pleasant day.
#please-close


fix reactBonus

for many reactions the reaction bonus is not displayed.
for example: https://gcsim.app/v3/viewer/share/8818ff23-055f-4669-9943-cf3a9c7afdfb (491 frame)

with fix:

Idk about merging this considering that ReactBonus mod is due for a rewrite (#913) and that this would log the ReactBonus at the time of the attack hitting, which would ignore its snapshotting properties for some reactions.


[Feature Proposal] Add a function with an api similar to styled-system that returns tailwind classes

I think it would be very useful to have a function that takes args in the same shape as @styled-system/css and generates tailwind classes.
The api would be something like this
import css from 'tailwind/css';

let myClass = css({
     fontSize: [ "sm", "base", "lg" ],
    color: 'primary',
    bg: 'gray',
    '&:hover': {
      color: 'secondary',
    },
});
console.log(myClass); // "text-sm md:text-base lg:text-lg text-primary bg-gray hover:text-secondary"

Ideally this function would include typescript types generated from the current theme to help developers recognize invalid arguments.

Have you seen this project? https://github.com/bradlc/babel-plugin-tailwind-components/


TCP ports and how to persist data @ Docker

I'm running OTBR on Docker.
Is it possible to specify:

Every TCP port used. On doc there is just TCP port related to the webgui but, for example, for some integrations we need also 8081 (used by OTBR for websocket protocol). Are there any other used TCP ports?
If I destroy my container I lose every configuration about thread network. What are directories to bind to make data persistent ?

Thank you

can't believe this google project is so badly mantained and documented.

Every TCP port used. On doc there is just TCP port related to the webgui but, for example, for some integrations we need also 8081 (used by OTBR for websocket protocol). Are there any other used TCP ports?

It's just the two ports you identified - one for the REST API and another for the web UI.

If I destroy my container I lose every configuration about thread network. What are directories to bind to make data persistent ?

The current OTBR Docker image is meant for development, not production, and does not save state.
You can make /var/lib/thread a Docker volume. More here: https://github.com/orgs/openthread/discussions/10311#discussioncomment-9754171

can't believe this google project is so badly mantained and documented.

OpenThread is a community supported project. Anyone is free to make contributions.

can't believe this google project is so badly mantained and documented.

OpenThread is a community supported project. Anyone is free to make contributions.

I would do it, if I were able.
So, as a simple user, I feel uncomfortable with so little support.

So, as a simple user, I feel uncomfortable with so little support.

You can start by submitting a PR that helps address any issues you've run into.


File.Create throws exception for relative file paths

Package Version
<IP_ADDRESS>6
Repro steps

Create MockFileSystem
Create working directory
Set working directory
Call

using (var file = fileSystem.File.Create("File.txt")) { }
Expected behavior
File is created in current working directory (which does exist).
Actual behavior
Exception is thrown.
Could not find a part of the path 'File.txt'.
This worked in version <IP_ADDRESS>. I suspect it is due to change for #278 an #286
which assumes an absolute file path rather than a relative one.
.NET Framework version handles both cases, as does
fileSystem.File.WriteAllText("File.txt", null);

Thanks for reporting this! Could you test if the problem also occurs in the latest prerelease version? #372 might already have fixed it.

Thanks. Alas it still throws in latest beta.
            string workingDirectory = @"C:\folder";
            string relativeFile = "file.txt";
            var fileSystem = new MockFileSystem();

            fileSystem.Directory.CreateDirectory(workingDirectory);
            fileSystem.Directory.SetCurrentDirectory(workingDirectory);

            // Throws.
            using(fileSystem.File.Create(relativeFile))
            {
            }

            // Works.
            fileSystem.File.WriteAllText(relativeFile, null);

This seems to be related to my issue #404.
The funny thing is that issue 404 is related to something that is not found ;-)

@Gav-Brown The problem is fixed with ec1b673. Could you verify your use case with the prerelease version https://www.nuget.org/packages/System.IO.Abstractions/2.2.10-beta?

@fgreinacher Thanks. I've tested and can confirm this is now resolved.


fix: image reference path in docs

support RHINENG-1487

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.79%. Comparing base (41bae4a) to head (739e777).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   78.79%   78.79%
=======================================
  Files          23       23
  Lines         613      613
=======================================
  Hits          483      483
  Misses        130      130

Flag
Coverage Δ

unittests
78.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Covered by the new doc - see https://github.com/RedHatInsights/yuptoo/pull/101


 Similarly, most developers have at some point compiled the static assets and built this file, so  the tests don't fail.
We should either ensure that this file is built before running the test suite, or fix the tests to not depend on it existing.

The tests generally rely on having make serve running don't they?

You don't have to run make serve before running the tests, if no containers are running, it will start the following:
Starting warehouse_rabbitmq_1
Starting warehouse_db_1
Starting warehouse_redis_1
Starting warehouse_elasticsearch_1

(but not the static container)

We could fix this by adding static to the links for the web worker, but I wasn't convinced we should necessarily have that dependency just for this file.

In our meeting today I asked us to double-check and we confirmed this isn't urgent enough for a near-term milestone.

I would really love it if someone could fix this during the packaging sprints!

Would it be acceptable to test for the presence of manifest file, and  "mark skipped" if the file does not exist yet?

@nlhkabu Could I take this issue please.

@Bjwebb We have an open PR for this already: https://github.com/pypa/warehouse/issues/3978
You can help by reviewing that PR though!

@di, may be it makes sense to mark it for Bloomberg 2018 Event?

+1, sounds like an issue that could be addressed by https://github.com/orgs/pypa/projects/1

Can someone create a new PR resolving the conflicts from #3978 and verify that it works?


Added Maven-Java11 builder

See https://github.com/jenkins-x/jenkins-x-builders/pull/20 .

/test this
/approve

/ok-to-test


how to resume?

Please try to use the model checkpoint. You might use the optimizer checkpoint.

@michuanhaohao yes,I have know how to do it. But I met a problem, AttributeError: 'Baseline' object has no attribute 'copy'. My torch version is 1.1.0. Can you give me some advice?

First, please check you used model checkpoint, not optimizer checkpoint.
Second, you can refer to https://github.com/michuanhaohao/reid-strong-baseline/issues/85 .


Compatibility with electron-compile (with a hack solution)

OS: Windows 10
Node: 14.15.0
electron-forge: '5.2.4'
When trying to include sharp with latest electron-forge, i noticed that altough sharp installed ok, and worked after npm install, when building in electron it was giving a error saying the module did not exists.
After debugging what was going on , electron-recompile was complaining that:

fatal error C1189: #error:  Exception support not detected.       Define either NAPI_CPP_EXCEPTIONS or NAPI_DISABLE_CPP_EXCEPTIONS. (compiling source file ..\src\common.cc) [C:\Users\CARLOS~1\AppData\Local\Temp\electron-packager\win32-x64\bluedarwin-studio-win32-x64\resources\app\node_modules\sharp\build\sharp.vcxproj]

Well i defined that flag in bindings.gyp and it stopped complaining, however was still getting the 'Cannot load module' error.
By debugging what was going on i noticed that what electron-rebuild, does is;
 node-gyp rebuild --target=8.2.0 --arch=x64 --dist-url=https://www.electronjs.org/headers --build-from-source
If i do that in sharp folder, then node->require('sharp') it also doesn't work.
I noticed then that in sharp package.json it has extra commands : '(node-gyp rebuild && node install/dll-copy)'
so i guessed the last part was breaking it, and it was correct, once i run manually the 'node install/dll-copy' then it worked.
Now to solve that i made a hack, i added;
'actions': [       {       'action_name': 'link_stuff',       'inputs':[], # complains if no input is provided       'outputs': ['output.txt'], # complains if not output is provided       'action': ['node ../install/dll-copy'] # i just want you to run this stuff       }     ],
Into the binding.gyp file, in the 'sharp' target segment.
Basically the 'hack' is for it to run that command upon rebuild as electron-rebuild is not going to run that for me.
And that worked!
Now i have absolutely no idea of what i am doing :)
So i just wanted to leave here my experience so that you guys may do it the right way ;)

Native modules that use N-API, such as sharp, do not require the use of electron-rebuild as the binaries are already suitable for all supported versions of Electron. You'll probably need to report this downstream.

Hi Lovell, thanks for the clarification. I will make a issue downstream.


tmt: Update bootc-install.py plugin

This contains the latest plugin code from
https://github.com/teemtee/tmt/pull/3161. It includes automatically spinning up a podman-machine when podman is not rootful. It also fixes a bug introduced in the latest tmt version related to starting a web server via a systemd service.

Looks like we get farther now but
                    Error: nu::shell::external_command

                      × External command failed
                        ╭─[/var/tmp/tmt/run-002/plans/test-20-local-upgrade/tree/tests/booted/test-image-pushpull-upgrade.nu:52:5]
                     51 │     # And reboot into it
                     52 │     tmt-reboot
                        ·     ─────┬────
                        ·          ╰── executable was not found
                     53 │ }
                        ╰────

should be fixed now. (my local setup was picking up an old tmt version installed via pip)

Every CI check is green! :heavy_check_mark:


Update the kube-proxy arguments for master

kube-proxy doesn't accept --api-masters=, it takes --master= instead

I signed it!

Anyone had a moment to review this ?

LGTM


Incorrect Example

The example shown for creating an assistant (in the Enable file search) section has the wrong version number (for the REST example)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 043d1c43-41f9-6121-192e-246ddf7321c4
Version Independent ID: 15aa4531-66af-bfea-65e7-293fcd1e8f38
Content: How to use Azure OpenAI Assistants file search - Azure OpenAI
Content Source: articles/ai-services/openai/how-to/file-search.md
Service: azure-ai-openai
GitHub Login: @aahill
Microsoft Alias: aahi

@edkopka
Thanks for your feedback! We will investigate and update as appropriate.

Thanks for raising this issue, I'll update the docs shortly.
#please-close


Fix multiple selection

#204

Will take a look after lunch

Will take a look after lunch

Thanks!

Codecov Report
Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@b9335ae). Click here to learn what that means.

Files
Patch %
Lines

crates/editor_ui/src/tools/gizmo.rs
0.00%
21 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage        ?   12.74%
=======================================
  Files           ?       54
  Lines           ?     7084
  Branches        ?        0
=======================================
  Hits            ?      903
  Misses          ?     6181
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

several lines running from the central gizmo to the centres of all selected objects?


[Feature request] Auto preview active opened file

Currently this extension only loads/reloads pages under two scenarios:

User clicks the "Show Preview" button
User changes the file opened in the preview window

I would like this extension to change the previewed document when switching the active opened file. For example, when I am editing A.html, the live preview shows rendered content of A.html, and when I switched to editing B.html, the live preview shows rendered content of B.html automatically.
Further, the other way round, in the preview window, when previewing A.html and then jumping to B.html via a hyperlink, it may be desirable to add a button beside the refresh button that can open B.html in the code editor window for me.
In addition, currently this extension only shows the "Show Preview" button when the file extension is ".html", but other file extensions can be viewed in web browser too, like pure XML documents or XML documents that can be transformed by .xslt document into HTML documents, as mentioned in #118. I hope user can configure which extensions they would like this extension to respond to and append a preview button for.
Anyway, this is a wonderful extension. Your work is appreciated!

I can make this a feature request for the preview following the active file and possibly for the active file following the preview, but supporting non-html file preview is unfortunately out of scope.


samples/mesh: Fix dev_uuid initialization from identity address

With the recent changes to identity address handling the local
identity address is only guaranteed to be available once
settings_load() has been called. Move the initialization of dev_uuid
to the appropriate place.
Signed-off-by: Johan Hedberg<EMAIL_ADDRESS>

@vikrant8051 this should fix the issue with the UUID that you reported. Could you please verify that it does indeed fix it?

Codecov Report

Merging #9474 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9474   +/-   ##
=======================================
  Coverage   52.19%   52.19%
=======================================
  Files         212      212
  Lines       25921    25921
  Branches     5570     5570
=======================================
  Hits        13529    13529
  Misses      10129    10129
  Partials     2263     2263

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734eda3...42f1972. Read the comment docs.

@jhedberg Ok.

@jhedberg Still getting UUID as<PHONE_NUMBER>0000000000000000000000

@jhedberg Still getting UUID as<PHONE_NUMBER>0000000000000000000000

I the Mesh stack debug logs, or in the actual unprovisioned device beacons? Since the code is now calling bt_mesh_init() before setting the UUID the Mesh stack logs are expected to print all zeroes in this case (which you can just ignore).

Ofcourse while DEVICE is in unprovisioned state

Ofcourse while DEVICE is in unprovisioned state

What do you mean?
Anyway, I just pushed a second patch to move the confusing log (which I suspect you're seeing) to a better place.

Ofcourse while DEVICE is in unprovisioned state

@vikrant8051 I wasn't asking when you get the all-zeroes UUID, rather where you are seeing it. I suspect it was only in the log but over the air the correct value was used. As I said, my second patch should also fix the logging (hopefully).

@jhedberg I do same changes as per your this commit & execute
[meshctl]# discover-unprovisioned on
SetDiscoveryFilter success
Discovery started
Adapter property changed
[CHG] Controller 28:F0:76:2F:42:BB Discovering: yes
Mesh Provisioning Service (00001827-0000-1000-8000-00805f9b34fb)
Device UUID:<PHONE_NUMBER>0000000000000000000000
OOB: 0000
Previously here we could see starting bytes as MAC address.

@jhedberg
After setting static u8_t dev_uuid[16] = {0xdd, 0xdd}; now I got
UUID as 			Device UUID: dddd0000000000000000000000000000

@vikrant8051 ok, there must be something I've missed then. I'll try to reproduce myself.

@vikrant8051 I can reproduce. The issue exists for PB-GATT but not for PB-ADV. The bt_mesh_proxy_init() function is constructing the advertising data and doesn't re-check the UUID later when actually using it. I'll try to come up with a fix soonish.

@vikrant8051 please try again with this PR. There's now a third patch that should fix this for PB-GATT.

Ok

@jhedberg Nope !! Still getting  Device UUID: dddd0000000000000000000000000000 after setting
static u8_t dev_uuid[16] = {0xdd, 0xdd}; or<PHONE_NUMBER>0000000000000000000000
git log has shown me following commits in my local repo ...
commit 22f57fb121516ddc2f8b600fcfbe39b3140c02ee (HEAD -> fix_bugs10)
commit 8e4982808637045f7bca4e6ad3d7f7d1e07c9c50
commit 42f1972077cc913a30662707c4b707e94c0f8008

@vikrant8051 I'm not following. If you're doing that initialization then you are supposed to get dddd. Remove the static initialization and keep the identity address based code as is. FWIW, I tried this myself with an nRF52840 DK and I was able to see the correct UUID in the nRFConnect app.

@vikrant8051 I cannot reproduce what you are saying. With the latest patches in this PR, on an nRF52840 DK, when I scan from my phone (nRF Connect) it shows that the UUID has been correctly initialized from the identity address.

@jhedberg
Do we have to enable some configuration option in prj.conf to use MAC address intead of value defined to dev_uuid ?

Do we have to enable some configuration option in prj.conf to embed MAC address in UUID instead of using value defined for dev_uuid ?

@vikrant8051 No, it's all app-side. You just need to have the memcpy as-is in the code. Did you really try this PR without any other changes to it?

@jhedberg
Issue has solved ... it was because of my /etc/bash.bashrc which was executing as usual script from /home/vikrant/zephyr/zephyr-env.sh
Now I changed it to latest location where I added this PR.

@jhedberg
Please take care of things if unnecessary changes has happened due to wrong feedback from my side.

@jhedberg Please take care of things if unnecessary changes has happened due to wrong feedback from my side.

I don't think there's anything unnecessary in the PR, since I was able to reproduce the issue myself and verify that the patches fix the behavior. I think all three patches are good. Now I'd just need an approved review from someone, @carlescufi @Vudentz @sjanc ? :)

@jhedberg Understanding Mesh stack is beyond my scope. I never tried to judge or do any analysis what is going on at background. It was just my concern since it was my mistake.


Helm repository for the retina

Is your feature request related to a problem? Please describe.
Currently, setting up installations in a cluster involves several steps to obtain the manifests for the helm. This process includes acquiring various tools locally and executing multiple commands, leading to complexity and potential errors.
Describe the solution you'd like
I envision a straightforward installation process for Retina. Simplifying the setup to just a few steps would greatly enhance user experience.
Describe alternatives you've considered
One feasible alternative is to establish a dedicated repository for Retina manifests. By adding this repository to Helm, users could easily access and install Retina with minimal effort:
helm repo add retinarepository
helm install retina

Additional context
Implementing this solution could significantly reduce the occurrence of issues that need to be investigated, streamlining the deployment process for Retina.

there are some options for how we could handle this:

use GH pages to host a helm repo (may be challenging, because we use GH pages to host retina.sh)
use something like artifacthub
publish helm charts as OCI artifacts to GHCR

I favor the last option and it would be straightforward to set up, but interested to see what others think about the UX there, or if there are other options I haven't listed

will be fixed in https://github.com/microsoft/retina/pull/127 by publishing the helm chart OCI artifact to GHCR


how to install mpglue using anaconda

Hi, I would like to know how to install mpglue using conda

@tzehuey85 You could pip install after creating a virtual environment with conda. For example,

Create your virtual environment:

conda create --name my_env python=3.8 cython numpy

Activate the virtual environment:

conda activate my_env

Install mpglue with pip into the conda environment:

(my_env) pip install git+https://github.com/jgrss/mpglue

@tzehuey85 Quick follow-up -- mpglue is no longer upgraded on a regular basis. Therefore, if you are looking for a library for image I/O for satellite imagery, I recommend rasterio or geowombat.

thanks for the guidance. I successfully installed the package but when I tried to import Spfeas in jupyter notebook, an error pop out "ERROR:115:classification.:Scikit-learn must be installed". BTW, I have installed scikit-learn. So, could you please guide me how to solve this problem. thanks in advance

I have a poor import check for multiple Scikit-learn packages. Scikit-learn may have changed names or dropped a module since last I used mpglue. Can you enter an ipython session and run:
from sklearn import ensemble, tree, metrics, manifold, calibration
from sklearn.feature_selection import chi2, VarianceThreshold
from sklearn.preprocessing import RobustScaler, StandardScaler
from sklearn.neighbors import KNeighborsClassifier
from sklearn.linear_model import LogisticRegression
from sklearn import svm
from sklearn.discriminant_analysis import QuadraticDiscriminantAnalysis as QDA
from sklearn.naive_bayes import GaussianNB
from sklearn.covariance import EllipticEnvelope
from sklearn.cluster import KMeans
from sklearn.semi_supervised import label_propagation
from sklearn.model_selection import GridSearchCV
from sklearn.decomposition import PCA as skPCA
from sklearn.decomposition import IncrementalPCA
from sklearn.gaussian_process import GaussianProcessClassifier
from sklearn.base import BaseEstimator, ClassifierMixin
from sklearn.utils.multiclass import unique_labels

Then paste the traceback of the error.

Everything is ok. jupyter showed future warning as bellow:
C:\ProgramData\Anaconda3\envs\tampy38\lib\site-packages\sklearn\utils\deprecation.py:143: FutureWarning: The sklearn.semi_supervised.label_propagation module is  deprecated in version 0.22 and will be removed in version 0.24. The corresponding classes / functions should instead be imported from sklearn.semi_supervised. Anything that cannot be imported from sklearn.semi_supervised is now part of the private API.
warnings.warn(message, FutureWarning)


sp-core-hashing: use the digest::Digest trait to handle the hashing function uniformly

Description

Replace some dependencies (in order to use digest::Digest to handle the hashing functions uniformly)

use sha3 instead of tiny-keccak  for Keccak256 and Keccak512
use blake2 instead of blake2-rfc for Blake2b64, Blake2b128, Blake2b256 and Blake2b512

Reduce some boilerplate code

polkadot companion: https://github.com/paritytech/polkadot/pull/4907
polkadot address: 15XuanNimo5951s3RjFTPX1AvYVnCwfr3SDhb3AV4fQF3LpK

Looks like keccak implementation is now on par with tiny-keccak, but looks like blake is a bit underperforming (only on small data, seems to be a constant overhead).
Will check again next week.

Well difference is actually not that relevant at size different than 32 bytes, so switching could be a good idea.

I'd raise this issue on rust-crypto/hashes crate.  We can ask if they want help improving those and/or put a bounty on improvements or offer funding.

I'll caution however that storage should eventually migrate toward custom hashing, for which the digest crate does not suffice, but it's fine for when using regular hash functions of course.

I'd raise this issue on rust-crypto/hashes crate. We can ask if they want help improving those and/or put a bounty on improvements or offer funding. It's also possible they know build conditions that improve performance.

Not sure the little overhead is worth chasing (on the other hand if we find a way to build with simd there is good gain).

@bkchr @cheme  could you merge this PR?

bot merge


Update interested-technical-writers.md

@googlebot I signed it!

@emckean I have added the name in alphabetical order by surname/family name.


Trouble with escape method in function “from” of Query Builder

Hi.
I have a problem with the way of escape of Query Builder in Codeigniter 3.0. For example, this code:
echo $this->db->select('ROUND(3.456, 1) AS T1')->get_compiled_select();
Return:
SELECT ROUND(3.456, `1)` AS `T1`
The function put backticks after a coma and out of parenthesis, but this is solved by setting FALSE the second parameter. But the function "from" put always backticks:
echo $this->db->from('(SELECT ROUND(3.456, 1)) AS T1')->get_compiled_select()
Return:
SELECT * FROM (SELECT ROUND(3.456, `1))` AS `T1`
I'm using Codeigniter 3.0. The problem exists since Codeigniter 2.2. I need use the Query Builder beacuse it's very easy to use, but its escape method is troublesome.
I try setting config '_protect_identifiers' to FALSE, but give more problems with insert, where and update functions.
Thanks.

Query Builder isn't meant to work with raw SQL, which is exactly what (SELECT ROUND(3.456, 1)) AS T1 is.

Hi. Thanks for answer. Sorry, the page hide the backticks in my text. I re-edited.
My original query is more complex, but the example show the conflict with the backticks. For now, I solved my problem using db->query(), but the Query Builder is very simple. Greetings.


feat: update golang-github-ncw-go-acd to 0.0_git20171120.887eb06

Go library for accessing Amazon Cloud Drive
Issue: https://github.com/deepin-community/sig-deepin-sysdev-team/issues/552
Log: update repo

/lgtm
/approve


How to compile using Cmake?

Hi, I wonder if this one can be compiled using Cmake. If yes, could you please show me how?
Thank you!

Please find the CMake file.
$ cd *MyDir*
$ mkdir build
$ cd build
$ cmake ..
$ make -j4

thanks!


Fix Texture#has()

This PR

Fixes a bug

It wasn't returning a boolean.

Yeah I guess a strict boolean is more useful here 👍


Phase2 translated to portuguese

I am continuing the translation into Portuguese that I saw in this issue

Thank you @ViniViniAntunes


Update roadmap

Pre-PR checklist

[ x ] PR is not a duplicate
[ x ] Changes have been made in a separate branch. Branches MUST have descriptive names that start with either the fix/ or feature/ prefixes. Good examples are: fix/signin-issue or feature/issue-templates.

Final checklist

[ x ] I have performed a self-review of my code

This is a test merge from kbs3-modality-fork


Add an exclude attribute in @TestParameter to exclude enum values.

Currently the exclude attribute in @TestParameter only supports
enums since it may not make any sense to support other types. It should
be fairly easy to add support for other types if needed.

Hi Fredy,
To start, I greatly appreciate you taking the time to create what seems to be a high quality pull request.
However, in this particular case, I'm not sure this is a feature that we would want to add. This has been proposed before, and our suggestion was always to solve the exclusion problem with the JUnit assumptions:
import static com.google.common.truth.TruthJUnit.assume;

@Test
public void test1(@TestParameter Fruit fruit) {
  assume().that(fruit).isNotEqualTo(Fruit.BANANA);

  // At this point, the test will only run for APPLE and CHERRY.
  // The BANANA case will silently be ignored.
}

enum Fruit { APPLE, BANANA, CHERRY }

The test will throw a special throwable that causes the test to be excluded if the assumption is not met.
(the above snippet uses Truth but it can work with standard JUnit methods too)
I realize there are pros and cons to the approach you proposed, e.g.:

an exclude option is a lot less verbose

an exclude option is closer to the parameter

Assumptions are in Java and thus have compile time guarantees, which means the IDE, refactor tools and the compiler can make things easier. This is not the case for an exclude option

An exclude option adds extra API surface

Adding an exclude option can trigger (pointless) discussions among engineers because there are now two options to do the same thing

We've (at least so far) weighed simplicity quite heavily, making is lean heavily towards recommending assume() instead

Thanks for the explanation. I've been using assume myself for excluding certain test parameter values. Initially I thought it would be nice to add this in the API. However, I totally understand the reason for making the API simple. Would it be possible to update the README with this recommendation since there can be multiple ways to achieve the same thing?

Would it be possible to update the README with this recommendation since there can be multiple ways to achieve the same thing?

Good idea. I'll add this next week.

Added in https://github.com/google/TestParameterInjector/commit/a9fc69dd6cdc06ee5502d2d407bb2dcc2ed65851


Get from Slaves

Hello,
Is it possible to connect to Slaves in order to perform some GET operations?
If yes, how can this be achieved? Also, will we get the connect/disconnect callbacks from the Slaves too?
Kindly advise.
Thank you.

Hi! It's not implemented yet. We have thought about it though.
If we add it, I think it should be with an option so the default will still be to use only masters. If replicas are used, I suppose the callbacks should be called for replicas too, but I haven't though about it much. What do you think?
Are you interested in contributing an implementation?

Thank you for the response.
Though not possible at the moment, we will certainly look to contribute whenever we can.


CorrelationDecoder.fit(dset) fails to create temporary files on HPC compute nodes where $HOME is read-only

Summary
CorrelationDecoder.fit() fails when ran on Niagara cluster compute nodes, since it attempts to create temporary files in $HOME which is read-only.
Additional details

NiMARE version: 0.0.10rc2

It appears that PR #460 added the feature causing the bug.
Bug could be resolved by storing temporary files in $TMPDIR environment variable or /tmp.
What were you trying to do?
Fit a CorrelationDecoder on a subset of the Neurosynth dataset.
What did you expect to happen?
CorrelationDecoder.fit() to run through without errors; a file named "neurosynth_dataset_slice_decoded.csv" to be outputted.
What actually happened?
An error:
Traceback (most recent call last):
  File "decode_example.py", line 14, in <module>
    decoder.fit(neurosynth_dset)
  File "/gpfs/fs1/home/m/mchakrav/daialy/.virtualenvs/nimare_venv/lib/python3.8/site-packages/nimare/base.py", line 548, in fit
    self._fit(dataset)
  File "/gpfs/fs1/home/m/mchakrav/daialy/.virtualenvs/nimare_venv/lib/python3.8/site-packages/nimare/decode/continuous.py", line 185, in _fit
    dataset = kernel_transformer.transform(dataset, return_type="dataset")
  File "/gpfs/fs1/home/m/mchakrav/daialy/.virtualenvs/nimare_venv/lib/python3.8/site-packages/nimare/utils.py", line 462, in memmap_context
    dataset_dir = _get_dataset_dir("temporary_files", data_dir=None)
  File "/gpfs/fs1/home/m/mchakrav/daialy/.virtualenvs/nimare_venv/lib/python3.8/site-packages/nimare/extract/utils.py", line 143, in _get_dataset_dir
    raise OSError(
OSError: NiMARE tried to store the dataset in the following directories, but:
 -/home/m/mchakrav/daialy/.nimare/temporary_files (Read-only file system)

Reproducing the bug

The following script was submitted as a job to SLURM, using qbatch.
#decode_images.py
import os
import nimare

out_dir = os.path.abspath("nimare_ns_data/")

neurosynth_dset = nimare.dataset.Dataset.load(os.path.join(out_dir, "neurosynth_dataset.pkl.gz"))
neurosynth_dset.update_path(out_dir)

neurosynth_dset = neurosynth_dset.slice(neurosynth_dset.ids[:50])
neurosynth_dset.annotations = neurosynth_dset.annotations[
    ["id", "study_id", "contrast_id", "terms_abstract_tfidf__11", "terms_abstract_tfidf__15"]
]

from nimare.decode import continuous
decoder = continuous.CorrelationDecoder(feature_group=None, features=None)
decoder.fit(neurosynth_dset)
decoded_df = decoder.transform("myimage.nii.gz")
decoded_df.to_csv("neurosynth_dataset_slice_decoded.csv")

qbatch command: qbatch -c1 decode_joblist.txt
contents of decode_joblist.txt:
python decode_images.py

I agree that this is a great idea, although I will need to look into how other packages handle this issue. NiMARE has a dedicated data directory, based on nilearn's approach when downloading files with its datasets module, so I'm not sure if a temporary directory is the way to go, but there should be a way to configure or set that target location in any functions/classes that might use it.

I think the problem might be one of documentation. I took the data-directory creation code from nilearn, and I've never really gotten familiar with it. However, nimare.extract.utils.get_data_dirs() attempts to use global variables (either NIMARE_SHARED_DATA or NIMARE_DATA). Obviously neither of those is TMPDIR, and without digging deep into the code I doubt anyone would know about them. However, if we document them, then that might help folks.
An alternative would be to properly separate the temporary and data directories. I believe nilearn has a memory argument in a number of its functions, which we could use in NiMARE. Users can provide a path to a caching directory and temporary files will be written there.

(technical staff supporting @alyssadai here). If there is indeed some environment variables which would impact this that would work fine, however my look over the documentation didn't immediately expose them (or as function options).
A separation of TMP directory would be beneficial in general, for using faster storage compared to other files.

Thanks @gdevenyi. I'll make sure to document the data directory variable, and I'll also look into supporting a separate temporary directory.

@alyssadai @gdevenyi, would you mind taking a look at the new documentation to see if it's clear enough?
The new page is https://nimare.readthedocs.io/en/latest/fetching.html#fetching-tools , and the pages that link to it are:

https://nimare.readthedocs.io/en/latest/api.html#module-nimare.extract
https://nimare.readthedocs.io/en/latest/auto_examples/01_datasets/download_neurosynth.html#sphx-glr-auto-examples-01-datasets-download-neurosynth-py

Hi Taylor, the documentation reads clearly to me - thanks for adding this. When data_dir is specified in the fetch call, would subsequent temporary files (e.g. for CorrelationDecoder.fit()) also be created in {data_dir}/temporary_files? Or are temporary files still directed to the home directory for now (looks like this might be the case based on #569)?


Quick Start Guide : Release Tag info for install image is improper.

Issue/Feature Description:
The release tag information is not proper for installer image download in quickstart guide.
https://docs.sodafoundation.io/soda-gettingstarted/quickstart/
Why this issue to fixed / feature is needed(give scenarios or use cases):
Installation step issue
How to reproduce, in case of a bug:
https://docs.sodafoundation.io/soda-gettingstarted/quickstart/ (attached the [image)

Other Notes /  Environment Information: (Please give the env information, log link or any useful information for this issue)
NA

Fixed with commit# 9d3b3ac56e2804d3ce7582960eae76a7b13c2e7f


[WIP] feat(package-server): create subscription manifest

Description

Adds helm template for package-service Subscription manifest
Adds helm template for olm-operators CatalogSource/ConfigMap
Generates manifests for package-service Subscription
Generates manifests for olm-operators CatalogSource/ConfigMap
Adds Subscription requeuing on CatalogSource update

/approve

/lgtm
/retest

@njhale It looks like running gofmt on the things we codegen is causing verify to fail?

@njhale It looks like running gofmt on the things we codegen is causing verify to fail?

Yup, looks like it. I ran goimports on the pkg/... earlier. I'll amend this commit with the regenerated code soon.

/test e2e-aws-olm

/test e2e-aws-olm

/retest

/retest

/retest

/lgtm

/retest

/retest


Doesn't support Chinese characters in the textfield

The Chinese characters will become strange symbols

Thank you for reporting 👍

Not just Chinese characters, any multibyte character seem to fall apart.
For example, here's "Árvíztűrő tükörfúrógép" as it appears in the ToDoList sample: ÃrvÃztÅ±rÅ tÃ¼kÃ¶rfÃºrÃ³gÃ©
This has some serious MS-DOS vibes 😄

Changing Control to pass around a Character, and changing the C read call to String(data:encoding:) seems to do the trick. I commented out arrow handling for the moment, so no PR yet.

Thanks @vzsg for coming up with a fix for the character encoding 👏
With Chinese characters and emojis however, there is a second issue, which is that they are considered double-width by many Terminal apps. That means they occupy twice the width of other characters, and the cursor is moved two positions as well, which the rendering code in SwiftTUI doesn't handle properly. We might have to consider support for double-width characters as a new feature, unrelated to this encoding bug.


Reduce palette not working

Describe the bug
When attempting to use the reduce palette feature (on the online version at least), you get an error: "Processing error: ReferenceError: __dirname is not defined"
To Reproduce
Steps to reproduce the behavior:

Go to https://squoosh.app/
Use one of the existing images.
Try to use reduce palette.
See error.

Expected behavior
To be able to use the reduce palette feature, to reduce the colors.
Version:

OS w/ version: Windows 10
Browser w/ version: Chrome Version 87.0.4280.141 / Firefox 84.0.2

I can’t reproduce this in Chrome on MacOS. @RReverser can you give this a try?

I can’t reproduce this in Chrome on MacOS. @RReverser can you give this a try?

Had a colleague test on Chrome on MacOS, and she was getting the same error, and another colleague with Windows 10 and Chrome as well.
This was still working yesterday, but it stopped working after refreshing the page today after getting an "Update is available" notification.

Had a colleague test on Chrome on MacOS, and she was getting the same error, and another colleague with Windows 10 and Chrome as well.
This was still working yesterday, but it stopped working after refreshing the page today after getting an "Update is available" notification.

I can recreate this. I'm going to roll back live.

I can recreate this. I'm going to roll back live.

Live is rolling back to 5d0c856. Assigning to @RReverser since it was the codec rebuild that seemed to cause this.

Live is rolling back to 5d0c856. Assigning to @RReverser since it was the codec rebuild that seemed to cause this.

@rin3s thanks for reporting this! The fix (well, rollback) should be live in a few minutes.

@rin3s thanks for reporting this! The fix (well, rollback) should be live in a few minutes.

@jakearchibald Awesome.
Live is working now again, thanks!

@jakearchibald Awesome.
Live is working now again, thanks!

That's very strange, but yeah, I can see something relevant in the diff on #935:
- for(u in e)e.hasOwnProperty(u)&&(t[u]=e[u]);var v="",ba;v=self.location.href;
+ for(u in e)e.hasOwnProperty(u)&&(t[u]=e[u]);var v="",ba,ca,da,ea;v=__dirname+"/";

I wonder what the actual underlying change was that caused this.

That's very strange, but yeah, I can see something relevant in the diff on #935:
- for(u in e)e.hasOwnProperty(u)&&(t[u]=e[u]);var v="",ba;v=self.location.href;
+ for(u in e)e.hasOwnProperty(u)&&(t[u]=e[u]);var v="",ba,ca,da,ea;v=__dirname+"/";

I wonder what the actual underlying change was that caused this.

Logging shows that ENVIRONMENT=worker is set correctly for imagequant.js, so maybe this is an Emscripten issue and it still uses __dirname when it shouldn't?

Logging shows that ENVIRONMENT=worker is set correctly for imagequant.js, so maybe this is an Emscripten issue and it still uses __dirname when it shouldn't?

OH MY GOD @surma.
https://github.com/GoogleChromeLabs/squoosh/blob/6117c9dd267e800e93f7435c0acb93e5b344a221/codecs/imagequant/Makefile#L14-L43
I somehow missed this in review of #875 too 😂
For each file, it compiles twice - first with correct environment, and second one that overwrites it with ENVIRONMENT=node.

OH MY GOD @surma.
https://github.com/GoogleChromeLabs/squoosh/blob/6117c9dd267e800e93f7435c0acb93e5b344a221/codecs/imagequant/Makefile#L14-L43
I somehow missed this in review of #875 too 😂
For each file, it compiles twice - first with correct environment, and second one that overwrites it with ENVIRONMENT=node.

We probably should add some sort of CI task that makes sure any output files are newer than Makefiles, to ensure that codecs are always rebuilt and tested with the latest Makefile changes.

We probably should add some sort of CI task that makes sure any output files are newer than Makefiles, to ensure that codecs are always rebuilt and tested with the latest Makefile changes.

Fixed in https://github.com/GoogleChromeLabs/squoosh/pull/947.

Fixed in https://github.com/GoogleChromeLabs/squoosh/pull/947.


Add hello world application for flex deploy check

This is taken from https://github.com/GoogleCloudPlatform/getting-started-php, and is used to ensure basic flex deploys work as intended.
@tmatsuo

So my question is, do we really need another e2e test?

Possibly no. I would say PHP is unique in already having a set of apps that are deployed and tracked, so props to you guys :) That being said, I guess the name of this check is a bit misleading: we also want to check that the application serves, not just that it deploys correctly. In some sense this is similar to the integration tests, but this is using the default production builder flow (whereas the integration tests are using a custom flow on a newly built runtime image). It doesn't look like any of the tests you have currently set up are actually checking to see that the deployed application serves. WDYT?

@nkubala I think our acceptance tests are using the build_pipeline and build_pipeline56 test apps against the production builder flow, also the test checks the app serving too.
Adding @chingor for confirm

@nkubala Our e2e tests do both deploys and can some simple web serving checks which can easily be added to. Our e2e tests are used for acceptance by utilizing the released builder pipelines, but are also used as CI tests for changes to our builder pipeline.
I'm not sure if this test app is needed.

Fair enough, thanks for the responses


fixed typo

in -> is

Hi! Thank you for noting this misprint.
Our Readme mentions that we only accept PRs from the users who have signed the JetBrains CLA. If you consider contributing to our docs and other JB projects in the future, could you please sign and send it to us, so I can accept your PR?
Otherwise, please let me know, and I'll make sure to fix the typo myself. Thanks again!

thanks - I just signed

Thank you! I will now merge your pull request.


Required false is not working with Map

I have created the Spring boot project and added openApi "springdoc-openapi-ui (1.6.14)". when I create a rest endpoint with below syntax:
@PostMapping("/test")
public void testing(@RequestParam String name,
@RequestParam(required = false) Map<String, String> maps,
@RequestParam(required = false) String key
) {
}
I dont see the "maps" attribute in the swagger UI. It is totally getting missed. But I see the "key" attribute. Even though both are required false, I see key attribute but not the maps attribute in the UI.
Note: If I remove the required false in the maps attribute then it comes in the UI.
Excepted:
key and maps both should come in swagger UI without any required label
Actual:
key is coming without any required label but maps is not coming in the UI at all.

Please raise tooling-related issues on the relevant repository, e.g. spring-boot or swagger-ui. This repository is for the OpenAPI specification itself. You may also receive more answers on a general support forum such as StackOverflow. Thanks.


nvcc fatal

g++: error：roi_pooling_op.cu.o：no such file

I meet the same problem,do you fixed it?Could you tell me how?


[Feature Request]: Plot directly onto a matplotlib axis

Libraries like seaborn allow you to add simple plots onto preexisting matplotlib objects. For simple, non-faceted ggplots, there should be a way to add them directly onto an existing matplotlib figure by specifying the axis to plot on. This allows for a high degree of customization in building subplots.

Do you mean something like this?

Hi,
I can't see the thread on GitHub, but I'm replying by email. I don't quite
mean what's in the linked example. In the example, you build a base figure
in ggplot and extend off of that. However, I want to be able to add simple
ggplot figures onto already-existing figure objects. While the linked
method makes it easy to put a ggplot in the first row, first column, it
makes it hard to put it anywhere else. For simple plots that don't involve
faceting, it could be possible to simply include a parameter for which axis
you want to plot it on.
Thank you,
Edridge D'Souza
On Thu, Aug 16, 2018 at 3:29 AM, chouhy<EMAIL_ADDRESS>wrote:

Do you mean something like this
https://stackoverflow.com/questions/42899779/how-can-i-add-a-pythons-ggplot-object-to-a-matplot-grid
?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/yhat/ggpy/issues/651#issuecomment-413452642, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AS1k1b5vP7StL9XV_HQfx-M6kziQKz5wks5uRR9hgaJpZM4VusAA
.


Update multi-sidebar.mdx

Improve documentation

I did a bit of re-wording and took out the mention of the label and width as they can differ depending on which style a user has selected.
Thanks again, @quickfold, for making Starlight Utils a bit better for everyone ✨


Tutorial: Fix broken check for format in match statement

We want the check to succeed if format is D32_SFLOAT_S8_UINT or D24_UNORM_S8_UINT, so the operator should be logical OR, not bitwise OR.

The use of | in a match arm results in a pattern, not a bitwise or, so this code is good as it is.
I'll add a note calling this out.

I didn't appreciate that Rust match arms work like this and the text you've added is super helpful. Hopefully most other people using your tutorial will have more Rust knowledge than I obviously do!


Task defined did not run in IOS

I used the Simple example provided in your readme and I can't see the msg logged in the Chrome React Native Debugger. Not sure what I missed.
Packages Versions:

Xcode: 8.2.1
NPM: 3.10.10
"react": "16.0.0-alpha.12",
"react-native": "0.45.1",
"react-native-background-fetch": "^2.0.8",
"react-native-background-task": "^0.2.0"

Try using the "Simulate Background Fetch" feature of Xcode, documented here:
https://developer.apple.com/library/content/documentation/IDEs/Conceptual/iOS_Simulator_Guide/TestingontheiOSSimulator/TestingontheiOSSimulator.html#//apple_ref/doc/uid/TP40012848-CH4-SW5
Were you using a simulator or device?  From what I understand the Simulator doesn't run background code by itself.  If you were using a real device then it probably should have run after ~15 mins.

It was tested on device.

Can you try out with Simulate Background Fetch and just confirm that works first?
If it does, it's probably a sign that the task is set up properly, but Apple's algorithm is choosing not to run it (which sadly there isn't much we can do about).
Did you force close the app, rather than just leaving it running in the background?  That's one which will unfortunately stop the background task occurring (until the user opens the app again), under Apple's policies.

The app was not closed. Home button is pressed to leave the App in Bg.  I will try out the Simulate Bg Fetch in Simualator to see if it works and get back to you.
I also happen to find one interesting quote when reading Nativescript.
From NativeScript Docs for "smple-ios-background-execution":

iOS doesn't allow a general-purpose background task to run forever, such a task will be suspended by the operating system after approximately 3 minutes. In some special cases your task is allowed to run longer, but you need to use UIBackgroundModes in your Info.plist file to specify the intent of your task (which automatically makes it not general-purpose).

https://developer.apple.com/library/content/documentation/iPhone/Conceptual/iPhoneOSProgrammingGuide/BackgroundExecution/BackgroundExecution.html#//apple_ref/doc/uid/TP40007072-CH4-SW23

the simple fetch example is not working in Android....i have follow all the steps but it is not working

Sure, I'll tidy up and include the example project I was using shortly, which worked on both Android and iOS.
Once that is up, @shammus672agmailcom , could you please open a new issue if you are still experiencing problems, as the debugging process is completely different for Android vs iOS.

I've created an example project here: https://github.com/jamesisaac/RNBackgroundTaskExample which includes step by step commits so you can see each part of the setup process.
I haven't tested this exact release of the project on iOS yet (I normally use Windows/Android so a bit of a hassle to get the environment set up), but this is almost identical to the initial code I was using to test the library across both platforms.  Maybe you'll spot something you've done differently.  I will test it myself shortly on iOS just to confirm everything is still working.

I am facing similar problem, I was also not able to run background task in my iphone background
As per documents I have define task but it does not print "Hello from a background task" on console
Below is my version, let me know if it is related to version or device
Node Version: 6.0.0
Npm Version: 3.8.6
Xcode Version: 8.0
react Version: "16.0.0-alpha.12",
react-native Version : "0.48.3",
react-native-background-fetch Version : "^2.0.8",
react-native-background-task Version: "^0.2.1",
Device : iphone 5c
Device OS: 9.3.3

Same here

Here's one more thing to try, make sure Background Fetch is enabled for the project:

To support this mode, enable the Background fetch option from the Background modes section of the Capabilities tab in your Xcode project. (You can also enable this support by including the UIBackgroundModes key with the fetch value in your app’s Info.plist file.)

This worked beautifully on the iOS Simulator with Debug > Background Fetch but couldn't get it to work on a real iOS device. Would love to have this working on the device as well, as it really helped achieve the background process work on the Simulator without many hitches.

This worked beautifully on the iOS Simulator with Debug > Background Fetch but couldn't get it to work on a real iOS device. Would love to have this working on the device as well, as it really helped achieve the background process work on the Simulator without many hitches.

@askarhu Did it work for you? I am stuck in similar situation, it worked well with 'Simulate Background Fetch' on xCode but it doesn't seem to work with production build, I even waited for 2 days, but background fetch was never triggered.

Having the same issue: it is working with the 'Simulate Background Fetch' but when built as release build it was not executed a single time during the past 12 hours...
Like @binitpatel I am also using an older version of this library (as recommended by react-native-background-task):
"react-native-background-fetch": "^2.0.8",
"react-native-background-task": "^0.2.1",

Could it be related to that? Maybe because the capability Background processing is not set? 🤔
Was anybody here able to solve it somehow?


Is that possible to totally control the randomness?

I noticed that by fixing the random seed in config.py can control the batch sequence. However, the initial weights of RPN can still be random. So, is there any way to control the randomness totally?

I think if you put a random seed, you can control it. I have not tested it though.


Version bump to v0.11.8

Tag the version that doesn't import internal functions

gentle bump @dlfivefifty


Not Compatible with Android Studio 3+

Please update the app sample for working on Android Studio 3.0 and above. I've tried but getting a lot of errors.

Hey,
thank you for that feedback, I will be pushing a quick fix soon.
Greetings,
Mario


feat: add gRPC public API

What problem are we solving?
This PR aims to solve multiple problems at the same time:

Add a public gRPC API implementation
Provide a public HTTP(S) OpenAPI schema

How are we solving the problem?
The idea is to create a public gRPC API, and use protoc-gen-openapi, which supports OpenAPI v3 to generate YAML spec documents.
See discussion in https://github.com/seaweedfs/seaweedfs/pull/4306 -- though we didn't discuss this particular solution, it seems like a good way to actually get both things done at the same time.
How is the PR tested?
There are no tests for the PR just yet, but what the API should look like is nailed down, tests should be added.
Checks

[ ] I have added unit tests if possible.
[ ] I will add related wiki document changes and link to this PR after merging.

Hey @chrislusf would love some feedback on this -- started with a very small example, but it should outline the approach.

This is good. But need to be split into smaller PRs with one change at a time.

Yeah, this is actually very close to the first PR I'd like to submit for this feature. The real addition here is public.proto and the rest are generated additions/required by Google gRPC feature usage.
The approach I wanted to take was to introduce exactly one new API (see public.proto) and then build out the API (and discuss as we go) from there.
I haven't actually written the implementation for the info endpoint I'm proposing (would love any help/pointers in that direction though, what you'd expect it to return, etc).

I don’t understand what is the value of having a grpc documentation generator in OpenApi?
Is it true that someone will use these and make a lot of their own integrations and external components?

Hi @kmlebedev would you mind explaining something about the documentation generator? My intent was to add an API to enable access to currently CLI-only commands that are available.
The documentation-related notes that are in the proto files are due to my (re)using Google shared proto schemas -- that's not strictly necessary but I thought it would be good to reuse.

Is it true that someone will use these and make a lot of their own integrations and external components?

The intent here was for controlling weed from outside it, without using the CLI. Not necessarily building an external component that interacts with weed internals.
Administration via CLI is fine for installations that are manually managed, but it is unnecessarily hard to automate, I think.

So far it looks like a bunch of extra code that needs to be maintained for no one knows.

If there's a different way to perform the administration tasks I wanted to lay out that I missed I'd appreciate a pointer! If CLI is intended to the be the only way to administer seaweed for the forseeable future then that's fine as well.
I'm also open to how you think this should be structured, based on the goal of being able to administer weed via API/non-CLI means.

@t3hmrman  I understand the idea and it will probably be useful, but I would like it to be the code used. Can you share your case of using this API in place of the cli?

but I would like it to be the code used.

Would you mind explaining this bit? I'm not sure I understand.

Can you share your case of using this API in place of the cli?
What specific problem are you solving in your case?

It's a bit wide-ranging, but I'd like to be able to perform all the CLI operations via API if possible -- right now I basically do this by scripting a sidecar container that runs CLI commands, but ideally I could trigger the actions directly.


feat(localize): updated translation from Crowdin

:tada: This PR is included in version 3.23.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix: GIF avatars with size loose their animated property

Please describe the changes this PR makes and why it should be merged:
This PR makes it to where the size param won't affect the avatar if it's a GIF. The size doesn't afect the image anyways, it just makes it not animate
Note: This is NOT a dupe of #2195, as this is pointed at master, while that is pointed at 11.3-dev
Semantic versioning classification:

[x] This PR changes the library's interface (methods or parameters added)

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

this should not be merged. it isn't a bug with discord.js, and introduces unwanted behavior.

After a quick round of omg it worked but it didn't when i tested it in Discord.JS, I'm closing this because well. Discord's client is :b:roken and won't animate the GIF


Support for multiple chats

Add support for sending alerts to multiple chats.

Thanks for this amazing plugin!
Would indeed be great if this gets possible.

Thanks 😄
I don't really use GrayLog anymore and I have a lot to do right now, but as people seem to like the plugin I will probably™ maybe™ implement this sometime™ in the coming weeks.
In the meantime: I also accept pull-requests. If someone wants to implement it then that would be great ^^

fixed in 60737dc 🙂

Aah nice @irgendwr ! If i knew how to program in this language i would.
Thanks for adding this 👍


IGNITE-16045 Add documentation pages for the snapshot thread pool size property

Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist

[ ] There is a single JIRA ticket related to the pull request.
[ ] The web-link to the pull request is attached to the JIRA ticket.
[ ] The JIRA ticket has the Patch Available state.
[ ] The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
[ ] The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
[ ] A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
[ ] The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

How to Contribute
Coding abbreviation rules
Coding Guidelines
Apache Ignite Teamcity Bot

If you need any help, please email<EMAIL_ADDRESS>or ask anу advice on http://asf.slack.com #ignite channel.

@Nikita-tech-writer Can you review the patch?

@Mmuzaf I've left a couple of suggestions. The rest LGTM! Thank you.


Evaluate fixed costs in TwoOpt

This PR fixes the bug identified in #380, which was caused by TwoOpt not considering fixed costs.

Let's wait for the CI and then merge it in. I'll push a new version to PyPI once it's in main.

Let's wait for the CI and then merge it in if we're hitting all cases. I'll push a new version to PyPI once it's in main.

I'll add an extra example to hit the other two cases, too.
    if (uRoute->empty() && U->isDepot() && !n(V)->isDepot())
        deltaCost += uRoute->fixedCost();

	...

    if (!vRoute->empty() && V->isDepot() && n(U)->isDepot())
        deltaCost -= vRoute->fixedCost();

@N-Wouda do you know why the CI doesn't want to run?
Current runner version: '2.308.0'
Operating System
Runner Image
Runner Image Provisioner
GITHUB_TOKEN Permissions
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:f43a0e5ff2bd294095638e18286ca9a3d1956744)
Error: Can't use 'tar -xzf' extract archive file: /home/runner/work/_actions/_temp_cbec4595-d85b-4884-85db-5c7f02255017/14cb0d45-847e-4586-be74-63508db3c71b.tar.gz. return code: 2.

We might need to update to checkout v4, which was release one hour ago (coincidence? I think not). In any case, I would not be surprised if there's an issue at GitHub, although the status page still claims Actions is healthy.
Pretty sure this is not us, however.

Relevant: https://github.com/actions/checkout/issues/949.

Maybe upgrade to checkout v4?

@N-Wouda all cases are (partially) hit. You can merge it in if this is OK.


Completion list takes far too long even after an initial list is generated

edits by @cartermp
Current issue:
Thanks to @buybackoff for the repro:

Download Spreads.
Build the solution (build.cmd)
Open the solution and theSortedMap.fs file.
Add a new line after line 125, and type this.

Expected: completion list appears reasonably fast, at least certainly after the first try.
Actual: completion appears many seconds after the . every time.
Old issue:
Recently started playing around with VsVim on 15.6 preview 2 and noticed that Intellisense is extremely slow. At first I thought it was broken but eventually found it's just taking ~6-8 seconds to display. This reproduces consistently.

Clone https://github.com/jaredpar/VsVim
Switch to branch repro/fsharp-intellisense-perf
Open VsVim.sln
Open Modes_Visual_VisualMode.fs
Wait for semantic colorizing to take place (ensure initial binding pass is done).
Navigate to line 223. Will have text _selectionTracker.UpdateSelection()
Open a line above and type _selectionTracker.

I would expect Intellisense to popup rather quickly here. Instead it takes ~8 seconds to popup. You can delete the . and retype and see the effect over and over again.
Of possible interest here is this F# project is on the new SDK.

Unfortunately preview 3 the IDE crashes on load of my solution :(.

Is your solution something I could take a look at?

I have experienced the same issue (completion taking ~10 seconds) with 15.7.0 Preview 1.0:
This is a new SDK project which includes the TypeProvider SDK:

clone https://gitlab.com/0x53A/Area51.git

In the project Area51, open Library.fs

Type S and press CTRL+SPACE to trigger completion.
Wait.
Select System and press DOT.
Wait.
Select Array and press DOT.
Wait.

On my machine this wait time takes between 1 and 10 seconds.
Note that in the second project, Area51.Tests, completion is okay.

On 15.6 it's better now. But not nearly as good as non SDK projects were.

@buybackoff without diving into a debug session and/or trace (thanks for the repro BTW), there's no telling what the issue is. The original issue was due to a missing check to see if data already existed before recomputing. Either that's not getting hit here (unlikely), or there's something else at work. I'll re-open and make this case the issue.

@cartermp  how I can help diagnose what's wrong? Should I try nightly build?

It's doubtful that a nightly has fixed this, but it's worth a shot. I think we'll just need to debug it and see what's going on, possibly running a trace. I can consistently reproduce your issue (every time I hit ., CPU spikes up to 60% and it takes multiple seconds to see completion). No inkling what the root cause is right now. Are there other places where completion consistently takes 8+ seconds, or is this the only one you've noticed so far with 15.7?

Everywhere in the project where I'm trying so far. Removing netstandard2.0 target doesn't help. I could see by coloring that some heavy calcs are going one in backgrounds, event the gif above shows that this is white for 5-6 secs then it turns yellow and only after that the intellisense window is shown.

Hey folks, sorry you are running into issues. Can I ask you do something?

Open a new instance of Visual Studio
Send Help > Feedback -> Report a Problem -> Report new Problem
Enter title/description saying you running into perf issues
Click Next, under Attachments choose Record and choose the other instance
Click Start recording
Go back to the other insatnce, and repro the problem
Click Stop Recording
Send on the Report and link the developer community item when it gets sent via email

This will give us traces that help us figure out the root cause.

Nevermind, strike that - I missed we had a 100% repro on our side. If you are hitting other performance issues in the future in other areas, follow the above steps.

Just as an update, with Spreads under test, we identified a hot spot where things are being needlessly recomputed deep in the language service causing a 5-8+ second delay every time. When we profile Spreads converted back to old-style SDK, that hot spot is instant, and completion performance is what we would expect.
Clearly, something is not being wired up at a top level, but we're not sure what it is yet. More digging is underway...

I believe this should resolve it: https://github.com/Microsoft/visualfsharp/pull/4889
This solves the issues in Area51 and Spreads that I managed to reproduce.

Cool, thanks for looking into this so deeply! When it will be available at
least in the nightly build?
On Sat, May 12, 2018, 5:01 AM Will Smith<EMAIL_ADDRESS>wrote:

I believe this should resolve it: #4889
https://github.com/Microsoft/visualfsharp/pull/4889
This solves the issues in Area51 and Spreads that I managed to reproduce.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/visualfsharp/issues/4209#issuecomment-388522563,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAd5fL8m_UrLIAj9yafNAhFfDECC-Lbpks5txkKCgaJpZM4Rh9_8
.

This should be available in nightlies once merged, yes.

@0x53A @buybackoff
I have to be a little more accurate here. I think when we get this fix out it should fix a lot of problems and you will see better results.
However, both of your projects still have a problem: multi-targeting. I did some testing today and multi-targeted projects will cause invalidation and rebuild chunks of the world. I don't know how complicated it is to fix, but I have a good understanding now of what's happening in our tooling to probably start trying to fix it.
From your projects, when using the fix here: #4889, completions and intellisense tend to be faster on immediate use. When you start using a bit more, you will notice it will take longer sometimes; that's due to invalidation from multi-targeting.
Removing multi-targeting and just doing one target, you shouldn't have an issues once the fix is in place.

@TIHan I could live with only .NET Standard 2.0 and have started to remove full .NET Framework target in an active branch. .NET 4.6.1, which supports standard 2.0, is old enough, and I have had needless pain with supporting 4.5.x. So if you have to choose between an ideal solution vs quick fix then please ship it ASAP for a single target.

Latest nightly works approximately as fast as Rider for autocomplete. Thanks!

@buybackoff Thanks for the followup!

I'll close this out and open a separate issue about perf for multitargeting, so that there isn't a multi-page issue to find out the current state of things.

Modified milestone to reflect that we're attempting to get this into a servicing branch.

@buybackoff Not sure how this is on your machine, but with latest master of Spreads the solution won't compile, and I noticed that anything involving this in SortedMap will fail due to its inherited type (ContainerSeries<'K, 'V, SortedMapCursor<'K, 'V>>) being defined in a project which doesn't compile. Various other things seem to not work due to this.
Example of what's unresolved:

I do get IntelliSense, just not for things which are defined elsewhere (and failing to build):

This is with the May 25th nightlies atop 15.7.2. Is this consistent with what you're noticing?

On master in Spreads only 4 projects should complile (the head one is
Spreads.Core.Tests, others are WIP). I try to push only what complies and
am reworking everything else. Yet I could run tests from R# in the project
..Tests.Core (the only one alive S..Tests.Core), everything compiles. But
IDE is broken again.
Did the working one make into 15.7.2? Maybe I should just not use nightly.
On Sat, May 26, 2018, 2:18 AM Phillip Carter<EMAIL_ADDRESS>wrote:

@buybackoff https://github.com/buybackoff Not sure how this is on your
machine, but with latest master of Spreads the solution won't compile, and
I noticed that anything involving this in SortedMap will fail due to its
inherited type (ContainerSeries<'K, 'V, SortedMapCursor<'K, 'V>>) being
defined in a project which doesn't compile. Various other things seem to
not work due to this.
Example of what's unresolved:
[image: image]
https://user-images.githubusercontent.com/6309070/40569303-5592b4de-6035-11e8-9922-4b7ecf28ebd7.png
I do get IntelliSense, just not for things which are defined elsewhere
(and failing to build):
[image: image]
https://user-images.githubusercontent.com/6309070/40569517-18d38814-6037-11e8-9a5c-325f92b8a347.png
This is with the May 25th nightlies atop 15.7.2. Is this consistent with
what you're noticing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/visualfsharp/issues/4209#issuecomment-392211492,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAd5fCnRTU2Eh3BL4GGanZXY07mtOKCoks5t2JEugaJpZM4Rh9_8
.

@buybackoff I believe 15.7.2 contains one of the fixes, but not the multitargeting one. Since Spreads.sln is still using multitargeting, it's likely to be slow.
That said, the experience noted above is venturing into undefined behavior. Completion on this when the inheriting from something that isn't resolved currently doesn't exist as far as I can tell, though I think that has more to do with error recovery of the compiler than tools.
It's arguable that failing to resolve an inheritance context shouldn't affect other areas (.e.g, the dictionary parameter to the default constructor of SortedMap being seen as unused), but I believe this has more to do with the compiler than with IDE tooling. I could be wrong, but there are various places where error recovery of the compiler prevents the tools from doing the right thing, and this looks like one of them.
The only true solution to that is to rewrite the parser to focus on error recovery (like the Roslyn team did for C#), but this is a large undertaking that is currently not as important as other performance issues, such as high memory usage and paying off years of technical debt w.r.t GC pause times under various scenarios. We get bit by it as well and want to do this, but the current work list of things we must do w.r.t performance and technical debt is quite large.

How to easily install a concrete nightly version that worked several days ago? I have retargeted F# to only netstandard2.0 and everything worked very well with the nightly after the first fix (without multitargeting), but stopped working after restarting VS and new nightly automatically installed. This definitely not related to Spreads, a standalone Deedle (that targets .NET 4.0) doesn't have autocompletion even on List members.
The only change I did in additional to VS restart (and the reason to restart) is updating R# to 2018.1.1. But suspending it doesn't change anything in F#.

(On mobile, hence brief reply)
Instructions here:
https://blogs.msdn.microsoft.com/dotnet/2017/03/14/announcing-nightly-releases-for-the-visual-f-tools/
On Sat, May 26, 2018, at 10:35, Victor Baybekov wrote:

How to easily install a concrete nightly version that worked several
days ago? I have retargeted F# to only netstandard2.0 and everything
worked very well with the nightly after the first fix (without
multitargeting), but stopped working after restarting VS and new
nightly automatically installed. This definitely not related to
Spreads, a standalone Deedle (that targets .NET 4.0) doesn't have
autocompletion even on List members.> The only change I did in additional to VS restart (and the reason to
restart) is updating R# to 2018.1.1. But suspending it doesn't change
anything in F#.> — You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub[1], or mute the
thread[2].

Links:

https://github.com/Microsoft/visualfsharp/issues/4209#issuecomment-392276439
https://github.com/notifications/unsubscribe-auth/AGBEzngpNEWGRPharFG_bhoD67L9Ucezks5t2ZJ3gaJpZM4Rh9_8

@buybackoff Do you have a repro for what you mentioned here?

This definitely not related to Spreads, a standalone Deedle (that targets .NET 4.0) doesn't have autocompletion even on List members.

Various files seem fine for me with Deedle.sln:

This is with the may 25th nightlies installed into 15.7.2.

@cartermp that's weird but now I have it working even in Spreads and seems like understand the reason: my copy of Deedle was not built and I disabled the automatic build of Spreads's F# project (Collections) while testing its dependency (Core) to save time on build while making many small changes in the Core project. If I clean the F# project in Spreads I could reproduce that there is no autocomplete.
Yet definitely I was running tests that used the F#-produced dll, but it was not rebuilt while it dependency was changing. When I delete obj folder I could run tests with the F#-produced dll and at the same time IDE for F# is not working. It starts working after rebuilding the F# project. So maybe at some point the content of the obj folder in F# project became incompatible with it's dependency and autocomplete failed. Or something else.

There are some known issues around /obj in the new project system that have to be worked through. So if deleting that folder made things better, then it sounds like you ran into one of those. They're difficult to reproduce, unfortunately, so I don't know of a repro off-hand that you can observe on any machine.


Adding crosstab that defaults to pandas to modin.pandas

What do these changes do?

Adds crosstab to modin.pandas
Related issue number
Resolves #366

[x] passes git diff upstream/master -u -- "*.py" | flake8 --diff
[x] passes black --check modin/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/222/
Test PASSed.


Updates

TODO bump version and also bump sdk version when it publishes

Outdated. These changes got added to master


[Open Question] Where is GeographyV2 library for python?

I am a customer of LUIS, and there are many prescription about the prebuilt entities in LUIS on the Microsoft documentation: https://docs.microsoft.com/en-us/azure/cognitive-services/luis/luis-reference-prebuilt-geographyv2.  However, some of them are not available or not released. I am wondering that when others entities library (e.g. GeographyV2) for python will publish on https://github.com/Microsoft/Recognizers-Text/tree/master/Python/libraries ?

Hi @Mary268,
while LUIS leverages Recognizers-Text for their base-type prebuilt entities, not all of their entities come from this project. GeographyV2 and Person use completely different pipelines from the recognizers here.
As such, they are not part of the project and won't be released through here.
Unfortunately, we're also not aware of any plans to release those outside of LUIS.


Add core.intercom queue in rootQueueList in api/msg/post.js

https://github.com/Shippable/pm/issues/9731

this is done


fix: remove deprecated data source

See https://www.terraform.io/docs/providers/helm/d/repository.html
I think this should have the same behavior.

Ah. Didn't see the big updates in the main repo. Sorry, will update PR.

@toabi Thanks for this! The checks failed because the docs were not updated. Can you run terraform_docs to update the readme as well? If not I can make the change so we can merge this.

LGTM, thanks again!


Tidy up equipment and weapons area

General once-over
Check in different themes - felsl ike some of them don't play well
See #820 and #821

Regarding Delete Buttos (Just discovered your Answer);
Deleting Items happens a lot when managing inventory or transfering items. Its not an issiue with items in the sidebar, but currently it feels clunky as you can easiliy add an item mit Drag and Drop or Creating it on sheet but you have to go 2 Levels to remove it from the sheet.


Add a fading effect to the right side of tables with horizontal scrolling

Add a fading effect to the right side of tables with horizontal scrolling
The larger tables that necessitate a horizontal scroll bar need to have a fading effect on the right side. This is to indicate to users that they can scroll horizontally.
@bherr2 mentioned that he can assist with this if @bhushankhope needs help.
Currently, the ASCT+B Table page is the only area requiring this, but should tables expand elsewhere, the functionality will need to be mirrored there.
To Do

[ ] Add fading effect to the right side of the table on any tables with horizontal scrolling.

Resources

Example: Exploration User Interface for lower right side vertical scrolling fade
GitHub Link from Bruce

Example: Exploration User Interface's lower right side vertical scrolling fade

Added this feature in PR #187


A whitesourceUpdate error won't break the build

Even when the whitezourceUpdate task fails the sbt job is considered successful.
See for example: https://travis-ci.org/lagom/lagom/jobs/244524907#L707

secure env vars are not injected in PRs so using sbt-whitesource with Travis's secure features will always cause a task failure.
https://github.com/travis-ci/travis-ci/issues/1500#issuecomment-26122631
I think it's actually a feature that a whitesourceUpdate task failure doesn't cause a build failure.


Banner image not consuming complete space

Brief
The image in the banner is not taking up the entire banner width.
The issue can be seen at Link

I would like to work on the same.

@devshiva619
please put this to issue #1


why   var items = $("#grid").jsGrid("option", "data");	 Not working always return {}

<link type="text/css" rel="stylesheet" href="jsgrid.min.css" />
<link type="text/css" rel="stylesheet" href="jsgrid-theme.min.css" />

<form action="abc.jsp">

<Input type="submit">
</form>

<input type='Button' onClick="showGridDataJSON();" value="Show Grid Data as JSON">

click [ Show Grid Data as JSON ] always show {}

sample
But the author tell us get all data is
var items = $("#grid").jsGrid("option", "data");
Please put the name same as sample. This is very important sample . no data to get is useless .
WTF!! waste time to solve this problem.

sample

But the author tell us get all data is
var items = $("#grid").jsGrid("option", "data");
Please put the name same as sample. This is very important sample . no data to get is useless .
WTF!! waste time to solve this problem.


Cancelling an order appears to be unresponsive

Cancelling an order appears to be unresponsive. The color toggles on click, but doesn't seem to run the intended process.

HyperDEX 0.1.0-alpha.1
Electron 2.0.0

What is the status of the order when you click "Cancel"? (Pending, Swap 1/4, etc)

pending

This is a bug in marketmaker, more info here: https://github.com/lukechilds/hyperdex/issues/129


Removed the time announcement as it currently is incompatible with the...

...timezone given from the PagerDuty API resulting in the wrong time being announced as the on-call user's local time.
I didn't remove any of the supporting code as it may be useful in the future..

Happy to take this PR until I fix this properly.
Its currently broken due to the non-standard timezone strings returned from the PagerDuty API as documented here:
https://developer.pagerduty.com/documentation/rest/types
I had basically hardcoded a workaround for us as a temporary solution, but it's known broken in other situations so I'm happy to remove the time announcement until this is fixed to work properly


Lzw predictor

Implemented type 2 predictor from the spec. It just says that colors are the difference from the previous color. Apparently that helps with compression.
Still need to add karma test.

Hi @m0ose. Thanks for your quick resolution. Unfortunately I don't think this is sufficient, as this covers only a very, very narrow use case (RGB). I'd prefer a solution that also handles other cases (non-RGB, and RGB-like scenarios: CMYK, YCbCr, etc...). Is it possible to do this directly in the LZW decoder? In this case, everything should work as expected.

Hi @m0ose: I implemented a solution (#14) that works with both LZW and the Deflate, as it uses the loop in _readRasters.
I also found that the LZW breaks with Float32 for some reason.

Abandoned in favour of a more elegant solution.


Created provider for cron expressions.

Created provider to produce valid cron expressions, both basic and extended (as indicated by Wikipedia's format section).
Also provided methods for the individual Cron fields.

Thanks for your contribution. In my opinion, it's a bit too specific for Faker. I suggest you host a standalone provider in your own GitHub account (like I did for CompanyNameGenerator), I'll be happy to link to it in the README.

I'm sorry to hear that, but I went ahead and followed your advice and created swekaj/CronExpressionGenerator.

Thanks, I mentioned it in the README in aca1dacd6188860684fc344880052f7fa94f709a

Thanks!


Question if PR will be accepted

Hi guys.
Not sure how I can request a feature before I build it to see if it will be accepted. At ThingConverter you are doing the right thing when ignoring a type of https://schema.org./product with a lowercase first letter.
Unfortunately I'm crawling a site that do not respect the full schema.org contract and are using a lowercase first letter. If I change the preg_match in ThingsConverter to preg_match('/https?\:\/\/schema.org\/([a-zA-z0-9]+)$/', $schemaOrgId, $matches) === 1 it all works because now it doesn't have to be an uppercase first letter.
Would this be OK otherwise I will have to extend the package by creating my own SchemaReader and own ThingsConverter which would be fine but would you accept this change?
Thanks for a great package!

Hi, it depends on whether the thing names are case-sensitive, in which case I'd be happy to accept a PR to change this.
Can you find a reference somewhere?

Thanks for your quick response @BenMorel . I should have done this research before but it looks like Schema is case-sensitive so we shouldn't change this. This is from Google Note: Schema.org markup can be used on web pages written in any language. The markup, like HTML, is in English. Schema.org values are case-sensitive..
What do you think is the best way for me to solve this? It will be hard but maybe I can parse the HTML before I send it to the ThingsConverter and look for all https://schema.org/product and change it to https://schema.org/Product. Just a little bit concerned if I have to do this for every corner-case that I find.

Schema.org values are case-sensitive.

I'm still not sure what they understand by values. I'd rather try to find this information on https://schema.org/ if it exists!
Otherwise, TBH I'm not sure what value case-sensitivity brings, I mean, nobody will ever create a schema.org/product to compete with schema.org/Product, so even if the spec says that it should be case-sensitive, I wouldn't be against a boolean configuration somewhere to make it lenient and therefore case-insensitive.
But let's first be 100% sure that it's supposed to be case-sensitive, before introducing a setting.
Also please test the output of the Google Structured Data Testing Tool and Yandex Structured data validator to see how they behave with a lowercase product.

I agree. Don't see why we should completely dismiss the item if it's a little bit misspelled. Maybe go with just checking https://schema.org like you say would be sufficient. I think so.
The Yandex tool was down for me but with Google Structured Data Testing Tool it does recognize https://schema.org/product as a Thing. This is the URL that I'm using https://www.telia.se/privat/telefoni/telefoner/produkt/sony-xperia-5-ll.
Personally I don't think that this needs a setting because it's pretty clear that they have tried to put in structured data and Google are accepting it as well.

I can confirm that Google handles it case-insensitively.
I could not find a better source for case sensitivity, but this link says:

While Schema.org vocabulary is case sensitive (and you can enable this option), Google is not as strict – so this isn’t required for Google rich result features and their understanding of structured data.

I think it could make sense to make case sensitivity an option, still.

I agree that a config wouldn't hurt but I think default should be case-insensitively. Where do you think a config like this should reside?
Do you then find it sufficient to "only" build up the preg_match string depending on this config at ThingsConverter like
$pattern = $caseInsensitively ? '[a-zA-z0-9]' : '[A-Za-z0-9]';

if (preg_match("/https?\:\/\/schema.org\/([{$pattern}]+)$/", $schemaOrgId, $matches) === 1) {
    //
}

This would probably have to go into ObjectFactory, since only there it will be known what properties exist. The regexp in ThingsConverter already matches both, the order in the character group does not matter.
In ObjectFactory, it could be something like this to determine the types in the build function:
        $types = array_map(function(string $type) {
           if(isset($this->propertiesByType[$type])) {
              return $type;
           }
           foreach(array_keys($this->propertiesByType) as $potentialType) {
              if(strtolower($potentialType) === strtolower($type)) {
                 return $potentialType;
              }
           }
           return null;
        }, $types);

        $types = array_filter(array_values($types));

Which isn't super efficient, but it'll get the job done. I guess the best way to make it configurable would be to have the config live as a property on SchemaReader and then pass it as a parameter into ThingConverter, which would pass it into ObjectFactory, wouldn't it?


Add grep exercise

Uses node.js API and coding standards.

@librorumque did you intend to act on the feedback you received here?
Let us know if we should expect this PR to be updated, thank you!


CMS access for update of the static pages

the CMS access /admin#/ is still connected to Gitlab and leads to the following error: The authorization server does not support this response type. when trying to connect.
While waiting for access via Github accounts, I'm preparing materials for update of the static pages here, and I have a few comments/questions:

I've collected better quality images to replace the bad ones.
@stefanprobst Is it possible to embed videos on static pages? I'd like to add this one on one of the about pages.
for the API documentation section (p.18), @stefanprobst and @KlausIllmayer , I'd need your review: @stefanprobst because I'm not sure at all about the widget format, although I've tried out some suggestions in the gdoc; @KlausIllmayer to make sure you agree with the use cases described in this section.

@stefanprobst once CMS access is solved, can you tell me again on which instance I should work to implement the changes? I believe the dev one - https://sshoc-marketplace.acdh-dev.oeaw.ac.at/admin#/ -, but I'm not sure anymore

you should now be able to sign in via https://marketplace.sshopencloud.eu/admin
published content will be pushed directly to the production deployment.

it is possible to embed youtube videos via iframe - but i don't think we have a cms editor widget for this currently - easiest would be to copypaste the embed markup from youtube directly in the .md file - or we could steal the Video cms editor widget from dariah campus

Thanks a lot!!
I got an error while trying to publish: "Failed to persist entry: API_ERROR: At least 1 approving review is required by reviewers with write access."

ah sorry, removed branch protection, should work now (i hope)

Yes, it works! That's great! Thanks a lot Stefan :)

I was a bit too optimistic too fast! I got some failed jobs for the last two publications.
The changes are saved on the CMS side, but I got the same error twice on deployment.

that's because of autolinks in mdx. i'll change those.

sorry to bother again...
I'd like to create a new entry in the about pages, but I can't via the CMS. Can I add a file directly here or do you prefer to do it? In case the title of the page and in the menu should be "API Documentation" and the position "5".

yep, exactly, just add a file in that folder with the .page.mdx extension (already did it now for this page).
you can also try enabling adding about pages via cms by changing this setting.

could you retitle the issue to reflect what is still missing here? only thing missing is api docs, correct? thanks!

Indeed, only the API documentation still needs to be finalised.
In this doc, (p.18), I have a draft that needs your review @stefanprobst and @KlausIllmayer.

@stefanprobst because I'm not sure at all about the widget format, although I've tried out some suggestions in the gdoc;
@KlausIllmayer to make sure you agree with the use cases described in this section.

In the meantime, I'll proceed with a first online version for things that I'm sure about, adding a 'under construction' warning on the top of the page.

Hi @stefanprobst! Thx for opening the cms for the stage instance too. I'm now able to log in to both main and stage CMS.
Nonetheless, I managed to publish content on stage only once. And got failed actions after this one time. Everything seems to work well with the prod/main branch.
My question is: what should I do if I pushed changes to stage, but the action failed, can I push the same changes via the prod CMS. I remember you saying no! How should I proceed then? Thx!

we should decide on 1 workflow: either push to main (i.e. log into the production instance), which means changes go live on the prod site as soon as the action finished. or only push to stage, and manually merge changes to main (i.e. push to the prod site). otherwise the two branches diverge.
generally speaking though, publishing to stage via cms should work just fine. the most recent stage action points to a syntax error: https://github.com/SSHOC/sshoc-marketplace-frontend/actions/runs/4041810500/jobs/6949917228#step:6:318