[ 98%] Linking CXX executable ../bin/amun - crash

Make crashes when linking CXX executable ../bin/amun
I use CMake 3.5.1, GCC/G++ 4.9, Boost 1.54
Do you have any idea what this could be related to? I'm very sorry for this newbie question!
[ 98%] Linking CXX executable ../bin/amun
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp: In function ‘History Tran                                     slationTask(const string&, size_t)’:
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:35:50: error: no matching                                      function for call to ‘Search::Decode(Sentence)’
return search->Decode(Sentence(taskCounter, in));
^
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:35:50: note: candidate is:
In file included from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:11:0                                     :
/home/sariyildiznureddin/amunmt/src/./common/search.h:14:34: note: boost::shared                                     _ptr Search::Decode(const Sentences&)
boost::shared_ptr Decode(const Sentences& sentences);
^
/home/sariyildiznureddin/amunmt/src/./common/search.h:14:34: note:   no known co                                     nversion for argument 1 from ‘Sentence’ to ‘const Sentences&’
In file included from /home/sariyildiznureddin/amunmt/src/./common/search.h:8:0,
from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:11:
/home/sariyildiznureddin/amunmt/src/./common/history.h: In lambda function:
/home/sariyildiznureddin/amunmt/src/./common/history.h:20:5: error: ‘History::Hi                                     story(const History&)’ is private
History(const History &) = delete;
^
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:65:48: error: within this                                      context
[=]{ return TranslationTask(s, i); }
^
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:65:48: error: use of delet                                     ed function ‘History::History(const History&)’
In file included from /home/sariyildiznureddin/amunmt/src/./common/search.h:8:0,
from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:11:
/home/sariyildiznureddin/amunmt/src/./common/history.h:20:5: note: declared here
History(const History &) = delete;
^
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp: In function ‘boost::pytho                                     n::list translate(boost::python::list&)’:
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:74:44: error: no matching                                      function for call to ‘Printer(History, size_t, std::stringstream&)’
Printer(result.get(), lineCounter++, ss);
^
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:74:44: note: candidates ar                                     e:
In file included from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:12:0                                     :
/home/sariyildiznureddin/amunmt/src/./common/printer.h:12:6: note: template void Printer(const History&, OStream&)
void Printer(const History& history, OStream& out) {
^
/home/sariyildiznureddin/amunmt/src/./common/printer.h:12:6: note:   template ar                                     gument deduction/substitution failed:
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:74:44: note:   candidate e                                     xpects 2 arguments, 3 provided
Printer(result.get(), lineCounter++, ss);
^
In file included from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:12:0                                     :
/home/sariyildiznureddin/amunmt/src/./common/printer.h:65:6: note: template void Printer(const Histories&, OStream&)
void Printer(const Histories& histories, OStream& out) {
^
/home/sariyildiznureddin/amunmt/src/./common/printer.h:65:6: note:   template ar                                     gument deduction/substitution failed:
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:74:44: note:   cannot conv                                     ert ‘std::future<_Res>::get() with _Res = History’ (type ‘History’) to type                                      ‘const Histories&’
Printer(result.get(), lineCounter++, ss);
^
In file included from /home/sariyildiznureddin/amunmt/src/./common/search.h:8:0,
from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:11:
/usr/include/c++/4.9/future: In instantiation of ‘_Res std::future<_Res>::get()                                      [with _Res = History]’:
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:74:24:   required from her                                     e
/home/sariyildiznureddin/amunmt/src/./common/history.h:20:5: error: ‘History::Hi                                     story(const History&)’ is private
History(const History &) = delete;
^
In file included from /home/sariyildiznureddin/amunmt/src/./common/threadpool.h:                                     35:0,
from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:10:
/usr/include/c++/4.9/future:700:58: error: within this context
return std::move(this->_M_get_result()._M_value());
^
/usr/include/c++/4.9/future:700:58: error: use of deleted function ‘History::His                                     tory(const History&)’
In file included from /home/sariyildiznureddin/amunmt/src/./common/search.h:8:0,
from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:11:
/home/sariyildiznureddin/amunmt/src/./common/history.h:20:5: note: declared here
History(const History &) = delete;
^
In file included from /home/sariyildiznureddin/amunmt/src/./common/threadpool.h:                                     35:0,
from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:10:
/usr/include/c++/4.9/future: In instantiation of ‘static std::__future_base::_Ta                                     sk_setter<_Res_ptr> std::__future_base::_S_task_setter(_Res_ptr&, _BoundFn&&) [w                                     ith _Res_ptr = std::unique_ptr<std::__future_base::_Result, std::__futu                                     re_base::_Result_base::_Deleter>; _BoundFn = std::_Bind_simple<std::reference_wr                                     apper<std::_Bind<translate(boost::python::list&)::<lambda()>()> >()>; typename _                                     Res_ptr::element_type::result_type = History]’:
/usr/include/c++/4.9/future:1318:70:   required from ‘void std::_future_base::                                     Task_state<_Fn, _Alloc, _Res(_Args ...)>::_M_run(_Args ...) [with _Fn = std::_Bi                                     nd<translate(boost::python::list&)::<lambda()>()>; _Alloc = std::allocator;                                      _Res = History; _Args = {}]’
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:85:1:   required from here
/usr/include/c++/4.9/future:539:57: error: could not convert ‘std::ref(_Tp&) wi                                     th _Tp = std::_Bind_simple<std::reference_wrapper<std::_Bind<translate(boost::py                                     thon::list&)::<lambda()>()> >()>’ from ‘std::reference_wrapper<std::_Bind_sim                                     ple<std::reference_wrapper<std::_Bind<translate(boost::python::list&)::<lambda()                                     >()> >()> >’ to ‘std::function<History()>’
return _Task_setter<_Res_ptr>{ __ptr, std::ref(__call) };
^
In file included from /home/sariyildiznureddin/amunmt/src/./common/search.h:8:0,
from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:11:
/usr/include/c++/4.9/functional: In instantiation of ‘_Res std::function<_Res(_A                                     rgTypes ...)>::operator()(_ArgTypes ...) const [with _Res = History; _ArgTypes =                                      {}]’:
/usr/include/c++/4.9/future:1241:6:   required from ‘_Ptr_type std::__future_bas                                     e::_Task_setter<_Res_ptr, _Res>::operator()() [with _Ptr_type = std::unique_ptr<                                     std::__future_base::_Result, std::__future_base::_Result_base::_Deleter                                     >; _Res = History]’
/usr/include/c++/4.9/functional:2024:10:   required from ‘static _Res std::_Func                                     tion_handler<_Res(_ArgTypes ...), _Functor>::_M_invoke(const std::_Any_data&, _A                                     rgTypes ...) [with _Res = std::unique_ptr<std::__future_base::_Result_base, std:                                     :__future_base::_Result_base::_Deleter>; _Functor = std::__future_base::_Task_se                                     tter<std::unique_ptr<std::__future_base::_Result, std::_future_base::                                     Result_base::_Deleter>, History>; _ArgTypes = {}]’
/usr/include/c++/4.9/functional:2428:19:   required from ‘std::function<_Res(_Ar                                     gTypes ...)>::function(_Functor) [with _Functor = std::__future_base::_Task_sett                                     er<std::unique_ptr<std::__future_base::_Result, std::__future_base::_Re                                     sult_base::_Deleter>, History>;  = void; _Res = std::uni                                     que_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Del                                     eter>; _ArgTypes = {}]’
/usr/include/c++/4.9/future:1319:2:   required from ‘void std::__future_base::_T                                     ask_state<_Fn, _Alloc, _Res(_Args ...)>::_M_run(_Args ...) [with _Fn = std::_Bin                                     d<translate(boost::python::list&)::<lambda()>()>; _Alloc = std::allocator;                                      _Res = History; _Args = {}]’
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:85:1:   required from here
/home/sariyildiznureddin/amunmt/src/./common/history.h:20:5: error: ‘History::Hi                                     story(const History&)’ is private
History(const History &) = delete;
^
In file included from /usr/include/boost/system/error_code.hpp:23:0,
from /usr/include/boost/chrono/detail/system.hpp:12,
from /usr/include/boost/chrono/system_clocks.hpp:64,
from /usr/include/boost/chrono/chrono.hpp:13,
from /usr/include/boost/timer/timer.hpp:14,
from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:4:
/usr/include/c++/4.9/functional:2440:71: error: within this context
return _M_invoker(_M_functor, std::forward<_ArgTypes>(__args)...);
^
/usr/include/c++/4.9/functional:2440:71: error: use of deleted function ‘History                                     ::History(const History&)’
In file included from /home/sariyildiznureddin/amunmt/src/./common/search.h:8:0,
from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:11:
/home/sariyildiznureddin/amunmt/src/./common/history.h:20:5: note: declared here
History(const History &) = delete;
^
/usr/include/c++/4.9/future: In instantiation of ‘void std::__future_base::_Resu                                     lt<_Res>::_M_set(_Res&&) [with _Res = History]’:
/usr/include/c++/4.9/future:1241:6:   required from ‘_Ptr_type std::__future_bas                                     e::_Task_setter<_Res_ptr, _Res>::operator()() [with _Ptr_type = std::unique_ptr<                                     std::__future_base::_Result, std::__future_base::_Result_base::_Deleter                                     >; _Res = History]’
/usr/include/c++/4.9/functional:2024:10:   required from ‘static _Res std::_Func                                     tion_handler<_Res(_ArgTypes ...), _Functor>::_M_invoke(const std::_Any_data&, _A                                     rgTypes ...) [with _Res = std::unique_ptr<std::__future_base::_Result_base, std:                                     :__future_base::_Result_base::_Deleter>; _Functor = std::__future_base::_Task_se                                     tter<std::unique_ptr<std::__future_base::_Result, std::_future_base::                                     Result_base::_Deleter>, History>; _ArgTypes = {}]’
/usr/include/c++/4.9/functional:2428:19:   required from ‘std::function<_Res(_Ar                                     gTypes ...)>::function(_Functor) [with _Functor = std::__future_base::_Task_sett                                     er<std::unique_ptr<std::__future_base::_Result, std::__future_base::_Re                                     sult_base::_Deleter>, History>;  = void; _Res = std::uni                                     que_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Del                                     eter>; _ArgTypes = {}]’
/usr/include/c++/4.9/future:1319:2:   required from ‘void std::__future_base::_T                                     ask_state<_Fn, _Alloc, _Res(_Args ...)>::_M_run(_Args ...) [with _Fn = std::_Bin                                     d<translate(boost::python::list&)::<lambda()>()>; _Alloc = std::allocator;                                      _Res = History; _Args = {}]’
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:85:1:   required from here
/home/sariyildiznureddin/amunmt/src/./common/history.h:20:5: error: ‘History::Hi                                     story(const History&)’ is private
In file included from /home/sariyildiznureddin/amunmt/src/./common/threadpool.h:                                     35:0,
from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:10:
/usr/include/c++/4.9/future:238:4: error: within this context
::new (_M_storage._M_addr()) _Res(std::move(__res));
^
/usr/include/c++/4.9/future:238:4: error: use of deleted function ‘History::Hist                                     ory(const History&)’
In file included from /home/sariyildiznureddin/amunmt/src/./common/search.h:8:0,
from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:11:
/home/sariyildiznureddin/amunmt/src/./common/history.h:20:5: note: declared here
History(const History &) = delete;
^
make[2]: *** [src/CMakeFiles/amunmt.dir/python/amunmt.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/amunmt.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
/tmp/ccwELx9c.ltrans1.ltrans.o: In function std::_Function_handler<void (), std                                     ::reference_wrapper<std::_Bind_simple<std::reference_wrapper<std::_Bind<main::{l                                     ambda()#2} ()> > ()> > >::_M_invoke(std::_Any_data const&) [clone .lto_priv.954]                                     ': <artificial>:(.text+0x2ad4): undefined reference to TranslationTask(boost::shar                                     ed_ptr, unsigned long, unsigned long)'
/tmp/ccwELx9c.ltrans1.ltrans.o: In function std::_Function_handler<void (), std                                     ::reference_wrapper<std::_Bind_simple<std::reference_wrapper<std::_Bind<main::{l                                     ambda()#1} ()> > ()> > >::_M_invoke(std::_Any_data const&) [clone .lto_priv.952]                                     ': <artificial>:(.text+0x2b84): undefined reference to TranslationTask(boost::shar                                     ed_ptr, unsigned long, unsigned long)'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/amun] Error 1
make[1]: *** [src/CMakeFiles/amun.dir/all] Error 2
make: *** [all] Error 2

Hi!

Does look like a bug to me because in path/to/amunmt/src/python/amunmt.cpp:35, a Sentence type is passed, while Decode function actually asks for Sentences type.
Shuoyang

Hm, cannot reproduce this. Which g++ version exactly are you using?

4.9.2 for me.

Do you have the possibility to try a higher version? We can confirm that for instance 5.4 works perfectly. I will try to experiment with 4.9.2 later today.

Sure. Will let you know when I do.

I tried 5.4 but still no luck.

try these commands, in this order:
git pull
make clean
make
If you have problems, please paste the exact error message
Hieu Hoang
http://moses-smt.org/
On 20 January 2017 at 00:24, Mehmed Sariyildiz<EMAIL_ADDRESS>wrote:

I tried 5.4 but still no luck.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/emjotde/amunmt/issues/22#issuecomment-273941323, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAqOFEdDMQzbsd6n5nKZ--jS6OrseTCjks5rT_6vgaJpZM4Lm_BI
.

Did as instructed but still:
[ 81%] Linking CXX executable ../bin/amun
CMakeFiles/amun.dir/common/decoder_main.cpp.o: In function std::_Function_handler<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> (), std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result<void>, std::__future_base::_Result_base::_Deleter>, std::_Bind_simple<std::reference_wrapper<std::_Bind<main::{lambda()#2} ()> > ()>, void> >::_M_invoke(std::_Any_data const&)': decoder_main.cpp:(.text+0x9c9): undefined reference to TranslationTask(God&, boost::shared_ptr, unsigned long, unsigned long)'
CMakeFiles/amun.dir/common/decoder_main.cpp.o: In function std::_Function_handler<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> (), std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result<void>, std::__future_base::_Result_base::_Deleter>, std::_Bind_simple<std::reference_wrapper<std::_Bind<main::{lambda()#1} ()> > ()>, void> >::_M_invoke(std::_Any_data const&)': decoder_main.cpp:(.text+0xb09): undefined reference to TranslationTask(God&, boost::shared_ptr, unsigned long, unsigned long)'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/amun] Error 1
make[1]: *** [src/CMakeFiles/amun.dir/all] Error 2
make: *** [all] Error 2

What linux distribution is this?

14.04

i've just checked in a change
https://github.com/emjotde/amunmt/commit/9e6952383ee5fc9e52652bfab8c8a786d9c7d315
can you please try again

Just tried:
[ 88%] Building CXX object src/CMakeFiles/libcommon.dir/common/processor/bpe.cpp.o
In file included from /home/sariyildiznureddin/amunmt/src/common/sentence.cpp:2:0:
/home/sariyildiznureddin/amunmt/src/common/sentence.h:25:26: error: ‘shared_ptr’ i                  n namespace ‘std’ does not name a template type
using SentencePtr = std::shared_ptr;
^
/home/sariyildiznureddin/amunmt/src/common/sentence.h:36:18: error: ‘SentencePtr’                   has not been declared
void push_back(SentencePtr sentence);
^
/home/sariyildiznureddin/amunmt/src/common/sentence.h:38:3: error: ‘SentencePtr’ d                  oes not name a type
SentencePtr at(size_t id) const {
^
/home/sariyildiznureddin/amunmt/src/common/sentence.h:53:16: error: ‘SentencePtr’                   was not declared in this scope
std::vector coll_;
^
/home/sariyildiznureddin/amunmt/src/common/sentence.h:53:27: error: template argum                  ent 1 is invalid
std::vector coll_;
^
/home/sariyildiznureddin/amunmt/src/common/sentence.h:53:27: error: template argum                  ent 2 is invalid
/home/sariyildiznureddin/amunmt/src/common/sentence.h: In member function ‘size_t                   Sentences::size() const’:
/home/sariyildiznureddin/amunmt/src/common/sentence.h:43:18: error: request for me                  mber ‘size’ in ‘((const Sentences*)this)->Sentences::coll_’, which is of non-class                   type ‘const int’
return coll_.size();
^
[ 89%] Building CXX object src/CMakeFiles/libcommon.dir/common/utils.cpp.o
/home/sariyildiznureddin/amunmt/src/common/sentence.cpp: At global scope:
/home/sariyildiznureddin/amunmt/src/common/sentence.cpp:49:27: error: variable or                   field ‘push_back’ declared void
void Sentences::push_back(SentencePtr sentence) {
^
/home/sariyildiznureddin/amunmt/src/common/sentence.cpp:49:27: error: ‘SentencePt                   ’ was not declared in this scope
[ 91%] Building CXX object src/CMakeFiles/libcommon.dir/common/vocab.cpp.o
make[2]: *** [src/CMakeFiles/libcommon.dir/common/sentence.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [src/CMakeFiles/libcommon.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 91%] Built target cpumode

This last error was a missing include. Fixed now, please try again.

This is what I get now. I'm so sorry for the inconveniencies I'm causing!!
[ 97%] Building CXX object src/CMakeFiles/amunmt.dir/common/loader_factory.cpp.o
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp: In function ‘History TranslationTask(const string&, size_t)’:
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:31:42: error: no matching function for call to ‘Search::Search(size_t&)’
search.reset(new Search(taskCounter));
^
In file included from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:11:0:
/home/sariyildiznureddin/amunmt/src/./common/search.h:12:5: note: candidate: Search::Search(God&, size_t)
Search(God &god, size_t threadId);
^
/home/sariyildiznureddin/amunmt/src/./common/search.h:12:5: note:   candidate expects 2 arguments, 1 provided
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:35:49: error: no matching function for call to ‘Sentence::Sentence(size_t&, const string&)’
return search->Decode(Sentence(taskCounter, in));
^
In file included from /home/sariyildiznureddin/amunmt/src/./common/scorer.h:7:0,
from /home/sariyildiznureddin/amunmt/src/./common/loader.h:6,
from /home/sariyildiznureddin/amunmt/src/./common/god.h:7,
from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:8:
/home/sariyildiznureddin/amunmt/src/./common/sentence.h:13:5: note: candidate: Sentence::Sentence(God&, size_t, const std::vector<std::basic_string >&)
Sentence(God &god, size_t vLineNum, const std::vectorstd::string& words);
^
/home/sariyildiznureddin/amunmt/src/./common/sentence.h:13:5: note:   candidate expects 3 arguments, 2 provided
/home/sariyildiznureddin/amunmt/src/./common/sentence.h:12:5: note: candidate: Sentence::Sentence(God&, size_t, const string&)
Sentence(God &god, size_t vLineNum, const std::string& line);
^
/home/sariyildiznureddin/amunmt/src/./common/sentence.h:12:5: note:   candidate expects 3 arguments, 2 provided
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp: In function ‘void init(const string&)’:
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:39:20: error: cannot call member function ‘God& God::Init(const string&)’ without object
God::Init(options);
^
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp: In function ‘boost::python::list translate(boost::python::list&)’:
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:43:53: error: cannot call member function ‘T God::Get(const string&) [with T = long unsigned int; std::string = std::basic_string]’ without object
size_t cpuThreads = God::Get<size_t>("cpu-threads");
^
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:74:44: error: no matching function for call to ‘Printer(History, size_t, std::stringstream&)’
Printer(result.get(), lineCounter++, ss);
^
In file included from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:12:0:
/home/sariyildiznureddin/amunmt/src/./common/printer.h:14:6: note: candidate: template void Printer(God&, const History&, OStream&)
void Printer(God &god, const History& history, OStream& out) {
^
/home/sariyildiznureddin/amunmt/src/./common/printer.h:14:6: note:   template argument deduction/substitution failed:
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:74:23: note:   cannot convert ‘std::future<_Res>::get() with _Res = History’ (type ‘History’) to type ‘God&’
Printer(result.get(), lineCounter++, ss);
^
In file included from /home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:12:0:
/home/sariyildiznureddin/amunmt/src/./common/printer.h:67:6: note: candidate: template void Printer(God&, const Histories&, OStream&)
void Printer(God &god, const Histories& histories, OStream& out) {
^
/home/sariyildiznureddin/amunmt/src/./common/printer.h:67:6: note:   template argument deduction/substitution failed:
/home/sariyildiznureddin/amunmt/src/python/amunmt.cpp:74:23: note:   cannot convert ‘std::future<_Res>::get() with _Res = History’ (type ‘History’) to type ‘God&’
Printer(result.get(), lineCounter++, ss);
^
make[2]: *** [src/CMakeFiles/amunmt.dir/python/amunmt.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/amunmt.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 98%] Linking CXX executable ../bin/amun
CMakeFiles/amun.dir/common/decoder_main.cpp.o: In function std::_Function_handler<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> (), std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result<void>, std::__future_base::_Result_base::_Deleter>, std::_Bind_simple<std::reference_wrapper<std::_Bind<main::{lambda()#1} ()> > ()>, void> >::_M_invoke(std::_Any_data const&)': decoder_main.cpp:(.text+0xed4): undefined reference to TranslationTask(God&, std::shared_ptr, unsigned long, unsigned long)'
CMakeFiles/amun.dir/common/decoder_main.cpp.o: In function std::_Function_handler<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> (), std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result<void>, std::__future_base::_Result_base::_Deleter>, std::_Bind_simple<std::reference_wrapper<std::_Bind<main::{lambda()#2} ()> > ()>, void> >::_M_invoke(std::_Any_data const&)': decoder_main.cpp:(.text+0x1004): undefined reference to TranslationTask(God&, std::shared_ptr, unsigned long, unsigned long)'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/amun] Error 1
make[1]: *** [src/CMakeFiles/amun.dir/all] Error 2
make: *** [all] Error 2

No reason to apologise.
Hieu, this looks like your changes are causing this, also can we make the python libs optional?

Thank you for your understanding. Your work is much appreciated!

FYI
Commit 3a548b3aa09f6d17db5383575fd24090688a610f works with me as well

FYI I'm on c96b2f20731842a1364db17e206d30447b64b4df and I'm able to compile.

compiling commit 3e5a5f2 (current) yields the following error:
In file included from /home/shuoyangd/nmt/amunmt/src/./common/hypothesis.h:4:0,
from /home/shuoyangd/nmt/amunmt/src/./common/scorer.h:6,
from /home/shuoyangd/nmt/amunmt/src/./common/loader.h:6,
from /home/shuoyangd/nmt/amunmt/src/./common/god.h:7,
from /home/shuoyangd/nmt/amunmt/src/common/filter.cpp:12:
/home/shuoyangd/nmt/amunmt/src/./common/soft_alignment.h:7:32: fatal error: thrust/host_vector.h: No such file or directory
#include <thrust/host_vector.h>
^
compilation terminated.
src/CMakeFiles/libcommon.dir/build.make:134: recipe for target 'src/CMakeFiles/libcommon.dir/common/filter.cpp.o' failed
make[2]: *** [src/CMakeFiles/libcommon.dir/common/filter.cpp.o] Error 1
CMakeFiles/Makefile2:215: recipe for target 'src/CMakeFiles/libcommon.dir/all' failed
make[1]: *** [src/CMakeFiles/libcommon.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

we've made more changes. git pull and make again

Everything works for me now. Thanks!

This sounds great.  I'll test it myself asap and keep you updated!

It's working!!!
Thank you!!!
I was able to build upon the latest commit.

Great, thank you for bringing this to our attention.


Added University of Nebraska

I created a new university file and added details about the University of Nebraska

Thanks Victory. I think the document here is referencing information from Dublin?

Closing due to lack of relevant info. I pinged Matt Germonprez asking if UNebraska should be included.


feat: Turborepo build-scripts rebase

Apparently renaming a branch with the github web console closes the old pull request and thread. Just wanted to follow the convention of the repo by putting my username as the starting token of the branch.
Relevant pull requests
https://github.com/latticexyz/mud/pull/657
https://github.com/latticexyz/mud/pull/644
Suggestion to make a rebase to this branch
https://github.com/latticexyz/mud/pull/644#issuecomment-1517105608
Also a heads up - commit https://github.com/latticexyz/mud/commit/60e62ebf70b0fe2fce39cd15b3d5b46120c34dd4 broke some of the hardhat doc generation. Converting certain packages to modules causes some compilation errors. There is a thread here with some claims support is coming soon.

Just wanted to follow the convention of the repo by putting my username as the starting token of the branch.

thanks! this pattern is useful when we're all operating out of the same repo to help determine who the branch was created by/owned by
will take a closer look at this once #633 lands

oops, this closed automatically since I merged the base branch


UX: Edit Authors

Working on ideas how to improve author editing. Currently you need to navigate a lot of modals to enter basic author data such as given names, surname.
Here's a UI idea, that allows quick editing and supports two author types (person and group). By clicking on edit you'll see another modal offering more detailed fields (such as ORCID, affiliations etc.)

Note, this view would be shown in authoring mode... we can have a more verbose QC view for author editing where we expose all fields.

Here's an updated Edit Person dialog, that allows basic editing of affiliations in-place.

Compared to the current UI this has some pros but also some cons e.g.:

Good: faster creation and editing of affiliations (no longer navigating dialogs)
Bad: Users may overlook that there's more fields (e.g. they could enter "Columbia University, United States" but it would be correct to add United States to the country field.

NOTE: Clicking "New Affiliation" could provide a selection of available affiliations (e.g. when entered already from another author's view). Then you decide either to pick an existing one or create a new one.

An alternative to in-place affiliation editing:
We could show a list of affiliations (using the display version of the affiliation) which you can expand to reach the form fields underneath.

We could apply the same to author editing, but then we'd get multiple editing levels (AuthorList > Edit Author > Edit Affiliation).

Here's another attempt, allowing in-place editing of authors, without an extra popup. Also see #452

This looks very nice and is surely much better than navigating modals. I just find it a bit awkward having the email between first and last names.

Yeah I just copied the existing forms which are generated from the schema and sometimes have weird order. We'll fix those things once we have decided on a UI/UX pattern.

How do you dismiss the forms once displayed?

By clicking on the author/affiliation name again. But we could have a separate button in the form, called something like "done editing" to make this more explicit.

@michael I think a modal panel is a better approach. Simply because it handles bigger forms more easily. In addition it scales better to smaller screens without wasting space. I think the show more options for inputs need to be very carefully considered, especially in the affiliation instance. I would avoid show more when you can and only use it for inputs that are rarely used or not key.
Generally, I think typical popup modals are fine for small pieces of information like 'Are you sure you want to do this? Yes, No' type actions, but complex forms with lots of inputs with hide/show behaviour may not be the best use for them.
Happy to discuss this further on a call or when you come to Cambridge. Hope this helps.

My experience with modals on small screens is not good. They often do not resize appropriately making me have to fiddle with panning to achieve what I need or to simply dismiss it. I blame this on design without responsiveness in mind.
That being said I think that the inline UI can yield a better UX if the forms are designed to be responsive and simple.

We must make sure this works well when there's a huge list of authors (like 100).

If composing a long list of authors like this is a real requirement then this current approach may not be the best.
An easier way IMO would be to do it with a spreadsheet-like UI having one author per row. Maybe the same for institutions and using regular numeral indexes to make the author institution links.
One alternative way would be to keep the current approach and just add a batch import feature that reads from a spreadsheet.

@michael please re-evaluate and decide what to do next (or close)

We have the metadata view now.


Allow Unsafe Code

This library allows unsafe code:

This will be a problem for deploying apps to stores like the Windows Store, and Google Play store.
Unsafe code can be used to increase performance, but it allows direct access to memory, so many analyzers and so on may consider the library to be malware because it is not known what the app may be doing to memory. As a general rule unsafe code should only be used when there are performance issues with device communication, but seeing that device communication is not generally an issue because of the small amounts of transfer, I don't think there will be performance issues.

We can probably remove this. Needed only for hid.dll.

The other option is to build two versions.

We don'tneed unsafe code.

@NicolasDorier , just FYI, someone at Microsoft are saying that their store will allow unsafe code:
https://social.msdn.microsoft.com/Forums/windowsapps/en-US/d7775be2-82b3-4ce2-a783-4956baeebfa4/allow-unsafe-code?forum=wpsubmit
Although, I don't really trust that this person knows what they are talking about.
I can't say if Unsafe is OK for Google Play or Apple stores though.

We can remove it, it is not needed anymore.


fix: Update refresh time for tenant level feature flags to avoid race condition

Description
The tenant level feature flags are pulled from Flagsmith from a cron job scheduled to run after every couple of hours. Also the refresh rate is set to exact same time as that of cron execution interval i.e. 120mins. This is creating a race condition because of which the latest feature flag may not get refreshed after each 2hrs but may take upto 4hrs i.e. next execution cycle. With current PR we are making sure the cron execution interval > refresh rate.

/ok-to-test

/ok-to-test


Switching between accounts belonging to the same contact is confusing

Describe the bug
I have multiple personal e-mail accounts integrated into k9 mail. Since the last update switching between them takes place via the sidebar. As they are all linked to my contact in the android address book, they all share my contact picture. This makes switching between accounts trial and error until you click the right one.
Expected behavior
A second indicator in the switch accounts view to distinguish between email accounts sharing the same contact picture.
Environment (please complete the following information):

K-9 Mail version: 5.800
Android version: 9
Device: Xiaomi Mix 2s
Account type: Various

I'm also finding this very hard to navigate. Here is a screenshot with the three identical pictures.

Even more confusing is that each icon links to a different account depending on the situation. Ideally we could customise the picture displayed. Alternatively (or in addition), the icons could be differentiated by colour (as per the previous version of K-9).

I created issue #5509 with a proposed solution. Closing this issue.


Space on font shown only as half the standard width in vscode?

VSCode Version: Visual Studio Code - Insiders
OS Version: OSX

Steps to Reproduce:

Install font https://github.com/gilescope/cyberpunkfonts/blob/master/audiowide-mono/Audiowide-Mono274.ttf
Type 'Audiowide' into editor font.

The space is half the width but fine in CLion for example. It's a crazy yet cool font if you want to try it, but I'd really like a hint how we can get the space to show up as the same width as all the normal chars.
I know this is very left field, but if anyone's got any hints please let me know!

FYI: The spaces used in vscode are not the 'space' char but a non breaking space char. - All fixed up now.


511 Add composite_key validation

Trello Ticket
Added Function, tests for unique together validation
How to test
Run tests

My understanding is that these values corresponded more to the unique_together constraint than the composite_key constraint. A composite key is used as a PK for a table, but the PK used for the tables in our db is the UUID "id" column. Then again, this is at the point of ingest, and we haven't actually generated our UUIDs at the point of validation. Do you know what the rationale is for composite_keys over unique_together?
 "composite_keys": ("Project ID", "Programme ID")

I do, however, have a bit of a concern about this.
These values can not act as a composite key in the database for the project_dim table as different rounds will have the same human-readable "Project ID", but unique ids; also, we expect all projects in "Project Details" to be unique at the point of ingest so I'm not entirely sure what the point of the composite key is anyway? It might not be an issue for validation of a given worksheet - where rounds will not interact - but I would have it's redundant code as each Project has to be unique at the point of ingest anyway, and a project can't belong to two different programmes.
I will test this with R1 data. Might be worth  getting some QA testing from Hrishi if you haven't already.

Falls over if try to ingest R1.

This is an unfortunate consequence of us being so rushed to get historical data in that we couldn't scaffold it with robust unit-testing, but for the time being we will have to QA test all ingest changes using both rounds as there's a possibility we will have to re-ingest R1.

Removed the R1 schema changes


Mixing HashMap and TreeMap

if properties is not null, DeepCopy is not applied. It causes mixing HashMap and TreeMap.
    protected SavedRevision putProperties(Map<String, Object> properties,
                                          String prevID,
                                          boolean allowConflict)
            throws CouchbaseLiteException {

        boolean hasTrueDeletedProperty = false;
        if (properties != null)
            hasTrueDeletedProperty = properties.get("_deleted") != null &&
                    ((Boolean) properties.get("_deleted")).booleanValue();
        boolean deleted = (properties == null) || hasTrueDeletedProperty;
        RevisionInternal rev = new RevisionInternal(documentId, null, deleted);
        if (properties != null)
            rev.setProperties(propertiesToInsert(properties));
        RevisionInternal newRev = database.putRevision(rev, prevID, allowConflict);
        if (newRev == null)
            return null;
        return new SavedRevision(this, newRev);
    }

In case of enabling SerializationFeature.ORDER_MAP_ENTRIES_BY_KEYS, Jackson recreates Map object with TreeMap if original Map object is not implemented SortedMap interface. So enabling ORDER_MAP_ENTRIES_BY_KEYS might not cause to create TreeMap twice.
https://github.com/FasterXML/jackson-databind/blob/faf68c561ceb5b9000cf6274b0c2435cc07b1ff8/src/main/java/com/fasterxml/jackson/databind/ser/std/MapSerializer.java#L1053-L1074


Step5 evaluation result very low

Have you ever had a situation where in Step 5 (model evaluation)，all the models searched were evaluated very low, that is, the AP value? I trained the supernet both on my own dataset and COCO dataset,  but all searched models had a very low AP during step 5, close to 0. However, when I evaluated the model using the script 'tools/test_net.py', the AP was greater than 0.6.

Have you ever had a situation where in Step 5 (model evaluation)，all the models searched were evaluated very low, that is, the AP value? I trained the supernet both on my own dataset and COCO dataset, but all searched models had a very low AP during step 5, close to 0. However, when I evaluated the model using the script 'tools/test_net.py', the AP was greater than 0.6.

+1.do you solve it?

Have you ever had a situation where in Step 5 (model evaluation)，all the models searched were evaluated very low, that is, the AP value? I trained the supernet both on my own dataset and COCO dataset, but all searched models had a very low AP during step 5, close to 0. However, when I evaluated the model using the script 'tools/test_net.py', the AP was greater than 0.6.

+1.do you solve it?

Yes, I have solved it. I found the bug is that 'cfg' is not the newest config in some scripts but the default config. You can modify the bug by these steps below. If you find a better solution, please let me know.

In maskrcnn_benchmark/modeling/backbone/shuffle_blocks.py, comment 'from maskrcnn_benchmark.config import cfg' and add 'cfg' as a parameter for 'ShuffleNetV2BlockSearched';
In maskrcnn_benchmark/pytorch_distributed_syncbn/syncbn.py, do same as above for 'DistributedSyncBN'.

Have you ever had a situation where in Step 5 (model evaluation)，all the models searched were evaluated very low, that is, the AP value? I trained the supernet both on my own dataset and COCO dataset, but all searched models had a very low AP during step 5, close to 0. However, when I evaluated the model using the script 'tools/test_net.py', the AP was greater than 0.6.

+1.do you solve it?

Yes, I have solved it. I found the bug is that 'cfg' is not the newest config in some scripts but the default config. You can modify the bug by these steps below. If you find a better solution, please let me know.

In maskrcnn_benchmark/modeling/backbone/shuffle_blocks.py, comment 'from maskrcnn_benchmark.config import cfg' and add 'cfg' as a parameter for 'ShuffleNetV2BlockSearched';
In maskrcnn_benchmark/pytorch_distributed_syncbn/syncbn.py, do same as above for 'DistributedSyncBN'.

Can you share your code? I'm a little confused.Thx!!  @barleyyuan

Have you ever had a situation where in Step 5 (model evaluation)，all the models searched were evaluated very low, that is, the AP value? I trained the supernet both on my own dataset and COCO dataset, but all searched models had a very low AP during step 5, close to 0. However, when I evaluated the model using the script 'tools/test_net.py', the AP was greater than 0.6.

+1.do you solve it?

Yes, I have solved it. I found the bug is that 'cfg' is not the newest config in some scripts but the default config. You can modify the bug by these steps below. If you find a better solution, please let me know.

In maskrcnn_benchmark/modeling/backbone/shuffle_blocks.py, comment 'from maskrcnn_benchmark.config import cfg' and add 'cfg' as a parameter for 'ShuffleNetV2BlockSearched';
In maskrcnn_benchmark/pytorch_distributed_syncbn/syncbn.py, do same as above for 'DistributedSyncBN'.

Can you share your code? I'm a little confused.Thx!! @barleyyuan

A simpler way:

In maskrcnn_benchmark/config/defaults.py Line 102 -->
_C.MODEL.BACKBONE.CHANNEL_SHUFFLE_METHOD = 1
In maskrcnn_benchmark/pytorch_distributed_syncbn.py Line 94 -->
def init(self, num_features, eps=1e-5, momentum=0.1, affine=True,

Hope it helpful for you!

Have you ever had a situation where in Step 5 (model evaluation)，all the models searched were evaluated very low, that is, the AP value? I trained the supernet both on my own dataset and COCO dataset, but all searched models had a very low AP during step 5, close to 0. However, when I evaluated the model using the script 'tools/test_net.py', the AP was greater than 0.6.

+1.do you solve it?

Yes, I have solved it. I found the bug is that 'cfg' is not the newest config in some scripts but the default config. You can modify the bug by these steps below. If you find a better solution, please let me know.

In maskrcnn_benchmark/modeling/backbone/shuffle_blocks.py, comment 'from maskrcnn_benchmark.config import cfg' and add 'cfg' as a parameter for 'ShuffleNetV2BlockSearched';
In maskrcnn_benchmark/pytorch_distributed_syncbn/syncbn.py, do same as above for 'DistributedSyncBN'.

Can you share your code? I'm a little confused.Thx!! @barleyyuan

A simpler way:
In maskrcnn_benchmark/config/defaults.py Line 102

_C.MODEL.BACKBONE.CHANNEL_SHUFFLE_METHOD = 1
-->
_C.MODEL.BACKBONE.CHANNEL_SHUFFLE_METHOD = 1
In maskrcnn_benchmark/pytorch_distributed_syncbn.py Line 94
def init(self, num_features, eps=1e-5, momentum=0.01, affine=True,
-->
def init(self, num_features, eps=1e-5, momentum=0.1, affine=True,
Hope it helpful for you!

@betterhalfwzm Have you solved the problem?

@betterhalfwzm Have you solved the problem?


File suggestions for Node require() function

It is quite annoying to keep working out the exact file path of a .js or .json file every time I want to include something, especially if I have to traverse backwards. Would it be possible to use the directory of the current document and the relative file being typed in to list file results that I would want to include?

We should provide this already. Can you try triggering suggestions using ctrl+space while typing out the path. If this does not work, please share small snippet showing where the require call is

Whoops, my mistake. Works for me. Sorry about this issue


Address failing test for resolve_alert_notifications

NOT FOR MERGE. I'm just using the diffs to illustrate the problem, which I imagine should result in opening of an issue (backend?)
When working on the Python client library lately, I noticed the example resolve_alert_notifications.py from the automated tests kept failing. By comparing what the Python was PUT-ing with the equivalent working operation from a browser, I determined that what was causing the failure was that the Python included this line in the JSON:
       "nonNullFilter": "host.hostName = 'ubuntu16'",

That is, much of how the Python client uses the REST API relies on the ability to GET some object, make some very minor change (in this case, setting resolved to true) and then PUT-ing the object back at the relevant endpoint to complete an update. In this PR I was able to force the example to start working again by manually deleting the nonNullFilter key before PUT-ing it back, but I doubt this is what we want. As far as I know this example used to work, so I'm not sure what changed, and if the right fix is for the GET to not return this key or for the endpoint receiving the PUT to silently accept it. I can open a separate issue for whatever is the appropriate course of action.

Here's a link to the output of the failing test before I made the change (shows the full JSON):
https://travis-ci.org/draios/python-sdc-client/builds/197492581


Add option to disable the SVG doctype

If you use the SVG as an inline object inside of a HTML document the extra doctype can lead to issues in rendering to prevent this there is no an extra option for the SVGWriter to disable the doctype.
reference: https://stackoverflow.com/a/38172170/548558
Fixes #60

This makes perfect sense. Would you mind adding a couple of tests for this so we can keep an eye of future regressions?
Thanks!

Thanks


libnuma: Warning: node argument 8 is out of range

In the Docker container, numactl does not recognize the NUMA node for High Bandwidth Memory (HBM). However, using 'numactl -H' reveals the corresponding node.
will show error:
libnuma: Warning: node argument 8 is out of range

HW/SW version:
kernel version: 5.15.0-spr.bkc.pc.16.1.23.x86_64
docker version: 24.0.6
host-numactl version: 2.0.16
container-numactl version: 2.0.14-3ubuntu2
docker run option: docker run -e http_proxy -e https_proxy -e no_proxy --privileged  --name wsf-78378ddc4d4ed --rm --detach xftbench-inference-lite:latest

I don't think it is the scope of xFT to fix it. (in fact, it cannot be fixed in xFT)
instead, we may need to think about how to launch xFT in case numactl not work.


format on save is not triggered with file auto-save

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.89.1
OS Version:  MS Windows 11 (opening a project with SSH from a Ubuntu 24.04)

Steps to Reproduce:

enable auto save
enable in setting.json editor.formatOnSave: true (format on save)
try a change that should trigger a formatting style.
unless the file is explicitly saved, (e.g. pressing ctrl+s) the format want be applied, even though the file was already saved by auto save.

EXPECTED RESULT:
The auto save should trigger all the events associated to the file saving functionality, in such case trigger the format on save, as the file has been saved (automatically).

It is explicitly disabled because it may change the character under your cursor.
//cc @jrieken

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

I'm also on  VSCode 1.89.1 (macOS 14.5). Auto-save is not working on cmd+S keyboard shortcut (it is saving though), but it does work if I click to File -> Save.

It is explicitly disabled for auto-save because it may change the character under your cursor.
//cc @jrieken

good point actually...
could it be that the auto-save should wait kind of on idle status from user stopping writing code? (implemented with a  kind of timeout to detect it and trigger the save)
so while a user is writing is not auto saving each single char, but wait to save after the user has finishing writing..
But actually digging that functionality a little deeper there are already various modes, anyway. i understand it is not really possible  in the case of an "instant auto-save" feature.

Formatting is a sometimes a slow operation, I would not want it happening every second even if I want to autosave every second.  Maybe what is needed is a separate editor.formatOnAutoSaveIdleDelay or similar which can either be null or set to some positive value to indicate how long the user needs to have been idle for in order to format

Formatting is a sometimes a slow operation, I would not want it happening every second even if I want to autosave every second. Maybe what is needed is a separate editor.formatOnAutoSaveIdleDelay or similar which can either be null or set to some positive value to indicate how long the user needs to have been idle for in order to format

this should be already available:
"files.autoSave": "afterDelay"
"files.autoSaveDelay": 1000

ref: https://code.visualstudio.com/docs/getstarted/settings

Perhaps, it could be interesting to have the autoformatting trigger based on different events rather than just save, e.g.:

post-build autoformat
pre-lunch autoformat

something like this, to delegate to other events and not only on the save one.
basically some different modes of "autoformats"

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Adam/config validation

Resolves
https://jira.rax.io/browse/CERES-394
What
It is attempting to make sure that when the server is configured with timeslot widths for downsampling that they widths dont conflict with each other.
Each timeslot width should be a multiple of the largest granularity and should also be a multiple of its neighbors.
widths of 3m, 7m, 21m -> should fail because 7m is not a multiple of 3m.
widths of 7m, 21m, 42m -> should succeed because everything is a multiple of each other.
How
It adds the GranularityValidator at the class level of the DownsampleProperties to validate the Granularity property
How to test
Unit tests were not added because it was not easy to get access to the validator outside of the normal spring boot means. Starting up the tests runs the validator before you can enter a @Test and leaves no way of asserting anything.
Alter the application.yml with testing widths from above.
Why
Annotation based validators are a common way to validate spring boot properties files.

You need to write a lot of tests for this validator. Not quite sure why writing junit tests for this class is not possible?

The problem is mostly that I can't figure out how to get the validator context to run it against the config class. I guess I don't need to do that. I can just pass the config class into the isValid function and since I am not using the ConstraintValidatorContext that can easily be null.


Audit client side performance

Certain transactions like adding vehicle location histories have surprisingly high client side latencies (hundreds of ms vs single digit ms on the server side). Figure out what's going on and get those down to more reasonable levels.

This was due to the high number of threads.


Local Storage!

The current paddles should save+load to+from local storage!
I should probably hold off on this until I make split cells and OR operators, because they would make this in need of a rewrite.

Closing this because I have other plans instead with #185


Add sorted maxApr secondary index

This pr adds sorted maxApr secondary index, that will be used, e.g, in sorting pool table on Balancer app main page

@timjrobinson I removed absMaxApr calculation, as it used only on portfolio page


Hello! I would like to ask you if this library can achieve screen recording and push stream, not through the camera through the screen recording to push the device picture and sound to the server.

Hello! I would like to ask you if this library can achieve screen recording and push stream, not through the camera through the screen recording to push the device picture and sound to the server.

Hello,
Yes, this is possible. You have an example code here:
https://github.com/pedroSG94/RootEncoder/tree/master/app/src/main/java/com/pedro/streamer/screen
You can compile the app example and test it

Hello! What is the maximum resolution you support?!

I support all resolutions. The max resolution depend of your device. You have 2 limitations:

Resolution supported by your source (camera, screen, etc):
In this case the resolution is your device screen resolution. The library allow you scale it as you want but remember that, increase the resolution above of the original resolution, produce a pixelation.
Resolution supported by your encoder:
Your device has video encoders that are used to stream. Depend of that encoders you can use a better resolution.

I don't understand your image but you can use AudioInternalSource or MicrophoneSource depend of your needs

I see that your project uses MicrophoneSource(). How to write if you use AudioInternalSource, or I want to use both.

I see that your project uses MicrophoneSource(). How to write if you use AudioInternalSource, or I want to use both.
 genericStream =             GenericStream(baseContext, this, NoVideoSource(), MicrophoneSource()).apply {                 //This is important to keep a constant fps because media projection only produce fps if the screen change                 getGlInterface().setForceRender(true, 15)             }

Hello,
If you use AudioInternalSource you can follow Screen example and add AudioInternalSource here:
https://github.com/pedroSG94/RootEncoder/blob/master/app/src/main/java/com/pedro/streamer/screen/ScreenService.kt#L141
exactly the same that ScreenSource you can create an InternalAudioSource and set to stream using changeAudioSource

Sorry, I don't know how to write. Can you add an audio selection feature? Add a source selection to the screen recording, similar to the image I gave you above. Can you help me?! Thank you!

Hello! Can you implement this feature? I really need this feature because when I'm recording a video that's playing on my device and I push it to the server there's no video sound. There is also a problem, I am playing video in the player and when I record and push to the server, no video screen is black. What is the cause of this.

Hello,
You have a code example about how to change the AudioSource in the link referred above. Also, you can check this code if you want more examples:
https://github.com/pedroSG94/RootEncoder/blob/master/app/src/main/java/com/pedro/streamer/rotation/RotationActivity.kt#L92
This case change the audioSource to a MicrophoneSource, if you want change to InternalAudioSource the code is exactly the same.

Thank you very much! With your patient reply, I have now implemented the switch between MicrophoneSource and InternalAudioSource. But I can't have both MicrophoneSoure and InternalAudioSource on at the same time and I have to choose one or the other how do I get them both on?

Hello,
Currently, only one video or audio source is supported.
You can try create a new custom AudioSource where you mix both but I'm not sure how to implement it.

I will add this as a future feature but I can't give you a date for it

Thank you very much! But I'm surprised that the microphone can't pick up the sound inside the speaker when I put it out there and it can't pick up the sound when it's pushed to the server, but it can pick up the human voice even if it's very low. I'm looking forward to your realization.

Hello! I encountered an issue using your library in my project. I encountered an issue while starting the encoder:

Below is my error log. May I ask what caused this and how can I fix it. If you use the same device environment, your project will not fail to start.
===========================================================LOG======================
2024-10-10 15:53:22.173 13814-13814/cn.com.iqtouchlive E/AndroidRuntime: FATAL EXCEPTION: main
Process: cn.com.iqtouchlive, PID: 13814
android.media.MediaCodec$CodecException: start failed
at android.media.MediaCodec.native_start(Native Method)
at android.media.MediaCodec.start(MediaCodec.java:2284)
at com.pedro.encoder.BaseEncoder.initCodec(BaseEncoder.java:97)
at com.pedro.encoder.BaseEncoder.start(BaseEncoder.java:83)
at com.pedro.library.base.StreamBase.startSources(StreamBase.kt:379)
at com.pedro.library.base.StreamBase.startStream(StreamBase.kt:152)
at cn.com.iqtouchlive.service.IQLiveScreenService.startStream(IQLiveScreenService.java:513)
at cn.com.iqtouchlive.service.IQLiveScreenService.showConnmect(IQLiveScreenService.java:493)
at cn.com.iqtouchlive.service.IQLiveScreenService.changeButtonText(IQLiveScreenService.java:438)
at cn.com.iqtouchlive.service.IQLiveScreenService.onClick(IQLiveScreenService.java:343)
at android.view.View.performClick(View.java:7447)
at android.view.View.performClickInternal(View.java:7424)
at android.view.View.access$3700(View.java:841)
at android.view.View$PerformClick.run(View.java:28728)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:7869)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1068)

Do you have this error using the app example?
If not, I will need see your code implementation and the library version to know the error.

Can you write a Java version of ScreenService? I feel like there might have been some issues when I switched from Kotlin to Java. I can implement streaming by copying your ScreenService into my project. So I can't understand Kotlin code. So I don't know where the problem lies?

Hello,
I can write the Java version of that class in a branch but I can't reproduce the error like this because the code shared is uncompleted.
Meanwhile, test in the app example using the kotlin example with your configuration to discard problem in the video/audio configuration used.

thank you! I have already converted my Java to Kotlin and there is no longer this issue. But I still don't understand why I can't convert to Java. I can't find the reason either.

Ok, I think that I detected the problem. Remember that in java this:
genericStream.prepareVideo(width, height, vBitrate, rotation);

Is not equivalent to this:
genericStream.prepareVideo(width, height, vBitrate, rotation = rotation)

The reason is that prepareVideo is configured like this:
prepareVideo(width: Int, height: Int, bitrate: Int, fps: Int = 30, iFrameInterval: Int = 2,
    rotation: Int = 0, profile: Int = -1, level: Int = -1): Boolean

So that code in java is traduced to this in kotlin:
genericStream.prepareVideo(width, height, vBitrate, fps = rotation)

To fix it try this:
genericStream.prepareVideo(width, height, vBitrate, 30, 2, rotation);

If it is not working I will continue with the code migration to Java. Also, I will add fews check in the code to avoid this problems in the future.

Wow! So that's the reason. I tried using the code you provided and found that the code in Java can also run correctly! Thank you for your guidance.


[PLAT-12346] Remove inlined frame from the Bugsnag notify call chain entirely so t…

Goal
Remove the call to functions that are getting inlined so that we don't have to worry about the size of the bugsnag portion of the stack (which will change if the call gets inlined).
Note: Do not merge this yet. We will also be trying a different approach.

Superseded by https://github.com/bugsnag/bugsnag-cocoa/pull/1668


Cannot paste a tab character at start of TS file

create a TS file

interface X {
}

make sure the file is configured to insert Tabs (from the status bar)
place a \t character in your clipboard
paste it at the beginning of the file
:bug: observe nothing happens

Version: 1.90.0-insider
Commit: 405ce83a24f38fd70751b03438763a1503329fe0
Date: 2024-05-20T23:10:59.594Z
Electron: 29.3.1
ElectronBuildId: 9464424
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 23.5.0

This seems related to Auto indent. Setting "editor.autoIndent": "none" fixes the issue

After investigating, this seems to happen because after pasting a new line character, the code becomes as follows:
    interface X {
}

The trigger method of the AutoIndentOnPaste is called and it performs automatic re-indentation. In your case, since there is nothing above that line, the indentation level on that line is zero. The inserted indentation is then removed.
It is possible to see this in more detail in the following example:
https://github.com/microsoft/vscode/assets/61460952/b1a87d44-e8b9-470e-a091-5fe236fbd577
I believe this behavior makes sense when the pasted text contains characters other than whitespace characters. Perhaps what I could do is to not trigger the re-indentation when only whitespace characters are pasted. This could be considered then as intended indentation adjustment.


Applied fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Just checked over all of this and it seems good to me... lots of namespace reformatting, padding of !s in conditionals, and array() → [] switcharoos.

:+1:


Rust symbol demangling

Is your feature request related to a problem? Please describe.
bpftrace currently doesn't support demangling Rust symbols, so when listing uprobes on Rust programs you get the mangled symbol name. This is a suboptimal user experience.
Unfortunately, Rust's name mangling scheme is different from C++, so the :cpp prefix doesn't work on Rust binaries.
For example:
❯ bpftrace --version
bpftrace v0.20.4
adam @ adams-nixos-desktop 🌐in nixos-configuration on  main
❯ sudo bpftrace -l 'u:/nix/store/71jzy8l7bqkw64fn4gnldrr248vqi2ly-ripgrep-14.1.0/bin/rg:cpp:*' | head -n 1
uprobe:/nix/store/71jzy8l7bqkw64fn4gnldrr248vqi2ly-ripgrep-14.1.0/bin/rg:cpp:"_$LT$aho_corasick..packed..teddy..builder..x86_64..SlimAVX2$LT$_$GT$$u20$as$u20$core..fmt..Debug$GT$::fmt::h5c8301c85bfe80c1"

Describe the solution you'd like
Introduce a :rust prefix to the bpftrace probe syntax that allows users to request automatic symbol demangling for Rust symbols in the same way that they request automatic symbol demangling.
LLVM has a rust demangler that we should be able to use: https://github.com/llvm/llvm-project/blob/main/llvm/lib/Demangle/RustDemangle.cpp.
I'm happy to do the work, but since this would be my first contribution I wanted to discuss the idea before implementing it.
Describe alternative solutions or features you've considered
Use the mangled symbol names – not a great user experience.

not quite sure, but i think we can provide a general demangle prefix for both (Demangle.cpp)

as far as I know, LLVM has supported rust demangling since release/13.x. therefore, we can rely on LLVM to automatically use the appropriate rust demangler (or another one if necessary) when we apply the demangle prefix.

Oh good call - I'll give that a shot.

to fix your trouble check this solution click
maybe this will solve your problem.


cbsnews parse/download is not working

Using version 2015-11-23, trying to capture video of niece on TV.
$ youtube-dl http://www.cbsnews.com/videos/why-do-we-like-the-foods-we-like
[debug] System config: [u'--prefer-free-formats']
[debug] User config: []
[debug] Command-line args: [u'http://www.cbsnews.com/videos/why-do-we-like-the-foods-we-like', u'--verbose']
[debug] Encodings: locale UTF-8, fs UTF-8, out None, pref UTF-8
[debug] youtube-dl version 2015.11.23
[debug] Python version 2.7.5 - Linux-3.19.8-100.fc20.x86_64-x86_64-with-fedora-20-Heisenbug
[debug] exe versions: ffmpeg 2.1.8, ffprobe 2.1.8
[debug] Proxy map: {}
[CBSNews] why-do-we-like-the-foods-we-like: Downloading webpage
[debug] Invoking downloader on u'{manifest:none}rtmp://cp98363.edgefcs.net/ondemand/?auth=cbs&aifp=v001&slist={slistPrefix}{break}{slistFilePath}media/2015/11/22/572131907744/sunmo_taste_1122_469594_796.mp4{slistFilePath}{manifest:f4m}http://cbsnews-vh.akamaihd.net/z/{slist::true:false}.csmil/manifest.f4m{manifest:m3u}http://cbsnews-vh.akamaihd.net/i/{slist::true:false}.csmil/master.m3u8{manifest}'
ERROR: unable to download video data: <urlopen error unknown url type: {manifest>
Traceback (most recent call last):
  File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1601, in process_info
    success = dl(filename, info_dict)
  File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1543, in dl
    return fd.download(name, info)
  File "/usr/bin/youtube-dl/youtube_dl/downloader/common.py", line 342, in download
    return self.real_download(filename, info_dict)
  File "/usr/bin/youtube-dl/youtube_dl/downloader/http.py", line 58, in real_download
    data = self.ydl.urlopen(request)
  File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1878, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib64/python2.7/urllib2.py", line 404, in open
    response = self._open(req, data)
  File "/usr/lib64/python2.7/urllib2.py", line 427, in _open
    'unknown_open', req)
  File "/usr/lib64/python2.7/urllib2.py", line 382, in _call_chain
    result = func(*args)
  File "/usr/lib64/python2.7/urllib2.py", line 1249, in unknown_open
    raise URLError('unknown url type: %s' % type)
URLError: <urlopen error unknown url type: {manifest>

Thanks

Try^

This is working for me:
youtube-dl -f RtmpMobileHigh http://www.cbsnews.com/videos/why-do-we-like-the-foods-we-like

this will be fixed in the next version.

Dr Miracle is a real spell caster, he is so powerful, unique, and amazing. Dr Miracle restored happiness to my life again by bringing my husband back to me with his powers. Dr Miracle is a gifted and a very powerful good man and if not for him what would my life turn to? Dr Miracle may your good gods continue to bless you for your good deeds. Dr Miracle words can not express how much good you have done for me and i believe that even a thousand words won't be enough to describe your good great works. If you are facing any spiritual problem i advice you not to cry just contact Dr Miracle on his email or and his web site and he will solve all your problems. Contact him on his email:
<EMAIL_ADDRESS>and this is his website: http://homeoflightandsolution.webs.com/  contact him and get your solution now. Thank you Dr Miracle for you are indeed miraculous.

Dr Miracle is a real spell caster, he is so powerful, unique, and amazing. Dr Miracle restored happiness to my life again by bringing my husband back to me with his powers. Dr Miracle is a gifted and a very powerful good man and if not for him what would my life turn to? Dr Miracle may your good gods continue to bless you for your good deeds. Dr Miracle words can not express how much good you have done for me and i believe that even a thousand words won't be enough to describe your good great works. If you are facing any spiritual problem i advice you not to cry just contact Dr Miracle on his email or and his web site and he will solve all your problems. Contact him on his email:
<EMAIL_ADDRESS>and this is his website: http://homeoflightandsolution.webs.com/  contact him and get your solution now. Thank you Dr Miracle for you are indeed miraculous.


torch backpropagate problem

Hey, I'm trying to use torch to reimplement your work. But occurring the backpropagate problem.
RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation: [torch.cuda.FloatTensor [256]] is at version 5; expected version 4 instead. Hint: enable anomaly detection to find the operation that failed to compute its gradient, with torch.autograd.set_detect_anomaly(True).
the code is as follows:
logits = self.model(adv_data)
new_logits = self.model(self.encoder(adv_data)))
adv_loss = 0.75*self.adv_func(logits, target).mean() + 0.25*self.adv_func(new_logits, target).mean()

Do you think the code is right?

@cuge1995 could you please direct me to the repo of the PyTorch implementation. I can help with that.


fix: ignore NotFoundError in the first call of LazyDiscoverer. __search

What type of PR is this?
/kind bug
What this PR does / why we need it:
According to fabianvf's suggestion, I try to catch the exception in the first call and safely ignore it
https://github.com/kubernetes-client/python/issues/1536#issuecomment-920265516
Which issue(s) this PR fixes:
Fixes https://github.com/kubernetes-client/python/issues/1536
Does this PR introduce a user-facing change?
Ignore NotFoundError in the first call of LazyDiscoverer. __search

CLA signature registered

/assign @fabianvf

/approve

Hello @yliaog , does this PR still need to be modified? It seems that the lgtm tag is required for robot auto-merge.


Bump dependencies

The dependencies currently are pretty outdated.
Is there a chance to bump the dependencies versions?

If you can submit a pull request with the changes I'll get it updated.


Upgrading from @floating-ui/react-dom 1.0.0 to 1.1.1 breaks positioning

Followup from comments here: https://github.com/floating-ui/floating-ui/issues/2091
I'm using a library which depends on @floating-ui/react-dom ^1.0.0. When I upgraded packages, it installed 1.1.1 which broke the positioning of the popup as shown in the screenshots below.
I'm unable to share the specific library that depends on floating-ui since it's internal. The authors will update their usage to work with 1.1.x, but others may run into this problem so I'll post it here anyway.
1.1.x version:

1.0.x version after package.json overrides:

If anyone else runs into this, I was able to fix it for now with overrides in package.json:
"overrides": {
    "dependency-that-uses-floating-ui-1.x": {
      "@floating-ui/react-dom": "1.0.0"
    }
  },

@atomiks asked here to check if the issue happens in 1.1.0 or 1.1.1 or both of @floating-ui/react-dom.
I looked at my package-lock.json in the commit where it originally broke, and it contained this combination of dependencies:
Affected library had<EMAIL_ADDRESS>which had<EMAIL_ADDRESS>which had<EMAIL_ADDRESS>The library author told me installing<EMAIL_ADDRESS>fixed the problem, so maybe you've already fixed this in one of the sub-dependencies.

Based on your overrides, the latest core and dom packages (v1.1.0) are not the problem, only react-dom v1.1.1, right?
It's hard to understand what the problem is without an actual reproduction, but if you try testing each of<EMAIL_ADDRESS>and<EMAIL_ADDRESS>in your overrides key (and re-installing) to see if which one is the issue, that would help

Affected library had<EMAIL_ADDRESS>which had<EMAIL_ADDRESS>which had<EMAIL_ADDRESS>

The library author told me installing<EMAIL_ADDRESS>fixed the problem, so maybe you've already fixed this in one of the sub-dependencies.

I don't see how it would be fixed suddenly though, given core and dom are unchanged

Unfortunately it's not :\
The dual sync technique works fine in v1.1.1: https://codesandbox.io/s/floating-ui-react-dom-template-forked-ccujnq?file=/src/App.js, including when updating either of the nodes as seen in the demo, and resizing the window to indicate autoUpdate is active.

Ok, I think we can just close this. If anyone else runs into the problem hopefully they'll find this thread useful. Thanks!


When using a divider inside a grid which has a stackable parent, that grid inherits the stackable behavior.

#3266


Owner variable is null on tree_exiting signal

Godot version:
3.0.6 and 3.1 alpha1
OS/device including version:
Arch Linux
Issue description:
Let's assume that there is a very simple instanced scene:
Owner
│
└── Node

Node node has script attached, that connects to the Owner tree_exiting signal. When this signal is emitted, I would like to access the Owner node by using owner variable (or get_owner method). Unfortunately, when this signal is emitted, this variable is already set to null, even though Owner node is still the owner of the Node (I can access Owner node by using get_parent).
Of course I could pass the owner in binds array in connect method, use get_parent method, store reference to the owner in a different variable, or create my own signal and method for deletion of the Owner. I'm just not sure if this is expected behavior, because tree_exiting signal is emitted before the node and its children are removed, so owner should still be accessible.
Steps to reproduce:

Create a node
Add a child to that node
Connect the child to the owner's tree_exiting signal
Try to access owner variable in a method that is called on the emission of the signal in point 3

Minimal reproduction project:
Project created in version 3.1 alpha1
When playing the project, press Delete key on keyboard to delete the Owner.
Look at the Output in the Editor window. Notice the Owner: [Object:null] (owner variable) and Parent: [Spatial:XXXX] (get_parent method).
All the code is in the Child.gd file.

The issue is at https://github.com/godotengine/godot/blob/b17e71b6e5e035f49b5b3b5b55b9cdac80215d72/scene/main/node.cpp#L145
where the owner is set to NULL before tree_exiting is ever emitted, not sure what the right fix here is.

I'd expect that behaviour of tree_exited, where the node has left the scene tree, but exiting is before/during, so should ownership still be a valid thing?

The signal might be renamed indeed.


Getting things working with Arch Linux

Notwithstanding #4, can anyone point me towards the steps required to get things working with Arch Linux (fresh install)?
There is this guide but it appears outdated.
Indeed following those steps in combination with using vmware-tools-patches I encounter these issues:

Some of the patches fail but this doesn't appear critical because everything builds fine - namely linux/driver.c, all hunks fail, vmhgfs/inode.c, all hunks fail, shared/compat_mm.h, all hunks fail, mhgfs-d_count-kernel-3.11-tools-9.6.0, 2 hunks fail
Then I get two sh: command not found errors before the first compilation step
I get a message telling me it's using the 2.6.x Kernel build system?
Messages that vmxnet3, pcscsi and vmmemctl are not supported for Kernels > 3.10... that I need to enable those modules in my kernel and might need to enable HYPERVISOR_GUEST
Complaints that I don't have the relevant fuse packages installed (although fuse is installed)

The final error messages are:

VM communication interface socket family fails to start
Guest filesystem driver fails to start
Mounting HGFS shares fails

Can anyone point me in the right direct with any of these before I start digging too far?
Thanks

Failure on Archlinux.
After calling ./compile.sh
Just before running vmhgfs filesystem shares, VMWare CPU stops

On my fork I've got a working script that works with Arch Linux. I'd like to clean it up before I pull request it in, but folks can give it a try to see if it also works for them.
https://github.com/dragon788/vmware-tools-patches


Apple: add mach_task_self back

This was removed in 56d665c9b3f ("macOs various updates") because tests failed, but apparently this still exists. Try adding it back.
Sources

https://web.mit.edu/darwin/src/modules/xnu/osfmk/man/mach_task_self.html

Oh, I think these were in https://github.com/rust-lang/libc/pull/3578 because they are part of the mach2 crate. So I think I should close this and instead mark them deprecated on libc-0.2.
@devnexen does that sound right?

yes


Review requirements for listing on Let's Encrypt site

Added to https://letsencrypt.org/docs/client-options/#clients-kubernetes


As VALIDATOR, I want to cross-check my study data against my study for values in VLM not found in user-defined codelist so that I can stay compliant with SD1228

This check applies to SEND, SDTM, and ADaM data.
This check is IG-version-agnostic.
User-defined codelist means no CodeList/Alias[@Name]. For Define-XML v2.1, def:IsNonStandard="Yes".
For variables in a study dataset that use a user-defined codelist, all the distinct values need to appear in the study define.xml.
This check is similar to SD0037, but specific to values in value-level metadata.

SD1228 in FDA VR v1.6:

Rule message: Variable value not found in user-defined codelist when value-level condition occurs
Rule description: Variable value must be populated with terms from user-defined value level codelist as specified in define.xml file.

The validation for this issue is completed. The implementation and code changes are good enough to complete the acceptance criteria. The testing also passed for the issue as it successfully found the negative cases. See attached screenshot for reference.

Validation Summary
Validation Methodology:
The validation process incorporated rigorous testing methodologies to ensure the accuracy and reliability of the system. This included:
Unit Testing:
Unit Testing was done to verify the implementation of the Acceptance criteria. Unit tests were designed to test the made changes using edge cases. All those tests were then run using pytest to verify compliance with acceptance criteria.
Test Endpoint:
A rule was written using the logic provided in the PR related to this issue and then tested against dataset files having both positive and negative cases regarding the implementation.
Code Review:
The code changes in the code files were reviewed and were found to be in accordance with the Acceptance criteria. Also, the code was reviewed for following:

Code Quality Evaluation
Logic and Functionality Review
Error Handling and Exception Handling Assessment
Security Considerations

Regression Testing:
Regression tests were run to validate that the changes did not affect any functionality of the overall system.
Test Execution:

The tests were executed in the following order:
Code Review: The code for all the changes files was reviewed first to check the proper implementation of the Acceptance criteria.
Unit Tests: The unit tests were run using the following command in the terminal from the root of the project
python -m pytests path/to/the/test/files
Test Endpoint: Rule logic similar to mentioned in PR was written to test the implementation using the endpoint
Dataset having two negative test cases was used against this issue. The negative case was successfully identified by the endpoint. This showed that the endpoint is able to successfully identify and separate negative cases from all other cases.
Regression Test: In the end regression tests were executed

Results:
After successful running of unit, Test endpoint rule, regression tests and careful validation, the issue was found to be good to close as the Acceptance criteria was fulfilled and all validations passed.
Deviations and Non-conformances:
No deviations or non-conformances were observed.
Summary of Findings:
Test Results: All tests conducted during the validation process passed successfully, indicating that the system functions as intended and meets the specified requirements. The tests covered various scenarios and edge cases, providing confidence in the system's reliability and correctness.
Unit Regression: The unit regression tests were executed, and no regressions or issues were identified. This indicates that the changes made during the development or modification of the system did not introduce any unintended side effects or break existing functionality.
Code Reviews: The code reviews conducted by both development and QA teams were completed, and no major issues or concerns were identified. The code adheres to coding standards and best practices, demonstrating good code quality, readability, and maintainability.


[Refactor] Rename rayiov1alpha1 and rayv1alpha1 to v1alpha1

Search before asking

[X] I searched the issues and found no similar issues.

KubeRay Component
ray-operator
What happened + What you expected to happen
1. "kuberay/ray-operator/apis/ray/v1alpha1"
In the KubeRay codebase, there are three aliases for v1alpha1: rayiov1alpha1, rayv1alpha1, and v1alpha1. Let's ensure consistency across all of them.

Case 1: https://github.com/ray-project/kuberay/blob/b0649c43bbae3a0ac4917f94d80cbde466bb4f88/ray-operator/controllers/ray/utils/util.go#L21

Case 2: https://github.com/ray-project/kuberay/blob/b0649c43bbae3a0ac4917f94d80cbde466bb4f88/ray-operator/controllers/ray/utils/dashboard_httpclient.go#L21

Case 3: https://github.com/ray-project/kuberay/blob/b0649c43bbae3a0ac4917f94d80cbde466bb4f88/ray-operator/controllers/ray/common/rbac.go#L4

Use Case 3 to replace Case 1 and Case 2.
Reproduction script
No
Anything else
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

One of the difficult here is also because we have multiple go packages named v1alpha1
Example:
github.com/ray-project/kuberay/ray-operator/apis/ray/v1alpha1
github.com/ray-project/kuberay/ray-operator/pkg/client/listers/ray/v1alpha1
So when importing both in same go file, we have to distinguish between them. Example:
https://github.com/ray-project/kuberay/blob/b0649c43bbae3a0ac4917f94d80cbde466bb4f88/ray-operator/pkg/client/informers/externalversions/ray/v1alpha1/rayservice.go#L9
So one option is when referring to ray-operator/apis/ray/v1alpha1 call it v1alpha1Operator and when referring to pkg/client/listers/ray/v1alpha1 call it v1alpha1Client.

@gvspraveen Good catch. I will update the issue description.

@gvspraveen I found that github.com/ray-project/kuberay/ray-operator/pkg/client/listers/ray/v1alpha1 only happens in the generated client code. It does not be imported into the operator codebase.

Generated code:
https://github.com/ray-project/kuberay/blob/b0649c43bbae3a0ac4917f94d80cbde466bb4f88/ray-operator/pkg/client/informers/externalversions/ray/v1alpha1/raycluster.go#L12

Just wanted to check in -- is someone already working on this issue?

Hi @anishasthana, thank you for reaching out! Currently, there is no one assigned to this issue. If you are interested, I can assign this issue to you.

I'd be happy to pick this one up! I've been looking for good issues to get started with anyways :-)

Great! You can also take a look at https://github.com/ray-project/kuberay/issues/1059 and join our Slack channel to stay connected with the community.


Minor typos

Signed-off-by: Chad Kittel<EMAIL_ADDRESS>

Since it's just typos, doing a self merge.


Data Provenance Information

At present, data provenance is just a simple text field. For true data provenance, we'd need information on

source data: link to MD record
processing routines: link to MD record
comment: text

Please also discuss this with the UC partners!

The STAC Extension for PROV-O  created by OGC is exactly what we need.


Tooling

@philipjbennett sorry for the ping.  I was looking at adding AMD 29000 to Ghidra.  Are you aware of any prebuilt compilers that are available for download.  Figured I'd ask before trying to compile an old gcc.

No worries! I don’t know of any prebuilt compilers; it’s been quite a while since I’ve done anything 29K related.


single column overview buttons misplaced

Have to make overview single column to see the bug.

this was due to a customization we aren't maintaining moving forward.


Add component runtime selector

Fixes
https://issues.redhat.com/browse/HAC-1605

Description
Add a runtime selector to components review section. That uses the devfile sample API to fetch list of runtimes.

Allows selecting a runtime when CDQ detection fails to detect one automatically.
Allows optionally selecting a different runtime if the automatic detection is not satisfactory.

Type of change

[x] Feature
[ ] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review

Scenario 1: Automatic detection failed
https://user-images.githubusercontent.com/20013884/193818663-80711778-5f4f-4976-b501-246ace162fde.mp4
Scenario 2: Detection succeeded
https://user-images.githubusercontent.com/20013884/193818709-db4e0e5d-550a-491d-af70-c37f474bea32.mp4

How to test or reproduce?
Use a non-detectable repo, or try to change the runtime after detection has happened.

Browser conformance:

[ ] Chrome
[x] Firefox
[ ] Safari
[ ] Edge

cc @openshift/team-hacdev-ux

@rottencandy In the second video 'Scenario 2: Detection succeeded' I guess I was expecting the dropdown to be pre-populated with the detected runtime. Is that not what's happening here? Does that ever happen?

@rottencandy In the first video 'Scenario 1: Automatic detection failed' would it be possible to put the error text "Runtime not detected" in the red error message area and not within the form field. And put the "Select a runtime" that is now in red within the field? So swap them?

@rottencandy In the second video 'Scenario 2: Detection succeeded' I guess I was expecting the dropdown to be pre-populated with the detected runtime. Is that not what's happening here? Does that ever happen?

Fixed. The pre population might not always happen since we're currently fetching runtimes from the devfile samples API, and it doesn't provide all the available runtimes. But I think it should work fine when we switch to the devfile stacks API in the future.

@rottencandy In the first video 'Scenario 1: Automatic detection failed' would it be possible to put the error text "Runtime not detected" in the red error message area and not within the form field. And put the "Select a runtime" that is now in red within the field? So swap them?

Updated.

/cc @rohitkrai03

@rottencandy The PR checks are failing. Seems like an e2e test failure. Can you take a look?

Fixed. Dropdown will now show Other when projectType does not match any of the samples.
https://user-images.githubusercontent.com/20013884/194560703-0e969b6c-ab81-4ea3-8fc5-a3e391b61cb8.mp4

/retest

Updating any one of the runtime selectors in a multi component detection it changes the selection for all and shows error message.

Fixed.


chore: change taobao registry url

https://github.com/cnpm/cnpm/issues/361?spm=defwork.home.0.0.72ce3f1bz8qwmn

Codecov Report

Merging #973 (ab25168) into master (168b4ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #973   +/-   ##
=======================================
  Coverage   48.93%   48.93%
=======================================
  Files          46       46
  Lines        1175     1175
  Branches      284      284
=======================================
  Hits          575      575
  Misses        600      600


Twitter Embeds Return 404 from CDN

Embedding tweets fail with a 404 from twitters CDN for valid tweets. Looks like https://cdn.syndication.twimg.com/ doesn't exist.
It has previously been using a deprecated API.

Twitter 🔥 in all directions 😱
Time I guess to switch to an authenticated approach. We’ll probably need to require folks add an integration to astro.config so they’re not forced to pass API keys each time they use a component.
Would look something like:

A user configures their Twitter API access token in astro.config:
export default defineConfig({
  integrations: [
    // if using @astro-community/astro-embed-twitter
    Twitter({ token: process.env.PRIVATE_TWITTER_ACCESS_TOKEN }),
    // if using the astro-embed umbrella package
    AstroEmbed({
      twitter: { token: process.env.PRIVATE_TWITTER_ACCESS_TOKEN },
    }),
  ],
});

The integration sets up a Vite plugin creating a virtual module, e.g. as virtual:astro-embed-twitter.

The Twitter component imports the access token from that virtual module and uses it with the Twitter API client.
import { accessToken } from 'virtual:astro-embed-twitter';

Facing similar issue -
Failed to fetch https://cdn.syndication.twimg.com/tweet?id=XXXXXX
Error 404: Not Found


[UStore instance pricing feature] Add a license field into CRD

Adding a license field to be checked vs. the dbType and determine if creating this UStore is allowed.
This can either be done with a Validating Webhook, or as part of the controller code.

cc: @ashvardanian @DarvinHarutyunyan


Implemented Google Tag Manager aka GTM trackers.

@hhamon is this ready?

Normally yes!

Just rebased the PR onto master.

@tgalopin any status on this one?

@tgalopin shall we close this PR?

@hhamon @tgalopin hi! what happened with this one? We're closing it but it hasn't been merged, right? Or is there another PR that was closed?

@atamano should we close this one?


Login/Signup page for user

Login and signup page to enroll themselves and to get details
1.Name
2.Address,(State and District)
3.Adhar card number or any valid document (To verify whether User is original user and to ensure the complaint is genuine)
4.Phone Number
5.Issue
6.Date of the issue
This will make the process simple like He/she Need not to enter the details everytime when they have the issue and want to report it When they have account they just need to enter the issue (Problem).
To create Login/signup page we  need to  implement it by front-end(html,css) and backend (php,mysql)

I would like to implement the frontend of login/signup page. Do you have any designs in mind? Can you please assign it to me after adding lavels of gssoc'21 and labels to it.
Thank you

Would you like to assign me for this project?
Front-end login and signup page.
Even I have already had designed page just waiting for your permission :)

@siddharth-143 Can u suggest me a better design first or some demo

@khannakshat7 Please assign this issue to me.

@inbasagar Please assign this issue to me.


No message in the data file

If there is no message in a data file, it will return nothing.

#24 is more accurate.


direnv: shell.nix doesn't exist

Hey, just wanted to checkout out this after reading https://discourse.nixos.org/t/hydra-check-does-package-x-still-build-on-channel-y/6126/1 and noticed that direnv allow fails with:
direnv: loading /var/src/hydra-check/.envrc
direnv: cannot watch file shell.nix because it does not exist
direnv: error exit status 1

good catch, i seem to have forgotten it. you can however still run nix-shell and it will catch up the existing default.nix

should be fixed with 9680e78e9abd135f5b0f668e919aceaa339d1e0a


Feature/small impovement

Coverage remained the same at 62.33% when pulling b4266dffec0f994dcff12f34c1540be92661cb04 on grey-mise:feature/small-impovement into fc61756f1322da244508b373df5a93807c924b6b on nixsolutions:develop.


Initial refactor of E2E tests

What this PR does / why we need it:

Moved common provisioning logic and provisioners for all providers to a package called provisioner
Moved helper functions to a package called testutil
Removed KubeOneCluster manifest from the testdata directory in favor of manifests generated at the runtime
Stop running conformance tests after cluster upgrade
Update comments and log messages to include more details

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #372
Special notes for your reviewer:
Documentation:

Release note:

NONE

/hold

I agree, especially on the provisioner part. The only provider that's going to have different apply steps is GCE, but all others are absolutely the same. I'll look into the builder pattern and then see how can I improve this.

/test all
Running all tests again to ensure new E2E tests are working. E2E tests for other PRs are currently broken until we don't merge this PR.

/test all

/test all

/test pull-kubeone-e2e-aws-conformance-1.14.1

/test all

/hold cancel


Missing Text in Table 1 "WDAC events found in the Microsoft Windows CodeIntegrity Operational log"

The  Explanation for event ID 3099 in Table 1 in section "WDAC events found in the Microsoft Windows CodeIntegrity Operational log" appears to be truncated.  As the text currently reads
"Indicates that a policy has been loaded. This event also includes information about the policy options that were specified by the policy. Refer to the"
with no further explanation after the "the".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5da550e8-6065-7666-46b1-7bfb84ad775e
Version Independent ID: ffbb3f81-73d3-c5e9-ca5a-abbb36320661
Content: Understanding Application Control event IDs (Windows) - Windows security
Content Source: windows/security/threat-protection/windows-defender-application-control/event-id-explanations.md
Product: m365-security
Technology: windows-sec
GitHub Login: @jsuther1974
Microsoft Alias: dansimp

Closing the issue. It was addressed in PR 6507.


Blend modes do not work with filters

https://pixijs.io/examples/#/demos-basic/blendmodes.js
Add this line to the above demo.
dude.filters = [new PIXI.filters.AlphaFilter()];
Then PIXI.BLEND_MODES.ADD will not apply.
PIXI: v5.0.4

It seems not a bug. sorry

And @ivanpopelyshev sighs with relief ;)