chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
0b1411f -> 5b96dd7

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
minor
v1.37.1 -> v1.38.0

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.38.0
Compare Source
Features

add function to check ingress health status of a cluster (#751) - Added new function testhelper.CheckClusterIngressHealthy() which can be used in Terraform tests to validate the status of an OpenShift cluster (801dd27)

v1.37.2
Compare Source
Bug Fixes

deps: update gomod (#855) (131e322)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

ℹ Artifact update notice
File name: tests/go.mod
In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

2 additional dependencies were updated

Details:

Package
Change

github.com/IBM/platform-services-go-sdk
v0.66.0 -> v0.67.0

github.com/IBM/vpc-go-sdk
v0.51.0 -> v0.57.0

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

GitHub release
v2.0.0

Your semantic-release bot :package::rocket:


ChaNGa out of tree build broken

Original issue: https://charm.cs.illinois.edu/redmine/issues/892

Simon tried to build using the following command on Blue Waters on the nodeGPU branch of charm and kept getting an error:
./build ChaNGa gemini_gni-crayxe hugepages smp cuda –with-production –enable-tracing –j8

I suspect that the problem is related to the build target (ChaNGa) and not the branch (nodeGPU) but I haven't confirmed it yet. I'll post the error here when Simon emails it to me.

Original date: 2015-11-12 22:19:07

I should note that if you get a hybridAPI.h missing error, just re-run the command. This is a known bug (see #788) that I'm working on fixing in other layers.

Original author: Nikhil Jain
Original date: 2015-11-12 22:33:37

Fix here: ~~https://charm.cs.illinois.edu/gerrit/#/c/912/~~ https://github.com/UIUC-PPL/charm/commit/802b882aa3d14748aaaa32866a09b8927b7e8b88


Updated to Symfony 4.3 Beta 2

After updating to Symfony 4.3 beta2, I see this deprecation:

I can't find any occurrence of for ... if in our templates and the deprecation message doesn't tell us which template contains the error. Any clue? Thanks.

I guess it comes from the vendor/symfony/swiftmailer-bundle/Resources/views/Collector/swiftmailer.html.twig template.

Also I see another deprecation in tests:
  1x: The "DAMA\DoctrineTestBundle\PHPUnit\PHPUnitListener" class extends "PHPUnit\Framework\BaseTestListener" that is deprecated Use TestListenerDefaultImplementation trait instead.
    1x in DebugClassLoader::loadClass from Symfony\Component\Debug

I can't find any occurrence of for ... if in our templates and the deprecation message doesn't tell us which template contains the error. Any clue? Thanks.

@javiereguiluz I sent a PR to improve it https://github.com/twigphp/Twig/pull/3031

Updating SwiftmailerBundle will remove some deprecations.

I no longer see deprecations after updating Symfony to 4.3 RC1 and the other dependencies too. @yceruto do you still see deprecations in tests? I can't see anything. Thanks.

I still see this one https://github.com/symfony/demo/pull/974#issuecomment-496197569 https://travis-ci.org/symfony/demo/jobs/538240998#L616


feat: impl evaluator eval context snapshot to prevent self recursively calling panic

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

feat: impl evaluator eval context snapshot to prevent self recursively calling

2. What is the scope of this PR (e.g. component or file name):

kclvm/evaluator/src/func.rs
kclvm/evaluator/src/node.rs
kclvm/evaluator/src/rule.rs
kclvm/evaluator/src/schema.rs
kclvm/evaluator/src/ty.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[x] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

test/grammar/schema/irrelevant_order/relaxed_1/main.k
test/grammar/schema/irrelevant_order/simple_1/main.k

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

19 of 57 (33.33%)  changed or added relevant lines in 5 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 72.584%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

kclvm/evaluator/src/node.rs
7
13
53.85%

kclvm/evaluator/src/func.rs
0
9
0.0%

kclvm/evaluator/src/rule.rs
0
11
0.0%

kclvm/evaluator/src/ty.rs
0
12
0.0%

Files with Coverage Reduction
New Missed Lines
%

kclvm/evaluator/src/rule.rs
1
0.0%

kclvm/evaluator/src/func.rs
1
70.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
47976

Relevant Lines:
66097

💛  - Coveralls


Scheme for Cud

Hi
Nice scheme. Can you make version for CudaText editor?
http://wiki.freepascal.org/CudaText#Color_themes

Hello, for the moment I'm working on a version for VS, although it wasn't in my plans a version for CudaText, I will try to do it as soon as possible.


[HMAC] The FIFO status never becomes full

The FIFO_FULL bit in the HMAC status register is never set and the FIFO_FULL interrupt never triggers.
This can be reproduced with the following diff to the OpenTitan repo
diff --git a/sw/device/lib/hmac.c b/sw/device/lib/hmac.c
index e30e49e8..b33ef184 100644
--- a/sw/device/lib/hmac.c
+++ b/sw/device/lib/hmac.c
@@ -5,7 +5,7 @@
 #include "sw/device/lib/hmac.h"

 #include "sw/device/lib/common.h"
-
+#include "sw/device/lib/uart.h"
 #include "hmac_regs.h"  // Generated.
 #include "hw/top_earlgrey/sw/autogen/top_earlgrey.h"

@@ -23,24 +23,23 @@ void hmac_init(hmac_cfg_t hmac_cfg) {
   REG32(HMAC_CMD(0)) = 1 << HMAC_CMD_HASH_START;
 };

-static int hmac_fifo_depth(void) {
-  return (REG32(HMAC_STATUS(0)) >> HMAC_STATUS_FIFO_DEPTH_OFFSET) &
-         HMAC_STATUS_FIFO_DEPTH_MASK;
-}
-
-static int fifo_avail(void) { return HMAC_FIFO_MAX - hmac_fifo_depth(); }
-
 void hmac_update(const void *data, size_t size_in_bytes) {
   const uint32_t *wp = (const uint32_t *)data;
   uint32_t bytes_per_word = sizeof(uint32_t) / sizeof(uint8_t);
   uint32_t bytes_left_over = (size_in_bytes % bytes_per_word);
   size_t words_remaining = size_in_bytes / bytes_per_word;
+  int i;

   // write in all words
   while (words_remaining > 0) {
     if (words_remaining > HMAC_FIFO_GROUP_SIZE) {
-      // wait until FIFO is at least half drained
-      while (fifo_avail() <= HMAC_FIFO_GROUP_SIZE) {
+      // Try to fill up buffer
+      for (i = 0; i < 10000000; i++) {
+        REG32(HMAC_MSG_FIFO(0)) = 0xDEADBEEF;
+      }
+
+      if (REG32(HMAC_STATUS(0)) & (1 << HMAC_STATUS_FIFO_FULL)) {
+        uart_send_str("FIFO FULL\r\n");
       }

       // write a whole group

The idea of the above code is to write a lot of data to the MSG_FIFO register and then see if the FIFO_FULL bit is set.
Running this on the current master bistream on the FPGA never prints the  "FIFO FULL" message. I am also unable to trigger the FIFO_FULL interrupt.

Hi Alistair,

I think intr: fifo_full is taken away and replaced by intr: fifo_empty
You can not read status interrupt full is because: when fifo is full, it blocks the tlul transaction by setting a_ready to 0. But I think that is a good point - if we block the tlul transaction, status register can never read out "full status". @eunchan could you provide some insight on this?

Ah, you are right about the interrupt. Sorry, I confused myself.

Oh no worries. Glad i can help.
Not sure if you still need it, but the screenshot below is a case for reading out status data "h'102" -> fifo full bit is up.
I think since status register is not sticky like interrupt, it might be harder to hit the case where fifo_full is set. Maybe you can try to random "i" instead of using a fixed "10000000"?
Hope that helps

The reason why it would be nice to know if the FIFO is to then wait for the interrupt. After writing data you could check if the FIFO is full, if it is stop writing data and wait for the FIFO empty interrupt.
Without knowing that it's full there isn't much of a use for waiting for it to be empty.

Just to clarify, are you suggesting to make the status fifo_full bit sticky until the fifo is empty? From what I understand, please correct me if it is wrong - right now, the "status" bit fifo_full will set to 1 when fifo is full, and then reset back to 0 as soon as the fifo is not full.
@eunchan for visibility :)

I assume that is how it works. That is fine as there is also a fifo_empty bit so we can tell when it's not empty. I just can't seem to ever see the fifo not be empty.
I am just surprised that on the FPGA platform the HMAC runs fast enough to never fill up when run in a tight loop.

@cindychip is right. as register interface and MSG_FIFO interface shares the same port, TL-UL (window) back-pressuring also affects the reading out of status register. What I talked with Phil was that the full information is not that needed in the software, as it can read the available fifo entries before write to the MSG_FIFO and be able to push the message not to spill over the MSG_FIFO. Empty interrupt is useful for the software to send next message chunk.
BTW, as you said, with CPU data transfer, HMAC MSG_FIFO cannot be full at all. CPU takes 5 cycles to write a word data into HMAC (load/calc_addr/store) . For 256b (16x32b) message, CPU takes 80 clocks to push, HMAC takes 80 clocks to calculate the hash. exact equilibrium.

Thanks for the clarification. I have a few comments then:

If back pressure applies to both MSG_FIFO and STATUS then I don't see a use for the FIFO_FULL bit in the status register. Should it be removed or at least not documented? In which case the fifo length can be used instead as you mention.

Could read accesses to STAUTS not be back pressured? (then 1 no longer applies).

Ah interesting. From what I can tell OT doesn't have a DMA, so I guess the HMAC can never actually be full.

Thanks for the clarification. I have a few comments then:

If back pressure applies to both MSG_FIFO and STATUS then I don't see a use for the FIFO_FULL bit in the status register. Should it be removed or at least not documented? In which case the fifo length can be used instead as you mention.

There's a case you can see the FIFO_FULL status. If the core is fast enough, and if the software pushes exact amount that is available in the FIFO, then full condition is set and can be read out.
 So I also don't expect that status bit has to be used.

Could read accesses to STAUTS not be back pressured? (then 1 no longer applies).

Ah interesting. From what I can tell OT doesn't have a DMA, so I guess the HMAC can never actually be full.

Any thoughts on removing it then?

should we loop back to resolving this?
Given where we are in the project, I'm inclined to say we should just keep the status indication even if it is not all that useful at the moment.  To @alistair23 point, perhaps this should be better described.  Is that already done @eunchan ? maybe we can close this issue out.


[Feature]: Developer gets Flask app failure feedback from cf logs and logs of Korifi API

Blockers/Dependencies
No response
Background
As a Developer pushing a basic Flask app
I want feedback when I've forgotten basic config (E.g. Procfile) causing the container not to start repeatedly
So that I can diagnose my personal memory failure and resolve my app woes more quickly
Not entirely sure why this is not in the logs, but given cf push hangs starting the app for 120 seconds and there are hundreds of restarts in the logs, we need to ensure we're doing a better job reflecting these failures in the cf push command and in cf logs without dropping 'under the hood' of cf and describing Kubernetes objects (which actually didn't help me in any case in this instance - but at least I saw what stage the failure was at).
Acceptance Criteria
GIVEN a cf push of a Python Flask API app that fails on start
WHEN I execute cf logs for the app, or view the Korifi logs, or describe the underlying Kubernetes resources
THEN I see the container failure message from container start up reported
Dev Notes
I can try and reproduce the same failure locally to see what log output should be possible, then report back with what the Korifi team need to capture once I've discovered it, if that helps.

Hey @adamfowleruk
Could you provide a sample app that reproduces the issue (we are not familiar with Flask)

there are hundreds of restarts in the logs
which logs are you referring to?

We went through the following steps:

Created a flask app as follows (app.rb):

from flask import Flask

app = Flask(__name__)

@app.route("/")
def hello_world():
    return "
Hello, World!
"

Added the gcr.io/paketo-buildpacks/python to both the ClusterStore and ClusterBuilder
Pushed the flask app

Indeed the app did not start and cf logs did not display anything useful, while the pod was in a CrashLoopBackoff state. - The pod's logs were empty

Thee app container had an exit code of 0
The app command was /cnb/lifecycle/launcher python

We read a bit more about the python buildpack and found out that if a framework like flask or gunicorn is being used, there needs to be a Procfile that contains the proper startup command for the framework.
We included the following Procfile with our flask app:
web: flask --app app run

When we pushed the updated app it failed again, but this time cf logs contained a log line as follows:
[APP/] OUT bash: flask: command not found

This is normal, since the clusterstack we are using does not include the flask runtime.
In conclusion the problem you are observing is very specific to the python buildpack, since it defaults to python as a command unless you give it a Procfile and python when run it non-interactive mode exits 0 and does not print anything to stderr. This is why the pod has an empty log and cf logs does not give any useful information.
Closing,  as this does not seem to be a bug in Korifi. Feel free to open if you have any ideas on how we can improve this.


VIS Widget: timer not updated if changing timer value

Describe the bug
If countdown is running and you change the timer interval, the widget timer text will not be updated.
To Reproduce
Steps to reproduce the behavior:

start countdown over dp '.cmd' with command 'start'
change dp '.timer' to a new value

Expected behavior
Widget timer text should be updated
Screenshots & Logfiles

Versions:

Adapter version: 0.7.6
JS-Controller version: 3.3.21

yes this is correct.
the new target time is only calculated at timer start.


Add gif support

Description
Add support for GIFs as an addon.
The data for it is stored between the emulated EEPROM and the actual code with some margin for both to grow.
Related issues

Closes #407

We are going to wait to evaluate this until after the release just a heads up.

I'm going to close this PR as there are too many issues with modifying the EEPROM addresses inside of an add-on.
We should have a new display driver coming out shortly, and we can discuss in firmware-development how to go about adding memory. A lot of boards have 16mb so you could utilize the extra space if the chip is big enough. That's how the other PoC did videos on their gp2040 build.
We can circle back on this one after the display driver comes out but the EEPROM address modifications are going to be a no-go from inside of an add-on.

the EEPROM address modifications are going to be a no-go from inside of an add-on.

The project is using a library that simulates an EEPROM at the end of the flash memory addresses but I'm not writing the gif's into it nor modifying any of it's adresses the only thing that I'm doing with it is reading the constant that stores it's starting address to keep gif data from overwriting those addresses. As I said in a previous comment, this is the proposed flash memory layout in this PR:
Code | GIF_CODE_DISTANCE| Empty space | Gif stuff | GIF_EEPROM_DISTANCE | EEPROM


CesiumTerrainProvider: own terrain data is not loaded since v1.107

What happened?
With the release of 1.107 my own terrain data is not loaded anymore.
No error is shown in the console. The layer.json is fetched, but no terrain tiles.
It works perfectly until v1.106.
Of course I fixed the constructor of CesiumTerrainProvider to the static one .fromUrl.
Is something new expected in the layer.json since v1.107?
Reproduction steps
see sandcastle example
Sandcastle example
https://sandcastle.cesium.com/#c=dZBNb8IwDIb/StQLIFWJdu0KmsR1X9K+LrmExkC0NOlsp4xN/PcFukmMMV8i530eR04TA7HoHWwAxVQE2Ig5kEutHI4XZ1fAY100h3YeAxsXAHVRik8dOoy9s4DVb+sREDN2/53KJcb2Cf1YB3FUozVzR5VSPODS2B4CJwQfV9JFxc4DAZM6DkaHh8VJIbwlIH4GZHi/jdgaT5VgTFD+C98AG2vYVGKZafjN7SY67MohmVzqUJRFTbz1MPvhrlzbRWSR8mJS5iXazhsGUovUvALLhmgv7tFaHau1db1wdnrmU0XjDVFOlsn7B/cBupjVKvN/VB+NdWF11wN6s91j64vZ9XAppaxVbs+bHKNfGDyZ/AU
Environment
every browser

The terrain can be loaded correctly using the following code (After Cesium 1.104):
const viewer = new Cesium.CesiumWidget('cesiumContainer', {
  terrainProvider: await Cesium.CesiumTerrainProvider.fromUrl(
    'https://terrain.adventurelog.io/tilesets/adventurelog', {
      requestVertexNormals: true,
      requestMetadata: false,
  }),
})

Is something new expected in the layer.json since v1.107?

No.

Of course I fixed the constructor of CesiumTerrainProvider to the static one .fromUrl.

Starting with CesiumJS 1.104 The readyPromise pattern has been deprecated across the API. It will be removed in CesiumJS 1.107. This has been done to facilitate better asynchronous flow and error handling.
Therefore, before 1.104, you can use the following code to load terrain:
const viewer = new Cesium.Viewer('cesiumContainer', {
  terrainProvider: new Cesium.CesiumTerrainProvider({
    url: 'https://terrain.adventurelog.io/tilesets/adventurelog',
    requestVertexNormals: true,
    requestMetadata: false,
  }),
})

But after 1.104, you need to use the latest code to load terrain.
In addition, terrainProvider or terrain should be used in the constructor to load terrain, while provider does not exist in the construction parameters.

@lukey78 As @syzdev pointed out, you need the await keyword since CesiumTerrainProvider.fromUrl returns a Promise.
The property is also terrainProvider not provider.

Perfect, thanks!


Add open in Terminal context menu to Windows explorer

Summary of the new feature/enhancement
It would be nice if it was possible to right click on a folder in Windows Explorer and select "Open in Terminal" sort of like you can do with PowerShell 6.0.

It would also be nice to be able to type "terminal" on the windows explorer address bar and have terminal open on that folder (like powershell does).
For example:

Go to a folder in Windows Explorer (i.e. c:\temp)

Type pwsh in the address bar and hit enter

A powershell 6.0 terminal window opens on the C:\temp folder:

this is a duplicate of #1060; please make sure to search before reporting a new issue!

OK, by bad, I searched for it but didn't find it.
Thanks

Here is a solution.


fix(@schematics/angular): fix extra comma added when use --change-detection=onPush and --style=none to generate a component

fixes #22857

Can you please add a UT in https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/component/index_spec.ts and squash all commits?
Thanks.

UT is added and commits are squashed.


Feat: Add Event Booking

Describe the feature
Add the frontend page for event Booking and integrate with the backend API.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I have starred the repository
[X] I'm a gssoc-24-extd contributor
[X] I want to work on this issue

it is same as the register event form so not needed


Update Commit.id to not validate as a UUID

Commit.id <=> RepositoryCommit.name, which is a dashless UUID.
This also implies that ResourceRef.value.id is not a UUID.
TODO:

[ ] This is now inconsistent across the API surface. Should we drop the UUID validation on all IDs? Ideally our IDs are opaque to users and we are not expressing their shape in the API. Alternatively, we add Commit.name back and Commit.id <=> RepositoryCommit.id and Commit.name <=> RepositoryCommit.name.

The inconsistency between some IDs are UUIDs and other aren’t is a bit unfortunate.
I think we should leverage Protovalidate for basic sanity checking of input as much as possible, so I don't think we should remove (buf.validate.field).string.uuid = true from id fields where it is valid.
For fields that can't use the build-in (buf.validate.field).string.uuid = true rule, we shouldn't just remove it, we should replace it with actual validation. It sounds like they are in fact UUIDs without the dashes, so let's validate that.

It sounds like they are in fact UUIDs without the dashes, so let's validate that.

Are we sure we want to go down that path? We are exposing the shape of our IDs, and we cannot change this later.
In the meantime, I'll update the validation rules to validate a dashless UUID.

Are we sure we want to go down that path? We are exposing the shape of our IDs, and we cannot change this later.

This is an interesting philosophical question. My two arguments in favor are:

In practice, it is nice to be able to rely on protovalidate to validate basic things like this.
In theory, even if we remove these validations from the schema, Hyrum's law will apply (people will see that in practice we are using UUIDs everywhere).

Therefore might as well put it in the schema and accept that if we are compelled to change this later it would be a breaking change in that sense.

Closing this PR, the BSR will take care to translate name to id and back as needed. We discussed this as a team and would like to prioritize the best API possible. Decision doc here.


Windows support

It's planed to support windows platform too?

Are there alternative packages or modules that do?

Probably this will be better with node v0.8.x?

This should work well on Windows using recent versions of node 0.6.  Please comment here with more details and I'll reopen the issue if it's still a problem.


The "About" section on the landing page could be customized

The main page has an about section. It currently has the default Wazimap information. We could expand on that to include more information.
Here are examples from other Wazimap implementations:
Kenya
South Africa -- uses the default about section

Thanks, @cliftonmcintosh - i'll work on the about section and get everyone's feedback!

@studenton here's the text for the homepage/about section (shared the doc with your c4n email): https://docs.google.com/document/d/1PYBGVX-hl2ZH6W3QKaO5JEMSDvX0N3lYsiIbbcD6dag/edit#
Pls note there's a text (just below the map to replace and then about section for the homepage. happy to chat via skype or FB if you have qs!


Ability to set a custom facet_size per table

Suggestion from Discord: https://discord.com/channels/823971286308356157/823971286941302908/1016725586351247430

Is it possible to limit the facet size per database or even per table?

This is a really good idea, it could be done in metadata.yml.

I'm going to do this just at the table level - if you want it at the database level I would imagine usually you would be OK running --setting default_facet_size 10 instead, since most Datasette instances only expose a single database.
I may reconsider this in the future.

Relevant code: https://github.com/simonw/datasette/blob/c9d1943aede436fa3413fd49bc56335cbda4ad07/datasette/facets.py#L102-L110

In that code self.table is the name of the current table, but can also be None if the faceting is being run against a custom SQL query instead (a future feature). self.database is the name of the current database.
So reading metadata via self.ds should work fine.

Still needs documentation.

facet_size is now documented here: https://docs.datasette.io/en/latest/facets.html#facets-in-metadata-json


evaluating impure delayed object always delivers the same result

According to the API, I would expect that evaluating the same impure delayed object twice would result in two distinct computations of the result. I would therefore expect, that the following code picks different random numbers:
d = dask.delayed(lambda: random.randint(0,100), pure = False)()
dl = 10*[d]
dask.compute(*dl, get = dask.threaded.get)
dask.compute(*dl, get = dask.async.get_sync) #to see if same seeds might be the problem

However, this always gives 10 times the same result. Maybe I just don't get how to use delayed and the result is already computed in the first line?

You're only calling the function once.  The following are similar
x = random.randint(0, 100)
l = 10 * [x]

d = delayed(random.randint, pure=False)(0, 100)
dl = 10 * [d]

d is a single value.  If you reuse that value it will remain consistent.
I think that you want the following:
f = delayed(random.randint, pure=False)
dl = [f(0, 100) for i in range(10)]

You are right. Thanks. I close the issue.


Favicon is missing in all pages

Hi! I am Suvadip Sana
ISSUE Favicon is missing in all pages. I want to work on it.
Suggestion
I add the favicon same as Logo that displayed on Home page.
Please assign me that issue. I want to work on it.

Ok wait

Here is the screensort.
See the favicon was not there. I want to add this logo as favicon.
Please assign me that issue! I want to fix it properly for every pages.
NOTE expected labels - hacktoberfest, gssoc-exted, point label.

Could you please assign to me?

Hey @Suvadip-sana you find the issue on the main website but currently, we want the contribution to this repo.


input[type="file"] Design Support

Right now the input type file works, but the design looks weird. Here is an example of how it looks:

Resolved with #270


[Design] Consider naming of ContentType enum

There are a few goals:

Consistency across languages (or understand why we diverge)
Does a ContentType type go in Azure.Core? (.NET doesn't currently have one)
Should FR library use a ContentType from Azure.Core, even though FR only supports a subset of possible HTTP content types, or does it make sense to have an extensible enum/enum to enumerate just the content types that FR supports.

Notes:
ContentType enum - is there overlap with ContentType in other libraries?
Python, Java have FormContentType.
In Python can also pass in a ContentType string
.NET to follow up with KC re: services taking content type, common master list in Azure.Core?  Use an extensible enum to pass a string but indicate which values are supported by the service?

Proposed changes:

renaming it to FormContentType

Pros:

the service only supports certain types so we show the user what they can use
Name avoids collision with otherl ibraries  ContentType

Cons:

User will need to learn how to manage content-type per library case

See if this is an opportunity to create a type in Azure.Core that all libraries can use. Doing a quick search I see that KeyVault, AppConfig, Storage, Core, will benefit.

Pros:

One unified way across libraries

Cons:

will need to update previous libraries that already ship
There are going to be types that not all the libraries will use. How to tell the user which ones will work? docs?

after internal discussion, decision was to go with renaming to FormContentType


Video output freezes but can still control phone

[x] I have read the FAQ.
[x] I have searched in existing issues.

Environment

OS: Windows
scrcpy version: 1.24
installation method: Windows release
device model: Realme X2 Pro on Lineage 12
Android version: 12

As soon as i start scrcpy the video output appears normally, however it freezes after 1-3 secs. I can still control my phone through scrcpy, but the video output is stuck on the frame it froze on.
scrcpy 1.24 <https://github.com/Genymobile/scrcpy>
C:\Users\JWEIBERL\Downloads\scrcpy-win64-v1.24\scrcpy-serv... file pushed, 0 skipped. 15.0 MB/s (41159 bytes in 0.003s)
[server] INFO: Device: realme RMX1931 (Android 12)
INFO: Renderer: direct3d
INFO: Initial texture: 1080x2400

Does it also happen at a lower resolution (scrcpy -m1024)?
If you record (scrcpy --record file.mp4), is the resulting file "frozen"?
Also try with another encoder.

I have now tried all available codecs, also at a lower resolution (scrcpy -m1024--encoder 'OMX.qcom.video.encoder.avc') with the same result of it freezing after about a second or two. The recorded files all seem to end as soon as the video output freezes. and range from 1-2MB in size.
I have only had this problem on Android 12, the same phone with the same cable worked fine on Android 11.
Thanks for the help either way.

Looks like a device ROM bug then :/

I figured it was as well, thanks again though  :)


Event Request Codeunit 427 - ICInboxOutboxMgt Function OutboxSalesHdrToInbox

Hello,
Requesting a new event publisher on codeunit 427 - ICInboxOutboxMgt
I would like to request the following publisher with IsHandled Pattern in Function OutboxSalesHdrToInbox
procedure OutboxSalesHdrToInbox(var ICInboxTrans: Record "IC Inbox Transaction"; var ICOutboxSalesHeader: Record "IC Outbox Sales Header"; var ICInboxPurchHeader: Record "IC Inbox Purchase Header")
var
    ICPartner: Record "IC Partner";
    Vendor: Record Vendor;
    >>> New Code Begin
    IsHandled: Boolean;
    <<< New Code End
begin
    GetCompanyInfo;
    >>> New Code Begin
    IsHandled := false;
    OnBeforeOutboxSalesHdrToInbox(ICInboxTrans, ICOutboxSalesHeader, ICInboxPurchHeader, CompanyInfo, IsHandled, ICPartner);
    if not IsHandled then
    <<< New Code End
        if ICOutboxSalesHeader."IC Partner Code" = CompanyInfo."IC Partner Code" then
            ICPartner.Get(ICInboxTrans."IC Partner Code")
        else begin

The signature of the publisher is:
[IntegrationEvent(false,false)]
local procedure OnBeforeOutboxSalesHdrToInbox(var ICInboxTrans: Record "IC Inbox Transaction"; var ICOutboxSalesHeader: Record "IC Outbox Sales Header";var ICInboxPurchHeader: Record "IC Inbox Purchase Header"; CompanyInfo: Record "Company Information"; var IsHandled: Boolean; var ICPartner: Record "IC Partner")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


help with contact information

Hi @xr09 , I would like to talk about a paid work opportunity.
What's the best way to reach you?

Hello @priamai, I'm not freelacing right now.  If you wish you can contact me at<EMAIL_ADDRESS>perhaps I can recommend you someone else.


feat: add label for skipif and onlyif conditions

Users can now add --label options to skip commands. resolve #177
For example:
sqllogictest --label risingwave ... xxx.slt

skipif risingwave
query I
select some_features_not_supported_yet();

This PR also bumps version to v0.14.0.

@skyzh Could you release the sqllogictest-engines? Thanks!

Published and added github:risinglightdb:crates-io as owner


Integration Testing with ITestHarness takes a minute instead of a second after upgrade to 8.0.7 . In 8.0.6 Issue was not there

Contact Details
No response
Version
8.x
On which operating system(s) are you experiencing the issue?
Windows
Using which broker(s) did you encounter the issue?
RabbitMQ
What are the steps required to reproduce the issue?
I use a WebApplicationFactory to start a application for integrationtesting.
Then to integration test consumers I have test methods that roughly look like this:

[Theory]
        [AutoMoqData]
        public async Task Consume_Event(Update update,CancellationToken cancellationToken)
        {
//Arrange
            var harness = _factory.Services.GetRequiredService<ITestHarness>();
            await harness.Start();

            //Act
            var @event = new UpdateIntegrationEvent(eventId, parsedCorrelationId, moment, IntegrationEventVersion.V1, update);
            await harness.Bus.Publish(@event, cancellationToken);
            await harness.InactivityTask;

            var published = await harness.Published.Any<UpdateIntegrationEvent>(cancellationToken);
            var consumed = await harness.Consumed.Any<UpdateIntegrationEvent>(cancellationToken);
            var faults = await harness.Published.Any<Fault<UpdateIntegrationEvent>>(cancellationToken);

            //Assert
            published.Should().BeTrue();
            consumed.Should().BeTrue();
            faults.Should().BeFalse();
        }

What is the expected behavior?
Testing this takes roughly 1 second to  complete.
I know you can set TestInactivityTimeout which I set to 1 second most of the time. For this example it does not matter.
What actually happened?
After upgrade to 8.0.7 test execution takes 1 minute plus...
Related log output, including any exceptions
No response
Link to repository that demonstrates/reproduces the issue
No response

I was looking into all the changes done since 8.0.6 to see if I can find what's wrong.
Didn't find it yet but at least I found that actual changes where done to InactivityTask and timer stuff.
See https://github.com/MassTransit/MassTransit/commit/9d6e0cba592bd31e68f1d324219e360951dbf2e2

Well, the only change is that it actually waits now. And my tests complete in ms, not seconds. So It's clearly something in your test that is causing it to think things are still happening. A standalone repository reproducing the issue would be required, or this issue will be closed. You could modify the WAF sample if that makes it easier.

Hi Chris,
Thanks for your quick response. I'm off right now for an extended weekend but I will have a look next week to see If I can reproduce the issue with the WAF sample and supply you with more details or if I can find what I'm doing wrong with all my integration tests and change them accordingly.
Thomas

Hi @phatboyg
I was able to make a small example additional to the WAF sample to reproduce the issue.
You can find it here: https://github.com/ThomasMaij/Sample-WebApplicationFactory
I will spend some more time to see If i can find the exact issue. Currently I'm looking again in documentation to see if my test setup is wrong.
Best regards
Thomas

@phatboyg Thanks for your hard work for this library!

@phatboyg I ran into the same issue after upgraded from 8.0.7 to 8.0.9. Downgrading to 8.0.7 seems to fix it. The test harness took a minute or 2 to start in 8.0.9

@phatboyg I ran into the same issue after upgraded from 8.0.7 to 8.0.9. Downgrading to 8.0.7 seems to fix it. The test harness took a minute or 2 to start in 8.0.9

Posting a comment on a two-month old issue without any context doesn't really help. If you actually have a reproducible case of a test running slow due to MassTransit, create a new discussion until it's proven that it's an MassTransit issue and not something in your test design.


Preload Progress Bar is unhelpful with small numbers of files

Currently, the preload progress bar updates only when a file is completely loaded. If only a single, large file is being loaded users are left staring at a static bar with no indication anything is happening. I think it's worth exploring estimating how much of each file has been downloaded based on network speed.
If that proves to be non-viable adding in some "Now Loading" text or a loading gif would be better than nothing.
Helpful links:
https://developer.mozilla.org/en-US/docs/Web/API/NetworkInformation/downlink
Edit:
I can't assign this to myself but I will look into this over the next week or so.

Bumping this to 6.2. It looks like downlink isn't widely supported or stable. The best solution is probably to enable some customization of the progress bar so that it can display a circular loading animation if desired.


Please ignore. This is for testing.

@bazel-io cherry-pick
commits: https://github.com/iancha1992/bazel/commit/a2b775467c1b36bd1c935d35770916105cd7102d
reviewers: iancha1992
team: team-ExternalDeps

Cherry-picked in https://github.com/bazelbuild/bazel/pull/19395, which includes the following commit(s): https://github.com/iancha1992/bazel/commit/a2b775467c1b36bd1c935d35770916105cd7102d

Cherry-picked in https://github.com/bazelbuild/bazel/pull/19395, which includes the following commit(s): https://github.com/iancha1992/bazel/commit/a2b775467c1b36bd1c935d35770916105cd7102d


Public APEX URL

Using application setup option 2:
When Browsersync lauches an APEX public URL, the application process set "On New Session" isn't firing, resulting on G_APP_IMAGES not being set.
2 solutions come to mind:

We enforce a random session_id for public apps
We change the dev application process to launch Before Header, just like option 1

@vincentmorneau Just changed the docs (see the commit) to run always. Since it's DEV_ONLY it won't cause any issues in prod. Close if you're ok with it.

What about public apps in production? Won't the 2nd application process fail as well?

@vincentmorneau good point. What do you think about changing (or offering 2 processes depending on usage). The process would be the same except for the following:

When: On load before header...
Condition: when G_APP_IMAGES is null

@martindsouza So the process would be triggered only on the first load. Sounds good to me.
We will need to emphasize on the importance to stick with the documentation.
You can close the issue once /docs/apex-setup.md is modified.


move up to 1.4 release of containerd

Updating the more stable test branch of containerd from the 1.4 beta 2 branch to the released 1.4 branch.
Signed-off-by: Mike Brown<EMAIL_ADDRESS>

Its great that containerd has gone to 1.4.0. LGTM NB. Thanks @mikebrow


Use Cases: refactor

From discussion with @shcheklein. TLDR:

[ ] use cases should high-level and answer to common scenarios users have in mind. Such as MR, Productionization, or Deployment to preview environments (should be formulated differently though).
[ ] if we would have enough time, we could cover "five patterns to put the ML model in production: Model-as-Service, Model-as-Dependency, Precompute, Model-on-Demand, and Hybrid-Serving."
[ ] CI/CD should be moved to User Guide (probably)
[x] DVC+MLEM should be moved to User Guide (definitely)
[x] Pure ML model registry can be a nested Tutorial inside of MR use case

Overall, since the team is small and docs are big, we need to thing what we can throw away - it slows us down. We need to work on simple things and GS adoption instead of covering extra/corner scenarios in docs.

use cases should high-level and answer to common scenarios users have in mind

Yup. Think problem/solution stories for ML team leads or even managers who don't want to see code or command line yet. We tend to use basic diagrams instead, and general language in the text (as little technical as possible).
From the existing pages:

Versioning MLEM objects with DVC: this is more of a general guide (DVC integration). Versioning itself is not really a use case of MLEM, I think.

Machine Learning Model Registry & Pure Mlem Model Registry: The former is a proper use case but non-MLEM specific. The latter could be somehow merged in (without all the instructions) so it belongs better in mlem.ai .

We could even remove the former from dvc.org at that point (it's a bit stretched to say that its a UC of DVC).

CI/CD for Machine Learning: the intro is good although I don't think this is really about CI/CD (more about distribution?) -- we can work on it 🙂

MR, Productionization, or Deployment to preview environments

I think def. productization is the highest priority one we should work on next though, maybe in parallel with doing some of the changes I outlined above.

cover "five patterns to put the ML model in production

Sounds more like a blog post to me.

CI/CD should be moved to User Guide (probably)

Yes for the bottom sections with instructions, or maybe even a blog since it's mostly about Github actions (we don't want to document 3rd party tools).

Marking p1 since good UCs are expected to help drive traffic and adoption to the tool. Note that however I still think the GS is a higher priority atm.


How logspout is diffrent from default docker drivers like GELF/syslog plugins

Hi,
I am exploring logging tools to collect logs from docker containers. How logspout is different from docker logging drivers. For example: GELF plugin can also send logs to logstash.

look https://github.com/micahhausler/logspout-gelf

@dvyas logspout is different from docker logging drivers because it allows you to keep the local logs (so the command docker logs <container> still works) while still shipping the container logs to a remote location. This is accomplished using the docker api (that's why logspout needs access to docker socket). I would say that this makes logspout more flexible in some situations. Try out both and you will spot the differences


Consolidate newlines in exception messages to avoid blank output

The exception message will now have leading newlines removed to avoid displaying a blank message as a header.
I took the way the error message is constructed from ActiveRecord's MigrationError error class and wrote a test case mimicking it.
Fixes #313

:+1:


Exclude Control: Clicking on option doesn't focus on setting item

Testing #55402
I would expect that clicking an option would focus on the setting item:

Otherwise, the description doesn't get expanded and look weird.

Other settings are the same, the control focus is independent of the setting itself.
I'll leave it for now since I may still try to get rid of focusing rows anyway.


util/panic_hook, test: panics as aborts

Panics as aborts, it's helpful for debug. There is a feature panic=abort in rust, but unfortunately it does work in tests.

@BusyJay It is alway disabled in tikv-server and others, it is enabled in tests only, for debug locally.

LGTM

PTAL

LGTM.

/rebuild

/run-all-tests


Word count does not work in Overleaf

Need to change the macro to make word count work in Overleaf

Awesome work.  I have used this template for a couple of years.
wordcount broke locally as well, it seems to have a problem with \@@localdummy. Also, is it possible to rename \trbcite to \citep to keep the name more consistent?

@hrgentry thanks.  I was able to compile it successfully with correct wordcount in TeXstudio locally.  What OS and TeX environment are you using?  Also, I've replaced \trbcite with \citep in the master.

Thanks for the update. I am using macOS, tried to compile with the vanilla latex and latexmk but with no luck.
Sent with GitHawk

Thanks for the response.  Unfortunately, I do not have access to macOS to test this.  I hope other users can help with this.

@chiehrosswang is there a temporary workaround to get overleaf to display the correct word count?

@chiehrosswang is there a temporary workaround to get overleaf to display the correct word count?

I will work on this tonight and will let you know.

@JeroenSchmidt the current master works in Overleaf now.  Let me know if you have any other questions.

Thanks for the update!
I just wanted to comment that I was trying to figure out why the word count wasn't working on an Overleaf project I updated to match the master. It turns out it was because I'd renamed my main tex file differently from trb_template.tex which didn't play well with the cls file command. A small mistake on my part, but I thought it was worth mentioning.

Yes, thanks @CarlinLiao for the feedback.  I will add this constraint to Readme so that people are aware of this.


Query data doesn't update when I use returnObjects

What is the purpose of this pull request? (put an "X" next to item)
immutable effect, objects that have been interpolated change original data
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
clone data before returning value, i use lodash.clonedeep to handle deep object, JSON.parse(JSON.stringify()) or Object.assign is not good for deep object
Which issue (if any) does this pull request address?
issue https://github.com/aralroca/next-translate/issues/952

hi @aralroca thanks for your libray, i got some problem when i use returnObject, please review my pull request, Thank you in advance

I need this fix for my project too.

unit tests added, pls review @aralroca
with clone object

without clone object

This is quite a bump in bundle size across the board (even for situations that don't use returnObjects). lodash.clonedeep seems to be approximately twice the size of next-translate. There are definitely solutions (better dependency selection or even better, writing own code) that achieve the same effect with a fraction of the cost.

oke, let's use JSON.parse(JSON.stringify()) for now, i think it works for this case.

hi @aralroca how about this issue? i need this changes

I'll just leave this here. JS has had a built-in feature for deep cloning for about a year. Browser support is also very good. But this approach is not suitable for older browsers.
https://developer.mozilla.org/en-US/docs/Web/API/structuredClone
https://caniuse.com/?search=structuredClone

it's a pitty that structuredClone is not available in all modern browsers... 😅

@alziqziq please remove the yarn.lock & package-lock.json changes, after this I'm going to merge it for the next release

and @alziqziq thank you for your contribution. Please @all-contributors add @alziqziq for code

@alziqziq please remove the yarn.lock & package-lock.json changes, after this I'm going to merge it for the next release

done, please rereview @aralroca


refactor BMC code

Reviewer checklist

[ ] Test coverage: stack test --coverage
[ ] Public API documentation: stack haddock
[ ] Style conformance: stylish-haskell

Line 45 needs further refactor. I need to return the result to the caller and use frontend to pretty print the result. This is the only place that will use the log.


Fixes Brush Selection Movement (#427)

Description
Enables the brush selection to be dragged.
Motivation and Context
.selection was being selected with select vs selectAll
Fixes https://github.com/eventbrite/britecharts/issues/427
How Has This Been Tested?
Tested this in docs locally. Tried to figure a way to write a test but couldn't figure out a way to simulate the movement. If you have any ideas I'm happy to write a test.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

LGTM
Interesting! I don't know the why of this problem, why would it fail to drag and drop?!
Thanks a lot for the fix!
PS: Yeah, doesn't look is doable to test this.

TBH im not 100% sure either. I noticed that select returns an array and selectAll a node list.

Thanks a lot for your first contribution!!


[Feature] Darwin: Pass event timestamp to MTRDeviceDelegate

Feature description
Current Darwin MTRDevice doesn't pass event timestamp to the MTRDeviceDelegate.
Apps may need to use the timestamp to discard too old events.
Please add event timestamps (maybe add to the dictionary with a dedicated key).
Platform
darwin
Platform Version(s)
No response
Anything else?
No response

For an event, we should be including everything present in MTREventReport.  So:

MTREventPath
Event number
Event priority
Event timestamp
The actual payload

Or just the path and error if here is an error.

Oh, and the event timestamp even in MTREventReport is kinda broken, since it just gives the value but not the type (system vs epoch time)....  We should add the type information in MTREventReport, and in the MTRDevice bits.

And we should decide for "epoch time" whether to leave it as CHIP epoch time or convert it to something people are more likely to understand....

Summary of Slack discussion, from @jtung-apple:
MTREventTimeTypeKey => NSNumber-wrapped enum of { epoch_type, system_type }
MTREventEpochTimeKey => NSDate object
MTREventSystemTimeKey => NSNumber-wrapped NSTimeInterval (which is seconds in a double)

and for MTREventReport, nullable NSDate and nullable NSNumber for the system time case.  And the enum.


Test the firewall missing steps

When testing the firewall on https://docs.microsoft.com/en-us/azure/firewall/tutorial-firewall-dnat#test-the-firewall, we reference a network rule RC-Net-01 that has not been created in the tutorial.  We should add a step to provision a Network Rule Collection on TCP with any source address (*) and the destination address of the private IP of the VM created ( probably <IP_ADDRESS>) on port 3389 with action Deny.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8ea87406-981b-8188-7d3f-ef68eb2ba367
Version Independent ID: 08dd0694-7a64-e24a-5338-9de873f4bda2
Content: Filter inbound traffic with Azure Firewall DNAT using the Azure portal
Content Source: articles/firewall/tutorial-firewall-dnat.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@gundermanc
Fixed.

#please-close

Looks like I was erroneously mentioned? :)


Constant names for env vars should be with _ENV_NAME suffix

Most of them already are but it should be consistent.

With the refactoring of configuration code now in version 3.2.47, this is no longer an issue.


Create anndata function calling modules

This issue is to create a module in the API agent that can generate function calls for anndata package, starting with combining, reading and filtering.

Done in https://github.com/biocypher/biochatter/pull/229

develop a starter for pydantic classes for the anndata reader classes
develop a tools calling starter code for binding multiple classes

Next steps needed:

modify the query builder
modify unit tests for the new structure
develop a abtract class parser for the pydantic class

Next sprint:

extend it to filtering, mapping and concatenating


add coroutines + move Utils waitFor into common

Sorry for leaving this so long alone.
Looks good to me :-)


Performance regression when MKL is enabled

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
No.

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Ubuntu 18.04.5

TensorFlow installed from (source or binary):
Binary

TensorFlow version (use command below):
1.13.2 and 1.14.0

Describe the current behavior
Train a ssdlite_mobilenet_v2 model with 1.13.2 and 1.14.0, the inference speed is very different. 1.14.0 one is about 50% to 100% slow with MKL enabled. When MKL is disabled, there is no obvious difference.
benchmark_model shows:
1.13.2

             _MklFusedConv2D           55       13.732      43.384%     43.384%  45625.535         55
         NonMaxSuppressionV3           27        5.386      17.016%     60.401%     10.800         27
    _MklDepthwiseConv2dNative          33        3.161       9.987%     70.387%  20275.297         33
                    _MklToTf           72        2.027       6.404%     76.791%  23987.072         72
                         Mul           51        1.783       5.633%     82.424%     15.336         51
                         Add           81        1.772       5.598%     88.023%      0.016         81
                   _MklRelu6           33        0.731       2.309%     90.332%     30.096         33
                        NoOp            1        0.462       1.460%     91.792%      0.000          1
                        Cast            6        0.383       1.210%     93.002%   1104.316          6
                       Slice           33        0.272       0.859%     93.861%    414.072         33
                    GatherV2           69        0.227       0.717%     94.579%    253.200         69
                       Const          614        0.180       0.569%     95.147%      0.000        688
                _MklConcatV2            6        0.168       0.531%     95.678%    358.848          6
        TensorArrayScatterV3            5        0.151       0.477%     96.155%   1317.728          5
                         Sub           44        0.133       0.420%     96.575%     15.336         44
                     Sigmoid            1        0.132       0.417%     96.992%      0.000          1
                      TopKV2            2        0.117       0.370%     97.362%     43.200          2
                StridedSlice           54        0.076       0.240%     97.602%      0.088         54
                       Shape           50        0.058       0.183%     97.785%      0.344         50
         TensorArrayGatherV3            6        0.057       0.180%     97.965%   1082.416          6
               TensorArrayV3           11        0.051       0.161%     98.127%      2.596         11
                        Pack           24        0.046       0.145%     98.272%     30.956         24
              ResizeBilinear            1        0.045       0.142%     98.414%   1080.000          1
                    ConcatV2           27        0.039       0.123%     98.537%     10.800         27
                      Select           33        0.038       0.120%     98.657%      0.000         33
                        Less           31        0.038       0.120%     98.777%      2.704         35
                       Enter           26        0.036       0.114%     98.891%      0.000         26
                       Merge           10        0.035       0.111%     99.002%      0.040         20
                        Fill           30        0.031       0.098%     99.100%     11.204         30
                   ZerosLike           29        0.030       0.095%     99.194%     10.808         29
                     Reshape           74        0.028       0.088%     99.283%      0.000         74
                       Split            3        0.026       0.082%     99.365%    129.600          3
                      Unpack            5        0.023       0.073%     99.438%     92.044          5
               _MklTranspose            3        0.020       0.063%     99.501%     92.016          3
                      Switch           10        0.019       0.060%     99.561%      0.000         20
                       Range           14        0.018       0.057%     99.618%      1.244         14
               NextIteration           10        0.014       0.044%     99.662%      0.000         10
                     Squeeze            4        0.010       0.032%     99.694%      0.000          4
          TensorArrayWriteV3            6        0.009       0.028%     99.722%      0.000          6
                     Minimum            6        0.009       0.028%     99.750%      0.000          6
                     Greater            6        0.009       0.028%     99.779%      2.705          6
                  ExpandDims            7        0.009       0.028%     99.807%      0.000          7
                     _Retval            4        0.007       0.022%     99.829%      0.000          4
                         Exp            2        0.007       0.022%     99.852%      0.000          2
           TensorArraySizeV3            6        0.006       0.019%     99.870%      0.024          6
                     Maximum            4        0.006       0.019%     99.889%      0.000          4
                       Where            1        0.005       0.016%     99.905%     21.600          1
           TensorArrayReadV3            5        0.005       0.016%     99.921%      0.000          5
                         Sum            1        0.004       0.013%     99.934%      0.004          1
                  LogicalAnd            2        0.004       0.013%     99.946%      0.000          4
                         Pad            3        0.003       0.009%     99.956%      0.000          3
                GreaterEqual            1        0.003       0.009%     99.965%      2.700          1
                       Equal            2        0.003       0.009%     99.975%      0.002          2
                        Size            2        0.002       0.006%     99.981%      0.008          2
                    LoopCond            2        0.002       0.006%     99.987%      0.000          4
                      Assert            3        0.002       0.006%     99.994%      0.000          3
                        _Arg            1        0.001       0.003%     99.997%      0.000          1
                        Tile            1        0.001       0.003%    100.000%      0.000          1
                    Identity            4        0.000       0.000%    100.000%      0.000          4
                        Exit            6        0.000       0.000%    100.000%      0.000          6
Timings (microseconds): count=283 first=29518 curr=32211 min=29448 max=39857 avg=32586.2 std=1784

1.14.0

                  _MklConv2D           43       12.516      28.381%     28.381%  43239.328         43
    _MklDepthwiseConv2dNative          33        7.580      17.188%     45.569%  20275.297         33
         NonMaxSuppressionV3           27        5.294      12.005%     57.574%     10.800         27
                         Add          114        5.088      11.537%     69.111%      0.016        114
                    _MklToTf          100        4.871      11.045%     80.156%  52036.352        100
                   _MklRelu6           59        2.116       4.798%     84.955%     53.808         59
                         Mul           51        1.774       4.023%     88.977%     15.336         51
             _MklFusedConv2D           12        1.282       2.907%     91.884%   2386.208         12
                        NoOp            1        0.563       1.277%     93.161%      0.000          1
                        Cast            6        0.374       0.848%     94.009%   1104.316          6
                       Slice           33        0.294       0.667%     94.676%    414.072         33
                       Const          601        0.293       0.664%     95.340%      0.000        677
                    GatherV2           69        0.232       0.526%     95.866%    253.200         69
                _MklConcatV2            6        0.174       0.395%     96.261%    358.848          6
        TensorArrayScatterV3            5        0.173       0.392%     96.653%   1317.728          5
                        AddN           10        0.142       0.322%     96.975%      0.000         10
                         Sub           44        0.138       0.313%     97.288%     15.336         44
                     Sigmoid            1        0.132       0.299%     97.587%      0.000          1
                      TopKV2            2        0.121       0.274%     97.862%     43.200          2
                StridedSlice           54        0.085       0.193%     98.054%      0.088         54
                     Reshape           74        0.063       0.143%     98.197%      0.000         74
         TensorArrayGatherV3            6        0.060       0.136%     98.333%   1082.416          6
                       Shape           50        0.056       0.127%     98.460%      0.344         50
              ResizeBilinear            1        0.055       0.125%     98.585%   1080.000          1
                    ConcatV2           27        0.053       0.120%     98.705%     10.800         27
               TensorArrayV3           11        0.052       0.118%     98.823%      2.596         11
                        Pack           24        0.051       0.116%     98.939%     30.956         24
                      Select           33        0.043       0.098%     99.036%      0.000         33
                       Enter           26        0.042       0.095%     99.132%      0.000         26
                        Less           31        0.040       0.091%     99.222%      2.704         35
                       Merge           10        0.037       0.084%     99.306%      0.040         20
                        Fill           30        0.032       0.073%     99.379%     11.204         30
                   ZerosLike           29        0.031       0.070%     99.449%     10.808         29
                       Split            3        0.027       0.061%     99.510%    129.600          3
                      Unpack            5        0.025       0.057%     99.567%     92.044          5
                      Switch           10        0.022       0.050%     99.617%      0.000         20
               _MklTranspose            3        0.020       0.045%     99.662%     92.016          3
                       Range           14        0.017       0.039%     99.701%      1.244         14
               NextIteration           10        0.017       0.039%     99.739%      0.000         10
          TensorArrayWriteV3            6        0.012       0.027%     99.766%      0.000          6
                     Squeeze            4        0.010       0.023%     99.789%      0.000          4
                     Minimum            6        0.009       0.020%     99.810%      0.000          6
                     Greater            6        0.009       0.020%     99.830%      2.705          6
                  ExpandDims            7        0.009       0.020%     99.850%      0.000          7
                     _Retval            4        0.008       0.018%     99.868%      0.000          4
           TensorArrayReadV3            5        0.007       0.016%     99.884%      0.000          5
                         Exp            2        0.007       0.016%     99.900%      0.000          2
           TensorArraySizeV3            6        0.006       0.014%     99.914%      0.024          6
                  LogicalAnd            2        0.006       0.014%     99.927%      0.000          4
                       Where            1        0.005       0.011%     99.939%     21.600          1
                     Maximum            4        0.005       0.011%     99.950%      0.000          4
                         Sum            1        0.004       0.009%     99.959%      0.004          1
                         Pad            3        0.003       0.007%     99.966%      0.000          3
                GreaterEqual            1        0.003       0.007%     99.973%      2.700          1
                       Equal            2        0.003       0.007%     99.980%      0.002          2
                        Size            2        0.002       0.005%     99.984%      0.008          2
                    LoopCond            2        0.002       0.005%     99.989%      0.000          4
                      Assert            2        0.002       0.005%     99.993%      0.000          2
                        _Arg            1        0.001       0.002%     99.995%      0.000          1
                        Tile            1        0.001       0.002%     99.998%      0.000          1

Timings (microseconds): count=207 first=39464 curr=48545 min=38998 max=65787 avg=45005.9 std=4312

@YijinLiu
As there is support for 2.x only now,could you please upgrade ad let us know if you still face any issues in 2.x.

Unfortunately, tf2 doesn't fully support the model I am using. I am stuck in tf1 for now.
I use the C++ interface. I assume there is no much difference between tf1 and tf2?
I tried tf1.5, which has the exact same issue. I guess it's related to some mkl C++ code that cannot handle conv2d for models trained with tf1.4+. Is it possible that you have some guy from Intel (whoever contributed https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/common_runtime/mkl_layout_pass.cc) take a look?

@YijinLiu
There is Intel optimized Tensorflow 1.15.0up1.
It includes many bug and performance fix.
We have got good performance improvement feedback from customers.
Could you try with it?
Installation:
pip install https://storage.googleapis.com/intel-optimized-tensorflow/intel_tensorflow-1.15.0up1-cp36-cp36m-manylinux2010_x86_64.whl

@YijinLiu
Is there any feedback?

I just tried it. Got illegal instruction...
My CPU is i7-10700. I hope running inside docker won't be a problem.

@YijinLiu
Oh, could you share your log for the issue?
It's Tensorflow 1.15 base, so the script need to be changed from some API of Tensorflow 1.13 or 1.14 to 1.15.
Is there same issue when run your script with stack/official TF 1.15?
What's the guest OS in docker?

@YijinLiu
Could you share the log?

@YijinLiu
Is your issue present?
If yes, could you answer above questions?

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


Add turnstile to player/s

Adds CF Turnstile

Description 🗒
Adds Turnstile token generation to the players and player pages for requests to players.tarkov.dev

Examples 📸

Related Issues 🔗

 Expand for Help

Have questions about the review or deployment process? View our contributing docs
Need additional help and want to chat in real time? Join our community Discord

By submitting this pull request, you agree to our code of conduct

.deploy to development

.deploy

.unlock

.deploy

.deploy main

.deploy to development

.deploy

.deploy main

.deploy to development

.deploy to development

.deploy to development

.deploy

.deploy

.unlock production

.deploy


Added *.DS_Store for Mac users

We track these in Global/OSX.gitignore rather than apply them to every possible scenario.

Makes sense. My mistake. So you can have multiple .gitignore files in your
working directory and Git will obey them all?
On Wed, Nov 18, 2015, 3:59 PM Brendan Forster<EMAIL_ADDRESS>wrote:

Closed #1760 https://github.com/github/gitignore/pull/1760.
—
Reply to this email directly or view it on GitHub
https://github.com/github/gitignore/pull/1760#event-468448045.

@BGR360 I recommend concatenating the files together based on your situation (for example, Windows + VisualStudio, or Windows + OSX + Node).


Fix: Wrong CSS class for labels

There is no label-important CSS class in Bootstrap 3 (was in Bootstrap 2). Equivalent class in new version is label-danger.

@lku thanks, merged!


Properly initialize ActionMailer outside railties

The divided load was triggering errors when encountering an unexpected load order. This allows the dependencies to properly load in any configuration.

This should properly correct the issue discovered here #1038

Cool, also; thanks for the insightful comments on #1038 too 🙏


How to perform testing with this package?

This package does not allow to be used in a test, because it does not use mocked SharedPreferences during a test

Did you have an issue with Android Playstore ?
Tencent TBS SDK ?


Allow fine grained event control

This change enables the ability to remove/add events that should be
handled by the eventHandler function. The purpose for this change is to
fix the cursor issue that occurs with Android browsers.
If you remove the 'input' event from the eventsToHandle then the ui-mask
directive works properly for Android browsers. However, you can't just
remove it permanently as that causes other UX issues on non-Android
browsers.
Hopefully this can be used for people to fix issues related to #21.
Code snippet on how it can be configured globally (please let me know if there is a better way)
   app.run(['uiMaskConfig',  function (uiMaskConfig) {
        var isAndroid = /(android)/i.test(navigator.userAgent);
        if (isAndroid) {
            var index = uiMaskConfig.eventsToHandle.indexOf('input');
            uiMaskConfig.eventsToHandle.splice(index, 1);
        }
    }]);

so PowerKiki, would one just chain this to the controller to bring its function in.  I have done that just having issues testing an Android locally.


Adding pluto-encrypted inMemory storage in demo Apps

Proposed feature
I propose to completely remove plutoinmemory which is insecure and not efficient, and in replacement use the package that I have created recently and is being maintained by the community, not just myself.
https://github.com/elribonazo/pluto-encrypted
Feature description
Not much needs to be done honestly, the package is plug and play, we could make this really quick
Anything else?
No response

Demos are using that in the following PR, we can close the ticket when the Pr is merged.


nixos: grsec-lock service fixes

There's no ConditionIsReadWrite in systemd units

@lethalman a typo, sorry. I originally used ConditionPathExists, but changed to IsReadWrite before submitting the PR and somehow lost the "Path" part.
I did a nixos-rebuild and systemctl restart grsec-lock before submitting, but there was no warning from systemd (systemctl cat grsec-lock confirms that the unit configuration it has loaded contains the typo) ...
Anyway, I've updated the PR sans the typo.

Haven't tested it but seems sane, thanks. cc @thoughtpolice


Return 202 Accepted for incoming POSTs

Current protocol defines that when an activity is posted to the bot there is no expected reply body other than a success status code except in 2 cases

invoke - we return the invokeResponse as content
DeliveryMode=expectReplies - we return an array of activities for the caller to process instead of HTTP POST back to the caller.

The activity protocol is designed conceptually as bi directional async delivery of activity objects. The SDK models this in a naive way...because it might have to return a body, it waits until the end of the turn to return the status code even when it knows there will be no content. This has the effect of delaying the status code for the incoming activity until the entire turn is complete and ALL of it's downstream dependencies are completed.
This is illustrated by this diagram:

You can see that the response to step 1 only happens in step 5 after 2, 3, 4 are processed.
This leads to ill effects in the system which impacts developers and us.

The caller is left waiting a long time for the status code...the status code should not change regardless if you succeed processing the turn or not.
Clients/Channels are blamed for being slow, because the initial delivery of the activity absorbs ALL downstream costs of the bot code. (For example ABS team is constantly getting ICM tickets for performance of delivery when the perf problem is in the bot's own code.)
Any internal dependencies that fail get attribute back to a protocol failure for the caller, complicating the trace logs (we write "we couldn't deliver that message with 503", even though we successfully delivered the message and it was the bot logic that failed it's internal logic.  the sender does not care if the bot understood a message and it shouldn't be an error status.
It makes it hard to read the logs because the traces are spread over large area
with addition of new Command activity type, it's possible that the target channel could POST back to the bot again....If it does that synchronous, then the entire chain would have to unwind to release the initial POST.

This illustrates the command chaining that will happen if we don't make this change:

The initial POST(message) will block until all of the services have unwound until step 8.
The alternative is to change our SDK code to decouple the call chains by returning 202 Accepted when it receives an activity it knows does not need a response body and has been validated. This looks like this:

Where activity 1 is acknowledged immediately, unblocking the caller and allowing the bot's logic decides to continue to process the turn.  This allows all of the POST transactions to live the shortest life spans.

@tomlm, this was reviewed by the SDK team. We are pushing to R14 so we have time to do end-to-end testing.

We ran into this in the telephony crew as well for async / await actions. Given how short R14 is, and how at the core this change is, I'm moving this to R15. We'll address it in early R15 so it has time to bake.


Why does Wanchain testnet chainid 999 conflicted with Zora-Testnet?

https://thirdweb.com/zora-testnet
https://chainlist.org/chain/999 << it's Wanchain Testnet

On chainlist. Zora isn't the "999"

the correct zora testnet is here: https://thirdweb.com/zora-sepolia-testnet
looking into why 999 points at an (incorrect, and non-functional) zora testnet, thanks for the report

Resolved the conflict, it will however take some time to make it out via various layers of caching, here's what happened:

zora launched their (goerli) testnet at chainId 999

wanchain had been essentially "dead" for a long time (no usage, almost no available interaction)

as such we (back then) decided to give zora testnet (again, goerli) the 999 chainId that they had selected

since then zora has launched their (active) sepolia testnet, which is (correctly) at chainId: 999999999

we never removed the override for 999 (until today)

thanks again for pointing this out! it'll be fixed once caches clear out over the next hour or so
this once again reinforces my belief that as an industry we need a better solution to organizing "what chains exist"


Add type to app.Config struct

We need to add the type attribute to the Struct to comply with the spec

Done!


DEP: delete all code marked for deprecation by 2024.12

[CHANGED] all coevolution functions described in Caporaso et al 2008
have been deleted. The exception are the mutual information
based methods which were recently refactored with much faster
implementations.
[CHANGED] the cogent3.util.recode_alphabet module, used by the above,
and tests have also been deleted
Summary by Sourcery
Remove all code marked for deprecation by December 2024, including coevolution functions and the recode_alphabet module.
Enhancements:

Remove deprecated coevolution functions from cogent3.evolve.coevolution module, retaining only mutual information based methods.

Chores:

Delete cogent3.util.recode_alphabet module and associated tests.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
243 unchanged lines in 18 files lost coverage.
Overall coverage decreased (-0.02%) to 92.195%

Files with Coverage Reduction
New Missed Lines
%

.nox/test-3-11/Lib/site-packages/cogent3/evolve/coevolution.py
2
97.01%

.nox/test-3-12/Lib/site-packages/cogent3/evolve/coevolution.py
2
97.01%

.nox/test-3-11/lib/python3.11/site-packages/cogent3/evolve/coevolution.py
2
97.01%

.nox/test-3-10/Lib/site-packages/cogent3/evolve/coevolution.py
2
97.01%

.nox/test-3-10/lib/python3.10/site-packages/cogent3/evolve/coevolution.py
2
97.01%

.nox/test-3-12/lib/python3.12/site-packages/cogent3/evolve/coevolution.py
2
97.01%

.nox/test-3-10/Lib/site-packages/cogent3/core/new_alignment.py
18
96.58%

.nox/test-3-10/lib/python3.10/site-packages/cogent3/core/new_alignment.py
18
96.58%

.nox/test-3-12/lib/python3.12/site-packages/cogent3/core/new_alignment.py
18
96.58%

.nox/test-3-12/Lib/site-packages/cogent3/core/new_alignment.py
18
96.58%

Totals

Change from base Build<PHONE_NUMBER>2:
-0.02%

Covered Lines:
205205

Relevant Lines:
222576

💛  - Coveralls


Format confirmation flash message in services

Format confirmation flash message in services.  Replace double quotes with single quotes and change text to lowercase to match delete button at end of services pages.
Delete button:

Flash Message before:

Flash Message after:

We've agreed on no quotes at all now, and everything is updated accordingly in PR #355 (finally ready to be merged!), so this PR should be closed.

  That's been the second story today, how disappointing!  Will close the pull request.

I know, sorry, I didn't know it had gone into Pivotal at all.

Sorry, I had a thought about this - on Monday afternoon discussing with @ralph-hawkins and Sarah it was decided to go with no quotes at all.  If the story in Pivotal is more recent than that then the design might have changed again and so maybe we do want quotes after all.
So we should check this morning to see what the final design decision is. (I don't have access to Pivotal at the moment so can't check the story right now.)


Request for an expedited 0.31 release to fix subclassing?

Question
For bugs/questions:

OS: All
Python version import sys; print(sys.version): All
Pydantic version import pydantic; print(pydantic.VERSION): 0.31

I would like to request an expedited release for 0.31 to fix the subclass init calling BaseModel from #644? I normally would not make such as request as its not an urgent rush since any release we do can pin around 0.30, but I'm weary to leave a release which alters the fundamentals of Python class inheritance imitation un-patched for long.
Thanks in advance!

Okay, I'm making a v0.30.1 release now.

Awesome, thank you so much!

release v0.30.1 done, will be available in pypi once builds have completed, probably ~20 minutes.


(v3.2.1) (iOS) No users on dashboard & Not receiving notifications

Description:
I can't get v3.2.1 working. I set up the app, followed the documentation and checked the app id several times. The weird thing is that I don't even see the Users in the OneSignal dashboard.
I tried to initialize the module in the both ways (JS and AppDelegate).
Finally I tried to downgrade to v3.1.4, I just replaced the version in the package.json, ran yarn and it worked.
Environment
Version v3.2.1
SDK installed using yarn, and linked with react-native link (Not pods)
RN v0.55.3
OS: iOS
Steps to Reproduce Issue:

Install the OneSignal SDK using yarn into your project yarn add react-native-onesignal
Run react-native link react-native-onesignal
Set up OneSignal app
Initialize the SDK in the iOS AppDelegate or with OneSignal.init() in the JS code
Attempt to receive a push notification

Anything else:
The app didn't crash nor throw any errors.
I debugged the ids listener and I noticed that it doesn't gets executed every time I open the app, just sometimes (don't know if that's the correct behavior).
I didn't try it on Android.

Same here.

Hi @nicastelo
Can you verify that if you go to the Xcode project settings, libRCTOneSignal.a shows up as a dependency in the Linked Libraries section?

Also, I suspect this is an issue with Xcode subproject dependencies vs. cocoa pod dependencies.
Can you tell me if your project looks like this?

@Nightsd01 I have the same issue and can verify that my setup is as you described.

@tpedersen123 Can you call OneSignal.setLogLevel(6, 0) before you call OneSignal.init("your_app_id") and tell me if you see any errors printed to the console?
Also, let's check a few things:

You're not using Expo right?
You are running on a real iOS device, correct? Please note that Apple does not support push notifications in the iOS simulator
You went to Xcode Project Settings > Capabilities, and enabled Push Notifications?
Where in your react app are you calling OneSignal.init() from?
Can you see if this issue occurs in the previous version (3.1.4)? If you downgrade to 3.1.4, note that this older version doesn't support JS initialization so you'll have to add code to the native Objective-C AppDelegate as described here

You're not using Expo right?
Nope
You are running on a real iOS device, correct? Please note that Apple does not support push notifications in the iOS simulator
Yes
You went to Xcode Project Settings > Capabilities, and enabled Push Notifications?
Yes
Where in your react app are you calling OneSignal.init() from?
In our "root" component in ComponentWillMount
Can you see if this issue occurs in the previous version (3.1.4)? If you downgrade to 3.1.4, note that this older version doesn't support JS initialization so you'll have to add code to the native Objective-C AppDelegate as described here
It worked fine before the updrage to 3.2.*, we have had this app running for months now on 3.1.2 working just fine.
Only a recent addition of AWS modules forced us to upgrade because of the collision with Google Play Services (GMS module)

The code works fine on Android with the exception of "onIds()" event listener not being called.
I tried your example project on Android, that doesn't trigger "onIds()" to be called either as far as I can see.

Here are the init lines of OneSignal - the kOSSettingsKeyAutoPrompt works to suppress permission prompt, so init() IS called.
We prompt for permissions later on.
OneSignal.setLogLevel(6, 0);     OneSignal.init('a802af1e-327d-47c8-8aa4-5fe3de8fa35c', {       kOSSettingsKeyAutoPrompt: false,     });     OneSignal.inFocusDisplaying(0);     OneSignal.addEventListener('opened', this.onOpened)     OneSignal.addEventListener('ids', this.onIds)

@tpedersen123 When you do eventually prompt for push notifications permission from the user, does the prompt actually show up? Try uninstalling the app and reinstalling it, and make sure the push notification permission prompt actually shows up.
Try a clean install of your app, accept push notification permission, and then can you send me the entire logs from Xcode console?

I only get these after a call to
[27 <private> stream, pid: 683, url: https://onesignal.com/api/v1/apps/top-secret-key/ios_params.js, tls] cancelled

@tpedersen123  There really should be more logs than that - you are calling setLogLevel(6, 0) before calling init() right?

@Nightsd01
I tried removing kOSSettingsKeyAutoPrompt to trigger permission prompt right away.
That gave me this output
WARNING: Attempted to send an event (OneSignal-idsAvailable) when no listeners were set.
and onIds(device) was called but device was null

Using OneSignal.configure() after OneSignal.init() works for me.

Related #503

@tpedersen123 Can you please send your logs? Just for the first ~10 seconds after launching your app.
Also, can you tell me where in your project you are calling OneSignal.init() from, where you are adding OneSignal event listeners, etc?

Hi everyone - this issue has been resolved in a new PR (#512). We expect to have this merged and a new update released within the next hour or two. Thanks for your patience!

@nicastelo @tpedersen123 The new update (3.2.3) has been released and should fix this issue. Please feel free to let me know if you see this issue (or other issues) again and I'll be happy to investigate.

@Nightsd01 Everything works now - I love you, man :-)
Thx!


Databox Custom Service Integration

Crashlytics, You rule!
We really love your service and this is why I wrote an integration that pushes data to Databox so we can monitor some of the stats from CL. At Databox we love stats.
Currently we are playing only with impacted_devices_count and crashes_count numbers. Do you have any plans for official API in the future?
I would like to have some feedback on this. Also, I didn't find any coding style rules so I used rubocop & reek. Hope you don't mind.
Vlada

Deleting the branch since this is now stale.


Subscriptions Not Loading

So I've successfully loaded all other items but when I activate & load a Subscription it doesn't load.  When I try to subscribe it also says it doesn't exist.  Do apps that have Subscriptions need to be on the PlayStore to work I've followed all the steps & nothing.

Is this a known issue, when I load Subsctions in testing they don't load right away.  I just added a new Subscription item & 2 hours later it finally loaded when I navigated to my in app billing page.  Not sure why this is but nothing like this occurs with consumable/nonconsumable items.


How to change the expert channel

We need to edit the Teams ID in the configuration page and install the expert app to this Team, but the app will send message to General channel, Can we change to another channel, so it won't border all the Teams member

Hi @RiverChen1988, The Expert App will get installed in the general channel only. This is by design.

I've deployed the bot and its all working great - thanks!  I'd also like to use the Bot in a Channel other than General as well - is that on the roadmap?  Its possible to select a channel when installing the app...

Thank you for reporting this. For FAQ Plus repository, we are currently only making changes to fix critical bugs or deployment failures. Please consider forking the repository to implement your improvement and post back here if you're successful.


AbstractValidator method for populating RootContextData

It would be useful to have a method that is always run before any rules that we can use for populating the RootContextData.
Currently what I do is create fake CustomAsync rules. But there are problems with this because CustomAsync is run after all of the synchronous rules.

The name of the method doesn't matter, but internally my team calls it "ProvideEvidence".

The usual way to do this is either to pre-populate it in a ValidationContext instance and then pass this to the Validate method, or override the Validate method and do it inside here. A new method shouldn’t be needed.


[Docs] Loudness Help File

Updates the loudness help file.

@tremblap for the same reason I requested review on the learn reference for loudness I believe you are the resident expert on it :) Given our recent sync I would usually reserve learn for Ted and not double your reviews but I just can't resist picking your brain on it.


Error when building bsg_manycore_uart_responder_add_del

bsg_manycore_uart_responder.cpp: In destructor ‘{anonymous}::__bsg_manycore_uart_responder_add_del::~__bsg_manycore_uart_responder_add_del()’:
./bsg_manycore_responder.h:128:12: warning: throw will always call terminate() [-Wterminate]
      throw r;   \
            ^
bsg_manycore_uart_responder.cpp:41:1: note: in expansion of macro ‘source_responder’
 source_responder(uart_responder)
 ^~~~~~~~~~~~~~~~
./bsg_manycore_responder.h:128:12: note: in C++11 destructors default to noexcept
      throw r;   \
            ^
bsg_manycore_uart_responder.cpp:41:1: note: in expansion of macro ‘source_responder’
 source_responder(uart_responder)
 ^~~~~~~~~~~~~~~~
g++ -std=c++11 -fPIC -I/home/centos/bsg_bladerunner/aws-fpga/sdk/userspace/include -I/home/centos/bsg_bladerunner/aws-fpga/hdk/common/software/include  -I/home/centos/bsg_bladerunner/aws-fpga/SDAccel/userspace/include -I. -Wall -Werror -Wno-unused-variable -Wno-unused-function -Wno-unused-but-set-variable   -c -o bsg_manycore_print_int_responder.o bsg_manycore_print_int_responder.cpp
In file included from bsg_manycore_print_int_responder.cpp:1:0:
bsg_manycore_print_int_responder.cpp: In destructor ‘{anonymous}::__bsg_manycore_print_int_responder_add_del::~__bsg_manycore_print_int_responder_add_del()’:
./bsg_manycore_responder.h:128:12: error: throw will always call terminate() [-Werror=terminate]
      throw r;   \
            ^
bsg_manycore_print_int_responder.cpp:76:1: note: in expansion of macro ‘source_responder’
 source_responder(print_int_responder)
 ^~~~~~~~~~~~~~~~
./bsg_manycore_responder.h:128:12: note: in C++11 destructors default to noexcept
      throw r;   \
            ^
bsg_manycore_print_int_responder.cpp:76:1: note: in expansion of macro ‘source_responder’
 source_responder(print_int_responder)
 ^~~~~~~~~~~~~~~~

Co-sim or F1?

F1. Borna found it yesterday.
I believe it’s because we don’t compile in cosim with wall werror.

On Sep 13, 2019, at 5:51 AM, mrutt92<EMAIL_ADDRESS>wrote:
Co-sim or F1?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Kucoin upgraded the API key to version 2.0

Hi everyone, I'm the creator of Cassandre that uses XChange. Thanks for your wonderful work.
My testing bot uses Kucoin Sandbox and for 3 weeks, impossible to connect (401 error) with the credentials I'm using for 1 year. It still works on the Kucoin production server.
From what I read on their websites, they are changing their authentication :
To reinforce the security of the API, KuCoin upgraded the API key to version 2.0, the validation logic has also been changed. It is recommended to create and update your API key to version 2.0. The API key of version 1.0 will be still valid until May 1, 2021. Check new signing method
Do you know if Xchange supports those change ? At least, from what I understand, it can now be tested on their sandbox.

@straumat I am not aware of anyone having done the necessary code changes to change the signing method to v2, but feel free to submit a PR making these changes!

@earce yes, I'm scared the upgrade in may broke XChange, I opened an issue at kucoin to ask them more about it. Is it just a configuration change or a code change. I will keep this issue updated with their reply.

@straumat it really shouldn't be that concerning, if you change our way of creating the signature to accommodate their new v2 and it works in sandbox I would say that would a good sign.

@straumat @earce
Hey guys,
Did you try something here? Since i'm working with KuCoin I have heavy interest on this point. More or less two weeks left... Unfortunately I did not study XChange (i'm only using it..) yet and it most probably would take me too much time to understand the architecture and where to change what to adapt to the new KuCoin API. In the meantime, here a bit of information:
https://support.kucoin.plus/hc/en-us/articles/900006465403-KuCoin-API-key-upgrade-operation-guide
Apparently there's a new header (KC-API-KEY-VERSION), and a new requirement, namely to encrypt the passphrase via the API-Secret.
I could probably help, if someone guides me to the right place where these "things" are done in the code... ;-)

@goberson Hi in fact, on the sanbox, i created a new API key (what they call 2.0 API key) and the sandbox login is working now. So maybe no change is required to Kucoin. I wait for their definitive reply before closing this issue

@straumat Oh, this looks like a positive thing.  Any plans to give it a try? Knowing Kucoin, i would not be surprised if they are differences between sandbox and prod. ;-)

@goberson In fact, it's in production :)
I'm the developer of Cassandre, a spring boot starter allowing Java developer to develop their own bot. And I'm in production since more than 6 months with Kucoin

@straumat Got it. So did I understand correctly that you use the API V2 Key on production?
Or only API V1 on production and API V2 on sandbox ?

API V2 Key on sandbox & production

Okay. Thank you. Then I'll give it a try too. ;-) And so we could close this issue right?


Fix testResolveIp to make it work in some special environment

Motivation:
As "getHostName" may do a reverse name lookup and return a host name based on the system configured name lookup service, testResolveIp may fail in some special environment. See #4720
Modifications:
Use getHostAddress instead of getHostName
Result:
testResolveIp works in all environments

LGTM.

@windie Thanks! I was planning on fixing it today but you shot first.

Cherry-picked into 4.1 (9e76b5319ef9790d8bce27eacbc2aff4ba312cac) .
@windie thanks! You rock :+1: