Update Resource Health BB documentation

Maintain Resource Health BB documentation to make sure that it represents the latest status of development of the BB. In addition, before the end of development cycle, update the Resource Health BB documentation to make sure that it represents the latest status of development of the BB.

[ ] Additional request to publish preliminary plans for OpenTelemetry implementation and availability of functionality that enables other BBs to feed their own derived/specified telemetry into Resource Health BB.

Currently working on updating the design overview based on the design refinement we've done with help of the prototype the last two months.

[ ] User tutorial document (to allow early user's to work with the Resource Health BB) - Tilo
[ ] Updated reqs and use cases - Dovydas

Basic "quick start" documentation in internal MR !10.

Updated and refined requirements and use cases added in internal MR, soon to be ported to github repo (and will be published with the documentation).


possible performance reengineering

hi, WebCoder...
I spent some time tuning my highlighter (it's really fast now, a single regexp tokenizes the full text, generating the minimum number of nodes etc.) . Even so, handling typical files with around 600 lines (it's a good upper bound for me), CodeInput was not satisfactorily responsive. I've been wondering if I should implement highlighting only the visible scroll window at each input event, scheduling the full highlight with window.requestIdleCallback(). But I decided to try a hack first...  and it seems to be giving satisfactory results by now...
The hack is to perform a kind of rendering throttling. This way:
// request redraw
el.must_redraw = true;
window.requestAnimationFrame(() => {
  if (el.must_redraw) {
    el.must_redraw = false;
    ulight_redraw(el, lang);
  } /*else {
    console.log('skipped');
  } */
});

When keystrokes are too fast, requests are queued; but instead of executing them FIFO, we jump to the current version of the text, ignoring the steps along the way.
This is a delicate change, so I didn't change your update() function, asking for a pull request.
When you have time, take a look, do some tests... Tell us what you think...
best regards
andrelsm

dear WebCoder...
I decided to build on its implementation to write a similar, simplified and more responsive TextEditor class. I would like to share with you the basis of the thing, which is performing very well. In hopes that it might inspire a little re-engineering of codeInput, if you and the maintainer group deem it worthwhile.
I apologize for my coding style, I'm an old school programmer... It's worth studying window.requestAnimationFrame(), understanding the advantages of putting the highlighter there.
The few lines below provide basic editing functionality.
class TextEditor {
	#container;
	#highlighter;
	#textarea;
	#lang;
	#must_redraw;

	#update(must = false) {
		this.#highlighter.scrollTo(this.#textarea.scrollLeft, this.#textarea.scrollTop);

		if (must || this.#must_redraw) {
			this.#must_redraw = false;

			// use your highlighter...
			ulight.apply(this.#highlighter, this.#lang, this.#textarea.value);
		}

		window.requestAnimationFrame(() => {
			this.#update();
		});
	}

	get value() {
		return this.#textarea.value;
	}

	set value(text) {
		this.#textarea.value = text;

		this.#update(true);
	}

	constructor(e, lang) {
		this.#container = e.appendChild(document.createElement('div'));
		this.#highlighter = this.#container.appendChild(document.createElement('div'));
		this.#textarea = this.#container.appendChild(document.createElement('textarea'));
		this.#lang = lang;

		this.#textarea.spellcheck = false;

		this.#container.classList.add('texteditor');
		this.#highlighter.classList.add('ulight');

		this.#textarea.addEventListener('input', () => {
			this.#must_redraw = true;
		});
	}
}

my best regards
andrelsm

Thank you so much! Improving performance should definitely be focused on more here in code-input than it has been in the past. Thank you again for all your time and work with this project, and please let me know if you have any more suggestions on how to improve code-input. I can see that responsiveness was one large factor in your desire to reduce complexity - were there any others?

Another aspect to improve performance in:

The reason why CodeMirror, Ace, Monaco, and the like can work faster even though they have bigger source code is because they work on the stream. Only parts that are in the view will be highlighted, any text below and above the scroll bar will be ignored.
(Taufik Nurrohman, Apr 2021)

I believe this will be difficult to implement with HLJS/Prism.js but is quite important - if the mainstream highlighters don't support it it should still be easy to implement with custom highlighting templates.

Certainly the definitive solution, in a custom highlighter, would be to generate highlight nodes only for the visible window (scroll window).
The suggestion I made in this code works well for a generic highlighter and brings good gains in performance and simplicity. It's serving me well for now.
When you have some time, take a look at this code, do some tests, see if it's worth using this idea of the update happening in the window.requestAnimationFrame() callback.
PS: I managed to have plugins, using the class prototype. crtl-G / indent are working fine.
[ ] andrelsm

I've started simplifying the codebase using requestAnimationFrame and have moved the scrolling synchronisation to be CSS' responsibility, and it appears to be working well.

My solution includes basically this wrapper to greatly boost its performance...
var updateBurst=0;
function updateCode() {
	if(updateBurst==1)return;
	updateBurst=1;
	setTimeout(()=>{
		updateBurst=0;
                ..... regular code is here.....
	},1);
};

For larger scripts the editor still runs stable even if i type fast (e.g. holding space/enter/tab). It may delay the display of a single or even two characters, but it will not cause the editor to get completely stucked because of multiple parallel code updates and prism renderings.
Cheers, Kai

Basically the same idea of a "rendering throttoling".  With a few lines more than my previous example, for attach plugins registered in TextEditor.prototype.plugins... I have a full functional editor which performs pretty well. So I shared the idea....

I've started simplifying the codebase using requestAnimationFrame and have moved the scrolling synchronisation to be CSS' responsibility, and it appears to be working well.

great!

Using bounding boxes, editing elements inside the result element directly, and only highlighting some of the top-level tokens chosen by what is visible rather than all of them on every keystroke. I think it will be quite easy to make the Prism/highlight.js much faster optionally with this - what do you think?

the main idea behind CodeInput remains the same, right?
I really liked the idea of mirroring a textarea. It allows a class with as little code as TextEditor (above) to offer basic editing (and with a few more lines, plugins). And performing well... Or "not so bad", at least.
Using generic highlighters as Prism/highlight.js is a very nice fetaure, too.
Highlighting is context-dependent. If, on the one hand, it is only affected by the text starting from the cursor, on the other hand, it depends on the previous context. For example, you can have the beginning of a multi-line comment on the first line above the visible region. Keeping with the current CodeInput structure, you could perhaps ask highlighting of [1, l] lines (l is the last visible line in the scroll window -- not difficult to determine from the scrollTop, clientHeight and lineHeight). And, in a post-highlighting step, replace all nodes in [1, f-1] (f is the first line visible in the scroll window) by "\n" textNodes. And request a window.requestIdleCallback() for full highlighting. (That way no highlighting while scrolling will be needed). But... I really don't know if all this hocus pocus will perform better than just drawing the entire text... Need to test and measure...
Did I understand your ideas correctly?
regards andrelsm

@andrelsm You could also simplify partial renderings by empty the currently hidden lines while copying the code from edit to display
But as you pointed out, the context may become lost if you highlight only those currently visible lines, without using a language specific detection where partially highlighting is supported and where not.
BTW: I performance optimized the prism TCL language definition (this is the language used in my solution). I dont know how great HTML/JScript language definitions are . But for TCL i was able to speed up renderings of TCL scripts by a factor of 4 while also improving the detection rate. Watch closely to the normalized RegEx syntax, its has become a huge decision tree...
https://github.com/KaiWilke/F5-PrismJS-iRule-Language-Definition/blob/main/iRuleLanguage.js
Cheers, Kai

@andrelsm the main concept will definitely remain the same - additionally I believe that in Prism.js at least the top-level tokens are free of context so can be highlighted like a normal code block. The yellow token below is a top-level token. By detecting how the selected region in the textarea changes and then highlighting only certain top-level tokens I will add partial highlighting then test whether it is faster than the old solution.

looking forward for the tests results...

I have made a sort-of-highlighter-independent method for partial highlighting which is in the partial-highlighting-optimisation branch and works with both Prism.js and highlight.js. However, it does not display significant advantages over your optimisations and still has a few bugs so I will treat it as a work-in-progress for now.

I aim to get the main performance-improvements released soon, once I have found a Firefox-compatible Ctrl+F fix.

dear friend, good morning,
Thank you so much for your efforts.
After thinking a little about the topic, I come to the following conclusions:

a selective highlight should be the responsibility of the highlighter, there is probably no agnostic means of doing this efficiently.

CodeInput is a lightweight solution in principle, allowing the choice of the user's preferred highlighter (or even a customized one). I think the general optimization options are important and welcome, but it might be better to assume that it has performance limitations for large files. Projects that need to handle large files should rely other already established solutions, such as the Chrome AceArea addon (2.2Mbytes footprint) etc.

my very best regards
[ ] andrelsm


tts vol command does not work when using headphone jack (audio device 0)

Describe the bug
When controlling the audio via the headphone jack. Audio volume control does not appear to work. Running .tts vol 50 does not do anything. However, entering amixer cset numid=1 80% or 50% in the terminal will change the volume
To Reproduce
Steps to reproduce the behavior:

Set the speaker_num in the controller.conf to 0,0.
Plug in speakers to the headphone jack
Run the .tts vol 50, then .tts vol 80. Notice no change

Expected behavior
Volume level is adjustable
Screenshots
n/a
Logs
n/a
Configurations

Raspberry Pi 3a+

# ALSA HW number for your playback device
# For Tellys this is 2.
# If you have trouble with the playback device changing hardware numbers,
# use the audio device name. Otherwise, leave it blank.
speaker_num=0,0
speaker_device=

Not quite sure how we should implement this in the code, as the alsa HW number is 0, but the command id is 1 for amixer cset numid=1 80%. Not sure how USB speakers handle this, or what they appear as.

Yeah, one command fits all volume control has proven to be a constant issue.
ALSA device number, subdevice number and card control number are all different things. Your amixer command is running against the default ALSA device, which is probably 0.
Out of curiosity, what does the output of amixer content show?

amixer gives
Simple mixer control 'Headphone',0
  Capabilities: pvolume pvolume-joined pswitch pswitch-joined
  Playback channels: Mono
  Limits: Playback -10239 - 400
  Mono: Playback -663 [90%] [-6.63dB] [on]

amixer content gives
amixer: Unknown command 'content'...

amixer contents gives
numid=2,iface=MIXER,name='Headphone Playback Switch'
  ; type=BOOLEAN,access=rw------,values=1
  : values=on
numid=1,iface=MIXER,name='Headphone Playback Volume'
  ; type=INTEGER,access=rw---R--,values=1,min=-10239,max=400,step=0
  : values=-663
  | dBscale-min=-102.39dB,step=0.01dB,mute=1

Try running this amixer -c 0 set PCM 50% Headphone 50% which should set your tts to 50% without breaking the existing supported hardware command... in theory.... since amixer seems to ignore channels it can't find.


Update Spyder link, description and related distribution info on Topical Software and Install pages

As it says on the tin, this PR does a few simple but related things, split into small, focused commits so it may be easily examined and (if necessary) changed or even reverted:
On the Topical Software Page:

Updates the very outdated Spyder link to point to the IDE's current website
Updates the description of the IDE to better describe its current capabilities and integration into the NumPy/SciPy/Matplotlib/Pandas etc workflow
Updates/removes the highly outdated parenthetical around its existing reference in the Python(x, y) distribution
Adds the WinPython distribution (which also includes Spyder) to the page with a short description to be consistent with its existing inclusion on the Install page, given it is very similar to Python(x, y) but much more up to date/maintained, although currently Windows-only

On the Install page:

Makes the existing Spyder IDE reference in Python(x, y) into a link, to make clear what it is referring to for unfamiliar users
Improves the WinPython description to be consistent with the Python(x, y), including a reference to Spyder (unlinked)

Let me know if you'd like me to make any further changes, or even revert something. I didn't see a contributing guide, so hopefully this is okay. Thanks!

Also, for reference, part of spyder-ide/spyder-docs#39

@ilayn Thanks for your feedback. I rewrote Python(x, y) and WinPython sections in both Topical Software and Installation to hopefully address both of your concerns.

I think this is much better and can go in. Thanks for the fix. Unlike the main repository, the website changes has to be pushed manually hence pinging @pv, @rgommers to consider this.

LGTM, merged. Thanks @CAM-Gerlach and @ilayn

Thanks for the merge @rgommers !


[$250] Track expense - System message appears on wrong LHN report after changing merchant or desc

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.77-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Navigate to staging.new.expensify.com
Open personal report
Create a tracked expense
Update either the description or the merchant of the tracked expense

Expected Result:
System message indicating merchant or description being updated gets displayed on LHN for the combined report of the tracked expense only
Actual Result:
System message indicating merchant or description being updated is shown on the LHN of the personal space report
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/b4b095fa-7c13-433e-b93e-d4955399a2e4
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e89fac46add8bf9d
Upwork Job ID:<PHONE_NUMBER>975722496
Last Price Increase: 2024-06-03

Issue OwnerCurrent Issue Owner: @allroundexperts

We think that this bug might be related to #vip-vsp

@johncschuster  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
System message (like changing of merchant) appears as subtitle of self DM in LHN. It should only appear as last message in the transaction thread and not in the selfDM in LHN.
What is the root cause of that problem?
This bug happens only when there is only one transaction in the self DM report.
Here in OptionsListUtils
https://github.com/Expensify/App/blob/0cb2dc052f01b6a024ac872ad8bf628159fe7873/src/libs/OptionsListUtils.ts#L291-L299
we merge the transaction thread report actions into IOU report actions if it is oneTransactionThreadReport so the last transaction of modified merchant is added into the report actions and set as the lastReportAction. In the present case of self DM, the lastMessage of modifying merchant appears on the LHN.
But this merging of transaction thread report actions for single transaction reports is not applicable for self DM because unlike other reports the tracked expenses are shown as separate report actions here instead of a single report preview merging all IOUs as shown in other reports.
Additionally, we don't see this report action of modifying merchant in the self DM report screen though the transaction report actions are added here as well
https://github.com/Expensify/App/blob/0cb2dc052f01b6a024ac872ad8bf628159fe7873/src/pages/home/report/ReportActionsView.tsx#L160
with transactionThreadReportActions obtained from onyx with the transactionThreadReportID passed from ReportScreen
https://github.com/Expensify/App/blob/0cb2dc052f01b6a024ac872ad8bf628159fe7873/src/pages/home/ReportScreen.tsx#L331-L334
This is because there is a check here when getting the getOneTransactionThreadReportID
https://github.com/Expensify/App/blob/0cb2dc052f01b6a024ac872ad8bf628159fe7873/src/libs/ReportActionsUtils.ts#L878-L887
and it returns null when the skipReportTypeCheck is passed as false as seen here for track expenses because it is not one of the actions being checked there
https://github.com/Expensify/App/blob/0cb2dc052f01b6a024ac872ad8bf628159fe7873/src/pages/home/ReportScreen.tsx#L332
whereas it is passed as true here
https://github.com/Expensify/App/blob/0cb2dc052f01b6a024ac872ad8bf628159fe7873/src/libs/OptionsListUtils.ts#L293
which skips the check. If the check is not skipped it returns null and LHN shows correct message.
What changes do you think we should make in order to solve the problem?
We can check if the report is self DM and pass the boolean here
https://github.com/Expensify/App/blob/0cb2dc052f01b6a024ac872ad8bf628159fe7873/src/libs/OptionsListUtils.ts#L293
like
const isSelfDM = ReportUtils.isSelfDM(ReportUtils.getReport(reportID));

            // If the report is a one-transaction report and has , we need to return the combined reportActions so that the LHN can display modifications
            // to the transaction thread or the report itself
            const transactionThreadReportID = ReportActionUtils.getOneTransactionThreadReportID(reportID, actions[reportActions[0]], !isSelfDM);

What alternative solutions did you explore? (Optional)
I see this skip of check added here in #39472 for showing correct messages in LHN for edge cases. I changed the skipcheck to false in OptionsListUtils directly (irrespective of whether it is a self DM or not) and the tests succeeded fine. So, we might consider changing this
https://github.com/Expensify/App/blob/0cb2dc052f01b6a024ac872ad8bf628159fe7873/src/libs/OptionsListUtils.ts#L293
simply to
const transactionThreadReportID = ReportActionUtils.getOneTransactionThreadReportID(reportID, actions[reportActions[0]], false);

Reviewing today.

@c3024's proposal looks good to me. I would suggest to go with the main proposal since its less likely to cause a regression.
🎀 👀 🎀 C+ reviewed

I see this skip of check added here in https://github.com/Expensify/App/pull/39472 for showing correct messages in LHN for edge cases. I changed the skipcheck to false in OptionsListUtils directly (irrespective of whether it is a self DM or not) and the tests succeeded fine. So, we might consider changing this

I just double-checked this, and the behavior without the skipReportType check is fine for me as well. Even though I agree with @allroundexperts that it's more likely to cause regressions, I think we should use the alternative proposal, but go one step further and remove the skipReportTypeCheck altogether since it's apparently unnecessary now.
@allroundexperts @c3024 how does that sound to you?

Yes, let's remove it. I don't think anything will be broken.

@allroundexperts PR ready for review!

@johncschuster This was deployed to production 4 days ago but automation failed here.

@johncschuster Can you please complete the payment here? This was deployed to production 10 days ago. Thanks!

Contributor: @c3024 paid $250 via Upwork
Contributor+: @allroundexperts due $250 via NewDot
@allroundexperts can you fill out the BZ checklist plzzzz
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@] Determine if we should create a regression test for this bug.
[ ] [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@BZ] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[ ]

On to the checklist today.

Checklist

https://github.com/Expensify/App/pull/36934
The PR author (@NikkiWines) is aware of the bug already.
N/A
A regression test would be helpful.

Regression test

Login to any account and open the chat with yourself (personal report)
Create a tracked expense
Update either the description or the merchant of the tracked expense

Verify that the system message indicating merchant or description being updated gets displayed on LHN for the combined report of the tracked expense only.
Do we 👍 or 👎 ?

Thanks @allroundexperts

https://github.com/Expensify/Expensify/issues/409882

$250 approved for @allroundexperts


Container IPs leak out to LAN

We are experiencing an issue where the container IPs are leaking out over onto the LAN.
This was reported by a customer here https://github.com/NebraLtd/helium-miner-software/issues/99 which contains more details.
Is this a known issue? Is there any fix for it?
Possibly related to...
https://github.com/docker/for-linux/issues/1126

@shawaj I've setup a device to capture it's network traffic, to see if I can see any packets using the non-masqueraded IPs
I'm just using simple http server in the container, is the helium-miner doing anything interesting when it comes to network activity?
if not I would let my setup run for a while to see if it happens by itself, right now I don't really have a clue as to what could be the cause for this.
On your end, did you see any kind of pattern to the devices this happens on?

Any luck with debugging this? I'm still having this issue on a regular basis.

@shawaj I've set up a device to capture its network traffic, to see if I can see any packets using the non-masqueraded IPs
I'm just using a simple http server in the container, is the helium-miner doing anything interesting when it comes to network activity?
if not I would let my setup run for a while to see if it happens by itself, right now I don't really have a clue as to what could be the cause for this.
On your end, did you see any kind of pattern to the devices this happens on?

@robertgzr as far as I know, it happens on every device in our fleet.
The helium miner container does do some interesting things to try and get around double-NAT and similar stuff using libp2p https://github.com/helium/erlang-libp2p


Isolate curl requests and add unit tests

Should make the review of #202 easier as we would have unit tests on the curl requests
Each commit can be reviewed independently.

Can I merge this one?


Customizing Canadidate Applications by Source

I'm not sure if this has been dealt with or not (couldn't find anything on it), but we are looking to be able to identify the source of all applications through the career portal. Currently all applications are marked as Corporate Career Portal as source regardless which job board they have come from.

Heya Royce, this is something that can be handled within the default career portal.   If the url has a source parameter added to it (?source=jobBoard) you are able to define the source of the application.   This source will need to be applied by the job boards that you are using.
Please let me know if you have any questions

Thank you!  Figured this already existed but couldn't find it to save me soul.
Cheers!


Fix StompSubframeDecoder.redHeaders no any notification when parsed l…

…ine that contains multiple colon, close #7083
Added validateHeaders flag, removed unnecessary code.

Added validateHeaders flag, removed unnecessary code.

@normanmaurer сorrected according to comments

Fix a few more comments

Squashed and cherry-picked into 4.1 (cc336ef2f8).
@amizurov thanks!


Enketo Preview button

Hi @matthew-white,
It was nice meeting you at the Convening! I'm overdue to contribute a very basic, proof-of-concept integration with Enketo—just for previewing forms—and was wondering what you'd think about me adding a "Preview" button next to the existing "View XML" button. It would use target="_blank" just as "View XML" does.

i'd probably put it to the left of the View button. will it launch the preview in a new tab/window?

:smile:
great! what do you think of that eye? i pulled it from icomoon but feel just so-so about it.

we use the font awesome v4.7.0 set for everything. i'll leave @matthew-white to fill in details about how he actually does the exporting and such.

ok. i understood it was from icomoon due to
https://github.com/opendatakit/central-frontend/blob/6fbe3ec8766999c31f1603cfc6bc11338f0c176e/src/components/form/overview/right-now.vue#L24
and
https://github.com/opendatakit/central-frontend/blob/6fbe3ec8766999c31f1603cfc6bc11338f0c176e/src/assets/css/icomoon.css#L96-L98
for Matt's reference, i was able to use https://icomoon.io/app to import the icomoon.json file, add the eye glyph, and export sensible-looking changes to

public/fonts/icomoon.svg
public/fonts/icomoon.ttf
public/fonts/icomoon.woff
src/assets/css/icomoon.css

i got stuck trying to update icomoon.json itself, though: anything i saved from the icomoon app had a disconcertingly large diff with what's currently in this repo.

Hi @jnm! I'm excited to see you in the Frontend repo. :) Sorry for the delay in commenting on this.
I often end up having a large diff with icomoon.json — I'm not sure why. For example, if you take a look at ebaaeb533209864d949960c3e83a980c25d49c0c, you'll see that properties like id, setId, setIdx, and iconIdx changed for many icons. Based on these properties, I suspect that there's a way to order the icons or icon sets within IcoMoon to minimize the diff, but I have yet to figure it out. As long as it's just properties like these, I wouldn't worry about it!
Let me know if you have any other questions about Frontend!


Investigate KMG Prestige listing data

We want to look at the xml files they sent us and answer the following:

Is there availability data missing from the files that we would need to be able to display whats available for a listing?
Is there data that is in the xml file that we want for the website that we currently don't have in our DB?
Would it be possible to ingest this data in our database?

This was addressed in #799.


revert grpc breaking netty tls change

see #197 and #199
the akka-grpc 2.1.6 breakage was traced back to this OSS akka-grpc 2.1.6 change (https://github.com/akka/akka-grpc/pull/1649) and reverted here

adding @mkurz too
Since we are now in license hell due to #197, I think the best starting place is to revert the original change that caused the issue (that was made before Pekko forked and we are safe to reference that change since it is an OSS friendly chane).
We can build on top of this but this might a starting point.

this seems to fix the play-grpc issue - https://github.com/playframework/play-grpc/issues/468#issuecomment-1869472024

Thanks for fixing this over the holidays! I see you just released v1.0.2, so I released play-grpc 0.12.1 as well:

https://github.com/playframework/play-grpc/releases/tag/0.12.1


'airmapcoordinate.h file not found' but can jump to definition

Is this a bug report?
No
Have you read the Installation Instructions?
Yes
Environment
react-native: 0.55.4
react: 16.3.1
react-native-maps: 0.23.0
Target Platform: iOS - 12 /iPhone 7+, using GoogleMaps
XCode : 10
Steps to Reproduce

Do the installation based on installation guide.
When starting run on XCode, error message appeared, 'airmapcoordinate.h file not found'.
Search on https://github.com/react-native-community/react-native-maps/issues/458, the problem can't be solved although I've updated the path.
I found #import "airmapcoordinate.h" can be "jump to definition" but system can't find that file.

Expected Behavior
Message Error 'airmapcoordinate.h file not found' on XCode has been solved.
Actual Behavior
Did I miss one step before?

Please make sure you have the library added to your projects header search paths.

@dominikuswilly please make sure you have the react native maps pods in place for iOS if you follow the iOS setup instructions found in installation
you should not have this error


fred's version

would be great if you can modify your copy to not show there is an update, which is pointing to fred's broken updated version. I much prefer this sparticled version.

Happy to accept PRs for any fixes

I changed it so the updates are checked against this repo, and tagged a release so we can have updates handled correctly! :)


Test KubeOne Release 1.9 - Cluster Upgrading (External, Cilium) on AWS

This is a testing ticket for the upcoming KubeOne release.
This issue has been automatically generated.
### Ubuntu
- [x] `/test pull-kubeone-e2e-aws-default-stable-upgrade-cilium-containerd-external-from-v1.29-to-v1.30`
- [x] `/test pull-kubeone-e2e-aws-default-stable-upgrade-cilium-containerd-external-from-v1.30-to-v1.31`

Tested in #3449, passing! ✅
/close


Module not found: Can't resolve './Archive'

I have tried llib in test nextjs project and after install got an error

"next": "12.2.2",
"react": "18.2.0",
node -v : v14.18.2

removing an second attempt to install solves


Fix stall on reconnecting ssh port forwarding

BUG=None
TEST=reboot DUT while lium chroot --dut ${DUT}
TEST=and the connection was re-established.

I found that I broke the background ssh port forwarding in the previous commit (sorry...) so this is a fix for it. Please take a look!


tt-torch model test parser

@vmilosevic / @AleksKnezevic / @ddilbazTT / @uazizTT

No issues from my side

@nsmithtt  The error you see in the workflow is because you are making a PR from the fork, and it doesn't have permission to add comments to PR to show the report.
We can ignore this, easiest way to get around this is by adding "continue-on-error: true" to "Show reports" step
File .github/workflows/test_collect_data_action.yml Line 37 add
continue-on-error: true


bypass data file based on filter and column statistics

What changes were proposed in this pull request?
Bypass file reading by looking at column statistics and pushed down filter.
How was this patch tested?
added a suite

Just FYI.
You can use below code if it helps.
minMax = getStatsFromSchema(schema).foreach(_.setMinMaxFromBytes(min, max))
minMax(i).getMin()

Thanks Linhong, I'll update this soon.

@linhong-intel , by using the method you mentioned, StringType data will also be casted to Binary

I see. then your current is better.


Template issue after upgrade to 2.1

Getting a strange error after upgrading to .Net Core 2.1 I initially upgraded the project my self, and then saw you already went to the effort, and pulled the latest version.
When going to any of the create pages I get the following error:

InvalidOperationException: Templates can be used only with field access, property access, single-dimension array index, or single-parameter custom indexer expressions.
Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.ExpressionMetadataProvider.FromLambdaExpression<TModel, TResult>(Expression<Func<TModel, TResult>> expression, ViewDataDictionary viewData, IModelMetadataProvider metadataProvider)

Have you seen this before?

Yeah.. The break happens when upgrading to HtmlTags due to the new model metadata support.
Looks like this is the issue: https://github.com/aspnet/Mvc/issues/7008
When it generates the expression for anything other than strings it does a Convert(Field, Object)

This is still an issue on 2.0 using HtmlTags 7. Initially I had thought it was due to the 2.1 upgrade.
I'll keep digging and see if I can help find a solution.

The fix was pretty simple when I understood the problem :)


bump containerd to v1.5.9

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 7.473%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
126

Relevant Lines:
1686

💛  - Coveralls


esp32

hi! thanks for the code,

I wonder what would be the easier way to remove the sd support and just print from memory in an esp32 which has more flash space. What do you think it would be the easier hack? have the image as String?

do you have the small "hello" banner.txt file to test?

Hello. Will be able to answer mire precisely by end of the week. I have no access to any computer now. But in brief the best way is to use the serial and do everything from outside in an app for example (under dev). And yes I have the data for the banner but not accessible right now.

Thanks! I will try :)

Here a generic input/output interface for the Printer. It goes with an Android app that will be published soon.
https://github.com/Raphael-Boichot/The-Arduino-SD-Game-Boy-Printer/tree/master/Research

Awesome! I will test during the week

Question, since the only thing it prints is 01 maybe the best approach would be to have some type of command line? i.e.
init
line<PHONE_NUMBER>110101011110 (or maybe as hex)
end

I am thinking on implementing this to output photos from a camera with the esp :D

The printer is able to print 4 shades of gray (unlike most thermal printer). You have to use the Game Boy tile format to send your data, no choice. But what you want to do is definitely doable. If you are more interested in general with the printer and the camera, you can join the Game Boy Camera Club (Discord). There are dedicated threads with technical discussions about the printer or ESP/Pico devices. It may be simplier to exchange technical data too.


Modifications with respect to age for PG12.

heap_open -> table_open
heap_close -> table_close
change function return type to void from Oid wherever required

@MuhammadTahaNaveed Other than the minor cosmetic adjustments above, the PR builds locally and looks good.

@MuhammadTahaNaveed Other than the minor cosmetic adjustments above, the PR builds locally and looks good.

I have fixed them.

@MuhammadTahaNaveed Good job!  Go ahead and squash your commit into the original commit and I'll merge it in.
Thanks! I have squashed it.


Development guidelines

Dear friends,
I am new to the community and need more "input" how to compile the plugins.

The workflow of the plugins repository is quite similar to the core repository, although the plugins have one source directory per plugin, while the core can be thought of a lone plugin.
Commits for individual plugins should therefore be split into individual chunks for each src/ directory so that they can be reviewed separately and also be applied remotely.
When an OPNsense release is built, the plugins are automatically added to the final package repository.

What is the recommended approach:

install Hardened BSD and compile plugins and then move plugins to a 17.7 firewall.
or
Recompile OPNsense from scratch using git and use the target build as development platform. Is this what is meant in the README?

I am also scratching Linux off and will run FreeBSD alone. Can I run the development environment in a jail or should I prefer a XEN quest? Is it preferable to install Hardened BSD?
Sorry for those newbee questions, it is only a few days since i decided to migrate all to FreeBSD or HardenedBSD. All comments are welcome.
Kind regards,

Hi @ffries,
Here's the how to for plugins and development in general:
https://docs.opnsense.org/development/examples/helloworld.html
https://docs.opnsense.org/development/guidelines/basics.html
https://docs.opnsense.org/development/how-tos/api.html
There is also the development workflow document, which is severely out of date, but still useful:
https://docs.opnsense.org/development/workflow.html
In essence, you only need a working OPNsense installation. A VM works too, you can even do a WAN-only setup.
After that, just run this...
opnsense-code tools plugins
cd /usr/plugins/your/plugin
make package
pkg add work/pkg/*.txz
From there, the plugin is installed by source. When you make modification to a plugin in its own src/ directory, you only need to run "make upgrade" to install these changes in the system.
There is also the "make collect" target which will copy changes from within /usr/local for your plugin.
The paths are the same in plugins and the system. The only difference is ./src/ <-> /usr/local/

Thanks, this was a fast answer!
Do you recommend HardenedBSD or FreeBSD?

Neither, use the latest OPNsense image unless you want to build everything from source, in that case the build tools document applies, it suggests FreeBSD 11.0 at this point. :)
https://github.com/opnsense/tools#setting-up-a-build-system

Thanks. I will probably try to rebuild.

ok, if you need help just let me know :)
ps: please close the issue when you think this can be closed
Cheers,
Franco


uses babel 2.4.0

its forcing me to use babel 2.4.0 even if i already installed latest version of babel(2.6.0)

This has been released as 0.4.0. LMK if you have any issues, I'm terrible at PyPi.


updated container tutorial doc

@vgamayunov is this still WIP or do you need a review ?

@vgamayunov is this still WIP or do you need a review ?

I am done for now, change mainly to be consistent with the latest changes in the code


Allow to continue lines

Fixes https://github.com/rednex/rgbds/issues/231
The PR is missing updates in the documentation, I'll do that over the next few days.
In short, "\" can be used now to continue a line, like with C preprocessor macros. I've also added a few fixes so that this can be done in regular code and in list of macro arguments.
PrintMacro : MACRO
    PRINTT \1
ENDM

    PrintMacro STRCAT(\"Hello\"\,  \
                      \" world\\n\")

There's another change that I'm not sure about. I've made it possible to concatenate strings by just placing them next to each other. The following two lines are equivalent:
    DB "Hello world"
    DB "Hello " "world"

I'm not sure about what others may think about this, it can already be done by using STRCAT, and I'm not sure about how safe this is. I'd rather just remove it, to be honest. It doesn't even work when one of the strings is only one character long.

I think it's kinda a shame that rgbasm can't just do 'the right thing' and figure out when more arguments are needed (e.g. when trailing commas are spotted), but hey, I've probably been spoiled by modern high-level programming languages lately stuck_out_tongue

It is a shame, but that would mean a huge change in the parser... Right now it only knows about lines of code. Actually, the change of this PR is just a cheat to make the parser believe there isn't a newline character after the "". :P

As for this PR, I think this seems quite sensible. I'm not sure how necessary the "string" "concatenation" syntax is either (hence my comment above), but I'm happy to be overruled. I'll hold off on approving this until the documentation has been updated!

As I've said in the comment in the commit, that is going away, I've been thinking about it today and I don't think it can actually be done without changing the syntax of one character long strings, so there's no point.

I've removed the concatenation syntax and changed the error message. Still missing the documentation, though.

Documentation added.

No problem! :)


all: coverage aggregation

The plan is to:

[x] land #4904
[x] land #4804 changes
[x] enable containers as a CloudRun env #https://github.com/google/syzkaller/pull/4878
[x] enable coverage aggregation pipelines for other namespaces (Q2)
[x] #4937
[x] make target project configurable #4980
[x] #4979  schedule bigquery->covermerger->spanner events (CloudRun or Batch)
[x] kernel filesystem coverage visualization for the upstream namespace
[x] extract db init code from sh file
[x] [done partially]rewrite .sh code in golang. The problems are very hard to debug in .sh. #5172
[x] file level coverage visualization by ./tools/syz-cover. #5173
[x] quarter long aggregations. I'll probably change Coverage->Total. 1 column per quarter.
[x] show details on hover (instrumented and covered points, frame detail)
[x] month long subsystems coverage aggregations to track the coverage improvement projects progress.
[ ] file level coverage visualization as a web tool
[ ] coverage gaps highlighted. Current version shows the status, but it has no idea where the target bar is. We can for sure hide files with coverage > XX%(50, 70, 90?).
[ ] show total coverage for subsystems (/coverage?sybsystem=...)
[ ] Markers attached to some code lines we want to be reachable by fuzzer. We can use them to track the CVE points reachability by fuzzer.
[ ] add integration tests and high level documentation
[ ] add day-to-day and file-to-file coverage comparison

Hi @novitoll .
Q3 labels were used to say "not in Q2".

is this plan up-to-date?

This plan is arguable because we don't have consensus about what features are needed. But it reflects my up-to-day perception.

should be resolved in sequence?

The bullets are independent enough. My goal is to stabilize the numbers and make most month-month coverage diffs explainable.

I could've jumped in to contribute.

We'll surprise each other periodically w/o coordination. I'm changing the DB and drop all the records periodically.
What bullet do you want to focus on? And feel free to add the new ideas.
In a month we'll have a 2025 plan if you're curious about the team focus points. I guess we can share it.

Thanks.

What bullet do you want to focus on? And feel free to add the new ideas.

[ ] coverage gaps highlighted. Current version shows the status, but it has no idea where the target bar is. We can for sure hide files with coverage > XX%(50, 70, 90?).

I don't understand Current version shows the status, but it has no idea where the target bar is part here. For /graph/coverage_heatmap, /graph/coverage_subsystems_heatmap URIs we can highlight (since it's called heatmap) each coverage % with distinguished color. Like a gradient from green to red with 100 - 0% respectfully, therefore hiding files with coverage > XX% would be irrelevant (why do we want to hide it?)

from user standpoint, I really like this visualization with each file's coverage with source code. If it's possible to add a similar visualization to coverage_heatmap, coverage_subsystems_heatmap pages as well as they have a similar % coverage, but different fuzzing instance base. Coverage with source code page is rendered in https://storage.googleapis.com/syzbot-assets, whereas coverage_heatmap, coverage_subsystems_heatmap on https://syzkaller.appspot.com/, perhaps, there are different storage infrastructure that I am not aware of, making this change complicated (?). But the general idea, is to have similar UX of coverage for coverage per instance, coverage per subsystem etc.

does it make sense to make a visualization of "mainline development vs syzbot coverage rate" to understand if syzbot is able to catch up with new changes in mainline while fuzzing the rest of previous codebase? Like I'm watching current mm subsystem coverage 58% 59% 59% 60% 59% from 2024-04-30 to 2024-09-30 and trying to understand:

syzbot is able to catch up with new mm patches during 5 months at 59% on average?
mm/z3fold.c, for example, has 0% 0% 0% 71% 72%. (In ci-upstream-kasan-gce-selinux-root instance it shows currently 38%). Does it mean that the last 2 months (71% for August, 72% for September) have coverage from syzbot where in May until July, syzbot didn't have a chance to cover it due to known reasons?

This rate indirectly is related to this task:

[ ] add day-to-day and file-to-file coverage comparison

In a month we'll have a 2025 plan if you're curious about the team focus points. I guess we can share it.

That would be helpful as I'd like to understand the tasks priority, please keep me notified, I appreciate it. I'm going over this bug list at the moment for the contribution sake.

syzbot is able to catch up with new mm patches during 5 months at 59% on average?

Yes. It is my understanding.

mm/z3fold.c, for example, has 0% 0% 0% 71% 72%. (In ci-upstream-kasan-gce-selinux-root instance it shows currently 38%). Does it mean that the last 2 months (71% for August, 72% for September) have coverage from syzbot where in May until July, syzbot didn't have a chance to cover it due to known reasons?mm/z3fold.c, for example, has 0% 0% 0% 71% 72%. (In ci-upstream-kasan-gce-selinux-root instance it shows currently 38%). Does it mean that the last 2 months (71% for August, 72% for September) have coverage from syzbot where in May until July, syzbot didn't have a chance to cover it due to known reasons?

Yes. We're receiving fuzzing signals from mm/z3fold.c starting 2024-08-30. @ramosian-glider suspects it is because upstream made this feature default.

But the general idea, is to have similar UX of coverage for coverage per instance, coverage per subsystem etc.

That's what I'm trying to do. File level visualization is not that easy because we don't store the all file version but I'm working on it. See #5293 .

Current version shows the status, but it has no idea where the target bar is.

Every customer has its own understanding of "good coverage". I'd like to let customers filter out "well covered" parts and be able to see only "bad covered".
The "well covered" criteria may be:

It is stable. (deviation not more than x%)
Coverage was higher than x%.
Maybe other criteria.

I called these criteria combination a "bar".


Fix markdown link in README.md

But why?

Links appears to be working fine

It seems it should look like this, i.e. picture?


Whirlpool version

If I may ask, what version of Whirlpool client/server does Sparrow wallet use?

Currently, the Whirlpool client is version 1.0.6.


A first pass over m3d

Adjusts nw4r/g3d includes to work like the others
Implements some of the known m3d symbols and classes
Cautiously matches our first dAcObjBase subclasses in RELs that use some m3d stuff

Only a couple functions left in m_bmdl.cpp and m_bline.cpp. Ill get to bline later, but bmdl may need to wait until more information of the nw4r and egg code it references


UP needs to support resending of data per OO process

User Story:
As an administrator, I want the UP to allow for retransmission of reports, so I can resend data to a STLT after some failure.
Description/Use Case
OO has a process to resend data.  Currently that process only applies to the COVID/Monkeypox pipeline, but it needs to apply any pipeline. We need to research this process and identify what work we need to do to support that process if any.
Risks/Impacts/Considerations

There is a possibility the process/software is COVID pipeline specific and we may need to expand that software instead of the UP.

Dev Notes:

Contact OO for a demo and tour of the code.
The current process seems inefficient, so there is a possibility of making improvements. However, care must taken to make sure we support ONE process for any pipeline.

Acceptance Criteria

Document the resend process or link to an existing document.
Document the work needed to be able to include the UP in the resend process.
Brief the team with the findings.
Generate any tickets for work approved by the team.

Brain dump: O&O uses a combination of Pager Duty and the Last Mile feature to get notified about last mile failures and keep tabs on the status of whether a resend has been attempted.
The query that pulls the reports that have failed and need to be resent (for UI linked above) pulls from the actions and reports table. This works the same for both the UP and the legacy covid pipelines. There are no changes required coming out of this research. The current resend process will be sufficient for the new pipeline.
Query defined here for anyone else that needs to see it: prime-router/src/main/resources/db/migration/V50__add_send_failure_function.sql


Error When installing on MacOSX

Hello,
I was trying to install DSP on my Mac and I have the following error during installation :
npm  start

<EMAIL_ADDRESS>start
node index.js | node_modules/.bin/bunyan

[2021-03-21T10:10:36.639Z]  INFO: DockerSecurityPlayground/26249 on MacBook-Pro-de-Rigotto.local: Checking docker, docker-compose and git installed, and docker is running ...
[2021-03-21T10:10:36.683Z]  INFO: DockerSecurityPlayground/26249 on MacBook-Pro-de-Rigotto.local: Server listening on <IP_ADDRESS>:18181
[2021-03-21T10:10:46.756Z]  INFO: DockerSecurityPlayground/26249 on MacBook-Pro-de-Rigotto.local: Create configuration file
[2021-03-21T10:10:46.757Z]  INFO: DockerSecurityPlayground/26249 on MacBook-Pro-de-Rigotto.local: Create dsp directories
[2021-03-21T10:10:46.757Z]  INFO: DockerSecurityPlayground/26249 on MacBook-Pro-de-Rigotto.local: Creating DSP directories
[2021-03-21T10:10:46.759Z]  INFO: DockerSecurityPlayground/26249 on MacBook-Pro-de-Rigotto.local: No synchronization with github: create local dir
[2021-03-21T10:10:46.760Z]  INFO: DockerSecurityPlayground/26249 on MacBook-Pro-de-Rigotto.local: Download single docker image
[2021-03-21T10:10:46.760Z]  INFO: DockerSecurityPlayground/26249 on MacBook-Pro-de-Rigotto.local: [DOCKER ACTIONS - DOWNLOAD IMAGE]
[2021-03-21T10:10:46.768Z]  INFO: DockerSecurityPlayground/26249 on MacBook-Pro-de-Rigotto.local: END
{"name":"DockerSecurityPlayground","hostname":"MacBook-Pro-de-Rigotto.local","pid":26249,"level":50,"msg":"Web socket error: Error: status 400; Client sent an HTTP request to an HTTPS server.\n","time":"2021-03-21T10:10:46.768Z","v":0}
[2021-03-21T10:10:46.768Z]  INFO: DockerSecurityPlayground/26249 on MacBook-Pro-de-Rigotto.local: [WEB SOCKET Response]
[2021-03-21T10:10:46.768Z] ERROR: DockerSecurityPlayground/26249 on MacBook-Pro-de-Rigotto.local:
Web socket error: Error: status 400; Client sent an HTTP request to an HTTPS server.
[2021-03-21T10:10:46.768Z] ERROR: DockerSecurityPlayground/26249 on MacBook-Pro-de-Rigotto.local:
Web socket error: Error: status 400; Client sent an HTTP request to an HTTPS server.
It seems that there is an issue during the download of lab docker images.
Do you know why ?
Regards,
MathRig.

Hi Math, I usually use DSP on Ubuntu 20.04, it seems that there is an issue regarding the websocket connection that is trying to interact with a HTTPs server instead of HTTP.
I will try another new installation from scratch on a new Linux machine to observe if there are strange behaviours in the last version, and I am going to try to reproduce it on my MacOS as soon as possible.
Could you give more information about the Operating System, node / docker version?
Could you also tell me if are you using Docker with tls enabled? maybe this could be the issue, I try to reproduce it if you give me the Docker configuration, and I can try to add tls support on docker client, if it is the case.
Thank you!

Hi MathRig, this issue cloud be related to docker-compose from Docker Desktop for macOS not using TLS.
https://github.com/docker/compose/issues/7348
Try to update your docker-compose version

Hi,
Thanks for your answers. Here are the version of nodejs and docker:

npm : 7.6.3
docker-machine version 0.16.2, build bd45ab1
Docker version 20.10.5, build 55c4c88
docker-compose version 1.28.5, build unknown
Homebrew 3.0.7

I installed everything using homebrew.
Ale753, I will try to delete and reinstall docker, python and openssl as they seems to be tight with this issue. I will let you know.

OK Guys, It was a docker-compose issue as ale753 said. I deleted docker from homebrew and installed from official package and now it is working. Same version but not the same way to deploy. with the official package, I don't need docker-machine to emulate a linux system, so it could it.

Great, thanks @ale753 .
@MathRig , hope that you will be able to use DSP and to find it useful for training and scenario emulations.
We hope to improve further, as soon as possibile, especially for learning experience and user experience.


Investigate time zone behavior

We had issue that our test suite does not specify time zone explicitly. So the XMLGregorianCalendar, sent in ws request, doesn't have setted timezone. But the server runs in different timezone and during conversion from XMLGregorianCalendar to Date the time was shifted.

Solution: Setting local java environment to the same timezone as the tested server environment.


feat: add update and delete to mongodbindexer

Add update and delete to MongoDBIndexer

We have quite a different way of doing tests here vs. Redis/LevelDB. Are there specific reasons for it? If no, could we do the same testing approach for both? Or even unify these tests for any Indexer and just call a test function with the specific indexer? Finally, they all should serve the same use-case.
If so, it would be great, to build up this test-case in the core-repo and use it there for the BinaryPBIndexer and then in all other KVIndexer in the hub, non?
If it is not possible to unify it, don't spend too much time on it. But it would be a cool pattern to just write a new indexer and get the test right away with only the custom set-up code.
@florian-hoenicke @cristianmtr

I agree that it would be nice to have them all look the same. The only reason I did it this way for MongoDBIndexer is because that's how we started doing it for the BinaryPbIndexer.
Also there might be specific indexers that won't pass some tests. E.g. BinaryPbIndexer doesn't support add and update in the same context. And possibly other indexer-specific issues that haven't been ironed out.
I think @florian-hoenicke suggested something like this some days ago, but he ran into some of these problems there. Do you remember what those were, or am I misremembering?

@cristianmtr Yes, I asked if we should write tests for baseclasses and run them on the derived classes. However, as @JoanFM  pointed out, we do not write core tests for the hub.
However, @hanxiao  suggested to add this functionality in the cookie cutter.
I created a ticket accordingly https://github.com/jina-ai/cookiecutter-jina/issues/39
fyi @maximilianwerk

@JoanFM can the mongodbindexer be merged?

We have quite a different way of doing tests here vs. Redis/LevelDB. Are there specific reasons for it? If no, could we do the same testing approach for both? Or even unify these tests for any Indexer and just call a test function with the specific indexer? Finally, they all should serve the same use-case.
If so, it would be great, to build up this test-case in the core-repo and use it there for the BinaryPBIndexer and then in all other KVIndexer in the hub, non?
If it is not possible to unify it, don't spend too much time on it. But it would be a cool pattern to just write a new indexer and get the test right away with only the custom set-up code.
@florian-hoenicke @cristianmtr
EDIT:
Haha, just saw jina-ai/cookiecutter-jina#39
Seems like the way to go :)

It is intentional not to have Hub executors import anything from the core, so I would avoid that. Also do not share code between executors, it is intended to have Hub execturos be independent at the expense of having more code duplication


Unable to find master entry for local.db.xxx.xx.com/10.80.xxx.xx:6379. Multiple IP bindings for single hostname supported only in Redisson PRO!

We use load balancing to achieve high redis availability,So we're using a domain name to connect to redisson.But now this error occurs:
org.redisson.client.RedisTimeoutException: Unable to get connection! Try to increase 'nettyThreads' and/or connection pool size settingsNode source: NodeSource [slot=0, addr=null, redisClient=null, redirect=null, entry=MasterSlaveEntry [masterEntry=[freeSubscribeConnectionsAmount=0, freeSubscribeConnectionsCounter=value:0:queue:1, freeConnectionsAmount=0, freeConnectionsCounter=value:0:queue:322, freezed=false, freezeReason=null, client=[addr=redis://local.db.xxx.xxx.com:6379], nodeType=MASTER, firstFail=0]]], command: (EVAL), params: [if (redis.call('exists', KEYS[1]) == 0) then redis.call('hset', KEYS[1], ARGV[2], 1); redis.call('pe..., 1, redisson_lock_sync2slave_documents_slave_p1, 30000, a9178bf5-e2c9-4a9e-be75-8a8c1481419d:231] after 0 retry attempts
2020-03-31 00:43:41,196 INFO [org.redisson.connection.DNSMonitor] - Detected DNS change. Master redis://local.db.xxx.xxxx.com:6379 has changed ip from 10.80.xxx.x1 to 10.80.xxx.x2
2020-03-31 00:43:41,196 ERROR [org.redisson.connection.DNSMonitor] - Unable to find master entry for local.db.xxx.xxx.com/10.80.xxx.x1:6379. Multiple IP bindings for single hostname supported only in Redisson PRO!

Had similar issue.
Please try to modify your config with setDnsMonitoringInterval(-1)

@ddekaliuk
Right


Stepper header without icons

Bug, feature request, or proposal:
Bug/feature request
What is the expected behavior?
Just display numbers in stepper headers
What is the current behavior?
Tries to display "create" in the icon after changing to another step
What are the steps to reproduce?
https://stackblitz.com/edit/angular-vpoj5j you can see it here
What is the use-case or motivation for changing an existing behavior?
Not everyone uses the icons
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Current. 5.2.4
Is there anything else we should know?
I know I can override the icons, however I'm unsure about changing it to always using the 'number' state.
The UX of changing the stepper to these icons doesn't really appeal to me.

There is a simple enough workaround, but it is not especially pretty:
@ViewChild(MatHorizontalStepper) stepper: MatHorizontalStepper;
this.stepper._getIndicatorType = () => 'number';

It is actually sort of frightening that this is permissible by ts

I think we could allow more flexibility with matStepperIcon if we added a let- binding on the directive so that people can have access to the step in the icon template. That should be able to support this use case as well as other things people may want to do. We should also allow people to specify a custom icon for the number steps, if we don't do that already. I think it only supports overriding edit and complete right now.
@crisbeto this sound reasonable to you?

I avoided adding the ability to override the number icon, because I wasn't sure how people would be able to do custom numbering @mmalerba, but your suggestion for adding a template context variable would work.
@narthur157 you can still replace the edit and done icons with blank ones. Note that the feature was added in Material 5.2.0, whereas your example is based on 5.1.0:
<mat-horizontal-stepper>
  <ng-template matStepperIcon="edit"></ng-template>
  <ng-template matStepperIcon="done"></ng-template>

  <mat-step>...</mat-step>
</mat-horizontal-stepper>


Add html placeholder option to search input

Please add html placeholder option to search input.

+1

@brunowego - I don't understand - why have you marked this and other bugs as +1? It is already implemented.

I would like to thanks .It works fine for me
$('div.dataTables_filter input').attr('placeholder', 'Search...');

+1

It can be done the with language.searchPlaceholder option


With whitespace: 'condense', elements contain only   and spaces are condensed into empty tags

Version
4.0.0-rc.1
Reproduction link
https://github.com/tobyzerner/vue-cli-nbsp-bug
Environment info
Environment Info:
  System:
    OS: macOS 10.14.6
    CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
  Binaries:
    Node: 10.15.3 - /usr/local/bin/node
    Yarn: 1.17.3 - ~/.npm-global/bin/yarn
    npm: 6.11.3 - ~/.npm-global/bin/npm
  Browsers:
    Chrome: 76.0.3809.132
    Firefox: 68.0.2
    Safari: 12.1.2
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0
    @vue/babel-plugin-transform-vue-jsx:  1.0.0
    @vue/babel-preset-app:  4.0.0-rc.1
    @vue/babel-preset-jsx:  1.1.0
    @vue/babel-sugar-functional-vue:  1.0.0
    @vue/babel-sugar-inject-h:  1.0.0
    @vue/babel-sugar-v-model:  1.0.0
    @vue/babel-sugar-v-on:  1.1.0
    @vue/cli-overlay:  4.0.0-rc.1
    @vue/cli-plugin-babel: ^4.0.0-rc.1 => 4.0.0-rc.1
    @vue/cli-plugin-eslint: ^4.0.0-rc.1 => 4.0.0-rc.1
    @vue/cli-service: ^4.0.0-rc.1 => 4.0.0-rc.1
    @vue/cli-shared-utils:  4.0.0-rc.1
    @vue/component-compiler-utils:  3.0.0
    @vue/preload-webpack-plugin:  1.1.1
    @vue/web-component-wrapper:  1.2.0
    eslint-plugin-vue: ^5.0.0 => 5.2.3
    vue: ^2.6.10 => 2.6.10
    vue-eslint-parser:  5.0.0
    vue-hot-reload-api:  2.3.3
    vue-loader:  15.7.1
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.6.10 => 2.6.10
    vue-template-es2015-compiler:  1.9.1
  npmGlobalPackages:
    @vue/cli: 4.0.0-rc.1

Steps to reproduce
Clone the repo, npm install && npm run serve
What is expected?
The template contains a span containing a   character. This span has a red background. Thus you should see a small red box on the page.
What is actually happening?
The   in the template is being ignored and converted into a normal space, which means the span element is not displayed.

I cannot replicate this bug in a plain Vue jsfiddle, nor a project using vue-loader without vue-cli. Thus I think something in vue-cli may be the culprit rather than vue-template-compiler or Vue itself.

I've transferred this issue to the vue repository because I believe it's a bug introduced in https://github.com/vuejs/vue/commit/e1abedb9e66b21da8a7e93e175b9dabe334dfebd
See another bug report at https://github.com/vuejs/vue/issues/9208#issuecomment-477811927
Current workaround:
// vue.config.js
module.exports = {
  chainWebpack: config => {
    config.module
      .rule('vue')
        .use('vue-loader')
          .tap(args => {
            args.compilerOptions.whitespace = 'preserve'
          })
  }
}

Would it be possible to ignore hairspaces ( ) as well..?

@naton as mentioned, this should be discussed in the vu repo.

@LinusBorg isn't this the Vue repo? The linked issue is the original change to add 'condense' is it not? It is also closed.
We just ran into this today and are trying to figure out how to work around it. We've built in some localization automation that assumes the 'condense' setting (based on Evan's suggestion that this would be default in 3.x and because I agree with the condense behaviour). So it makes it difficult to just swap back to preserve without potential side effects.

Ok it seems that simply not including the nbsp; inside an element by itself solves the issue. Adding this as a note for anyone else who runs into this.

I've transferred this issue to the vue repository because I believe it's a bug introduced in e1abedb
See another bug report at #9208 (comment)
Current workaround:
// vue.config.js
module.exports = {
  chainWebpack: config => {
    config.module
      .rule('vue')
        .use('vue-loader')
          .tap(args => {
            args.compilerOptions.whitespace = 'preserve'
          })
  }
}

This doesn't seem to work anymore with Vue 3, it throws the error: "TypeError: Cannot set property 'whitespace' of undefined". Any workaround for Vue 3?


Profile should work without loginscreen/userselection

Describe the issue
Given I use the b2b-example application and
Given I'm already logged into the application
When I click to "Edit Profile" (https://console.zitadel.ch/users/me)
Then I have to select my account again to be redirected
Expected behavior
Directly get to my profile (with the correct private-labeling / app context).

In my opinion we should do something similar to oidc "login_hint"
I should be able to redirect to some console urls and send a login_hint as parameter, if this is set the console will send this to  the login and the user should be authenticated directly

You can now add login_hint as parameter to trigger an auth flow with the username.


TextZone insertions may need to contain the rest of the editor for syntactic / grammatic context

Unless we can avoid it, because it would significantly increase load times. But some languages may need context from previous and next lines in order to color properly.

It might be possible to instead only create one other editor (for the 'after' state). Then, we would observe its rendered context and place it instead in interspersed views.
The upside to this approach would be that a lot of other features might work. But it would be a lot more work to get it to run properly. For now I'd argue neither is worth the effort.


Sponsors to support this

Given this is the best tutorial to help people learn AWS + Seerverless, I think you could ask for sponsors.

@QuantumInformation That's a good idea. A few others have suggested something similar as well. I think I might set up a Patreon page for this.

Patreon is a good idea, I would sign up.

Heres where I want to get sponsors for my less well know project:
https://github.com/QuantumInformation/test-recorder#sponsors

Thanks for that. Yeah I'll look into Patreon soon.

Good work, I signed up.

@QuantumInformation Thanks for the support and the idea itself!


offscreen Support

May I ask if you are considering supporting the offscreen feature? I didn't see any explanation in the wxt documentation.

@asasas234 The example of an offscreen api can be found here, WXT support it.

https://github.com/wxt-dev/examples/tree/main/examples/offscreen-document-setup
https://github.com/wxt-dev/examples/tree/main/examples/offscreen-document-domparser


Add a User Profiles page 🌟

👤✨ I want to create a normal user profile page and a profile icon in the home page navbar that redirects to the profile page...
PA please assign me for this task...

@kvcops

What's the advantage of this feature ?

What's the advantage of this feature ?

@kvcops Users can personalize their experience. They can update their name, profile image (avatar), email, phone number, bio.. to make the profile more reflective of their preferences. A user will feel more connected to the platform if they can customize their profile to reflect their personality or interests..

So...which database would you like to use for these to store the data?


Process versioning protocol?

Description
In kogito, what is the protocol for process versioning?
Examples

You deploy a process and find a bug, you make a change to the BPMN and restart the app?
If you want to run multiple parallel versions, are these separate application deployments?
Other considerations?

Implementation ideas
No response

@StephenOTT at this stage versioning is still limited, we've got a few items in our backlog like this one https://issues.redhat.com/browse/KOGITO-6517 to start enhancing this story. In that context, the primary use case that we would like to target is that each process version would have its own deployment and so inflight processes would remain running in the service version that it started. For new versions, that would mean deploying a completely new service, that way you can simplify having to do any kind of migrations for processes.

great.
This is a very interesting conversation because there is so much pro / con:

There is value to have 1 app per version but they share a index
Having multiple versions of BPMN in a single app, leads to having deployment Apis, which leads to weird migration scenarios: where you have to migrate from v1 to v2, rather than being able to make live change.
Could the index service GraphQL just have a mutation that joins each of the versions data into a single table response?
.. others to come.

@StephenOTT regarding point 3, the Data Index is also a sort of Gateway API in that sense, it could act as a routing layer to redirect a mutation to start a new instance to the newest version of the process. That also means that the Data Index would keep track of the available deployments. And as for data, that's already done by Data Index, it collects data from multiple runtimes, different processes and versions as well, so it should be transparent in that sense.

I have dealt with this A LOT in the camunda bpm space, and versioning becomes this mess for organizational deployments: where you have multiple versions being deployed, and dealing with migrations, etc.

One must be able to update the current version without having to change the version ID (from the index perspective its the same version) - this would also lead to things like: should you hash the BPMN so even though its the same version ID/tag you are aware that the definition is actually different (example: you made a bug in gateway logic and only detected it post deployment into prod).

Migration between V1 and V2 in messy: mapping between elements, deleted elements, etc is a mess and never perfect, and full of complexity.  The simpler you can keep your version protocol the better.: Codegen and service/app deployments really helps IMO which is great!

Starting the most recent version vs a specific version gets messy in practice and needs to be treated carefully:

Deployments could be active for active instances but you want to prevent any additional instances from being created. (in some engines this is a problem, because you suspend the definition, but this breaks Async Job creation such as timers (in camunda for example).
Sometimes you want to just hide the process def from users, but keep it active
Sometimes you want to have multiple parallel versions active to users
etc.


[FEATURE] Providing Direct link to recording

Why do we need this improvement?
It will enhance the user experience, as users don't have to go to a random GitHub page and search for the link to the YouTube recording, users can be directed straight to the YouTube video instead.  Moreover, no link is useful on that GitHub page as most of them are for the live recordings

How will this change help?
Users can directly go to the video rather than going to some other website .
Screenshots
Uploading asyncapi_website_ AsyncAPI specification website - Google Chrome 2024-03-03 00-50-45 (1).mp4…
How could it be implemented/designed?
It's not that difficult to implement we can embed the link of Youtube video rather than the GitHub page link
🚧 Breaking changes
Yes
👀 Have you checked for similar open issues?

[X] I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

Are you willing to work on this issue?
Yes I am willing to submit a PR!

@b-harsh thanks for opening this issue but IMO we don't need this change so I am closing this issue


Help on how to properly run it on Fedora

Hi! First of all, I'm a Linux newbie just really curious to know how this works. I've built and ran it successfully but with a few issues and questions:
I think it is "conflicting" with GNOME, somehow? I tried opening Firefox and it is rendering with the GNOME topbar. I guess the expected behavior was to it render with a topbar similar to that on the README screenshot, right?

Also, GNOME probably shouldn't even be running alongside electron-wm. Is there a way to disable it before opening electron-wm? Or maybe add electron-wm to the window manager selector on the login screen? I'm pretty sure I'm missing something here... 😅
With those questions answered I'll probably be able to guess how to properly run it in fullscreen.
Thanks in advance for your patience! This is a really neat project. ✨

It looks like you launched the window manager inside Xephyr, which is typically just used for development or experimentation.
I am not sure whether Firefox on Fedora will continue to look like this when the window manager is ran by itself. Some windows can choose to draw their own title bar. That doesn't happen for my Firefox install, but it could be different here.
I think you would want to set up the login screen to have an option to use this window manager to use it for real. I am not familiar with Fedora setup, but this post seems helpful:
https://superuser.com/questions/667042/fedora-window-manager-list
Thanks for trying it out!


SEO consideration on url change

https://www.zesty.io/contact-new/
The contact page url seems to be a temp which was being used to indicate it is the "new" page. If the prior url was /contact we should keep that in order to maintain the prior search engine indexed link.

Resolved - updated in CMS
https://www.zesty.io/contact/


refactor: add Python API

I factored the click commands into a general lm_zoo model API. click commands are now defined in lm_zoo.commands. This allows us to define libraries on top of the lm-zoo commands.

Yowza, accidentally merged to master. I reverted this and force-pushed manually


Fixed the UI issue and even added new dialogs to different actions

The constant appearance no-notes.gif by delete note is removed. It was caused by some notes.length field, but it is fixed.
Also to replace that gif i added a simple modal that appears on various actions like add/update/delete.
The modal can automatically disappears after 1500ms and some by 1000ms. or can by explicitly disappeared by clicking on any where on window.
After adding new note, it shows...

after updating any note it shows....

and finally after deleting any note...

Basically i just removed the bug or replaced bug with some modals, i hope you like it😊 also it doesnt change any main functionalities of your project...
please do accept my pull request😄

Hey @Sami3160 You have done a great job, but this will not create a good user experience.
Instead, you can show a toast message in the top right/center.

Hey @Sami3160 You have done a great job, but this will not create a good user experience.
Instead, you can show a toast message in the top right/center.

changes are done in this pr, check the updated preview:


Fix build warnings on Flutter 3.0.0

This PR addresses #39 by fixing dart:unnecessary_non_null_assertion warning so that the package is compatible with Flutter version 3.0.0. Warning details: The '!' will have no effect because the receiver can't be null. Try removing the '!' operator.
Warning about bindings in Flutter 3.0.0 release notes

Closing in favour of #34 which was raised earlier and addresses exactly the same thing


[HUDI-1098] Adding TimedWaitOnAppearConsistencyGuard

What is the purpose of the pull request
Introducing a TimedWaitOnAppearConsistencyGuard for eventual consistent stores. This will sleep for configured period of time only on APPEAR. It is a no-op for DISAPPEAR. This is specifically for eventually consistent stores like S3A filesystem and here is the rational.
This guard is used when deleting data files corresponding to marker files that needs to be deleted.
There are two tricky cases that needs to be considered. Case 1 : A data file creation is eventually consistent and hence
when issuing deletes, the file may not be found. Case 2: a data file was never created in the first place as the process crashed.
In S3A, GET and LIST are eventually consistent, and delete() implementation internally does a LIST/EXISTS.
Prior to this patch, hudi was leveraging FailSafeConsistencyGuard which was doing the following to delete data files.
Step1: wait for all files to appear with linear backoff timer w/ a max timer.
Step2: issue deletes
Step3: wait for all files to disappear.
Step1 and Step2 is handled by {@link FailSafeConsistencyGuard}.
We are simplifying these steps with TimedWaitOnAppearConsistencyGaurd as below.
Step1: Sleep for a configured threshold.
Step2: issue deletes.
With this, if any files that was created, should be available within configured threshold(eventual consistency).
Delete() will return false if FileNotFound. So, both cases are taken care of this {@link ConsistencyGuard}.
Step3 is not required since if FileIsNotFound, delete() would have returned false and hence we ignore the return values. But if file exists and if file could not be deleted, some exception would be thrown.
Brief change log

Added TimedWaitOnAppearConsistencyGuard to delete a bunch of files in eventually consistent cloud stores
Added a property in ConsistencyGuardConfig to determine the consistency Guard class
Fixed instantiation of ConsistencyGuard via Reflection in HoodieTable

Verify this pull request
This change added tests and can be verified as follows:

Added tests to TestConsistencyGuard to verify the change.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@bvaradar you are most familiar with this. can you please review this?
@umehrot2 let's see if we agree on the principles here

@umehrot2 can you please review this?

@umehrot2 : I will be reviewing this PR. In the interest of testing time, can you in parallel test and confirm if this would be effective in solving commit abort issue you are  facing.

Synced up with @bvaradar  on the diff. Here are some changes/conclusions we narrowed down after our discussion.

We felt exposing TimedWaitOnAppearCG to external users may not make much sense. We do not want to make TimedWaitOnAppear as the global consistency guard in all places, but it is very specific to finalizeWrite code path.
And so, instead of defining a config for consistencyGuardClass, we will introduce a config in ConsistencyGuard (for lack of better word, lets say "simplifyFailSafeConsistencyToTimedSleep/simplifyFailSafeConsistencyToTimedWait" for now). Will enable this config by default in which case TimedWaitOnAppearCG will be used in finalize Write. If users wish to use FailSafeCG even in finalizeWrite code paths, they can disable this config value on which FailSafeCG will be used.

@bvaradar : since you suggested to have the TimedWaitOnAppearCG as default opt in, I would suggest to introduce a new config for the sleep time. so that we can set it to 2 or 3 secs as default. The existing config which we are repurposing, has a default value of 400 ms and users may not realize to fix this value since this is going to be default opt in.

@umehrot2 : Would appreciate if you agree on the approach here. Before I go ahead and address feedback want to have consensus.

@bvaradar : patch is good to be reviewed.

@nsivabalan : Please fix the checkstyle issues when you get a chance.


Reduce logging overhead in hosting

TraceIdentifier is done at the last moment, or not at all
Request starting and finished messages are added
This pair provide many of the top-level values that you would have
found in server log files.

This ci broke

See also aspnet/Logging#261

PR #409 is working now; which you'll need to merge as the HttpAbstraction changes look like they have flowed through; so currently this PR will break the CI. Added all my comment changes from this to it - as they were around the upcoming break.

Sorry, was wrong, don't think this PR will break the CI.

Rebased #409 onto last commit and picked up remaining clean up and ci break

@Tratcher  updated

@Tratcher updated

Remove src/Microsoft.AspNet.Hosting/Internal/FastHttpRequestIdentifierFeature.cs
Remove function private string GetRequestIdentifier(HttpContext httpContext) from src/Microsoft.AspNet.Hosting/Internal/HostingEngine.cs
Remove "allowUnsafe": true from src/Microsoft.AspNet.Hosting/project.json
Remove test/Microsoft.AspNet.Hosting.Tests/Internal/FastHttpRequestIdentifierFeatureTests.cs
Change function HostingEngine_CreatesDefaultRequestIdentifierFeature_IfNotPresent in test/Microsoft.AspNet.Hosting.Tests/HostingEngineTests.cs from
Assert.NotNull(httpContext);
Assert.IsType<FastHttpRequestIdentifierFeature>(httpContext.Features.Get<IHttpRequestIdentifierFeature>());

to
Assert.NotNull(httpContext);
Assert.IsType<HttpRequestIdentifierFeature>(httpContext.Features.Get<IHttpRequestIdentifierFeature>());
Assert.False(string.IsNullOrWhiteSpace(httpContext.TraceIdentifier));
Assert.Same(httpContext.TraceIdentifier, httpContext.Features.Get<IHttpRequestIdentifierFeature>().TraceIdentifier);

As is overhead and otherwise now redundant (has been moved into HttpAbstractions)

:shipit:

Will wait until CI for hosting is green to push. Currently broken due to issues not related to this change.

f37375f43cd9e49ebcd61b62130d3455c8d41944


Official Docker Image doesn't exist on DockerHub?

Hello, I'm currently looking to pull the official discource/prometheus_exporter docker image using the command from the README and it appears like it doesn't exist anymore:
=> ~/ docker pull discourse/prometheus_exporter:latest
Error response from daemon: pull access denied for discourse/prometheus_exporter, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

Is the README still up to date or is there a new place I should be pulling the image from?

Hey @ttstarck, there was a slight setback with docker image publishing flow, so no official release in the Hub/GCR yet. I think it'll be published with the new release.
In the meantime you can use the provided Dockerfile here: https://github.com/discourse/prometheus_exporter/blob/main/Dockerfile

Any update on this? We would like to use the docker image on kubernetes. We can't link to a Dockerfile.
Thanks.

Interested in using a public docker image as well. Any update? Thanks much!

It seems that an official image is available on GHCR:
https://github.com/discourse/prometheus_exporter/pkgs/container/prometheus_exporter
The latest version can be pulled as ghcr.io/discourse/prometheus_exporter:2.1.1 (or :latest).
I hope this helps. I would recommend that the maintainers add some links to guide users in finding it more easily.


Rename the institutional sponsors section to organizing institutions

This is a requirement from the university, they just let us know about this.

published


CocoaPod

Hey
First of all let me thank you for writing this library. I was wondering if you can please provide the latest version through CocoaPod. The current one is 0.9.4 which seems quite old.
Thanks
Regards
Siddharth Garg

Yeah it has been a while since a new Cocoapods version has been release. I have a 0.9.5 tag pending on what we hear back from #86 then will push a new version once that feature has been tested.


Actioned Bug

There is a bug where if you kill or do anything to someone, the actioned should be 1 and if its one it should say you cant use it until the daytime. It does not say that
Just to let everyone know.

thonk

Resolved


Allow arbitrary table types for export (codegen)

Fixes #1108

Thanks for the PR! I added some commit comments.

Could you also update the reference docs and AntMetaDataExporter?

@Shredder121 Do you think this is ok to merge? The comma separated argument style is consistent with tableNamePattern, so it might be a better choice.

I think the text of tableTypesToExport being mutually exclusive to exportTables and exportViews would serve well in the Javadoc of AbstractMetaDataExportMojo.
Other than that it is good to merge in my opinion.


Fix android platform border color (#39893)

At Chime X Software Mansion we need this fix to be cherry-picked to RN 0.71+ as currently there is no option for us to upgrade to the next version ( this fix has not been released anyway) and we are blocked with our next project there.
It would be amazing if you could release it!

Summary:aAt Chime X Software Mansion we need this fix to be cherry-picked to RN 0.71+ as currently there is no option for us to upgrade to the next version ( this fix has not been released anyway) and we are blocked with our next project there.
It would be amazing if you could release it!

Summary:
If you try to apply PlatformColor to borders on Android app will crash with the next error:
"Error while updating property 'borderColor' of a view managed by: RCTView"
Changelog:
[ANDROID] [FIXED] - Fix android crash when apply PlatformColor to borders
Pull Request resolved: https://github.com/facebook/react-native/pull/39893
Test Plan:
In RNTester example, go to APIs -> PlatformColor

Before
After

Reviewed By: NickGerleman
Differential Revision: D50011758
Pulled By: javache
fbshipit-source-id: ea06c18c6aef4b6731e9b9b87422a1e0d13de208 (cherry picked from commit 265af222aa8acb3b514e22a7db191d66755f553b)
If you try to apply PlatformColor to borders on Android app will crash with the next error:
"Error while updating property 'borderColor' of a view managed by: RCTView"
Changelog:
[ANDROID] [FIXED] - Fix android crash when apply PlatformColor to borders
Pull Request resolved: https://github.com/facebook/react-native/pull/39893
Test Plan:
In RNTester example, go to APIs -> PlatformColor

Before
After

Reviewed By: NickGerleman
Differential Revision: D50011758
Pulled By: javache
fbshipit-source-id: ea06c18c6aef4b6731e9b9b87422a1e0d13de208 (cherry picked from commit 265af222aa8acb3b514e22a7db191d66755f553b)

Please request this in https://github.com/reactwg/react-native-releases/discussions/91


Support for pasting images

It'd be really nice if Lorien supported pasting in images (and moving / resizing them). This would be useful in augmenting the free-form brainstorming that's already possible with some specific images/screenshots.
Thanks again for the cool tool. :)

I started working on adding image-paste support via external C++ library clip since Godot can only retrieve text from clipboard. Currently, I have only tested on Linux since I do not have macOS or Windows development environments ready.

https://github.com/hansemro/GDClip: clip library for Godot + demo
https://github.com/hansemro/Lorien/tree/paste_dev: Linux/xclip image paste proof-of-concept in Lorien

no load/save/selection/deletion functionality for pasted images as they have not been implemented yet.
supports only png images in clipboard

@hansemro impressive! We can use this when we add full image support ;)
I would have just started with dragging images into the app window (which you can do with Godot) and then implement everything based on that. But unfortunally i'm very busy right now, so i'm of very little help for such a big new feature :/

I am nearly finished with clipboard support. Current status: https://github.com/hansemro/Lorien/issues/1
I might make a merge request (without super-eraser and debug stuff included) later if you are interested.


Admin internal API interface

Brain dump. /cc @skade
Instead of dumping all the ORM bits directly into the admin, we could interface them through a set of helpers (the API) that would inject the required methods based on the ORM of choice.
The helpers could look like get_one(Model, id).
This could allow for a pretty much static and mountable admin application, i.e, you only need to switch the adaptor for it.
Pushed even further it could allow for one liners that define manageable objects and it's associations.

Requested couch potato support in #849


AfterAll hook doesn't run when 'bail' is set

This appears intentional, but has some unfortunate unintentional consequences, the most obvious of which I'm currently encountering.
I need to run some tests against an instantiated application; when the tests are done, I want to shut down the application gracefully. Before and After hooks make sense for this, right? Wrong! The application will never get cleaned up if there is an error because the after hook doesn't run!
I'm not sure why hooks are treated the same as test suites; the intent of the 'bail' option is just to stop running tests, but cleanup should still happen; that is, 'after' hooks that apply to tests that did run should be executed.

Hi @myndzi, what version of mocha are you running? I supposedly fixed that bug recently.

The bugfix was released on version 2.1.0.

Figures, haha. I had to avoid version 2.1.0 because of the other change which destroyed color support by binding mocha's reporters tightly to the native tty module. I haven't had time to work out a workaround yet, I only noted that no matter what I did (setting the use color property directly, environment variable, etc.) I couldn't get color out a stream.

I'll take your word that this is fixed and close this; I'll open another one for the color thing if/when I've managed to look into it enough to say something useful


[To Main] DESENG-634: Update engagement cards; add suggested engagements block

Issue #:  🎟 DESENG-634
Description of changes:

Redesigned the engagement cards to match the new design system
Added a new section to the engagement page to display suggested engagements
Engagement cards now take you to the "new look" route
Tweaks to the engagement list page layout
Minor tweaks to the engagement view page layout

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report
Attention: Patch coverage is 81.25000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 75.94%. Comparing base (4ee26b0) to head (0c23d97).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2547      +/-   ##
==========================================
+ Coverage   75.92%   75.94%   +0.02%
==========================================
  Files         607      608       +1
  Lines       21958    21996      +38
  Branches     1695     1708      +13
==========================================
+ Hits        16671    16705      +34
- Misses       5024     5028       +4
  Partials      263      263

Flag
Coverage Δ

metweb
64.72% <81.25%> (+0.08%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...eb/src/components/common/Indicators/StatusChip.tsx
73.91% <100.00%> (ø)

met-web/src/components/landing/FilterDrawer.tsx
48.00% <100.00%> (+1.06%)
:arrow_up:

...et-web/src/components/landing/LandingComponent.tsx
100.00% <100.00%> (ø)

...-web/src/components/landing/MetadataFilterChip.tsx
100.00% <100.00%> (ø)

met-web/src/components/landing/TileBlock.tsx
90.00% <100.00%> (ø)

met-web/src/components/landing/TileSkeleton.tsx
100.00% <100.00%> (ø)

met-web/src/styles/Theme.ts
100.00% <ø> (ø)

met-web/src/components/landing/EngagementTile.tsx
73.61% <68.96%> (-2.96%)
:arrow_down:

... and 2 files with indirect coverage changes


en: Remove kubectl duplicate example

With #16974 and the removal of --include-uninitialized flag, the

second
and third examples of kubectl delete become equal, thus leading to
duplication and being confusing. Suggest to remove the duplicate and
replace it with another example in the future if needed.
Observed in v1.16 and v1.17 documentation.

Signed-off-by: Mariyan Dimitrov<EMAIL_ADDRESS>

I signed it

/assign @jimangel

/kind cleanup
/lgtm
@merkata Thank you!


Confirgure a module installed by zip doesn't work

Install MBO
Click on Module Catalog
Upload a module by zip
Click on Configure button

Fixed

@MrBaiame this issue is back again with the last version

On which branch did you test ? it works on master

I was on dev branch


Error importing CMS field on certain environments

We consistenly get an exception (see below) when trying to import cms fields on our staging and production environments. Importing works fine on local and development environments. We tried pulling in the production and staging DB to our local environment. Imports still work then. So DB is not corrupt. Copying our local code directly to the staging and production environments does not solve this issue.
The column1Label field does exist in our production and staging database.
Is this a bug in schematic or are we doing something wrong here?
exception 'Craft\Exception' with message 'No field exists with the handle “column1Label”' in /project/craft/app/models/BaseElementModel.php:987 Stack trace: #0 /project/craft/app/services/ContentService.php(403): Craft\BaseElementModel->getFieldValue('column1Label') #1 /project/craft/app/services/ContentService.php(154): Craft\ContentService->_updateSearchIndexes(Object(Craft\GlobalSetModel), Object(Craft\ContentModel), Object(Craft\FieldLayoutModel), NULL, NULL) #2 /project/craft/app/services/ElementsService.php(1521): Craft\ContentService->saveContent(Object(Craft\GlobalSetModel), false, false) #3 /project/craft/app/services/GlobalsService.php(282): Craft\ElementsService->saveElement(Object(Craft\GlobalSetModel), false) #4 /project/vendor/itmundi/schematic/src/Services/GlobalSets.php(79): Craft\GlobalsService->saveSet(Object(Craft\GlobalSetModel)) #5 /project/vendor/itmundi/schematic/src/Services/Schematic.php(131): NerdsAndCompany\Schematic\Services\GlobalSets->import(Array, false) #6 /project/vendor/itmundi/schematic/src/Services/Schematic.php(80): NerdsAndCompany\Schematic\Services\Schematic->importDataModel(Object(NerdsAndCompany\Schematic\Models\Data), false) #7 /project/vendor/itmundi/schematic/src/ConsoleCommands/ImportCommand.php(37): NerdsAndCompany\Schematic\Services\Schematic->importFromYaml('cms-fields.yml', 'craft/config/ov...', false) #8 [internal function]: NerdsAndCompany\Schematic\ConsoleCommands\ImportCommand->actionIndex('cms-fields.yml', 'craft/config/ov...', false) #9 /project/craft/app/framework/console/CConsoleCommand.php(172): ReflectionMethod->invokeArgs(Object(NerdsAndCompany\Schematic\ConsoleCommands\ImportCommand), Array) #10 /project/craft/app/framework/console/CConsoleCommandRunner.php(71): CConsoleCommand->run(Array) #11 /project/craft/app/framework/console/CConsoleApplication.php(92): CConsoleCommandRunner->run(Array) #12 /project/craft/app/framework/base/CApplication.php(185): CConsoleApplication->processRequest() #13 /project/vendor/itmundi/schematic/bin/schematic(82): CApplication->run() #14 /project/schematic(9): require('/project...')

We found out that the fieldcontext is not being set correctly to 'global' when importing the global sets. Not sure why.

Can you try #81 to see if this is fixed?


Incorrect events documentation

The docs page stated change.dp, show.dp, etc as events. I think you meant dp.change, dp.show and dp.hide. The page is here!

Thanks. I'm aware of this. I expect to push the dev to master this coming Saturday and will fix the docs. We had hope to have the namespaces fixed, but change.dp causes issues so we had to revert it (again)

I see. Thanks for the clarification! :smile:


[backport] Replace distutils with setuptools in Windows cl.exe detection

Backport of #6025 by @kmaehashi

/test mini


Error in other device

I/flutter (13963): ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
I/flutter (13963): The following NoSuchMethodError was thrown building BackButton(dirty):
I/flutter (13963): The getter 'backButtonTooltip' was called on null.
I/flutter (13963): Receiver: null
I/flutter (13963): Tried calling: backButtonTooltip
I/flutter (13963): When the exception was thrown, this was the stack:
I/flutter (13963): #0      Object.noSuchMethod (dart:core-patch/dart:core/object_patch.dart:46)
I/flutter (13963): #1      BackButton.build (package:flutter/src/material/back_button.dart:87)
I/flutter (13963): #2      StatelessElement.build (package:flutter/src/widgets/framework.dart:3687)
I/flutter (13963): #3      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3634)
I/flutter (13963): #4      Element.rebuild (package:flutter/src/widgets/framework.dart:3487)
I/flutter (13963): #5      ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3614)
I/flutter (13963): #6      ComponentElement.mount (package:flutter/src/widgets/framework.dart:3609)
I/flutter (13963): #7      Element.inflateWidget (package:flutter/src/widgets/framework.dart:2899)
I/flutter (13963): #8      Element.updateChild (package:flutter/src/widgets/framework.dart:2702)
I/flutter (13963): #9      SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4646)
I/flutter (13963): #10     Element.inflateWidget (package:flutter/src/widgets/framework.dart:2899)
I/flutter (13963): #11     Element.updateChild (package:flutter/src/widgets/framework.dart:2702)
I/flutter (13963): #12     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3645)
I/flutter (13963): #13     Element.rebuild (package:flutter/src/widgets/framework.dart:3487)

$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v0.3.1, on Linux, locale pt_BR.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[✓] Android Studio (version 3.0)
[✓] VS Code (version 1.22.2)
[✓] Connected devices (1 available)
• No issues found!