[WIP] Add HttpData#close, HttpData#toByteBuffer, and docs.

Also changes ByteBufHttpData#toInputStream to not create a new reference / release one. I think for usages of HttpData, it's clear enough that all the operations should happen in the scope of the try-with-resources so no need to worry about transfer of InputStream out of the block.
Fixes #1936

/cc @adriancole

I can't think of it either. 😢 The reason that you don't like it is that you think the HttpData is something that is not closeable?

I also worry about top-level no-op close(). Many API which implement HttpData don't need close(). a close() method is only overrided at ByteBufData among AbstractHttpData, ByteBufData, ByteRangeHttpDataandDefaultHttpData`.
How about making a delegate for making sure release instead of inheritance like:
class CloseableHttpData implements HttpData, AutoCloseable {

    private HttpData httpData;

    static HttpData of(HttpData httpData) {
        return new CloseableHttpData(httpData);
    }

    CloseableHttpData(HttpData httpData) {
        this.httpData = httpData;
    }

    @Override
    public void close() {
        // Check HttpData Type
        if (httpData instanceof ByteBufData) {
            /// close stuff
        }
        ...
    }

    // HttpData overrides
    @Override
    public byte[] array() {
        return httpData.array();
    }
    ....

}

I was thinking of the wrapper too, putting it into the unsafe package. I feel like if we do that we should do it for everything - move the current aggregateWithPooled methods and anything else that mentions pooled into unsafe. I think it might also imply moving some classes into the internal package though since they would probably need to become public.
Is this a good idea? It's pretty big refactoring

I like the idea of providing an additional layer for enabling an advanced feature like this, e.g.
try (PooledHttpRequest pooled = req.withPooling()) {
    pooled.aggregate()...;
}

interface PooledHttpRequest extends HttpRequest, AutoCloseable { ... }

What do you think?

@trustin I like the thinking.. I suppose it would be more telling if applied to existing call sites. Maybe something like that could go on a branch/PR and we can try applying it to real use using jitpack to serve the dependency

Yeah I think it's a good idea - it'll take a lot of refactoring :) I'll put this PR on hold for now

Superseded by #2448


Rename submodule under cupy.prof package

Rel #3420.
This PR renames the submodule under cupy.prof to indicate that it is CuPy's private submodule and not intended to be used by users.

Jenkins, test this please

Jenkins CI test (for commit 1c078fef068d1d1e1bad43f7ab33faa6d40a8600, target branch master) failed with status FAILURE.

Jenkins, test this please

Jenkins CI test (for commit 1c078fef068d1d1e1bad43f7ab33faa6d40a8600, target branch master) succeeded!


Error messages for SOW upload

As a
I want
So that
Description:
if needed
Acceptance Criteria:

[ ] If SoW is not uploaded successfully, it should not show in thee upload box for the SoW and the change request upload
[ ] Error message for file upload should say file name in it where it says 'Statement of Work' in the error messages for SoW and change request validation

[wireframe 1]

[ ] Acceptance Criteria

[wireframe 2]

[ ] Acceptance Criteria

Implementation Details

Hey team! Please add your planning poker estimate with Zenhub @AntBush @marcellmueller @rafasdc @VB-at-Bis


RequireJS + AngularJS + angular-spinner:

I'm unable to configure the spinner.
define(["require", "exports"], function (require, exports) {
	Object.defineProperty(exports, "__esModule", { value: true });
	var SpinnerConfigurator = (function () {
		function SpinnerConfigurator(cfgProvider) {
			this.cfgProvider = cfgProvider;
			/*
				https://github.com/urish/angular-spinner
				http://spin.js.org/
			*/
			console.log(cfgProvider);
			cfgProvider.setDefaults({
				color: "white",
				scale: 1,
				width: 5,
				length: 7,
				radius: 5,
				trail: 50,
				shadow: true,
				opacity: 0.2
			});
		}
		return SpinnerConfigurator;
	}());
	SpinnerConfigurator.$inject = ["usSpinnerConfig"];
	exports.SpinnerConfigurator = SpinnerConfigurator;
});

Angular itself is shim'd, but not angular-spinner or spin.js.  The console.log statement above prints out {config: Object, themes: Object}; that object doesn't contain a setDefaults method, even though I see those methods in the angular-spinner code.
Can anyone advise me on what to do?  Additional information can be provided upon request.

@amyhickman Thanks for reporting. Why did you closed the issue? Is it relevant?


[BUG] Unable to create new app on latest version when using a custom template.

Required check list:

[x] I'm gonna mark the checkboxes like this.
[x] I didn't find in the Create Go App CLI repository's issues section similar bug.
[x] I understand, that the Create Go App CLI is Open Source and not-for-profit product.
[x] This is not about third-party project, framework, package or technology.

My environment:

Linux Ubuntu SMP x86_64 GNU/Linux
go version go1.19.2 linux/amd64
cgapp version 3.6.2

Describe the bug:
Bug when creating a new app with custom template, In last prompt Y choice is still a No.
Steps to reproduce the behavior:

run cgapp create -t
In my case, I choose echo-go-template as backend template, so input github.com/create-go-app/echo-go-template
Do the same thing for the frontend(pick your own frontend template).
Lastly, type Y for the last prompt.

Expected behavior:
The app picks the no choice and closes.
Screenshots:

Hi,
@mystique09 if you've time, would be great to make PR with this fix 😉


Addy builder needs help! Issue #88

To find out a large square, we need to have small squares in quantity of perfect square, thus we need to nullify some squares taking squareroot of given number of squares and checking for nearest(less) integer and then taking its square to get exact number of squares needed for large square. After we get no. of squares we can use from given small squares, we can calculate overall Maximum area.

@ArtiHere your pull req is merged.


Tabula not opening

Tabula isn't opening it is saying can't connect.
Err_Connection_Refused
I'm running windows 7. I just downloaded it last month, and i tried opening it in chrome and firefox.

Have tried firefox, uninstalled and reinstalled, updated java no luck. still won't connect.  it has been working great up until today.

Ah! Windows was for some reason stopping java with the firewall. Issue resolved!

@NishaT Glad you solved the issue! And thanks for documenting it here, hopefully if anyone else runs into it, they'll find this thread and find the solution.


Aries RFC's and DIDComm v2 overlap

Background
I have been spending some time lately researching the Aries RFC's, and trying to look for overlapping with the new Identity Fondation-hosted DIDComm v2
Aries DIDComm RFC's overlapping with DIDComm v2

Aries RFC 0003 Protocols - https://github.com/hyperledger/aries-rfcs/blob/master/concepts/0003-protocols/README.md
Aries RFC 0005 Didcomm - https://github.com/hyperledger/aries-rfcs/blob/master/concepts/0005-didcomm/README.md
Aries RFC 0019 Encryption envelope - https://github.com/hyperledger/aries-rfcs/blob/master/features/0019-encryption-envelope/README.md
Aries RFC 0025 Didcomm transports - https://github.com/hyperledger/aries-rfcs/blob/master/features/0025-didcomm-transports/README.md
Aries RFC 0046 Mediators and relays - https://github.com/hyperledger/aries-rfcs/blob/master/concepts/0046-mediators-and-relays/README.md

Aries DIDComm RFC's partially overlapping

Aries RFC 0021 Didcomm message anatomy - https://github.com/hyperledger/aries-rfcs/blob/master/concepts/0021-didcomm-message-anatomy/README.md
Aries RFC 0160 Connection protocol - https://github.com/hyperledger/aries-rfcs/blob/master/features/0160-connection-protocol/README.md

Aries DIDComm RFC's not overlapping with DIDComm v2

Aries RFC 0008 Message id and threading - https://github.com/hyperledger/aries-rfcs/blob/master/concepts/0008-message-id-and-threading/README.md
Aries RFC 0011 Decorators - https://github.com/hyperledger/aries-rfcs/blob/master/concepts/0011-decorators/README.md
Aries RFC 0020 Message types - https://github.com/hyperledger/aries-rfcs/blob/master/concepts/0020-message-types/README.md

Here is my question:
Aries RFC's can be categorized into 2 broad categories:

Aries RFC's which are inside the scope of DIDComm v2
Aries RFC's which are outside of the scope of DIDComm v2

Is it possible to make the distinction between the RFC's which are inside, and the RFC's which are outside crystal clear? Will this distinction be useful to the community, to make it easier to know which RFC's will receive continued support, and which will be deprecated after DIDComm v2 has landed?

@Arxcis I do think one important thing to think about and mention is, how does this affect interopability. What are these non overlapping RFCs, and what features might that affect the interopable communication?

One interessting thought when venturing into didcom might be this comment: https://github.com/uport-project/veramo/discussions/420#discussioncomment-517010


🚀[Feature]: Add GitHub Action library

Description
Take inspiration from:

[ ] Should include default PowerShell commands to handle Workflow commands

[ ] Using workflow commands to access toolkit functions
[ ] Setting a debug message
[ ] Setting a notice message
[ ] Setting a warning message
[ ] Setting an error message
[ ] Grouping log lines
[ ] Masking a value in a log
[ ] Stopping and starting workflow commands
[ ] Sending values to the pre and post actions
[ ] Environment files
[ ] Setting an environment variable
[ ] Setting an output parameter
[ ] Adding a job summary
[ ] Adding a system path

[ ] https://github.com/actions/toolkit
[ ] https://docs.github.com/en/rest/guides/scripting-with-the-rest-api-and-javascript?apiVersion=2022-11-28

Toolkit function
Equivalent workflow command

core.addPath
Accessible using environment file GITHUB_PATH

core.debug
debug

core.notice
notice

core.error
error

core.endGroup
endgroup

core.exportVariable
Accessible using environment file GITHUB_ENV

core.getInput
Accessible using environment variable INPUT_{NAME}

core.getState
Accessible using environment variable STATE_{NAME}

core.isDebug
Accessible using environment variable RUNNER_DEBUG

core.summary
Accessible using environment file GITHUB_STEP_SUMMARY

core.saveState
Accessible using environment file GITHUB_STATE

core.setCommandEcho
echo

core.setFailed
Used as a shortcut for ::error and exit 1

core.setOutput
Accessible using environment file GITHUB_OUTPUT

core.setSecret
add-mask

core.startGroup
group

core.warning
warning


evidence

Does 'sampler.evidence()' return the Bayesian evidence of the model defined as eqn.(17) in https://ned.ipac.caltech.edu/level5/Sept13/Trotta/Trotta4.html? Can it be directly used to calculate the Bayesian ratio for model comparison?

Thanks for your reply!


'image_tensor' not existing in the graph

Hi Edje!
Trying to use a custom model, but I'm receiving an error about 'image_tensor' not existing in the graph.
KeyError: "The name 'image_tensor:0' refers to a Tensor which does not exist. The operation, 'image_tensor', does not exist in the graph."
Full console output here
I trained the model following Google's TensorFlow for Poets tutorial. The output was a .pb for the graph and a .txt with the labels. It didn't have the labels formatted the same way yours did, so manually edited it in.
Do you think something else might be missing from the retraining?
Any help would be much appreciated! Your example worked GREAT, now it's just to add in the custom model!
Thank you,
-RobotGrrl

Hi RobotGrrl,
The TensorFlow for Poets tutorial trains an image classification model rather than an object detection model. The difference is that an object detection model can locate and identify multiple objects in an image (and draw a box around them), while a classifier just looks at an image and makes a single identification of the image. Classifiers can't be used to detect multiple objects in an image.
The models I used for this tutorial are object detection models, and all the tools are from the Object Detection module (i.e. everything inside the models/research/object_detection folder), so the .pb and .txt files from the TensorFlow for Poets tutorials won't work. However, I think you can use your classification model with the "classify_image.py" script inside the /tensorflow1/tutorials/image/imagenet folder.
Try issuing:
python /tensorflow1/tutorials/image/imagenet classify_image.py --model_dir=<path to wherever your .pb and .txt files are> --image_file=<path to the image you want to test>"

It should return a label for the image (you can see an example at 15:20 in this video: https://youtu.be/WqCnW_2XDw8?t=15m20s ). I'm not sure how to work that into it's own program though (where you do something like classify the image and then perform an action if it's a certain object)!
Can you let me know if this works?
Alternatively, you can look at my GitHub guide for training your own object detection model [here](Update the Raspberry Pi.


Typescript Definition

Hi, I'm trying to use this library in typescript project but got error Could not find a declaration file for module 'nfc-pcsc'
Could you please add typescript definition to this awesome library. thanks.

I've just started working on this, so far I've covered enough for my very small use case of just getting the UID from a generic card.
I don't really know all the technicalities of all the card types and such neither do I know the inner workings of @pokusew/pcsclite, but I'd be happy to help implement types for this repo.
I've added the types in a way in which no source code is modified, and the definitions in Reader.d.ts should be easy to work with and extend.
My fork is here.
To test the types you can add // @ts-check to the top of an example file to enable strict type-checking (at least in vscode).
Not sure if you got resources to work on this right now @pokusew, but I'd be willing to help :)

Thanks vaaski for sharing your types!
It would also be great to see your implementation in a module declaration, so it can be retrofittet independant of the repo.
I was not able to get it right as I'm not experienced in TS. My approach:
declare module 'nfc-pcsc' {
  import type { TypedEmitter } from './TypedEmitter'
  interface NFCEmitter {
    reader: (reader: Reader) => void;
    error: (error: Error) => void;
  }
  export class NFC extends TypedEmitter<NFCEmitter> {}
}

Can someone assist?

I wonder if this will work:
declare module 'nfc-pcsc' {
  import { EventEmitter } from 'events';

  interface NfcPcsc extends EventEmitter {
    start(): Promise<void>;
    stop(): Promise<void>;
    listDevices(): Promise<string[]>;
    open(device: string): Promise<void>;
    close(): Promise<void>;
    transmit(data: Buffer): Promise<Buffer>;
  }

  function nfc(): NfcPcsc;

  export = nfc;
}

I didn't write it all down, but it looks like this.
nfc-pcsc.d.ts
declare module 'nfc-pcsc' {
  export type ListenerSignature<L> = {
    [E in keyof L]: (...args: any[]) => any;
  };

  export type DefaultListener = {
    [k: string]: (...args: any[]) => any;
  };

  export class TypedEmitter<L extends ListenerSignature<L> = DefaultListener> {
    static defaultMaxListeners: number;
    addListener<U extends keyof L>(event: U, listener: L[U]): this;
    prependListener<U extends keyof L>(event: U, listener: L[U]): this;
    prependOnceListener<U extends keyof L>(event: U, listener: L[U]): this;
    removeListener<U extends keyof L>(event: U, listener: L[U]): this;
    removeAllListeners(event?: keyof L): this;
    once<U extends keyof L>(event: U, listener: L[U]): this;
    on<U extends keyof L>(event: U, listener: L[U]): this;
    off<U extends keyof L>(event: U, listener: L[U]): this;
    emit<U extends keyof L>(event: U, ...args: Parameters<L[U]>): boolean;
    eventNames<U extends keyof L>(): U[];
    listenerCount(type: keyof L): number;
    listeners<U extends keyof L>(type: U): L[U][];
    rawListeners<U extends keyof L>(type: U): L[U][];
    getMaxListeners(): number;
    setMaxListeners(n: number): this;
  }

  type Type = 'TAG_ISO_14443_3' | 'TAG_ISO_14443_4';

  const KEY_TYPE_A = 0x60;
  const KEY_TYPE_B = 0x61;

  interface Card {
    type: Type;
    standard: Type;
    uid?: string;
    data?: Buffer;
  }

  interface ReaderEmitter {
    card: (x: Card) => void;
    'card.off': (x: Card) => void;
    error: (x: Error) => void;
    end: () => void;
  }

  export class Reader extends TypedEmitter<ReaderEmitter> {
    get name(): string;

    authenticate(blockNumber: number, keyType: number, key: string, obsolete?: boolean): Promise<boolean>;

    read(
      blockNumber: number,
      length: number,
      blockSize?: number,
      packetSize?: number,
      readClass?: number
    ): Promise<Buffer>;
  }

  interface NFCEmitter {
    reader: (reader: Reader) => void;
    error: (error: Error) => void;
  }

  export class NFC extends TypedEmitter<NFCEmitter> {}
}


fix: use more specific selectors in cypress test to avoid flakiness

dateConditions:

there was a vis that had "Last 12 months" in the name, that was listed in the start screen behind the period selector dialog. Cypress was choosing that rather than the period option

fileMenu:

on CI, the File menu was positioned at 0,0 in the viewport, so clicking on 0,0 didn't close the file menu. Instead, click on the cover layer to close the menu, and confirm that it's gone. I'm not sure why the File menu was positioned incorrectly.

Added to https://github.com/dhis2/line-listing-app/pull/298


export to Maya Blender format

Any idea how to convert result to DCC(Maya Blender) software?

Sorry, I have not been used this software.


NIFI-11215: Add custom validation for KerberosUserService in PutIceberg

Summary
NIFI-11215
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[ ] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[ ] Pull Request based on current revision of the main branch
[ ] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[x] Build completed using mvn clean install -P contrib-check

[x] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

@mark-bathori Could you please add a unit test (using TestRunner) for testing the new validation logic?

Thanks @Lehel44 and @turcsanyip for the reviews. I've updated my PR with unit tests for the custom validation.


Add support for ControlledQubitUnitary

resolves issue #49. Tests need to be added though.

added a test

Friendly nudge @isaacdevlugt 🙂

I'm not sure I understand this correctly, but does this leave the control wires in the |0> state? This would make the control operation trivial, no? Maybe it would be good to test this for the |+> state in the control register. What do you think?

Hi @Hosseinberg, I just wanted to check in and hear what you think about this comment? I think if we have a test like this we can merge the PR.


Trying to download to path

I'm trying to use a library like Fetch (https://github.com/tonyofrancis/Fetch) to download: photos, videos, audios and documents to the filesystem. What is the correct way to generate a path for simple storage to download to?
findViewById<FloatingActionButton>(R.id.fab).setOnClickListener {
            val tsLong = System.currentTimeMillis() / 1000
            val ts = tsLong.toString()
            val url = "https://unsplash.com/photos/FQq88kJLoyI/download?force=true"
            val mediaFile = MediaStoreCompat.createImage(this, FileDescription("image${ts}.jpg", subFolder = "Bramti Images", mimeType = "image/jpg"), ImageMediaDirectory.PICTURES)
//           val intent = Intent(applicationContext, DownloadService::class.java)
//            intent.putExtra("downloadUrl", url)
              val path = mediaFile!!.absolutePath
//            intent.putExtra("saveFilePath", path)

            enqueueDownload(url, path)
        }
 }

    private fun enqueueDownload(url: String, filePath: String) {
        request = Request(url, filePath)
        fetch.attachFetchObserversForDownload(request.id, this)
                .enqueue(request, { result -> request = result }, { result -> Log.d("MainActivity", "SingleDownloadActivity Error: %1${result}s") })
    }

Prior to API 29, you can use direct filePath such as /storage/emulated/0/Download, but it no longer works on API 29 and higher. You need to use Uri or output stream. Here's the common example:
val mediaFile = MediaStoreCompat.createImage(...)
val uri = mediaFile.uri
val outputStream = mediaFile.openOutputStream()
// Then, use Uri or OutputStream to write file

After the file is downloaded successfully, do not forget to set MediaFile.isPending to false. If not, the file wont be visible to user:
mediaFile.isPending = false

Check if Fetch supports writing files with Uri or java.io.OutputStream.

Prior to API 29, you can use direct filePath such as /storage/emulated/0/Download, but it no longer works on API 29 and higher. You need to use Uri or output stream. Here's the common example:
val mediaFile = MediaStoreCompat.createImage(...)
val uri = mediaFile.uri
val outputStream = mediaFile.openOutputStream()
// Then, use Uri or OutputStream to write file

After the file is downloaded successfully, do not forget to set MediaFile.isPending to false. If not, the file wont be visible to user:
mediaFile.isPending = false

Check if Fetch supports writing files with Uri or java.io.OutputStream.

Thanks for the response, so Fetch uses the file path, I have tried doing it the way you stated with uri.path for the strring path, however I get a file not found error.

Thanks for the response, so Fetch uses the file path, I have tried doing it the way you stated with uri.path for the strring path, however I get a file not found error.

Looking inside of fetch i see this

Looking inside of fetch i see this

For API 29+, Android scoped storage limits your access to external storage, even though user has granted the permissions. The only writable path on API 29+ is context.getExternalFilesDir(), which will return:
/storage/emulated/0/Android/data/your_app_package/files
You can use this path if you don't want to use Uri and stick with java.io.File.
If you want to save downloads into media file or public directory like Download, then you have to depend on Uri or java.io.OutputStream.
Yup, MediaStoreCompat is for media files only. For documents and other files, you can use DocumentFileCompat. Since Fetch uses java.io.File, I will assume that it does not support scoped storage yet. You had better creating an issue on Fetch to request scoped storage support for API 29+.

For API 29+, Android scoped storage limits your access to external storage, even though user has granted the permissions. The only writable path on API 29+ is context.getExternalFilesDir(), which will return:
/storage/emulated/0/Android/data/your_app_package/files
You can use this path if you don't want to use Uri and stick with java.io.File.
If you want to save downloads into media file or public directory like Download, then you have to depend on Uri or java.io.OutputStream.
Yup, MediaStoreCompat is for media files only. For documents and other files, you can use DocumentFileCompat. Since Fetch uses java.io.File, I will assume that it does not support scoped storage yet. You had better creating an issue on Fetch to request scoped storage support for API 29+.

Are you saying to use something like this?
val documentFile = DocumentFileCompat.createFile(this, basePath = "Invigo App Documents", mimeType = "document/pdf")!!
documentFile.uri

Files stored in context.getExternalFilesDir()  get deleted after app uninstall if I am not mistaken, this is not something I would want. In terms of permissions none are needed for MediaStoreCompat file creating right? What about DocumentFileCompat

Are you saying to use something like this?
val documentFile = DocumentFileCompat.createFile(this, basePath = "Invigo App Documents", mimeType = "document/pdf")!!
documentFile.uri

Files stored in context.getExternalFilesDir()  get deleted after app uninstall if I am not mistaken, this is not something I would want. In terms of permissions none are needed for MediaStoreCompat file creating right? What about DocumentFileCompat

That's because you don't have URI permissions for read & write files. Please use this approach: https://github.com/anggrayudi/SimpleStorage#request-storage-access
Anyway, it's ok if you use MediaStoreCompat.createDownload. No URI permission is required, but you cannot resume downloads by using this method since you cannot check the downloaded file size.

That's because you don't have URI permissions for read & write files. Please use this approach: https://github.com/anggrayudi/SimpleStorage#request-storage-access
Anyway, it's ok if you use MediaStoreCompat.createDownload. No URI permission is required, but you cannot resume downloads by using this method since you cannot check the downloaded file size.

Do we really need full disk access to enable this feature.. seems not a great user experience, surely we just want downloads folder access.. I have not seen any apps yet ask me to pick a folder like this. What do you thing would be a better UX?
Have you seen what apps like WhatsApp and Telegram do? they have their own folders in the filesystem and then they create subfolders for their content inside there, these folders are persistent over app reinstalls, is this no longer permissible with SAF?

Do we really need full disk access to enable this feature.. seems not a great user experience, surely we just want downloads folder access.. I have not seen any apps yet ask me to pick a folder like this. What do you thing would be a better UX?
Have you seen what apps like WhatsApp and Telegram do? they have their own folders in the filesystem and then they create subfolders for their content inside there, these folders are persistent over app reinstalls, is this no longer permissible with SAF?

Once you select Download folder via SimpleStorage's SAF, implicitly you have granted URI for read & write access. Let user pick Download folder once, then you will have full disk access under this directory.

Once you select Download folder via SimpleStorage's SAF, implicitly you have granted URI for read & write access. Let user pick Download folder once, then you will have full disk access under this directory.

Thanks for your help, got what I needed to work, will continue exploring SimpleStorage :)

Thanks for your help, got what I needed to work, will continue exploring SimpleStorage :)

Ok so I have given the access as in the example, and still getting null here ...
val documentFile = DocumentFileCompat.createFile(this, basePath = "Invigo App Documents/doc${ts}.pdf", mimeType = "application/pdf")!!

Ok so I have given the access as in the example, and still getting null here ...
val documentFile = DocumentFileCompat.createFile(this, basePath = "Invigo App Documents/doc${ts}.pdf", mimeType = "application/pdf")!!

Use this code to check if you have access to Invigo App Documents. It should be non-null if the folder is writable.
val writable = DocumentFileCompat.getAccessibleRootDocumentFile(context, buildAbsolutePath(PRIMARY, "Invigo App Documents"), requiresWriteAccess = true) != null

DocumentFileCompat.createFile() returns null if the folder is not writable.

Use this code to check if you have access to Invigo App Documents. It should be non-null if the folder is writable.
val writable = DocumentFileCompat.getAccessibleRootDocumentFile(context, buildAbsolutePath(PRIMARY, "Invigo App Documents"), requiresWriteAccess = true) != null

DocumentFileCompat.createFile() returns null if the folder is not writable.

What if I just wanted to create a file in the Environment.DIRECTORY_DOCUMENTS and then write to its uri.
I tried (after giving access) this:
DocumentFileCompat.fromPublicFolder(this, PublicDirectory.DOWNLOADS, subFile = "doc${ts}.pdf", requiresWriteAccess = true)
however this returns null (it does not return null if I omit the subFile parameter, but then I am unclear on how and where to name the file)

What if I just wanted to create a file in the Environment.DIRECTORY_DOCUMENTS and then write to its uri.
I tried (after giving access) this:
DocumentFileCompat.fromPublicFolder(this, PublicDirectory.DOWNLOADS, subFile = "doc${ts}.pdf", requiresWriteAccess = true)
however this returns null (it does not return null if I omit the subFile parameter, but then I am unclear on how and where to name the file)

DocumentFileCompat.from...() returns null if you have no URI access. You had better cloning this project and test the code on your own. I will close this issue since the discussion becoming more complex and I have no much time to teach you.

DocumentFileCompat.from...() returns null if you have no URI access. You had better cloning this project and test the code on your own. I will close this issue since the discussion becoming more complex and I have no much time to teach you.


response code is 200 but response body is null

my main.py is
from fastapi import FastAPI, Request, Depends
from pydantic import BaseModel
import models
from sqlalchemy.orm import Session
from database import SessionLocal, engine
from models import product
app=FastAPI()
models.Base.metadata.create_all(bind=engine)
def get_db():
try:
db=SessionLocal()
yield db
finally:
db.close()
@app.get('/')
def index():
pass
@app.get('/products/{id}')
def get_product(id: int):
db=SessionLocal()
stock= db.query(models.product).filter(models.product.id == id).first()
return stock
# return pr.product_name ,pr.product_price,tenure,tenure*pr.product_price

and database.py is
from sqlalchemy import create_engine
from sqlalchemy.ext.declarative import declarative_base
from sqlalchemy.orm import sessionmaker
SQLALCHEMY_DATABASE_URL = "sqlite:///./product.db"
engine = create_engine(
SQLALCHEMY_DATABASE_URL, connect_args={"check_same_thread": False}
)
SessionLocal = sessionmaker(autocommit=False, autoflush=False, bind=engine)
Base = declarative_base()
and models.py is
from sqlalchemy import  Column, ForeignKey, Integer, String
from database import Base
class product(Base):
tablename = "products"
id = Column(Integer, primary_key=True, index=True)
product_name = Column(String, unique=True, index=True)
product_price= Column(Integer)

can you modify
db=SessionLocal() --> db = get_db() and give it a try?
this would work.

can you modify
db=SessionLocal() --> db = get_db() and give it a try?
this would work.

stock= db.query(models.product).filter(models.product.id == id).first()
this line it shows
AttributeError: 'generator' object has no attribute 'query'

stock= db.query(models.product).filter(models.product.id == id).first()
this line it shows
AttributeError: 'generator' object has no attribute 'query'

solved

solved

posting the solution about how you solved it would be better..
my suggestions:
@app.get('/products/{id}')
def get_product(id: int, db: Session = Depends(get_db)):
    stock= db.query(models.product).filter(models.product.id == id).first()
    return stock

or
if you are using some function(not an api)  and that function is interacting with database...
def get_sample( db: Session = Depends(get_db)):
    """some crud operation"""

posting the solution about how you solved it would be better..
my suggestions:
@app.get('/products/{id}')
def get_product(id: int, db: Session = Depends(get_db)):
    stock= db.query(models.product).filter(models.product.id == id).first()
    return stock

or
if you are using some function(not an api)  and that function is interacting with database...
def get_sample( db: Session = Depends(get_db)):
    """some crud operation"""

This maybe a long shot but can someone post the solution. I’m having the exact same issue with fast api.

This issue opening is a bunch of unformatted code without any question or issue in it. Somehow, someone did found what was wrong with it (kudos to him) and posted that solution in the comment above yours. This is a very specific user-error; it might be that the docs were not up to standards as they are now back then, but without any errors, there is little to go on here.

thanks for the feedback. i'm goign to open another issue then and see if i can get some help.


submitTransaction should use base64 to submit transaction, not hex

Question on this one: It looks like the docs call for a hex-encoded string: http://stellar.github.io/go-horizon/endpoint/transactions_create/
Should that be updated as well?

@pletcher definitely.  We just haven't made another pass on the docs yet.
The issue in go-horizon: https://github.com/stellar/go-horizon/issues/58


Installing .net core 2.2 SDK

Problem encountered on https://dotnet.microsoft.com/download/linux-package-manager/debian9/sdk-current
Operating System: Linux Debian 9 - x64
Provide details about the problem you are experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
The following error I received
Unable to loacate package dotnet-sdk-2.2

More info is needed, what was the output when you installed the version?, What did you type when the error was shown?

@meemwebsolutions have you performed the steps under "Register Microsoft key and feed"? The package is pulled from this feed.

Closing this out; please provide more info and re-open if you haven't been able to resolve this.


Research how to send the file

Related to #4

@OkanKocabalkanli

ZeroMQ might be worth looking into as well

This seems like a promising project
https://webrtc.github.io/samples/src/content/datachannel/filetransfer/

This too: https://peerjs.com/


Can't create an account through the Cosmos Extension

Repro steps:
1.) Either right click a subscription or ctrl + shift+ p and create a new account
2.) Type a valid account name
3.) Hit enter
4.) Nothing happens-- try again
5.) All names appear invalid
Action: cosmosDB.createAccount
Error type: Error
Error Message: {"name":"Error","message":""}
Version: 0.6.0
OS: win32

This seems to be happening with version 0.5.1 as well.

Thanks for catching this.

just hit this...glad to see it's already fixed. Thanks!

We'll be releasing the fix "real soon". In the meantime I'm afraid the portal is the only work-around.


PHOENIX-6523: Support for HRpc connection protocol through JDBC URL

HBase now supports a zookeeper-less connection strategy using a Master Registry implementation. For this to work through Phoenix, we need to set a list host:ports of the HMaster quorum
<property>
   <name>hbase.masters</name>
   <value>master1:16000,master2:16001,master3:16000</value>
</property>

To support opting into this from a Phoenix connection URL, we can introduce a "connector type" as follows:
jdbc:phoenix+zk:hostname1,2,3...:<properties>
jdbc:phoenix+hrpc:hostname1,2,3...:<properties>

Above are examples of opting into hrpc/zk registry implementations of HBase.
If no connector is specified, the Phoenix driver will default to a Zookeeper-based connection as it's always been doing prior to this. If an invalid connector type is specified, we throw a MalformedUrlException, similarly if there's a + char but the connector type is empty.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 22s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
21m 37s
master passed

+0
hbaserecompile
28m 38s
HBase recompiled.

+1 :green_heart:
compile
1m  2s
master passed

+1 :green_heart:
checkstyle
1m 15s
master passed

+1 :green_heart:
javadoc
0m 52s
master passed

+0 :ok:
spotbugs
3m  7s
phoenix-core in master has 973 extant spotbugs warnings.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 31s
root in the patch failed.

+0
hbaserecompile
9m 58s
HBase recompiled.

-1 :x:
compile
0m 20s
phoenix-core in the patch failed.

-1 :x:
javac
0m 20s
phoenix-core in the patch failed.

-1 :x:
checkstyle
1m 16s
phoenix-core: The patch generated 24 new + 737 unchanged - 15 fixed = 761 total (was 752)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 50s
the patch passed

-1 :x:
spotbugs
0m 19s
phoenix-core in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 19s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

52m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1280

JIRA Issue
PHOENIX-6523

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux 823e64d1ba6c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / c4d297d

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

mvninstall
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt

javac
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/testReport/

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
24m 13s
master passed

+0
hbaserecompile
31m 12s
HBase recompiled.

+1 :green_heart:
compile
1m  5s
master passed

+1 :green_heart:
checkstyle
1m 13s
master passed

+1 :green_heart:
javadoc
0m 51s
master passed

+0 :ok:
spotbugs
3m 26s
phoenix-core in master has 973 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
16m 53s
the patch passed

+0
hbaserecompile
27m 22s
HBase recompiled.

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

-1 :x:
checkstyle
1m 14s
phoenix-core: The patch generated 33 new + 727 unchanged - 25 fixed = 760 total (was 752)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 51s
the patch passed

+1 :green_heart:
spotbugs
3m 38s
the patch passed

_ Other Tests _

-1 :x:
unit
117m 50s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

190m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1280

JIRA Issue
PHOENIX-6523

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux 5da2aa6dfc67 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / c4d297d

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/3/testReport/

Max. process+thread count
11607 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  1s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
21m 57s
master passed

+0
hbaserecompile
28m 49s
HBase recompiled.

+1 :green_heart:
compile
1m  2s
master passed

+1 :green_heart:
checkstyle
1m 14s
master passed

+1 :green_heart:
javadoc
0m 51s
master passed

+0 :ok:
spotbugs
3m  7s
phoenix-core in master has 973 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
13m 30s
the patch passed

+0
hbaserecompile
25m 52s
HBase recompiled.

+1 :green_heart:
compile
1m  3s
the patch passed

+1 :green_heart:
javac
1m  3s
the patch passed

-1 :x:
checkstyle
1m 14s
phoenix-core: The patch generated 20 new + 735 unchanged - 17 fixed = 755 total (was 752)

-1 :x:
whitespace
0m  0s
The patch 2 line(s) with tabs.

+1 :green_heart:
javadoc
0m 49s
the patch passed

+1 :green_heart:
spotbugs
3m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
119m 13s
phoenix-core in the patch passed.

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

186m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1280

JIRA Issue
PHOENIX-6523

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux edf46d24c8ec 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / c4d297d

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-general-check/output/whitespace-tabs.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/4/testReport/

Max. process+thread count
7332 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/4/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 45s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
24m 27s
master passed

+0
hbaserecompile
36m 48s
HBase recompiled.

+1 :green_heart:
compile
1m  7s
master passed

+1 :green_heart:
checkstyle
1m 11s
master passed

+1 :green_heart:
javadoc
0m 54s
master passed

+0 :ok:
spotbugs
3m 30s
phoenix-core in master has 973 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
16m 41s
the patch passed

+0
hbaserecompile
33m  6s
HBase recompiled.

+1 :green_heart:
compile
1m  3s
the patch passed

+1 :green_heart:
javac
1m  3s
the patch passed

-1 :x:
checkstyle
1m 13s
phoenix-core: The patch generated 29 new + 725 unchanged - 27 fixed = 754 total (was 752)

-1 :x:
whitespace
0m  0s
The patch 2 line(s) with tabs.

+1 :green_heart:
javadoc
0m 52s
the patch passed

+1 :green_heart:
spotbugs
3m 31s
the patch passed

_ Other Tests _

-1 :x:
unit
116m 43s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

206m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1280

JIRA Issue
PHOENIX-6523

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux 119635c75cbf 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / c4d297d

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/5/artifact/yetus-general-check/output/whitespace-tabs.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/5/testReport/

Max. process+thread count
12703 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/5/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

jdbc:phoenix+zk:hostname1,2,3...:<properties>
jdbc:phoenix+hrpc:hostname1,2,3...:<properties>

What is "hrpc" supposed to stand for in this case? I would think "masters" or "registry" might be more clear?
I think the problem here is that @bharathv built the "default" implementation to be pluggable. While this is nice, do we have any expectations to support any possible mechanism? It would be helpful (for me, a reviewer) to understand what is in scope and what's out of scope. I'm assuming you don't want to try to support any registry, but it might be a good idea to keep that in mind so as to not code ourselves into a corner.

to understand what is in scope and what's out of scope

The scope right now is to support HBase registry if specified or else always default to ZK. I think the most important thing here is to ensure there's no regression to existing connections. This HRpc thing should be treated as an opt-in, else we should preserve the same behaviour as before.

I'm assuming you don't want to try to support any registry, but it might be a good idea to keep that in mind so as to not code ourselves into a corner.

I think using some OOP to clean the classes up as you suggested is a good foundation to set for other registries down the road

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
24m 19s
master passed

+0
hbaserecompile
31m 26s
HBase recompiled.

+1 :green_heart:
compile
1m  8s
master passed

+1 :green_heart:
checkstyle
1m 15s
master passed

+1 :green_heart:
javadoc
0m 52s
master passed

+0 :ok:
spotbugs
3m 20s
phoenix-core in master has 972 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
16m 36s
the patch passed

+0
hbaserecompile
27m 14s
HBase recompiled.

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

-1 :x:
checkstyle
1m 20s
phoenix-core: The patch generated 36 new + 735 unchanged - 17 fixed = 771 total (was 752)

-1 :x:
whitespace
0m  0s
The patch 2 line(s) with tabs.

+1 :green_heart:
javadoc
0m 57s
the patch passed

+1 :green_heart:
spotbugs
4m 11s
the patch passed

_ Other Tests _

-1 :x:
unit
122m  8s
phoenix-core in the patch failed.

-1 :x:
asflicense
0m 34s
The patch generated 5 ASF License warnings.

200m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1280

JIRA Issue
PHOENIX-6523

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux edb51fb2019d 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / bfc4621

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/6/artifact/yetus-general-check/output/whitespace-tabs.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/6/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/6/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/6/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
11315 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/6/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
24m 13s
master passed

+0
hbaserecompile
31m 58s
HBase recompiled.

+1 :green_heart:
compile
1m  5s
master passed

+1 :green_heart:
checkstyle
1m 16s
master passed

+1 :green_heart:
javadoc
0m 52s
master passed

+0 :ok:
spotbugs
3m 20s
phoenix-core in master has 972 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
16m 46s
the patch passed

+0
hbaserecompile
27m 37s
HBase recompiled.

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

-1 :x:
checkstyle
1m 14s
phoenix-core: The patch generated 35 new + 735 unchanged - 17 fixed = 770 total (was 752)

-1 :x:
whitespace
0m  0s
The patch 2 line(s) with tabs.

+1 :green_heart:
javadoc
0m 53s
the patch passed

+1 :green_heart:
spotbugs
3m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
118m  2s
phoenix-core in the patch passed.

-1 :x:
asflicense
0m 14s
The patch generated 5 ASF License warnings.

190m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1280

JIRA Issue
PHOENIX-6523

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux ba856428ad27 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / bfc4621

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/7/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/7/artifact/yetus-general-check/output/whitespace-tabs.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/7/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/7/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
10727 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/7/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 54s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
30m  3s
master passed

+0
hbaserecompile
39m 23s
HBase recompiled.

+1 :green_heart:
compile
1m  5s
master passed

+1 :green_heart:
checkstyle
1m 15s
master passed

+1 :green_heart:
javadoc
0m 54s
master passed

+0 :ok:
spotbugs
3m 22s
phoenix-core in master has 972 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
16m 49s
the patch passed

+0
hbaserecompile
29m 49s
HBase recompiled.

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

-1 :x:
checkstyle
1m 16s
phoenix-core: The patch generated 35 new + 735 unchanged - 17 fixed = 770 total (was 752)

-1 :x:
whitespace
0m  0s
The patch 2 line(s) with tabs.

+1 :green_heart:
javadoc
0m 51s
the patch passed

+1 :green_heart:
spotbugs
3m 32s
the patch passed

_ Other Tests _

-1 :x:
unit
116m 15s
phoenix-core in the patch failed.

-1 :x:
asflicense
0m 34s
The patch generated 5 ASF License warnings.

205m 54s

Reason
Tests

Failed junit tests
phoenix.end2end.UpsertSelectIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1280

JIRA Issue
PHOENIX-6523

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux 43818037d335 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 9dfb423

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/8/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/8/artifact/yetus-general-check/output/whitespace-tabs.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/8/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/8/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/8/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
11682 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/8/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 56s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
24m  2s
master passed

+0
hbaserecompile
31m  7s
HBase recompiled.

+1 :green_heart:
compile
1m  5s
master passed

+1 :green_heart:
checkstyle
1m 14s
master passed

+1 :green_heart:
javadoc
0m 52s
master passed

+0 :ok:
spotbugs
3m 23s
phoenix-core in master has 972 extant spotbugs warnings.

-0 :warning:
patch
3m 32s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
16m 44s
the patch passed

+0
hbaserecompile
27m  5s
HBase recompiled.

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

-1 :x:
checkstyle
1m 14s
phoenix-core: The patch generated 36 new + 735 unchanged - 17 fixed = 771 total (was 752)

-1 :x:
whitespace
0m  0s
The patch 4 line(s) with tabs.

+1 :green_heart:
javadoc
0m 51s
the patch passed

+1 :green_heart:
spotbugs
3m 30s
the patch passed

_ Other Tests _

-1 :x:
unit
161m 56s
phoenix-core in the patch failed.

-1 :x:
asflicense
0m 14s
The patch generated 5 ASF License warnings.

237m 53s

Reason
Tests

Failed junit tests
phoenix.mapreduce.util.PhoenixConfigurationUtilTest

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/9/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1280

JIRA Issue
PHOENIX-6523

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux 8979c3c1e2f9 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 19b2260

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/9/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/9/artifact/yetus-general-check/output/whitespace-tabs.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/9/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/9/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/9/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
432 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/9/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Looking at the code, I'd expect PhoenixEmbeddedDriver.ConnectionInfo.normalize() to fail for Hrpc connections.
Could you add an Integration Test to check that the Hrpc connections work (i.e. starting a  minicluster and connecting to it with HRPC) ?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 53s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
21m 22s
master passed

+0
hbaserecompile
28m  3s
HBase recompiled.

+1 :green_heart:
compile
1m  5s
master passed

+1 :green_heart:
checkstyle
1m 15s
master passed

+1 :green_heart:
javadoc
0m 51s
master passed

+0 :ok:
spotbugs
3m  6s
phoenix-core in master has 972 extant spotbugs warnings.

-0 :warning:
patch
3m 15s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
13m 25s
the patch passed

+0
hbaserecompile
23m 12s
HBase recompiled.

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

-1 :x:
checkstyle
1m 15s
phoenix-core: The patch generated 48 new + 734 unchanged - 18 fixed = 782 total (was 752)

-1 :x:
whitespace
0m  0s
The patch 4 line(s) with tabs.

+1 :green_heart:
javadoc
0m 52s
the patch passed

-1 :x:
spotbugs
3m 21s
phoenix-core generated 1 new + 972 unchanged - 0 fixed = 973 total (was 972)

_ Other Tests _

-1 :x:
unit
161m 45s
phoenix-core in the patch failed.

-1 :x:
asflicense
0m 16s
The patch generated 7 ASF License warnings.

230m 39s

Reason
Tests

FindBugs
module:phoenix-core

Class org.apache.phoenix.jdbc.MalformedUrlException is not derived from an Exception, even though it is named as such  At MalformedUrlException.java:from an Exception, even though it is named as such  At MalformedUrlException.java:[lines 8-15]

Failed junit tests
phoenix.mapreduce.util.PhoenixConfigurationUtilTest

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1280

JIRA Issue
PHOENIX-6523

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux 03f2c05daf9d 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / f606289

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/whitespace-tabs.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
486 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I moved Registry context to a separate package. I think it covers @joshelser's ask of starting to clean up the PhoenixEmbeddedDriver. It's an in-between to where we want to be ideally (@stoty as you pointed out here) vs what we can do now realistically.
Created a class called EmbeddedDriverContext to pass between the EmbeddedDriver and the Registry classes. I tagged in comments with the 🥴 emoji places where the context is passed back and forth (unnecessarily perhaps) - so let me know if we should make any changes there.
I think an integration test would really help here so I'm going to get started on that.
CC: @dbwong @yanxinyi @virajjasani @apurtell

A havily modified version of this already been merged.
I suggest closing this one, @ramatronics .


Build some additional public functions for Plugins

From @martindsouza on March 28, 2014 1:32
To enhance Issue #46 Add some functions/procedures that will help other users. One example is an apex data dump procedure that will append all APEX items to the end of the extra column.
Copied from original issue: tmuth/Logger---A-PL-SQL-Logging-Utility#60

Moved to Future. Need a compelling reason to create some 3rd party plugins. Right now the example in the docs highlights how to use plugins.


CS:Function: Should final score be multiplied by 10?

Final CS subscore is 10 * calculation, but the definition does not include the 10 * is this correct?

confimed


Update quick-start to use Assert.ThrowsException

In Walkthrough: Test-driven development using Test Explorer, replaces try/catch pattern with Assert.ThrowsException.

#sign-off

Learn Build status updates of commit 1c07459:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/test/quick-start-test-driven-development-with-test-explorer.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@Mikejo5000
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Evangelink
Note that you can open this PR in the private repo, visualstudio-docs-pr, where you can sign off on PRs you create.
Thanks!

@Evangelink
It doesn't. I just wanted to let you know that it was an option since you had signed off on this PR.

@AbhitejJohn Can you take a look at this one, also?


Expression statement conversion

Fixes https://github.com/microsoft/typespec/issues/3499
The idea here is to not have a Statement when all it does is append ; to the corresponding Expression.  Snippets should return the Expression if the invoked method returns a value and should return a statement if the invoked method returns a void.
I added a Terminate method to ValueExpression and TypedSnippet to easily convert to a statement which simply appends the ;.  This is not an implicit cast since many Expressions cannot be terminated so I wanted to make this something we do explicitly.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Microsoft.Generator.CSharp


Deactivated user compose error state does not clear when recipient is changed

Repro:

Attempt to send a PM to a deactivated user.
An error message is correctly displayed:

Change the recipient to a valid one without closing the compose box.

Expected: It should now be possible to send a message. Ideally, the error banner would disappear.
Actual: The error banner remains and nothing seems to happen when one tries to send the message (via keyboard or "Send" button).

@zulipbot claim

@alya I am working trying to reproduce the bug. How do I find or get the deactivated user?

@zulipbot claim

@zulipbot claim

@evykassirer is this issue still present following your compose_banner project?

Yes, the banner project was almost entirely UI and not UX changes. There's a lot that can be improved with when banners disappear, and this is one of them.

If https://github.com/zulip/zulip/pull/23899 should resolve this issue, please note that in the PR / commit message. I think we should keep it open until the PR has bene merged.

Unassigning myself from this Issue to work on other Issues, since I have already raised a PR and it is under review, will continue working on the PR for any required changes, Thanks.

Commenting here to inform you that I have an open PR for this issue. I'm not sure why I couldn't link my PR to this issue, even after correcting the PR description or commit description. In any case, I am providing the link to the PR for cross-referencing.
#23899

@zulipbot claim

Hey @alya, this issue is no longer reproducible.


Add this as a resource or community if not already present

https://www.techxlab.org/solutions/categories/covid19/ventilator/

done


Broken Link

> Introduction to Azure Security section that has "State of the art Data Center" the link is broken, navigates to a page not found.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ce94e95d-f2df-72de-66d0-56930547ee98
Version Independent ID: 8d258a24-3bd7-dd4e-db41-9cfea8d077ee
Content: Introduction to Azure security
Content Source: articles/security/fundamentals/overview.md
Service: security
Sub-service: security-fundamentals
GitHub Login: @unifycloud
Microsoft Alias: TomSh

@anchowd
Thanks for your feedback! We will investigate and update as appropriate.

Hi @anchowd ,
The link works just fine for me. If you're still seeing issues feel free to make a pull request to fix it.
Here is the correct link: https://azure.microsoft.com/en-us/global-infrastructure/
Thanks,
Marilee
CC: @unifycloud-llc


feed.xml

Currently I see you have the feed.xml sitting outside the source directory. Is this desired, or is it just in the wrong place?

Nope, it was unintentional. Good catch! :+1:


admin, records, schema, manage, metrics

Purpose of this pull reques
Select the type of change:

[ ] Migration and Minor Changes - Typos, formatting, slight revisions

parsing ref and more


Obsolete implementation of JSON-RPC Protocol

Should be align with the actual JSON RPC API version.

@sorpaas and it's also up to you to change impl., jsonrpc works good, but a little bit magic, you can reimpl. directly with Hyper, for example.

@dulanov So this issue is for the Ethereum JSON-RPC, right?

It's our own API, but it was inspired from personal geth module and from another Ethereum JSON RPC methods.

It's #108 then? Okay. jsonrpc is an RPC client. Definitely that needs to get changed because now we're implementing an RPC server.
I think I'll continue to use serde_derive with some generic functions and, as you mentioned, Hyper. Hopefully it can save some LoC.

(Thought you meant SputnikVM's jsonrpc... Anyway, I think Parity's jsonrpc magic would work fine for us now. I'll continue to use the current design.)

Ok, good.

@dulanov I'm thinking about change all IoBuilder::add_async_method to IoBuilder::add_method for now. Will this work or do you have any concern in this?
We're not taking advantage of any futures feature -- all current calls just directly call futures::finished or futures::error. So I don't think we speed things up by using async methods. By doing this, I can also remove the macros and use try! and question mark syntax to handle everything.

I think you are right, yes.

@dulanov Do you mind to change those RPC calls that contains more than one optional parameters to use a struct instead? For example, right now emerald_newAccount is [account, passphrase, chain/chain_id]. If we change this to [{"account":.., "passphrase":.., "chain":..}], that would make everything a lot easier.
Right now, it would require to enumerate all the possibilities (even if we parse Vec<Value> one by one, it would require the same technique to deal with edge cases). But if those optional parameters are tagged, then there would be no way to misplace those arguments.

But there is one RPC call - emerald_signTransaction, and it may takes up to a minute, so better to impl. as async call.


Added option to make grunt-runner panel hidden on start

This looks great! @nickclaw please publish a new version


Failed at the sqlite3 3.1.3 install script

node v4.2.4
npm v1.4.3
Failed at the<EMAIL_ADDRESS>install script

I fixed this by switching down versions to 4.2.0


Deploy Your First SAPUI5 App

Tutorials: https://developers.sap.com/tutorials/appstudio-sapui5-create.html
The generators now feature the option to add a managed AppRouter - so there is no need to manually add an AppRouter after you have created the project.
I have also noticed that after you create a project, there is no message displayed to open the workspace. Once you open the workspace manually (using the File Menu) it opens the project. However, the project doesn't build correctly.
Apparently the Fiori MTA module and its dependencies are not consistent with NodeJS version installed on Business Application Studio. I am getting the following error while trying to run #npm install @ the project's root folder:

<EMAIL_ADDRESS>install /home/user/projects/sapui5/node_modules/keytar
prebuild-install || npm run build
prebuild-install WARN install libsecret-1.so.0: cannot open shared object file: No such file or directory

It seems that the current dependencies require a newer version of NodeJS.
I've managed to update nodejs to version 12 and npm to version 7 and the above error goes away completely.
However, I've also seen messages related to updating NodeJS on BAS and SAP has discouraged this procedure as it has unknown side-effects.
Could you please review this?
Best regards,
Ivan

Hi @ivanmir ,
Why did you need to run npm install?
I followed the tutorial and it worked well.
Perhaps it's because the node.js version in BAS was recently updated to 14.
Regards - Raz

Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue.
If you still have questions and want to continue the conversation, feel free to reopen the issue.


typed errors overhaul for Parser

Fixes # .
Motivation
continuing from this PR: https://github.com/coinbase/rosetta-sdk-go/pull/102
and this PR: https://github.com/coinbase/rosetta-sdk-go/pull/129
we want to use named errors in the SDK to improve the debugging experience
this PR also includes some minor changes in /keys
Solution
added errors.go and an ErrParser() function to check if an error was thrown by the parser
Open questions

Pull Request Test Coverage Report for Build 5962

69 of 88 (78.41%)  changed or added relevant lines in 3 files are covered.
37 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.2%) to 79.305%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

parser/errors.go
16
17
94.12%

parser/match_operations.go
39
57
68.42%

Files with Coverage Reduction
New Missed Lines
%

parser/match_operations.go
2
79.68%

fetcher/construction.go
5
0%

asserter/construction.go
8
94.12%

asserter/server.go
22
86.09%

Totals

Change from base Build 5889:
-0.2%

Covered Lines:
3265

Relevant Lines:
4117

💛  - Coveralls


Is it possible to change the Radio Button Drawable for the Single Choice List Dialog?

Hello!
First, thank you for this great library :)
I am using this snippet to make a simple single choice list dialog
new MaterialDialog.Builder(this)
        .title(R.string.title)
        .items(R.array.items)

Was wondering if its possible for me to change the Radio button drawable? or do I need to make my own adapter? The single choice is perfect for my requirements but just would like to change the drawable of the radio button to my own selector
Thank you for reading !

You'd see it in the documentation if it was possible.
I'm guessing AppCompat has an attribute you can add  your Activity theme to change it everywhere though.


More work on scope maps

Specifically, rework continuation handling to generalize it for top-level code declarations.

@swift-ci please smoke test and merge


AutoRestSchemaFilter for enums - in 3.0?

I'm not sure if this counts as a documentation bug or I should close & ask on SO? But AutoRestSchemaFilter in the readme.md - the "enums as strings" one - no longer works with the 3.0 changes.
I need to new up an implementation of IOpenApiExtension as an argument -I'm not sure what would work?

I apologise - with a search I found https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/1ecfc8e5e881d07a8a1bf008fcbd73778a79e2ea/README-v5.md


⚠ PrivateHD has degraded performance

In 412e537, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 3453 ms

Resolved: PrivateHD performance has improved in 8fe9984.


Feature/tm sconverer

TMS reco/matching merge

I pushed the fixes that make this work with the newly-merged SAND branch

Is someone working on the most major of the comments above?

@cjbackhouse I plan to address them either today or over the weekend. I agree with all the above comments for what it's worth.
Faiza is updating the track matcher so I'll wait for her and let you know

Branch is now updated with a few additions:

Remove TF1 reliance and instead just use arithmetic with doubles
Update matching code to propagate the LAr track into the first layer of the TMS and do the residual on that point, instead of propagating both tracks into the dead region between the TMS and LAr. This removes reliance on the TMS unit vector for calculating the residual; the TMS unit vector can sometimes be unreliable because a straight line is a bad parameterisation of the track in the TMS due to the bending
Make TMS use cm as default unit for distances; LAr already does this and TMS was using mm. Also update the track matching code to know about this.

Found some bugs during this; the LAr direction vectors appear to be corrupted. Hence the matching calculates the line in LAr by using start and end points of the LAr track rather than the saved direction vector. This should be updated when the LAr unit vectors are fixed.

I think we are in a position to merge this (the ND-LAr bug above is not related to anything in this repo and will be fixed next time we respin).  @clarenc3  would you do the honors?

Turns out @clarenc3 is ✈ today, so I hereby invoke the merge. 🪄


Lost all connections to raspmatic

I agree to the following

[X] I have read the documentation
[X] I am aware of the latest release notes
[X] The Backend (CCU/Homegear/...) is working as expected and connected devices are controllable by its own UI.
[X] I am running the latest version of the custom_component (and Home Assistant)

The problem
Hi
After i updated to ->1.34.2 HOMEMATICIP_LOCAL-Interface not reachable All Devices
If i try to connect again in settings -> no connection
There is a other IP now in the Settings from hahomematic?! <IP_ADDRESS>
I tried to changed it back to the Hostname from raspberrymatic. Not Working.
After  Full Backup restore from Yesterday Hahomematic get also no connection. Same Problem. Also after multible Reboots.
Raspberrymatic is working. No Problems. Only the HomeMatic RS485 Gateway crashes after few hours. But this is a other issue...
Thx
What version of HomematicIP (local) has the issue?
1.34.2
What was the last working version of HomematicIP (local)?
1.34.1
What type of installation are you running?
Home Assistant OS
What type of installation are you running for your homematic backend?
RaspberryMatic Standalone
Which version of your homematic backend are you running?
<IP_ADDRESS>30407
What hardware are you running for your system?
Pi4
Which config details do you use

[x] Username and password
[ ] TLS
[ ] callback data (see)

Which interfaces do you use?

[x] Homematic IP
[x] Homematic (Bidcos-RF)
[x] Groups (Heating-Group)
[x] BidCos-Wired (HM-Wired)

Diagnostics information
home-assistant_2023-04-25T03-27-20.089Z.log
supervisor_2023-04-25T03-28-41.691Z.log
de838cd8_raspberrymatic_2023-04-25T03-28-30.031Z.log
Anything in the logs that might be useful for us?
No response
Additional information
No response

Use the hostname de838cd8_raspberrymatic as described in the installation instructions.

I used the de838cd8_raspberrymatic. After update i checked the configs and the there was the ip.
i tried to changed it back to de838cd8_raspberrymatic but it show error "no connection"
I fixed it now. i put the hass port 8123 in the firewall config from raspberrymatic.
after then i put the de838cd8_raspberrymatic back in the config and now it works.


How was debian_data.csv generated?

The raw data includes a file called debian_data.csv. Are the scripts to generate this data public as well? Also, it seems that debian_data.csv is not in sync with the vulnerables.json and non-vulnerables.json files: the keyword PEM_def_callback appears in non-vulnerables.json, but does not appear in debian_data.csv at all.

I also wanto know!


First cut at dependency refactor.

Bagit dependency changed to utilize current release stream from https://github.com/LibraryOfCongress/bagit-python via PyPi. BDBag-specific changes are handled via subclassing and function overloading. There is some code duplication here, and certain parts will need to be kept synchronized with upstream. However, this seems like a more practical approach than trying to maintain a separate fork for a relatively small set of code tweaks.
Profile validation via bagit_profile has been completely internalized with a fork based on the latest code from https://github.com/ruebot/bagit-profiles-validator. This code is pretty static so maintenance should not be a huge issue.

Works well here! All tests pass as well.


Add Spanish RVR version

As a Spanish speaker developer
I want to be able to consult the spanish RVR version of the Bible
So that I can develop an app to share the Bible with people who speaks Spanish

Done


Revert moving index.[ios|android].js.

Issue: See https://github.com/storybooks/storybook/issues/1200
What I did
Moved index.js -> index.[ios|android].js. (It didn't seem possible to make the files import index.js, I ran into this problem: https://github.com/facebook/react-native/issues/6282, maybe you aren't allowed to register components from an imported file? IDK).
How to test
Follow the steps in #1200, but using npm link-ed CLI

Interesting, it didn't have the bug when I did it that way. I think maybe when I tried to make it index.js rather than storybook.js with the same content, the problem was there. Or maybe it was just RN being weird? Hopefully this works.


Close card if user tries to interact with the map

Users seem to try to close the card in may ways by trying to interact with the map.

Current close-by-tap is good enough.


queuetools mass actions should hide things if the setting is enabled

You're right.  Words mean things and 'hide' on mod 'action' means exactly that, regardless of it's an action on 1 or 100 items.


Nested Smart Components (SSR)

What problem does this feature solve?
Introduction
Separation of concerns is important, that's why we always try to encapsulate data and logic inside independent smart components reusable throughout the application. Smart Components usually perform asynchronous operations like data fetching and they can be nested inside each other.
Problem
Currently the SSR solution proposed by the vue-hackernews-2.0 example requires all asynchronous operations to be performed in the asyncData hook, which unfortunately is only available to route-components registered in the router. This makes route-components become "super-smart" as they take responsibility for all the data of all underlying "dumb" components and doesn't allow for any smart component to be placed beneath a route-component. During SSR the server-side renderer won't wait for any nested smart component to finish their asynchronous work.
Desired Behavior
The server-side renderer should wait for all root child components to resolve recursively, hence let every active*  smart component attain its renderable state.
Benefits
Not only does this feature allow for better code structuring and seamless SSR support, it is also extremely helpful in this kind of situations where the layout of the application needs to be computed programmatically. Think of content management system were one would be able to compose the final layout of the single-page application by simply putting together independent arbitrary building blocks on top of a template.
Smart Components & APIs
Smart components are served best in combination with GraphQL. Every little smart component asks the GraphQL client for a small part of the graph the API server has to offer. It only fetches the data it needs, no more, no less. The GQL client will batch all those little queries into one big query every 10ms or so and fire them. This way smart components make modular architecture a piece of cake!
* We define components as "active" when they are in the actual context of execution. Inactive components are hidden due to certain application state conditions like the current route for example.
What does the proposed API look like?
API Proposal
We should be able to make any component smart, regardless of where it's placed in the application. Basically this means making the asyncData hook available to any component and not just the route-components.
Then it just becomes a classical dependency tree problem, where out of the tree of components we compose a flat dependency tree filtering out all of the dumb components resulting in an array of Promises the SSR needs to await before finally rendering the page.
Performance Considerations
Because traversing the component tree on every SSR request seems inefficient - this step should probably be done by Webpack at compile time.

Seems this should be doable in "user land". Let's assume you're making a regular HTTP requests to a "REST-like" API.
You can make "smart components" with a global mixin, which looks for a given key on your component. At the same time it makes the request, it simply adds the request to array, and attaches that array to the SSRContext. Then you simply do Promise.all and you're done.
Moving to GraphQL, assuming you're using vue-apollo, it seems it already supports something like this with willPrefetch (check the docs)

This is really doable in userland. We already have async component support. What you need to wrap is a smart loader function or so.
function smartLoad(asyncComp: Promise<Component>) {
  return asyncComp.then(comp => comp.default)
             .then(comp => comp.asyncData ? comp.asyncData().then(_ => comp) : comp)
}

// usage
new Vue({
  components: {async: smartLoad(import('./my-ascyn.vue'))}
})

FYI this should be resolved by https://github.com/vuejs/vue/pull/9017. Closing to track in that PR.


Move all docs to ReST

Also makes the ORD docs landing page a bit more useful...

Gentle ping...

Gentle ping...


Update No Mercy Window to Prioritise Double Down

Updated No Mercy window to prioritise Double Down (DD) over Blast Strike (BS) + Hypervelocity (HV).

DD has a single target potency of 1200 (and cumulatively more over multiple targets) for 2 carts over two BS / HV combos which totals 1120.
DD is also a single GCD compared to BS 2 GCDs, meaning additional potency gained for that extra action.

Discuss.

I don't think a one size fits all for No Mercy is a good idea considering GNB now has 3 different windows for it.

What do you mean 3 different windows for it? As far as I'm aware in all windows (maybe minus the opener) you would still want to fit 9 GCDs in, you still want a Gnashing combo, Sonic Break, Blasting Zone, Bow Shock and 1 / 2 Rough Divides as before. The only difference I see is you want Double Down rather than Blast Strike, which is also on a 60 cooldown same as No Mercy.
Unsure how this is more or less one size fits all than any recommendation or how it worked previously.
Please do correct me if I'm wrong.

Basically Bloodfest NM knocks out The first 3rd of a gnashing fang combo.
The other 2 non-Bloodfest windows are basically just hyper velocity or not though, so this approach would be fine for those.

To be honest, I take that image with a large grain of salt. The opener for example is not one I expect to stay like that and if that chances, chances are so do the NM windows. If we were to assume that that image is the only way to use NM, that's trying to fit into a one size fits all.
If we look at the analysis of some of the top DPS GNB on fflogs on the new extremes as examples, they for the most part still have full GF combos in all their NM windows and the one of two that don't seem to look like it was potentially a mistake or mechanic timing related.

Looked over the data from the top 20 pulls from the normals, the trend does seem to be still shoving GF under every NM.
Given it's just a 20 potency gain and is subject to fight timing, a general purpose one would work fine, I'm just overthinking things again.
Our General case though assuming 3 ammo to start and no combo started would have:

3 GF skills
sonic break,
double down
3 regular GCDs
1 burst strike (but no hyperVelocity in buffs)

Our general Bloodfest case though assuming 3 ammo to start and no combo started with Bloodfest off cooldown would have:

3 GF skills
sonic break,
double down
1-2 regular GCDs
3-4 burst strikes

I'm on mobile and have no idea how to leave a proper review,
But just re-add a burst strike to expected uses and adjust the Bloodfest evaluator to add 2 to the expected burst strikes so it expects 3 burst strikes and this should be good to merge in.


Config help

Sorry to ask.
I soldered. And installed the plugin. Im on HOOBS.
When I copy paste your Config sample down on the first page to my hoobs config.
Hoobs says cannot save, invalid JSON.
What am I doing wrong?

Can you give a full copy of your config with sensitive information redacted?

Sorry to disturb you. I use hoobs. Installed the plugin. And added your example config to accsessories [] i have soldererd the wires according to the pictures on the remote and inserted the wires on the rasperry pi 3 5 and 7 places.
I see the switch on hoobs and on homekit.
Nothing happens when i press the switch. If i press the buttons on the remote it works.
What am I missing?
Is there something more i should install? The depencies file? How?
Sent from my iPad

On 18. Mar 2021, at 11.55, Fred de Gier @.***> wrote:

Can you give a full copy of your config with sensitive information redacted?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Ok, so your invalid JSON error is now gone?
How does the remote get power? Only via battery?


Is this feature relevant to MongoDB and Gremlin or not?

[Enter feedback here]
The top of this page says "APPLIES TO:  NoSQL  MongoDB  Gremlin"
The Limitations at the end of the page says "API for MongoDB, Gremlin and Cassandra aren't supported at this time."
The two sections seem contradictory.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3b02fa2d-1579-5446-42fa-5a692aa345c0
Version Independent ID: 0c463897-404b-fc40-1f8e-217d7ebf73f7
Content: Custom partitioning in Azure Synapse Link for Azure Cosmos DB
Content Source: articles/cosmos-db/custom-partitioning-analytical-store.md
Service: cosmos-db
GitHub Login: @Rodrigossz
Microsoft Alias: rosouz

@asos-martinsmith Thank you for your feedback. We will check and get back shortly.

@Oury-MSFT @asos-martinsmith
It is in preview for Gremlin and MongoDB. Clarification is under way.
#please-close

https://github.com/Rodrigossz Thank you for clarifying.


fix for bugzilla https://issues.dlang.org/show_bug.cgi?id=14349

First pull request I've done. It's quite small.
fixes subpath's for windows (https://issues.dlang.org/show_bug.cgi?id=14349).
To my mind their shouldn't be any security issues with it since it disallows specifying drives and going up directories along with disallowing file server access (//server/share)

This allows using \ or / to specify a path starting from the root directory, which the existing disallows.

In the comment to safeSearchPath(), it lists two URLs describing path traversal attacks. This change has to be reviewed in the light of those documents.

Requires a test case.

So \\ is disallowed b/c that's root (C:) on Windows, right?
Why do you disallow //, is it also interpreted as root?

WalterBright said:

This allows using \ or / to specify a path starting from the root directory, which the existing disallows.

duly noted and fixed, latest commit should disallow \ or / at the start of a path.
WalterBright said:

In the comment to safeSearchPath(), it lists two URLs describing path traversal attacks. This change has to be reviewed in the light of those documents.

I will try to find a suitable replacement for those documents.
MartinNowak said:

So \ is disallowed b/c that's root (C:) on Windows, right?
Why do you disallow //, is it also interpreted as root?

The reason for disallowing // and \\ is to prevent access to any local file server.
windows is lax with its slashes so in practice \\ and // satisfies for local file server access.

I will try to find a suitable replacement for those documents.

Thank you. Since this is a security issue, this needs a thorough review of what best secure practices are here before modifying the algorithm.

Path traversal attacks seem irrelevant here since the user running the compiler already has access to all files on the system and the compiler is unable to send a file out of the system.
I really have to dream up extraordinary situations for an attacker to benefit from this at all. Like maybe a build server that takes code in and spits executables out... but why would somebody offer such a server to the public? Why would anybody want to use such a service, given how easily it could inject malicious code in the program it returns? It's just not a realistic scenario.

So getting creative, maybe a malicious library could read some sensitive file unbeknowst to the user, who then runs the program and it gets served up... but if you run the program, it can just load the file ordinarily! Well, perhaps you compile and run as different users, or on different machines.
But that's the only possible attack vector I can think of... and it is kinda far fetched. A malicious library has far easier things it could do - it is, after all, arbitrary code that the user is running. The compile is the least scary part.

Any updates on this?

Auto-merge toggled on

thx

Auto-merge toggled off

Disabling auto-merge since the windows tests remain broken and will require changes to fix which should be re-reviewed.

Disabling auto-merge since the windows tests remain broken and will require changes to fix which should be re-reviewed.

Isn't auto-merge toggled off automatically when new commits are pushed?

Isn't auto-merge toggled off automatically when new commits are pushed?

No.  It used to be.

Afaict https://github.com/dlang/dmd/pull/5337 replaces this PR and was merged, so I'm closing this. Reopen if I was wrong, please. Thanks.


Linear and Logistic Regression clone parameters

Currently the methods to return the parameters look like this:
pub fn parameters(&self) -> Option<Vector<f64>> {
    match *self.base.parameters() {
        Some(ref p) => Some(p.clone()),
        None => None,
    }
}

It would be more appropriate to return an &Option<Vector<f64>>. This would allow the user to control when to clone the data. The new methods will look like this:
pub fn parameters(&self) -> &Option<Vector<f64>> {
    &self.parameters
}

Wouldn't it be better to return a Option<&Vector<f64>> since we don't actually want to share the option but rather data if available? This has also the charm of allowing the user to clone with .cloned() instead of .unwrap().
pub fn parameters(&self) -> Option<&Vector<f64>> {
    self.parameters.as_ref()
}

I think you're right! This does indeed seem like a cleaner solution to me.
We should probably adopt this same pattern in a few other places where I am currently returning &Option<T>. I believe this is only in the learning module (within model code).

I would try to find these places and make a single PR to change all of them including the ones mentioned in this issue. Ok?

Awesome! Thanks.


Add sefaria integration

Add a verse/selection picker using sefaria's api

Maybe a build step that fetches js data from sefaria's index, filters the category of Tanakh.
By using Sefaria's api, I can get more texts in the future and ensure proper ordering