chore(deps): update grafana/grafana docker tag to v9.3.2 (dev)

This PR contains the following updates:

Package
Update
Change

grafana/grafana
patch
9.3.1 -> 9.3.2

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will now ignore this update (9.3.2). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


add basic support for async-io

As discussed in #39, this adds basic support for async-io based async runtimes like async-std and smol. Couple of notes:

I did not add a direct constructor, instead relying on TryFrom<CanSocket/CanFdSocket>. This could be added easily though.
I did not add a method to get back to the synchronous socket, partially because I haven't figured out how to do that yet.
I pretty much only ported the read and write functionality, since setting socket options is not possible asynchronously on Linux. To maintain access to the different setup methods, I give access to the inner socket via as_sync_socket methods.
Instead of using the mem::zeroed-based approach when reading, I actually went with the MaybeUninit strategy, which I believe to be sound. However, I can go back to the zeroed version used for the synchronous read operations. Now just using the synchronous methods.

Thanks for any feedback!

I noticed, after looking at the corresponding tokio code for a little while, that I don't actually need to reimplement the read logic at all.. I'll push an update this evening.

Rebased and cleaned up.

Oh, also, just FYI:

Instead of using the mem::zeroed-based approach when reading, I actually went with the MaybeUninit strategy, which I believe to be sound. However, I can go back to the zeroed version used for the synchronous read operations.

I realize you pulled this out from the PR, but in general, it's a standard practice in socket programming to zero out structs like socket addresses, an then just fill in the needed fields, knowing the rest are zero.
But you are right that MaybeUninit would be fine for reading in frames, since a successful read is certain to fill the whole struct.

BTW... I'm a little unsure of keeping the macro in the long run:

It's somewhat confusing to save just few lines of code.
It's considerably different than the way the other two socket families (tokio, blocking) are implemented, and I would like to remain consistent.


[Epic] Destinations support

Integrate with SAP BTP Destination service to cover the functionality provided by xshttpdest

[x] #866
[x] #880
[x] #899
[x] #900
[x] #1041

This issue is closed as the project is no longer maintained


[production] Download Button Missing on File Renderer

Behavior:
On (seemingly) one specific file, there is no download button on the file renderer page:

The file is here: https://osf.io/bu3mr/
There IS a download button on the file tab:

I thought this may be related to files too large to display in the browser, but I have found both .jpg files (https://osf.io/k5bcg/) and another .pdf (https://osf.io/9xf6j/) too big to display, but both show the download button.
Console displays this error when loading the file render page:
"Uncaught SyntaxError: Unexpected token ILLEGAL"

JS Errors in the MFR need to not break knockout. I wonder if there's an easy way to handle that (such as by modifying load order or similar).

No, I take it back, that's not the problem.
<script>
    $script(['/static/addons/osfstorage/storageRevisions.js'], function() {
        var revisionTable = new RevisionTable(
            '#revisionScope',
            'Tracing the Evolution of Starless Cores in a Molecular Cloud Simulation:
Comparisons with JCMT Data and Predictions for ALMA',

On the last like there, between the colon and Comparisons is a unicode line break (\u2028) that is not being handled, so the javascript is being broken.

I believe this will be fix with @lyndsysimon's Mako Safe HTML, but I have to look into it a bit more to be sure. That or we just have to sanitize the string. Since it's javascript in the source code, though, I'm fairly certain it's a Mako thing.

FYI, Mako Safe HTML will be pulled from 0.23 and will go shortly after 0.23 as a dot release or into 0.24 targeted for end of month-ish.

Checked on https://osf.io/bu3mr/. This problem doesn't exist anymore.


How can i use the pool

the api does not has the pool

With mongojs you're already using the pool. The mongodb driver module behind mongojs (mongodb) opens a pooled connection which is used in the background my mongojs

@gclinux you should close this ticket... :P


INSTA_UPDATE=always cargo test with an incorrect inline snapshot passes

What happened?
with a test like:
    #[test]
    fn test_inline() {
        insta::assert_snapshot!(3 + 2, @"");
    }

... running INSTA_UPDATE=always cargo test gives:
error: cannot update inline snapshots in-place (https://github.com/mitsuhiko/insta/issues/272)
test tests::test_inline ... ok

But then returns a zero exit code
Arguably this should return a non-zero exit code, to indicate the snapshots are not correct
Reproduction steps
No response
Insta Version
1.38
rustc Version
1.77.2
What did you expect?
No response

I would like to fix this by implementing inline snapshot updates without the need of cargo-insta. See #490


feat(shared): all platforms to use shared vault-k8s chart

Description
As a developer i want to a have a single chart in under shared folder for vault k8s job used by fabric and corda-ent platform
Acceptance Criteria

Fabric and Corda-ent platform using shared vault k8s chart

I will check this.


List of implementing interfaces with generics

Hi,
I use @Inject in combination with a List<MyInterface<Type>> to inject all implementors of this interface. Avaje seems to ignore the generics and fails to compile with "No dependency provided".
If a PR is ok please let me know.
Thanks
Markus

Yes, a PR would be great.


Updated filter bar to match more closely to the mockup

Fixes #227 @zackkrida
Fixes #226 @zackkrida
Description
Change list:

[x] Filter heading sized down
[x] Filter heading spacing updated
[x] "Filter results by" and "hide filters" headings are now vertically centered
[x]  Removed horizontal dividers between filters
[x] Updated help icons with new SVGs
[x] Increased checkbox sizes
[ ] Did not complete optional and related: [Feature] Use CSS accent-color for UI control styling #222
[x] Fixed related hover button style issue #226: "Clear Filters" button was made larger and hover style was updated to fit the mockup grey color.

Technical details
Changed the "show results" button to match the "clear filters" button size.
Screenshots
Updated filter bar

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

I didn't notice that the package-lock.json file had 42,374 line changes! Does anyone have any idea what might have caused this? I don't believe I edited the package-lock.json file manually at all.  I can't see the specific changes as there is a limit.

@DillonKyleDev maybe you're using a version of NPM that's different from the recommended one. We recommend Node.js v14 and NPM v7.
https://github.com/WordPress/openverse-frontend/blob/bfe72da38b4c36a852cf2266d491416fca5a26cd/package.json#L111
For now, you can check out package.json and package-lock.json from master and update the PR. Or you can reset your commits (mixed), update the code and force push to your branch.
I'll review the PR again once you've done this.

This is becoming a mess.  I apologize for all the commits and mistakes.  I have a lot to learn about git apparently!
I'm also unable to figure out how to change the CC icon size

:
Please forgive all of the rookie mistakes. I'll be on ASAP to get this all sorted.

@zackkrida Thank you for the kind words! And for the Small adjustments! haha

In the future we will have improved guidelines and styling consistency to make this work easier.

Awesome! Thanks for all your help! :)


Add deletion of bucket stats during bucket delete

Prior to this change, bucket deletion would not trigger a deletion of
the bucket-related stats from the db which would result in leaving
redundant data in the db. This path modifies the bucket_delete flow to
include a cleaning of the relevant stats from the db.
Fixed: #6212
Signed-off-by: Barak Sason Rofman<EMAIL_ADDRESS>

please squah


Notebooks card updates

Some feedback on the notebooks cards- they are unusable compared to list view because the names get clipped off. We should:

Remove the jupyter logo
Wrap the notebook-name title text
Order the list alphabetically instead of last updated

Matt and Nicole have asked us to move to list view by default. That's a separate matter. Here, we're improving the cards view.

Can take this opportunity to move to the new notebooks card design (minus the icon):
https://projects.invisionapp.com/d/main#/console/16562871/343437622/preview

Card view was updated to match the old mocks and solve the aforementioned problems.
Removal of the card view entirely is coming in the future: see #1272.


Add telemetry when python terminal REPL is used

Use Shell Integration to detect when python terminal REPL is used.

Will attempt to use:
		 * Creates a stream of raw data (including escape sequences) that is written to the
		 * terminal. This will only include data that was written after `read` was called for
		 * the first time, ie. you must call `read` immediately after the command is executed via
		 * {@link TerminalShellIntegration.executeCommand} or
		 * {@link window.onDidStartTerminalShellExecution} to not miss any data.
		 *
		 * @example
		 * // Log all data written to the terminal for a command
		 * const command = term.shellIntegration.executeCommand({ commandLine: 'echo "Hello world"' });
		 * const stream = command.read();
		 * for await (const data of stream) {
		 *   console.log(data);
		 * }
		 */
		read(): AsyncIterable<string>;
``` from https://github.com/microsoft/vscode/blob/main/src/vscode-dts/vscode.proposed.terminalShellIntegration.d.ts
to read() right after executing Terminal REPL launch commands.

Verification step:

Install latest pre-release Python extension version.
Set your log level to Trace
Make sure Python extension is activated and go open a new terminal
Type Python to launch your Python REPL
Go to Extension telemetry log output and make sure y

ou see the telemetry event getting fired with "...replType:Terminal" such as:


'beet fields' output should be sorted

Output would be easier to read if it were sorted.  Currently it appears as

$ beet fields
Item fields:
  lyrics
  disctitle
  month
  channels
  disc
  mb_trackid
  composer
  albumartist_sort
  bitdepth
  title
  mb_albumid
  acoustid_fingerprint
  rg_album_gain
  mb_releasegroupid
  rg_album_peak
  albumartist_credit
  acoustid_id
  format
  encoder
  rg_track_gain
  day
  original_year
  artist
  mb_albumartistid
  bpm
  artist_credit
  grouping
  disctotal
  album_id
  albumstatus
  mtime
  original_day
  albumartist
  year
  albumdisambig
  samplerate
  id
  album
  mb_artistid
  media
  artist_sort
  comments
  tracktotal
  rg_track_peak
  catalognum
  added
  original_month
  asin
  track
  comp
  initial_key
  genre
  path
  bitrate
  language
  country
  script
  label
  length
  albumtype
  singleton
  filesize
  data_source

Album fields:
  disctotal
  albumstatus
  month
  original_day
  albumartist
  year
  albumdisambig
  albumartist_sort
  id
  album
  asin
  script
  mb_albumid
  label
  rg_album_gain
  mb_releasegroupid
  artpath
  rg_album_peak
  albumartist_credit
  catalognum
  added
  original_month
  comp
  genre
  day
  original_year
  language
  mb_albumartistid
  country
  albumtype
  path
  albumtotal
  path
  data_source

I was planning on working on this one when I got home tonight but you beat me to it.  Was that ever fast. : )

Fixed in #1402.


Closes issue #174 and issue #189: Remove 2nd definition from 'aggrega…

…te of organizations' and create new money and money-related terms with defintions and labels.

Some issues I see:
No term editor annotation on new classes
No contributor annotations on new classes
OBO suggests (I think strongly but not required): example of usage annotation, editor preferred term annotation
I do not know if they want editor preferred term different from rdfs:label

They don't make any mention of an rdfs:label, just an editor preferred term, which they define as "a unique, unambiguous label for the term in American English" (Source). I'm currently working on adding an example of usage, term editor, and contributor annotation to each new class.

Sorry for not being clear.  ROBOT makes sure everything's got an
rdfs:label.  That is a must, even if it's not explicitly written down
somewhere.
My only point was does the rdfs:label have to be different from the editor
preferred?  If not, then add editor preferred term to all classes.  You
could instead make them more wordy to be more precise.
On Wed, Aug 24, 2022 at 5:31 PM Matthew Diller @.***>
wrote:

They don't make any mention of an rdfs:label, just an editor preferred
term, which they define as "a unique, unambiguous label for the term in
American English" (Source
https://github.com/jamesaoverton/obo-tutorial/blob/master/docs/ontology-development.md).
I'm currently working on adding an example of usage, term editor, and
contributor annotation to each new class.
—
Reply to this email directly, view it on GitHub
https://github.com/ufbmi/OMRSE/pull/190#issuecomment-1226402880, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJR55V6MNJSZSEQQBAQPKTV22IEFANCNFSM57NEZFGA
.
You are receiving this because your review was requested.Message ID:
@.***>

That's what I mean: they don't specify what the annotation has to be (e.g., rdfs:label or IAO:editor-preferred-term) and they use "label" and "editor preferred term" interchangeably.

rdfs:label is important because it's what is use for display in programs like Protege and many more. ROBOT report complains if it is not present.
'editor preferred label' is not required, but is used by many projects such as IAO and OBI. It can be the same as rdfs:label, and it often is. The advantage to having both is that downstream users may want/need to change the rdfs:label to adapt terms to their use case, while the 'editor preferred label' stays the same as the (upstream) source ontology. For example, in a tree view where the ancestry is visible and space is at a premium, a shorter rdfs:label can be more clear than a verbose label.

James, thank you so much for the clarification.  That info is extremely
helpful.
On Wed, Aug 24, 2022 at 6:13 PM James A. Overton @.***>
wrote:

rdfs:label is important because it's what is use for display in programs
like Protege and many more. ROBOT report complains if it is not present.
'editor preferred label' is not required, but is used by many projects
such as IAO and OBI. It can be the same as rdfs:label, and it often is.
The advantage to having both is that downstream users may want/need to
change the rdfs:label to adapt terms to their use case, while the 'editor
preferred label' stays the same as the (upstream) source ontology. For
example, in a tree view where the ancestry is visible and space is at a
premium, a shorter rdfs:label can be more clear than a verbose label.
—
Reply to this email directly, view it on GitHub
https://github.com/ufbmi/OMRSE/pull/190#issuecomment-1226487849, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJR55U3KY73XDHRTHUUJS3V22NB7ANCNFSM57NEZFGA
.
You are receiving this because your review was requested.Message ID:
@.***>

@hoganwr  and I reviewed this together and determined it was ready to merge.


Compatibility with Julia 0.4

Is there any estimated timeline for upgrading this package to be compatible with Julia 0.4x?

My tests show that it is compatible with 0.4. Do you mean 0.5?

It was for 0.4.
I was getting both warnings and errors after trying to move to 0.4.  Will double check update steps.

On Jan 8, 2016, at 1:28 AM, Eric Davies<EMAIL_ADDRESS>wrote:
My tests show that it is compatible with 0.4. Do you mean 0.5?
—
Reply to this email directly or view it on GitHub.

There are currently known warnings, but there shouldn't be any errors. Please file an issue if you encounter an unexpected error :)

I had a look at this issue when I was unable to load PostgreSQL.jl:
               _
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: http://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.4.4-pre+35 (2016-02-12 13:21 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit 1a9429e (38 days old release-0.4)
|__/                   |  x86_64-linux-gnu

julia> using PostgreSQL
ERROR: LoadError: ArgumentError: DBI not found in path
 in require at ./loading.jl:233
 in include at ./boot.jl:261
 in include_from_node1 at ./loading.jl:304
 in require at ./loading.jl:243
while loading /home/mike/.julia/v0.4/PostgreSQL/src/PostgreSQL.jl, in expression starting on line 11

It didn't take too much work for me to conclude that the problem was one of missing the header files for libpq.  Fixing this (on an Ubuntu Linux machine) was a matter of installing the libpq-dev package:
julia> using PostgreSQL

julia>

I have no idea whether this particular issue is what's troubling @gbarz but decided to add this comment in case it is helpful.

Should this be closed by now..? I hope since I did: https://github.com/JuliaDB/PostgreSQL.jl/pull/43

Yeah, especially as there was no specific issue mentioned here.


Keeping numbers at the start of union cases is invalid syntax with ReScript

export type Test = "1" | "2";

is converted to
@@uncurried
@@warning("-27-32-33-44")
open RescriptCore
open Ts2ocaml
module Test = {
  type t =
    | @as("1") 1
    | @as("2") 2
}
module Export = {
  module Test = Test
}

Which is not allowed and causes At this point, I'm looking for an uppercased name like Belt or Array
I'm using ReScript 11.1.0-rc.3 and ts2ocaml 2.0.0-beta.2

@Programmerino Thank you for trying it out and reporting a bug! Do you happen to know what NPM package has a union type like this? (string enum with non-alphabet cases) The issue itself is trivial to fix but I would like to add it as a test package.

Sure! The issue was the translation of MemoryOption from https://github.com/firebase/firebase-functions/blob/master/src/v2/options.ts
The NPM package is firebase-functions, although I had a different problem with that project due to a dependency cycle, but I can open a separate issue for that.

Thank you! #394 looks like a more complicated issue, so I'll just merge #393 first and then take a close look at firebase-functions.


SC goes over the selected block area when moving a block, but clicking it does nothing

It might be more efficient to have switch control skip this screen, but I'm not sure that would work with voice over

I think this would break the voice over, so it's fine


Error on Lazy loading component section

The page loads for a moment then this error shows:
Cannot read property 'querySelectorAll' of null
URL:
https://learnnextjs.com/excel/lazy-loading-components/hello-dynamic-components
Screencast:
http://nimb.ws/OWrvSj

+1
The error occurs just because react-highlight hasn't supported React v16+ yet. To workaround this, see https://github.com/akiran/react-highlight/issues/39#issuecomment-334898100.

hey, I've found a solution for your issue, the thing is that react-highlight hasn't been updated to support<EMAIL_ADDRESS>someone made a patch, and his build is working but it's not merged yet.
So Imma call this a workaround based on a workaround, simply change the react highlight version in your package.json to briancappello/react-highlight#react-v16-compiled and npm install
your package.json should look like this:
{
  "name": "hello-next",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "dev": "next",
    "build": "next build",
    "start": "next start",
    "analyze": "cross-env ANALYZE=1 next build"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "dependencies": {
    "cross-env": "^5.0.1",
    "marked": "^0.3.6",
    "next": "^4.2.0",
    "react": "^16.2.0",
    "react-dom": "^16.2.0",
    "react-highlight": "briancappello/react-highlight#react-v16-compiled",
    "webpack-bundle-analyzer": "^2.8.3"
  }
}

https://github.com/arunoda/learnnextjs-demo/pull/35


Program output diff

We've got compiler output diff: would it be possible to get program output diff-mode as well please? I often find it very difficult to track minor changes in program output, and having a tool to assist in this regard would be splendid.

I was in the midst of filing a new issue for this, but found this one. Here's what I wrote:
Is your feature request related to a problem? Please describe.
It's not easy to see what changes occur to the binary as a result of changing the source code. One way to do it is to create two versions of the same function in one file and then visually compare the output, but it's not as easy as it could be.
Describe the solution you'd like
It would be great if the diff view supported diffing the output of two different files, not just two different compilers. Then it would be easy to visually compare the differences.

This feature is now live


Missing some named entities

Some named entities are missing from the entities-full.properties, specifically, those that translate to more than a single character (within the Basic Multilingual Plane, not the supplementary planes as described in #602).
For example, ⫽⃥ should be decoded into \u2AFD\u20E5.  See the chart here or its convenient JSON file.
This could probably be fixed at the same time as fixing #602.

Thanks for pointing this out. Fixed with  https://github.com/jhy/jsoup/commit/aa81e10c34f48a3c4ac7160aa90ee18af4f5c0c2


Update manifests/e/Eugeny/Tabby/1.0.166/Eugeny.Tabby.locale.en-US.yaml

Fixes an issue where this package has multiple different monikers
Microsoft Reviewers: Open in CodeFlow

[Policy] Reset Labels


Update RPi installation guide

Added how to configure, via Admin UI, real input from NMEA interfaces and the signalk-to-nmea0183 plug in.

👍
Hls Mats Ahlklo
+46 76 20 99 200

6 mars 2018 kl. 21:04 skrev Teppo Kurki<EMAIL_ADDRESS>Merged #453.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Build abstract and portable SIMD using xsimd

Summary: This change replaces all Intel intrinsics with portable xsimd wrappers.  It only runs on AVX2 chips for now.  Subsequent changes will make it portable to SSE4.2 and NEON.
Differential Revision: D35579863

Below are some of the more representative benchmarks.  There are also some benchmarks with vectors but the operations are simple and the results are long so I did not include it here.  I did not find any benchmark for DWRF, but the operations are similar to Filter.  All the dispatches are static and can be inlined so I am not worried too much about the performance on AVX2.
Baseline:
$ buck run @mode/opt //velox/type/tests:velox_filter_benchmark
============================================================================
velox/type/tests/FilterBenchmark.cpp     relative  time/iter   iters/s
============================================================================
scalarDense                                                10.94ms     91.44
simdDense                                        166.8%     6.56ms    152.52
scalarSparse                                                2.96ms    337.70
simdSparse                                      204.12%     1.45ms    689.30

$ buck run @mode/opt //velox/exec/benchmarks:vector_hasher_benchmark
============================================================================
[...]/benchmarks/VectorHasherBenchmark.cpp     relative  time/iter   iters/s
============================================================================
computeValueIdsBigintNoNulls                                3.70ms    270.08
computeValueIdsBigintWithNulls                  12.652%    29.26ms     34.17
computeValueIdsIntegerNoNulls                               3.46ms    288.87
computeValueIdsIntegerWithNulls                 10.902%    31.75ms     31.49
computeValueIdsSmallintNoNulls                              2.59ms    386.02
computeValueIdsSmallintWithNulls                 8.179%    31.67ms     31.57
computeValueIdsDictionaryStrings                           88.11ms     11.35
computeValueIdsFlatStrings                       5.938%      1.48s   673.90m

New version:
$ buck run @mode/opt //velox/type/tests:velox_filter_benchmark
============================================================================
velox/type/tests/FilterBenchmark.cpp     relative  time/iter   iters/s
============================================================================
scalarDense                                                11.32ms     88.33
simdDense                                       169.76%     6.67ms    149.95
scalarSparse                                                3.13ms    319.22
simdSparse                                      222.47%     1.41ms    710.15

$ buck run @mode/opt //velox/exec/benchmarks:vector_hasher_benchmark
============================================================================
[...]/benchmarks/VectorHasherBenchmark.cpp     relative  time/iter   iters/s
============================================================================
computeValueIdsBigintNoNulls                                4.32ms    231.54
computeValueIdsBigintWithNulls                  13.523%    31.94ms     31.31
computeValueIdsIntegerNoNulls                               3.98ms    251.56
computeValueIdsIntegerWithNulls                  11.74%    33.86ms     29.53
computeValueIdsSmallintNoNulls                              2.86ms    349.33
computeValueIdsSmallintWithNulls                9.0541%    31.62ms     31.63
computeValueIdsDictionaryStrings                           91.70ms     10.91
computeValueIdsFlatStrings                       5.844%      1.57s   637.33m

I did not find any benchmark for DWRF (...)

I'm planning to add some micro-benchmark for dwrf encoding/decoding as part of the micro-benchmark CI tests. Will probably get to that sometime next week or so.

Hi Jimmy, per Orri's request I helped run some tests for this PR on my Intel chip Macbook. Here is what I got for velox_cache_test
SSD: Ssd cache IO: Write 1109MB read 631MB Size 0GB Occupied 0GB7K entries.
GroupStats:
[       OK ] AsyncDataCacheTest.ssd (21423 ms)
[----------] 4 tests from AsyncDataCacheTest (25355 ms total)
[----------] 1 test from SsdFileTest
[ RUN      ] SsdFileTest.writeAndRead
/Users/jtan6/git-repos/presto_cpp/velox/velox/common/caching/tests/SsdFileTest.cpp:201: Failure
Value of: ssdFile_->find(RawFileCacheKey{fileName_.id(), ssdSize}).empty()
Actual: true
Expected: false
/Users/jtan6/git-repos/presto_cpp/velox/velox/common/caching/tests/SsdFileTest.cpp:168: Failure
Value of: ssdPins.back().empty()
Actual: true
Expected: false
/Users/jtan6/git-repos/presto_cpp/velox/velox/common/caching/tests/SsdFileTest.cpp:168: Failure
Value of: ssdPins.back().empty()
Actual: true
Expected: false
/Users/jtan6/git-repos/presto_cpp/velox/velox/common/caching/tests/SsdFileTest.cpp:168: Failure
Value of: ssdPins.back().empty()
Actual: true
Expected: false
/Users/jtan6/git-repos/presto_cpp/velox/velox/common/caching/tests/SsdFileTest.cpp:168: Failure
Value of: ssdPins.back().empty()
Actual: true
Expected: false
/Users/jtan6/git-repos/presto_cpp/velox/velox/common/caching/tests/SsdFileTest.cpp:168: Failure
Value of: ssdPins.back().empty()
Actual: true
Expected: false
E20220502 11:43:35.497864 260736512 Exceptions.h:68] Line: /Users/jtan6/git-repos/presto_cpp/velox/velox/common/caching/SsdFile.cpp:182, Function:load, Expression: runSize >= entry->size()(1 vs. 4096) IOERR SSd cache entry shorter than requested range, Source: RUNTIME, ErrorCode: INVALID_STATE
unknown file: Failure
C++ exception with description "Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: (1 vs. 4096) IOERR SSd cache entry shorter than requested range
Retriable: False
Expression: runSize >= entry->size()
Function: load
File: /Users/jtan6/git-repos/presto_cpp/velox/velox/common/caching/SsdFile.cpp
Line: 182
Stack trace:
Stack trace has been disabled. Use --velox_exception_stacktrace=true to enable it.
" thrown in the test body.
[  FAILED  ] SsdFileTest.writeAndRead (10589 ms)
[----------] 1 test from SsdFileTest (10589 ms total)
[----------] 1 test from SsdFileTrackerTest
[ RUN      ] SsdFileTrackerTest.tracker
[       OK ] SsdFileTrackerTest.tracker (1 ms)
[----------] 1 test from SsdFileTrackerTest (1 ms total)
[----------] Global test environment tear-down
[==========] 8 tests from 4 test suites ran. (36013 ms total)
[  PASSED  ] 7 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SsdFileTest.writeAndRead
1 FAILED TEST

Hi @tanjialiang , can you try it on base version?  The code in SsdFileTest does not seem related to SIMD.

Jialiang just tried it. It does not work on main either.
From: Jimmy Lu @.>
Sent: Monday, May 2, 2022 12:17 PM
To: facebookincubator/velox @.>
Cc: oerling @.>; Review requested @.>
Subject: Re: [facebookincubator/velox] Build abstract and portable SIMD using xsimd (PR #1445)
Hi @tanjialiang https://github.com/tanjialiang  , can you try it on base version? The code in SsdFileTest does not seem related to SIMD.
—
Reply to this email directly, view it on GitHub https://github.com/facebookincubator/velox/pull/1445#issuecomment-1115266821 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPPPT5S2HIJWKIBNXX3F33VIASZ5ANCNFSM5TZB34XQ .
You are receiving this because your review was requested.Message ID: @.***>

It only runs on AVX2 chips for now.

Looks like I don't have AVX2 on my cpu:
 % sysctl -a | grep cpu.feat
machdep.cpu.feature_bits:<PHONE_NUMBER>971750911
machdep.cpu.features: FPU VME DE PSE TSC MSR PAE MCE CX8 APIC SEP MTRR PGE MCA CMOV PAT PSE36 CLFSH DS ACPI MMX FXSR SSE SSE2 SS HTT TM PBE SSE3 PCLMULQDQ DTES64 MON DSCPL VMX EST TM2 SSSE3 FMA CX16 TPR PDCM SSE4.1 SSE4.2 x2APIC MOVBE POPCNT AES PCID XSAVE OSXSAVE SEGLIM64 TSCTMR AVX1.0 RDRAND F16C

@mbasmanova Can you try change this line to echo -n "-msse4.2"?
https://github.com/facebookincubator/velox/pull/1667/files#diff-f010e02fb561bdf27a2fa520f811792399dc1df44e7e132a105580865a82d85eR108

Here is what I found.
Invocation of setup-helper-functions.sh in top-level CMakeLists.txt was failing silently leaving CMAKE_CXX_FLAGS variable being set to empty.
bash: ./scripts/setup-helper-functions.sh: No such file or directory
bash: get_cxx_flags: command not found
A workaround is to add ${CMAKE_SOURCE_DIR} to the script path:
execute_process(
COMMAND
bash -c
"( source ${CMAKE_SOURCE_DIR}/scripts/setup-helper-functions.sh; echo -n $(get_cxx_flags))"
OUTPUT_VARIABLE SCRIPT_CXX_FLAGS)
message("Setting CMAKE_CXX_FLAGS=${SCRIPT_CXX_FLAGS}")


Make spacebar trigger play/pause event

NOTE: I can't check now if I messed something up now -- I'm not at home. If you're meant to merge this PR, please consider testing the application or just wait few hours

Works great, thanks!


Add 'Adversary emulation' category

Hello!
I recently released https://github.com/DataDog/stratus-red-team. I created a category dedicated to "purple teaming / adversary emulation", moved Leonidas in there, and added GuardDuty tester as well
projects ordered by star count

cool! thanks @christophetd


fix(master): revert chat event names

simplifies command structure and loads only one set of events (faster)

they do not need to be separate as they are all mineflayer events


Failed to map segment from shared object

Hey,
While using your method, I encountered the following error:
postgres=# CREATE FUNCTION sys(cstring) RETURNS int AS '/tmp/pg_exec.so', 'pg_exec' LANGUAGE 'c' STRICT;
ERROR:  could not load library "/tmp/pg_exec.so": /tmp/pg_exec.so: failed to map segment from shared object: Permission denied

PostgreSQL version: 9.5.9.
Browsing the Internet, it looks like SELinux is installed and blocks the loading.
Did you get this error? Is there any workaround?
Thanks!
Regards.

It's actually blocked by SELinux.


Fix async update state

fixes write ha state, warn

Thanks. Looks like this warning was introduced in recently and I have yet to setup my units for the summer.
https://github.com/home-assistant/core/pull/91372


[image_picker] Image imported from Google Photos is missing Exif data

Using image_picker plugin, when I am selecting an image from Google Photo, the exif metadata is incomplete
     final pickedFile = await picker.getImage(source: widget.imageSource);     var r = await readExifFromFile(File(pickedFile.path));     debugPrint(r.toString());
Prints something like
  {Image Software: Google, Image ExifOffset: 46,   EXIF ExifVersion: 0220,   EXIF UserComment:,   EXIF ColorSpace: sRGB,   Interoperability InteroperabilityIndex: R98,   Interoperability InteroperabilityVersion: [48, 49, 48, 48],   EXIF InteroperabilityOffset: 356}
GPS information, as well as the date, for example, are missing from the exif metadata.
The image has exif data as I see it in the Google Photo application

~/source λ flutter doctor                                                                                ✘ 130
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 1.22.5, on Mac OS X 10.15.6 19G2021 darwin-x64, locale en-CA)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
[!] Android Studio
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
[!] Android Studio (version 4.1)
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] IntelliJ IDEA Ultimate Edition (version 2020.2.3)
[✓] VS Code (version 1.52.1)
[✓] Connected device (1 available)

! Doctor found issues in 2 categories.

Hi @arashbi
Thank s for filing the issue.
I do see a difference when picking Image from Gallery vs Google photos.
Google photos:
[  +19 ms] I/flutter (16692): {Software: Google}
Gallery:
{YResolution: 72.0, XResolution: 72.0, ImageWidth: 4000, Model: IN2011, ImageHeight: 3000, Make: OnePlus, YCbCrPositioning: 1, ExifIFDPointer: 209, Orientation: 1, ResolutionUnit: 2, DateTime: 2021:01:22 19:48:15, GPSInfoIFDPointer: 712, ExifVersion: 0220, ApertureValue: 1.61, SceneType: null, ExposureBias: -Infinity, ExposureProgram: Not defined, ColorSpace: 1, MaxApertureValue: 1.61, PixelYDimension: 3000, BrightnessValue: 0.0, DateTimeOriginal: 2021:01:22 19:48:15, FlashpixVersion: 0100, SubsecTimeOriginal: 000103, WhiteBalance: Auto white balance, InteroperabilityIFDPointer: 932, ExposureMode: 0, ExposureTime: 0.02, Flash: Flash did not fire, auto mode, SubsecTime: 000103, FNumber: 1.75, ISOSpeedRatings: 160, PixelXDimension: 4000, ComponentsConfiguration: YCbCr, FocalLengthIn35mmFilm: 0, SubsecTimeDigitized: 000103, DateTimeDigitized: 2021:01:22 19:48:15, ShutterSpeedValue: 5.643, MeteringMode: Pattern, FocalLength: 4.745, SceneCaptureType: Standard, LightSource: D65, SensingMethod: null, GPSLatitude:

complete runnable code sample
import 'dart:io';

import 'package:exifdart/exifdart_io.dart';
import 'package:flutter/material.dart';
import 'package:image_picker/image_picker.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  final picker = ImagePicker();

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: Container(
          child: Text('Hello World'),
        ),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () async {
          final pickedFile = await picker.getImage(source: ImageSource.gallery);
          print(pickedFile.path);
          var r = await readExifFromFile(File(pickedFile.path));
          debugPrint(r.toString());
        },
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (7 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • Taha’s iPad (mobile)       • 00008020-000255113EE8402E            • ios • iOS 14.3
    • iPhone 12 Pro Max (mobile) • DC25925E-876C-4CFE-A2F7-0640782D22A5 • ios • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)

! Doctor found issues in 1 category.

Thank you

Hi @arashbi
Thank s for filing the issue.
I do see a difference when picking Image from Gallery vs Google photos.
Google photos:
[  +19 ms] I/flutter (16692): {Software: Google}
Gallery:
{YResolution: 72.0, XResolution: 72.0, ImageWidth: 4000, Model: IN2011, ImageHeight: 3000, Make: OnePlus, YCbCrPositioning: 1, ExifIFDPointer: 209, Orientation: 1, ResolutionUnit: 2, DateTime: 2021:01:22 19:48:15, GPSInfoIFDPointer: 712, ExifVersion: 0220, ApertureValue: 1.61, SceneType: null, ExposureBias: -Infinity, ExposureProgram: Not defined, ColorSpace: 1, MaxApertureValue: 1.61, PixelYDimension: 3000, BrightnessValue: 0.0, DateTimeOriginal: 2021:01:22 19:48:15, FlashpixVersion: 0100, SubsecTimeOriginal: 000103, WhiteBalance: Auto white balance, InteroperabilityIFDPointer: 932, ExposureMode: 0, ExposureTime: 0.02, Flash: Flash did not fire, auto mode, SubsecTime: 000103, FNumber: 1.75, ISOSpeedRatings: 160, PixelXDimension: 4000, ComponentsConfiguration: YCbCr, FocalLengthIn35mmFilm: 0, SubsecTimeDigitized: 000103, DateTimeDigitized: 2021:01:22 19:48:15, ShutterSpeedValue: 5.643, MeteringMode: Pattern, FocalLength: 4.745, SceneCaptureType: Standard, LightSource: D65, SensingMethod: null, GPSLatitude:

complete runnable code sample
import 'dart:io';

import 'package:exifdart/exifdart_io.dart';
import 'package:flutter/material.dart';
import 'package:image_picker/image_picker.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  final picker = ImagePicker();

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: Container(
          child: Text('Hello World'),
        ),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () async {
          final pickedFile = await picker.getImage(source: ImageSource.gallery);
          print(pickedFile.path);
          var r = await readExifFromFile(File(pickedFile.path));
          debugPrint(r.toString());
        },
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (7 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • Taha’s iPad (mobile)       • 00008020-000255113EE8402E            • ios • iOS 14.3
    • iPhone 12 Pro Max (mobile) • DC25925E-876C-4CFE-A2F7-0640782D22A5 • ios • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)

! Doctor found issues in 1 category.

Thank you

I diged a little into this, even on the android plugin code, the image which is coming back from Intent doesn't have exif information.

I diged a little into this, even on the android plugin code, the image which is coming back from Intent doesn't have exif information.

I confirm: Imagesource.camera has EXIF data, Imagesource.gallery does not.
Worse: The returned filepath is from cache and does not allow to get file date from lastModified attribute.
Any idea on how to get the date the picture from gallery was taken is highly appreciated!

This issue is reproducible on the latest plugin version image_picker: ^0.8.7.
Using plugin sample code and checking Exif data (GPS for eg) on macOS (Open image > Info > GPS tab)
Demo

Original image data

image
gps data

Image picker image data:

image
gps data

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.7.7, on macOS 13.0.1 22A400 darwin-x64, locale en-EE)
    • Flutter version 3.7.7 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2ad6cd72c0 (10 hours ago), 2023-03-08 09:41:59 -0800
    • Engine revision 1837b5be5f
    • Dart version 2.19.4
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.76.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 110.0.5481.177

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.9.0-8.0.pre.19, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.9.0-8.0.pre.19 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d043c93e1a (2 hours ago), 2023-03-15 21:44:10 -0400
    • Engine revision 903ea2eabc
    • Dart version 3.0.0 (build 3.0.0-322.0.dev)
    • DevTools version 2.22.2
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.76.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (4 available)
    • SM T225 (mobile)       • R9JT3004VRJ                          • android-arm64  • Android 13 (API 33)
    • iPhone 14 Pro (mobile) • AB2EBB55-6852-40A7-9A12-057128370920 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-1 (simulator)
    • macOS (desktop)        • macos                                • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 111.0.5563.64

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

I have the same issue in my app. See the dup above.
I see that EXIF data is manually copied across from the source image to the image shipped back to the app, presumably because the image is optionally resized when picked. However not all EXIF fields are copied. This seems pretty silly.
https://github.com/flutter/packages/blob/main/packages/image_picker/image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ExifDataCopier.java
However in my case, the field I need (DateTime) is one of the fields that is supposed to be copied over (and is not), and a couple of other fields that are not copied over by ExifDataCopier are present. So I think this code path is not being triggered.
If the EXIF data is not present in the image being received via Intent from the Google Photos app, then it sounds like the bug is in Google Photos? How can we get the attention of the Google Photos team?

I am also facing the same issue,
i debugged the problem and found that:
IOS direct camera image have very less exif data:
here is the data from iphone 6s direct camera :
flutter: attributes flutter: {Flash: 16, DateTimeOriginal: 2023:12:21 16:21:08, SubsecTimeDigitized: 480, BrightnessValue: 2.5292306763649535, MeteringMode: 5, ExposureBiasValue: 0.0, FNumber: 2.2, FocalLength: 4.15, ShutterSpeedValue: 5.059470884046353, SubjectArea: [2015, 1511, 2217, 1330], ApertureValue: 2.2750070476914215, SceneType: 1, ColorSpace: 1, LensSpecification: [4.150000095367432, 4.150000095367432, 2.200000047683716, 2.200000047683716], PixelYDimension: 3024, WhiteBalance: 0, DateTimeDigitized: 2023:12:21 16:21:08, OffsetTimeOriginal: +01:00, ISOSpeedRatings: [125], OffsetTimeDigitized: +01:00, ExposureMode: 0, PixelXDimension: 4032, LensModel: iPhone 6s back camera 4.15mm f/2.2, OffsetTime: +01:00, ExposureProgram: 2, FocalLenIn35mmFilm: 29, SubsecTimeOriginal: 480, ExposureTime: 0.030303030303030304, SensingMethod: 2, Orientation: 6, LensMake: Apple}
Missing location data also

Any News on this topic ?
I have the same problem. I am getting GPS data if i pick from the external Picker, but not if i Pick from the new draggable picker.

The problem is not the plugin, it is how google photo works. It erases exif data from images for "security" reasons. I don't think there is anything can be done, except using google api to read the meta-data, which is not in the scope of this plugin.

@arashbi not true, the Flutter plug in strips the EXIF data. I read through the code to figure out what it was doing. I linked the code above. Please reopen this.

I opened the issue, but even if I download the image it doesn't have exif data.

That may or may not use the same API, so the web download behavior may or may not be related to the intent API behavior.
The thing to do would be set a breakpoint in the code I linked to above, and examine the incoming EXIF data directly, before it is further filtered. (I don't have time to work on this though...)


Json streaming parser

This PR is based on the same idea of #614, but it's using jsoniter library
Coverage is pretty good (around 92%, we're just not hitting some error branches) and the benchmark results speak for themselves:
name                                                                               old time/op    new time/op    delta
Unmarshal/string_data_v0.3-8                                                         26.5µs ± 0%     9.2µs ± 2%  -65.23%  (p=0.008 n=5+5)
Unmarshal/nil_data_v0.3-8                                                            24.4µs ± 1%    10.0µs ± 0%  -58.78%  (p=0.016 n=5+4)
Unmarshal/string_data_v1.0-8                                                         28.4µs ± 0%    10.9µs ±14%  -61.79%  (p=0.008 n=5+5)
Unmarshal/base64_json_encoded_data_v1.0-8                                            15.9µs ± 0%     6.5µs ± 3%  -59.30%  (p=0.008 n=5+5)
Unmarshal/struct_data_v0.3-8                                                         27.2µs ± 1%     9.5µs ± 2%  -65.10%  (p=0.008 n=5+5)
Unmarshal/struct_data_v1.0-8                                                         29.0µs ± 0%    10.4µs ± 2%  -64.22%  (p=0.008 n=5+5)
Unmarshal/data,_attributes_and_extensions_and_specversion_with_struct_data_v1.0-8    29.0µs ± 0%    11.6µs ± 3%  -60.14%  (p=0.008 n=5+5)
Unmarshal/base64_xml_encoded_data_v1.0-8                                             16.7µs ± 1%     7.8µs ± 4%  -53.31%  (p=0.008 n=5+5)
Unmarshal/nil_data_v1.0-8                                                            26.5µs ± 0%    11.9µs ± 1%  -55.04%  (p=0.008 n=5+5)
Unmarshal/data,_attributes_and_extensions_and_specversion_with_struct_data_v0.3-8    27.4µs ± 1%     9.8µs ± 2%  -64.19%  (p=0.008 n=5+5)

name                                                                               old alloc/op   new alloc/op   delta
Unmarshal/string_data_v0.3-8                                                         9.62kB ± 0%    5.17kB ± 0%  -46.25%  (p=0.008 n=5+5)
Unmarshal/nil_data_v0.3-8                                                            8.09kB ± 0%    4.96kB ± 0%  -38.64%  (p=0.008 n=5+5)
Unmarshal/string_data_v1.0-8                                                         9.62kB ± 0%    5.00kB ± 0%     ~     (p=0.079 n=4+5)
Unmarshal/base64_json_encoded_data_v1.0-8                                            5.37kB ± 0%    4.30kB ± 0%  -19.82%  (p=0.008 n=5+5)
Unmarshal/struct_data_v0.3-8                                                         9.67kB ± 0%    5.19kB ± 0%  -46.35%  (p=0.008 n=5+5)
Unmarshal/struct_data_v1.0-8                                                         9.67kB ± 0%    5.01kB ± 0%     ~     (p=0.079 n=4+5)
Unmarshal/data,_attributes_and_extensions_and_specversion_with_struct_data_v1.0-8    9.66kB ± 0%    6.46kB ± 0%  -33.20%  (p=0.008 n=5+5)
Unmarshal/base64_xml_encoded_data_v1.0-8                                             5.42kB ± 0%    4.32kB ± 0%  -20.23%  (p=0.008 n=5+5)
Unmarshal/nil_data_v1.0-8                                                            8.09kB ± 0%    4.96kB ± 0%  -38.64%  (p=0.008 n=5+5)
Unmarshal/data,_attributes_and_extensions_and_specversion_with_struct_data_v0.3-8    9.66kB ± 0%    6.45kB ± 0%  -33.21%  (p=0.008 n=5+5)

name                                                                               old allocs/op  new allocs/op  delta
Unmarshal/string_data_v0.3-8                                                            154 ± 0%        79 ± 0%  -48.70%  (p=0.008 n=5+5)
Unmarshal/nil_data_v0.3-8                                                               148 ± 0%        75 ± 0%  -49.32%  (p=0.008 n=5+5)
Unmarshal/string_data_v1.0-8                                                            154 ± 0%        77 ± 0%  -50.00%  (p=0.008 n=5+5)
Unmarshal/base64_json_encoded_data_v1.0-8                                               100 ± 0%        52 ± 0%  -48.00%  (p=0.008 n=5+5)
Unmarshal/struct_data_v0.3-8                                                            157 ± 0%        80 ± 0%  -49.04%  (p=0.008 n=5+5)
Unmarshal/struct_data_v1.0-8                                                            157 ± 0%        78 ± 0%  -50.32%  (p=0.008 n=5+5)
Unmarshal/data,_attributes_and_extensions_and_specversion_with_struct_data_v1.0-8       157 ± 0%        89 ± 0%  -43.31%  (p=0.008 n=5+5)
Unmarshal/base64_xml_encoded_data_v1.0-8                                                100 ± 0%        52 ± 0%  -48.00%  (p=0.008 n=5+5)
Unmarshal/nil_data_v1.0-8                                                               148 ± 0%        75 ± 0%  -49.32%  (p=0.008 n=5+5)
Unmarshal/data,_attributes_and_extensions_and_specversion_with_struct_data_v0.3-8       157 ± 0%        89 ± 0%  -43.31%  (p=0.008 n=5+5)

Plan for the followups:

Use this in bindings and throughout various protocols to unmarshal structured events
Try to implement the streaming writer using jsoniter Stream

To justify the need for streaming (and the related complexity) i tried jsoniter on the old json code (just replacing all imports of encoding/json with jsoniter) and the results (old = master code, no_streaming = old code but with jsoniter replacing encoding/json, new = this PR):
name \ time/op                                                                     old.txt      no_streaming.txt  new.txt
Unmarshal/string_data_v0.3-8                                                       26.5µs ± 0%       16.3µs ± 3%   9.2µs ± 2%
Unmarshal/nil_data_v0.3-8                                                          24.4µs ± 1%       16.1µs ± 1%  10.0µs ± 0%
Unmarshal/string_data_v1.0-8                                                       28.4µs ± 0%       19.3µs ± 1%  10.9µs ±14%
Unmarshal/base64_json_encoded_data_v1.0-8                                          15.9µs ± 0%       11.1µs ± 3%   6.5µs ± 3%
Unmarshal/struct_data_v0.3-8                                                       27.2µs ± 1%       18.1µs ± 1%   9.5µs ± 2%
Unmarshal/struct_data_v1.0-8                                                       29.0µs ± 0%       19.4µs ± 1%  10.4µs ± 2%
Unmarshal/data,_attributes_and_extensions_and_specversion_with_struct_data_v1.0-8  29.0µs ± 0%       19.5µs ± 2%  11.6µs ± 3%
Unmarshal/base64_xml_encoded_data_v1.0-8                                           16.7µs ± 1%       11.6µs ± 1%   7.8µs ± 4%
Unmarshal/nil_data_v1.0-8                                                          26.5µs ± 0%       17.9µs ± 1%  11.9µs ± 1%
Unmarshal/data,_attributes_and_extensions_and_specversion_with_struct_data_v0.3-8  27.4µs ± 1%       17.3µs ± 2%   9.8µs ± 2%

name \ alloc/op                                                                    old.txt      no_streaming.txt  new.txt
Unmarshal/string_data_v0.3-8                                                       9.62kB ± 0%       7.81kB ± 0%  5.17kB ± 0%
Unmarshal/nil_data_v0.3-8                                                          8.09kB ± 0%       6.31kB ± 0%  4.96kB ± 0%
Unmarshal/string_data_v1.0-8                                                       9.62kB ± 0%       7.81kB ± 0%  5.00kB ± 0%
Unmarshal/base64_json_encoded_data_v1.0-8                                          5.37kB ± 0%       4.57kB ± 0%  4.30kB ± 0%
Unmarshal/struct_data_v0.3-8                                                       9.67kB ± 0%       7.82kB ± 0%  5.19kB ± 0%
Unmarshal/struct_data_v1.0-8                                                       9.67kB ± 0%       7.83kB ± 0%  5.01kB ± 0%
Unmarshal/data,_attributes_and_extensions_and_specversion_with_struct_data_v1.0-8  9.66kB ± 0%       7.82kB ± 0%  6.46kB ± 0%
Unmarshal/base64_xml_encoded_data_v1.0-8                                           5.42kB ± 0%       4.75kB ± 0%  4.32kB ± 0%
Unmarshal/nil_data_v1.0-8                                                          8.09kB ± 0%       6.31kB ± 0%  4.96kB ± 0%
Unmarshal/data,_attributes_and_extensions_and_specversion_with_struct_data_v0.3-8  9.66kB ± 0%       7.81kB ± 0%  6.45kB ± 0%

name \ allocs/op                                                                   old.txt      no_streaming.txt  new.txt
Unmarshal/string_data_v0.3-8                                                          154 ± 0%          134 ± 0%      79 ± 0%
Unmarshal/nil_data_v0.3-8                                                             148 ± 0%          129 ± 0%      75 ± 0%
Unmarshal/string_data_v1.0-8                                                          154 ± 0%          134 ± 0%      77 ± 0%
Unmarshal/base64_json_encoded_data_v1.0-8                                             100 ± 0%           92 ± 0%      52 ± 0%
Unmarshal/struct_data_v0.3-8                                                          157 ± 0%          135 ± 0%      80 ± 0%
Unmarshal/struct_data_v1.0-8                                                          157 ± 0%          135 ± 0%      78 ± 0%
Unmarshal/data,_attributes_and_extensions_and_specversion_with_struct_data_v1.0-8     157 ± 0%          135 ± 0%      89 ± 0%
Unmarshal/base64_xml_encoded_data_v1.0-8                                              100 ± 0%           94 ± 0%      52 ± 0%
Unmarshal/nil_data_v1.0-8                                                             148 ± 0%          129 ± 0%      75 ± 0%
Unmarshal/data,_attributes_and_extensions_and_specversion_with_struct_data_v0.3-8     157 ± 0%          135 ± 0%      89 ± 0%


Implement statefulset stuck diagnosis

This pull request implement statefulset detail collector and statefulset stuck diagnosis.
https://github.com/kubediag/kubediag/issues/103

lgtm


Example/multiclass ecoc

@karlnapf Does it make sense to keep the legacy test though? Because it tests for all possible ecoc encoder/decoder combinations

@karlnapf Does it make sense to keep the legacy test though? Because it tests for all possible ecoc encoder/decoder combinations

I think what makes sense is to add one meta example for each of the combinations covered in the example

I think what makes sense is to add one meta example for each of the combinations covered in the example

Yes, I plan to do that, should I include all of them in this PR or separate ones?

You can do this PR. But wait until we are happy with the one you made here as then you dont need to change all files ... :)

Actually it looks good so you can create the other ones :)

thanks!
You used some specific API (I made comments). In general, stick to base class methods and use put/get

Okay, I'l make those changes, Will I need to update the data PR again, or just this PR?

You only need to update the data files if the numbers change. You will see that locally. I think they won't change if you do these changes.

Hi, I replaced it with the new API, I'm getting this error:
/home/tejsukhatme/shogun/build/examples/meta/cpp/multiclass/ecoc_discriminant_aed.cpp: In function ‘int main(int, char**)’:
/home/tejsukhatme/shogun/build/examples/meta/cpp/multiclass/ecoc_discriminant_aed.cpp:76:44: error: no matching function for call to ‘shogun::DynamicObjectArray::append_element(std::shared_ptr<shogun::SGObject>&, const char [7])’
 sg_storage->append_element(output, "output");
                                            ^
In file included from /home/tejsukhatme/shogun/build/examples/meta/cpp/multiclass/ecoc_discriminant_aed.cpp:10:0:
/home/tejsukhatme/shogun/src/shogun/lib/DynamicObjectArray.h:198:15: note: candidate: template<class T, class T2> bool shogun::DynamicObjectArray::append_element(T, const char*)
   inline bool append_element(T e, const char* name="")
               ^~~~~~~~~~~~~~

How do I avoid this? I am not dealing with the Dynamic Array allocation myself in the meta example.
This is the meta example.

Made a comment in the gist. Could you check if that helps?
Also could you pls post the .cpp source of the example?

Actually just checking your example, the error doesnt match that. Could you re-run make meta_examples and then make build_cpp_meta_examples....maybe something is outdated. Then add the change I posted, and re-run. If the error persists, post the .cpp

Yes, I did that. The error still persists. These are the relevant files:
Error Message
.sg.in file
.cpp file

Something isn’t right, you should be getting an error before that. The issue is that you are getting labels as an sgobject whereas it is an SGVector.. but when you get there should be an error if you pass the wrong type.. I’ll have a look into at some point. Have a look at how other meta examples get an SGVector and you’ll be able to fix this :)

thanks!
You used some specific API (I made comments). In general, stick to base class methods and use put/get

Is it okay if I use get_real_vector() instead of get()? That's what other meta examples seem to do.

Yup, that’s a templated version of get for SGVector. You can have a look at the cpp file using that and see it still uses get :)

Is this okay to merge?

Is this okay to merge?

CI does not seem to be happy. Did you check that the generated meta examples work locally?

Something isn’t right, you should be getting an error before that. The issue is that you are getting labels as an sgobject whereas it is an SGVector.. but when you get there should be an error if you pass the wrong type.. I’ll have a look into at some point. Have a look at how other meta examples get an SGVector and you’ll be able to fix this :)

This indeed is concerning. Shouldn't have happened. Especially since this would lead to a segfault down the line when accessing the returned object (it is a SGVector after all)

Looks like CI passed (using the data you had). Thanks, that is a big chunk! :)


Feature Request - ping forever

Hello,
would it be possible to add option, so that vmping wouldn't stop pinging even if there are connection errors/lack of response from hosts ?
Just like "ping -t"  - tries pinging forever, which is useful while monitoring network.
Regards
PK

This is the default behavior starting on release 1.3.17. What version are you on? If you're on the latest release, what error are you seeing that causes the pings to stop?

Awesome! Glad it's working.


Make sure drawImage width and height are not too big

in the case of an offset.
fixes #4337

It would be nice to have a render test for this.

But the problem is only visible in Safari? So how would a render test help?

Does this fix break things on other browsers?
In theory, if you create the render test reference image in a different browser, and run the test in Safari, it should fail. In practice, the resemble.js image comparison is often too picky. Maybe the render tests should use Pixelmatch instead. See #4288.

No it's still fine on other browsers (I checked Chrome and FF).
There is still no way to run the render tests on OSX right?

It would at least be nice to have a passing render test before this change, to make sure that it doesn't break things on other browsers.

Agreed, okay I'll add one.

There is still no way to run the render tests on OSX right?

They run fine in the browser (http://localhost:3000/test_rendering/. In El Capitan with latest XCode, they also run with make test-rendering now.

Ah great, that's good to know.

@ahocevar and they currently pass all for you on OSX? I get 5 failures:
Barts-MacBook-Air:ol3_bartvde bartvandeneijnden$ make test-rendering
node tasks/test-rendering.js
Gecko: 33.1.1
ol.rendering.layer.VectorTile vector tile layer renders correctly with the canvas renderer
Error: Error: expected '2.12' to be below 1.5 (http://<IP_ADDRESS>:3001/node_modules/expect.js/index.js:96)

ol.rendering.reproj.Tile tile projection from EPSG:4326 to EPSG:3857
Error: Error: expected '7.42' to be below 1.5 (http://<IP_ADDRESS>:3001/node_modules/expect.js/index.js:96)

ol.rendering.reproj.Tile dateline wrapping wraps X when prime meridian is shifted
Error: Error: expected '6.20' to be below 1.5 (http://<IP_ADDRESS>:3001/node_modules/expect.js/index.js:96)

ol.rendering.reproj.Tile dateline wrapping displays north pole correctly (EPSG:3413)
Error: Error: expected '2.69' to be below 1.5 (http://<IP_ADDRESS>:3001/node_modules/expect.js/index.js:96)

ol.rendering.style.RegularShape #render tests the canvas renderer
Error: Error: expected '6.36' to be below 6 (http://<IP_ADDRESS>:3001/node_modules/expect.js/index.js:96)

5 test(s) failed.

Added a rendering test for an icon with an offset, let's see if Travis also thinks it's okay.

Hmm, but of course my change does influence the resulting image. So a rendering image created before this change is different.

So this needs more work.

Okay have a fix now that results in the same reference image before and after this change.

@ahocevar this is now really ready for review.

I added in comment which you may want to take. Otherwise this looks good to me. I'd favor if @ahocevar looked at this as well.
Thanks, Bart.

Looking at this now.

Looks great now, thanks @bartvde. Please merge.


🐛 [firebase_messaging] getInitialMessage() does not terminate on macOS if app starts from terminated state

Bug report
The method works as expected on iPad, but on macOS any code after getInitialMessage() is never executed.
Steps to reproduce
Steps to reproduce the behavior:

Add any behavior after await FirebaseMessaging.instance.getInitialMessage(), e.g. showDialog()
Close app and trigger a push notification
Click notification: App opens, but the behavior from 1. is never observed

Sample project
GitHub
Configure this project with flutterfire configure, set up XCode for signing etc.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.10.1, on macOS 13.3.1 22E772610a darwin-arm64, locale en-US)
[!] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc2)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
[✓] Chrome - develop for the web
[✓] Android Studio
[✓] IntelliJ IDEA Ultimate Edition (version 2023.2 EAP)
[✓] IntelliJ IDEA Ultimate Edition (version EAP IU-232.5150.116)
[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.2)
[✓] IntelliJ IDEA Ultimate Edition (version EAP IU-232.6095.10)
[✓] VS Code (version 1.78.2)
[✓] VS Code (version 1.79.0-insider)
[✓] Connected device (2 available)
[✓] Network resources

! Doctor found issues in 1 category.

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 3.0.1
Flutter SDK 3.10.1
initial_message 0.1.0

dependencies:
- firebase_core 2.13.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_messaging 14.6.1 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- flutter 0.0.0 [characters collection js material_color_utilities meta vector_math sky_engine]

dev dependencies:
- flutter_lints 2.0.1 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection js matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph]

transitive dependencies:
- _flutterfire_internals 1.3.1 [collection firebase_core firebase_core_platform_interface flutter meta]
- async 2.11.0 [collection meta]
- boolean_selector 2.1.1 [source_span string_scanner]
- characters 1.3.0
- clock 1.1.1
- collection 1.17.1
- fake_async 1.3.1 [clock collection]
- firebase_core_platform_interface 4.8.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.5.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_messaging_platform_interface 4.5.1 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 3.5.1 [_flutterfire_internals firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math]
- js 0.6.7 [meta]
- lints 2.1.0
- matcher 0.12.15 [async meta stack_trace term_glyph test_api]
- material_color_utilities 0.2.0
- meta 1.9.1
- path 1.8.3
- plugin_platform_interface 2.1.4 [meta]
- sky_engine 0.0.99
- source_span 1.9.1 [collection path term_glyph]
- stack_trace 1.11.0 [path]
- stream_channel 2.1.1 [async]
- string_scanner 1.2.0 [source_span]
- term_glyph 1.2.1
- test_api 0.5.1 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- vector_math 2.1.4

Thanks for the report @Lootwig
Per this documentation for macOS, can you confirm if the required permissions are configured properly ?

@darshankawar The suggested default parameters are exactly the ones I left in the requestPermission() call. I am receiving the notification and it opens the app just fine. It's just the mentioned callback that doesn't terminate as it does on iPad and Android.

Thanks for the update. Using the repo provided, I seem to be able to replicate the reported behavior.
/cc @Lyokone


V4 dev backports and updates

This should restore the ES5 enforcement in tests @Johann-S

I left js/dist.index.js for the time being, although it does seem unused. We should revisit later if we need it and remove it if not.

I left js/dist.index.js for the time being, although it does seem unused. We should revisit later if we need it and remove it if not.

I see this is covered in #31823, so maybe we slate for v4.6.0? Do we need to warn folks at all?

I see this is covered in #31823, so maybe we slate for v4.6.0? Do we need to warn folks at all?

I intentionally kept index.js in v4-dev, since I can't be 100% sure if this will break something. But the sourcemap was outdated and moot for sure, hence why I decided to remove only that here :)


didn't work with dvp

Debian 10, DWM.
tty = dvorak-programmer
/etc/keyd/default.cfg
rightalt = layer(mylayer)

[mylayer]
a = 0
o = 1
e = 2
u = 3

/etc/X11/xorg.conf.d/00-keyboard.conf
Section "InputClass"
        Identifier "system-keyboard"
        MatchIsKeyboard "on"
        Option "XkbLayout" "us,ru"
        Option "XkbModel" "pc104"
        Option "XkbVariant" "dvp,typewriter"
        Option "XkbOptions" "ctrl:nocaps, grp:win_space_toggle"
EndSection

if i delete /etc/X11/xorg.conf.d/00-keyboard.conf and use setxkbmap -option ctrl:nocaps -option grp:win_space_toggle us,ru -variant dvp,typewriter
keyd not work too...

See #26


Experimenting with generics for backend type passthrough

This is an alternative implementation to https://github.com/gopxl/pixel/pull/76
And more importantly, an experiment in a different way to handle pixel's interactions with backends.
While working on the pixel Actions PR, it began to feel a bit like a hat on a hat on a hat as input arrays are passed up through the stack (OpenGL -> GLFW -> Pixel), copying at each level and creating more garbage to be collected. So I started experimenting with generics to see if I could get around that.
The way this works is that pixel would actually not define any of its own input types, but rather use the ones defined by the backend directly. Which means when fetching the array of buttons for a joystick from glfw, we can just set it directly into the state store rather than copying and transforming the type.
Using it then looks like this
win := opengl.NewWindow(...)
win.JoystickJustPressed(glfw.Joystick1, glfw.ButtonA)

This would make pixel much more flexible, since backends would not need to map to a constrained set of inputs defined by pixel.
The downside is this approach could result in an explosion of generics, and makes the interface for using pixel less uniform between backends.

Other notable downside, this would reopen the issue of MouseButton KeyboardButton . Since glfw defines them as separate types, this wouldn't work
win.JustPressed(glfw.MouseButton1)
win.JustPressed(glfw.Key0)

It would have to be something like
win.MouseJustPressed(glfw.MouseButton1)
win.KeyJustPressed(glfw.Key0)

And a pixel code base would not be able to easily switch between backends, so that's a deal breaker. But ditching the generics this gives me an idea for a better way to handle it while still mapping to pixel types.

And a pixel code base would not be able to easily switch between backends, so that's a deal breaker. But ditching the generics this gives me an idea for a better way to handle it while still mapping to pixel types.

Haven't been following along, but if you mean it should be able to switch after startup, we can ignore this. Once a user selects a backend, they're stuck with it unless they tear everything down and start again.

No didn't mean after startup, just that I think it's not a good design pattern for the project that you wouldn't be able to switch over to a different backend with relative ease.

Makes sense!

Ok ignoring the stuff I said about the end-user referencing backend types directly, this could actually work. Store inputs as the backend native type, and then do the type mapping in the other direction at query time. WDYT?

causes more problems than it solves


🥢 SafeTransferLib Assembly is Not Memory Safe

As far as I understand the assembly in SafeTransferLib is not memory safe despite being tagged as such. In particular from the docs:

In particular, a memory-safe assembly block may only access the following memory ranges:

Memory allocated by yourself using a mechanism like the allocate function described above.
Memory allocated by Solidity, e.g. memory within the bounds of a memory array you reference.
The scratch space between memory offset 0 and 64 mentioned above.
Temporary memory that is located after the value of the free memory pointer at the beginning of the assembly block, i.e. memory that is “allocated” at the free memory pointer without updating the free memory pointer.

Furthermore, if the assembly block assigns to Solidity variables in memory, you need to assure that accesses to the Solidity variables only access these memory ranges.
Since this is mainly about the optimizer, these restrictions still need to be followed, even if the assembly block reverts or terminates. As an example, the following assembly snippet is not memory safe, because the value of returndatasize() may exceed the 64 byte scratch space:
assembly {
  returndatacopy(0, 0, returndatasize())
  revert(0, returndatasize())
}

In particular, writing over the zero-memory slot (start at memory offset 0x60) is not allowed in memory safe assembly, even control never leaves the execution block (such as with an explicit return or revert) or, AFAIU, if the memory is restored. However, in safeTransferFrom (among other functions), this invariant is not upheld by the assembly block:
https://github.com/Vectorized/solady/blob/5f048036524032e31c692888f3e8bdf55f6c5209/src/utils/SafeTransferLib.sol#L201
AFAIU, this is an issue as the optimizer may make use of assumptions of the memory layout invariants within assembly block statements (one such example, although not applicable to the zero slot, is that stack variables a-la let x := ... can occupy memory instead of a stack slot when simultaneous access to more than 16 stack variables is needed).

assembly {
returndatacopy(0, 0, returndatasize())
revert(0, returndatasize())
}

It doesn't cause any issue because return or revert statement will stop current frame execution and returns data to parent frame.

https://github.com/Vectorized/solady/blob/5f048036524032e31c692888f3e8bdf55f6c5209/src/utils/SafeTransferLib.sol#L201

We will restore zero-pointer at end of function.

It doesn't cause any issue because return or revert statement will stop current frame execution and returns data to parent frame.

Correct, but the Solidity documentation explicitly states that this is not memory safe, despite stopping the current frame of execution. From the docs:

Since this is mainly about the optimizer, these restrictions still need to be followed, even if the assembly block reverts or terminates.

We will restore zero-pointer at end of function.

Yes, but according to the documentation, this is not enough for the assembly to be considered memory safe. It cannot be written to in the first place.

The Solidity optimizer doesn't change the control flow of functions, so we don't need to worry about this warning.
For a quick example:
struct Shit {
    uint256 a;
    uint256 b;
}

function start() public {
    uint256 m;
    assembly {
        m := mload(0x40)
        mstore(0x40, randomBytes)
        mstore(0x60, randomBytes)
    }
    f2();

    assembly {
        mstore(0x40, m)
        mstore(0x60, 0)
    }
}

function f2() public {
    string memory r = "shitmemory";  // load memory pointer and store from there
    Shit memory s;  // assign s to 0x60
    // do stuff
}

In the above example, overwriting the free memory pointer and zero pointer like that can cause unexpected errors due to the control flow change from the f1() to the f2() function, which is written in Solidity. Solady libraries don't give control flow to any other function like the one mentioned above.

Yup it will return 42 because you are writing arbitrary memory pointer location without knowing free memory pointer(0x40).
Correct ways is writing memory
contract MemoryUnsafe {
    function memoryUnsafe() public pure returns (uint256) {
         // all vars
        assembly ("memory-safe") {
           let m := mload(0x40) // where can write memory
            mstore(m, 11) // random memory store...
            mstore(0x00, add(allvar)))
            return(0x00, 0x20)
        }
    }
}

Correct ways is writing memory

Exactly... the current code is writing to 0x60 which is not "the correct way of writing memory" according to the Solidity docs.

Basically I'm arguing that, while the current code does work, it is relying on UB, and the compiler/optimizer is free to make use of mload(0x60) == 0 assumption at any point inside memory-safe assembly blocks, an invariant which the current assembly block breaks. It can break things silently and unexpectedly in future versions of the compiler.

Solady all assembly block has special comment /// @solidity memory-safe-assembly which will disallow this type of future breaking change.

Defacto memory safe.
Closing this.

Ah - OK, so they are relaxing the definition of memory safety to allow overwriting the zero slot as long as it is restored. Looking at the discussion, it means that you can't access dynamic arrays reliably (since you may be inadvertently modifying their length), but that isn't an issue for the safe transfer functions.
TIL - thanks for the link, I wasn't aware of the proposed change.


Parser: support heredoc literal in macro

Fixed #8365

I think this should have a spec that asserts the final string content has the expected space in the intermediate lines.
Although the parsing specs make sense, it is not clear in this PR that expanding the macro will lead to the right string.

@bcardiff Added codegen specs for this. Is this okay?

Yup. Thanks @MakeNowJust 🙇♂


Create Step-by-Step Guide to Install & Maintain Lagoon

Currently the Installation Guide of Lagoon is rather small: https://lagoon.readthedocs.io/en/latest/administering_lagoon/install/
Also there is no documentation on how to upgrade an already existing Lagoon.
This project idea covers:

Creating a better Step-by-Step guide on how to Install a Lagoon, with possible known issues, edge cases, etc.
Create a Step-by-Step guide on how to upgrade/maintain a previously installed Lagoon, with known issues, possible hurdles, best practices, etc.

This is now better covered in the documentation, and being updated.


⚠ Bofrost.at has degraded performance

In a980601, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2454 ms

Resolved: Bofrost.at performance has improved in 1b857cd.


Create aneesh-gopalakrishnan.json

#WeAreDonet Creator Submission Guidelines

By submitting this pull request to add my creator card, I verify that I adhere to the #WeAreDotnet creator card submission guidelines.

We do not accept submissions with the sole intention of promoting a product or company.

We add you as a creator, not your company.

The moderator team decides whether we accept or reject a submission.

When Do We Accept Someone's Creator Card Submission?

You must have published a post since 2022 on any of your channels.

There must be one publication in English.

There needs to be more than tweets.

A longer-form article on LinkedIn is good, but a self-hosted blog or one on a well-known platform like Hashnode, medium etc., is better.

Alternatively, you contributed with another form on a platform like YouTube, Twitch, Udemy or Pluralsight. If you have some recorded talks of conferences or anywhere else, that counts too! So in the form of a recorded video or a book.

RSS or Atom Feed

Submit an Atom or RSS URL inside your creator card that belongs to your blog

If you do not submit an RSS or Atom URL. We cannot consider your feed for the upcoming aggregation feature.

Content Guideline

If you have a self-hosted blog, please ensure you have a valid HTTPS certificate.

We host NO malicious or offensive content on the blog (including photos, swearing, etc.)

You must add the full URL to your GitHub profile to your card, so we can assign it to the member account that used the same GitHub account for sign-up.

Sending updates as pert @DeeJayTC's suggestions

@DeeJayTC - No RSS feeds yet. But instead of meetup links, I can provide the direct youtube links (The events went live using .NET Foundation's youtube channel)
I updated the blog link with this - https://www.red-gate.com/simple-talk/development/angular/inline-pdf-viewer-in-an-angular-app-now-you-can/
The blog post has a section for asp.net usage under "A sample API using C# and ASP.NET Core"
PS: I created the PDF library to fill in the gap when Asp.net core removed support for RDLC Report viewer
Link - https://learn.microsoft.com/en-us/archive/blogs/sqlrsteamblog/microsoft-acquires-report-rendering-technology-from-forerunner-software
Link: https://stackoverflow.com/questions/49309797/rdlc-local-report-viewer-for-asp-net-core-and-angular2-0

@DeeJayTC I will set up a feed and let you know.

@DeeJayTC - I have setup a RSS feed here: https://rss.app/feeds/79Dl0OyyexNBxDuA.xml
I added links to the feeds (youtube links and such). Let me know if this would suffice.

Yea that looks fine on first glance, i'll check it in detail later and merge it


Add Zhuoran Shen to AUTHORS and CONTRIBUTORS

I previously made a minor documentation fix in
https://github.com/google/glog/pull/747. According to README, this
commit adds myself to AUTHORS and CONTRIBUTORS.

Coverage remained the same at 76.432% when pulling 38fb0bd4382d7f75d88ec87c9634262cc6375670 on cmsflash:master into<PHONE_NUMBER>c6f1566e8c30a0f8d4e9e530491b30 on google:master.


Error executing vim.schedule lua callback: Garbage after pattern: +//.+$+

I'm getting the following error when scrolling through fzf-files
Error executing vim.schedule lua callback: ...k/packer/start/fzf-lua/lua/fzf-lua/previewer/builtin.lua:177: Error executing lua:
...k/packer/start/fzf-lua/lua/fzf-lua/previewer/builtin.lua:178: Vim(syntax):E402: Garbage after pattern: +//.+$+
Press ENTER or type command to continue

Just committed a fix, feel free to close the issue if it works.

My bad this was an issue with my configuration! Thanks for helping me figure it out!

My bad this was an issue with my configuration! Thanks for helping me figure it out!

Ty for helping me add code to avoid an error on faulty filetype configurations :)


Change the dummy words under the section "WHO WE ARE."

Change these 6 dummy words under "who we are" into content that communicates our company's vision.

These are not dummy words these are logo.png.

Let's just create a .md file for SILK website issues, get it approved first, and then add the issue to the repository.

I have some suggestions about this issue and that is we can add Testimonials or Quotes instead of logo.png. We can
Integrate testimonials or quotes from employees, clients, or partners that speak to the strengths and unique aspects of this company. These can provide a personal touch and convey the positive experiences and outcomes associated with your work.


Why does Command.Publish() require a CancellationToken?

Command.Publish() uses an async adapter internally but externally presents itself as not being async and the need to pass a cancellationToken parameter appears confusing.

@JC008 EventFlow is async first and therefor you should always use the async methods as EventFlow merely tries to do a good job when using the sync methods. Sync methods are exposed on interfaces as a convenience to be used externally by developers, but never used internally.
The use of cancellation tokens isn't something that's "async only", its a generic way of cancelling started work, which is why its exposed on almost all EventFlow interfaces. EventFlow uses retry strategies, in which it might wait a tiny bit (currently only for optimistic concurrency exceptions). So, cancellation tokens are exposed on every method what might result in work that's either IO bound or might have a retry strategy.
At a later time I'll let developers be able to configure the "point of no return" internally in EventFlow. Some developers might always be able to cancel an action, but some might not want to cancel if the aggregate events have been committed and read models are being updated.
You are always free to create an extension method in your own application that sends CancellationToken.None to e.g. Publish(...).
I hope that answers your question?

Yes thanks.


XPAY_Proj

Thank you for participating in the Xpay Developer Program. We truly appreciate your attendance and valued your presence. Goodluck with your personal and professional journey ahead.


:bug: replace . by _ in snapshot names

@lucasrodes don't use . in filenames, please. I'm not sure how the dots got there, you should get an assertion error if you run the snapshot step with dots.

Thanks, Mojmir!
Yup, I think this did not raise an error in the past. I recently detected this and decided to go and create new versions: https://github.com/owid/etl/pull/1495. So, the versions that you modified are not in use anymore.


Added fuzzer for cryptoservice

This PR adds a fuzzer that targets GetPrivateKey().
The fuzzer runs both locally and on oss-fuzz's infrastructure as well. I suggest integrating Notary into oss-fuzz which will allow Google to run this fuzzer and future fuzzers on their platform continuously. When a bug is found by oss-fuzz, the maintainers on the contact list receive a detailed bug report via email.
To be part of the project is free. It is expected that the bugs are fixed, so that the resources put into running the fuzzers go to good use.
I will be happy to integrate Notary into oss-fuzz. All I need are the email addresses of maintainers that need to receive the bug reports.

I am afraid I don't see why the build fails. Any feedback is appreciated.

Can you rebase, should fix the build issue.

Could you perhaps squash your commits?

Could you perhaps squash your commits?

@justincormack @thaJeztah Squashed


Add Table of Contents to README

Because each of the tools are described separately, the main README needs a table of contents.
Explain how to get --help for each of the tools.

Added in #39


Please rectify schemachange dry run output

Describe the bug
The schemachange dry run is used as a check before the actual implementation run to display the order of execution of the change scripts.
To Reproduce
Steps to reproduce the behavior:
Run a schemachange command using '--dry-run' parameter at the end.
Expected behavior
We would expect the Snowflake account details to be printed, scripts that would execute and NOT statements like ' Applying change script A__grant_permissions.sql ' as seen in the attached screenshot.
Screenshots

Schemachange:

Version: 3.6.1

Additional context
As seen I'm trying to run a dry run of a schemachange command using change scripts(version, repeatable, always).
It would be very helpful and informative if the output of dry run is cleaned up, and doesn't show statements like ' Applying script xyz ' as it isn't actually applying any change scripts at this point of the dry run and hence it is misleading and confusing.
Please let me know if you require additional details. Thank you.

@Jeevan-Raju The purpose of the dry run was to understand which scripts will be applied/skipped and the order in which the scripts will be executed when schemachange actually runs.
The output does say "Running in dry-run mode" which means the script is not applying the scripts.
What kind of check are you doing with dry-run before actual implementation? Can you give a few examples ?


Realtime Socket set to Null after Sign-In

As the title suggests:
Works fine in 0.12.2 but Client.Realtime.Socket is set to null after signing in when using 0.13.0 or 0.13.1
( I only install the Supabase-csharp package not each individual library)
' client.Realtime.Session Not Null
  Dim session = Await client.Auth.SignIn(email, password)
' client.Realtime.Session is now Null

Also, Can I ask what version this is resolved in:
https://github.com/supabase-community/gotrue-csharp/pull/74
I have such trouble trying to work out if a fix is released or not. Are there any release notes?

#74 was released on 0.13.0 you can see the release notes in the CHANGELOG!
I'll need to look into the realtime socket being null, let me get back to you on that one.

@Kuffs2205 are you calling client.InitializeAsync() after it's been constructed? Or is it possible you're using a client that hasn't called that? That's the only way I can get your issue to duplicate currently.

As far as I know yes.
Am I doing something wrong here ?
https://www.screencast.com/t/wBzSsmCus

Very odd. No that looks fine?
It looks like you're hitting this line somehow:
https://github.com/supabase-community/supabase-csharp/blob/a8e16622591f67770dbbc14e11a52d32fd5589ff/Supabase/Client.cs#L225-L229
Which in turn references this:
https://github.com/supabase-community/realtime-csharp/blob/853c06c6b18e078cafe621bf0ada9e8cb01fee75/Realtime/Client.cs#L286-L298
So, it looks like the SignedOut event is being called without a SignedIn being followed up.
Any thoughts @wiverson?

I just noticed that you released  0.13.3.
Tried it. No issue.
Went back to 0.13.2. Null Socket again.
Not sure about the sign out.  I seem to have a valid token back.
Anyway, it works with 13.3 so I'll all good.
Thanks.

Yeah it was an incorrectly called disconnection on one of the event handlers! Glad it’s working for you. Maybe I can get a link for the changelog to show up on the wiki. Happy Friday!


Add custom rustc driver that uses cg_clif

This makes the jit mode a bit more usable with cargo. This is also a prereq for the jit mode version of #1087.
Part of #1066

This is by the way possible since https://github.com/rust-lang/rust/pull/76474.


libuv-1.7.5

I also went ahead and modified all packages using a libuv stable release to just point at the latest. If that breaks anything I can roll that part back.

ping @cstrahan

@Ralith Sorry for the delay - looks good :+1:
Thanks!


[Wallets] Fix filter by a wallet that it supported in all languages

📝 Changed routes:

/dashboard/wallet

(view full size)

Commit 0d67d75026c3a4b216ffb914cfb4231200ade953 (https://thirdweb-osc2uvnln.thirdweb-preview.com).