Unable to install using cli

I am not sure if this is an issue of your extension or if it's something in vs code, i have this problem only with your extension so far, though: i am unable to install your extension using the cli:
code --install-extension rafaelmaiolla.remote-vscode

This results in the output below. Installing directly from vs code works, though. I've tried this with Linux and Mac OS X, so the problem doesn't seem to be platform specific.
Output of the above command:
Found 'rafaelmaiolla.remote-vscode' in the marketplace.
Installing...
WARNING: Promise with no error callback:19
{ exception: null,
error:
Error: Invalid package /Users/harald/.vscode/extensions/rafaelmaiolla.remote-vscode-0.1.8/.vscode-test/VSCode-linux-x64/resources/atom.asar
    at invalidArchiveError (ELECTRON_ASAR.js:149:19)
    at Object.module.(anonymous function) [as open] (ELECTRON_ASAR.js:205:16)
    at WriteStream.open (fs.js:2094:6)
    at new WriteStream (fs.js:2080:10)
    at Object.fs.createWriteStream (fs.js:2035:10)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cliProcessMain.js:7:11353
    at new n.Class.derive._oncancel (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:4:30926)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cliProcessMain.js:7:11317
    at Object._ [as _notify] (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:4:23742)
    at Object.enter (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:4:27320),
promise:
{ _oncancel: null,
    _nextState: null,
    _state:
    { name: 'error',
        enter: [Function: enter],
        cancel: [Function: a],
        done: null,
        then: null,
        _completed: [Function: a],
        _error: [Function: a],
        _notify: [Function: m],
        _progress: [Function: a],
        _setCompleteValue: [Function: a],
        _setErrorValue: [Function: a] },
    _listeners: null,
    _value:
    Error: Invalid package /Users/harald/.vscode/extensions/rafaelmaiolla.remote-vscode-0.1.8/.vscode-test/VSCode-linux-x64/resources/atom.asar
        at invalidArchiveError (ELECTRON_ASAR.js:149:19)
        at Object.module.(anonymous function) [as open] (ELECTRON_ASAR.js:205:16)
        at WriteStream.open (fs.js:2094:6)
        at new WriteStream (fs.js:2080:10)
        at Object.fs.createWriteStream (fs.js:2035:10)
        at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cliProcessMain.js:7:11353
        at new n.Class.derive._oncancel (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:4:30926)
        at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cliProcessMain.js:7:11317
        at Object._ [as _notify] (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:4:23742)
        at Object.enter (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:4:27320),
    _isException: false,
    _errorId: 19,
    done: [Function: done],
    then: [Function: then] },
handler: undefined,
id: 19,
parent: undefined }
/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:4
(function(){var e=["exports","require","vs/base/common/platform","vs/base/common/types","vs/base/common/uri","vs/base/common/winjs.base","vs/base/common/arrays","vs/base/common/errors","vs/nls!vs/platform/environment/node/argv","vs/base/common/objects","vs/platform/environment/node/argv","vs/platform/package","path","vs/platform/product","os","minimist","assert","vs/base/common/winjs.base.raw","vs/nls!vs/code/node/cli","child_process","vs/code/node/cli","vs/nls"],t=function(t){for(var n=[],r=0,o=t.length;r<o;r++)n[r]=e[t[r]];return n};define(e[6],t([1,0]),function(e,t){"use strict";function n(e,t){return void 0===t&&(t=0),e[e.length-(1+t)]}function r(e,t){for(var n=0,r=e.length;n<r;n++)t(e[n],function(){e.splice(n,1),n--,r--})}function o(e,t,n){if(void 0===n&&(n=function(e,t){return e===t}),e.length!==t.length)return!1;for(var r=0,o=e.length;r<o;r++)if(!n(e[r],t[r]))return!1;return!0}function i(e,t,n){for(var r=0,o=e.lengt

Error: Invalid package /Users/harald/.vscode/extensions/rafaelmaiolla.remote-vscode-0.1.8/.vscode-test/VSCode-linux-x64/resources/atom.asar

Error: Invalid package /Users/harald/.vscode/extensions/rafaelmaiolla.remote-vscode-0.1.8/.vscode-test/VSCode-linux-x64/resources/atom.asar
    at invalidArchiveError (ELECTRON_ASAR.js:149:19)
    at Object.module.(anonymous function) [as open] (ELECTRON_ASAR.js:205:16)
    at WriteStream.open (fs.js:2094:6)
    at new WriteStream (fs.js:2080:10)
    at Object.fs.createWriteStream (fs.js:2035:10)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cliProcessMain.js:7:11353
    at new n.Class.derive._oncancel (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:4:30926)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cliProcessMain.js:7:11317
    at Object._ [as _notify] (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:4:23742)
    at Object.enter (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:4:27320)
    at Timeout._onTimeout (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/cli.js:4:7323)
    at tryOnTimeout (timers.js:232:11)
    at Timer.listOnTimeout (timers.js:202:5)

I can see the same issue, will investigate.

This is fixed in version 1.0.1.  Please uninstall the old extension and try to install the new version.


[newrelic-infrastructure] Exposing configuration settings to helm chart

Is your feature request related to a problem? Please describe.
I would like to easily configure additional infrastructure agent configuration settings via the helm chart. Some have already been added such as https://github.com/newrelic/helm-charts/issues/141. Personally I'm looking for those related to sampling, but others may also be useful.
Describe the solution you'd like
Environment variables NRIA_METRICS_NETWORK_SAMPLE_RATE, NRIA_METRICS_PROCESS_SAMPLE_RATE, NRIA_METRICS_STORAGE_SAMPLE_RATE, NRIA_METRICS_SYSTEM_SAMPLE_RATE added to the env section of the daemonset templates for Linux and Windows, and exposed as values.
Describe alternatives you've considered
Forking the chart or using a post renderer such as kustomize.
Additional context
N/A

Hi,
Thanks for raising this concern, as well as taking the time to write the linked PR.
Given the high number of settings that can be configured for the infrastructure agent and integrations, we are trying to move away of aliasing all possible env vars to the chart as Values. The ones we currently have are there for legacy or backwards-compatibility reasons.
Changing this (and any other) setting should be possible using the config key, which is expanded and mounted as a config file for the infrastructure agent. Could you please try it and see if it works for you?

@roobre Not wanting to alias all of the possible env vars makes total sense, and is definitely something that I considered at the time but didn't realise the better way. This is my first attempt at New Relic but I think your comment has helped me understand a lot! It looks like for the config key, the relevant parameters from https://github.com/newrelic/infrastructure-agent/blob/master/assets/examples/infrastructure/newrelic-infra-template.yml.example can be included. It should even be possible to use the nri-bundle chart and pass them through from there. Is that correct?

Yes, that is totally correct. Just keep in mind that you'll have to "nest" the value under the infrastructure-bundle key. just like this example:
https://github.com/newrelic/helm-charts/blob/2aae7be7dad949d986a5b0fd265b803d908db328/charts/nri-bundle/values.yaml#L52-L54

Great, I tested this and verified the file was created correctly on the container. Thanks for your help!


Is there a way to convert a LLM output text to data then we can parse it?

Bug Description
It seems , there is no way to convert a LLM's output JSON string to JSON object and store it to some place and reuse it in some component later.
Reproduction
It seems , there is no way to convert a LLM's output JSON string to JSON object and store it to some place and reuse it in some component later.
Expected behavior
There should be some component to parse the text to data and then we can update and visit it just like a dict.
Who can help?
No response
Operating System
Docker image v1.0.16
Langflow Version
v1.0.16
Python Version
None
Screenshot
No response
Flow File
No response

Langflow provides functionality to convert LLM output text to data structures like JSON objects. The JSONCleaner component includes a method _validate_json that uses json.loads to validate and parse JSON strings [1]. Additionally, the ParseDataComponent can convert data into plain text following a specified template, which can be useful for handling JSON data [[2]](https://github.com/langflow-ai/langflow/blob/main/src/backend/base/langflow/initial_setup/starter_projects/Document QA.json).
For storing and reusing data, Langflow's memory management feature allows every chat message to be stored, and a single flow can have multiple memory sessions. This enables the creation of multiple “memories” for agents to store and recall specific information as needed [3].
You can use these components to parse the LLM's output JSON string into a JSON object and store it for later use.
To continue talking to Dosu, mention @dosu.

the output of "JSON Cleaner' is text, it can not be handled by "Parse Data'

Langflow provides functionality to convert LLM output text to data structures like JSON objects. The JSONCleaner component includes a method _validate_json that uses json.loads to validate and parse JSON strings [1]. Additionally, the ParseDataComponent can convert data into plain text following a specified template, which can be useful for handling JSON data [[2]](https://github.com/langflow-ai/langflow/blob/main/src/backend/base/langflow/initial_setup/starter_projects/Document QA.json).
For storing and reusing data, Langflow's memory management feature allows every chat message to be stored, and a single flow can have multiple memory sessions. This enables the creation of multiple “memories” for agents to store and recall specific information as needed [3].
You can use these components to parse the LLM's output JSON string into a JSON object and store it for later use.
To continue talking to Dosu, mention @dosu.

the output of "JSON Cleaner' is text, it can not be handled by "Parse Data' . @dosu

If the text output of the JSONCleaner component cannot be processed by the ParseDataComponent, you can handle it by catching the exception and logging the error or taking alternative actions. Here is an example of how you might handle this situation:
try:
    cleaned_json_message = json_cleaner.clean_json()
    cleaned_json_str = cleaned_json_message.text
    # Attempt to process the cleaned JSON string with ParseDataComponent
    parsed_data = parse_data_component.parse(cleaned_json_str)
except ValueError as e:
    # Handle the error if JSONCleaner fails
    print(f"Error cleaning JSON string: {e}")
    # Take alternative actions, such as logging the error or using a default value
    # For example:
    # log_error(e)
    # parsed_data = default_value
except Exception as e:
    # Handle any other exceptions that may occur
    print(f"An unexpected error occurred: {e}")
    # Take alternative actions
    # For example:
    # log_error(e)
    # parsed_data = default_value

In this code, json_cleaner is an instance of the JSONCleaner component, and parse_data_component is an instance of the ParseDataComponent. The try block attempts to clean the JSON string and then process it. If an error occurs during the cleaning process, it is caught, and alternative actions can be taken.
Additionally, ensure that the data types and connections between components are correctly configured. For instance, the ParseDataComponent expects input of type Data and outputs a Message. Make sure the data flow aligns with these expectations to avoid processing errors [1][[2]](https://github.com/langflow-ai/langflow/blob/main/src/backend/base/langflow/initial_setup/starter_projects/Blog Writer.json)[[3]](https://github.com/langflow-ai/langflow/blob/main/src/backend/base/langflow/initial_setup/starter_projects/Document QA.json).
To continue talking to Dosu, mention @dosu.

Really very frustrating, If there is a variable setter and getter, things can be much more easier.

hi maxpaynebupt!
i solved this creating a custom component that takes a text and returns a data object
with the key that you wish (value in my case) and the text as value
my code below:
# from langflow.field_typing import Data
from langflow.custom import Component
from langflow.io import MessageTextInput, Output
from langflow.schema import Data

class TextToData(Component):
    display_name = "Text to data object"
    description = "This component takes a MessageTextInput and parse it into a data object"
    icon = "custom_components"
    name = "TextToData"

    inputs = [
        MessageTextInput(name="input_value", display_name="Input Value", value="Hello, World!"),
    ]

    outputs = [
        Output(display_name="Output", name="output", method="build_output"),
    ]

    def build_output(self) -> Data:
        data = Data(value=self.input_value)
        self.status = data
        return data

good luck!


[ioredis] Unhandled error event: Error: write ENOBUFS

[ioredis] Unhandled error event: Error: write ENOBUFS
who can i resolve this issue

It's not an issue related to ioredis. ENOBUFS errors are often caused by running out of system memory.


Show loading indicator when waiting for auth

After I authorized GitHub from the browser and went back to VS Code, there was a slight delay (3-5s) where nothing was happening and I wasn't sure whether the auth worked. I expected there to be a progress/loading indicator on the "Sign In" section of the GH viewlet so that the I knew to wait (either a spinner or the viewlet progress bar up top).

Closing as auth is part of core now.


Distinguish definitions from references in the model

We have hit a hurdle when creating test data templates and generating sample data using the model. I don't see a way we can distinguish between definitions and references within the model.
For example, in this screenshot of the model, you can see that both StudyDesign and StudyCell have a list of studyElements.

By the sample json, we can see that StudyDesign.studyElements points to a list of definitions, but StudyCell.studyElement(Id)s points to a list of references to StudyDesign's definitions. How do we distinguish the two using the model?

It would help to either have the "Id" qualifier in the relationship names or have some other indicator to distinguish between definitions and references.

One option might be to specify "Containment" for the target in the relationship:

Hi @ASL-rmarshall ,
Thank you for the comments. I will look into the containment part with the team.
Did you also check out the description in the IG with regards to referencing in the API? See https://wiki.cdisc.org/display/USDMIGv3/USDM+API

Email thread on this issue over the last few days
API.pdf
Remember, the CORE rules are checking the API JSON, not the model. There is a subtle difference between the two.

End (optimistically) of email thread:
API2.pdf
It's the differences that make things tricky. We need something machine readable that can be interpreted to replicate (programmatically) what's been done in the API.

I just realized that adding containment to the UML EA may not work. I can't find a counterexample in the current API quickly and I'm not sure if one exists right now or may exist in the future, but here is a general example:
Let's say we have:

4 classes: A, B, C, D.
2 relationships: AtoC, BtoC, CtoD

The relationships are as follow:
A -> AtoC -> C -> CtoD (val) -> D
B -> BtoC -> C -> CtoD (ref) -> D
The problem is with CtoD. Let's say the first CtoD relationship is a value and the second CtoD relationship is a reference. As you can see, class C will only have one relationship in EA, but whether it is value or reference depends on its parent.

On second thought, I'm guessing this scenario doesn't happen. Otherwise, I would expect to see multiple instances of the same Class within the API schema.

The API schema defines once and uses cross references of the form "$ref": "#/components/schemas/Code" everywhere else to refer, this being a Code reference.

Yeah, I didn't mean the schema's use of $ref. I meant there might be a scenario where we have ClassA.ClassC1.code and ClassB.ClassC2.codeId. But I don't see cases like this.

Updates to DD and CT should allow for the attribute names to be mapped from the API to the UML model and the use of "Id" and "Ids" suffix


Outdated command

[Enter feedback here]
Looks like powershell command shown on page is not up to date
get-AzRoleAssignment -Scope "/providers/Microsoft.Capacity" |?{$_.RoleDefinitionName -Like "Reservations*"}
WARNING: Upcoming breaking changes in the cmdlet 'Get-AzRoleAssignment' :
This cmdlet will use Microsoft Graph in Az 7.x and later.
Visit https://go.microsoft.com/fwlink/?linkid=2174792 for migration guide and breaking changes.
Note : Go to https://aka.ms/azps-changewarnings for steps to suppress this breaking change warning, and other information on breaking changes in Azure PowerShell.

Get-AzRoleAssignment: Operation returned an invalid status code 'Forbidden'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9845f989-fdb0-d55f-df73-969b0ca2d06c
Version Independent ID: 8562a607-1d01-c368-7000-b956f82af400
Content: Permissions to view and manage Azure reservations
Content Source: articles/cost-management-billing/reservations/view-reservations.md
Service: cost-management-billing
Sub-service: reservations
GitHub Login: @bandersmsft
Microsoft Alias: banders

@smorczak - Thanks for brining this to our attention. We will investigate it further and update you shortly.

@smorczak Thanks for letting us know about this issue. I've updated the article.
#please-close


raftstore::test_conf_change::test_conf_change_fast failed

raftstore::test_conf_change::test_conf_change_fast
Latest failed builds:
https://internal.pingcap.net/idc-jenkins/job/tikv_ghpr_test/20152/consoleFull

This issue has become out-of-date. Given that no further feedback regarding this issue has been reported, it can be safely closed.


Memory Leak when deploying to Stand-alone Tomcat

Hi,
I'm attaching a a modified version of the graphql-server project from the Spring Getting Started Guide. The only real modifications are the addition of Spring Data & H2 as dependencies, plus some standard configuration. When deploying the application as a WAR file to 10x Version Tomcat it would appear the memory is not being released following shutdown of the application.

I'm only able to reproduce the problem when using spring data and spring graphql in tandem. I cannot reproduce the problem when using one without the other.
gs-graphql-server.zip

I think that calling Schedulers.boundedElastic() will create a shared instance that will be kept around until the JVM is shut down. Have you tried to shut them down with Schedulers.shutdownNow() as part of the application lifecycle when the application is undeployed? Typically, you could create a bean that implements SmartLifecycle and calls this shutdown method in its stop() implementation. You can of course use any other mechanism supported by you environment (like the Servlet lifecycle).
Can you try this and let us know if this works out?

That works, thanks. :)
Is this bleeding out from the framework internals? I don't see the demo app explicitly initiating anything via Scheduler and didn't realize a shutdown hook was needed.

There is the broader lifecycle angle question to be considered. Even a Spring for GraphQL application that's using Spring MVC as a transport could need a Scheduler in some cases, e.g. in the synchronous client or the WebSocket handler.
Specifically for the sample here, however, a Scheduler doesn't actually need to be used, and seems to be created eagerly. I've created https://github.com/spring-projects/spring-framework/issues/33218 to resolve that.

We had a brief exchange with @bclozel about the points raised above. I'm happy to help in Framework's/Boot's lifecycle management of the Scheduler instances. One idea that comes to mind is to not replace the static ones, but explicitly use specific Scheduler implementations in Spring which are in control of the framework. They would not create risks of colliding with 3rd party library expectations or user-defined long running periodic tasks or shutdown hooks. The drawback for Spring would be the necessity to always feed operators with these instances. Also it could be perceived as a breaking change for users. We can discuss this further and consider various options.

I have discussed this with the Spring Boot team, and we think this case is quite similar to spring-projects/spring-boot#21221. So we would like to consider expanding the SpringBootServletInitializer to also defensively shut down the shared Schedulers once the application context has been closed.
As a first step, I will use the sample you provided to test this approach and then apply the appropriate change. In the meantime, please consider adding a ServletContextListener bean to your application that calls Schedulers.shutdownNow() when the servlet context is destroyed.
Transferring this issue to Spring Boot.


timeouts -

currently missing decent setTimout and clearTimeout methods.
I'd like these to work 2 ways. async and not. so a flag needs to be added to make async=True. currently i doubled up and 2 new ones to 'Global' so the old implementations could be left alone. (not that they worked. its just a sleep.)
ideally somehow utilise the SetInterval work that was done in the past. I had avoided ayncio due to api changes between python versions. I'd get setInterval to work in one version but it would fail in another so went to 'threads' for the Job class. howeer this is only async atm. should it block during exec?
for now I can't see me getting to this for a while. so making a ticket not to use setTimeout and clearTimeout as they aren't done. But will be once I get time and can think about how I resolve these issues.

I've labled this as help wanted as don't think I'll get to it for 2 months at least. it's at least a weekends work for me so not on my roadmap for immediate forseeable with other stuff.

I think the builtin python [threading.Timer] would work perfectly for this.
https://docs.python.org/3/library/threading.html#timer-objects

You my friend are a genius. this is now in the 0.4.7 release. I did update it to divide/1000 to use milliseconds like the javascript one but the functionality is perfect. I tried and have also now elevated it to a module function as well as on the Global class. This ticket can be closed. Also thanks so much for the unit tests. A friend showed me the Mock object ages ago and I forget about that. Also the dunder acccessors in your assert looked like magic. Then i realised i saw that in a django app once and must've thought it was a esoteric django thing and hadn't realised you could just do that in python. weird i hadn't made the connection. I'm pretty chuffed about these 2 methods being in. so thanks again. I put your name in the contributers.md files as well.


IncludeStatistics only available for batch operations

TextAnalyticsResult provides the option to Gets statistics about the input document and how it was processed by the service. This information is misleading as for .NET we only provide the option to get the statistics if there is a batch operation (i.e. here).
We should either remove the Statistics property from TextAnalyticsResult to avoid confusion, or provide an option for the customer to be able to ask for that information in single document analysis like Python does.
FYI the Detect Language API:
Request URL
https://{endpoint}/text/analytics/v2.1/languages[?showStats]
Request parameters
showStats (optional)boolean
(optional) if set to true, response will contain input and document level statistics.

FYI @annelo-msft

See PR https://github.com/Azure/azure-sdk-for-net/pull/9772

PR merged


FAILED - RETRYING: wait for hosts (12 retries left)

Hello,
I am trying to install S4HANA 2020 with HANA 2.0SPS05 Netweaver -HA, after the compute engine instance creation, I get the below error
I see that it gets stuck in the below section of forminator but the issue is actually with not being able to SSH into the instance by the script.
Thinking out loud here -
I am able to manually SSH into the instance and I checked that ansible is present in the list of users from OS level.
I dont see sap_ssh_user in sudo users list in VMs - also thinking if ansible user's password is the reason for not being able to SSH.
Is there anything specific that we need to do in terms of updating the sudo users list or guest permissions in the VMs?
name: wait for hosts
# Run a command with sudo to ensure the guest agent has added sap_ssh_user and it
is present in the sudoers file, otherwise later the ansible connection can fail with:
FAILED! => {"msg": "Missing sudo password"}
command: >-
ssh -i {{ sap_ssh_priv_key }} -o StrictHostKeyChecking=no
{{ sap_ssh_user }}@{{ item.host }} sudo true
register: can_ssh
retries: 12
delay: 10
until: can_ssh is succeeded
loop: '{{ terraform.outputs.inventory.value }}'
changed_when: false
when: sap_ansible_is_push_mode
TASK [forminator : wait for hosts] ****************************************************************************************************************************************************************************
FAILED - RETRYING: wait for hosts (12 retries left).
FAILED - RETRYING: wait for hosts (11 retries left).
FAILED - RETRYING: wait for hosts (10 retries left).
FAILED - RETRYING: wait for hosts (9 retries left).
FAILED - RETRYING: wait for hosts (8 retries left).
FAILED - RETRYING: wait for hosts (7 retries left).
FAILED - RETRYING: wait for hosts (6 retries left).
FAILED - RETRYING: wait for hosts (5 retries left).
FAILED - RETRYING: wait for hosts (4 retries left).
FAILED - RETRYING: wait for hosts (3 retries left).
FAILED - RETRYING: wait for hosts (2 retries left).
FAILED - RETRYING: wait for hosts (1 retries left).
failed: [<IP_ADDRESS>] (item={'groups': ['hana'], 'host': '<IP_ADDRESS>', 'vars': {'sap_hana_is_primary': True}}) => {"ansible_loop_var": "item", "attempts": 12, "changed": false, "cmd": ["ssh", "-i", "~/.ssh/id_rsa", "-o", "StrictHostKeyChecking=no"<EMAIL_ADDRESS>"sudo", "true"], "delta": "0:01:15.015114", "end": "2022-01-26 16:03:56.821052", "item": {"groups": ["hana"], "host": "<IP_ADDRESS>", "vars": {"sap_hana_is_primary": true}}, "msg": "non-zero return code", "rc": 255, "start": "2022-01-26 16:02:41.805938", "stderr": "ssh: connect to host <IP_ADDRESS> port 22: Operation timed out", "stderr_lines": ["ssh: connect to host <IP_ADDRESS> port 22: Operation timed out"], "stdout": "", "stdout_lines": []}

Hi @vasu2809, the error "ssh: connect to host <IP_ADDRESS> port 22: Operation timed out" is typically caused by a firewall blocking access, so I am wondering if you see the same timeout when ssh-ing manually from the same host where you are running Ansible. If it were an issue with the user not being present, you would more likely see a permission denied error rather than a timeout.

Thanks @rjosephwright - I am running Ansible from my Mac desktop (Visual Studio)  and the SSH port is right now open to <IP_ADDRESS>/0, so I am not sure how firewall is blocking it, I am also thinking if IAP is an issue here - but if thats the case, I believe IAP problem should come when I try to SSH from GCP console as well.

IAP isn't used here by Ansible, so the ssh connection from the GCP console happens in a different way. I think the problem is that Ansible connects to the machines on their internal IP, and you are running Ansible from your desktop which cannot connect to them (unless you have e.g. Cloud Interconnect, but it sounds like that is not the case). I recommend running Ansible from a machine in the VPC to have direct access.

I tested the same script through AWX tower - installed it using the image available in the same network in which I am trying to install SAP application.
I get the below error while trying to deploy S4HANA-HA stack - now that AWX is able to SSH into the instances, I think it is not able to install the packages I believe and fails after 50 retries -
Wondering if we are missing any IAP configurations here -
{
"msg": "No provider of '+unrar' found.",
"rc": 104,
"stdout": "\n\n<message type="error">Package '+krb5-32bit' not found.\n<message type="error">Package '+libstdc++6-32bit' not found.\n<message type="error">Package '+pam-32bit' not found.\n<message type="error">Package '+python3-pip' not found.\n<message type="error">No provider of '+numactl' found.\n<message type="error">No provider of '+python-pip' found.\n<message type="error">No provider of '+unrar' found.\n\n",
"stderr": "",
"cmd": [
"/usr/bin/zypper",
"--quiet",
"--non-interactive",
"--xmlout",
"install",
"--type",
"package",
"--auto-agree-with-licenses",
"--no-recommends",
"--",
"+krb5-32bit",
"+unrar",
"+numactl",
"+python-pip",
"+python3-pip",
"+libstdc++6-32bit",
"+pam-32bit"
],
"invocation": {
"module_args": {
"name": [
"libopenssl1_1",
"tuned",
"krb5-32bit",
"unrar",
"numactl",
"sap-suse-cluster-connector",
"socat",
"libgcc_s1",
"libstdc++6",
"libatomic1",
"python-pip",
"python3-pip",
"libstdc++6-32bit",
"pam-32bit"
],
"state": "present",
"type": "package",
"disable_gpg_check": false,
"disable_recommends": true,
"force": false,
"update_cache": false,
"oldpackage": false,
"extra_args_precommand": null,
"extra_args": null
}
},
"stdout_lines": [
"",
"",
"<message type="error">Package '+krb5-32bit' not found.",
"<message type="error">Package '+libstdc++6-32bit' not found.",
"<message type="error">Package '+pam-32bit' not found.",
"<message type="error">Package '+python3-pip' not found.",
"<message type="error">No provider of '+numactl' found.",
"<message type="error">No provider of '+python-pip' found.",
"<message type="error">No provider of '+unrar' found.",
""
],
"stderr_lines": [],
"_ansible_no_log": false,
"attempts": 50,
"changed": false
}

Thank you - makes sense but all of the VM deployments for SAP HANA and Applications are deployed without internet access - will we still able to do the registration without network access for these VMs?
So, this would make NAT gateway deployment mandatory for the script to go through?
Resolution
Enable Internet access from the virtual machines to the Public Cloud Update Infrastructure servers. Once the virtual machine has network connectivity to the Public Cloud Update Infrastructure, you can have the on-demand virtual machine register to the SUSE Public Cloud Update Infrastructure by executing the following command as root:
registercloudguest --force-new
https://www.suse.com/support/kb/doc/?id=000019476

Doing a deployment without internet access requires more effort and will probably require building a custom image. If you just want to do a POC, I would highly recommend adding the NAT gateway.

Thank you for the prompt responses @rjosephwright  - so the question is if we roll this out to customers - can we have NAT gateway listed out as one of the prerequisites to be made available in the network or maybe bake it in the deploy-vars.yml file unless a SUSE for SAP image with the packages is made available for use.
Also, I enabled NAT gateway, ran registercloudguest --force-new on all instances of HANA and SAP and also ran python3 installation on all of them manually -and the script through AWX tower is going through now.
If I may point out a couple of things I noticed while executing script from my desktop (Visual Studio) and through AWX tower -

AWX prompted for sap_hana_instance_name character limit to 7 - which wasn't the case with my Visual Studio, I was able to provide more than 10 characters and the compute instance was created fine
Can we also have a dropdown input for sap_nw_instance_type for choosing the instance type just like how we have for HANA?
The script did not create the Service Account automatically when it doesn't exist- it has to be created manually else script threw an error.

@rjosephwright Thank you, I have tested most of the scripts and everything looks good, the only intermittent issue I see is with python installation package, and even that happens only once in a while, if I retry the same script without performing any additional manual steps like registercloudguest --force-new, it goes through fine.


Allow to sort pages by created_at and title

Hello,
I would like to propose the changes for sorting pages by created-at and title. It requires files_sorted_by_created_at to be implemented in adapters (I have implemented in the rugged one https://github.com/gollum/rugged_adapter/pull/32).
Please, let me know what do you think about this functionality and the solutions (if you have better ideas for the solution, I am willing to discuss and work on it)

@igor-drozdov Sorry for the slow reply. I think this could be quite a useful addition to gollum. @dometto What do you think?

Closing for now, please feel free to reopen against 5.x and explain the points I raised above


Unable to Compile SMCServer Psi with beta or nightly

What version of rust should I use
I got
posix4e@posix4e-HP-Spectre-x360-Convertible-15-bl1XX:~/src/rust-sgx-sdk/samplecode/psi/SMCServer$ make
make -C ../../../sgx_ustdc/ 2> /dev/null
make[1]: Entering directory '/home/posix4e/src/rust-sgx-sdk/sgx_ustdc'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/posix4e/src/rust-sgx-sdk/sgx_ustdc'
cp ../../../sgx_ustdc/libsgx_ustdc.a ./lib
LINK =>  app
make -C ./enclave/
make[1]: Entering directory '/home/posix4e/src/rust-sgx-sdk/samplecode/psi/SMCServer/enclave'
cargo build --release
   Compiling sgx_tstd v1.0.0 (file:///home/posix4e/src/rust-sgx-sdk/sgx_tstd)
   Compiling sgx_trts v1.0.0 (file:///home/posix4e/src/rust-sgx-sdk/sgx_trts)
   Compiling sgx_unwind v0.0.0 (file:///home/posix4e/src/rust-sgx-sdk/sgx_unwind)
error[E0554]: #![feature] may not be used on the beta release channel
  --> /home/posix4e/src/rust-sgx-sdk/sgx_trts/src/lib.rs:78:1
   |
78 | #![feature(alloc)]
   | ^^^^^^^^^^^^^^^^^^

error[E0554]: #![feature] may not be used on the beta release channel
  --> /home/posix4e/src/rust-sgx-sdk/sgx_trts/src/lib.rs:79:1
   |
79 | #![feature(allocator_api)]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: #![feature] may not be used on the beta release channel
  --> /home/posix4e/src/rust-sgx-sdk/sgx_trts/src/lib.rs:80:1
   |
80 | #![feature(fused)]
   | ^^^^^^^^^^^^^^^^^^

error[E0554]: #![feature] may not be used on the beta release channel
  --> /home/posix4e/src/rust-sgx-sdk/sgx_trts/src/lib.rs:81:1
   |
81 | #![feature(const_atomic_ptr_new)]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: #![feature] may not be used on the beta release channel
  --> /home/posix4e/src/rust-sgx-sdk/sgx_trts/src/lib.rs:82:1
   |
82 | #![feature(ascii_ctype)]
   | ^^^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: #![feature] may not be used on the beta release channel
  --> /home/posix4e/src/rust-sgx-sdk/sgx_trts/src/lib.rs:83:1
   |
83 | #![feature(asm)]
   | ^^^^^^^^^^^^^^^^

error: aborting due to 6 previous errors

For more information about this error, try `rustc --explain E0554`.
error: Could not compile `sgx_trts`.
warning: build failed, waiting for other jobs to finish...
error: build failed
Makefile:42: recipe for target 'libpsienclave.a' failed
make[1]: *** [libpsienclave.a] Error 101
make[1]: Leaving directory '/home/posix4e/src/rust-sgx-sdk/samplecode/psi/SMCServer/enclave'
Makefile:251: recipe for target 'psienclave' failed
make: *** [psienclave] Error 2
posix4e@posix4e-HP-Spectre-x360-

Hey there
It seems you are trying to compile the codes natively on your machine. So some preparation has to be done before making this sample.
If you want to use the master branch, please set up your environment according to the Dockerfile. There are four steps: (1) install all dependencies using apt-get, (2) install the SGX suites, (3) patch and build the SGX-2.1.3 source code and install libsgx_tlibc.a and (4) install the specific version of Rust nightly-2018-04-12
Since you are working on the psi samples, please install additional dependencies according to the Readme. And please make sure you have a registered SGX license key and set it up in GeneralSettings.h.
After all of these settings are done, you should be able to run the psi sample natively.
Again, we recommend using our docker images for playing :-)


Don't modify error results after tx finishes

Some results are marked as errors before the tx happens.  The code before was marking everything as successful when the multi-op tx finished.  This fixes that.
@malgorithms this should fix your test.

Actually, i'm going to turn off UseMulti for now...


Update ROIExtractors metadata test

Fixes #738.
This issue was caused by an update to extract_extra_metadata for scanimage, which adds a new group of metadata fields -- see roiextractors # 272.

Going to have to pin to dev ROI extractors in the testing requirements until next release
Unless you want to go ahead and cut a new release now?

Unless you want to go ahead and cut a new release now?

Yep, just cut a new release on ROIExtractors

All tests green, at long last. Thanks @h-mayorquin and @pauladkisson


#[\ReturnTypeWillChange] deprecated notice on ECS

Running ECS on rector-src on php 8.1 got the following notice:
> vendor/bin/ecs check --fix --ansi 'rules/DowngradePhp80/Rector/MethodCall/DowngradeReflectionClassGetConstantsFilterRector.php'
PHP Deprecated:  Return type of ECSPrefix20211216\Symfony\Component\OptionsResolver\OptionsResolver::offsetGet($option, bool $triggerDeprecation = true) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /Users/samsonasik/www/rector-src/vendor/symplify/easy-coding-standard/vendor/symfony/options-resolver/OptionsResolver.php on line 776

Deprecated: Return type of ECSPrefix20211216\Symfony\Component\OptionsResolver\OptionsResolver::offsetGet($option, bool $triggerDeprecation = true) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /Users/samsonasik/www/rector-src/vendor/symplify/easy-coding-standard/vendor/symfony/options-resolver/OptionsResolver.php on line 776
PHP Deprecated:  Return type of ECSPrefix20211216\Symfony\Component\OptionsResolver\OptionsResolver::offsetGet($option, bool $triggerDeprecation = true) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /Users/samsonasik/www/rector-src/vendor/symplify/easy-coding-standard/vendor/symfony/options-resolver/OptionsResolver.php on line 776

Deprecated: Return type of ECSPrefix20211216\Symfony\Component\OptionsResolver\OptionsResolver::offsetGet($option, bool $triggerDeprecation = true) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /Users/samsonasik/www/rector-src/vendor/symplify/easy-coding-standard/vendor/symfony/options-resolver/OptionsResolver.php on line 776

The symfony option resolver seems still doesn't has #[\ReturnTypeWillChange] on offsetGet
https://github.com/symfony/symfony/blob/e7142a6651bedb33dcce7fb33d2895e3032764e4/src/Symfony/Component/OptionsResolver/OptionsResolver.php#L915

Ok, so, the original code has mixed actual return:
https://github.com/symfony/symfony/blob/e7142a6651bedb33dcce7fb33d2895e3032764e4/src/Symfony/Component/OptionsResolver/OptionsResolver.php#L915
which originally valid.
but the downgraded version has only phpdoc:
https://github.com/symplify/easy-coding-standard/blob/6efa220af9f71058605330305b66b71b1fcc2836/vendor/symfony/options-resolver/OptionsResolver.php#L776
which make it invalid and require #[\ReturnTypeWillChange] so it works on php 7.x

It seems we need to have rector rule to apply #[\ReturnTypeWillChange] with class -> [...methods] configuration

I created feature request at rector https://github.com/rectorphp/rector/issues/6886

I created PR https://github.com/rectorphp/rector-src/pull/1544 to solve it for downgrade purpose.
The configurable independent rule ReturnTypeWillChangeRector still needed for upgrade purpose.

new symplify easy-coding-standard release is needed for it so the vendor code OptionsResolver class downgraded with add #[\ReturnTypeWillChange] on OffsetGet() method.


Add Ubuntu 23.04 support.

This change allows operators to deploy machines using Ubuntu 23.04 (Lunar).

Depends on changes to python-libjuju

https://github.com/juju/python-libjuju/issues/852

Its my understanding the ubuntu charm only follows LTS releases so sadly kinetic, lunar, and mantic wouldn't be included


Investigate libxml2 patches in USN-5548-1

This issue is to track an investigation into the upstream patches applied by Canonical to the 2.9.10-derived version
References:

https://ubuntu.com/security/notices/USN-5548-1
https://ubuntu.com/security/CVE-2016-3709
https://bugzilla.gnome.org/show_bug.cgi?id=769760

Analysis
The CVE in question was fixed by https://github.com/GNOME/libxml2/commit/c1ba6f54d32b707ca6d91cb3257ce9de82876b6f in libxml 2.9.11. This version of libxml2 has been present since Nokogiri v1.11.4 released on 2021-05-14.
Note further, though, that this vulnerability was named in:

CVE-2018-8048 in Loofah: https://github.com/flavorjones/loofah/issues/144
CVE-2018-3740 in Sanitize: https://github.com/rgrove/sanitize/issues/176
CVE-2018-3741 in rails-html-sanitizer: https://hackerone.com/reports/328270

and so the above patch was applied very early to Nokogiri's packaged libxml2 source, via commit 3872182, present in Nokogiri v1.8.3 released on 2018-06-16. Details can be found in https://github.com/sparklemotion/nokogiri/pull/1746 or in the above linked reports.
Summary
This vulnerability was identified and addressed years ago in Nokogiri and in the downstream Loofah, Sanitize, and rails-html-sanitizer gems. No action necessary.


refactor vision model loading

Motivation
Some vlm models have finetuned vision weights and there is no need to download original vision model.

internlm-xcomposer2-vl 还是需要下载 vision model

git+https://github.com/dvlab-research/MiniGemini.git

Seems they changed the repo name. https://github.com/dvlab-research/MGM

git+https://github.com/dvlab-research/MiniGemini.git

Seems they changed the repo name. https://github.com/dvlab-research/MGM

@irexyc may update the hint

May check if deepseek vl also needs refactoring to avoid downloading weight.

deepseek vl won't download vision model
https://github.com/deepseek-ai/DeepSeek-VL/blob/main/deepseek_vl/models/clip_encoder.py#L71-L75
https://huggingface.co/deepseek-ai/deepseek-vl-7b-chat/blob/main/config.json
https://huggingface.co/deepseek-ai/deepseek-vl-1.3b-chat/blob/main/config.json


The Alerts appears differently in browsers

The Alerts appears differently in IE, Firefox and Chrome:
The exclamation mark is black only in IE.
Reference: http://swiss.github.io/styleguide/content_modules_-_widgets.html#a-alerts
Chrome

Firefox

IE

The font icons should be replaced with a more future-friendly component.

https://jira.liip.ch/browse/SWG-93

This will be fixed with 3.0

No milestone is mentioned. Was ist fixed with 3.0 ?

Both missing icons and size issue were fixed in 3.0.0

There still seems to be an issue with this.
This is a screenshot of the styleguide in IE 10.0.9xx:

There only seems to be a problem with .alert-warning exclamation mark icon.


Actural flash cartridge?

was just wondering. could you create an actual flash cartridge, that could load say a .PSV off SD and implement CMD56 to authenticate with an unmodified vita ..? and then like .. play the game?
(could also be useful for "reproduction" cartridges, i guess)
Thanks?

not possible with .PSV as the 'key1' and 'key2' provided are the result of sha256 hash of some data from packet18 and packet20


[JOSS review] Manuscript summary

The "Summary" section of the manuscript is too short and does not provide enough information about the purpose of the library - other than telling the reader that it is a library about spatial networks. I would suggest extending the sentence "To this end, spaghetti (spatial graphs: networks, topology, & inference), a sub-module in the wider PySAL ecosystem (see Figure 1), was developed to address network-centric research questions with a strong focus on spatial analysis." with a very brief overview of the main functionalities of the library. I believe that by reading the summary, a potential user should be able to assess whether the tool is of its interest.
https://github.com/openjournals/joss-reviews/issues/2826

We appreciate the suggestion that substantially improve the readability of our manuscript, and have made appropriate additions to the summary:

Through spaghetti, first, network objects can be created and analysed from collections of line data by various means including reading in a shapefile or passing in a geopandas.GeoDataFrame at which time the line data are assigned network topology. Second, spaghetti provides computational tools to support statistical analysis of so-called network-based events along many different types of previously loaded networks. Network based-events or near-network observations are events that happen along spatial networks in our daily lives, i.e. locations of trees along footpaths, biking accidents along roads or locations of coffee shops along streets. As with spaghetti.Network objects, spaghetti.PointPattern objects can be created from shapefiles, geopandas.GeoDataFrame objects or single libpysal.cg.Point objects. Near-network observations can then be snapped to nearest network segments enabling the calculation of observation distance matrices. Third, these observation distance matrices can be used both within spaghetti to perform clustering analysis or serve as input for other network-centric problems (e.g. optimal routing), or within the wider PySAL ecosystem to perform exploratory spatial analysis with esda. Finally, spaghetti’s network elements (vertices and arcs) can also be extracted as geopandas.GeoDataFrame objects for visualization and integrated into further spatial statistical analysis within PySAL (e.g. esda).

We have also included a statement of need connected to the Related Works (see also Issue #575):

While all the libraries above are important for network-based research, spaghetti was created and has evolved in line with the Python Spatial Analysis Library ecosystem for the specific purpose of utilizing the functionality of spatial weights in libpysal for generating network segment contiguity objects. The PySAL project was started in the mid-2000s when installation was difficult to maintain. Due to the non-triviality of relying on dependencies to secondary packages, a conscious decision was made to limit dependencies and build native PySAL data structures in cases where at all possible. Therefore, the original pysal.network submodule was developed to address the need for integrating support for network data structures with PySAL weights data structures, with the target audience being spatial data scientists and anyone interested in investigating network-centric phenomena within PySAL. Owing to the co-development of network functionality found within spaghetti and the evolution of the wider PySAL ecosystem, today, the package provides specialized network functionality that easily integrates with the rest of PySAL. This allows users of spaghetti’s network functionality to access spatial analysis functionality that complements network analysis, such as spatial statistical tools with esda and integration with core components of libpysal: libpysal.weights (mentioned above), libpysal.cg (computational geometry and data structures), libpysal.io (input-output), and libpysal.examples (built-in example data).


Claims, view slots and the camera wall

I would like to propose the following changes to the behavior of !view and the camera wall.

If you !view a module, and you're already occupying a view slot, and all other view slots have a claimed module in them, the new module should replace the existing view slot. (In other words, a player can only take up two view slots if there are view slots to spare.) Pinned views (such as FMN) are excepted.

If you !view a module, and you are not using a view slot, but someone else is using two, replace one of that player's.

If you !view a module and there are already 6 unique players taking up the view slots, the camera wall should automatically engage and show all claimed modules. Bonus points if it also automatically runs !modules instead of showing a mostly black screen.

When a module is solved, reevaluate the situation to see if a claimed module can be brought back into view and/or the camera wall can be turned back off.

In the case of camera wall being enabled, a !bomb turn should automatically move unclaimed modules currently occupying a camera slot to the back of the line, so that the next set of modules available will show up in the unclaimed camera slots.  In this way, !bomb turn will still be effective when the camera wall is enabled.

Can we close this issue now? From what I can tell, most of this behaviour is happening now


Does Training work with multiple GPUs?

Tried running
devices 4
accelerator gpu
but when using devices > 1 it doesn't work (Tried with running on 2,3 and 4 A100 80gb)

It could be that I need to downgrade Cuda (currently running CUDA 12.0)


Add Nebraska truck and scenic shields

Fixes #649
Fixes #651
Test location (localhost link)

Whoops, did that one on the wrong branch.

I've somehow branched this off of the wrong place and I'm not sure how to fix it.

Thanks!  I think we got this sorted now :grimacing:

I’d still recommend a rebase. The current state of this branch is likely to introduce a bad merge.

Ok, I think I got it now.

I've somehow branched this off of the wrong place and I'm not sure how to fix it.

https://github.com/git/git/blob/master/Documentation/git-rebase.txt#L101-L159


armv7:  get_regular_files_non_recursive(/vcpkg/triplets): Value too large for defined data type

Describe the bug
I am getting an error when installing packages on armv7, using Docker multiarch build.
Environment

OS: Docker multibuild via buildx, on armv7 target
Compiler: revision

To Reproduce
Steps to reproduce the behavior:
In Dockerfile:
FROM ubuntu:20.10
ENV DEBIAN_FRONTEND noninteractive
RUN apt-get update && apt install -yy -q --no-install-recommends ca-certificates libssl-dev git build-essential autoconf libtool pkg-config libtool curl make g++ zip unzip tar ninja-build
RUN curl -L -o cmake-3.22.0.tar.gz https://github.com/Kitware/CMake/releases/download/v3.22.0/cmake-3.22.0.tar.gz && file cmake-3.22.0.tar.gz && tar xvf cmake-3.22.0.tar.gz && cd cmake-3.22.0 && ./bootstrap && make && make install && cd / && rm -rf ./cmake-3.22.0*
RUN git clone https://github.com/microsoft/vcpkg
RUN ./vcpkg/bootstrap-vcpkg.sh
ENV VCPKG_FORCE_SYSTEM_BINARIES=1
RUN ./vcpkg/vcpkg install restinio json-dto spdlog
RUN ./vcpkg/vcpkg integrate install
Built with:
docker buildx build --push --platform linux/amd64,linux/arm/v7 -t image_name_goes_here .
Expected behavior
Package installation should be successful on armv7. This arch is needed for Docker images for Raspberry Pi 3B+
Failure logs
=> ERROR [linux/arm/v7 12/14] RUN ./vcpkg/vcpkg install restinio json-dto spdlog                 0.4s

[linux/arm/v7 12/14] RUN ./vcpkg/vcpkg install restinio json-dto spdlog:
#17 0.286 get_regular_files_non_recursive(/vcpkg/triplets): Value too large for defined data type

Dockerfile:39
37 |     RUN ./vcpkg/bootstrap-vcpkg.sh
38 |     ENV VCPKG_FORCE_SYSTEM_BINARIES=1
39 | >>> RUN ./vcpkg/vcpkg install restinio json-dto spdlog
40 |     RUN ./vcpkg/vcpkg integrate install

41

error: failed to solve: rpc error: code = Unknown desc = process "/bin/sh -c ./vcpkg/vcpkg install restinio json-dto spdlog" did not complete successfully: exit code: 1

Additional context
The vcpkg commands run without error for the linux/amd64 Docker build target.

Duplicate of #21189 :)

@vladimir-voinea ,Thanks for posting this issue, this issue duplicate of #21189, temporarily close this issue, we will track it in issue #21189


Implement Wisp Super Staff Bros

There's still things in here that are preventing it from being ready for merge, I'll work on it later.

Okay, I'm done on this PR.  @jd4564  and other collabs can change it by pushing to the wssb branch.  I only wanted to create a PR where people could actually work on it from, not be the one to actually work on it.

Since mods/WSSB/statuses.js doesn't actually implement anything new, I think it's okay to delete that file

no travis errors
code seems preety legit
origin used the same code

preety cool @Volcos

There's no travis errors because jd and I took it over

This no longer seems to be "out right crashing" - at least, not with the limited amount of testing that I had done on it so far today.
The fact of the matter is now we have two viable options: 1. We create bots to stress-test the tier, making sure that the rest of it is good to go and patch if/when necessary before merging. 2. We just push it to the production server and patch bugs if/as they happen.
Of course, one option is definitely preferred, but the people who should be working on this aren't going to be, so we need to look at those two options with that in mind.
Also, in testing, there was one request before pushing

LotusChamp Torpid: can you remove thick fat from alan?

So, what now, @jd4564?

Yᵒᵘ Oᶰˡʸ Lᶤᵛᵉ Oᶰᶜᵉ

best commit summary ever


consolidate_metadata for tables

See discussion at https://github.com/ome/ngff/pull/64/files#r1025073730
In order to allow full access to all the tables metadata when the ability to ls subdirectories is not available (e.g. over https / s3), consolidate_metadata() can be used to add metadata to the image.zarr/tables group.
This would also provide a work-around for the listing of tables within that top-level tables group. See https://github.com/ome/ngff/pull/64/files#r1022858025
cc @ivirshup @joshmoore

consolidate_metadata isn't in the v2 spec and isn't supported by all implementations. I would not suggest we go that route unless absolutely necessary.

My main thinking here is that I don't want to be on the hook for essentially maintaining a copy of information already encoded by the Groups.

@joshmoore

consolidate_metadata isn't in the v2 spec

Did this come up as a possible backport to v2? It seems quite important to zarr's cloud friendliness.

and isn't supported by all implementations

What's the support like among implementations that are currently used for OME-NGFF?

IIRC netcdf/ xarray's zarr format doesn't require something like this, right?
I'm wondering if it just didn't come up, or if they just implemented consolidated metadata.

I don't want to be on the hook for essentially maintaining a copy of information already encoded by the Groups.

I agree it's not ideal but the other alternatives I don't see as improvements.

Did this come up as a possible backport to v2? It seems quite important to zarr's cloud friendliness.

There's https://github.com/zarr-developers/zarr-specs/issues/113 but it's a pretty major undertaking. (I refer to my oft cited metric of 6 months to introduce dimension_separator). It would also take away from the v3 effort.

What's the support like among implementations that are currently used for OME-NGFF?

Python only as far as I know.

IIRC netcdf/ xarray's zarr format doesn't require something like this, right? I'm wondering if it just didn't come up, or if they just implemented consolidated metadata.

xarray relies heavily on consolidated_metadata. I don't think netcdf does, but they have other extensions in "nczarr" that may be similar.

@will-moore, responding to your comment: https://github.com/ome/ngff/pull/64#discussion_r1026401547

 Your suggestion

E.g. add this to write_table_regions() from the ome-ngff-tables-prototype:

    # write group names into .zattrs
    table_path = os.path.join(group.store.dir_path(), group.path, table_group_name)
    for sub_dir in ["layers", "obsm", "obsp", "raw", "uns"]:
        sub_path = os.path.join(table_path, sub_dir)
        if not os.path.exists(sub_path):
            continue
        children = [f.name for f in os.scandir(sub_path) if f.is_dir()]
        sub_group = table_group[sub_dir]
        sub_group.attrs[sub_dir] = children
E.g. obsm/.zattrs now looks like this:

{
    "encoding-type": "dict",
    "encoding-version": "0.1.0",
    "obsm": [
        "X_scanorama",
        "X_umap",
        "spatial"
    ]
}

You could instead do:
group: zarr.Group

keys = []
group.visit(lambda x: keys.append(x))
group.attrs["keys"] = keys

But this is basically just a worse version of consolidated metadata. I think it would make more sense to just add consolidated metadata to the spec than having to design an alternative. Especially since there aren't that many cases in the anndata specification where you know whether the child nodes are Groups or Arrays.
@joshmoore

There's https://github.com/zarr-developers/zarr-specs/issues/113 but it's a pretty major undertaking.

My read here is that interest has dropped in favor of instead solving it in v3?

I don't think netcdf does, but they have other extensions in "nczarr" that may be similar.

It looks like they have an alternative: https://docs.unidata.ucar.edu/nug/current/nczarr_head.html#autotoc_md22
They store an bunch of extra jsons with information like a list of variables. These can be turned off with mode=nczarr,zarr, inference rules for which are defined right below.

I agree it's not ideal but the other alternatives I don't see as improvements.

@joshmoore @will-moore
I think "relying on the hierarchy provided by zarr" would be an improvement. It's just that for some implementations, with some stores, the hierarchy doesn't work.
To me, this reads as an issue with zarr. Perhaps one that needs a temporary work around, but ultimately one which should be fixed in zarr.
From this perspective, I would propose minimizing what needs to be done – and making it easy to revert and rely on the zarr hierarchy instead.
So maybe just saying tables should store the a consolidated metadata json or list of keys at their root in OME-NGFF? Then removing this once the spec moves up to v3 or v2 gets consolidated metadata, which ever happens first.
side notes

I would be very interested in knowing how commonly "no ls" problem occurs.
I do not think "s3 ls is slow" is something that should impact decisions here. consolidated_metadata is a much better solution to s3 being slow – and the current implementation is to make a request at each level of the hierarchy.

My read here is that interest has dropped in favor of instead solving it in v3?

From the POV of the other implementors, I think this would count as a significant change (and related implementation burden).

To me, this reads as an issue with zarr. Perhaps one that needs a temporary work around, but ultimately one which should be fixed in zarr.

I think it's fair to say that it's something that needs to be clarified at the Zarr Spec level, but if there remains a possibility that there's a fileset which is not listable, then the design of NGFF specifications will be forced to deal with that.

Are the implementors up for this being solved in v3?

I think there will definitely be work on this at the spec level in v3. I don't want to put words in the implementors' mouths though :)

As a broader question, how common are unlistable stores and why are people hosting data in them?

AWS S3 buckets and other object storage can be configured to not allowing listing. (We even recently ran into this for an AWS Open Data bucket)
HTTP servers don't have a standardized way to provide file listings. (You can attempt to parse the HTML that a url/ returns to find all links, but YMMV.)

Data generated with save_load_squidpy_segment.py script, with the tweaks from the current state of this PR is deployed at https://minio-dev.openmicroscopy.org/idr/temp_table/test_segment.zarr/tables/regions_table and can be viewed with:
https://deploy-preview-20--ome-ngff-validator.netlify.app/?source=https://minio-dev.openmicroscopy.org/idr/temp_table/test_segment.zarr/tables/regions_table
This includes adding child group names to parent group .zattrs under "keys": [].
E.g.
/test_segment.zarr/tables/regions_table/obsm/.zattrs:
{
    "encoding-type": "dict",
    "encoding-version": "0.1.0",
    "keys": [
        "X_scanorama",
        "X_umap",
        "spatial"
    ]
}

Also, an extra step required for viewing data in the browser via zarr.js is to convert int64 arrays to int32 dtype by running an additional script included above:
# generate the data...
$ python save_load_squidpy_segment.py

# fix dtypes for `obs` data
$ python fix_dtype.py test_segment.zarr/tables/regions_table/obs


Enhancement: Multimodal Content Support via SRT File Generation

Current Scope: "aifs" excels in local semantic search for text-based content.
Proposed Enhancement: Extend capabilities to include audio and video content.
Implementation:

Generate .srt Files: Utilize tools like Whisper (runs great locally on most computers) for transcribing audio and video into subtitle files.
Search Integration: Incorporate these .srt files into the search functionality.

Outcome:

Search Utility: Enable searches to return specific segments from multimedia content.
Timestamps Feature: Provide timestamps alongside search results for precise referencing.

Impact: This enhancement would transform "aifs" into a comprehensive tool for searching across various content formats, greatly expanding its usability.

A good ressource to assist with this is: https://github.com/sindresorhus/awesome-whisper

oh I love this @mysticaltech. will make a ROADMAP.md and put this there. thanks!

@KillianLucas Just stumbled on that high level whisper library, it seems ideal for the job. I checked in the code, the real API is more extensive than what is presented in the readme. https://github.com/kadirnar/whisper-plus


Implement static Shadow method GetEmptyShadowDocument

Shadow:: namespace was missing for static method GetEmptyShadowDocument

Hi @GiDW,
Thank you for pointing this out. We will add this fix in the next release of the SDK. Please do let us know if you find any further issues.
Rahul

Merged into master. Will release with next version.


Remove duplicate arguments from CentOS

Yay, green build!

Yay, green build!

Yeah, sorry for the slow down caused by the DockerHub rate limit. We are in discussion with Docker, but both them and us (infra) were a bit overwhelmed the 2 pasts weeks. I'll check the builds during this upcoming (long) weekend: there might be a short term solution until rate limiting is extended, by using public IP and no docker login. That would not be fair to Docker but that would solve the short term problem.


Fidesops should confirm which collections are reachable pre-execution, and gracefully error when tables are unreachable

Before Fidesops begins to execute a privacy request, it should...

be aware of which databases (or in a future state, HTTPS connectors) an execution will require based on the policy and projected identity graph
confirm whether Fidesops can access those database connections
execute the request only on the minimum required databases to execute the privacy request given the identity graph and policy

If a database table/collection is not reachable, Fidesops should noticeably error so that the user/operator knows exactly which db connection, which collection (if applicable) and which field(s) (if applicable) is unreachable, and for what reason.

This means Fidesops will gracefully error if it can't reach a table that is defined in the dataset. Knowing which tables are required to be reachable requires knowledge of the Policy in execution time.
More refinement is required here — how can we define reachability from the Policy rather than in general.

Specifically, what I think we need here is the ability for Fidesops to support traversing datasets where there are collections that are not reachable - as long as those collections don't contain any data categories that are needed by the request policy.
That's kind of a mouthful, but it's easier to see via example.
Example
For this example, assume we have this dataset:
dataset:
  - fides_key: test_dataset
    collections:
      - name: address
        fields:
          - name: city
            data_categories: [user.provided.identifiable.contact.city]
          - name: id
            data_categories: [system.operations]
            fidesops_meta:
              primary_key: True

      - name: customer
        fields:
          - name: address_id
            data_categories: [system.operations]
            fidesops_meta:
              references:
                - dataset: test_dataset
                  field: address.id
                  direction: to
          - name: created
            data_categories: [system.operations]
          - name: email
            data_categories: [user.provided.identifiable.contact.email]
            fidesops_meta:
              identity: email
          - name: id
            data_categories: [user.derived.identifiable.unique_id]
            fidesops_meta:
              primary_key: True

      - name: report_cache
        fields:
          - name: report_hash
            data_categories: [system.operations]
          - name: report_value
            data_categories: [user.derived.nonidentifiable]

This dataset has three collections:

address which contains user identifiable data, reachable via customer.address_id
customer which contains user identifiable data, reachable via customer.email
report_cache which is some imaginary cache that stores the result of some computation for a user; this isn't identifiable, but in theory you might annotate this as user.derived.nonidentifiable as it's derived from their usage

Note that the report_cache table isn't traversable via fidesops - the application simply uses this as a persistent cache based on some hash that it computes in app code that we don't understand.
Depending on the policy, this dataset should be either supported or not!
Case 1: Target Data Categories = [user.provided] -> VALID
When the request policy is for user.provided, this should be a valid dataset as we only need to traverse customer and address to get everything we need.
Case 2: Target Data Categories = [user] -> INVALID
When the request policy is for user, this should be an invalid dataset as we should also need to traverse report_cache to get to the report_value field, but that's not possible.
Today, our code would correctly reject this dataset for case 2, but would also reject this dataset for case 1. This ticket should change that and allow both cases to work as expected 👍

This is very clear. Brings up a few questions (of course):

a) since the validity of the traversal is dependent on the categories and use, on a request that asks for multiple actions, how to we respond to a situation where "we can take action A, but not B"?
b) is it ever valid to run a partial traversal? That is, maybe it's better, instead of failing the whole run, to echo something like "We can run this but the collections [db1.tableY, db2.tableX] are unreachable - do you want to proceed?" This could simplify how we respond to a)
c) we could also allow for some kind of annotation like "do_not_query" or something that would indicate something like "This should be skipped in access/This should be skipped in erasure/This can be skipped in... ".

I don't think you meant to close this- reopening!

Kicking out of 1.1.0 in favor of moving to the prioritized backlog. Not blocking for the release but is a really solid optimization for query running.


Create EasyCLA.md [DELETE]

Test only, ignore

IRONY

@jpalmerLinuxFoundation are you done with this PR? Or should it stay open a bit longer?


Connection through TOR not working

Hello,
I'm currently testing qsocket (qs-netcat) and can't connect to the client through TOR.
-T switch brings the following error:
[ERROR] invalid knock response
I also tried to specify the proxy through the -x switch, with the same result.
Thanks!

Thanks for reporting.
This issue is due to the Cloudflare's restrictions to connections coming from TOR network. It should be fixed with the latest v0.0.7-beta release. Now qsocket is using its own onion address for connections over TOR effectively bypassing CF.


developer docs: document how get_storage_at works in db

Code docs :partying_face:
This documents how a get_storage_at lookup works under the hood.

Rendered


dispatch-cli create command throws error on path parameter

After running de dispatch create command I get the following error...
running command> dispatch create --bot wbs.bot --luisAuthoringRegion westeurope
Exporting services for dispatch...
Exporting qnaname QnA kb...
Exporting luisname LUIS application...
Creating dispatch LUIS model json...
Creating training data...
Value cannot be null.
Parameter name: path
what am I missing... which "path" parameter are we talking about and where should it be set?

@robkostermans

how did you run the command dispatch init [options] first, before trying the dispatch create command? More specifically, what options did you include?

I ask, because you seem to be using optional --luisAuthoringRegion in your create command, when looking at the botbuilder-tools dispatch repo it looks like --luisAuthoringRegion should be used with init command
Note in Dispatch repo it does not show --luisAuthoringRegion as an option for create
For example
dispatch init -n TestDispatch --luisAuthoringKey F57AEEEBE67349C282E1DC51F6BA66D9 --luisAuthoringRegion westus

Additionally, trying to repro what you've done, how did you create your .bot file?
I get a different error when I attempt your command, so seeing the exact commands you input would be helpful

@robkostermans, could you share your bot file with @zerryth and see if she could repro?  Make sure not to copy and paste here since it contains keys..  Btw, any reason why you specify luisAuthoringRegion for create?

@robkostermans
Update:
Successfully created dispatch model doing the following steps:
npm install -g botdispatch
dispatch init -name YourDispatchAppName -luisAuthoringKey "YOUR-LUIS-AUTHORING-KEY" -luisAuthoringRegion westus
dispatch add -type luis -id "YOUR-SubLuisApp-ID" -n homeautomation -v 0.1 -k "YOUR_LuisSubscriptionKey"
dispatch create --bot 57942.bot --luisAuthoringRegion westus

Success! Glad it worked out in the end :)
Also thanks for the clarification and feedback on where the confusion came from.


problem while working with elasticsearch-mapper-attachments plugin

Hello,
I got a little trouble while trying to use Nest with elasticsearch-mapper-attachments plugin.
In fact, the mapping from attributs defined in a class doesn't seem work well.
The detail is here listed in stack overflow
http://stackoverflow.com/questions/25917386/client-net-nest-with-attachment-highlight-feature
Appreciate if you can give me some advice on it.
Thank you very much
Yuan

@jacyuan Hi Jacyuan... I am working on something similar to yours.. I have a folder in which i have some documents(pdf,.doc, .docx) and i have to read all of the documents in the folder and index them to ES server.(using NEST) I searched a lot on google for some possible solution and couldnt find any. Can you please help me in solving this. (like how do i start, what should be the flow be like or any sample code if you have) TIA :)


#add FAQ section in Quick links

add frequently asked questions along with their answers to quickly resolve customer doubts on common issues

hi @Tejashri-Taral pls add level label and also i have raised a PR
pls do check
thanks


Typographical Error #2

[Section: Add a project configuration file —> (https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/guidance/use-sp-pnp-js-with-spfx-web-parts#add-a-project-configuration-file)]
Issue: The word 'the', is typed as 'hte'.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4b19eb96-192d-2d8b-8d4e-0de787f22093
Version Independent ID: e2cbd2b2-8bb7-a95f-0768-15f1b045b4c4
Content: Use @pnp/sp (PnPJS) library with SharePoint Framework web parts
Content Source: docs/spfx/web-parts/guidance/use-sp-pnp-js-with-spfx-web-parts.md
Product: sharepoint
Technology: sharepoint-framework
GitHub Login: @VesaJuvonen
Microsoft Alias: vesaj

Fixed now - thanks for the heads up.


Adding challenges and opportunities tracker to Github

Create separate organization level project for challenges and opportunities

Add all information from sharepoint
share with governance groups

Create review plan for the challenge and opportunity

categorize
review
accept/reject
timeline for review

@sjurl i have started this and want you to take a look and see if you think this will work before i put all the entries across:
list view https://github.com/orgs/ices-eg/projects/6/views/1
board view https://github.com/orgs/ices-eg/projects/6/views/2
the project board is now linked to the DIG projects (note that the new project type sits at the ICES-EG organization level, rather than within the DIG repository

Everything moved from sharepoint to github https://github.com/orgs/ices-eg/projects/6/views/1


Add mocks for HTTP requests

Issue https://github.com/juhalehtonen/ex_uptimerobot/issues/6
Added mocks via https://github.com/jjh42/mock

A big thank you for the PR! Much appreciated.


add useRouter hook

Adds useRouter hook.
I think it useful as a hook alternative to withRouter.

In this case you could also refactor useParams, useLocation, useHistory and useRouteMatch. Let's discuss this with @mjacksons who is currently working on the RR hooks.

@mjackson @MeiKatz can we re-open this for discussion?
I was surprised to see a 5.1.0 release and useRouter was not included at all! This seems unintuitive to me... we already had the withRouter api, so useRouter seemed like the first obvious hook to add.


feat: port data.char

mathlib3 SHA: aab56fd783b265168f660d6b46709961153c4c20
Note: This file already existed in Mathlib4, so the material from mathlib3 was just added, but didn't replace the existing results.

bors d+

maintainer merge

bors merge


[MINOR] docs: improvements to readability

What changes were proposed in this pull request?
Improve documentation.
Why are the changes needed?
For clarity and readability.
Fix: # N/A
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Built on local machine.

Not sure we have a concept of a Gravitino table.

I think we don't.

@cottage14 would you please fix the conflicts and update the PR description, thanks!

I do not understand the proposed change so we end up saying "unit tests"
twice. Unit and integration tests are very different things.
a
On Tue, Feb 6, 2024 at 9:56 AM Qi Yu @.***> wrote:

@.**** commented on this pull request.
In docs/how-to-test.md
https://github.com/datastrato/gravitino/pull/1992#discussion_r1479846178
:

@@ -5,26 +5,28 @@ license: "Copyright 2023 Datastrato Pvt Ltd.
This software is licensed under the Apache License version 2."

-Gravitino has two types of tests: unit tests and integration tests. Unit tests are mainly
-focused on the functionalities of the specific class, module, or component. Integration tests
-are end-to-end tests that cover the whole system.
+Gravitino has two types of tests:
+

unit tests and integration tests that mainly

"unit tests and integration tests" -> "unit tests and unit tests"
—
Reply to this email directly, view it on GitHub
https://github.com/datastrato/gravitino/pull/1992#pullrequestreview-1865261892,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC3RFXI4KNITGF74SCBOS6DYSIZBFAVCNFSM6AAAAABCWQDKXSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNRVGI3DCOBZGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Andrew Wetmore
Editor, Moose House Publications https://moosehousepress.com
Editor-Writer, The Apache Software Foundation https://apache.org

I do not understand the proposed change so we end up saying "unit tests" twice. Unit and integration tests are very different things. a
…
On Tue, Feb 6, 2024 at 9:56 AM Qi Yu @.> wrote: @.* commented on this pull request. ------------------------------ In docs/how-to-test.md <#1992 (comment)> : > @@ -5,26 +5,28 @@ license: "Copyright 2023 Datastrato Pvt Ltd. This software is licensed under the Apache License version 2." --- -Gravitino has two types of tests: unit tests and integration tests. Unit tests are mainly -focused on the functionalities of the specific class, module, or component. Integration tests -are end-to-end tests that cover the whole system. +Gravitino has two types of tests: + + - unit tests and integration tests that mainly "unit tests and integration tests" -> "unit tests and unit tests" — Reply to this email directly, view it on GitHub <#1992 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3RFXI4KNITGF74SCBOS6DYSIZBFAVCNFSM6AAAAABCWQDKXSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNRVGI3DCOBZGI . You are receiving this because you were mentioned.Message ID: @.***>
-- Andrew Wetmore Editor, Moose House Publications https://moosehousepress.com Editor-Writer, The Apache Software Foundation https://apache.org

unit tests and integration tests that mainly focus on the functionalities of the specific class, module, or component
Obviously, integration tests that here is unit test not integration test, it's a mistake here.

The original looks correct to me as there are two types of tests: unit tests and integration tests.

@cottage14 Do you need a hand in resolving the conflicts?

@justinmclean would you please help to solve the conflicts and move forward this PR? Thanks a lot.

@cottage14 Do you have time to work on some minor issues here? @justinmclean Can you please help to move this forward if @cottage14 is not available? Thanks!

@justinmclean can you please continue on this and fix the issues I mentioned above.

It is fixed by #2631 , thanks a lot for your work @cottage14 . I'm going to close this PR.


test-branch/execute-job/wrong-commit-sha-on-pr/90d5cae3-6d5c-4d3f-859f-31dc881efe05

PR for testing ed0bbb90236c10d664e7b57ea4bca668f679057f

/canonical/self-hosted-runners/run-workflows 931ad21dd9ace68aaa0a7d341e94de96ad93fa6b


Last three Turbo/Stimulus conversions

Doing a PR off the PR to isolate test issues.

coverage: 92.992% (-0.4%) from 93.382%
when pulling 24303dc5952f70428ff151686bca7ae2eebc2c9f on nimmo-importmap-last-controllers
into 7eb7043bdfdb9e7b038c9cfe2cbb7e13bcf648ee on nimmo-importmap-stimulus.


FadeOff leaves LED glimming

When the FadeOff function reaches the last period step, the LED still glows as it is not fully switched off. There should be an implemented auto-off after end of fading time.
Library version: 4.5.1
Controller: ESP32-WROOM-32 at a small dev board (AZdelivery)
My Code:
#include "jled.h
#define PIN_LED_INSIDE 1
auto LEDInsideOn = JLed(PIN_LED_INSIDE).LowActive();

bool schalter = true;

void setup() {
  LEDInsideOn.On();
  LEDInsideOn.Update();
  delay(500);
  LEDInsideOn.FadeOff(10000);
  LEDInsideOn.Update();
}

void loop() {
  LEDInsideOn.Update();
}

I dont have the original schematic by hand and can not find it in the web. It's a LowSide switched LED in principle like this;

Hi,
could you please provide  complete, minimal example C++ code and an schematic of the circuit you used so I can check the behaviour?
Which version of JLed are you using?

Hi,
thanks for your quick response.
I updated my original post with more information :)

I did some experiments and it seems like we hit this ESP32 problem: https://github.com/espressif/arduino-esp32/issues/689
The LED stays dim on in this simple example:
#include <jled.h>

auto led = JLed(22).On().LowActive();
void setup() { }

void loop() {
  led.Update();
}

I'll provide a workaround in the next days

See #61 for a fix - does it work for you?

@marmil does the fix solve the problem?

@jandelgado Works. Thank you 👍

fix released with 4.5.2


Use ANSI color codes on Windows as well

Description
Windows' console supports ANSI escape sequences since Windows 10.
https://learn.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences
PHP enables this by default since PHP 7.2.
https://www.php.net/manual/en/function.sapi-windows-vt100-support.php
On older PHP versions, the output with --colors will not be correct, but this is already the case when using this option.
PHP CodeSniffer special-cased Windows in this code in 2014 (bfd095d39895abef6afae575382d58f7ad058232). This workaround is no longer needed today in 2024.
Note that the --colors option was already supported on Windows. This only affects inline highlighting in error and debug messages.
Also document problems with printing Unicode characters to Windows console before PHP 7.1.
https://www.php.net/manual/en/migration71.windows-support.php
Perhaps this workaround can be removed too one day.
Suggested changelog entry

On Windows, output when using the --colors option now has more colors.

Related issues/external references
(none)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

[ ] This change is only breaking for integrators, not for external standards or end-users.

[ ] Documentation improvement

PR checklist

[x] I have checked there is no other PR open for the same change.
[x] I have read the Contribution Guidelines.
[x] I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
[ ] I have added tests to cover my changes.
[x] I have verified that the code complies with the projects coding standards.
[ ] [Required for new sniffs] I have added XML documentation for the sniff.

@MatmaRex Thanks for the PR.
However, similar to the other PR, I need to ask you to please either provide a reproduction scenario, screenshots or tests to demonstrate what you are trying to solve. Preferably all three of these should be provided with any PR which changes things in the UI.
I can take a guess what you are trying to solve, but my guess may be wrong, so without any of the above, I can't even begin to properly evaluate the PR.

PHP enables this by default since PHP 7.2. https://www.php.net/manual/en/function.sapi-windows-vt100-support.php

PHPCS 3.x still has a minimum supported PHP version of PHP 5.4, so we cannot rely on features from PHP 7.2.
Please test your changes with PHP < 7.2 and see what breaks (and yes, things will break).
I could tentatively earmark this PR for PHPCS 4.0 , which will have a PHP 7.2 minimum, but that still doesn't negate my remarks above.

@MatmaRex

The --no-colors mode is unaffected by my patch. I believe nothing new breaks.

Given the following simple file:
<?php

    // This is a space indented line.
    $a = 10;
	// This is a tab indented line.

And running the following command on the Windows 10 command line:
phpcs ./phpcs-662.php --report=code --tab-width=4 --no-colors --standard=generic

:point_up: Take note of the use of --report=code as that's the report which is being adjusted in this PR (amongst other things). Also note that this is in no-colors mode.
On PHP 8.4, everything looks swell:

Before
After

Not so much on PHP 7.0....:

Before
After

Which only goes to demonstrate why I insist on tests and will continue to do so...

If you really want to support these old systems, the only thing to do would be to disable --colors entirely. I could write a patch for that, if you promise you won't ask me for any test cases for it. I'm not sure what the point would be since they wouldn't run in CI anyway.

Proper tests will run in CI and should have caught the above. If not, the tests would not be good enough.

Oh, right, the "visible" characters are still applied in --no-colors mode. Thanks for pointing that out.
The encoding issue is interesting – it happens with PHP 7.0, but not with PHP 7.1, which I tested with.

Proper tests will run in CI and should have caught the above. If not, the tests would not be good enough.

I'm not very familiar with GitHub's CI – can you point out which of the jobs run on Windows?

Oh, right, the "visible" characters are still applied in --no-colors mode. Thanks for pointing that out.
The encoding issue is interesting – it happens with PHP 7.0, but not with PHP 7.1, which I tested with.

Might just be that PHP added support for the Windows ANSI codes in PHP 7.1 and only added the function related to it in PHP 7.2.

Proper tests will run in CI and should have caught the above. If not, the tests would not be good enough.

I'm not very familiar with GitHub's CI – can you point out which of the jobs run on Windows?

At this time, there are no runs on Windows as there are no tests covering code which has special conditions for Windows. As soon as such tests would be added, the Windows OS would have to be added to the test matrix/workflow. (No worries about that, I can do that).

Might just be that PHP added support for the Windows ANSI codes in PHP 7.1 and only added the function related to it in PHP 7.2.

The ANSI codes and the Unicode characters actually appear unrelated. I found a PHP doc page that documents the latter as a change in PHP 7.1. https://www.php.net/manual/en/migration71.windows-support.php

At this time, there are no runs on Windows as there are no tests covering code which has special conditions for Windows. As soon as such tests would be added, the Windows OS would have to be added to the test matrix/workflow. (No worries about that, I can do that).

I guess I can try adding some. Probably in yet another pull request.

I extended the changes here slightly, adding two additional commits (see commit messages for details):

Update tests, which were added in #663
Improve the use of control characters in general
Use the Unicode characters on PHP 7.1+ on Windows, per our discussion above

Sorry about the noise, I didn't realize at first that PHPUnit 4.8 (used on PHP 5.4) does not support the @requires PHP < 7.1 syntax. And thanks for enabling automatic test runs for me :)

@jrfnl I greatly appreciate your reviews so far. I'd love to hear your thoughts on these patches again whenever you have the time. Please do not feel hurried though, I just want to make it clear that I'm still interested in completing these changes!

@jrfnl I greatly appreciate your reviews so far. I'd love to hear your thoughts on these patches again whenever you have the time. Please do not feel hurried though, I just want to make it clear that I'm still interested in completing these changes!

@MatmRex Sorry for the delay, looking at it again now.


More configuration options

Ideally, the options provided on the add page should also be present in the extension configuration (e.g. crawl depth and extractor methods).
In the future, it would also be nice to have this be able to be set per-domain.

I want to accept config options via tags as well by parsing KEY=value tags, e.g. adding a tag DEPTH=1 or EXTRACT=wget,media,screenshot,favicon,singlefile or TIMEOUT=160 should work as expected.


Body offset is unaffected by scale in Pehkui

The model does resize properly, but the X offset doesn't change to reflect the model's different size. As a result, the offset becomes too small at large scales and too large at small scales.
Normally, with default configs, the player's body is mostly out of the way when looking down, but the majority of the front of the body is still visible:

At large scales, the offset is relatively smaller, and so the player's body fills much more of the screen when looking down:

At small scales, the offset is relatively larger, so the player's body is almost entirely out of frame:

I think if it would be ideal if the model's offset were multiplied by the pehkui:model_width scale type, and for this calculation to be applied after the X Offset from the FirstPersonModel config.

The mod used to contain the function to scale the player, and there it was a part of it. So shouldn't be too bad to fix I hope? As a temporary fix you can fix the offset in the FirstPerson settings.

This issue is still present as of 1.19 on the latest release

Not sure if it is worth noting but I was able to use both mods together just fine up until a few days ago? I didnt have any issues but now the player body is really far forward when I crouch which I assume is a result of the vanilla crouching model taking priority?

This has always been broken. Sneaking with Pekhui installed will cancel out the offset.

odd, like i said it used to work for me, not sure why. until i downloaded more mods lol

I mean, this issue has been open for over a year now 😅

Any ideas how or when this might be fixed? can you fix it or is this up to pehkui

Oh wait do i need to edit the offset with pehkui instead?

Wait im talking specifically about crouching. It works fine normally

I mean, Pehkui seems to break and overwrite my offset logic when the player sneaks, probably to correct for something when the player is scaled up/down. So one solution might be for Pehkui to see that this mod is installed and include my offset in that case(probably also scaled, so the body doesn't get flung way too far behind the camera when small).


REI support (1.19.2)

Make sure you are not opening a duplicate.

[X] I have searched the issue tracker and did not find an issue describing my bug.

Description of your suggestion.
Was about to edit some recipes from other mods which do add arrows, but then saw that the recipe isn't shown in REI nor is the recipe type being registered by KubeJS despite using the minecraft namespace (minecraft:fletching) - which confused me a bit, but somebody helped me out with it and discovered that AdditionZ itself registered that new recipe type. not a big thingy - just confusing for people which do look the recipe files
KubeJS isn't either a big thingy - could be useful tho - but the REI support would be quite essential and therefore would ask if AdditionsZ could add REI support so that recipes actually show up in there?

Added the recipe type on emi.


Add setCurrent() method to Page Collection

Lets us have a workaround for #531
Also was a discussion on Discourse
This new method would allow to have expected (not inversed) prev and next items of the collection in Twig
Eg.:
    {% set collection = page.parent.collection({items<EMAIL_ADDRESS>filter: {published: true, routable: true}}) %}
    {% set isFirst = collection.isFirst(page.path) %}
    {% set isLast = collection.isLast(page.path) %}

        {% if not isFirst %}
            {% do collection.setCurrent(page.path) or collection.prev %}
            Previous page
        {% endif %}

        {% if not isLast %}
            {% do collection.setCurrent(page.path) or collection.next %}
            Next page
        {% endif %}

Ping @mahagr 🙂
Not sure if re-request of review is enough or should I ping next time right after re-request 😄


How could i pass moveCall with vector

my module function is this:
    entry fun remove_liquidity_(
        pool: &mut Pool,
        bankers:vector<Banker>,
        ctx: &mut TxContext
    ) {
        let length = vector::length(&bankers);
        let i = 0;
        while (i < length) {
            let banker = vector::borrow_mut(&mut bankers,length);
            let sui = remove_liquidity(pool, banker,ctx);
            let sender = tx_context::sender(ctx);
            transfer::public_transfer(sui, sender);
            let banker_to_delete = vector::remove(&mut bankers,length);
            delete_banker(banker_to_delete);
            i = i + 1
        };
        vector::destroy_empty(bankers);
    }

and my ts code like this:
      let resData;
      const tx = new TransactionBlock();
      tx.moveCall({
        target: `${global.contractAddress}::${contractModule}::${contractMethod}`,
        arguments: [
          tx.pure(global.pool_1),
          tx.makeMoveVec({ objects: bankers.map((id) => tx.object(id)), type: `${global.contractAddress}::${contractModule}::Banker` }),
        ]
      })
      resData = await wallet.signAndExecuteTransactionBlock({
        transactionBlock: tx,
      });

bug shows this:
Dry run failed, could not automatically determine a budget: MovePrimitiveRuntimeError(MoveLocationOpt(Some(MoveLocation { module: ModuleId { address: b0c5e352c761d38b87edebc86b02e05005049b2bd26cb2b434fa308ae6e3f777, name: Identifier("dice_game") }, function: 6, instruction: 12, function_name: Some("remove_liquidity_") }))) in command 1 (code: -1)
please help!!

@tnowacki Could you please help me,thx

As far as I can tell, your makeMoveVec call is working fine! This seems to be more of an issue with dry run not determining a budget since your transaction failed.
It looks like these Banker objects don't have enough liquidity? I'm not sure about the specifics of these functions though, so it's just a guess based on where the abort occurred :)

@qxyanda hopefully you got it sorted by now. If not, feel free to create a new issue. Closing it for now.


feat : derive DecidableEq for mutual inductives

[X] Put an X in this bracket to confirm you have read the
External Contribution Guidelines.

This partly implements #2329 by making the derive handler manage mutual inductive types. The general framework for derive handlers is currently not well-suited to manage nested inductives without resorting to making those derived instances partial, and managing them would require big changes to the framework, and thus, to other handlers as well. Such work/design decisions should thus be discussed in a subsequent RFC.

awaiting-review

I was slightly surprised to find that writing deriving DecidableEq on both inductives in a mutual block didn't error. That's great, but could you explain to me why? :-)

Would you mind adding a sentence about this to RELEASES.md in the v4.3.0 section (you will need to rebase on master for this section to appear)? We're trying to get better about recording the lovely new features arriving in Lean!

I was slightly surprised to find that writing deriving DecidableEq on both inductives in a mutual block didn't error. That's great, but could you explain to me why? :-)

I was surprised by this behaviour too ! As it turns out, other handlers share the same behaviour, so I figured I shouldn't change its behaviour here. Another thing that surprised me is that deriving on one inductive doesn't lead to the other one(s) also getting the instances generated. Furthermore, you can't use deriving _ on a whole mutual block, despite handlers being handled arrays of names instead of just a single one. Because of this, you need to derive on each and every inductive, which leads to code duplication of the definitions behind the instances (!). I believe such fixes/changes could (should ?) come through reworking the whole framework as well, instead of it being on a case-by-case basis.


After update of lspsaga, nothing don't work

Describe the bug
Hello! Today after update of lspsaga I started to have error on nvim launch and errors on lspsaga's actions.
Steps to reproduce
:PackerSync (for installing latest lspsaga version)
:q
Launch nvim (first error on 1 screen) and after this try to use lsp saga (second screen)
Expected behavior
Expect that all will work. Because I finished my nvim configuration few days ago and want to use it)
Neovim version (nvim -v)
0.8.2
Operating system/version
macOS 13.1
Terminal name/version
kitty
$TERM environment variable
xterm-256color

I think they changed the settings config. This is a pain

did you change the lspsaga config follow 0.2.3 version?

@glepnir I am working on it, but I can't find some specific settings. code_action_icon, custom_kind for example

@glepnir no. I wrote my config few days ago and all this time didn't open nvim. This is my config

please read doc new version is breakchange

@glepnir can you show me please what I did wrong or send me the section of documentation where is breakchange. I will be very grateful to you

@glepnir im newcomer in nvim world and its hard for me to understand this problem. please help