graalvm{8,11}-ce: init at 20.1.0

Motivation for this change
babashka requires graalvm20 and building graalvm20 from source seems rather difficult and the extremely long compile times and other issues that @hlolli is experiencing are rather draining.
For now I would propose that we add graalvm8-ce and graalvm11-ce
I will add a PR to babashka and clj-kondo that make them depend on graalvm11-ce until we have a better graalvm "built from source" story.
for more information see  #83080
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

cc: @volth @jlesquembre

Not a bad idea. Tough I have graalvm core working in my PR, holding back because I still don't have the graalpython/graal-js and other polyglots working yet. Can you confirm if the polyglot binaries work? If so this will be a good interim solution. One of my biggest problem in my PR is lack of response and comments from maintainers. I think I will continue on my PR next month using newer version, many of the problems I was hitting have been resolved in newer releases after I reported them upstream.
Alternatively we can say, screw the polyglots and let's get the core working properly, hence why I'm trying to make the libraries independent from the rest (perhaps an overly-abitious pursuit).

@hlolli
Yeah the polyglot binaries work. I've been able to run simple programs in truffleruby and graalpython.
the wasm binary doesn't crash, but I'm unable to confirm that it runs any wasm file.
I've never worked with wasm before and my minimal emscripten compiled example doesn't run.

@bennyandresen thanks for working on this, I like the idea. In fact, I was thinking on opening a similar PR myself, but I didn't find time to work on it. I'll try it tomorrow

same here I'll give this PR a try tomorrow. The fact that the polyglots langs are working is a seller to me.

I'm missing some assets from the release page:
https://github.com/graalvm/graalvm-ce-builds/releases/tag/vm-20.1.0
I can't find the python nor the ruby jars:
https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-20.1.0/python-installable-svm-java11-linux-amd64-20.1.0.jar

@GrahamcOfBorg build graalvm11-ce

@jlesquembre I already had them downloaded and therefor didn't realize that only wasm is included in the core graalvm release. graalpython and truffleruby are their own projects but are vm-compatible on their own release page.
Fixed in the commit I just updated.

@GrahamcOfBorg build graalvm11-ce

@bennyandresen thanks, looks better now, I was able to build it locally, still need to test the executables

@GrahamcOfBorg build graalvm8-ce

I was able to compile a clojure project, looks good to me

I found an error:
/nix/store/1kx44zs01d9ksibdxk3gi15akq5i8nfg-graalvm11-ce-20.1.0/lib/installer/bin/gu --help
/nix/store/1kx44zs01d9ksibdxk3gi15akq5i8nfg-graalvm11-ce-20.1.0/lib/installer/bin/gu: error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory

I found an error:
/nix/store/1kx44zs01d9ksibdxk3gi15akq5i8nfg-graalvm11-ce-20.1.0/lib/installer/bin/gu --help
/nix/store/1kx44zs01d9ksibdxk3gi15akq5i8nfg-graalvm11-ce-20.1.0/lib/installer/bin/gu: error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory

thanks! fixed in latest push.

Hello, I don't know if you can add support for Darwin. I did a quick search and found that GHC supports Darwin using dynamic libraries (https://github.com/NixOS/nixpkgs/blob/dbb7aaef62bb6e7cece233111914879c46d593fa/pkgs/development/compilers/ghc/8.6.5-binary.nix)
I can help testing on Darwin, but I cannot figure out how to make Graal work on this platform.

I tried to update graalvm-ee 20.0.0 -> 20.1.1 (there is no 20.1.0 for ee) and it does not work stable.
Sometimes it crashes with core dump.

Hello, I don't know if you can add support for Darwin. I did a quick search and found that GHC supports Darwin using dynamic libraries (https://github.com/NixOS/nixpkgs/blob/dbb7aaef62bb6e7cece233111914879c46d593fa/pkgs/development/compilers/ghc/8.6.5-binary.nix)
I can help testing on Darwin, but I cannot figure out how to make Graal work on this platform.

I tried for 30 minutes to integrate both platforms into a single file, but I wasn't successful.
Maybe you can fork the file I provided and change all the linux strings to darwin and see if that works for you? Then I can try again to see if I can incorporate it.

I was using graalvm11-ce to compile more clojure projects, and looks good to me, I didn't find any issues.
I'd like to get this merged and update clj-kondo and babashka to use this version until we fix the version built from the sources. Darwin users, in the meantime, can use overlays to build that packages from a different graalvm version. That's anyways necessary since the current graalvm version is broken on master. (https://hydra.nixos.org/job/nixpkgs/trunk/graalvm8.x86_64-darwin)

@bennyandresen can you please update your maintainer references so the build completes/this PR can get merged? I'm eager to use this and use the resulting binary cached derivation.

What's missing here to make this buildable? Do we need to rerun the tests? It looks like the error listed in the failing check has been resolved.

Something I noticed using this: If I try to compile a static native-image (with the "--static" flag), I get some weird errors with Clojure related to using the clj-http-lite library trying to make simple http requests. The executable will run fine from the computer I compiled it on, but if I run it from a different one, it fails. I can compile it dynamically but then it's guaranteed to not work pretty much anywhere else because of how the paths are in nix.
The same exact code works fine anywhere (or at least on Debian, Ubuntu, and NixOS) if I compile it on Ubuntu by installing the latest version of graalvm-ce using the instructions in the docs. I'm guessing this would have something to do with how the static zlib and glibc stuff is being handled in the nix derivation but I don't know anywhere near enough about graalvm or java to say for sure.
(ns gema.main
  (:gen-class)
  (:require [clj-http.lite.client :as client]))

(defn test-get []
  (println (client/get "http://example.org")))

Exception in thread "main" java.net.UnknownHostException: example.org
        at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:184)
        at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
        at java.net.Socket.connect(Socket.java:607)
        at java.net.Socket.connect(Socket.java:556)
        at sun.net.NetworkClient.doConnect(NetworkClient.java:180)
        at sun.net.www.http.HttpClient.openServer(HttpClient.java:463)
        at sun.net.www.http.HttpClient.openServer(HttpClient.java:558)
        at sun.net.www.http.HttpClient.<init>(HttpClient.java:242)
        at sun.net.www.http.HttpClient.New(HttpClient.java:339)
        at sun.net.www.http.HttpClient.New(HttpClient.java:357)
        at sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:1226)
        at sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1162)
        at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1056)
        at sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:990)
        at clj_http.lite.core$request.invokeStatic(core.clj:76)
        at clj_http.lite.core$request.invoke(core.clj:42)
        at clojure.lang.Var.invoke(Var.java:384)
        at clj_http.lite.client$wrap_query_params$fn__996.invoke(client.clj:167)
        at clj_http.lite.client$wrap_user_info$fn__1006.invoke(client.clj:191)
        at clj_http.lite.client$wrap_url$fn__1023.invoke(client.clj:213)
        at clj_http.lite.client$wrap_redirects$fn__940.invoke(client.clj:47)
        at clj_http.lite.client$wrap_decompression$fn__947.invoke(client.clj:63)
        at clj_http.lite.client$wrap_input_coercion$fn__962.invoke(client.clj:115)
        at clj_http.lite.client$wrap_output_coercion$fn__953.invoke(client.clj:72)
        at clj_http.lite.client$wrap_exceptions$fn__933.invoke(client.clj:33)
        at clj_http.lite.client$wrap_basic_auth$fn__1001.invoke(client.clj:181)
        at clj_http.lite.client$wrap_accept$fn__974.invoke(client.clj:135)
        at clj_http.lite.client$wrap_accept_encoding$fn__980.invoke(client.clj:146)
        at clj_http.lite.client$wrap_content_type$fn__969.invoke(client.clj:127)
        at clj_http.lite.client$wrap_form_params$fn__1018.invoke(client.clj:208)
        at clj_http.lite.client$wrap_method$fn__1013.invoke(client.clj:196)
        at clj_http.lite.links$wrap_links$fn__901.invoke(links.clj:65)
        at clj_http.lite.client$wrap_unknown_host$fn__1028.invoke(client.clj:219)
        at clj_http.lite.client$get.invokeStatic(client.clj:273)
        at clj_http.lite.client$get.doInvoke(client.clj:270)
        at clojure.lang.RestFn.invoke(RestFn.java:410)
        at gema.main$test_get.invokeStatic(main.clj:43)
        at gema.main$_main.invokeStatic(main.clj:67)
        at gema.main$_main.doInvoke(main.clj:67)
        at clojure.lang.RestFn.invoke(RestFn.java:397)
        at clojure.lang.AFn.applyToHelper(AFn.java:152)
        at clojure.lang.RestFn.applyTo(RestFn.java:132)
        at gema.main.main(Unknown Source)

if @bennyandresen is busy and it feels kosher to people I'd love to take this and rebase it to fix the eval error

if @bennyandresen is busy and it feels kosher to people I'd love to take this and rebase it to fix the eval error

Please go ahead. If there is a way for me to transfer this PR over to you, I'll do that.

I'll just open a new one. thanks :smile:

Done, along with a version bump. This can safely be closed now.

Closing in favor of #99631


New Maintainer proposal and suggested plan for moving forward

TL;DR: Unless someone stops me I'm going to take this thing over, modernize it, get it sane, strip out the cruft, make almost everything optional, all for the greater good. Not everyone will like all of the changes, but most everyone will agree they make sense. Once updated we can reimplement a healthy PR culture. I will communicate this proposal in as many places as possibly but will assume silence is acceptance.

Nobody is maintaining this tool. It has a ton of forks and not a lot of people contributing back.
People still use and rely on this tool, especially people from the Pivotal heritage, such as VMware employees, Pivotal alumni, current clients, former clients, partners, friends, family, loved ones.
I hereby nominate myself to maintain this tool for now in an effort to modernize it, bring sanity, and draw a line-in-the-sand for moving forward.
My qualifications:

I have worked on and used this tool and all of it's predecessors for the past 15 years
I'm a known quantity by this tool's primary audience: people from the Pivotal heritage
I'm fair and the above mentioned community tends to trust my judgement
I'm not afraid to make hard decisions and make some people unhappy on behalf of the greater good
I have the time, tools, and enthusiasm

Here is my current plan:

Declare PR bankruptcy
Put a pause on design-by-committee and implement DESIGN BY JOE MOORE THE DECIDER OF ALL THINGS DAMNIT
(But just for now I promise. We have to make some progress as fast as possible and eliminate lots of cruft and get to a sane baseline in order to move forward. Plus I'll constantly communicate.)
That means personal opinionated changed in current PRs will mostly be ignored. If you want a different default terminal font or editor line length you'll have to do that yourself because the greater good.
What's the difference between a sane default and a personal opinion? I DECIDE. Again, just for now. We can duke it out in PRs later.

I'll take inspiration from current PRs and create a series of new PRs with a goal of:

Making certain must-have changes, such as zsh by default.
Remove anything that is flat-out broken or dead
Decompose the current installer scripts into their contingent parts. For example, the fact that git.sh installs vim is bonkers. Again, current PRs have some good ideas.
Make as much as possible optional and opt-in. This likely means commenting most things out and providing instructions to uncomment what you want. No fancy choose-your-own-adventure set of command line args. We're developers. We basically live by commenting things in and out and running it again anyway.

Am I going to merge in my own PRs? Yes, I probably will. Again, I'll constantly communicate. Again, once we're at a new sane baseline we can have a healthy PR culture.
I have an OS X VM running in Fusion on my mac plus an extra loaner mac to test stuff. I can also look at some CI solutions, especially if GitHub Actions supports an OS X runner.
Let me know what you think.

I second. I'm sure you'll do a wonderful job. I'm grateful that you're willing to take it on.

What a treat of a read 😆

"DESIGN BY JOE MOORE THE DECIDER OF ALL THINGS DAMNIT"
"I DECIDE"

Re: CI Solutions - Circle has a Mac executor, but I believe the last time I looked into it, it cost $ and I didn't know if I'd get buy in to expense a using a non-Tanzu product for a Tanzu thing.
Also ... sadly the Circle Mac executor comes with brew already installed. Not the worst thing, but also not a perfectly pristine test environment 🧽
Lastly comes the question - is maintaining this repo a futile task? Github recently released a blog post (which I'm sadly not finding quickly) about their workstation setup. It's more containerized. But that could also be specifically to their application, of which this repository does not deal with any 1 application ... anyway /rant. Thanks for taking this over, Joe!

Yeah go ahead with it. And thanks for picking this up, I feel it is worthwhile the effort. Feel free to cherry pick or merge my stuff, or not - I'm completely fine with you taking the decisions on upstream.

Lastly comes the question - is maintaining this repo a futile task? Github recently released a blog post (which I'm sadly not finding quickly) about their workstation setup. It's more containerized. But that could also be specifically to their application, of which this repository does not deal with any 1 application ... anyway, I personally love and support WS setup, but just wanted to throw that out there /long winded comment.

This is a very interesting and valid question. I think that eventually we'll all be working primarily in containers. I'd still like to get this tool in better shape and then solicit volunteers to do a kind of bake-off.


AST now provides access to document catalog footnotes

Kind of change

[ ] Bug fix
[x] New non-breaking feature
[ ] New breaking feature
[ ] Documentation update
[ ] Build improvement

Description
Adds AST access to document footnotes so that a converter may render them.
Footnotes are accessible under Document via getCatalog().getFootnotes().
I will update this description with any appropriate changes resulting from review/discussion
Issue
Footnote portion of #958
This PR will likely also include exposing catalog.refs but has been submitted with only catalog.footnotes exposed to get feedback from AsciidoctorJ folks on code/approach
Release notes
I've updated CHANGELOG with a TBD, will finalize after as PR is reviewed.

Added couple of comments, but @robertpanzer has the final saying.

Added couple of comments, but @robertpanzer has the final saying.

Thanks so much for your thoughtful review @abelsromero!

Thanks for comments @robertpanzer, if the general approach agrees with you and @abelsromero, I will continue with adding refs on your go-ahead (and addressing any review feedback of course).

Yes, please go ahead.
This is great! :+1:

Ok, @abelsromero & @robertpanzer, I've added access for doc catalog refs.
I think my changes to RubyHashMapDecorator make good sense, but I'm sure you'll let me know if you prefer an alternate approach.
Otherwise, looking forward to any feedback you may have.

This looks great! Sorry for not responding the last days.
I'll try to test it tomorrow, in particular the changes around the RubyHashMapDecorator.

Cool, thanks for the update/status!

Overall this looks great.
I just have 2 minor remarks.

Afterthought, do any supporting docs need updating?

It should probably be also mentioned in the integrator guide.
If you like we can do this later and I can merge now.
Or do you want to add it to this PR?

I'd better do the docs with the code, else I might never do the docs!

Ok @robertpanzer, took a stab at a small mention of the catalog in the integrator's guide, lemme know if it is sufficient.

Thank you putting so much effort into this! This is great.
Thank you!


kernel_parameters set incorrectly on CentOS 8

I realise the module does not currently claim to support CentoOS 8.
With centos8
/etc/default/grub
is no longer the way to specify kernel parameters and indeed grub2-mkconfig is no
longer the correct command to call.
From https://access.redhat.com/solutions/3710121 (paywall) suggests that
# grub2-editenv - list
saved_entry=72ee326dc9ff4092ab35d066fbbf02c5-4.18.0-147.8.1.el8_1.x86_64
kernelopts=root=UUID=8dd1149a-2dab-4b33-b554-42890f94d1b1 ro console=ttyS0,115200 console=tty0 rd.auto net.ifnames=0 crashkernel=auto rhgb quiet

and
grub2-editenv - set "kernelopts=root=UUID=8dd1149a-2dab-4b33-b554-42890f94d1b1 ro console=ttyS0,115200 console=tty0 rd.auto net.ifnames=0 crashkernel=auto rhgb quiet consoleblank=0"

is the way to set consoleblank.
In reality this command maintains the files:
# ls -l /boot/efi/EFI/centos/grubenv /boot/grub2/grubenv
-rwx------. 1 root root 1029 May 22 17:01 /boot/efi/EFI/centos/grubenv
lrwxrwxrwx. 1 root root   25 Feb  5 02:46 /boot/grub2/grubenv -> ../efi/EFI/centos/grubenv

and these are loaded by the blscfg module.
https://fedoraproject.org/wiki/Changes/BootLoaderSpecByDefault
Not sure how to proceed. Can we still use augeas  to validate output of the commands
to add kernel_parameters.

I see there is grubenv work in the menu_config type for some inspiration.

@traylenator I'm currently doing a bit of testing and it looks like everything still works as expected as long as GRUB_ENABLE_BLSCFG=true in /etc/default/grub.

@trevor-vaughan what do you mean by still works? It does edit files but when I tested a long time ago these are not used on reboot.

@traylenator The bug fix you added to run mkconfig on all files in menuentry needs to be ported to the other providers. Working on that now as part of #63

Which fix is that? I'm not sure there's a PR associated to that issue at the moment.

@raphink I'm assuming this one https://github.com/hercules-team/augeasproviders_grub/pull/64

So this is all fixed now assuming you are running 8.3.
Running with 8.1 or 8.2 results in a non bootable system.


language isn't stored

Describe the bug
If I switch the language to Deutsch, it isn't stored and I have the make this choice at each visit of Artemis.
To Reproduce

Browse to your Artemis server.
Change the language to Deutsch
Sign in
Logout
Reload the page :arrow_right:  Page is in English again, also after I login again

Expected behavior
Artemis remembers the language I had selected. At least after I Sign in.
Screenshots
No response
What browsers are you seeing the problem on?
Other (specify in "Additional context")
Additional context

browsers:

Firefox 101.0
Opera 87.0.4390.45

OS: Linux Mint 20.3 64-bit
Artemis 5.8.3

Relevant log output
No response

I think it should update the language key of the user, if the user is signed in. If there is also a language key in the local storage, that maybe triggers the question which of the language keys (local or user) should take action.
Another possible solution in my opinion would be to simplify the language task. Always take the browser language. If Artemis doesn't support the browser language it could fall back to english or an default language of the Artemis server.

I would suggest the following approach:

Currently the language set in the session takes precedence over the one stored in the database. I think we should keep it that way. But: We need to allow a user to set his/her language permanently.
Solution: When the user changes the language via the dropdown, ask if this change is only for this current session or if the user details should be updated. Depending on the answer we update only the session storage or also update the language key in the database via a new API endpoint.

I think it should update the language key of the user, if the user is signed in. If there is also a language key in the local storage, that maybe triggers the question which of the language keys (local or user) should take action.
Another possible solution in my opinion would be to simplify the language task. Always take the browser language. If Artemis doesn't support the browser language it could fall back to english or an default language of the Artemis server.

Good Idea. Maybe something like:

Source of truth in frontend is language_key in session
User Not Logged in:
Opening Artemis:
If langKey in session -> take it
If not determine best matching langKey via browser settings and set in session.
Changing Language:
Change langKey in session to the picked value

Logging into Artemis:

Replace langKey in session with the one from the database
Changing Language:

Change langKey in session to the picked value and update the database

User logged in ->

A good and detailed described solution in my opinion.
I have only one little addition (I don't know if that is technically easy to do or not.):
user logging into Artemis for the first time:

The langKey in the database hasn't been set yet.
Take the langKey from the session and set it into the database.
Changing Language:  same as in "Logging into Artemis"

@BaumiCoder
Good Idea! I implemented the feature as a draft in https://github.com/ls1intum/Artemis/pull/5233.


⚠ GitLab Server has degraded performance

In 0c074c7, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 7081 ms

Resolved: GitLab Server performance has improved in d5a9109.


Error with connection

Here is my code:
import hive_utils
query = """
SELECT sm.metric_name as 'DRC', sm.metric_value as value from sm
WHERE sm.year = 2016
AND sm.month = 5
AND sm.tail = 10646
AND sm.metric_name = 'DRC_kbps'
limit 100
"""
hive_client = hive_utils.HiveClient(
 server=config['_I redacted the real server_'],
 port=config['8888'],
 db=config['analysis']
)
for row in hive_client.execute(query):
 print '%s: %s' % (row['DRC'], row['value'])
I get the following error:

rcates@RCates-MBP:~/Documents/Scripting> python connect.py
Traceback (most recent call last):
File "connect.py", line 14, in
server=config['I redacted the real server'],
NameError: name 'config' is not defined

Please Help

The sample code in the README assumes you defined your configuration in a dictionary. For example,
config = {
  'HOST': 'example.com',
  'PORT': 8888,
  'NAME': 'analysis',
}

hive_client = hive_utils.HiveClient(
    server=config['HOST'],
    port=config['PORT'],
    db=config['NAME'],
)

would work.
If you want to pass the config values in directly, just do
hive_client = hive_utils.HiveClient(
server='_I redacted the real server_',
port=8888,
db='analysis',
)

It would be helpful if you would specify that in the README, it is not intuitive. Just a thought.


How to Limit swapn in docker conainer

Hi Team,
in selonoid docker container how to to set swap limit.
we tried using --memory-swap* option but not worked.
Kindly provide how to set swap limit .

@sharathmankala this option is currently not supported. What is the use case for this?

@vania-pooh  we are getting OOM after increasing Physical-memory, shm size and assigning memory to individual browsers  value.
So we want to use swap memory.

@sharathmankala wouldn't it be very slow? Our approach is to set -limit that will not cause OOMs at all.

Closing this because of inactivity. Feel free to reopen if still having questions.


but，this is more ,difficult to use than GSON

here is the rationale:
http://www.birbit.com/jsonapi-is-a-blessing-for-offline-ready-apps/
Why do you think it is difficult? More code ?

yes ,more code than before,and more difficult to understand.
anyway,Thanks a lot ,It's time for me to learn a new skill.


Create THEOS-Tweak.gitignore

Reasons for making this change:
No such template exists yet.
Links to documentation supporting these rule changes:
Ryan Petrich uses this gitignore in all of his tweak projects, he's about as close to official documentation on this as we will get. His gitnigores were the most thorough out of the many open source projects I browsed.

I'm going to close this out because the value of maintaining a template like this in the repository isn't clear to me.
@NSExceptional if you still feel this should be a template listed in this repository, please read the section about specialized templates and open a new pull request that follows the new pattern.


Sell extension on VS Marketplace

I'm not sure this is the best place for the question, but I'm wondering who I could talk to about selling an extension on the VS Marketplace for VS Code. Is this possible? Contacts / pointers would be helpful, thanks!

Unfortunately this is not supported as all Code extensions are meant to be free. You can always implement that functionality within the extension itself although you'd be handling all the payments and distribution yourself.
cc @chrisdias


Fix typo's

Signed-off-by: Auke Oosterhoff<EMAIL_ADDRESS>

Looks good to me.   Thanks.
I'll also cherry-pick to older releases.


defaultProject is ignored when using GCE Default Service Account authentication

The defaultProject data source configuration key is ignored when using GCE Default Service Account authentication. This seems like a regression/breaking change from the previous version of this plugin. I'm unable to use a datasource configured with this plugin.  I receive the following error upon testing the data source:
403: Access Denied: Project xxx: User does not have bigquery.jobs.create permission in project xxx., accessDenied

I believe this issue arises for anyone where BigQuery jobs created by Grafana need to run in a GCP project different from where Grafana is deployed.  I think this is a fairly common situation for billing and BigQuery quota management.
In the doitintl version, administrators could provide the following data source configuration and Grafana would create the bigquery jobs in a project it actually has bigquery access.
{"authenticationType":"gce","defaultProject":"yyy","flatRateProject":"yyy","queryPriority":"INTERACTIVE"}

For clarity, I have three forks of the BigQuery plugin deployed to a single pod in a Kubernetes cluster with a workload identity bound to a GCE service account:

v1.0.0 from Grafana
v2.0.3 from doitintl
v3.2.2 (an internal fork)

The same deployment and data source configuration works great in the latter two but receives a 403 using the Grafana version.

@chrisleavoy thanks for opening this, looking into the issue!

@chrisleavoy I have looked into the issue and tried to reproduce it. I have created two GCP projects.
Project A contains:

a VM running Grafana, using Compute Engine default service account
a BigQuery instance (just for testing purposes)

Project B contains:

a BigQuery instance. I've added  Compute Engine default service account with BigQuery Job User and BigQuery Data Viewer roles via IAM settings

I can query both Project A and Project B BigQuery projects.
We currently don't provide code completion for multiple projects - we will try to introduce this soon. Moreover, the visual query builder doesn't allow project selection when in GCE scenario - I think we will be able to add that soon.
I don't know how the above helps your case, but if you could either confirm your setup is similart to the above, or provide some more details on your setup then I hope we will be able to help you more and hopefully solve the problem very soon.

Hi @dprokop, thanks for looking into this issue.
In your attempt to reproduce, Project B would be the default project, not A. Moreover, to see the 403 error, the local Project A permissions for BigQuery would need to be removed.
Our setup is slightly different:  Project A only has Grafana running – there is no local BigQuery dataset or permissions to create BigQuery jobs there. Project B has a BigQuery dataset and all the necessary permissions for Project A's service account.
The way I understand it, BigQuery creates lambda jobs when running queries against a dataset. Google uses these jobs for usage billing. We centralize where users must instantiate jobs for BigQuery to keep cost controls and quotas configuration sane in our environment.
I just tested the 1.0.1 patch, and the behaviour changed slightly.  It still doesn't respect the defaultProject.  When configuring the data source, the Save & test action still shows Grafana uses the local project to create BigQuery jobs.  The Google API rightfully returns a 403 error.  As it worked in the last fork and other Google plugins like StackDriver, we expect the defaultProject to override where Grafana creates BigQuery jobs.

@chrisleavoy thanks for the detailed description. I think I have managed to reproduce that exact environment.
Project A: Grafana instance. Default service account with the default Editor role.
Project B: Jobs runner. Added Project A's default service account with BigQuery Job User role.
Project C: BigQuery instance. Added Project's A default service account with BigQuery Data Viewer role.
As far as I can see the implementation problem is, as you described, not using the default project configured when creating the jobs. Indeed, no matter the default project config, it was never used when creating a BigQuery client. I'm bringing this in with this PR: https://github.com/grafana/google-bigquery-datasource/pull/103. I hope to release 1.0.2 later today, so you could verify it works in your setup.
Unfortunately, I can see one limitation that we need to solve soon for the described GCE setup to be user-friendly. There may be several BQ projects that one wants to query. We need to introduce Resource Managere API integration, similar to the Google Cloud Monitoring data source, so we can allow projects selection when creating the query. As of now, it's only the GCE default project(not the one introduced by #103) that gets code editor support and visual query builder datasets and tables selection. With #103 in place one will be able to create queries using Code editor only (visual query builder doesn't allow project selection), but the code completion will be broken.
@chrisleavoy Let me know if the 1.0.2 makes the thing work for you, and in the meantime I'll land on a more detailed description of what needs to be done in the query builder, to support code completion and visual query builder given described setup.

@dprokop, I just tried 1.0.2 and GCE auth is working now, thank you!
Regarding the Explorer view.  I like the changes, but yes, being able to select the project would be nice.  Otherwise, we would have to create a few dozen BigQuery data sources for all the different projects we have internally.
I'll do some more testing today. I saw a bunch of 500 internal errors after switching a few panels to the new plugin. I will open a new issue after I discover the trigger.

Glad to hear @chrisleavoy. I'm gonna close this issue then, in favor of https://github.com/grafana/google-bigquery-datasource/issues/104


wip: Add operator OLM bundle

Description
This PR adds support for generating the ClusterServiceVersion and other operator deployment metadata.
Related
PR to update the OpenShift installation instructions to enable OLM to manage the operator: https://github.com/projectcalico/calico/pull/3378

Closing in favor of https://github.com/tigera/operator/pull/682


Moved testing related code out of main web application

Resolves #75

 (5) Create pipeline for integration tests execution as part of PR validation


Fuzzy PID Controller Example?

Hi and thanks for your attention!
I've seen the examples, but couldn't figure out if it's possible to use this library with Brett's Beauregard's PID library (or any PID).
Would FuzzyOutputs be Kp, Ki, Kd?
3 outputs and 2 inputs (setpoint and measured variable)?
Thanks!

Yes, you can build a Fuzzy system with 2 inputs and 3 outputs, the advanced-example show how to build a system with 2 outputs.


Documentation link is broken (PACMAN-624)

The Component Manager version
repo main
ESP-IDF Version
n/a
python Version
n/a
Operating System
N/A
Browser (for https://components.espressif.com  Issues)
Firefox
Description
Link in README does not load https://docs.espressif.com/projects/idf-component-manager/en/latest/

The page isn’t redirecting properly
An error occurred during a connection to docs.espressif.com.

To Reproduce
go to link

Expected behaviour
link works
Additional info
No response
I have checked existing issues and online Documentation

[X] I confirm I have checked existing issues and online Documentation.

@ljden Thank you for reporting. The documentation site is fixed now.


Show separate total balances for funds and loans

[x] Calculate total fund balance
[x] Calculate total loan balance
[x] Show balances in headers of list pages
[x] Show balances in headers of sidebar

Closed by a4bbf01c80728eb10e5173897f03bb0bcad054ad


Has anyone encountered this error: "Warning: /opt/homebrew/bin is not in your PATH." ?

This occurs on MBAir M1 running macOS 11.4 20F5065a.
Is there a workaround?

This isn't MailTrackerBlocker-specific. You'll need to add /opt/homebrew/bin to your PATH to your ~/.zshrc (or whatever shell you're using). See this Stack Overflow thread for more.


One more typo in macro

This define has the same typo as was fixed in a previous issue. Maybe worth fixing here for consistency.
https://github.com/ICRAR/VELOCIraptor-STF/blob/cb4336de8421b7bada3e158c44755c41e9fab78b/src/hdfitems.h#L103
Also, not sure what that whole block is supposed to achieve in general.

Thanks @MatthieuSchaller, this looks like and old mechanism to define/undefine the macro before it was exposed as a cmake option, I'll simply remove those lines.

Fixed on the master now.


fix: made the links width 100%

Description
Earlier we have to move the cursor on the text to click any of the links. But now I made its width complete.
Related issue(s)

@akshatnema better show some screenshots before and after and ask docs and design folks. I don't have a strong opinion

@shubhamku044 can you please provide a demo video showing both websites and the changes?

yes sure, sending you a video in few minutes

https://github.com/asyncapi/website/assets/77788249/50124952-8bd5-4856-9135-4957c229aa99

@derberg You can now see the difference between the first and the second preview of the sidebar. Links will be more accessible instead of restricting it's width to text only. First view - PR Changes Preview, Second view - AsyncAPI website

/rtm


refactor: removed atclient_ prefix from atlogger functions

Closes #102
- What I did

removed atclient_ prefix from atlogger functions

- How I did it

See changes

- How to verify it
- Description for the changelog

Waiting for #208

Going to merge with #210


No snapshot is published

Latest snapshot was in 2016.
http://oss.jfrog.org/oss-snapshot-local/io/requery/requery/

Snapshot version has been updated to 1.6.0 on http://oss.jfrog.org/artifactory/oss-snapshot-local thanks!


Add --rune flag to resume command to enable resuming a specific etching

Adds a new --rune <RUNE> flag to allow resuming a specific pending etching. This is useful in automated scenarios (if anyone else is into that kind of stuff) where you'd like to etch something, suspend (perhaps via --no-wait from #3526), do something else, and then resume after the 6 confirmations.

This is good feature.
We should probably resume it by rune name. Another feature that would improve this would be a command to list all pending etchings, so it is easier to know what can be resumed. Probably best to do another PR for that.

Thanks for the feedback, @raphjaph - I'll get these changes in and create a separate PR for listing pending etchings.

Thanks for the feedback, @raphjaph! Requested changes have been applied. Will add the command to show pending etchings on a separate PR.

Almost there! Still needs an integration test. Have a look at tests/wallet/resume.rs. For reasons this can only be tested on Mac and Linux. What system are you on?

@raphjaph took me a while to get around to adding these tests, but here they are! Hope it's looking good. I'm on a Mac, btw.


When an activity is stopped on the mobile ap, it continues to go on the desktop

This has happened consistently for me for the last few days.
Whenever I come to my computer, I will see that the Toggl timer on an activity is still going if I had previously stopped it on my phone. If I had logged multiple activities on my phone, then the most recent one will be the one still active on the desktop.
If I stop the activity on my desktop, then all is well.

Mee too...
A workaround that seems to work: logout+login from mobile app

This seems to be a mobile app specific syncing issue. Not sure we can do anything about it on the desktop app side.

old mobile-related issue, not relevant anymore


Add auto-generate sample for Advisor and AgFoodPlatform

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


[doc] Use PNG logo for compatibility with all browsers

Also:

Fix some documentation warnings

Fixes #1927

Codecov Report

Merging #1976 (0616a24) into master (2d5a5ed) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1976      +/-   ##
==========================================
- Coverage   87.51%   87.50%   -0.02%
==========================================
  Files          50       50
  Lines        8713     8714       +1
==========================================
  Hits         7625     7625
- Misses       1088     1089       +1

Impacted Files
Coverage Δ

reframe/core/schedulers/pbs.py
47.26% <0.00%> (-0.33%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d5a5ed...0616a24. Read the comment docs.


Rome and Vatican City

The map currently shows Vatican City but not Rome up to something like zoom z10:

https://zelonewolf.github.io/openstreetmap-americana/#map=7.2/41.988/12.491&language=
Personally I would expect to see Rome first and then Vatican City.
QRank https://github.com/brawer/wikidata-qrank also says that Rome is more important than Vatican City:
QRank Q220 (Rome) is 7670781
QRank Q237 (Vatican City) is 6822664

This is essentially a duplicate of #533, except that the city label layer doesn’t have a text-radial-offset. The only general solution that GL JS currently supports would be to consolidate all the place labels into a single layer. But in this case, we could special-case any feature with iso_a2 equal to VA to be hidden until a higher zoom level.

Interesting, yes solving in the client only probably does not work unless you take all labels into a single layer. That is not so good because not all label properties are data-driven...
But would it maybe work if planetiler would compute collisions when generating the tiles and remove labels if they have a lower rank even if they are in separate layer? https://github.com/onthegomap/planetiler/discussions/492

But would it maybe work if planetiler would compute collisions when generating the tiles and remove labels if they have a lower rank even if they are in separate layer? https://github.com/onthegomap/planetiler/discussions/492

It could be made to work, but that seems like a bit of a sledgehammer for this particular problem. I think a more versatile approach, requiring fewer assumptions about the client, would be for OpenMapTiles to tag each country with its tile_area. OpenMapTiles already does this for bodies of water as of openmaptiles/openmaptiles#1457, but if computing the area of a country based on its boundary relation would be too difficult, perhaps it could copy the area from Wikidata.


html: Initialize doReconnect to false when specified by client options

This change fixes a bug (regression?) that causes the disableReconnect client option to not apply properly on the first disconnection.
Symptom
When the disableReconnect flag is passed to the server binary, the web client still automatically reconnects, but only on the first disconnection. Subsequent disconnects do not automatically reconnect.
The expected behavior is that the web client should never automatically reconnect as long as disableReconnect is provided.
Reproduction example

./ttyd --port 8000 --client-option disableReconnect=true bash
Visit localhost:8000 in the browser
Run exit
Notice that the client reconnects automatically (and the server thus starts a new bash process)
Run exit
Notice that the client prompts the user to press enter to reconnect

Patch verification
Enabled case:

./ttyd --port 8000 --client-option disableReconnect=true bash
Visit localhost:8000 in the browser
Run exit
Notice that the client does not reconnect automatically

Disabled case:

./ttyd --port 8000 bash
Visit localhost:8000 in the browser
Run exit
Notice that the client reconnects automatically

Disabled case with socket error:

./ttyd --port 8000 bash
Visit localhost:8000 in the browser
Terminate the ttyd process to induce a client-side socket error
Notice that the client does not reconnect automatically

RCA

The web client determines whether to reconnect based on a check of doReconnect
doReconnect is initially only assigned the value of the this.reconnect (default false) when the socket is opened
The client options are applied after the socket has been opened, but this does not change doReconnect
Thus, the disableReconnect preference never gets applied until the second socket open attempt.

Cherry-picked to main.


<EMAIL_ADDRESS>decompress error

Updating 'lunacy' (9.6.1 -> 10.0.1)
Downloading new version
Starting download with aria2 ...
Download: Download Results:
Download: gid   |stat|avg speed  |path/URI
Download: ======+====+===========+=======================================================
Download: c85005|OK  |   4.6MiB/s|C:/Users/Rescenic/scoop/cache/lunacy#10.0.1#667a216.exe
Download: Status Legend:
Download: (OK):download completed.
Checking hash of LunacySetup_10.0.1.exe ... ok.
Uninstalling 'lunacy' (9.6.1)
Removing shim 'Lunacy.shim'.
Removing shim 'Lunacy.exe'.
Unlinking ~\scoop\apps\lunacy\current
Installing 'lunacy' (10.0.1) [64bit] from 'extras' bucket
Loading LunacySetup_10.0.1.exe from cache.
Extracting LunacySetup_10.0.1.exe ... ERROR Exit code was 1!
Failed to extract files from C:\Users\Rescenic\scoop\apps\lunacy\10.0.1\LunacySetup_10.0.1.exe.
Log file:
~\scoop\apps\lunacy\10.0.1\innounp.log

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Relates to #13444.
With scoop v0.5.0+:
scoop bucket add versions
scoop install versions/innounp-unicode

as a workaround.


Create Goals Document and update it for future deliverables

A document needs to be created stating our tentative goals for future IDs, changed as we see fit. It can start with a simple idea of what we want in future, and more concrete as it gets closer, but it should at least maybe have a general idea of what we want to have done for a certain ID. It's good for both the stakeholder and us, as it gives an idea of what we're looking for as we progress through the project.

This has in been covered by a combination of the Transtion/Deployment Plan and the Requirements Document


[release-2023b] sync 2023b branch with upstream 2023b branch for CVE fix.

Related-to:
https://issues.redhat.com/browse/RHOAIENG-4027
https://github.com/opendatahub-io/notebooks/pull/472
Manually opened the PR as the validation failed: https://github.com/red-hat-data-services/notebooks/actions/runs/8564702274

Merging to get this fixed.


Group / Collate / Aggregate notification emails

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
New Notification
🔖 Feature description
For someone using Uptime Kuma to monitor plenty of items (~50) Uptime Kuma can spam notification emails when there is internet connectivity/networking problems.
I usually get 50 when it's down, and 50 again when it comes back up.
✔ Solution
Allow Uptime Kuma to list ALL services that down, or ALL services that are up and then send them in a single email as a list after a configurable timeout.
❓ Alternatives
Some other kind of notification, filtering emails.
Different email inbox.
I would rather not do any of these because I will not notice them as quickly as an email to my personal mail. I also don't like these options as they (for email) create a lot of storage need for no reason.
📝 Additional Context
No response

+1 Would be nice to have some hierarchy so if the main host goes down / internet then only the main notification is sent instead of all the services that are being monitored.

+1

I can see this being made possible by allowing users to group monitors together. If one monitor of a group starts alerting, the other monitors will block the notification for the whole group until they update their status. This will let users group together related failures and it can help reduce the spam notifications received from an outage of related monitors.

https://github.com/louislam/uptime-kuma/issues/2500

@tomlawesome
I have removed the alert filtering from your issue as I think tracking this in a distinct issue like #1233 is a better call

To pull my thoughts from 4829 here, I'd love to see nested items within a group being able to have individual notifications off, while notifications for the group is on, and if something goes down, the group notification would specify what went down rather than just saying "child inaccessible." This would be for situations such as:
-Location (group)
--Server1 (child)
--Server2 (child)
--Firewall (child)
If one server goes down, one notification at the Location level, saying which server is down. If the firewall goes down (taking the servers with it), one notification at the Location level, listing all 3 children as down. As it sits, these would generate 2 and 4 emails for the scenarios if all alerts are enabled.

Small note in case someone implements this, some services (like Telegram) have character limits, so grouped notifications may have to be split into parts at that limit to avoid being truncated or anything like that.


50% Parallax scrolling

Start scrolling with Parallax once the element is 50% in view and finishes once 50% of the element is out of view.
TP: https://rockabox.tpondemand.com/entity/12324

Ready for merging for QA


Write documentation for Asanawarrior

https://github.com/manishrjain/asanawarrior/pull/32 adds some minimal documentation.


speedup docker hub pull/push process from China

this could be one solution http://blog.daocloud.io/daocloud-mirror-free/. a docker hub mirror in China. need more information about the SLA.

There are no recent complain about this issue, I'm closing this item. But assign it to @xiaowuhu so that they can aware this potential issue. Please open new issues with detailed info and needs.


Force kill any existing dnf process

We are seeing lot of failure on the CI because of existing
dnf process.
+ sudo yum install -y podman make golang rsync
[...]
Waiting for process with pid 1281 to finish.

/cherry-pick 4.7

The background dnf process is dnf-automatic. It might be trying to update the image to 8.4 in the background, which is taking more time than usual dnf-automatic runs, and ends up getting of the way of our CI scripts.


How to run bugger with Mocha?

Bugger has been a great experience with Jest, but any ideas on how to run mocha tests with it?

The general idea when debugging mocha is that you have to start _mocha instead. For example: bugger --brk $(which _mocha).


'dotnet' is not recognized as an internal or external command, operable program or batch file.

Problem encountered on https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/install
Operating System: windows
Provide details about the problem you are experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

have you re-opened your command prompt windows? The installer updates PATH variables, which will not flow to existing command prompts.

Closing this out due to lack of response. Hope you resolved it, otherwise feel free to re-open if you can provide more detail.


[core-xml] Updating to latest fast-xml-parser

Packages impacted by this PR

@azure/core-xml

Issues associated with this PR

#30721

Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


manual delete TaskRun, its ownerReference PipelineRun remains Running

Expected Behavior

pipelinerun status to failed
pipelinerun event record this situation

Actual Behavior
pipelinerun remains running
Steps to Reproduce the Problem

manual delete taskrun

Additional Info

Kubernetes version:
Output of kubectl version:
1.16

Tekton Pipeline version:
Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

0.17.3

/assign @sbwsg
/remove-lifecycle stale
thanks @sbwsg!

Hey @leo1515416043 thanks for the issue report. I'm going to describe what's happening here. For context, I'm running on the latest Tekton Pipelines from source.
What you are seeing is expected behaviour: when an owned TaskRun is deleted mid-execution the PipelineRun reconciler does not know that a deletion happened. Instead the only thing that the PipelineRun reconciler knows is that the TaskRun doesn't exist. This in turn leads to the reconciler attempting to re-create the TaskRun so that it can complete its work.
Now an interesting extra detail related to some very recent changes in Tekton Pipelines is that a PipelineRun will fail when one of its TaskRuns are deleted. The reason for this is that the names of TaskRuns are now no longer randomized. If a TaskRun is deleted the PipelineRun reconciler will see an update and attempt to re-create the TaskRun. However, if the Pod or the TaskRun are slow to delete then either the TaskRun reconciler or the PipelineRun reconciler will receive an error while trying to re-create those objects. At this point the TaskRun and/or PipelineRun will be placed into a failed state.
I believe this is an intended change in behaviour but I am pinging @afrittoli here for more context around the kmeta.ChildName fixes.

Here's also the PipelineRun I used to test this behaviour:
kind: PipelineRun
apiVersion: tekton.dev/v1beta1
metadata:
  name: test
spec:
  pipelineSpec:
    tasks:
    - name: foo-task
      taskSpec:
        steps:
        - name: waiter
          image: alpine:latest
          script: |
            sleep 10000s

So I created this using kubectl apply -f ./test.yaml and then opened a new terminal and started watching PipelineRuns with kubectl get pipelineruns -w.  Then I deleted the taskrun with kubectl delete taskrun test-foo-task.  On a slightly older version of Pipelines I issued kubectl delete taskrun test-foo-task-<random-string>.
It might be helpful if there was also more context around why this is an important use-case for your @leo1515416043 .  Is there a specific feature you are trying to implement with Tekton that requires you delete owned TaskRuns rather than their PipelineRuns?


rename to react-native-vision-camera-code-scanner?

As discussed briefly over at RNVC discussion groups do you consider to rename the project before it lifts off? ;)
react-native-vision-camera-code-scanner is long but makes the connection to react-native-vision-camera clear and follows other npm pluggable packages (eslint-plugin-*)
vision-camera-code-scanner would probably fine too unless there is a vision-camera project in the future.
Maybe it could also directly move under an umbrella orga repo: @react-native-vision-camera/code-scanner?
Keep up the good work, saved me a ton of work ;)

solved in https://github.com/rodgomesc/vision-camera-code-scanner/pull/26,
0.1.6 is now available on npmjs


Integrate @graphql-yoga/plugin-apollo-inline-trace into HTTP for Apollo's federated tracing

Add support for Apollo's federated tracing by integrating the @graphql-yoga/plugin-apollo-inline-trace plugin.
I considered making a plugin, but plugins seem to rely on envelop's plugin signature - until https://github.com/n1ru4l/envelop/pull/1515 (or something alike) lands - envelop is not capable of supporting this kind of tracing.

Superseded by #4641.


Is the introduction page of wiki wrong?

Can I know this is correct?
This image is introduction of cluster in raft github wiki.
there are same IP addr and port numbers.
Is this the scenarios concerning the different cluster nodes in same machine?

It's definitely wrong, and not just because of the IP addresses. That documentation has been removed from the README and should have been removed from the wiki. I've deleted the wiki. What's in the master branch is what will be released in the coming weeks, and that is being documented separately. Documentation will go in the README until a release and then it will be moved to the wiki.


Fix deprecation warning

When running, it throws the following deprecation warning, so just fixing that:
PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in ~/.composer/vendor/dominikb/composer-license-checker/src/ConstraintViolationDetector.php on line 69

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in ~/.composer/vendor/dominikb/composer-license-checker/src/ConstraintViolationDetector.php on line 69

Thanks! 👍

@dominikb would you mind cutting a new release with this fix?

Just tagged release 2.4.1 with it. Thanks for reminding me!


Support for Symfony 4

Fixes #354

Works for me 👍

@stof removed that .idea from .gitignore

Works for me too (y)

@stof we need this bundle soon :+1:

Oh please merge this!

+1 Pretty please, @stof!

Both #355 and this PR are 👍 for me. This bundle already has only private services and I can't see any other issues with this bundle and 4.0.
AND, I've just tested this bundle extensively with 4.0 and Flex and could not find any issues. Here is a Flex 4.0 project using this bundle: I was even able to activate ALL the listeners and everything looked just fine: https://github.com/weaverryan/stof_doctrine_extensions_40_test
@stof could we have a merge and tag? Personally, this is blocking our KnpU "Upgrade to Symfony4" tutorial :).
Thanks!

ping

@stof is there an ETA on this merge?

@stof Thanks for the merge. Could you tag now? Are there any issues that need to be addressed before creating a tag?

tag please


Cookie Clicker Game

I want to add Cookie Clicker Game which will be made using python

@TusharAMD kindly assign


[BUG] Memory leak issue ,Clean Up handling,Preserve handling during compaction

clean up handling is done in compaction flow.
Fixed the memory leak issue in query execution flow.
Corrected the preserve segment to exclude the already merged segment from the preserve.

retest this please

retest this please

retest this please

retest this please

retest this please


Problem when I use devops scripts.

I want mount local source folder in the container,but when I ues order "devops/deploy.sh start --build",it occured a error and failed.
The build log is this:
Building worker
Step 1/23 : FROM ubuntu:20.04
---> Using cache
---> 3d4874a4bcb4
Step 18/23 : RUN ansible-playbook -i inventory/local docker_ansible.yml --extra-vars="docker=girder_worker" &&     sudo rm -rf /var/lib/apt/lists/* /tmp/*                 /home/ubuntu/.cache                 /home/ubuntu/.ansible*                 /home/ubuntu/.wget-hsts                 /root/.cache/pip &&     sudo find / -xdev -name '*.py[oc]' -type f -exec rm {} + &&     sudo find / -xdev -name pycache -type d -exec rm -r {} +
---> Running in fbb09921364c
PLAY [local] *******************************************************************
TASK [Gathering Facts] *********************************************************
ok: [localhost]
TASK [common : Ensure the girder group exists] *********************************
ok: [localhost]
TASK [common : Ensure the girder user exists] **********************************
changed: [localhost]
TASK [common : Give ownership of root dir to appropriate user] *****************
changed: [localhost]
TASK [common : Install curl] ***************************************************
ok: [localhost]
TASK [common : Install aptitude] ***********************************************
changed: [localhost]
TASK [common : Upgrade system packages] ****************************************
changed: [localhost]
TASK [common : Install pycurl and apt-transport-https package in order to use the apt_repository module and install from https] ***
changed: [localhost]
TASK [common : Install packages needed for girder plugins] *********************
changed: [localhost]
TASK [common : Create a docker group] ******************************************
changed: [localhost]
TASK [common : Join the docker group] ******************************************
changed: [localhost]
TASK [common : Set /opt to public] *********************************************
changed: [localhost]
TASK [common : Add .vimrc to make developers happy] ****************************
changed: [localhost]
TASK [common : Fetch python3-distutils] ****************************************
ok: [localhost]
TASK [worker : Install gpg dependencies] ***************************************
skipping: [localhost]
TASK [worker : Fetch GPG key for docker package] *******************************
changed: [localhost]
TASK [worker : Add docker PPA] *************************************************
skipping: [localhost]
TASK [worker : Install worker dependencies] ************************************
skipping: [localhost]
TASK [worker : Start docker daemon] ********************************************
skipping: [localhost]
TASK [worker : Clone girder_worker] ********************************************
fatal: [localhost]: FAILED! => {"changed": false, "cmd": "/usr/bin/git ls-remote git://github.com/girder/girder_worker.git -h refs/heads/master", "msg": "fatal: remote error: \n  The unauthenticated git protocol on port 9418 is no longer supported.\nPlease see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.", "rc": 128, "stderr": "fatal: remote error: \n  The unauthenticated git protocol on port 9418 is no longer supported.\nPlease see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.\n", "stderr_lines": ["fatal: remote error: ", "  The unauthenticated git protocol on port 9418 is no longer supported.", "Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information."], "stdout": "", "stdout_lines": []}
PLAY RECAP *********************************************************************
localhost                  : ok=15   changed=11   unreachable=0    failed=1    skipped=4    rescued=0    ignored=0
Removing intermediate container fbb09921364c
Error building worker
Any suggestions? Thanks in advance!

github changed some configuration settings.  We addressed this in https://github.com/DigitalSlideArchive/digital_slide_archive/pull/200.  Please pull the latest version and try again.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_8b36l73wq5/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_8b36l73wq5/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_8b36l73wq5/clone/recipe/meta.yaml:42: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_8b36l73wq5/clone/recipe/meta.yaml:42: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_8b36l73wq5/clone/recipe/meta.yaml:42: missing_dev_url: The recipe is missing a dev_url
WARNING: /tmp/abs_8b36l73wq5/clone/recipe/meta.yaml:42: missing_description: The recipe is missing a description
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_97n4oehagb/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_97n4oehagb/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_97n4oehagb/clone/recipe/meta.yaml:42: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_97n4oehagb/clone/recipe/meta.yaml:42: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_97n4oehagb/clone/recipe/meta.yaml:42: missing_description: The recipe is missing a description
ERROR: /tmp/abs_97n4oehagb/clone/recipe/meta.yaml:42: missing_license_family: The recipe is missing the about/license_family key.
Errors were found


utcnow() -> now(UTC)

This makes the nows timezone-aware, as demanded by Python 3.12+.
Towards fixing #845.

Thank you for starting on this, but this isn't quite complete. datetime.UTC is only available in python 3.11+, and some additional checks need to be made to avoid comparing timezone-aware and naive datetimes.

Thanks for completing!


[Build Break] K-NN similarity_search/CMakeLists.txt: No such file or directory

Describe the bug
sed: can't read external/nmslib/similarity_search/CMakeLists.txt: No such file or directory
To Reproduce
Steps to reproduce the behavior:

./bundle-workflow/build.sh manifests/opensearch-1.1.0.yml --component k-NN --snapshot

+ cd jni
+ '[' x64 = x64 ']'
+ sed -i s/-march=native/-march=x86-64/g external/nmslib/similarity_search/CMakeLists.txt
sed: can't read external/nmslib/similarity_search/CMakeLists.txt: No such file or directory
2021-09-15 15:10:31 ERROR    Error building k-NN, retry with: /var/jenkins/workspace/bundle-build/bundle-workflow/build.sh manifests/opensearch-1.1.0.yml --component k-NN --snapshot
Traceback (most recent call last):
  File "/var/jenkins/workspace/bundle-build/bundle-workflow/src/build.py", line 63, in <module>
    builder.build(target)
  File "/var/jenkins/workspace/bundle-build/bundle-workflow/src/build_workflow/builder.py", line 38, in build
    self.git_repo.execute(build_command)
  File "/var/jenkins/workspace/bundle-build/bundle-workflow/src/git/git_repository.py", line 67, in execute
    subprocess.check_call(command, cwd=cwd, shell=True)
  File "/usr/lib64/python3.7/subprocess.py", line 363, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '/var/jenkins/workspace/bundle-build/bundle-workflow/scripts/components/k-NN/build.sh -v 1.1.0 -a x64 -s true -o artifacts' returned non-zero exit status 2.
Jenkins 2.289.3

Taking a look..

"nmslib" submodule was not pulled before attempting to modify one of its files. This didnt have to do it because the submodule was pulled when cmake had been implicitly ran on the machine via gradle before making this call.
I will explicitly init the submodule, test, and submit a new PR.

Closed via https://github.com/opensearch-project/opensearch-build/pull/489


Add scaling for gateway controllers automatically created by Istio

Describe the feature request
We want to be able to scale the gateway controller deployments; right now, there seems to be no way to add HPA or ScaledObjects that target the gateway controller deployments that Istio creates when a Gateway is created: https://github.com/istio/istio/blob/master/manifests/charts/istio-control/istio-discovery/files/kube-gateway.yaml
Describe alternatives you've considered
We need to create an object that targets the deployment based on the name pattern that Istio uses to generate the gateway controller deployment.
If that name pattern changes at some point this would break the integration, this is why we would like to have this done by the istio controller.
Affected product area (please put an X in all that apply)

[x] Performance and Scalability

https://istio.io/latest/docs/tasks/traffic-management/ingress/gateway-api/#resource-attachment-and-scaling -- the naming pattern is standardized in the upstream API so it is stable to depend on


Wizard 'Cancel' button doesn't work

Using dev-launcher on Ubuntu 16.04, Cancel button doesn't work, nothing happens when click on it.

Done


Fix doc requirements to address build issue

A new version of sphinx-markdown-tables (0.0.16) was recently released and is compatible with the current Markdown release (3.4.1) that had previously broken sphinx-markdown-tables.  This PR updates the relative minimum versions of these packages and removes the previously imposed cap and exclusion.
Fixes: #2837
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

sphinx-markdown-tables 0.0.16 causes doc builds with Markdown < 3.4 to fail:
Extension error (sphinx_markdown_tables):
Handler <function process_tables at 0x7faf1779b3b0> for event 'source-read' threw an exception (exception: __init__() takes 2 positional arguments but 3 were given)

We therefore might have to cap sphinx-markdown-tables if we publish another 3.x.y patch release (x < 11).

Yes, that is correct.  Good point. Damned if you, damned if you don't. 😁


Nested italic and bold not working properly.

I am using this awesome gem in my current work but run into the problem while nesting bold text inside italic.
Here is the scenario.
This is the code I use:
*You **can** combine them*

This is the code produced by the gem:

You *can** combine them*

I would except the following output:

You can combine them

Please see the feedback by clicking on the  edit button.
Thanks
Madhu Rakhal Magar

Weasyl/misaka@90aad1b and Weasyl/misaka@548d921 (minus the change to find_emph_char that Redcarpet seems to have applied already) might fix this.

+1


https://apt.dockerproject.org down again?

I saw an earlier issue filed related to this that was closed last year, but it seems that the issue still exists and I can not install docker on my Ubuntu machines.
apt-get update
:
Ign https://apt.dockerproject.org ubuntu-trusty Release
Err https://apt.dockerproject.org ubuntu-trusty/main amd64 Packages
  Operation timed out after 0 milliseconds with 0 out of 0 bytes received
Ign https://apt.dockerproject.org ubuntu-trusty/main Translation-en_US
Ign https://apt.dockerproject.org ubuntu-trusty/main Translation-en
Fetched 200 kB in 3min 0s (1,110 B/s)
W: Failed to fetch https://apt.dockerproject.org/repo/dists/ubuntu-trusty/main/binary-amd64/Packages  Operation timed out after 0 milliseconds with 0 out of 0 bytes received

E: Some index files failed to download. They have been ignored, or old ones used instead.

Do we have any remedy for this?

I'm not aware of it being down (or having been down). Are you still having this issue?

I'm going to close this issue as there doesn't seem to be any issue with this. Please make sure there's no corporate proxy or some kind of firewall which is blocking access to certain websites.


Escape abbreviation before substitution

Fixes https://github.com/nipunsadvilkar/pySBD/issues/80

Perhaps there should be some unit tests for these functions?

Hey @matthen, Sorry for the late reply! was tied up in other commitments.
Yes, adding those unit tests would definitely help. Since PySBD is inspired by https://github.com/diasks2/pragmatic_segmenter, have kept tests and design pretty similar. Having said that, more tests are always welcome :)
Also, can you please take a pull from master? I've fixed the failing CI issue

Thanks Nipun! I have updated the branch and it looks like CI is passing. How about a separate PR to add a unit test that checks https://github.com/nipunsadvilkar/pySBD/issues/80 ?

Yes separate PR would be fine


Running app on expo

Hello everyone!
It is not an issue, just a question (sorry by the way if it is not in correct place): can we somehow connect that project to expo?
Thanks in advance,
Odin

Hi @odinscode , this project contains custom native iOS and Android modules which I believe prevents this project from being connected to Expo. Is there something in particular you were wishing to get out of this project being connected to Expo?

Hi @Gulci, I'm not really comfortable with Android Studio and I don't have any opportunity to use XCode. So I wanted to use Expo to navigate throw that application to get more experience in it.
Due to inexperience in react native I don't know how to correctly configure expo in particular.
I would glad to hear any suggestions or advice, thanks!

Hi @odinscode, it sounds like you are on a PC, so Android Studio would be your best option for moving forward. To do this, follow the instructions here after selecting the 'Build Projects with Native Code' tab. If you need assistance with a particular step of the Android Studio setup, you can email me directly<EMAIL_ADDRESS>Expo out of the box will not work with our project for reasons Gulci mentions above. Expo does offer early Alpha support for working with native code, which you can learn about here: https://docs.expo.io/versions/latest/guides/expokit.html


fix(http): fix so referer header is resolved depending on request class in invalid response

This PR fixes Call to undefined method Tempest\Http\GenericRequest::getHeader() error that happens when the request is not an instance of PsrRequest when you return a Invalid response.
This also happens when you throw a ValidationException from a controller. (and according to the signature it should work 😬)

Perfect, thanks!


draft of PSGet3.0 proposal

Any additional comments, please post to the PR to RFC repo.  Thanks everyone!


Migrate all CI/CD to Github actions

Migrate all CI/CD to Github actions
=> Remove Circle CI
=> Sonar Analysis in Github actions

Hey @LGouellec do you need help implementing this task? I can do it, if you need it.

Hi @joaovitorpina ,
As you want, the aim of this issue is to use only GitHub actions for ci/cd, integration and release jobs.
Feel free to make a PR.
Appreciate thanks


Freeze k/website for Kubernetes 1.19 release

This issue is for freezing the k/website for Kubernetes 1.19 release.
The release is scheduled to happen tomorrow (Aug 25th) and No PRs allowed to merge until the release PR has successfully merged.
For any queries, please contact me or anyone from docs release team cc'd here
cc: @annajung @divya-mohan0209 @mikejoh @zestrells

/sig release

K8s v1.19 is out 🥳
/close


Locale button is not working when a keyboard is used as an input view

The globe (next locale) button on iPad isn't working – it doesn't trigger the next locale, it makes the background white every 3rd press, and also long pressing and selecting a locale doesn't work. It works fine on iPhone (button labelled with the current locale) Testing with https://github.com/KeyboardKit/KeyboardKitPro/commit/9c195c2682c52a3e19b2a38cad262ea4b0daa3a8.
https://user-images.githubusercontent.com/1141167/197168480-d0482917-410c-4304-ab57-b8c56b7245d4.mp4

Thanks for letting me know @nrbrook - I will look into it!
This has worked since forever, so I wonder what can cause this.

Hi again,
I've given it a try now, using both the non-pro and the pro demos, and both work for me.
Here's a video of the pro demo, using both long press and tap:
https://user-images.githubusercontent.com/429927/197324732-7d578042-a552-42de-a6d5-bdb7f0093729.mov
Did you do any customizations or used the keyboard in a way that can help me reproduce the bug?

I think it’s probably because I’m using it as an input view?

Yes, that's probably the case since the button tries to trigger a very specific action from the input controller, which I guess is missing when you use it as an input view.
If you send me the code you use to set it up as an input view, I'll try to reproduce the error with that setup. If it's not possible to switch keyboards in this state, you can always create a custom layout and simply remove the button.

If you use this commit in our package: https://github.com/AirTurn/AirTurnReplacementKeyboard/commit/d2246b2b99997072486605eabde96a4d80cbd493
You can use it as follows:
import AirTurnReplacementKeyboard

...

textField.inputView = AirTurnReplacementKeyboardViewController().view
textField.reloadInputViews()

Perhaps a solution would be to add a property to KeyboardContext like var enableSystemNextKeyboardButton = true and check the value in SystemKeyboardActionButtonContent:
if action == .nextKeyboard {
            #if os(iOS) || os(tvOS)
            if context.enableSystemNextKeyboardButton {
                NextKeyboardButton()
            } else {
                Image.keyboardGlobe
            }
            #else
            Image.keyboardGlobe
            #endif
        }

Unless there is a way to determine if operating in a keyboard extension automatically...

I will look into this whenever I focus on making the keyboard working in an app.


[WIP] feature: start podsandbox stopped forced

Signed-off-by: Starnop<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Support to the ability to get the same IP after restart the PodSandbox.
Scenario: It will fail to get IP after PodSandbox restarts  because of the external factors such as shutdown the host.
Ⅱ. Does this pull request fix one issue?

None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
None.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
No need to review it now, I will delete [WIP] when it's ready.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #2237 into master will decrease coverage by 0.14%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2237      +/-   ##
==========================================
- Coverage   66.56%   66.41%   -0.15%
==========================================
  Files         208      208
  Lines       16756    16782      +26
==========================================
- Hits        11153    11146       -7
- Misses       4276     4310      +34
+ Partials     1327     1326       -1

Flag
Coverage Δ

#criv1alpha1test
32.94% <0%> (ø)
:arrow_up:

#criv1alpha2test
33.64% <33.33%> (+0.18%)
:arrow_up:

#integrationtest
39.86% <0%> (-0.06%)
:arrow_down:

#nodee2etest
33.52% <33.33%> (-0.17%)
:arrow_down:

#unittest
23.81% <0%> (-0.05%)
:arrow_down:

Impacted Files
Coverage Δ

cri/v1alpha2/cri_wrapper.go
63.56% <0%> (-0.88%)
:arrow_down:

cri/v1alpha2/cri.go
70.19% <5.88%> (-1.7%)
:arrow_down:

cri/v1alpha2/cri_utils.go
90.37% <70%> (-0.62%)
:arrow_down:

cri/ocicni/cni_manager.go
65% <0%> (-15%)
:arrow_down:

daemon/mgr/snapshot.go
89.85% <0%> (-4.35%)
:arrow_down:

ctrd/image.go
76.75% <0%> (-2.2%)
:arrow_down:

daemon/containerio/container_io.go
74.58% <0%> (-1.11%)
:arrow_down:

daemon/mgr/container.go
57.59% <0%> (-0.21%)
:arrow_down:

ctrd/container.go
60.23% <0%> (+0.47%)
:arrow_up:

... and 3 more

LGTM as well.


WIP: Start trying to port to recoil

I might abandon this, but I was curious what it would take to port speedscope to use recoil instead.
I'm currently stuck on thinking about how to do per-profile, per-speedscope-tab state that doesn't leak memory or create a ton of boilerplate. I'm not really clear on what granularity of atoms to use.

Coverage decreased (-0.08%) to 46.746% when pulling 13a8bfc4a029c28345449daf4e554df9a2bdddea on jlfwong/react-recoil into 9ecea8ec5f7f8d6d259f9b9366f1f3d1b49f9915 on jlfwong/react-switch.

Superseded by #341.


Introduce a tag-system that actually represents PyPi releases

I should make sure that different versions of the module get different tags attached, that correspond to their version numbers (as in, git tags). I think this is fairly self-explanatory, so not much to add here.

I implemented this in https://github.com/phseiff/github-flavored-markdown-to-html/commit/03fbc05dd56917de23df91b8126e03ef71cb5640.


crop is being called infinite times

crop is being called infinite times when passing image src as updated(rotated or cropped) image url.
passing src as below code:
src={this.state.imageUrl}
crop={this.state.crop}
As a result getting black screen with crop rectangle.

Hi how are you rotating or cropping the image can you provide an example using one of the codesandboxes? You can probably copy the base64 data to a variable and pass it

Also need to know the crop object settings - most importantly if you are
using percentage crops
On Tue, 14 Apr 2020 at 19:31, nitesh8402<EMAIL_ADDRESS>wrote:

crop is being called infinite times when passing image src as
updated(rotated or cropped) image url.
passing src as below code:
src={this.state.imageUrl}
crop={this.state.crop}
As a result getting black screen with crop rectangle.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DominicTobias/react-image-crop/issues/349, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFZT6XS3DQ5STWGO6IRFB3RMRCSDANCNFSM4MHVGUQQ
.

for rotation :
imageStyle={{transform: rotate(${this.state.rotation}deg)}}
crop: {
unit: "%",
width: 30,
aspect: 16/9,
},
"react-image-crop": "^8.6.2",
browser: chrome on macOs
using below codesandbox example as reference:

crop: {
unit: "%",
width: 30,
aspect: 16/9,
}
onImageLoaded = image => {
this.imageRef = image;
};
onCropComplete = crop => {
this.makeClientCrop(crop);
};
onCropChange = (crop, percentCrop) => {
this.setState({ crop });
};
render() {
const { crop, croppedImageUrl, src } = this.state;
return(){
<ReactCrop
src={croppedImageUrl? croppedImageUrl: src}
crop={crop}
ruleOfThirds
onImageLoaded={this.onImageLoaded}
onComplete={this.onCropComplete}
onChange={this.onCropChange}
imageStyle={{transform: rotate(${this.state.rotation}deg)}} // rotating with button
/>
}
}
"react-image-crop": "8.6.2",
browser: chrome on macOs

Are you rotating the image to try and fix the rotation? If so refer to the link in the other issue you raised which should also fix this issue. Though I'll still look into why the library does not expect you to apply a css rotation to the image.

https://codesandbox.io/s/react-image-crop-demo-with-classes-b2yfv?file=/src/index.js
here is my sandbox link. Please find.
I am not able to get rotated cropped image Preview as expected.
when i rotate the image and than crop, i got the resultant image as it was not rotated and cropped.
Please get the below url for better understanding.

Thanks for the repro, rotation issue aside are you getting the infinite loop/crash in that sandbox? I tried a couple of images but was ok - if it's a specific image please upload it here

Closing due to lack of activity, will re-poen if needed

Hi,
I am using React Image Crop inside a Formik component and the onChange Callback is being called infinitely. Here is my code:
const INITIAL_CROP = { unit: 'px', width: 320, aspect: 16 / 9 };

const SaveBanner = ({ show, handleClose, onSubmit, defaultValues }) => {
	const [crop, setCrop] = useState(INITIAL_CROP);
	const imgRef = useRef(null);
	const initialValues = { <some values> };
	const validationSchema = Yup.object({<some schema>});

	const onLoad = useCallback(img => {
		imgRef.current = img;
	}, []);

	return (

			<Modal show={show} onHide={handleClose} size='lg' scrollable>
				<Modal.Header closeButton>
					<Modal.Title>{!defaultValues ? 'Create' : 'Update'} Banner</Modal.Title>
				</Modal.Header>
				<Modal.Body>
					<Formik
						initialValues={defaultValues || initialValues}
						validationSchema={validationSchema}
						onSubmit={onSubmit}
					>
						{({ dirty, isSubmitting, values, setFieldValue }) => {
							return (
								<>
									<Form noValidate className='d-flex flex-column'>

											<FormikControl
												control='text'
												name='name'
												label='Title'
												placeholder='Enter Banner Title'
												required={true}
												containerClassName='form-group col-md-6'
											/>

											<FormikControl
												control='file'
												name='image'
												label='Banner Image'
												required={true}
												containerClassName='form-group custom-file col-md-6 mt-2'
											/>

										<ReactCrop
											src={values.image && URL.createObjectURL(values.image)}
											onImageLoaded={onLoad}
											crop={crop}
											onChange={c => setCrop(c)}
										/>

											<Button
												variant='danger'
												className='mr-2'
												type='button'
												onClick={handleClose}
												disabled={isSubmitting}
											>
												Cancel
											</Button>
											<Button variant='primary' type='submit' disabled={!dirty || isSubmitting}>
												{!defaultValues ? 'Create' : 'Update'}
											</Button>

									</Form>
								</>
							);
						}}
					</Formik>
				</Modal.Body>
			</Modal>

	);
};

export default SaveBanner;

Can someone please tell me where the problem lies?
Thanks.


Handle infinity and NaN cases

http://en.cppreference.com/w/cpp/io/c/fprintf
snprintf will format infinity and nan doubles as Inf/Infinity or nan/nan(char_sequence) respectively.  This  can break the validity of a json.dump() document: https://github.com/nlohmann/json/blob/1580eee4ed36cce2251c42ced420807abe8fa35f/src/json.hpp#L2279
You can check for infinity/nan w/ std::isinfinite/std::isnan - not sure what you'd like to actually do in those scenarios (some specific/configurable string representation?)
http://en.cppreference.com/w/cpp/numeric/math/isfinite

Looking into what others do, it seems the ECMAScript 5.1 specification explicitly specifies stringifying +/- Infinity and NaN as null.
NOTE 4 Finite numbers are stringified as if by calling ToString(number). NaN and Infinity regardless of sign are represented as the String null.

http://www.ecma-international.org/ecma-262/5.1/#sec-15.12.3
Of course, 'the String null' is pleasantly ambiguous.  In Chrome I see it's actually doing:
JSON.stringify({x: NaN});
"{"x":null}"

Hi @EricMCornelius, thanks for the note. I'll check it tonight. All the best, Niels

With 3.0.0, the semantics of this changed: NAN and infinity are stored properly inside the JSON value (no exception or conversion to null), but are serialized as null.
(#329 and #388 are related).

This issue is fixed with 8feaf8dc94a88393510637af36a24163c95a1b45 as follows:

If an overflow occurs during parsing a number from a JSON text, an exception (std::out_of_range for the moment, to be replaced by a user-defined exception #244) is thrown so that the overflow is detected early and roundtripping is guaranteed.
NaN and INF floating-point values can be stored in a JSON value and are not replaced by null. That is, the basic_json class behaves like double in this regard (no exception occurs). However, NaN and INF are serialized to “null”.
Adjusted test cases appropriately.

Waiting for Travis to complete. Then this issue can be closed and the different semantics can be described in the wiki.


Doc fix

Two commits:

Fix relative link in docs
Change REST server notebook to use Werkzeug as a local HTTP server; saved outputs to both notebooks.

Let me know if you want me to clone this PR and run nbfmt for you.

No, I got it just now. Thanks though! Checks running...


How to setup TP Overlap configs

Hi!
After checking across multiple NVIDIA projects (NeMo, NeMo Framework Launcher & Megatron) I'm still wondering how do I have to setup all the configs related with TP Overlap. The little explanation I've found is this chapter in the NeMo docs.
So far I've seen this folder in NeMo Framework Launcher which contains similar configs to the ones in NeMo 2.0. From the names of the configs I can more or less derive to which hidden size, tp, cp, mbs & sequence  length are optimised for but I would like to understand a bit more what is happening & also some guidelines to tune this parameters for my underlaying hardware (GH200).
Thanks!

Hi @TJ-Solergibert -- the chapter in NeMo documentation is, I believe, the best description of what TP overlap does conceptually but you're correct that there is not much guidance anywhere for the overlap configs. It's on our roadmap to improve the documentation for this on the TE side, and I'm hoping to include it in some other TP overlap-related items on our agenda in January. In the meantime, I'll share some guidance on the config options here in TE's own API.
In pure-TE/PyTorch code (without NeMo), we initialize and configure TP overlap with transformer_engine.pytorch.initialize_ub(...). The docstring for this shows the structure of the config dictionary, which NeMo constructs from the YAML config files you've seen in their repo. I'll list these options below with some descriptions of what they are and guidance on how to use them:

"method" : str

"ring_exchange" -- Overlap GEMM with point-to-point send/recv kernels. Send/recv is executed by the Copy Engine and does not require any SMs if "use_ce" : True. Supports both all-gather and reduce-scatter overlaps.
"pipeline" -- Overlap GEMM with collective/pipelined reduce-scatter kernel. Does not support all-gather overlap, only reduce-scatter. Requires an SM margin reservation via "num_sm" : int and "set_sm_margin": True.
"bulk" -- Overlap GEMM with an independent bulk all-gather or reduce-scatter. Requires an SM margin reservation via reservation via "num_sm" : int and "set_sm_margin": True.

"num_splits": int -- Number of chunks to divide the GEMM operation into. This option is ignored when "method" : "ring_exchange" and forced to be equal to the # of GPUs in the tensor-parallel group.
"num_max_streams": int -- Maximum number of compute streams for GEMM chunks, capped by the number of chunks (i.e. min(num_splits, num_max_streams)). Default value is set to 3.
"use_ce" : bool -- Flag for using the Copy Engine to execute send/recv kernels when "method" : "ring_exchange". Ignored when "method" : "pipeline" or "method": "bulk". Default value set to True.
"atomic_gemm" : bool -- Instead of looping over GEMM chunks on the host and launching a separate GEMM kernel for each, launch a single atomic GEMM kernel that loops over chunks on device. Set to False by default, and typically sub-optimal with CUDA graphs.
"aggregate" : bool -- Aggregate 2X GEMM chunks when overlapping all-gather. Since "num_splits" is fixed to the tensor-parallel number of GPUs when "method" : "ring_exchange", aggregating 2X chunks per compute stream can help improve the overlap efficiency for smaller problem sizes where the GEMM kernel executes too quickly. Set to False by default.
"num_sm" : int -- Number of streaming multiprocessors (SM) to reserve for communication kernels. This is ignored when "set_sm_margin" : False.
"set_sm_margin" : bool -- When set to False, GEMM kernels flood all available SMs on device. Otherwise, "num_sm" count of SMs are excluded from the GEMM kernel. This should not be used with "method" : "ring_exchange" and "use_ce" : True` since Copy Engine can execute P2P send/recv without requiring any SMs.

I would recommend starting out with one of the existing configs in NeMo and looking at execution profiles to see if there is any communication left that's not hidden by a GEMM execution. For pipeline overlaps, that typically means you need to increase your SM margin to slow down the GEMM kernel and speed up the comms until you're able to cover all your communication behind the GEMM compute. Conversely, you would need to decrease your SM margin if the GEMM is too slow and communication streams stuck waiting for chunks to finish compute. Ring-exchange overlaps with Copy Engine send/recv can't tune with SM margins but these are also typically performant out-of-the-box.
Since you're using GH200s, I should point out that TP overlap currently does not support Multi-Node NVLink so it restricts your TP size to the 2 GPUs on a single GH200 node. Adding this support is one of the other TP overlap-related items I mentioned on our roadmap, but until then, it may not make sense to use it


useClientEffect$ doesn't get triggered with projection component as root

Qwik Version
0.12.1
Operating System (or Browser)
any
Node Version (if applicable)
any
Which component is affected?
Qwik Runtime
Expected Behaviour
component$s that have implemented useClientEffect$ should be triggered even when the root of the containing component holds a projection <Slot />
const ComponentA = component$((props) => {
    return (

            <Slot />

    )
})

const Main = component$((props) => {
    useClientEffect$(() => {
         //should be triggered
         console.log('some code to be resumed on browser')
    })
    return (
          <ComponentA>hello world</ComponentA>
    )
}

Actual Behaviour
The useClientEffect$ is not triggered when the root of that containing component has a projection.
const ComponentA = component$((props) => {
    return (

            <Slot />

    )
})

const Main = component$((props) => {
    useClientEffect$(() => {
         //not triggered
         console.log('some code to be resumed on browser')
    })
    return (
          <ComponentA>hello world</ComponentA>
    )
}

Repro https://stackblitz.com/edit/qwik-starter-jq3bna?file=src/app/index.tsx
Additional Information
One workaround for this to work is to wrap it with a div
const Main = component$((props) => {
    useClientEffect$(() => {
         console.log('some code to be resumed on browser')
    })
    return (

 {/*this workaround triggeres the useClientEffect*/}
               <ComponentA>hello world</ComponentA>

    )
}

I just ran into this issue. No errors; just the JS in useClientEffect$ never ran. And it took me a long to realize that it was even happening since it was data that doesn't update frequently and loads first on the server.
Wrapping the component in a
 worked so thanks for mentioning that workaround!

looks related https://github.com/BuilderIO/qwik/issues/1413?


Annotate and remove support auto commit

Contributes to https://github.com/iterative/gto/issues/25

Codecov Report
Base: 86.10% // Head: 86.30% // Increases project coverage by +0.19% :tada:

Coverage data is based on head (801acfd) compared to base (900610e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   86.10%   86.30%   +0.19%
==========================================
  Files          15       15
  Lines        1929     1971      +42
==========================================
+ Hits         1661     1701      +40
- Misses        268      270       +2

Impacted Files
Coverage Δ

gto/api.py
93.33% <100.00%> (+0.10%)
:arrow_up:

gto/cli.py
72.93% <100.00%> (+0.08%)
:arrow_up:

gto/git_utils.py
97.08% <100.00%> (-1.36%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

There are two things missing yet:

(that I would like to discuss) what should be the commit message? I was thinking to use the command used, something like gto.api.annotate(repo=., name="new-type", auto_commit=True)
raise a gto exception if are trying to commit the changes on a file different from HEAD (as suggested in https://github.com/iterative/gto/issues/25#issuecomment-1277207211)

Hi @aguschin , I think it's ready, I covered the two points left.
Please have a look, in couple of points I had the impression that perhaps the code was getting difficult to read.
In fact I even added a docstring for gto.git-utils.commit_produced_changes_on_auto_commit, something I try to avoid as a general rule.
Looking forward to hear your feedback!
Oh, and a small thing: could you please assign this PR to me? I am not clear if this is important for the Hacktoberfest, but just in case... :P

Awesome! Merging this. Thanks @francesco086!


Expect attribute to be absent

For some reason it was never possible to assert that an attribute is absent by going:
expect(element, 'to have attributes', { foo: undefined });
// or:
expect(element, 'to satisfy', { attributes: { foo: undefined } });

Analogous to the object to satisfy semantics.
This PR fixes that and adds tests.

Yay!