[SPARK-47954][K8S] Support creating ingress entry for external UI access

What changes were proposed in this pull request?

Ingress a kind of K8s resource to expose HTTP and HTTPS routes from outside the K8s cluster to services within the K8s cluster. It's a common use case that uses ingress to access Spark UI for Spark jobs running on K8s in cluster mode.
This PR aims to add such a built-in feature to allow users to enable Ingress for Spark jobs which running on K8s cluster mode.
State: functionality completed; manuelly tested; ready for review to collect feedback
TODO: UT and docs
Why are the changes needed?

Simplify Spark live UI access from outside of the K8s.
Does this PR introduce any user-facing change?

This PR adds a new feature, but is disabled by default.
How was this patch tested?

I will supply the unit tests later.

No.

+CC @zhouyejoe

cc @dongjoon-hyun @yaooqinn @LuciferYang @EnricoMi appreciate it if you could have a look on this idea

Gentle ping, @pan3793 . It would be great if we can land this before Apache Spark 4.0.0-preview.
To @cloud-fan , when do you think you are going to cut 4.0.0-preview tag?

@dongjoon-hyun sorry for late, I'm a little busy these days, will address comments soon

For the record, Apache Spark 4.0.0-preview is scheduled on next Monday.

Just FYI, please take your time. We can target this for Apache Spark 4.0.0.


fix custom op for backward compatibility

Description
The default implementation infer_storage_type_backward in custom op has some problem.
Before this PR, the LR in sparse example is broken due to the custom op, and the added test will throw err message,
Error in mult.infer_type: Traceback (most recent call last):
  File "/home/hanfeng/zyh/mxnet/python/mxnet/operator.py", line 737, in infer_storage_type_backward_entry
    "stypes, got %d."%(total_outputs, len(ostype))
AssertionError: InferStorageTypeBackward Error: expecting 2 entries in returned output stypes, got 1.

[10:27:12] /home/hanfeng/zyh/mxnet/dmlc-core/include/dmlc/./logging.h:308: [10:27:12] src/operator/custom/custom.cc:383: Check failed: reinterpret_cast<CustomOpBackwardInferStorageTypeFunc>( params.info->callbacks[kCustomOpPropBackwardInferStorageType])( stypes.size(), stypes.data(), params.info->contexts[kCustomOpPropBackwardInferStorageType])

cc @eric-haibin-lin @anirudh2290
Checklist
Essentials

[ ] Passed code style checking (make lint)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented.
[ ] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@anirudh2290

Thank you for fixing this and adding the tests! Yes, since the output of stypes which is the in_grads would depend on arguments length and not output length. Can you please let me know what LR example you are referring to?

@anirudh2290 Thanks for your comments. LR example is the linear_classification.py in example/sparse.

Closing this because we are reverting sparse support for custom op


20989 - Exclude USA conditionally

Issue #: /bcgov/entity#20989
Description of changes:

new function to exclude USA conditionally
pass newly created function to filter call

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

@severinbeauvais thanks for spotting this bug.


GH-37107: [C++] Suppress an unused variable warning with GCC 7

Rationale for this change
If there is a warning, debug build is failed by default.
What changes are included in this PR?
Suppress the unused warning explicitly.
Are these changes tested?
No.
Are there any user-facing changes?
Yes.

@c0dzilla Could you confirm this with GCC 7?

@kou confirmed that this works on g++ 7.3:
codzilla@hogwarts:~/arrow/cpp/build$ git diff
diff --git a/cpp/src/arrow/util/ree_util.h b/cpp/src/arrow/util/ree_util.h
index 5a24024..c6bb4e5 100644
--- a/cpp/src/arrow/util/ree_util.h
+++ b/cpp/src/arrow/util/ree_util.h
@@ -104,6 +104,7 @@ int64_t FindPhysicalLength(const RunEndCType* run_ends, int64_t run_ends_size,
                            int64_t length, int64_t offset) {
   auto [_, physical_length] =
       FindPhysicalRange<RunEndCType>(run_ends, run_ends_size, length, offset);
+  ARROW_UNUSED(_);
   return physical_length;
 }

codzilla@hogwarts:~/arrow/cpp/build$ cmake --build .
Recompacting log...
[91/91] Creating library symlink debug/libarrow.so.1300 debug/libarrow.so

Thanks!


CNV-52283: inverted condition in next button disabled

📝 Description
The next button isDisabled condition was inverted.
This button should be disabled if the user didn't selected any disk
🎥 Demo
Before

.

After
https://github.com/user-attachments/assets/d2fee6f5-f364-484f-aef2-056ecbf013d9

/lgtm


4845 ledger fix styling

This is a re-PR based on discussion with serena and sprinkle. Don't merge unless serena leaves a comment saying it's all good ;)

This looks good to go from a visual standpoint.


[SPARK-48035][SQL] Fix try_add/try_multiply being semantic equal to add/multiply

What changes were proposed in this pull request?

This PR fixes a correctness bug in commutative operator canonicalization where we currently do not take into account the evaluation mode during operand reordering.
As a result, the following condition will be incorrectly true:

val l1 = Literal(1)
val l2 = Literal(2)
val l3 = Literal(3)
val expr1 = Add(Add(l1, l2), l3)
val expr2 = Add(Add(l2, l1, EvalMode.TRY), l3)
expr1.semanticEquals(expr2)

To fix the issue, we now reorder commutative operands only if all operators have the same evaluation mode.

Why are the changes needed?

To fix a correctness bug.

Does this PR introduce any user-facing change?
No
How was this patch tested?

Added unit tests

Was this patch authored or co-authored using generative AI tooling?
No

cc: @cloud-fan

Merged to master.


How to install in Community 2019.2?

Im on Ubuntu 18.04 and installed Idea Community 2019.2 through the Toolbox.
This gives me the following environment:
IntelliJ IDEA 2019.2.2 (Community Edition)
Build #IC-192.6603.28, built on September 6, 2019
Runtime version: 11.0.3+12-b304.56 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 5.0.0-27-generic
GC: ParNew, ConcurrentMarkSweep
Memory: 1908M
Cores: 4
Registry:
Non-Bundled Plugins: org.jetbrains.idea.grammar, org.jetbrains.kotlin, com.github.shiraji.ipgwizard
The only plugin I can find in the marketplace for the search term "gradle intellij" is "gradle-intellij-plugin-wizard"
Is the bleeding edge too new for this plugin? If so, what is the currently supported version at this moment?

This is not plugin for the IntelliJ IDEA, it's plugin for Gradle.
You don't need to install Gradle plugin in IntelliJ IDEA, it is bundled there


🎯[Good First Issues]: Vanus Connector Template (Auth0-Discord)

What is a Vanus Connector Template
Vanus connector templates are pre-configured templates for Vanus Cloud and Vanus Open-Source. It is written in JSON. These templates help users create easy-to-use configurations when they use Vanus SaaS or the Vanus OSS.
This templates issue is designed to send Cloud Events from Auth0 to Discord
Features of Connector Template
The connector template should have the following variables

Client name: The name of the Web App that is configured on Auth0
IP Address: The IP address of the user which triggered Auth0
Username: The Username of the user which triggered Auth0
Login Count: The number of times the user has logged in.

Excepted Template Output
The Template output could be in the format below:
Hi <Client Name>, User <User Name> just logged in. <User Name> IP address is <IP Address>. <User Name> has logged in <Login Count> times.
How to claim to implement this template
If you want to solve this issue, please leave a comment on this issue like:

I'd like to develop this template, please assign it to me.

Vanus community will assign the issue to you on time.

I'd like to develop this template, please assign it to me.


[WIP] add race on go test

ref #118

PR: https://github.com/ReactiveX/RxGo/pull/120

Pull Request Test Coverage Report for Build 246

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+6.2%) to 95.416%

Totals

Change from base Build 240:
6.2%

Covered Lines:
1228

Relevant Lines:
1287

💛  - Coveralls


Context extension

Move the arg extension into a static library of its own and turn it off by default.
Call user context deinit before context deinit, because the user context deinit needs a still-functioning context.
Add the context extension and turn it off by default.

This patch seems good. However I don't everybody will happy about this change:
jerry-ext/include/jerryscript-ext/arg.h → jerry-ext/arg/include/jerryscript-ext/arg.h
This will make include directories complicated.

jerry-ext/include/jerryscript-ext/arg.h → jerry-ext/arg/include/jerryscript-ext/arg.h

FWIW, I'm fine with it.
I don't mind having to explicitly add a header search path per util.
Having the headers separated per util It also makes it clearer for the user what headers belong to what util.

Actually, they all install to <prefix>/include/jerryscript-ext and are cumulative:
file(GLOB INCLUDE_FILES_ARG "${INCLUDE_ARG}/jerryscript-ext/*")
install(FILES ${INCLUDE_FILES_ARG} DESTINATION include/jerryscript-ext/)
...
file(GLOB INCLUDE_FILES_CONTEXT "${INCLUDE_CONTEXT}/jerryscript-ext/*")
install(FILES ${INCLUDE_FILES_CONTEXT} DESTINATION include/jerryscript-ext/)

So, only the tests need the many include paths.

My first thoughts:

Why "Move the arg extension into a static library of its own and turn it off by default"? We have had this discussion before and concluded to have a single library for jerry-ext, why divert from that?
In the new build files, there are include paths to internal directories. That flashes very big warning signs to me.

@akosthekiss
The reason I went with separate libraries is for the case where all of them are turned off. If you go with one library (-DJERRY_EXT=ON) but turn off everything else (-DJERRYX_ARG=OFF) and (-DJERRYX_CONTEXT=OFF) then what do you build? I mean, if we go with one library, we still want to give the option to turn parts of it off, right?
I mean, we could have
if(JERRYX_ARG OR JERRYX_CONTEXT OR ...)
  add_library(${JERRYX_EXT_NAME} STATIC)
  if(JERRYX_ARG)
    target_link_libraries(${JERRYX_EXT_NAME} ${JERRYX_ARG_NAME})
  endif()
  if (JERRYX_CONTEXT)
    target_link_libraries(${JERRYX_EXT_NAME} ${JERRYX_CONTEXT_NAME})
  endif()

at the end of jerry-ext/CMakeLists.txt but it's pretty awkward to build conditionally upon n different flags OR-ed together.
We talked about referring to internal API from extensions, and the conclusion was that it was OK because extensions are not mere users of JerryScript, but parts of JerryScript.

OTOH, I guess we could conditionally merge the source files, and then if the list of source files is empty, not define the target. i.e.,
if (JERRYX_ARG)
  file(GLOB JERRYX_ARG_SOURCES arg/*.c)
  set(SOURCES_EXT ${SOURCES_EXT} ${JERRYX_ARG_SOURCES})
endif()
if (JERRYX_CONTEXT)
  file(GLOB JERRYX_CONTEXT_SOURCES arg/*.c)
  set(SOURCES_EXT ${SOURCES_EXT} ${JERRYX_CONTEXT_SOURCES})
endif()
...
if (NOT SOURCES_EXT STREQUAL "")
  add_target(JERRY_EXT_NAME STATIC ${SOURCES_EXT})
endif()

Would you like that better?

@gabrielschulhof

if we go with one library, we still want to give the option to turn parts of it off, right?

Do we? Why? What do we gain by disabling parts of an extension library? If some parts of it are not used, they don't contribute to the final binary of an application.

We talked about referring to internal API from extensions, and the conclusion was that it was OK

I'm not sure I completely agree with that (I know that it's my bad that I haven't expressed my thoughts there). If we may access internal code/API from extensions, then why not call ecma_make_simple_value (ECMA_SIMPLE_VALUE_UNDEFINED) instead of jerry_create_undefined (), and all that? I guess that would trigger some LBTMs. Then why is accessing jmem.h and jrt.h any different?

if we go with one library, we still want to give the option to turn parts of it off, right?

Do we? Why? What do we gain by disabling parts of an extension library? If some parts of it are not used, they don't contribute to the final binary of an application.

If we link a bunch of object files into jerry-ext.a that will never be used, that wastes space, right? OTOH, if you can target_link_libraries(${MY_BINARY_NAME} jerryx-needed1 jerryx-needed2 ...) then you never link anything into your binary that you're not gonna use.
If I don't use jmem.h I have no way of allocating memory, so I can't write any of these extensions. Like, the user of the extension may have some mechanism for allocating memory, but I don't know what that mechanism is. The only mechanism I can use is jmem_heap_alloc_block ().

If we link a bunch of object files into jerry-ext.a that will never be used, that wastes space, right?

Disk space during development: yes. Text/data space in the application binary: I don't think so. That's what we have the linker for. It only cherry-picks those objects from a (static) library that contain symbol definitions for unresolved references in the application objects. Those "parts" (objects) of a library that are not referenced by app objects are not linked into the final binary.

If I don't use jmem.h I have no way of allocating memory

That's true. It might be a public API deficiency. Do you need anything else from jerry-core internals?

@akosthekiss
I'm learning about linkers all the time :) Good to know no space is likely wasted in the final binary.
I need nothing else from jerry-core internals except the memory allocation functionality.

... and I'll put things back to a single libjerry-ext.a.

@akosthekiss The context extension is now added the same way as arg.
@martijnthe I've removed the index. It need not be stored if jerryx_context_get () receives a pointer to the static global structure defining the context to be retrieved, because it can compute the index from that pointer.

Starting to look very slick :)

@martijnthe Thanks!

@akosthekiss do you want me to squash?

@gabrielschulhof eventually, that will be a must

@akosthekiss I squashed the commits, and updated the commit message for the extension to reflect the changed name of the section ("jerryx_ctx_slots") and the fact that the index is no longer stored in the slot.
I also left the commit affecting core separate, because it touches a different part of the repo. Nevertheless, I can squash that in too, if you'd like.

@gabrielschulhof PRs are merged in a "one commit per PR" style. so, if you'd like to keep the change to the core separate, you'll need a separate PR for that, too (although, I don't think that this minor change deserves that)

@akosthekiss squash ALL the commits! :)

OK ... weird that it breaks ...

Oh, I see. There was a rename of the types.

still LGTM (thanks for fixing up the API reference doc)

NP - by the power of git grep :)

HOLD THE PRESSES!
There might be a way we can do the user context that does not require this extension at all. I'll have a PR in a bit.

https://github.com/jerryscript-project/jerryscript/pull/1815

@gabrielschulhof can we close this PR?

Absolutely! Sorry I left it open!


feat: improve global install

Do nothing if environment already exists and fits to requested properties
Improve reporting
Refactor StateChanges

I've cleaned up the color and wording a bit more.


Unexpected error, unable to continue

Describe the bug
I received an error in multiple jobs in the workflow for my RegularExpressions library (commit: c0dd27d):
name: Swift

on: [push, pull_request, workflow_dispatch]

jobs:
  build:
    name: Swift ${{ matrix.swift }} on ${{ matrix.os }}
    strategy:
      fail-fast: false
      matrix:
        os: [ubuntu-latest, macos-latest]
        swift: ["5.0", "5.1", "5.2", "5.3", "5.4"]
    runs-on: ${{ matrix.os }}
    steps:
      - uses: fwal/setup-swift@v1
        with:
          swift-version: ${{ matrix.swift }}
      - uses: actions/checkout@v2
      - name: Build
        run: swift build --build-tests
      - name: Run tests
        run: swift test

Here is the output of some of the jobs that failed:
Swift 5.0 on ubuntu-latest
Set up job
Current runner version: '2.278.0'
Operating System
  Ubuntu
  20.04.2
  LTS
Virtual Environment
  Environment: ubuntu-20.04
  Version: 20210524.1
  Included Software: https://github.com/actions/virtual-environments/blob/ubuntu20/20210524.1/images/linux/Ubuntu2004-README.md
  Image Release: https://github.com/actions/virtual-environments/releases/tag/ubuntu20%2F20210524.1
GITHUB_TOKEN Permissions
  Actions: write
  Checks: write
  Contents: write
  Deployments: write
  Issues: write
  Metadata: read
  Packages: write
  PullRequests: write
  RepositoryProjects: write
  SecurityEvents: write
  Statuses: write
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'fwal/setup-swift@v1'
Download action repository 'actions/checkout@v2'

Run fwal/setup-swift@v1
Run fwal/setup-swift@v1
  with:
    swift-version: 5.0
/usr/bin/gpg --import /home/runner/work/_temp/4f1928c9-cbb8-46a3-aa8f-d68335288a81
gpg: directory '/home/runner/.gnupg' created
gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
gpg: /home/runner/.gnupg/trustdb.gpg: trustdb created
gpg: key D441C977412B37AD: public key "Swift Automatic Signing Key #1<EMAIL_ADDRESS>imported
gpg: key 9F597F4D21A56D5F: public key "Swift 2.2 Release Signing Key<EMAIL_ADDRESS>imported
gpg: key 63BC1CFE91D306C6: public key "Swift 3.x Release Signing Key<EMAIL_ADDRESS>imported
gpg: key EF5430F071E1B235: public key "Swift 4.x Release Signing Key<EMAIL_ADDRESS>imported
gpg: key 7638F1FB2B2B08C4: public key "Swift Automatic Signing Key #2<EMAIL_ADDRESS>imported
gpg: key 925CC1CCED3D1561: public key "Swift 5.x Release Signing Key<EMAIL_ADDRESS>imported
gpg: key FAF6989E1BC16FEA: public key "Swift Automatic Signing Key #3<EMAIL_ADDRESS>imported
gpg: key 925CC1CCED3D1561: "Swift 5.x Release Signing Key<EMAIL_ADDRESS>1 new signature
gpg: Total number processed: 8
gpg:               imported: 7
gpg:         new signatures: 1
/usr/bin/gpg --keyserver hkp://pool.sks-keyservers.net --refresh-keys Swift
gpg: refreshing 7 keys from hkp://pool.sks-keyservers.net
gpg: key FAF6989E1BC16FEA: "Swift Automatic Signing Key #3<EMAIL_ADDRESS>not changed
gpg: key 925CC1CCED3D1561: "Swift 5.x Release Signing Key<EMAIL_ADDRESS>not changed
gpg: key 7638F1FB2B2B08C4: "Swift Automatic Signing Key #2<EMAIL_ADDRESS>not changed
gpg: key EF5430F071E1B235: "Swift 4.x Release Signing Key<EMAIL_ADDRESS>not changed
gpg: key 63BC1CFE91D306C6: "Swift 3.x Release Signing Key<EMAIL_ADDRESS>not changed
gpg: key 9F597F4D21A56D5F: "Swift 2.2 Release Signing Key<EMAIL_ADDRESS>not changed
gpg: key D441C977412B37AD: "Swift Automatic Signing Key #1<EMAIL_ADDRESS>not changed
gpg: Total number processed: 7
gpg:              unchanged: 7
Error: Unexpected error, unable to continue. Please report at https://github.com/fwal/setup-swift/issues
Unexpected HTTP response: 404
Stacktrace:
Error: Unexpected HTTP response: 404
    at /home/runner/work/_actions/fwal/setup-swift/v1/dist/index.js:8816:25
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/fwal/setup-swift/v1/dist/index.js:8721:58)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

The "Swift 5.1 on ubuntu-latest" job failed with the same error.
The "Swift 5.1 on macos-latest" and "Swift 5.2 on macos-latest" jobs also failed, although the cause of the failures may be unrelated to this action because they occurred in the "Build" step. Nevertheless, I would appreciate any help in determining the cause of the failures.
I have uploaded a zip file of the full logs on Google Drive.
Summary

Edit
I just tested the following jobs:
jobs:
  test_macOS:
    runs-on: macos-latest

    steps:
    - uses: actions/checkout@v2
    - name: Build
      run: swift build
    - name: Run tests
      run: swift test

  test_linux:
    strategy:
      matrix:
        image: ["swift:5.0", "swift:5.1", "swift:5.2", "swift:5.3", "swift:5.4"]
    runs-on: ubuntu-latest
    container: ${{ matrix.image }}

    steps:
    - uses: actions/checkout@v2
    - name: Build
      run: swift build
    - name: Run tests
      run: swift test

All of these competed successfully, proving that my library does compile for Swift 5.0-5.4 on Linux and swift 5.3 on macOS.

This seems to be the same problem as #196. Basically the linux version is incompatible with the swift version.
The reason it works in the second example is that it then is bundled with the correct linux version in the container.

Is there anything I can do to make it work? I'm not sure what the best way is to test on different versions of Swift for macOS.

I would only need to use this library for macOS because I can use docker for Linux.

@Peter-Schorn Hi! I've released some updates recently that hopefully helps resolving this, please check it out and feel free to reopen this issue if you continue to experience problems.


Move Apache and Chrome to packages/cached containers

Takes a while to install, we probably can move them too (like pwntools, chroot, nsjail, etc)

@sroettger wdyt? this is an old issue, but for can we easily detect when we only made changes that wouldn't affect the samples? I don't know if this will really help (do we make a lot of changes here?)
or can we cache other steps?

For testing or production? For the latter, we should try to recreate the images everytime. I.e. if I make a challenge that ships Chrome, I want to use the latest version from apt-get.

ok, then closing this. (it was for prod)

ok, then closing this. (it was for prod)


Made code slightly less bloat(🚀).

Because I added some Rust(🚀) code, this now is faster, statically-typed, no-runtime, compiled and all that good sh*t unlike JS (totally a fair comparison).

Appreciate the PR but I don't think this is correct. thirteen          is not thirteen because it has extra spaces at the end. But trim_end() would remove the extra spaces and return true when it should be false. 🚀


rename connection pool configuration

Rename pool configuration type and property to ConnectionPool
Motivation:
HTTPConfiguration.poolConfiguration is redundant and does not make clear what pool are we talking about.
Modifications:
Rename property and type to ConnectionPool
Result:
Closes #286

Error:
ERROR:  Error installing jazzy:
	cocoapods-downloader requires Ruby version >= 2.3.3.

@swift-server-bot test this please

Same error in 5.1, @tomerd could you help with that?

@artemredkin I think we can do something like https://github.com/apple/swift-nio-ssl/pull/234/


Added isUpperCase/isLowerCase to String/CharSequence

Check List:

Fixes #1106
Unit tests : YES
Javadoc with a code example (API only) : YES

Thanks for the pull request 👍
I think we should define what happens in edge cases.
With the current implementation of the pull request these assertions all pass:
assertThat("").isUpperCase();
assertThat(" ").isUpperCase();
assertThat(".").isUpperCase();
assertThat("7").isUpperCase();
assertThat("A.7").isUpperCase();

assertThat("").isLowerCase();
assertThat(" ").isLowerCase();
assertThat(".").isLowerCase();
assertThat("7").isLowerCase();
assertThat("a.7").isLowerCase();

While these existing character assertions all fail:
assertThat(' ').isUpperCase();
assertThat('.').isUpperCase();
assertThat('7').isUpperCase();

assertThat(' ').isLowerCase();
assertThat('.').isLowerCase();
assertThat('7').isLowerCase();

Good points @PascalSchumacher!
My implementation is quite simple using standard JDK toUpperCase()/toLowerCase() methods to compare. Maybe we should refine some edge cases indeed.

We should add all the edge cases in the javadoc code examples and states that it follows JDK toUpperCase()/`toLowerCase() so that it is crystal clear what the beahvior of the assertion is.
Thanks for the PR.


Enable signature verification for MDQ

Add functionality to allow configuration of signature verification for
metadata obtained using the MDQ protocol. Support is limited to checking
the signature of a response containing a single entity and not multiple
entities.

LGTM

I'd love to see this merged in.  Checking an MDQ's cert is the last piece I need in place for authorizing webapps against a federation mdq.

What is keeping us from merging this?

I rebased to today's master.

Codecov Report

Merging #483 into master will decrease coverage by 0.03%.
The diff coverage is 35.29%.

@@            Coverage Diff            @@
##           master    #483      +/-   ##
=========================================
- Coverage   65.63%   65.6%   -0.04%
=========================================
  Files         103     103
  Lines       25603   25616      +13
=========================================
  Hits        16805   16805
- Misses       8798    8811      +13

Impacted Files
Coverage Δ

src/saml2/mdstore.py
74.01% <35.29%> (-0.73%)
:arrow_down:

src/saml2/validate.py
74.5% <0%> (-1.97%)
:arrow_down:

src/saml2/__init__.py
86.52% <0%> (+0.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d7414...9073a89. Read the comment docs.


Fatal deployment error

When deploying to staging/production, occasionally a site will throw an authorization error during the deploy:update_code task which can be resolved by a lando rebuild, but shouldn't occur in the first place. A site may deploy just fine but when you come back to it a couple days later (without touching it aside from lando stop or lando poweroff) the deployment can throw said authorization error.
This is approximately the contents of the error:
Cloning into '[filepath]/releases/[#]'...
Unauthorized
fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

[Symfony\Component\Process\Exception\ProcessFailedException]

Exit Code: 128(Invalid exit argument)

Working directory: /app

Output:
==================

Error Output:
==================

[bitbucket repo]

error at this same point may also throw Permission denied (publickey). (instead of Unauthorized)
[possibly specific to github repos]


Side panel tab tooltip doesn't work

Open the toolbox
Select the Style Editor panel and Media Rules side panel
Hover mouse over the side panel tab
There should be a tooltip displayed (just like for a main panel), but none is visible -> BUG

Honza

(just reassigning anurag90x is now FWG member)
Honza

\o/
Florent

$fixed firebug-3.0.0-alpha.7


[Feature] Fetch Proxy Address from ProxySelector or System Properties

Motivation:
We can get SOCKS / HTTP Proxy Host and Port from socksProxyHost and socksProxyPort / http.proxyHost and http.proxyPort or ProxySelector#getDefault.
https://docs.oracle.com/javase/8/docs/technotes/guides/net/proxies.html
Modification:
Fetch Host and Port from socksProxyHost and socksProxyPort / http.proxyHost and http.proxyPort using SystemPropertyUtil or ProxySelector#getDefault.
Result:
Fixes #10534.

Looks good, but the ProxyHandlers seem to be not called anywhere. To emulate proxy behavior from other client libraries, they probably have to be called somewhere after call to initChannel.
Also I would add tests to show it actually works. You can create SOCKS proxy server for example with TestContainers library using kallqvist/microsocks Docker image.

@hyperxpro HttpProxyHandler can be used for http and https. How do you decide which one http.proxy... or https.proxy... setting to use?

@hyperxpro HttpProxyHandler can be used for http and https. How do you decide which one http.proxy... or https.proxy... setting to use?

Valid point. How about adding boolean for http or https?

@hyperxpro I was also thinking: Is the requirement only to support port and host or also nonProxyHosts?

@violetagg Only Host and Port. nonProxyHosts is something that is out of context for now.

@hyperxpro the point is that by default nonProxyHosts has this default value http.nonProxyHosts (default: localhost|127.*|[::1])
https://docs.oracle.com/javase/8/docs/api/java/net/doc-files/net-properties.html
so this one ProxySelector.getDefault().select(URI.create("http://localhost:1")); I think will always return DIRECT.
Wdyt?

@violetagg Yes, I'd. But the focus of this PR is to fetch System-wide Proxy configuration. If ProxySelector.getDefault().select(URI.create("http://localhost:1")); is not HTTP/HTTPS, we'll throw an exception.

Drive by review:
I'd question the API and approach of this PR.  Maybe worth bumping up to visibility @normanmaurer

By the point someone is configuring the ChannelPipeline explicitly with Socks4ProxyHandler or HttpProxyHandler, they presumably know what the proxy should be or can call it themselves.  If you want to simplify that job to use System properties, maybe a single utility method that reads system properties or a snapshot of ProxySelector and returns a fixed ProxyHandler based on the environment.

Failing at runtime because you require the client configuring the channel pipeline to know the type of configured proxy seems counter the the point of the PR

if (proxy.type() != Proxy.Type.SOCKS) {
                throw new IllegalArgumentException("Expected Default Proxy Type: SOCKS, Got: " + proxy.type());
}

For Socks, can't it still use http:// in the URL it queries rather than socket?

The result of ProxySelector.getDefault().select(URI.create("http://localhost:1")) isn't guaranteed to be static is it? Even for a single host it could change based on the implementation, or the passed in URL.  localhost is also a questionable choice here, since it's probably the most likely to be direct.

See https://stackoverflow.com/a/63188956/1542667 for example

This is a complicated space with poor APIs (ProxySelector is the worst API in the JDK).  Maybe a better alternative is pointing users at using https://github.com/MarkusBernhardt/proxy-vole, which solves this on various platforms.

@yschimke Yeah, Even I agree. Although a default configuration would help and make things a lot easy when changing addresses of the Proxy server but it creates lots of confusion and mess. I have been thinking a lot but couldn't find any solution.
Maybe we should leave implementation as it is?

I don't think it's good for Netty to pickup something like the default environmental proxies from the host.  But as a feature something like the following that worked for HTTP, SOCKS4 or SOCKS5 proxies based on system properties and default proxies would probably be useful opt-in.
p.addLast(new SystemDefaultProxyHandler());

Makes sense. I will leave it as it is. Closing PR.

Damn, I didn't mean to discourage you from improving this area.  More about the approach you had taken and how you could provide higher value by hiding more complexity from whoever is configuring the channelpipeline.  Sorry.

Damn, I didn't mean to discourage you from improving this area. More about the approach you had taken and how you could provide higher value by hiding more complexity from whoever is configuring the channelpipeline. Sorry.

Man, no no! I understand your point and appreciate your suggestions. Thanks a lot!
I'm thinking about this in different ways to address the issue in a better way now.
@normanmaurer WDYT? Having a system-wide configuration auto applied is good but ProxySelector is a little odd IMO. Drop your suggestions If you've any.

It's super weird for me to have a magical handler that appears on some pipelines, based on whether there is an HTTP or HTTP+SSL handler already in the pipeline (or added at the same time as the HTTP handler?) (and operating or not based on whether there is no other proxy already configured).
I'd definitely be more inclined to support an explicitly added ChannelInitializer that adds an appropriate proxy handler based on existence of the environment settings, a la SystemDefaultProxyHandler()


Docs-update-next-steps

Description
Backlog task to check all "Next steps" in Install docs. Note that OpenStack docs have not been reviewed in ages so I would need more time/context to derive next steps; skipping for now.

These updates are OS specific (because OS requires calicoctl and Enterprise does not)
Merge to nightly

Deploy preview for calico ready!
Built with commit cad5142d38407e797bf71feb5486201f996b20a3
https://deploy-preview-3625--calico.netlify.app


Gradle 6.0 Tries To Retrieve pom for artifacts that it didn't previously

Tested both in Gradle 5.6.4 and Gradle 6.0.
Historically my project has had a dependency along the lines of:
implementation 'OpenXML:DocumentFormat.OpenXML:2.5@dll'
Because the extension is provided it doesn't try to read a pom from the repository and just grabs the artifact. After upgrading to Gradle 6.0 this behavior appears to have changed. Now the pom is attempted to be found and since there is no pom for this artifact the task fails.
Expected Behavior
No attempt to access pom for artifact
Current Behavior
Pom is being searched for for the artifact.
Context
Initialized native services in: C:\Users\kcarter\.gradle\native
The client will now receive all logging from the daemon (pid: 36320). The daemon log file: C:\Users\kcarter\.gradle\daemon\6.0\daemon-36320.out.log
Starting 5th build in daemon [uptime: 10 mins 18.056 secs, performance: 98%, GC rate: 0.01/s, heap usage: 8% of 358.1 MB, non-heap usage: 34% of 268.4 MB]
Using 8 worker leases.
Starting Build
Settings evaluated using settings file 'C:\Source\documents\settings.gradle'.
Projects loaded. Root project using build file 'C:\Source\documents\build.gradle'.
Included projects: [root project 'documents']

> Configure project :
Evaluating root project 'documents' using build file 'C:\Source\documents\build.gradle'.
Apply OSS Index Plugin
Applying dependency management to configuration 'bootArchives' in project 'documents'
Applying dependency management to configuration 'spotbugsPlugins' in project 'documents'
Applying dependency management to configuration 'spotbugs' in project 'documents'
Applying dependency management to configuration 'archives' in project 'documents'
Applying dependency management to configuration 'default' in project 'documents'
Applying dependency management to configuration 'compile' in project 'documents'
Applying dependency management to configuration 'implementation' in project 'documents'
Applying dependency management to configuration 'runtime' in project 'documents'
Applying dependency management to configuration 'compileOnly' in project 'documents'
Applying dependency management to configuration 'compileClasspath' in project 'documents'
Applying dependency management to configuration 'annotationProcessor' in project 'documents'
Applying dependency management to configuration 'runtimeOnly' in project 'documents'
Applying dependency management to configuration 'runtimeClasspath' in project 'documents'
Applying dependency management to configuration 'testCompile' in project 'documents'
Applying dependency management to configuration 'testImplementation' in project 'documents'
Applying dependency management to configuration 'testRuntime' in project 'documents'
Applying dependency management to configuration 'testCompileOnly' in project 'documents'
Applying dependency management to configuration 'testCompileClasspath' in project 'documents'
Applying dependency management to configuration 'testAnnotationProcessor' in project 'documents'
Applying dependency management to configuration 'testRuntimeOnly' in project 'documents'
Applying dependency management to configuration 'testRuntimeClasspath' in project 'documents'
Applying dependency management to configuration 'apiElements' in project 'documents'
Applying dependency management to configuration 'runtimeElements' in project 'documents'
Applying dependency management to configuration 'api' in project 'documents'
Applying dependency management to configuration 'jacocoAgent' in project 'documents'
Applying dependency management to configuration 'jacocoAnt' in project 'documents'
Applying dependency management to configuration 'checkstyle' in project 'documents'
Applying dependency management to configuration 'pmd' in project 'documents'
Applying dependency management to configuration 'docstamper' in project 'documents'
Resolving global dependency management for project 'documents'
Resource missing. [HTTP GET: https://labs.mastercontrol.com/artifactory/repo/com/mastercontrol/docstamper/OOXMLStamper/1.0.1/OOXMLStamper-1.0.1.pom]
Resource missing. [HTTP GET: https://labs.mastercontrol.com/artifactory/repo/NewtonSoft/NewtonSoft.Json/7.0.1/NewtonSoft.Json-7.0.1.pom]
Excluding []
Closing Git repo: C:\Source\documents\.git

FAILURE: Build failed with an exception.

* Where:
Build file 'C:\Source\documents\build.gradle' line: 93

* What went wrong:
A problem occurred evaluating root project 'documents'.
> Could not resolve all files for configuration ':docstamper'.
   > Could not find com.mastercontrol.docstamper:OOXMLStamper:1.0.1.
     Required by:
         project :
   > Could not find NewtonSoft:NewtonSoft.Json:7.0.1.
     Required by:
         project :

* Try:
Run with --stacktrace option to get the stack trace. Run with --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.0/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 5s

Steps to Reproduce
Have a repository that hosts an artifact that doesn't have a pom and specify the extension of the item being targeted.
Your Environment

Build scan URL:

I think this is related to this upgrade note: https://docs.gradle.org/current/userguide/upgrading_version_5.html#maven_or_ivy_repositories_are_no_longer_queried_for_artifacts_without_metadata_by_default
Before 6.0, Gradle would locate artifacts without metadata by default.
Could you try changing your repository declaration to something like:
repositories {
    maven {
        // your repo URL
        url "http://repo.mycompany.com/repo"
        metadataSources {
            mavenPom()
            artifact()
        }
    }
}

Yeah. That totally solved it. We can likely close this in favor of the existing issue. Thank you for the quick response.

@kylec32  note: In the described use case, in Gradle 5, we would also first check if the pom exists despite of the @ notation.
If your repository does not contain POMs at all, the better solution now is
repositories {
    maven {
        url "http://repo.mycompany.com/repo"
        metadataSources {
            artifact()
        }
    }
}

Then we won't check for the POMs at all and you will save network requests.


Suggestion about linux implementation

Hey! Great work on this, super excited to try DeskGap on a personal project.
Perhaps you could find some ideas on how to add linux from this project: https://github.com/zserge/webview

This project looks interesting. I'll look into it. Thank you!

Any rough timelines for linux ..

@navinSing Linux support has arrived.

Super
On Sun 24 Feb, 2019, 10:40 PM Chi Wang<EMAIL_ADDRESS>wrote:

@navinSing https://github.com/navinSing Linux support has arrived.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/patr0nus/DeskGap/issues/7#issuecomment-466795456, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACV8O_6xzoLE7ISVj2NkZgddkAKsEwJXks5vQseNgaJpZM4a8gCq
.

Awesome stuff @patr0nus


Feature/add prompts to story

Description: This branch adds additional functionality to Pull Request #76
            namely, it adds an additional function to storyNewModel.js to return both "episode prompts" (Drawing & Writing) without needing 2 functions. Episode prompts are then attached to each episode object  for a given story id. this adds additional information to the return object from the

Fixes #76

What work was done?
new function created in the model (getPromptsByEpisodeID)
two, now redundant functions were removed from model (getDrawingByEpisodeID, getWritingByEpisodeID)
storyNewRouter.js edited to make GET(/episodes/:eid) endpoint use getPromptsByEpisodeID function
improperly scoped "i" variable fixed in getByID model function (storyNewModel.js)
Why was this work done?
this work returns a more robust object and removes the need to hit multiple endpoints to get all of the "story" data for a given ID
What feature / user story is it for?
https://trello.com/c/s4cxfDGf/494-add-story-prompts-to-episodes-and-return-from-the-story-id-endpoint
Any relevant links or images / screenshots
https://www.loom.com/share/664360d726e1441492a297276e8c6fff

Type of change

[X] New feature (non-breaking change which adds functionality)

Change Status

[ ] Complete, tested, ready to review and merge
[ X] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

Has This Been Tested

[X] No

Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] My code has been reviewed by at least one peer
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[X] There are no merge conflicts

Everything looks great! Very clean code too.


Tmp master

@daneshk / @thusithathilina : I believe this is a temporary PR and should not be merged. Shall we close this PR or move this to a temporary branch?

@Niranjan-K Yes this is a temp PR which can be used to continue the work which I did. We can close the PR


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
e0e39bcb3827c6edd58c12dac56a0699bfe243cc
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


 This PR includes them into the repo

Deploy preview for gestalt ready!
Built with commit f0bc5b1a66804974b4a86428fdd4e9fe89488727
https://deploy-preview-151--gestalt.netlify.com


Issue with findByName function with iframes

I'm not entirely sure how I can explain this problem, but I'll do my best.  I am currently using an iframe (both on the same domain), and from inside the iframe, I'm calling the validation script on a from resting inside jquery ui dialog outside the iframe.  I assume that my issue arose because of the inside to outside the iframe jumping, but perhaps that's not really the problem.
It is important to note, that all of the validation functions that I have tested work perfectly EXCEPT remote.  It throws a js error that "element" is undefined.  I tracked this error back to the findByName function.  I was able to solve the problem by making a  change to the findByName function to the following:
findByName: function( name ) {
// select by name and filter by form for performance over form.find("[name=...]")
var form = this.currentForm;
return $(form).find("[name='" + name + "']");
},
I realize that you used map because of a performance enchancement; however, the document.getElementsByName(name) is returning null.  I assume this is because document is referring to the code inside the iframe where this.currentForm is referring to the location of the actual form (outside the iframe).

It seems like by now that optimization is causing more trouble then its worth. If someone still needs to support slow browsers like IE6/7, they shouldn't build up forms without thousands of elements...
Here's another issue related to the same function, suggesting a slightly different solution: https://github.com/jzaefferer/jquery-validation/issues/275
Could you give that a try, see if it also addresses your issue?

Sorry I haven't yet had a chance to implement that fix, but it looks like it's pretty much the same fix that I have, except that it would have better performance than my solution.  So, I don't see how it would cause any issues.
Is there any chance that this fix could get implemented into the next release?  I really just hate keeping a modified version of an external script ... makes updates so much more difficult.


CSS error when using academic theme

Cool that you like slidev-theme-academic and thanks for bringing up this issue!


Branch testing workflow

🗒 Summary
Merge this to add a branch testing workflow.
⚙ Test Data and/or Report
See the sandbox action run that uses the same workflow.
♻ Related Issues

devops#62

Thanks @jordanpadams!


feature(prompt): Added a new prompt asking for scope

This feature has been requested by #264

@izifortune — Awesome, thank you, Fabrizio! 🏆

Released as v12.4.0 👍


C binding: wasi std out to string

Feature
Rust library can bind WritePipe to WasiCtx stdout which can be far simpler and effective than OS files went dealing with multiple short-lived instances.
It is not currently possible with C/C++ bindings
Benefit

Avoid useless error-prone and slow interactions by filesystem
Allow simpler integration in freestanding targets

Implementation
Leverage existing wasi_common::pipe::WritePipe and ReadPipe on the rust side to implemented a binding in c-api crate.
Alternatives
Export some basic filesystem operations in c binding

+1 for this feature.
When embedding Wasmtime in C (or C++), and enabling WASI extensions for a Wasm module, there is no way to capture stdout into a string. The only alternative seems to use [wasi.h]wasi_config_set_stdout_file(), which brings many other drawbacks (ie: no buffering, slow down, etc.)

Is this the blocker issue for https://github.com/bytecodealliance/wasmtime-go/issues/34 and https://github.com/bytecodealliance/wasmtime-py/issues/34? (cc @alexcrichton)
I would love to switch to wasmtime for my projects but this is preventing me from doing so.
We also need the ability to set a string for stdin as well. I'm not sure if there is a separate issue for that.


Dio error - Not getting the env variables (ApiKey and Base URL)

It's a great-looking app, and using Riverpod is amazing.
I tried to follow the instructions and added the .env file in the project's root. However, I get the following dio errors.
flutter: *** DioException ***:
flutter: uri: movie/now_playing?page=1&api_key=
flutter: DioException [unknown]: null
Error: Invalid argument(s): No host specified in URI movie/now_playing?page=1&api_key=

I even tried making a copy of the .env file in the lib folder, but that did not work. (I promise to try and debug this, but I thought it's best to let you know, too).
One more thing I noticed: app_env.dart is an empty file.

A dirty hack (I don't think that is what you intended) I tried is in the file dio_network_service.dart
@override
  String get baseUrl =>
      dotenv.env[NetworkEnv.BASE_URL.name] ?? 'https://api.themoviedb.org/3/';

  @override
  String get apiKey =>
      dotenv.env[NetworkEnv.API_KEY.name] ?? 'myApiKey';

Hi @vnl please refer to https://github.com/Iamzaryab/Movie-Application-Flutter-Clean-Architecture-RiverPod#getting-started
so basically steps are simple
1.Create a .env file in root directory
2.https://www.themoviedb.org/settings/api create an API from this website
3. BASE_URL=https://api.themoviedb.org/3/
4.API_KEY=PASTE_YOUR_API_KEY
that's it project will start working as expected

@Iamzaryab, sorry, I think I did not communicate it properly. If you see the first post, I have the .env file in the root with the BASE_URL and API_KEY.
Only for the screenshot I change the API key, of course. With that in place, it does not work.
Have I missed something?

@vnl did you tried to run
flutter pub run build_runner build --delete-conflicting-outputs
is it still now working ?

@vnl i checked again on my side code is working fine If you have still facing an issue I can check your code or you can contact me my LinkedIn https://www.linkedin.com/in/zaryab-shakir-035b58171/

@vnl did you tried to run flutter pub run build_runner build --delete-conflicting-outputs is it still not working ?

I did this @Iamzaryab
I followed the instructions exactly:
Git cloned, created a new .env file and added the 2 variables, flutter pub get to get dependencies and finally ran the command "flutter pub run build_runner build --delete-conflicting-outputs"
I get the above error. So there is no code change I promise.

@Iamzaryab I am sorry this is an oversight from me. I was able to solve it. As I mentioned, I followed your instructions a little too well.
I had (from the screenshots you can see), named my variables from the instructions:
BASEURL=https://api.themoviedb.org/3/
APIKEY=ADD YOUR API KEY

However, the variables you are loading using dotenv is BASE_URL and API_KEY - the underscore was the issue :) COuld you change that in the read, please?


1ES pipeline template conversion

Summary
These changes convert the pipelines/stages/jobs/steps to be able to leverage the 1ES Pipeline Templates in the internal project; the public project builds largely remain unaffected by the change at this time. Changes have been made to minimize the differences between internal project and public project builds so that as much code sharing can be used as is reasonable. Optimizations have not been performed on the internal project builds at this time (e.g. possibly removing compliance, cg, codql pipelines, or using 1ES PT outputs instead of manually uploading artifacts).
Summary of changes:

Refactored PublishBuildArtifacts and PublishPipelineArtifact tasks into build steps that can be toggled between the standard tasks and their 1ES equivalent. This allows sharing between internal project and public project builds.
Updated jobs to take is1ESPipeline and commonTemplatesFolderName parameters to switch between standard pipeline fuctionality and 1ES equivalents.
Implemented pipeline templates under /eng/pipelines/templates that wrap the 1ES pipeline template. This allows providing a common template (pipeline-template.yml) for all of the pipelines to use that can switch between standard pipeline functionality (pipeline-template-legacy.yml) and the 1ES pipeline template (pipeline-template-1es.yml) as well as provide common resources (e.g. all of the container definitions). The legacy template provides as much functionality that the 1ES template does to preserve the existing capabilities of the public project builds.
Removed all Windows pool specifications and apply them at the pipeline level. These are passed to the pipeline template and applied to each stage when the template is expanded.
Logs publishing is disabled for internal project builds since Arcade has not updated that functionality to conform to 1ES pipeline templates at this time.

Most of the credit for this initial conversion goes to @schmittjoseph; I mostly worked on bridging the internal project and public project build functionality.

Release Notes Entry

/backport to release/8.0


Android is unable to build

I got error like the following image:

I don't know is it about the flutter version or not but I solved it by modifying the flutter_curl/android/build.gradle file with:

add 'namespace'
update 'minSdkVersion' from 16 to 21

the reason I changed the 'minSdkVersion' because I had got a warning with some error about deprecated sdk api
Currently I have to do modify the flutter_curl/android/build.gradle file manually after 'flutter pub add flutter_curl'
Do you have  the better solution ?

Sorry missed this.
I have done the necessary changes in the master. Possible to try it? You can use the latest master commit like below in pubpsec.
flutter_curl:
    git:
      url: https://github.com/ajinasokan/flutter_curl
      ref: 2771b30608d83c0ca53e66ab5693ac159a121904


Nodes disappear during renaming of the project

Discord username
No response
What type of issue is this?
Permanent – Occurring repeatably
Is this issue blocking you from using Enso?

[ ] Yes, I can't use Enso because of this issue.

Is this a regression?

[ ] Yes, previous version of Enso did not have this issue.

What issue are you facing?
During renaming of the project the last edited node will disappear.
Expected behaviour
Nodes must not be modified during renaming.
How we can reproduce it?
No response
Screenshots or screencasts
Kazam_screencast_00002.webm
Apologies for the fragment of the screen only; something is weird with my resolution when recording. But you can see see the node disappearing.
Enso Version
develop
Browser or standalone distribution
Standalone distribution
Browser Version or standalone distribution
standalone
Operating System
Linux
Operating System Version
No response
Hardware you are using
No response

It's funny, it disappears because you had it selected and pressed Backspace, which is a shortcut for node deletion. The easy fix would be to unselect nodes when starting editing the project name (I believe we already unselect everything when the node is edited)

It's funny, it disappears because you had it selected and pressed Backspace, which is a shortcut for node deletion. The easy fix would be to unselect nodes when starting editing the project name (I believe we already unselect everything when the node is edited)

:)
I would expect the focus to switch to the thing that I'm editing i.e. name of the project.

@hubertp that's right, that's a bug on our end, but at least we know the cause of it now :)


Slideshow runs in wrong resolution.

When launching slides with manim-slides command the opened window has the wrong resolution. It is  off the screen tall and skinny. This issue is not present when launching with full screen tag.

Hi @Dinoboychris , many thanks for spotting the bug and creating this issue!
#12 will solve this problem, and I will release this fix in v3.2.4 very soon


Added support for custom time intervals

This is useful for instant noodles, or very particular tea drinkers.

Also I've never written shell script before, so this code might be awful. I'll happily accept improvement suggestions!

Merged. I would advise that you shouldn't really need a space between -t <seconds> but it works, so it's included, and it'll save me editing the script every bloody time I want to check it's  working!
Thanks.


I get this error tryed to fix it but does not work

recipe.preproc.macros pattern is missing
Error compiling for board NodeMCU 1.0 (ESP-12E Module).

FIX: Reinstall Arduino and delete all files


Happiness ('s Unit of Measurement) by Busdriver unsupported.

Check if issue with swaglyrics or whether song lyrics unavailable on Genius.

stripper -> Busdriver-Happiness

added


Update gene references in schema - human gencode 38 and mouse gencode 27

Updates links to the reference gene files. New versions: human gencode 38 and mouse gencode 27
Addresses the schema component of this:
https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/chanzuckerberg/single-cell-data-portal/1404

@brianraymor your comments have been addressed


Background color not updating after changing wallpaper and loading wal

When updating the colorscheme with pywal, the st background doesn't get updated. Shell colors change fine, but not the st background. I suspect it's sequence related (where wal uses a color code for backgrounds the st terminal doesn't).
I've tried hacking st in a few places, googling, but nothing's really conclusive. Hoping more eyes will see this and make this bug shallow.
Possibly related issues/regressions: #142
Screenshot of problem in action:

This has been fixed


Trailing slashes

Is there any way to make from URLs match with an optional trailing slash?
Currently if I set '/old' to redirect to '/new' it won't match a request for '/old/'.
Currently I'm adding both versions of the path but am wondering if this could be done more succinctly.

Hey Rob!
We've addressed this in the latest release - hopefully that's okay!
Cheers,


Checkpoint 3

Changes Unknown when pulling 339b6812e51bb560a98506bc82046db004002cc9 on develop into ** on master**.

Changes Unknown when pulling 84ca4f597915e969bbc734beb7262271b4079177 on develop into ** on master**.

Changes Unknown when pulling 258a4b4eee37fbf757ff951db03771492f6c8a49 on develop into ** on master**.

Changes Unknown when pulling 1491d594ae3968a67e25c3658817619c685a7dcb on develop into ** on master**.

Changes Unknown when pulling 32bb22711b006809661acdd6e262dd1cf79f1f92 on develop into ** on master**.

Changes Unknown when pulling d2a913c5f227051b731d40275b1db66b19ab5f9a on develop into ** on master**.

Changes Unknown when pulling b31b53d2a8f827e6a3b10b1e9a40414436ad84cb on develop into ** on master**.

Changes Unknown when pulling c377bbefe60db56a43c1d52adbbb20da401bef49 on develop into ** on master**.

Changes Unknown when pulling 655a682b005748f06dd456953c3f19e71bbbc821 on develop into ** on master**.


Consider using bindgen for gdal-sys

What the title says. This might make adding the missing APIs easier, but will probably require a large rework of the crate.
Do you think it might be a good idea?
I'm not necessarily volunteering to implement this 😄 .

This would be great!
If you succeed in generating bindings with bindgen let me know how you did it ;)


Ensure Polymer 3 Modulizer compatibility

Fixes #23

This change is

Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

demo/advanced-demos.html, line 29 at r1 (raw file):

    customElements.define(AdvancedDemos.is, AdvancedDemos);
  </script>
</dom-module>

nit: use VSCode settings"files.insertFinalNewline": true to prevent Reviewable and GitHub from showing those ugly red characters :)
https://eslint.org/docs/rules/eol-last

Comments from Reviewable

Currently the modulizer does not do anything with the Polymer.importHref so it appears to work in Chrome, under native HTML imports implementation. We will have to revise it in the future, though.
Not a blocker to me, if we don't expect demos to work in all browsers. Probably we will have to use import() later.

Reviewed 1 of 9 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

Refactored to use script tags for P3 compatibility and added the tests.

Review status: 5 of 17 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 3 of 9 files at r1, 2 of 3 files at r2, 12 of 12 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

package.json, line 25 at r3 (raw file):

    "gulp-modify": "latest",
    "gulp-concat": "latest",
    "polymer-cli": "^1.2.0"

Maybe remove polymer-cli from the devDeps, as advised in the “General steps”?

demo/all-imports.html, line 2 at r3 (raw file):

<link rel="import" href="basic-demos.html">
<link rel="import" href="advanced-demos.html">

Having to make this in every element would be annoying.
Let me enable conversion for demos on the magi side instead.

Comments from Reviewable

Review status: 10 of 19 files reviewed at latest revision, 2 unresolved discussions.

package.json, line 25 at r3 (raw file):
Previously, platosha (Anton Platonov) wrote…
Maybe remove polymer-cli from the devDeps, as advised in the “General steps”?

The whole "devDependencies" section is not needed here, actually. Done.

demo/advanced-demos.html, line 29 at r1 (raw file):
Previously, limonte (Limon Monte) wrote…
nit: use VSCode settings"files.insertFinalNewline": true to prevent Reviewable and GitHub from showing those ugly red characters :)
https://eslint.org/docs/rules/eol-last

Done.

demo/all-imports.html, line 2 at r3 (raw file):
Previously, platosha (Anton Platonov) wrote…
Having to make this in every element would be annoying.
Let me enable conversion for demos on the magi side instead.

Removed.

Comments from Reviewable

Waiting for the new magi-cli in order to verify that demo conversion works, and then should be ready to go.

Review status: 10 of 19 files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Reviewed 1 of 3 files at r2, 8 of 12 files at r4.
Review status: 17 of 19 files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Reviewed 1 of 9 files at r1, 1 of 12 files at r3, 5 of 12 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Dilato: IE only: Core: There are two loading icons when clicking on 'Continue' button in SUSI page

Problem:
There are two loading icons when clicking on 'Continue' button in SUSI page
Steps:

Launch https://graduation.stage.adobe.com/
Click Getting Started button
Click Continue button
Input a T2 or T3 account
Then click on 'Continue' button and observe
Actual result:
There are two loading icons when clicking on 'Continue' button in SUSI page
Expected result:
There displayed one loading icon when clicking on 'Continue' button in SUSI page

@iost, thanks for the report. Unfortunately, I cannot access the link you've provided (Access denied), and I don't have any T2/T3 account logins.
Can you please indicate the exact markup you're using here and the version of Spectrum CSS that's running? Or even better, create a codepen based on this template that reproduces the issue: https://codepen.io/pen?template=zMyYEO
I tried to reproduce this issue on our docs at http://opensource.adobe.com/spectrum-css/2.13.0/docs/#circle-loader---indeterminate, but it works fine in IE 11.
If you can screen grab a video and let me know what markup/Spectrum CSS versioned is being used, that would be very helpful.

Closing this since we couldn't reproduce and are dropping support for IE11.


Publishing latest changes in KV protocol

This swagger update contains several updates in the KV service protocol V20161001:

adding support for recoverable deletion ("soft-delete") of KeyVault entities (vaults and in-vault objects)
adding support for backing up/restoring KeyVault secrets
exposing support for additional JWK signature algorithms

@dragav,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

I agree on the redundancy of 'summary' and 'description'; in some cases, it's downright painful to come up with a description that is comprehensively more detailed than the summary. However, some of these changes are passed on to me via our docs team, and my understanding is that both fields are needed for a proper documentation to be generated.
Thanks for reviewing.

@dragav -- Hmm. I was under the impression that description is "really required" and summary is "kinda required". I'll chat with Brady when I see him next.

 https://github.com/Azure/azure-sdk-for-python/pull/1165

No modification for NodeJS

 https://github.com/Azure/azure-sdk-for-ruby/pull/777

Would it be possible to let this through? I'm sure we can address any minor comment- or documentation-related issue in a subsequent revision. Thanks.


HL-194 - fixes for terms approval.

Add fixture for default terms (applicant terms and the terms of
service).
Load fixtures on deployment.
Add ordering field to ApplicantConsent.
Add permission checks

Description :sparkles:
Issues :bug:
HL-194
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #340 (65be9cd) into develop (13f18b3) will decrease coverage by 1.06%.
The diff coverage is 84.21%.

@@             Coverage Diff             @@
##           develop     #340      +/-   ##
===========================================
- Coverage    95.78%   94.71%   -1.07%
===========================================
  Files          184      136      -48
  Lines         6504     4924    -1580
===========================================
- Hits          6230     4664    -1566
+ Misses         274      260      -14

Impacted Files
Coverage Δ

backend/benefit/terms/api/v1/views.py
88.46% <66.66%> (-3.21%)
:arrow_down:

backend/benefit/users/utils.py
80.00% <66.66%> (-3.34%)
:arrow_down:

backend/benefit/users/api/v1/views.py
93.33% <85.71%> (-6.67%)
:arrow_down:

...s/migrations/0003_add_applicantconsent_ordering.py
100.00% <100.00%> (ø)

backend/benefit/terms/models.py
91.76% <100.00%> (+0.19%)
:arrow_up:

backend/shared/shared/audit_log/viewsets.py
46.96% <0.00%> (-43.94%)
:arrow_down:

backend/shared/shared/audit_log/audit_logging.py
79.54% <0.00%> (-18.19%)
:arrow_down:

backend/shared/shared/common/tests/conftest.py
84.61% <0.00%> (-15.39%)
:arrow_down:

backend/shared/shared/oidc/auth.py
84.61% <0.00%> (-1.10%)
:arrow_down:

backend/kesaseteli/kesaseteli/wsgi.py

... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f18b3...65be9cd. Read the comment docs.


✨  rename Frozen-Deps to Pinned-Dependencies

Please check if the PR fulfills these requirements

[] Tests for the changes have been added (for bug fixes / features)
[X] PR title follows the guidelines defined in  https://github.com/ossf/scorecard/blob/main/CONTRIBUTING.md#pr-process

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature

What is the current behavior? (You can also link to an open issue here)
name is frozen-deps

What is the new behavior (if this is a feature change)?
name is pinned-dependencies

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no

Other information:
I also fix https://github.com/ossf/scorecard/issues/741 along the way.
Put all file-related functions into new file fileutils.go

@naveensrinivasan how to I bypass the failing check? I've added empty files on purpose for unit tests.

@naveensrinivasan how to I bypass the failing check? I've added empty files on purpose for unit tests.
@inferno-chromium

I don’t understand, so you want to bypass the integration test check?
Why not actually fix the issue?
Can you please explain?

I've added empty files on purpose for unit tests.

I've added empty files on purpose for unit tests (need to verify that our checks work properly on empty files). The check is failing because it wants every file to contain a copyright notice.
Please advise. Thanks.


Use Hex Color Codes for ASCII art?

Current Neofetch version (7.0.0)
Trying to make my own "Distro" ASCII art. I have the art code done and matching your format for them. Curious if there is a way to plug in specific Hex Color Codes for it.
I tried to put hex colors directly into the:
set_colors 16 0 99 1 3 7             read -rd '' ascii_data <<'EOF'
section, in place of the "single" digit color numbers you had for all the others, but this just kinda shredded the ascii art and/or broke neofetch when done.
I tried random set_color numbers, 0-99, make install, neofetch over and over, and got a lot of colors close, but can't find some colors. Was curious what set_colors pulls from to where a small number stands for another color. Like is there somewhere I could force one distro to pull from another color pool? Or, how/where could I find a full list of available colors you are using, rather than trying a million random possibilities just tossing numbers in?
Thanks for your time,
catfood
*update: changing .Xresources colors or using dkeger presetups can take hex colors from their code/scripts and overwrite neofetch assci colors, but it applies to entire terminal, so end up with terminal font colors I'd rather not have to make distro font correct...

Color handling will be overhauled to accept escape sequences, etc. This issue will be handled then. :+1:

Note: ASCII logos shipped with neofetch will always be limited to the basic terminal palette to maintain compatibility with everything new and old. Users will be free to use escape sequences, etc to make use of the 256 palette and true color.

Thanks dylan. I slowly realized the I guess "dependency tree". All based on terminal limitations, was the limiting factor i did not understand. i will make dkeger Xresource themes that can keep the ascii art more true. Solvable on my end. I appreciate your script, please keep up the good work, regardless if people like my don't understand or question it...  Thanks, God bless you sir.
It was interesting to see the weird glitchy colors that came out of changing your color codes up to 999. It won't override a default X setting, but it could weirdly tweak to colors it should not allow in the range. Maybe someone can abuse this "bug" later to make more vibrant terminals :)

Going to close this in favor of the more recent #1699


the node's "downInternval" and "interval" values are not changing and stay on default values

Hi, I am trying to update the node's "downInternval" and "interval" while I'm adding it to the pool but those values are not changing and stay at default. This is the simple code I am testing. as you see I also tried updating these values after the node is created, but still no luck. Please advise. Thank you.
`from f5.bigip import ManagementRoot
mgmt = ManagementRoot('ip', 'user', 'pass')
pool = mgmt.tm.ltm.pools.pool.load(partition='Common', name='my-pool')
server_name = "my-server"
app_port = "440"
socket_name = f"{server_name}:{app_port}"
address = f"{server_name}.github.com"
fqdn = {"autopopulate": "enabled",
"downInternval": 6,
"interval": 300,
"tmName": address}
member_add = pool.members_s.members.create(
partition='Common',
name=socket_name,
fqdn=fqdn
)
node = mgmt.tm.ltm.nodes.node.load(partition='Common', name=server_name)
node.fqdn['downInterval'] = 10
node.fqdn['interval'] = 350
print (node.raw)`

hi @shariaty59 did you do a node.update() after setting the fqdn attributes? Setting them locally doesn't automatically update the object on BIG-IP, it just updates the local python object until you call the update() method.


It doesn't work on Chrome 124

"You have been blocked! If you are not a malicious actor, please update your web browser to the latest version to access this website. If the problem persists, please contact support."
This is pretty embarrassing. I am literally using the most up-to-date version of the most popular browser in the world.

In #95 I learnt there is some like _only white listed webbrowsers for https://kerkour.com _.


TypeError: (0 , _component.default) is not a function mock tests

💬 Questions and Help
Hi,
We are using the loadable/component function to load components but are having issues with the mocking tests and running into the following error:
TypeError: (0 , _component.default) is not a function
Within our test we have just created a mock like so
jest.mock('@loadable/component', () => ({
  loadable: jest.fn()
}));

Also tried
jest.mock('@loadable/component', () => {
  const original = jest.requireActual('@loadable/component');
  return {
    ...original,
    __esModule: true,
    default: () => {},
    loadableReady: callback => callback(),
  };
});

But this still errors.
Any ideas on how we can mock it?

what you want to do
what is the real error? Callstack is important.

Hi,
We basically need to update unit tests whereby we are using loadable and need to mock it.
The error is:
Test suite failed to run
TypeError: (0 , _component.default) is not a function

  18 |
> 19 | export const agreement = loadable(
     |                               ^
  20 |   () => import(/* webpackChunkName: "agreement" */ './agreement'),
  21 |   { fallback: <Spinner overlay="clear" alignCenter /> }
  22 | );

So the error is actually failing in our component when we run our unit tests.
Basically we need to mock out the above code within our unit test

Did anyone found any solution?

I'm also looking for a solution. Any help would be appreciated!
@tara-singh-danu did you find a solution?

I'm also looking for a solution. Any help would be appreciated!
@tara-singh-danu did you find a solution?

I am using these libraries now
"@testing-library/jest-dom": "5.16.2",
"@testing-library/react": "12.1.5",
"@testing-library/user-event": "^14.2.1",
In which I am not getting the above issue.

@tejpowar how did you mock the loadable import?

I faced a similar issue and included the function definition in a try catch block and it fixed all test cases.

Hi @HebleV can you expand a little in the solution?

I have found a very hacky and ugly solution... It would be nice to know the proper way to do this.
Let's assume we import a component (with classes) called Dummy:
import loadable, { lazy } from '@loadable/component';
const Dummy = lazy(() => import('../components/Dummy'));
...
// lazyLoaded is a state variable to force Suspense
class SomeClass  {
 render() {
  return (<>
     {this.state.lazyLoaded && <Suspense fallback={
loading in suspense
}><Dummy /></Suspense>
   < />)
 }
}

We can use the following super ugly code in a jest to test it.
jest.mock('react', () => {
  const React = jest.requireActual('react');
  const Suspense = ({children, fallback}) => {
    console.log('Suspense called children!!', typeof children, children.toString());
    console.log('Suspense called fallback!!', typeof fallback, fallback.toString());
    return children;
  };
  return {
    ...React,
    Suspense
  };
});

jest.mock('@loadable/component', () => {
  const loadable = jest.requireActual('@loadable/component');
  // The trick is to convert the async dynamic import we do not have in node, to a syncronous require!!!!!!
  const lazy = (importer) => {
    const matchCondition = `${importer?.toString()}`.match('Dummy');
    if(matchCondition) {
      return require('../components/Dummy').default;
    }
    return importer;
  };
  loadable.lazy = lazy;
  return {
    __esModule: true,
    default: (children) => {
      return children;
    },
    loadable,
    lazy
  };
});

Note - you do mock @loadable/component in the same way, and in your case default export is working 🤷♂
However, I should ask other questions

why you need to mock loadable/component?
why you require('../components/Dummy')
is loadable babel plugin applied? Because it should handle this out of the box

Hello @theKashey, I mock @loadable/component because I need to mock lazy. Also, I have loadable babel plugin, but not working with jest. How should it work with jest?

How should it work with jest?

Follow Jest babel's configuration (usually just .babelrc)

Do you know any example to mock

You cannot mock loadable, as you need "something" to transform import into require to make your code "sync". Or you might not want that and keep stuff dynamic. If you use Jest with RTL - that should work out of the box, you just need to wait a little for components to load (wait for content inside lazy loaded regions or just wait for a promise)

You cannot mock loadable, as you need "something" to transform import into require to make your code "sync". Or you might not want that and keep stuff dynamic. If you use Jest with RTL - that should work out of the box, you just need to wait a little for components to load (wait for content inside lazy loaded regions or just wait for a promise)

Well, the whole point is to deal with @loadable/component, Suspense and lazy with dynamic imports. We are using enzyme. I see that the very ugly example above works, I override Lazy and transform import to require.
I will take a look to the following example to see if I can make it working.  Thanks for your help.
https://github.com/timarney/react-app-rewired/issues/328#issuecomment-498836392.

There is something wrong with this package export. Seems it provides different exports in ESM and CJS. In ESM default is loadable function, but in CJS default is an object with another default prop. So you need to write loadable.default(() => import(...)).

I fixed it by writing
import rawLoadable from '@loadable/component';
const loadable = typeof rawLoadable === 'function' ? rawLoadable : rawLoadable.default;

Finally found rather simple solution which works for me without mocking:
import { render,screen } from '@testing-library/react';
import LoadableComponent from './LoadableComponent';

test('it renders', async () => {
  const name = "LoadableComponent"

  render(<LoadableComponent name={name} />);

  expect(await screen.findByText(name)).toBeInTheDocument();
});

LoadableComponent file:
import loadable from '@loadable/component';

const LoadableComponent = loadable(
  () => import('your-library-path'),
);

export default LoadableComponent;

@revenokanton dude, it's amazing!!!


CARDS-1780: Configure/Implement data import from Clarity

This PR involves the clarity importer, and includes sample testing data
To test (via Docker):

Build with -Pdocker and navigate to the compose-cluster folder.
Clean up any old instance of CARDS with docker-compose down && docker-compose rm && docker volume prune -f && ./cleanup.sh
Start up Docker with python3 generate_compose_yaml.py --mssql --cards_project cards4prems --oak_filesystem --dev_docker_image --composum --adminer (of note: --adminer to setup adminer, --cards_project cards4prems for the prems project, --mssql to setup the MS-SQL container, and --custom_env_file mssql/mssql.env to set it up with the environment variables necessary.)

As an aside, the compose-cluster/mssql/mssql.env file is there to show which environment variables are important to setup CARDs' clarity importer.

docker-compose build && docker-compose up -d to start up the server
Navigate to http://localhost:1435/ to access adminer. Login with the following credentials:

System: MS SQL (beta)
Server: mssql
Username: sa
Password: testPassword_
Database: master

On the left bar, click Import.
On the next screen, upload the file cards/compose-cluster/mssql/importTestSql.sql like so:

It should say "4 queries executed OK." if it was successful.
You can add more rows if you want to test other scenarios
I've also included a tool inside compose-cluster/mssql/ called generate_test_sql.py. Call it with python3 generate_test_sql.py test.sql -n 100 to generate 100 entries

Login to cards with the admin account
Navigate to http://localhost:8080/Subjects.importClarity

You should receive a white page with {"status":"success","message":"Data import started"}

The patients and forms should be imported momentarily. I have noticed a delay of a minute or five when importing more than 1000 forms.
When finished, docker-compose down && docker-compose rm && docker volume prune -f && ./cleanup.sh

Rebuilt many large parts of this PR to address https://github.com/data-team-uhn/cards/pull/1204#discussion_r1046496029 and have rebased it off of the latest dev branch. Tested with the included importTestSql.sql file as well as a generated SQL file created with the generate_test_sql.py program and seems to work fine with the exception that all created Forms are marked as INCOMPLETE (draft) as previously mentioned in https://github.com/data-team-uhn/cards/pull/1204#discussion_r1046366117. I'm not sure whether or not that's a blocker for the PREMs use-case.

@sdumitriu This branch is getting out of control. IIRC according to our best practices, the changes related to 1968&co should have been committed in a separate branch dependent on this one and published in a separate DRAFT PR.


posix.mak: Work around DMD bug manifesting on certain filesystems

If the files are passed to DMD in a different order, Phobos fails to
compile. For example, this happens when the Phobos source code is on a
tmpfs, but not on ext4 or btrfs. Work around this by sorting the
Phobos source file list before passing in to DMD.

It's greeeen!

I am going ahead and merge this, s.t. the approved PRs can pass smoothly. Thanks a lot @CyberShadow!

I couldn't find a bug report for this. Did you already create one?

I've CC'd Walter (by email) but don't have a reasonable test case yet... will DustMite it after I finish some modifications to it... (yeah, quite the yak-shaving stack I'm in)

Thx for the fix.
Unfortunately order of semantic analysis sometimes unveils compiler bugs.

cherry-picked as 7f23e834c1a78e985b5f18a0ea02fcd9489b584c


Command for creating relationship functions (belongsTo and hasMany)

Added a command to create laravel's relationship functions based on the foreign keys configured on the table.
php artisan xeed:relation

bin/console relation

Currently it only generates belongsTo and hasMany relationships on MySQLand SQLite
I could not provide tests as the current tests didn't work on my machine.

I could not provide tests as the current tests didn't work on my machine.

#64 solved.

Great job!


HTML tags in product descriptions

Hi,
I am having trouble putting HTML tags (eg. p, br tags etc) into product descriptions.
Is this supported? I am wondering if I am doing something wrong.
Thanks in advance,
David

I use  tags in all my products and it works fine for me. HTML tags dont work in product names (and possibly short descriptions too).

@dznicol  you may use markdown syntax

I believe Markdown can be used but in your application you'd need to render that output using .html_safe or raw

Sorry yeah I should have updated ... I forgot to use .html_safe
Thanks for the reply.
I will close.
David


Update README with conda-forge installation

Yes!

What option are you referring to?

The static shapes thing for example, which I am seeing defaults to True in TensorNet, and I understand this needs to be done to use CUDA graphs. But don't take very seriously my thoughts, I might be wrong, you decide.

Yeah... there is no option to tune that from outside, its always true.
There is no other performance-only option, so I did not want to include it just for that. Additionally, for that particular option, there is really no good heuristic AFAIK. I tried to enable it only if cuda graph capture is enabled but torch really dislikes these kind of model behavior change and I run into issues. So I just left it as True.
At some point it would be interesting to add a set of performance-only options, but I think this is not the time.


Simplify the examples

daos_cluster example can be use to just make servers.
Setting the "client_number_of_instances = 0" allows just severs
to be created.  A small patch to main.tf keeps Client resources
from being created in this case.
Only_daos_client has an unclear use.  Users should use the
Server output script to install new clients.
Signed-off-by: Keith Mannthey<EMAIL_ADDRESS>

Patch did not come though right...


Different Folder structure but added mutations

I ended up removing the input types that weren't necessary. I didn't create another folder for inputs due to their simplicity. It would be much easier to understand their usage when they are directly within the file in which they are used.

There are lot of commits in your pull request. It would be better to rebase them into one.
I agree the input types are very small and easy, but I wanted to show the developer that he / she can separate it. I know it is obvious for lot of developers that you can put those things into separate files, but... I was on lot of projects that had everything in one file and it was not readable, therefore I always do it like this in my example projects.
And I am sorry, this time I added it here by myself. But please, stay in touch and maybe there will be another issue you can hep with.
Thank you!


mdbook: 0.4.8 -> 0.4.9

Motivation for this change
simple package update
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[ ] Fits CONTRIBUTING.md.

As usual, if you feel this is a little out of place, please feel free to let me know and I'll be more careful next time.


Derive debug for FontBook

Helpfull for externally implementing Worlds, which will mostly somehow contain a FontBook, and deriving Debug is just a helpfull thing in general.

Thanks!


Inconsistent Radius.

The radius is inconsistent between the discretization interval and the direction vector.
A check needs to be implemented that makes sure that we get an error if the used provides
inconsistent radii for the discretization interval and the radius of the v tensor.

At the moment both are defaulted to radius 1  so there should be no problem at the moment.


Align chained method calls config

From @onilton on September 12, 2014 16:50
It would be nice to have a config to align chained methods with the dot of the first call.
Instead of this:
Option(readLine).map(_.toLowerCase())
  .filter(l => l == "y" || l == "n")
  .map { case l => l == "y" }
  .getOrElse(readConfirmation(prompt))

The formatter could do this:
Option(readLine).map(_.toLowerCase())
                .filter(l => l == "y" || l == "n")
                .map { case l => l == "y" }
                .getOrElse(readConfirmation(prompt))

Copied from original issue: daniel-trinh/scalariform#31

From @ms-ati on December 23, 2015 1:6
:+1:

From @johnhanks1 on November 16, 2015 22:27
+1 This would make your tool much more useful.


Acceptance criteria for 8001-BLOX Transaction and block content

https://github.com/vegaprotocol/specs/blob/user-interface-placeholders-for-all/user-interface/8001-BLOX-transaction_and_blocks.md

Old


v0.4.12

TE-1218

@jzoldak @cahrens @dianakhuang I can rebase this PR once the XSS work lands. LMK if you have feedback on these changes.

@benpatterson The XSS PR just merged: https://github.com/edx/bok-choy/pull/139

I'm going to close this and create a new one since I had given the branch name the name of the wrong release version.


BUGFIX applying flexslider to DataObject won’t call requirement

contentcontrollerInit is extended on ContentController and won’t trigger for a DataObject.

@jsirish this came up in some testing with blocks. Everything was present with the exception of the custom script to initialize the plugin.


versioning and rolling upgrades plan

bootstrap same version of etcd
cluster: {a: 2.1, b: 2.1, c :2.1}

after bootstrap the leader sets the cluster version to 2.0.
after the first round of successful version detection, the leader sets the cluster version to 2.1.

bootstrap different versions of etcd
cluster: {a: 2.2, b:2.1, c: 2.1}
There are two cases:

a:2.2 becomes the first leader
b:2.1 or c:2.1 becomes the first leader

If a becomes the first leader:

after bootstrap a:2.2 sets the cluster version to 2.1
after the first round of successful detection, the cluster version remains to be 2.1

If b:2.1 or c:2.1 becomes the first leader:

after bootstrap b:2.1 or c:2.1 sets the cluster version to 2.0. (this implies 2.2 needs to support all 2.0 commands. If we want to deprecate a command, we need to stop using the command and wait for at least 2 version bumps before removing the code handling it)
after the first round of successful detection, the leader sets the cluster version to 2.1

member restart
The restarted member recovers the previous cluster version. If all member dies before successfully setting the first cluster version, then it is the same as bootstrap case.
If member restarted with an incompatible version of binary, it dies.
rolling upgrades
cluster: {a: 2.0, b:2.0, c: 2.0} -> cluster version 2.0
upgrades a:2.1
cluster: {a: 2.1, b:2.0, c: 2.0} -> cluster version 2.0
upgrades b:2.1
cluster: {a: 2.1, b:2.1, c: 2.0} -> cluster version 2.0
upgrades c:2.1 -> cluster will be upgraded
cluster: {a: 2.1, b:2.1, c: 2.1} -> cluster version 2.1
new member dynamically joining
there are three cases.

the whole cluster is healthy in the view of the member when it joins
check the versions and cluster versions of all other members, dies if found an incompatibility
This is 100% safe.

some of the members is unhealthy in the view of the member when it joins
check the versions and cluster versions of all other member, dies if found an incompatibility.
This is not 100% safe, but 99%.
And the newly joined member might dies at runtime due to runtime version enforcement, though the possibility is low.
For example:
cluster {a: 2.1, b:2.1, c: 2.2}
The cluster lost connection with c from the beginning. So the cluster version remains to be 2.0, which is the min cluster version of a and b.
When d:2.0 joins, it checks the version of a:2.1 ,b:2.1 and the checking result is compatibility.
However when c comes back, the cluster is in a bad mixed version situation.
d:2.0 will dies with version too low when it checks the version of c:2.2 successfully.

none of the members is healthy
do not start

@philips @bakins @yichengq @barakmich
I enumerate the common cases I can think of. Please take a look.

On initial read, LGTM.

19:11:32 etcd2 | 2015/04/30 19:11:32 etcdsever: setting up the initial cluster version to 2.0.0
19:11:32 etcd2 | 2015/04/30 19:11:32 etcdsever: set the initial cluster version to 2.0.0
19:11:32 etcd1 | 2015/04/30 19:11:32 etcdsever: set the initial cluster version to 2.0.0
19:11:32 etcd3 | 2015/04/30 19:11:32 etcdsever: set the initial cluster version to 2.0.0
.... rolling upgrade all members...
19:14:39 etcd2 | 2015/04/30 19:14:39 etcdsever: updating the cluster version from 2.0.0 to 2.1.0
19:14:39 etcd2 | 2015/04/30 19:14:39 etcdsever: updated the cluster version from 2.0.0 to 2.1.0
19:14:40 etcd1 | 2015/04/30 19:14:39 etcdsever: updated the cluster version from 2.0.0 to 2.1.0
19:14:40 etcd3 | 2015/04/30 19:14:40 etcdsever: updated the cluster version from 2.0.0 to 2.1.0

This is working... So if everyone agrees on this, I get a Pull Request ready for review soon.

That seems good. I'm a little confused why after bootstrapping the cluster is initally 2.0 (is that the case for anything in the 2.x series?)
Maybe also some thoughts on 2.x -> 3.x as well? Just thinking through the cases.

The lgtm.
One question: what may happen if there exists incompatible version when bootstrap?

@yichengq It will be detected at runtime as dynamic adding case 2. But I guess this should never happen in reality...

closed via #2804


dongle_id 409071e6ad8a3912 Camryh? FP

I am just guessing here but I am 80% sure that this is right. Maybe we can track down the user.

Sorry, didn't see this!