Tweak neuron:neuron connectivity headers

Parent -> Type
Weight is unused - please drop.
Maybe drop T-bars column here too @admclachlan - do we include this for neuron:neuron?

Currently I'm only fetching neuron:neuron connectivity as pre>post weights. Probably could get T-bar counts with a custom neuprint query if that is useful.

@Robbie1977  As T-bars not currently present in data, please drop


Time duration can identify the number of days

In some scenarios, the time parameter supports days, which is better. For example, data is rarely modified and the backup interval is expected to be one week. Although 168h can also be used, 7d is more intuitive, such as --backup-meta 7d.

took over by #4246


✨ Improve validation errors (#22)

Codecov Report

Merging #23 (eb963fe) into main (385ef44) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           15        15
  Lines          485       501   +16
=========================================
+ Hits           485       501   +16

Impacted Files
Coverage Δ

argdantic/core.py
100.00% <100.00%> (ø)

argdantic/parsing/arguments.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add favicon

Created the addfavicon feature branch for this.

Favicon looks cool, I like the look.

Merged pull request. Thanks again!

Thanks for asking!


[FALSE-POSITIVE]

Domains or links
b2badmincards.incedopay.com
More Information
How did you discover your web site or domain was listed here?

Website was not hacked
Incorrectly marked as Phishing
Nothing known about the domain on Phishtank or OpenPhish?

Additional context
Add any other context about the problem here.
:exclamation:
We understand being listed on a Phishing Database like this can be frustrating and embarrassing for many web site owners. The first step is to remain calm. The second step is to rest assured one of our maintainers will address your issue as soon as possible. Please make sure you have provided as much information as possible to help speed up the process.
Send a Pull Request for faster removal
Users who understand github and creating Pull Requests can assist us with faster removals by sending a PR on the whitelist.me file

https://github.com/mitchellkrogza/Phishing.Database/blob/master/whitelist.me/whitelist.me
Please include the same above information to help speed up the whitelisting process.

This domain seems rather suspicious to me,first, ther are no secure connection (SSL) second it is redirecting to the spyware domain akamai of you actually even gets connected

curl: (28) Failed to connect to b2badmincards.incedopay.com port 80 after 130555 ms: Connection timed out
@Chankjha  is this anything near what you would expect?

Openphish FP (6/19/22), probably because you used a stolen Citibank logo, thus confusing their detection engine. See https://urlscan.io/result/0bfd697a-0d38-4843-a0c5-1cafcf8e73e2
@spirillen it is not stealing your credentials or credit card details, so this is not a phishing site. It may still be unsafe or spyware or a scam, but not phishing.

This domain seems rather suspicious to me,first, ther are no secure connection (SSL) second it is redirecting to the spyware domain akamai of you actually even gets connected

curl: (28) Failed to connect to b2badmincards.incedopay.com port 80 after 130555 ms: Connection timed out
@Chankjha is this anything near what you would expect?

I will re look at this tomorrow just been a bit busy

Already whitelisted. Closing.


Fix size check of max processor count

On 64-bit systems, size_t will not overflow when the function to get max processors returns UINT32_MAX. Explicitly check for the proper value so that both 32-bit and 64-bit systems will succeed.

@malfet Flagging as the fix for the size check you flagged in the recently landed RISC-V CL.


If master.m3u8 contains the URI to the encryption key, it is converted to an IPFS link!

The file master.m3u8 contains the URI to the encryption key
#EXT-X-KEY:METHOD=AES-128,URI="https://hlsbook.net/enc.key",IV=0xecd0d06eaf884d8226c33928e87efa33
Here is the error in the console:
Error: File not found: Qma4qsd4h5PY7YmxHgva1w68FMcPv4c8fBR5LjUwfzZEzq/enc.key
    at getFile (index.js:125)

In a context where a video is encrypted, it does not make sense to include the key in the ipfs directory itself.
The URI should remain https and not become ipfs.

See https://github.com/moshisushi/hlsjs-ipfs-loader/issues/21 for continued discussion.


OLAP integration for scalable analytics

Can there be a feature for handling large datasets? By this, I mean integrating with OLAP databases to perform heavy analytical tasks. A typical scenario involves loading a 300 MB data file directly into these databases without the need to download them but instead, load them directly.

I think this would need to be an enhancement to the Kaggle platform, not a Kaggle API enhancement. I suggest posting a request to https://www.kaggle.com/discussions/product-feedback


Extend gcp.py to also read/archive jsons for AWS resources (especially retrospective.)

ping @arpita0911patel @karnesh

This may involve a combination of data.py (which already reads the AWS resource) and gcp.py in the /kerchunk folder.


Portfolio project review

Well done! You did a very good job but the margin between some of your sections is more than the required in the figma design.
For example, the header section has a bigger gap than required between it and the works section.
Also try to create individual CSS files for each section to avoid very long style.css file which could lead to confusion later on as the project is being modified.
Overall, you did a very good job. Kudos to you!

All Issues have been Addressed


yarn dev command is not working in node 16 version.

I have to downgrade to 13/ 14/ 15/

please, someone upgrade the project to latest node version.

We have updated the main branch with latest updates from reactjs.org repository. It is working as expected from my end. Can you guys try again after pulling the latest changes from main?
@nomandhoni-cs @AlSajid

@shakib609 Thanks, now it's working with the latest version of Node.js
I want to contribute in the docs, do I have to get assigned in specific task, before I start contributing.

Hi @nomandhoni-cs , you can check #1 to see the pending translation tasks. You can pick any of them up. I would recommend going for one of the core pages first if possible.
Closing this issue, as it's resolved. Thanks for pointing out. 🙌


[Refactor] record error code

Why I'm doing:
We only record error code when encounter expection when getNext() which makes user cannot get enough error info in audit log.
What I'm doing:

Add some error type for different types of expection.

parser execption -> ANALYSIS_ERR
IOException -> IO_ERR
any other exception In FE process step -> INTERNAL_ERR
BE execute exception -> TStatusCode.name()

remove some unnecessary catch execption.
Ignoe record  kill stmt execute failure to avoid non-sense error sql in audit log.

BTW, we'd better think how to unify these TStatusCode, ErrorCode, ErrType, ConnectContext.errorCode.
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

@mergify backport branch-3.2 branch-3.1

@mergify backport branch-3.0 branch-2.5


Multi-gpu support

Do you plan to release multi-gpu support?

need this as well, I tried to split different parts of the model into gpus, but ran into a lot of problems, might because multiple controlnets in the pipeline?


az vm extension set crashes

az vm extension set -n IaaSAntimalware --publisher Microsoft.Azure.Security -g TestDesktop_RG --vm-name vmAWB10Test09

Traceback (most recent call last):
  File "/usr/local/Cellar/python3/3.6.0_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/azure/cli/main.py", line 37, in main
    cmd_result = APPLICATION.execute(args)
  File "/usr/local/Cellar/python3/3.6.0_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/azure/cli/core/application.py", line 157, in execute
    result = expanded_arg.func(params)
  File "/usr/local/Cellar/python3/3.6.0_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 358, in _execute_command
    raise ex
  File "/usr/local/Cellar/python3/3.6.0_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 353, in _execute_command
    result = op(client, **kwargs) if client else op(**kwargs)
  File "/usr/local/Cellar/python3/3.6.0_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/azure/cli/command_modules/vm/custom.py", line 861, in set_extension
    instance_name = _get_extension_instance_name(vm.instance_view, publisher, vm_extension_name)
  File "/usr/local/Cellar/python3/3.6.0_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/azure/cli/command_modules/vm/custom.py", line 712, in _get_extension_instance_name
    ext = next((x for x in instance_view.extensions
StopIteration

I will fix it today.

@yugangw-msft I also ran into this issue, but I'm not familiar with how the cli is released. Do I have to use a nightly build? Will this be included in a more official 'release' sometime soon?

We plan to have a release early next week including this fix.

Awesome, thanks!


StyleProvider Context missed

StyleProvider Context is missed and get all times the default options
<StylesProvider
        generateClassName={pageContext.generateClassName}
        jss={pageContext.jss}
        {...paramsToTheme}
        // registry={pageContext.sheetsRegistry}
        // jss={pageContext.jss}
        // generateClassName={pageContext.generateClassName}
      >
        <ThemeProvider
          // {...paramsToTheme}
          theme={pageContext.theme}
          // sheetsManager={pageContext.sheetsManager}
        >
          <CssBaseline />
          <ErrorBoundary location={location} history={history}>
            <AppWrapper {...this.props} changeTheme={this.changeTheme} />
          </ErrorBoundary>
        </ThemeProvider>
      </StylesProvider>

but the options pass to provider when makestyles get the context the context is other

I may be seeing a similar issue but I haven't been able to track it down yet.  useTheme/makeStyles is returning the defaultTheme even though I am using ThemeProvider with a custom theme.  I am only seeing this when CRA is built on Linux, it works fine when built on Windows.  I still need to investigate further as there is not an easy way to debug this.  @joacub I am curious, what OS are you building on? Are you using create-react-app?

Could you create a minimal repository that can reproduce this issue? This would help alot.

@eps1lon
Here is a minimal reproduction of what I am seeing: Theming Repo.  I can only get the error to reproduce when building on my build server or Ubuntu.  It works fine on Windows build.   Am I doing something wrong?

I tried it in the code sandbox and it works fine.

 Please add a lockfile and verify that only a single version of @material-ui/styles is installed.

Yes the error is beco use the context is different so is becomes you have different vesions of material ui core and styles package , if you remove the dependencia of styles and only let the core it’s all right if not the core use a self version of styles and you are getting other version in your own code of style provider

Your version strings in your package.json seem off. Please add a lockfile and verify that only a single version of @material-ui/styles is installed.

Yes, this resolved my issue.  I had two different versions.


Can you tell me the progress of VDF，Now I'm interested to know how do you generate two large prime Numbers

how do you generate two large prime Numbers

The goal is to have an (n-1)-secure RSA ceremony with ~1,000 participants. The MPC is being designed by Ligero, specifically Carmit Hazay, abhi shelat, and Muthu Venkitasubramaniam. They have an upcoming paper titled "Scalable RSA Modulus Generation with Dishonest Majority" where they bring down the communication complexity down to less than 10 rounds, with less than 100MB of total bandwidth per participant. I'm hoping the RSA ceremony will be completed in a handful of minutes.


Add ssl support to grpc proxy

Fixes https://github.com/dapr/dapr/issues/4048.

@daixiang0 can you please review?


fix: assertion of DynamoType failing

This is a complete test which reproduces the issue.
The reload function is sourced from this Stack Overflow response. Our tests currently rely on this behaviour. The use of this function contributes to the occurrence of this bug.
import importlib
import sys

import boto3
import pytest
from boto3.dynamodb.types import TypeSerializer
from moto import mock_dynamodb

serializer = TypeSerializer()

@pytest.fixture(autouse=True)
def reload(monkeypatch):
    importlib.reload(sys.modules["moto"])
    to_reload = [m for m in sys.modules if m.startswith("moto.")]
    for m in to_reload:
        importlib.reload(sys.modules[m])

@pytest.fixture
def setup_dynamo():
    with mock_dynamodb():
        dynamodb = boto3.client("dynamodb", region_name="eu-west-1")
        dynamodb.create_table(
            TableName="SomeTable",
            AttributeDefinitions=[
                {"AttributeName": "SomeKey", "AttributeType": "S"},
            ],
            KeySchema=[
                {"AttributeName": "SomeKey", "KeyType": "HASH"},
            ],
            BillingMode="PAY_PER_REQUEST",
        )
        yield dynamodb

@pytest.mark.parametrize(
    "value",
    [
        serializer.serialize(value)
        for value in [
            {"This test case passes": "A"},
            {"This test case fails": "B"},
        ]
    ],
)
def test_reproduce_dynamo_type_assertion_error(setup_dynamo, value):
    config_key = "SomeKeyValue"

    setup_dynamo.put_item(
        TableName="SomeTable",
        Item={"SomeKey": {"S": config_key}, "ConfigValue": serializer.serialize({})},
    )

    setup_dynamo.update_item(
        TableName="SomeTable",
        Key={
            "SomeKey": {"S": config_key},
        },
        UpdateExpression="SET SomeValue = :some_value",
        ExpressionAttributeValues={":some_value": value},
    )

    dynamo_item = setup_dynamo.get_item(
        TableName="SomeTable",
        Key={"SomeKey": {"S": config_key}},
    )["Item"]["SomeValue"]

    assert dynamo_item == value

Running the above code results in this assertion failing:
https://github.com/getmoto/moto/blob/bfac8a8a07f694dcbfa773c052dd7bf45d7fde06/moto/dynamodb/parsing/ast_nodes.py#L330
It seems something along the lines of this is going on: the reload function combined with the inconsistent imports means two different instances of DynamoType coexist and are in use.
Because the reload function is called between test invocations, this error only occurs when more than one test runs in a single pytest execution. So with the example above, running each case individually they'll both pass.
If appropriate, I can add the example above as a test here.

@bblommers "fun to debug!" is certainly one way to put it 😅
I have added a self-contained test which reproduces the issue using the style you've suggested.

Hmm.. Our CI still doesn't seem to like that.
All the tests after the new tests are now failing:
2023-11-28T21:23:54.2345124Z tests/test_dynamodb/test_dynamodb.py::test_dynamo_type_assertion_exception_not_raised_when_reloading_modules PASSED
2023-11-28T21:23:54.3234042Z tests/test_dynamodb/test_dynamodb_batch_get_item.py::test_batch_items_returns_all PASSED
2023-11-28T21:23:54.7353450Z
2023-11-28T21:23:54.7402019Z ##[error]test_batch_items_throws_exception_when_requesting_100_items_for_single_table

botocore.errorfactory.ResourceInUseException: An error occurred (ResourceInUseException) when calling the CreateTable operation: Table already exists: users
2023-11-28T21:23:54.7414803Z tests/test_dynamodb/test_dynamodb_batch_get_item.py::test_batch_items_throws_exception_when_requesting_100_items_for_single_table FAILED


http_query failed

http_query always failed, this is the patch:
diff --git a/src/http.c b/src/http.c
index 0b5bbc9..6314236 100644
--- a/src/http.c
+++ b/src/http.c
@@ -66,7 +66,7 @@ static int receive_all(int sockfd, char *buf, size_t length) {
int ret;
ret = wait_readable(sockfd, timeout);
if (ret != 0)

       return -1;

       return bytes_received; // www.benew.xyz fix http_query failed

   ret = recv(sockfd, buf + bytes_received, length - bytes_received, 0);
   if (ret > 0) {

Thanks for patch.


unrecognized OS: darwin

ccsecret generic my-secret --from-literal key1 --from-literal key2
Enter value for key1 :
Enter value for key2 :
Unrecognized OS: darwin
Please create an issue here, https://github.com/rewanth1997/kubectl-ccsecret/issues

@ahmetb It also doesn't install view krew.

@nikolay I can install it via krew on ubuntu. I haven't tested this on macos or darwin, hence I dropped the support. I will release an update soon with darwin support.


how do you get this app running

im very confuse pls some help
also there is so much missing dll flies

im very confuse pls some help
→ To Run, download the release and extract to C:/ or anywhere. Go to that directory and press Shift+Right Click and open with open PowerShell then attach your device run adb devices or scrcpy.exe rest you'll find in feature section of Repo README file
also there is so much missing dll flies
→ I don't face any issue.? With the app

thanks i got the app running.
On Sat, Aug 28, 2021, 12:22 PM Aditya Yadav @.***>
wrote:

im very confuse pls some help
→ To Run, download
https://github.com/Genymobile/scrcpy/releases/download/v1.18/scrcpy-win64-v1.18.zip
the release and extract to C:/ or anywhere. Go to that directory and press
Shift+Right Click and open with open PowerShell then attach your device run adb
devices or scrcpy.exe rest you'll find in feature section of Repo
https://github.com/Genymobile/scrcpy README file
also there is so much missing dll flies
→ I don't face any issue.? With the app
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Genymobile/scrcpy/issues/2596#issuecomment-907565224,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVLZTCIMEX46XMOGGVAQBUDT7BQBHANCNFSM5C42B73A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Release 0.5.0 ("Mocked Voyager") with Electron 1.7.5

This is done: https://github.com/cosmos/voyager/releases/tag/0.5.0


Zoom Selection and Panning Not Supported on Mobile Devices

Description: Currently, the zoom selection and panning functionalities in ApexCharts are not supported on mobile devices. This limitation affects the user experience, especially for applications that require data interaction on smaller screens.
Steps to Reproduce:
Open the chart on a mobile device.
Attempt to use zoom selection and panning features.
Expected Result: Users should be able to use zoom selection and panning functionalities seamlessly on mobile devices.
Actual Result: The zoom selection and panning features are not responsive or functional on mobile devices.

Did not provide required reproduction app.


Developer content

It is said that this topic is only for programmers, but there is only a description of bugcheck without any information on how to debug it. And the problem is that the meaning of bugcheck describes the first parameter, and here there is no description what the first parameter means. Can you ask for a description of at least a few parameters such as 0x7?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 07ee21a7-bbd5-a1fd-fe3d-ed30c18e3aad
Version Independent ID: bfc5146c-928e-7032-f2ad-034e1aa1a135
Content: Bug Check 0x11D EVENT_TRACING_FATAL_ERROR - Windows drivers
Content Source: windows-driver-docs-pr/debugger/bug-check-0x11d---event-tracing-fatal-error.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @DOMARS
Microsoft Alias: domars

@MrPepka - Thanks for this input. I added a descriptions of the parameter 1 values including 0x7. Using !analyze to see what code it considers faulting is always a good first step. I added a link to !analyze as well. Good luck in tracking down the failure you are working on.


View page

Added a Cover Page

the landing page is there with a button that will redirect to login form (the button need a little bit of styling)

Created view page

View page now have an organizer view, however its not functional yet. Still need to have the API endpoint to connect it to the data base.


[Feature]:  get rid of core_ffi_c

Is there an existing issue for this?

[X] I have searched the existing issues

Description
mustikka in sallyport on  feat/enarxcall/reset-sgx-permissions [?] is 📦 v0.3.0
$ git grep "[^a-z_]c_[a-z_]*" | sed 's/.*\(c_[a-z]*\).*/\1/g' | sort | uniq
c_char
c_int
c_long
c_path
c_short
c_size
c_uint
c_ulong
c_void

Refactor:

c_char -> u8
c_int -> isize
c_long -> isize
c_size -> usize
c_short -> i16
c_long -> isize
c_uint -> isize
c_ulong -> usize
c_void (page-aligned) -> primordial::Address<usize, primordial::Page>
c_void (unaligned) -> primordial::Address<usize, ()>

Acceptance Criteria
No response
Suggestions for a technical implementation
No response

no

you probably know better


operator/clustermesh: add endpoint slice synchronization

Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[x] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[x] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

This commit adds a new clustermesh module inside the operator which pull data from Cilium's clustermesh components and synchronize Endpoint Slices from remote cluster. See commits description for more details.
Related to: #27902
Add Endpoint Slice synchronization for Cilium clustermesh

I'm creating this PR early but there are many things to iron out like helm chart integration, probably integration tests, documentation. I have not really tested it so far, I can just say that the reconciler unit test are passing and the code compiling. Will try to address all of those next week or so.

It seems to work fairly well locally:
❯ k get endpointslices.discovery.k8s.io --context kind-clustermesh2
NAME                            ADDRESSTYPE   PORTS   ENDPOINTS               AGE
kubernetes                      IPv4          6443    <IP_ADDRESS>              20h
rebel-base-2sjcn                IPv4          80      <IP_ADDRESS>,<IP_ADDRESS>   20h
rebel-base-clustermesh1-6lwsj   IPv4          80      <IP_ADDRESS>,<IP_ADDRESS>   11m
❯ k get endpointslices.discovery.k8s.io --context kind-clustermesh1
NAME                            ADDRESSTYPE   PORTS   ENDPOINTS               AGE
kubernetes                      IPv4          6443    <IP_ADDRESS>              20h
rebel-base-7tllq                IPv4          80      <IP_ADDRESS>,<IP_ADDRESS>   20h
rebel-base-clustermesh2-86vjj   IPv4          80      <IP_ADDRESS>,<IP_ADDRESS>   11m

I was hoping to add an integration tests but IIUC there is no test for clustermesh so it would be harder but I can check if needed. I could add mcs-api conformance test which covers endpointslice mirroring from remote cluster as well apparently. However those need Cilium support for ServiceImport/Export support to that should probably be done in a future PR I think :thinking:.

After more discussions with @aanm, he suggested to try implementing it by fully utilizing upstream Kubernetes controller (rather than forking it and updating for our own usage) by mocking the interfaces used there, I'm switching this to draft and will work on another PR with the alternative implementation.

So the new approach discussed with @aanm is ready for review :tada:.
It involves using the upstream Kubernetes controller as is and faking that we have new pods from cluster services by essentially faking/mocking a few informers (more details in the first commit description) whereas before I was essentially getting the same code but trimming it and adapting it for dealing with clustermesh instead of pods. This new approach allow us to skip all the complicated logic inside the EndpointSlice controller/reconcile and easily get any improvement made there without too much trouble.
This has a few downside though:

To import the kubernetes lib where the endpoint slice controller it bring a substantial amount of dependencies (the actual non vendorized code added here is ~2k lines)
We have to use a bit of "reflect" and "unsafe around metrics and forcing the controller name

Also there is currently a limitation with the synchronization of pod's hostname as this is something that is not currently available in Cilium's Clustermesh. But I think this can be something that could be added at a later point.

I have an issue with the size of this PR. I understand that most of it is additional dependencies, which begs the question why we need so many of them? Perhaps we can copy part of a dependency, use one of our existing dependencies or re-implement something?
Even considering just the 2k of non-vendor code, I would suggest merging the full feature in multiple PRs, large changes such as this are really hard to review properly.
Also, the PR needs a rebase.
Please don't take this feedback to harshly, we are very thankful for what must have been a lot of work you have put into this.

I have an issue with the size of this PR. I understand that most of it is additional dependencies, which begs the question why we need so many of them? Perhaps we can copy part of a dependency, use one of our existing dependencies or re-implement something?

So most of the dependencies are kubernetes/otel ones, the previous approach that I took was to extract the upstream code and adapt it and was like ~8k line of code including dependency (i kept it in a separate branch if you want to take a look https://github.com/MrFreezeex/cilium/commits/add-sync-endpoints-old/). So technically probably around only ~10k lines of dependencies are actually used.
I did it this way initially as we are not exactly in the same context, like in the clustermesh context we are not receiving pods but rather Cilium's GlobalService. Then @aanm suggested to mock the different resources and use the upstream controller directly so we didn't have to directly maintain a reharsh of the upstream controller and do these (relatively) small tweaks for the CIlium context. So now we only call the upstream controller (https://github.com/MrFreezeex/cilium/blob/add-sync-endpoints/operator/pkg/clustermesh/endpointslice_meta_controller.go#L29) and unfortunately this line almost alone make this current "dependency hell".
Note that the upstream controller have to handle a lot of somewhat complicated things like splitting big endpoint slice, reusing them as much as possible, topology API, dual stack, batching reconciliation events, and I think it's somewhat nice to reuse the upstream code rather than trying to implement our own version IMO.
Maybe it would be possible to extract the upstream code in a fork (that could be in the CIlium org for instance) and automate the update from the actual kubernetes code with a small script. It should remove most of the unecessary dependencies that we have to import, I can take a look to do that if you think that's a fair approach.

Even considering just the 2k of non-vendor code, I would suggest merging the full feature in multiple PRs, large changes such as this are really hard to review properly.

Hmmm it's not a lot of code but maybe I could split the code to create the cell + the "clustermesh" specific code to synchronize the different GlobalService/globalServiceCache and so on from the current PR. It's not a lot of code and pretty similar to the clustermesh code in the CIlium agent though (which fortunately is already nicely simplified thanks to pkg/clustermesh/common).

I understand the predicament now, thank you for explaining. I will leave it to the assigned reviewers to make a decision on what to do.

I removed a bunch of dependencies (~160k LOC in the vendor dir) by copying two files and making minor tweak to remove the import to k8s.io/kubernetes/*) in those file:
❯ diff endpointslice_controller.go ~/kubernetes/pkg/controller/endpointslice/endpointslice_controller.go
1,2c1,2
< // SPDX-License-Identifier: Apache-2.0
< // Copyright Authors of Cilium
---
> /*
> Copyright 2019 The Kubernetes Authors.
4c4,15
< // Copyright 2019 The Kubernetes Authors.
---
> Licensed under the Apache License, Version 2.0 (the "License");
> you may not use this file except in compliance with the License.
> You may obtain a copy of the License at
>
>     http://www.apache.org/licenses/LICENSE-2.0
>
> Unless required by applicable law or agreed to in writing, software
> distributed under the License is distributed on an "AS IS" BASIS,
> WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> See the License for the specific language governing permissions and
> limitations under the License.
> */
6,10c17
< // Code copied from https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/endpointslice/endpointslice_controller.go
< // for simpler cilium dependency handling. The only change made here is to strip
< // the dependency to k8s.io/kubernetes.
<
< package clustermesh
---
> package endpointslice
24a32
> 	utilfeature "k8s.io/apiserver/pkg/util/feature"
39a48,50
> 	"k8s.io/kubernetes/pkg/controller"
> 	endpointslicepkg "k8s.io/kubernetes/pkg/controller/util/endpointslice"
> 	"k8s.io/kubernetes/pkg/features"
143,153c154,165
< 	nodeInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
< 		AddFunc: func(obj interface{}) {
< 			c.addNode(logger, obj)
< 		},
< 		UpdateFunc: func(oldObj, newObj interface{}) {
< 			c.updateNode(logger, oldObj, newObj)
< 		},
< 		DeleteFunc: func(obj interface{}) {
< 			c.deleteNode(logger, obj)
< 		},
< 	})
---
> 	if utilfeature.DefaultFeatureGate.Enabled(features.TopologyAwareHints) {
> 		nodeInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
> 			AddFunc: func(obj interface{}) {
> 				c.addNode(logger, obj)
> 			},
> 			UpdateFunc: func(oldObj, newObj interface{}) {
> 				c.updateNode(logger, oldObj, newObj)
> 			},
> 			DeleteFunc: func(obj interface{}) {
> 				c.deleteNode(logger, obj)
> 			},
> 		})
155c167,168
< 	c.topologyCache = topologycache.NewTopologyCache()
---
> 		c.topologyCache = topologycache.NewTopologyCache()
> 	}
373c386
< 		return NewStaleInformerCache("EndpointSlice informer cache is out of date")
---
> 		return endpointslicepkg.NewStaleInformerCache("EndpointSlice informer cache is out of date")
394c407
< 	key, err := cache.DeletionHandlingMetaNamespaceKeyFunc(obj)
---
> 	key, err := controller.KeyFunc(obj)
405c418
< 	key, err := cache.DeletionHandlingMetaNamespaceKeyFunc(obj)
---
> 	key, err := controller.KeyFunc(obj)
558c571
< 		if IsStaleInformerCacheErr(err) {
---
> 		if endpointslicepkg.IsStaleInformerCacheErr(err) {

Thanks for the review 🎉

Also, it seems that we are missing some e2e tests, are we planning to have those as well?

Well yes I would like to have some. But unfortunately last time I checked there was no e2e tests on anything related to clustermesh (AFAIU?) so it's something that I didn't do so far but could try to.

I think we have them, @giorio94 can you help out here?

Also, it seems that we are missing some e2e tests, are we planning to have those as well?

Well yes I would like to have some. But unfortunately last time I checked there was no e2e tests on anything related to clustermesh (AFAIU?) so it's something that I didn't do so far but could try to.

I think we have them, @giorio94 can you help out here?

Sure. the main clustermesh E2E tests are defined in conformance-clustermesh.yaml, and we also have tests-clustermesh-upgrade.yaml to ensure that meshed clusters skewed by one minor version can still interoperate correctly. In both cases, the GHA workflow definition takes care of setting up the testing environment (two kind clusters), installing Cilium and so on. The actual tests are then executed through the Cilium CLI connectivity suite.
I haven't yet looked into the details of your PR, but my feeling is that it should be enough to add the appropriate tests to the connectivity suite, without having to modify the workflow. For inspiration, the entrypoint enumerating all connectivity tests is suite.go.
Feel free to ping me (either here or on slack) for more details/pointers about the introduction of new connectivity tests for clustermesh.

I have one high-level quesion - should we add this synchronization to cilium-operator or somewhere else? I can see a few possibility and each of them have their downsides:

Hmmm so my initial thought was to place this in the operator as it was somewhat logical to me to put a controller inside an operator and also we would most likely need to place the future MCS API controllers collocated to this code (which I would like to work on next).
But apart from that I am not against moving this, I think it definitely makes sense. My only concern is that we would most certainly need to add a globalServiceCache wherever we do this. Apart from that constraint + that we would most likely need to place the MCS API controllers there as well I am open to do this about anywhere :D.

Thanks for your very useful pointers @giorio94! I added a basic e2e test here https://github.com/cilium/cilium-cli/pull/2267 to ensure that we can get endpointslice sync working with a dns query on a headless service.

I did a first pass on the PR and left a few initial comments, although I'll admittedly need to come back later to fully digest all the logic. Overall, I'm personally concerned about the mocked client/informer approach, which looks potentially fragile to me. I did a bunch of simple tests (mostly around scaling up/down the remote deployment, or removing the remote service), and in quite a few cases the local epslice didn't react as expected (in most cases it didn't react at all, in another the controller kept creating duplicated epslices at every retry), and the controller logged warnings/errors which look a consequence of the mocked informers behavior. Examples are:

Thanks for pointing that out, will check what's happening here :+1:

I wonder if there could be a simpler/more robust way of achieving the same goal, but unfortunately I don't have any good suggestions at the moment. In any case, I'll keep thinking about it.

Not sure how we can do more elegantly than this without re-implementing an endpointslice controller/reconciler or changing too much the existing one.

@MrFreezeex I had a quick chat with Marca and Andre and we agreed that having endpointSlice synchronization in cilium-operator is fine, but it would make sense to have a separate clientset so it doesn't share qps/rate limiting with other parts of cilium-operator - so basically chance of remote clusters churn affecting local cluster operation will be minimal.

I addressed many suggestions (thanks for the reviews :pray:) and most importantly found the issues with the reconciliation inconsistencies:

The EndpointSlice watcher implementation in the meshClient was buggy (the select over the channel was not in a loop... :sweat_smile:)
Added something to delete the endpointslice if we remove the annotation sync the endpointslice https://github.com/MrFreezeex/cilium/blob/cc4c07001a9367ac366acae1ac895f042c5c8823/operator/pkg/clustermesh/service_informer.go#L89) . This is needed because the current implementation report Services that don't sync EndpointSlice like if they were not existing to the controller. And as opposed to a service that is actually deleted, endpointslice doesn't get removed on their own via the ownerref so we need something to clean that up.

I haven't updated the unit test and there still a few suggestions to address, but it should be much more reliable now!

/test

/test

I just noticed that I should have not squashed my fixup commits, it will make the review harder, sorry for that :(.
Quick note also about the two last commits:

https://github.com/cilium/cilium/pull/28440/commits/9404c81ae2ea839a2db1cc0425531eae9b049789
https://github.com/cilium/cilium/pull/28440/commits/5c93290e9c54de2aaf694cc56439bdd54ca711b8

They might be a good candidate for separating them into their own PR as it's a code improvement that does not affect the base functionality and it also affects the "general" clustermesh code so it might need a higher level of scrutiny.

Sorry for the delay. I finally managed to get back to review this PR.

Quick note also about the two last commits:

https://github.com/cilium/cilium/commit/9404c81ae2ea839a2db1cc0425531eae9b049789
https://github.com/cilium/cilium/commit/5c93290e9c54de2aaf694cc56439bdd54ca711b8

They might be a good candidate for separating them into their own PR as it's a code improvement that does not affect the base functionality and it also affects the "general" clustermesh code so it might need a higher level of scrutiny.

I've started looking into these two commits, and overall look great, thanks! I've just left one minor comment inline, and I wonder whether it could be worth creating a dedicated package (maybe clustermesh/service or clustermesh/common/service) instead of reusing the common one. WDYT?
That said, would you be up for opening a separate PR with only those two commits, and /cc me there? That should be pretty quick to get reviewed and merged, so that we can start making progress, and reduce the size of this one.

I feel there's something wrong with the EndpointSlices wrapper, but I'm not yet sure what exactly. I've had one cluster with the feature enabled (everything else idle, and no services at all) and after ~10 minutes the operator started busy looping, with the logs being flooded by:
level=error msg=k8sError error="k8s.io/client-go/informers/factory.go:159: expected type *v1.EndpointSlice, but watch event object had type <nil>" subsys=k8s

Restarting the operator fixes it, but this is already the second time that it happened. I've now enabled the pprof server, so
I should be able to gather more information if it happens again.

I feel there's something wrong with the EndpointSlices wrapper, but I'm not yet sure what exactly. I've had one cluster with the feature enabled (everything else idle, and no services at all) and after ~10 minutes the operator started busy looping, with the logs being flooded by:
level=error msg=k8sError error="k8s.io/client-go/informers/factory.go:159: expected type *v1.EndpointSlice, but watch event object had type <nil>" subsys=k8s

Restarting the operator fixes it, but this is already the second time that it happened. I've now enabled the pprof server, so I should be able to gather more information if it happens again.

Ah! I must have re-introduced a bug then, sorry :(. Last time I checked was before adding the feature flag logic and I'm pretty sure it was not doing this...

I feel there's something wrong with the EndpointSlices wrapper, but I'm not yet sure what exactly. I've had one cluster with the feature enabled (everything else idle, and no services at all) and after ~10 minutes the operator started busy looping, with the logs being flooded by:
level=error msg=k8sError error="k8s.io/client-go/informers/factory.go:159: expected type *v1.EndpointSlice, but watch event object had type <nil>" subsys=k8s

Restarting the operator fixes it, but this is already the second time that it happened. I've now enabled the pprof server, so I should be able to gather more information if it happens again.

Ah! I must have re-introduced a bug then, sorry :(. Last time I checked was before adding the feature flag logic and I'm pretty sure it was not doing this...

It just happened again. I'm attaching the pprof FYI, although most of the entries are related with logging.
My understanding is that this is caused if the ResultChan() gets closed by the upstream watcher, as then the receive() function becomes a busy loop. It could be fixed returning if the channel is closed, or changing the logic according to https://github.com/cilium/cilium/pull/28440#discussion_r1497782478.
pprof.cilium-operator-generic.samples.cpu.pb.gz

I just fixed the case where the endpointslice was not being recreated after a manual deletion in (wip commit to be squashed):

https://github.com/cilium/cilium/pull/28440/commits/983effacbab1dac6b0fe0aa222d1f778817bf537

Before doing that the controller/reconciler registered inconsistently the endpointslice with the wrong service name (without the cluster name in it) so we actually need to remove the "hacks" before going to the apiserver but add those back before returning to the controller/reconciler code.

Hi, I've set this to draft while you rebase + get CI green. Let us know here or on Slack #development if you need someone to trigger the /test commands. When you think this is ready for a fresh round of review, please use the "Ready for Review" button at the bottom of the page to mark the PR for review again.

Also now that this has a toggle switch that is disabled by default, wondering if this should be enabled by default in the conformance-clustermesh tests :thinking:?

Also now that this has a toggle switch that is disabled by default, wondering if this should be enabled by default in the conformance-clustermesh tests 🤔?

Sure, let me take a look at https://github.com/cilium/cilium-cli/pull/2267, then I can open a separate PR to enable this feature and configure the CLI development version with the test to verify that it works as expected here. We need to open that from a branch in cilium/cilium, instead of a fork, otherwise we cannot test if it works directly as part of the PR.

/test

@sayboras @pippolo84 @qmonnet @harsimran-pabla Gentle ping :pray:

/test

/test

Hi @pippolo84 many thanks for the review! :D
I updated a bit the last commit do you think you could take another quick look on it if it looks all sane to you 🙏? I was a bit updating this at the same time you reviewed 😅.
It's linked to the suggestion you made about headless service exclusion. There was a bug on the label selector for instance, like I assumed the label selector were merged with the functionnal pattern but not at all. So now I have to parse the labels and add the headless exclusion and also did some other small fixes on this commit.

/test

/test

Huge thanks to all the people involved here :heart:. Many of you provided super insightful reviews that made the code a lot better, wrote encouraging messages or even provided direct help!
Now I am excited to to have other users trying this, annd see some of you around for the followups/related PRs  :D.


Cleaning up obtuse example code

Hi @paulpv, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@paulpv Thanks for helping us improve our Android code samples. We appreciate your contribution to improving the Azure docs.


Can't get alpha channel output

How do you get the alpha output? I have a Photoshop file with an alpha channel, but the alpha_output only outputs a blank mask.

can you give me more information? such as what your workflow looks like.
Works in my Comfy

Oh, I thought it meant a real alpha channel output. If I just make some transparency in a layer, like your example, it will output that fine. But if my Photoshop file has a true alpha channel, that doesn't output, but just shows black.

Seems like Adobe does not provide APIs to get contents of one specific channel.
This issue will keep open to see if Adobe will provide it later


Adding UsableNet

For some context, here is some evidence why I believe UsableNet (and specifically its "Assistive" offering) should be added.

Implies WCAG conformance requires no effort, that its tooling can do it:

Our Assistive platform offers an end-to-end solution that dynamically remediates and maintains the accessibility of your site so it conforms to the most current standards.

We already know "ADA compliance" is not a thing, but here it is as a marketing promise:

We deliver a fully ADA-compliant site tested with automated tools, manual review and people from the disability community.

Promises WCAG conformance (which I disprove later):

Our work ensures your site conforms fully to the highest standards (WCAG 2.0 or 2.1 AA).

Relies on automated captions for its marketing videos, without correcting them:

Pitches a de facto one-click solution through its "Enable accessibility" add-on at customer sites:

Uses an add-on which does not work unless you enable third-party cookies:

Generates more than twice as many automated test warnings with TPGi's ARC Toolkit when enabled (DSW home page).

Generates more issues in Deque's Axe when enabled (DSW home page).

Anything requiring me to use CPU cycles on my computer to remediate code on every visit while also self-identifying a disability to un-break a site is an overlay to me. It is not an equal experience. It also presents a false choice between privacy/security and accessibility.
Not all overlays need to present a bevy of widgets that adjust content in nonsense ways or just fail to work, some can just fail silently.

@aardrian do you think it would be worthwhile to specify the actual product?
This is more of a grey area with UsableNet than AccessiBe (or is it?).
UsableNet used to make those "alternate" versions of customers' sites. Those were mostly crap, but AFAIK they've stopped doing that.
However, now there's this "UsableNet Assistive".
Do we know if UsableNet has any other offerings? Is this used in conjunction with services or is it stand alone?
Your evidence above is already pretty solid. I just wonder if, in context of this PR, its worth clarifying the product name

@karlgroves Fair point. The issues I cite are primarily around that specific product offering. And, unlike accessiBe or UserWay or others, UsableNet started not as a product but as a service offering (as you note). And UsableNet has other products, meaning "UsableNet" alone is not synonymous with its overlay product.
I amended my PR to name the product.

When does this show up on the live site?

Clarification needed on UsableNet Assistive and Accessibility for Ontarians with Disabilities Act, 2005 (AODA) Conformance Claims
Good evening Jason,
I'm hoping you can clarify UsableNet Assistive and Accessibility for Ontarians with Disabilities Act, 2005 (AODA) conformance claims on your website?
UsableNet Assistive claims on its website to continously achieve Accessibility for Ontarians with Disabilities Act, 2005 (AODA) compliance with each new release and code change.
Screenshot

Text excerpt from UsableNet website
A Complete Web Accessibility Solution
UsableNet Assistive enables accessibility on your website in weeks and provides the most WCAG compliant and usable experience for people with disabilities.
With each new release and code change, Assistive keeps you in compliance with WCAG and access laws like the Americans with Disabilities Act (ADA) and the Accessibility for Ontarians with Disabilities Act (AODA). Watch the video
Source: UsableNet website https://usablenet.com/technology/assistive-technology-services

AODA's scope contains integrated standards far beyond a website's conformance to Web Content Accessibility Guidelines. For example: How does your solution meet the legal requirements and needs of a disabled individual that asks for website content to be made available to them in an alternate accessible format (such as large print, mp3, transcript, braille, captions, etc.)? Specifically, how does UsableNet developers, testers and third-party providers work on behalf of the business with disabled individuals to meet the Ontario Human Rights Legislation, the Canadian Charter of Rights and Freedoms and additional relevant legislation?
AODA legally requires that businesses and non-profits with 20 or more employees file accessibility compliance reports. It is an offence to provide false or misleading information in an accessibility report and corporations can be fined $100,000 each day or part of a day on which the offence occurs or continues to occur. Source: [website] https://www.ontario.ca/laws/statute/05a11#BK17 How do you confirm your claims of AODA conformance in weeks will be sufficient to avoid fines and when the Ministry for Seniors and Accessibility and the Government of Ontario do not endorse or recommend any accessibility consultant(s), their advice, opinions or recommendations. Source: Disclaimer [website] https://www.ontario.ca/page/accessibility-in-ontario
In addition, It is becoming more common for organizations to do a risk assessment and request a VPAT 2.4Rev INT (March 2022). Are you able to provide these documents?

I look forward to reading your response and for your time.
Best regards,
Lonny O'Brien

Trying to address this in chunks (I am independent, so filing and responding to PRs is unpaid labor), and will address the more straightforward one first.

First, I address how the UsableNet Assistive service works and why Assistive does not fit the definition on the Overlay Fact Sheet.

If we are restricting ourselves solely to the definition on OFS, then here it is: "Overlays are a broad term for technologies that aim to improve the accessibility of a website. They apply third-party source code (typically JavaScript) to make improvements to the front-end code of the website."

UsableNet Assistive Service is not a mass market product, as all the other tools listed on the Overlay Fact Sheet.

That is not part of the definition.

The Platform aspect of UsableNet Assistive manages the remediation code. The website remediations get applied to the website once the ‘Enable Accessibility’ link is selected. The process is on-the-fly; it is not a separate website; it is 100% dynamic (much the same as every website has a dynamic desktop and mobile rendering of the same site).

That tells me it uses third-party code ("Assistive manages the remediation code") to make improvements to the front-end code of the site after it has been delivered/rendered ("process is on-the-fly").
(As a point of fact for the parenthetical statement, not every web site has "dynamic desktop and mobile rendering"; OFS does not, for example.)
As far as I see, UsableNet Assistive meets the definition of overlay as provided on this site.

Please shift any comments to https://github.com/karlgroves/overlayfactsheet/issues/957

understand the discussion has moved to another ticket. Wanted to make sure @lonnyobrien got a response. I believe a address @aardrian website claim observations in my response above. lease Adrian let me know if I did not.
Hi Lonny
The UsableNet Assistive Service is one of a number of approaches we offer. In all client engagements, it would most likely be provided , as part of an overall package of services to match the clients challenges. The fast majority of our clients do not use the UsableNet Assistive Service, we support them with other more traditional type support for internal accessibility efforts.
The description of UsableNet Assistive Service is focused on addressing the web experience in he context of any legal obligation. We do not sell it as a stand alone tool or solution to solve , in most cases, a range of accessibility client needs - we careful work with clients to build out a range of services if needed. We do provide VPAT, we also provide training courses, Audits, Testing platform and many other approaches that can be mixed to the client need. I have asked the team to tweak the wording on the page you identified to ensure its clear that UsableNet Assistive Service is to help with the web experience component of a clients need.

Thanks for the clarification and quick response.
On Wed., Apr. 20, 2022, 2:10 p.m. Jason Taylor, @.***>
wrote:

understand the discussion has moved to another ticket. Wanted to make sure
@lonnyobrien https://github.com/lonnyobrien got a response. I believe a
address @aardrian https://github.com/aardrian website claim
observations in my response above. lease Adrian let me know if I did not.
Hi Lonny
The UsableNet Assistive Service is one of a number of approaches we offer.
In all client engagements, it would most likely be provided , as part of an
overall package of services to match the clients challenges. The fast
majority of our clients do not use the UsableNet Assistive Service, we
support them with other more traditional type support for internal
accessibility efforts.
The description of UsableNet Assistive Service is focused on addressing
the web experience in he context of any legal obligation. We do not sell it
as a stand alone tool or solution to solve , in most cases, a range of
accessibility client needs - we careful work with clients to build out a
range of services if needed. We do provide VPAT, we also provide training
courses, Audits, Testing platform and many other approaches that can be
mixed to the client need. I have asked the team to tweak the wording on the
page you identified to ensure its clear that UsableNet Assistive Service is
to help with the web experience component of a clients need.
—
Reply to this email directly, view it on GitHub
https://github.com/karlgroves/overlayfactsheet/pull/932#issuecomment-1104262852,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACM4HNS4MZW7L7HUB4JONB3VGBCAPANCNFSM5O2Y6SSQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Request for Timer-XL Pre-trained Weights

Excellent work! This repository looks like it was designed for Timer-XL. May I ask when you might be releasing the pre-trained weights? I would be incredibly grateful for any updates. Thank you very much.

Thanks for your interest! We are scheduled to release the relevant checkpoint.


Fix timezone typo refs: https://github.com/mattermost/docker/issues/56

Summary

Hello @metanerd , @mrckndt , @cpanato
This issue is to fix a typo in docker-compose.yml and docker-compose.nginx.yml introduced in my previous PR #52.
I'm very sorry for this typo in the push.
I ran docker-compose -f docker-compose.yml -f docker-compose.nginx.yml config to validate and I can see that the environment variable TZ is correctly interpolate.
And it respect https://docs.docker.com/compose/environment-variables/#pass-environment-variables-to-containers
Ticket Link

Fixes https://github.com/mattermost/docker/issues/56

@metanerd the PR #55 is not needed like this one solve the problem 😃


(Getx5) Play animation with Obx

Is your feature request related to a problem? Please describe.
The animation does not play when the value of obs changes.
Describe the solution you'd like
I think you need an option to run an animation when the value changes.
Describe alternatives you've considered
I tried making a sample.
I think you can tell what you want just by looking at the logic.
class TestPage extends GetView {
  List<int> datas = [0, 1, 2, 3, 4, 5];
  Rx<int> curSelect = 0.obs;
  @override
  Widget build(BuildContext context) {
    return Column(
        children: datas.map((e) {
      return Obx(() {
        var bselect = curSelect.value == e;
        return ElevatedButton.icon(
          onPressed: () {
            curSelect(e);
          },
          icon: FlutterLogo(),
          label: Text("${e}"),
        ).scale(begin: 1, end: bselect ? 0.8 : 1, duration: 100.milliseconds);
      });
    }).toList());
  }
}

Thanks for developing such a great library.

I need this


fix(v7): improve SubmissionError detection

Now event after obfuscation, or importing SubmissionForm
from a different context, isSubmissionError will return true
only for SubmissionError
Closes #4092
Closes #4162

Codecov Report

Merging #4653 into v7 will not change coverage by %.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                v7     #4653   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           72        72
  Lines         1666      1668    +2
=========================================
+ Hits          1666      1668    +2

Impacted Files
Coverage Δ

src/actions.js
100.00% <ø> (ø)

src/SubmissionError.js
100.00% <100.00%> (ø)

src/handleSubmit.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee74c6e...100f2ed. Read the comment docs.


Convert ratio of ToBigInt values to f64

Performs the division with integer arithmetic, and rounds
before performing an exact cast to float. This avoids any
issues with rounding.
General method referenced from https://stackoverflow.com/questions/33623875/converting-an-arbitrary-precision-rational-number-ocaml-zarith-to-an-approxim.
Partially fixes #4 (no support for f32 conversion currently).

Try running ci/test_full.sh before pushing. This will test your code very similarly to how Travis CI tests it. We should probably add this instruction to the readme, or a contributing.md.
It seems like your code depends on std. This crate supports nostd. If you can make it work with FloatCore, that would be great, but it seems like that isn't possible with your algorithm. If you just want CI to work, try throwing in some #[cfg(feature = "std")]s.

Ok, I'll make sure that passes.
Given that this code needs BigInts, and num-bigint seems to have a hard dependency on std, does it make sense to try and convert it to FloatCore?

You need #[cfg(feature = "bigint")] at least. If you're using any of f64's methods that aren't in core, then we should explicitly require "std" too, as num-bigint may someday work with only core and alloc. FloatCore is only relevant if you're using generic Float, but I think not.

Ok that makes sense, I'll add both feature flags.
I think most of what I use is actually in core, except for exp2. It could potentially be replaced by a hand-rolled solution, but I don't think it's really worth it until we actually get std-free BigInts.

@maxbla I agree with your comments above, I've pushed a new revision which handles both 16-bit architectures and arbitrarily wide usizes. Thanks for having taken the time to look at this!

@cuviper, @hauleth, it looks like you guys have merge rights on this repo, would you have time to give this a look?

I've moved a bigint-based unit test to the doctests to show the possibility of using BigInts. Does anyone have time to take another look at the review?

Sorry, yes, I mean to give this a deeper review, but haven't gotten to it yet. It just came up in #54 too -- is there a reason you added a new method instead of implementing ToPrimitive as a whole?

No particular reason—it's more work to implement all of ToPrimitive, I guess 😛. This code can easily enough be extended to f32s (a particularly trivial implementation being to cast the f64 down), but if possible I'd rather merge this first.
I do have a small reason for not doing the full ToPrimitive, which is that it's not clear to me what the exact semantics of ToPrimitive are. Should None be returned only when the value overflows? Or when it's not exactly representable? We should probably document this in the trait documentation.

This code can easily enough be extended to f32s (a particularly trivial implementation being to cast the f64 down)

FWIW, the default ToPrimitive::to_f32 already does this. The only required methods are to_i64 and to_u64, and the rest should only be implemented if you can do a better job than the naive default. (e.g. a more precise to_f64 as here, or to_u128 that actually uses more bits)

but if possible I'd rather merge this first.

The design of public API is important though, because we'll be stuck with it. I think ToPrimitive is probably the better approach. Maybe we can do both (as discussed here), but if so I'd want to make sure their use is a close as possible, without weird idiosyncrasies between the two options. The surest way to do that is to implement one in terms of the other.

I do have a small reason for not doing the full ToPrimitive, which is that it's not clear to me what the exact semantics of ToPrimitive are. Should None be returned only when the value overflows? Or when it's not exactly representable? We should probably document this in the trait documentation.

Sure, we can and should enhance docs -- the current semantics of the primitive implementations are that they only return None for overflow, or for completely unrepresentable values like NaN to int. Float to integer returns the same value that an as cast would, truncated toward zero.

Ok, that makes sense. I'll put out a new version that implements
ToPrimitive.
Le mer. 17 juil. 2019 à 12:46, Josh Stone<EMAIL_ADDRESS>a
écrit :

This code can easily enough be extended to f32s (a particularly trivial
implementation being to cast the f64 down)
FWIW, the default ToPrimitive::to_f32 already does this. The only
required methods are to_i64 and to_u64, and the rest should only be
implemented if you can do a better job than the naive default. (e.g. a more
precise to_f64 as here, or to_u128 that actually uses more bits)
but if possible I'd rather merge this first.
The design of public API is important though, because we'll be stuck with
it. I think ToPrimitive is probably the better approach. Maybe we can do
both (as discussed here
https://users.rust-lang.org/t/crates-that-use-the-inherent-trait-method-pattern/30381),
but if so I'd want to make sure their use is a close as possible, without
weird idiosyncrasies between the two options. The surest way to do that is
to implement one in terms of the other.
I do have a small reason for not doing the full ToPrimitive, which is
that it's not clear to me what the exact semantics of ToPrimitive are.
Should None be returned only when the value overflows? Or when it's not
exactly representable? We should probably document this in the trait
documentation.
Sure, we can and should enhance docs -- the current semantics of the
primitive implementations are that they only return None for overflow, or
for completely unrepresentable values like NaN to int. Float to integer
returns the same value that an as cast would, truncated toward zero.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-num/num-rational/pull/52?email_source=notifications&email_token=AAA6TWUFROYNX4NOMNA7LCLP75EG3A5CNFSM4H2HMRA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2FAMXI#issuecomment-512362077,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAA6TWU3773XNFPNUI3PXETP75EG3ANCNFSM4H2HMRAQ
.

I've pushed a version with ToPrimitive, please let me know what you think.

@cuviper, @hauleth, let me know how the CR looks when you have time. I'm happy to make further changes if needed.

If the original author doesn't makes the suggested changes, I'd be happy to drag this PR to the finish line.

Hey sorry, I think I missed the review notification. @maxbla if you have time feel free to take over, otherwise I can take a look this weekend.

I would be happy for you to make the suggested changes. I only offered because it looked like you were done.

Yeah if you have time to get started before this weekend go for it!

I've implemented the suggested changes:

If big ints and std are available, use that to convert any Ratio of Clone + Integer + ToPrimitive + ToBigInt types
Otherwise, ratios of primitive integer types ≤ 32 bits are now always convertible to f64 by converting the numerator and denominator to f64 directly. Ratios of u64 and i64 are convertible if std is available using the same algorithm as BigInt conversion, and using i128 as the supporting type for shifts.

Looks great, thanks!
bors r+


repo structure

Seeing the growing COMPASS repo, I am thinking of the following changes:

rename configuration files from cslc_s1.yaml to s1_cslc.yaml, to be consistent with the script name s1_cslc.py
move schemas and defaults from within utils to the same level as utils for shoter path, since users will check them frequently
create a bin directory for executables, like s1_cslc.py, as they are really executable scripts. Update: we could add entry_points for executables, without moving them to a bin folder.

These lead to a structure as below:
/COMPASS
    /bin
        s1_cslc.py
        s1_gslc.py
    /src/compass
        s1_rdr2geo.py
        s1_geo2rdr.py
        s1_resample.py (renamed from s1_resample_burst.py)
        ...
        /utils
            helpers.py
            geo_grid.py (renamed from geogrid.py)
            radar_grid.py (renamed from reference_radar_grid.py)
            runconfig.py
            ...
        /defaults
            s1_cslc.yaml (renamed from cslc_s1.py)
            s1_gslc.yaml (renamed from geo_cslc_s1.yaml)
        /schemas
            s1_cslc.yaml
            s1_gslc.yaml
    /tests
        ...

Let me know what do you think please @LiangJYu @vbrancat @hfattahi .

I like the idea. For OPERA we chose the term CSLC to represent Coregistered SLC in general regardless if they are in radar or geo-coordinates. If we want to avoid confusion in that regard, then I suggest to use:
s1_cslc_radar.py
s1_cslc_geo.py

That being said, the name that I really like for GSLC is geocode_slc.py

That being said, the name that I really like for GSLC is geocode_slc.py

I assume you meant s1_geocode_slc.py? I like it a lot too.
If the geocode SLC executable script can be as short as the current s1_cslc.py, we can add merge it into s1_cslc.py and add an option in the yaml file to choose between geo or radar grid. That would be even simpler. And we could keep one yaml file also, instead of two.

I like the changes. A few questions/comments:
How does bin get installed? I have no idea and an explanation would be very useful. I've been installing COMPASS into my conda env and running with python -m and would like to learn more.
Regarding the common executable, were you thinking the following?
/COMPASS
    /bin
        s1_cslc.py (runconfig input determines geo or radar coordinate processing path)
    /src/compass
        s1_rdr2geo.py
        s1_geo2rdr.py
        s1_resample.py (renamed from s1_resample_burst.py)
        s1_geocode_slc.py (renamed from geo_cslc.py)
        ...
        /utils
            helpers.py
            geo_grid.py (renamed from geogrid.py)
            radar_grid.py (renamed from reference_radar_grid.py)
            runconfig.py (combination of both runconfig.py's)
            ...
        /defaults
            s1_cslc.yaml (renamed from cslc_s1.yaml and merged from 2 current defaults)
        /schemas
            s1_cslc.yaml (merge of 2 current schemas)
    /tests
        ...

I like the cleanliness and the additional logic doesn't seem too troublesome. I also like the descriptive clarity of current verbose structure.

I think the run config for radar and geo slc have fundamental differences which we only introduce un-necessary work and complication to the workflow for gaining little or nothing. I suggest we keep the cslc workflows separate for geo and radar coordinates.

We could make scripts available on the command line using entry_points in setup.cfg. The bin folder is actually not needed, so that makes things simpler.

I like the changes and the suggestions given above. My preference is that the repo re-organization is done after the geocoded burst PR gets merged (less work in addressing conflicts)

@yunjunz I would like to close this issue. Will you take care of this? Now is a good time to re-organize the repo before we submit other PRs.

Yes, I will issue a PR soon.


This section and the following sections, up to and including the duplicate "Authenticate the client" section -- aside from the "Configure TypeScript", if that's necessary -- should be removed to match Java's README.

          This section and the following sections, up to and including the duplicate "Authenticate the client" section -- aside from the "Configure TypeScript", if that's necessary -- should be removed to match [Java's README](https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/keyvault/azure-security-keyvault-administration/README.md).

Originally posted by @mccoyp in https://github.com/Azure/azure-sdk-for-js/pull/22814#discussion_r939450028

Hi @Amarakhaid -- I'm not sure if you meant to open this issue in this repository, since the original comment referred to JS and Python's azure-keyvault-administration README already aligns with the suggested change. I'll close this issue for now, but please feel free to clarify if this was intended for another repository or if there's context missing here. Thank you!


README updated with how to build and run instructions

I updated the README with the build instructions from #108

This PR got all commits mixed in. I'm gonna create separate branches and create two PRs. Sorry for confusion.


Desktop fullpage screenshots are rendered as on the tablet view for a certain page element

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.20.0
Platform / OS version: macOS Mojave 10.14.6 (18G103)
Node.js version: v12.14.1

What steps will reproduce the problem?
A page with the main menu that has a different view on the mobile, tablet and desktop screens. Here is the view for the desktop view:

The tablet view:

The difference is that the label under the icons is hidden on the tablet devices. It's done by the following styling:
@media all and (min-width: (769px)) and (max-width: 992px),
        all and (min-width: (769px)) and (orientation: portrait) {
        span:not(.ui-icon) {
            display: none;
        }
    }
}

What is the expected result?
I want to see the menu with icons and labels on the desktop screens (1024x1000 or 1440x1000 screens):

What happens instead?
During page.screenshot({fullPage: true}), Puppeteer takes a screenshot with 1024x1000 and 1440x1000 resolutions, but the menu looks like on the tablet for some reason:

Please let me know if you have any question or clarification to help here.

Issues that may be related:

https://github.com/puppeteer/puppeteer/issues/5411 - fullPage changes viewport size or changes element positions
https://github.com/puppeteer/puppeteer/issues/2272 - Clipped screenshot differs from the fullpage one in content


Merge rampup to berkeley (30 jan 2024)

Just a merge, no conflicts arose (git merged automatically)
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

!ci-build-me

!approved-for-mainnet

!ci-build-me

!approved-for-mainnet

!ci-nightly-me


Low priority: Enhancement request - less wasted white space would be nice on DAI display screen

It would be really nice to have a wider area for display of utterances.  There is a huge amount of wasted space on the screen, and yet the user has to scroll through many utterances to see them...
This is from my laptop, so it is not relying on a large screen.  About 40% of the horizontal space is wasted.

Correction:  When I view at "actual size" on my laptop, there is no extra space, actually.
Would be great if the width of the column displaying the utterances (and therefore the width of the table itself) could be adjustable :-)   But maybe this is too much to ask.  In which case, never mind...
THANKS.
In any case, LOW priority !!
thanks again.


DoomFist: Empowered Concept

In GitLab by @DpsDoomMain on Sep 27, 2023, 18:20
• Currently DoomFist is unable to have his Empowered status.
• Preferably DoomFist should have a Empowered status but he can use it on all abilities.
• For Doomfist’s Seismic Slam it should increase the charge rate of the slam by a 1.75x, increase the max damage to 150 and it should be given a Increased area of effect by 1.25x
• For Doomfist’s Rising Uppercut he should get a increased area of effect by 1.5x and the damage should be increased by 50+ adding up to a total of 100 damage
• For Doomfist’s Rocket Punch it should be given the shockwave effect back.
—————————————————————
After Reviewing:
• For Doomfist’s  Arch Slam it should increase the charge rate of the slam by a 1.5x, increase the max damage to 150 and it should be given a Increased area of effect by 1.25x.
• For Doomfist’s Indicator Slam it should increase the charge rate by 1.5x. Increase the maximum range of slam by 1.5x and increase the speed by 2x in order to combat the multiplier on charge rate.
• For Doomfist’s Rising Uppercut he should get a increased area of effect by 1.25x and the damage should be increased by 25+ adding up to a total of 75 damage
• For Doomfist’s Rocket Punch it should be given the a damage increase of 200 on impact and 200 on Contact with Wall.

In GitLab by @DpsDoomMain on Sep 27, 2023, 18:20
made the issue visible to everyone

In GitLab by @DpsDoomMain on Sep 27, 2023, 18:34
locked this issue

In GitLab by @DpsDoomMain on Sep 27, 2023, 18:34
unlocked this issue

Kinda sounds op if you ask me.
Also, I don't think we should change ow1 heroes. The point is to extend ow1 not change it.

moved from ow1_plus_plus#8


possible typo fix on database query type

This might be a typo, because stringedKey value is of type string and database query wants BIGINT. Still works at present state if user presents the "key" as integer - or is this intentional?

good catch


Move some code from Shelley to Core

There is a lot of code inside https://github.com/input-output-hk/cardano-ledger/tree/master/eras/shelley/impl which should be moved into https://github.com/input-output-hk/cardano-ledger/tree/master/libs/cardano-ledger-core

I think we can indeed close it. (we might move other stuff later, but we can do that as it comes up without this issue).


org.postgresql.util.PSQLException: 10 Authentication is not supported.   (scram-sha-256)

DBeaver: 4.1.13
Description:
Trying to connect to one PostgreSQL 10 version database set with scram-sha-256 authentication using DBeaver,  but getting  the following error:
org.postgresql.util.PSQLException: 10 Authentication  is not supported. Check you have setup pg_hba..conf  ...
The same connection works fine if database authentication is set to md5 (or others authentication types).
So, DBeaver seems to not work with new PostgreSQL 10 scram-sha-256 authentification.
Is there any plan to allow DBeaver to work with scram-sha-256 PostgreSQL 10 authentication mode ?If yes any idea when it will be available ?
Many thanks for yoru help.
Best Regards,
Jean-Pierre

DBeaver uses the Postgres JDBC driver, which, from what I can tell, does not have a SCRAM-SHA-256 authentication method available yet (see this link). Although, there appears to be a patch in the works, but it's not ready yet.

Thanks a lot your answer.
We'll wait for the JDBC driver correction.
I'm closing this issue and thanks again for your help.
Best Regards,

Any updates on this closed case, can se that other jdbc driven tools supports scram-sha-256 but i  can't get dbeaver to work with password encryption scram-sha-256.
It's works fine with MD5.
Im using dbeaver 5.2.1
Error message:
The authentication type 10 is not supported. Check that you have configured the pg_hba.conf file to include the client's IP address or subnet, and that it is using an authentication scheme supported by the driver.

According to https://wiki.postgresql.org/wiki/List_of_drivers JDCB should support SCRAM from version 42.2.0.
I use JDCB v42.2.5 (on DataGrip and DBeaver), but can't connect to the server when change authentication method from md5 to scram-sha-256. It says:
FATAL: password authentication failed for user "postgres"
Same issue on pgAdmin 4 v3.2.

So we're at Postgres 13, 2020 is almost over and this still doesn't work. Maybe JDBC is not the right technology to use here if it's unmaintained for years?
Anyway, I've followed the error message and changed Postgres' hb_pga.conf to "md5", restarted the service. Still can't log in. It works on another machine with Postgres 12 but not this fresh installation of the latest bits.

The indicated patch was accepted years ago.  Use DBeaver's Driver Manager to use/get a newer version of JDBC.

for non-prd: pg_hba.config
local   all             all                                     trust

This worked for me

go to Database / Driver Manager
Find Postgres and click edit
Click the Libraries tab and click Download/Update


Make BACKUP_PERIOD and BACKUP_RETENTION configurable parameters.

Rancher Version:v1.1.3
K8s system stack template version - v1.2.4-rancher9 from https://github.com/llparse/testing-catalog
Currently BACKUP_PERIOD and BACKUP_RETENTION are hardcoded in the template. They should be made as configurable parameters.
If BACKUP_PERIOD and BACKUP_RETENTION are made variables , user will be prompted  for these values when upgrading to this K8s template.
Currently during  K8s  environment, user is not presented with the K8s templates details to allow for Users to be able to provide values when presented with questions.

Added questions for BACKUP_PERIOD and BACKUP_RETENTION to the template.
URL: https://github.com/llparse/testing-catalog
Branch: config-backup-param
The questions work when launched as a cattle template. In kubernetes environment upgrade scenario, user can select the template version but the screen is stuck in a loading phase.

To configure these parameters in a fresh environment would require the infra catalog - is this slated for 1.2.0?

Tested with Rancher Version: v1.2.0-pre4-rc3 and K8s 1.4 version from - https://github.com/rancher/infra-catalog
User is now provided with BACKUP_PERIOD and BACKUP_RETENTION parameters that can be overridden by users.
Logged bug for including more field description  - https://github.com/rancher/rancher/issues/6295


Crystal Picnic no longer available on steam

From steam page:   'Notice: At the request of the publisher, Crystal Picnic is no longer available for sale on Steam.'
Website is also down
Is on sale on itch.io

Monster RPG 2 has same issue.

Good catch for this two games 👍 I'm gonna keep them in the list with their link to Steam, but explain that it's not available anymore on the platform.

Resolved in the last commit, thanks again for your contributions !


Add sleet probability acceptance test

Add pytest conversion of BATS test
I'd recommend changing the sleet/basic KGO directory to sleet-probability/basic to follow the convention that KGO directory names match CLI names. I haven't made this change in this branch/PR, as it will need a corresponding change in the KGO files you've prepared.

I have changed the kgo directory to sleet-probabiliy/basic so that it follows convention. So hopefully if you change it in your PR it will work too. Thanks for this @tjtg 👍


add scrollBy

Hey guys!
First awesome lib! Thanks! I just wanted to create a component where I missed scrollBy. According to MDN, what do you think about this?

Perfectly executed PR :smile: Thanks! Seems odd that this didn't already exist, but I guess it was just forgotten somehow.


Use LUKSO Web Components for styling

Request
ERC725 Tools should use LUKSO's web components to style all pages, aligning with the corporate design
Current Behaviour
Regular Bulma styling + some component adjustments

I think current design is ok. Bulma is easy to use. But a mixture of both could do

Indeed. The request was coming from Tim & Dominik, as we have pre-build style components for our other web pages that could easily be integrated.

This is low prio

We don't need that really, i will close.


Acknowledgements for Persistent Subscription

Hi, how can i acknowledgement event for persistent subscription using this client?
i sent event to subscription.

Each time, when i connect to subscription i get this Event.
In doc written, that last param in connectToPersistentSubscription is auto-ack (by default its true) and when handler for event return Promise resolve it should accept event and don't send it again.
i have code example

const esClient = require('node-eventstore-client');

let esConnection = null;

const start = async () => {
  console.log('start');
  const connSettings = {};  // Use defaults
  esConnection = esClient.createConnection(connSettings, "tcp://eventstore:1113");
  await esConnection.connect();

  const connectedPromise = new Promise((resolve, reject) => {
    esConnection.once('connected', resolve);
    const timeoutMs = 5000;
    const errorMsg =
      'Event Store connection failed after 5000ms timeout';
    const error = Error(errorMsg);
    setTimeout(() => reject(error), timeoutMs);
  });
  const tcpEndpoint = await connectedPromise;
  console.log('Connected to eventstore');

  await connectToSubscription();
};

const subscriptionDropped = () => {
  console.log('dropped');
};

const connectToSubscription = async () => {
  const credentials = new esClient.UserCredentials('admin', 'changeit');
  try {
    console.log('connectToSubscription start');
    const subscription = await esConnection.connectToPersistentSubscription(
      'TEST',
      'test',
      (subscription, event) => {
        console.log(JSON.parse(event.originalEvent.data.toString()));
        return Promise.resolve();
        },
      subscriptionDropped,
      credentials,
    );
    console.log('connectToSubscription end');
    return subscription;
  } catch (e) {
    console.log(e);
  }
};

start();

what i do incorrect? I tried to use acknowledge method manually, but no results..

It works as expected.
Events are auto-acknowledged, you can see it in the UI it says 0 in flight meaning they have been acked by the client.
When I run the code you provided more than once, in the subsequent runs I don't receive events received (and acked) from previous runs.

After some magic it works, thanks


Windows Server 2022 GA

I just realized this is not here yet :). See more here: aka.ms/ws2022gacontainerblog.

thx


Batched issues from Gabor

General comments

start_time/startTime and end_time/endTime are used inconsistently both in the patterns and in the text

the name for the ids for persons p1 (and p2) is inconsitent: "p1Id", "pid1" are used.

patterns: when having multiple nodes on one end of an edge, it is worth assigning different names to these nodes
good examples:

complex-read / 6: has src1, ..., src3
complex-read / 11: has l1c1, l1c2, ..., l1c3, and so on

bad examples:

simple-read / 2: has dst, dst, dst
simple-read / 3: has src, src, ...
complex-read / 7: has src/dst repeated
complex-read / 8: has dst1, dst1, ..., dst1; dst2, ...
complex-read / 9: has up/down repeated
complex-read / 10: has m repeated

Comments for specific queries/operations
complex-read / 2:

"accounts" should be singular (account)

complex-read / 5:

if every row in the result encodes a path, the name of the result attribute should be "path" and its description should be "a transfer trace"

complex-read / 7:

numSrc, numDst: are these numbers counted with 'count distinct'?

complex-read / 8:

the term "inflow" is not defined and it is only used for describing the results
the pattern should illustrate/describe that the traversal can end at any level (dst1, dst2, dst3)

complex-read / 10:

what should be the result if there are no matches for edge1 and/or edge2?

complex-read / 12:

nitpicking but if everything else query used the terms edge1, edge2, ...; why use g1, g2, ..., gN here?
a person can have multiple loans, maybe this should be reflected in the pattern as well?

simple-read / 2:
in the pattern:

the undirected "edge2" in the middle does not make sense to me
the second "edge1" should be called "edge2"
in the pattern, "sum(edge1.amount)" in the last row should be "sum(edge2.amount)"

simple-read / 3:

what should be returned if there are no edges between src and dst and the result would be 0/0?

simple-read / 6:

result description doesn't make sense. accounts on their own do not have srcs, their incoming transfer edges do.

simple-read / 6:

the RESULT in the pattern should say "collect(x.id)" instead of "collect(x)"

write / 3, 8, 9:

the edges (transfer, deposit, repay) edges are missing the plus sign indicating that they are newly created

simple-read / 6, 7, 8:

the name of result fields that return the collection of multiple IDs should have a plural name, e.g. "accId" should be called "accIds"

write / 8:

the node "Loan" should be named "loan: Loan" as its bound to a single node by the loanId parameter
"amount <- amount" in the pattern is inconsistent, other patterns use "amount <- amt"

Typo
The word "gurantee" is misspelled in the patterns of read-write / 3 and write / 13 (maybe also in other places).
currentTime
Several queries use the "currentTime" parameter. Where does the value of this parameter come from: the data set, the driver (e.g. Java's System.currentTimeMillis()), or the DBMS (e.g. Cypher's date() function)? If it's a parameter, the patterns should indicate it as such with ${currentTime}.
Path queries with conditions over multiple edges
Queries that require "all timestamps in the transfer trace are in ascending order" or the "upstream" edge are difficult to explain in plain Cypher (or GQL or SQL/PGQ) because they require some memory.
One can think of this as an extra choke point which requires support for the category of queries "Regular expression with memory" as described in this paper: https://dl.acm.org/doi/abs/10.1145/2274576.2274585.
Even if it's not defined as a choke point, it's worth including this reference in the specificiation.
More comments

It should be mentioned that "truncation" is a form of deterministic sampling

General comments

start_time/startTime and end_time/endTime are used inconsistently both in the patterns and in the text

Done

the name for the ids for persons p1 (and p2) is inconsitent: "p1Id", "pid1" are used.

patterns: when having multiple nodes on one end of an edge, it is worth assigning different names to these nodes
good examples:

complex-read / 6: has src1, ..., src3
complex-read / 11: has l1c1, l1c2, ..., l1c3, and so on

bad examples:

simple-read / 2: has dst, dst, dst
simple-read / 3: has src, src, ...
complex-read / 7: has src/dst repeated
complex-read / 8: has dst1, dst1, ..., dst1; dst2, ...
complex-read / 9: has up/down repeated
complex-read / 10: has m repeated

Comments for specific queries/operations
complex-read / 2:

"accounts" should be singular (account)

complex-read / 5:

if every row in the result encodes a path, the name of the result attribute should be "path" and its description should be "a transfer trace"

complex-read / 7:

numSrc, numDst: are these numbers counted with 'count distinct'?

complex-read / 8:

the term "inflow" is not defined and it is only used for describing the results
the pattern should illustrate/describe that the traversal can end at any level (dst1, dst2, dst3)

complex-read / 10:

what should be the result if there are no matches for edge1 and/or edge2?

complex-read / 12:

nitpicking but if everything else query used the terms edge1, edge2, ...; why use g1, g2, ..., gN here?
a person can have multiple loans, maybe this should be reflected in the pattern as well?

simple-read / 2: in the pattern:

the undirected "edge2" in the middle does not make sense to me
the second "edge1" should be called "edge2"
in the pattern, "sum(edge1.amount)" in the last row should be "sum(edge2.amount)"

simple-read / 3:

what should be returned if there are no edges between src and dst and the result would be 0/0?

simple-read / 6:

result description doesn't make sense. accounts on their own do not have srcs, their incoming transfer edges do.

simple-read / 6:

the RESULT in the pattern should say "collect(x.id)" instead of "collect(x)"

write / 3, 8, 9:

the edges (transfer, deposit, repay) edges are missing the plus sign indicating that they are newly created

simple-read / 6, 7, 8:

the name of result fields that return the collection of multiple IDs should have a plural name, e.g. "accId" should be called "accIds"

write / 8:

the node "Loan" should be named "loan: Loan" as its bound to a single node by the loanId parameter
"amount <- amount" in the pattern is inconsistent, other patterns use "amount <- amt"

Typo
The word "gurantee" is misspelled in the patterns of read-write / 3 and write / 13 (maybe also in other places).

Done

currentTime
Several queries use the "currentTime" parameter. Where does the value of this parameter come from: the data set, the driver (e.g. Java's System.currentTimeMillis()), or the DBMS (e.g. Cypher's date() function)? If it's a parameter, the patterns should indicate it as such with ${currentTime}.
Path queries with conditions over multiple edges
Queries that require "all timestamps in the transfer trace are in ascending order" or the "upstream" edge are difficult to explain in plain Cypher (or GQL or SQL/PGQ) because they require some memory.
One can think of this as an extra choke point which requires support for the category of queries "Regular expression with memory" as described in this paper: https://dl.acm.org/doi/abs/10.1145/2274576.2274585. Even if it's not defined as a choke point, it's worth including this reference in the specificiation.
More comments

It should be mentioned that "truncation" is a form of deterministic sampling

TODO: re-generate and crop the diagrams.


Failed in fastlock.cpp:303:

Hi. Suddenly there was an issue and make our KeyDB down. Our log say that issue is in fastlock.cpp:303:. Is there something wrong?
BTW I use KeyDB version 5.0.2, stand alone

Nov 15 11:22:09 keydb-server keydb-server[95835]: keydb-server: fastlock.cpp:303: void fastlock_free(fastlock*): Assertion `(lock->m_ticket.m_active == lock->m_ticket.m_avail) || (lock->m_pidOwner == gettid() && (lock->m_ticket.m_active == lock->m_ticket.m_avail-1))' failed.
Nov 15 11:24:41 keydb-server systemd[1]: keydb.service: Main process exited, code=killed, status=6/ABRT
Nov 15 11:24:41 keydb-server systemd[1]: keydb.service: Failed with result 'signal'.
Nov 15 11:24:44 keydb-server systemd[1]: keydb.service: Service hold-off time over, scheduling restart.
Nov 15 11:24:44 keydb-server systemd[1]: keydb.service: Scheduled restart job, restart counter is at 3.
Nov 15 11:24:44 keydb-server systemd[1]: Stopped keydb service.

Hi @fourirakbar
There should be more debugging information in the log.  Can you provide me the debugging information there?  There should be a line that says: === KEYDB BUG REPORT START: Cut & paste starting from here ===
Send everything after that.

Hi @JohnSully
Here 10 lines before the assert failure, I got it from /var/log/syslog

ov 15 09:04:46 keydb-server snapd[129121]: storehelpers.go:436: cannot refresh: snap has no updates available: "core", "google-cloud-sdk"
Nov 15 09:04:46 keydb-server snapd[129121]: autorefresh.go:397: auto-refresh: all snaps are up-to-date
Nov 15 09:17:01 keydb-server CRON[199193]: (root) CMD (   cd / && run-parts --report /etc/cron.hourly)
Nov 15 09:23:31 keydb-server systemd[1]: Starting Message of the Day...
Nov 15 09:23:33 keydb-server 50-motd-news[199228]:  * Kata Containers are now fully integrated in Charmed Kubernetes 1.16!
Nov 15 09:23:33 keydb-server 50-motd-news[199228]:    Yes, charms take the Krazy out of K8s Kata Kluster Konstruction.
Nov 15 09:23:33 keydb-server 50-motd-news[199228]:      https://ubuntu.com/kubernetes/docs/release-notes
Nov 15 09:23:33 keydb-server systemd[1]: Started Message of the Day.
Nov 15 10:17:01 keydb-server CRON[199563]: (root) CMD (   cd / && run-parts --report /etc/cron.hourly)
Nov 15 11:17:01 keydb-server CRON[199888]: (root) CMD (   cd / && run-parts --report /etc/cron.hourly)

Also I will try upgrade to latest version keydb (5.1.1)

Hi @fourirakbar those are systemd logs which aren't the same as KeyDB's log.  I need the log of KeyDB itself.  It looks like you are using docker so the following command should work:
docker logs keydb-server
Note that I'm guessing at the docker container name from your systemd logs.  You can use docker ps to find it if I guessed wrong.

Hi @JohnSully , there isn't any log related to KeyDB. By the way, I'm not running KeyDB using docker, I use standard systemctl. I think I also wrong config in systemctl keydb about logging..
Now I try upgrade my KeyDB version to 5.1.1
Thanks!


Drop dbus-python and move to Jeepney

dbus-python is clunky and crusty
Remove glib dependency which is probably on the road to deprecation.

850435a


Nova shows only loading animation

Menu Builder shows a migration on top and all tables shows only an loading animation after installing menu builder

Failure comes from other wrong config file


Mangement plane PR triggers data-plane CI

What I see
Mgmt-plane-only PR triggers data-plane CI, for example #11625 , so if there's error in data-plane, the pr is blocked (check-enforcer demands all CI to pass).
Question
I think in general the failure of data-plane CI should not block mgmt-plane PRs, but I want to here your voice.
Proposed solution

The reviewer tells check enforcer it's OK to ignore the failed data-plane checks
Update data-plane CI to exclude mgmt-plane projects

cc @weshaggard @mitchdenny @erich-wang @chidozieononiwu

cc @allenjzhang
This is being triggered because we don't limit the path filtering to just the data-plane library at https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/containerregistry/ci.yml#L22.
We have a couple options here:

We could update our script https://github.com/Azure/azure-sdk-for-net/blob/master/eng/scripts/Update-Mgmt-Yml.ps1 which correctly sets up the mgmt path filters to also update the path filters in the ci.yml files as well.
We could simply let them continue to trigger and if they are failing for other reasons ignore the failures and proceed with check-in.
We could work to ensure both mgmt and data-plane stay clean and always passing.

I was chatting with @allenjzhang about the track 2 mgmt libraries and for those I would like to go with option 3. However for the existing track 1 mgmt libraries perhaps we can go with option 1. It shouldn't be too hard to alter that script to adjust all these.

This issue is fairly stale by now and the T1 packages are deprecated with T2 reaching GA.   I'm going to close this out and we can address any specific cases on an as-needed basis.


Don’t bundle Gateway API CRDs

Welcome!

[x] Yes, I've searched similar issues on GitHub and didn't find any.
[x] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you expect to see?
I’m doing some greenfield work and trying to take advantage of all the Gateway API goodness Traefik, Argo CD, Argo Rollouts, Linkerd, and others are doing, but have found that Traefik bundling in the Gateway API CRDs in the helm charts is both an anti pattern and problematic. The other projects I’ve looked at all seem to have you pull them in as a prerequisite. This allows the end user to pull in whatever works best for the combination of tools deployed.
For example, here’s what prompted this issue: I have a cluster with

Traefik + external-dns + cert-manager for north/south traffic and
Linkerd + cert-manager for east/west traffic and
Argo CD managing everything

Traefik & Argo CD both have Gateways that use certs from cert-manager, and Argo CD is using HTTPRoutes.
I’m also working to deploy an application stack that will utilize Linkerd + GRPCRoutes inside the cluster for observability and gRPC load balancing.
The problem with the bundled CRDs is that Linkerd still uses Gateway API v1alpha2 for compatibility with Google Kubernetes Engine (GKE).
Thus, to get a version of Linkerd with the features I need (including support for Native Sidecars so that Jobs like the ones in Argo CD itself work correctly) and Traefik to work together, I am currently forced to use a custom build of the Traefik helm chart with the Gateway API manifest replaced with the experimental 1.1.0 version as the stable version doesn’t expose the v1alpha2 variant (just beta and stable ones).
https://github.com/traefik/traefik-helm-chart/issues/1141 is one possible solution to this if setup like https://github.com/linkerd/linkerd2/tree/main/charts/linkerd-crds as they allow toggling off the bundled Gateway API CRDs by setting enableHttpRoutes: false like mentioned at https://linkerd.io/2.16/features/httproute/
Lastly, for reference, I posted about this at https://community.traefik.io/t/install-traefik-w-o-gateway-api-crds/24712/ too.

Same issue here. I'd like to continue applying future Traefik security updates despite being on GKE, please.