location is callback,but the status is INTULocationStatusTimedOut

requestLocationWithDesiredAccuracy:(INTULocationAccuracy)desiredAccuracy
timeout:(NSTimeInterval)timeout
block:(INTULocationRequestBlock)block
I use this method the block is called and I got log "INTULocationManager: Location Request completed with ID: 1, currentLocation: <+39.89284587,+116.16985747> +/- 65.00m (speed -1.00 mps / course -1.00) @ 15/12/12 中国标准时间 上午10:10:48, achievedAccuracy: 3, status: 1",but the block status is INTULocationStatusTimedOut.

Same here.  On Simulator it rolls right through on INTULocationStatusSuccess.  On actual device though it gets location but calls the INTULocationStatusTimedOut.
I drop my delay from 10 down to 0.5 and I still get the location but it executes INTULocationStatusTimedOut.
iPhone 6 iOS 9.2.1 using latest XCODE.
Here is my LOG with timeout:0.5.

2016-02-19 15:21:11.463 app[9968:3870192] INTULocationManager: Changing location services accuracy level to: medium high.
2016-02-19 15:21:11.464 app[9968:3870192] INTULocationManager: Location services updates have started.
2016-02-19 15:21:11.464 app[9968:3870192] INTULocationManager: Location Request added with ID: 1
2016-02-19 15:21:11.948 app[9968:3870192] INTULocationManager: Location services updates have stopped.
2016-02-19 15:21:11.971 app[9968:3870192] INTULocationManager: Location Request completed with ID: 1, currentLocation: <+18.46254211,-69.94379034> +/- 65.00m (speed -1.00 mps / course -1.00) @ 2/19/16, 3:21:11 PM Atlantic Standard Time, achievedAccuracy: 3, status: 1

Here's my method call from viewDidLoad
-(void)fetchLocation {

    INTULocationManager *locMgr = [INTULocationManager sharedInstance];
    [locMgr requestLocationWithDesiredAccuracy:INTULocationAccuracyHouse
                                       timeout:0.5
                          delayUntilAuthorized:YES  // This parameter is optional, defaults to NO if omitted
                                         block:^(CLLocation *currentLocation, INTULocationAccuracy achievedAccuracy, INTULocationStatus status) {
                                             if (status == INTULocationStatusSuccess) {

                                                 CLLocationDegrees currentLatitude = currentLocation.coordinate.latitude;
                                                 CLLocationDegrees currentLongitude = currentLocation.coordinate.longitude;
                                                 NSLog(@"lat %f, long %f", currentLatitude, currentLongitude);

                                                 [self checkLicense];

                                                 // Request succeeded, meaning achievedAccuracy is at least the requested accuracy, and
                                                 // currentLocation contains the device's current location.
                                             }
                                             else if (status == INTULocationStatusTimedOut) {

                                                 CLLocationDegrees currentLatitude = currentLocation.coordinate.latitude;
                                                 CLLocationDegrees currentLongitude = currentLocation.coordinate.longitude;
                                                 NSLog(@"lat %f, long %f", currentLatitude, currentLongitude);

                                                 [self checkLicense];

                                                 // Wasn't able to locate the user with the requested accuracy within the timeout interval.
                                                 // However, currentLocation contains the best location available (if any) as of right now,
                                                 // and achievedAccuracy has info on the accuracy/recency of the location in currentLocation.
                                             }
                                             else {

                                                 CLLocationDegrees currentLatitude = currentLocation.coordinate.latitude;
                                                 CLLocationDegrees currentLongitude = currentLocation.coordinate.longitude;
                                                 NSLog(@"lat %f, long %f", currentLatitude, currentLongitude);

                                                 dispatch_async(dispatch_get_main_queue(), ^{
                                                     [progressView closeProgressDialog];
                                                 });

                                                 [self checkLicense];
                                                 // An error occurred, more info is available by looking at the specific status returned.
                                             }
                                         }];

}

so is this still a problem or not? Is any one looking into this?

there is nothing wrong, you need to read the comments in README

The timeout parameter specifies how long you are willing to wait for a location with the accuracy you requested. The timeout guarantees that your block will execute within this period of time, either with a location of at least the accuracy you requested (INTULocationStatusSuccess), or with whatever location could be determined before the timeout interval was up (INTULocationStatusTimedOut). Pass 0.0 for no timeout (not recommended).

on simulator, the location is SIMULATED and can be found very fast. on a device it takes a while. if you use a very short timeout and are asking for high accuracy location then on a device it may not have enough time to get the location with that accuracy.so you get INTULocationStatusTimedOut with the most accurate location that was possible to find. look at the achievedAccuracy in the block and you will see it is some lower accuracy than what you asked for.
@rjpalermo1 timeout is not a delay, you should use larger value if you don't need location immediately, OR use lower desired accuracy

I can't get my code to trigger inside any timeout I set on my device. The device is not moved between runs and the only value changed is the timeouts. Crude comparisons in apple maps shows my location within a couple of seconds. The code is:
       [locMgr requestLocationWithDesiredAccuracy:INTULocationAccuracyHouse
                                           timeout:10.0
                              delayUntilAuthorized:YES  // This parameter is optional, defaults to NO if omitted
                                             block:^(CLLocation *currentLocation, INTULocationAccuracy achievedAccuracy, INTULocationStatus status) {
                                                 if (status == INTULocationStatusSuccess) {
                                                     // Request succeeded, meaning achievedAccuracy is at least the requested accuracy, and
                                                     // currentLocation contains the device's current location.
                                                     [weakSelf foundLocation:currentLocation];
                                                 }
                                                 else if (status == INTULocationStatusTimedOut) {
                                                     // Wasn't able to locate the user with the requested accuracy within the timeout interval.
                                                     // However, currentLocation contains the best location available (if any) as of right now,
                                                     // and achievedAccuracy has info on the accuracy/recency of the location in currentLocation.
                                                     [weakSelf foundLocation:currentLocation];
                                                 }
                                                 else {
                                                     [weakSelf.navigationController.view makeToast:@"Did not find the location." duration:3.0 position:CSToastPositionBottom];
                                                 }
                                             }];

The results I have from my console:10 seconds
2016-07-02 15:28:55.248 Locator[2321:1582265] INTULocationManager: Changing location services accuracy level to: medium high.
2016-07-02 15:28:55.249 Locator[2321:1582265] INTULocationManager: Location services updates have started.
2016-07-02 15:28:55.249 Locator[2321:1582265] INTULocationManager: Location Request added with ID: 1
2016-07-02 15:29:05.235 Locator[2321:1582265] INTULocationManager: Location services updates have stopped.
2016-07-02 15:29:05.247 Locator[2321:1582265] INTULocationManager: Location Request completed with ID: 1, currentLocation: <+xx.xxxxxxxx,-1.46231728> +/- 1414.00m (speed -1.00 mps / course -1.00) @ 02/07/2016, 15:28:55 British Summer Time, achievedAccuracy: 1, status: 1
30 seconds
2016-07-02 15:31:31.502 Locator[2326:1583251] INTULocationManager: Changing location services accuracy level to: medium high.
2016-07-02 15:31:31.503 Locator[2326:1583251] INTULocationManager: Location services updates have started.
2016-07-02 15:31:31.504 Locator[2326:1583251] INTULocationManager: Location Request added with ID: 1
2016-07-02 15:32:01.488 Locator[2326:1583251] INTULocationManager: Location services updates have stopped.
2016-07-02 15:32:01.504 Locator[2326:1583251] INTULocationManager: Location Request completed with ID: 1, currentLocation: <+xx.xxxxxxxx,-1.47222044> +/- 165.00m (speed -1.00 mps / course -1.00) @ 02/07/2016, 15:31:55 British Summer Time, achievedAccuracy: 2, status: 1
60 seconds
2016-07-02 15:35:59.172 Locator[2331:1584376] INTULocationManager: Changing location services accuracy level to: medium high.
2016-07-02 15:35:59.173 Locator[2331:1584376] INTULocationManager: Location services updates have started.
2016-07-02 15:35:59.173 Locator[2331:1584376] INTULocationManager: Location Request added with ID: 1
2016-07-02 15:36:59.158 Locator[2331:1584376] INTULocationManager: Location services updates have stopped.
2016-07-02 15:36:59.195 Locator[2331:1584376] INTULocationManager: Location Request completed with ID: 1, currentLocation: <+xx.xxxxxxxx,-1.47218503> +/- 165.00m (speed -1.00 mps / course -1.00) @ 02/07/2016, 15:36:38 British Summer Time, achievedAccuracy: 2, status: 1
120 seconds
2016-07-02 15:41:58.923 Locator[2335:1586286] INTULocationManager: Changing location services accuracy level to: medium high.
2016-07-02 15:41:58.924 Locator[2335:1586286] INTULocationManager: Location services updates have started.
2016-07-02 15:41:58.924 Locator[2335:1586286] INTULocationManager: Location Request added with ID: 1
2016-07-02 15:43:58.903 Locator[2335:1586286] INTULocationManager: Location services updates have stopped.
2016-07-02 15:43:58.913 Locator[2335:1586286] INTULocationManager: Location Request completed with ID: 1, currentLocation: <+xx.xxxxxxxx,-1.47218809> +/- 165.00m (speed -1.00 mps / course -1.00) @ 02/07/2016, 15:43:58 British Summer Time, achievedAccuracy: 2, status: 1
180 seconds
2016-07-02 15:45:47.006 Locator[2339:1587492] INTULocationManager: Changing location services accuracy level to: medium high.
2016-07-02 15:45:47.008 Locator[2339:1587492] INTULocationManager: Location services updates have started.
2016-07-02 15:45:47.008 Locator[2339:1587492] INTULocationManager: Location Request added with ID: 1
2016-07-02 15:48:46.993 Locator[2339:1587492] INTULocationManager: Location services updates have stopped.
2016-07-02 15:48:47.009 Locator[2339:1587492] INTULocationManager: Location Request completed with ID: 1, currentLocation: <+xx.xxxxxxxx,-1.47222305> +/- 165.00m (speed -1.00 mps / course -1.00) @ 02/07/2016, 15:48:38 British Summer Time, achievedAccuracy: 2, status: 1
Back to 10 seconds
2016-07-02 15:57:54.362 Locator[2343:1589309] INTULocationManager: Changing location services accuracy level to: medium high.
2016-07-02 15:57:54.363 Locator[2343:1589309] INTULocationManager: Location services updates have started.
2016-07-02 15:57:54.363 Locator[2343:1589309] INTULocationManager: Location Request added with ID: 1
2016-07-02 15:58:04.340 Locator[2343:1589309] INTULocationManager: Location services updates have stopped.
2016-07-02 15:58:04.351 Locator[2343:1589309] INTULocationManager: Location Request completed with ID: 1, currentLocation: <+xx.xxxxxxxx,-1.47215569> +/- 65.00m (speed -1.00 mps / course -1.00) @ 02/07/2016, 15:57:54 British Summer Time, achievedAccuracy: 3, status: 1

Same code, different device (iPhone 6s versus iPad Air 2):
10 seconds
2016-07-02 16:23:44.518 Locator[1713:1225759] INTULocationManager: Changing location services accuracy level to: medium high.
2016-07-02 16:23:44.519 Locator[1713:1225759] INTULocationManager: Location services updates have started.
2016-07-02 16:23:44.519 Locator[1713:1225759] INTULocationManager: Location Request added with ID: 1
2016-07-02 16:23:54.506 Locator[1713:1225759] INTULocationManager: Location services updates have stopped.
2016-07-02 16:23:54.520 Locator[1713:1225759] INTULocationManager: Location Request completed with ID: 1, currentLocation: <+xx.xxxxxxxx,-1.47202716> +/- 165.00m (speed -1.00 mps / course -1.00) @ 02/07/2016, 16:23:53 British Summer Time, achievedAccuracy: 2, status: 1
20 seconds
2016-07-02 16:26:09.057 Locator[1717:1226375] INTULocationManager: Changing location services accuracy level to: medium high.
2016-07-02 16:26:09.058 Locator[1717:1226375] INTULocationManager: Location services updates have started.
2016-07-02 16:26:09.058 Locator[1717:1226375] INTULocationManager: Location Request added with ID: 1
2016-07-02 16:26:39.045 Locator[1717:1226375] INTULocationManager: Location services updates have stopped.
2016-07-02 16:26:39.060 Locator[1717:1226375] INTULocationManager: Location Request completed with ID: 1, currentLocation: <+xx.xxxxxxxx,-1.47221618> +/- 65.00m (speed -1.00 mps / course -1.00) @ 02/07/2016, 16:26:18 British Summer Time, achievedAccuracy: 3, status: 1
60 seconds
2016-07-02 16:28:48.830 Locator[1721:1227203] INTULocationManager: Changing location services accuracy level to: medium high.
2016-07-02 16:28:48.835 Locator[1721:1227203] INTULocationManager: Location services updates have started.
2016-07-02 16:28:48.835 Locator[1721:1227203] INTULocationManager: Location Request added with ID: 1
2016-07-02 16:29:48.816 Locator[1721:1227203] INTULocationManager: Location services updates have stopped.
2016-07-02 16:29:48.829 Locator[1721:1227203] INTULocationManager: Location Request completed with ID: 1, currentLocation: <+xx.xxxxxxxx,-1.47209244> +/- 165.00m (speed -1.00 mps / course -1.00) @ 02/07/2016, 16:28:58 British Summer Time, achievedAccuracy: 2, status: 1
120 seconds
2016-07-02 16:30:21.578 Locator[1724:1227823] INTULocationManager: Changing location services accuracy level to: medium high.
2016-07-02 16:30:21.579 Locator[1724:1227823] INTULocationManager: Location services updates have started.
2016-07-02 16:30:21.579 Locator[1724:1227823] INTULocationManager: Location Request added with ID: 1
2016-07-02 16:32:21.566 Locator[1724:1227823] INTULocationManager: Location services updates have stopped.
2016-07-02 16:32:21.582 Locator[1724:1227823] INTULocationManager: Location Request completed with ID: 1, currentLocation: <+xx.xxxxxxxx,-1.47221314> +/- 65.00m (speed -1.00 mps / course -1.00) @ 02/07/2016, 16:30:30 British Summer Time, achievedAccuracy: 2, status: 1
180 seconds
2016-07-02 16:33:43.797 Locator[1728:1228597] INTULocationManager: Changing location services accuracy level to: medium high.
2016-07-02 16:33:43.798 Locator[1728:1228597] INTULocationManager: Location services updates have started.
2016-07-02 16:33:43.798 Locator[1728:1228597] INTULocationManager: Location Request added with ID: 1
2016-07-02 16:36:43.781 Locator[1728:1228597] INTULocationManager: Location services updates have stopped.
2016-07-02 16:36:43.795 Locator[1728:1228597] INTULocationManager: Location Request completed with ID: 1, currentLocation: <+xx.xxxxxxxx,-1.47220965> +/- 65.00m (speed -1.00 mps / course -1.00) @ 02/07/2016, 16:34:02 British Summer Time, achievedAccuracy: 2, status: 1

Old, closing. Presumably you've worked through it by now?


about dependencys vision

The version of the required dependency library is not mentioned in the readme

the latest versions will work


First pull request. Sorry Chris!

Module 04 Confusion Matrix:
Overall: Great job this week, despite the :electric_plug: issues.
Feedback: COMMENT YOUR CODE. Future Kim will appreciate it...a lot.
Get and interpret the confusion matrix for classification models

Nice function for model selection
Your confusion matrix plot is well done
What does the c-matrix tell you?
What is the significance of the precision, recall, f-1 scores?

Kaggle Challenge

Ask yourself, what you would do differently on your next Kaggle challenge? In approach and execution.

Great Job!!!


We're up to 5.8k, minified and gzipped. It would be lovely to get that back down under 5...

Theres better ways to do this than deleting methods. omit and pick, max and min and several others are nearly duplicates of each other. It would not be hard to generate those functions

Maybe if we dropped support for older browsers we could cut down on the size..
Oh didn't see this one:

[x] https://github.com/jashkenas/underscore/issues/2062 Drop support for older browsers

I'd be happy to spend a few hours looking for places to trim down (I'm sure others would too). However, no one was given the opportunity.
I know what the answer is going to be to this, but please mark 1.7 as latest on npm and revert 1.8 before people start using it.

Also ping https://github.com/jashkenas/underscore/issues/1594

Could we look for some features in underscore that could be moved to underscore-contrib?

Underscore is now 6kb gzipped, which is up from 5.8kb (site says 5.7kb).

Im sure there is an excellent reason for this, and id love to hear it but wouldn't it save quite a bit of size if Underscore more of its own functions internally? such as _.each, _.filter, _.map ect...
At quick glance it seems there a quite a few more places that Underscore could "Dog Food" itself.
One of the things I love about Underscore is how it decreases the amount of Javascript I write in my projects. Seems Underscore itself could take more advantage of that.

@dperrymorrow

Im sure there is an excellent reason for this, and id love to hear it but wouldn't it save quite a bit of size if Underscore used more of its own functions internally? such as _.each, _.filter, _.map ect...

My guess is it's a concern over performance. That said I'm sure there are plenty of methods where performance isn't a concern for their common scenarios. It would be worth reviewing areas where dog fooding can be improved, nixing those areas where perf flags are raised.


[CT-1998] Improve handling of dictionaries in protobuf messages

In pull request #6820 we implemented protobuf message versions of nodes and node configs. However the match between Python dictionaries that allow values of any type and protobuf maps isn't straightforward. As a result we have temporarily forced a number of dictionaries into string/string dictionaries.
We should look at other options for this and improve the representation of dictionaries in protobuf messages. In particularly this applies to the "meta" dictionary, which is already included in 1.4 in the node_info structures in the logs.
In addition to "meta", the following dictionaries are affected:

in NodeConfig - persist_docs, quoting, column_types, grants
in ColumnInfo - _extra
in various nodes - unrendered_config
in TestMetadata - kwargs
in SourceDefinitino - source_meta

Copying from https://github.com/dbt-labs/dbt-core/issues/6803#issuecomment-1435099103
Next steps here:

Check out what Struct can do
See what map<str, Any> can do
Both have their limitations
Pick one, and go implement

Closing #6581 and #6803 in favor of this one — more context in the discussions there


keep the implicit (hidden) match features in a separate set in RankProfile

@havardpe maybe this is more clean

yes :-)


refactor TestReconcile_PipelineSpecTaskSpec objects

Changes
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Docs included if any changes are user facing
[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes
NONE

working on #4610
Signed-off-by: jbpratt<EMAIL_ADDRESS>

/ok-to-test

/retest

Hi @jerop and @pritidesai 😸 and @vdemeester !
Curious if we should convert this expected object
https://github.com/tektoncd/pipeline/blob/1f3b893548bb2414cbe60ac0cff74dc9adbb57f0/pkg/reconciler/pipelinerun/pipelinerun_test.go#L1015-L1030
My attempts to weren't exactly successful, anything omitted on the YAML side ends up as nil on the object so I'm not sure how to express some things.

Yes please, we should update and convert this object. Please refer to how its done here:
https://github.com/tektoncd/pipeline/pull/4609/files#diff-a64a19b939f791920d235cbf5bf2e4905d4814af06f21401b27af11351afbd0bR538
and
https://github.com/tektoncd/pipeline/pull/4609/files#diff-a64a19b939f791920d235cbf5bf2e4905d4814af06f21401b27af11351afbd0bR497
Also, if needed, you can add ignoreTypeMeta in the diff:
https://github.com/tektoncd/pipeline/pull/4609/files#diff-a64a19b939f791920d235cbf5bf2e4905d4814af06f21401b27af11351afbd0bR541

Pushed an update, the ignoreTypeMeta has helped, thank you @pritidesai . The test is currently failing, I'm seeing is resources wanting to be nil but I'm not sure how to fix this without another ignore compare option which may not be desirable. Thoughts? Sorry for the dumb question, still trying to figure things out :smiley_cat:
    /home/jbpratt/git/tektoncd/pipeline/pkg/reconciler/pipelinerun/pipelinerun_test.go:1030: expected to see TaskRun &{{TaskRun tekton.dev/v1beta1} {test-pipeline-run-success-unit-test-task-spec  foo    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[tekton.dev/memberOf:tasks tekton.dev/pipeline:test-pipeline tekton.dev/pipelineRun:test-pipeline-run-success tekton.dev/pipelineTask:unit-test-task-spec] map[] [{tekton.dev/v1beta1 PipelineRun test-pipeline-run-success  0x324c2b9 0x324c2b9}] []  []} {<nil> [] <nil> default <nil> 0xc000b34000  &Duration{Duration:1h0m0s,} <nil> [] [] []} {{0 [] map[]} { <nil> <nil> [] [] [] [] [] [] <nil>}}} created. Diff (-want, +got):   &v1beta1.TaskRun{
          	... // 1 ignored field
          	ObjectMeta: {Name: "test-pipeline-run-success-unit-test-task-spec", Namespace: "foo", Labels: {"tekton.dev/memberOf": "tasks", "tekton.dev/pipeline": "test-pipeline", "tekton.dev/pipelineRun": "test-pipeline-run-success", "tekton.dev/pipelineTask": "unit-test-task-spec"}, Annotations: {}, ...},
          	Spec: v1beta1.TaskRunSpec{
          		Debug:              nil,
          		Params:             nil,
        - 		Resources:          nil,
        + 		Resources:          &v1beta1.TaskRunResources{},
          		ServiceAccountName: "default",
          		TaskRef:            nil,
          		... // 7 identical fields
          	},
          	Status: {},
          }

You can update the expectedTaskRun to set it to empty struct instead of nil:
	expectedTaskRun.Spec.Resources = &v1beta1.TaskRunResources{}

This should work!

I'll push another PR soon, my apologies. Should have marked this as draft :grin:


juno: remove support

Support for the Juno reference platform is being done in the
meta-arm-bsp layer now.  Remove support here in favor of that.
Signed-off-by: Jon Mason<EMAIL_ADDRESS>

@fboudra @mrchapp is anyone using juno in their builds, in any of our internal projects?

We are, but very far from the master branch.

If you are using juno, please migrate to meta-arm-bsp.  If it is missing something, please let us know and we'll add it.

If you are using juno, please migrate to meta-arm-bsp. If it is missing something, please let us know and we'll add it.

We are using Juno and HiKey (with optee). The thing is that we're using Sumo. :(
Once we move to Dunfell we'll add meta-arm for Juno (and see how we deal with HiKey).


stop trying to use generation without observedgeneration

We never set observedgeneration (oops), which means that trying to use generation is inexact at best.  I think we're rolling out and somehow not seeing the transitions.  This reduces the precision of the check, but may improve stability.

no one's here today.  Self lgtm to see if this helps.  We can revert the test later if necessary.

/lgtm


Revert "Revert "Dropdown: prefixed private props (index) with undersc…

…ore (#1900)" (#1923)"
This reverts commit a3d545bbaeab5ea32d8446ddb1b2bc02ee629130
Summary
What changed?
index private prop in Dropdown.Item and Dropdown.Link are prefixed with underscore ('_') following new pattern
Why?
Following new pattern to name private props

Hey @ayeshakmaz Could you review this one to make sure I'm not missing any _index in any cloned children?
Pretty simple, just to make sure I don't miss anything.


Map NwStore.CurrentCustomers

Confirmed OK from StoreEvents.OnClose. Let me know if you need anything changed.

@Jorteck I had forgotten this PR. Suggestions applied and commits tidied up. Let me know if you need anything else changed.


Fix task cancel install

Fix: #609

when I click on install from tektonHub and try to install and overwrite it is always stuck on installing.

still, it stuck on Installing button.


fix an error when executing startup.bat when the log directory exists

Please answer these questions before submitting pull request

Why submit this pull request?

[x] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues
resolve #5183

1st PR of the 8.2 milestone, welcome.


Swift 4 新特性 - 柏荧的博客 | BY Blog

https://a-liudezhi.github.io/2017/09/11/Swift-4-新特性/
Every failure is leading towards success.

ioo濙popipippop普 辩说 谱

谱说法闵闵说滴剂


OOM while finetuning Starcoder

I really appreciate you releasing this work.
I have been trying to do something similar with the original Starcoder finetuning code but have had a variety of issues.
Unfortunately, when I run this script on my own dataset (it's only around 6800 MOO verbs) I get a pretty rapid OOM on a machine with 8x A100 80gb cards.
At first I thought it was because I was trying to increase max_seq_size, (I was hoping for 1024 tokens) but dropping it back to 512 gave me the same issue.
I then tried reducing batch size to 1, but that also did not work and errored out with insufficient memory again.
The only other thing I changed is the prompt, although I made very minor changes to that, mostly just changing the language to my own and picking different columns out of my dataset.
Here is my run.sh:
#! /usr/bin/env bash
set -e # stop on first error
set -u # stop if any variable is unbound
set -o pipefail # stop if any command in a pipe fails

LOG_FILE="output.log"
TRANSFORMERS_VERBOSITY=info

get_gpu_count() {
  local gpu_count
  gpu_count=$(nvidia-smi -L | wc -l)
  echo "$gpu_count"
}

gpu_count=$(get_gpu_count)
echo "Number of GPUs: $gpu_count"

train() {
    local script="$1"
    shift 1
    local script_args="$@"

    if [ -z "$script" ] || [ -z "$script_args" ]; then
        echo "Error: Missing arguments. Please provide the script and script_args."
        return 1
    fi

    { torchrun --nproc_per_node="$gpu_count" "$script" $script_args 2>&1; } | tee -a "$LOG_FILE"
    }

train train.py \
    --model_name_or_path "bigcode/starcoder" \
    --data_path ./verbs_augmented/verbs_augmented.jsonl \
    --bf16 True \
    --output_dir moocoder \
    --num_train_epochs 2 \
    --per_device_train_batch_size 2 \
    --per_device_eval_batch_size 2 \
    --gradient_accumulation_steps 16 \
    --evaluation_strategy "no" \
    --save_strategy "steps" \
    --save_steps 100 \
    --learning_rate 2e-5 \
    --weight_decay 0. \
    --warmup_ratio 0.03 \
    --lr_scheduler_type "cosine" \
    --logging_steps 1 \
    --fsdp "full_shard" \
    --fsdp_transformer_layer_cls_to_wrap 'GPTBigCodeBlock' \
    --tf32 True

Any idea what might be going wrong here/can I give you any more info to help me figure this out?

Hey @ctoth , thank you, glad it's useful!
The only thing i noticed about your training params is the lack of auto_wrap option in the --fsdp argument. (see godot_dodo_4x_60k_starcoder_15b_3ep , Transformers docs)
Could you try adding that and report back? The rest all looks correct to me, and i was using the same hardware for my training runs.


Revamp interface with Material UI

The whole thing started because I was building a button with the address that you could click to copy the address to the clipboard. I wanted a small tooltip saying "copy to clipboard" and "copied to clipboard" afterward. Doing it with tailwind and a headless component was too much work. Since we are still in the prototyping phase, I wanted more high-level components to build things quickly.
So, I changed the whole UI to use material UI. Most of the code is Lego work, combining components imported from material. This should make it easier for everyone that wants to contribute.
Most of this is just my replacing the existing UI elements with the material version, but I did take some time to refactor pieces of the code:

extracted a bunch of functionality to hooks.
flatten the components because a flat structure makes it simpler for contributors because they don't have to guess where to put components.
revamped the transactions section.
disabled autocorrect in some fields because it messed up the input text.
other minor improvements.

And the cherry on top is that we get light and dark mode for free, and it adapts to the system configuration.

Love it. just need to see what's going on with that isDirty comment I left above.
but other than that let's merge this!


DROP TABLE not permitted

skeema refuses to DROP a table even though MySQL account has a DROP privilege.
2017-09-04 05:45:32 [ERROR] DROP TABLE not permitted. The affected DDL statement will be skipped. See --help for more information.
/* DROP TABLE `sb_woocommerce_shipping_table_rates`; */

[root@ip-172-31-37-147 sb]# mysql -e 'SHOW GRANTS FOR CURRENT_USER()'
+----------------------------------------------------------------------------------------------------------------------------------------+
| Grants for root@localhost                                                                                |
+----------------------------------------------------------------------------------------------------------------------------------------+
| GRANT ALL PRIVILEGES ON *.* TO 'root'@'localhost' IDENTIFIED BY PASSWORD '****' WITH GRANT OPTION |
| GRANT PROXY ON ''@'' TO 'root'@'localhost' WITH GRANT OPTION                                                                           |
+----------------------------------------------------------------------------------------------------------------------------------------+

Thank you for trying out Skeema! This is working as designed though. Skeema considers destructive actions (e.g. dropping tables, dropping columns, lossy changes to column types, etc) to be "unsafe" by default, and won't execute them unless you specifically configure it to do so. That's why it is telling you to See --help for more information :) That said, I should make this message clearer to indicate it's because of Skeema's settings, not because of grants.
You can configure unsafe operations to always be executed only in certain environments (e.g. dev), and/or can configure them to be OK depending on the table size (e.g. allow them if the table is under 1GB, or allow them only if the table has no rows).
More docs on this:

https://github.com/skeema/skeema/blob/master/doc/examples.md#generate-ddl-from-adding-or-removing-files
https://github.com/skeema/skeema/blob/master/doc/options.md#allow-unsafe
https://github.com/skeema/skeema/blob/master/doc/options.md#safe-below-size
https://github.com/skeema/skeema/blob/master/doc/faq.md#destructive-operations-are-prevented-by-default
https://github.com/skeema/skeema/blob/master/doc/requirements.md#renaming-columns-or-tables


Crashes in setProperPage()

Hello, I am getting random crashes. They start in the setProperPage() where the class is called "UpdateUIViewControllerBugFixClass". Here's the code where it finally crashes:
 func configureNewMonth(at page: Int) {
        if months[page] != currentMonth {
            currentMonth = months[page]
            selectedDate = nil

            delegate?.calendar(willDisplayMonth: currentMonth)

            if allowsHaptics && isHapticActive {
                UIImpactFeedbackGenerator.generateSelectionHaptic()
            } else {
                isHapticActive = true
            }
        }
    }

For some reason the page passed is like 26,000. Any ideas on how to fix this? Apparently the creator was trying to solve a bug but it seems it is not resolved.

The issue was solved. Basically the Calendar can't be empty on initialization, so I had to pass a welcome entry when a new account is created.


Bugfix & improvement of Cyclone V SoC DK ethernet

Bugfix & improvement of Cyclone V SoC DK ethernet
Issue involved overflow of a timeout counter and the driver instance was not the emac-index.
Signed-off-by: Benjamin Kyd<EMAIL_ADDRESS>

@teburd Apologies for the push once more.. the compliance check failed again at a spot i thought i amended... Should be good now once CI passes. Sorry again

@teburd do you think you could request a review from the others.. they seem to have been automatically removed.


Lazy create MVC ControllerActionInvoker statemachines

Lazy create ControllerActionInvoker.InvokeInnerFilterAsync statemachine
Lazy create ControllerActionInvoker.InvokeNextActionFilterAwaitedAsync statemachine
Lazy create ControllerActionInvoker.InvokeNextActionFilterAsync statemachine
Lazy create ControllerActionInvoker.InvokeActionMethodAsync statemachine
Lazy create Controller.OnActionExecutionAsync statemachine

/cc @rynowak  @pranavkm

Update on outstanding statemachines with current sdk; highlighting Controller stuff (this PR)

Thanks!

When all of this stuff is done it would be super cool to see before/after numbers

When all of this stuff is done it would be super cool to see before/after numbers

3.0 is currently +37.3% higher than 2.2

@rynowak has stabilised for now as nothing merged related, though still https://github.com/aspnet/AspNetCore/pull/9512 and https://github.com/aspnet/Extensions/pull/1479 to go

Drop was from GC issue that @sebastienros tracked down and has now bee resolved.


COUNT(*) returns an object which can't be read

db.prepare("SELECT COUNT(*) FROM table").get();
returns an object that is just
{ 'COUNT(*)': 2 } that is fine until you realize console.log(rows.COUNT(*)); doesn't work because SyntaxError: Unexpected token *

Shortly after posting I realized this could be resolved with Object.values(the returned object)

object["propert"] also works

Oh, okay, as I said rows['count(*)'] should work

Sure it works, but it doesn't look good.
You named your issue "COUNT(*) returns an object which can't be read" which is still true as even do COUNT(*) is a valid JavaScript Object key name, it doesn't look good while count would be much better and better readable.
Obviously, technically the returned object is readable, but from a developer point of view it isn't.

Well, I'm facing that issue too, and honestly, it doesn't look good. I found this SO which says to use .count() but it doesn't work, while it should!
This issue should be reopened in my opinion .. so if you could do it @AidanWelch it would be great! :)

Try this:
const count = db.prepare('SELECT COUNT(*) AS count FROM table').get().count;

Or this:
const count = db.prepare('SELECT COUNT(*) FROM table').pluck().get();

Thank you @JoshuaWise for your comment, I will try them 🤞

@JoshuaWise 👍.
No problem, glad it works


use position control even if all commanded positions are zero, becaus…

…e that is a set of valid values.
Resolves: #20
Signed-off-by: Kenji Brameld<EMAIL_ADDRESS>

@Mergifyio backport galactic


Finalize payment on server: Bug on Android

Describe the bug
When using the finalize payment on server integration method, https://docs.stripe.com/payments/finalize-payments-on-the-server?integration=paymentsheet
There is a bug that appears on android  - After the user enters an incorrect card details and attempts to pay, the payment sheet gives an error which is good, the problem is, all subsequent attempts fail in that payment sheet instance. You have to close it and reopen it and enter the new card details for it to work again
To Reproduce
Steps to reproduce the behavior:
Here is the entire code for testing (very short 1 file: 150 lines): https://pastebin.com/ATet43qF. I added the create intent (that should be server side) for convenience to the client side code.

Tap "Pay Now"
Enter card details that will fail, e.g.<PHONE_NUMBER>000002
After the error appears that the card was declined, IN THE SAME PAYMENT SHEET update your card details to:<PHONE_NUMBER>424242
And Submit. You will notice that the attempt fail with error "Something went wrong" and all other attempts will also fail

Expected behavior
The bug does not appear on iOS. The payment sheet should simply accept and process the new card and show success.
Screenshots/Video
Here is a video of my attempt: https://streamable.com/53rl9g
Smartphone (please complete the following information):

Device: Samsung S23 and Samsung s9+
OS: Android
Version: I tested in Android 10 and 14 on physical devices

Additional context
The error only appears on android from the testing I did (which is a lot). I notified Stripe of the issue and have been following up for about 3 months now. I am not sure if they can't replicate, or I am doing something wrong, so I am posting here in case some good Samaritan had the issue and figured it out. NOTE: I USE EXPO and have tried expo version as well as latest version of the package

Any update on this issue? I am also facing the same with the same card details mentioned by @ryonwhyte

Any update on this issue? I am also facing the same with the same card details mentioned by @ryonwhyte

Have you found a solution? In the end I switched to the regular way.


Best way to determine state depending on prop(s)?

  :)
Suppose we have a tree of files to explore, and we want to be able to provide an initial state based on the files/directories the user had opened when they were last using the app or possibly based on the project/workspace/whatever.  So imagine we have this initial state serialized as follows:
const open = {
  'redux/src': true,
  'redux/examples': true,
  'redux/examples/counter': true,
  'redux/examples/counter/server.js': true
};

And then for each item in the tree (let's call it a Limb component), we want to provide props.isOpen based on a combination of the open state and the path prop which is specific to each Limb.  And we also want to provide toggle prop (function) that updates both the open object and props.isOpen such that only the Limb being toggled is affected.
What's the best way to achieve this with redux and react-redux?

Take a look at the last example in connect API reference. (Sorry, I'm on mobile :-)

Can you link me to what you're talking about when you get a chance?

Okay finally had a chance to actually look for it lol.  At the bottom of the main README right?  Above troubleshooting using parentProps?  I'll try this out now.

Whoa.  That was insanely easy.  Thanks a ton dude!!!!

:+1:


retry all errors

What problem are we solving?
The leader switch process may cause request failures.
How are we solving the problem?
Retry all errors.
The reason for the issue is that not all types of errors were retried when accessing the master node, only network issues were retried. After the election ends and a new leader appears, the topology information is not yet fully constructed, so the leader node is still in an unavailable state. At this time, the returned error should be retried.
How is the PR tested?
Use S3 stress testing tool to conduct stress testing and stop the Leader process during the testing process to observe whether there are any request errors during the leader switch.
Checks

[ ] I have added unit tests if possible.
[ ] I will add related wiki document changes and link to this PR after merging.

Fix the legacy issues of this commit.
https://github.com/seaweedfs/seaweedfs/commit/f7e0a65e752f08566c829ce67c4aa8ed1d6dd4f6

Not all errors are retry-able.


Feature Request: reverse proxy option to assume ResourceNotFound by default

With ASP.NET Core, we are using Kestrel exclusively. However, the assumption of port sharing by reverse proxy requires every microservice to add extra header X-ServiceFabric : ResourceNotFound. This is not microservice friendly, and we are caught every so often.
I propose an option/setting to switch the default behavior.

@qrli Yup, makes sense, it's something we're working on, specifically decoupling services from each other and from networking concerns in general.

No news about it?
Even if I agree with @qrli and @Mardoxx the real pain here is when the Stateless Service is an existing web api application developed without the ServiceFabric SDK, I mean a java spring boot rest api or a node rest api for example.
For all of them we need to find a weird way to inject a web filter to intercept all the returning response and adding the "X-ServiceFabric" "ResourceNotFound" response header before commit the original response.


Create Single Workout View

-more details about the workout
-recommended reps/sets/rest times/weight (based on difficulty)
-beginner/intermediate/advanced
-equipment requirements
-tips/tricks
-video (extra feature)
-user input: weight, reps, sets
previous time(s) workout was done: date, weight, reps, sets, how difficult

Only working in SingleWorkout.js

I tried going to your branches and trying from main but it kept giving me errors. I changed some apis/stores/SingleExercise.js on the workouts branch.
SingleExercise.js now changes based on the params id but I haven't added the other details in yet besides the name and add to workout button.


Adding an API route 404 error

I'm trying to create a user profile page and I'm running into a weird problem setting up the API endpoint.
I add the following to /modules/users/server/routes/users.server.routes.js:
  app.route('/api/profile/:userName').get(users.userByUsername);
  app.param('userName', users.userByUsername);

Then I add the middleware that gets user by username to users.authentication.server.controller.js. This appears to be working because when I visit say /api/profile/james I can log james's profile information to the console.
However, on the browser itself I get a 404 error. It appears to be triggering the following rule from core.server.routes: app.route('/:url(api|modules|lib)/*').get(core.renderNotFound);
Why is the browser not just displaying the JSON information as it does with the other API endpoints? I've been digging around the code and can't work out why.

Doh, I just realized that all API requests go through the authentication middleware by default. I had to add an extra policy to admin.server.policy.js:
{
    roles: ['guest', 'user'],
    allows: [{
      resources: '/api/profile/:userName',
      permissions: 'get'
    }]
}

and the following to admin.server.routes.js:
  app.route('/api/profile/:userName')
    .get(adminPolicy.isAllowed, admin.read);


cannot compile for i386 Debian, is it possible to change u64 to u32?

Compiling clang-sys v1.3.3
error[E0308]: mismatched types
--> /root/.cargo/git/checkouts/mouce-da81cbdbeafc6640/26da8d4/src/nix/uinput.rs:186:23
|
186 |             ioctl(fd, UI_DEV_DESTROY as u64);
|                       ^^^^^^^^^^^^^^^^^^^^^ expected u32, found u64
|
help: you can convert a u64 to a u32 and panic if the converted value doesn't fit
|
186 |             ioctl(fd, (UI_DEV_DESTROY as u64).try_into().unwrap());
|                       +                     +++++++++++++++++++++
For more information about this error, try rustc --explain E0308.
error: could not compile mouce due to previous error

It looks like this PR introduces too many redundant changes. Please propose a smaller PR, or open an issue.


Upload Crypto VENO (VENO)

Hello friend, I'm upload new logo, please approved request add logo token.

I still not look logo on trust wallet.

@CryptoVENO it has to be approved first.

Done!
https://github.com/TrustWallet/tokens/commit/e64c64963dbc7d14c65059cec1b79e0f5687170b

Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwalletapp.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:
Twitter: @TrustWalletApp
Facebook: @TrustWalletApp

Thank's friends


Is Inlining wasm via asmˋ...ˋ "macro" supported?

Porffor.wasm... exists

See the contributing guidelines for more information.


Make chat identifiers long instead of int

From https://core.telegram.org/bots/api-changelog
⚠ WARNING! ⚠
User identifiers will become bigger than 2^31 - 1 before the end of this year and it will be no longer possible to store them in a signed 32-bit integer type. User identifiers will have up to 52 significant bits, so a 64-bit integer or double-precision float type would still be safe for storing them. Please make sure that your code can correctly handle such user identifiers.

Since PostMessage(string message, string chatId) uses a string as chat_id, this is not needed.


GridField and DataObject canView()

If you have a GridField containing any DataObject with a canView() resulting in true, everything is perfectly fine as you would expect. However, when the canView() results in false, you end up having items that are suppressed from the view. They aren't actually removed, but more so hidden, and therefore introduce a number of issues..
Firstly, you basically end up having the GridField show "no items found" which is correct, however you'll see something like "view 1–15 of 100" displayed at the top. Secondly, if you're using the export to CSV button, you'll actually have the complete 100 items exported.. completely bypassing the permissions in place.
I understand that there's some performance issues to take into consideration with regards to permission checking, however something like this seems completely fundamental to me. I think this needs some attention in the near future, as I have also encountered similar issues when using full-text search pagination out of the box (as noted in #2791).

I agree and it's misleading. Pagination would require more thinking but the CSV export missing canView() is much more vital (#3845).

Nice work covering off the export canView() issue. Since the main problem has been corrected, I'll close this off for now. However, it seems like the pagination will require some work in the future.

Is it possible to reopen this and look at what it would take to fix the pagination issue?
On initial inspection it appears that the all GridField_DataManipulator inheritor classes, such as GridFieldPaginator receive a list that hasn't been filtered by canView().
This is expected and reasonable, but when using extensions like 'Lumberjack' and 'Restricted Objects' together, you start to get gridfields where the expectation is to see a paginated list of pages that can be viewed, but instead get a paginated list that says "no items found" because the viewable pages are not condescend to the first paginated page.
Changing this behaviour would almost definitely have performance implications, but might be necessary for sites with complex canView() behaviours and enterprise-ish admin permissions.

@talbet it's definitely worth looking into this issue but I'd rather (you) open a new issue than us re-open this old one? This old one is part solved and doesn't offer any helpful context


Fix log rollig

Also I added totalSizeCap = 5GB
For some reason current logger configuration didn't work for me. But with adding full path for  rotation of logs started.

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:


learned linear projections l_Q, l_K, l_V

Hi, this question is about the linear projections l_Q, l_K, l_V of the attention module in the paper Prompt-to-Prompt. The paper illustrated that the linear projections are learnable. However, in the introduction, it is claimed that "this method does not requires model training". The two expressions seem to contradict each other. How do you learn the papamaters of the l_Q, l_K, l_V?

In the attention module, l_Q, l_K, and l_V are designed to be learnable.
However, since this paper utilizes pretrained models, there is no necessity to train them.


DataStore - subscriptionError Connection failed; "Not Authorized to access [many-to-many] on type Subscription"

Amplify CLI Version
11.0.2
Question
Hello, I'm building a wishlist app where a user can have multiple wishlists and save multiple items to one or more wishlists, so I created a  @manyToMany relationship between them. I first tried this with public auth and followed the instructions here, and a new Item and WishlistItem were created correctly.  Here is my implementation:
const item = await DataStore.save(
    new ItemModel({
          name,
          price: parseFloat(price),
          imageUrl: image,
          itemUrl,
          platform,
          isReserved: false,
          isPurchased: false,
    })
);
await DataStore.save(
    new WishlistItemModel({
          item,
          wishlist,
    })
);

However, when I switched this to owner based access as described in the models below, and tried saving an item to a wishlist, I could see that the Item was being added correctly, but there was no WishlistItem, and I got several errors related to querying/updating/deleting WishlistItem like:

DataStore - queryError User is unauthorized to query syncWishlistItems, some items could not be returned
DataStore - subscriptionError Connection failed: {"errors": [{"errorType":"Unauthorized", "message":"Not Authorized to access onUpdateWishlistItem(onCreateWishlistItem/onDeleteWishlistItem) on type Subscription"}]}

type Wishlist @model @auth(rules: [{allow: owner}]) {
  id: ID!
  name: String!
  description: String
  isPrivate: Boolean!
  Items: [Item] @manyToMany(relationName: "WishlistItem")
}

type Item @model @auth(rules: [{allow: owner}]) {
  id: ID!
  name: String!
  price: Float!
  imageUrl: AWSURL!
  itemUrl: AWSURL!
  platform: String!
  isReserved: Boolean!
  isPurchased: Boolean!
  Wishlists: [Wishlist] @manyToMany(relationName: "WishlistItem")
}

Not sure what I'm missing here :/ I would REALLY appreciate any help I can get. I've been stuck on this for so long 😢  Thank you in advance!

Hi @lafeer 👋 thanks for raising this issue. Can you please share the contents of your amplify/backend/api/<apiName>/cli-inputs.json file?

Hi @chrisbonifacio, thanks for getting back to me. Sure it's
{   "version": 1,   "serviceConfiguration": {     "apiName": "wishwell",     "serviceName": "AppSync",     "defaultAuthType": {       "mode": "API_KEY",       "keyDescription": "api key description",       "expirationTime": 30     },     "additionalAuthTypes": [       {         "mode": "AWS_IAM"       },       {         "mode": "AMAZON_COGNITO_USER_POOLS",         "cognitoUserPoolId": "authwishwell"       }     ],     "conflictResolution": {       "defaultResolutionStrategy": {         "type": "AUTOMERGE"       }     }   } }

@lafeer Of course 😃
So, it looks like the default auth mode on your GraphQL API is API KEY, which is needed for the { allow: public } auth rule. Since your models are now using { allow: owner }, you'll need to make sure DataStore is trying to authorize the queries, mutations, and subscriptions using AMAZON_COGNITO_POOLS as the auth mode.
By default DataStore will only use the default auth mode. In order for it to use the additional auth types, you just need to enable to MULTI_AUTH by altering your Amplify configuration a bit.
Ex.
import { Amplify, AuthModeStrategyType } from 'aws-amplify';
import awsconfig from './aws-exports';

Amplify.configure({
  ...awsconfig,
  DataStore: {
    authModeStrategyType: AuthModeStrategyType.MULTI_AUTH
  }
})

Try this and let me know if it resolves the issue for you!


Labels for Data Sets

Hi,
Here is the chart I have: https://jsfiddle.net/hqjz321d/
In my chart, the values are given with arrays. My chart has a time span of about 2 years. In my example are 3 data points, but usually I have much more! The performance is good, but for every data point I need a label as you can see in the example.
1.) As JSON object, as I can do it for the data values: http://c3js.org/samples/data_json.html
or
with an additional data serie, like HiddenLabel in my example. But I need to rotate the labels (90°) and make the bar for the label invisible (the same colour as the background has or bar width = 0 or value = 0 and set the heigh of the label)
Is this possible at the moment?
2.) Subchart:

the colour of HiddenLabel in the subchart is not changed to black (maybe a bug?)

I would like to zoom the area I want to see, hide the subchart, and then make a screenshot of the zoomed area without the subchart. Is that possible? This is not so important for me as point 1.

Any idea here? =)

Hi,
The issue queue is to be used for reporting defects and problems with C3.js, in addition to feature requests and ideas.
It is not a catch-all support forum.
For general support enquiries, please use the Google Group at https://groups.google.com/forum/#!forum/c3js.
All questions involving the interplay between C3.js and any other library (such as AngularJS) should be posted there first!
Thank you!


Trying to update ReplicaSet Docs as per issue 12081

To start with, I tried to cleanup the docs to adhere to the style guide https://kubernetes.io/docs/contribute/style/style-guide/. I then added some description of the ReplicaSet-Pod link via the owner reference field and behavior by it. I also made a clarification on the ReplicaSet demo where it was being redundant for the sake of demonstrating the different forms of usage. I consider this draft incomplete as I still lack knowledge of how the pod labels affect the behavior.
Preview: https://deploy-preview-12409--kubernetes-io-master-staging.netlify.com/docs/concepts/workloads/controllers/replicaset/
cc @steveperry-53 @chenopis

/lgtm

I still have to investigate the actual mechanics of this: Does the Deployment Controller actually compare the Pods' Specs or does it rely on the hash in the label

fixes #12081


Can not discover Vizio TV

Hello -
Attempting to deploy on a Windows Server box that has Python installed and running.
When running the discover command
pyvizio --ip=0 discover Nothing is returned.....
I can ping the tv as shown below in the screen grab, any suggestions?

Thanks.
Squid

Hi @KidSquid1 this is likely because mDNS is blocked on your LAN. Is there something in particular you are trying to achieve with discovery given that you already know the IP of the TV?
I just pushed a change that falls back to SSDP if mDNS discovery fails: https://github.com/vkorn/pyvizio/pull/122

I had a similar problem. The first thing I did was run this command:
avahi-browser -all
You should see the device show up. For instance with device_type=tv you should see viziocast entry.  What I found out is that I had my tv on eco mode for the device. You have to set up as quick start. If you don't, the device won't respond.


Nifi 1893

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

This is my first version of JSON Validator. Please review it.

I think we can use ValidateRecord to do the same validation. I will close this pull request.

I think we can use ValidateRecord to do the same validation. I will close this pull request.


Use PRE_FUNDED_ACCOUNTS as a stack

Using array.pop each time an account is used would guarantee no clashes between services.

I have someone who flashbotted me for 20btcs and 48 eth. I have all his token holder addresses and centralized exchanges and decentralized exchange addresses with multi millions in every transaction. Anyone wanna help me with coding


Parameterize service files for multi-device control

Since the beginning (only a year ago?) I've been using this project with a parameterized service file to allow running two bridges to control my two Oolers. In the spirit of "getting all my private change out in the open", here is the change I have made.
The parameterized service file should be a drop-in replacement for anyone using the current model. Just disable your current service and remove the old file from systemd, then add this new file and add the new service, adding your config file name as the parameter.
Additionally, I have always used a virtual environment. I realize this is not for everyone, so I have added a second service file (which is the one I actually use) to use the virtual environment Python.
No hard feelings if you don't want these changes, or you only want part of them.

Thanks for this - it should be helpful. I think it might be worth still keeping the non-templated example file around though, to give more examples for people to use.

Sorry, I lost track of this. I have re-added the old file.


Change to confirmCardPayment from handleCardPayment

Example is using a method that has been deprecated, updated it to match current guidance in docs: https://stripe.com/docs/stripe-js/reference#stripe-confirm-card-payment
FYI this is @stevehind from Stripe ... this is my personal account.

I've now implemented and tested his on the integration I'm building and it causes errors. I don't think the documentation saying handleCardPayment and confirmCardPayment are the same is accurate. If I do nothing but change the name, I get this error:
Payment failed: A payment method of type card was expected to be present, but this PaymentIntent does not have a payment method and none was provided. Try again providing either the payment_method or payment_method_data parameters.
If I follow the pattern in the docs and add a card, I get: Invalid value for confirmCardPayment: payment_method.card should be object or element. You specified: function.
https://stripe.com/docs/stripe-js/reference#stripe-handle-card-payment


Add a configuration option to define the primary artifact extension.

Custom packaging types (maven-archetype, mule, etc.) which do not map from packaging type name (jar, war, zip, etc) to artifact filename extension need to be handled more gracefully than hard-coding string comparisons as done here:
https://github.com/egineering-llc/gitflow-helper-maven-plugin/blob/master/src/main/java/com/e_gineering/maven/gitflowhelper/AbstractGitflowBasedRepositoryMojo.java#L166

After some investigation, due to the way some plugins handle artifact attachment (rather than providing custom packaging) it will probably be best to push this configuration to the gitflow-helper-maven-plugin in the form of configuration options.
It may also be worth having the plugin attach a known artifact which lists the attached artifacts in release branches. This would enable us to track what artifacts are attached and properly handle artifact discovery  more elegantly than additional configuration items.


IA-1813: show geo data info  when orgunit has been created

geo data info was confusing when creating a new org unit, it should be displayed only when the org unit has been created
Self proof reading checklist

[x] Did I use eslint and black formatters
[x] Is my code clear enough and well documented
[x] Are my typescript files well typed
[ ] Did I add translations
[ ] My migrations file are included
[ ] Are there enough tests

Print screen / video
recording-2023-01-11-12-40-30.webm

@cypress


"Setup postgres server" step fails

The two commands it executes here, fail to execute with the error:
sudo: createuser msf -P -S -R -D: command not found sudo: createdb -O msf msf: command not found
The rest of the install has no errors, so i assume that part works.
uname -a output: Linux Pesoen-Thinkpad 4.9.0-11-amd64 #1 SMP Debian 4.9.189-3+deb9u2 (2019-11-11) x86_64 GNU/Linux

starting armitage reveals it not being able to find database.yml

metasploit starts, but also cannot see any database. have not tested how much of it works yet.

Same issue for me

Sorry for the delay. I will write another program that should remedy this problem and will post it before this Friday.
Thank you for bringing this to my attention

you are welcome :) and it's okay it took a while, as long as it gets fixed i don't mind 👍

Sorry taking longer than expected. Haven't found the time. Once I sit down and do it it'll only take around 10 minutes. I have a fix in mind. If not by tonight expect it by the end of the weekend. Thank you for understanding.

No rush! Thank you for looking into it :)
I haven't had time to debug myself and I'm out of town till Monday. Do you know what causes the issue? If you don't have time, I could look at it and send a PR on Monday.
I've tried to generate a new database with MSF itself (db_init). Works like a charm. Was able to generate a valid database.yml for Armitage as well but a but it seems like the SQL instructions still timeout.

Alright try this before I change the code. Basically run this in a root shell:
echo "production:\nadapter: postgresql\ndatabase: msf\nusername: msf\npassword: root\nhost: <IP_ADDRESS>\nport: 5432\npool: 75\ntimeout: 5" > /opt/metasploit-framework/config/database.yml
Sorry for the delay. Let me know how it works.

file already exist for me, but running the command seems to complete without anything wrong..

quick update, made it work by manually running the "msfdb init" command, and copying the database it creates in my home folder to the root folder. now it works and connects to the database correctly, and seems to work, need to run a test with armitage, but it looks to be working after this.

No complaints from armitage, though the network i am currently on is protected, and i cannot find any computers by scanning, it seems to be working as expected.

just tested it. my fix with copying the database.yml file created by running msfdb init works as a workaround.

Yikes, I'm sorry I never noticed your replies. Glad it works. Let me know if there's anything else you need! I'll close this issue.


Get rid of fat arrows

Introduced in https://github.com/arthurvr/timeline-url/pull/13, which I like but it breaks Chrome stable (and I think beta too). Assigning to me :beers:

Done in #20. Thanks again, @paulirish :wink:


stylex-webpack doesn't work properly in Next.js development environment

I added @stylexjs/stylex and stylex-webpack into my project, but when I launched the dev server, I got an error in the console and the it didn't work as expected.
The error log is below:
Error: 'stylex.create' should never be called at runtime. It should be compiled away by '@stylexjs/babel-plugin'
    at errorForFn (webpack-internal:///(rsc)/./node_modules/@stylexjs/stylex/lib/es/stylex.mjs:189:28)
    at Function.stylexCreate [as create] (webpack-internal:///(rsc)/./node_modules/@stylexjs/stylex/lib/es/stylex.mjs:228:9)
    at eval (webpack-internal:///(rsc)/./src/app/layout.tsx:15:73)
    at (rsc)/./src/app/layout.tsx (D:\Project\Website\stylex-webpack-issue-reproduction\.next\server\app\page.js:97:1)
    at Function.__webpack_require__ (D:\Project\Website\stylex-webpack-issue-reproduction\.next\server\webpack-runtime.js:33:42)
    at async e7 (D:\Project\Website\stylex-webpack-issue-reproduction\node_modules\next\dist\compiled\next-server\app-page.runtime.dev.js:35:396619)
    at async tS (D:\Project\Website\stylex-webpack-issue-reproduction\node_modules\next\dist\compiled\next-server\app-page.runtime.dev.js:35:400214)
    at async tw (D:\Project\Website\stylex-webpack-issue-reproduction\node_modules\next\dist\compiled\next-server\app-page.runtime.dev.js:35:400775)
    at async tO (D:\Project\Website\stylex-webpack-issue-reproduction\node_modules\next\dist\compiled\next-server\app-page.runtime.dev.js:36:2320)
    at async D:\Project\Website\stylex-webpack-issue-reproduction\node_modules\next\dist\compiled\next-server\app-page.runtime.dev.js:36:2989 {
  digest: '1747662813',
  page: '/'

I've created a minium bug reproduction here, and I hope that will help someone find out a solution easier.

Hi, it has been two weeks since the issue was opened. Is there anyone able to offer some suggestions about how to solve the problem or where to get help about my problem? I'd sincerely appreciate it if someone helps.

Have you tried rename next.config.cjs to next.config.js?

Have you tried rename next.config.cjs to next.config.js?
next.config.cjs is never supported by Next.js: https://github.com/vercel/next.js/blob/47e346c97bcb54179eb409ad12757a13b5a0fb13/packages/next/src/shared/lib/constants.ts#L53

yes，it works for my problem, thank you for your help.


Update BMI input units

All input/output units are in m/h as commented in source code.  Current BMI input units for rain (CSDMS: atmosphere_water__liquid_equivalent_precipitation_rate) and ep (CSDMS: water_potential_evaporation_flux) should be updated from
static const char *input_var_units[INPUT_VAR_NAME_COUNT] = {
        "kg m-2",
        "m s-1"
};

in bmi_topmodel.c to,
static const char *input_var_units[INPUT_VAR_NAME_COUNT] = {
        "kg m-2/1000.0",
        "kg m-2/1000.0"
};

The units string should not contain conversion constants, as I understand
it, because they will not be recognized by the unit conversion tools like
UDUNITs.  Multiplying by constants (if needed) should be done internally.
Best,
Scott
On Fri, Nov 12, 2021 at 1:46 PM JessicaGarrett-NOAA <
@.***> wrote:

All input/output units are in m/h as commented in source code
https://github.com/NOAA-OWP/topmodel/blob/479d00684971977bc39f44491515c49fc82ab37e/refs/original_code_c/tmod9502.c#L381.
Current BMI input units for rain (CSDMS:
atmosphere_water__liquid_equivalent_precipitation_rate) and ep (CSDMS:
water_potential_evaporation_flux) should be updated from
static const char *input_var_units[INPUT_VAR_NAME_COUNT] = {
"kg m-2",
"m s-1"
};
in bmi_topmodel.c
https://github.com/NOAA-OWP/topmodel/blob/479d00684971977bc39f44491515c49fc82ab37e/src/bmi_topmodel.c#L122
to,
static const char *input_var_units[INPUT_VAR_NAME_COUNT] = {
"kg m-2/1000.0",
"kg m-2/1000.0"
};
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NOAA-OWP/topmodel/issues/18, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB2T4L6XNYVNBCQLYAZ457DULV4ITANCNFSM5H5U6FRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@madMatchstick To echo what Scott said, please do not add numerical conversion to the units. Additionally, neither of those conversions would produce m/h.

@SnowHydrology @peckhams @lcunha0118 Agreed - conversion constants for var units does seem a bit off.  What is, then, the proper string that I'm after here? Just m h-1, yes?

Just remove the constants, so "kg m-2/1000.0" becomes "kg m-2".
Best,
Scott
On Fri, Nov 12, 2021 at 4:31 PM JessicaGarrett-NOAA <
@.***> wrote:

@SnowHydrology https://github.com/SnowHydrology @peckhams
https://github.com/peckhams @lcunha0118 https://github.com/lcunha0118
Agreed - conversion constants for var units does seem a bit off. What is,
then, the proper string that I'm after here? Just m h-1, yes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NOAA-OWP/topmodel/issues/18#issuecomment-967726994,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB2T4L26FOVQ6RFAWDNHOTTULWPV7ANCNFSM5H5U6FRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Does bmi-cfe have similar issue?
On Fri, Nov 12, 2021 at 6:31 PM Scott D. Peckham @.***>
wrote:

Just remove the constants, so "kg m-2/1000.0" becomes "kg m-2".
Best,
Scott
On Fri, Nov 12, 2021 at 4:31 PM JessicaGarrett-NOAA <
@.***> wrote:

@SnowHydrology https://github.com/SnowHydrology @peckhams
https://github.com/peckhams @lcunha0118 <https://github.com/lcunha0118
Agreed - conversion constants for var units does seem a bit off. What is,
then, the proper string that I'm after here? Just m h-1, yes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NOAA-OWP/topmodel/issues/18#issuecomment-967726994,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AB2T4L26FOVQ6RFAWDNHOTTULWPV7ANCNFSM5H5U6FRA
.
Triage notifications on the go with GitHub Mobile for iOS
<
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
<
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NOAA-OWP/topmodel/issues/18#issuecomment-967743547,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACA4SRJO7L5ICXZI6W2CS33ULWWU5ANCNFSM5H5U6FRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@madMatchstick and @peckhams, if the model is expecting input precipitation in m/h, then its BMI specification should give 'm h-1' as the var_unit. It will be up to the model engine to make conversions.

When I looked at this last week, I saw kg m-2, so I asked Jess to add kg m-2/1000 as a place hold so the group can discuss what would be the best approach. It seems that "atmosphere_water__liquid_equivalent_precipitation_rate" should be a volume and not a rate (????) and that is why we did not specify m/h directly. @peckhams , any comment on that? For example, in CFE atmosphere_water__liquid_equivalent_precipitation_rate units is kg m-2.

Actually, m/h does not work since the unit is volume/dt... and dt is not necessarily hour.

From https://csdms.colorado.edu/wiki/CSN_Searchable_List-Names, atmosphere_water__domain_time_integral_of_rainfall_volume_flux ?  Recall topmodel only considers precip as rain...

To confirm what @lcunha0118 said, my reading is that TOPMODEL expects precipitation to be given in the unit of m per timestep. This is trivial when the timestep is 1 h, but less so when it is not.


Starting agent in a navigable position

Habitat-Sim version
v0.1.5 (but I am asking in general)
Hello, I have a question about knowing a valid "start position" of the agent.
I know that there are episodes data provided by the "navigation challenges" (for example, gibson's episode data here: https://github.com/devendrachaplot/Object-Goal-Navigation), and there are "starting poses" in these data.
I wonder if I can get a valid starting pose (that is inside the house and not under the floor, etc), from a random scene (for gibson, hm3d, or other data). I have seen this post: https://github.com/devendrachaplot/Object-Goal-Navigation, but it looks like we can't get a valid "z" position (height) of where the agent is standing, with this method.
By any chance, is there a way to figure out a valid starting position in a ".glb"?
Thank you all the time!

Please read the "Habitat-Sim Basics for Navigation" tutorial: https://aihabitat.org/tutorial/2020/
And in general, please consider going through the tutorials.


Reclaim one byte from HeaderString.

Description:
With conversion to getStringView() access there is no longer any need to
reserve a NUL byte at the end of the HeaderString since all accesses
will be through string_views which are not required to be NUL
terminated.
Ran bazel test -c opt //test/... --config=asan --runs_per_test=10
without issue. There is some risk that someone has or will abuse the
data() accessor on a string_view assuming it is NUL terminated. A
comment is added to emphasize that the HeaderString::getStringView() is
not NUL terminated.
By eliminating this wasted byte it is more likely that a HeaderString
will fit into the existing embedded space, hopefully giving a small
performance gain and reduction in memory allocations.
Signed-off-by: Dan Noé<EMAIL_ADDRESS>Risk Level: Medium
Testing: bazel test -c opt //test/... --config=asan --runs_per_test=10
Docs Changes: None
Release Notes: None
Part of: Issue #6580

Sorry about the force push, somehow I screwed up my local branch trying to be smart. It should be the same two commits, so you can see the changes by looking at the second commit.

Manual inspection finds no mis-use of data() - all users are properly using data() in a context where the length is explicitly specified.


[CONTAINER] Introduce StrMap

Allows use of map of str->node, specializes Map<std::string,NodeRefType>, useful in storing additional attributes.
@merrymercy can you review and when merged followup with attrs field in the op?

cc @jroesch


Run transaction in dry mode first

With MainNet life, it's really bad to have failed transactions because we have wrong arguments or something else.
General solution is to have a dry mode, when transaction is executed in "view only" and everything is validated.
Caveats: nearcore fails right now because of deposit / sender are missing in view mode.
We may want to modify that with additional flags to support this.

Should also consider how to prevent abuse because you can easily do some expensive stuff with function calls.


client.ts Not Detecting Commands

Hey, thanks for this template!
I recently started using this repo and noticed that the commands weren't registering, and when i looked into client/client.ts, I realized it was filtering .js files instead of .ts files.
Example:
https://github.com/KingOKarma/discord.js-v13TS-template/blob/75116eec35b761684bb7c5a1e1c6f69bed5d29a5/src/client/client.ts#L27
Changing it to .ts fixes it for me, and it looks like most of the readdirSync functions look for .js extensions.
This is a pretty small fix so I just wanted to let you know, but if you want I can definitely submit a PR!

Oops, just realized this was because ts-node-dev for my live reload; the commands will obviously work after running tsc lol.
I ended up adding both .ts and .js checks to the code, like so:
const cmds = readdirSync(`${commandPath}/${dir}`).filter((file) => file.endsWith(".js") || file.endsWith(".ts"));

I was thinking we could also use an environment variable to check if it's a dev environment with hot reload enabled.
Do you think these changes are worthwhile? I'll change the title to better reflect this issue now.


Email provider support

Hey I wanted to know if you are focusing on specific providers because currently a lot of the german email providers aren't working with your API, for ex. (GMX, Web.de, 1&1)
I think they have different responses and behaviours than the standard (Gmail, G-suite, Yahoo, iCloud)
Do you intend to support those as well in the future?
Thanks ;)

Thank you for bringing this up. I remember running into this issue when I was building the app a few months ago. The issue is that the server needs to have a PTR record that identifies the hostname using the hosts IP. Since Heroku doesn't natively support this type of thing I'll need to find an addon that does or host it elsewhere.
I'll work on taking care of this!
Thank you for the feedback, this should be a fairly simple fix!


Icons: Remove any  tags on generation

Description
There are 4 icons that contain titles, which is strange when it is displayed in the user interface

How Has This Been Tested?
visually
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[ ] I've added relevant tests.

You need to address the root cause of the titles.
I just tried and they will be re-generated by https://github.com/MudBlazor/MudBlazor/blob/dev/tools/Icons/Update-MudIcons.ps1

The source icons are here
https://github.com/google/material-design-icons/search?p=3&q=title&type=code
you probably need to PR them or add a regex in our generation tool to remove the titles.

The source icons are here https://github.com/google/material-design-icons/search?p=3&q=title&type=code you probably need to PR them or add a regex in our generation tool to remove the titles.

I've modified the generation tool locally.
But I can't run the script properly because of network issues, and I'll modify this PR when my testing is done

@mikes-gh I'm done. But I didn't upload the latest icon because the latest material icon removed 3 icons, and I think this should be put into a new PR

@QianMoXi Thanks a lot 👍


FR: more strings

This PR adds missing settings strings.

Pipeline is failing because of RU and DE locales.

Thank you for the update!


#801 protect from browser exception

in case of weird paths, Firefox might throw an exception calculating points at path length.

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Refactor (changes the way we code something without changing its functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] Latest master code has been merged into this branch
[ ] No commented out code (if required, place // TODO above with explanation)
[ ] No linting issues
[ ] Build is successful
[ ] Code follows the API Guidelines
[ ] Updated the documentation
[ ] Added tests to cover changes
[ ] All new and existing tests passed

Hi @shayh, thanks for opening the issue and for the fix!


SSL connectivity

TLS connectivity failing at ping step with example codes "hello" and "hello wallet" for go1.19.4 linux/amd64
with message:  Can't open connection: local error: tls: unexpected message
ConnStr : "oracle://user:pass@server/servicename?SSL=true&SSL Verify=false"
queryStr =  "SELECT 1 from DUAL"
Connection gets this far with malformed oracle service name:
Can't open connection: ORA-12514: TNS:listener does not currently know of service requested in connect descriptorSSL connection
Query succeeds with "tcp" (nonSSL) connection to TCP port
TLS Connection to target succeeds with another (nonSQL) SSL client app built with same go version + tls.Config{InsecureSkipVerify: true,} using tls.Dial("tcp","targetip:port", conf)
tracelog:
2023-02-01T16:20:05.4493: Connect
2023-02-01T16:20:05.4501: using: 10.x.x.x:15450 ..... [SUCCEED]
2023-02-01T16:20:05.4501: Using SSL/TLS
2023-02-01T16:20:05.4503: Open :(DESCRIPTION=(ADDRESS=(PROTOCOL=tcps)(HOST=10.x.x.x)(PORT=15450))(CONNECT_DATA=(SERVICE_NAME=xxxxxxxxxxxxxxxxxxxx)(CID=(PROGRAM=./oracle2)(HOST=host)(USER=user))))
2023-02-01T16:20:05.4503:
Write packet:
00000000  00 f5 00 00 01 00 00 00  01 3d 01 2c 0c 01 ff ff  |.........=.,....|
00000010  ff ff 4f 98 00 00 00 01  00 af 00 46 00 00 00 00  |..O........F....|
00000020  01 01 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
00000030  00 00 00 00 00 00 00 00  00 00 00 20 00 00 00 20  |........... ... |
00000040  00 00 00 00 00 00 28 44  45 53 43 52 49 50 54 49  |......(DESCRIPTI|
00000050  4f 4e 3d 28 41 44 44 52  45 53 53 3d 28 50 52 4f  |ON=(ADDRESS=(PRO|
00000060  54 4f 43 4f 4c 3d 74 63  70 73 29 28 48 4f 53 54  |TOCOL=tcps)(HOST|
00000070  3d 31 30 2e 00 00 2e 00  00 00 2e 00 00 29 28 50  |=10.xx.xxx.xx)(P|
00000080  4f 52 54 3d 31 35 34 35  30 29 29 28 43 4f 4e 4e  |ORT=15450))(CONN|
00000090  45 43 54 5f 44 41 54 41  3d 28 53 45 52 56 49 43  |ECT_DATA=(SERVIC|
000000a0  45 5f 4e 41 4d 45 3d 00  00 00 00 00 00 00 00 00  |E_NAME=xxxxxxxxx|
000000b0  00 00 00 00 00 00 00 00  00 29 28 43 49 44 3d 28  |xxxxxxxxx)(CID=(|
000000c0  50 52 4f 47 52 41 4d 3d  2e 2f 6f 72 61 63 6c 65  |PROGRAM=./oracle|
000000d0  32 29 28 48 4f 53 54 3d  00 00 00 00 00 00 00 00  |2)(HOST=xxxxxxxx|
000000e0  00 00 00 29 28 55 53 45  52 3d 00 00 00 00 00 00  |xxx)(USER=xxxxxx|
000000f0  00 29 29 29 29                                    |x))))|

Any ideas?

as you receive this error with using TLS connection
ORA-12514: TNS:listener does not currently know of service requested in connect descriptorSSL connection
this means connection using SSL is succeed with the server and server successfully return an error message
I think this message means that server listener.ora is not configured correctly

Wasn't sure whether to reply here or open a new issue, but I am also getting a local error: tls: unexpected message when I try to ping my database using SSL=enable&SSL verify=disable. I am not getting any ORA message back from the server. I will be happy to provide whatever additional information necessary to help troubleshoot. Just let me know what you need.

Thanks Samy for your prompt reply. The database (oracle 11g) is functional for java applications using  ojdbc6-11.2.04.jar.
What I was highlighting was that if "err = pool.Ping()" is called with an incorrect service, the SSL negotiation succeeds - because of the ORACLE-12514 error. However, if the service is correct, the  Ping() method returns the error:
"local error: tls: unexpected message.".
If I ignore the err returned from Ping(), then the same err responses (for both incorrect and correct service names) come back from:
stmt, err := pool.Prepare(queryStr) which implies that Ping() is not correctly completing the DB connection, or attempting something "clever" which is not TLS?.
The same go executable connecting to unencrypted 1521 and ?SSL=disable works OK.
ALSO: in our environment the SSL offloading is done at an F5 loadbalancer in front of the RAC cluster (OK with ojdbc6-11.2.04.jar). The error at the F5 is:   " warning tmm1[12809]: 01260009:4: Connection error: ssl_codec_parse:1512: record protocol version incorrect (47)" .

I think I found a fix for this. I am going to do some more testing and then I will open a pull request.

Wireshark thinks the second encrypted handshake Message has:
Transport Layer Security
TLSv1.2 Record Layer: Handshake Protocol: Encrypted Handshake Message
Content Type: Handshake (22)
Version: TLS 1.0 (0x301)    < ------ this is wrong!
Length:  279
Handshake Protocol: Encrypted Handshake Message

@penenin  I test your pull request and not function give EOF
server = 19c

please refer to this replay in issue #219

@sijms My change did allow me to connect to my Oracle Cloud instance. Maybe a local instance of Oracle behaves differently. I'll work on installing 19c locally, trying that and reworking my patch.
@jonathanw5 What version of Oracle are you trying to connect to and is it local or Oracle Cloud? Out of curiosity, does my patch fix things for you?

@sijms After further research, it looks like there is a protocol difference between mTLS (wallet) connections and TLS (walletless) connections. I was getting the same error with my first patch when trying to authenticate with a wallet. So if we restrict the session.negotiate() call to wallet connections only, it seems to now work for both scenarios. Again, tested against Oracle Cloud Autonomous Transaction Processing Database versions 19c and 21c. I am currently working on setting up a local Oracle XE instance to test against, but I don't have it set up yet.

Hi @penenin, @sijms   - yes that first fix works for me (lines 609-11),  both with "?SSL=true&SSL Verify=enable&wallet=./wallet"
and with ?SSL=true&SSL Verify=disable" (although I haven't tried to do a wallet authentication - only wallet CA root cert verify)
Thanks to both of you for a speedy fix.
I'll check out the other wallet-specific updates on Monday and report.

I test your pull request without using wallet and still give EOF

may be SSL Verify will make the response different

I find this code in the original dirver
case TNSPacketType.RESEND:
            // note that this.m_sessionCtx.m_transportAdapter.NeedReneg always true
            if ((pkt.m_flags & 8) != 0 && this.m_sessionCtx.m_transportAdapter.NeedReneg)
            {
              this.m_sessionCtx.m_transportAdapter.Renegotiate(this.m_connOption);
              this.m_sessionCtx.m_socketStream = this.m_sessionCtx.m_transportAdapter.GetStream();
              this.m_sessionCtx.m_socket = this.m_sessionCtx.m_transportAdapter.GetSocket();
              if (this.m_sessionCtx.m_socketStream == null)
                throw new NetworkException(12614);
              continue;
            }
            continue;

so it is clear that (pkt.m_flags & 8) != 0 is the controller of the operation
i make a commit add this flag in session.go file
could you test it before make new release

@sijms Your fix is working on everything I have to test against.

very good I find another place (condition for renegotiation
case DATA:
	dataPck, err := newDataPacketFromData(packetData, session.Context)
	if session.Context.ConnOption.SSL && dataPck != nil && dataPck.dataFlag == 0x8000 {
		session.negotiate()
	}
	return dataPck, err

now we can close re-negotiation file
I make new release contain these fixes

@sijms  Your latest update works on my targets - thanks. Also thanks to @penenin

@sijms I've updated the client wallet with client host name following the example you provided but I still getting the same error. I also updated to the latest version.
add client certificate
orapki wallet add -wallet "/tmp" -pwd @Password -dn "CN=adriano-mac" -keysize 1024 -self_signed -validity 3650
urlOptions := map[string]string{
"trace file":        "./logs/trace.log",
"ssl verify":        "false",
"wallet":            dbParams["walletLocation"],
"ssl":               "true",
}
databaseURL := go_ora.BuildUrl(dbParams["server"], port, dbParams["service"], dbParams["username"], dbParams["password"], urlOptions)
fmt.Printf("databaseURL: %v\n", databaseURL)
conn, err := go_ora.NewConnection(databaseURL)
if err != nil {
panic(fmt.Errorf("can't create connection:  %w", err))
}
err = conn.Open()
if err != nil {
panic(fmt.Errorf("can't open connection: %w", err))
}

error:
panic: can't open connection: remote error: tls: handshake failure

2023-02-06T15:50:40.3446: Connect
2023-02-06T15:50:40.4458: using: dbhostxxxxxxxxxxxxxx:1500 ..... [SUCCEED]
2023-02-06T15:50:40.4461: Using SSL/TLS
2023-02-06T15:50:40.4461: Open :(DESCRIPTION=(ADDRESS=(PROTOCOL=tcps)(HOST=dbhostxxxxxxxxxxxxxx)(PORT=1500))(CONNECT_DATA=(SERVICE_NAME=dbsidxxxx)(CID=(PROGRAM=./gg-cli)(HOST=adriano-mac)(USER=adriano))))
2023-02-06T15:50:40.4462:
Write packet:
00000000  01 05 00 00 01 00 00 00  01 3d 01 2c 0c 01 ff ff  |.........=.,....|
00000010  ff ff 4f 98 00 00 00 01  00 bf 00 46 00 00 00 00  |..O........F....|
00000020  01 01 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
00000030  00 00 00 00 00 00 00 00  00 00 00 20 00 00 00 20  |........... ... |
00000040  00 00 00 00 00 00 28 44  45 53 43 52 49 50 54 49  |......(DESCRIPTI|
00000050  4f 4e 3d 28 41 44 44 52  45 53 53 3d 28 50 52 4f  |ON=(ADDRESS=(PRO|
00000060  54 4f 43 4f 4c 3d 74 63  70 73 29 28 48 4f 53 54  |TOCOL=tcps)(HOST|
00000070  3d 64 62 7a 69 6e 67 6d  70 2e 67 2e 61 70 70 6c  |=dbhostxxxxxxxxx|
00000080  65 2e 63 6f 6d 29 28 50  4f 52 54 3d 31 35 32 35  |xxxxx)(PORT=1500|
00000090  29 29 28 43 4f 4e 4e 45  43 54 5f 44 41 54 41 3d  |))(CONNECT_DATA=|
000000a0  28 53 45 52 56 49 43 45  5f 4e 41 4d 45 3d 7a 69  |(SERVICE_NAME=db|
000000b0  6e 67 6d 70 5f 72 77 29  28 43 49 44 3d 28 50 52  |sidxxxx)(CID=(PR|
000000c0  4f 47 52 41 4d 3d 2e 2f  67 67 2d 63 6c 69 29 28  |OGRAM=./gg-cli)(|
000000d0  48 4f 53 54 3d 41 64 72  69 61 6e 6f 2d 2d 2d 4d  |HOST=adriano-mac|
000000e0  61 63 42 6f 6f 6b 2d 50  72 6f 2d 31 36 2e 6c 6f  |                  |
000000f0  63 61 6c 29 28 55 53 45  52 3d 61 64 72 69 61 6e  |cal)(USER=adrian|
00000100  6f 29 29 29 29                                    |o))))|

the tracer.log show that was able to connect successful with the db host but handshake failed.

could you please test the latest version because i fix a bug related to TCPS connection

the server wallet should be updated with certificate of the client host name otherwise connection will not work

I'm not trying todo mTLS, I just need to have the root ca in my wallet and I'm able to connect. I can do that from SQL Developer, java and all the other apps I have in other languages using this same wallet. All works without adding any certificate in the server but when I try with you driver I get this handshake error.

Is there any way to enable more verbose logs?

@adrianosantos : what files are in your wallet directory? I found there MUST be a "cwallet.sso" file as well as the "ewallet.p12" file, even if you are not using authentication (use a dummy user/password).  Then the certificate was accepted by my app.

@jonathanw5 I have the "ewallet.p12" and "cwallet.sso". The wallet has password and has the auto login configured. I have the user/password sent as well.


added multiple lines shell example

Brief Summary of The Change

Pull Request checklist
I confirm that the following checklist has been completed.

[ ] Add/Change test cases for the changes.
[ ] Add/Change the related documentation, should also change docs/source/config.rst when you change file default_config.yaml.
[ ] (Optional) Add your change to UPDATING.md when it is an incompatible change.

@ zhongjiajie please review it once.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e04b836) 90.93% compared to head (a6b5e29) 90.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   90.93%   90.93%
=======================================
  Files          64       64
  Lines        2361     2361
=======================================
  Hits         2147     2147
  Misses        214      214

Flag
Coverage Δ

unittests
90.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.