Chore: add build step to bundle client-side assets

refs https://github.com/eslint/eslint.github.io/issues/576
~I believe I have everything working except for the styling of the JS in the demo. orion/editor/built-editor.js relies on RequireJS to request orion/editor/stylers/application_javascript/syntax, and it's currently not able to find the module.~ I dug into this some more, and Orion requires the syntax highlighting file asynchronously at run time. I struggled with it for a bit and found it easier to just switch it out for CodeMirror (the Babel REPL uses this as well).
There are a lot of ways we can organize the code, and after exploring a few options this felt like the solution with the least amount of developer friction and overhead. It gets rid of some top level directories (I'd ideally like to move a lot of these top level directories into sub-directories to clean up the root directory of the repo) and puts all the client-side assets in one assets/ directory (which is what  Jekyll suggests). I didn't rename styles to css, but we definitely can.
Happy to discuss other ways of doing things, though, if others have strong opinions!
Landing this opens us up a lot of options to us, and I wanted to keep this (mostly) limited to implementing a build step in a sane way.
Finally, some things we definitely need to do if we land this as-is:

We'll also need to update the release script before the next release. That being said, I think it could be nice to explore instead bundling latest Espree/ESLint in this repository at build time in the future.

We'll need to change the command Netlify runs before this is merged so that it'll build correctly.

Note: The design is slightly different for the demo, but I think it's a little cleaner looking:

I removed the border because I think it's a little cleaner looking
I changed the error underline from a red squiggly line to a red dotted line because the squiggly line wouldn't show up correctly when highlighting one character (which we do for a syntax error)

See updated design below:

Putting the do not merge label on this since the deploy preview version of the site isn't able to load all assets at the moment.

@kaicataldo Could you possibly separate CodeMirror into it's own PR that we can merge before we do this one? I would like to see those changes before we do a big-bang build changes.

@ilyavolodin I do generally try to decouple tasks like this, but the reason I switched out Orion for CodeMirror is because it was difficult to get Orion to play nicely with webpack and ES modules.
I can spend time getting CodeMirror to work with the RequireJS setup we currently have (maybe by using a CDN?), but I’m not sure it buys us much if we’re going to be adding the bundling step soon anyway (unless you foresee us not merging this PR for a while).

As a follow up to  deploy preview version not being able to load assets - it's because the URLs are using {{ site.url }} and so the staging environment is requesting assets from eslint.org. I don't think we have to fix deploy previews in this PR (and would rather decouple that from this task and land this first), but we could maybe use something like https://github.com/jayvdb/jekyll-netlify to access the deploy preview URL.

I know this is a large PR, but a lot of it is actually the removal of files and package-lock.json changes. I think I did a pretty good job of isolating individual tasks in commits, and I think reviewing commit by commit makes it a lot easier to review.

As discussed via email, I'm going to go ahead and merge this. Happy to continue discussing any of these decisions!


Adds the ability to specify options to Drivers, Producers and Queues

I'm using bernard in a project where we're primarily using Amazon SQS and PDO in development but want the flexibility to switch to Iron MQ in the future. In the interim we would like to utilize Amazon SQS more efficiently for our purposes, i.e. increase the timeout while long polling and use a delay when queuing certain types of messages.
I've implemented this by adding an optional options array as the last parameter of the relevant interfaces/abstract classes and added optional driver options where applicable, e.g. pheanstalk and sqs both support a delay.
Note: this could potentially be breaking if users have custom implementations of Bernard\Driver or Bernard\Queue and have changed the signatures of the pushMessage and enqueue methods respectively.

Duplicates #206


FreeDraw

I am using the sample code you provided for Issue #947 using Leaflet FreeDraw.  It works fine except it doesn't know when to stop drawing the polygon.  Whereas with your example you can complete drawing a freehand polygon, then select another drawing tool and draw the shape on the map.  For me, when I finish drawing a freehand polygon and then select another drawing tool, the api thinks I am still drawing.  Notice here what happens when I select the Polyline tool after I finish drawing a freehand polygon:

I have set the leaveModeAfterCreate option to true when I instantiated FreeDraw like this:
const freeDraw = new FreeDraw({     leaveModeAfterCreate: true,     strokeWidth: 4 });
but as you can see the freehand polygon tool does not leave the CREATE mode after I finish drawing a polygon; it still thinks I am still drawing when I select another drawing tool.
I understand that Leaflet FreeDraw is not your library, but perhaps you may know why the freehand tool is behaving this way and can offer a solution. I understand if you don't have a solution, I will then file an issue with Leaflet.FreeDraw on their GIT.
Thank you

Please create a jsfiddle because I can't reproduce this. When you look into the example: https://jsfiddle.net/falkedesign/stmg297a/ freedrawing is stopped when switching to another drawing tool.
This happens because when switching to another drawing tool the onClick function of the freedrawing control is called and then freedrawing is toggled and disabled.


Added positions submitted via email + updated positions already on th…

…e job board

just checking that this works before I deploy it :)


argument parser acting strange (not trimming spaces?)

not-working script:
#!/usr/bin/env bash

# usage:
#   ./compress.sh    # build + minify
#   ./compress.sh 1  # build only

MINIFY="--minify"
if [[ -n "$1" ]]; then
  echo "skipping minification..."
  MINIFY=""
fi

/w/shrinko8/shrinko8.py game.p8 tower.p8.png --lint --count "$MINIFY" --script compress_combine.py

when I ./compress.sh, shrinko8 runs normally. when I ./compress.sh 1, it shows the usage string and says shrinko8.py: error: unrecognized arguments:, which is unexpected (I expect it to run normally)
I assume the problem is because the command ends up having two spaces in it, which confuses the argument parser, but I haven't looked into it.
My shrinko8 commit hash is 8a4f6e0

workaround:
#!/usr/bin/env bash

# usage:
#   ./compress.sh    # build + minify
#   ./compress.sh 1  # build only

MINIFY="--minify"
if [[ -n "$1" ]]; then
  echo "skipping minification..."
  MINIFY="--count" # hacky
fi

/w/shrinko8/shrinko8.py game.p8 tower.p8.png --lint --count "$MINIFY" --script compress_combine.py

ah my bad; when minify is empty --count "$MINIFY" --script becomes --count "" --script, and the argparser (correctly) wonders "uhhh why did you pass me an empty string there in the middle?"
removing the quotes works as expected:
#!/usr/bin/env bash

# usage:
#   ./compress.sh    # build + minify
#   ./compress.sh 1  # build only

MINIFY="--minify"
if [[ -n "$1" ]]; then
  echo "skipping minification..."
  MINIFY=""
fi

/w/shrinko8/shrinko8.py game.p8 tower.p8.png --lint --count $MINIFY --script compress_combine.py

whoops -- I should have looked into this more before opening an issue!


Autostart on Debian

First of all let me just thank you for this amazing script. This helped me get it all running and working 🥇
However, each time I restart the container (Debian GNU/Linux 9) OpenVPN needs to be started again.
What I have been doing so far is:
vpn@vpn:~$ sudo systemctl enable<EMAIL_ADDRESS>vpn@vpn:~$ sudo systemctl start<EMAIL_ADDRESS>
Could someone help me? 🙏

This must be a problem in your side, maybe related to OpenVZ.
The default script setup will run the service on startup, so if that is not being the case something must be wrong. Additionally, systemctl enable should enable the service to run at startup if it was disabled for some reason.
My suggestions:

Check the logs, likely the service is trying to start the VPN server but is failing for some reason.
Unlikely that this is the cause of your problem, but still worth checking: https://github.com/Nyr/openvpn-install/issues/206

Thanks!
I differently think it's on my end. It's however a all clean container with nothing else than the script and the newest Debian version. Where would I find the logs so i can study them?

systemctl status<EMAIL_ADDRESS>If you need longer output:
grep ovpn /var/log/syslog

I solved the issue by looking into the log file: grep ovpn /var/log/syslog
vpn ovpn-server[96]: ERROR: Cannot open TUN/TAP dev /dev/net/tun: No such file or directory (errno=2)
vpn ovpn-server[96]: Exiting due to fatal error

I am using Proxmox, so i need to open TUN/TAP manually which is a systemctl script on its own, so the problem was that the<EMAIL_ADDRESS>was run before TUN/TAP was correctly setup. Solved it with a Before=.
Maybe this will help others, in the future.


libjson-rpc-cpp-dev is not a valid package in 15.10+

As the title says.
libjson-rpc-cpp-dev => libjsonrpccpp-dev

does this just need to be updated in the readme?
I got the same error with ubuntu  16.04

Yes, the README needs to be updated.  My pull #140 would fix the README.


Request approval to release Text Analytics 1.0.0

Context:
Service released their 3.0 version API. Our client libraries released a 1.0.0-preview.5 (preview.6 for Python) package on 05/27/2020 with the corresponding changes and support for that service version.
Test have been passing and now we are ready to release 1.0.0. There are no API changes between releases.

.NET:

APIView
Readme

Java:

APIView
Readme

Python:

APIView
Readme

JS:

APIView
Draft PR for comments
Readme

cc: @KrzysztofCwalina @johanste @bterlson @JonathanGiles
FYI @mayurid @iscai-msft @mssfang @willmtemple

JS looks good! Congratulations for releasing an awesome library! 🎉🎉

Looks good too. Thanks for preparing the library for GA!

Is it 'subcategory' or 'subCategory'? I see differences between the languages: Java and Python are subcategory and C# and JS are subCategory

In C# I note that the *Input classes derive from TextAnalyticsInput, whereas in Java, Python, and JS there is no common type so Id and Text getters are duplicated on each *Input class. Was there a reason to deviate here?

Other than the comments above and the 'Analyze' typo everywhere (it should obviously be 'Analyse' :-) ), the Java API looks good too.

Oh, and recognize needs changing to recognise too 😄

:shipit:

To clarify - nothing I mentioned is ship-blocking, just minor observations and curiosities. And the spelling comments were attempts at humour, not meant to be taken seriously :-)

subcategory and C# and JS are subCategory

Thanks for pointing that out! Will take a look.

TextAnalyticsInput in .NET

We added it after the .NET arch board meeting as an attempt to unify input type. the rest of the v-team didn't feel strongly about this, so we made the change in .NET making sure that user experience across languages is the same.
As an example, if want to detect language in a doc, the input will look like:
new DetectLanguageInput("1", "Hello world")

.NET - Java

spelling comments

lol. I actually looked the dictionary wondering if it was one of those instances where my English was wrong :P
=> Thank you!

Thanks board. The crew discussed among themselves as well as based on my chat with Jonathan we decided none of the comments warrant a change late in cycle with the planned GA.
Thank you all for your approval. We will proceed to our release next week


Quantstamp Token (QSP) Added

Project website: https://quantstamp.com/
Etherscan: https://etherscan.io/address/0x99ea4db9ee77acd40b119bd1dc4e33e1c070b80d
Facebook: https://www.facebook.com/quantstamp/
Twitter: https://twitter.com/Quantstamp
CoinMarketCap: https://coinmarketcap.com/currencies/quantstamp/

Hi @alex-murashkin in order to merge this we need at least NEUTRAL reputation on etherscan, let me know if you have any doubt. thanks

Hi @estebanmino ,
Thanks for lettings us know. Our reputation has now changed to NEUTRAL, according to Etherscan:

Any chance we could try again? Thanks!


Add changelog for 0.13.0

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@fa9414b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #446   +/-   ##
=========================================
  Coverage          ?   64.08%
=========================================
  Files             ?       53
  Lines             ?     3957
  Branches          ?        0
=========================================
  Hits              ?     2536
  Misses            ?     1421
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa9414b...34ecd94. Read the comment docs.


Browser Session Handling using MSAL.

Core Library
MSAL.js (@azure/msal-browser)
Core Library Version
2.14.2
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.0.0
Public or Confidential Client?
Public
Description
We have requirement to store MSAL acquired token in cache and it should clear automatically on closing all browser windows and also should share token between windows and tabs.  We are using Angular 14 at front end.
Has any body implemented similar requirement. Can you please shed some light on the approach you have taken.
MSAL Configuration
{
  cache: {
    cacheLocation: "localStorage"
  }
}

Relevant Code Snippets
No response
Identity Provider
Azure B2C Custom Policy
Source
External (Customer)

To share cache between tabs/windows use localStorage. To clear cache when closing a window you can subscribe to the beforeUnload browser event and clear localStorage prior to exiting. To ensure you don't clear cache while other tabs are still open will likely require more complex custom logic that extends beyond the scope of MSAL.js and the support we're able to offer. I would suggest asking your question over on StackOverflow.


[DONOTMERGE] test: update submodules to see where CI breaks

DO NOT MERGE, just testing for CI errors

Depends on the following:
https://github.com/tiiuae/px4-firmware/pull/468
https://github.com/tiiuae/saluki-pi/pull/8
https://github.com/tiiuae/saluki-v1/pull/115
https://github.com/tiiuae/saluki-v2/pull/27

No idea what the "Failsafe Simulator Build" is or why it's failing


⚠ Bofrost.at has degraded performance

In 0919709, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 860 ms

Resolved: Bofrost.at performance has improved in 8934d69 after 13 minutes.


Change enabled to disabled?

OK so, I was considering this a while ago, but didn't bother changing it because:

We use state.isEnabled in tippy
Positive booleans are "preferred"

However in the case of JSX/HTML, disabled is the standard attribute, and a false default makes things easier.
Should we change this prop in the next major?

I'll change this in v4.


Angular-material input not rendering inside a ui-view

When a partial is loaded in the ui-view, the input is not being rendered. The md-input-container and the label directive functions seem to be getting called but not the input. When the snippet of code is placed outside the ui-view, it is rendered correctly. Can't figure out a solution.
Seems to be a conflict with ui-router and angular-material.
Below is the snippet of code that does not work in ui-router:

Username

Looks like it was an older version. Updated all the libraries and it worked.

I'm using angular material 0.7.1 and ui-router 0.2.13
I'm not able to put <md- items into a ui-view

Also try updating to the latest version of Angular. I think this is what did it for me. Mine was on 1.3.8 and I updated to 1.3.12.

Using angular 1.3.13


Variable step integrator refactoring

For the refactoring of the variable step integrators, a new interface should be made.
This interface would take care purely of the step size control, not of the integration itself. Inputs of this interface would be:

minimum_step_size
maximum_step_size
relative_error_tolerance
absolute_error_tolerance
safety_factor
maximum_factor_increase
minimum_factor_increase
throw_exception_if_minimum_step_exceeded

Then, during the propagation, the integrator would call this interface, giving the current time, truncation error of the state (computed from the two RK orders), and the order. This interface will then return the next time step.
Having this interface setup this way (especially the method that takes the time, error, and order), allows for more flexibility in later adding variations of this interface, for instance for custom step size control. The integrator will then recognize alternative step size control methods as similar.
Having this interface separated will probably also appear cleaner for users to use.

From a Slack message I sent to Dominic:
The envisioned setup for this would be to create a new class, called ErrorToleranceBasedStepSize (or something more catchy), that will be initialised with all of the parameters related to step size control that we have now (tolerance, min/max step sizes, safety factors, min/max factor increases, etc). Then, the runge_kutta_variable_step_size integrator would be initialise with a function that is a member of ErrorToleranceBasedStepSize , let's say ErrorToleranceBasedStepSize.computeStepSize(). This function will take the estimated error, integrator orders, and time as inputs (but not do anything with the time), and return the optimum time step.
This setup allows for any function to be passed to runge_kutta_variable_step_size for step size control. At first, ErrorToleranceBasedStepSize.computeStepSize() for step size control like currently implemented, but then, a function can also easily be user-defined.
Dominic added the following:
Let ErrorToleranceBasedStepSize be a derived class of some StepSizeController base class (with the computeStepSize a pure virtual funcion). We can then implement derived classes of these, with the ErrorToleranceBasedStepSize derived class implementing the current functionality


ResourceSaver duplicates items in all arrays

Godot version:
3.1
OS/device including version:
Windows 10
Issue description:
ResourceSaver duplicates items in all arrays upon saving
Minimal reproduction script:
extends Node2D

class Save:
	extends Resource

	export var version : String = "1.0"
	export var save_name : String = "Whatever"

	export var arr1: Array = []
	export var arr2: Array = []
	export var arr3: Array = []

func _ready():
	var save := Save.new()

	save.arr1.push_back({"name": "Plane"})
	save.arr2.push_back({"name": "Human"})
	save.arr3.push_back({"name": "Cat"})

	ResourceSaver.save("res://test.tres", save)

test.tres:
[gd_resource type="Resource" load_steps=2 format=2]

[sub_resource type="GDScript" id=1]

[resource]
script = SubResource( 1 )
version = "1.0"
save_name = "Whatever"
arr1 = [ {
"name": "Plane"
}, {
"name": "Human"
}, {
"name": "Cat"
} ]
arr2 = [ {
"name": "Plane"
}, {
"name": "Human"
}, {
"name": "Cat"
} ]
arr3 = [ {
"name": "Plane"
}, {
"name": "Human"
}, {
"name": "Cat"
} ]

The actual problem here is that each exported array is the same instance. I remember it being mentioned/reported somewhere (like this related issue #20436), but not sure if there was some proper fix/workaround.
btw, this makes Resources almost useless for saving game progress, because you often need to use arrays in complex games.

The erroneous sharing between typed arrays and dictionaries should be fixed in 3.2, see https://github.com/godotengine/godot/issues/24134
In the meantime, if you give your Save class an _init function, you should be able to bypass this (heavy emphasis on should because I haven't tried saving exported arrays since v306):
func _init():     arr1 = []     arr2 = []     arr3 = []

Hey, thanks for the heads up @PetePete1984
I ended up using
class Save:
	extends Resource

	export var version : String = "1.0"
	export var save_name : String = "Whatever"
	export var save_data = {
		"nodes": [],
		"connections": []
	}

The erroneous sharing between typed arrays and dictionaries should be fixed in 3.2, see #24134
In the meantime, if you give your Save class an _init function, you should be able to bypass this (heavy emphasis on should because I haven't tried saving exported arrays since v306):
func _init():
    arr1 = []
    arr2 = []
    arr3 = []

Stumbled upon the same issue. Can confirm, @PetePete1984's workaround suggestion works.

The erroneous sharing between typed arrays and dictionaries should be fixed in 3.2, see #24134

Tested in 4493957 and the problem still exists.

So, another way to avoid this is not initializing the arrays:
export var arr1: Array
export var arr2: Array
export var arr3: Array

They are initialized automatically to unique references.

The issues related to this mentioned that dictionaries also had this problem; in my own experiments, the dictionaries were fine, but the arrays would still share the same instance.  Not initializing them does the trick.

Eh, if someone is interested, export var arr = [] executes code blocks at these lines:
https://github.com/godotengine/godot/blob/4ee8ecd3efee742be58c1ff191e78d0de09b57b6/modules/gdscript/gdscript_parser.cpp#L927
https://github.com/godotengine/godot/blob/4ee8ecd3efee742be58c1ff191e78d0de09b57b6/modules/gdscript/gdscript_parser.cpp#L1619
Same operation for dictionaries uses exactly the same code, so not sure where is the part that makes arrays shared (but probably there are some parts I'm not aware of and these might differ. Dunno). I used #28603 to get a clue where to look, but then got stuck :/

Still valid in a609b30

I just stumbled into this in an instanced scene. My tool script was editing every single empty array in the default values of the scene that I instanced.
I can work around this by creating a new array if it was empty, but it takes time to figure out what was going on.

Would it be because arrays were made to be compared by value, therefore making them under the same key if indexed in a map or hashmap? If dictionaries also get compared by value they might end up with the same problem


onboard Storage-datalake to rush

Onboarding storage-datalake to rush
@Azure/azure-sdk-eng @HarshaNalluru

Hey @KarishmaGhiya, I'm not the one working on storage-datalake. You might need to confirm with someone who is actually working on this sdk.


 A dedicated meta seems overkilling for just a recipe. Maybe you have plans to create a meta-theimagingsource?

Hi,
First of all, thank you for your contribution. We really appreciate it!
We had some internal debates as to how to handle cases like this.
We want to ensure that all parts of tiscamera are properly maintained and
ensured to be working,
thus we opened a separate repository for contributions that we see ourselves unable to maintain/test.
You can find it here:
https://github.com/TheImagingSource/tiscamera-contributions
You can open a merge request to add your recipe. Maybe even a short description of what people are looking at.
Thank you again and looking forward to your merge request.


Find number of observations per band in ensemble without computing

Ensemble.count at the moment gives number of observations for a total lightcurve, i.e., all bands together. Implement that it gives a count per band, if desired.

The object table now natively tracks nobs by band.


Leetcode solution to 648

Is there an existing issue for this?

[X] I have searched the existing issues

Issue Description
Leetcode solution to 648
Suggested Change
Leetcode solution to 648
Rationale
No response
Urgency
High
Acknowledgements

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository
[X] I have read and followed the Contribution Guidelines
[X] I have followed the code style guidelines of this project
[X] I have checked for any existing open issues that my pull request may address
[X] I have ensured that my changes do not break any existing functionality
[X] Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently
[X] I have read the resources for guidance listed below
[X] I have not used AI-generated content (e.g., ChatGPT, other AI tools)
[X] I have not used content from existing sites (e.g., text, images)
[X] I have followed all security rules and only shared trusted resources

Hi @Hemav009,
Here are some Guidelines for Writing DSA Problem Solutions for your reference. Please ensure that all your contents follow these guidelines so that we can maintain the quality of the solutions at a high level.
Feel free to ask if you have any questions.


Vue UI host ignored in configuration

Version
4.2.3
Environment info
  System:                                                                                │
    OS: Linux 5.4 Alpine Linux                                                                           │
    CPU: (4) x64 Intel(R) Core(TM) m3-6Y30 CPU @ 0.90GHz                                                 │
  Binaries:                                                                                │
    Node: 12.15.0 - /usr/bin/node                                                                        │
    Yarn: Not Found                                                                                │
    npm: 6.13.4 - /usr/bin/npm                                                                           │
  Browsers:                                                                                │
    Chrome: Not Found                                                                                │
    Firefox: Not Found                                                                                │
  npmGlobalPackages:                                                                                │
    @vue/cli: 4.2.3

Steps to reproduce
$ echo "module.exports = { devServer: { host: '<IP_ADDRESS>' }};" > vue.config.js && vue ui

What is expected?
The host parameter should be accounted when running vue ui.
What is actually happening?
The host parameter is not accounted when running vue ui.

i agree with this


fix: revert the exact filter method

In #199 we removed the exact matching for filtering, this caused problems when searching for aliases, for example trying to go to rolebinding would match for clusterrolebinding.
Returned the exact matching so that doesn't happen.
@mosheavni Will this revert affect the issue you had in #199? I'm thinking the issue you had was for filtering in content and not when filtering aliases, correct?

Since you kept string.find and not reverted back to string.match the filter still works! so all good.


issue with aws_auth.tf

I have issues
I'm submitting a...

[X] bug report
[ ] feature request
[X] support request - read the FAQ first!
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
when running the module and using iam_instance_profile_name as input for worker_group_launch_template I'm getting the following
:35 Error: Invalid template interpolation value
  on .terraform/modules/eks/terraform-aws-eks-12.0.0/aws_auth.tf line 7, in locals:
   7:       worker_role_arn = "arn:${data.aws_partition.current.partition}:iam::${data.aws_caller_identity.current.account_id}:role/${element(
   8:         coalescelist(
   9:           aws_iam_instance_profile.workers_launch_template.*.role,
  10:           data.aws_iam_instance_profile.custom_worker_group_launch_template_iam_instance_profile.*.role_name,
  11:           [""]
  12:         ),
  13:         index
  14:       )}"
    |----------------
    | aws_iam_instance_profile.workers_launch_template is empty tuple
    | data.aws_iam_instance_profile.custom_worker_group_launch_template_iam_instance_profile is tuple with 1 element

The expression result is null. Cannot include a null value in a string
template.

this is expected to work as the second value custom_worker_group_launch_template_iam_instance_profile is not empty
I'm unable to understand why it claims the value is null
If this is a bug, how to reproduce? Please include a code sample if relevant.
What's the expected behavior?
it should work
Are you able to fix this problem and submit a PR? Link here if you have already.
Environment details

Affected module version: 12.0.0
OS: linux
Terraform version: 0.12.24

Any other relevant info

Please post how you're calling the module

Please post how you're calling the module

this is no longer an issue,
closing the issue


Configure storage of Bitlocker recovery information to AD DS?????

Since the Bitlocker profile change in Intune under Endpoint Security, I've been wondering.... why the .... is there absolutely nothing written on writing Bitlocker recovery key information to Azure AD????
Please update the article to include information If the settings that are sugesting recovery key information will be saved to AD DS are also the settings that need to be used for AzureAD Joined devices to write the keys to Azure AD.
The information in the Bitlocker CSP is outdated in my opinion.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4a05802f-9d0f-9aeb-3c8e-8b92f1284202
Version Independent ID: 1fd9efc2-8946-75e4-27f3-95ac43a9d987
Content: BitLocker CSP - Windows Client Management
Content Source: windows/client-management/mdm/bitlocker-csp.md
Product: windows-client
Technology: itpro-manage
GitHub Login: @vinaypamnani-msft
Microsoft Alias: vinpa

Thank you for the feedback, @RefleCs. As @aczechowski mentioned I'm working on refreshing the whole BDE documentation and I'll take your feedback. Closing the issue at the moment.


Add high-level function for truncating to specified start/stop times

Hi,
Oftentimes it is useful to crop/truncate the EDF file to specified start and/or stop times (e.g. time in bed). I suggest adding a new function pyedflib.highlevel.truncate_edf (or "crop_edf")
This is an initial working implementation tested on pyedflib 0.1.30
"""Function to crop an EDF file to specified start/end times."""
from pathlib import Path
import pyedflib as pedf
import datetime as dt

def truncate_edf(path_edf, new_start=None, new_stop=None):
    """Truncate an EDF file to desired start/stop times.

    Parameters
    ----------
    path_edf : str
        The path the the EDF file
    new_start : datetime.datetime
        The new start timestamp
    new_stop : datetime.datetime
        The new stop timestamp
    """
    assert isinstance(new_start, (dt.datetime, type(None)))
    assert isinstance(new_stop, (dt.datetime, type(None)))
    path_edf = Path(path_edf)
    assert path_edf.exists(), "File does not exist."

    # Open the original EDF file
    edf = pedf.EdfReader(str(path_edf))
    signals_headers = edf.getSignalHeaders()
    header = edf.getHeader()

    # Define start/stop in samples
    current_start = edf.getStartdatetime()
    if new_start is None:
        new_start = current_start
    start_diff_seconds = (new_start - current_start).total_seconds()
    assert current_start <= new_start

    current_stop = current_start + dt.timedelta(seconds=edf.getFileDuration())
    current_duration = current_stop - current_start
    if new_stop is None:
        new_stop = current_stop
    assert new_stop <= current_stop
    stop_diff_from_start = (new_stop - current_start).total_seconds()

    # Crop each signal
    signals = []
    for i in range(len(edf.getSignalHeaders())):
        sf = edf.getSampleFrequency(i)
        start_idx = int(start_diff_seconds * sf)
        stop_idx = int(stop_diff_from_start * sf)
        signals.append(edf.readSignal(i, start=start_idx, n=stop_idx - start_idx))
    edf.close()

    # Update header startdate and save file
    header["startdate"] = new_start
    outpath = str(path_edf).replace(".edf", "cropped.edf")
    pedf.highlevel.write_edf(outpath, signals, signals_headers, header)

    # Get new EDF start, stop and duration
    edf = pedf.EdfReader(outpath)
    start = edf.getStartdatetime()
    stop = start + dt.timedelta(seconds=edf.getFileDuration())
    duration = stop - start
    edf.close()

    # Verbose
    print(f"Original: {current_start} to {current_stop} ({current_duration})")
    print(f"Truncated: {start} to {stop} ({duration})")
    print(f"Succesfully written file: {outpath}")

That sounds like a great addition!
Do you want to make a PR?

Sure thing, I'll submit a PR in the new couple of weeks. Is there anything that you'd modify from the initial code that I sent? Are there general contributing guidelines for this library?
Thanks


[Info Request] systemd-manager + systemd on Ubuntu from PPA

Hi, I've recently been following the git commits and am testing your systemd-manager GUI with great interest. On Arch Linux, everything works just fine. As I also use Ubuntu (16.04) on some machines, I tried to get it working there as well. Mixed results, untill I realized I had https://launchpad.net/~pitti/+archive/ubuntu/systemd active on my machines. As soon as I purged that, systemd-manager started to work as expected. I've contacted the PPA maintainer about this, requesting if he would be interested in looking into why systemd-manager errors-out with the systemd version from his PPA. Alas this is by e-mail and I haven't a URL to supply here. As soon as I get a response, I'll add it to the issue.
I do realize this might not be of interest to you. Enough on one's plate already etc. So this isn't a bug report, rather a request for info/thoughts on the issue at hand, as detailed in the output of relevant commands below. Thoughts?
Thanks for reading this,
glitsj16
= = = info (snippets) = = =
$ lsb_release -d
Description:	Ubuntu 16.04 LTS
scenario 1 :: without systemd PPA
$ apt-cache policy systemd
systemd:
Installed: 229-4ubuntu6
Candidate: 229-4ubuntu6
Version table:
*** 229-4ubuntu6 500
500 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
100 /var/lib/dpkg/status
229-4ubuntu4 500
500 http://archive.ubuntu.com/ubuntu xenial/main amd64 Packages
$ systemd-manager-pkexec
--> starts cleanly, works as expected
scenario 2 :: with systemd PPA
#+ https://launchpad.net/~pitti/+archive/ubuntu/systemd
$ sudo add-apt-repository ppa:pitti/systemd
$ sudo apt-get update && sudo apt-get -y update
...
$ apt-cache policy systemd
systemd:
Installed: 230+upstream20160523-0.master
Candidate: 230+upstream20160523-0.master
Version table:
*** 230+upstream20160523-0.master 500
500 http://ppa.launchpad.net/pitti/systemd/ubuntu xenial/main amd64 Packages
100 /var/lib/dpkg/status
229-4ubuntu6 500
500 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
229-4ubuntu4 500
500 http://archive.ubuntu.com/ubuntu xenial/main amd64 Packages
#+ 2.1 :: no reboot after upgrading systemd from PPA
$ systemd-manager-pkexec
thread '' panicked at 'Unknown Type: /run/systemd/generator/dev-disk-by\x2duuid-05839743\x2d3b4e\x2d4eab\x2d8408\x2dbab5cef3c4fe.swap', src/systemd/mod.rs:31
#+ 2.2 :: after upgrading systemd from PPA + reboot:
$ systemd-manager-pkexec
thread '' panicked at 'Unknown State:  Str("generated")])', src/systemd/mod.rs:51

I have all the Unit Types implemented here. It's designed to panic when an unknown type is detected. This is the first I've seen a swap unit type before. I'll add it to the list.

It should be fixed now with this patch.

Confirming the patch solved the issue as described under 'scenario 2.1'. Thanks you for working this in so fast & knowledgeable. I've copycatted your patch and did some more testing with scenario 2.2. After using the below patch I can know use systemd-manager without problems/errors, although I have no clue what it means, dumb luck I guess... Here's what I did, maybe it helps you in some way.
--- a/src/systemd/mod.rs
+++ b/src/systemd/mod.rs
@@ -35,7 +35,7 @@
}
#[derive(Clone, Debug, PartialEq, Eq)]
-pub enum UnitState { Bad, Disabled, Enabled, Indirect, Linked, Masked, Static }
+pub enum UnitState { Bad, Disabled, Enabled, Generated, Indirect, Linked, Masked, Static, Transient }
impl UnitState {
/// Takes the string containing the state information from the dbus message and converts it
/// into a UnitType by matching the first character.
@@ -49,6 +49,8 @@
'l' => UnitState::Linked,
'm' => UnitState::Masked,
'b' => UnitState::Bad,

       'g' => UnitState::Generated,

       't' => UnitState::Transient,
       _   => panic!("Unknown State: {}", x),
   }

}

I'll do some more testing on this, diffing changes introduced between systemd v229 & v230 as is available in the Ubuntu PPA. Please feel free to close this issue whenever you feel it satisfies your needs for this great GUI.
Cheers

Thanks for reporting the new states/types ahead of time. I have now added the two states with this patch. Arch Linux is still using systemd 229, which is what I'm using.
I don't, as of yet, actually use all these other types, but for the sake of completeness I think it's a good idea to ensure that the application collects that information properly, even if it does nothing with those states and types. The application mainly aims to be simplistic in only displaying the units that matter to the user -- units that can be enabled, disabled, stopped and started.


Support symbols

First, thanks for creating this plugin!
Sorry if I'm just doing something wrong but when I use the Go > Go to Symbol.. menu option I would expect to see methods, computed properties, and life-cycle methods (created, beforeDestroy). Instead I see script, template and sometimes some template tags with their CSS class names.
Is symbol support missing? If so, are you planning to implement it?

Hi there! Thank you too for enjoying it!
Symbol support is something I'm aware is not the best, unfortunately is not completely under my control. Vetur which is the Vue file parser and is running under the hood doesn't provide such information, at least as far as I've found. The symbols you are seeing right now come from the syntaxes definitions of Nova. That means that in order to display that kind of information I would have to overwrite the standard js definition of Nova... Another option would be to define them programmatically with the API but I would have to parse the file another time looking for all the elements...
So far it hasn't been a priority but I can consider working on it for the next release.

Right, this would be a really usefull improvement !

I checked the status of this issue and I'm not sure how the situation was when @jdillworth opened it but now the symbols are almost all available.
The problem with life-cycle callbacks si that the JS syntax doesn't define symbols for object shorthands. Unfortunately Vue best practices require them...
For @logancollins maybe a future release of Nova can fix this 😉
Standard function:

Object shorthand (missing symbol):

Not sure what version of Nova fixed this but in Nova v7.0 object shorthands work as expected 🚀


Whether to support drag and drop to change row height?

Does it support dragging and dropping to change the row height? I see that tables in many documents have implemented this function.

@wang1xiang What was the resolution or answer to this one?  I'm curious about it also.

+1


refactor: do not show the snyk-report-tab on build results that do not contain the snyk task

Currently the "Snyk Report" tab shows on all build results, even if the build pipeline does not actually use the Snyk task. If the task is never run, the tab renders nothing and just clutters the build results.
This change restricts the tab so that it only show for builds that actually ran the Snyk task.

^ this build pipeline does not contain the Snyk task, but it shows anyway.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@j-luong any chance this could be approved? thanks

@thisislawatts @schottsfired, any chance of considering this change to hide the Snyk report tab in pipelines that do not contain the Snyk task?

Thanks so much for your contribution @rhyskoedijk! I wasn't able to find official docs for this, but it looks good to me based on the following:
https://github.com/microsoft/vsts-extension-samples/blob/da897c8ff271a77811f7a5e6eeb791bd01e1fe08/build-results-enhancer/README.md?plain=1#L23-L24
WDYT @thisislawatts ?

@schottsfired yes unfortunately Microsoft haven't documented the list of properties; it's even missing from the vss-extension.json schema file. However, as you mentioned, there are many examples of this throughout the community.


Add Tuinity 1.17 upstream

Leaves in independent updating of either Paper/Tuinity.

Hmm while it builds fine locally before I cleared caches, it seems Paperweight isn't quite comfortable with multiple upstreams yet. I'm looking into the issue a bit in Paperweight, but it might be better for now to go back to squashing Tuinity to a commit.

I believe its because of the original issue I mentioned a long time ago about how Tuinity and Paper often conflict with each other because of the long delays between Tuinity's upstream merges.
I am testing something locally where I maintain an up-to-date fork of Tuinity and seeing if paperweight likes that any better. If it pans out I'll run with it.

DenWav says this is a supported feature, I presume the way it would work is the project which uses multiple upstreams solves conflicts as its own patch. I assume maintaining a separate updated fork of Tuinity would work just fine (since it's linear again) but it doesn't seem like a huge bug so it should be fixable once I can figure out where it is.


[feature] Support extended json

Hi, I would like to request a extension to json support:

inline comments{ // some comment
"key": "value" // some comment
}

block comments{ /* Block comment
Or multiline
*/
"key": "value"
}

enum value not as string

  {
  "key": enum_value,
  "key_second": "other_value"
  }

As for example these jsons are valid for flatbuffer complier
https://flatbuffers.dev/flatbuffers_guide_writing_schema.html#autotoc_md29
And pydantic would be great for batch processing of such JSON configurations.

As per #91 I think comment support is straightforward subject to performance impact.
For the enum values, that's a much more complicated / interesting idea which would have a strong interaction with pydantic-core. I'm open to someone exploring this idea, but it's a much bigger feature request and would have questions all the way up to the pydantic main API (as I assume users would want to be able to configure this).


Set digital output level relative to different references

Allow the user to configure the output level in these manners:

reference to full scale (FFS) (percentage of full scale)
reference to dB full scale (dBFS)
reference to 0.7746V (dBu)
reference to 1V (dBV)
reference to 1mW (dBm)

Focusing on %FS and dBFS for digital output types. There is also the notion of setting a reference relative to a reading such as THD+N. Sometimes this is called dBrG (AP) for setting a user defined reference.


Fixed bot timeout

I spent some time debugging and realized that we had a receiving in stay_alive which would never complete the loop. I removed that and now we are good! Also updated plugins_info.md, and re added PLUGINS.conf and temp.txt.

@Abdur-rahmaanJ this is a critical update so I am going to merge. It fixes a major issue #137


user_show - avoid lots of db access pre-CKAN 2.3

For pre-CKAN 2.3, ensure that user_show doesn't make lots of db accesses to get all the owning users' packages etc. when displaying an issue.
e.g. at /dataset/annakarenina/issues/1

Ready to merge


[WFLY-19283] Migrate Micrometer extension to new wildfly-subsystem approach

https://issues.redhat.com/browse/WFLY-19283
Migrate classes
Modify module deps

More information about the wildfly-bot[bot]

/retest

FYI, I wrote the :read-resource-description(operations,recursive) output for this subsystem to a file after building main and then this branch. Then I ran diff -uw against the files. Got this:
-- /Users/bstansberry/tmp/orig_rrd.txt	2024-05-01 18:19:40
+++ refactored_rrd.txt	2024-05-02 07:09:25
@@ -3,6 +3,11 @@
     "result" => {
         "description" => "Micrometer subsystem",
         "stability" => "default",
+        "capabilities" => [{
+            "name" => "org.wildfly.extension.micrometer.wildfly-collector",
+            "dynamic" => false,
+            "stability" => "default"
+        }],
         "attributes" => {
             "endpoint" => {
                 "type" => STRING,
@@ -88,6 +93,7 @@
                 },
                 "reply-properties" => {},
                 "read-only" => false,
+                "restart-required" => "all-services",
                 "runtime-only" => false
             },
             "read-children-types" => {
@@ -386,7 +392,7 @@
                 "reply-properties" => {},
                 "stability" => "default",
                 "read-only" => false,
-                "restart-required" => "all-services",
+                "restart-required" => "resource-services",
                 "runtime-only" => false
             },
             "map-remove" => {

The 'restart-required bits relate to the 'add and 'remove` ops, respectively.
I haven't dug into the details but my instinct is the first two diffs are fine; the refactor is correcting mistakes. The 'remove' setting change seems wrong.

The 'restart-required bits relate to the 'add and 'remove` ops, respectively.
I haven't dug into the details but my instinct is the first two diffs are fine; the refactor is correcting mistakes. The 'remove' setting change seems wrong.

Good catch. My guess is default values at play with the new API? At any rate, I've added this:
    .withAddOperationRestartFlag(OperationEntry.Flag.RESTART_ALL_SERVICES)
    .withRemoveOperationRestartFlag(OperationEntry.Flag.RESTART_ALL_SERVICES)

Does that look right @pferraro ?

The 'restart-required bits relate to the 'add and 'remove` ops, respectively.
I haven't dug into the details but my instinct is the first two diffs are fine; the refactor is correcting mistakes. The 'remove' setting change seems wrong.

Good catch. My guess is default values at play with the new API? At any rate, I've added this:
    .withAddOperationRestartFlag(OperationEntry.Flag.RESTART_ALL_SERVICES)
    .withRemoveOperationRestartFlag(OperationEntry.Flag.RESTART_ALL_SERVICES)

Does that look right @pferraro ?

The behavior of the generic add/remove resource operation handlers is driven by these flags - so it is important to set them appropriately (if your intended behavior is meant to differ from the default behavior).  The ResourceDescriptor.Builder will automatically override these based on specific described behavior - however, I just realized that the remove operation restart level when calling withDeploymentChainContributor(...) is not overriding the value set when calling withRuntimeHandler(...).  For now, set these explicitly.


Wrong DNS API Documentation

Hey,
the DNS API docs to query all zones [1] mention a name parameter which specifies: Full name of a zone. Will return an array with one or no results. Yet, when trying this with a non-existing zone I get an undocumented 404 error rather than an empty array.
Maybe the docs can be updated to say it returns 404?
Sadly, the DNS APIs are not supported by hcloud-python (btw., any particular reason why?) so feel free to refer me to the correct place to report this (or close it, if you feel like it).
Thanks!
[1] https://dns.hetzner.com/api-docs#operation/GetZones

Hey @dvdhrm, I have talked to the responsible team internally and they will take a look at this.

The documentation is still incorrect.


[as2_python_api] Specifying subdirectories in setup.py

Basic Info

Info
Please fill out this column

Issue(s) this addresses
#372

ROS2 version tested on
Humble

Aerial platform tested on
-

Description of contribution in a few bullet points

Added submodules to setup.py. It should fix issue with binaries

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8999e71) 1.97% compared to head (53d84ed) 1.90%.

:exclamation: Current head 53d84ed differs from pull request most recent head 3bd2b37. Consider uploading reports for the commit 3bd2b37 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #373      +/-   ##
========================================
- Coverage   1.97%   1.90%   -0.07%
========================================
  Files        103     100       -3
  Lines       5626    5608      -18
  Branches     181     193      +12
========================================
- Hits         111     107       -4
+ Misses      5405    5382      -23
- Partials     110     119       +9

Flag
Coverage Δ

unittests
1.90% <ø> (-0.07%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CI only checks version 0.10.1

The asdf action is only testing version 0.10.1 of the terraform-docs installed by this tool.
This means new values returned by list-all are not being checked. This results in other issues like #11
The change required for CI to check the latest versions as they release is:
    steps:
      - name: asdf_plugin_test
        uses: asdf-vm/actions/plugin-test@v1
        with:
          command: terraform-docs --version
-         version: 0.10.1

fixed by #16


Minor syntax error

I just wanted you to know that there is a syntax error in this header, even though it is compiling without error with the right compilation flags.
https://github.com/stack-of-tasks/pinocchio/blob/cd452efbeb3f04dc980def5fe0fc4a14edc197b7/src/parsers/urdf/types.hpp#L68

Thanks. Can you provide the compilation error please ?

@duburcqa Thanks for the pointer to the syntax error.

Arf, that was too obvious... maybe we should use something like https://www.codacy.com/.

@jcarpent would you agree with that ? I can try to set it up.

@jmirabel Yes please go ahead.  Thanks a lot

I made a request but I don't know who receives it (send to @stack-of-task ...).

I did.

I have accepted. Is it all right ?

They tell me

Seems like you are not an organization owner. You need to request an owner to join Codacy and add the organization.

So @florent-lamiraux , you still have an action to do.

Thank you. It worked.

Here is the result: https://app.codacy.com/gh/stack-of-tasks/pinocchio/dashboard
It will be run on every PR (and commit ?).

This tool is cool!
@jcarpent, @nim65s  could we allow it on loco-3d? I would like to use it in Crocoddyl.

Arf, that was too obvious... maybe we should use something like https://www.codacy.com/.

 It is not a linter by itself, is it ?
So which static analysis tool do you think would have prevented such a typo ?

I think it isn't a linter by itself.
I ran cppcheck and it does not report it. I was probably overoptimistic then.

I saw it was more than a linter, right? It is just a linter then we don't need it. I would follow the linter project developed by @nim65s, it is quite useful :)

At least, it didn't find this issue: https://app.codacy.com/gh/stack-of-tasks/pinocchio/file/43958393041/issues/source?bid=17605373&fileBranchId=17605373

As far as I can see, it is not a linter, it's a tool that run external linters on each commit / PR and show the results in the commit / PR, and in a dashboard.

@nim65s would you know a tool that would be able to catch this kind of typo ?
Basically, a compiler which wouldn't do anything else than parsing the code (though I don't know how faster this would be).

I don't know one which would have automatically tested this with and without PINOCCHIO_URDFDOM_USE_STD_SHARED_PTR

But I plan on adding clang-tidy & cppcheck everywhere :)

Well, if there exists a tool as fast as cppcheck but that would take the same option as a compiler (the preprocessor variables in this case), one can easily image running this tool with all the possible flags combinations.

I will try to do that :)


fix: Update README

:tada: This PR is included in version 0.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Make all RowReceiver's listenable

In order to migrate to a pull-based execution pipeline we'll temporarly
require a bridge from pull to push (to RowReceiver).
In a pull based architecture a consumer needs to explicitly close its
upstream to release its resources. A upstream/data-source cannot
auto-close itself as it doesn't know when a consumer has finished.
So we'll need to have some kind of close method.
To slowly migrate individual components we'll require a
RowReceiver-bridge. This bridge needs to call close after the
RowReceiver is done. This commit adds a finishFuture that can be used
by the bridge. Otherwise it wouldn't know when a RowReceiver is really
"done" due to their async nature.
Other rejected approaches:

Adding close to the RepeatHandle.:

This doesn't work for cases where a intermediate failure happens because
the RepeatHandle won't be available and so a RowReceiver further down
the chain cannot call close.

Merge finish and fail and add a closeCallback:

This would work, but is more complicated because all async RowReceivers
would have to manage additional futures in order to be able to handover
the closeCallback to its downstream.

Change finish/fail to return a Future:

This would also require intermediate futures in async RowReceivers as
the finish/fail calls cannot be called eagerly to pass-through the
future.

Codecov Report

Merging #4903 into master will decrease coverage by -0.11%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master    #4903      +/-   ##
============================================
- Coverage     82.15%   82.04%   -0.11%
+ Complexity    10684    10665      -19
============================================
  Files          1294     1294
  Lines         44523    44525       +2
  Branches       5629     5630       +1
============================================
- Hits          36576    36530      -46
- Misses         5312     5355      +43
- Partials       2635     2640       +5

Impacted Files
Coverage Δ
Complexity Δ

...src/main/java/io/crate/jobs/NestedLoopContext.java
50% <ø> (ø)
8 <ø> (ø)
:x:

...va/io/crate/operation/projectors/RowReceivers.java
87.5% <ø> (-7.74%)
3 <ø> (-2)

...tor/transport/SingleRowSingleValueRowReceiver.java
72% <ø> (ø)
8 <ø> (ø)
:x:

...ava/io/crate/operation/projectors/RowReceiver.java
100% <ø> (ø)
0 <ø> (ø)
:x:

...operation/projectors/MultiUpstreamRowReceiver.java
69.23% <ø> (-4.11%)
19 <ø> (-1)

...o/crate/operation/RowCountResultRowDownstream.java
70.58% <ø> (-4.42%)
4 <ø> (ø)

...eration/collect/collectors/CompositeCollector.java
74.07% <ø> (-3.29%)
5 <ø> (ø)

...a/io/crate/operation/join/NestedLoopOperation.java
82.62% <100%> (-1.94%)
11 <ø> (ø)

.../transport/distributed/DistributingDownstream.java
91.33% <100%> (-1.35%)
26 <1> (ø)

...tor/transport/distributed/SingleBucketBuilder.java
76.19% <100%> (ø)
7 <1> (ø)
:x:

... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46e22b...7bda550. Read the comment docs.

@mfussenegger did you consider let RowReceiver implement CompletionListenable? does it conflict in existing components?

@dobe No I had not. Pushed a fixup.


Swift4 support?

Unable to satisfy the following requirements:
RxSwift (~> 3.4)required byRxFeedback (0.1.0)

Yes, I'll push 4.0 version soon, just trying to release RxSwift 4.0.0 first.


Write unit / integration test for Paused Condition for ByoHost

We do not have any test for this function - https://github.com/vmware-tanzu/cluster-api-provider-bringyourownhost/blob/1b485e7180727ea36bf24750d6a230f8a796e4f0/controllers/infrastructure/byomachine_controller.go#L383-L399
Write some unit or integration test to improve code coverage

I can take a look into this one

/assign @NilanjanDaw


Please update the Add Account information

Please update the Add Account Information, as the screenshots must be from the Azure portal.
According to the latest process, it is not possible to add an account from the EA portal. Instead, the account should be added from the Azure portal. It is crucial to rectify this error in the document promptly and address it. The incorrect information in the document has been causing confusion among many customers.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 97154f08-4e08-e3b9-bd7f-b399aeb763ef
Version Independent ID: 56c611c8-ce10-caa0-f48c-41237c5a8151
Content: Azure EA portal administration - Microsoft Cost Management
Content Source: articles/cost-management-billing/manage/ea-portal-administration.md
Service: cost-management-billing
Sub-service: enterprise
GitHub Login: @bandersmsft
Microsoft Alias: banders

@DeepikaMicrosoft Per the EA Billing engineering team, the EA Portal is still available for indirect customers and their partners and customers on US Gov cloud. So, the article is still applicable to them. So, I updated the Important note block at the beginning of the article to say:

[!IMPORTANT]
The Azure EA portal is getting deprecated. Direct and indirect EA Azure customers should now use Cost Management + Billing features in the Azure portal to manage their enrollment and billing instead of using the EA portal. For more information about enrollment management in the Azure portal, see  Get started with EA billing in the Azure portal.

As deprecation proceeds, I'll update the article. When the EA portal is fully decommissioned for all users, I'll retire it.
#please-close
https://github.com/MicrosoftDocs/azure-docs-pr/pull/243996


Add feature to prost-build to allow runtime specification of protoc

Opening this as a way of opening the discussion about an issue that I
was running into.  If you would prefer a different approach, I'm happy
to discuss that.
Within multi-language environments, such as bazel, cargo isn't always
able to drive the build process.  However, prost and prost-build
provides an amazing foundation of which to build off.  The general idea
of this commit was to open up prost-build to having tools built off of
it, while still preserving previous behavior.
Currently, if PROTOC or PROTO_INCLUDE are not set at build-time, then
the build fails.  This commit introduces feature, runtime-protoc. This
hides env! invocations when enabled, allowing compilation, under the
assumption that the protoc location will be provided at runtime.  This
wouldn't be my first preference, but I was prioritizing the build-break
if the environment flags were not specified.  I would generally have
preferred grabbing those with option_env! macros and then trying to
gracefully handle the error at runtime protoc has not been provided at
build time or runtime similar, since this is already covered by tests.
That would allow removal of the feature flag.  It would also make the
code a little cleaner, since there's not a great way to do conditionals
with cfg (see rust-lang/rust#71679).

rebased on top of #314

As far as the Bazel integration goes, it'd be better to make generate() public and consume FileDescriptorSets from proto_library targets instead of calling protoc directly. I ran into this recently while setting up Tonic.

@kornholi I didn't realize proto_library provided that.  Thanks for point that out!

@kornholi is any of the work you did with bazel/tonic open source?

It's not, but I think we're very close with your work in #313 and some PRs open in rules_rust/cargo-raze. Let me see if I can get it working in a clean Bazel environment.

Now that #283 and #324 have landed is this still needed?  I know this PR goes further in that it provides a protoc plugin, but not sure if that's still advantageous for bazel/buck?

Sorry I got my PRs mixed up, that's not what this PR does.  So now it should be possible to specify the protoc through the runtime PROTOC env var, is that good enough?

@danburkert , no worries!  Thanks for taking a look at these.
I had continued the discussion here over on #307, following your reply.

The PROTOC environment variable override in https://github.com/danburkert/prost/pull/324 unblocked my use case.  While I still like the more explicit side of this design, I don't think it would make sense to have both features.


Use function types and lambda expressions in Kotlin: Android Basics with Compose

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-function-types-and-lambda?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-2-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-function-types-and-lambda#3
In which task and step of the codelab can this issue be found?
Nullable function types, step 3
Describe the problem
the lambda is replaced with null, but the code path executed never touches the lambda provided because the change is made when isTrick has a true value. If instead coins is replaced by null the check for if (extraTreat != null) { will be executed because isTrick is false.
Steps to reproduce?

with this implementation of trickOrTreat

fun trickOrTreat(isTrick: Boolean, extraTreat: ((Int) -> String)?): () -> Unit {
    if (isTrick) {
        return trick
    } else {
        if (extraTreat != null) {
            println(extraTreat(5))
        }
        return treat
    }
}

the main function should containing something like:

    val treatFunction = trickOrTreat(false, null)
    val trickFunction = trickOrTreat(true, cupcake)

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

This change will apparently ripple in to the next task - unfortunate

Hi @dcharlan426
Thanks for reaching out to us and sharing your feedback with us - it will be passed to the appropriate team for further consideration.
I hope you are enjoying the course.
Regards.


Cleaner illegal_csr_write assignment in CSR

For write logic in ibex_cs_registers.sv:

move if (csr_we_int) begin conditional outside unique case block to make code cleaner
move illegal_csr_write assign to write logic block with assignments in appropriate places. Before it was just a general out of scope assign without too much meaning.

Thanks for an insight @vogelpi. I didn't know it was this strictly defined in spec. Can you point me to a specific place in spec which consider checking these address bits?

Yes, it is in Section 2.1 "CSR Address Mapping Conventions" in the privileged spec.

Thanks for the reference. I just pushed version with only the csr_we_int conditional.

Besides, it seems that Pipelines are somewhat broken.

CI will be fixed in #364, it's not related to your change.


Make ProfilingContext nullable

The JobExecutionContext had already checks to see if the profiler is
enabled, resulting in 2 levels of "do something or not" checking. Once
on the use-site of the profiler and once inside of the profiler via
different Timer instances.
This removes the inner level to have the checks consistently in the use
sites.

retest this please

retest this please


Create zh_cn.lang

@3TUSK Are you able to check over this if you have time?

It's just a very simple translation, please rest assured that the use.😂


code with comments inside multline comment breaks syntax parsing

code like below will not parse correctly, due to the comment line inside the code block inside the multiline comment:

/**
 *
 * ```kotlin
 * object Foo {
 *     /** this comment breaks syntax parsing */
 *     const val VAR = "VAL"
 * }
 * ```
 */

 object Foo {
     const val VAR = "VAL"
 }

Bump, is there any plan to address this? @fwcd

This has been fixed.
(source_file [1, 0] - [14, 0]
  (multiline_comment [1, 0] - [9, 3])
  (object_declaration [11, 1] - [13, 2]
    (type_identifier [11, 8] - [11, 11])
    (class_body [11, 12] - [13, 2]
      (property_declaration [12, 5] - [12, 26]
        (modifiers [12, 5] - [12, 10]
          (property_modifier [12, 5] - [12, 10]))
        (variable_declaration [12, 15] - [12, 18]
          (simple_identifier [12, 15] - [12, 18]))
        (string_literal [12, 21] - [12, 26])))))


Return next steps in operation detail REST service

Next step server should return steps in /operation/detail

Implemented in pull request #37


waypoint: 0.7.2 -> 0.8.1

Description of changes
https://github.com/hashicorp/waypoint/releases/tag/v0.8.1
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

waypoint 0.8.1 was just released, and so I've updated this PR to match that


feat(nuxt3-module): remove shopware duplicate in env-var-naming

Description

Removed currently unused code in the nuxt-module index file
Changed used ShopwareNuxtOptions to use naming without Shopware (e.g. shopwareEndpoint -> endpoint) but still be backwards compatible
Adjusted used .env variables in the plugin.ts file
Changed variable identifiers to match updated variables in nuxt.config of the demo store, as well as the .env variables

closes #665
Type of change

New feature (non-breaking change which adds functionality)

ToDo's

[x] Changeset file provided read more
[x] Documentation added/updated
[ ] Unit-Tests added/updated
[ ] E2E-Tests added/updated
[x] Related Issue updated

Screenshots (if applicable)

Additional context

Thanks a lot for DX perspective and this simplifying contribution 💙 .
Could you also have a look at https://github.com/shopware/frontends/actions/runs/8078810205/job/22071923215?pr=664#step:9:131 and adjust it because types don't match correctly?


Delete multi-selected nodes won't clean LG resources

Version
57baf4c8
Describe the bug
Using the 'Delete' button in single click can delete LG resources, however, using multi-selection to select nodes and deleting them won't clean LG resources.
Related to #922 (parent)
To Reproduce
Steps to reproduce the behavior:

create two SendActivity actions, input something
drag select them
click Delete in toolbar
common.lg not cleaned

Expected behavior
Should be deleted
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

pending on #1512

in pr #1580

addressed in https://github.com/microsoft/BotFramework-Composer/pull/1580


Prepare a 8.2-compatible release

What it says on the tin.

TODO: replace all occurrences of next with the actual version number.

Done in f5ab42d5db78ecadee1ba19abc0224e0505778ba.


Billing - Stripe - 1st version

A first version for the immediate billing use-case:

immediateBillingAllowed must be set in billing settings
generates an invoice per transaction
finalize the invoice immediately
tries to charge the invoice using the default payment method of the customer
can apply taxes (VAT) when taxID is properly set (no UI for doing it yet)
send mails to inform the user about the status of the new invoice
Invoice line item: Quantity is always set to 1, line amount corresponds to the roundedPrice of the transaction
The link between Users and Stripe Customer does not rely on the email anymore.
The link between Users and Stripe Customer cannot be repaired automatically if broken (when deleting a customer for instance on stripe side)
Invoice Synchronization is implicit. Triggering a manual sync should be useless.
ACHTUNG! - The billing settings are very sensitive to changes. Switching from a STRIPE account to another one may break the data consistency.
The end user can add his/her card via the UI (from Caroline) - The latest created payment method becomes the default payment method of the customer (in STRIPE DB). This payment is the only one used when trying to charge the invoice.
Invoice PDF document is downloaded and persisted on our side as soon as the invoice is finalized (and cannot be changed anymore)
WebHooks (listening for stripe events) are not yet used - just logging some information
Some end-points are in comment because they are not yet used
Billing Testing:
2 categories of tests:

Some tests are testing Stripe Capabilities directly - they call the Stripe Implementation

Other tests are testing the complete flow via the regular interfaces (REST endpoints) and are very sensitive to the initial test data - In other words, the STRIPE account should not contain inconsistent data when running the tests

@ClaudeROSSI I can merge it if you want (still in Draft)
Let me know.

@ClaudeROSSI I can merge it if you want (still in Draft)
Let me know.

I think we can merge ... but I'm not sure about the impact on the tests ... I have declared billing.taxID has a boolean property in the test/config.js file. I have not been able to run the tests on my side!

Test are only ok when executed whithin VSCode and on my linux machine ?!? I'm lost!
Green on the left, Almost green on the right side!

LOL !!!
Got them ok on your branch, I'll merge :)


Problem with the annotation export

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Steps to Reproduce

Export the annotations
Choose CVAT for Video 1.1
Receive the message with error: Could not export dataset for the task xxxxxx — ValueError: operands could not be broadcast together with shapes (0,) (6,)

Expected Behavior
I expected to export the annotations. For every other similar task it works well. Task has rectangle tracks and skeleton tracks. It is impossible to export the annotation in any of the formats.
Possible Solution
No response
Context
No response
Environment
I am using your platform app.cvat.ai
Operating system: MacOS 12.6.1

Hello,
Please, fill the environment. Otherwise the issue will be closed.

Hello, I have updated this section as you asked, but I don't have a lot of information to provide since I use CVAT on your servers

If that is our platform, than please provide your username.

ivan1

Did you upload annotations first to the task and then adjusted it?
Or it was full annotating from scratch?

You have several corrupted keyframes in annotations.
Like this. As you can see, "points" array is empty for some of tracked shapes. That does not seem to be correct.

Thank you for the explanation. Everything was done from scratch, there are only 2 tasks with this issue: 520915 and 526001. Is there any way to detect tracked shapes with this issue from the tool interface? or can it only be done on your side? Is there anything I can do to prevent these issues to appear? @bsekachev

Export as datumaro
Text search "points": [], remove.
Import back
Export as CVAT for Video.

Thank you so much! I have found only the backup guide for docker. Is there way to restore annotations using the platform? Can it be performed via the "upload annotations" action? @bsekachev

https://opencv.github.io/cvat/docs/manual/advanced/backup/

thank you!

Hello @bsekachev, I tried to upload the .zip with backup, however I receive the message that archive doesn't contain the task.json file. That is strange since the file is in archive. Could you please explain how resolve this issues?

@bsekachev

Export any backup from CVAT and compare archive formats. I suspect there is extra top level directory

Thank you, it worked


awk for startupProbe and readinessProbe only look for controller_id in down nodes, not current broker id

It appears that when doing the startupProbe and readinessProbe for pod health, we aren't actually looking for the current pod's broker id. We're looking for the controller id in the down nodes list, which could trigger a cascading failure of actually healthy nodes. Additionally, we also may be missing cases where a broker is in the list, but we don't fail out the probe. It doesn't appear that we have a good way to find the current broker id in the list based on the health_overview.
https://github.com/redpanda-data/helm-charts/blob/6e31833a0df989a76229a4f12522bbff3d107aff/charts/redpanda/templates/statefulset.yaml#L216-L247
See thread for more detail:
https://redpandadata.slack.com/archives/C01H6JRQX1S/p1680276099505199
From the thread:
Assume we have 3 brokers in a cluster. controller is on broker 0. If broker id 0 shows up in the down nodes list, all pods in the cluster will likely die off.
Additionally, if any other broker shows up in the down nodes list, the awk ends up with a false negative and doesn't seem to exit with a non-zero status to trigger a failure in the probes for that broker.
I instrumented the awk a bit to make this more obvious in testing it. Below we can see that broker0 being down in the first test would trigger the probe failure.  We may want to be passing --fail to the curl call so it exits the way we need it to in order to detect a Redpanda API probe correctly.
We'll want to make sure that the health_overview call returns appropriately in the event of an unhealthy status. My quick check shows it returns HTTP 200 if is_healthy is false (which I think is the right thing because this is a cluster-level response, not a broker-level response)

/v1/brokers/<brokerid> might be a suitable alternative. it's at least got details around commission/failure state


does betamax work across machines?

I am trying to setup betamax for our tests that run on a different machine than the service under test. I tried setting up a mock server that starts the betamax recorder on startup. Now when i redirect requests through this server, i dont see betamax playing back from the tapes nor it acknowledges that any requests are coming through.
I thought starting betamax recorder on some port (unblocked of course!) and routing my requests through that port would work. It works fine on the same box but I can't seem to get it working when the mock server is deployed on another box.
Any ideas?

Betamax is not designed to work in this way, though I suppose it could be adjusted to do so. You have to ensure that your proxy settings are correctly configured to hit Betamax, and even then, the behavior is undefined. I've thought about adding this sort of route in a future version of Betamax, but I may completely diverge from Java to do that.
What is your reason for wanting to do this?

what would need to be configured in betamax to make it work? In the configuration, there is a property called proxyHost. What is the benefit of that if it is always going to be localhost?
I assume betamax listens on a port and matches whatever traffic responses it can. Why would there be any difference between same machine requests and cross machine requests?
I was thinking on writing a TCP port listener that forwards traffic to the port betamax is listening on. Will that work?
Our test structure is complex as multiple teams' tests call into our service and we prefer that they don't mock our service

Will you be using HTTPS?

yes we will be using https

Our https scenario works just fine but again on the same machine

So in essence you want to turn Betamax into a forward proxy? You want to use it as an actual MITM between clients and your service? Hypothetically this is possible, though I do not have a lot of advice for getting it done. I am not sure if there is any poorly implemented bindings to localhost that would otherwise prevent such a use.
Being that Betamax was not designed to function in this capacity, I can only offer some high-level guidance for you going forward. I would figure out how to get Betamax to launch as a stand-alone application, and use simple curl scripts to try and stress it. It may take some time to get to that point.
If you do get Betamax working this way, please report back, and we can try to incorporate it into the project.

I was thinking about keeping the forward proxy separate from Betamax at this point but if it works then I can contribute it to betamax. The thing I don't understand is why cross machine case is different from same machine? What is betamax using that imposes this restriction?
Running betamax as a standalone project was fairly straightforward to do. We just deployed a REST service that had onStart and onShutdown hooks where we start and stop the recorder.

Betamax 1.x was originally a hack similar to that of vcr. In 2.x, we started moving it to a standalone attachment. It's not that there is a restriction, it just wasn't designed for your use.

So here is how i got it to work:
I wrote a simple forwarding proxy program that forwards the traffic from one port to the one betmax is running on. The program consists of spinning up 2 threads: the first one reads data from the client and writes it to the betamax connection. the second threads does just the opposite: reads from betamax's stream and writes it back to the client. works for both http and https.
I haven't looked at what betamax uses that blocks it from working across machines but i don't see a reason why it can't be adjusted.
Encapsulating all this logic in betamax will make it even more useful. Regardless, it is a great tool that will make our lives easier :)

@babarismail is there potential to put this on a branch somewhere I can see it?

I'd like to leave this open until I create an action item from it.

This is a good example: http://examples.oreilly.com/jenut/ProxyServer.java
I wrote something similar but with some of our infra related housekeeping. I then start betamax recorder before serverSocket.accept(). I can try to create a personal github repo for you to see if you want to see exactly what i did. Otherwise this is a very good starting point

Moving this to Trello: https://trello.com/c/MEwtr6m2.


wrong message about "use a ILP64 abi for larger tables"

Steps to reproduce the issue
In https://github.com/YosysHQ/yosys/blob/60a787fa50062169c1aae4ecb199d13c0b6f25b6/kernel/hashlib.h#L191
	if (sizeof(int) == 4)
		throw std::length_error("hash table exceeded maximum size. use a ILP64 abi for larger tables.");

is not helpful.  ILP64 is quite dead and LP64 uses 4 byte ints.  If you want to allow larger values then you should use 'long long' not int as the type [long is 32bit on windows].
A failure of this check is seen in https://github.com/The-OpenROAD-Project/OpenROAD/issues/2106
Expected behavior
64 bit linux compiles (LP64) should allow for the larger table size.
Actual behavior
64 bit linux compiles (LP64) don't allow for the larger table size and gives an unhelpful message.

Why not use a longer type rather than just giving up?

Using a longer type will involve an in-depth review of every single use of int in the entire codebase. Are you volunteering?

No but you closed this issue which suggests that yosys will not support larger designs.  It seems an important limitation of the tool to address.

The issue as filed was that the error message was "wrong" (not true) and the suggestion it gave "not helpful" (true). It now gives a more helpful suggestion, which is what we can currently do to address this limitation with the resources we have.
Feel free to open a feature request for larger tables, if you think having more open issues is useful.


[help] shorten lines

Reported by @indragiek: On smaller windows a lot of text wraps and makes it difficult to parse through.

Thanks @indragiek for reporting this issue. Please get the latest from master as it was addressed by PR https://github.com/odeke-em/drive/pull/263


"Uncaught TypeError" in peerconnection calls

Browsers and versions affected
Chrome OS : 62.0.3202.9 / 9901.7.0 dev
Any chrome device
Steps to reproduce

Browse to https://appr.tc/?debug=loopback and join the loopback call
Open the javascript console (alt+cmd+j or ctr+shift+j) and watch for any errors

Expected results
Apprtc loopback call should connect successfully and there should not be any javascript errors
Actual results
Apprtc loopback call connects successfully but javascript logs shows "Uncaught TypeError: Cannot read property '0' of undefined at PeerConnectionClient.onRemoteStreamAdded_ (apprtc.debug.js:4461)"
Loopback_js_logs_M62dev.txt

Note:
This issue is also observed in apprtc peer2peer calls and other webrtc sample pages for peerconnection calls : https://webrtc.github.io/samples/src/content/peerconnection/pc1/, https://webrtc.github.io/samples/src/content/peerconnection/webaudio-input/

@KaptenJansson

I believe this is due to an adapter change, will take a look and see if the web clients need an update or adapter.
FYI @fippo

AppRTC is receiving events from both adapter and Chrome, that's why this is happening.

that does sound familiar... https://bugs.chromium.org/p/chromium/issues/detail?id=761612 ?

bingo. Only happens without experimental web platform features.

I will try to fix the Chromium bug.

Doing pc.addEventListener('track', callback); results in the callback being invoked when ontrack should fire, even though ontrack is behind experimental web platform flags and the flag is off (that's a bug!). Not only does it fire when it shouldn't, because the RTCTrackEvent is behind a flag the event that does fire have undefined track and streams members.

I have a confirmed fix ready, let's wait for it to land and for it to get into canary.

I've confirmed this is fixed on tip of tree. Should be in canary shortly if it isn't already.


Settings - A new user can navigate away from the onboarding modal using an URL

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
Found when executing PR : https://github.com/Expensify/App/pull/44536
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Open the app
Log in with a new Gmail user
Open https://staging.new.expensify.com/settings/profile
URL "in New Expensify"
Tap on the "<" button to navigate back

Expected Result:
The onboarding modal should be showing when opening a different URL until the onboarding is completed.
Actual Result:
A new user can navigate away from the onboarding modal using an URL. The onboarding can't be skipped as its shown again when navigating back from the opened page.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/1dde4238-d698-4c36-a02b-568d6da006c8

View all open jobs on GitHub

We think this issue might be related to the #collect project.

Able to repro this using a Pixel 6 pro on Native.

Proposal
Please re-state the problem that we are trying to solve in this issue.
A new user can navigate away from the onboarding modal using an URL. The onboarding can't be skipped as its shown again when navigating back from the opened page.
What is the root cause of that problem?
We have a useEffect to navigate to the onboarding flow if it's not complete but this only triggers when isLoadingApp is changed and isLoadingApp is only changed after OpenApp API is called. So when we open the deep link and we already login, we navigate to the deep link page.
https://github.com/Expensify/App/blob/fb9ce79f891ef932c60c36617162f5e988e3313d/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.tsx#L62
What changes do you think we should make in order to solve the problem?
For the web, when we access via deep link the page is reloaded and the useEffect is triggered and the bug doesn't happen.
https://github.com/Expensify/App/blob/fb9ce79f891ef932c60c36617162f5e988e3313d/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.tsx#L62
For natives, we have the logic to listen to the deep link here. We can navigate to the onboarding flow in the openReportFromDeepLink function if it's not completed here
if (isAuthenticated) {
    Welcome.isOnboardingFlowCompleted({onNotCompleted: () => Navigation.navigate(ROUTES.ONBOARDING_ROOT)});
    return;
}

https://github.com/Expensify/App/blob/fb9ce79f891ef932c60c36617162f5e988e3313d/src/libs/actions/Report.ts#L2598-L2599
What alternative solutions did you explore? (Optional)
NA
Result
https://github.com/user-attachments/assets/a92b54ea-016a-4ceb-a8d8-5f335d9dca3e

Payment Summary

$250 @Ollyws via New Expensify manual request
$250 @nkdengineer via Upwork (paid)

Working on reg test gh now.

$250 approved for @Ollyws

Thanks all, this is paid and reg test is done, closing out!


KnetSpace login from localhost/aratiny doesn't work in Chrome, works in Firefox

This is not crucial for the end users, but it's quite important for developing and debugging.
When I login while running the aratiny application, on localhost:8080, I can type my credentials and apparently, the code is successfully getting a positive answer from KnetSpace to the authentication request. However, the UI remains unchanged, there isn't any "welcome marco" message on the top-right side, the "Sign In" items don't change into the user name and the 'my knetspace' button.
On the contrary, in Firefox everything works fine, including the fact that the limit for the genes list box is removed.
Additionally, this is wat the Chrome Javascript console shows from the click on 'Sign In' to the disappearance of the login pop-up:
21:57:11.405 loginUtils.js:209 User isn't logged in, initalizing login Modal
21:57:11.423 google-analytics.js:117 Google Analytics tracker started with ***
21:57:11.440 google-analytics.js:50 Google Analytics, event 'ui:aratiny:uiOpened' sent

# This occurs after clicking on "Sign In"
21:57:20.751 loginUtils.js:213 logged in
21:57:20.865 localhost/:1 [DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) <input type="password" name="password" id="password">
22:09:08.011 loginUtils.js:213 logged in
22:09:08.123 localhost/:1 [DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) <input type="password" name="password" id="password">

Surprisingly, Firefox has a few more warnings during the same interaction:
logged in loginUtils.js:213:29
Some cookies are misusing the recommended “SameSite“ attribute 5
Cookie “csrftoken” has been rejected because it is in a cross-site context and its “SameSite” is “Lax” or “Strict”. me
Cookie “csrftoken” has been rejected because it is in a cross-site context and its “SameSite” is “Lax” or “Strict”. 3 me
Cookie “knetspace_token” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite 2 jwt
Cookie “csrftoken” has been rejected because it is in a cross-site context and its “SameSite” is “Lax” or “Strict”. 2 me
Cookie “csrftoken” has been rejected because it is in a cross-site context and its “SameSite” is “Lax” or “Strict”. 4 me

If I have to guess, I'd say Chrome is more restrictive than FF on the problem that the FF warning is describing (ie, cross-site permissions with KnetSpace cookies).
A quick workaround to this is testing KnetSpace-related features with FF. Chrome works with a real KneMiner instance that has a real/production URL, so in practice, we developers are the only ones affected by this problem.

Thanks a lot for this Marco. Really strange! I suppose Firefox is still of the few not based on Chromium. I'd be curious to know whether it works in Safari.
That said, my feeling on this is that it'll be resolved as part of Nova, and we're rolling out our final pre-redesign update soon, with testing mostly complete already for where this would have been especially helpful (sample queries, etc).
If this does get investigated, it could be mostly for curiosity's sake and can be done last as part of 5.7... @lawal-olaotan
Thanks for checking this Marco. I don't even have FF...

@marco-brandizi did we agree to migrate this? Please remind me. It's probably an issue linked only to the current knetspace implementation, so it can rest here in the backlog. Later today we can have a call with the extended team about the importance of testing early on multiple browsers.


How to uninstall it?

This app alway show dialog when startup, How to uninstall it?

Hi @NgKhanh,
You should just be able to delete Bluesnooze.app from your Applications folder, or wherever you placed the application.
If that doesn't work you can try deselecting "Launch at login" from the menu bar as well:

Thanks,
Oli

I run app to disconnect bluetooth speaker while macbook sleeping, but it also disconect mouse and keyboard bluetooth

@NgKhanh yes, it completely turns off Bluetooth, rather than disconnecting from specific devices - this is by design.


Test Coverage: Migrate some open source Apps to Accio

Currently, only a few project structures and sets of dependencies are tested with Accio. While most should be usable as is, it would make sense to migrate several open source iOS apps from Carthage to Accio to find edge cases (or confirm there are none). Here's a repo with many such projects.
Bigger and wider known app projects could be started with, like Firefox.

Closing this, as Accio is now deprecated.


When can we use 2024-4 with this Gem?

Overview
Seems the release of a version to use the latest API 2024-04 is delayed? Any ETA on that?

Hey, thanks for bringing this up! We completed all of the steps needed in #1305 - it'll be available in the next release, coming soon.


Bug 2068401: Avoid overwriting needsStatusUpdate

Ensure previous conditions requiring status
updates are preserved, when a future condition
does not require a status update.
This helps with retaining last known good status
for DRPC "Available" condition, and also prevents
future conditions from overwriting the same.
Was inadvertently introduced in commit 90d1d91e48
Signed-off-by: Shyamsundar Ranganathan<EMAIL_ADDRESS>

/approve

/bugzilla refresh


how to set default start time 8 AM for each day of calender

Is it a duplicate of #34?

No..I want to set 8AM the default start time of calendar for each day. If user want to see above and below time, he can scroll up and down.

Would scrollTo method of the dayView solve your issue?
https://github.com/richardtop/CalendarKit/blob/master/Sources/DayView.swift#L140
Just try using it like this:
dayView.scrollTo(hour24: 8, animated: true/false)

Let me know if this is an appropriate solution to your problem

yes its work..but when we click on another date ..its automatically shift to 12:00 AM.

but when we click on another date  - this is a limitation of the CalendarKit, as it doesn't preserve the scroll position when you click on the date in the header.  Already reported as #211
One workaround would be to invoke the dayView.scrollTo(hour24: 8, animated: true/false) method just after dayView.didMoveToDate delegate callback: https://github.com/richardtop/CalendarKit/blob/master/Sources/DayViewController.swift#L106 - let me know if this solution works for you.

yes, when i try to write scroll code in this method its working.. but their some jerk ...means its first show 12:00 for some millisecond then directly move to 8:00 AM

Could you please attach a video? Thanks

And the exact code you're using for this? Maybe try using 'willMoveTo' instead of 'didMoveTo'? Let me know if there is any difference.
If this doesn't help, I'll convert this ticket to an enhancement.

No , when i move that line to willMoveTo..then nothing are happing.

And do you use animated:false?

yes on didMoveTo and same on willMoveTo.

Ok, I've changed this to enhancement. Would you be willing to make relevant changes to the CalendarKit to implement this feature?
I can briefly explain how to achieve this functionality.

yes if you will help me..i will make changes.

oky..let me check this one..Thanks

Please keep me updated on whether you resolve this issue either by my suggestion or by any other means...


[BUG] Not using the disk bus in the template

Describe the bug

To Reproduce
Steps to reproduce the behavior:

Create a template with sata bus
Use the template

Expected behavior

After Use template, the disk bus should be as same as template
Log

Environment:

Harvester ISO version:
Installation Mode: ISO/app-mode
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Additional context
Add any other context about the problem here.

validated on master-head


CW20 case study

Overall, the CW20 case study is a great way of seeing the EOG in practice, and it's an excellent record of what happened in terms of planning and organisation of the event.
However, it's very long. I don't think it's necessary to write another one though, as we can probably use a re-jigged version of the CW20 blogpost: https://software.ac.uk/blog/2020-05-18-cw20-how-move-event-online-three-weeks.
So, my suggestion would be that we keep the CW20 as is in the guide as a thorough example of each of the EOG stages, but add a re-jigged version of the blog post as the case study (which would be added instead of the current introduction).
Happy to chat about this further if anyone has any ideas or suggestions.

We (@rainsworth and I) were thinking a statement on the intro page directing to the blog post for the summary version and explaining that what is below is a detailed exposition of how activities match to the different stages of the EOG would be sufficient rather than a re-jig/summary of the blog post - what do you think @selina-aragon?

I agree with not creating another version of the blog post, but I think we need to rephrase/rename our titles as the longer version isn't a case study, whereas the blog post version reads a lot more like one. Maybe let's have a chat about this one?

ok - I will email about setting up a meeting.

From comms/community meeting 2020-12-03:
SSI use case study to mean something quite concise that highlights benefits and things learnt - so we will make EOG consistent with that use of the terminology and change Case Study to EOG in Practice in the EOG.

Terminology and directory structure updated to reflect 'In Practice' write-ups vs 'Case Studies'.


Cannot configure build tasks by clicking on the suggested bar (after trying to execute a task)

VSCode Version:
1.27.1
5944e81f3c46a3938a82c701f96d7a59b074cfdc
x64
French Locale
OS Version: Windows 7 professionnal

Steps to Reproduce:

Do de steps in this official tutorial until (with any code) 12:40 https://www.youtube.com/watch?v=X7CXjKGi_ro
In this version there is no "task" menu, so instead go to terminal menu, then click on "execute task"
This is not as beautiful as in the video but it will tell you like in the video that "no build task found, configure tasks..."
Click on configure tasks

Acutual results: nothing happens, not like in the video in which it creates a configuration file

Not applicable

no duplicate detected

This works for me using an empty workspace

I can't comment on whether this makes a difference with the CPP tools installed as shown in the video. If you see problems with the CPP tools please report the issue there.

@dbaeumer it works because you didn't respect the protocol to reproduce the bug. The steps you do in your video are working for me as well:  You went to "configurer les tâches de génération par défaut" instead of "exécuter la tâche"
I've just reproduce the bug on another PC with Windows 8.1
Again,
Here are a simplified steps to reproduce the bug. Please follow these:
0.

You have all infos you need now. Good luck to fix it.

@chrmarti this fails do to an exception in the list widget
  ERR Invalid index 0: Error: Invalid index 0
    at WorkbenchList.List.open (file:///C:/Users/dirkb/Projects/mseng/VSCode/vscode/out/vs/base/browser/ui/list/listWidget.js:1048:27)
    at MouseController.onMouseDown (file:///C:/Users/dirkb/Projects/mseng/VSCode/vscode/out/vs/base/browser/ui/list/listWidget.js:426:31)
    at file:///C:/Users/dirkb/Projects/mseng/VSCode/vscode/out/vs/base/common/event.js:456:70
    at file:///C:/Users/dirkb/Projects/mseng/VSCode/vscode/out/vs/base/common/event.js:442:57
    at Emitter.fire (file:///C:/Users/dirkb/Projects/mseng/VSCode/vscode/out/vs/base/common/event.js:151:38)
    at HTMLDivElement.fn (file:///C:/Users/dirkb/Projects/mseng/VSCode/vscode/out/vs/base/browser/event.js:9:48)

Interestingly when I debug through it it does not happen. So seems timing related.

The problem is that the selection change event lets QuickInput clear the list and then the list's code for the open event fails because the clicked element is no longer there: https://github.com/Microsoft/vscode/blob/1c921394696edbecac21f2993155dfcc4a67b167/src/vs/base/browser/ui/list/listWidget.ts#L507
I can fix this by disabling the open event, which is not used by QuickInput.
@joaomoreno Isn't this a bug in the list widget?

@chrmarti Maybe just disable open for now.