Typings install issue

Installing node packages freezes after npm run typings --install > typings "install"
I've node version 5.4.1 with npm version 3.3.12. If I run the application it stops with an error
error in [default] app.component.ts, cannot find name require.
I'm using the zip downloaded from the repo.

are you on windows?
npm install typings -g
and
typings install

I already have typings in the global but I did it again still not working.
Typings version is 1.1.0 and yes I'm on windows 10.

I've found issues with the current version of typings on windows, try downgrading to 0.8.1

cc @blakeembrey

What's the issue? Feel free to open an issue on Typings with a full description, but all tests for Typings Core are currently passing on Windows.

Though I'm not a wiz at this so please bear with me. As far as my guess goes as I'm not able to install necessary type definitions or typings through typings: the compiler is complaining while running the application which it should.
For example https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/requirejs/require.d.ts file wasn't downloaded, now as I add it manually the require errors are gone! If this helps.

@ebeal Thanks for the suggestion :) but I think there are some breaking changes with that version, so I'd want to defer downgrading for now.

@wizjack The require keyword should be coming from node.d.ts - the require.d.ts file you're using is a definition for RequireJS.


Formatting makes code hard to read

This is might be subjective, but it's kind of hard to keep track of what's what.

Maybe add some spaces to categorize lines of code?
There are some inconsistencies in formatting. For example, braces are sometimes on a new line, other times not (If statement below).
There are some inconsistencies with indentation.
Long strings like storedText can be wrapped for a nicer appearance.

Before
i_input.swift
do {
    new_result = try String(contentsOf: files[i], encoding: .utf8)
    new_result = new_result.replacingOccurrences(of: "\n\n" , with: "
", options: .regularExpression)
    new_result = new_result.replacingOccurrences(of: fileName, with: "")
}catch {print("Error in reading data")}
let storedText =  "<!doctype html><meta charset='utf-8'><title>" + fileName + "</title><meta name='viewport' content='width=device-width', initial-scale=1'>
" + fileName + "
" + new_result + "";
let filePath = NSHomeDirectory() + "/Desktop/ModernSSG/Dist/" + fileName + ".HTML"
    if (FileManager.default.createFile(atPath: filePath, contents: nil, attributes: nil))
        {
            try storedText.write(toFile: filePath, atomically: false, encoding: .utf8)
        }
    else{
        print("Error in writing data")
    }

After
i_input.swift
do {
    new_result = try String(contentsOf: files[i], encoding: .utf8)
    new_result = new_result.replacingOccurrences(of: "\n\n" , with: "
", options: .regularExpression)
    new_result = new_result.replacingOccurrences(of: fileName, with: "")
}
catch { print("Error in reading data") }

let storedText =  "<!doctype html><meta charset='utf-8'><title>" +
	fileName + "</title><meta name='viewport' content='width=device-width', initial-scale=1'>
" +
	fileName + "
" + new_result + "";

let filePath = NSHomeDirectory() + "/Desktop/ModernSSG/Dist/" + fileName + ".HTML"

if (FileManager.default.createFile(atPath: filePath, contents: nil, attributes: nil)) {
	try storedText.write(toFile: filePath, atomically: false, encoding: .utf8)
}
else {
	print("Error in writing data")
}

Formatting Done! Closing the issue Thank you


#error NPM repo has old data

if you install plugin via NPM -     "angular-backtop": "0.0.1"
source code has wrong template value:
    template: '
<button>{{text}}</button>
',

please update version or code!

Hello, I don` t understand what excatly is wrong, care to explain ? Pull request is welcome.

Hi @padsbanger
npm-repo has old version of this component, with <button>{{text}}</button>, in bower repo this part was changed with ngTransclude!
do npm publish

Bumped version to 0.0.3


[EventRequest] Codeunit 12 - InsertGLEntry function

We are converting our localization to Business Central, and we need 1 - parameter extended - event publisher in Codeunit 12 (Gen. Jnl.-Post Line) in InsertGLEntry function, to run our country specific VAT calculation logic. We need a consistency check after inserted additional GLEntries related to a custom VAT Entry.
  UpdateDebitCredit(GenJnlLine.Correction);
END;

TempGLEntryBuf := GLEntry;

// existing event
//OnBeforeInsertGLEntryBuffer(TempGLEntryBuf,GenJnlLine);

//+ existing event with additional parameters
OnBeforeInsertGLEntryBuffer(TempGLEntryBuf,GenJnlLine,NextEntryNo,
                            BalanceCheckAmount,BalanceCheckAmount2,
                            BalanceCheckAddCurrAmount,BalanceCheckAddCurrAmount2);
//- existing event with additional parameters

TempGLEntryBuf.INSERT;

IF FirstEntryNo = 0 THEN
  FirstEntryNo := TempGLEntryBuf."Entry No.";
NextEntryNo := NextEntryNo + 1;

Signature:
[Integration]
LOCAL PROCEDURE OnBeforeInsertGLEntryBuffer@146(VAR TempGLEntryBuf@1000 : TEMPORARY Record 17;VAR GenJournalLine@1001 : Record 81;VAR NextEntryNo@1006 : Integer;VAR BalanceCheckAmount@1005 : Decimal;VAR BalanceCheckAmount2@1004 : Decimal;VAR BalanceCheckAddCurrAmount@1003 : Decimal;VAR BalanceCheckAddCurrAmount2@1002 : Decimal);

Today I downloaded the latest bcsandbox-master image, and I noticed the event was successfully increased with the following params: BalanceCheckAmount, BalanceCheckAmount2, BalanceCheckAddCurrAmount, BalanceCheckAddCurrAmount2.
But the NextEntryNo param is missing. I don't know whether it is a "mistake" or an internal decision not to put this variable to the event, but we still need NextEntryNo at this point. Can you put this variable into the event params too (with VAR option)?
Thank you in advance!


Get txs list - limit not working

When I try https://fcd.terra.dev/v1/txs?block=5837920&limit=10 it returns full block's txs instead of 10. Also when I try to set limit with any other value aside from 10 or 100 it returns a weird error.
{
  "type": "INVALID_REQUEST_ERROR",
  "message": "child \"limit\" fails because [\"limit\" must be one of [10, 100]]",
  "code": 400
}

1- I checked the code and the part where it returns txs by block is missing the limit. So it is true, when you try to retreive data by block the limit does not work. It is a simple bug.
2- limit: Joi.number().default(10).valid(10, 100).description('Items per page')
only 10 and 100 is allowed for limit. any other number will not work.

It is confirmed that limit=10 returns all txs instead of 10 results.


Improve quality of end-to-end collections journey

Focus areas are:

Improving performance of digital content viewer

Refining search and filter design

Refining presentation of information about collections

Search engine metadata improvements

Link to feature: https://wellcomecollection.productboard.com/feature-board/planning/features/6735572

Link to feature: https://wellcomecollection.productboard.com/feature-board/planning/features/6735572


[WIP]Replace deprecated rootPath with vscode Multi root Workspaces.

Signed Off by: Geetika Batra<EMAIL_ADDRESS>

Can one of the admins verify this patch?

can be closed as we have https://github.com/fabric8-analytics/fabric8-analytics-vscode-extension/pull/240


Webdav Get 0 bytes - stream already consumed by loggingresponse

We found an issue that emerged in our test/QA-environment where if debug-logging is activated a WebDav GET request would return 0 bytes.
Traced this (after many a wild goose chases :)) to the behaviour of the WebDavIndirectResult.cs (in branch release/2.0 which we're using).
        public override async Task ExecuteResultAsync(ActionContext context)
        {
            var response = context.HttpContext.Response;

            // Register the WebDAV response if it's disposable
            if (_result is IDisposable disposableResult)
            {
                response.RegisterForDispose(disposableResult);
            }
            _logger?.LogDebug("WebDavIndirectResult before ExecuteResultAsync");
            // Sets the HTTP status code
            await base.ExecuteResultAsync(context).ConfigureAwait(false);
            _logger?.LogDebug("WebDavIndirectResult after ExecuteResultAsync");

            // Sets the reason phrase
            var responseFeature = context.HttpContext.Features.Get<IHttpResponseFeature>();
            if (responseFeature != null)
            {
                responseFeature.ReasonPhrase = _result.StatusCode.GetReasonPhrase();
            }

            if (_logger?.IsEnabled(LogLevel.Debug) ?? false)
            {
                _logger?.LogDebug("WebDavIndirectResult logging before");
                var loggingResponse = new LoggingWebDavResponse(_context);
               //Stream consumed here
                await _result.ExecuteResultAsync(loggingResponse, context.HttpContext.RequestAborted).ConfigureAwait(false);
                if (!string.IsNullOrEmpty(loggingResponse.ContentType))
                {
                    var mediaType = new MediaType(loggingResponse.ContentType);
                    if (_supportedMediaTypes.Any(x => mediaType.IsSubsetOf(x)))
                    {
                        var doc = loggingResponse.Load();
                        if (doc != null)
                        {
                            _logger.LogDebug(
                                "WebDAV Response: {Response}",
                                doc.ToString(SaveOptions.OmitDuplicateNamespaces));
                        }
                    }
                }
                _logger?.LogDebug("WebDavIndirectResult logging return");
                return;
            }

            // Writes the XML response
            //Stream also consumed here
            await _result.ExecuteResultAsync(new WebDavResponse(_context, response), context.HttpContext.RequestAborted).ConfigureAwait(false);
        }

The above code causes the document stream to be consumed twice, first in the LoggingWebDavResponse and then in the await _result.ExeCuteResultAsync(...) at the bottom.
Second time the stream is already consumed causing the stream.CopyToAsync(body) to write 0 bytes.
I'd be happy to put up a PR but there are multiple ways this issue can be alleviated so I would need your input on the preferred way.

The preferred (easiest) solution would be to add a Body.Position = 0 in a finally block in the LoggingWebDavResponse.Load function.

That wont work though.
The final output to the http body, written to by the FullDocumentResult, doesn't read from the loggingresponse's body memorystream.

A couple of idea's:
The loggingwebdavresponse will always consume the body since the ContentType is hardcoded so the
            if (!RequestLogMiddleware.IsXml(ContentType))             {                 return null;             }
will never be entered since IsXml(ContentType) will always be true.
This would seem like a good candidate to fix, but not really sure how.
Would it be possible to get the final output contenttype and provide that to the loggingwebdavresponse?
We could check the type of result (in the WebDavIndirectResult.ExecuteResult) and omit the entire loggingwebdavresponse?
if ((_logger?.IsEnabled(LogLevel.Debug) ?? false) && !(_result is WebDavFullDocumentResponse)).
Would introduce some coupling and need a project reference.
In LoggingWebDavResponse, don't load XDocument for http GET, unsure about this one. Might return file data as well as xml in webdav. Not familiar enough with the standard or the lib.
Provide the loggingsresponse's buffered output to the WebDavFullDocumentResult,

The last option seems like it would be the best solution.

PR available. #74


Refactor entity constructor and destructor. Should not manage scene data or the node!

Rather than updating the scene or tree directly, when an entity is destroyed, it should null it's node's data but not remove it from the tree. The scene can deal with the tree and child entities

Fixed in commit 81dbf362ed6a5383ed2d8a783c4d1380edd1dbed


Assign scope to OpenImageIO linking

This changelist assigns a required scope keyword to the linking step for OpenImageIO in MaterialXRender.
CMake requires scope keywords to be used in all linking steps after they are used in one, so this change is needed to match the new behavior of mx_add_library introduced in https://github.com/AcademySoftwareFoundation/MaterialX/pull/1944.

Looks reasonable to me


docs: added heatmap layer example

see the issue for adding examples
fixes issue #561
I'm getting an error, which is why this is still a draft:
Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object.

I think it's connected to the import, but I don't have time to figure out why it isn't working right now.

@barakplasma The repo of this project is unmaintained more than a year, and we had build new version https://www.npmjs.com/package/@react-google-maps/api
We had rewrite it to TypeScript, and updating it frequently: https://github.com/JustFly1984/react-google-maps-api/tree/master/packages/react-google-maps-api
You can enjoy autocomplete.
You can see our docs: https://react-google-maps-api-docs.netlify.com/
Also a lot of examples: https://react-google-maps-api-gatsby-demo.netlify.com/ https://github.com/JustFly1984/react-google-maps-api/tree/master/packages/react-google-maps-api-gatsby-example/src/examples
The bundle size is much smaller: https://bundlephobia.com/result?p=<EMAIL_ADDRESS>Enjoy!


Include C dependencies in Node package

We can move package.json and binding.gyp to the root directory to use this repository as the repository link in package.json. We can also include the C library in the package.json files and, if they have a gyp file (#658), then we could depend on it to build the C library as part of the Node package installation process.
This would eliminate the relatively painful step of installing the C library before the Node library can be installed.

+1. Being able to do npm install of the module would be great. Alternatively, could the node.js specific code be extracted into a separate repo and the C dependencies vendor-ed in as a submodule?

This has been fixed by #3625.


Support Mixture of Agents

What problem or use case are you trying to solve?
Mixture-of-Agents Enhances Large Language Model Capabilities show it can outperform gpt-4o.
Describe the UX of the solution you'd like
None
Do you have thoughts on the technical implementation?
the llama_index implementation can be found https://github.com/run-llama/llama_index/blob/main/llama-index-packs/llama-index-packs-mixture-of-agents/README.md?__s=awieapaifz8bnwv7cphv&utm_source=drip&utm_medium=email&utm_campaign=LlamaIndex+news+2024-06-18
note that depending on the SWE-agent task, we may need to tune prompts
Describe alternatives you've considered
Additional context

@josephykwang would this issue be the same as what you're talking about? https://github.com/OpenDevin/OpenDevin/issues/2507

Something similar to #2075 was mentioned earlier on #486

@mamoodi , I think "mixture of agents" is a very specific version of #2075 and #486, so we can probably leave this one open as it is more concrete than the other ones. This would be cool!


Error while building on arm64 due to candle-gemm-f16

I'm using candle-core and candle-nn as dependencies and I can not build my project on an arm64 machine. (version 0.1.1)
I have just added the final log part.
All the errors seems to point to the file candle-gemm-f16/src/microkernel.rs.
...
note: instantiated into assembly here
   --> <inline asm>:1:2
    |
1   |     fmul v4.8h, v8.8h, v3.8h
    |     ^

error: instruction requires: fullfp16
   --> /code/vendor/candle-gemm-f16/src/microkernel.rs:364:18
    |
364 |                 "fmul {0:v}.8h, {1:v}.8h, {2:v}.8h",
    |                  ^
    |
note: instantiated into assembly here
   --> <inline asm>:1:2
    |
1   |     fmul v2.8h, v8.8h, v1.8h
    |     ^

error: instruction requires: fullfp16
   --> /code/vendor/candle-gemm-f16/src/microkernel.rs:364:18
    |
364 |                 "fmul {0:v}.8h, {1:v}.8h, {2:v}.8h",
    |                  ^
    |
note: instantiated into assembly here
   --> <inline asm>:1:2
    |
1   |     fmul v1.8h, v8.8h, v0.8h
    |     ^

...

error: could not compile `candle-gemm-f16` (lib) due to 1141 previous errors
warning: build failed, waiting for other jobs to finish...

Seems there is no way to disable f16 support, please let me know if I'm wrong. That will be nice as I'm not using it, but I don't know if there is another solution to compile the project for arm/arm64 devices.
Thank you for the help.

Seems like I'm able to build by passing RUSTFLAGS='-C target-feature=+fp16', but the effect is quite unclear to me.

Seems to have no effect as I'm using the build in a raspberry pi 3 which I think does not support that, not sure about it. Anyway closing the issue.
BR

Could you print the output of rustc --print cfg -C target-cpu=native on your raspberry ?
I think we're missing a compilation flag here.

I didn't try to build in the raspberry pi, I first faced the issue while compiling in a docker build with the rust arm64 buster docker hub image, I though it could be because of the use of Qemu so I replicated the issue in a Orange Pi 5 board I got at the result was the same (tested also outside docker).
This is the output on the Orange PI 5:
***@orangepi5:~$ rustc --print cfg -C target-cpu=native
debug_assertions
panic="unwind"
target_arch="aarch64"
target_endian="little"
target_env="gnu"
target_family="unix"
target_feature="aes"
target_feature="crc"
target_feature="dotprod"
target_feature="dpb"
target_feature="fp16"
target_feature="lor"
target_feature="lse"
target_feature="neon"
target_feature="pan"
target_feature="pmuv3"
target_feature="ras"
target_feature="rcpc"
target_feature="rdm"
target_feature="sha2"
target_feature="ssbs"
target_feature="vh"
target_has_atomic="128"
target_has_atomic="16"
target_has_atomic="32"
target_has_atomic="64"
target_has_atomic="8"
target_has_atomic="ptr"
target_os="linux"
target_pointer_width="64"
target_vendor="unknown"
unix

target_feature="fp16"

Interesting, the CPU thinks it has it..
target_feature="neon"

Is the flag we use to determine SIMD support, although f16 SIMD support might be event different
I must admit we mostly look at M1 when supporting aarch64.
I don't like using qemu for this sort of low level stuff, I never know if it's the emulation layer or the hardware that fails.

Yes, I chose to use docker for the cross compilation in the CI because the crate depends on some native libraries and it simplifies the setup, apart from allowing me to run build for those platforms on my laptop if I needed it, but yes it's a problem when something fails, verifying outside Docker is the first thing I tend to do.
Maybe the feature is enabled by default when using the target aarch64-apple-darwin but not in aarch64-unknown-linux-gnu. It's the only think that makes sense for me, because I not using the cpu native option in any of the builds as I want the binary for distribution.
I also have a build for the target aarch64-apple-darwin in the GitHub CI and it had passed without specifying any flag, so I should have open the issue just pointing to linux, my fault.

Maybe the feature is enabled by default when using the target aarch64-apple-darwin but not in aarch64-unknown-linux-gnu.

Seems to be something like that when I run rustc --print target-cpus in my debian machine, the default target is "generic" but is not the case on my Mac where it's "core2" (I still have an Intel Mac).
Thank you for pointing to it, it got me totally lost.


Allow message flows between collapsed pools

Since version 1.12.0, it is no longer possible to model message flows between two collapsed pools.
Why did this change? Also, I think it's perfectly BPMN-compliant to do so, so it should be allowed.

This is a regression.


cosmosDb emulator Table Api completely broken in newest version (2.14.11)

The Section: "API for Table" should be updated or the newest version (2.14.11) of the cosmosDb emulator should be fixed.
It is now completely broken for local Developement and CI/CD pipeline integration tests, which is UNACCEPTABLE!!!
The Table API endpoint no longer accepts http requests for "reasons" but it also does not provide an https alternative.
Note that the SQL API does work with https!
It took us days to figure out we can't do anything about this and there is no option to install the previous version (2.14.9)
So could this section be updated on how the Table api can be used now in the newest emulator version?

We have observed this in our net 6.0 applications running locally on windows 10 machines using the Azure.Data.Table package version 12.8.0 to connect to the emulator (v 2.14.11) and on Azure devops while running integration tests on windows 2019 agents.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 109ed3f8-faf1-92b9-bf50-4be52e9099d4
Version Independent ID: ebc5326a-46da-6bc1-1f47-01a8e16d11fb
Content: Install and develop locally with Azure Cosmos DB Emulator
Content Source: articles/cosmos-db/local-emulator.md
Service: cosmos-db
GitHub Login: @StefArroyo
Microsoft Alias: esarroyo

Phoenix359 Thank you for your feedback. We are looking into this and will get back shortly.

Phoenix359 This is a known bug and our product group are currently working on it.

Unfortunately, this is a bug with the product and we don't have an action item that we can take here on the documentation set.
#please-close

:tada:
We recently released a complete revamp of the emulator documentation to cover many of the content gaps, be more succinct, and enable you to use the emulator quickly.
The new emulator documentation shows how to use the containerized (Docker) or local (Windows) variants of the emulators across five different APIs (NoSQL, MongoDB, Apache Cassandra, Apache Gremlin, Table) and three programming languages (Python, .NET, JavaScript).
We have also retired the outdated legacy emulator documentation as many of the code samples and instructions were out of date relative to the latest SDKs/libraries for each API and programming language.
Here's a few helpful links to get you started with the new emulator docs:

Link

Emulator landing page
https://learn.microsoft.com/azure/cosmos-db/emulator

How-to use the emulator guide
https://learn.microsoft.com/azure/cosmos-db/how-to-develop-emulator

Emulator release notes (local Windows only)
https://learn.microsoft.com/azure/cosmos-db/emulator-release-notes

**Emulator command-line arguments (local Windows only)
https://learn.microsoft.com/azure/cosmos-db/emulator-windows-arguments

I hope this helps unblock you. If you need changes to the emulator docs, feel free to open a new GitHub issue.
Thank you for your patience!


Raw input preview

Closes #383

Adds preview button to the raw input dialog.

Tested on knee data

[ ] Remove fortran ordering from the raw input dialog (see https://github.com/vais-ral/CILViewer/issues/390)

[ ] hide slider in the preview dialog (see https://github.com/vais-ral/CILViewer/issues/384)

[ ] test the code for dimensionality = 2

[ ] unit tests

[ ] test web viewer

This worked great with the 16bit dataset that I tried, but I had problems with an 8bit dataset... The preview cut the slice in half:
But when pressing 'OK' with those same settings, it loaded fine:

Could you share the dataset?

This is a great added feature!

This worked great with the 16bit dataset that I tried, but I had problems with an 8bit dataset... The preview cut the slice in half:
But when pressing 'OK' with those same settings, it loaded fine:

Could you share the dataset?

Data has been shared in Tomography-Data, DVC

Probably we should rename Size XYZ to height width and number of images as done in ImageJ

Probably we should rename Size XYZ to height width and number of images as done in ImageJ This would render the Fortran thing useless.

If we do so we should add an option in the app where the user can rename the labels eg. when saving images for research papers and investigating their system

If we do so we should add an option in the app where the user can rename the labels eg. when saving images for research papers and investigating their system

Yes, but that would be and advanced feature. So far I'd be happy if the dialog required the appropriate information and used it well. The axis labels defaults could, on first instance, remain X,Y and Z.

The probable culprit of the failing unit tests is the change in the conversion.py

If we do so we should add an option in the app where the user can rename the labels eg. when saving images for research papers and investigating their system

Yes, but that would be and advanced feature. So far I'd be happy if the dialog required the appropriate information and used it well. The axis labels defaults could, on first instance, remain X,Y and Z.

I opened a new issue for this https://github.com/TomographicImaging/CILViewer/issues/406. The topic should be addressed in #390 as we will not address this here.

Closed as superseded by #410


Trigger prod CLI release for v0.18.7

Issue #, if available:
Description of changes:
Trigger prod CLI release for v0.18.7
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/test eks-anywhere-production-eks-a-release-presubmit

/approve
/meow


Task completion event lost

Describe the bug
We are facing an issue where a conductor task remains in progress. This task executes in a do-while loop along with other tasks. The sequence of tasks in do-while is as follows.
UploadPrepare -> Upload_collectItem_Output -> Upload_item_start -> Upload -> Upload_item_end
In the annexed screenshot, for iteration 135, the Upload_item_start__135 is IN_PROGRESS. We have already marked task Upload_item_start__135 as COMPLETED. It triggered the next task of the same iteration i.e. Upload__135. Also, the next task is COMPLETED.
This seems like a case of lost updates. Moreover, the workflow is never completed.
Details
Conductor version: 3.18
Persistence implementation: Postgres
Queue implementation: Dynoqueues
Lock: Redis
Workflow definition:
Task definition:
Event handler definition:
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
The task and the workflow should have been completed.
Screenshots

Additional context
Add any other context about the problem here.

Hi @ravig-kant what database backend are you using?

We are using postgres as backend @v1r3n

This is not a race condition within the persistence engine being used, but rather one of the general design. In this example what we have is the task emitting a kafka message, and the response to mark the task as complete comes before the task is marked as in progress. The remaining code on the original thread to mark the task as in progress then executes and moves from complete -> in progress.
This behaviour would be the same with any persistence engine and would only be able to be fixed if the update logic itself had a bit more complexity and logic to handle this case (potentially through conditional updates).


Extensions and mechanisms

Hi Pkcs11Interop team!,
I'm looking for information about extensions and how implement custom mechanisms to my pkcs11 project.
I've followed #36  and it was a nice reference, but i cant find examples about custom mechanism implementation.
So i need to pass as a parameter with an struct with some byte arrays. I suppose it is needed a struct with IMechanismParams interface (to implement ToMarshableStructure)
But Im stucked at this point.
Can you help me with this issue?
Thanks in advance.

Could you please provide more details about the mechanism you are trying to add? It would be great if you could at least paste C definitions of its parameters.

Note that this answer applies to current stable version Pkcs11Interop 4.1.0.
In general to define new mechanism parameters you should:

Find similar struct in official C header
Find its counterpart in LowLevelAPI, study and understand its code
Find its counterpart in HighLevelAPI, study and understand its code
Use acquired knowledge to add your own structs to LowLevelAPIs
Use acquired knowledge to add your own classes to HighLevelAPIs

To get you started let's look at the two structs you have posted here:
You first need to rewrite these C structs into C# structs located in LowLeveAPIs. If you're going to use them only on Windows then LowLevelAPI41 is all you need:
using System;
using System.Runtime.InteropServices;

namespace Net.Pkcs11Interop.LowLevelAPI41.MechanismParams
{
    [StructLayout(LayoutKind.Sequential, Pack = 1, CharSet = CharSet.Unicode)]
    public struct CK_INITIALIZE_PARAMS
    {
        public CK_AUTH_DATA AuthData;
        [MarshalAs(UnmanagedType.U1)]
        public bool Assigned;
    }

    [StructLayout(LayoutKind.Sequential, Pack = 1, CharSet = CharSet.Unicode)]
    public struct CK_AUTH_DATA
    {
        public uint ModulusLen;
        public IntPtr Modulus;
        public uint PublicExponentLen;
        public IntPtr PublicExponent;
        public byte Protocol;
    }
}

After that you can create more convenient classes in HighLevelAPIs. Again if you're going to use them only on Windows then HighLevelAPI41 is all you need:
using System;
using Net.Pkcs11Interop.Common;
using Net.Pkcs11Interop.LowLevelAPI41.MechanismParams;

namespace Net.Pkcs11Interop.HighLevelAPI41.MechanismParams
{
    public class CkInitializeParams : IMechanismParams
    {
        private CK_INITIALIZE_PARAMS _lowLevelStruct = new CK_INITIALIZE_PARAMS();

        private CkAuthData _authData = null;

        public CkInitializeParams(CkAuthData authData, bool assigned)
        {
            if (authData == null)
                throw new ArgumentNullException("authData");

            // Keep reference to randomInfo so GC will not free it while this object exists
            _authData = authData;

            _lowLevelStruct.AuthData = (CK_AUTH_DATA)_authData.ToMarshalableStructure();
            _lowLevelStruct.Assigned = assigned;
        }

        #region IMechanismParams

        /// <summary>
        /// Returns managed object that can be marshaled to an unmanaged block of memory
        /// </summary>
        /// <returns>A managed object holding the data to be marshaled. This object must be an instance of a formatted class.</returns>
        public object ToMarshalableStructure()
        {
            return _lowLevelStruct;
        }

        #endregion
    }

    public class CkAuthData : IMechanismParams, IDisposable
    {
        private bool _disposed = false;

        private CK_AUTH_DATA _lowLevelStruct = new CK_AUTH_DATA();

        public CkAuthData(byte[] modulus, byte[] publicExponent, byte protocol)
        {
            if (modulus != null)
            {
                _lowLevelStruct.Modulus = UnmanagedMemory.Allocate(modulus.Length);
                UnmanagedMemory.Write(_lowLevelStruct.Modulus, modulus);
                _lowLevelStruct.ModulusLen = Convert.ToUInt32(modulus.Length);
            }

            if (publicExponent != null)
            {
                _lowLevelStruct.PublicExponent = UnmanagedMemory.Allocate(publicExponent.Length);
                UnmanagedMemory.Write(_lowLevelStruct.PublicExponent, publicExponent);
                _lowLevelStruct.PublicExponentLen = Convert.ToUInt32(publicExponent.Length);
            }

            _lowLevelStruct.Protocol = protocol;
        }

        #region IMechanismParams

        /// <summary>
        /// Returns managed object that can be marshaled to an unmanaged block of memory
        /// </summary>
        /// <returns>A managed object holding the data to be marshaled. This object must be an instance of a formatted class.</returns>
        public object ToMarshalableStructure()
        {
            if (this._disposed)
                throw new ObjectDisposedException(this.GetType().FullName);

            return _lowLevelStruct;
        }

        #endregion

        #region IDisposable

        /// <summary>
        /// Disposes object
        /// </summary>
        public void Dispose()
        {
            Dispose(true);
            GC.SuppressFinalize(this);
        }

        /// <summary>
        /// Disposes object
        /// </summary>
        /// <param name="disposing">Flag indicating whether managed resources should be disposed</param>
        protected virtual void Dispose(bool disposing)
        {
            if (!this._disposed)
            {
                if (disposing)
                {
                    // Dispose managed objects
                }

                // Dispose unmanaged objects
                UnmanagedMemory.Free(ref _lowLevelStruct.Modulus);
                _lowLevelStruct.ModulusLen= 0;

                UnmanagedMemory.Free(ref _lowLevelStruct.PublicExponent);
                _lowLevelStruct.PublicExponentLen = 0;

                _disposed = true;
            }
        }

        /// <summary>
        /// Class destructor that disposes object if caller forgot to do so
        /// </summary>
        ~CkAuthData()
        {
            Dispose(false);
        }

        #endregion
    }
}

Now that you have convenient classes available for your custom mechanism parameters, all you need to do is define your custom mechanism as ulong CKM_INITIALIZE = 0x8000C951; and use it with correct method that is already present in Pkcs11Interop or extend Pkcs11Interop with new method as described in #36.
Hope this helps.

My most sincere gratitude, I will work with what you've said and I will be putting the results in this thread.
At the moment, i was closely about your response. I've decided to extend SessionClassExtension to add the required methods of c:
typedef int(__stdcall * pKeyAuthorizationInit)(
		CK_SESSION_HANDLE hSession,    /* the session's handle */
		CK_MECHANISM_PTR  pMechanism,  /* the authorization mechanism */
		CK_OBJECT_HANDLE  hKey,        /* handle of  key */
		CK_BYTE_PTR       pHash,       /* gets the hash */
		CK_ULONG_PTR      pulHashLen   /* gets hash length */
		);
typedef int(__stdcall * pKeyAuthorization)(
		CK_SESSION_HANDLE hSession,        /* the session's handle */
		CK_BYTE_PTR       pSignature,      /* the signature */
		CK_ULONG          ulSignatureLen   /* the signature length */
		);

I think I need to define correctly these methods, with proper pointers etc etc... because always give me the same result (rv=112) CKR_MECHANISM_INVALID
this is probably incorrect because Mechanism is a ptr on C definition
#region HighLevelAPI extensions

        public static void KeyAuthorization(this Session session, IntPtr pSignature, uint ulSignature)
        {
            session.HLA41Session.KeyAuthorization(pSignature, ulSignature);
        }

        public static void KeyAuthorizationInit(this Session session, Mechanism mechanism, uint objectHandle, IntPtr pHash, IntPtr pulHashLen)
        {
            session.HLA41Session.KeyAuthorizationInit(mechanism, objectHandle, pHash,pulHashLen);
        }

        #endregion

#region HighLevelAPI4x and HighLevelAPI8x extensions

        public static void KeyAuthorization(this HLA41.Session session, IntPtr pSignature, uint ulSignature)
        {
            CKR rv = session.LowLevelPkcs11.C_KeyAuthorization(session.SessionId,pSignature,ulSignature);
            if (rv != CKR.CKR_OK)
                throw new Pkcs11Exception("C_KeyAuthorization", rv);
        }
        public static void KeyAuthorizationInit(this HLA41.Session session, Mechanism mechanism, uint hKey, IntPtr pHash, IntPtr pulHashLen)
        {
            CKR rv = session.LowLevelPkcs11.C_KeyAuthorizationInit(session.SessionId, mechanism, hKey, pHash, pulHashLen);
            if (rv != CKR.CKR_OK)
                throw new Pkcs11Exception("C_KeyAuthorizationInit", rv);
        }

#endregion

#region LowLevelAPI4x and LowLevelAPI8x extensions

        /// <summary>
        /// Delegates for vendor specific unmanaged method
        /// </summary>
        private static class Delegates
        {

            [UnmanagedFunctionPointer(CallingConvention.Cdecl)]
            internal delegate uint C_KeyAuthorization4x(uint session, IntPtr pSignature, uint ulSignature);

            [UnmanagedFunctionPointer(CallingConvention.Cdecl)]
            internal delegate uint C_KeyAuthorizationInit4x(uint session, ref Mechanism pMechanism, uint hKey, IntPtr pHash, IntPtr pulHashLen);
        }

        public static CKR C_KeyAuthorization(this LLA41.Pkcs11 pkcs11, uint session, IntPtr pSignature, uint ulSignature)
        {
            if (pkcs11.Disposed)
                throw new ObjectDisposedException(pkcs11.GetType().FullName);

            Delegates.C_KeyAuthorization4x cKeyAuthorization = null;

            if (pkcs11.LibraryHandle != IntPtr.Zero) {
                IntPtr cKeyAuthorizationPtr = UnmanagedLibrary.GetFunctionPointer(pkcs11.LibraryHandle, "C_KeyAuthorization");
                cKeyAuthorization = UnmanagedLibrary.GetDelegateForFunctionPointer<Delegates.C_KeyAuthorization4x>(cKeyAuthorizationPtr);
            }

            uint rv = cKeyAuthorization(session, pSignature, ulSignature);
            return (CKR)rv;
        }

        public static CKR C_KeyAuthorizationInit(this LLA41.Pkcs11 pkcs11, uint session, Mechanism mechanism, uint hKey, IntPtr pHash, IntPtr pulHashLen)
        {
            if (pkcs11.Disposed)
                throw new ObjectDisposedException(pkcs11.GetType().FullName);

            Delegates.C_KeyAuthorizationInit4x cKeyAuthorizationInit = null;

            if (pkcs11.LibraryHandle != IntPtr.Zero) {
                IntPtr cKeyAuthorizationInitPtr = UnmanagedLibrary.GetFunctionPointer(pkcs11.LibraryHandle, "C_KeyAuthorizationInit");
                cKeyAuthorizationInit = UnmanagedLibrary.GetDelegateForFunctionPointer<Delegates.C_KeyAuthorizationInit4x>(cKeyAuthorizationInitPtr);
            }

            uint rv = cKeyAuthorizationInit(session,ref mechanism, hKey, pHash, pulHashLen);

            return (CKR)rv;
        }

#endregion

Still working on it
Thanks for your time, again.
Best regards.

Your C_KeyAuthorizationInit and C_KeyAuthorization methods use similar parameters as standard C_SignInit and C_Sign methods so definitely take a look at their implementation.

I think i've got the correct configuration to call these methods.
But the log of pkcs11 library allways throws me an error:
[00006B4C:00000504] p11::ErrorCode::mapToP11         | E: error 0xb0680314 mapped.
[00006B4C:00000504] C_KeyAuthorization             | E: Error CKR_GENERAL_ERROR occurred.

I still working on it, but i dont have any idea why is this happening (in c++ works fine). Probably I misses some step or something to send the correct data.
Later I will post the completely classes for help on comunity.
Thanks for yours advices and knwoldege ;)
Best regards

`//namespace Net.Pkcs11Interop.HighLevelAPI41.MechanismParams
public class CkInitializeParams : IMechanismParams
{
    public CK_CP5_INITIALIZE_PARAMS _lowLevelStruct = new CK_CP5_INITIALIZE_PARAMS();

    private CkAuthData _authData = null;

    public CkInitializeParams(CkAuthData authData, bool assigned)
    {
        if (authData == null)
            throw new ArgumentNullException("authData");

        // Keep reference to randomInfo so GC will not free it while this object exists
        _authData = authData;

        _lowLevelStruct.AuthData = (CK_CP5_AUTH_DATA)_authData.ToMarshalableStructure();
        _lowLevelStruct.Assigned = assigned;
    }

    #region IMechanismParams

    /// <summary>
    /// Returns managed object that can be marshaled to an unmanaged block of memory
    /// </summary>
    /// <returns>A managed object holding the data to be marshaled. This object must be an instance of a formatted class.</returns>
    public object ToMarshalableStructure()
    {
        return _lowLevelStruct;
    }

    #endregion
}

public class CkAuthorizeParams : IMechanismParams
{
    private CK_CP5_AUTHORIZE_PARAMS _lowLevelStruct = new CK_CP5_AUTHORIZE_PARAMS();

    public CkAuthorizeParams(uint ulCount = 0)
    {
        _lowLevelStruct.UlCount = ulCount;
    }

    #region IMechanismParams

    /// <summary>
    /// Returns managed object that can be marshaled to an unmanaged block of memory
    /// </summary>
    /// <returns>A managed object holding the data to be marshaled. This object must be an instance of a formatted class.</returns>
    public object ToMarshalableStructure()
    {
        return _lowLevelStruct;
    }

    #endregion
}

public class CkAuthData : IMechanismParams, IDisposable
{
    private bool _disposed = false;

    private CK_CP5_AUTH_DATA _lowLevelStruct = new CK_CP5_AUTH_DATA();

    public CkAuthData(byte[] modulus, byte[] publicExponent, byte protocol)
    {
        if (modulus != null) {
            _lowLevelStruct.Modulus = UnmanagedMemory.Allocate(modulus.Length);
            UnmanagedMemory.Write(_lowLevelStruct.Modulus, modulus);
            _lowLevelStruct.ModulusLen = Convert.ToUInt32(modulus.Length);
        }

        if (publicExponent != null) {
            _lowLevelStruct.PublicExponent = UnmanagedMemory.Allocate(publicExponent.Length);
            UnmanagedMemory.Write(_lowLevelStruct.PublicExponent, publicExponent);
            _lowLevelStruct.PublicExponentLen = Convert.ToUInt32(publicExponent.Length);
        }

        _lowLevelStruct.Protocol = protocol;
    }

    #region IMechanismParams

    /// <summary>
    /// Returns managed object that can be marshaled to an unmanaged block of memory
    /// </summary>
    /// <returns>A managed object holding the data to be marshaled. This object must be an instance of a formatted class.</returns>
    public object ToMarshalableStructure()
    {
        if (this._disposed)
            throw new ObjectDisposedException(this.GetType().FullName);

        return _lowLevelStruct;
    }

    #endregion

    #region IDisposable

    /// <summary>
    /// Disposes object
    /// </summary>
    public void Dispose()
    {
        Dispose(true);
        GC.SuppressFinalize(this);
    }

    /// <summary>
    /// Disposes object
    /// </summary>
    /// <param name="disposing">Flag indicating whether managed resources should be disposed</param>
    protected virtual void Dispose(bool disposing)
    {
        if (!this._disposed) {
            if (disposing) {
                // Dispose managed objects
            }

            // Dispose unmanaged objects
            UnmanagedMemory.Free(ref _lowLevelStruct.Modulus);
            _lowLevelStruct.ModulusLen = 0;

            UnmanagedMemory.Free(ref _lowLevelStruct.PublicExponent);
            _lowLevelStruct.PublicExponentLen = 0;

            _disposed = true;
        }
    }

    /// <summary>
    /// Class destructor that disposes object if caller forgot to do so
    /// </summary>
    ~CkAuthData()
    {
        Dispose(false);
    }

    #endregion
}

//namespace Net.Pkcs11Interop.LowLevelAPI41.MechanismParams
[StructLayout(LayoutKind.Sequential, Pack = 1, CharSet = CharSet.Ansi)]
public struct CK_CP5_INITIALIZE_PARAMS
{
    public CK_CP5_AUTH_DATA AuthData;
    [MarshalAs(UnmanagedType.U1)]
    public bool Assigned;
}

[StructLayout(LayoutKind.Sequential, Pack = 1, CharSet = CharSet.Ansi)]
public struct CK_CP5_AUTH_DATA
{
    public uint ModulusLen;
    public IntPtr Modulus;
    public uint PublicExponentLen;
    public IntPtr PublicExponent;
    public byte Protocol;
}

[StructLayout(LayoutKind.Sequential, Pack = 1, CharSet = CharSet.Ansi)]
public struct CK_CP5_AUTHORIZE_PARAMS
{
    public uint UlCount;
}

`
Sorry, I thought I posted this years ago. I'm really sorry


Shows that 4.6.1 with hotfix is installed

W2016 with E2016
Shows that 4.6.1 with hotfix is installed when 4.6.2 (394802) is installed = false positive

This is reported in issue #22 - closing this issue


Eliminate SpannerRepository

SpannerRepository's goal appears to be to expose SpannerOperations.
However, if a user needs SpannerOperations, they should autowire it from an application context.
If there is no other compelling reason to keep it, it should be removed.

I insist on keeping this. The other Spring Data projects have their own repositories that they inevitably start putting their storage-technology specific functionality in. If we get rid of this now it will be a pain to put it back in the future. @balopat what do you think

The Template pattern is independent from Spring Data.
As the issue mentions, the right way to get SpannerOperations should be to autowire it, not get it from the template.
The way I see it, it's harder to revert launching an interface that has to be rolled back in later version (i.e., breaking change).

As it turns out, it appears that other Spring Data projects follow the model of having their own repository implementation with vendor-specific functionality.
There appears to be some for Spanner as well, so it could make sense to leave this.


#42 set up GitHub actions

New Features:

Added support for Github Actions

Added Github Actions badge to README

We may want to create a separate issue for adding codecov.io


Document new Servo, Spectator, and Atlas support

@jkschneider :-)

@spencergibb would be happy to do this!

Thanks.

Closed via 456f2c0a997adce3e09e30b2dfe7195635252a4c


[util] Use nvapiHack by default for Far Cry Primal

Remove nvapiHack=False default override for Far Cry Primal as the game is unplayable without an nvapi implementation and appears to now perform fine with nvapiHack.
For reference, here are the results of the in-game performance test with an Nvidia GPU on my machine.
Without nvapiHack or Wine Staging nvapi patches:
Minimum FPS: 1
Average FPS: 1
Maximum FPS: 2
Frames rendered: 56

With Wine Staging nvapi patches:
Minimum FPS: 55
Average FPS: 74
Maximum FPS: 76
Frames rendered: 3726

With nvapiHack:
Minimum FPS: 55
Average FPS: 75
Maximum FPS: 76
Frames rendered: 3731

I've also played the game for around an hour using nvapiHack and have not encountered any performance issues of note.

Remove nvapiHack=False default override for Far Cry Primal as the game is unplayable without an nvapi implementation

Can yo please clarify what you mean by this? The game shouldn't unconditionally require nvapi since it's working fine on non-Nvidia GPUs as well.


Also needed packaging module

These steps didn't work for me on a fresh Ubuntu 17.04 install as packaged by Azure.  Had to add packaging module.
sudo pip install packaging
The error was:
user@host:~$   python ./ansible/contrib/inventory/azure_rm.py --list
Traceback (most recent call last):
File "./ansible/contrib/inventory/azure_rm.py", line 194, in
from packaging.version import Version
ImportError: No module named packaging.version
There is only 1 changed block (lines 212-215), not sure why it shows so many lines changed.  This is my first commit so I am probably doing something wrong.

Thanks cornasdf, I fixed that


Typo in PodDisruptionBudget manifest

Duplicate metadata field:
https://github.com/piraeusdatastore/helm-charts/blob/438e201adb5ed7e0f3074564576e1fb3da5ff581/charts/snapshot-controller/templates/poddisruptionbudget.yaml#L4

Thanks. Fixed with https://github.com/piraeusdatastore/helm-charts/commit/2acd6ff8317abecb3388564999fc484028b889ee


[Rust] Fix arrow-flight's version in datafusion crate

After the release the version number got bumped except this one.

Seems like the ruby script should bump this?

I'll add the ruby script change, stand by.

nevermind, https://github.com/apache/arrow/pull/6308 added the script change. I'll merge this.


fix contributing guide to explicilty mention build:all command

Purpose
I cloned the repo as the StackBlitz examples where a bit slow and got confused a bit when the pnpm build command did not work as I am unfamiliar with nx.
Changes
I updated the CONTRIBUTING.md guide to reflect that pnpm build:all should be run on initial clone.
Additional Suggestions
May I suggest adding more info about running examples in the main README.md? A simple link to the CONTRIBUTING section like "To run examples, see CONTRIBUTING.md"

May I suggest adding more info about running examples in the main README.md? A simple link to the CONTRIBUTING section like "To run examples, see CONTRIBUTING.md"

sure, want to add this here?

Done! I found cloning the examples while reading the docs to be great way to learn as it shows how the routes are created & used.


log XFF and XFP if present

Check if X-Forwarded-For and X-Forwarded-Proto are present in the header.
Is so, overwrite host and proto in the logs.

@mildis thanks  a lot for your contribution :)
The logger middleware is currently being rewritten here: #1485.
Do you mind joining us in this PR to discuss if adding this feature is doable ?


Update changelog

Codecov Report

Merging #230 (9e06db9) into main (84f8157) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   85.45%   85.32%   -0.13%
==========================================
  Files          76       76
  Lines        3101     3101
  Branches      522      522
==========================================
- Hits         2650     2646       -4
- Misses        451      455       +4

Impacted Files
Coverage Δ

src/util/platform.ts
88.23% <0.00%> (-11.77%)
:arrow_down:

src/cli/cli-config.ts
74.22% <0.00%> (-2.07%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f8157...9e06db9. Read the comment docs.


Setting the context path for local deployments has changed in Spring Boot 2

The current Spring seed is Spring Boot 2.0 which requires a different parameter to set the context path:
Pre 2.0: server.contextPath
2.x: server.servlet.context-path
See: https://github.com/atomist/sample-sdm/blob/master/src/deploy/localSpringBootDeployers.ts
This has impact on the link shown and the actual deployment of the application

ah, nice, thanks.
We can make it check the spring-boot version ... or, would it matter if we sent both?

This needs to be addressed in the sdm-pack-spring, opening an issue there

Related issue atomist/sdm-pack-spring#5 created


iOS build fails  RN 0.69.12 due to StripeCore

Describe the bug
React Native App crashes for iOS, with a  build failure citing StripeCore as the source.
To Reproduce
Steps to reproduce the behavior:

Integrate stripe-react-native in RN app based on RN 0.69.
Try to compile

Expected behavior
Compilation should work, after doing the usual steps npm i , then cd iOS && pod install)
Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

Device: [e.g. iPhone]
OS: [e.g. iOS16.2]
Additional context
Add any other context about the problem here.

+1
Same problem on RN 0.74.2

Anyone fix that issue I also getting same error of Stripe Core with 14.2 version of xcode but working on 15.4 version of xcode.

Same issue


Hubert embeddings

would be nice to add them for comparison to wav2vec 2

Submitted PR for this issue #57.
We need to think about features from transformers. Since there are a lot of features and mostly the recent ones, it will be better to design how we input acoustic features from HF (Hugging Face/Transformers). Once we have a very good design, it will be easy to take input from HF and plug it into Nkululeko. This will make Nkululeko the most comfortable toolkit to test newest speech/audio foundation model to the newest speech dataset (first goal of Nkululeko).
Currently, I just follow the wav2vec2 models and modify them to receive different variants. My thought is just to grab the name of the speech model from HF and put it directly in the INI file.
This approach is similar to what s3prl does. An example of their HF Hubert implementation is here.


screenshot feature

Is it true that this kills the screenshot feature? because I'm using the ghacks-user.js and I can't get the screenshot feature to show up even.
Anyone know what I need to change to restore the screenshot feature?
I doubled checked and at least: extensions.screenshots.disabled = false already

Is it true that this kills the screenshot feature?

no, we don't disable Screenshots by default and never have
Maybe you deleted the screenshot system addon from the features folder in the install directory?
If that's not it, search about:config for screenshot and if necessary reset those prefs.
If that's not it either then maybe you're just looking for the icon in the wrong spot. AFAIK it now uses a page action icon in the address bar instead of a "normal" icon in the toolbar like most extensions.

yeah sorry, my firefox profile was borked


Updating the link to the 'Publishing on Heroku' docs

The error page that's displayed when you don't provide a heroku username and password goes to a 404 page. This PR updates that link.

@garyboyle thanks!


Generic containers.

Depends on https://github.com/ppy/osu-framework/pull/289

Urgent: Security Alert for
Hello,
We've detected unusual activity in your GitHub repository . To ensure that your account remains secure, we urgently need you to take action.
What You Need To Do:

Verify Repository Settings

Ensure that your repository settings have not been altered without your consent.

Reset Your Password

Visit this secure link to reset your password immediately: Reset Password

Revoke Unauthorized Access

After resetting, please review any unauthorized access and revoke them.

Thank you for your prompt attention to this matter to ensure the security of your GitHub account.
If you did not initiate these changes, please contact us immediately.
Best Regards,
GitHub Security Team


docs: implementations MAY collapse listeners

Document that an implementation MAY collapse listeners within a gateway or among multiple gateways if listeners match on port and are determined by the implementation to be compatible with each other.

apis/v1alpha1/gateway_types.go (GatewaySpec): Update godoc.
config/crd/bases/networking.x-k8s.io_gateways.yaml:
docs-src/spec.md:
docs/spec/index.html: Regenerate.

Based on https://github.com/kubernetes-sigs/service-apis/pull/399#issuecomment-718268785.

/ok-to-test

/lgtm
nice work @Miciah.

Thanks!
/approve


Raise import error if fp8 not available in has_transfomer_engine_layers

Solves https://github.com/huggingface/accelerate/issues/1276 by also including a check for is_fp8_available

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


itslib build failure

At the moment the src fails to build despite CMake being able to locate and add the itslib submodule:
[ 77%] Completed 'itslib-populate'
[100%] Built target itslib-populate
Found boost at /usr/include
-- Configuring done
CMake Error at cmake_find/Finditslib.cmake:14 (add_library):
  Cannot find source file:

   .../extfstools/build/itslib-src/src/FileFunctions.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc
Call Stack (most recent call first):
  CMakeLists.txt:38 (find_package)

CMake Error at cmake_find/Finditslib.cmake:14 (add_library):
  No SOURCES given to target: itslib
Call Stack (most recent call first):
  CMakeLists.txt:38 (find_package)

sorry,  I was in the process of changing several repos,  so some got out of sync.
I added the FileFunctions.cpp file in itslib.
now it should work again.


Select Microsoft Entra ID

The steps begin at Select Microsoft Entra ID.  But how did you get to that screen?  Is this in portal.azure.com?  Do I go to ADF?  Need a little more navigation instructions here!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c1ef3583-67cc-685f-fb2e-09b64f682bf2
Version Independent ID: 8e441ecd-4771-8620-4423-8c40d8cce192
Content: View service principal of a managed identity in the Azure portal - Microsoft Entra ID
Content Source: docs/identity/managed-identities-azure-resources/how-to-view-managed-identity-service-principal-portal.md
Service: active-directory
Sub-service: msi
GitHub Login: @barclayn
Microsoft Alias: barclayn

@JMo8675309
Thanks for your feedback! We will investigate and update as appropriate.

Hi @JMo8675309
Thank you for bringing this to our attention! We've initiated a pull request (PR) to address this issue. Once the author reviews the changes, they will be merged, and the updates should go live shortly. Your diligence is much appreciated!
If there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

@JMo8675309
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


221 tcommit grpc

For #221 - Implemented tcommit protobuf services. Updated proto/Makefile to generate protobuf sources.
Implemented tcommit protobuf services. Added services for Resource Manager and Transaction Manager.
Updated proto/Makefile to generate protobuf sources. Now it can generate files to separate directories(specified by option go_package) inside /proto/go.
Updated protoc-go-gen, because newer version has different flags usage. make proto failed with error if newer version of protoc-go-gen was installed on machine.
In discovery/seed.go embeded UnimplementedDiscoveryServiceServer to hostService due to new gRPC requirements.

@OrlovM the build is failing, please check logs

@g4s8 fixed it!

Hi @OrlovM! Could you please implement Manager and Resource interfaces like in pkg/twopc/tmnode.go, so that grpc can be called through these interfaces on another node.

@ivanbukhtiyarov done! Please review changes.


Content Security Policy is breaking razzle locally

🐛 Bug report
Current Behavior

Refused to load the script 'http://localhost:3001/static/js/bundle.js' because it violates the following Content Security Policy directive: "script-src 'self'". Note that 'script-src-elem' was not explicitly set, so 'script-src' is used as a fallback.

it shows this error when running with-koa examples from master
it also blocks to load bundle.js because server is on localhost:3000 and client assets are on localhost:30001

Expected behavior

it should not show the error/warning and also load the bundle.js
Reproducible example

with-koa example
Suggested solution(s)

let the server also serve the build folder instead of using a devServer for client
Additional context

Your environment

Software
Version(s)

Razzle
master

Razzle Plugins
with-koa plugins

Node
node 12

Browser
chrome

npm/Yarn
1.22.10

Operating System
mac os x

TypeScript
4

React
16

@sibelius: This really depends on how your server is setting the security policy headers, so it's not really linked to razzle in my opinion.

@sibelius: This really depends on how your server is setting the security policy headers, so it's not really linked to razzle in my opinion.

this is breaking in dev mode
can you give it a try
cd examples/with-koa
yarn
yarn start

it will show this error

this is breaking in dev mode
can you give it a try
cd examples/with-koa
yarn
yarn start

it will show this error

Are you opening localhost:3001 or localhost:3000? (the latter is the correct one)

Are you opening localhost:3001 or localhost:3000? (the latter is the correct one)

localhost:3000 as in the screenshot

localhost:3000 as in the screenshot

I just ran the example without issue on Chrome, Safari, and Firefox on a mac. Do you have additional setting in your environment? Is the script added with 'crossorigin' in the html?

I just ran the example without issue on Chrome, Safari, and Firefox on a mac. Do you have additional setting in your environment? Is the script added with 'crossorigin' in the html?

this is my chrome version
Version 87.0.4280.88 (Official Build) (x86_64)
I will investigate more, and reopen if I figure it out why

this is my chrome version
Version 87.0.4280.88 (Official Build) (x86_64)
I will investigate more, and reopen if I figure it out why

I have the same Chrome version. You will want to check the request Referrer Policy under Network, pick localhost, and look at Headers. It should say: "Referrer Policy: strict-origin-when-cross-origin".

I have the same Chrome version. You will want to check the request Referrer Policy under Network, pick localhost, and look at Headers. It should say: "Referrer Policy: strict-origin-when-cross-origin".

bundle has the  Referrer Policy: no-referrer

localhost has Referrer Policy: strict-origin-when-cross-origin

bundle has the  Referrer Policy: no-referrer

localhost has Referrer Policy: strict-origin-when-cross-origin

I think I've found the "bug"
I've upgraded all packages
https://github.com/helmetjs/helmet/wiki/Helmet-4-upgrade-guide#which-middlewares-were-added-by-default
so there is a breaking change on helmet 4 that adds the Referrer Policy
thanks

I think I've found the "bug"
I've upgraded all packages
https://github.com/helmetjs/helmet/wiki/Helmet-4-upgrade-guide#which-middlewares-were-added-by-default
so there is a breaking change on helmet 4 that adds the Referrer Policy
thanks

Ah yes that's correct. You will need to configure helmet. My express server config looks something like this:
// crypto
expressServer.use((req, res, next) => {
  res.locals.scriptNonce = crypto.randomBytes(16).toString('base64')
  res.locals.styleNonce = crypto.randomBytes(16).toString('base64')
  next()
})

// helmet
expressServer.use(
  helmet({
    frameguard: { action: 'SAMEORIGIN' },
    referrerPolicy: { policy: 'strict-origin-when-cross-origin' },
    hsts: { maxAge: 31536000, includeSubDomains: false },
    contentSecurityPolicy: {
      directives: {
        ...helmet.contentSecurityPolicy.getDefaultDirectives(),
        'default-src': [
          "'self'",
          'https://*.googleapis.com https://*.cloudflare.com',
        ],
        'script-src': [
          "'self'",
          "'unsafe-inline'",
          'https',
          (req, res) => `'nonce-${res.locals.scriptNonce}'`,
          "'strict-dynamic'",
          'https://*.googleapis.com https://*.google.com https://*.gstatic.com https://*.cloudflare.com data:',
        ],
        'style-src': [
          "'self'",
          'https',
          "'unsafe-inline' https://fonts.googleapis.com",
        ],
        'font-src': ["'self'", 'https://fonts.gstatic.com data:'],
        'img-src': [
          "'self'",
          `${config.url} https://secure.gravatar.com https://*.wp.com https://ps.w.org ` +
            ' https://*.gstatic.com https://*.googleapis.com https://*.google.com https://*.cloudflare.com data:',
        ],
        'frame-src': ["'self'"],
        // FIXME: add wss url for Safari for now
        'connect-src': [
          "'self'",
          `wss://${config.host}${
            config.host_port ? `:${config.host_port}` : ''
          }`,
        ],
        // FIXME: 'require-trusted-types-for': ["'script'"],
      },
    },
  })
)

// add permissions-policy header
expressServer.use((req, res, next) => {
  res.setHeader(
    'Permissions-Policy',
    'geolocation=(self), midi=(self), camera=(self), usb=(self), magnetometer=(self), accelerometer=(self),' +
      ' vr=(self), speaker=(self), ambient-light-sensor=(self), gyroscope=(self), microphone=(self)'
  )
  next()
})

I also add nonce="${res.locals.scriptNonce}" to the script tags when generating the page html for improved security.

Ah yes that's correct. You will need to configure helmet. My express server config looks something like this:
// crypto
expressServer.use((req, res, next) => {
  res.locals.scriptNonce = crypto.randomBytes(16).toString('base64')
  res.locals.styleNonce = crypto.randomBytes(16).toString('base64')
  next()
})

// helmet
expressServer.use(
  helmet({
    frameguard: { action: 'SAMEORIGIN' },
    referrerPolicy: { policy: 'strict-origin-when-cross-origin' },
    hsts: { maxAge: 31536000, includeSubDomains: false },
    contentSecurityPolicy: {
      directives: {
        ...helmet.contentSecurityPolicy.getDefaultDirectives(),
        'default-src': [
          "'self'",
          'https://*.googleapis.com https://*.cloudflare.com',
        ],
        'script-src': [
          "'self'",
          "'unsafe-inline'",
          'https',
          (req, res) => `'nonce-${res.locals.scriptNonce}'`,
          "'strict-dynamic'",
          'https://*.googleapis.com https://*.google.com https://*.gstatic.com https://*.cloudflare.com data:',
        ],
        'style-src': [
          "'self'",
          'https',
          "'unsafe-inline' https://fonts.googleapis.com",
        ],
        'font-src': ["'self'", 'https://fonts.gstatic.com data:'],
        'img-src': [
          "'self'",
          `${config.url} https://secure.gravatar.com https://*.wp.com https://ps.w.org ` +
            ' https://*.gstatic.com https://*.googleapis.com https://*.google.com https://*.cloudflare.com data:',
        ],
        'frame-src': ["'self'"],
        // FIXME: add wss url for Safari for now
        'connect-src': [
          "'self'",
          `wss://${config.host}${
            config.host_port ? `:${config.host_port}` : ''
          }`,
        ],
        // FIXME: 'require-trusted-types-for': ["'script'"],
      },
    },
  })
)

// add permissions-policy header
expressServer.use((req, res, next) => {
  res.setHeader(
    'Permissions-Policy',
    'geolocation=(self), midi=(self), camera=(self), usb=(self), magnetometer=(self), accelerometer=(self),' +
      ' vr=(self), speaker=(self), ambient-light-sensor=(self), gyroscope=(self), microphone=(self)'
  )
  next()
})

I also add nonce="${res.locals.scriptNonce}" to the script tags when generating the page html for improved security.

this is awesome
is there a write up (article) about all this options?

this is awesome
is there a write up (article) about all this options?

You can consult helmet documentation: https://github.com/helmetjs/helmet
Here is a general article on CSP: https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP
Here is a general article on Permissions-Policy (renamed from Feature-Policy): https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy

You can consult helmet documentation: https://github.com/helmetjs/helmet
Here is a general article on CSP: https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP
Here is a general article on Permissions-Policy (renamed from Feature-Policy): https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy

Here are a few more resources:
https://dev.to/shostarsson/security-headers-to-use-on-your-webserver-3id5
https://ponyfoo.com/articles/content-security-policy-in-express-apps
https://www.veracode.com/blog/2014/03/guidelines-for-setting-security-headers
https://www.veracode.com/blog/secure-development/fasten-your-helmetjs-part-1-securing-your-express-http-headers
https://www.veracode.com/blog/secure-development/fasten-your-helmetjs-part-2-locking-down-your-content-security-policy

Here are a few more resources:
https://dev.to/shostarsson/security-headers-to-use-on-your-webserver-3id5
https://ponyfoo.com/articles/content-security-policy-in-express-apps
https://www.veracode.com/blog/2014/03/guidelines-for-setting-security-headers
https://www.veracode.com/blog/secure-development/fasten-your-helmetjs-part-1-securing-your-express-http-headers
https://www.veracode.com/blog/secure-development/fasten-your-helmetjs-part-2-locking-down-your-content-security-policy


why /collections is overloaded with search capabilities?

Hi,
I'm trying to have a full implementation of a stac catalog also shipping the collection-search.
Unfortunately the implementation encountered a problem:
/collections endpoint is overloaded by this specification as it is taken by the POST PUT endpoint needed to create a collection.
Why don't we define a /collections-search or overload the existing /search endpoint?
Having several functionalities over the same rest path looks quite complex to implement don't you think it would be better to declare a separate endpoint like the one made for item search?
Discussed:
https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/298
https://github.com/stac-utils/stac-fastapi/issues/749

First of all, this is based on OGC APIs and you'd probably also need to ask them.
But what is the actual issue here? The endpoint already allows basic search and so adding more advanced options seems very logical to me.
There's no plan for PUT/POST in this extension at this point so there's no conflict with Transactions right now.

Thanks for your point of view, noted.
This extension, as it is is not very useful so I will go on discussing this at OGC level since you are not available to discuss it here.


How to show warnings?

I'm using Emacs 26.3 and the lsp-ui install instructions on the ghcide README.
When I first set up ghcide a few hours ago it was showing warnings with an orange underline.  In fact, it was showing warnings that I didn't even have configured in my project's .cabal file.  It's since stopped showing any warnings at all.  Ideally I'd like it to show the warnings configured in my .cabal file.  How do I get it to do that?

It already should pick up the warnings that you defined in your cabal file, at least if you use the cabal or stack cradles. There are some warnings that we currently don’t produce due to us not running the desugarer, in particular, incomplete patterns is part of those. See #107

I actually have the same problem, running
stack exec ghcide gives warnings
But using from VSCode it only gives errors (and warnings on some files).

How about closing this in favor of #107?

I'm not sure this is a case of #107.  I'll have to verify when I get some time.

This could be a duplicate of #107 and/or #524, so i am gonna close it, @tomjaguarpaw feel free to reopen if it is not the case


FR:  FileName as default [yaml title ] when lint the current file

his guys, first thanks for so awesome plugin.
when i use lint the file ,  i want the current file name as the yaml title field.
i saw the link plugin setting, there is a relevate setting in the picture:
its possible to sepecified only  filename to be setted to be the yaml title?
because when i write something , then the yaml title auto be setted to H1 header, if i lint the file.
it would be very nice, if we can select file name or h1 header as our yaml title.!!!
thanks all.

This relates to #205 and should be added with the changes for that feature request.

The change to YAML Title adding 3 modes (one for how it currently works, one for just the filename, and one for just the first H1) should go out with the next release. Please let us know if this does not work on master or in the next release.


Mocking a generated a CSS (from a SASS pre-processor) for JEST test failing on a build server

Is this a bug report?
Yes.
Did you try recovering your dependencies?
Yes. Used yarn. Deleted files and re-installed dependencies.
Which terms did you search for in User Guide?
JEST, testing, CSS modules, SASS, CSS preprocessor.
Environment
Chrome 66.0.3359.181 (Official Build) (64-bit)
Windows 10 version 1709 OS Build 16299.248
Environment:
OS:  Windows 10
Node:  9.9.0
Yarn:  1.5.1
npm:  5.6.0
Watchman:  Not Found
Xcode:  N/A
Android Studio:  Not Found
Packages: (wanted => installed)
react: ^16.3.1 => 16.4.0
react-dom: ^16.3.1 => 16.4.0
react-scripts: 1.1.4 => 1.1.4
Steps to Reproduce

Create a fresh CRA app
Follow the steps in the guide to set up a SASS pre-processor (https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#adding-a-css-preprocessor-sass-less-etc)
Rename the extension of App.css to App.scss
Run yarn start and you should see an App.css file is generated and the app loads as expected.
Stop the application
Delete App.css (as this will not be included in source control)
Run yarn test in the command line

I'm running the tests on a build agent, where the (generated CSS files) do not exist as they are not part of source control as prescribed in the user guide. Since they are not there when the tests are executed the tests complain about a missing module.
I'm not sure what to do here. I suppose I could try integrating SCSS directly into the react components with something like react-app-rewired (https://egghead.io/lessons/react-customize-create-react-app-cra-without-ejecting-using-react-app-rewired), but I would like to get to the bottom of what's the expected behaviour with CRA here.
Expected Behavior
I would expect all css imports to be mocked and run the tests successfully.
Actual Behavior
The test doesn't pass because a module of App.css could not be found. The exact output is as follows:
$ yarn test
yarn run v1.5.1
$ react-scripts test --env=jsdom
 FAIL  src\App.test.js
  ● Test suite failed to run

    Cannot find module './App.css' from 'App.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:179:17)
      at Object.<anonymous> (src/App.js:3:1)

Reproducible Demo
https://github.com/prabuw/cra-mock-css-test-fail

Delete App.css (as this will not be included in source control)
Run yarn test in the command line

That sounds like the problem? I think the module mapping works if that module exists.
Can you delete the file after running tests?

I haven't really thought about this before. I guess maybe we don't need those modules to exist if they're mocked anyway? But then a test wouldn't catch a renamed or moved file.
It makes sense to me that you should do the CSS build as part of your CI process, and then run tests afterwards.

@gaearon I have run the tests while the file exists and it works fine. I can confirm that I am able to delete the file after running the tests.

So we can close this?

Yes, I'll include the step to generate the CSS prior to running the tests.


test(integration): withdrawing a fake L2 token

Codecov Report

Merging #20 (e2746b9) into develop (e8ea965) will increase coverage by 15.90%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop      #20       +/-   ##
============================================
+ Coverage    74.58%   90.48%   +15.90%
============================================
  Files           79       33       -46
  Lines         2554     1083     -1471
  Branches       401      151      -250
============================================
- Hits          1905      980      -925
+ Misses         649      103      -546

Flag
Coverage Δ

batch-submitter
?

contracts
90.48% <ø> (ø)

core-utils
?

data-transport-layer
?

message-relayer
?

sdk
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/message-relayer/src/relay-tx.ts

packages/core-utils/src/bn.ts

packages/core-utils/src/common/misc.ts

packages/core-utils/src/common/test-utils.ts

packages/sdk/src/utils/misc-utils.ts

packages/data-transport-layer/src/utils/index.ts

packages/batch-submitter/hardhat.config.ts

packages/data-transport-layer/src/utils/common.ts

packages/sdk/src/utils/coercion.ts

packages/core-utils/src/coders/index.ts

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8ea965...e2746b9. Read the comment docs.


Errors related to controller imports (main.go) when using dep

Hello,
please see details below.
Version: 0.18.0
Error:
ERROR 16:56:42  revel  build.go:146: src\git.xxx.com\project\sign\app\tmp\main.go:11:2: must be imported as github.com/revel/modules/static/app/controllers
src\git.xxx.com\project\sign\app\tmp\main.go:12:2: must be imported as github.com/revel/modules/testrunner/app
src\git.xxx.com\project\sign\app\tmp\main.go:13:2: must be imported as github.com/revel/modules/testrunner/app/controllers

Let me know if you need other informations.

Can you upload the line it is referencing in  src\git.xxx.com\project\sign\app\tmp\main.go:11:2 ?
Thanks


remove multiple startup

What's the purpose? I can't get this to work. See also #2511

@Eilon please review. What's the intention here.
Main needs the correct NS to call Startup
public static void Main(string[] args)
        {
            var host = new WebHostBuilder()
                .UseKestrel()
                .UseContentRoot(Directory.GetCurrentDirectory())
                .UseIISIntegration()
                .UseStartup<Startup>()
                .Build();

            host.Run();
        }```

I believe this behavior only works (worked?) if you didn't specify .UseStartup() or .UseStartup() in WebHostBuilder.

When I comment out  /.UseStartup<Startup>(), I get
500 Internal Server Error  No service for type 'Microsoft.AspNetCore.Hosting.IStartup' has been registered.

Ah, that must've changed since the betas, then.

@Tratcher can you comment on the behavior when there are multiple Startup classes, and which WebHostBuilder.UseStartupXYZ() method does what?

A long time ago there was a feature to scan assemblies for Startup if you didn't specify UseStartup. This was removed when we added UseStartup<T>

replaced by #2564


Problem with airmass plots?

Hi all,
First, thanks for making what seems like a really great tool. I'm looking forward to incorporating it in my research. With that, I'm trying to make an airmass plot but there seems to be some issue. See attached image,

I'm not sure why the lines continue vertically like they do and I'd prefer it if they didn't. Is there something wrong with how I'm setting up this plot that could be causing that?
keck = Observer.at_site('keck')
# Times need to be in UTC
start_time = Time('2016-04-04 05:00:00')
end_time = Time('2016-04-04 16:00:00')
delta_t = end_time - start_time
observe_time = start_time + delta_t*np.linspace(0, 1, 75)

coordinates = SkyCoord('03h40m11.904s', '-18d34m49.36s', frame='icrs')
obj1 = FixedTarget(coord=coordinates)

coordinates = SkyCoord('08h54m27.067s', '-03d04m01.56s', frame='icrs')
obj2 = FixedTarget(coord=coordinates)

plot_airmass(obj1, keck, observe_time)
plot_airmass(obj2, keck, observe_time)
plt.show()
~

@AlexaVillaume - Which version of astroplan do you use?
This was an issue fixed after the 0.1 release was made. So if you're using 0.1 and prefer not to have the vertical lines (it's a bug, the vertical lines appear when the target is below the horizon), I would suggest to install the current development version.

@bsipocz - Thank you for your reply. I was using version 0.1. I have now switched to the developer version and the vertical lines are gone.

Hi @AlexaVillaume! I also fixed the incomplete x-axis label in that update.
Please let us know if we can improve anywhere else! In the mean time, I think this issue has been addressed.


Initial set of helper scripts

We should create some helper-script to abstract some common tasks

[x] Start / Stop
[x] Create a new Plugin
[x] Create a new Theme
[x] Reset Database
[x] rake command
[x] Nuke the installation
delete everything possible to recreate a known-good state

Those are basic scripts to get you started. We can create more powerful scripts with a better UX later.

We have all the mentioned commands.
Create separate issues to improve the command, because some of them are very crud and could use some UX improvements.


HellFreezesOverError: Socket for user xxxxx is not connected or does not have a session ID yet

Bug Report
There's 2 bugs I want to report, and I think they are related:

When calling .stop() on an EventSubWsListener immediately after .start(), the library does not honor the .stop() call and attempts retrying opening the connection
After the the above finishes connecting, the HellFreezesOver error occurs. The connection seems to be dropped shortly after. No logs of this exit are shown

Code
Code Sandbox
Not sure how familiar you are with React, but what's happening here is that the function inside the useEffect is being called immediately when the application starts, then the returned callback (the one with .stop()) is invoked, then first callback is invoked a second time.

Expected behavior
What should happen in the ideal world would be:

First connection starts being established
Gets aborted
A second connection is started

When invoking .stop() on a connection, the library should not attempt performing any sort of retrying, even if the connection has not been started yet. Not sure about the HellFreezesOver part, but I'm guessing that fixing the first issue should naturally lead to the second one never happening

Actual Behavior

Invoking .stop() is not honored if it happens before the connection is established
HellFreezesOver is being thrown

Environment

Version: 5.3.4 and 6.0.0
Node version: 18
Browser version: Chrome
Operating system: MacOS

Dunno about the sandbox environment but you should be able to inspect that one

I would also like to point out I see similar issues with .stop() not being honored in the ChatClient. Hopefully solving this for one of the libraries fixes it for the rest of them

I would also like to point out I see similar issues with .stop() not being honored in the ChatClient. Hopefully solving this for one of the libraries fixes it for the rest of them

Could you maybe create a separate issue with a separate reproduction case for this?

I just published the package<EMAIL_ADDRESS>which should fix this issue. You should be able to upgrade to this using a full upgrade, or if you don't want to do that, removing that specific package from your lock file and running your package manager's install command. I will not push just a dependency update as a new version.
Please confirm whether it worked for you. It could also fix the issue in @twurple/chat, although I have not tested that at all.

Thanks for the quick response! Upgrading to<EMAIL_ADDRESS>fixed the issue for both the ChatClient and EventSubWS


fixed find-open-source-project broken link�🔗

closes #3020
What does this PR do?
This fixed the broken link in the README.md file present in the support section
Description of the task to be completed?
Yes
How can this be manually tested?
Any background context you want to provide?
Is there any relevant issue to this PR?
Screenshots (if appropriate)
Questions

I would consider making the links relativ


To improve the Contact page

Here the details are at the bottom of the page and it is not in proper font I can fix that detailing in the project.

already issue raised


sym.entry.scalaSig.hasEntry(idx) check in metacp

This check (https://github.com/scalameta/scalameta/blob/49fde66004b997df8140c722e7637a50e32115df/semanticdb/metacp/src/main/scala/scala/meta/internal/metacp/Main.scala#L172-L180) was introduced as a stop-gap measure to unblock large-scale metacp tests. We should get back to it to see why it's needed and whether it's a principled enough fix.

This is no longer relevant in the latest master.


Feat: add rolling release to kruise-rollout

Signed-off-by: Yin Da<EMAIL_ADDRESS>
Description of your changes

How has this code been tested?

Checklist

I have:

[ ] Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
[ ] Updated/Added any relevant documentation and examples.
[ ] New addon should be put in experimental.
[ ] Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules
If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

[ ] This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
This addon must have some basic but necessary information.

[ ] An accessible icon url and source url defined in addon's metadata.yaml.
[ ] A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
[ ] Also provide an introduction in KubeVela documentation.
[ ] It's more likely to be accepted if useful examples provided in example dir.

Close as moved to #648


New Item submit form does not change associated collection if picked from admin side bar

can be reproduced on demo site : https://dspace7-demo.atmire.com/

Log in and open New Item form
While in this form, pick from sidebar New/Item
Select a different collection from pop-up
Nothing visually noticeable happens to New Item form - associated collection does not get changed

Expected that the action would have the collection change or would not be available at this point.

@Aziris : I'm not sure I understand this ticket.  I've tried the steps you described, creating a new Item by selecting a collection from the popup.  After selecting a collection, I see the submission form load & it shows that selected Collection at the top of the submission form (in the "Collection" field).
So, I'm not seeing any bug based on the steps you've described.  But, maybe I'm misunderstanding the steps?

Here I will describe the steps that I take with some pictures.

Open new Item page

Still in new Item form click sidebar "new Item" option again:

Pick different collection this time (Brasil/Collecion)

Nothing changes, no messages

Possibly after such a step a new "new Item" page could be presented with picked Collection. Another possibility this "new Item" feature could be disabled while in this page.

Thanks for clarifying @MarisArins .
I can reproduce this after all by doing:

Login as a submitter
Select New -> Item & choose a collection.  I go to the submission form for that collection
Select New -> Item again & choose a different collection.  Nothing happens...I remain on the submission form for the original Collection.

To me, this is a lower-priority bug/usability issue.  It seems unlikely many users would try to do this, as it's much easier to simply change the collection using the "Collection" dropdown on the submission form.  So, I'm tentatively scheduling this for fixing in 7.2

Stumbled on this old ticket. Re-tested today on demo7.dspace.org and it's no longer reproducible.  It appears this was fixed in 7.0


remove errant ` in git clone call

oh - hah!  Thanks @eljhkrr  - but I guess you and I don't have write access so the approval doesn't allow me to merge.  I'll see who does :eye:


Publishing update

relates to #81

we'll have to experience the pain I think, whatever

mostly fine, concurrency of this is shitty, I think packages-${{ github.ref }} is wrong and will cause issues because it's limited to branch/tag

I've addressed this by changing to fixed group name, let's see if this works for us.


feat(threat): add Count method

IMPORTANT: Please do not create a PR without creating an issue first!
(Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request).
Summary

Explains the information and/or motivation for making this changes...
Proposed of changes
This PR fixes/implements the following bugs/features:

Bug 1
Bug 2
Feature 1
Feature 2
Breaking changes

How has this been tested?
Proof:

Closing issues
Fixes #
Checklist:

[x] My code follows the code style of this project.
[x] My changes successfully ran and pass linters locally (run make lint).
[x] I have written new tests for my changes.

[x] My changes successfully ran and pass tests locally.

[x] My change requires a change to the documentation.

[x] I have updated the documentation accordingly.

Codecov Report
Patch coverage: 85.71% and project coverage change: -0.68% :warning:

Comparison is base (d700f3b) 79.88% compared to head (25df0d0) 79.20%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   79.88%   79.20%   -0.68%
==========================================
  Files           5        5
  Lines        1059     1034      -25
==========================================
- Hits          846      819      -27
  Misses        162      162
- Partials       51       53       +2

Files Changed
Coverage Δ

teler.go
78.17% <75.00%> (-2.03%)
:arrow_down:

analyze.go
74.84% <100.00%> (+0.06%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remove v4 constraint for MVP

Removes v4 constraint for the MVP launch, per a decision late on Tuesday (Oct 31, 2023).

Removes v4 datasets from hasConstraint to have the frontend not render the table constraint table for v4
Removes references to v4 constraint in help/faq text
Removes v4 constraint section from downloads page

In addition, the genes pipeline has been re-run, and outputs were written to a new bucket (genes_no_constraint_20231031T224855, I tried to followed the convention as best I could figure). The indices have been loaded into the v4 elasticsearch, all that is left to do is change the aliases to point to the new indices after this PR is merged.
The new indices are (these are on the v4 elasticsearch cluster)

genes_grch38-2023-11-01--03-17
transcripts_grch38-2023-11-01--03-19

The old indices were (these still exist on the v4 elasticsearch cluster)

genes_grch38-2023-10-29--23-36
transcripts_grch38-2023-10-29--23-38

I'm happy to update these indices after these get merged. The only detrimental thing that will happen with the currently deployed demo is that (once the nginx cache has been cleared) the v4 gene and constraint pages will render the warning that reads something like "constraint not available for this gene" rather than "constraint not available for v4.0.0")

Sorry Riley I meant to open a new PR with my change but accidentally pushed the commit to your branch.
The snapshot tests are failing with even when I run yarn jest -u.
Message: Invariant failed: You should not use <withRouter() /> outside a <Router>

Changing the <Link/> to an <a/> enables tests to pass, so it's something to do with <Link/> being added to this component. Unfortunately then we lose link styles. There's something about the test config I'm not understanding.

Changing the <Link/> to an <a/> enables tests to pass, so it's something to do with <Link/> being added to this component. Unfortunately then we lose link styles. There's something about the test config I'm not understanding.

Interesting, yeah I'm not seeing where the router is being used in a router either, will poke around for a tiny bit and if it doesn't go just change it to an  tag and re-create the styles like you said?


Custom SVGs / images

Hi
Thanks for this lib!
I am using the React package in a Gatsby application and wondering how could I customize that message icon when using in the Popover component. This is what I have now:
      <Popover
        buttonColor="#26254D"
        height={500}
        hidden={metadata}
        id="MY-ID"
        chat
        onReady={() => {
          console.log('form ready');
        }}
      >
        Help
      </Popover>

I see that can customize the color but there is no good way to replace the message icon. If we had a onLoad event we could potentially manipulate the DOM and replace the SVG but I wonder if you plan to allow customizations of the Popover.
Thanks

Hello @leonardofaria. I am afraid we forgot to document this part 😃  You can pass image URL in a prop called customIcon.
Like this:
<Popover
  id="<form-id>"
  customIcon="<image-url>"
/>

We will update the documentation soon and then we can close this issue.

Hi!
Thanks for letting me know :)
I will use customIcon


Write docker-compose file

[x]  Jenkins with Filebeat

[x] Elasticsearch

[x] Logstash

[x] Kibana


Add bal build -c filter for no-source package

Purpose
bal build - not allowed
bal build with compiler plugins - not allowed
bal build -c without compiler plugins - not allowed
bal build -c with compiler plugins - allowed
Fixes #30684
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Build and Compile Tests :

[ ] Empty project with Compiler plugin
[ ] Project with tests only
[ ] Non-default modules source only
[ ] Non-default tests only
[ ] Empty non-default module


plugin wont work. i'm tring use real seneca and it's worked fine.

so please try to fix it.  cose some of the people will frustrate about that

Hi @dima1034,
could you please give some more info about what's not working and the error that you got?

as I mentioned before with regular seneca everything works pretty well.

Hi @dima1034. Which Seneca version are you using?
Can you please paste here your solution so we can check?

http://dropmefiles.com/qPJhz


lists in wysiwyg

now that we use quill, which has support for better newline handling, we should be able to support lists!

ordered and unordered
needs passthrough styling
remove pseudoBullet argument
update html cleaner so they don't get parsed out

lists are supported in multi-line wysiwyg in commit 69f1873 (which also adds support for sup/sub everywhere). We're keeping the pseudo-bullet because implementing lists will require a new list component with multi-line wysiwyg


BLE Commissioning Issue in Chip-Tool (CON-568)

Logs of Chip-Tool
logs.txt

Looks like the chip-tool cannot resolve the address of the operational node. Is the device a Thread device or Wi-Fi device? Is the device(or the Thread BR) in the same local network with the chip-tool?

We are using Open Thread Border Router in Raspberry PI and the devices are thread devices and they are connected to my company's Wi-Fi.

So, you are pairing the thread device, maybe this commands could help you
sudo sysctl -w net.ipv6.conf.enp2s0.accept_ra=2
sudo sysctl -w net.ipv6.conf.enp2s0.accept_ra_rt_info_max_plen=128
sudo sysctl -w net.ipv6.conf.all.forwarding=1

Note: Please replace the enp2s0 with your network interface name

Yes, we are pairing the threading device.
At which place I have to run above commands that you given.

You should run these commands on the chip-tool terminal before you pair the device with chip-tool.

yes, @wqx6 I applied the steps you gave but still not changes anything in the outcome.
Still, as earlier, same BLE Commissioning issues I got.

Is the backbone netif of the OTBR connected to the same local network of the chip-tool? could you please provide the log from the OTBR and the device? The log shows that the chip-tool cannot resolve the address of the thread device. The reason might be that the device fails to register SRP service on the SRP server of the BR.

Yes, OTBR is connected to the same local network as the Chip Tool.
Chip Tool Logs using Latest Version of Chip-Tool.txt
Chip Tool Logs.txt

Could you please provide us the thread device-log?
Also I notice that the chip-tool are using the minimal mDNS, you can rebuild the chip-tool with the platform mDNS.
cd connectedhomeip/examples/chip-tool
gn gen out --args='chip_mdns="platform" chip_inet_config_enable_ipv4=false'
ninja -C out

@varshilglide Please provide the requested information or close the issue if it is resolved

Okay Thanks