Not prompted for API Key

When published to a Dynamics 365 CRM Environment for use with 'embedded' flow, it does not prompt for the API Key but instead seems intent on trying to use OAuth 😟

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fb743ac5-5429-b45d-9623-3140b304669b
Version Independent ID: 2b8fc604-63b0-7ea5-0c75-450f21056e9b
Content: Call a function from PowerApps
Content Source: articles/azure-functions/functions-powerapps-scenario.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@paulhasell
I have tried creating a the same connector as described in this tutorial and was able to create the custom connector successfully and was also being prompted for the API Key when trying to use it in flow.

I did face one issue when trying to import the function into PowerApps + Flow from Azure though

I noticed that without selecting anything in that dropdown and just providing a name did allow me to go forward. And I also tried going to PowerApps and add a Custom Connector by importing the OpenAPI definition had the same result.

Note that for it to work using the URL, you will have to add https://flow.microsoft.com to the CORS setting of your Function App

After that, everything else worked as expected. Maybe you could try recreating the custom connector this way and try again?

@paulhasell Just following up... Have you gotten a chance to try this out?

@PramodValavala-MSFT Ah, twas the awkward UI that confused me 😶 I have now successfully accessed my function app from inside my CRM hosted flow 🎉
Many thanks, this opens up some very interesting possibilities 😊

@paulhasell Glad to hear that! 😃
I will try to work with the appropriate team to get the UI fixed.


Export new Storylines products into JSON skeleton

When creating a new Storylines product, export the basic structure of a JSON into a new folder:
Create files/folders:

{UUID}

assets

en
fr

charts

en
fr

ramp-config

en
fr

{UUID}_en.json
{UUID}_fr.json

Will we need fancy permissions to accomplish this?

From the research I've been doing for the save feature, it looks like if we want to save products directly to the server's file system we'll need to set up some sort of backend API (like Express, for example) that handles the file creation and editing. Since Vue is a front-end framework it doesn't have the means of creating or editing files on the file system, so we'd need to have something running on the server side that the Vue app can send the files to.

Ryan has already PoC'd a zip creation function that could be deployed to the server.

Here's what I was able to do:

Created an express server that accepts a ZIP file via POST request and unzips it on the server filesystem

Included a few security features:

I have some code in the server to verify that the project name is in Storylines UUID format (xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx), but since the CWS product didn't use the UUID I've commented this out temporarily.
After unzipping the file, the server will check each file within to ensure that the file extension is one of the following: .json, .csv, .html, .md, .png, .gif, .jpeg, .jpg. All files that do not have one of these extensions will be deleted.
A small check to ensure that deleting files can't be manipulated into deleting Storylines project files (basically checks to see if a specific path is contained in the path being deleted, like the UUID for example).

Added axios to the Storylines project and hooked it up to the save button. When clicking the button, it generates the zip file and makes the POST request to the server.

The GIF below is an example of this in action. This server is running locally on my computer but as far as I'm aware, it should work on the server that we're using to host Storylines and we should be able to update the target path of this program to dump the extracted ZIP file into our public folder.
This express server needs to be always running in order to handle the POST requests, and I'm not very familiar with how to do that. If anyone is familiar with keeping a node server running feel free to comment here.


net: ethernet: Define and use Ethernet frame and datagram size

Remove magic numbers from Ethernet drivers and tests by defining
NET_ETH_MAX_DATAGRAM_SIZE and NET_ETH_MAX_FRAME_SIZE.

Codecov Report

Merging #14516 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #14516   +/-   ##
=======================================
  Coverage   51.99%   51.99%
=======================================
  Files         309      309
  Lines       45574    45574
  Branches    10555    10555
=======================================
  Hits        23695    23695
  Misses      17069    17069
  Partials     4810     4810

Impacted Files
Coverage Δ

drivers/ethernet/eth_native_posix.c
29.59% <ø> (ø)
:arrow_up:

include/net/ethernet.h
53.84% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d46a3...47c1ee6. Read the comment docs.


Hand off to a competent successor

Per Eric Raymond in The Cathedral and the Bazaar:

When you lose interest in a program, your last duty to it is to hand it off to a competent successor.

It seems to me that @tlvince has emerged as that successor. Or he's at least in the running against @RangerRick.
For a project like this, choosing a successor is especially important, because when you homestead the name angular-pouchdb at npm and bower, you hold the benefits of SEO as well as developer ergonomics. (npm install -S angular-pouchdb and  bower install -S angular-pouchdb are easy to remember.)
I'm happy to remain neutral in terms of which modules we promote on the PouchDB website (list them all!), but my personal opinion is that it's better to combine our efforts and rally behind a single solution. We seem to be there for Backbone and Ember, and I would really, really like to be there for Angular as well. :)
(It's worth adding that I am a shameless Angular fan – check out the code for npm-browser!)

 :-(
I deleted the project from bower and I'll solemnly swear never again to come up with a sensible name. From now on, I will name all my projects (&(HJHDS(&^U&^%*S$$$S with a suffix that is the current star date. Hopefully that will not conflict with anybody else's work. But please keep bashing me if there are other things you don't like.


Can you tag a new release for 5.7?

Thanks for the great work.

Thanks for your reminding, I've released v1.8.4.

Just wanted to say thank you! I was wondering why I couldn't update.

Hi @jastend ,
What do you mean couldn't update? Is there any error message?

@albertcht Think they meant, they wondered why they couldn't update before this new release.

Correct. It was just a thank you for the quick update. Everything works like a charm now.

Ok, I got it, no problem :)


GPG key invalid on repo | mi-fastboot doesn't install

apt output:
Hit:2 https://packages-cf.termux.dev/apt/termux-main stable InRelease
Err:1 https://rohitverma882.github.io termux InRelease
  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 98B41BFB7ED7F825
Reading package lists... Done
W: GPG error: https://rohitverma882.github.io termux InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 98B41BFB7ED7F825
E: The repository 'https://rohitverma882.github.io termux InRelease' is not signed.
N: Metadata integrity can't be verified, repository is disabled now.
N: Possible causes: unstable or tampered Internet connection, wrong sources.list, outdated keyring or host is down currently.
N: Please note that all hosting problems or other serious issues we announce on our social media pages.
N: Use termux-change-repo for switching to a mirror.
[...]```

Clear termux app data and try again

didn't work

Download deb-pkg and install mi-fastboot manually using command.
dpkg -i <deb-pkg-file>

it worked, thanks


hubble: Improve performance of identity getter

Profiling Hubble showed that the GetIdentity getter is responsible for
a lot of CPU time when Hubble is enabled, as it translates the internal
identity object into a API model. This stems from the fact that Hubble
used to fetch these identities via external API. However, these days
Hubble can directly access the identity allocator, thus making the
conversion unnecessary.
This PR removes the conversion step from the identity type to the model
and directly returns the identity type instead.
Reported-by: Michi Mutsuzaki<EMAIL_ADDRESS>Signed-off-by: Sebastian Wicki<EMAIL_ADDRESS>

/test

The failures in GKE and ci-l4lb are known flakes:

https://github.com/cilium/cilium/issues/17307
https://github.com/cilium/cilium/pull/19953 (re-basing it would likely fix it, but there is no Hubble in that test suite, so not sure what value it would bring)

All other pending workflows are disabled. Marking as ready to merge.

The failures in GKE and ci-l4lb are known flakes:

https://github.com/cilium/cilium/issues/17307
https://github.com/cilium/cilium/pull/19953 (re-basing it would likely fix it, but there is no Hubble in that test suite, so not sure what value it would bring)

All other pending workflows are disabled. Marking as ready to merge.


Start a proper documentation

How about mkdocs:)

Yeah, it's good enough to start with!

Did you start a branch with this?

No I just started to update mkdocs.yml and index, it is in in the branch add_ped_support


HHH-13443: Build failing to parse *.properties file attributes containing trailing space

My accidently putting "spring.jpa.hibernate.ddl-auto=update "(*note one trailing space!) in my application-dev.properties failing build, giving me: "Unrecognized legacy hibernate.hbm2ddl.auto value : update" whereas real message should be: "Unrecognized legacy hibernate.hbm2ddl.auto value : update " which may give us a clue we have malformed attributes/properties or we can have a trim before exception conclude

good idea, thanks! will merge soon.

Merged and applied the same principle in some more places.

Thank you Sanne :tada: !


New API to Fetch WhiteListed Domains for email

Jira Ticket : https://karmayogibharat.atlassian.net/browse/KB-5850


WIP: Fix fixed size arrays

Part of https://github.com/gtk-rs/gir/issues/880
Result of https://github.com/gtk-rs/gir/pull/881
cc @sdroege , @GuillaumeGomez
No other meaningful changes except for not included removal empty line in "Cargo.toml"s (as I remember @GuillaumeGomez don't add it to regen anyway).

I guess it's time for full regen @EPashkin ? :)

Almost, I missed warning https://github.com/gtk-rs/gir/pull/882

Updated.
Again without removal of empty line in Cargo.toml but this can cause CI fail

We'll check that later on. Thanks!


Bad link on Github

Hello,
I am currently running the Verge Windows Wallet 3.0 and have intentions of updating to the most recent Windows release. From what I have read it is my understanding that you cannot jump straight from 3.0 to 4.0.1 it is necessary to go from 3.0 to 4.0 to 4.0.1. Since that was my belief I attempted to download the Windows 4.0 release but the link took me to this:

I would be grateful for some help on this issue, and most notably answers to these questions:

Why am I getting this error message?
Was I right in thinking that you cannot jump straight from Wallet 3.0 to Wallet 4.0.1?
What are my options going forward?

Thanks in advance for your help,
Tom

where was this link? use this: https://github.com/vergecurrency/VERGE/releases/tag/4.0stealth
also, you should not be "running" 3.0, as you would be syncing past the fork block. youll probably want to download the chain again.

I encountered a similar bug.

Visiting https://vergecurrency.com/langs/de/#wallets
Smartphone => Download Verge Android Wallet
This links to https://github.com/vergecurrency/VERGE/releases/download/2.1/vergetorandroid.apk
which redirects here and prints the following error:

Justin I followed your link and this worked. I also downloaded the blockchain again and the new wallet synced up no problem. Thank you very much for your help.
Martin - if you follow Justin's link you should be good.
Justin - to answer your original question, the bug came from this link:
https://github.com/vergecurrency/VERGE/releases - the link was under the 'Wraith Release 2' category. I never noticed this until just now it is not entitled 'Wraith Release 2' with a capital 'W' but rather 'VVraith Release 2' with two capitals 'V's. Can I trust the links from a github that cannot get its spelling correct? Justin I recommend you take a look into this in case there is something untoward going on.
Thank you again,
Tom

Why so serious?  it's 2 Vs.  2 V's together look like a W.  Laugh a little in life.

it's for
a e s t h e t i c
purposes.

and also, good, I'm glad the old wallet binary isn't available, as we don't want people downloading it!

Justin thanks for your help earlier, much appreciated.

@martinloeper thanks for bringing the Android link to my attention. I need to make it available on github again for users that don't have access to Google play store. leaving this open until I upload it here in the morning.

@justinvforvendetta please do this.  It needs also to have the electrum servers updated, a way to change the servers from settings, and a safeguard so it won't give receiving addresses unless a connection is made.  There's issues with the new orbot, so a clearnet options would be good as well.

we definitely won't be offering a clearnet option, and I've already confirmed with several people (even in mainland china) that the new orbot works just fine.
what do you mean 4.0.1 wasn't a signed commit so it's not showing up as verified?

It wasn't built from a signed commit, so not verified.  Seems like commits made from web interface are signed, but maybe not ones made with git.


Crash debugging Vulkan applications built with SDK 1.0.8

I recently installed and updated a project of mine to use the 1.0.8 LunarG SDK for Vulkan and I can no longer properly debug with Renderdoc. I can debug the same application on 1.0.5 but not the latest.
I'm using a GTX 780 with Driver version 364.91 on Windows 10. Renderdoc is the absolute latest; I built it from source just a few minutes before writing this.
The crash happens with my application, Hatchit as well as any of the examples from Sascha Willems but ONLY when Validation is enabled. If you take any example from Sascha Willems and turn on validation it will break. If you leave validation off this repro will not cause a crash.
The repro is simple:

Attempt to capture any executable using the 1.0.8 SDK that has validation enabled
Capture a frame
Load the log
Go to the texture viewer
RenderDoc immediately crashes

Running RenderDoc in debug mode the crash happens at line 1212 of vk_replay.cpp with the error:
Exception thrown at 0x00007FF9F7C42F6C (VkLayer_core_validation.dll) in renderdocui.exe: 0xC0000005: Access violation reading location 0x0000000000000000.

Here is a picture of the callstack:

The new errors I get in my app and with Sascha Willem's examples with the 1.0.8 SDK are:
ERROR: [SC] Code 15 : Shader requires VkPhysicalDeviceFeatures::shaderClipDistance but is not enabled on the device
ERROR: [SC] Code 15 : Shader requires VkPhysicalDeviceFeatures::shaderCullDistance but is not enabled on the device

Which I haven't found any solution for an which only show up on the Nvidia 364.91 driver. (I don't think AMD has a 1.0.8 compliant driver anyway). The cullDistance error goes away when using a shader version below #version 450 but the clipDistance error shows up on every shader I've written.
The validation layer names changed with 1.0.8. Could this have something to do with it?

The crash lies in the validation layers, not in renderdoc - I think this case is one I've seen before, it's because of something I'm doing that's not spec valid and the validation layers trip up and hit a NULL pointer.
I've been meaning to fix it for a while, which should hopefully sort the issue, but in the meantime disabling validation while capturing renderdoc should work as a workaround.
As to the cullDistance/clipDistance errors - I'm not quite clear on what you're getting at. Are you saying that you only get these errors when running with renderdoc?

I get the clip/cull errors with everything but they were new with 1.0.8 so I wasn't sure if they were relevant.

Ah right. No I think they were just a new check added in 1.0.8. I found that just removing those declarations from gl_PerVertex did the trick - b630b84e2026e8169bc0d84ad0ae067f969c8859

Oh yep that did it. Thanks. But yeah it looks like those errors were unrelated to the crash anyway.

Honeybunch: The ".8" part defines a patch number, which technically means that any changes made at this level are backward-compatible and should not affect applications. All in all, this means there's no such thing as 1.0.8-compliancy (for the lack of better wording ..). This has been made clear in the latest spec version (https://www.khronos.org/registry/vulkan/specs/1.0/xhtml/vkspec.html )
Just thought I'd chime in and clarify.

Oh, by the way - you may want to consider building the layers yourself (https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers ) and checking where the crash is coming from. If this turns out to be a problem with the validation layer, it would be much appreciated if you could report the error to the team by creating an issue there.

If it's the crash I'm thinking of, it's because the texture display shader declares 12 different samplers and samples from only one via dynamic branching. I'm only updating the one relevant descriptor - the others are uninitialised. The validation layers definitely crashed out on that at some point, but I think on latest master branch they're working and giving an explicit error for this case.
As I mentioned above, I've been dragging my heels on fixing it since it means creating a dozen different dummy minimum-sized textures and updating them constantly into the descriptors that will never be read. It's been lower priority since it's not actually a problem on any of the platforms I've tested. It's still spec invalid though so I need to fix it.

@DominikWitczakAMD Thanks for the clarification.

Just tested it and it works fine. Thanks so much!


Stop ampersands on HTML entities when parser.decodeEntities = false

Addresses https://github.com/punkave/sanitize-html/issues/249

Can't this be used to sneak in entity escapes when typing in a rich text editor, for instance? That doesn't sound like desirable behavior.

I'm not sure, however, where the bc break is if it's optional.

@boutell Is the updated PR OK?

Merged, thanks.

Thank you @boutell

@boutell Is it you I need to ask nicely to tag the 1.18.5 release and publish to NPM?

Yep. Published. (You might not see it right away, npm is lagging behind lately in showing package updates to the world.)

That's great, thanks @boutell


Parens not added when joining on CTE

I tried out Ecto 3, a test in the app failed on a join with a Common Table Expression. When joining on a CTE, parens were not added, triggering an error from mariadb

** (Mariaex.Error) (1064): You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'bogus AS (SELECT ? as temp) SELECT temp as post_id FROM bogus AS f1 ON f1.`post_' at line 1

This used to work on Ecto 2. See this PR for a reproduction.
I've added a possible fix by adding parens when the join expressions starts with the words with or WITH.
Of course this can also be fixed by adding the parens around the CTE like
fragment("(WITH bogus AS (SELECT ? as temp) SELECT temp as post_id FROM bogus)", ^p1_id)

The mysql test fails on mysql 5.6 not supporting CTE's. Mariadb does since 10.2

@maartenvanvliet thanks! I will add a note to the changelog. The issue is that some operations did not like the automatic parens. I think it is best to push this concern to users rather than try to guess when we should add parens or  not.


Clean up git parsing code

Right now we're just doing string comparisons on incoming messages, we should actually 'understand' these commands and acknowledge git client capabilities etc..

Much better as of recently


I start optifine version 17.1 and after 2 sec of starting it crashes without an error code

Describe the bug
A clear and concise description of what the bug is.
Desktop (please complete the following information):
OS & version [e.g. Windows 10, 1822]:
MSFT Build of OpenJDK Version:
The output from java --version
To Reproduce:
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots, Logs etc
If applicable, add screenshots, logs to help explain your problem.
Additional context
Add any other context about the problem here.

@Grimmzjr I assume this is whilst playing Minecraft?

no while starting
Am Fr., 12. Nov. 2021 um 17:23 Uhr schrieb Martijn Verburg <
@.***>:

@Grimmzjr https://github.com/Grimmzjr I assume this is whilst playing
Minecraft?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/openjdk/issues/164#issuecomment-967242635,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASRRN4XYXQKAAKE2QTZXEDDULU5ONANCNFSM5H5DLLVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

no while starting Am Fr., 12. Nov. 2021 um 17:23 Uhr schrieb Martijn Verburg < @.***>:
…
@Grimmzjr https://github.com/Grimmzjr I assume this is whilst playing Minecraft? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#164 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASRRN4XYXQKAAKE2QTZXEDDULU5ONANCNFSM5H5DLLVA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

while starting Minecraft?

Correct
Am Mo., 15. Nov. 2021 um 15:17 Uhr schrieb Martijn Verburg <
@.***>:

no while starting Am Fr., 12. Nov. 2021 um 17:23 Uhr schrieb Martijn
Verburg < @.***>:
… <#m_-2398693359774943736_>
@Grimmzjr https://github.com/Grimmzjr https://github.com/Grimmzjr I
assume this is whilst playing Minecraft? — You are receiving this because
you were mentioned. Reply to this email directly, view it on GitHub <#164
(comment)
https://github.com/microsoft/openjdk/issues/164#issuecomment-967242635>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASRRN4XYXQKAAKE2QTZXEDDULU5ONANCNFSM5H5DLLVA
. Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
.
while starting Minecraft?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/openjdk/issues/164#issuecomment-968954189,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASRRN4RMA4JBTMZRW24SUMDUMEI7LANCNFSM5H5DLLVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

See https://github.com/microsoft/openjdk/issues/67 - we don't support Optifine and mod'd installers.


some scrot issue

Hi!
When i use pyautogui.pixel(p.x, p.y), besides the return of colour values, it throws and error: scrot - invalid option --z passed.
I use the latest available scrot (0.8.0) with python 3.7.3.
pyautogui installed via pip3

As I understand - the issue is buried much deeper than in pyautogui, so I close it.

As I understand - the issue is buried much deeper than in pyautogui, so I close it.


Resilience in dask-mpi

Hi!
I've been reading through the docs, but I'm still a bit unsure about whether the resilience/fault tolerance in dask-distributed in maintained in dask-mpi.
As I understood it, MPI is only used to discover nodes and not for communication, but would the fact that the execution has been launched with MPI in the first place imply that it will collapse in case a node fails?
Carlos

I guess that a worker which dies and takes its MPI process with it will bring down the MPI cluster. A simple test would be to submit something that terminates the worker it's living on:
def kill_my_worker_process():
    os.kill(os.getpid(), 15)

But you'll probably be able to handle problems caught by the nanny processes (like exceeding memory limits).

Yes, that seems to bring down the whole MPI cluster.
Thanks!


C:\Windows\System32\Data

Why is this defaulting as my settings folder for preferences?

Where are you launching the program from? Make sure it's a folder with sufficient permissions (don't put it in an administrator folder for instance).


Crudmaker : Avoid using snake case when generating from table

Hi,
I'm trying to do some CRUD generations from an existing database but I'm facing a problem.
I have a table called "helicopter_types" but I don't want to generate App\Models\Helicopter\Type but App\Models\HelicopterType
And same for controllers/services/etc...
Is there any way to do that?
Thanks

If you use CamelCase it should work fine App\Services\HelicopterTypeService etc will be generated and the table base of helicopter_types

@mlantz There is a consitency issue on this then because if I use CamelCase with crudmaker:table it's looking for a table with the CamelCased name but actually generation Models/routes/... with snake_case names.
So my workaround for now is to rename the table with camelcase then use the crudmaker:table command, then rename the table back to snake_case

I'll review this to ensure consistency. Thanks.


fix: Entity Explorer test case

Description
Fix test case failing because of changes in https://github.com/appsmithorg/appsmith/pull/21789

Fix failing test case

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

Manual
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test

/ok-to-test

/ok-to-test


Theia IDE Rebrand and Theia 1.45.0

What it does

Rebrand Theia Blueprint as Theia IDE
Update to Theia 1.45.0
Fix Javascript Debugging

Contributed on behalf of STMicroelectronics
How to test

build the application and check everything is still working
Check welcome page, etc to see if there are places where the Blueprint->IDE rename is missing

Review checklist

[x] as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

Maybe you should link the javascriopt debugging bug in the description?


Cordova plugins

While refactoring my app from Cordova to Libgdx, I'm having a hard time finding an exhaustive Firebase implementation, specifically for FCM.
https://github.com/mk-5/gdx-fireapp seems to be the most complete, but it's still in active development. For Cordova, I was using https://github.com/arnesson/cordova-plugin-firebase which has all the functionality I need.
This lead to my thinking of somehow creating a bridge between Libgdx and Cordova plugins. As far as I can tell, being standalone, they only need an application context so some kind of intermediate class that provides this context alongside an interface to libgdx might be enough to get them to work.
What do you guys think of this and is this even possible, considering the IOS counterparts of Cordova plugins are written in Objective-C instead of Java?
I think this would allow for a lot of extra features to libgdx apps as there are tons of plugins already, for different platforms: https://cordova.apache.org/plugins/
Please select the affected platforms

[x] Android
[x] iOS (robovm)
[x] iOS (MOE)
[x] HTML/GWT
[x] Windows
[ ] Linux
[x] MacOS

better using firebase REST API, libgdx provides all you need to call any REST API.

I am using the REST API to send notifications from my server, however on the client this plugin leverages the Firebase SDK to handle the incoming notifications, adding them to the notification bar, controlling the led, updating icon badges, etc.

Not something this project will take on, and is more fit for an external extension if someone wanted to.
Typically you create cross platform compatible libraries, such as the one you linked, either outside of your project as some library, or inside as cross platform compatible code via interfaces as demonstrated in simple case here https://github.com/libgdx/libgdx/wiki/Interfacing-with-platform-specific-code.


Extending 'aad app add' command with admin consent process

Extends aad app add command to support admin consent

Closes #2563

Thanks for your contribution @michaelmaillot 👏, we'll review this asap!

Hi @michaelmaillot, I'm seeing a lot of files changed. It seems to me that can't possibly be correct. I didn't look at the branch line as I'm on holiday, but I think something needs to be done here before we can review.

Is this because I've synced my fork and rebase to main before pushing?
Sorry I've missed something but can't find out what, since it's a forked repo.

Looks much better like this 🍻

@martinlingstuyl do you think you could do an additional review on this one 🙏
from me it's ready to be merged (with a small fix along the way I will do) but I would like to double check this one with you if you don't mind 😊

Hi @Adam-it, I can review the code, but I do not have a pc with me (on holiday) so I can't try it out. I assume that's okay, as you have confirmed it works as expected. I can see if I can find some things just by looking at it line by line. That okay for you?

Hi @Adam-it, I can review the code, but I do not have a pc with me (on holiday) so I can't try it out. I assume that's okay, as you have confirmed it works as expected. I can see if I can find some things just by looking at it line by line. That okay for you?

totally

Hi @michaelmaillot, @Adam-it, I've left some comments and considerations.👍

great 🤩 Thanks @martinlingstuyl for the double check 👍👍👍. I didn't feel confident enough in merging this  😊 and I suppose the things you pointed out are good comments
@michaelmaillot do you think you could have a look at them ?

👍 It's all from my phone from holidays @michaelmaillot, some things might be easily answered and resolved. 😌

Thanks for your additional feedback @martinlingstuyl!
I'll update my code accordingly.

@michaelmaillot thanks for you amazing work 🤩. I will try to review it asap and align to our latest approach with commands which was refactored 👍

recreated this change in separate PR #3578


HarmBlockThreshold.BLOCK_NONE breaks embeddings creation

When running python env_setup.py (either v1 or v2), the flow stops due to the following error:

google.api_core.exceptions.InvalidArgument: 400 User has requested a restricted HarmBlockThreshold setting BLOCK_NONE. You can get access either (a) through an allowlist via your Google account team, or (b) by switching your account type to monthly invoiced billing via this instruction: https://cloud.google.com/billing/docs/how-to/invoiced-billing.

This can be resolved by setting HarmBlockThreshold.BLOCK_MEDIUM_AND_ABOVE but should either be avoided or allow to be configured.
Thanks.

Adding an example for such an exception during the embeddings creation flow:

"File \"/.../lib/python3.11/site-packages/vertexai/generative_models/_generative_models.py\", line 1977, in text",
"    1974  @property",
"    1975  def text(self) -> str:",
"    1976      try:",
"--> 1977          return self.content.text",
"    1978      except (ValueError, AttributeError) as e:",
"    ..................................................",
"     self = finish_reason: SAFETY",
"            safety_ratings {",
"              category: HARM_CATEGORY_HATE_SPEECH",
"              probability: NEGLIGIBLE",
"              probability_score: 0.124023438",
"              severity: HARM_SEVERITY_NEGLIGIBLE",
"              severity_score: 0.15234375",
"            }",
"            safety_ratings {",
"              category: HARM_CATEGORY_DANGEROUS_CONTENT",
"              probability: HIGH",
"              blocked: true",
"              probability_score: 0.87890625",
"              severity: HARM_SEVERITY_LOW",
"              severity_score: 0.3046875",
"            }",
"            safety_ratings {",
"              category: HARM_CATEGORY_HARASSMENT",
"              probability: NEGLIGIBLE",
"              probability_score: 0.1621...",
"     self.content.text = # ValueError",
"          self.content = ",

The content of the tables far from being harmful or dangerous.

This should be resolved, as safety filters should be unblocked by default as of now. @rafi-rr can you verify?

@5Y5TEM Still not resolved in v2.0.0
Happened again in a new project that doesn't have the security filters disabled.
It fails during initialization with "InvalidArgument: 400 User has requested a restricted HarmBlockThreshold setting BLOCK_NONE."
I'm using gemini-1.5-pro


The child component cannot inherit validators defined in its parent.

Suppose we have a base Vue like the following
var base = new Vue({
  el: "#app",
  ...
  validator: {
    validates: {
      "username": require("./validator/username.js")
    }
  }
 components: {
   "my-component":  require("./my-component.vue")
 }
});

and the child component is defined as follows:
<template>
  <input name="username" class="form-control" v-model="username"
             v-validate="required, username">
</template>
<script>
module.exports = {
  replace: true,
  inherit: true,
  data: function() {
    return  { username: "" };
  }
};
</script>

It seems that the child component cannot inherit validators defined in its parent.

this issue is related with https://github.com/vuejs/vue-validator/issues/55

I fixed this issue, and readied for the release of v1 latest version.
You can check behavior in  the following jsfiddle.
https://jsfiddle.net/kazupon/kdye3gv5/3/
In order to release, we need to release of vue.js 0.12 latest version.
Please wait. :)

I published vue-validator latest version.
Please check it! :smiley:


\lq and \rq commands don't work

Issue Summary
The commands for left and right quote (\lq and \rq, respectively) do not work in MathJax.  I observed this both on a site which used MathJax (GitHub markdown) and on https://www.mathjax.org/#demo.
Steps to Reproduce:

Try $\lq $ or $\rq $ using MathJax
Alternatively, view what happens with MathJax in GitHub markdown: $\lq$ or $\rq$

Technical details:

MathJax Version: 3.2.2
Client OS: Windows 10
Browser: Brave 1.59.124 [Chromium: 118.0.5993.117 (Official Build)  (64-bit)]

I am using the following MathJax configuration:
N/A (demo)
and loading MathJax via
N/A (demo)
Supporting information:

https://www.mathjax.org/#demo
no console errors

The \lq and \rq macros are generally considered to be text-mode macros, and MathJax doesn't implement those.  That's why they are appearing in red (which means an undefined macro).
You can, of course define them yourself.  For example
\newcommand{\lq}{\unicode{x2018}}
\newcommand{\rq}{'}

would get you the equivalent of how LaTeX would treat these two.  If you want an actual right quotation mark (’), then you could do
\newcommand{\lq}{\unicode{x2018}}
\newcommand{\rq}{\unicode{x2019}}

instead.  You could define these in your MathJax configuration using
MathJax = {
  tex: {
    macros: {
      lq: '\\unicode{x2018}',
      rq: '\''
    }
  }
};

for example.

@dpvc that makes sense; thank you for the quick response!  Since this is expected behavior, I'll close the issue.


Made available the full response object in addition to the original a…

Warning
The callback payload interface has changed.
Before
{
  "street_number": "...",
  "route": "...",
  "locality": "...",
  "administrative_area_level_1": "...",
  "country": "...",
  "postal_code": "..."
}

Now
{
  place: {
      "street_number": "...",
      "route": "...t",
      "locality": "...",
      "administrative_area_level_1": "...",
     "country": "...",
     "postal_code": "..."
   },
   response: { ... the original Google Autocomplete response ... }
}

Changes

Made available the full response object in addition to the original address information already available in the callback
Added the possibility to pass in the configs for the Autocomplete API
Updated the doc to reflect those changes

Hey, thanks for the contribution.
Do you mind write some tests? I know, this repository does not have any, but I would like to see how this change works.
It seems pretty neat, but would like to test.
Let me know, otherwise, I ll try to do it myself and merge the changes,
Thanks

Ok! I'll try to do that. Do you have a preference on the test framework? I not too familliar with the JavaScript ones. Any leads on that would help me out.

Hey mate, take a look at the one I use for vuemit 👊🏻💪🏻
Just let me know if help is needed,i will be more than glad to help yoi out.

Otherwise, I can try this on sunday, make the test and merge your pr ;)

Ok, I'll have a look into vuemit's testing framework

Hey, I am ready to merge this. I already tested the code locally. I have a question in regard to response
Why do you need this for? What is the different between it and address?
I left comments in the code as well.
Thanks.

Because I wanted to use the default types in the options for the Autocomplete. I specificaly need the establishments. So if I look for Université du québec à Montréal, I would get the address of this establishment. I needed the response, because it includes information on geocoding and also the actual name of the establishment/place.
For example, I could query "UQAM" and get the adress of the "Université du Québec à Montréal". I would want the full establishment name to be saved on my end. This full name is available in the original Autocomplete response.

These are the output for that particular example.

Using UQAM

Using Université du Québec à Montréal

Hum, that is weird because you have twice the same object...
That's what I get. A whole lot more information

Point me out in how you assign the response.

Yes, exactly.
You can see here, I just wrap both in an object on the vuemit payload
https://github.com/gocanto/google-autocomplete/pull/37/files#diff-08420c820708ccac1cbc6f0c0650420aR86

OK cool, I like that.

Can you send the PR to dev branch please?

I ll merge it from there

Ok!


ENH: Write Unknown cartesian CRS when saving gdf without a CRS to GPKG

Questions/remarks:

I only put it in the code path for GeoDataFrames and not in general as we only know for these that it should be cartesian I think?
If I remember correctly I think it was decided in the meeting not to set the crs to None for that crs when reading?

resolves #367

@edzer are you sure the way this is handled in {sf} is actually correct? Meaning it correctly roundtrips and follows the spec?

@martinfleis which spec are you referring to?

@edzer I think I meant GeoPackage spec. From what I understand when @theroggy explained that, undefined SRS shall be saved as -1. But if we replicate the WKT from the sf issue linked above, it is not the case and it is saved as a custom SRS instead with ID 10000 or something like that (@theroggy please correct me here).

IIRC, the problem with the undefined SRS in GeoPackages is that they are assumed (and, after roundtrip read as) geographic coordinates with undefined datum. If you want to specify they are Cartesian but otherwise unknown, you can use the WKT
ENGCRS["Undefined Cartesian SRS with unknown unit",
  EDATUM["Unknown engineering datum"],
  CS[Cartesian, 2],
  AXIS["X",unspecified,ORDER[1],LENGTHUNIT["unknown",0]],
  AXIS["Y",unspecified,ORDER[2],LENGTHUNIT["unknown",0]]
]

which is what R package sf writes to geopackages when the CRS is NA: https://github.com/r-spatial/sf/blob/main/R/read.R#L548

See also https://github.com/r-spatial/sf/issues/2049#issuecomment-1333937050

the undefined SRS in GeoPackages is that they are assumed (and, after roundtrip read as) geographic coordinates with undefined datum. If you want to specify they are Cartesian but otherwise unknown, you can use the WKT

Undefined in sense of SRS=0 is assumed geographic but SRS=-1 is assumed Cartesian. Citing Requirement 11 from the version 1.4 of the spec:

The record with an srs_id of -1 SHALL be used for undefined Cartesian coordinate reference systems. The record with an srs_id of 0 SHALL be used for undefined geographic coordinate reference systems.

That is where I think that the sf solution with custom WKT is not exactly reflecting the spec.
GDAL correctly understands -1 as Cartesian but, for unknown reasons, sets units to meters here. We discusses on the dev call earlier today that this should probably be fixed to resolve as Undefined Cartesian SRS with unknown units rather than with meters. Then setting SRS to -1 should do what we want it to without specifying custom WKT.

So, maybe raise an issue with GDAL?

As planned in the community meeting and suggested by @edzer , I opened an issue to discuss this further in GDAL: https://github.com/OSGeo/gdal/issues/9580

Just checking back on the status of this PR; it looks like this is potentially waiting on upstream changes to GDAL possibly in 3.9?  But then what is the path forward on this for GDAL < 3.9?


alacritty 0.3.0 occasionally fails to redraw the screen

Which operating system does the issue occur on? Gentoo Linux
If on linux, are you using X11 or Wayland? X11
Ever since updating to the 0.3 series, alacritty will occasionally fail to redraw until something forces the redraw (such as input or moving the mouse over the terminal window).
Let me know what additional information I can provide.

Can you run alacritty -vvv and see what it prints before it hangs perhaps?

+1 on Linux X11 and it seems to happen, at least more frequently in full screen mode, and for commands who take time without screen updates, e.g. durring a rust project compilation. Alacritty doesn't hang, but stops redrawing while there's no keystrokes, after a keystroke the screen gets updated and everythink works as expected again.
Can't see any error with -vvv

I wasn't really expecting to see an error if all it's doing is hanging for a moment then moving on. I was curious to see the last few log messages logged when the terminal is hanging, before you hit  keystroke and unhang it.

I'm still trying to capture this. I can't make the issue happen at will so it will take a bit of time. :)

OK, observing this, it's going to be tricky to match the logs up with the issue.
I think what I'm seeing is that when alacritty stops redrawing, the log output continues as normal. In my current test, it's repeating:
[2019-04-17 09:09] [TRACE] [src/term/mod.rs:1689] Carriage return
[2019-04-17 09:09] [TRACE] [src/term/mod.rs:1697] Linefeed
[2019-04-17 09:09] [TRACE] [src/term/mod.rs:1333] Scrolling up relative: origin=0, lines=1

In this case, the output is periodically freezing and unfreezing - something I didn't notice before I watched the alacritty logs.

This is a duplicate of https://github.com/jwilm/alacritty/issues/2217.

Excellent, thanks!


Fetching related with many-to-many models

I have not been able to find any documentation dealing with this question, so am asking it here.
Let's say I have two models which have a belongsToMany relation with each other using a pivot table. For instance, Policies and Exclusions.
I have an exclusion ID and want to query for all models which have such an id.
How do I do this?

Closing this since it's a duplicate of a Stack Overflow post: https://stackoverflow.com/questions/53151351/bookshelf-js-how-do-i-fetch-many-to-many


How to remove typed text when selecting with enter?

This might just be user-error, in which case an update to the docs might help, otherwise it might be a feature request.
When I use a select like this:
	new tomSelect(selectElem, {
		plugins: ['remove_button'],
		create: false
	});

I can start typing a few chars, then use the keyboard (up/down/enter) to select a item from the list.
When I do that, the characters i typed remain in the box. Can these be removed on selection?
Thanks

Like this? https://jsfiddle.net/84fLts2k/

Spectacular, thanks!
Might be worth a demo that does that, unless its there and I missed in. In which case make it more obvious/call me an idiot
:D

What threw me was that it has that behaviour by default when its a <select multiple=false>

Hmm, although your solution makes the dropdown say "no results found", if you type another char, then backspace it, you get the search list back...

It is different for multiple=false (and different from selectize). The reason: let's say you have a long list and you want to add all options that have "aaa". You wouldn't want to have to type "aaa" every time.

your solution makes the dropdown say "no results found"

Looks like it needs one more line

Awesome, thanks for the support!


[release-0.58] Set mem/cpu request and limits on hotplug attachment pod container to 1 to 1 ratio

What this PR does / why we need it:
Manual backport of #9312 needed to adjust the functional test to use older mechanisms.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/lgtm
/approve

/test pull-kubevirt-goveralls-0.58

/test pull-kubevirt-e2e-kind-1.23-vgpu-0.58


Add docs for managing releases

GitHub Issue: #628
Describe your changes
Adds a MAINTAINING.md doc to list all the steps maintainers need to follow to release the various projects in the monorepo.
The MAINTAINING.md doc can be read at https://github.com/chapter-three/next-drupal/blob/628-manage-releases/MAINTAINING.md
The 8761181 commit ensures that when we release a 2.0.0-alpha.0 release of next-drupal that all of the examples/starters will also get a premajor version bump.

Closed in favor of #641


Minimum set of permissions to use cdk cli

Hello,
I'm experimenting the cdk-cli.
According to the cdk workshop I found here the cdk-cli needs AdministrationAccess privileges to work.
Is it really necessary? It looks like the permissions are a little too much for the purpose of the tool. Am I missing something?
Thanks

The CDK can be used to create any resource in your account. As such, it will need permission to create any resource in your account, which roughly amounts to AdministorAccess.
If you know you're only going to be creating Buckets and nothing else, feel free to use a role that only has s3:CreateBucket.


Wrong command present in odo documentation(#creating a Node.js application with odo)

/kind documentation

What mistake did you find / what is missing in the documentation?
In the following documentation, command to create dir and change to the directory is wrong as shown below.

$$ should be replaced with &&.
What is the relevance of it?
Correct command will improve UX of users.

Thanks @anandrkskd I've opened up a PR here: https://github.com/openshift/openshift-docs/pull/25090

This has been fixed.


Implementation of MULTILEADER and MULTILEADERSTYLE

First of all, great work!! this looks great!! to continue with the development I would like to add a few notes:

Add test to check that the MLEADER and MLEADERSTYLE are read without errors, the current test files only contain MLEADERSTYLE, you should add a file in each version (if possible) containing MLEADER in it.
The DxfReader and DxfWriter haven't been updated, do you plan to do it in this PR or keep it separately?
When updating the branch be careful for which are the last changes in master, some of my comments were related to this issue.

Overall looks good, I will continue to review the PR while you work on it and continue to give feedback to you.
Thanks for the contribution.

I am afraid, we did something wrong. Some of the changes you mentioned above have not been made by us. We have to check how this happened.
Maybe we have to redo the fork, create a branch and enter a PR.
I will return to it tomorrow.

Add test to check that the MLEADER and MLEADERSTYLE are read without errors, the current test files only contain MLEADERSTYLE, you should add a file in each version (if possible) containing MLEADER in it.

OK, we must view the test project.

The DxfReader and DxfWriter haven't been updated, do you plan to do it in this PR or keep it separately?

We then also must add writeMultiLeader and writeMultiLeaderStyle to DwgObjectWriter, right?
I would prefer do do it separately.

When updating the branch be careful for which are the last changes in master, some of my comments were related to this issue.

OK

I've been reviewing the PR, for some reason your PR is pointing to an old version of master and registering a lot of changes that should not be there... I don't know why is this way, I'll try to find out more about this issue.
In the meantime keep an eye to the test, I've approved the build but is failing, check what is happening, it may be caused due this unnecessary changes.

For a full test we have to create a DWG files with "all" variants of Mutileader also for older AutoCAD versions, right?
To make the test run a subset may be sufficient.
For all variants we have to learn about block content, arrow heads and some other things we did not try yet.

For a full test we have to create a DWG files with "all" variants of Mutileader also for older AutoCAD versions, right? To make the test run a subset may be sufficient. For all variants we have to learn about block content, arrow heads and some other things we did not try yet.

If you want to just test in a single version you have to make sure that the reader will ignore the entities for all other versions to avoid issues or bugs.

It seems that some tests are failing, one of them is the DwgReaderTest the test is making a comparison with a json file that does not belong to the new sample, the best way to go it will be to move the sample to another folder and create an specific test for it.
Also I see that the Clone() test is failing too for the MultiLeader it goes in some kind of loop.
Let me know if you need any help with that.

It seems that some tests are failing, one of them is the DwgReaderTest the test is making a comparison with a json file that does not belong to the new sample, the best way to go it will be to move the sample to another folder and create an specific test for it.
Also I see that the Clone() test is failing too for the MultiLeader it goes in some kind of loop.
Let me know if you need any help with that.

Hi @DomCR,
I am sorry, I did not have time to work on this project the last two weeks.
I return today to analyse these problems with Nihad.
Then we should try to finish.
I would like to solve the problems regarding the version compliance by simply not supporting mutileaders form AutoCAD versions older than R2010.
I think the object model is OK now.

It seems that some tests are failing, one of them is the DwgReaderTest the test is making a comparison with a json file that does not belong to the new sample, the best way to go it will be to move the sample to another folder and create an specific test for it.
Also I see that the Clone() test is failing too for the MultiLeader it goes in some kind of loop.
Let me know if you need any help with that.

Hi @DomCR,
I am sorry, I did not have time to work on this project the last two weeks. I return today to analyse these problems with Nihad.
Then we should try to finish. I would like to solve the problems regarding the version compliance by simply not supporting mutileaders form AutoCAD versions older than R2010. I think the object model is OK now.

The PR and the implementation looks good, and if you want to focus on one feature at a time that's ok, even if you want to split the PR that would be OK for me too.
Just as a general note, check the documentation comments and avoid to use the ///  tag for enums and keep in mind to delete the development methods.

Hi @DomCR,
is it OK for you, to restrict ths support of multileader entities to version R2010 Plus?
Then I will change the implementation accordingly.
Here are some remarks to our implementation:
Object Model
According to the PDF (OpenDesign_Specification_for_.dwg_files) and online documentation the MultiLeader entity  embeds an object that provides a subset ob the properties of a MLeaderAnnotContext object. The MLeaderAnnotContext includes a list of embedded LEADER objects. LEADER objects contain a list of LEDER_LINE objects.

In the DXF file with a MULTILEADER entity we also found a complete MLeaderAnnotContext object with the common properties and properties identical to the object embedded into the MULTILEADER.

This structure is reproduced in the object model:

The MultiLeader class has a Style property referencing a MultiLeaderStyle object.
A MultiLeaderAnnotContext class is defined holding the subset of properties from the MLeaderAnnotContext. Each MultiLeader references exactly one MultiLeaderAnnotContext.
The MultiLeaderAnnotContext has a list of LeaderRoot objects.
A LederRoot has a list of LeaderLine objects.

Several properties of the MultiLeader class also exist in the MultiLeaderAnnotContext class. Values may be redundant or conflicting.
Remarks
In AutoCAD a MultiLeader can have one or more leaders evolving to leader lines (LEADER_LINE). It seems there is no way to add more than one leader (LEADER), having one or more leader lines each.
Thus: There can be only one LEADER. More than one LEADER would require an individual Contents. But the MultiLeader can have has one "Contents", either a Text contents or a contents block.
The MultiLeader class has a LineType property enherited from Entity referencing a LineType object. A second property of type LineType (LeaderLineType) is defined in the MultiLeader class. The referenced LineType objects are different.
Open Issues
Version Compliance
Due to lack of documentation and because we cannot create and test DWG-files with old AutoCAD versions we can support multileaders only for R2010 Plus.
List of Arrowheads
In the PDF (OpenDesign_Specification_for_.dwg_files) documentation and also in the various DXF documentations a list of arrowheads is mentioned. This data are obviously not present in the DWG. We assume that the documentation is wrong.
Two Unknown Bytes in MultiLeader
Between 291 Enable Dogleg and 41  Dogleg Length we must call Advance(2).

Hi @DomCR,
final changes (hopefully):

removed all enum values from /// comments, except where only a subset is mentioned in the documentation.
fixed formatting (opening brace on new line).
removed analyse methods.
readMultiLeader and readMultiLeaderStyle return null when version is older than R2010.

regards
Matthias

Hi @DomCR,
please commit this PR if the code is OK for you now.
regards
Matthias

Great Job with this one!! looks really good!!
I've reviewed the PR, most of the comments are related to the documentation or fix some merging errors that you may have had during the development, I'll try to block any PRs that mess with you files until this is merge into master.

There are some test failing:

Failed ACadSharp.Tests.ColorTests: this are due the merging errors, once you restore those classes you will be good.
Failed ACadSharp.Tests.IO.IOTests: this test is using the DwgWriter and DxfWriter for testing, the ACadSharp.IO.DXF.DxfSectionWriterBase.writeEntity and DwgObjectWriter.Entities are throwing an exception for your new entities, please add them into the ignore list so this exception is avoided.

If you need a hand resolving this issues, please let me know and I'll commit the changes directly to this PR.

Hi @DomCR,
we hopefully fixed the merge conflicts and changed the comments as you requested.
However the comments are in general very poor. I will improve them later when we learnt how properties specified in AutoCAD arrive in the data.
regards
Matthias

Here is a fix for the ACadSharp.Entities.MultiLeader.Clone() error:
		public override CadObject Clone()
		{
			MultiLeader clone = (MultiLeader)base.Clone();

			clone.ContextData = (MultiLeaderAnnotContext)this.ContextData?.Clone();

			foreach (var att in BlockAttributes)
			{
				clone.BlockAttributes.Add(att);
			}

			return clone;
		}

Oh.

Oh.

Sorry I wanted to try if I was able to push directly here and make the merge if the test passed.

Great job!!

Hi @DomCR
So you made the change yourself and merged everythng, Thank you wery much.
We will now concentrate on our DWG-to-SVG converter an so intensively test the multileder reader.
Then we shall implement the DXF-reader and the writers.
Again thank you very much for your help and the review. It is great to contribute to such an active project.
Greetings from Berlin to Barcelona.


Updated sessionupdate datamodel to include session_type and session_id

Description:

Type of change:

[ ] Bug fix.
[ ] New feature.
[ ] Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

[ ] Is the change limited to one issue?
[ ] Does this PR close the issue?
[ ] Is the code easy to read and understand?
[ ] Do all new feature have an accompanying new test?
[ ] Has the documentation been updated as necessary?

In the pydantic documentation examples, they do not specify:
class Config:
""" enable assignment validation """
validate_assignment = True
Why is it needed in our case?

In the pydantic documentation examples, they do not specify: class Config: """ enable assignment validation """ validate_assignment = True
Why is it needed in our case?

It validates the field types when the values are updated. Normally, type validation is only done when first creating the model objects.

The purpose of introducing session_type and session_id is unclear from this PR. Is the idea that session_type e.g. should be "dlite" or "cuds". What about the session_id? For DLite, should that the the id of the underlying collection?
Maybe example use could be added to the description of the pydantic data model.

To get rid of the failing tests, install pre-commit and accept the changes suggested by blacken...

I think this should reopened and re-evaluated?


Chained "or"s to reduce on parentheses in source

currently you can do find all "a" or ("b" or "c") but I would really like to be able to do find all "a" or "b" or "c" so the amount of parentheses doesn't build up with long "or" chains

This was completed as well as changing from literals to full  expressions as the body to certain commands like at least x <expr> which also significantly cuts down on the number of parentheses


Facing overlapping issues in floating Inputs

Platform
IOS

NativeBase version : 2.15.0
Device: Iphone 7 or later
OS: IOS
React Native version: 0.63.4
node 15

Facing overlapping issues in floating Inputs

Hi @loveheenavasu , Can you please provide snack /  codesandbox link?


[AutoPR] cognitiveservices/data-plane/Face

Created to accumulate context: cognitiveservices/data-plane/Face

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cognitiveservices/data-plane/Face/readme.md

Working on generating https://github.com/azure/azure-rest-api-specs/blob/master/specification/cognitiveservices/data-plane/face/readme.md for you!!!

Nothing to rebuild, this PR is up to date

Codecov Report

Merging #4220 into master will increase coverage by 3%.
The diff coverage is 73.45%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab3f67...c56daa9. Read the comment docs.


Improve the text at the top of the home page

Received the latest home text from the product team

wrong target repo


Changed slf4j-simple to runtime dependency

SLF4j runtime bindings like slf4j-simple should only be a test or runtime scope dependency, otherwise you'll see runtime SLF4J runtime binding errors if a different project is using, for example slf4j-log4j runtime binding.
It doesn't appear that this plugin is using any SLF4j apis directly, so possible that slf4j-simple dependency could just be removed all together...

Can one of the admins verify this patch?

ok to test

Yeah its using the logger api from maven itself. But the fabric-forge stuff uses slf4j. But only slf4j-api would be nessasary to have on CP and it should be there already.


Add support for v1.5 API

TL;DR
v1.5 adds some additional fields attached to keys that need to be handled by the Key server.
Limited support for change of key status + revocation is supported in the API shape.
Design Goals
Additional fields need to be selected by the HA app:

report_type - unambiguous source of the diagnosis
days_since_onset_of_symptoms - offset to the date on which symptoms first appeared

The HA also has the opportunity to make a single revision to a previously published key:

Changes are placed in revised_keys

Only some changes are allowed (enforced by the client, but server can also check):
Recursive -> Confirmed Test, Revoked, Clinical Diagnosis, Self-Report
Self-Report ->  Confirmed Test, Revoked, Clinical Diagnosis
Clinical Diagnosis -> Confirmed Test, Revoked
To support these fields well the Diagnosis Key server will need to:

Allow the app to provide an optional days since first onset and attach this to keys
Allow the app to suggest a reportType, but limit some report types to those certified by a verification server

Revision + revocation will require dispensing some secret to the client to allow later revalidation to change a previously released key.
Revision + revocation support in the reference server is of secondary priority to supporting the new key fields.
Transmission risk is deprecated, but can be co-present with the other fields to support v1.0 clients.

I'll take this on next week.

Is revoked in this case, a user initiated action or does that need to be run through a verification server?

Some high level notes

In this reference sever we will not support uploads of "recursive" or "self-report" at this time, but instead continue to recommend the use of the verification server protocol.
Symptom onset date will be accepted and then assigned by the server. This field can also be present on the verification certificate. Ideally that is where the field will come from.
Report type must come from a verification certificate, we won't let apps assign this on their own
For revised keys:

the verification system itself doesn't know that it is revising a key.
For HA verification there are 2 paths we can support

likely -> confirmed
likely -> negative
if a duplicate key is encountered and the verification certificate indicates this status change, it will be recorded

This is the 3rd allowable change only (see original comment)
revisions must come from the same health authority ID

Execution plan

[ ] Change verification certificate claims to support v1.5 fields
[ ] Change the exposure table to add the following fields: health_authority_id, report_type, days_since_symptom_onset, revised_report_type, revised_at (timestamp)
[ ] Add support in the exposure API to accept symptom onset date only. This means that a confirmed or likely diagnosis can only come from a verification certificate.
[ ] Add the new fields to the verification server for token + certificate processing
[ ] Process expanded fields in the verification certificate. Write new fields to database
[ ] Add support for key revision in the exposure API
[ ] Add support for publishing revised keys in export files, based off of the new fields in the exposure table.

Updates to verification server for new claims:
https://github.com/google/exposure-notifications-verification-server/pull/101

The specification still states "The header must be exactly “EK Export v1” right-padded to 16 bytes with UTF-8 whitespaces."
Do you intend to keep that / how do you plan to do versioning for this interface?

@flagxor @gurayAlsac  - Can you answer the question about the header string?

When stable, I plan to promote the API version from v1alpha1 to v1beta1.

@flagxor @gurayAlsac - Can you answer the question about the header string?

We won't be changing the header string for this backwards compatible proto change. The header string would only change for a larger file format change (e.g., using a different proto, or something other than a proto)

/close
Remaining work is in #717


Binding to port 0

When you bind to port 0, the system assigns you some unspecified available port. This is only useful if you can get that port back from SuperWebSocket, but it does not seem to expose the endpoint of the listener.

Example use-case: https://github.com/SirCmpwn/mdedit/blob/master/MDService.cs#L33-L34

Same issue for me as well. I have game servers that are dynamically created and I can't seem to retrieve the server port without doing some hacky coding.

Probably you can implement this feature using endpoint runtime replacement like the code below:
https://raw.githubusercontent.com/kerryjiang/SuperSocket/v1.6/QuickStart/WindowsAzure/SuperSocketRole/WorkerRole.cs


DISTX-397 Create data engineering HA template

Design : https://docs.google.com/document/d/1oN8l9p74gKNps1aeG2NCjdh1_6yRo5YZA4eTolS9dVw/edit
Added all the templates in preview mode as noted in the design.
The requirement was to use smaller instance type for quorum nodes. At the moment not possible because, a unit test fails with m5.xlarge for quorum nodes.
Tested that cluster definitions and blueprints came up fine in UI via moonlander private stack https://gk1-console.cdp-priv.mow-dev.cloudera.com/cloud/environments/list.

Also, does this need to change for 702 also, or just 710 onwards?

Also, does this need to change for 702 also, or just 710 onwards?

There is nothing specific to 710 so, support for both the versions. Also, 702 is the default version in the version selector as of now.

retest this please

Only checkstyle was failing. I asked for retest, now aws-test is failing with docker volume remove error.


How can I install additional packages in boot2docker vm?

For example utility tracert  is not present.
Installing additional packages would be great  in order to get better tools for debugging configurations.(especially in corporate environments with multiple network connections and vpns)

docker run 😉
(Seriously though, if you want to use the TCL package manager very badly, you can do this with tce-load e.g. tce-load -iw rsync)

I needed to install vim, so now I include this line at the end of my /mnt/sda1/var/lib/boot2docker/bootsync.sh file.  This will install it every time you restart the docker-machine.   You must install as docker.  The ampersand at the end forks the command into a background process so you can start using the machine immediatly and wait for vim to finish loading in the background.
sudo su - docker -c 'tce-load -wi vim.tcz &'
Kind of resource intensive though - it downloads the packages for every restart.  Requires internet too - don't expect it to work on a plane.


[INFRA] Bump github labeler action to v5

:mag: Description
Issue References 🔗

This pull request aims to bump labeler action to v5.
Describe Your Solution 🔧
The full release notes: https://github.com/actions/labeler/releases/tag/v5.0.0
Version 5 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklists
📝 Author Self Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

[x] Pull request title is okay.
[x] No license issues.
[x] Milestone correctly set?
[ ] Test coverage is ok
[x] Assignees are selected.
[x] Minimum number of approvals
[x] No changes are requested

Be nice. Be informative.

cc @bowenliang123 as u tried it previously

Similar PR has already been done in Spark repo: https://github.com/apache/spark/pull/44350

The CI actions still run on v4. You have to run actions/checkout first to apply the local labler config file.

 The CI actions still run on v4. You have to run actions/checkout first to apply the local labler config file.

Manually check as follows:
1.Considering that the testing of the github labeler action is relatively special: When I submitted changes to this repo, the GA still executed the v4 version logic before merging the PR into it
ref: https://github.com/actions/labeler?tab=readme-ov-file#notes-regarding-pull_request_target,

2.I created a similar private repo to verify it
The file (.github/labeler.yml) of this private repo is exactly the same as the file I am submitting to Spark repo

https://github.com/panbingkun/github-action-test/blob/main/.github/labeler.yml
3.The verification process is as follows:
A.When I submitted core/x.scala to this repo, it automatically labeled CORE
https://github.com/panbingkun/github-action-test/pull/2

B.When I submitted core/xxUI. scala in this library, it automatically labeled WEBUI
https://github.com/panbingkun/github-action-test/pull/3

LGTM in changes overall. However external manual validation on a forked Spark repo may not be enough. Last time I reverted similar changes exactly due to assuming things right with skipped validation in PR.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (667b5ab) 61.36% compared to head (85ce1f6) 61.31%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5874      +/-   ##
============================================
- Coverage     61.36%   61.31%   -0.05%
  Complexity       23       23
============================================
  Files           612      612
  Lines         36239    36239
  Branches       4967     4967
============================================
- Hits          22237    22221      -16
- Misses        11606    11621      +15
- Partials       2396     2397       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Let's get it in to see what happens. Thanks for your contribution @panbingkun

LGTM in changes overall. However external manual validation on a forked Spark repo may not be enough. Last time I reverted similar changes in #5840 and abandoned drafted #5843, exactly due to assuming things right with skipped validation in PR.

After Spark Merge it, I verified again whether it is normal, and it is currently normal.
eg: https://github.com/apache/spark/actions/runs/7255705397/job/19766796815?pr=43924

If it is not enough, I can verify the exact logic of and files in my private repo

Merged to master, will observe the coming PRs

Thanks for your contribution @panbingkun.

After this merge, I tested one as follows:
https://github.com/apache/kyuubi/pull/5876
At present, it seems normal, 😄
https://github.com/apache/kyuubi/actions/runs/7257083679/job/19770341512?pr=5876

@panbingkun thanks for the follow-up verification.


update(changelog): updated changelog for 0.39.2.

What type of PR is this?
/kind release
Any specific area of the project related to this PR?
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

/milestone 0.39.2
Will be cherrypicked to master once it's merged.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fix Search Box Not Showing Apps/Tweaks Checkboxes When typing out Capital-Letters

Issues this PR Tries to Resolve
Resolves #1731
The PR in-action

That's a easy one line fixes lol

That's a easy one line fixes lol

Agree on being a very simple patch, finding where's the searching code was the difficult part for me.

This is one of my favorite PR's of all time.


Code splitting Angular 8

🐞 bug report
Affected Package
The issue is caused by package @angular/cli
Is this a regression?

 Yes, the previous version in which this bug was not present was 7.3.8.
Description
 After the `import` statements have been adjusted by `angular` to use the standard `import()` for lazy loading, the output bundle now is bundling all of my lazy-loaded routes into the main bundle after updating to Angular 8.
🌍  Your Environment
Angular Version:

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 8.0.3
Node: 12.1.0
OS: darwin x64
Angular: 8.1.0-next.1
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router, service-worker

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.13.8
@angular-devkit/build-angular      0.800.3
@angular-devkit/build-ng-packagr   0.800.3
@angular-devkit/build-optimizer    0.13.8
@angular-devkit/build-webpack      0.800.3
@angular-devkit/core               7.3.8
@angular-devkit/schematics         7.3.8
@angular/cdk                       7.3.7
@angular/cli                       8.0.3
@angular/flex-layout               7.0.0-beta.24
@angular/material                  7.3.7
@angular/pwa                       0.13.8
@ngtools/json-schema               1.1.0
@ngtools/webpack                   8.0.3
@schematics/angular                7.3.8
@schematics/update                 0.800.3
ng-packagr                         5.3.0
rxjs                               6.5.2
typescript                         3.4.5
webpack                            4.30.0

@aaronte I'm seeing some old packages in your version list. This might well be the cause of it.
Can you check if this issue still exists if you manually update the @angular and @schematics to their latest versions?
Please also remove and reinstall your node_modules folder after that change.

Hi @aaronte can you please follow the steps mentioned above by @SanderElias?
If the problem persists after upgrading,  Can you setup a minimal repro please?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.
This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

@SanderElias @alan-agius4 I should've provided a repro in the beginning! Apologies! But by making the repro repo, I've found the problem!
My angular project has existed for a long time and not sure if this was just the default before but it doesn't have module defined. This causes the tsconfig to default to module: commonjs. When running the ng update to Angular v8, the automatic update should scripts convert module to be set to esnext. This is required for the new dynamic import loading syntax to work. However, when a project does not have the tsconfig.json in the root of the project like what I had, the script does not automatically update module field which then led to my project not code-splitting properly.
I've added a mimic of folder structure in this example repo. My question is:
• Is the CLI ignoring non-root tsconfig.json even if it's defined in angular.json the correct implementation?
• Is the assumption that all angular workspaces should have a root tsconfig.json?

Hi, @aaronte,

Is the CLI ignoring non-root tsconfig.json even if it's defined in angular.json the correct implementation?

The problem here, is that you have an addition tsconfig that the application tsconfig is extending from which is not the workspace root tsconfig (https://github.com/aaronte/v7-to-v8-angular-repro-steps/blob/master/projects/main-project/tsconfig.json). We are not resolving extends and we are assuming that if you do extend, eventually it will extend from root tsconfig.

Is the assumption that all angular workspaces should have a root tsconfig.json?
No, as in most cases we will use the tsconfig defined in the angular.json. However, there are certain schematics which do require the root level tsconfig.json. As otherwise, the users will need to config their tsconfig manually, One such case that comes to mind is if you generate libraries, Not having a root level tsconfig will be quite cumbersome get it working and configuration.

I am going to mark this needs further discussion to see if we should resolve the extended tsconfig when doing the migration and not assume that if one an extends in one or more level, it will eventually extend the root level tsconfig. That being said, this is quite a rare case and eventually if the tsconfig is not updated via the migration will lead to a build error, which should be straight forward to fix.

We should inform that our tsconfig update fell off the happy path and what the user should do. We probably should compile a comprehensive update list and either display it during the update, or put it on AIO.

https://github.com/cexbrayat/angular-cli-diff is of a great help, when updating.

@alan-agius4 Thank you so much for the detailed explanation. I do agree that in the repro step, the build threw an error and was very straightforward to fix. However, in my real application, this error did not occur (It just defaulted to commonjs since module wasn't defined in tsconfig.json) which is probably an even rarer case.  I think we're good to close this conversation?
Thank you all again so much!

Closing as per above.


Migration state bug [P3006]

Bug description
The uncorrect migration is not a "failed"
(Migration '20240225090930_bad' cannot be rolled back because it is not in a failed state.)
How to reproduce

Create not correct schema:

model CircleFriend {
  id Int @id @default(autoincrement())
  name String @db.VarChar(255)
  circle Unsupported("circle")? @default(dbgenerated("'<10,4>,13'::circle")) // <10,4>,13 - is incorrect, have to be "<(10,4),13>"
}

Run npx prisma migrate dev --create-only
Now you can't use npx prisma migrate dev at all. (But npx prisma db push works). It says that:

Error: P3006

Migration `20240225090930_bad` failed to apply cleanly to the shadow database.
..circle: "<10,4>,13"
0: sql_schema_connector::validate_migrations
           with namespaces=None
             at schema-engine\connectors\sql-schema-connector\src\lib.rs:324
   1: schema_core::state::DevDiagnostic
             at schema-engine\core\src\state.rs:267

What I tried to do
I tried to --rolled-back, but it can't be used while migration is not applied..
Migration `20240225090930_bad` cannot be rolled back because it was never applied to the database.

..so I have used npx prisma resolved --applied "20240225090930_bad". If I try to -rolled-back now it gives:
Migration `20240225090930_bad` cannot be rolled back because it is not in a failed state.

Main question
Why it's state is not failed?
If I try to prisma migrate dev another time:
Error: P3006

Migration `20240225090930_bad` failed to apply cleanly to the shadow database.

I don't know hot to delete this..
Can I just delete this migration and synchronize with database? No resseting, no prisma db push, no prisma migrate deploy, jut as it was with 'prisma dev'?
Is where another way to cancel uncorrect migration?
Expected behavior

Cancel migration as failed.
Sync with database state if needed.

Prisma information
model CircleFriend {
  id Int @id @default(autoincrement())
  name String @db.VarChar(255)
  circle Unsupported("circle")? @default(dbgenerated("'<10,4>,13'::circle"))
}

npx prisma migrate dev --create-only

Environment & setup

OS: Windows
Database: PostgreSQL
Node.js version: v20.4.0

Prisma Version
5.10.2

I find the solution by manualy deleting applyed migration from DB and change migration in 'Prisma/migration/folder.  But I still think that's a bug, that it didn't counted asfailed`


POSIX compliant poll.h and mmap over sys/poll.h and mmap64

Closes #10737
Basic build testing confirms this works with both musl and glibc:
FROM alpine
RUN apk add --no-cache cmake gcc g++ make musl-dev
WORKDIR /src/xgboost
COPY . .
RUN cmake -S . -B build && \
    cmake --build build

FROM debian:bookworm-slim
RUN apt-get update -qq && \
    apt-get install -y cmake gcc g++ make libstdc++6 && \
    rm -rf /var/lib/apt/lists/*
WORKDIR /src/xgboost
COPY . .
RUN cmake -S . -B build && \
    cmake --build build

Great to see this fixed, as we stumbled over this problem ourselves as well!
I assume this will be part of the 2.2.x release?

We will probably make a patch release.


Add 'optical' cellFormat

Close #787
Added 'optical' to cell formats

pre-commit.ci autofix

pre-commit.ci autofix

pre-commit.ci run

Ah the problem is that pre-commit CI cannot run the schema linter (I think). I'll manually run this.

Pending pre-commit run, this lgtm, is it ready to merge @BenjaminCharmes?

Yes !


Machinery, Computers and Driving lores

The lores do not take the corresponding modifier when creating characters, all keep using INT instead of the proper ability.
i found that adding "machinery-lore" and "lore-machinery" at the selector tab in the Flat-Modifier rule element fixes the issue, same with driving and computers.
BTW you shoult take a look at the starfinder playtest module, it adds piloting and Computers in the main skills instead of being lores, so maybe you can find a way to add machinery in the same way.
Thanks for keeping this module up, hope this helps fix this small issue

@Nalaar365 You can add the Skills by editing the Data\modules\hopefinder\module.json file in the following way:
find the section that says:
  "flags": {
    "hopefinder": {
      "pf2e-homebrew": {

Then add the following lines:
          "skills": {
              "additional": {
                  "computers": {
                      "label": "Computers",
                      "attribute": "int"
                  },
                  "driving": {
                      "label": "Driving",
                      "attribute": "dex"
                  },
		  "mechanics": {
                      "label": "Mechanics",
                      "attribute": "wis"
                  }
              }
        },


Test adding new module

Hello @meteorcloudy, modules without existing maintainers (zlib-2) have been updated in this PR. Please review the changes.

Hello @meteorcloudy, modules without existing maintainers (zlib-2, zlib) have been updated in this PR. Please review the changes.

Hello @meteorcloudy, modules without specific GitHub maintainers (zlib) have been updated in this PR. Please review the changes.


Revamp add version 2

Closes #180

Codecov Report

Merging #186 (1bfc804) into master (7afefbd) will increase coverage by 2.82%.
The diff coverage is 43.83%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##             master     #186      +/-   ##
============================================
+ Coverage     51.56%   54.38%   +2.82%
- Complexity      497      499       +2
============================================
  Files           102      103       +1
  Lines          2368     2278      -90
  Branches        241      244       +3
============================================
+ Hits           1221     1239      +18
+ Misses         1072      957     -115
- Partials         75       82       +7

Impacted Files
Coverage Δ

.../address/logic/commands/AddAppointmentCommand.java
0.00% <0.00%> (ø)

...address/logic/commands/MarkAppointmentCommand.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/person/Nric.java
18.75% <18.75%> (ø)

.../java/seedu/address/storage/JsonAdaptedPerson.java
69.92% <41.37%> (+7.15%)
:arrow_up:

...a/seedu/address/logic/parser/AddCommandParser.java
80.00% <66.66%> (-2.61%)
:arrow_down:

...c/main/java/seedu/address/model/person/Person.java
70.08% <73.33%> (+35.88%)
:arrow_up:

...ain/java/seedu/address/logic/parser/CliSyntax.java
90.00% <100.00%> (+1.11%)
:arrow_up:

...in/java/seedu/address/logic/parser/ParserUtil.java
64.44% <100.00%> (+1.22%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Running the app.exe uncompresses on every run

Not sure if this is by design, but on each application run the entire project is uncompressed to temp and then removed on exit.  0.3.3b.
Steps:

Used Web2Executable gui 0.3.3b windows
Built project for 32 and 64 which results in a 190mb app.exe
Launching app.exe takes many seconds
Launches at .../AppData/Local/Temp/nw264_13422/
Exiting takes many seconds and removes that directory

How do I prevent that?  Shouldn't it only uncompress once?

Unfortunately, that's how NW.js works with packed exes. The only way to have uncompressed data is when exporting to Mac.
Of course, if I added an Electron backend, you could have uncompressed folders easily on all platforms.

Yup.  I remembered that after posting...   Thanks.


[WIP] Add an auto-redirect for all HTTP to HTTPs

Addresses https://github.com/hackoregon/civic-devops/issues/215
Adds a TLS-redirect at the ALB layer, so that none of our services need to be aware of HTTP/HTTPS distinctions.  At present, would affect all HTTP resources under the civicpdx.org, service.civicpdx.org and civicplatform.org domains.

@MikeTheCanuck , one question I would have is how are health checks configured?, would endpoints returning a 301 affect these? We may also need to verify any test suites that are calling  http  endpoints

Good ideas to verify these behaviours.
I'm 90% sure that the health check call from ALB to the container would happen after the layer that performs this redirect.  It will be very easy to check, just looking at the CloudWatch logs for Django will tell us instantly whether the requests are getting to the containers, and if they're happening once or twice.
I don't know as much about any application test suites, and which of them to evaluate where to know if this has affected anything or not.  Can you help track them down, and maybe even boil down to a list of (a) where to look, (b) what to look for, for each of the applications?


Development

Hi Aswin,
I heard about you on the news today. What you are doing is amazing it's an honor that people like are part of the community. When the news channel showed the code I knew it was written on ROR so I thought I should help in any way I can. This is just a readme update. if there are any open issues you are working on please let me know.

The rake admin task should need password and password_confirmation

acutally we are creating it from the terminal right, so we can see whats the password what password we are giving in in plain text. So i dont think that will be necessory. If you think so, i will add.

Also the master branch contains production ready code only, push to develop

Sure.
can you please make a small, condribution guidelines. if you do it, i could ask a few more people to join in.


Feature: Increase the size of icon and text for an indicator of the number of post views when opening it in the post submitting page and post overlay page

Fixed by ea23fea commit

Fixed by ea23fea commit


[WIP] Add documentation of all OpenStack provider opts

Add documentation of all OpenStack provider options including an
indication as to which items are required versus optional and which
configuration blocks they must appear in.
https://github.com/kubernetes/website/issues/5980

This change is

Does anyone understand why the bot labeled this as "Do not merge"?
@xsgordon Is it your intention that this should not be merged?

@steveperry-53 I believe the "do-not-merge" label was added because the PR has "[WIP]" in its title.

@steveperry-53 I marked it WIP as there is still a few TODOs marked.
/cc @dims @anguslees @arthur0 @FengyunPan @k8s-sig-openstack-feature-requests

Still not sure what the valid values for lb-method are.

cc ss22ever


Docker setup not working correctly

Expected Behavior
After running docker/start-dev I should be able to access localhost:8080/auth/login and in localhost:8080 I should see the site.
Current Behavior
When accessing said URLs all you get is an ECONNREFUSED error and if you run ngrep on the containers the proxy returns a 502 without even trying to reach the other containers.
Steps to Reproduce
Steps to reproduce the behavior:

fresh clone of Protofy
cd into docker folder, run ./start-dev and wait for it to finish
visit localhost:8080 in a browser

Context (Environment)

Default setup
OS: Manjaro
Browser: Chrome and Firefox
Environment: dev

Currently we've added support for docker and its currently working. See docs


Migrating junit4to jupiter

Thanks for sending this over @nherac
We're going to take the changes and apply them without the solutions so I'll close this off for now but base our future updates off the back of it.


Get rid of locking and allocations in Map/MapOf.Range

Closes #44
Closes #25

Codecov Report

Merging #45 (fd03f35) into main (f620963) will decrease coverage by 2.48%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   94.46%   91.97%   -2.49%
==========================================
  Files           6        6
  Lines         723      723
==========================================
- Hits          683      665      -18
- Misses         33       47      +14
- Partials        7       11       +4

Impacted Files
Coverage Δ

map.go
90.43% <94.44%> (-4.06%)
:arrow_down:

mapof.go
90.08% <100.00%> (-1.73%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add API security

Should add a minimal amount of API security to ensure scores are coming from the game and not random user's curl-ing / cheating
serve via https vs http?
access key in the request headers?

possibly route the API via 3scale for API security?

https added via OpenShift.
For API security - plan to start with just an API access key.


New function to Send seen (double blue checks) to chat

In the file wapi.js, Why do you pass how parameter the value 'false' in the function sendSeen?
What's the difference in passing it or not?

If you don't pass it it simply wont work.

Do I need to send another command in order it to work ? sendSeen just not work if you hav about 30 seconds of inactivity.


cachi2: conversion function to cachi2 params

Conversion function that transforms remote_source into cachi2 params
STONEBLD-2586
Maintainers will complete the following section

[x] Commit messages are descriptive enough
[x] Code coverage from testing does not decrease and new code is covered
[x] Python type annotations added to new code
[-] JSON/YAML configuration changes are updated in the relevant schema
[-] Changes to metadata also update the documentation for the metadata
[-] Pull request has a link to an osbs-docs PR for user documentation updates
[-] New feature can be disabled from a configuration file

Addressed comments, PTAL


Dev

v2024.2.19

Codecov Report
Attention: 513 lines in your changes are missing coverage. Please review.

Comparison is base (f24faef) 40.13% compared to head (6e72df0) 38.63%.

:exclamation: Current head 6e72df0 differs from pull request most recent head 389a4cb. Consider uploading reports for the commit 389a4cb to get more accurate results

Files
Patch %
Lines

src/napari_chatgpt/_sandbox/qtawesome_demo.py
0.00%
116 Missing :warning:

...ari_chatgpt/utils/api_keys/api_key_vault_dialog.py
0.00%
50 Missing :warning:

...ri_chatgpt/utils/segmentation/labels_3d_merging.py
0.00%
35 Missing :warning:

...tgpt/omega/tools/napari/delegated_code/stardist.py
0.00%
33 Missing :warning:

src/napari_chatgpt/_sandbox/all_qstyle_icons.py
0.00%
22 Missing :warning:

src/napari_chatgpt/_widget.py
48.71%
20 Missing :warning:

...mega/tools/napari/cell_nuclei_segmentation_tool.py
75.00%
18 Missing :warning:

src/napari_chatgpt/utils/python/pip_utils.py
26.08%
17 Missing :warning:

.../utils/segmentation/demo/labels_3d_merging_demo.py
0.00%
17 Missing :warning:

...hatgpt/utils/python/test/check_code_safety_test.py
0.00%
15 Missing :warning:

... and 31 more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   40.13%   38.63%   -1.50%
==========================================
  Files         156      175      +19
  Lines        4647     5231     +584
==========================================
+ Hits         1865     2021     +156
- Misses       2782     3210     +428

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Upgrade phone numbers from 1.1.0-beta.6 to 1.1.0-beta.7

Description
Upgrade phone numbers from 1.1.0-beta.6 to 1.1.0-beta.7.
The update contains only patch updates.

API change check
API changes are not detected in this pull request.

Unlike stable releases, we don't have to release a beta to update dependencies every month. We usually do so if there are new features or bug fixes instead. If you want to go ahead and release a new beta that's alright though.


ensure you load in the request module

I think this is just a typo. I think.

wowowow how is this even working lol. Thank you @shiftkey!! ✨


Delete shortcuts

Hello,
When I create a desktop shortcut using Visual Studio Installer Projects the user may never be able to delete it.
The way I do it is going to right click setup -> File System ->Application Folder -> right click on Primary output -> Create Shortcut -> rename it -> move to User's Desktop.
I noticed that after installation the shortcuts owner is System, thus preventing deletion.

Is there any way I can make the shortcuts correctly, allowing them to be deleted?

Is this a per-user install or a shared install?

Is this a per-user install or a shared install?

Sorry for taking so long, didn't see the notification email and this is not so urgent...
We create the installer, where later the APP is installed locally on the computer, normally for all users.


Fix Layout/LineLength cop failure in case of tabbed YARD-comment-like string

The following ruby code leads to an error:
rubocop -c <(echo "Layout/LineLength:\n AllowURI: true\n Max: 1") --stdin bug.rb --only Layout/LineLength -d <<EOF
  expect(some_exception_variable) {|e| e.url.should == 'http://host/path'}
EOF

(there's a \t in the beginning)
Backtrace:
An error occurred while Layout/LineLength cop was inspecting bug.rb.
undefined method `offset' for nil
lib/rubocop/cop/mixin/line_length_help.rb:76:in `extend_uri_end_position'
lib/rubocop/cop/mixin/line_length_help.rb:44:in `find_excessive_uri_range'
lib/rubocop/cop/layout/line_length.rb:359:in `check_uri_line'
lib/rubocop/cop/layout/line_length.rb:258:in `check_line'
lib/rubocop/cop/layout/line_length.rb:103:in `block in on_investigation_end'
lib/rubocop/cop/layout/line_length.rb:102:in `each'
lib/rubocop/cop/layout/line_length.rb:102:in `each_with_index'
lib/rubocop/cop/layout/line_length.rb:102:in `on_investigation_end'

Before submitting the PR make sure the following are checked:

[X] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[X] Wrote good commit messages.
[X] Commit message starts with [Fix #issue-number] (if the related issue exists).
[X] Feature branch is up-to-date with master (if not - rebase it).
[X] Squashed related commits together.
[X] Added tests.
[X] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!