[SPARK-28096][SQL] Convert defs to lazy vals to avoid expensive output computation in QueryPlans

What changes were proposed in this pull request?
The original output implementation in a few QueryPlan sub-classes are methods, which means unnecessary re-computation can happen at times. This PR resolves this problem by making these method lazy vals.
The overall planning time of TPC-DS was reduced by 9.3% (compared with the optimized version as in https://github.com/apache/spark/pull/24866). The detailed stats are shown in the following figure.

How was this patch tested?
Existing UTs.

Test build #106691 has started for PR 24915 at commit 004c37f.

Can one of the admins verify this patch?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11924/
Test PASSed.

Test build #106691 has finished for PR 24915 at commit 004c37f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106691/
Test PASSed.


Running live on server

Hi There!
This is my first time asking a question, so I hope I'm doing it in the correct way!
It's probably a rather simple one, but I'm actually having trouble getting my AR files to work live? They all work fine (In Firefox) locally, and I've checked and re-checked all my file paths over and over.
I got ONE file that uses A-FRAME to work and show up correctly after getting the security certificate on my domain, but weirdly it seems to work by calling the java from the web, not my folders on the server.
So now I have the "https" sercure server, but the others (using three.js, AR.js, and a-frame) do not show up for me. Is there anything you can think of that I'm missing?
Thanks so much for your help!
Jody

but weirdly it seems to work by calling the java from the web, not my folders on the server.

Can you elaborate on what you mean here?
What does your index.html file, the <script> tags that include those libraries look like?

Hi! Thank you!
Like this:

<!-- include jsartookit -->
<script src="jsartoolkit5/artoolkit.min.js"></script>
<script src="jsartoolkit5/artoolkit.api.js"></script>
<!-- include threex.artoolkit -->
<script src="threex/threex-artoolkitsource.js"></script>

the one file that does work, is the a-frame file, which looks like this:

So I'm a bit confused because they all work beautifully locally, and the a-frame file started working when I activated my SSL cert.
Thanks so much for your help!

@jodyataylor what server are you using? maybe it could be some wrong permits?

Hi!
Yes I had a similar thought - since some of the original files from within
didn't work either.
I'm using go daddy and have the hosting reseller acct to have unlimited
hosting.
And the one file worked when I got my ssl (https)
Thanks so much!
On Sat, May 4, 2019, 12:16 PM Walter Perdan<EMAIL_ADDRESS>wrote:

@jodyataylor https://github.com/jodyataylor what server are you using?
maybe it could be some wrong permits?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jeromeetienne/AR.js/issues/519#issuecomment-489340809,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIWZQMQN4722DP4VBRHWCJ3PTWZEBANCNFSM4HKVUL4A
.

Hi @jodyataylor  have you solved your problem?

I think he got it to work.
The solution is to always run AR.js as a https site.

Actually it is not really solved...
I have different behavior when running locally from
<script src="https://aframe.io/releases/0.9.1/aframe.min.js"></script>
<script src="https://cdn.rawgit.com/jeromeetienne/AR.js/1.7.2/aframe/build/aframe-ar.js"></script>

and different when running from this
<script src="js/aframe.min.js"></script>
<script src="js/aframe-ar.js"></script>

the difference is
when I run from the https the picture slides weirdly over the marker, for Ex: down when the marker looks up ect.
on the second option from file there is good tracking.... but its much slower and brakes

Hm... I do not think that just downloading the files locally would solve the problem.
The thing with aframe and aframe-ar is that they depend on other libraries (I think).
Have you tried to see what the different options show of errors in console?

since i made the upgrade to the  aframe v0.9.2 in this PR #515 see https://github.com/jeromeetienne/AR.js/pull/515/commits/dc6eaefd054066aa9d54d219608817feb764181a
try:
<script src="https://aframe.io/releases/0.9.2/aframe.min.js"></script>
<script src="https://cdn.rawgit.com/jeromeetienne/AR.js/1.7.2/aframe/build/aframe-ar.js"></script>

tell us if it makes any difference.

@kalwalt thank you for the input, this will not change the "sliding" problem, though. Any idea what is the reason for this?
here an example: https://github.com/iggykov/AR/blob/master/IK_AR_test.mov

@iggykov I think it is because the starting point (anchorpoint) for the model is not 0,0,0.
Is it a 3d model?
I assume it is just an image, so I might actually recommend using: https://github.com/rodrigocam/ar-gif

@iggykov did you solve the problem?


NamedItemList: make tab completion for NamedItemList work again

it turns out that an explicit list with all possibilities is required for the REPL tab completion code to show the list of all possibilities (duh!). (The __getattr__() method is obviously implicit, but we still need it to keep mypy happy...)
note that this change doesn't have an effect on scripts because tab completion is a purely interactive thing.
Andreas Lauser<EMAIL_ADDRESS>on behalf of MBition GmbH.
Provider Information

(also note that calling dir(name_item_list) is quite slow and memory intensive. That should not matter though, as these objects are not supposed to contain more than a few thousand items...)


PERMISSION: Use one-way hash of resource URI as unique ID of shared resource

The shared-keys.ttl uses the name of the shared file as a "unique ID" for the corresponding record (with data path, permission list and individual key, all encrypted using the recipient's RSA public key) of the shared file. This will result in the same ID for a file in a different path but with the same filename shared by the same POD.
Including the path of shared file could solve this problem, but it reveals the actual URI of the shared file (the URI can be reconstructed from the parent directory of shared-keys.ttl in shared, named with POD_ORIGIN-POD_NAME). This is problematic because the shared/ folder is publicly readable and writable (for adding/deleting encryption keys when granting/revoking access permissions).
Additionally, encrypt the URI of shared file using the recipient's public key may not work as the cipher text produced by RSA public key encryption is usually not the same (even for the same plain text) in different runs of the encryption. This is due to the randomised padding scheme used in RSA encryption (as described here and here). This can cause problem when granting additional permissions or revoking permissions.
Therefore, a method to create secure and unique ID for a shared resource needs to be developed.

Anushka proposed to use a one way hash, for example, sha256(RESOURCE_URI) as the unique ID of shared resource. And include the encrypted resource URI, the list of permissions, and the encrypted individual key for one shared file.
The advantage of this approach is that we need only a single shared-keys.ttl file in shared/ to store the encryption keys of all shared files (rather than one shared-keys.ttl for each webID that shares files as currently implemented).

Changes are in https://github.com/anusii/solidpod/tree/av/182_use_unique_id_for_sharing_keys
Up for a discussion

With this change, all shared keys will be saved in a single file. Is this ok
Anyone can read this file, but (up to some level) will not be able to extract useful information
Anyone can delete stuff from this file. This is an issue we had previously as well. But not sure how to get around this.

Changes are in https://github.com/anusii/solidpod/tree/av/182_use_unique_id_for_sharing_keys

Thanks Anushka, this is great.

With this change, all shared keys will be saved in a single file. Is this ok

This seems OK to me.

Anyone can read this file, but (up to some level) will not be able to extract useful information

Public Read access seems fine.

Anyone can delete stuff from this file. This is an issue we had previously as well. But not sure how to get around this.

Public Write access sounds problematic.
For example, someone can delete or change the encrypted individual key of the shared file which would prevent the recipient from decrypting the shared file content.
A cumbersome workaround I can think of is using two files in the shared/ folder, both with only Append access for the public (the recipient of course has Write access), and one file stores transactions of granting permissions, the other for transactions of revoking permissions.
To make things slightly easier, the recipient could update both files (e.g. every time they start their app) to remove outdated grant/revoke permission transactions (just like how a database executes the transations in journals in data recovery).
What do you think?

Thanks Dawei for the suggestions. Yes, that could be a work around. However, that makes sharing a bit more complicated and recipient need to update files everytime there is a change. But this seems to be the only workaround at the moment. We could do this in one file instead of two files.

Thanks Anushka. Yes, we could implement the workaround using only one file (for example, by defining permission granting and revoking predicates in our custom ontology).
I tried to capture this discussion and the tasks here https://github.com/anusii/solidpod/issues/193, please feel free to add anything I have missed.

Thanks Dawei. Will check that issue. Closing this as the PR has been merged.


Messaging: Automated newsletter invites to engineers

Context
We just launched automated PostHog for Startups invites for founders via https://github.com/PostHog/meta/issues/121
An idea I proposed in the subsequent marketing sprint was doing similar automation to invite users who say they are engineers to subscribe to the Product for Engineers newsletter. Feedback is welcome.
Goal
More newsletter subscriptions. This is an OKR for Marketing.
Proposal
This would be a simple personal message sent to all users who specify themselves as engineers. The email, which would come from Joe or Andy, would tell users about the newsletter and provide a link to subscribe. That's it.
To prevent this from immediately annoying users or interfering with the onboarding processes, we add this email to the end of the Cloud onboarding flow.

This will only be sent to users who have the Completed_onboarding_emails = true property (added after the campaign is otherwise completed)
The email will only send to users who list themselves as engineers
This email will send at a weekday, 5 days after the onboarding campaign is complete

Alternatives considered
It was suggested in the sprint that we could instead:

Run this as a holdout test and only target a proportion of engineers (@andyvan-ph)
Wait to see how https://github.com/PostHog/meta/issues/121 performed first (@joethreepwood)
Add this to the signup flow somehow instead of relying on email (@charlescook-ph)

However, these each have issues.

A holdout test would limit the reach of the campaign and be more conservative, but wouldn't get us more information. If the idea is to see if users will complain then we should roll out aggressively to find out as fast as possible, so we can act on it. A limited roll out would mean this campaign needs to run for longer to get the result.
https://github.com/PostHog/meta/issues/121 is targeting a different group, with a different incentive so would not be indicative. It's also a small user set, so would take a very long time to reach a statistically relevant result.
@smallbrownbike and I discussed, and quickly determined the potential gain (newsletter subscriptions) was not worth the likely impact to conversion.

Preview

That's a good point. The simplest way would be to trigger an event when a user subscribes, but we can't do that AFAIK.
There's no Zapier integration with Substack, so we can't do an automation to take out the cohort either.
@andyvan-ph any ideas?

Worst case, we could just say 'if you're not already, why not subscribe' but obv that's less smooth

Some ideas, feel free to take or leave any of them:

Should we include a couple of links to past articles?
Would be cool (I think) if it came from Andy and he mentions he writes it.
Idea to add it in product, once someone checks all the onboarding steps? I don't know if everyone gets these or just the first user in org.
Maybe mention: "If you've already subscribed, reply and let us know what you think we should write about next?"

+1 to Ian's suggestions

Should we include a couple of links to past articles?

Sure.
Would be cool (I think) if it came from Andy and he mentions he writes it.

Happy with this. @andyvan-ph want to draft something and post it here? I'll then put it in and set up a Customer.io alias.

Idea to add it in product, once someone checks all the onboarding steps? I don't know if everyone gets these or just the first user in org.

I've actually just put a proposal to include this in the onboarding email flow already. We could put it in the product too, but that's probably a @raquelmsmith call.

Maybe mention: "If you've already subscribed, reply and let us know what you think we should write about next?"

Will let Andy decide for his draft.

I'd like to pass on the in-app component if that's okay :)


Update not working anymore in GH actions

Think it's due to update flag not being forwarded to
gosu user:user /bin/setup_and_run_zwift
@hobeone ☝

See https://github.com/netbrain/zwift/pull/107

Still something wrong with the gh action. Not sure why it's failing. But I'll look into out when I got the time

Can you run gh actions locally to test them out?  I can try to debug as well if so.

https://github.com/nektos/act
but it's probably easier to try to run the container as it's run with the github action.
https://github.com/netbrain/zwift/blob/master/.github/workflows/zwift_updater.yaml

But actually, now that im looking it seems that its caused by the script files you updated has not been update in the container. ( https://github.com/netbrain/zwift/blob/master/.github/workflows/zwift_push.yaml )
This yaml is supposed to update the existing container image with latest script files like the entrypoint.sh and stuff. Actually made a note of this in #99.
So we should really fix #99 which in turn would have fixed this issue aswell after your change in #107

Though it doesn't look like it fixed the update routine :face_exhaling:
https://github.com/netbrain/zwift/actions/runs/8968054365/job/24626741254#step:5:182
Seems like the update flag still isn't being forwarded, and that it just simply runs zwift instead of updating.

Looking into this too as podman is broke so trying to merge better for both docker and podman.

I have done a partial update to here https://github.com/sHedC/zwift but having some issues with persistance and permissions in Podman, working on it.

It's probably working now, closing for now and re-opening if it fails on next release.


Bug - Give PageHeader correct padding when it has no tabs

This class was added to PageHeader, and needs to be removed in these special cases when there are no tabs.
For example,
before:

after:

Reviewer: @mlunoe

this still happens. is this supposed to fix that?

Dammit that's a new different bug haha. One sec

Thanks for checking for me! I should have done that

merging on integration pass


compatablity ? and ?shdoc.md!

shdoc is a documentation generator for bash/zsh/sh for generating API documentation in Markdown from shell scripts source.

shdoc parses annotations in the beginning of a given file and alongside function definitions, and creates a markdown file with ready to use documentation.

give the above quote from readme.md it appears that any language supporting  '# comment '
should work
unless some other reason exist making ssb exclusive to bash/zsh/sh?
... with the above in mind has any consideration been given to

documenting the shdoc awk script !
expanding the stated compatibility to "any language supporting  '# comment ' " ?

I'm not sure I've understood your question.
shdoc does support comments starting with #, and it doesn't support documenting awk scripts.

I'm not sure I've understood your question.

(it would help me clarify if you could explain) what is unclear ?

shdoc does support comments starting with #

it doesn't support documenting awk scripts.

if awk scripts use  '#' comment ( AFAIK it dose )
for what reason(s?) do you consider  awk script's unsupported  ?
eg
you have no interest in supporting other lang with # comment
or no time to support other lang with # comment
something technical ( i have not thought of )

I have not tested it on awk, may be it works fine


[Validation] [twe reports supplied function is not defined]

Describe the bug
TWE Validation warns that my custom validation rule does not exist during every call facilitated by <form data-te-active-validation="true">...</form>
To Reproduce
Steps to reproduce the behavior:

Implement a custom rule in JS using the exact same method given in TWE's documentation:  https://tailwind-elements.com/docs/standard/forms/validation/#custom-validation
Bind the validation to html input field i.e. textarea.
Ensure enclosing form has attribute data-te-active-validation="true".
While viewing web app in browser, open chrome dev tools.
Start type in input field.
View the console.warn message after every keyup stating Rule 'myCustomRule' does not exist.

Expected behavior
Expected behavior is that the twe validation component accurately reports when my supplied validation function is defined or not.
Actual behavior
twe validation component is reporting that custom validation rule does not exist, when in reality it does exist and its being used properly.
Show your code
I could not figure out how to import individual components in the snippet playground
<body>
  <form data-te-validation-init data-te-validated="false" data-te-active-validation="true" id="form-id">
    <div class="relative" data-te-input-wrapper-init data-te-validate="input" data-te-validation-ruleset="isValid" >
      <textarea id="textareaId"></textarea>
    </div>
  </form>
  <script type="module">
    import { Input, Validation, initTE } from 'tw-elements';
    initTE({ Input, Validation });

    function isValid(val,msg,str) {
      return 'no';
    }

    let config = {
      customErrorMessages: { isValid: 'maybe' },
      customRules: { isValid: isValid }  // tried isValid: (val,msg,str) => { ... }; isValid: function(val,msg,str) { ... }; fn.bind(...) ...
    }

    new Validation(document.getElementById('form-id', config))

    // start typing into textarea, twe will output something like such:
    // console.warn('Rule isValid does not exist.')
  </script>
</body>

Desktop (please complete the following information):

OS: Windows 11
Browser: Chrome
Version: 116.0.5845.180

Additional context
The end result is that the validation still correctly validates my input element using given custom rule function.  I've tried every different combination of function declaration i.e. (function func() {} in enclosing scope, inline function() {}, inline lambda, fn defined on class and passing its prop name), and using bind i.e. .bind(this, that, ...) on each one.  I get the same results in every scenario.

If it's a general support question (you just can't figure out how something works), but not an issue with the UI Kit or documentation itself it's better to ask here:
https://github.com/mdbootstrap/Tailwind-Elements/discussions/categories/support-from-community
If it's an idea for a new feature, but you cannot write the code for it yourself, it's better to ask here:
https://github.com/mdbootstrap/Tailwind-Elements/discussions/categories/share-ideas-request-features
If it's general feedback, it's better to post it here:
https://github.com/mdbootstrap/Tailwind-Elements/discussions/categories/kind-words-general-feedback

I remembered the reason why this matters xD.  I'm trying to use the callback for when form validation fails, during the active typing validation, so I can set us that info to update the state of other html elements.  I've added event listeners to the 'invalid.te.validation' event, its only fired after clicking submit, not during active typing input.  However active typing is validation and updating the dom correctly.  Maybe that event is not supported during active typing, I initially thought it was related to the 'custom rule not found' message

Hi!
It looks like the issue is inside the config you are providing. The customRules options need an object with named method (the same for the error message). You can checkout this example, how we are adding a new custom rule to the rule set:

https://tailwind-elements.com/docs/standard/forms/validation/#custom-validation
As of the event for active validation, changed.te.validation should fire everytime input's value changed. Check how it works in this example:
https://tailwind-elements.com/docs/standard/forms/validation/#validation-with-tooltips

@juujisai I believe thats exactly what I'm doing, and thats what I showed in my snippet.  The name of my customRule is isValid.  The config object I'm passing has customRules.isValid
as described in my snippet as well:
    let config = {
      customErrorMessages: { isValid: 'maybe' },
      customRules: { isValid: isValid }  // tried isValid: (val,msg,str) => { ... }; isValid: function(val,msg,str) { ... }; fn.bind(...) ...
    }

    new Validation(document.getElementById('form-id', config))

screenshot for clarify

it is actually using the function isValid that I provided in the config.  Its just reporting that it's not defined, before and after successfully using it

Ok I see what may cause the problem. You are initializing the validation component twice, and the first time, the validation doesn't see the isValid method. You are initializing once with data attribute data-te-validation-init and then again with use of JS new Validation(...). The second one has the ruleset isValid added as an option and the first one does not.
Try removing the data-te-validation-init data attribute and then check if it works like you want to.

yes haha that solves it and answers why my validation always ran twice at a time xD


Update README.md

Updates the docs link to point to a workable domain path

Thank you very much @brandensilva !


Add gunicorn

Hello I have added the --gunicorn option to ga4gh_server. You can also specify the number of worker and if you   want them async (with gevent) or sync.
I think There is some tweak still needed for the --tls option to work with gunicorn, I have not tested it.

Codecov Report

Merging #76 into master will decrease coverage by 0.05%.
The diff coverage is 38.09%.

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   80.67%   80.61%   -0.06%
==========================================
  Files          37       37
  Lines       14553    14573      +20
  Branches     1439     1441       +2
==========================================
+ Hits        11740    11748       +8
- Misses       2336     2348      +12
  Partials      477      477

Impacted Files
Coverage Δ

ga4gh/server/cli/server.py
58% <38.09%> (-12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 089fc76...7399e24. Read the comment docs.


jared/adrian/node test proc macro

Rebase of https://github.com/ockam-network/ockam/pull/1904#pullrequestreview-772885355

@adrianbenavides I think the next logical step would be to use new macro for all tests and examples, then move macro to ockam_node_attribute. What do you think? Do you want to work on it?


Revise enclosure page to include assembly components and BoMs

How do you know it has to be done
The Enclosure page is straight up sad right now. A lot of information on how to put together this build is missing and makes understanding components not directly contained in other assemblies quite difficult.
What has to be done
The enclosure page needs to be expanded to include all components present in the current build outside of what is covered by other assemblies. It should include:

Revised metal enclosure instructions and drawings
A general assembly and/or sectional drawing detailing assembly of the entire unit
Acrylic sheet CAD and drawings (Face Plate, Filter Plate, Pneumatics Tray)
Pneumatics Assembly overview drawing
LOM for any hardware required
Updated Assembly CAD (if possible)

References

Beta CAD (Fusion)
Beta BoM: https://docs.google.com/spreadsheets/d/1i01Zh0hXRvrTphOLACNOmgj-qOsmSzOZ/edit#gid=2003192236
Slack # eng-mechanical channel
Feedback from Edwin/Martin/India from their experience putting it together

Don't forget

[ ] Put the issue in a milestone
[ ] Assign it to one of the projects
[ ] Add appropriate labels
[ ] Mention dependent/blocked issues if any

The scope of this is to encompass the 0.3 enclosed version but not improvements beyond that.

The scope of this is to encompass the 0.3 enclosed version but not improvements beyond that.

Repurposing this ticket as leaping board for some general refactoring of v0.3 CAD and BOM.
Currently we need to tie up these loose ends:

explain choice of hardware, preference for diameters and drivers/heads
move techniques / methods guides to their own directory

3d printing
heat insert installation
acrylic manufacture and modification techniques

add logo decal to enclosure
add main power plug to closure panel
explain optional wiring of blower to interim board (#926)
finish migrating all screws to button head / hex drive
re-import some third-party parts now that we have tacit understanding for CAD use
remove unused third-party parts
make most of electrical assembly part of display panel assembly
pneumatic assembly should now be "internals assembly", with whatever directory restructuring it might precipitate
pneumatic assembly needs more refactoring into sub-assemblies, in CAD as well as in readmes
add newest photo of v0.3 assembly
mention deburring/filing/sanding of sharp corners in enclosure
list bottoming instead of tapered tap for venturi nipples
add some supplier and part number info to parts metadata (depending on feedback from efforts in #1011 )

Most likely will not be tackled here:

sensor tubing CAD
general wiring CAD
tubing clips in CAD
general update of all drawings
replacement of Tygon tubing & fittings in oxygen line (#996)
including cooling fan (#1034)

Most of the CAD modeling content has been addressed through #1035
Remaining issues are captured in:

sensor tubing #1039
main power input #1040
cooling fan #1034
custom elbows #1019
final drawings and exports #1041

This ticket is superseded by the above more granular and better defined tasks.


Folder icons: implement logic

implement the same application logic from file icons to folder icons (in my opinion this seems right, but it's up to you to improve!)
https://github.com/deadlyjack/Acode/blob/506e77aeb8fb0ec998a02c9b7fbfbbc7134724e7/src/utils/helpers.js#L112
if (item.isDirectory) {
  item.icon = this.getIconForFolder(item.name);
 } else {
  item.icon = this.getIconForFile(item.name);
}

getIconForFolder(name) {
  const regex = /* regex */;
  return `icon folder type_folder_${name}`;
};

Does this logic work or is it more difficult than it seems?

https://github.com/sebastianjnuwu/acode-plugins/issues/7


Bug: Files can't copy or move any iso file

Description
Files can't copy or move any iso files.
When I try to copy or move a iso file, Files' move progress will exceed 100% and there is no upper limit.
Steps To Reproduce

Copy or move a iso file to other folder or drive with Files.

Requirements

Let Files can copy or move any iso files and Files' progress won't exceed 100%.

Files Version
Files version: <IP_ADDRESS>, OS version: 10.0.25217.1010
Windows Version
Windows 11 22H2 25217.1010
Log file
debug.log

Thanks for the report. I am unable to reproduce this, Can you give the following information.

Does it give any errors in Windows File explorer?

Thanks for the report. I am unable to reproduce this, Can you give the following information.

Does it give any errors in Windows File explorer?

No, it doesn't.
And the image file isn't .jpg/.jpeg etc. , it's .iso/.img etc.

@Nightingale0504 thank you for reporting this issue, can you check if it's still an issue in v2.5.20?


Deephaven autocomplete

Autocomplete doesn't seem to be working when I call Deephaven methods. Maybe I don't have VS Code configured properly, but all of my other Python libraries work with autocomplete.

@jjbrosnan To get intellisense, you'll need to pip install whatever packages you want to use. A good starting point is:
deephaven-core
deephaven-plugin-plotly-express
deephaven-plugin-ui

You can always just put this in a requirements.txt file in whatever folder you have open in vscode. The standard Python extension (not DH) provides some commands to setup virtual environments, install the requirements, etc.
https://code.visualstudio.com/docs/python/python-tutorial

FWIW, I'm getting a nonzero amount of autocomplete using pip-installed DH.

@jjbrosnan is this still an issue?

@bmingles I have yet to re-test. I probably didn't have something configured properly on my end. I'd never used VSCode to write Deephaven queries before.
This can be closed, especially if it's not an issue anyone else has seen.

Closing as can't reproduce, and seems to be working for other users.


fix: replacing the player does not mean giving up authority

If you replace a player,  the old player should remain attached to the connection.
Following the single responsibility principle,  we should not try to combine these 2 actions in one method.

Test Routines not applicable.

:tada: This PR is included in version 5.1.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Block edge 4.6.0-rc.4

4.6.0-rc.4 needs to be disabled:
2 clusters currently failing (13%),  3 gone (20%),and 10 successful (67%), out of 15 who attempted the update over 7d
Currently failing classification:
* Down nodes: 1
* Node pressure: 1
* SDN issue: 1
* UPI router degraded: 1

4.6.0-rc.4 can be enabled again:
1 clusters currently failing ( 6%),  3 gone (19%),and 11 successful (69%), out of 16 who attempted the update over 7d
Currently failing classification:
* UPI router degraded: 1


Fix custom namespace deploy Role errors in RBAC

Deploying v0.11.0 to custom namespace results in an error:
W0516 23:52:47.169746       1 reflector.go:539] k8s.io/client-go@v0.29.3/tools/cache/reflector.go:229:
failed to list *v1.Job: jobs.batch is forbidden: User "system:serviceaccount:my-namespace:my-deploy-name-v1-controller" cannot list resource "jobs" in API group "batch" in the namespace "my-namespace"

The Role in RBAC should be bound to a namespace, however declaring namespace via serviceAccountMetadata (which gets injected into the Role) is specifically not allowed.
To be honest I'm baffled at how is deploy was supposed to work for users with custom namespace, does everyone deploy to a default namespace or am I missing something? 🤔

Hm, there must have been some error in my setup, I'm now getting namespace added into the Role without this PR.
Apologies for the noise!

Okay, I double-checked and it's the RoleBinding that needs to be fixed, not the Role -> #330


Validate discipline incident codes, improve local data

Who is this PR for?
developers, designers
What problem does this PR fix?
Document expected values for incident codes, for validate and for building features around this.
What does this PR do?
Adds a validation which adds in codes that we see, and also improves the local demo data to use real codes and locations.

@edavidsonsawyer This might help a bit with https://github.com/studentinsights/studentinsights/pull/1502 too.

@kevinrobinson this is great! Where did these come from? Is it a Somerville specific list?

@edavidsonsawyer Yep, these is the aggregate of DisciplineIncident.all.map(&:incident_code).uniq.sort across all data we import in Somerville.  I assume it's a combination of how Somerville defines this, how Aspen supports this, and what DESE requires for reporting, but getting into more details there is probably a conversation for email.  This isn't trying to make realistic distributions or anything, just to make the codes quasi-realistic rather than the placeholder "A", "B", "C" they were before.

Pushed another commit that updates all the specs to now use valid data, and removed the FakeDisciplineIncident class since it and the factory were doing the same thing.


cmd/go: go test cmd/go (without -short) may be failing on Windows

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version devel +e0adc35c Tue May 8 21:15:48 2018 +0000 windows/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
>go env

set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Lubo\AppData\Local\go-build
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\Lubo\go
set GORACE=
set GOROOT=c:\dev\go
set GOTMPDIR=
set GOTOOLDIR=c:\dev\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Windows\T
EMP\go-build598151490=/tmp/go-build -gno-record-gcc-switches

What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
> go test cmd/go -v

cmd/go passes when doing:
src/all.cmd

or:
go test -short -v cmd/go

What did you expect to see?
passing tests for cmd/go.
What did you see instead?
https://gist.githubusercontent.com/neolit123/b48fc27c8be1eb598fb41ce3cb2366f4/raw/06c1e91e076206574f4136a72aa238c3b1df878d/gistfile1.txt
with an older version i used to see this:
*** Test killed: ran too long (10m0s).

full log here:
https://pastebin.com/XNNAKhBW
requested by:
@alexbrainman
refs:
https://github.com/golang/go/issues/24709

Using src/all.cmd will run go test -test.short cmd/go.  What happens if you run go test -short -v cmd/go?  That is, is the problem due to adding -v, or is it due to omitting -short?

It looks from the transcript in the link that there are some failing tests in non-short mode. Unfortunately, that's true, or at least was in May.
I don't see anything in the initial report about a 3-minute failure. Not sure why Brad put that in the title.

updated and rebuild latest master:
go version devel +43530e6b Fri Oct 26 12:37:30 2018 +0000 windows/amd64

go env is same as OP.
go test cmd/go -v
https://gist.githubusercontent.com/neolit123/b48fc27c8be1eb598fb41ce3cb2366f4/raw/8dc9a4c812cc5a6e81c03112768083735afa15ac/october%25202018%2520run%25201
i ran the tests a 3-4 times and it seems to fail at a different location each time.
it prompts for github login in one of the tests and if one does not enters it too fast it can fail with a:
*** Test killed: ran too long (10m0s). error once.`

It's not obvious to me whether tests are still failing on Windows, but I seem to have sent CLs to fix the ones I was aware of.
It seems to me that the appropriate long-term solution is to actually run all of the tests on a builder on a regular basis (#26529), which may require adding or configuring more tools on the builder image (see also #32430).
If specific tests are failing or regressing, please let us know which ones and in what configuration, or just send a CL to fix them. Otherwise, I don't think we need to keep an umbrella issue open.

We are now running the long tests on the windows-amd64-longtest builder, and they are indeed failing (https://build.golang.org/log/1805b0fbce354f6ac6e08ca9196e418cb142171a).
Now that we have a builder that reproduces the failures, we can work on fixing them.


Autodrift support

Summary by CodeRabbit

New Feature: Introduced Autodrift rebalancing to the Kamino SDK, enhancing the software's functionality and providing users with more options for rebalancing.
New Feature: Added new error types to improve error handling and provide more specific error messages, enhancing the user experience by making troubleshooting easier.
New Feature: Updated the CollateralInfo class to include new properties, providing users with more detailed information.
New Feature: Introduced new classes representing different states and types, improving the software's flexibility and adaptability.
New Feature: Added support for the Autodrift rebalance type, expanding the software's capabilities and offering users more choices for rebalancing.
New Feature: Introduced new helper functions to improve the software's performance and reliability.
Note: The Autodrift rebalancing feature is currently disabled and will be enabled in a future update.

As a follow up we should add a test where we create a strategy using the Autodrift rebalance method, update the params and check it works as expected

Releasing it and will follow up with a test fix in the next PR


500 error creating pull request for LFS repo

Gitea version (or commit ref): 1.5.0
Git version: 2.18.0.windows.1
Operating system: Windows Server 2016
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No
[ ] Not relevant

Description
Creating a pull request on a repository that uses LFS produces a 500 error.
Relevant log snippet:
2018/08/21 10:19:06 [...routers/repo/pull.go:839 CompareAndPullRequestPost()] [E] PushToBaseRepo: Push: exit status 1 - batch request: missing protocol: "G:\\GitRepos\\storageteam\\qualificationtools.git/info/lfs"
error: failed to push some refs to 'G:\GitRepos\storageteam\qualificationtools.git'

Pull Request is not created if assigned participant in this moment.

I think there was already issue reported about this

related with #4463, but that issue is merging issue not creating.

I think I've finally found the cause and a workaround:
I suspect that you have git-lfs version greater than 2.3.4 installed on your server and gitea user has a .gitconfig file containing:
[filter "lfs"]
	clean = git-lfs clean -- %f
	smudge = git-lfs smudge -- %f
	process = git-lfs filter-process
	required = true

If you remove that that should act as a workaround.

This is a duplicate of #732


[Driver] Allow passing OutputFileMap directly to the driver

Ignore the temporary directory commit. @DougGregor what do you think about exposing this? It makes it much easier to integrate and we don't have to go through the file system... See usage here: https://github.com/apple/swiftpm-on-llbuild2/pull/13/files#diff-1fd23c67dae9e4e23bfcb0ba11fc59d6R50-R58

sgtm!


Create 0000-01-02-Karthikjpillai.md

What you have accomplished so far

What you have accomplished so far

Its completed


Handle timeouts when trying to load node credentials in editor

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Fixes #2840
Proposed changes
When opening an node/subflow editor dialog that includes credentials, the editor makes a call back to the runtime to get the credential information. If that call takes a long time for some reason, the edit dialog doesn't appear and there is no feedback to the user. The user may get bored and double-click on the node again - kicking off another request to load the credentials.
When the request(s) finally timeout or complete, you then get multiple edit dialogs open.
This PR fixes two aspects of this:

If a node edit dialog is still being built, a second dbl click on a node is ignored. This stops you from getting multiple dialogs open for the same node.
There is now timeout handling for loading credentials.

For the timeout handling, there are two stages to this.

If the request to load credentials takes more than 800ms we first show this notification which includes the spinner to give feedback to the user that something is happening

If the request has not completed after 30 seconds, we show this notification:

And the edit dialog opens without the credential information.
I think the 800ms / 30s timeouts for the two stages are reasonable values to go with. When the user is running locally, the request to load credentials responds instantly so they are never troubled by the notifications.

Coverage increased (+0.04%) to 68.393% when pulling f4c87af5c152f6254c5077abd2d1186634d1440a on credential-timeout into 3a0074d96e21b6ffa68cabe4567f4cf50897bb46 on dev.

Coverage increased (+0.04%) to 68.393% when pulling f4c87af5c152f6254c5077abd2d1186634d1440a on credential-timeout into 3a0074d96e21b6ffa68cabe4567f4cf50897bb46 on dev.


Re-fetch pull request when updating overview page

Whenever the description page is updated, the timeline event data, review data, etc are re-fetched, but the pull request object itself is passed. This is a simple fix to make sure the object is up to date by also fetching it again.
I think ideally though, we would ensure that the passed object isn't stale. The PR object is either from the tree node if the description page is opened from the tree, or from the activePullRequest stored on the PR manager if the page is being opened from the command palette. Both of these data sources easily become state. Whenever a user locally edits the title/description, these don't get updated. Same for whenever a user runs the "Refresh Pull Request" command. Refresh is triggered on the pull request node, which causes its getTreeItem and getChildren methods to be called. In getChildren, all of the changed file data etc. is dynamically fetched, so this gets updated. But getTreeItem just returns the same data the node was constructed from. I don't think we always want to fetch the PR there, since this would un-batch our initial fetching of PRs, but maybe we could scope this to only refresh cases. I'll spend some more time on refresh but I think this fix is straightforward and good to have for now.
Fixes https://github.com/Microsoft/vscode-pull-request-github/issues/728

LG, just a tweak to cut down the indentation a bit
diff --git a/src/github/pullRequestOverview.ts b/src/github/pullRequestOverview.ts
index 17cea5f..5169e09 100644
--- a/src/github/pullRequestOverview.ts
+++ b/src/github/pullRequestOverview.ts
@@ -130,50 +130,52 @@ export class PullRequestOverviewPanel {
 			scrollPosition: this._scrollPosition,
 		});

-		if (!pullRequestModel.equals(this._pullRequest) || !this._initialized) {
-			this._panel.webview.html = this.getHtmlForWebview(pullRequestModel.prNumber.toString());
-			this._initialized = true;
-
-			Promise.all(
-				[
-					this._pullRequestManager.resolvePullRequest(pullRequestModel.remote.owner, pullRequestModel.remote.repositoryName, pullRequestModel.prNumber),
-					this._pullRequestManager.getTimelineEvents(pullRequestModel),
-					this._pullRequestManager.getPullRequestRepositoryDefaultBranch(pullRequestModel),
-					this._pullRequestManager.getStatusChecks(pullRequestModel)
-				]
-			).then(result => {
-				const [pullRequest, timelineEvents, defaultBranch, status] = result;
-				this._pullRequest = pullRequest;
-				this._panel.title = `Pull Request #${pullRequestModel.prNumber.toString()}`;
-
-				const isCurrentlyCheckedOut = pullRequestModel.equals(this._pullRequestManager.activePullRequest);
-				const canEdit = this._pullRequestManager.canEditPullRequest(this._pullRequest);
+		if (this._initialized && pullRequestModel.equals(this._pullRequest)) { return; }
+
+		this._panel.webview.html = this.getHtmlForWebview(pullRequestModel.prNumber.toString());
+		this._initialized = true;
+
+		Promise.all([
+			this._pullRequestManager.resolvePullRequest(
+				pullRequestModel.remote.owner,
+				pullRequestModel.remote.repositoryName,
+				pullRequestModel.prNumber
+			),
+			this._pullRequestManager.getTimelineEvents(pullRequestModel),
+			this._pullRequestManager.getPullRequestRepositoryDefaultBranch(pullRequestModel),
+			this._pullRequestManager.getStatusChecks(pullRequestModel)
+		]).then(result => {
+			const [pullRequest, timelineEvents, defaultBranch, status] = result;
+			this._pullRequest = pullRequest;
+			this._panel.title = `Pull Request #${pullRequestModel.prNumber.toString()}`;
+
+			const isCurrentlyCheckedOut = pullRequestModel.equals(this._pullRequestManager.activePullRequest);
+			const canEdit = this._pullRequestManager.canEditPullRequest(this._pullRequest);

-				this._postMessage({
-					command: 'pr.initialize',
-					pullrequest: {
-						number: this._pullRequest.prNumber,
-						title: this._pullRequest.title,
-						url: this._pullRequest.html_url,
-						createdAt: this._pullRequest.createdAt,
-						body: this._pullRequest.body,
-						labels: this._pullRequest.labels,
-						author: this._pullRequest.author,
-						state: this._pullRequest.state,
-						events: timelineEvents,
-						isCurrentlyCheckedOut: isCurrentlyCheckedOut,
-						base: this._pullRequest.base && this._pullRequest.base.label || 'UNKNOWN',
-						head: this._pullRequest.head && this._pullRequest.head.label || 'UNKNOWN',
-						commitsCount: this._pullRequest.commitCount,
-						repositoryDefaultBranch: defaultBranch,
-						canEdit: canEdit,
-						status: status
-					}
-				});
-			}).catch(e => {
-				vscode.window.showErrorMessage(formatError(e));
+			this._postMessage({
+				command: 'pr.initialize',
+				pullrequest: {
+					number: this._pullRequest.prNumber,
+					title: this._pullRequest.title,
+					url: this._pullRequest.html_url,
+					createdAt: this._pullRequest.createdAt,
+					body: this._pullRequest.body,
+					labels: this._pullRequest.labels,
+					author: this._pullRequest.author,
+					state: this._pullRequest.state,
+					events: timelineEvents,
+					isCurrentlyCheckedOut: isCurrentlyCheckedOut,
+					base: this._pullRequest.base && this._pullRequest.base.label || 'UNKNOWN',
+					head: this._pullRequest.head && this._pullRequest.head.label || 'UNKNOWN',
+					commitsCount: this._pullRequest.commitCount,
+					repositoryDefaultBranch: defaultBranch,
+					canEdit: canEdit,
+					status: status
+				}
 			});
-		}
+		}).catch(e => {
+			vscode.window.showErrorMessage(formatError(e));
+		});
 	}

 	private async _postMessage(message: any) {

Thanks, updated the indentation!


Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0

Hello,
I cant use this tool in a new project.
Just make a new project with: react-native init projectname
And then install the react-native-tor with npm i react-native-tor
After this using : npx react-native run-android
I get this error:
Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/6.2/userguide/command_line_interface.html#sec:command_line_warnings 26 actionable tasks: 19 executed, 7 up-to-date repository\x\android\app\src\debug\AndroidManifest.xml Error:         uses-sdk:minSdkVersion 16 cannot be smaller than version 26 declared in library [sifir_android.aar] C:\Users\x\.gradle\caches\transforms-2\files-2.1\d1b53437b9b544e7ed30bf7073aa64ea\sifir_android\AndroidManifest.xml as the library might be using APIs not available in 16         Suggestion: use a compatible library with a minSdk of at most 16,                 or increase this project's minSdk version to at least 26,                 or use tools:overrideLibrary="com.sifir.tor" to force usage (may lead to runtime failures)
Node version: 15.5.1
Npm version: 7.3.0
ReactNative version: 4.13.1
Windows: 10
Note: if I run npx react-native run-android without installing npm i react-native-tor the project load in the emulator without any problem.

... Suggestion: use a compatible library with a minSdk of at most 16, or increase this project's minSdk version to at least 26

In android/build.gradle around line ~6
minSdkVersion = 16  change it to minSdkVersion = 26

... Suggestion: use a compatible library with a minSdk of at most 16, or increase this project's minSdk version to at least 26

In android/build.gradle around line ~6
minSdkVersion = 16  change it to minSdkVersion = 26

... Suggestion: use a compatible library with a minSdk of at most 16, or increase this project's minSdk version to at least 26

In android/build.gradle around line ~6
minSdkVersion = 16  change it to minSdkVersion = 26

... Suggestion: use a compatible library with a minSdk of at most 16, or increase this project's minSdk version to at least 26

In android/build.gradle around line ~6
minSdkVersion = 16  change it to minSdkVersion = 26


Dangerous delete everything code in github scrap service.

This line is in github_scrap_service.rb
FileUtils.rm_rf(Dir.glob("#{ENV['SCENARIOS_DIR']}/*"))

If SCENARIOS_DIR is not set in your environment, then running this code results in delete/*, which is everything.
Alas all my photos and video of my family are deleted - (and because i had the backup nas mounted it delete all that too). I'm seeing what i can recover from the cloud :-( :-(
Can you please change the code so that it isn't a big giant danger trap.

Can use ./tmp, instead of needing the user to set it.


[GSSoC'23] Added Navbar with styling

Fixes Issue - 138

Closes #138

Changes proposed

Moving navbar with hovering effect on buttons
Link all the buttons
Making them responsive

Screenshots

@sahil-sagwekar2652 please review this pull request


Landing page

Load a landing page with logo and full color before the main app view.

@Ozcino as the logo is not yet done, one could only use a mock-up logo for now. Or?

closed by #21


ALT+ScrollWheel causes loss of focus

Describe the bug
After you zoom vertically, using alt+scroll-wheel, zooming horizontally using ctrl+scroll-wheel doesn't work, until the user clicks in, or pans the graph.
To Reproduce
Press alt and scroll to zoom in/out vertically. Release alt, then press ctrl and scroll to zoom horizontally. => You'd expect the graph to zoom horizontally, but nothing happens.
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();

        }

        private void Form1_Load(object sender, EventArgs e)
        {
            double[] dataX = new double[] { 1, 2, 3, 4, 5 };
            double[] dataY = new double[] { 1, 4, 9, 16, 25 };
            formsPlot1.plt.PlotScatter(dataX, dataY);
            formsPlot1.Render();
        }
    }

Hi @tomwimmenhove
This problem is caused by a system event that causes the control to lose focus on Alt key press.
I maked PR that fix that, but not sure if he deserves to be accepted into the codebase.
If you want a fast solution you can disable main menu of Form in your application by setting Form.ControlBox property to false.
Also, loss of focus occurs on an odd Alt press. Each even Alt press returns focus...

Hi @tomwimmenhove thanks for reporting this, and @StendProg thanks for figuring out the cause of this issue!
@StendProg's solution (#437) fixes the problem on the WinForms control (but it's still present on the WPF control).
An alternative solution here may be to stop using the ALT key. Perhaps CTRL could lock the vertical axis and SHIFT could lock the horizontal axis. Currently SHIFT-click-drag is used to zoom-to-rectangle, but we could give that function to ALT, or even CTRL+SHIFT...
Another alternative option may be to have mousewheel events create call a method to focus the control 50 ms after the wheel event. I'm not sure if this is possible yet. Something like:
Task.Delay(50).ContinueWith(t=> GetFocusAgain());

I think the best long-term solution here is to avoid using ALT in combination with scroll-wheel actions. ALT can be used with click-drag actions because the control maintains focus. Switching the function of ALT and SHIFT for the WinForms and WPF controls is probably the way to go here. The new list of actions is:

Left-click-drag: pan
Right-click-drag: zoom
Middle-click-drag: zoom region
ALT+Left-click-drag: zoom region
Scroll wheel: zoom to cursor
Right-click: show menu
Middle-click: auto-axis
Double-click: show benchmark
Hold CTRL to lock vertical axis
Hold SHIFT to lock horizontal axis

We might want to consider adding CTRL+SHIFT+right-click-drag as a way to zoom without distorting the ratio (something you currently have to set with Configure(equalAxes: true), #306)

In addition to fixing the original issue, CTRL+SHIFT+right-click-drag now zooms evenly (with a fixed axis ratio). This feels really natural, I like it!
Thanks for initially reporting this @tomwimmenhove and @StendProg for your helpful PR and research into message handling.


34834 Listriodon splendens

34834 Listriodon splendens
<EMAIL_ADDRESS>Fri 30/10/2020 21:46
Subject: 34834 Listriodon splendens
Name: Jan van der Made
Email<EMAIL_ADDRESS>Tel:
Fax:
Fast reply reguested: No
Message:
This is the only case when Li. splendens is classified in a superfamily. In the first place Suoides is a typing error: Suoidea. In the second case, because of this, the sole locality from which it is cited does not appear in the main list of this species. In any case, in one list it is Tunggur Moergen and in the other Tunggur WC, or something like that.

Activity
Show details
Write a comment…
indre.zliobaite Jun 28, 2021 10:35 AM
We need to check those localities and their age allocations, there are many that start with Tunggur and some have magnetostratigraphic ages in their comments, but the main age designation is by MN units. This looks suspicious. We'll need to look at this with Liu, she will come to Helsunki in mid July.
Reply • Delete
Lars van den Hoek Ostende Jun 26, 2021 2:20 PM
The problems seems to be solved. There is only one splendens record and it has Suoidea typed correctly. I don't think we can do a lot with the Tunggur remark, if I remember correctly, Tunggur is a formation and not a true locality.
Reply • Delete
indre.zliobaite Nov 12, 2020 9:28 AM
What's the problem?


Update README config documentation to use correct keys for testingbot credentials

At the time of writing, the README says that you can specify your testingbot credentials with the keys key and secret. But the source suggests differently, where those config keys need to be apiKey and apiSecret instead.
In my karma config, specifying my testingbot credentials like so
module.exports = function(config) {
  testingbot: {
    apiKey: "[key omitted]",
    apiSecret: "[secret omitted]"
  }
}

works correctly. Just hoping to correct the docs for the next person who needs these configuration options. Let me know if I missed anything. Thanks!

thanks please sign the CLA and I can merge this

I'd rather not give that much personal info out. I looked for contribution guidelines before opening the PR but didn't find anything. Didn't realize signing the agreement was a requirement.

I can just take your patch an re-create it myself and submit it - I don't
think I can accept a contribution w/o a signed CLA sorry - up to you.
thanks!
On Thu, Jan 21, 2016 at 6:04 PM, Rick Harris<EMAIL_ADDRESS>wrote:

I'd rather not give that much personal info out. I looked for contribution
guidelines before opening the PR but didn't find anything. Didn't realize
signing the agreement was a requirement.
—
Reply to this email directly or view it on GitHub
https://github.com/karma-runner/karma-testingbot-launcher/pull/2#issuecomment-173776852
.

@zzo this repo shouldn't be covered by the the cla.  We just keep it in the org for lrganizationalmpurposes but it's maitained and written by testingbot

great even better!


General Command Improvement and Addition

Added a count for how many servers the bot is in on both invite commands (slash and text)
Uptime command to check how long the bot has been running

@Nathaniel-VFX mind checking then pulling/closing this

Hi getting Some errors when starting the bot try to contact ya on discord but no responses yet  it says cant find you
can i get some help with the errors ?


[AVM Module Issue]:  createDsStorageAccount: take(     'lz-vend-ds-stg-create-${uniqueString(subscriptionId, --Storageaccount name already exists

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Bug
Module Name
avm/ptn/lz/sub-vending
(Optional) Module Version
module subVending 'br/public:avm/ptn/lz/sub-vending:0.1.2' = {
Description
Hi @sebassem @jtracey93, it seems when u run the bicep template to create another subscription, and it vend the rame resource group for networking, then it uses the same storage account name as per the parameters in wrapper module, and that throws error in deployment as name already exists, can we fix it?
https://github.com/Azure/bicep-registry-modules/blob/main/avm/ptn/lz/sub-vending/modules/subResourceWrapper.bicep
createDsStorageAccount: take(
'lz-vend-ds-stg-create-${uniqueString(subscriptionId, deploymentScriptResourceGroupName, deploymentScriptLocation, deploymentScriptStorageAccountName, deployment().name)}',
64
)
}
Error:
The storage account named stgdstwcs is already taken. (Code: StorageAccountAlreadyTaken)

(Optional) Correlation Id
rsg-australiasoutheast-ds | Deployments while creating this rg it throws error

Hi @sebassem  r u referring me to change it here for each time I do a new subscription deployment?
https://github.com/Azure/bicep-registry-modules/blob/d0d07663f75a71099d3ef2683c028e2ce9b3dfec/avm/ptn/lz/sub-vending/modules/subResourceWrapper.bicep#L255
the issue is I am deploying the subscription module and this is part of vending modules in which it creates the default resource groups and try to deploy the storage account in those resource group, and subscription deployment doesn't have parameter defined for storage account.

@NirajCricket It appears you deployed the module multiple times with the same parameters without cleaning up the old deployments. You can either delete the existing deployment or customize the name of the storage account based on your preferred naming convention.

Closing with last comment. @NirajCricket please feel free to reachout if this is not resolved


Use the latest Rubies on Travis CI

Ruby 2.2.8, 2.3.5 and 2.4.2 has been released and these versions are available on Travis CI.

https://www.ruby-lang.org/en/news/2017/09/14/ruby-2-2-8-released/
https://www.ruby-lang.org/en/news/2017/09/14/ruby-2-3-5-released/
https://www.ruby-lang.org/en/news/2017/09/14/ruby-2-4-2-released/

👍


PMID:31563844

loss of mitochondrial DNA

made a synonym of
abnormal mitochondrial genome maintenance

add synonym mitochondrial DNA depletion


how to import css properly

I read official doc and
put
@import "mafs/index.css";
into index.css but
Failed to compile
./src/index.css (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-4-1!./node_modules/postcss-loader/src??postcss!./src/index.css)
Error: Can't resolve 'mafs/index.css' in '/Users/plato/dev/math_tutorial/vector_test/src'
How to import css?

To use the import "mafs/index.css" or @import "mafs/index.css" methods, you need to be using tooling that resolves packages from node_modules (usually webpack, which ships with a lot of React-based tools).
If you're having trouble and just want to get things up and running, you can always try importing the CSS from unpkg:
@import<EMAIL_ADDRESS>

Oh actually, you know what—the docs are out of date. Try doing this instead:
@import "mafs/build/index.css"

OK. path problem solved but
output was
./node_modules/mafs/build/index.mjs 535:23
Module parse failed: Unexpected token (535:23)
File was processed with these loaders:

./node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
|       opacity: opacity,
|       vectorEffect: "non-scaling-stroke",

  ...(svgPathProps?.style || {})

|     }
|   });
should I configure webpack? or babel?

Hmm. This isn't an issue on your end—the final bundle shouldn't contain that syntax. Let me see if I can get this sorted for you shortly.

Go ahead and upgrade to v0.5.1. Should be fixed now :)

Go ahead and upgrade to v0.5.1. Should be fixed now :)

first, thanks for your work!!
I updated package to v0.5.1 but there is another issue
I'm using node version 14 and create-react-app
Failed to compile
./node_modules/mafs/build/index.mjs
Can't import the named export 'Fragment' from non EcmaScript module (only default export is available)


Is there a way to generate files and write them the first time you debug?

Every time you start the app, a TXT will be generated, but there may be no printed information except the environment information.
So I wonder if there is a way to generate a TXT file and input relevant information after the first print information?

Yes.
Check out the Advanced Usage section of the ReadMe. You'll see the recommended way to add your log destinations. Also you'll see that the logAppDetails() method is what outputs the environment information. If you alter the order a bit, you can call logAppDetails() before adding the file destination. That will prevent the generic info from being written to the file. If you then want it to be written later, you can call logAppDetails() again and it will only write to destinations it hasn't already written to.


A few more exception rules

This are the last few exception rules which I like to see in detekt.

seems related to #333

Cool rules thanks for the big work on exceptions :)


Ctrl+Shift should open Terminal with elevated rights

Windows Terminal version and OS Version
Windows Terminal 1.10.2383.0
Windows OS 10.0.22000.0
Other Software
PowerShell 7.1.4
Affected releases: any
Affected OS: Windows 10 (any), Windows 11 (any branch)
Steps to reproduce
applies to

Windows Terminal run via Win+X > Windows Terminal (may not be intended)
Windows Terminal via Windows Search in Start

works as intended
Windows Terminal run pinned on taskbar
Windows Terminal run pinned via Start
for 1. press Win+X > press Ctrl+Shift Left mouse button >Windows Terminal
for 2. press Win Key > search terminal > press Ctrl+Shift and left click on Terminal in the search results
Expected Behavior
Pressing Ctrl+Shift should open Terminal and default shell with elevated rights
Actual Behavior
starts with user rights

notes: I believe this needs to be assigned to Windows Team as PowerShell 7, and cmd do behave the same in Windows 11.
In Windows 10 I remember this to be ok with cmd and PowerShell but Windows Terminal

Windows Terminal run via Win+X > Windows Terminal (may not be intended)

I'm sitting on 10.0.22454.1000, and that looks fixed to me. I'm guessing that's going to be fixed either by the official Win11 release, or in an Insiders update shortly thereafter.

press Win Key > search terminal > press Ctrl+Shift and left click on Terminal in the search results

This definitely doesn't work with the Terminal in Windows 10, nor does it work with any shell in conhost either.


python3Packages.tinydb: 3.14.1 -> 4.1.1

Motivation for this change

Fix license
Update version
Update homepage & URL links
Disable on python2.7 (no longer supported).

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Builds with python 3.6 to 3.8 and passes tests on NixOS. Thanks @drewrisinger.

Yeah, looks pretty good, thanks!
Result of nixpkgs-review pr 98104 1

2 packages built:

python37Packages.tinydb
python38Packages.tinydb


Documentation and improve performance by preparing

Current documentation states in multiple places improve performance by preparing.
Is this some upcoming functionality that is not available yet with the latest release or I am just missing how it should be done?

@telemmaite that's indeed not yet in the latest release.
On master (and in the next release), there is a pygeos.prepare function that does this: https://pygeos.readthedocs.io/en/latest/creation.html#pygeos.creation.prepare

@telemmaite that's indeed not yet in the latest release.
On master (and in the next release), there is a pygeos.prepare function that does this: https://pygeos.readthedocs.io/en/latest/creation.html#pygeos.creation.prepare

Thank you ! Looking forward to the next release, you have done great job!

Thank you ! Looking forward to the next release, you have done great job!


Is there an easy way of viewing the persisitant hive variables in Android Studio?

Is there a way to view all the currently stored Hive box variables in Android Studio or any editor?
I have many hive boxes with all types of data being stored and if there was a way to easily view all the data somehow during development in a window, that would be great.

Currently not. I will eventually create a tool or plugin to view the content of boxes (maybe using Facebook's flipper, but this does not have a high priority currently.

Cant you View your contents of a Hive box in Hive Studio ?


Yahoo title parsing improving

I noticed that title of Yahoo is extracted incorrectly:
URL: https://gist.github.com/soxoj/9d65c2f4d3bec5dd25949197ea73cf3a
Title: gist.github.com › soxoj › 9d65c2f4d3bec5dd25949197eamaigret.ipynb · GitHub

Title should be maigret.ipynb · GitHub
I did some fixes form my other project here

Nice catch! I fixed it with bs4's .decompose(), but I'll keep this open in case there is more work to be done


Amd module

prettyselect exposes herself as an amd module if inside an amd ecosystem

I didn't know she was a girl :O
Congrats!


url longclaw_basket occur error

longclaw version: last
Django version:  (1, 10, 8, 'final', 0)
Python version: 3.6.4

When paste in template {% url 'longclaw_basket' %}
Error: Reverse for 'longclaw-basket' with arguments '()' and keyword arguments '{}' not found. 0 pattern(s) tried: []
How fix it?

@Wladislav
You need to make sure you have a template for the basket. This should be in longclawbasket/basket.html in your templates directory.
Relevant docs:
http://longclaw.readthedocs.io/en/latest/walkthrough/basket.html

Closing - Can't reproduce


Fix docker push

Signed-off-by: Julien Pivotto<EMAIL_ADDRESS>

:+1: but I have no idea about any of this :)

It can't hurt, we can revert if needed


feat(contracts): adds test coverage

Adds tests coverage for contracts
Ref: https://rsklabs.atlassian.net/browse/ROLLUP-374
I was unable to verify that it runs correctly, but once. Since “re-yarned”, I am getting the following error:

I suspect a dependency version change issues.

Due to some issues we had with the repo dependencies, we're not going to measure code coverage of the contracts for now.


fix: Modified tests to use runner_features

Tests are updated to use runner_features, this allows the tests to support multiple lightning implementations at the same time.

I do not know if the runner_feature inside the init message will change the meaning of the test, so I need to think more about it

Please see https://github.com/lightning/bolts/pull/1095

What is the status of this PR?
Can you rebase and see if the CI will pass now? there is a conflict to be resolved

What is the status of this PR?
Can you rebase and see if the CI will pass now? there is a conflict to be resolved

Sure


String in deployment template

Please provide us with the following information:

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [x] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

launch template on Visual Studio

Any log messages given by the failure

There are errors in deployment json file: data.modulesContent.$edgeAgent['properties.desired'].modules['camera-capture'].settings.createOptions should be string
Expected/desired behavior

To upload correctly

OS and Version?
Linux 19.0 and Visual Studio Code (Jan 2020 release)
Versions

Mention any other details that might be useful
I think you need to make the details like this...
"{\"HostConfig\":{\"PortBindings\":{\"5012/tcp\":[{\"HostPort\":\"5012\"}]},\"Binds\":[\"/dev/video0:/dev/video0\"],\"Devices\":[{\"PathOnHost\":\"/dev/video0\",\"PathInContainer\":\"/dev/video0\",\"CgroupPermissions\":\"mrw\"}]}}"
Or something that works and looks nice (very hard to see what is going on in that string). Also I think the file needs to be in a folder named config.

Thanks! We'll be in touch soon.

Hey @PeterHedley94,
Did you use the deployment.template.json file or the deployment.json one? You should start from the deployment.template.json file and generate the deployment.json file from there (using right click > generate manifest) and then use the deployment.json file to make your deployment (right-click > create deployment for single device)

Thank you, new to iot edge and visual studio extensions. Closing now as is not a bug.


[Docs] Views: Location path

In the example for rendering ecr views on http://kemalcr.com/docs/views/ the path to the view is specified as views/hello.ecr.
I followed the example, created my_app/src/views and put hello.ecr there. When you try to build from the project root, following the example on http://kemalcr.com/docs/getting_started/, this won't work because the path needs to be src/views/hello.ecr.
I didn't just fixed this in case I did something wrong. So, am I right? xD

Yeah you are right. In that example the view folder doesn't reside in src.
Putting the folder inside src is the correct way.


Updated usage of $http to use promises instead of deprecated success …

…callback method
Also switched to the Chrome launcher in Karma because the PhantomJS launcher kept timing out and I didn't take the time to fix that yet.

@CodeCharm, can you undo the tab change so I can see what changed?

Sure. On it now.

Okay, that should be a little cleaner. I tried to rebase (squash) the commits, but I have not reached that level of git ninja.


Missing protos types

Environment details

OS: macOS (12.6)
Node.js version: v16.16.0
npm version: 8.11.0
@google-cloud/firestore version: 6.0.0 and 6.3.0
Typescript: 4.7.4

Steps to reproduce
Unlike some other @google-cloud/ client libraries, this one doesn't appear to export protos. Some types are completely inaccessible because of this.
Example
import { v1, protos } from '@google-cloud/firestore'; // Would be great to have protos access here

const client = new v1.FirestoreAdminClient();
const someOpName = '<insertSomeOpName>';
const resp = await client.checkExportDocumentsProgress(someOpName);

// Despite `checkExportDocumentsProgress` having the following type signature:
//
//   checkExportDocumentsProgress(
//     name: string
//   ): Promise<
//     LROperation<
//       protos.google.firestore.admin.v1.ExportDocumentsResponse,
//       protos.google.firestore.admin.v1.ExportDocumentsMetadata
//     >
//   >;
//
// Typescript is believes the metadata type is the generic interface Metadata:
//
//   error TS2339: Property 'outputUriPrefix' does not exist on type 'Metadata'.
//
// So it would be great if we can provide this type hint to avoid this issue.
// But 'protos' is not exported so I'm not sure how to access this type.
const meta: protos.google.firestore.admin.v1.ExportDocumentsMetadata = resp.metadata;

Thank you for the suggestion.
I brought this up for team discussion, and will let you know whether this is a change we want.
I am a little concerned about calling Firestore service with gRPC directly. Is there a reason you aren't using the SDK? Some Firestore protos have fairly complicated semantics, so I am of the opinion that calls should be made through SDK to avoid this trouble. I would rather we improve SDK.

Thank you for the prompt response!

I am a little concerned about calling Firestore service with gRPC directly. Is there a reason you aren't using the SDK?

I don't think I quite understand -- the snippet I shared does use the SDK. This proposal is to expose the type so that Typescript can use the correct type (I've had to resort to an as any cast to access outputUriPrefix without Typescript complaining).
If there's a better way to satisfy Typescript without exposing the protos definitions, that would be great as well!

The SDK I am referring to is the const firestore = new Firestore(...) client.
https://github.com/googleapis/nodejs-firestore#using-the-client-library
But after looking a little closer, I realize, the admin protos aren't covered by the SDK.
The gRPC client that you are using is simply generated from the published protos found here: https://github.com/googleapis/googleapis/tree/master/google/firestore/admin/v1
You could roll your own.
In the meantime, I will see if we can better expose the admin protos you are referencing.

Use:
import { Metadata } from 'google-gax';

Then you can write:
let metadata: Metadata | null = resp.metadata;


[GEARPUMP-171] Fix some typos

GEARPUMP-171
Fix some typos

Thanks, I'll hold this till we release 0.8.1

+1

Sorry it took so long.


[BEAM-8937] Add Jenkins job definitions for GroupByKey Java load test on Flink

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.


aligned sample ini's

Can we change the model numbers in both files to 14g?

we have another bug to change the server models

I know.  Just figured we might get em both knocked off in one PR.  Your call.


Default language for quests always English

Not tested, but a code review suggests this is bugged in 1.4.2

Will look at this later - should have put in more detail as to what the issue is!

I think this can be closed.


HTML layout "example" padding on left missing

See: https://www.calendarstandards.org/standards/csd-calspam-bcp.html
A little too close to the left border now.

Your commit on isodoc, https://github.com/riboseinc/isodoc/commit/b735a7178a4d4f4a051982508d9d7c6371bda460, removed "padding:.75pt .75pt .75pt .75pt" from the inline styling of example_label. I'm going to put it back in, that will address it.

Making it padding:0 0 0 1em


refactor: move catalog into a datafusion extension

So this ended up being a bit trickier than the session vars.
The context is used within async/await a lot more than the vars were & caused the parking_lot::RwLock to not work. I had to swap it out with the tokio::sync::RwLock which unfortunately causes all read/write actions to be async. This caused qquite a ripple effect as all dependent function calls in the stack also had to be converted to async/await.
I also added a small example exec CreateTableExec, it's not fully wired up yet, but it does show that we can mutably access the catalog & session vars from the exec now!
you can test it out by swapping out the planner in sqlexec/src/session.rs:create_physical_plan for the extension aware planner.
There's a few small todo's & unwraps left in here, but I think the bulk of the work is ready for review.

I made a change that splits out the metastore client from the session catalog and puts it in a struct called CatalogMutator. We can stick that on the datafusion context.

closed in favor of #1607


FS-2119: Redirect after comment creation

After submitting a comment, we return a redirect to the route so it re-fetches the comments

@tferns this would be a good use-case for a flash message in addition to the redirect https://flask.palletsprojects.com/en/2.2.x/patterns/flashing/

@tferns this would be a good use-case for a flash message in addition to the redirect https://flask.palletsprojects.com/en/2.2.x/patterns/flashing/

Oh good idea! I know there was some talk of showing feedback when a user had commented so I'll see if I can fish out the story later today and whip something up

@tferns we probably should also redirect to a comments area anchor, else it may not be obvious to the user why they've been redirected, especially without any flash message.

@tferns this would be a good use-case for a flash message in addition to the redirect https://flask.palletsprojects.com/en/2.2.x/patterns/flashing/

@gidsg  I'd implemented these changes here: https://github.com/communitiesuk/funding-service-design-assessment/pull/124
Although Peter has asked design and confirmed no longer necessary, so have closed the PR


Mangle SILBoxTypes with their layout.

Use a new mangling scheme that describes the layout of compound boxes.

@swift-ci Please test

@eeckstein I haven't yet built up an intuition for what constitutes an unambiguous mangling in the new postfix scheme—do you mind reviewing my work here to verify that it makes sense? Also, is there any easier way to mangle a TypeList than building a TupleType first?

@swift-ci Please smoke test

@swift-ci Please smoke test

Can we prove the postfix scheme is unambiguous? By making and validating a DFA or something?

@jrose-apple There are 2 things to prove:

each operator has to start with a unique character. This is implicitly "proved" by the big switch-statement in Demangler::demangleOperator()
we must know when an operator ends (in case an operator consists of multiple characters). This is something we have to check for each operator

Ah, I meant for the whole mangling. The existence of a demangler ought to be proof of that but our actual demangler is more complicated than just a parser generator, so it's not enforced.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test OS X


README has misspelled word

I found misspelled word in README.md file.
In 'How to use' section,
below line has misspelled word at the end of line; buil.gradle

If you prefer it, you can use the grade dependency, you have to add these lines in your buil.gradle file:

Request to change word like below

build.gradle file

fixed in #109. Waiting for merge.


Optimize _double_var

Save 1 _fe_negate
Prefer operations on local variables
Reorder code somewhat to group inline function calls together

I am definitely looking for others to test this one. I measure up to 1% improvement for bench_verify, but of the three things I listed above, the "reorder code" measures as the most significant, so it's possible I have only optimized for my machine/compiler somehow.

This results in a measurable 0.2% slowdown for me...

@sipa I'll re-test when I get a chance.

@sipa Well, I still see a difference (bench_verify), but it's smaller now, ~0.2us/55us. Since it's inconsistent at best... closed!


Support Hexadecimal String Literals

Examples of usage are at https://dlang.org/changelog/2.108.0.html#dmd.hexstring-cast.

Looks reasonable, although DMD 2.108 is not yet released.  I'll probably trail the release a little bit on these new extensions.

So I think hex strings are much older than 2.108, but 2.108 added the suffix.  Somehow this was missed in my original work.


Add discord server to readme

Per https://github.com/OpenBMB/ChatDev/issues/91

LGTM, can we merge?

Thank you very much for your suggestions and support😊! However, due to our busy schedule in the near future, we are not maintaining the Discord community for the time being, so we intend to include this PR in the next phase of the program first, please stay tuned.


Factorize validators

Problem:
All the validators have the same code, they apply the ad hoc validation function and collect/throw the errors:
if (!this.isValidWhatever(data)) {
  const errors = this.isValidWhatever.errors as DefinedError[];
  throw this.validationErrorFactory.from(errors);
}

We also have to implement the same tests for every validator. This generates a lot of duplicated code with zero benefits.
Proposed solution:
This PR aims to simplify a bit the validation logic by introducing a SimpleValidator (name open to suggestions, other options could be GenericValidator or ItemValidator) which encapsulates the common code and tests. This makes creating a new validator an even simpler process: the developer just have create an AJV schema, build the related ValidateFunction and call this SimpleValidator.

Coverage increased (+0.1%) to 91.882% when pulling 205e0b2360dfa76d2d467caa92e750da34a25a97 on factorize-validators into eaf9e1589edf8d854d49c7ee7cdcc29c9bf8902a on main.

We also have to implement the same tests for every validator. This generates a lot of duplicated code with zero benefits.

Curious about the reason you mention this. We should treat validators as a black-box and every entity should have different ways to be validated. Therefore the tests should not be the same as we should test with different inputs (json payloads) and check if the validator is working or not.

We also have to implement the same tests for every validator. This generates a lot of duplicated code with zero benefits.

Curious about the reason you mention this. We should treat validators as a black-box and every entity should have different ways to be validated. Therefore the tests should not be the same as we should test with different inputs (json payloads) and check if the validator is working or not.

I think that the idea here is group the common validators, because it's true that now we have repeated code, the unique difference is the schema that we use.
I would prefer GenericValidator.
Regarding the tests, I agree with @fmrsabino I would prefer test every schema.

We also have to implement the same tests for every validator. This generates a lot of duplicated code with zero benefits.

Curious about the reason you mention this. We should treat validators as a black-box and every entity should have different ways to be validated. Therefore the tests should not be the same as we should test with different inputs (json payloads) and check if the validator is working or not.

Hmm, I kind of agree we have to see the validators as black boxes, but I think we don't have to test them with different inputs. I'd say we could test they use the expected schema (something that could be added to this PR) but we don't need to test that the validator behaves as we expect for every input payload combination.
For me that would be entering into a rabbit hole where we have to test a multiple input combinations and, in the end, we would be testing AJV itself.

Regarding the tests, I agree with @fmrsabino I would prefer test every schema.

I did this in the past and I wasn't happy at all with it. At the end you are testing that AJV (Joy or whatever validation library you're using) works. That should be covered by AJV tests, not ours. Imagine implementing a persistence layer where you define persistence models and you test the DB throws an error when you send the incorrect data type. Which is the value of those tests? For me this is the same.

I added a test to every validator to check the correct schema is used in 3234b5ac
I renamed SimpleValidator to GenericValidator ad @moisses89 suggested 👍 (153d146)

Hmm, I kind of agree we have to see the validators as black boxes, but I think we don't have to test them with different inputs. I'd say we could test they use the expected schema (something that could be added to this PR) but we don't need to test that the validator behaves as we expect for every input payload combination.
For me that would be entering into a rabbit hole where we have to test a multiple input combinations and, in the end, we would be testing AJV itself.

I disagree that we would be testing AJV with this. Testing AJV would mean that given the schema that we provide it generates correct validation functions for the schema.
We would instead be testing if our validation rules (AJV or not) work as expected:
1. Given Payload X
2. Validate X (can be AJV or any other solution)
3. Is X valid or not

The goal of this testing scenario is not to test AJV but to test that we have the correct validation rules in place. Because we know what is successful and what is an error case. Testing each combination is however quite cumbersome and we'd need some kind of factory to generate multiple distinct payloads.
If we replace AJV with any other solution and while migrating we change one of the rules by mistake we wouldn't be able to catch that rule change.
However, we can cover some of these scenarios on the bigger Unit tests that we have that cover every layer:
1. Given that service X returns Y
2. The CGW returns Z

I think in the end we should also re-evaluate the value that we are getting from the tests that we introduce – if they are too tied to the implementation then we will always be rewriting and adjusting these tests as the application grow.

Hmm, I kind of agree we have to see the validators as black boxes, but I think we don't have to test them with different inputs. I'd say we could test they use the expected schema (something that could be added to this PR) but we don't need to test that the validator behaves as we expect for every input payload combination.
For me that would be entering into a rabbit hole where we have to test a multiple input combinations and, in the end, we would be testing AJV itself.

I disagree that we would be testing AJV with this. Testing AJV would mean that given the schema that we provide it generates correct validation functions for the schema.
We would instead be testing if our validation rules (AJV or not) work as expected

Hmm, I get your point here as well. For me this is a thin line between testing our logic and testing the dependency itself. AJV does more than "given the schema that we provide it generates correct validation functions for the schema", it also actually validates the data using that validation function. So testing the validation function works as the schema tells it to work, seems more a test for AJV. But as I said I get your point, because it could be useful to check the schemas we write are actually accepting/rejecting some random payloads.
I think this could be useful and for me as you said a broader test (controller tests as we have now, or real end-to-end tests in CI in the future) could be a good point to implement this checks.

...Testing each combination is however quite cumbersome and we'd need some kind of factory to generate multiple distinct payloads.
Property-based testing tools could help with this I think, but maybe it's too much for a hopefully simple client gateway like this.

If we replace AJV with any other solution and while migrating we change one of the rules by mistake we wouldn't be able to catch that rule change.
True! Except if the other technology implements JSONSchema as well.


exclude more false positive cases with constant propagation

Codecov Report

Merging #33 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   73.69%   73.72%   +0.03%
==========================================
  Files          10       10
  Lines         707      708       +1
==========================================
+ Hits          521      522       +1
  Misses        186      186

Flag
Coverage Δ

#unittests
73.72% <100.00%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/abstractinterpreterinterface.jl
86.36% <ø> (ø)

src/abstractinterpretation.jl
96.87% <100.00%> (+0.02%)
:arrow_up:

src/reports.jl
93.52% <100.00%> (ø)

src/tfuncs.jl
94.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec7505...52a7335. Read the comment docs.


Update cloud.google.com/go and OTel dependencies

I need to update these to address https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/issues/864.  I'm doing it in a separate PR to minimize the diff.

I've isolated the user-agent problem to https://github.com/googleapis/google-cloud-go/pull/10402

Blocked by https://github.com/googleapis/google-cloud-go/issues/10550

The workaround proposed in https://github.com/googleapis/google-cloud-go/issues/10550#issuecomment-2229415546 works.

Test coverage failure tracked here: https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/issues/865
This should be good to go otherwise


When creating a user, do not persist the user on invitation sending failure

See https://github.com/BookStackApp/BookStack/issues/3174
What this PR do:

Wrap the user creation process in a transaction
Add test

Thanks for this @Julesdevops and extra thanks for covering with some tests!
All looks great and seems to work wonderfully when manually testing. Will merge for next patch release.


Update Swagger/OpenAPI for the 1.0 release

We need to update the Swagger/OpenAPI for the 1.0 release.

Closing this as a duplicate of #354


Move oneDNN Graph python bindings

Move oneDNN Graph python bindings to avoid CMake changes.
And pass PyObject module pointer to bindings instead of pybind11::module for fewer changes in stock PT

Hi @jgong5, can you please help review this PR? Thanks!

Thanks for reviewing this PR, @jgong5! :)
@chunyuan-w @Xia-Weiwen, can you please help land this PR? Thanks!

@sanchitintel is this API used in stock now? May I know if IDEEP_VERSION_REVISION needs to be updated similar to https://github.com/intel/ideep/pull/311?

Hi @chunyuan-w, I plan to use it in https://github.com/pytorch/pytorch/pull/126740.
I updated IDEEP_VERSION_REVISION. Thanks!

Another small tip to mention for the PyTorch PR: not sure if you're aware of the below practice: https://github.com/pytorch/pytorch/blob/a379ed6e98fe91b1b41ce4c7e0916f6ad1faea02/aten/src/ATen/native/quantized/cpu/qconv_prepack.cpp#L380-L386
You'll need ideep version check in PyTorch code if using new APIs.


Is the sentence "All resources created in Azure are distributed across multiple geographical regions around the world. " correct ?

Hello,
under "Locations" is written: "All resources created in Azure are distributed across multiple geographical regions around the world."
That implies all resources gets distributed across regions always. That sounds not right to me, but i am unsure about the statement, and it confuses me.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ae844bb3-d0eb-4b74-b06f-bb405cf6b910
Version Independent ID: 6187bbaf-e595-73cc-e2b2-7643d7a4d6e6
Content: Overview of Linux VMs in Azure - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/overview.md
Service: virtual-machines-linux
GitHub Login: @cynthn
Microsoft Alias: cynthn

Thanks for the doc feedback, I've assigned this to the doc author to take a look.


[Bug] Effects which are emitted in background can be missed in Compose

Preconditions:
There are two ElmFragments which are only container for Composable functions. Subscribe to Flow(Effect) with effects extension inside Composable fun.
Steps to reproduce:

Open Fragment1 and navigate to Fragment2. Fragment1 subscribes via Actor to some data-holder.
Trigger an event in Fragment2 which perform some work and update the data-holder from previous step.
Reducer1 received event from Actor and produce effect, while Fragment1 is paused.
Fragment2 is closed and Fragment1 didn't get effect.

IMPORTANT NOTE
It's related only for Flow. Due to research, I found that ElmScreen always subscribes to effects when Fragment is resumed. Since we manually subscribes to effects, this behavior broke the logic.
CoroutineScope inside Composable starts later than Fragment is get resume state, so ElmScreen consume effects but it shouldn't.

Hello. Do you have a working sample, reproducing this issue?


howto configure prefix in require.register

Hi,
I guess this is not a bug but a misunderstood of brunch.
I have the following structure of files (can't change it)
root/
|+ app/
|++ component/
|+++ srcClient/ (js source files)
|++++ foo/
|++++- index.js
|++++- moduleX.js
|++++- …
|+++ public/ (js compiled files)
|+++- foo.bundle.js

And I would like to see in foo.bundle.js a require.register('foo', …) instead of actual require.register('component/srcClient/foo', …)
I tried changing root like this in config
  paths : {
    public : 'public',
    watched : 'srcClient',
    root : 'app/component'
  },

But it throws
Error: undefined of Error: ENOENT: no such file or directory, open '../../brunch-config.js' failed.
  at /usr/lib/node_modules/brunch/lib/fs_utils/file_list.js:194:26

Is this error normal and is exists a way to achieve what I want to ?
If not, I guess I have to write my own post-compile plugin to do my actual sed -i -e "s@require.register('component/srcClient/@require.register('@g" public/*.bundle.js after each brunch build. Is there an example somewhere to show how ?
Thanks a lot for any clue

Reading the doc I understood that path.watched should be removed from modules names, but in my case it isn't, I don't find why but thanks to https://github.com/brunch/brunch-guide/blob/master/content/en/chapter07-using-brunch-on-legacy-code.md I have a workaround with :
  paths : {
    public : 'app/component/public',
    watched : 'app/component/srcClient'
  },
  files: {
    javascripts: {
      joinTo: {
        'foo.bundle.js': ['app/component/srcClient/foo/*.js'],
        …
      }
    }
  },
  modules : {
    nameCleaner : function (path) {
      return path.replace('app/component/srcClient/', '')
    }
  }


Fix for missing content-length header when using QUIC

Since some chrome releases or quic clients are not sending the Content-Length
in the request headers, caddy should re-calculate content-length by the body and fix it.
This fixes a potential issue where FastCGI POST requests body empty when QUIC is enabled. (#1370)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

now I figured out where the problem comes from, creating a patch for it.


ERROR: /apollo/modules/dreamview/backend/BUILD:5:1: C++ compilation of rule '//modules/dreamview/backend:backend' failed (Exit 4)

Hi guys,
Now I install ubuntu16.04 virtual machine on Mac, and do the software installation followings Appllo docs, then I try to build apollo sourcecodes  and encounter build failed as follow :
bash apollo.sh build --local_resources 2048,1.0,1.0
�
System check passed. Build continue ...
[WARNING] ESD CAN library supplied by ESD Electronics does not exist. If you need ESD CAN, please refer to third_party/can_card_library/esd_can/README.md.
Running build under GPU mode. GPU is required to run the build.
[INFO] Start building, please wait ...
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling
Extracting Bazel installation...
.
____Loading package: modules/prediction/container/obstacles
____Loading package: modules/control
____Loading package: modules/perception/obstacle/camera/detector/common
____Loading package: modules/perception/obstacle/camera/interface
____Loading package: third_party/can_card_library/hermes_can
____Loading package: modules/planning/toolkits/optimizers/qp_spline_path
____Loading package: modules/localization/msf/local_tool/data_extraction
____Loading package: modules/monitor/hardware/can
____Loading package: modules/perception/tool/offline_visualizer_tool
____Loading package: modules/planning/common
____Loading package: modules/perception/traffic_light/reviser
____Loading package: modules/drivers/camera/common
____Loading package: modules/planning/toolkits/optimizers
____Loading package: modules/guardian/common
____Loading package: modules/perception/proto
____Loading package: modules/planning/planner/navi
[INFO] Building on x86_64...
[INFO] Building with --jobs=2 for x86_64
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling
INFO: Found 1811 targets...
ERROR: Error during action cache initialization: Failed to load filename index data. Corrupted files were renamed to '/home/lx/.cache/bazel/_bazel_lx/540135163923dd7d5820f3ee4b306b32/action_cache/*.bad'. Blaze will now reset action cache data, causing a full rebuild.
ERROR: /apollo/modules/dreamview/backend/BUILD:5:1: C++ compilation of rule '//modules/dreamview/backend:backend' failed (Exit 4).
gcc: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-4.8/README.Bugs> for instructions.
INFO: Elapsed time: 1054.926s, Critical Path: 56.50s
[ERROR] Build failed!
[INFO] Took 1082 seconds
lx@in_dev_docker:/apollo$ cd modules/dreamview/backend/

try to replace  --local_resources 2048,1.0,1.0 with --local_resources 2048,.5,1.0

@muleisheng
Thanks for your help, build successed by your suggestion


Is there an event we can listen for when text tracks are enabled/disabled?

When text tracks are enabled/disabled, their 'enable' property is toggled but it doesn't seem like any event is firing that can tip us off that there has been an update to the track object. Is this correct?

Sorry for the delay in my reply.  That's correct, there are no events for this at the moment.
Any change in enabled text tracks either driven through your app, in which case you already know, or it's done through the built-in controls in the browser, in which case there is no native event and we would have to poll to discover this for you.
I don't think polling HTMLTrackElement.mode is something I want to do right now.  Do you have any ideas for other ways we could solve this?

Since there's no better options on the table other than polling, I'm going to close this.  The same polling could be done at the app level if desired.