Suggestion from Performance/BlockGivenWithExplicitBlock is often slower

Performance/BlockGivenWithExplicitBlock provides bad guidance and should be removed. The benchmark which was given when it was introduced didn't test the case that a block was given, when that happens block is significantly slower than the other option.
For Ruby 3.2+ I made if block faster, but prior to that the advice from this cop was always wrong. Even in 3.2+ I believe it's bad advice as there's only a very narrow usage for which block is (very slightly) faster, and even in those cases it's likely a future refactor the user will accidentally introduce the slow case (ex. moving from if block to if block && something_else)
require 'bundler/inline'

gemfile(true) do
  gem 'benchmark-ips'
end

def if_block(&block)
  !!block
end

def if_block_given(&block)
  !!block_given?
end

Benchmark.ips do |x|
  x.report('block')                  { if_block }
  x.report('block w/ block')         { if_block {} }
  x.report('block_given?')           { if_block_given }
  x.report('block_given? w/ block')  { if_block_given {} }
  x.compare!
end

Warming up --------------------------------------
            block     1.612M i/100ms
   block w/ block   508.391k i/100ms
     block_given?     1.309M i/100ms
block_given? w/ block
                         1.068M i/100ms
Calculating -------------------------------------
            block     15.804M (± 1.8%) i/s -     79.000M in   5.000346s
   block w/ block      5.017M (± 0.5%) i/s -     25.420M in   5.067106s
     block_given?     13.297M (± 1.7%) i/s -     66.746M in   5.021282s
block_given? w/ block
                         10.745M (± 0.6%) i/s -     54.450M in   5.067787s

Comparison:
            block: 15804072.8 i/s
     block_given?: 13296844.8 i/s - 1.19x  slower
block_given? w/ block: 10744860.7 i/s - 1.47x  slower
   block w/ block:  5016692.5 i/s - 3.15x  slower

To be fair, the assumption is that with block_given? you can often avoid declaring &block:
require 'bundler/inline'

gemfile(true) do
  gem 'benchmark-ips'
end

def if_block(&block)
  !!block
end

def if_block_given
  block_given?
end

Benchmark.ips do |x|
  x.report('block')                  { if_block }
  x.report('block w/ block')         { if_block {} }
  x.report('block_given?')           { if_block_given }
  x.report('block_given? w/ block')  { if_block_given {} }
  x.compare!(order: :baseline)
end

ruby 3.2.2 (2023-03-30 revision e51014f9c0) [arm64-darwin22]
Resolving dependencies...
Warming up --------------------------------------
               block     1.343M i/100ms
      block w/ block   513.029k i/100ms
        block_given?     1.465M i/100ms
block_given? w/ block
                         1.457M i/100ms
Calculating -------------------------------------
               block     13.177M (± 2.0%) i/s -     67.134M in   5.096854s
      block w/ block      5.471M (± 4.3%) i/s -     27.704M in   5.074617s
        block_given?     14.664M (± 0.8%) i/s -     74.736M in   5.096843s
block_given? w/ block
                         14.537M (± 0.8%) i/s -     72.851M in   5.011781s

Comparison:
               block: 13176873.3 i/s
        block_given?: 14664219.5 i/s - 1.11x  faster
block_given? w/ block: 14537095.2 i/s - 1.10x  faster
      block w/ block:  5470680.3 i/s - 2.41x  slower

But even then, the difference is too small to be worth in unless you enter the case where the Proc has to be instantiated.
require 'bundler/inline'

gemfile(true) do
  gem 'benchmark-ips'
end

def if_block(&block)
  block ? true : false
end

def if_block_given
  block_given?
end

Benchmark.ips do |x|
  x.report('block')                  { if_block }
  x.report('block w/ block')         { if_block {} }
  x.report('block_given?')           { if_block_given }
  x.report('block_given? w/ block')  { if_block_given {} }
  x.compare!(order: :baseline)
end

Warming up --------------------------------------
               block     1.428M i/100ms
      block w/ block     1.321M i/100ms
        block_given?     1.456M i/100ms
block_given? w/ block
                         1.451M i/100ms
Calculating -------------------------------------
               block     14.424M (± 1.6%) i/s -     72.851M in   5.052055s
      block w/ block     13.159M (± 1.4%) i/s -     66.037M in   5.019221s
        block_given?     14.549M (± 1.4%) i/s -     72.786M in   5.003860s
block_given? w/ block
                         14.404M (± 1.3%) i/s -     72.529M in   5.036180s

Comparison:
               block: 14424088.9 i/s
        block_given?: 14548868.5 i/s - same-ish: difference falls within error
block_given? w/ block: 14404275.0 i/s - same-ish: difference falls within error
      block w/ block: 13159479.3 i/s - 1.10x  slower

To be fair, the assumption is that with block_given? you can often avoid declaring &block:

That's another point in favour of removing the linter, which tells you to replace block_given? with block.

Following this Cop's advice produces significantly worse results on Ruby < 3.2 if a method forwards checks whether a block was given and then just forwards it. Consider the following example where we may call one of the outer methods either with a block or without one:
# frozen_string_literal: true

require 'bundler/inline'
gemfile(true) do
  gem 'benchmark-ips'
end

def each
  3.times { |i| yield i }
end

def outer1(&block)
 return enum_for(__method__) unless block_given?
 each(&block)
end

def outer2(&block)
 return enum_for(__method__) unless block
 each(&block)
end

Benchmark.ips do |x|
  x.report('outer1') { outer1 { } }
  x.report('outer2') { outer2 { } }

  x.compare!
end

With Ruby < 2.6 (I tested down to Ruby 2.3), both outer methods are about equally slow since the forwarded block is always materialized as a Proc when calling the each method:
ruby 2.3.8p459 (2018-10-18 revision 65136) [x86_64-darwin17]
Warming up --------------------------------------
              outer1   174.019k i/100ms
              outer2   135.977k i/100ms
Calculating -------------------------------------
              outer1      1.398M (± 7.2%) i/s -      7.135M in   5.129078s
              outer2      1.547M (±13.5%) i/s -      7.615M in   5.022678s

Comparison:
              outer2:  1547464.0 i/s
              outer1:  1397649.7 i/s - same-ish: difference falls within error

With Ruby >= 2.6, < 3.2 however, the block is not strictly materialized as a Proc when forwarding anymore. Thus, when passing block, outer2 is roughly 2 times slower  than outer1:
ruby 2.6.4p104 (2019-08-28 revision 67798) [x86_64-darwin17]
Warming up --------------------------------------
              outer1   391.625k i/100ms
              outer2   199.534k i/100ms
Calculating -------------------------------------
              outer1      3.861M (± 3.0%) i/s -     19.581M in   5.076225s
              outer2      1.947M (± 4.1%) i/s -      9.777M in   5.030709s

Comparison:
              outer1:  3861370.8 i/s
              outer2:  1947189.7 i/s - 1.98x  (± 0.00) slower

ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [x86_64-darwin19]
Warming up --------------------------------------
              outer1   271.669k i/100ms
              outer2   155.330k i/100ms
Calculating -------------------------------------
              outer1      2.712M (± 1.3%) i/s -     13.583M in   5.009887s
              outer2      1.476M (± 9.8%) i/s -      7.301M in   5.006872s

Comparison:
              outer1:  2711812.2 i/s
              outer2:  1475957.7 i/s - 1.84x  slower

Only from Ruby 3.2 on, this improved and there is no actual difference between both options anymore — until you unwittingly  introduce another pattern which again materializes the block as indicated by @jhawthorn above.
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-darwin23]
Warming up --------------------------------------
              outer1   296.872k i/100ms
              outer2   310.487k i/100ms
Calculating -------------------------------------
              outer1      2.737M (± 7.4%) i/s -     13.656M in   5.018464s
              outer2      2.893M (± 6.1%) i/s -     14.593M in   5.065345s

Comparison:
              outer2:  2892991.1 i/s
              outer1:  2737445.0 i/s - same-ish: difference falls within error

Thus, at the very least you should restrict the cop to be only active in Ruby >= 3.2.0. Here, it doesn't actively cause harm at least, although it doesn't  provide much benefit too. As such, I'd also be happy if the cop is fully disabled by default.

I openend #466 to disable by default. I don't think there's value in trying to update it into something that may give worse results in the next ruby version yet again. There's been some great performance work in Ruby itself lately and I wouldn't be surprised if these difference versions continue to converge. With YJIT, benchmark-ips doesn't even show the difference anymore (except that the correction is even worse)


improvement : better custom selectYears in pickadate

Currently, the variable selectYears permits to delimit the number of years in the select menu, with current year being the center of the span -- i.e. if selectYears is set to 10, and we're in 2015, the select menu will show years from 2005 to 2025.
In most cases, this is not useful. For example, in the case of date of birth, you'd need to set selectYears to a high value like 180 in order to accommodate ages up to 90 years old, while have a looooong select list up to year 2105...
Wouldn't it be better to use 2 variables : selectYearStart and selectYearEnd ?

Please see http://amsul.ca/pickadate.js/date/


How to ensure specific files and directories are Included and accessible in function package?

Hi,
I am working on a project to conduct automatic audits on providers and need to run tests programmatically in AWS Lambda using SST version 0.0.296. I'm trying to include an entire directory (src/tests) and a specific file (src/playwright.config.ts) in my function deployment package. My current configuration is as follows:
/// <reference path="./.sst/platform/config.d.ts" />

export default $config({
  app(input) {
    return {
      name: "watcher",
      removal: input?.stage === "production" ? "retain" : "remove",
      home: "aws",
    };
  },
  async run() {
    const helloWorldApp = new sst.aws.Function("WatcherHelloWorld", {
      handler: "src/functions/hello-world.handler",
      url: true,
      copyFiles: [
        { from: 'src/tests' },
        { from: 'src/playwright.config.ts' }
      ]
    });

    return {
      url: helloWorldApp.url
    }
  },
});

The function deploys without errors and the files are included in the deployment zip. However, when I execute ls -la using child_process inside the function, it shows that the src folder only contains the lambda handler file and not the copied files. How can I make sure these files are properly accessible and listed for execution by my code in Lambda?

I have been analyzing how SST handles file deployment and noticed something intriguing. After running sst dev and deploying on AWS, the copied files are indeed present in the code.zip stored in .sst/artifacts/WatcherHelloWorld.

However, once I visit the SST-provided endpoint and the deployment completes without errors, the original zip disappears and is replaced by a folder containing a symbolic link to node_modules and the src/functions/hello-world folder only housing index.mjs and its .mjs.map.

The copied files are missing, which explains why my code cannot detect these files.
I will continue investigating this issue.


Possibly change from Highlight.js to Prism.js

Is your feature request related to a problem? Please describe.
Currently Snapcode doesn't like React code, specifically JSX within React code. This is a limitation of highlight.js. Looking through issues on that projects Github, someone has suggested Prism.js, as it does support JSX, as well as a tonne more languages.
Describe the solution you'd like
Investigate if changing from Highlight.js to Prism.js is something that Snapcode might benefit from
Describe alternatives you've considered
Sticking with Highlight.js, that doesn't support React/JSX, cuts off a lot of developers from potentially using the platform to store snippets/code.

Hi @denno020, I have added JSX support(fc5f3827f7e301310e0cf80701a6ef0bdf58f940), now you can write react code in snapcode.  And I'm using codemirror for the code highlighter not highlight.js

Hi @denno020, I have added JSX support(fc5f3827f7e301310e0cf80701a6ef0bdf58f940), now you can write react code in snapcode.  And I'm using codemirror for the code highlighter not highlight.js

Oh great! Thanks.
Ah right, sorry! The PR titled Bump highlight.js from 9.18.1 to 9.18.5 threw me 😅

Oh great! Thanks.
Ah right, sorry! The PR titled Bump highlight.js from 9.18.1 to 9.18.5 threw me 😅


Support django >= 2.0

Add support to Django versions 1.11 <= 2.0

See https://github.com/ashchristopher/django-pgcli/pull/9 - seems to work out of the box.

You can use a work-around and install the fork of @jnoortheen by using this in your requirements.txt instead of django-pgcli
git+git://github.com/jnoortheen/django-pgcli@master#egg=django-pgcli


Support "." and "_" in filename

Replace all "." but last with "$", then in view pattern "$" is translated to "." on reading

https://gist.github.com/Sauilitired/98d425d176a9341ab230981b1817ddef


CSS suddenly not displaying properly after updating Firefox

Description
Rounded borders around page are missing and no longer display after updating Firefox
To Reproduce
update to 132.0 (64-bit)
Expected behavior
Borders display normally, around browser window
Screenshots

Desktop (please complete the following information):

OS: Arch Linux
Firefox Version: 132.0 (64-bit)

have this same issue, no idea what could've changed to break the theme like that (also arch linux on 132.0)

I dont think #appcontent is a thing anymore.
Open browser.css file, find #appcontent and replace it with for example #tabbrowser-tabbox


Error: init() got an unexpected keyword argument 'output_dims'

Hello, Please your help when I tried to run "python3.6 getrawimage.py 0.01 output.tif", there is an error that I couldn't solve:

press Ctrl C  to end program
camera startup gain autocal
auto AWB gains were 0.90234375 1.4453125
Traceback (most recent call last):
File "getrawimage.py", line 32, in
img = bayerseq(p.numimg, p.exposure)
File "/home/pi/Desktop/Multiespectral/raspicam-raw-bayer-master/pibayer/init.py", line 30, in bayerseq
r,c = getparams(cam)
File "/home/pi/Desktop/Multiespectral/raspicam-raw-bayer-master/pibayer/init.py", line 162, in getparams
img = grabframe(c)
File "/home/pi/Desktop/Multiespectral/raspicam-raw-bayer-master/pibayer/init.py", line 234, in grabframe
with picamera.array.PiBayerArray(cam, output_dims=2) as S:
TypeError: init() got an unexpected keyword argument 'output_dims'

Do you know what I can do to let this code runs?

Can you tell me what PiCamera (python) version you're running? This output_dims=2 should be valid syntax
import picamera
picamera.__version__

Please reopen if it's still an issue with the latest picamera installed, thanks.


fix: track all events

What it solves
Adding previously GA-tracked events, as well as newly requested ones from this document.
How this PR fixes it
All events that were previously being tracked, as well as those that were requested are now added to the dataLayer, routed onto GA from GTM.
GTM only initializes/tracks when in the production environment or the debug window is open.
Notes
There are three event types: pageview, customClick and metadata:

pageview emits the URL, with an anonymized Safe address/transaction ID
customClick emits when an element is clicked (or is a direct side-effect of a click)
metadata emits with associated data, e.g. threshold of a newly created Safe

How to test it
The checklist of events here will log to the console.

Note: in the last commit I removed the SHOULD_LOAD_GTM as it was intefering with preview mode. It is no longer needed as we do not push to the dataLayer unless it is production, and when in preview a debug flag is sent to GA.

When switching accoutns int the MM extension 2 metadata entries are being created that are the same. Not sure if it is a bug or not, just weird behavior

The rest of the events are fine,  they are being tracked.
Note that I only checked in the GTM that the events were tracked but not in GA yet, and also we should have a meeting to discuss the integrity of the data being tracked, to make sure we are tracking what we expect.

@francovenica, thanks for the thorough testing. I have fixed/adjusted your findings accordingly (pleasse see the checkboxes). Regarding the following:

If you click that button it will create a metadata log with the value you input in the searchbar, which I don't think is correct. I think it should be something lile "WC by suggestion" or something like that.

I have discussed this with @johannesmoormann and the current implementation is as intended. Should we want to adjust this, we will do so in the future.
As a side note: I have added an extra event when clicking the "Download on the App Store" button, as per @sche's request. It would be appreciated if you can double-check that for me as well.

The double click event when opening an app was fixed (the event with the "unknown" eventLabel was removed)
The pin/unpin events were fixed
I checked the new event when clicking the "download in app store" button that is in the "Connect dropdown"
The download in app store button has the link it was requested to have:

Looks good to me


Call roll-up angular in reh build

Various build updates to fix regressions in webmode builds.

Pull Request Test Coverage Report for Build 926808481

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 43.369%

Totals

Change from base Build 926472147:
0.002%

Covered Lines:
26602

Relevant Lines:
55739

💛  - Coveralls

I have these changes included in the overall web-build PR.  Will address anything pending there.


DEV:LOG: GetFromStore <IP_ADDRESS> Channel Set Metadata missing objectGrowing

GetFromStore Log <IP_ADDRESS> Channel Set Metadata missing objectGrowing. Need to trace for root cause & fix.

ETA is 7/24 @sukhendumukherjee

@sukhendumukherjee will manage this in the next sprint

The issue is still outstanding.

QA Tested, issue is fixed.


Add esports stats API

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


is not working with symfony filter scssphp

I try to get this runnning in Symfony 3.1.2 with the assetic watcher for scss (scssphp).
{% stylesheets filter="scssphp" output="/assets/css/style.css"
<EMAIL_ADDRESS>        %}
        <link rel="stylesheet" href="{{ asset_url }}" />
        {% endstylesheets %}

Here is the code i run:
$nav-font-size: 15px;
@include rem((
          font-size: $nav-font-size
  ));

and this is what comes out:
font-size:15px;
font-size:0.00977rem

My rem-baseline is:
$rem-baseline: 16px;
Any idea what cause this?
Regards
Thomas

Hi,
I pushed a fix on a fix/scssphp branch: let me know if it resolves your issue.
I'm not quite sure I want to support such unofficial ports of Sass (without unit testing), so I'll think about merging this eventually.

Hi,
yes works now.
What do you mean with "unofficial ports of Sass".
This filter is what symfony officila recommends on there webiste.

Thanks,
Thomas

Symfony recommends https://github.com/leafo/scssphp which is PHP compiler.
The only official Sass compilers are written in Ruby and C/C++ (libsass) : https://github.com/sass
Since this compiler is not supported by the Sass team, it could have some bugs and not all the features in Sass and libsass (I'm pretty sure the ones I fixed are bugs since its works on both official compilers).
I would rather recommend using something like Gulp/Grunt (and node-sass) to compile your .scss files to .css, but it would sure be less integrated with Symfony. Or maybe something like https://github.com/GollumSF/libsass-bundle ?
Anyway, I'm glad this fix your issue for now, and thanks for using sass-rem!


Simplify Svelteimpl

Summary
The goal for this PR is to simplify the Svelte to React bridge. It allows to import Svelte component (=JS Class) directly and set any props we want on them, not limited to data and options anymore.
(Internal for Opendatasoft only) Associated Shortcut ticket: sc-45636.
Changes
I mainly replaced the ReactImpl.tsx content. This is the main change, where we create a reactify HOC that takes a compiled Svelte component (not our homebrewed implementation) and returns the desired React component. It uses to useEffect one for mounting and one for updating props.
In the process, I decided to remove the ability to forward props to the mounting node. I found it a bit confusing on how it works (e.g. set style on the created mounting node, not on the first tag of the component) and the ability to choose tag (in practice, we don't, it's div). Now, either the Svelte component accepts style or classname etc. and places it where it wants, either you have to set thoses on a wrapping div (e.g. for css custom properties).
I also deleted Sveltimpl. As of now, it means using component.$set({ propname: propvalue}) to use it in vanilla JS. We could also add bundling option to export web components.
Most of the rest is updating imports accordingly to this new architecture. To do so, I added path aliases, since it proved super tiresome to update all ../src, ../../src, between source, Storybook etc. It makes for most of the diff, but actually pretty simple.
Props type is still here to build stories components etc. but should be gone in further PRs if we like this idea. As of this one, I'd rather try to change the components as few as possible.
Breaking Changes
💥
Actually, shouldn't break anything as of this PR.
Open discussion
Many, many questions… 🤓
Do we export web components? A new Vanilla interface or we're good with the native Svelte one?
Do we memo the component by default? Do we forwardRef? I'm not a huge fan of any, I'd rather not mess with the mounting node which is just an implementation detail, but this can be discussed.
To be tested
Change export let … names, add new ones etc. in Svelte and do the same in Stories. It should work 😅
Review checklist

[x] Description is complete
[x] Commits respect the Conventional Commits Specification
[x] 2 reviewers (1 if trivial)
[x] Code is ready for a release on NPM

So here is the state of things with TS.
I've been able to use ComponentProps<Component> in .svelte files. It works in the package itself

But doesn't get bundled. You can look into dist/components/types, it will try to import Chart.svelte but with no files. The ends up the component being cast as SvelteCompnent default, which accepts any props:

And thus we can add any props. As of now this line should crash, but it doesn't because of that cast to a generic component. If were able to bundle components types, we problably won't even need to export props types indivdually…
Yet another lead is the $$Props types, which I see mentioned but I don't much doc about…

So here is the state of things with TS.
I've been able to use ComponentProps<Component> in .svelte files. It works in the package itself
But doesn't get bundled. You can look into dist/components/types, it will try to import Chart.svelte but with no files. The ends up the component being cast as SvelteCompnent default, which accepts any props:
And thus we can add any props. As of now this line should crash, but it doesn't because of that cast to a generic component. If were able to bundle components types, we problably won't even need to export props types indivdually…
Yet another lead is the $$Props types, which I see mentioned but I don't much doc about…

From what I could test it seems that during the local build it tries to get ChartProps from the node_modules folder.
As it doesn't exist it fallbacks to Record<...>.
I test with a type that is already in the nodule_modules folder like ChartOption.
It seems better.
Before the build you can try to link the @ods-dataviz-sdk/visualizations package to use the local version instead of referring to the node_modules

Sooooo… I couldn't find an option to export types from *.svelte files in any meaningful ways. It seems exports from those files get erased at build time, wether they are the default export, or from context="module".
Ideally, I would have liked to either use SvelteComponentTyped(Table) or something like:
<script context="module">
type Props = { ... }
</script>

<script type="export">
...
</script>

And then have svelte preprocess inject type $$Props = Props;
It's not too much of a hassle to add manually, but we have to remember to define props in .ts file and add type $$Props = TableProps in exported components. Can't find anything better right now, but it works 🤷

@KevinFabre-ods I only checked the storybook, I have yet to double check how it works on the platform.

So, I left some comments
Locally, when I build visualizations and then visualisations-react I don't need $$Props in the Svelte component to have the right type declarations.

$$Props isn't for export/bundle, it's for making the bridge between the .svelte and .ts during dev, making sure you don't add an extra/wrong export let … that is not in the types.ts.

Visualizations types have changed since my last review
Before:
After <img alt="image" width="876" src="https://private-user-images.githubusercontent.com/117300300/311281964-0aa96c35-fd56-4fa4-b2f6-5f3d8aa743b0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTAxNDc3MTcsIm5iZiI6MTcxMDE0NzQxNywicGF0aCI6Ii8xMTczMDAzMDAvMzExMjgxOTY0LTBhYTk2YzM1LWZkNTYtNGZhNC1iMmY2LTVmM2Q4YWE3NDNiMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMzExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDMxMVQwODU2NTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mZjBlNzEyZGU0MGJjMmFlNDVmYjMyYTgxNTQyYmEwZGUxZDUwMTllMzFkNDk5YWRiZDI5OTJmMTg0OWZkZjNjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.FGWDGSeEhhJX_c-CuJ-yXxwxIqe2fWwn2PgXK_AME3g"
They doesn't seems to be considered as React component now

They aren't typed as some form of FC, but (props: …) => JSX.Element should be good enough. We can specify it though 🤷


#6714 CreateUserActivity allow to create users of different types

Provides the implementation of this issue https://github.com/OrchardCMS/Orchard/issues/6714
Maybe you prefer I target dev ...

It's a very special scenario, I'd suggest you create a CreateCustomUserActivity in your own module.


How to manage !effect or !custom with simple property.

I'm writing a tern plugin for jasmine https://github.com/angelozerr/tern-jasmine
I can manage this case :
expect(true).  // here Ctrl+Space must shows not, toBeDefined, etc

expect is a function which returns a custom function (because jasmine matchers can be dynamic).
"expect": {
      "!type": "fn(value: ?) -> !custom:jasmineExpect",
      "!doc": "Expectations are built with the function expect which takes a value, called the actual. It is chained with a Matcher function, which takes the expected value."
    },

See https://github.com/angelozerr/tern-jasmine/blob/master/jasmine.js#L146
The not matcher must return the matchers list too like expect function (`not', 'toBeDefined', etc, So I have written :
"not": {
          "!type": "!custom:jasmineExpect",

But as not matcher is a property and not a function, it doesn't work.
I would like to manage that :
expect(true).not.  // here Ctrl+Space must shows not, toBeDefined, etc

@marijnh have you an idea how to I could manage not case?

What does not hold, then? Is it a getter property? If it's not a function, Tern can currently not associate effects with it.

not is a simple property. That's why I have created an issue for that : associate an effects with a property.
I have fixed my problem by writing my JSON Type Defitnition with an other mean and it works https://github.com/angelozerr/tern-jasmine/blob/master/jasmine.js#L47


Fixed an error when the text has a non-word character and a space next to it

This PR fixes undefined method '[]' for nil:NilClass for texts like this one Hello !

Thanks for the great work, @ivanovv. Just ran into this error in our production app, so it'd be wonderful to get this PR merged and into a release.

I've released a new avatarly version 1.5.1. Thanks for PR!
Nowadays I work on https://knapsackpro.com maybe you will find it useful to run your tests faster. :)

Thank you. :heart:
Congratulations for your new job. :tada:

Thank you! Minus one github gem from the Gemfile :)


Create Socket Wrapper

Create a class to wrap sys/socket.h.  This will be used by both Client and Server to communicate.

[ ] Create Socket.h and Socket class definition.
[ ] Create Socket.cpp and implement the Socket class.
[ ] Create TCP child class.
[ ] Create UDP child class.

0001-make-socket-util

Even though we've put some work into this, I think we should abandon in favor of using Boost sockets.
We're likely going to use boost for testing anyway.


Custom directives in schema "tried to use an undeclared directive"

Custom defined directives from another file not
To Reproduce

Create a new file "directives.graphql"
Add some directive definition e.g.

directive @Resource(Name: String!, Route: String, Primary: Boolean, DB: DbConfig) on OBJECT
directive @Field(Label: String, Description: String, DB: DbFieldConfig) on FIELD_DEFINITION

Add directives.graphql to schemas in (graphql.config.yaml or .graphqlrc e.t.c.)

schema:
   - "./directives.graphql"

Create new file types.graphql

type User
@Resource(Name: "user", Primary: true, Route: "user", DB: {Table: "user"})
{
    id: ID! @Field(Label: "ID", Description: "ID of the todo", DB: {Column: "id", PrimaryKey: true})
    name: String! @Field(Label: "Text", Description: "Text of the todo", DB: {Column: "name", Unique: true})
    cars: [Car!]! @Field(Label: "Cars", Description: "Cars of the todo", DB: {})
}

Add types.graphql to schemas too

schema:
   - "./directives.graphql"
   - "./types.graphql"

Check inspection errors in editor

Version and Environment Details
Operation system: MacOS
IDE name and version: Goland or Intellij IDEA
Plugin version: 4.0.2

@diazoxide Hi! Sorry for the late response. Unfortunately, I can't reproduce the issue. My project looks like that, no errors so far.
directives.graphql
directive @Resource(Name: String!, Route: String, Primary: Boolean, DB: DbConfig) on OBJECT
directive @Field(Label: String, Description: String, DB: DbFieldConfig) on FIELD_DEFINITION

types.graphql
input DbConfig {
    Table: String
}

input DbFieldConfig {
    Column: String
    PrimaryKey: Boolean
    Unique: Boolean
}

type Car {
    name: String
}

type User @Resource(Name: "user", Primary: true, Route: "user", DB: {Table: "user"}) {
    id: ID! @Field(Label: "ID", Description: "ID of the todo", DB: {Column: "id", PrimaryKey: true})
    name: String! @Field(Label: "Text", Description: "Text of the todo", DB: {Column: "name", Unique: true})
    cars: [Car!]! @Field(Label: "Cars", Description: "Cars of the todo", DB: {})
}

graphql.config.yml
schema:
  - "./directives.graphql"
  - "./types.graphql"


Selecting install from prompt when missing pip fails because pip is not available

Install a python interpreter without including pip
Select that interpreter as the kernel in vscode and run a cell
A prompt shows up saying that IPykernel and pip are required, select install

result:

This happened after deleting the windows app python installation, and installing a new 3.10.5 to replace it.

I believe this is by design. You need to have pip available.
This issue is relevant:
https://github.com/microsoft/vscode-python/issues/15937

we shouldn't have an option to install if we know it's going to fail, the installation prompt already says that pip is missing

We probably should not have the install button in this case. Without 'pip' we don't want to get pip for the user. They should do it but we need to make that clearer.

I might be in this situation because of a bad python installation, pip should actually be installed
PS C:\src\test\3> python -m pip --version
Error processing line 7 of C:\Users\aamunger\AppData\Roaming\Python\Python310\site-packages\pywin32.pth:

  Traceback (most recent call last):
    File "C:\Users\aamunger\AppData\Local\Programs\Python\Python310_5\lib\site.py", line 186, in addpackage
      exec(line)
    File "<string>", line 1, in <module>
  ModuleNotFoundError: No module named 'pywin32_bootstrap'

Remainder of file ignored
C:\Users\aamunger\AppData\Local\Programs\Python\Python310_5\python.exe: No module named pip

@IanMatthewHuff I'm taking this as this falls into installation, and kernel startup and the like.

Closing as not planned
No one else has reported this


Unable to delete a user with admin auth

Bug report

[Maybe?] I confirm this is a bug with Supabase, not with my own application.
[Y] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
Unable to delete a user with python admin sdk supabase.auth.admin.delete_user
To Reproduce
from supabase import create_client, Client
from now_u_api.settings import SUPABASE

supabase = create_client(SUPABASE.URL, SUPABASE.KEY)
response = supabase.auth.admin.delete_user(self.auth_id)

the values of SUPABASE.URL and SUPABASE.KEY look correct and the auth_id is a valid UUID of one of the users in supabase
Im getting the following error:
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/gotrue/_sync/gotrue_base_api.py", line 111, in _request
    response = self._http_client.request(
  File "/usr/local/lib/python3.10/site-packages/httpx/_client.py", line 814, in request
    request = self.build_request(
  File "/usr/local/lib/python3.10/site-packages/httpx/_client.py", line 345, in build_request
    url = self._merge_url(url)
  File "/usr/local/lib/python3.10/site-packages/httpx/_client.py", line 375, in _merge_url
    merge_url = URL(url)
  File "/usr/local/lib/python3.10/site-packages/httpx/_urls.py", line 115, in __init__
    self._uri_reference = urlparse(url, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/httpx/_urlparse.py", line 162, in urlparse
    raise InvalidURL("Invalid non-printable ASCII character in URL")
httpx.InvalidURL: Invalid non-printable ASCII character in URL
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.10/site-packages/sentry_sdk/integrations/django/views.py", line 84, in sentry_wrapped_callback
    return callback(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/views/decorators/csrf.py", line 65, in _view_wrapper
    return view_func(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/rest_framework/views.py", line 509, in dispatch
    response = self.handle_exception(exc)
  File "/usr/local/lib/python3.10/site-packages/rest_framework/views.py", line 469, in handle_exception
    self.raise_uncaught_exception(exc)
  File "/usr/local/lib/python3.10/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
    raise exc
  File "/usr/local/lib/python3.10/site-packages/rest_framework/views.py", line 506, in dispatch
    response = handler(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/rest_framework/generics.py", line 217, in delete
    return self.destroy(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/rest_framework/mixins.py", line 91, in destroy
    self.perform_destroy(instance)
  File "/usr/local/lib/python3.10/site-packages/rest_framework/mixins.py", line 95, in perform_destroy
    instance.delete()
  File "/app/users/models.py", line 110, in delete
    response = supabase.auth.admin.delete_user(self.auth_id)
  File "/usr/local/lib/python3.10/site-packages/gotrue/_sync/gotrue_admin_api.py", line 164, in delete_user
    return self._request("DELETE", f"admin/users/{id}", body=body)
  File "/usr/local/lib/python3.10/site-packages/gotrue/_sync/gotrue_base_api.py", line 123, in _request
    raise handle_exception(e)
gotrue.errors.AuthRetryableError: Invalid non-printable ASCII character in URL

Expected behavior
User should be deleted
Screenshots
N/A
System information
python 3.10
supabase 2.7.3
Additional context
Add any other context about the problem here.

I had a new line character at the end of the url 🤦


Datagen doesn't work with mod installed

Describe the bug
When running forge datagen, it crashes because Minecraft.getInstance() returns null.
To Reproduce
Steps to reproduce the behavior:

Install mod
Run datagen

Expected behavior
The mod wouldn't run any logic during datagen
Additional context
This should be fixed by checking if it returns null during client initialization

log?

latest.log

The arch port removed this check and this issue is back


New Preferences UI and zedconfig.json

This might be known since this hasn't been officially released yet, but right now the preferences ui will show settings that are set in a project's zedconfig.json, but overwrite the settings in the configuration project's user.json. I'm not sure what the best solution to this problem is.  Maybe it should just show the configuration project's preferences?

As observed in #495 mode-local preferences should also be taken into account here.


Loss calculation

When calculating the loss, the size of the picture is 46x46. If the size of the output image is 23x23, how should it be calculated? Does the following method work?
keypoint_maps = batch_data['keypoint_maps'].cuda()
keypoints_maps=keypoint_maps/2

Hi! How output image size became 23x23 instead of 46x46? If you have just changed crop size, the output should be changed correspondingly automatically.

Change the stridee of a certain convolution kernel from 1 to 2 ?

In this case, set the stride to 16.

thanks, have a nice day


[FEA]: Create unittests for DFP example

Is this a new feature, an improvement, or a change to existing functionality?
Improvement
How would you describe the priority of this feature request
Medium
Please provide a clear description of problem this feature solves
The DFP example contains a sizable code base with multiple custom stages.
In order to ensure that the DFP example doesn't break we should creates some tests for it, and run it as a part of our CI system.
Describe your ideal solution
Write more tests.
Describe any alternatives you have considered
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I have searched the open feature requests and have found no duplicates for this feature request

Closing since tests were added for DFP in #940


Update package.json

@lexich
May be add
"engines": {
"npm": ">=3"
}
I am usually add such constraint, How do u think?

Travis fails because code use nodejs version syntax >= 4.0.0
https://travis-ci.org/nspectator/katas/jobs/151720457#L254
I update travis config to remove 0.12 version, but unfortunately travis didn't update build configuration. Anyway you can merge this PR, because version 4 and 5 passed
@jonny-novikov

@lexich That's ok!
Of course, it's rather expected behaviour that Travis config is modifying on merge but not on pr hook.
https://travis-ci.org/nspectator/katas/builds/151726266
Merge commit updated configuration automatically.


.Added AIExt Scripts

Here is some of my modification in AI scripts.

Okay, I finally have been able to take a closer look at the additions. Mostly everything looks good, but I'm not quite sure how to properly configure a new vehicle with the AI. I tried adding a different vehicle prefab to the example scene and copying the AI Agent Autonomous script and Nav Mesh Agent from the monster truck but sometimes the car would get stuck at a target point and just move forward and back. I disabled the Basic Input script too. Also, is there a way to configure the AI so that it doesn't reverse every time it reaches a target point?
I think the variables in the AI Agent Autonomous script should instead be given properties (getters) that limit their returned range to be greater than zero instead of using the range attribute. With the way it is now, the variables have sliders in the inspector that reach all the way up to 3.402823e+38 which is not very useful to work with compared to how sliders are used in other parts of RVP.
I noticed that the AI Actuator script calls ShiftToGear(2) on Gearbox Transmission. I assume this is because you want it to shift into the first gear, however not all vehicles might have the first one at that index in the gears array. The Gearbox Transmission script already has a private firstGear variable that contains the index of the first gear and is set in Start(). You can make the variable public and nonserialized and reference it in AI Actuator instead of using the number 2.
Lastly, it seems as though the AI does not work properly with vehicles using continuous transmissions unless I'm configuring something incorrectly. If possible, I would appreciate it if you could make it work with the Special Car prefab.
Once these concerns are addressed I'll merge this into its own branch for some minor polishes and tweaks and to update the documentation. Can you adjust the pull request to be directed at the AIExt branch?

...but sometimes the car would get stuck at a target point and just move forward and back.
You can choose Forward or Backward in Direction Property in AI Agent Autonomous. However, it doesn't really accurate for handling sharp curve.

The forward-backward behavior is normal when we selected AutoFlip in Direction Property since it's using Seek/Arrive behavior that depends on the distance between target and the vehicle.
The user should change the Behavior to None to stop the vehicle perfectly when they write codes for AI FSM State. But i think it's a good idea to do this in AI Actuator. I will fix it.
Actually, the AI Agent Autonomous doesn't handle all situations perfectly, that's why i included the AI FSM State to fix the errors.
For example, when users wanna move the vehicle towards the enemy, they might select Forward direction in a open area to move the vehicle faster, but when the vehicle is in an area which requires sharp turn, they will have to change the Direction to Auto Flip.
The AI behaviors might be different in different vehicles and requires tweaking to setup them properly. So, it's better to make samples for all vehicle types.

I think the variables in the AI Agent Autonomous script should instead be given properties (getters) that limit their returned range to be greater than zero instead of using the range attribute...

I noticed that the AI Actuator script calls ShiftToGear(2) on Gearbox Transmission. I assume this is because you want it to shift into the first gear...

I got it. I will change them.

Lastly, it seems as though the AI does not work properly with vehicles using continuous transmissions unless I'm configuring something incorrectly.

You're right. I have not implemented the AI for continuous transmission.
Thanks for your feedbacks.

One more thing that would be good is to test it with a hover car.
Thanks for the contributions.


adding english to language attribute of html tag

#127 for reference

Sure! One sec...

@juliaelman all set

Awesome! Thank you @kstack7! You :crown:


Feature request -- event handling for non-visual components without DOM

Just wanted to add a feature request.
I use some components as non-visual components, just like a class in traditional OO language.
Events fired in these components do not get caught by the component that instantiates the non-visual component unless the non-visual component is added to the DOM.  i don't know if it's possible to work it so that these also can get caught above (have non-dom events as well), but I found it kind of "hacky" feeling have to add the non-visual component to the dom in order to get the event to be caught.

Hm, this should just work. Something like this perhaps: http://jsbin.com/guwemaqezu/edit?html,console,output

Thanks, I must have had something else going on.


Makka / #1230 add one percent to total cost

Description
Adds a 1% fee to total cost on retire/purchase pools.

[x] Add error message and styling when insufficient balance.

Related Ticket
Resolves #1230
Checklist

[X] I have run npm run build-all without errors
[X] I have formatted JS and TS files with npm run format-all

@0xMakka is this one ready for QA?

@0xMakka is this one ready for QA?

@jabby09 I think you should be good to start looking at it. I pushed some changes earlier on the /redeem page on the app, however I was having issues with Polygon RPC so couldn't fully verify on the /offset page.

Helloes,
+1% total cost on Carbonmark works, no issues. Checked it on both Purchase and Retire. ✅
+1% total cost also works on KlimaDAO /redeem (✅), but not on KlimaDAO /offset (❌).

Helloes,
+1% total cost on Carbonmark works, no issues. Checked it on both Purchase and Retire. ✅
+1% total cost also works on KlimaDAO /redeem (✅), but not on KlimaDAO /offset (❌).

@0xtapi thanks for this, I was having issues with polygon-rpc at the time when working on the offset part so the balance wasn't loading for me to verify it was working as intended. Will pick this up again today and provide a fix for the /offset 👍

@0xtapi thanks for this, I was having issues with polygon-rpc at the time when working on the offset part so the balance wasn't loading for me to verify it was working as intended. Will pick this up again today and provide a fix for the /offset 👍

I believe it, lots of RPCs have been giving me trouble in the past few days. Better luck next time 🙃

if memory serves me correctly we should have a different error message that tells the user they need to have enough to cover cost +1 for slippage.

@0xMakka @Atmosfearful yes that is correct about an error message; see the requirements in #1230
As an example, you can see the design implementation for the RA https://www.figma.com/file/HXwNOLfM9CQHgwmouz0rpk/CARBON-OFFSETTING?type=design&node-id=2305-12141&t=eUJtBhZaKiaIPuja-4
@0xtapi when you did the QA for this, did you confirm the error message as per this requirement?

In Carbonmark, on Retire and Buy forms for Pool listings, need to add additional form validation to ensure the Pay with balance is the cost + 1%. If not, need to display the form error message.

1% increased cost on /offset works now ✅
@jabby09

when you did the QA for this, did you confirm the error message as per this requirement?

No, I did not. Makka said the only change that was made was the added +1% cost, so that's the only thing I took a look at. You are right that it currently does not show the error message as seen in the designs. I'll make it more clear next time if I actually QA'd for everything in the related ticket or just for whatever fix is mentioned in the OP.
Which means that, for now, the balance error messages are missing ❌.

1% increased cost on /offset works now ✅
@jabby09

when you did the QA for this, did you confirm the error message as per this requirement?

No, I did not. Makka said the only change that was made was the added +1% cost, so that's the only thing I took a look at. You are right that it currently does not show the error message as seen in the designs. I'll make it more clear next time if I actually QA'd for everything in the related ticket or just for whatever fix is mentioned in the OP.
Which means that, for now, the balance error messages are missing ❌.

This was my bad, I missed this error message on the designs. Apologies guys, will have a fix in for this today.

@0xtapi this is ready now for re-testing and requirements verification

I think we're still not quite there, but we're getting closer. Give me a quick sanity check here please: The "1% warning message" should display whenever your balance isn't at least the total cost plus 1%, right?
If so, this still needs some work. Check screenshots below:

First one is my balance exceeding the total cost by about 0.04%, second screenshot is my balance not exceeding the total cost (where it correctly spits out the message).
The warning should trigger on the first screenshot as well because my balance is not higher than total cost + 1% (my balance would need to be about 703 USDC in this example), right? So if the total cost is 100 USDC, the warning should trigger for all balance values below 101 USDC, correct?
If these assumptions are true, this still needs some more tweaking 🔧

I think we're still not quite there, but we're getting closer. Give me a quick sanity check here please: The "1% warning message" should display whenever your balance isn't at least the total cost plus 1%, right?
If so, this still needs some work. Check screenshots below:
First one is my balance exceeding the total cost by about 0.04%, second screenshot is my balance not exceeding the total cost (where it correctly spits out the message).
The warning should trigger on the first screenshot as well because my balance is not higher than total cost + 1% (my balance would need to be about 703 USDC in this example), right? So if the total cost is 100 USDC, the warning should trigger for all balance values below 101 USDC, correct?
If these assumptions are true, this still needs some more tweaking 🔧

@0xtapi just a note the "cost" price includes the 1% fee. Here is two scenarios I ran through when testing.
Offset View:
Scenario 1:

Tonnes = 6.19081
Cost without 1% fee = 3.071108 USDC
Cost with 1% fee -> 3.071108 + 1% = 3.101819

My exact USDC balance is 3.101819
In this case, no error message is shown as there is enough balance to cover the fee and the cost

Scenario 2:

Tonnes = 6.190811
Cost without 1% fee = 3.071109 USDC
Cost with 1% fee -> 3.071109 + 1% = 3.101820

My exact USDC balance is 3.101819
In this case, an error message is shown as there isn't enough balance to cover the fee and the cost.

Redeem View:
8.21585
Scenario 1:

Tonnes = 8.21585
Cost without 1% fee = 3.071108 USDC
Cost with 1% fee -> 3.071108 + 1% = 3.101819

My exact USDC balance is 3.101819
In this case, no error message is shown as there is enough balance to cover the fee and the cost

Scenario 2:

Tonnes = 8.215852
Cost without 1% fee = 3.071109 USDC
Cost with 1% fee -> 3.071109 + 1% = 3.101820

My exact USDC balance is 3.101819
In this case, an error message is shown as there isn't enough balance to cover the fee and the cost.

Not sure if I'm missing something else here, but will be sure to jump back on this and address if it is still an issue?

@0xMakka @0xtapi I'm having trouble following the RA screenshots above and for some reason I cannot currently get my metamask wallet to connect properly to the RA to test myself. However, in Carbonmark...
Apologies if the requirements were not clear in https://github.com/KlimaDAO/klimadao/issues/1230
Note, the 1% to account for slippage or pool price movement is automatically added when the transaction request is sent to the contract. This step happens here in the Confirm Retirement modal when the user clicks APPROVE.
This will fail every time if the user wallet does not have enough USDC to cover the total cost + 1%.

The objective is this ticket is to validate on the form before the user gets to the Confirm modal.
In the example below:

My USDC balance is $5.50
Therefore, I should not be able to submit this form for any total cost + 1% that exceeds $5.50
Basically that works out to ~$5.45 (i.e. $5.45 x 1.01 = $5.50)
In the example, somewhere close to 14.44 tonnes should trigger the validation error but it does not

The same logic applies to the retirement aggregator form.

@0xMakka @0xtapi I'm having trouble following the RA screenshots above and for some reason I cannot currently get my metamask wallet to connect properly to the RA to test myself. However, in Carbonmark...
Apologies if the requirements were not clear in #1230
Note, the 1% to account for slippage or pool price movement is automatically added when the transaction request is sent to the contract. This step happens here in the Confirm Retirement modal when the user clicks APPROVE.
This will fail every time if the user wallet does not have enough USDC to cover the total cost + 1%.

The objective of this ticket is to validate on the form before the user gets to the Confirm modal.
In the example below:

My USDC balance is $5.50
Therefore, I should not be able to submit this form for any total cost + 1% that exceeds $5.50
Basically that works out to ~$5.45 (i.e. $5.45 x 1.01 = $5.50)
In the example, somewhere close to 14.44 tonnes should trigger the validation error but it does not

The same logic applies to the retirement aggregator form.

@jabby09 thanks for the above message. So, I think the part I might be confusing is that currently the total cost on the card includes the 1% fee. From what I am now gathering; the total cost should be displayed without the 1% fee added, but when adding the error handling message, if the user doesn't have the total cost + 1% only at that point should the error message be displayed?
If this is the case (my bad at reading the requirements wrong), I'll rework it again; when looking at the RA app, I seen there is a tooltip on the total cost which says the total cost includes slippage and aggregation fee of 1% so I assumed it should be added to the total cost by default.

thanks for the above message. So, I think the part I might be confusing is that currently the total cost on the card includes the 1% fee. From what I am now gathering; the total cost should be displayed without the 1% fee added, but when adding the error handling message, if the user doesn't have the total cost + 1% only at that point should the error message be displayed?
If this is the case (my bad at reading the requirements wrong), I'll rework it again; when looking at the RA app, I seen there is a tooltip on the total cost which says the total cost includes slippage and aggregation fee of 1% so I assumed it should be added to the total cost by default.

hey @0xMakka okay now I'm confused, hahaha
don't do anything at this point, I think we need to talk to @Atmosfearful about this one

#1230

@jabby09 The error message is to be shown under the pay with dropdown, couldn't see it in the designs linked. I thought I had it added but will take another look.
With regards the loading issues, this is the rpc issue I've been looking into as polygon-rpc is constantly failing for me which prevents the balance from being able to be loaded.

The error message is to be shown under the pay with dropdown, couldn't see it in the designs linked. I thought I had it added but will take another look.

ah, okay. it was not showing up for me on Carbonmark

@0xMakka please check the style on the pay with element and font size for the error message.
Used to seeing this...
With USDC seeing this...
The other thing to check / keep in mind is the changes in #1459 and how the error messages are displayed.

@jabby09 My bad on this, I copied the font size from figma, but all the error messages on carbonmark are a slightly smaller size than the figma file (16px in figma, 14px on carbonmark) - so I've just updated to 14px to be consistent with what's currently on carbonmark. I also noticed I missed the red border on the dropdown so pushed a fix for this also.

This PR looks like it's passed @jabby09 QA but has been up for a couple months now, can you resolve the conflicts and then we can close it @0xMakka

Good shout @0xemc, yeah other higher priority tasks came up so this one was just left sitting. Just fixed all conflicts there now 👍


TypeError: document.getElementById(...) is null

Sometimes "TypeError: document.getElementById(...) is null" appears as an error after importing an exported file.
Can this be resolved?
Also, I added a feature to load a script saved to a server.
export function importURL(event) {
var request = new XMLHttpRequest();
//alert("awd");
//if(event.target.value == "lcsubsequence"){
//request.open('GET', 'https://isellemails.com/MediaLight/XEhA2/suTEbIGi76.json/raw', true);//lcsubsequence
//}
request.responseType = 'blob';
request.onload = function() {
	if(this.readyState == 4 && this.status == 200){
	var reader = new FileReader();
	reader.onload = onReaderLoad;
	reader.readAsText(request.response);
		//alert(request.response); //blob

	function onReaderLoad(event){
		//alert(event.target.result); //json
		app.currentProject = JSON.parse(event.target.result);
		el.name.value = app.currentProject.name;
		el.description.value = app.currentProject.description;
		setEditorValues(app.currentProject.data);
		app.unsavedChanges = true;
		ui.toast('Project imported.', 2000);
	}

	}

};

//alert('https://isellemails.com/webden/'+event.target.value+'.json');
request.open('GET', 'https://isellemails.com/webden/'+event.target.value+'.json', true);
request.send();

}
The feature I added works on the desktop but not on my mobile browser (Android Firefox and Android Chrome). I cannot find an error associated with my feature when I debug it.

I updated isellemails.com/webden/ but then the XMLHttpRequest is only working on desktops. That was so strange. Can this be fixed?
The update I added allows the user to select a project. It's only working on a desktop browser and not on Android Firefox.


Design Bug in light theme

Background Color and Text-selection-color is same so when we select text for copy or something..
For example in white background white text became invisible..
To fix this problem i change the selection text color to red so when anyone select the text in light theme they see text in red color when they select the text..

Thanks for the PR @iamuditpatel
This has been fixed in the redesign on master


[Look&Feel] Consistency of Plus Icons

Description
Updated plus icon over plusInCircle for add/create use cases. Did not change instances of other use cases, or when minusInCircle was attached.

Scope
Before (v7light)
After (v7light)
Before (v8dark)
After (v8dark)

Dashboards: Add Alert Monitor

Add Action / Trigger

Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Could you actually revert this one - because it's an empty button, I think it looks weird without either a button container or the fill - i'd rather just leave it unchanged for now.

Let's hold off on this one until we clarify Laura's guidance for Add's

@danieldong51 is it ready for review? Could you converted PR from draft?

@danieldong51 is it ready for review? Could you converted PR from draft?

Laura recommended me to not carry out these changes


Wrong import statement affecting LinearWarmupCosineAnnealingLR (and probably more code)

🐛 Bug
Can't import LinearWarmupCosineAnnealingLR
To Reproduce
from pl_bolts.optimizers.lr_scheduler import LinearWarmupCosineAnnealingLR

----> 1 from pl_bolts.optimizers.lr_scheduler import LinearWarmupCosineAnnealingLR
      3 class EventsTransformer(BaseEventsModel):
      4     def __init__(
      5         self,
      6         features: Sequence[str] | None = None,
   (...)
     17         dropout: float = 0.2
     18     ):

File ~/.cache/pypoetry/virtualenvs/ar-resp-vArrGwjy-py3.10/lib/python3.10/site-packages/pl_bolts/__init__.py:11
      8 _PROJECT_ROOT = os.path.dirname(_PACKAGE_ROOT)
      9 _HTTPS_AWS_HUB = "https://pl-bolts-weights.s3.us-east-2.amazonaws.com/"
---> 11 from pl_bolts import (  # noqa: E402
     12     callbacks,
     13     datamodules,
     14     datasets,
     15     losses,
     16     metrics,
     17     models,
     18     optimizers,
     19     transforms,
     20     utils,
     21 )
     23 __all__ = [
     24     "callbacks",
     25     "datamodules",
   (...)
     32     "utils",
     33 ]

File ~/.cache/pypoetry/virtualenvs/ar-resp-vArrGwjy-py3.10/lib/python3.10/site-packages/pl_bolts/callbacks/__init__.py:3
      1 """Collection of PyTorchLightning callbacks."""
      2 from pl_bolts.callbacks.byol_updates import BYOLMAWeightUpdate
----> 3 from pl_bolts.callbacks.data_monitor import ModuleDataMonitor, TrainingDataMonitor
      4 from pl_bolts.callbacks.printing import PrintTableMetricsCallback
      5 from pl_bolts.callbacks.sparseml import SparseMLCallback

File ~/.cache/pypoetry/virtualenvs/ar-resp-vArrGwjy-py3.10/lib/python3.10/site-packages/pl_bolts/callbacks/data_monitor.py:6
      4 import torch
      5 from pytorch_lightning import Callback, LightningModule, Trainer
----> 6 from pytorch_lightning.loggers import LightningLoggerBase, TensorBoardLogger, WandbLogger
      7 from pytorch_lightning.utilities import rank_zero_warn
      8 from pytorch_lightning.utilities.apply_func import apply_to_collection

ImportError: cannot import name 'LightningLoggerBase' from 'pytorch_lightning.loggers'

Code sample

Expected behavior
The code should work
Environment

Lightning-Bolts: 0.6.0.post1
PyTorch-Lightning: 1.9.0
Python version: 3.10

I ran into this same issue! A work around I found was to use LinearWarmupCosineAnnealingLR from the Flash module.

I'm running into the same issue.
torch: 2.0.0
lightning: 2.0.0
lightning-bolts: 0.6.0.post1

Did someone find the fix yet?

shall be fixed in #973


Is scikit-bio/ipynbs/ useful?

It's been about a year since we created that directory and there are only two presentations in it (both out of date at this point). I think the initial intention was something very much like the current scikit-bio-cookbook so I am wondering if this directory is still relevant? It seems like most of what should go there has a better home elsewhere, and the directory itself adds clutter to the root position. Also the last meaningful commit on scikit-bio/ipynbs was on Jul 9th 2014 when I added Greg's scipy talk (which is also present on our site in rendered form).

I think it could be dropped, maybe in favor of a separate repo for
presentations?
Sent from my phone, please excuse typos and brevity.
On Mar 27, 2015 4:03 PM, "Evan Bolyen"<EMAIL_ADDRESS>wrote:

It's been about a year since we created that directory and there are only
two presentations in it (both out of date at this point). I think the
initial intention was something very much like the current
scikit-bio-cookbook https://github.com/biocore/scikit-bio-cookbook so I
am wondering if this directory is still relevant? It seems like most of
what should go there has a better home elsewhere, and the directory itself
adds clutter to the root position. Also the last meaningful commit on
scikit-bio/ipynbs was on Jul 9th 2014 when I added Greg's scipy talk
(which is also present on our site in rendered form).
--
Reply to this email directly or view it on GitHub
https://github.com/biocore/scikit-bio/issues/884.

:+1:


Live Server does not wortk

It's been happening for about a month. I can't open live server on command (alt+L, alt +O). It doesn't show on bottom of task bar.  I restart Visual Code more than twice to get live server to start. Also when I right-clikc, the live server option is not stated/ its not an option. Please help me solve this issue. I am wasting valuable time trying to find a solution.
Thank you.

After upgrading to 5.6.1
I have the same problem
Go Live button is missing

If you do uninstall & install?

or if you delete live server folder from
C:\Users<USERNAME>\extensions\ritwickdey.liveserver-5.6.1\

Ritwickdey !!!
thank!!!
It all worked!!!

In mine the live server launches outside Visual studio? Also it does not run my index.php file. Was this only meant for html files?

I am confused. So I uninstalled and reinstalled live server at Visual Code. Nothing happened. The only error-- Open a folder or workspace (File-->Open  Folder).
I am going to try to delete from C: Users now. I'll give you an update.
Also is live server only meant for HTML's only? I'm in the process of learning Javascript and it requires Live Server as per my tutorial.

So I checked for live server in the C drive: users, etc... There is no live server extension. But this is installed in Visual code. What did I do wrong? Please advise.

Live Server is static files (Means HTML, CSS & JS).... (yaa it supports php, but that needs different configurations. Check for 'Live Server Browser Extension'
@livia7916 can you please share a screenshot of the directory?

C:\Users<YOUR_USERNAME>\extensions\ritwickdey.liveserver-5.6.1

I do not have -- \extensions\ritwickdey.liveserver-5.6.1 in my C drive.

Should I delete Microsoft Visual Code and reinstall? What is your advice?

yaa.. You can. meanwhile you can take a look into it https://www.google.com/search?q=windows+user+directory&oq=windows+user+direc&aqs=chrome.1.69i57j0l3.9785j0j9&client=ms-android-xiaomi&sourceid=chrome-mobile&ie=UTF-8

Hi
I uninstall and reinstall Microsoft Visual Code and there's still no LIVE SERVER. What is the next step?
Thank you for your patience I am a newbie.

OK so I restart and followed the open a folder. And the GO LIVE button is on the bottom task bar. But when I open file and it does not show in browser as you can see. What am I doing wrong?

FINALLY FIGURED OUT MY ERROR. Thanks you.

I cant delete ritwickdey.liveserver-5.6.1 it won't let me


What is the connection between grounds.io and grounds-exec do I need both?

Hey just reading through the documentation trying to set up locally etc... what is the connection between grounds.io repository and the grounds-exec reposiotry, and how do I make them work together?
And as a side note, what role to grounds-images play, is the actual code runner in there? All very exciting :)

Grounds is splitted in three main parts:
grounds.io: The web application.
grounds-exec: The code runner.
grounds-images: A docker image builder, to build every language stack images required by Grounds (e.g. C#, Ruby, Golang, ect...).
grounds.io already includes grounds-exec through its docker image, docker-compose will run a instance of grounds-exec in the background and resolves its url according to the environment variable: DOCKER_URL.
You can check this file https://github.com/grounds/grounds.io/blob/master/docker-compose.yml which describe the whole stack.
If you have docker installed and the Docker API exposed to the outside world it should be pretty straightforward, you only need to follow the documentation of grounds.io: https://github.com/grounds/grounds.io/blob/master/README.md
If you are new to docker, do not hesitate I will gladly do my best to help you :)

Thank you, will keep trying and let you know if I hit any issues (very new to docker) thank you so much!


Connecting without using USB cable for the first time

It is possible to connect without using a cable at all (at least on some devices). All the information needed is IP address of the device. Is it possible to implement inputting of IP address within the plugin GUI? It would be much more convenient if a cable is not required.

This feature is not implemented. As far as I know, connecting the device to the computer was mandatory. At least it was mandatory when I developed the plugin. I'm going to mark this feature request as an enhancement in case any contributor would like to send a PR 😃


Inconsistent use of information pop ups

Example: https://frontend-v2-test.apps.silver.devops.gov.bc.ca/entity/FM0389260
On the company results page, the left hand column has inconsistent use of information pop ups:

The titles Credentials, Authority and Registration type all have info pop ups, but Credential type, Date effective, and Show Expired do not.  Show Expired is somewhat self explanatory, however the others could use info pop up for consistency.

To be assigned to @DJ-Gordon to define the text, and then to @wadeking98 to add in.

In this conversation here: https://github.com/bcgov/orgbook-bc-client/issues/31#issuecomment-946120547. Credential type is not needed as per @alexgmetcalf 's comment. I'll add the wording for date effective and show expired though once I get the wording

Priority for cleanup.


Send button positon fix(mobile/tablet)

hi @auniverseaway,
are you fine with this change? would be great to get a review and merge if it's fine. thx!


Fix plugin not working on ample-desktop & mobile

Try a fetch and retry it without the CORS proxy if we get a 400 error (happens when making calls to a cors-anywhere proxy from outside a browser).
Also added a small change that should ensure we don't insert empty strings inside dashboard tables, which can produce errors down the line. This one will be completed with further fixes to address a user-reported issue.

I'll take a look this week at whether we can let the origin-less request through the proxy / why they are getting blocked. Note that you could check location.origin === "https://plugins.amplenote.com" to decide whether to use the CORS proxy or not (rather than checking if a request fails).


[MM-33766] Handle channel header call error

Summary
This PR makes it so when a channel header binding option is pressed, the channel info screen waits for the response before exiting.

If the request is successful, the channel info screen is exited. A app modal form is shown if the response contained a form.
If the request fails, an alert is shown and the channel info screen is not exited.
While submitting, the binding option is disabled.

For the post action call:

Pressing the binding closes the post dropdown menu, before waiting for the response to come back.
A app modal form is shown if the response contained a form.
If the request fails, an alert is shown.

Ticket Link
FIxes https://mattermost.atlassian.net/browse/MM-33766
Awaiting merge of feature/cloud-apps -> master https://github.com/mattermost/mattermost-mobile/pull/5226

Building app in separate branch.

Building app in separate branch.

/update-branch

Building app in separate branch.

Does this fix https://mattermost.atlassian.net/browse/MM-34112 ?

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/14531
https://circleci.com/gh/mattermost/mattermost-mobile/14530

Artifact links:
https://14531-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.ipa
https://14530-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.apk

@aaronrothschild I have done some testing on this and see the same behavior as described above. Maybe you or @abhijit-singh have some thoughts on if the post menu should stay open when an error occurs to make the behavior more consistent with the channel menu.

@aaronrothschild I have done some testing on this and see the same behavior as described above. Maybe you or @abhijit-singh have some thoughts on if the post menu should stay open when an error occurs to make the behavior more consistent with the channel menu.

IMO - we should keep the menu where the failure occurred - open.  This way the user can quickly retry (after dismissing the error message) if it is a recoverable error (like a server is down temporarily).

IMO - we should keep the menu where the failure occurred - open.  This way the user can quickly retry (after dismissing the error message) if it is a recoverable error (like a server is down temporarily).

I differ from this, it can make the app "feel" slow because nothing is happening while you wait, perhaps add a retry option in the error being displayed so the user can reply quickly without affecting the current UX

@mickmister I synced up with @aaronrothschild & @DHaussermann and we're on the same page that we keep the behaviour as you've implemented and described in the summary above. Here's the logic we agreed on -

So we currently have different behaviours for the two menus. Clicking on any action in the 'post actions menu' first closes the 'post actions menu', whereas any action in the channel menu does not close the channel menu and even brings the user back to it after taking the respective action.
For instance, clicking on Edit Channel in the Channel Menu opens a form and then brings the user back to the channel menu on Save.
In the Post action menu, clicking on something like Edit, first closes the post action menu and then brings the user to the post editing UI. And clicking on Save from there takes the user back to the center channel.
I know we're talking about error states here and I tried to produce them as well. The two menus seem to have different behaviours currently, so we should keep it that way unless we feel strongly about this and are willing to make that change for all kinds of actions, not just for apps.

I think I need to clarify.

post menu is a slide up modal that serves as a touch & go options
The chsnnel info is a SCREEN like the center channel, those actions taken here will take you to a different screen in the app (part of the navigation)

For me it is absolutely obvious that the behavior of the two should not match as the are different navigation elements.


neomake_make_modified causes error

When the option g:neomake_make_modified is set to 1 Neomake causes an error because it tries to invoke a function without the keyword call before, so vim understands it as a command.
The call keyword should be placed before the function invocation.
The line 212 of the file autoload/neomake.vim causes the error:
neomake#utils#LoudMessage('Neomake: wrote temp file '.makepath)

For me putting a call before the line solved the problem
call neomake#utils#LoudMessage('Neomake: wrote temp file '.makepath)

Thanks for finding this! It would be awesome if you could submit a pull request for this, since I'm not sure if I'll have time to work on this today.


Stub cannot catch NSURLSession requests when used with custom protocolClasses

When an app that is making NSURLSession requests sets a value to the optional config.ProtocolClasses array, OHHTTPStubs cannot catch the request, thus it also cannot reply with the stubbed response.
Can OHHTTPStubs even do anything about this?
Snip of app code that's initializing the NSURLSession
NSURLSessionConfiguration *config;
    config = [NSURLSessionConfiguration defaultSessionConfiguration];

	// You have to explicitly configure the session to use your own protocol subclass here
	// otherwise you don't see redirects <rdar://problem/17384498>.
	config.protocolClasses = @[[CustomURLProtocol class]]; // <---- the offending line. Remove it and OHHTTPStubs works.

Yes, just use the dedicated method [OHHTTPStubs setEnabled:YES forSessionConfiguration:config]; to activate the stubs on your custom configuration (and before creating the NSURLSession with it)

Or even better, don't set the protocolClasses property to a new value replacing the old one, but instead add your [CustomURLProocol] to the existing value.


【0.9.12】 执行 tidevice ps 指令报错

我们希望App一直处于启动状态，所以定时在检查App的运行状态tidevice ps。
每天都会出现批量报错。报错信息统计看基本每个设备每天都会出现2次报错。
怀疑过是设备连接过多造成的，之前链接18台设备，后来改到7台设备。但是还是会出现。

报错信息1
运行中app，指令执行出现异常内容：Traceback (most recent call last):  File "/Library/Frameworks/Python.framework/Versions/3.8/bin/tidevice", line 8, in     sys.exit(main())  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/main.py", line 742, in main    actionsargs.subparser  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/main.py", line 452, in cmd_ps    ps = list(d.instruments.app_process_list(app_infos))  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 708, in app_process_list    processes = self.app_running_processes()  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 681, in app_running_processes    retobj = self.call_message(identifier, "runningProcesses")  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 354, in call_message    channel = self.make_channel(channel)  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 315, in make_channel    result = self.call_message(0, '_requestChannelWithCode:identifier:', aux)  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 356, in call_message    _id = self.send_dtx_message(channel,  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 392, in send_dtx_message    self.sendall(data)  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_safe_socket.py", line 66, in sendall    return self._sock.sendall(data)  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/ssl.py", line 1204, in sendall    v = self.send(byte_view[count:])  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/ssl.py", line 1173, in send    return self._sslobj.write(data)ssl.SSLZeroReturnError: TLS/SSL connection has been closed (EOF) (_ssl.c:2485)

报错信息2
运行中app，指令执行出现异常内容：[E 221206 14:44:41 _instruments:594] drain error    Traceback (most recent call last):      File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 580, in _drain        self._drain_single_message()      File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 607, in _drain_single_message        mheader, payload = self.recv_dtx_message()      File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 513, in recv_dtx_message        message_id = self.recv_part_dtx_message()      File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 409, in recv_part_dtx_message        data = self.psock.recvall(0x20)      File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_safe_socket.py", line 115, in recvall        raise ConnectionError("socket connection broken")    ConnectionError: socket connection brokenTraceback (most recent call last):  File "/Library/Frameworks/Python.framework/Versions/3.8/bin/tidevice", line 8, in     sys.exit(main())  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/main.py", line 965, in main    actionsargs.subparser  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/main.py", line 582, in cmd_ps    ps = list(ts.app_process_list(app_infos))  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 737, in app_process_list    processes = self.app_running_processes()  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 708, in app_running_processes    retobj = self.call_message(identifier, "runningProcesses")  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 357, in call_message    channel = self.make_channel(channel)  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 318, in make_channel    result = self.call_message(0, '_requestChannelWithCode:identifier:', aux)  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 363, in call_message    return self.wait_reply(_id).result  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/tidevice/_instruments.py", line 568, in wait_reply    raise ConnectionError("connection closed")ConnectionError: connection closed

我也不知道怎么整？有时候只能重启手机


Smoke tests for CoderDojo login flow

Task 1 of Epic #1290
What
Integraton smoke test for login flow for existing users.
Why
To give confidence that existing login flow is not broken when working through the Profile integration
How

Cypress test hitting unmocked endpoints, to be run locally with full stack & db
Use existing Selenium login page test as template

Ran the plan by @ArayB this morning and asked about getting my local db in shape

Warned me that it's currently a 2gb+ mock data download
He's figring out a more managable setup db script while I get started on the tests then we're going to jump back on a call to run the scripts and update zen repo docs.


⚠ Bofrost.de has degraded performance

In c252804, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1100 ms

Resolved: Bofrost.de performance has improved in 6bde31f after 3 hours, 20 minutes.


Problem with resolution enum

The "Standard timing" resolutions are not shown correctly, since the bitwise detection (line 151) is incorrect.
Can you replace:
bit = raw_edid.timings_supported & 1
With this:
bit = raw_edid.timings_supported & (1 << i)

Fixed in my version. The Pypi package is currently maintained by @dd4e.


Error while installing the package on macbook M2 Air Ventura 13.3.1

The error is as follows :
Package poppler-qt5 was not found in the pkg-config search path.
npm ERR! Perhaps you should add the directory containing `poppler-qt5.pc'
npm ERR! to the PKG_CONFIG_PATH environment variable
npm ERR! No package 'poppler-qt5' found
npm ERR! gyp: Call to 'pkg-config --cflags  cairo poppler-qt5' returned exit status 1 while in binding.gyp. while trying to load binding.gyp

Also After fixing PKG_CONFIG_PATH a new error comes.

Hello @satyajitnayk 👋
I have the same issue on a M1 MacBook, did you find out how to fix it ?
Thanks in advance :)

Unfortunately no, sorry,

Hello, I was able to install it by following the steps mentioned in this comment : https://github.com/tpisto/pdf-fill-form/issues/104#issuecomment-1195150975. Please also note that it will not work with<EMAIL_ADDRESS><EMAIL_ADDRESS>is required.
However, all these downgrading doesn't seem like a durable solution to me. I'm afraid that I'll have to look for another package 😅

No solution so far @lucienbl . but it working in my pro environment which running ubuntu & node version 15.


Cable/Pipe Malfunction

Issue description:
So, I've already looked through closed issues and found a similar group of people having the issue, but on an older version of mekanism here: https://github.com/aidancbrady/Mekanism/issues/2733
This is occuring with all pipes/wires, the server is running Mekanism, Generators, and Tools 9.4.1 for all.
Steps to reproduce:
The way to reproduce this never seems to be consistent, we've only been able to narrow down that is has to do with chunk loading and de-loading, as it never occurs 100% of the time, and the example picture i've pasted into this is at my location.
Having teleporter blocks with anchor upgrades littered around the place seems to be the only way we have to stop this from occuring, and even it doesn't always work.
Version (make sure you are on the latest version before reporting):
Forge: Mod Loader <IP_ADDRESS>, and Minecraft Forge <IP_ADDRESS>5
Mekanism: As stated above, 9.4.1
Other relevant version:
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
[gist/pastebin/etc link here]

My apologies if i'm placing this in the wrong place or not including enough information, as I haven't really done this sort of thing much but this problem is coming up too often for us to ignore.
I can offer more information upon request.

It does sound a lot like issue #4676. Can you confirm with a network reader (or something) that the cable which malfunctions has no network?

I'm not too sure what that is.  Do you mean any kind of machine that takes a power input?

The problem does sound very similar after rwading it, however the problem can crop up as soon as i connect to the server.

Something else of note I just noticed when setting up another anchored teleporter block: Trying to connect a cable to a group of cables that was already running power through it(and was supplying it to machines fine) would not draw energy from the old cables to the new, despite the old ones working fine.
Also, placiing energy cubes seems to help sometimes? Some of the cables that run out of cubes work fine, while the only one that breaks consistenty is in the supplied pictures above.
For the old cables to the new working fine cables:

Also, picture of logistical sorters not working as to the right there is a mob spawner room where the relocators are operating fine but the items are not being removed via pipe:

Yeah this is the same as the other cable issues. @thommy101 did we backport the 1 fix we did make so far?

@thiakil Looks like 9801b12b62d93a21b8ed5774fcb6f38fd847980a isn't in 1.10.

Can you confirm with a network reader (or something) that the cable which malfunctions has no network?

@Satrman Could you please confirm the thing I asked earlier? The network reader is an item from Mekanism which you could craft.

Just checked the network reader, two readings came up on the cable

The reading on the 2nd picture continues to the energy cube down the line, which is 15 pieces of cable away from where I took the readings, from which the cable going in and another cable going out are working fine.

Looking at the two picture (and the coordinates from your minimap) it is indeed the same as #4676.
The breakage point is exactly on a chunk border, and some transmitters do not have a network. Two of the indicators it's the same issue.
It's an issue which is still on our radar, but we haven't found the fix for it yet.

This MUST be fixed. I am going to have to reset my world completely because of this.

A temporary fix for this that i've been using to some success is placing Teleporter Blocks with Anchor Upgrades every chunk, and using Quantum Entangeloporters to shorten then number of both pipes/cables/sorters and teleporters.
It's an expensive way, but it works until this gets fixed.


Center Align the profile picture

The current profile picture is slightly of to the left which is bad for aesthetics...

I can work on this issue
I am submitting a PR solving this issue.


Allow wasm32 compilation

This allows for compilation to wasm32. These changes are necessary to build for things like https://hakana.dev

Thank you for the PR !
Overall it looks good, but I have a few points I'd like to discuss internally before completing the review here. I'll come back to you asap

Thank you ! The PR is in good enough shape. I'll merge it soon.

@muglug Thanks again for the PR :)


Implement HTTPS

Close #11
It's nothing difficult. The only bit that is not implemented is the API. I'm waiting for a review of #106 to decide what to do next.

This should now be good to go.
There is one unresolved question: what to do if the client connects to an SSL server?
To my surprise, OpenSSL generates an error if a client tries to connect to an SSL server through regular HTTP.
I tried sniffing packets from real HTTPS websites to see what's going on, but it looks like the browser will automatically use SSL if you use port 443, even if you type http://example.com:443.

I discussed a bit, and the unresolved question is in fact not a problem. If you try to connect to https://google.fr:80 or http://google.fr:443 with an older browser you get an error from the server for both.

FYI, travis is failing

I have some nitpicky comments, but no point in holding this up for them right now. Thanks!


Add deps badge to README

Hi there,
I'm the maintainer of Inch CI and this PR pitches my latest project for the Elixir community.
Here comes the pitch:

You already know the Inch badge on the right: It shows you an analysis for your Elixir project's docs. The new badge does the same thing for your dependencies.
Behind the badge works a CI service written in Elixir which can notify you whenever important updates for your Hex packages are released.
This is still in its infancy, and I want to basically invite you to join the beta to test-drive this. I really believe that we can create a great service for the community with this. That said, don't feel any obligation to accept the PR. You can't hurt my feelings by voicing your honest opinion about this idea!

Thanks.


Failed to triangulate concave polygon

https://github.com/fzi-forschungszentrum-informatik/Lanelet2/commit/1c521a116fde6fffd67453042ed905d69736ea9b
I have tried triangulation function added in above commit, but it seems to fail with concave polygon.
White lines represent boundary of lanes, and light blue polygon is triangulated result.

Hm, that looks strange. Can you provide us a file with your lanelet so that we can look into this?

This actually occurs with your sample file as well. Here is the result of triangulation of lanelet 45030.
Original shape of the lanelet.

Triangulation Result:

Here's the code I used to generate the result.
#include <lanelet2_core/primitives/Lanelet.h>
#include <lanelet2_core/geometry/Polygon.h>
#include <lanelet2_io/Io.h>
#include <lanelet2_io/io_handlers/Factory.h>
#include <lanelet2_io/io_handlers/Writer.h>
#include <lanelet2_projection/UTM.h>
#include <cstdio>

namespace {
std::string exampleMapPath = std::string(PKG_DIR) + "/../lanelet2_maps/res/mapping_example.osm";
}  // namespace

void triangulation();

int main() {
  // this tutorial shows you how to load and write lanelet maps. It is divided into three parts:
  triangulation();
  return 0;
}

void triangulation() {
  using namespace lanelet;
  projection::UtmProjector projector(Origin({49, 8.4}));  // we will go into details later
  LaneletMapPtr map = load(exampleMapPath, projector);
  LaneletMap triangle_map;

  const auto lanelet = map->laneletLayer.get(45030);
  const auto polygon2d = lanelet.polygon2d();

  const auto triangles = geometry::triangulate(polygon2d);
  for(const auto& triangle : triangles)
  {
    Points3d points;
    for (const auto& index : triangle)
    {
      const auto pt = polygon2d[index];
      Point3d new_pt(utils::getId(), pt.x(), pt.y(), 0.0);
      points.push_back(new_pt);
    }
    // add first point to close loop
    points.push_back(points.front());

    Polygon3d triangle_poly(utils::getId(), points);
    triangle_map.add(triangle_poly);
  }

  write("triangle_map.osm", triangle_map, projector);
}

Normal Delaunay triangulation creates convex hull of a polygon. You need constrained/conforming Delaunay Triangulation in order to triangulate concave polygon.
https://stackoverflow.com/questions/1858307/how-do-i-cut-triangles-out-of-a-concave-delaunay-triangulation

You are correct, the implementation is flawed.
Unfortunately, boost does not offer constrained Delaunay triangulation. The convexPartition function overcomes this by merging triangles inside the polygon and stopping at the polygon border. A similar approach could be considered for the triangulate function.
@poggenhans I don't see any other reasonably simple solution for this.

It might be worth taking different approach.
One idea I can think of is reusing some functions in calculateCenterline().
Current implementation in Lanelet2 seems to "progress" index either in leftBound or rightBound in order to calculate centerline, which is can be used for doing triangulation. It doesn't have same property as Delaunay triangulation, but you can still achieve the goal of triangulating concave polygons.
I drew an image with blue line.

Sadly, the centerline algorithm is not suitable for this approach. It is similar to Delaunay triangulation, but it takes a few shortcuts.
There are some cases (with very crude polygons), where the triangulation cannot be done by simply connecting points from the left and the right side.
A simple "hack" would be to filter the triangles with a point-in-polygon test after triangulation. But I suppose the overhead compared to the solution @joeda suggested is quite high.


Experimental: Separate "build" from "up" stages in DDEV Start()

The Issue
People sometimes struggle with debugging .web-build/Dockerfile.* items because it doesn't give good output unless there's an error.
How This PR Solves The Issue

With export DDEV_VERBOSE=true ddev start shows the output of the build stage and also the full output of the "up" stage, including start.sh, etc.
ddev debug refresh always shows the output of the build stage.
Added DDEV_VERBOSE=true to the troubleshooting.md page.
Added unconditional timestamp to util.Debug() output

TODO

[x] Change docs to say DDEV_VERBOSE shows build info
[x] DDEV_VERBOSE add to docs about debugging Dockerfile

Manual Testing Instructions

[x] export DDEV_VERBOSE=true && ddev start
[x] Compare start time to previous versions

I compared ddev start times with this against upstream/master and I don't believe it does any harm.


Rewrite Project using SharedInformers

Right now the project is using the client-go library and the rest k8sio APIs to query the API server each time the request comes in. This idea is surely not scalable if the traffic increases. I want to rewrite the project and use ShardInformers in place of multiple calls to API Sever of the master node.
If you wanna ask, why didn't I make the project using shared informers in the first place, I just wanna say:

This seems tough for sure but not impossible!


[WIP] Validations

Third time's the charm.
This PR is the beginning of the inline validation system refactor. It won't replace all of the validation system at once, but the idea is to add the new components in place and then work on getting the rest of the forms upgraded bit by bit.
TODOs for this:

[ ] Facebook & Twitter validator cleanup
[ ] Tests

👍 looks good so far, should hopefully clean things up a lot 😁
One thing I I'm not too sure about is the util for creating a mixin. I'm wondering if it would be simpler/cleaner to use the standard changeset=(changeset ...) helper and ensure that we pass the changeset around as an argument to actions/tasks. From what I can see the mixin is being used so that  the generatePassword observer can still function but it seems like it may be better to drop the observer and instead have an update action on the isPrivate checkbox control that generates the password if necessary?

@kevinansfield yeah - that was a bit of a weird approach. The problem I was running into is that by default the changeset object is passed to the submit action from ember-form-for when you click the submit button, but if you just press "cmd+s" then the save action is called with no changeset which leads to errors. There is probably a need to refactor the keyboard shortcut handling across the app (at some point) but didn't want to do that with this PR. The util for creating a mixin was intended to avoid the same code in each controller that needs a changeset.
The other approach to it would be what I did in previous refactor attempts, which was to define a changeset object on the model itself - however it's probably better performance-wise to have it be done in the controller/template like I did here.
I'm definitely all for removing the util - just didn't see another way as I was doing it and am completely open to suggestions 😄

The problem I was running into is that by default the changeset object is passed to the submit action from ember-form-for when you click the submit button, but if you just press "cmd+s" (behavior defined in Ghost itself) then the save action is called with no changeset which leads to errors.

Good point, I'm not sure there's a way around that at the moment without updating the keyboard shortcut to trigger the form's onsubmit handler.

Good point, I'm not sure there's a way around that at the moment without updating the keyboard shortcut to trigger the form's onsubmit handler.

Which I initially tried to do, but it didn't work because the cmd+s shortcut is set to 'all' scopes - making it impossible to override (I tried lots of ways 😕 ). I'd say the best thing for this PR at least is to maybe find a better way than using the util, then work on refactoring that little bit out once we've addressed the keyboard shortcuts issue.

Don't spend too much time trying to make things perfect, I'd say keep the util for now, it's the validations side of things which is more important and has more effect on other code. We can circle back and revisit the util and keyboard shortcuts later on.

Hey @acburdine 👋 I'm going to close this as it's now quite out of date 😬
I'm of two minds at the moment for how to handle this in the future. On one side we could push forward with moving some validation and maybe trickier bits of "unsaved change" handling to ember-changeset now, on the other we could wait for the Ember Data ModelData work to land which should open up store forking which would have a similar effect to ember-changeset.


Update: Style.css

Related Issue - Updated style.css
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #(issue no.)#1420
Description
[Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]
There was a lot of margin between Navbar and Hero Section

Type of PR

[x] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]

Checklist:

[x] I have made this change from my own.
[ ] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

Conflicting files
assets/css/style.css
Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!