Configure Storybook for Sage Repo

What
In the previous iteration of Storybook on the Rage repo, we were able to render off components and manipulate their state using the controls. But Storybook is capable of so much more, and we should take advantage of some of the awesome features it provides.
Here's a few things that would be great to add into our Sage Storybook.

[x] Documentation support
[x] Global styles and theming (https://github.com/HausDAO/daohaus-monorepo/issues/53)
[x] Ability to switch between dark/light mode in the storybook interface

Thinking around documentation support:
After snooping countless storybook and component lib repos, I've noticed a few things:

We could spend all year on documenting things in Storybook. Storybook is very useful, but I can't help but wonder if it hits a point of diminishing returns.

MDX Docs work, but not the way I thought. I thought we could have our canvas as a place to interact with the component, then have the docs panel as place to go further in depth. However the docs panel is just a utility that automatically lists out all the subcomponents with a specific story. In summary, I could not find a way to have a regular story + a MD doc per component. Trying to do both causes a collision error, then neither story ends up rendering. I couldn't find a repo in the showcase that solves this.

We are given a pretty sweet path system that we can use to group the stories. Some obvious groups that come to mind are Atoms/Molecules/Organisms, but also global styles. Monday.com had a cool section for 'Foundations' that I thought would be really helpful.

Conclusion:
I think there's a way to get 80% of the benefit of storybook while investing 20% of the effort. GitHub's React Primer libary does a pretty decent job of this.
https://github.com/primer/react
They use the story to separate different states and subcomponents of each atom. Then on the docs page, story book automatically lists them out.
Story code:
https://github.com/primer/react/blob/main/src/Button/Button.stories.tsx
The Story:
https://61a90feace7802003a4d9c45-jtvdedpfdr.chromatic.com/?path=/story/composite-components-button--default-button
There's no MDX. But there's an example of the component, the name of the variant, and most importantly, the ability to see the code we use to achieve this effect. In my mind, this is a great low-overhead way to move forward without getting bogged down in low-impact documentation overhead.

Review notes:
Needed to add a useEffect to help story book toggle the context's theming from the top level.
There's a slight flicker after every save as storybook switches into darkmode (the default). It's slightly annoying.
-- Fixed by implementing storybook's background parameters.This ensures that the background is the same color before loading the context.

Next step: https://github.com/HausDAO/daohaus-monorepo/issues/36

Closed by https://github.com/HausDAO/daohaus-monorepo/pull/55
Next step is #36 like @earth2travis mentioned above.


Handle switching node data-dir for different networks

Rationale
Previously the go-spacemesh takes care of creating subdirectories under the node data-dir to make it possible to connect to different networks:
https://github.com/spacemeshos/go-spacemesh/blob/5279493f46a831e26293719013ad86a079387732/config/config.go#L60-L62
But the latest changes in the develop branch got rid of this logic and now Smapp should handle it:
https://github.com/spacemeshos/go-spacemesh/blob/develop/config/config.go#L63-L67
Besides this, we should take into account that we won't have a short network-id anymore and will have a genesis-id (hash).
So it might be too long (and problematic) for Windows that is using short paths. Probably we can shorten it using a couple of first chars from the hash and a few latest ones, and then pray there will be no collisions :D
Prerequisites

https://github.com/spacemeshos/smapp/issues/949
We need to add support for genesis id into Smapp to switch to the latest go-spacemesh binary.

Acceptance criteria

[ ] When user switches the network, Smapp should also switch the node datadir to a proper one

Done within https://github.com/spacemeshos/smapp/commit/10ca506fbe737b3362f7a774bb7f4ae27d350d7a


Current weapon release state as of 3-16 and 2.3.2

I saw no development on this since November and thought I would jump in.
Changes Made:
-Special Points Edited
-Released weapons
-Subs and Specials fixed.

Thank you for the contribution and assistance! I'm resuming work on this project now.


Gateway retry and timeout design

The current design has the gateway timeout with always a minimum of 65 seconds. This causes high latency issues when there is a transient networking problem or other issues with gateway.
Proposed guideline:
Metadata operations
Non-hotpath (Account information)
Read:
5 second timeout (No delay on first retry)
10 second timeout
20 second timeout
Hotpath (QueryPlan, partition key ranges, address refresh)
Read retry in the same region.

For 1, this basically would mean requests for metadata resources (Databases, Collections, etc), and also Query Plan?
Should backoff be exponential?

Metadata operations
Non-hotpath (Account information)
Read:
5 second timeout (No delay on first retry)
10 second timeout
20 second timeout
Hotpath (QueryPlan, partition key ranges, address refresh)
Read retry in the same region. Does not impact region failover:
.5 second timeout (No delay on first retry)
5 second timeout
10 second timeout
Create, Update, Delete:
65 seconds
Timeouts will kill the connection.

@j82w : Does Query follow the same timeout patterns as Read?  What about ReadFeed operations?

This is only optimizing control plane requests. I was told the default is 65 seconds to allow gateway to handle split scenarios.

@sivethe just to be clear all item operations like read, query, ReadFeed, ChangeFeed, etc all follow the 65 second timeout for gateway mode.


All wormholes show up as shattered, no statics.

As in topic. Fresh install, databases set up without problems, everything appears to be ok but every single wormhole is listed as shattered and shows no statics.

You probably have not imported some static data into your pathfinder DB. after setting up all the tables correctly.
https://github.com/exodus4d/pathfinder/blob/master/export/sql/pathfinder.sql
I think I forgot to mention this in the wiki. These data are necessary for static-WH information and jump-route configuration.

That was it, fixed with simple
mysql -u pathfinder -p pathfinder < /pathfinder/export/sql/pathfinder.sql

This is still not mentioned in the wiki or at least at a place not visible at first.


Please Add Sympli in Design to Code Tools category.

Hi, thanks for the useful resources in the repo.
I understand that Sympli versions was added to the Version Control Section, however I've found the design to code features of Sympli helpful for mobile developers as well. Please consider adding sympli.io under Design to Code Tools category.

+1 for Sympli. Although I think the proposed category is a bit off: the ability to generate code snippets is not the primary use-case for Sympli. It's a design handoff tool, so maybe let's create a new category (e.g. "Design Handoff Tools") and put it right there?
// cc @valianka

@rodionovd & @alistairholmes, probably it's time for "Design Handoff Tools section. I'll do it over weekend


Add depoyment for sonataflow services

@masayag @gabriel-farache Do we want to continue working on this PR?


Bad link in "Revisions object"

Hi,
In the Revision object (7f267a64-885a-cb4c-008a-e8545cea94d2.md) and Revision Object Members (../97eb185c-125a-1c5f-6f54-157fd5bbf355.md) articles:
The link Revision object point to SmartArtLayout Object (../f8d9db83-86f7-4830-096d-5d15368ab6b1.md). The target article should be "e6f64467-a438-88f1-60f9-975365a1430e.md".
Could you fix that?

Thank you for identifying the error. I have made the fix to both files.


[BUG]: Firebase Auth failure message

I have found an issue with the login page . It shows firebase: Error when the wrong credentials are applied, I can contribute and help you change it with a good ui and message.


1287 delete draft banner

For https://trello.com/c/bE8Uz9e6/1287-delete-draft-banner
This changes the way that the delete draft action confirmation is handled.
Currently, an alert is used to request confirmation of deletion, this change introduces a new page confirm_delete_draft for that purpose.
The current use of an alert is considered an incorrect use of the pattern. So this change brings the action in-line with other actions, such as scheduling, removing content, change history mode tag, etc.
Before...

After...

Thanks for the comments Peter - makes sense.  Have now re-ordered the commits.


Improve graph reader error handling

/intelci: run

Parsing of Edge List Files and Error Handling was improved. All open questions were resolved


Define target between 0-100

During my past work on slo-libsonnet I had several people point out that writing targets between 0-1 by hand seems weird and not intuitive.
Especially targets like 99.5 are a lot more readable than 0.995. Given that OpenSLO is also meant to by written by hand I wanted to bring it up here, as it's been brought up with me before.
It's somewhat related to #24 but still different enough to have a separate issue, I believe.

This is unfortunately settled in the spec and it's indeed a bit weird.
Fix would be either of:

add: targetPercent or
interpret target as percent if value >1.

Though the second option is probably too weird.

Keep in mind that whilst v 1.0.0 of the spec has been published, the spec is there to be moulded, challenged, and shaped by comments exactly like this.
I suspect this issue was missed by some of us (I certainly didn't see it!), but it definitely makes sense that some way of helping people write "human-readable" percentages rather than "computer accurate" percentages should be incorporated at a future date.

Related a little bit duplicated issues https://github.com/OpenSLO/OpenSLO/issues/24 & https://github.com/OpenSLO/OpenSLO/issues/137 (comment added for visibility)

With #155 getting merged, this is now resolved, closing.


Clip Contents has no effect on TextEdit Control

Tested versions
v4.3.dev3.official [36e943b6b]
System information
Linux Kubuntu 23.04 KDE Plasma Version: 5.27.4 KDE Frameworks Version: 5.104.0 Qt Version: 5.15.8
Issue description
Clip Contents property has no effect on TextEdit. Although the default is Off, it behaves as if it is always On.
Steps to reproduce
Add a TextEdit to a scene and add a child Label or Button with some description and or background colors. Drag the Label or Button control away, you will notice it gets clipped. Trying to adjust Clip Contents to on or off, has no effect. I only noticed it with TextEdit. Other controls obey the Clip Contents setting.
This code will not work either:
extends TextEdit

func _ready():
	clip_contents=false

But this code works:
func _draw() -> void:
	RenderingServer.canvas_item_set_clip(get_canvas_item(), false)

Attached is sample screen shot  with TextEdit and Label and Button as children. The other controls obey Clip Content

Minimal reproduction project (MRP)
See screen shot and description.

Does anyone know why clipping is set to true here?
void TextEdit::_notification(int p_what) {
	// ...
	case NOTIFICATION_DRAW: {
		// ...
		RID ci = get_canvas_item();
		RenderingServer::get_singleton()->canvas_item_set_clip(get_canvas_item(), true);
		int xmargin_beg = theme_cache.style_normal->get_margin(SIDE_LEFT) + gutters_width + gutter_padding;
		// ...
	} break;
	// ...
}

Changing it to
RenderingServer::get_singleton()->canvas_item_set_clip(get_canvas_item(), is_clipping_contents());

seems to work for me, but I don't want to break some important functionality.

This should be a bug, not an ehnacement. The user should be allowed to chek/uncheck clipping as desired.

It's not a bug, it's a missing feature, so that's considered an enhancement

FYI: The Clip Contents (clip_contents) checkbox for TextEdit is there in the inspector. See my screenshot above. It just doesn't do anything when you click it on on/off, but it is saved and loaded with the scene.

It could be argued, that this is a bug, because changing clip_contents has no effect. I believe it is in the gray area between the two and changing it will not have an impact on when the pull request gets merged.


Moved random generator to it's own function so it can be overridden.

If you're into fun with random number generators :)

+1 Looks good, maybe allow the size to be specified? Just forward thinking :)
BTW, I don't really maintain bitcoin-lib-php much, I'd suggest looking at this: https://github.com/Bit-Wasp/bitcoin-php This is probably easier to achieve with this library, which accepts an RbgInterface where random data is required.


IncludeGraph and CalculateStats: StatsInfo returns only counts of last processed batch

When using BulkImportOrUpdate with both IncludeGraph and CalculateStats set to true, the stats aren't calculated right.
They seem to only return the stats of the last processed batch.
I've updated the Test IncludeGraphTests.BulkInsertOrUpdate_EntityWithNestedObjectGraph_SavesGraphToDatabase and added CalculateStats = true, and the resulting bulkConfig.StatsInfo.StatsNumberInserted equals 4, while it should be 12.
I think I know how to tackle this one... I'll create a pull request shortly...

PR merged, thx for contrib.


Make newBinaryIO public

Make func newBinaryIO(...) (runc.IO, error) public so third-party runtimes
can reuse it for binary shim logging (and use in conjunction with logging.Run(...)).
Signed-off-by: Maksym Pavlenko<EMAIL_ADDRESS>

Codecov Report

Merging #3348 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3348   +/-   ##
=======================================
  Coverage   44.75%   44.75%
=======================================
  Files         113      113
  Lines       12513    12513
=======================================
  Hits         5600     5600
  Misses       6057     6057
  Partials      856      856

Flag
Coverage Δ

#linux
48.65% <ø> (ø)
:arrow_up:

#windows
40.2% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062d056...bca5667. Read the comment docs.

LGTM

LGTM (not a maintainer, but I find this useful)


Add contracts inline documentation

Add a section to output contracts inline documentation.
We should add documentation for both lib contracts and token/vouching contracts.

Addressed by #300


Adding Settings View with two new settings

Reorganized the messaging flow for settings, added new interfaces for theme and keep on , then added interfaces and functionality for font size and refresh rate

resolves #21 and #33

Merged! thanks @mrkmndz. In linux was impossible to click the settings buttons because the draggable area. So I added another drag-bar to move the window and removed the draggable behavior from header. I've already asked to @silvestreh for help with the new settings ui.


Add support for initial effects cleanup

This PR aims to enable cleanup for effects that are executed as part of the state initialization.
Was there a particular reason this was not possible in the first place?
Please note that 32cff1d needs some attention before it can be merged. I had to @ts-ignore an error that should probably not have to be ignored. It seems this error is disappears in later TS versions (>3.8), but I'm not sure when/why. At least, all was good when I was using TS 4.0.3, which was the globally installed version on my machine. Have not tested with other versions. The error would also disappear if I just added some extra type narrowing by doing
fetchData(_, effect) {
  setTimeout(() => {
    if (effect.type === "fetchData") {
     dispatch({ type: 'RESOLVE', data: effect.data.toUpperCase() });
    }
  }, 20);
}

but it seems like that shouldn't be necessary. Is this a known issue?

Thanks! Are you using the latest version of TypeScript? I don't get any TS errors locally with this.

Thanks! I don't get any type errors with TypeScript v.4.1.x (which is the latest version on VS Code).

Sorry, I should have added that the error only appears when running the tests. Everything works fine in VS Code itself, but I guess the tests run with TS 3.8.3, since that's what's installed for the project in package.json.
I think this is the first test where a union type is passed into the TEffect param of EffectReducer, which would explain why this error haven't surfaced before.
This change from TS 3.9 might be related to fixing this error, so maybe a good option would be to update the project's TS version.
Let me know what you think, and I'll make the needed changes :)

I think upgrading TS would be a good idea, if you want to do this in this PR as well.
Thank you!

Great!
I upgraded to the latest version, but TSDX ships with a version of @typescript-eslint that doesn't support the newer TS versions, I had to add a couple of manual resolutions for those packages, otherwise I would get errors during linting (relevant-ish SO post). Hope that's OK!

Thanks for doing that! I've been seeing the same ESLint issues in other TSDX projects, so I'm glad to know there's a workaround.
This LGTM!

Awesome! Thanks for the quick responses, and for making this library in the first place - I'm having a great time with it.

Would it be possible to have this released in the near future? Feel free to let me know if there's anything I can do to help.


add Python 2.7

[x] setup
[x] change
[x] collation
[x] corpus
[x] number
[x] postaggers
[x] rank
[x] romanization
[x] segment
[x] spell

https://github.com/wannaphongcom/pythainlp/issues/5

fix in https://github.com/wannaphongcom/pythainlp/commit/a009dabd539f00999553625b2c7f3a834d46a7a7


small fixes

added images and style.css file
fixed typo for label tag in contact.html
formatted documents with prettier

this will fixes #17 and #18


Bug viewing interpreters with "Select Interpreter" command

Environment data

VS Code version: 1.25.1
Extension version (available under the Extensions sidebar): 2018.6.0
OS and version: macOS 10.13.5 (High Sierra)
Python version (& distribution if applicable, e.g. Anaconda): 3.7.0
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): pyenv virtualenv
Relevant/affected Python packages and their versions: N/A

Actual behavior
When running the Python: Select Interpreter command, there is an issue viewing the python interpreters where [Clang 9.1.0 (clang-9<IP_ADDRESS>)] is shown instead of the name of the virtual environment created through pyenv.

Expected  behavior
It should list the Python interpreter as "Name of the Interpreter (venv)."
Steps to reproduce:

Install pyenv
pyenv install 3.7.0
Install pyenv-virtualenv
pyenv virtualenv 3.7.0 test
Run the select interpreter command

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
Starting the classic analysis engine.

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
workbench.main.js:sourcemap:1375  INFO no standard startup: not a new window
workbench.main.js:sourcemap:1375  INFO No grammar found for scope source.dosbatch
workbench.main.js:sourcemap:1375  INFO No grammar found for scope source.scala
workbench.main.js:sourcemap:1375  INFO No grammar found for scope source.dart
workbench.main.js:sourcemap:1375  INFO No grammar found for scope source.smarty
workbench.main.js:sourcemap:1375  INFO No grammar found for scope text.html.javadoc
workbench.main.js:sourcemap:1375  INFO No grammar found for scope source.postscript
workbench.main.js:sourcemap:1375  INFO No grammar found for scope source.c++
workbench.main.js:sourcemap:1375  INFO No grammar found for scope source.js.jquery
workbench.main.js:sourcemap:1375  INFO No grammar found for scope source.sass
workbench.main.js:sourcemap:1375  INFO No grammar found for scope source.less
workbench.main.js:sourcemap:1375  INFO No grammar found for scope source.stylus
workbench.main.js:sourcemap:1375  INFO No grammar found for scope source.applescript
workbench.main.js:sourcemap:1375  INFO No grammar found for scope text.html.textile

This issue would fix it https://github.com/Microsoft/vscode-python/issues/1351

Thank you for the help @DonJayamanne


Change how license is rendered in README.md

Before:

After:

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


add service to task

Motivation
https://github.com/google/wireit?tab=readme-ov-file#services

closing due to inactivity, feel free to reopen if you'd like to work on it more


Does this support mac or web?

I want to use this to control the page in web

Probably web, but only on windows and Android. Its literally in the readme.

It would be very convenient if could support web or mac pages.

It is in python. Maybe you can try running it?

Re #2 #9 and I’m sure others. #42
basically it needs reworking a few libraries. It’s doable. I can’t see us doing it in  our fork as the inbuilt MacOS camera gesture is pretty good already and we are targeting windows heavily with a better upgrade and installation process . But Linux for sure it has a role.


:seedling: Move container build job to GH runner

Move container image builds to GH runners, using common image build workflow from project-infra, making workflow much cleaner and maintainable.
This solves many GH workflow<->Jenkins related issues, like false timeouts due scheduling and GH workers do not suffer from random network issues as often.

/override metal3-centos-e2e-integration-test-main  metal3-ubuntu-e2e-integration-test-main

/cherry-pick release-1.6
/cherry-pick release-1.7

/cherry-pick release-1.7


Include network in sdk config and use it to generate the notice & remove playground

Summary
A description of the changes proposed in the pull request.
Fixes #number
Checklist

[ ] Change is small and easy to review (please split big changes into multiple PRs)
[ ] Change is consistent with architecture
[ ] Change is consistent with test architecture
[ ] Change is consistent with naming conventions
[ ] New code is covered with tests
[ ] Tests related to old code are updated
[ ] Documentation is up to date with changes

Tests are failing


-BccBlocked missing description

exchange/exchange-ps/exchange/Set-DistributionGroup.md
The description has
{{ Fill BccBlocked Description }}

@bruceburge, empty parameter descriptions are a known commodity. Availability vs. functionality are two different things. You can read more about it here.
Are you being directed to use that parameter in other content?

No I am a end user trying to use the documentation
On Wed, May 24, 2023, 11:43 Chris Davis @.***> wrote:

@bruceburge https://github.com/bruceburge, empty parameter descriptions
are a known commodity. Availability vs. functionality are two different
things. You can read more about it here
https://github.com/MicrosoftDocs/office-docs-powershell/issues/7429#issuecomment-808564486
.
Are you being directed to use that parameter in other content?
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/office-docs-powershell/issues/10880#issuecomment-1561569836,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTVZAVILTB522EQQMSVNHTXHY3EJANCNFSM6AAAAAAYNT5FYM
.
You are receiving this because you were mentioned.Message ID:
@.***>

@bruceburge, blank parameter descriptions are part of doing business with 1400+ cmdlets and 14,000+ parameters. Having available but unknown parameters documented with blank parameter descriptions is the best out of a series of not too great options.
Unless that parameter somehow fulfills a scenario for you, I would say don't worry about it (hence my question about other documentation sources telling you to use it).

It took me all of a single query to find out where the exchange team explains it purpose, I'm sorry you consider not documenting the feature set of commands "part of doing business."
I get that is a large number of commandlets, but not having them documented is just a serious down fall, if they are made available for public use, they should be documented, and accepting that it isn't shows a series problem within the culture of those managing this.

@bruceburge, I added the following for the BccBlocked parameter in New-DistributionGroup and Set-DistributionGrouo:

The BccBlocked parameter specifies whether members of the group don't receive messages if the group is used in the Bcc line. Valid values are:

$true: If the group is used in the Bcc line, members of the group don't receive the message, and the sender receives a non-delivery report (also known as an NDR or bounce message). Other recipients of the message aren't blocked. If an external sender uses the group in the Bcc line, members of the group aren't blocked. For nested groups, the message is blocked only for members of the top-level group.
$false: There are no restrictions for using the group in the Bcc line of messages. This is the default value.

If you would like to edit/improve, instructions are here.
Thanks for the feedback.
Closing


Vertex elements mixed with other 3D elements don't display

Open exodus_test_data/kassbohm1.exoThe mesh contains a bunch of different element types include 3 vertex elements.They don't display in mesh plot If you hack the Exodus plugin and set topological dimension in PopMD to 0 and then display the Mesh plot with only the vertex elements selected (use SIL controls), then they will display.
-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.
Ticket number: 2034
Status: Pending
Project: VisIt
Tracker: Bug
Priority: Normal
Subject: Vertex elements mixed with other 3D elements don't display
Assigned to: -
Category: -
Target version: -
Author: Mark Miller
Start: 10/23/2014
Due date:
% Done: 0%
Estimated time:
Created: 10/23/2014 02:47 pm
Updated: 10/29/2014 11:41 am
Likelihood: 2 - Rare
Severity: 4 - Crash / Wrong Results
Found in version: 2.8.0
Impact:
Expected Use:
OS: All
Support Group: Any
Description:
Open exodus_test_data/kassbohm1.exoThe mesh contains a bunch of different element types include 3 vertex elements.They don't display in mesh plot If you hack the Exodus plugin and set topological dimension in PopMD to 0 and then display the Mesh plot with only the vertex elements selected (use SIL controls), then they will display.
Comments:

This was resolved by #4808


Workspace setup makes it hard to depend on GRPC

This is essentially the same as https://github.com/grpc/grpc/issues/11630. I'm trying update https://github.com/bazelbuild/bazel to not have it's own local copy of GRPC, but I need to setup all the binds in https://github.com/grpc/grpc/blob/007b721f8045ceef4ebf418a2935ab772fbe3708/bazel/grpc_deps.bzl for that to work.
Bind is not recommended (https://github.com/bazelbuild/bazel/issues/1952), not strictly necessary (you can refer to these targets through their repo qualified label), and requires projects that want to depend on you to know about the internals of how you have your dependencies structured.

ok, not completely the same as #11630 as they wanted a full copy in third_party. But don't think I can make protobuf's WORKSPACE file depend on grpc_deps.bzl. I could copy and paste that into their repo that opens up version inconsistencies.

CC @nicolasnoble  who handled the original issue and knows the context

Reopening as the usage of bind should be fixed

i.e. this should be reopened. I don't have the priviliges to do that here

CC @gnossen

We acknowledge this to be a valid feature request but since no one has come forward to implement this, we are going to close it for now while maintaining the label/Help wanted to indicate that this can be picked up as future work


Use TypeSystem.String instead of typeof(string) when resolving types from Cecil

How was the solution implemented (if it's not obvious)?

typeof(string) returns RuntimeType defined in System.Private.CoreLib.
System.Private.CoreLib is used from the build runtime version, i.e. 7.0.
It's getting included in the built assembly with the same version.
Avoiding typeof helps to avoid System.Private.CoreLib completely.

TIL, to not use typeof with cecil.
Fixed issues
Fixes #10859

You can test this PR using the following package version. 11.0.999-cibuild0034696-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

This is a really good find! Still not sure how typeof(string) is resolving the way it is though. Very interesting

@robloo in short, Cecil used runtime reflection to resolve and import type instead of looking into assemblies known at compile time. Quite a known problem there apparently https://github.com/jbevain/cecil/issues/895


Page title is not rendered

In my layout I have the following.
<EMAIL_ADDRESS>
This renders into HTML as...
<title></title>

I do have a "Page Title" set in the page editor in Manager.
@Page seems to be an empty dictionary.

It seems that @Page is not available in _Layout.cshtml.
Instead I have to set the Title in the ViewBag within the views themselves and use the ViewBag version in the layout.

Piranha CMS was initially created for ASP.NET Web Pages, and in Web Pages "Page" is the equivalent to "ViewBag". I must have slipped when converting the template to MVC. Strange that no one has reported this before :) I'll fix it in the next release.
Regards


Add telnet, wget, wput, curl

All handy to debug network issues

added curl in 266d5a44f808f3587796b12c5cc9fd11bcf5ed30

Less than wget I guess. You can keep it out for now.
Spelling error in the README BTW, search for Kubenates.
Thanks

Spelling error in the README BTW, search for Kubenates.
Good catch, fixed.


(example: psping <IP_ADDRESS>:3389)  in the section of Additional network captures.

there is one issue about the followig statement in the 2nd list of Additional network captures.
Use TCPing from one of the backend VMs within the VNet to test the probe port response (example: psping <IP_ADDRESS>:3389) and record results.    where is should be (example: tcping <IP_ADDRESS>:3389) or not?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fb23185b-6c56-d9f1-7ce1-758c978e08e1
Version Independent ID: 84990444-dec1-7196-cac7-9fe668b115ba
Content: Troubleshoot Azure Load Balancer
Content Source: articles/load-balancer/load-balancer-troubleshoot.md
Service: load-balancer
GitHub Login: @RamanDhillon
Microsoft Alias: kumud

@rockboyfor the <IP_ADDRESS> address is an example address of a VM that is in the backend pool. You would want to use the Direct IP for one of your backend VMs in place of the <IP_ADDRESS>.
Please let me know if this answers your question.

@rockboyfor We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


broken listmus test links

Scroll down 80% and click view tests: http://foundation.zurb.com/emails/drip.html

The issue description does not really show what is meant. I can not find any "test" on this page.


Monitor for changes in/of PHP files in workspace and add caching

Currently the workspace is scanned for PHP files (and thus, for example, for class definitions) only once per extension activation.
For the vscode extension to be truly usable, we need to monitor for changes in PHP files (in existing ones or when a PHP file is created or deleted), so we can update our class maps accordingly.
The information that comes out of the scanning (and later monitoring) of PHP files should also be cached in some way (probably via ExtensionContext.workspaceState).

[x] Monitor for changes in PHP files.
[x] Add workspace info caching.

Done in 84b8c45043cc0f2fb21f62970bd4ceb4dbb9920d.


[WIP] Add support for installing and build dependencies, install folly using externalproject add

This PR is WIP.
This PR creates a macro to allow us to download/build/install dependencies using ExternalProject_ADD.
It is being tested with Folly.
Currently this PR is able to build and run all velox tests successfully downloading and installing folly on build time. To reproduce use:
docker-compose build --no-cache ubuntu-cpp
docker-compose run --rm ubuntu-cpp

TODO list:

[ ] Fix usage of CMAKE_CXX_FLAGS instead of hardcoding
[ ] Fix transient dependencies to not require to define all Folly dependencies via INTERFACE_LINK_LIBRARIES for transitive link dependencies
[ ] Add CI to test both using the system installed dependency and downloading dependency via CMAKE
[ ] Test on other OS not only docker

@kgpai @assignUser See initial PR for what we have been discussing. The approach on this PR uses ExternalProject_Add for the third party dependencies. Currently this PR downloads and builds folly as part of the build and all tests pass on Docker. There are still several TO DO items but I wanted to share the approach.


[FAB-11334] Adds a viper Cmd to unjoin a peer from a channel

This change adds a Viper cobra.Command to unjoin the peer from a specified channel.
Signed-off-by: Josh Kneubuhl<EMAIL_ADDRESS>Type of change

New feature

Description
This PR introduces a node unjoin cobra.Cmd to the peer binary.  When enjoining a channel, the peer must be shut down, and the command will scrub all channel artifacts from the kvledger and transient storage.   If a crash occurs during the removal of the ledger, the residual artifacts will be scrubbed at the next launch of the peer.
Additional details
PR #2769
PR #2754
PR #2732
Related issues
FAB-16035
FAB-4481
FAB-17787
FAB-17801

Nice addition of the command overall... looks like you even figured out how to generate the command doc correctly!

Thanks gentlemen for the keen eyes and co-pilot reviews.  For future PRs I'll leave in a draft status until running / crafting the integration tests and running some basic validation on mini / nano -fab.
I think switching the deletion ordering will unwind the crash-recovery correctly.  I was wondering this AM if we should step back and add both of the PENDING_DELETION markers, or possibly a single deletion marker up at the layer of the CLI.  At least swapping the order will prevent the data from getting "bricked" as in the current form.  I'll try to set up a functional test for this scenario, as well as the normal delete path.
Another question is related to @yacovm 's comment regarding the remaining peers in the network not "getting the message" that the channel has been unjoined.  What's the correct venue for documenting the subsequent log / operations chatter generated when a peer channel suddenly vanishes from the network?

@manish-sethi and @denyeart the latest push will address the transient storage path and the ordering of kvledger / transient removal.  I tested this update with the nano-fab network and it looks OK - at least it does not panic, can join/unjoin/join/unjoin, and will fail to run unless the peer has been shut down.  I'd still like to add some functional / integration tests in here to emulate the scenarios above.

What's the correct venue for documenting the subsequent log / operations chatter generated when a peer channel suddenly vanishes from the network?

Maybe here you can add a guide how to remove a channel from a peer (the semantic of "removing a peer from a channel is simply wrong, because the channel has no awareness of peers but the other way around) and in that guide you can mention it, after you have reproduced my hypothesis in your environment.

@denyeart I have some progress on the integration test (the gingko suites are great!)   I will set up a separate PR for the test case if I can get It("to behave")

No concerns raised, I'll go ahead and merge and I've created #2803 for the integration test.


Implement sort-by flag in more antctl resources for more fields

PR https://github.com/vmware-tanzu/antrea/pull/1530 introduced the sort-by flag to the NetworkPolicy resource for antctl get command. Currently the only supported value for this flag is effectivePriority, which is computed based on the Tier priority and policy priority of each NetworkPolicy.
As pointed out in https://github.com/vmware-tanzu/antrea/pull/1530#discussion_r534534714, since sorting is implemented on the client side through the transform defined for each resource, we can support sort-by for an arbitrary field of the resource, or in other resources that antctl can query (e.g. appliedToGroups and addressGroups).

Will take this

Thansk @saramach, I assigned this to you!

@saramach No update from you so I'm removing you as an Assignee in case someone else wants to work on this

As the issue states implementing sort-by flag in more resources and more feilds ,will take this issue to implement sort-by flag in generic form like kubectl sort-by flag


[WIP][Compute] vm/vmss/availability-set update: add --ppg to allowing updating ProximityPlacementGroup

Issue #11420
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

--ppg is missing help.
az vm availability-set update -h

Command
    az vm availability-set update : Update an Azure Availability Set.

Arguments
    --ppg

add to S165.


Python: add MultiAddress

Python counterpart of https://github.com/iotaledger/iota-sdk/pull/1573

Closed by https://github.com/iotaledger/iota-sdk/pull/1658


Go Live 🚀

The MedBook App is a SPA built with React, the user is able to:
✅  Sign Up ✍
✅  Add doctor 👨⚕
✅  Book appointments 📆
✅  See all its appointments 🗓
✅  Delete a doctor, even if it has appointments👨⚕ ❌
We are using MedBook API to store all information related to our app. 🌐
Of course, our APP is responsive so, feel free to use it on any device! 📱 💻  🖥
Do you prefer the dark side ❓
Awesome you can join us using our dark theme 🌑
Try it out ⬇  ⬇
Live Demo
Enjoy!

Hi @Amrhub, @AlexRS90, @codepantha, @micheaol,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project that does not have a PR description, which is very important for who is reviewing it. For example, do you have a back-end PR for me to review or is it only the front-end?
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Hi @Amrhub, @codepantha, @AlexRS90, @micheaol,
In my opinion, your project is ready for the presentation!  There is nothing else to say other than... it's time to merge it :shipit:
Good luck! 🎉
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


Configuring the online postman to test the Heroku server.

Enable the default environment feature to resolve this problem.


Blog post for Server Side Apply to GA

This adds the blog post for Server Side Apply moving to GA in 1.22

👀

Hi. If this is ready for review, please retitle accordingly. The release blog team can assign a publication date.

This blog is currently scheduled for publication on August 6th.

@Jefftree since this is in review, can you remove WIP from the PR title? Thanks!

I'll get Prow to help
/retitle Blog post for Server Side Apply to GA

Todos:
Adjust publish date
A couple of comments need to be addressed

To help reviewers, @Jefftree, would you be willing to update the PR description so that it is current?

/wg api-expression

Thanks, LGTM for me!

@Jefftree one thing you might want to do is bump your repository's main branch to something more current (it's currently stale by 4763 commits).
Anyway, I tested a merge locally and it still looks fine.
/lgtm

@Jefftree one thing you might want to do is bump your repository's main branch to something more current (it's currently stale by 4763 commits).
Anyway, I tested a merge locally and it still looks fine.
/lgtm

Rebased on the latest main branch. Thanks

This looks really good!
/lgtm

/approve
/hold
Can unhold once Kubernetes v1.22 release is finished.

/hold cancel


Doesn't compile on fusetools 0.28

-compile:
[javac] Compiling 109 source files to ..../app/src/main/bin/classes
[javac] warning: [options] source value 1.5 is obsolete and will be removed in a future release
[javac] warning: [options] target value 1.5 is obsolete and will be removed in a future release
[javac] warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
[javac] .../app/src/main/java/com/foreign/Bolav/ForeignHelpers/JSList.java:32: error: incompatible types: Object cannot be converted to UnoObject
[javac]         					com.foreign.Bolav.ForeignHelpers.JSDict.FromJava277(ddict, obj);
[javac]         					                                                    ^
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some messages have been simplified; recompile with -Xdiags:verbose to get full output
[javac] 1 error
[javac] 3 warnings

Could compile it with a simple patch:
--- bolav/fuse-foreignhelpers/ListDict.uno.orig	2016-10-28 10:27:44.000000000 -0400
+++ bolav/fuse-foreignhelpers/ListDict.uno	2016-10-28 10:27:57.000000000 -0400
@@ -44,7 +44,7 @@
 			java.util.List l = (java.util.List)ary;
 			for (Object obj : l) {
 				if (obj instanceof java.util.HashMap) {
-					Object ddict = @{JSList:Of(_this).NewDictRow():Call()};
+					UnoObject ddict = @{JSList:Of(_this).NewDictRow():Call()};
 					@{JSDict:Of(ddict).FromJava(Java.Object):Call(obj)};
 				}
 				else {

Don't know if it works yet...

Did it work? If so will you submit a PR?

Yes it worked.
PR submitted.
Thanks.


Windows Authentication username defaults to terminal's prompt name for Mac

Windows Authentication on Mac expects the username to be equal to the specified name on the Terminal prompt. Windows Authentication on Mac works when both the Terminal and SQL Server use the same username, but this should not be expected.
Steps to repro:

On Mac, clear cached Kerberos ticket by calling kdestroy
Ensure terminal on Mac uses a prompt name that's unequal to the needed username for Windows Authentication
Try to connect to SQL Server instance using Windows Authentication on Mac environment
Connection error should appear, click "Run kinit"
kinit attempts to create Kerberos ticket with incorrect username

Workaround:

In ADS's terminal, specify the correct username by calling kinit [YOUR USERNAME]@[YOUR DOMAIN].com
Enter password
Reconnect to SQL Server instance with Windows Authentication—should now work

At a minimum, if authentication initially fails, ADS should specify the user call kinit followed by their user account for Windows Authentication, rather than attempt to make assumptions for the user.

As a follow-up, I created a feature request: #7079. This suggests enabling the username and password inputs in the New Connection form.

Closing as a duplicate of #112.  Which was the resolution for related issue #7079.  Thanks!


Causes crashes

My only bug reports so far have exclusively been this:
java.lang.NullPointerException
in com.ourcodeworld.plugins.filebrowser.Filebrowser.onActivityResult
I assume it's caused by Android 9 incompatibilities. Will there be an update soon?

Already fixed in https://github.com/muhammed-noufal/cordova-ourcodeworld-filebrowser.
Please follow the fixes title in Readme.MD


Add type defs for common types

It's quite verbose having to type the full type signature for common vector and matrix types when type inference cannot be used, e.g. writing structs or non generic functions. For this reason it would be good to have aliases for commonly used types (like VectorN, MatrixN etc). GLM is a good example of doing this, it's also one of the recommendations of this post on writing good vector math libraries for graphics http://www.reedbeta.com/blog/2013/12/28/on-vector-math-libraries/.
For example, I have the following struct and function:
pub struct ParticleData {
    position: Vec<cgmath::Vector3<f32>>,
    velocity: Vec<cgmath::Vector3<f32>>,
}

It would be a lot less verbose as (to use GLM format):
pub struct ParticleData {
    position: Vec<cgmath::Vec3>,
    velocity: Vec<cgmath::Vec3>,
}

The GLM typedefs for vec are listed here http://glm.g-truc.net/0.9.7/api/a00132.html and for matrices are here http://glm.g-truc.net/0.9.7/api/a00120_source.html#l00344. I'm not necessarily recommending adding all of those, GLM is mimicking all the types available in GLSL.
In my experience, game math uses float 99% of the time, so it would be good to provide type defs for the f32 types at least, VecN and MatN (for square matrices) seem like common choices.

Hmm, yeah. Might be useful. Also, nice article!

Yeah, that article was a good find, glad you liked it.

Perhaps the scalar type parameters could default to f32. That is,
struct Vector3<S = f32> { ... }

let foo: Vec<Vector3> = vec![];

Yeah, that could work.


Still does not work

I get a warning message that "roaming sync cannot be completed" when I remove the network cable, even when I have disabled all options!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4459a0c8-0451-bbdf-3d2f-f62f46dc2240
Version Independent ID: 7ebbbee6-1bd2-de5a-aabf-978d12099f3f
Content: Windows 10 roaming settings reference
Content Source: articles/active-directory/active-directory-windows-enterprise-state-roaming-windows-settings-reference.md
Service: active-directory
GitHub Login: @tanning
Microsoft Alias: markvi

@hydrogen2oxygen Thanks for your feedback! We will investigate and update as appropriate.

@hydrogen2oxygen Please refer to the Troubleshooting Enterprise State Roaming settings in Azure Active Directory document. In case you still face issue, please open a new MSDN forum or Stack Overflow post and community may help with recommendations based on their experience.

@MohitGargMSFT unfortunatelly the link you provided does not mention a problem similar to mine.

@hydrogen2oxygen As already mentioned, please please note that MSDN forum or Stack Overflow could be better place to get help on your scenario. As these forum community has many members and could provide their expert guidance on your scenario based on their experience.

@hydrogen2oxygen We will now proceed to close this thread. As already mentioned above, please post the forum link here that will help me monitor that thread.


Razor SDK view doesn't honour _ViewImports file provider

My application has the following file provider defined:
public class ViewImportsFileProvider : IFileProvider {
    public IDirectoryContents GetDirectoryContents(string subpath) {
        return null;
    }

    public IFileInfo GetFileInfo(string subpath) {
        if (subpath == "/_ViewImports" + RazorViewEngine.ViewExtension)
            return new ContentFileInfo("_ViewImports" + RazorViewEngine.ViewExtension,
                "@addTagHelper *, Microsoft.AspNetCore.Mvc.TagHelpers");

        return null;
    }

    public IChangeToken Watch(string filter) {
        return null;
    }
}

public class ContentFileInfo : IFileInfo {
    private readonly byte[] _content;

    public ContentFileInfo(string name, string content) {
        Name = name;
        _content = Encoding.UTF8.GetBytes(content);
    }

    public bool Exists => true;

    public long Length => _content.Length;

    public string PhysicalPath => null;

    public string Name { get; }

    public DateTimeOffset LastModified => DateTimeOffset.MinValue;

    public bool IsDirectory => false;

    public Stream CreateReadStream() {
        return new MemoryStream(_content);
    }
}

Now say I have a view with the following content:
Contact

The tag helper works fine if the view is within my application but doesn't if it is within a class library (using the Razor SDK).

Thanks for contacting us, @nfplee.
@pranavkm, can you please look into this? Thanks!

Build time compilation does not load \ run your app's code. Files need to be present on disk for them to be affect Razor code generation and compilation.

This technique works fine if the views are within the web application. It even works when the application is published and the views are pre-compiled.

Right - _ViewImports.cshtml affects code generation of other Razor files - _ViewStart.cshtml is simply executed. In all other cases you listed, runtime compilation is performed so things work as expected.

Oh right thanks, for now I've added a file on disk but this does mean that I have multiple ones across each of my libraries/modules which isn't idea.

This might be an option depending on how your libraries are set up, but you could try using linked files:
<ItemGroup>
   <RazorGenerate Include="..\SomeCommonDir\_ViewImports.cshtml" Link="_ViewImports.cshtml" />
</ItemGroup>

Thanks, I have a sample project in an issue you have helped me on before:
https://github.com/aspnet/Razor/issues/2425
After your suggestion, the MyLibrary project now has the following target defined:
<Target Name="UpdateTargetPath" BeforeTargets="AssignRazorGenerateTargetPaths">
  <ItemGroup>
    <RazorGenerate Include="@(RazorGenerate)" Link="$(TargetName)\%(RazorGenerate.RelativeDir)%(RazorGenerate.FileName)%(RazorGenerate.Extension)" />
  </ItemGroup>
</Target>

This saved me from having my views within an Areas directory within my library. Say I placed the _ViewImports within a MyCommonLibrary project then what would I need to add the MyLibrary project file?
Here is the file structure in case it helps:
Application
├── Program.cs
└── Startup.cs
MyLibrary
├── Controllers
│   └── HomeController.cs
└── Views
└── Home
└── Index.cshtml
MyCommonLibrary
└── Views
└── _ViewImports.cshtml
Sorry to ask, but I only know the basics of MsBuild and have never really used linked files before. Also my attempts so far have been in vain.

I guess you could do something along the lines of:
<Target Name="UpdateTargetPath" BeforeTargets="AssignRazorGenerateTargetPaths">
  <ItemGroup>
    <RazorGenerate Include="@(RazorGenerate)" Link="$(TargetName)\%(RazorGenerate.RelativeDir)%(RazorGenerate.FileName)%(RazorGenerate.Extension)" />
  </ItemGroup>

   <ItemGroup>
    <RazorGenerate Include="..\MyCommonLibrary\Views\_ViewImports.cshtml" Link="_ViewImports.cshtml" />
  </ItemGroup>
</Target>

basically update the "area" paths to start with followed by dropping a "_ViewImports.cshtml" at the root of the application.

Thanks that worked perfectly.

After digging into this a little further I found if I add the following to my project which has a package reference to MyCommonLibrary:
<Target Name="UpdateTargetPath" BeforeTargets="AssignRazorGenerateTargetPaths">
  <ItemGroup>
    <RazorGenerate Include="@(RazorGenerate)" Link="$(TargetName)\%(RazorGenerate.RelativeDir)%(RazorGenerate.FileName)%(RazorGenerate.Extension)" />
  </ItemGroup>

   <ItemGroup>
    <RazorGenerate Include="$(NuGetPackageRoot)\MyCommonLibrary\1.0.0\contentFiles\any\$(TargetFramework)\_ViewImports.cshtml" Link="_ViewImports.cshtml" />
  </ItemGroup>
</Target>

Then it works fine. I hope this helps someone else.


Create new endpoints in Validator class #59

One of the endpoints is missing: /invalid_blocks It gives 404 code and I cannot find it in the documentation. And the endpoint: /upgrade_notice is /upgrade_request from the documentation.
The other endpoints are done including the tests:
/banks
/connection_requests
/config
/upgrade_request
/validators

My account number:
b0302a7a0c02df1a5d298122de7c22a0bdd2394de75d1ae724f51a85bd13128e

Paid


Allow custom model directory

Codecov Report
Attention: Patch coverage is 17.24138% with 48 lines in your changes missing coverage. Please review.

Project coverage is 78.74%. Comparing base (2dcd633) to head (f929bc9).

Files
Patch %
Lines

src/faunanet/repl.py
6.12%
46 Missing :warning:

src/faunanet/watcher.py
77.77%
1 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   82.50%   78.74%   -3.76%
==========================================
  Files          10       10
  Lines         983     1035      +52
  Branches      182      191       +9
==========================================
+ Hits          811      815       +4
- Misses        134      181      +47
- Partials       38       39       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Lock BC Wallet after 5 minutes of inactivity

As a user, I want the app to require my authentication after a period of non-use, so that my private information is secure, even if I choose not to or forget to close the app after I use it.
Acceptance Criteria
Given BC Wallet is open in the foreground
When the app has not been used or interacted with for longer than 5 minutes
Then the app will lock the user out of the wallet
And notification will appear that informs people that they were logged out
Given the user has been locked out of the app
And are presented with the logged out notification
When they select the "okay" button on the notification
Then they are prompted to authenticate (via biometrics on wallet PIN)
See the flow with wireframes
See the flow diagram

@knguyenBC is this ready to start development?

@wadeking98 It's ready to start development

@wadeking98 I changed the specs on what is considered an activity based on a discussion with the design team, the ON team and a review of our app. See the ticket description.


add new (mostly) tech-focused treat messages

an oddly-specific hyperactive interest in old, outdated software
an IBM PC/AT
a giant pile of dead hardware platforms
corporate in-fighting
a full development lifecycle reset
a Blåhaj-colored computer
a sentence that is false

appreciate it, thanks for the merge!


feat: call configure ca every time the certificateAuthority config changes

Issue #, if available:
Description of changes:
Ensure we are calling the use case to configure the certificate authority every time there is a change on the CDA configuration for the certificateAuthority.
Additional changes:

Made the UseCases injectable instead of a singleton due to the fact it make them easier to test by allowing us to mock provided values of use cases in case we want to do simple unit tests.

Why is this change necessary:
We need to make sure we are updating the CAs when any value under the certificateAuthority configuration changes
How was this change tested:
Wrote a unit test.

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.


Feedback ontology loading

@dariober I think I've fixed the issue where the ontology was always loaded in the test. The meta section of the pre-loaded indexeddb databases didn't match what was expected, so it always tried to re-load it. I added the missing meta.storeOptions.prefixes to the json files and fixed the import of those files so it transformed it from an object to a map. That made it match what Apollo was expecting, so now it doesn't try to re-load the ontologies every time.


fixes

I corrected the importation of modules and files. The import functions starts checking from the current working directory which the file importing is at. You are required to import the OS package or sys in order to deal with system paths.


[sol2] Handle dependencies using features

Is your feature request related to a problem? Please describe.
It is currently not possible to use sol2 with the package luajit as dependency as on the windows platform it always tries to use lua and if you have luajit in your vcpkg.json this is a conflict.
Proposed solution
{
  "name": "sol2",
  "version-string": "3.2.2",
  "port-version": 2,
  "description": "Sol v2.0 - a C++ <-> Lua API wrapper with advanced features and top notch performance - is here, and it's great",
  "homepage": "https://github.com/ThePhD/sol2",
  "default-features": [
    "lua"
  ],
  "features": {
    "lua": {
      "description": "Use lua",
      "dependencies": [
        "lua"
      ]
    },
    "luajit": {
      "description": "Use luajit",
      "dependencies": [
        "luajit"
      ]
    }
  }
}

I propose using features to determine which lua implementation the user wants to use. Also having the default Lua implementation as the default doesnt change the old behavior but allows the new behavior.
Describe alternatives you've considered
I tried looking for a possibility for overwriting the dependencies of a package I include in my vcpkg.json
Additional context
Add any other context or screenshots about the feature request here.

We should select the detected dependencies based on the feature name, rather than automatically detect them.

Thanks for posting this issue. Now lua and luajit don't conflict on windows, you can install sol2 when luajit has been installed vcpkg.


GEODE-7458: Adding option in gfsh command "start gateway sender" to control clearing of existing queues

In this PR clearing of queue is added as option at starting of gateway sender.
Also behavior of parallel and serial gateway senders are now aligned.
Due to that, queue is no longer cleared at stopping of gateway sender,
since we now have option whether we want it to be cleared or restored, at restarting of gateway sender.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[*] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[*] Is your initial contribution a single, squashed commit?

[*] Does gradlew build run cleanly?

[*] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Added tests for new functionality.

Most tests are added, except UT, since there are no existing for impacted classes.

Most tests are added, except UT, since there are no existing for impacted classes.

I think that even if there are no existing unit tests for a class, you can still create a new test class and write tests to verify the specific changes you've made.

@mivanac I'm going on vacation for two weeks starting tomorrow, so I won't be able to actively review any further changes to this PR. I'm dismissing my existing request for changes so that it doesn't block the PR from being merged while I'm away, but I still do feel that unit tests for the affected methods should be added.

Added UT

@jujoramos are added tests OK with you?

@mivanac I'm on vacations so I won't be able to work any further on this, I'll dismiss my review but please wait for at least one more review before merging the PR (@davebarnes97 approved the changes only from a docs standpoint).

Could someone help with UT. After last modification on PR (there was no update of UT), UT is reporting Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "Management Task", and eventually it timeouts. Thanks.

Locally on my own machine, everything is working fine.

@jhuynh1 are new changes OK with you.

Hi Mario,
Sorry for the delay, I'm going to take a more thorough look as this diff is quite large.  Please bear with me and I'll hopefully have it reviewed in a couple more days (early next week?)
@agingade, you were also reviewing this at one point.  Perhaps you'd like to re-review?

Hi Mario,
I ran the previous sha through an app I have and am running into a few hangs.  I'll try to debug and see if I can reproduce in a DUnit.... I'll also try to take your latest diff (maybe that will help?)

Ok. Thanks.

With these last changes, test is not failing.

Cool, awesome job.  I'm going to run against some end to end tests and see what else crops up.  Please bear with me.
Also, is there a brief explanation of what was causing the hang and what change was required?  Just for those of us who are curious.

Problem was, that as we are stoping and starting gateway sender, while we are dispatching events,
in some cases, stopping of gw sender can shutdown ackReaderThread, just after we dispatch batch, so we will never remove this events from queue.

Hi,
Are there any updates regarding this PR?

Hi, can we merge this PR, if there is no more comments?


Version 1.2.0: ada_url to 2.6.5, host_type support

This PR:

Upgrades to the latest version of ada_url
Adds the host_type to the URL class and to the parse_url function output
Adds support for the del operator, using the ada_clear_* functions

The Host Type is returned as an IntEnum, whose values can be compared to normal integers.

OK, now using version 2.6.5. This should be good to release.


add resolver function generator

Add resolver function generator, which generates code based on the output from the GraphQL schema generated by graphql-api-generator.

Related to 41-add-resolver-function-generator


Try to fix MacOS sound

This PR updates globkey and attempts to fix the terrible sound produced by MacOS when using PTT, see https://imgur.com/a/o9VdGPo

I also noticed that the shouldbreak logic that was here before was removed by someone. I know I didn't in my previous PR, but this have something to do with this issue

I also noticed that the shouldbreak logic that was here before was removed by someone. I know I didn't in my previous PR, but this have something to do with this issue

actually i was the one who removed the shouldBreak logic as i was the one who put it there but forgot to make it actually do the task of breaking the loop. instead i noticed worker.terminate() automatically breaks the loop for me so i didn't touch shouldBreak and forgot to remove it. basically shouldBreak was redundant.

okay


[Interact Outside]: Interact outside doesn't fire when clicking outside opens a new floating element

Describe the bug
Interact outside doesn't fire (doesn't close a floating element) when an outside interaction opens a new sibling floating element.
An example of this is opening one popover, and opening a second sibling popover. When opening a second popover, that should be counted as an outside interaction of the first popover and hence the first popover should close. However, currently, the first popover doesn't close as can be seen in the video below.
https://github.com/melt-ui/melt-ui/assets/53095479/cbd69a3b-bfdf-4379-82e4-52e4f0385664
Reproduction
See video above which uses an example straight from the docs.
Logs
No response
System Info
System:
    OS: Linux 5.0 undefined
    CPU: (6) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.3 - /usr/local/bin/pnpm
  npmPackages:
    @melt-ui/svelte: latest => 0.76.3
    @sveltejs/kit: ^2.0.0 => 2.5.5
    svelte: ^4.1.2 => 4.2.12

Severity
annoyance

https://github.com/melt-ui/melt-ui/pull/1080 closes this


False file upload error being reported

Program uploads are blocked for now but the error check reports this as an error.

Extended this check to the sample source and sample destination.


feat: add default public RPC endpoints for default configured networks

What I did
Adds RPC endpoints for default configured networks sourced from official Ethereum Foundation repository.
fixes: #1729
How I did it
Added a script to generate a source file that has constants for the RPC endpoints.
How to verify it
ape console --network ethereum:mainnet

Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

https://github.com/mikeshultz/ape/blob/027305b71bcb99b2cebb8b049e9e66e2ae0f3a8d/src/ape_geth/provider.py#L209-L210
@antazoey thoughts on adding more default ecosystem configurations here?  Script currently also includes base, polygon, polygon-zkevm, and gnosis.  Could expand/contract that if we want, too.

this makes forking in test work out-of-the-gate without having to configure a default provider or set a URI.
<3


Load balancing

The tgis backend only holds a single grpc channel, so it'll create a connection to a single tgis pod and route all requests there.
We can instead:

Create a new channel on every request (extra slow) or
Do service-side load balancing (I'm assuming not an option / harder to change that...) or
Do client-side load balancing with a connection pool

Thx for inputting this issue :-)
I agree, I think best approach is "client-side load balancing with a connection pool", therefore establishing a connection to each Pod in a models replica set, and bouncing req's  between them.
Please contact me when there's a build to test out, thx<EMAIL_ADDRESS>


Long Text issue

Hi ! I am unable to input long text...its getting trimmed as well there only maximum 4 lines I can set. I want long text in text sticker....How can I ? Thanks

It's not a issue, it's a business logic of library.
For change this behavior quickly, change the line 269 of TextSticker.java
setText(text.subSequence(0, endOffset) + mEllipsis);
to
setText(text.toString());

@pedrofsn i tried setText(text.toString());, but the text ended up rendered out of the boundary, like this.

Any idea how to fix this?

I think the previous way can fix this (it's just a hint/shot).
Other idea it's put a padding on border content, so the content won't touch the boundary.


Cannot enable theme

Describe the bug
Migrating from One Dark Pro Italic to One Dark Theme, the "set theme" isn't working.
To Reproduce
Steps to reproduce the behavior:

Install extension
Click Set Color Theme
Get toast "Cannot read property 'id' of undefined

Expected behavior
Take a guess :)
Screenshots

Desktop (please complete the following information):

OS: Mojave 10.14.6
VS Code Version [e.g. 1.39.2]

Additional context
Nope.

Thanks for reporting this issue.  I have not noticed this at all when installing the new theme, so I'm a bit puzzled by it.  Could you try disabling other extensions and then installing it?  Also, if you open developer tools, is there more information in the console about the error?
Thanks!

When I tried again just to reproduce the error for you, I could not. I guess a relaunch of VSCode solved the issue, whatever it was. Closing this, thanks for the rapid response! :)

Glad that the issue is fixed!


How can I use this on Jetson Nano ?

The grove base hat and grove.py lib seems doesn't support this sensor, so hoe can I use MLX90615 sensor on my Jetson Nano ?

Sorry, we will support it in the future


Add logos to the shield badges

Summary
SUMMARY_GOES_HERE

@atharwa-24 can you elaborate a bit more, do you want us to contribute here: https://github.com/badges/shields ?

Along with badge the logo too looks great!
Check PR #6239

Ah, ok, added comment:
https://github.com/Kong/kong/pull/6239#pullrequestreview-471844826

Closing this after closing #6239. Please reopen if necessary.


Unragdolling not responding to animations

Currently if I ragdoll, press a key to walk, and then unragdoll, the walking animation will not play until I restart the walk cycle.
https://github.com/LeoStormer/ragdoll-system/assets/65048459/0b772cbe-d2a5-4b09-9618-bf47ed52db45

Hello, I'm unable to reproduce this bug. Are you experiencing this on the latest version of the system, version 0.3.0? If so can you send a small example that reproduces this bug?

Here's a Roblox place file with the bug being produced. My sample code is in StarterPlayerScripts.
RagdollSystemBug.zip


add sanity check for camera info

Not ready for review.
I think the sanity of the CameraInfo should be checked, but the sanity checking code shouldn't belong to this ipm library. The tests in test_sanity_camera_info.py are also not great. The sanity check only checks for the K value too... Leaving this as a draft for now.
Resolves: #34

sanity checking code shouldn't belong to this ipm library

Where would you put this then?

I don't think sanity checking CameraInfo is specific to ipm.
I believe there should be a ROS2 sanity checking library that uses a plugin-type structure to allow sanity checking any custom ROS 2 message type.

Closing this PR, as I don't believe this code belongs in ipm.


internal: remove package-level init with fastlyABIInit()

We were ignoring the return value anyway and it complicates wizer integration.

Just need to figure out where to put this for people who want to call it.  Maybe at the top-level sdk.go file ?

What purpose does the call serve?  What're the implications of not calling it?

The call allows an app to say "I'm using this version of the ABI" and verify that the wasm runtime supports it.   However, it is purely advisory and the return value ("Sounds Good" / "I'm sorry I don't support that version") was ignored anyway.

Can we just move this into handle.go:Serve(), before we create the ClientRequest?

There are code entries that could be called before Serve(), for example loading a configuration or something from a kvstore or equivalent.  So while it would be seen, it wouldn't necessarily be the first action the SDK would take with the host.

There are code entries that could be called before Serve(), for example loading a configuration or something from a kvstore or equivalent. So while it would be seen, it wouldn't necessarily be the first action the SDK would take with the host.

Ah, yes, you are right. I still think this should happen automatically (and not something the end user should care about) but I'm not sure how to achieve that outside init or adding the extra check in all the possible entrypoints.


publish somewhere

Please, publish somewhere. I also want to try tensorflow from Scala

I'll try to see if I can publish to Sonatype (or similar). In the meantime, you can use publishLocal on this and the TensorFlow bindings project.

ScalaPy is now published to Sonatype, and Maven Central as soon as it syncs!


Get the specs for articles controller to pass when running rspec

Just noticed that some of the boilerplate tests were left in.  Would love some help getting the tests to pass for the articles controller.  Thank you!

#17 Gets the routing spec to pass, but the controller spec is not integrated yet.


Poor printing quality with driverless printing

Printing from Ubuntu 22.04 (cups 2.4.1+patches) on a Brother MFC L6950DW. Printer is autodetected for driverless printing. Unfortunately the print quality is sub-par, almost sure, much worse than what the printer could do. Fonts look pixelated and thin lines in fonts are in multiple occasions not printed at all (very visible when printing the ballot character, where borders of the box often disappear).  Furthermore the printing is extremely small.
Don't know if this is actually the case, but it looks a lot as if everything was rasterized before printing and the rasterization happened at a wrong resolution (causing a lot of work on the printer for rescaling and detail loss).

What you get for
avahi-browse -rt _ipp._tcp
avahi-browse -rt _uscan._tcp

could be useful.

Hi @callegar ,
thank you for reporting the issue! Together with avahi-browse output it would be great if you attached a .txt file with output of ipptool command:
$ ipptool -tv <your_printer_uri> get-printer-attributes.test

and cupsd error_log when you print with debug logging enabled and you experience the issue. It happens often that printer doesn't support all quality options via driverless standards in comparison to the old driver. The other thing which could happen is assigning incorrect quality option in cupsd, problem in a filter etc.
Debug log and IPP response from the printer should help us with that.

Unfortunately the command
ipptool -tv implicitclass://Brother_MFC_L6900DW_series get-printer-attributes.test

errors out, proposing the help for ipptool.

From avahi-browse the relevant fragments appear to be:
= enx0050b61af5c1 IPv4 Brother MFC-L6900DW series                    Internet Printer     local
   hostname = [BRNB4220052FD43.local]
   address = [<IP_ADDRESS>]
   port = [631]
   txt = ["mopria-certified=1.2" "print_wfds=T" "UUID=e3248000-80ce-11db-8000-b4220052fd43" "PaperMax=legal-A4" "kind=document,envelope,label,postcard" "URF=W8,CP1,IS19-1,MT1-3-4-5-8,OB10,PQ4,RS300-600-1200,V1.4,DM1" "rfo=ipp/faxout" "TBCP=F" "Transparent=T" "Binary=T" "PaperCustom=T" "Scan=T" "Fax=T" "Duplex=T" "Copies=T" "Color=F" "usb_CMD=PJL,PCL,PCLXL,URF" "usb_MDL=MFC-L6900DW series" "usb_MFG=Brother" "priority=25" "adminurl=http://BRNB4220052FD43.local./net/net/airprint.html" "product=(Brother MFC-L6900DW series)" "ty=Brother MFC-L6900DW series" "note=" "rp=ipp/print" "pdl=application/octet-stream,image/urf,image/pwg-raster,application/pdf" "qtotal=1" "txtvers=1"]

and
= enx0050b61af5c1 IPv4 Brother MFC-L6900DW series                    _uscan._tcp          local
   hostname = [BRNB4220052FD43.local]
   address = [<IP_ADDRESS>]
   port = [80]
   txt = ["duplex=T" "is=adf,platen" "cs=binary,grayscale,color" "UUID=e3248000-80ce-11db-8000-b4220052fd43" "pdl=application/pdf,image/jpeg" "note=" "ty=Brother MFC-L6900DW series" "rs=eSCL" "representation=http://BRNB4220052FD43.local./icons/device-icons-128.png" "adminurl=http://BRNB4220052FD43.local./" "vers=2.5" "txtvers=1"]

hope I am not missing anything...

@callegar

ipptool -tv implicitclass://Brother_MFC_L6900DW_series get-printer-attributes.test

Ok, so the URI tells us the printer is created and managed by cups-browsed from cups-filters project. The PPD is generated by driverless generator as well.
It would be great if you turned on CUPS debugging, printed the file where you experience quality issues and attached the CUPS error_log file here with .txt suffix - avahi-browse output shows the device advertises 3 types of quality for AirPrint - 300dpi, 600dpi and 1200dpi, it would be great to see which one is used during printing.
Ad ipptool command - I'm sorry I didn't expect cups-browsed, ipptool works with clean IPP uris. So please try this one (to keep it simple I use the IP address instead of mDNS hostname)
$ ipptool -tv ipp://<IP_ADDRESS>:631/ipp/print get-printer-attributes.test

Please attach the PPD you have for the printer in /etc/cups/ppd as well.
Once we gather all info, I'll pass this to cups-filters, because the printer is managed by the daemon from it.
Thank you in advance!

Thank you @callegar; everything is there.

pdl=application/octet-stream,image/urf,image/pwg-raster,application/pdf

The Brother MFC L6950DW accepts PDF. On Ubuntu 22.04 production of a PDF to send to the printer is the priority route. Raster format is not involved.
A PDF can be sent directly to the printer with
netcat <IP_ADDRESS> 9100 < ANY_PDF

Check that 9100 is an open port with  nmap <IP_ADDRESS>
How does that go on as regards quality?

There has been no response since the end of June, Brian's question hasn't been answered and the requested files haven't been provided, so I'm going to close the issue. In case the problem persists, please let us know and provide the requested information.
Thank you in advance!


added command line parameter "-modules"

This issue should be addressed, more or less, on master. JSDoc should now automatically discover the node_modules directory in your template and load the submodules from there.
One very important caveat: To make this work, the require() calls must be at the top level of the module, or in some other chunk of code that is executed when the module is loaded. For example:
// this works
var foo = require('foo');

// this works
var bar = (function() {
    return require('bar');
})();

function myFunc() {
    // this doesn't work
    var baz = require('baz');
}

It would be very difficult to fix this limitation without making major changes to Rhino, and I don't think anyone is interested in doing that work. However, I think the current implementation should cover the vast majority of use cases.
@Gubaer: Please give this a try. If your template still can't find the submodules, please add a comment, and I'll investigate.


object is not a function at new ol.structs.RBush in ol-debug build

Error, 3/13/2015, 5:30:17 PM, TypeError: object is not a function at new ol.structs.RBush (/app/map/bower_components/openlayers3/build/ol-debug.js?v=1426292962889:63920)
This is where that problem is:
// export as AMD/CommonJS module or global variable
if (typeof define === 'function' && define.amd) define(function() { return rbush; });
else if (typeof module !== 'undefined') module.exports = rbush;
else if (typeof self !== 'undefined') self.rbush = rbush;
else window.rbush = rbush;
})();
ol.ext.rbush = module.exports;
})();
The issue is caused because I'm using requirejs which creates window.define.amd. Hence, module.exports is still an empty object as it is not set to rbush.
I'm not sure why this works in release mode....can't figure out what the minified variables mean.
One solution is to set "module.exports = rbush", but I'm not sure how open layers handles these scenarios when using 3rd party libraries. However, I can at least modify the debug file and use it to debug.
Email thread: https://groups.google.com/forum/#!topic/ol3-dev/y0ri7LPrD78

+1

See #3274
Please try with v3.4.0

Still having this issue with both 3.4.0 and 3.5.0.


The dreaded "ETIMEDOUT" error

MBS humming along nicely for a few months until this error began showing a few weeks ago. It only happens during MQTT --> ST, never during ST --> MQTT. The error shows in the MBS log but not in ST IDE Live Logging. Something in the environment obviously changed but not by intention.
2020-02-26 00:55:27 AM error: undefined
2020-02-26 00:55:27 AM error: Error from SmartThings Hub: Error: connect ETIMEDOUT 192.168.0.xx:39500
2020-02-26 00:55:27 AM error: {
"errno": "ETIMEDOUT",
"code": "ETIMEDOUT",
"syscall": "connect",
"address": "192.168.0.xx",
"port": 39500
}
I've verified all the ip addresses and ports. I removed the devices.yml. Rebooted ST and server. I believe I'm running the latest mbs-server.js, config.yml and mbs-smartapp-full. To the best of my knowledge this is only happening with MBS.
Any suggestions on where else to search? Much appreciated!

Yeah this has been know to happen in many 3rd party integration.
If u reboot the hub it should go away.
Hubs been acting weird for me for the past week in general - going offline / online - sure Samsung is up to something
Sent from my iPhone

On Feb 27, 2020, at 10:31 PM, raisingskell<EMAIL_ADDRESS>wrote:

MBS humming along nicely for a few months until this error began showing a few weeks ago. It only happens during MQTT --> ST, never during ST --> MQTT. The error shows in the MBS log but not in ST IDE Live Logging. Something in the environment obviously changed but not by intention.
2020-02-26 00:55:27 AM error: undefined
2020-02-26 00:55:27 AM error: Error from SmartThings Hub: Error: connect ETIMEDOUT 192.168.0.xx:39500
2020-02-26 00:55:27 AM error: {
"errno": "ETIMEDOUT",
"code": "ETIMEDOUT",
"syscall": "connect",
"address": "192.168.0.xx",
"port": 39500
}
I've verified all the ip addresses and ports. I removed the devices.yml. Rebooted ST and server. I believe I'm running the latest mbs-server.js, config.yml and mbs-smartapp-full. To the best of my knowledge this is only happening with MBS.
Any suggestions on where else to search? Much appreciated!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi.
I was planning to migrate to your fork from St. John because of this issue, but discovered this report.
I have this issue when my custom Python script is setting a person present in ST. It is random in nature and it seems to be consistent across reboots. I changed my script to loop until ST reports the device present and during my tests today it works on either the 2nd or 3rd retry.
If I monitor my ST logs I am also unable to see any indication of a failure, but I conclude that this is because we get a timeout on the connect call to ST. And since ST don’t know anything about a timed out connection nothing is logged.
Could perhaps the connect function be verified or robustified?
UT

I guess when it errors out one could technically program some retries.
your should be seeing errors on the server side in the log and error.log files - can you check if those are the errors you are actually gettting.
Like most people have reported most of the time a reboot reboot of ST fixes this error.
my development environment is completely shot so I cannot test but in the test directory i have uploaded a mbs-server-retries.js.  download that and rename it to mbs-server.js and see if that helps - i have added 5 retries.  like i said have not tested it so could faile even if i had a typo  - i checked so hopefully no syntax or typos

Thanks for reporting back, but as of right now I have not migrated to your fork yet, so I am unable to test.
How much reconfiguration needs to be done should I install yours?


feat: Add FpsCounter component

Inspired by https://github.com/joshka/tui-big-text/blob/7f9e84968a9ba4db824a7ece7d186e58bb35999d/examples/stopwatch.rs

I think if I was looking at this again, I'd probably just render at 60fps regardless of what updates happen (and aim not to try to render after each update, so you might have 2 things come in and never see the screen updated for the first thing before the second thing also renders). That's ok though as not many people can really tell the difference between two events that occur 16.7ms apart. This approach also allows your events to be blocked by a rendering cycle which is probably useful for low latency things - the stopwatch example demonstrates that idea to some extent.

I think if I was looking at this again, I'd probably just render at 60fps regardless of what updates happen (and aim not to try to render after each update, so you might have 2 things come in and never see the screen updated for the first thing before the second thing also renders).

If I understand what you are recommending, I believe that's what this version of the ratatui-async-template does. For example, if you press and hold any key you'll see the app tick rate go up but the render tick rate remain the same.
The main loop is like this:
    loop {
      if let Some(e) = tui.next().await {
        // When we receive an event, immediately map it to an action and send it on the action channel
        match e {
          tui::Event::Quit => action_tx.send(Action::Quit)?,
          tui::Event::Tick => action_tx.send(Action::Tick)?,
          tui::Event::Render => action_tx.send(Action::Render)?,
          tui::Event::Resize(x, y) => action_tx.send(Action::Resize(x, y))?,
          e => {
            for component in self.components.iter_mut() {
              if let Some(action) = component.handle_events(Some(e.clone())) {
                action_tx.send(action)?;
              }
            }
          },
        }
      }

      // Resolve all actions on the action channel
      // `while let` will break if the action channel is empty
      // This will only break after resolving all action channel messages
      // caveat: if updating the app state based on an action takes too long, render will be blocked.
      while let Ok(action) = action_rx.try_recv() {
        match action {
          Action::Quit => self.should_quit = true,
          Action::Render => {
            tui.draw(|f| {
              for component in self.components.iter_mut() {
                component.draw(f, f.size());
              }
            })?;
          },
          _ => {},
        }
        for component in self.components.iter_mut() {
          if let Some(action) = component.update(action.clone())? {
            action_tx.send(action)?
          };
        }
      }
      if self.should_quit {
        tui.stop()?;
        break;
      }
    }

The previous version wouldn't block render even if the app update took too long, but I think that that's unnecessarily complex.


Is it possible to overlap another image?

I would like to overlap an image done with lines drawn with Painter. I used Stack to overlap it. It works however I noted that the image cannot be moved or zoomed in the zone where the image is overlapped. Is there any workaround to overlap images but still maintaining the zoom and move feature?

Duplicate of #555 maybe...


feat(components): expansion panel web component

Description
Developed expansion panel component using Lit framework - implemented in storybook.
What's included?

Expansion panel component
Expansion panel documentation page

Test Steps

[ ] npm run storybook

General Tests for Every PR

[ ] npm run start still works.
[ ] npm run lint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build still works.

Screenshots or link to StackBlitz/Plunker

@carolineguzylak looks like there is a few lint and build issues. You should be able to run locally using nx affected build and nx affected lint

@carolineguzylak looks like the pipeline did not pass you should be able run npm run lint -- --fix

@carolineguzylak looks like the pipeline did not pass you should be able run npm run lint -- --fix

:tada: This PR is included in version 7.1.0 :tada:
The release is available on:

v7.1.0
GitHub release

Your semantic-release bot :package::rocket:


Jenny is trying to complete the homework

Hi!
I'm just wondering that I'm doing well.
Jenny

Hey @YENCHUNYU—congrats on submitting a PR at the end of the git course! I think you've done an excellent job of following along and completing the challenge with a PR! I hope you enjoyed this intro to using git, and that you were able to follow along easily.
If you weren't already using git for your code, hopefully this has inspired you to do so. I hope that you enjoy the "Mastering Git" video course as well—you'll soon be able to get git to bend to your will :)
You can now wear this #GitWarrior badge with pride—and Tweet your historic victory!

sam


Change room_id field in Room Events from Option to RoomId

For some reason this field is not enforced, but every spec version of the protocol specifies that it is required.

related to #44?

@emilazy kind of. But that issue is about events that are declared with event!, so should be non-room events based on that but contain a room_id field anyways. This issue is about room_event!s.

When looking through the history of ruma-events, I found that early versions had Event as a generic type like ToDevice and Stripped now are. I think returning to that would easily solve the problem here by just having another of these generic types where the room ID is optional, with the main RoomEvent having a mandatory room_id field.

Maybe that's just hair-splitting, but I see doing that as a potential source for mismatches between the content type and the event type (Event, RoomEvent or StateEvent). Having the traits implemented from the library doesn't have that kind of ambiguity problem. For the same reason I don't like that change regarding Stripped, but I ignore why it was deemed necessary.

@aledomu We could still have the same traits for the content types, using them to limit the content types each of the generic event structs accepts as for the content field.

This is done in the api22 branch.


Potential Infinite Loop and Redundant Check in City Query Method

Issue:
In the getAllCitiesOrderedByPopulation method (and similar methods), there is a potential inefficiency due to incorrect loop structure. The current implementation of the while (rs.next()) loop processes ResultSet rows, but unnecessary checks or looping structure issues can arise, particularly if the initial rs.next() is placed outside the loop, causing missed or duplicated entries.
Root Cause:
The bug occurs because the first rs.next() is sometimes placed before the loop body, causing an off-by-one error, which either skips the first row of the ResultSet or leads to redundant checks and empty results.
Solution:
The correct approach is to directly use the while (rs.next()) loop without the extra if (rs.next()) check before it.


min rule

If the filed is allowed to be number then it accepts comma in value (i.e. 1200 and 1,200 both are valid). Now if "min" rule is provided with number then currently even if i'm entering 1,200 error(Please enter a value greater than or equal to 0.) is throwing. So if the current element has number and min both rules then we need to replace comma with 0 length string.

The Travis check has failed (https://travis-ci.org/jzaefferer/jquery-validation/builds/114806911)

Depending on local the , can be a thousands-seperator, therefore this cannot be merged as is. Looks like something which should be added with Globalize support.

I'm going to close this as it's not something this plugin has to support. As @staabm said in his comment, the , depends on the local and how numbers are formated, not how they are entered. What I can suggest people to do is to use the normalizer to remove the , before hitting the validation:
$("form").validate({
  rules: {
    field: {
      required: true,
      min: 1500,
      normalizer: function( value ) {
        return value.replace(/,/g, "");
      }
    }
  }
});


What about Laravel 7.3 support?

required ^7.0
can't install on 7.3

No official update, I fork a branch, you can try
composer require benhuang1024/dusk-dashboard:dev-master --dev

@benhuang1024 , your fork is can be installed, but it seems broken

@benhuang1024 , your fork is can be installed, but it seems broken

Sorry, I forgot to update the remote package using use Yosymfony \ ResourceWatcher \ Crc32ContentHash;
Trying now

I would also like to install with Laravel 7.3


Pin PostgreSQL version in *-postgres templates

*-postgres templates (ex. ruby-rails-postgres) use postgres:latest image which isn't the best default by 2 reasons:

Using latest tag will cause problems in a case we rebuild container after release of new major version of PostgreSQL, as data generated by different major versions are not compatible and require using dumps, cluster upgrades, etc., simply saying container won't start unless we pin to numbered tag that matches previous major version.
Images that have tags without suffix, like latest or 16, are Debian-based which means it's almost twice bigger than Alpine-based (425MB vs 243MB), in most cases using Alpine-flavored image should suffice.

I suggest switching to numbered tags with -alpine suffix as and it's smaller and would make it more future-safe. Not sure if it's possible, can PostgreSQL version be entered by user in the same way as imageVariant during initialization?

Thank you for creating the issue and explaining the drawbacks of defaulting to the latest tag for postgres image.
The suggestion to allow users to override the tag (similar to imageVarient) makes sense. But we still need to have a default. I am afraid if a tag like 16-alpine can be the new default instead of latest, since that will hard pin the image and would never receive newer major versions unless we manually modify the template.  Any thoughts around that?

I think it would be good default, at least a better one. In perspective, pinned version in template would need to be updated every year around September/October when new major version is being released to match.
Pinned version also simplifies upgrading to latest minor version by rebuild (not sure if pull is set to always during them, docker pull postgres:16-alpine can be run previously to be safe).
Similarly if developer would need new version to utilize newly added features or simply upgrade it with persisting data still stays manual but more controllable.


federation runtime vue 3 remotes with getPublicPath generates double calls (one with wrong public path)

Describe the bug
Hello,
I use federation runtime to dynamically import vue 3 remotes with getPublicPath.
some css, vendors assets are called twice:

once with the proper public path retrieved through the getPublicPath function
once with the consumer url which returns in my case the root html.

you can see screenshots in the repro project README.
It doesn't always generate an issue as one of the two calls succeeds.
I don't have this behavior if I replace getPublicPath by a static publicPath.
Thank you
Reproduction
https://github.com/WeetA34/mf-double-calls-repro
Used Package Manager
yarn
System Info
System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M1 Max
    Memory: 128.44 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.15.1 - /usr/local/bin/node
    Yarn: 1.22.22 - /opt/homebrew/bin/yarn ---> yarn 4.3.1 with nodeLinker node-modules in the project
    npm: 9.8.1 - /opt/homebrew/bin/npm
    pnpm: 9.4.0 - /opt/homebrew/bin/pnpm
    bun: 1.0.21 - ~/.bun/bin/bun
  Browsers:
    Chrome: 126.0.6478.185
    Safari: 17.5

Validations

[X] Read the docs.
[X] Read the common issues list.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Module federation issue and not a framework-specific issue.
[X] The provided reproduction is a minimal reproducible example of the bug.

Hello,
fyi, it's still the same with 0.3.5

Hello,
fyi, it's still the same with 0.5.1

Hello,
fyi, it's still the same with 0.6.3 :)

+1, seeing the same issue as well (with React, although that doesn't really matter here)

Hello,
fyi, it's still the same with 0.6.8 :)

hmm seems like a legit issue. Will check the source code.
You can try setting public path to auto?

Hello Zack,
It seems to be ok without getPublicPath and config.output.publicPath set to 'auto' instead.
Thank you

Hello again,
I moved to @module-federation/rsbuild-plugin.
publicPath='auto' by default
It works fine

Perfect

Bump

The wrong css asset is loaded by producer's miniCss runtime . It will use publicPath + assetUrl  as final url .
And the producer not set specific publicPath , so it will call twice .


Added "std" feature, made validate_enum work on no_std

Codecov Report

Merging #2 (a65b2c5) into main (d34097d) will decrease coverage by 2.33%.
The diff coverage is 77.55%.

@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
- Coverage   89.18%   86.85%   -2.34%
==========================================
  Files           6        6
  Lines         148      175      +27
==========================================
+ Hits          132      152      +20
- Misses         16       23       +7

Impacted Files
Coverage Δ

src/lib.rs
100.00% <ø> (ø)

tests/validate_nested.rs
100.00% <ø> (ø)

tests/validate_struct.rs
100.00% <ø> (ø)

src/implementations.rs
64.15% <55.00%> (-0.72%)
:arrow_down:

src/helpers.rs
90.47% <90.00%> (+2.47%)
:arrow_up:

tests/validate_enum.rs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d34097d...a65b2c5. Read the comment docs.


Optimization: use EventHandle in Components for scene and layers

Depends on: https://github.com/playcanvas/engine/pull/7137
This PR uses EventHandle.off instead of EventHandler.off to improve performance when disabling renderable components. As a scene and layers callaback arrays can get large in big projects.
In large scenes, disabling renderable components became ~4-8 times faster based on our tests. In one specific scene, disabling half of a scene used to take ~3550ms now it takes ~600ms (~5.9 times improvement).
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

So this is for merging into main_v. I guess that's fine - we just cherry-pick afterwards to main. But we normally seem to go the other way....

So this is for merging into main_v. I guess that's fine - we just cherry-pick afterwards to main. But we normally seem to go the other way....

Editor uses engine v1, and most (except one) of our projects are v1, so we work with it in the first place.

cherry picked to main as well


"RESOURCES" and  "ACCOUNTS & TENANTS" views keep "Waiting for Azure sign-in..." status after clicking the "Cancel" button during the second account sign-in process

OS: Mac (M1 Pro)/Linux
Build Version: v0.10.0
Regression: Not a regression
Repro Steps:

Set "Microsoft-authentication: Implementation" to "msal" in "Settings" page.

Make sure logged into 1 Microsoft account.
F1 -> Select "Azure: Sign in" -> Click the "Allow" button -> Select "Sign in to another account" to open the browser.
Return to VS Code -> Click the "Cancel" button -> Select "Yes" to cancel sign-in.

Check whether "RESOURCES" and "ACCOUNTS & TENANTS" views show well.

Expect:
"RESOURCES" and  "ACCOUNTS & TENANTS" views show well.
Actual:
"RESOURCES" and  "ACCOUNTS & TENANTS" views keep "Waiting for Azure sign-in..." status.

More Info:

This issue does not reproduce if setting "Microsoft-authentication: Implementation" to "classic" in "Settings" page.
Reload Window can resolve this issue.

When you press cancel does an error pop up after? Normally an error such as this should pop up:

@motm32 Hi Megan, an "Canceled" error pops up after pressing "cancel" button, but only in the case of this issue, "RESOURCES" and "ACCOUNTS & TENANTS" views keep "Waiting for Azure sign-in..." status, the GIF is as follows:
https://microsoft-my.sharepoint.com/:v:/p/v-meilei/EaFw7Y_foF9OoCYYhfHIiwsBENkk2OHSgihIm6J7HUMzig?e=lWQJvS