Create "Previous releases" section in docs

The LTS docs are restructured so that Quick Start, Concepts, and Installation are at the same level as operate/admin, manage, define, bridge, etc.
When we publish the LTS docs, we need to do one more little reorg to create an "Earlier releases" section on the landing page, under which we will have the last 0.x.x release documentation as well as the last 0.x.x version  of Quick Start, Explore Keptn, Concepts, and Installation.  This preserves, more or less, the structure and information of the 0.x.x docs and gives us a clean landing page for LTS, where the history is available but is clearly marked as history.  This also leaves the 0.19.x docs undisturbed between now and when LTS is released.
Note that this means that, until LTS is released, we will have separate copies of Concepts and Installation and need to be sure that modifications made to these sections are applied to the proper version.
The final structure of the docs landing page will be:

Release 1.0.x -- LTS

Quick Start (killercoda version)
Concepts
Installation
Administration (was operate)
Manage projects
Define projects
Keptn Bridge
Integrate tools
Reference
Troubleshooting

Roadmap
Earlier releases

Explore Keptn (0.x version)
Quick Start
Concepts
Installation
Release 0.19.x

Same structure as now

Release 0.18.x

Same structure as now

Release 0.17.x

Same structure as now

Release 0.16.x (or maybe this is removed?)

Same structure as now

Integrations
News

I would suggest to keep the trees for the individual versions but hide them from the menu. This way, links to the existing docs are preserved and we don't break user's bookmarks or the access to old docs for users that are still running an old version of Keptn.
However, I would change the name of the section from Docs to something similar to Docs for previous versions

@thisthat Simon knows how to set this up so the landing page looks like what I want but the source file paths are not modified so that the SEO is not affected.  We'll take care of that.

i created a pr, it is not 100% the desired outcome, as it is only hiding the version pages, but it allows to at least access those

so i reworked my Pull request a little and here is my suggest for the structure - I do have SEO in mind, with the canonical URLs etc - and this should also help us for future releases
- Quick Start (killercoda version)
- Concepts
- Installation
- Administration (was operate)
- Manage projects
- Define projects
- Keptn Bridge
- Integrate tools
- Reference
- Troubleshooting
- Roadmap
- Previous releases
    - Explore Keptn (0.x version)
    - Quick Start
    - Concepts
    - Installation
    - List of Link to all hidden releases
- Release 0.19.x [hidden] - Same structure as now
- Release 0.18.x [hidden] - Same structure as now
- Release 0.17.x [hidden] - Same structure as now
- Release 0.16.x [hidden] - Same structure as now
- Integrations
- News

Why I propose this change:

we sofar do not break a lot of links, the canonical links can be replaced and just pointing to a page without a version in there (so we do not need to adapt it in the future
we do not break old links, we hide the versions, but the bookmarks etc like @thisthat said, will still work and point to the right direction
we have a flat hierarchy and we are save for future versions, where we might only move the things which have changed to the previous version folder, or we copy paste it into a new folder on the root level.

in my pr for the previous releases, I added the previous release page already, what is missing is

[ ] adapt canonical URL generation
[ ] place for 1.0.x documentation
[ ] moving of the old files under the previous releases, with keeping their links in tact.

I know that this is not the ideal solution, but it allows us to move fast.
Additionally we can still think of an own folder for version 1.0.x - that's something optional, we only need to ensure redirects from the old installation etc, to the one within that folder, and we need to be careful with SEO for future releases

A couple comments about Simon's proposed revision of the structure:

The 0.19.x, 0.18.x, 0.17.x, and perhaps 0.16.x sections should be under "Previous releases"
Have we agreed that we want the 1.0 docs at the top level rather than under the 1.0.x header?  I like this but, when we reviewed the proposed structure, people wanted the 1.0.x header there so we could add the KLT docs at the same level as the 1.0.x docs.
I believe that "List of links to all hidden releases" should not be here.  Our policy has been to only include links to the last three releases and I see no reason why we now want to revive links to the older releases.
I'm also thinking that "Integrations", "News", and "Roadmap" should appear before "Previous Releases".
Should we remove the "Roadmap" from the page, given the current plans for Keptn 1.x?

Assuming that the 1.0 docs are at the top level and not under a "1.0" header, here is my proposed structure:

Quick Start (killercoda version) (1.0 version)
Concepts (1.0 version)
Installation (1.0 version)
Administration (was operate)
Manage projects
Define projects
Keptn Bridge
Integrate tools
Reference
Troubleshooting
Integrations
News
Roadmap [??]
Previous releases

Explore Keptn (0.x version)
Quick Start  [Thinking that maybe we should delete this]
Concepts (0.x version)
Installation (0.x version)
Release 0.19.x - Same structure as now
Release 0.18.x - Same structure as now
Release 0.17.x - Same structure as now
Release 0.16.x  - Same structure as now [??]

Thanks, @thisthat !  I fear that the only way is to move source files.  Perhaps with a bunch of redirects, we can make it not too bad?  I'm going to create a PR that does this so we can look at it and then decide between this approach and the one @aepfli proposes.  Moving the files won't be a huge task -- the redirects will so I won't do those until we decide on the implementation.

close as not planned


Remove FallbackFactory validation

Fixes #41

Codecov Report

Merging #58 into master will increase coverage by 0.25%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master      #58      +/-   ##
============================================
+ Coverage     75.87%   76.12%   +0.25%
- Complexity      283      285       +2
============================================
  Files            36       36
  Lines          1206     1181      -25
  Branches        186      184       -2
============================================
- Hits            915      899      -16
+ Misses          212      204       -8
+ Partials         79       78       -1

Impacted Files
Coverage Δ
Complexity Δ

...ringframework/cloud/openfeign/HystrixTargeter.java
100% <ø> (ø)
12 <0> (-1)
:arrow_down:

...loud/openfeign/ribbon/LoadBalancerFeignClient.java
69.04% <83.33%> (+1.48%)
11 <4> (+3)
:arrow_up:

...ork/cloud/openfeign/support/SpringMvcContract.java
87.32% <0%> (+4.29%)
44% <0%> (ø)
:arrow_down:


fix(932200): detect windows style filepaths

Issue: U8Z0MSCP
Description: The affected rule only works on *nix style filepaths.
Fix: Detect windows style filepaths by considering \ as valid filepath delimiter like /.

CRS Bug Bounty PR assessment

Rules affected (list rules): FIXME
Paranoia Level addressed (1, 2, 3, 4, full or explain): FIXME
FTW passes (yes or no) : FIXME
Rule(s) picked for solution (correct or not-correct or explain) : FIXME
Risk for false positives (irrelevant, adequate, substantial or explain) : FIXME
Regular expression quality (inspirational, decent base, needs work, adequate or explain) : FIXME
Documentation (needs work, adequate or explain) : FIXME
Tests (none or some or adequate) : FIXME

Verdict (Unusable, inspirational, usable, almost perfect or perfect) : FIXME

This is not meant to be final. As a CRS dev, feel free to comment below and edit this form directly. As committer or observer, feel free to comment below with feedback and we will think about updating the assessment accordingly.

@s0md3v Your new test doesn't seem to be working at the moment.

We have a rule for backslash notation in the contribution guidelines: \\-> \x5c
Please if possible could you put it after the /.
We need also a test for the backslash, some more tests could really help.

Can you also be sure that your PR doesn't change permissions on files? I see a change from 644 to 755 (probably because of WSL?).

Oops. Seems that the test is failing. Is the test wrong or does the rule have a problem? Could you have a look at that @s0md3v ?

I'm struggling to make the test match. Will enter debug mode.

I believe the proposal here changes the existing regular expression in ways that fundamentally change its meaning. I think this needs a closer inspection.

This issue may be harder than it looks (or maybe not). I am confused because as far as I know, we should have detected this technique also in earlier releases. So I think we may have to fix an existin rule as well, and that rule is really complex. I will close this for now, and use it as a reference.


Update overview sections to use them as filter

Description

Fixes #3771
Submissions:

Projects:

Invoices:

Loading state:

Test Steps

[ ] Check the All Submissions, All Projects, and Invoices pages.
[ ] Check if overview sections(in ss above) are clear and can filter the data by selecting any one of them.
[ ] Overview sections should be easily accessible and able to filter the data correctly.

@frjo It is ready for testing.

Added a note regarding the size of the text in the overview filter. Other than that it works perfectly in my testing, nice work!

And we can use the strong tag or set weight here for the status-block__title:
https://github.com/HyphaApp/hypha/blob/37b2f494a1ec871f425719ff8f13978ee6aea57a/hypha/static_src/sass/components/_status-block.scss#L57-L61


Allow creation of Ingresses in default namespace

As it stands, one must include a namespace in the ingress yaml file. We should detect the case where no namespace is provided, and use the default namespace.
The tool currently gives this error if no namespace is specified:
Error in creating load balancer: error in creating ingress in cluster my-cluster-name: an empty namespace may not be set during creation

Fixed by #34


Cannot infer types if one argument (Struct field) is defined

What version of Go are you using (go version)?
go 1.12.6

$ go version

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
"darwin"
go env Output
$ go env

What did you do?
Option1:
if I have two variables one defined and other undefined then the := does not identify the defined variable and results in compile error "non-name fs.err on left side of :=" The line of code is as follows
d, fs.err := fs.client.Collection(fs.CollectionName).Doc(fs.ID).Get(fs.ctx)
In order to make it work d needs to be defined
var d *firestore.DocumentSnapshot
Option 2:
while the following fragment works and go infer the type for d
var err error
d, err := fs.client.Collection(fs.CollectionName).Doc(fs.ID).Get(fs.ctx)
In the line above fs is a struct and has been defined. In this case I am receiving it as an argument

What did you expect to see?
I  expect go to infer types for non defined parameters, as it does in the second scenario above
What did you see instead?
Option 1 does not work while Option 2 works

Yeah you can't do this. := will always create new variables. For example, in
	var a int = 1
	{
		a, b := 99, 2
		fmt.Println(a, b)
	}

The a outside the block and the a inside the block are two different variables. Even if you used := for the second assignment, it won't overwrite the outer a, it'll create a new one.
The workaround is writing var d ... and then using = ....
Closing here (see #377).

Yeah you can't do this. := will always create new variables. For example, in
	var a int = 1
	{
		a, b := 99, 2
		fmt.Println(a, b)
	}
	fmt.Println(a)

The a outside the block and the a inside the block are two different variables. Even if you used := for the second assignment, it won't overwrite the outer a, it'll create a new one.
The workaround is writing var d ... and then using = ....
Closing here (see #377).

I do not think it is scope is the reason. Probably i did not explain better

Okay, can you explain better?

Because what you wrote here:

if I have two variables one defined and other undefined then the := does not identify the defined variable

looks like the example I wrote above. Ignore the scoping stuff, as I said := will ignore the already defined variable, that's the issue here.

Thank you for the report @saritseal, @ALTree thanks for the response.
For clarity and others looking at this issue in the future, here is a full example https://play.golang.org/p/PSUFXGSVTWQ or inlined below
package main

type Foo struct {
	err  error
}

func f1() (string, error) {
	return "here", nil
}

func main() {
	n1, err := f1()
	if err != nil {
		panic("Expected an error")
	}
	_ = n1

	f := new(Foo)
	n2, f.err  := f1()
	_ = n2
}

which won't compile as per
./prog.go:19:7: non-name f.err on left side of :=

Yes indeed, this is forbidden by the language's specification under the section "Short variable declarations" https://golang.org/ref/spec#Short_variable_declarations; a struct field being used is not an IDENTIFIER -- which must be composed only of free standing variables from letters and unicode digits. The language's grammar expects only identifiers for these short variable declarations to be redefined using := provided it was previously declared.
I don't think that we can change this for Go1 at least, but perhaps @griesemer might want to take a look.

There's been various discussions in the past regarding relaxing the rules for := assignments (see #377 as the tracking issue for several proposals).
But as has been said before by @odeke-em, this is working as intended.

more related: https://github.com/golang/go/issues/30318


UX: Settings Minimap viewport size change

VSCode Version: 1.10.1
OS Version: MacOS 10.12.1

Minuscule minimap mishap. ~Viewport size expands upon reaching end of settings file. I'm unsure what other aspects of the situation I'm missing or if it's only applicable for the settings file.~

~~~- groups~~~
~~~- collapse state of setting sections~~~

Steps to
1. Open settings
2. Collapse / Uncollapse sections
3. Look at minimap viewport
2. ~~~Scroll to bottom of default settings~~~
3. ~~~Scroll up enough so that the last section is not 100% still in view~~~
4. ~~~Hover over minimap to display the viewport indicator, then repeat steps 3 & 4 at your leisure.~~~

The way the minimap handles the settings collapsed sections differently then that of 'code' collapsed sections and the inconsistency made it seem like it was a *bug* but its probably *working as design*.

I don't know how the settings are structured in the backend but I presume that it is an aggregate view and the minimap viewport size is generated per source. As the source from 'code' is singular (example, user settings file), the size is singular. Since the settings are an aggregate and can take up a varying amount of space (due to collapsed state).

I think that for a consistent user experience, the minimap viewport size should stay the same.
So the collapsed state shouldn't have any baring on that size.

Relevant labels: UX, settings, editor-minimap

We are no longer showing the minimap in the left-hand-side (Default configuration)


[BUG] package-name-with-dash converts to underscores

setuptools version
setuptools=70.1.0
Python version
Python 3.11.5
OS
macOS
Additional environment information
No response
Description
I tried running python setup.py sdist on the following:
import setuptools; setuptools.setup(name="my-wonderful-tool", version="0.1.0")

and the distribution generated is named my_wonderful_tool. Previous versions maintained the dashes. For instance.
68.0.0 maintains the file name.
69.0.0 does not.
same applies if one attempts to run it with
python -m build as advised in the docs here.
Expected behavior
Expected behaviour is to maintain the name and not normalise it to underscores.
How to Reproduce
use setuptools >) 69.0.0
import setuptools; setuptools.setup(name="my-wonderful-tool", version="0.1.0")

python -m build

Output
(base) ➜  sandbox python -m build

* Creating venv isolated environment...
* Installing packages in isolated environment... (setuptools >= 40.8.0)
* Getting build dependencies for sdist...
running egg_info
writing my_wonderful_tool.egg-info/PKG-INFO
writing dependency_links to my_wonderful_tool.egg-info/dependency_links.txt
writing top-level names to my_wonderful_tool.egg-info/top_level.txt
reading manifest file 'my_wonderful_tool.egg-info/SOURCES.txt'
writing manifest file 'my_wonderful_tool.egg-info/SOURCES.txt'
* Building sdist...
running sdist
running egg_info
writing my_wonderful_tool.egg-info/PKG-INFO
writing dependency_links to my_wonderful_tool.egg-info/dependency_links.txt
writing top-level names to my_wonderful_tool.egg-info/top_level.txt
reading manifest file 'my_wonderful_tool.egg-info/SOURCES.txt'
writing manifest file 'my_wonderful_tool.egg-info/SOURCES.txt'
warning: sdist: standard file not found: should have one of README, README.rst, README.txt, README.md

running check
creating my_wonderful_tool-0.1.0
creating my_wonderful_tool-0.1.0/my_wonderful_tool.egg-info
copying files to my_wonderful_tool-0.1.0...
copying setup.py -> my_wonderful_tool-0.1.0
copying my_wonderful_tool.egg-info/PKG-INFO -> my_wonderful_tool-0.1.0/my_wonderful_tool.egg-info
copying my_wonderful_tool.egg-info/SOURCES.txt -> my_wonderful_tool-0.1.0/my_wonderful_tool.egg-info
copying my_wonderful_tool.egg-info/dependency_links.txt -> my_wonderful_tool-0.1.0/my_wonderful_tool.egg-info
copying my_wonderful_tool.egg-info/top_level.txt -> my_wonderful_tool-0.1.0/my_wonderful_tool.egg-info
copying my_wonderful_tool.egg-info/SOURCES.txt -> my_wonderful_tool-0.1.0/my_wonderful_tool.egg-info
Writing my_wonderful_tool-0.1.0/setup.cfg
Creating tar archive
removing 'my_wonderful_tool-0.1.0' (and everything under it)
* Building wheel from sdist
* Creating venv isolated environment...
* Installing packages in isolated environment... (setuptools >= 40.8.0)
* Getting build dependencies for wheel...
running egg_info
writing my_wonderful_tool.egg-info/PKG-INFO
writing dependency_links to my_wonderful_tool.egg-info/dependency_links.txt
writing top-level names to my_wonderful_tool.egg-info/top_level.txt
reading manifest file 'my_wonderful_tool.egg-info/SOURCES.txt'
writing manifest file 'my_wonderful_tool.egg-info/SOURCES.txt'
* Building wheel...
running bdist_wheel
running build
installing to build/bdist.macosx-11.1-arm64/wheel
running install
running install_egg_info
running egg_info
writing my_wonderful_tool.egg-info/PKG-INFO
writing dependency_links to my_wonderful_tool.egg-info/dependency_links.txt
writing top-level names to my_wonderful_tool.egg-info/top_level.txt
reading manifest file 'my_wonderful_tool.egg-info/SOURCES.txt'
writing manifest file 'my_wonderful_tool.egg-info/SOURCES.txt'
Copying my_wonderful_tool.egg-info to build/bdist.macosx-11.1-arm64/wheel/my_wonderful_tool-0.1.0-py3.11.egg-info
running install_scripts
creating build/bdist.macosx-11.1-arm64/wheel/my_wonderful_tool-0.1.0.dist-info/WHEEL
creating '/Users/alexandervialabellander/Documents/ahlsell/github/sandbox/dist/.tmp-ubjjm9bt/my_wonderful_tool-0.1.0-py3-none-any.whl' and adding 'build/bdist.macosx-11.1-arm64/wheel' to it
adding 'my_wonderful_tool-0.1.0.dist-info/METADATA'
adding 'my_wonderful_tool-0.1.0.dist-info/WHEEL'
adding 'my_wonderful_tool-0.1.0.dist-info/top_level.txt'
adding 'my_wonderful_tool-0.1.0.dist-info/RECORD'
removing build/bdist.macosx-11.1-arm64/wheel
Successfully built my_wonderful_tool-0.1.0.tar.gz and my_wonderful_tool-0.1.0-py3-none-any.whl
(base) ➜  sandbox

Hi @AlexVialaBellander,setuptools recently implemented the standardisation for distribution arquive naming.
That does not change the metadata of your package,  but it does change the name of the sdist or wheel.
It is very unlikely that this behaviour will revert since it comes from discussions and standardisation efforts in PyPA.
Please note that this is necessary to interoperate well with other tools in the ecosystem.


Update Project-System-Support.md

Removed excess word

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/visual-studio-extensibility/Project-System-Support.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks for the correction.


Reach out on DIF about verifiable conditions for visibility

Duplicate of https://github.com/Tonomy-Foundation/Antelope-SSI-Toolkit/issues/7


mods installed mutiple times

so i just setup v1.2 and all is working except for load the game up and check screenshot here: https://s12.postimg.org/in3qe19wt/Untitled.png

Have you at some point updated your mods through ModMyFactory? This is the only reason I can think of where multiple versions of a mod could end up in the mods folder.
For now I recommend to just clean up yourself. You can safely delete the duplicate mods in Windows Explorer, but delete the mod-list.json file as well so ModMyFactory can rebuild it.

yer i did update the mods thru ModMyFactory

Maby they were synced from Steam? I am not sure which contents Steam will save in the cloud.
However, both folders should actually have the same contents because one of them should just be a junction to the other one.

they ain't because i have steam sync off and when i did it only does the saves

Yes, It can't be Steam.
However, I still do not understand how the contents of %AppData%\Factorio\mods and the ModMyFactory mods folder can be different for you. %AppData%\Factorio\mods should be a directory junction to the ModMyFactory mods folder (marked by a small link arrow in Windows Explorer).

There is a small link arrow on it but the 2 folders differed.  When I opened %AppData%\Factorio\mods it showed that in the address bar if it's just linked when opened shouldn't it open to where the money factory is

No it's correct that way.

Yer I dunno it was only showing in %AppData%\Factorio\mods and not also the modmyfactory mods folder

Please confirm that the folders are actually correctly linked (by creating a test file for example). You can view the destination of the junction by using the dir command in the console.

I'm not at home atm, but does it matter what folder I do it from

No problem, I am neither. ;)
And yes it does matter. Do it from %AppData%\Factorio. You should then see an entry that looks something like ' mods [destination]'.

i think i have fixed it... also anyway so that when i format i don't loose all the modpacks etc save them in the app folder instead of %appdata%\ModMyFactory

It would be nice if you could tell me what the problem was so I can close this. :)

for some reason it was detecting another mod folder i had somewhere else not in the app dir

Ah, ok. Glad to hear this isn't actually a bug in ModMyFactory.


enable Test_DependencyEnable test for go

Description
Test_DependencyEnable is passing for go, but not enabled. This PR enables it.
Motivation

Additional notes

Hi @lievan,
Is this PR still relevant ?

@katiehockman gentle ping 😃

/merge


Add Pulsar adapter to list of Queue Adapters

Q
A

New feature?
V

Github
Packagist

There're not enough test and it's unstable. Please add tests and show code coverage in the readme


[Bug]: Popper components throwing error on SSR

Environment
Developement/Production OS: Windows 10 19043.1110
Node version: 16.0.0
Package manager<EMAIL_ADDRESS>Radix Vue version: 1.0.0
Shadcn Vue version: 1.0.0
Vue version: 3.0.0
Nuxt version: 3.0.0
Nuxt mode: universal
Nuxt target: server
CSS framework<EMAIL_ADDRESS>Client OS: Windows 10 19043.1110
Browser: Chrome 90.0.4430.212

Link to minimal reproduction
https://www.shadcn-vue.com/docs/components/tooltip.html
Steps to reproduce

Describe the bug
when i  use tooltip into my nuxt project

get this error.
if i use redix-tooltip directly there is no error
Expected behavior
No response
Conext & Screenshots (if applicable)
No response

@BayBreezy could you point me to which triggers are causing similar issue? I updated a few.. and will look into the real problem today

@zernonia , I removed the client-only tag from all the Radix-vue components and I no longer get the warning/error.
Thanks for fixing this.
If anything comes up, I will be sure to let you know

Thanks for that @BayBreezy ! 😁

Hey @zernonia , I am getting the error with the Tooltip trigger component. If not wrapped in the client-only tag, I get all sorts of hydration warnings and it causes the child of the trigger to be duplicated.

hmmm.. @BayBreezy  Im not seeing that.. Could you provide some screenshot or minimal repro?

Sure @zernonia , here is the stackblitz: https://stackblitz.com/edit/nuxt-starter-ws3qeq?file=pages%2Findex.vue
I added 2 buttons that are triggers for tooltips. Check the console and you will see the issue with the one not wrapped in the client-only tag

@BayBreezy  you should as asChild props to trigger when you use another button.
eg: wrapping native button inside another button would render hydration error by default.
    <button>
        <button>Test</button>
    </button>

So, in your code, add asChild as such
       <UITooltipTrigger asChild>
              <UIButton variant="outline">
                <Icon class="h-5 w-5" name="solar:moon-fog-bold-duotone" /> Does
                not work on init load
              </UIButton>
            </UITooltipTrigger>

Ohhhhhhh. My fault

No problem. You are welcome! 😁

@zernonia , So adding asChild removed the hydration error, but I still get this error when I hover over it.
Uncaught (in promise) TypeError: n.getBoundingClientRect is not a function

@BayBreezy  the fixes is in 0.2.3

Oh.. The website is saying that 0.2.2 is the latest. Another oversight on my part. Thank you. It is working as intended now.


More Pythonic way to get the combinations

Thank you for you contribution to the repo and the community

On 22 Sep 2017, at 15:37, Fares Bessrour<EMAIL_ADDRESS>wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/geekcomputers/Python/pull/237 https://github.com/geekcomputers/Python/pull/237
Commit Summary
More pythonic way to get the combinations
File Changes
M 4 Digit Number Combinations.py https://github.com/geekcomputers/Python/pull/237/files#diff-0 (5)
Patch Links:
https://github.com/geekcomputers/Python/pull/237.patch https://github.com/geekcomputers/Python/pull/237.patch
https://github.com/geekcomputers/Python/pull/237.diff https://github.com/geekcomputers/Python/pull/237.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/geekcomputers/Python/pull/237, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHa0tI8chtFoi478sHKwqYl36wB3XQRks5sk8Y5gaJpZM4PgzH_.


Update task-configuration-file

What is changed, added, or deleted? (Required)

add full backup ftwrl usage details
Which DM version(s) do your changes apply to? (Required)

[x] master (the latest development version, including v3.0 changes)
[x] v2.0 (TiDB DM 2.0 versions)
[ ] v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

This PR is translated from:https://github.com/pingcap/docs-dm/pull/633
Other reference link(s):

Do your changes match any of the following descriptions?

[ ] Delete files
[ ] Change aliases
[ ] Need modification after applied to another branch
[ ] Might cause conflicts after applied to another branch

/merge


Android: keep resource as is

The option setting 'android.enableResourceOptimizations=false' is deprecated. The current default is 'true'. It will be removed in version 8.0 of the Android Gradle plugin.

^ Although the Android Gradle plugin will complain, but afaik Solar2D need to keep the widget resource as-is before found out more practical solution.

Refer: commit ad9bf162e2db195a5d8d4682336009b20db1d072 and commit f12fb5748dc1fe3f98610101be4647be4f3eabf8
Without the option, the default value of "true" is used, which results in the resource filenames being shrink and obfuscated, resulting in the widget resource not being found.
Set the option to false is temporary solution (this PR), may find another solution later (#610 as memo) :D

follow up on #611

Haha :) I am the one who put it there in the first place.


cur-setup-destination Readme a bit confusing

The cur-setup-destination README example usage shows both the setup-source and setup-destination modules being called.  But if you follow the deployment steps the setup-destination would have already been run in step 1 (cur-setup-destination)
https://github.com/aws-samples/aws-cudos-framework-deployment/blob/main/terraform-modules/cur-setup-destination/README.md

@sean-nixon please can you check this?

@mthwbarb The README you linked for the cur-setup-destination module only contains the cur-setup-destination in the example. Can you clarify where the confusion lies? If there's a way we can make the documentation better, I'd love to hear suggestions.
The README for each module is intended to be more or less standalone documentation for just that one module. The top-level README  contains instructions and examples for using all of the modules together to setup CUR and deploy CID dashboards.

Hi @sean-nixon -  I'm referring to the example usage in the CUR SOURCE readme https://github.com/aws-samples/aws-cudos-framework-deployment/blob/main/terraform-modules/cur-setup-source/README.md.  In this example, the both modules are being provisioned.  However, i the deployment steps from the workshop, you would typically deploy CUR DESTINATION first, then CUR SOURCE second, Especially if they are 2 different accounts and you are using 2 different sets of credentials to deploy.
I think the main README is ok but I would remove the CUR DESTINATION module reference from the example in CUR SOURCE readme.

@mthwbarb Sorry for the delay. I agree with your proposal. I've submitted a PR with some enhancements including removing the CUR destination module from the CUR source module example as well as adding a callout to refer to the main README for complete deployment instructions. Thanks for your feedback!


Hammer breaks HTML5 drag and drop by overriding drag events

Note: If you are having problems formatting your issue please refer to this article on using markdown in Github:
https://guides.github.com/features/mastering-markdown/
Note: for support questions, please use one of these channels:
https://forum.ionicframework.com/
http://ionicworldwide.herokuapp.com/
Short description of the problem:
Drag events 'dragstart', 'dragend' used to work properly by using the native HTML 5 DND api. Now they are being overriden by Ionic's Hammer gestures meaning we can no longer access such things as event.datatransfer. This happens on elements/components that aren't even Ionic ones
What behavior are you expecting?
HTML5 DND events should work as normal, as they used to.
Steps to reproduce:

Use a HostListerner for the 'dragstart' event on a component.
The event object returned is no longer an instance of DragEvent. Instead it is a custom object produced by Ionic's hammer configuration
You get errors due to the object not being an instance of DragEvent as illustrated below

browser_adapter.js:84 TypeError: dragEvent.stopPropagation is not a function
    at DraggableDirective.handleDragEnd (draggable.directive.ts:46)
    at DebugAppView._View_EditorComponent2._handle_dragend_0_1 (EditorComponent.ngfactory.js:740)
    at view.js:381
    at dom_renderer.js:255
    at hammer_gestures.js:68
    at ZoneDelegate.invoke (zone.js:332)
    at Object.onInvoke (ng_zone_impl.js:53)
    at ZoneDelegate.invoke (zone.js:331)
    at Zone.runGuarded (zone.js:239)
    at NgZoneImpl.runInnerGuarded (ng_zone_impl.js:86)
    at NgZone.runGuarded (ng_zone.js:240)
    at Array.callback (hammer_gestures.js:68)
    at Object.emit (hammer.js:2089)
    at emit (hammer.js:1219)
    at PanRecognizer.emit (hammer.js:1231)
    at PanRecognizer.emit (hammer.js:1484)
    at PanRecognizer.tryEmit (hammer.js:1242)
    at PanRecognizer.recognize (hammer.js:1283)
    at Object.recognize (hammer.js:1965)
    at MouseInput.inputHandler [as callback] (hammer.js:409)
    at MouseInput.MEhandler [as handler] (hammer.js:670)
    at Input.domHandler (hammer.js:332)
    at ZoneDelegate.invokeTask (zone.js:365)
    at Zone.runTask (zone.js:265)
    at ZoneTask.invoke (zone.js:433)

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
Which Ionic Version? 1.x or 2.x
2.0.0-beta.10
Plunker that shows an example of your issue
For Ionic 1 issues - http://plnkr.co/edit/Xo1QyAUx35ny1Xf9ODHx?p=preview
For Ionic 2 issues - http://plnkr.co/edit/me3Uk0GKWVRhZWU0usad?p=preview
Run ionic info from terminal/cmd prompt: (paste output below)

I may have found the problem. It seems that ion-item is now somehow being given an inline style of the following:
<ion-item style="touch-action: none; -webkit-user-select: none; -webkit-user-drag: none; -webkit-tap-highlight-color: rgba(0, 0, 0, 0);">```
This is disabling html5 drag and drop. I worked around it by using CSS to override that ```-webkit-user-drag: none;``` style to ```-webkit-user-drag: element !important;```

Hello, thanks for using Ionic! When you say that this used to work do you mean that in beta.10 it worked?

Yes. The Drag gesture is now overriding the dragstart and dragend events. It didn't used to do that before. These two events are integral to HTML5 drag and drop. Instead of overriding those, it should really be overriding the drag event (if necessary). angular/material2 uses Hammer and they don't do this. It's only ionic2

Thanks for the info! Would you be able to provide a repo or code snippet i can use to reproduce this issue? Thanks!

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!

Use the default ionic2 template and add an event handler for the dragstart event on any node. Inspect the event object instance that you receive in your event handler. It is not an instance of DragEvent. Instead it is a Hammer generated object that is missing the HTML5 drag and drop APIs (e.g event.datatransfer)


Can't npm install as of node 4

I'm not sure what title this should use or if this is even a node-gyp issue but I'm hoping someone can point me in the right direction.
I'm also not sure if node 4 actually is the cause of this, I tried reverting to the last iojs version that I was using and it didn't seem to fix it.
This is the package I was trying to run npm install on, it's my own project and I had this working before installing node 4. Here's the debug log.
/
><EMAIL_ADDRESS>install /Users/xo/Desktop/t/Network-Status-Page/node_modules/diskusage/node_modules/ref
> node-gyp rebuild

  CXX(target) Release/obj.target/binding/src/binding.o
In file included from ../src/binding.cc:8:
../node_modules/nan/nan.h:261:25: error: redefinition of '_NanEnsureLocal'
NAN_INLINE v8::Local<T> _NanEnsureLocal(v8::Local<T> val) {
                        ^
../node_modules/nan/nan.h:256:25: note: previous definition is here
NAN_INLINE v8::Local<T> _NanEnsureLocal(v8::Handle<T> val) {
                        ^
../node_modules/nan/nan.h:661:13: error: no member named 'smalloc' in namespace 'node'
    , node::smalloc::FreeCallback callback
      ~~~~~~^
../node_modules/nan/nan.h:672:12: error: no matching function for call to 'New'
    return node::Buffer::New(v8::Isolate::GetCurrent(), data, size);
           ^~~~~~~~~~~~~~~~~
/Users/xo/.node-gyp/4.0.0/include/node/node_buffer.h:31:40: note: candidate function not viable: no known conversion from 'uint32_t' (aka 'unsigned int') to
      'enum encoding' for 3rd argument
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
                                       ^
/Users/xo/.node-gyp/4.0.0/include/node/node_buffer.h:43:40: note: candidate function not viable: 2nd argument ('const char *') would lose const qualifier
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
                                       ^
/Users/xo/.node-gyp/4.0.0/include/node/node_buffer.h:28:40: note: candidate function not viable: requires 2 arguments, but 3 were provided
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate, size_t length);
                                       ^
/Users/xo/.node-gyp/4.0.0/include/node/node_buffer.h:36:40: note: candidate function not viable: requires 5 arguments, but 3 were provided
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
                                       ^
In file included from ../src/binding.cc:8:
../node_modules/nan/nan.h:676:12: error: no viable conversion from 'v8::MaybeLocal<v8::Object>' to 'v8::Local<v8::Object>'
    return node::Buffer::New(v8::Isolate::GetCurrent(), size);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:210:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from
      'v8::MaybeLocal<v8::Object>' to 'const v8::Local<v8::Object> &' for 1st argument
class Local {
      ^
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:210:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from
      'v8::MaybeLocal<v8::Object>' to 'v8::Local<v8::Object> &&' for 1st argument
class Local {
      ^
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:214:13: note: candidate template ignored: could not match 'Local' against 'MaybeLocal'
  V8_INLINE Local(Local<S> that)
            ^
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:326:13: note: candidate template ignored: could not match 'S *' against 'v8::MaybeLocal<v8::Object>'
  V8_INLINE Local(S* that)
            ^
In file included from ../src/binding.cc:8:
../node_modules/nan/nan.h:683:26: error: no member named 'Use' in namespace 'node::Buffer'
    return node::Buffer::Use(v8::Isolate::GetCurrent(), data, size);
           ~~~~~~~~~~~~~~^
../src/binding.cc:154:23: error: no matching function for call to 'NanNewBufferHandle'
  Local<Object> buf = NanNewBufferHandle(ptr, buf_size, unref_null_cb, user_data);
                      ^~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:658:36: note: candidate function not viable: no known conversion from 'void (char *, void *)' to 'int' for 3rd argument
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (
                                   ^
../node_modules/nan/nan.h:668:36: note: candidate function not viable: requires 2 arguments, but 4 were provided
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (
                                   ^
../node_modules/nan/nan.h:675:36: note: candidate function not viable: requires single argument 'size', but 4 arguments were provided
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (uint32_t size) {
                                   ^
../src/binding.cc:271:27: error: no matching function for call to 'NanNewBufferHandle'
  Local<Object> rtn_buf = NanNewBufferHandle(val, size, read_pointer_cb, user_data);
                          ^~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:658:36: note: candidate function not viable: no known conversion from 'void (char *, void *)' to 'int' for 3rd argument
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (
                                   ^
../node_modules/nan/nan.h:668:36: note: candidate function not viable: requires 2 arguments, but 4 were provided
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (
                                   ^
../node_modules/nan/nan.h:675:36: note: candidate function not viable: requires single argument 'size', but 4 arguments were provided
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (uint32_t size) {
                                   ^
../src/binding.cc:518:23: error: no matching function for call to 'NanNewBufferHandle'
  Local<Object> rtn = NanNewBufferHandle(ptr, size, read_pointer_cb, NULL);
                      ^~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:658:36: note: candidate function not viable: no known conversion from 'void (char *, void *)' to 'int' for 3rd argument
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (
                                   ^
../node_modules/nan/nan.h:668:36: note: candidate function not viable: requires 2 arguments, but 4 were provided
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (
                                   ^
../node_modules/nan/nan.h:675:36: note: candidate function not viable: requires single argument 'size', but 4 arguments were provided
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (uint32_t size) {
                                   ^
../src/binding.cc:565:23: error: no matching function for call to 'NanNewBufferHandle'
  Local<Object> rtn = NanNewBufferHandle(ptr, size, read_pointer_cb, NULL);
                      ^~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:658:36: note: candidate function not viable: no known conversion from 'void (char *, void *)' to 'int' for 3rd argument
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (
                                   ^
../node_modules/nan/nan.h:668:36: note: candidate function not viable: requires 2 arguments, but 4 were provided
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (
                                   ^
../node_modules/nan/nan.h:675:36: note: candidate function not viable: requires single argument 'size', but 4 arguments were provided
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (uint32_t size) {
                                   ^
In file included from ../src/binding.cc:6:
In file included from /Users/xo/.node-gyp/4.0.0/include/node/node.h:42:
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:221:5: error: assigning to 'v8::Primitive *volatile' from incompatible type 'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:414:12: note: in instantiation of function template specialization 'v8::Local<v8::Primitive>::Local<v8::Value>' requested here
    return NanEscapeScope(NanNew(v8::Undefined(v8::Isolate::GetCurrent())));
           ^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                             ^
In file included from ../src/binding.cc:6:
In file included from /Users/xo/.node-gyp/4.0.0/include/node/node.h:42:
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:221:5: error: assigning to 'v8::Boolean *volatile' from incompatible type 'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:424:12: note: in instantiation of function template specialization 'v8::Local<v8::Boolean>::Local<v8::Value>' requested here
    return NanEscapeScope(NanNew(v8::True(v8::Isolate::GetCurrent())));
           ^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                             ^
In file included from ../src/binding.cc:6:
In file included from /Users/xo/.node-gyp/4.0.0/include/node/node.h:42:
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:221:5: error: assigning to 'v8::Function *volatile' from incompatible type 'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:1514:12: note: in instantiation of function template specialization 'v8::Local<v8::Function>::Local<v8::Value>' requested here
    return NanEscapeScope(NanNew(handle)->Get(kCallbackIndex)
           ^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                             ^
In file included from ../src/binding.cc:6:
In file included from /Users/xo/.node-gyp/4.0.0/include/node/node.h:42:
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:221:5: error: assigning to 'v8::Object *volatile' from incompatible type 'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:1632:12: note: in instantiation of function template specialization 'v8::Local<v8::Object>::Local<v8::Value>' requested here
    return NanEscapeScope(handle->Get(NanNew(key)).As<v8::Object>());
           ^
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                             ^
13 errors generated.
make: *** [Release/obj.target/binding/src/binding.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/xo/.nvm/versions/node/v4.0.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 14.5.0
gyp ERR! command "/Users/xo/.nvm/versions/node/v4.0.0/bin/node" "/Users/xo/.nvm/versions/node/v4.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/xo/Desktop/t/Network-Status-Page/node_modules/diskusage/node_modules/ref
gyp ERR! node -v v4.0.0
gyp ERR! node-gyp -v v3.0.1
gyp ERR! not ok

><EMAIL_ADDRESS>install /Users/xo/Desktop/t/Network-Status-Page/node_modules/diskusage/node_modules/ffi
> node-gyp rebuild

  CC(target) Release/obj.target/ffi/deps/libffi/src/prep_cif.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/types.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/raw_api.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/java_raw_api.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/closures.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/x86/ffi.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/x86/ffi64.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/x86/darwin.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/x86/darwin64.o
  LIBTOOL-STATIC Release/libffi.a
  CXX(target) Release/obj.target/ffi_bindings/src/ffi.o
In file included from ../src/ffi.cc:3:
In file included from ../src/ffi.h:18:
../node_modules/nan/nan.h:324:27: error: redefinition of 'NanEnsureHandleOrPersistent'
  NAN_INLINE v8::Local<T> NanEnsureHandleOrPersistent(const v8::Local<T> &val) {
                          ^
../node_modules/nan/nan.h:319:17: note: previous definition is here
  v8::Handle<T> NanEnsureHandleOrPersistent(const v8::Handle<T> &val) {
                ^
../node_modules/nan/nan.h:344:27: error: redefinition of 'NanEnsureLocal'
  NAN_INLINE v8::Local<T> NanEnsureLocal(const v8::Handle<T> &val) {
                          ^
../node_modules/nan/nan.h:334:27: note: previous definition is here
  NAN_INLINE v8::Local<T> NanEnsureLocal(const v8::Local<T> &val) {
                          ^
../node_modules/nan/nan.h:757:13: error: no member named 'smalloc' in namespace 'node'
    , node::smalloc::FreeCallback callback
      ~~~~~~^
../node_modules/nan/nan.h:768:12: error: no matching function for call to 'New'
    return node::Buffer::New(v8::Isolate::GetCurrent(), data, size);
           ^~~~~~~~~~~~~~~~~
/Users/xo/.node-gyp/4.0.0/include/node/node_buffer.h:31:40: note: candidate function not viable: no known conversion from 'uint32_t' (aka 'unsigned int') to
      'enum encoding' for 3rd argument
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
                                       ^
/Users/xo/.node-gyp/4.0.0/include/node/node_buffer.h:43:40: note: candidate function not viable: 2nd argument ('const char *') would lose const qualifier
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
                                       ^
/Users/xo/.node-gyp/4.0.0/include/node/node_buffer.h:28:40: note: candidate function not viable: requires 2 arguments, but 3 were provided
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate, size_t length);
                                       ^
/Users/xo/.node-gyp/4.0.0/include/node/node_buffer.h:36:40: note: candidate function not viable: requires 5 arguments, but 3 were provided
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
                                       ^
In file included from ../src/ffi.cc:3:
In file included from ../src/ffi.h:18:
../node_modules/nan/nan.h:772:12: error: no viable conversion from 'v8::MaybeLocal<v8::Object>' to 'v8::Local<v8::Object>'
    return node::Buffer::New(v8::Isolate::GetCurrent(), size);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:210:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from
      'v8::MaybeLocal<v8::Object>' to 'const v8::Local<v8::Object> &' for 1st argument
class Local {
      ^
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:210:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from
      'v8::MaybeLocal<v8::Object>' to 'v8::Local<v8::Object> &&' for 1st argument
class Local {
      ^
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:214:13: note: candidate template ignored: could not match 'Local' against 'MaybeLocal'
  V8_INLINE Local(Local<S> that)
            ^
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:326:13: note: candidate template ignored: could not match 'S *' against 'v8::MaybeLocal<v8::Object>'
  V8_INLINE Local(S* that)
            ^
In file included from ../src/ffi.cc:3:
In file included from ../src/ffi.h:18:
../node_modules/nan/nan.h:779:26: error: no member named 'Use' in namespace 'node::Buffer'
    return node::Buffer::Use(v8::Isolate::GetCurrent(), data, size);
           ~~~~~~~~~~~~~~^
../src/ffi.cc:25:5: error: no matching function for call to 'NanNewBufferHandle'
    NanNewBufferHandle(ptr, length, wrap_pointer_cb, user_data)
    ^~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:483:68: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(Nan::imp::NanEnsureLocal(val))
                                                                   ^
../node_modules/nan/nan.h:754:36: note: candidate function not viable: no known conversion from 'void (char *, void *)' to 'int' for 3rd argument
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (
                                   ^
../node_modules/nan/nan.h:764:36: note: candidate function not viable: requires 2 arguments, but 4 were provided
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (
                                   ^
../node_modules/nan/nan.h:771:36: note: candidate function not viable: requires single argument 'size', but 4 arguments were provided
  NAN_INLINE v8::Local<v8::Object> NanNewBufferHandle (uint32_t size) {
                                   ^
../src/ffi.cc:387:5: warning: 'FatalException' is deprecated: Use FatalException(isolate, ...) [-Wdeprecated-declarations]
    FatalException(try_catch);
    ^
/Users/xo/.node-gyp/4.0.0/include/node/node.h:283:29: note: 'FatalException' has been explicitly marked deprecated here
                inline void FatalException(const v8::TryCatch& try_catch) {
                            ^
/Users/xo/.node-gyp/4.0.0/include/node/node.h:66:42: note: expanded from macro 'NODE_DEPRECATED'
    __attribute__((deprecated(message))) declarator
                                         ^
In file included from ../src/ffi.cc:1:
In file included from /Users/xo/.node-gyp/4.0.0/include/node/node.h:42:
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:221:5: error: assigning to 'v8::Primitive *volatile' from incompatible type 'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:501:12: note: in instantiation of function template specialization 'v8::Local<v8::Primitive>::Local<v8::Value>' requested here
    return NanEscapeScope(NanNew(v8::Undefined(v8::Isolate::GetCurrent())));
           ^
../node_modules/nan/nan.h:483:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(Nan::imp::NanEnsureLocal(val))
                             ^
In file included from ../src/ffi.cc:1:
In file included from /Users/xo/.node-gyp/4.0.0/include/node/node.h:42:
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:221:5: error: assigning to 'v8::Boolean *volatile' from incompatible type 'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:511:12: note: in instantiation of function template specialization 'v8::Local<v8::Boolean>::Local<v8::Value>' requested here
    return NanEscapeScope(NanNew(v8::True(v8::Isolate::GetCurrent())));
           ^
../node_modules/nan/nan.h:483:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(Nan::imp::NanEnsureLocal(val))
                             ^
In file included from ../src/ffi.cc:1:
In file included from /Users/xo/.node-gyp/4.0.0/include/node/node.h:42:
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:221:5: error: assigning to 'v8::Function *volatile' from incompatible type 'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:1645:12: note: in instantiation of function template specialization 'v8::Local<v8::Function>::Local<v8::Value>' requested here
    return NanEscapeScope(NanNew(handle)->Get(kCallbackIndex)
           ^
../node_modules/nan/nan.h:483:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(Nan::imp::NanEnsureLocal(val))
                             ^
In file included from ../src/ffi.cc:1:
In file included from /Users/xo/.node-gyp/4.0.0/include/node/node.h:42:
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:221:5: error: assigning to 'v8::Object *volatile' from incompatible type 'v8::Value *'
    TYPE_CHECK(T, S);
    ^~~~~~~~~~~~~~~~
/Users/xo/.node-gyp/4.0.0/include/node/v8.h:180:37: note: expanded from macro 'TYPE_CHECK'
    *(static_cast<T* volatile*>(0)) = static_cast<S*>(0);      \
                                    ^ ~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:1776:12: note: in instantiation of function template specialization 'v8::Local<v8::Object>::Local<v8::Value>' requested here
    return NanEscapeScope(
           ^
../node_modules/nan/nan.h:483:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(Nan::imp::NanEnsureLocal(val))
                             ^
1 warning and 11 errors generated.
make: *** [Release/obj.target/ffi_bindings/src/ffi.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/xo/.nvm/versions/node/v4.0.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 14.5.0
gyp ERR! command "/Users/xo/.nvm/versions/node/v4.0.0/bin/node" "/Users/xo/.nvm/versions/node/v4.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/xo/Desktop/t/Network-Status-Page/node_modules/diskusage/node_modules/ffi
gyp ERR! node -v v4.0.0
gyp ERR! node-gyp -v v3.0.1
gyp ERR! not ok

><EMAIL_ADDRESS>install /Users/xo/Desktop/t/Network-Status-Page/node_modules/xml2json/node_modules/node-expat/node_modules/iconv
> node-gyp rebuild

  CC(target) Release/obj.target/libiconv/deps/libiconv/lib/iconv.o
  LIBTOOL-STATIC Release/iconv.a
  CXX(target) Release/obj.target/iconv/src/binding.o
  SOLINK_MODULE(target) Release/iconv.node

><EMAIL_ADDRESS>install /Users/xo/Desktop/t/Network-Status-Page/node_modules/xml2json/node_modules/node-expat
> node-gyp rebuild

  CC(target) Release/obj.target/expat/deps/libexpat/lib/xmlparse.o
  CC(target) Release/obj.target/expat/deps/libexpat/lib/xmltok.o
../deps/libexpat/lib/xmltok.c:471:1: warning: missing field 'isName2' initializer [-Wmissing-field-initializers]
};
^
../deps/libexpat/lib/xmltok.c:484:1: warning: missing field 'isName2' initializer [-Wmissing-field-initializers]
};
^
../deps/libexpat/lib/xmltok.c:504:1: warning: missing field 'isName2' initializer [-Wmissing-field-initializers]
};
^
../deps/libexpat/lib/xmltok.c:517:1: warning: missing field 'isName2' initializer [-Wmissing-field-initializers]
};
^
../deps/libexpat/lib/xmltok.c:730:1: warning: missing field 'isName2' initializer [-Wmissing-field-initializers]
};
^
../deps/libexpat/lib/xmltok.c:749:1: warning: missing field 'isName2' initializer [-Wmissing-field-initializers]
};
^
../deps/libexpat/lib/xmltok.c:762:1: warning: missing field 'isName2' initializer [-Wmissing-field-initializers]
};
^
../deps/libexpat/lib/xmltok.c:775:1: warning: missing field 'isName2' initializer [-Wmissing-field-initializers]
};
^
../deps/libexpat/lib/xmltok.c:871:1: warning: missing field 'isName2' initializer [-Wmissing-field-initializers]
};
^
../deps/libexpat/lib/xmltok.c:890:1: warning: missing field 'isName2' initializer [-Wmissing-field-initializers]
};
^
10 warnings generated.
  CC(target) Release/obj.target/expat/deps/libexpat/lib/xmlrole.o
  LIBTOOL-STATIC Release/libexpat.a
  CXX(target) Release/obj.target/node_expat/node-expat.o
  SOLINK_MODULE(target) Release/node_expat.node
npm ERR! Darwin 14.5.0
npm ERR! argv "/Users/xo/.nvm/versions/node/v4.0.0/bin/node" "/Users/xo/.nvm/versions/node/v4.0.0/bin/npm" "install"
npm ERR! node v4.0.0
npm ERR! npm  v2.14.2
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the ref package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls ref
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/xo/Desktop/t/Network-Status-Page/npm-debug.log

you're going to need to upgrade to nan v2, see https://github.com/nodejs/nan for new docs and a simple bash script to do 80% of the conversion work on your c++ code here https://gist.github.com/thlorenz/7e9d8ad15566c99fd116

@rvagg any idea from this which script is using the old nan version? I'd like to contact the authors so they can update their packages.

npm ls and have a look at what's using what


[issue][elasticsearch] Fix status on Elasticsearch object

The status is never updated.
Need to set the URL:

Ingress, LB or service

Need to set the cluster state
Need to set the secret name that store the credentials

It's fixed


KYLIN-3942 Support multi-level json event in backend

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 4390

43 of 48 (89.58%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.07%) to 27.82%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

stream-source-kafka/src/main/java/org/apache/kylin/stream/source/kafka/consumer/KafkaConnector.java
0
2
0.0%

stream-source-kafka/src/main/java/org/apache/kylin/stream/source/kafka/TimedJsonStreamParser.java
43
46
93.48%

Files with Coverage Reduction
New Missed Lines
%

stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java
2
73.74%

Totals

Change from base Build 4386:
0.07%

Covered Lines:
22744

Relevant Lines:
81754

💛  - Coveralls

Codecov Report

Merging #605 into master will increase coverage by 0.05%.
The diff coverage is 81.25%.

@@             Coverage Diff              @@
##             master     #605      +/-   ##
============================================
+ Coverage     25.28%   25.33%   +0.05%
- Complexity     5825     5835      +10
============================================
  Files          1379     1379
  Lines         81716    81754      +38
  Branches      11443    11451       +8
============================================
+ Hits          20663    20716      +53
+ Misses        59039    59014      -25
- Partials       2014     2024      +10

Impacted Files
Coverage Δ
Complexity Δ

...n/stream/source/kafka/consumer/KafkaConnector.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...lin/stream/source/kafka/TimedJsonStreamParser.java
77.92% <84.78%> (+77.92%)
13 <10> (+13)
:arrow_up:

...he/kylin/dict/lookup/cache/RocksDBLookupTable.java
72.97% <0%> (-5.41%)
6% <0%> (-1%)

...org/apache/kylin/rest/util/QueryRequestLimits.java
35.71% <0%> (-4.77%)
5% <0%> (-1%)

...che/kylin/stream/core/storage/CheckPointStore.java
63.63% <0%> (-3.04%)
21% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb96418...fea3c06. Read the comment docs.

After disscussion, I use ParseInfo's columnToSourceFieldMapping to parse multi-level json event.


"An Error has occurred during file processing!"

My tinyripper has consistently been crashing when trying to export my assets.
My error message is below:
Game name: (Guns Up!)
Engine version: (Unity unknown version but i would guess 2018ish)
Platform: (PC)
Error message: SerializedFile with index<PHONE_NUMBER> was not found in dependencies
Stack trace:    at uTinyRipper.SerializedFile.FindAsset(Int32 fileIndex, Int64 pathID, Boolean isSafe)
at uTinyRipper.Converters.ProjectAssetContainer.FindAsset(Int32 fileIndex, Int64 pathID)
at uTinyRipper.Classes.PPtr1.FindAsset(IAssetContainer file)    at uTinyRipper.Classes.PPtr1.ExportYAML(IExportContainer container)
at uTinyRipper.Game.Assembly.SerializableField.ExportYAML(IExportContainer container, Field& etalon)
at uTinyRipper.Game.Assembly.SerializableStructure.ExportYAML(IExportContainer container)
at uTinyRipper.Classes.MonoBehaviour.ExportYAMLRoot(IExportContainer container)
at uTinyRipper.Classes.Object.ExportYAMLDocument(IExportContainer container)
at uTinyRipper.Converters.YAMLAssetExporter.Export(IExportContainer container, IEnumerable1 assets, String path)    at uTinyRipper.Project.AssetExportCollection.Export(ProjectAssetContainer container, String dirPath)    at uTinyRipper.Converters.ProjectExporter.Export(String path, GameCollection fileCollection, IEnumerable1 files, ExportOptions options)
at uTinyRipper.GameStructure.Export(String exportPath, Func`2 filter)
at uTinyRipperGUI.MainWindow.ExportFiles(Object data)

nvm i didnt notice this was no longer supported, ill try asset ripper


Pix3D per-class results and data splits

Dear Yen-Chi,
thanks for this great work and open-sourcing the code and model checkpoints!
As there are no official data splits for Pix3D, except for the chair category, could you provide the data splits which were used in the paper?
Additionally, would it be possible for you to provide the per-class results of the single-view reconstruction results (Tab. 2) or even an evaluation script for that part?
Thanks a lot!

Dear Yen-Chi, I was wondering if you already had time to have a look into this?
Thanks a lot for your time!

Dear Yen-Chi,
any updates on this?
Thank you for your time!


How to do all the workouts ?

First of all: Great, an app that already has many workouts included.
But i don't know how to do all the workouts.
Maybe there will be an explanation in later releases, who knows.

In the plans page tap one of the plans (probably today's one). Then enter your reps/weight for a set. Tap save. Continue this for each exercise until you are done.

In the plans page tap one of the plans (probably today's one). Then enter your reps/weight for a set. Tap save. Continue this for each exercise until you are done.

You have now explained how I should practise this.
But how am I supposed to know how all these exercises are practised?
It's not written anywhere.
That's what I meant.

I won't be putting in Flexify tutorials of how to do exercises


Undefined very vague error that breaks vs code

Issue Type
Bug
Description
I use vs code to write react native javascript (so JSX) and randomly, my vs code will break with this incredibly helpful error. What I mean by this is autocomplete/snippets will cease to work, the colors of text will get weird, and hitting ctrl-s to save will take about 2 seconds in between when I use the hotkey and when the dot next to the file changes, (I use watchman to live reload the iPhone simulator on changes, and the simulator will also wait those 2 seconds because it isn't saved).
I would love to provide steps to reproduce, but I've tried uninstalling VS Code and clearing all caches, not installing any extensions, and I have no idea where to even begin to track down this issue. When I try to look at the line at which it broke, I'm shown this whic if I prettify looks like this. Quitting VS Code, killing all the helper processes in Activity Monitor, and restarting does not fix it reliably, and neither does reloading the window.
About two weeks ago, the same symptoms (autocomplete ceasing to function, weird color text, etc.) would happen and I'd get this error and I have since uninstalled flow and I still get the breaking error.
I love VS Code but I'm getting very frustrated by it breaking unpredictably :(
NOTE This happened on the old release of VS Code and I hoped that updating it would fix it. I am using a hackintosh build, however, this issue also occurs on my macbook pro so I do not believe it is a symptom of me using a hackintosh.
EDIT: not 10 minutes after I posted this issue, my VS Code crashed (like, the official way) for the first time. I pasted the entire error log on pastebin.
VS Code Info
VS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:23:28.607Z)
OS version: Darwin x64 16.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-5820K CPU @ 3.30GHz (12 x 3300)

Load (avg)
3, 3, 3

Memory (System)
32.00GB (14.58GB free)

Process Argv
/Applications/Visual Studio Code.app/Contents/MacOS/Electron

Screen Reader
no

VM
0%

Extensions (9)

Extension
Author (truncated)
Version

rainbow-brackets
2gu
0.0.6

material-icon-theme
PKi
3.2.2

code-settings-sync
Sha
2.8.7

vscode-wakatime
Wak
1.1.22

path-intellisense
chr
1.4.2

auto-close-tag
for
0.5.6

auto-rename-tag
for
0.0.15

indent-rainbow
ode
0.7.2

vscode-jumpy
wma
0.3.1

(1 theme extensions excluded)

Reproduces without extensions

Can you confirm that this issue doesn´t happen when you have extensions disabled https://github.com/Microsoft/vscode/wiki/Performance-Issues#run-with-extensions-disabled?
In one of the screenshots you link to there is an exception from a flow extension

Since you mention there is a delay with saving. When this happens can you please run ´code --status´ and attach the output. This will help us to understand which VS Code process is causing the slow down.

@egamma I uninstalled the flow extension and I still get the error. The "undefined" error happens when all extensions are disabled

It looks like the error happens when we report an error, but the message passed to Error is undefined. However, it is not clear the this ERR is causing the behavior you are observing.
Let´s try something else can you install insiders and do not change anything and I wonder whether you can still reproduce the problem https://code.visualstudio.com/insiders/.

@egamma I am using the insider version, and now I am getting this error

@prodigynelson this is an error that can happen I don´t think it is related to the issue you mention in the discussion:

What I mean by this is autocomplete/snippets will cease to work, the colors of text will get weird, and hitting ctrl-s to save will take about 2 seconds

Let´s ignore the error messages for now but focus on this problem. What language are you using when this happens?

@egamma JSX

OK, sorry but I have to ask again, you have all extensions disabled when this happens? I didn´t see a clear answer in the discussion above.

@egamma yes, I am also running separate VS code windows when it happens.

@egamma whenever I toggle developer tools, vs code crashes

@prodigynelson please file a separate issue on this crash and if possible include some more details about the crash.

@prodigynelson let´s focus on the slow down for now:

and hitting ctrl-s to save will take about 2 seconds

Since you cannot create a CPU profile due to the developer tools crashing, can you run ´code-insiders --status´ when this happens.

@egamma here are the logs when it begins misbehaving

@prodigynelson Do you still  see this in the latest VS Code insiders build? What if you install and enable typescript@next in your workspace by following these instructions: https://code.visualstudio.com/docs/languages/typescript#_using-newer-typescript-versions


Manifest key warnings @ Firefox for Android version

These warnings were given in Mozilla Developer Hub when signing the package for release 0.0.1
⚠ Manifest key not supported by the specified minimum Firefox for Android version
Warning: "strict_min_version" requires Firefox for Android 56.0a1, which was released before version 57 introduced support for "options_ui".
Warning: "strict_min_version" requires Firefox for Android 56.0a1, which was released before version 57 introduced support for "options_ui.page".
⚠ runtime.openOptionsPage is not supported in Firefox for Android version 56.0a1
Warning: This API is not implemented by the given minimum Firefox for Android version

These issues have been patched in release v0.0.2, by bumping minimum version to 57.0.


HBASE-26986 Trace Master Procedure Execution

This one adds a tracing context to the Master's ProcedureV2 execution. This ties all the spans that result from a procedure execution back to a procedure by name.

This gives us nicely contained traces like this,
├─ [spanId=52131d42d4b9b99a,name=TransitRegionStateProcedure table=testCreateOpenDeleteTableSpans, region=dcbb606f964a33df720cae68ae9d44b3, UNASSIGN,hasEnded=true]
  └─ [spanId=b110180fbf63f086,name=PUT hbase:meta,hasEnded=true]
    └─ [spanId=d68bcb4131ebe421,name=AsyncRegionLocator.getRegionLocation,hasEnded=true]
    ├─ [spanId=f3dec62bf805b93d,name=hbase.pb.ClientService/Mutate,hasEnded=true]
      └─ [spanId=b919b8289e36f306,name=RpcServer.process,hasEnded=true]
        └─ [spanId=458fd550bcf0fc10,name=hbase.pb.ClientService/Mutate,hasEnded=true]
          └─ [spanId=bba75977ca158a3e,name=Region.put,hasEnded=true]
            └─ [spanId=48e63e8dd8cedce9,name=WAL.sync,hasEnded=true]
            ├─ [spanId=f2545d1cdd8df88c,name=WAL.appendData,hasEnded=true]
            ├─ [spanId=5245192c950f563b,name=Region.getRowLock,hasEnded=true]
  ├─ [spanId=85d7316b561ca0fc,name=WAL.appendData,hasEnded=true]
  ├─ [spanId=95d636764e433992,name=Region.getRowLock,hasEnded=true]
  ├─ [spanId=9360c4de11428864,name=WAL.sync,hasEnded=true]
  ├─ [spanId=7a78b0d2ef332573,name=Region.put,hasEnded=true]
    └─ [spanId=99dbb2e60aa47b12,name=WAL.sync,hasEnded=true]
    ├─ [spanId=ba71434842eb98db,name=Region.getRowLock,hasEnded=true]
    ├─ [spanId=8bfd48b9277978b7,name=WAL.appendData,hasEnded=true]
  ├─ [spanId=8f0717e91a8852c9,name=Region.getRowLock,hasEnded=true]

FYI, I make only the most trivial effort to deconstruct the details of a procedure onto span attributes. I could see this becoming much more involved, by translating many of the internal details of a specific type of procedure into attributes that decorate the span.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 22s
master passed

+1 :green_heart:
compile
3m 17s
master passed

+1 :green_heart:
checkstyle
1m  3s
master passed

+1 :green_heart:
spotbugs
2m 19s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 12s
the patch passed

+1 :green_heart:
compile
3m 15s
the patch passed

+1 :green_heart:
javac
3m 15s
the patch passed

+1 :green_heart:
checkstyle
0m 59s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 42s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
2m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

37m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4381

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 0bafdb98bb37 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ec78c2677b

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-client hbase-procedure hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 41s
master passed

+1 :green_heart:
compile
1m 25s
master passed

+1 :green_heart:
shadedjars
3m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
1m 20s
the patch passed

+1 :green_heart:
javac
1m 20s
the patch passed

+1 :green_heart:
shadedjars
3m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 56s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 22s
hbase-client in the patch passed.

+1 :green_heart:
unit
1m 13s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
185m 29s
hbase-server in the patch passed.

208m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4381

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4fef55253de1 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ec78c2677b

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/1/testReport/

Max. process+thread count
2506 (vs. ulimit of 30000)

modules
C: hbase-client hbase-procedure hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 47s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 17s
master passed

+1 :green_heart:
compile
1m  6s
master passed

+1 :green_heart:
shadedjars
3m 56s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 44s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  8s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

+1 :green_heart:
shadedjars
3m 53s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  8s
hbase-client in the patch passed.

+1 :green_heart:
unit
1m 28s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
184m 51s
hbase-server in the patch passed.

209m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4381

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d6351d82edd6 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ec78c2677b

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/1/testReport/

Max. process+thread count
2931 (vs. ulimit of 30000)

modules
C: hbase-client hbase-procedure hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Rebased across formatting and updated Jira Summary and commit title according to reviewer feedback.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 51s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 29s
master passed

+1 :green_heart:
compile
3m  5s
master passed

+1 :green_heart:
checkstyle
0m 46s
master passed

+1 :green_heart:
spotbugs
2m  5s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  6s
the patch passed

+1 :green_heart:
compile
3m  3s
the patch passed

+1 :green_heart:
javac
3m  3s
the patch passed

+1 :green_heart:
checkstyle
0m 45s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 32s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
2m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

35m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4381

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 2b57940b6a3d 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 404e1d6870

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-client hbase-procedure hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 46s
master passed

+1 :green_heart:
compile
1m 22s
master passed

+1 :green_heart:
shadedjars
3m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 30s
the patch passed

+1 :green_heart:
compile
1m 20s
the patch passed

+1 :green_heart:
javac
1m 20s
the patch passed

+1 :green_heart:
shadedjars
3m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 56s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 22s
hbase-client in the patch passed.

+1 :green_heart:
unit
1m 19s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
183m 43s
hbase-server in the patch passed.

206m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4381

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ec0eb11620ca 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 404e1d6870

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/2/testReport/

Max. process+thread count
2632 (vs. ulimit of 30000)

modules
C: hbase-client hbase-procedure hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 22s
master passed

+1 :green_heart:
compile
1m 11s
master passed

+1 :green_heart:
shadedjars
3m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 54s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  9s
the patch passed

+1 :green_heart:
compile
1m 12s
the patch passed

+1 :green_heart:
javac
1m 12s
the patch passed

+1 :green_heart:
shadedjars
3m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  1s
hbase-client in the patch passed.

+1 :green_heart:
unit
1m 11s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
192m 28s
hbase-server in the patch passed.

213m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4381

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 33109de0de54 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 404e1d6870

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/2/testReport/

Max. process+thread count
2680 (vs. ulimit of 30000)

modules
C: hbase-client hbase-procedure hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 39s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 22s
master passed

+1 :green_heart:
compile
3m 10s
master passed

+1 :green_heart:
checkstyle
0m 48s
master passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 14s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  6s
the patch passed

+1 :green_heart:
compile
3m 15s
the patch passed

+1 :green_heart:
javac
3m 15s
the patch passed

+1 :green_heart:
checkstyle
0m 47s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m  1s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

38m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4381

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 8cb566fcba12 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ba7ef0216a

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-client hbase-procedure hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 50s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 46s
master passed

+1 :green_heart:
compile
1m  1s
master passed

+1 :green_heart:
shadedjars
3m 55s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  7s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
shadedjars
3m 53s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  8s
hbase-client in the patch passed.

+1 :green_heart:
unit
1m 24s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
183m 43s
hbase-server in the patch passed.

206m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4381

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 440f4892605b 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ba7ef0216a

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/3/testReport/

Max. process+thread count
2890 (vs. ulimit of 30000)

modules
C: hbase-client hbase-procedure hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 49s
master passed

+1 :green_heart:
compile
1m 20s
master passed

+1 :green_heart:
shadedjars
3m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 56s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
1m 22s
the patch passed

+1 :green_heart:
javac
1m 22s
the patch passed

+1 :green_heart:
shadedjars
3m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 55s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 22s
hbase-client in the patch passed.

+1 :green_heart:
unit
1m 13s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
187m  9s
hbase-server in the patch passed.

210m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4381

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c6b323ee4d05 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ba7ef0216a

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/3/testReport/

Max. process+thread count
2469 (vs. ulimit of 30000)

modules
C: hbase-client hbase-procedure hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4381/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[10.x] Fix docs ResourceCollection and JsonCollection

Description
In this pull request, I have updated the PHPDoc for the function [function name]. Previously, the PHPDoc for this function was described as follows:
@return array|\Illuminate\Contracts\Support\Arrayable|\JsonSerializable

However, I have changed it to:
@return array<int|string, mixed>

Reason for Change:
This update aims to clarify the return type of the function. The previous description indicated that the function could return an array, an Arrayable object, or a JsonSerializable object. However, it was not clear about the specific structure of the array.
By using array<int|string, mixed>, I have clarified that this function returns an array with keys that can be either integers or strings, and the values can be of any type.
This helps improve the clarity and transparency of the code and better supports static analysis and code suggestion in IDE tools.
Impact:
This change does not affect the functionality of the function. It simply provides clearer information about the expected return data type.
It helps developers who read and use this function to better understand the data structure they can expect from it.
Looking forward to your feedback and suggestions. If there are any questions or concerns about this change, please feel free to discuss.

\Illuminate\Contracts\Support\Arrayable and \JsonSerializable are actually valid return types for the toArray($request) method.
See: https://github.com/laravel/framework/blob/10.x/src/Illuminate/Http/Resources/Json/JsonResource.php#L105-L118

In addition to @rojtjo's correct comment above, array is implicitly <array-key, mixed>, so this does not add anything specifically.


Address #1718 menu issues.

Purpose / why
Address #1718 When the menu is collapsed into hamburger-lines, the landing page shows only the "About section" menu, which looks like the whole docs are real small!
What changes were made?
Pulled the main page out to be the "About" page, on the top level of the nav menu.
Verification
Test locally
Interested Parties
@Islandora/8-x-committers @dannylamb

Checklist

Pull-request reviewer should ensure the following

[x] Does this PR link to related issues?
[x] Does the proposed documentation align with the Islandora Documentation Style Guide?
[x] Are the changes accurate, useful, free of typos, etc?
[ ] Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

[x] Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
[x] If pages are renamed or removed, have all internal links to those pages been fixed?
[x] If pages are added, have they been linked to or placed in the menu?
[ ] Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

Built the docs, previewed in "mobile" view, and this seems to fix the issue. When you hit the docs, you see the entire TOC now.

Resolves #1718


feat(text-input): text-input @carbon/react v11 sync

Related Ticket(s)
[text-input]: sync with @carbon/react version #10233
Description
@carbon/react syncing with text-input component. This component replaces the input references with text-input
@carbon/react version: https://react.carbondesignsystem.com/?path=/story/components-textinput--playground

Looks like deploy previews are failing because there's still a reference to the original stylesheet filename
Carbon Web Components/packages/carbon-web-components/src/components/text-input/input.scss doesn't exist


Merge refs/heads/feature/find-as-cursor into alpha

Merge refs/heads/feature/find-as-cursor into alpha

This PR has been merged into alpha and tagged as 1.6.0-alpha-202304121642. Thanks for your contribution!

This PR has been merged into alpha and tagged as 1.6.0-alpha-202304121646. Thanks for your contribution!


Enhancement #5: persistent pin states

Pull request for Enhancement Issue #5
Changes:

Moved the pin state Booleans into the settings of the plugin as hidden settings from the user as a way of persisting the states of the pins between launches of Obsidian

Testing:

I tested as many scenarios as I could come up with (panes already open, enabling and disabling the pins in settings)

great work! thank you.