the mod is broken?

I'm using the 1.20.6 version of the mod. I died and lost everything except my fireworks; my tools, weapons, armor, & food weren't dropped where I died. All my fighting equipment was just removed from the world, not dropped, or put in my inventory.

Are your playing in singleplayer or multiplayer? Do you have other mods/plugins/data packs installed?
The pack never touches the items that should be kept at all, it internally uses the "KeepInventory" gamerule and only removes the items that should be dropped, so the equipment meant to be kept never leave your inventory.

I'm using singleplayer, and I am using some other mods that add new content but don't modify any vanilla items, at least not any that I had in my inventory / items dropped on death
Here's how my inventory looked after I got my items back,

When I respawned, I only had my fireworks, the water buckets, the ender pearls, the stack of arrows, and i think? my food.

So you kept some items but not all of the ones you were supposed to? But items still dropped where you died, just not all? That’s even more strange..
Can you tell me the items that behaved weirdly? Then I may be able to reproduce this in vanilla minecraft - but if this is just an incompatibility with a mod, I’m sorry but I won’t be fixing that then, many mods introduce incompatibilities and as a data pack developer it’s impossible to react to all of them.

I had an elytra and a set of diamond armor equipped (except for the chestplate which was in my inventory), a mace, a trident, a bow, and a diamond sword, axe, pickaxe, and shovel.

I’ll see if I can re-create that in vanilla somehow - thanks for letting me know

I can not reproduce this:
Inventory before death

Dropped items on ground

Inventory after collecting items

As I said, the pack never clears items that are not supposed to be cleared. This is most likely an incompatibility with other mods you have installed, this is not an issue with KeepSomeInventory and will therefore not be fixed, thanks for the report though!

Sorry, I was hasty, the bug was with enchanted items, it's been fixed in v1.4.2 and onward, sorry for the lost items and general inconvenience


TTL: Only drop altogether the expired parts and not partially prune them.

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):

Performance Improvement

Short description (up to few sentences):
MergeTree now has an additional option ttl_only_drop_parts (disabled by default) to avoid partial pruning of parts, so that they dropped completely when all the rows in a part are expired.
This allows to have shorter merge_with_ttl_timeout times and lower impact on systems performance.
Also fixes a performance bug in TTLBlockInputStream::readImpl(): if we know that we will not need the data, we must never read the child stream. This change is the most risky here though.
TODO: Need to add tests.

I click on Details for the failed Performance test and it time outs.

Performance tests have been failed because of CI problems.

I reverted it because there were other tests failures. I was thinking that this fix caused them.
Maybe they happened because of the CI problems as well?
I do not see the previous CI run results, I'll give another try to push the fix.
As for testing, do you have any ideas how to test this stuff better? The new flag does not change the client visible behaviour. Look at some metrics?

Yes, tests failures are not related to your changes.
It's hard to check performance with TTL using CI tests. I think it's reasonable to write unit tests for TTLMergeSelector, because TTL tests use OPTIMIZE ... FINAL and  selector is stayed almost unused. But it's not exactly part of this task, because test is needed for all it's functionality. So, I can add this test later.

00974_query_profiler - flappy test failed by timeout.

I will look at query_profiler test.

query_profiler test has been fixed.

@CurtizJ ?


feat: update default to ubuntu 20.04

@Yajo seems like Travis.org has been deprecated. We can either migrate to Travis.com (I guess by registering the project there) or use something like https://github.com/marketplace/actions/publish-ansible-role-to-galaxy here to publish to Ansible Galaxy through a GH Action. We would just need to set up the appropriate secret. What do you prefer?

Ok, can you create the required secret then? It would be something like galaxy_api_key

@Yajo I removed the Travis action from here, so we will only know if the new one is working once we merge to master. Can you review please?


Fix minor formatting issues

Fix minor formatting issues.

I can also see that there are some functions that we support by now that may need to be updated here such as:
AS_CHAR , AS_VARCHAR, AS_DECIMAL , AS_NUMBER, AS_DOUBLE , AS_REAL, SUM, MODE, ANY_VALUE
cc: @HarshCasper

Thanks @whummer it totally make sense, good insight 👍  I'm closing the PR then. Will fix in the code where applicable.


Fixed up initial draft of article with example code

:rocket: This PR description was created by Ellipsis for commit e8c5059ab57c15e244b538e660f6f9ba27d1e18e.

Summary:
This PR introduces a new blog post on generating synthetic data and evaluating retrieval algorithms, and includes Python scripts that implement the concepts discussed in the post.
Key points:

Adds a new blog post explaining how to use Instructor to generate synthetic data, chunk and embed text using lancedb, and evaluate the performance of a retrieval algorithm using NDCG and MRR metrics.
Includes Python scripts (ingest.py and questions.py) that implement the concepts discussed in the blog post.
Adds a requirements.txt file listing the Python libraries needed to run the scripts.

Generated with :heart: by ellipsis.dev

lets not flood the repo with text files and move the blog to
jxnl/blog


Add a new generated page to group symbol overloads together

Bug/issue #, if applicable: rdar://116550528
Summary
In an effort to simplify symbol overloads, this PR creates a new generated "overload group" page for each group of overloads it encounters. This page has a simplified page subheading based on the first overload's information, and links to the first overload's declaration. This page's path is the same as the first overload's path, without a disambiguating hash.
Dependencies
None
Testing
Steps:

With a recent main branch Swift-DocC-Render built in $DOCC_HTML_DIR, run swift run docc preview --enable-experimental-overloaded-symbol-presentation Tests/SwiftDocCTests/Test\ Bundles/OverloadedSymbols.docc
Navigate to the OverloadedEnum symbol.
Ensure that a separate firstTestMemberName(_:) page is added to the automatic curation alongside the specific overloads.

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran the ./bin/test script and it succeeded
[ n/a ] Updated documentation if necessary

@swift-ci Please test

Based on discussions both here and offline, i'm closing this PR in favor of https://github.com/apple/swift-docc/pull/846.


Merge #83 into master branch. (Send plugin.check._name_s list on updateHost)

Merge #83 into master branch. (Send plugin.check._name_s list on updateHost)


Information Overlap on new chart instance

Hi
I'm having an issue where it looks like the new chart objects are overlapping. I'm working on a web app that has a single page, on click of a button it will re-render the page and a new chart with a different data set, this works until you hover over a point on the graph then for some reason it displays the previously rendered graph information. I'm still in the process of learning JavaScript so could be missing something obvious...
can anyone shed some light on this?

On hover over a point

Any help would be massively appreciated
Thank you
code snippets:
function loadDbPage() {
        toggleActiveBtns("sideNav", dbBtn, sideNavBtnArray);
        let databaseYears = yearsInDatabase();
        let header1 = document.getElementById("header1")
        header1.innerHTML = ''
        header1.innerHTML = `<h1>Drybulb Frequency Data  For ${selectionData.monthOfInterest.name}</h1>`
        let header2 = document.getElementById("header2")
        header2.innerHTML = ''
        header2.innerHTML = `

        • DB = Dry bulb temperature (center of bin), degC

        • Frequecy = number of hours of occurence between ${databaseYears[0]} and ${databaseYears[1]}

`
        addTable("DB");
        buildFreqChart(chartDataSet);
    }

function buildFreqChart(freqData, barDataSet) {
    const ctx = document.getElementById('myChart').getContext('2d');
    let labels = [];
    let freqDataSet = [];
    let unitKW = [];
    for (let i = 0; i < freqData.length; i++) {
        labels.push(freqData[i][0])
        freqDataSet.push(freqData[i][1])
        unitKW.push(i * (1 + Math.random()))
    };
    let chart = new Chart(ctx, {
        // The type of chart we want to create
        type: 'line',

        // The data for our dataset
        data: {
            labels: labels,
            datasets: [{
                    type: 'line',
                    label: 'Frequency',
                    yAxisID: 'frequency-Axis',
                    backgroundColor: 'rgba(255, 99, 132, 0.2)',
                    borderColor: 'rgb(255, 99, 132)',
                    data: freqDataSet,
                    borderWidth: 1

                },
                {
                    type: 'bar',
                    label: 'Unit kW',
                    yAxisID: 'UnitkW-Axis',
                    backgroundColor: 'rgba(247, 219, 7, 0.1)',
                    borderColor: 'rgba(247, 219, 7,0.3)',
                    data: unitKW,
                    borderWidth: 1

                }
            ]
        },

        // Configuration options go here
        options: {
            legend: {
                labels: {
                    fontFamily: 'Arial, Helvetica, sans-serif',
                    fontSize: 14,
                    fontColor: 'rgb(158, 202, 237)'
                }
            },
            scales: {
                xAxes: {
                    type: 'linear',
                    scaleLabel: {
                        display: true,
                        labelString: 'Deg C',
                        fontFamily: 'Arial, Helvetica, sans-serif',
                        fontSize: 14,
                        fontColor: 'rgb(158, 202, 237)'
                    },
                    type: 'linear',
                    position: 'left',
                    gridLines: {
                        color: 'rgba(158, 202, 237, 0.1)'
                    },
                    ticks: {
                        fontColor: 'rgb(158, 202, 237)',
                        stepSize: 0.5,
                        // maxTicksLimit: 30,
                    },

                },

                'frequency-Axis': {
                    scaleLabel: {
                        display: true,
                        labelString: 'Frequency Of Occurence',
                        fontFamily: 'Arial, Helvetica, sans-serif',
                        fontSize: 14,
                        fontColor: 'rgb(158, 202, 237)'
                    },
                    gridLines: {
                        color: 'rgba(158, 202, 237, 0.2)'
                    },
                    ticks: {
                        fontColor: 'rgb(158, 202, 237)',
                        stepSize: 0.5,
                        maxTicksLimit: 30
                    }
                },
                'UnitkW-Axis': {
                    scaleLabel: {
                        display: true,
                        labelString: 'Unit kW',
                        fontFamily: 'Arial, Helvetica, sans-serif',
                        fontSize: 14,
                        fontColor: 'rgb(158, 202, 237)'
                    },
                    type: 'linear',
                    position: 'right',
                    gridLines: {
                        display: false
                    },
                    ticks: {
                        fontColor: 'rgb(158, 202, 237)',
                        stepSize: 0.5,
                        maxTicksLimit: 30
                    }

                }
            }

        }
    });

}

@JPDuffy1993 the issue is that you're not calling .destroy() on the old chart instance before creating a new one. When the 2nd chart is created, the first still exists and shows up during mouse events.
There are two options to solve this:

Re-use the chart that was initially created but change the data/options
Call .destroy() on the old chart before creating the new one

Depending on what framework (if any) you're using, that will influence how you keep track of the old chart state. In React, I've put it in state before.

Thank you for this, sorted now

I think we could detect this and throw an error. It seems to be quite common error.

@kurkle perhaps attach something to the context to flag it as in use. I did a quick test in a fiddle and the exact same context object is returned for multiple calls to getContext (in Chrome)

I think the DOM platform stored chart in canvas. Could utilize that.


Redesign Review Screen

According to the Material Design guidelines, this PR redesigns the review screen:

Make the screen a full-screen dialog.
Replace Exploration Mode alert with a dismissable banner.
Make the article panel a card.
Replace the decision navigation bar with floating action buttons.
Adjust the side statistics sheet.
Make all components responsive to a small screen.

Large Screen

When undo mode is active, an alert appears on the previous record:

Small Screen

Thanks to @SagevdBrand for her insightful feedback. Besides styling issues, she proposed the function that can "freeze" a record card if we want to skip a record (in a future release). In other words, skipping a record is not a decision, which means this feature does not merit another button alongside "relevant" and "irrelevant". This feature should be associated with the record card.

Love this. We will continue working on this and finetune/UX test the interface.


Adding riscv-dv to CHIPS Alliance Graduated

This file confirms riscv-dv graduation to CHIPS Alliance projects.

Left some comments, but seems like we're close.

Seems like we can vote on this!

Thanks for updating, I’ve been out past few days. LGTM.
On Wed, Jun 23, 2021 at 8:30 AM Michael Gielda @.***>
wrote:

Seems like we can vote on this!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chipsalliance/tsc/pull/66#issuecomment-866938494, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AHDIIR5DLY4F7SOGM74GWZ3TUH4XTANCNFSM46Q7S5NQ
.

Changing name of PR to reflect there is still a little work to do here.

Matt mentioned he's going to do this when he returns from holiday, next week.

Hi @mcockrell-google - summing up, we had two minor threads:

naming, I would go for "RISC-V DV" everywhere (no backticks)
your role, I think if you change "workgroup" to "subgroup" everything will be fine.

Done.
On Mon, Aug 9, 2021 at 9:36 AM Michael Gielda @.***>
wrote:

Hi @mcockrell-google https://github.com/mcockrell-google - summing up,
we had two minor threads:

naming, I would go for "RISC-V DV" everywhere (no backticks)
your role, I think if you change "workgroup" to "subgroup"
everything will be fine.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chipsalliance/tsc/pull/66#issuecomment-895369870, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AHDIIRYW2BRMDLFPN2ZHSE3T377XFANCNFSM46Q7S5NQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

This will close #57

LGTM, thanks! Starting vote.

5/8 votes in, waiting for some more to come in until the end of the week, but technically we passed, so by next week @mcockrell-google we will be welcoming you in the TSC I assume!


Cannot upgrade krr to version 1.10.0

Hello,
My brew cannot upgrade krr from version 1.8.3 to the version 1.10.0.
As far as I can understand, the error happens here:
==> Running 'krr version' to warm up binary and extract compressed python libraries... this can take up to 60 seconds
==> /usr/local/Cellar/krr/1.10.0/libexec/krr version
Failed to execute: /usr/local/Cellar/krr/1.10.0/libexec/krr

Here is the full output:
% brew upgrade --verbose
==> Upgrading 1 outdated package:
robusta-dev/krr/krr 1.8.3 -> 1.10.0
==> Fetching robusta-dev/krr/krr
==> Downloading https://github.com/robusta-dev/krr/releases/download/v1.10.0/krr-macos-latest-v1.10.0.zip
Already downloaded: /Users/aazon/Library/Caches/Homebrew/downloads/10f7fd854de52a19a9b2b0ade2bbbde764225eab1666d66222c2f775023fc60d--krr-macos-latest-v1.10.0.zip
==> Verifying checksum for '10f7fd854de52a19a9b2b0ade2bbbde764225eab1666d66222c2f775023fc60d--krr-macos-latest-v1.10.0.zip'
==> Upgrading robusta-dev/krr/krr
  1.8.3 -> 1.10.0
rm /usr/local/bin/krr
/usr/bin/env PATH=/usr/local/Homebrew/Library/Homebrew/shims/mac/super:/usr/bin:/bin:/usr/sbin:/sbin unzip -o /Users/aazon/Library/Caches/Homebrew/downloads/10f7fd854de52a19a9b2b0ade2bbbde764225eab1666d66222c2f775023fc60d--krr-macos-latest-v1.10.0.zip -d /private/tmp/homebrew-unpack20240614-85866-jf2v7l
/usr/bin/env cp -pR /private/tmp/homebrew-unpack20240614-85866-jf2v7l/krr/. /private/tmp/krr-20240614-85866-uhfuqd/krr
==> Running 'krr version' to warm up binary and extract compressed python libraries... this can take up to 60 seconds
==> /usr/local/Cellar/krr/1.10.0/libexec/krr version
Failed to execute: /usr/local/Cellar/krr/1.10.0/libexec/krr
ln -s ../Cellar/krr/1.8.3/bin/krr krr

==> Formula
Tap: robusta-dev/krr
Path: /usr/local/Homebrew/Library/Taps/robusta-dev/homebrew-krr/Formula/krr.rb
==> Configuration
HOMEBREW_VERSION: 4.3.5-95-g24f74c0
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: 24f74c05280870be60168ed7287789e59b9e4ff9
Last commit: 6 hours ago
Core tap HEAD: 39c4d9bb45d8d1e993be50a46390cad92dbabda3
Core tap last commit: 2 hours ago
Core tap JSON: 14 Jun 09:26 UTC
Core cask tap HEAD: 5d6faad7cfec3b34f25251c2792ab9025807a08f
Core cask tap last commit: 2 hours ago
Core cask tap JSON: 14 Jun 09:26 UTC
HOMEBREW_PREFIX: /usr/local
HOMEBREW_AUTO_UPDATE_SECS: 86400
HOMEBREW_CASK_OPTS: []
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 12
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.3.3 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.3/bin/ruby
CPU: dodeca-core 64-bit kabylake
Clang: 15.0.0 build 1500
Git: 2.45.2 => /usr/local/bin/git
Curl: 8.6.0 => /usr/bin/curl
macOS: 14.5-x86_64
CLT: <IP_ADDRESS>.1.1708646388
Xcode: 15.4
==> ENV
HOMEBREW_CC: clang
HOMEBREW_CXX: clang++
MAKEFLAGS: -j12
CMAKE_PREFIX_PATH: /usr/local
CMAKE_INCLUDE_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers
CMAKE_LIBRARY_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig/14
HOMEBREW_GIT: git
HOMEBREW_SDKROOT: /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk
ACLOCAL_PATH: /usr/local/share/aclocal
PATH: /usr/local/Homebrew/Library/Homebrew/shims/mac/super:/usr/bin:/bin:/usr/sbin:/sbin

Error: robusta-dev/krr/krr 1.10.0 did not build
Logs:
     /Users/aazon/Library/Logs/Homebrew/krr/00.options.out
     /Users/aazon/Library/Logs/Homebrew/krr/01.krr
If reporting this issue please do so at (not Homebrew/brew or Homebrew/homebrew-core):
  https://github.com/robusta-dev/homebrew-krr/issues

I tried to reinstall krr but got the same error message.

Strange, if you completely uninstall and then reinstall does it succeed?

Uninstall and reinstall don't help:
% brew uninstall krr -v
Uninstalling /usr/local/Cellar/krr/1.8.3... (2,614 files, 320.4MB)
rm /usr/local/bin/krr

% brew cleanup
...
Removing: /Users/aazon/Library/Caches/Homebrew/XXX
Removing: /Users/aazon/Library/Caches/Homebrew/YYY
...
Pruned 0 symbolic links and 2 directories from /usr/local
==> This operation has freed approximately 215.6MB of disk space.

Now trying to install krr again:
% brew install krr -v
==> Fetching robusta-dev/krr/krr
==> Downloading https://github.com/robusta-dev/krr/releases/download/v1.10.0/krr-macos-latest-v1.10.0.zip
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/603117527/36ab9ebd-a79e-4154-8771-df5a564ab747?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=releaseassetproduction%2F20240614%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240614T111010Z&X-Amz-Expires=300&X-Amz-Signature=8b6360952331cbaeb504590792db0b468d3b52154244554ce45672d948889ba3&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=603117527&response-content-disposition=attachment%3B%20filename%3Dkrr-macos-latest-v1.10.0.zip&response-content-type=application%2Foctet-stream
/usr/bin/env /usr/local/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/4.3.5-95-g24f74c0\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 14.5\)\ curl/8.6.0 --header Accept-Language:\ en --fail --retry 3 --remote-time --output /Users/aazon/Library/Caches/Homebrew/downloads/10f7fd854de52a19a9b2b0ade2bbbde764225eab1666d66222c2f775023fc60d--krr-macos-latest-v1.10.0.zip.incomplete --location https://objects.githubusercontent.com/github-production-release-asset-2e65be/603117527/36ab9ebd-a79e-4154-8771-df5a564ab747\?X-Amz-Algorithm=AWS4-HMAC-SHA256\&X-Amz-Credential=releaseassetproduction\%2F20240614\%2Fus-east-1\%2Fs3\%2Faws4_request\&X-Amz-Date=20240614T111010Z\&X-Amz-Expires=300\&X-Amz-Signature=8b6360952331cbaeb504590792db0b468d3b52154244554ce45672d948889ba3\&X-Amz-SignedHeaders=host\&actor_id=0\&key_id=0\&repo_id=603117527\&response-content-disposition=attachment\%3B\%20filename\%3Dkrr-macos-latest-v1.10.0.zip\&response-content-type=application\%2Foctet-stream
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 82.2M  100 82.2M    0     0  6431k      0  0:00:13  0:00:13 --:--:-- 6688k
==> Verifying checksum for '10f7fd854de52a19a9b2b0ade2bbbde764225eab1666d66222c2f775023fc60d--krr-macos-latest-v1.10.0.zip'
==> Installing krr from robusta-dev/krr
/usr/bin/env PATH=/usr/local/Homebrew/Library/Homebrew/shims/mac/super:/usr/bin:/bin:/usr/sbin:/sbin unzip -o /Users/aazon/Library/Caches/Homebrew/downloads/10f7fd854de52a19a9b2b0ade2bbbde764225eab1666d66222c2f775023fc60d--krr-macos-latest-v1.10.0.zip -d /private/tmp/homebrew-unpack20240614-2598-f4jkx9
/usr/bin/env cp -pR /private/tmp/homebrew-unpack20240614-2598-f4jkx9/krr/. /private/tmp/krr-20240614-2598-bd2e0e/krr
==> Running 'krr version' to warm up binary and extract compressed python libraries... this can take up to 60 seconds
==> /usr/local/Cellar/krr/1.10.0/libexec/krr version
Failed to execute: /usr/local/Cellar/krr/1.10.0/libexec/krr

==> Formula
Tap: robusta-dev/krr
Path: /usr/local/Homebrew/Library/Taps/robusta-dev/homebrew-krr/Formula/krr.rb
==> Configuration
HOMEBREW_VERSION: 4.3.5-95-g24f74c0
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: 24f74c05280870be60168ed7287789e59b9e4ff9
Last commit: 8 hours ago
Core tap HEAD: 39c4d9bb45d8d1e993be50a46390cad92dbabda3
Core tap last commit: 4 hours ago
Core tap JSON: 14 Jun 11:05 UTC
Core cask tap HEAD: 5d6faad7cfec3b34f25251c2792ab9025807a08f
Core cask tap last commit: 4 hours ago
Core cask tap JSON: 14 Jun 11:05 UTC
HOMEBREW_PREFIX: /usr/local
HOMEBREW_AUTO_UPDATE_SECS: 86400
HOMEBREW_CASK_OPTS: []
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 12
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.3.3 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.3/bin/ruby
CPU: dodeca-core 64-bit kabylake
Clang: 15.0.0 build 1500
Git: 2.45.2 => /usr/local/bin/git
Curl: 8.6.0 => /usr/bin/curl
macOS: 14.5-x86_64
CLT: <IP_ADDRESS>.1.1708646388
Xcode: 15.4
==> ENV
HOMEBREW_CC: clang
HOMEBREW_CXX: clang++
MAKEFLAGS: -j12
CMAKE_PREFIX_PATH: /usr/local
CMAKE_INCLUDE_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers
CMAKE_LIBRARY_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig/14
HOMEBREW_GIT: git
HOMEBREW_SDKROOT: /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk
ACLOCAL_PATH: /usr/local/share/aclocal
PATH: /usr/local/Homebrew/Library/Homebrew/shims/mac/super:/usr/bin:/bin:/usr/sbin:/sbin

Error: robusta-dev/krr/krr 1.10.0 did not build
Logs:
     /Users/aazon/Library/Logs/Homebrew/krr/00.options.out
     /Users/aazon/Library/Logs/Homebrew/krr/01.krr
If reporting this issue please do so at (not Homebrew/brew or Homebrew/homebrew-core):
  https://github.com/robusta-dev/homebrew-krr/issues

These open issues may also help:
Cannot upgrade krr to version 1.10.0 https://github.com/robusta-dev/homebrew-krr/issues/4

Can you get downloading the same release from GitHub using the cli (copy the url from the releases page and download it with curl -L <url> -o krr.zip then unzip it, cd into the directory, run it, and share logs?
It's important that you do NOT download with the browser as the binaries are unsigned and Mac OS quarantines browser downloaded binaries.

fwiw, seems like the macos builds are only for Apple silicon (arm64).
$ ./krr/krr simple
-bash: ./krr/krr: Bad CPU type in executable
$ file ./krr/krr
./krr/krr: Mach-O 64-bit executable arm64

related: https://github.com/actions/runner-images/issues/9741

Yes, that's right. Is building binaries for Mac OS x86 just a matter of using an older non-ARM image? Is there an image on which we can build a universal binary or does it have to be separate builds?

I tried to download a binary using curl command but got an error in the end:
% curl -L https://github.com/robusta-dev/krr/releases/download/v1.11.0/krr-macos-latest-v1.11.0.zip -o krr-macos-latest-v1.11.0.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 82.2M  100 82.2M    0     0  6145k      0  0:00:13  0:00:13 --:--:-- 6372k

Then I tried to execute the krr binary:
% ./krr --help
zsh: bad CPU type in executable: ./krr

What architecture are you on? I think we are only building ARM binaries right now.

I have Intel MacBook

Got it. I've opened a PR to build binaries for x86 starting from the next release.
https://github.com/robusta-dev/krr/pull/302/files
Until then, are you able to run from source or via the Docker image?

❯ ./krr version
zsh: bad CPU type in executable: ./krr
:(

I have similar problem here, in a fresh homebrew install on RHEL 8.9, it needs GLIBC_2.35, yet my os only have glibc_2.28.

@aantn Hi! Could you please describe, any updates when new release come with support x86_64? Thanks!

Hey, we should have x86 compatible binaries now. Likewise, we already merged and released the GLIBC changes.
@yotles are you able to use the binaries if you download them from the Releases page? (Make sure to use curl - otherwise Mac OS sandboxes the binaries if you download with the browser.)

@aantn Yep, checked again and it works with krr-macos-13-v1.13.0.zip. Thanks for reply! Your app is pretty cool, looks like it will help with optimizing my resources.

Wonderful, happy to hear it!


"quotation mark"

Type of issue
Other (describe below)
Description
In the discussion of <param>, the phrase

    Enclose the name in double quotation marks (" ").

implies that

    <param name=" "name" ">description</param>

is acceptable. It is not!
The problem is that over the years, programmers' poor US English has referred to the quotation mark as "double quotes". I have no doubt that the author of this page has succumbed to this poor practice. The problem exists in eight places in this document and in myriad other places throughout MS documentation.
I suggest that "double quotation marks" be replaced by "quotation marks" and that (" ") be replaced with (").
Page URL
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/xmldoc/recommended-tags
Content source URL
https://github.com/dotnet/docs/blob/main/docs/csharp/language-reference/xmldoc/recommended-tags.md
Document Version Independent Id
d135d0a6-53d2-1567-0b1b-7aae5e07739f
Article author
@BillWagner
Metadata

ID: 3bcb925f-ef72-9a64-3762-c0b4a96f9dc4
Service: dotnet-csharp
Sub-service: lang-reference

This is a reasonable suggestion @gggustafson
I've added it to our backlog, and I've added the "help wanted" label in case someone wants to submit a PR before we next update this article.

I need to talk with you about the abrupt closing of the T and N record issue (Issue #41597). It appear to have been closed by Cyrus Najmabadi. Please advise.

@gggustafson

I need to talk with you about the abrupt closing of the T and N record issue (Issue #41597).

I did see that. Cyrus is a member of the compiler team. I tagged him to verify that the current behavior is correct. It is. I closed for that reason. The docs say what does happen: the XML tags are emitted only when doc comments exist.
Cyrus also provided several alternatives to get the information you needed.
I'm not sure what else you expect.

The issue was becoming whether or not the requirements were valid. The discussion had gone beyond the documentation and had become one of the appropriateness of the compiler XML output.
I guess my question is now "how do I report this incomplete compiler output?"

I guess my question is now "how do I report this incomplete compiler output?"

Your feedback was reported.  We assessed it and determined that the behavior was as expected and will not be changing.  Suitable solutions were provided so that you can accomplish your end goal with the doc output of the compiler.
You view this as 'incomplete'.  Your view is valid.  :)
We view it as working as intended.  Our view is valid. :)
If you need help using the other technologies we listed as appropriate for your problem space, we're happy to assist.

I do not normally respond in this manner. However, your attitude and disrespect are hallmarks of an individual who is too sure of himself and does not recognize when he is speaking gibberish.
I have been programming for more than 60 years. I was a member of the X3J9 Pascal Technical Committee. I have been programming in C# since 2005 and before that in C. I am an evangelist for Microsoft since I found that MS provides a well-constructed and elegant (Visual Studio) platform on which to develop software.
However, no matter how carefully MS builds its software (in this case, C# compiler) there is always the non-vanishing probability of error. Errors exist in two varieties: those that are caused by the implementers of a requirement; those that are caused by a failure in the requirements themselves. The former are programmer errors. The latter are architectural errors. Both may exist for a long time before discovery - even 25 years.
The failure to produce T and N records means that I am not able to use the compiler generated XML document as input to my HTML producing program. There does not appear to be anyway to get the compiler-known namespace. I have a version of the program that performs a lexical scan of the source code and extracts the needed data. But the only way that I can get the namespace is through the .CSPROJ file's RootNamespace. (The only way that I can get the Assembly is through the .CSPROJ file's AssemblyName.)
IMHO, the failure to supply T and N records (and some type of record for the assembly name) in the compiler-generated XML is a requirements failure. It seems that MS's intent was to encourage programmers to document their code. Yet MS is not providing the necessary data to fulfill that intent.
You casually state "You can use our APIs. We have many you can use here. Reflection. Roslyn. Etc" You fail to realize that I am providing the user with the ability to choose C# files that are in a project file. I cannot use reflection! I do not plan to compile the C# files! So what APIs? What I need are the specifics that you fail to mention.
Note the web page for DataTable:

    **DataTable Class**

        Reference

    **Definition**

        Namespace:  System.Data
        Assembly:  System.Data.Common.dll
        Source:  DataTable.cs

This and countless other web pages begin the same way. Using my own lexical scanner, I can obtain:

    **BoyerMoore Class**

    **Definition**

        Namespace: Utilities

Must I use my own software and access the CSPROJ file for other data? Today, I must!
You are non-responsive to a valid issue with the compiler-generated XML.

The failure to produce T and N records means that I am not able to use the compiler generated XML document as input to my HTML producing program.

Correct.  As stated, that's expected as there is no intent for the compiler to provide xml document entries for items that do not have doc comments on them.
If you need that information, we have APIs that you can use instead to get it.  We are happy to help you with that information.  As before, we do not intend to change the behavior here around xml documentation.  If you would like to discuss this more, we're happy to help over at our discord channels: https://discord.com/invite/tGJvv88

You fail to realize that I am providing the user with the ability to choose C# files that are in a project file. I cannot use reflection! I do not plan to compile the C# files! So what APIs?

As mentioned, Roslyn has apis here that you can use to get at this information without reflection.

I cannot use reflection!

That's why i mentioned both.  One that would work if you had an available built artifact you could introspect at runtime.  The other if you didn't, and needed to access this information from source alone.  If you'd like to discuss Roslyn more and how it can be used to get the information you need, please come to the discord link above and we can help you.


Moon Daisy Scans

Source name
Moon Daisy Scans
Source link
https://moondaisyscans.biz/
Source language
Turkish
Other details
18+/NSFW: YES
Acknowledgements

[X] I have checked that the extension does not already exist by searching the extension listing and verified it does not appear there.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[X] I will fill out all of the requested information in this form.

Was removed in commit 874cbe5dcefbeb1f2a505985feafeb3a70c378e3, should reuse as much as possible from that.


Why is there Linear and Circular bools on Locus struct?

Describe the bug
In io.go at line 80 + 81, there is a Circular and Linear field, both as booleans. Couldn't you just have one? (Since if Circular is false, linear is true, and vice versa, by definition).
Is this here simply to accommodate the ambiguous case?
To Reproduce
Steps to reproduce the behavior:
go to io.go
Expected behavior
A single field
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

@TimothyStiles I can fix the cloning stuff if I have an answer to this

@TimothyStiles I can fix the cloning stuff if I have an answer to this

@Koeng101 did we already solve this? Should be fixed with #227.

Think so. Let's close.

https://github.com/TimothyStiles/poly/blob/beacf5d83d54f588c154a634e9f222b27349291c/io/genbank/genbank.go#L97-L98
Heyyyyyy


Motion to dismiss for lack of service

Being tracked in #303 with other motions

#507

Not in motion tester or EDDE. Still need to automate


scootapi: allow configuring number of tasks per job; output job progress

Current coverage is 60.90% (diff: 100%)

No coverage report found for master at 3602e15.

Powered by Codecov. Last update 3602e15...c1a457d


chore: make risedev tasks more readable

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

make private
--hide-uninteresting
group aliases https://github.com/sagiegurari/cargo-make/issues/862
better categories
🌟

❯ r+
[cargo-make] INFO - cargo make 0.36.10
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: default
[cargo-make] INFO - Profile: development
Misc
----------
clean-data - Clean all data, config and logs
clean-etcd-data - Clean etcd data
clean-full - Clean all downloaded binaries by deleting .risingwave folder
delete - Delete a node in the cluster [aliases: del]
doc - Open rustdoc for risingwave
download-all - Download all available components at once
follow - Follows the end of the logs of a specific component [aliases: f]
install - 🌟 Install RiseDev so you can run it from anywhere
logs - Open logs with VSCode or dump in console [aliases: l]
ls - List all nodes in the cluster
lsw - List --watch all nodes in the cluster

RiseDev - Build
----------
build-connector-node - Build RisingWave Connector from source
build-docs - Build Rust docs
build-risingwave - Build Rust components [aliases: b, build]
clean - Clean Rust targets
configure - Configure what components to download/build
link-all-in-one-binaries - Link all-in-one cmds to RiseDev bin
sbuild - Build in simulation mode

RiseDev - Check
----------
check - 🌟 Perform pre-CI checks and automatically fix cargo sort, cargo hakari, cargo fmt warnings [aliases: c]
check-clippy - Run cargo clippy check
check-clippy-fix - Run cargo clippy check and fixes all files (including dirty and staged)
check-dep-sort - Run cargo sort check and attempt to fix
check-fix - Perform pre-CI checks and automatically fix cargo sort, cargo hakari, fixes cargo fmt warnings [aliases: cf]
check-fmt - Run cargo fmt check and attempt to fix
check-hakari - Run cargo hakari check and attempt to fix
check-java - Run mvn spotless:check in connector-node
check-java-fix - Run mvn spotless:apply in connector-node
check-typos - Run cargo typos-cli check
check-udeps - Check unused dependencies
install-tools - Install (or upgrade) required tools to do pre-CI check and run e2e tests

RiseDev - Compose
----------
apply-compose-deploy - Run deploy.sh
apply-compose-docker - Run deploy.sh
compose - Compose a docker-compose.yaml file
compose-deploy - Compose a docker-compose.yaml deploy directory

RiseDev - Deterministic Simulation
----------
sarchive-it-test - Archive integration tests in deterministic simulation mode
scheck - Run cargo check in deterministic simulation mode
sit-test - Run integration tests in deterministic simulation mode
sslt - Run e2e tests in deterministic simulation mode
sslt-build-all - Build deterministic simulation runner and tests
sslt-cov - Run e2e tests in deterministic simulation mode and report code coverage
stest - Run unit tests in deterministic simulation mode

RiseDev - Java Binding
----------
build-java-binding-java - Build the java binding java code
build-java-binding-rust - Build the java binding rust code
gen-java-binding-header - Generate the java binding C header file
ingest-data-and-run-java-binding - Ingest test data and run java binding demo
kill-java-binding-demo-cluster - Kill the RisingWave cluster for java binding demo
run-java-binding-demo - Run the java binding demo
run-java-binding-stream-chunk-demo - Run the java binding stream chunk demo
start-java-binding-demo-cluster - Start the RisingWave cluster for java binding demo

RiseDev - SQLLogicTest
----------
docslt - Extract SQL examples written in SQLLogicTest syntax from Rust doc comments
slt - 🌟 Run SQLLogicTest
slt-all - Run all e2e tests
slt-batch - Run all batch e2e tests
slt-generated - Run all generated e2e tests
slt-streaming - Run all streaming e2e tests

RiseDev - Start/Stop
----------
ctl - Start RiseCtl
dev - 🌟 Start a full RisingWave dev cluster using risedev-dev [aliases: d]
down - Kill RisingWave dev cluster and clean the data
kill-risedev - Kill RisingWave dev cluster [aliases: k, kill]
playground - 🌟 Start a lite RisingWave playground using risingwave all-in-one binary [aliases: p]

RiseDev - Test
----------
apply-parser-test - Generate parser test data
compaction-test - Run hummock compaction e2e deterministic test
delete-range-test - Run hummock compaction delete-range for test
do-apply-parser-test - Apply parser test data
do-apply-planner-test - Apply planner test data [aliases: dapt]
do-apply-stream-integration-test - Apply stream integration test output snapshots. [aliases: dasit]
meta-backup-restore-test - Run meta backup/restore test
run-planner-test - Run planner test
test - 🌟 Run unit tests
test-cov - Run unit tests and report coverage

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

Documentation

[ ] My PR contains user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

@kwannoel Any idea about fuzz test time out?

@kwannoel Any idea about fuzz test time out?

I guess there will always be some tail cases which lead to timeout, lets say if every query has natural join. These should occur less often, but they will occur.
Also since we added updates and deletes, the runtime would have increased as well.
I have to look at the set of generated queries for those which take a long time, to know for sure and do some analysis.
For now it is sufficient to just increase the timeout for sqlsmith e2e random fuzz test in pull-request.yml, since we don't run it every PR, only PRs with changes to sqlsmith source files / sqlsmith ci scripts.


limited exception message length

in the RequestException, exception message is set to limit only 200 characters. is there anyway to allow the message length more than that?

I think this is just a limit set by Saloon, I'd be happy to accept a PR which increases this limit.

@lydenn Like Sam says, it's a limit in Saloon only (in the RequestException, like you said).
I don't think you can properly override the max body length property right now, unfortunately.
The way I've handled this is to create a custom Exception, and extend the RequestException, and in the constructor pass the message manually (to bypass this).
So something like this..
class MyRequestException extends \Saloon\Exceptions\Request\RequestException
{
    public function __construct(Response $response, ?string $message = null, int $code = 0, ?Throwable $previous = null)
    {
        $message ??= $response->body();

        parent::__construct($response, $message, $code, $previous);

        // Or to keep Saloons normal behaviour.
        // $this->maxBodyLength = mb_strlen($message ?? $response->body());
        //
        // parent::__construct($response, $message, $code, $previous);
    }
}

You will need to set your custom Exception, as shown here.
You don't necessarily need to extend the RequestException, but that's what I ended up doing.


Drive entries are now mobile friendly.

Moved the data column headers into the card so they can dynamically move with the size of the screen.

New vs. old comparison.


Full rewritte of external scanner

Simple grammar = maintainable grammar
This grammar has to be maintainable. To be maintainable, the grammar has to be simple.
One way to keep things simple is to do things naively. But a naive Typst grammar has terrible performances.
For instance, when inserting optional white spaces and comments every where it is allowed, it increases the parser size tremendously and clutters the grammar's readability.
We can use the builtin extra feature (making the given rules optional everywhere) but this is not possible as some rules have to be directly sequential, like a function call (foo() = foo ~ ( ), no space nor comment allowed.
External scanner
The external scanner can be used to implement a work around the previous problem. Moreover, to handle indentation, there is no other way than using the external scanner.
To sum up, the use of the external lexer is mandatory to enable some functionalities and prevent the parser from becoming too big by implementing shortcuts.
Full external scanning
In the current situation, some tokens are parsed by the external scanner and some tokens are parsed by the builtin scanner. To improve the situation, it would be better to only use the external scanner. But current external scanner has become too complex and prevents a full migration.
The new external scanner will have to be, at least partially, generated because some token, like builtin functions in Typst, have to be parsed through a switch subdivision (like ref and range):
switch (next) {
    case 'r':
    switch (next) {
        case 'e':
        ...
        break;
        case 'a':
        ...
        break;
    }
    break;
}

This can be achieved by producing a finite state machine from a given regex list, but it has to take in account that some token are not always valid.
Finite state machine with conflicting acceptation
Because in Typst there are different modes (text, code and math), some tokens are in collision. For instance, the input f would be accepted as plain text in text mode, as an identifier in code mode and as a letter in math mode.
If an automatic generation of a finite state machine is implemented, it has to take in account those collisions.
I will experiment and look for solutions. If anyone have an idea on how to do it and what kind of challenges does it lead to, you can share it here.

I thought about this and it could be a great way to simplify the parser, but there are several problems:

To have embedded code, a parent language has to be able to identify the character range of the embedded source by itself. With Typst, it would mean to determine in text mode, where an embedded code expression ends. To do so, you have to parse correctly the code. So it comes back to the original problem.
Most editors don't offer the same support, it gives to the main source, to the embedded language. For instance, in Helix, embedded code is highlighted, but text can't be selected following the hierarchy.

But I do believe that it is possible to identify in which mode we are when the external scanner is invoked. In my understanding, there are 5 different situations:

Error recovery. Which is when the parsing failed (invalid syntax) and Tree Sitter tries to recover by accepting any token and resume parsing.
Expression mode (or code mode). When an expression is valid next, any token starting an expression is accepted.
Math expression mode (or math mode). When a math expression is valid next, any token starting a math expression is accepted.
Text mode. When plain text is accepted.
Specific token. When a token, only valid in a single and specific situation has to be parsed.

And this is not even a perfect split, as some tokens are valid over different modes, and some, not even valid from time to time in a single mode. For instance, the comments and white spaces are always valid. And the =, as heading markup in text mode, is only valid at the beginning of a line or a container like strong or emphasis markups.

I am thinking about writing the scanner in Zig, because Zig code can be transpiled to C code, and as the external scanner interacts with the tree sitter parser, only through C abi, it should work. I'll make some test to check if it works and if it doesn't increase the size of the final parser, because generated C code from Zig contains lots of boilerplate code, which I hope gets optimized away.


Port to Bevy 0.13 (WIP)

Hey, thank you for your work! Do you happen to need a helping hand here? Some testing or anything similar?

Thanks for the offer. Testing is always welcome and let me know if you spot any issues. There are a few more things on my to-do list and I've been short of time, but I expect 0.7 will be released soon.

Yeah, been using it since that comment. Has been such a good experience.
I have a pretty small use case, so maybe it's not that much help. It's just a complex hierarchy that needs to be outlined starting from whatever entity I select and ending at the last children of that entity. It's been perfect!


Thread-safe CommandStream

Is your feature request related to a problem? Please describe.
I am developing a game with filament. I need to create entity in multi-thread enviroment
and render in main thread. But the following segment of code blocks:
filament/backend/include/private/backend/CommandStream.h
inline void* allocateCommand(size_t size) {
        assert_invariant(utils::ThreadUtils::isThisThread(mThreadId));
        return mCurrentBuffer.allocate(size);
    }

Describe the solution you'd like
Can we remove this assertion and make CommandStream thread safe?
Describe alternatives you've considered
No
OS and backend
MacOS

Making the command stream thread safe isn't enough, all Filament APIs would have to be thread safe but that's not something we plan on doing.

I don't think all the APIs should be thread-safe.
I think making all the ::build() and ::destroy() APIs thread-safe is enough.

I don't think it would make sense for only some APIs to be thread-safe. It might be convenient for your use case, but it wouldn't be very consistent in terms of APIs. In addition this would require quite a bit of the internals to become thread-safe.

@romainguy If there is no plan for thread-safe API. Would it be better to remove this assertion. I can add mutex in my app but this line of code assert the thread-id, which blocks multi-thread env.


lfs: init at 1.0.0

Motivation for this change
Package lfs program.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 141178 run on x86_64-linux 1

1 package built:

lfs


I am getting issue in pdf pre-flight validation status is verification is failed and PDF/A-2b pre-flight validation is also failed its showing error like character reference .notdef glyph (1 match 1 page)

Link to PDF file (or attach file here):
Configuration:

Web browser and its version: Adobe DC

Operating system and its version: windows 10

PDF.js version: PDF/A-2b

Is an extension:PDF

Steps to reproduce the problem:

Scan a copy and select file type as PDF/A
2.Open the PDF file Adobe DC and perform validation in Preflight

What is the expected behavior? (add screenshot)
I have attached screen shot
What went wrong? (add screenshot)
validation is failed
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

There's nothing that indicates that this is an issue with the PDF.js library, since the (very) limited information provided only refers to "Adobe DC" and there's no PDF file provided either.
Closing as invalid, and incomplete.


Merge dissertation, locationOfOriginal, citeAs fields into notes field

Resolves wellcometrust/platform#3996
Resolves wellcometrust/platform#3998

Looking at  this file here, it appears like all subfields will be created as seperate notes,
Is that what we want, for all these fields?

@jamieparkinson looks like we have an issue here:
https://travis-ci.org/wellcometrust/catalogue/jobs/604444535#L503

On @warrd's comment - @jtweed
[{
  "content": "Wellcome Library;",
  "type": "LocationOfOriginalNote"
},
{
  "content": "GB.",
  "type": "LocationOfOriginalNote"
}]

Would then be serialised as:
[{
  "contents": ["Wellcome Library;", "GB."],
  "noteType": { /*...*/ }
}]

This is the way we're treating all notes, we could however add a label which would be Wellcome Library;GB. for https://search.wellcomelibrary.org/iii/encore/record/C__Rb1879996?marcData=Y

I think we probably want to join subfields with spaces, but create multiple entries in contents for repeated fields?


pypi package broken

the pypi package don't contains the folder parsers and templates

Yes, looks like the wheel is FUBAR.


Spelling - Chapter 1 Line 18

"Period" is spelt "Periodt."

Thanks for opening an issue, @EthanHoward! That spelling is actually intentional and is part of the Gen Z theme 😄


FDC3 Survey Links

Adding FDC3 Survey Links in Marquee and temp using FeatureCallout for Survey (Hid Use Cases Temporarily)

@grizzwolf @rikoe @donbasuno
I created an alternate CTA layout here:  https://github.com/FDC3/FDC3/pull/136

Here's how this looks on my laptop after this PR was approved.


Add prerequisites for practice exercises

This aims to add prerequisites for some exercises in https://github.com/exercism/javascript/issues/984

@TomPradat can you also increase the difficulty? Feel free to merge if you can, or ping me and I will.

Done @SleeplessByte ! I cannot merge on my own though


az network bastion rdp fails: ImportError: cannot import name 'WinDLL' from 'ctypes'

This is autogenerated. Please review and update as needed.
Unable to use az network bastion rdp to connect to vmss instance
Command Name
az network bastion rdp
Errors:
The command failed with an unexpected error. Here is the traceback:
cannot import name 'WinDLL' from 'ctypes' (/opt/az/lib/python3.10/ctypes/__init__.py)
Traceback (most recent call last):
  File "/opt/az/lib/python3.10/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 663, in execute
    raise ex
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 697, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 333, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/network/custom.py", line 8457, in rdp_bastion_host
    from ._process_helper import launch_and_wait
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/network/_process_helper.py", line 9, in <module>
    from ctypes import WinDLL, c_int, c_size_t, Structure, WinError, sizeof, pointer
ImportError: cannot import name 'WinDLL' from 'ctypes' (/opt/az/lib/python3.10/ctypes/__init__.py)

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az network bastion rdp --name {} --resource-group {} --target-resource-id {}

Expected Behavior
Environment Summary
Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.31, Ubuntu 20.04.4 LTS
Python 3.10.5
Installer: DEB

azure-cli 2.38.0

Extensions:
account 0.2.3

Dependencies:
msal 1.18.0b1
azure-mgmt-resource 21.1.0b1

Additional Context

route to CXP team

Also getting issues with  az network bastion tunnel and az network bastion ssh.
Both resulting in the same error:
Exception in thread Thread-1 (_start_tunnel):
Traceback (most recent call last):
File "threading.py", line 1016, in _bootstrap_inner
File "threading.py", line 953, in run
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/network/custom.py", line 8535, in _start_tunnel
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/network/tunnel.py", line 184, in start_server
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/network/tunnel.py", line 117, in _listen
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/network/tunnel.py", line 104, in _get_auth_token
msrestazure.azure_exceptions.CloudError: java.lang.IllegalArgumentException: Invalid vmss instance format /subscriptions/SUB/resourceGroups/lovigano-bastion1/providers/Microsoft.Compute/virtualMachineScaleSets/gmcl-nr3j
Should be noted that the bastion DOES work through the browser. just not powershell nor wsl2

@lovigano i see a typo in "virtualMachines"

@lovigano Apologies for the late reply. Thanks for reaching out to us and reporting this issue. Could you please confirm if you are running this from a cloudshell ? If Yes, it wont be able to open the RDP on your local machine. For this reason, we recommend using powershell with az cli (on Windows machine).
Also, note that RDP command works best on Windows, for other OS’ (like Linux) you can do the tunnel command and then use the client of your choice.

Connect to a VM using the az network bastion tunnel command. This lets you do the following:

Use native clients on non-Windows local computers (example: a Linux PC).
Use the native client of your choice. (This includes the Windows native client.)
Connect using SSH or RDP.
Set up concurrent VM sessions with Bastion.
Upload files to your target VM from your local computer. File download from the target VM to the local client is currently not supported for this command.

Currently, this feature has the following limitation:
Signing in using an SSH private key stored in Azure Key Vault isn’t supported with this feature. Before signing in to your Linux VM using an SSH key pair, download your private key to a file on your local machine.

Hope this helps.

@navba-MSFT i'm getting the same error running from az cli on Windows.
here's the details bug report:
This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az network bastion rdp
Errors:
The command failed with an unexpected error. Here is the traceback:
cannot import name 'WinDLL' from 'ctypes' (/opt/az/lib/python3.10/ctypes/__init__.py)
Traceback (most recent call last):
  File "/opt/az/lib/python3.10/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 663, in execute
    raise ex
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 697, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 333, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/network/custom.py", line 8457, in rdp_bastion_host
    from ._process_helper import launch_and_wait
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/network/_process_helper.py", line 9, in <module>
    from ctypes import WinDLL, c_int, c_size_t, Structure, WinError, sizeof, pointer
ImportError: cannot import name 'WinDLL' from 'ctypes' (/opt/az/lib/python3.10/ctypes/__init__.py)

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az network bastion rdp --name {} --resource-group {} --target-resource-id {}

Expected Behavior
Environment Summary
Linux-5.4.0-1086-azure-x86_64-with-glibc2.28 (Cloud Shell), Common Base Linux Delridge (quinault)
Python 3.10.5
Installer: DEB

azure-cli 2.38.0

Extensions:
ai-examples 0.2.5
ssh 1.1.2

Dependencies:
msal 1.18.0b1
azure-mgmt-resource 21.1.0b1

Additional Context

@lovigano I wanted to do quick follow-up to check if you had a chance to look at my above comment. Please let us know if you need any further assistance on this. Awaiting your reply.

@lovigano The action is currently pending on you to test on powershell with az cli (on Windows machine). We will now proceed with closure of this GitHub issue. If you need any further assistance on this issue in future, please feel free to reopen this thread. We would be happy to help.

I have linked all related issues to this one as a main tracker.
az network bastion rdp is now from bastion extension. It unconditionally imports ctypes.WinDLL regardless of the operating system:
https://github.com/Azure/azure-cli-extensions/blob/b293d7e9d91b6a97d958a424d136befb7a7f6d28/src/bastion/azext_bastion/_process_helper.py#L9
from ctypes import WinDLL, c_int, c_size_t, Structure, WinError, sizeof, pointer

According to https://docs.python.org/3/library/ctypes.html#ctypes.WinDLL, ctypes.WinDLL is Windows only.
This command should give a better error message stating az network bastion rdp is only supported on Windows. It can detect the operating system with sys.platform. For example:
https://github.com/Azure/azure-cli/blob/fb805f4bb3167623107c10ec5f34581a838c8a1c/src/azure-cli-core/azure/cli/core/auth/persistence.py#L41-L50

resolved this by installing the full AZ CLI  and NOT using the azure cloud shell connector in Windows 11 Terminal (which seems to be AZ ClI lite).
Once downloaded and installed the full AZ CLI client on my windows 11 machine, I restarted Windows Terminal (PowerShell windows), and logged into AZ using the following and rdp opened up via the bastion.
az login

az account set --subscription "<sub-id>"

az network bastion rdp .......


Select form gets sluggish and not responsive

I have raised this issue in more details here. The dropdown list shows with no problem. Once an item is selected, the whole menu gets sluggish and not responsive unless page is refreshed.
Any idea?

Can you create a reproduction?

yes!

Duplicate of #5113
(I assume for lack of other information)


🗒 Create a GitHub Workflow that Runs on a Manual Trigger to Generate List of Removable Users

User Need
As a Ops Eng
I want to create a GH Workflow that will generate the dormant users list
so that the whole team can run the process.
Value
We can trigger the process whenever we want.
Functional Requirements (What):

[x] Create a GH Workflow of operation-engineering repository

Non-Functional Requirements (How):

[ ] needs workflow dispatch
[x] no PII printed to the screen
[x] print output to slack

Acceptance Criteria:

[ ] We can trigger the process manually via a GH Action

Notes:

https://github.com/ministryofjustice/operations-engineering/pull/4798

The new action takes approximately 1m43s to complete.
https://github.com/ministryofjustice/operations-engineering/actions/runs/10699994170/job/29662759239


Doesn't lint for ruby

linter correctly lints all other languages except ruby where it does nothing. (on OSX yosemite)

My sense of debugging says that it's because ruby linter hasn't upgraded to the latest API and that API has been removed after the 1.3.0 upgrade, If you want to revert to the older linter do apm install<EMAIL_ADDRESS>

Funny you should mention Ruby. Rewriting it with ES6 is on my code to do list next.

@steelbrain
Your debugging sense was spot on. Reverting to linter 1.2.4 solved the issue!
Many many thanks!

AtomLinter/linter-ruby#21


Only seems to attack 3 IPs

With -i 0 flag on launch, the only IPs visible in the log are
[DEBUG] <IP_ADDRESS>:53 started at XYZ
[DEBUG] <IP_ADDRESS>:53 started at XYZ
[DEBUG] <IP_ADDRESS>:53 started at XYZ
No other targets are visible
Sometimes there are fail messages like
[DEBUG] GET https://bezformata.com/ failed at<PHONE_NUMBER> with code 403
With only 3 targets working out of 59, it doesn't seem to be effective

My output looks different, but I can also see only one IP (<IP_ADDRESS>)

@alextatarinov @arthur2406 @bunge12 you're using a mode that only shows important logs, the IP there is from one of the experimental jobs that doesn't respect that (and there's already a bit more effective job with the same functionality, we just didn't get to reconfiguring that target yet). If you want to see all the info - add -l 0 to the commandline arguments to enable debug logging (but be careful, there's a lot of it)
@WeGoToMars since you were using debug logs already, can you check it out with the latest version and provide a full log of an app running for at least a minute?

@Arriven downloaded latest build for amd64, running on win11
here is a piece of the log I'm seeing https://pastebin.com/raKTKG8n, it's not a full minute because pastebin has limit for free users, but it really stays the same.
On a side note, there seems to be some kind of an error with calculating the speed, it seems to drift upwards but network activity in task manager never changes (~2.5 mbps up/~4.5 mbps down).

My results:
docker run --rm -it ghcr.io/arriven/db1000n:latest

@WeGoToMars the log you provided this time also doesn't seem to include debug logs :)
The main reason network usage drifts up and down here is that the job outputting it's IP doesn't contribute to the overall metrics (it's simply an integrated module and will be replaced by other, more effective job). You can try out the backup config embedded into the app (it uses latest features) in the latest release by providing an invalid url for the main config (for example run it with -c https://blah). Coordinators will soon update the default remote config to use latest features but it's already effective as is

@Arriven -c httpsL//blah completely fixed the issue for me, it now works on multiple IPs and shows logs correctly. Thanks!

@WeGoToMars cool, but please check https://github.com/db1000n-coordinators/LoadTestConfig and remove that commandline argument as soon as activity starts there to keep being up to date with current targets (I've almost finished instructing admins on how to manage it so it should become active very soon)

@Arriven db1000n.exe -c https://github.com/db1000n-coordinators/LoadTestConfig/blob/main/config.json seems to work now
Without any arguments, the logging works differently(?)
db1000n.exe -c https://github.com/db1000n-coordinators/LoadTestConfig/blob/main/config.json:
[INFO] Attacking https://lenta.ru/
[INFO] Attacking https://lenta.ru/login
...
db1000n.exe:
[INFO] Атака проводиться успішно! Руський воєнний корабль іди нахуй!
[INFO] The app is generating approximately 34394 bytes per second
It prints this stat every minute, and it would be great if it could be more frequent (once every 1-10s)
db1000n.exe -l 0 shows attacks on all 6 targets outlined in the LoadTestConfig/main/config.json


Short lived jobs

This PR solves some problems:

Improves queueing by doing only one page of results at a time and then putting a new job at the end of the queue if there are more pages. Closes https://github.com/github/ecosystem-integrations/issues/194
Sends the migrate event correctly to event, not assuming that the commits queue is the last one and not assuming when one repo is done, everything is done.
Parses PR bodies. Closes https://github.com/integrations/jira/issues/120 and https://github.com/integrations/jira/issues/119
Adds more logging. See https://github.com/github/ecosystem-integrations/issues/193

@gimenete Take a look at the changes I added in 3ab5c87. We don't really need to retry a bunch of times, so instead I just threw a try/catch around the function that gets each content type. If it fails to get per_page: 100, it falls back to trying per_page: 50 for each job. Since we're doing one page per job, this feels like a pretty simple solution. If it fails to get per_page: 50, it's likely there's some other error that can't be resolved by retrying anyway.
I'm getting some inconsistent results, though. Try syncing the integrations org against your test instance. About 2/3 of the time when I run the sync, it finishes all the pages but never goes from "active" to "complete" because a couple of the repos still show pending. The other 1/3 of the time it completes the sync with no issues, so I think something is off about how we're updating repoSyncState. I've looked at it a few ways but couldn't put my finger on what's causing it.

To follow up, 5720e40 fixes the issue with some jobs never signaling they were complete. We were running into race conditions where the subscription object we were passing around between jobs had stale data, so the jobs would complete, but the repoSyncState object would be in an older state with jobs in pending status. The update ensures we get the most current state from the database before pushing another update.
I also noticed a couple of situations where we weren't sending avatarUrl everywhere, so a fresh sync wouldn't display an avatar for a commit that was previously pushed.

@gimenete I added a few things to how the jobs are getting re-triggered. Mainly just verifying it's coming from an admin of the Jira instance by vaildating the JWT and adding csrf protection like our other POST routes. I verified everything looks good in staging. Feel free to deploy this prod.


[tiny-process-library] Bump tiny-process-library to 2.0.4

Describe the pull request

What does your PR fix? This PR updates the tiny-process-library to the 2.0.3

Which triplets are supported/not supported? Have you updated the CI baseline? The baseline should not be affected.

Does your PR follow the maintainer guide? Yes

@traversaro, thanks for the PR!
Here is CI testing results, could you please take a look?
x86-windows/x64-windows/arm64-windows/
LINK : fatal error LNK1104: cannot open file 'tiny-process-library.lib'

failure logs for x64-windows (1).zip
x64-windows-static/x64-linux
-- Configuring x64-windows-static
-- Building x64-windows-static-dbg
-- Building x64-windows-static-rel
CMake Error at scripts/cmake/vcpkg_fixup_cmake_targets.cmake:73 (message):
  'D:/packages/tiny-process-library_x64-windows-static/debug/lib/cmake/tiny-process-library'
  does not exist.
Call Stack (most recent call first):
  ports/tiny-process-library/portfile.cmake:21 (vcpkg_fixup_cmake_targets)
  scripts/ports.cmake:136 (include)

Error: Building package tiny-process-library:x64-windows-static failed with: BUILD_FAILED

@traversaro, thanks for the PR!

Thanks for the comment @PhoebeHui  ! I fixed all the problems, and now the port should work fine, I am not sure what happened to the CI jobs that staled.

fyi @j-rivero, if you want to include tiny-process-library in the Gazebo vcpkg dependencies for compiling the Gazebo , after this PR  the version that exports the correct CMake imported target is available in vpckg.

And thanks a lot @PhoebeHui and @strega-nil  for reviewing and merging this!

fyi @j-rivero, if you want to include tiny-process-library in the Gazebo vcpkg dependencies for compiling the Gazebo main command on Windows, after this PR the version that exports the correct CMake imported target is available in vpckg.

Thanks Silvio. Gazebo classic is not using dependencies from vcpkg in our CI, something I will need to fix or change at some point.


Prevent cleaning of development database

Opened this PR a few weeks ago to generalize ProductionEnv safeguard to prevent clearing of a development database:
https://github.com/DatabaseCleaner/database_cleaner/pull/703
Did not see any comments on the PR so thought I'd open an issue to get some visibility. Thanks!

@cherbst-2112 Thanks for the ping! I just commented on #703


Add convenience update & install flags

May be add convenience flags:

add -i (--install) flag in update command; this would install the latest distribution version after the update is performed
add -u (--update) flag in install command; this would update the distribution list before installing the version( latest of specified one)

We could do things like binenv install terraform -u instead of binenv update terraform && binenv install terraform.
This could be nice, but could also make the tool a bit confusing just to save some keystrokes.

Makes the CLI usage too complex. It's just 2 commands, no need to over engineer this thing.


[gql-tag-operations] useFragment cannot take nullable as an argument

Is your feature request related to a problem? Please describe.

GraphQL client libraries used in React may return null in results (e.g., Apollo's useQuery).
However, the useFragment generated by gql-tag-operations-preset is not usable since it cannot take null or undefined as an argument.
const query = gql(`#graphql
  query GetDashboardPage {
  # ...
  }
`);

function Dashboard() {
  const { data } = useQuery(query);

  // data cannot be passed to useFragment because it is `T | undefined`
  // const postListFragment = useFragment(PostList.fragment, data);

  if (data != null) {
     return null
  }

  // return <PostList fragment={postListFragment} />
  return <_Dashboard data={data} />
}

// Component for masking data that is guaranteed not to be null with fragment
function _Dashboard(data) {
  const postListFragment = useFragment(PostList.fragment, data);

  return <PostList fragment={postListFragment} />
}

Describe the solution you'd like
If useFragment could take null or undefined arguments, the above code could be written very concisely with only one component.
const query = gql(`#graphql
  query GetDashboardPage {
  # ...
  }
`);

function Dashboard() {
  const { data } = useQuery(query);
  const postListFragment = useFragment(PostList.fragment, data);

  if (data != null) {
     return null
  }

  return <PostList fragment={postListFragment} />
}

cf. https://github.com/DefinitelyTyped/DefinitelyTyped/blob/7b6642aefa0d21f77f5d6b610f69dade4eb8df64/types/react-relay/relay-hooks/useFragment.d.ts#L5-L30


RichTextLabel focus stylebox visible below other elements when used with HSplit

Tested versions

Reproducible in 4.2.1 stable, 4.1.1 stable, 4.0.3 stable
Not reproducible in 3.5.3 stable

System information
Windows 10.0.19045 - Vulkan (Compatibility and Forward+) - AMD Radeon R7 Graphics
Issue description
The RichTextLabel focus stylebox is visible through other elements, when its used in combination with HSplitContainer.
https://github.com/godotengine/godot/assets/142301391/3e3cf3c4-98da-436e-9abf-9d6c5e11c3a2
Steps to reproduce

Add a HSplitContainer
On one side, add a RichTextLabel with focus mode all or selection enabled

Place it inside a scroll container and give it minimum size, so it can go below the other side

On the other side, add a panel with transparency
Run project, move the split so that the RichTextLabel is halfway under the other side, then click on the RichTextLabel to make the focus stylebox visible

Minimal reproduction project (MRP)
richtextlable_mrp.zip

I have found the reason. Its for some reason ignoring clipping, I dont know why it is needed and i also dont know if just removing the clip ignore would fix it.
https://github.com/godotengine/godot/blob/bf8dd73e9d88d6ab146506699f43230b12c6a2b0/scene/gui/rich_text_label.cpp#L1902-L1906
This same code is applied in Tree and ItemList, and after testing i have found that both of these also have the same problem.
https://github.com/godotengine/godot/blob/bf8dd73e9d88d6ab146506699f43230b12c6a2b0/scene/gui/tree.cpp#L4249-L4252
https://github.com/godotengine/godot/blob/bf8dd73e9d88d6ab146506699f43230b12c6a2b0/scene/gui/item_list.cpp#L1042-L1046

https://github.com/godotengine/godot/assets/142301391/8bf73240-15ee-4b88-95ce-7a24cd999213


xtrace: 1.3.1 -> 1.4.0

Motivation for this change
This one could not be updated automatically anymore. The source
repository has changed.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

This pull request has been mentioned on Nix community. There might be relevant details there:
https://discourse.nixos.org/t/nixpkgs-update-r-ryantm-logs/1464/28

@grahamcofborg build xtrace


Search

I’d love to see a simple (maybe serverless) search for tweet content.

A very low-hanging option for this is using a package that generates a static search index. Within a few minutes I had managed to set up Pagefind https://github.com/cloudcannon/pagefind on my archive to search all tweets: https://twitter.alistairshepherd.uk/search/
It runs on the eleventy.after event and generates a static index by crawling the pages in the output directory, and includes a relatively small library and UI component to output the results.
It certainly isn't an ideal solution as it runs the search locally therefore requiring a decent amount of JS and not having a server-side fallback, but on the other hand doesn't rely on serverless routes making hosting a bit easier.
I'd be keen to hear thoughts on this solution, and happy to put together a PR based on my implementation of pagefind if it's wanted.

@Accudio it works great! 👍
I like that Pagefind’s search index is split into chunks, as other similar solutions generate one single very big file, which would not work well with my ~120.000 tweets… 😅
I think a PR for this would be great!

I've added a basic Pagefind implemention in PR #27 although we may want to do a bit more with it including a custom search component!

Done in #27, thanks @Accudio ! 🙏


What is the status of this library?

Is it recommended for production usage?

@ygyg70 Yes, we're using it in production across several hundreds of lambdas.


Update index.js

@athibaud Can you take a look at this. I removed the filter on type of 'function' (see my comment on your last PR). And I also found another bug. When running the cacheClean method at startup we also set up the Observer of library changes. This actually triggered the user gran-access dialog. So we clean the cache the first time anyone tries to run a function instead now. And we exclude auth-status-functions from this cleanCache-logic so that the user of the API can decide for them selfs when to trigger the dialog.

indeed i noticed the grant dialog appeared on app startup but didn't realise cleanCache was responsible, thanks!
the code looks good to me. just tested in our app, seems to work fine.

A future improvement would be to not set up the observation until the user explicitly is trying to watch a collection or assets. will take a look at that at a later point.

yes this would be much better, and correct. our app crashes sometimes and haven't looked into the causes yet.. but having a change observer setup could be one of them.
not sure yet if we'll have the time to delve into this in the coming weeks but please let us know if there is anything we can do :)

@athibaud I'll look into it asap. A crash does not seem good.. hmm.. please send me the stacktrace/try to create a repro if it happens again. Haven't had one single crash myself that was from the library code, so I'm very interested. Might be some configuration I haven't tried. Note: I have only ran this code on iOS 10. will do some testing on 8 and 9.

@olofd we have no proof that the crash is caused by this module :) and if we ever find out that it is indeed, we will report it and do our best to fix it too, you can be sure of that ;)
all i'm saying is setting up an unnecessary change-observer could contribute to the crashing. so setting up that observer only when needed would be good future change indeed! :)
we have ios9 devices and we'll report/fix issues we encounter. cannot help for ios8 though :/
thanks again for the hard work! extremely appreciated!


Missing pre-trained ckpt of MSN-Hard

Hi thanks for the great work!
It seems the pre-trained checkpoint of MSN-Hard is missing.

Hi,
Due to our circumstances, it is taking some time to prepare the pre-trained models.  I will let you know here when it's done.