update type checking to deal with unsup transformers with target

Updates for type checking when dealing with an unsupervised transformer that relies on a target (a la https://scikit-learn.org/stable/modules/generated/sklearn.feature_selection.SelectKBest.html#sklearn.feature_selection.SelectKBest)

Codecov Report

Merging #705 (ac4c171) into dev (5d8c78c) will decrease coverage by 2.74%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##              dev     #705      +/-   ##
==========================================
- Coverage   86.53%   83.78%   -2.75%
==========================================
  Files          36       36
  Lines        3401     2905     -496
==========================================
- Hits         2943     2434     -509
- Misses        458      471      +13

Impacted Files
Coverage Δ

src/machines.jl
80.72% <75.00%> (-3.30%)
:arrow_down:

src/sources.jl
70.00% <0.00%> (-18.00%)
:arrow_down:

src/composition/models/transformed_target_model.jl
85.45% <0.00%> (-14.55%)
:arrow_down:

src/data/datasets.jl
86.84% <0.00%> (-13.16%)
:arrow_down:

src/measures/continuous.jl
89.13% <0.00%> (-7.17%)
:arrow_down:

src/show.jl
29.92% <0.00%> (-7.12%)
:arrow_down:

src/measures/measures.jl
64.63% <0.00%> (-6.24%)
:arrow_down:

src/measures/probabilistic.jl
58.46% <0.00%> (-4.70%)
:arrow_down:

src/operations.jl
76.19% <0.00%> (-4.58%)
:arrow_down:

src/interface/data_utils.jl
88.88% <0.00%> (-4.45%)
:arrow_down:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8c78c...ac4c171. Read the comment docs.

Codecov Report

Merging #705 (ac4c171) into dev (5d8c78c) will decrease coverage by 2.74%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##              dev     #705      +/-   ##
==========================================
- Coverage   86.53%   83.78%   -2.75%
==========================================
  Files          36       36
  Lines        3401     2905     -496
==========================================
- Hits         2943     2434     -509
- Misses        458      471      +13

Impacted Files
Coverage Δ

src/machines.jl
80.72% <75.00%> (-3.30%)
:arrow_down:

src/sources.jl
70.00% <0.00%> (-18.00%)
:arrow_down:

src/composition/models/transformed_target_model.jl
85.45% <0.00%> (-14.55%)
:arrow_down:

src/data/datasets.jl
86.84% <0.00%> (-13.16%)
:arrow_down:

src/measures/continuous.jl
89.13% <0.00%> (-7.17%)
:arrow_down:

src/show.jl
29.92% <0.00%> (-7.12%)
:arrow_down:

src/measures/measures.jl
64.63% <0.00%> (-6.24%)
:arrow_down:

src/measures/probabilistic.jl
58.46% <0.00%> (-4.70%)
:arrow_down:

src/operations.jl
76.19% <0.00%> (-4.58%)
:arrow_down:

src/interface/data_utils.jl
88.88% <0.00%> (-4.45%)
:arrow_down:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8c78c...ac4c171. Read the comment docs.


Please remove this repo, create a fork instead

@Ggoals -- please remove this repo "Ggoals/spark2.2_custom".
If you want to make code changes, please fork the original repository "apache/spark" and create a custom branch. If any of your changes should be put into the original "apache/spark" repo you can then create a pull request.
I'm not sure if there may be legal issues with you hosting a copy of "apache/spark" under your user id, but you do throw off everyones GitHub contribution statistics with your copy!

Nevermind, there are about a 110 more copies of the Spark repository all over GitHub :(


LLVM 14 is not installed om macos-12

Description
According to the readme at images/macos/macos-12-Readme.md LLVM 14 should be installed on macos-12 runners, it is not though.
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[X] macOS 12
[ ] macOS 13
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
macos-12
Is it regression?
IDK
Expected behavior
Either the readme should not say it is installed, or the runner should have it installed.
Actual behavior
Not installed.
Repro steps
Try using llvm 14 in a macos-12 runner. For example brew list | grep llvm

Hello! The docs are correct, llvm 14 does not come with brew but with xcode installed in the image and is also pinned to the clang version from Xcode


play-api.md modified to aid users new to postman

This Pull Request modifies play-api.md by including additional descriptive steps to aid users new to postman

@derberg Glad to be able to contribute to this


rename 'master' to 'main'

Is your feature request related to a problem? Please describe.
https://github.com/Project-MONAI/tutorials/issues/717

fixed in https://github.com/Project-MONAI/research-contributions/pull/52, please feel free to create new tickets for any relevant issues.


Update Ruby

Bump Ruby to 3.0 release.
Add dependabot config to update Gems.

Signed-off-by: SuperQ<EMAIL_ADDRESS>

Thanks!


Add "maybe" commands

Sometimes it is not possible to determine the remote state during the fact gathering phase, which leads to the interdependent operations issue. As a workaround pyinfra already uses quick scripts to dynamically handle such situations in some cases:

https://github.com/Fizzadar/pyinfra/blob/master/pyinfra/operations/init.py#L27
https://github.com/Fizzadar/pyinfra/blob/master/pyinfra/operations/files.py#L276

A "maybe" command would behave the same but be flagged as "might run" in the proposed changes after fact gathering. This logic could then be applied to the files.[line|directory|file] operations to remove/replace the assume_present argument, which is a far greater user experience.
There are not many operations affected by this issue anymore, and this should remove the issue entirely from the users perspective.

v3 implements this properly "maybe will change" operations and indicated in the pre-apply changes output.


Rule: Detect base path property is not used

Introduce a new rule which detects if a base path can be extracted out of all resource names. If all paths have same path prefix, a could violation should be created.

@netme Can also be a hint rule... ;)

@fmueller actually yes, can be a nice first example.

I saw this issue during an API review I did where team missed using basePath property which cause some other violations.

Current status: server part is implemented in #146, CLI should be adjusted.

Closing this one since I've found a special ticket for CLI: #90


Sync email changes to processor

This should sync the local email changes to the payment processor if the user who's email got updated has any subscriptions.
@excid3 not sure if we want to do this in a background job instead?

Great idea! Been struggling a little with the lifetime of changes and what is/isn’t kept once you’re not subbed anymore :)

On Dec 26, 2018, at 9:53 AM, Chris Oliver<EMAIL_ADDRESS>wrote:
@excid3 requested changes on this pull request.
In lib/pay/billable.rb:

@@ -83,6 +85,12 @@ def upcoming_invoice

 private

def update_processor_email

 if saved_change_to_email? && subscriptions.any?

I think we can swap the subscriptions.any? with processor_id? that way it updates them even if they don't have a subscription, but may have previously.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


1553 read only rhs toast on checklist

Summary
This PR adds toast when a channel member with read-only access to the run tries to change the checklist state.
https://user-images.githubusercontent.com/4368372/200803827-ff705ebd-d090-4ecd-bf88-be2ee675e828.mp4
Ticket Link
https://github.com/mattermost/mattermost-plugin-playbooks/issues/1553
Checklist

- [ ] Telemetry updated
- [ ] Gated by experimental feature flag
- [ ] Unit tests updated

it's triggering the toast when the run is finished, shouldn't be completely disabled in that case?


PowerToys run smooth scrolling

Description of the new feature / enhancement
smooth scrolling for PowerToys run
Scenario when this would be used?
when scrolling
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/5088


Template app uses XIB for launch screen, needs to be Storyboard (new App Store guidelines)

Description
Received this from Apple: "Apps for iPhone or iPad must be built with the iOS 13 SDK or later and use an Xcode storyboard to provide the app’s launch screen." (my emphasis)
Currently the template app uses LaunchScreen.xib.
My interpretation is that the XIB file needs to be changed to a Storyboard in order to be accepted by Apple's review.
React Native version:
info Fetching system and libraries information...
System:
    OS: macOS 10.15.3
    CPU: (4) x64 Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
    Memory: 837.37 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 10.16.3 - ~/.nvm/versions/node/v10.16.3/bin/node
    Yarn: 1.17.0 - /usr/local/bin/yarn
    npm: 6.9.0 - ~/.nvm/versions/node/v10.16.3/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.8.4 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
    Android SDK: Not Found
  IDEs:
    Android Studio: 3.6 AI-192.7<IP_ADDRESS>41897
    Xcode: 11.3.1/11C504 - /usr/bin/xcodebuild
  Languages:
    Java: javac 12 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.11.0 => 16.11.0
    react-native: 0.62.1 => 0.62.1
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce

Create new app (npx react-native init AwesomeProject)
Check that it includes LaunchScreen.xib (ls AwesomeProject/ios/AwesomeProject/Base.lproj/LaunchScreen.xib)

Expected Results
I expect the project to use a storyboard launch screen instead of a XIB. So that I can submit my app to the App Store and go through their review.

A PR is already in place for addressing this https://github.com/facebook/react-native/pull/28239

When will version 63.0 be released? The new apple guidelines need to be implemented before July 1st, but the latest released react native version still contains .xib Launch screen


wave file

I cannot create a wave file  I have tried everything,,  when I hit create it create a tiny wave  file that does not work, is this a bug?  I am on OS X  I try in serria and Catalina, thank you

I'm seeing the same thing the .wav file is 44 bytes. I tried with quite big / long samples that I wanted to combine and add slices. I noticed that I couldn't preview the long samples but if I added a clap or short sample I could preview it and the wav file increases. Feels like its choking on the larger ones and unable to add them. I'm on OSX Mojave btw

I think its https://github.com/KaiDrange/OctaChainer/issues/8#issue-398463435 will have a play around and report back

Yep it was spaces in my files - ableton 10 adds datetime stamp at the end of consolidated wavs with spaces...

I was not able to reproduce the issue, so either this was already fixed when I tested, or perhaps the datetime stamp had some other character or white space that caused a problem? I changed how file names are handled in v1.3.1. If the root cause for the issue was the file names, it is most likely not an issue any more. I'll keep this issue open so that I remember to take a second look, just in case.
There is currently no error handling on file IO at all. That needs to be improved so that reporting and fixing these kinds of errors will be easier.


Sema: Go back to synthesizing hashValue on _StoredBridgedNSError conformers

Commit e0bba70 added a default implementation, however this is wrong
for non-imported types.
Instead, synthesize the body as before. Since this is one of the few
derived methods that can appear on an imported type, make sure to
build fully type-checked AST.
Fixes rdar://problem/51322302.

@swift-ci Please smoke test

You're not supposed to use that protocol with non-imported types.

We have CocoaError, URLError, POSIXError and MachError conforming to it in Foundation.

Okay, but that's because those are emulating imported types, and I wouldn't expect their hash(into:) or == to be out of sync anyway. Can we just add manual implementations to those?

Yep, we can do that. I'm perfectly okay with either solution.

Please revert this, then, @slavapestov.


Dropdown: onMouseDown should be given undefined, not false, when disabled

Issue
On React Toolbox 2.0.0-beta.13, console prints an error when an option in the Dropdown is disabled:
Warning: Expected `onMouseDown` listener to be a function, instead got `false`.

If you used to conditionally omit it with onMouseDown={condition && value}, pass onMouseDown={condition ? value : undefined} instead.

Code
import Dropdown from 'react-toolbox/lib/dropdown/Dropdown';

...

let newLocationOptions = [{
  value: "initial", label: "Select a Location", disabled: true
},{
  value: "add-new-location", label: "Add New Location"
},{
  value: "empty", label: "Your Locations:", disabled: true
}]

...

<Dropdown
  key={selectedLocation}
  auto={false}
  label="Event Location"
  onChange={this.locationChangeHandler}
  source={newLocationOptions}
  value={selectedLocation}
  required={true}
/>

Fix
In /components/dropdown/Dropdown.js, change
onMouseDown={!item.disabled && this.handleSelect.bind(this, item[valueKey])}

to
onMouseDown={item.disabled ? undefined : this.handleSelect.bind(this, item[valueKey])}

Same issue here. Have you found any temp workaround perchance, @k3ntako ?


Implement Clear filters feature

Add Clear button to the filters Dropdown, which resets the filters and close the Dropdown.

I updated the code to reflect your suggestion :)


API: Rename scipy.fft DCT/DST shape argument to s

What does this implement/fix?
The shape parameter for the n-dimensional DCT and DST functions are renamed s.
Additional information
This was an oversight in the API for scipy.fft. As you can see from the docs, every function under the "FFTs" section uses s rather than shape. This is done for consistency with the numpy.fft API.
While this does hurt compatability with scipy.fftpack, it also makes the interface for scipy.fft more consistent.

I am +1 on this for consistency.
If this is merged, then I suppose #10507 will need to be updated accordingly.

If this is merged, then I suppose #10507 will need to be updated accordingly.

That should be fine actually. In #10507 scipy.fftpack calls _pocketfft directly which isn't changed here.

Agreed the consistency is good, thanks @peterbell10


) optparse.OptionConflictError: option -C/--no-color: conflicting option string(s): --no-color

I used django==1.7 for my project. And now I upgraded my django version to 1.8. I am getting an error while running the following command.
python manage.py celerycam
Output:
Traceback (most recent call last):   File "manage.py", line 10, in <module>     execute_from_command_line(sys.argv)   File "/usr/local/lib/python2.7/dist-packages/django/core/management/__init__.py", line 354, in execute_from_command_line     utility.execute()   File "/usr/local/lib/python2.7/dist-packages/django/core/management/__init__.py", line 346, in execute     self.fetch_command(subcommand).run_from_argv(self.argv)   File "/usr/local/lib/python2.7/dist-packages/djcelery/management/base.py", line 77, in run_from_argv     return super(CeleryCommand, self).run_from_argv(argv)   File "/usr/local/lib/python2.7/dist-packages/django/core/management/base.py", line 382, in run_from_argv     parser = self.create_parser(argv[0], argv[1])   File "/usr/local/lib/python2.7/dist-packages/django/core/management/base.py", line 331, in create_parser     parser.add_option(opt)   File "/usr/lib/python2.7/optparse.py", line 1021, in add_option     self._check_conflict(option)   File "/usr/lib/python2.7/optparse.py", line 996, in _check_conflict     option) optparse.OptionConflictError: option -C/--no-color: conflicting option string(s): --no-color
I am using,
django-celery==3.1.10
celery==3.1.13
How can I resolve this?

upgrade the django celery to latest version 3.2.2


⚠ Bofrost.de has degraded performance

In 4a98b20, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 979 ms

Resolved: Bofrost.de performance has improved in 0f71b5c after 6 minutes.


Update SSL version

Using the 0.10 version of the gem I get:

OpenSSL::SSL::SSLError (SSL_connect returned=1 errno=0 state=error: tlsv1 alert protocol version)

when connecting to https://services.arcgis.com. This PR fixes the issue by updating from:
http.ssl_version = :TLSv1

to:
http.ssl_version = :TLSv1_2

I get the same error. d1ffff489626b0f795db4f3d4833d2768f0624e0 fixes it for me.

Note that the released 0.1.0 gem is from a fork by @MatzFan.


GH-36234: [Packaging][Debian] Add support for Debian GNU/Linux trixie (13)

Rationale for this change
It's a new testing.
What changes are included in this PR?
Added it.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.

Closes: #36234

@github-actions crossbow submit -g linux

@github-actions crossbow submit debian-trixie-*

@github-actions crossbow submit debian-trixie-*

@github-actions crossbow submit debian-trixie-*

+1


option to mute interstitial video ads

Can the following be added to have an option of showing interstitial video ads muted:
Android
MobileAds.setAppVolume(0.0f);
MobileAds.setAppMuted(true);
iOS
[GADMobileAds sharedInstance].applicationVolume = 0.0;
[GADMobileAds sharedInstance].applicationMuted = YES;

@duseless Please try out AdMob Plus, which provide these APIs (https://admob-plus.github.io/docs/volume-control.html).

Thought that you were going to support admob free until the admob plus has all the features, and without mediation one cannot move to admob plus


Exception: Unknown option ssl_ca_certs when collecting mongodb metrics

2023-04-06 10:30:49 UTC | CORE | ERROR | (pkg/collector/python/datadog_agent.go:130 in LogMessage) | mongo:e1d99e3a7002a150 | (mongo.py:188) | Exception: Unknown option ssl_ca_cert
Checks are working fine against my Mongo cluster, but Metrics are not being collected. It looks like the agent cannot connect to the Mongo because of a dodgy config option ssl_ca_cert.
The error throws whether I provide this option in /etc/datadog-agent/conf.d/mongo.d/conf.yaml or not.

👋 @Jivings would you mind sharing your config with and without the ssl_ca_cert param? Please do censor out any sensitive information.
At a glance, it seems like it could be related to the ssl_ca_cert. This I believe has been deprecated by pymongo.  So we had removed it:
https://github.com/DataDog/integrations-core/pull/13881/files
If you need to use it then I think you would need to use the new params:
https://github.com/DataDog/integrations-core/blob/master/mongo/datadog_checks/mongo/data/conf.yaml.example#L98-L110

Hey @steveny91, this option was not being used in the config. It's commented out.

I updated to the latest version, and changed to use the TLS options and it's now working. Thanks!


error on startup

Hi, I've tried to setup emojimixing on my vps, however I ran into an issue when trying to run it:
[Node] internal/modules/cjs/loader.js:818
[Node]   throw err;
[Node]   ^
[Node]
[Node] Error: Cannot find module '/root/EmojiMixing/dist/app.js'
[Node]     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
[Node]     at Function.Module._load (internal/modules/cjs/loader.js:667:27)
[Node]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
[Node]     at internal/main/run_main_module.js:17:47 {
[Node]   code: 'MODULE_NOT_FOUND',
[Node]   requireStack: []
[Node] }
[Node] [nodemon] app crashed - waiting for file changes before starting...

which I don't quite understand (as I also know next to nothing about node), but that file, the whole dist folder even, does not exist.

Hi. Probably I haven't described the setup&launch steps properly. Will look into them tomorrow, thx


Does not install on clusters where running containers as root is not allowed

The keda http-add-on can not be installed and doesn't work in clusters where containers are forced to run as non-root.
It would be nice if we could configure each containers' securityContext in the helm-charts values.yaml.
Expected Behavior
Helm-chart should install and creating a HTTPScaledObject should successfully start components in target namespace.
Actual Behavior
All components fail to install because their container spec doesn't specify the UID and GID under which the containers will run. This results in events like so:
podinfo         0s          Warning   Failed                         pod/podinfo-interceptor-5d86f9bb84-zjzxk                           Error: container has runAsNonRoot and image has non-numeric user (nonroot), cannot verify user is non-root

I was able to get the http-controller-manager to start by adding the following securityContext to each container's spec:
    securityContext:
      runAsGroup: 65532
      runAsUser: 65532

Steps to Reproduce the Problem
Our PodSecurityPolicy looks like this, which forces all containers to run as non-root:
apiVersion: policy/v1beta1
kind: PodSecurityPolicy
metadata:
  annotations:
    seccomp.security.alpha.kubernetes.io/allowedProfileNames: docker/default,runtime/default
    seccomp.security.alpha.kubernetes.io/defaultProfileName: runtime/default
  name: restricted
spec:
  allowPrivilegeEscalation: false
  allowedCapabilities:
  - NET_BIND_SERVICE
  fsGroup:
    ranges:
    - max: 65535
      min: 1
    rule: MustRunAs
  requiredDropCapabilities:
  - ALL
  runAsUser:
    rule: MustRunAsNonRoot
  seLinux:
    rule: RunAsAny
  supplementalGroups:
    ranges:
    - max: 65535
      min: 1
    rule: MustRunAs
  volumes:
  - configMap
  - emptyDir
  - projected
  - secret
  - downwardAPI
  - persistentVolumeClaim

Specifications

KEDA Version:
KEDA HTTP Add-on Version:

❯ helm ls -n keda
NAME       	NAMESPACE	REVISION	UPDATED                                 	STATUS  	CHART                  	APP VERSION
http-add-on	keda     	1       	2021-06-24 13:51:28.934724904 +0200 CEST	deployed	keda-add-ons-http-0.1.0	0.1.0
keda       	keda     	1       	2021-06-24 11:21:00.927907258 +0200 CEST	deployed	keda-2.3.2             	2.3.0

Platform & Version: EKS 1.19
Kubernetes Version:

clientVersion:
  buildDate: "2021-06-16T12:59:11Z"
  compiler: gc
  gitCommit: 092fbfbf53427de67cac1e9fa54aaa09a28371d7
  gitTreeState: clean
  gitVersion: v1.21.2
  goVersion: go1.16.5
  major: "1"
  minor: "21"
  platform: linux/amd64
serverVersion:
  buildDate: "2021-03-10T21:32:29Z"
  compiler: gc
  gitCommit: 96780e1b30acbf0a52c38b6030d7853e575bcdf3
  gitTreeState: clean
  gitVersion: v1.19.8-eks-96780e
  goVersion: go1.15.8
  major: "1"
  minor: 19+
  platform: linux/amd64

Are you willing to contribute this?

@tomkerkhove I haven't had a chance to contribute this yet, so  @mhulscher if you're open to contributing this, I'd welcome that!

This can be closed?
PSP was deprecated in 1.21 and will be removed in 1.25.

Closing as I am no longer following this.

With respect to installing on clusters where non-root is required, this is the default behavior now:
https://github.com/kedacore/charts/blob/main/keda/README.md#keda-is-secure-by-default


OSPOS v3.3.6 Installation Issue

I am having issues installing OSPOS v3.3.6 and would need some assistance.
Infrastructure
OS: Ubuntu 20.04
PHP: 7.4
MySQL: MariaDB 10.6
Apache: v2.4
What have I done
Downloaded the release version of v3.3.6(https://github.com/opensourcepos/opensourcepos/releases/download/3.3.6/opensourcepos.master.3.3.6.zip)
Unzipped it to a folder called ospos
Moved the entire ospos folder to /var/www/html
Created database user ospos and database ospos
Assigned all privileges for ospos database to ospos user
Migrated database.sql to ospos database (This created 31 tables and default inserts)
Edited the public/.htaccess file and set ospos_path to /var/www/html/ospos
Navigated to http://server_IP_Address/ospos/public were I was presented with Login Page.
Logged in with default login credentials (admin/pointofsales)
Got an error message along the lines of the resource requested not available(paraphrasing here)
I have made sure that the entire ospos subdirectory is owned by www-data:www-data
I have also ensures that php-bcmath is installed alongside other requirements.
What else do I need to check to properly troubleshoot this?
Thanks in advance for any assistance


feat(Compute): Adds usage report export bucket samples.

Failures are unrelated and being tracked in #1311
Force merging.


Proposal to refactor Config for User Interface Testing

Config needs to be able to

Have it's own namespace for uiTesting (perhaps by adding ui-testing in front of the UserDefault keys.
Create several sets of fixed Wallets for uiTesting.
Passed from one coordinator to another instead of just creating it on the coordinator's init method.

Passed from one coordinator to another instead of just creating it on the coordinator's init method

Definitely. We have removed many of these. But appears to have come back. Maybe a PR to get rid of these first? Might involve a number of files.

Have it's own namespace for uiTesting (perhaps by adding ui-testing in front of the UserDefault keys.

Since Config mostly reads from UserDefaults [^1], maybe it's easier to just add a initializer init(defaults: UserDefaults), change Config to use it and pass in a different UserDefaults instance for tests?
[^1]: we should probably see if we can fix any values that aren't.

Actually, we are already halfway there: https://github.com/AlphaWallet/alpha-wallet-ios/blob/c98072d2771fe4f3d277c2e7e9a07916470a3663/AlphaWalletTests/Factories/Config.swift#L7

Maybe it's the static functions in Config which are the problem

@eviltofu do you have enough feedback from me?


Broken link to  .NET Core Nano Server Dockerfile.

The link to .NET Core Nano Server Dockerfile at the end of the page does not exist.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c1a1a7bd-e5cd-aa5a-c21a-196cfbce495c
Version Independent ID: c89f33c7-6572-38ad-6a53-9cb6ed610c1d
Content: Windows Container Base Images
Content Source: virtualization/windowscontainers/manage-containers/container-base-images.md
Product: windows-server
Technology: windows-containers
GitHub Login: @mattbriggs
Microsoft Alias: mabrigg

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


HDFS-16095. Add lsQuotaList command and getQuotaListing api for hdfs …

3155

 Quality gate: Failed
6 Issues

 6 Code issues

Details


Add ability to configure issuer at runtime

This commit allows users to specify the name of a ConfigMap which should be watched for issuer configuration. Importantly, this allows for istio-csr to be installed at the same time as cert-manager without needing an issuer to already exist
The helm chart assumes that the ConfigMap is in the same namespace as the istio-csr Deployment.
This is very similar to https://github.com/cert-manager/csi-driver-spiffe/pull/141 which implemented similar functionality for csi-driver-spiffe.
While this is similar to csi-driver-spiffe, a key difference is that the runtime configuration configmap watcher in this PR is a controller-runtime Runnable.

/test pull-cert-manager-istio-csr-k8s-v1-26-istio-v1-14

/test pull-cert-manager-istio-csr-k8s-v1-26-istio-v1-14

I've added a second commit with the suggested change and a minor extra one (to remove a pointless deployment running in the e2e test)

The merging of https://github.com/cert-manager/testing/pull/1044 made the test output go a bit crazy.
I reworked the commits. My change to use a single service for the runtime config e2e test revealed a race condition in how we wait for pods to be ready. I've addressed that and fixed it for the mtls e2e test too.

/test pull-cert-manager-istio-csr-istio-v1-14
/test pull-cert-manager-istio-csr-istio-v1-17
/test pull-cert-manager-istio-csr-istio-v1-16
/test pull-cert-manager-istio-csr-istio-v1-20


Add getElement() functions to Panel and PanelGroup

This makes it much easier to do stuff like in https://github.com/bvaughn/react-resizable-panels/issues/48#issuecomment-1368106118, because you don't need a querySelector anymore but can use the ref to target the group or panel directly.
Also, this is the minimal implementation needed to get this working (I think), feel free to adjust & fix anything I missed.

I appreciate the PR, but I would prefer not to make this change.
I don't think it actually simplifies the issue you linked to– primarily  because PanelResizeHandle doesn't support a ref, but you need to account for their size also. If I were to add ref support to that component, then you'd need to add multiple refs (to group and resize handle) at which point I think the code isn't really any more straight forward.

I think it would simplify the code because a ref is available on the Group. This means a queryElements can be done on this element, instead of the .document.
The original example is not scalable, because you need the reference to the element that is rendered (and not just any group rendered in the document).
One way of doing that is by adding a <div> around the panelgroup that you can give a ref to, but I don't prefer that because it introduces a wrapper div.
It is also possible to generate an unique id, but that feels more like an escape hatch. In the end, it feels more right to me that a ref is available (just like all other React components). Hiding this feels weird.
The example could become something like:
  const MIN_SIZE_IN_PIXELS = 100;

  const [minSize, setMinSize] = useState(10);
  const panelGroupRef = useRef<ImperativePanelGroupHandle>(null);

  useLayoutEffect(() => {
    const panelGroup = panelGroupRef.current?.getElement();
    if (!panelGroup) return;
    const resizeHandles = panelGroup.querySelectorAll(
      "[data-panel-resize-handle-id]"
    );
    const observer = new ResizeObserver(() => {
      let height = panelGroup.offsetHeight;

      resizeHandles.forEach((resizeHandle) => {
        height -= resizeHandle.offsetHeight;
      });

      // Minimum size in pixels is a percentage of the PanelGroup's height,
      // less the (fixed) height of the resize handles.
      setMinSize((MIN_SIZE_IN_PIXELS / height) * 100);
    });
    observer.observe(panelGroup);
    resizeHandles.forEach((resizeHandle) => {
      observer.observe(resizeHandle);
    });

    return () => {
      observer.disconnect();
    };
  }, []);

This would work when multiple panelgroups are rendered in the DOM.

The original example is not scalable, because you need the reference to the element that is rendered (and not just any group rendered in the document).

I think you're overlooking a key detail in my original comment– the data id attribute.
// Given a group like so
<PanelGroup direction="horizontal" id="your-id-here">

// This query selector gets you the exact same HTML element as the getElement() API you're proposing would
// Note that "your-id-here" matches to whatever prop you pass to the PanelGroup (above)
const panelGroup = document.querySelector('[data-panel-group-id="your-id-here"]');

// With it, you can query for only resize handles within the group, like so:
panelGroup.querySelectorAll("[data-panel-resize-handle-id]");

But, why force this on users?
I find it more practical to use a ref, so I don't have to mind about a component being rendered twice possibly.
A ref is always bound to the rendered element, so I don't have to worry about generating unique ids.

I think I've already shared my opinion and it seems like we just disagree. I don't think your opinion is totally crazy, I just don't think this change is an improvement. :)


add in the way to use it

this is where I got lost and confused

Thank you but this is not the way to use it. VueRouter is accessible because it's included as a global script.

Please, search existing issues and pull requests before opening issues, it saves maintainers a lot of time 🙏


Add azure storage account export target

This PR prepares:

data_types, ignore_alloc_keys & rename_columns_config to be read from ConfigMaps by reading them from file
Business logic to use Service Principal and upload blob to Azure Storage Account container
Factory pattern to target aws & azure blob storages. As of now, the code would not allow saving to local file system
Testing extended accordingly
Lots of thoughts what could be added to the code or where error handling could be improved
Adjust README accordingly. But I wanted to checkin with you guys first.

I'll have to defer to @lmello and/or @sntxrr on this one

Thanks for your contribution. I am reviewing it.

@cklingspor
I love the idea of moving data_types, ignore_alloc_keys & rename_columns_config to config maps. This is what I was planning to do to make this more parametrized.
I like the idea of supporting both s3 and azure blob storage, but must still support local filesystem.
Please let me know when you are ready for review, Since I am using this in my production environment I will need to extensively test it before merging.

@lmello : I've added  the env variables (was using that already in a private version. I've also updated the docs. I think you could run a test on your environment. Interested to hear your findings 😊

Sorry for the long delay. I am updating my opencost environment this week to version 1.110 and will be able to test this change next week. hope it is ok for you @cklingspor

No worries, works for me @lmello . Thanks!

@cklingspor sorry for the delay to test this. Trying to get some time at work. I hope to have a faster turn around on your next contributions.

I liked that by adding the files we allow people to overwrite them on their docker images or using config maps.

Hi @lmello ,
was on a longer vacation. Thank you for the review. I'll take a look the upcoming week and submit changes.

Its good you added this, because I will need to deploy to gcp and you create the basis for supporting multiple providers, I am going to be adding the gcp support soon.

Merging this PR! Thanks for your contribution @cklingspor !!!!


Add a nebula installing description named installed by dashboard

https://docs.nebula-graph.com.cn/3.1.0/4.deployment-and-installation/2.compile-and-install-nebula-graph/6.deploy-nebula-graph-with-peripherals/ done


copr: enable copr builds

Enable copr builds
Signed-off-by: Sandro Bonazzola<EMAIL_ADDRESS>

superseded by #1534


[WIP]message_feed: Update placeholder text of starred empty view.

Changes Made:

Added a new file named starred_empty_view_placeholder.hbs to update the placeholder text specifically for empty starred views.
Updated existing placeholder text for mentions.

Additional Notes:
Why I Created starred_empty_view_placeholder.hbs Instead of Updating the Existing Placeholder Text ?
The reason for creating starred_empty_view_placeholder.hbs instead of simply updating the existing text lies in the necessity to incorporate a star icon between strings.
Fixes #29378.
Starred

Mention

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@sujalshah-bit What's the status on this PR? Do you plan to fix tests and complete the self-review checklist?

It looks like the @ might be missing the code formatting suggested in the issue?

Also, please include screenshots showing more of the Zulip window, to give a better feel for how these messages look in context.

Thanks! I think we need to discuss the design here. Posted on CZO.

Closing in favor of #30575 for this issue, thanks for working on this @sujalshah-bit!

@sujalshah-bit You might find it helpful to read https://github.com/zulip/zulip/pull/30575, as it takes a different technical approach.


[fontc] Move more code from binary to lib

Currently much of the code in fontc lives in the main.rs file, and I would like to move more of it into the library crate.
This follows general Rust conventions, and has additional benefits like enforcing visibility on various types, which forces us to think a bit more about our API.
from a brief look, I would expect to move ChangeDetector and Workload into their own files, along with whatever types they use. Apart from that the other question would be where to put all the free fns. Some of these feel like they should be methods, and maybe the others can just live in their own module, re-exported from the crate root or something?

Ew ... in looking again it has indeed grown a lot.
Another thing that would be nice to change is to move the dependency declarations to the actual create work functions because that's where we actually know what we need to read/write.

@cmyr is this now done given your recent changes?


Billing timeout and filter constant changes.

Recent runs of seer and hail were timoung out on hail api. It took close to 60 seconds, had increased timeout to 90 seconds, which should sort out those errors.
As well limit the += to only 5 days, that 10 days seems to get too many ids, 3-5 days should be enough to check against data already in the table.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@898222b). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage        ?   90.74%
=======================================
  Files           ?        4
  Lines           ?      432
  Branches        ?        0
=======================================
  Hits            ?      392
  Misses          ?       40
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support GitHub Token API

Hi!
Your project is the best app to monitor Travis CI. Thanks for providing this amazing tool for the community!
Publish username and password could not be safe.
Github provides API key to access all levels. It's safer and can be revoked when needed.
Consider providing an option to API token instead of password.
Regards!

Hi @uilianries I would like to work on this issue!

Really appreciate!

@uilianries Logging in using the API token would require OAuth. Is this registered for OAuth and do we have any client_key and client_secret?

@uilianries To use Oauth Token, client_id and client_secret must be needed that is unique for the app. How do I get it?

Here is a documentation of the auth on Travis CI. https://docs.travis-ci.com/api#authentication
So in order to authenticate on Travis CI, you need to provide a token. And a token can be received through the GitHub.
Yes, we can implement one more option for users to provide a token instead of credentials. But how convenient will it be to input a token comparing to credentials? Most of the users know their GitHub credentials and don't care about creating a token.
I'm open for suggestions and ideas :)


Add calico/routereflector support

Add BGP route reflectors support in order to optimize BGP topology for deployments with Calico network plugin.
Also bumping calico/ctl version to get some bug fixes.

That's really cool! thanks!

Rebased


Filtering by dates

Great Job sir.
My issue is with the filter argument in the updated ona_get_data() function. It's unclear how to use it to filter by dates. I have tried the following:

I thought to make the dates an object so I can always just change the figures.

> date_filter <- list(
+   submission_time = list(
+     "$gte" = "2024-11-05T00:00:00",
+     "$lte" = "2024-11-12T14:30:00"
+   )
+ )
>
> ona_eim_ipds_ih_epm <- poliprep::get_ona_data(
+   form_id = 7178,
+   api_token = Sys.getenv("ONA_TOKEN"),
+   filters = date_filter
+   )

I tried to use list() and _submission_time as parameters

> ona_eim_ipds_ih_epm_date_filter <- poliprep::get_ona_data(
+   form_id = 7178,
+   api_token = Sys.getenv("ONA_TOKEN"),
+   filters = list(_submission_time = c("2024-11-11"))

I was getting an error for using _submission_time. So I thought removing the underscore would work

> ona_eim_ipds_ih_epm_date_filter <- poliprep::get_ona_data(
+   form_id = 7178,
+   api_token = Sys.getenv("ONA_TOKEN"),
+   filters = list(submission_time = c("2024-11-11"))
+ )

Here I tried using the endtime column since it did not have the underscore prefix

> ona_eim_ipds_ih_epm_date_filter <- poliprep::get_ona_data(
+   form_id = 7178,
+   api_token = Sys.getenv("ONA_TOKEN"),
+   filters = list(endtime = c("2024-11-11"))
+ )

Same idea as bullet one but with endtime instead of submission_time

> date_filter <- list(
+   endtime = list(
+     "$gte" = "2024-11-05T00:00:00",
+     "$lte" = "2024-11-12T13:00:00"
+   )
+ )
>
> ona_eim_ipds_ih_epm_date_filter <- poliprep::get_ona_data(
+   form_id = 7178,
+   api_token = Sys.getenv("ONA_TOKEN"),
+   filters = date_filter
+ )

Sadly none of these options generated any data.
Would be grateful if this could be fix of be clarified.
Regards.
Thank you

Hi Davies,
Thank you for this request! I’ve managed to incorporate the additional filters using comparators, though it was a bit tricky given that the querying is done in MongoDB. I’ve worked to make this as straightforward as possible using R input.
To select specific elements in a column, you can now use logical_filters. For example, to select 'BORNO' and “KANO” in the states column, you can input list(states = c("BORNO", "KANO")).
For filtering ranges, you can use comparison_filters, which always starts with a tilde (~) and then the conditions are written in a standard R syntax. For example:
~ `today` >= "2023-02-04" & `today` <= "2025-02-04"
This filter selects rows where the today column falls within the specified date range. By combining logical_filters and comparison_filters, we can create a versatile query for our dataset.
Here’s an example:
ona_eim_ipds_ih_epm <- get_ona_data(
  form_id = 7178,
  api_token = Sys.getenv("ONA_TOKEN"),
  selected_columns = c("states", "endtime", "today", "_duration"),
  logical_filters = list(states = c("BORNO", "KANO")),
  comparison_filters = (~ `today` >= "2023-02-04" & `today` <= "2025-02-04")
)

This example selects the columns states, endtime, today, and _duration from form ID 7178, and filters to include only rows where the states column is either “Borno” or “Kano,” and where the today column falls within the specified date range.
Before applying any of these filters, please double-check both the column names and their contents to ensure they match your intended filters. For example, if you plan to use the submission_time column, note that in form 7178, this column is labelled _submission_time.
Please play around with this and let me know if there are any issues.

Dear colleagues,
Are we still exploring the possibility of moving all our scripts to GitHub as early planned? I think it has benefits. Thank you for your collaboration.


Provide a OpenJDK 10 Mac build with the correct layout for completeness

See https://github.com/AdoptOpenJDK/homebrew-openjdk/pull/46

I'm going to try and kick off a build today

closing https://github.com/AdoptOpenJDK/openjdk10-binaries/releases/tag/jdk-10.0.2%2B13


Fetching https://cloud.google.com/go?go-get=1
Parsing meta tags from https://cloud.google.com/go?go-get=1 (status code 200)
import "cloud.google.com/go/...": parse https://cloud.google.com/go?go-get=1: no go-import meta tags
package cloud.google.com/go/...: unrecognized import path "cloud.google.com/go/..."

See https://travis-ci.org/GoogleCloudPlatform/gcloud-golang/jobs/149608141
/cc @broady @okdave @jba

Yes, @broady is looking now. Looks like it might be due to go/commit@5b085482ae8792cf751371991488d29e7bd3762f

Fixed.
$ GOPATH=$HOME/.tmpgopath go1.5/bin/go get -u cloud.google.com/go && echo woohoo
woohoo


hg_poll_destroy(): Poll set non empty

I'm getting the following error on both the client side and server side when shutting down Mercury, using the Margo library atop it, and configuring Mercury to include no transports except the na_sm one:
# HG Util -- Error -- /home/pcarns/working/src/mochi/mercury/src/util/mercury_poll.c:121
 # hg_poll_destroy(): Poll set non empty
# NA -- Error -- /home/pcarns/working/src/mochi/mercury/src/na/na_sm.c:2719
 # na_sm_finalize(): hg_poll_destroy() failed
# HG -- Error -- /home/pcarns/working/src/mochi/mercury/src/mercury_core.c:913
 # hg_core_finalize(): Could not finalize NA interface
# HG -- Error -- /home/pcarns/working/src/mochi/mercury/src/mercury_core.c:2373
 # HG_Core_finalize(): Cannot finalize HG core layer

The communication leading up to that point worked fine.  Is this something that I am doing wrong at the API level, or is this an issue inside Mercury?

Looking in a debugger I can see that there are two poll_sets being manipulated during the run.  One of them has exactly one hg_poll_add() and a matching hg_poll_remove().  The other one has 3 hg_poll_add() calls but only 1 hg_poll_remove() call.

I was able to fix the problem on the client side by adding a missing HG_addr_free() call in the application (to match an earlier addr_lookup()).  I should have been doing this all along, but it is more obvious now that the is necessary to remove fds from the poll set :)
I'm still having a the "Poll set non empty" problem on the server side, though, and I don't believe that it is calling an explicit addr_lookup() like the client is.

It looks like at least one of the extra fd's on the server side is being added to a poll set by way of the na_sm_progress_accept() call path, which in turn calls na_sm_poll_register(), but I'm not sure how that fd is supposed to get back out of the poll set after that.

Ah ok yes actually Yulu had that problem and that's why I entered the issue: https://github.com/mercury-hpc/mercury/issues/150

Hmm all addresses on the server should be freed unless there is still a reference to it, which Addr calls are you making on the server?

Ok.  I walked through na_sm_finalize(), and I can see that it is indeed iterating the accepted_addr_queue and trying to free the right address (which would clear it from the poll set).  The na_sm_addr_free() is returning early, though, because the ref count on the address has not hit zero.
I may have a problem in the timing of how I am shutting down the service via an RPC.  Maybe the RPC handler hasn't fully completed and cleaned up before I start executing the shutdown steps.  I'll check.

Ah I see, that could be possible, well anyway I think that's another reason for having #150. I'm thinking of just having a counter per na_class that gets incrememented on creation and decremented when an addr is freed. Addresses get created after a recv_unexpected call and freed when we are done with the handle.

Although NA_Finalize should never be called if something has not completed yet... so maybe that's something else....

Ok, I'm confused :)
Two more pieces of data:

I have multiple concurrent RPCs in flight to the same na_sm addr at an earlier point in this test
The na_complete_sm() function causes the ref_count for that addr to go rather high (to 5 in this case) because of the hg_atomic_incr32() in the NA_CB_RECV_UNEXPECTED switch case
na_sm_addr_free() is called later, but never gets the ref count low enough before finalize

Is there some other code path that is supposed to decrement the addr refcount that I'm not seeing?  I don't see how addr_free() will be called enough times to get it to zero.
If I comment out the hg_atomic_incr32() call in na_complete_sm() then the error goes away for me, but I'm not sure I really understand what's going on here, so that might not be a real fix.

That's definitely not the right fix exactly; if I simply comment out that inc32 then addr_free() gets called twice for that address even though the ref_count stays at 1 (meaning that the second addr_free() is making the ref_count go negative, and probably is corrupting memory).

Maybe the na_sm add ref counting is right, but I'm having a problem with the handle ref counting above it.  If the handle ref count never hits zero, then it will never call free on the underlying addr.  If I add printfs to hg_core_destroy() and hg_core_reset_post() I can see that there are handles that never get past a ref count of 1.  If they were to hit zero maybe they would trigger enough addr_frees to release the na_sm addr.
Still not really sure if this is a problem in my code or something I am triggering in Mercury.

Wow, that was painful.  This was a problem in my code.  I had an RPC handler that was not calling HG_Free_input().  This prevented the handle ref count from being decremented, which prevented the handle destroy from calling the addr free function, which prevented its ref count from being decremented, which ultimately led to too many fds in the poll set, and thus the error.
Ultimately the error msg was a good thing because it revealed a bug in this test program that I was not aware of before, it just took me a long time to debug.
Sorry about the github noise.

I see, so that's what I was expecting then, recv_unexpected creates an address, which is the reason why the refcount is incremented in na_sm. The address returned from recv_unexpected though is attached to the handle in mercury_core.c line 1483 and then freed with the handle or when the handle is reposted, line 1895.

Oh sorry I just see your message now and I was going to say that it means that the refcount to the handle is not decremented :)

I wonder how we could prevent that situation from happening, or at least to tell the user that something has not been freed...

Maybe just a safety check at finalize time if there are any handles left that were never fully destroyed?  I think in this case I would have saved time if I had known to look for a resource leak at that level instead of the NA level.

Yes sounds good to me, I guess we can do the same check as for addresses (and for anything that is created in general)


Updated the name in readme.

[=] Updated the readme name

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

hi, [=] fix a few gramma errors in API documentation
as mentioned in https://github.com/alibaba/xquic/blob/main/CONTRIBUTING.md#commit-messages

Thanks for your contribution, but would you mind changing the commit messages to
[=] Updated the readme name
as mentioned in https://github.com/alibaba/xquic/blob/main/CONTRIBUTING.md#commit-messages

Done.

Done.

To change the commit message, you should rebase and then force push.
https://docs.github.com/en/get-started/using-git/about-git-rebase#commands-available-while-rebasing

reword
The reword command is similar to pick, but after you use it, the rebase process will pause and give you a chance to alter the commit message. Any changes made by the commit are not affected.

and the PR can only be merged after you have signed the CLA.

I have singed the CLA

can u tell me how to do it in the git GUI I didn't quite get that

https://docs.github.com/en/get-started/using-git/about-git-rebase#commands-available-while-rebasing

I think it would be easier to use the command line, see https://docs.github.com/en/get-started/using-git/using-git-rebase-on-the-command-line

Hi, #46 has solved this problem, so I will close this PR.


Update constants to match the reference implementation

I tried to use this code to replicate the output from a C implementation of Mersenne Twister and noticed that the values are different for the same seed.
After some debugging, I found two differences to the reference implementation and the wikipedia pseudocode:

the lower_mask is usually defined as 0x7FFFFFFF and the upper_mask as 0x80000000 (which matches the description in wikipedia)
in the tempering part in extract_number(), the constants s, b and t, c are switched

It would be really nice if you could merge this, especially since the README claims Coefficients follow the standard of MT19937-32.

Hey, I just noticed a difference in your implementation and one on Wikipedia
In the extract number function, the pseudo code on Wikipedia says
    int y := MT[index]      y := y xor ((y >> u) and d)      y := y xor ((y << s) and b)      y := y xor ((y << t) and c)      y := y xor (y >> l)
where as you have implemented:
    y = y ^ ((y >> u) & d)     y = y ^ ((y << t) & c)     y = y ^ ((y << s) & b)     y = y ^ (y >> l)
the subtle difference is in the order of assignments, you seem to have swapped the ordering of s and t, and since we are continuously updating y after each line the change in order changes the output.

Thanks for the reply, but I think I already fixed that in this merge request.
Together with the updated lower_mask and upper_mask values it should now match the reference implementation and it also returns the same numbers for a fixed seed as these rust and js implementations.

got it, I guess it hasn't been merged cause it didn't show the changes then, thanks

Thank you guys!


WindowView not overlaying keyboard

Hi,
First of all, thanks for a great job with this library. There's one thing, i can't understand how to make it with your library. Imagine following situation: There's a stack of view controllers, by clicking next button in one of them, next view controller is opened. When this second vc is opened, some textfield in that controller becomes first responder. So keyboard becomes visible. The problem here, is that AGWindowView is not overlaying this keyboard. It's keyboard overlaying AGWindowView.
If i get it correct, AGwindowView uses keyWindow, which is usually the first window in UIApplication windows array. And when keyboard shows, Additional window(actually UITextEffectWindow) is added to windows array. So UITextEffectWindow is now on top of key window.

Won't fix


web component for transforming inside the browser with SaxonJS

It would be nice to have a web component that does the transformation inside the browser with SaxonJS.
This would make developing XSLT and deploying it to the www much more agile.

mentioned in commit ceb648d1c206e2ad06f6290ce067cbd076fd2e1c

This is being developed on the transform-sef branch. The component was implemented in bfbfa38d4e9e28d08879e74fac1d6a636be8ebb0.
However, there is a bug in SaxonJS, whenever it is loaded as a module: https://saxonica.plan.io/issues/6233

mentioned in commit 524e66094ddec4c05dfb696ecad17bb7da213f0f

mentioned in commit 8df372c336d9f408b5400d4efb0262bf28c31cec


Add circleci

Trying out the default config.
We might have to revise once it's set up

I'd prefer these CI steps in GitHub actions (since that's where we already build pages). Is there a reason we must use Circle CI?

Is there a reason we must use Circle CI?

None, I was just doing something out of habit.
You might want to add tests to the Github actions (as I didn't see it)
Otherwise, no need to use this :)


Update entrypoint.sh

Remove deprecated github action instruction. Just a note, this project is so so behind the original repository. Could we update it?
@Nitro/syseng

Newer version isn't free hence we pinned the older (free) version.


The textarea as the content to the Chat.Message does not respond to Up and Down arrow keys as expected

Bug Report
Steps
The textarea as the content to the Chat.Message UI component does not respond to Up and Down arrow keys as expected
An example show casing the scenario: https://codesandbox.io/embed/stardust-ui-example-wu6yo
steps:

Type some multi line text in the textarea which is inside the chat message list.
Press Up or Down key to try to move the cursor.

Expected Result
The cursor should move Up and Down along the text line.
Actual Result
The cursor does not move at all for Up and Down keys 💣
Version
stardust UI @0.38.1
Testcase

This needs to be fixed on consumer side by stopping the propagation of events in onKeyDown:
<textarea rows={10} onKeyDown={(e) => e.stopPropagation()} /> // TOOD: check correct key codes

Please note that propagation should be stopped only for desired keys - arrows, pgup, pgdown, home, end probably.


Cannot build on GNU/Linux : CMakeLists are missing (?)

Hi, I cannot build retdec following the README instructions. Apparenty, some CMakeLists are missing. I unsuccessfully tried to git checkout tags/v3.0
~/cq/retdec/build > cmake .. -DCMAKE_INSTALL_PREFIX=~/cq/retdec 2>&1 |xsel -ib
CMake Error at deps/CMakeLists.txt:2 (add_subdirectory):
  The source directory

    /home/valkheim/cq/retdec/deps/capstone2llvmir

  does not contain a CMakeLists.txt file.

CMake Error at deps/CMakeLists.txt:3 (add_subdirectory):
  The source directory

    /home/valkheim/cq/retdec/deps/ctypes

  does not contain a CMakeLists.txt file.

CMake Error at deps/CMakeLists.txt:4 (add_subdirectory):
  The source directory

    /home/valkheim/cq/retdec/deps/demangler

  does not contain a CMakeLists.txt file.

CMake Error at deps/CMakeLists.txt:5 (add_subdirectory):
  The source directory

    /home/valkheim/cq/retdec/deps/fileformat

  does not contain a CMakeLists.txt file.

CMake Error at deps/CMakeLists.txt:6 (add_subdirectory):
  The source directory

    /home/valkheim/cq/retdec/deps/fnc-patterns

  does not contain a CMakeLists.txt file.

CMake Error at deps/CMakeLists.txt:10 (add_subdirectory):
  The source directory

    /home/valkheim/cq/retdec/deps/libdwarf

  does not contain a CMakeLists.txt file.

CMake Error at deps/CMakeLists.txt:11 (add_subdirectory):
  The source directory

    /home/valkheim/cq/retdec/deps/llvm

  does not contain a CMakeLists.txt file.

CMake Error at deps/CMakeLists.txt:12 (add_subdirectory):
  The source directory

    /home/valkheim/cq/retdec/deps/pdbparser

  does not contain a CMakeLists.txt file.

CMake Error at deps/CMakeLists.txt:13 (add_subdirectory):
  The source directory

    /home/valkheim/cq/retdec/deps/retdec-config

  does not contain a CMakeLists.txt file.

CMake Error at deps/CMakeLists.txt:14 (add_subdirectory):
  The source directory

    /home/valkheim/cq/retdec/deps/tl-cpputils

  does not contain a CMakeLists.txt file.

-- Configuring incomplete, errors occurred!
See also "/home/valkheim/cq/retdec/CMakeFiles/CMakeOutput.log".

Any idea ?

You did not checkout recursively as stated in the instructions.

Hi. Yes, @Leseratte10 is correct. When cloning, you need to clone recursively to get the contents of all submodules, which contain the CMakeLists.txt files that you are currently missing. I suggest cloning the master branch as it has many bugfixes over the v3.0 tag:
git clone --recursive https://github.com/avast-tl/retdec

I am closing this as a duplicate of #4.


"Organize imports" quick fix doesn't account for @TestOn directive

Take the following code example:
@TestOn('windows')

import 'package:test/test.dart';
import 'package:winmd/winmd.dart';
import 'package:generator/generator.dart';

void main() {
...
}

The analyzer correctly flags that the last import is not alphabetically ordered. On using the VSCode quick fix ("Organize Imports"), this code is reordered thus:
import 'package:generator/generator.dart';
@TestOn('windows')

import 'package:test/test.dart';
import 'package:winmd/winmd.dart';

void main() {
...
}

which is of course incorrect (the @TestOn line should be first).
Dart version:
Dart SDK version: 2.17.1 (stable) (Tue May 17 17:58:21 2022 +0000) on "windows_x64"

Flagging to @DanTup in case this is a DartCode issue (running v3.40.0).

This looks like https://github.com/Dart-Code/Dart-Code/issues/3598 so I would've expected this to work. However looking at the definition of TestOn, it's not marked with @Target({TargetKind.library}) so the server doesn't know that it should remain at the top.
@natebosch @jakemac53 is @TestOn always library level? If so, I can send a change that adds @Target({TargetKind.library}) which I believe will fix this.

We should allow you to declare a name-less library as library;, so you'd have somewhere to put library-level annotations. The reordering is technically correct, because the original annotation belongs to the test library import, not the library, according to the language specification.
Tools which recognize annotations on the first import as being intended as annotations on the library are doing a hack, mainly because the "right thing" requires giving the library a name, which is annoying and verbose.

Tools which recognize annotations on the first import as being intended as annotations on the library are doing a hack,

It would definitely be nice if this was unambigious. The server has several places that have to add/re-order/remove imports that need to make assumptions about annotations.
But - it seems like quite a breaking (and perhaps annoying) change to say any use of @TestOn needs to have library; after it. If that's not to be enforced, then I think the server needs to handle this case better anyway (and I think we have a much less hacky way to do this using the Target annotation noted above - assuming it could be applied to TestOn).

I'm not as smart as you analyzer people, but what you're saying, @lrhn:

"The reordering is technically correct, because the original annotation belongs to the test library import, not the library, according to the language specification."

doesn't match what the documentation says:

"The @TestOn annotation makes it easy to declare exactly which platforms a test file should run on. Just put it at the top of your file, before any library or import declarations" (emphasis mine)

I'm using @TestOn on certain tests only, by the way. I have a couple of _test.dart files that do not have this attribute, since they are intended to run on all platforms.

From the language's perspective, annotations are put on declarations, and belong to the next following declaration.
As such, the @TestOn annotation is an annotation on the import 'package:test/test.dart'; declaration.
(The grammar rule allowing the annotation is <libraryImport> ::= <metadata> <importSpecification>.)
From the perspective of a source rewrite tool which doesn't know what the TestOn annotation means, or how it's documented, moving the import declaration to somewhere else includes moving its annotations along. Or, equivalently, moving another import up before the test import will put it before the annotation too.
The TestOn annotation is documented and interpreted specially. When it's an annotation on the first import is treated as an annotation relating to the library, and the association to the import is ignored. That's not a general rule, not all annotations ar treated that way. Tools can obviously do that, but it requires special knowledge to know that the import annotation is really intended as a library annotation. Simply writing it in documentation doesn't make other tools know that (or even know that such annotations exist).
It's a hack, and the hackiness shows in situations like this, because it requires every tool to be in on the hack.
If the analysis server adds an import for you, and it wants to put it first to keep things alphabetic, it could very well put it before the annotated import. It doesn't, which means it knows about the hack, and has added extra code to compensate.
The "organize imports" tool didn't know and hasn't added special casing, and therefore it treats @TestOn just as it would any other annotation on the import.
The proper, non-hackish solution, which doesn't require tools to treat this particular annotation specially, is to put the annotation on the library declaration. That's where metadata for the library goes. If you want DartDoc to document your library, you need to put the doc comment — a kind of metadata — on the library declaration. It can't just be on the first import (if you have imports, not every library does).
The problem with that solution is that to have a library declaration, you also have to give the library a name. That's highly annoying and potentially error-prone. If you give two libraries the same name, you can't import them into the same program.
So you have to give them good and long names. Nobody wants to do that, which is probably why the @TestOn annotation hack was introduced to begin with.
That's why I propose to fix that by allowing library; as a declaration to hang annotations and DartDoc on.
Then we can help people by having the tools which know the TestOn annotation introduce the library; declaration and move the annotation there (dart-fix, analyzer quick-fix, etc).
(If adding Target({TargetKind.library}) doesn't cause a warning, that's another example of special casing, because the annotation here is not on a library, it is on an import declaration. Marking TestOn as a library annotation would make a good hook for a quick-fix to introduce a library declaration for the annotation, and then make it a warning to keep the annotation on the import.)
I don't blame our users for thinking @TestOn works as documented. I do blame almost every choice leading up to this failure, including not introducing library; much earlier, like at the same time as metadata.
(I've long been aware that something was treating metadata on the first import as library metadata, but I didn't actually know what. I used to think it was DartDoc, but found out it wasn't. At least I've found out now.)

@natebosch

Conceptually yes. But the test runner has always had a hack where it could be applied on an import instead.

My understanding is that analyzer also knows about this, so you could still have Target({TargetKind.library}) on the annotation today without causing any warnings when it's on the first import:
https://github.com/dart-lang/sdk/blob/f2b5ba82ab156b11ad4d2467b72c09b0eac8fa8f/pkg/analyzer/lib/src/error/best_practices_verifier.dart#L1687-L1689
If that's accurate, I think we could add the Target annotation now (before any language change) and resolve this issue?

My understanding is that analyzer also knows about this

Hmm, apparently I used to know that too...
I don't see any comment in the PR about why TestOn was not changed, and the description looks like I intended to do this for all the annotations. I must have missed this one...
https://github.com/dart-lang/test/pull/1704

FWIW I do think that an explicit library; is a better solution than this hack, but given that the hack already exists in both test runner and analyzer/meta I'm happy to use it.

Yep, I agree - but it's nice to have this fixed with the current "behaviour" in the meantime :-)

https://github.com/dart-lang/test/pull/1704

Awesome, thanks!

I checked that with the change above, Tim's example now works:

@timsneath the fix won't show up until you're on a future version of package:test (1.21.2).
Presumably if library; is added (and required for library-level annotations) in future, we could have a dart fix that inserts library; after any existing library-level annotations that are on directives.


formula: allow excluding deprecate! reason when disable! exists

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

This is a fantastic idea. Thanks @cho-m!

Will wait until after #18733 is merged to finish this up.


preserve cite-detail in tex-math

Follow up from #445. Downstream needs to be able to identify cite-detail in tex-math.
Since we now preserve x elements as elements in tex-math, we're not adding much complication (textContent will still be good for MathJax rendering).

I guess this isn't technically a breaking change after #455 but still.


Rich text field and PageChooserBlock should use 'specific' URLs

I have a site that's implemented wagtail 1.7 with wagtail-modeltransation, but when I use inline PageChooser links in a RichTextBlock I'm unable to get the link for the page in other languages. wagtail-modeltranslation generates page URLs by overriding the .url method on the Page models configured for translation. This means that the only way to get the right links to use .specific.url rather than just .url on the generic Page model.
Would it cause any issues to make the PageLinkHandler in rich_text.py or the PageChooserBlock in blocks/field_block.py use value.specific.url when they render the value.url? This would be an easy fix for the problem and better enable the use of translated Page models.

Hi @dwasyl - yes, I think it would be appropriate to use specific in both PageLinkHandler and PageChooserBlock. Thanks for the report!

Okay great, thanks @gasman. Is this something you can just include in another patch or would a PR be helpful?

A PR would definitely be helpful, thanks!

Fixed in #3425 / #3494


Need add await in CreateExchange() to prevent create FRE flow from auto complete

Steps to reproduce:

Create Fixed Price
Accept first 2 transaction of mint and create
Wait about 5-10 second here without clicking Confirm/Reject on metamask

and u will see success message

Possible Solution:
Need to add await at code below for user to click Confirm/Reject on metamask before showing success.
https://github.com/oceanprotocol/ocean.js/blob/2be0918d8355395a4206396d5b592d6cc2d88eab/src/exchange/FixedRateExchange.ts#L149

Thanks a lot for reporting this @krisliew, I just tested it out and the problem is just like you described. I'll have a look at a possible solution


feat(data):Update multiple borderRadius token descriptions DSY2582

:tada: This PR is included in version 4.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add temporary API_KEY to latticectl context

fixed in https://github.com/mlab-lattice/lattice/pull/220


Can Ollama use both  CPU and GPU for inference?

What are you trying to do?
May I know whether ollama support to mix CPU and GPU together for running on windows? I know my hardware is not enough for ollama, but I still want to use the part ability of GPU.
But I checked the parameter information from link below, I still can not mix CPU&GPU, most load by CPU.
https://github.com/ollama/ollama/blob/main/docs/modelfile.md
If I put all load to GPU, it will say "Out of VRam", :) you know it.
I am guessing if it have, maybe like we can specify GPU sharing part load， and CPU on most load?
Thanks,
How should we solve this?
Please see content.
What is the impact of not solving this?
If not, all load on GPU will crash.
Anything else?
Thanks for all

You must provide the log off ollama serve to see how ollama have tried to share the models in both memory.

I can run ollama serve in cmd line, it is the log what you want?

Hi @OPDEV001 , this is how Ollama works by default. It will try to offload as many layers of the LLM as possible onto the GPU, and then if it doesn't fit the other layers will run on the CPU.
I'll go ahead and close the issue, but feel free to keep commenting.


Worked on Register page and on About page

Completely Rewrote the FAQ Page
Added "Workinprogress" Pages to all unused but mentioned routes
Added Working Register Page (State contolled by Edge Config)
Worked on About Page

#3
#2  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 1, 10:42 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

fixes #4


process.stdout and process.stderr could not print to NDB-Console

Steps to reproduce
Tell us about your environment:

ndb version: v1.0.26
Platform / OS version: Win10
Node.js version: v10.12.0

What steps will reproduce the problem?
Please include code that reproduces the issue.

process.stdout.write('stdout')
process.stderr.write('stderr')

What is the expected result?
NDB-Console should has something print.
What happens instead?
but only in Terminal could see some logs.
NDB-Console only print the process.stderr.write return is true.

Terminal output is available in terminal starting<EMAIL_ADDRESS>press Esc to show Console drawer and select Terminal there.


Use spark master in local intellij idea

Hello guys I am running spark operator on AWS eks cluster and everything is working fine .Now I wanted to run spark job by using master on intellij idea .Can anyone give me some ideas how to set it up

Hi,
have you take a look here :
https://www.jetbrains.com/help/idea/big-data-tools-spark-submit.html#spark-submit


Update to reflect collections and lazy removal

This updates the docs in order to reflect the fact that the collections and lazy
modules were removed in https://github.com/paritytech/ink/pull/1111.
I've added a short page on how to initialize the Mapping, although this could be
fleshed out a bit more in the future to match the old HashMap docs (which are still
around, just hidden from the sidebar).
There's also some mentions of StorageVec in the dynamic storage allocators docs. I
think we'll be removing this in the future, so I left those pages untouched. Same goes
for Memory.
I've also fixed some of the line lengths in places, so that blows up the diff a little.
Closes https://github.com/paritytech/ink-docs/issues/42, https://github.com/paritytech/ink/issues/1128.

So the CI is failing because https://paritytech.github.io/ink-docs/datastructures/mapping doesn't exist yet (was introduced in this PR)


feature/nodeMavenApi build from the ui

Allow the user to build their maven project from the ui.
The user should be able to build any pom in their workspace, with the option of the following goals:

clean
install
clean install
test

Completed


[Fix] Shadow renderer does not use nearClip of 0

Fixes: https://github.com/playcanvas/engine/issues/4858

Shadow renderer uses ortho camera for shadow projection, for which the nearClip of 0 works fine. But Camera class itself evaluates a perspective projection for skydome (not used in this case), which cannot use clip plane of 0, causing NaN results. Those values are not used at all, but avoiding them anyways.

Approving but can you put something in the description that explains what this is fixing exactly?

Approving but can you put something in the description that explains what this is fixing exactly?

Yes, on it .. wait with reviews for when invited ;)

Haha, I normally fill out the description when I open the PR! 😉

Yeah, I use Tower desktop tool, and it only lets me enter a single line of description (cannot do Shift-Enter to go to next line), and so I start with the empty description, and then continue in the browser.


Creation of instances failed

Hi, recently my moodle setup stoped to work (after some scalin-out and in).
Ive noticed that inside the status of the instances in vmss , where we can see all steps done by instance, under the "setup_moodle (Microsoft.Azure.Extensions.CustomScript, 2.1.10)" step we can see something like :
Enable succeeded: [stdout] ### Script Start Mon Jun 26 12:35:59 UTC 2023### + set -ex ++ date + echo '### Function Start Mon Jun 26 12:36:00 UTC 2023###' ### Function Start Mon Jun 26 12:36:00 UTC 2023### + curl -sL https://packages.microsoft.com/keys/microsoft.asc + gpg --dearmor + tee /etc/apt/trusted.gpg.d/microsoft.gpg ++ lsb_release -cs + AZ_REPO=bionic + tee /etc/apt/sources.list.d/azure-cli.list + echo 'deb [arch=amd64] https://packages.microsoft.com/repos/azure-cli/ bionic main' deb [arch=amd64] https://packages.microsoft.com/repos/azure-cli/ bionic main + add-apt-repository ppa:ondrej/php -y + apt-get -qq -o=Dpkg::Use-Pty=0 update + export DEBIAN_FRONTEND=noninteractive + DEBIAN_FRONTEND=noninteractive + apt-get --yes --no-install-recommends -qq -o=Dpkg::Use-Pty=0 -o Dpkg::Options::=--force-confdef -o Dpkg::Options::=--force-confold install azure-cli ca-certificates curl apt-transport-https lsb-release gnupg software-properties-common unzip rsyslog postgresql-client mysql-client git unattended-upgrades tuned varnish php7.4 php7.4-cli php7.4-curl php7.4-zip php-pear php7.4-mbstring mcrypt php7.4-dev graphviz aspell php7.4-soap php7.4-json php7.4-redis php7.4-bcmath php7.4-ldap php7.4-gd php7.4-pgsql php7.4-mysql php7.4-xmlrpc php7.4-intl php7.4-xml php7.4-bz2 E: Unable to locate package php7.4 E: Couldn't find any package by glob 'php7.4' E: Couldn't find any package by regex 'php7.4' E: Unable to locate package php7.4-cli E: Couldn't find any package by glob 'php7.4-cli' E: Couldn't find any package by regex 'php7.4-cli' E: Unable to locate package php7.4-curl E: Couldn't find any package by glob 'php7.4-curl' E: Couldn't find any package by regex 'php7.4-curl' E: Unable to locate package php7.4-zip E: Couldn't find any package by glob 'php7.4-zip' E: Couldn't find any package by regex 'php7.4-zip' E: Unable to locate package php7.4-mbstring E: Couldn't find any package by glob 'php7.4-mbstring' E: Couldn't find any package by regex 'php7.4-mbstring' E: Unable to locate package php7.4-dev E: Couldn't find any package by glob 'php7.4-dev' E: Couldn't find any package by regex 'php7.4-dev' E: Unable to locate package php7.4-soap E: Couldn't find any package by glob 'php7.4-soap' E: Couldn't find any package by regex 'php7.4-soap' E: Unable to locate package php7.4-json E: Couldn't find any package by glob 'php7.4-json' E: Couldn't find any package by regex 'php7.4-json' E: Unable to locate package php7.4-redis E: Couldn't find any package by glob 'php7.4-redis' E: Couldn't find any package by regex 'php7.4-redis' E: Unable to locate package php7.4-bcmath E: Couldn't find any package by glob 'php7.4-bcmath' E: Couldn't find any package by regex 'php7.4-bcmath' E: Unable to locate package php7.4-ldap E: Couldn't find any package by glob 'php7.4-ldap' E: Couldn't find any package by regex 'php7.4-ldap' E: Unable to locate package php7.4-gd E: Couldn't find any package by glob 'php7.4-gd' E: Couldn't find any package by regex 'php7.4-gd' E: Unable to locate package php7.4-pgsql E: Couldn't find any package by glob 'php7.4-pgsql' E: Couldn't find any package by regex 'php7.4-pgsql' E: Unable to locate package php7.4-mysql E: Couldn't find any package by glob 'php7.4-mysql' E: Couldn't find any package by regex 'php7.4-mysql' E: Unable to locate package php7.4-xmlrpc E: Couldn't find any package by glob 'php7.4-xmlrpc' E: Couldn't find any package by regex 'php7.4-xmlrpc' E: Unable to locate package php7.4-intl E: Couldn't find any package by glob 'php7.4-intl' E: Couldn't find any package by regex 'php7.4-intl' E: Unable to locate package php7.4-xml E: Couldn't find any package by glob 'php7.4-xml' E: Couldn't find any package by regex 'php7.4-xml' E: Unable to locate package php7.4-bz2 E: Couldn't find any package by glob 'php7.4-bz2' E: Couldn't find any package by regex 'php7.4-bz2' [stderr]
Looks like no PHP 7.4 on that repo?
Also did a small test (new installation) with a minimal setup, and also this cant start because of the same error

`Support for Ubuntu 18.04 was removed from Ondřej Surý's PPA on June 15, 2023 as that version of Ubuntu is no longer supported. As per the description on the PPA landing page:
... Only Supported Versions of PHP (http://php.net/supported-versions.php) for Supported Ubuntu Releases (https://wiki.ubuntu.com/Releases) are provided. Don't ask for end-of-life PHP versions or Ubuntu release, they won't be provided.
`
This template is now useless as it uses outdated Ubuntu and PHP that no one wants to support :/


Update claimtrie CLI to support other tools

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.009%) to 51.806%

Files with Coverage Reduction
New Missed Lines
%

peer/peer.go
3
75.92%

Totals

Change from base Build<PHONE_NUMBER>:
0.009%

Covered Lines:
22351

Relevant Lines:
43144

💛  - Coveralls


improve handling for ajax errors

If an ajax/json request results in an error HTTP response code, the current behaviour is to log the error to console, but the end user just gets an empty select list.
It would be good to be able to display an error message to the end user in this situation.
I'm imagining a jsonErrorMessageField option, so that I can craft my error response to contain the message to be displayed...?

...or something like this, which allows developer to handle their own errors?
onAjaxError(function(XHR, textstatus){});

@zellerda if you can give me some guidance as to which direction to take (or another), I'm happy to do the initial work and submit a pull request...

Hi thanks for your proposition, I have implemented in the last commit, is it what you want ?

That's perfect, love your work and your responsiveness!


[Issue: 2821] Metadata export script help clarifications

References

Fixes https://github.com/DSpace/DSpace/issues/2821

Description
There was a bug in the help function of the metadata export scripts leading admins to believe that a server path is needed on where to store the file. But this argument is to be used as a filename for the REST call.
Instructions for Reviewers
Retrieve the help instructions from REST & CLI, these will now properly explains what the "--file" flag does.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[X] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[X] My PR passes Checkstyle validation based on the Code Style Guide.
[X] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[X] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[X] If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[X] If my PR modifies the REST API, I've linked to the REST Contract page (or open PR) related to this change.

Closing in favor of: https://github.com/DSpace/DSpace/pull/2924


i want to make a great documentation for this webpage...since,the purpose should be clear to the visiters through readme ..please assign me this.

I would like to contribute to this issue. Please assign me this task under GSSOC'23.


fix(type): Make iterators compatible with TS 5.6 --target ESNext

Summary
Use ReturnType<> to avoid explicitly naming the types of builtin iterators that have changed in 5.6, and convert manually implemented iterators to generators so they are compatible with builtin iterators under --target ESNext.

Fixes part of #8277.

Checklist

[x] Tests updated (or not required).
[x] Documentation updated (or not required).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Spanish] localize 'Transport Layer Security (TLS)'

Describe your changes
[Spanish] localize 'Transport Layer Security (TLS)'
Related issue number or link (ex: resolves #issue-number)
Fixes #1780
Checklist before opening this PR (put x in the checkboxes)

[X] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[X] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@Ambareen09 thanks for contributing for the translation of the glossary to Spanish. There are some considerations to consider which are described in the Contribution guide. Don't hesitate to contact us in slack channel.

Thanks for reviewing, made the changes!


--update userwidget feature

I encountered a problem with the EditAccountInfo component. Currently, when a user attempts to update their details through the form, the changes are not being accepted or reflected as expected.

Your approach to the code isn't quite right, and using context here isn't necessary. It seems like you didn't fully understand the existing code structure. Please take another look at the requirements and the current setup to ensure your changes align with what's needed. Additionally, restore the comments that explain the code, like those in User.jsx, as they are important for code clarity and maintenance.

I encountered a problem with the EditAccountInfo component. Currently, when a user attempts to update their details through the form, the changes are not being accepted or reflected as expected.

For now, please focus on optimally fetching the user's name. As for the location, just write the logic for fetching it, since the form's Redux store is still under construction.


Added support for VCL theme aware

Added support for VCL Theme Awareness option and updated Delphi 12 DPR/DPK to compile those changes.

Hy Lance, thank for your contribution, but I don't understand why you implemented this feature, since normally a StyledButton already uses the style of the active VCL, if no alternative style is set to "Classic/Windows/Normal" (or the AsVCLComponent is set to True). Please explain me what do you need.


JAVA Solution for Merge in Between Linked Lists | GSSOC'21

💥 Proposal
(A clear and concise description of what the proposal is.)
I am looking to work on Leetcode problem Merge in Between LinkedList using JAVA for GSSOC'21.
Proposal in Brief:
Problem: Merge in Between LinkedList
Problem Source: Leetcode
Language: JAVA
Submission for Open Source Program: GSSOC'21
Have you read the Contributing Guidelines on Pull Requests?
Yes.

/assign

JAVA solution for Merge in between linked lists


delimiter options

It seems that the default delimiter used is  (space).
I'm using the logfmt parser in fluent-bit, but have a use case where i need the delimiter to be ,  (comma space).
Is this a built-in functionality of the logfmt package?
Below is a sample log file which contains a message field inside the json array
{"timestamp":"2021-05-26T20:45:08.751Z","sequence":568,"loggerClassName":"org.jboss.logging.Logger","loggerName":"org.keycloak.events","level":"WARN","message":"type=LOGIN_ERROR, realmId=master, clientId=ui, userId=92cdda0b-28b4-46df-8f81-48458708eb48, ipAddress=<IP_ADDRESS>, error=invalid_user_credentials, auth_method=openid-connect, auth_type=code, redirect_uri=https://centralus-v2.mydomain.com/signin, code_id=f8d8be37-eb0e-40cc-a507-db5862cd0719<EMAIL_ADDRESS>authSessionParentId=f8d8be37-eb0e-40cc-a507-db5862cd0719, authSessionTabId=pvMeYvDFhU4","threadName":"default task-2","threadId":147,"mdc":{},"ndc":"","hostName":"keycloak-b9576f6db-np5dx","processName":"jboss-modules.jar","processId":617}

I am in a the same situation but with semicolon space instead of comma space. Still looking for an answer.

Works for me:

create lua script for replace comma by none (path: keycloak_output.lua):

function stringToLogFmt(tag, timestamp, record)
    local new_record = {}

    for key, value in pairs(record) do
        new_record[key] = value
    end

    new_record["message"] = record["message"]:gsub(",","")

    return 2, timestamp, new_record
end

add logfmt parser:

[PARSER]
    Name              keycloak_output_message_logfmt
    Format            logfmt

add lua and parser filters:

[FILTER]
    Name               lua
    Match              keycloak_output.tag
    script             keycloak_output.lua
    call               stringToLogFmt

[FILTER]
    Name               parser
    Match              keycloak_output.tag
    Key_Name           message
    Parser             keycloak_output_message_logfmt
    Reserve_Data       On
    Preserve_Key       On


Add zombie-event option to debug leaked Http2ClientSessions.

Debugging option.  If you enable the feature, it will schedule zombie events when one but not both of the Session shutdown requirements is set.  If the zombie event goes off (presumably long after the session should have finished cleaning up), the traffic server process will assert.
This has been incredibly useful in debugging some Http2ClientSession clean scenarios (more PR's to come).

[approve ci autest]


Submit the search form if no result is selected

@howdu thanks for this!
Makes sense to remove the .prevent and call that manually. Is there a way that logic can be inside the enter() method? I feel that would keep the markup cleaner. Then this.selected would also be accessible, so wouldn't need the getter.
Any chance you could add a test for this? If not, I will try and have a look at both of these later in the week.

@joshhanley no worries - I've updated so that the event is passed to enter function.
Sorry I'm not sure how to write the test for it.

@howdu thanks, looks good! No worries, I will add a test for it.

@howdu thanks! Have tagged a release v0.1.9 with your changes 🙂


feat: Updating Python runtime to use Python SDK

This PR is dependent on #211. That one should be merged first, and this one next.
The build should work after being merged to main branch, as proved by this GH Action build: https://github.com/domderen/argo-dataflow/actions/runs/1107787084

I think the needs rebasing?

Yup, it's rebased now.


Fixing CLAHE crash with pixels value > 12 bit

Resolves #5953 bug
What does this PR change?
There is no CLAHE crash for images with pixels value > 12 bit.
CLAHE outputs for 16 bit image and 16 bit image being transformed to 8 bit the same.

thanks! :+1:

@belgraviton : We just used the latest OpenCV 3.1 to process certain 16bit grayscale Tiff images, but the processing results looked very bad, and not acceptable.  I can't to post my images here, but would send them to you in private.  Could you see if you can process these few images 'correctly' to give satisfactory CLAHE results?  Thanks in advance.

@CelerityAbbottPC You can use my email in profile.


MRG: Store NIRx location data in meters

What does this implement/fix?
Stores the NIRx sensor location data in meters (as specified for 3d locations here)
Details

A test recording was completed as described: https://github.com/mne-tools/mne-testing-data/pull/51
In step 4 of this test recording a figure was taken that shows the location of the detectors in the vendor software (in millimeters)
This PR tests that the values read by MNE match the values in the vendor software (but converted to meters)

Note
The values displayed in the vendor software are in mm. However, the values stored with the recordings are in cm (I have confirmed this with the company technical support). And MNE expects m.

@rob-luke this code:
import mne
data_path = mne.datasets.testing.data_path()
subjects_dir = mne.datasets.sample.data_path() + '/subjects'
raw = mne.io.read_raw_nirx(data_path + '/NIRx/nirx_15_2_recording_w_short')
mne.viz.plot_alignment(
    raw.info, show_axes=True, subject='fsaverage', trans='fsaverage',
    subjects_dir=subjects_dir, verbose=True)

Now produces:

You can see that the points are on the head (good) and that the head and MRI coordinate frames are correct (good). There are a few points that are quite far away to the subject's right, though -- is this correct/expected?

Thanks @larsoner! I loaded a bunch of other montages and they all look great.
I investigated that point that is slightly off the head by looking at other montages I have with more channels in that same area. All the other points sit nicely on the head. The one that is off the head looks to be over a recessed section near the ear. I have tried to capture this in the image below (look at the red dot on the left of the image ). It could be that because the channel is defined as the half way point between a source and detector, that it can then float in space if their is a recess in the head.

So I think this looks great and will change the title to MRG. I am looking forward to uploading some more interesting montages to make testing things like this easier.

@rob-luke you need to fix merge conflict

I have uploaded another test dataset here.: https://github.com/mne-tools/mne-testing-data/pull/52
And running @larsoner code above on this new data I get this image, which matches well with the vendor images

Thanks @rob-luke, feel free to add tests with the new dataset (as necessary) in the next PR


Node configuration documentation

In GitLab by @franzi233 on Aug 18, 2021, 10:47
Finish the documentation of how to configure the different nodes (Validator, Gateway, Observer, Client).

In GitLab by @franzi233 on Aug 18, 2021, 10:48
marked this issue as related to #1

In GitLab by @franzi233 on Aug 30, 2021, 11:14
changed due date to September 01, 2021

In GitLab by @franzi233 on Oct 4, 2021, 12:07
created merge request !1 to address this issue

In GitLab by @franzi233 on Oct 4, 2021, 12:07
mentioned in merge request !1


use of any

What version of kubb is running?
2.0.0-beta.8
What platform is your computer?
linux
What version of external packages are you using(@tanstack-query, MSW, React, Vue, ...)
"dependencies": {     "@aws-crypto/sha256-js": "^2.0.0",     "@codemirror/autocomplete": "^6.4.0",     "@codemirror/language": "^6.3.2",     "@codemirror/legacy-modes": "^6.3.1",     "@codemirror/lint": "^6.1.0",     "@codemirror/search": "^6.2.3",     "@codemirror/state": "^6.2.0",     "@codemirror/theme-one-dark": "^6.1.0",     "@codemirror/view": "^6.7.1",     "@lezer/common": "^1.0.2",     "@lezer/highlight": "^1.1.3",     "@nxmix/tokenize-ansi": "^3.0.0",     "@open-amt-cloud-toolkit/ui-toolkit-react": "2.0.0",     "@reach/combobox": "^0.16.5",     "@reach/dialog": "^0.17.0",     "@reach/menu-button": "^0.16.1",     "@reach/popover": "^0.18.0",     "@tanstack/react-table": "^8.8.5",     "@tippyjs/react": "^4.2.6",     "@uirouter/angularjs": "1.0.11",     "@uirouter/react": "^1.0.7",     "@uirouter/react-hybrid": "^1.0.4",     "@uiw/codemirror-themes": "^4.19.9",     "@uiw/react-codemirror": "^4.19.5",     "angular": "1.8.2",     "angular-clipboard": "^1.6.2",     "angular-file-saver": "^1.1.3",     "angu
What steps can reproduce the bug?
I'm using the typescript plugin, and my tsconfig prevents the use of any, while the generated code is full of use of any and other errors.
some of the errors are fixable using eslint --fix and prettier. but the use of any is not fixable.
also, worth mentioning the need of installation of @kubb/swagger-client
How often does this bug happen?
None
What is the expected behavior?
No response
Swagger/OpenAPI file?
No response
Additional information
No response

I was talking about the error types:
export type AuthenticateUser400 = any | null;

what is their use? won't typescript just show "any" anyway? it's not like we can do some type narrowing anyway, because they're all just any | null
another place I see the use of any is inside useQuery generics. why do we need them? why not use type inference?
in our own code we have useQuery({...}) I never have to type the generics


[Parse] 'super' requires following l-square

Follow-up to #25787 .
super must be followed by period, period_prefix, or l_square on the same line. i.e.
super
[0]

is invalid.

@swift-ci Please smoke test


windows/msvc: export stdio file descriptor numbers

These are useful for using in dup2 arguments, for example.
They are probably valid for every compiler but here it is in Microsoft example: https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/fileno?view=msvc-170#example

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.
Please see the contribution instructions for more information.

Well, MSVC apparently doesn't declare such constant. MSDN suggests to use fileno(stdin) instead.

We don't expose anything in the libc crate that isn't exposed by the underlying libc. This is checked by our CI, which is failing now because MSVC doesn't expose these constants.
In this case you should probably just hardcode the file descriptor numbers 0, 1 and 2 in your code directly.


Adding vertical spacing to notifications

There is a current issue with a vertical spacing of notifications. This
commit adds it temporarily but ideally the component itself should be
adding the margin spacing it requires.

Error messages look good:

Confirmation banner with action looks 👍