Very strange issues since F41

Hi,
I realize this is not really a technical bug report, so please forgive me for this. The issues that I'm encountering are just weird to me, and I'm unable to start diagnosing properly so I resort to just telling the symptoms.
Currently I'm using a Acer laptop with Nvidia card. I have been really happily using Bazzite for a year I think, and never encountered issues and was really enthusiastic about Bazzite since it's so rock solid.
Lately though, and it started happening since the update to F41, I've been having strange issues. I'm sorry that I'm unable to give logs or anything, because the issues are really strange. What I mean is, I would give logs but I'm unable to start figuring out what causes these strange things.
Stuff like:

Applications not responding
The applications not responding, freezing my OS
When the laptop is put to sleep, the laptop starts booting but there's only a black screen but my mouse is visible and usable. (I try to go into terminal 2 by CTRL+ALT+F1/F2/F3 or CTRL+ALT+1/2/3 but this doesn't work.)
After sleep, logging in is impossible; I have a login windows showing up, but when I input my password, nothing happens. Buttons respond to input (hover and click changes the button graphics). After 30 seconds, it tells me "Unlocking failed".
Unable to launch my terminal; Plasma reacts and shows the "loading" cursor, then after 1 minute, I get a system notification that the app "launch-terminal" did not respond.
Applications randomly shutting down; no indication, just windows disappears. When checking system monitor, process is gone.

The issues were so strange that I figured, maybe my hard drive is dieing. The SMART status says it's working as expected however.
I figured I'd wait a bit and keep daily updating so that maybe my issues would be resolved, however I'm a bit fed up at the moment so I rebased to stable-40 for now.  Pointers to start diagnosing my issues? If anything comes to mind, please let me know. I would like to be on latest stable, but for now I get too annoyed by constantly force-powering my PC off, but I also don't only wanna complain, I'd like to help to resolve issues I (and maybe others) might encounter.
Thank you very much for this project, I'm a huge fan! Please, if there's anything I can do to contribute, I'll try (just about) anything to get more information.

Hi, do you still have this issue?
'Rollback and/or rebase and wait' is a valid and correct workaround for a broken update. Sometimes it takes up to a few weeks for the latest update to fix whatever the issue is, especially with Nvidia hardware. The great thing about Bazzite / Atomic is that you can rebase back to a working image until then.
That does look like a relatively large number of layered packages, albeit ones which may need to be layered. Each one adds a degree of uncertainty to updates. If you can do so without breaking anything important, it may be worth pinning your working image, then performing an rpm-ostree reset to remove all layered packages from a new deployment, rebasing that new deployment to F41, then testing whether the updated image with nothing layered works properly, then perhaps chasing down which exact package may be causing problems, if any.
To check another hunch, were you using X11 or Wayland on F40? F41 is Wayland-only, which is now mostly-there but a semi-random assortment of Nvidia hardware/firmware/etc can still have issues.
Also, having Nvidia hardware myself (16xx/20xx+), I was informed by maintainers a while back that I should rebase to bazzite-(gnome-)nvidia-open since the non-open drivers are now somewhat legacy-only. For right now it may or may not make a difference.


Error with 20.2.0 in singularity: AttributeError: type object 'loggers' has no attribute 'warning'

This fails with 20.2.0, but works fine with 20.1.1 (~or at least, it doesn't crash at the same point~ EDIT: 20.1.1 finished perfectly).
What version of fMRIPrep are you using?
20.2.0
What kind of installation are you using? Containers (Singularity, Docker), or "bare-metal"?

BIDS dataset is valid.
201005-23:19:20,86 nipype.workflow IMPORTANT:

    Running fMRIPREP version 20.2.0:
      * BIDS dataset path: /data/ucsf/test-sequences-atl/data/bids-new.
      * Participant list: ['01'].
      * Run identifier: 20201005-231828_b61e5695-5d3f-4ec6-86d4-1499c10e21d9.
      * Output spaces: anat fsaverage:den-164k.
      * Pre-run FreeSurfer's SUBJECTS_DIR: /data/ucsf/test-sequences-atl/data/derivatives/freesurfer.
201005-23:19:21,476 nipype.workflow INFO:
         Using single-band reference file(s) sub-01_ses-01_task-rest_acq-cmrrbold2p2mmmb6_dir-AP_run-10_sbref.nii.gz.
201005-23:19:22,681 nipype.workflow IMPORTANT:
         Slice-timing correction will be included.
201005-23:19:23,3 nipype.workflow INFO:
         Using single-band reference file(s) sub-01_ses-01_task-rest_acq-cmrrboldalmsemanticvis2p2mmmb4_dir-AP_run-13_sbref.nii.gz.
201005-23:19:24,68 nipype.workflow IMPORTANT:
         Slice-timing correction will be included.
201005-23:19:24,362 nipype.workflow INFO:
         Using single-band reference file(s) sub-01_ses-01_task-rest_acq-ipat2_dir-AP_run-06_sbref.nii.gz.
201005-23:19:24,961 nipype.workflow IMPORTANT:
         Slice-timing correction will be included.
Process Process-2:
Traceback (most recent call last):
  File "/usr/local/miniconda/lib/python3.7/multiprocessing/process.py", line 297, in _bootstrap
    self.run()
  File "/usr/local/miniconda/lib/python3.7/multiprocessing/process.py", line 99, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/miniconda/lib/python3.7/site-packages/fmriprep/cli/workflow.py", line 84, in build_workflow
    retval["workflow"] = init_fmriprep_wf()
  File "/usr/local/miniconda/lib/python3.7/site-packages/fmriprep/workflows/base.py", line 64, in init_fmriprep_wf
    single_subject_wf = init_single_subject_wf(subject_id)
  File "/usr/local/miniconda/lib/python3.7/site-packages/fmriprep/workflows/base.py", line 304, in init_single_subject_wf
    func_preproc_wf = init_func_preproc_wf(bold_file)
  File "/usr/local/miniconda/lib/python3.7/site-packages/fmriprep/workflows/bold/base.py", line 167, in init_func_preproc_wf
    config.loggers.warning(
AttributeError: type object 'loggers' has no attribute 'warning'

Are you reusing previously computed results (e.g., FreeSurfer, Anatomical derivatives, work directory of previous run)?
Nope

Thanks for the report, this is a silly typo that will be fixed in #2298 and then we'll cut a new release 👍

Sorry to bother about this, but do you guys have a planned date for a new release? I have a dataset with me-epi with both two and three echoes, and I have to use fmriprep 2.1.3 to analyze. But you guys added so many new goodies in 2.2.0 that I really want to use the new version ;) I tried pulling the unstable version but it's not synced with master.

You're probably looking at poldracklab/fmriprep:unstable. Switch to nipreps/fmriprep:unstable.

I did pull yesterday from nipreps/fmriprep:unstable, but it was pointing to a previous commit, not master. I'm trying to pull again and see if I can replicate.

Oh, we might need to rerun something.

OK then the docker image was pointing to master but I needed maint then ;) thanks for checking!

Merged into master, so the fix should be there. I think all additional changes in current master are compatible with 20.2.x, so it shouldn't be a problem to reuse working directories between this upcoming unstable and the 20.2.1 release.

thank you!! 🎉

Closing since this will be in the next release.

When will 20.2.1 be released to dockerhub? I don't see 20.2.1 on https://hub.docker.com/r/poldracklab/fmriprep/tags?page=1&ordering=last_updated

It moved to nipreps/fmriprep.


Update numexpr

With @jgoodrich I saw this:
/nsls2/conda/envs/2023-3.1-py310-tiled/lib/python3.10/site-packages/pandas/core/computation/expressions.py:21: UserWarning: Pandas requires version '2.8.0' or newer of 'numexpr' (version '2.7.3' currently installed).
  from pandas.core.computation.check import NUMEXPR_INSTALLED

The first 2.8.x release was in December 2021. Something must be holding numexpr back. Does this ring a bell, @mrakitin?

We should try a newer pin and see what happens.

It's addressed via #24.


Recommended Setup until Rehydration is Possible

Hi !
I'm looking at using Fastboot for an upcoming build - because strong SEO & metatags is a must.  Until Rehydration is working - is there a recommended way of handling the routing:
--> "hi request, you're a crawler, go to my fastboot server for an index.html"
--> "hi request, you're a browser, here's my real app server that will give you an index.html"
Or is this an exercise best left to the developer?  Working on the infra stuffs :+1:
Thankyou!!

@hhff I do that via nginx configuration, as it acts like a proxy in between request & fastboot or prerender. Check user agent and pass to respective backend.

@tylr is doing this for Bustle, he can probably give you the details on how to detect the Googlebot.

Thanks both - would love some pointers on the finer points of Fastboot SEO & Infra.  Bustle is for sure killing it in that world
Sitemap / Full site crawling tips welcome too!!
Will be happy to contribute my findings back to the repo as docs!

server {
   ...
   location / {
          try_files $uri @prerender;
        }

        location @prerender {
          set $prerender 0;
          if ($http_user_agent ~* "googlebot|bot|bingbot|adsbot-google|mediapartners-google|baiduspider|twitterbot|facebookexternalhit|rogerbot|linkedinb$
            set $prerender 1;
          }
          if ($args ~ "_escaped_fragment_") {
            set $prerender 1;
          }
          if ($http_user_agent ~ "Prerender") {
            set $prerender 0;
          }
          if ($uri ~ "\.(js|css|xml|less|png|jpg|jpeg|gif|pdf|doc|txt|ico|rss|zip|mp3|rar|exe|wmv|doc|avi|ppt|mpg|mpeg|tif|wav|mov|psd|ai|xls|mp4|m4a|swf$
            set $prerender 0;
          }

          #resolve using Google's DNS server to force DNS resolution and prevent caching of IPs
          resolver <IP_ADDRESS>;

          if ($prerender = 1) {
            #setting prerender as a variable forces DNS resolution since nginx caches IPs and doesnt play well with load balancing
            set $prerender "**prerender.website-url.com:3000**";
            rewrite .* /https://$host$request_uri? break;
            proxy_pass http://$prerender;
          }
          if ($prerender = 0) {
            rewrite .* /index.php;
          }
        }
   ...
}

@hhff this is how I do it with nginx & prerender. It could be similar later on with fastboot

amazing @RuslanZavacky !

While Bustle still uses _escaped_fragment_, you shouldn't use it for new projects and we're migrating away from it as soon as possible.
Google has officially deprecated and dropped support for it and encourages you not to use it.
See here: https://googlewebmastercentral.blogspot.com/2015/10/deprecating-our-ajax-crawling-scheme.html
We do however use (read: need) server-side rendering for social media bots and services. We're also investigating ways of serving a non-rehydratable DOM / skeleton to browsers if we can perfect the re-draw when the app actually boots and provide a satisfactory UX. Which might make use out of it pre-rehydration.
If you want good google SEO, simply follow their best practices and submit a sitemap to webmaster tools.

Gonna close this for now but we should definitely make sure we put some "Best Practices" documentation together. @hhff maybe you can tackle this once you've tried it out. :)

totally, will do!
feel like having a static full-page loader in the non-rehdratable skeleton HTML and then pulling the loader away shortly after a full-redraw might be a good half-step for this.

@RuslanZavacky ... I'm just curious.. Have you noticed any ill effects from serving the pre-rendered HTML to the googlebot.. According to google docs, you should serve them the same content as your users.
Prerender.io recommend that you don't serve the pre-rendered HTML, as you can see if their config here
I would love to serve them up the pre-rendered HTML from prerender.io as it renders so much faster.

@ianpetzer my solution is a bit more complicated, than just serving simple HTML. I store static HTML until I do any changes or information of specific page changes. If for example, I change information on 1 page, I schedule it for HTML cache update. So I am always trying to keep HTML cache up to date. My next improvements would be to place Varnish in front of prerender (or fastboot) so Varnish cache everything, instead I do it manually :)
There is a potential risk, but it mainly relates to the popups, modal windows jumping over, or content disappearing. Like if you want to boost your SEO, you show Google totally different content. In our case, its fine, because we are not doing anything bad :)


Feature Request: Add specific cards to "your collection"

Hi, love your X-Wing squad builder!
Wondering if it would be possible to add a way to include cards bought/traded outside of the ship expansions? I've bought several cards from ebay, and it would be really useful to have them not show "you cannot field this list with your collection".
Many thanks :)

This is a good idea but will take some time to implement; hopefully I can start on this once other things die down (I have some busy weeks coming up).


Bug: Loading Button Sizing Problems

Describe the bug
When using a clarity button with [clrLoading] the initial width is not wide enough.

After it stops loading it adjusts to the correct size.
But if it starts loading again the spinner icon contains an unexpected ellipsis.

How to reproduce
https://stackblitz.com/edit/clarity-v4-loading-button
Steps to reproduce the behavior:

Go to https://stackblitz.com/edit/clarity-v4-loading-button
See the cut spinner icon
Click 'Stop Loading' & 'Start Loading'
See '...' behind loading spinner

Expected behavior

button should have initial min width of spinner icon
in loading state the spinner icon should be shown without ellipsis

Additional Notes
Maybe it would help to set a min-width for the initial state:
https://github.com/vmware/clarity/blob/next/packages/angular/projects/clr-angular/src/button/button-loading/loading-button.ts#L105
Maybe the ellipsis text-overflow can be disabled for .btn-icon.

I could confirm that this bug is still active even with the latest version
    ...
    "@angular/animations": "~12.0.2",
    "@angular/common": "~12.0.2",
    "@angular/compiler": "~12.0.2",
    "@angular/core": "~12.0.2",
    "@angular/forms": "~12.0.2",
    "@cds/city": "^1.1.0",
    "@cds/core": "^5.4.0",
    "@clr/ui": "^5.4.0",
    "@clr/angular": "^5.4.0"
    ...

Even with changing the expected type from boolean to ClrLoadingState the issue persist
isLoading$ = new BehaviorSubject<ClrLoadingState>(ClrLoadingState.LOADING);

I think that because of the state change in the middle of the render cycle we don't calculate or set the correct width of the button.
style="width: 26px;transform: translateZ(0px);"

The width is set from this method:
  private setExplicitButtonWidth() {
    if (this.el.nativeElement && this.el.nativeElement.getBoundingClientRect) {
      const boundingClientRect = this.el.nativeElement.getBoundingClientRect();
      this.renderer.setStyle(this.el.nativeElement, 'width', `${boundingClientRect.width}px`);
    }
  }

There is also an animation that is triggered at the beginning,
 trigger('spinner', [
      transition(':enter', [style({ opacity: 0 }), animate('200ms 100ms ease-in', style({ opacity: 1 }))]),
      transition(':leave', [style({ opacity: 1 }), animate('100ms ease-out', style({ opacity: 0 }))]),
    ]),

My guess here is that boundingClientRect.width is called at the beginning of the render when the button is only a simple box without the spinner inside - after that, the animation will continue but now the width will be wrong.


az recommendation list --refresh command failed

It happens all the time I try to execute this command.
Command Name
az advisor recommendation list --refresh
Errors:
The command failed with an unexpected error. Here is the traceback:
Session.request() got an unexpected keyword argument 'raw'
Traceback (most recent call last):
  File "/opt/az/lib/python3.10/site-packages/knack/cli.py", line 233, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 663, in execute
    raise ex
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 697, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 333, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/advisor/custom.py", line 13, in list_recommendations
    _generate_recommendations(client)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/advisor/custom.py", line 152, in _generate_recommendations
    response = client.generate(raw=True)
  File "/opt/az/lib/python3.10/site-packages/azure/mgmt/advisor/operations/_recommendations_operations.py", line 84, in generate
    pipeline_response = self._client._pipeline.run(request, stream=False, **kwargs)
  File "/opt/az/lib/python3.10/site-packages/azure/core/pipeline/_base.py", line 211, in run
    return first_node.send(pipeline_request)  # type: ignore
  File "/opt/az/lib/python3.10/site-packages/azure/core/pipeline/_base.py", line 71, in send
    response = self.next.send(request)
  File "/opt/az/lib/python3.10/site-packages/azure/core/pipeline/_base.py", line 71, in send
    response = self.next.send(request)
  File "/opt/az/lib/python3.10/site-packages/azure/core/pipeline/_base.py", line 71, in send
    response = self.next.send(request)
  [Previous line repeated 2 more times]
  File "/opt/az/lib/python3.10/site-packages/azure/mgmt/core/policies/_base.py", line 47, in send
    response = self.next.send(request)
  File "/opt/az/lib/python3.10/site-packages/azure/core/pipeline/policies/_redirect.py", line 158, in send
    response = self.next.send(request)
  File "/opt/az/lib/python3.10/site-packages/azure/core/pipeline/policies/_retry.py", line 446, in send
    response = self.next.send(request)
  File "/opt/az/lib/python3.10/site-packages/azure/core/pipeline/policies/_authentication.py", line 119, in send
    response = self.next.send(request)
  File "/opt/az/lib/python3.10/site-packages/azure/core/pipeline/_base.py", line 71, in send
    response = self.next.send(request)
  File "/opt/az/lib/python3.10/site-packages/azure/core/pipeline/_base.py", line 71, in send
    response = self.next.send(request)
  File "/opt/az/lib/python3.10/site-packages/azure/core/pipeline/_base.py", line 71, in send
    response = self.next.send(request)
  [Previous line repeated 1 more time]
  File "/opt/az/lib/python3.10/site-packages/azure/core/pipeline/_base.py", line 103, in send
    self._sender.send(request.http_request, **request.context.options),
  File "/opt/az/lib/python3.10/site-packages/azure/core/pipeline/transport/_requests_basic.py", line 327, in send
    response = self.session.request(  # type: ignore
TypeError: Session.request() got an unexpected keyword argument 'raw'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

simply executing the command again
az advisor recommendation list --refresh

Expected Behavior
To do not fail.
Environment Summary
Linux-5.14.0-1051-oem-x86_64-with-glibc2.35, Ubuntu 22.04.1 LTS
Python 3.10.8
Installer: DEB

azure-cli 2.43.0

It happens if I open Cloud Shell on azure portal, in bash and powershell as well.

Additional Context

@ZoltanKoczan Can you please refer to the recommendations provided over here.

/unresolve

Hello,
I'm sorry for the late reply, but I've tried that already (even before opening this ticket), but it's not working:
$ az rest --method POST --uri https://management.azure.com/subscriptions/XXXXXXXXXXXXX/providers/Microsoft.Advisor/generateRecommendations?api-version=2020-01-01 Bad Request({"error":{"code":"InvalidSubscriptionId","message":"The provided subscription identifier 'XXXXXXXXXXXXX' is malformed or invalid."}})
The problem occurs on Azure portal Chell as well.

@ZoltanKoczan By looking at the error it looks like the subscriptionid which you are passing is not correct.  Can you please check and pass the correct subscription id.  I have tried the az rest command with above shared URI and it worked https://management.azure.com/subscriptions/{subscriptionid}/providers/Microsoft.Advisor/generateRecommendations?api-version=2020-01-01

It has worked! I really appreciate your help!
Thank you!

@ZoltanKoczan No problem.  Glad it worked out for you.
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


no error on unkown variable of interface

TypeScript Version:  2.1.5
Code
interface ProductionRecord {
  _id: string,
  productName: string;
  price: number;
  quantityProduced: number;
}

type ProductionRecords = ProductionRecord[];

interface ProductionRecordsState {
  records: ProductionRecords
}

const initialState: ProductionRecordsState = {
  records: [],
  test:"my test string"
};

Expected behavior:
vscode or tsc should give error about defining unknown attribute test
Actual behavior:
no error at all when defining the initialState. but it gives error when access the variable :
// it give error when use it, it says: can not find ``test`` in type ``ProductionRecordsState``
const test = initialState.test;

same issue

But in fact the entity that implements the interface must contain all of its properties. But it not disallowed to have others.

@vasa-c it's not true, otherwise, when accessing the variable test, vscode or tsc wouldn't show errors.
in your case, interface ProductionRecordsState must be defined as:
interface ProductionRecordsState {
  records: ProductionRecords
  [key:string]:any;
}

in your case, interface ProductionRecordsState must be defined as:

It solves second problem, initialState.test will not throw error. :)
But
{
  records: [],
  test:"my test string"
};

It object implements ProductionRecordsState and in additional has property test

anyway, the old behaviour, and I think it was the correct one, is you must define exactly the same attributes of an interface. if not. what's the meaning of implementing [key:string]:any ?
if interface ProductionRecordsState  is:
interface ProductionRecordsState {
  records: ProductionRecords;
}

this must throw error
const initialState: ProductionRecordsState = {
  records: [],
  test:"my test string"
};

the only way of preventing error is by defining like this:
interface ProductionRecordsState {
  records: ProductionRecords;
  [key:string]:any;
}

@gitawego tested on http://www.typescriptlang.org/play/index.html and it throws error as expected.

@hxuanhung don't know which typescript version is in the playground.


Add tests to TestMatchers

This commit adds a number of tests to TestMatchers that asserts some of the more nuanced behavior when parsing label matchers.

Thank you very much for this contribution.


Bump Lightning Cloud to 0.5.51

What does this PR do?

Fixes #<issue_number>

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

:books: Documentation preview :books:: https://pytorch-lightning--18962.org.readthedocs.build/en/18962/

cc @borda

We're getting what seems like a circular import issue when building lightning-cloud 0.5.51 in conda-forge - https://github.com/conda-forge/lightning-cloud-feedstock/pull/21#issuecomment-1799770988. Anyone know what changed recently?


No module named metric_learn

thanks for your work, when I use softmax example, I find this error"Traceback (most recent call last):
File "softmax_loss.py", line 12, in
from reid import datasets
File "/home/yuepan/code/pytorch_open_reid/reid/init.py", line 7, in
from . import metric_learning
File "/home/yuepan/code/pytorch_open_reid/reid/metric_learning/init.py", line 3, in
from metric_learn import (ITML_Supervised, LMNN, LSML_Supervised,
ImportError: No module named metric_learn"
and I find no metric_learn.py in folder

You should install metric-learn first.
pip install metric-learn

thx

@zydou Thank you very much!


Changes in the footer text

On main web page at the footer , in the About us section ->
the word "were" should be changed to "where" .

Thanks for pointing out the issue.

Hello,
I want to work on this issue. Can you assign this task to me?

Sure!


#25: Improve interactions with Time and Date

Closes #25

Codecov Report

Merging #26 (46d5792) into main (5f20287) will increase coverage by 0.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   96.40%   96.74%   +0.33%
==========================================
  Files          40       40
  Lines         334      338       +4
  Branches       66       65       -1
==========================================
+ Hits          322      327       +5
+ Misses         12       11       -1

Impacted Files
Coverage Δ

src/components/SettingsForm/TimeItem.tsx
100.00% <100.00%> (ø)

src/hooks/useGetTime.ts
100.00% <100.00%> (ø)

src/screens/Home/Home.tsx
100.00% <100.00%> (+5.26%)
:arrow_up:

src/utils/time.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f20287...46d5792. Read the comment docs.

Codecov Report

Merging #26 (46d5792) into main (5f20287) will increase coverage by 0.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   96.40%   96.74%   +0.33%
==========================================
  Files          40       40
  Lines         334      338       +4
  Branches       66       65       -1
==========================================
+ Hits          322      327       +5
+ Misses         12       11       -1

Impacted Files
Coverage Δ

src/components/SettingsForm/TimeItem.tsx
100.00% <100.00%> (ø)

src/hooks/useGetTime.ts
100.00% <100.00%> (ø)

src/screens/Home/Home.tsx
100.00% <100.00%> (+5.26%)
:arrow_up:

src/utils/time.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f20287...46d5792. Read the comment docs.


[Event Hubs] Add test for exceeding max listeners on send

For more context refer to https://github.com/Azure/azure-sdk-for-js/issues/3375#issuecomment-515302962

/azp run js - eventhubs-client - tests

/azp run js - eventhubs-client - tests


platformio: 6.0.2 -> 6.1.4

Description of changes

https://github.com/platformio/platformio-core/releases
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 186991 run on x86_64-linux 1

2 packages built:

esphome
platformio


12/11 Crossover Grading Review Ticket

Project WRONG - Crossover Grading Review Ticket

Pages

Home Page: https://nathaniel633.github.io/WRONG/ (buttons link to other pages)
Carousel: https://nathaniel633.github.io/WRONG/2023/11/15/Learning-Carousel_IPYNB_2_.html
Binary Hand Quiz: https://nathaniel633.github.io/WRONG/BinaryKnowledgeTest.html
Number Quiz: https://nathaniel633.github.io/WRONG/2023/09/15/Quiz_IPYNB_2_.html

Video link: https://drive.google.com/file/d/1hK5Y2t-kSYxOn69wNvJhP66ZGkrCRGTJ/view?usp=sharing
Miscellaneous:

In the beginning of the project, we all worked together to envision what the project should look like and created the Canva page seen on the home page and a brief plan in the repository summarizing the parts of the project and who works on what
We also created a separate group chat to discuss the parts of the project and ensure all the parts are done by the due date

Nathan: Carousel

Analytics: https://github.com/Nathaniel633
Issues:

For our Project WRONG where we helped teach binary with the use of hand signs, I primarily worked on the front page index.md with an added index.css that I referenced for styling. In addition to this, I imported the scss from the Teacher Portfolio repository for the Teacher 2.0 Binary Calculator, manipulated the colors and sizing for the buttons, and used that to create the front page buttons. I encountered the issue of the spacing of the buttons, as they would either all be adjacent to one another or all shifted from the center, but I fixed this with the help of a peer from another group by adding the “gap” style. I also wanted the links on the front page to open on a new tab, so I added the href target=“_blank” css to make each link open in a new tab upon click. With the images themselves, I encountered problems with the linking as I had originally saved them as files in our images folder, which was manipulated for the image carousels. To combat this, I uploaded the images to postimage to create permanent links for them, to be saved elsewhere.

Key commits:

https://github.com/Nathaniel633/WRONG/commit/709994c8acd4641b626f73f071f9764bfc7610f1, import sass from teacher portfolio for buttons
https://github.com/Nathaniel633/WRONG/commit/0e96d5aac29e529c2b46be7d9e759a6c287fae7a, add image of canva page and add index to front page

Summary of code:

Grayson: Carousel and Number Quiz

Analytics: https://github.com/Delta760
Issues:

In this code, I created the binary-to-decimal quiz. I had trouble randomizing the questions after clicking the next question button and getting the code to accept 0-31 inputs. I fixed this by using the built-in JavaScript randomizer code. I fixed the input amount problem by creating a library and storing the index as the same value of the binary code.

Key commits:

https://github.com/Nathaniel633/WRONG/commit/09a49c66d36af37b28c787a5677492b63372504e, finished number quiz
https://github.com/Nathaniel633/WRONG/commit/7198125bfeb4ec75f7556ee04994ff6cc84bc6ff, fix carousel issues

Summary of code:

Will: Carousel

Analytics: https://github.com/willbartelt15
Issues:

During my code some of the issues I encountered was figuring out how to make the images pop up in the carousel. It turns out that the image link I was using weren't taking me to the right pathway. I had to update the image links and use an external link to make them pop up. Another Issue I encountered was fixing the cycling function to shuffle between the images. I had to update the code and fix the code that shuffled between slides.

Key commits:

https://github.com/Nathaniel633/WRONG/commit/3651b96ceb1f5646a19c3f40d1bbcda84befbb0f, create carousel code and margins
https://github.com/Nathaniel633/WRONG/commit/87cff97ccef6a616138c57446e10d0b83c5a4e59, add images to carousel

Summary of code:

Jason: Binary Hand Quiz

Analytics: https://github.com/JasonGao76
Issues:

One issue we ran into were the image links not properly linking to the right image. Initially, we attempted to use relative paths but that never worked, even after hours of testing. Thus, I resorted to using outside image uploaders. I first used discord which worked for a week, but then the image links broke and it also wasn't compatible with school wifi, so I had to search for another one. I then looked at Google Photos but the links were massive, so that wasn't practical as well. Finally, I found postimage, and it worked perfectly with a concise link and that's what we used for the rest of project.
When writing the key functionality for the random images script, I encountered numerous problems as this was one of the first times I've coded in Javascript, and the biggest problem was figuring out how to get random indexes for the array. I encountered problems with the math function and spent an hour tracking down the code, variables, and more to figure out how the indexes were made, if they were properly made, and how it grabbed the link and if it did it correctly.
Something we can still work on is making the code less redundant as many of the same procedures are repeated but for different questions, so loops or other methods can be used to reduce the lines of codes

Key commits:

https://github.com/Nathaniel633/WRONG/commit/3004b3409f3dfa19c33bca8eebe61c6bb289f888, created all files and did backbone / key functionality of all, but not debugged or fixed
https://github.com/Nathaniel633/WRONG/commit/b5e64a3bd548d16dc9781d0b073c977233e2bfab, fixed links and polished up quiz

Summary of code:

Rayyan: Binary Hand Quiz

Analytics: https://github.com/RayyanDarugar
Issues:

As me and Jason coded our Binary Picture Quiz, we ran into a bunch of issues to solve. In development, we reviewed all in Jupyter Notebooks. On the Jupyter page, we couldn't get the answer Key function to run from inside of one of our scripts. To fix this, I changed the function to a variable array with answers defined in each line, and migrated the script folder to outside of our _notebooks. Additionally, when we started testing on the GitHub page, for some reason every part of our code broke. It wasn't reading scripts properly, so I troubleshooted for a while until I realized I could fix it by changing from a IPYNB to a .md. From there on out, I just fixed minor styling issues and modified the page to look better.

Key commits:

https://github.com/Nathaniel633/WRONG/commit/94592aee027909d177ab0e14837c0d1a0b5ac476, created group plan
https://github.com/Nathaniel633/WRONG/commit/c5ec40ee074c68292468fc31e18edf89eb52fd8c, fixed key problem with answer key not defining

Summary of code:

 + also shifted everything to anther file

Individual Review "Ryan Liu" grading "Nathan O"

[ ] Individual should show that they were key contributor and example to team.  This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom.

Individuals Video, Issue(s), Commits(s)

[ ] Video in CPT caption style , includes Web demo of key contribution to project, 1 minute
[ ] Issue(s) that show plans/progress to team objectives
[ ] Highlights of key commit(s) in Issues, summarizes code contributions
[ ] Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks

Per check.
0.55 not attempted/no check
0.7 attempted, incomplete, but some runtime
0.8 mastery and runtime
0.9 above and beyond.
Freeform comment.
Provide positives and growth summary.
Justify or comment on final score.
Be sure to provide extra details on anything below 0.7 average or above 0.8.

Individual Review  Hayden Chen grading Grayson Guyot

[ x ] Individual should show that they were key contributor and example to team.  This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom.

Individuals Video, Issue(s), Commits(s)

[ x ] Video in CPT caption style , includes Web demo of key contribution to project, 1 minute
[ x ] Issue(s) that show plans/progress to team objectives
[ x ] Highlights of key commit(s) in Issues, summarizes code contributions
[ x ] Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks

Per check.
0.55 not attempted/no check
0.7 attempted, incoomplete, but some runtime
0.8 mastery and runtime
0.9 above and beyond.
SCORE: 0.86.
Demonstrated mastery and knowledge of algorithms (Fisher-Yates) and showed code well. The website broke for some reason during class, but the video showed proof of the binary to decimal quiz working well and very fast. Growth: could potentially have showed more important commits or created a nicer, aesthetic CSS for the user's eyes.

Individual Review: Srijan Atti grading Jason Gao

[x] Individual should show that they were key contributor and example to team.  This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom.

Individuals Video, Issue(s), Commits(s)

[x] Video in CPT caption style , includes Web demo of key contribution to project, 1 minute
[x] Issue(s) that show plans/progress to team objectives
[x] Highlights of key commit(s) in Issues, summarizes code contributions
[x] Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks

Per check.
0.55 not attempted/no check
0.7 attempted, incomplete, but some runtime
0.8 mastery and runtime
0.9 above and beyond.
Score: 0.85/0.90
Jason exhibited mastery over his portion of the project and displayed high levels of problem solving while overcoming problems such as storing and displaying images. His video was perfect with captions, no audio, and high level descriptions of his code and demos of his project. The project harnessed skills from last trimester such as input checking, output as well as newer skills such as CSS and code cleanliness.

Individual Review Hayden Chen grading Will Bartelt
[ x ] Individual should show that they were key contributor and example to team. This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom.
Individuals Video, Issue(s), Commits(s)
[ x ] Video in CPT caption style , includes Web demo of key contribution to project, 1 minute
[ x ] Issue(s) that show plans/progress to team objectives
[ x ] Highlights of key commit(s) in Issues, summarizes code contributions
[ x ] Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks
Per check.
0.55 not attempted/no check
0.7 attempted, incoomplete, but some runtime
0.8 mastery and runtime
0.9 above and beyond.
SCORE: 0.85.
Carousel code was complete and very impressive. Functional according to the video (broke on the day of review). The key commit was explained well with knowledge of the code, and the carousel JS was completed with functions, indicating good skill. Growth: the screenshotted code was very repetitive and could have been more concise through the use of JS. (just a suggestion)

Team Review Ian grading Rayyan

[ ] The team should have a Web Pages that teach: Binary, Data, Data Structures, Data Abstraction.

Team Review ticket containing key Team and individual contributions

[ ] Growth/Accomplishments in work is according to historical Team Plan, or they show revisions to plan according to work
[ ] Short falls/Improvement that could be made in Work or Team Plan, team highlights next steps or improvements that could be made
[ ] Showing key accomplishments according to requirement in Frontend such as Binary Math, ASCII, Unicode, Color Codes, Logic Gates, etc.
[ ] Showing key user interaction and learning(s).  For instance how you visualized  Algorithms, Data, Data Structures.  Or, how you provided response and Feedback to user on their success in learning.

Per check.
0.55 not attempted/no check
0.7 attempted, incoomplete, but some runtime
0.8 mastery and runtime
0.9 above and beyond.
Comments:
Project was well designed and it is definitely possible to be used to teach binary, which is a key skill. The project contains three pages, each meant to teach binary. Plan is not a post, but placed on homepage, but this works well as a basic explanation of binary. The completed project goes beyond the original plan, and plan was followed well. Video is well made and complete with captions, going into detail about code and demonstrating project. I especially liked how the project, rather than expand and continue into more complicated concepts that applied binary and color codes, etc, instead sought to explain and teach the basics of binary in a way that makes it easier to understand for a new learner. The use of images, while much more complicated to create in terms of code, effectively visualizes binary in a way that makes it easy to follow. On that topic, however, the learn page does not explain what binary is, and rather directly gives practice and matches a number to an image. While this may work for some, an explanation of how binary works would have benefitted the project. Another place for improve is the CSS of the project. While a plan on the homepage works, creating a homepage with links would've looked more appealing, as well as customizing the CSS of the project more to fit the project topic. Overall, even though some minor changes could've improve the website, the website was well designed, and went beyond the requirements of the project.
Score: 0.86/0.9

Individual Review Ian grading Rayyan

[ ] Individual should show that they were key contributor and example to team.  This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom.

Individuals Video, Issue(s), Commits(s)

[ ] Video in CPT caption style , includes Web demo of key contribution to project, 1 minute
[ ] Issue(s) that show plans/progress to team objectives
[ ] Highlights of key commit(s) in Issues, summarizes code contributions
[ ] Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks

Per check.
0.55 not attempted/no check
0.7 attempted, incomplete, but some runtime
0.8 mastery and runtime
0.9 above and beyond.
Freeform comment.
Code for test was effective and well written. Issues were outline and discussed, especially with images, and debugging and finding errors is much more work, since images are more finnicky. Video showcasing work was complete with captions, and highlighted work on the projects. Worked on HTML, CSS, and JS, and video shows that. Randomizer created is effective and code creates a good environment for practicing and testing binary. Plan and project features demonstrated good collaboration with teammates, such as helping fix errors. Overall, Rayyan was a key contributor to their project and definitely did his share of work.
Grade: 0.86/9


Admin\Operator - External user can select an existing operator in select operator workflow

Dependencies

Blocked by
Blocking #1960

Description:
This ticket is about copying the select an operator workflow to reg 2. Wireframes: https://www.figma.com/design/LsDmLDCdnJqI8UahyqvOD8/BCIERS-Designs?node-id=15413-1900
Acceptance Criteria:
Given I am a new user who has never used the app before
When I sign in and navigate to the administration dashboard
Then I see only the select operator and report and issue tiles
Given I click the select operator tile
When am I redirected
Then I see the select an operator dropdown and form (add will be handled in another ticket)
Given I select an operator
When I click "next"
I am asked to confirm I've selected the correct operator
Given I confirm
When I am redirected to a page where I can request access or admin access
Then I can click request
Given I request access
When I am redirected
I can see a confirmation message
Development Checklist:

[x] Refactor dashboard fixtures for conditional display of dashboard links
[x] Refactor dashboard tiles for conditional display of dashboard links
[x] Refactor middleware for conditional routing
[x] Copy the select operator pages into bciers/apps/administration/app/bceidbusiness/industry_user/select-operator
[x] Copy the components in the pages into bciers/apps/administration/app/components/userOperator
[x] Refactor api calls
[x] Refactor components to work with vitests
[x] Write missing vitests
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:
Consider fixing this bug as part of this ticket since most of this will be importing a completed feature from reg1. We can add some polish:
https://github.com/bcgov/cas-registration/issues/1428

@patriciarussellCAS
Reachable at:
https://cas-bciers-frontend-dev.apps.silver.devops.gov.bc.ca/administration/select-operator
Test Dashboard Tile Link - Select an Operator:

Navigate to http://localhost:3000
Click button "Log in with Business BCeID"
Sign in to Keycloak using bc-cas-dev-secondary
Expected results:

Redirection to dashboard page for role industry_user without an associated operator
Administration tile has link Select an Operator

Link redirects to:
https://cas-bciers-frontend-dev.apps.silver.devops.gov.bc.ca/administration/select-operator

@shon-button The intent is also that a first-time user cannot see any of the other tiles or options/actions until they select an operator and get approved to access that operator. I think the dashboard should show show only the Administration tile and only the 'Select an Operator' action. (Plus the 'report a problem' tile)

I also flagged to @zoeyli-46 that the wireframe currently shows the old Reg 1 tile where the whole tile is for selecting an operator (https://www.figma.com/design/LsDmLDCdnJqI8UahyqvOD8/BCIERS-Designs?node-id=15682-299&t=JfwXOlGzeqFgIus9-4). I'm assuming that in the current app setup using the Administration tile makes more sense from a dev perspective so suggested a change to the wireframe. Please correct me if it's not the case though.
cc: @patriciarussellCAS

The original intent of this ticket appears to be complete. I believe we can close this ticket and address Hanna's comments above in the follow-up ticket #2165
Devs - let me know if that works for you and I'll close this.

Closing this ticket, with a note that we'll need ensure there is a follow-up ticket for greying out the tiles they shouldn't have access to.


UserAttribute is missing in the reflection information for scalar variable declaration.

[__AttributeUsage(_AttributeTargets.Var)]
struct DefaultValueAttribute
{
    int iParam;
}

struct A
{
    float x;
    [DefaultValue(1)]
    float y;
};

A param1;

[DefaultValue(1)]
int param2;

For above code snippet, user attribute is missing for param2 in the reflection information, but not for A::y.
It can be reproduced by running slang-test.

This is not really a reflection bug, but a reflection test bug, because the test doesn't print the attribute for the variable, only print the attributes for type.


Documentation Gaps

Summary: Some areas of the documentation, such as contribution guidelines and troubleshooting sections, are incomplete.
Details: Although basic installation and setup instructions are provided in the README.md, detailed contribution guidelines, as well as troubleshooting for common issues, are missing.
Affected Areas: README.md, CONTRIBUTING.md (if applicable).
Dependencies: None.

Proposed Solution: Add detailed contribution guidelines, including coding standards, pull request procedures, and how to run tests. Also, expand troubleshooting sections to cover common issues encountered during setup.

Continue to expand the documentation, especially for the next milestones and contribution guidelines.

Continue improving the README.md and add a CONTRIBUTING.md file with detailed contribution guidelines.

Next Steps: Further expand the documentation, especially to address onboarding and troubleshooting.

Expand the README.md and CONTRIBUTING.md to include more information on testing, setup, and troubleshooting.

Detailed instructions for setting up the UI, testing the form submission process, and running unit tests using pytest have been added to the README.md. Some troubleshooting sections still require more examples


Updated the README.md (added a godoc reference)

Minor edit. Added a godoc reference badge to the README.

Coverage remained the same at 83.784% when pulling eb0995be8c82f84df9ab5df2f786e4513d47d9ab on HanEmile:master into f83f50a18c78c22ed966b7d548064e08b50de266 on solher:master.

Thank you!


Whitespace preservation inconsistency

While backporting some tests from Dome to Blueprint (https://github.com/ignitionrobotics/ign-sensors/pull/33/), I noticed that there's an inconsistency with how sdf8 and sdf10 treat multiple whitespaces inside elements (not inside arguments).
I believe this difference comes from the default behaviour of tinyxml versus tinyxml2, according to tinyxml documentation on whitespace preservation:  "By default, TinyXML-2 preserves white space in a (hopefully) sane way that is almost compliant with the spec. (TinyXML-1 used a completely different model, much more similar to 'collapse'".
It would be nice to be consistent across SDF versions. I can see arguments for each behaviour though. This is not very important for our use cases right now, but I thought we should keep track of it.

https://github.com/ignitionrobotics/ign-gazebo/issues/280 has a more important use case. I think it would be good to support this kind of declaration on SDF10:
<uri>
   https://fuel.ignitionrobotics.org/1.0/OpenRobotics/models/Coke
</uri>

cc @mjcarroll

Fixed in #359


[feature] Add black list for insert

What type of PR is this：

[ ] bug
[x] feature
[ ] enhancement
[ ] refactor
[ ] others

Problem Summary(Required) ：

Add blacklist for insert stmt:

admin set frontend config ("enable_sql_blacklist" = "true")
ADD SQLBLACKLIST "insert into .+ values.+";
then, execute

insert into action333 values(333, 'ddd', '2020-02-25 17:33:22');
ERROR 1064 (HY000): Access denied; This sql is in blacklist, please contact your admin

[FE PR Coverage Check]
:disappointed: fail : 2 / 3 (66.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/StmtExecutor.java
2
3
66.67%
[507]

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

[FE PR Coverage Check]
:disappointed: fail : 2 / 3 (66.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/StmtExecutor.java
2
3
66.67%
[507]


feature request: API to set URL of WebView

Currently the webview API does not allow setting a URL to load content. Thus, if you want to load content from a remote/local server you need to set the webview's html to include an iframe.
Inserting an iframe inside of a webview breaks all keyboard shortcuts inside the webivew (so no copy / paste) and also outside of the webview (so you cannot open the command palatte)

The bugs described above do not occur when an iframe is not inserted within a webview. If we could set the webview's url we would not need an iframe. Thus the feature request is an extension of the webview api to set a url to load content.

Might be a duplicate of https://github.com/Microsoft/vscode/issues/65452
But I've added some extra details to this feature request so I'll leave it to the maintainers to decide if this should be closed and marked as duplicate

If we were to support this, would you expect:

VS Code api to be enabled?
Navigation to work?

The former I think? Its an API feature request after all. To be honest I'm not sure I know what you're asking @mjbvz

If you load a url like localhost:3000 in the webview, would you expect:

That content served on localhost:3000 could use the vscode apis that webview content has access to today (using postMessage for example)
That you could click on a link on the page and it would navigate to that page within the webview element? Navigation is blocked inside of webviews today

Yes, we would want to unblock navigation as part of this API request.

In my scenario, webworkers of monaco don't seem to work in vscodes webviews.
I can't really debug it since the dev tools window opens way too late, but I think it is because only http(s?)-served websites can spawn web workers.
IFrames are very slow and I have tons of focus problems with them in Vs Code so I would like to avoid them.
I would be fine with blocking navigation but persisting the URL query parameters which are then allowed to be updated from within the webview.
My extension would start a webserver to host the content.

@mjbvz support navigation is important for SPA, any plan to support this?

I have managed to get a solution, available here, but it can't load js/css at this moment.

Closing as this is not something we can provide a good story for
Webviews take raw html in part because this lets us modify the html content before it is rendered, such as injecting the webview API. This is generally not possible for content loaded from a url (unless you have a proxy, but that's not business VS Code wants to get into). As a result, none of the VS Code variables or scripts would be available inside of a url based webview, which makes it about the same just rendering a full width+height iframe for the url inside your webview.
Instead, if you need to display content from a specific url, use an iframe. You webview code can also post messages to this iframe to communicate with it

I would like to revisit this issue. I'm having a bad time trying to implement a previewer for revealjs that doesn't lose its position each time it gets refreshed. In order to support this, revealjs updates its url to include the current slide number. @mjbvz you suggested to use an iframe in 2019, but that's not possible anymore since a couple of years at least. The only way around this I see is some kind of convoluted message passing informing slide changes.


Investigation Ontology: STUDY misses some follows relationships

https://github.com/nfdi4plants/ARCTokenization/blob/2dfd46f6884a61853baa76971620e868b66b4987/src/ARCTokenization/structural_ontologies/investigation_metadata_structural_ontology.obo#L243-L248
As seen here
,
STUDY can also follow Study Person Roles Term Source REF (for every Study added to an Investigation after the first one). This is not mapped atm. in Investigation Metadata ontology.
Image's source file: https://git.nfdi4plants.org/muehlhaus/ArcPrototype/-/blob/main/isa.investigation.xlsx

Also misses follows to Investigation Person ORCID:

(same source as above)

should be fixed via https://github.com/nfdi4plants/ARCTokenization/commit/587eafb4a0e023a29eaa58edf63231a272e4aa60


Select2Editor TemplatedDialog validation error

Hi,
I created a very small dialog based on TemplatedDialog to avoid grid inline editing. There is simply a StringEditor and a n extension of Select2Editor.
I can't figure out how come I get 'Unable to get property 'element' of undefined or null reference' in jquery.validate
I am not using FormScript, and I guess that validator is created  from the form, but I cannot figure out how to "override it".
May I request a hint to where to look for it?

Meh,
Ok, for the record, for select2editor, it is "input" not "div"...
 constructor() {             super();             this.dateStringForm = new TimeTypeEditor(this.byId('Date')) } protected getTemplate() {             return (                 "<form id='~_Form' class='b-inline-container s-Form' style='flex-direction:row'>" +                 "<**input** id='~_Date' class='required b-inline-form editor'></**input**>" +                 "</form>");


nivo slider throws error

Fresh inbstall of backdrop.. Installed nivo-slider. Foolowed the instructions and tried to add an image.
Result:
Notice: Undefined index: nivo_slider_image_style in nivo_slider_slide_configuration_form() (line 76 of /var/www/html/modules/nivo_slider/nivo_slider_slides.admin.inc).

I too am hitting this same notice. It is preventing me from adding more than one slide. I checked the apache error log and there is nothing there related to the issue. I'm guessing its a missing library issue, however the nivo slider js library is located at $MYSITE/libraries/nivo_slider. Though perhaps it was a permission issue on the libraries directory, but that does not seem to be it either.


https ssl issue. i've had ssl compile error

hello~
i compiled pistache source using ssl  but i got this error.
terminate called after throwing an instance of 'std::runtime_error'   what():  Pistache is not compiled with SSL support.
my code is below this.
#include <iostream>

using namespace Pistache;

struct HelloHandler : public Http::Handler {
    HTTP_PROTOTYPE(HelloHandler)

    void onRequest(const Http::Request& request, Http::ResponseWriter writer) {
        writer.send(Http::Code::Ok, "Hello, World!");
    }
};

int main(void) {
    std::cout << "Starting server\n";
    Pistache::Address addr;
    auto opts = Http::Endpoint::options().threads(1);

    addr = Pistache::Address(Pistache::Ipv4::any(), Pistache::Port(9999));

    Http::Endpoint server(addr);
    server.init(opts);
    server.setHandler(std::make_shared<HelloHandler>());
    server.useSSL("./cas/server/server.crt", "./cas/server/server.key");
    server.useSSLAuth("./cas/rootCA/rootCA.crt");
    std::cout << "SSL enabled\n";

    server.serve();

    return 0;
}

What commands, exactly, did you use to compile pistache?  Did you set the correct flags when running cmake?

i just made another cc file. and compile command is  g++ httpssample.cc -o httpssample -lpistache.

What commands did you use to compile the pistahce library itself (not your own code that links against that library)?
Should be something that looks like:
cmake -G "Unix Makefiles" -DPISTACHE_USE_ALL=true

thank you for your help.
i change my source socket program to pistache rest program.
so i need to use just library option.
is it possible?

I do not understand what you are asking.

i'm sorry. i'd like to know how to compile pistache ssl source without cmakefiles.
i'd like to know commands line for compiling ssl pistache source.
thank you~

i added libpistache.a compile command line.. so it worked~
thank you for your help!!

@forkballpitch, please consider using the pre-compiled binaries from the PPA. They are already built with SSL support and will automatically pull the correct dependencies.

I'm getting the same error.
I've tried to compile the lib using these 2 commands
sudo cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release ..
sudo cmake -G "Unix Makefiles" -DPISTACHE_USE_ALL=true ..
but still getting the same error
terminate called after throwing an instance of 'std::runtime_error' what(): Pistache is not compiled with SSL support.

You should turn on ssl support with cmake command.
-DPISTACHE_USE_SSL=true

Also, don't build as root. If you want to install system wide outside of the control of the system's package manager (not recommended), then prefix just the installation step with sudo.


Editable Modal Size / width

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.
[X] I am only requesting a single feature. Multiple changes should be split into individual requests, with links between them.
[X] I believe my requested feature will be generally applicable to other users, not just me: it is not uniquely tied to my personal workflow.

🔖 Feature description
When on the new modal with the new editing options (Thank you btw) the window is too small and thus requires scrolling

As such it requires me to scroll down when the modal is open.
As I see it the issue is width.
I want to be able to edit the size of the modal that appears and the settings be remembered (possibly a reset button as well but that may be a different request)
✔ Solution
Make the modal window editable so that the user can edit the size of the window both vertically and horizontally.
I would like the window to be centred by default.
The vault should remember my size preferences for the modal and keep them unless changed.
Moving around the window is a separate concern and not required (but would also be nice)
There should be a reset button to undo the edits both in settings and in the modal itself.
❓ Alternatives
Alternativly you could fix the issue and make the window wider on all pages

As I see it the issue is width,
📝 Additional Context
No response

Thanks for the suggestion.
I don't know if Obsidian even provides control over the size of the modal, and I personally would not spend time making it customisable. User settings complicate things for both users and developers.
You could experiment with CSS in the meantime, and perhaps ask in the #appearance channel in the Obsidian Discord server.
For info, I am planning to redesign the modal so that it takes up less space, although there is a lot of other in-flight work to do first...
In the short term, it is soon going to get larger, when the new task dependencies feature gets released.
I'll leave this open for a day or two, for discussion.

Hey Claire,

It seems that there would be as the popup sizes for the modal windows vary.
I would assume that this would be styed at the point of rendering

(Fixing the cause of the orange warning would of course be another space-saver - and better use of development time - it is a hard problem though.)

Thank you, yh that should do the trick.
Do you want me to close this out?

I’m not sure what you mean by the width of modals varying. That settings dialogue is entirely controlled by Obsidian. For me, the modal width is controlled by the width of my Obsidian window.
Anyway, thank you for being so understanding. As you’re OK with closing, I’ll do that now.


Following guide creates error

Versions
Erlang/OTP 20 [erts-9.1] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:10] [hipe] [kernel-poll:false]

Elixir 1.5.2

Error
mix deps.compile
== Compilation error in file lib/ex_admin/gettext.ex ==
** (CompileError) Elixir.ExAdmin.Gettext: function lgettext/4+1688:
  Internal consistency check failed - please report this bug.
  Instruction: {test,bs_match_string,{f,561},[{x,6},48,{string,"rofile"}]}
  Error:       {no_bsm_context,{x,6}}:

    (stdlib) lists.erl:1338: :lists.foreach/2
    (stdlib) erl_eval.erl:670: :erl_eval.do_apply/6
    (elixir) lib/kernel/parallel_compiler.ex:121: anonymous fn/4 in Kernel.ParallelCompiler.spawn_compilers/1
could not compile dependency :ex_admin, "mix compile" failed. You can recompile this dependency with "mix deps.compile ex_admin", update it with "mix deps.update ex_admin" or clean it with "mix deps.clean ex_admin"

Same issue with my compile phase

Help!!!

@StephanMeijer  I made some test. In my opinion, it's not a ex_admin bug, I switched the erlang version to 19.3.6 and this bug disappear. I also tested Erlang/OTP 20 [erts-9.1.2]  and it works fine. However it does not work on Erlang/OTP 20 [erts-9.1]

Erlang/OTP 19 [erts-8.3.5] [source] [64-bit] [smp:2:2] [async-threads:10] [hipe] [kernel-poll:false]
Eshell V8.3.5  (abort with ^G)

So whats the solution to this? Just downgrade Erlang and wait for next version of otp?

Confirmed it is an OTP bug and has been reported. It’s fixed in Erlang 20.1.3

There's no official Debian release containing the fix (latest is erts-9.1), how can I get the latest version on Debian ?

Use a version manager like asdf that allows you to pull from the GitHub repo. Not sure if asdf supports vanilla Debian, it supports Ubuntu. You can also download the tagged version of the code and use the compile and install from source instructions on Erlangs site to manually install it.

asdf surely supports debian.


[Bug]: Offline Inference with the OpenAI Batch file format yields unnecessary asyncio.exceptions.CancelledError

Your current environment
Collecting environment information...
PyTorch version: 2.3.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Ubuntu 20.04.6 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
Clang version: Could not collect
CMake version: version 3.29.3
Libc version: glibc-2.31

Python version: 3.10.14 (main, May  6 2024, 19:42:50) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-5.15.0-60-generic-x86_64-with-glibc2.31
Is CUDA available: True
CUDA runtime version: Could not collect
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: NVIDIA A100-SXM4-80GB
Nvidia driver version: 525.105.17
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   43 bits physical, 48 bits virtual
CPU(s):                          128
On-line CPU(s) list:             0-127
Thread(s) per core:              2
Core(s) per socket:              32
Socket(s):                       2
NUMA node(s):                    2
Vendor ID:                       AuthenticAMD
CPU family:                      25
Model:                           1
Model name:                      AMD EPYC 7513 32-Core Processor
Stepping:                        1
Frequency boost:                 enabled
CPU MHz:                         3098.695
CPU max MHz:                     3681.6399
CPU min MHz:                     1500.0000
BogoMIPS:                        5189.82
Virtualization:                  AMD-V
L1d cache:                       2 MiB
L1i cache:                       2 MiB
L2 cache:                        32 MiB
L3 cache:                        256 MiB
NUMA node0 CPU(s):               0-31,64-95
NUMA node1 CPU(s):               32-63,96-127
Vulnerability Itlb multihit:     Not affected
Vulnerability L1tf:              Not affected
Vulnerability Mds:               Not affected
Vulnerability Meltdown:          Not affected
Vulnerability Mmio stale data:   Not affected
Vulnerability Retbleed:          Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, IBPB conditional, IBRS_FW, STIBP always-on, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 invpcid_single hw_pstate ssbd mba ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local clzero irperf xsaveerptr rdpru wbnoinvd amd_ppin arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload vgif v_spec_ctrl umip pku ospke vaes vpclmulqdq rdpid overflow_recov succor smca fsrm sme sev sev_es

Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] torch==2.3.0
[pip3] triton==2.3.0
[conda] cudatoolkit               11.8.0               h6a678d5_0
[conda] numpy                     1.26.4                   pypi_0    pypi
[conda] nvidia-nccl-cu12          2.20.5                   pypi_0    pypi
[conda] torch                     2.3.0                    pypi_0    pypi
[conda] triton                    2.3.0                    pypi_0    pypiROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.4.3
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0	NIC0	CPU Affinity	NUMA Affinity
GPU0	 X 	PXB	0-31,64-95	0
NIC0	PXB	 X

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

NIC Legend:

  NIC0: mlx5_bond_0

🐛 Describe the bug
The offline Inference with the OpenAI Batch file format yields an unnecessary asyncio.exceptions.CancelledError even though it fulfills the requests appropriately.
After following the steps for the usual install I run:
wget https://raw.githubusercontent.com/vllm-project/vllm/main/examples/openai_example_batch.jsonl
python -m vllm.entrypoints.openai.run_batch -i openai_example_batch.jsonl -o results.jsonl --model meta-llama/Meta-Llama-3-8B-Instruct

which yields the following output:
/root/.conda/envs/venv/lib/python3.10/site-packages/huggingface_hub/file_download.py:1132: FutureWarning: `resume_download` is deprecated and will be removed in version 1.0.0. Downloads always resume when possible. If you want to force a new download, use `force_download=True`.
  warnings.warn(
INFO 06-01 11:35:00 llm_engine.py:161] Initializing an LLM engine (v0.4.3) with config: model='meta-llama/Meta-Llama-3-8B-Instruct', speculative_config=None, tokenizer='meta-llama/Meta-Llama-3-8B-Instruct', skip_tokenizer_init=False, tokenizer_mode=auto, revision=None, rope_scaling=None, tokenizer_revision=None, trust_remote_code=False, dtype=torch.bfloat16, max_seq_len=8192, download_dir=None, load_format=LoadFormat.AUTO, tensor_parallel_size=1, disable_custom_all_reduce=False, quantization=None, enforce_eager=False, kv_cache_dtype=auto, quantization_param_path=None, device_config=cuda, decoding_config=DecodingConfig(guided_decoding_backend='outlines'), seed=0, served_model_name=meta-llama/Meta-Llama-3-8B-Instruct)
Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
WARNING 06-01 11:35:01 logger.py:146] VLLM_TRACE_FUNCTION is enabled. It will record every function executed by Python. This will slow down the code. It is suggested to be used for debugging hang or crashes only.
INFO 06-01 11:35:01 logger.py:150] Trace frame log is saved to /tmp/vllm/vllm-instance-1f1fb60e04e448b989f2d3eeef714ac3/VLLM_TRACE_FUNCTION_for_process_3702_thread_140538783966400_at_2024-06-01_11:35:01.276871.log
DEBUG 06-01 11:35:01 parallel_state.py:87] world_size=1 rank=0 local_rank=0 distributed_init_method=tcp://<IP_ADDRESS>:48437 backend=nccl
INFO 06-01 11:35:02 weight_utils.py:207] Using model weights format ['*.safetensors']
INFO 06-01 11:35:07 model_runner.py:146] Loading model weights took 14.9595 GB
INFO 06-01 11:35:08 gpu_executor.py:83] # GPU blocks: 27973, # CPU blocks: 2048
INFO 06-01 11:35:09 model_runner.py:854] Capturing the model for CUDA graphs. This may lead to unexpected consequences if the model is not static. To run the model in eager mode, set 'enforce_eager=True' or use '--enforce-eager' in the CLI.
INFO 06-01 11:35:09 model_runner.py:858] CUDA graphs can take additional 1~3 GiB memory per GPU. If you are running out of memory, consider decreasing `gpu_memory_utilization` or enforcing eager mode. You can also reduce the `max_num_seqs` as needed to decrease memory usage.
INFO 06-01 11:35:25 model_runner.py:924] Graph capturing finished in 15 secs.
Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
INFO 06-01 11:35:27 serving_chat.py:84] Using default chat template:
INFO 06-01 11:35:27 serving_chat.py:84] {% set loop_messages = messages %}{% for message in loop_messages %}{% set content = '<|start_header_id|>' + message['role'] + '<|end_header_id|>
INFO 06-01 11:35:27 serving_chat.py:84]
INFO 06-01 11:35:27 serving_chat.py:84] '+ message['content'] | trim + '<|eot_id|>' %}{% if loop.index0 == 0 %}{% set content = bos_token + content %}{% endif %}{{ content }}{% endfor %}{% if add_generation_prompt %}{{ '<|start_header_id|>assistant<|end_header_id|>
INFO 06-01 11:35:27 serving_chat.py:84]
INFO 06-01 11:35:27 serving_chat.py:84] ' }}{% endif %}
INFO 06-01 11:35:27 async_llm_engine.py:553] Received request cmpl-9ac7822d394c4eb590bfd6af6c3ae539: prompt: '<|begin_of_text|><|start_header_id|>system<|end_header_id|>\n\nYou are a helpful assistant.<|eot_id|><|start_header_id|>user<|end_header_id|>\n\nHello world!<|eot_id|><|start_header_id|>assistant<|end_header_id|>\n\n', params: SamplingParams(n=1, best_of=1, presence_penalty=0.0, frequency_penalty=0.0, repetition_penalty=1.0, temperature=0.7, top_p=1.0, top_k=-1, min_p=0.0, seed=None, use_beam_search=False, length_penalty=1.0, early_stopping=False, stop=[], stop_token_ids=[], include_stop_str_in_output=False, ignore_eos=False, max_tokens=1000, min_tokens=0, logprobs=None, prompt_logprobs=None, skip_special_tokens=True, spaces_between_special_tokens=True, truncate_prompt_tokens=None), prompt_token_ids: [128000, 128006, 9125, 128007, 271, 2675, 527, 264, 11190, 18328, 13, 128009, 128006, 882, 128007, 271, 9906, 1917, 0, 128009, 128006, 78191, 128007, 271], lora_request: None.

DEBUG 06-01 11:35:27 async_llm_engine.py:514] Waiting for new requests...
DEBUG 06-01 11:35:27 async_llm_engine.py:516] Got new requests!
INFO 06-01 11:35:27 async_llm_engine.py:124] Finished request cmpl-5216cb94e03e4263bd89d265f4ab8c56.
INFO 06-01 11:35:28 async_llm_engine.py:124] Finished request cmpl-9ac7822d394c4eb590bfd6af6c3ae539.
Exception in callback _raise_exception_on_finish(error_callback=<bound method...7fd04ff2d600>>)(<Task cancell...ngine.py:510>>) at /root/.conda/envs/venv/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py:32
handle: <Handle _raise_exception_on_finish(error_callback=<bound method...7fd04ff2d600>>)(<Task cancell...ngine.py:510>>) at /root/.conda/envs/venv/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py:32>
Traceback (most recent call last):
  File "/root/.conda/envs/venv/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 528, in run_engine_loop
    await asyncio.sleep(0)
  File "/root/.conda/envs/venv/lib/python3.10/asyncio/tasks.py", line 596, in sleep
    await __sleep0()
  File "/root/.conda/envs/venv/lib/python3.10/asyncio/tasks.py", line 590, in __sleep0
    yield
asyncio.exceptions.CancelledError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/root/.conda/envs/venv/lib/python3.10/asyncio/events.py", line 80, in _run
    self._context.run(self._callback, *self._args)
  File "/root/.conda/envs/venv/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 40, in _raise_exception_on_finish
    task.result()
asyncio.exceptions.CancelledError

The input file, openai_example_batch.jsonl, contains two requests:
{"custom_id": "request-1", "method": "POST", "url": "/v1/chat/completions", "body": {"model": "meta-llama/Meta-Llama-3-8B-Instruct", "messages": [{"role": "system", "content": "You are a helpful assistant."},{"role": "user", "content": "Hello world!"}],"max_tokens": 1000}}
{"custom_id": "request-2", "method": "POST", "url": "/v1/chat/completions", "body": {"model": "meta-llama/Meta-Llama-3-8B-Instruct", "messages": [{"role": "system", "content": "You are an unhelpful assistant."},{"role": "user", "content": "Hello world!"}],"max_tokens": 1000}}

And the output file, results.jsonl, contains two responses:
{"id":"vllm-3db6165852554c9ca09676d5079efba5","custom_id":"request-1","response":{"id":"cmpl-9ac7822d394c4eb590bfd6af6c3ae539","object":"chat.completion","created":1717266927,"model":"meta-llama/Meta-Llama-3-8B-Instruct","choices":[{"index":0,"message":{"role":"assistant","content":"Hello! It's great to meet you! I'm here to help with any questions or tasks you may have. What's on your mind today?"},"logprobs":null,"finish_reason":"stop","stop_reason":null}],"usage":{"prompt_tokens":24,"total_tokens":55,"completion_tokens":31}},"error":null}
{"id":"vllm-601cfbcc98d34ddf8e1a6b50581d636e","custom_id":"request-2","response":{"id":"cmpl-5216cb94e03e4263bd89d265f4ab8c56","object":"chat.completion","created":1717266927,"model":"meta-llama/Meta-Llama-3-8B-Instruct","choices":[{"index":0,"message":{"role":"assistant","content":"*silence*"},"logprobs":null,"finish_reason":"stop","stop_reason":null}],"usage":{"prompt_tokens":26,"total_tokens":31,"completion_tokens":5}},"error":null}

So everything appears to be working, but I'm just not sure why an error is being thrown. (I also doubled the size of the input file and still found four responses in the results.)

@wuisawesome can you help take a look?

Likely related, since it only happened when I sent multiple concurrent requests:

https://github.com/vllm-project/vllm/issues/2621#issuecomment-2143889481

As detailed in that linked comment, the solution I stumbled upon was to reduce --gpu-memory-utilization from 0.99 to 0.96. Hopefully this provides some clues as to the root cause.

Yeah I've noticed this too and can look into it. I think this is a logging issue when cleaning up the program so it shouldn't be causing a correctness issue. Still worth fixing though I think.


support custom config

support custom config
change copy config file to soft link

wrong commit user, repr.


Provide an "array_view" class

When typed_array supports different storage types (see #140), an new array_view class should be provided. This class is meant to provide an array API to Arrow data provided by external libraries (via the Arrow C data interface). Notice that this new class should provid a restricted API (only the const API of the array class), since we cannot manage the memory of the external structures.
This array_view will hold a variant of typed_array parmetrized by the ArrowArray storage, while the existing array class will remain unchanged.

👍🏽
There is a risk that the array_view name leads to misunderstanding, as it would not match "any arrow data storage" but only ArrowArrays. Also we want it to be reduced in capabilities and maybe the name needs to reflect that.

array_read_only ?

external_array?

This class is not needed anymore now that the library has been refactored to handle imported arrays and arrays created with sparrow in a single class.


Rename e2e -> integration_test

The e2e name is not entirely fitting for this plugin - some of our consumers expect e2e to implement larger multi-system tests exercising both client and server, which makes this package confusing. Adding the word test also should make this package more discoverable on pub for users looking for test packages.
WIP while I figure out which other plugin(s) need bumps to accomodate pubspec changes.

The lint failure is because it's looking for a URL that doesn't exist yet, since this PR will be creating that URL.

/cc @csells

/cc @jiahaog as this will impact the internal roll/naming.

I don't see an obvious way that the previously existing e2e package on pub would be linked to the new name from this PR, is that a concern? I think it would probably help to keep e2e as an empty package in the repo and publish a README update about the rename to pub, but I'm not really familiar with all the context here.

That's a good idea.  I was going to just locally modify e2e for that

And there's readme.md in root directory.

@CareF I've updated the READMe. I'm not calling it main so you can import it without an alias more easily and still use it.

I'm not calling it main so you can import it without an alias more easily and still use it.

I get that, but I mean Future<void> integration_main() => integrationDriver(); this is no longer necessary if we don't want a main here. Users can directly use integrationDriver in their driver file.

This is currently blocked by apparently unrelated timeouts on infra. Trying to open another PR to shard.

Red CI is because this PR creates a directory the CI is checking for.
Landing on red for that reason. If this goes red on post submit will revert.


Can Add Service Principle to Workspace, but not Group

We have a mix of Workspaces and Office 365 Groups in our "Workspaces" in PowerBI web app. I can add a service principle to a workspace (using the instructions above), but I can't figure out how to provide permissions for a service principle to be an admin for a "Group" Workspace. Is this possible?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c135bb4c-618b-478d-bce7-ac8608e3caac
Version Independent ID: a297498b-afa2-575d-417c-0cb4696a90af
Content: Service principal with Power BI - Power BI
Content Source: powerbi-docs/developer/embed-service-principal.md
Service: powerbi
Sub-service: powerbi-developer
GitHub Login: @KesemSharabi
Microsoft Alias: kesharab

Hi @lphomiej,
It isn't possible to provide permissions for a service principle to be an admin for a "Group" Workspace (the old workspace).
This only works with  the new workspace as mentioned in the first bullet in Service principal with Power BI > Considerations and limitations.


removed sonar vulnerabilities

Pull Request Title (Brief description of changes)
Related Issue
Link to the related issue(s) and touch on any details. Use the 'closes', 'fixes', 'resolves' etc. keywords.
Fixes sonar issues with past commits #112
Description
Provide a detailed description of the changes made in this PR.
Removed Sonar Vulnerabilities
Testing
Describe the tests that were run to verify your changes and testing instructions for PR reviewers.
N/A
Images
Add any relevant images to demonstrate changes.
Additional Context
Any other context or information that reviewers might need.

Approved and looks good great work


I need help selecting quality

Checklist

[X] I'm asking a question and not reporting a bug/feature request
[X] I've looked through the README
[X] I've read the guidelines for opening an issue
[X] I've searched the bugtracker for similar questions including closed ones

Question
Hello
Sorry for asking here, I don't speak English well and don't know where else to ask
I search here for an answer and see there is no easy way to select best quality
I found that best quality now is AV1 codec (I can play it) but I want to select it above everything else then H264 and then the rest
What should cmd command look like in that case?
Also is it possible to download best available (no matter resolution) and convert it to background to 720p 2pass q20 vbr mode somehow automatically and delete original big resolution file via cmd/ytdlp commands?
Verbose log
No response

Thanks for your reply!
So H264 is 1st in order by default and we make AV1 in front of it by that command? H264 will still have priority over VP9?
I usually work with other GUI based software to convert videos after they are downloaded and never did it via console commands unfortunately. I just wanted to automate this process. To download best version possible and then automatically convert it to something like 720p 2pass profile with slow preset. Because YT does such an awful job at converting stuff even 1080p somehow looks subpar 720p if not 480p. So I thought converting best available 4k option can give me good quality achieved from 4k downscale and small size too but it is annoying to manually set up the whole process after files are downloaded plus they are not deleted automatically to free up space

So H264 is 1st in order by default and we make AV1 in front of it by that command? H264 will still have priority over VP9?

No. Re-reading your question, I see I misunderstood what you wanted to do. -S vcodec will set the order to av01 > vp9 > h265 > h264 > .... It is currently not possible to set it as av1 > h264 > vp9 using -S (can be done with -f). However, we can use the fact that av1 and h264 are served in mp4 to set -S ext:mp4,vcodec

and then automatically convert it to something like 720p 2pass profile with slow preset.

You will have to figure out the ffmpeg command for that. You can try asking in some ffmpeg community
Though honestly, youtube probably does better encoding that whatever you do. So it is better imo to just download the 720p from youtube directly


Fix incorrect namespaces in schemaLocation

Changed for mediainfo and mediatrace reports.

@kimec thanks for the fix!


Ability to look back n items and / or having moving windows

There are many times where you need n items of history. So like batch is it possible to have a moving window.

I will add support for a sliding window using the immutable Conc tree collection (from the reactors-common module, which you should have if you depend on the reactors-core package).
Note, however, that if you need sliding windows, it is very likely that using the mutate combinator to modify a mutable ConcBuffer collection is more efficient than using an immutable Conc. The mutable ConcBuffer allows appending elements very efficiently. I will modify it to also support efficient pushLeft, pushRight, popLeft and popRight.


setCount Error

The error is occurring at line 105 in your Main.php file for the Lifesteal plugin. Specifically, the setCount method is being called with a string instead of an integer.

Good.

@ShauryaGupta0 i am rewrite the plugin, it's not stable rn.


Documentation needs to be corrected

[Enter feedback here]
data = np.array(data)
result = model.predict(data)
inputs_dc.collect(data) #this call is saving our input data into Azure Blob
prediction_dc.collect(result) #this call is saving our input data into Azure Blob
Second comment needs correction

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5ec57fee-a0d0-c9a7-eeb2-90b9223b932c
Version Independent ID: 0f840fe8-5786-59ba-5b80-87595f370133
Content: Collect data on your production models - Azure Machine Learning
Content Source: articles/machine-learning/how-to-enable-data-collection.md
Service: machine-learning
Sub-service: core
GitHub Login: @lostmygithubaccount
Microsoft Alias: copeters

Thanks for the feedback! We are currently investigating and will update you shortly.

@shikha1970 Thanks for your feedback again, I have created a PR to fix this issue.

You should see the fixing soon! We will now proceed to close this thread. If there are further questions regarding this matter, please respond here and @YutongTie-MSFT and we will gladly continue the discussion.


style: clickable labels have outlines, storybook shows them

SUMMARY

Touches up the Label component in a few ways:
• Labels get a visible border if they have an onClick handler. No border if they don't.
• Default label gets a lighter/inverted color treatment (colors copped from https://github.com/apache/incubator-superset/pull/10971)
• Adds a row to the Storybook to show both interactive and non-interactive variants
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Storybook FTW.
Stamp of approval from @steejay
ADDITIONAL INFORMATION

[ ] Has associated issue:
[x] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Merging so that I can rebase https://github.com/apache/incubator-superset/pull/10971


Slack access

Hi everyone:
It looks like there is a Slack channel however an invite is required to access?  Is there a link that should be setup for that?
Thanks,
Mohammed

Hi Mohammed,
Let me follow up to see how that slack channel was set up.
Thanks,
Henry

Hi @havetisyan -- I'm sure you've been busy but do you know if we can get an update on this? :)

Hi Mohammed,
I’m still trying to follow up with another team at Oath that has a product opensourced and has setup public access to their slack workspace to see what is the work involved.
However, if you have any questions about Athenz I’d suggest to follow with us in our athenz-users google group and we’ll be happy to help.
ThanksHenry
Sent from Yahoo Mail for iPhone
On Monday, November 26, 2018, 5:13 AM, Mohammed Naser<EMAIL_ADDRESS>wrote:
Hi @havetisyan -- I'm sure you've been busy but do you know if we can get an update on this? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

For my own info - need to implement something like https://slack.screwdriver.cd to send invites to the athenz slack channel.

@mnaser we have updated the 'Contacts' page with slack invite link. Please check it out.


Position Mode for VTOL in MC Tuning.

Hello guys,
We have the following problem we could not solve in Position Mode in MC. We tuned our Position XY PIDs such that we have a very tight and accurate Position hold in MC. But there are certain aspects of the Position Control that we cannot overcome.
Here is the Position Control Dynamics in MC when you use the Pitch Stick to move the Aircraft forward.

While this is very nice and good for the MC it turns out that it is not very logical for the VTOL.
When we make the XY PIDs tight we exaggerate the effects of: Initial Angle and the Airbraking flare the machine is performing from the diagram.
The Initial angle step for VTOL is not logical because we have a whole wing with its drag and aerodynamics. So more logical is to softly pitch up, up to the setpoint angle, and smoothly gain speed.
While we introduced some expo to the stick and lowered the XY FF gain in the parameters and softened the Initial Angle it is still there and is not very nice to gain speed in Position mode in MC in the initial moment.
The bigger problem is the Airbraking Flare the machine is performing when we release the sticks. It is very dynamic with very high angle and sudden. So given it is not MC but Airplane again with its drag and aerodynamics sometimes this almost flips the airplane. We are using flying wing so it is much more sensitive on the pitch access.
This Airbraking in the air is very good for the VTOL as well but not at the extend it is happening now.
I suppose we could lower the XY PIDs to minimize the extend of the flare but are we going to loose the Position accuracy and grip in Position mode in MC?
I could not find a way to control the Initial Angle and Airbraking Flare with parameters.
Any ideas?

Try lowering the horizontal acceleration and deceleration.
MPC_ACC_HOR_MAX
MPC_DEC_HOR_MAX

The other thing you should consider is significantly lowering the max multicopter pitch and roll rates to what you think is reasonable for a wing.
MC_PITCHRATE_MAX
MC_ROLLRATE_MAX

We limited the pitch rate which solved the problem in half but the acc and dec are parameter I've missed along the lines.
Thanks a lot @dagar We will try the parameters and see what is going on.

I'll close this for now. Reopen if you think it's worth changing some of the vtol defaults.


[Feature Request] [JS Dependant] Add search functionality

This is low down the priority list, but a nice-to-have would be search functionality. It looks like there are a few samples already out there, that are available for re-use -

https://gist.github.com/sebz/efddfc8fdcb6b480f567
https://gist.github.com/naile/47e3e8aa62c6d1410d7b51b80f13bcfe

Could be a good first contribution for anyone who wants to work on their JavaScript skills/has a similar background.


Implementing jwt with passport-local and not passport-local-mongoose

Hey Rob,
I am trying to implement jwt with passport local and not with passport-local-mongoose, but I am not able to understand the flow. Taking this boilerplate, is there any way I can implement that. The reason why I am using this is because I might switch from passport-local to passport-basic since it allows for headers based user details and that I feel is more suitable for rest calls.

@yogeshkumar180592 sorry I haven't touched this repo for a long time and I don't have time to dig in :( best of luck and sorry I can't be more helpful


Change the pty host responsiveness notification to a status bar item

Part of #130320
Simulated a failure with "terminal.integrated.developer.ptyHost.startupDelay": 10000:

New developer command:

I discovered https://github.com/microsoft/vscode/issues/185254 when working on this, it's not a regression from main.

If terminals may stop working, don't we want it to be extremely clear that we're aware of this and provide a way to fix it?
I worry ppl won't discover the status bar item

@meganrogge it's pretty obvious because of the warning color, but since it's a status bar item we can dismiss it immediately when it's no longer valid.

does the message get read when using a screen reader?

@meganrogge it depends on whether new status bar items are announced.
I could go with a notification in screen reader mode, but this seems like an issue with status bar items if they don't already?

and do you have to click the status bar item to see that or does it show automatically?

and yes let's go with a notification for screen reader users and create an issue abt the status bar if it doesn't work already

Toggling screen reader accessibility mode - which adds a status bar item - does not get announced to me

@meganrogge it would be better if this problem was solved generally, such as an announcement flag on the status bar item which optionally alerts it. But that's out of the scope of this change imo, the impact on screen reader users should be very small as it's a very small edge case when pty responsiveness is an issue.


Migrate to new package mapping

Addresses issue  #111

@dm-ra-01 I am currently working on this issue. It's a lot more involved. See the test-coverage branch.

Fixed with 3.2.0 release and onward.


Can the latest version of the tar framework be installed offline?

Why do I go down when I compile?

Can I jump over?

It seems that in the Internet environment, compile it and then transfer it to the intranet to recompile.

There is a download directory. Copy is OK in the past.

有一个download目录的，copy过去就行


Sync pipelinerun validation between v1beta1 and v1

In this commit, I forgot to sync pipelinerun validation between v1beta1 and v1. Thank you @lbernick for noticing this. This PR syncs both of those version as expected.

Changes

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
Sync pipelinerun validation between v1beta1 and v1

/kind bug

/assign @lbernick