Response in ended before the catch in RequestListener

In the following example the server is not returning 500 Internal Server Error. Instead the server throws an error (Error [ERR_HTTP_HEADERS_SENT]: Cannot render headers after they are sent to the client) and the process is killed.
import http from 'http';
import { createHandler } from 'graphql-sse';

const handler = createHandler({
  ...
  onNext: () => {
    throw new Error('Not implemented');
  },
});

http.createServer(async (req, res) => {
  try {
    await handler(req, res);
  } catch (err) {
    res.writeHead(500, 'Internal Server Error').end();
  }
});

Hmm, I couldn't manage to replicate your issue, I've added tests describing your case, and they pass.
Can you elaborate further? Which version are you using? How are you connecting to the server? Which client are you using?
Ideally a full repro would be perfect and much appreciated!

Ah, ok, I misread - the error is thrown properly, but you have problems writing the headers.
The SSE headers are already written and flushed at the point where onNext is reached. Writing a 200: OK is necessary in order to establish an SSE connection.

If I want to write a different head, what are the options? For instance, I would like to send a 500 when something goes wrong.

You cannot write a different header. As mentioned before, it is already written and flushed at that point.
You can only leave a log on your server and fix the onNext handler.

Since re-writing the header is not possible, you can catch the error in onNext and populate the errors GraphQL result field.
Something around the edges:
import http from 'http';
import { createHandler } from 'graphql-sse';

const handler = createHandler({
  // ... your other options ...
  onNext: () => {
    try {
      mightThrowAnError();
    } catch (err) {
      return {
        errors: [new GraphQLError(err)],
      };
    }
  },
});

http.createServer(async (req, res) => {
  try {
    await handler(req, res);
  } catch (err) {
    if (!res.headersSent) {
      res.writeHead(500, 'Internal Server Error').end();
    } else {
      console.error('Internal Server Error', err);
    }
  }
});

Thank you @enisdenjo! The example I have used is directly copied from the JSDoc for the Handler. I have submitted a PR for this.

Thank you @enisdenjo! The example I have used is directly copied from the JSDoc for the Handler. I have submitted a PR for this.

:tada: This issue has been resolved in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Allow specifying custom implementation of k-rpc-socket

Just like k-rpc-socket supports custom socket implementation to be specified as an option it would be nice to also support custom k-rpc-socket implementation.
I'm working on webrtc-socket and k-rpc-socket-webrtc and want to reuse k-rpc as is.

Can someone review and merge this PR, please?

Released as 4.2.0


call_thumbor error: tornado server unavailable, proceeding with tornado  server restart

We are intermittently getting the error below which we are not able to explain.
This URL was previously failing for us, however it now works:
https://d2vjgjl6okzqz8.cloudfront.net/90x278/smart/526535f5afc81614f05b26d2/52652350afc8161e104d5764/2015-03-20-10-35-02-643-01lastarcticice.jpg
We also sometimes get this when using other parameters (eg omitting fit-in). It seems pretty random.

It happens intermittently, and quite often, if we attempt the same job again a few moments later (same url) then it sometimes works ok.
When we change the parameters in the URL slightly, this seems to always mean it works.
We've been so far unable to identify a pattern of when it happens or with what images.

Looking in the CloudWatch logs I find the following messages:
[ERROR]	2018-11-09T18:14:41.970Z	53ead92f-e44b-11e8-8ccd-eb0ffcfa44ce	call_thumbor error: tornado server unavailable, proceeding with tornado
server restart
[ERROR]	2018-11-09T18:14:41.970Z	53ead92f-e44b-11e8-8ccd-eb0ffcfa44ce	lambda_handler error: too many values to unpack
[ERROR]	2018-11-09T18:14:41.971Z	53ead92f-e44b-11e8-8ccd-eb0ffcfa44ce	lambda_handler trace: Traceback (most recent call last):
File "/var/task/image_handler/lambda_function.py", line 353, in lambda_handler
result = call_thumbor(event)
File "/var/task/image_handler/lambda_function.py", line 328, in call_thumbor
thumbor_down, session = is_thumbor_down()
ValueError: too many values to unpack
The stack was built using the following version: serverless-image-handler/v3.0.0/serverless-image-handler.zip

I've also ran into this issue several times:

Having the same issue, seems to be with png only but small sizes as well. Might be related to concurrent access, unsure. Failing images convert fine on a second try.
Commenting pngquant optimizer seems to do some good but too early to tell.

Hi all. We're in the process of updating the solution and have identified several ways to mitigate this issue in the next version. Stay tuned and thanks for your feedback/patience!

I'm having the same issue with jpegs when adding my base64 encoded signature to the beginning of the url as documented here: https://github.com/thumbor/thumbor/wiki/Security

@hayesry Any update on this? We are having the same problem. Can you elaborate on the ways to mitigate this?

The PNG issue for me was happening when using Smart Crop on PNG files utilizing an alpha channel.  The Rekognition support attempts to convert these to jpg to send to Rekognition, and since jpg doesn't support alpha channels, it fails.
To get around this limitation, I'm trying to redeploy without rekognition enabled, and using only the built-in feature detectors, but having issues with mismatches of libcurl 7.53 in lambda vs 7.55 or 7.61 available via yum in amazon redhat docker used for building.

I am also getting Future exception was never retrieved: Traceback, occurs for PNG:
11:09:53 START RequestId: 5ebe7755-a92b-4132-a6ca-164712fe3ca3 Version: $LATEST
11:09:53 [INFO]	2019-05-06T11:09:53.812Z	5ebe7755-a92b-4132-a6ca-164712fe3ca3	200 GET /healthcheck (<IP_ADDRESS>) 2.29ms
11:09:53 [ERROR]	2019-05-06T11:09:53.883Z	5ebe7755-a92b-4132-a6ca-164712fe3ca3	Future exception was never retrieved: Traceback (most recent call last): File "/var/task/tornado/gen.py", line 1107, in run yielded = self.gen.throw(*exc_info) File "/var/task/thumbor/transformer.py", line 152, in smart_detect yield self.do_smart_detection() File "/var/task/tornado/gen.py", line 1099, in run va
11:10:03 END RequestId: 5ebe7755-a92b-4132-a6ca-164712fe3ca3
11:10:03 REPORT RequestId: 5ebe7755-a92b-4132-a6ca-164712fe3ca3	Duration: 10010.49 ms	Billed Duration: 10000 ms Memory Size: 1536 MB	Max Memory Used: 119 MB
11:10:03 2019-05-06T11:10:03.798Z 5ebe7755-a92b-4132-a6ca-164712fe3ca3 Task timed out after 10.01 seconds
11:10:05 START RequestId: 8d465828-7082-4b5a-983a-f659f083aea5 Version: $LATEST
11:10:05 [ERROR]	2019-05-06T11:10:05.885Z	8d465828-7082-4b5a-983a-f659f083aea5	call_thumbor error: tornado server unavailable, proceeding with tornado server restart
11:10:05 [ERROR]	2019-05-06T11:10:05.885Z	8d465828-7082-4b5a-983a-f659f083aea5	lambda_handler error: too many values to unpack
11:10:05 [ERROR]	2019-05-06T11:10:05.886Z	8d465828-7082-4b5a-983a-f659f083aea5	lambda_handler trace: Traceback (most recent call last): File "/var/task/image_handler/lambda_function.py", line 338, in lambda_handler result = call_thumbor(event) File "/var/task/image_handler/lambda_function.py", line 313, in call_thumbor thumbor_down, session = is_thumbor_down() ValueError: too many values to unp
11:10:05 END RequestId: 8d465828-7082-4b5a-983a-f659f083aea5
11:10:05 REPORT RequestId: 8d465828-7082-4b5a-983a-f659f083aea5	Duration: 317.85 ms	Billed Duration: 400 ms Memory Size: 1536 MB	Max Memory Used: 41 MB

I am also getting Future exception was never retrieved: Traceback, occures for PNG with
11:09:53 START RequestId: 5ebe7755-a92b-4132-a6ca-164712fe3ca3 Version: $LATEST
11:09:53 [INFO]	2019-05-06T11:09:53.812Z	5ebe7755-a92b-4132-a6ca-164712fe3ca3	200 GET /healthcheck (<IP_ADDRESS>) 2.29ms
11:09:53 [ERROR]	2019-05-06T11:09:53.883Z	5ebe7755-a92b-4132-a6ca-164712fe3ca3	Future exception was never retrieved: Traceback (most recent call last): File "/var/task/tornado/gen.py", line 1107, in run yielded = self.gen.throw(*exc_info) File "/var/task/thumbor/transformer.py", line 152, in smart_detect yield self.do_smart_detection() File "/var/task/tornado/gen.py", line 1099, in run va
11:10:03 END RequestId: 5ebe7755-a92b-4132-a6ca-164712fe3ca3
11:10:03 REPORT RequestId: 5ebe7755-a92b-4132-a6ca-164712fe3ca3	Duration: 10010.49 ms	Billed Duration: 10000 ms Memory Size: 1536 MB	Max Memory Used: 119 MB
11:10:03 2019-05-06T11:10:03.798Z 5ebe7755-a92b-4132-a6ca-164712fe3ca3 Task timed out after 10.01 seconds
11:10:05 START RequestId: 8d465828-7082-4b5a-983a-f659f083aea5 Version: $LATEST
11:10:05 [ERROR]	2019-05-06T11:10:05.885Z	8d465828-7082-4b5a-983a-f659f083aea5	call_thumbor error: tornado server unavailable, proceeding with tornado server restart
11:10:05 [ERROR]	2019-05-06T11:10:05.885Z	8d465828-7082-4b5a-983a-f659f083aea5	lambda_handler error: too many values to unpack
11:10:05 [ERROR]	2019-05-06T11:10:05.886Z	8d465828-7082-4b5a-983a-f659f083aea5	lambda_handler trace: Traceback (most recent call last): File "/var/task/image_handler/lambda_function.py", line 338, in lambda_handler result = call_thumbor(event) File "/var/task/image_handler/lambda_function.py", line 313, in call_thumbor thumbor_down, session = is_thumbor_down() ValueError: too many values to unp
11:10:05 END RequestId: 8d465828-7082-4b5a-983a-f659f083aea5
11:10:05 REPORT RequestId: 8d465828-7082-4b5a-983a-f659f083aea5	Duration: 317.85 ms	Billed Duration: 400 ms Memory Size: 1536 MB	Max Memory Used: 41 MB

@peterkuiper Thanks for checking in on this, we're currently working through the testing stages of the new version and hope to have it out shortly. We've replaced the Thumbor image handler library with SharpJS to provide for a truly serverless implementation and reduce the technical debt associated with starting up and running the tornado server within the Lambda function. We are also providing built-in mappings to promote compatibility with existing Thumbor URLs, which will hopefully minimize/prevent any rework from needing to be done on the front-end when upgrading to the new version.

@hayesry Thanks for the update! Looking forward to test the new version.

Great news ! Also looking forward to test your new solution !

New version please!

@passledevelopers we were facing the same issue reported by you and also the following error for some requests

We found that the png shared libraries are not included in the Lambda zip file. On further checking the build script https://github.com/awslabs/serverless-image-handler/blob/master/deployment/build-s3-dist.sh we confirmed that it's indeed missed in the build process. Hence we added a step for including the libpng* files as part of the build script to the 'lib' folder inside the zip artifact. We deployed this custom artifact to Lambda and now we are not seeing the same errors again. Not sure whether this is the actual solution to the problem discussed here, however you may try. @hayesry could you confirm?

When are you going to release the fix ?

Resolved with v4.0.0


SourceHut user authorized keys

toastal  Is ~bob or bob considered the “user” in SourceHut land? I’m not entirely sure if the ~ sigil is a part of the username or just an indicator…

pabs3    an indicator, see https://en.wikipedia.org/wiki/Tilde#Directories_and_URLs

toastal  thanks 🙂

I’ve never touched Go before. This is just copy-paste of everything that matched [Gg]itLab

LGTM. Thanks for the contributions! I didn't know about SourceHut, but it looks great! I rebased this PR and ran a make docs to regenerate the docs.

https://github.com/owenthereal/upterm/releases/tag/v0.12.0 includes the changes


[BACKLOG-6829] CSV file import, some date formats are not recognized …

…automatically

Build Commands:
Build:

rm -r ~/.kettle; rm -r ~/.pentaho; echo removed hidden folders
ant -Dpentaho.coding.standards.version=1.0.4 -Djunit.jvmargs=-XX:PermSize=256m -f core/build.xml clean-all resolve jacoco jacoco-integration checkstyle publish-local

Cleanup:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
core/src/org/pentaho/di/core/util/DateDetector.java
core/test-src/org/pentaho/di/core/util/DateDetectorTest.java
Unit test coverage change:
org.pentaho.di.core.util.DateDetector:

instructionPercentCoverageChange : +0.09%
branchPercentCoverageChange : +3.13%
linePercentCoverageChange : +0.24%
complexityPercentCoverageChange : +3.87%
methodPercentCoverageChange : +0.78%


MVP

[ ] LDtk spawning entities
[ ] player animations (death, wall slide, jump)
[ ] screen shake on jump
[ ] particle FX wall slide
[ ] trail for jump
[ ] end scene
[ ] breakable Blocks
[ ] door key combo
[ ] leaderboard/population for completed creatures
[ ] 20 levels
[ ] web build

Maybe the offer in position comes from the pivot location of the scene.
https://github.com/Cammin/LDtkToUnity/issues/30

Maybe the offer in position comes from the pivot location of the scene.
https://github.com/Cammin/LDtkToUnity/issues/30

Screenshake
https://github.com/Eneskp3441/Shaker/wiki

Breakable block logic
extends Area2D

# Time in seconds before the block breaks
var break_time: float = 2.0
var is_broken: bool = false

# Signal to notify when the block breaks
signal block_broken

# Called when a player enters the block area
func _on_BreakableBlock_body_entered(body):
    if body.is_in_group("players") and not is_broken:
        is_broken = true
        # Start a timer to break the block
        yield(get_tree().create_timer(break_time), "timeout")
        break_block()

# Function to handle breaking the block
func break_block():
    emit_signal("block_broken")
    queue_free()  # Remove the block from the scene

# Called when a body exits the block area
func _on_BreakableBlock_body_exited(body):
    # Optional: Handle logic if needed when the player leaves the block
    pass

Spring logic

extends Area2D

# Jump force to apply when the player contacts the spring
var jump_force: float = 600.0

# Called when a player enters the spring area
func _on_Spring_body_entered(body):
    if body.is_in_group("players") and body is CharacterBody2D:
        # Apply the jump force to the player's velocity
        body.velocity.y = -jump_force  # Set the upward velocity

        # Optionally, you can add a visual effect or sound
        _play_spring_effect()

# Function to play a spring effect (optional)
func _play_spring_effect():
    # For example, play a sound or show an animation
    pass

Spring logic

extends Area2D

# Jump force to apply when the player contacts the spring
var jump_force: float = 600.0

# Called when a player enters the spring area
func _on_Spring_body_entered(body):
    if body.is_in_group("players") and body is CharacterBody2D:
        # Apply the jump force to the player's velocity
        body.velocity.y = -jump_force  # Set the upward velocity

        # Optionally, you can add a visual effect or sound
        _play_spring_effect()

# Function to play a spring effect (optional)
func _play_spring_effect():
    # For example, play a sound or show an animation
    pass

Logic for particle FX
https://christinec-dev.medium.com/learn-godot-4-by-making-a-2d-platformer-part-23-particle-effects-10473e650aa7

Leaderboard
https://silentwolf.com/leaderboard

Submittted!!


Integrity constraint violation: 1052 Column 'created_at' in order clause is ambiguous

'php
$tags = $post->tags()->orderBy('created_at', 'desc')->fastPaginate(20);
'
SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'created_at' in order clause is ambiguous

I'm not sure this is a fastPaginate problem. Can you show the SQL or schema? Does it work with the traditional paginate method?


Errors building smartgrid-prediction project

Hi,
I am running into a couple of issues while setting up the smartgrid-prediction repo and would appreciate your assistance. I am using springxd release 1.1.1
Issue 1: I have installed analytic-pmml module in springxd processor via module upload command but the 'predict' stream is not starting and my xd instance throws "Constructor threw exception; nested exception is java.lang.RuntimeException: java.io.FileNotFoundException: class path resource [prediction.pmml] cannot be resolved to URL because it does not exist". I have also noticed that prediction.pmml does not exist in the resource folder of spring-xd-modules/analytics-ml-pmml -- how do I add classpath to prediction.pmml in the prediction folder?
Issue 2: Cannot start Spring boot app via mvn spring-boot:run --- Error in maven compilation step "Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project smartgrid-frontend: Fatal error compiling: invalid target release: 1.8"
Thanks in advance for your guidance.

Issue 1 is likely because the pmml file was not correctly embedded in the module itself, as explained in the note at https://github.com/spring-projects/spring-xd-samples/tree/master/smartgrid-prediction#install-the-analytic-pmml-module. Did you use the shell script to build the module? As that note says, that's not something you would typically do anyway. So if you're running locally, you can just change the stream definition to include
...
analytic-pmml --inputType=application/x-xd-tuple
              --location=file://<path/to/your/local/prediction.pmml>
              --inputFieldMapping='ts:timestamp,house:house'
...

Regarding issue n°2, you'll need to make sure to use JDK8 to compile

Thanks both issues are resolved. I am now able to access the frontend at localhost:8080 but the distribution & load graphs are now showing. Spring boot console shows one error: ERROR 3957 --- [Frontend.main()] f.t.AggregateCounterTimeSeriesRepository : Could not connect to server: http://localhost:9393 Error: SocketTimeoutException: Read timed out
Configuration the location of aggregate counters via -Dsmartgrid.frontend.aggregateCounterUrl=http://localhost:9393/metrics/aggregate-counters is not helping either.
Thanks

Can you see the counters via aggregate-counter list in the shell ?
Le 3 avr. 2015 18:51, "linusviking"<EMAIL_ADDRESS>a écrit :

Thanks both issues are resolved. I am now able to access the frontend at
localhost:8080 but the distribution & load graphs are now showing. Spring
boot console shows one error: ERROR 3957 --- [Frontend.main()]
f.t.AggregateCounterTimeSeriesRepository : Could not connect to server:
http://localhost:9393 Error: SocketTimeoutException: Read timed out
Configuration the location of aggregate counters via
-Dsmartgrid.frontend.aggregateCounterUrl=
http://localhost:9393/metrics/aggregate-counters is not helping either.
Thanks
—
Reply to this email directly or view it on GitHub
https://github.com/spring-projects/spring-xd-samples/issues/31#issuecomment-89351760
.

Yes can see the counters in the shell. Also, after restarting the xd node, I was able to see the graphs in the browser. Many thanks.


improve typescript definitions

I think this also resolves #821 and #747

This encompasses #865, merging that will likely result in unnecessary conflicts.
I think this also resolves #821 and #747

@Falke-Design I think I covered all the areas you mentioned

@ryan-morris what if you use LayerEvent instead of Evented? Event Doku: Events
But it also looks like that map and layers are using LayerEvent together.

@Falke-Design LayerEvent describe the event being passed into the callback function, so that would result in:
layer.on('click', function(ev) {
    ev.on('pm:snap', ......);
});

which isn't a thing. The .off() do need to be added. Those didn't even cross my mind, so I'll get that updated. I haven't had a chance to look into the events in general any more, I am hoping to get a chance next week. Do you know roughly when the next release may be going out?

@ryan-morris This weekend I have a meeting with @codeofsumit to merge the PRs and prepare the release. But I think that some PRs needs a change. It would be good when we release around 14. of May but we will wait on you. This is a very important PR and improvement to the library.
So latest date for release is 21. of May


laravel 5.3

Can laravel-messenger be used on 5.3 ?

Yes, this works on all minor versions of 5, and also 4.2. You can also see a test repo that I use for 5.3 here


minor difference between results in paper and my reproducing results

looks like there Is always a minor gap between your results and mine.
tydiQA:
llama-7b:    "average": {
"f1": 37.98539743712254,
"exact_match": 25.333333333333332
}
tulu-7b:     "average": {
"f1": 43.70682780615583,
"exact_match": 30.0
}
GSM:
llama-7b:{
"exact_match": 0.08
}
why I can't reach the answer? for llama-7b, I download the llama-7b-hf model from HuggingFace at https://huggingface.co/yahma/llama-7b-hf/tree/main
for tulu-7b, I download at https://huggingface.co/allenai/tulu-7b and run the code:python scripts/weight_diff.py recover --path_raw ./llama-7b-hf --path_tuned ./tulu-7b-diff --path_diff ./tulu-7b
and I modify nothing except the batch_size for memory limit, but I don't think it will influence the output.
so can you tell me what's going wrong? I download the code at 10.8

The issue has been resolved. I made changes according to the instructions in the requirements.txt regarding the transformers bug, and now I can obtain normal evaluation scores.

Hi,

Some variation is expected, since generation can sometimes be a bit non-deterministic, even when trying to reduce all sources of variance. Your reported results here are within 1 point of performance on TydiQA, and within 2 points for GSM8k. I think this is okay, and probably this is not a significant difference.

Did you run this with llama 1 or llama 2? We found llama 1 gets 31.5%. You should also evaluate base models without any chat formatting, the command we used is like:

python -m eval.mmlu.run_eval \
    --ntrain 0 \
    --data_dir data/eval/mmlu \
    --save_dir results/mmlu/llama-7B-0shot \
    --model_name_or_path <your_path>/hf_llama_models/7B \
    --tokenizer_name_or_path <your_path>/hf_llama_models/7B \
    --eval_batch_size 4 \
    --load_in_8bit
    ```


Can't debug in terminal when progress bar is running.

Describe the bug
I think the progress bar rendering makes it difficult to debug anything. I often use import ipdb; ipdb.set_trace() before the line I want to debug. Then I call the program using command line like python yolo/lazy.py task=train model=v9-s dataset=mock task.epoch=1 etc.
But, I think the progress bar is getting in the way and the cursor disappears. Can't type anything in the terminal afterward.
Also, if the call to lazy.py fails for some reason, the cursor doesn't appear anymore on that terminal.
I am using WSL. I ran other programs, but this never happened in my other programs.
To Reproduce
Steps to reproduce the behavior:

In the terminal for your environment do pip install ipdb.
In the ModelValidator.solve() call import ipdb; ipdb.set_trace()
Go back to terminal.
See that you can't interact anymore.

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

After running the program from the terminal using python yolo/lazy.py task=train model=v9-s dataset=mock task.epoch=1, the interactive debugging in the terminal no longer works.

System Info (please complete the following ## information):

OS: [Ubuntu 22.04]
Python Version: [3.10]
PyTorch Version: [2.4.0]
CUDA/cuDNN/MPS Version: []
YOLO Model Version: [YOLOv9-s]

Additional context

A temporary solution that is working for me is never setting
progress.start() in lazy.py. I'll test today if this solution keeps working I'll close the issue.

https://github.com/Megvii-BaseDetection/YOLOX/issues/843
this also helped when debugging dataloader.
set cpu_num to zero in genera.yaml

We need to find a way to enable debugging while using this rich library.
Can't set debug points using ipdb, once a loop is started using track.
Debugging this repo is unnecessarily hard due to this rich library.


[ServiceBus] remove network trace params from extra in pyamqp logging

related to #32190
following #32215
TODO:

[ ] sync changes with EH pyamqp + README

can we add the same changes in to EH as well please 🙂

API change check
API changes are not detected in this pull request.

/azp run python - servicebus - tests

/azp run python - eventhub - tests

closing in favor of #34458


config seems to ignored, failover missing

Since updating the package I have the following issues:

wrong locales showing up and mine are missing on empty entries

array key should not be resolved from config as the entry might not exist

adding them temporary does not resolve key properly even though it works in list view

my locals settings:
    'locals' => [
        'de' => [
            'label' => 'German',
            'flag' => 'de',
        ],
        'en' => [
            'label' => 'English',
            'flag' => 'us',
        ],
    ],

wrong locales showing up and mine are missing on empty entries

I had this same issue. Turns out the FilamentTranslationComponent that powers the editing has its own config file, and changing it there worked for me. So you need the locals array in both:

config/filament-translations.php
config/filament-translation-component.php

Short term, I think an update to the installation / config steps would be helpful here. I get why they're separate (so you can use the component without the main plugin), but long-term it would be nice to be able to specify a list of locales once and have both parts reference it.

hi, @dave-mills @mrvnklm I will try to make it 1 config on the translation component or main package to make it more easy.

it's fine now you can check the last version.

I am still getting Undefined array key "ar" when I remove ar from locals like
    'locals' => [
        'de' => [
            'label' => 'German',
            'flag' => 'de',
        ],
        'en' => [
            'label' => 'English',
            'flag' => 'us',
        ],
    ],

There should be a fallback when the key is not found instead of an exception


source ./venv/bin/activate doesnt work in fish

Works fine with bash, but not fish.

./venv/bin/activate.fish

Oh, thank you


Added first Beam integration test

This should fix some problems of the original version

hmm, I'm not too sure about the point of this PR. If @fpompermaier wants to work on Beam integration in a branch of this repo, then he should be given commit rights to that branch (I don't see why it would be easier here than in fpompermaier:apache-beam though).
In any case we should keep pull requests for actual discussions about changes, where code is properly reviewed.

@thadguidry yeah let's just give him push access!

@fpompermaier You should have received an Invite email to be added as an "External Collaborator" to our project.  Please accept that invite and then I can add your username to this new branch, so that you can push directly.


Modify child command logic to allow for meaningful usage on subcommand failure

SpongeAPI | SpongeCommon
One of the long standing issues with the Command API is that subcommands don't give useful feedback if a command fails. The current implementation of the command system is difficult to solve this effectively with - this is a best effort. It isn't breaking, but in order to activate behaviour where a subcommand failing gives meaningful usage requires childArgumentParseExceptionFallback on the CommandSpec builder to be set to false. It defaults to true, the current behaviour.
I felt it was better to propose this fix for API 7, even though #1587 will completely eclipse this in API 8. It gives devlopers the choice on how to handle their subcommands now. It honestly feels a little hacky, but it works. In theory, there is nothing stopping this going into API 5 and 6 either. Note that any plugin that doesn't use this method in the builder will get the old behaviour, so the change isn't breaking API wise or behaviour wise, plugins will have to update to use this new behaviour - there are some plugins out there, no doubt, that use the fallback as it is now.
Comments are welcome on naming (it's not my strong suit). Test plugin included in Common, some unit tests in API.
Fixes #1165, fixes #1272, fixes #1542, fixes #1647

I'll merge this tomorrow if there are no late objections or naming suggestions. Would do it tonight, but other things are currently on my plate.


real world eval

Hi,
I am wondering could you please provide a script or tutorial for evaluating the policy in the real world robot?
Thanks.

Hi, thank you for your interest.
I would possibly make a tutorial in the near future, but for now you could maybe check how we evaluate the policy in the simulation (basically it is just Markov decision process)


Transparency

What's the recommended way of making the background transparent in this theme?
I can run run hi Normal ctermbg=NONE guibg=NONE after starting Vim to remove most of the background (the line numbers still have a solid background), but it does nothing in my .vimrc:
colorscheme space-vim-dark
hi Normal ctermbg=NONE guibg=NONE
hi MatchParen cterm=underline ctermbg=NONE

I could probably use an autocommand but surely there's a better way? :slightly_smiling_face:

Works for me.

Have you put the two lines at the end of your .vimrc?
colors space-vim-dark
hi Normal ctermbg=NONE guibg=NONE

I had the lines in my config, but they were not the last, apparently some plugin must've overwritten them.
Lighting fast answer, thanks for that!

FWIW: The above instructions didn't work for me, but it did work when I added "hi Normal ctermbg=NONE guibg=NONE" to the end of my ~/.SpaceVim/main.vim file.


verifier/snp: check for attestation report version causing verifier to fail

The check for the attestation report version is causing an error in the verifier due to a recent update  changing the version and structure of the attestation report. A stakeholder from the confidential community brought up this concern.
ERROR kbs::http::error] Attestation failed: Verifier evaluate failed: Unexpected report version

There are 2 proposals to fix this issue:

Skip the check for the report version
Change the check from report.version != 2 to report.version != 3 or report.version >= 2

Fixed by Trustee PR#590


[Wallet] Add resend button to VerificationInputScreen

Description

Remove "I already received three codes" and merge its logic into "Resume" button on the VerificationEducation screen.
Add "Resend N messages" on the VerificationInput screen. Button is only available after a minute since the last reveal. When pressed we will try to reveal already existing attestations first. If HTTP call to attestation-service returns anything, but OK we request another issuer and try to reveal the number to it. Those we increase number of actionable attestations till the limit 5, after which user need to wait until some attestations expire to request more.
Updated text for "Do I need to confirm" dialog in English.

See figma for more details.
Tested
iOS & Android with actual requesting of SMSs
Related issues

Part of https://github.com/celo-org/celo-monorepo/issues/4563

Backwards compatibility
Yes
Screenshots

There is a vulnerability which does not have a fix yet https://www.npmjs.com/advisories/1560/versions and it blocks the build

Hi @tarikbellamine Can you please give access to below id for figma screen (https://www.figma.com/) to verify this task
Account<EMAIL_ADDRESS>

Hi @tarikbellamine I have verified this task test flight build (25) & Android internal build Android internal build 1.2.0(1004294313) and observe the following
Device: iPhone 11 (14iOS), Samsung Galaxy A70(9.0)
Test plan link: https://docs.google.com/spreadsheets/d/1phHo7MUMQNLjuJOic1TlZwoHM2T0iecT07VLoKtiqMg/edit#gid=1211519342
Need Clarification:

Blank fields is shown on First & second Confirm code fields when user go back and open confirm page
"Verification Error " message is shown when user paste third code from Resend messages
can you please confirm that  i need file  issues for the same


app audio signal function is ambiguous

signal function at line 273 is ambiguous
with ei::signal

Fixed in https://github.com/edgeimpulse/example-standalone-inferencing-linux/pull/20


Feat: CoreForkBase

This is a draft PR, and it doesn't compile.
Before investing a bunch of time in refactoring, this is a blueprint of how I imagine the test suite to be modular:

Tests
Protocol
Environment

Let's start from the ground up:

Environment: It sets the environment where the tests will run. This can be one of: [Mock, Local, Fork]. It creates the contracts that the tests access.
Protocol: This is a very thin layer and serves as an API between the Tests and Environment. Basically it informs the tests on what contracts are made available by the Environment. In the current PR this layer is integrated into the Environment.
Test: The actual tests (e.g ReplicaTest).

With this design, we have the following contract inheritance:|

FORK: ForCore --> ForkBase --> Replica Test
LOCAL: LocalCore (refactor of NomadBase.sol) --> Replcia Test
MOCK: MockCore -> Replica Test

I have added Mock because it's helpful to test some system parts in isolation. For example, Bridge tests might be Local
(LocalBridge) for the bridge contracts but MockCore for the Core contracts.
Before diving into refactoring NomadBase to be able to properly inherit ReplicaTest to a ForkReplicaTest, I want to ask for some feedback. I spent some time thinking about how I should go about this, and this approach seems the sanest -- assuming we want modularity between the systems (fork, local, etc.) and not build them in isolation.
For the actual inheritance, I imagine all the test contracts to be abstract and then have:

ReplicaTest as abstract
LocalReplicaTest is ReplicaTest, LocalCore
EthProdReplicaForkTest is ReplicaTest, EthProdCoreFork

I think we will refactor to something along these lines very soon, esp once foundry race condition for fork testing is solid

I think we will refactor to something along these lines very soon, esp once foundry race condition for fork testing is solid. For now, closing the PR as i believe it was mostly meant to be illustrative


Retain user roles after login and pass on destination parameter

This will allow the users logging in using OneLogin to retain their roles on next login (e.g. a user logins using OneLogin where he will get a default assigned role, an admin can assign additional roles to that users from backend and we never check for existing roles). By adding this line, we pull the existing roles a user may have.
The check for RelayState and passing destination parameter in "Login using SAML" link is related. When we pass a destination parameter, the response from OneLogin will contain the destination in the RelayState parameter so we can redirect the users to that page after logging in using SAML.

We should add a settings in order to define if the roles of an user that already exists should be sync with the IdP's roles or should be a mix of pre-defined roles + new roles.

That's a better way to do it for sure. Let me see if I can work something up.


main.py, no EmpowermentSkills

from maml_rl.policies.empowerment_skills import EmpowermentSkills

Yes. I am aware of this. I am still refactoring the code. This should be addressed in the next commit.

Same issue, seems the author cannot fix it for 2 years


v2.8.0 not available via Brew

brew install gimme-aws-creds still installs v2.7.2_3
Expected Behavior
brew install gimme-aws-creds should install the latest release (v2.8.0)
Current Behavior
Version 2.7.2_3 is the highest version available
Possible Solution
Bottle 2.8.0 and make available via brew
Steps to Reproduce (for bugs)

brew install gimme-aws-creds
Version 2.7.2_3 is installed

Context
I wish to use the 'acc' name for credential profiles, which was added as a feature in v2.8.0.

2.8.1 should be available in Homebrew when it is released next week


Add thumbnail images to the forum

There is a telescope package for this:
https://github.com/TelescopeJS/Telescope/tree/master/packages/telescope-embedly
I've also added our Embedly API key to the settings on prod.
I've shared the account info with you @yourcelf too.  I think we just need to add this image to our custom design.
@constantx can advise about specific look or just modify the style after we have the thumbnails in place.
In the meantime, we're doing a super hack by placing the image in the body of the question.

you can see thumbnails working here too: http://demo2.telescopeapp.org/

What do you envision the thumbnails to be of in our installation?
The built-in embedly plugin takes a snapshot of the target page of the URL for a post.  But none of our posts have URLs -- they're all "self" posts, just a title and sometimes a body.

Ideally an image Dan uploads himself.

On Oct 7, 2015, at 8:17 PM, Charlie DeTar<EMAIL_ADDRESS>wrote:
What do you envision the thumbnails to be of in our installation?
The built-in embedly plugin takes a snapshot of the target page of the URL for a post. But none of our posts have URLs -- they're all "self" posts, just a title and sometimes a body.
—
Reply to this email directly or view it on GitHub.

So thumbnails should be editable by admins/officers?  Should they be editable by regular users?

BTW, if we want to explicitly choose the thumbnail, we'll need to do this custom.  The embedly implementation ties the thumbnail to the post URL and doesn't allow you to choose your own thumbnail.

Looks like this is implemented in https://github.com/AdmitHub/Telescope/pull/12 ?

Yes


Saavn (saavn.com) support

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.10.02. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.10.02

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Examples:

Single audio: http://www.saavn.com/s/song/hindi/Ae-Dil-Hai-Mushkil/Ae-Dil-Hai-Mushkil/Cg0AdD0DeQU
Playlist: http://www.saavn.com/s/featured/hindi/Raghu_Dixit_-Coke_Studio_Picks/NGesoSZlFG4

+1 to this site if possible.

@yan12125 this one is more like spotify (https://www.spotify.com) but for indian songs mostly. Though its pretty easy to extract songs from this site but tbh you don't wanna add it. copyright & stuff!

@sudovijay Did you mean saavn.com does not have rights to distribute those songs? Seems Google's transparency report indicates the opposite: https://www.google.com/transparencyreport/removals/copyright/searchdata/domains/?id=saavn.com

It does have rights if not they wouldn't be able to operate commercially.
Also I think all of the content are DRM protected.

There is false dichotomy at work here. For instance, no youtube does not but it still does. Some music providers (like shemaroo.com) have stopped all their videos on youtube.com but that does not mean that the whole platform is wrong.
Also if the songs are DRM protected then AFAIK they can be done only through copyright holders only so there certainly is mix-up there. https://en.wikipedia.org/wiki/Digital_rights_management . I would assume and presume it would be highly costly and expensive for saavn or any other digital audio service provider to become false owners of intellectual property. There has to be a deal between the companies. Also see http://www.saavn.com/corporate/music-rights as well as http://www.medianama.com/2016/11/223-saavn-singtel-music-singapore/ and http://www.medianama.com/2016/06/223-saavn-funding-guy-oseary/ . They have done 3-4 rounds of fund-raising.  At the very least, no research seems to have been done and facts pulled out of air.
Disclaimer - I have no other relationship with saavn except I use their app. on my android phone as well.

Issue should be closed, proxy needed


Clarify use of labels and groups together

Why:

Saying "and/or" when in fact the requirement is "and" is misleading.
Saying "ARC does not support multiple labels" in an article that explains how to use multiple labels with ARC is extra confusing. See #35714 for more details.

What's being changed (if available, include any code snippets, screenshots, or gifs):
As correctly explained under Using labels and groups to route jobs, when you combine groups and labels, the runner must meet both requirements to be eligible to run the job. Therefore, a statement like "GitHub looks for a runner that matches the job's runs-on labels and/or groups" is confusing and wrong. The runner must match the job's labels and groups and will not be selected if it only matches the job's labels or groups but not both. So all the "and/or" instances have been changed to "and".
Reference to ARC at the top of the article has been changed to a reference to Runner Scale Sets for accuracy. The Note has been upgraded to Important because the entire article does not apply if you are using Runner Scale Sets.
Check off the following:

[x] A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
[x] The changes in this PR meet the docs fundamentals that are required for all content.
[x] All CI checks are passing.

@Nuru Thanks so much for opening a PR! I'll get this triaged for review ✨


[europaconsilium] Add extractor (closes #20679)

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[x] New extractor
[x] New feature

Description of your pull request and other information
Adds an extractor for video.consilium.europa.eu and support for the language tags used by it to the kaltura extractor. Currently, the extracted timestamp is wrong.<PHONE_NUMBER> is reported for the test video, which is on 6 March instead of 18 March.) There is a correct timestamp in info['ScheduleStart'], however this is in local (Brussels) time and not UTC. Also, some HLS formats are reported as video only even if they contain audio due to referencing an audio group. Not sure how to fix this as that would break other videos (#11995).

Fixed conflicts.


Will this work with Cycle.js?

Just wondering if core can be used interchangeably with @cycle/most-run? or if it's best to stick with the main most library for now?
FYI... Definitely liking the direction you're taking most ...towards a more classical frp approach (i.e. continuous time, behaviors, etc). Excited for what's to come!

Check out @TylorS' Motorcycle framework, which is an adaptation of Cycle.js built around Most.js, with some other enhancements too.

ohh... my understanding was that Cycle.js union was a collaborative effort to bring the two projects together. Didn't realize Motorcycle was still an active project in its own right. I'll definitely revisit. Thanks @axefrog!

Currently Cycle.js does not support @most/core as it's not reached v1 yet. Motorcycle has become more of it's own project and no longer tries to be 1:1 with Cycle as it was in the beginning (expect more and more differences in the future) but also does not yet support @most/core, but that work will be done in due time.

Great Thanks for the insight @TylorS.

@mjleitch Just wanted to let you know https://github.com/motorcyclets/motorcycle is 100% @most/core ready now!

@TylorS- Ha! I just stumbled across the latest a couple hours ago! I have a couple questions... but they seem more appropriate for gitter, so I'll hit you up in there. Thanks!


Documentation defaults to old version

When hitting http://flask-admin.readthedocs.org/, I'm confronted with v1.0.9 of the docs. Is there a setting to always default to latest?

Made it always show latest docs by default. Thanks.


The avahi daemon keeps detecting hostname conflicts

We have noticed that avahi-daemon sometimes produces a lot of log output because it keeps detecting hostname conflicts:
Mar 20 11:39:29 lxatac-00015 avahi-daemon[306]: Host name conflict, retrying with lxatac-00015-30
Mar 20 11:39:29 lxatac-00015 avahi-daemon[306]: Registering new address record for 2a0a:edc0:1:2:1a74:e2ff:fea0:113 on tac-bridge.*.
Mar 20 11:39:29 lxatac-00015 avahi-daemon[306]: Registering new address record for <IP_ADDRESS> on tac-bridge.IPv4.
Mar 20 11:39:29 lxatac-00015 avahi-daemon[306]: Registering new address record for ::1 on lo.*.
Mar 20 11:39:29 lxatac-00015 avahi-daemon[306]: Registering new address record for <IP_ADDRESS> on lo.IPv4.
Mar 20 11:39:49 lxatac-00015 avahi-daemon[306]: Server startup complete. Host name is lxatac-00015-30.local. Local service cookie is<PHONE_NUMBER>.
Mar 20 11:39:49 lxatac-00015 avahi-daemon[306]: Withdrawing address record for <IP_ADDRESS> on tac-bridge.
Mar 20 11:39:49 lxatac-00015 avahi-daemon[306]: Withdrawing address record for ::1 on lo.
Mar 20 11:39:49 lxatac-00015 avahi-daemon[306]: Withdrawing address record for <IP_ADDRESS> on lo.
Mar 20 11:39:49 lxatac-00015 avahi-daemon[306]: Host name conflict, retrying with lxatac-00015-31
Mar 20 11:39:49 lxatac-00015 avahi-daemon[306]: Registering new address record for 2a0a:edc0:1:2:1a74:e2ff:fea0:113 on tac-bridge.*.
Mar 20 11:39:49 lxatac-00015 avahi-daemon[306]: Registering new address record for <IP_ADDRESS> on tac-bridge.IPv4.
Mar 20 11:39:49 lxatac-00015 avahi-daemon[306]: Registering new address record for ::1 on lo.*.
Mar 20 11:39:49 lxatac-00015 avahi-daemon[306]: Registering new address record for <IP_ADDRESS> on lo.IPv4.
Mar 20 11:40:09 lxatac-00015 avahi-daemon[306]: Server startup complete. Host name is lxatac-00015-31.local. Local service cookie is<PHONE_NUMBER>.
Mar 20 11:40:09 lxatac-00015 avahi-daemon[306]: Withdrawing address record for <IP_ADDRESS> on tac-bridge.
Mar 20 11:40:09 lxatac-00015 avahi-daemon[306]: Withdrawing address record for ::1 on lo.
Mar 20 11:40:09 lxatac-00015 avahi-daemon[306]: Withdrawing address record for <IP_ADDRESS> on lo.

We should find out why that is and if we even need an avahi-daemon on the TAC or if it can be replaced by systemd-resolved.

This looks to be https://github.com/avahi/avahi/issues/117.

We have not observed this since #137 was merged and since that PR is part of the v24.09 release now I feel confident in closing this.


Layouts and flash messages

This PR solidifies shared layouts and flash messaging.

Merging for now. Let's explore more composable layout calling in the future!


feat: add Slack plugin

❯ go run . help slack
Scan Slack team for sensitive information.

Usage:
  2ms slack --token TOKEN --team TEAM [flags]

Flags:
      --channel stringArray   Slack channels to scan
      --duration duration     Slack backward duration for messages (ex: 24h, 7d, 1M, 1y) (default 336h0m0s)
  -h, --help                  help for slack
      --messages-count int    Slack messages count to scan (0 = all messages)
      --team string           Slack team name or ID [required]
      --token string          Slack token [required]

Global Flags:
      --all                scan all plugins (default true)
      --log-level string   log level (trace, debug, info, warn, error, fatal) (default "info")
      --tags strings       select rules to be applied (default [all])

Like in Discord, more knowledge is required to integrate this plugin into an E2E system. For example, except for retrieving the token (from OAuth & Permissions in the Slack App page), you have to add your app to each channel you want to read.

@joaopedrocsilva @cx-monicac @jossef Please review, I left a few comments about things I want you to see.
This PR introduces a new way to work with CLI args, and includes unit-tests (with mock by interface).


png to placeholder is not clear

Hi Steve,
wehen i insert png to placeholder, the picture is not clear in ppt, but the original png is quite good if i manually paste to ppt, any suggestion for this? thx
placeholder.insert_picture('my-image.png')

Is it a picture placeholder? What do you mean specifically by "not clear in ppt"?

Hi Steve,
yes, it is a picture placeholder, the png looks quite ok when I download the png in browser, but when i pass it to server and save it to the placeholder, it is fuzzy n blurry

Hmm, I'm afraid "fuzzy n blurry" isn't much to go on for diagnosis purposes. Can you attach a screenshot or attach an example?

Hi Steve, you can find the png downloaded in browser n in ppt attached,
on client i use canvas.toDataURL("image/png"); to pass png to server, then on server side i write the png to temp folder and insert to placeholder,
with open(path.join(settings.MEDIA_ROOT, 'temp.png' ), "wb") as fh:
        fh.write(base64.decodestring(img))
slide1.placeholders[14].insert_picture(path.join(settings.MEDIA_ROOT, 'temp.png' ))

Hi Steve, any advice on this pls, thx

@scanny

Hmm, sorry, somehow my message back got eaten by GitHub or something.
What I had asked in response was:
Can you resend the .pptx file? I don't find it attached.

my.pptx.txt
@scanny
pls remove the .txt then open it as pptx, thx

Ok, now I can see what you're describing. The problem is simple. The image being inserted is first of all a raster image (made up of pixels, not lines or vectors). Second, it is small (395px x 440px) relative to the chart placeholder. So the image simply gets graining when it is scaled up.
If you want better results, use a bigger raster image or find a vector format that will work.


Introduce Strongly Typed Dependency Block

Improve the discoverability and other aspects of dependency handling with a more strongly-typed dependency block.
Spec: https://docs.google.com/document/d/1jKKRdFMCsYQ0b0poPK5wHKb01Ng1f1_0Ou9VOhqCO3E/edit?usp=sharing

Related work: #20868

Spec not readable :(

Unfortunately, I can't make it public, so please request access and I will grant permissions to view.


changed OS min supported version

@srinathvasireddy : Thanks for your contribution! The author, @markgalioto, has been notified to review your proposed change.


Card #210 / The issue in [POST/email/changePlaceStatus] with Response 200 OK solved.

Add NotFoundException handling in sendChangePlaceStatusEmail method to return 404 when authorEmail is not found in database

The sendChangePlaceStatusEmailTest test has been changed and the sendChangePlaceStatusEmailTest_UserNotFound test has been added.


Get error when using client routing

Description
When I use client routing by set export const clientRouting = true; on _default.page.client.js, but I get an error on the browser.
I saw an assertServerRouting assertion at the client/entry.ts. I think it does not make sense 🤔.
Error Message + Error Stack
Error<EMAIL_ADDRESS>Usage] `import { something } from 'vite-plugin-ssr/client/router'` is forbidden when using Server Routing
    at assertServerRouting (entry-client-routing.2f516636.js:63:4480)
    at entry-client-routing.2f516636.js:66:11032

Just released 0.4.105 which contains refactored assertions.
Closing but I'll re-open if you still encounter your problem. Keep me updated.


[SPARK-37062][SS] Introduce a new data source for providing consistent set of rows per microbatch

What changes were proposed in this pull request?
This PR proposes to introduce a new data source having short name as "rate-micro-batch", which produces similar input rows as "rate" (increment long values with timestamps), but ensures that each micro-batch has a "predictable" set of input rows.
"rate-micro-batch" data source receives a config to specify the number of rows per micro-batch, which defines the set of input rows for further micro-batches. For example, if the number of rows per micro-batch is set to 1000, the first batch would have 1000 rows having value range as 0~999, the second batch would have 1000 rows having value range as 1000~1999, and so on. This characteristic brings different use cases compared to rate data source, as we can't predict the input rows for rate data source like this.
For generated time (timestamp column), the data source applies the same mechanism to make the value of column be predictable. startTimestamp option defines the starting value of generated time, and advanceMillisPerBatch option defines how much time the generated time should advance per micro-batch. All input rows in the same micro-batch will have same timestamp.
This source supports the following options:

rowsPerBatch (e.g. 100): How many rows should be generated per micro-batch.
numPartitions (e.g. 10, default: Spark's default parallelism): The partition number for the generated rows.
startTimestamp (e.g. 1000, default: 0): starting value of generated time
advanceMillisPerBatch (e.g. 1000, default: 1000): the amount of time being advanced in generated time on each micro-batch.

Why are the changes needed?
The "rate" data source has been known to be used as a benchmark for streaming query.
While this helps to put the query to the limit (how many rows the query could process per second), the rate data source doesn't provide consistent rows per batch into stream, which leads two environments be hard to compare with.
For example, in many cases, you may want to compare the metrics in the batches between test environments (like running same streaming query with different options). These metrics are strongly affected if the distribution of input rows in batches are changing, especially a micro-batch has been lagged (in any reason) and rate data source produces more input rows to the next batch.
Also, when you test against streaming aggregation, you may want the data source produces the same set of input rows per batch (deterministic), so that you can plan how these input rows will be aggregated and how state rows will be evicted, and craft the test query based on the plan.
Does this PR introduce any user-facing change?
Yes, end users can leverage a new data source in micro-batch mode of streaming query to test/benchmark.
How was this patch tested?
New UTs, and manually tested via below query in spark-shell:
spark.readStream.format("rate-micro-batch").option("rowsPerBatch", 20).option("numPartitions", 3).load().writeStream.format("console").start()

Test build #144432 has started for PR 34333 at commit 2534675.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48905/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48904/

Test build #144432 has finished for PR 34333 at commit 2534675.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #144431 has finished for PR 34333 at commit affad64.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class RatePerEpochMicroBatchStream(
case class RatePerEpochStreamOffset(offset: Long, timestamp: Long) extends Offset
case class RatePerEpochStreamMicroBatchInputPartition(
class RatePerEpochStreamMicroBatchPartitionReader(
class RatePerEpochProvider extends SimpleTableProvider with DataSourceRegister
class RatePerEpochTable(

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144432/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144431/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48959/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48959/

Just pushed a commit addressing...

doc review comment
fix a bug for Trigger.Once / Trigger.AvailableNow triggers (with adding UTs)

@viirya @xuanyuanking Please take a look again. Thanks in advance!

Test build #144800 has started for PR 34333 at commit cc48368.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49270/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49270/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49270/

Test build #144800 has finished for PR 34333 at commit cc48368.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144800/

Thanks! Merging to master.


Update Travis CI configuration

Take inspiration by the petgraph-graphml Travis configuration.

Add Clippy tests for stable, beta, and nightly.
Add a minimal versions test.

bors r+


Gstreamer operations not permitted on latest container builds

Hi, running the 2022-08-09T14-21-00Z-prod container and invoking Gstreamer outputs the following errors:
ERROR     GST_PLUGIN_LOADING gstpluginloader.c:442:gst_plugin_loader_try_helper: Spawning gst-plugin-scanner helper failed: Failed to close file descriptor for child process (Operation not permitted)

GStreamer-WARNING **: 10:44:03.965: External plugin loader failed. This most likely means that the plugin loader helper binary was not found or could not be run. You might need to set the GST_PLUGIN_SCANNER environment variable if your setup is unusual. This should normally not be required though.

GStreamer-WARNING **: 10:44:04.256: Failed to load plugin '/usr/lib/x86_64-linux-gnu/gstreamer-1.0/libgstxvimagesink.so': libXv.so.1: cannot open shared object file: No such file or directory

GStreamer-WARNING **: 10:44:04.316: Failed to load plugin '/usr/lib/x86_64-linux-gnu/gstreamer-1.0/libgstfluidsynthmidi.so': libfluidsynth.so.3: cannot open shared object file: No such file or directory

GLib-ERROR **: 10:44:04.323: file ../../../glib/gthread-posix.c: line 1339 (g_system_thread_new): error 'Operation not permitted' during 'pthread_create'

probably is reason for #24 ?

It's better to not rely on the timestamp in the image tag, because recent builds not always the latest.
Operation not permitted can be fixed by running container with privileged flag.


Android Basics: Introduction to Coroutines in Kotlin Playground - 3. Asynchronous code - dead link

In the section:
Note: As a real-world example of async(), you can check out this part of the [Now in Android app](https://github.com/android/nowinandroid). In the [SyncWorker](https://github.com/android/nowinandroid/blob/main/sync/work/src/main/java/com/google/samples/apps/nowinandroid/sync/workers/SyncWorker.kt#L65) class, the call to sync() returns a boolean if the sync to a particular backend was successful. If any of the sync operations failed, then the app needs to perform a retry.
The link to SyncWorker.kt links through a non existant java folder, should be kotlin

Closing, duplicate of #15


fix sstore/sload gasCost

This PR fix problems on:

SLOAD gas cost
SSTORE gas cost
nonce not incremented correctly in eth_call() transations.

Close issue #254


Help need to add a private registry to containerd / k3s

Hi All,
i have deplyed k3s with containerd backend and i have a Nexus private registry on http.
i have been able to locate this doc https://github.com/containerd/cri/blob/master/docs/registry.md
Environmental Info:
K3s Version:
1.20 latest stable
and i have add the below to /etc/containerd/config.toml
# Config file is parsed as version 1 by default.
# To use the long form of plugin names set "version = 2"
# explicitly use v2 config format
version = 2

[plugin."io.containerd.grpc.v1.cri".registry.mirrors]
  [plugin."io.containerd.grpc.v1.cri".registry.mirrors."test.http-registry.io"]
    endpoint = ["http://<<IP>>:32000"]
[plugin."io.containerd.grpc.v1.cri".registry.configs."test.http-registry.io".tls]
  insecure_skip_verify = true

failed to resolve reference "<<IP>>:32000/prod/jacket:1": failed to do request: Head "https://<<IP>>:32000/v2/prod/jacket/manifests/1": http: server gave HTTP response to HTTPS client

helping someone will be able to help me to get it to work.

https://rancher.com/docs/k3s/latest/en/installation/private-registry/

https://rancher.com/docs/k3s/latest/en/installation/private-registry/

Hey @brandond I have tried this setup without tls and still get the same outcome :)
Im able to access my provide registry out side on k3s and pull images

Hey @brandond I have tried this setup without tls and still get the same outcome :)
Im able to access my provide registry out side on k3s and pull images

Can you provide an example of both your registries.yaml, and the pod spec referencing the image on your private registry that is failing to pull?

Can you provide an example of both your registries.yaml, and the pod spec referencing the image on your private registry that is failing to pull?

@brandond
If I do the below
sudo crictl pull <<IP>>:32000/prod/jacket:1 to pull the image into containerd I get the error advised in the first post.
if I do it with docker as I have allowed docker to connect to the registry on http it will pull the image.
So I know there is no issue with the nexus registry
Just having issue with containerd being able to connect over http as my k3s is using the  containerd backend not docker backend.
Nexus deployment yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: nexus-deployment
  namespace: utilities
  labels:
    app: nexus
spec:
  replicas: 1
  selector:
    matchLabels:
      app: nexus
  template:
    metadata:
      labels:
        app: nexus
    spec:
      volumes:
        - name: utilities-nexus
          persistentVolumeClaim:
            claimName: utilities-nexus
      containers:
        - name: nexus
          image: docfactory/nexus:latest
          imagePullPolicy: IfNotPresent
          env:
            - name: TZ
              value: 'Australia/Sydney'
            - name: DOCKUID
              value: '1000'
            - name: DOCKGID
              value: '1000'
            - name: DOCKUPGRADE
              value: '1'
          resources:
            limits:
              cpu: '4'
              memory: 2Gi
            requests:
              cpu: '200m'
              memory: 500Mi
          ports:
           - containerPort: 8081
           - containerPort: 32000
              # Use the localhost:32000 path to use image from registry service
              # e.g.  image: localhost:32000/hello-app:v3
          volumeMounts:
            - name: utilities-nexus
              mountPath: "/nexus-work"

Deployment reference private registry
apiVersion: apps/v1
kind: Deployment
metadata:
  name: jackett-deployment
  namespace: media
  labels:
    app: jackett
spec:
  replicas: 1
  selector:
    matchLabels:
      app: jackett
  template:
    metadata:
      labels:
        app: jackett
    spec:
      volumes:
        - name: media-jackett
          persistentVolumeClaim:
            claimName: media-jackett
        - name: media-download
          persistentVolumeClaim:
            claimName: media-download
      containers:
        - name: jackett
          image: <IP_ADDRESS>:32000/jackett:1
          imagePullPolicy: Always
          env:
            - name: DOCKUID
              value: '112'
            - name: DOCKGID
              value: '115'
            - name: DOCKUPGRADE
              value: '1'
          resources:
            limits:
              cpu: '100m'
              memory: '1Gi'
            requests:
              cpu: '50m'
              memory: '500Mi'
          ports:
           - containerPort: 9117
              # Use the localhost:32000 path to use image from registry service
              # e.g.  image: localhost:32000/hello-app:v3
          volumeMounts:
            - name: media-jackett
              mountPath: "/config"
            - name: media-download
              mountPath: "/downloads"

@brandond
If I do the below
sudo crictl pull <<IP>>:32000/prod/jacket:1 to pull the image into containerd I get the error advised in the first post.
if I do it with docker as I have allowed docker to connect to the registry on http it will pull the image.
So I know there is no issue with the nexus registry
Just having issue with containerd being able to connect over http as my k3s is using the  containerd backend not docker backend.
Nexus deployment yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: nexus-deployment
  namespace: utilities
  labels:
    app: nexus
spec:
  replicas: 1
  selector:
    matchLabels:
      app: nexus
  template:
    metadata:
      labels:
        app: nexus
    spec:
      volumes:
        - name: utilities-nexus
          persistentVolumeClaim:
            claimName: utilities-nexus
      containers:
        - name: nexus
          image: docfactory/nexus:latest
          imagePullPolicy: IfNotPresent
          env:
            - name: TZ
              value: 'Australia/Sydney'
            - name: DOCKUID
              value: '1000'
            - name: DOCKGID
              value: '1000'
            - name: DOCKUPGRADE
              value: '1'
          resources:
            limits:
              cpu: '4'
              memory: 2Gi
            requests:
              cpu: '200m'
              memory: 500Mi
          ports:
           - containerPort: 8081
           - containerPort: 32000
              # Use the localhost:32000 path to use image from registry service
              # e.g.  image: localhost:32000/hello-app:v3
          volumeMounts:
            - name: utilities-nexus
              mountPath: "/nexus-work"

Deployment reference private registry
apiVersion: apps/v1
kind: Deployment
metadata:
  name: jackett-deployment
  namespace: media
  labels:
    app: jackett
spec:
  replicas: 1
  selector:
    matchLabels:
      app: jackett
  template:
    metadata:
      labels:
        app: jackett
    spec:
      volumes:
        - name: media-jackett
          persistentVolumeClaim:
            claimName: media-jackett
        - name: media-download
          persistentVolumeClaim:
            claimName: media-download
      containers:
        - name: jackett
          image: <IP_ADDRESS>:32000/jackett:1
          imagePullPolicy: Always
          env:
            - name: DOCKUID
              value: '112'
            - name: DOCKGID
              value: '115'
            - name: DOCKUPGRADE
              value: '1'
          resources:
            limits:
              cpu: '100m'
              memory: '1Gi'
            requests:
              cpu: '50m'
              memory: '500Mi'
          ports:
           - containerPort: 9117
              # Use the localhost:32000 path to use image from registry service
              # e.g.  image: localhost:32000/hello-app:v3
          volumeMounts:
            - name: media-jackett
              mountPath: "/config"
            - name: media-download
              mountPath: "/downloads"

What does your registries.yaml look like? You need to tell containerd to use http for <IP_ADDRESS>:32000 in the endpoint list. By default it assumes https.

What does your registries.yaml look like? You need to tell containerd to use http for <IP_ADDRESS>:32000 in the endpoint list. By default it assumes https.

Not sure what you mean by registries.yaml look like ?
As I'm using Nexus docker registry.
So are you say the the image should be ?http://<IP_ADDRESS>:32000/jackett:1

Not sure what you mean by registries.yaml look like ?
As I'm using Nexus docker registry.
So are you say the the image should be ?http://<IP_ADDRESS>:32000/jackett:1

@brandond  sorry I just realized what you mean be registry.yaml see below
mirrors:
  docker.io:
    endpoint:
      - "http://<IP_ADDRESS>:32000"

@brandond  sorry I just realized what you mean be registry.yaml see below
mirrors:
  docker.io:
    endpoint:
      - "http://<IP_ADDRESS>:32000"

@brandond  I have fixed the issue found this issue https://github.com/k3s-io/k3s/issues/1802
Looks like I had my registry.yaml file incorrectly confided
Changed to below
mirrors:
  "<IP_ADDRESS>:5055":
    endpoint:
      - "http://<IP_ADDRESS>:5055"

With correct port and ip and restarted and fixed the issue :)
Thank you for your help

@brandond  I have fixed the issue found this issue https://github.com/k3s-io/k3s/issues/1802
Looks like I had my registry.yaml file incorrectly confided
Changed to below
mirrors:
  "<IP_ADDRESS>:5055":
    endpoint:
      - "http://<IP_ADDRESS>:5055"

With correct port and ip and restarted and fixed the issue :)
Thank you for your help

@brandond I have tried it again and still having the pull image issue for some reason it worked once but now not working

@brandond I have tried it again and still having the pull image issue for some reason it worked once but now not working

That should be registries.yaml not registry. If it works you will see the endpoint templated into containerd's config.toml.

That should be registries.yaml not registry. If it works you will see the endpoint templated into containerd's config.toml.

I re looked over all the file and started again and it is now working.
But to get this to work in future do you only need to Todo the registries.yaml?

I re looked over all the file and started again and it is now working.
But to get this to work in future do you only need to Todo the registries.yaml?


(1CT) Create One Click Trading Session

ClickUp Task
1CT Logic
1CT Profile Link
Brief Changelog

Allow Creating 1CT session
Remove Session from LocalStorage after disconnect
Add 1CT Expiry and Activated toasts
Add 1CT Intro Modal
Display the 'welcome back screen' in the wallet modal after the user has started at least one 1CT session
Display the remaining session time radial progress in the navbar

Testing and Verifying

[ ] Should allow user to create 1CT account
[ ] Should allow to create a 1CT session with different parameters
[ ] Should display a toast when the session expires
[ ] Should display a toast when the session starts

I'm trying to initialized a session, but I get an error here: getAccountPubKeyAndAuthenticators

Previews will not work until we get an HTTPS link for the smart accounts node. I'll make sure to keep you posted once I have it. In the meantime, I would appreciate a code review on this PR


Visualize attention

Thank you for your work.
Can you share the code for visualizing attention?

Thanks for your interest in our work! Unfortunately the visualization code would not be easy to share. Briefly, what we did is: (1) modify the Transformer code to save the attention maps to disk, (2) run the model with this modification for each of several inputs, loading the attention map from disk after running each example. (3) For the attention map for "sleeves" for example we subtracted a "baseline" attention map obtained with many random words in the place of "sleeves".
Sorry I can't be of more help with this, at least on short notice.

Dear author,
Do you give options to run the model basing on each method in this table?

Thank you for your answer.

Yes, you can try these variations using the --attn_2stream_mode parameter with --model set to attention. The default xxx_xmm_xff corresponds to the second line of this table. In general you can pass in a string that will be parsed into a sequence of attention operations here.


Sub Category on Category Page

Issue Reference
#7182

@akathuria289
Not working, getting the exception while trying to shop by category, please find the screenshot Here

@Sanjaybhattwebkul Please check

@akathuria289
Please remove slight space from the categories. Please find the screenshot Here

@Sanjaybhattwebkul check now

@akathuria289
Still need to improve, please fix the below issues.
1. Font size should be increased [ font-size:30px ]
2. Number of categories should be 6 on the screen
3. Scroller should be added
4. Image should not be stretched

@akathuria289
Not fixed, images are getting stretched. and getting the issues in mobile view, please find the screenshot Here

@Sanjaybhattwebkul Check Now

@akathuria289
This is working fine, please find the screenshot Here

@akathuria289
Any update?

Resolve conflicts

@jitendra-webkul Sir Resolved

Merged as this is already approved by @jitendra-webkul sir.


Add segment by asset to volume and transfers views (staging prview)

Problem
With xTokens growing in scale, we want to be able to view activity by asset and confirm accuracy
Proposed Solution
Add filter using the same config we use in the bridge to segment data by token/asset in the transfers table AND volume table
Where there is no mapping yet, show the address ID so we can update it
Acceptance Criteria
From an end user perspective, the below criteria must be met to consider this done:

[ ] On the transfers and volume bar graphs, able to toggle to segment by asset instead of by chain

We've been looking for endpoints to get and show the data in the described views. But unfortunately, we can't seem to find the right endpoint for it.
The endpoint we found is close, but it only gives us the daily USD volume and doesn't include the number of transactions. And even after using filters, the data size is pretty big.
So, please let us know if any other endpoint could work to create the view.

@liu-zhipeng
the endpoint theyre using returns a list of objects like this:
 {"status":"Executed","transfer_date":"2023-09-21","origin_chain":"1869640809","destination_chain":"1634886255","router":"0x49a9e7ec76bc8fdf658d09557305170d9f01d2fa","asset":"0x4200000000000000000000000000000000000006","volume":464724934832380323,"avg_price":1580.9500000000000000,"usd_volume":735.7674408959445194806000,"id":33}

the status / router does not make sense if this is a daily tvl view. any idea on the best way to get daily volume by asset? and why the single-transfer specific columns are here

@liu-zhipeng
the endpoint theyre using returns a list of objects like this:
 {"status":"Executed","transfer_date":"2023-09-21","origin_chain":"1869640809","destination_chain":"1634886255","router":"0x49a9e7ec76bc8fdf658d09557305170d9f01d2fa","asset":"0x4200000000000000000000000000000000000006","volume":464724934832380323,"avg_price":1580.9500000000000000,"usd_volume":735.7674408959445194806000,"id":33}

the status / router does not make sense if this is a daily tvl view. any idea on the best way to get daily volume by asset? and why the single-transfer specific columns are here

Above query is the daily transfer volume table which is grouped by date, origin domain, destination domain, router address, and origin transacting asset.
I think we need to create a new view to get daily volume by asset.


Broken examples

The examples here are broken due to the change of the api in ultradom...
https://codepen.io/zaceno/pen/PEmEbW

You're right @cjh9 , but there's more than just the new render function I'm afraid.
At least I changed the update function to:
function update () {
    render(Main(), document.body)
}

which seems right according to the README. But there's more stuff breaking that's hard to debug in a codepen. I'm going to have to look deeper into it when I'm at home (and everyone's gone to bed 😅 )
@jorgebucaran Has anything else changed in ultradom 3.0, besides how apps are mounted & patched with the same render function? More specifically, how lifecycle events are treated, or how the virtual-dom is shaped?

@zaceno Yes, sorry, I'm still in the middle of making changes to Ultradom. Some of those changes might make it into Hyperapp at some point, but I can't say for sure.
@cjh9 As a rule of thumb, packages inside the github.com/hyperapp org are fundamentally meant to work with Hyperapp, if it works with anything else is pure coincidence! 😉🙇

@cjh9 Thanks for reporting! I've decided I'm not going to maintain Ultradom (now Superfine) compatibility any more. It may still work, or almost work, but it will be up to you to figure it out. If you want to discuss what changes might be necessary to make it work, come by the Hyperapp slack, and post in the #superfine channel


Product Backlog Item #1585382: Revert File SDK code from RMS repo

Need to revert the changes we did in the scripts


Some certifcate links open in a new tab, some in same tab

If I click on a link to a certificate from my settings page, it opens in the same tab. If I click on one from the timeline on my portfolio, it opens in a new tab. We could probably make this consistent. I believe I made the timeline links open in a new tab because there's no nav on the cert pages, so the only way to get back to the site is with the browsers back button. I believe I have also heard an argument that they should open in the same tab so I'm not sure what the better way to go is.

sir.. i would like to solve this issue...can i contribute??

#@asperger99,  please go ahead 👍. No assignment is necessary as described in our contribution guidelines. The first comprehensive PR will be considered for review.

So should it open in a new tab or in the same tab? what should happen?

same question as @NirajNair ....what shold happen?? @ahmadabdolsaheb

I will double check with the dev team and get back to you.

My vote was to open them in a new tab - like I said, there's no nav on the certs so you have to use the browsers back button to get back to the website.

@moT01 I agree

I was told, "If the user donates on the certificate, the redux store will not be updated on the other tab and would need a refresh". So, I think that for now, we should open them in the current tab - unless someone has a better solution to that.

"If the user donates on the certificate, the redux store will not be updated on the other tab and would need a refresh"

Could you clarify this?

If the user donates on the certificate opened on a new tab, the redux store will not be opened on the original (settings) tab?

This does not sound much like a problem. In fact, I would have said that is expected behaviour, from past experience.

So If a user donates on their certificate the store on that tab gets updated (isDonating: true). When the user goes back to the previous tab to work on the challenges, she will see the donation modal. (unless refresh).
Solutions:

keep a navigation on the certs and keep them in the same tab
open certs in new tab but sync state across tabs,

Might find this one helpful. https://medium.com/@daverivera90/sharing-state-between-browser-tabs-with-redux-68899eb88fb7

What is the chosen path to solve this issue? Or am I missing something?

We have not come to an agreement regarding the way to move forward yet.
The options are listed above.
Once we reach an agreement, we should make the experience consistent across the app.


Update linux_syscall_support.h

The #else here defines __syscall6 twice for __aarch64__. The first time is up on line 2563. Instead of a catchall for other 64-bit architectures, they can be handled explicitly.
@alk

This is failing to build with "unsupported 64-bit architecture" on my odroid c2

Merged pull request #833 instead


c3c: fix source hash

Description of changes
In 842a15bf096f (https://github.com/NixOS/nixpkgs/pull/330456), c3c was updated to version 0.6.1, but the source hash wasn't changed, the upshot of which seems to be that users with access to a cache get the old version, and users that don't get sha mismatches.
This commit fixes the hash of the c3c package, to match the currently
packaged version.
@luc65r @0x61nas

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

cc @gador


remnote: 1.13.52 -> 1.14.13

Description of changes
https://feedback.remnote.com/changelog

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

There's a lot of changes in this patch that are not a simple version update.
Especially the removal of one maintainer of the package.
I'd like to have the commit split up into several commits, if you don't mind.

Have split into 3 commits. Hopefully that is better. Many thanks.

Can this be merged? Many thanks.


RN 0.62.2 KeyboardAvoidingView race condition on iOS

Description
Discovered a bug in KeyboardAvoidingView on iOS after upgrading to RN 0.62.2 (can't reproduce on previous version 0.61.2). It happens randomly and rarely, only reproduced on iOS (both simulator and physical phone: iPhone7 iOS 13.3). When using the KeyboardAvoidingView (with behavior="padding") inside which is autoFocused TextInput being aligned to the bottom of the screen, the input is sometimes (very rarely, hard to reproduce) covered by the software keyboard when opening the screen, instead of pushed up in the view.
React Native version:
System:
    OS: macOS 10.15.5
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 20.86 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.17.0 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.4 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK:
      API Levels: 28, 29
      Build Tools: 28.0.3, 29.0.3, 30.0.0
      System Images: android-29 | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 4.0 AI-193.69<IP_ADDRESS>14223
    Xcode: 11.5/11E608c - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_252 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.11.0 => 16.11.0
    react-native: 0.62.2 => 0.62.2

    "react-navigation": "^4.0.10",
    "react-navigation-fluid-transitions": "^0.3.2",
    "react-navigation-hooks": "^1.1.0",
    "react-navigation-stack": "^1.9.4",
    "react-navigation-tabs": "^2.5.6",

Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

Use iOS and open screen using react-navigation v4 library.
Open a new screen with react-navigation-stack
Use KeyboardAvoidingView, behavior="padding"
Add TextInput with autoFocus aligned to the bottom

Expected Results
The TextInput is pushed above the software keyboard on the bottom of the screen.
Code example:
<KeyboardAvoidingView
  behavior="padding"
  style={{
    flex: 1,
    height: '100%',
    width: '100%',
  }}>
  <View style={{ flex: 1 }} /> {/* this is to push the TextInput to bottom*/}
  <TextInput
    style={{
      backgroundColor: 'red',
      width: '100%',
    }}
    keyboardType="numeric"
    autoFocus
    placeholder="test"
  />
</KeyboardAvoidingView>

Screenshots:
I've been digging into the code to see why it breaks occasionally, and it is most likely because the layout callbacks are not properly handled inside the KeyboardAvoidingView component. Sometimes they get called in different order and then the logic breaks. I have altered the RN component code and added some logging to see in which order the internal methods are called:
This is when the callbacks are called in regular order (most of the cases). The TextInput gets pushed up when opening the screen:

This is when the callbacks are called in different (rare case) order. As you can see the LayoutAnimation doesn't happen when _onKeyboardChange is called before _onLayout (which happens rarely on iOS with RN 0.62.2). Then the TextInput component gets covered by the software keyboard:

I'm still facing it. Please reopen it


Should transition hooks be inside the component.vue file instead of its parent?

What problem does this feature solve?
Currently, devs need to define transition hooks in parent components, leading to dirty DOM checks and conditions that could be solved if these hooks were declared inside the child transitioned component.
What does the proposed API look like?
While using the <transition> element I come to realize that the JavaScript transition hooks are scoped in the component's parent object:
parent component
<template>

    <transition v-on:enter="onChildEnter">
       <some-child></some-child>
    </transition>

</template>

The issue with this is that it kinda breaks the single file component model because there are methods decribing the behavior of a component outside of it.
Also, the onEnter method will be generic to all child components that are render inside the <transition> tag.
These two points encourage dirty DOM checks:

if the transition hook would be inside the child component instead of doing el.querySelector('.element--inside--children'), refs could be used.

if you want two different animations for elements inside the transition tag, for example when animating routes entering with <router-view>, you have to do some dirty conditional check inside the transition method.

I could be missing some possible configuration or skipped in the docs. In case I didn't miss anything and there is no escape over this, I would suggest moving the transition hooks inside a transition property in the child component, similar to what nuxt does (https://nuxtjs.org/api/pages-transition#object).
The aprent and child components inside the transition tag would look something like that:
parent component
<template>

    <transition name="fade">
       <some-child></some-child>
    </transition>

</template>

child ccomponent
<template>

</template>

Alternatively we could use the name of the transition to identify the hooks:
 transition: {
  fade: {
    beforeEnter(el, done) {},
    onEnter(el, done) {},
    beforeLeave(el, done) {},
    onLeave(el, done) {},
  },
  otherTransition: {}
}

This would allow developers to different animations in case the element is reused and wrapped in other parts of the app and need a different sequence.
What about common transition hooks like in the current Vue version? Well, that could be easily accomplished if the user creates a generic function, imports it in each component and reference it.
I repeat, if it was possible to define a transition hooks in children components and I missed it, sorry in advance for the noise :)

One final note, my proposal would also need to standarize names for the transition hooks though I don't see it as a huge drawback.

You can actually move out every hook already by creating reusable transitions it's almost what you just did
The other solution is to actually wrap the child component inside of a transition and allow it to pass a transition name through a prop, although I discourage you to use this approach because it's magic 😄
Thanks for the suggestion. Transition hooks being like events, we want to handle them the same way we do with events without introducing a different api


Is it possible to implement upload?

Hi there!
Thank you for your work on this library, I'm going to convert all of the forms in my antd application to redux-forms using this. However, one thing that's bothering me is how to deal with an upload on one of our forms.
I know that uploads are more way more complicated than any other field you have created but do you think it's possible to support them with this project. I don't mind doing the work, I just want to know your thoughts, thanks :)

Never mind, I've handled the file upload separately.

@Remimstr do you mind sharing how you solved this

@sajeezy Not at all :)
The approach that worked for my case is to have separate sections for the upload and form items. I explicitly store the file in redux and let redux-form-antd take care of the form data. This is all within a modal that is responsible for making the api request once all the fields are properly filled out.
Here is the general gist of my code:
import { Button, Card, Modal } from "antd";
import { reduxForm, Field } from "redux-form";
import { TextField, DatePickerField } from "redux-form-antd";

// This is a reference to help us click the textInput box
let textInput = React.createRef();

// When the upload button is clicked, click the actual input tag
const interceptUploadClick = ref => {
  ref.current.click();
};

const ItemUpload = props => {
  const {
    uploadFileName,
    handleFileUpload,
    handleSubmit,
    hideUploadModal
  } = props;

  return (
    <Modal
      okButtonProps={{ disabled: !uploadFileName }}
      onOk={handleSubmit.bind(this)}
      onCancel={hideUploadModal.bind(this)}
    >
      <Button
        onClick={interceptUploadClick.bind(this, textInput)}
      >
        <input
          type="file"
          ref={textInput}
          hidden={true}
          onChange={handleFile(this)}
        />
        <span>{uploadFileName || "Upload"}</span>
      </Button>
      <form layout="inline">
        <Card>
          <*FormItemsGoHere /*>
        </Card>
      </form>
    </Modal>
  );
};

const ItemUploadForm = reduxForm({
  form: "itemUploadForm",
  validate
})(ItemUpload);

export class ItemUploadContainer extends React.Component {
  onSubmit = values => {
    const { uploadedUnitFile } = this.props; // Mapped in from redux
    const { uploadUnitRequest } = this.props.actins;

    if (!uploadedUnitFile) {
      message.error("Please upload a file!");
    }  else {
      uploadUnitRequest({
         file: uploadedUnitFile
         // Other form items from "values"
     })
  }

  render() {
    <ItemUploadForm onSubmit={onSubmit} *etc...* />
  }
}

Hope that helps!


User local workspace settings

To distinguish between multiple open VS Code instances I tend to use different color themes.
E.g. A dark theme for the instance where I work on the master branch and a light theme for my experimental branch.
As both instances have a similar set of open files, it is very easy to edit in the wrong instance by mistake.
As the theme selection is an individual choice I do not want to put it in the version controlled .vscode/settings.json file.
Now I have to constantly stash or revert my changes every time I want to pull from new remote changes.
Suggestion: Add the file .vscode/settings.user.json that overrides any settings in .vscode/settings.json.

/duplicate of #40233


SPM

SPM support.
Changes: Create Package.swift
Screenshots for the change:

Hello @jogendra
Any news?


How to automatically add language support

The HTML code I returned from the compiler like this：

How can I distinguish them？And add them to the corresponding class in  tag  'pre' or 'code'

At the moment there is no auto-detection of the language. This feature has been asked already in issue #1313.
You have to set the right class yourself.


cleanup_push causes crash for debug build with clang

I found a crash only happens with debug build when using the library, found the reason is the implicit array as handler in neco.h
#define neco_cleanup_push(routine, arg) {__neco_c0(&(char[32]){0},routine,arg);
#define neco_cleanup_pop(execute)        __neco_c1(execute);}

Suggest this change to fix the crash:
❯ git diff neco.h
diff --git a/neco.h b/neco.h
index 6b905c5..f9155c5 100644
--- a/neco.h
+++ b/neco.h
@@ -225,7 +225,7 @@ int neco_cancel_dl(int64_t id, int64_t deadline);
 int neco_setcanceltype(int type, int *oldtype);
 int neco_setcancelstate(int state, int *oldstate);

-#define neco_cleanup_push(routine, arg) {__neco_c0(&(char[32]){0},routine,arg);
+#define neco_cleanup_push(routine, arg) {char _handler[32] = {0}; __neco_c0(&_handler,routine,arg);
 #define neco_cleanup_pop(execute)        __neco_c1(execute);}

 /// @}

Program received signal SIGILL, Illegal instruction.
0x0000000001014acc in cleanup_push (handler=0x7ffff60c7a08, routine=0x10412b0 <cleanup_free_host>, arg=0x1056580) at /home/binarycraft/projects/neco/src/neco.c:7683
warning: Source file is more recent than executable.
7683        handler->routine = routine;
(gdb) bt
#0  0x0000000001014acc in cleanup_push (handler=0x7ffff60c7a08, routine=0x10412b0 <cleanup_free_host>, arg=0x1056580) at /home/binarycraft/projects/neco/src/neco.c:7683
#1  0x0000000001014a75 in __neco_c0 (cl=0x7ffff60c7a08, routine=0x10412b0 <cleanup_free_host>, arg=0x1056580) at /home/binarycraft/projects/neco/src/neco.c:7701
#2  0x0000000001040b17 in getaddrinfo_from_tcp_addr_dl (addr=0x1001c4c "localhost:19203", tcp_vers=0, res=0x7ffff60c7b00, deadline=9223372036854775807) at /home/binarycraft/projects/neco/src/neco.c:6792
#3  0x0000000001041357 in listen_tcp_dl (addr=0x1001c4c "localhost:19203", tcp_vers=0, deadline=9223372036854775807) at /home/binarycraft/projects/neco/src/neco.c:6973
#4  0x00000000010121c4 in serve_dl (network=0x1001f1c "tcp", address=0x1001c4c "localhost:19203", deadline=9223372036854775807) at /home/binarycraft/projects/neco/src/neco.c:7029
#5  0x0000000001012045 in neco_serve_dl (network=0x1001f1c "tcp", address=0x1001c4c "localhost:19203", deadline=9223372036854775807) at /home/binarycraft/projects/neco/src/neco.c:7043
#6  0x0000000001012327 in neco_serve (network=0x1001f1c "tcp", address=0x1001c4c "localhost:19203") at /home/binarycraft/projects/neco/src/neco.c:7072
#7  0x00000000010086e2 in __neco_main (argc=1, argv=0x7fffffffdd68) at /home/binarycraft/projects/neco/examples/echo-server.c:21
#8  0x00000000010086af in _neco_main (argc=2, argv=0x1056430) at /home/binarycraft/projects/neco/examples/echo-server.c:20
#9  0x000000000102f172 in coentry (udata=0x10563e0) at /home/binarycraft/projects/neco/src/neco.c:3827
#10 0x0000000001033437 in sco_entry (udata=0x10563e0) at /home/binarycraft/projects/neco/src/neco.c:2019
#11 0x0000000001028b19 in llco_entry_wrap (arg=0x0) at /home/binarycraft/projects/neco/src/neco.c:1189
#12 0x0000000001028895 in llco_entry (arg=0x0) at /home/binarycraft/projects/neco/src/neco.c:1195
#13 0xdeaddeaddeaddead in ?? ()
#14 0x0000000000000000 in ?? ()

I would like to reproduce.  Could you provide more information about your system?
I suspect it's an alignment issue and ideally it could be fixed without introducing new thread globals.

I would like to reproduce. Could you provide more information about your system? I suspect it's an alignment issue and ideally it could be fixed without introducing new thread globals.

Sure, I am using zig build system, the system is x86_64 archlinux, here is the command to build and reproduce the crash:
zig build-exe -lc -I./ -DLLCO_NOUNWIND neco.c examples/echo-server.c
❯ ./neco

=== Crash on main thread ===

------ STACK TRACE ------

Illegal instruction

ideally it could be fixed without introducing new thread globals.

The above change is not thread global though, just explicitly defined the handler.

Thanks! I was able to reproduce. Your suggestion worked and I just pushed the fix.

Thanks! I was able to reproduce. Your suggestion worked and I just pushed the fix.

Come to think of it, maybe the expression &(char[32]){0} confused the compiler and it didn't initialize the array correctly, with the explicitly defined array, we can be sure it's initialized.

Yeah. I'm not exactly sure what happened.
The zig cc compiler is something I don't have a lot of experience with personally but it's nice to know that it now works.