Analog LED Strip Driver

Hello!
I have an analog LED strip with 4 terminals (12V, G, R, B). I know none of the fancy animations will work, but I want to be able to control it through my Raspberry Pi's GPIO pins with Biblio pixel, setting simple colors and fades. Is this possible? I didn't see Analog support anywhere in the drivers but I may be missng something.
Thanks!

Ah OK that makes sense. It's a shame your LongPixel didn't make it, that would've been useful. Otherwise, great job on the project!

Totally agree! Would've loved for the LongPixel to have found more of an
audience.
If you need any help with your project, even though it's not strictly
related, feel free to hit us up on our Google Group:
https://groups.google.com/forum/#!forum/maniacal-labs-users
On Wed, Apr 25, 2018 at 5:57 PM, HeroCC<EMAIL_ADDRESS>wrote:

Ah OK that makes sense. It's a shame your LongPixel didn't make it, that
would've been useful. Otherwise, great job on the project!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/776#issuecomment-384447252,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6svK4UTzCixHap2AV5f-CY6sa2bLks5tsPE9gaJpZM4TkKdm
.


create binary distributions

since histdatacom is a cli app, it might be nice to provide more common means of installation.

References:
How to extend distutils with a simple post install script?
How to perform custom build steps in setup.py?
How To Add Custom Build Steps and Commands To setup.py
Python Git Packaging
Python Packaging Guide for APT/Debian
How do I do Debian packaging of a Python package?
How Software Producers Can Distribute Their Products Directly in DEB Format
How To Package For Debian
How can i publish my software to public linux repos to be available with "apt" installers etc
Launchpad Source package recipes
Launchpad Packaging/PPA
launchpad.net/
How to get my software into Ubuntu?


Fix Python version in dockerfile to avoid TypeError

fix error:
TypeError: ForwardRef._evaluate() missing 1 required keyword-only argument: 'recursive_guard'

Is it solved?

Thank you for fixing this @moas


PhantomJS / GhostDriver is not clearing state between runs

On the first run on CatapultResourceIT, the test attempts to issue a fling operation which ends in forwarding the user to the project overview page.  As the user is not logged into OpenShift, the console asks for authorization first.  The test logs the user in.
On subsequent runs, the user is brought directly to the project overview page with no need to log in.  State is not getting cleared somewhere.
Breaking this issue off of work done in #55 to allow that work to make it upstream, and testing simply that the user ends up somewhere on the OpenShift console for the time-being.

Check to see if I've fixed this in: 088705bc451645e602eaf3d9bda69145bc7f3528
Noticed that I was never closing the WebDriver and that phantom (pun intended) processes were laying around forever.  If they clear state by nature of exiting, maybe that's why state was never cleared.

Yep, that fix did it.  I've corrected the tests to match and now always log in the user to OpenShift because with state being cleared, the test always arrives as a new user (the expected behaviour)
adb56b26da14ef897c0c3e3a2e790b1a8c73a9f9


Q: Possibility to add class to images?

Whenever I attach an image and save it, I want it to have a default class of img img-responsive so that when images are rendered, they would have that class.
Is that possible right now?
If not, are there any workarounds aside from using javascript/jQuery?

You could try the plugin Summernote-Classes, which will one configured the classes you want to use the editor on different elements, allow you to add whatever classes you like to elements.
https://github.com/DiemenDesign/summernote-classes
I made it so the classes need to be added so it's not rigid to a set of classes, seeing as people could use custom, or different frameworks that will have different class names that do similar and or different things.

@DiemenDesign Thanks! Though this one seems to be an overkill for what I wanted to achieve as I only want to automatically add img img-responsive to images. I don't want users to manually set the class to be used for images

no worries, your welcome to take the idea and run with it.

Actually, if your overriding the insertion so images are uploaded to the server rather than using the Base 64 encoding when they are inserted, you could add an extra bit of script that also adds the classes you want to the element.

@DiemenDesign yeah. That's kindas what I want. Do you have any ideas on how?

Look up elFinder, they have a small bit of javascript for using their media browser with Summernote, it opens a modal with the media browser, then returns the url of the image and inserts it into Summernote, you could see how they are doing it, and attach the classes to the image as you would have the object and could do something like $(imageelement).addClass('img-reposonsive'); with imageelement being the reference to the image element that was inserted.

I have found a way but it's somewhat hacky. The idea is to use the summernote.change event to update the editor, if necessary. However, summernote.change is fired on every keystroke, so that would lead to excessive parsing if used standalone. To avoid that, I process the content only after bs.modal.hidden is fired.
Put the following code into a static file, for example summernote/custom.js, and have it added through settings.py:
# settings.py
SUMMERNOTE_CONFIG = {
    'js': (
        '/static/summernote/custom.js',
    )
}

Here's the code for Bootstrap 4. It adds the necessary classes to every  and also wraps videos in
. Note that this works only in iframe mode because it uses global $('#summernote').

$(document).on('hidden.bs.modal', function() {
    // remember that a dialog has been closed recently, so we must inspect the next change event
    $('#summernote').data('dialogClosed', true);
});

$(document).on('summernote.change', function(evt, content, editor) {
    const $summernote = $('#summernote');
    // has the dialog been closed recently ?
    if ($summernote.data('dialogClosed')=== true) {

        // let the browser parse the content (html string)
        const $el = $('
');
        $el.html(content);

        // add  img-thumbnail class to each image
        $el.find('img').addClass('mx-auto d-block img-thumbnail');

        // wrap videos into .embed-responsive instead of

        $el.find('iframe.note-video-clip').each(function () {
            const $video = $(this),
                $parent = $video.parent();

            if ($parent[0].tagName === 'P') {
                $parent.replaceWith($video);
                $video.addClass('embed-responsive-item');
                $video.wrap('
');
            }
        });

        // retrieve the updated content as HTML string
        const newContent = $el.html();
        if (newContent !== content) {
            // update editor content with our changes
            $summernote.summernote('code', newContent);
        }
        // delete dialogClosed flag
        $summernote.data('dialogClosed', false);
    }
});


版本兼容问题

Verify it's not a duplicate bug report

[X] I searched for similar bugs reported on GitHub and nobody has reported a similar issue. Search all issuees.

Verify troubleshooting guide is missing steps to solve this issue

[X] I read Troubleshooting guide on Readme and there is not a guide on how to solve my problem.

Describe the Bug

Please tell us if you have customized any of the extension settings or whether you are using the defaults.
否
Additional context
No response

My editor is not updated ？

@YongkeShou the minimum vscode version to use the extension is 1.73.0

Thanks, I have updated my editor version


mac: Update macOS SDK version

Change default macOS SDK version to 10.12 according to current macOS
supported version.
Signed-off-by: Wenchao Wang<EMAIL_ADDRESS>

We'll need update CI script.


[FEATURE] sidebar menu bottom left fixed settings bar

Is your request related to a problem? Please describe.
Hello, It's possible to create buttons links from the BuildingMenu that are fixed to the bottom of the sidebar and just be icon links (not full sidebar width) ?
Like this:

Thanks !
Describe the solution you'd like
A clear and concise description of what you want to happen or the enhancement you want.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hello @guga121 there's no built-in support for that. But you are able to publish the package views and edit they to include whatever you want on the left-side menu. Take the issue #926 as a reference...

Thank you Diego for your quick response. Very helpfull as always!!
Regards


ISPN-13978 Align dependencies between projects

Dependencies

jboss-parent 39
jboss-logging 3.4.3.Final
jboss-logging-processor 2.2.1.Final
junit 4.13.2
mockito 4.3.1

https://issues.redhat.com/browse/ISPN-13978
While looking at downstream reports, found some divergences between versions of Infinispan and protostream, infinispan-quarkus and wildfly. I've updated some of them. :crossed_fingers:

Merged, thanks


Fix some grammar

First "its" is definitely possessive and second one should go due to the first one already expressing possessiveness.

Thanks!


Crash when a file is being retrieved from tape

I have encountered a problem with the file restore functionality in the C API. More precisely with the ds3_get_object() call. I am trying to restore a file with job_id set to NULL.
But if a file is stored on a tape and thus unavailable from the cache - the library does not handle the 307 HTTP code correctly (as described in DS3 API Reference - page 65).
I think the following happens:

Get ds3 object command is sent.
The file is not available so 307 is returned
Curl library retries several times before giving up
the DS3 lib tries to parse the headers information, but no headers are available (see header_buff value)
NULL pointer access crash

Crash stack

msvcr90!strlen+0x31 [f:\dd\vctools\crt_bld\SELF_64_amd64\crt\src\amd64\strlen.asm @ 70]
ds3!ds3_str_init+0x3c [e:\projects\ds3\tiger_ds3\src\ds3.c @ 79]
ds3!_process_header_line+0x266 [e:\projects\ds3\tiger_ds3\src\ds3.c @ 211]
ds3!Curl_client_write+0x184
ds3!Curl_http_readwrite_headers+0xbcb
ds3!Curl_meets_timecondition+0x1eb
ds3!Curl_readwrite+0xcb
ds3!curl_multi_remove_handle+0xcd8
ds3!curl_multi_perform+0x8e
ds3!curl_easy_setopt+0xdd
ds3!curl_easy_setopt+0x22e
ds3!_net_process_request+0x50c [e:\projects\ds3\tiger_ds3\src\ds3.c @ 495]
ds3!_internal_request_dispatcher+0x71 [e:\projects\ds3\tiger_ds3\src\ds3.c @ 842]
ds3!ds3_get_object+0x43 [e:\projects\ds3\tiger_ds3\src\ds3.c @ 1210]

Values

header_buff = 0x00000000`03b1acb0 "HTTP/1.1 307 Temporary Redirect"

Offending code src\ds3.c @ 211

split_result = g_strsplit(header_buff, ": ", 2);
header = g_new0(ds3_response_header, 1);
header->key = ds3_str_init(split_result[0]);
header->value = ds3_str_init(split_result[1]); <======== 2nd elements is NULL because header_buff does not contain : char
g_hash_table_insert(headers, header->key->value, header);
g_strfreev(split_result);

DS3 version used: from 1.1 version tag

We no not recommend that you use ds3_get_object without a job.  You'll get better performance overall if you do that and will avoid 307 redirects.  That being said, I'll try to reproduce this and introduce a fix.

I've reproduced the error.  The fix will be in the next release of the sdk which will be sometime next week.

A fix was just checked in.  It will be available in the next release.

Thanks


Update README.md

test

While I do agree with the contents of this PR, I only created it to help @jessicard test her notifications, so now I'm closing it.

thank u my dear @jakeboxer


config: cancel freeze release-4.0 for tidb/tikv

Cancel freeze release-4.0 for pingcap/tidb and tikv/tikv. The cherry-pick-approved label is no longer required for the release-4.0 branch.

/lgtm

/status LGT1

/merge


Error: Could not find the RNLocation native module

Hi,
I installed the latest version of this module.
But when I build and launch on a simulator, I get a big red error saying:
"Native module cannot be null"
In my debugger it says: Could not find the RNLocation native module
I have used the Cocoapods installation method, so I don't see what I might have missed.
Please let me know how I could fix this issue,
Thank you!

+1
Exact same issue! Any solutions?
I can provide more details if needed.

1

I am having the same issues when trying to import react-native-location from inside my jest test. I also get a console.warn that says -
Could not find the RNLocation native module. Have you correctly linked react-native-location and rebuilt your app?

but I followed the necessary steps to link for ios and android...

So, I was able to get my jest tests to run again. It turns out I need to mock out react-native-location in my setup.js file like so,
jest.mock('react-native-location', () => ({
  __esModule: true,
  default: {
    requestPermission: jest.fn(() => Promise.resolve(true)),
    getLatestLocation: jest.fn(() => Promise.resolve()),
  },
}));

I hope this helps.

I have a patch here that fixes it. Would love it if the maintainer pulled it.


got error form

Source :  Exceptionless.Core.Repositories.StackRepository
Job : StackEventCountJob
Message : Type: version_conflict_engine_exception Reason: "[stacks][5d19da601ed2af0001819c6c]: version conflict, current version [696] is different than the one provided [695]"

Do you have more information on this? It looks like the document got out of sync? Do you know if this is now resolved?

this error do not happen again .


Support deeper zooming

When browsing TMSes, the max zoom is currently capped at z18. When imagery is ~5cm, z22 is reasonable: http://tiles.openaerialmap.org/588d32222be03d001038e386/0/ca7d8e23-2994-41ce-8466-c32ba20e1248/preview#22/47.59043/-122.22537

I'm behind this and I don't think there is any reason to restrict at this point, right? In the past, the previous TMSs that were generated from the Tiler were at lower zoom levels.

Right, those maxed out at z18

I've done a bit of research on this and from what I can see, the public tiling servers that we use, namely mapbox and OSM, only have guaranteed global coverage for zoom level 18. There are occasionally tiles for z19 but very rarely more. This is just to explain the reason for hard limit at z18.
Of course OAM's tiles can go deeper, so I think the question now become how do give a sensible user experience for both maximum zoom levels? Currently if you override the zoom level, leaflet lets you zoom but just doesn't even attempt to make any HTTP requests for tiles at levels higher than z18. This means we can zoom in OAM tiles but the background map just goes blank, it completely disappears.
One idea could be to artificially zoom the global map imagery so it goes blurry. That's ugly but at least some kind of solution. Though I'm not exactly sure if it's even possible.
Another solution would be to have some rather complicated code that kept careful watch over what was currently in the browser viewport and automatically adjusted both the zoom level (zooming out if there's no OAM tiles) and the controls (re-enabling the "+" zoom in button when a OAM tile is in view).
Or of course we can just enable z22 across the globe, which means you might get a bit lost in the blankness for a while.

@tombh Great summary of where we are at, thanks. Couple ideas:

Implement z22 across the board, but limit panning and zooming to the bounding box of the image you have selected. Maybe that's overkill but it would limit the risk of getting lost when you have an image selected and at higher zoom levels.

Look to build out the TMS preview page more and send users there for now to browse higher zoom levels. Example: http://tiles.openaerialmap.org/58ebc54fcfbcc90010aca44d/0/c44a3159-4c49-4278-874a-49845a1e8352/preview#18/49.56948/18.89199. Or do we look to change how the TMS functionality is interacted with on map.openaerialmap.org?

On the Leaflet end of things, you can override the zoom per-layer (rather than for the map as a whole). I think that ends up overzooming layers that don't have better imagery available. Mapbox and OAM both have TileJSON endpoints (e.g. http://tiles.openaerialmap.org/58ebc54fcfbcc90010aca44d/0/c44a3159-4c49-4278-874a-49845a1e8352) that surface which zooms are available from them.

@mojodna That's great that you can override the zoom for individual layers, that'll definitely come in useful. If I understand right, the mapbox JS actually uses the zoom levels from the TileJSON to decide the maximum zoom level of the map, something like: the map's maximum zoom is the minimum of the user-specified max zoom and the layer's max zoom. Curiously production.js in this repo sets the max zoom to undefined, which I assume is a reference to mapbox's ability to use the zoom levels from individual layers' TileJSON manifest?
@smit1678 Interesting suggestions Nate. About sending the users out to the preview page, that made me think, well what's the difference between the preview page and the browser anyway? I think it's merely the fact that it's a separate UI - which then justifies the precedent for enforcing different zoom and pan levels. I imagine the user thinks something like, "ok I'm somewhere else, so that's understandable that the controls do something else."
That got me thinking, well what could we do to make the preview UI perfect. Well first thing would be to create a hard restriction on panning and the minimum zoom level - both panning and zooming out too far get you lost. As I said, merely the change in UI circumvents the cognitive dissonance of, "eh?? why's it behaving differently now??" So, what I'm wondering is, can we not do exactly this all inside the browser UI? The proviso being that we clearly trigger a small UI change to accompany the change of rules. For instance, assuming you've arrived at some imagery through the modal dialog so that you have the individual summary open on the right - what if you then slightly coloured various elements of the UI in a consistent and coherent way;

give the imagery modal dialog background and/or borders a suitably subtle but noticeable shade of blue (indicates the "something's different now" mindset).
the zoom controls receive the exact same colour to borders/background and receive new max/min levels and also change the point at which they grey out becoming disabled.
the entire window gets a slight blue border indicating that panning has new restrictions, namely you can't pan such that for example, the imagery's western extremity can leave the left hand side of the screen.

One problem with that is how you would enter this new UI state without going through the imagery modal? Maybe it could be triggered when you are both at zoom 18 and a portion of imagery intersects with the viewport?

Oh wow, I only just realised, imagery only appears when the preview modal is open! This means it's trivial to adjust zoom and probably panning as well, when a single piece of imagery is selected.
Ok so that change things a bit. It would be a relatively straight forward fix here, without having to do any fancy UI state hinting. What I propose is simply that zoom is increased to 22 only when a single piece of imagery is selected.
One question though, what should the behaviour be when the user is zoomed in beyond 18 and they close they deselect the current imagery? To zoom back out to 18, centred on the same coords? I think that's ok, a tiny bit sudden and jarring, but ok.

One question though, what should the behaviour be when the user is zoomed in beyond 18 and they deselect the current imagery? To zoom back out to 18, centred on the same coords? I think that's ok, a tiny bit sudden and jarring, but ok.

@tombh Let's try that out and see how it feels. I think that might be ok but curious of how the performance is, but the might be handled ok with how we use the loading icon.

Reopening to track a fix to use https for tile endpoints by default. The fix is currently on the develop branch and ready for testing.

@tombh Did this change during the refactor? It looks like this isn't working now on the new work. Or can you point to where someone should be looking to debug this? We're using a new database on staging so it's not the TMS prefix path issue.

This is the core function: https://github.com/hotosm/oam-browser/blob/oauth-login/src/components/map.js#L523
There is also a disabled test (waiting on running the dynamic tiler locally) for this exact feature: https://github.com/hotosm/oam-browser/blob/oauth-login/test/integration/general_test.js#L227


Updated module version to 2.1.0

[DO NOT MERGE before #227]
Updated module version:

Bumped version in manifest
Bumped version in README shield
Added new version to version comparison docs
Updated downloadDependencies.ps1 to download BicepNet 1.0.6

Please add new commands to readme


Bug: Integrated Dynamics Trees

Integrated Dynamics Trees are not affected by this mod, would you be able to support it? Thank you
Edit:
I added "tile.blocks.integrateddynamics.menril_log" to the config with no effect

Hello,
weird thing, it works well for me. There are 2 types of log in Integrated Dynamics:
tile.blocks.integrateddynamics.menril_log
tile.blocks.integrateddynamics.menril_log_filled
Try it with my config:
treechopper.zip

still not working. using iron or obsidian axe from Obsidian tools and armor mod. the break time is slower but the whole tree does not break like with other trees

Ok I see the problem now :D I have sent you names for MC 1.11.2. They have changed a log names.
For MC 1.10.2:
tile.blocks.integrateddynamics.menrilLog
tile.blocks.integrateddynamics.menrilLogFilled
For MC 1.11.2
tile.blocks.integrateddynamics.menril_log
tile.blocks.integrateddynamics.menril_log_filled

But next time please use in-game command "/tch printname 1", that's 100% certainty.

I have, and it prints out "tile.blocks.integrateddynamics.menrilLog" and "item.obsidian_axe" for the axe. But even when putting in the configs, it's a no go. But I am running 1.11.2, with forge <IP_ADDRESS>2. Not sure if that is causing a conflict.

here is exact config:
# Configuration file

data {
    # Put new axe between < and >
    S:"Axe Types" <
        item.hatchetWood
        item.hatchetStone
        item.hatchetIron
        item.hatchetGold
        item.hatchetDiamond
        item.mud_axe
        item.psi:psimetalAxe
        item.tconstruct.lumberaxe
        item.tconstruct.mattock
        item.tconstruct.hatchet
        item.brain_stone_axe
        item.stable_pulsating_brain_stone_axe
        item.adobe_axe
        item.ObsidianAxe
        item.LazuliAxe
        item.OsmiumAxe
        item.BronzeAxe
        item.GlowstoneAxe
        item.SteelAxe
        item.LapisLazuliAxe
        item.peridotAxe
        item.rubyAxe
        item.sapphireAxe
        item.bronzeAxe
        item.mud_axe
        ic2.chainsaw
		item.obsidian_axe
     >

    # Put new log between < and >
    S:"Log Types" <
        tile.log
        tile.log_0
        tile.log_1
        tile.log_2
        tile.log_3
        tile.log_4
        tile.pamCinnamon
        tile.pamPaperbark
        tile.pamMaple
        tile.for.pile_wood
        tile.for.logs.vanilla.fireproof.1
        tile.for.logs.vanilla.fireproof.0
        tile.for.logs.fireproof.7
        tile.for.logs.fireproof.6
        tile.for.logs.fireproof.5
        tile.for.logs.fireproof.4
        tile.for.logs.fireproof.3
        tile.for.logs.fireproof.2
        tile.for.logs.fireproof.1
        tile.for.logs.fireproof.0
        tile.for.logs.7
        tile.for.logs.6
        tile.for.logs.5
        tile.for.logs.4
        tile.for.logs.3
        tile.for.logs.2
        tile.for.logs.1
        tile.for.logs.0
        ic2.rubber_wood
        tile.terraqueous.trunk
        tile.techreborn.rubberlog
		tile.blocks.integrateddynamics.menril_log
		tile.blocks.integrateddynamics.menril_log_filled
     >
}

settings {
    I:"Break speed [DEFAULT: 10]"=10
    B:"Decay leaves"=true
    B:"Ignore axe durability"=false
    B:"Look for roots"=false
    B:"Plant sapling automatically"=false
    B:"Plant sapling on tree position"=false
    B:"Reverse function"=false
}

Which MC version are u using?

1.11.2

Ok and this "item.obsidian_axe" last axe in your config is from this mod?
https://mods.curse.com/mc-mods/minecraft/228314-emerald-obsidian-mod

http://infinitycommunicationsgateway.net/Pub/Minecraft/Shots/#files%2FTree Chopper

And no, this is the mod I am using:
https://minecraft.curseforge.com/projects/obsidian-armor-and-tools

Ok, I just tested this combination of mods and everything is working fine :D
I am using MC 1.11.2
My mods:
CommonCapabilities-1.11.2-1.3.1
CyclopsCore-1.11.2-0.9.2
IntegratedDynamics-1.11.2-0.6.8
ObsidianToolsArmor_V1.6.2
TreeChopper-1.11.2-1.1.2
Attaching my config..
treechopper.zip

Does it help, or not?

ok ill tray again

Capture.mp4

Ok I see. Btw are u playing on a server, or just singleplayer?

Server, and the mod exists on both, and the same config is on both

Could you please try it on singleplayer, so I can know it doesn't work on multiplayer :)

yep, single player working

Thanks a lot for help, this will help :)


unable to import GoogleSignin: RNGoogleSignin.BUTTON_SIZE_ICON

I created a project with create-react-native-app Sample
and installed your library as
npm install react-native-google-signin --save
react-native link react-native-google-signin
But when I import:
import { GoogleSignin, GoogleSigninButton } from 'react-native-google-signin;
I get error:
Undefined is not an object( evaluating RNGoogleSignin.BUTTON_SIZE_ICON')
Steps to Reproduce

You must provide a way to reproduce the problem. We're a small team of maintainers and do not have time to try reproduce bugs ourselves.

See link below. It's a bare bones react project that recreates the problem.

Link to a GitHub repository with code that reproduces the bug.

https://github.com/lingxiao/Sample

Explain how to run the example app and any steps that we need to take to reproduce the issue from the example app.

Expected Behavior

I should be able to import GoogleSignin without an issue.
Actual Behavior

Crashed with:
[RNGoogleSignin.BUTTON_SIZE_ICON error] (https://i.imgur.com/i1TZuDU.png)
Environment
Please provide the version of your

react-native                             0.55.4
react-native-google-signin    The one I get from npm install
react
cocoapods and GoogleSignIn pod version (if applicable)          N/A
gradle, android plugin for gradle and play-services-auth version (if applicable)   N/A

hi, create-react-native-app uses expo, and expo does not support custom native modules. the good news is that expo has a google sign in functionality available: https://docs.expo.io/versions/latest/sdk/google

@vonovak I am also encountering this issue, but I'm not using expo.
Any ideas?


[prim_alert_receiver] Only check for ping requests after initialization

Fix #9588
Signed-off-by: Michael Schaffner<EMAIL_ADDRESS>

Hi Michael,
Thanks for the fix. But send_init goes low after InitReq state is done, so ping still is pending high and might cause a timeout. I think the issue is when ping_req is sent when alert in InitAckWait state :)

I think this would fix the timeout issue : https://github.com/msfschaffner/opentitan/pull/17


Fulma Input.Text fails during SSR

When I try to render a Input.text element on the server, I get the following error:
System.MissingMethodException: Method not found: 'HTMLAttr HTMLAttr.NewDefaultValue(System.String)'.
   at Fulma.Input.input@161.GenerateNext(IEnumerable`1& next)
   at Microsoft.FSharp.Core.CompilerServices.GeneratedSequenceBase`1.MoveNextImpl()
   at Microsoft.FSharp.Collections.SeqModule.ToList[T](IEnumerable`1 source)
   at Fulma.Input.input(FSharpList`1 options)
    -- Rest of the code omitted

This has been a bit confusing to me because (as far as I can tell) that bit of code in the repo never tries to call a NewDefaultValue method at all.
Any idea what this might be?

let toValue (c: Fable.Import.React.FormEvent) = c.Value

let withLabel label body =
    Field.div []
        [ Label.label [] [str label]
          body ]

let labledText label value change =
    withLabel label
        (Input.text
            [ Input.OnChange (change << toValue)
              Input.Value value
              Input.Props
                [Props.Required true]])

Here's the minimal example.

@AnthonySuper I cannot find HTMLAttr.NewDefaultValue in any repo, can you create a minimal reproducible repo?

Here is a minimal example repository. The README explains how to use it.
From the fact that the bug only occurs under certain routing conditions, I think this situation may be more complicated than the stack trace is letting on, unfortunately... Still, hopefully this repository can provide insight.

@AnthonySuper Thanks for your repo.
The ilspycmd shows that dotnet compiles HTMLAttr.DefaultValue to HTMLAttr.NewDefaultValue, I'm afraid this is related to dotnet core version mismatch problem, I tried change TargetFramework in Server.fsproj to netcoreapp2.0 as the same as Fulma and Fable.React, but have no luck. Perhaps you can try with a lower version of dotnet cli, like 2.0. Or send an issue to projects like visualfsharp/dotnetcore, perhaps people there who are more familiar with dotnet core can give some more useful advice.
case 4:
    if (opts.Id_0040 != null)
    {
        pc = 5;
        current = HTMLAttr.NewId(opts.Id_0040.get_Value());
        return 1;
    }
    goto case 5;
case 5:
    if (opts.Value_0040 != null)
    {
        pc = 6;
        current = HTMLAttr.NewValue(opts.Value_0040.get_Value());
        return 1;
    }
    goto case 6;
case 6:
    if (opts.DefaultValue_0040 != null)
    {
        pc = 7;
        current = HTMLAttr.NewDefaultValue(opts.DefaultValue_0040.get_Value());
        return 1;
    }
    goto case 7;

Input.cs.zip

I will close this issue as there isn't much we can do from this repo.
Feel free to re-open if needed.


Added kubectx and kubens utilities

Hi Massimo,
I find both kubectx and kubens helpful cli tools.
Added the new go versions within this commit.
Thanks,
Tom

Thanks @tomellis !


Using data-a11y-dialog-show with web components

Hi!
I’ve just upgraded to v8.1.0 in our web component based design system and it’s fixed a problem we were having with shadow DOM and focus trapping, so thanks 😄
However, we now have an issue when trying to use data-a11y-dialog-show on a button custom element to trigger showing the modal (which is also a custom element). It looks like the change from event.target to event.composedPath()[0] here means that we're now getting back the slot the button is in, rather than the button itself, so .show() isn’t being called.
I noticed there was a previous commit that accounted for a slot being returned and fell back to using event.target - I think reverting to that would fix the issue?

Good morning Ella, and thank you for opening an issue! ✨
I was thinking about it on my way home last night, and I think the problem is that Element.prototype.closest does not cross shadow boundaries. So if our click target ends up being resolved as a <slot> (as you rightfully pointed out), then using .closest(..) to find the data-a11y-dialog-show ancestor doesn’t work because it stops at the shadow root.
If I am right about this, then there are two ways to address it:

Find the shadow root first (by using event.target if event.composedPath()[0] yields a <slot> as we’ve suggested in the former commit), so that .closest(..) operates exclusively in the light DOM.
Use a version of Element.prototype.closest that crosses shadow boundaries, so that it doesn’t just stop when reaching the first shadow root.

I think the 2nd version is better because it would work with however many nested web components, which is probably what we want (think a button inside of a card inside of a dialog or something).
I need to spend a bit of time coming up with a reproducible test case first so that I can try fixing it. :)

Addressed in #713. Do you want to venture a review, @ella-etch? :)

Hey @KittyGiraudel, thanks for doing this so quickly!
I've had a look through the code and also tested it out on our project - it all looks great, so I've left an approving review 💯

Solved in 8.1.1. Thanks!


Render widgets only when they are in the viewport

Description
Render widgets only when they come into view.

feels snappier when opening location details page
user can see widget (chart) animations when they come into view

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


APP-473: Added Telemetry Monitor as Custom Log Appender for Data Collection Demo

Added Telemetry Monitor
Changed maven structure for Data collection demo to allow telemetry monitor to be a module for Data Collection
Added executions to maven build to generate all needed libs for Sandbox to make Telemetry Monotor working
Extended DemoBuilder to execute defined commands in SandboxBuilder

@kaa-leeroy test this fully please

@kaa-leeroy test this fully please

@kaa-leeroy test this fully please

@kaa-leeroy test this fully please

@kaa-leeroy test this fully please

@kaa-leeroy test this fully please


Immutable error: "No implementation of function Function() found for signature"

Reporting a bug

[ ] I have tried using the latest released version of Numba (most recent is
visible in the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
[ ] I have included a self contained code sample to reproduce the problem.
i.e. it's possible to run as 'python bug.py'.

Hi,
I have a 2d-array filled with IDs of some entities, for now I am going to replace each value with a vector, so I create a 3d-array with np.zeros() and decorate the code with @njit as a means to accelerate it.
import numpy as np
from numba import njit

tre_n_arr = np.empty([len(tre_n_split), max(tre_n_split, key=lambda x: len(x)), hidden_dim])
tre_n_arr.fill(0)

@njit
def emb():
    for line in range(len(tre_n_split)):
        for path in range(len(tre_n_split[line])):
            emb_vals = emb_n[tre_n_split[line][path]]
            for emb_val_idx in range(len(emb_vals)):
                emb_val = emb_vals[emb_val_idx]
                tre_n_arr[line][path][emb_val_idx] = emb_val

    return tre_n_arr

However, an error occurred:
numba.core.errors.TypingError: Failed in nopython mode pipeline (step: nopython frontend)
No implementation of function Function(<built-in function setitem>) found for signature:

 >>> setitem(readonly array(float64, 1d, C), int64, float64)

There are 16 candidate implementations:
  - Of which 14 did not match due to:
  Overload of function 'setitem': File: <numerous>: Line N/A.
    With argument(s): '(readonly array(float64, 1d, C), int64, float64)':
   No match.
  - Of which 2 did not match due to:
  Overload in function 'SetItemBuffer.generic': File: numba\core\typing\arraydecl.py: Line 171.
    With argument(s): '(readonly array(float64, 1d, C), int64, float64)':
   Rejected as the implementation raised a specific error:
     TypeError: Cannot modify value of type readonly array(float64, 1d, C)

Obviously, [line], [path], [emb_val_idx]   are  <int> indices, while emb_val is a  <float>  value. Of these,
>>> setitem(readonly array(float64, 1d, C), int64, float64)

I'm quite confused about what thesearray(float64, 1d, C), int64, float64  are referring to，and would like to know how could I fix the error. Thanks in advance.

The line:
>>> setitem(readonly array(float64, 1d, C), int64, float64)

describes the arguments to __setitem__ in order. This is equivalent to writing:
a[i] = v

where:

a is a read-only 1D array of float64 values that is C-contiguous (readonly array(float64, 1d, C))
i is an int64
v is a float64.

I couldn't run your code to reproduce the error for more info (e.g. tre_n_split is undedefined) but somehow an array (or view) you are writing to is marked as read-only - perhaps its broadcasted or a view of something?
If you remove the @njit decorator, do you get a different error message that explains the issue in another way?
(For future reference - the Numba Discourse is a good place to post questions like this, as there are more active users answering questions there than on this issue tracker)

I think something like this would produce the same:
import numpy as np
from numba import njit

tre_n_arr = np.empty((3, 4))
tre_n_arr.fill(0)

@njit
def emb():
    tre_n_arr[0][0] = 12

emb()

The issue is caused by Numba treating global values as compile time constants. In this case the array tre_n_arr would be considered constant and so is made read-only at compile time and so writing to it is a violation.

Closing as it appears that the original question is answered and no further follow-up has been received.


Incompatibility between graaljs and Google Closure Library goog.provide

Google Closure Library's goog.provide doesn't work in graaljs when the given namespace starts with com.
This does work in other JS engines like nodejs. For example:
$ curl -O https://raw.githubusercontent.com/google/closure-library/66700f582b1f94d6ef6e8f9e7d9dbb2ca7d6d792/closure/goog/base.js

It works in nodejs:
$ node
Welcome to Node.js v12.1.0.
Type ".help" for more information.
> .load base.js
> goog.provide('com.bar.my_place')
undefined
> com.bar
{ my_place: {} }
>

But fails with graaljs version 19.0.0:
$ js
>  load("base.js")
function() {
  var /** !Object<string, boolean> */ requiresTranspilation = {'es3': false};
  var transpilationRequiredForAllLaterModes = false;

  /**
   * Adds an entry to requiresTranspliation ...<omitted>...
}
> goog.provide('com.bar.my_place')
Error: Namespace "com.bar.my_place" already declared.
	at <js> goog.provide(base.js:305:10391-10441)
	at <js> :program(<shell>:4:1:0-31)
> goog.provide('foo.bar.my_place')
> foo.bar
{my_place: {...}}

Note that defining a namespace which's first namespace part is not com works as expected. It seems com is already defined to some special thing, which breaks goog.provide.
> com
JavaPackage {Symbol(Symbol.toPrimitive): {...}}

The same problem exists also with the node binary which ships with graal.
This is a problem for ClojureScript, which uses Google Closure Compiler, as users are encouraged to use the reverse domain names for namespaces. None of that ClojureScript code, after being compiled to JS, would work with graaljs because of this.

ClojureScript issue: https://dev.clojure.org/jira/browse/CLJS-3087

As @mfikes noted over at the ClojureScript jira, probably the best solution would be to turn set js.java-package-globals to "false" for the ClojureScript environment.

@kommen thanks, interesting find. I'll check why we activate js.java-package-globals by default on a non-JVM runtime.

@wirthi is js.java-package-globals an experimental feature? I got a message that I shouldn't use it in production... why is that? This seems like a safe feature to disable

@pmlopes yet it is; we only marked a small set of flags stable (or "supported"). All other flags are available, but we don't guarantee long-term support for them. It is safe to use them currently, but future releases might change behavior, drop the option, etc. (similar to Java's XX-options).
We might also decide for future releases that an option is really crucial and add it to the "supported" list.
Best,
Christian

The root of the problem is that JavaPackage objects occupy the whole namespace with several prefixes (like com). goog.provide refuses to define anything with these prefixes because it thinks (through goog.isProvided_) that something useful already exists under the specified name.
Setting js.java-package-globals to false would solve this issue because it would remove the mentioned JavaPackage objects. Unfortunately, users would not be able to use a very handy syntax like new java.util.ArrayList() with such change. It would be ideal to have the best from both worlds: allow the Java-friendly syntax and don't have goog.provide broken.
This can be solved by patching goog.isProvided_ such that it returns false for JavaPackage objects. Would that be an acceptable solution for you? I saw that there are some patches related to graaljs in clojurescript already.
I am not sure what is the best/most reliable identification of JavaPackage objects but something like
object => typeof object === 'object' && typeof Packages !== 'undefined' && Packages[Symbol.toPrimitive] === object[Symbol.toPrimitive] may work well.

This can be solved by patching goog.isProvided_ such that it returns false for JavaPackage objects. Would that be an acceptable solution for you?

It would be a solution, but one would also risk collisions of names within those namespaces. I don't know how probable this would be, but I guess it would be a nightmare to debug and find out what is going on.

Setting js.java-package-globals to false would solve this issue because it would remove the mentioned JavaPackage objects.

It think the most sensible thing regarding to ClojureScript would be to just default js.java-package-globals to false for graaljs engines it instantiates itself - which one of the patches you're referring to does.
However, I'm still not clear why js.java-package-globals is on by default in non-jvm runtimes, as the globals are not useable anyway:
 $ js
> new java.util.ArrayList()
TypeError: Access to host class java.util.ArrayList is not allowed or does not exist.
	at <js> :program(Unknown)
> java
JavaPackage {Symbol(Symbol.toPrimitive): {...}}
>

Hi @kommen
yes, our suggestion is to set the js.java-package-globals flag to false in your usecase. We don't want to change the default behavior there, because that would conflict with other usecases.

... is on by default in non-jvm runtimes ...

We are blurring the border here a bit. Even in js --native mode, we have some limited support for Java interoperability, e.g.:
$ js --native
> Java.type("int[]")
JavaClass[int[]]

We might extend that in the future. The default will be false if hostClassLookup is deactivated (see allowHostClassLookup).
Best,
Christian

Thanks @wirthi for the clarification. Let's see if my patch to make js.java-package-globals false makes it into into ClojureScript. This would be a first step, but would still leave users in the dark when they run a javascript artifact produced with ClojureScript using graal's nodejs and js commadline tools.

We won't change the default of js.java-package-globals, as access to Java is a fundamental feature of GraalVM JavaScript.
As there has not been an update in this ticket for more than a year, I am closing it. Please re-open or create a new ticket if there are additional questions.


Roll Engine from 9f31d4f90bde to cf3ceeaac8b0 (4 revisions)

https://github.com/flutter/engine/compare/9f31d4f90bde...cf3ceeaac8b0
2021-12-03<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from RyloAtJNT... to gc6NLk09G... (flutter/engine#30118)
2021-12-03<EMAIL_ADDRESS>Roll Skia from 672062da97da to 29af7d59714b (4 revisions) (flutter/engine#30117)
2021-12-03<EMAIL_ADDRESS>Roll Skia from f278a8058eaa to 672062da97da (8 revisions) (flutter/engine#30115)
2021-12-03<EMAIL_ADDRESS>Update IosUnitTests to use iPhone 11 simulator (flutter/engine#30090)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from RyloAtJNTAv0 to gc6NLk09GTbp
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Bug fix: client should skip component updates that aren't needed

I did not add a test for this.

Codecov Report
Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (ded251e) 93.40% compared to head (0285252) 92.85%.

Files
Patch %
Lines

src/client.rs
67.85%
9 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                   Coverage Diff                    @@
##           packet-fragmentation     #125      +/-   ##
========================================================
- Coverage                 93.40%   92.85%   -0.56%
========================================================
  Files                        14       14
  Lines                      1062     1078      +16
========================================================
+ Hits                        992     1001       +9
- Misses                       70       77       +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thank you a lot, brilliant solution!


select CSS framework

Possible choices:

Bulma
Materialize
Foundation
Skeleton

Best choices: Bulma and Materialize
Bulma

docs provide samples and model how they are used
looks slightly better but will need heavy modification to fit project plans
Materialize
very friendly user interface in documentation
docs provide samples and model how they are used
models match project plans

Worst Choices: Foundation and Skeleton
Foundation

very extensive, too much to learn in timeframe available
Skeleton
too "bare bones" and minimal
may not have all the features needed for this project

Final Choice pending group member approvals: Materialize


Add the ability to configure timeouts from the startup context.

Client and Image liveness timeouts are only set from system properties. They should be sourced into the context.

:+1: I'm in that area and can take this one.

I've done a partial change to cover the images. Client is a bit more messy.

Driver timeout is in MS; client timeout is in NS. This should be more consistent.

Client keepalive value is in two places. ClientConductor and Configuration on driver side. It feels like these should be on CommonContext like the driver timeout.

Feel free to continue and complete if you are in the area.

It is a little odd in the that clients concern (for client liveness) is interval between keepalives. And the driver side is max lifetime.

Client timeout now settable in the context.


New job to quickly create signed composes

Part of https://jira.coreos.com/browse/ART-308 "Always build (images) ONCE"

This is net new, going to self-ACK here and merginate it.


UI elements no longer detectable after navigation

Hi.
We have experienced, that clearly detectable UI elements suddenly are no longer detectable after performing some navigation forth and back. The team have not been able to explain why, but have created a small app that easily reproduces the problem.
To reproduce, start the attached solution. Verify you can track the "Test FlaUI" in the data table.
Click the top "TestFlaUI" button in the data grid then click "Back". Do this twice.
Refresh the Inspector.
Track the "TestFlaUI" button.
Nothing is visible under the Tab page and no amount of refreshing the Inspector will make them visible.
If you only do the navigation once and refresh, then the button is trackable, it only breaks on the 2nd navigation. You can keep on tracking the UI element as long as you only do the navigation once between Inspector refreshes...
Hope you can help me figure out why the Inspector breaks.
Best regards
Thor
FlaUI_DataGridButtons.zip

Since this has gotten no traction and is not a specific inspector problem, I have raised it in the FlaUI page instead (https://github.com/FlaUI/FlaUI/issues/578). Will close this issue to not have duplicates.


classIdPrefix bug Webpack 3.10^

When setting the classIdPrefix: '[name]-[hash:5]__' option it doesn't generate an name-hash combo but instead injects [name]-[hash:5]__ litteraly using webpack 3.10.

Any news on this? Did you find a workaround?

svg-react-loader does not do any interpolation with the classIdPrefix.
Adding as a feature request.

I'm working on a solution, btw - should have a fix ready rather soon.


Replace bypass strategy description with one that better describes behaviour

The current description of the bypass strategy uses the phrase "simply silences index updates" to describe the bypass strategy. I think this is misleading as doing something silently doesn't mean that a process does not happen but rather that there is no output. If I select a process to happen silently, I would expect a normal behaviour but without anything being logged or output to the console.
I believe that the bypass strategy does more than simply suppress output. Instead it bypasses the index update on model save.

Thanks for improvment!


doc: update dockerTools.pullImage content and use doc conventions

Description of changes
This PR updates the dockerTools.pullImage section with new content, and restructures it to follow the conventions that we've been establishing for the nixpkgs manual.
One of the examples is affected by #283098, but I chose to keep it there because it is still useful for other scenarios.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/2024-01-25-documentation-team-meeting-notes-106/38792/1


chore(@lexical/text): Split into several files for better readability and to simplify further expansion

It's time to do some housekeeping if we want to add more helpers there :)

I don't mind this but let's hold off for a bit on merging until we get this ESM support release working.

@acywatson Hi! Do you think we can merge it now? Or if not - what is the blocking issue?


chore: dogfood CSP in report-only mode

Breaking Changes
N/A
Changes

feat:
fix:
chore:

Associated Issues
closes #...

@chris13524 thanks for fixing up a bunch 🙏 found some more missing for img-src from playing around with Swaps beta and ENS profile resolution.

Set up a docs draft for the page, with the lab-specific sources removed: https://github.com/WalletConnect/walletconnect-docs/pull/1603

@chris13524 rather than enforcing this on lab I think it's preferable to use report-only and pipe to Sentry: https://docs.sentry.io/security-legal-pii/security/security-policy-reporting/#content-security-policy
That way it will flag missing values without causing quiet breakage in manual and/or integration testing

Can we merge this?


better sqlite

Node Version: v15.14.0
Platform: win32
Compiler:
Module:
quick.db

Verbose output (from npm or node-gyp):
it worked if it ends with ok
cli [
'C:\Program Files (x86)\nodejs\node.exe',
'C:\Users\Collegien\node_modules\node-gyp\bin\node-gyp.js',
'rebuild',
'--release'
]
using node-gyp@%s 3.8.0
using node@%s | %s | %s 15.14.0 win32 ia32
UNCAUGHT EXCEPTION
stack TypeError: log.verbose is not a function
at Object.self.commands. [as rebuild] (C:\Users\Collegien\node_modules\node-gyp\lib\node-gyp.js:54:11)
at run (C:\Users\Collegien\node_modules\node-gyp\bin\node-gyp.js:87:30)
at Object. (C:\Users\Collegien\node_modules\node-gyp\bin\node-gyp.js:148:1)
at Module._compile (node:internal/modules/cjs/loader:1092:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1121:10)
at Module.load (node:internal/modules/cjs/loader:972:32)
at Function.Module._load (node:internal/modules/cjs/loader:813:14)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
at node:internal/main/run_main_module:17:47
System Windows_NT 10.0.17134
command "C:\Program Files (x86)\nodejs\node.exe" "C:\Users\Collegien\node_modules\node-gyp\bin\node-gyp.js" "rebuild" "--release"
cwd C:\Users\Collegien\Documents\GitHub\bot\node_modules\better-sqlite3
node -v v15.14.0
node-gyp -v v3.8.0
This is a bug in node-gyp.
Try to update node-gyp and file an Issue if it does not help:
Paste your log here, between the backticks. It can be:
  - npm --verbose output,
  - or contents of npm-debug.log,
  - or output of node-gyp rebuild --verbose.
Include the command you were trying to run.

This should look like this:

>npm --verbose
npm info it worked if it ends with ok
npm verb cli [
npm verb cli   'C:\\...\\node\\13.9.0\\x64\\node.exe',
npm verb cli   'C:\\...\\node\\13.9.0\\x64\\node_modules\\npm\\bin\\npm-cli.js',
npm verb cli   '--verbose'
npm verb cli ]
npm info using<EMAIL_ADDRESS>npm info using<EMAIL_ADDRESS>
Usage: npm <command>
(...)

The current release of node-gyp is v8.1.0 but the log output above says:

gyp ERR! node-gyp -v v3.8.0

Please use https://github.com/nodejs/node-gyp/wiki/Updating-npm's-bundled-node-gyp to upgrade to the current version of node-gyp.


Prevent metadata of auxiliary resources in container metadata

Closes #385 (again).
This reduces the performance for SPARQL backends due to the extra calls. This might actually increase the performance in some situations for file/memory backends.

All good.


How to use make.m

Thanks for this useful source code. I would like to use your code as a jumping off point, where I'd like to be able to write and compile my own lcr.cpp files for any of the commands in dlc350_api.cpp and call there .mex files in MATLAB. However, I have not been able to compile new .cpp files of my own or even just rebuild the library using the make.m function. Whenever, I run make.m, I receive an error for each file like, for example, the following:

mex  -I"C:\PutFilesHere\matlab-lcr-master\api" -L"C:\PutFilesHere\matlab-lcr-master" -llcr lcrSetPatternTriggerMode.cpp
Building with 'MinGW64 Compiler (C++)'.
Error compiling 'lcrSetPatternTriggerMode.cpp'
C:\Users\jjohn2811\AppData\Local\Temp\mex_7029798612222_25048\lcrSetPatternTriggerMode.obj:lcrSetPatternTriggerMode.cpp:(.text+0x52): undefined reference to `DLPC350_SetPatternTriggerMode(int)'
collect2.exe: error: ld returned 1 exit status

Before running make.m, I opened Developer Command Prompt for VS 2019, changed the directory to "C:\PutFilesHere\matlab-lcr-master\api" and ran the command "cl /Felcr /I hidapi-master/hidapi dlpc350_api.cpp dlpc350_usb.cpp hidapi-master/windows/hid.c SetupAPI.lib /LD". After doing this I received no errors.
Do you know why I am still unable to compile the .cpp files?

I am ashamed to admit that after deleting and re-downloading the code the problem was resolved.


Make the standard Voice configuarble

I've made the Standard Text-to-Speech voice available in the configuration, where you can choose from all Installed Voices (like the drop-down in Voice Attack).
Since this is my first time working with C# I only got the code building in the debug environment. So make sure to review the changes for rookie mistakes.
I also haven't included Tests, because I couldn't find a file that actually tests the configuration.exe.
I have tested the debug version and it actually uses the configured voice.
Please let me know if changes like this are appreciated.
Greetings CMDR Creeprr

So is the close just a no to the feature request of being able to select a voice, or was my code so bad that you want to implement the feature yourself?

Sorry this auto-closed when the feature branch was deleted, and for some reason I hadn't received a notification when it was created.
I'll take a look at this and see what it's doing.  Would it be possible to create a PR against the develop branch?
I will say, however, that I want to make the voice configuration available on a per-ship basis to allow for different voices as well as different modulations for each voice so I'm not sure how this would mesh with that idea.

Well it was a fast fix because I am playing on a German system and the english with german tts isn't understandable. I will look into a new pull request later this evening. Maybe also look into your thoughts while I'm at it.

My thought was to have a default voice in the 'EDDI' section and then the ability to also select one for each ship in the 'Shipyard' section (with a 'default' option if they don't want to do so).
There are also a number of parameters for each voice beyond just the name though (chorus/reverb/distortion/etc) so there would need to be some thought in to where all these fitted, and how to explain them to the user.  It might be that the easiest solution is to have a pop-up window where the user selected the voice and parameters, and had a 'test' button that would say something to allow the user to get a feel of how the voice sounds.  This could then be reused for both the default voice as well as the per-ship voice.


"Days in this column" value should not be changed when a task moved in the same column

Expected behaviour
"Days in this column" value should not be changed when a task moved to down or up in the same column.
Actual behaviour
I have 2 tasks in WIP column. After I move first task under of second task, "days in this column" value becomes < 15m.
Steps to reproduce

Create 2 tasks in WIP column
Wait 1 hour.
Change order of tasks.

Configuration
◾ Application version: 1.0.28
◾ PHP version: 7.0.5
◾ PHP SAPI: apache2handler
◾ OS version: Windows NT 6.3
◾ Database driver: postgres
◾ Database version: 9.5.2
◾ Browser: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; WOW64; Trident/7.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; GWX:MANAGED)

In this case, not to update the date_moved column in the tasks table is possible, but is it an accepted behavior ?

In KB 1.0.34, the moved date doesn't change anymore if the task is moved in the same column.


Add Terraform PPC page

https://github.com/pulumi/home/issues/660

@zchase what's needed to finish this off, assuming it's still relevant? Can I help get it finished up?

@cnunciato A review was all this needed, but now that stencil.js is a thing we probably want to implement the JS in stencil instead of jQuery, right?

Probably, but I'd also like to talk through this a bit more so I can help out with the overall UX.

@zchase Can we close this PR and revisit collaboratively on a replacement?

@cnunciato Yeah let's mark it as closed and come back. There are no near-term plans to use the page currently, though we should revisit this and /terraform.


Allow adding custom ldif files to the openldap chart

Updated deployment.yaml file in order to provide the desired argument --copy-service to start the ldap docker image so that a user of the chart can override the basis ldif file with another one provided as an argument when installing the chart.
@enis
Signed-off-by<EMAIL_ADDRESS>

/assign @mattfarina

Should we protect the argument with
{{- if .Values.customLdifFiles }}

or there is no need for that?

Good point, it should be there. Thanks for spotting it!

Hello @ehardon thanks for this PR

you need to bump the chart version
and sign the DCO
https://www.helm.sh/blog/helm-dco/index.html

@ehardon still missing the DCO you can follow this steps https://github.com/helm/charts/pull/7396/checks?check_run_id=15027962

Thanks @cpanato !

/lgtm

/ok-to-test

Can this be merged?

/retest

@ehardon can you please rebase and fix the conflict?

@cpanato fixed the conflict

/lgtm

@ehardon thanks!

@ehardon Can you please give us an example on how to include customLdifFiles?

@THPubs When installing the helm chart you need to provide a config yaml file which should include your customLdifFiles
helm install stable/openldap -f ldap_config.yaml
where the ladp_config.yaml  file should look like the example below:
customLdifFiles:
  file1.ldif: |-
    dn: ou=users,dc=example,dc=org
    objectclass: organizationalUnit
    objectclass: top
    ou: users

    dn: cn=uname,ou=users,dc=example,dc=org
    cn: uname
    gidnumber:
    givenname:
    homedirectory:
    objectclass: inetOrgPerson
    objectclass: posixAccount
    objectclass: top
    sn:
    uid:
    uidnumber:
    mail:
    userpassword:

@ehardon Great thanks a lot! It worked! It would be really nice if we can add it to the Readme so others can also find it easily.

Hi - good that we can dd customt LDIF files! But, for my understanding, will this only copy the custom .ldif's to /container/service/slapd/assets/config/bootstrap/ldif/custom or will it actually 'execute' (import) them too?

@gmcbrien Actually it does execute and seed the database. Worked for me. Can you please share a sample of your code?

@THPubs Thanks for your interest. Attached is my values.yaml (with some fake user info) - renamed to .txt.
values.txt

@gmcbrien Sorry Im unable to find any issue with the file you sent. Try with one single ldif file and see?

@THPubs No problem and thanks for offering support.
According to this site https://github.com/osixia/docker-openldap#seed-ldap-database-with-ldif (where the original OpenLDAP image comes from):

**Seed ldap database with ldif**
This image can load ldif files at startup with either ldapadd or ldapmodify. Mount .ldif in /container/service/slapd/assets/config/bootstrap/ldif directory if you want to overwrite image default boostrap ldif files or in /container/service/slapd/assets/config/bootstrap/ldif/custom (recommended) to extend image config.
Files containing changeType: attributes will be loaded with ldapmodify.

My LDIFs are getting copied successfully to the 'custom' folder. But not being executed (at least, I see no users in the database).
I tested editing the volumeMounts in the deployment.yaml to point to
mountPath: /container/service/slapd/assets/config/bootstrap/ldif/ (and not the custom subfolder). Again, my LDIFs get copied there... but no users in the database.
I also don't understand the comment about 'changeType'....

Just an update - my problem is resolved.
I removed the part of my LDIF that defines the organisation ('o') and domain ('dc') and basically just left in there the definition of the roles and users. This worked fine. I am guessing my LDIF was being rejected as I was trying to overwrite 'top-level' data in my database, and this wasn't permitted.


Support for Windows MSI archives (WiX) is broken

This issue was originally created at: 2011-01-11 09:05:03.
This issue was reported by: dirkbaechle.
dirkbaechle said at 2011-01-11 09:05:04

Hi,
based on the user reports/questions in
http://scons.tigris.org/ds/viewMessage.do?dsForumId=1272&dsMessageId=2435080
I started to investigate the problem a little bit. From what I see in the
sources for Tool/wix.py and Tool/packaging/msi.py it simply cannot work at the
moment:
1.) In lines 492-495 of msi.py we have
this builder is the entry-point for .wxs file compiler.
wxs_builder = Builder(
action         = Action( build_wxsfile, string_wxsfile ),
ensure_suffix  = '.wxs' )
where the last line looks wrong to me. This should read something like
 suffix = '.wxs',
 ensure_suffix  = 1 )

instead.
2.) When fixing 1), I get the next error in gen_dos_short_file_name() at line
117 of msi.py. The expression
fname[:8-len(str(num))]
becomes a list, which doesn't have an "upper()" method.
Best regards,
Dirk

dirkbaechle said at 2011-01-11 09:07:55

Created an attachment (id=827)
Very simple testcase

dirkbaechle attached wix.zip at 2011-01-11 09:07:55.

Very simple testcase

This is still an issue in SCons 3.0.1.


Rehaul git-branch-name

Fix several bad memory references
Add more error handling conditions
Remove non-standard ISDIR/ISREG references
Default PATH_MAX to 4096
Default hash_truncate_length to 12
Add compile-time QUIET flag
Add two optional args: [] []
Run through formatter
Add comments

Thank you. Honestly I don't use this command anymore. I have invited you as a maintainer.


Type definition file for TypeScript is missing

Is your feature request related to a problem? Please describe.
When I use TypeScript and import this lib, I got the error inside of VSCode and via serve, that the typedef file is missing. If it is easy for you, please add it. Otherwise, I will have a look later to generate one, when I have time.
Describe the solution you'd like
Creating a .d.ts file
Additional context
Context is, using your plugin with TypeScript in Vue.

Duplicate of #54


Adding classes for constructor tables

Maybe I went too "smart" with the inheritance here, but I was lazy to type out a lot of duplicated fields across the different views. I might have missed something? In any case, this can be a good starting point to annotate each class explicitly as well.
Also cleaned up a bit of naming and aliased the number<->string functions.
Still needs work:

commenting each field for the props (or transfering comments form the class defs)
noting that child views can be added to the tables where appropriate
remove the write-only fields from the classes that are only applicable when constructing

Maybe I went too "smart" with the inheritance here, but I was lazy to type out a lot of duplicated fields across the different views

Always good to be lazy :) On the other hand, it might be easier for me to maintain this in the future if it follows Renoise's internal view inheritance.
View -> Control -> SomeSpecializedControl
     -> SomeSpecializedView

But either way this is fine for now. So you decide what's easier to manage for now. Especially because what we have now is already a great improvement.
I won't have time to go over this in detail over the weekend, but I will continue this next week.
Until then, thanks a lot for your very helpful contributions.  It really helps a lot!

Sure thing!
I made it so the _Properties classes mirror the list you've shared.

Converted every type for views to an alias to make editing the doc comments easier: change the comments for the aliases and it changes for both the class and the constructor table classes.
Removed the write-only bind/notifier fields from the classes.
Cleaned up the whole document a bit so it's the same order everywhere, "View class header, aliases, View description, properties, functions"
Moved defaults to the alias descriptions to show up in editor hints for both the constructor tables and classes
Fixed a few wrong types for properties

It all seems to work nicely in practice.

I copied the explanation of the show_custom_dialog into application.lua, since that way it would show up as a hint when calling this function.

Much of the explanation can be encoded in the type system itself so I left the parts that talk about something being optional to the ? notation in the new KeyEvent class def.
The keyhandler function had the wrong type here
TODO I'm not sure if modifiers uses "command" or "control" on Mac, the ModifierStates alias might need to be extended.

After revision, much of the top section from view_builder.lua could be dropped imo.

I think we can use a union type for the key_handler here instead of an overload.

That indeed is platform specific and can be a combination of:

Windows: "Control"|"Shift"|"Alt"|"WinKey"
Linux: "Control"|"Shift"|"Alt"|"Meta"
Mac: "Command"|"Shift"|"Option"|"Control"

You mean "mac: control | shift | option | command"? Control on other platforms corresponds to control on Mac, right?
I didn't know meta key was also available here (doesn't work for me on Linux). In that case listing all permutations might be excessive.
That being said this API is kinda confusing because you have to know the precedence rules as well (shift > alt > control) or use find on the string instead.  Maybe in the future this could be deprecated and abstracted away across platforms? Since I don't think many tools want to do something different for Win/Mac/Linux anyway, so it could be a just table of booleans instead of a string, like { control : boolean, shift : boolean, alt : boolean, meta : boolean} which would be easier to document, check against and handle the cross-platform.
Where is the meta key in the precedence order?  And is it formatted as "winkey" on Windows?
As for TODOs maybe it would be better to move or somehow share the class definition comments (and ASCII art) with the builder functions, since those are what you use more while coding, and they show nothing currently, you'd have to manually look up the class to get to the general explanation of each view type. Now I've put @see links pointing to the class from the constructors to make this a bit better. Unfortunately the @see links from class->constructor didn't seem to show up.

I've converted every instance of optional types from the type|nil to the type? syntax from to be consistent.

Tell me what you think of the Modifier explanation I did.

Looks good!

I think we can use a union type for the key_handler here instead of an overload.

This also works, but makes the signature harder to read because it's super long.

That being said this API is kinda confusing because you have to know the precedence rules as well

Yes, agree. That should be changed in future.

Where is the meta key in the precedence order? And is it formatted as "winkey" on Windows?

Yes, it's "WinKey". The order is "Shift" < "Alt" < "Control" < "Meta".

I found another issue with the definitions.
Since the constructor functions are defined on the ViewBuilder class, you can write the things below, none of which is actually possible, yet the language server will not say anything.
-- text doesn't exist on the ViewBuilder class at runtime
rprint( renoise.ViewBuilder:text { text = "bla" } )

-- views doesn't exist either
rprint( renoise.ViewBuilder.views )

vb = renoise.ViewBuilder()
-- constants don't exist on a ViewBuilder instance
print(vb.DEFAULT_DIALOG_MARGIN)

I fixed this by adding a local dummy class ViewBuilderInstance which makes all the above lines be flagged by the lsp.

I've converted every instance of optional types from the type|nil to the type? syntax to be consistent.

Agree. But I'd prefer to keep things focused on the ViewBuilder here and do this later in a separate commit.

I fixed this by adding a local dummy class ViewBuilderInstance which makes all the above lines be flagged by the lsp.

Cool. That actually is a problem in the entire API and the XXXInstance thing looks like a clever fix.
I'll check if we can make this a pattern in the API.

You mean it's in PascalCase? On Linux all the modifiers are lowercase. Is this different for other platforms or just this one key?

No, sorry. They are all lower in the API, internally they are not. I've confused things here.

Guess it could be just with a + sign instead.

Yep!

I see, if there is nothing else I think this might be it for the view_builder defintion.
I've added the nested view hints to the appropriate constructor functions to tick off that TODO.

Looks great to me. If you're happy with it, let's merge it.
Thanks again for all your help. I couldn't have done it alone with all the details!
My TODOs for the next release regarding the viewbuilder:

add new "modifier_flags" property to KeyEvent and make old "modifiers" deprecated:

{
  command: boolean,  -- Command key on macOS else Control
  shift  boolean,
  alt  boolean,
  meta: boolean  -- Control key on macOS, Windows key on Windows, Super key on Linux
}

add new "views" property to renoise.Views.View to specify child/sub views in space/rack/aligned as property, instead of mixing array/key-value notation.

Anything else?

Happy to help!
Can't think of anything else to improve right now, so merging would be fine.

 command: boolean,  -- Command key on macOS else Control
 shift  boolean,
 alt  boolean,
 meta: boolean  -- Control key on macOS, Windows key on Windows, Super key on Linux
}

*control : boolean I suppose to align with the naming convention of the majority

Anything else?

Technically these can be worked around right now but I would love to have

ViewInstance.views which would return all the child views added to a particular view. Would be nice with the mentioned views property on the constructor table as it would mirror that on the created instance.
ViewInstance:clear_children() a convenience function which would allow us to remove every child of the view without having to hold a reference to each. Although Having a views property on the created instances would make this easier to implement, so it's not as needed.


Stop prioritizing Archived chats

Details

When in #focus mode this will ensure that archived reports are not shown in the LHN.
We also will stop including them in the global unread count regardless of what mode you are in.

Note: This change can possibly be reverted in the future if we land on a backend solution where we mark these chats as "read" by default.
 To do this you must go into OldDot as the User A and do this in the JS console:API.policy_employees_merge({
    policyID: '89A1395A94B9A81F',
    employees: [{"email":"b<EMAIL_ADDRESS>});

Refresh the page for User B and put them in #focus mode.
Clear out any unread chats for them so there is only the Concierge chat
As User A delete the workspace.
Verify that User A (still in Most recent mode) can see the archived chats in the LHN
Verify that User B sees no archived chats
Refresh the page as User B
Verify they still can't see the archived chats
Put User A into #focus mode and unpin all chats except the Concierge chat
Verify they also now can't see the archived chats in the LHN

[ ] Verify that no errors appear in the JS console

Offline tests
N/A
QA Steps
Same as tests

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Sorry didn't realize how many tests are failing. Putting it back into draft for now.

User B also need to be admin? Can just be invitee?

Yes, that is indicated here:

Invite User B and make them an admin

Ok, figured out the tests on this. I will leave some comments in this review to explain why some things are getting removed.

Putting this on HOLD as I'm going OOO and I think maybe we are still debating the proper solution.
@aldo-expensify probably has the next best context so if you feel like pushing this one forward to help close out Wave 1 feel free. Otherwise, will pick it up when I return.

I believe we had deviated from this solution and this one can be closed out.


Diffing large files hangs/freezes atom

When attempting to diff two relatively large file (~1200 lines each). Atom tends to hang or freeze and often needs to be restarted. Maybe this is due to the fact that it has to diff again every time a modification is made?

Hi @johnsoga, what version of Atom are you on? What version of split-diff are you on? What is your operating system, amount of RAM, CPU etc?
I ask because I am not seeing Atom freeze during a diff of files that large - just a loading indicator (that shouldn't block the UI) as it computes the diff.

@mupchrch I'm having almost the same issue where atoms slows down and just says computing diff forever waited over 20mins, trying to split-diff a file with over 400,000 lines. It use to work and give me the diff in no time at all but now it does not.
Computer Ryzen 1600, 8GB Ram, Tried Atom 1.18 and 1.19b2, split-diff 1.4.3 and minimap-split-diff 0.3.7

this seems to have gone away in newer versions.


Show the result directly if the url is being scanned or if the result is still valid.

Steps to reproduce:

Scan an URL.
While it is still scanning, try to scan the same URL.

Expected:
You see the scan screen.
Current:
You see the "waiting" screen.

ref: https://github.com/webhintio/online-service/issues/166


security/acme-client

I keep getting the following bug on my dashboard :(
[22-Oct-2017 00:00:02 Etc/UTC] PHP Warning:  cert_action_validator(): Node no longer exists in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 122 [23-Oct-2017 00:00:02 Etc/UTC] PHP Warning:  cert_action_validator(): Node no longer exists in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 122
This is with the latest version of Opnsense as well.  Any help appreciated!

It's an warning caused by the garbage collector of PHP 7 and it's harmless. We have, however, not found any clues as to how it can be fixed, there is some info available on the web but non applies in these circumstances (there have been a few commits to try to address this). We hope the jump to PHP 7.1 changes the behaviour of this warning. But it's quite impossible to know because we can't be sure why it is warning about it in the first place.

@fichtner I expect the object is somewhere changed within the loop, which invalidates the next fetch of children(). A simple workaround could be to clone() the "$configObj->OPNsense->AcmeClient->certificates" object before iterating, but there might as well be a bug somewhere within the methods in the loop modifying the same object. The loop is a bit too complicated to inspect easily.

Preliminary crash report examination seems to confirm my suspicion: PHP 7.0 garbage collection was too aggressive and 7.1 fixed this...

@fichtner Just configured another Let's Encrypt setup on top of 17.7.9_9 and got this message again:
[11-Dec-2017 14:42:37 Europe/Berlin] PHP Warning:  cert_action_validator(): Node no longer exists in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 122

I'm pretty sure @AdSchellevis's assumption is correct, because the objects actually are changed within the loop. I have to collect all changes in the loop without modifying the object and commit all changes at the end of the run. That being said, I'm unsure how to implement this, so some advice how to properly do this would be very welcome. :)

A fix was committed and will be available in the next OPNsense release.
All fearless people may apply the patch manually:
opnsense-patch -c plugins 541cfdbe222b60f48c3664bae4db321da1455016
Please report back.

@fraenki In the latest released version (1.15) the error still occurs:
[01-Jun-2018 13:52:29 Europe/Berlin] PHP Warning:  cert_action_validator(): Node no longer exists in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 182
[01-Jun-2018 13:52:29 Europe/Berlin] PHP Warning:  cert_action_validator(): Node no longer exists in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 255
[01-Jun-2018 13:52:29 Europe/Berlin] PHP Warning:  SimpleXMLElement::attributes(): Node no longer exists in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 1124
[01-Jun-2018 13:52:29 Europe/Berlin] PHP Warning:  log_cert_acme_status(): Node no longer exists in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 1124
[01-Jun-2018 13:52:29 Europe/Berlin] PHP Warning:  log_cert_acme_status(): Node no longer exists in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 1132

Regards,
Fabian

I still see these warnings with lastest code:
FreeBSD 11.2-RELEASE-p9-HBSD  f083bc4f8a0(stable/19.1) amd64
OPNsense 19.1.4 736dc49c3
Plugins os-acme-client-1.20 os-arp-scan-1.1 os-cache-1.0 os-dyndns-1.13 os-haproxy-2.15 os-lldpd-1.1 os-postfix-1.8_2 os-tor-1.7_1 os-upnp-1.3
Time Tue, 26 Mar 2019 16:51:10 +0000
OpenSSL 1.0.2r  26 Feb 2019
PHP 7.1.27

I still see these warnings with lastest code

@ssbarnea Could you please add the actual log message too? Because there are multiple places in the code where this issue may be found. Ideally you would provide the acme errors in context with everything else, this might help me to figure out what's going on and what triggers this error.
To everyone else: If you find a way to reproduce these "node no longer exists" warnings, please share it with me. Currently I'm unable to reproduce it.

Earlier today I got this Error message on a brand new installation. First I added a firewall rule to allow HTTP and HTTPS on the WAN interface. Second, I changed the key length to 2048 bit.  Now I do get a fine certificate =)
User-Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0
FreeBSD 11.2-RELEASE-p10-HBSD  5e5adf26fc3(stable/19.1) amd64
OPNsense 19.7.b_92 55641d204
Plugins os-acme-client-1.23 os-dyndns-1.15_1
Time Wed, 12 Jun 2019 10:33:17 +0000
OpenSSL 1.0.2s  28 May 2019
PHP 7.2.19

[12-Jun-2019 08:57:11 Etc/UTC] PHP Warning:  cert_action_validator(): Node no longer exists in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 171
[12-Jun-2019 08:57:11 Etc/UTC] PHP Warning:  cert_action_validator(): Node no longer exists in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 243
[12-Jun-2019 08:57:11 Etc/UTC] PHP Warning:  SimpleXMLElement::attributes(): Node no longer exists in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 1186
[12-Jun-2019 08:57:11 Etc/UTC] PHP Warning:  log_cert_acme_status(): Node no longer exists in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 1186
[12-Jun-2019 08:57:11 Etc/UTC] PHP Warning:  log_cert_acme_status(): Node no longer exists in /usr/local/opnsense/scripts/OPNsense/AcmeClient/certhelper.php on line 1194


Add TIDAL support to oembed

This adds TIDAL support for embedding playlists/tracks.
An example of a TIDAL link is:

https://tidal.com/browse/playlist/1d71b4bb-db33-4bfd-b7c9-135b9b67f3a7
https://tidal.com/browse/track/593849

Unrelated to this change:
I also was looking into Apple Music, but couldn't find the oembed endpoint. Might do in a different PR if I find it. If anyone else finds it, please let me know or create a PR :)

@woutdp thanks heaps for taking the time to submit this PR, we have merged this in.
Feel free to put up a new PR also for any others, but just a reminder that Watail users can easily extend/add their own oEmbed providers also. https://docs.wagtail.io/en/stable/advanced_topics/embeds.html#customising-embed-providers
Please check the commit that you are happy with how your name is listed.
https://github.com/wagtail/wagtail/commit/348aec32e59634550a5e02092601181483ab4efa
Have an amazing week.


Cannot acquire connection even all connections are idle

I am using Spring Boot 2.1.6 with HakariCP 3.2.0
I am trying to print out the connection pool status as below before executing queries.

As you can see there are 100 idle connections and zero active connections.
But the MyBatis still throws error which said: Connection is not available

I am confusing about exactly what idle connections mean.
Can someone help me explain this?
Thank you.

Enable debug-level logging for com.zaxxer.hikari.

I have the same issue. How to resolve this issue?

Without debug log information, there isn't much that we can do to investigate. And in fact we would prefer if you only open tickets here on github issues if you know specifically what the bug in HikariCP is and can explain how HikariCP is wrong.
If you are looking for help diagnosing a problem in your system, we recommend stackoverflow instead.


Finish bitfield test suite

Fixes #7.

FYI @Robbepop

Are you going to add solutions to the workshop items to have a go-to when they are stuck or do you accept such solutions? They could for example live in another branch.

I keep public reference solutions for all five projects in GitHub if you know where to look, but I wouldn't want them to be listed as branches. I would prefer that people file issues when stuck so that I find out what content needs to be improved.

I really like the test-driven specification by this PR - it gave me a much better understanding of how the interfaces are meant to work towards the user facing side.
Maybe I will give it a try. :)


add the CDN urls to the webpage

https://cdnjs.com/libraries/graphics-element

and then we'll have to see if it picks up on NPM updates now that it's supposedly watching

landed in v1.8.0


Trying to delete my capability, but is not working

I`ve tried many times, but isnt working.
Thanks!

Same here

This has been fixed.


Get Insomnia app version or actual user-agent header

Currently the user-agent header is hard coded, and the app version is missing from it (only kept the year part). This temporary fix came as a result of an Insomnia update that made all non-custom headers for a request (i.e. all the headers added by Insomnia automatically such as user-agent, host, accept-encoding) unavailable from the context object. Working on a fix for this over at Kong/Insomnia.

Commit https://github.com/resurfaceio/insomnia-plugin/commit/2d4e755ab2bd76a15e88a809663671697597f88d closes this.


[chore]  Update Python Dependencies and remove unsued scripts in the repo

Fixes #643
Thi PR removes the integration test scripts in the repo, which are not used and have no purpose to sit in this repo, helps for the better maintainance of the project and Updates the Python dependencies.

Please split the two into separate PRs, otherwise it makes it harder to review

The PR build was failing, if not updating the version of python. So had to keep it in one PR.

Looks like there's an error in the build:
Error: CustomMakeBuilder:MakeBuild - Make Failed: WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv

Looks like there's an error in the build:
Error: CustomMakeBuilder:MakeBuild - Make Failed: WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv

yeah looks like the failure is something related to this change looking into it now.

Looks like there's an error in the build:
Error: CustomMakeBuilder:MakeBuild - Make Failed: WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv

oh yes, Rebasing to the main has worked as it seems git merge has both changes in place led to conflict.
The PR is now ready to merge :-).

Thanks @vasireddy99


utils, labels: Move tests secret label to libsecret

What this PR does
Before this PR:
The label "kubevirt.io/secret" used in e2e tests to mark secret that should be deleted before each test by the global test suite cleanup.
After this PR:
Remove the label definition from utilis/lables.go and export the one at libsecret package.

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

/lgtm

/sig code-quality

/approve

/hold
@ormergi Could you please fix the linter issue?

/hold cancel


3090  run instant-nsr-pl  :  RuntimeError: CUDA error: out of memory

*\venv\lib\site-packages\torchaudio\backend\utils.py:74: UserWarning: No audio backend is available.
File "multiprocessing\spawn.py", line 116, in spawn_main
File "multiprocessing\spawn.py", line 126, in _main
File "D:\AI_3D\Wonder3D\venv\lib\site-packages\torch\multiprocessing\reductions.py", line 121, in rebuild_cuda_tensor
storage = storage_cls._new_shared_cuda(
File "D:\AI_3D\Wonder3D\venv\lib\site-packages\torch\storage.py", line 932, in _new_shared_cuda
return torch.UntypedStorage._new_shared_cuda(*args, **kwargs)
RuntimeError: CUDA error: out of memory
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with TORCH_USE_CUDA_DSA to enable device-side assertions.

My 3090 can cover the memory. I think you should check your cuda version-11.7 and the version of torch


[Feature] Add user management functionality into the module

Add user management - Default Meteor
MVP styling

Completed.


Set started/stopped mails sender and address

AFAIK, the specs of mails sent by Fail2ban when it starts are handled by action.d/{sendmail,mail}-common.conf (which one is used depends on mta value in jail.local).
So in order to configure this, this role could simply add a task like this:
  - name: set email sender address
    ini_file:
      dest: "/etc/fail2ban/action.d/{{fail2ban_mta}}-common.local"
      section: Init
      option: "{{item.k}}"
      value: "{{item.v}}"
    with_items:
      - { k: "dest", v: "{{fail2ban_destemail}}" }
      - { k: "sender", v: "{{fail2ban_sender}}" }
      - { k: "sendername", v: "{{fail2ban_sendername}}" }
    notify: restart fail2ban

I would like that! at least until the underlying problem in Fail2ban is fixed?


Add kamelets marked as planned

There are many kamelets in the camel components documentation marked as "planned", they should be available for testing.

@oscerd @christophd can you merge this PR ?


Require IDs to be strings

Why: Instead of allowing both numbers and strings, accept only strings. The caller is now responsible for converting numbers to strings.
How: removed code to convert numbers to strings. Removed tests that looked for this behavior.
Test Plan: yarn test

will need to update the changelog breaking changes section.
also, do we want to throw an error if the id is a number? at the moment it will send the request successfully (assuming the rudder-server will be unable to process the incoming event though). might be dangerous?