ngSanitize triggers CSP alert/report in Firefox

I'm submitting a ...

[X] bug report
[ ] feature request
[ ] other

Current behavior:

If ngSanitize is added as a module dependency and a Content-Security-Policy is set that does not allow inline styles then Firefox shows the following message:

Content Security Policy: The page’s settings observed the loading of a resource at self (“default-src”). A CSP report is being sent.

Our CSP looks like this:

Content-Security-Policy-Report-Only: default-src 'self'; report-uri /foo

If ngSanitize is removed from the module dependencies then the CSP message disappears as well.
Expected / new behavior:

ngSanitize should work in Firefox without triggering CSP alerts, at least if the "ng-csp" mode is enabled.
Minimal reproduction of the problem with instructions:

Set the Content-Security-Policy to: default-src: 'self'
Add 'ngSanitize' as a module dependency.

AngularJS version: 1.6.9

Browser: Firefox 60.0a1 and 59.0b10
Anything else:
I guess the following code triggers the CSP alert, since it adds an inline

@thesam do you have any suggestion for how we could test for this FF bug (which is a security vulnerability) without the inline style?

If I understand correctly this is how it works right now:

If Safari bug exists: Use getInertBodyElement_XHR
Else if Firefox bug exists: Use getInertBodyElement_DOMParser
Else: Use getInertBodyElement_InertDocument

Maybe it could be done like this instead?

If Safari bug exists: Use getInertBodyElement_XHR
Else if DOMParser is available: Use getInertBodyElement_DOMParser
Else if Firefox bug exists: fail/throw/abort!
Else: Use getInertBodyElement_InertDocument

This way, the Firefox CSP alert will not be triggered if DOMParser is available.
I guess this would mean that most browsers would use DOMParser instead of InertDocument. Are there any negative side effects of using DOMParser instead of InertDocument?

This now also triggers an error in Chrome.

@thesam do you have any suggestion for how we could test for this FF bug (which is a security vulnerability) without the inline style?

I went through the details I could find on this:

the Angular.js commit that introduced this CSP violation: fix($sanitize): use appropriate inert document strategy for Firefox and Safari
the Angular pull request that introduced the CSP violation in angular/core: fix(core): use appropriate inert document strategy for Firefox & Safari
related "Details about the Security Issue" section in DOMPurify 0.6.7 release notes
related Firefox bug report HTML Parser ambiguity with inline svg and nested styles

It doesn't seem that the inline style tag is relevant; if I replace it with span, the bug is still detected in Firefox (and not in Chrome or Safari). I verified it by adding a console.log after if (inertBodyElement.querySelector('svg img')) { (in the Angular.js code) and if (this.inertBodyElement.querySelector && this.inertBodyElement.querySelector('svg img')) { (in the Angular code).
Also the related unit test description is "should not allow JavaScript hidden in badly formed HTML to get through sanitization (Firefox bug)", and none of the related discussions really mention the style tag. The bug is more related to the HTML structure than the actual tags if I understood correctly (though some tags like img may still be relevant).
Now that Angular.js is in Long Term Support, would it still be worthwhile to fix this? I guess this doesn't really count as a "security flaw".

I would argue that it does count as a security flaw because now my only course of action is to effectively cripple my content security policy by adding 'unsafe-inline'

Thanks for your input @crhistianramirez, I went ahead and created a pull request, let's see how it goes. 🙂

Any plans to take this off of the Backlog - won't fix Milestone?

On what version can we have this fix?

1.8.1 see https://github.com/angular/angular.js/blob/master/CHANGELOG.md#181-mutually-supporting-2020-09-30


Trainer.fit() crashes if no checkpoint callback is provided

I hope it's okay that I keep posting issues...
Now that I can circumvent the github installation issues, I pulled in the latests master and let my simple CoolModel demo code run. But now calling trainer.fit() crashes with:

AttributeError                            Traceback (most recent call last)
 in
21                  )
22
---> 23 trainer.fit(model)
24 # exp.close()

/opt/miniconda3/envs/dev_pytorch_lightning36/lib/python3.6/site-packages/pytorch_lightning/models/trainer.py in fit(self, model)
494                 self.optimizers, self.lr_schedulers = self.optimizers
495
--> 496             self.__run_pretrain_routine(model)
497
498         # return 1 when finished

/opt/miniconda3/envs/dev_pytorch_lightning36/lib/python3.6/site-packages/pytorch_lightning/models/trainer.py in __run_pretrain_routine(self, model)
680
681         # restore training and model before hpc call
--> 682         self.restore_state_if_existing_checkpoint()
683
684         # enable cluster checkpointing

/opt/miniconda3/envs/dev_pytorch_lightning36/lib/python3.6/site-packages/pytorch_lightning/models/trainer.py in restore_state_if_existing_checkpoint(self)
261
262         # find last epoch
--> 263         checkpoints = os.listdir(self.checkpoint_callback.filepath)
264         for name in checkpoints:
265             # ignore hpc ckpts

AttributeError: 'NoneType' object has no attribute 'filepath'

Looking at the code, it appears to happen because I did not provide a checkpoint callback and it tries to access it in restore_state_if_existing_checkpoint

now I added a ModelCheckpoint callback to test it and it still crashes, as the callbacks filepath does not exist when running for the first time

good catch... definetely a bug from the thing i pushed yesterday.
there is no test for that particular case either haha. good catch!

@egonuel try again. fixed

@williamFalcon this also works now, thank you!


[REFACTOR] Remove template transform

Removes the experimental template transform that {{set}} was using,
making it a standard helper.

Do you know of any codemod in existence that coverts from 1.x to 2.0 invocation style?

@pzuraq Thank you for this! :heart:


File Upload

@ajsturrock: Hi Adam, just doing some extra work on the black crows site. We tried to add a new flow to category to add a cover image to category pages

Dave Ghijben [10:30 AM]
I added a new field to category

Dave Ghijben [10:30 AM]
with the following values

Dave Ghijben [10:31 AM]
name=cover
slug=cover
required=no
unique=no
type=File Upload
FIle formats= jpg, png, tif, jpeg, gif
maximum file size I left empty

Hi Dave, we'll need to make a push to our PHP SDK to fully support the file field type in forge, I'll speak to the team first thing tomorrow for you.

This is what rolled back to disable the file field type -

Removed POST support for files and data:
https://github.com/moltin/php-sdk/commit/532701dbf10961b93325002fc60b516d7dd8a433

Removed the field type from the form builder:
https://github.com/moltin/php-sdk/commit/939a0e8a62aae35e2961f73ec442c9f4ca978851

I got Forge working properly on my local machine connected with the live database, I rolledback the commits metioned above and I can add a new file type field to a category flow then go to the entries of that category and add one img per time, as well as in this case (because already existed a field cover) add a cover which was exactly what the user is requesting on this issue.

Question: why this feature were removed? what was the issue with those commits?

and add one img per time
Can you add more than one image per time on the products and the categories?

Also could you try updating categories, as well as reordering them via Forge.
I have a feeling that one of the issues was that you could no longer reorder them, but I'm not 100% sure if we fixed this or not.

@outrunthewolf you can add more than one image from the Images tab but not from the General tab
@jHoldroyd updating works, so if you change something on the category it got saved on the database, however reordering the categories (if I understood what you mean with that, see picture below) is not working but it was not working before neither. If you go to the live forge and try to reordering them it just reorder them but when you refresh the appear on the previous position.

@jHoldroyd ok just detected so issues when updating the category the cover just got deleted I'm having a look to that now

@jHoldroyd could you please confirm that being able to reordering the categories is something that have to be fixed?


zone support

Another API I was using in pcbnew was InsertArea.
Here's a slightly abbreviated dump of one of the areas that I'd created; I've removed some of the points from the polygon:
  (zone (net 2) (net_name GND) (layer F.Cu) (tstamp 58FCDE74) (hatch edge 0.508)
    (connect_pads (clearance 0.508))
    (min_thickness 0.254)
    (fill (arc_segments 16) (thermal_gap 0.508) (thermal_bridge_width 0.508))
    (polygon
      (pts
        (xy 67.944355 25) (xy 67.944355 25)
      )
    )
  )

(this is useful for ground and power planes)

I don't know how much value this adds over the bullet in #9

Fixed


Cannot login with GitLab

I confirm (by marking "x" in the [ ] below: [x]):

[x] This is not a troubleshooting question. Troubleshooting questions go here: https://docs.mattermost.com/install/troubleshooting.html.
[x] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[x] I have read contributing guidelines.

Summary

Environment

Operating System: Ubuntu Budgie 20.04
Mattermost Desktop App version: 5.0.4 64-bit .deb
Mattermost Server version: can't find out

Steps to reproduce
Open desktop client. Click on GitLab login page link
Expected behavior
GitLab login page opens
Observed behavior
Nothing happens. Terminal output says opening link was prevented

@pessi-v You can find the Mattermost server version at Main Menu > About Mattermost. Can you help check this?

@amyblais I think I can't get to the Main Menu because I can't login, but the server admin says it's 6.3.2

@pessi-v Would you be willing to try the latest release candidiate of v5.1? It may fix your issue.
https://github.com/mattermost/desktop/releases/tag/v5.1.0-rc.2

@devinbinnie 5.1.0-rc2.1_amd64 didn't work either

17:33:35.229 › webContentEvents.did-start-navigation {
webContentsId: 3,
url: 'https://chat.x.org/oauth/gitlab/login'
}
17:33:35.232 › webContentEvents.will-navigate {
webContentsId: 3,
url: 'https://chat.x.org/oauth/gitlab/login'
}
17:33:35.234 › Prevented desktop from navigating to: https://chat.x.org/oauth/gitlab/login
on 'Finest':
17:35:55.375 › TeamDropdownView.handleClose
17:35:55.380 › webContentEvents.did-start-navigation {
webContentsId: 3,
url: 'https://chat.x.org/oauth/gitlab/login'
}
17:35:55.381 › webContentEvents.will-navigate {
webContentsId: 3,
url: 'https://chat.x.org/oauth/gitlab/login'
}
17:35:55.382 › Prevented desktop from navigating to: https://chat.x.org/oauth/gitlab/login
17:35:55.388 › MattermostView.handleFaviconUpdate {
tabName: 'X___TAB_MESSAGING',
favicons: [
'https://chat.x.org/static/images/favicon/favicon-default-16x16.png',
'https://chat.x.org/static/images/favicon/favicon-default-24x24.png',
'https://chat.x.org/static/images/favicon/favicon-default-32x32.png',
'https://chat.x.org/static/images/favicon/favicon-default-64x64.png',
'https://chat.x.org/static/images/favicon/favicon-default-96x96.png'
]
}
17:35:55.389 › MattermostView.handleFaviconIsUnread {
favicon: 'https://chat.x.org/static/images/favicon/favicon-default-16x16.png',
viewName: 'X___TAB_MESSAGING',
result: false
}
17:35:55.390 › AppState.emitMentions {
serverName: 'X___TAB_MESSAGING',
isExpired: false,
newMentions: 0,
newUnreads: false
}
17:35:55.391 › Badge.showBadge { sessionExpired: false, mentionCount: 0, showUnreadBadge: false }
17:35:55.392 › TeamDropdownView.updateMentions { expired: {}, mentions: {}, unreads: {} }
@devinbinnie

@pessi-v What is your server URL configured as? Is it exactly https://chat.x.org? Sometimes deviations can cause issues here. I assume there is also no subpath after the URL?

@devinbinnie sigh, that was it. I had configured the server with http://. Changing that to https:// did it. Thanks for the help!


Update metadata parsing for spherex metadata commands

Update LaTeX document parsing to use the new commands provided by the spherex class (https://github.com/SPHEREx/spherex-tex)
Update logo and colors
Display additional document metadata and use badges to display SPHEREx pipeline module metadata, similar to the README template.
Additional integration testing

I'm OK with merging at this point - you've addressed all of my concerns.

Sounds good. Once we get the landing pages into production we can make adjustments for issues that come up.


Lucide Angular does not work with Angular 13 and 14

Version:0.93.0
Are you running from source/main:
Are you using a released build: Yes
Operating system: Mac OS
Bits:

Actual behavior
Lucide Angular does not work with Angular 13 and 14. I tried to import but angular does not see the library.
I have the library installed in my project.

Links
Screenshots

@danielradstrom Can you check if this is fixed. @ekowbaah made some fixes.

@ericfennis I did make the fixes, but the angular build we had was not working and that has been fixed in the last pr but it has not been released yet.
@danielradstrom this should work in the next release.

We released a new version. https://www.npmjs.com/package/lucide-angular

Awesome! works now! Thanks @ekowbaah @ericfennis


New BTP cockpit UI, exposure v2, newer S/4 release

Update of tutorials with newer UIs

Sibylle, can please resolve the conflicts.  You can use the "Resolve conflict" button to do so.  Just remove the unneeded content.

Hi Joshua,
Where do I find the Resolve conflict button. Cannot see it anywhere.
Thanks,
Sibylle
From: Joshua Margo @.>
Sent: Thursday, 28 March 2024 00:40
To: sap-tutorials/Tutorials @.>
Cc: Brehm, Sibylle @.>; Author @.>
Subject: Re: [sap-tutorials/Tutorials] New BTP cockpit UI, exposure v2, newer S/4 release (PR #23500)
Sibylle, can please resolve the conflicts. You can use the "Resolve conflict" button to do so. Just remove the unneeded content.
—
Reply to this email directly, view it on GitHubhttps://github.com/sap-tutorials/Tutorials/pull/23500#issuecomment-2024158525, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEV4LI5HDSPBBV6MVQV3KD3Y2NKF3AVCNFSM6AAAAABFLMW74SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRUGE2TQNJSGU.
You are receiving this because you authored the thread.Message ID: @.***>

New BTP cockpit UI, exposure v2, newer S/4 release by SibylleB * Pull Request #23500 * sap-tutorials/Tutorials (github.com)https://github.com/sap-tutorials/Tutorials/pull/23500
You will need to scroll down past the conversation.
From: Sibylle Brehm @.>
Sent: Thursday, March 28, 2024 1:57 AM
To: sap-tutorials/Tutorials @.>
Cc: Margo, Joshua @.>; Comment @.>
Subject: Re: [sap-tutorials/Tutorials] New BTP cockpit UI, exposure v2, newer S/4 release (PR #23500)
Hi Joshua,
Where do I find the Resolve conflict button. Cannot see it anywhere.
Thanks,
Sibylle
From: Joshua Margo<EMAIL_ADDRESS>Sent: Thursday, 28 March 2024 00:40
To: sap-tutorials/Tutorials<EMAIL_ADDRESS>Cc: Brehm, Sibylle<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [sap-tutorials/Tutorials] New BTP cockpit UI, exposure v2, newer S/4 release (PR #23500)
Sibylle, can please resolve the conflicts. You can use the "Resolve conflict" button to do so. Just remove the unneeded content.

Reply to this email directly, view it on GitHubhttps://github.com/sap-tutorials/Tutorials/pull/23500#issuecomment-2024158525, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEV4LI5HDSPBBV6MVQV3KD3Y2NKF3AVCNFSM6AAAAABFLMW74SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRUGE2TQNJSGU.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Reply to this email directly, view it on GitHubhttps://github.com/sap-tutorials/Tutorials/pull/23500#issuecomment-2024612981, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXMAAXZ4HDFKHV2WLMSPEODY2PEMVAVCNFSM6AAAAABFLMW74SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRUGYYTEOJYGE.
You are receiving this because you commented.Message ID<EMAIL_ADDRESS>


Small optimisations on AboutUs, Footer, Header, CSS

Description:

About Us page:

correction on content colour respecting brand's colours
fix image on left hand side of the content
adjust the image we show just about the About Us content and below NavBar

Footer:

take off the logo
CSS small tweak

Search & Hire:

Show only the options of fleet and date range when end user clicks Search & Hire
Show relevant calendar after user chose in fleet options

Introduce a header above Navbar

Priority:
[High]
Type:
[Bug, MVP Feature, Enhancement]
User story - Current Behaviour:

About Us:
1)fix of bug as end user can't see image on left handside of the content
2)the photo above About Us and below NavBar show the upper side of the image only
3)the content does not follow brand's colours

Footer:

the logo must migrate from footer
CSS will be impacted due to the above

-Search & Hire:

End User sees all calendars!

-Header:
Missing
User Story - Expected Behaviour:

About Us:

Load photo from images on left hand side of the page aka left of the content
The photo above the About Us and below NavBar shows larger part of the image
The content is in line with brand's colours

Footer:

We took away the logo of the brand
Due to the above we made arrangements of CSS to look fine

Header:
Just a thin line with relevant brand colour and naming "Mak-Lift" just above NavBar

Steps to Reproduce:
Be sure you are on branch: optimisations-aboutus-footer-header-search
npm run dev
Browse on About Us
Check footer at the bottom of the page
Browse on Search & Hire
Screenshots:
Not needed
Branch Name:
optimisations-aboutus-footer-header-search
Additional Information:
N/A
Acceptance Criteria:
End User see a polished About Us with homogenous colours and nicely placed images.
Also, the footer end user can find any relevant information about the business in nice format.
On Search & Hire user can choose fleet option, date range and we render the equivalent calendar.
Introduction of a header above the NavBar with brand name of Mak-Lift.
Subtasks:
Will be added later on as further optimisations required on Search & Hire page.
Assignees:

Leading Developer: @nikomakr
Leading QA: @clamadi

Labels:
[bug, enhancement, further development]
Due Date:
[24/01/2024]
Dependencies:
None
Notes for Reviewers:
N/A

Hi @clamadi ,
Can you please QA test this one?
It looks good to me.
Thanks

Hi @nikomakr you can create a PR all looks good according the the above listed


fixing all RGB instances to BGR where needed

There are many places in documentation where we still tell people that opencv reads in RGB images which is simply incorrect. We then slap those same readers with BGR conversion functions at their faces, so I tried to change it all to be identical. These are pure documentation fixes!

@Dikay900 can you help me check if I made no mistake here
@mshabunin is there a way to easily search a specific branch for occurences? The search a repository option on github gives results for master branch and thus it is hard to know which fixes are need in 2.4.

@StevenPuttemans, unfortunately it is not possible to search for code on 2.4 branch using GitHub interface. You need to use local repository clone for this.

Okay thank you! Will probably be a bit harder to find all the instances there then ...

Applied fixes mentioned by @Dikay900

:+1:

:+1:


Log file not closing

Hi
I want to report a bug in a new plesk extension:
its the 'application 'firewall utility (modsecurity)'
after its installed and turned on, if you click on the app link under tools/security
there is a link at the bottom of the page to view the' Log'
but if you click on the log to view it, a pop up windows appears, but that window does never close. only if you exit the plesk panel and log back in to close the last active session
thanks

Hi @doppelt,
I am afraid that this is not the best place to open this issue. I would recommend you to open it under the "Plesk" project as this extension is not built nor maintained by us. Therefore there is no much we can do about it. Hope you understand.


Parser problem + fix

I'm trying to plot a multilayer network using Py3plex. I've created a multiedge file using this setup:
n1 l1 n2 l2 0.4
n1 l3 n3 l1 1

From the file i can assure you:

There are only 2 layers, called l1 and l2.
There are no edges between the two layers

Actually i'm using this code:
from py3plex.visualization.multilayer import *
from py3plex.core import multinet
multilayer_network = multinet.multi_layer_network().load_network("multyL.txt", directed=True, input="multiedgelist")
multilayer_network.basic_stats()
multilayer_network.visualize_network(style="diagonal")
plt.show()

This is the result:

I know that this is wrong. I've done a reverse engineering on the library to find what could be the problem. I've found it was a parse error.
Since i'm using a multi_edgelist i've analized only the method i'm using. In line 141 in ".../py3plex/core/parser.py" there is this method:
def parse_multi_edgelist(input_name,directed):
    if directed:
        G = nx.MultiDiGraph()
    else:
        G = nx.MultiGraph()
    with open(input_name) as IN:
        for line in IN:
            node_first,layer_first,node_second,layer_second,weight = line.strip().split()
            G.add_node((node_first,layer_first),type=layer_first)
            G.add_node((node_second,layer_second),type=layer_second)
            G.add_edge(node_first,node_second,weight=weight)
    return (G,None)

I've tried to rewrite this method multiples times adding a  print(G.nodes(data=True)  to see if I could fix it. I've notice these problems:

self loops: if l1 = l2_ and _n1 = n2 this code below is not working. I think there is a problem when it tries to add a second node ((node_second,layer_second),type=layer_second) since layer_first and layer_second are the same.

G.add_node((node_first,layer_first),type=layer_first)
G.add_node((node_second,layer_second),type=layer_second)
G.add_edge(node_first, node_first, weight=weight)

I think there is a problem when it tries to add a second node
((node_second,layer_second),type=layer_second) since layer_first and layer_second are the
same. In this case the code is trying to do:
G.add_node((n1,l1),type=layer_first)
G.add_node((n1, l1),type=layer_second)

Since n1 = n2 it is trying to add the same node added before with a different type even if the layers are equals.

If l1 = l2_ and _n1 != n2.  I think the problem is always when it tries to add a second node ((node_second,layer_second),type=layer_second) since layer_first and layer_second are the same. In this case the code is trying to do:

G.add_node((n1,l1),type=layer_first)
G.add_node((n2, l1),type=layer_second)

I've modified this method to:
def parse_multi_edgelist(input_name,directed):
    if directed:
        G = nx.MultiDiGraph()
    else:
        G = nx.MultiGraph()
    with open(input_name) as IN:
        for line in IN:
            node_first,layer_first,node_second,layer_second,weight = line.strip().split()
            if layer_first == layer_second and node_first == node_second:
                # first case
                G.add_node((node_first, layer_first), type=layer_first)
            elif layer_first == layer_second and node_first != node_second:
                # second case
                G.add_node((node_first, layer_first), type=layer_first)
                G.add_node((node_second, layer_second), type=layer_first)
                G.add_edge((node_first, layer_first), (node_second, layer_second), weight=weight)
            else:
                #default case
                G.add_node((node_first, layer_first), type=layer_first)
                G.add_node((node_second, layer_second), type=layer_second)
                G.add_edge(node_first, node_second, weight=weight)
    return (G,None)

With my code i've never used the third case yet. So i don't know if there are other cases. This is the correct plot:

There is still a problem: in the first case if you add G.add_edge(node_first, node_first, weight=weight) it plots this:

This is the file i'm using.
multyL.txt

Hello @Snaicol !
Thanks for the extensive report, I see you've more or less solved the problem yourself! I adapted a bit your code and updated the library to a newer version ('0.65), the parser should work OK now.
Your example is now part of https://github.com/SkBlaz/Py3plex/blob/master/examples/example_multilayer_visualization.py
for reproducibility.
I've also fixed the self loop problem, it seems to work fine now (case 1), please report any additional problems!
Thanks!

If this solved the problem, you can close the issue.
Thanks!


Disable comScore analytics while playing video in the background

As a Mediapulse analyst I don't want videos to be tracked when played in the background.
Context
Mediapulse requires videos not to be tracked when < 50% of the video surface is visible. We can identify 3 matching scenarios:

The video is visible but only < 50% of its surface is actually presented on screen (e.g. covered by other views or played in a mini player bar).
The video is played in PiP, whose overlay can be put away by the user.
The video is played in the background (lock screen or app switching).

Due to the nature of the problem we cannot automatically cover several of these use cases:

< 50% area coverage is difficult to address automatically (we cannot really reliably determine how much of a view is visible).
We cannot know when the PiP overlay is visible or not.

We should therefore:

Deal with the cases that can be addressed automatically (app state transitions).
Document how app developers should manually address the other cases, using the available isTracked flag.

Remark
The isTracked flag is greedy and disables all trackers. If finer-grained control is required we should discuss https://github.com/SRGSSR/pillarbox-documentation/issues/38 as well.
Acceptance criteria

Background video playback is not tracked where automatically feasible.
Limitations and manual implementation requirements are documented.

Tasks

[ ] Disable comScore analytics while the application is in background.
[ ] Document required manual implementation inside an app (disabled for < 50% visibility).

Duplicate of #419. Visibility documentation added to #355. Closed.


Deployment

Deployment
User Story
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
Acceptance Criteria
GIVEN a Prework Study Guide website,
WHEN I visit the website using the URL,
THEN I can access my website from any browser

Prework Study Guide successfully deployed to GitHub Pages.


Implement some minor performance optimizations

I tend to benchmark the parser by parsing all of CPython in Ruff. This involves (1) disabling Ruff's linting pass, then (2) running cargo build --release && hyperfine --warmup 10 --runs 50 -i "./target/release/ruff resources/test/cpython --no-cache".
Prior to this change:
Benchmark 1: ./target/release/ruff resources/test/cpython --no-cache
  Time (mean ± σ):     265.2 ms ±   4.6 ms    [User: 2260.7 ms, System: 83.1 ms]
  Range (min … max):   259.0 ms … 281.1 ms    50 runs

Benchmark 1: ./target/release/ruff resources/test/cpython --no-cache
  Time (mean ± σ):     268.4 ms ±   4.2 ms    [User: 2268.1 ms, System: 83.5 ms]
  Range (min … max):   262.5 ms … 283.6 ms    50 runs

Benchmark 1: ./target/release/ruff resources/test/cpython --no-cache
  Time (mean ± σ):     269.7 ms ±   5.5 ms    [User: 2277.9 ms, System: 83.5 ms]
  Range (min … max):   260.1 ms … 280.7 ms    50 runs

After this change:
Benchmark 1: ./target/release/ruff resources/test/cpython --no-cache
  Time (mean ± σ):     255.6 ms ±   5.1 ms    [User: 2156.0 ms, System: 83.4 ms]
  Range (min … max):   247.2 ms … 271.8 ms    50 runs

Benchmark 1: ./target/release/ruff resources/test/cpython --no-cache
  Time (mean ± σ):     255.4 ms ±   4.8 ms    [User: 2152.8 ms, System: 83.0 ms]
  Range (min … max):   246.9 ms … 269.7 ms    50 runs

Benchmark 1: ./target/release/ruff resources/test/cpython --no-cache
  Time (mean ± σ):     256.3 ms ±   4.8 ms    [User: 2156.3 ms, System: 82.8 ms]
  Range (min … max):   248.5 ms … 270.6 ms    50 runs

So it's a ~4.8% improvement, if you take the median results.
Note that there's about ~58ms of overhead associated with this benchmark (e.g., to locate all the Python files on-disk, read their contents, etc.), so that's really a lower-bound on improvement.

@coolreader18 - Definitely! We've used it from the very beginnings of Ruff. I've tried to contribute back as many compatibility improvements as I can :)


rework aardvark setup

Based on #369
The driver already has all information so the aardvark code should not
have to pass it again. This simplifies the code and creates smaller
aardvark config files since it does not duplicate the contianer id and
names just to set more then one ip.
This does not touch the aardvark teardown logic.
Requires https://github.com/containers/aardvark-dns/pull/183

LGTM on my end - looks like an overall simplification of the code, and seems more logical.

lets get this in ... @flouthoc were you able to verify?

ah i missed manually verifying this with podman integration my bad but lets get this in cause i think @Luap99 already did so, @Luap99 could you rebase since some new aardvark changes went in and it would be nice to rerun CI with latest aardvark and lets merge this.


Report missing keys

Add support for throwing an exception if a key referenced by a template is not found. This is useful for clients that want to ensure templates and the related input data structure match and want to handle potential mismatches as failures.
P.S. I also rebased the patches against torbjoernk/mstch branch develop and pushed to the branch torbjoernk/report-missing-keys as some of the other open pull requests have been merged there.

Ignoring the code (although it looks fine to me), I'm +1 on this feature.


Add new mesos 1.0 capability flags

This will add support for Mesos 1.0's new features, like GPU tasks.
Could you please release a new version as well? Thank you!

thanks, will release soonish

@dgrnbrg the release is out, cheers.


Updated scaleio tests

This commit updates the scaleio test package.

[Current coverage][cc-pull] is 42.90%

Merging [#96][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master        #96   diff @@
==========================================
  Files            21         21
  Lines          1529       1529
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            656        656
  Misses          824        824
  Partials         49         49

Powered by Codecov. Last updated by [a0eab5c...c68e27f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/emccode/libstorage/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/emccode/libstorage/compare/a0eab5c2b2c7172dc16aa6b009c5419315056613...c68e27fbf3f3da8ce5843fb9a4428efd9e737bf2
[cc-pull]: https://codecov.io/gh/emccode/libstorage/pull/96?src=pr


Syntax Highlighting bugs

When using string formatting constructs like %[1]s instead of %s, syntax highlighting is broken:

If the method is defined all on one line, highlighting for the method name works fine but things like primitive types (string, map, etc) are not highlighted correctly:

If there is a newline in the method definition, the name is not highlighted correctly, but the primitive types are:

With a leading type that is a func, I do not get the correct syntax highlighting on the type or the following method func or name:

With a leading function definition that is not finished, I get correct highlighting on the method func and name, but not on the type or the func in the typedef:

With the leading function braces closed, I get the same results as with no leading function:

The syntax highlighting should be converted to use Sublime's new syntax format, and we should scrap the tmLanguage stuff.

Somehow it looks like you should support it already unless I am not understanding that regex correctly.

@stevekuznetsov would you mind moving #70 and #71 into this issue and then closing them? I like your idea to have a single syntax issue.

@ironcladlou Should have done that from the outset. my bad!

Pushed this upstream


feat: Define a new lint script

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.

I have placed this PR under a WIP as I would like to consolidate everything in to the project root, and have prettier working correctly. Currently ESlint is throwing in react files, which is just silly.

@ValeraS The idea is to implement prettier in some form after this PR. Should I just implement it now? Seeing as i am already touching a lot of files.

Now with prettier-eslint

@Bouncey @raisedadead could you look at https://github.com/ValeraS/freeCodeCamp/commits/feat/prettier
with this use of the prettier, I see only the one main difference from our rules (wrap-regex). What do you think, can we use it as the prettier suggests?

I have merged your changes in to this PR @ValeraS
Thank you


TabModel.requestRefresh does not handle a userInitiated flag

AppModel.requestRefresh takes an argument 'userInitiated' which indicates whether the user asked for the refresh (or if was generated by an auto-refresh tiimer.).  this can be used by actual implementations to determine whether to visibly throw an exception or silently fail.
Unfortunately, this is not handled by TabModel.requestRefresh.
Seems like one implementation would be for the visible tab to be refreshed with the userInitiated flag passed to it, so that it could silently fail in the case of a failed autoRefresh.  However, hidden tabs that were refreshed only when made visible would always have userInitiatedFlag fixed to true.  This is because presumably it was a user action that made the tab visible, so user would expect the popup, and would not be surprised by it.

Fixed with new Refresh Architecture in 19.x


Fix image vulnerabilities

Fix #75

Should be merged after https://github.com/open-horizon/vault-exchange-auth/pull/78

@bencourliss I recall that vault version we are locked for is v1.14.9?

We're locked to the minor version. So any patch of 1.14 is fine.


Player callbacks hooking in include

Attempt to hook the necessary player callbacks, mentioned here, in the include. This way it doesn't matter if people forget to declare the player callbacks. Not declaring these callbacks can lead to strange behaviour.

Agreed. I don't know why I didn't think of this before.

Since the return values of of the SA-MP player functions (except the streaming ones) do different things, we should take this into account. So maybe something like this:
public OnPlayerTakeDamage(...) {
	new ret = 0;
	#if defined FCNPC_OnPlayerTakeDamage
		ret = FCNPC_OnPlayerTakeDamage(...);
	#endif
	return ret;
}
//Remaining hooking code

Extra comment as a reminder that the readme and wiki should be updated when this is implemented.

No need to complicate with returning values and adding additional layer...
#if !defined FCNPC_OnPlayerTakeDamage
FCNPC_OnPlayerTakeDamage {\
    return 1;\
}
#endif

I think what this is done, but I can be wrong.


Chained Controllers Example: Forwarding-Chained controllers.

this PR is only for exemplary purposes to enable demonstration of chained controllers.

We have a demo now in the demos, see https://github.com/ros-controls/ros2_control_demos/pull/318
Is there anything more inside this PR, or can we close it?


ERROR: UpdateManager.ActionAsync Getting new update failed with error

How To Reproduce?
launch wasabi
see error
doesn't matter if auto download new version is enabled or disabled
Operating System
deb12
Logs

[9] ERROR	UpdateManager.ActionAsync (85)	Getting new update failed with error. Exception: System.InvalidOperationException: For Linux, get the correct update manually.
   at WalletWasabi.Services.UpdateManager.GetAssetToDownload(List`1 assetDownloadURLs) in WalletWasabi/Services/UpdateManager.cs:line 271
   at WalletWasabi.Services.UpdateManager.GetLatestReleaseFromGithubAsync(CancellationToken cancellationToken) in WalletWasabi/Services/UpdateManager.cs:line 203
   at WalletWasabi.Services.UpdateManager.ActionAsync(CancellationToken cancellationToken) in WalletWasabi/Services/UpdateManager.cs:line 53

Wasabi Version
ed5639fb0f438222db5ddb766bf3630c14c98ca4

don't shoot the messenger.
I didn't do anything, just watched the logs🤣


Guidebook entries for playable races.

About the PR
Added new guidebook entries for each race (because this wasn't already in for some reason)
Why / Balance
Do you really want newbies to scout the wiki to find out why their slime is suffocation with their starter oxygen tank? Me neither.
Technical details
Nothing game breaking.
Media
In due time

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
None
Changelog

You may now find information about your own body in the in-game guidebook.

:cl:

add: A guidebook entry explaining key mechanics for each race.

 Opening another.

It is done but my client is crashing when opening any menu. So i can't test it properly yet.


Broadcast max altitude after apogee

Description of Problem
Adding print after apogee is reached with altitude point which apogee was reached with.
Solution
added print after apogee is detected
Testing
Compiled correctly

closing stale PR


Satellite builder not working as expected

Hi it's me again^^
i have maybe encountered another issue.
I tried build an satellite.
I placed an empty satellite and some items as shown in the screenshot at the bottom.
I clicked on build and it seemed that nothing is happening.
But after some moments i got an satellite with an id ID0.
But i didn't get another chip with the id ID0 for the terminal.
I tried to copy it from the satellite but all attempts failed.
Getting the finished satellite back to the satellite builder was also a bit trickty.
I figured out that i first have to try to insert the satellite (but nothing happens here) and then add a satellite chip (in this case an unprogrammed). Afterwards i click on the satellite (at my inventar again) and then it places itself at the satellite slot of the satellite builder (without doing any drag and drop).
I worked with this documentation about building satellites:
http://<IP_ADDRESS>:8000/AdvancedRocketry/blocks/SatelliteAssemblingMachine.php
And here is the screenshot of the current setup:
http://mc.aaronegger.de/sc5.png
Server Infos: https://gist.github.com/aaronegger/02bd341a85a8573076d69e7a8684bb90
Did i miss something or is that a bug?
I missed it to thank you for this mod!
I like it very much how you realized the concept of building individual rockets.
There are a lot of good ideas that should be implemented in vanilla minecraft!
Like multiblock machines and the holo projector!
Keep up the good work :)

It looks like you placed the main components in the first 2 power slots, the optical sensor/mass sensor/etc should be in the Main Component slot ( you can only have 1 per satellite).  Though you shouldn't have been able to get a satellite with ID 0.  That's likely also why you were unable to copy it.

I now understand how building satellites really work.
At the moment i can't confirm if building satellites now really work in Version 1.2.2, because i downgraded to 1.2.1.
But i can confirm that building satellites work in 1.2.1.

I think all in all it was my failure. Therefore i close this issue.


Unable to pass moz:firefoxOptions to GeckoDriver, needed for Firefox headless

The current version of Firefox (55) supports headless mode. Currently I have only been able to get this working with a workaround.
The issue is that the contents of moz:firefoxOptions does not get passed to GeckoDriver.
Config:
// See: https://github.com/mozilla/geckodriver
// Note: I am using a manually started Selenium Standalone, because both directConnect and automatically starting Selenium Standalone seem to have issues with GeckoDriver.
{
    capabilities: {
        'browserName': 'firefox',
        'seleniumAddress': 'http://localhost:4444/wd/hub',
        'acceptInsecureCerts': true,
        'moz:firefoxOptions': {
            args: ['--headless']
        }
    }
}

However, in the capabilities passed to Selenium Standalone, the moz:firefoxOptions seem to have disappeared. Firefox does run correctly, but in GUI mode:
11:38:40.688 INFO - Found handler: org.openqa.selenium.remote.server.BeginSession@7d9cd404
11:38:40.690 INFO - /session: Executing POST on /session (handler: BeginSession)
11:38:40.708 INFO - Capabilities are: Capabilities {acceptInsecureCerts=true, count=1.0, browserName=firefox, maxInstances=1.0, moz:firefoxOptions={}, shardTestFiles=false, seleniumAddress=http://localhost:4444/wd/hub, }

Workaround for using headless mode: start Selenium Standalone with the MOZ_HEADLESS environment variable:
MOZ_HEADLESS=1 webdriver-manager start

Where do the moz:firefoxOptions get lost? Is it in Protractor? Or in one of the other components? If so, which component?

With the latest version of Protractor (5.2.0) this issue no longer occurs.


remove all mentions of tactics key

About the PR
previously added in my previous PR; based off memory off a much older version of CM; this no longer exists and would just like to clarify my mistake before proceeding with other PR's :)

que? where's the merge conflict ;(

git genius, merge conflict solved


Only one callback function

in project i have 12 pages with cca 150 buttons where many buttons has same functionality
now i have to create many NexText and NexButton object and create callback function with parameter "void *ptr" for each object
maybe would be better have only one callback function with parameter "NexObject *ptr"

You can have a common function handle multiple buttons.  This is why there is the void pointer.

is possible somehow check pid in callback function?

Hey folks, it's possible - overwrite notification event with your own code.

In Nextion Editor select element and uncheck "Send Component ID" - this will disable event firing to arduino.
fire your own event, by adding command - "printh 65 01 01 00 ff ff ff"  so now you have event on page id 1 and element id 1. you can put any values of page ID and element ID    on this string. Nextion event handler will eat it and try to search for callback for this IDs.
Define single callback function like
NexTouch bSaveConfig = NexTouch(1, 1, ""); //this is hardcoded pageId and elementId in click events of all save config buttons

Enjoy.


Bare metal troubleshooting in wrong place

The bare metal header was on the wrong place. The section in the middle should be general troubleshooting.

/cherry-pick release-0.12

/lgtm


feat: add stackables interface for platformatic stackables

The code in this PR are not finalized and probably will be in different packages. It's just for demonstration purposes.

The runtime is still depends on platformatic specific stackables (mostly in places where it overrides configs), but I think I reached the point where this PR can be merged to unblock @ShogunPanda. After your review, of course.
I created issues for the next refactoring steps: #2924 #2925

I think you need to add
https://github.com/platformatic/platformatic/blob/17be2d1fe59d274f3426a99c07fe0ea832f59d71/packages/config/index.d.ts#L72
.

I decided to not attach the buldStackable function to the current stackable fastify plugin and just export it from a stackable module for now.


Fixes #102, fixes #103 -- FLW status and identification

There are two small todos on #103 pending clarification on "mandatory" location fields and spec for "FLW Designation". I'll open another ticket for those in sprint 3 because we probably won't get clarification in time for sprint 2.

lgtm
assertTrue(a == b) => assertEquals(a, b)


Move variable declarations to top of blocks

This makes the project compile successfully
when -Wdeclaration-after-statement is enabled.

Why do you need to enable that warning (which shouldn't be causing the build to fail anyway)? It's only relevant for C90 compatibility.

A project I'm participating in uses GLFW and compiles both for win32 and Linux. To be backwards compatible as far back as is possible (to Windows XP?) the win32 port is normally compiled with an old versions of MSVC (2005 I believe). Due to us Linux developers unknowingly causing issues with declarations midway through functions (as gcc does not usually complain about this) we conciously enabled -Wdeclaration-after-statement for all the code in the project. Most of GLFW compiled without warnings (this is expected as the same code is also used in the win32 port), the warnings were limited to the changed three files. It would be nice to avoid the warnings completely as this allows us to consistenly compile with this flag enabled and not cause issues for users of older MSVC 2005 compiles by accident.

I would actually like to change the other way for Linux-only backends.  On Linux we are lucky enough to not have to support MSVC’s legacy, and block-scoped variables help prevent common errors such as reusing a variable after the end of the block, or simply human understanding.

Ok, so you are suggesting adding more blocks and thus new scopes to the source instead? That might would resolve the issue as well. Let me try that out.

I attempted to just do a naïve implementation and while it silences the compiler warnings I'm not sure the commitdiff nor the resulting code looks more appealing…

I'm sorry; I won't merge this.
C99 declarations is a lot to give up, especially on intermediate-heavy Cocoa, and having to maintain strict C89 discipline across the project for years to come until we drop support for VS 2010 and 2012 is a lot to ask to avoid making a compiler flag special case.

Just so I understand you clearly. :)
The project where we use GLFW is MuPDF, and since MuPDF is built for Windows using VS2005 to keep support for Windows XP onwards (we try to keep that). VS2005 complains if variables are not declared at the top of blocks.
But what you are arguing is that is not worth staying with C89 for GLFW, because you only support VS2010 onwards and C99 has a few features you like to use? So I imagine both the original patch (faa784de) and the currently proposed patch (2a23666e) are not acceptable?

especially on intermediate-heavy Cocoa

I'm not sure I understand what you mean by this..? Care to explain a bit more? I'm not arguing against you, but even if you decide not to take either of the patches on I'd still like to understand the underlying reasons. Thanks you! :)

Visual Studio have a toolset which generate Windows XP compatible binaries. For 2015 it is v140_xp. We are using it in all games we releaseing.

VS2005 complains if variables are not declared at the top of blocks.

So does VS 2010, which we support. Any GLFW code that will compile on VS is already strict about declaring variables at the top of blocks. That includes win32_*, wgl_*, egl_*, osmesa_* and files without an underscore. Your patch is about extending that restriction to other platforms where system compilers all support intermingled (C99 style) declarations.
I'm arguing that introducing and maintaining this restriction for all GLFW code for years to come is disproportionately more work than making a special case in your build system so the -Wdeclaration-after-statement flag isn't applied to all GLFW code.
I agree that applying this flag to your application code is a good idea for the reason you stated (and I should apply it to the Windows-relevant parts of GLFW for the same reason), but it should be possible for you to apply it to your code without also applying it to all your dependencies. Also, if you want the flag applied to GLFW because you are maintaining your own local modifications of it then my adding the flag selectively via CMake should help with that bit as well.

especially on intermediate-heavy Cocoa

I'm not sure I understand what you mean by this..? Care to explain a bit more?

Most APIs on macOS are fairly verbose and either OO Objective-C or OO-style C. It's common that you need to store intermediate values in long fetch sequences, either to use them directly later on or to break up what would otherwise be lines hundreds of characters long and nested in ways that are difficult to line-break clearly.
However, I see that your patch doesn't touch the macOS code so perhaps that's irrelevant.

The flag has (mostly) been added with e27dc50689885736b0b79fde22c9d24046264f96.


Restructured the project and added in GUI files

GUI for different lessons are still empty for now. Add in later.

No functions to link different lessons yet. Add in later.


Performance interface returns any instead of actual types

https://developer.mozilla.org/en-US/docs/Web/API/Performance
For example, getEntries(): any; should be getEntries(): PerformanceEntry

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.


Rename 'config' directories to 'config-template' in all packages

This action can help some people understand that we store not configs in packages, but templates for them.

I think that's an overkill. We can just mention it in the package readme and the guide.


"No text channels" part is not colorized

Thanks for reporting it, I'll fix it when I can

Should be colorized now ! :3

Not working, but I see why.

why ? ^^

https://github.com/NYRI4/Discolored/pull/5

Should be working now, thanks for your participation !

Thanks, it's still not yet fixed on support/discolored.user.css.

There, sorry smh


Update README.md

Made grammatical corrections and improved sentence structure throughout the README file.

cloud native and open source shouldn't have a -
https://github.com/cncf/foundation/blob/main/style-guide.md#1-cloud-native-and-open-source

cloud native and open source shouldn't have a -
https://github.com/cncf/foundation/blob/main/style-guide.md#1-cloud-native-and-open-source

I understand your point correctly, could you please provide some additional context or specific details about the issue you're addressing? I want to make sure I address your concerns appropriately and align with the recommended guidelines.
Thank you

Please don't add the hyphen in those words


ABC transporters

Hello,
You may recall that a couple of years ago I requested
some changes be made to the transporter ontology in
regard to the ABC transporters. Since then, a
SourceForge ticket was opened which indicated work was
underway to revamp the whole transporter ontology.  My
tickets and requests were attached to this.  I have
heard nothing on this for a long time and the issues I
(and my teammates) have with the ABC transporters are
becoming rather pressing so I've decided to raise the
issue again.
First let me lay out the problem.  There is a lot of
ambiquity in the current ABC transporter terms.  The
parent to all the ABC transporters (ATP-binding
cassette (ABC) transporter activity, GO:0004009) is not
defined, nor are its three children.  However, its
grandchildren usually are defined.  In the case of the
"ABC-type uptake permeases" these definitions are of
the nature "ATP + H2O + substrate(out) -> ADP +
phosphate + substrate(in)".  This definition implys the
functioning of the entire ABC transporter complex -
three proteins that must work together to achieve the
net result that the definition describes.  In ABC
uptake transporters, there is a membrane bound
permease, a membrane associated ATP-binding protein,
and a periplasmic (or membrane anchored, in Gram +)
substrate binding protein.  All three are required for
a functional ABC transporter to uptake metabolites.
However, the names of the specific children of
"ABC-type uptake permease" have names like "amino
acid-transporting ATPase activity" which implies only
the function of the ATP-binding protein and is
inconsistent as a child of "ABC-type uptake permease"
which implies only the permease function.
After discussion with other TIGR microbial annotators
it seems there are two options available to make the
ABC transporter terms more clear.
Option 1:  Define the parent and grandparent terms and
change the wording of all the terms to indicate that
they represent the function of the entire complex, not
just one component.  For example, change "amino
acid-transporting ATPase activity" to something along
the lines of "amino acid ABC-type uptake transporter".
We may also want to add children of each substrate
specific term that are the three different components -
or not, I'm not sure.
Option 2:  Obsolete all of the ABC transporter function
terms.  Create  ABC transporter component terms, for
example:  "ABC-type uptake transporter" - defined as "A
complex for the transport of metabolites into the cell,
comprised of a permease integral to the plasma
membrane, a membrane associated ATP-binding protein,
and a periplasmic (in Gram-negative organims) or
membrane anchored (in Gram-positive organisms)
substrate-binding protein."   Then annotations for
genes in these transporters could be annotated to the
new component term, and to substrate specific generic
transporter terms like "amino acid transport" and
"amino acid transporter".   They would also be
annotated to other terms to indicate which component
they are, for example:  "ATP-binding" or "integral to
plasma membrane" or "external side of plasma membrane"
or "periplasmic space" or "amino acid-binding".  (Some
genes would get more than one of these.)
I think I favor option #2 since, I think, GO does not
represent the functions of complexes as separate from
the same function carried out by a single protein.
Therefore, the net function is the same whether it is
one protein or three and the fact that it is three
should be reflected in component, not function.
Thanks,
Michelle
Reported by: mlgwinn
Original Ticket: "geneontology/ontology-requests/1656":https://sourceforge.net/p/geneontology/ontology-requests/1656

thanks www.movied.org


Key path and security groups

Hi guys, great resource and thanks for sharing.
A couple of points that I came across while using the tool that could be clearer in the docs:

the PATH_TO_KEY variable is the directory containing the key file, not the full path to the key file itself

the security group set as MASTER_SECURITY_GROUP must have SSH access (port 22) from the machine running the script otherwise the script fails to log in to the master to execute the post-EMR installation

I found installing awscli as instructed in the root environment on my Mac clashed with my existing python2 awscli setup. To avoid this I installed python3 using brew as instructed, then used a virtualenv to install the subsequent libraries and tools:

virtualenv -p python3 hail-spot
cd hail-spot/
source bin/activate
pip3 install --upgrade pip
pip3 install boto3 pandas botocore paramiko pyyaml nose tornado
pip3 install awscli
git clone https://github.com/hms-dbmi/hail-on-AWS-spot-instances
...etc...

Hi @willmclaren,

Correct, PATH_TO_KEY is the path to the directory. I added a note in the .yaml file to avoid ambiguity.

Yes, the MASTER_SECURITY_GROUP needs to have port 22 open. That's why I added reference to this link: https://docs.aws.amazon.com/emr/latest/ManagementGuide/emr-security-groups.html but it doesn't hurt to explicitly say that

Exactly, as stated at the beginning of the Software requirements section you need Python3  but if you use pip3 you shouldn't expect any issues but definitely the best way to avoid clashing between versions is to use a virtualenv for one or the other.

Thank you for the feedback and the comments. I'm closing this thread. BTW I just got a notification about open issues just yesterday.


Graph Text Color

Graph text color doesn't reset back to black/original text color when uncheck contrast.

This is how it is supposed to work. We want to guarantee that the graph labels are readable, so we do not include the choice for them to not contrast with the background.

So the thing is, when without contract and the graph background is changed to black, the text will stay black. If the contrast in checked the color with change.
By unchecking the check box I was thinking that the text might go back to black/the original color. Otherwise, there isn't a point to uncheck the contrast since it'd stay the contrast color after it's enabled.

A better example might be a red background color with original/black text. I check the contrast and the text color turned into white, but I want the original black text color so I would uncheck the contrast, but then nothing happens.

At first, unchecking the contrast will return the graph text color to original. (After the second change of background color, the text color stays contrasted even if the contrast is disabled.) >> At least that's what I thought at first, but it seems it just changes text color somehow when the background is changed even though the contrast is disabled.
For example, background is black and contrast disabled, the text is black. Enable contrast, text turns white. Disable contrast again, text turns black (original color). Change background to red as contrast stays disabled, text turns white, which should stay black (original color) instead.
To summarize, when contrast is enabled once, (even when background wasn't changed at first), then disabled, the text color changes while the background color changes. Text color doesn't always change with the change in background color, and it doesn't seem to change by contrast of background color either.

Is the last commit supposed to make it so the graph background and text color are contrasted even though the "High Contrast" is not checked? On Safari, Chrome, and Firefox, that's what is happening so far.

Yeah, it seemed counterintuitive to allow the labels to be unreadable.

Then I guess the High Contrast should be changed to checked at all times and can't be unchecked by user.

I've disabled the checkbox and set it as checked. Also, the related codes for graphConstrast, in the reset.js, is commented out for now.


Use Save file as actual/additional data source for a map

You could check this code: https://github.com/Goz3rr/SatisfactorySaveEditor, there is a C# library for loading game's Save file. Shouldn't be hard to convert it into JS and use here as a data source.
It's pretty easy to get from there locations of resources (and info if those are used, built on), or objects like Slugs or Drop pods, along with info if those are taken/used or not yet.
This would greatly improve the map usability - Could instantly see not only where I am, but also where are stuff I didn't take yet.

Hi ! We already know this repo :)
We have our own file parser with more advanced functionality than the Goz3r parser, such as being able to recover all the collected objects, to associate EPIC ids to each player in the save, to recognize the host among these players etc (j have already contacted Goz3r a few days ago for collected items)
You should check are roadmap on trello : https://trello.com/b/Pz8tj1OX/roadmap-for-satisfactory-map

Oh I checked here only, alright then, keep up the good work! :)

Thank you :) Closed


Windows 7 and up like taskbar grouping

Regarding grouping, the method Cairo uses I mentioned in #53. However, thumbnails are a great idea!

I know, but it would be nice to have that options too, besides The Windows 7 taskbar has been praised by many of its users, also flexibility :)

Here are my notes from previous brainstorming on the combined quick launch + task list implementation.
For categorizing windows by app:

Windows 7 and up use AppUserModelID (AUMID) to uniquely identify applications on the system. This is required to properly categorize windows by application. Cairo already gets the explicit AUMID for apps, but not yet the implicit AUMID assigned to apps that don't explicitly define one. It may make sense to implement this in ManagedShell.WindowsTasks.ApplicationWindow. Getting it on Windows 7 requires injection into the process and calling GetCurrentProcessExplicitAppUserModelID, which sounds unsavory. This Win32 API can be used to get it on Windows 8 and up.
A new TaskCategoryProvider will need to be created for categorizing taskbar windows by app. The App Grabber category-based TaskCategoryProvider implementation is here as an example.
A setting needs to be created for switching between the TaskCategoryProviders.
This can be implemented independently from the combined list below.

For combining taskbar windows with quick launch icons:

I haven't thought this through completely yet, so the following are high-level thoughts of a potential way forward.
Quick launch, task list, and combined quick launch + task list should all likely be separate controls, to mesh with future customization plans.
The controls used in the taskbar need to be configurable by a separate setting.
A data model is needed for the combined quick launch (ApplicationInfo objects from AppGrabber) and task list (ApplicationWindow objects from ManagedShell.WindowsTasks) collection.
ApplicationInfo and ApplicationWindow objects will need a way to relate to each other. Is there a way to get the AUMID for the non-UWP apps stored in AppGrabber?
The new combined quick launch+task list control will need to use the new data model as its data source and display a QuickLaunchButton or a TaskButton depending on the item.
The new control will need to show a single taskbar item for a category, with the individual windows listed in the TaskThumbWindow.
TaskThumbWindow needs to be refactored so that it can show multiple windows.

Available in the latest release!


Live Demo throws AttributeError immediately after login

The live demo throws an AttributeError directly after login before doing/showing anything. This occurs even in a fresh Incognito mode session.
https://accounting.imacat.idv.tw/accounting/cash/0/2021-07
AttributeError at /accounting/cash/0/2021-07
'NoneType' object has no attribute 'code'
Request Method:	GET
Request URL:	https://accounting.imacat.idv.tw/accounting/cash/0/2021-07
Django Version:	3.1.6
Exception Type:	AttributeError
Exception Value:
'NoneType' object has no attribute 'code'
Exception Location:	./accounting/converters.py, line 215, in to_url
Error during template rendering
In template /srv/www/accounting/accounting/templates/accounting/include/report-chooser.html, error at line 75

Thanks for reporting.  Sorry I did not notice your report.
The demo site is working now, besides the Django admin login page.  That page is generated by Django.  I have no idea why it is broken.
Also the demo site is moved to https://accounting-django.imacat.idv.tw.  It is going to be retired and replaced with a new Flask release at https://accounting.imacat.idv.tw.


Snippets defaulting to include DB Name makes it very inconvenient to do ad-hoc development

SQL Operations Studio Version: master

Steps to Reproduce:

Open a new query window for a database, let's call it MyLongWindedDatabaseName
Type in sqlCreateTable and add the snippet
Observe that you have to include the database name and it's quite hard to do so

I understand this was an acceptance of a community PR, but to my mind this tips the balance between "I can easily get my job done as a dev" and "I can write something that works for DBAs". The old way was mildly inconvenient for people who liked to include the DB name in all scripts, but now it's very inconvenient for ad-hoc developers (of which I'm one).
Proposed solution: Add sqlcreateTableWithDb snippet that does include DB name, but leave the existing ones as-is. This would mean that most snippets "just work" without needing to figure out the DB name.
Code snippet:
-- Create a new table called '[TableName]' in schema '[SchemaName]' in database '[DatabaseName]'
-- Drop the table if it already exists
IF OBJECT_ID('[DatabaseName].[SchemaName].[TableName]', 'U') IS NOT NULL
DROP TABLE [DatabaseName].[SchemaName].[TableName]
GO
-- Create the table in the specified database and schema
CREATE TABLE [DatabaseName].[SchemaName].[TableName]
(
    [ColumnName]Id INT NOT NULL PRIMARY KEY, -- Primary Key column
    [ColumnName1] [NVARCHAR](50) NOT NULL,
    [ColumnName2] [NVARCHAR](50) NOT NULL
    -- Specify more columns here
);
GO

@yualan  I think this a good opportunity to collect community feedback and see what works best for most people.  It appears any solution isn't going to be what everyone wants, though, of course users can add and customize their own snippets if they don't like the defaults.


Add spec for commands

Figure out how to simulate pressing a key instead of triggering a specific command (ie, tab vs markdown:indent-list-item). The current spec only tests whether the commands work, but not if they break any fallback/default behavior.
[x] A tab-width of 2, and soft-tabs are assumed
Add full specs for:

[x] markdown:indent-list-item
[x] markdown:outdent-list-item
[x] markdown:toggle-task

I've scratched the "simulate key presses" item, because I haven't been able to (reasonably quickly) find any evidence that Atom tests for this itself. I've even stumbled on a mention on StackOverflow that this might go against a security principle of browsers, so perhaps it is not even possible. I have left the idea as a TODO in the source.


Ship tests outside package

Move tests outside

Fixes #466
@shreyasbapat

@shreyasbapat

@ritzvik

@anish29292 You need to have some patience in order to contribute. I will review this today.

First I will ask you to configure your local git client and redo the commit. git reset will be useful in doing this.

Is this being worked upon?

The PR seems inactive. Closing this one.


[SPARK-12248][CORE] Adds memory / heap limits per cpu for mesos coarse

Add spark.cores.mb.min for minimum memory per core
Add spark.cores.mb.max for max memory per core
Modifies the behavior of the coarse executor to now account for an overhead, and assign heap related to total memory available minus the overhead

Tested and it works great


Fix NOTIFY code

Identifiers cannot contain dashes:
Query 1 ERROR at Line 1: : ERROR:  syntax error at or near "-"
LINE 1: NOTIFY mainnet-foo '$block_num,$a,$b'

If an identifier contain dash, it must be quoted:
NOTIFY "mainnet-foo", '$block_num,$a,$b'

Missing comma was also added.

Thank you. Fixed in 3339f96b83abb3e71c13fd2fff718f09b7c8bc6c


 Please pull the recent changes and edit your PR.
Also read the CONTRIBUTING.md for the PR title and description.


It is deprecated to specify guide = FALSE to remove a guide. Please use guide = "none" instead.

Getting this all over since recent update

Most changes in place, just need to verify

Fixed


Fixed types for renderHeader

Pretty straightforward fix for typescript.

Can you take a look at this @cbbfcd

Can you take a look at this @cbbfcd

@tobiastornros LGTM~ thanks very much


New Feature : Food Showcase Section

Hi, I want to add a new Section related to food show.
Something like this.
https://github.com/khushi-joshi-05/Food-ordering-website/assets/125960660/6a09e3e0-c834-4f43-a02b-f984a0f8acd8
If i have your permission, Can I please try?
if yes, please assign it to me under GSSoC'24

I worked on it before generating the issue. So that i can be sure of able to implement this feature
Here's a PR for the same.
https://github.com/khushi-joshi-05/Food-ordering-website/pull/219
Please consider merging PR

@khushi-joshi-05 Please Assign under label GSSoC'24. I dont know if the points will be counted without it so to be safe.

@mohitrajjha111 that issue is already merged and i have also labeled it under gssoc and level1.

@sunny0625 Please assign this to me and add appropiate labels. Its PR has been closed but it was still not assigned and labelled. Please do same. Thank you


Document the chain spec format

@tomaka the protocol id, will that be deprecated after everything uses the genesis hash?

@tomaka the protocol id, will that be deprecated after everything uses the genesis hash?

Yeah, but of course this isn't done yet


Single service principal for local dev, provisioning, and ci deployment of containers

Service principal management is expensive and a security risk. I would like to create 1 service principal while in my developer loop. Create it locally, save the JSON output, use the Id within the provisioning so the same service principal has access to the resources, then use it again for deploying.
Or alternatively, get the service principal JSON including the password after azd creates it.
Since all my services are running in containers, and the SDK code uses DefaultAzureCredential, I need the service principal at the time I start the container locally, in cicd, or on Azure.
AZD handles the CICD and Azure but how do I manage local container development with service principals if azd creates the service principal?

/unresolve


DownloadDistmapResult does not handle correctly PG in records

As described by @robmaz in https://github.com/magicDGS/ReadTools/issues/394#issuecomment-361954765, while downloading files with PG tags included in the records but removing the header lines, the tag is maintained and thus is breaking the output file.
This was not picked before because the bwa test files does not include the tag in the records, but for example novoalign does. This should be fixed and a text included, doing a point-release for the fix.

Thanks for the data, it was so useful for adding the tests.


[MINOR:TYPO] Update README.rst

replaces all occurrences of topicnaming with toponymy
fixes the forking link

Thanks. We are definitely very much in a state of flux right now, so things like this are appreciated.


SelectiveStructColumnReader::filterRowGroups() return duplicate RowGroup Ids

SelectiveStructColumnReader::filterRowGroups() go over the stats column by column, and merge the RowGroup Ids to be skipped from each column to the final strideToSkip_. This could produce many duplicates in the list. For example, a table has 3 columns, and all columns returns a list of {0, 1, 2, ... 9}, then the final strideToSkip_ became {0, 0, 0, 1, 1, 1,....9,9,9}. This is not only inefficient for later processing since the list will be searched linearly, but also the stats matching was inefficient. If column 0 fails the filter for its RowGroup 0, then the later columns do not need to be matched for the same RowGroup. Dwrf's RowGroup layout is different from Parquet, but it does not matter. The above still holds.

Related issue https://github.com/facebookincubator/velox/issues/2329
I'm working on a fix. Assigning to myself.

This bug is DWRF only and does not affect the correctness. To fix it, it requires some refactoring and needs to be thought over. I will defer the fix to later. Unassigning me for now.

cc @oerling


Update README.md

Insert description of PR here

✅ By submitting this PR, I have verified the following

[] Checked to see if a similar PR has already been opened 🤔
[] Reviewed the contributing guidelines 🔍
[] Added my name to the bottom of the list under the Credits section in the README.md with a link to my website or GitHub profile 👥

Added O4U Technology conference.  They sponsor all-expenses paid trips to their conferences for LGBT+ undergrad students.  It's a good time :)

Looks amazing!


fix/feat: New cleanup implementation

Jira: https://keboola.atlassian.net/browse/PSGO-416
:pray: Please, check it commit by commit
Changes:

Replaced old implementation of the storage/cleanup.

It deletes metadata of old files/slices from the DB.

ping @hosekpeter :pray:


A problem occurred configuring project ':react-native-community_netinfo'

Environment
System:
OS: Linux 4.9 Debian GNU/Linux 9 (stretch) 9 (stretch)
CPU: (4) x64 Intel(R) Core(TM) i3-3217U CPU @ 1.80GHz
Memory: 666.69 MB / 7.69 GB
Shell: 4.4.12 - /bin/bash
Binaries:
Node: 10.16.0 - ~/.nvm/versions/node/v10.16.0/bin/node
Yarn: 1.17.3 - /usr/bin/yarn
npm: 6.9.0 - ~/.nvm/versions/node/v10.16.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
Android SDK:
API Levels: 23, 26, 28, 29
Build Tools: 28.0.3, 29.0.1
System Images: android-28 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.2 => 0.61.2
npmGlobalPackages:
react-native-cli: 2.0.1
Platforms
Android
Versions

Android:
iOS:
react-native-netinfo: ^5.7.0
react-native: 0.61.2
react: 16.9.0

Description
I have installed react-native-netinfo and configure like his docs says. When I run react-native run-android I get the following error maybe related to gradle:
A problem occurred configuring project ':react-native-community_netinfo'.
> Could not resolve all artifacts for configuration ':react-native-community_netinfo:classpath'.
   > Could not find gradle.jar (com.android.tools.build:gradle:3.2.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/build/gradle/3.2.1/gradle-3.2.1.jar
   > Could not find builder.jar (com.android.tools.build:builder:3.2.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/build/builder/3.2.1/builder-3.2.1.jar
   > Could not find tracker.jar (com.android.tools.analytics-library:tracker:26.2.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/analytics-library/tracker/26.2.1/tracker-26.2.1.jar

and my build.gradle:
...
buildscript {
    ext {
        buildToolsVersion = "28.0.3"
        minSdkVersion = 16
        compileSdkVersion = 28
        targetSdkVersion = 28
    }
    repositories {
        google()
        jcenter()
    }
    dependencies {
        classpath("com.android.tools.build:gradle:3.4.2")

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}
...

Reproducible Demo

I solved this upgrading project dependencies and gradle to 3.5.2. Also adding androidXCore = "1.0.2" to my buildscript config like doc says (I was missing this detail).


[Feature request] - Add a FactoryAwareTrait to ease getting factory

Hi,
I've created for myself a little helper trait to ease getting a factory and I'm wondering if it may be of some interest to include one in this package.
Instead of doing
<?php
use App\Tests\Factory\FooFactory;
use App\Tests\Factory\BarFactory;
use App\Tests\Factory\BazFactory;

class MyTest extends TestCase
{
     public function testFoo(): void
     {
        FooFactory::make()->...;
     }

     public function testBar(): void
     {
        BarFactory::make()->...;
     }

     public function testBaz(): void
     {
        BazFactory::make()->...;
     }
}

I'm doing this :
<?php
use App\Tests\FactoryAwareTrait;

class MyTest extends TestCase
{
    use FactoryAwareTrait;

    public function testFoo(): void
    {
      $this->getFactory('foo')->...;
    }

    public function testBar(): void
    {
      $this->getFactory('bars')->...;
    }

     public function testBaz(): void
     {
        $this->getFactory('Bazes')->...;
     }
}

I've added some string transforms to be tolerant against cases and plurals. I've also extended my base test case to include trait so getFactory is available everywhere 😄
If you're interested, here's the code or I can submit a PR
<?php
declare(strict_types=1);

namespace App\Tests

use Cake\Core\Configure;
use Cake\Utility\Inflector;
use CakephpFixtureFactories\Factory\BaseFactory;

trait FactoryAwareTrait
{
    public function getFactory(string $model): BaseFactory
    {
        // Build class name
        $app = Configure::read('App.namespace') ?? 'App';
        $model = Inflector::singularize(ucfirst(strtolower($model)));
        $className = "$app\\Test\\Factory\\$model" . "Factory";

        if (class_exists($className)) {
            return $className::make();
        }

        throw new \Exception('Unable to locate Factory class for ' . $model);
    }
}

Hi @liqueurdetoile ,
glad to see you active on this repository too!
The advantage of the static call as featured in the package is that:

a good IDE autocompletes everything from you. You solution implies to type 'foo', increasing the risk of typo.
factories do not share states as such. Your notation looks like CakePHP tables (and components) awareness notation, which makes sense in the context of a repository. But this is not the case for the factories. There are no repositories, each factory lives for itself.

Correct me if I foresaw any advantage of your notation.
I'll mention my fellow colleagues @pakacuda @vidrascu001 to have their point of view, we take decisions together and might see some potential in your proposal.

Hi @pabloelcolombiano
Thanks for your welcome 😄
I understand your point of view. Here's some elements to respond :

This trait only brings another way to achieve the same thing, not replacing it. About the typo, I think the trait is more opened as you can type 'foo', 'Foo', 'foos', 'Foos' without any trouble. When starting to use cakephp-fixture-factories, I sometimes find myself staring to type  FoosFactory instead of FooFactory due to old habit with fixtures : app.Foos and not app.Foo.

As i see it, a factory is somehow linked to a model because they are baked from them and use associations to bring up data (that's the great thing in my opinion). I think the trait naming makes sense as some of the 'aware' stuff in cakephp relies on class loading and not on any registry (ModelAwareTrait, MailerAwareTrait for instance).

I must say it's more a question of feeling than anything else. I like to have things as less verbose as possible.

Our main concern when developing the package with @pakacuda has always been to optimize the developer experience. So if you think that the FactoryAwareTrait can enhance your coding experience, I am O.K. with it.

This said, I do not see how you end up making typos with the static call, unless you use a very basic IDE. I made a simple demonstration in this video  at around minute 22. If you type FooFa, your IDE should already propose you FooFactory.

In addition, you will sometimes want to create a PremiumUserFactory based on the UsersTable, probably an extension of the UserFactory. In this case, the FactoryAwareTrait cannot be used. This is really not a blocker to the FactoryAwareTrait, just a thought.

In order to better shape the implementation of the FactoryAwareTrait: you might want to have a look at this method: https://github.com/vierge-noire/cakephp-fixture-factories/blob/main/src/Util.php#L60 I think it does the same as your implementation + enables the plugin notation. I do not mind you shifting this method and its neighbors into the trait. But we should avoid having this code duplicated.

Again, I'll wait for my colleagues' feedback. Personaly if some users find the FactoryAwareTrait usefull in some ways, I have no objections.

I'm absolutely not willing to force things. It will be fine if you decide to avoid embedding it. Again, it's more a question of feeling than a real need and I can keep it using on my own anyway. I see it more like a syntactic sugar than anything else.

My IDE autocompleter indeed complains about my FoosFact...:unamused: and then I complain myself. That's one of the reason why I've wrote this little trait and extends my base TestCase with it 😺The main reason is that it reduces verbosity of my tests.

I haven't think about this one. Good point. Trait could implement haydenpierce/class-finder to compare lower-cased class names as a fallback before failure.

Sure, plugin syntax could be implemented. Maybe in a more sophisticated way if using  class-finder. But I can hardly see a use case for willing to load a factory from a plugin ?

Let's give it a try @liqueurdetoile.
The point 2 is actualy not an issue, your implementation will find the PremiumUser factory.
The plugin notation can be usefull. If you have models in a plugin, their factories will by convention also be located in the corresponding plugin.
My requirements on the implementation would be:

That the parameters passed to the getFactory() method be a string first, and then optional the two parameters that the make method accepts (see here)
The code placed in the Util class should be re-used, and the locator trait should be applied instead of the Util class (I think mainly by the bake command)
The implementation should be based on the next branch, not from main.
A test class should extensively test the new trait.

Does this make sense?

@pabloelcolombiano It seems fine. I will have a look for a PR on this basis.

Hi All,
Thanks @liqueurdetoile for your contribution !
Here are my thoughts :

Strongly typed factories are easy to refactor, using strings is hazardous in that context.
Autocompletion is better, even if you have to undo/re-type something to find the targeted factory IMO. You have immediate response as you type and you can be confident that you'll get the Factory you just typed/selected. With the getFactory method, you have to run the code to be sure that the correct factory was found and returned, which is an additional burden.
In terms of verbosity, I don't see an improvement. Could you shed some light @liqueurdetoile ? I probably missed something here :)
We'll potentially expose the library to unexpected name resolution bugs where someone passing some model name expects
Plugin syntax must be supported, for the reason @pabloelcolombiano mentioned

That said, as @pabloelcolombiano mentioned, I wouldn't be against something that the users of the library want.

Hi @pakacuda,
I totally agree with you and @pabloelcolombiano that using direct classes call is precise and less versatile. A trait like that has obviously its drawbacks but brings more flexibility on the other hand because it can easily be embedded in a custom parent TestCase to be automatically included.
About verbosity feeling. I presume it's closely related to my way of working.
For instance, if I wanna check a role-based access to an API. I prefer create a test case per role with 2 tests each rather than 10 tests in a single test case. I find it useful for keeping them fine-grained to each role specificity and more easier to expand (1 more role = 1 more test case and not 30 more lines). It's also easier to target things when troubles arise, particularly on integration test case.
To achieve this, I used to split transverse and common functionalities in traits and make my recipe with them in a test case that can then be extended. For instance, I will use Cake IntegrationTestTrait and customs FactoryAwareTrait, LoginTrait and CheckLogTrait in an AccessIntegrationTestTrait. Copy/paste a template and all setup is done for a brand new test case. Just need to add adequate fixtures and write down tests.
 Most of the time, in unit tests, I try to avoid using database interactions and keep them for latter and broader integration tests. Due to this habit, @pabloelcolombiano can tell how maniac I can be about overall speed in tests initialization 😄
Strictly speaking, the gain of verbosity per test case is only of 1 line per factory used between using my Trait or direct call but, as I multiply the test cases, the gain is multiplying too. Nevertheless, I can't say that using direct Factory should be a real problem in my own case.
My goal is not to convert anyone to change its way of working. As I'm feeling more comfortable with a trait, I thought I can share the idea here as some others can also feels like me. The idea is indeed to provide an alternative not a replacement.
Anyway, as you stated, it can be hard to maintain it against fancy factories names if willing to keep it tolerant against casing and plurals. I have to think about that. After all, Cake does not support it in its own fixtures system.
I thank you all for taking time to discuss it 😸, it's also helping me to self analyze my very own obsessive compulsive disorders in coding 😆.
I'll see for a PR but it can't be on the top of the list. Maybe, it's better to close this issue and follow up later in the PR itself ?

Personally I see the trait as a nice to have internally to the package, because the baking console, the association builder and maybe more later can take advantage of it.
It would not be my preferred way to instantiate factories for the reasons mentioned above, but I see no objections to add the feature for the reasons you mentioned.
Additionally, opportunities appear often while implementing a feature, so I think we should give it a try.
Btw I totally share your point that DB interactions should be banned from unit testing.
Let's keep this enhancement proposal open and ready to be implemented whenever someone has time.

This has been merged into master and shipped with the latest tag.
Thanks @liqueurdetoile for your contribution!


MWPW-133659 - rotate-page - hide the content after deleting selecting page

Resolves: https://jira.corp.adobe.com/browse/MWPW-133659
LINKS:
Before: https://stage--dc--adobecom.hlx.page/acrobat/online/rotate-pdf
After: https://mwpw-133659-l1-to-l2-rotate-pdf--dc--adobecom.hlx.page/acrobat/online/rotate-pdf

Codecov Report

Merging #357 (13cb5c1) into stage (9a6a259) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            stage     #357      +/-   ##
==========================================
+ Coverage   94.48%   94.55%   +0.07%
==========================================
  Files          23       23
  Lines        2591     2590       -1
==========================================
+ Hits         2448     2449       +1
+ Misses        143      141       -2

Files Changed
Coverage Δ

acrobat/blocks/eventwrapper/eventwrapper.js
30.28% <ø> (+0.17%)
:arrow_up:

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Is it possible to specify a folder configuration for open daily notes?

It works really well for me as all the diaries are in a separate folder
@svsool

Hi, yes it's possible, please find an example here.

Hi, yes it's possible, please find an example here.

it works.
Is it possible to support a simpler implementation, such as the configuration of foam:
"foam.openDailyNote.directory": "journals",


Slight redesign to covid landing page

make social distancing link more prominent
move images to the right
amend design of announcements section
wrap all in a grey, not black, box

@DilwoarH yeah, I think hard coded numbers are the inevitable by-product of high pressure changes like this. We can look at alternatives next week if it's a problem.


How to change the button's color?

([x] becomes a filled in checkbox, [ ] is an empty one)

[x] I have verified there are no duplicate active or recent bugs, questions, or requests
[x] I understand that versions below 2.0.0 will no longer be supported for updates.
[x] I have given my issue a non-generic title.
[x] I have read over the documentation (before asking questions on how to do something).

Include the following:

Material Dialogs version: 2.0.0-beta4
Affected device: OnePlus 3T

Also, please wrap your code with correct syntax highlighting (not just indents).
   MaterialDialog(this)
                .title(text = "title")
                .message(text = "Message")
                .positiveButton(text = "确定")
                .negativeButton(text = "取消")
                .show()

<LinearLayout ...></LinearLayout>

Reproduction Steps

Expected Result
In pre-2.0.0 version,I find the way to set "md_negative_color" to change negative's color.
In 2.0.0 version,I can't use this.
I know the way to set "android:colorAccent",But i think this way is not the best.
So, There has any other way to change negative's color?
Actual Result

See https://github.com/afollestad/material-dialogs/blob/master/README.md#changes-in-version-2

Unable to customize the button color, which is very distressing.


nuget badges link to package website

Hi @cloudRoutine, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Hi @cloudRoutine, thanks for the PR! To round this out, would you mind adding links to the MyGet and AppVeyor build definitions as well?

There aren't as clear cut destinations to link to for those, that's why I didn't do it in the first place

Lets go with the Rx Gallery for MyGet: https://dotnet.myget.org/gallery/rx, and Ix's CI feed is https://ci.appveyor.com/project/dotnetfoundation/rx-net-g0jsj and Rx's CI feed is https://ci.appveyor.com/project/dotnetfoundation/rx-net-la3iv. The badges may need to be updated for CI as well as we did create separate CI builds for Rx/Ix and did not yet updated the badges.

I think this can be closed.


Bug 2048824: IBMCloud: Add critical spec to driver daemonset

Add some critical settings to the driver daemonset template,
including priority class and update strategy. Remove the resource
limits for pods. All per OCP Conformance test expectations for
managed pods.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2048824

/bugzilla refresh
/lgtm
/approve

/cherry-pick release-4.10


fix: Do not merge expressions that contain output witnesses

Description
Problem*
Resolves #6516
Summary*
Stop the MergeExpressionOptimizer from optimising away an opcode that would assign to an output witness.
TODO: Add a test.
Additional Context
Using this example program for debug:
pub fn main(in0: Field) -> pub (Field, Field) {
    let out0 = (in0 * in0);
    //let out1 = (in0 + in0);
    let out1 = (in0 * in0);
    (out0, out1)
}

Running it with --force-brillig assigns all output witnesses:
❯ cargo run -q -p nargo_cli -- --program-dir . execute --force-brillig
[0_test] Circuit witness successfully solved
[0_test] Circuit output: Vec([Field(100), Field(100)])
[0_test] Witness saved to /Users/aakoshh/Work/aztec/noir/test_programs/execution_success/0_test/target/0_test.gz

However with ACIR it only assigns one witness, which is only evident with extra prints added to the program:
❯ cargo run -q -p nargo_cli -- --program-dir . execute
main witness = WitnessMap({Witness(0): 10, Witness(2): 100})
[0_test] Circuit witness successfully solved
[0_test] Witness saved to /Users/aakoshh/Work/aztec/noir/test_programs/execution_success/0_test/target/0_test.gz

Adding more prints to show the opcodes:
❯ cargo run -q -p nargo_cli -- --program-dir . execute --print-acir
Compiled ACIR for main (unoptimized):
func 0
current witness index : 2
private parameters indices : [0]
public parameters indices : []
return value indices : [1, 2]
EXPR [ (-1, _0, _0) (1, _1) 0 ]
EXPR [ (-1, _1) (1, _2) 0 ]

SOLVING OPCODE EXPR [ (-1, _0, _0) (1, _2) 0 ]
SOLVING EXPR Expression { mul_terms: [(-1, Witness(0), Witness(0))], linear_combinations: [(1, Witness(2))], q_c: 0 }
SOLVING EVAL Expression { mul_terms: [], linear_combinations: [(1, Witness(2))], q_c: -100 }
INSERTING Witness(2): 100
main witness = WitnessMap({Witness(0): 10, Witness(2): 100})
[0_test] Circuit witness successfully solved
[0_test] Witness saved to /Users/aakoshh/Work/aztec/noir/test_programs/execution_success/0_test/target/0_test.gz

We can see that the ACIR printed has 2 opcodes, but the execution only has one, because they have been merged.
Documentation*
Check one:

[ ] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Thanks for approving, let me just add a unit test quickly ⏳


Add determine version documentation

Add the API documentation for DetermineVersion experimental endpoint.

Generally this also needs information on how to get the hashes, how many files are necessary to include, etc.

Moved some wording around, added specific instructions for how to build the hashes to be sent to the endpoint, and linked the example tooling in the repository.

Docs preview

This is ready to go content-wise, but something broke in the github pages settings. I converted to draft until I can figure out what happened.

Please merge https://github.com/google/osv.dev/pull/1396 first to avoid breaking

@another-rex This is ready to go, but I took a look at the merge conflicts and determined that you would be the better person to resolve them.


Can't add multiple PTC accounts directly

If I want to add more than one PTC account, I get this error:
Oops, something went wrong and we couldn't log you in. Please try again. Unable to get login session from Pokemon SSO.
If I start the server and go back to the starting settings page or close the window and reopen it, it works fine again for a single account.

Add, then CTRL + R, and add again, etc etc.


refactor(router): rename pipeline slots

Pipeline slots have been renamed: 'modelbind' is 'preActivate', 'precommit' is 'preRender', and 'postcomplete' is 'postRender'. Sugar methods have been added to support the new names. RouteFilterContainers now support aliases in order to preserve backwards compatibility. Tests have been added for 'route-filters.js'.
Fixes #295.

Looks good to me!

Pipeline slots are still being hardcoded in some places
https://github.com/aurelia/router/blob/master/src/pipeline-provider.js#L20
The pipelineSlot's have got a new name, but the keys are still the same old. It's good for backwards compatibility, but you won't be able to use what should be the new key (as string) 'preActivate'.
Shouldn't the aliases be fixing this?

Line items in the pull request have been addressed, symbols have been removed, and the pipeline slot names have been fixed.

One more change...let's not export the pipeline step consts. Lets keep them internal and just have the methods since the step names are really an implementation detail.

Done.
2016-02-24 20:45 GMT-05:00 Rob Eisenberg<EMAIL_ADDRESS>
One more change...let's not export the pipeline step consts. Lets keep
them internal and just have the methods since the step names are really an
implementation detail.
—
Reply to this email directly or view it on GitHub
https://github.com/aurelia/router/pull/296#issuecomment-188555718.

Cool. Thanks! @bryanrsmith Whenever you think it's ready.


Max Flows (SUM or MAX)

The Azure Monitor screenshot above shows "SUM" as the metric for calculating inbound \ outbound flows.  When pulling this metric to see if we are hitting the 500k limit should we use "MAX" instead?
https://docs.microsoft.com/en-us/azure/azure-monitor/platform/metrics-custom-overview#metric-values

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c7c054b7-422c-c3b0-fc8e-91314231ee0c
Version Independent ID: 42825540-2137-92e3-08b0-0dbd84089eda
Content: Azure virtual machine network throughput
Content Source: articles/virtual-network/virtual-machine-network-throughput.md
Service: virtual-network
GitHub Login: @steveesp
Microsoft Alias: steveesp

@jarthu3 the flow limit is a combination of inbound & outbound flows, so you would need to use the SUM to add both of them together.
MAX would only output the highest of the 2 single values, which would not give what you want.

Thanks for your input @TravisCragg-MSFT
I checked with @mattreatMSFT who authored that portion of the document. He confirmed your comment and will make the necessary adjustment.

I'm confused on the following statement - “The flow limit is a combination of inbound & outbound flows, so you would need to use the SUM to add both of them together.”  The portal metrics are already separating the inbound and outbound flows, so calling “sum” on the inbound flows would not include the outbound flows because “outbound flows”  a different metric.

"In addition to bandwidth, the number of network connections present on a VM at any given time can affect its network performance..."  So, I shouldn't I be most interested in the MAX number of flows during a given time period when trying to determine if a VM is breaking the flow limit?  As long as my MAX is under 500k, I should not have performance issues directly related to breaking the flow limit, correct?
Min: The minimum observed value from all the samples and measurements during the minute.
Max: The maximum observed value from all the samples and measurements during the minute.
Sum: The summation of all the observed values from all the samples and measurements during the minute.
Count: The number of samples and measurements taken during the minute.
I appreciate any clarity you can provide.
Thank you!

@jarthu3 your understanding is correct, the problem is a limit with the custom metric. The limit that you need to track is the combination of inbound & outbound, but you need to use a custom metric to track that.
the ideal situation would be to do a MAX of the inbound + outbound, but I do not know if you can make a custom metric of a custom metric.

@jarthu3 We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


tags: fix missing javascript

Tags editor is broken on search result page after login.

[ ] register javascript to "search" bundle when tags module is enabled (addresses #1769)
[ ] do not use inline javascript or <script> tag

@jirikuncar can we move or close the issue?

Fixed in https://github.com/inveniosoftware/invenio-tags/commit/a598b23a15c73d3344c2a88bba80e1e2e68a94f4