operators [R] hazelcast-platform-operator (5.12.0)

This reverts commit d3749cb9ec29bea5f80aaa56017e312d52ea9a26.
Signed-off-by: devOpsHelm<EMAIL_ADDRESS>Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[x] Are you familiar with our contribution guidelines?
[x] Are you familiar with our operator pipeline?

[ ] Have you considered whether you want to use semantic versioning order?
[x] Is your submission signed?
[x] Is operator icon set?

Your submission should not

[x] Add more than one operator bundle per PR
[ ] Modify any operator
[ ] Rename an operator
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description of the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/retest-required

Hi @J0zi @mvalarh
Could you please check this PR and tell me what is wrong here? What should I do to revert the commit and remove [hazelcast-operator-5.12.0]
Currently, it's a kind of release blocker for our operator.

/retest

Hi @J0zi @mvalarh @Allda @mporrato
Could you please check this PR and tell me what is wrong here? What should I do to revert the commit and remove [hazelcast-operator-5.12.0]
Currently, it's a kind of release blocker for our operator.

/pipeline restart operator-hosted-pipeline

@devOpsHelm you cannot change existing bundles. You will have to release a new bundle.
Hi @mporrato, but this bundle is not correct and won't work for users. I need to create new 5.12.0 but it won't be possible because 5.12.0 already exist and we need to keep versioning. Why it's a problem to remove?
For example this one removed https://github.com/k8s-operatorhub/community-operators/pull/4266 and certified operator will be removed as well https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3843

This repo's ci has now been unified with the isv certification pipeline and it has inherited some of its restrictions.
Immutability of existing bundles is one of those restrictions.

This repo's ci has now been unified with the isv certification pipeline and it has inherited some of its restrictions. Immutability of existing bundles is one of those restrictions.

Ok then, can you please advice how can I release 5.12.0 version?

You will have to release a new bundle.

Hi @mporrato @Allda @J0zi @mvalarh,
I am from the Hazelcast team.
We did not know about the policy change, you mentioned me in the announcement but I did not receive any notification so that's why we did not modify our release script to prevent these kind of situations. And also at the announcement, you mentioned that you introduced this policy to prevent some problems at user-side:

Bundle Removal Restriction: Removal or update of a bundle is no longer allowed. This restriction ensures that operator users won't end up with a broken operator in case an operator is removed from an index.

but we have just released this version few hours ago so no one is using it right now.
Releasing the new version(5.13) is not possible for us now because we have a public roadmap that has already been announced to our customers. It will create huge confusion on their side. I could see some revert PRs which were created after the announcement:
https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/4221
Could you make an exception for us just for once? We have already started to change our release script to make it compatible with your policy.
Thanks,

but we have just released this version few hours ago so no one is using it right now.

That's why I am suggesting to release a new bundle to fix the issue as soon as possible so that new users installing the operator from now on will get the fix directly.

Releasing the new version(5.13) is not possible for us now because we have a public roadmap that has already been announced to our customers. It will create huge confusion on their side.

Can't you issue a new z release, like 5.12.1?

I could see some revert PRs which were created after the announcement: #4221

That specific example (and I'm sure this applies to any other revert pr you can find since the switch to the new CI) was a revert of a change that did not end up being published to any operator index: that's something we can do if we can catch the issue before the release pipeline completes successfully, but unfortunately it's not the case for your request.

Could you make an exception for us just for once? We have already started to change our release script to make it compatible with your policy.

What you are asking for is not just a revert of a commit in a git repo: your previous PR was already processed by the release pipeline which updated the operator index of each supported openshift version to include the 5.12.0 bundle (that's what the operator-release-pipeline/passed label in https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/4442 means).
Undoing that would require manually altering 5 different operator indices, one for each supported openshift version, which is a slow, complex and very error prone operation when done manually.

@mporrato
Thanks for your detailed answers.

Can't you issue a new z release, like 5.12.1?

it will be messy on our side.

That specific example (and I'm sure this applies to any other revert pr you can find since the switch to the new CI) was a revert of a change that did not end up being published to any operator index: that's something we can do if we can catch the issue before the release pipeline completes successfully, but unfortunately it's not the case for your request.

What you are asking for is not just a revert of a commit in a git repo: your previous PR was already processed by the release pipeline which updated the operator index of each supported openshift version to include the 5.12.0 bundle (that's what the operator-release-pipeline/passed label in https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/4442 means).
Undoing that would require manually altering 5 different operator indices, one for each supported openshift version, which is a slow, complex and very error prone operation when done manually.

I see, thanks for the explanation.
I know updates are not allowed due to the policy, but our issue is at the docker image level, so can we update clusterserviceversion.yaml of 5.12 with new image details?
https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/4442/files#diff-2915a0425309d62c715cb47f0f91fd10f448c872f442c50230920c93a1f0c69bR254-R256

@mporrato
Thanks to @jfrancin, the certified counterpart of this PR has been reverted, FYI.
https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3843#issuecomment-2093377079
For the 'do-over' of the 5.12.0 release, we are waiting for your decision.


Introduce C++14 style helpers

This adds a C++11 implementation of make_unique and enable_if_t, and use them around the code.

as I am completing my Ph.D. thesis this week!

Good luck!


Windows 10 PostgreSQL 10 Connection via SSH

I have read through issue #317 numerous times trying to figure out what I am missing and I am unable to... Here are the basics:
I am running on Windows 10 with OmniDB 2.15.0...  Here is my connection in OmniDB:

That does not work... I continually get a password dialog, which always fails.
NOTE: If I create a tunnel outside... I.E:
alias tnlbi='ssh -N -L 5433:server:5432 me@server
Then run it in back ground:
tnlbi &
Then I can create a local connection that connects:

So while this is a work around... I would really like to be able to bypass this requirement and understand what happened.

Hi @FriarMonk ,
You need to paste the contents of your private key in that field and not the path to the file.
Please try this way and let us know if it will work.
Best regards,
William

Perfect… that is the piece I was missing… Thank you!
From: William Ivanski<EMAIL_ADDRESS>Sent: Friday, April 26, 2019 11:46 AM
To: OmniDB/OmniDB<EMAIL_ADDRESS>Cc: Larry Tuck<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [OmniDB/OmniDB] Windows 10 PostgreSQL 10 Connection via SSH (#931)
Hi @FriarMonkhttps://github.com/FriarMonk ,
You need to paste the contents of your private key in that field and not the path to the file.
Please try this way and let us know if it will work.
Best regards,
William
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/OmniDB/OmniDB/issues/931#issuecomment-487123844, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AL5VMARJDKG4E7NAHFLWIJLPSMWUHANCNFSM4HIXCXNQ.

Hi @FriarMonk ,
Thanks for confirming it helped. Closing this case now.
Best regards,
William


Enhancement: When passing a name to new_action, fastlane still prompts you for a name.

fastlane new_action react_bundle
Still causes fastlane to output the following
Must be lower case, and use a '_' between words. Do not use '.'
examples: 'testflight', 'upload_to_s3'

I exepected it to grab the react_bundle passed in as the first argument and use it as the name

Right now the args are unused: https://github.com/fastlane/fastlane/blob/master/fastlane/bin/fastlane#L59-L61, it should be easy to add this :+1:

Just merged this: https://github.com/fastlane/fastlane/pull/4041
It will be available in the next release, closing this but let me know on Slack how it works out for you!


Replace GoogleTest with Boost.Test?

We can drop dependency on GoogleTest and use Boost.Test instead -- we already depend on Boost anyway.

Resolution (discussed by JM, AS, and PBW): keep using GoogleTest.


Can we have the publishhtml tab in release pipeline?

I have added the extension to release pipeline but i cant see the tab as we see in pipelines

Duplicate to the closed issue. It will be good if it support Release pipeline

Duplicate to the closed issue. It will be good if it support Release pipeline


Added nth-check in Third Party Modules GitHub

This error was not caused by my change.

"-" doesn't support by deno so change the name to nthCheck, nth_check or something else

"-" doesn't support by deno so change the name to nthCheck, nth_check or something else

Solved


Small UI fixes

Hey @w3irdrobot I talked to @FrontendCrypto and he believes having static 5 lines input for the login page and DM is too much, I'll revert it here, anyways thanks for the multi-line trick on the DM, now it grows, it's awesome 😄


Add code to show current weather

Need to code a function to pull data from openweathermap and report it to the UI. Obtain temperature, humidity, current weather (cloudy, raining, etc) and weather icon. Possibly 'feels' like and other data?

Currently working with temp, humidity, current sky. Need to convert icon id to img address?

Along with several errors in the code, attempts to get the code working, etc, it took a while to determine
a) that I needed a geolocation link from openweathermap to convert city names to long/lat needed to call the data from the api
b)how to convert the default kelvin temperature to celsius. Used simple arithmetic to do so, but the data might also contain that information. Opened separate issue to report in F'


Calendar flickering/jumping all over the place

Hi,
I just restarted my Pi (has been running for a while) and suddenly the calendar is jumping all over the place. I've narrowed it down to something that happened in 2f786b7. If I checkout a2828f5, then it works (no jumping), but 2f786b7 or master has this jumping issue. It happens both when viewed from my lapttop (Vivaldi, Linux) and on my Pi.
I see there's a lot of divs being created and deleted.
I've reduced my config.js down to this, which contains only MMM-CalendarExt2.
jumping-config.js.txt
For now, I'll just use 2f786b7.
(Thanks for a great plugin!)

Hi @mabahj,
I do not see this behaviour on my end, although I am running the latest master. Could you show this in animated form (e.g. gif or screen recording)?

Here you go.

@mabahj That's really crazy behaviour.
As I couldn't see the behaviour with my config, but yours I decided to add breakpoints in the sources tab until I found a place it frequently visited - turns out, that you have this in your config:
updateInterval: "10*60*1000", // 10 minutter¬
rotateInterval: "60*60*1000", // 1 hour. Trial to force the calender to update first day shown.¬

The updateInterval gets passed verbatim to javascripts setTimeout() function, which expects an integer there.
Now let's try to parse that value to an integer:
parseInt("10*60*1000")
-> 10

So you accidentially set the update interval to 10 milliseconds, and then even the quickest browser in the world can't keep up and remove the old divs before the next one gets added in.
The fix is easy: just remove the double quotes, that way the value stored in the config is no longer "10*60*1000" but 600000, which is the 10 minutes you intended.
I have no idea why the problem got exposed by these commits, but the explanation is easy enough.


Speed up creation of HoloViews objects

In the past HoloViews has generally been used for reasonably small datasets, where loading or generating the data is many times more expensive than creating param.Parameterized objects. However in this project we'll be working with iris cubes, which can potentially be very large and can easily be grouped into tens or even hundreds of thousands of individual Images, Contours or other Element types. At that point creating this many objects, which may each also create other parameterized objects, can become a serious bottleneck.
param was designed with the idea that the user should be able to tweak each parameter on each object, when declaring many thousands of objects at once however it is clear that the user will not tweak each individual parameter and it might indeed be desirable to share certain parameters across all these objects. Therefore there is this tension between being able to tweak parameters and quickly declaring thousands of identical objects.
This issue is meant as a place to brainstorm how we can speed up creation of objects in HoloViews, by providing better control over when Parameterized objects make deep copies of their parameters. This could take the form of a context manager, which could be used in any place when a lot of identical objects will be generated, an option on Parameterized objects or something else entirely.
I've already opened https://github.com/ioam/param/pull/122, which speeds up object creation by ~50%, such that we can create 20k Image objects in about 5 seconds. Hopefully we can reduce that further by coming up with a good proposal here.

param optimisation will address this, closing for this project


Type Safety of ABI

Currently there is very little type safety at the ABI layer. Mistakes in code generation around ABI are likely to not be caught until code is run, although these changes should be easy to catch with the simple "smoke tests" already present. How big of a deal is this?
Specifics
WinRT interfaces are conceptually simple wrappers around pointers to their VTables. However, we are currently encoding them as wrappers around a pointer to IUnknown.
For example, given an interface IMyInterface, there will be a struct defined as follows:
struct IMyInterface {
  ptr: ::winrt::IUnknown,
}

An arguably more correct implementation would wrap some sort of smart pointer to the VTable directly.
ComPtr<abi_IMyInterface>

// comptr.rs
#[repr(transparent)
#[derive(Default)]
ComPtr<T>( *mut *mut T); // We could also constrain `T` to types that implement some unsafe interface like `ComVTable`

impl<T> ComPtr<T> {
  #[inline]
  fn as_raw() -> *mut *mut T {
    self.0
  }
}

/// Additional functionality to make this a ref counter pointer

Additionally, the "this" pointer for ABI function calls is usually defined as RawPointer aka *mut c_void. It would be more correct for this to take a ComPtr<abi_IMyInterface> instead. In fact, this is true for all the arguments to the ABI functions, not just this.

This was fixed by https://github.com/microsoft/winrt-rs/pull/97


In Visual Studio, crashed with errno -4082 EBUSY

Sometimes when I save a file in Visual Studio, karma just crashes with a -4082 EBUSY. This is currently only happening to me at work, it never happens on my computer at home. Any advice.  I pondered on if it was the virsus scan locking up the file or something. Is there a way to force Karma to contine on an error? I opened the test file in notepad and saved it and it also crashed, but it took me really saving quick over and over to get it to crash, with Visual Studio it is just doing common work.. I will check my version at home (when I get home)
Visual Studio Premium 2013
Karma version 0.12.31
node v0.12.2
PhantomJS

I am at a loss, so I opend the project in VS2012 and I am noticing it does not happen (or has not happened yet). I will look and see if in VS2013 I have some plug in or extension that is causing this. Perhaps some process has the file in VS2013 (resharper, web essential, some devil spawn)

This might shed some light on the issue: https://github.com/codereflection/Giles/issues/40

I closed this issue, because I believe it is a VS2013 issue


How to use js submit log?

I download v4.1 release and deploy on IIS.Now I test submit netcore log is ok,but I think how to use   exceptionless submit log with js?

Hello,
Please see our client documentation for submitting events: https://github.com/exceptionless/Exceptionless.JavaScript/wiki/Sending-Events


build: support building inside a container

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   43.07%   43.07%
=======================================
  Files          10       10
  Lines        1170     1170
=======================================
  Hits          504      504
  Misses        587      587
  Partials       79       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735e858...2a96e73. Read the comment docs.


Failed to setup listeners: getaddrinfo EAI_AGAIN

hi
After running haraka service in /etc/haraka it gives the following error when i tries to send mail

can anybody just guide me how to solve this error I tries everything bt not able to solve it
attachin  the screenshot

What do you have in your listen= option in config/smtp.ini?
Note: please don't post another screenshot.  Learn how to quote in Github and paste the output.

listen=[:0]:587

looks like i figured it out it is syntax mistake i am doing it should have
listen=[::0]:587


[Suggestion] Retry for thumbnails

Lately, Groompbot's posts don't have thumbnails. I am pretty sure the reason for that lies with Youtube not having the thumbnails ready when the videos are first published. Would it be possible to implement an automatic retry after a few minutes?

This version of Groompbot is dead, I don't know what /u/groompbot is using.


Explore folder/lists for bookmarks

List out what bookmarks we want for desktop/mobile

My proposal is for "lists". There would be no bookmarks in the default / root level. There would only be names of "lists" in the default / root level. These "lists" act the same as a single-depth folder.
1. Lists Proposal
Pros:

Shabads can be added to multiple lists very easily
Shabads can be found in no more than one jump
Editing a bookmark's location(s) is easier
Sharing lists with other users is easier than sharing a nested folder (a list just goes in the flat list of lists, a folder has to be chosen where it gets put) an extension of "sharing" becomes "broadcasting" so people could subscribe to an online list more easily

Cons:

May require more scrolling for the user
May require more dragging of list ordering for better organization
Does not "organize" well for variations of the same concept (nitnem for different schools of thought)

Example tree: // First nine cannot be re-arranged

Saved For Later // Default list for user bookmarks to go in
Nitnem (Taksal) // These may use different sources for compositional banis or include different lengths

Jap Ji Sahib
Jaap Sahib
...

Nitnem (SGPC) // These maybe follow SGPC published nitnem gutke

Jap Ji Sahib
Jaap Sahib
...

Asa Di Vaar // Note both the bani for the entire and each individual is available

Full 24 Chhakke
Chhakka 1
Chhakka 2
...

Sundar Gutka // These would contain nitnem, asa di vaar, and more -- repeating is allowed
Anand Karaj // Shabads related to marriage ceremony including 4 laavan
Final rites
Hukamnama // Could be an optional list that requires subscribing to - List of different gurdwara hukams from around the world that are automatically updated and includes any number of user hukamnama options that are automatically chosen each day
Paath // List of different paath readings of compositions. Perhaps multiple people use the same tablet for sehaj paath of Sri Guru Granth Sahib ji, they can have them all in this Paath list
User list 1 // perhaps for keertan program
User list 2 // perhaps for thematic
User list 3 // perhaps for presentation/katha/speech purposes
Subscribed BoS // perhaps a list of shabads for basics of sikhi's most recent video, can be cleared and added to again for each new video and shows "last updated" date as well as "home page" of subscribed list which points to the video
...

2. Tree Proposal
Pros:

A lot more organization customization / capability (for advanced users willing to spend the time and effort)
Potentially less visual "clutter" to scroll through

Cons:

Can create annoying navigation situations (If we allow a default location of save to be where you last saved, and that is a nested folder, the user must "edit" location by first leaving to root folder, then delving into a different structure/nest to save it in the correct place)
Seeing where a bookmark is saved is harder to do (In a single flat list, you can see where the bookmark is saved in the same scrolling view)
Sharing of nested folders is harder conceptually on the end user (imo). Similarly, organizing of nested folders is more work for any user even for themselves. Sometimes have to stop the user from being too smart for their own good ? 😄

3. Hybrid Proposal
Root folder contains non-customizable base folders. Shabad OS folders can contain folders within folders perhaps. User folder can only contain lists and can be located in their own "User folder" or simply as lists below the Shabad OS folders.
Pros:

Allows for less visual information without sacrificing simplicity of user bookmarking
Cuts down scrolling, at the cost of one extra folder depth requirement from bookmark root
Shabad OS folders are easier to organize, though at the cost of requiring extra work from the user

Cons:

Still doesn't allow power users to create lists within lists for their custom bookmarks (No folder for "keertan set lists", or "presentations")

Shabad OS folders could also be annoying to traverse if there is too much depth.

's Bookmarks // Either this is it's own folder at the top of the root folder, or it's children are listed alongside (and below) the root Shabad OS folders

Saved for later // where a default user bookmark goes for later sorting, cannot be moved/re-arranged
User list 1 // perhaps for keertan program
User list 2 // perhaps for thematic
User list 3 // perhaps for presentation/katha/speech purposes
Custom Nitnem/Sundar Gutka // perhaps user wishes to do nitnem with a superset not available

Nitnem

Nitnem (Taksal)
Nitnem (SGPC)
...

Sundar Gutka

etc.

Conclusion
Personally my goals for our bookmarking is twofold: (1) to include commonly read bani/shabads in a well organized and easily accessible way, and (2) easy user bookmarking for future reference (usually one "parent" name is all that's required)

If we keep things to a single list format we will avoid more than three taps to get anywhere (1: Bookmarks > 2: List > 3: Item).
If we keep things in a single list format, consumption of pre-defined bookmark lists is easier (they don't have to navigate around to see where what is)
We glean more easily where a shabad is saved (when editing a bookmark / it's locations, you see one flat list with a check mark next to the list name indicating it's saved in there).
We also allow for more customization of the bookmark itself without adding on the worry of where it is (choose whether the bookmark is opened in reader mode by default, which source to use for the bookmark, whether to make it a "broadcast" bookmark for other users to subscribe to like a hukamnama, etc.).
Better navigation of lots of bookmarks requires a search bookmarks feature regardless of folder structure, and I will argue that remembering the names of your lists is easier when it's in one flat list that is viewed when scrolling
Lists are easier than folders within folders for users to conceptually understand creating, managing, editing, etc.
Users may not find the "look" of multiple lists in scroll view appealing, but they should find it easier / simpler (and smart ones could avoid by searching the list name or sorting by date, etc.). Sorting is easier when you are sorting a flat level of lists as opposed to nested folders.

I agree because the main purpose is that one can access something quickly.

If we keep things to a single list format we will avoid more than three taps to get anywhere (1: Bookmarks > 2: List > 3: Item).

With Hybrid we are trying to put in List and Tree together so it should allow users:

Still doesn't allow power users to create lists within lists for their custom bookmarks (No folder for "keertan set lists", or "presentations")

Question: User can modify the predefined bookmarks?

Users should not be able to modify predefined bookmarks (in hybrid these would be the "folders" bookmarks)
User should be able to "hide" the default predefined bookmarks. Though how the user will "unhide" them is a good question.
Hybrid would not allow users to customize lists within lists. Hybrid allows users to have their lists in a flat level and includes predefined folders from Shabad OS to cut down on clutter perhaps. Hybrid then allows either the lists to be in the root directory or in it's own folder "User's Bookmarks".
Personally I don't see the benefit of Hybrid aside from a very shallow level of organization for predefined bookmarks. Especially if user can hide the extra predefined lists in prop 1, it should not be considered too much of a clutter.

I would also say I'd rather see hiding/archiving of lists rather than folders. This would allow there to be "current lists" and "inactive lists" which can still be accessed though not cluttering the main bookmarks page.

This was more a mobile issue and has been resolved. Can be linked for information.
End choice is a list of only folders. Each folder has a list of only bookmarks. Folders are renamed "Collections". Items are still named "Bookmarks".

This was more a mobile issue and has been resolved. Can be linked for information.
End choice is a list of only folders. Each folder has a list of only bookmarks. Folders are renamed "Collections". Items are still named "Bookmarks".


Report only option (fortio report)

Fixes #42
(Partially/one way)

Thinking of running an instance in report mode on something like fortio.istio.io


replaced socket.gethostname()

worked on issue #40
fixes
Not printing logo on macOS in
OWASP-Honeypot/config.py
Proposed:
Replace socket.gethostname() with ""
Testing:

Hi,
Thanks for the PR and your contribution, can you describe the issue more? i am using mac os but couldn’t understand what issue you solved
Thank you.

hi
I am also using mac OS.
The issue which was opened by you https://github.com/zdresearch/OWASP-Honeypot/issues/40, in which ohp.py file doesn't printing anything, I just tried to solve that one, after replacing socket.gethostname() by "" in config.py file, I found that it started to print the logo.

The issue in #40, fixed by #44 PR, do you still have the issue?

But why this issue is still open?
On Sun, Feb 23, 2020, 5:22 PM Ali Razmjoo<EMAIL_ADDRESS>wrote:

The issue in #40 https://github.com/zdresearch/OWASP-Honeypot/issues/40,
fixed by #44 https://github.com/zdresearch/OWASP-Honeypot/pull/44 PR,
do you still have the issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zdresearch/OWASP-Honeypot/pull/61?email_source=notifications&email_token=AMWTAZCVW72Z6FI2J7NHBQLREJPOVA5CNFSM4KZXPZS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMVZZCQ#issuecomment-590060682,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMWTAZBSO7CJUSQOOKMIITLREJPOVANCNFSM4KZXPZSQ
.

I think I forget to close the issue, and thank you for your consideration.


GDScript: Fix usage of enum value as range argument

Look at a type of a reduced value, not at a type of a constant. Solves two things:

Allows enum values.
Validates constants with a declared type of Variant, before they were skipped.

Closes #73779.

Thanks!


Zones over Multiple Screens

Fancy Zones Over Multiple Screens
The Problem is that i have a Multi monitor Setup and want to place a Fancy zone over the border of the screens. I use two borderless monitors and would like to put a fancy zone in the "middle" but the problem is that there is a monitor border and i cant create Fancy zones that reach from one screen to another.
Best Regards Winkow

Hi @Winkowitsch
thank you for your feedback.
This feature request is tracked by https://github.com/microsoft/PowerToys/issues/480
Please add your comments there, I'll close this one.
Thank you.


Remove tarball file after sync

The removes the tarball file artifact after syncing.
Testing

Ensure you have the latest dependencies with rm -rf node_modules && npm install
Run the unit test suite, ensuring all tests pass
After running, validate the webdrivercss.tar.gz file doesn't exist

Notes

I was looking at a way to pipe the stream from targz() to the form (in lieu of creating a file), but just don't know enough about it to figure out the sync error I was getting. Going to see if I can try this again when I get more free time.
The upgrade to 1.0.1 for tar.gz isn't necessary, but thought it's worth updating anyway.

hi @klamping :)
why not keep it and just .gitignore it - Maybe Might be useful in the rare cases you want to debug your tar and see its contents?

(off topic, my take on the file sync is that it should be moved out of core for webdrivercss 3, and just use webdrivercss's API)

hey @amitaibu! I'm doing the .gitignore route for my project, but it just feels weird to have the file lying around. Because the screenshotRoot corresponds directly to the name of the webdrivercss-adminpanel project, this file gets added to my root folder. Not a huge deal, but something I'd like to see cleaned up.

:+1: by me. I'll still let @christian-bromann hit the merge :)

LGTM!

(off topic, my take on the file sync is that it should be moved out of core for webdrivercss 3, and just use webdrivercss's API)

Agree on that.

Published with v1.1.8


SPARK-66 NullPointerException is thrown during parsing an empty string

@tmatvienko could you please add corresponding unit test to https://github.com/basho/spark-riak-connector/blob/master/connector/src/test/scala/com/basho/riak/spark/rdd/timeseries/TSConversionTest.scala

@srgg Please, check

@tmatvienko Could you please squash all the commits into the one commit?


support to subtitle?

support to files .srt?
great job!

There is a readme section regarding adding <track> elements when playing files.

not support .srt files and remote files

https://stackoverflow.com/questions/26968759/does-html5-video-support-srt-texttrack


Added URLs for external hyperlinks in the docs

Generated documentation had broken links. For example, `cookiecutter`_ was visible rather than a proper link.

This won't be fixed until we address #56

@ianmkenney is this superseded by #57?

Closed as stale -- @ianmkenney please reopen if you think it's needed.


chore: fix typo

What is the purpose of the change
(For example: This pull request adds a new feature to periodically create and maintain savepoints through the FlinkDeployment custom resource.)
Brief change log
(for example:)

Periodic savepoint trigger is introduced to the custom resource
The operator checks on reconciliation whether the required time has passed
The JobManager's dispose savepoint API is used to clean up obsolete savepoints

Verifying this change

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changes to the CustomResourceDescriptors: (yes / no)
Core observer or reconciler logic that is regularly executed: (yes / no)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@drgnchan I think the commit message is best changed to the form of "[hotfix] XXX"

This PR has been opened for 1 month, and don't response more than 2 weeks.
I close it first.


Add a new "Air Traffic Data" example

What
WIP
pixi run py-build-examples && pixi run -e examples python examples/python/air_traffic_data/air_traffic_data.py

Checklist

[ ] I have read and agree to Contributor Guide and the Code of Conduct
[ ] I've included a screenshot or gif (if applicable)
[ ] I have tested the web demo (if applicable):

Using newly built examples: app.rerun.io
Using examples from latest main build: app.rerun.io
Using full set of examples from nightly build: app.rerun.io

[ ] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[ ] If applicable, add a new check to the release checklist!

PR Build Summary
Docs preview
Examples preview
Recent benchmark results
Wasm size tracking

@abey79 the reason we don't have this in yet is that it simply is too bad of a user experience, right?

@abey79 the reason we don't have this in yet is that it simply is too bad of a user experience, right?

Yes. It's here to remind us that we need to improve our "lots of entities" story :)

I would love to get this merged as a benchmark, even though we're not hitting the benchmark yet.

I would love to get this merged as a benchmark, even though we're not hitting the benchmark yet.

May I interest you in https://github.com/rerun-io/rerun/pull/8163? This is a blocker for the --batch logging strategy of this example. Which is interesting to have along side the "regular" (aka rr.log()) logging pathway for ingestion benchmark (aka why is shuffling data in python faster than our compactor).
Then I can further dust it off and try to push it to mergeable state.

As of today on my machine, using the 2h dataset, I get the following ingestion times:

with --batch, I get 45s of ingestion time, plus 3-4s of additional latency in the viewer
without --batch, I get 1min20s of ingestion tine, plus ~35s of additional latency in the viewer

I'm probably missing something, but our batches (SDK-side and viewer-side) should probably do a better job at beating my home-grown, Polars-based batching code.


Don't attempt to lookup search aliases if Bungiesearch isn't setup

And associated test.
As per Issue #160
I included a simple test, however I wasn't able to get the tests to run on my local machine, so I can't guarantee that it passes

Coverage remained the same at 100.0% when pulling 16db5617051e17157ca50ffe37b9416e67adf322 on ProfSmiles:bugs/160-manager-aliases into 2f87ee034f4667304870144bfbaccd8d147c82c6 on ChristopherRabotin:master.


ERROR at dynamically parsed input that //build/toolchain/gcc_toolchain.gni:6:20 loaded :1:2: This is not a valid number. 1.9471311569213867

I'm trying to use the gn tool (in the engine/src/flutter/tools directory) to prepare build files using the following command:
./flutter/tools/gn --android --unoptimized
However, I first get errors about invalid syntax for print statements in the gn tool script. I assume these scripts are to be executed with Python2 but are getting executed with Python3 instead hence the error.  I converted the print statements to the Python3 syntax but then I'm met with this error:
Generating GN files in: out/android_debug_unopt
ERROR at dynamically parsed input that //build/toolchain/gcc_toolchain.gni:6:20 loaded :1:2: This is not a valid number.
1.9471311569213867
-^
See //build/toolchain/android/BUILD.gn:9:1: whence it was imported.
import("//build/toolchain/gcc_toolchain.gni")
^-------------------------------------------
See //BUILD.gn:6:1: which caused the file to be included.
group("default") {
^-----------------

For context: I'm following the instructions at Compiling the engine

anyone resolutions?

What platform are you on? Can you work around this by getting rid of concurrent_links = exec_script("get_concurrent_links.py", [], "value") in gcc_toolchain.gni:6. I don't think that flag is used anymore and seems to have been initially added to figure out how many concurrent link jobs the build system could do. For whatever reason, that number seems to be 1.9... on your host.

Ok, I can confirm that this variable was not necessary. I removed its use in https://github.com/flutter/buildroot/pull/351 and you can do the same to unblock yourself. Let me know if you are stuck anywhere else.

@chinmaygarde

Ok, I can confirm that this variable was not necessary. I removed its use in flutter/buildroot#351 and you can do the same to unblock yourself. Let me know if you are stuck anywhere else.

yes the issue goes away by removing that call. However newer issues come up owing to invalid Python3 statements in various scripts and tools. Have created an issue here #53002


Diffrax activating the event on a rejected step

Hi
I'm using diffrax 0.5.1 with events like that :
def condition(state, **kwargs):
"some condition"
...
return cdn
event = dx.DiscreteTerminatingEvent(cond_fn=condition)

solution = dx.diffeqsolve(
...
discrete_terminating_event=event
)

and I noticed that diffrax is activating the terminating event even if the step has been rejected.
I suppose this is an undesirable behavior ?
Also as far as I tried I've been unable to find a way to get the knowledge of whether the step has been rejected or not in the event through "state" or "kwargs"
I'm sorry to be unable to give a minimal working exemple here because I don't now how to reproduce it by making an event trigger at the "right moment" that is at the moment a time step has just been rejected ! (and the code I'm using is too large to be considered a working exemple).
Though I'm pretty sure it happens as described since solutions.stats gives me 'num_accepted_steps': Array(0, dtype=int32), 'num_rejected_steps': Array(1, dtype=int32) and my event is triggered

Hmmm! That's not good!
@cholberg - WDYT?

0.5.1 is pre the events refactor right?

0.5.1 is pre the events refactor right?

Yes it is ! ( Though I'm still using this version for one main reason that is state.tnext is not defined in 0.6.0 alongside state.tprev. And i need a dt = state.tnext - state.tprev for my condition. But that's another story. ).
Though the code for 0.6.0 assumes backward compatibility with TerminatingEvent according to this note, so I suppose the problem is still relevant as for now.

As far as I can tell, this happens exactly because your condition depends on tnext. This should be possible right now in 0.6.0 (at least not in a straight-forward way) as you mention yourself. But I think there should be a way to do what you want in the newest version that perhaps would not run into the same problems.  The idea I had in mind would be to add an extra variable to the state of your differential equation that keeps track of the time. So the vector field for your ODETerm would look something like this:
def vf(t, y, args):
    t, x = y
    x_out = ...
    t_out = 1
    return (t_out, x_out)

@patrick-kidger: On a different note, this made me notice that the current implementation is actually not quite backwards compatible since DiscreteTerminatingEvent takes state as the first positional arguement which is not a possible argument in the newest version. I am not sure if this is something we would want to change? (Then, of course, you would not have to do the work around as described above if you wanted your event condition to depend on dt.)

@etienney: So tnext was removed deliberately. It's not clearly defined in general: for example when doing a root-find over the length of the final step, to determine the exact time at which a condition is triggered.
What's your use case for needing the length of a step?

@cholberg: indeed, removing this was deliberate (and despite our backward compatibility layer, the break here is the reason I bumped the minor version to 0.6.0, rather than continue down 0.5.x). The state object we were passing is an internal abstraction that isn't stable from release to release -- at times we may add or remove fields. It's also not clearly defined when doing a root find to find an event.
If there's any additional information we could reasonable be forward to the event, that we aren't at the moment, then I think that should become an additional **kwarg.

As far as I can tell, this happens exactly because your condition depends on tnext. This should be possible right now in 0.6.0 (at least not in a straight-forward way) as you mention yourself. But I think there should be a way to do what you want in the newest version that perhaps would not run into the same problems. The idea I had in mind would be to add an extra variable to the state of your differential equation that keeps track of the time. So the vector field for your ODETerm would look something like this:
def vf(t, y, args):
    t, x = y
    x_out = ...
    t_out = 1
    return (t_out, x_out)

Indeed I envisaged this possibility, though I fear that it would make the computation of vf more expensive, when I'm working on a numerical solver where rapidity of execution is key. So this is maybe not the best solution for me.

@etienney: So tnext was removed deliberately. It's not clearly defined in general: for example when doing a root-find over the length of the final step, to determine the exact time at which a condition is triggered.
What's your use case for needing the length of a step?

My use case is the one of issue 462 where I made a MWE (2nd message). Let's say aux is the derivative of a function that I need to calculate as such ( For reasons of structure preservingness ). I need to have not the derivative but the integral of such derivative for my event so I need a dt.

I think if you want an integral then the best way to do this is to take advantage of the fact that diffeqsolve is itself computing the integral y(T) = y(T) + \int_0^t vector_field(t, y, args) dt! So augment your vector field with the quantity you would like to compute, and then pipe that value into your event function.
In particular you shouldn't need access to dt or to compute any kind of integral yourself.

Yes, this is indeed the obvious and perfect solution for me ! But as I said this is not possible.
The "real" y (not aux) i'm integrating sould be integrated via a Tsit5 runge-kutta method. Those methods have some hypotheses, one of which is the fact that the solution should be at least C^k (ie it's k-th derivative should be continuous) with k the order of the RK scheme (k=4 for Tsit5 as it's RK4 verifying it's solution with a RK5 if I understood well). The aux i'm integrating has for its derivative the absolute value of something, which doesn't showcase this property.
As such the solver goes crazy ( In practice, it can go crazy to the point of ouputing negative values for aux.. when aux starts at 0 and all its derivatives are absolute values of something, so clearly positive. And I'm not talking of some -1e-16 but some real -1e-4 ! )
So this was indeed my first try, but I moved away from it, and it motivated my previous issue.

@cholberg: indeed, removing this was deliberate (and despite our backward compatibility layer, the break here is the reason I bumped the minor version to 0.6.0, rather than continue down 0.5.x). The state object we were passing is an internal abstraction that isn't stable from release to release -- at times we may add or remove fields. It's also not clearly defined when doing a root find to find an event.
If there's any additional information we could reasonable be forward to the event, that we aren't at the moment, then I think that should become an additional **kwarg?
WDYT?

Sorry, totally missed this. I've been away on holiday for a bit. But yea, I think that makes a lot of sense. Adding an extra **kwargs should be an easy change.

As such the solver goes crazy

Do you mean with a fixed step size (the conditions of the RK method are not method and so it does numerically iffy things) or with an adaptive step size (the step size controller struggles due to the aux not being Ck)?
If the former then the appropriate thing to do would be to write your own solver (subclass AbstractSolver), wrapping together e.g. Tsit5 and Euler. Apply the former to y and the latter to aux.
If the latter then you can pass a PIDController(norm=...) that excludes aux from consideration when determining how to compute step sizes.

It is a little bit both, ie I'm using an adaptative step size, but the problem does not come from the step size controller struggling due to aux not being Ck but rather that

the conditions of the RK method are not met (the word you intended to choose right? you wrote method so i'm unsure) and so it does numerically iffy things
But yeah I can indeed modify my code to work with my own solver, then updating my code to fit the 0.6.0 indeed... I'll see if I ever find a simpler solution but thanks for this one in any case !!


[bazel] pwrmgr_testutils 2 keymgr_functest deps

Signed-off-by: Drew Macrae<EMAIL_ADDRESS>

No worries
On Thu, Jan 27, 2022 at 6:24 PM Matute @.***> wrote:

@.**** approved this pull request.
Thanks for fixing this... I missed it somehow.
LGTM
—
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/10419#pullrequestreview-865545602,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKQHJD6NXSCNGROPCB4R63UYHH2HANCNFSM5M7BRWHA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


Navigating away from a view with update-meta overwrites doesn't return to default values

If you overwrite default meta values from within a view; navigating off of that view to one without any update-meta does not return the page meta values to their original values.
For example, if the default title tag in my template is set to:
<title>My Lovely Company</title>

... and I overwrite that title from within the /contact view:
<update-title title="My Lovely Company | Contact us"></update-title>

When I navigate away from the /contact view to a view without any overwrites, the DOM title remains:
<title>My Lovely Company | Contact us</title>

Is this intended behaviour? In which case, it requires that all views that can make do with the default meta data have their own update-meta overwrites. Subsequent app wide changes to the default meta data will then need to be updated in all the 'vanilla' views also.

@jonnykates — You are correct, that is indeed how it works.
Adding an <update-title> element to a page or view instructs Angular to update the title. So if you don't instruct Angular to change it, it will remain untouched (even if you navigate away).
Sometimes this is desired behavior. Sometimes it is not.
In your case you would indeed have to update the title in all views.
If anyone has a proposal on how we can express such an intent in a declarative way (from the view) so that we could add it as a feature to this library (as I assume that others will be in similar situations), I would be happy to consider it.
Thanks for your feedback @jonnykates!

What about a  directive (and so on) to use in the views you don't want to keep a custom title, to avoid repeating the same data over and over? That might solve the problem.

@Sithdown — Interesting idea. And by "reset", you mean you would restore the original value that was in the original markup?

@jvandemo Yes, like that.
But, I have been thinking about it, and I'm not sure my suggestion makes sense with nested views.
If using nested views (ui-router), I think the values should default to the first/topmost view in the hierarchy when using a "reset". Something like this:
Current view directives define the meta tags and title.
If no directives are set, the data should be get from the view the current view inherits from.
If the current view has a reset, it should inherit from the topmost view and not its direct parent.
If using multiple views loaded at once from the same state, the behaviour should not be defined. Whatever gets parsed the last is what is kept. This should be documented, as to avoid using meta/title tags on views that are loaded simultaneously, e.g, a side view and a detail view both inheriting from a main state.

@Sithdown — Ideally the angular-update-meta directives should not be concerned with external dependencies such as the router (ui-router or ngRoute).
It's a tough one to crack, especially in an non-opinionated way.
Really appreciate your feedback though! 👍

same problem here

This is not an issue with this library and should be tackled in the consuming application.
This library provides the ability to set meta values but has no ability to determine what the actual values should be, because that depends on the architecture of the consuming application.
To tackle this problem, the consuming application should determine the values and set them accordingly. Thanks!

Sure, I just have one question that I haven't been able to answer. When google crawls a page built with angular, does google reload the page everytime the bot visit a new page, or does the bot uses angular to navigate between views so he doesn't really reload the app each time?

@Eduardo-Julio — I'm not familiar with the actual inner workings of the Google crawler, but my guess would be that it crawls each page separately and does not use the JavaScript router. Hope that helps!

This is off topic now, but @Eduardo-Julio - you might want to take a look at https://prerender.io/ for making sure bots actually get a rendered version of your page.

Thanks for your help!


Karta Map Marker Links Not Switching Map

When placing a Karta marker on a map in the Karta module, clicking on the marker title link doesn't cause the map to switch.
Note: I think the root problem was that with the change from hash to query notation, Map.KartaMarker.prototype.loadContent wasn't updated.

Thank you for reporting this bug. I will fix this.

Fixed with a3f4c8ab47db717e7eb9c670aece5752c31a8f1f


Documentation v0.5.0

Describe the following features in documentation:

[ ] Remote data source (list of URLs to create an annotation task)
[ ] Load/Dump annotations in different formats
[ ] Linear interpolation for a single point
[ ] Video frame filter
[ ] Auto annotation (link on the cvat/apps/auto_annotation, a couple of examples)

Please also describe the Dataset Repository feature better. Specifically how the credentials for the repo access can be configured.


Portable update

It would be nice if VSCode portable mode would automatically update and ask to restart similarly to the standard installer version of VSCode instead of needing to download a new ZIP and do it all manually.

Duplicate of #56326


v2

What's new

More utilities for CSS properties
Uses verbose naming convention for textAlign, alignItems, justifyContent, flexWrap, and other CSS properties
style and responsiveStyle utilities now accept a getter argument for converting values
New borders utility that normalizes the API with other styled-system utilities
Rewritten with ES module syntax
DRYer code base for utilities like fontSize, width, and color
The repo has been reorganized as a monorepo

Breaking

The cleanElement utility is now a separate package, removing the react dependency from the core library
The flexWrap utility now expects a string value for its prop (previously a boolean)
The borderWidth utility has been replaced with the borders utility
The borderTop, borderRight, borderBottom, and borderLeft props no longer accept boolean props, but follow the same convention as other utilities
The default spacing scale has changed to [ 0, 4, 8, 16, 32, 64, 128, 256, 512 ] (this only affects usage without a custom theme.space provided
Number values for breakpoints are now converted to px instead of ems to better match the rest of the library
The theme utility has been renamed to themeGet (alternative names under consideration)
Removes removeProps utility
Removes idx utility
Removes legacy responsiveStyle arguments API

Shims for breaking changes
To make migration easier, some breaking changes will continue to work as intended or similarly:

justifyContent is aliased to the justify prop
textAlign is aliased to the align prop, though this may cause unexpected behavior when used with the alignItems prop
alignItems is aliased to the align prop, though this may cause unexpected behavior when used with the textAlign prop
flexWrap is aliased to the wrap prop, but a string value of wrap or nowrap should be provided. (a shim to convert boolean true values to wrap has been added as well)
borderWidth now works similarly to the new borders utility, which will continue to work for most use-cases
The themeGet utility is aliased to a theme export

New utilities

fontFamily
display
minWidth
height
maxHeight
minHeight
size (width & height)
alignContent
order
borders
backgroundImage
backgroundSize
backgroundPosition
zIndex
top
right
bottom
left

Fixes #82

I'd strongly encourage you to compile dist files with rollup to achieve a flat bundles (which should result in less code included in consumers' apps) and distribute both main and module entries (latter for treeshake-ability). If you want I can set up this tooling.

@Andarist sorry that's not something I want to introduce to this library at the moment. A lot of the work here was to help simplify the code base for outside contributors, and I feel that adding more build setup sort of goes against that, especially for such a small utility library like this

@jxnblk - under utils you have propTypes with the key of 'responsivePropType', and under responsiveStyle function you reference propTypes.responsive

@Andarist sorry that's not something I want to introduce to this library at the moment. A lot of the work here was to help simplify the code base for outside contributors, and I feel that adding more build setup sort of goes against that, especially for such a small utility library like this

I don't feel slightly different build tooling would be a barrier for outside contributors.

most contributors are focused on the code and not the surrounding tooling - if we make it work, noone will even notice it. And it's not like you have no tooling at the moment
rollup is quite standard tool at the moment, used by numerous libraries and its config is straight-forward

As the author you are of course entitled to decide whatever you feel is right, I'd only want to raise this concern, because, for such a modular library as this, the improved tooling would give users real benefits and I can prepare demons backing that statement with numbers if you want.

@jxnblk - another suggestion: adding the getter along with pseudo:
apply a getter key just like numberToPx, Moved th variable outside of loop, apply the getValue function which allows the removal of the conditional PX conversion at the end.
export const pseudoStyle = (pseudoclass, prop) => (keys = {}) => props => {
    const style = props[prop || pseudoclass]
    const numberToPx = keys.numberToPx || {}
    const getters = keys.getter || {}
    const th = fallbackTheme(props)
    for (let key in style) {
        const toPx = numberToPx[key]
        if (!keys[key] && !toPx) continue
        const themeKey = [keys[key], style[key]].join('.')
        style[key] = getValue(get(th, themeKey, style[key]), getter, numberToPx)
    }
    return {
        ['&:' + pseudoclass]: style
    }
}

@JoshRosenstein that's a great idea, thanks! I should probably make the argument for pseudoStyle follow the other utilities as well


[NFC] Moved DetectRocm calls to constructor of ExecutionContext

Implements #2289

Hi @DrizztDoUrden this is triggering some strange issues in CI:
[2023-08-02T21:03:43.755Z] /var/jenkins/workspace/s_MIOpen_ddu_private-detect-rocm/fin/src/include/tensor.hpp:30:5: warning: 'HIP_PACKAGE_VERSION_FLAT' is not defined, evaluates to 0 [-Wundef]

[2023-08-02T21:03:43.755Z] #if HIP_PACKAGE_VERSION_FLAT >=<PHONE_NUMBER>ULL

[2023-08-02T21:03:43.755Z]     ^

[2023-08-02T21:03:47.689Z] In file included from /var/jenkins/workspace/s_MIOpen_ddu_private-detect-rocm/fin/src/main.cpp:29:

[2023-08-02T21:03:47.689Z] /var/jenkins/workspace/s_MIOpen_ddu_private-detect-rocm/fin/src/include/conv_fin.hpp:211:9: error: 'DetectRocm' is a private member of 'miopen::ExecutionContext'

[2023-08-02T21:03:47.689Z]     ctx.DetectRocm();

[2023-08-02T21:03:47.689Z]         ^

If HIP_PACKAGE_VERSION_FLAT is not defined in the scope, why it passed previous CI runs?

@junliume

If HIP_PACKAGE_VERSION_FLAT is not defined in the scope, why it passed previous CI runs?

Because this is just a warning.
Note that this happens during fin build. IIRC we do not use fin in our tidy checks; fin has its own Jenkinsfile (and its own tidy check). Why it does not catch the problem like this is another story. <config.h> must be included before using HIP_PACKAGE_VERSION_FLAT in fin/src/include/tensor.hpp. I highly recommend fixing both issues in fin. @cderb @JehandadKhan

I'm looking into resolving the warning from HIP_PACKAGE_VERSION_FLAT.
It looks like moving DetectRocm caused some breakages in fin as well. It appears that the solution is to simply remove these lines?

@cderb Exactly. What is the process of updating both fin and MIOpen? It seems like we can't commit changes in fin without prior changes in MIOpen and vice versa 🤔

@atamazov this time lets change the fin branch here, then we can redirect it back to develop once the repos are aligned.
If you use this fin branch for the submodule, I believe we can pass the CI: cerb/detect_rocm_private

@DrizztDoUrden FYI ⬆


Example not working

Example provided in the doc https://oras.land/client_libraries/go/ is not working
package main

import (
    "context"
    "fmt"

    "github.com/containerd/containerd/remotes/docker"
    ocispec "github.com/opencontainers/image-spec/specs-go/v1"

    "oras.land/oras-go/pkg/content"
    "oras.land/oras-go/pkg/oras"
)

func check(e error) {
    if e != nil {
        panic(e)
    }
}

func main() {
    ref := "localhost:5000/oras:test"
    fileName := "hello.txt"
    fileContent := []byte("Hello World!\n")
    customMediaType := "my.custom.media.type"

    ctx := context.Background()
    resolver := docker.NewResolver(docker.ResolverOptions{})

    // Push file(s) w custom mediatype to registry
    memoryStore := content.NewMemoryStore()
    desc := memoryStore.Add(fileName, customMediaType, fileContent)
    pushContents := []ocispec.Descriptor{desc}
    fmt.Printf("Pushing %s to %s...\n", fileName, ref)
    desc, err := oras.Push(ctx, resolver, ref, memoryStore, pushContents)
    check(err)
    fmt.Printf("Pushed to %s with digest %s\n", ref, desc.Digest)

    // Pull file(s) from registry and save to disk
    fmt.Printf("Pulling from %s and saving to %s...\n", ref, fileName)
    fileStore := content.NewFileStore("")
    defer fileStore.Close()
    allowedMediaTypes := []string{customMediaType}
    desc, _, err = oras.Pull(ctx, resolver, ref, fileStore, oras.WithAllowedMediaTypes(allowedMediaTypes))
    check(err)
    fmt.Printf("Pulled from %s with digest %s\n", ref, desc.Digest)
    fmt.Printf("Try running 'cat %s'\n", fileName)
}

output :
./oras-push.go:30:28: undefined: content.NewMemoryStore
./oras-push.go:34:23: undefined: oras.Push
./oras-push.go:40:26: undefined: content.NewFileStore
./oras-push.go:43:25: undefined: oras.Pull

do we have any working example or I'm doing something wrong?

The code examples on oras.land are outdated. We are working on the website.
To use the latest version of oras-go, please refer to the examples linked at https://github.com/oras-project/oras-go#v2-stable

Should the website pull docs from the project sites? It would be a lot easier to keep it in sync.


Stored procedures

Stored procedures are not supported?

Supported all mysql statements, amy is just a wrapper of  mysql C client.
If you still had doubt, you can run your procedures with the native mysql_real_query() C API to check.


More generic env-excavation

Now with parameterized types!
See the changes in README.rst to see the new API that this provides. You can still use all the old functions, so it's not a breaking change, but I think it'll make things more friendly.
It also includes incidental documentation fixups, including fixing a lie about env_int which claimed it took a separator argument.
Also, I made the ordering of the kwargs consistent, which shouldn't break anything—I hope people were using them kwargily, and not positionally. But it needed to happen.
Have a cute animal, IF YOU DARE.

Closing in favor of one on the main fork.

Closing in favor of one on the main fork.


fix: annotate nodes for reboot before aborting due to blocked

This PR moves the checking of "reboot blockers" (e.g., matching podSelectors running on the node to-be-rebooted) further down in the conditional reboot flow so that those checks happen after we (conditionally) annotate the nodes.
This enables the following when a reboot is detected (by default the presence of the /var/run/reboot-required file):

If --annotate-nodes is true, we annotate the nodes with the following annotations:

"weave.works/kured-reboot-in-progress" (indicates that this node will be rebooted at some point in the near future)
"weave.works/kured-most-recent-reboot-needed" (marks a timestamp of when this need for reboot was detected by kured)

After we annotate nodes, add a "prefer no schedule taint" to communicate a preference (though not a strict requirement) to the scheduler not to consider this node for future pod scheduling
We check to see if any prometheus or pod selector blockers prevent an immediate reboot, if so we short-circuit and requeue for a later reboot attempt when blockers and give the green light
If we're not blocked, we cordon+drain node
We reboot

I'm simplifying a bit above, there is a bit more complexity, but the key point is that we are now marking "this node is definitely going to be reboote" prior to blockers. This allows other, complementary tooling to know about the state of the node ("gonna be rebooted soon") and do things like extra-manual stateful application migration off of that node, add additional taints to better prevent future scheduling, etc.
Fixes #702

cc @timo-42

/assign @ckotzbauer

@jackfrancis @ckotzbauer Please merge this PR.

We're just discussing if this should land now right before the upcoming 1.13.0 release.


name tweak  GO:0072766 centromere clustering at the nuclear envelope

Can this term  (and children) be named
GO:0072766 centromere clustering at the mitotic nuclear envelope
(it is defined  and positined mitotically).
There is also some clustering in meiosis, but I think its   in a lsightly different context  and I want to avoid future confusion.
Thanks!

Done.


Building multiverse issues "incorrect string value" warnings

E   _mysql_exceptions.Warning: (1366, "Incorrect string value: '\xE2\x88\x922: ...' for column 'search_text' at row 1")
To repro bump SCHEMA_VERSION and run anything.

On prod:
mysql> SELECT    COLUMN_NAME,   TABLE_NAME,   CHARACTER_SET_NAME,   COLUMN_TYPE   COLLATION_NAME FROM information_schema.COLUMNS WHERE column_name = 'search_text';
+-------------+------------+--------------------+----------------+
| COLUMN_NAME | TABLE_NAME | CHARACTER_SET_NAME | COLLATION_NAME |
+-------------+------------+--------------------+----------------+
| search_text | face       | utf8               | longtext       |
+-------------+------------+--------------------+----------------+
1 row in set (0.01 sec)

On dev:
mysql> SELECT    COLUMN_NAME,   TABLE_NAME,   CHARACTER_SET_NAME,   COLUMN_TYPE   COLLATION_NAME FROM information_schema.COLUMNS WHERE column_name = 'search_text';
+-------------+------------+--------------------+----------------+
| COLUMN_NAME | TABLE_NAME | CHARACTER_SET_NAME | COLLATION_NAME |
+-------------+------------+--------------------+----------------+
| search_text | face       | utf8mb4            | longtext       |
+-------------+------------+--------------------+----------------+
1 row in set (0.07 sec)

I wonder if default charset is not set correctly on prod.
I'm going to try explicitly running:
SET NAMES utf8mb4

before running the table creation stuff.

Using SET NAMES didn't work.
mysql> SELECT    COLUMN_NAME,   TABLE_NAME,   CHARACTER_SET_NAME,   COLUMN_TYPE   COLLATION_NAME FROM information_schema.COLUMNS WHERE column_name = 'search_text';
+-------------+------------+--------------------+----------------+
| COLUMN_NAME | TABLE_NAME | CHARACTER_SET_NAME | COLLATION_NAME |
+-------------+------------+--------------------+----------------+
| search_text | face       | utf8               | longtext       |
+-------------+------------+--------------------+----------------+
1 row in set (0.01 sec)

Prod:
mysql> SELECT @@character_set_server;
+------------------------+
| @@character_set_server |
+------------------------+
| utf8                   |
+------------------------+
1 row in set (0.00 sec)

So that's the heart of the problem. We can change the server setting but I'm going to make the multiverse not care what it is set to.

e28e21d.

mysql> SELECT    COLUMN_NAME,   TABLE_NAME,   CHARACTER_SET_NAME,   COLUMN_TYPE   COLLATION_NAME FROM information_schema.COLUMNS WHERE column_name = 'search_text';
+-------------+------------+--------------------+----------------+
| COLUMN_NAME | TABLE_NAME | CHARACTER_SET_NAME | COLLATION_NAME |
+-------------+------------+--------------------+----------------+
| search_text | face       | utf8mb4            | longtext       |
+-------------+------------+--------------------+----------------+
1 row in set (0.00 sec)

mysql> SELECT * FROM db_version;
+---------+
| version |
+---------+
|      83 |
+---------+
1 row in set (0.00 sec)


MediaArea.MediaInfo.GUI version 23.04

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.
Resolves #108271

Microsoft Reviewers: Open in CodeFlow

Set Aligning Release Notes.
ReleaseNotes: |-
Version 23.04, 2023-04-26

MXF: support of SMPTE ST 381-4 (AAC in MXF)
DTS: show MA or HRA tip in commercial name for DTS:X
DTS: detection of DTS:X not lossless
APT-X100 a.k.a. Cinema DTS: initial support
Matroska: support of HDR10+
MP4: more information about thumbnails
ID3v2: more information about thumbnails
VP9: initial support, for more information about chroma subsampling
AWS S3: support for reference files with AccessID:SecretKey@URL
x Windows installer: fix crash with Windows 10/11 having ASLR enabled (NSIS update)
x AWS S3: fix errors with some special chars in SecretKey
x AWS S3: fix random credential issues with non geolocated URLs
x DTS: fix freeze with some DTS-HD not DTS:X files
x MPEG-TS: fix crash in HEVC_timing_and_HRD
x AAC: fix samples per frame with SBR streams
x FLAC: fix missing Tbc Tbr in ChannelLayout


Update Assembly Sintax (for NASM)

A major syntax update, which was previously extremely incomplete, is now complete

Any feedback? If I did something wrong I would like to know the problem...

Any feedback? If I did something wrong I would like to know the problem...

https://github.com/zyedidia/micro/issues/2956

Any feedback? If I did something wrong I would like to know the problem...

#2956
I would also recommend you to make screenshot "before/after" it will make it easier for reviewers. Reviewer won't go way just because feels that needs much work in comparing. It can have small benefit but it can have it...

Since I've added a lot of keywords, it's going to be hard for me to do a complete "before" and "after". So I'm going to send here a generic "before" and "after" print that covers several points, but not all.
BEFORE

AFTER


[BUG] Using PyPI with GitHub repository Poetry pyproject.toml results in 'NoneType' object error for format_dependencies

Describe the bug
Thank you for the great efforts with this project! I noticed a bug which appears to be reoccurring or occurring similarly to #455 and #461. The error occurs when attempting to use Grayskull from a GitHub repository which leverages pyproject.toml files. Specifically (and maybe differently from the earlier issues) I'm seeing this occur with pyproject.toml files of the Poetry variety.
Please don't hesitate to let me know if I've done something out of alignment with what Grayskull expects or supports (I may just be doing things completely wrong!).
To Reproduce
Steps to reproduce the behavior:
I created a simple demonstration repository which may be found here and is referenced below: https://github.com/d33bs/test-grayskull .

Attempt to run grayskull pypi https://github.com/d33bs/test-grayskull
Witness the error:

...
File ".../python3.9/site-packages/grayskull/utils.py", line 165, in format_dependencies
    if deps_name.replace("-", "_") == name.replace("-", "_"):
AttributeError: 'NoneType' object has no attribute 'replace

Expected behavior
I'd suggest some combination of the following possible solutions:

A more descriptive error (mentioning what is required from the project metadata).
Documentation covering the expected fields within pyproject.toml files (if this is where the error stems from).
A successful build based on these types of pyproject.toml files.

Environment:

MacOS
Python 3.9
Poetry 1.6.1
Grayskull 2.5.0

oh ok, that seems to be a bug indeed. Gonna take a further look and add it to my backlog
Thanks for reporting it! :)

Thank you @marcelotrevisani !

Hi all,
I am having the same error now. Is there any update so far? Thank you!

Hey, I am in the process of fixing this and all of your suggested solutions are great!
I just don't have much time to do it all, but indeed it would be great.
Can I break down your issue into others please?
For instance, I would like to create two more issues for:

A more descriptive error (mentioning what is required from the project metadata).
Documentation covering the expected fields within pyproject.toml files (if this is where the error stems from).

So, at least, I can keep track of this. The last bit is related to the fix I am doing.

This issue was fixed with #503 as well
I was able to generate
grayskull pypi https://github.com/d33bs/test-grayskull

{% set name = "test-grayskull" %}
{% set version = "0.0.1" %}

package:
  name: {{ name|lower }}
  version: {{ version }}

source:
  url: https://github.com/d33bs/test-grayskull/archive/v{{ version }}.tar.gz
  sha256: 98d81a0d5d0e2f5c47b113a4083fc5bdab358f0440568d3bd5dd3d6bd4bb2d9f

build:
  noarch: python
  script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
  number: 0

requirements:
  host:
    - python
    - poetry-core
    - pip
  run:
    - python >=3.9,<3.13
    - pandas >=2.1.1,<3.0.0
    - numpy >=1.26.0,<2.0.0

test:
  commands:
    - pip check
  requires:
    - pip

about:
  license: Apache-2.0
  license_file: LICENSE

extra:
  recipe-maintainers:
    - marcelotrevisani

I am generating version 2.5.1 that should have this fix

Thanks @marcelotrevisani ! Does the fix relate to a specific PR?

yup, this one
https://github.com/conda/grayskull/pull/503
I fixed another bug and this one as they were simple


Support env file min_version of genesis

Genesis environment files can now specify the minimimum version of
Genesis that is required to read it.  This is automatically populated
when kits use the new genesis_config_block helper and specify a
minimum verison required by the kit, or setting $GENESIS_MIN_VERSION
prior to calling that helper..  It can also be expicitly stated by
specifying genesis.min_version or params.genesis_version_min in the
environment file.
Furthermore, the deprecation warning for not using genesis block for
the values in params that were moved to genesis have been delayed to
a future version, so that detection of kit and env depencency checks can
be in the wild for some time.

No, those changes were never released.

Rebased for merging


Add SSH key generation

This should help with #852. We no longer would need to shell out to ssh-keygen.

Nice!
This needs a godep save followed by a git add Godeps to update and vendor the crypto/ssh depends.
I'm getting prompted for docker@localhost and<EMAIL_ADDRESS>passwords when creating virtualbox and DO machines.

@ehazlett Done.

Rockin' -- definitely want to test this out when I get a chance

I will test this again as soon as I get back and have access to my windows machine as well :)  Thanks!

@ehazlett can we merge this? :)

@sthulb testing today :)

Code looks pretty good.
I've been testing this today (tried VirtualBox and EC2) and it's working seamlessly so far.

LGTM


minor: add human eval

Motivation

Modifications

Checklist

[ ] Format your code according to the Contributor Guide.
[ ] Add unit tests as outlined in the Contributor Guide.
[ ] Update documentation as needed, including docstrings or example tutorials.

@zhyncs I think the human eval scores should be good. Can we merge this?

Let me update the code

ref https://github.com/sgl-project/sglang/actions/runs/11624964385/job/32374303654


cilium: transparent encryption, kube-proxy services may use incorrect sport

With encryption enabled kube-proxy services may hit a case where an icmp unreachable error happens,
17:04:13.410974 IP <IP_ADDRESS>.9421 > <IP_ADDRESS>.53: 9351+ AAAA? cilium-etcd-client.kube-system.svc.cluster.local. (66)
17:04:13.411033 IP <IP_ADDRESS>.9422 > <IP_ADDRESS>.53: 12894+ A? cilium-etcd-client.kube-system.svc.cluster.local. (66)
17:04:13.413912 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP <IP_ADDRESS> udp port 9422 unreachable, length 166
17:04:13.414121 IP <IP_ADDRESS> > <IP_ADDRESS>: ICMP <IP_ADDRESS> udp port 9421 unreachable, length 195

Currently iptables rules to match on encryption/decryption mark is only handled in Cilium iptables chains. However, this doesn't prevent us from hitting a kube-service iptables entry incorrectly. The fix is to move mark matching + ACCEPT action rules out of Cilium chains and it to main tables.
Even with above fix however still seeing a sport rewrite. Debugging.

https://github.com/cilium/cilium/pull/7146

Backports merged and released in 1.4.1
https://github.com/cilium/cilium/pull/7152


WIP: Adds swig include directory to command line

This PR may need more testing by I ran into issues when trying to use swig 4.0.0 (current master of the repo) and this patch addressed the problem).

@thewtex Pushing this branch here so it does not get lost.

@fbudin69500 thanks!


Consider non-ASCII characters in HTML case regex

Fixes https://github.com/dotnet/razor/issues/10844.
I've replaced [a-z] with \p{Ll} (any lowercase letter) and [A-Z] with \p{Lu} (any uppercase letter).
Note that this is technically a breaking change, I'm not sure how we feel about that.

Note that this is technically a breaking change

What is something that would break with this change?

From the issue, users with a component named TestÄh currently need to use a tag with <vc:testäa>, but after the change they would need to use <vc:test-äa>. Until they make the change in their source, they'd lose the functionality of the view component and the tag would simply be rendered to Html and presumably ignored by the browser.

As David says. Plus this also affects normal TagHelpers (not just ViewComponent tag helpers) - if users don't specify the HtmlTargetElement explicitly, it's derived from the TagHelper class name in the same fashion.

@chsienki, @jaredpar, @DustinCampbell, @danroth27 for their thoughts. I'm inclined to won't fix this bug; it's been around for a very long time, and we don't have a good way of communicating the change to users in the form of compilation errors. It's also another case where runtime compilation would probably produce different results, and there'd be no way to get equivalent behavior between runtime and non-runtime compilation.

We could also tie the breaking change to RazorLangVersion. But I agree it does not seem worth it.

I'm supportive of not making this change given the breaking change impact.

Hi, wouldn't it be possible to generate tag helpers with both the correct name and the current incorrect name? This would correct the bug while preserving backwards compatibility for those that rely on the current tag names.

Yes, I think that would work, but at the cost of more complexity in the implementation.

The problem my team is currently having is that the generated tag helpers for view components are incorrectly named for our Swedish domain specific words, so we need to either contort our view components names or manually write our own tag helpers (because HtmlTargetElement doesn't work on view components).
It's manageable but it's unnecessary friction and surprising when it doesn't work as it's supposed to.

Let me reopen the original issue with this alternative so it will get triaged again.

@DavidZidar Instead of using View Components, could you use Blazor components with the Component Tag Helper instead? If not, what would be needed to enable you to do so? Ideally, we'd like to align ASP.NET Core on a single component model.

@danroth27 We have a fairly large application that is built on top of Optimizely CMS where all the Optimizely Blocks are view components (because Optimizely requires this), so we use view components for non-block components as well to be able to reuse a lot of common code. I may be wrong but I don't think HTML helpers and tag helpers work in Blazor components?
Also, we have a couple of filters that need to wrap view components (to perform error handling and authorization policies and so on) so I had to find a way to make that work with view components because that is not something that is supported by ASP.NET by default. Can this be done with Blazor components? This is not something that I have investigated.

I may be wrong but I don't think HTML helpers and tag helpers work in Blazor components?

That's correct.

Also, we have a couple of filters that need to wrap view components (to perform error handling and authorization policies and so on) so I had to find a way to make that work with view components because that is not something that is supported by ASP.NET by default. Can this be done with Blazor components?

Nope, this also isn't something we currently support.
Thanks for sharing these additional details!


Update to use "prop-types" dependency

Description
In the console there was an annoying warning from React:

"Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead."

This PR adds the prop-types dependency to the project, and updates the references.
https://github.com/facebook/prop-types
Changes
Files changed

Mixin.js (updating references)
main.js (updating references)

Tests/Examples
Tests are passing, examples run fine

You might want to take a look at #439 that also fixed those issues but might lead to a more elaborate rewriting apparently.

Ah I see (I didn't try and tackle the createClass issue as it looked like a rewrite as you mentioned), maybe i'll jump onto that branch and see if there's anything I can help with 😄  cheers!

🏆
I really wish this would be merged in and accepted into master before the massive rewrite at #439 gets vetted. There is very little reason tolerate these warnings given the fix is so simple.

@drewlustro I'm in agreement, would be good to get rid of these annoying warnings for now, not sure when that massive rewrite is going to be merged ☹

@ottis and @drewlustro are you guys on the latest version? v0.19.5?


Logs are discarded on error

Crate
ibc
Summary of Bug
The current handlers' implementation discards logs when an error is encountered.
Version
v0.11.1

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Might be related -> https://github.com/cosmos/cosmos-sdk/issues/10618

Suggestion from @plafer (https://github.com/informalsystems/ibc-rs/pull/1838#discussion_r829168099) ->
pub fn deliver<Ctx>(ctx: &mut Ctx, message: Any) -> Result<(Vec<IbcEvent>, Vec<String>), Error>

We could create RouterOutput and RouterResult types, analogous to HandlerOutput and HandlerResult. This would make it more explicit that Vec represents the logs.
dispatch() would then return a RouterResult.

struct RouterOutput {
    events: Vec<IbcEvent>,
    logs: Vec<String>,
}

type RouterResult = Result<RouterOutput, Error>;


Translation of the word 'empty" for requiredif validation rule

Laravel Version: 9
PHP Version: 8.1.11

Description:
Error message with the word 'empty' which is not translated
Steps To Reproduce:
Add a validation rule for requiredif with a null value
required_if:content,null
I can use this : https://laravel.com/docs/9.x/validation#specifying-values-in-language-files
It's OK for a single validation rule.
I think  it would be better to add translation in laravel\framework\src\Illuminate\Validation\Concerns\FormatsMessages.php, in the function getDisplayableValue
        if (is_bool($value)) {
            return $value ? 'true' : 'false'; <=== Maybe add translation here for 'true' and 'false'
        }

        if (is_null($value)) {
            return 'empty'; <=== add the translation here
        }

Hello,
Yes, it's not really a bug.
I've tried :

__('empty')
$this->translator->get('empty')

but it returns everytime 'empty'.
Do you know which function to use ?


UI for batch action: delete, rename & drag category

Use case

User builds tokens without using "import"
Naming convention has not been fully determined
Categorization method has not been fully determined
User has to remove, edit & organize categories as they test different approaches

Curren method

Edit name, remove, organize in JSON file

Proposed Update

Rename & remove by clicking on the category name on the UI
Reorganize orders by click-drag on the category
Click-drag tokens in/out of a category

Bonus

Auto-fill or type-ahead suggestion on certain input fields (esp. typography where you have to insert several references).

So I think there's 3 features here:

refactor when renaming: covered in #247 and #211 and #165
sort tokens in ui covered in: #122
type ahead, something like react-mentions: https://react-mentions.vercel.app/ - could you create an issue for that? i tried something like this out locally but discarded due to it leading to a broken experience at times. Typeahead would be great, but at the same time a simple token chooser could be good already. like a color picker but for picking token values.

If it's OK with you I'd close this issue once the type ahead one is created?

@six7 All of this makes sense. The new update is awesome. Thanks for your hard work on this.
I made a new ticket for the token chooser. Please feel free to close this one.

Perfect, thank you for creating that issue. Will close this one, let's discuss in the other issues on each of these on their own


NoMethodError: undefined method `helper_method'

Just dropped decent exposure into a Rails 5.0.01 project. Added a simple expose :client in the top of a controller and it blew up with:
NoMethodError: undefined method `helper_method' for Api::V1::Clients::TagCategoriesController:Class

Could it be the namespaced controllers? I checked the documentation / issues, tried adding:
expose(:client, model: ::Client)

Without any luck.  I've used this gem perviously with Rails 4 + nested controller namespaces without issue.

@Rodeoclash I created a PR that will probably solve the problem, so let us know if this works with your app

👌
Fixed perfectly

This still occurs for me.  If I pass in current_client into any of the expose method param blocks, I still receive the same helper_method error that Rodeoclash:
ActionController::RoutingError (undefined method `helper_method' for KnowledgeBase::ContentsController:Class):
Im on Rails API <IP_ADDRESS> that was upgraded from a Rails 4 API project.  Also using Mongoid, although I don't think that would be related.

@gthorsen are you using the master branch version of the gem? This fix was not released in any new version of the gem yet.
It should be something like:
gem 'decent_exposure', github: 'hashrocket/decent_exposure', branch: 'master'

@vnegrisolo ahhh I am not, thanks for that, I thought it was.  Cheers.


Add distance to witnesses list

Issue: https://github.com/helium/explorer/issues/463
Added a distance to the right of the dbm measurement.

hey @RaymanRJ, thanks for doing this! I think you might have forked from an old branch or from something other than v2 (that's the branch that deploys to explorer.helium.com now), as we actually made this same change already! (good instincts 😄 )
e.g.:

so going to close this PR for now unless I'm missing something :)
thanks for contributing!


Engine parameter ignored when writing NetCDF4 if writing to a file handle.

What happened?
I tried to call ds.to_netcdf(f, engine="netcdf4", format="NETCDF4") and got an
ValueError: invalid format for scipy.io.netcdf backend: 'NETCDF4'

What did you expect to happen?
I expected the write to succeed.
Minimal Complete Verifiable Example
import numpy as np
import xarray as xr

arr_thr = np.random.random_sample((2, 100, 100))

x_var = np.arange(100)
y_var = np.arange(100)

ds = xr.Dataset(
    {
        "low_threshold": (["x", "y"], arr_thr[0], {"units": "dB"}),
        "high_threshold": (["x", "y"], arr_thr[1], {"units": "dB"}),
    },
    coords={
        "x_dist": (["x"], x_var, {"units": "m"}),
        "y_dist": (["y"], y_var, {"units": "m"}),
    },
)

with open("/tmp/test.nc", "wb") as f:
    ds.to_netcdf(f, engine="netcdf4", format="NETCDF4")

MVCE confirmation

[X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[X] Complete example — the example is self-contained, including all data and the text of any traceback.
[X] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[X] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output
Output exceeds the [size limit](command:workbench.action.openSettings?[). Open the full output data [in a text editor](command:workbench.action.openLargeOutput?1f881801-9039-4b0c-abe7-f26b42b290b9)
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In [9], line 2
      1 with open("/tmp/test.nc", "wb") as f:
----> 2     ds.to_netcdf(f, engine="netcdf4", format="NETCDF4")

File ~/mambaforge/envs/eiland-dev/lib/python3.10/site-packages/xarray/core/dataset.py:1882, in Dataset.to_netcdf(self, path, mode, format, group, engine, encoding, unlimited_dims, compute, invalid_netcdf)
   1879     encoding = {}
   1880 from ..backends.api import to_netcdf
-> 1882 return to_netcdf(  # type: ignore  # mypy cannot resolve the overloads:(
   1883     self,
   1884     path,
   1885     mode=mode,
   1886     format=format,
   1887     group=group,
   1888     engine=engine,
   1889     encoding=encoding,
   1890     unlimited_dims=unlimited_dims,
   1891     compute=compute,
   1892     multifile=False,
   1893     invalid_netcdf=invalid_netcdf,
   1894 )

File ~/mambaforge/envs/eiland-dev/lib/python3.10/site-packages/xarray/backends/api.py:1193, in to_netcdf(dataset, path_or_file, mode, format, group, engine, encoding, unlimited_dims, compute, multifile, invalid_netcdf)
   1189     else:
...
--> 138     raise ValueError(f"invalid format for scipy.io.netcdf backend: {format!r}")
    140 if lock is None and mode != "r" and isinstance(filename_or_obj, str):
    141     lock = get_write_lock(filename_or_obj)

ValueError: invalid format for scipy.io.netcdf backend: 'NETCDF4'

Anything else we need to know?

Is it possible to write to an open file object with netCDF4?
We are currently overwriting engine here but could raise an error if engine != 'scipy'
https://github.com/pydata/xarray/blob/58ab594aa4315e75281569902e29c8c69834151f/xarray/backends/api.py#L1174-L1175

I get the same issue with h5netcdf, so the issue isn't unique to netCDF4.


[KBFS-2417] De-duplicate prefetches

This rewrites prefetching. Design is detailed in KBFS-2417, and comments in code extensively detail the cases being handled.
Short story: all prefetches are now triggered and tracked in the primary blockPrefetcher.run() goroutine. There are no more goroutines spawned by the block retrieval queue.
Suggested review order:

prefetcher.go (you may need to view both the raw file and the diff)
block_retrieval_queue.go
prefetcher_test.go
everything else

🎉 congrats!

Nice cleanup! It seems the code is much easier to follow though now. Thanks! I'm still going through the code; I do have some questions for now to help myself understand: It seems completePrefetch is called when receiving a request from the prefetchRequestCh where prefetchStatus is FinishedStatus. Is this correct how every decrement happens (as described in comment for blockPrefetcher.run)? If so, where are we sending requests with pretchStatus=FinishedStatus?

@songgao: completePrefetch is one way decrements can happen. The other is decrementPrefetch, which happens on the first time we trigger a block for prefetching if it hadn't yet been triggered.
We send requests with prefetchStatus==FinishedPrefetch when they are retrieved from the cache and its status there is FinishedPrefetch. This allows us to short-circuit the subtree retrieval for sync'ed prefetch requests.

The other is decrementPrefetch

I see it's also applied under case reqInt := <-p.prefetchRequestCh.Out():, so looks like it's checked when a prefetch request comes in? I was under the impression that this would be something happening after a prefetch finishes. I must be missing something here!

@songgao: I'm not sure I understand your question.

Oh sorry; I'm trying to figure out the code path from when a block fetch is requested, to when the fetching is done and acknowledged by the prefetcher and the retriever, to get a big picture. I guess I should just spend more time following the code rather than asking confusing questions :)

Not at all, ask away! If something is confusing, then I need to put in comments that clarify it.

@strib: all feedback implemented: https://github.com/keybase/kbfs/pull/1197/files/1cec51069d67e3bc2d9987c86c92338d016b1152..5c77b230e97b19aeff09a03dffc5431af6814fd0

Cool, thanks!  Looking for a re-review on those parts?  From my POV, I'm good, but happy to look again if you want.

Maybe just take a look at channels.go


[WiP]: Add attributes, ifdefs to emitter.

This adds (* ... *) attributes and  `ifndef `else `endif` to the verilog emitter by extending the existing Description functionality. For motivation, see #941 and #687.
For attributes, the way it works is pretty similar to comments- just uses (* *) instead of //.
Ifdef is a little trickier. You need to add stuff both before and after the code of interest. Hopefully the way I've done it is correct. I'm curious if anyone has any thoughts about how I could make it better.
Another issue with the ifdefs: right now, they actually emit ifndef because it is easier to emit the alternative clause first rather than after the code. I think ideally you should be able to emit either an `ifdef or `ifndef.
I've augmented an existing test- if I get good feedback, I'll clean them up and add a bunch more test cases.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@grebe is this something you're still working on?

Yes, it's a TODO to split out attributes from ifdefs. I think ifdefs will take a while.