We need to switch the development branch to use python 3.

We are currently still building against python 2 on quartz and running the test suite using python 2. The third party libraries on quartz should be rebuilt with python 3 and the config site file updated. The CI should also be built with python 3.
We should remove the python 2 stuff at some later date once we have confidence that the python 3 stuff is solid. This may be in a few months.

@cyrush, @biagas I built the new third party libraries on quartz and built VisIt against it and ran the test suite and got quite a few failures.

There are a few random one off failures that need investigation
There were several failures with query output tests where a dictionary was output and it looks like things were reordered in the dictionary. Those may be rebaselines is that is expected, although I noticed one where something was missing. Would need to look at them all in detail to make sure there isn't an issue.
The simulation tests all exited with a zero exit code, so something might be amis
The movie making test failed. Since that involves scripts, perhaps there is an error there

How do you want to proceed? I can give you a tar file with the html output on the CZ.

@cyrush, @biagas I built the new third party libraries on quartz and built VisIt against it and ran the test suite and got quite a few failures.

There are a few random one off failures that need investigation
There were several failures with query output tests where a dictionary was output and it looks like things were reordered in the dictionary. Those may be rebaselines is that is expected, although I noticed one where something was missing. Would need to look at them all in detail to make sure there isn't an issue.
The simulation tests all exited with a zero exit code, so something might be amis
The movie making test failed. Since that involves scripts, perhaps there is an error there

How do you want to proceed? I can give you a tar file with the html output on the CZ.

Sounds like what I saw. You can give me the html output, I am willing to take a look at the results.
@cyrush, have the sim tests been passed through the py2to3 filter? Do the sim swig files need updating?

Sounds like what I saw. You can give me the html output, I am willing to take a look at the results.
@cyrush, have the sim tests been passed through the py2to3 filter? Do the sim swig files need updating?

@biagas, @cyrush I gave you both the test results on the CZ.

@biagas, @cyrush I gave you both the test results on the CZ.

Thanks @brugger1.
I would say that the dictionary output is now sorted by key. Makes confirming the new pick results a bit challenging.
Overall I think the movie and sim tests are the big issues.

Thanks @brugger1.
I would say that the dictionary output is now sorted by key. Makes confirming the new pick results a bit challenging.
Overall I think the movie and sim tests are the big issues.

@brugger1, is there a log file of test output that I can have?

@brugger1, is there a log file of test output that I can have?

@biagas, @cyrush I gave both of you the log files on the CZ.

@biagas, @cyrush I gave both of you the log files on the CZ.

Thanks, that wasn't what I was looking for. I'm thinking of a log file that captures all the test output. I generate one when I run the tests, but I also use '--lessverbose' to capture more output.

Thanks, that wasn't what I was looking for. I'm thinking of a log file that captures all the test output. I generate one when I run the tests, but I also use '--lessverbose' to capture more output.

Here's the error output I saw on my run for cinema test:
>>> Traceback (most recent call last):
  File "/usr/WS1/kbonnell/Branches/Pyside_Take2/BuildPascal/bin/visitcinemamain.py", line 39, in <module>
    main()
  File "/usr/WS1/kbonnell/Branches/Pyside_Take2/BuildPascal/bin/visitcinemamain.py", line 33, in main
    cinema.Execute()
  File "/usr/WS1/kbonnell/Branches/Pyside_Take2/BuildPascal/bin/visitcinema.py", line 738, in Execute
    self.CreatePhiThetaDatabase()
  File "/usr/WS1/kbonnell/Branches/Pyside_Take2/BuildPascal/bin/visitcinema.py", line 1322, in CreatePhiThetaDatabase
    f.write('       "default":%d,\n' % ideg(theta[self.theta/2]))
TypeError: list indices must be integers or slices, not float

 - - - - - - - - - - - - - - -
  START:  Test script cinema-a.py

    BEGIN SECTION: Cinema spec A static camera
    Test case 'cinema_0_00' PASSED
    Test case 'cinema_0_01' PASSED
    Test case 'cinema_0_02' PASSED
    Test case 'cinema_0_03' PASSED
    BEGIN SECTION: Cinema spec A phi-theta camera
    Test case 'cinema_1_00' PASSED
    Test case 'cinema_1_01' PASSED
    Test case 'cinema_1_02' FAILED
Traceback (most recent call last):
  File "/usr/WS1/kbonnell/Branches/Pyside_Take2/visit/src/test/tests/hybrid/cinema-a.py", line 201, in <module>
    main()
  File "/usr/WS1/kbonnell/Branches/Pyside_Take2/visit/src/test/tests/hybrid/cinema-a.py", line 197, in main
    test1(db)
  File "/usr/WS1/kbonnell/Branches/Pyside_Take2/visit/src/test/tests/hybrid/cinema-a.py", line 158, in test1
    params = eval(json)
  File "<string>", line 7
    "theta": {
             ^
SyntaxError: unexpected EOF while parsing
>>>

Here's the error output I saw on my run for cinema test:
>>> Traceback (most recent call last):
  File "/usr/WS1/kbonnell/Branches/Pyside_Take2/BuildPascal/bin/visitcinemamain.py", line 39, in <module>
    main()
  File "/usr/WS1/kbonnell/Branches/Pyside_Take2/BuildPascal/bin/visitcinemamain.py", line 33, in main
    cinema.Execute()
  File "/usr/WS1/kbonnell/Branches/Pyside_Take2/BuildPascal/bin/visitcinema.py", line 738, in Execute
    self.CreatePhiThetaDatabase()
  File "/usr/WS1/kbonnell/Branches/Pyside_Take2/BuildPascal/bin/visitcinema.py", line 1322, in CreatePhiThetaDatabase
    f.write('       "default":%d,\n' % ideg(theta[self.theta/2]))
TypeError: list indices must be integers or slices, not float

 - - - - - - - - - - - - - - -
  START:  Test script cinema-a.py

    BEGIN SECTION: Cinema spec A static camera
    Test case 'cinema_0_00' PASSED
    Test case 'cinema_0_01' PASSED
    Test case 'cinema_0_02' PASSED
    Test case 'cinema_0_03' PASSED
    BEGIN SECTION: Cinema spec A phi-theta camera
    Test case 'cinema_1_00' PASSED
    Test case 'cinema_1_01' PASSED
    Test case 'cinema_1_02' FAILED
Traceback (most recent call last):
  File "/usr/WS1/kbonnell/Branches/Pyside_Take2/visit/src/test/tests/hybrid/cinema-a.py", line 201, in <module>
    main()
  File "/usr/WS1/kbonnell/Branches/Pyside_Take2/visit/src/test/tests/hybrid/cinema-a.py", line 197, in main
    test1(db)
  File "/usr/WS1/kbonnell/Branches/Pyside_Take2/visit/src/test/tests/hybrid/cinema-a.py", line 158, in test1
    params = eval(json)
  File "<string>", line 7
    "theta": {
             ^
SyntaxError: unexpected EOF while parsing
>>>

movie.py is missing () around a print statement that it writes out to a script file. line 99 on the develop version of the file.

movie.py is missing () around a print statement that it writes out to a script file. line 99 on the develop version of the file.

tests/hybrid/py_expr_script_00.vpe line 37 uses 'xrange', should be just 'range' ?

tests/hybrid/py_expr_script_00.vpe line 37 uses 'xrange', should be just 'range' ?

I'm making mods to scripts as I find the problems and if I know the fix. Shall I give them to you @brugger1? As I finish each one, or when I have worked through as many as I can?

I'm making mods to scripts as I find the problems and if I know the fix. Shall I give them to you @brugger1? As I finish each one, or when I have worked through as many as I can?

Sounds like there is more work to do.
This is one of the down sides of having to turn on several flags to get to the same config that we test ☹
I really wish more things defaulted to on.
-Cyrus
From: Kathleen Biagas<EMAIL_ADDRESS>Reply-To: visit-dav/visit<EMAIL_ADDRESS>Date: Wednesday, January 20, 2021 at 1:10 PM
To: visit-dav/visit<EMAIL_ADDRESS>Cc: Cyrus Harrison<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [visit-dav/visit] We need to switch the development branch to use python 3. (#5383)
Thanks, that wasn't what I was looking for. I'm thinking of a log file that captures all the test output. I generate one when I run the tests, but I also use '--lessverbose' to capture more output.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/visit-dav/visit/issues/5383#issuecomment-763948264, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAJDUHUBRD37X42NV6MET73S25BEBANCNFSM4WCZDEYQ.

Sounds like there is more work to do.
This is one of the down sides of having to turn on several flags to get to the same config that we test ☹
I really wish more things defaulted to on.
-Cyrus
From: Kathleen Biagas<EMAIL_ADDRESS>Reply-To: visit-dav/visit<EMAIL_ADDRESS>Date: Wednesday, January 20, 2021 at 1:10 PM
To: visit-dav/visit<EMAIL_ADDRESS>Cc: Cyrus Harrison<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [visit-dav/visit] We need to switch the development branch to use python 3. (#5383)
Thanks, that wasn't what I was looking for. I'm thinking of a log file that captures all the test output. I generate one when I run the tests, but I also use '--lessverbose' to capture more output.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/visit-dav/visit/issues/5383#issuecomment-763948264, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAJDUHUBRD37X42NV6MET73S25BEBANCNFSM4WCZDEYQ.

You can give them to me when you have worked through as many as you can.

You can give them to me when you have worked through as many as you can.

@cyrush, how should this line in makemovie.py line 292 be fixed?
The error message is
TypeError: can only concatenate str (not "bytes") to str
                s = s + os.read(fd_list[0][0], 100)

Does the os.read part just get wrapped in str() ?

@cyrush, how should this line in makemovie.py line 292 be fixed?
The error message is
TypeError: can only concatenate str (not "bytes") to str
                s = s + os.read(fd_list[0][0], 100)

Does the os.read part just get wrapped in str() ?

Does the os.read part just get wrapped in str() ?

That would certainly fix the error as in...
                s = s + str(os.read(fd_list[0][0], 100))

Does the os.read part just get wrapped in str() ?

That would certainly fix the error as in...
                s = s + str(os.read(fd_list[0][0], 100))

Thanks @markcmiller86. That's what I did. Now the movie test is hanging, so there must be another issue somewhere that isn't raising an obvious python3 error.

Thanks @markcmiller86. That's what I did. Now the movie test is hanging, so there must be another issue somewhere that isn't raising an obvious python3 error.

@brugger1 I've given you a tarball with changes that fix python 3 errors for py_expr test, cinema-a test, movie test. The movie test hangs for me, but that could be something to do with my pyside-build.  I will look into pluginVsInstall next.

@brugger1 I've given you a tarball with changes that fix python 3 errors for py_expr test, cinema-a test, movie test. The movie test hangs for me, but that could be something to do with my pyside-build.  I will look into pluginVsInstall next.

For queries tests:
scf.py
pick.py
conncomp.py
pickNamedArgs.py
queriesOverTime.py
I checked the failing tests (copied current vs baseline results to python3 and performed an equivalence test). They can all be rebaselined.

For queries tests:
scf.py
pick.py
conncomp.py
pickNamedArgs.py
queriesOverTime.py
I checked the failing tests (copied current vs baseline results to python3 and performed an equivalence test). They can all be rebaselined.

@cyrush, can you look into locus.py.
Here's the error message I see:
Traceback (most recent call last):
  File "/src/test/tests/hybrid/locus.py", line 42, in <module>
    import visit_writer
ImportError: dynamic module does not define module export function (PyInit_visit_writer)
>>>

@cyrush, can you look into locus.py.
Here's the error message I see:
Traceback (most recent call last):
  File "/src/test/tests/hybrid/locus.py", line 42, in <module>
    import visit_writer
ImportError: dynamic module does not define module export function (PyInit_visit_writer)
>>>

Maybe try self.p.stdin.write(bytes(cmd+"\n"),"utf_8")) based on...

Seems like a lot of extra work to write a simple string :(
Do we always want to use "utf_8"? Any instance where we would want "ascii"?
If default encoding is 'utf_8' does it need to be specified each and every time you want to encode a string as bytes?
I've seen some examples using 'encode' or 'decode' methods on the string.
Which is better?
What about this section of code, looking for a string in the output of readline?
     buf = sim.p.stderr.readline()
        print(buf)
        if "Command '%s'"%com in buf:
            keepGoing = False

Should 'buf' be decoded? Or the string 'encoded' ?

Maybe try self.p.stdin.write(bytes(cmd+"\n"),"utf_8")) based on...

Seems like a lot of extra work to write a simple string :(
Do we always want to use "utf_8"? Any instance where we would want "ascii"?
If default encoding is 'utf_8' does it need to be specified each and every time you want to encode a string as bytes?
I've seen some examples using 'encode' or 'decode' methods on the string.
Which is better?
What about this section of code, looking for a string in the output of readline?
     buf = sim.p.stderr.readline()
        print(buf)
        if "Command '%s'"%com in buf:
            keepGoing = False

Should 'buf' be decoded? Or the string 'encoded' ?

Are these changes on a branch we can attack together?
For some of these strings vs bytes issues, there are file mode open options that can solve them.
We shouldn't have to do too much manual encode / decode steps.

Are these changes on a branch we can attack together?
For some of these strings vs bytes issues, there are file mode open options that can solve them.
We shouldn't have to do too much manual encode / decode steps.

if @brugger1 doesn't have one already, I can get one started.

if @brugger1 doesn't have one already, I can get one started.

I just pushed the branch. There's not much on it, just the updated config site file. It's
task/brugger1/2020_01_19_upgrade_tpls

I just pushed the branch. There's not much on it, just the updated config site file. It's
task/brugger1/2020_01_19_upgrade_tpls

Great! So, do we branch off your branch, or just check it out? I will add some of the fixes I created yesterday that I know work.

Great! So, do we branch off your branch, or just check it out? I will add some of the fixes I created yesterday that I know work.

I'm not sure. It seems whatever is simpler.

I'm not sure. It seems whatever is simpler.

@biagas, have you made any changes. If not, I'll rebaseline the queries tests you mentioned.

@biagas, have you made any changes. If not, I'll rebaseline the queries tests you mentioned.

@brugger1  I was waiting for the build to finish so I can verify. Go ahead and rebaseline, and I will commit when you are done.

@brugger1  I was waiting for the build to finish so I can verify.

I added the fixes for py_exprs, cinema-a and pluginVsInstall tests.
Investigating hang with movie.py

I added the fixes for py_exprs, cinema-a and pluginVsInstall tests.
Investigating hang with movie.py

I investigated the databases/ffp.py failure and it was because I didn't copy libstripack.so to build/lib. This is a non-issue.

I investigated the databases/ffp.py failure and it was because I didn't copy libstripack.so to build/lib. This is a non-issue.

Looking at databases/FMS.py failure now.

Looking at databases/FMS.py failure now.

The databases/FMS.py failure was from a python conversion issue. I suspect this was added after the test suite was converted to python 3. I fixed the error and pushed the changes.

The databases/FMS.py failure was from a python conversion issue. I suspect this was added after the test suite was converted to python 3. I fixed the error and pushed the changes.

Regarding any conversion between Python 2/3, should we continue to try to ensure the resulting code works in both or just abandon Python 2 altogether?

Regarding any conversion between Python 2/3, should we continue to try to ensure the resulting code works in both or just abandon Python 2 altogether?

I looked at unit/launcher.py and the failure is
Traceback (most recent call last):
File "/usr/WS1/brugger/visit_dev_git/visit/src/test/tests/unit/launcher.py", line 143, in
output = FormatLauncherOutput(GetLauncherCommand([visit] + args))
File "/usr/WS1/brugger/visit_dev_git/visit/src/test/tests/unit/launcher.py", line 56, in GetLauncherCommand
ru = stdout.find("RUN USING")
TypeError: argument should be integer or bytes-like object, not 'str'
It looks similar to what @biagas encountered earlier with some proposed solutions. What did you go with?

I looked at unit/launcher.py and the failure is
Traceback (most recent call last):
File "/usr/WS1/brugger/visit_dev_git/visit/src/test/tests/unit/launcher.py", line 143, in
output = FormatLauncherOutput(GetLauncherCommand([visit] + args))
File "/usr/WS1/brugger/visit_dev_git/visit/src/test/tests/unit/launcher.py", line 56, in GetLauncherCommand
ru = stdout.find("RUN USING")
TypeError: argument should be integer or bytes-like object, not 'str'
It looks similar to what @biagas encountered earlier with some proposed solutions. What did you go with?

What did you go with?

Saw from @cyrush that we may need to check open() calls to ensure ascii rather than binary mode is active.

What did you go with?

Saw from @cyrush that we may need to check open() calls to ensure ascii rather than binary mode is active.

try:
ru = stdout.find("RUN USING".encode())

try:
ru = stdout.find("RUN USING".encode())

Also, launcher.py has some entries like 'string.replace' that need to be changed to 'str.replace'.

Also, launcher.py has some entries like 'string.replace' that need to be changed to 'str.replace'.

Regarding any conversion between Python 2/3, should we continue to try to ensure the resulting code works in both or just abandon Python 2 altogether?

It's not very hard to have code that supports both.
I'd opt for having both work.

Regarding any conversion between Python 2/3, should we continue to try to ensure the resulting code works in both or just abandon Python 2 altogether?

It's not very hard to have code that supports both.
I'd opt for having both work.

Yes, I saw the str.replace issue, as well as a few others.

Yes, I saw the str.replace issue, as well as a few others.

can you put up a draft PR for our branch? I think I can provide some feedback easily that way.

can you put up a draft PR for our branch? I think I can provide some feedback easily that way.

I'd opt for having both work.

I am inclined to agree. However, I think that means we should test both too. If we don't, for sure one will fall out of working order.

I'd opt for having both work.

I am inclined to agree. However, I think that means we should test both too. If we don't, for sure one will fall out of working order.

Maybe we can alternate nights running python2 on even numbered days and python 3 on odd numbered days

Maybe we can alternate nights running python2 on even numbered days and python 3 on odd numbered days

I fixed unit/launcher.py and pushed it. I also created a draft pull request.

I fixed unit/launcher.py and pushed it. I also created a draft pull request.

I believe we still have the following failures:
hybrid/movie.py
hybrid/locus.py
simulation/*.py

I believe we still have the following failures:
hybrid/movie.py
hybrid/locus.py
simulation/*.py

@brugger1 is correct, and I am working on the movie issue.

@brugger1 is correct, and I am working on the movie issue.

@cyrush, I was looking into the locus.py failure:
Traceback (most recent call last):
File "/src/test/tests/hybrid/locus.py", line 42, in
import visit_writer
ImportError: dynamic module does not define module export function (PyInit_visit_writer)

and looked at ./tools/data/writer/py_visit_writer.c
and found
#if __GNUC__ >= 4
/* Ensure this function is visible even if -fvisibility=hidden was passed */
PyObject * __attribute__ ((visibility("default"))) PyInit_visit( void )
#else
PyObject * PyInit_visit( void )
#endif

I changed "PyInit_visit" to "PyInit_visit_writer" and that didn't fix it. I did a make and it compiled and linked it into lib/visit_writer.so. Any other ideas?

@cyrush, I was looking into the locus.py failure:
Traceback (most recent call last):
File "/src/test/tests/hybrid/locus.py", line 42, in
import visit_writer
ImportError: dynamic module does not define module export function (PyInit_visit_writer)

and looked at ./tools/data/writer/py_visit_writer.c
and found
#if __GNUC__ >= 4
/* Ensure this function is visible even if -fvisibility=hidden was passed */
PyObject * __attribute__ ((visibility("default"))) PyInit_visit( void )
#else
PyObject * PyInit_visit( void )
#endif

I changed "PyInit_visit" to "PyInit_visit_writer" and that didn't fix it. I did a make and it compiled and linked it into lib/visit_writer.so. Any other ideas?

I fixed the python issue with the simulation tests. I tried 2 simulation tests to verify the fix and I noticed some text output from one of the tests had more significant digits in the text output, so there may need to be some rebaselines. I pushed the changes.

I fixed the python issue with the simulation tests. I tried 2 simulation tests to verify the fix and I noticed some text output from one of the tests had more significant digits in the text output, so there may need to be some rebaselines. I pushed the changes.

I have a partial fix for tests/hybrid/movie.py. The remaining problem is in makemovie.py. I pushed my changes.

I have a partial fix for tests/hybrid/movie.py. The remaining problem is in makemovie.py. I pushed my changes.


[docs][base] Add plain CSS, MUI System, Tailwind CSS and non-styled option for each demo

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
Currently, all of the Base UI demos show examples of how the component can be styled using MUI System. For developers not familiar with it, it can be confusing about which parts come from Base UI, and which parts are from MUI System. Also, for illustrating that MUI System is not the only styling solution compatible with Base UI, we can show different versions of the demos showing how Base UI components can be styled with:

Vanilla CSS
Tailwind CSS
MUI System
And, unstyled (i.e. how it looks out of the box)

Examples 🌈
One nice benchmark that we can take into account is the Radix UI's demos, where there is a dropdown for choosing the styling solution for each demo:

Another idea I like about this is that the styles definition are extracted in a separate file, so the demos code itself is very clean.
Motivation 🔦
The motivation is to show that Base UI components are compatible with different styling solutions, as well as simplify the demos we show, to contain the most essential bits of information (so far we just moved the styles below the demos code in order to fix this part, see https://github.com/mui/material-ui/issues/36498).
Progress

[ ] Autocomplete
[ ] Button (help wanted!, see e.g. UnstyledButtonsSimple)
[ ] Input (help wanted!, see e.g. UnstyledInputBasic)
[ ] Select (help wanted!, see e.g. UnstyledSelectBasic)
[ ] Slider (help wanted!, see e.g. UnstyledSliderBasic)
[ ] Switch (help wanted!, see e.g. UnstyledSwitchBasic)
[ ] Badge (help wanted!, see e.g. UnstyledBadge)
[ ] Snackbar (help wanted!, see e.g. UnstyledSnackbar)
[ ] Menu (help wanted!, see e.g. UnstyledMenuBasic)
[ ] Table pagination 🚧 https://github.com/mui/material-ui/pull/37937
[ ] Tabs 🚧 https://github.com/mui/material-ui/pull/37910
[ ] Form control (help wanted!, see e.g. BasicFormControl)
[ ] Modal
[ ] Popper 🚧 https://github.com/mui/material-ui/pull/37953
[ ] Textarea Autosize 🚧 https://github.com/mui/material-ui/pull/37943

Migration steps
Pick one demo from the documentation. For an explanation, let's use the UnstyledInputBasic demo. When searching for it in the docs, you will find three related files to it:

docs/data/base/components/input/UnstyledInputBasic.tsx
docs/data/base/components/input/UnstyledInputBasic.js
docs/data/base/components/input/UnstyledInputBasic.tsx.preview

The second two files are automatically generated using the yarn docs:typescript:formatted so we can ignore them for now.
The first step is to create a folder matching the demo name, in this case: UnstyledInputBasic in the same folder as the existing files. In this create three folders: system, tailwind, css. The folder structure should look like this:
/UnstyledInputBasic
  /tailwind
  /css
  /system

In each of this files, we will create a index.tsx file that will host the demo. For starting, copy the content of the existing demo under the /system/index.tsx file. After this you can remove the old files related to this demo.
Next, create the index.tsx file in the /css directory, copy the previous example, and adjust it to use plain CSS, similar as it is done in /css/index.tsx. For this example, we want to have a custom class names for the component and it's slots and to use the cyan palette, so that it would be differentiated from the default theme.
After this, create index.tsx file under /tailwind. Start with the same example, and convert each CSS statement (except the fonts) to the appropriate tailwind class. Instead of the blue color, here we use the purple tailwind's palette. You can use as an example /tailwind/index.tsx.
After you are done, run the yarn docs:typescript:formatted so that the JavaScript and preview files are generated.
Lastly, update the md file to point to the directory:
-{{"demo": "UnstyledInputBasic.js", "defaultCodeOpen": false}}
+{{"demo": "UnstyledInputBasic", "defaultCodeOpen": false}}

Note: For the tailwind demo, you may need to extend the theme in some cases, if this is needed, check https://github.com/mui/material-ui/pull/37685/files#diff-51a56236d553b9e7f2a94309601668a73d6582192be03c95f666b5d847661957 for an example. Someone from the core team will validate if this is truly required.

Hmm this component could just wrap some extra functionality (the dropdown) around the "Code Group" (“tabs between any time of code blocks”) suggested here - since for each dropdown option we could be showing a completely different set of files (completely different state)

@mnajdova Is this umbrella ticket open for contributions from the community? If so, may I start working on the Button component? (or whatever component you would suggest)

@mnajdova Is this umbrella ticket open for contributions from the community? If so, may I start working on the AutoComplete component? (or whatever component you would suggest)

Hey @alisasanib thanks for the interest. You can start with any of the pages that has the "help wanted" text besides it. The goal is to update each demo to contain versions with Tailwind CSS and Plain CSS. For e.g. for Button we have done it for the Basic demo, but there are other demos on the page too that we want to update. Feel free to pick up any of the pages that you would like to work on.
In terms of the Autocomplete, we were thinking to add at least one demo as an example on each page first, but if you want to try it feel free to grab that one too :)

Thanks @mnajdova I'll start with the button component :)

@mnajdova Is this umbrella ticket open for contributions from the community? If so, may I start working on the AutoComplete component? (or whatever component you would suggest)

Hey @alisasanib thanks for the interest. You can start with any of the pages that has the "help wanted" text besides it. The goal is to update each demo to contain versions with Tailwind CSS and Plain CSS. For e.g. for Button we have done it for the Basic demo, but there are other demos on the page too that we want to update. Feel free to pick up any of the pages that you would like to work on.
In terms of the Autocomplete, we were thinking to add at least one demo as an example on each page first, but if you want to try it feel free to grab that one too :)

Thanks @mnajdova I'll start with the button component :)

An interesting question in https://mui.zendesk.com/agent/tickets/10146

For Base-UI, is there a design kit like MUI that we can maintain and control the UI development. What are the pros and cons ?

Maybe we could make it simple. How about?

We introduce #38214, which provides a Base UI version of Material UI/Joy UI. This would deliver a straight copy of the source of Material UI/Joy UI in your codebase. This way, developers could use the Material UI/Joy UI design kit, and all the docs could stay the same. Pulling the use of Tailwind CSS, CSS modules would probably be too much effort.

In Base UI, we use:

A simplified version of Joy Design as the introductory demo, something that makes you say wow, amazing what we can do with Base UI, the same level of execution as https://sonner.emilkowal.ski/, something you could copy & paste in your codebase and use. Developers could pick between Tailwind CSS, CSS modules, MUI System, automatically converted.
Regular demos that document how Base UI works, either using the introductory demo when most relevant or basic demos, no toggles between different style engines

We have been talking about how fruitful it would be to use the Joy UI design language on Base UI, and it resonates with your perspective. We'd enable more people to use Joy UI design kit, distance MUI from Material Design only—as we are often seen by the community—, have a well-defined design system and guidelines to be used on Base UI demos (reducing a lot the cognitive load to come up with styles every time we need a new demo, and making it consistent with all the rest).

A possible way we could scale the Plain CSS / MUI System / Tailwind CSS toggle between the different demos of a page: https://github.com/mui/material-ui/issues/38911.
The playbook could look like this:

Create one Joy Design style variant per Base UI component with Plain CSS / MUI System / Tailwind CSS
Have the rest of the demos reimport from this introduction demo
Create a CLI to automatically copy the demo to your filesystem (so yo can effectively use it as in the docs
Introduce automation so only one of "Plain CSS / MUI System / Tailwind CSS" needs to be kept in sync with Joy UI.
Introduce a Material Design style variant.
🔥

All existing introduction demos have been handled.
We can track any further improvements in separate issues. I'm closing this one.


INT-2400 Fix tool:expected-type Classes in IP XSD

MessageChannel was moved from core to the base package.
InterceptorFactoryChain was incorrect.

More than just IP; closing.


[feature] pipe html file

Hi, I just finished setting up gulp to automate favicon generation, and all the images are created perfectly as expected :D
In my setup, I am using jade as the express template engine, and so in order to use the html generated by this favicons module, it would be great to be able to pipe the generated html file through the gulp-html2jade plugin, and thus end up with a jade file to include in my templates. However, running gulp-debug I found that the html file is never piped. Is there any way you guys could enable the html file piping? Thanks!

Basically, this is what I want to achieve:
return gulp.src(['client/img/icon.svg'])
	.pipe(svg2png())
	.pipe(favicons({
		...
		html: '../views/favicon.html',
		...
	}))
	.pipe(gulpif(/favicon\.html$/, html2jade()))
	.pipe(gulp.dest("public"));

ok I put together a quick implementation, will send pull request in a little while!

@perrin4869 Awesome, sounds good :)


WIP: Quick POC for how we could clean up non-existent projects in tea…

…ms and tokens
Signed-off-by: Tyler Cloke<EMAIL_ADDRESS>:nut_and_bolt: Description: What code changed, and why?

:chains: Related Resources
:+1: Definition of Done
:athletic_shoe: How to Build and Test the Change
:white_check_mark: Checklist

[ ] Tests added/updated?
[ ] Docs added/updated?

:camera: Screenshots, if applicable

@tylercloke thanks for the quick POC on this. Let me check if I understand / can summarize this correctly.
Firstly, there's a regular old SQL migration in here that sets up the database so we can run special data migrations in Golang. :ballot_box_with_check:
We need to run this migration in Golang here because it needs to be dynamic. We need data from another service (in this case we need to know what projects exist) and based on that data we need to update the records in our service. It's essentially a cleanup task. Our current migration tool, migrate doesn't support this.
So now, here's a rough idea of how our service startup goes:

run all the sql migrations that haven't been run
run all the golang migrations that haven't been run

I have a feeling that this will potentially cause problems at some point down the road. Imagine that we create more sql migrations that change how the code in the golang migrations works. Some customers will have already run the golang migrations. Some won't have because they'll upgrade many versions at once. Do we have a way to ensure that all the golang migrations will always run against the latest version of the sql schema? Is that what happens on a fresh intsall? Do we already have sufficient testing for this with our "upgrade from the may 2018 version (aka deep upgrade)" test?
Thoughts?

@tylercloke is it true that on a fresh install we'll:

run all the sql migrations 1-x
run all the golang migtations 1-x

If that's the case - it seems that we should catch at least the most basic case where this would fail when we do the fresh install test - the schema of the migration code not matching the new schema of the database.

@sdelano Summary and second comment are all accurate. All the schema migrations will always run before all the golang migrations. So we'd just have to keep the golang migrations up to date with any schema changes. That is a downside to this approach for sure.

Concerns noted above need to be kept in mind for the future, of course, and those would likely involve some further iteration, but seems like this will certainly meet our present needs.


Removed Duplicate Code

If I'm not mistaken, this seems to be an unnecessary duplicate

it's the lower one that should be removed actually. I'll edit it now. The idea is skip do any changes to superflat world including adding to the configuredstructures field for that chunkgenerator

Done, thank you for pointing this out!

No problem, thanks for making the tutorial!


Encourage the use of a semantic version in README.md

The project should encourage users to pin the action to a semantic version. Doing so helps to ensure potential breaking changes don't immediately break a user's workflow.
All of the official GitHub actions follow this pattern as well as many other community actions:
https://github.com/actions/
For example, the checkout action: https://github.com/actions/checkout

Thank you for this suggestion! I made this change as part of https://github.com/isort/isort-action/pull/60/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R45, so will close out this PR.
(Note that the tag on the current release is v1.0.0, so you would need to pin to<EMAIL_ADDRESS>instead)

Thanks!

Note that the tag on the current release is v1.0.0, so you would need to pin to<EMAIL_ADDRESS>instead

Good point!
It might be a good idea to publish a v1 tag that is set to the most recent release on the 1.x track. Through semantic versions, users should feel confident to use any release from 1.x without breaking their workflow but continue to use the most up to date compatible release.
Other actions, like actions/checkout do this.


Improve workspace API for Notebook lifecycle to support (at least) saving events

There are certain VSCode extensions that are devoted to allow users to define shell commands that are executed when files are saved. These include, among others, the following:

Run on Save
VSCode Run on Save
Save and Run

The extensions above rely on events currently available in the VSCode workspace API such as onWillSaveTextDocument and onDidSaveTextDocument.
In the recently added native support for notebooks in VSCode, it looks like notebooks are treated in a different way than text documents. The new workspace API has included some events specifically targeted to the notebook lifecycle, such as onDidOpenNotebookDocument and onDidCloseNotebookDocument. However, the API currently lacks other useful notebook lifecycle events such as onWillSaveNotebookDocument and onDidSaveNotebookDocument, so the extensions above can't work properly when save-related events happen on notebooks.
Would it be possible to extend the workspace API with at least onWillSaveNotebookDocument and onDidSaveNotebookDocument (and other useful methods for the notebook lifecycle if possible)?
Thanks in advance!!!
Note: I've just stumbled upon a similar request for those APIs in an issue related to LiveShare: #102503

That would be super useful to have, indeed!

Is there any workaround for this? I currently can easily see if a text file has been saved, but not have an event to tap into when a notebook has been saved. 😤😭
vscode.workspace.onDidSaveTextDocument(e => {
  vscode.window.showInformationMessage('did' + e.fileName)
})

vscode.workspace.onWillSaveTextDocument(e => {
    vscode.window.showInformationMessage('will' + e.document.fileName)
})

Re https://github.com/microsoft/vscode/issues/157844

We already have onDidSaveNotebookDocument and we are finalizing onWillSaveNotebookDocument API in https://github.com/microsoft/vscode/issues/157844, thus closing this issue.

@francisco-perez-sorrosal  @reggi you can follow https://github.com/microsoft/vscode/issues/157844 on where we are with the onWillSaveNotebookDocument API, thanks!

This can be now tested against VS Code Insiders using the latest vscode.d.ts file from main branch. A sample extension with following content should work
import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext) {
	vscode.workspace.onWillSaveNotebookDocument(event => {
		if (event.reason === vscode.TextDocumentSaveReason.Manual) {
			event.waitUntil(new Promise((resolve) => {
				const notebookEdit = new vscode.NotebookEdit(new vscode.NotebookRange(0, 0), [new vscode.NotebookCellData(vscode.NotebookCellKind.Code, 'print(1)', 'python')]);
				const edit = new vscode.WorkspaceEdit();
				edit.set(event.notebook.uri, [notebookEdit]);
				resolve(edit);
			}));
		}
	});
}
export function deactivate() {}


Error while creating RadarWidget objects: Empty data-type

Hi again,
I have succeeded in launching BlueSky with GUI, but got the subsequent terminal readout, where the error appears near the bottom:

~/Downloads/bluesky-master » python3 BlueSky.py
Reading config from settings.cfg
Using Python-based geo functions
Loading global navigation database...
Reading cache: data/cache/py3/navdata.p
*****   BlueSky Open ATM simulator *****
Distributed under GNU General Public License v3
Exception in thread Thread-1:
Traceback (most recent call last):
File<EMAIL_ADDRESS>line 932, in _bootstrap_inner
self.run()
File "/Users/.../Downloads/bluesky-master/bluesky/network/server.py", line 71, in run
self.fe_event.bind(f'tcp://*:{bs.settings.event_port}')
File "zmq/backend/cython/socket.pyx", line 550, in zmq.backend.cython.socket.Socket.bind
File "zmq/backend/cython/checkrc.pxd", line 26, in zmq.backend.cython.checkrc._check_rc
zmq.error.ZMQError: Address already in use
Loading palette bluesky-default
Using Qt 5.15.0 for windows and widgets
QGLWidget initialized for OpenGL version 3.3
Reading cache: data/cache/py3/aptsurface.p
Reading cache: data/cache/py3/coastlines.p
ND: Context not valid in create_objects, or shareWidget not yet initialized
Maximum supported texture size: 16384
Loading texture data/graphics/world.16384x8192.dds
Error while creating RadarWidget objects: Empty data-type
ND: Context not valid in create_objects, or shareWidget not yet initialized
Client b'\x00\x02\x08\xdd\x0f' connected to host b'\x00\xcd\x8a\xa7c'
ND: Context not valid in create_objects, or shareWidget not yet initialized
ND: Context not valid in create_objects, or shareWidget not yet initialized
ND: Context not valid in create_objects, or shareWidget not yet initialized
ND: Context not valid in create_objects, or shareWidget not yet initialized
ND: Context not valid in create_objects, or shareWidget not yet initialized
ND: Context not valid in create_objects, or shareWidget not yet initialized
...

This issue persists when running in the Python virtual environment.
I am new to BlueSky, and will keep consulting the documentation, but thank you if you have the solution.

Something is going wrong in the construction of the OpenGL gui. Can you do the following:
in bluesky/ui/qtgl/radarwidget.py, around line 445, change:
    except Exception as e:
        print('Error while creating RadarWidget objects: ' + e.args[0])

into:
    except Exception as e:
        print('Error while creating RadarWidget objects: ' + e.args[0])
        raise e

Then run BlueSky again and let me know the full exception printed to the terminal.

Dear Joost,
Thank you for attending to this. Here is the print-out:

~/Documents/UAM_research/bluesky(lstm*) » python3 BlueSky.py
Reading config from settings.cfg
Using Python-based geo functions
Loading global navigation database...
Reading cache: data/cache/py3/navdata.p
*****   BlueSky Open ATM simulator *****
Distributed under GNU General Public License v3
Accepting event connections on port 11000, and stream connections on port 11001
Discovery is disabled
Loading palette bluesky-default
Reading config from settings.cfg
Using Python-based geo functions
Loading global navigation database...
Reading cache: data/cache/py3/navdata.p
StateBasedCD: using default Python version, no compiled version for this platform.
StateBasedCD: using Python version.
Using BlueSky legacy performance model
pygame 2.0.0.dev6 (SDL 2.0.10, python 3.8.5)
Hello from the pygame community. https://www.pygame.org/contribute.html
Using Qt 5.15.0 for windows and widgets
QGLWidget initialized for OpenGL version 3.3
Reading cache: data/cache/py3/aptsurface.p
Reading cache: data/cache/py3/coastlines.p
ND: Context not valid in create_objects, or shareWidget not yet initialized
Maximum supported texture size: 16384
Loading texture data/graphics/world.16384x8192.dds
Error while creating RadarWidget objects: Empty data-type
Traceback (most recent call last):
File "/Users/yaofuzhou/Documents/UAM_research/bluesky/bluesky/ui/qtgl/radarwidget.py", line 447, in initializeGL
raise e
File "/Users/yaofuzhou/Documents/UAM_research/bluesky/bluesky/ui/qtgl/radarwidget.py", line 444, in initializeGL
self.create_objects()
File "/Users/yaofuzhou/Documents/UAM_research/bluesky/bluesky/ui/qtgl/radarwidget.py", line 356, in create_objects
self.wptlabels = self.font.prepare_text_instanced(npwpids, (5, 1), self.wptlatbuf, self.wptlonbuf, char_size=text_size, vertex_offset=(wpt_size, 0.5 * wpt_size))
File "/Users/yaofuzhou/Documents/UAM_research/bluesky/bluesky/ui/qtgl/glhelpers.py", line 371, in prepare_text_instanced
ret.bind_attrib(self.attrib_texdepth, 1, text_array, instance_divisor=1, datatype=gl.GL_UNSIGNED_BYTE)
File "/Users/yaofuzhou/Documents/UAM_research/bluesky/bluesky/ui/qtgl/glhelpers.py", line 194, in bind_attrib
gl.glBufferData(gl.GL_ARRAY_BUFFER, data.nbytes, data, storagetype)
File "src/latebind.pyx", line 51, in OpenGL_accelerate.latebind.Curry.call
File "/usr/local/lib/python3.8/site-packages/OpenGL/GL/VERSION/GL_1_5.py", line 86, in glBufferData
data = ArrayDatatype.asArray( data )
File "src/arraydatatype.pyx", line 174, in OpenGL_accelerate.arraydatatype.ArrayDatatype.asArray
File "src/numpy_formathandler.pyx", line 159, in OpenGL_accelerate.numpy_formathandler.NumpyHandler.c_asArray
File "src/numpy_formathandler.pyx", line 132, in OpenGL_accelerate.numpy_formathandler.NumpyHandler.c_zeros
TypeError: Empty data-type

and the GUI was stuck at the logo.

From the line File "/usr/local/lib/python3.8/site-packages/OpenGL/GL/VERSION/GL_1_5.py", line 86, in glBufferData it looks like your installation of pyopengl is using OpenGL version 1, whereas you need version >=3. Can you try updating pyopengl?

I do have
OpenGL module version is         [3.1.5]
when check.py is run. I will check if I can get program looking for the correct version of OpenGL, and update then.

3.1.5 is indeed the latest version that pip provides.
In case the problem does lie elsewhere you could try the following: In bluesky/ui/qtgl/radarwidget.py before line 356 insert:
    print('WPname buffer size:', len(npwpids))

And let me know what it prints.

File "/Users/yaofuzhou/Documents/UAM_research/bluesky/bluesky/ui/qtgl/radarwidget.py", line 356, in create_objects
print('WPname buffer size:', len(npwpids))
TypeError: len() of unsized object

Ah, sorry, apparently you need npwpids.size instead of len(npwpids).

By coincidence I just received an email from someone with exactly the same problems as you are experiencing. Also with a Mac and Python 3.8. I'm starting to think that this is related to python 3.8 and the packages that come with it. Would you mind trying installing python 3.7? This is what I use myself (also on a mac), and it works fine.

Ah, sorry, apparently you need npwpids.size instead of len(npwpids).

WPname buffer size: 1

It is finally working for me!
Specifically, I installed miniconda to create a virtual environment of Python 3.7 (3.7.9 to be exact).
Another critical step in my attempt was pip3 install msgpack==0.6.2, which is another downgrade from the latest version.


Added international / global flag

Sometimes websites offer a global or international version. For this purpose I added a global flag containing a flat icon of the globe on blue background.

Perhaps one could play a little with the colors. Looking at it again tells me that this one has very much contrast. This can be used as starting point - I think the idea is clear.
What do you think?

For futher clarity: It's already in usage on http://www.sygns.com

I will keep this repo for the ISO 3166 list only.. it's not really hard to add more flags even if this repo is used via Bower


Quote Icon added

changed the column widths for the quote icon left to the text
inserted the icon in the Quote component

additional to the changes here: https://trello.com/c/pB0tO5W8


[conductor] Add code coverage to tests

Add code coverage to all the tests of the release dashboard by using the code coverage support offered by Flutter tools.
It will help with the code review, test confidence and additionally dogfood the code coverage tool.

cc @christopherfujino

codecov.io offers free code coverage metrics and web dashboards for open source projects. We used to do this for the flutter CLI tool: https://app.codecov.io/gh/flutter/flutter


update verification script to enable fast fetch of step functions. use service contract. show liquidity conversion rate

updating mainnet json.
also adding some missing addresses to permission.
a faster way to fetch step function, using some service contract.

this was handled in another PR


Optimal Path (Immitation Learning)

Hi It looks like the agent will calculate the shortest path to the goal each time it performs the action but I got slightly confused with its calculation. (I am hoping I can use the shortest path for the purpose of imitation learning) Every time the agents perform the action like "TurnLeft" or "Turn Right", the direction of optimal path changes (I am not sure why this is happening since the agent's location is not changing as far as I am observing). Since the orientation of the agent is also changing, this leads the agent never able to direct itself to optimal path direction.

Hi @kojimano ,
The shortest path direction is given in the agent's frame of reference, and so it will indeed change on turn actions as well (since the agent's orientation has changed on a turn).
This shortest path computation is not necessarily the "optimal path" for the agent's action space because it is computed on a discretized grid given the agent's current position and the goal position.  The relative orientation of the agent and the direction to the next grid cell on the path is then used to compute the direction of the shortest path.
If you are observing a specific issue please send us a description in a bit more detail.

Thanks! Could you probably point me to the script where the shortest path computation has been done (I couldn't trace back where.)
Now I understand the agent's orientation is given in an absolute frame, and shortest path is given in an agent's frame. Given this relative coordinates of next pixel how you can tell when the agent has almost redirected itself to the next grid? The definition of this seems a bit unclear to me. (Is it when the orientation is on pi/2 radian ? I did simple experiments but something got wrong and could not figure out this.)

Also could you verify my understanding regarding these measurements is correct?
"""
observations['observation']['measurements']['shortest_path_to_goal']['direction']
observations['observation']['measurements']['direction_to_goal']
observations['info']['agent_state']['orientation']
"""
All of the measurments returns the tuplet of containing 3 numbers (corresponding to x,y,z in absoluute and relative coordinate). For the first two measuments we want to make x coordinate close to 1 so that the agent direct themselves to a next grids or goal. For the third measurments the retuned value is more coordinate on absolute axis. This confuzes me slightly after I do numerous expeiments trying to figure out.

The shortest path is computed as part of the update step here: https://github.com/smartscenes/sstk/blob/660cc7b17ccc2745b3f0453083405adecac03e7a/client/js/lib/nav/NavScene.js#L742
For continuous control, the agent step size may also be larger than a grid cell (depending on the agent velocity) - this is another way where the discretized shortest path may not match the optimal trajectory for the agent.
As for the agent coordinate frame: +z is forward so you want to get the z coordinate close to 1 so the agent is oriented correctly.  +y is the upward direction and +x right direction.  This is true for the observations['observation']['measurements']['direction_to_goal']
I think you are right that the values for observations['observation']['measurements']['shortest_path_to_goal']['direction'] are not quite following that convention and we are debugging more to see what the problem is.
You can check the measurements by debugging using
python3 -m tools.pygame_client -s map --navmap
(the navmap option was accidentally removed at some point, so please pull to use the --navmap option)

Thank you for your response. I will take a look at this issue closer.

Also are there any minimal test codes available for shortest pathfinding? While this seems a bit tricky to fix (since not clear where exactly the issue is from searching, coordinate calculation or graph construction), if this will take sometimes to fix, I would also try fixing by myself given the time constraints.

I did temporal fix by myself bt returning the optimal path instead of angles and etc, so I will close this issue.


Include more performance benefit info in the README

See #27
The code examples might be too opinionated perhaps, but I think they might be useful to show the HTML only approach vs the more dynamic approach.

Btw, You may not need loadCSS…, by Filament Group.
Another approach, without dependencies will be:
<script>
  const medias = window.matchMedia('(min-width: 1024px)')
  if (medias.matches) {
    const desktopCSS = document.createElement('link');
    desktopCSS.rel = 'stylesheet';
    desktopCSS.href = '/css/desktop.css';
    document.getElementsByTagName('head')[0].appendChild(desktopCSS);
  }
</script>


Revert jsk recognition

The latest versions aren't building on the buildfarm: see http://build.ros.org/view/Mbin_uB64/job/Mbin_uB64__jsk_perception__ubuntu_bionic_amd64__binary/ for one example.  This reverts it back to the last version that built, 1.2.10.  @k-okada FYI.

Thanks,
I'm working on this issue at
https://travis-ci.org/github/jsk-ros-pkg/jsk_recognition/jobs/733534427
created test code and apply patch to fix this
We'll release newer version soon.
--
◉ Kei Okada
2020年10月7日(水) 21:09 Chris Lalancette<EMAIL_ADDRESS>
Merged #26834 into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@clalancette sorry for trouble #26864 #26862 #26861 should fix this error


feat: update to vue 2.6

Notes:

https://medium.com/the-vue-point/vue-2-6-released-66aa6c8e785e
https://ssr.vuejs.org/guide/data.html
https://github.com/vuejs/vue/releases/tag/v2.6.0

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[x] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

Codecov Report

Merging #4953 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #4953   +/-   ##
=======================================
  Coverage   92.93%   92.93%
=======================================
  Files          73       73
  Lines        2419     2419
  Branches      594      594
=======================================
  Hits         2248     2248
  Misses        156      156
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4051b2...c96755d. Read the comment docs.

Will the ssrPrefetch be implemented in another version ?

@clarkdo yes


Webpack.8 Unexpected Token Error After Update

Please provide us with the following information:

OS?  Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

El Capitan

Versions. Please run ng --version. If there's nothing outputted, please run
in a Terminal: node --version and paste the result here:

node: 4.5.0

Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code? etc.

npm install angular-cli@webpack -g

The log given by the failure. Normally this include a stack trace and some
more information.

Error while running script "/usr/local/lib/node_modules/angular-cli/addon/ng2/models/config/config.ts":
SyntaxError: Unexpected token ...
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:373:25)
at Object.require.extensions..ts (/usr/local/lib/node_modules/angular-cli/lib/bootstrap-local.js:30:14)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Module.require (module.js:353:17)
at require (internal/module.js:12:17)
at Object. (/usr/local/lib/node_modules/angular-cli/addon/ng2/models/config.ts:7:16)
at Module._compile (module.js:409:26)
at Object.require.extensions..ts (/usr/local/lib/node_modules/angular-cli/lib/bootstrap-local.js:30:14)

Mention any other details that might be useful.

When running version .2 all was well after upgrade I get the above error.

Thanks! We'll be in touch soon.

Nevermind looks like it needs Node 6.x
That said after running new command a vanilla project won't build. It throws a bunch of errors related to not finding globals. Going to rollback for the moment.
ERROR in [default] Cannot find name 'Object'

The above is thrown for Object, Array, Function etc...

Issue appears to be typescript version. lock out to version 2.0.0
change:
"typescript": "^2.0.0"

to:
"typescript": "2.0.0"

Based on my experience this am I would suggest the following config:
Node: 6.x
Npm: 3.x
angular-cli:
npm install<EMAIL_ADDRESS>-g

typescript:
npm install<EMAIL_ADDRESS>-g

Also ensure that typescript in package.json dev dependencies is locked out as shown above.

when I create a project with angular-cli not app.module.ts file appears me, anyone know how to fix it?

@EdwinDennis are  you saying that app.module.ts does not exist?

do not appear app.module.ts, the versions I have are these ,
node --version
v4.4.5
ng --version
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://ember-cli.com/user-guide/#watchman for more info.
angular-cli: 1.0.0-beta.10
node: 4.4.5
os: darwin x64

Looks like you need to the webpack version of angular-cli
npm install<EMAIL_ADDRESS>-g

I don't believe the default angular-cli uses app.module.ts. At least not the last time I checked.
Be careful though if on an existing project as webpack works significantly different and makes use of the new @types for typescript.

thanks for the help, update and think the file


[JOSS Review] What about automated tests?

The minimal  JOSS requirements testing reads:

Documented manual steps that can be followed to objectively check the expected functionality of the software (e.g., a sample input file to assert behavior)

I guess you could basically argued that some of the steps in the documentation full fills this requirement. But there is not really any objective criteria to say if the warping was correct. In other words how can I know the library does the same as the last release.
I think you could benefit from automated testing. Tests are also a nice if you ever get contributions from others as it helps verify their code. Using something like "Github actions" is very easy to setup,

Since the package's main purpose is to support manual (and therefore subjective) registration, the only way to thoroughly automate quantitative testing is to simulate mouse and keyboard actions.  This is certainly possible using Qt's event simulators, but this type of automated testing takes much longer to develop than normal script-based testing. Given the JOSS requirement statement (i.e., that step-by-step documentation is sufficient for publication), we decided to choose the documentation route instead.
Please note:
The documentation link you sent above ("steps in the documentation") contains only a list of scripting examples.
The step-by-step instructions appear in the User manual section, and for those who don't like to read, in the Screencasts section.
Do you think Qt-based mouse+keyboard automation is necessary for publication?

No. Please don't do any automated GUI testing. That would be overkill for an application like this. It is the underlying logic that could benefit from unit testing.
You have plenty of scripting examples in http://www.spm1d.org/mwarp1d/examples.html, which could easily be tested. Functions like mwarp1d.warp_manual
I agree that JOSS does not require unit testing, and that your documentation is extensive enough comply with the minimum JOSS requirements. So I guess this is not a blocker for the review.
I do understand that you don't see the benefit of automated testing if you haven't used it in other projects. But for open source projects automated CI testing is often quite essential. They can help ensure that your stuff still works when dependencies change over time. How can you be sure that the program will still load with Python 4 when it has been lying around untouched for three years.
For example, your Setup.py and Conda recipe does not mention all the dependencies that you use. This is guaranteed to break at some point when the default QT in Anaconda changes. I think you would have caught this error if you did automated testing.
Also,  you should consider creating a conda-forge recipe. It will ensure that the package will continue to work in the future and also give you packages for linux.

I have created a separate issue for the missing dependencies. So I think we can close this if you promise to give automated tests a try in the future ;-)

Thank you for that! I do use unit testing in other projects, I just usually keep the unit testing code separate from the main repository. But I agree it could indeed be advantageous to include the unit testing code, will definitely add it in the future. Thank you!
I've not used conda-forge before, but will definitely try it out, thanks for that as well!


Add data augmentation option

We should add the possibility to augment data in grid case. See data_augmentation in the former DataGenerator of deeprank.

Do we want to add such an option during the generation of the hdf5 files (query module), or at a later stage, when generating the GridDataset? (I would go for the latter)
In the latter case, do we want to write such augmentations in the hdf5 files? I would avoid that.

What types of augmentation are we thinking about?

Do we want to add such an option during the generation of the hdf5 files (query module), or at a later stage, when generating the GridDataset? (I would go for the latter)

I think during query is not a good idea, because normally only the training data should be augmented, and not the validation or test data. In query, we are not yet (and do not want to be) defining which data will be for training and which for validation/testing.
Also, for many types of (randomized) augmentations (e.g. random rotation), each epoch can use a different random rotation, so ideally the augmentations only happen at that point rather than in the GridDataset class.
For predetermined augmentations (e.g. mirroring all data) this wouldn't be an issue, but probably better to do all augmentations in the same way.

In the original deeprank, data is augmented by rotating points in space by a random rotation around a random axis.
The points hold all the feature values.
After rotation, the points are mapped to the grid.

This was done in #336.


Generate a new DNS transaction ID for each probe

This is more representative of real traffic, which should not repeat
transaction IDs.

Thanks!

Thanks!

Thank you! :)


HIVE-27937: Clarifying comments around tez container size

What changes were proposed in this pull request?

added a useful comment in HiveConf for hive.tez.container.size
cleaned up hive-site and tez-site xml files accordingly:

removed hive.tez.container.size from tez-site.xml (even if it works from there, it's a hive option, should be in hive-site for clarity's sake)
updated hive.tez.container.size in hive-site where a bigger value was removed from tez-site

minimal refactor in DagUtils in the same area, added debug level messages

Why are the changes needed?
Clarity in HiveConf and qtests.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
Precommit, and manually checked tez logs.
in DAGAppMaster log:
2023-12-05T09:39:06,211 INFO [DelayedContainerManager] rm.YarnTaskSchedulerService: Assigning container to task: containerId=container_1701797922416_0001_01_000002, task=attempt_1701797922416_0001_1_00_000000_0, containerHost=localhost:60444, containerPriority= 2, containerResources=<memory:128, vCores:1>, localityMatchType=NodeLocal, matchedLocation=localhost, honorLocalityFlags=true, reusedContainer=false, delayedContainers=1

can I get a review on this?
@deniskuzZ @ayushtkn @zabetak

thanks for the review @zabetak, I'm assuming you're fine with patch with my comment, let me know if you don't, also, I have to wait for a green test anyway :)

seems like both TestTriggersNoTezSessionPool failures and qtest failures are related, so for currently unknown reasons, hive.tez.container.size looks to have an effect on llap local driver results somehow, which I need to investigate (I would ignore it and change back to original, but that would be against the purpose of this PR, which is to understand and clarify hive.tez.container.size as much as possible, so let me work on this further

The last test failure was unrelated but I'm retriggering...
@zabetak : are you fine with the patch in its current form?


I use my own data for retargeting, but the program will give an exception

Traceback (most recent call last):
File "eval_single_pair.py", line 104, in
main()
File "eval_single_pair.py", line 92, in main
new_motion = (new_motion - dataset.mean[i][j]) / dataset.var[i][j]
RuntimeError: The size of tensor a (99) must match the size of tensor b (91) at non-singleton dimension 1
Traceback (most recent call last):
File "demo.py", line 46, in
example('Aj', 'BigVegas', '01.bvh', 'intra', './examples/intra_structure')
File "demo.py", line 42, in example
height)
File "/home/wuxiaoliang/docker/newAPP/deep-motion-editing/retargeting/models/IK.py", line 57, in fix_foot_contact
anim, name, ftime = BVH.load(input_file)
File "../utils/BVH.py", line 58, in load
f = open(filename, "r")
FileNotFoundError: [Errno 2] No such file or directory: './examples/intra_structure/result.bvh'
Hello, how can I solve this problem？@ @kfiraberman

Traceback (most recent call last):
File "eval_single_pair.py", line 104, in
main()
File "eval_single_pair.py", line 92, in main
new_motion = (new_motion - dataset.mean[i][j]) / dataset.var[i][j]
RuntimeError: The size of tensor a (99) must match the size of tensor b (91) at non-singleton dimension 1
Traceback (most recent call last):
File "demo.py", line 46, in
example('Aj', 'BigVegas', '01.bvh', 'intra', './examples/intra_structure')
File "demo.py", line 42, in example
height)
File "/home/wuxiaoliang/docker/newAPP/deep-motion-editing/retargeting/models/IK.py", line 57, in fix_foot_contact
anim, name, ftime = BVH.load(input_file)
File "../utils/BVH.py", line 58, in load
f = open(filename, "r")
FileNotFoundError: [Errno 2] No such file or directory: './examples/intra_structure/result.bvh'
Hello, how can I solve this problem？

I've created the directory your way, but the same error still occurs @crissallan

RuntimeError: The size of tensor a (99) must match the size of tensor b (91) at non-singleton dimension 1，
This is the first exception

RuntimeError: The size of tensor a (99) must match the size of tensor b (91) at non-singleton dimension 1，
This is the first exception

Ah~ Since the tensor's shape doesn't match,  I think you should check whether  "01.bvh" is the mocap data of “Aj” or "BigVegas".
Because the shape of the motion tensor depends on the number of joints of the character. e.g. 91 = (23-1) * 4 + 3 because "Aj" and "BigVegas" both has 23 joints as its simplified skeleton.
So if tensor a's shape is 99, I would reckon that this bvh file might belongs to a character which has 24 joints.

OK, thank you very much for your reply,
"Our approach is also quantitatively evaluated on a synthetic dataset that contains pairs of motions applied to different skeletons. To the best of our knowledge, our method is the first to perform retargeting between skeletons with differently sampled kinematic chains, without any paired examples. " , it is from "Skeleton-Aware Networks for Deep Motion Retargeting",
Is it required that the number of key points must be consistent？

Our architecture requires a consistent topology between training character and test character. Thus, if you want to test with a new topology you will need to retrain the model with your own dataset.

thank you very much for your reply @PeizhuoLi

Hi, I convert example.bvh file to csv file, and I found the number of joint was 31:
Hips Lhipjoint leftupleg leftleg leftfoot lefttoebase rhipjoint rightupleg rightleg rightfoot righttoebase lowerback spine spine1 neck neck1 head leftshoulder leftarm leftforearm lefthand leftfingerbase lefthandindex1 lthumb rightshoulder rightarm rightforearm righthand rightfingerbase righthandindex1 rthumb
As I understand, the number of joints was 23. What difference between those?


Acceleration and jerk bounded velocity planner

This is now considered complete. What we have as of right now is a good v1 of this.


[FEATURE] Untie tracing component from Zipkin details

Is your feature request related to a problem? Please describe.
The tracing component directly ties to Zipkin implementation, but we prefer to use Jaeger tracing.
Describe the solution you'd like
Rewrite the tracing component by defining an abstraction layer while providing adapters for major vendors such as Zipkin, Jaeger, etc.
Describe alternatives you've considered
I briefly considered writing a jaeger adapter for Zipkin, but the tracing component in v1.0 as it stands now is too leaky, hardcoding Zipkin types all over the place.
Additional context
Will a PR like this be accepted? I will be able to contribute.

@Reasno Yes, an adapter for Jaeger also in Hyperf's plan, if you could contribute this adapter will be better, any questions about this issue could ask me.

Thanks. Hopefully, I can have some code available by the end of this week.

return [
    'handler' => \Hyperf\Tracer\Handler\ZipkinHandler::class,
    'enable' => [],
    'zipkin' => [
          //zipkin specific config
    ],
     'jaeger' => [
          //jaeger specific config
    ],
];

In laravel style you probably have something like this:
return [
    'tracing' => env('TRACING", 'somezipkin')
    'enable' => [],
     'somezipkin' => [
          'driver' => 'zipkin',
         //zipkin specific config
    ],
    'somejaeger' => [
          'driver' => 'jaeger',
          //jaeger specific config
    ],
     'anotherzipkin' => [
          'driver' => 'zipkin',
         //zipkin specific config
    ],
];

I feel it is common to desire a different set of configuration for a different environment, (ie. different sample rate for development/staging/production) even for the same tracing handler.
However, I understand Hyperf is not Laravel, and this is beyond the tracing component's responsibilities. So, for now, I am happy to implement it your way.

For now, I think the way that you suggested is better, but obvious this changes is a incompatible changes for the component, therefore, you should create your branch base on master branch, and send the PR to merge into master branch, which means this changes will be released in v1.1, and the v1.1 is planned to release in the middle of September.
<?php
return [
  'tracing' => env('TRACING', 'somezipkin'),
  'enable' => [],
  'handler' => [
    'somezipkin' => [
      'driver' => \Hyperf\Tracer\Handler\ZipkinHandler::class,
      'sampler' => BinarySampler::createAsAlwaysSample(),
       //zipkin specific config
    ],
    'somejaeger' => [
      'driver' => \Hyperf\Tracer\Handler\JaegerHandler::class,
      //jaeger specific config
    ],
    'anotherzipkin' => [
      'driver' => \Hyperf\Tracer\Handler\ZipkinHandler::class,
      'sampler' => PercentageSampler:create(0.1),
      //zipkin specific config
    ],
  ]
];


Problem with a DW11 2GIG/Vivint Window Sensor

I honestly can't figure this out.
I have 8 sensors all working perfectly with this app, so thank you for that!
However, we have 1 2GIG DW11 from a Vivint system that is no longer active, that doesn't want to play nice. It shows as Invalid Payloads in the log, but then in Home Assistant it randomly picks up a trigger of open/close every few hours.

Hello. I see your very recent post. It looks like you successfully installed the component. I attempted to install it via HACS in HASS.IO, but it failed with 'Repository structure for master is not compliant' error. Please let me know if there is another way to install this custom component. Thank you in advance!

Hello. I see your very recent post. It looks like you successfully installed the component. I attempted to install it via HACS in HASS.IO, but it failed with 'Repository structure for master is not compliant' error. Please let me know if there is another way to install this custom component. Thank you in advance!

This is a stand alone binary that broadcasts over MQTT to Home Assistant, it's not installed as an addon.

Did you ever get this figured out? I am having the same issue.

Nope, haven't been able to get this figured out. There is a second sensor that also always triggers as open for no apparent reason. After a HA reboot, it will show closed for like 5 mins, then randomly open and stay open.

#https://github.com/merbanan/rtl_433/issues/1261


Correctly set intent classifier custom entity parser in ProbabilisticIntentParser

Description:

The ProbabilisticIntentParser should set  its intent_classifier.custom_entity_parser when it's fitted the same way as the intent_classifier.builtin_entity_parser

Codecov Report

Merging #688 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #688      +/-   ##
===========================================
+ Coverage    88.44%   88.45%   +<.01%
===========================================
  Files           64       64
  Lines         3662     3663       +1
  Branches       670      670
===========================================
+ Hits          3239     3240       +1
  Misses         325      325
  Partials        98       98


Fast Unstake Pallet

Fixes #8436
This is a pallet that does one thing and one thing only: allow you to unstake from the staking system quickly IFF you are not exposed (i.e. not in the Exposure of any validator) in any of the last BondingDuration eras. Optionally, this pallet allows one to join a pool on the fly as they unstake.
Multiple ideas exist to implement this, all of which have been discussed in #8436. This PR is probably the most conservative approach in terms of security, yet it is the least efficient for the chain. To be specific, the pallet will schedule background tasks to check the entire exposure table of the stash who wants to unstake over multiple blocks. This is not fast, does waste chain resources, but it is safe.
@rossbulat and I have the intention to merge this before 9.29 release and implement it in the staking dashboard as well, hopefully providing a much better UX for those who wish to migrate from staking to Pools.
TODO:

[x] Tests @rossbulat
[ ] Issue for future task: de-couple this from the nomination_pools pallet.

/cmd queue -c fmt $ 1

First superficial look at this PR: y'all need to explain what the heck "not exposed" means in layman's terms. Stating that it's not in the Exposure of any validator is not good enough, because it begs the question "what exactly is an Exposure for a validator?"

First superficial look at this PR: we need to explain what the heck "not exposed" means in layman's terms. Stating that it's not in the Exposure of any validator is not good enough, because it begs the question "what exactly is an Exposure for a validator?"

https://github.com/paritytech/substrate/pull/12129/commits/c925741d271716d21f0e34b9f4f16e08707a8852
Do you want more docs for review and developer purposes, or for end users?
For the former, I think adding more context here is moot. This pallet relies on pallet_staking and concepts such as Exposure are explained there.
For the latter, I also think more than this is not useful because I don't think anyone wants (or is capable of) checking whether they are exposed or not. The wallet would identify this, and if the user is eligible, would report it to them. So the real audience here is wallet developers. s

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:
https://forum.polkadot.network/t/nomination-pools-integration/361/1

LGTM! :+1:

/cmd queue -c fmt $ 1

merging this, won't go to Polkadot yet.

bot merge

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:
https://forum.polkadot.network/t/path-to-fast-unstake-in-polkadot-kusama/1539/1

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:
https://forum.polkadot.network/t/polkadot-digest-17-jan-2023/1706/1


[ BUG ] form no work

Describe the bug
run form.tsx
'BottomSheetModalInternalContext' cannot be null!
This error is located at:
in BottomSheetModal (created by BottomSheetModal)
in Unknown (created by Combobox)

@jychen23333
Is your root component wrapped with BottomSheetModalProvider from @gorhom/bottom-sheet like the app/_layout.tsx file in the showcase app?

It work, thanks so much!


Dropping nmcli reqs

Currently the code is tightly tied to having a working NetworkManager, but there are many distributions that do not use it. This PR replaces the NetworkManager commands with base ip / iw / ss / ... commands, widely available in almost all linux distros.

I'm debating if this should be the default or an argument switch.  My core requirement is that this work on a Raspberry Pi with Raspbian OS, and currently, it doesn't without some adjustments, and more research is needed to figure out the most correct way to do it on that platform.
The primary issue on Raspbian is that NetworkManager is running, and as a result, iw has limited authority/domain.  It can scan and list SSIDs, but it can't connect to unprotected networks, it will deauth and fail.  The only solution I've found so far, which I don't deem correct enough is to sudo systemctl stop NetworkManager followed by sudo ifconfig wlan0 up, but that kills DNS on the box, and leaves DNS dead after running.  I'm not sure if we just track state (check if NetworkManager service is installed/active) and stop then start as needed, or something else.
Additionally, there is one bug where I'm guessing your pauses covered it up.  It's a bug that existed in the existing cloudcutter that we couldn't prevent, but the worst case was one connect would fail, and the next would work.  With this version, it will sit thinking it's trying to connect to a network that isn't actually there.  sudo iw ${WIFI_ADAPTER} scan will need to be changed to sudo iw ${WIFI_ADAPTER} scan flush because after we run the exploit, the SSID changes from smartlife's prefix to the A- prefix, and the previous scan still has the smartlife one present in the list, and will only try to connect to that indefinitely.  Adding flush appears to take care of that.

The only RPI I have around I cannot use it, because it is running already a project that needs to be open 24/7 :-/. Which iw commands fail on your Pi? About the commands: what if we encapsulate the nmcli / non-nmcli commands on functions their respective files, and we source those files depending on an argument? This way the code will be cleaner.
I have just pushed a commit adding the flush.

The only RPI I have around I cannot use it, because it is running already a project that needs to be open 24/7 :-/.

No worries, I'll spend some time toying around with it and see if I can find a better way.

Which iw commands fail on your Pi?

sudo iw dev ${WIFI_ADAPTER} connect "${AP_MATCHED_NAME}" silently fails, and it gets stuck in the loop checking the link response for a gateway.  We're going to need to add some timeout there so it can re-issue connect commands somehow.  The connect command itself silently fails, but if you hook into sudo iw event I get the message
wlan0 (phy #0): connected to d8:1f:12:47:6d:d8
wlan0 (phy #0): disconnected (local request) reason: 3: Deauthenticated because sending station is leaving (or has left) the IBSS or ESS
phy #0: regulatory domain change: set to world roaming by the wireless core upon initialization request

The third message is not relevant, it appears it changes the regulatory domain every connect.  Some internet searching says this may only happen on newer versions of Raspberry pi, but I'm not certain.  It may have something to do with the unprotected nature of SmartLife APs and the running wpa_supplicant service may be causing part of the issue.

About the commands: what if we encapsulate the nmcli / non-nmcli commands on functions their respective files, and we source those files depending on an argument? This way the code will be cleaner.

Yes, if we have to resort to supporting both, that would be the ideal way, having a conditional source command and two files with the same function names to call.

I have just pushed a commit adding the flush.

Thanks!
I'll spend some more time trying to find the best way to deal with NetworkManager on RPi as I can.

I should also clarify, current instructions do currently include manually removing the wifi adapter from NetworkManager, but I am currently trying this against a clean install and attempting to avoid that step.  It's possible we may just need to enforce the same requirements already present when using a system with NetworkManager, which already needs changes when it is running anyway.
I'll keep playing around and see what I can come up with.

It appears we can accomplish this by issuing sudo nmcli dev ${WIFI_ADAPTER} managed no on machines with nmcli available and nmcli dev ${WIFI_ADAPTER} status not containing the string unmanaged
This may end up in safety_checks and give instructions on how to undo it (and attempt to automatically undo it if not aborted).

@Cossid Sorry for taking more time than expected for this, but I have hit an issue: After the success with last plug I have bought 3 more (Same model, Denver SHP-102) and... I cannot get them flashed. Thus, I am holding back the PR to prevent breaking the project. This is the log I am getting (part of the source of common_run.sh, before the actual firmware is flashed):
Found access point name: "SmartLife-F8BF", trying to connect...
.
Internet Systems Consortium DHCP Client 4.4.3-P1
Copyright 2004-2022 Internet Systems Consortium.
All rights reserved.
For info, please visit https://www.isc.org/software/dhcp/

Listening on LPF/wlp52s0f4u2u3u2/d0:37:45:9f:57:64
Sending on   LPF/wlp52s0f4u2u3u2/d0:37:45:9f:57:64
Sending on   Socket/fallback
DHCPDISCOVER on wlp52s0f4u2u3u2 to <IP_ADDRESS> port 67 interval 4
DHCPOFFER of <IP_ADDRESS> from <IP_ADDRESS>
DHCPREQUEST for <IP_ADDRESS> on wlp52s0f4u2u3u2 to <IP_ADDRESS> port 67
DHCPACK of <IP_ADDRESS> from <IP_ADDRESS>
bound to <IP_ADDRESS> -- renewal in 1702 seconds.
Connected to access point.

Waiting 1 sec to allow device to set itself up...
Running initial exploit toolchain...
Exploit run, saved device config too!
output=/work/configured-devices/D6GaB88GRxye.deviceconfig
Saved device config in /work/configured-devices/D6GaB88GRxye.deviceconfig

================================================================================
Power cycle and place your device in AP (slow blink) mode again.  This can usually be accomplished by either:
Power cycling off/on - 3 times and wait for the device to fast-blink, then repeat 3 more times.  Some devices need 4 or 5 times on each side of the pause
Long press the power/reset button on the device until it starts fast-blinking, then releasing, and then holding the power/reset button again until the device starts slow-blinking.
See https://support.tuya.com/en/help/_detail/K9hut3w10nby8 for more information.
================================================================================

Scanning for open Tuya SmartLife AP

Found access point name: "SmartLife-F8BF", trying to connect...

In the previous plug, this showed and access point starting by A-, so it was OK. In this one, after power cycling it and setting it into the slow blinking mode.... the same SmartLife- AP is found. Might you know if this is a problem with the script or with the device?

In the previous plug, this showed and access point starting by A-, so it was OK. In this one, after power cycling it and setting it into the slow blinking mode.... the same SmartLife- AP is found. Might you know if this is a problem with the script or with the device?

Check the firmware version on that plug.  When it doesn't change to A-, that means the exploit wasn't effective.  It's quite likely some of the newer versions of the plug have different firmware.  It should be connecting and then telling you the exploit was unsuccessful though, not sure if that didn't happen or you truncated that part off.

@Cossid I am getting mixed results: on one hand it is not changing the SSID does not change to A-, but on the other hand every single time I run it is freezing for ~1' with the light on or off (in whatever state it is), and I have seen in the PoC script that is a sign for being exploitable. How can I check the firmware version on the plug?

The only way to check the firmware version is to add the device to Smart Life, and go to the Device Update menu option for the device, it will either tell you the current firmware version, or if there is an update available, what version that update is.
https://github.com/tuya-cloudcutter/tuya-cloudcutter/wiki/FAQ#how-do-i-find-out-what-firmware-version-my-device-has

@Cossid That's it, then: the version I am getting is 1.3.5, which shows as patched on the wiki. That is..... sad :_-(


Reference the control gallery image in the Control class documentation

Depends on https://github.com/godotengine/godot-docs/pull/4535.
Like the Tween cheatsheet or Color constants cheatsheet, this references a "cheatsheet" image from the documentation repository.

Thanks!

Cherry-picked for 3.2.4.


Clarifies create-a-pipeline docs

This PR addresses https://github.com/dlt-hub/dlt/issues/492
Alternatives
Instead of asking the user to cd my_new_directory we could put:
mkdir weatherapi_duckdb && cd "$_"

However, because it's less known and a bit cryptic I decided to be explicit with a simple cd.

@adrianbr Maybe the following is even better?


Add manpages

@mgree @angelhof I have not added an example yet. Any recommendations?

I have added some of the examples you proposed. Let me know if you would like me to add anything else :-)

BTW, let's also add the example to the README too (once it's finalized)

Good idea! We can mostly crib from the manpage, but it's good to have killer examples and installation instructions up front in a friendly way in the README.
On 2023-05-30 at 02:08:42 PM, Konstantinos Kallas wrote:

BTW, let's also add the example to the README too (once it's finalized)
--
Reply to this email directly or view it on GitHub:
https://github.com/binpash/try/pull/8#issuecomment-1569105924
You are receiving this because you were mentioned.
Message ID: @.***>

@angelhof @mgree I think this is ready to merge.


How to handle sysrepo-plugind crash?

If sysrepo-plugind crashes the NETCONF server will not return any message.
You can test this with the plugin turing-machine by editing:
--- a/examples/plugins/turing-machine.c
+++ b/examples/plugins/turing-machine.c
@@ -52,6 +52,8 @@ module_change_cb(sr_session_ctx_t *session, const char *module_name, sr_notif_ev
 {
     SRP_LOG_DBG_MSG("turing-machine configuration has changed.");

+    printf("string_val %s\n", ((sr_val_t *) private_ctx)->data.string_val);
+
     retrieve_current_config(session);

     return SR_ERR_OK;

After some NETCONF edit command the sysrepo-plugind will crash and NETCONF client will not get any message returned.

Hi,
having the referenced pull request merged, the client should receive time out error in case sysrepo-plugind crashes. I am not sure what more is there to do. Did you have something in mind?
Regards,
Michal

Hi,
I think a time out error is enough for now, thank you.
Regards,
Mislav

Well, I had something else in my mind. In case a sysrepo plugin crashes, it should be limited only to the plugin. Now, it affects all the plugins by shutting down the sysrepo-plugind. The daemon (libsysrepo) should check for the plugin crash when using its callbacks and in case of crash it should return an error and switch of the specific plugin while the others are still working fine.

If it's not a problem to implement that would be great to have.
Should I reopen this issue then?

We will see how big a challenge will it be.


Graviton 1 support

Hi, this is a GREAT project, but I own and RI on AWS that is 1st gen Graviton with older crypto
So when I try and pull opensearch I see
Fatal glibc error: This version of Amazon Linux requires a newer ARM64 processor
search-1  |                    compliant with at least ARM architecture 8.2-a with Cryptographic
search-1  |                    extensions. On EC2 this is Graviton 2 or later.
search-1  | Fatal glibc error: This version of Amazon Linux requires a newer ARM64 processor
search-1  |                    compliant with at least ARM architecture 8.2-a with Cryptographic
search-1  |                    extensions. On EC2 this is Graviton 2 or later.
search-1  | Fatal glibc error: This version of Amazon Linux requires a newer ARM64 processor
search-1  |                    compliant with at least ARM architecture 8.2-a with Cryptographic
search-1  |                    extensions. On EC2 this is Graviton 2 or later.
db-1      | syncing data to disk ... ok
Is there any way you can build for Graviton1 also or are you hardwired to using HW features of the Graviton 2?
Thanks
Ivan

@ivanbishop the opensearch docker image is provided by the opensearch community and not the inveniordm community. Ask for help there.

Shall do, thanks Martin.
If they have a graviton1, is it easy enough to make it part of the pull into your RDM offering? Via your compose file?
thanks
Ivan
From: "Martin Fenner" @.>
To: "front-matter/invenio-rdm-starter" @.>
Cc: "ivanbishop" @.>, "Mention" @.>
Sent: Monday, October 28, 2024 3:11:42 PM
Subject: Re: [front-matter/invenio-rdm-starter] Graviton 1 support (Issue #54)
[ https://github.com/ivanbishop | @ivanbishop ] the opensearch docker image is provided by the opensearch community and not the inveniordm community. Ask for help there.
—
Reply to this email directly, [ https://github.com/front-matter/invenio-rdm-starter/issues/54#issuecomment-2442770602 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/ABPMBW6UJHUUPZGIGCDK2EDZ52SA5AVCNFSM6AAAAABQV4QQPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBSG43TANRQGI | unsubscribe ] .
You are receiving this because you were mentioned. Message ID: @.***>

Note: OpenSearch images use Amazon Linux 2 as the base image for 1.x versions and 2.x versions up until 2.9.0, and Amazon Linux 2023 since 2.10.0.
I edited the docker compose file and simply told it to download opensearch
docker pull opensearchproject/opensearch:2.9.0
This build is ghraviton1 capable
The whole build process per your instructions ran smoothly
Will look at fixing allowed hosts ? as I can't browse the UI as yet on 7080 (I altered it from port 80 as it was in use) and I see all the docker ports open and mapped per docker ps -a

Are you using Docker Compose on a local computer or setting up infrastructure in AWS? For running Docker Compose locally you can override the settings, e.g. with an env file or another compose file.
For a local install you can set APP_ALLOWED_HOSTS = ['localhost', '<IP_ADDRESS>', '<IP_ADDRESS>']. In a production environment I would use a specific hostname.

setting up on AWS Martin, I'll add in my DNS server name , its a global name,not in Route53
Are there any specifics I should concern myself with for a "production" deploy?
many thanks
Ivan
From: "Martin Fenner" @.>
To: "front-matter/invenio-rdm-starter" @.>
Cc: "ivanbishop" @.>, "Mention" @.>
Sent: Thursday, October 31, 2024 12:44:57 PM
Subject: Re: [front-matter/invenio-rdm-starter] Graviton 1 support (Issue #54)
Are you using Docker Compose on a local computer or setting up infrastructure in AWS? For running Docker Compose locally you can override the settings, e.g. with an env file or another compose file.
For a local install you can set APP_ALLOWED_HOSTS = ['localhost', '<IP_ADDRESS>', '<IP_ADDRESS>']. In a production environment I would use a specific hostname.
—
Reply to this email directly, [ https://github.com/front-matter/invenio-rdm-starter/issues/54#issuecomment-2450689084 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/ABPMBWZMEOSG6KMWNEKERCTZ6KCDTAVCNFSM6AAAAABQV4QQPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQGY4DSMBYGQ | unsubscribe ] .
You are receiving this because you were mentioned. Message ID: @.***>

Using Docker Compose in a production environment with AWS is possible, but not typical. The invenio-rdm-starter Docker image can be safely used in production, but for container orchestration on AWS you would typically use ECS or EKS services. You can ask  other InvenioRDM project partners in the Invenio Discord Forum for their experience with AWS.

Yeah, I do a lot of ECS/EKS work. I want to run Invenio past those who will use it in anger and see if they like it. (I do) If they do, then  I'll plan to move it to EKS
thanks Martin


The @useAuth decorator does not support security requirements at the operation level

The Cadl Http library provides a @useAuth decorator that allows one or more security schemes to be defined and then applied globally to all operations. But some services need to define different security requirements for different operations, for example requiring a "read" scope for read operations but a "write" scope for write operations. Cadl should provide a mechanism to define security requirements at the operation level.

We decided that on purpose until we figured out a better way to have client level parameters.

Design proposal https://gist.github.com/timotheeguerin/56690786e61a436710dd647de9febc0f

implementation https://github.com/microsoft/typespec/issues/2624


Refactor get-showcase-data.ts script to run faster

Description
Currently the get-showcase-data.ts script runs for more than 6 hours, so GitHub automatically stops it and the action is marked as failed. Let's refactor the script, so it only generates images for the new links that appeared in the Awesome repo, and remove the ones we have locally in showcase.json but don't exist in the Awesome repo.

Hi @lazarnikolov94


Removing unused (and redundant) Parameter Category

Description
The Parameter Category volumeIntegrated is unused in ARMI and is not involved in any code that actual integrates volumes. More importantly, there is a ParamLocation.VOLUME_INTEGRATED attribute just a few lines lower that is actually used to deal with volume calculations.
So, this PR removes a single line of essentially dead code, with the goal of helping people understand "volume integrated Parameters" more easily.

Checklist

[X] This PR has only one purpose or idea.
[X] Tests have been added/updated to verify that the new/changed code works.

[X] The code style follows good practices.
[X] The commit message(s) follow good practices.

[X] The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
[X] The documentation is still up-to-date in the doc folder.
[X] The dependencies are still up-to-date in setup.py.

This looks ready to land @john-science whenever you are good.


docs: various changes and improvements

chore: rename readme files to uppercase
Enhancing docs

@kbudde @fritzduchardt I'm merging this now, but if you have any ideas or suggestions regarding documentation, I'd be glad to hear them :-)


Placeholder in prompt for existing rem content

Creating custom prompts is great. It could be even more powerful if the prompt text could contain a placeholder for an existing (selected) rem's content. For example:
Rephrase the following text so a third-grader can understand it: [rem]
This way, the prompts can relate to any selected rem by using the [rem] placeholder

Came here looking for exactly this.  Can't wait to try it!