Non-triviality conditions in theorems

@danflapjax @StevenClontz  Sorry I did not have the chance to comment.  But I don't think this change is an improvement.

I agree it is in general preferable to use "true" properties in theorems.  However that does not apply to "non-triviality conditions", i.e., conditions meant to exclude trivial uninteresting boundary cases from the discussion.  Things like "non empty" or "not indiscrete", etc.  Non-triviality conditions are often expressed as the negation of some property.

In this case, what we want to express is that R1 spaces are not hyperconnected.  And that holds mostly true, except in the trivial case that the space has the indiscrete topology.  So we say instead: If the space is R1 and we are not in a trivial condition, then the space is not hyperconnected.

But the new change turns this into: if the space is both R1 and hyperconnected, then we are in a trivial condition.  That is of course logically equivalent.  But the previous formulation is more natural, as that's the common one that is used when applying this to particular spaces, to determine if a space is hyperconnected or not.

Originally posted by @prabau in https://github.com/pi-base/data/issues/738#issuecomment-2327281261

Yeah, let's add this as an item for Friday's zoom meeting.

Does this need to be discussed at another Zoom meeting? What was the consensus at the previous one?
T109 is similar to the new version of T262 suggested by @danflapjax, so if some reversion were to be made (not that I have an opinion either way) then I think these should be changed together.
I'm not certain I understand the Issue, but I think it suggests that "non-triviality conditions" should not be positive conclusions of theorems. No theorem has Empty as a conclusion at present, though a few do have Indiscrete as a conclusion, as can be seen on the Indiscrete page. Are any other properties "non-triviality conditions"?

Agreed; I don't think we'll find a "right" way to do this for every scenario, so I think it's up to the opinion of the contributor and reviewer what makes sense in a given context, and eventually we can provide tooling as @danflapjax suggests to switch the consequence.

And given this discussion we had, I suppose this can be closed, but note the issue I made at pi-base/web to implement this UI change someday.

Our conclusion was that the underlying dispute (that is, the differing aesthetic preferences) would be better ameliorated by enhancements to the user interface than any style policy. As it stands, the site will only display proof or counterexamples of one converse of a theorem, but we should at least allow visitors to switch which property is treated as the consequence for this analysis.

@danflapjax @GeoffreySangston @StevenClontz
I agree that better tooling will let users explore different equivalent formulations of a theorem.
But the discussion was not simply about aesthetic preferences.  I still think it's more important to display a version of the theorem that is most likely to be useful to a user applying it to some situation.  And that is done by having the non-triviality condition as a hypothesis, and not by move it to a triviality condition in the conclusion.  (By moving that condition to a triviality condition in the conclusion, we will indeed have an equivalence between the hypotheses and the conclusion.  But who cares?  That's not an important thing at all.)

I sat here for a full five minutes trying to decide how to diplomatically respond to both of you, who I believe both make good points. And then I decided that we all have higher-impact things to do on this repository, so I'm moving on. (-:


feat(bigquery): save policy tags in column attributes

bigquery supports column level policy tags for securing access to sensitive data in columns through policyTags. fetch the policy tags assigned to a given column and save it as attributes in asset only when the column has policy tags defined.

closes #456

I had to make additional changes in this and rebased with master. It is causing issues since the asset type has changed from v1beta1 to v1beta2, which doesn't have Properties.Tags in Column.


[EMB-392] Show only bibliographic contributors in contributor lists

Purpose
Non-bibliographic contributors shouldn't be included in lists of contributors, except on the contributors management page (which isn't emberized yet).

Summary of Changes
Going by commit:

https://github.com/CenterForOpenScience/ember-osf-web/commit/c642fafe615328fe524837672ed4c4cec8b58d36: add bibliographic_contributors relationship to Node
https://github.com/CenterForOpenScience/ember-osf-web/commit/9b0831e9357275de6d049468f24d7fb4d7e42941: update <ContributorList> to use bibliographic_contributors
https://github.com/CenterForOpenScience/ember-osf-web/commit/0f38490fd11f64ea12fdebb2dc8cc6fe8a53a05f: go through the rest of the app, update include: 'contributors' to include: 'bibliographic_contributors and similar

Side Effects
The mirage implementation of bibliographic_contributors is kinda hacky and will have to be revisited when we implement contributor management. It's fine as long as all mirage contributors are created via server.create.

Feature Flags
n/a

QA Notes
There are a bunch of places that should not show non-bibliographic contributors anymore:

Registries: overview, components, links pages
Dashboard: main table and new/noteworthy
Forks page
Analytics page: "Linked by" list

Ticket

https://openscience.atlassian.net/browse/EMB-392
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md

Pull Request Test Coverage Report for Build 2594

14 of 17 (82.35%)  changed or added relevant lines in 10 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.03%) to 70.821%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/guid-node/forks/controller.ts
0
1
0.0%

app/guid-registration/forks/controller.ts
0
1
0.0%

lib/analytics-page/addon/application/controller.ts
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

lib/osf-components/addon/components/contributor-list/component.ts
3
83.08%

app/models/node.ts
4
83.21%

Totals

Change from base Build 2589:
0.03%

Covered Lines:
5646

Relevant Lines:
7188

💛  - Coveralls

Waiting to merge this until https://github.com/CenterForOpenScience/osf.io/pull/8944/commits/0fb07bd18c84c025d1163c08108fb21abfcd7e8b is released (or at least on develop)


Add a devcontainer open flag to open up a repo in VS Code in the dev container

In the command line I want to open VS Code and have it open directly into my dev container.
Right now I do this by running code . and then clicking the "Reopen in container" button but I'd love to just open straight to the project.
Something like: devcontainer open . would address my feedback and help me out a lot.
Thanks!

Hi @craigloewen-msft thank you for submitting this issue.
The devcontainers CLI is agnostic of the editor tools, so it may not fit well to add an open . command to launch vscode.
While understand this is not exactly what you are looking for, have you considered using the Open Recent (Ctrl+R) option inside vscode?
If you think it can be beneficial if the vscode extension can detect the container and automatically re-open the workspace folder in container, please consider filing an issue at https://github.com/microsoft/vscode-remote-release/issues


dicom data does not have pixel_array ?

dicom data does not have pixel_array?

Hello @hexiao-cs, could you detail more the issue? Did you try to preprocess the data with the notebook load_data.ipynb?

Closing the issue. Feel free to re-open it if needed.


BZ 1278756 - Isn't possible to move group of elements from container

@krisv PR for 6.3.x branch

+1  I just tested this and it looks good

Will be recreated.


fix(build): Vendor tree-sitter-hcl properly

git submodule is just way too painful!

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.81%. Comparing base (b3fb9fa) to head (1f91c31).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   86.81%   86.81%
=======================================
  Files          31       31
  Lines        1941     1941
=======================================
  Hits         1685     1685
  Misses        256      256

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Related: #95


Laravel migrate:refresh and schedule

Why artisan migrate:refresh make a call to schedule command from Kernel.php?

It doesn't?

I think it does when I call artisan migrate:refresh --seed.
In schedule() method I'm using a model to retrieve some infos and calling refresh  make errors that my model's table don't exist.


[BUG] [GraphScope-0.18.0a20221102]Load HDFS Data failed Install GraphScope locally without Kubernetes

Describe the bug
deploy locally without K8S
To Reproduce

loaded data from HDFS failed

# Install graphscope package if you are NOT in the Playground
!pip3 install -U graphscope --pre
!pip3 install -U graphscope-client --pre

# Import the graphscope module
import graphscope
import os
from graphscope.client.session import get_default_session
# 单机验证 加载图数据 from HDFS
from graphscope.framework.loader import Loader

graphscope.set_option(show_log=True)  # enable logging

sess = get_default_session()
graph = sess.g()

graph = (
        graph.add_vertices(Loader("hdfs:///home/ogbn_mag_small/paper.csv",host="xxx", port=9000), "paper")
        .add_vertices(Loader("hdfs:///home/ogbn_mag_small/author.csv",host="xxx", port=9000), "author")
        .add_vertices(Loader("hdfs:///home/ogbn_mag_small/institution.csv",host="xxx", port=9000), "institution")
        .add_vertices(Loader("hdfs:///home/ogbn_mag_small/field_of_study.csv",host="xxx", port=9000), "field_of_study")
        .add_edges(
            Loader("hdfs:///home/ogbn_mag_small/author_affiliated_with_institution.csv",host="xxx", port=9000),
            "affiliated",
            src_label="author",
            dst_label="institution",
        )
        .add_edges(
            Loader("hdfs:///home/ogbn_mag_small/paper_has_topic_field_of_study.csv",host="xxx", port=9000),
            "hasTopic",
            src_label="paper",
            dst_label="field_of_study",
        )
        .add_edges(
            Loader("hdfs:///home/ogbn_mag_small/paper_cites_paper.csv",host="xxx", port=9000),
            "cites",
            src_label="paper",
            dst_label="paper",
        )
        .add_edges(
            Loader("hdfs:///home/ogbn_mag_small/author_writes_paper.csv",host="xxx", port=9000),
            "writes",
            src_label="author",
            dst_label="paper",
        )
    )

Expected behavior
juputer log
2022-11-03 10:32:02,958 [ERROR][rpc:186]: Runstep failed with code: COORDINATOR_INTERNAL_ERROR, message: Error occurred during RunStep, The traceback is: Traceback (most recent call last):
  File "/home/data/anaconda3/lib/python3.9/site-packages/gscoordinator/coordinator.py", line 304, in _RunStep
    head, bodies = self._operation_executor.run_on_coordinator(
  File "/home/data/anaconda3/lib/python3.9/site-packages/gscoordinator/op_executor.py", line 684, in run_on_coordinator
    op_result = self._process_data_source(op, dag_bodies, loader_op_bodies)
  File "/home/data/anaconda3/lib/python3.9/site-packages/gscoordinator/op_executor.py", line 792, in _process_data_source
    _process_loader_func(loader, vineyard_endpoint, vineyard_ipc_socket)
  File "/home/data/anaconda3/lib/python3.9/site-packages/gscoordinator/op_executor.py", line 765, in _process_loader_func
    new_protocol, new_source = _spawn_vineyard_io_stream(
  File "/home/data/anaconda3/lib/python3.9/site-packages/gscoordinator/op_executor.py", line 740, in _spawn_vineyard_io_stream
    vineyard.io.open(
  File "/home/data/anaconda3/lib/python3.9/site-packages/vineyard/io/stream.py", line 157, in open
    return read(path, *args, handlers=handlers, **kwargs)
  File "/home/data/anaconda3/lib/python3.9/site-packages/vineyard/core/driver.py", line 127, in wrap
    return func(*args, **kwargs)
  File "/home/data/anaconda3/lib/python3.9/site-packages/vineyard/io/stream.py", line 72, in read
    raise RuntimeError(
RuntimeError: Unable to find a proper IO driver for hdfs:///home/ogbn_mag_small/paper.csv, potential causes are:
 read_dataframe: Traceback (most recent call last):
  File "/home/data/anaconda3/lib/python3.9/site-packages/vineyard/io/stream.py", line 61, in read
    r = reader(
  File "/home/data/anaconda3/lib/python3.9/site-packages/vineyard/drivers/io/stream.py", line 311, in read_dataframe
    stream = read_bytes(
  File "/home/data/anaconda3/lib/python3.9/site-packages/vineyard/drivers/io/stream.py", line 268, in read_bytes
    return launcher.wait()
  File "/home/data/anaconda3/lib/python3.9/site-packages/vineyard/drivers/io/stream.py", line 169, in wait
    r = proc.wait(timeout=timeout)
  File "/home/data/anaconda3/lib/python3.9/site-packages/vineyard/drivers/io/stream.py", line 65, in wait
    return vineyard.ObjectID(super().wait(timeout=timeout))
  File "/home/data/anaconda3/lib/python3.9/site-packages/vineyard/launcher/script.py", line 138, in wait
    raise RuntimeError(
RuntimeError: Failed to launch job [/home/data/anaconda3/lib/python3.9/site-packages/vineyard/drivers/io/ssh.sh localhost vineyard_read_bytes /tmp/vineyard.sock.1667442393.493992 "hdfs:///home/ogbn_mag_small/paper.csv" ...], exited with 255:
loadFileSystems error:
(unable to get stack trace for java.lang.NoClassDefFoundError exception: ExceptionUtils::getStackTrace error.)
hdfsBuilderConnect(forceNewInstance=1, nn=hdfs://xxx, port=9000, kerbTicketCachePath=(NULL), userName=(NULL)) error:
(unable to get stack trace for java.lang.NoClassDefFoundError exception: ExceptionUtils::getStackTrace error.)
/arrow/cpp/src/arrow/filesystem/hdfs.cc:52: Failed to disconnect hdfs client: IOError: HDFS hdfsFS::Disconnect failed, errno: 9 (Bad file descriptor)

extra diagnostics are as follows: Cannot initialize such filesystem for 'hdfs:///home/ogbn_mag_small/paper.csv', exception is:
Traceback (most recent call last):
  File "/home/data/anaconda3/lib/python3.9/site-packages/vineyard/drivers/io/adaptors/read_bytes.py", line 130, in read_bytes
    fs = fsspec.filesystem(protocol, **storage_options)
  File "/home/data/anaconda3/lib/python3.9/site-packages/fsspec/registry.py", line 284, in filesystem
    return cls(**storage_options)
  File "/home/data/anaconda3/lib/python3.9/site-packages/fsspec/spec.py", line 76, in __call__
    obj = super().__call__(*args, **kwargs)
  File "/home/data/anaconda3/lib/python3.9/site-packages/fsspec/implementations/arrow.py", line 235, in __init__
    fs = HadoopFileSystem(
  File "pyarrow/_hdfs.pyx", line 89, in pyarrow._hdfs.HadoopFileSystem.__init__
  File "pyarrow/error.pxi", line 143, in pyarrow.lib.pyarrow_internal_check_status
  File "pyarrow/error.pxi", line 114, in pyarrow.lib.check_status
OSError: HDFS connection failed

``
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

GraphScope version: 0.18.0a20221102
OS: Linux
HDFS version: 3.2.2

Additional context
Add any other context about the problem here.

Please ensure your classpath for hadoop is correctly exported.
export CLASSPATH="$($HADOOP_HOME/bin/hdfs classpath --glob)"

thanks!
I'm testing.
there are tow questions:

Do you also need to configure $HADOOP_HOME when deploying through k8?
Is there any framework and code interpretation article in the community, I want to be able to Trouble Shotting quickly

Please ensure your classpath for hadoop is correctly exported.
export CLASSPATH="$($HADOOP_HOME/bin/hdfs classpath --glob)"

add CLASSPATH=.$CLASSPATH:"$($HADOOP_HOME/bin/hdfs classpath --glob)"  /etc/profile
source /etc/profile
lunch jupyter
it's running

@JackyYangPassion Thanks for the feedback!
Closing as resolved.

thanks! I'm testing. there are tow questions:

Do you also need to configure $HADOOP_HOME when deploying through k8?

Our official docker image have already sourced the environment, see our test case on Kubernetes: https://github.com/alibaba/GraphScope/blob/main/python/graphscope/tests/kubernetes/test_demo_script.py#L116

Is there any framework and code interpretation article in the community, I want to be able to Trouble Shotting quickly

Please refer to our wechat public account "GraphScope".
We have documentation and blogs as well.


Reason for new permissions

Thanks for your work on this extension. It's made things a lot easier.
Could you explain why the permission requirements of the extension have changed recently? The latest change will reveal the user's email address. It would be a good idea to explain why each permission is necessary on the extension's description page.

Superclarkk,
Thank you for your feedback.  Also for your suggestion to add an explanation to the description page.  I've updated the Chrome Web Store's description.
The only permission that was changed was "Know your email address" and I've explained other places why I made the change.  In short, it was to better understand my user base.  Here is the beginning of a blog post I've written and a thread on Reddit which may give you more insight:
http://june07.com/foff
https://www.reddit.com/r/node/comments/5t8psv/node_inspector_manager_is_great_but_the_new/

Thanks for your reply, @june07. Sorry to hear that you've had some undeserved negative feedback from other users. Great job on clarifying the permissions on the description page, which will make it especially easier for new users to understand.


Bug: Floating divide by zero error when reading input volcanic emissions in GOCART/SU with UFS

A floating divide by zero error occurs in MAPL_BaseMod > MAPL_GetHorzIJIndex() > cube_xy() while reading in volcanic emissions in GOCART2G_GridComp/SU2G_GridComp/SU2G_GridCompMod.F90 when running UFS-GOCART built in debug mode on Orion. Relevant stack trace information are provided below:
forrtl: error (73): floating divide by zero
Image              PC                Routine            Line        Source
ufs_model          000000000A5E9C4B  Unknown               Unknown  Unknown
libpthread-2.17.s  00002B512D4CB5D0  Unknown               Unknown  Unknown
ufs_model<PHONE_NUMBER>1385DB  mapl_basemodmapl_        3701  MAPL_Base.F90
ufs_model<PHONE_NUMBER>134931  mapl_basemod_mp_m        3510  MAPL_Base.F90
ufs_model<PHONE_NUMBER>DCAA5D  su2g_gridcompmod_         868  SU2G_GridCompMod.F90
ufs_model<PHONE_NUMBER>DBC198  su2g_gridcompmod_         719  SU2G_GridCompMod.F90

The MAPL library (branch: main, revision bc57d97c) was built without debug flags and with BUILD_WITH_FLAP=NO.

I'm adding @bena-nasa to this ticket.    He's more experienced with GetHorzIJIndex for the CS grid.
@rmontuoro - any clue as to what was different about this particular run?   Clearly GOCART has run successfully many times, and no changes have been made recently in  that bottom most routine.

The division at that line has SIN(LAT) as the denominator.    Presumably the CS grids in GEOS don't quite have points right at the pole (cell corner is at pole, but centers are slightly displaced), but the NOAA CS grid does.   (But this surprises me, since we nominally both get our grids from the FMS / FV layer.)
Aside from this, the code in MAPL should not need to do such divisions.   I would expect a robust algorithm could be implemented that just checks for inclusion within specific regions.      I could be wrong though.

I talked with Rafeale and Williams yesterday. We found a couple things, for example the grid coming in from UFS is in degrees, this assumes the points were radians. There were a few other assumptions in there (the fuji rotation) Also this is not using the centers, only the corners.
This needs to be rewritten to be more robust in any case. What is the trig to tell if a point is in a rectangular polygon defined by great circles. That would avoid what I did here where I convert to the 2D cartesian points on the face and search there.

Are  the coordinates for the grid or for the volcano emissions?

This takes an arbitrary list of coordinates and an ESMF grid. Then for each coordinate we want to know, is it in the local domain? If so what are the indices of the cell in that domain that contain that point so you have to search. So there are two coordinate sets the grid and the arbitrary list of points.
I thought maybe ESMF locstream -> grid transform could do this but I'm not thinking so since we want to really aggregate points in each cell, not simply sample say the nearest.

Overall, the current approach also seems expensive.    E.g., there may just be 1 volcano at a given time, and yet essentially all the entire grid is brought into memory.      I'm wondering if the C5760 runs are being impacted by this?
If ESMF regridding can do the job, great.   Otherwise, a bisection algorithm will significantly reduce the cost without requiring any unsafe divisions.

Bill said he is not running gocart for c5760 run

@tclune - this test run is using volcanic emissions, which were not included in previous runs.
Transforming the grid coordinates to radians fixed the problem, however a more general strategy is needed to properly handle:
(a) coordinate units

Option 1: MAPL could check the coordinate units and perform a proper conversion. This needs to be done both in base/MAPL_Base.F90 and base/MAPL_OrbGridCompMod.F90 (code replication):

        call ESMF_GridGet(grid, coordSys=coordSys, rc=status)
        _VERIFY(STATUS)
        if      (coordSys == ESMF_COORDSYS_SPH_DEG) then
          conv = PI_R8 / 180._ESMF_KIND_R8
        else if (coordSys == ESMF_COORDSYS_SPH_RAD) then
          conv = 1._ESMF_KIND_R8
        else
          _ASSERT(.false., "unsupported coordinate system")
        end if
        ...
              EdgeLons_ = conv * EdgeLons_
              EdgeLats_ = conv * EdgeLats_

Option 2: MAPL could create a deep copy of the external grid, converting the coordinates to radians if needed

(b) coordinate shift (Fuji rotation)

The UFS global cubed sphere grid is indeed shifted away from Japan and the default setting is consistent with the correction implemented in MAPL:

        LAT=LATS(I,J)
        LON=LONS(I,J)+MAPL_PI_R8/18.0d0

Since we are allowing MAPL to use external grid, however, a more general approach should be implemented. Not sure how to determine the shift from the grid itself. Could such a shift be bypassed in cube_xy() and related methods?

I'm just going to try to implement a more general algorithm for the cube. So hopefully that should make the shifting irrelevant. You can apparently retrieve the coordinate type with a MAPL_GridGet call so that can take care of any radians/degrees confusion for anything needing to use the coordinates. I'm going to work on this now so hang tight.

Thanks a lot @bena-nasa! I look forward to the new implementation.
The question on whether we should create a full copy of the external grid for MAPL still remains, and may help address this issue. What's your preference?

No, I don't think you need to make a full copy.  We can determine the coordinate type so no need to make a copy with different units.

The actual offset used should not affect the algorithm.  The grid is a set of coordinates and we're just implementing an (efficient) search to find the cell that contains a given point.      I'd otherwise hate to try to "guess" the offset from data.
Even the radians issue will probably evaporate once the new algorithm is in place.        I may need to better understand how/if ESMF detects radians vs degrees when doing regridding though.   Apparently that has been working so somehow ESMF must be able to detect this.

ESMF regridding is done in Cartesian coordinates. The coordinate system of the Grid, Mesh or LocStream that is being used to represent the coordinates of the data that is being regridded is specified at creation time.

Making this contingent for now. When I ran both algorithms simultaneously and compared the assigned indices it never complained that they did not match. But now after stripping out the old algorithm I'm finding it is non-zero diff so I'm confused. I'll do some more checking but keep the PR as DNA to save retyping later.

Closing this as (for some reason) the autocloser didn't work...

Reopening as there was still a bug in the updated implemention

Yes this should be fixed


Update Footer.vue

Why we create this PR?
Legal notice added to the Footer
PR Linked to:
https://jira.catena-x.net/browse/CMP-698

This is the very first commit to this task. Just wanted to align what exactly should be added here and in what form.
Links might be wrong and the layout is just basic.

Can we take the commit id directly not the link?
@saudkhan116 can we come with a solution to inject in the frontend through the helm charts?

Now this can be included


Styling for the header of the DataGrid Widget

Is your feature request related to a problem? Please describe.
I want to be able to style the header ( Column ) for the DataGrid. Like changing the font size, family, background etc for the COlumn headings, etc.
Describe the solution you'd like
Can be like this, so I can choose to remove dividers ( vertical ). and set backgroundColor of each tab to to my wish.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Fixed in a recent PR for Stylistic Changes


transform tag into plain text

Hello,
I am trying to use the transformTags option, to transform an img tag to just plain text of the image src (for example). Could this be done?
Omer

No, but you could turn it into a span tag.
On Tue, Jul 26, 2016 at 6:14 AM, omerts<EMAIL_ADDRESS>wrote:

Hello,
I am trying to use the transformTags option, to transform an img tag to
just plain text of the image src (for example). Could this be done?
Omer
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/punkave/sanitize-html/issues/119, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB9fX4n1wqDWaU6-cV5ilClfuvYemriks5qZd4WgaJpZM4JU_i6
.

--
*THOMAS BOUTELL, *SUPPORT LEAD
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

span tag will not be visual in the dom, but it will still add uneeded tags in the data.


New releases not published to npm

The releases 2.10.0 and 2.10.1 are not in the npm registry:
<EMAIL_ADDRESS>

Done! thank you undergrunder for notifying it!
@AidasK i've still to grant you permissions on npmjs, let me know on whch mai i should generally enable you on this kind of things ;)
to publish the package generally after the release we should run npm publish

Bam! https://www.npmjs.com/~flowjs


Recordings for storage

Recordings for storage

/azp run cpp - storage

/azp run cpp - storage

Let me confirm one thing first, when running in LIVE mode, are different pipeline (Linux, Windows x64, Windows x86 etc.) running against the same storage account or different storage accounts? Since you've removed randomness, there could be problems if they run against the same account.

Yes, each pipeline creates an instance of storage, so, it won't be collision 💥

Finally got coverage for cpp - storage - ci:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=1277527&view=codecoverage-tab

Finally got coverage for cpp - storage - ci: https://dev.azure.com/azure-sdk/public/_build/results?buildId=1277527&view=codecoverage-tab

The coverage looks real good.

Finally got coverage for cpp - storage - ci: https://dev.azure.com/azure-sdk/public/_build/results?buildId=1277527&view=codecoverage-tab

The coverage looks real good.

It's a little bit below the real coverage from cpp - storage ( live test ) because some tests are LIVEONLY like sas and some tests depending on datetimes comparison

Hi @vhvb1989 ,this is a huge PR and it may take quite some time for me to review it. Unfortunately, I have some higher priority task to do recently. So maybe I cannot review it until Feb.

Can you hold on to any making changes to Storage tests?  Otherwise there would be lots of conflicts.
Also?  Since all these changes are for tests only. Can we just notice that the Coverage is still the same for approving?   And then you can gradually keep reviewing in the future and I can address any detail you see in there.
You know, waiting until Feb will be hard to keep this PR on sync

/azp run cpp - storage

All right, I'll try to spare some time to review this PR before Feb.

/azp run cpp - storage

/azp run cpp - storage

/azp run cpp - storage

/azp run cpp - storage


Cannot register two commands with the same id: timeline.refresh

Error: Cannot register two commands with the same id: timeline.refresh
at o in src/vs/platform/actions/common/actions.ts:586:9
at new me in out/vs/workbench/workbench.desktop.main.js:2194:17638
at b.j in src/vs/platform/instantiation/common/instantiationService.ts:119:18
at b.createInstance in src/vs/platform/instantiation/common/instantiationService.ts:85:18
at new te in src/vs/workbench/contrib/timeline/browser/timelinePane.ts:277:60
at b.j in src/vs/platform/instantiation/common/instantiationService.ts:119:18
at b.createInstance in src/vs/platform/instantiation/common/instantiationService.ts:85:18
at z.nb in src/vs/workbench/browser/parts/views/viewPaneContainer.ts:693:45
at z.nb in src/vs/workbench/contrib/files/browser/explorerViewlet.ts:220:16
at z.tb in src/vs/workbench/browser/parts/views/viewPaneContainer.ts:777:22
at z.create in src/vs/workbench/browser/parts/views/viewPaneContainer.ts:538:9
at z.create in src/vs/workbench/contrib/files/browser/explorerViewlet.ts:178:9
at z.create in src/vs/workbench/browser/panecomposite.ts:47:26
at f.ub in src/vs/workbench/browser/parts/compositePart.ts:227:14
at f.ub in src/vs/workbench/browser/parts/paneCompositePart.ts:218:9
at f.sb in src/vs/workbench/browser/parts/compositePart.ts:151:8
at f.rb in src/vs/workbench/browser/parts/compositePart.ts:115:15
at f.ic in src/vs/workbench/browser/parts/paneCompositePart.ts:390:15
at f.openPaneComposite in src/vs/workbench/browser/parts/paneCompositePart.ts:364:16
at f.H in src/vs/workbench/browser/parts/paneCompositeBar.ts:214:28
at a.value in src/vs/workbench/browser/parts/paneCompositeBar.ts:181:112
at o.y in src/vs/base/common/event.ts:1127:13
at o.z in src/vs/base/common/event.ts:1138:9
at o.fire in src/vs/base/common/event.ts:1162:9
at n.Z in src/vs/workbench/services/views/browser/viewDescriptorService.ts:465:39
at n.moveViewContainerToLocation in src/vs/workbench/services/views/browser/viewDescriptorService.ts:313:8
at a.drop in src/vs/workbench/browser/parts/compositeBar.ts:60:32
at Object.onDrop in src/vs/workbench/browser/parts/paneCompositePart.ts:284:45
at Object.onDrop in src/vs/workbench/browser/dnd.ts:499:16
at HTMLDivElement.<anonymous> in out/vs/workbench/workbench.desktop.main.js:149:52335

Go to Errors Site

Caused by https://github.com/microsoft/vscode/issues/204994


Bug: Couldn't update page after cancellation

Environment
Host

item
version

OS
CentOS 7.6

GROWI
3.5.0-RC (d3a7702aaf542bc3f0deb259a2cfe0d414f83e97)

node.js
10.16.0

npm
6.9.0

Using Docker
yes (Kubernetes)

Using growi-docker-compose
no

Client

item
version

OS
macOS 10.14.5

browser
Chrome 75.0.3770.80

How to reproduce? (再現手順)

Open existing page
Switch to edit tab
Modify content
Click "Update"
Asked "Do you want to leave this page?" by browser and choose "Stay"
Click "Update" again

What happens? (症状)

Nothing happens to editor.
Got error in JS console:

Uncaught (in promise) Error: Posted param "revisionId" is outdated.
    at commons.a4a23a2e699c062ab33f.chunk.js:1

What is the expected result? (期待される動作)

Page updated successfully.

@shield-9 Thank you for your report. I have confirmed it was reproduced. I'll fix this soon.


Program not working. code=exited status=127

So when I run the program if gives an error.
I've followed every step and didn't see any errors running into the installation.
Im gonna put a picture where the code is.

Don't bash on me haha, kinda new into this sort of things.
bern

Line 5 says camera not found.
Can you figure out why?
Ken

Well the first attempt I forgot to put the camera in. In the second attempt I plugged it in.

Its always give the same error line:
allsky systemd: unit allsky.service entered failed state

I use the asi120mc. I've googled if they need any drivers for linux. And they said on the website you don't need any.

My camera is not running this week so i can't look, but what you need to do is one of two things:
find a *.log file with more info (possibly in /var/log)
or
run the program from the command line (capture I think it's calle) with the appropriate arguments and see what error messages spit out onto the screen
most likely the problem is some typo in your config file.   Using the web page version of the config will help catch some (but not all) errors.
Ken

What Raspberry Pi version are you using? Try a different USB port. Also make sure you’re using the recommended power adapter. If the camera can’t draw enough power, it will not be recognized.

What Raspberry Pi version are you using? Try a different USB port. Also make sure you’re using the recommended power adapter. If the camera can’t draw enough power, it will not be recognized.

SoI looked up my device number. And it had this code a02082, so pi 3 model b. The adapter is the one with the raspberry logo on. My debian version is 8.0.

two things:

is the camera detected: # lsusb -v | egrep -i 'zwo|asi'
does the pi user have permission to open the camera device? you might need to install some udev rules to permit the device properly, eg.

https://github.com/openastroproject/openastro/blob/master/udev/70-asi-cameras.rules
https://github.com/thomasjacquin/allsky/blob/master/asi.rules

Alright so I reinstalled everything. And it works now but it gives the following line when i check the status.

two things:

is the camera detected: # lsusb -v | egrep -i 'zwo|asi'

does the pi user have permission to open the camera device? you might need to install some udev rules to permit the device properly, eg.

https://github.com/openastroproject/openastro/blob/master/udev/70-asi-cameras.rules
https://github.com/thomasjacquin/allsky/blob/master/asi.rules

How do you run these commands. I've selected the line for my device. And when i run it, it mentions "attr(idvendor)==03c3,: command not found

Glad that it's working for you. I get that "can't get debug descriptor" too, and my camera works. I think you can safely ignore it.
You should just be able to type lsusb -v | egrep -i 'zwo|asi' at the command prompt.
As for the rules, I'm using custom rules because I'm doing special weird stuff that doesn't play nice with starting allsky from a udev rule. You don't actually run udev rules; udev(7) does that. You just need to make sure that it knows what to do by installing the rules into /etc/udev/rules.d/ which you seem to have done when you reinstalled. Have a look in there and you'll probably see some asi rules.

Alright this afternoon I'll try again. One other thing. When I run the program and try to connect with my laptop to https://allsky.local it mentions I can't connect it. Any idea why?

The .local address works if both computers have the avahi service instaled. The RPi should have it running under the name avahi daemon. Apple computers have it running under the name Bonjour. On linux you need to install avahi (apt install avahi-daemon) and on Windows I believe you may have it installed if you have iTunes installed or you can just install the Bonjour service independently.

Okay! I get the interface now. But i get the next thingies.

As you can see on the live view gives a black screen? And when i go on the dashboard tab it mentions "interface is down". When i run the allsky status thingy it doesnt say any errors.

On that first screenshot, the interface is down means your wifi is not running. You can see that the wireless info to the right has no details.
Click on Start wnlan0 to enable the wifi.
Then in the Configure Wifi tab, you can choose your network.

On that first screenshot, the interface is down means your wifi is not running. You can see that the wireless info to the right has no details.
Click on Start wnlan0 to enable the wifi.
Then in the Configure Wifi tab, you can choose your network.

If i run by internet cable wont it work?

Oh yeah it should work, I thought you were trying to fix the wifi issue.
Regarding the black screen, it looks like the liveview-image.jpg doesn't exist. Can you make sure that images are captured properly in /home/pi/allsky? The image.jpg should refresh periodically.
If it doesn't then we need to know why it's not making new images. You can run service allsky status to get more info.

Alright. Gonna do that tomorrow. Time for some sleep. The moment it works I'm gonna donate to you to support you. Great help dude!!!

Alright so. The interface works.

Now when i go to the specific folder you mentioned. I find the jpg file. But it gives a black screen.
So I've ran the status thingy and this pops up.

So close haha to get it working

What does image.jpg look like? Is it all black? Does it have the time in the upper left corner? Look at the timestamp it was last modified to see if it keeps updating.
Other than that, the admin portal seems to be running fine. The issue seems to be at the capture level.

The image had a time on it. Yesterday around 21 oclock.  I will try this evening again when i'm home.

What does image.jpg look like? Is it all black? Does it have the time in the upper left corner? Look at the timestamp it was last modified to see if it keeps updating.
Other than that, the admin portal seems to be running fine. The issue seems to be at the capture level.

This is the image I get.

And if he takes image where does he saves them?

That's the default image from the repository. It's not an image created by your camera.
Try running the program manually. First, stop the service (sudo service allsky stop) and then from the allsky directory: ./allsky.sh
There could be a few reasons why the capture is not starting. One of them is that the time on your RPi could be wrong or thew settings for lat/long for your position are not correct or DAYTIME is not set to 1, etc.

Ok. I've checked everything. My location is correct. Daytime is at 1. Time zone is correct on my rpi. I think im gonna give up haha. The live view is still bottle necking me. It gives the broken image thing.

These are the settings.

I would not even try installing the GUI until the capture is working. Installing the GUI won't fix the issue with the capture.
Make sure images are created in the images folder and then we can move forward to the GUI.
Running ./allsky.sh is your best option to find out what's happening. Look at the output of that command and paste it here.

This issue is from an older release of the AllSky software.  If you think it might still be relevant, please test it with the newest version and submit a new issue if needed.   Set the "debuglevel" to 3 to get additional information in /var/log/allsky.log that may help determine what the problem is.


Use BigInt instead of bn.js

@noble/* and @scure/* libs were audited by scure in Jan 2022
https://github.com/paulmillr/noble-hashes#security
https://github.com/paulmillr/noble-curves#security
https://github.com/paulmillr/scure-bip32#security
https://github.com/paulmillr/scure-bip39#security
https://github.com/paulmillr/scure-base#security

So no C++ needed anymore?

So no C++ needed anymore?

Yes correct, the C++ was also removed as part of this MR. The bindings depended on bn.js which this MR aims to deprecate.
The current implementation is slightly slower than the C++ implementation, but much closer in performance to the C++ implementation than the previous JS implementation:
Master (JS) ~ 2000ms
Master (C++) ~ 2ms
This MR (JS) ~ 6ms


NoMissingTypes does not work if the missing type is a return value of a method and the method has a parameter

Draft PR for https://github.com/openrewrite/rewrite/issues/4405, add tests to reproduce the issue.

@timtebeek Please help to perfect this fix if you are available, thanks.
Add some troubleshooting findings: it may related with this line:
https://github.com/openrewrite/rewrite/blob/main/rewrite-java/src/main/java/org/openrewrite/java/JavaVisitor.java#L874
m = m.getPadding().withParameters(visitContainer(m.getPadding().getParameters(), JContainer.Location.METHOD_DECLARATION_PARAMETERS, p));

This code will be called in org.openrewrite.java.search.FindMissingTypes.FindMissingTypesVisitor#visitMethodDeclaration because it will call super.visitMethodDeclaration which is org.openrewrite.java.JavaVisitor#visitMethodDeclaration. And the latter will in turn affect the seenTypes list of the former which causes the issue.

This is a tricky one @ckcd ; I've found a way to get the tests going in https://github.com/openrewrite/rewrite/pull/4406/commits/27fc614f9e51132d73b1f71534234c55d079774a , but I'm not quite sure I like the code change just yet. Could you help think through from your earlier analysis if this is in line what you were thinking?

@timtebeek Thanks for the fix!! And yes it's align with my analysis I think. I will try with the snapshot version once we have it.


Removing hardcoding on jiva volume delete scrub image

Currently, the image of the jiva volume delete scrub image is hardcode in runtask which can cause a problem in case of image upgrade. This hardcoding of image should be removed and the image name should be taken from env variable of m-apiserver.

Deuplicate https://github.com/openebs/openebs/issues/2344


use advanced querying to apply filters when fetching records

This PR changes how records are filtered. Until now, all records since a given point in time where fetched, and then filtered for the sites that should be reported. With this PR, the filter is already applied when the records are fetched, using the new advanced querying feature.
Closes #600.

Codecov Report

Merging #654 (dcd06f7) into main (bfc287c) will increase coverage by 2.65%.
The diff coverage is 76.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   63.52%   66.17%   +2.65%
==========================================
  Files          45        1      -44
  Lines        5658      408    -5250
  Branches       74       89      +15
==========================================
- Hits         3594      270    -3324
+ Misses       2064      138    -1926

Components
Coverage Δ

apel_plugin
66.17% <76.00%> (+1.22%)
:arrow_up:

auditor
∅ <ø> (∅)

slurm_collector
∅ <ø> (∅)

slurm_epilog_collector
∅ <ø> (∅)

htcondor_collector
∅ <ø> (∅)

priority_plugin
∅ <ø> (∅)


Problems installing OMChemSim

Thanks for this package.  tl;dr: Can you provide instructions for how to install the package?
** Longer version**
I received several errors when trying to run any of the examples related to imports.
First,  OpenModellica does like global imports (e.g., Simulator.Files.ThermodynamicFunctions.*) and throws up errors like the following:
[5] 22:17:07 Translation Error
[Simulator.Files.ThermodynamicPackages.RaoultsLaw: 4:5-4:53]: Import Simulator.Files.Thermodynamic_Functions not found in scope <top>.

[1] 22:17:10 Translation Error
[Simulator.Files.ThermodynamicPackages.RaoultsLaw: 4:5-4:53]: Import Simulator.Files.Thermodynamic_Functions not found in scope <top>.

I converted some of the global imports to direct imports as suggested here, but I continue to find more problems.

I am having the same problem.
None of the examples could be run. There are variables missing in the original packages.


Launch a bug report from command line

Golang has this feature and I think it is convenient as it starts a new bug report with some system information (version of the binary, OS version and more).
The command is used typing go bug. We could define godot bug or godot report.
Here is the file where the feature is implemented in Golang: https://github.com/golang/go/blob/b7d3f4c0b2f421c6b7bf6ce3533f1b34b470b39d/src/cmd/go/internal/bug/bug.go#L40

good idea.  i am no sure if this is windows only, but the console won't allow any user input. i guess that would could get changed though

I think this is quite a bad idea. Because making the process of raising an issue simpler means that we are going to have a lot more issue to deal with, which are more likely to be poorly written and to miss informations.
We already have a limited amount of human resources, such issues would not be welcome.
In general, I don't think we want to simplify the issue submission too much, so that people creating issues get really involved in the processus. It is the same reason we do not want automatic reports when Godot crashes. But @akien-mga could confirm I guess.

I don't think it is very different from opening the issues and clicking the "New issue" button which is already very simple.
If someone wants to create a low effort issue they will do it anyway as github makes is really easy. In fact, this could improve the quality of the reports as it could automatically include information which is missing in a lot of reports and sometimes is important for context.
It's not about making bad use easier, it's about easing the experience of reporting bugs automating the addition of system information.
If we keep it a terminal only feature I don't think a lot of people will abuse it.

I'm against having tools that report bugs in your place (i.e. you type a command or click a button and a bug report is created, without you ever visiting github.com).
I'm ok with adding tools that can load github.com in your browser with the issue template pre-filled with relevant information, and where the user would need to finish completing relevant stuff (description of the bug, backtrace, GIF, etc.).

The reason I left the up vote on the original proposal is, if we had a command that would let people make a report (since it's commandline, it'd be mostly reports that Godot doesn't work on their system), we could have a list of bad drivers that require GLES2 and -- maybe -- make Godot switch to GLES2 automatically.
For instance, I'm currently down to Intel HD 3000 and I find myself forgetting and trying to launch Godot only to get mad because it doesn't (not using 3.1 yet because well, it's not for production)

go bug doesn't create the issue, it just opens the browser with a new issue template with the system information.
In case of a failed request to "https://github.com/golang/go/issues/new?body=" it prints the body so you can copy paste it in a new issue:
https://github.com/golang/go/blob/b7d3f4c0b2f421c6b7bf6ce3533f1b34b470b39d/src/cmd/go/internal/bug/bug.go#L65-L69

Would implementing this as a command-line argument make sense, considering most Godot users never use the command-line interface?

Self-quoting:

if we had a command that would let people make a report (since it's commandline, it'd be mostly reports that Godot doesn't work on their system), we could have a list of bad drivers that require GLES2 and -- maybe -- make Godot switch to GLES2 automatically.

@Zireael07 I think the Godot project manager automatically fallbacks to GLES2, but the project creation dialog won't choose GLES2 in new projects automatically if your hardware doesn't support GLES3 (which causes various issues).

I seem to remember cases where some drivers claimed to support GLES3, but in truth didn't and various issues happened as a result?

@Zireael07 Godot will still start on such drivers, it will just be broken in various ways. Still, I don't think beginners are going to use the command-line interface (many of them don't even know how to open a command prompt).

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


Ensure knowledge docs are cloned into unique dirs

Previously, we were attempting to clone multiple knowledge documents into the same destination directory, leading to failures generating data for any run that contained 2+ knowledge leaf nodes.
Now, we clone docs into a guaranteed unique (via tempfile.mkdtemp) subdirectory per knowledge leaf node. Just using a subdirectory per leaf node could still have led to collisions if the user ran data generation twice within one minute, which is why this goes the extra step of using mkdtemp for guaranteed uniqueness.
Fixes #404

@Mergifyio backport release-v0.6

Still waiting on e2e-medium that is taking its sweet time working through some compositional skill testing, unrelated to this change. For the sake of expediency, I'm going to manually push the merge button on this one and get CI starting to run on the backport PR so they can happen simultaneously.


Generate manylinux wheels

This PR allows the plasma source to be installed without requiring a local build. It makes use of manylinux (as defined under pep 513) to create the build on a container that supports forward compatibility. In particular the Python install used is as provided by the container, not the GitHub version. The Python module auditwheel is used to ensure that the manylinux wheel is created successfully. This should be compatible with any CentOS 7 (or equivalent) and higher Linux operating system, by using the manylinux2014 standard.

This is just what we needed, thanks for figuring all this out
I would be tempted to put the published stuff back in but perhaps with these usernames PYPI_USERNAME and password PYPI_PASSWORD which I think @makeclean might have added to the settings
    - name: Publish wheel artifact
      env:
        TWINE_USERNAME: ${{ secrets.TEST_PYPI_USERNAME }}
        TWINE_PASSWORD: ${{ secrets.TEST_PYPI_PASSWORD }}
      run: |
        export PYVER=${{ matrix.python-version }}
        alias python=$(ls -d /opt/python/* | grep ${PYVER//.})/bin/python
        python -m pip install twine
        python -m twine upload --repository testpypi wheelhouse/*

Does it need something like so that the uploading only triggers when merging into master. Also I think we need to rename master to main branch at some point
on:
  push:
    branches:
      - master

@DanShort12 I can confirm that any has added github secrets PYPI_USERNAME and PYPI_PASSWORD

This is just what we needed, thanks for figuring all this out
I would be tempted to put the published stuff back in but perhaps with these usernames PYPI_USERNAME and password PYPI_PASSWORD which @makeclean has added to the repository settings
    - name: Publish wheel artifact
      env:
        TWINE_USERNAME: ${{ secrets.TEST_PYPI_USERNAME }}
        TWINE_PASSWORD: ${{ secrets.TEST_PYPI_PASSWORD }}
      run: |
        export PYVER=${{ matrix.python-version }}
        alias python=$(ls -d /opt/python/* | grep ${PYVER//.})/bin/python
        python -m pip install twine
        python -m twine upload --repository testpypi wheelhouse/*

The accounts used would depend on where we're uploading to. This snippet uploads to TestPyPI so it may not be the case that this shares credentials with production PyPI - although of course the same credentials could be used for both repos, in which case the same secrets could be used. I'm also not sure if a suitable account exists on TestPyPI (I used an account that I created myself when I checked the upload to TestPyPI).

Does it need something like so that the uploading only triggers when merging into master. Also I think we need to rename master to main branch at some point
on:
  push:
    branches:
      - master

I don't think we'd want this exactly - we still want to be able to run the rest of the workflow on a PR, otherwise the build and tests won't be applied to PRs, so there won't be any checks. I think we'd want something like the below so that the upload only happens on a tag:
if: startsWith(github.ref, 'refs/tags')

around the "Publish wheel artifact" action. PyPA actually have a guide with a suggestion of how to do that, which we could adopt (to upload to TestPyPI if the action isn't a tag, or to upload to PyPI if the action is a tag).
However, that still raises the question of how the PyPI packages will be versioned. Since TestPyPI and PyPI need unique versions for each upload we'd need some logic to generate clean versions on upload to PyPI and unique (timestamped?) versions when uploading to TestPI. How would you prefer to do that?

In the past I've used bump to update the version number automatically, but it might be best for the pull request to contain the incremented version number in the setup.py as the contributor knows if it is a major, minor or patch update
To upload to PyPi instead of TestPyPi we could replace
python -m twine upload --repository testpypi wheelhouse/*
with
python -m twine upload wheelhouse/*
But  I see the example uploads to TestPyPi every time and PyPi only if the commit is tagged which is a bit nicer.
    - name: Publish distribution 📦 to Test PyPI
      uses: pypa/gh-action-pypi-publish@master
      with:
        password: ${{ secrets.test_pypi_password }}
        repository_url: https://test.pypi.org/legacy/
    - name: Publish distribution 📦 to PyPI
      if: startsWith(github.ref, 'refs/tags')
      uses: pypa/gh-action-pypi-publish@master
      with:
        password: ${{ secrets.pypi_password }}

But then we get the version number problem. Do you want to use the patch part of the version number for PyPi and keen major and minor increments for PyPi uploads

I think we it will be tricky to use semantic versioning for the PR part, if pushes to a PR are going to generate an upload to TestPyPI - I think it's fair to assume that a developer wouldn't remember to bump a version number each time they are ready to push. Also IMO a PR shouldn't correspond to a new released version of the code - it's a potential new released version, but the actual released versions should align to tags in git (hence why PyPA suggest to only upload to PyPI on a new tag) e.g. a released version should be version x.y.z but a pre-release version in a PR should be x.y.z-some-metadata. If that's a suitable versioning method then we could just use the version described by git?
git describe --always --tags

That gives the release version if the commit corresponds to a tag (if annotated, which it should be for a release), else it gives the number of commits since the last release and the short git hash of the commit. Basically this. That seems like a nice way to keep versions distinct for TestPyPI, while still having some control over tagging actual releases.

Hi @makeclean, after a bit of GitHub wrangling I think this is nearly ready to run with a full CI chain (build, test, publish). Would it be possible to create a TestPyPI account that can be used to upload new versions of the package to TestPyPI when working under a PR?

Updated to use latest version on PyPI rather than by getting number of git commits. Should be more stable if multiple PRs are open.

It's not clear to me why the publish still fails - have the secrets in this repo been set up correctly?

It's not clear to me why the publish still fails - have the secrets in this repo been set up correctly?

Ah yes I see what you are saying, the github actions is reporting the pypi username password is not correct. This needs access to the repository settings to check

Sorry to be a pain @DanShort12 is there any chance this PR can be redirect to the new repository
https://github.com/open-radiation-sources/parametric-plasma-source


added note about GPO location change

#5418

#sign-off

@mapalko @Dansimp - PR has been copy edited and is ready for final review. This is based on issue #5418
Thank you.
cc: @kenwith

The PR has been approved by the document author.
Final review & merge can be done by the doc manager.