Update README

Since migration, readme is out of date. Update it so it has correct info.

Mostly updated with this commit. Leaving issue open, as I plan on making other substantial changes soon.


Support for Utimaco HSM (Cryptoserver v. 4.31 Simulator and LAN HSM), specially for Ed25519 curves.

Tested with Utimaco HSM (Cryptoserver v. 4.31 Simulator and LAN HSM). Added Edward curves (Ed25519) tests.

Reviewed


User-defined number of incorrect password attempts; wallet self destructs

Describe the solution you'd like
Not sure how useful this would be in practice, but perhaps having the option to specify a certain number of incorrect password attempts results in the wallet self destructing. Then it can only be recreated from the phrase/password used when the wallet was created.

We'll look at this if its ever needed.


Adding Stage/Scene

This is the start to the GUI. Will be adding more buttons to initiate the commands.

Improving basic layout


Update for Xcode 10.2 / Swift 5

bump version to 5.0.0
add swift version to podspec
remove file .swift-version (deprecated)
update project to recommended settings
update RSKPlaceholderTextViewExample

$ pod lib lint

 -> RSKPlaceholderTextView (4.0.0)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | [iOS] xcodebuild:  note: Planning build
    - NOTE  | [iOS] xcodebuild:  note: Constructing build description

RSKPlaceholderTextView passed validation.

NOTES:

still needs to be tagged and pushed to cocoapods obviously
@unknown default case for UIUserInterfaceLayoutDirection will cause an assertionFailure(_:) (see here)

@weakfl Hi,
Thanks for the PR!

Could you rebase your changes onto the master branch?
Also, I prefer to stay with .swift-version file. It is still useful for swiftenv. Could you restore this file?
Instead of assertionFailure(_:) for @unknown default case lets use the same calculations as for leftToRight case.

switch userInterfaceLayoutDirection {

case .rightToLeft:
    caretRect.origin.x = placeholderUsedRect.maxX - self.placeholderInsets.left

case .leftToRight:
    fallthrough

@unknown default:
    caretRect.origin.x = placeholderUsedRect.minX + self.placeholderInsets.left
}

@ruslanskorb done

@weakfl Thank you!

@ruslanskorb Can you please push the new release to cocoapods? Thanks ;)

@weakfl Already pushed - https://github.com/CocoaPods/Specs/blob/master/Specs/7/0/2/RSKPlaceholderTextView/5.0.0/RSKPlaceholderTextView.podspec.json

@ruslanskorb Thanks, probably just needs some time before it's available...

@weakfl Have you tried pod install --repo-update?

@ruslanskorb thanks, it's already available, although cocoapods.org is still listing version 4.0.0.


Improve database management, files storage management and sub-process management

Overview
This patch series include many change to have a even better handle of sub-process. The patch series include:

Change the management of end-points, now the service provide /wps, /status, /files URL
Refactor of Process and Services
Rewrite of Storage Back-ends
Dynamic status files (#354)
Implement optional file lock for the database access, after several test the current lock is not safe.

Missing peace:

Implementation of the back-end for S3 storage

More detail on patches series
Storage Back-end rewrite:
The rewrite of back-end storage, simplify the API of back-end storage by only allowing read and write and does not provide particular API for one or another Storage type (for example I removed the copy/move optimisation). Now files in the back-end storage may be exported. If they are exported they can be downloaded via /files endpoint using it's identifier. I did not implemented the S3 back-end because I can't test it, but I think there is nothing that blocking the implementation of the new API.
Multiple end-point:
This allow to implement dynamic status, and to manage files output via Storage back-end. There is no more direct file access, all files download goes through /files URL.
New locks scheme for databases.
The current lock scheme does not work, the filelock scheme is 100% safe in some setup, in particular one WPS server that access to the database. The filelock will not work if some process that is not aware of file lock try to access to the database or if the database is shared within several sever. I did not found a 'standard' lock method that is shared accross several database back-end thus I implemented this one.
I currently use this implementation on our server.
Best regards
Related Issue / Discussion
Additional Information
This contribution is supported by MINES ParisTech.
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[x] I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
[x] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

Coverage decreased (-0.07%) to 80.978% when pulling f6fa83f2afe5167a8758486a941ede2fb6adf254 on gschwind:fix-status-failed-pull-request into 85ca8191f1440e5906210408d2fa48c41f0ca679 on geopython:main.

I tried testing with https://github.com/bird-house/emu (a test and demo servier) and all processes failed.

I will have a look,
Thanks for feed back :)

Hello, after a first look I gather two issue.
The first one is fixed by 6e4e3aa394cfec59a61db1505d696affeff2c383 and it's due to change that make request url ends with /wps when wps is made, to separate /files or /status request. I may change that by using service query parameter instead, as exemple.
The second issue that I found is related to the new Storage handle, I do not store file immediately in the storage when we use code such as response.outputs["output"].file = "/some/path". and it's seems that during test temporary file vanish before I try to put them into the store. If I put the into a directory that do not vanish it's work. In test outputs files are stored in process.workdir, if I put them directly in "/tmp" every thing goes well.  I will investigate futher.

Hello,
I did fixed more test regarding previous comment here : https://github.com/gschwind/pywps-emu/commits/update-test
I have also some update to fix outputs storage, but I need to fix issue for inputs. I will try to fix it and update the branch once I got something that I'm confident with it.
And I still have the test test_wps_ncml.py that I cannot fix, and that is invalid test in my opinion, it tries to retrieve data from not-existing server. Thus the test should be rethinked using client.get(...) instead of d3.retrieveData()
Best Regards.

Hello,
I working on replacement of this patch suite, the first part is in #667
Best regards


Change user language of sign in page with ui_locales option (Auth)

Currently the sign in page can be translated to the customer's browser language by selecting
Enable language customization on the Languages tab of the User Flow in Azure AB B2C.
In our apps, the user can select another language than the device default language. We would like to be able to show the sign in page in the language selected by the user.
This should be possible in MSAL by setting the ui_locales option as described in Language customization in Azure Active Directory B2C.
Could you please add an option to AppCenter Auth to set the ui_locales option?
And please mention in the documentation for this option that ‘enable language customization’ must be turned on in the User Flow!

Hey @Forestbrook, thanks for using Auth!
Would you mind sharing a little more about your use case, and what are the key languages used by your apps? Also, would love to get your feedback on how the Auth experience is going for you. If you're keen to chat, please email me at amchew [at] microsoft [dot] com.

In smaller countries (like in my case The Netherlands) a lot of people do not set the default language to their own language. For several reasons, e.g. because they don’t like English websites to be translated automatically, or just because the phone is delivered with another default language.
But when they install an app which supports their home language, like our apps do, they switch to their home language. Now when the app is in Dutch, it would be strange when the logon page is shown in English.
Azure AD B2C is prepared for that, you can provide the query string parameter, ui_locales, with the language you want the logon page to show.
What I need in Auth is an option to set that ui_locales query string parameter.

Hey @forestbrook, thanks for the elaboration! Will speak to our team internally to explore providing the parameter, and will update again.

@Forestbrook  Thank you so much for your feedback. We announced this week in a blog post that we’re retiring the Auth and Data services later this year and recommending customers transition to Azure Active Directory B2C and Azure Cosmos DB instead. Let me know if you have any additional questions about this transition and i'll make sure to get them answered! Closing this issue.


Support cloud database for AWS.

Thanks Jin Hao for the contribution. Overall, it's great.  A few minor things and I can commit and then refine.


https://wiki.developer.mozilla.org/ru/docs/Learn/Server-side/Django/Введение$history

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[x] New documentation
[

] Correction or update
Details

The sentence in the Russian translation can be translated more correctly.
In the sentence "contained in the context variable inside the render () function above", "context" is the name of the variable.

https://developer.mozilla.org/ru/docs/Learn/Server-side/Django/Введение

Thanks for your report! Please note that MDN translations are maintained by the MDN wiki community. The few MDN staff don't speak Russian. Closing this issue, see also https://github.com/mdn/sprints#mdn-translations


Update Calico to v3.1.3

https://github.com/projectcalico/calico/releases/tag/v3.1.3
https://github.com/projectcalico/calico/releases/tag/v3.1.2
https://github.com/projectcalico/calico/releases/tag/v3.1.1

root@terom-pharos-master:~# kubectl -n kube-system rollout status daemonset/calico-node
Waiting for rollout to finish: 1 out of 4 new pods have been updated...
Waiting for rollout to finish: 1 out of 4 new pods have been updated...
Waiting for rollout to finish: 2 out of 4 new pods have been updated...
Waiting for rollout to finish: 2 out of 4 new pods have been updated...
Waiting for rollout to finish: 3 out of 4 new pods have been updated...
Waiting for rollout to finish: 3 out of 4 new pods have been updated...
Waiting for rollout to finish: 3 of 4 updated pods are available...
daemon set "calico-node" successfully rolled out

2018-06-21 11:55:52.953 [INFO][66] felix.go 147: Felix starting up GOMAXPROCS=1 buildDate="2018-05-30T17:16:03+0000" gitCommit="4d7bb9ad6ff7b34d1a79531121bc9e48d1123652" version="3.1.3"


Understand how to use the OTEL_SDK_DISABLED env var

https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-sdk-node#disable-the-sdk-from-the-environment
This is not disabling using this way:
( I don't know if that works for sdk-trace-node package )
➜  check-traces git:(remove-declared-deps) set OTEL_SDK_DISABLED true
➜  check-traces git:(remove-declared-deps) npm start

><EMAIL_ADDRESS>start
> NODE_OPTIONS='--require ./tracing.js' node .

Example app listening on port 8080
^C⏎
➜  check-traces git:(remove-declared-deps) curl -s http://localhost:14269/metrics | grep "check-traces"
jaeger_spans_received_total{debug="false",format="proto",svc="check-traces",transport="grpc"} 19
jaeger_spans_saved_by_svc_total{debug="false",result="ok",svc="check-traces"} 19
jaeger_traces_received_total{debug="false",format="proto",sampler_type="unknown",svc="check-traces",transport="grpc"} 5
jaeger_traces_saved_by_svc_total{debug="false",result="ok",sampler_type="unknown",svc="check-traces"} 5

Comment added in our Slack channel :v:


Theme submission: Showcase

Theme submission
Please make sure that you have read the theme submission guidelines before submitting a theme. The guidelines provide all relevant information and requirements that have to be fulfilled before the submission. We strongly suggest that you test your theme with the Hugo Themes Build Script before submitting the theme for review. If a submission does not meet the criteria mentioned in the README it will be closed. You may re-submit once you fix the problems with your submission. However, please note that we have limited resources and can not provide help for general web development issues. For Hugo support questions please refer to the dedicated support forum.
Please tick the relevant boxes for your theme in the checklist below:
Link to my theme repository: https://github.com/apvarun/showcase-hugo-theme
I made sure that...

[x] the repository contains a good README.md describing my theme
[x] an open source license has been added to LICENSE.md
[x] all metadata have been added to theme.toml
[x] screenshots have been added in the images/ folder with the required dimensions
[x] in case I'm using a customized demo via the exampleSite folder that

[x] https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
[x] I tested that my theme's demo works with the content directory of gohugoio/HugoBasicExample

[x] I tested my theme against the gohugoio/HugoBasicExample

[x] I've checked the developer tools' console in my browser for error messages

[x] in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo

N.B. By submitting a theme to the Hugo Themes Showcase you understand that you need to maintain your theme. If a theme demo breaks and remains broken then at some point it will be removed from the list without prior warning. If you no longer wish to maintain a theme please let us know.
New themes will usually be promoted on Hugo's official Twitter account. If you would like to be mentioned in the tweet please add your Twitter username to this submission.
Link to my Twitter account (optional): https://twitter.com/apvarun
Feel free to ask questions. We're glad to help.

Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.


Log number of concurrent branches during proof

Following up on #1883, we would like to have a log entry at each step for the breadth (number of concurrent branches) in the execution graph.

We only need to modify updateQueue so that it logs the size of the queue.


uniform variables error after updating model from gltf v1.0 to gltf v2.0

I am trying to update model from gltf v1.0 to gltf v2.0.
The following may occur in a gltf file:
"techniques":{  "a":{      "uniforms":{          "u_tex":"tex",          "u_tex2":"bakingTex"      }  },  "b":{      "uniforms":{          "u_tex":"bakingTex"      }  } }
But in the function moveTechniquesToExtension(gltf) of moveTechniquesToExtension.js,
the mappedUniforms variable is finally recorded as bakingTex -> u_tex and bakingTex -> u_tex2 information is missing.
This leads to errors in later use of uniform u_tex2.

@liukangkanglkk99 Thanks for all the details, it should be quick for us to track this down. If you are able to share the glTF that would be helpful too.

@liukangkanglkk99 I opened a fix here: https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/490.
Would you mind trying it out with your gltf?

With pleasure. I tested this and it does work.


belongs_to not considered in some routes

Using belongs_to during registration of a resource naturally uses the "parent" as a scope for the "childs" overview. The childs controller expects a "parent_id" for the index page and the routes ar
e crafted accordingly.
As it stands, though, the "parent_id" is necessary for the overview but is not processed in all url's where it would be necessary.
Imagine a nesting of Continent, Country and City resources:
ActiveAdmin.register Continent do
  #...
end

ActiveAdmin.register Country do
  belongs_to :continent
end

ActiveAdmin.register City do
  belongs_to :country
end

Now the breadcrumb path shown while looking at a city or a city overview does not mention Continent (because it's parsed from the URL which does not contain that datapoint)
and the part linking to the country misses the continent_id. Following the link fails. I found a workaround at least for the breadcrumbs. Works for me, but is possibly not generalizable.
Adding a comment under a country or city fails in both cases: they only infer admin_city_path and admin_country_path respectively as targets, not admin_country_city_path etc. Would not work anyway because they are not given the extra parameter on invocation.
Finally the json/csv/xml exports ignore the parent relationship, I managed to work around that by monkeypatching but I'm not sure if that covers all families of URL's to be expected.
For the time being handling the comments is more problematic as the routes are defined during namespace registration.
Could it be that I'm on the wrong path using belongs_to? I can imaging that scope_to would work also, at the expense of adding the parent_id in al URL's which would fail also in the comment case.
Anyone else ran into this problem? Might also be the case that I overlooked something completely obvious ...
Cheers and thanks a lot so far!
download link fix:
class PaginatedCollection < ActiveAdmin::Component
   protected
   def build_download_format_links(formats = [:csv, :xml, :json])
      links = formats.collect do |format|
        #old: link_to format.to_s.upcase, { :format => format}.merge(request.query_parameters.except(:commit, :format))
        tmp_p = request.fullpath.split('?')
        new_path = tmp_p[0] + ".#{format}?" + tmp_p[1..-1].join('?') #the ugly fix
        link_to(format.to_s.upcase, new_path)
      end
      text_node [I18n.t('active_admin.download'), links].flatten.join(" ").html_safe
   end
end

The breadcrumb fix tries to establish the first notion of an instance mentioned in the path and works itself up along the belongs_to path.

I'm seeing the same problem, the routes don't seem to get built out all the way up the belongs_to relationships.

I've written a hack to do this, this block below shows what I added to lib/active_admin/router.rb right after it sets up the parent route:
  # Add the next parent if it exists
  # This is horrible and should be done recursively
  if config.belongs_to? && config.belongs_to_config.target.belongs_to?
	routes_for_belongs_to_belongs_to = route_definition_block.dup
	route_definition_block = Proc.new do
	  # If its optional, make the normal resource routes
	  instance_eval &routes_for_belongs_to_belongs_to if config.belongs_to_config.target.belongs_to_config.optional?

	  # Make the nested belongs_to routes
	  # :only is set to nothing so that we don't clobber any existing routes on the resource
	  resources config.belongs_to_config.target.belongs_to_config.target.underscored_resource_name.pluralize, :only => [] do
		instance_eval &routes_for_belongs_to_belongs_to
	  end
	end
  end

I'm sure this is possible to generalise so it will act recursively, but I don't have the ruby knowledge to do so. However this will add ONE extra level of nesting, and can add as many as you need if you duplicate it again and modify it a little.
Feel free to use this in creating a pull request once it's less of a hack - if someone gives me a hand I'll do it myself.

I also had to use inherited_resources Nested belongs to : https://github.com/josevalim/inherited_resources
ActiveAdmin.register City do
  belongs_to :country do
    belongs_to :continent
  end
end

I've written the start of a patch for this ( https://github.com/alzeih/active_admin/compare/master...patch-2 ) but it has a couple of caveats that I think should be fixed before it is merged in:
It only uses the  belongs_to :continent, :country syntax for now - another belongs_to or a block won't nest them like the inherited_resources syntax
(As above) The routes are only generated by one extra level.

Having this would be fantastic. I'm currently having to use a link with an appended param akin to ?q[country_id_eq] in order to get users to a resource three levels down.

Here's what I did. It's a minor monkeypatch on AA's breadcrumbs function (I keep the old one as a fallback) and some recursive hierarchy-tracing, following belongs_to relations.
There is a lot of defensive coding which might be not necessary and it might be a bit terser. Pull my ears if you find mistakes or no-no's , mind though, that the solution depends strongly on innards of the AA namespaces and might not work for future versions.
This approach still relies on the url and tries to give a complete upward path for all :belongs_to parents
I removed all defensive coding below to keep it readable.
monkeypatch
 module ActiveAdmin::ViewHelpers::BreadcrumbHelper

  alias :old_breadcrumb_links :breadcrumb_links

  def breadcrumb_links(path=nil)
    path ||= request.fullpath
    parts = path.gsub(/^\//,'').split('/')
    crumbs = []
    crumbs = Extension::HierarchySolver.crumble(parts)
    if crumbs
      crumbs.pop if parts.last =~ /^\d$/
    else
      crumbs = old_breadcrumb_links(path)
    end
    crumbs
  end
end

lib/extension/hierarchy_solver
module Extension
  class HierarchySolver
    class << self
      include ActionView::Helpers::UrlHelper
      def crumble pa
        namespace        = pa.first
        first_class_desc = make_combination(pa).reverse.find{|p| p[1] =~ /\d/}
        first_class      = instantiate(*first_class_desc)
        crumbs = [link_to(namespace.titlecase,'/' + namespace)]
        chain = find_parent_chain(namespace,first_class)
        chain.each_with_index do |inst,index|
          if index > 0
            parent = chain[index-1]
            indexpath = '/' +  [namespace,parent.class.name.underscore.pluralize,parent.id,inst.class.name.underscore.pluralize].join('/')
          else
            indexpath = '/' + [namespace,inst.class.name.underscore.pluralize].join('/')
          end
          detailpath = "#{indexpath}/#{inst.id}"
          crumbs << link_to(inst.class.name.underscore.pluralize.titlecase,indexpath)
          crumbs << link_to((inst.respond_to?(:display_name)) ? inst.display_name.titlecase : inst.id, detailpath)
        end
        crumbs
     end
     #this only works if the belongs_to parent-attribute is named following conventions:
     def find_parent _ns,object
        @nss ||= ActiveAdmin.application.namespaces
         ns = @nss[_ns.to_sym]
         resource = ns.resources.find_by_key(object.class.name)
         return nil unless resource.belongs_to?
         target = resource.belongs_to_config.target.underscored_resource_name
         object.send(target.to_sym)
      end

    private
      def instantiate clazz,id
        begin
          parent_class = clazz.singularize.camelcase.constantize
          obj = parent_class.find(id.to_i)
        rescue
          nil
        end
      end
      def make_combination arr
        #["admin", "things", "2", "apples", "1", "edit"]
        #->  [["admin", "things"], ["things", "2"], ["apples", "1"]] etc ...
        arr.zip(arr.dup.push(nil)[1..-1]).select{|item| (item[0] =~ /\d/).nil? }
      end
    end
  end
end

@davidmathei I tried out your monkey patch, but it seems that find_parent_chain is missing; I tried writing my own replacement, but failed since I didn't really understand the code:
  def find_parent_chain _ns,object
    result = []
    while 1
      parent = find_parent _ns,object
      if parent.nil?
        return nil if result.empty?
        return result
      end
      _ns = parent.belongs_to_config.target.underscored_resource_name
      result << object.send(_ns.to_sym)
      object = instantiate(_ns,resource.id)
    end
  end

Oops ... sorry ... I had to edit the code heavily to edit out some project specific things and have not tested the code in isolation. At least: thanks for trying :-)
Here is the missing function, using find_parent and calling itself recursively.
  def find_parent_chain _ns,object, chain = []
    if object
      find_parent_chain(_ns,find_parent(_ns,object),chain.push(object))
    else
      chain.reverse
    end
  end

No more exception! Think I need to actually figure out how to use recursive methods properly some time...
It seems that the breadcrumbs don't seem to be right just yet, but I'll continue hacking at this code. Thanks for it :)

Alright, I sadly gave up on that code, but I did find a temporary workaround through looking at #78 and #977.
You'll need to create routes manually, so with the OP's example, you'd write:
namespace :admin do
  resources :continents do
    resources :countries do
      resources :cities
    end
  end
end

In cities.rb, instead of a standard belongs_to, write this:
controller do
  nested_belongs_to :continents, :countries
end
menu false

And bam, you're done! So for this to be fixed, there just needs to be proper auto-generation of routes; this explains why the menu false was needed, as you'll get the resource listed in the menu, and have routes like admin_cities generated.

@a2h - my patch above will generate the routes to three levels deep, and with some duplication can do as many as you need. I've been too busy to figure out how to make it work more generally for any levels of nesting, but I don't see it as impossible to do.

Did anything similar ever get merged in?

Is this considered an ActiveAdmin bug or an inherited_resources issue?

No more exception! Think I need to actually figure out how to use recursive methods properly some time...
It seems that the breadcrumbs don't seem to be right just yet (I'm three levels down and it shows HOME / Third-Level-Model), but I'll continue hacking at this code. Thanks for it :)

@rzhw works perfectly


doc: clarify consequences of lib.meta.setName

And remove unnecessary mention of nix-env
Description of changes
Tracking issue: https://github.com/NixOS/nixpkgs/issues/265058

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/2024-05-15-documentation-team-meeting-notes-127/45466/1


Introduce '@EnabledIfDockerAvailable' JUnit 5 annotation (#8613)

Introduces a @EnabledIfDockerAvailable annotation to conditionally enable a JUnit 5 test only if Docker is available (as proposed in #8613).
To reuse the same "Docker-available"-detection as in TestcontainersExtension this piece was extracted to a new class DockerAvailableDetector, which is then used by both.

Thanks for your contribution, @eidottermihi !


Unnecessary go routine spawn.

https://github.com/prometheus/prometheus/pull/7879
Refer to this issue

Thanks!


jquery uniform is not a function

Laravel Mix Version: 2.1.14
Node Version (node -v): v10.6.0
NPM Version (npm -v): 6.4.1
OS: Windows 10 x64

Description:
With a fresh laravel install i'm trying to display a uniform styles but i get this error :
Steps To Reproduce:
install package
npm install --save jquery.uniform

in boostrap.js
.
.
try {
    window.Popper = require('popper.js').default;
    window.$ = window.jQuery = require('jquery');

    require('bootstrap');

    require('jquery.uniform');
} catch (e) {}
.
.

in app.js
require('./theme');

in theme.js
        document.addEventListener('DOMContentLoaded', function () {
            $('.radio').uniform();
        });

in webpack.mix.js
mix.options({
    processCssUrls: false
});

mix.extract(['vue', 'lodash', 'popper.js', 'jquery', 'bootstrap', 'jquery.uniform']);

mix.autoload({
        jquery: ['$', 'window.$', 'window.jQuery', 'jQuery']
    });

mix.js('resources/js/app.js', 'public/js');

in console
Uncaught TypeError: $(...).uniform is not a function

So I hope someone help me... thanks.

What's causing this is mix.autoload, since it will prepend var $ = require('jquery') to every location that it encounters either the global $ identifier, or window.jQuery as mentioned in the docs.
A workaround for this is to remove mix.autoload from webpack.mix.js. This will force ./theme.js to use window $.

error in console jQuery no defined

Try removing mix.extract?

using alone
mix.js('resources/js/app.js', 'public/js');

I have no problem but I would like to have plugins separated in vendor.js

Could be one of the dependencies messing up with the vendor.js. Try starting with mix.extract(['jquery']); and adding one by one to find which dependencies are responsible.

dependencies "jquery.uniform" in extract cause error

Can't think of anything regarding jquery.uniform.
It's doing some monkey patching on jQuery when required, which messes up with webpack's common chunks extraction.
You could use a CDN for uniform and mix.extract for jquery and the rest. Not ideal, but it will keep the vendor dependencies separate from the application code.


Why aren't the sampling offsets related parameters trained during fine-tuning?

Dear auther,
I notice that the sampling offsets related parameters aren't trained during fine-tuning. I am kind of confusing what the reason for.
Looking forward to your reply.

Thank you for your meticulous attention to detail! That's really a good question!
Just from my experience (very subjective), the sampling offsets related parameters are very sensitive. That's probably why the authors of Deformable-DETR train them with 0.1x learning rates. From my understanding, the sampling offsets are class-agnostic, so fine-tuning them on a very small few-shot dataset probably won't help to achieve better results, and may even degrade the performance due to the small number of training images during fine-tuning. That's why I chose to not train the sampling offsets related parameters.
You may conduct experiments to verify whether my intuition is true.
Thank you!     ; )

Thanks very much. Yeah, I have conducted experiments and got the same phenomenon. The statement of "the sampling offsets are class-agnostic“ is really helpful.


Why does this repository exist?

Title

It exists because Math.clamp isn't a built-in feature, yet
https://github.com/Richienb/proposal-math-clamp


Add a depency to get rid of several warnings from the joda-time library.

These looked like that:
[warn] Class org.joda.convert.FromString not found - continuing with a stub.
[warn] Class org.joda.convert.ToString not found - continuing with a stub.
Incidently it allows me to compile the project without a StackOverflowException

Great, thanks.


Include jQuery above page__footer to allow for upgrade-safe custom JavaScript

Suppose I want to add some JS code that runs before _main.cs (in my case, I want to add some classes to elements to be processed by _main.js, specifically the image-popup class: https://github.com/mmistakes/minimal-mistakes/issues/1235).
So I add a JS file to assets/js and reference it from footer/custom.html, but then I don't have jQuery because it's bundled inside main.min.js which is only included after (lower in the HTML).
I realize I could override the scripts but that would interfere with Gem upgrades.

Also, getting jquery (and any other external dependency really) from a CDN rather than minifying it inside main.min.js would probably increase performance (and reduce hosting costs), both due to the CDN hosting and browser download parallelization.

Just override _includes/scripts.html
There's barely anything in that file and is very likely not to change making it safe.
As far as pulling out jQuery into a CDN version. Not going to get into that debate. There's to many Stackoverflow and blog posts arguing the benefits of doing it and not.

Override _includes/scripts.html and do what? I can already have my script included before main.min.js using footer/custom.html as I mentioned above. The problem is that I don't have jQuery. I suppose I could include it again (before my script) but that seems rather wasteful...
Regarding CDN, I took a quick look in SO in it doesn't seem like much of a debate... the overwhelming majority of answers and upvotes are clearly in favor of a CDN.
It is especially recommended for HTTP/2 due to caching improvements.

Add your scripts after main.min.js which bundles jQuery with a few lines of JavaScript to init various plugins (e.g. lightbox).
I'm screwed either way I do it. Include the CDN and someone will want to self host to avoid an external dependency. Bundle it and someone will want a CDN ref'd one. I've done it both ways in the past and it's a losing battle.
I think you'll see this sort of things with themes in general. They can't possibly do ever suggested web performance suggestion and balance features/customization at the same time.
Users that are savvy enough to request this sort of stuff are likely out growing an "open sourced" theme and would be better served forking/building their own to fit needs.

I could add my script after main.min.js and add the magnificPopup() setup but I don't like it as much due to the lightbox setup duplication (~25 lines), especially if it ever changes in future versions. How about a compromise - could you expose some sort of event (simplest would probably be a jQuery custom event before the _main.js code executes?
Regarding CDN, I totally agree with your sentiment but I disagree with your premise. I would wager that if asked, the vast majority of your users will prefer the clear performance and cost improvements over the chance that the Google CDN goes down but their site doesn't.
So I think the equation should be flipped - only extremely paranoid or savvy users with very specific scenarios (like firewalls that don't have CDNs allowed) would fork the theme. To most laymen, this is an easy win...

Vast majority of users host for free with GitHub Pages, which already has some CDN power behind it.

That article suggests it only has that CDN power if configured correctly (in the case of custom sub-domains). It also doesn't address parallelization and optimized caching. And by the same token performance is not considered, I would posit that dependency on something like the Google CDN isn't either...
So given two presumably equally irrelevant options, why not take the one with the improved experience?

BTW GitHub pages is probably a much bigger dependency than Google CDN...

See #1241 for feature add.


[feature] message delete webhook events not received

Hello,
We would like to receive 'message.delete' ack event when someone deletes a message from their whatsapp phone.
Event is important for us to know if sent message was deleted by user, and our system should get the webhook and should get updated of such actions.

@ehussain hi!
just to make sure it doesn't work - you mentioned here https://github.com/devlikeapro/whatsapp-http-api/issues/209

We receive a delete webhook for messages sent by client (any incoming message)

Does it mean that message.any covers message.delete event case? Or I misunderstood it...

Hello @allburov .
I tested this morning only, we have subscribed to 'message.any' event but still we are not receiving any webhook for delete case. It seems I mistakenly wrote about delete webhook.
So as per my understanding and testing. I can say that neither 'delete' api is available nor we are receiving the delete webhook for any messages which is deleted by client.

Added new message.revoked event in 2023.10.12 (Plus yet)

message.revoked
The message.revoked event is triggered when a user, whether it be you or any other participant,
revokes a previously sent message.
{
  "event": "message.ack",
  "session": "default",
  "payload": {
    "before": {
      "id": "some-id-here",
      "timestamp": "some-timestamp-here",
      "body": "Hi there!"
    },
    "after": {
      "id": "some-id-here",
      "timestamp": "some-timestamp-here",
      "body": ""
    }
  }
}

Important notes:

The above messages' ids don't match any of the ids you'll receive in the message event, it's a different id.
In order to find the message that was revoked, you'll need to search for the message with
the same timestamp and chat id as the one in the after object.
before field can be null in some cases.


/logout No Longer Supports "redirect_uri" as default from v18.0.0

Hi @yubinTW,
Amazing work on this plugin! I wanted to report an issue we're experiencing with Keycloak 18.0.0, specifically regarding the /logout endpoint functionality. According to the official documentation, a breaking change has been introduced starting from version 18.0.0. Future versions will likely remove the ability to specify the redirect_uri in the logout request.
Link

Consider either removing the redirect_uri parameter entirely or replacing it with the id_token_hint and post_logout_redirect_uri parameters.
The backwards compatibility switch will be removed in some future version - probably Keycloak 23. You are encouraged to update your clients as soon as possible as described above rather than rely on this switch.

Currently, an error message is thrown when doing a logout:

Invalid parameter: redirect_uri

Investigation
I reviewed the source code of the official (and now deprecated) keycloak-nodejs-connect library. They handle this by adding the post_logout_redirect_uri and id_token_hint parameters. The id_token_hint parameter is automatically populated with the id_token from the grant response.
Here, they automatically populate the id_token_hint parameter from grant.id_token:
Link
    let idTokenHint = null
    if (request.kauth.grant) {
      idTokenHint = request.kauth.grant.id_token.token
      ....
    }

Link
Keycloak.prototype.logoutUrl = function (redirectUrl, idTokenHint) {
  const url = new URL(this.config.realmUrl + '/protocol/openid-connect/logout')

  if (redirectUrl && idTokenHint) {
    url.searchParams.set('id_token_hint', idTokenHint)
    url.searchParams.set('post_logout_redirect_uri', redirectUrl)
  }

  return url.toString()
}

Solution Proposal
A non-breaking solution that works both ways could be beneficial. This solution would handle both the redirect_uri parameter and the new way of specifying the logout redirect URL.
I propose adding a new partial keycloakOption, such as a boolean flag, to instruct the library to build the logout URL using the new parameters. If this flag is not set, the library should default to using the current redirect_uri.
Link
const partialOptions = t.partial({
  ...
  XXXXXX: t.readonly(t.boolean),
  ...
})

Around this code line, you could implement the logic to build the logout URL using either the old redirect_uri or the new parameters, depending on the optional flag mentioned above.
Link
              E.map((config) => reply.redirect(`${config.end_session_endpoint}?redirect_uri=${opts.appOrigin}`))

Additionally, you could use the id_token from the grant response to automatically populate the id_token_hint parameter.
Link
/**
 * Grant response
 */
export interface GrantResponse {
  ....
  /**
   * OpenID Connect id token
   */
  id_token?: string
  ....

Final Thoughts
I conducted some manual tests by directly calling my Keycloak /logout URL endpoint with the new parameters in the browser. It appears to work correctly, redirecting me as expected and not throwing any invalid parameter errors.
Thank you for your attention!

Hi @EnriqueJMP-holcim,
Thank you so much for your detailed issue! Your investigation and proposed solution were extremely helpful. I've modified the code (#56), and a new version of the library has been published.
Try the 2.3.0 version, and set usePostLogoutRedirect to true when using keycloak version >= 18


Xcode complains English.lproj should be named en.lproj

Godot version
3.5.1
System information
MacOS Ventura 13.0.1, Xcode 14.1
Issue description
The latest version of Xcode doesn't like how godot exports some files. It generates the following warning. I believe it doesn't integer with deployment (it's only a warning), but it might be best to fix this now so users aren't presented with warnings by Xcode??
Migrating the “English, deprecated” localization to “English” is recommended for all projects. This will ensure localized resources are placed in “en.lproj” directories instead of deprecated “English.lproj” directories.
Steps to reproduce
Export a generic hello world project for XCode
Minimal reproduction project
Export a generic hello world project for XCode

ISO codes for locales should be supported starting from Xcode 9, so it should be safe to update it.


Precommit typos

Reference Issues or PRs
Closes https://github.com/nebari-dev/nebari/issues/2598

What does this implement/fix?
Put a x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[x] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[x] Did you test the pull request locally?
[ ] Did you add new tests?

How to test this PR?

Create a new local deployment from the develop branch in editable mode
Run nebari render -c nebari-config.yaml
Run ls stages/07-kubernetes-services/modules/kubernetes/services/dask-gateway/ and verify that the directory contains the misspelled controler.tf file.
Checkout this branch and run nebari render -c nebari-config.yaml
Re-run the ls from above and verify the file has been renamed to controller.tf

Any other comments?

@blakerosenthal Is this ready for review?

@blakerosenthal Is this ready for review?

Yes, thank you!


[improvement] the index parameter should be defined elsewhere

For now the index parameter is defined here:
https://github.com/lauramble/rnaseq-vizfada/blob/combined/main.nf#L39
I guess it should be defined somewhare here:
https://github.com/lauramble/rnaseq-vizfada/blob/combined/nextflow.config

It's fine where it is. I misunderstood its function.


fix: Use loader configuration passed in plugin instead detection by file extension

Example:
src/SomeComponent/index.js use JSX markup inside. But entry.extname.slice(1) detect loader as js which is not correct if {loader: {'.js': 'jsx'} } passed in plugin options.
The idea is to use overrides like in original esbuild with loader property.

Thank you for the contribution! I will watch your PR a little later.

Hi! It will be very useful. Thank you!


Kasten K10 Addon

Issue #, if available:
Description of changes:
Initial commit of Kasten K10 by Veeam SSP Addon
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Canceling PR


MouseWheelEvent.wheelDelta is not defined

TypeScript Version:  3.2.0-dev.20181110

Search Terms:

dom.d.ts
mousewheelevent

Problem
https://github.com/Microsoft/TSJS-lib-generator/pull/579 removes the definition for MouseWheelEvent,wheelDelta
Although this property is deprecated non-standard (https://developer.mozilla.org/en-US/docs/Web/API/MouseWheelEvent) it was being used in the VS Code code base and potentially elsewhere.
I'll see if VS Code can migrate to use the standard WheelEvent but am not sure if the current breaking change on MouseWheelEvent is correct.

@sandersn let's discuss tomorrow.

I think the break is intentional and the workaround should be fairly straightforward for most users.


Common releases jobs need to exist for Master bosh

The following releases all need to be uploaded to Master bosh in order for Tooling bosh to be deployed.

[ ] fisma (cg-hardening)
[ ] tripwire
[ ] awslogs
[ ] nessus-agent
[ ] newrelic
[ ] riemannc
[ ] clamav
[ ] snort

Discovered during #62

Josh says this is all done now.


Add a heap profiler API and document it.

I'm going to merge this given Skye has reviewed; if Jake has comments I'm happy to make them in a follow-up PR.


NullPointerException thrown while mapping

I am using dozer 5.4.0 and class MappingProcessor is throwing NullPointerException in
private  T map(Object srcObj, final Class destClass, final T destObj, final String mapId); method.
The issue is -
if (destClass == null) {
  destType = (Class<T>) destObj.getClass();
  result = destObj;
} else {
  destType = destClass;
  result = null;
}

if destClass is null it is getting class of destObj but later in the code it is calling
  Object alreadyMappedValue = mappedFields.getMappedValue(srcObj, destClass);

so if destClass was null in method argument, it will still be null and hence throws a NullPointerException in getMappedValue method.
Please fix this.

I can confirm that this is fixed in 5.5.1 at least.
Someone should close this issue.


Rancher backup too many colons in address

Rancher Server Setup

Rancher version: 2.6.2
Installation option (Docker install/Helm Chart): Helm Chart

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE2

Proxy/Cert Details: self-signed certificate via cert-manager

Information about the Cluster

Kubernetes version: v1.21.6+rke2r1
Cluster Type (Local/Downstream): local

Describe the bug
I want to backup my local cluster to a local S3 endpoint (Ceph Radosgw cluster), who's not listening on standard 443 TCP port (8080).
The endpoint URL is like https://my.local.dns:8080.
The backup fails with :
Failed to set s3 server: address https://public.labs.fiducial.cloud:8080: too many colons in address
To Reproduce
Set a backup with a custom S3 URL endpoint, with a specific TCP port (the URL will have 2 colons).
Result
Backup fails with the message :
Failed to set s3 server: address https://public.labs.fiducial.cloud:8080: too many colons in address
Expected Result
Backup succeed, no errors, should be able to use whatever valid URL.

Reply to myself.
If I put in the endpoint : my.server.dns:8080 without https://, it works !

work fine 4 me !!!!! thx a lot (y)


Update most if not all of the branding to MangoCord

there is a bug in patch 0023 that does not allow the mangocord to be compiled correctly
Applying: MangoCord logger options
error: sha1 information is lacking or useless (mangcord/src/main/java/dev/lucianishimiya/mangcord/configuration/MangoCordConfiguration.java).
error: could not build fake ancestor
Patch failed at 0023 MangoCord logger options


How visualize the carla road network map on rviz?

Hi,
Is there a way to visualize the carla opendrive map on rviz?What  message type should I use?Or can I only draw it line by line manually?

Hi @XieJinLiang there is no specific message for that, but you could take a look at this: https://github.com/carla-simulator/carlaviz
The message should be compatible with rviz, so that is your best starting point.

@XieJinLiang Did you find a way to visualize it on rviz?


S3 Driver not including x-amx-content-sha256 in signed headers

This bug has been reported as fixed here:
https://github.com/aws/aws-sdk-go/issues/743
Can we pull this into registry 2.5.0 ? This bug is currently preventing the use of some alternate S3 storage providers.

@rdjones517 : can you confirm this fixes your issue?  You can get a container with this change at distribution/registry:latest in about an hour

@RichardScothern Should I be pulling master or latest? looks like the latest tag is 7 months old

sorry @rdjones517 I lied to you the tag should be master 😿
REPOSITORY                         TAG                 IMAGE ID            CREATED             SIZE
distribution/registry              master              3cac39dad6c4        16 hours ago        349 MB

@RichardScothern I was able to test using the container your provided, and I can confirm that this has resolved my issue. I am able to communicate with my S3 storage provider successfully. Thanks

Thanks @rdjones517 for testing it out!

Doesn't look like this fix was included in registry 2.5.0. Will it be included in 2.5.1?

This was committed past the cutoff for 2.5.0.  There is no reason it can't go in 2.5.1

Doesn't look like this made it into 2.5.1. Any idea why?

I want to keep the impact low for patch releases.  This fix required 84 file changes in the vendored code so I would like to keep it back until 2.6.  Sorry for misleading you.


Add remove command

Codecov Report

Merging #84 (52a15ae) into master (7d296d4) will decrease coverage by 1.82%.
The diff coverage is 8.33%.

@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
- Coverage     72.97%   71.14%   -1.83%
  Complexity      429      429
============================================
  Files            74       76       +2
  Lines          1306     1341      +35
  Branches        137      145       +8
============================================
+ Hits            953      954       +1
- Misses          315      348      +33
- Partials         38       39       +1

Impacted Files
Coverage Δ

...va/seedu/address/logic/commands/RemoveCommand.java
0.00% <0.00%> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
86.95% <0.00%> (-10.61%)
:arrow_down:

...eedu/address/logic/parser/RemoveCommandParser.java
0.00% <0.00%> (ø)

...eedu/address/logic/parser/TrackAScholarParser.java
89.47% <0.00%> (-10.53%)
:arrow_down:

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
95.91% <0.00%> (-4.09%)
:arrow_down:

...c/main/java/seedu/address/model/TrackAScholar.java
84.61% <0.00%> (-7.06%)
:arrow_down:

.../java/seedu/address/model/applicant/Applicant.java
91.83% <0.00%> (-3.91%)
:arrow_down:

...u/address/model/applicant/UniqueApplicantList.java
82.60% <0.00%> (-10.08%)
:arrow_down:

...edu/address/model/applicant/ApplicationStatus.java
73.68% <60.00%> (-6.32%)
:arrow_down:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Packaging for Windows

DOD:

A Windows executable (possibly with accompanying DLLs) that, when run, starts up an instance of pypew and opens the index page in a browser.
A MSI installer that produces desktop or start menu shortcuts to this executable.

Done in 6b624e9b5b37e0793c9d99a2b49daca64ba1ed92, awaiting testing,


Version bump dependencies on fastlane_core and spaceship

I messed up by already version bumping match and sigh before doing this commit, so I needed to correct the version bump for sigh in match locally to make CI able to build & test

lol, all the badges 😂


prjoxide: update clap

Clap was fixed to <=3.0.0-beta.2 in #12. Upon further investigation, beta.4 was functioning as intended; it simply bumped clap's MSRV to 1.54 (see clap-rs/clap#2741).
Clap 3.1 supports Rust as early as 1.54. Upgrade to that (with a few fixes for a rename that happened in 3.0.0-beta.5), since it's been out for well over a year now.

thanks!


Establish standard structure for release-templates

Rename eng/scripts/release-template/js.md to eng/scripts/release-template/javascript.md

Fill in each eng/scripts/release-template/language.md using the the template package for that language.

We might consider using friendly names for the packages in some places, but we might need a standard mapping for automating conversion from the standard package name to a friendly name.

Closing this since changes are merged in https://github.com/Azure/azure-sdk/pull/2158


chore(ts): don't export pnpm store

This is the node_modules equivalent for pnpm - we should never export it, just in our tests these can end up at 100MB, which causes our exports to sometimes hang.

this fixed the CI problem I was having with my PR ❤


Support SelectNodesNS and SelectSingleNodeNS

fix #18

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for your PR, but problem was solved in #20


[RTC-374] Revisit Jellyfish Videoroom setup

I am mergin as I need this to bump Jellyfish to 0.2.0 :stuck_out_tongue:


Showing the year modal at the start.

Hi,
https://github.com/roto93/react-native-neat-date-picker/blob/d94a59c01d8cb4b97143929c9050a7c2d7932fb8/src/components/NeatDatePicker.js#L32
In this line, we have an use case where we would like to first show the year and then show the date picker. It would be nice if a prop could be given, like showYearModal and this would show the year modal at first.

Hi, Sorry for the late reply. I have been fulfilling the military service in my country therefore could not reply for weeks.
Your advice is awesome! That would be more reasonable in many circumstances.
But I won’t be able to deal with it until June. It will be great if someone make a PR for it first. Otherwise please wait for few more days.

Version 1.4.9 added a new prop chooseYearFirst. I think this is what you need.😄


Jupyter kernelspec

These are not correct. The way to install the IPython kernelspec post-4.0 is ipython kernel install.

@minrk in building the Dockerimage this is printed:
Removing intermediate container 7cd608a4d3ef

Step 5 , RUN /bin/bash -c "source activate binder && ipython kernelspec install-self --user"

---> Running in fb3e105f7a93

discarding /home/main/anaconda2/bin from PATH

prepending /home/main/anaconda2/envs/binder/bin to PATH

[TerminalIPythonApp] WARNING | Subcommand `ipython kernelspec` is deprecated and will be removed in future versions.

[TerminalIPythonApp] WARNING | You likely want to use `jupyter kernelspec`... continue in 5 sec. Press Ctrl-C to quit now.

ipython kernelspec did two things:

install Jupyter kernelspecs in general
install IPython's kernelspec for Jupyter via install-self (effectively calling jupyter kernelspec install /path/to/ipython/kernelspec)

(1) is now called jupyter kernelspec. install-self doesn't make sense for jupyter kernelspec because Jupyter doesn't provide any kernels itself. It only exists as a deprecated alias for the old command. (2) continues to be an IPython command, now called ipython kernel install, which installs the IPython kernelspec.
I see now that the deprecations of jupyter kernelspec install-self are only in the code and not shown to the user. I'll fix that shortly.

@basnijholt thanks for the PR! As per @minrk's comment, I've updated the command to ipython kernel install as part of another update to the base image (https://github.com/binder-project/binder/commit/29c4e3dbda94e80b1b22c82997e554a25cd187ff), so I'll go ahead and close the issue.
Thanks again for the contribution!


Is Tools, adunit info overlay work with video?

As in the title, doesTools, adunit info overlay work with video?  As I cant get anything to show at all

Hi @spormeon ,
could you provide a (test-)page where i can reproduce your issue?


printf still bigger in size compared to stdio printf

Hi, I was trying to use this library on the AVR ATmega328P microcontroller (Arduino). When comparing the file generated using stdio and this library, I noticed that the library resulted in a significantly larger file size. I believe I have set the option to use the minimum amount of memory.  Instead of the regular vsnprintf I use vsnprintf_
void myprintf(char *fmt, ...)
{
    char buf[128]; // resulting string limited to 128 chars

    va_list args;
    va_start(args, fmt);
    int len = vsnprintf_(buf, 128, fmt, args);
    va_end(args);

    for (int i = 0; i < len; i++)
        USART_Transmit(buf[i]);
}

the rest of the code is identical.
For build and link flags, I just use -Os to minimize code size.
Any tips on how to reduce the code size? Or is this library is better optimized for 32-bit mcu?

Hello @ramadhanafif .
While I'm maintaining this repository - I do not do microcontroller development. So, I am not familiar with what happens with the AVR ATmega328P.
I would speculate that this is a "counting problem", i.e. that there is printf code in another object/executable/library, from the standard library. I am very doubtful the code size can decreased by a factor of 3.
@phillipjohnston , perhaps you can chime in about this?
or, @ramadhanafif  - perhaps you could write Phillip and ask for his opinion on this?

Thanks for the suggestion @eyalroz
I do suspect that this is an unoptimized linker issues. Although I'm not sure how to do that

In addition to @mickjc750's suggestion, You would also need -gc-sections as a linker flag.
For reference, with the original mpaland/printf library with similar formatting options disabled, I measured ~1.6kb on the same platform. I haven't taken similar measurements with the new library.

@phillipjohnston avr-gcc is based on gcc 7.3, doesnt have -gc-sections flag
@mickjc750 Now I have added -ffunction-sections and -fdata-sections and -flto but it does not seem to change.
@eyalroz I found that the project cmake does not pass the compile or linker flags to the printf library. After checking the build commands, I discover that the libprintf.a are created without any optimizations. I modify the library CMakeLists and add a -Os. Here is the result
AVR Memory Usage
----------------
Device: atmega328p

Program:    3116 bytes (9.5% Full)
(.text + .data + .bootloader)

Data:         34 bytes (1.7% Full)
(.data + .bss + .noinit)

Definitely an improvement, but still somewhat bigger than the stdio printf (1992 bytes).
Will try to compile them manually instead of using cmake scripts, maybe we can find something else.

Gc-sections is a linker flag. You need it for the others to make a difference.CheerPhillipOn Jul 13, 2023, at 18:44, Muhammad Afif Ramadhan @.***> wrote:
@phillipjohnston avr-gcc is based on gcc 7.3, doesnt have -gc-sections flag
@mickjc750 Now I have added -ffunction-sections and -fdata-sections and -flto but it does not seem to change.
@eyalroz I found that the project cmake does not pass the compile or linker flags to the printf library. After checking the build commands, I discover that the libprintf.a are created without any optimizations. I modify the library CMakeLists and add a -Os. Here is the result
AVR Memory Usage
Device: atmega328p
Program:    3116 bytes (9.5% Full)
(.text + .data + .bootloader)
Data:         34 bytes (1.7% Full)
(.data + .bss + .noinit)
Definitely an improvement, but still somewhat bigger than the stdio printf (1992 bytes).
Will try to compile them manually instead of using cmake scripts, maybe we can find something else.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@phillipjohnston Thanks for the reply.
I had tried using --gc-sections, but the avr-gcc returns error for not understanding what it means.
Digging deeper into the manual, you can see that --gc-sections is not listed in the avr-gcc man page

Hi @phillipjohnston , I found out what you mean. I have added the
-ffunction-sections -fdata-sections -Wl,--gc-sections
but it size stays at 3116 bytes (no change).

@ramadhanafif : I would accept a pull request which adds a CMake option for setting these compilation and linking options for the libprintf target.
Or, if you're not familiar enough with CMake to write that, I'll try to get to it soon.
@phillipjohnston : Using these flags, how far can the size be brought down on the AVR atmega328p?

@ramadhanafif : ping.

@eyalroz I don't know a good way to approach this issue. For the moment, I'm adding a compile flag to my main CMakeLists.txt
add_subdirectory(printf)
target_compile_options(printf PUBLIC -Os)

@ramadhanafif Would it not be enough to suggest the use of -Os in CFLAGS when configuring and building printf? In the README perhaps?

I agree, that simplifies things

@ramadhanafif : How's the README change I just introduced?

That surely helps! Great job @eyalroz! thanks for solving this one until the end!


Revert "something else"

This reverts commit b5947f7d48c7ca6a40c62fd6b8ce95776f0ba0ad.
Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@tvm-bot merge

@tvm-bot merge


Make members of att.bibl members of att.responsibility

One should be able to use @resp on most (or perhaps all) elements in the header to indicate the individual or group responsible for encoding the metadata.
Please note that @resp is independent of @auth and @auth.uri.  While the latter attributes typically point at entities described outside the MEI document, @resp associates the element that bears it with an entity named inside the MEI file.  @auth and @auth.uri help to unambiguously identify an entity, while @resp asserts that the entity has/had some role in identifying/creating the data contained in the element to which it's attached.

Actually, @resp was made available on all elements by commit d82a5b5.


Is it safe to change the alphabet used?

We are hoping to use this for creating order IDs that can't be guessed, and are finding that using mixed case is not ideal for a couple reasons.
If we take out all the uppercase letters, would there be any issues that arise with regard to uniqueness?

Thanks, very good question!
Changing the alphabet is fine. But you have to remember four things:

Change it once and stay with that modified alphabet forever. Obviously, if you change the alphabet again later, or if you somehow "lose" your alphabet, all IDs transformed so far will become invalid, i.e. pointing to the wrong resources.
Shortening the alphabet makes your transformed IDs longer.
Extending the alphabet makes your transformed IDs shorter. You don't have to worry about this if obfuscation is all you need, of course.
Your alphabet must never contain duplicate characters.

And when using this library in general, you have to keep in mind that the ID transformation is "secure" only in the sense that it's "security through obscurity". If there is a "determined guesser", they will probably find a way to reverse the transformation. Against a layperson, however, that transformation will easily be enough as a defense.
In addition to that, an attacker will still be able to observe whether an ID is short (e.g. ms7) or long (e.g. m29slqmdf8), where the first one is a smaller number and the second one is a larger number, no matter what alphabet you're using. If you want to get rid of that property as well, and if you happen to work in PHP, you can use PHP-IDs, which is an extension of this library here.
After all, if you need to make guessing even harder, try non-sequential IDs such as UUIDs.
Does this help?

This definitely helps, thanks for the detailed response! FWIW we are using mysql short UUIDs and then encoding them with this library.
We need the IDs to be easy(ish) to type using a touchscreen keyboard, so that's why we're not using just regular UUIDs. Unfortunately we've found that both the short UUID and the resulting encoded string is sequential, but I think now that we're throwing letters into the mix, the average person won't be able to guess, which is all we need.
Thanks again!

the average person won't be able to guess, which is all we need

Definitely not! If that's really all you need, you should be fine.
All in all, that seems like a pretty reasonable solution for your use case. Especially in combination with MySQL's UUID_SHORT(), this will work well.
Just make sure that the implementation that you're using supports 64-bit (unsigned) integers. I don't know which (language) version you're using from this repository, but not all do support that out of the box. Some have 32-bit support only. If you're unsure, try a single large number (outside the 32-bit space), or open an issue here.


Support for node-mssql package

Hi! Im trying to capture mssql driver connections but no result is going out in XRay. I guess this package is not yet supported. Any ideas about this? Thanks!

Hi, unfortunately the SDK right now doesn't support this package yet. So you won't see any auto-generated subsegments for mssql client calls. We will put this feature request to our backlog.
Which version of mssql are you using? It seems like v4 is using async/await for IO operations. The SDK depends on CLS for context binding and right now CLS loses track of the context on async/await invocation. This work is tracked here https://github.com/aws/aws-xray-sdk-node/issues/12.
Please let us know if you have any additional questions.

Hi @haotianw465, thanks for your quick response. Right now we're using v4.1 so i guess we will need to wait until this package is supported.
The initial idea of using X-Ray was to understand a little better about the random time delays in connections between lambdas and RDS.  We have to use VPC to do this, and i checked that under this scenario those kind of delays could be sometimes expectable due to times assigning ENIs and creating connections.
We would try to follow this analysis, would be great to have support for this package to take advantage of XRay tracing . Thanks!

+1

At this time we do not have it on our roadmap to add node-mssql first-party support. We are always open to pull requests if anyone is interested in making one for mssql in particular, or for a more generic framework like Sequelize or TypeORM which could also potentially be used by MSSQL users.


Jakob/issueScript

Created a python script to get all of the issues/announcements from issue 181 (where we will be listing our announcements) and insert them into a json file to be put into our announcements page.

@jakobreinwald You'll also need to merge again from main because I merged something into main that should cause merge conflicts

From what we talked about on the messenger chat, could add do body.trim() in Announcement.js?

LGTM! Final changes before we merge:

Delete all the comments from the issue and make sure annountements.json is empty []
Rename updateAnnouncements.py to update_announcements.py and get rid of the current update_announcements.py


Field options missing

Field options is missing (last, first, average, min, max, etc) in power bi after adding a calculation group in tabular editor.
(https://learn.microsoft.com/pt-br/power-bi/create-reports/media/service-aggregates/power-bi-aggregate-average.png for example this menu options)
When i use tabular editor and add a calculation group (with information or empty), some field option is missing
To Reproduce

Go to Tabular editor
Click on tables, create new, calculation group
Save
See error

Delete the changes dont fix the problem.
Application specifics

Tabular Editor 2.17.3
Semantic Engine used: Power BI Desktop 2.115.1006.0 64-bit

Duplicate of #871, #636, #628, #614, #544, ...
TLDR: Calculation Groups requires the DiscourageImplicitMeasures property on the model to be set to true. This disables implicit columns (i.e. the ability to summarize columns in visuals). You'll have to either remove the calc groups, and set DiscourageImplicitMeasures back to false, or create explicit measures for any column you intend to summarize in a visual.


Update MATLAB versions available on Puhti

Proposed changes
Based on feedback in RT ticket. https://csc-guide-preview.2.rahtiapp.fi/origin/rkronberg-patch-1/apps/matlab/#available
Checklist before requesting a review

[x] I have followed the instructions in the Contributing and Styleguide documents.
[x] My pull request passes the automated tests. If not, visit pull requests at Travis CI and have a look at the job log.
[x] I have included a link to the appropriate preview page (select your branch from the list).

Ok. T. Sampo


Error in the testing the installation run

Hi,
After installing and running python -m pip install . command, I run the command, python object_detection/builders/model_builder_tf2_test.py to test the installation. But I'm getting the following errors as seen in the image attached below.
I'm currently running it in a Virtual Machine in GCP which contains a GPU . So when I run the pip install -U tensorflow==2.3.0 command, it runs but still shows some errors and messes up my GPU , due to which I'm not able to access it.
Please any help will be much appreciated!
Best,
Aravind

I just took a look, and it seems that the Dockerfiles really are quite old. They're still using Tensorflow 2.2, but according to the setup.py script, at least version 2.5 is required. It works for more with both Tensorflow 2.5 and 2.6.


Provide winget package

subj

We will implement winget once it supports standalone executables. https://github.com/microsoft/winget-cli/issues/182

Hi. Winget now supports standalone executables. https://github.com/microsoft/winget-cli/pull/2233

https://github.com/microsoft/winget-pkgs/pull/83157
however, it requires winget 1.4 as it uses nested portable installer...

confirmed with the maintainer. my PR requires winget 1.4 to support nested portable installer. I'm marking the PR as Draft and leaving it open till 1.4 is out.

Winget 1.4 is out now. So this should be closed? @weinong

Works for me

@ggirard07 this is a known issue fixed in https://github.com/microsoft/winget-cli/pull/3002. Wnget team will make a new release this week.

https://github.com/microsoft/winget-cli/releases/tag/v1.5.1081-preview


build: Use -fno-exceptions when compiling jakt-generated cpp code

This cuts down build time spent in Clang by 2.7s, or 23%.
The open question is if jakt will ever support C++ exceptions (generated, for example, int the inline c++ code blocks, or third party c++ libraries called from jakt code)
hyperfine -r 5 "cd jakt/build/ && clang++ -std=c++20 -I ../runtime/ -Wno-parentheses-equality -Wno-trigraphs -Wno-user-defined-literalsi jakt.cpp" "cd jakt/build/ && clang++ -std=c++20 -I ../runtime/ -Wno-parentheses-equality -Wno-trigraphs -Wno-user-defined-literals -fno-exceptions jakt.cpp"
Benchmark 1: cd jakt/build/ && clang++ -std=c++20 -I ../runtime/ -Wno-parentheses-equality -Wno-trigraphs -Wno-user-defined-literalsi jakt.cpp
  Time (mean ± σ):     14.772 s ±  0.092 s    [User: 14.208 s, System: 0.552 s]
  Range (min … max):   14.666 s … 14.881 s    5 runs

Benchmark 2: cd jakt/build/ && clang++ -std=c++20 -I ../runtime/ -Wno-parentheses-equality -Wno-trigraphs -Wno-user-defined-literals -fno-exceptions jakt.cpp
  Time (mean ± σ):     11.989 s ±  0.069 s    [User: 11.431 s, System: 0.541 s]
  Range (min … max):   11.874 s … 12.059 s    5 runs

Summary
  'cd jakt/build/ && clang++ -std=c++20 -I ../runtime/ -Wno-parentheses-equality -Wno-trigraphs -Wno-user-defined-literals -fno-exceptions jakt.cpp' ran
    1.23 ± 0.01 times faster than 'cd jakt/build/ && clang++ -std=c++20 -I ../runtime/ -Wno-parentheses-equality -Wno-trigraphs -Wno-user-defined-literalsi jakt.cpp'

Super awesome! We don't care about C++ exceptions, so it's not a problem :)

Super awesome! We don't care about C++ exceptions, so it's not a problem :)

Hmm, but with extern c you might want to call throwing apis and guard them with catch.

SerenityOS does not use C++ exceptions, and this is a language specifically for SerenityOS.


Speedup compile time for rustpython-parser

Saves about half a minute on a clean build, see timing reports:
Before

Targets:
rustpython 0.1.2 (lib, bin "rustpython")

Profile:
release

Fresh units:
0

Dirty units:
345

Total units:
345

Max concurrency:
8 (jobs=8 ncpu=8)

Build start:
2022-04-22T19:33:33Z

Total time:
177.4s (2m 57.4s)

After

Targets:
rustpython 0.1.2 (lib, bin "rustpython")

Profile:
release

Fresh units:
0

Dirty units:
320

Total units:
320

Max concurrency:
8 (jobs=8 ncpu=8)

Build start:
2022-04-22T22:09:37Z

Total time:
153.6s (2m 33.6s)

Achh, newline issues on windows.

TAKE MY BENCHMARKS WITH A GRAIN OF SALT
HP Elitebook 745 G3
Manjaro Stable (2022-04-15 update)
Rust v1.60.0
*processes are running in the background*
listening to some Bach on another computer
Current main (c103fe13)

Targets:
rustpython 0.1.2 (lib, bin "rustpython")

Profile:
release

Fresh units:
0

Dirty units:
375

Total units:
375

Max concurrency:
4 (jobs=4 ncpu=4)

Build start:
2022-04-23T01:04:52Z

Total time:
726.9s (12m 6.9s)

rustc:
rustc 1.60.0 (7737e0b5c 2022-04-04) Host: x86_64-unknown-linux-gnu Target: x86_64-unkown-linux-gnu

Max (global) rustc threads concurrency:
0

This branch (2918395)

Targets:
rustpython 0.1.2 (lib, bin "rustpython")

Profile:
release

Fresh units:
0

Dirty units:
357

Total units:
357

Max concurrency:
4 (jobs=4 ncpu=4)

Build start:
2022-04-23T01:38:57Z

Total time:
575.9s (9m 35.9s)

rustc:
rustc 1.60.0 (7737e0b5c 2022-04-04) Host: x86_64-unknown-linux-gnu Target: x86_64-unkown-linux-gnu

Max (global) rustc threads concurrency:
0

Should I rustfmt it?


Initialise comments

Description
Initialise comments:

Config flags in place to keep the feature hidden / not in the execution path
Overlay comments wrapper at the base-widget, that renders comments using position: absolute
Unpublished comment that is pushed to the server once the comment is actually added, until then it's just within the store
Normalised store structure to prevent re-renders across all widgets when a comment is added
Overlay over components except a blacklist to prevent interaction with the components while adding comments, the blacklist is added for container components
Toggle comment mode button at the header toggles the comment mode
Websockets - a socket connection is initiated after authentication / disconnected on logout, we maintain socket connection status in the store, and an action to reconnect is supported, but not accessible from the UI atm

An additional change dispatches logoutAction on 401, to reset store and disconnect socket.
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Integration tests forOverlayCommentsWrapper with API mocks for:

Rendering threads
Creating a new thread
Replying to a thread

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: init-comments

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
50.08 (1.4)
30.72 (0.99)
29.02 (1.79)
50.49 (1.35)

:sparkles: :new:
app/client/src/actions/commentActions.ts
87.84
100
62.5
89.47

:green_circle:
app/client/src/actions/initActions.ts
80 (10)
100 (0)
33.33 (33.33)
80 (0)

:sparkles: :new:
app/client/src/actions/websocketActions.ts
71.43
100
0
75

:green_circle:
app/client/src/api/Api.ts
83.33 (8.33)
25 (12.5)
60 (20)
83.33 (8.33)

:green_circle:
app/client/src/api/ApiUtils.ts
65.38 (9.61)
45.71 (11.42)
80 (0)
62.5 (10.42)

:sparkles: :new:
app/client/src/api/CommentsAPI.tsx
80.95
100
57.14
80

:green_circle:
app/client/src/api/OrgApi.ts
59.38 (3.13)
0 (0)
16.67 (8.34)
58.06 (3.22)

:sparkles: :new:
app/client/src/comments/ToggleCommentModeButton.tsx
65.85
37.5
40
65.85

:sparkles: :new:
app/client/src/comments/utils.ts
84.62
0
50
77.78

:sparkles: :new:
app/client/src/comments/CommentCard/CommentCard.tsx
86.36
77.78
84.21
86.15

:sparkles: :new:
app/client/src/comments/CommentCard/CommentContextMenu.tsx
75
100
42.86
71.88

:sparkles: :new:
app/client/src/comments/CommentCard/ResolveCommentButton.tsx
100
83.33
100
100

:sparkles: :new:
app/client/src/comments/CommentThread/CommentThread.tsx
94.74
78.38
90
94.74

:sparkles: :new:
app/client/src/comments/CommentThread/ScrollToLatest.tsx
100
100
100
100

:sparkles: :new:
app/client/src/comments/inlineComments/AddCommentInput.tsx
79.73
85.71
68.75
79.03

:sparkles: :new:
app/client/src/comments/inlineComments/Comments.tsx
100
100
100
100

:sparkles: :new:
app/client/src/comments/inlineComments/InlineCommentPin.tsx
87.18
33.33
88.89
86.11

:sparkles: :new:
app/client/src/comments/inlineComments/OverlayCommentsWrapper.tsx
96.97
75
100
100

:sparkles: :new:
app/client/src/comments/inlineComments/StyledComponents.tsx
100
100
100
100

:sparkles: :new:
app/client/src/comments/inlineComments/UnpublishedCommentThread.tsx
89.66
50
71.43
88.89

:sparkles: :new:
app/client/src/comments/inlineComments/useOrgUsers.tsx
100
100
100
100

:sparkles: :new:
app/client/src/comments/tests/setMockPages.ts
100
100
100
100

:sparkles: :new:
app/client/src/components/ads/EmojiPicker.tsx
82.35
100
33.33
80

:green_circle:
app/client/src/components/ads/Icon.tsx
60.79 (3.29)
42.11 (3.29)
100 (0)
60.62 (3.33)

:sparkles: :new:
app/client/src/components/ads/MentionsInput.tsx
87.5
58.33
71.43
85.29

:green_circle:
app/client/src/components/ads/Toast.tsx
45.65 (10.87)
34.62 (19.24)
5.88 (5.88)
45.65 (10.87)

:sparkles: :new:
app/client/src/components/editorComponents/PreventInteractionsOverlay.tsx
100
87.5
100
100

:sparkles: :new:
app/client/src/constants/CommentConstants.tsx
100
100
100
100

:green_circle:
app/client/src/constants/DefaultTheme.tsx
93 (0.14)
88.89 (0)
75 (0)
91.67 (0.21)

:sparkles: :new:
app/client/src/constants/WebsocketConstants.tsx
70
100
0
100

:green_circle:
app/client/src/constants/messages.ts
70.64 (0.6)
100 (0)
11.11 (1.86)
74.03 (0.72)

:sparkles: :new:
app/client/src/mockResponses/CommentApiMockResponse.tsx
100
100
100
100

:green_circle:
app/client/src/pages/Editor/EditorHeader.tsx
87.21 (0.15)
46.34 (0)
73.91 (0)
86.9 (0.15)

:green_circle:
app/client/src/reducers/entityReducers/pageListReducer.tsx
19.44 (5.55)
27.78 (27.78)
15.38 (15.38)
21.88 (6.25)

:green_circle:
app/client/src/reducers/uiReducers/editorReducer.tsx
26.87 (2.99)
0 (0)
13.64 (9.09)
26.87 (2.99)

:green_circle:
app/client/src/reducers/uiReducers/errorReducer.tsx
77.78 (11.11)
100 (0)
33.33 (33.33)
77.78 (11.11)

:green_circle:
app/client/src/reducers/uiReducers/orgReducer.ts
16.22 (2.71)
0 (0)
4.17 (4.17)
16.22 (2.71)

:sparkles: :new:
app/client/src/reducers/uiReducers/websocketReducer.ts
83.33
100
0
83.33

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/commentsReducer.ts
67.39
50
76.47
75.61

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/handleAddCommentToThreadSuccess.ts
100
100
100
100

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/handleCreateNewCommentThreadSuccess.ts
92.31
50
100
90

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/handleFetchApplicationCommentsSuccess.ts
93.33
75
100
100

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/handleNewCommentThreadEvent.ts
92.31
75
100
92.31

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/handleUpdateCommentThreadEvent.ts
100
100
100
100

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/handleUpdateCommentThreadSuccess.ts
100
100
100
100

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/testFixtures.ts
100
100
100
100

:green_circle:
app/client/src/sagas/ApplicationSagas.tsx
24.26 (0.31)
7.84 (0)
15.79 (0)
27.08 (0.32)

:green_circle:
app/client/src/sagas/ErrorSagas.tsx
65.09 (25.47)
42.11 (24.57)
50 (27.78)
65.26 (26.31)

:green_circle:
app/client/src/sagas/InitSagas.ts
24.04 (0.28)
3.33 (0)
20 (0)
28.09 (0.18)

:green_circle:
app/client/src/sagas/OrgSagas.ts
22.05 (4.73)
3.85 (0)
14.29 (7.15)
25.74 (3.96)

:sparkles: :new:
app/client/src/sagas/WebsocketSagas.ts
19.4
9.52
13.33
23.64

:green_circle:
app/client/src/sagas/index.tsx
90.7 (0.46)
50 (0)
100 (0)
92.86 (0.36)

:red_circle:
app/client/src/sagas/userSagas.tsx
17.37 (-0.1)
2.33 (-0.37)
8.33 (0)
20.57 (-0.14)

:sparkles: :new:
app/client/src/sagas/CommentSagas/handleCommentEvents.ts
25
0
0
25

:sparkles: :new:
app/client/src/sagas/CommentSagas/index.ts
63.75
55
66.67
64.52

:green_circle:
app/client/src/selectors/appViewSelectors.tsx
68.75 (12.5)
0 (0)
28.57 (28.57)
66.67 (6.67)

:sparkles: :new:
app/client/src/selectors/commentsSelectors.ts
59.62
25
53.33
57.58

:green_circle:
app/client/src/selectors/editorSelectors.tsx
59.23 (0.77)
27.03 (0)
35.71 (2.38)
57.01 (0.94)

:green_circle:
app/client/src/selectors/organizationSelectors.tsx
67.44 (2.32)
0 (0)
26.32 (5.27)
62.96 (0)

:sparkles: :new:
app/client/src/utils/hooks/useIsScrolledToBottom.tsx
100
72.73
100
100

:green_circle:
app/client/src/widgets/BaseWidget.tsx
79.65 (0.04)
39.02 (0)
78.57 (1.65)
78.7 (0.13)

:green_circle:
app/client/test/customQueries.js
95 (5)
100 (0)
66.67 (33.34)
94.74 (5.27)

Test coverage results :test_tube:
Code coverage diff between base branch:release and head branch: init-comments

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
43.94 (1.52)
27.24 (0.84)
22.36 (2.2)
46.3 (1.43)

:sparkles: :new:
app/client/src/actions/commentActions.ts
80.95
100
60
96.15

:green_circle:
app/client/src/actions/initActions.ts
71.43 (14.29)
100 (0)
33.33 (33.33)
80 (0)

:sparkles: :new:
app/client/src/actions/websocketActions.ts
60
100
0
75

:green_circle:
app/client/src/api/Api.ts
83.33 (8.33)
25 (12.5)
60 (20)
83.33 (8.33)

:sparkles: :new:
app/client/src/api/CommentsAPI.tsx
94.44
100
85.71
93.33

:green_circle:
app/client/src/components/ads/Icon.tsx
56.63 (4.7)
35.9 (5.76)
100 (0)
56.63 (4.7)

:sparkles: :new:
app/client/src/components/ads/Comments/AddCommentInput.tsx
91.89
87.5
92.31
90.91

:sparkles: :new:
app/client/src/components/ads/Comments/CommentCard.tsx
100
100
100
100

:sparkles: :new:
app/client/src/components/ads/Comments/Comments.tsx
100
100
100
100

:sparkles: :new:
app/client/src/components/ads/Comments/EmojiPicker.tsx
82.35
100
33.33
80

:sparkles: :new:
app/client/src/components/ads/Comments/InlineCommentPin.tsx
100
100
100
100

:sparkles: :new:
app/client/src/components/ads/Comments/InlineCommentThreadContainer.tsx
93.1
57.14
83.33
93.1

:sparkles: :new:
app/client/src/components/ads/Comments/OverlayCommentsWrapper.tsx
93.94
62.5
100
100

:sparkles: :new:
app/client/src/components/ads/Comments/ResolveCommentButton.tsx
100
75
100
100

:sparkles: :new:
app/client/src/components/ads/Comments/ScrollToLatest.tsx
100
100
100
100

:sparkles: :new:
app/client/src/components/ads/Comments/StyledComponents.tsx
100
100
100
100

:sparkles: :new:
app/client/src/components/ads/Comments/UnpublishedCommentThread.tsx
89.66
50
71.43
88.46

:sparkles: :new:
app/client/src/components/ads/Comments/init.ts
45.45
100
0
62.5

:sparkles: :new:
app/client/src/components/ads/Comments/selectors.ts
86.96
100
72.73
90

:sparkles: :new:
app/client/src/components/ads/Comments/utils.ts
80
0
50
77.78

:sparkles: :new:
app/client/src/components/ads/Comments/tests/setMockPages.ts
100
100
100
100

:red_circle:
app/client/src/components/editorComponents/DropTargetComponent.tsx
15.15 (-1.18)
2.82 (0.15)
0 (0)
16.85 (-1.33)

:sparkles: :new:
app/client/src/components/editorComponents/PreventInteractionsOverlay.tsx
60
50
0
69.23

:sparkles: :new:
app/client/src/constants/CommentConstants.tsx
100
100
100
100

:green_circle:
app/client/src/constants/DefaultTheme.tsx
73.12 (1.38)
80.56 (0)
42.86 (3.57)
75.9 (0.29)

:sparkles: :new:
app/client/src/constants/WebsocketConstants.tsx
57.14
100
0
100

:green_circle:
app/client/src/constants/messages.ts
51.48 (0.28)
100 (0)
2.38 (0.57)
72.08 (0.23)

:sparkles: :new:
app/client/src/mockResponses/CommentApiMockResponse.tsx
100
100
100
100

:green_circle:
app/client/src/reducers/entityReducers/pageListReducer.tsx
19.44 (5.55)
27.78 (27.78)
15.38 (15.38)
21.88 (6.25)

:green_circle:
app/client/src/reducers/uiReducers/editorReducer.tsx
12.12 (3.03)
0 (0)
9.09 (9.09)
12.12 (3.03)

:sparkles: :new:
app/client/src/reducers/uiReducers/websocketReducer.ts
83.33
100
0
83.33

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/commentsReducer.ts
70.97
0
71.43
73.33

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/handleAddCommentToThreadSuccess.ts
100
100
100
100

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/handleCreateNewCommentThreadSuccess.ts
100
100
100
100

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/handleFetchApplicationCommentsSuccess.ts
100
100
100
100

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/handleNewCommentThreadEvent.ts
37.5
100
0
37.5

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/handleUpdateCommentThreadEvent.ts
42.86
100
0
42.86

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/handleUpdateCommentThreadSuccess.ts
100
100
100
100

:sparkles: :new:
app/client/src/reducers/uiReducers/commentsReducer/testFixtures.ts
100
100
100
100

:green_circle:
app/client/src/sagas/ApplicationSagas.tsx
24.4 (0.3)
7.84 (0)
15.79 (0)
27.27 (0.32)

:green_circle:
app/client/src/sagas/InitSagas.ts
26.67 (0.23)
3.57 (0)
25 (0)
28.92 (0.17)

:sparkles: :new:
app/client/src/sagas/WebsocketSagas.ts
20.9
9.52
6.67
21.82

:green_circle:
app/client/src/sagas/index.tsx
92.5 (3.03)
50 (0)
100 (0)
94.87 (2.98)

:red_circle:
app/client/src/sagas/userSagas.tsx
17.37 (-0.1)
2.33 (-0.37)
8.33 (0)
20.57 (-0.14)

:sparkles: :new:
app/client/src/sagas/CommentSagas/handleCommentEvents.ts
25
0
0
25

:sparkles: :new:
app/client/src/sagas/CommentSagas/index.ts
72.37
55
75
73.33

:green_circle:
app/client/src/selectors/appViewSelectors.tsx
68.75 (12.5)
0 (0)
28.57 (28.57)
66.67 (6.67)

:green_circle:
app/client/src/selectors/editorSelectors.tsx
33.91 (1.74)
0 (0)
4.76 (4.76)
36.45 (1.87)

:green_circle:
app/client/src/utils/AppsmithUtils.tsx
40.99 (1.86)
12.2 (1.22)
30.56 (2.78)
39.87 (1.96)

:sparkles: :new:
app/client/src/utils/hooks/useIsScrolledToBottom.tsx
100
72.73
100
100

:red_circle:
app/client/src/widgets/BaseWidget.tsx
43.75 (-0.37)
0 (0)
3.45 (-0.25)
45.37 (-0.55)

:green_circle:
app/client/test/customQueries.js
95 (5)
100 (0)
66.67 (33.34)
94.74 (5.27)

folks", "y'all" or "people"). Always be respectful to each other, no matter the communication channel. If you feel like there was a violation of the Code of Conduct, please report it anytime.
We are a community and we're here for you.
Find our code on GitHub
Find ways to contribute
Find us on Twitter

folks", "y'all" or "people"). Always be respectful to each other, no matter the communication channel. If you feel like there was a violation of the Code of Conduct, please report it anytime.
We are a community and we're here for you.
Find our code on GitHub
Find ways to contribute
Find us on Twitter

folks", "y'all" or "people"). Always be respectful to each other, no matter the communication channel. If you feel like there was a violation of the Code of Conduct, please report it anytime.
We are a community and we're here for you.
Find our code on GitHub
Find ways to contribute

[ ] - - [ ] Find us on Twitter@ for it for me!  I'm sorry I didn't get back in time to go over to the neighborhood and puke like a choked up lunitic!

/ok-to-test sha=3a0dd2d

/ok-to-test sha=a36c4b7

/ok-to-test sha=9851de4

/ok-to-test sha=9851de4

/ok-to-test sha=5b89525


[xDai] Feature flag implementation for supported wallets

What is this feature about? (1 sentence)
As part of #1473, we need a way to show the user only the supported wallets for the specific network.
Why is it needed? What is the value? For whom do we build it?
Avoid future errors coming from wallets not supported by the current network.
High-level overview of the feature
Currently, we have came up with 2 ideas to handle it:

Create a supportedWallets key inside each network config object and adding all the wallets supported as an enum.

Create a disabledWallets key inside each network config object and adding only the wallets not supported by the network.

The same as the first one but if no wallet present, all of them will be supported.

I would like to open the discussion in order to decide which is the best way to handle it.

@dasanra @fernandomg @pablofullana @Agupane what do you think ?

I would be consistent with disabledFeatures. Enable all by default.


⚠ Bofrost.lu has degraded performance

In a802941, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1132 ms

Resolved: Bofrost.lu performance has improved in fbbd3da after 37 minutes.


 If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.
Describe the contribution to the taxonomy
Computations involving days and date intervals. (Just including examples going across one month boundary, this already seems to exercise the model’s limits.)
Input given at the prompt/Response that was received
With MERLINITE-7B-Q4_K_M:
how many days between Feb 1 and Mar 1?

The number of days between February 1 and March 1 depends on whether February
is a leap year or not. In a regular year, there are 31 days in February, so
the total number of days between February 1 and March 1 would be 28 (February
1 to February 28) plus 1 (March 1), which equals 29 days. However, in a leap
year, February has 29 days, so the total number of days between February 1
and March 1 would be 29 (February 1 to February 29) plus 1 (March 1), which equals 30 days.

How many days between Mar 2 and Apr 3?

The number of days between March 2 and April 3 is 30. This is because March has 31 days,
so from March 2 to March 3, there is 1 day; from March 3 to March 4, there is 2 days; from
March 4 to March 31, there are 28 days (31 - 3); from March 31 to April 1, there is 1
day; and from April 1 to April 3, there are 3 days (3 - 1). In total, this amounts to 30 days.

What is the number of days between Sep 19 and Oct 3, inclusive?

There are four days between September 19th and October 3rd, inclusive. This includes September
19th, 20th, 21st, and October 3rd. To calculate this, we start by finding the difference in days
between September 19th and October 2nd (inclusive), which is 12 days (30-day
September minus 1-day October plus 2 days). Then, we add October 3rd to account for
the last day in the range. Therefore, there are a total of 4 days between these two dates.

Response that is now received instead
This is not representative. I got reasonably correct answers in around 5 tries in each case, but the first answer was always incorrect. This seems to be limited by the inability/unwillingness of the model to do basic math and/or to remember numbers from one sentence to the next, rather than the inability to express what needs to be done (per the surrounding text).
I am doubtful that adding more examples would substantially help with that; in the limit, the training data could contain all 365*365 combinations, but then we would, end up with an information retrieval problem, not a skill. I can auto-generate more training examples, if desired.
how many days between Feb 1 and Mar 1?

The number of days between February 1st and March 1st depends on whether February has 28 or 29 days in a particular year. To determine the number of days, we first need to calculate the total number of days in February, which can range from
28 to 29, depending on whether it's a leap year or not. If it's a leap year (a year that is divisible by 4, except for years divisible by 100, unless the year is divisible by 400), then February will have 29 days. If it's not a leap year, then February will have 28 days. Once we have determined the number of days in February, we can then add 1 to account for March 1st. So, if February has 28 days, then the number of days between February 1st and March 1st is 29; if February has 29 days, then the number of days between February 1st and March 1st is 30.

How many days between Mar 2 and Apr 3?

To calculate the number of days between March 2nd and April 3rd, we first need to determine how many days are in March. There are 31 days in March, so from March 2nd to March 31st, there are 30 days in total. To find the total number of days between March 2nd and April 3rd, we add the 30 days in March to the 3 days in April, giving us a total of 33 days. Therefore, there are 33 days between March 2nd and April 3rd, inclusive.

 What is the number of days between Sep 19 and Oct 3, inclusive?

There are 14 days between Sep 19 and Oct 3, inclusive. To calculate this, we start by finding the difference in calendar days between Sep 19 (inclusive) and Oct 3 (inclusive), which results in 14 days.

Contribution checklist

[x] tested contribution with lab generate
[x] lab generate does not produce any warnings or errors
[x] all commits are signed off (DCO)
[x] the qna.yaml file was linted

Thank you for your contribution to InstructLab! Unfortunately, once a Github repo is made public, all open PRs are automatically closed since they link against a private repo. We have detected that your PR might have been one of the ones affected by this change. If you are still interested in contributing your improvement, please fill out the following short form by no later than May 3rd, and we will get back to you with the additional steps necessary once we have had time to assess the PRs of those still interested:
https://forms.gle/V7SrPPMZDo6iGDYu8


Release Mendix for Private Cloud Operator 1.3.0

Anticipated release date: July 15

Updated the Release Notes
Added documentation how to upgrade to the latest Mendix for Private Cloud version
Updated documentation and screenshots to include new configuration options

Asked to publish over Slack.


Connect the Dots and Azure Stream Analytics... How to?

I think I must be missing something obvious.  I have CTD up and running, sending lots of nice data to the event hub, website displaying data fine..  However, while there are several statements indicating running Azure Stream Analytics is "easy" I have yet to be able to get it (or see it) running.
It seems I may need to define AZURESTREAMANALYTICS... somewhere, but there is no documentation saying just what has to be done.
Very frustrating.

Mark

What the...
There used to be a SA_setup.md file in the /StreamAnalyticsQueries folder. Found it, pushed. Now I just have to find where it should be linked from in the readme.md.
Sorry, and thanks for pointing out!
Spyros

Added link into readme.md for Stream Analytics setup.

Well, I tried following the SA_setup, and something still isn't right.
First, it appears the instructions in SA_setup are for a somewhat older Azure portal than the current one.  (This is the "manage" portal, not the new preview portal.)  Things like "Alias" names are needed, StreamingAnalytics policy name, etc.
Second, I don't get any alerts posted to the website.  Which may or may not be because of SA.  If I block the light sensor, I can see the output drop in the graph, but there isn't an alert generated.
Finally, the "Alerts" and "LightSecsor" jobs have a "Processing" status, while the "Aggregates" job has a "Degraded" status.
Very confused.

Mark

You are right on two specific counts: the instructions are for (a) the original Azure "manage"  portal, and (b) for a slightly earlier version of ConnectTheDots. I just grabbed what I found without editing. Will do so as soon as I can.
The reason the instructions were not there, it turns out, is that the most recent version of AzurePrep automatically creates the SA jobs for you, so the instructions are mostly redundant, and only if you want to do it yourself. Need to be edited in that regard.
Now why the alerts are not posting, that is another matter. Would need to check all the settings. Basically, if the data is in ehdevices, and the SA Input, Query, and Output are as defined, the alerts should show up in the website. The only thing I can suggest is that you check the "Operations Logs" on each Event Hub page to see if you can identify the source of the problem.

The reason the instructions were not there, it turns out, is that the most recent version of AzurePrep automatically creates the SA jobs for you

This would suggest having some form of update history or release notes (with history) would be beneficial.  Otherwise, the novice will get caught by not knowing whether the problem(s) being encountered are of their own doing or are some form of mismatch with the instructions / infrastructure.  This would almost certainly be a turn-off to going forward.
I have checked the operation logs for both event hubs, and the only entries are weeks old for the "CreateConsumerGroup" when I first created everything.  There is noting since May 13, and I have been trying to get SA going for the past several days, so that would indicate there hasn't been anything posted related to SA; or the device for that matter.
I would seem it would be more productive to toss everything I have and start over with the latest. :-(

Mark


Mqtt Last Will and Testament use on Project

Hi, I'm using the zwave-js to control some devices and I need a way to know if the gateway is offline. I have researched a little bit how to do it with mqtt and I found out the Last Will and Testament. Does this project have something similar?

Sure, lastWill testament topic is:
<mqtt_prefix>/_EVENTS_/ZWAVE_GATEWAY-<mqtt_name>

Payload:
{
  "value": false
}


Text to speech and speech to text

Assigned to Abhinav and Karthik

assign me :)

assign me

assign me


Reland #49925

#49925 ran CI before  #49891  was merged, and then failed postsubmit because of #49891
This relands #49925 with updates to the stack elision logic for new frames introduced by it.
/cc @rrousselGit @goderbauer @jmagman

This is getting bitten by the skia gold flakes....