chore: add .gitattributes file for EOL normalization

add .gitattributes for non-vscode editors
replace single with double quotes (and escape them) in the prettier call to be shell-agnostic.

The escaped double quotes work fine, thank you.
As for .gitattributes, you need to add another line:
* eol=lf

for it to work.
After that, everything seems to work fine - the repo gets checked out with LFs even though core.autocrlf=true and vscode correctly detects the files having LF and works with them in this mode, so no need to set anything there.

@michaelkonecny awesome, I will add it and merge. Please do not about my comment on the now closed PR #955, all scripts in package.json using && will not work in powershell.


Markdown Reporting

todo link single models to their logs

@bauersimon please rebase again

There is an open task in the issue #49 what is that one about?

There is an open task in the issue #49 what is that one about?

automatically selecting interesting model responses for the report

NOOOOOOOOOOOOOOO just ran a benchmark for some time and then:
2024/04/25 18:15:09 Evaluating models and languages
mkdir README.md: not a directory
2024/04/25 18:15:09 Could not parse arguments: mkdir README.md: not a directory
github.com/symflower/eval-dev-quality/evaluate/report.Markdown.WriteToFile
        /home/zimmski/symflower/src/github.com/symflower/eval-dev-quality/evaluate/report/markdown.go:164
github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/cmd.(*Evaluate).Execute
        /home/zimmski/symflower/src/github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/cmd/evaluate.go:289
github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/cmd.Execute.func1
        /home/zimmski/symflower/src/github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/cmd/command.go:34
github.com/jessevdk/go-flags.(*Parser).ParseArgs
        /home/zimmski/symflower/pkg/mod/github.com/jessevdk/go-flags@v1.5.1-0.20210607101731-3927b71304df/parser.go:333
github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/cmd.Execute
        /home/zimmski/symflower/src/github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/cmd/command.go:37
main.main
        /home/zimmski/symflower/src/github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/main.go:11
runtime.main
        /home/zimmski/symflower/.devenv/go@1.21.5/go/src/runtime/proc.go:267
runtime.goexit
        /home/zimmski/symflower/.devenv/go@1.21.5/go/src/runtime/asm_amd64.s:1650
panic: Could not parse arguments: mkdir README.md: not a directory
github.com/symflower/eval-dev-quality/evaluate/report.Markdown.WriteToFile
        /home/zimmski/symflower/src/github.com/symflower/eval-dev-quality/evaluate/report/markdown.go:164
github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/cmd.(*Evaluate).Execute
        /home/zimmski/symflower/src/github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/cmd/evaluate.go:289
github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/cmd.Execute.func1
        /home/zimmski/symflower/src/github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/cmd/command.go:34
github.com/jessevdk/go-flags.(*Parser).ParseArgs
        /home/zimmski/symflower/pkg/mod/github.com/jessevdk/go-flags@v1.5.1-0.20210607101731-3927b71304df/parser.go:333
github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/cmd.Execute
        /home/zimmski/symflower/src/github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/cmd/command.go:37
main.main
        /home/zimmski/symflower/src/github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/main.go:11
runtime.main
        /home/zimmski/symflower/.devenv/go@1.21.5/go/src/runtime/proc.go:267
runtime.goexit
        /home/zimmski/symflower/.devenv/go@1.21.5/go/src/runtime/asm_amd64.s:1650

goroutine 1 [running]:
log.(*Logger).Panicf(0xc0000dbb90?, {0x97fa6a?, 0x1?}, {0xc0004bdee8?, 0x0?, 0x8c9960?})
        /home/zimmski/symflower/.devenv/go@1.21.5/go/src/log/log.go:310 +0x6e
github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/cmd.Execute(0xc0000b7920, {0xc000024050, 0x1, 0x1})
        /home/zimmski/symflower/src/github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/cmd/command.go:42 +0x2b4
main.main()
        /home/zimmski/symflower/src/github.com/symflower/eval-dev-quality/cmd/eval-dev-quality/main.go:11 +0x65
        ```

wer/eval-dev-quality/evaluate/report/markdown.go:164

Clearly a test is missing!

wer/eval-dev-quality/evaluate/report/markdown.go:164

Clearly a test is missing!

I always get filepath.Base and filepath.Dir mixed up -_- ...

I always get filepath.Base and filepath.Dir mixed up -_- ...

What strikes me as odd, is that no test was failing ... can you please add an explicit test that fails without this change

@bauersimon  Taking this PR and doing fixups as i go


feature request : Standalone Pod and white list

Hello,
I need :
A way to configure a standalone pod which can't communicate with other pods.
A way to create a white list of pods the pod is authorized to talk.
Use case : I would like to install a pod for a school / a list of school.

Wrong issue tracker? This isn't Diaspora*

sorry, too much tabs opened...


Create documentation for AutoMapper

Describe the change
Update the wiki to include information on how the auto mapper works in the API.
Why is this happening
To ensure the whole team understands the standard usage for AutoMapper in the API.

Nice explanation, LGTM


"Show text, dates, and times in Power Apps" is misleading

This article implies an inaccurate interpretation of the DateTimeValue and DateValue functions. In "Format dates and times by using DateTimeValue", at the third step, the article implies that running DateTimeValue(..., "fr") converts the date into a French date. The reverse is true: that function is parsing the input text as if it's a French date, which is why it flips the date in the output in the example. You can see the issue if you run DateValue("12/20/2020", "fr"), which will output "8/12/2021" if formatted, because it's interpreting 20 as a really large month number in French.
I was going to submit a PR myself, but a enough of the article is predicated on the idea that DateTimeValue and DateValue are what's doing the formatting, rather than the parsing, that I wasn't sure how to maintain the original purpose of the article while using Text for formatting, instead of the date parsing functions.

Discussed internally and closing this task without documentation changes.


SharePoint loader returns empty list when object_ids are not passed in

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
import os
from langchain_community.document_loaders.sharepoint import SharePointLoader

os.environ['O365_CLIENT_ID'] = "<client_id>"
os.environ['O365_CLIENT_SECRET'] = "<client_secret>"

# option 1: this returns empty list
loader = SharePointLoader(document_library_id="<document_library_id>",
                          auth_with_token=True)
loader.load()

# option 2: this returns correctly, but only documents with listed ids
loader = SharePointLoader(document_library_id="<document_library_id>",
                          object_ids=["object_id_1","object_id_2"],
                          auth_with_token=True)
loader.load()

Error Message and Stack Trace (if applicable)
No response
Description
I'm trying to use SharePoint document loader.

When I don't pass in any folder_path I would expect the loader to load all supported documents from the SharePoint. However I get empty list []. There are supported documents in the root directory.
Any folder_path I try to pass in is rejected with ValueError: There isn't a folder with path <folder_path>. It may have something to do with the root directory being called Shared Documents. The space in the folder name might be causing trouble. *more details in a comment
When I pass in object_ids, I get the documents returned correctly.

System Info
langchain==0.1.14
langchain-community==0.0.31
langchain-core==0.1.38
langchain-openai==0.0.8
langchain-text-splitters==0.0.1

Windows / Python 3.11.5

Regarding not being able to pass in a folder_name that would be accepted: I tried numerous values with no success:

Shared Documents
Shared%20Documents
Shared\ Documents
Adding / before and/or after the before mentioned values
Only using lowercase letters
Using Documents instead of Shared Documents
...
The issue might be mitigated if this PR is merged in


Bug: Display Goal is falsely red if budget has "reimbursement" larger than goal

Defective ToolKit Feature Name: Display Target Goal Amount And Overbudget Warning #765
Expected Behavior
When I budget the goal amount, the "Target Goal Amount" is displayed green, indicating, that my goal is met.
Actual Behavior
My "Travel" budget is red.
At first, I thought it is because I had already spent some this month:

But after removing the spending and with a positive activity, the Goal Amount is still red:

Only after removing the travel reimbursement does the Goal Amount get displayed in green:

I then tried recreating the behavior: it only occurs when one inflow amount is larger than the goal amount.
Steps to Reproduce the Behavior

Set up a monthly goal, e.g. $50
 Create an inflow amount larger than the goal amount, e.g. $55

Export of Toolkit Settings (Bottom Left of Settings Page)
[{"key":"AutoCloseReconcile","value":false},{"key":"CustomFlagNames","value":false},{"key":"DisplayTargetGoalAmount","value":true},{"key":"HideReferralBanner","value":false},{"key":"RunningBalance","value":false},{"key":"ShowCategoryBalance","value":false},{"key":"StealingFromFuture","value":false},{"key":"TargetBalanceWarning","value":false},{"key":"accountsClearSelection","value":true},{"key":"accountsDisplayDensity","value":"0"},{"key":"accountsEmphasizedOutflows","value":true},{"key":"accountsRowHeight","value":"0"},{"key":"accountsStripedRows","value":false},{"key":"activityTransactionLink","value":true},{"key":"betterScrollbars","value":"0"},{"key":"budgetBalanceToZero","value":true},{"key":"budgetProgressBars","value":"0"},{"key":"budgetQuickSwitch","value":false},{"key":"budgetRowsHeight","value":"0"},{"key":"calendarFirstDay","value":"0"},{"key":"categoryActivityPopupWidth","value":"0"},{"key":"changeEnterBehavior","value":true},{"key":"checkCreditBalances","value":true},{"key":"checkNumbers","value":false},{"key":"closeReconcileWindow","value":false},{"key":"collapseExpandBudgetGroups","value":true},{"key":"collapseSideMenu","value":true},{"key":"colourBlindMode","value":false},{"key":"compactIncomeVsExpense","value":false},{"key":"currentMonthIndicator","value":true},{"key":"daysOfBuffering","value":true},{"key":"daysOfBufferingHistoryLookup","value":"1"},{"key":"editButtonPosition","value":"0"},{"key":"enableRetroCalculator","value":true},{"key":"enlargeCategoriesDropdown","value":true},{"key":"enterInRegisterNow","value":true},{"key":"exportTransactions","value":false},{"key":"goalIndicator","value":true},{"key":"goalIndicatorWarningColor","value":true},{"key":"googleFontsSelector","value":"0"},{"key":"hideAOM","value":false},{"key":"hideAccountBalancesType","value":"0"},{"key":"hideHelp","value":true},{"key":"highlightNegativesNegative","value":true},{"key":"importNotification","value":"0"},{"key":"incomeFromLastMonth","value":"0"},{"key":"l10n","value":"0"},{"key":"largerClickableIcons","value":true},{"key":"monthlyNotesPopupWidth","value":"0"},{"key":"navDisplayDensity","value":"0"},{"key":"pacing","value":"0"},{"key":"popupCalculator","value":false},{"key":"printingImprovements","value":true},{"key":"privacyMode","value":"0"},{"key":"reconciledTextColor","value":"0"},{"key":"removePositiveHighlight","value":false},{"key":"removeZeroCategories","value":true},{"key":"reports","value":false},{"key":"resizeInspector","value":true},{"key":"rightClickToEdit","value":true},{"key":"runningBalance","value":false},{"key":"seamlessBudgetHeader","value":false},{"key":"showIntercom","value":true},{"key":"spareChange","value":false},{"key":"splitKeyboardShortcut","value":true},{"key":"splitTransactionAutoAdjust","value":true},{"key":"squareNegativeMode","value":false},{"key":"stealingFromNextMonth","value":false},{"key":"swapClearedFlagged","value":false},{"key":"toBeBudgetedWarning","value":true},{"key":"toggleSplits","value":false},{"key":"toggleTransactionFilters","value":"0"},{"key":"warnOnQuickBudget","value":false}]

System Settings
ToolKit Version: 1.0.2
Operating System (Mac/Windows/Etc): Windows 10
Browser (Chrome/Firefox/Safari): Chrome
Browser Version: 58.0.3029.110 (64-bit)
Other Extensions: --several--

I hope to have fixed your issue here: #803
Cheers @GeorgLink

Thanks @danieldbird
I tested against the current 1.1.0 master branch and the error is fixed.
On a side note: is there a way to display the goal amount green when I budget more than my plan for the month is? It makes no sense to me, to display the goal red, if I overachieve it. Example: We plan x amount for home improvement projects each month, but sometimes we need more and "roll with the punches" but then the goal amount should not be red. - Should I open a new issue to discuss this behavior?

Closing this, because it's fixed in the current development version 1.1.0
My last comment is moved to #827 and hopefully fixed with #828


RowHeight not working as expected

Please mark the type of this issue:

[x] Bug
[ ] Feature Request
[x] Question

I have set my rowHeight in the ResponsiveReactGridLayout to 70, and the height of one of my elements right before the last has a height of 5 ... so I am expecting 350 + 10 for the margin that I'm reading in the other issues, so 360 total.
But right now the height of that draggable item is 390. Am I misunderstanding how rowHeight works?
Here is the specific key item below, and my other question is ... is it a problem to have a set height inside of the draggable item children? (seen below in the div with styles.dashboardBody

      Trending Searches

        <FontAwesome
          border={false}
          name="align-justify"
          style={{color: 'white'}}
        />

      {!this.state.gettingTrending ?

          {this.state.trendingSearches.length > 0 ?

              {this.state.trendingSearches.slice(0, 5).map((item, index) => (

{item.term}

              ))}

 :

Nothing found.

          }

 :

Fetching...

}

And here is one of the layouts I'm using:
lg: [
  {i: 'a', x: 0, y: 0, w: 4, h: 3, isResizable: false}, //net profit
  {i: 'b', x: 4, y: 0, w: 4, h: 3, isResizable: false}, //orders made as of tday
  {i: 'c', x: 8, y: 0, w: 4, h: 5, isResizable: false}, //average mobile users

  {i: 'd', x: 0, y: 3, w: 8, h: 5, isResizable: false}, //recent order graph
  {i: 'e', x: 8, y: 5, w: 4, h: 3, isResizable: false}, //orders as of yesterday

  {i: 'f', x: 0, y: 8, w: 6, h: 5, isResizable: false}, //trending products
  {i: 'g', x: 6, y: 8, w: 6, h: 5, isResizable: false}, //top searches

  {i: 'h', x: 0, y: 13, w: 12, h: 5, isResizable: false}, //order history
],

And here is a dev tools screenshot for further clarity:

Hi - in order for all elements of different row heights to align, (height -
1)*margin is applied to the row height.
On May 17, 2017 2:23 PM, "Taylor King"<EMAIL_ADDRESS>wrote:

Please mark the type of this issue:

Bug
Feature Request
Question

I have set my rowHeight in the ResponsiveReactGridLayout to 70, and the
height of one of my elements right before the last has a height of 5 ... so
I am expecting 350 + 10 for the margin that I'm reading in the other
issues, so 360 total.
But right now the height of that draggable item is 390. Am I
misunderstanding how rowHeight works?
Here is the specific key item below, and my other question is ... is it a
problem to have a set height inside of the draggable item children? (seen
below in the div with styles.dashboardBody

      Trending Searches

      {!this.state.gettingTrending ?

          {this.state.trendingSearches.length > 0 ?

              {this.state.trendingSearches.slice(0, 5).map((item, index) => (
                {item.term}
              ))}
             :

Nothing found.

          }
         : Fetching...}

And here is one of the layouts I'm using:
lg: [
{i: 'a', x: 0, y: 0, w: 4, h: 3, isResizable: false}, //net profit
{i: 'b', x: 4, y: 0, w: 4, h: 3, isResizable: false}, //orders made as of tday
{i: 'c', x: 8, y: 0, w: 4, h: 5, isResizable: false}, //average mobile users
{i: 'd', x: 0, y: 3, w: 8, h: 5, isResizable: false}, //recent order graph
{i: 'e', x: 8, y: 5, w: 4, h: 3, isResizable: false}, //orders as of yesterday
{i: 'f', x: 0, y: 8, w: 6, h: 5, isResizable: false}, //trending products
{i: 'g', x: 6, y: 8, w: 6, h: 5, isResizable: false}, //top searches
{i: 'h', x: 0, y: 13, w: 12, h: 5, isResizable: false}, //order history
],
And here is a dev tools screenshot for further clarity:
[image: screen shot 2017-05-17 at 2 22 32 pm]
https://cloud.githubusercontent.com/assets/14862852/26171974/64ccc3f8-3b0c-11e7-8c71-0b17772769af.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/STRML/react-grid-layout/issues/559, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABJFPxi783fI-CVJvaTRqknw6m90zRKrks5r60k3gaJpZM4NeU-s
.

@STRML Interesting, thanks for the response. Would there be any way to override that formula, or another recommended solution for having the issue of too much space in between your rows?

There's no other way to do it, if you want margin. Otherwise the rows would end up haggard. You could just not use margin at all.

Ok ... i'll have to look into this a bit further. I do like the margin, and it is generally working ... it's just that second to last row that has been bothering me ha. I'll share the full layout, maybe I'm not doing something correctly with the layout object or something.

Anyways thanks @STRML  for the insight to rowHeight ... it's definitely good to know that extra little formula calculating that total height. Helped with some confusion.


Review code

I suggest these:
1 - In order to have a professional code layout, It would be better to use comments in your code.
2 - In line 217, It would be a nice idea to contain the name of language inside of a anchor element.
3 - In line 285, I suggest to clean "p" element and you can use of ul and li instead.

Great job!
1 - No linter errors.
2 - Nice workflow.
3 - Well class names.


Create models

Models emit to JSON in camelCase.

Codecov Report

Merging #3 (c57a927) into main (fa9b3e3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3        12    +9
  Lines          106       201   +95
  Branches         9        18    +9
=========================================
+ Hits           106       201   +95

Impacted Files
Coverage Δ

collectors/__init__.py
100.00% <100.00%> (ø)

collectors/base.py
100.00% <100.00%> (ø)

collectors/models/__init__.py
100.00% <100.00%> (ø)

collectors/models/base.py
100.00% <100.00%> (ø)

collectors/models/league.py
100.00% <100.00%> (ø)

collectors/models/manager.py
100.00% <100.00%> (ø)

collectors/models/player.py
100.00% <100.00%> (ø)

collectors/models/record.py
100.00% <100.00%> (ø)

collectors/models/roster.py
100.00% <100.00%> (ø)

collectors/models/season.py
100.00% <100.00%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa9b3e3...c57a927. Read the comment docs.


[PreviewCard] Created a separated single Attachment that will connect to PreviewCard

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
Created an attachment that will be directly connected beneath the PreviewCard.
The Attachment is currently separated from PreviewCard's view. It'll be embedded with PreviewCard as a single control at a later date to reduce redundancy and keep the code clear.
Verification

Before
After

Pull request checklist
This PR has considered:

[ ] Light and Dark appearances
[ ] iOS supported versions (all major versions greater than or equal current target deployment version)
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
[ ] iPad Pointer interaction
[ ] SwiftUI consumption (validation or new demo scenarios needed)
[ ] Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

Looks like the 40x40 image isn't actually 40x40, but 40x48. Intentional?


Resolve #129: Use Java7 in TracEE 2.0

Initial commit for TracEE 2.0

Raise the version up to 2.0.0-SNAPSHOT
Use Java7 instead of Java6.

Lgtm


Issue with savings_account interest_rate test

Problems

The current test for SavingsAccount.interest_rate  is written to expect a fixed value of 0.5 for balances less than 1000. This contradicts the exercise specification which emphasizes an interest rate of 0.5% ~ 0.005.

Posible solution

Kindly change the expected value to 0.5% ~ 0.005 of the balance for balances less than 1000.

Thank you

https://forum.exercism.org/t/issue-with-savings-account-interest-rate-test/8763 is the discussion link on the forums.


Add preconditions to transaction_v0

Context
We need to update the transaction_v0 struct with the preconditions according to the CAP-21 implementation for the Stellar Core.
Objective

[ ] Update the transaction_v0 struct with the preconditions.
[ ] Update the respective tests and related structs.

Closed due to bad implementation of the transactionV0


Fix processing of argument of the “*” operator

Consider an expression like this:
*field = "foo"

The field variable is evaluated and its value is used to select a point field. It is not itself assigned to. In semantic pass, this corresponds to processing with this.lhs == false.
Before this commit, code in sa_UnaryExpression wrongly processed * arguments with the same this.lhs value as the operator itself. This PR fixes it to always process them with this.lhs == false.
Fixes #598.

@bkutil

+1


Modifying some icon colors does not seem to take effect.

Describe the bug

When I try to change the .npmrc icon color, but it takes no effect.
To Reproduce

Change the .npmrc icon color to #D14748
The icon color keeps the default green (may be it is green)

Expected Behavior

Change the icon .npmrc to color #D14748
Environment

Mac
WebStorm 2023.2
Atom Material Icons 92.0.0
list of enabled plugins: 1. Atom Material Icons 2. Material Theme UI 3. Github Copilot

Screenshots

Thanks. There are some icons with the wrong path, I did a quick search to see if there are others in that case.
It will be fixed next release

Thank you so much!


Add new constructor options to HistoricalRecords class

Provide history_id_field to change the field type for history_id
Provide user_model to use an alternative model for tracking history_user

Codecov Report

Merging #351 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   97.63%   97.66%   +0.02%
==========================================
  Files          15       15
  Lines         593      600       +7
  Branches       73       74       +1
==========================================
+ Hits          579      586       +7
  Misses          7        7
  Partials        7        7

Impacted Files
Coverage Δ

simple_history/registry_tests/tests.py
100% <ø> (ø)
:arrow_up:

simple_history/models.py
97.01% <100%> (+0.1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35febc3...d87833f. Read the comment docs.

This would solve for #116. Happy to discuss allowing UUIDs for the historical tables, but I'm less inclined to allow for a separate user model. Want to split this up into two PRs and we can discuss them separately? @rwlogel

No worries. Let's definitely split the changes into two PRs so that we can have the discussions separately. Happy to allow UUIDs on history IDs as I've seen that functionality requested multiple times.
More hesitant about allowing a CustomUser model as it's rare to see Django programmers using a user model that doesn't extend AUTH_USER_MODEL, and I'm worried about any possible side effects (the way we track users with middleware is a little magic-y).
However, I understand your use case – essentially keeping sensitive fields in a separate table, right? Going to close this PR and ask you to open these two features in separate PRs and we can discuss them separately.

Changing the user model doesn't work with the built in middleware, as documented in the PR it requires the user of the _history_user.  I will submit new PR's shortly and try to include an example of what a middleware with the a custom user model may look like.

Thanks @rwlogel


17052 — migrate BaseMiniContextMenuItem to PressableWithoutFeedback

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/17052
PROPOSAL: https://github.com/Expensify/App/issues/17052
Tests

BaseMiniContextMenuItem is used in various places: ShareCodePage, User Details page (copy icon next to mail), LHN (popover on secondaryClick Row), Emoji popover on message hover.

Share Code Page

log in
press/click the avatar in LHN
navigate to Share code
press/click Copy URL to clipboard, verify that behaviour and styling remain unchanged

User Details Page

log in
navigate to chat
click the user avatar in chat window
click/press copy icon in the e-mail row. Verify that behaviour and styling remain unchanged

LHN popover

log in
hover on any chat in LHN and perform secondary click (longPress on touch devices, right-click on others)
verify that popover became visible as intended

Emoji popover on message hover

log in
navigate to any chat
hover on any sent message
verify that popover appeared, and has emoji in itself

[X] Verify that no errors appear in the JS console

Offline tests

Same as test steps
QA Steps

Same as test steps

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/61146594/3caf1648-ea40-4477-8921-13f57d10a6e5

Mobile Web - Chrome
https://github.com/Expensify/App/assets/61146594/868cfad5-b3ad-4877-91dd-e1fc21a06507

Mobile Web - Safari
https://github.com/Expensify/App/assets/61146594/7eb26666-e2a4-4ab7-ad43-9af1eec75c1b

Desktop
https://github.com/Expensify/App/assets/61146594/ec0ce5ab-b325-499f-ba06-3356942a1e6c

iOS
https://github.com/Expensify/App/assets/61146594/f50a4f9f-7316-4224-a7ec-deaf80a2c207

Android
https://github.com/Expensify/App/assets/61146594/a78137b7-0d80-4ac9-847f-78cf279e2686

Conflicts Resolved. @cristipaval pinging

@aimane-chnaif has to test.

Everything passed, Melv.

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.28-1 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
failure ❌

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.28-1 🚀

platform
result

🤖 android 🤖
cancelled 🔪

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
failure ❌

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


How to use it?
Click on the GitHub button next to the save button.
Details

https://makecode.com/blog/github-packages
https://makecode.com/blog/github-extensions-episode-2
https://makecode.com/blog/makecode-with-github

Feedback
Do you use this feature? Is there something you'd like to change? Did you encounter issues? Please drop a comment on this issue to send us your feedback.

Supported int the editor now.


💡 [REQUEST] - Atomic Red Team Executor

Implementation PR
No response
Reference Issues
No response
Summary
We need to figure out a way to ingest and use TTPs from Atomic Red Team
Basic Example
ttpforge -c config.yaml run rc atomics/T1003.003/T1003.003.yaml

Drawbacks
Could be complicated.
Unresolved questions
Do we want to create a transform function to consume ART or Nuclei "TTPs" into our YAML format? This could save us a lot of heartburn.
Do we want it to be part of the forge codebase or do we want to figure out a modular attachment for this functionality?

I think we should follow the Technique class to examine how to build parser for Atomic Red Team yaml definitions


Jalaali(Persian) Date input support

It's good to support  Jalaali(Persian) date.   User can input date text in Jalaali  and  DateFiled  should parse it to Georgian date. it's very useful feature  for users that using  Jalaali calendar system.

I know nothing about Persian date formats.
Is there no built-in capability in .NET for handling them? In reviewing the PR for this (#1205) I see you've added a specific flag to the API. On the surface, this appears clunky to me.
Are you sure there's no way to add this support in a way that would ALSO add support for any other important but less common date input formats?
What we want to avoid is having the API need to support more and more flags like this over time. If Persian is the only outlier that requires this then I'm all for the solution you've provided!

I know nothing about Persian date formats.
Is there no built-in capability in .NET for handling them? In reviewing the PR for this (#1205) I see you've added a specific flag to the API. On the surface, this appears clunky to me.
Are you sure there's no way to add this support in a way that would ALSO add support for any other important but less common date input formats?
What we want to avoid is having the API need to support more and more flags like this over time. If Persian is the only outlier that requires this then I'm all for the solution you've provided!

You can learn about Persian date here. more that 150 millions people are using this calendar. As I know there is no built-in input for that in .NET and just has a PersianCalendar class  that converts Georgian date into Persian date but no input control is available. I agree that is not a good way to set a flag for each type of format. I can change it to new class and call it 'PersianDateField' but it needs to be derived from DateField class and override some of it's methods. the problem is DateField methods are not virtual and can not be overridden.  do you have any idea to ignore flag parameter?

Got it.
I imagine over time there may be more controls that take date input/display dates...
I wonder if we should add a flag to a base class, e.g. View that gets set once to indicate Persian date formatting is in use. This could also be set automatically if it's possible to detect the user's computer-wide settings?
Now that I mention it, are you sure there's no way to detect this is a user's preference?

Got it.
I imagine over time there may be more controls that take date input/display dates...
I wonder if we should add a flag to a base class, e.g. View that gets set once to indicate Persian date formatting is in use. This could also be set automatically if it's possible to detect the user's computer-wide settings?
Now that I mention it, are you sure there's no way to detect this is a user's preference?

I think it's possible to detect system settings, but the point is 99% of people do not change OS settings to enter a Persian date.  it's because of incompatibility of other Persian programs or etc.. for example my windows calendar setting is Georgian date  but in my accounting software I enter date in Jalaali format. I don't want to change my hole system setting just for  a accounting software.

How about to add a custom date format property in the DateField view?

How about to add a custom date format property in the DateField view?
it's not only about  date format string. the calendar system also should change. for example date format yyyy-MM-dd will be used in both Georgian and Jalaali systems.


question

hi i m searching a compiler for converting javascript to java or directly to bytecode . It is possible with your lib ? is there a example?

No, it's impossible. Look at Rhino or Nashorn.


Fix date input issue #6

The bug occurred because of a problem with date formatting and conversion within the DateInput.svelte component.
Changes:
Adjusted the logic in DateInput.svelte to ensure proper date handling and conversion.
Replaced the existing code that incorrectly handled date formatting and conversion with a simplified approach that directly binds the input date to the correct format.
Fixes: Issue #6

Amazing, thank you so much!


App not localized for release versions working fine for debug versions

Library version used : implementation 'com.akexorcist:localization:1.2.6'
If any progruard rules to be added for release versions please do provide.
bundle {
language {
enableSplit = true
}
}

working fine


Criticality rating is to optimistic

Hi ORT community,
I was just struggling with with one of my created WebAppReports - In the report the vulnerabilty CVE-2023-2976 is shown with the criticality of MEDIUM.

I checked all the linked references and found the NIST rating in there (https://nvd.nist.gov/vuln/detail/CVE-2023-2976 )
The NIST rating itself shows two scores

NIST: BaseScore: 7.1(HIGH)
CNA: BaseScore: 5.5 (Medium)

I'd expect that the report would show me the worst case and therefor I wanted to ask how the decision is taken which score is applied in the report - To be on the save side a more conservative approach, which aims for the highest criticality, could help.

Thanks for the report @Ragamuffin85. Could you please share (excerpts of) your raw ORT advisor result, so we can have a look which scores are being reported? At the example of a YAML report, I'm interested in a section that looks similar to this:
    advisor_results:
      PyPI::flask:2.2.3:
      - advisor:
          name: "OssIndex"
          capabilities:
          - "VULNERABILITIES"
        summary:
          start_time: "2023-02-27T10:47:39.903421900Z"
          end_time: "2023-02-27T10:47:41.258589300Z"
        defects: []
        vulnerabilities:
        - id: "sonatype-2020-0201"
          summary: "1 vulnerability found"
          description: "1 non-CVE vulnerability found. To see more details, please\
            \ create a free account at https://ossindex.sonatype.org/ and request\
            \ for this information using your registered account"
          references:
          - url: "https://ossindex.sonatype.org/vulnerability/sonatype-2020-0201"
            scoring_system: "CVSS:3.1"
            severity: "4.8"

Hi @sschuberth,
thanks for taking care :-)!
Please find attached the excerpts for the mentioned CVE
 - id: "CVE-2023-2976"
          references:
          - url: "https://github.com/google/guava/commit/feb83a1c8fd2e7670b244d5afd23cba5aca43284"
            scoring_system: null
            severity: null
          - url: "https://github.com/google/guava/issues/2575"
            scoring_system: null
            severity: null
          - url: "https://github.com/google/guava/issues/6532"
            scoring_system: null
            severity: null
          - url: "https://github.com/google/guava/releases/tag/v32.0.0"
            scoring_system: null
            severity: null
          - url: "https://security.netapp.com/advisory/ntap-20230818-0008/"
            scoring_system: null
            severity: null
          - url: "https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1038979"
            scoring_system: null
            severity: null
          - url: "https://nvd.nist.gov/vuln/detail/CVE-2023-2976"
            scoring_system: null
            severity: null
          - url: "https://github.com/advisories/GHSA-7g45-4rm6-3mm3"
            scoring_system: "cvssv3.1_qr"
            severity: "MEDIUM"

It looks like, as only the last entry from github advisories contained any severity-results.
the one from NIST returned with null :-(

If you need any additional information, please let me know

Could you please also include the part that says which advisor(s) have been used? I assume it was VulnerableCode?

Sorry, my bad :-)
I'm quite new to this complex environment and since there are some internals in the advisor.yml I don't wanted to share to many information ;-)
    advisor_results:
      Maven:com.google.guava:guava:19.0:
      - advisor:
          name: "VulnerableCode"
          capabilities:
          - "VULNERABILITIES"
        summary:
          start_time: "2023-10-26T06:14:51.591670Z"
          end_time: "2023-10-26T06:14:54.198678Z"
        defects: []
        vulnerabilities:
...
        - id: "CVE-2023-2976"
          references:
          - url: "https://github.com/google/guava/commit/feb83a1c8fd2e7670b244d5afd23cba5aca43284"
            scoring_system: null
            severity: null
          - url: "https://github.com/google/guava/issues/2575"
            scoring_system: null
            severity: null
          - url: "https://github.com/google/guava/issues/6532"
            scoring_system: null
            severity: null
          - url: "https://github.com/google/guava/releases/tag/v32.0.0"
            scoring_system: null
            severity: null
          - url: "https://security.netapp.com/advisory/ntap-20230818-0008/"
            scoring_system: null
            severity: null
          - url: "https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1038979"
            scoring_system: null
            severity: null
          - url: "https://nvd.nist.gov/vuln/detail/CVE-2023-2976"
            scoring_system: null
            severity: null
          - url: "https://github.com/advisories/GHSA-7g45-4rm6-3mm3"
            scoring_system: "cvssv3.1_qr"
            severity: "MEDIUM"

Whereas the advisor VulnerableCode points towards an internal adress

Whereas the advisor VulnerableCode points towards an internal adress

Which version of VulnerableCode are you hosting internally? I'm asking because there was a change in version 30.0.0 that we did not properly catch up with until https://github.com/oss-review-toolkit/ort/pull/7765. When using a fairly recent version of VulnerableCode plus a brand new ORT that includes the linked PR, this should not happen anymore, as the WebApp report is supposed to already use the "worst" severity for the icon. Could you check on that?

Hi @sschuberth,
I aligned with the colleagues to gather the necessary information.
The version if "VulnerableCode" that we're using is 32.0.0
This morning a new build was deployed with the mentioned PR in it.
But it seems as the problem still persists.
Please find attached the "new" advisor_results
  results:
    advisor_results:
      Maven:com.google.guava:guava:25.0-jre:
      - advisor:
          name: "VulnerableCode"
          capabilities:
          - "VULNERABILITIES"
        summary:
          start_time: "2023-11-02T08:29:12.950584Z"
          end_time: "2023-11-02T08:29:16.656203Z"
        defects: []
        vulnerabilities:
        - id: "CVE-2023-2976"
          references:
          - url: "https://github.com/google/guava/commit/feb83a1c8fd2e7670b244d5afd23cba5aca43284"
            scoring_system: null
            severity: null
            severity_rating: "UNKNOWN"
          - url: "https://github.com/google/guava/issues/2575"
            scoring_system: null
            severity: null
            severity_rating: "UNKNOWN"
          - url: "https://github.com/google/guava/issues/6532"
            scoring_system: null
            severity: null
            severity_rating: "UNKNOWN"
          - url: "https://github.com/google/guava/releases/tag/v32.0.0"
            scoring_system: null
            severity: null
            severity_rating: "UNKNOWN"
          - url: "https://security.netapp.com/advisory/ntap-20230818-0008/"
            scoring_system: null
            severity: null
            severity_rating: "UNKNOWN"
          - url: "https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1038979"
            scoring_system: null
            severity: null
            severity_rating: "UNKNOWN"
          - url: "https://nvd.nist.gov/vuln/detail/CVE-2023-2976"
            scoring_system: null
            severity: null
            severity_rating: "UNKNOWN"
          - url: "https://github.com/advisories/GHSA-7g45-4rm6-3mm3"
            scoring_system: "cvssv3.1_qr"
            severity: "MEDIUM"
            severity_rating: "MEDIUM"

TBH there's not that much of a difference :-)
P.S. meanwhile we upgraded the dependency, but the vulnerability is still in there ;-)

@Ragamuffin85 you're now quoting another dependency than before, it's Maven:com.google.guava:guava:19.0 vs. Maven:com.google.guava:guava:25.0-jre, though I guess it shouldn't make much of a difference as the CVE-2023-2976 is the same.
I've meanwhile added a test to show that the issue does not occur when using the public instance of VulnerableCode. So another thing you should check on your side is whether you regularly run the data importer on your VulnerableCode instance so that also the data is up to date. Because IIRC VulnerableCode does not fetch data directly from upstream but from its own database, that needs to be synced on a regular basis.

Hi @sschuberth ,
thanks for pushing this issue.
TL;DR; We're up2date but "something" seems to be fishy
I involved some of my colleagues who are way more in this topic than I am (I'm some kind of waterboy - carrying the buckets from A to B ;-))
The last feedback I received was, that we're running updates on a regular base and that the latest scans were based on the latest updates => But still contained the problem.
My colleagues started to dig deeper and they found "something" (Not sure what "something" means in this context).
I further asked them to please reply in this issue, so I'm in good spirits, that soon a new participant will appear in here ;-).
P.S. Your guess was right - The sentence referes to the version change ;-)
Cheers

We had a problem with the NVD importer. As a result, the database was corrupt and not all sources could be indexed. The problem should be fixed.

@turambarturin - Thanks for the feedback!
We'll monitor the current behavor for a while (You know, better safe than sorry ;-) ).
@sschuberth I'd say, since we identified the problem on our side, you can consider this issue as "Solved" - Thanks for your pro active support and also the provided fixes (including tests)


Collection of minor updates

@andresnava : Thanks for your contribution! The author(s) have been notified to review your proposed change.

These all look good to me!
#sign-off

@ShannonLeavitt : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Problem when try to install module, can't add module to IRIS

OS: clean Debian 12
sudo ./buildnpush2iris.sh -a
[BUILDnPUSH2IRIS] Pushing to Worker and App container!
[BUILDnPUSH2IRIS] Starting the build and push process..
./buildnpush2iris.sh: line 30: python3.9: command not found
ls: cannot access './dist': No such file or directory
[BUILDnPUSH2IRIS] Found latest module file:
[BUILDnPUSH2IRIS] Copy module file to worker container..
"docker cp" requires exactly 2 arguments.
See 'docker cp --help'.
Usage:  docker cp [OPTIONS] CONTAINER:SRC_PATH DEST_PATH|-
docker cp [OPTIONS] SRC_PATH|- CONTAINER:DEST_PATH
Copy files/folders between a container and the local filesystem
[BUILDnPUSH2IRIS] Installing module in worker container..
ERROR: Directory 'dependencies/' is not installable. Neither 'setup.py' nor 'pyproject.toml' found.
[notice] A new release of pip is available: 23.0.1 -> 23.2.1
[notice] To update, run: pip install --upgrade pip
[BUILDnPUSH2IRIS] Restarting worker container..
iriswebapp_worker
[BUILDnPUSH2IRIS] Copy module file to app container..
"docker cp" requires exactly 2 arguments.
See 'docker cp --help'.
Usage:  docker cp [OPTIONS] CONTAINER:SRC_PATH DEST_PATH|-
docker cp [OPTIONS] SRC_PATH|- CONTAINER:DEST_PATH
Copy files/folders between a container and the local filesystem
[BUILDnPUSH2IRIS] Installing module in app container..
ERROR: Directory 'dependencies/' is not installable. Neither 'setup.py' nor 'pyproject.toml' found.
[notice] A new release of pip is available: 23.0.1 -> 23.2.1
[notice] To update, run: pip install --upgrade pip
[BUILDnPUSH2IRIS] Restarting app container..
iriswebapp_app
[BUILDnPUSH2IRIS] Completed!

Same problem on Debian 12

dear tkolaski, how do you fix the above

If you use this ommand docker exec -it iriswebapp_worker /bin/sh and issue the command pip install --upgrade pip that will solve the pip issue. I'm struggling as to what the ./.dist  directory is and what files it should contain. It needs the setup.py file and the pyproject.toml but other than that IDK

thank you for your help , the integration done successfully ,  but i can not searching task , I had the following error  in Dim Task:
Task ID:
97cb0817-a10c-4a36-b773-303e29ed64c5
Task finished on:
2024-03-15 00:59:52.192154
Module name:
iris_wazuhindexer_module
Hook name:
on_manual_trigger_ioc
User:
administrator
Case ID:
1
Success:
Failure
Logs
Traceback (most recent call last): File "/iriswebapp/app/iris_engine/module_handler/module_handler.py", line 478, in task_hook_wrapper task_status = mod_inst.hooks_handler(hook_name, hook_ui_name, data=_obj) File "/opt/venv/lib/python3.9/site-packages/iris_wazuhindexer_module/IrisWazuhindexerInterface.py", line 95, in hooks_handler case = CaseDetailsSchema().dump(data) File "/opt/venv/lib/python3.9/site-packages/marshmallow/schema.py", line 549, in dump result = self._serialize(processed_obj, many=many) File "/opt/venv/lib/python3.9/site-packages/marshmallow/schema.py", line 517, in _serialize value = field_obj.serialize(attr_name, obj, accessor=self.get_attribute) File "/opt/venv/lib/python3.9/site-packages/marshmallow/fields.py", line 340, in serialize return self._serialize(value, attr, obj, **kwargs) File "/opt/venv/lib/python3.9/site-packages/marshmallow/fields.py", line 1981, in _serialize return self._serialize_method(obj) File "/iriswebapp/app/schema/marshables.py", line 2255, in get_status_name return CaseStatus(obj.status_id).name AttributeError: 'list' object has no attribute 'status_id'
could you help me to fix it


[Mobile] textselection bug ,

My issue is about [Mobile]
QuillEditor set readyonly:true
https://user-images.githubusercontent.com/7134823/207216870-35d73c82-b9c6-4b28-af5f-df9319912fa0.mp4
my solution : if (ignoreFocus || _keyboardVisible || widget.readOnly)

Please let me know if you still facing this issue or send a pull request to fix it so the others will get your changes as well
Thank you for the report, this issue has been open for a while and since there are no interactions with it, we had to close it
but if you still facing this issue, or other issues or you have any other questions, feel free to contact us anytime you want.


Use a ThumbnailCard for Teams

Fixes #10 by using a ThumbnailCard in place of a SigninCard.

version 0.2.12 in npm has this fix


When you use FlatList, if you update the data of FlatList, the head will reset.

Hi @yunuo-tech, sorry for the long response. You right it is a bug. But I have a good news, it's already fixed in the v1.5.2.
Can you test the new version?


[SPARK-40895][BUILD] Upgrade arrow to 10.0.0

What changes were proposed in this pull request?
This PR aims to upgrade Apache Arrow to 10.0.0
Why are the changes needed?

Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions

cc @sunchao

Is this released? I only found https://github.com/apache/arrow/tree/release-10.0.0-rc0 and their own tests don't run.

@bjornjorgensen has been released and is waiting for the official release notes

https://github.com/apache/arrow/releases/tag/apache-arrow-10.0.0

Thanks @dongjoon-hyun @itholic @bjornjorgensen


Http-probe metricsEnd enhancement

Currently metricsEnd does not emit the baseUrl and route, available from the request. This can be problematic if you're trying to identify a url that has path params. For example it would be nice to capture a route such as: /verify/email/:email. Where currently only the url is available which contains the passed in variable, so you get back<EMAIL_ADDRESS>I have an enhancement working on a fork currently and would be happy to submit a PR.

@kgriesh Please go ahead and submit a PR.  You will need to confirm you have read the contributing rules before we can accept it though https://github.com/RuntimeTools/appmetrics/blob/master/CONTRIBUTING.md

Just wondering, if this has been committed to master already?


Unable to add dns ip address

The ui when adding an IP address doesn’t allow to set the dots in an ip address

Thank you for reporting the issue. I'll fix it ASAP.

I plan to release to TestFlight first, and then to App Store, both in a few days.
If you want to join the beta testing, you can do from https://testflight.apple.com/join/A8GwCnq8.

DNSecure 1.0.2 is now available on the App Store.


Proposed fix for #5442 - command "unexpectedChangesets" always reports at least 1 unexpected changeset with initial tag in database

Impact

[x] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Issue #5442 outlines an odd behavior where the unexpected-changesets command shows the tag changeset as unexpected. If using the tag command itself, a changeset is not added to the changelog, but an internal Liquibase changeset will be added to the DBCL table. This would cause the unexpected-changesets to always show the internal Liquibase changeset as unexpected. Side note, the generate-changelog does not create the changeset in a changelog if it exists in the DBCL, so there isn't a way to make the tag expected.
This fix adds a function that is called first to determine if the file path is the liquibase-internal changeset. If it is, it removes it from the unexpected list.
Fixes #5442
Things to be aware of
I couldn't find a way to capture the file path for the ran changeset in the RanChangesSet.java file, so I did the same call that occurs in the isSameAs function (occurs in the isSamePath function technically), so it could be refactored to be more efficient.

Things to worry about
There isn't any additional tests associated with the change. I have found that there is a file unexpectedChangesets.test.groovy, but was unsure how to get the tag command to execute first. I would be happy to write test cases/modify the existing ones.

Additional Context

N/A

@Tylorjg would you mind looking at the regression issue @rberezen mentioned above?
Thanks,
Daniel.

Code changes look good to me, thank you for taking care of this regression issue @Tylorjg.
@rberezen would you mind trying again when you have a chance?
Thanks,
Daniel.


How to inherit colors from colorscheme?

Pretty much what the title says. I can't quite figure out how to do something like this:
local colors = {
		bg = colorscheme.bg,
		yellow = colorscheme.yellow,
		cyan = colorscheme.cyan,
                .... etc....
}

Is this (easily) doable? I'm a complete lua noob, so please bear with me ;-)
K

Can you explain in detail what you are going to do? colors is just a custom table variable to store some color values, which has nothing to do with galaxyline, which means you can define any color variable you want, just pass it to highlight.If you want to match your current color theme, you need to get the color code from your theme

Right! I looked a bit more into the details of my colorscheme, and of course things are a bit more complex than I would like :-D
I use base16 colorschemes and change them depending on time of day and mood in general.  The definition of colors here follows the scheme:
  let g:terminal_color_0 =  "#1d2021"
  let g:terminal_color_1 =  "#d72638"
  let g:terminal_color_2 =  "#88b92d"
  let g:terminal_color_3 =  "#f19d1a"
  let g:terminal_color_4 =  "#1e8bac"
  let g:terminal_color_5 =  "#be4264"
  let g:terminal_color_6 =  "#1ba595"
  let g:terminal_color_7 =  "#d5d5d5"
  let g:terminal_color_8 =  "#6f7579"
  let g:terminal_color_9 =  "#d72638"
  let g:terminal_color_10 = "#88b92d"
  let g:terminal_color_11 = "#f19d1a"
  let g:terminal_color_12 = "#1e8bac"
  let g:terminal_color_13 = "#be4264"
  let g:terminal_color_14 = "#1ba595"
  let g:terminal_color_15 = "#e5e5e5"
  let g:terminal_color_background = g:terminal_color_0
  let g:terminal_color_foreground = g:terminal_color_5
  if &background == "light"
    let g:terminal_color_background = g:terminal_color_7
    let g:terminal_color_foreground = g:terminal_color_2
  endif

So, basically, what I would like to do is to access programmatically the g:terminal_color_* variables from my galaxylineconf.lua to set the color scheme. Maybe something like this:
local colors = {
    bg = g:terminal_color_0,
    fg = g:terminal_color_5,
   ...etc...
}

Not quite sure how to do that in lua, but seems like it should be possible?

you need use vim.g.terminal_color_xxx

Thanks!!!


[incubator/vault] Fix serviceAccount reference and resource limits

What this PR does / why we need it:

Add a reference to serviceAccountName in the deployment for when serviceAccountName.create is set to true, otherwise the deployment will use the default service account.

Move the resources block above the extraContainers block so that it applies to the Vault deployment even when an extraContainer is defined. Currently, if an extraContainer is defined the resource block gets applied to that container and not the Vault container.

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @unguiculus

/assign @jpds

bump? Could someone please give this an /ok-to-test if the changes look alright?

/ok-to-test

/assign @maorfr

Seems that serviceAccount.name is missing from README. Maybe its a good time to add it. wdyt?

/retest

Seems that serviceAccount.name is missing from README. Maybe its a good time to add it. wdyt?

Good idea! Updated!

/lgtm


Video Conference Mute, Cannot set Camera Overlay Image

Microsoft PowerToys version
0.57.2
Running as admin

[X] Yes

Area(s) with issue?
Video Conference Mute
Steps to reproduce
Video Conference Mute > Camera > Camera Overlay Image > Browse
✔ Expected Behavior
Can set a overlay image by clicking browse button
❌ Actual Behavior
Nothing happens when pressing browse button to set overlay image
Other Software
No response

/dup #13215


Minor: Begin porting some window tests to sqllogictests

Which issue does this PR close?
Part of https://github.com/apache/arrow-datafusion/issues/4495
Rationale for this change
While reviewing https://github.com/apache/arrow-datafusion/pull/5171 I realized that many of the tests are still written directly in rust, which is not bad but figured I would start porting them to sqllogictests so we can avoid adding to the porting work
I think sqllogictests are easier to write (less boilerplate setup) and maintain (no rust recompilation to update output files). This is also the first sqllogictest I know of that has expain plans, which is exciting
What changes are included in this PR?
Port the first few tests from window.rs to sqllogictests
Are these changes tested?
Yes, they are all tests
Are there any user-facing changes?
No

cc @mustafasrepo

There is something wrong with the plan diff comparison -- will review shortly

Thanks @alamb for this PR. LGTM!.


[Unique] Data annotation

Currently, it's possible to ensure field uniqueness like this:
protected override void OnModelCreating(ModelBuilder modelBuilder)
{
    modelBuilder.Entity<Model>()
        .HasIndex(m => m.Field)
        .IsUnique();
}

I'm not sure about other ways.
My proposition is to add [Unique] data annotation to simplify this process.

@midnightstarr There has been a suggestion for an Index attribute in the past. I think Unique would be part of that. So closing as a dupe of #4050.


Qualify @inline to work with -Yno-imports.

Also, use -Yno-imports in the tests to ensure this doesn’t regress.
At SlamData we use -Yno-imports everywhere, and I have to explicitly import scala.inline anywhere we define a @typeclass, even though we don’t reference @inline.

Awesome, thanks. Want me to publish a release with this fix now?

Well, I wouldn’t complain 😄


162161084 fix windows symlink

Note: This will break the BOSH Agent as it requires BOSH Utils changes. There is a pull request to update the BOSH Utils with this PR: https://github.com/cloudfoundry/bosh-utils/pull/52

I forgot to mention that this commit does not include the go dep changes to pull in the BOSH Util code. Will that be taken care of automatically or should I update the pull request to include the dep changes?


fix: remove empty lines from docker-compose.varnish-extras.yaml, fixes #24

The Issue

#24

How This PR Solves The Issue
Uses grep to remove empty lines.
Manual Testing Instructions
Automated Testing Overview

Related Issue Link(s)
Release/Deployment Notes

This PR does not affect the functionality of docker-compose.varnish-extras.yaml at all, it just makes it more presentable.
We have the same empty lines in the .ddev/.ddev-docker-compose-base.yaml and ~/.ddev/.router-compose.yaml files generated by DDEV, which doesn't matter because those files are not committed.
But it matters here because you are committing this file.

For reasons of evaluation precedence, IMO docker-compose.varnish_extras.yaml works better as a recommendation. I can't remember what the issue was. But that's the format I always recommend.

@rfay, are you referring to this recommendation ?

Yes, didn't realize it made it into the docs :)

Ah, this talk about _ and -, I didn't see that at first. Okay, let's rename it here.

Well, the tests are improved! Don't know if the result is improved :)

I leave the testing to the experts 🙂.
To be honest, I don't understand how this add-on works, even after reading README.md and Varnish docs.


Malformed x-b3-traceid Header

Do you want to request a feature or report a bug?

Bug

What did you do?
When enabling tracing with b3 propagation and gen128Bit the x-b3-traceid is not 32 digits long.

What did you expect to see?
X-B3-Traceid: 4b03a264f5ae470241e7619143ef228
What did you see instead?
X-B3-Traceid: 04b03a264f5ae470241e7619143ef228
Output of traefik version: (What version of Traefik are you using?)

/ # traefik version
Version:      2.0.5
Codename:     montdor
Go version:   go1.13.4
Built:        2019-11-14T18:11:01Z
OS/Arch:      linux/amd64

What is your environment & configuration (arguments, toml, provider, platform, ...)?
      --entryPoints.web.address=:8000
      --entryPoints.web.forwardedheaders.insecure=true
      --entryPoints.websecure.address=:8443
      --entryPoints.traefik.address=:9000
      --api.dashboard=true
      --api.insecure=true
      --accesslog
      --log
      --ping=true
      --providers.kubernetescrd
      --providers.kubernetescrd.labelselector=traffic-type=private
      --providers.kubernetesingress
      --providers.kubernetesingress.ingressclass=traefik2-private
      --log.level=DEBUG
      --tracing.jaeger=true
      --tracing.jaeger.samplingServerURL="http://jaeger-agent.tracing.svc.cluster.local:5778/sampling"
      --tracing.jaeger.localAgentHostPort=jaeger-agent.tracing.svc.cluster.local:6831
      --tracing.jaeger.samplingType=const
      --tracing.jaeger.samplingParam=1.0
      --tracing.jaeger.propagation=b3
      --tracing.jaeger.gen128Bit=true

I think its the same issue as in #4712

ping @jcchavezs

Hello,
It's an issue of https://github.com/jaegertracing/jaeger-client-go

@atze234 could you open an issue on https://github.com/jaegertracing/jaeger-client-go, thanks.

Yeah that is what I was about to say because in zipkin-go we make sure the lenght of the trace_ids: https://github.com/openzipkin/zipkin-go/blob/master/model/traceid_test.go#L24 and https://github.com/openzipkin/zipkin-go/blob/master/model/traceid_test.go#L56

https://github.com/jaegertracing/jaeger/issues/1657
https://github.com/jaegertracing/jaeger-client-go/issues/471

@jcchavezs the zipkin package in jaeger-client-go seems also contains a bug:
https://github.com/jaegertracing/jaeger-client-go/blob/a015c340eda344ef534e88cef4f2604c211f5810/zipkin/propagation.go#L62-L66

yeah that is probably true. I bet they will fix it now that you reported it.

Closed by #6079.


chore: replace zip-local with adm-zip

The zip-local package has dependencies with security vulnerabilities:

https://nvd.nist.gov/vuln/detail/CVE-2022-48285
https://nvd.nist.gov/vuln/detail/CVE-2021-43138

There is an open pull request on zip-local to fix this (https://github.com/Mostafa-Samir/zip-local/pull/18), but it's two weeks old and the maintainer has not reacted to it. Maybe it's easier to just use adm-zip instead, since it's already in the deps anyway.
I have tried to verify that it's still possible to build java functions, but my experience with Java in Lambda is nil, so I might have broken something.

thank you!


Add Pet Rock!

Pet Rock!

[x] I will not ping the Discord about this pull request.

Please provide the following information for your token.

Token Address: 8xMW6cphJYxLPPkLqytGoq5pPMTKy8NAeaAu73ndJSB9
Token Name: Pet Rock
Token Symbol: ROCK
Logo: https://i.imgur.com/wSWxoKo.png
Link to the official homepage of token: https://petrock.page

fails build not a valid json.


Fix: refer to general and special CG meetings

Action following multiple cases of uncertainty (cf. matrix), and looking ahead to the special topic meeting on this 2023-10-10. Can be reverted if decision turns out to keep panel meetings alive.

Decided to approve so to get something in quick/good enough.


Changes for allowing custom CA certs

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[ ] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

[ ] Each command and parameter has a meaningful description.
[ ] Each new command has a test.

(see Authoring Command Modules)

@bganapa,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Closing and taking over this PR. Will create a new PR once changes made.


[Plugin] OCaml toplevel running inside daemon

This PR adds a plugin using the ocamlnat toplevel library (which I've extracted from the OCaml main repo). This is ridiculously unsafe and hard to use properly for a variety of reasons, not least of which are

directories containing the .cmi files have to be manually loaded using #directory directives

These only take absolute paths (i.e. /path/to/mina/_build/default/src/lib/coda_plugins/examples/toplevel/.plugin_toplevel.eobjs/byte). I plan to fix this in the ocamlnat repo at some point.
No directories are loaded by default. dune-describe seems to give all of the relevant information, but it's an unstable representation in an undocumented format, and I haven't bothered to write a parser or loader using it yet.

there is no check that values exist in the executable before running a linked command

I plan to investigate whether this is possible to fix, and fix it if it is.
Running a command that refers to values that aren't present exits with an exception. This is easily fixed, which I plan to do.

every evaluation adds to memory use, as it loads a dynamic library that is never unloaded

This is mostly a necessity of implementation. It may be possible to do something here by detecting that the compiled code contains no functions/captured closures/etc. and free only those dynlibs, or to do something horrendous with finalisers. I have no intention of doing this any time soon.

the toplevel is missing some useful directives (#show_module/#show_type/etc.) that are present in the bytecode toplevel

I plan to add these to the ocamlnat repo.

the interaction happens on stdin/stdout, where logging is also happening

There are a few cleverer things we could do here, but it's not clear that this will ever get enough use to warrant fixing it.
See sample run below for how this manifests.

the Obj functions can be used to hotpatch functions in the executable (if they haven't been inlined)

This is super, super dangerous, but also very cool to play with.

the native toplevel is imported wholesale

It should be reasonably easy (if labourious) to library-ise it, but at present it believes that it is the toplevel, with all the error handling and exit conditions that entails

the async yeilding is a hack in the middle of the parse loop, using some lower-level Async thread management primitives.

This actually seems to work well, but a library-ised toplevel would make this safe and straightforward.

printing of values is touch-and-go, depending on whether the directories containing the declarations for the types it includes are loaded or not

To try this out (please, please not on a node you care about!),

install the ocamlnat package by pinning its github repo
build the plugin with dune build src/lib/coda_plugins/examples/toplevel/plugin_toplevel.cmxs
start the daemon with the plugin loaded rlwrap _build/default/src/app/cli/src/coda.exe daemon -seed -load-plugin _build/default/src/lib/coda_plugins/examples/toplevel/plugin_toplevel.cmxs

I recommend rlwrap here to make the toplevel's behaviour slightly less unbearable.

load the (bytecode) directories for the modules you want and start poking around in

#directory "/path/to/mina/_build/default/src/lib/coda_plugins/examples/toplevel/.plugin_toplevel.eobjs/byte";; is good to have, as it exposes a reference to the Coda_lib instance in Dune__exe__Plugin_toplevel.coda
#directory "/path/to/mina/_build/default/src/lib/coda_lib/.coda_lib.objs/byte";; loads Coda_lib, making the functions available to poke at the above reference
#directory "/path/to/.opam/4.07.1/lib/core_kernel";; (as well as async, async_kernel) are nice to have for quality of life in the toplevel.

Sample run:
$ rlwrap _build/default/src/app/cli/src/coda.exe daemon -seed -load-plugin _build/default/src/lib/coda_plugins/examples/toplevel/plugin_toplevel.cmxs
2020-11-28 18:19:44 UTC [Info] Coda daemon is booting up; built with commit "b5967c18d848fca003006bba95d9983b61575500" on branch "feature/toplevel-plugin"
...
(* SNIP *)
...
2020-11-28 18:19:45 UTC [Info] Coda daemon is connecting
2020-11-28 18:19:45 UTC [Info] Initializing plugins
2020-11-28 18:19:45 UTC [Info] Initializing plugin from $path
        path: "_build/default/src/lib/coda_plugins/examples/toplevel/plugin_toplevel.cmxs"
2020-11-28 18:19:45 UTC [Info] Hi from toplevel plugin!
        OCaml version 4.07.1 - native toplevel

2020-11-28 18:19:45 UTC [Info] Plugin successfully loaded from $path
        path: "_build/default/src/lib/coda_plugins/examples/toplevel/plugin_toplevel.cmxs"
2020-11-28 18:19:45 UTC [Info] Pausing block production while bootstrapping
2020-11-28 18:19:45 UTC [Info] Attempted to turn on snark worker, but snark worker key is set to none
2020-11-28 18:19:45 UTC [Info] Daemon ready. Clients can now connect
2020-11-28 18:19:45 UTC [Info] Created GraphQL server at: http://localhost:3085/graphql
#directory "/home/matthew/source_code/coda/_build/default/src/lib/coda_plugins/examples/toplevel/.plugin_toplevel.eobjs/byte";;
# #directory "/home/matthew/source_code/coda/_build/default/src/lib/coda_lib/.coda_lib.objs/byte";;
# #directory "/home/matthew/.opam/coda/lib/core_kernel";;
# #directory "/home/matthew/.opam/coda/lib/async_kernel";;
# #directory "/home/matthew/.opam/coda/lib/async";;
# open Core_kernel;;
# open Async;;
# let coda = Dune__exe__Plugin_toplevel.coda;;
val coda : Coda_lib.t = <abstr>
# Coda_lib.next_producer_timing coda;;
- : Consensus.Hooks.block_producer_timing option = None
# 2020-11-28 18:20:45 UTC [Info] Will start initialization without connecting with too any peers
2020-11-28 18:20:45 UTC [Info] Fast forward successful
2020-11-28 18:20:45 UTC [Info] Loaded full frontier and extensions
2020-11-28 18:20:45 UTC [Info] Successfully loaded frontier
2020-11-28 18:20:45 UTC [Info] Requesting peers for their best tip to do initialization
2020-11-28 18:20:45 UTC [Info] Successfully loaded frontier, but failed to download best tip from network; starting participation
2020-11-28 18:20:45 UTC [Info] Starting transition frontier controller phase
2020-11-28 18:20:45 UTC [Info] Coda daemon is connecting
2020-11-28 18:20:45 UTC [Info] Updating new available work took 0.00762939453125 ms
2020-11-28 18:20:45 UTC [Info] Determining next slot to produce block
2020-11-28 18:20:45 UTC [Info] No block producers running, skipping check for now.
Coda_lib.next_producer_timing coda;;
- : Consensus.Hooks.block_producer_timing option = Some <abstr>
# #directory "/home/matthew/source_code/coda/_build/default/src/lib/consensus/.consensus.objs/byte";;
# Coda_lib.next_producer_timing coda;;
- : Consensus.Hooks.block_producer_timing option =
Some (`Check_again <abstr>)
# let deferred_peers = Coda_lib.peers coda;;
val deferred_peers : Network_peer.Peer.t list Async_kernel.Deferred.t =
  <abstr>
# Thread_safe.block_on_async_exn (fun () -> deferred_peers);;
Error: The module Thread_safe is an alias for module Async_unix__.Thread_safe, which is missing
# #directory "/home/matthew/.opam/coda/lib/async_unix";;
# Async_unix.Thread_safe.block_on_async_exn (fun () -> deferred_peers);;
- : Network_peer.Peer.t list = []
# #directory "/home/matthew/source_code/coda/_build/default/src/lib/network_pool/.network_pool.objs/byte";;
# let txn_pool = Coda_lib.transaction_pool coda;;
val txn_pool : Network_pool.Transaction_pool.t = <abstr>
# 2020-11-28 18:24:00 UTC [Info] Determining next slot to produce block
2020-11-28 18:24:00 UTC [Info] No block producers running, skipping check for now.
# Network_pool.Transaction_pool.get_all;;
Error: Unbound value Network_pool.Transaction_pool.get_all
# module Txn_pool = struct include Network_pool.Transaction_pool end;;
module Txn_pool :
  sig
...
(* SNIP: This is a cheat I used to check the signature of Transaction_pool. Large signature elided. *)
...
    val resource_pool : t -> Resource_pool.t
    val broadcasts : t -> Diff_versioned.t Pipe_lib.Linear_pipe.Reader.t
    val apply_and_broadcast :
      t ->
      Diff_versioned.verified Network_peer.Envelope.Incoming.t ->
      Broadcast_callback.t -> unit Async_kernel.Deferred.t
  end
# Network_pool.Transaction_pool.(Resource_pool.get_all (resource_pool txn_pool));;
- : Coda_base.Transaction_hash.User_command_with_valid_signature.t list = []
# Obj.reachable_words (Obj.repr txn_pool);;
- : int = 170174
# exit 0
  ;;
2020-11-28 18:28:38 UTC [Info] Running async shutdown handler: "Close transition frontier, if exists"
2020-11-28 18:28:38 UTC [Info] Running async shutdown handler: "Remove daemon lockfile"
- : 'a Async_unix__.Import.Deferred.t = <abstr>

Checklist:

[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them:

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me


Match another CSV error about line endings

(The test didn't fail on Travis, but it certainly failed locally until the next commit was made.)

Coverage remained the same at 95.91% when pulling f7738f3ef9cec9cd7d0a2873d9531ea6c9a5d765 on jpmckinney:errors into 08ab3af84a892ab3eed054d8f60da1926e5ec67f on theodi:master.

Coverage remained the same at 95.91% when pulling f7738f3ef9cec9cd7d0a2873d9531ea6c9a5d765 on jpmckinney:errors into 08ab3af84a892ab3eed054d8f60da1926e5ec67f on theodi:master.

Coverage remained the same at 95.91% when pulling 1d3fd4b0486141f8d824db4de314ec49e6947d79 on jpmckinney:errors into 08ab3af84a892ab3eed054d8f60da1926e5ec67f on theodi:master.

Coverage remained the same at 95.91% when pulling 1d3fd4b0486141f8d824db4de314ec49e6947d79 on jpmckinney:errors into 08ab3af84a892ab3eed054d8f60da1926e5ec67f on theodi:master.

Coverage remained the same at 95.91% when pulling 1d3fd4b0486141f8d824db4de314ec49e6947d79 on jpmckinney:errors into 08ab3af84a892ab3eed054d8f60da1926e5ec67f on theodi:master.

Cool, thanks for these fixes so far! :+1:


Improve and extend the ppm encoder to all pnm formats

Attached pull request #730  provides a new implementation for a pnm encoder. It is able to write all image formats (pbm, pgm, ppm, pam), encoding images with sample type u8.
The file format can be chosen by the user or automatically decided. Alternatively, a complete header can be provided as well to further restrict the output format. Decoded headers should be able to fully roundtrip, preserving comments and formatting. Inserting additional comments into headers is not in scope for this pull request.
This encoder could fully replace the old encoder found in ppm::encoder. The rewrite improves diagnostics for several cases, such as avoid some panics with additional error checking.
Changes

u16 is now handled correctly, encoded in big endiean and can now be input as &[u16].
Image data, color and header format are checked for compatibility
The default format is now pnm whose header is more readable, with binary data.
More color types. A pnm header with custom color can be used to write any color type, with the correct number of channels, while those specified in the standard are automatically detected.
The ascii writer now follows the suggestion of writing a maximum of 70 character per line

Not included

Decoded headers should be able to fully roundtrip, preserving comments and formatting. This and inserting additional comments into headers is not in scope for this pull request.

Adapted to the recent changes concerning ImageOutputFormat, the subtype is now exposed over the new interface and defaults to selecting pam.


Hello , can you tell me how to use with remote sensing

hello , Im very interesting in your tool and this can solve my issue in hyperspectral image classification.The dataset is IndianPines and Salinas,but I dont know how to use in this dataset because your example is random data.Can you give me a example in IndianPines dataset,thank you very much.

I'll update the README and docs to include an example using one of those datasets in the next release. For now, here's an example using the IndianPines dataset downloaded from here.
import numpy as np
from skimage import io
import matplotlib.pyplot as plt

from skhyper.process import Process
from skhyper.cluster import KMeans
from skhyper.svm import SVC

# Reading in the data from Site3 in the IndianPines dataset
im = io.imread('19920612_AVIRIS_IndianPine_Site3.tif')

The data for scikit-hyper needs to be in the form [x, y, (z), spectra] so:
im_transpose = np.transpose(im)
X = Process(im_transpose, scale=True)

# Clustering using k-means
mdl_kmeans = KMeans(n_clusters=5)
mdl_kmeans.fit(X)

For classification, you'll need the ground truth labels. For simplicity, I'll just use one of the tif files in the dataset from the link above:
im_label = io.imread('19920612_AVIRIS_IndianPine_Site3_gr.tif')

# Using support vector machines for classification
mdl_svc = SVC()
mdl_svc.fit(X, im_label)

To classify new data from the trained model above, you use the normal methods from scikit-learn, i.e. predict, predict_proba or predict_log_proba. I'll just use a random dataset here for the new dataset for now (and amend for a proper example later):
# Random dataset with the same dimensions as the one used to train the model
x_random = np.random.rand(145, 145, 220)

x_classified = mdl_svc.predict(x_random)

Hopefully that helps. As mentioned, I'll put a thorough example in the next update.

If you do have any suggestions or need help let me know, but please note that some features are subject to changes which won't be backward compatabile (at least until version 0.1 is released).

I'm closing this now, if you have any further issues please feel free to open it again.


[BUG] Success redirect from social login leads to 404

Describe the bug
Trying to integrated Next.JS project with hosted login box.
Using code from https://github.com/frontegg/frontegg-nextjs/tree/master/apps.
After Google sign - all good - redirected back to http://localhost:3000/account/social/success?state=fdssdf....
Then 404 error received.
Checked FronteggRouter.tsx - and only found login/logout routes (@frontegg/nextjs not handling this route).
To Reproduce

Use https://github.com/frontegg/frontegg-nextjs/tree/master/apps/example or follow Next.js integration docs.
Sign in with google.
Success. Redirect leads you back to localhost:3000 but nothing happens.

Expected behavior
Data from redirect processed to auth session.

Hey @rost-rem !
The frontegg/nextjs package is handling all the types of logins that we support and I couldn't reproduce the issue that you describe. Could you please provide your email address and we will continue investigating together over an email?

My mistake.
Social Login must be redirected to "[your-domain].frontegg.com/oauth" and not to localhost:3000
Everything is working now.
Thank you @MashaPav


[i2c,dv] Fix the incorrect assertions of sda_interference interrupt

[i2c,dv] Patches for the incorrect assertion of sda_interference and sda_unstable

Fix sda interference occurred in the address phase of read transaction
Fix sda not remain (unstable) during clock pulse

Signed-off-by: Tung Hoang<EMAIL_ADDRESS>

@weicaiyang @cindychip thanks for the review, can it be merged?


Feature/add user to org by username error

When you add a user by username to an org, ensure that a user exists with that name.

codecov is going crazy

Coverage decreased (-7.2%) to 69.775% when pulling 850086b8a22f9f70535e661c84f8b3d142f6fd4c on feature/addUserToOrgByUsernameError into 799a0e59c82add2f77460bfe1cce624f68093633 on develop.


Scala compiler in its own cloud function

It turns out we can just upload our own copy of the JRE, etc. and use the CLI
to build ScalaJS. This is somewhat faster than using SBT and addresses the SBT
lockfile issue. An issue with approach is that we need hardcode the name of the
main method (i.e., Runner.main). We could write a little hacky script to detect
it if we want.

This commit is already deployed and seems to be working correctly.


Font helper requires React types

We should make it agnostic, and make csstypes a dependency instead so that react is not required.
https://github.com/onfido/castor/blob/main/packages/core/src/helpers/font/font.ts#L2

Looks like it is only defined as string | number: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts#L1542

You're right, we could even skip csstypes altogether and just roll our own types.


Update SameSite and Secure attributes for session and CSRF cookies

Docs: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#samesitesamesite-value


Crash when closing Options

Brief description of your issue
When showing the settings window and closing it on the close button, an error occurs.
Steps to reproduce (optional)
Show main windows of System Informar.
Click on Options.
I move from the first option to the last one using the down key
Click on Close button.
Expected behavior (optional)
The options window should close and return to the main window.
Actual behavior (optional)
The application crash and show this window:

Environment (optional)
System Informer 3.0.7029 (f647fb0)
Windows 11 Enterprise 22H2 Build 22621.2134
AMD Ryzen 5 4600H with Radeon Graphics

I made a Fulldump, if you need it I'll upload it.

Probably is inside the device notification options. I'll correct this shortly.

Should be fixed with https://github.com/winsiderss/systeminformer/commit/d137ee88b70912855cd9e400a9d9601b83eda979 in the next build

Solved in Version: 3.0.7039 (1dc68ca)


fix #4 and also spoiler text size

Fix for #4 as described in the issue.
Also added md-container to <body> so that a selector matches and changes the font size properly.

Thanks again!


bcbio 1.1.0 dev installation error: conda: error: unrecognized arguments: --only-deps

Hi,
I am trying to install the latest 1.1.0 development version of bcbio.
python bcbio_nextgen_install.py --tooldir=/home/my_user/workspace/tmp_bcbio_1.1.0_development/tool_dir --aligners bwa --aligners star --nodata --isolate -u stable --distribution centos /home/my_user/workspace/tmp_bcbio_1.1.0_development/data_dir
I run into this conda error:
conda                     4.5.4                    py27_0    https://repo.anaconda.com/pkgs/main
usage: conda [-h] [-V] command ...
conda: error: unrecognized arguments: --only-deps
Traceback (most recent call last):
  File "bcbio_nextgen_install.py", line 266, in <module>
    main(parser.parse_args(), sys.argv[1:])
  File "bcbio_nextgen_install.py", line 38, in main
    bcbio = install_conda_pkgs(anaconda, args)
  File "bcbio_nextgen_install.py", line 83, in install_conda_pkgs
    "-c", "conda-forge", "-c", "bioconda", "--only-deps", "bcbio-nextgen"], env=env)
  File "/tools/general/app/anaconda-python-2.7/lib/python2.7/subprocess.py", line 186, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/home/my_user/workspace/tmp_bcbio_1.1.0_development/data_dir/anaconda/bin/conda', 'install', '--yes', '-c', 'conda-forge', '-c', 'bioconda', '--only-deps', 'bcbio-nextgen']' returned non-zero exit status 2

Do you have any advice on how to fix this.
For this installation attempt I set the $PYTHONPATH and $PATH variables to and older bcbio installation:
echo $PYTHONPATH
/data/prod/Tools/bcbio/1.0.4/anaconda/lib/python2.7/site-packages/:/tools/general/app/anaconda-python-2.7/lib

echo $PATH
/tools/bioinfo/app/bcbio-1.0.4/bin: ................................

If I don't set the these PATHS the installation continues much further before crashing on:
Traceback (most recent call last):
  File "/home/my_user/.local/lib/python2.7/site-packages/fabric/network.py", line 24, in <module>
    import paramiko as ssh
  File "/home/my_user/.local/lib/python2.7/site-packages/paramiko/__init__.py", line 30, in <module>
    from paramiko.transport import SecurityOptions, Transport
  File "/home/my_user/.local/lib/python2.7/site-packages/paramiko/transport.py", line 49, in <module>
    from paramiko.dsskey import DSSKey
  File "/home/my_user/.local/lib/python2.7/site-packages/paramiko/dsskey.py", line 26, in <module>
    from Crypto.PublicKey import DSA
  File "/home/my_user/.local/lib/python2.7/site-packages/Crypto/PublicKey/DSA.py", line 89, in <module>
    from Crypto import Random
  File "/home/my_user/.local/lib/python2.7/site-packages/Crypto/Random/__init__.py", line 29, in <module>
    from Crypto.Random import _UserFriendlyRNG
  File "/home/my_user/.local/lib/python2.7/site-packages/Crypto/Random/_UserFriendlyRNG.py", line 38, in <module>
    from Crypto.Random.Fortuna import FortunaAccumulator
  File "/home/my_user/.local/lib/python2.7/site-packages/Crypto/Random/Fortuna/FortunaAccumulator.py", line 39, in <module>
    import FortunaGenerator
  File "/home/my_user/.local/lib/python2.7/site-packages/Crypto/Random/Fortuna/FortunaGenerator.py", line 36, in <module>
    from Crypto.Cipher import AES
  File "/home/my_user/.local/lib/python2.7/site-packages/Crypto/Cipher/AES.py", line 50, in <module>
    from Crypto.Cipher import _AES
ImportError: /home/my_user/.local/lib/python2.7/site-packages/Crypto/Cipher/_AES.so: undefined symbol: rpl_malloc

There was a problem importing our SSH library (see traceback above).
Please make sure all dependencies are installed and importable.
Traceback (most recent call last):
  File "bcbio_nextgen_install.py", line 266, in <module>
    main(parser.parse_args(), sys.argv[1:])
  File "bcbio_nextgen_install.py", line 44, in main
    subprocess.check_call([bcbio, "upgrade"] + _clean_args(sys_argv, args))
  File "/tools/general/app/anaconda-python-2.7/lib/python2.7/subprocess.py", line 186, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/home/my_user/workspace/tmp_bcbio_1.1.0_development/data_dir/anaconda/bin/bcbio_nextgen.py', 'upgrade', '--tooldir=/home/my_user/workspace/tmp_bcbio_1.1.0_development/tool_dir', '--aligners', 'bwa', '--aligners', 'star', '--isolate', '-u', 'stable', '--distribution', 'centos']' returned non-zero exit status 1

This error I used to solve via setting the PATH and PYTHONPATH to and older bcbio version. But this not does not work anymore since I get the first error in this ticket.
Advice on how to fix this second error would also be useful. Thank you.

Thanks for the detailed report and apologies about the issue. For the main bcbio install issue, I'm not entirely sure what is happening but it looks like we're somehow getting conda environments crossed up. The traceback looks like you have a recent version which should support the --only-deps argument. You can check by looking at:
/home/my_user/workspace/tmp_bcbio_1.1.0_development/data_dir/anaconda/bin/conda install -h

From your description I'd guess that setting the PYTHONPATH and PATH cause injection of the older conda so that gets picked up instead of the one we should be using.
The second error you're seeing is due to an incompatible crypto library in your '~/.local` directory, which gets automatically inserted into your PYTHONPATH.
So both issues are due to incompatible cross talk. My suggestion to fix would be to remove the '~/.local` directory and do not set PATH and PYTHONPATH. Hopefully this will keep the new install isolated and work properly so you can get running. Please let us know if this doesn't fix the problem.

Thank you for the quick answer. Removing the locally installed  python2.7/site-packages/Crypto package fixed the issue.


label color

i wanna colorize saturday and sunday days in a linechart
please add color support for some labels

This was done in the v3 dev work by introducing scriptable font options. You can specify a function that returns a different font color for ticks that are on the weekend


Enables REST APIs and authentication options

Ifdevs doesn't make the code that readable, but it it's at least runnable.

This PR is out of date. Will close rather than keep it open.

I will do a rebase  when the .NET6 branch is merged.


Support tilde in save, load and open

#117
Needs test?

Ahhhhh, yeah, it should probably have a test. I can't figure out how to write one though. Any ideas?

Since we can use open to print out the path (by setting the open command to echo), we can set $HOME to . and just expect that the printed path contains that prefix

That would work for open, but not for save and load. Why don't we set $HOME
to the path to the tempdir, and then assert that it saved to a file in the
tempdir, loaded from the same file, etc?

That would work for open, but not for save and load. Why don't we set $HOME
to the path to the tempdir, and then assert that it saved to a file in the
tempdir, loaded from the same file, etc?

Yeah we could do that, I just assumed testing one would suffice since they're all calling the same method

Yeah, good point. I would say we should test with all of them, since we could easily forget to do tilde expansion for any of them.

Reviewing the code, I think that there's probably a better way to solve this problem than to expand tilde ourselves.
The whole reason I wanted this in the first place was to be able to write: save:~/foo.png which doesn't work, because the shell won't expand ~ unless it's the first character in a word.
I'm thinking that instead we should actually improve parsing so that you can write:
save: ~/foo.png

This would allow the shell to expand the tilde, instead of us.
The downsides of doing it ourselves:

New dependency
For every command that takes a path, we need to remember to shell expand, and if we don't, we'll have the bug that ~ doesn't get expanded for that particular command
The shellexpand library might implement slightly different semantics from the user's shell
We can no longer take non-unicode paths

I actually think this would be pretty easy, we just need to do a preprocessing step on the command line where we group arguments by : and then parse commands from that grouping.
What do you think?


Contributors section

Kindly Check if this needs any more changes @PritamSarbajna
https://user-images.githubusercontent.com/65062036/186525151-92cfa2ef-1ac5-452a-8b88-790a9c19a6f6.mp4

Yes @PritamSarbajna I haven't touched anything else except the Contributions section HTML and CSS code.

Oh sorry I didn't saw the changed section, I need to look where it is messing up

Oh sorry I didn't saw the changed section, I need to look where it is messing up

Yeah @prakhartiwari2507 just change that and make the contributors section's bg as black (#000)

Oh sorry I didn't saw the changed section, I need to look where it is messing up

Yeah @prakhartiwari2507 just change that and make the contributors section's bg as black (#000)

Hey @PritamSarbajna Kindly check now if everything is fine.

Yes @PritamSarbajna you create it according to the needs of this website.


Add search result highlighting

@lon-io Sorry sir but I'll have to decline this PR. The cost of implementing this seems to be bigger than the gain from it. I've added a simple fix for now, at least until I can find a better approach.
Thanks for the effort though! Much appreciated. 😊


Pin all package versions

Closes #2040

[Current coverage][cc-pull] is 91.29%

Merging [#2064][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master      #2064   diff @@
==========================================
  Files            93         93
  Lines          6537       6537
  Methods        1169       1169
  Messages          0          0
  Branches       1370       1370
==========================================
  Hits           5968       5968
  Misses          569        569
  Partials          0          0

Powered by Codecov. Last updated by [b2a5092...26015b9][cc-compare]
[cc-base-branch]: https://codecov.io/gh/ParsePlatform/parse-server/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/ParsePlatform/parse-server/compare/b2a509262767dd2c56e41c10ec7edf57bacdfd85...26015b9c1f48b7f1786dbd1998d1867771f815e0
[cc-pull]: https://codecov.io/gh/ParsePlatform/parse-server/pull/2064?src=pr

Replaced by #2073


Add OpenSheetMusicDisplay to Library List

Adding OSMD to software library list.

Thanks! (I had to fix the spelling of TypeScript. It irks me more than it should when the s is lowercase 🙈)