Adopt OWNERship policy consistent with other CNCF projects

OWNERS slows code cleanups
OWNERS adds constraints beyond what we're used to internally
OWNERS complicates code reverts
OWNERS is not compatible with taking a vacation
Github CODEOWNERS is an anti-pattern, the worst possible model for ownership, and not used by any CNCF-graduated projects (or by grpc/grpc-java or grpc/grpc-go)
OWNERS gotta get guillotined

I asked for rational arguments; appeals to recent history are not that.

BTW, the discussion that @markdroth cites in his comment refers to #16534 and its comment section.

I know that github's implementation of CODEOWNERS has some (relatively serious) flaws, but I still think there are some directories that are worth protecting (e.g. some of the test infrastructure directories tend to get modified in broken ways unless there's some oversight).
Perhaps the best next move on our side to be actually put together the complaints around complaints of CODEOWNERS implementation, make sure they are files as issues for github.com and try to convince github to fix them.

the biggest issue from my perspective is  that if I'm already an owner for a subdirectory, I should only need an approval from any other contributor (as opposed to needing another OWNER's approval).

The existence of CODEOWNERS is incompatible with healthy development practices like vacations. Right now we have at least one PR (#17932) that is blocked because the owner who did a review and wrote the words LGTM without clicking the green approval button went on vacation.

CODEOWNERS is a self-inflicted wound. It is perhaps unique among obstacles by delaying both development velocity and revert velocity.

@jtattermusch So right now we're protecting some test infrastructure directories, but we're not protecting the actual unit tests or end2end tests at all. There is nothing in our current setup that would prevent a committer from deleting all of test/core and test/cpp, for example. We're relying on the fact that members of the org are vetted and that reverts are possible (and encouraged) when things go awry. The existence of OWNERS hasn't prevented build and test infrastructure from breaking from time to time. It's just delayed reverts when we realize that things are broken.

#17932 is a good example of why OWNERship makes no sense. It is an overly blunt instrument. Even if you concede that a particular directory should be owned by those who understand its logic (a point that I do not concede), that particular PR had no impact on the logic of the directory. It was a pure code cleanup, yet nevertheless had to go through ownership. The rational basis for the review would have been based on knowledge of concurrency, not knowledge of core logic. But of course, OWNERship complicated both its approval and its unrelated revert.

kubernetes/kubernetes has their own notion of OWNERS. They do not use Github CODEOWNERS. Rather, they use their own bot that assigns 2 reviewers from the OWNER list (even if there are 20 named owners). Once any reviewer has given it an LGTM, the bot assigns an approver from the OWNER list -- unless the PR was created by an approver, in which case it is already approved. The kubernetes policy is still not what I'd ideally seek, but it much better than the default Github CODEOWNERS.

Counterargument to my note above about other CNCF projects. "If all your friends jumped off a bridge, would you do it too?" Response: Unfortunately, grpc/grpc is the bridge jumper in this scenario. We jumped into the Github CODEOWNERS lake even though it was still not really ready for prime time. The other projects were the wiser heads here.

A subscriber suggested that I attach the following:

I believe this is now resolved?


Drop SafeRefCount in favor of C++11 atomics

Primitive variables being treated as atomics are also promoted to std::atomic<T>.
atomic_conditional_increment and atomic_exchange_if_greater still exist since they are useful,
but are also meant to be used on C++11 atomics.
CowData specifics:

There's an static_assert near the top, ensuring that the memory layout of a std::atomic<uint32_t>
is just the uint32_t itself, or that at least it doesn't require more memory than it.
On the other hand, the standard guarantees that integer atomics are trivially copyable so it's OK
to use raw memory functions on them (and reinterpret_cast), just as if it were a plain uint32_t.
Anyway, when initializing the refcount it's made explicit that the intent is that they are
atomic integers, even though the resulting machine code would be the same.
Removed misleading parameter from _unref.

Fixes #31860.
@akien-mga, I'm letting you set the milestone. Probably this is OK for 3.2 (I think none of the removed items were exposed to scripting of GDNative, but I'm not sure). Otherwise, or just for some safety, this should be for 4.0.

Out of curiosity, does this have performance benefits?

I don't think so. Unless the old code was invoking some lock-based implementation on some platform or something, but doesn't look like it.

Given the timing, I'd opt for cautiousness and target this for 4.0. I really want to get 3.2 released ASAP :)
Moreover I think these changes may partly conflict with changes done in the vulkan branch by @reduz, so merging them for 3.2 would make rebasing vulkan trickier.
That being said, if @hpvb or @reduz want these changes done for 3.2, I'm not against it.

I've tried changing the base branch to vulkan, but the CI still believes this is unmergeable, so I'm closing this and will open a new one directly with the new base.


.onion mint address causes network error

Hi,
I've tested Cashu mint over LNBits, all networking over tor, and I tried to connect to mint using minibits under orbot.
Result is "network error"; I've tried other implementations of Cashu web wallets and my mint works fine, so I think it's only an app rejection of .onion mint address.
Could you please integrate a tor daemon?
It could improve privacy and add the feature of reaching .onion mint address, unlocking much more user base through home-made nodes that implement LNBits and Cashu.
Thanks in advance.

I'll put it on the roadmap and do a POC with react-native-tor. I need to check whether cashu-ts library I am using won't brake as it handles mint networking.

Many thanks for reply. I'll wait for updates

Related cashu-ts issue: #https://github.com/cashubtc/cashu-ts/issues/92

thanks for opening the issue on cashu-ts!

@Ciugam may I ask you to send me an onion URI to your mint so that I could make a quick connection test? I have a Tor POC ready on separate code branch.

Of course! But I don't see any mail, could you give me one?

You can send it to mail at minibits.cash. Thanks!

Sorry, I visited the site minibits.cash and I couldn't find any mail.
Anyway, I'll leave here the URI, I've created a mint 'ad hoc' for your test.
http://myrhc3enlghx35lvxa4goz3qm2nho4e56tkeh7dfvc3npzbk3dzoszid.onion/cashu/api/v1/6CVAiR5JbC3pKhaH4FdSFX
When you've finished, I'll delete the instance.
Apologize for misunderstand.

Let me know when you finish the test.
Thank you for all

Done. After a lot of pain to build the app with react-native-tor and to fork and customize cashu-ts the POC result is much .... better then expected - it just worked on first try :)
This is a POC only implementation, it will take me some time to release it - I need to implement quite a lot of plumbing yet:

user setting to turn on/of Tor support so that the daemon does not load if not necessary
refactor the daemon initialization
solve some Typescript errors in the tor request helper
prepare proper pull request for cashu-ts and ideally get it reviewed, merged and released as I'd like to avoid to maintain my fork
should add long pending feature to rename the mint (onions are particularly ugly)
test and test again - I had to update many android native settings to make it work and need to be sure something did not break

Over the long term, tor library seems not to be well maintained, so there is a risk that it won't support later Android versions if nobody starts to work on it again. But so far so good.
If you would have some time later to help with early testing, please submit your email on https://www.minibits.cash, I'll add you to the closed testing program and you would get access to early release.

Done, I've submitted to early access, glad to help trying this new feature.
Again, thanks for support, very appreciated.
Could I delete the mint URI now? If you need more time, I can leave it there :)

You can delete it now, thanks for quick help!
I'll post to this issue once the production release will be ready to test - then we might need some mint again :)

@minibits-cash I'm not an expert, so I ask your opinion:
If the react native tor has this issue and could become "abandoned", might be useful put minibits app over a tor-vpn app, like orbot or inviziblepro? These are up-to-date and created for this purpose

Hi @minibits-cash, thanks for mention about update, glad to help.
I've updated to latest version, and I try to connect again with LNbits 0.11 with Cashu 0.3.2 latest update.
With tor-integrated on, I scan QR code of mint and it says:
CONNECTION_ERROR
Could not connect to the selected mint.
"[\"CLEARTEXT communication to abc....xyz.onion not pe

What does it mean?
Also, to be sure that it's not a single phone related issue, I've tested 3 different smartphones: unfortunately, same result for all.

Thanks, compared to the POC something somewhere changed. I'll need finally to setup a testing mint behind tor to investigate.

After quick search it seems that the app needs additional configuration to allow cleartext http traffic.
Will play with that tonight. That was unfortunately not enforced nor warned by android when running in dev mode.
Fix will be a new .apk version, until then likely only tor services with https might work.

Thank you, I'll wait new app version then.
Unfortunately I can't modify from http to https on my LNBits...

Please install new release https://github.com/minibits-cash/minibits_wallet/releases/tag/v0.1.3-tor.2-beta with cleartext traffic allowed and test with your mint. Thank you very much!

Your work is awesome! Now it works!
Glad to help, and thank you for the quick fix.
In the next days I'll try this Cashu seriously.
Last thing: I've noticed that every time I open the app, in the "tor status" section there is "NOTINT". After pressing it checks green as "DONE". Do I have to do it every time I enter in the app?
And, for instance, could I use in the future a backed orbot instead of tor daemon? I ask this for more interoperabiliy and also because, as you said (I think), tor daemon in the long time could be "deprecated"; using a orbot proxy maybe could give more certainty in the future...
Many thanks in advance

Glad it works! You do not need to tap the Tor setting every time - if the daemon is not yet running, it will start on first request automatically, it will just take longer time. Only needed thing is to have the Tor user setting turned on.
If the functionality will be stable, I will keep it for now and try to integrate it into the Google Play version in future release - for now it's available only in the .apk version and I need then to maintain 2 branches of code in sync.
I will look on other options in case there would be problems to release it on Google Play.

Tor daemon is finally available in Google Play release of the Minibits wallet.


[fix][offload]fix get error ledgerhandle when ledger trim

relate issue: https://github.com/apache/pulsar/issues/21737
Motivation
fix get error ledgerhandle when ledger trimed case NoSuchLedgerExitsException
Modifications
cursor position at trimming-ledger which to be deleted from Bookkeeper.After the ledger deleted due to archive the ManagedLedgerOffloadDeletionLagInMillis,
readentries should use new readhanle implement by OFFLOADreadhandle, in current implementation, get readhandle generate from Bookkeeper, use it to would cause read will cause NoSuchLedgerException.
Regarding the addition of ledgers to offloadedLedgersToDelete, there are two scenarios to consider:

BOOKKEEPER_FIRST:
If a ledger is currently being read from, it should not be added to offloadedLedgersToDelete during the current trim process to prevent read exceptions from BookKeeper. If the ledger is not being read from, the readHandle from BookKeeper should be invalidated. Subsequent reads of this ledger will then reacquire the readHandle from tiered storage.

TIERED_STORAGE_FIRST:
If isOffloadedNeedsDelete is set to true, continue adding to offloadedLedgersToDelete because the current reading method utilizes tiered storage. Deleting a ledger from BookKeeper will not impact the ongoing process. After the ledger is deleted from BookKeeper, it is unnecessary to invalidate the readHandle because if the current LedgerHandle in offloadedLedgersToDelete is reading data from tiered storage, invalidating the readHandle could result in a NullPointerException (NPE).

Verifying this change

[x] Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:  https://github.com/ethqunzhong/pulsar/pull/10

@ethqunzhong please rebase this PR

@ethqunzhong Please rebase this PR. Thanks


k8s readiness check failing

Question
When running on k8s, I'm now seeing [Health Check] Readiness failed: Dial error: handshake failed (connection name = "xxx:xxx:xxx"): context canceled only and it never recovers.
I'm using the config from here
https://github.com/GoogleCloudPlatform/cloud-sql-proxy/blob/main/examples/k8s-health-check/proxy_with_http_health_check.yaml
Also, the pod is showing as healthy, but it's not, since the application isn't being able to connect to it.
Nothing changed in the configuration and started failing this weekend on GCP
Code
No response
Additional Details
No response

Hi @pocesar! Thanks for opening an issue on the Cloud SQL Proxy.
Couple quick questions for you to hopefully understand your scenario a bit better:

Was your deployment working fine and then all of a sudden started seeing the above error?
Are you using Public or Private IP Cloud SQL connection?

We are currently updating our Health Check sample and this work is being tracked here https://github.com/GoogleCloudPlatform/cloud-sql-proxy/pull/1950

Hi @pocesar,
If your application can't connect, and also the proxy readiness check fails, then there may be a network configuration problem preventing the proxy from establishing a connection to the Cloud SQL Instance.
About readiness checks:
We discourage the use of the readiness check in most applications. If you are running an application like a website or API service, you usually want the application container to provide a readiness check that includes connecting through the proxy to the database. (see Readiness Check Configuration).
The example readiness check configuration is tuned for batch jobs. In this configuration, the readiness check will attempt to connect to the instance for a full 60 seconds, failing 6 times before marking the pod as "not ready".

@jackwotherspoon

Yes, it was working fine and now having those issues
I'm using the private IP of the SQL instance

@hessjcg I see, so the recommended manifest should leave the readiness block out?

Yes -- readiness is a tricky check to get right.
@pocesar Can your app reach your database otherwise?

Closing due to inactivity.


Page does not update info

No information (caught, map, exp, traveled dist) is updated at all after about 1 min.
Environment: Ubuntu 16.04(64bit). All dependencies are up-to-date.
Commit: 4dcfdddef16ee02c071b3e35dfe35f1a7b028224

This means that the bot failed to run. What is the console output?

I can see the bot is running as normal, collecting things and catching Pokemon. Only no visual update.

Same on Windows, also tools -> refresh does not work, when i refresh aplication go white screen when at console bot is running.

@Vardius This was a Python server bug. We got rid of it. Update to the latest version

no, i have the problem


Remove postgres pool

This introduces the environment variable VOTE_DATABASE_NO_POOL to disable the pool.
I think the pool should be the default for a non intervation setup. It is much easier to start OpenSlides without pgbounce. But without pgbounce, there should be a connection pool. The postgres-test need 6 seconds on my local laptop. But it takes 9 seconds, if I disable the connection pool.
If we want to make the connection pool optional, then we have to benchmark this with the performance tool.
We we find another way to fix this problem without disabling the pool, I would like not to merge this.
I found a hint about pgbounce in the documentation
I added lines in the file postgres.go to use the simple backend. But the documentation says, that the simple backend is not performant. Could you test this PR with and without the pool and with the two lines activated and disabled?
Maybe we have to test each of them with the  performance tool.

Okay, I did some testing.
My Test looked smth like this:
0. Have two browsers open: browser1 with superadmin, browser2 with normal user

Start a vote on motion1 in browser1
Vote in browser2
End vote in browser1
Start over from 1. inside a different motion
Do 2-3 iterations.

on master the test fails with the prepared statement "lrupsc_3_1" does not exist message, usually already during the first vote, at best during the second.
on this branch, disabling the pool seems to fix the issue, 3 iterations passed.
Enabled pool + conf.ConnConfig.PreferSimpleProtocol = true (within the if block, line 40) seems to suffice as well! It passed 4 iterations including a lunch break in between iteration 3 and 4. So it seems stable to me.

Im not sure what other implications conf.ConnConfig.PreferSimpleProtocol = true might have, but if you're not seeing issues with it @ostcar, IMO you can just include that line and keep the pooling.
Maybe @gsiv also has an opinion on this?

Thank you for the tests. I would like to keep this open until https://github.com/OpenSlides/openslides-backend/issues/1037 and https://github.com/OpenSlides/openslides-client/issues/655 is fixed. When it is possible to make some tests if there is a performance penalty and which configuration is the fastest.

I close this for now.


Csrf middleware is not fully PHP 5 compatible

Hello,
I've recently used Csrf Middleware with PHP 5.6 and cannot run it due to generateTokens() function.
random_bytes is only available since PHP 7.0
I suggest to use openssl extension such as :
        if (version_compare(PHP_VERSION, '7.0', 'ge')) {
            $index = self::encode(random_bytes(18));
            $token = self::encode(random_bytes(32));
        } else {
            $index = self::encode(openssl_random_pseudo_bytes(18));
            $token = self::encode(openssl_random_pseudo_bytes(32));
        }

What do you think of such solution ?

Good catch.
Maybe a better approach is simply check whether the function exists or not. Something like this: http://php.net/manual/en/function.random-bytes.php#118932
Do you want to work on a pull request?
Thank you!

Nice TIP (manual page). OK I'll work on a PR tomorrow !

Code is available on my forked version at https://github.com/llaville/psr7-middlewares/commit/236fbaea99e236135cfab0122f1a1a027b7ab62a (for code review, if you want).
I'll test it in real condition tomorrow, and gave you my feedback !

PR #63 is available !

Merged. Thanks for your contribution 👍


Reuse docker-entrypoint.bash from openjdk:8 image

Currently, we're overwriting the docker-entrypoint.bash file defined in the base image while duplicating most of the code in it. We should instead leverage the script in the base image. One option would be to define a different entrypoint script and call the one in the base image at the end after appending $DEFAULT_ARGS to $JAVA_OPTS.

I agree that it would be good not to duplicate the behaviour from the base entrypoint.  However, I'd rather not have an alternate entrypoint as it is pretty standard to use docker-entrypoint.bash and we want least surprise.
Instead, I would advocate having the base script start with something like:
#!/bin/bash

# source the supported feature JVM arguments
source /setup-env.bash
if [ -x /app-env.bash ] ; then
  source /app-env.bash
fi;

I believe all the subsequent difference in behaviour can be moved to such an app-env.bash script, but if not the changes needed in the base script should be minor to allow it to be more extensible.
Shall I prepare a PR along those lines?

Sure, this sounds good too.


Updated wrong types in quantile_plot.py

Type for y_true was set to pd.DataFrame, while a few lines later in sam_quantile_plot, y_true.name is checked. This caused the function to break, since pd.Dataframe has no attribute name, but pd.Series does. Since y_true was supposed to be a DataFrame with 1 column, this change is backwards compatible when y_titleis provided.

This makes sense, though we could also use the squeeze function to optionally squeeze a dataframe into a series. But that't maybe a task for later, for now this will suffice


HL7.FHIR.BE.RIZIV\AllergyIntolerance - FHIR v4.0.1 / Formal Views of Profile Content(jct)

Document
Section
Comment
Organization Name
Mail

HL7.FHIR.BE.RIZIV\AllergyIntolerance - FHIR v4.0.1
Formal Views of Profile Content
Do we need to add the element "probable reaction if taken" to the allergy? Add http://hl7.org/fhir/R4/extension-allergyintolerance-substanceexposurerisk.html (optional)
jct

this standard extension would prevent allergyIntolerance.code to be populated, which is messy.
I asked in Zulip, but in the meanwhile, we have our own extension.


FixedMeshletMemoryLeak

The branch name says it all

Has this already been merged into master from a different branch? There's no changes.


fix a doc error

TupleDataset.init() checks whether all items in the datasets argument
have the same length as datasets[0], but the doc says all datasets must
have (some) length, which should be a mistake.

Thank you!
LGTM


New install

So have tried to  install on pi zero and I get webui but does not  show temp , will not start, no manual control and screen does not work . Same on pi3b.
Event on start (warning: issue reading /tmp/current.log)
Any help would be great.
Thanks

Hi @Chadac77,
Are you using a PCB design for the project?  Which version?  What type of relay board do you have?  Is it high or low triggered?  Are you using the latest source from the development branch or are you using the main branch?
If you have the supervisor UI running, can you check if both the control script and the web app script are running?  (goto http://your.pifire.ip.addr:9001)

No pcb just bread board for now. Relay or triggered low. Using the main branch. Screen is SSD1306.
Web app running
Control runs for a few seconds then exits

OK, thanks.  Sounds like control.py is crashing on something.
Can you send the contents of the following files:
~/pifire/settings.json
~/pifire/logs/control.err.log
~/pifire/logs/control.out.log

I believe we'll be able to start to drill down on the error from there.

i get (permission denied)

settings
{"history_page": {"minutes": 1, "clearhistoryonstart": true, "autorefresh": "on", "datapoints": 60}, "probe_settings": {"probe_profiles": {"TWPS00": {"Vs": 3.28, "Rd": 10000, "A": 0.00073431401, "B": 0.0002157437, "C": 9.515686e-08, "name": "Thermoworks-Pro-Series-HeaterMeter"}, "ET73-HM": {"Vs": 3.28, "Rd": 10000, "A": 0.00024723753, "B": 0.00023402251, "C": 1.3879768e-07, "name": "ET-73-Heatermeter"}, "iGrill-HM": {"Vs": 3.28, "Rd": 10000, "A": 0.0007739251279, "B": 0.0002088025997, "C": 1.154400438e-07, "name": "iGrill-Heatermeter"}, "PT1000-00": {"Vs": 3.37, "Rd": 10000, "A": 0.04136906456, "B": -0.00677987613, "C": 2.760294589e-05, "name": "PT-1000-OEM-RTD"}, "ET73-SP": {"Vs": 3.28, "Rd": 10000, "A": 0.00023067434, "B": 0.00023696596, "C": 1.2636414e-07, "name": "ET-73-skyeperry1"}}, "probes_enabled": [1, 1, 1]}, "globals": {"grill_name": "", "debug_mode": false, "page_theme": "light", "triggerlevel": "LOW", "buttonslevel": "HIGH", "shutdown_timer": 60, "units": "F"}, "ifttt": {"APIKey": ""}, "pushbullet": {"APIKey": "", "PublicURL": ""}, "pushover": {"APIKey": "", "UserKeys": "", "PublicURL": ""}, "probe_types": {"grill0type": "PT1000-00", "probe1type": "TWPS00", "probe2type": "TWPS00"}, "outpins": {"power": 4, "auger": 14, "fan": 15, "igniter": 18}, "inpins": {"selector": 17}, "cycle_data": {"PB": 60.0, "Ti": 180.0, "Td": 45.0, "HoldCycleTime": 20, "SmokeCycleTime": 15, "PMode": 2, "u_min": 0.15, "u_max": 1.0}, "smoke_plus": {"enabled": false, "min_temp": 160, "max_temp": 220, "cycle": 10, "frequency": 1, "duty_cycle": 50}, "safety": {"minstartuptemp": 75, "maxstartuptemp": 100, "maxtemp": 550, "reigniteretries": 1}, "modules": {"grillplat": "pifire", "adc": "ads1115", "display": "ssd1306", "dist": "prototype"}}

had to use filezilla
this is my
~/pifire/logs/control.err.log
~/pifire/logs/control.out.log
https://drive.google.com/drive/folders/1BJVltCiJdCBBAnAsJ1JZl26SeANqM6oO?usp=sharing

Thanks for providing the files.  Can you approve my request for access to the drive link?  I just submitted the request (nebhead77 @ gmail).

done

done

Hmm... still don't seem to have access.  Could you make it public?

try this
https://drive.google.com/drive/folders/1BJVltCiJdCBBAnAsJ1JZl26SeANqM6oO?usp=sharing

done

OK, sorry, got access, not sure why it took a while to work. :)
Anyway, seems we have an issue with the display.  It appears that the display might not be recognized.  Can you make sure it's hooked up right?
luma.core.error.DeviceNotFoundError: I2C device not found on address: 0x3C

Could also mean that your I2C isn't enabled properly as well.  But let's check the connections of the display first.

yes i will hook display i had it disconnected for testing trying to see if it was the problem along with most everything. I will hook up everything and run it and then copy the file.

ok I saved the new files in the drive folder

OK, I think the screen might be OK now, but it's hard to tell.  Can you delete the control.err.log file in the logs directory to start it fresh?
It appears that there may be an issue with the ADS1115 (ADC) readings, as I see the output of the control.out-new.log:
2021-11-01 13:16:34 Error Reading Temperature.

Maybe double check you have this hooked up correctly as well.
Also, for any files that you don't have permission to change, you can always use sudo.
For example:
sudo cat control.err.log
sudo rm control.err.log

it seems to be  working now
i will test it
thank you so much

You're welcome!  Enjoy!


copySync errors swallowed, hanging deploy

While working on a smoke test for t2-compiler, the deployment would hang after INFO Connected to.... I discovered this was due to fs.copySync blocking errors inside of the actions.injectBinaryModules function.

@HipsterBrown could this also be the cause of https://github.com/tessel/t2-cli/issues/271? Or maybe just one of a number of causes.

It could be. The best practice in the future would be to add a .catch() to every Promise chain, so we can throw or reject those swallowed errors.

:+1: good point. I'll keep my eye out to see if I hit this hanging issue anymore. I've tried to make sure all errors are being passed up the chain but it's totally possible I missed a few cases.


[🌟] Way to store more than one image at one

Description
Hi, i use this library to get two images (opening the picker for each image) and then upload this images to the cloud. As follows:
open the picker
pick an image
save the image uri in the state
open the picker again
pick an image
save the image uri in state
upload the two files in a multipart-file request
But i noticed that the library persist one image at once. so the request fails because cant read one of the two files
Proposed Solution
Implement a way to store more than 1 file at once.
Test Solution
Pick two images in separated sessions (open the picker for each image).
Check that the two image uris exists in the file system

Not sure this will be implemented, but as a workaround, create your own copy of the image after a user selects it.

@Johan-dutoit Thanks for your reply. Do you have an example that works? I tried with RNFS but it gives me an error that the file cannot be found.

This can be help hear

Done!


I'm having this issue, too

Still have the same issue. Is this repository actually still maintained?

This is still happening... would it be possible to have the API server embedded so we can run it locally?

Same issue.

Same issue.

same issue


[Learn Rebrand Metadata Publish]

Learn Build status updates of commit b860614:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

documentation/blog/MS-SQLINTBLOGLP/0b5e3a73-15fc-44b5-b5e6-7385b693115c.md
:white_check_mark:Succeeded

documentation/blog/MS-SQLINTBLOGLP/6da25da6-94f9-4eba-98d0-0a2cf789f166.md
:white_check_mark:Succeeded

documentation/blog/MS-SQLINTBLOGLP/7f5fe25f-10ae-40a6-88fa-5c0fd6012a95.md
:white_check_mark:Succeeded

documentation/blog/MS-SQLINTBLOGLP/9509b32d-256b-4771-b802-ac4e9ddaddb0.md
:white_check_mark:Succeeded

documentation/blog/MS-SQLINTBLOGLP/be97d48a-7fbd-440c-b508-135be337a9c0.md
:white_check_mark:Succeeded

documentation/blog/MS-SQLINTBLOGLP/c892c071-027a-43c7-88f1-019765975d06.md
:white_check_mark:Succeeded

documentation/blog/MS-SQLINTBLOGLP/cec9ad5e-988f-4043-b541-3c5ebbe93c3a.md
:white_check_mark:Succeeded

documentation/blog/MS-SQLINTBLOGLP/f5f55ea5-bb77-4448-a9c6-c9ba363d59dc.md
:white_check_mark:Succeeded

documentation/blog/MS-SQLINTBLOGLP/f907472f-a738-4cb9-b353-5f2bb8ca577b.md
:white_check_mark:Succeeded

documentation/blog/MS-SQLINTBLOGLP/ff908ef1-89f6-4045-b32a-13da8c6fca3f.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/0778cda7-a610-4cae-92df-281c6cd81e57.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/3c50cdd8-7934-41aa-a878-e2e6f0f5d792.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/49863e24-573f-4b5d-a497-28b228271c38.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/534eadc5-d06b-47e3-b6a4-ecf7c5050437.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/5764aef4-7758-4edb-83c0-badad385087c.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/6183f838-c21e-4c44-a5bb-1a84e1864c2e.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/679d51f9-ae93-46d3-ba9b-a3136f09b2a6.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/71ce8f62-8a99-4606-b5f5-da38c8012d8f.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/7b112223-12f5-4ae8-ad7b-3f5d30fd6270.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/7fa9eb87-5b32-48aa-a7fb-450822b6724c.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/d0ae8948-5328-48b9-bb88-9667a8fb76cf.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/da478d59-c2e6-41cf-8eae-ec8223a8ad3a.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/dd98b93c-0a75-4eb0-b92e-e760c502394f.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/f8d6b307-8317-4b38-9263-586a2569272f.md
:white_check_mark:Succeeded

documentation/blog/MS-WININTBLOGLP/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Correct spelling + grammar

These fixes are already within a planned writing update, so i will take these into consideration. Thank you for noting these changes.


Maintenance?

Hi - it looks like a lot of the integrations are being abandoned (i.e. all bot sdks/integrations). Would anyone be able to elaborate on the plans of maintaining (or at least merging the 24! PRs, I guess)?
Thanks - Rocket chat looks great, but bots/other integrations are important for our use case...

Yesterday in the community open call they (Guilherme Gazzo) said they are moving to a "monorepo". As soon as their "internal SDK" reaches parity regarding features with this repo (Rocket.Chat.js.SDK) they plan to deprecate it.
@RC: Feel free to correct me here. Mr. Gazzo clearly struggled with expressing things in the english language.

@ggazzo i had no one particular in mind to notify. Thanks for your confirmation of the roadmap for this repo.

@mmaass Hi! Any news on SDK updates?

Is there an alternative to the JS SDK in a monorepo?
Asking because of #169 😖

I wonder what to use today to connect to RocketChat Server and Post messages when writing a node.js based Chat Bot?
Can’t find anything besides the JS SDK and a this https://github.com/RocketChat/botkit-rocketchat-connector approach in the docs. Th latter one also seems to be as unmaintained as the SDK.
I was just digging through the monorepo and found these:

https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/apps-engine
https://github.com/RocketChat/Rocket.Chat/tree/develop/packages/api-client

Both lack the needed documentation 🤔
Any other ideas?

Adding tags to ensure notifications ;)
@mmaass
@ggazzo
Have great Christmas holidays and an happy new year in advanceto y'all !
Cheers


libnss3 required on ubuntu 18.04 minimal

Describe the Bug
libnss3 is required to run webots on ubuntu 18.04 minimal
Steps to Reproduce

Install webots with sudo apt install webots on ubuntu 18.04 minimal
see the message /usr/local/webots/bin/webots-bin: error while loading shared libraries: libnss3.so: cannot open shared object file: No such file or directory
Install libnss3 sudo apt install libnss3
Webots runs.

Expected behavior
Webots runs without manually installing libnss3
Screenshots
$ webots
/usr/local/webots/bin/webots-bin: error while loading shared libraries: libnss3.so: cannot open shared object file: No such file or directory
$ sudo apt install libnss3
...
$ webots # now webots runs

System

Operating System: Linux Ubuntu 18.04

Additional context
I'm trying to run Webots on docker. I don't usually use ubuntu, so honestly I'm not sure if there's Ubuntu 18.04 minimal or not, but I guess you will know what I meant.

This is probably because you did install a minimal version of Ubuntu 18.04, I checked on a normal install of Ubuntu 18.04 and libnss3 is present by default.
Did you install Webots from the tarball or debian package?

We fixed this in #293 libnss3 will be a dependency automatically installed when installing Webots in the next version of Webots.


Error messages aren't displaying on the remote container create form

https://issues.redhat.com/browse/AAH-1845
This PR refactors error handling using utils. Every error (including field validation and server side validation together) is now in one associative array formErrors, which can hold error message per form field (for example formErrors['name']).
Also, validation from server in attempt to save the form is now included.

There's a lot of commented-out code, and no  PR description.
What is this supposed to do?

One more thing noticed during testing... this doesn't deal with unknown errors from the server in any way, no alerts, no messages, just a stuck form.
Try adding a EE with a name like foo/. - this passes the name validation, but the server responds with a base_path validation message .. we should be displaying unknown messages on error.
(The response looks like...
{
  "errors": [
    {
      "status": "400",
      "code": "invalid",
      "title": "Invalid input.",
      "detail": "The provided base path contains forbidden characters.",
      "source": {
        "parameter": "base_path"
      }
    }
  ]
}

)

TODO - delete validation errors when alert is shown and error does not belong to any field.

Looks like this works :+1:

(just needs a rebase to get tests green, #3018 )


help me to stream from line in to icecast

Hi, I'm from Vietnamese and not good speak English. I have been following you for a long time and found this project very good. Recently I had the idea to stream from line in vs1053/1063 to icecast. Have you done this, can you help me? Thank you!!

No, never done this.


Wiring Diagram

Hi. Thank you for sharing awesome code with esphome.
While I am working with wring the wind sensor devices, I am confused with some wiring problem such as resistance, GPIO etc..
Would you upload your whole system's wiring diagram?

Hi,
As I explain in the article, this project is derived from an article in Elektor magazine (https://www.elektormagazine.com/labs/remake-elektor-weather-station).
The schematics are available on the article page as a PDF:

https://www.elektormagazine.com/files/attachment/31165
https://www.elektormagazine.com/files/attachment/23317

Thank you. So, did you follow every wiring step without modification just as diagrams in the files?

Thank you. So, did you follow every wiring step without modification just as diagrams in the files?

Yes because I used the original card from the article.


Removing groovy meta definition

Nextflow is recognised as a proper lang by GiHub and editors such as Atom and VS Code.

Thx @pditommaso !

But I'm still not happy (see #16) 😆


[BUG][opensearch-dashboards] selectorLabels generated but not used.

Describe the bug
opensearch-dashboards.selectorLabels is defined, but never used. Instead the labels for app and chart are used.
This makes the selector labels an outlier with the rest of the repository
To Reproduce

Check the _helpers.tpl for generation of the selectors
Check the selector labels present in the templates themselves

deployment.yaml
service.yaml

Expected behavior
I'd expect the selector labels to be properly used.
Chart Name
opensearch-dashboards
Host/Environment (please complete the following information):
Not relevant.

Hi @rcomanne can you raise another PR with DCO signed (just use -s when you run git commit).
Thanks.


Mathematical functions should accept integral type

Mathematical functions of xsimd should accept integral types when their standard counterparts do.

Duplicate of #403


Docs: HelloWorldStreamFunction in examples fails with sam

Issue #, if available:
Description of changes:

Checklist

[ ] Meet tenets criteria
[ ] Update tests
[ ] Update docs
[ ] PR title follows conventional commit semantics

Breaking change checklist

RFC issue #:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6e33419) 79.48% compared to head (d4bed89) 79.07%.
Report is 13 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1532      +/-   ##
============================================
- Coverage     79.48%   79.07%   -0.41%
- Complexity      740      754      +14
============================================
  Files            90       93       +3
  Lines          2778     2877      +99
  Branches        294      307      +13
============================================
+ Hits           2208     2275      +67
- Misses          478      503      +25
- Partials         92       99       +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


No module named 'hok.lib.interface'

Hello, I followed the README.md, and was stuck at the following command:  python3 test_env.py. Here's the log:
xinli@XinLi:~/hok_env/hok_env/hok_env/hok/unit_test$ sudo python3 test_env.py
Traceback (most recent call last):
  File "/home/xinli/hok_env/hok_env/hok_env/hok/unit_test/test_env.py", line 5, in <module>
    from hok import HoK1v1
  File "/usr/local/lib/python3.10/dist-packages/hok/__init__.py", line 11, in <module>
    from hok.env1v1 import HoK1v1
  File "/usr/local/lib/python3.10/dist-packages/hok/env1v1.py", line 22, in <module>
    import hok.lib.interface as interface
ModuleNotFoundError: No module named 'hok.lib.interface'

It appeared an error message saying that No module named 'hok.lib.interface'. I checked the ~\.local\lib\python3.10\site-packages\hok\lib folder, it existed four files:
interface.cpython-36m-x86_64-linux-gnu.so
interface.cpython-37m-x86_64-linux-gnu.so
interface.cpython-38-x86_64-linux-gnu.so
interface.cpython-39-x86_64-linux-gnu.so

Does anyone know how to fix this problem? Thanks.

I also encountered the same problem as you with this command. I searched hok_env-master and hok_env_gamecore but couldn’t find this module. I hope the author can help solve this problem, thank!

Python10 is not supported now. Please use try to use python36~python39.

i change to 3.6,but its not work also

have you fixed it?


add SoftImpute and IterativeSVD to imputation

PR Checklist

[ ] This comment contains a description of changes (with reason)
[ ] Referenced issue is linked
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] Documentation in docs is updated

Description of changes

Add SoftImpute and IterativeSVD from fancyimpute to imputation.
Technical details

pyproject.toml has been updated to add fancyimpute dependency.
ehrapy/preprocessing/init.py has been updated to add import.
tests/preprocessing/test_imputation.py has been updated to add corresponding tests.
Additional context

Docstring needs to be updated.

@xinyuejohn you also need to add this function to the docs.

Please add the imputation methods to the docs (usage.rst)

@Zethson It seems this has no more issues.


[Feature] Easier @doc Macro or Alternative

Hey @ronisbr!
Now that I have started using TerminalPager frequently, I had one feature request/idea that I am not sure how much work would be to do on your end. A big use that I have right now for the package is looking at documentation as it tends to clutter my REPL session. However, with your handy tool and the docs macro, this is no longer a problem!
However, what I was wondering if rather than having to write syntax like this every time:
@doc(println) |> pager
Could you instead make it something more like this:
@doc println
Where the macro implicitly knows to call the pager command? Thanks for the great work! Use it everyday. :)

Hi @TheCedarPrince !
Nice! I am glad this package is being useful :)
I think we cannot "hijack" @doc without many consequences (I don't know even if it is possible). However, it should be really easy to create another macro, like @docp or something. What do you think?

Sorry, hit the wrong button...

Oh! I didn't realize that @doc was provisioned from base Julia. What about @dpr - short for "docs pager" and pronounced like "dapper"? Either way, another macro sounds great! Plus, that has the bonus - to my eyes - of getting away from having to depend on base Julia if they were to change around the @doc macro. What do you think @ronisbr ?

Hi @TheCedarPrince !
Done! I followed your suggestion and added the macro @dpr. Hence you can now call open a documentation inside the pager using @dpr <function_name>. Can you please test?

Hey @ronisbr - what a great tool! Works perfectly on my fork of TerminalPager. :100:
Thank you for adding this in! Would you like an example of @dpr added to the docs? Happy to open a small PR adding how it can be used! :smile:


localStorage versioning

Describe the bug
Sometimes when you try to download a format (i.e. bibtex) of a record,  you get 406.  We should start versioning the localStorage to avoid these errors in the future.

The bug is fixed in #1361 temporarily. I'll check how we can do proper local storage versioning, migrations and cleanup without a lot of effort.
This could be a good time to investigate if we need to move IndexDB, because AFAIR we were seeing errors like "Local storage limit exceeded" from some clients.

Since we just need a simple key -> value store, IndexedDB is an overkill unless we use a simple wrapper like https://github.com/localForage/localForage which also comes with version support.
If the library size is too big, we can just write a simple wrapper that clears whole localStorage when version is changed.

TECH NOTES: Implement localForage, write function to loop through localStorage to get values and set them in localForage in order to persist user settings (to be deleted after most of the users use the app at least once), replace localStorage in storage.js file with localForage

did you see my concern regarding Safari compatibility in https://cern-rcs-sis.zulipchat.com/#narrow/stream/310485-inspire/topic/localstorage/near/278165924 ?

the library fallback to localStorage if it's not supported


Only trigger onStart when the compiler starts

compilation might be triggered multiple times during a build, which leads to multiple Building ${name} bundle....
compile is only triggered once, when the compiler starts.

before
after

Cool, thanks!  AFAIK, this only fires once the main bundle begins compiling. This is why I've never seen this issue happen before.

Good question.
I'm not that well versed in webpack events. I just read https://webpack.js.org/api/plugins/ and figured it was possible for compilation to fire multiple times and compile only once.
Also, I just debugged my setup again and it seems the ExtractTextWebpackPlugin is the one triggering multiple compilation events.

Cool. Well, switching to compile also only emits once per bundle (for me) so let's move ahead with this on the assumption that other plugins emit/alter the compilation event.
Thanks!


Add writer for configuration files in Python

Description
Add writer for configuration files in Python
used for stackabletech/superset-operator#173
Review Checklist

[ ] Code contains useful comments
[ ] (Integration-)Test cases added (or not applicable)
[ ] Documentation added (or not applicable)
[ ] Changelog updated (or not applicable)

This seems.. dangerous. Is there any significant gain from doing this vs emitting the user's config in an inert data format (JSON?) and shipping a static "config file" that just loads that data file?

The implementation for the boolean and integer literals is not dangerous.
The string literals are only dangerous if the escaping is not implemented correctly.
The Python expressions are dangerous but also powerful. The operator can use them to easily add own configuration options:
    config.insert(
￼        SupersetConfigOptions::StatsLogger.to_string(),
￼        "StatsdStatsLogger(host='<IP_ADDRESS>', port=9125)".into(),
￼    );

Admittedly, this can also be achieved with a static string.
If the cluster configuration does not expose options of type "Python expression" then there is only a risk at the configuration overrides. The configuration overrides need to be expressive to be useful:
configOverrides:
  superset_config.py:
    CSV_EXPORT: "{'encoding': 'utf-8'}"
    PREFERRED_DATABASES: |-
      [
          'PostgreSQL',
          'Presto',
          'MySQL',
          'SQLite',
          # etc.
      ]

I do not see how this can be (easily) achieved with a JSON file without embedded Python code.
If the user installs a F.A.B. application directly, she/he is able to do (dangerous) configurations in the Python file. In my opinion, the operators should not restrict the possibilities of the products too much, otherwise the operators could be perceived as a burden. Furthermore, an administrator who knows how to configure e.g. Superset, will have no problems to configure it in the cluster spec if it resembles the product configuration as close as possible (which means Python code).
But I see your point and we should discuss, e.g. in the architecture meeting, if the operators should tend to flexibility or safety in such a case.

bors merge


KB mapping for the human set

Hi, It is good work and I plan to do some research based on the dataset.
Could you please provide the KB mapping for the human set, so that I can measure the upper bound of model performance when given the correct external knowledge?

Hi @Lackel ,
Thanks a lot for your interests!
We released withkb information for train/valid for model development.
For test/human set, the goal is to retrieve entity directly from the wikipedia. So we don't plan to release the gold withkb information publicly.


add rmutsb.ac.th

The school official URL : https://www.rmutsb.ac.th/2016/home/
Here is the list of accredited from Ministry of Higher Education
http://inter2.mua.go.th/documents/Thai_HEIs.pdf
(Row number: 82  Page: 2)

@utarn I have to close this request without merging, because you requested to add a non-existent domain to this repository: ;; connection timed out; no servers could be reached Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for understanding!

I think there was something wrong with your server.
You may try to access through Google server. The website is up and running.
https://translate.google.com/translate?sl=th&tl=en&u=https%3A%2F%2Fwww.rmutsb.ac.th%2F2016%2Fhome%2F


add tolerance to RegionOps.regionBooleanXY

Allow caller to supply (larger) merge tolerance to this method so that imprecise loops with gaps greater than the default micrometer tolerance can be merged successfully, avoiding danglers/spikes that can cause issues with parity analysis downstream.
For example, creating a UnionRegion with RegionOps.regionBooleanXY by passing in default tolerance and input geometry that has gaps on the order of 1e-5 meters:
 top: bottom:
and then passing the output into RegionOps.constructAllXYRegionLoops can result in a component with two negative area (outer boundary) loops. However, by passing in a larger tolerance, say 1.0e-4, the same construction sequence results in the expected single boundary loop.
Also: clarify/make consistency changes to angle measurement API.

@mergifyio backport release/3.7.x


Handle score for no impact

This should resolve https://github.com/skontar/cvss-v4.0-calculator/issues/3 .


Changing v11 instruction to test LLMAJ grounded ensemble

@KMirshahi what is the status of this? To me it looks like an important separation between instruction and the few shot examples. But not sure who's using it and how. @OfirArviv @pvn25 do you have a comment to add here?


android,  part of layout be blank until tap the screen.

I am using react native to write a communicator of Webrtc. After the stream is established, the video stream from remote doesn't play well in the native UIComponent. We need tap screen then it works.
The process of the communicator is as below.

prepare a view groupfor the video stream.
do establish video stream.
put  the video stream into the view.

I expected the stream will be play on the corresponding place but it didn't.
Is there any solution for this case?

After inspect log. It is a surface was not created until tap the window.

two causes, 1 the stream be established after render, it would not be done again.
2. View not opacity.

@facebook-github-bot label Android

I am curious about this as well. I am building a native ui component, and layout isn't triggered until a scroll event. So I'm wondering if there's some layout invalidation that needs to happen first. Additionally, I'm curious if this is due to some undocumented caveat in the way react-native renders native modules. I have a similar issue on iOS.

My case is a communication application by webrtc. webrtc will establish video stream and render a pre-defined native UIComponent(view group).
We design the Interface with a "TouchableWithoutFeedback". the menu will be popped after the view is touched. It is very unstable both android and IOS.
We remove the  "TouchableWithoutFeedback" component and use simple layout. Switch the view in layout by "weight" and "height" it is stable now.
I guess the view render collide with my UIComponent.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/android-part-of-layout-be-blank-until-tap-the-screen
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub. GitHub issues have voting too, nevertheless
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.