Bug: using absolute paths throws FileExistsError

$ docker run -v `pwd`:/app2 --rm quay.io/mschuette/yaml-shellcheck /app2/test-input/github-workflow.yml

2024-08-14 02:18:05,957 - root - INFO - read /app2/test-input/github-workflow.yml as GitHub Actions config...
Traceback (most recent call last):
  File "/app/yaml_shellcheck.py", line 459, in <module>
    main()
  File "/app/yaml_shellcheck.py", line 448, in main
    filenames.extend(write_tmp_files(args, result))
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/yaml_shellcheck.py", line 402, in write_tmp_files
    subdir.mkdir(exist_ok=True, parents=True)
  File "/usr/local/lib/python3.12/pathlib.py", line 1311, in mkdir
    os.mkdir(self, mode)
FileExistsError: [Errno 17] File exists: '/app2/test-input/github-workflow.yml'

or
$ docker run -v `pwd`:`pwd` --rm quay.io/mschuette/yaml-shellcheck  `pwd`/**/*.y*ml
2024-08-14 02:32:29,902 - root - INFO - read /home/luka/Downloads/yaml-shellcheck/test-input/ansible-playbook.yml as Ansible file...
Traceback (most recent call last):
  File "/app/yaml_shellcheck.py", line 459, in <module>
    main()
  File "/app/yaml_shellcheck.py", line 448, in main
    filenames.extend(write_tmp_files(args, result))
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/yaml_shellcheck.py", line 402, in write_tmp_files
    subdir.mkdir(exist_ok=True, parents=True)
  File "/usr/local/lib/python3.12/pathlib.py", line 1311, in mkdir
    os.mkdir(self, mode)
FileExistsError: [Errno 17] File exists: '/home/luka/Downloads/yaml-shellcheck/test-input/ansible-playbook.yml'

This happens because https://github.com/mschuett/yaml-shellcheck/blob/2608670944fe48bf08e2bd334cf4114db8c6b4d3/yaml_shellcheck.py#L397
is just subdir = filename for absolute paths.
Naive fix
https://github.com/lukaw3d/yaml-shellcheck/commit/8df5d6476862712fbb3afcd31288348a55e9f6b0
$ docker run -v `pwd`:/app2 --rm ghcr.io/lukaw3d/yaml-shellcheck:main /app2/test-input/github-workflow.yml
2024-08-14 02:29:29,192 - root - INFO - read /app2/test-input/github-workflow.yml as GitHub Actions config...

In a/app2/test-input/github-workflow.yml/jobs/hello_world_job/steps/2/run line 2:
echo random-number $ACTION_EXPRESSION
                   ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
echo random-number "$ACTION_EXPRESSION"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

fixed in the PR and released as part of v1.4.0


no version information available (required by ./cuda_dot)

CUDA Version : 10.2
OS : Ubuntu 18.04
I successfully compiled the CUDA code in the frontend, but I was prompted with the following error when running the CUDA application.
./cuda_test: /root/GVirtuS/lib/frontend/libcudart.so.10.2: no version information available (required by ./cuda_test)
./cuda_test: relocation error: ./cuda_test: symbol cudaLaunchKernel version libcudart.so.10.2 not defined in file libcudart.so.10.2 with link time reference

I tried to execute the following command
ldd -d ./cuda_test
I got the following result
./cuda_test: /root/GVirtuS/lib/frontend/libcudart.so.10.2: no version information available (required by ./cuda_test)
	linux-vdso.so.1 (0x00007ffe965e8000)
	libcudart.so.10.2 => /root/GVirtuS/lib/frontend/libcudart.so.10.2 (0x00007fc12da30000)
	libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fc12d6a7000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fc12d48f000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fc12d09e000)
	libgvirtus-frontend.so => /root/GVirtuS/lib/libgvirtus-frontend.so (0x00007fc12cdc9000)
	libgvirtus-communicators.so => /root/GVirtuS/lib/libgvirtus-communicators.so (0x00007fc12caf1000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fc12c753000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fc12de77000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fc12c54f000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fc12c330000)
symbol cudaLaunchKernel version libcudart.so.10.2 not defined in file libcudart.so.10.2 with link time reference	(./cuda_test)
symbol __cudaPushCallConfiguration version libcudart.so.10.2 not defined in file libcudart.so.10.2 with link time reference	(./cuda_test)
symbol __cudaPopCallConfiguration version libcudart.so.10.2 not defined in file libcudart.so.10.2 with link time reference	(./cuda_test)
symbol __cudaRegisterFatBinaryEnd version libcudart.so.10.2 not defined in file libcudart.so.10.2 with link time reference	(./cuda_test)

The above results appears to be missing some functions, cudaLaunchKernel, __cudaPushCallConfiguration, __cudaPopCallConfiguration, __cudaRegisterFatBinaryEnd seems to not be found.

same error. have you slove this problem ？@sky-ng

same error. have you slove this problem ？@sky-ng

I downgraded the CUDA version to 9.0 and tried this version: https://github.com/RapidProjectH2020/GVirtuS

then, is it ok? @sky-ng

then, is it ok? @sky-ng

yes

thanks,i'll have a try


Correct ipa dts filter configuration to act on MuBeamFlash stream

A typo slipped into https://github.com/Mu2e/Production/pull/369 by which the correct dts filtering for IPA Michel mixing jobs would be applied to the wrong input stream (MuStopPileup, instead of MuBeamFlash). This PR fixes that mistake.

Hi @edcallaghan,
You have proposed changes to files in these packages:

JobConfig

which require these tests: build.
@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.
:hourglass: The following tests have been triggered for 6d6fb1b61332a0fcb4a9b0d039684d537747e856: build  (Build queue is empty)
About FNALbuild. Code review on Mu2e/Offline.


No self-signed variable in exodus data

We are not seeing the self-signed variable referenced in the addon for the cf login in the exodus data. The best that we can tell is that self-signed variable is associated when ha-proxy is enabled. Since we are not using ha-proxy in our test environment the self-signed variable will not show up even though we are using self-signed certs.

To work around this we ran this command to create the variable
safe set secret/exodus/dev/cf self-signed=1


Fix web server crash in Docker environment

The current web server fails on my machine when I run the Docker setup. I found out that this was a more common issue with a fix, so I've applied this fix to our setup.
This was the crash: https://github.com/etingof/pyasn1/issues/108

Would it be an idea to specify the dependencies of the web server in a requirements.txt?

There is a setup.py, I believe, maybe we could finally make use of that one?

That would be a good idea!

I'll do that in a separate PR, I'd propose merging this one for now, what do you think?

Agreed!


Added countdown based on the deadline in application.properties file

A countdown clock has been added to the homepage. It will hit 0:0:0 past the moment contained in the variable app.deadline declared in the application.properties file (currently set to the Git Race's deadline). Also added some Bootstrap details to make the page shown a little more appealing.
The clock's JS code was based on the following example

Please, sync first with this repo.


NotebookController only allows for one view type

Last week, the NotebookController selector property was replaced with viewType. In the old design with NotebookKernels, we only had to use one kernel where we could specify multiple view types.
With the new design, it seems we are limited to one view type per controller. Put another way, we can't have a single controller support multiple view types. Is this by design?
I am using this in the Live Share extension to create a controller for the guest to enable coediting. Could we change this to accept a string or an array? This would let us use one controller that handles all view types.
cc @jrieken

Put another way, we can't have a single controller support multiple view types.

It's not documented because I wasn't sure about it but the * view type means any view type.


Started to see new console.warn messages

This line was added 3 days ago but I'm not sure if that is meant to be a warning or its just left by mistake:
https://github.com/krakenjs/post-robot/blame/1df75d4fdc1ccc08dfdd3170e1d79b97383074e3/src/drivers/listeners.js#L107
console.warn('adding request listener:', name);

Whoops! Published a fix. Gotta add some lint rule to guard against this in future, I'll keep this issue open as a reminder.


Update FontAwesome5 to 5.11.2

Updated using provided script

Looking at integrating the new Duotone fonts too

Looks like this works correctly but theres issues with the duotone second glyph not appearing

A newer version has since been merged, closing


[RFC] Bluetooth: Multiple identity support

This set of patches adds support for multiple identities (identity addresses and local IRKs) for LE peripheral role operations. For central role the default identity (0) is always used.
Not very thoroughly tested yet (hence the RFC/DNM tag).
Fixes #7473

FYI: @pdunaj

FYI @fiku

@jhn-nordic

Codecov Report

Merging #8943 into master will increase coverage by 1.72%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8943      +/-   ##
==========================================
+ Coverage    52.3%   54.02%   +1.72%
==========================================
  Files         196      188       -8
  Lines       24778    23958     -820
  Branches     5152     4996     -156
==========================================
- Hits        12959    12943      -16
+ Misses       9740     8941     -799
+ Partials     2079     2074       -5

Impacted Files
Coverage Δ

subsys/bluetooth/common/log.c

subsys/bluetooth/host/crypto.c

include/bluetooth/buf.h

include/drivers/bluetooth/hci_driver.h

subsys/bluetooth/host/uuid.c

include/net/buf.h
100% <0%> (+11.11%)
:arrow_up:

include/misc/byteorder.h
96.15% <0%> (+39.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02addff...475a13b. Read the comment docs.

CC @pdunaj @Qbicz @jhn-nordic

@aescolar does anyone from Oticon want to review this?

@pizi-nordic

General question: Are we going to support per-identity values in GATT database different than CCCD?

Well, we get read/write callbacks with struct bt_conn *conn. At that point the application can check with id is active and reply with a data set or another?
@jhedberg can you confirm my statement?

Well, we get read/write callbacks with struct bt_conn *conn. At that point the application can check with id is active and reply with a data set or another? @jhedberg can you confirm my statement?

@carlescufi yes, that would be the way to do it.

@pizi-nordic I've tried to cover the issues you raised in the API documentation. I've also reduced the maximum to 10 identities (in theory current settings subsystem would allow up to 11, but I decided to keep it a nice round number)

Updated the PR with the new bt_id_reset() API (untested and no shell support yet). Also simplified the persistent storage logic as discussed, i.e. after bt_enable storing will always happen. We can introduce a Kconfig option later to modify this behavior, if it's deemed to be necessary.

@pizi-nordic there's now a bt_id_delete() API. After thinking more about this I agree that makes sense, since that way the app doesn't need to do any of its own persistent storage for knowing what identities are valid.

@pizi-nordic @oyvindronningstad any further comments on this PR? I've tried to address all issues brought up so far.

@jhedberg: Looks good for me.

I removed the DNM label now, since this seems to be working quite well in my own testing. Next it'd be nice to get some "approved" reviews :)

no docs to review?

@dbkinder well, there's the Kconfig help text and the API documentation in the header files.


Failure build with forked version

Running microsoft.exchange.webservices.data.util.TimeZoneUtilsTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec
Results :
Failed tests:   testOlsonTimeZoneConversion(microsoft.exchange.webservices.data.property.complex.OlsonTimeZoneTest): olsonTimeZoneId for Europe/Astrakhan is blank
Tests run: 132, Failures: 1, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31.894 s
[INFO] Finished at: 2018-02-02T09:54:23+01:00
[INFO] Final Memory: 31M/297M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on project ews-java-api: There are test failures.
[ERROR]
[ERROR] Please refer to C:\pz\Git\ews-java-api\target\surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
I just forked the current version and tried to compile it with Maven.

The referenced PR I provided should fix the issue if you want to use it locally @louis123562 .
It's a shame that there's no interaction with the project owners :-1:

I just deleted the test and compiled successfully without it.
Thank you for that offer @philipwhiuk . I really dont know why the community here is so quiet.


Migrate to GPT-4

Description
Now the chat request are all using GPT-4 model.

Currently wait for the release of GPT-4 API.

@Xanonymous-GitHub I already enable GPT-4 feature.


Playbook for NFS purge

Is your feature request related to a problem? Please describe.
Unfortunately, the NFS isn't supported anymore on Debian-based systems. Basically, there was no release for stable NFS-ganesha repositories since Mimic. For Nautilus there was a chakra repo that could be used, but it wasn't stable. For Octopus there are no packages at all, so to be able to update the cluster to Octopus we had to remove the NFS update part from the rolling update playbook.
However, we decided to drop the usage of NFS on our Ceph cluster, but how do we remove it now?
Describe the solution you'd like
There are other playbooks to remove components from the cluster (shrink or purge). It would be nice to have a playbook for NFS shrink/purge.

FYI
For Ubuntu there's https://launchpad.net/~nfs-ganesha
For Debian there's https://download.nfs-ganesha.org/


No module named 'sctx.snvs.snvcmp'

I'm trying to get sctx running on my scnv annotated data, but the module import isn't working. Strangely enough, 'import sctx' doesn't give any errors. This is the code I'm using, from the example:
import os, sys
import pandas as pd
from sctx.snvs.snvcmp import GroupBuilder, SampleData
import sctx.genotype as GT
import sctx.refine as RT
from sctx.find_snvs import FindSNVs

And this is the error:
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[3], line 3
      1 import os, sys
      2 import pandas as pd
----> 3 from sctx.snvs.snvcmp import GroupBuilder, SampleData
      4 import sctx.genotype as GT
      5 import sctx.refine as RT

ModuleNotFoundError: No module named 'sctx.snvs.snvcmp'

It's worth noting that during the installation of sctx, this particular line was highlighted in red:
zip_safe flag not set; analyzing archive contents...
sctx.snvs.__pycache__.calc.cpython-310: module references __file__

Hi,
It's strange that you are getting that error.  Perhaps there was an issue with the package installation.  It may be the outdated package installation script I was using.  I have updated the repository.  Could you clone it again and install it using the new instructions in the README?

When I tried running sudo pip install . , I got this error:
Processing /data/sctx
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [7 lines of output]
      Compiling src/sctx/snvs/calc.pyx because it depends on /tmp/pip-build-env-540s0wg5/overlay/local/lib/python3.10/dist-packages/Cython/Includes/libcpp/__init__.pxd.
      [1/1] Cythonizing src/sctx/snvs/calc.pyx
      running egg_info
      writing sctx.egg-info/PKG-INFO
      writing dependency_links to sctx.egg-info/dependency_links.txt
      writing top-level names to sctx.egg-info/top_level.txt
      error: package directory 'sctx' does not exist
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

Sorry that's my fault.  I think it's fixed now if you reclone it.

Looks like you are missing the package needed to install python packages with pip:
pip install setuptools

Setuptools is already installed with pip. I've been trying to troubleshoot things on my end, but nothing seems to be working.

Are you using multiple versions of python or some kind of environment like conda?   I have python in a micromamba instance and when I run my commands I get:
gww@GWW:~$ which python
/home/gww/micromamba/envs/GWW/bin/python
gww@GWW:~$ which pip
/home/gww/micromamba/envs/GWW/bin/pip
gww@GWW:~$ python
Python 3.10.11 | packaged by conda-forge | (main, May 10 2023, 18:58:44) [GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import setuptools
>>>

Setuptools is functional and can be imported with no problems, it's just not working for this one specific case. In the conda env:
(myenv) dluong@davidsctx:/data/sctx$ which python
/home/dluong/anaconda3/envs/myenv/bin/python
(myenv) dluong@davidsctx:/data/sctx$ which pip
/home/dluong/anaconda3/envs/myenv/bin/pip
(myenv) dluong@davidsctx:/data/sctx$ python
Python 3.12.1 | packaged by Anaconda, Inc. | (main, Jan 19 2024, 15:51:05) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import setuptools
>>>

Outside the conda env:
dluong@davidsctx:/data/sctx$ which python
/usr/bin/python
dluong@davidsctx:/data/sctx$ which pip
/usr/local/bin/pip
dluong@davidsctx:/data/sctx$ python
Python 3.12.1 (main, Dec 10 2023, 15:07:36) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import setuptools
>>>

You could try:
/home/dluong/anaconda3/envs/myenv/bin/pip install .
to force the use of your conda pip command.

I found this answer on StackOverflow and it seems to have worked! https://stackoverflow.com/a/65787633

For others with the same issue due to a different reason: This can also happen when there's a pyproject.toml in the same directory as the setup.py, even when setuptools is available.
Removing pyproject.toml fixed the issue for me.


[BUG] Context menu options (remove, bodygroup, disable collisions) don't work on scalable entities

Short Description
If you try to, for example, change the bodygroup of a scalable weapon, you'll get a console error and nothing will happen. Same goes for if you disable collisions or try to remove it.
Branch and Version
Latest version of master.
Console Error Logs (Optional)
gamemodes/sandbox/gamemode/shared.lua:241: attempt to call method 'IsWeapon' (a boolean value)
  1. Call - gamemodes/sandbox/gamemode/shared.lua:241
   2. Filter - lua/autorun/properties/collisions.lua:13
    3. Receive - lua/autorun/properties/collisions.lua:32
     4. func - lua/includes/modules/properties.lua:173
      5. unknown - lua/includes/extensions/net.lua:33

Fixed on 81e4d2e, ACF weapons used a flag called ENT.IsWeapon. Since they're scalable entities that use the custom __index metamethod, said flag was getting priority over the ENT:IsWeapon method.


Get rid of ErrorNodes and fix corner case bug in replace

In the recent implementation of Pipeline we introduced ErrorNode <: AbstractNode as a mechanism for throwing errors when an UnsupervisedPipeline did not support inverse_transform. This is not part of the public API.
This PR:

Get's rid of ErrorNodes by allowing one to instead wrap an Exception object in an ordinary Source node. Calling the node in that case always throws the exception . This is a minor conceptual simplification. It also makes the next fix a little more straightforward.

Fixes a bug in replace. This is an internal method used only for composite models exported using @from_network. The bug concerns the corner case where an "operation node" is also a Source node, and when there were previously ErrorNodes.

Some details. The main change to replace is to iterate over all nodes, not just non-source nodes, when progressively reconstructing the network, and to add logic in the loop that stops the loop looking for ancestors in the special case of a Source node.

Codecov Report

Merging #723 (f55e072) into dev (51c486b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #723      +/-   ##
==========================================
+ Coverage   84.87%   84.90%   +0.02%
==========================================
  Files          36       36
  Lines        3352     3351       -1
==========================================
  Hits         2845     2845
+ Misses        507      506       -1

Impacted Files
Coverage Δ

src/composition/learning_networks/inspection.jl
86.27% <ø> (-0.27%)
:arrow_down:

src/composition/learning_networks/nodes.jl
69.65% <ø> (+0.47%)
:arrow_up:

src/composition/models/from_network.jl
96.55% <ø> (ø)

src/composition/learning_networks/machines.jl
90.53% <100.00%> (+0.17%)
:arrow_up:

src/composition/models/pipelines.jl
99.42% <100.00%> (ø)

src/sources.jl
87.50% <100.00%> (-0.50%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c486b...f55e072. Read the comment docs.

Thanks Anthony for your swift reaction.

Can I ask what would happen if we were not to have nodes containing exceptions? It seems to me the only problem is that the inverse_transform would not be defined in the signature but I am not sure why this is a problem?
I like the idea of looping over all nodes. In light of reusing the replace function (or part of) for serialization we might on top of that dispatch the inner working of the loop on the Node type to update the various mappings adequatly. This can be done later on though.
Regarding the potential removal of anonymization, do you mean that we may be able to remove the cache.data field on top of changing at least the return! and update functions? I would be up for it if possible since a serialisable machine will be deprived of any data anyway. However I didn't really have any use case for the anonymization stage in the first place so I might be missing something.

I have found a way to abandon the error-throwing source nodes and so remove more case distinctions. I agree this is a better solution.
I have also relaxed the condition state > 0 for operations called on machines  to state !=0 , which should address your concern at https://github.com/JuliaAI/MLJSerialization.jl/pull/17#discussion_r789005641 . Please confirm this is indeed the case.
I am posting the new commits very shortly.


Implemented fireworks

Also ensures that crafting outputs have their NBT data applied.

Not too sure how to fix that, since technically the firework is within a block.

Implemented firework damage.


Support multiple prebid versions on download page

@rmloveland
ready for re-review

@mkendall07 LGTM - ran it locally, did a download, worked well.


[MAINT] Francesco as BDFL, add Alberto and Mauro

add Fancesco as elected BDFL
add Alberto and Mauro to list of steering council members
update affiliations
update retired steering council members after periods of inactivity

Addresses #8

@francescobanda and @kscipal please let me know if I missed someone.

@francescobanda and @kscipal please let me know if I missed someone.

@ slumnitz this is fine for me


Hit Detection issues for custom DESCANT array

When redefining the geometry of DESCANT in TDescant.cxx, the only hits detected come from the first 19 detectors in the TDescant::gPosition vector.  This is regardless of how I define the rest of the set of vectors.

I have created a mapping from the detectorsims_v10 detector definitions for DESCANT to the detector numbering in the TDescant.cxx file.
DetectorMapping.pdf

Honestly, the issue may be in the mapping; it should be more staightforward in code to manipulate the array.

What do you get if you draw the detector number of the descant detectors?
Something like AnalysisTree->Draw("fDescantHits.GetDetector()") should show hits for detectors from 1 to 70. Otherwise there is an error in NTuple2EventTree that we need to fix.

It definitely shows det# range of [0,19].  The numbering from the sims restarts each time the detector changes colour as we can tell by the dips at 10 and 15 where yellow, green, and then red, blue detector numbering stops.

Okay, in that case you'll need to change in NTuple2EventTree the inside the switch on fSystemID the cases for the difference colours (using individual offsets for each colour) so that the detector number ranges from 1 to 70.

Okay, I'm going to close here.  I chose an arbitrary number scheme to test and it worked out, so I'll refine it now to how I'd like to number the detectors.


Add Regex state trigger

Add support for a trigger that evaluates a string against a regular expression

<triggers:RegexStateTrigger Value="{x:Bind emailTextBox.Text, Mode=OneWay}"
		Expression="^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$"
		Options="IgnoreCase"
		/>

(y)

By which I mean "thumbs up", in Skype-speak...


ASP .NET Core 8 - SQL instrumentation not working

I've an ASP. NET Core Web API (.NET 8) with SqlClientCommands instrumentation. However, SQL commands are not printed to the console or SEQ.
Here is my code:
//Program.cs

public class Program
{
    public static void Main(string[] args)
    {
        Log.Logger = new LoggerConfiguration()
            .MinimumLevel.Information()
            .WriteTo.Console()
            .CreateBootstrapLogger();

        try
        {
            var builder = WebApplication.CreateBuilder(args);

            // Add services to the container.

            builder.Services.AddControllers();
            // Learn more about configuring Swagger/OpenAPI at https://aka.ms/aspnetcore/swashbuckle
            builder.Services.AddEndpointsApiExplorer();

            builder.Services.AddSwaggerGen();

            builder.Host.UseSerilog((hostBuilderContext, loggerConfiguration) =>
            {
                loggerConfiguration
                .MinimumLevel.Override("Microsoft", LogEventLevel.Warning)
                .MinimumLevel.Override("System", LogEventLevel.Warning)
                .Enrich.WithProperty("Application", typeof(Program).Assembly.GetName().Name)
                .WriteTo.Console(Formatters.CreateConsoleTextFormatter(TemplateTheme.Code))
                .WriteTo.Seq("https://myloggingaddress.net", apiKey: "xpto");

                var _ = new ActivityListenerConfiguration()
                .Instrument.AspNetCoreRequests()
                .Instrument.SqlClientCommands()
                .TraceToSharedLogger();
            });

            var app = builder.Build();

            // Configure the HTTP request pipeline.
            if (app.Environment.IsDevelopment())
            {
                app.UseSwagger();
                app.UseSwaggerUI();
            }

            app.UseHttpsRedirection();

            app.UseAuthorization();

            // Log all requests to serilog
            app.UseSerilogRequestLogging();

            app.MapControllers();

            app.Run();
        }
        catch (Exception ex)
        {
            Log.Fatal(ex, "An unhandled exception occured during startup");
        }
        finally
        {
            Log.CloseAndFlush();
        }
    }
}

// WeatherForecastController.cs

[ApiController]
[Route("[controller]")]
public class WeatherForecastController : ControllerBase
{
   private static readonly string[] Summaries = new[]
   {
       "Freezing", "Bracing", "Chilly", "Cool", "Mild", "Warm", "Balmy", "Hot", "Sweltering", "Scorching"
   };

   private readonly ILogger<WeatherForecastController> _logger;

   public WeatherForecastController(ILogger<WeatherForecastController> logger)
   {
       _logger = logger;
   }

   [HttpGet(Name = "GetWeatherForecast")]
   public async Task<IEnumerable<WeatherForecast>> GetAsync()
   {
       _logger.LogInformation("Called GetWeatherForecast");
       var client = new HttpClient();
       var content = await client.GetStringAsync("https://example.com");
       var connectionString = new SqlConnectionStringBuilder("Server=localhost;Database=MyDatabase;Integrated Security = true;").ConnectionString;
       using (var connection = new SqlConnection(connectionString))
       {
           await connection.QueryAsync("SELECT 1");
       }

       return Enumerable.Range(1, 5).Select(index => new WeatherForecast
       {
           Date = DateOnly.FromDateTime(DateTime.Now.AddDays(index)),
           TemperatureC = Random.Shared.Next(-20, 55),
           Summary = Summaries[Random.Shared.Next(Summaries.Length)]
       })
       .ToArray();
   }
}

Console output:

SEQ output:

If I use the same logger configuration in a console application, everything works as expected:
//Program.cs

static async Task Main(string[] args)
{
    Log.Logger = new LoggerConfiguration()
        .Enrich.WithProperty("Application", typeof(Program).Assembly.GetName().Name)
        .WriteTo.Console(Formatters.CreateConsoleTextFormatter(TemplateTheme.Code))
        .WriteTo.Seq("https://myloggingaddress.net", apiKey: "xpto")
        .CreateLogger();

    // External trace sources will be enabled until the returned handle is disposed.
    using (var _ = new ActivityListenerConfiguration()
       .Instrument.AspNetCoreRequests()
       .Instrument.SqlClientCommands()
      .TraceToSharedLogger())
    {
       using var activity = Log.Logger.StartActivity("Main");

        Log.Information("Hello, {Name}!", Environment.UserName);
        var client = new HttpClient();
        var content = await client.GetStringAsync("https://example.com");
        var connectionString = new SqlConnectionStringBuilder("Server=localhost;Database=MyDatabase;Integrated Security = true;").ConnectionString;
        using (var connection = new SqlConnection(connectionString))
        {
            await connection.QueryAsync("SELECT 1");
        }

        activity.Complete();
    }
    Log.CloseAndFlush();
    Console.ReadLine();
}

Console output:

SEQ output:

Hi! I pasted your code into a .NET 8 web app and it works for me -

I'm assuming that your "QueryAsync" call is a Dapper one, and that you're definitely using Microsoft.Data.SqlClient and haven't inadvertently added a using statement for the older System.Data.SqlClient, which SerilogTracing doesn't (currently) support.
Perhaps dotnet new console and pasting in the code sample will work for you?
Here are the packages my repro is using:
  <ItemGroup>
    <PackageReference Include="dapper" Version="2.1.35" />
    <PackageReference Include="microsoft.data.sqlclient" Version="5.2.1" />
    <PackageReference Include="serilog.aspnetcore" Version="8.0.1" />
    <PackageReference Include="serilog.sinks.console" Version="6.0.0" />
    <PackageReference Include="serilogtracing.expressions" Version="2.0.0" />
    <PackageReference Include="serilogtracing.instrumentation.aspnetcore" Version="2.0.0" />
    <PackageReference Include="serilogtracing.instrumentation.sqlclient" Version="2.0.0" />
  </ItemGroup>

I'm assuming that your "QueryAsync" call is a Dapper one, and that you're definitely using Microsoft.Data.SqlClient and haven't inadvertently added a using statement for the older System.Data.SqlClient, which SerilogTracing doesn't (currently) support.

Yes, I am using Dapper and you were correct, I was using the older System.Data.SqlClient instead of Microsoft.Data.SqlClient. After switching to the Microsoft one, it started working correctly!
Thanks!


Add additional sort options to Top Hits Aggregation

Top Hits Aggregation fluent lambda syntax constrains sort options to field sorting, even though ITopHitsAggregation can accept any implementation of ISort.
Update TopHitsAggregation usage test to call the new Sort method.
Fixes #2913

Port to master and remove the [Obsolete]ed Sort method


QbitNinja not return Balances

Hi Nicolas, My 5 stars. Its totally a wondrous wrapper besides some glitches. Enjoyed playing with it. 👍
see below urls
Qbitninja goes out of sync??
https://tapi.qbit.ninja/balances/mpqChjGscZ5GqZX5XjSiDojvCmcuQLC7WT
blocktrail
https://www.blocktrail.com/tBTC/address/mpqChjGscZ5GqZX5XjSiDojvCmcuQLC7WT/transactions.
Planning to use qbitninja for mainnet transactions. should i rely on qbit.ninja or should i deploy qbitninja server on my own azure services. Can i deploy it on other windows vps (not azure/ storage or VM)?

yes it seems qbit ninja testnet is out of sync, restarting the indexer, something seems off.

Restarted it. Seems fine now.

Ok so the public qbitninja server have no guarantee of reliability, so for anything in prod, you should host your own.
You need at least to run the indexer on Azure (good latency needed for indexing things fast enough). You can run front end anywhere you like though.

Indexer is hard coupled with azure, I think  can it be modified ( in code/ clases) to make use of sql server as back end storage n indexing . And How much  effective it ll be if done so as compared to azure.
I need to index a few thousands collection of address n transactions , need brodcast function .Not to be exposed publicly. Gone through nbxplorer , it also doesnt fit in here. Own my privte server to want tohost there.

modifying it to work fast enough on a SQL database is major work. The index schema is very coupled with internal implementation details of Azure so that queries are fast.
NBXplorer is lightweight, while still have bugs to iron out, it HD keys, and you can retrieve transactions which got tracked.

Thanks a lot.

It seems Qbit ninja is down again????

it seems so, checking it.

Should be good now, can you check?

Yes synced n running Thanks :)


#6489 padding

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[ ] Feature
[x] Refactoring

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #6489
[ ] Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed UI

Copilot Summary

Comes from #6457, landing page should be using 'full-width-layout'

@roiLeo what do you mean?

@prachi00 you should use full-width-layout on landing page and it will fix this issue. Check old code before vue3 migration on the page.

@prachi00 you should use full-width-layout on landing page and it will fix this issue. Check old code before vue3 migration on the page.

done

it affected other elements as well:

it affected other elements as well:

@roiLeo I guess the previous fix was better then?

it affected other elements as well:

Are you sure it is related with this PR? Looks weird as I can only see changes related to landing page

it affected other elements as well:

Are you sure it is related with this PR? Looks weird as I can only see changes related to landing page

i don't know what the heck happened, i opened again now and its working properly
checked all the other PRs to see if was one of them and found nothing

it affected other elements as well:

Are you sure it is related with this PR? Looks weird as I can only see changes related to landing page

i don't know what the heck happened, i opened again now and its working properly checked all the other PRs to see if was one of them and found nothing

um okay with me 😂


Upgrade to Gradle 5.2.1

Upgrading to Gradle 5.2.1

Coverage remained the same at 86.253% when pulling 0b289cf8ddfdf060509002f81f0204db75f512f7 on stefan-zh:feature/gradle-5.2.1 into 9116c573641d77726b020b308c31f9726a5788fb on conradoqg:master.

wrong target


fix: defaults.redirect never honored

Looks like a bug related to operator priority, or logic.

Thanks for merging!


Use homebrew for python

This will hopefully cut 8~10min off the mac CI times.
Depends on #199.

bors r=nbraud

bors r+

bors r+

Rebased to deal with merge conflict.
bors r+


Upgrade Arcmutate 1.1.0 -> 1.1.1

This PR contains the following updates:

Package
Type
Update
Change

Arcmutate
build
patch
1.1.0 -> 1.1.1

[ ] If you want to rebase/retry this PR, check this box

Warning
Renovate's suggested commit message is being replaced with improved initial commits to enable automerging. As a side effect, these suggested commit messages might have changed. Consider comparing the initial commit message and this message to determine the most suitable one. Please leave feedback in #sys-renovate.

Suggested commit message:
Upgrade Arcmutate 1.1.0 -> 1.1.1


Feature Request: Enable players to see (But not edit) their stealth/perception numbers on HUD

The stealth & perception numbers only show up for the GM - it would be nice if players could see the stealth and perception numbers on their controlled tokens (but not edit those numbers)

This one has a decent chance of getting done once I work through all the vision-5e interactions. Not committing yet but is likely.

It's in 3.15.0


Remove unnecessary state update and fix 0 flip issue

My first Open-Source PR. Thanks, @bluebill1049


Export issue when using anisotropic data

Spline segmentation exporter does not work as intended (?).
When using anisotropic data the data is converted to isotropic for display, and the annotated points are saved in that space to the database. During spline segmentation export, the images are copied from disk (as anisotropic) and the segmentation mask is created with the anisotropic image shape while the point coordinates are isotropic. This will cause a shift that badly effects the segmentation mask.
Some potential solutions:

Check if image is anisotropic on export, and convert coordinates
Convert image from anisotropic to isotropic when exporting

The cardiac task has a fix for this: https://github.com/smistad/annotationweb/blob/master/exporters/cardiac_segmentation_exporter.py#L180
But I think it might be better to draw in isotropic space, which is what the user saw, and then resample the segmentation to the original anistropic space afterwards. Otherwise the splines might not be drawn in the exact same way the user saw it.

I fixed this issue (see https://github.com/jpdefrutos/annotationweb/commit/13795d14bbb0993cb725ba488562449c7f8ca971). I can PR the solution.
The fix included what you mentioned on the cardiac_segmentation_exporter, and also exposing the attribute 'Offset' on the MetaImage object to correctly align the segmentation and the image


Return a 400 when a request body can't be decompressed

Problem:
Currently, making a request with content-encoding set to gzip (or deflate) with content that's either not gziped, corrupt, or truncated results in a 500 because the exception from GZipInputStream is never handled.
Solution:
Gzip request decompression is handled by BiDiGzipHandler. This change decorates the GZipInputStream it creates so that ZipException and EORException are handled, and the exception is propagated as a Jersey BadMessageException. Similar changes were made to handle
deflate.
Result:
Making a request like
echo plaintext | curl -X POST -d @- http://localhost:8080/endpoint

will return a 400 rather than a 500. Additionally, ZipExceptions won't be logged as unhandled exceptions.

Could someone look at codeclimate? It's getting to the point where it's making the test less readable.

Could someone look at codeclimate? It's getting to the point where it's making the test less readable.

It looks like you are all set! I agree that sometimes codeclimate is too aggresive in its analysys.

Thank you for the contribution!

Cherry-picked to the 1.2.x branch as b70492524190201d394a2c16941098d1054305eb


Fix CI

Extract from https://github.com/go-gitea/gitea/pull/32057/files
Replace #32044

@lunny please fix the merge conflicts. :tea:

I think the CI was broken again

unable to open tcp connection with host 'mssql:1433': dial tcp <IP_ADDRESS>:1433: connect: connection refused


Allow configurable key bindings to any task

For instance. I would like to assign key binding to any task
Other than just test and build.
for instance
  {
    "key": "ctrl+shift+1",
    "command": "workbench.action.tasks.task1"
  }

This is actually a nice idea to solve this.
@alexandrudima can I have arguments to a command in the key bindings file. I would like to name the action workbench.actions.task and then have an argument "task1"

@alexandrudima ping...

Moving. Was very busy with the TS builder exploration.

@dbaeumer Not yet, but it is something I wanted to do since more than 1 year. :)

@codyrigney92 is working on this here: #10676, but PR is not ready yet. Moving to September.

No progress on the pull request. Moving to October.

No progress on PR. Moving to November

@dbaeumer There is progress on the PR, will we be taking this for the current milestone or pushing to Jan 2017?

Unfortunately I was not able to get this into November given the LSP work I had to do. For January we want to completely revisit the way tasks work. See the discussion here: #15179. I will make sure that this will make it into the new design.

tracking at stackoverglow: http://stackoverflow.com/questions/41510632/how-can-i-run-a-custom-task-different-from-test-or-build-from-a-keychord-in-vs/41512460#41512460

I re-implemented the task execution engine for Jan to use the terminal instead of the output window. Although not the default yet I will wait until the switch is final to provide support for this request With the new engine this needs more thinking since the new engine support executing tasks in parallel and to compose task out of smaller tasks. I first need to finalize the syntax in the tasks.json for this before allowing to bind key bindings for the composite tasks. Otherwise I might break clients unnecessarily.

This will be available in the next version of VS Code.
	{
		"key": "ctrl+h",
		"command": "workbench.action.tasks.runTask",
		"args": "tsc"
	}

This is just outstanding...VSCode becoming gold std. IDE.

Agreed, this opens up a lot of options for me!

@dbaeumer is this implemented in 1.11? There was suggesting on #10676 that it was due in 1.10.
Does seem to work as per docs:
https://code.visualstudio.com/docs/editor/tasks#_binding-keyboard-shortcuts-to-tasks

This is in but there seems to be problems with it for 1.11.x. I have a bug for it and will investigate.

Thought i was going crazy. Thanks @dbaeumer

The solution is not what @justin-romano asked for. Why is this issue closed?


Fix static routes registration on a blueprint

Adds ability for app.static() to return the routes it created.
This allows blueprint registration to add the bp's static routes to its list of own routes.
So now blueprint middlewares will apply to a blueprint's static file routes.
Fixes #1953

AppVeyor is failing on test_loaded_module_from_file_location_name I don't know if thats expected, I don't think its related to changes in this PR.

@ashleysommer That test is broken. Looks like a problem with how it was written and is out of the scope for this PR. I am merging and ignoring that for now.


decouple observables from assets

This PR decouples the type used to represent assets that can be delivered from observables.
The main reason why I think this makes sense is that observables are a much bigger set than assets and are generally non-deliverable. For instance, we wish to observe a Libor rate but can't deliver it.
This is a breaking change

Hey @matteolimberto-da . I was thinking about this and trying to recall why I made this change originally (previously they were distinct types).
I'm thinking it boils down to pricing. Say I want to value a bond. On the leaves, I will have One "USD" for example. Now the thing is, when this gets converted to a formula, I will have something in terms of an expectation E[ ... USD ..], so I need to be able to convert from the asset to an observation in Reals. If I have the same type, then I will be able to lookup the USD value. If not, then how do I do this?
Does that sound reasonable to you? It's been a while since I did this, and I'm struggling to remember the motivation. Does the above sound logical?

Let's raise a ticket for this instead, to not block the PR. As the pricing
module is clearly marked experimental, I don't see any issue changing it
later.
On Tue, Jun 7, 2022 at 9:41 AM Matteo Limberto @.***>
wrote:

@.**** commented on this pull request.
In daml/ContingentClaims/Math/Stochastic.daml
https://github.com/digital-asset/contingent-claims/pull/88#discussion_r890870124
:

  -> (a -> a -> Process t)

  -- ^ Given an asset and a currency, it returns the value process of the asset expressed in units of currency

-> (o -> a -> Process t)

Happy to get back to you after putting some thought into this. Would you
see it as part of this PR or should I rather raise an issue and address
this separately?
—
Reply to this email directly, view it on GitHub
https://github.com/digital-asset/contingent-claims/pull/88#discussion_r890870124,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMYA3GURFEXE3TULUB7GMDLVN34K7ANCNFSM5XNOCYYQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
This message, and any attachments, is for the intended recipient(s) only,
may contain information that is privileged, confidential and/or proprietary
and subject to important terms and conditions available at
http://www.digitalasset.com/emaildisclaimer.html
http://www.digitalasset.com/emaildisclaimer.html. If you are not the
intended recipient, please delete this message.

Let's raise a ticket for this instead, to not block the PR. As the pricing module is clearly marked experimental, I don't see any issue changing it later.
…
On Tue, Jun 7, 2022 at 9:41 AM Matteo Limberto @.> wrote: @.* commented on this pull request. ------------------------------ In daml/ContingentClaims/Math/Stochastic.daml <#88 (comment)> : > -> (a -> a -> Process t) + -- ^ Given an asset and a currency, it returns the value process of the asset expressed in units of currency + -> (o -> a -> Process t) Happy to get back to you after putting some thought into this. Would you see it as part of this PR or should I rather raise an issue and address this separately? — Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMYA3GURFEXE3TULUB7GMDLVN34K7ANCNFSM5XNOCYYQ . You are receiving this because you were mentioned.Message ID: @.***>
-- This message, and any attachments, is for the intended recipient(s) only, may contain information that is privileged, confidential and/or proprietary and subject to important terms and conditions available at  http://www.digitalasset.com/emaildisclaimer.html http://www.digitalasset.com/emaildisclaimer.html. If you are not the intended recipient, please delete this message.

Thanks, I raised https://github.com/digital-asset/contingent-claims/issues/89 to address it.


Lost @rel_var alias when using QueryProxy#branch

Using #branch causes the @rel_var of the initial QueryProxy to be lost

@history.students(:student, :enrolledIn).rel_var => :enrolledIn
@history.students(:student, :enrolledIn).branch { all }.rel_var => :rel2
I suppose that bug is present in all versions.

the issue is there even without using custom variables
@history.students..all.brach { all }.to_a(false, true)

throws an exception


fix(semantic): transform checker check symbol IDs

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5078  👈
#5076
#5075
#5074
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


go.mod requires a patch version

Currently go modules just grabs the latest commit because your SemVer tags don’t include a patch version. Changing the tags from v3.1 to v3.1.0 should fix it, I think.

It looks like modules also requires for major versions 2+ that the module path and package import path contain the major version number, e.g. ‘module github.com/ericlagergren/decimal/v3’, so this might be a bit more involved :-/

I can confirm, if you release as a v3 library, your go.mod file would need to start with module github.com/ericlagergren/decimal/v3 and your semver tag would need to be something like v3.1.0.
However, if this is the first getable tag for go modules, maybe just reset back to v1.3.1 and keep the module name as is?

Hm. So, I've already released v3.2 but I haven't included go.mod in a release so yet (14 commits separate v3.2 from HEAD).
Is it possible to release v.3.3.0 with a v3/ directory that contains the requisite go.mod file?

You don't need, but can use, a sub-directory. I would avoid it.
The v3 at the end of the module path will be ignored by the older versions that have been patched. So you can safely make the module path end in a /v3 tag v3.3.0 in place (no moving files).
I don't see a reason to bump to v4 unless you have some breaking change, which it doesn't look like you have.

Awesome, thanks @kardianos.

(I guess this means I should go and re-read the modules docs.)

Readme (current version) might be out of date.
On Sun, Dec 9, 2018 at 10:41 PM Eric Lagergren<EMAIL_ADDRESS>wrote:

Closed #111 https://github.com/ericlagergren/decimal/issues/111 via
7f7cf8a
https://github.com/ericlagergren/decimal/commit/7f7cf8a362e5c45851ebbf009274d2ed8a2c88a7
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ericlagergren/decimal/issues/111#event-2015061092,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAuFsR2Uv-akx-_2htgV47BZdqDg1Q2Eks5u3gIqgaJpZM4YJbF_
.


Decouple production code and experimental code/package

At the moment, to run any model (e.g. xlinear) in production, we need to install the whole package. This is probably not ideal, and blows up the size of the docker container. It would be good to have a minimal code just for the a production model.

@nsorros

Totally agree. I wonder to which extent two repos are needed. One for experimentation and one for production with different "requirements", one with more libraries and less optimised, the other less heavy.
Otherwise it could happen in this repo as well but the code would need to be decoupled and we would need maybe a light setup.py and a more heavy requirements.txt to be used for experimentation

We are addressing that in #246


Enable keyboard shortcuts

All of Joplin can be used without touching the mouse. I do this with all apps that have tabs. However, this plugin with this key feature would be super productive! 🎉
Common shortcuts:

Ctrl+tab: switch to last active tab.
Ctrl+pgup: previous tab.
Ctrl+pgdown: next tab.

However, they should be configurable like most others in Joplin.

Hi! I came here to write about the same thing. ;-)
I don't know if this is a feature of Joplin or this plugin, but only one menu item in this plugin ("Pin note to Tabs") is available for customizing hotkeys. Maybe the problem of the inability to configure hotkeys will be solved by adding the accelerator property to each plugin menu item. For example, as described in that message. But I'm not familiar enough with Javascript development to try modifying the plugin.
However, I found anyone available solution. You need to create or modify file keymap-desktop.json in the same directory where file settings.json is located and write the following into it:
[
  {
    "command": "tabsSwitchLastActive",
    "accelerator": "Ctrl+Tab"
  },
  {
    "command": "tabsSwitchLeft",
    "accelerator": "Ctrl+PageUp"
  },
  {
    "command": "tabsSwitchRight",
    "accelerator": "Ctrl+PageDown"
  }
]

...create or modify file keymap-desktop.json in the same directory where file settings.json is located...

Thank you! This works great. On OSX, the location is ~/.config/joplin-desktop/, and you'll probably want to map to "Cmd+Shift+[" and "Cmd+Shift+]".


Add another PNG crusher

OptiPNG doesn't seem to do as well as AdvPNG. We should look at porting AdvPNG over.

Candidates:

https://github.com/google/zopfli (slow but high compression. Not sure if it switches palette modes, so may need to be run through another crusher first).
https://github.com/shssoichiro/oxipng Multithreaded and Rust version of optipng.
AdvPNG - Old messy project but seems to be a good trade off in terms of speed and size reduction.
https://github.com/fhanau/Efficient-Compression-Tool scores well in https://css-ig.net/png-tools-overview, but as far as I can tell, it's just a wrapper around other tools.

Maybe something like pngquant (https://pngquant.org/) can be interesting for lossy PNG compression. It feels like squoosh is especially good for lossy compression since it makes it easy to compare the before and after pictures.

@tobiasdubois the "reduce palette" preprocessor uses libquant which powers pngquant. We seperated it so you can use it with webp lossless too (you can also use it with jpeg, but there isn't a lot of point).

Would love to see a quantization option with palette reduction on the output... huge benefits in many cases.

@tracker1 Squoosh already offers that. It’s under “Reduce palette”

Just to add one more compressor that isn't listed above: PNGWolf. Code on Github: https://github.com/hoehrmann/pngwolf.

I think we are all quite happy with Oxi :D


Replace TypeVar with Optional

Codecov Report

Merging #224 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   77.23%   77.22%   -0.01%
==========================================
  Files          54       54
  Lines        3119     3118       -1
  Branches      512      512
==========================================
- Hits         2409     2408       -1
  Misses        683      683
  Partials       27       27

Impacted Files
Coverage Δ

colcon_core/subprocess.py
48.36% <100%> (-0.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af5b886...704a27b. Read the comment docs.


feat(proof_data_handler): add new endpoints to the TEE prover interface API

What ❔
This PR introduces three new endpoints to the prover interface API:

/tee/proof_inputs - for fetching input data for the TEE verifier. It is intended for TEE workers to obtain a batch to process.
/tee/submit_proofs/<l1_batch_number> - for submitting TEE proof.
/tee/register_attestation - for registering TEE attestation.

The first two introduced API endpoints correspond to the existing, analogous /proof_generation_data and /submit_proof/<l1_batch_number> endpoints used for the ZK proofs.
The state of batches (e.g., proven, taken, etc.) is tracked in the database. The TeeVerifierInputProducer generates serialized TEE prover inputs, which are then stored in the object store.
To run the unit tests, you need to use the following command: zk test rust --package zksync_proof_data_handler --lib tests. Running cargo test directly fails because the zk command sets up an additional database for testing purposes.
To test it manually, run the ZK server with the command:
zk server --components proof_data_handler --use-node-framework

and then send an HTTP request:

to get TEE verifier input data:curl -X POST -H "Content-Type: application/json" --data-raw "{}" -vvv http://<IP_ADDRESS>:3320/tee/proof_inputs

register TEE attestation:curl -X POST -H "Content-Type: application/json" --data-raw '{ "attestation": [ 4, 3, 2, 1, 0 ], "pubkey": [ 5, 6, 7, 8, 9 ] }' -vvv http://<IP_ADDRESS>:3320/tee/register_attestation

to submit TEE proof:curl -X POST -H "Content-Type: application/json" --data-raw '{ "Proof": { "signature": [ 0, 1, 2, 3, 4 ], "pubkey": [ 5, 6, 7, 8, 9 ], "proof": [ 10, 11, 12, 13, 14 ] } }' -vvv http://<IP_ADDRESS>:3320/tee/submit_proofs/1

To inspect the database for the updated proof, run:$ PGPASSWORD='notsecurepassword' psql -h <IP_ADDRESS> -p 5432 -U postgres
# \c zksync_local
# SELECT * FROM tee_proof_generation_details WHERE l1_batch_number = 1;

to skip proof generation for the given batch number:$ curl -X POST -H "Content-Type: application/json" --data-raw '{ "SkippedProofGeneration": null }' -vvv http://<IP_ADDRESS>:3320/tee/submit_proofs/1

Why ❔
This PR contributes to the effort outlined in the docs:

https://www.notion.so/matterlabs/2FA-for-zk-rollups-with-TEEs-a2266138bd554fda8846e898fef75131?pvs=4
https://www.notion.so/matterlabs/Proof-2F-verification-with-SGX-5fca2c619dd147938971cc00ae53e2b0?pvs=4

Checklist

[x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[x] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.
[ ] Code has been formatted via zk fmt and zk lint.
[ ] Spellcheck has been run via zk spellcheck.

@thomasknauth @haraldh @RomanBrodetski This PR is ready for the first round of reviews. You can find the details on how to run and test it manually or automatically here. Feel free to comment and add other reviewers. Thanks.

Just came across a doc suggesting we will introduce the /proof_generation_data/verified endpoint to provide proofs that Matter Labs has already created. AFAIK, we haven't decided whether to add this endpoint yet.

@slowli @popzxc @RomanBrodetski I put quite an effort into implementing tests using ObjectStoreFactory::mock(). I just rebased my branch on the latest origin/main and noticed that you removed mock() @slowli. 😢 Quote from https://github.com/matter-labs/zksync-era/commit/5c0396441ea5383da322670a57ca0392d2a647fa git message:
(...)
- Expose GCS, file-based and mock object stores directly and remove
ability to create mock object stores from `ObjectStoreFactory`
(...)

Any recommendation?

@pbeza as commit message mentions, mock storage factory is now exposed directly, e.g. as MockObjectStore, you can see sample usage in the same PR as you linked.

@popzxc All the issues resolved and CI passing. 🫡 Ready to merge?

@popzxc @RomanBrodetski CI checks are passing, and manual tests have been successfully redone. From my perspective, it's ready to merge. ✅
There is just one outstanding comment that I need to clarify if you think it's critical to resolve before merging.

@popzxc @RomanBrodetski Again: CI checks are passing, and manual tests have been successfully redone. From my perspective, it's ready to merge. ✅
Sorry for the mess with rebasing and force pushing. I didn't expect it to make incremental code review harder. I will merge instead of rebase next time.

@popzxc @RomanBrodetski are we good to merge? This is my first PR to be merged, so I'm not sure about the process. How many reviewers need to approve it before we can merge?

@pbeza generally up to the reviewee. If your PR is approved, you are free to merge, but it's not uncommon

either for the reviewer to suggest waiting for a 2nd review (e.g. if reviewer doesn't feel confident about some part of the diff), or
for the reviewee to ask for more reviews (e.g. if the change is complex and they want more eyes to at least skim through it).

So overall, we trust people to decide what would be the safest and most productive approach.

Got it, I didn't have permission to merge, which is why I asked. Thanks for the clarification.


Importing pod-styles in an addon

I have an addon with pods, each pod has its own styles.scss file.
I was trying to import with @import pod-styles; but when I try and build the app consuming the addon I get: File to import not found or unreadable: pod-styles
Thanks for your time.
PS: I noticed https://github.com/ebryn/ember-component-css/issues/46 , is it still the case that I need to put the stylesheets in the app tree?

Ii resolved this by changing my import path:
// app.scss
@import "../../pod-styles";

I'm having issues using this inside an addon as well. Any updates?

@Bockit @ivanvanderbyl @rwwagner90 Just released a 0.2.1 version. This should work with inside of addons now. Please give it a try and file a new bug if you are still having issues, but I hope you will no longer be!


Slow indexing after login

[x] I have read through the manual page (man fzf)
[x ] I have the latest version of fzf
[ x] I have searched through the existing issues

Info

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[x] bash
[ ] zsh
[ ] fish

Problem / Steps to reproduce
The first time I use fzf after a fresh login it takes time to index files and dirs. This only happen the first time I use it in a login session. Then even if I shut down the terminal, the next time I open a terminal and I do 'CTRL + T' it immediately starts to find stuff. There is any method to ensure that this indexing is performed at login?

See:

#763
#1284
#2550

It's faster on the second run, not because fzf caches the result, but because your operating system has cached the structure of the file system.


Field order incorrect in Detail view

I've set up my field like this:
Repeater::make('Addresses', 'addresses')
->addField([
'label' => 'Label',
'name' => 'label',
'placeholder' => 'Label/Department',
'type' => 'text'
])
->addField([
'label' => 'Street',
'name' => 'street',
'type' => 'text'
])
->addField([
'label' => 'Zip',
'name' => 'zip',
'type' => 'text'
])
->addField([
'label' => 'City',
'name' => 'city',
'type' => 'text'
])
->addField([
'label' => 'Country',
'name' => 'country',
'type' => 'text'
])
->addButtonText('Add Address')
->summaryLabel('Addresses')
->hideFromIndex()
,
But in Detail view the fields are in a strange order
Zip:
City:
Label:
Street:
Country:

Hi @tanthammar - sorry for slow reply and thanks for the bug report.  I'll see if I can replicate this and get back to you.  Can't see a good reason off the top of my head as the fields are pushed into an array so the order should be respected.  The kind of behaviour you're seeing might make sense if they were in an object where order is not necessarily respected.  Will see if I can track this one down

@tanthammar I'm afraid I can't replicate this.  I copied your field config in your original message and the fields show up in the correct order in all views.  This is what I see on the detail (and index) views:

If you can supply more information if you're still having issues then I'm happy to reopen this


Error: Processing the pdf failed due to excess load. Please try again later.

Hey,
Thank you for your cool project!
I wanted to try it out and got the following error:
Error: Processing the pdf failed due to excess load. Please try again later. Check the URL if there is https:// at the beginning. If not, add it.
Is this normal?

I have the same too

I have the same problem using the 'main-local.py'

I have the same too, while using the 'main-local.py'

Me too.

Me too.

so how to solve it

me too

Hi @nature1949 @lxd941213 @matriim @Abandon339 @yeloveyou @MrPeterJin @Abandon339 @Xin-GY @fatboy1994  please make sure you are on a secure connection (Check the URL of the app https:// at the beginning. If not, add it.) Or just go to this link here.
If you are still facing this issue it may be because the demo is overloaded due to too many people using it at the same time.
Unfortunately because of the fact that the demo runs everything locally in your browser (due to privacy and security reasons regarding keeping the open ai key local) it is really hard for me to debug what the issue is.
To figure out what's going on you would need to open the network tab in the inspect tool and see which call is failing. Let me know if you're able to do this and I can help figure out what's going wrong. Thanks :)

Hi @nature1949 @lxd941213 @matriim @Abandon339 @yeloveyou @MrPeterJin @Abandon339 @Xin-GY @fatboy1994 please make sure you are on a secure connection (Check the URL of the app https:// at the beginning. If not, add it.) Or just go to this link here.
If you are still facing this issue it may be because the demo is overloaded due to too many people using it at the same time.
Unfortunately because of the fact that the demo runs everything locally in your browser (due to privacy and security reasons regarding keeping the open ai key local) it is really hard for me to debug what the issue is.
To figure out what's going on you would need to open the network tab in the inspect tool and see which call is failing. Let me know if you're able to do this and I can help figure out what's going wrong. Thanks :)

I'm not a native English speaker, apologize for my language problem. My friend and I run the demo locally, and upload local pdf. We also have this problem. We tried to find the problem.
I changed the port 8080 to 5000. When I upload pdf, there would be a http error 500.

More specific error is "SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data"

This is the the part of the js that may be buggy.

I donot learn much about js, but there must be something wrong with the "process_pdf" in static/js/script.js

Hi @nature1949 @lxd941213 @matriim @Abandon339 @yeloveyou @MrPeterJin @Abandon339 @Xin-GY @fatboy1994 please make sure you are on a secure connection (Check the URL of the app https:// at the beginning. If not, add it.) Or just go to this link here.
If you are still facing this issue it may be because the demo is overloaded due to too many people using it at the same time.
Unfortunately because of the fact that the demo runs everything locally in your browser (due to privacy and security reasons regarding keeping the open ai key local) it is really hard for me to debug what the issue is.
To figure out what's going on you would need to open the network tab in the inspect tool and see which call is failing. Let me know if you're able to do this and I can help figure out what's going wrong. Thanks :)

I'm not a native English speaker, apologize for my language problem. My friend and I run the demo locally, and upload local pdf. We also have this problem. We tried to find the problem. I changed the port 8080 to 5000. When I upload pdf, there would be a http error 500.  More specific error is "SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data"  This is the the part of the js that may be buggy.  I donot learn much about js, but there must be something wrong with the "process_pdf" in static/js/script.js

我在本地搭建成功了，如果你和我一样，用了clash for windows，你可以尝试在clash中的setting->System Proxy->Specify Protocol开启即可

Hi @nature1949 @lxd941213 @matriim @Abandon339 @yeloveyou @MrPeterJin @Abandon339 @Xin-GY @fatboy1994 please make sure you are on a secure connection (Check the URL of the app https:// at the beginning. If not, add it.) Or just go to this link here.
If you are still facing this issue it may be because the demo is overloaded due to too many people using it at the same time.
Unfortunately because of the fact that the demo runs everything locally in your browser (due to privacy and security reasons regarding keeping the open ai key local) it is really hard for me to debug what the issue is.
To figure out what's going on you would need to open the network tab in the inspect tool and see which call is failing. Let me know if you're able to do this and I can help figure out what's going wrong. Thanks :)

I'm not a native English speaker, apologize for my language problem. My friend and I run the demo locally, and upload local pdf. We also have this problem. We tried to find the problem. I changed the port 8080 to 5000. When I upload pdf, there would be a http error 500.  More specific error is "SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data"  This is the the part of the js that may be buggy.  I donot learn much about js, but there must be something wrong with the "process_pdf" in static/js/script.js

我在本地搭建成功了，如果你和我一样，用了clash for windows，你可以尝试在clash中的setting->System Proxy->Specify Protocol开启即可

十分感谢，我一直用CFW，因为要连接OPEN AI，所以要一直开代理，原来是访问本机地址没有协议头导致的500error。太感谢你了

谢谢，我也回去试试。估计问题是一样的，我也是在运行本地配置的时候出现了问题

我cfl已经设置了指定协议 但是还是在报500错误 有什么办法吗

I have the same issue but I'm running localy: <IP_ADDRESS>:8000
Error: Processing the pdf failed due to excess load. Please try again later. Check the URL if there is https:// at the beginning. If not, add it.
I've just loaded 2 documents.
Phil


features.txt == mdel.txt??? what is model.txt?

model.txt is what gets loaded by the script, features.txt is just a list of possible features one can use in model.txt


Suggest

I hope you can provide the traditional PHP installation method, I will not use composer, I believe there are many people who also do not use composer. This source is good, but unfortunately I can't install it.

You could use composer on your local machine and upload the folder to the server.

You could use composer on your local machine and upload the folder to the server.

Thank you for your response, I have uploaded the file to the VPS by unzipping it, but I will not install it.


json-ld frame explainer

Addresses #60 and #62

changed to 80 char lines and added @bumblefudge framing guide

multiple positive reviews, feedback given and incorporated, merging


IdM & IdS using OAuth2 mode

I am trying to set up IdM with Oauth2 mode to authorize using IdS running in the same host.
In IdS I have this scope defined:
new Scope
                    {
                        Name = "idmgr",
                        DisplayName = "Thinktecture IdentityManager",
                        Type = ScopeType.Resource,
                        Emphasize = true,
                        Claims = new[]
                        {
                            new ScopeClaim(Constants.ClaimTypes.Name),
                            new ScopeClaim(Constants.ClaimTypes.Role)
                        }
                    }

The IdM Oauth config looks like this:
OAuth2Configuration = new OAuth2Configuration
                    {
                        AuthorizationUrl = "/connect/authorize",
                        Issuer = "urn:id",
                        ClientId = "implicitclient",
                        SigningCert = Certificate.Get(),
                        Scope = "idmgr",
                        Audience = "/admin"
                    }

Yet, after entering my username and password, the IdSrv (url /connect/authorize) states that "The client application tried to access a resource it does not have access to".
Any ideas?

configured it with securityMode oauth2 not local machine i want to login with registered user in AspNetUser table not with InMemory User. So please give me solution for it.


Issue with etcd  cluster

We have 1.5 cluster running since last year. Today when i was trying to deploy new pods their status showing "Creating container". When checked further i found below errors:
"using network plugins "cni": client: etcd cluster is unavailable or misconfigured; error #0: x509: certificate has expired or is not yet valid\n; error #1: x509: certificate has expired or is not yet valid\n; error #2: x509: certificate has expired or is not yet valid\n; Skipping pod"
Looking at the above errors it seems there is an issue with etcd cluster.
We have 3 node etcd cluster and all the nodes showing similar errors when checking individually  by running "etcdctl member list".
"etcdctl member list
Error:  x509: certificate has expired or is not yet valid
"
As far I remember we haven't updated any certificates anywhere on the cluster.
Any help on providing some insight on the issue would be really  appreciated.
Thanks

keep same key file, but regenerate cert files with new expire period, then redeploy them to nodes

How do we implement it via kube-aws ? Updating in cluster.yml will recreate all the controller, etcd and workers. So go to each server and update certificates ?

Merging a new duplicated issue #1191 to this.
Also see my comment for suggestions.

Hello All,
FWIW, we also had older 1.5 (kube-aws ver: v0.9.3-rc.5) clusters deployed via kube-aws.
Unfortunately we were not able to update the certs via the documented process in kube-aws (regenerate certs then kube-aws update AIR?--of course would need to go back to the old tagged versions README for exact steps)
v0.9.3-rc.5 kube-aws-cluster-updates.md#certificate-rotation
What I saw when trying to update two (2) separate clusters of same versions:
One cluster failed update with only the workers and controllers getting updated and redeployed, but its etcd nodes did not and was left in a hot mess and totally broken.
The second cluster did not complain or throw errors, but apparently didn't update the certs, then when a year came it just dropped off the map--running remote ssh commands on etcd cluster nodes we can validate:
etcdctl cluster-health
cluster may be unhealthy: failed to list members
Error:  client: etcd cluster is unavailable or misconfigured
error #0: x509: certificate has expired or is not yet valid

both clusters were the same ancient versions
cat ./foo-stage-deployment-stats
##### Kube Cluster Provision Details #####
KUBE-CLUSTER-NAME: foo-stage
DATE: 2017-04-25-18:16:44-PDT
KUBE-AWS-VERSION: v0.9.3-rc.5
AMI-ID: ami-b31d43d3

If time permits would like to follow the helpful info on this issue, but we need to redeploy these ancient clusters anyway:
Rotate/update TLS cert key issue #1057
Hope this information is useful

Hello since this just happened to us again decided to script a fix to distribute your updated tls x509 etdc certs JIC it happens again and to hopefully help others out.  Note you should backup your outdated certs on the dest etcd2 nodes before running if you wish to keep them as this script will overwrite them.
Please see:  dist-upated-tls-certs-etcd-nodes.sh


Highlighted fields

Merge the highlight section directly into the documents section.

Let's see if the world burns.


Buggy exit/termination after a couple of iterations

Buggy execution after a couple of iterations. I am running python3.5 on a mac and the model quits. Not sure if this is a compatibility issue with the Py3.5 site packages. Help appreciated! Thanks
Average loss at step  100000 :  4.67189269698
Traceback (most recent call last):
File "", line 1, in
File "/Users/kg/anaconda/lib/python3.5/site-packages/spyderlib/widgets/externalshell/sitecustomize.py", line 699, in runfile
execfile(filename, namespace)
File "/Users/kg/anaconda/lib/python3.5/site-packages/spyderlib/widgets/externalshell/sitecustomize.py", line 88, in execfile
exec(compile(open(filename, 'rb').read(), filename, 'exec'), namespace)
File "/Users/kg/TF/trial_cnn.py", line 243, in
low_dim_embs = tsne.fit_transform(final_embeddings[:plot_only,:])
File "/Users/kg/anaconda/lib/python3.5/site-packages/sklearn/manifold/t_sne.py", line 866, in fit_transform
embedding = self._fit(X)
File "/Users/kg/anaconda/lib/python3.5/site-packages/sklearn/manifold/t_sne.py", line 777, in _fit
skip_num_points=skip_num_points)
File "/Users/kg/anaconda/lib/python3.5/site-packages/sklearn/manifold/t_sne.py", line 832, in _tsne
params, error, it = _gradient_descent(obj_func, params, **opt_args)
File "/Users/kg/anaconda/lib/python3.5/site-packages/sklearn/manifold/t_sne.py", line 387, in _gradient_descent
grad_norm = linalg.norm(grad)
File "/Users/kg/anaconda/lib/python3.5/site-packages/scipy/linalg/misc.py", line 129, in norm
a = np.asarray_chkfinite(a)
File "/Users/kg/anaconda/lib/python3.5/site-packages/numpy/lib/function_base.py", line 1022, in asarray_chkfinite
"array must not contain infs or NaNs")
ValueError: array must not contain infs or NaNs

It looks like your embeddings have NaNs, most likely caused by your model training not being stable, which I suspect is not a TensorFlow bug.  You might get more help on StackOverflow for non-bugs like these (unless you can demonstrate to us that there's a bug here).

Thanks..Will look into it..

This is similar to issue #1839 and possible this is a numpy/scipy issue as reported by @zhongzyd


cargo can now order fax machines

About the PR
Cargo can now purchase fax machines. Included in the crate is a flatpacked fax machine, a screwdriver, and a manual instructing the end user how to set up and use the glorious fax machine. (honestly the screwdriver and manual is just there because so many people seem to be unaware that you can rename fax machines and I wanted to make it obvious.)
Why / Balance
There was no way to get fax machines. If one is destroyed, or if someone wants one for RP and there are no spares, or even if the bartender wants to start taking orders via fax, there was no way to get one (other than theft).
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
None (I hope)
realistically there shouldn't be any
Changelog
:cl:

add: Fax machines can now be purchased at cargo, for when you need more paper pushing on your station!

i thought about making faxes craftable in rnd


Check access token validity without silent sign-in

Unsure if this is a feature request or a question, so apologies.
Right now I'm in a situation where, on my single-page application, a token might get revoked and I would need to refresh the page. I do this by checking to see if I get a 401 back from my API (I control both the API and the auth server, which is a PingFederate OIDC server). If I do, then I call signInRedirect and force them to log in again.
Unfortunately there are a few situations arising where we get 401s back, but it doesn't necessarily mean that our token is bad. It could just be that our API is invalidating it incorrectly, or whatever. What I would like to do is, before redirecting them, to check whether our access token (which is just a reference string) is still valid.
I tried querySessionStatus, but it seems like it relies on session_state being returned (and also the sid property? which I am not entirely sure what it does). However, my server is not maintaining sessions, and is only validating tokens. I get back an id token and a state, but oidc-client doesn't see the session_state that it needs and says "user not authenticated".
Does this seem like correct behavior? Is my oidc server doing something incorrectly? Is there a simpler/more direct way of doing what I'm trying to do (that isn't just offline "yep session still says good")? I'd prefer not to have to manually introspect the access token myself, when that really seems like something my user manager should be doing.

Unfortunately there are a few situations arising where we get 401s back, but it doesn't necessarily mean that our token is bad. It could just be that our API is invalidating it incorrectly, or whatever

401 means you need to get a new token. If the API tells you this incorrectly, then it's broken.

No, I agree, and that's something I'm looking at as an avenue to fixing it. Unfortunately most of the auth frameworks for .NET just issue Authentication.Fail on any problem with the server, so I just can't do much with that for now.
What I do have control over is what my front-end app does when it receives a 401. Is there any way to, using this library, to check the current state of our token in the browser directly with the authority?

Access tokens, by design, are opaque to the client. You could do something custom, but it would be beyond what the spec and this library is designed for.

Okay, that's fair. Appreciate you taking the time.


Notifications as a class with inheritance

The notifications should be changed so that there is a parent interface DeRecStatusNotification, and then each particular type of notification is an interface that extends the parent interface. The reason for this is that the current implementation with an enum is not extensible by implementations (because they can't add to an enum, but they could add more classes).
The parent should have a method getType which returns an enum from {NORMAL, WARNING, ERROR}.
All of the methods that are currently in the interface are kept.

Looks good


Shift + Tab not working any more

Category
Bug
What is the current behavior?
Shift + Tab to reduce indent, and nothing will happen
Also sometimes backspace key will act like enter key
Also one minor thing is the save button becomes publish button, don't know why
What is the desired behavior?
Should reduce indent properly
Additional information

No

In raw mode (edition of markdown) or document mode ?

Both mode....Since sometime last week, it totally broke down for me... Seems you guys pushed a new version? Because the appearance changed a lot...

This should have been fixed since 6.3.10


fix: Publish maybe_rayon when releasing crates

These sort of errors get fixed pre-release by doing dry-runs. We have #115 as a tracking issue for dry-runs


Running Python script from command bar

Description of the problem or steps to reproduce

Is there a way to run python script from command bar?
Specifications

Commit hash:
OS: Windows10
Terminal: ConEmu

You can either use Ctrl-b which will give you a command prompt, and will allow you to interact with the command you run, or you can use the run command which will your job in the background. I think ctrl-b is probably what you want.

You can either use Ctrl-b which will give you a command prompt, and will allow you to interact with the command you run, or you can use the run command which will your job in the background. I think ctrl-b is probably what you want.

Thank you!


Error: double free or corruption (!prev)

Hi, I got the double free or corruption (!prev) error when I was decoding this image. I don't know how to solve it, can you help me? Here are my codes:
import cv2
from pyzbar import pyzbar

img = cv2.imread(img)
h, w, _ = img.shape
gray_image = cv2.cvtColor(img, cv2.COLOR_BGR2GRAY)
barcodes = pyzbar.decode(gray_image)

My python version is 3.7.3 and the version of pyzbar is 0.1.8.
Thanks.

Hi, I also met a similar problem. Have you solved it again?

Not yet.
My solution is to decode each image in different processes, so if one crashed others won't be affected. But of course, it will cost more running time.

export MALLOC_CHECK_=0, I found it here
If you have plenty of time, I suggest you try it.

Thank you. But the same problem still exists for me.

Hi, I faced the same problem. Do you have any ideas to solve it now?

I have run into the same issue. It makes Pyzbar unusable.

I also got the same issue.

+1

We have the same error.
By enabling faulthandler.enable(), the following logs appeared.
Fatal Python error: Aborted
Current thread 0x00007fe908226740 (most recent call first):
File "/usr/local/lib/python3.9/site-packages/pyzbar/pyzbar.py", line 230 in decode
Fatal Python error: Segmentation fault

It seems that some errors are inside wrapper.zbar_scan_image().
https://github.com/NaturalHistoryMuseum/pyzbar/blob/ff2892666fa7cd305f0a95f9808159809c6fc222/pyzbar/pyzbar.py#L230


IBM Cloud tests are failing when the PR title contains a quote

/kind bug
What versions of software are you using?
Operating System:
Output of odo version:
How did you run odo exactly?
Actual behavior
When a PR title contains a quote ', the IBM Cloud tests fail with the message:
/tmp/run: 96: ./_env: Syntax error: Unterminated quoted string

Expected behavior
Any logs, error output, etc?

@feloy I think this is something which is handled by ibmcloud CI, do you think It's still relevant ? or should we close it

Needs investigation

I check the PR's with quotes ' as well as backquotes ` ,and they passed all the IBM cloud tests.

I faced this issue again on https://github.com/redhat-developer/odo/pull/6833. PR title was: Fix flaky 'odo dev' test on Podman by randomizing component names:
Preparing to start the job...
Running on public worker: eu-depublicworker04-3
Pulling image quay.io/odo-dev/ibmcloudtest-image:v1.19-1 ...
Job execution started at Mon May 22 16:16:51 UTC 2023
Custom image
Cloning the 'main' branch from repo 'https://github.com/redhat-developer/odo.git'
2023/05/22 16:17:21 Skipping step because a previous step failed
/tmp/run: 18: export: dev test on Podman by randomizing component names: bad variable name
Repository successfully cloned
Performing Pull Request Checkout
From https://github.com/redhat-developer/odo
 * [new ref]             refs/pull/6833/head -> ids-pipeline-temp-branch-for-pr
Switched to branch 'ids-pipeline-temp-branch-for-pr'

Finished: FAILED


Network: IP masquerade works locally

Description
With this PR dnat rules for IP resources are applied also on the node if the masquerade value is true.
This allows pods to use the remapped IP even if it is a local remapped IP

/merge


search bar and landing zone

[ ] landing zone groundwork
[ ] search bar for filtering
[ ] grid for project cards
[ ] project card
[ ]  button for table view and table view -- allow local storage save of view by permanent storage


Move getStaticCsvUrl and add to buildCache

Fix CensusCharts
Seperate server and react functions
Make buildCsvFromData store independent
Add noAlert option
Make download analysis faster

replaced by #735


it didn't work out

Bro I followed all the steps but it didn't work out
pls help me

Bro I tried getting the error of node bot. J's unexpected identufuer

what? can you send me a screenshot


Refactor new method entry point to rwh

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Docs
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Checklist

[ ] This PR will resolve #___
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary
[ ] It can be built on all targets and pass CI/CD.

Other information

Here is what is left to do:

Fix Documentation and add missing ones
Cleanup examples:

use tao to showcase all current examples
add new examples for winit, wgpu and some other projects

* [ ]  Cleanup examples and add new examples for winit, wgpu and some other projects

I think we should reduce the amount of example to only some basic ones and move others to integration test.
Let's do this in next isses/PRs.

* [ ]  Figure out how to resize the child gtk in x11

Can Windows auto resize? On macOS, it can auto resize. But I feel like we should just tell users to handle child position and size manually themselves.

* [ ]  Figure out how to resize the child gtk in x11

Can Windows auto resize? On macOS, it can auto resize. But I feel like we should just tell users to handle child position and size manually themselves.

Windows can auto resize correctly yes, but on x11 it doesn't, the problem is if we take a raw x11 handle and we initialize the webview as a child, you can call webview.set_size which changes the x11 child correctly but the gtk render surface stays the same

Alright, I fixed the webview.set_size for child webviews, now remains only one-case which I am not sure if even possible to fix. When you create a webview using raw-window-handle Webview::new(&window), on macOS and Linux when the passed window is resized, the webview also gets resized, but on X11, it stays the same size when was created.

Alright, I have opted into leaving that behavior as is and documenting it and also changed webview.set_size to work only on X11 if the webview was created that way, also modified the winit example to showcase this.

Note: any example that uses winit right now is broken due to a crash in winit and I am reaching out to the winit team to find a solution to this.

Transparency does not seem to work anymore with this branch (on macOS):

Using the following code:
    let event_loop = EventLoop::new()?;
    let window = WindowBuilder::new().build(&event_loop)?;

    let parent = window.window_handle()?;
    let mut builder = WindowBuilder::new()
        .with_title("child window")
        .with_decorations(false)
        .with_has_shadow(false)
        .with_transparent(true)
        .with_inner_size(LogicalSize::new(400.0f32, 400.0f32))
        //.with_position(Position::Logical(LogicalPosition::new(0.0, 0.0)))
        .with_visible(true);
    builder = unsafe { builder.with_parent_window(Some(parent.into())) };
    let child_window = builder.build(&event_loop)?;

    let builder = WebViewBuilder::new(&child_window);
    let webview = builder
        .with_transparent(true)
        .with_devtools(false)
        .with_html(
            r#"
                  <!doctype html>

                    hello

                  "#,
        )?
        .build()?;

The parent window here is rendered by a wgpu surface filled with a static color.

Also, the application crashes every time the webview loses focus:
thread 'main' panicked at 'ivar _state not found on class WryWebViewParent', /Users/niklaskorz/.cargo/registry/src/index.crates.io-6f17d22bba15001f/objc2-0.4.1/src/runtime/mod.rs:1015:17

@niklaskorz thanks for testing, this is really nice feedback.
About the transparent thing, are you using winit or tao as the windowing library? can you test with both?
Also cc @wusyong

@niklaskorz thanks for testing, this is really nice feedback.
About the transparent thing, are you using winit or tao as the windowing library? can you test with both?
Also cc @wusyong

This was using winit, but I also tried with tao (dev-branch) right now. This code:
    use tao::{
        event::*,
        event_loop::{EventLoop, ControlFlow},
        platform::macos::WindowBuilderExtMacOS,
        window::WindowBuilder, keyboard::Key,
    };
    use wry::WebViewBuilder;

    let event_loop = EventLoop::new();
    let window = WindowBuilder::new()
        .with_transparent(true)
        .with_decorations(false)
        .with_has_shadow(false)
        .with_transparent(true)
        .build(&event_loop)?;

    let builder = WebViewBuilder::new(&window);
    let webview = builder
        .with_transparent(true)
        .with_devtools(false)
        .with_html(
            r#"
                  <!doctype html>

                    hello

                  "#,
        )?
        .build()?;

gives me a web view with a white background:

On the upside, when using tao instead of winit, the app does not crash when the webview loses focus.

Thanks for the feedback, @wusyong will take a look as soon as he can.

@amrbashir Sorry, I actually didn't know transparent is a feature flag, maybe this should be added to the comment of to the with_transparent method. Or that method should be behind the transparent flag as well. Anyhow, with features = ["transparent"], it works now... Both in tao and winit:

But the crash on focus-lost (ivar _state not found on class WryWebViewParent) in winit still occurs.

Thank you very much, I believe we should be able to fix that ivar crash

And I will add a compile error on the transparent example to make it harder to miss the feature flag.

@niklaskorz You don't need to create a child window. Our new_as_child will handle that for you already.
All you need to do is provide position and size when creating webview.
As for the crash, I think winit will try to set some state to NSView and our Wry's default behavior will try to replace the view with our own. I guess we should update the doc to suggest winit users should use new_as_child instead of new for now. @amrbashir Does this look good to you?
    let event_loop = EventLoop::new()?;
    let window = WindowBuilder::new().build(&event_loop)?;

    let builder = WebViewBuilder::new_as_child(&window);
    let webview = builder
        .with_transparent(true)
        .with_size((100, 100))
        .with_devtools(false)
        .with_html(
            r#"
                  <!doctype html>

                    hello

                  "#,
        )?
        .build()?;

@wusyong On Windows, using new_as_child instead of creating a winit child window has the problem that transparency is only set for the webview, not the child window:

Repository: https://github.com/niklaskorz/wgpu-wry-example (webview is created here: https://github.com/niklaskorz/wgpu-wry-example/blob/4476b96879f8a01f0c7ac571f2e5f18d33cd6af3/src/lib.rs#L671)

Tbh I feel like we shouldn't care what crate the user is using and we should avoid replacing the view, keep the original and then add ours as a new subview.

@amrbashir There are a lot of trouble if we just add as subview. For example like, the cursor won't change if unfocused, menu item accelerators won't work, global accelerator won't work, and IME troubles.
We come a long way for this, and I spent tremendous of time fixing all these issues. And we endup replace the content view in order to work best with tauri. So for tauri usage, it still must replace the view.

@wusyong On Windows, using new_as_child instead of creating a winit child window has the problem that transparency is only set for the webview, not the child window wry creates:

@amrbashir I think we should make the child window be also transparent if webview has transparent attribute on Windows and Linux then.

Can we at least reuse the view? without removing its stat

@wusyong On Windows, using new_as_child instead of creating a winit child window has the problem that transparency is only set for the webview, not the child window wry creates:

@amrbashir I think we should make the child window be also transparent if webview has transparent attribute on Windows and Linux then.

I will take care of that

Can we at least reuse the view? without removing its state

I have tried that but menu item accelerator won't work. And we need them for fundamental items like cut/copy/paste.
winit's NSView will stop the input chain to itself and won't pass to menu.

Maybe we should contact winit maintainers for a possible solution?

Whole winit's window event heavily relies on their custom NSView.
Many events were initially implemented in NSWindow, but they moved to NSView.
We have made a lot of effort to avoid this in tao.
I was on the side to keep original view as well. But every time I did this way, it always backfired with horrifying regressions.
I don't see any possible way winit can get away with this.
Best we could do is making new and new_as_child literally the same (add as subview).
And offer another platform specific method just like new_gtk to do the replacing approach.

I'll keep the winit and x11 implementation like this for now, if you feel you can refactor new to add a subview and it will fill the window and resize with it, I am fine with that.

@amrbashir I added the new method for macOS

@wusyong WebViewBuilder::new was completely broken on macOS (both for winit and tao) so I changed that to replace the contentView by default and changed new_as_content_view to with_as_subview as an ext method instead of new constructor.

That's sounds the same as new_as_child

That's sounds the same as new_as_child

Semantics matter 😅 just like the previous new was the same as new_as_child, but you can't reuse the same function for that purpose.

I think the overview description in README would need update as well :)

WRY connects the web engine on each platform and provides easy to use and unified interface to render WebView. It also re-exports TAO as a module for event loop and window creation.

https://github.com/tauri-apps/wry/blob/dev/README.md#overview

@rhysd Thanks for notifying! I've opened a PR to update it.
https://github.com/tauri-apps/wry/pull/1065


azd pipeline config  Azure Dev Provision fail in pipeline for todo-nodejs-mongo-aks

Describe the issue:
The template deployment fail , when run azd pipeline config --provider azdo.
The error message as follows:

Repro steps:

Run command azd login.
Run command  bash ./test-templates.sh -t todo-nodejs-mongo-aks -b staging
Run command azd pipeline config --provider azdo

Environment:
OS: Windows desktop, MacOS desktop, Linux desktop, Devcontainer in VS Code, WSL.
Template: todo-nodejs-mongo-aks
Azd version: 0.7.0-beta.2-pr.2672227  (commit https://github.com/Azure/azure-dev/commit/dec4eb2c9f5932d3bd41f7e66b41c775c050ad48)
Expected behavior:
azd pipeline config --provider azdo can pass.
@rajeshkamal5050 for notification.

@vhvb1989 can you take a look at the azdo issue? Marked it as a blocker. Please update.

@rajeshkamal5050 @vhvb1989  Looks like a duplicated of closed issue #1686

@rajeshkamal5050 @vhvb1989 Looks like a duplicated of closed issue #1686

Do we need to document within aks-todo templates that running azd pipeline requires to set an special role? Or at least as part of the test-procedures notes.

removing blocker...  as this is known configuration issue

@rajeshkamal5050 This issue also occurs in the following cases:

OS: Windows desktop, MacOS desktop, Linux desktop, Devcontainer in VS Code, WSL.
Template: todo-nodejs-mongo-aks
Branch: Staging
Azd version:  0.7.0-beta.2-daily.2681609  (commit https://github.com/Azure/azure-dev/commit/81b97e0268a78c521ef0017c5c9531c4ba7e0399)

@wbreza can we callout the requirements azd pipeline config --provider github --principal-role owner in the template's ReadMe?