Open file

Description
What steps will reproduce the problem?

Open spyder under Python 3.6
Click on open file icon
Error

What is the expected output? What do you see instead?
Please provide any additional information below
File "/home/pat/apps/anaconda2/envs/py3mqtt/lib/python3.6/site-packages/spyder/plugins/editor.py", line 1841, in load
self.edit_filetypes = get_edit_filetypes()
File "/home/pat/apps/anaconda2/envs/py3mqtt/lib/python3.6/site-packages/spyder/config/utils.py", line 124, in get_edit_filetypes
supported_exts = _get_pygments_extensions()
File "/home/pat/apps/anaconda2/envs/py3mqtt/lib/python3.6/site-packages/spyder/config/utils.py", line 86, in _get_pygments_extensions
for lx in lexers.get_all_lexers():
File "/home/pat/apps/anaconda2/envs/py3mqtt/lib/python3.6/site-packages/pygments/lexers/init.py", line 53, in get_all_lexers
for lexer in find_plugin_lexers():
File "/home/pat/apps/anaconda2/envs/py3mqtt/lib/python3.6/site-packages/pygments/plugin.py", line 53, in find_plugin_lexers
yield entrypoint.load()
File "/home/pat/apps/anaconda2/envs/py3mqtt/lib/python3.6/site-packages/pkg_resources/init.py", line 2404, in load
self.require(*args, **kwargs)
File "/home/pat/apps/anaconda2/envs/py3mqtt/lib/python3.6/site-packages/pkg_resources/init.py", line 2427, in require
items = working_set.resolve(reqs, env, installer, extras=self.extras)
File "/home/pat/apps/anaconda2/envs/py3mqtt/lib/python3.6/site-packages/pkg_resources/init.py", line 872, in resolve
raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (parso 0.1.1 (/home/pat/apps/anaconda2/envs/py3mqtt/lib/python3.6/site-packages), Requirement.parse('parso==0.1.0'), {'jedi'})
Version and main components

Spyder Version: 3.2.4
Python Version: 3.6.3
Qt Versions: 5.6.2, PyQt5 5.6 on Linux

Dependencies
pyflakes >=0.6.0 :  1.6.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  None (NOK)
numpy >=1.7      :  None (NOK)
sphinx >=0.6.6   :  1.6.3 (OK)
rope >=0.9.4     :  0.10.7 (OK)
jedi >=0.9.0     :  0.11.0 (OK)
psutil >=0.3     :  5.4.1 (OK)
nbconvert >=4.0  :  5.3.1 (OK)
sympy >=0.7.3    :  None (NOK)
cython >=0.21    :  None (NOK)
qtconsole >=4.2.0:  4.3.1 (OK)
IPython >=4.0    :  6.2.1 (OK)
pylint >=0.25    :  1.7.4 (OK)

Thanks for reporting; this is a duplicate of e.g. #5673. As the error message states, Jedi is only compatible with parso 0.1.0, not, 0.1.1. Therefore, please downgrade to 0.1.0 to fix this, and this issue can be closed.

You can also update Jedi with
conda update jedi

to fix this problem.

thanks
“A goal without a plan is just a wish.”
― Antoine de Saint-Exupéry
http://www.goodreads.com/author/show/1020792.Antoine_de_Saint_Exup_ry
On 10 December 2017 at 00:59, Carlos Cordoba<EMAIL_ADDRESS>wrote:

You can also update Jedi with
conda update jedi
to fix this problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/5933#issuecomment-350517197,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANEopsn68B90SdPj4D0EfmBQmngL-umnks5s-yzogaJpZM4Q8CYu
.


InputTypeCountry filters by ISO and not Label

Describe the bug
When you look up the country list for a specific country, you're actually filtering by ISO code and not by the label it displays.
This is a problem in the case of "Switzerland", where you're intuitively searching for "Swi..." but nothing appears. You need to type "CH" to get that country listed.
To Reproduce
Steps to reproduce the behavior:

Go to the New Expense page
Click on the Choose Country dropdown
Type "Switzerland"
Type "CH"

Expected behavior
Search country by name.
Screenshots

I think @SudharakaP is already looing in this regression (it was reported on Slack). Should be resolved by https://github.com/opencollective/opencollective-frontend/pull/7745


Prepend task name to PX4_WARN() on all OS

@mcharleb here is how to get the thread name (I will merge a change to master in a sec which sets it in px4_task_spawn). It would be great if we could rework PX4_INFO and warn to always prepend the thread name since that makes the error messages substantially more informative.
The same would be good for PX4_WARN() for NuttX, since warnx() does do that and its the main reason we haven't cut over the rest of the system to PX4_WARN().
const unsigned NAMELEN = 32;
char thread_name[NAMELEN] = {};
(void)pthread_getname_np(pthread_self(), thread_name, NAMELEN);
PX4_WARN("%s: error message abc", thread_name);

Done as part of #4709.


new cassIO connect experience with the newest cassio.init

CassIO 0.1.3 shipped with a brand new zero-friction cassio.init() method for establishing the connection to your database (be it Astra DB or Cassandra).
This PR updates the notebook accordingly, thereby reducing a lot of the boilerplate around connecting to the DB.
(nothing else changes apart from the connection procedure and the instructions around it)
Tested both locally and on Colab.
Thank you for a review!

Looks good! In the future please fill out our PR template!


Updated plot_city

Summary
Fixes #2322
Details and comments
Matplotlib has a function called get_autoscalez_on() which automatically determines the best intervals to use. I used this in place of set_major_locator(MaxNLocator(5)), which would sometimes cut off the max and min values on the plot axes. Both the real/imag plots should have the same maximum value now.

@nonhermitian @mtreinish Is there anything else @dennis-liu-1 needs to do to enable this PR to be closed? If not, mind reviewing the changes?

do you mind pasting a picture of how the image will look like now? (so that we can contrast it with the image in #2322 )

The original plot for comparison, and another example as well

Do we have a bug about the axis being off center on the imaginary half when there is a negative value? While that's outside the scope of this PR it's something else we'll want to fix.

@mtreinish There does not appear to be. As you note, it's beyond the scope of this PR. Can we please close it and then @dennis-liu-1 can work on the other issue.


Small improvement to mnist_tflearn.ipynb

Small improvement to mnist_tflearn.ipynb - included the linear model and created a small function to create a new subdirectory,  parameterized the functions for the DNN and linear models (parameters for Num steps, logdir,  and learning rate). This should make it easier for students to re-run.

A belated thanks again for this!   As I think I might have mentioned, the repo is not currently set up for external contributions (sorry about that -- google has some rules about how we do this) but I will incorporate your changes and give you credit in the commit message.

Closing, as I have made a commit that incorporates your suggestions.  Thanks again!


Cannot change a file in the composum editor

Hi !
I've tried to change a html file that I've added to the repository via Sling-Initial-Content and there is no save on the repository. The editor does not complain of an error, it actually presents my changed content (in the text code view) but when I access the corresponding URL or when I preview the old content is presented. I'm using sling 8 and the latest version of composum avaliable.
To reproduce this issue an html file needs to be on the repository for example at /apps/components/test.html (or uploaded) and then we should select the text code view of the corresponding node and press edit text. In the edit view we should perform a change and press save.
The final outcome of this is a text code view with the changed content but when accessing directly via Display Rendered View for example the old content is still displayed.
I've tried to change permissions and the problem remais. I've also peeked at the log files but was unable to find any useful information so I'm a little lost right now.

Hello again, I've debugged the code and actually this is even more strange than I thought initially.
I've looked at the PropertyUtil class which is called by the PropertyServlet after I hit the save button and apparently everything goes well. the statement
property = node.setProperty(name, valueFactory.createValue(binary));
completes with success but no data is stored something very weird is happening...

Okey,
This must be some kind of cache problem. If I open another browser window the content is indeed changed, what is odd is that in the previous session I still see the old content. Any idea what this could be ?

Hi again :-) Sorry for the spamming but I think I've found the problem. To use composum as a way to edit content when the content is fetched some headers should be sent in the request to disable caching else after changing some html for example the user will see the previously cached browser page and not the one that he/she has changed.
I think this is a matter of adding some headers for such requests to correct this problem.


Improved CI checks and pinned latest Python versions

Description
Self-explained
Motivation and Context

Pinning Python with the latest releases (3.8.6 and 3.9.1)
Pinning OSes

Types of changes

[x] House cleaning (small change at project level)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Implementation details
N/A

Codecov Report

Merging #29 (3dd188c) into master (0999432) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   73.68%   73.68%
=======================================
  Files           2        2
  Lines          19       19
=======================================
  Hits           14       14
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0999432...3dd188c. Read the comment docs.

Codecov Report

Merging #29 (3dd188c) into master (0999432) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   73.68%   73.68%
=======================================
  Files           2        2
  Lines          19       19
=======================================
  Hits           14       14
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0999432...3dd188c. Read the comment docs.


Connection refused while initiating application

Hi @nbdd0121, I am having issues with running Terminator GUI via WSL2 Ubuntu.
Here is my setup:

Start VcXSrv on windows host with vcxsrv.exe :0 -ac -terminate -lesspointer -multiwindow -clipboard -wgl -dpi auto
Start the wsldhost --daemon with in Windows CMD as admin, and verified that it is running on the port 6000
Inside WSL via windows CMD export DISPLAY=:0 and start wsld process in background.
But I can't get any response for xset q, it just waits.
And also when initiating the application I get the following error:

C:\>wsl.exe bash -c "DISPLAY=:0 terminator"
Unable to init server: Could not connect: Connection refused
Unable to init server: Could not connect: Connection refused
You need to run terminator in an X environment. Make sure $DISPLAY is properly set

I can see the correct PID in /tmp/.X0-lock for the wsld process I started. And the /tmp/.X11-unix/X0 also have correct permissions(777):
Thanks!

I have no immediate clue of what's wrong there. Maybe try deleting files in /tmp and try again as WSL doesn't clean up the temporary files automatically.


Duplicate InvokeFunction types

Looks like starknet_core::types::transaction_request::InvokeFunctionTransaction is literally the same as  starknet_core::types::call_contract::CallContractResult. We should remove the latter.

Do you mean starknet_core::types::call_contract::InvokeFunction, not starknet_core::types::call_contract::CallContractResult?

Yeah was a typo 😂😂


ARROW-12353: [Packaging][deb] Rename -archive-keyring to -apt-source

Because lintian recommends that a package that puts files to
/etc/apt/sources.list.d/ uses -apt-source suffix.
See also: https://lintian.debian.net/tags/package-installs-apt-sources
This also changes repository URL to
https://apache.jfrog.io/artifactory/ from https://apache.bintray.com/ .

@github-actions crossbow submit debian-* ubuntu-*

@github-actions crossbow submit debian-* ubuntu-*

https://github.com/ursacomputing/crossbow/branches/all?query=build-220
https://github.com/kou/arrow/actions/runs/747455109

+1


measure distance

Adding a possibility to measure distances in the map

Added the initial infrastructure. The starting point for the feature development is `OlMeasurementHandler.js.

Manually adding the olLayer within the OlMeasurementHandler is no longer necessary

Well done!

Code structure
Test and test coverage
Preparation for later refactoring (common function)

On the one hand the concept of passing the map instance to the handler breaks encapsulation, but on the other hand,
we are able to to do all the necessary and often complicated setup to interact with the map. I think we'll leave that, and I will extract a generic handler interface for other handler developments.
Next steps from my point of view:

make the tool look and feel the same like the ba3 measurement tool
add a button in the show case to clear/remove the layer

OlMeasurementHandler.js could now extent OlLayerHandler.js

OlMeasurementHandler.js has now Partition-Overlays.
Next Increment is planned with overlay-styling, as for now, the styling is absent.
Or is it better nor possible to litify the overlay-content to a component, so styling could be moved to this component?

OlMeasurementHandler have now styling on the overlay-elements and is lifted up to a module.
Next increment is planned with the display of the azimuth-angle in the tooltip

Very nice!!
I just would like to suggest to give the BaOverlay class a more meaningful name (e.g. MeasurementOverlay),
for two reasons:

We probably will have a couple of "BaOverlay" classes distributed over a couple of folders in the future otherwise
You've got a better IDE support when you search for a file, and you just know it has something to do with "measurement"

Excellent !
Just one thing to note: When the handler is deactivated, the overlays (labels) seems not to be removed completely

I fixed that

Just for me to remind, pending are:

transformation of geometries to a geodetic SRID for correct length and area calculations
small refactoring of the LayerHandler (provide an id)

Something more?
Nothing from my side, except an possible enhancement for the sketch-styles, if vectorLayers with custom-themes comes to production. Then we could think about retrieving colors from CSS-Globals or stuff like that.

Ready for refactoring of the LayerHandler (provide an id)


[Airbrake] [Staging] undefined method `marginal_heat_costs' for #InstalledHeatSource:0x007f674ad3f500

Airbrake error: #4669
Airbrake project: ETMoses
Error type: NoMethodError
Error message: undefined method `marginal_heat_costs' for #<InstalledHeatSource:0x007f674ad3f500>
Where: testing_grounds#edit
Occurred at: Jun 13, 2016 15:35:01 UTC
First seen at: Jun 13, 2016 15:35:01 UTC
Occurrences: 1 (1 since last deploy on Jun 13, 2016 15:27:46 UTC)
URL: https://beta-moses.energytransitionmodel.com/testing_grounds/528/edit
File: [PROJECT_ROOT]/app/views/heat_source_lists/_must_run_table.html.haml
Backtrace:
[PROJECT_ROOT]/app/views/heat_source_lists/_must_run_table.html.haml:45:in block in _app_views_heat_source_lists__must_run_table_html_haml___4099859659731822186_70040831311340
[PROJECT_ROOT]/app/views/heat_source_lists/_must_run_table.html.haml:19:in each
[PROJECT_ROOT]/app/views/heat_source_lists/_must_run_table.html.haml:19:in _app_views_heat_source_lists__must_run_table_html_haml___4099859659731822186_70040831311340
[GEM_ROOT]/gems/actionview-4.1.8/lib/action_view/template.rb:145:in block in render

Fixed by: b584d44


accepted version

from the compiler:
/langversion:             Specify language version:
9|9.0|10|10.0|11|11.0|12|12.0|14|14.0

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 98333251-2a19-793a-acd2-274181a7f1fd
Version Independent ID: ff27427e-cbe2-3d89-b526-dfa7b3debabf
Content: -langversion (Visual Basic)
Content Source: docs/visual-basic/reference/command-line-compiler/langversion.md
Service: unspecified
Product: dotnet-visualbasic
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

I agree that the page should be updated, though it seems there are versions beyond 14. When I run vbc /langversion:? from Developer Command Prompt for VS 2017, the output I get is:
Supported language versions:
default
9
10
11
12
14
15 (default)
15.3
15.5 (latest)
latest

Do you want to create a Pull Request to update that information? If you do and don't know how to do that, you might want to read this guide. And if you have any questions about the process, feel free to ask here.

Aha, there was an older version of vbc in my path. Your list is correct. I will dive into the guide.

Resolved with PR #5571


chore: jsonfmt relay

Ran jsonfmt -w "specification/relay/**/*.json"

Automation for azure-sdk-for-python

Automation for azure-sdk-for-java

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

Automation for azure-sdk-for-js

@v-Ajnava I fixed the model validation issue by removing the "description" from the example file. I can remove this if you prefer


Strip Markdown markup from title

Headers in Markdown may include markup:
# My _title_ with footnote[^src]

[^src]: This article is based on previous work by J.E.D.

It would be nice to strip that from the title as it goes to the front-matter, since it will be treated verbatim by browsers and scripts.
Many thanks for considering,
-d

I agree that that is not the intended behavior, though do not know that footnote in H1s are that common, and thus may not be able to personally tackle this in the near future. Very glad to review a PR if you or anyone else is interested.

Eeh, this issue should have gone to benbalter/jekyll-titles-from-headings, sorry. Moved to benbalter/jekyll-titles-from-headings#15.


Update crate dependencies.

This PR updates crate dependencies to latest.
To keep compatibility with Wasmtime 14 (until the next release), the adapters have not been updated.
Also fixes a few tests containing WIT that were missed when adding semicolons, as they are now required by default with this update.

This will also incorporate the fix for https://github.com/bytecodealliance/wit-bindgen/issues/752.


update readme to remove special branch instructions

updating the readme

still a work in progress, but testing that my local repo is set up correctly to push changes.


Support creating testlayer from uri

typos, otherwise lgtm
also, if you want to sell it as a feature, you could add a changelog entry

ack


Add support for query options on useThreads

Add an option to useThreads to filter threads based on their metadata.
Definition
useThreads(options?: { query?: { metadata?: Partial<TThreadMetadata> }});

TODOS:

[x] Support passing no options
[x] Improve polling
[x] Fix tests that are failing due to change in cache manager signature
[x] Support errors

Each useThreads can be passed filter options that is used to determine what threads the useThreads hook should return. We collect all these filter options in a map and make getThreads call for each option. Then, we normalize this list and replace the cache with the normalized list of threads. Any update to the cache is made via the setCache method inside the threads cache manager. Each time a setCache method is called, we also calculate threads for each filter  option and store these filtered threads for each filter option.
High level architecture:

We have a main cache which stores all threads we are currently interested in. Subsets of this main cache is stored in the cache state of filter options.
Each filter option has its own cache state. This cache state is either in loading state or has data in it. Any data in the cache state of filter options are derived from the main cache.
The cache state of each filter option is initially set to loading state until the next revalidation or optimistic mutation updates the main cache.
Cache state for each filter option is calculated from the main cache on each update to the main cache.
We store each filter option in an array and during revalidation, we make a call to fetch threads using each of those filters.

Possible improvements

[ ] Currently, we store all filter options and make a getThreads for each option, which is okay but can be improved in certain cases. Consider the case where one of the filter options applied is { resolved: true } and the other one applied is { resolved: true, page: 10 }. In the current setup, we make two getThreads call one with each of the aforementioned filter options. But, notice how the filter { resolved: true, page: 10 } is a subset of the filter { resolved: true }, so we could have only made one single call to getThreads with filter { resolved: true }. For this, we will need a function, let's call it isSubset(subset, superset) that checks if an option filter is a subset of another.
[ ] Similar to the above mentioned improvement, but slightly different. During initial rendering, we set the cache state of a filter option to { isLoading: true }. But, say we already have mounted a component that calls useThreads with { resolved: true } filter option and we have all those threads in the main cache. Now, say after clicking a button, a new component is rendered that calls useThreads with { resolved: true, page: 10 } filter. Ideally, we don't want to set the cache state for this filter option to { isLoading: true } because this filter option is a subset of { resolved: true }, which we already have data for. For this optimization as well, we also need the isSubset method.
[ ] Each sub-cache associated to a filter option is initially set to { isLoading: true } and this state is updated to show filtered threads for the filter option on the next call to setCache, which normally happens after the initial revalidation (on mount) is completed. But, there can be cases when the setCache can be triggered by a mutation before the revalidation is complete, which results in an empty threads list for the filter, until a new revalidation is successful (which happens immediately after a mutation)
[x] Better support for suspense. The suspense useThreads hook currently doesn't delete the query info after completely removing the component from React tree. I don't think this will cause any UX problems other than a less optimal fetcher call but this is something we should be wary of.

@nimeshnayaju @GuillaumeSalles I asked this in the past but it's buried deep in Slack: should we name the option query instead of something more fitting like filter? To me, query sounds like it will map to all options available on the query string but I assume for things like pagination in the future we'll make the API more intuitive than asking for query parameters.

With the new changes, the global fetcher (collection of getThreads for each filter option) is only called during polling and revalidation after a mutation. During initial revalidation of useThreads, the filter that is passed as option is used, and this request is deduped too, which makes the experience slightly smoother and faster in general.


Tapping on map hides open callout

Bug

Environment info

React Native Environment Info:
    System:
      OS: macOS 10.14.6
      CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
      Memory: 78.19 MB / 16.00 GB
      Shell: 3.0.2 - /usr/local/bin/fish
    Binaries:
      Node: 10.16.0 - /usr/local/bin/node
      Yarn: 1.17.3 - /usr/local/bin/yarn
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
      Android SDK:
        API Levels: 23, 28, 29
        Build Tools: 28.0.3, 29.0.0
        System Images: android-26 | Google Play Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
    IDEs:
      Android Studio: 3.4 AI-183.6<IP_ADDRESS>22156
      Xcode: 10.3/10G8 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.6.3 => 16.6.3
      react-native: 0.58.3 => 0.58.3

Library version: 0.25.0
Steps To Reproduce

Open the callout
Tap on the map anywhere
Observe callout being hidden
...

Expected behaviour
I expect the callout to be open when I click the map.

I disagree this is a bug.   If you then click outside, it hides.  This seems like it is working as intended.

Maybe any workaround to avoid that?

Do you have a use case for this?  I am curious because usually when a user taps another area of the map, they intend to focus on that new touch and receive new data, not the previous touch (which the data was displayed for).

Closing as it's not a bug. You might want to ask on stack overflow maybe you find any answer :)


Home button on Xbox like controllers is not recognized

Godot version:
3.2.4 rc3 official
OS/device including version:
Windows 10, 64 bit
Issue description:
The HOME button on a Xbox like controller (XInput, like the Logitech F310) is not in the JoystickList.
Also, when pressing the HOME button on a Xbox like controller, it returns the scancode 33554431 (Unknown key).
I think this is a fault of the engine, because platforms like Steam expect a game to have an answer to the HOME button, like pausing the game. It can be done with Steam API integration, but why not recognize the button?
Users also expect this, because even if it's not on a specific store/launch hub, on Windows, XInput controllers will open the Xbox Game Bar with the HOME button, and it is good practice to pause the game when that happens.
Steps to reproduce:
Just add a script to any project with the code below, and press the HOME button in a Xbox like controller.
func _unhandled_input(event):
	if event is InputEventKey:
		print(event.scancode)

Minimal reproduction project:
See above.

Is that button even visible to third-party input mapping programs? If it's like the Xbox button on official Xbox controllers, there's no way to access it.

Is that button even visible to third-party input mapping programs? If it's like the Xbox button on official Xbox controllers, there's probably no way to access it from userspace.

Hum, didn't know that this could be the problem...

This was fixed in 4.0 with #38151 and will be fixed in 3.x with #48934.

Should I create a new issue or reopen this one? I still have the problem in Godot 3.5.2. The action is not triggered and printing event.scancode in the _input() function returns 33554431, which is unknown.
I've tested and it works fine in Godot 4.1.

Please open a new one, issues that have been marked as solved are not reopened


optimal padding that is more efficient than log2

this is a draft piull request to let you know I'm working on this so we don't duplicate effort by accident.
I found the log2 padding to be very wasteful with VRAM in worst cast scenarios, e.g. an input array of shape (129, 513, 513) will end up as (256, 1024, 1024) which is almost 8 times as large. In addition to wasting valuable VRAM this will also impact the other computations that have to process many more voxels.
Adding an option OPM_2357. Using a precomputed rainbow table (whether this is a good approach is open to debate but it is fast and has no dependencies).
Time to go to bed, will hopefully test tomorrow.

Thanks man!  Sounds good to me and feel free to make that the default mode.  That seems like a better choice since there was another issue or two from people hitting GPU memory issues immediately with so much padding.

LGTM -- I'm not sure why that old test is failing in the build yet but I don't see how any of those changes would interfere with existing functionality so I'll patch it up.  I think as a part of the fix for https://github.com/hammerlab/flowdec/issues/17, I'll want singleton dimensions to not get squeezed out (i.e. dropped), if I'm understanding you correctly, since that should make it easier to track spatial and batch dimensions.
Thanks again for putting this together!

Thanks for including the pull request

I think as a part of the fix for #17, I'll want singleton dimensions to not get squeezed out (i.e. dropped), if I'm understanding you correctly, since that should make it easier to track spatial and batch dimensions.

Ok, if I understand you correctly this might require a (simple) change to my code.
My code will turn a singleton dimension into a "2"
(1, 128, 128) -> (2, 128, 128)
The simple fix is to include the number "1" as first list element of the rainbow table.
In addition, this will also require a change to this test (change 2 to 1):
https://github.com/hammerlab/flowdec/blob/6b92c32036ff6e3746c15268bb2902519fef0cc5/python/flowdec/fft_utils_test.py#L49


[#6343] Adds support Kafka 2.3.0+

Codecov Report

Merging #6345 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6345      +/-   ##
==========================================
- Coverage   39.57%   39.57%   -0.01%
==========================================
  Files        3065     3065
  Lines       91419    91421       +2
  Branches    11837    11838       +1
==========================================
- Hits        36180    36179       -1
- Misses      52255    52256       +1
- Partials     2984     2986       +2

Impacted Files
Coverage Δ

...m/navercorp/pinpoint/plugin/kafka/KafkaPlugin.java
0% <0%> (ø)
:arrow_up:

...p/pinpoint/rpc/client/WriteFailFutureListener.java
56.25% <0%> (-18.75%)
:arrow_down:

...vercorp/pinpoint/web/vo/ApplicationAgentsList.java
66.66% <0%> (-2.57%)
:arrow_down:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
57.44% <0%> (-2.13%)
:arrow_down:

.../pinpoint/rpc/client/PinpointClientHandshaker.java
65% <0%> (-1.43%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
72.07% <0%> (-0.33%)
:arrow_down:

...ollector/cluster/zookeeper/ZookeeperJobWorker.java
80.93% <0%> (+1.39%)
:arrow_up:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
85.36% <0%> (+2.43%)
:arrow_up:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
70% <0%> (+3.33%)
:arrow_up:

...p/pinpoint/rpc/stream/StreamChannelRepository.java
85% <0%> (+10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2baf3b8...7ae37ac. Read the comment docs.


Use browser window scrollbar instead of container scrollbar

Hello,
I am wondering if it's possible to use the main browser window scrollbar instead of using the container scrollbar.
Thank you for your time

Hi @alolis! Because manage our own scrolling for performance, we don't use the native scrollbar.

@ehzhang Ah damn :( Thanks for your reply though!


Need to expose additional functionality from the jquery tooltipster plugin

Additional properties onlyOne and autoClose need to be exposed. If not this, then provide support to expose these properties from a custom component by allowing additional options.

It's been a while :) but autoClose has been added now. As for onlyOne it would work only if you had nested component inside another one, so I decided to not expose it for the moment. If I find a better way to handle that I will add it in the future.


Peruse does not close properly

OS: Arch Linux
Process:
Close the Peruse window by last tab close or window close.
Expectation:
The window closes and the process ends.
Result:
The window closes, but ps -ef | grep peruse shows that the process is still running.

I also have this problem in Windows 10.
Consequently, when launching the browser again (after the above issue; so with the Peruse process still running but the GUI closed) the GUI won't re-open. I assume @Folatt also had this problem causing him to look whether something was wrong with the process.

Migrated issue to https://github.com/maidsafe/safe_browser/issues/313


Add underlying #driver for element

@cheezy So far you plan to remove #method_missing for elements which is both great feature and source of pain.
However, it has some problems as well. For example, watir-webdriver recently introduced native support of drag&drop while previously we had to access webdriver's instance of element and webdriver's Actions:
def drag_and_drop_test_div(target_div)
  source_div = div(id: 'test').wd
  @browser.driver.action.drag_and_drop(source_div, target_div.wd).perform
end

We should allow users to make such "hacks" because page-object can't be as fast as both selenium and watir-webdriver.
What if we introduce some accessor to underlying driver element, so we could operate with low-level instance of element:
class Page
  include PageObject

  link :test, id: 'test'
end

Page.new.test_element.driver
#=> #<Watir::Anchor:0x703980a46a5b176c located=false selector={:element=>(webdriver element)}>

On the PageObject module there already is an accessor for browser.  In the example above you could have used:
self.browser.driver...

Also, on Element there is an accessor for element.
What else is missing?

I must have missed smth. Once you remove https://github.com/cheezy/page-object/blob/master/lib/page-object/elements/element.rb#L90 it won't be possible to access Watir/Selenium instance of element, yes? Or it will be possible via @element? For example:
class Page
  include PageObject

  link :test, id: 'test'
end

Page.new.test_element.element.class
#=> Watir::Anchor

If that's true, than this issue is invalid. Sorry for bothering.

In the element class you have the following attr_reader:
class Element
  include ::PageObject::NestedElements

  attr_reader :element

This provides access to the native element that was pass in during creation.

Thanks for explanation!


IOP API different levels of override inconsistent

There are different types of customization we can do using IOP: via the operator API, values.yaml pass through or overlay the k8s object directly, and they can be defined in file or using --set override.
However there are some inconsistency when using them. For example: https://github.com/istio/istio/issues/20153, overriding the k8s settings via values.yaml pass through would have no effect as it would be overrode by k8s spec defined in operator API at the end.
We may need to better document the priority order and what can be customized or not, or fix the bug if there is issue.

It's a similar case to enablement where user overrides should always take effect, even if they are going through the passthrough values API.

@ostromart I think we have to fix the k8s override part, as you said, user overrides should always take effect even if they are provided via values API.
But now it is not the case, now many settings provided via values API would be ignored because they are overrode by the IOP k8s spec defined in the profile at last step.


[TCK Challenge]: ExtensionTests#testDataProviderWithBuildCompatibleExtension conflicts with QBN

Specification
spec/src/main/asciidoc/repository.asciidoc
Assertion
A valid Query by Method Name exists but the TCK is expecting something different
TCK Version
SNAPSHOT (Locally built)
Implementation being tested
HIbernate
Challenge Scenario
Claims that a test assertion conflicts with the specification.
Full Description
The ExtensionTests#testDataProviderWithBuildCompatibleExtension test is expecting that it can call the injected ee.jakarta.tck.data.common.cdi.Directory#findFirstNameByIdInOrderByAgeDesc() method and obtain a list of Person.firstName values as though the repository was annotated with:
@Repository(provider = Directory.PERSON_PROVIDER)
public interface Directory extends DataRepository<Person, Long> {
    @Query("select firstName from Person where id in ?1 order by age desc")
    List<String> findFirstNameByIdInOrderByAgeDesc(List<Long> ids);
}

while findFirstNameByIdInOrderByAgeDesc is a valid QBN method that parses to:
find-expression: findFirst
ignored-text: Name
predicate: id IN
order-clause: OrderBy age Desc
which results in an interface annotated like:
public interface Directory$ extends Directory {
            @Override
            @Query("where id in ?1 order by '' limit 1")
            @OrderBy(value="age", descending = true)
            public java.util.List<java.lang.String> findFirstNameByIdInOrderByAgeDesc (java.util.List<java.lang.Long> ids);
}

but the return type should be type of Person rather than firstName values.
Additional Context
No response
Is there an existing challenge for this?

[X] I have searched the existing issues

There's another thing wrong with this test. Even if:
select firstName from Person where id in ?1 order by age desc

is the intended interpretation, it's ordering by a field age which is not in the projection list.

is the intended interpretation, it's ordering by a field age which is not in the projection list.

@gavinking, does query by method name have such a restriction?  Besides the findFirstissue I don't see anything in the specification that limits query by method name to sort only based on the field returned.
I can fix the findFIrst issue.

does query by method name have such a restriction?

I dunno, the spec for query by method name isn't terribly, shall we say, precise about such things.
Actually, looking at the spec, I don't see where query by method name even supports projection at all.
The relevant part of the BNF boils down to:
"find" "First" [<positive-integer>] [<ignored-text>] "By"

AFAICT, Name here matches to <ignored-text>, and so the query should be returning Person, not String.


recent-ui: Change the order (or make it changeable via arg)

We want to have the most recent element on the first position.

Done in: https://github.com/michidk/vscli/commit/20ed7bbef3de41609701c38e97652d9f45d8ee7d
Note that it is not changeable via args/env var yet. I don't think this is very important. Let's implement it if somebody else requests it


Publish to Galaxy

@sherl0cks and @sabre1041  - to check the test integration with Galaxy please look at my sandbox branch https://github.com/kameshsampath/ansible-middleware-playbooks/tree/sandbox

since i see we are able to pull the roles via galaxy, am closing this issue


Topicmerge process runs out of memory (DITA OT v 2.2)

I'm developing PDF2 stylesheets for a customer of ours and hit the following issue.
A publication of around 5000 objects which includes cross-references towards objects in a separate data set of around 18000 objects I hit an out of memory error message in the topicmerge process.
If I exclude the data set of around 18000 objects (so the xref statements do not resolve) the process runs fine.
I have already extended the memory on the server to 64GB of RAM, however when monitoring the process in the task manager I do see that it crashes when it has around 27,7GB or memory in use.
Upon suggestion of Eero, I have switched the generate-debug-attributes option in the lib/configuration.properties file from "true" to "false". This reduce the memory to 13,5 GB however the process still crashes.
Below the error stack which is raised each time:
-- start of snippet --
BUILD FAILED
W:\InfoShare\App\Utilities\DITA-OT\LR\build.xml:41: The following error occurred while executing this line:
W:\InfoShare\App\Utilities\DITA-OT\LR\plugins\org.dita.pdf2\build.xml:134: java.lang.OutOfMemoryError: Requested array size exceeds VM limit
at java.util.Arrays.copyOf(Arrays.java:2271)
at java.io.ByteArrayOutputStream.grow(ByteArrayOutputStream.java:113)
at java.io.ByteArrayOutputStream.ensureCapacity(ByteArrayOutputStream.java:93)
at java.io.ByteArrayOutputStream.write(ByteArrayOutputStream.java:140)
at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221)
at sun.nio.cs.StreamEncoder.implWrite(StreamEncoder.java:282)
at sun.nio.cs.StreamEncoder.write(StreamEncoder.java:125)
at java.io.OutputStreamWriter.write(OutputStreamWriter.java:207)
at java.io.BufferedWriter.flushBuffer(BufferedWriter.java:129)
at java.io.BufferedWriter.write(BufferedWriter.java:230)
at java.io.Writer.write(Writer.java:157)
at net.sf.saxon.event.XMLEmitter.writeCharSequence(XMLEmitter.java:621)
at net.sf.saxon.event.XMLEmitter.writeEscape(XMLEmitter.java:714)
at net.sf.saxon.event.XMLEmitter.writeAttribute(XMLEmitter.java:473)
at net.sf.saxon.event.XMLEmitter.attribute(XMLEmitter.java:394)
at net.sf.saxon.event.ProxyReceiver.attribute(ProxyReceiver.java:154)
at net.sf.saxon.event.ReceivingContentHandler.startElement(ReceivingContentHandler.java:366)
at org.dita.dost.reader.MergeTopicParser.startElement(MergeTopicParser.java:231)
at org.apache.xerces.parsers.AbstractSAXParser.startElement(Unknown Source)
at org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown Source)
at org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElement(Unknown Source)
at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source)
at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source)
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
at org.apache.xerces.parsers.DTDConfiguration.parse(Unknown Source)
at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
at org.dita.dost.reader.MergeTopicParser.parse(MergeTopicParser.java:190)
at org.dita.dost.reader.MergeMapParser.endDocument(MergeMapParser.java:253)
at org.apache.xerces.parsers.AbstractSAXParser.endDocument(Unknown Source)
at org.apache.xerces.impl.XMLDocumentScannerImpl.endEntity(Unknown Source)
at org.apache.xerces.impl.XMLEntityManager.endEntity(Unknown Source)
-- end of snippet --
Any idea on how to overcome this issue? Is there any memory switch which I can use apart from the -Xmx which I'm already using.
Can I get the topicmerge task setup so it can use more memory or can I somehow reduce the required memory in an easy way?
Any inside you can provide is highly appreciated.
Unfortunately, I'm not able to share the datasets as the customer doesn't allow this.
Kind Regards,
Raf
Raf Snijders

Which DITA-OT version?

The error message is different, but I wonder whether https://saxonica.plan.io/issues/2271 is related...?
From that issue:

As reported, I did look at the possibility of supported larger documents beyond the 2G limit. With strings and arrays in Java limited to 32-bit int addressing, it's not at all easy. The limits for a LinkedTree would probably be rather higher than for the TinyTree, which tries to reduce the number of Java objects and therefore ends up with objects whose size appriximates to the document size. It might be worth seeing how far you get with the Linked Tree: the actual amount of memory used will be higher, but I don't think you'll hit the same limits.

@snijderr: Which Java version are you using? I found this bug report:
https://bugs.openjdk.java.net/browse/JDK-8136527
The last comment in that bug report would suggest that this is a bug that has been fixed in newer JDK versions.
I tried the test case attached to that ticket and using JDK 8u65 indeed seemed to make a difference.

in response to the DITA-OT version number question,
The DITA-OT version I used is 2.2.0
But I also experience the same behaviour with DITA-OT 1.7.5.
I'll retry later tonight the process using the JDK8u65 as currently we are using JDK7u21.
Keep you posted.
Many thanks for the comments and investigations.
Kind Regards,
Raf

Hi Eero,
Hi Jarno,
The proposed fix of Eero did work. Upgrading the java development environment towards JDK8u60 made the publishing process to continue and work as expected.
I'll close the issue for now as it seems to be caused by JDK and not the DITA-OT.
Thanks,
Raf

While upgrading Java proved to be a working workaround, topicmerge still consumes a lot of memory. This is because the output of merge is:

map
topics

in that order. To update the generated IDs into the map, the process cannot be streaming without buffers. I had a feature branch that changed the output so that the merged output was

topics
map

And only DOM document of the map is kept in memory, all topic content is directly flushed to final output stream. I think I'll land this change for 3.0, since it breaks backwards compatibility. The change is small and I'm actually pretty sure no one relies on that order, but still.


fetch mission-api-data and display on UI

Hello @ashmalzahra 👋 ,
In this PR, the following has been implemented 😄

Fetched data and updated Redux store
Upon first render fetched data from the SpaceX API endpoints using Missions API: https://api.spacexdata.com/v3/missions
Used React Bootstrap, a UI library to style the table as per the design
Rendered a table with the missions' data.

Hi @Balikuddembe ,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights

Connect to API ✅.


Publish documentation to ???

Where and how to publish documentation?

Published to Gitbook https://orakl-network.gitbook.io/docs/


Fix errors at rake docs and whitespace.

This fixes https://github.com/rack-test/rack-test/issues/182
Summary

Fix rake whitespace.
I changed the sed command format to run on GNU sed. Another version sed has been used before?
Change hanna to rdoc to generate RDoc document.
Because hanna latest version 0.1.12 is using very old rake as runtime dependency.
That causes install error.
rdoc does not have any runtime dependency. It looks better.

Ref:

https://rubygems.org/gems/hanna
runtime dependencies
rake ~> 0.8.2
https://rubygems.org/gems/rake
rake is 12.0.0

Use cases
whitespace
$ vi lib/rack/test.rb

$ git status
On branch hotfix/fix-rake-docs-and-whitespace
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   lib/rack/test.rb
...

$ git diff
diff --git a/lib/rack/test.rb b/lib/rack/test.rb
index b7288c6..8aa3f85 100644
--- a/lib/rack/test.rb
+++ b/lib/rack/test.rb
@@ -6,7 +6,7 @@ require "rack/test/mock_digest_request"
 require "rack/test/utils"
 require "rack/test/methods"
 require "rack/test/uploaded_file"
-require "rack/test/version"
+require "rack/test/version"   <= tailing space

 module Rack
   module Test

$ bundle exec rake whitespace
find . -name '*.rb' -exec sed -i 's/ *$//g' {} \;

$ git status
<= no difference

docs
$ bundle exec rake docs
...
rdoc --title 'Rack::Test 0.6.3 API Documentation'
Parsing sources...
...

Then see doc/index.html.

Thanks for the reviewing!


Embulk preview ``-L'' option raise exception.

Embulk preview -L raise the following exception.
2016-08-04 19:33:00.900 +0900: Embulk v0.8.12
ArgumentError: wrong number of arguments (1 for 4)
                   initialize at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/stub_specification.rb:339
  block in setup_plugin_paths at /path/to/home/.embulk/bin/embulk!/embulk/command/embulk_run.rb:339
                        chdir at org/jruby/RubyDir.java:323
  block in setup_plugin_paths at /path/to/home/.embulk/bin/embulk!/embulk/command/embulk_run.rb:337
                         each at org/jruby/RubyArray.java:1593
  block in setup_plugin_paths at /path/to/home/.embulk/bin/embulk!/embulk/command/embulk_run.rb:335
                         each at org/jruby/RubyArray.java:1593
           setup_plugin_paths at /path/to/home/.embulk/bin/embulk!/embulk/command/embulk_run.rb:327
                          run at /path/to/home/.embulk/bin/embulk!/embulk/command/embulk_run.rb:287
                        <top> at /path/to/home/.embulk/bin/embulk!/embulk/command/embulk_main.rb:2
                      require at org/jruby/RubyKernel.java:944
                       (root) at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:1
                        <top> at file:/path/to/home/.embulk/bin/embulk!/embulk/command/embulk_bundle.rb:51

Reproduce step.
embulk new ruby-input sample
2016-08-04 19:31:15.982 +0900: Embulk v0.8.12
Creating embulk-input-sample/
  Creating embulk-input-sample/README.md
  Creating embulk-input-sample/LICENSE.txt
  Creating embulk-input-sample/.gitignore
  Creating embulk-input-sample/Rakefile
  Creating embulk-input-sample/Gemfile
  Creating embulk-input-sample/.ruby-version
  Creating embulk-input-sample/embulk-input-sample.gemspec
  Creating embulk-input-sample/lib/embulk/input/sample.rb

Plugin template is successfully generated.
Next steps:

  $ cd embulk-input-sample
  $ bundle install                      # install one using rbenv & rbenv-build
  $ bundle exec rake                    # build gem to be released
  $ bundle exec embulk run config.yml

in:
  type: sample
  option1: 123
out:
  type: stdout

embulk preview -L embulk-input-sample conf.yml

One more thing. He said that the -L option does not work with -b option.
I'm not familiar -L option. so I'm not sure it's spec or bug.
Twitter

I'm now sure how to fix this. but I would like to share this information.
https://github.com/embulk/embulk/blob/master/lib/embulk/command/embulk_run.rb#L341
        Dir.chdir(path) do
          # cd to path because spec could include `git ...`
          stub = Gem::StubSpecification.new(spec)
          stub.define_singleton_method(:full_gem_path) { gem_path }
          Gem::Specification.add_spec(stub)
        end

Gem::Specification#add_spec is now Deprecated method.
https://github.com/rubygems/rubygems/commit/33f03a482e1ca0a53d70ba488c757f62195bca41


Bug: Pydantic "escape hatch" no longer available

Expected Behaviour
The Parser documentation FAQ states that an "escape hatch" mechanism can be used to access imports from the base pydantic library that are not otherwise available as imports from aws_lambda_powertools.utilities.parser: https://docs.powertools.aws.dev/lambda/python/latest/utilities/parser/#faq.
Current Behaviour
aws_lambda_powertools.utilities.parser.pydantic is not a valid import path. (This may have been an older feature that has since been removed.)
Code snippet
from aws_lambda_powertools.utilities.parser.pydantic import <what you'd like to import'>
Possible Solution
If all pydantic imports can be made available at aws_lambda_powertools.utilities.parser.pydantic (likely by modifying aws_lambda_powertools/utilities/parser/__init__.py), that would be ideal. Otherwise, the documentation should be updated to remove this feature.
Steps to Reproduce
Attempting to import anything from aws_lambda_powertools.utilities.parser.pydantic will result in an import error.
Powertools for AWS Lambda (Python) version
latest
AWS Lambda function runtime
3.12
Packaging format used
Lambda Layers
Debugging logs
No response

For reference, I was trying to import computed_field, but
from aws_lambda_powertools.utilities.parser import computed_field

is not a valid import.

Hey @areifert thanks a lot for opening this issue! In fact we are not exporting Pydantic objects from parser and we explain that in our upgrade guide to v3.
In Powertools v3 we have dropped support for Pydantic v1 and are only supporting Pydantic v2 which is why we are no longer exporting pydantic types directly and allowing customers to import them directly from Pydantic. First, I must say that I agree with that we need to update our documentation and we are already doing this. I'll try to merge this PR as soon as possible to prevent this type of error.
Let me explain some reasons why we removed this export:
1 - Pydantic V2 was a complete refactoring of the Pydantic project and they made several changes including, but not limited, to the way they export types, classes, methods, and others. If we continue to expose them directly from Powertools and some export in Pydantic has changed, our customers may get the impression that there is some bug in Powertools and that is not the experience we want to have for our customers.
2 - The way we were doing this was by exposing everything exposed from pydantic to our customers, but there is a long discussion in the Pydantic repository about how https://github.com/pydantic/pydantic/discussions/6748 when importing and loading things in this new version. We don't want our customers to inadvertently import everything from Pydantic and this could create some slowdown in their functions.
Can you please try importing them directly from Pydantic?

@leandrodamascena: this is perfect, thanks for the detailed response. I was able to import computed_field directly from Pydantic.
It looks like some Pydantic exports are still available from aws_lambda_powertools.utilities.parser (e.g., BaseModel); going forward, is it recommended that all of these be imported directly from Pydantic instead?
(P.S.: I've been using Powertools for only a month or two and am really enjoying it, thanks for all you do!)

It looks like some Pydantic exports are still available from aws_lambda_powertools.utilities.parser (e.g., BaseModel); going forward, is it recommended that all of these be imported directly from Pydantic instead?

This is expected because now we just export BaseModel, Field, ValidationError, field_validator, and model_validator, the functions/classes that we must use in our utilities, including parser. The old way we were exporting  * from pydantic and errors.

(P.S.: I've been using Powertools for only a month or two and am really enjoying it, thanks for all you do!)

Hey, that's awesome to hear! We're here to support you in any way you need. Feel free to open an issue or talk to us on our Discord server https://discord.gg/B8zZKbbyET
Closing this issue.


test suite fails towards robur now

... should be looked into.

Deja-vu ... RRULE with freq set to yearly expands to a monthly event.  I believe I've reported this upstream at some point.


Scenario name not serialised to JSON in 2.33.0

Hi there,
I'm looking at updating wiremock-php to support wiremock 2.33.0. It looks like the 2.33.0 release has removed the name field from JSON serialized Scenario objects returned by the admin API. I'm not quite clear if this is intentional or not?
It looks like the change is due to adding @JsonIgnoreProperties({"name"}) to Scenario (so it looks intentional), but the same commit includes a comment referencing keeping JSON backwards compatibility and the admin API reference still shows a name field in the sample response.
Could you please confirm if it's a bug in the API (in which case I'll assume it'll be fixed soon, and not support this in wiremock-php) or if the reference is wrong (in which case I'll look to make wiremock-php consider this an optional field, defaulted to id when it's missing, and perhaps mark it as deprecated)?
Thanks,
Rowan

Hi Rowan, thanks for flagging this.
You're correct that I intended to leave name in there for backwards compatibility but was guilty of not writing a test for this. Patch release on its way...

2.33.1 is up now, with this fix


Fix last merge conflict

New readme change prevented merging into master, so I needed to pull master into this branch again

Should this one show 92 commits? In #811 it shows just 1.

Closing and re-opening on a brand-new branch to see if I can get it to not be 92 commits


feat(frontend): add network selector in Activity page

Motivation
We would like to include the logic of the NetworkSwitcher in the Activity page.
Basically:

It will not appear if testnet is not enabled and show Chain Fusion tokens transactions.
It will appear when testnet is enabled and allows to filter transactions per network.

NOTE: By default all networks (Chain Fusion) shows everything except transactions of testnet tokens.
Changes

Add NetworksSwitcher in unified transaction component.
Add route parameters breakdown in +page of Activity.
Change tokens store in unified transaction list to be enabledNetworkTokens.

Tests
https://github.com/user-attachments/assets/cf54b381-b2cc-4103-9311-959e602ed967

have you try to have the switcher after the message box?

Good suggestion! I talked with the design team and they told me that for now it is better to leave it there, since there is discussion to hide the message box when it does not concern (for example, hide the BTC disclaimer if you are in Ethereum).
So, visually, it is better to leave it below in that case.
In any case, they will discuss it, and if they decide to not hide the message box, then it makes sense to see if we can move it

[OISY-409]


Redacted Data Reading Proficiency Popup

In the popup, the reading proficiency percentage is showing as Proficiency Score: 7777700%.

Having a tough time on this one.  Popup is created with popuptemplate which seems to be a black box for feature layers.  Can seem to find how to add logic.

Got it, thanks Vern.  Connect.connect


Savannah Update: JTAC tcom, more furniture in maints, guitars

About the PR
Added:

JTAC t-com server
2 guitars and saxophone
filling cabinets, closets, large crates, racks, beer in maints
flood lights
removed wrong placed light fixture

Unmap instruments please

done


wavedec2 and waverec2 applied consecutively don't return original image

See my notebook here for the issue.
Essentially, using transform = wavedec2(image) and recovery = waverec2(transform) should give me recovery==image. But this is not the case...
What am I doing wrong?

I am not sure I see the problem in your example.  The root mean square error you observed is on the order of 1e-8?  When I ran on my machine from current master this was on the order of 9e-11 which is better, but either way that seems pretty good for images scaled in the range [0, 255].  The implementation is based on convolutions using floating point arrays, so there will be some degree of numerical error and the difference image will not look like zeros.

does not seem to be a bug, so closing this one.  Please use the mailing list at http://groups.google.com/group/pywavelets for general questions on usage.


Help needed: BME280 SSD1306

Hi guys!
Maybe someone has an example for BME280 using with SSD1306 Oled display?
Thanks

Its done.


Tooltip not working if values are missing

Testcase: http://jsbin.com/hafopu/4/edit?html,js,output
When comparing 1-12/2014 to 1/2015 then values for the months 2-12/2015 are missing. If you hover over these bars a JavaScript error will be thrown instead of showing a tooltip with just the value of the 2014 month.
[Error] TypeError: undefined is not an object (evaluating 't.highlightFill')
(anonyme Funktion) (Chart.min.js, line 10)
each (Chart.min.js, line 10)
(anonyme Funktion) (Chart.min.js, line 10)
(anonyme Funktion) (Chart.min.js, line 10)

The release notes of v1.0.2 say "Fixes a divide by zero error with only one label" but the problem still exists as it seems.

Further more, if the value is 0 and barShowStroke is set to false. In that situation nothing is actually rendered for that specific bar, so there's nothing to hover over.

This has been fixed in v2. See: https://jsfiddle.net/k8xsnpu3/1/


mobile: Fix RTDS integration test

/assign-from @envoyproxy/senior-maintainers

/retest

@abeyad @fredyw Just run into this for our import, and do we need any improvement for the CI to catch this problem?

@abeyad @fredyw Just run into this for our import, and do we need any improvement for the CI to catch this problem?

Yeah, we are planning to enable CI with xDS enabled to catch this.


Sporadic Error - "Buffer is currently not delivered!"

Hello,
I have an IDS Camera IDS GV-5260CP with Genicam.
I was able to successfully write this script here. However, now sporadically an error occurs when I want to take a photo (execute the shoot_image function).
AccessDeniedException: GenTL exception: Requested operation is not allowed. (Message from the source: Buffer is currently not delivered!) (ID: -1005)
I wonder if the error is on behalf of Harvesters (@kazunarikudo), because I don't have an error with the IDS library...
Could someone help me here? Is it possible that I still have to do some steps regarding the buffer?
Thanks a lot!
class CameraController:
    def __init__(self, PATH_GENICAM_CTI, exposure_time: int = 20000):
        self.h = Harvester()
        self.h.add_file(PATH_GENICAM_CTI)
        self.h.update()

        self.ia = self.h.create_image_acquirer(0)
        self.ia.remote_device.node_map.ExposureTime.set_value(float(exposure_time))
        self.ia.start_acquisition()

    def shoot_image(self):
        with self.ia.fetch_buffer() as buffer:
            component = buffer.payload.components[0]
            data_format = component.data_format
            content = component.data.reshape(component.height, component.width).copy()
            content_bgr = cv2.cvtColor(content, cv2.COLOR_BAYER_RG2BGR)
            return content_bgr

    def close_connection(self):
        self.ia.destroy()
        self.h.reset()

@marvher Hi, I am sorry for having kept you waiting. I guess I'm trying to update the chunk data even though the buffer itself is not complete. I will try to check the code and provide the fix as soon as possible. Thanks, Kazunari.

I have just merged a branch into the master: You will never have any buffer that is incomplete hence you should not face the exception above anymore. On the other hand, please note that there is a case where the fetch_buffer method call ends up with a time-out due to incomplete buffers that float under your feet. If the fetch attempt ends up with a time-out then the method throws the genicam.gentl.TimeoutException. If you need a valid buffer anyway, please catch the exception and call the fetch_buffer method again until you get a valid buffer.

Hello @kazunarikudo, no problem, thanks for your answer and explanation!
In fact, I have now done exactly the same as you suggested :)
Thanks a lot for that!
Cheers!

@marvher Hi, thank you for the update. Keep happy coding!


Enable execution for multi instances

This work is built on top of #51. So, it needs to rebase off once #51 is merged.

I'd suffered that the SEGV issue on hot-reloading. After applied the hot-reloading fix PR on the corresponding callback PR, the SEGV issue is gone.

Now that #51 has been merged can we get this rebased for testing? I might be able to debug the crashes in the log functions.

I rebased off the current main.

I ran the core-http-loader with the following configuration:
go.mod:
module github.com/calyptia/core-fluent-bit-plugin-http-loader

go 1.21.0

toolchain go1.21.1

require (
	github.com/Masterminds/sprig/v3 v3.2.3
	github.com/alecthomas/assert/v2 v2.3.0
	github.com/calyptia/api v1.4.7
	github.com/calyptia/plugin **v1.1.2-0.20231024020218-cbc15ad4bf73**
	github.com/go-playground/form/v4 v4.2.1
	github.com/itchyny/gojq v0.12.13
	github.com/peterbourgon/diskv/v3 v3.0.1
	github.com/peterhellberg/link v1.2.0
	github.com/stretchr/testify v1.8.4
	github.com/vmihailenco/msgpack/v5 v5.3.5
	golang.org/x/oauth2 v0.11.0
)

...

 If not, then it seems that the plugin is working as intended.
I recommend adding an integration test specifically testing scenarios that used to cause segmentation faults in earlier versions of the plugin, but that is out of scope for this actual pull request.
LGTM
:+1:

My configuration may not have caused the same segmentation faults because I was using multiple instances of the same plugin? @cosmo0920. If not, then it seems that the plugin is working as intended.

In my confirmations, I used in_gdummy plugin in multiple times. However, I adopted this PR to Golang 1.20. This could be affected for the different behavior. Thanks a lot for your confirmation.


Add currency conversion API

Here's an example that we use currently:
https://markets.api.bitcoin.com/rates/convertor?c=BCH&q=EUR

USD and CAD are supported natively rn.


Need group style option in tableview

I think tableview with group style is more suitable for settings because of the sticky section cells. Can you add a group style option?

Hi,
I think that sticky sections work only with Plain style, with Grouped style sections cells are not sticky. Current behaviour is based on .Plain style and section headers are sticky. I can optionally add a setting allowing to change table view style when initialising SwiftySettings, so that you can change this behaviour. What do you think?


improvements to pretty printer

Read the code and realized some code that can easily be removed.

LGTM, thanks


Promoting onError to beta 🎓

Changes
Pipeline 0.27 was released in August 2021 which introduced an alpha feature to specify onError in a step. This feature was implemented in the PR #4106.
To enable this feature, the Tekton Pipeline deployment had to set enable-api-fields to alpha.
After discussing this in the API WG:
https://docs.google.com/document/d/17PodAxG8hV351fBhSu7Y_OIPhGTVgj6OJ2lPphYYRpU/edit#heading=h.ig94pf1w10xc
I have sent an email out to collect the feedback from the users.  @skaegi is looking forward to this promotion.
Following the promotion guidelines, this commit includes:

Updating task validation to no longer require enable-api-fields set to alpha.
The documentation is updated to move it out of the alpha section.
Moved the example yamls out of alpha.

/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Docs included if any changes are user facing
[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes
Announcement: onError in a step is now stable and available to include in your task definition without any flag.

/test pull-tekton-pipeline-alpha-integration-tests

Sounds good to me!!
/approve

/test tekton-pipeline-unit-tests

re-lgtming now that tide is unblocked and other prs have merged
/lgtm


[NoQA] Increase the octokit gh throttling times

Details

In case when there was many PRs in the deploy, we have experience rate limitting as we dont wait between the issue comment requests. This PR is adding 1s sleep between the create comment requests to avoid this happening in future.
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/293688
PROPOSAL: GH_LINK_ISSUE(COMMENT)
Tests

N/A

[ ] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Ensure the deploy works correctly and all the PRs deployed got a message posted on them.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos
No need for screenshots because the changes are only in CI/CD

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Reviewing the PR now

@mountiny With the last change, this seems to be working in Fiddle with the mock code. Is there any different way i can test this out? not sure on this since it essentially adds comments to PR

Also add onSecondaryRateLimit that logs a warning and returns true. This should pause for 60 seconds to address rate limiting.

Once you are secondary rate limited the pause doesn't help for an hour, you cannot create content for an hour.
The one second sleep is the advised fix in the GitHub documentation here:

If you're making a large number of POST, PATCH, PUT, or DELETE requests for a single user or client ID, wait at least one second between each request.

Not sure if there is a good way tot test this now either @abdulrahuman5196 thanks for testing with the fiddle!
@roryabraham thanks for the links! I have assumed what Andrew mentioned, once we hit this rate limit we cant easily just wait to retry later, so I think that 1 second wait is better at this point. Let me know what you think, thanks!

The plugin already does 1, 2, or 3 second sleep between every request, depending on the type of request link

From the octokit docs:

In order to automatically throttle requests as recommended in GitHub’s best practices for integrators, we recommend you install the @octokit/plugin-throttling plugin.

Seems like comments should be rate limited then: https://github.com/octokit/plugin-throttling.js/blob/main/src/generated/triggers-notification-paths.ts#L9C2-L9C2
I like the idea of just increasing retryAfterBaseValue by 2x, I think it will allow us to scale slightly more.
Long term however, we are still using a Personal Access Token based bot, correct? I think we might need to look at moving over to an GitHub App bot e.g. Mevlin-Bot[Bot] like we have in other repos, from my testing previously I think you can create ~4x the amount of triggersNotificationPaths style API calls.

Once you are secondary rate limited the sleep(60) doesn't help for an hour, you cannot create content for an hour.

Got a source?
Regardless, we could still do the other two things I suggested as well to increase the amount of throttling we do in general:

update this to retry more than once, let's say 5 times
pass a higher value for options.retryAfterBaseValue to the plugin. It defaults to 1000ms, we could bump that to 1500 or 2000ms.

Ultimately the throttling we get from the plugin is more sophisticated than a basic 1-second throttle between requests + accounts for the retry-after headers we get from the API, including extra throttling that can occur during GitHub incidents. Increasing the options.retryAfterBaseValue would have the same effect as this but would be applied to all requests, not just the deploy comments.

Long term however, we are still using a Personal Access Token based bot, correct? I think we might need to look at moving over to an GitHub App bot e.g. Mevlin-Bot[Bot] like we have in other repos, from my https://github.com/Expensify/Expensify/issues/200920#issuecomment-1064663941 the amount of triggersNotificationPaths style API calls.

Definitely down to open an issue for this, seems like a good solution to allow us to scale up 👍🏼

Got a source?

No, just experience from my testing in the past. We should also rename the function to fix this:

[@octokit/plugin-throttling] onAbuseLimit() is deprecated and will be removed in a future release of @octokit/plugin-throttling, please use the onSecondaryRateLimit handler instead

@roryabraham @AndrewGable Updated with the suggestions, thanks for patience
I agree using github app bot would be best here to also align with our other github flows.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Going to merge this since we agreed on the approach in the convo above.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.39-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.39-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Setup Kanban board

Here is the link of our project:
https://github.com/edi-sipka/meals_capstone/projects?type=classic
Team members are:
@aamirkhan2478 / Student A
@edi-sipka  / Student B
@GloireIrenge / Student C

Hello @leonardodiasb!

I guess now we provided correct link, right?

Related to team members assignment you can check on our issue that it was from the beginning team member names and card number ( who is A,B and C). What i am missing here?

Thank you in advance.

Hi @edi-sipka,
Congratulations! 🎉
Your project is complete!  There is nothing else to say other than... it's time to merge it 🚀 :
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


[Stepper] Optional step label

Description
It will be nice if we have Optional step parameter in Step Label of Stepper component
Images & references
https://material.io/guidelines/components/steppers.html#steppers-specs

This has been fixed as part of the new Stepper - see 96c372446 in #4799


OOP-lite: back from the dead

As per previous conversations, I've removed the resolve function from the Challenge library in https://github.com/AdChain/AdChainRegistry/commit/a49bc46fabb6ca65b0749a8e766fd69514d4f12a:
The resolve member function of the Challenge struct made state changes
which would result in only the partial completion of the resolution
task. This was more dangerous than the code it de-duped, because it
made it seem that other *necessary* state changes that might be required
in the complete resolution of a challenge might be done by the resolve
method. They're not. Challenge resolutions are heterogenous, and short
of being able to pass function types into a resolve method, the resolver
itself needs to operate on the internal state of the Challenge struct.
More important to keep that totally explicit than it is to dedupe a
small number of lines. (Though if, in the future, we could solve this
more elegantly that would be highly desirable).

With that out of the way, I feel this PR is something of a half-measure but still an overall improvement to the codebase. Compare: https://github.com/AdChain/AdChainRegistry/compare/develop...a49bc46fabb6ca65b0749a8e766fd69514d4f12a
This does not actually reduce our testing burden, but it does allow us to dedupe some code and separate concerns. With the resolve method removed it doesn't confuse who gets to change internal state: the contract in which the Challenge resides must mutate its state to resolve a challenge, and we bundle that up in one private (implicitly dangerous) method.

BREAKING CHANGES:
determineReward -> challengeWinnerReward
calculateVoterReward -> voterReward
Just name changes. Arguments and returns are the same.

If a user calls claimReward directly, state will not be messed up, but an expected event in the wrapper contract might not fire, which could confuse some UIs.

lgtm @skmgoldin !


disasm error

Hi, i got error with command  "hbctool disasm index.android.bundle test_hasm". Please help:
[*] Disassemble 'index.android.bundle' to 'test_hasm' path
Traceback (most recent call last):
File "C:\Program Files\Python310\lib\runpy.py", line 196, in run_module_as_main
return run_code(code, main_globals, None,
File "C:\Program Files\Python310\lib\runpy.py", line 86, in run_code
exec(code, run_globals)
File "C:\Program Files\Python310\Scripts\hbctool.exe_main.py", line 7, in
File "C:\Program Files\Python310\lib\site-packages\hbctool_init.py", line 61, in main
disasm(args['<HBC_FILE>'], args['<HASM_PATH>'])
File "C:\Program Files\Python310\lib\site-packages\hbctool_init.py", line 33, in disasm
hbco = hbc.load(f)
File "C:\Program Files\Python310\lib\site-packages\hbctool\hbc_init_.py", line 28, in load
assert magic == MAGIC, f"The magic ({hex(magic)}) is invalid. (must be {hex(MAGIC)})"
AssertionError: The magic (0x55425f5f20726176) is invalid. (must be 0x1f1903c103bc1fc6)

You don't seem to be passing a proper index.android.bundle file. Those initial bytes decode to
00000000: 5542 5f5f 2072 6176                      UB__ rav


Fetching plugin takes forever

I'm setting up ObjectBox on an existing project. After adding the plugin to the build script class path, building the project takes forever:
root build.gradle:
buildscript {
    repositories {
        jcenter()
        maven { url "http://objectbox.net/beta-repo/" }
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:2.3.0-rc1'
        ...
        classpath 'io.objectbox:objectbox-gradle-plugin:0.9.8'
    }

Without io.objectbox on the class path, running ./gradlew clean --profile takes about 10 seconds
When I add io.objectbox back, running the same ./gradlew clean --profile takes about 5 minutes.

Must have been part of the S3 outage yesterday. I can't reproduce today. Thx


Dictation initial implementation

Pull request provides initial implementation for dragon diction integration. By modifying the Slate.js source code, we are able to pass the Slate Editor an onInput function that can handle structured phrase parsing.  So far 3 bugs with dictation that have been identified (and for which JIRA's have been logged):

Entering in "new line" through the mic will a) overwrite everything on the current line with whatever follows the last "new line" keyword, and b) often un-syncs Slate's model of editor content and actual editor content, resulting in text that you cannot delete/edit.
Insertions in the middle of an existing line of text will insert properly, but the cursor will be pulled to the end of the line.
Using the '@' symbol between two words results in a concatenation "previousWord@nextWord" that resembles email formatting, likely because Dragon assumes you're writing an email address.

N.B. that issues 1) and 2) are a product of how we do insertions in onInput. Our implementation is currently limited by our inability to access the chunk of text Dragon is inserting. If someone can find a way to access that information from the event we're handling, or figure out how to infer it indirectly, these issues should resolve seamlessly.
Pull requests into Flux require the following: Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable (N/A) and ✅.
Submitter: Dylan
Documentation

[x] This pull request describes why these changes were made
[x] Recognizes any potential shortcomings/bugs in the description
[x] N/A Cheat sheet is updated
[x] Demo script is updated
As of now, I think the best place for this would be in the second half of the demo when we're doing structured data insertions. The '#' doesn't have the same issues that the '@' has, and we shouldn't need to use any new lines if we're at the end of the demonstration.
[x] Documentation on Wiki has been updated
[x] N/A Additional technical components and libraries are documented and added to wiki as needed

NoteParser

[x] N/A Note parser has been updated if structured phrases change

Code Quality

[x] 4-space indents - convert any tabs to spaces
This is a bizarre case because the source code I copied over has not been reformatted; that would make a future pull request way harder. I think because of this that we should get a pass on this. Please?
[x] Use public class field syntax for binding functions - ex. handleChange = () => { ... };
[x] Code is commented

Tests

[x] Existing tests passed
I'm leaning towards relying on manual tests for dictation, but I'm open to other options.
[x] N/A Added UI tests for slim mode
[x] N/A Added UI tests for full mode
[x] N/A Added backend tests for fluxNotes code
[x] N/A Added note parser examples to test new functionality

Reviewer 1: Julia

[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] N/A The tests appropriately test the new code, including edge cases
[x] You have tried to break the code

Reviewer 2: Name

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

difficult to test this without Dragon. Maybe we should schedule 30 minutes for the team to watch a demo of using Dragon with Flux? I looked at the code and it looks fine to me. I see you are supporting passing in an onInput handler into Slate now which makes sense to me. That is then used by our editor and it passes what it receives on to the handleSummaryUpdate method (we need to rename that at some point!). So code looks good, but do people feel we need a demo?

Understandable! I could walk through it with people tomorrow if people are around!

This looks good to me! I reviewed the code and tried to break it (without using the dictation) and everything looks like it is working as it was before. All the tests pass, and I agree with manual testing for dictation. I'm around today if we want to run through a demo of the dictation, or I can look at getting it running to test it on the demo machine.

Also, this should get rebased before merging since Greg's pull request was merged yesterday.

Heads up to everyone not in the lab today -- after a review of the dictation tests in person, the team said we're all set to merge!


External name does not update when the initial cluster is deleted and it gets recreated

After step 5/5 https://github.com/thechangelog/changelog.com/pull/399, the cluster's external name does not get updated:

External name is still 49593, the new external name is 49594
Let's pair-up on this @muvaf so that I can show you live what I mean 👍🏻

This is fixed with https://github.com/crossplane/terrajet/pull/190 . So, updating to the latest Terrajet should fix it for this provider.


Compatability with Quantum Space Buddies (Multiplayer mod)

I haven't tested this, but it would be incredible to be able to play this game VR in multiplayer.

Just to get folks on the same page, potentially: https://github.com/misternebula/quantum-space-buddies/issues/246

I'm not that knowledgeable about the inner workings of either mods, but at their current state, a support from either is difficult, mostly because of the harmony patches that they have. _nebula is working and reworking stuff, so maybe some kind of API can be made available, and then someone can try connecting the mods. But still, they both change lots of stuff, and a conflict is almost inevitable.

I can say that there will be no effort from me to make this compatible. Even when I first created the QSB project, I had no intention of making them compatible. Both mods require modifying code in many, many parts of the game. So conflicts are very likely to happen. Would just be too difficult to keep them working together. The mods are already hard enough as they are.
I'd say the best chance this has of seeing the day of light would be if someone creates a Virtual Reality Space Buddies that merges both mods into one. Probably only after QSB is more complete.
In any case, I'm not actively developing NomaiVR anymore, so I wouldn't do something this big anyway.

I can say that there will be no effort from me to make this compatible. Even when I first created the QSB project, I had no intention of making them compatible. Both mods require modifying code in many, many parts of the game. So conflicts are very likely to happen. Would just be too difficult to keep them working together. The mods are already hard enough as they are.

Agreed. And while continuing making QSB (Rai made up to version 0.1.2 I think? and it's on 0.7.0/0.8.0 currently), I certainly haven't been thinking about VR compatibility.

@misternebula is here 😍 I'm a huge fan will you sign my repo

🖋 : _nebula


Windows installer

Partially fixes #3209 by addressing an issue Windows was having with the HDF5 initializer.
@stasj Could you take a look at the errors in osgl and vapi?  Here's a link to the status of our current build.

Partially fixes #3209 by addressing an issue Windows was having with the HDF5 initializer.
@StasJ Could you take a look at the errors in osgl and vapi? Here's a link to the status of our current build.

This PR is building on Windows for me so this may be an issue specific to Circle?

@stasj Could you grant me write permissions to your directory on cisl-vaporwin10.cis.ucar.edu?  Or alternatively copy the directory and give me write permissions on that one?  I'm hitting build errors on that machine, CircleCI, and two of my own windows computers.  I gotta find out what's different between those systems and the one you're building on.

@StasJ Could you grant me write permissions to your directory on cisl-vaporwin10.cis.ucar.edu? Or alternatively copy the directory and give me write permissions on that one? I'm hitting build errors on that machine, CircleCI, and two of my own windows computers. I gotta find out what's different between those systems and the one you're building on.

I was not using cisl-vaporwin10. It was a fresh windows/VS/third party lib install.

Ok, got it.  That's really strange.  I'm currently able to build, install, and run Vapor now though.  It required disabling the vapi build, as well as the the osgl tests for Windows.  I'm going test all of the platforms in a little bit, and if they all pass I'll re-request review.


Context.typeof has side effects (inference. others?)

As shown here: http://try-haxe.mrcdk.com/#DeCd8
Calling Context.typeof can cause monomorphs to harden. So my strategy of "call typeof until one succeeds" is not 100% fail-safe.
I could warn if any of the incoming params are monomorphs (though I think the behavior could be deeper than the params themselves?)

Idea: replace monomorph inputs (just for the typeof call) with throw-away variables... So instead of typing:
tools_class.replace(subject, [foo, bar]);

Upon detecting that foo is a monomorph, instead type:
{
  var __protect_foo;
  tools_class.replace(subject, [__protect_foo, b]) ;
}

Thus, foo is not morphed and __protect_foo is just a temporary identifier.


Init Powell Teams Connector

Please check the following conditions for your PR.

[x] apiDefinition.swagger.json is validated using paconn validate command.
[x] apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

@PowellSoftware Checking in on things - any questions about Srikanth's feedback?

@PowellSoftware Any update on updating your PR as per the given feedback? Please let us know if you have any questions.

@PowellSoftware  I'm just checking in to see how things are going with updating your connector as per the feedback. Feel free to reach out with any questions you may have.

@PowellSoftware I'm just checking in to see how things are going with updating your connector as per the feedback. Feel free to reach out with any questions you may have.

@PowellSoftware  Since there is no response, I am closing this PR, You can reopen it any time whenever you are ready.