iOS message is lost on cold start

When a PG/Cordova-App is closed and started upon user's activating the PushMessage, this message is not forwarded to Host-App.
It seems that plugin (PushPlugin.m) receives message and only afterwards comes registration from Host-App. So probably because, there is still no callbacks are registered. Message gets lost.
In my app PushNotification.init is called on cordova's onDeviceReady event.
The guys from https://github.com/Telerik-Verified-Plugins/PushNotification seem to handle the problem well. The scenario works on their code.

We are experiencing the same issue with version 1.1.1, but it seems to work ok with version 1.0.1.

@do34 and @martinfilliau what is the reproduction scenario for this one?
I have an app that is registered with my push service. I make sure it is not running by doing a swipe up on it in the task list in iOS. Then I send an push to the app and it shows up in the notification shade. When I click on this notification the app is started and my onNotification handler is executed with the info of the push notification.
What am I missing?

@macdonst your scenario is correct, and it does work for us in version 1.0.1 but couldn't get it to work in 1.1.1.   seems to be also described in #55 albeit I'm not sure which version is used.

Same problem here

I am having the same problem. The notification event is not fired in the iOS if the app was closed when the push notification was received.

I can reproduce this in version 1.2.2 - it works fine in Android but not iOS. I created a blank app and copied the code from the example/www folder into the app.
In the example app, the "card" with the notification details is only displayed if the app is open when the notification is received. If the app is not running and launched from the notification, the card with the notification details does not get displayed.

I think this might be a misunderstanding. It does work, but only if you tap the notification. If you just start the app it doesn't. Is this expected behaviour?

No, the problem apears when you tap de notification (when you tap the app icon it will never show the notification data)

I can now consistently reproduce the problem:

Close the app and lock the device.
Trigger a push notification.
Either swipe the notification on the lock screen or unlock the device and pull down notification centre, then tap the notification.
The didReceiveRemoteNotification method does not get called.

After this process, when the app is already running, the functionality works as expected. Until you close the app (double tap home, swipe up) and lock the device again.

Anything new about this issue?

@greg84 it seems that this is expected behaviour by iOS. The notification event doesn't get called until you tap on the notification.
I think you are looking for the same functionality as #93?

Just to clarify, #93 is talking about the app being able to run code while the app is closed when a notification is received. In this case however, I'm talking about the app running code when it is launched from a notification after being killed by the user (i.e. the user taps the notification to launch an app that's previously been forcibly closed from the app switcher).
I'm talking specifically about the following repro steps using the example app (where cards appear when a notification is received).

Open the app, trigger a notification, new card appears.
Go back to home screen, lock the device, trigger a notification, tap notification, app opens and new card appears.
Kill the app from the app switcher, lock the device, trigger a notification, tap notification, app opens but no new card appears.

I would expect number 3 to display a new card. It seems that this is expected behavior after the app has been forcibly closed by the user, but it's a bit strange. I'm not sure why killing the app should prevent the didReceiveRemoteNotification method from being called when the app resumes.
I could understand that if a user kills an app that runs code when a notification is received (like #93 talks about), you probably wouldn't want that to happen if you'd manually killed the app and stopped it from running. But I would still expect the method to run when I launch the app again from the notification.
As the links below explain, when a user force-closes the app, the callback method is no longer invoked.
http://stackoverflow.com/questions/18856204/applicationdidreceiveremotenotificationfetchcompletionhandler-not-called
http://stackoverflow.com/questions/19068762/will-ios-launch-my-app-into-the-background-if-it-was-force-quit-by-the-user/19202487#19202487
I've been reading the iOS docs. This section talks about the didReceiveRemoteNotification delagate:

If the app is not running when a remote notification arrives, the method launches the app and provides the appropriate information in the launch options dictionary. The app does not call this method to handle that remote notification. Instead, your implementation of the application:willFinishLaunchingWithOptions: or application:didFinishLaunchingWithOptions: method needs to get the remote notification payload data and respond appropriately.

My testing suggests that this hasn't been implemented properly. Although I might be misunderstanding how it actually works, in which case accept my apologies.

@greg84 just making sure. The worst part about this issue is that I'm following your reproduction scenario and in step three I do get the notification event in my sample app which creates a new card.
What version of iOS are you using?

@greg84 Please take a look at the attached video and let me know what I'm doing wrong trying to reproduce your problem.
https://dl.dropboxusercontent.com/u/887989/pushplugin/Issue50.mov

@macdonst The steps you followed in the video are the same as what I'm doing. Only difference is I'm using ios 8.4.1 on an iPad. I wonder if Apple fixed it in the latest update?

@greg84 you, I can reproduce on 8.4.1 now to see if there is anything I can do about it.

What you guys use as a solution on a case where the user launched the app using the icon on menu?
I think this is most common on IOS.

I gotta give up on this one as I believe it to be a bug with iOS 8.4.1. If anyone has a fix I'd love to merge a PR.

I have found the solution for this one. The reason for this issue is that in PushPlugin.m the callbackId property is set to nil on killing the app. As a result, the check on line#441 is not satisfied in the - (void)notificationReceived callback. The fix for the issue is to instantiate the PushPlugin class on opening the push notification every time your app starts. This can be done by registering the push notification plugin on app start.
Call the PushPlugin.init method in your javascript everytime your app starts, and this will instantiate the plugin and assign the appropriate callback and callbackid in the plugin. I have added the below code to my Ionic app's app.run() section
window.PushNotification.init({
    ios: {
       "badge": false,
       "sound": true,
       "alert": true,
       "clearBadge": true
   }
})

Let me know if anyone still faces this issue.

Hi @addi90 , i follow your solution but I always have this problem.
the callbackId property is nil when my app is in foreground and background but when my app closed my property is nil .


Provide Adaptive Authentication function to check user roles without caching

Current Adaptive Authentication related function, which is used to check user roles using caching internally. This is causing caching issues during authentication flow in multi node-setups when clustering is disabled. Need to provide Adaptive Authentication function to check user roles without caching to avoid this issue.

https://github.com/wso2-extensions/identity-conditional-auth-functions/pull/53 can be merged once a new version of the carbon-kernel is released.


[engine] Add doc references to application lifecycle classes once they exist.

In the platform dispatcher changes added by https://github.com/flutter/engine/pull/39836 there are two places where documentation references need to be added to framework classes that have not yet landed.
This issue is just to track that they are eventually added.

Fixed.


Test/fix mac

Fix Mac warnings.
Resolves #9411
Release note
None

@BusyJay PTAL

@BusyJay PTAL

/merge

/merge

/merge

/merge


check additional cost in registering pool to staking proxy at pool proxy creation

registering pool to staking has some cost, around 125k (could be something less and can be optimized by reducing initialization storage). Registering everything in 1 call has benefit of creating staking pool immediately.
Cons: when pool is registered, needs to collect eth, and buy grg first, then can stake. We can create staking pool when staking first time from pool.

does not make a lot of sense as would increase deployment cost.
Should implement staking adapter, so pool operator can stake at any time (could also implement
    buyGrgAndStake(uint256 grgAmount) {
        require(grgAmount > 100);
        _buyGrg(grgAmount);
        _approveGrgVault(grgAmount);
        _stakeGRG(grgAmount);
        bytes32 poolId = Registry(registry).getPoolIdFromAddress(address(this));
        _delegate(grgAmount, StakeStatus.Delegated);
}


Can you add/remove an image element to cropper object?

We would like to be able to add an icon to an image element and also be able to remove it.
I have seen documentations on multiple images but there doesn't seem to be any support for images to be added to the same cropper object and elements removed.
I am just wondering if I missed any documentations. Can someone please confirm if it is possible?
We want to be able to do something like this:

NOT support that. This is just a simple image cropper, not a full-featured image editor. I'm sorry.


editor splits not working, Code (& Codium BTW), 1.90.0 and 1.90.1

Does this issue occur when all extensions are disabled?: Yes
Issue is still present in Insider edition:
Version: 1.90.1
Commit: 611f9bfce64f25108829dd295f54a6894e87339d
Date: 2024-06-11T21:02:43.666Z
Electron: 29.4.0
ElectronBuildId: 9593362
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Linux x64 5.15.0-112-generic

Describe the bug
After Release 1.89.1 (this now includes both 1.90.0 and 1.90.1) the View->Editor Layout->Split [Up|Down|Left|Right] menus no longer have any effect. (This is true for both Code and Codium)
Please confirm that the issue/resolution isn't already documented
I checked after 1.90.0, and saw no mention of the issue. I retested with 1.90.1 and it is still present. Removing either and re-installing 1.89.1 or earlier resolves the issue.
To Reproduce
Steps to reproduce the behavior:

open any content
View->Editor Layout->Split [Up|Down|Left|Right] menus
See no splits appear

Expected behavior
selected splits should appear.
Screenshots
not applicable
Desktop (please complete the following information):
see sys info below
Additional context
Linux Mint 21.3
Sys Info:
System:
Kernel: 5.15.0-112-generic x86_64 bits: 64 compiler: gcc v: 11.4.0 Desktop: Cinnamon 6.0.4
tk: GTK 3.24.33 wm: muffin vt: 7 dm: LightDM 1.30.0 Distro: Linux Mint 21.3 Virginia
base: Ubuntu 22.04 jammy
Machine:
Type: Desktop System: Dell product: OptiPlex 5040 v: N/A serial:  Chassis:
type: 3 serial:
Mobo: Dell model: 0R790T v: A00 serial:  UEFI-[Legacy]: Dell v: 1.2.7
date: 01/15/2016
Battery:
Device-1: hidpp_battery_0 model: Logitech M570 serial:  charge: 40% rechargeable: yes
status: Discharging
CPU:
Info: quad core model: Intel Core i5-6500 bits: 64 type: MCP smt:  arch: Skylake-S
rev: 3 cache: L1: 256 KiB L2: 1024 KiB L3: 6 MiB
Speed (MHz): avg: 1644 high: 2500 min/max: 800/3600 cores: 1: 2500 2: 2109 3: 1067 4: 900
bogomips: 25599
Flags: avx avx2 ht lm nx pae sse sse2 sse3 sse4_1 sse4_2 ssse3 vmx
Graphics:
Device-1: NVIDIA GP108 [GeForce GT 1030] driver: nvidia v: 535.171.04 pcie: speed: 8 GT/s
lanes: 4 ports: active: none off: HDMI-A-1 empty: DVI-D-1 bus-ID: 01:00.0 chip-ID: 10de:1d01
class-ID: 0300
Display: x11 server: X.Org v: <IP_ADDRESS> driver: X: loaded: nvidia
unloaded: fbdev,modesetting,nouveau,vesa gpu: nvidia display-ID: :0 screens: 1
Screen-1: 0 s-res: 3840x2160 s-dpi: 162 s-size: 602x341mm (23.7x13.4") s-diag: 692mm (27.2")
Monitor-1: HDMI-0 res: 3840x2160 hz: 60 dpi: 163 size: 600x340mm (23.6x13.4")
diag: 690mm (27.2")
OpenGL: renderer: NVIDIA GeForce GT 1030/PCIe/SSE2 v: 4.6.0 NVIDIA 535.171.04
direct render: Yes
Audio:
Device-1: Intel 100 Series/C230 Series Family HD Audio vendor: Dell driver: snd_hda_intel
v: kernel bus-ID: 00:1f.3 chip-ID: 8086:a170 class-ID: 0403
Device-2: NVIDIA GP108 High Definition Audio driver: snd_hda_intel v: kernel pcie:
speed: 8 GT/s lanes: 4 bus-ID: 01:00.1 chip-ID: 10de:0fb8 class-ID: 0403
Sound Server-1: ALSA v: k5.15.0-112-generic running: yes
Sound Server-2: PulseAudio v: 15.99.1 running: yes
Sound Server-3: PipeWire v: 0.3.48 running: yes
Network:
Device-1: Intel Ethernet I219-V vendor: Dell driver: e1000e v: kernel port: N/A bus-ID: 00:1f.6
chip-ID: 8086:15b8 class-ID: 0200
IF: enp0s31f6 state: up speed: 1000 Mbps duplex: full mac:
IF-ID-1: vboxnet0 state: down mac:
Drives:
Local Storage: total: 2.05 TiB used: 1.79 TiB (87.0%)
ID-1: /dev/sda vendor: SanDisk model: SD8SBAT-256G-1006 size: 238.47 GiB speed: 6.0 Gb/s
type: SSD serial:  rev: 1006 scheme: GPT
ID-2: /dev/sdb vendor: Western Digital model: WDS100T2B0A-00SM50 size: 931.51 GiB
speed: 6.0 Gb/s type: SSD serial:  rev: 20WD scheme: MBR
ID-3: /dev/sdd type: USB vendor: Western Digital model: WD My Passport 25E1 size: 931.48 GiB
type: N/A serial:  rev: 1021 scheme: GPT
Partition:
ID-1: / size: 233.62 GiB used: 77.4 GiB (33.1%) fs: ext4 dev: /dev/sda3
ID-2: /boot/efi size: 47.2 MiB used: 6 MiB (12.8%) fs: vfat dev: /dev/sda2
ID-3: /home size: 915.82 GiB used: 606.89 GiB (66.3%) fs: ext4 dev: /dev/sdb1
Swap:
ID-1: swap-1 type: file size: 2 GiB used: 4 MiB (0.2%) priority: -2 file: /swapfile
USB:
Hub-1: 1-0:1 info: Hi-speed hub with single TT ports: 16 rev: 2.0 speed: 480 Mb/s
chip-ID: 1d6b:0002 class-ID: 0900
Device-1: 1-5:2 info:<PHONE_NUMBER>26 type: Mass Storage driver: usb-storage interfaces: 1
rev: 2.0 speed: 480 Mb/s power: 500mA chip-ID: 3207:0300 class-ID: 0806 serial:
Device-2: 1-8:3 info: Logitech Unifying Receiver type: Keyboard,Mouse,HID
driver: logitech-djreceiver,usbhid interfaces: 3 rev: 2.0 speed: 12 Mb/s power: 98mA
chip-ID: 046d:c52b class-ID: 0300
Hub-2: 2-0:1 info: Super-speed hub ports: 10 rev: 3.0 speed: 5 Gb/s chip-ID: 1d6b:0003
class-ID: 0900
Device-1: 2-5:2 info: Western Digital My Passport (WD20NMVW) type: Mass Storage
driver: usb-storage interfaces: 1 rev: 3.1 speed: 5 Gb/s power: 896mA chip-ID: 1058:25e1
class-ID: 0806 serial:
Sensors:
System Temperatures: cpu: 29.8 C pch: 63.5 C mobo: 27.8 C gpu: nvidia temp: 42 C
Fan Speeds (RPM): N/A gpu: nvidia fan: 87%
Repos:
Packages: note: see --pkg apt: 3997
No active apt repos in: /etc/apt/sources.list
Active apt repos in: /etc/apt/sources.list.d/gambas-team-gambas3-jammy.list
1: deb [signed-by=/etc/apt/keyrings/gambas-team-gambas3-jammy.gpg] https: //ppa.launchpadcontent.net/gambas-team/gambas3/ubuntu jammy main
Active apt repos in: /etc/apt/sources.list.d/jonaski-strawberry-jammy.list
1: deb [signed-by=/etc/apt/keyrings/jonaski-strawberry-jammy.gpg] https: //ppa.launchpadcontent.net/jonaski/strawberry/ubuntu jammy main
Active apt repos in: /etc/apt/sources.list.d/krupkat-code-jammy.list
1: deb [signed-by=/etc/apt/keyrings/krupkat-code-jammy.gpg] https: //ppa.launchpadcontent.net/krupkat/code/ubuntu jammy main
Active apt repos in: /etc/apt/sources.list.d/official-package-repositories.list
1: deb http: //packages.linuxmint.com virginia main upstream import backport
2: deb http: //archive.ubuntu.com/ubuntu jammy main restricted universe multiverse
3: deb http: //archive.ubuntu.com/ubuntu jammy-updates main restricted universe multiverse
4: deb http: //archive.ubuntu.com/ubuntu jammy-backports main restricted universe multiverse
5: deb http: //security.ubuntu.com/ubuntu/ jammy-security main restricted universe multiverse
Active apt repos in: /etc/apt/sources.list.d/vivaldi.list
1: deb [arch=amd64] https: //repo.vivaldi.com/stable/deb/ stable main
Active apt repos in: /etc/apt/sources.list.d/vscode.list
1: deb [arch=amd64,arm64,armhf] http: //packages.microsoft.com/repos/code stable main
Active apt repos in: /etc/apt/sources.list.d/vscodium.list
1: deb [ signed-by=/usr/share/keyrings/vscodium-archive-keyring.gpg ] https: //download.vscodium.com/debs vscodium main
Active apt repos in: /etc/apt/sources.list.d/warpdotdev.list
1: deb [arch=amd64 signed-by=/etc/apt/trusted.gpg.d/warpdotdev.gpg] https: //releases.warp.dev/linux/deb stable main
Info:
Processes: 295 Uptime: 11h 34m wakeups: 21 Memory: 15.54 GiB used: 4.87 GiB (31.4%)
Init: systemd v: 249 runlevel: 5 Compilers: gcc: 11.4.0 alt: 11/12 clang: 14.0.0-1ubuntu1.1
Client: Unknown python client inxi: 3.3.13

Same problem with 1.90.0 and 1.90.1 on macOS
ProductName:	macOS
ProductVersion:	12.7.5
BuildVersion:	21H122

Version: 1.90.1
Commit: 611f9bfce64f25108829dd295f54a6894e87339d
Date: 2024-06-11T21:44:54.914Z
Electron: 29.4.0
ElectronBuildId: 9593362
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 21.6.0

I believe I fixed a problem last Friday which also fixed this. This should work again in our newest Insiders build.
In the meantime you can still use the split feature by right clicking on a tab

I believe I fixed a problem last Friday which also fixed this. This should work again in our newest Insiders build. In the meantime you can still use the split feature by right clicking on a tab

I didn't know about that work-around before, but that does work on the broken version -- Thanks!
Trying the Insider's version next...


watermelon helmets can be made and have upstream armor

Description
butchering a watermelon lets you create a watermelon helmet. This helmet has upstream armor.
Reproduction
enter botany
plant watermelon
wait 3 years for it to grow
take a knife
RIGHT CLICK > BUTCHER (do not click on the melon that turns it into slices)
shift + click helmet
click armor value examine
see 5% upstream blunt resist
Additional context
most likely a non-issue

fixed by #4767


Add Difficulty Levels

Description:
This pull request adds difficulty levels to the Snake game, allowing players to choose between "Easy" and "Hard" modes. In "Easy" mode, the snake moves slower, while in "Hard" mode, it moves faster.
Changes:

Added difficulty buttons ("Easy" and "Hard") to the game screen.
Implemented functions to toggle and set the game difficulty.
Updated game delay and Added a difficulty label to display the current difficulty level.
Modified the reset_game function to reset the delay based on the current difficulty.

Testing:
Successfully tested the difficulty levels by playing the game in both "Easy" and "Hard" modes. The snake's speed adjusted accordingly, and the score display accurately reflected the current difficulty level.
Concerns:
No concerns at this time.

👍 👍  Thank you!


FIX: Do not break figure-datatype derivatives by sessions

This PR amends #507 so that the reportlets are not broken into sessions. The session is kept after the subject key though, so these files are still identifiable.

Looks reasonable.


API Docs Malformed Code Examples

There are malformed code examples on the API Documentation site in the following languages:

HTTP
PHP
Go
cURL

Instead of [object Object] it should include the object itself

The places where the code examples are malformed are:

HTTP:

PHP:

Go:

cURL:

Same issue occurred for these sections and only for the languages commented by @pcs289 :

https://api.pheatureflags.io/?go#retrieves-the-list-of-features-for-the-given-identity
https://api.pheatureflags.io/?go#retrieves-a-feature-for-the-given-feture-id-and-identity

Repo to contribute: https://github.com/pheature-flags/api-docs

This issue has been solved at https://github.com/pheature-flags/api-docs/pull/41


Not all lines coming through terminal.onLineData()

Not all lines are coming through terminal.onLineData(), which is what tasks uses for problem matchers. This means that some tasks won't report or won't clear problems because some of the lines are missing. This does not occur every time, but about 1 in 5 times. Lines missing is more dramatic when debugging since even more lines a missing.
Easy repro in the vscode repo:
Put a break point in the call to terminal.onLineData in terminalTaskSystem.ts
Run the strict null check watch task
Watch the lines that come through. There should be one about Starting incremental compilation, and it will likely be missing.

duplicate https://github.com/Microsoft/vscode/issues/57803


nixos: add deCONZ Zigbee gateway support

Description of changes
Add a NixOS module (and test) for the deCONZ Zigbee gateway software.
Commit list:

deconz: set meta.mainProgram
nixos/deconz: init
nixos/tests/deconz: init
deconz: add NixOS test to passthru.tests
deconz: fix meta.platforms
deconz: set meta.sourceProvenance

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

The changes over deconz can be squashed in only one commit.

The changes over deconz can be squashed in only one commit.

What would the topic be of such a commit?

deconz: refactor

- bullet
- list
- of
- changes

It's not refactoring though (https://en.wikipedia.org/wiki/Code_refactoring), since the patches introduce externally visible changes. (Actually, that's the only thing they do, so the changes are in fact of a non-refactoring character.)
I guess we could group 3 out of 4 deconz commits under deconz: improve meta attributes (+ bullet list body). But why? Is it to minimize the number of commits in a PR? That would take a 6 commit PR down to 4 commits. But we could make even bigger reductions by collapsing them all into the PR title nixos: add deCONZ Zigbee gateway support. ('m not suggesting that we do that.)
I think I prefer small and to-the-point commits. But if you have strong feelings about it, I can squash 3 deconz commits into 1?

Ok, that's fair. I've squashed.


Consider read-only OrderedDictionary rather than ReadOnlyDictionary for metadata type

ReadOnlyDictionary is difficult to construct in Powershell and may be an intimidating barrier to extension authors not fluent with C# (see https://github.com/PowerShell/SecretManagement/issues/108 for potential remediation on this point)
Further, ReadOnlyDictionary is case sensitive by default, which powershell users are normally not used to for property names. They would expect $secret.metadata.test and $secret.metadata.Test to return the same data, whereas currently only one will and one won't with ReadOnlyDictionary unless it was constructed with the correct stringcomparer
However, accepting an ordered in the secretinformation constructor makes it easy on extension authors who can just supply a hashtable or an ordered hashtable, and then secretmanagement can store/present with the AsReadOnly() method to get the same effect as a readonlydictionary using a non-generic type but one that is effectively string,object anyways.
Alternatively, the dictionary can be instantiated with StringComparer.OrdinalIgnoreCase, but this would require the extension author to implement correctly when supplying it to secretmanagement, leading to inconsistent user experience.

Evidence right here of this problem: https://github.com/PowerShell/SecretManagement/issues/116

Closing in favor of #108 approach.


Fix minor numpy bug

This PR fixes https://github.com/rapidsai/crossfit/issues/56

This was covered in: https://github.com/rapidsai/crossfit/pull/60/files#diff-7df28932e442bcba119ac55733d7222128331c1c716813d341ab6e25ab52d918


Always use IP addresses in tests (+ some minor improvements)

Last row of "random name" => IP address conversion.

The failure is repeating on ValidatorCleanRestart so we could merge this.


Difference Binding Context/Path at Popup and TestStep Screen

There is a different meaning within the popup after selecting an item and the setting for the teststep attributes table.
Maybe the Binding stuff has to be refactored altogether.

Combine any binding-related criteria into a single one that only checks for binding paths (e.g., default>/todos/1/title). The user should be able to see the resulting value, for instance, via a corresponding label.

I have pushed a commit to the branch binding-refactorings that is a further step towards the implementation of the idea sketched above. The binding is now checked against the fully-qualified binding path, including a prefix with the model name and the
binding context (e.g., "defaultModel>/todos/1/title").
There are still some issues open for this:

Code generation is not adapted yet. Maybe, we defer this until we have more work on Issue #38.
Composite bindings are not working properly yet as they do not have a reliable path -- which is currently needed in the code though. We need to discuss whether and how to support this.
https://github.com/msg-systems/ui5-testrecorder/blob/d386c0cebe90594795e41177c22929a125c7e372/scripts/injected/pageInject.js#L2191-L2199

With the changes in 44fb194e8b8498712052e7ff3173e2032d6d5db6, this is likely fixed. I will put this issue into the review state.


Modify the deletion of scheduled reports

This will get automatically pulled into the next UAT and production deployments. FYI @haykd


HTTPCORE-627: URIBuilder::Adding query parameters result in removing …

…the scheme specific part of an URI
Changed: URIBuilder to support new getter/setter to allow access to previously existing but private schemeSpecificPart variable. Idea was to open the class for more use cases, like RFC 6068. Issue discussion at HTTPCORE-627

@netsrotr Looks good to me. Could you please add @since 5.1 tags to the javadocs of the new methods and add public URIBuilder setSchemeSpecificPart(final String schemeSpecificPart, final NameValuePair... nvps) method as well?


try ruby 3.2

I think the spec/system/admin/good_job_spec.rb spec error is related to https://github.com/bensheldon/good_job/issues/1280 which needs a newer rails 6 (stable branch) or 7

replaced by https://github.com/Energy-Sparks/energy-sparks/pull/3678


ConsoleLite Design Update: Market List

ACs

[ ] It should match the new design
[ ] It should work in dark/light mode
[ ] It should be a sortable table
[ ] It should sort on clicking a column header
[ ] It should navigate to trade view for the marketId when you click on a row
[ ] It should work on screen readers for A11Y

Question: How many rows to display by default?
Question: Is this an infinite scroll?  If so this needs potentially a new ticket.
Question: Can you search? If so this needs a new ticket.

Action Needed: Please provide icons for the companies
Action Needed: Data returned should return this as a logo url

Answer:
Row No: TBC
Infinite Scroll: TBC / Depends on Data Node (Devnet playground under query)
Search: We need to add this


Allow for multiple devices.

When an electricity meter is replaced, a situation arises where the Eagle200 returns multiple devices.  The first device is not in connected state, but the second device is.  Consequently, HA shows the values as unavailable.
Proposed change adds a check for the connection status.
See discussion.

This is not the right place to fix this. This is the API library and it should return the data as we get it. If the API gives us offline devices, so should the library.
Offline device handling should happen inside Home Assistant.


[BUG] Bloxstrap.Exceptions.ChecksumFailedException: Failed to verify download of http://setup.rbxcdn.com/version-1088f3c8e4a44cc7-shaders.zip

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
Bloxstrap.Exceptions.ChecksumFailedException: Failed to verify download of http://setup.rbxcdn.com/version-1088f3c8e4a44cc7-shaders.zip

See https://github.com/pizzaboxer/bloxstrap/wiki/Bloxstrap-is-unable-to-download-Roblox


Cant add songs to my playlist and cant logout with apache

I use apache and can not add music to my playlist and the logout button does not work.
Koel Version: 2.2.0
Error in Chrome Console when try to add music:
PUT https://music.my-domain.com/api/playlist/3/sync 403 (Forbidden)

XHR finished loading: PUT "https://music.my-domain.com/api/playlist/3/sync".

Uncaught (in promise) Object {request: Object, data: "<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">…my-domain.com Port 443</address>↵↵", status: 403, statusText: "Forbidden", ok: false}data: "<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">↵↵<title>403 Forbidden</title>↵↵
Forbidden
↵
You don't have permission to access /api/playlist/3/sync↵on this server.
↵
↵
↵<address>Apache/2.4.18 (Ubuntu) Server at music.my-domain.com Port 443</address>↵↵"headers: (e)ok: falserequest: Objectstatus: 403statusText: "Forbidden"__proto__: Object

Error in Chrome Console when try to logout:
DELETE https://music.my-domain.com/api/me 403 (Forbidden)
XHR finished loading: DELETE "https://music.my-domain.com/api/me".
Uncaught (in promise) Object {request: Object, data: "<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">…my-domain.com Port 443</address>↵↵", status: 403, statusText: "Forbidden", ok: false}

My apache config:
ServerName music.my-domain.com
	ServerAlias www.my-domain.com
	DocumentRoot /home/user/public_html/koel
	SSLEngine on
	SSLProxyEngine on
	SSLCertificateFile /etc/fullchain.pem
	SSLCertificateKeyFile /etc/privkey.pem
	SSLOpenSSLConfCmd DHParameters "/etc/dhparam.pem"
	SSLProtocol all -SSLv2 -SSLv3
	SSlCipherSuite ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA:ECDHE-RSA-AES128-SHA:DHE-RSA-AES256-SHA:DHE-RSA-AES128-SHA;
	SSLHonorCipherOrder on
	Header always set Strict-Transport-Security "max-age=31536000"

	<Directory "/home/user/public_html/koel">
		AllowOverride All
		Require all granted
	</Directory>

	<IfModule mod_xsendfile.c>
		XSendFile on
		XSendFilePath /home/user/music
	</IfModule>

	<Directory />
		Options FollowSymLinks
		AllowOverride All
	</Directory>

From the console you should be ab;e to right click the link and open in new tab, it might provide some additional detail for he error.

First link (https://music.my-domain.com/api/playlist/3/sync):
MethodNotAllowedHttpException in compiled.php line 8754:
in compiled.php line 8754
at RouteCollection->methodNotAllowed(array('PUT')) in compiled.php line 8750
at RouteCollection->getRouteForMethods(object(Request), array('PUT')) in compiled.php line 8728
at RouteCollection->match(object(Request)) in compiled.php line 8095
at Router->findRoute(object(Request)) in compiled.php line 8043
at Router->dispatchToRoute(object(Request)) in compiled.php line 8038
at Router->dispatch(object(Request)) in compiled.php line 2381
at Kernel->Illuminate\Foundation\Http\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 52
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in compiled.php line 3214
at CheckForMaintenanceMode->handle(object(Request), object(Closure))
at call_user_func_array(array(object(CheckForMaintenanceMode), 'handle'), array(object(Request), object(Closure))) in compiled.php line 9765
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 32
at Pipeline->Illuminate\Routing\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in compiled.php line 9755
at Pipeline->then(object(Closure)) in compiled.php line 2328
at Kernel->sendRequestThroughRouter(object(Request)) in compiled.php line 2312
at Kernel->handle(object(Request)) in index.php line 53

Second link (https://music.my-domain.com/api/me):
MethodNotAllowedHttpException in compiled.php line 8754:
in compiled.php line 8754
at RouteCollection->methodNotAllowed(array('POST', 'PUT', 'DELETE')) in compiled.php line 8750
at RouteCollection->getRouteForMethods(object(Request), array('POST', 'PUT', 'DELETE')) in compiled.php line 8728
at RouteCollection->match(object(Request)) in compiled.php line 8095
at Router->findRoute(object(Request)) in compiled.php line 8043
at Router->dispatchToRoute(object(Request)) in compiled.php line 8038
at Router->dispatch(object(Request)) in compiled.php line 2381
at Kernel->Illuminate\Foundation\Http\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 52
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in compiled.php line 3214
at CheckForMaintenanceMode->handle(object(Request), object(Closure))
at call_user_func_array(array(object(CheckForMaintenanceMode), 'handle'), array(object(Request), object(Closure))) in compiled.php line 9765
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 32
at Pipeline->Illuminate\Routing\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in compiled.php line 9755
at Pipeline->then(object(Closure)) in compiled.php line 2328
at Kernel->sendRequestThroughRouter(object(Request)) in compiled.php line 2312
at Kernel->handle(object(Request)) in index.php line 53

I would start by running gulp and clearing the page cache (not sure if that part is necessary but wouldn't hurt).

From the console you should be able to right click the link and open in new tab, it might provide some additional detail for the error.

Not for non-GET actions (hence the next errors provided by @Arendt, as playlist/sync is a PUT, and log out is a DELETE).
My guess is something went wrong with the session. Try por… ahem, icognito mode, and see if it works?

Same error with incognito mode

Seems like an error with your Apache conf. Try using a tool like Postman and do the requests manually?

Closing due to inactivity.


Suddenly cannot use this terminal tool without a VPN

I am using new Bing from China. This terminal tool used work for me without any proxy settings. Today it suddenly starts to go wrong. When I turn on VPN, it still works. Is this because MS starts to check IP address?
This is the error log when I use it without a VPN:
python3 -m EdgeGPT --cookie-file \<IP_ADDRESS>\shared\tmp\work\chatGPT\edge_bing\acheong08_EdgeGPT\cookies_bing.json
    EdgeGPT - A demo of reverse engineering the Bing GPT chatbot
    Repo: github.com/acheong08/EdgeGPT
    By: Antonio Cheong

    !help for help

    Type !exit to exit
    Enter twice to send message or set --enter-once to send one line message

Initializing...
Traceback (most recent call last):
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.2800.0_x64__qbz5n2kfra8p0\lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.2800.0_x64__qbz5n2kfra8p0\lib\runpy.py", line 86, in _run_code
exec(code, run_globals)
File "C:\Users\huwei\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\EdgeGPT.py", line 418, in
asyncio.run(main())
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.2800.0_x64__qbz5n2kfra8p0\lib\asyncio\runners.py", line 44, in run
return loop.run_until_complete(main)
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.2800.0_x64__qbz5n2kfra8p0\lib\asyncio\base_events.py", line 649, in run_until_complete
return future.result()
File "C:\Users\huwei\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\EdgeGPT.py", line 349, in main
bot = Chatbot()
File "C:\Users\huwei\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\EdgeGPT.py", line 269, in init
self.chat_hub: ChatHub = ChatHub(Conversation(self.cookiePath, self.cookies))
File "C:\Users\huwei\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\EdgeGPT.py", line 178, in init
response = self.session.get(
File "C:\Users\huwei\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\requests\sessions.py", line 600, in get
return self.request("GET", url, **kwargs)
File "C:\Users\huwei\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\requests\sessions.py", line 587, in request
resp = self.send(prep, **send_kwargs)
File "C:\Users\huwei\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\requests\sessions.py", line 723, in send
history = [resp for resp in gen]
File "C:\Users\huwei\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\requests\sessions.py", line 723, in
history = [resp for resp in gen]
File "C:\Users\huwei\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\requests\sessions.py", line 191, in resolve_redirects
raise TooManyRedirects(
requests.exceptions.TooManyRedirects: Exceeded 30 redirects.

Try upgrading to latest version. Microsoft changed something

Now I upgrade to the newest version: (0.0.56).
The error somehow becomes auth failed 302.
I've tried update my cookie file. The error is still same.
Still, if I turn on VPN, the error is gone.
Initializing...
Status code: 302
Object moved
Object moved to here.

Traceback (most recent call last):
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.2800.0_x64__qbz5n2kfra8p0\lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.2800.0_x64__qbz5n2kfra8p0\lib\runpy.py", line 86, in _run_code
exec(code, run_globals)
File "C:\Users\huwei\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\EdgeGPT.py", line 417, in
asyncio.run(main())
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.2800.0_x64__qbz5n2kfra8p0\lib\asyncio\runners.py", line 44, in run
return loop.run_until_complete(main)
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.2800.0_x64__qbz5n2kfra8p0\lib\asyncio\base_events.py", line 649, in run_until_complete
return future.result()
File "C:\Users\huwei\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\EdgeGPT.py", line 348, in main
bot = Chatbot()
File "C:\Users\huwei\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\EdgeGPT.py", line 268, in init
self.chat_hub: ChatHub = ChatHub(Conversation(self.cookiePath, self.cookies))
File "C:\Users\huwei\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\EdgeGPT.py", line 186, in init
raise Exception("Authentication failed")
Exception: Authentication failed

Try upgrading to latest version. Microsoft changed something

Oh, I found that you upgraded another version.
Now I upgrade to (<IP_ADDRESS>). It seems the error is gone, without a VPN.
Amazing!


No effect on session after setting cognito_user_session_timeout_inmins

Describe the bug
Hello Team,
We are using v2.2.0 and have set cognito_user_session_timeout_inmins to 60. As per the doc -
cognito_user_session_timeout_inmins -> The number of minutes to set the refresh token validity time for user session’s in Cognito before a user must re-login to the data.all UI (default: 43200 - i.e. 30 days)
Doc Link: https://data-dot-all.github.io/dataall/deploy-aws/
However, we still see that the session still remains active and the user is not asked to re-login.
How to Reproduce
edit cdk.json
set "cognito_user_session_timeout_inmins": 60 in DeploymentEnvironments section

Expected behavior
The user must be asked to re-login after 60 minutes.
Your project
No response
Screenshots
No response
OS
NA
Python version
NA
AWS data.all version
2.2.0
Additional context
No response

Hi @shivalkarrahul !
Thanks for opening issue! Can you confirm, that both Access token expiration and ID token expiration values in AWS Cognito are set less than 60 mins? We will test this behaviour and will be back with more detailed answer.

I couldn't reproduce the bug, so please, provide more details about your deployment.

Hello @SofiaSazonova ,
Thanx for your reply.
Here is what we have in Incognito. Refresh token expiration is still 30 days.

Oh, I see. The problem is not, that timeout doesn't work, but it's not set right!

@shivalkarrahul Could you please confirm, that after you commit and push this changes of cdk.json into CodePipelines, the pipeline was build without any errors?

Hello @SofiaSazonova ,
Yes, I confirm that the pipeline completed successfully.

Hi @shivalkarrahul , is this issue resolved ? if so can we close this issue?

Closing this issue as it seems to be resolved now, feel free to reopen if you have questions or still need any help on this issue.


Fix for “The specified child already has a parent”

Does any other open PR do the same thing?

No.
What issue is this PR fixing?
I haven't created an issue for it, but seems to be the same issue found here:
https://github.com/react-community/react-native-maps/issues/2447
Error it fixes is the following, which for me personally occurred when re-rendering with the map with a partially different set of Markers.
For performance reasons in my project on render only markers that are within the specified region are returned with render, with the map re-rendering markers using onRegionChangeComplete. With small changes it is generally fine however I found when animating a region change where a lot of markers change this crash would occur.
This simple change in the java code fixed the issue for me.

(please link the issue here)
How did you test this PR?

I only have this issue on Android, and I could consistently replicate the crash on a suite of android test devices. After the fix it was easy to confirm that it fixed the issue for me. Also the code snippet is pretty harmless and contained, checks for null and should not introduce any crashes.

LGTM @alvelig 🐽

Massive props @shanereid - and thanks for the speedy merge 🎉

Does any other open PR do the same thing?
No.
What issue is this PR fixing?
I haven't created an issue for it, but seems to be the same issue found here:
#2447
Error it fixes is the following, which for me personally occurred when re-rendering with the map with a partially different set of Markers.
For performance reasons in my project on render only markers that are within the specified region are returned with render, with the map re-rendering markers using onRegionChangeComplete. With small changes it is generally fine however I found when animating a region change where a lot of markers change this crash would occur.
This simple change in the java code fixed the issue for me.

(please link the issue here)
How did you test this PR?
I only have this issue on Android, and I could consistently replicate the crash on a suite of android test devices. After the fix it was easy to confirm that it fixed the issue for me. Also the code snippet is pretty harmless and contained, checks for null and should not introduce any crashes.

I am still facing same issue after this fix too.Any other solution for this??


wifi: driver: esp32: fix reconnection issue

Device won't reconnect automatically even if
AP station is available. This fix adds the carrier event, indicating
that network is present again enabling DHCP bound event.
Also, internal wifi event callback  was added into wifi driver to enable proper
event handling.
Fixes #33843

LGTM, minor nit about the indentation. Was this meant to be applied to 2.6?

If there is room for that, yes.


Replaced gradle install with gradle installApp

The "gradle install" task does not seem to exist anymore. I've assumed that the proper replacement is "gradle installApp".

Can one of the admins please verify this patch?

Nice catch! Yep you are correct. Must have changed to installApp in a Gradle update sometime. Even appears like that's deprecated in favor of installDist starting with Gradle 3.
We're not there yet though so this helps for now, thanks! :-)


Fix deleting DBs in test for PSQL and document setup

Small PR to document that a Postgres instance needs to be running for the e2e of the go-sdk and make sure that the name of the table is not lowercased if not the tables will not get cleaned up after the test

sorry missed this in the review, you said:

make sure that the name of the table is not lowercased if not the tables will not get cleaned up after the test

where was this addressed?

Here https://github.com/hyperledger-labs/zeto/pull/40/files#diff-7f04ceab68afe0e2e8989c32363b39b3f55907daf03d7bc4e7ebc312b328274cR101-R104 @jimthematrix


Added Azure Pipelines Agent to list

Adding my extension Azure Pipelines Agent  to the existing list

Thx @sujaypillai for the contribution. I just fixed a conflict with main


Rails 5 loading and validation issues

I started a new Rails 5 project today and ran into a series weird issues with FGR.
Example app to reproduce issues
rails <IP_ADDRESS>
factory_girls_rails 4.7.0
rspec-rails 3.5.2
shoulda-matchers 3.1.1
For more context, on the example app:
Model: User
Attributes: email:string:uniq, admin:boolean
Not registering factories properly
I generated a simple user_factory and sequenced email generation. In trying to use Syntax Methods as referenced in the getting started guide. I get the following error:
uninitialized constant FactoryGirl (NameError)

So I added a require statement to /spec/support/factory_girl.rb:
require 'factory_girl'

RSpec.configure do |config|
  config.include FactoryGirl::Syntax::Methods
end

Add the require statement leads to the following error:
ArgumentError Factory not registered: user

yet there clearly is a /spec/factories/users.rb
Adding definitions hack
I read a number of issue reports on FGR, factory_girl, and StackOverflow and decided to try this (changes viewable on this PR):
require 'factory_girl'

RSpec.configure do |config|
  config.include FactoryGirl::Syntax::Methods

  config.before(:all) do
    FactoryGirl.find_definitions if FactoryGirl.factories.count == 0 # I also tried FactoryGirl.reload here
  end
end

Running that, I get:
ActiveRecord::RecordInvalid: Validation failed: Admin can't be blank

Introspecting the object in the test: it has the attribute admin set to false yet the spec fails saying the value is blank. :scream:
Am I doing it wrong?
Apologies if these are should be seperate issues, but they seem related. If I have missed anything on the setup to reproduce this, then I apologize for the noise. And thanks for the awesome OSS.

@maxbeizer the first thing I noticed is that the Gemfile group for FGR isn't set for :test; that's the first place I'd start. Under normal conditions you shouldn't have to require anything from FG for it to work if the Gemfile is correct. Please let me know where that gets you!

@joshuaclayton I updated my example repo to move FGR to development and test :facepalm:. That's just a mistake from copy stuff over into an example app. In any event, with the gem in test and development groups, I still see:
Validation failed: Admin can't be blank

If I remove the require statement, I get the uninitialized constant error as reported above.
Thanks for looking into this with me 😄

@maxbeizer if you attempt to create a record from a Rails console, e.g. User.create!(admin: false, email: "brand-new@example.com"), what happens?

User.create!(admin: false, email<EMAIL_ADDRESS>   (0.1ms)  begin transaction
  User Exists (0.4ms)  SELECT  1 AS one FROM "users" WHERE "users"."email" = ? LIMIT ?  [["email"<EMAIL_ADDRESS>["LIMIT", 1]]
   (0.0ms)  rollback transaction
ActiveRecord::RecordInvalid: Validation failed: Admin can't be blank

Yep. Can't validate presence on a boolean field. Example updated. I still have to require factory girl for some reason.

Digging into this more, I have not found anything new. So for the time being I will be requiring factory girl in my support file. If I figure out where I went wrong or learn something new, I'll reopen. Thanks for looking into this with me @joshuaclayton and thanks for all the OSS work you do .


Show flash to flash transaction default memo in transaction history screen

#187

Interesting... this is showing that the payment was paid to me... it's showing my username.
But it does not tell me what flash user the payment came from. This is still a good addition to the details screen, ACK


Update react-native-image-picker

Details
react-native-image-picker added the fileName param (among others) to their iOS API. This is important because we use it to get the file extension and successfully upload the file.
Fixed Issues
$ https://github.com/Expensify/App/issues/8275
Tests

Navigate to Settings > Profile and tap on your avatar image.
Select a new image and verify that the upload succeeds and your image changes.
Open a chat with another user.
Tap on + > Add attachment
Test all 3 options: Take photo (only on a real device), Choose from gallery and Choose document
Verify that the upload works for different types of files.

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps
Same as testing steps.

[ ] Verify that no errors appear in the JS console

Screenshots

Web
https://user-images.githubusercontent.com/22219519/160003764-912bf089-5471-4b11-8e2f-a93f2fe18334.mov
Mobile Web
https://user-images.githubusercontent.com/22219519/160003931-bd216aa2-ccb6-4a22-99a3-d9ecaff28cab.mov
Desktop
https://user-images.githubusercontent.com/22219519/160004209-a77ce124-6c86-4607-9c23-ee36d84f933b.mov
iOS
https://user-images.githubusercontent.com/22219519/160005115-e8b183c4-59d9-4383-8258-309ca6be32d9.mov
Android
https://user-images.githubusercontent.com/22219519/160005254-ea95c207-f1ba-410b-9e9a-8d8e7e6c42e7.mov

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @MariaHCD in version: 1.1.47-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.49-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add or document ability to run SQL agnostic of whether I'm using a Connection or a Transaction

I'd like to be able to write a function that executes some SQL, but have it be agnostic over whether the thing it's using to execute said SQL is a single Connection or a Transaction, so that logic higher up the stack can decide whether it wants to wrap such calls in a transaction or not.
The code I have written to achieve this looks like the following:
pub struct User {
    name: String
}

impl User {
    pub async fn from_db_by_email<E: sqlx::Executor<Database = sqlx::Postgres>>(email_address: &str, conn: &E) -> Option<User>
    {
        let user = sqlx::query_as!(
            User,
            "select name from (select 'Foo' as name<EMAIL_ADDRESS>as email) lark where email = $1",
            email_address
        ).fetch_one(conn).await.ok()?;

        Some(user)
    }
}

async fn foo() -> Result<(), sqlx::Error> {

    let client = statscloud_db::ClientBuilder::new().connect_with_password("foo").await?;
    let conn = client.acquire().await?;

    // Here I can decide whether to pass a Transaction or not (that's the hope, anyway):
<EMAIL_ADDRESS>&conn);

    Ok(())
}

However, this hits an overflow error:
error[E0275]: overflow evaluating the requirement `&mut _: sqlx_core::executor::RefExecutor<'_>`
  |
  = help: consider adding a `#![recursion_limit="256"]` attribute to your crate
  = note: required because of the requirements on the impl of `sqlx_core::executor::RefExecutor<'_>` for `&mut sqlx_core::pool::connection::PoolConnection<_>`
  = note: required because of the requirements on the impl of `sqlx_core::executor::RefExecutor<'_>` for `&mut sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<_>>`
  = note: required because of the requirements on the impl of `sqlx_core::executor::RefExecutor<'_>` for `&mut sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<_>>>`
  = note: required because of the requirements on the impl of `sqlx_core::executor::RefExecutor<'_>` for `&mut sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<_>>>>`
  = note: required because of the requirements on the impl of `sqlx_core::executor::RefExecutor<'_>` for `&mut sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<_>>>>>`
  = note: required because of the requirements on the impl of `sqlx_core::executor::RefExecutor<'_>` for `&mut sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<_>>>>>>`
  = note: required because of the requirements on the impl of `sqlx_core::executor::RefExecutor<'_>` for `&mut sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<_>>>>>>>`
  = note: required because of the requirements on the impl of `sqlx_core::executor::RefExecutor<'_>` for `&mut sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<sqlx_core::pool::connection::PoolConnection<_>>>>>>>>`

Trimming the sqlx::query_as! line so that it looks like the following seems to avoid the overflow issue:
sqlx::query_as!(
    User,
    "select name from (select 'Foo' as name<EMAIL_ADDRESS>as email) lark where email = $1",
    email_address
);

Adding back the fetch_one so that it becomes the following causes the overflow to occur again:
sqlx::query_as!(
    User,
    "select name from (select 'Foo' as name<EMAIL_ADDRESS>as email) lark where email = $1",
    email_address
).fetch_one(conn);

So I guess the issue is around the type being handed to fetch_one.
Is this a bug, or am I holding it wrong?

Digging into the code more, I believe that fetch_one needs a RefExecutor, not an executor.
The problem with using RefExecutor to try an abstract over Connection vs Transaction is that it is implemented for refs (often mutable refs) of the various Executor types, but inside the function I have an opaque object that I can only use by moving into the fetch_one call, preventing me from doing more than one query inside a function.
So, this works:
pub async fn from_db_by_email2<'e, E: sqlx::executor::RefExecutor<'e, Database = sqlx::Postgres>>(email_address: &str, conn: E) -> Option<User>{

    let user = sqlx::query_as!(
        User,
        "select * from sc_users.users where email = $1",
        email_address
    ).fetch_one(conn).await.ok()?;

    Some(user)
}

async fn run_some_queries() -> Result<(), sqlx::Error> {

    use sqlx::prelude::*;

    // Either of these should be passable to the function below ideally:
    let mut client = sqlx::PgConnection::connect("some/url").await?;
    // let mut tr = client.begin().await?;

<EMAIL_ADDRESS>&mut client).await;

    Ok(())
}

But I can't find a way to be able to run more than one query inside the from_db_by_email function, eg this (and various combinations involving &mut fails:
pub async fn from_db_by_email2<'e, E: sqlx::executor::RefExecutor<'e, Database = sqlx::Postgres>>(email_address: &str, conn: E) -> Option<User>{

    let user = sqlx::query_as!(
        User,
        "select * from sc_users.users where email = $1",
        email_address
    ).fetch_one(conn).await.ok()?;

    let user2 = sqlx::query_as!(
        User,
        "select * from sc_users.users where email = $1",
        email_address
    ).fetch_one(conn).await.ok()?;

    Some(user)
}

I wonder whether implementing RefExecutor on all types that are &mut RefExecutor might help, as then I could take a mutable reference to conn in the above function and pass that to each fetch_one query?
Is there another, more practical way to abstract over Connections and Transactions in this way?

Busy weekend so I can't give a longer answer right now but you can write methods that accept &mut PgConnection and then if you want to pass a transaction you can do &mut *tx when invoking the method as Transaction dereferences to the connection.
Hopefully that helps. It's not possible to sanely abstract over a generic executor without weird type bounds due to some limitations in Rusts type resolution right now (waiting on lazy normalization).

Oooh, thankyou, that works great! In fact, I just pass &mut Transaction to the function and it seems to deref automatically to &mut PgConnection as well :)


Move command handling into queue

Get rid of the command_group class.
Already started with the introduction of the handler class: efeb82ef262bb629cf002bab7cb1984ea981ae53

Don't really need to get rid of the command_group class - for now I've moved it into namespace detail (374b6d68c51896dbdc51ae0ced11c82a5d57f637), did some trimming (09a3dec28a0287dc3e52eb02cfbbb9564669bef2), and used it to provide a local compilation environment (f3a4e4ff0836698ccfe65498d6e75c80cf333bd2, not done yet).
But yes, in the end, the queue should be the only one to handle commands. But this can now be done by using local compilation environments (local command groups) and later joining them. This should allow for better optimizations, as all commands can be viewed at once.

There were some problems with the local compilation environment, had to be removed in 10167ad777cab7ee57dc72e3f44f5b80e810f22a.

Basically done in 1ec0a7b6b3ffccce9bb19594c17df3e756c0824b, but needs #13. Closing.


Add filter for order statuses

Any chance to merge this one https://github.com/PayU-EMEA/plugin_woocommerce/pull/40 please? It's non-breaking change that would allow us to control the status changes.
Thanks!

We added filter but only for CANCELED notification because:

REJECTED has been remover (Payu doesn't send it anymore)
WAITING_FOR_CONFIRMATION not final status in PayU. WC order status must be set to payu-waiting for proper future status changes.

https://github.com/PayU-EMEA/plugin_woocommerce/commit/86a0bd52c1fa73d908b21110891ac39a1ef44164

Awesome, thanks!


Release v0.6.0 binary for mac

There seems to have been one for 0.5.0 but not for the new version.
Thanks :-)

The problem is that I need to ask someone with a Mac to build them for me since I don't have one... :D I'll ask on irc later

Just built it.
Would you like me to send you an archive?

@paf31 built binaries and even provided a buildscript in  #120 for non-stack users!


Monitor opendal streaming uploader and deprecate the outer MonitoredSteramingUploader

After #16929, MonitoredSteramingUploader will only be used by OpenDAL object store. However, the reporting metrics are not exactly what we want because I/O may or may not happen on opendal writer write calls and the I/O scheduling is done inside the implementation of opendal writer.
However, after https://github.com/apache/opendal/pull/4638, whenever a I/O happens in the opendal writer, it will invoke the execute method provided by the Executor implemented by us. We should monitor I/O metrics in the Executor and deprecate the outer MonitoredStreamingUploader completely.

After #17198, the metrics related to streaming uploader has already been moved into opendal object store. I will try to see whether we can completely deprecate MonitoredSteramingUploader.

Resolved by #17198


Bug located in hfss.boundaries

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
hfss.boundaries returns an empty list, whereas hfss.oboundary.GetBoundariesOfType('Radiation') returns the correct boundary name inside a list. and hfss.modeler.get_boundaries_name() works as well.
using pyaedt v0.6.59 with of AEDT 2023.1
Steps To Reproduce
hfss.boundaries
Which Operating System are you using?
Windows
Which Python version are you using?
3.9
Installed packages

@fwlfHS Pyaedt is retrieving such information from the project file or stored when the command is executed from pyaedt.
In your case maybe you have created the boundary manually and not saved the project.
Try to save the project and read the boundaries value again.

Thanks Massimo, this was indeed the case. Is there a method to check whether a project has been saved and if not to interactively ask the user for a destination?

@fwlfHS The default destination is the same than in AEDT projects (Options>General Options>Directories), then if the user doesn't specify any path, the project will be saved there.
You could use different methods to check if the path exists or not:
from pyaedt.generic.general_methods import check_if_path_exists
check_if_path_exists(path)
or you could check the project timestamp:
hfss.project_time_stamp
Each time you save the project, the time_stamp will change, then you could verify if the project has been saved since the last time stamp.
Let us know if it helps and if this issue could be closed.

Thanks Samuel, this can be closed.


order results search

It's possible order by price -  relevance and search only in category elettronics - movie etc.?
thanks

Hello,
Unfortunately there's no way to order them using this package.
The only way you'd be able to do it would be to store the products you search somewhere (database?) and then run your own queries on that to sort them.
Thanks for using the package :)


Add support for making grpc calls to service methods which return streams of responses.

Nice. No code change needed?

@ht290 Indeed the code was fine. The problem was that protoc was removed from the stuff shipped with bazel itself, so I needed to add an extra import.


Archived VM can't be removed by admin user in Global Region

Occurs in: Euwe RC1 (tested with admin account on the Global Region, provider VMware vCenter)
Steps to reproduce the issue:

Login as admin user at the Global Region appliance
Go to Compute -> Infrastructure -> Virtual Machines
Select the "VMs" accordeon, and select an archived VM
Through "Configuration", select "Remove selected items".

The following message appears: "All selected VMs are not in the current region", so the archived item can't be removed from the Global Region.

@gtanzillo I'm not sure removal of archived items was on the docket for Central Admin, but here's an issue for it.

I don't think this is supported through the global region.
Right now we just have powerops and retirement.

@gtanzillo Can you take care of this stale issue?

Closing as this will be evaluated when we extend the currently supported Central Admin features.


[Don't Merge] Test CI

Looks like a flake. I shall make some effort to tackle it, been there for too long.


Document make backport details and usage.

Depends on https://github.com/submariner-io/shipyard/pull/618
Signed-Off-By: Janki Chhatbar<EMAIL_ADDRESS>

We don't have gitlint on this repo unfortunately, but if we did I think it would fail on the period on the first line of the commit message. Might still be best to follow those practices.


[SPARK-10849][SQL] Adding field metadata property to override default jdbc data source type mapping.

This patch allows users to override default type mapping of  data frame field to database column type when writing data frame to jdbc data sources.
In some cases user may want to use specific database data type mapping for fields based on the database configuration (page size , type of table spaces ..etc) instead of the defaults.  For example large varchar size  for all the columns may not fit in row size limits , user may want to use mix of varchar , and clob types. Max precision supported in some database systems might be less than the spark decimal precision, in such cases user can use this option to adjust the decimal type precision , and scale to match the target database.
Added a new field meta data property name    db.column.type .   I am not sure what is the convention for these type of property names. Please let me know it it needs to be changed.
@rxin  @marmbrus

Can one of the admins verify this patch?

ok to test

Merged build triggered.

Merged build started.

Test build #44586 has started for PR 9352 at commit 4048c2d.

Test build #44586 has finished for PR 9352 at commit 4048c2d.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44586/
Test FAILed.

Merged build finished. Test FAILed.

Failed test is test_trainOn_predictOn (main.StreamingKMeansTest).   It seems to be unrelated to my changes.  Can we retest this please.

Thinking about this more , I realized current version of the patch may introduce SQL injection. I will update the pull request with a new version of the fix.

Merged build triggered.

Merged build started.

Updated the patch to address sql injection issue by removing space characters from the input.  Please review.
@marmbrus @rxin

Test build #44699 has started for PR 9352 at commit ef26084.

Test build #44699 has finished for PR 9352 at commit ef26084.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44699/
Test FAILed.

Merged build finished. Test FAILed.

retest this please.
Test  failure is unrelated to my changes. Failed test is org.apache.spark.sql.sources.JsonHadoopFsRelationSuite.test all data types - TimestampType. It passes in my environment.

Thanks for addressing the SQL injection concerns, Suresh. LGTM.

Jenkins, retest this please.

Anyone know the status of this change?  Is there anything blocking, or was it superceded by something else?  Thanks...

Can one of the admins verify this patch?

Opened two new [WIP] PRs to fix this issue using different approaches.
https://github.com/apache/spark/pull/16208
https://github.com/apache/spark/pull/16209
Closing this PR.


basic geting started problem

i am sure this must be a really basic error on my part but i am lost.
i added the component, i have a copy of the sample nodes and the page shows 3 node names.
view source shows that a lot of markup is in the pages but hidden.
the nodes do not click and do not show colapse / expand icons.
no errors in the javascript console in chrome.
angular cli 4  is the build environment.
app runs and other pages work ok.
the tree is in a simple bootstrap 3 panel.

It's bootstrap that cause the problem, for some reason it hide the collapse and /expand icon, try to comment the boostrap import to verify that. (For me this was the problem, but I don't know how to solve maintaning boostrap)

You have to manually import the css of the tree,
add to your style.css file this
@import '~angular-tree-component/dist/angular-tree-component.css';

Here is the fix for a project that uses bootstrap and angular cli:
go to the file .angular-cli.json
edit that file
it has a styles section
add the style like this:
 "styles": [         "../node_modules/bootstrap/dist/css/bootstrap.css",           "../node_modules/angular-tree-component/dist/angular-tree-component.css",         "styles.css"       ],
then re build and test

ng serve

works!!

@figuerres, did you try importing the css from styles.css as the docs and @crivadavi suggest?

What I did works and it let's the angular clip build process see the dependacie on that case file.

I'm having the same issue. Just use a "@import "~angular-tree-component/dist/angular-tree-component.css";" like @crivadavi says.
@adamkleingit , the docs don't says anything about styles.css.
Check the Getting Started section of the docs.
I think that section must be update.

Fixed - the default docs was 4.1 instead of 5.0


click 8.1.0 breaks typer 0.4.0

See tiangolo/typer#377 for more information

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

this pin is needed to avoid an ImportError on simply importing typer (typer is completely unusable with click 8.1.0)

Thanks for the PR!
Unfortunately, and frustratingly, adding a pin won't necessarily help much, as the solver is "greedy," and will simply select the older, still-incompatible version _0.
In the near term, we just have to deal with pinning versions (in this case, click).
The longer-term hope is for https://github.com/tiangolo/typer/pull/375 which would either preserve functionality with the existing range,

#8 adds a click 8.1-compatible typer. Thanks again!

Hello! I just released Typer 0.4.1 that should handle this. :rocket: :nerd_face:

@tiangolo thanks! we've already got that version up but still waiting for CDN for it to be widely distributed. :blush:


Support Multipage draw.io diagrams

Describe the feature you'd like
draw.io supports multiple pages drawings. I would like to be able to see the other pages of the diagram than the first one.
Describe the benefits this feature would bring to BookStack users
You can have more advanced diagrams.
Additional context
Read more about this how it's supported in Confluence which also uses draw.io here : https://drawio-app.com/draw-io-for-confluence-multi-page-diagrams/
Here is a screenshot of the feature in Confluence :

Hi @donnib,
Please see my thoughts regarding this functionality here:
https://github.com/BookStackApp/BookStack/issues/2294#issuecomment-701604448

Since there's been no follow-up I'm going to close this.


Support a mode to trunk install to seed the GitHub Actions cache on main

In the future we should use a sub-action for this type of thing, c.f. actions/cache/save and actions/cache/restore.


Support custom events in exporter

Will be used in conjunction with the custom events extension. Exporter only needs to check for special attribute in log record.

API change check
API changes are not detected in this pull request.


I can't delete the playlist tracks by position

I want to delete all the tracks of a playlist and I have a code more or less like this:
$playlist=$this->api->getUserPlaylist($userId,$playlistId);
$snapshotId=$playlist->snapshot_id;
while ($snapshotId){
 $tracks = [ 0 ];
 $snapshotId=$this->api->deletePlaylistTracks($playlistId, $tracks, $snapshotId);
}

But it outputs the error: JSON body doesn't conform to specification
I've also tried using:
$tracks= [
'positions' => 0
];

But it outputs the error: Missing or invalid positions
Expected behaviour:
I want to remove the first track of the playlist until $snapshotId becomes false (the playlist is empty)

Hi!
positions needs to be an array too, so this should work:
$playlist=$this->api->getUserPlaylist($userId,$playlistId);
$snapshotId=$playlist->snapshot_id;
while ($snapshotId){
  $tracks = [
    'positions' => [0]
  ];

  $snapshotId=$this->api->deletePlaylistTracks($playlistId, $tracks, $snapshotId);
}

I think though, in this case replacePlaylistTracks might be a better fit. That is, if you only want to clear a playlist. That will be quicker and a $snapshotId will always be returned from deletePlaylistTracks, even when the playlist is empty.
An example using replacePlaylistTracks:
$this->api->replacePlaylistTracks($playlistId, []);

Passing an empty list of tracks will clear the whole playlist in one go.
Hope this helps!

Hi Jwilsson! Thanks for the quick reply. In this case replacePlaylistTracks made the job for me, unfortunately using positions as an array also failed with the message:
"Could not remove tracks, please check parameters."
I'm not sure why this happens, so I will leave it to you. When you find the solution you could update the the managing-user-playlists.md file in the "Delete tracks from a user's playlist based on positions" sections since it doesn't fit the correct answer. I think that more or less would end up like this:
It would change from this:
$trackPositions = [
5,
12,
];
$api->deletePlaylistTracks('USER_ID', 'PLAYLIST_ID', $trackPositions, 'SNAPSHOT_ID');
To more or less this:
$trackPositions = [
'positions' => [5,12]
];
$api->deletePlaylistTracks('PLAYLIST_ID', $trackPositions, 'SNAPSHOT_ID');
I was a bit confused at the beginning because this example didn't matched the definition of the method in SpotifyWebAPI.md: "Or an array with the key "positions" containing integer positions of the tracks to delete."
Just wanted to say, thanks a bunch for your time and your help!


feat: add additional raw data parsing for items, characters, and base camps

Closes #84

Awesoem :)


make sure Radisson will be shutdown in finalize()

if not properly shutdown try to shutdown once the object is being gc'ed
in order to prevent unintentional leaks of the running threads

is there still any interest in the PR?

I think it's a developer responsibility to shutdown Redisson properly

This is more meant as a safe belt, i.e. when users forget to shutdown the instances properly (.e. https://github.com/redisson/redisson/issues/693).


Fix: Breaks fonts in lot of pages

Regarding #30
Apply basic styling to .wrapper only instead of body.
Still open: jsonfinder does not use namespaced CSS classes and ids. It may still break styling of individual web pages.

Also plugin overwrites body element's margin to 0

Fixed in 0.1.0. Sorry to keep you waiting!


Add more statistics to the overall summary page and the team summary page

We now have a per user graph, and a running challenges solved line on the line graph.

Coverage decreased (-0.1%) to 97.214% when pulling ca57fb8c31c4667410aef16f67d03ac22d53317e on addMoreStats into f14bb2528902cd5efd2e50c562844e7ea1758ce5 on master.

Coverage increased (+0.008%) to 97.333% when pulling e555b2018b6c216fd1ab4deb80e7bcc3dfe8a632 on addMoreStats into f14bb2528902cd5efd2e50c562844e7ea1758ce5 on master.


Clarify installation instructions

In particular it is necessary to clone the repository before running the other commands. I also removed the cargo install side note because it didn't actually work (running the command just produces an error that --package isn't a recognized flag) and added a tldr code block with the list of commands to run.

bors r+
Thanks!


Adding new gateway

I'm getting an error of 404 when trying to add a new gateway via the client UI. The server is running and configured on the Settings of the Client

Are you getting it in the UI? Try to remove the last slash in the url "/". Go to settings and correct server url there.

Okay, I noticed that in the client it references the JavaScript payum.js in the header but its not in the client, so had to copy from the server. Now when I try and save a Gateway, I get an error on the UI "Invalid Form", but if I refresh the Gateways, I can see its added

How do you run server? with docker?

No, I cant install Docker on Windows 10 Home edition. I used composer to install the dependencies and executed php -S <IP_ADDRESS>:8000 web/index.php

Unfortunately Php server is not enough, (because of payum.js). It is simple php app. try to run it with apache server or something like that. Would be good to add env var PAYUM_DEBUG=1 to see more details on errors.
This setup has to work. This way it works on server.payum.org. (without docker).


Knowledge graph in entity linking and encoding entities with graph

This requires a change in the json files. I'm storing the corresponding columnId for each cell.
I'm running tests on this now.

LGTM


useInfiniteQuery: hasNextPage does not work with custom select function

useInfiniteQuery(['posts', variables], fetchPosts, {
    getNextPageParam: (lastPage, pages) => lastPage.nextPage
    select: data => data.pages.flatMap(page => page.posts)
  })

hasNextPage always returns undefined when I specify a select function. When I remove the select function, hasNextPage works as expected.

When using select you need to return the original data structure which contains pages and pageParams:
useInfiniteQuery(['posts', variables], fetchPosts, {
  getNextPageParam: lastPage => lastPage.nextPage,
  select: data => ({ ...data, pages: data.pages.flatMap(page => page.posts) })
})

There was a bug though because the selected data was passed into getNextPageParam. This has been fixed in 3.5.6.

@boschni will this not void the possibility to subscribe to parts of the state via select if we have to create a new object to return?


Navigation of items with arrow keys

Is your feature request related to a problem? Please describe.
In an accessibility standpoint navigation of the days, month and years menu should be made with the arrow keys instead of using tabs, since it mimics a lot of the behavior patterns in native html date tags and makes it easier for disabled users to make a selection.
Describe the solution you'd like

When inside day view menu (the one that lets you navigate days in month), tabs only let you switch focus between

selecting month,
year,
previous month
next month
selecting day selection.
If focused on day selection, arrows lets you navigate left-right-up-down, between items. Enter makes a selection.

When inside month view, tabs only let you switch focus between selecting month and going back to calendar overview. If focused on month selection, arrows lets you navigate left-right-up-down, between items. Enter makes a selection and returns user to overview.
When inside year view, tabs only let you switch focus between selecting month and going back to calendar overview. If focused on month selection, arrows lets you navigate left-right-up-down, between items. Enter makes a selection and returns user to overview.

Illustrating tab stops and places where arrows should be used for navigation

I planned to implement this, since it is as you said, much easier to navigate, however, this will not be in the next version, but in the version after next, probably 3.2.


[dua] MTD prioritizes DUA in AR Tlv

Thread 1.2 spec requires prioritizing DUA in AR TLV to ensure DUA could be stored in the limited addresses space for Child on the parent.
This PR depends on #4854 , please only review the last commit which is the purpose of this PR.

Updated along with the dependent #4854 getting merged. Please take a review. @abtink @jwhui


Sampling fails when partitioning

from pycylon import DataFrame, CylonEnv
from pycylon.net import MPIConfig
import random

df1 = DataFrame([random.sample(range(10, 30), 5),
                 random.sample(range(10, 30), 5)])

# local sort
df3 = df1.sort_values(by=[0])
print("Local Sort")
print(df3)

# distributed sort
env = CylonEnv(config=MPIConfig())

print("Distributed Sort", env.rank)
df3 = df1.sort_values(by=[0], env=env)
print(df3)

Gives
I0402 15:32:48.667140 76425 arrow_partition_kernels.cpp:420] len=5 min=0 max=0 range=0 num bins=64 quantile=0.25
W0402 15:32:48.667186 76425 arrow_partition_kernels.cpp:438] sample was unable to capture distribution. try increasing num_samples or num_bins
[laptop:76425] *** Process received signal ***
[laptop:76424] *** Process received signal ***
[laptop:76424] Signal: Floating point exception (8)
[laptop:76424] Signal code: Integer divide-by-zero (1)
[laptop:76424] Failing at address: 0x7fc602528943
[laptop:76425] Signal: Floating point exception (8)
[laptop:76425] Signal code: Integer divide-by-zero (1)
[laptop:76425] Failing at address: 0x7f7f1a13f943
[laptop:76425] [ 0] /lib/x86_64-linux-gnu/libpthread.so.0(+0x14bb0)[0x7f7f1c141bb0]
[laptop:76425] [ 1] [laptop:76426] *** Process received signal ***
[laptop:76426] Signal: Floating point exception (8)
[laptop:76426] Signal code: Integer divide-by-zero (1)
[laptop:76426] Failing at address: 0x7f5f74c4e943
[laptop:76426] [ 0] /lib/x86_64-linux-gnu/libpthread.so.0(+0x14bb0)[0x7f5f76c50bb0]
[laptop:76426] [ 1] [laptop:76423] *** Process received signal ***
[laptop:76423] Signal: Floating point exception (8)
[laptop:76423] Signal code: Integer divide-by-zero (1)
[laptop:76423] Failing at address: 0x7ff8e7644943
[laptop:76423] [ 0] /lib/x86_64-linux-gnu/libpthread.so.0(+0x14bb0)[0x7ff8e9646bb0]

from pycylon import DataFrame, CylonEnv
from pycylon.net import MPIConfig
import random

df1 = DataFrame([random.sample(range(10, 30), 50),
                 random.sample(range(10, 30), 50)])

# local sort
df3 = df1.sort_values(by=[0])
print("Local Sort")
print(df3)

# distributed sort
env = CylonEnv(config=MPIConfig())

print("Distributed Sort", env.rank)
df3 = df1.sort_values(by=[0], env=env)
print(df3)

Gives,
Sample larger than population or is negative

what was the world size?

4
On Fri, Apr 2, 2021 at 4:29 PM niranda perera @.***>
wrote:

what was the world size?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cylondata/cylon/issues/372#issuecomment-812698728,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABXZKCIFHNXTKOJ74VI5QMTTGYSLTANCNFSM42JKOZZA
.


evcc CLI calls interfere with mqtt-API status

Describe the bug
With enabled mqtt option, calling evcc from the command line like „evcc chargers“ generate a representation in the mqtt topics. While evcc itself is running, the cli called evcc changes the evcc/status topics to offline after ending. The status is now wrong, because the running daemon does not refresh the topic during runtime.
Expected behavior is, that evcc cli does not use mqtt api during execution.
Steps to reproduce

enable mqtt in evcc.yaml
create some kind of listener on evcc/status for viewing the values
start evcc daemon
Run evcc with a CLI option, like evcc charger
Review content of evcc/status

Configuration details
[…]

mqtt:
  broker: mqtt-server:1883
  topic:evcc # root topic for publishing, set empty to disable
  user: evcc
  password: password

[…]

Log details
Not needed

What type of operating system are you running?
Linux
Nightly build

[ ] I have verified that the issue is reproducible with the latest nightly build

Version
0.130.13

Understood. I came across this issue while running a demo instance for testing the interaction between https://github.com/muexxl/batcontrol .
During normal operation, that issue is not a big thing.


Unexpected token {

Attempting to run
C:\Users\username>node-prototype-repl

On Windows 10 with Node.js v8.12.0, the latest Node.js LTS version (as of writing), results in this fatal error:
C:\Users\username\AppData\Roaming\npm\node_modules\@nodejs\repl\src\repl.js:227
          } catch {} // eslint-disable-line no-empty
                  ^

SyntaxError: Unexpected token {
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Module._compile (module.js:616:28)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (C:\Users\username\AppData\Roaming\npm\node_modules\@nodejs\repl\src\index.js:7:14)

At the moment this is being developed against Node.js nightly builds, as it is intended to eventually replace the repl built into node. If you want to open a pr and change it i would accept it but i can't guarantee the compatibility would stay as more code is added.

node 8 is no longer lts


applicationId  vs AppIdentifier

The identifier for the Application is named applicationId in "Traffic Influence API" and in the "MEC Exposure API". The same parameter is named applicationIdentfier in the "EdgeCloud API".
It is proposed to rename applicationIdentfier as applicationId in the more recent EdgeCloud API.

Dear @Kevsy ,
I'm referring to: https://github.com/camaraproject/EdgeCloud/blob/main/code/API_definitions/EdgeCloudApi_v0.0.5.yaml
About discussing it in commonalities, I totally agree, I started in the Edge Cloud group because this is where the problem raised, do you want me to open a new one in Commonalities?

Issue open in Commonalities Id vs Identifier in the name of a parameter : https://github.com/camaraproject/WorkingGroups/issues/223

In the EdgeCloud API the schema is applicationIdentifier (I suggest to modifiy it in applicationId according to the outcomes of the discussions) and the variable is appId (that is fine).
For the TI API, to be coherent with the EdgeCloud API, I suggest to rename applicationId as appId

Closing because of the the modification of the Glossary file:
https://github.com/camaraproject/Commonalities/issues/16


Cannot GET /

I run it on ubuntu and it cursed until I changed the port, set it to 4000.
But at startup everything that is written on the page "Canot GET /" on white fone.
Firefox browser

localhost:4000 doesn't take your anywhere, localhost:4000/docs will take you to the docs. let me improve the messaging of the app. lmk if /docs works!

just pushed a change, now visiting localhost:4000  returns something descriptive (instead of cannot GET /)
and the "server running" message in terminal/cmd should be more descriptive now
hopefully this helps avoid confusion for folks like u trying to setup for the first time! (commit: https://github.com/keldenl/gpt-llama.cpp/commit/50d06cdaed6fc19da924775d0108dd892674f370)

Oh, I already figured it out, I just didn't launch it that way. I looked at your docks on auto-gpt. But a stub for people like me is a useful thing, thanks


Add a reference to Readme.md

Checklist

[x] I've given this PR a concise, self-descriptive, and meaningful title
[ ] I've linked relevant issues in the PR body
[x] I've applied the relevant labels to this PR
[ ] I've added relevant tests for my contribution
[ ] I've updated the documentation and/or added correct docstrings
[x] I've assigned a reviewer
[x] I've consulted ADS's internal developer documentation to ensure my contribution is in line with any relevant design decisions

Description
This quick PR aims to update the references of the ADS readme. The article that cites ADS --> https://www.sciencedirect.com/science/article/pii/S1361841520303042
Linked issues

Coverage remained the same at 82.653% when pulling 4e5a0ba6eb6ab2763929a9d98381e33bdde80b75 on vs/add_citation_readme into ffc79f83ed95945f9d22d391833e809d491e7977 on master.


Fix build error when mvn uses JDK 1.3 by default

This is a common error when not specifying the version of JDK that maven uses. It will lead to an error
error: generics are not supported in -source 1.3 that stops the setup of the streaming-benchmark-common.

@yuhc Sorry this has taken so long to get back to you.  We are trying to improve on this.
The change looks great but I don't see yet if you have submitted a CLA or not.

CLA is valid!

Oh there it is, so I am +1 on the change.


May we please get an update?

This is a VERY useful program, however there is a lot of errors due to using a newer game (Bellwright). May we please get this updated so that we can use it again for newer games?
Thank you!

You can try submitting an issue with a copy of specific assets that you are having trouble with, along with the Unreal engine version of the game