[Bug]: App reliably crashes on click of 'Default Locale' in the settings menu

Steps to reproduce
Go to the settings menu, click on 'Default Locale'
Expected behaviour
No crash
Actual behaviour
Crash
Device name
Xiaomi Redmi Note 10a
Android version
Android 13
GreenStash version
3.6.0
Device logs
No response
Additional information
No response

Please update your comment with relevant logs, the app includes a recovery screen which will appear in the event of crash and from there you can easily copy and paste logs when creating bug reports.

There's no recovery screen bro.

At least not for me

I'm unable to reproduce this problem in either Android 13 or 14. The app doesn't support changing locale below that yet. If you're not seeing a crash screen, please add a screen recording so I can try to figure out what might be causing the issue. Since you're able to reliably reproduce the error, it's important to provide additional information such as logs or other context. Otherwise, I'll have to close the issue for the time being until someone else reports it with enough details.

https://photos.app.goo.gl/CVDauWQboDHtoTyP9

https://photos.app.goo.gl/CVDauWQboDHtoTyP9

Alright, give me a sec.

Just so you know, you can upload the screen recording directly here on GitHub instead of using any third party service.

Try https://send.vis.ee then

https://github.com/Pool-Of-Tears/GreenStash/assets/36566555/e3584954-fd5f-4257-b68e-1ab7529bbc93
Compression helps too

My guess is it has something to do with MIUI, maybe it doesn't (yet) support app specific language configuration at all? I don't have too good of an idea of that yet, haven't yet implemented that in any of my apps.

Yeah, seems like it. See https://xiaomi.eu/community/threads/miui-14-per-app-language-support.69022/

WhatsApp.Video.2024-05-11.at.18.02.46.mp4
Compression helps too

Can you click on "view summary" and send me that ss or either copy paste it if it's possible? Because there it'll show actual logs of crash.

WhatsApp.Video.2024-05-11.at.18.02.46.mp4
Compression helps too

Can you click on "view summary" and send me that ss or either copy paste it if it's possible? Because there it'll show actual logs of crash.

java.lang.RuntimeException: Unable to start activity ComponentInfo{com.android.settings/com.android.settings.localepicker.AppLocalePickerActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.app.ActionBar.setDisplayHomeAsUpEnabled(boolean)' on a null object reference
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3834)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3980)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2394)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:211)
at android.os.Looper.loop(Looper.java:300)
at android.app.ActivityThread.main(ActivityThread.java:8296)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:559)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:954)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.app.ActionBar.setDisplayHomeAsUpEnabled(boolean)' on a null object reference
at com.android.settings.localepicker.AppLocalePickerActivity.onCreate(AppLocalePickerActivity.java:82)
at android.app.Activity.performCreate(Activity.java:8523)
at android.app.Activity.performCreate(Activity.java:8487)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1438)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3815)
... 12 more

WhatsApp.Video.2024-05-11.at.18.02.46.mp4
Compression helps too

Can you click on "view summary" and send me that ss or either copy paste it if it's possible? Because there it'll show actual logs of crash.

java.lang.RuntimeException: Unable to start activity ComponentInfo{com.android.settings/com.android.settings.localepicker.AppLocalePickerActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.app.ActionBar.setDisplayHomeAsUpEnabled(boolean)' on a null object reference at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3834) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3980) at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101) at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2394) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loopOnce(Looper.java:211) at android.os.Looper.loop(Looper.java:300) at android.app.ActivityThread.main(ActivityThread.java:8296) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:559) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:954) Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.app.ActionBar.setDisplayHomeAsUpEnabled(boolean)' on a null object reference at com.android.settings.localepicker.AppLocalePickerActivity.onCreate(AppLocalePickerActivity.java:82) at android.app.Activity.performCreate(Activity.java:8523) at android.app.Activity.performCreate(Activity.java:8487) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1438) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3815) ... 12 more

Damn, MIUI is going to be MIUI, I guess. Even if it's one of the highlighting features of Android 13, Xiaomi is out there, busy breaking standard Android APIs again... Although i use xiaomi myself but my device is currently running hyper os with android 14 where this seems to have fixed.

WhatsApp.Video.2024-05-11.at.18.02.46.mp4
Compression helps too

Can you click on "view summary" and send me that ss or either copy paste it if it's possible? Because there it'll show actual logs of crash.

java.lang.RuntimeException: Unable to start activity ComponentInfo{com.android.settings/com.android.settings.localepicker.AppLocalePickerActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.app.ActionBar.setDisplayHomeAsUpEnabled(boolean)' on a null object reference at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3834) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3980) at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101) at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2394) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loopOnce(Looper.java:211) at android.os.Looper.loop(Looper.java:300) at android.app.ActivityThread.main(ActivityThread.java:8296) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:559) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:954) Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.app.ActionBar.setDisplayHomeAsUpEnabled(boolean)' on a null object reference at com.android.settings.localepicker.AppLocalePickerActivity.onCreate(AppLocalePickerActivity.java:82) at android.app.Activity.performCreate(Activity.java:8523) at android.app.Activity.performCreate(Activity.java:8487) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1438) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3815) ... 12 more

Damn, MIUI is going to be MIUI, I guess. Even if it's one of the highlighting features of Android 13, Xiaomi is out there, busy breaking standard Android APIs again... Although i use xiaomi myself but my device is currently running hyper os with android 14 where this seems to have fixed.

Yeah I know, but I mean what would Android dev be if you didn't need to handle hundreds of edge cases for each device manufacturer 🙃

In any case, I think I'd just catch the exception in the onClick and thereupon show a toast/Snackbar, saying something along the lines of "your device doesn't support app-specific language configuration".

In any case, I think I'd just catch the exception in the onClick and thereupon show a toast/Snackbar, saying something along the lines of "your device doesn't support app-specific language configuration".

No, you can't really 'catch' this exception because the crash doesn't happen within the app's process, but outside of it within the internal system component of MIUI itself. If it was happening within the app, the app would've shown you the recovery screen and logs, as I said in my first message. It wasn't able to do so in this case because, well, the crash didn't happen within the app. The most I can do from my side is to figure out somehow if the user is running MIUI, then don't show this option in settings, same as how it doesn't show up if you're running Android 12 or below.

Okay I see, that's annoying

I've found this gist for checking whether a device is running MIUI, although it really doesn't strike me as a particularly safe or reliable way of doing so
https://gist.github.com/Muyangmin/e8ec1002c930d8df3df46b306d03315d
Really lovely of them to force you to include something like that into your code.

I've found this gist for checking whether a device is running MIUI, although it really doesn't strike me as a particularly safe or reliable way of doing so

Yeah, it isn't. According to this method, the option to change the app locale will also get removed from my device, which is running on Hyper OS and where this feature clearly works well.

I don't see any hyper os or miui 15 specific values in build.prop to cross check and verify that device is only running miui and not hyper os 😐

I mean you do get the MIUI version number under [ro.miui.ui.version.code], which for me is 14

Maybe the version always differs if it's hyperOS, as is the case for you, so you could possibly disable it only if the version is 14?

I mean you do get the MIUI version number under [ro.miui.ui.version.code], which for me is 14
Maybe the version always differs if it's hyperOS, as is the case for you, so you could possibly disable it only if the version is 14?

Actually i think i found a more reliable way to figure out weather the device is running only miui and not hyperos, can you try this command and show output (if any) getprop | grep ro.mi.os

I get nothing.

I get nothing.

Thanks! It seems grep ro.mi.os is only available in hyperos as mi internally calls hyperos just "OS" and the current version is OS1.0 instead of something like `MIUIXX'

I can combine this with standerd miui check to ensure that i dont block devices running hyperos from this feature.

Great 😅
Still such an incredibly hacky solution, but better than no solution.

Exactly, we should thank xiaomi for that 🙂


[Request] New sample with Agera

I'm not sure if this make sense, 'cause the RxJava version is already in progress and both may result in similar codes. Nevertheless, would be interested to see the differences fleshed out.

Yes it will make sense but we have to finish the RxJava sample first. It's the industry standard and Agera is not even stable yet.

Closing as obsolete.


Typing quotes adds more quotes instead of completing existing quotes

If I type one quote VS Code will add a pair with the cursor in the middle. When I type a string between them and then type another quote, VS Code will register there is a quote there already and just move the cursor to the right of it. Perfect.
However, when I use triple quotes, VS will add more quotes between them if I type anything in the middle instead of just moving the cursor to the right of what’s already there.
why are they different? The latter should also act like one quote.

Moving this issue to discussion as an enhancement request for comments and upvotes.


AttributeError: 'Session' object has no attribute 'block_filter'

Describe the bug
AttributeError: 'Session' object has no attribute 'block_filter'
To Reproduce
run ether_sql --settings='PersonalInfuraSettings' celery start -c2 -B -Q celery_filters -n worker1@%h, we get the error, but, it still push blocks in queque:
[2018-09-10 12:41:17,224][PID:8589][ERROR][ForkPoolWorker-3] Task ether_sql.tasks.filters.new_blocks[fb253629-be89-4c58-aee5-0c6ece03d65d] raised unexpected: AttributeError("'Session' object has no attribute 'block_filter'",)
Traceback (most recent call last):
  File "/home/ubuntu/ether_sql/envname/lib/python3.6/site-packages/celery/app/trace.py", line 375, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/home/ubuntu/ether_sql/envname/lib/python3.6/site-packages/celery/app/trace.py", line 632, in __protected_call__
    return self.run(*args, **kwargs)
  File "/home/ubuntu/ether_sql/ether_sql/tasks/filters.py", line 22, in new_blocks
    block_hashes = current_session.block_filter.get_new_entries()
AttributeError: 'Session' object has no attribute 'block_filter'
AttributeError: 'Session' object has no attribute 'block_filter'
[2018-09-10 12:41:51,134][PID:8588][INFO][ForkPoolWorker-2] Task ether_sql.tasks.filters.push_blocks_in_queue[7c3b666a-6363-4a50-9a66-64978708e897] succeeded in 33.95213927699933s: None
[2018-09-10 12:41:17,224][PID:8589][ERROR][ForkPoolWorker-3] Task ether_sql.tasks.filters.new_blocks[fb253629-be89-4c58-aee5-0c6ece03d65d] raised unexpected: AttributeError("'Session' object has no attribute 'block_filter'",)

it's there any problem if missing attribute block_filter?
Desktop (please complete the following information):

OS: ubuntu 16.04
Node Infura

it keep pushing blocks in queue,:

but, when i run ether_sql --settings='PersonalInfuraSettings' celery start -c1 -n worker3@%h, to push data into database it stay as in next image and nothing happens, but it still keep push blocks in queue

it might be cause of my memory? if i add many workers, system cannot allocate memory, it just has 500 mb ram.. it might be also why i get killed when i try to push blocks into database with geth/infura?

Adding new blocks using an Infura node is not enabled yet with the library:
https://github.com/analyseether/ether_sql/issues/54, it is in the pipeline.
The image says that the function push_blocks_in_queue ran but not necessarily the blocks have been pushed in the database (this command is not yet enabled with infura).
Can you try this with a parity node?

trying to sync parity light node, but there are no peers, around 200k blocks left
2018-09-10 22:30:10 UTC Syncing #6117108 0xa7a6…8562     0 hdr/s      0+    0 Qed  #6117108    1/50 peers   664 bytes cache 0 bytes queue  RPC:  0 conn,  0 req/s,   0 µs

some crazy stuff here or i'm blind/dumb/tired :)))
running ether_sql --settings='PersonalParitySettings' scrape_block_range --start_block_number 6308685 --no-fill_gaps
(envname) [23:14 ubuntu@ip-172-26-15-152 ether_sql] > ether_sql --settings='PersonalParitySettings' scrape_block_range --start_block_number 6308685 --no-fill_gaps
Usage: ether_sql [OPTIONS] COMMAND [ARGS]...

Error: Invalid value for "--settings": invalid choice: PersonalParitySettings**.** (choose from DefaultSettings, ParityTestSettings, PerrsonalParitySettings, PersonalGethSettings, PersonalInfuraSettings, TestSettings)

idk from where comes that dot after PersonalParitySettings lol

@dirmansebastian were you able to resolve the mast bug?
I retried and everything works fine ...

no luck, same problem :)))


Testing with mocking

Refactor a few simple component tests so that dependent components are mocked.  This now allows development to occur on individual components without causing tests to fail on components which depend on the component being changed.

Closing so I can merge into a different branch


Improve drag and drop in web app

Left to do:
Replace bg with border.
Investigate mobile rotate not working.


Pythia not linked correctly

A repro:
echo -e "generate p p > e+ e- \$$ z\noutput dy" |mg5_aMC
cd dy
echo "shower=Pythia8" | bin/generate_events

produces (among a lot of other output)
Command "generate_events " interrupted with error:
Exception : program /root/data/dy/Events/run_01/PY8_parallelization/split_0/run_PY8.sh 0 launch ends with non zero status: 127. Stop all computation
Please report this bug on https://bugs.launchpad.net/mg5amcnlo
More information is found in '/root/data/dy/run_01_tag_1_debug.log'.
Please attach this file to your report.

In fact the log is not helpful but
# tail /root/data/dy/Events/run_01/PY8_parallelization/split_0/PY8_log.txt
   158         11  e-                  91   122     0     0     0     0     0      0.011      0.004    101.209    101.209      0.001
   159        -11  e+                  91   122     0     0     0     0     0      0.045     -0.001    307.539    307.539      0.001
   160         22  gamma               91   135     0     0     0     0     0      0.076     -0.198     -7.013      7.017      0.000
   161         22  gamma               91   135     0     0     0     0     0      0.015     -0.155     -2.612      2.617      0.000
   162         22  gamma               91   140     0     0     0     0     0      0.080      0.110     -0.213      0.253      0.000
   163         22  gamma               91   140     0     0     0     0     0      0.086     -0.031     -0.119      0.150      0.000
                                   Charge sum:  2.000           Momentum sum:      0.000     -0.000     -0.000  13000.000  13000.000

 --------  End PYTHIA Event Listing  -----------------------------------------------------------------------------------------------
./MG5aMC_PY8_interface: symbol lookup error: ./MG5aMC_PY8_interface: undefined symbol: _ZN5HepMC15WeightContainer9push_backERKdNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE

@nsmith- Which image are you using for this?

Ah yeah, this was with a container I was attempting to modify. With scailfin/madgraph5-amc-nlo:mg5_amc3.5.0 it seems to work! Sorry for the noise.

@nsmith- No worries. If you need something backported, like PR #72, to other tags I can do that. I just don't usually do it unprompted as it is a slow (though easy) process.


[Bug][CI] pulsar-function-go build failures are ignored when the last commit in the PR doesn't modify go files

Search before asking

[X] I searched in the issues and found nothing similar.

Version
master
Minimal reproduce step

create a PR with changes to pulsar-function-go which break the build
add a commit outside of pulsar-function-go
the CI build passes successfully and makes the PR mergable

What did you expect to see?

if the pulsar-function-go job fails for the PR, it shouldn't make the CI build mergable

What did you see instead?

the PR was mergable

Anything else?
This is a known limitation of the way how the GitHub Actions workflow ci-go-functions.yaml has been configured to trigger for changes to pulsar-function-go/** path
on:
  pull_request:
    branches:
      - master
    paths:
      - '.github/workflows/**'
      - 'pulsar-function-go/**'
  workflow_dispatch:

the problem would be fixed by using apache/pulsar-test-infra/paths-filter@master for detecting changed files in ci-go-functions.yaml.
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

it shouldn't make the CI build mergable

Then we may always run the workflow.
https://github.com/apache/pulsar/blob/7a99e74220bdff7a0dff3dbbf3befb2316f3a6c8/.asf.yaml#L52
Currently, only the pulsar-ci.yml workflow is required.

Weird. Does GitHub Actions fileter paths only for the last commit? This should be a bug for the GHA side.

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#git-diff-comparisons

Pull requests: Three-dot diffs are a comparison between the most recent version of the topic branch and the commit where the topic branch was last synced with the base branch.

From the doc the workflow should run because the diff is counted from the latest version to the most recent base branch.

@lhotari any feedback or new instance? I don't find a similar case now.

Closing..
Feel free to reopen if there is a live demo.


Invalid HTML on the sidebar

First of all I want to thank you for this great template!
The menu code looks like the following

         Ecommerce

         Analytics
         new

However, it is invalid to add
 between the
 and the

I recommend that you change the code so something like this

         Ecommerce

         Analytics
         new

Of course, the CSS code may have to change as well to accommodate the change

I also detected the same problem.

Thanks for letting us know about the issue. We will fix it soon.


draft setup-gh fails with error

draft setup-gh fails with the following error:
$ draft setup-gh
✔ azure
Enter app registration name: ???
✔ ???
Enter resource group name: ???
Enter github organization and repo (organization/repoName): ???/???
[Draft] --> Setting up Github OIDC... ⡿ [Draft] ERROR: usage error: --assignee STRING | --assignee-object-id GUID

az version output:
$ az version
{
  "azure-cli": "2.33.1",
  "azure-cli-core": "2.33.1",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {
    "containerapp": "0.3.4",
    "log-analytics": "0.2.2",
    "tipsextension": "0.0.1"
  }
}

I will submit a PR for this in a moment.

I just ran this on the main branch. Could you provide some more information about your environment, draft version, etc.
➜ draftv2 (main) ✗ ./draft setup-gh -p azure -v
Enter app registration name: iztesting
[Draft] Checking that Azure Cli is installed...
[Draft] Checking that user is logged in to Azure CLI...
✔ 0e0d6284-a155-4d10-83da-9675ef354298
Enter resource group name: izroll-dev
Enter github organization and repo (organization/repoName): imiller31/go_echo
[Draft] Commencing github connection with azure...
[Draft] Checking that github cli is installed...
[Draft] --> Setting up Github OIDC... ⣾ [Draft] Github cli found!
[Draft] Checking that user is logged in to github...
[Draft] --> Setting up Github OIDC... ⡿ [Draft] User is logged in!
[Draft] Checking that provided information is valid...
[Draft] --> Setting up Github OIDC... ⣾ [Draft] Commencing Azure app creation...
[Draft] 2022-06-14 11:39:06.760873 -0400 EDT m=+29.686785587
[Draft] --> Setting up Github OIDC... ⣷ [Draft] App created successfully!
[Draft] 5.506264772s
[Draft] Creating Azure service principal...
[Draft] 2022-06-14 11:39:12.26724 -0400 EDT m=+35.193102374
[Draft] --> Setting up Github OIDC... ⡿ [Draft] Checking sp was created...
[Draft] --> Setting up Github OIDC... ⣷ [Draft] Service principal exists
[Draft] Service principal created successfully!
[Draft] 3.987388489s
[Draft] Fetching Azure account tenant ID
[Draft] --> Setting up Github OIDC... ⣽ [Draft] Fetching Azure application object ID
[Draft] --> Setting up Github OIDC... ⣯ [Draft] Assigning contributor role to service principal...
[Draft] --> Setting up Github OIDC... ⣾ [Draft] Role assigned successfully!
[Draft] Checking for existing federated credentials...
[Draft] --> Setting up Github OIDC... ⣽ [Draft] No existing credentials found
[Draft] Creating federated credentials...
[Draft] --> Setting up Github OIDC... ⣾ [Draft] Waiting 10 seconds to allow credentials time to populate
[Draft] --> Setting up Github OIDC... ⢿ [Draft] Checking for existing federated credentials...
[Draft] --> Setting up Github OIDC... ⣽ [Draft] Credentials found
[Draft] Setting AZURE_CLIENT_ID in github...
[Draft] --> Setting up Github OIDC... ⢿ [Draft] Setting AZURE_SUBSCRIPTION_ID in github...
[Draft] --> Setting up Github OIDC... ⣷ [Draft] Setting AZURE_TENANT_ID in github...
[Draft] --> Setting up Github OIDC... ⢿ [Draft] Github connection with azure completed successfully!
[Draft] Draft has successfully set up Github OIDC for your project 😃
[Draft] Use 'draft generate-workflow' to generate a Github workflow to build and deploy an application on AKS.

az version
➜ draftv2 (main) ✗ az version
{
  "azure-cli": "2.37.0",
  "azure-cli-core": "2.37.0",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {
    "aks-preview": "0.5.60"
  }
}

I just re-ran from main and encountered a different error.
[Draft] --> Setting up Github OIDC... ⢿ Fatal: [69 82 82 79 82 58 32 84 104 101 32 100 105 114 101 99 116 111 114 121 32 111 98 106 101 99 116 32 113 117 111 116 97 32 108 105 109 105 116 32 102 111 114 32 116 104 101 32 80 114 105 110 99 105 112 97 108 32 104 97 115 32 98 101 101 110 32 101 120 99 101 101 100 101 100 46 32 80 108 101 97 115 101 32 97 115 107 32 121 111 117 114 32 97 100 109 105 110 105 115 116 114 97 116 111 114 32 116 111 32 105 110 99 114 101 97 115 101 32 116 104 101 32 113 117 111 116 97 32 108 105 109 105 116 32 111 114 32 100 101 108 101 116 101 32 111 98 106 101 99 116 115 32 116 111 32 114 101 100 117 99 101 32 116 104 101 32 117 115 101 100 32 113 117 111 116 97 46 10]
Exiting.

This is because az ad app create / createAppCmd := exec.Command("az", "ad", "app", "create", "--only-show-errors", "--display-name", sc.AppName) is failing in my directory, and it's using log.Fatal on a []byte.
I'll send a new PR to unblock this, avoid using log.Fatal, log.Printf the command output, and return errors instead.
For anyone hitting this, the underlying error is/was:
ERROR: The directory object quota limit for the Principal has been exceeded. Please ask your administrator to increase the quota limit or delete objects to reduce the used quota.

I'll then try to unblock the above and see if I can repro any further issues.

Thanks for catching this

I recently noticed the original error may have been related to: https://docs.microsoft.com/en-ca/cli/azure/microsoft-graph-migration


Docs/beta

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/scullyio/scully/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@geromegrignon This is the pr

I was going to make a PR about the docs.
If you mind updating this PR :
The showcase, utils, and scully doc files don't have a title metadata.
It would be great to add it with a capitalized name to be consistent with the others files :

Doing a quick review right now too.

I was going to make a PR about the docs.
If you don't mind updating this PR :
The showcase, utils, and scully doc files don't have a title metadata.
It would be great to add it with a capitalized name to be consistent with the others files :

Doing a quick review right now too.

done :D


Redundant definition of maildir path

In my recent mail-migration tests for (see #757), I have noticed that the maildir of each user is defined in two places but appearently resolving to the same directory (as long as the login includes the domain):

In /etc/dovecot/10-mail.conf it is defined as mail_location = maildir:/var/mail/%d/%n.
In /etc/dovecot/userdb, the home directory is specified the same way.

In my case, since I am removing the domain-name from the login, the userdb contains lines like
mailtest:{SHA512-CRYPT}$6$kRR/7zHpZmxOi4VB$dJj:5000:5000::/var/mail/test.knappi.org/mailtest::

so the home directory includes the domain name. However, maildir:/var/mail/%d/%n resolves to /var/mail/mailtest.
Somehow, both directories are initialized with a maildir-structure, but on /var/mail/mailtest is used to store mails. This behavior is rather confusing.
I would like to keep mails in /var/mail/test.knappi.org/mailtest because it makes switching to the login with domain easier later on. This works for me when the mail-location pattern is changed to  mail_location = maildir:%h. Could this be changed (should I submit a PR)? Or is there a good reason for the specific pattern (%d/%n) ?

You can make the change and run tests. It should tell fast enough if it breaks some configuration.
If the PR is ok no problems with merging it.

Closing due to inactivity. Plus while I haven't tested it I suspect that this would break all existing installations? Moving the mail location sounds like a very disruptive change.


23 sap quickstart basic checkov implementation

Implementing basic Checkov checks for SAP quickstart.
This deployment is a public one, so requires public access for Storage Accounts and Key Vault.
I skip a couple of checks because is a public deployment and because a lack on permisions to implement RBAC and encription to Storage account.
I tested and can be deployed with no errors with the correct "local.tfvars" file.

@furlan can you help me to review this PR..?
Thank you in advance.

I reviewed the files and also tested the SAP connection through the SHIR created.
Everything looks good for me.


mujoco: 2.3.0 -> 2.3.7

Description of changes
Changelog: https://github.com/deepmind/mujoco/releases/tag/2.3.7
@samuela
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

diff LGTM

Cool ! Do you have the rights to merge ?

Cool ! Do you have the rights to merge ?

Thanks so much !


Add files via upload

Fixes # .
Changes proposed in this pull request:

Added the BLKZ custom strategy

Adding in a new custom strategy for the XDC network (BLKZ)

Closing this as stale. feel free to reopen if needed


docs: Update 'Include organization name in subject line' settings' docs.

This commit updates the help page 'email-notification.md' to reflect the change in zulip#24075 from a checkbox to a dropdown for the 'Include organisation name in subject line' setting.
Earlier the commit was dropped from the PR because:
Alya Abbott said:

Please don't merge the documentation commit; I will tweak it once the feature has been integrated.

Fixes: follow-up PR to #24075

Screenshots and screen captures:

Current Doc

Updated Doc

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Thanks! Replaced by #24714.


Fix broken build on latest talib version

This previous script defaulted to using the latest version of talib available on NPM, however, the version as of now 1.1.2 is broken and won't build with gekko. This commit fixes the build by sticking to a known working version based on the DOCKERFILE 1.0.2.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Other information:

@askmike The TALIB versioning is still an issue that breaks the build. Please merge so new users can build successfully.


Support adding benchmark name to bench-metric

-this schema is used for post-process-data.json
-when rickshaw supports just 1 benchmark type per run,
the benchmark name was generally already known,
as post-processing was done for a known, singular
benchmark.  To prepare to multi-benchmark use, we
need the post-process-data to include the benchmark
name.  Once this is merged, all benchmark subprojects
will need to be updated to include their benchmark
name in this file they generate.

I'm almost positive that while this will allow the new parameter to exist it will not require it. I recently noticed this when doing some other work and it is on my todo list to fix. Since it's such a rampant problem at this point in the rickshaw schemas there is no reason to worry about it for this one thing, besides, if we made this actually be required it would make CI fail since the benchmarks wouldn't have it yet, and for that matter it would be the usual chicken-and-egg where you could not add it to the benchmarks without it being added here first either.

This is why I did not make it a requirement yet, because it would break every benchmark.  Once all existing benchmarks have it, then and only then can we change to being required.


Feature to Apply Classes in fields and define them in identity file!

Hi,
I want to customize the netlify CMS by doing 50% width of some fields. So I wanted to add class to that field. but didn't found anything!
I want this featured!

Hi @yousafblogger, can you please follow the issue template?
Without it it's very hard to understand what you're trying to accomplish.
Closing this issue as I believe it is covered by https://github.com/netlify/netlify-cms/issues/1727.
If that's not the case please comment


Zlib: add stream-oriented operations

This PR introduces stream-oriented primitives for dealing with zlib data.
The code is split into functional commits for easier review.
Memory pressure is directly dependent on how often the stream output buffer is flushed through read() calls, so this implementation makes it possible to continuously compress data within a memory cap.
Notes:

I'm note very familiar with the documentation syntax, I hope I didn't mess up there and provide sufficient information.
I didn't feel necessary to include an explicit stream destructor since I assume that once the stream goes out of scope, the implicit destructor will be called freeing all leftover memory (the zstrm_t struct). That's why I chose to use *new() naming suffix for the stream constructor

Only happy testing has been performed (successfully) so far, comments welcome
HTH

On a first glance this looks good. Not overly happy with the constructor naming, "infnew" and "defnew" reminds me on infinity and default, not inflate and deflate for some reason. What about calling the constructors inflater() and deflater() or inflate_stream()  and deflate_stream() ?

Rename the internal resource type names to zlib.inflate and zlib.deflate for clarity
Is Z_FINISH really a useful default flush mode for the deflate write() method? Should we maybe default it to Z_NO_FLUSH?
Dito for inflate write()
The documentation is a bit broken, you should not put @see text inline into text (to test documentation rendering locally, run npm install; npm run doc in the source dir, then browse docs/module-zlib.html)
The call stream.write('', Z_FINISH) looks a bit messy, maybe it makes sense to implement a stream.finish() convenience method?

On a first glance this looks good. Not overly happy with the constructor naming, "infnew" and "defnew" reminds me on infinity and default, not inflate and deflate for some reason. What about calling the constructors inflater() and deflater() or inflate_stream()  and deflate_stream() ?

Ok, I'll go with the former to keep things short.

Rename the internal resource type names to zlib.inflate and zlib.deflate for clarity

Won't that be confusing with the same-name functions ?

Is Z_FINISH really a useful default flush mode for the deflate write() method? Should we maybe default it to Z_NO_FLUSH?

Dito for inflate write()

I suppose you have a point. My initial idea was to have the stream functions default to the same behavior as the single-call oriented ones, but it's probably not ideal now that I think about it. Will switch to Z_NO_FLUSH instead.

The documentation is a bit broken, you should not put @see text inline into text (to test documentation rendering locally, run npm install; npm run doc in the source dir, then browse docs/module-zlib.html)

Sorry no can do. I don't have npm on my system and no intention of installing it just for this use given how it's been a proven attack vector multiple times already. Sorry. I'll fix the @see.

The call stream.write('', Z_FINISH) looks a bit messy, maybe it makes sense to implement a stream.finish() convenience method?

Actually the example is clumsy (I was lazy there). In real life you would of course use Z_FINISH with the last sent chunk, not with an empty one. The latter works and completes the stream to a valid archive but adds an unnecessary extra block. I'll improve the doc.

@jow- friendly ping, is there anything else you wanted changed here? :)


bug: No values for charging session with nothing charged (pv überschuss)

If you charge with PV, it can happen that you plug the charger in but nothing is charged because the pv energy is not enough. (The car has than often an error the whole charging time)
Currently a charging session with no values is than stored. The session should have 0kwh, start and end soc, etc...

This is on purpose. It makes it much easier to see sessions where the charging was never started. %Start is the SoC when the charging was started, not when the car was connected.

Okay, thanks.
And is it on purpose if you want to delete this session, you have to at first fill out the start date field with some numbers until you can delete the session?

No :) good catch! That is a bug.

Fixed in 0.20.0


Remove "THIS CODE IS GENERATED" comments 8 of 12

same as https://github.com/opensearch-project/opensearch-java/pull/235 but broken down into different commits / branches.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

closing in favor of one PR with all the commits #263


Add Custom Image Support for InstaScale in the CodeFlare Operator

The ability to update or revert the InstaScale image in the MCAD CR will be very helpful going forward.

We would want to update the operator, api, and crd: https://github.com/project-codeflare/codeflare-operator/blob/main/api/v1alpha1/instascale_types.go


For #180: it is not possible to include the name of the variable.

For #180 It was already reported by @llorllale in README.md as a know limitations - The java compiler is known to inline constant variables as per [JLS 13.1].

@yegor256/z please, pay attention to this pull request

Job #279 is now in scope, role is REV

Codecov Report

Merging #279 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #279   +/-   ##
=========================================
  Coverage     74.88%   74.88%
  Complexity      173      173
=========================================
  Files            33       33
  Lines          1067     1067
  Branches         82       82
=========================================
  Hits            799      799
  Misses          235      235
  Partials         33       33

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/org/jpeek/skeleton/XmlClass.java
93.87% <ø> (ø)
13 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48fcf32...f4b38c2. Read the comment docs.

@yegor256/z everybody who has role REV is banned at #279; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@yegor256/z everybody who has role REV is banned at #279; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@yegor256 ping.

@paulodamaso/z everybody who has role REV is banned at #279; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@oridan please resolve the pr conflicts

@paulodamaso ping.

@oridan What was made in this pr?

@paulodamaso I removed the puzzle because it cannot be done. As mentioned before it is a know limitation:

For #180 It was already reported by @llorllale in README.md as a know limitations - The java compiler is known to inline constant variables as per [JLS 13.1].

@oridan Okay, I did not understood that it could not be done from the available documentation.

The job #279 is now out of scope


Feature/wallet button

Done:

[x] Created a wallet button for connect wallet interactions.

To do:

Display address on connected wallet
Implement on:
[x] pages/liquidity/index.ts 163 *
[x] src/components/Balances.tsx 78
[x] src/components/layoutprofileSection *
[x] src/components/liquidity/Add/AddLiquidityComponent.ts 382
[x] src/components/Modals/WrapStellarAssetModal.tsx 100

Updated pull request #267 https://github.com/soroswap/frontend/pull/267


Adds source code link for Rural Payments website

Makes it easier to find the source code behind the style guide example.

Not sure where the Land Registry website source code is so haven't added it in this PR

Thanks @pflannery!
I'll ask Mat Johnson (@demotive) if he can update the Land Registry guide as a separate PR.

thanks @gemmaleigh

@gemmaleigh - The Land Registry style guide fell by the wayside for a long time, and isn't being maintained (long story). A new one is in the works (another long story). I'm making a note to add a PR to this repo when we're up and running.


Resolve most Doxygen warnings

The only significant remaining warnings are for the expression template operator overloads.  Any thoughts on whether there's value in documenting them?

The only significant remaining warnings are for the expression template operator overloads. Any thoughts on whether there's value in documenting them?

I think it's fine to leave these out.

LGTM


refactor: refactoring the initialization way of the MetaData

Using a chained call to initialize MetaData like NewMetaData.WithNewMetaData().WithKeySize(keySize).WithValueSize(valSize)...

I have completed.

Merged, your coding capability is unbelievable.


ARTEMIS-1354 Critical IO Error on AIO write failure

@clebertsuconic This is your neck of the woods.  I've seen this cause loss of availability on shared store when the SAN network is down.  However, this is old code and I am always dubious about changing journal level code that's been around for a while.  Could you please verify.

@clebertsuconic Note that with this code change I could no longer reproduce the shared store issue described above.


Fixing the issue of provisioner being override by torpedo params even it is  passed by ScheduleOptions from test and Adding support for provisioner volume snapshotclass mapping

What this PR does / why we need it:
Fixed the issue of provisioner getting override even though it is passed from ScheduleOptions
Adding common function for passing provisioner volumesnapshotclass mapping
Ignore reviewing the dummy test BasicBackupCreationDummyTest, which will be removed before merge
Which issue(s) this PR fixes (optional)
Closes #https://portworx.atlassian.net/browse/PB-5533
Special notes for your reviewer:
https://jenkins.pwx.dev.purestorage.com/job/Users/job/santoshn/job/ocp-quick-byoc/26/execution/node/162/log/?consoleFull
https://aetos.pwx.purestorage.com/resultSet/testSetID/566432/testCaseID/3409909
Latest Log : https://jenkins.pwx.dev.purestorage.com/job/Users/job/santoshn/job/ocp-quick-byoc/87/execution/node/162/log/?consoleFull
Ran the basic test to ensure it is not breaking
https://jenkins.pwx.dev.purestorage.com/job/Users/job/santoshn/job/ocp-quick-byoc/23/consoleFull
Latest Log : https://aetos.pwx.purestorage.com/resultSet/testSetID/584295/testCaseID/3552299

Please create a separate function instead of modifying the existing one

done

As discussed, please pass the volume snapshot map in the backup Request itself and keep the function signature of AdditionalBackupRequestParams unchanged

-> Done


Implement support for noexcept overridable methods

Fixes #782
I updated the Composable_h.h file so there's a lot of noise in there.

I updated the Composable_h.h file so there's a lot of noise in there.

We should just remove this file - it shouldn't be included in the repo.

Reverted the changes for now


Added functionality for histogramming non-integer cutvals for weighted graphs.

Hi Matias, thanks for the contributions to IQS.


[Core] Spark assert_true and raise_error function support

Description
spark assert_true and raise_error function not compatible with current velox type system and function register interface.
as below query a example,
val df = spark.sql("select assert_true(1 > 0) as v, id from t")
df: org.apache.spark.sql.DataFrame = [v: void, id: bigint]

df.schema
res3: org.apache.spark.sql.types.StructType = StructType(StructField(v,NullType,true),StructField(id,LongType,true))

it would generate void type and NullType in output schema which would convert to unknown type in velox, for raise_error, it expect void return type but velox function always expect a non-void return type.
One way i tried is convert raise_error from void return type to string type but it need we update not only expression itself but also the output type schema also from NullType to StringType, otherwise would encounter mem allocation issue based on my local test.
@zhouyuan / @PHILO-HE / @FelixYBW

Is the two function implemented in Presto list or Spark list?

want to use this item to track how do support for those specific spark functions, @zhouyuan / @PHILO-HE / @FelixYBW
could you put your thought here, actully the issue can be summaried as how to support NullType schema and void return type spark function.

Is the two function implemented in Presto list or Spark list?

spark list https://spark.apache.org/docs/latest/api/python/reference/pyspark.sql/api/pyspark.sql.functions.assert_true.html

looks if we can make a generic solution to let gluten always call vanilla spark to project values for the function, it would be nice. like https://github.com/facebookincubator/velox/issues/9957 encounter similar issue

I see. just talked with @zhli1142015 on the interval issue.
We need a fundamental way to test all the Spark functions. @rui-mo Can your velox_Spark fuzzer test achieve this?

looks if we can make a generic solution to let gluten always call vanilla spark to project values for the function, it would be nice. like facebookincubator/velox#9957 encounter similar issue

It's different issue from input_file_name(). If we can implement the function in Velox, we should do that firstly.

looks if we can make a generic solution to let gluten always call vanilla spark to project values for the function, it would be nice. like facebookincubator/velox#9957 encounter similar issue

It's different issue from input_file_name(). If we can implement the function in Velox, we should do that firstly.

so please check my this try
One way i tried is convert raise_error from void return type to string type but it need we update not only expression itself but also the output type schema also from NullType to StringType, otherwise would encounter mem allocation issue based on my local test.
``

this need one change to apply if we detect there is a `NullType` in output schema, then we need convert it always `StringType`, does that change ok ?

this need one change to apply if we detect there is a NullType in output schema, then we need convert it always StringType, does that change ok ?

No, we should use the same data type as Spark.
Can assert_true return unknown_type in velox? null_type is implemented as unknown_type in velox.

@gaoyangxiaozhu, velox doesn't support UnknownType (NullType) for function output? I remember this type is supported for input.

@gaoyangxiaozhu, velox doesn't support UnknownType (NullType) for function output? I remember this type is supported for input.

got ! let me try! thank you @PHILO-HE / @FelixYBW

We need a fundamental way to test all the Spark functions. @rui-mo Can your velox_Spark fuzzer test achieve this?

@FelixYBW With this tool, the result of a Velox Spark function can be compared with the result of vanilla Spark.  Currently we are working on enabling it in aggregate fuzzer test.


[Event Request] Report 394 Suggest Employee Payments

Hello,
please add a new publisher events similar to Report Suggest Vendor Payments.
In function CopyTempEmpPaymentBuffersToGenJnlLines():
[IntegrationEvent(false, false)]
local procedure OnBeforeUpdateGnlJnlLineDimensionsFromTempBuffer(var GenJournalLine: Record "Gen. Journal Line"; TempEmplPaymentBuffer: Record "Employee Payment Buffer" temporary)
    begin
    end;

In function MakeGenJnlLines():
[IntegrationEvent(false, false)]
local procedure OnUpdateTempBufferFromEmployeeLedgerEntry(var TempEmplPaymentBuffer: Record "Employee Payment Buffer" temporary; EmployeeLedgerEntry: Record "Employee Ledger Entry")
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Updated Vulkano to 0.34, egui to 0.23 as well as all the examples.

I found the reason! (After some long time just going through my changes)
As you suspected the problem originates from the newest version of either Egui or it's demo crate.
What should we do? Keep the version of Egui on 0.22 or accept living with the 0.23 problem?

Maybe accept living with it then.

Hey, apologies. #50 just went through with lints etc. I was hoping if you could update this PR to just update the egui library? Then we can make a new release

Hey, apologies. #50 just went through with lints etc. I was hoping if you could update this PR to just update the egui library? Then we can make a new release

My bad, I totally missed this PR when I started mine. :( Sorry!

oops. I forgot about the lints because I don't have them set up the same way.
I'm going to do that later today.

oops. I forgot about the lints because I don't have them set up the same way.
I'm going to do that later today.

No rush!

oops


breaks default fivem scoreboard

prevents default fivem scoreboard from appearing at all when this resource is enabled.

Are you sure there isn't something else causing the UI to break? Lots of servers use this resource and this is the first I've heard of this issue.

its only this one as far as i know.  I got this in conjunction with the tornado mod to allow custom sounds.

Not sure what this is and there's not enough information here to really solve it. In addition, this resource will soon be deprecated in favor of the next iteration, SoundFX.


fix canonical links for crawlers

This PR is to resolve https://github.com/fortran-lang/webpage/issues/222 , Please refer : https://fortran-lang.discourse.group/t/4942 .
This would add a custom canonical link tag to all the pages of the webpage.
Thanks and Regards,
Henil
CC @awvwgk @certik

What is the purpose of the canonical tag? The url seem long and pointing to some github.io url, while I would think our canonical page is "https://fortran-lang.org/".

@certik the canonical links are used to show a crawler that the duplicate content is available in this link and don't penalise/remove this page from the search engine as they are related ( even if you have crawled the older site and find this as a duplicate).

I see. And the link that you put into the canonical is the "main" content, or the "secondary" content?
To me, the word canonical means the "main" content, thus https://fortran-lang.org/.

@certik yes, we should add this code to the duplicate site / older site.

@henilp105 ok, ping me once you have a PR ready for reivew.


Can only restore 15 tabs at a time

In the corral are 126 tabs.
Check the Select all tabs box and the Restore button grays out.
Individually check the boxes and the Restore button is functional UNTIL you check the 16th box, then it grays out again. What's the point of only restoring a dozen at a time?
Ain't nobody got time for that!
I want the ENTIRE session restored most of the time.
And, if I had multiple windows with tabs, I want the session restored that way unless I choose to open all tabs in one window. Those tabs were in multiple windows for a reason - If I'd wanted them combined I would have opened them in one window myself.

Restoring 126 tabs at once is almost guaranteed to crash Chrome! That's a ton of network requests at once. I added the 15 tab limit because of https://github.com/jacobSingh/tabwrangler/issues/109, but the limit is admittedly arbitrary.
I could change that to a warning saying opening many new tabs at once could cause performance problems or even crash your browser. That'd be nicer than preventing it entirely.

RE: restoring to the correct windows
https://github.com/jacobSingh/tabwrangler/issues/138 tracks opening tabs in the correct window

I don't normally have that many tabs open (usually less than 80), but Chrome & Safari haven't crashed because of it.
IMO tabs should either be restored but not loaded, or loaded one at a time instead of all at once.
That's the way a good session manager works to restore tabs when a browser is opened.
I don't see why TW can't function the same way, to prevent overloading the network when opening an abundance of tabs.


Ore texture overlays need work

Thought I could get by with a simple photoshop hack, however, they just don't look right. Need to spend some time extracting the parts from the 16x16 textures and build them as overlays.

Iron blends in TOO much, Lapis looks like Cobalt from Tinkers.


Flaky TestHealthTrait

What happened?
The E2E test TestHealthTrait is flaky due to failing integration ready condition assertion in health_test.go#L366
The E2E test starts an integration that should never become ready due to health traits. But at some point the Integration condition status is ready=true because for a short term period the Deployment ready state is reflected in the status:
- firstTruthyTime: "2024-04-09T20:36:38Z"
   lastTransitionTime: "2024-04-09T20:36:38Z"
   lastUpdateTime: "2024-04-09T20:36:38Z"
   message: 1/1 ready replicas
   reason: DeploymentReady
   status: "True"
   type: Ready

Shortly after that the Integration controller monitor will set the condition status to ready=false because of the health trait evaluation. This means there is a racing condition on the Integration ready status that causes the test to be flaky
Steps to reproduce
See https://github.com/apache/camel-k/actions/runs/8620813154/job/23630392501?pr=5342
Relevant log output
Camel K installed in namespace test-ce148498-46dd-4778-bf93-496d290c5607
      health_test.go:366:
          Failed after 9.120s.
          Expected
              <v1.ConditionStatus>: True
          to equal
              <v1.ConditionStatus>: False

Camel K version
2.3.0

I think it's a duplicate of #4922

@squakez good catch, thanks

Can I take this?


Error in .install_repos, argument "force" is missing, with no default

Describe the bug
Execution halts building during the run of install.R with the following output.
> install.packages("BiocManager", repos="https://cran.rstudio.com")
Installing package into ‘/usr/local/lib/R/site-library’
(as ‘lib’ is unspecified)
trying URL 'https://cran.rstudio.com/src/contrib/BiocManager_1.30.15.tar.gz'
Content type 'application/x-gzip' length 262210 bytes (256 KB)
==================================================
downloaded 256 KB

* installing *source* package ‘BiocManager’ ...
** package ‘BiocManager’ successfully unpacked and MD5 sums checked
** using staged installation
** R
** inst
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** installing vignettes
** testing if installed package can be loaded from temporary location
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (BiocManager)
>
> BiocManager::install(version="3.14", update=TRUE, ask=FALSE)

The downloaded source packages are in
	‘/tmp/Rtmp8mPtpK/downloaded_packages’
'getOption("repos")' replaces Bioconductor standard repositories, see
'?repositories' for details

replacement repositories:
    CRAN: https://packagemanager.rstudio.com/all/__linux__/focal/latest

Bioconductor version 3.14 (BiocManager 1.30.15), R 4.1.0 (2021-05-18)
Installing package(s) 'BiocVersion'
trying URL 'https://bioconductor.org/packages/3.14/bioc/src/contrib/BiocVersion_3.14.0.tar.gz'
Content type 'application/x-gzip' length 969 bytes
==================================================
downloaded 969 bytes

* installing *source* package ‘BiocVersion’ ...
** using staged installation
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded from temporary location
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (BiocVersion)

The downloaded source packages are in
	‘/tmp/Rtmp8mPtpK/downloaded_packages’
Error in .install_repos(pkgs, old_pkgs, instPkgs = instPkgs, lib = lib,  :
  argument "force" is missing, with no default
Calls: <Anonymous> ... .install -> .install_repos -> .install_filter_up_to_date
Execution halted
The command '/bin/sh -c R -f /tmp/install.R' returned a non-zero code: 1

To Reproduce
docker build --no-cache -t bioconductor_docker:devel .
Expected behavior
I expect the build to complete without issue.
Desktop (please complete the following information):

OS: Ubuntu 20.04

Additional context
I know this is an issue with BiocManager, but I was able to build the docker earlier this week. Please let me know if I should report it there.

The issue should probably be moved to BiocManager and I've created a PR for Martin to review https://github.com/Bioconductor/BiocManager/pull/105

@LiNk-NY I'm sorry I missed this somehow. I will try it now and get back to you.

@LiNk-NY Your fix worked for me. Thank you.


::content styling rule should have higher specificity than the distributed element's :host rule

If <x-foo> has this style:
:host {
  color: blue;
}

And <x-bar> has this style:
:host > :content > * {
  color: red;
}

When <x-foo> is distributed into <x-bar> I expect the <x-foo> to be red, but it is blue. I can work around this by using a wrapper element around the <content> in <x-bar>, which makes the ::content rule more specific.

This has been fixed in Polymer 2 with slots: http://jsbin.com/fixedop/edit?html,console,output


bump dependencies to fix security issues

This was done by running the following commands:
nvm install v14
nvm use v14
yarn upgrade --latest
It drops the number of dependencies that show up from yarn audit from 57 to 26.

this should probably be ran again now after two months

@krisk I've re-bumped using yarn upgrade rather than yarn upgrade --latest because latest major updates seem to include breaking changes.

Should all be addressed as part of #711


React, JSX and refs

TypeScript Version:  3.4.0-dev.201xxxxx

Search Terms:
react, ref
Code
const genericRef = React.createRef<Element>();
const inputRef = React.createRef<HTMLInputElement>();

// throws, undesired: HTMLInputElement extends Element
<input ref={genericRef} />;
// works, desired
React.createElement("input", { ref: genericRef });
// works, desired
<input ref={inputRef} />;
// works, desired
React.createElement("input", { ref: inputRef });

// throws, undesired: same issue as #1 other motivation
const ElementComponent = React.forwardRef<Element>((_, ref) => (
  <div ref={ref} />
));

// works, desired
<ElementComponent ref={genericRef} />;
// works, desired
React.createElement(ElementComponent, { ref: genericRef });
// works, undesired: inputRef.current.value would be undefined at runtime
<ElementComponent ref={inputRef} />;
// works, undesired: see jsx example
React.createElement(ElementComponent, { ref: inputRef });

Expected behavior:

same behavior between JSX and React.createElement
undesired behavior gets fixed

Actual behavior:

different behavior with and without JSX
2 undesired errors, 1 undesired pass

Playground Link:
https://github.com/eps1lon/typescript-react-ref-issue
Related Issues:
#16019
I suppose the main issue is how react handles refs. Since react never reads the current value it's perfectly fine to pass a less specific type to the ref attribute. I'm not sure if we can express this behavior with types, it is a current limitation that should be fixed or if this is working as intended.

Yep, it's a long-standing issue in TypeScript. We were able to avoid it for the most part back when the only typesafe refs would be functions, because there is a hack we can use to get TypeScript to treat function parameters as bivariant; but there is no way to tell TypeScript that the "ref" prop actually is contravariant (hopefully I'm using the right computer science term).
I wrote about it in https://github.com/Microsoft/TypeScript/issues/10717#issuecomment-461704350 but issues about that go as far back as https://github.com/Microsoft/TypeScript/issues/1394


yticks misaligned

Thanks for your great work on this package @asinghvi17 !
I've just played with the new release and I realized the following.

begin
	MakieTeX.CURRENT_TEX_ENGINE[] = `tectonic`

	fig = Figure()
	ax = Axis(fig[1,1],
		ytickformat = x -> latexstring.(string.(x))
	)

	v = 0.05:0.1:0.95
	#v = 0.19:0.1:0.99
	scatter!(ax, v, v)

	fig
end

Relatedly, when you are unlucky, the ticks look like this (reproduce by uncommenting line 10 above)

It would be nice if the example code in the readme were more robust. Probably one can call some internal function in Makie that produces the nice strings from tick values.

Huh!  Can reproduce the issue in CairoMakie as well.
Looks like my left/right align code is off.  Will try to fix that soonish.

With some quick adjustments, the figure now looks like this.

AFAICT the labels are cut off to the left because of the Axis protrusion calculation...I'll have to look further into that to see how to avoid this.  Could be an error in the boundingbox calculation for multiple tex images.

Aha!  Found the problem - the plot coming from Axis is of type MakieCore.Text{Tuple{Vector{Tuple{AbstractString, Point{2, Float32}}}}}, while we only dispatch on Texts which contain Vectors of CachedTeX!  I fixed that and pushed a branch which should auto-close this issue when merged.
Thanks for the tests and putting up with my not seeing these error cases, @greimel!


How does fitbert handle answers that have multiple tokens?

If the answer contains multiple tokens (for example containing multiple words, or even a whole sentence), how does fitbert compute the cummulative probability of this kind of answer. Because MLM outputs the probabilities for every single tokens, not for groups of tokens.

I would use BART for this, see https://github.com/writerai/fitbert/issues/19#issuecomment-913618892


refactor(api): optimization code

Left a few in line comments. Additionally, we're using magic strings for things like 'notes' and 'categories' frequently in this file, can we create some constants for those?

In my opinion, it may not be necessary for the time being.

@all-contributors please add BlackHole1 for code.


Command line test running should be included.

There should be some info here about how to run these unit tests via the command line.  Is it done via MS Test?  vstest.console.exe?  This would help me automate these tests outside of Visual Studio.  Unfortunately, we are not using VSTS version control, and need to automate running these tests at build manually.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 90010c79-fead-60c0-61d4-1c624d4801c0
Version Independent ID: 42445083-7b63-5640-2129-a5c672f5df88
Content
Content Source

@mikeasage thanks for letting us know. We'll be moving the command line test topics over to docs.microsoft.com, but meanwhile you can reference the MSDN VSTest.Console.exe topic.


Cannot Pkg.add DataStructures under windows Julia 0.4

This is what I get when I try to install the package:
julia> Pkg.add("DataStructures")
ERROR: unsatisfiable package requirements detected: no feasible version could be found for package: WinRPM
 in error at error.jl:21
 in sync_end at task.jl:413
 [inlined code] from task.jl:422
 in add at pkg/entry.jl:46
 in add at pkg/entry.jl:73
 in anonymous at pkg/dir.jl:31
 in cd at file.jl:32
 in cd at pkg/dir.jl:31
 in add at pkg.jl:23

@2nNguyen, are you still having this problem?
Unfortunately, I don't have access to a Windows machine (and it doesn't look like anyone else following here can help).  DataStructures itself doesn't directly require WinRPM, and I can't see where that might be pulled in.
  Unpin these and try again

After that, if it still doesn't work, please try posting on the julia-users mailing list.
I'm going to close this, but feel free to post back here, and I can reopen if it is actually a DataStructures.jl problem


Razor Pages Filters

Fixes #5754
Review URL
Clean up of Filters in ASP.NET Core

@pranavkm  can you send me the code for a filter attribute?

You could use the same ResultFilter example as https://review.docs.microsoft.com/en-us/aspnet/core/mvc/controllers/filters?branch=pr-en-us-5835#built-in-filter-attributes.

@pranavkm can all the following be used with Razor Pages?
I added a sample with ResultFilterAttribute.
ActionFilterAttribute
ExceptionFilterAttribute
ResultFilterAttribute
FormatFilterAttribute
ServiceFilterAttribute
TypeFilterAttribute

It should be ready to review. I'll update the sample to  2.1.0-preview2-final when it's available.

@pranavkm  ready for review. Do all the XyzFilterAttributes I listed work with Razor Pages?

@fmaeseele please review.

@pranavkm Can you take another look. It should be ready.


Filter for duplicate numbers

Seems like the contact database might contain the same phone number multiple times.
Someone shared a screenshot of the sample app, where the contact details show the same number multiple times. The contact had WhatsApp linked to it. An other contact contained the same phone three times. That contact had both WhatsApp and Signal installed.

Whatsapp
Whatsapp + Signal

I also came across this, some of the contacts had 8-10 times the same phone number. So requird custom logic to filter it.

Can you show the screen?
WhatsApp, Viber currently returns 3 different items - calling, video calling, and chat. Isn't that an intended behavior? Should this library return only 1 number for each chat app?

@tatocaster I have updated the first post with photos. Notice the duplicate Phones you have in both photos. One Phone entry is the one the person manually added in their contacts app. The others are probably coming from the 3rd party apps.
The WhatsApp, Viber, etc work as they should, but it seems like the ContentProvider returns a duplicate of the phone number for each linked account.
I wonder how the AOSP contacts app prevents this issue.

I see now. Interesting, I had the same issue but several years ago 👀  Will take a look on that

Quick update: Ended up picking this up. (cc @tatocaster)
I went through the AOSP and it seems like they are keeping track of the accounts for each ContentValue (phones,mails, etc). Because of that they know if a phone number belongs to an account which is editable (google). Having this information, it is easy to filter out non-editable items when not-needed (i.e. the edit screen).
I am currently working on the API design to support this nicely.

This is currently where I am at.
I am considering of having an internetAccounts property on the Contact interface. So the Contact itself holds all information about the aggregated contacts (local, google, whatsapp, etc). The InternetAccount holds information about where each information belongs.
Contact {
    displayName : String
    contactId : Long
    stared :Boolean

    phones  : List<LabeledValue<PhoneNumbers>>
    mails   : List<LabeledValue<MailAddress>>
    postals : List<LabeledValue<MailAddress>>
    // other standard properties

    internetAccounts : List<InternetAccount>
}

Each InternetAccount contains information about the account, and the data contained in that account (such as phone numbers, postals, etc)
Adding and updating contacts in accounts:
contactStore.execute {
    // create a new contact into a google account
    insert {
        account = InternetAccount("com.google"<EMAIL_ADDRESS>        phone("555", Label.Main)
    }

    // how to store a new number on specific account
    update(contact.mutableCopy {
        // will be stored locally
        phones.add(LabeledValue("555-123-456", Label.Main))

        linkedAccounts.first { it.accountType == "com.google" }.apply {
            // will be stored on google account
            phones.add(LabeledValue("555", Label.Main))
        }
    })
}

The InternetAccount name is temporary. I am thinking whether there is a need for having an 'account' for information stored locally (on the device) or the SIM card.
Any feedback is more than welcome

After a lot of thought, I ended up keeping the API as is. In order to resolve the duplicate numbers, I have included information of each account in each LabeledValue (in https://github.com/alexstyl/contactstore/pull/49).
There is more work to be done for allowing storing information on specific numbers, and that will be done on a later stage.

Closing this as won't fix.
The way to prevent any duplication on the UI is by checking the new InternetAccount of each LabeledValue and decide whether they need to use the data item or not.


Timer HAL

There is no support for Timer HAL in driver section.
Can you please add support for Timer HAL in driver section.
We could see good APIs for UART and GPIO in framework-zephyr\include\drivers.
But missing the timer HALs.
There is a HAL for LP timer but we need on normal timers.
We basically need it for STM32Fxxx. ( 429 to be precise ).

https://github.com/zephyrproject-rtos/zephyr/blob/main/include/drivers/counter.h

Thank you for prompt response.
I tried using the counter example which uses RTC as clock source.
So I cannot change the resolution below 1 second.
I need timer interval in the order of few milliseconds to 100 micro seconds.
So that is not suitable. ( Please confirm )
I tried using 'timers1' but it is giving below error:
"C:/xxxxx/.platformio/packages/framework-zephyr/include/devicetree.h:303:40: error: 'DT_N_INST_0_timers1_P_label' was not declared in this scope"
The timers1 device is already define in dts file and status is marked as okay.


Experiment a4e4: 'Graph' not showing in the Autosubmit GUI

In GitLab by @vagudets on Feb 23, 2023, 16:54
Hi @jberlin
The Graph is not displaying correctly in the GUI for my experiment (a4e4, currently running). Instead, I am getting this message:
Something has gone very wrong.

'<' not supported between instances of 'int' and 'str'

Here's a screenshot:

The tree view and the rest of the features seem to be working correctly.
Thanks,
Victòria

In GitLab by @vagudets on Feb 23, 2023, 17:12
Thanks for looking into it!
It only started happening today when I started a new run of the experiment.
I migrated it from 3.14 from 3.14.b a few weeks ago, but it had already run a couple times with this version with no issues...
Victòria

In GitLab by @jberlin on Feb 23, 2023, 17:09
Hi @vagudets , thanks for reporting, tagging @dbeltran just in case, it started to happen suddenly ? did you migrate the experiment to 3.14 recently ? thanks!

In GitLab by @pabretonniere on Mar 7, 2023, 10:23
Hi @dbeltran
Just to check if there are any news here. We have a meeting on Thursday afternoon where I'd need to show the graph of this experiment. Do you know if this is "workflow related" (something of the jobs.conf) or if might be only due to some jobs status? If it is the latter, I could copy the experiment and set artificially the jobs to the status I need, I only need to be able to browse the graph to show the dependencies.
Thanks!

In GitLab by @pabretonniere on Mar 7, 2023, 13:07
Thanks! I had already (successfully) changed the status but the graph didn't show. But I'll do a copy of the experiment. I just need the graph and not to access the data in esarchive or run the jobs, the so it's fine. Thanks.
If it happens again in another experiment, I will report it here anyway.

In GitLab by @dbeltran on Mar 7, 2023, 11:24
Hello,
I think it is not related to Autosubmit or Autosubmit configuration,
I copied a5b4 without issues. You can see it at a5qw https://earth.bsc.es/autosubmitapp/experiment/a5qw
And also, I copied a4e4. I had the same issue as the original experiment in this one.. but now it works fine. (a5qx) (https://earth.bsc.es/autosubmitapp/experiment/a5qx)
"""I solved the issue""" by commenting all the jobs and then uncommenting them one per one ( doing an autosubmit create + autosubmit run each time I uncommented one)
My idea was to find the culprit of the error, but now I have all the jobs uncommented, and the visualization works. So I don't know what the issue is.
In any case, @pabretonniere , you can try to copy the experiment. And set the project to use dummy templates
[project]
# Select project type. STRING = git, svn, local, none
# If PROJECT_TYPE is set to none, Autosubmit self-contained dummy templates will be used
PROJECT_TYPE = none

I had no issues with you experiment a5b4 so maybe a setstatus is enough

In GitLab by @vagudets on Mar 10, 2023, 10:45
Hi @jberlin,
I did a setstatus on a job, but it didn't solve the problem. autosubmit create and running it again didn't seem to change anything either.
Victòria

In GitLab by @vagudets on Mar 10, 2023, 10:50
Thanks @dbeltran, I'll try and let you know.

In GitLab by @pabretonniere on Mar 7, 2023, 13:08
PS: you can delete a5qw if you want ;)

In GitLab by @dbeltran on Mar 10, 2023, 10:49
Maybe if you:
comment on all jobs.conf
perform autosubmit create
uncomment all jobs.conf
perform the autosubmit create

may clean/reset the tables and fix it , at least it worked when I did a copy of your expid , although I uncommented them one per one

In GitLab by @jberlin on Mar 8, 2023, 21:13
Hi @dbeltran , so refreshing the job database (by either re-creating or via set status) solved the problem with the graph view for these experiments ?
I checked the graph table, for both experiments a4e4 and the copy (a5qx)
(base) bscearth357 /esarchive/autosubmit/as_metadata/graph  > sqlite3 graph_data_a4e4.db
SQLite version 3.38.2 2022-03-26 13:51:10
Enter ".help" for usage hints.
sqlite> SELECT * FROM experiment_graph_draw;
1|a4e4_20230216_fc0_1_decathlon_data|150|-292
2|a4e4_20230216_fc0_2_decathlon_data|472|-292
3|a4e4_20230216_fc0_3_decathlon_data|794|-292
4|a4e4_20230216_fc0_4_decathlon_data|1118|-292
5|a4e4_20230216_fc0_5_decathlon_data|1443|-292
6|a4e4_20230216_fc0_6_decathlon_data|1767|-292
7|a4e4_20230216_fc0_7_decathlon_data|2091|-292
8|a4e4_20230216_fc0_8_decathlon_data|2413|-292
9|a4e4_20230216_fc0_9_decathlon_data|2737|-292
10|a4e4_20230216_fc0_1_vitigeoss_preproc|3069|-292
11|a4e4_20230216_fc0_1_vitigeoss_data|3095|-202
12|a4e4_20230216_vitigeoss_transfer|4438|-112
13|a4e4_20230216_vitigeoss_check|4438|-22
14|a4e4_20230216_fc0_2_vitigeoss_preproc|3411|-292
15|a4e4_20230216_fc0_2_vitigeoss_data|3423|-202
16|a4e4_20230216_fc0_3_vitigeoss_preproc|3752|-292
17|a4e4_20230216_fc0_3_vitigeoss_data|3764|-202
18|a4e4_20230216_fc0_4_vitigeoss_preproc|4095|-292
19|a4e4_20230216_fc0_4_vitigeoss_data|4107|-202
20|a4e4_20230216_fc0_5_vitigeoss_preproc|4438|-292
21|a4e4_20230216_fc0_5_vitigeoss_data|4438|-202
22|a4e4_20230216_fc0_6_vitigeoss_preproc|4781|-292
23|a4e4_20230216_fc0_6_vitigeoss_data|4762|-202
24|a4e4_20230216_fc0_7_vitigeoss_preproc|5123|-292
25|a4e4_20230216_fc0_7_vitigeoss_data|5092|-202
26|a4e4_20230216_fc0_8_vitigeoss_preproc|5464|-292
27|a4e4_20230216_fc0_8_vitigeoss_data|5433|-202
28|a4e4_20230216_fc0_9_vitigeoss_preproc|5807|-292
29|a4e4_20230216_fc0_9_vitigeoss_data|5801|-202
sqlite>

for a5qx
/esarchive/autosubmit/as_metadata/graph  > sqlite3 graph_data_a5qx.db
SQLite version 3.38.2 2022-03-26 13:51:10
Enter ".help" for usage hints.
sqlite> SELECT * FROM experiment_graph_draw;
sqlite>

it may be related to the parsing of the table, if I am not wrong, after generating the graph, it is store in the mentioned table above to save time on calculations. I will try to check further in the upcoming days. @vagudets can you check if updating any job in your experiment solves the problem ? thanks

In GitLab by @pabretonniere on Feb 28, 2023, 19:07
Tagging myself here to follow the outcome of this issue as I have the same problem with a5b4. Thanks

In GitLab by @jberlin on Apr 3, 2023, 12:10
I will have a look in the logs in production to  check if I see soemthing

In GitLab by @jberlin on Apr 4, 2023, 17:21
I think I fixed the issue in DEV, @vagudets
when you have some time, can you check if the graph is displayed correctly:
https://bscesautosubmitdev01.bsc.es/autosubmitapp/experiment/a4e4/graph

then if it is correct, I will upload the patch to production

In GitLab by @vagudets on Mar 10, 2023, 10:56
Still nothing, unfortunately...

In GitLab by @mcastril on Apr 3, 2023, 11:40
This experiment has the same issue
https://earth.bsc.es/autosubmitapp/experiment/a5jp

In GitLab by @jberlin on Apr 5, 2023, 13:12
Fixed also the problem with the treeview with the a5jp in Dev,
https://bscesautosubmitdev01.bsc.es/autosubmitapp/experiment/a5jp/tree

I will put in Dev the other experiments that were reported having issues to check how these behave, if these are OK after Easters we can prepare a patch

In GitLab by @mcastril on Mar 22, 2023, 16:57

I will try to check further in the upcoming days. @vagudets can you check if updating any job in your experiment solves the problem ? thanks

Assigning it to @jberlin as for any reason it didn't have any assignee

In GitLab by @jberlin on Apr 4, 2023, 15:55
copìed the experiment to dev environment to start debugging and get an idea of the issue:
https://bscesautosubmitdev01.bsc.es/autosubmitapp/experiment/a4e4/graph

In GitLab by @jberlin on Apr 4, 2023, 18:07
There still errors in the treview generation, these are in the get_tree_structured function, most likely we have the same issues as the graph

In GitLab by @jberlin on Apr 6, 2023, 16:39
We moved the issue to the API (#21), lets continue over there

In GitLab by @jberlin on Apr 6, 2023, 15:29
Hi @vagudets , we moved the isse to API project #21
did you check in production ? because my comment was to check in development environment , because in production the patch is not applied yet.
https://bscesautosubmitdev01.bsc.es/autosubmitapp/experiment/a4e4/graph

In GitLab by @jberlin on Apr 6, 2023, 09:59
moved to autosubmit_api#21

In GitLab by @mcastril on Apr 5, 2023, 18:04
Perfect @jberlin, and thanks for the insights.
Could you make the commits appear in the issue? I think it's enough if you put the issue # in the commit message. But you can also paste the commits here.

In GitLab by @jberlin on Apr 6, 2023, 09:58
Hki @mcastril , the problem is tha the changes were made in the API side, I will move the issue there

In GitLab by @vagudets on Apr 6, 2023, 15:35
Ah, sorry! My bad.
In your screenshot and in that link, the graph is not quite correct; it seems like many of the jobs are duplicated. I see this sometimes when running a new instance of the experiment and it goes away after refreshing.

In GitLab by @vagudets on Apr 6, 2023, 15:25
Hi @jberlin
I just checked and the graph is still not displayed, now I get a different error message:
Something has gone very wrong.

a bytes-like object is required, not 'str'

Victòria


Part 3: Replace references to ml5 0.4.3 library version with @latest

This is the first part of a 3 step process to switch the examples from using a specific library version numbers:

1/3: Update ml5 reference script to use @latest (into development branch)
2/3: Merge changes from development to release
3/3: Replace references to ml5 0.4.3 library version with @latest

If we keep this repo (see discussion), maybe we can think of a better way to coordinate changes to the release and development branch!
Context
Approach:

Replace all references to the specific ml5 version on imports in the ml5-examples and ml5-boilerplate library with @latest. Delete scripts for updating version numbers in the files.

Pros:

Simplest approach for handling the ml5-example repo and ml5-boilerplate repo while also allowing them to remain separate. Overall, this is probably the least disruptive change to the current workflow.

Cons:

May cause some confusion about which version of the library is being used
If you make a sketch that specifies @latest and then come back to it a year or so later, it’s possible that there could have been breaking changes to the library that would break the script.

Merging this in now! Many thanks!

I forgot to check to see how different the development and release branches, so Part 2 of this series will happen when the development branch gets merged into the release branch (presumably during the next time that the core library is released). The risk is that someone runs the update-ml5-references script on the release branch and it switches everything back to 0.4.3, but that seems unlikely since the release branch is seemingly handled in a special way.
I think we should be good to go on this series!

Perfecto! 🙌


Partial Success with Status Details

We are writing log entries to Logging API using the write_entry_log_entries method, and we enabled partial_success.
When a request has a mix of failed and successful entries, it raised a Google::Apis::ClientError error. However, we can't find a way to get the status details to locate which entries are the failing ones.
To clarify it a bit, we are looking for something equivalent to the WriteLogEntriesPartialErrors mentioned in the documention of partialSuccess here.
Is this not supported yet?

You should be able to get the full response body from the error -- the error has a body property that will be the raw body (as a string). You'll need to parse it yourself, but should be able to get the details you need from that.

@sqrrrl Thanks for taking a look!
We recently fixed an issue for GCP instances. Previously when I tried on GCP, there is nothing in the error body. Now I'm able to extract some info as you recommended above. Yet I'm still having issues parsing the error body (Not necessarily due to this Ruby client lib. Could be the upper stream Logging API).
Basically the error body I got from the Ruby clients (both this one and the grpc one) has weird format (I added some new lines to make it readable)
{
	"error": {
		"code": 400,
		"message": "Resource type cannot be empty",
		"errors": [
			{
				"message": "Resource type cannot be empty",
				"domain": "global",
				"reason": "badRequest",
				"debugInfo": "
					detail: \\"[ORIGINAL ERROR] generic::invalid_argument: Resource type cannot be empty [google.rpc.error_details_ext] {
					message: \\\\\\"Resource type cannot be empty\\\\\\"
					details {
						type_url: \\\\\\"type.googleapis.com/google.logging.v2.WriteLogEntriesPartialErrors\\\\\\"
						value: \\\\\\"\\\\\\\%\\\\\\\\010\\\\\\\\000\\\\\\\\022!\\\\\\\\010\\\\\\\\003\\\\\\\\022\\\\\\\\035Resource type cannot be empty\\\\\\\%\\\\\\\\010\\\\\\\\001\\\\\\\\022!\\\\\\\\010\\\\\\\\003\\\\\\\\022\\\\\\\\035Resource type cannot be empty\\\\\\\%\\\\\\\\010\\\\\\\\002\\\\\\\\022!\\\\\\\\010\\\\\\\\003\\\\\\\\022\\\\\\\\035Resource type cannot be empty\\\\\\"
					}
				}\\"\"
			}
		],
		"status": "INVALID_ARGUMENT"
	}
}

However when I call the Logging API directly, I got:
{
  "error": {
    "code": 400,
    "message": "Illegal character ':' in log name",
    "status": "INVALID_ARGUMENT",
    "details": [
      {
        "@type": "type.googleapis.com/google.logging.v2.WriteLogEntriesPartialErrors",
        "logEntryErrors": {
          "0": {
            "code": 3,
            "message": "Illegal character ':' in log name"
          },
          "1": {
            "code": 7,
            "message": "User not authorized."
          }
        }
      },
      {
        "@type": "type.googleapis.com/google.rpc.DebugInfo",
        "detail": "[ORIGINAL ERROR] generic::invalid_argument: Illegal character ':' in log name [google.rpc.error_details_ext] {
message: \"Illegal character \\':\\' in log name\" details {
type_url: \"type.googleapis.com/google.logging.v2.WriteLogEntriesPartialErrors\"
value: \"\\n)\\010\\000\\022%\\010\\003\\022!Illegal character \\':\\' in log name\\n
\\034\\010\\001\\022\\030\\010\\007\\022\\024User not authorized.\" } }"
      }
    ]
  }
}

Note that "type.googleapis.com/google.logging.v2.WriteLogEntriesPartialErrors" seems to be what we want, And I would be fine with "type.googleapis.com/google.rpc.DebugInfo" if I could successfully parse out the indexes (right now it seems kind of messed up).
I'm still working with the Logging API team to try to figure out what the expected behavior and fix should be.
My hunch is we either somehow fix "type.googleapis.com/google.rpc.DebugInfo" or use "type.googleapis.com/google.logging.v2.WriteLogEntriesPartialErrors" instead if possible.
Will keep you updated.

Hi @sqrrrl, after some investigation with Logging API team it turned out that I got weird error format like
    details {
        type_url: \\\\\\"type.googleapis.com/google.logging.v2.WriteLogEntriesPartialErrors\\\\\\"
	value: \\\\\\"\\\\\\\%\\\\\\\\010\\\\\\\\000\\\\\\\\022!\\\\\\\\010\\\\\\\\003\\\\\\\\022\\\\\\\\035Resource type cannot be empty\\\\\\\%\\\\\\\\010\\\\\\\\001\\\\\\\\022!\\\\\\\\010\\\\\\\\003\\\\\\\\022\\\\\\\\035Resource type cannot be empty\\\\\\\%\\\\\\\\010\\\\\\\\002\\\\\\\\022!\\\\\\\\010\\\\\\\\003\\\\\\\\022\\\\\\\\035Resource type cannot be empty\\\\\\"
    }

because this is the V1 format. The V2 format would have the error details in well-formed json:
      {
        "@type": "type.googleapis.com/google.logging.v2.WriteLogEntriesPartialErrors",
        "logEntryErrors": {
          "0": {
            "code": 3,
            "message": "Illegal character ':' in log name"
          },
          "1": {
            "code": 7,
            "message": "User not authorized."
          }
        }
      },

To force v2 format, the client should use either the query param: $apiFormat=2 or the header: X-GOOG-API-FORMAT-VERSION: 2. Can we force this client to use V2 format?

Can't force it without breaking existing clients. Can make it opt-in though if you need it.
I had wanted to move to v2 a while back, but there were a few problems:

Older APIs only support v1. Asking for v2 still gives v1 formats.
There's no signal from the API definitions that a given API supports V2
There's nothing in the response that indicates which format an error is. Have to infer from the content.
Doing so is fragile -- if, for example, the older backends started supporting v2 errors it would manifest as a visible breaking changing in the client since it was asking for v2 by default.

Safest thing was to just force v1 for everything.
LMK if you need it and I'll see about adding an opt-in approach + parsing the errors correctly.

Opt-in sounds good to me. The v1 format makes it impossible to extract the index of the failing entries, which is important to make partial success very useful. Can we default to v1 as is and support v2 as opt-in?

Hi, any news on this one?

Verified the fix with google-api-client (0.11.3). Closing this issue. Thanks Steve!
$ cat partial_error_non_grpc.rb
require 'google/apis/logging_v2'
require 'googleauth'

client = Google::Apis::LoggingV2::LoggingService.new
client.authorization = Google::Auth.get_application_default(
  'https://www.googleapis.com/auth/logging.write')

resource = Google::Apis::LoggingV2::MonitoredResource.new(
  type: 'gce_instance',
  labels: {}
)

entries = [
  Google::Apis::LoggingV2::LogEntry.new(
    {
      resource: resource,
      log_name: 'projects/gapic-test/logs/my-log',
      text_payload: 'pass'
    }
  ),
  Google::Apis::LoggingV2::LogEntry.new(
    {
      resource: resource,
      log_name: 'projects/gapic-test/logs/bad:log',
      text_payload: 'fail'
    }
  )
]

write_request = \
  Google::Apis::LoggingV2::WriteLogEntriesRequest.new(
    log_name: 'projects/gapic-test/logs/my-log',
    resource: resource,
    labels: {},
    partial_success: true,
    entries: entries)

begin
  client.write_entry_log_entries(
    write_request,
    options: {
      api_format_version: '2'
    }
  )
rescue => error
  puts "error:\n#{error.inspect}\n"
  puts "error body =\n#{error.body}\n"
end

$ ruby partial_error_non_grpc.rb
error:
#<Google::Apis::ClientError: PERMISSION_DENIED: User not authorized.>
error body =
{
  "error": {
    "code": 403,
    "message": "User not authorized.",
    "status": "PERMISSION_DENIED",
    "details": [
      {
        "@type": "type.googleapis.com/google.logging.v2.WriteLogEntriesPartialErrors",
        "logEntryErrors": {
          "0": {
            "code": 7,
            "message": "User not authorized."
          },
          "1": {
            "code": 3,
            "message": "Log name contains illegal character :"
          }
        }
      },
      {
        "@type": "type.googleapis.com/google.rpc.DebugInfo",
        "detail": "[ORIGINAL ERROR] generic::permission_denied: User not authorized. [google.rpc.error_details_ext] { message: \"User not authorized.\" details { type_url: \"type.googleapis.com/google.logging.v2.WriteLogEntriesPartialErrors\" value: \"\\n\\034\\010\\000\\022\\030\\010\\007\\022\\024User not authorized.\\n-\\010\\001\\022)\\010\\003\\022%Log name contains illegal character :\" } }"
      }
    ]
  }
}

$ gem list | grep google-api-client
google-api-client (0.11.3)


How to reload the Nerdtree SVN status icon?

How to reload the Nerdtree SVN status icon?
The Nerdtree Svn status icon always disappear and how to load it again?

Sorry @agentxpt, i just saw this issue. What platform and version of vim are you using? Is there anything else you can tell me about when the status icons disappear? Is it when you have a large number of changes staged, does it happen after x amount of time, etc.
Does refreshing the filesystem mapping from NERDTree (r or R) bring the status icons back?

I'm going to close this issue; if it's still an issue please reach out to me.


Interop interfaces are all pass-by-ref for IID param

fixes #885
fixed interop IDL, and decided to just keep the TestHWND I created earlier (when I thought it was an HWND marshaling issue)
Note that:
for 64-bit calling convention, a 128-bit value ends up being passed by address, so we get lucky
for 32-bit calling convention, a 128-bit value is passed directly on the stack, so we get corruption when the callee attempts to interpret the first 4 bytes of that GUID as a pointer to one.

Is there any impact to the Windows SDK projection public API surface / assembly version from this change?  I see all the types that were modified had ProjectionInternal, but want to confirm there is indeed no impact.

The binlog shows only Windows SDK and Project Reunion winmds as input, but no ReactNative winmds, which explains the output.

Is there any impact to the Windows SDK projection public API surface / assembly version from this change? I see all the types that were modified had ProjectionInternal, but want to confirm there is indeed no impact.

There shouldn't be any impact - the interop IDL is used solely to generate projection sources for the Windows SDK


Please add MERRA-2

CC @Guo-Badger
What is the data?
MERRA-2 is the Modern-Era Retrospective analysis for Research and Applications, Version 2
What is the data format (OpenDap, VRT, TIF)
OpenDap via NASA EarthData
What is the data URL:
https://disc.gsfc.nasa.gov/datasets?project=MERRA-2
The priority is hourly land surface forcings: https://disc.gsfc.nasa.gov/datasets/M2T1NXLFO_5.12.4/summary

Hi Mike,
This tag means you are working on it and it is not ready yet. Is it correct?

Correct! We have the data cataloged, just need to merge it here

added in nonR6 form

Hi Mike, I am not farmilar with this tool and have no clue what does "added in non R6 form" mean. Will you be able to provide me an example or direct me to the right place?

Yep! Your request came at a tricky time since we are transitioning the entire catalog to a new design. All this means is that I created the merra catalog using the old technique and @program— will translate it to the R6 method.
Once that’s done we can provide a nice example for you. Typically adding a new product is very easy. The timing was just off this go around.
On Jul 14, 2023 at 2:50 PM -0600, Guo Yu @.***>, wrote:

Hi Mike, I am not farmilar with this tool and have no clue what does "added in non R6 form" mean. Will you be able to provide me an example or direct me to the right place?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: @.***>

--
CONFIDENTIALITY NOTICE: This email message, including any attachment(s), is
intended only for the named recipient(s) and contains confidential,
proprietary or legally privileged information. Unauthorized individuals or
entities are not permitted access to this information. Any dissemination,
distribution, disclosure, or copying of this information is unauthorized
and strictly prohibited. If you have received this message in error, please
advise the sender by reply email, and delete this message and any
attachments.

Got you. I am looking forward to the updated version! I did some research recently and found that OpenDAP is a brillant idea. I notice there is a python package Pydap can also do a similar job.

Yep! It’s a super cool technology! What climateR and climatePy do for you is build, send and structure the queries. It also provides access to other data forms like tifs, vrts, and hdf files on different server types
On Jul 14, 2023 at 3:08 PM -0600, Guo Yu @.***>, wrote:

Got you. I am looking forward to the updated version! I did some research recently and found that OpenDAP is a brillant idea. I notice there is a python package Pydap can also do a similar job.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: @.***>

--
CONFIDENTIALITY NOTICE: This email message, including any attachment(s), is
intended only for the named recipient(s) and contains confidential,
proprietary or legally privileged information. Unauthorized individuals or
entities are not permitted access to this information. Any dissemination,
distribution, disclosure, or copying of this information is unauthorized
and strictly prohibited. If you have received this message in error, please
advise the sender by reply email, and delete this message and any
attachments.

Merra2 is in the most recent catalog release. All dap  tools should work! We’ll have a sortcut added soon as well.
Thanks!
Mike Johnson, PhD
Water Resource Data Scientist
Hydrofabric Technical Director, NOAA Office of Water Prediction
www.Lynker.com
Metro DC • Boulder • Honolulu • Tuscaloosa • Seattle • Charleston • Wellington NZ
An Employee-Owned Company
On Aug 2, 2023 at 9:22 AM -0700, Guo Yu @.***>, wrote:

Hi Mike, I wonder do you have any updates on this? Thanks.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: @.***>

--
CONFIDENTIALITY NOTICE: This email message, including any attachment(s), is
intended only for the named recipient(s) and contains confidential,
proprietary or legally privileged information. Unauthorized individuals or
entities are not permitted access to this information. Any dissemination,
distribution, disclosure, or copying of this information is unauthorized
and strictly prohibited. If you have received this message in error, please
advise the sender by reply email, and delete this message and any
attachments.

Sounds great. Is there any tutorial that I can follow to give a try?

Hi Mike, can you send me an example to follow for using this tool? This tool seems new to me. Thanks.


kmod-nvidia-535.54.03-5.14.0-284.18.1-535.86.10-1.el9_2.x86_64.rpm is missing

From repo :
http://developer.download.nvidia.com/compute/cuda/repos/rhel9/x86_64/
Latest kmod available is
kmod-nvidia-535.54.03-5.14.0-284.18.1-535.54.03-3.el9_2.x86_64.rpm
It seems we are missing :
kmod-nvidia-535.54.03-5.14.0-284.18.1-535.86.10-1.el9_2.x86_64.rpm
yum update cannot upgrade to 535

Okay @alphacc this has been resolved now for driver 535.86.10 available for the latest RHEL9 kernel 5.14.0-284.25.1
https://developer.download.nvidia.com/compute/cuda/repos/rhel9/x86_64/precompiled


Error restoring: TFModel/ocrnet

Hi,
The function restore model always throw the error even if the model is stored:
In [18]: cnnc = ANNC(IS, ws, batchSize = 64, learnRate = 5e-5, maxIter = 55, reg = 1e-5, tol = 1e-2, verbose = True)
cnnc.RestoreModel('TFModel/', 'ocrnet')
Will always give result : INFO:tensorflow:Restoring parameters from TFModel/ocrnet
Error restoring: TFModel/ocrnet
Out[18]: False

Hi,
In your code for SetBias and SetWeightMatrix you have written a warning does not work with restored model.
def SetBias(self, i, _B):
'''
Warning! Does not work with restored models currently.
Sets the i-th bias from the model.
'''
self.B[i].assign(_B).eval(session = self.GetSes())
def SetWeightMatrix(self, i, _W):
'''
Warning! Does not work with restored models currently.
Sets the i-th weight matrix from the model.
'''
self.W[i].assign(_W).eval(session = self.GetSes())
Can you tell how to make it work with the restored models?