Add support for TFTP related DHCP option

Adds support for 3 TFTP related options (TFTServerName, TFTPServerAdress, and BootfileName) which can be used to boot devices from the network.
The capitalization of BootfileName follows the RFC and IANA spelling, it is different from the existing BootFileSize but that is consistent with the spec 😅

This might be pedantic but, do we know the server name and bootfile name are able to be utf-8 encoded?

According to https://www.rfc-editor.org/rfc/rfc2131 and https://www.rfc-editor.org/rfc/rfc951 sname and file are null-terminated strings. The encoding is not given, but (NVT) ASCII seems logical to assume given the age and other references to it.
I think it's safe to assume those fields and these options should be valid utf-8 (though not every utf-8 string is a valid option), the octets are also indicated as c1,c2,c3,..,cn suggesting that they're meant to be interpreted as characters but I'll agree the spec is not very clear.

For reference, here is the issue that caused the change to begin with: https://github.com/bluecatengineering/dhcproto/issues/3 do you have any additional thoughts?

I think bstr might be the right call as

[this crate enables] their use as byte strings, where byte strings are conventionally UTF-8.

likely matches reality, whatever the standard-as-written says. Writing utf-8 will always be valid (utf-8 can't have interior null-bytes), but the full encoding seems undefined aside from fname/sname having to be a "null terminated string".

OK, as long as no traits need to be put in the public API, I think BString makes sense

Hi, happy new year :)
I had another look at this and I think the issue of unclear encodings goes beyond just these couple of TFTP-related options. Take for example Host name option 12, for which the rfc says

See RFC 1035 for character set restrictions.

Which in turn mentions a preferred format

Although labels can contain any 8 bit values in octets that make up a label, it is strongly recommended that labels follow the preferred syntax described elsewhere in this memo

This might need to be a BString too as String could be to restrictive.
On the other hand MeritDumpFile, RootPath,  NISDomain, Message, take a String to but this is too permissive as the RFC says these use NVT ASCII.
NetBiosScope I'm not quite sure what the format should be.

I don't might changing the Strings to BString (I did so just now), but it might make sense to merge this PR as is and punt the resolution of the types to another PR or Issue to make sure they are kept consistent?

Hey! If we're to be consistent, from my reading of the RFC opt 66/67 contain the data from sname and fname.

This option is used to identify a TFTP server when the 'sname' field
in the DHCP header has been used for DHCP options.

Right now those fields are Vec<u8>, so maybe we should just stick with that for now? I think BString is a fine choice also although I do prefer std types where possible.
In general, I think being more permissive than is strictly necessary is okay, I'd rather err of the side of the parser not blowing up. When we know the contents are ASCII (as in Message), I was thinking we would just use String, unless there is something to be gained by using a different type there?
Which reminds me, we also don't handle 'option overload'.  If set, the sname and fname could contain option data, the part that's usually added in the variable length section at the end of the packet. I don't think option overload is used much these days, but it is another condition that we don't cover.
Sorry, lot of words to discuss encodings! Thanks for following up on this.

Hey! If we're to be consistent, from my reading of the RFC opt 66/67 contain the data from sname and fname.

That makes sense looking at the quote you gave though as a side-note, the maximum length of field 66/67 is 256 characters and must not be null-terminated, whereas sname must be a null-terminated string of at most 64 characters (including null).

This option is used to identify a TFTP server when the 'sname' field
in the DHCP header has been used for DHCP options.

I'm not quite sure how to interpret this line from the RFC, but I know there are embedded devices (raspberry pis for example) that will accept passing the tftp-server in Option 66, but will not accept passing it in sname. So in practice I think it makes sense to consider them as two different settings.

In general, I think being more permissive than is strictly necessary is okay, I'd rather err of the side of the parser not blowing up. When we know the contents are ASCII (as in Message), I was thinking we would just use String, unless there is something to be gained by using a different type there?

For accepting messages from other devices, yes definitely. Not all devices will follow the letter of the RFC unfortunately.
For sending I think it's less straightforward to say what is or isn't acceptable. If the RFC says that an option should be ASCII, and you accept a String in the constructor, you could create an invalid value by passing "🦀".to_string(). But then, maybe you want to be able to do that?

I'll convert this field to be a Vec<u8> instead of a String for maximum flexibility for now.

For accepting messages from other devices, yes definitely. Not all devices will follow the letter of the RFC unfortunately.
For sending I think it's less straightforward to say what is or isn't acceptable. If the RFC says that an option should be ASCII, and you accept a String in the constructor, you could create an invalid value by passing "🦀".to_string(). But then, maybe you want to be able to do that?

Good point, I was thinking of decoding not encoding. I will make an issue to address the ASCII types. Thank you for following up again, if you switch to Vec<u8> for the new types in this PR I will merge.

if you switch to Vec for the new types in this PR I will merge.

done! :)

My interpretation was that it relates to when option overload is used, in this case the sname field contains DhcpOptions and the TFTP server option will house the value that was in sname?

I read it as "sname will hold the server-name of the tftp-server, unless option Overload is used, in which case Option 66 can be used to store the server-named".
In the old BOOTP protocol, sname and fname full-filled similar purposes to TFTP so I think that makes sense.  See also RFC  5859 which says

There are two commonly accepted methods to discover this
server via DHCP; the "sname" field in the DHCP header [[RFC2131](] and
the "TFTP Server Name" option (66) [RFC2132].  Both of these sources of information, however, contain the TFTP server's hostname.  That
hostname must then be translated to an IP address.  The usual method
to accomplish this would be DNS [RFC1034].

TFTP is often used to bootstrap embedded devices, with the firmware responsible for handling the protocol and, unfortunately,  that likely means there are a lot of quirks and deviations from the standard in the real-world.
I've noticed however that some devices will only accept option 66 and will not look at sname.


Add more validations for Playbooks

Add more validations for Playbooks:

All parameters in the ARM template should have a user-friendly description to explain the parameter value's usage and format
All API connection resources deployed in the template should have their resource name and display name as values taken from variables to allow them to be computed from the playbook name + those variables should exist in the template. Validation on the value of the API connection variables (that they reference the playbook name parameter + the resource name variable references the API connection type) will be added in a separate PR to keep this one short and focused

@lior-tamir - please help review this PR / playbook validations. Thanks.


Register server classes to fix GDNative binding issues

Due to ClassDB not containing information about the server specific classes
the JSON API file didn't contain those either which caused the GDNative
binding tools to not recognize objects of such classes.
This is needed to fix https://github.com/GodotNativeTools/godot-cpp/issues/175.

Don't merge this. I'll review in an hour.

We do not want to expose these classes to the scripting API. The same way we don't expose OS_Unix.
IINW, the issue with godot-cpp#175 is the same I had some time ago with C#, which I fixed doing the following: https://github.com/godotengine/godot/blob/b0da7b66ce278179eedd0e21dae1d84ed3f4459d/modules/mono/csharp_script.cpp#L1126-L1130
Not sure how that could be applied to NativeScript.
Maybe we could have a way to register private classes in ClassDB.
Or even better, perhaps this is already fixable from bindings generators. Just make an additional check, if the class is not exposed but it derives an exposed class, generate it (in C# such a class would be generated as internal).

Not sure what's the ground for not wanting to expose them, after all they are nothing but implementations of an already exposed interface.
In the end it's your call, I just intended to contribute back the fix I did on my fork, considering that apparently other people ran into the same issue.
Feel free to close the PR if you don't want to take this fix.

First of all, I'm not talking for all contributors, as it can be seen in the two other contributors who approved this PR.
One reason I don't like this is because all the reason to expose these classes is to fix the crash. There is no other point for these classes to be exposed, and the user is not meant to use them directly. This wouldn't be too much of a problem is we could somehow mark these classes so the C# bindings generator, for example, could generate them as internal.
The other reason, and the most important, is the case of IP_Unix (I said OS_Unix by mistake in the other comment). If I understand the GodotNativeTools/godot-cpp#175 issue correctly, the same crash should be reproducible when trying to access any IP instance on a unix platform (Engine::get_singleton()->get_singleton_object("IP")).
If that's the case, we cannot just apply the same fix and expose IP_Unix, because that would make the ClassDB API non-portable as IP_Unix only exists on unix platforms.

It could be interesting if we would allow godot to support different features depending on the implementation chosen. Taking the physics as example we could have additional APIs depending on the physics engine, (For example the kinematic APIs that get rejected https://github.com/godotengine/godot/pull/21838), opening a lot of new possibilities.
On the other hand, the down side is that it could mean start to break the base Godot architecture, since in this moment everything is unified.
To say a rough opinion, in this moment, I'm at 51% on reject this PR, because I can always implement it elsewhere...

One reason I don't like this is because all the reason to expose these classes is to fix the crash.

That's an oversimplification. In practice what happens is that simply the binding is not aware of the object's type (as the inheritance relationship is unknown to it as it's not present in the API json), which then causes the crash.

The other reason, and the most important, is the case of IP_Unix (I said OS_Unix by mistake in the other comment). If I understand the GodotNativeTools/godot-cpp#175 issue correctly, the same crash should be reproducible when trying to access any IP instance on a unix platform (something like godot::Engine::get_singleton_object("IP") or maybe just godot::IP from godot-cpp).

I didn't look into that one, but if it's the same principle where there is an OS-specific subclass implementing a common interface, then I'm afraid the issue is the same.
Really, there are two options as I see it:

Either register the implementation classes of the interfaces with the ClassDB too, so that the API json has information about them and thus bindings can understand what they are (possibly even if an actual implementation won't exist on any given platform),
Or change the way how GDNative works on the engine side so that it treats the implementation classes as if they were identical to the parent interface class

IMO the API json itself should contain all interfaces though, even if some of the implementation classes only ever going to exist on a subset of the platforms/configurations.
Again, it's up to you how you go about, as far as I'm concerned I have a working solution for the problem I encountered, so I won't have hard feelings about you closing the PR :)

IMO the API json itself should contain all interfaces though, even if some of the implementation classes only ever going to exist on a subset of the platforms/configurations.

This will not happen. The ClassDB API has to be the same on all platforms and for all targets (debug/release).
Maybe we could use the pimpl idiom to solve the IP_Unix issue, or something like what is done with the OS class (which is basically the same as pimpl).

The thing is this PR is missing more types that are not exposed. This is the full list:
BulletPhysicsDirectBodyState, BulletPhysicsServer, GDNativeLibraryResourceLoader, GDNativeLibraryResourceSaver, GDScriptNativeClass, IP_Unix, InputDefault, Physics2DDirectBodyStateSW, Physics2DServerSW, ResourceFormatDDS, ResourceFormatImporter, ResourceFormatLoaderBMFont, ResourceFormatLoaderBinary, ResourceFormatLoaderCSharpScript, ResourceFormatLoaderDynamicFont, ResourceFormatLoaderGDScript, ResourceFormatLoaderImage, ResourceFormatLoaderNativeScript, ResourceFormatLoaderShader, ResourceFormatLoaderStreamTexture, ResourceFormatLoaderText, ResourceFormatLoaderTextureLayered, ResourceFormatLoaderTheora, ResourceFormatLoaderVideoStreamGDNative, ResourceFormatLoaderWebm, ResourceFormatPKM, ResourceFormatPVR, ResourceFormatSaverBinary, ResourceFormatSaverCSharpScript, ResourceFormatSaverGDScript, ResourceFormatSaverNativeScript, ResourceFormatSaverShader, ResourceFormatSaverText, ResourceImporter, ResourceImporterOGGVorbis, ResourceSaverPNG, TranslationLoaderPO

An instance of any of those types that is returned to script code (be it C#, godot-cpp, etc) is vulnerable to the GodotNativeTools/godot-cpp#175 issue. Applying this fix to all of these types completely eliminates the point of the exposed, as everything is now exposed.
I think the better fix is to register the classes but still mark them as not exposed.

IMO the API json itself should contain all interfaces though, even if some of the implementation classes only ever going to exist on a subset of the platforms/configurations.

This will not happen. The ClassDB API has to be the same on all platforms and for all targets (debug/release).

I didn't say otherwise, in fact we're in agreement. I just suggested that if we do have these "platform-optional" classes, those should be registered even if they aren't actually available on any particular platform, unless you use the pimpl idiom as you suggested. FWIW, I guess the ARVR classes are another example where the interface class itself is exposed, but there may not be actual implementations for them on all platforms.

In a sense i don't think it's wrong to expose something like bulletphysicsserver if it's exposing extra features over the regular one (they need to be registered as virtual, though).
The problem is that servers are wrapped into the multithread wrapper, so you don't really have access to them anyway. Maybe a different approach should be taken if we understand the actual use case.

I'm still not sure what to do with this PR. I share @neikeq's concern over registering implementation classes which are not meant to user-facing, such as OS or library-specific implementations.
I'm not sure how to fix the GDNative issue otherwise, but I feel this is not the right approach.
BTW, I tried it locally to see if it would add the newly registered classes to the class reference, and doctool segfaults with these changes:
$ godot-git --doctool .
Godot Engine v3.2.alpha.custom_build.c52287208 - https://godotengine.org
git statusFound discrete GPU, setting DRI_PRIME=1 to use it.
Note: Set DRI_PRIME=0 in the environment to disable Godot from using the discrete GPU.
OpenGL ES 3.0 Renderer: AMD VEGAM (DRM 3.32.0, 5.2.16-desktop-2.mga7, LLVM 8.0.0)

handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /lib64/libc.so.6(+0x3caf0) [0x7f7373212af0] (??:0)
[2] BulletPhysicsDirectBodyState::get_inverse_mass() const (/home/akien/Projects/godot/godot.git/modules/bullet/rigid_body_bullet.cpp:78)
[3] MethodBind0RC<float>::call(Object*, Variant const**, int, Variant::CallError&) (/home/akien/Projects/godot/godot.git/./core/method_bind.gen.inc:593 (discriminator 4))
[4] ClassDB::get_property(Object*, StringName const&, Variant&) (/home/akien/Projects/godot/godot.git/core/class_db.cpp:1069)
[5] Object::get(StringName const&, bool*) const (/home/akien/Projects/godot/godot.git/core/object.cpp:494)
[6] ClassDB::class_get_default_property_value(StringName const&, StringName const&, bool*) (/home/akien/Projects/godot/godot.git/core/class_db.cpp:1404 (discriminator 1))
[7] godot-git() [0x23cc529] (/home/akien/Projects/godot/godot.git/editor/doc/doc_data.cpp:214 (discriminator 1))
[8] DocData::generate(bool) (/home/akien/Projects/godot/godot.git/editor/doc/doc_data.cpp:283 (discriminator 2))
[9] Main::start() (/home/akien/Projects/godot/godot.git/main/main.cpp:1392)
[10] godot-git(main+0xf1) [0x1432043] (/home/akien/Projects/godot/godot.git/platform/x11/godot_x11.cpp:55)
[11] /lib64/libc.so.6(__libc_start_main+0xeb) [0x7f73731fcb0b] (??:0)
[12] godot-git(_start+0x2a) [0x1431eaa] (/home/iurt/rpmbuild/BUILD/glibc-2.29/csu/../sysdeps/x86_64/start.S:122)
-- END OF BACKTRACE --
Aborted (core dumped)

It's not only that concern, but doing this would break API portability, which is critical and the whole reason exposed was added.
If a solution similar to what I proposed (which I use in C#) is not possible or not desired, then here is another option:
Add a way to register classes as "internal" or "private". Those would be generated by bindings generators as any other class, but they would be generated as a private API not visible/exposed to user.

It's important that the API hash calculator excludes such "internal" classes when calculating the API hash.
Such classes cannot bind methods/signals/properties as they are supposed to implement the virtual methods that are already bound by the exposed class they inherit.

Neither this solution nor this PR's solution solve the following issue: it's hard to know what needs to be bound until you get a crash/error. Unless you were to just bind every single non-exposed class as internal.
Ultimately, I prefer the solution I use in C#. Or a similar but better one if any one comes up with that.
If someone could point me to the relevant part of GDNative or godot-cpp where the object of such classes is not recognized, I could be of some help.

The crash described in the 3 related issues no longer happens. Has it been fixed or are we still looking for other solutions? (I notice my PhysicsDirectSpaceState has a null type tag, so casting still doesn't work for non-exposed types.)
Type tags for Godot classes wouldn't be needed if we could access is_class_ptr and get_class_ptr_static (the engine's own cast_to implementation) from GDNative. They'd allow casting to engine types without any info on unregistered classes like BulletPhysicsDirectSpaceState. Casts to NativeScripts would still be handled with type tags.
The implementation is straightforward: changes to Godot, changes to C++ binding.
However, those 2 functions are unused in favor of dynamic_cast on most platforms, so it's worth considering whether we want to use them for GDNative. The functions themselves are not removed when the NO_SAFE_CAST macro is undefined, only their usage in cast_to.

So what is the status of this bug report? Is it waiting to be merged?

Superseded by #34688.


StyleCop Checks Do Not Respect Ruleset File During Build with dotnet from CommandLine- .NET Core

I wanted to ask the same thing. I have modified in my ruleset file some specific checks. During the build in Visual Studio, no warnings are displayed. In CI the project is built with dotnet build (the projects are .NET Core and .NET Standard). All warnings are displayed - https://www.screencast.com/t/wwAB1kgMB
Here is how we use StyleCop in the MSBuild: https://gist.github.com/angelovstanton/d677299f3bb65cc790a4cf76e141be77

Is there a way the ruleset file to be respected during the build from the command line?

I tried different ways to stop the code analysis for specific build configuration but without success.
2. Is there a proper way of doing it?
Thank you in advance for any help on the matter!
P.S. Maybe my issue is related to this one- #2596

You are absolutely right. I did what you suggested and everything is working as expected!


making sure each of the build-identifier is uint64_t

the reason for this change was to make sure each part of the build-identifiers is an unsigned long long
theoretically also unsigned long is 64bit, however it depends on the compilation flags
per only if LP64 is defined in compilation the  unsigned long would be 64bit

@katzoded Thanks for the contribution! I've some comments regarding the naming, but after fixing that, I'll approve.


Providing a yarn.lock file (equivalent of shrinkwrap in npm)

Thanks for the PR! Can you also provide an instruction to update this file?

This file is for yarn (which is a really fast alternative to npm). This file is automatically updated every time we install a package and it needs to be committed to version control.

Thanks for the PR :D


Rewrite and simplify Recycler

Motivation:
We have in the past gotten reports of weird errors that we haven't been able to reproduce, but which could be explained by bugs in the Recycler.
The reason is that the Recycler was mixing concurrency, and interactions with the GC, in ways that were difficult to reason about.
It is unwise to leave suspicous-looking code unaddressed.
Modification:
The Recycler has been rewritten to use a much simpler algorithm, and now completely avoids the use of weak references.
The WeakOrderQueue is gone, and there is no longer a concept of a shared max capacity - only thread-local capacity.
There is also no more scavenging.
It turns out that other code was relying on the ability to forget references to objects they acquired from a Recycler, and this is hard to support if there is a shared pool for moving handles between threads.
Each thread now has a local pool (an ArrayDeque), and an external inbox (also an ArrayDeque, but access is synchronised).
Calls to get() and recycle() in the same thread will just operate on the local pool like a stack.
Calls to recycle() from a thread that did not get() that object (the object was acquired in another thread) will place the object in the originating pools inbox.
When a thread then goes to get() another object, they will first check if they have anything in their inbox, and if so, drain it into their local pool.
Result:
The Recycler code is much easier to understand.

An alternative take is #8052. Not sure which one is best, but I'll point out that this version has fewer changes to the tests, and does away with weak references entirely.
I just noticed the benchmark, which would be good to copy over.

Very happy that we're getting rid of weak ref really: anything that's not using it is a +100 from me :P

@franz1981 Updated. Please take a look.

Got benchmark numbers.

Allocation rate is generally down, despite more work done. I suspect much of this being because DefaultHandle objects are now smaller.


Single VM Dev Env: Use keystone container for identity services

Currently the single VM tests use a fake identity service. As we now have a dockerized keystone instance we should provision and use this keystone in single VM for identity services.

I'll take this one.  I need to do this to fully test ceph inside the Single VM.  Right now ciao-cli can't find the volume service.  It's probably just as easy to enable keystone in Single VM as it is to update the testutils/identity.go file.


tabs Documentation shows error

https://cdmoro.github.io/bootstrap-vue-3/components/Tabs.html#dynamic-tabs-tabs-end-slot

We can close it. It's fixed.


cpeng: fix return code of hps command

In main for hps executable, return exit code returned by calling the
app's main function. If/when CLI11's validators determine an argument to
be invalid, the exit code returned from CLI11 will be returned.
In the case of a validation error, the error code returned is the
enumeration ValidationError which equals 105.
This PR should fix #2530
Signed-off-by: Rodrigo Rojo<EMAIL_ADDRESS>

Coverage increased (+0.004%) to 65.339% when pulling cb707ec61f121da12d13e590c52c5639f07b330c on rrojo/hps-exit-code into a55dd1eafea9195dec2608fdd1a238045963cd8d on master.


Q: How does this relate to fzzy/radix?

Would you suggest using this package instead of fzzy/radix at the moment, and what is your plan with it going forward?

Hi @viblo, I'm so sorry I never got back to you on this, I never received any notifications from github, email or otherwise. There's a small section on this in the README for this project, let me know if that could use any further information. As far as suggesting you use it, yes I do. I've used this for a number of high load projects and I'm quite confident in it. From this point onwards the original radix will not be receiving any new features from me, only bug fixes and doc fixes. This project will receive both new features (if it needs any) as well as bug fixes. Hopefully this helps, again sorry this is coming so late :(


Support GitHub Models API

Feature Request
Support GitHub Models in Open WebUI
The GitHub Models /models API end point returns models info in a slightly different format than what Open WebUI expects.
It looks like the id value provides the full path (ex: azureml://registries/azureml/models/Phi-3-small-8k-instruct/versions/3) of the model in the Azure registry where as the /chat/completions api requires the model's short name (ex: Phi-3-small-8k-instruct). The name attribute has the model short name.
May be below code can be modified to handle what GitHub Models /models endpoint returns. Something like, .map((model) => ({ id: model.id.find('://') > 0 ? model.name : model.id, name: model.name ?? model.id, external: true })) ??
https://github.com/open-webui/open-webui/blob/main/src/lib/apis/openai/index.ts#L264C3-L264C4

Should be supported on dev, testing wanted here.

@tjbck , It doesn't work when I tried with the dev image. It still complains about the full model path.


Docker server

Tasks:

[x] set up the flask server to run in the docker container
[ ] dynamic page
[x] flask server processes audio POST requests
[x] audio from container host
[ ] audio client sends list of all sound devices to flask server
[ ] GUI choose sound device to use/make loopback for

[ ] WASAPI support
[ ] loopback generation for selected audio output devices

soundcard handles loopback devices and the list of audio devices.
Still need to send that list to the flask server.

Added in Vue frontend for dynamic UI


Can we configure the RuleSet while using validator attribute?

Hi Jeremy,
By defined ruleset in our validtor, we can validate them like:
validator.Validate(person, ruleSet: "Names,MyRuleSet,SomeOtherRuleSet")
validator.Validate(person, ruleSet: "default,MyRuleSet")
validator.Validate(person, ruleSet: "*"),

When I integrate to my MVC project, I used the Attribute validator to decorate the class instead of validate manually in the controller, how can we input the ruleSet name as parameter?
// shouldn't be look like this?? but doesn't seem it works
[Validator(typeof(PersonValidator), ruleSet = "*")]
public class Person {
	public int Id { get; set; }
	public string Name { get; set; }
	public string Email { get; set; }
	public int Age { get; set; }
}

Also, can we set validator by defining which ruleset to be used?
such as
   // can we tell the validator which ruleset to be used?
    RuleForEach(model => model.list).SetValidator(new SomeListValidator());

    public class SomeListValidator: AbstractValidator<SomeListItem> {
        public SomeListValidator()
        {
           RuleSet("First", ()=> {
               RuleFor(list => list.SomeProp1).NotEmpty();
           });
           RuleSet("Second", ()=> {
               RuleFor(list => list.SomeProp2).NotEmpty();
           });
        }
    }

You need to use the CustomizeValidatorAttribute on your controller action parameter. Please take a look at the documentation for details on this page under the “validator customisation” section: https://fluentvalidation.net/aspnet.html#asp-net-mvc-5

I'm decorating like this
[CustomizeValidator(typeof(PersonValidator), ruleSet = "*")]
public class Person {
	public int Id { get; set; }
	public string Name { get; set; }
	public string Email { get; set; }
	public int Age { get; set; }
}

or
public ActionResult Save([CustomizeValidator(Interceptor = (typeof(PersonValidator)), RuleSet = "*")] Customer cust) {
  // ...
}

but both of them are not taking any effect, any clue?

Hi, it should be like this:
public ActionResult Save([CustomizeValidator(RuleSet = "myRuleset1, myRuleset2, default")] Customer cust) {
}

I've committed a change to allow ruleset to be specified in a call to SetValidator:
RuleFor(x => x.Address).SetValidator(new AddressValidator(), "MyRuleset");

This will be in the 8.0 release.
I'll close this for now. Please re-open if you're still not able to get CustomizeValidatorAttribute to work.


document streaming results with jdbc

Closes #1440

Will the new driver be released with next version or can we make a custom build meanwhile?
Looking forward to it.

Will the new driver be released with next version or can we make a custom build meanwhile?
Looking forward to it.

You can use the snapshot build in the meantime, documentation is on the installation page

Will the new driver be released with next version or can we make a custom build meanwhile?
Looking forward to it.

You can use the snapshot build in the meantime, documentation is on the installation page

Cannot find the latest jar (duckdb_jdbc-0.10.0-20231025.025423-87.jar) at https://oss.sonatype.org/content/repositories/snapshots/org/duckdb/duckdb_jdbc/0.10.0-SNAPSHOT/
Can you please take a look? It is causing Kotlin gradle project to fail as it tries to find latest.

Will the new driver be released with next version or can we make a custom build meanwhile?
Looking forward to it.

You can use the snapshot build in the meantime, documentation is on the installation page

Cannot find the latest jar (duckdb_jdbc-0.10.0-20231025.025423-87.jar) at https://oss.sonatype.org/content/repositories/snapshots/org/duckdb/duckdb_jdbc/0.10.0-SNAPSHOT/
Can you please take a look? It is causing Kotlin gradle project to fail as it tries to find latest.

See https://github.com/duckdb/duckdb/issues/8240


PostCSS import, and documentation

⚠ IMPORTANT ⚠ Please check the following list before proceeding. If you ignore this issue template, your issue will be directly closed.

[x] Read the docs.
[x] Use Vite >=2.0. (1.x is no longer supported)

Describe the bug
Same as #1629
I am trying to @import an empty theme.css file from src/ using (see Reproduction)
The Vite docs are pretty scarce on syntax/plugins to install/write.
I initially supposed that lang="postcss" is not required ?
same for installing postcss and/or postcss-import libraries ?
same for the postcss.config.js file ?
I have tried adding all the above but still get this error (see Logs section)
Vite seems unable to resolve @import word, despite #1629 saying it is fixed/merged ?
I am honestly clueless on what is preventing Vite to recognize @import keyword, which is extremely commonly used.
Reproduction

// App.vue

System Info

vite version: ^2.0.0-beta.49
Operating System: Windows10
Node version: 15.6
Package manager (yarn) and version: 1.22.10

Logs (Optional if provided reproduction)

Run vite or vite build with the --debug flag.
Provide the error log here.

Just initialized a bare vite project using vue-ts template,
installed postcss-import lib
added postcss.config.js with declaring the postcss-import plugin
transfered the #app css rule from App.vue into a src/theme.css file
Used @import './theme' in App.vue
... and it works o.O

Just initialized a bare vite project using vue-ts template,
installed postcss-import lib
added postcss.config.js with declaring the postcss-import plugin
transfered the #app css rule from App.vue into a src/theme.css file
Used @import './theme' in App.vue
... and it works o.O

You don't need to install anything and @import just works out of the box inside all CSS, including <style> of Vue SFCs.

You don't need to install anything and @import just works out of the box inside all CSS, including <style> of Vue SFCs.

@Sharlaan
It doesn't work for me...

has none //  ......
so, what can i do next?


Wrong decription

Hello,
It seems that command in the examples
bwa mem -M example.fasta example.1.fq example.2.fq | samtools view - > example.bam
produces a SAM file instead of a BAM.  To receive a BAM we need to use
bwa mem -M example.fasta example.1.fq example.2.fq | samtools view -Sb - > example.bam

Hello @andreyurch,
You are absolutely correct. Thanks very much for pointing it out! I will update the README. :)
Simo

Hello @andreyurch,
Samtools command line is now fixed :) Thanks!
Simo


can't compile mqtt client with tls

Hello, I encountered a problem when compile the https://github.com/redboltz/mqtt_cpp/blob/master/example/tls_client.cpp example client code with tls.
/root/CLionProjects/test_mqtt_cpp/main.cpp: In function ‘int main()’: /root/CLionProjects/test_mqtt_cpp/main.cpp:20:23: error: ‘make_tls_sync_client’ is not a member of ‘mqtt’      auto c = MQTT_NS::make_tls_sync_client(ioc, host, port);                        ^~~~~~~~~~~~~~~~~~~~ /root/CLionProjects/test_mqtt_cpp/main.cpp:20:23: note: suggested alternative: ‘make_async_client’      auto c = MQTT_NS::make_tls_sync_client(ioc, host, port);                        ^~~~~~~~~~~~~~~~~~~~                        make_async_client /root/CLionProjects/test_mqtt_cpp/main.cpp:21:70: error: template argument 1 is invalid      using packet_id_t = typename std::remove_reference_t<decltype(*c)>::packet_id_t;                                                                       ^ /root/CLionProjects/test_mqtt_cpp/main.cpp: In lambda function: /root/CLionProjects/test_mqtt_cpp/main.cpp:52:32: error: ‘c’ is not captured                      pid_sub1 = c->subscribe("mqtt_client_cpp/topic1", MQTT_NS::qos::at_most_once);                                 ^ /root/CLionProjects/test_mqtt_cpp/main.cpp:45:38: note: the lambda has no capture-default              [&c, &pid_sub1, &pid_sub2]                                       ^ /root/CLionProjects/test_mqtt_cpp/main.cpp:20:10: note: ‘<typeprefixerror>c’ declared here      auto c = MQTT_NS::make_tls_sync_client(ioc, host, port);           ^ /root/CLionProjects/test_mqtt_cpp/main.cpp:53:32: error: ‘c’ is not captured                      pid_sub2 = c->subscribe(                                 ^ /root/CLionProjects/test_mqtt_cpp/main.cpp:45:38: note: the lambda has no capture-default              [&c, &pid_sub1, &pid_sub2]                                       ^ /root/CLionProjects/test_mqtt_cpp/main.cpp:20:10: note: ‘<typeprefixerror>c’ declared here      auto c = MQTT_NS::make_tls_sync_client(ioc, host, port);           ^ /root/CLionProjects/test_mqtt_cpp/main.cpp: In function ‘int main()’: /root/CLionProjects/test_mqtt_cpp/main.cpp:74:22: error: ‘packet_id_t’ has not been declared                      (packet_id_t packet_id){                       ^~~~~~~~~~~ /root/CLionProjects/test_mqtt_cpp/main.cpp:81:22: error: ‘packet_id_t’ has not been declared                      (packet_id_t packet_id){                       ^~~~~~~~~~~ /root/CLionProjects/test_mqtt_cpp/main.cpp:87:22: error: ‘packet_id_t’ has not been declared                      (packet_id_t packet_id){                       ^~~~~~~~~~~ /root/CLionProjects/test_mqtt_cpp/main.cpp:94:22: error: ‘packet_id_t’ has not been declared                      (packet_id_t packet_id, std::vector<MQTT_NS::suback_return_code> results){                       ^~~~~~~~~~~ /root/CLionProjects/test_mqtt_cpp/main.cpp:113:40: error: ‘packet_id_t’ was not declared in this scope                       MQTT_NS::optional<packet_id_t> packet_id,                                         ^~~~~~~~~~~ /root/CLionProjects/test_mqtt_cpp/main.cpp:113:51: error: template argument 1 is invalid                       MQTT_NS::optional<packet_id_t> packet_id,                                                    ^ /root/CLionProjects/test_mqtt_cpp/main.cpp: In lambda function: /root/CLionProjects/test_mqtt_cpp/main.cpp:121:52: error: invalid type argument of unary ‘*’ (have ‘int’)                      std::cout << "packet_id: " << *packet_id << std::endl;                                                     ^~~~~~~~~ CMakeFiles/test_mqtt_cpp.dir/build.make:62: recipe for target 'CMakeFiles/test_mqtt_cpp.dir/main.cpp.o' failed make[3]: *** [CMakeFiles/test_mqtt_cpp.dir/main.cpp.o] Error 1 CMakeFiles/Makefile2:72: recipe for target 'CMakeFiles/test_mqtt_cpp.dir/all' failed make[2]: *** [CMakeFiles/test_mqtt_cpp.dir/all] Error 2 CMakeFiles/Makefile2:84: recipe for target 'CMakeFiles/test_mqtt_cpp.dir/rule' failed make[1]: *** [CMakeFiles/test_mqtt_cpp.dir/rule] Error 2 Makefile:118: recipe for target 'test_mqtt_cpp' failed make: *** [test_mqtt_cpp] Error 2
And I've add OPTION(MQTT_USE_TLS "Enable building TLS code" ON) and Boost dependencies in CMakeList.
Thanks in advance~

We'll need a minimal reproduction
Please post the bare minimum cmake file and associated c++ file that reproduces the issue.
We also need platform and compiler information.

CMakeLists.txt file that I used to compile tls_client.cpp was:
cmake_minimum_required(VERSION 3.1)
project("mqtt-test" VERSION <IP_ADDRESS> LANGUAGES CXX)
include(FindBoost)
include(FindOpenSSL)

set(CMAKE_SCRIPTS "${CMAKE_SOURCE_DIR}/cmake")
set(THREADS_PREFER_PTHREAD_FLAG ON)
find_package(Threads REQUIRED)

set(Boost_USE_MULTITHREADED ON)
find_package(Boost 1.66.0 REQUIRED system)

include_directories(${Boost_INCLUDE_DIR} ${OPENSSL_INCLUDE_DIR} ".")
add_executable(test tls_client.cpp)
target_link_libraries(test ${Boost_LIBRARIES} ${OPENSSL_LIBRARIES} Threads::Threads)

I'm not that familiar with cmake so I also (as mentioned in previous post) added:
#define MQTT_USE_TLS

before all headers in tls_client.cpp file instead of defining it throught cmake.

Provide clear information that MQTT_USE_TLS must be defined if TLS is expected.

It should be provided at https://github.com/redboltz/mqtt_cpp/wiki/Config. I just noticed that there was only old information (MQTT_NO_TLS). I updated the wiki page.

If you still has problem, feel free to reopen it.


typescript-type-graphql does not appropriately handle non-string descriptions

Describe the bug
The GraphQL schema I'm using has some description fields that resolve to objects when parsed to GraphQLSchema. These are not appropriately handled by the typescript-type-graphql plugin, which attempts to pass the description object to an string escape function.
To Reproduce
Steps to reproduce the behavior:
I have set up a repro using this sandbox:
https://codesandbox.io/s/beautiful-dew-5i4tm
Note: This uses a JSON introspection schema. You should notice that, when yarn generate is run, you will encounter the following error:
✖ graphql.ts
TypeError: str.replace is not a function
This is because the value being passed to the escapeString function is as follows:
{
  kind: 'StringValue',
  value:'If the asset doesn\'t exist in the queried locale, setting it to true would return the asset published in the fallback locale (if it is published in the fallback locale)',
  block: true,
  loc: { start: 74, end: 258 }
}

Here is the stack trace:
Found 1 error

  ✖ graphql.ts
    TypeError: str.replace is not a function
        at escapeString (/sandbox/node_modules/@graphql-codegen/typescript-type-graphql/index.cjs.js:19:22)
        at TypeGraphQLVisitor.getDecoratorOptions (/sandbox/node_modules/@graphql-codegen/typescript-type-graphql/index.cjs.js:89:44)
        at TypeGraphQLVisitor.InputValueDefinition (/sandbox/node_modules/@graphql-codegen/typescript-type-graphql/index.cjs.js:278:39)
        at visitorPluginCommon.DeclarationBlock.export.asKind.withName.withComment.withBlock.field.arguments.map.argument (/sandbox/node
_modules/@graphql-codegen/typescript-type-graphql/index.cjs.js:163:61)
        at Array.map (<anonymous>)
        at TypeGraphQLVisitor.getArgumentsObjectDeclarationBlock<EMAIL_ADDRESS>js.js:163:40)
        at TypeGraphQLVisitor.getArgumentsObjectTypeDefinition<EMAIL_ADDRESS>.js:167:37)
        at fieldsWithArguments.map.field (/sandbox/node_modules/@graphql-codegen/typescript-type-graphql/index.cjs.js:112:29)
        at Array.map (<anonymous>)
        at TypeGraphQLVisitor.buildArgumentsBlock (/sandbox/node_modules/@graphql-codegen/typescript-type-graphql/index.cjs.js:103:14)
        at TypeGraphQLVisitor.ObjectTypeDefinition (/sandbox/node_modules/@graphql-codegen/typescript-type-graphql/index.cjs.js:144:47)
        at Object.visit (/sandbox/node_modules/graphql/language/visitor.js:243:26)
        at Object.plugin (/sandbox/node_modules/@graphql-codegen/typescript-type-graphql/index.cjs.js:322:35)
        at executePlugin (/sandbox/node_modules/@graphql-codegen/core/index.cjs.js:36:35)
        at Promise.all.options.plugins.map (/sandbox/node_modules/@graphql-codegen/core/index.cjs.js:113:30)
        at Array.map (<anonymous>)

#############
#############
-->

My GraphQL schema:

schema.zip

My GraphQL operations:

I don't know what this is :(

My codegen.yml config file:

overwrite: true
schema: schema.json
generates:
  graphql.ts:
    plugins:
      - "typescript-type-graphql"

Expected behavior
The code is generated without issue
Environment:

OS: Windows 10
"@graphql-codegen/cli": "1.20.1",
"@graphql-codegen/introspection": "1.18.1",
"@graphql-codegen/typescript": "1.20.2",
"@graphql-codegen/typescript-type-graphql": "^1.18.2"
NodeJS: 12

Additional context

Fixed in https://github.com/dotansimha/graphql-code-generator/commit/febe054a1fcad107579b860c6a9c22eb5d2aef09

Fixed in<EMAIL_ADDRESS>


Solution for resolving the issue of point size not functioning correctly in GLES3

The pull request addresses the problem of point size option in custom shaders and base material not functioning correctly in the GLES3 compatibility renderer. For more information on this issue, please refer to the following link: #73826.
Bugsquad edit:

Fixes #73826
Fixes: #74005

Thanks! And congrats for your first merged Godot contribution :tada:

Cherry-picked for 4.0.2.


Removes inaccurate comment.

This used to be true, but at some point the RegistryPuller became a general purpose registry puller.

/approve


Opt into Ruby style for thoughtbot

This change is meant to enable cops that thoughtbot projects should follow and disable the rest.

LeGiT****M

@gylaz huh?

LGTM

@gylaz, I don't get it, all the Cops are disabled.

@salbertson I'm confused about what you are confused about. LGTM, means "Looks good to me".

Is the idea with this pull request that we're starting with a file where everything is disabled, and we'll comment on the lines we think should be enabled based on our style guide?

Do we have a reason to believe the current approach isn't working?

Do we have a reason to believe the current approach isn't working?

The issue is that new rules are activated without input from the team, so occasionally Hound just shows up and starts commenting about odd things on pull requests.
Here's a good example: https://github.com/thoughtbot/upcase/pull/1228

Assignment Branch Condition size for stub_trail is too high. [15.03/15]

We don't want Hound to do complexity checks; we have other tools for that.

Rename have_completed_text to have_completed_text?.

We also consider it good practice to name matchers that way, so the second comment is sort of harmful.
We have a group buy-in process for our style guide. When Hound starts making up new rules, the process starts to break down.

@jferris, yes, please :+1: any rule you would like enabled and I'll make the change.

@jferris Where do we land on things that are a best practice in ruby, but we don't explicitly call it out in our style guide?
@salbertson There's a lot here to go through. Would it be better to generate a full config for the current thoughtbot config, and disable the rules that are not thoughtbot approved?

Where do we land on things that are a best practice in ruby, but we don't explicitly call it out in our style guide?

In order to be consistent, I think it would be best to leave them disabled and open a pull request to our style guides.
Thanks a lot for going through all of these. I know it's a lot of work, and not a particularly interesting challenge.

I've made changes based on feedback. Here are the rules that are enabled:
Style/AlignHash
Style/AlignParameters
Style/AndOr
Style/BarePercentLiterals
Style/CollectionMethods
Style/DotPosition
Style/EmptyLineBetweenDefs
Style/EmptyLinesAroundBlockBody
Style/EmptyLinesAroundClassBody
Style/EmptyLinesAroundModuleBody
Style/FileName
Style/FirstParameterIndentation
Style/StringLiterals
MultilineOperationIndentation

Closing this until https://github.com/thoughtbot/guides/issues/318 is figured out.


Pushing manifest files for SQL Server Management Studio 19.1

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Validation tracking:
Locale de-DE Validation: 108
Locale en-US Validation: 109
Locale es-ES Validation: 111
Locale fr-FR Validation: 110
Locale it-IT Validation: 112
Locale ja-JP Validation: 113
Locale ko-KR Validation: 114
Locale pt-BR Validation: Pending
Locale ru-RU Validation: Pending
Locale zh-CN Validation: Pending
Locale zh-HK Validation: Pending
Locale zh-TW Validation: Pending


Upgrade mio to fix security advisory

Just did a cargo update. This should fix the security advisory:
https://github.com/scs/substrate-api-client/security/dependabot/27

Closed in favor of #756


re-deployment strategies

As today integrations are re-deployed with a rolling deployment strategy but we need to make the re-deployment strategy configurable, i.e. we should be able to start the new pod/deployment only when the old one is completely shut down.

Right, we could also support the Recreate strategy, that may be more appropriate, depending on the Integration connectivity or logic.


Separated Login form and Register form

#163
And with some minior fixes. See commit logs for details.

These should really be two different pull requests: (1) for changes to the login page, and (2) for updating Bootstrap.
We use Bootstrap on many different pages so that is likely to be a different and substantial task to debug and integration.

Cross referencing similar pull requests #193.

(regardless, thanks @SummerWish for the PR)
@irdan Any thoughts on Modal (#193) vs Swap (#195)? I am leaning towards modal for the first run page, but it is more of a debate here.

@smcgregor So sorry that I didn't noticed this issue. I have reverted that commit.

Thanks, if we go this direction for the login form I'll cherry pick 6405252, since it will exclude the bootstrap changes.

For my own notes, I attempted to merge the two registration/login pull requests by I am receiving an error.
branch
build

I just deleted a comment that was on the wrong PR... Sorry for the email.

Oh I'm sorry, previously thought that generated templates are the same in both Chrome build and Firefox build... Since it is different for different builds, should those generated templates be ignored?

Which generated templates?

sorry, generated HTML.
for example, those Message/show.html, PlainPost/show.html .. etc

Master is periodically updated with the "web" build. This causes merge conflicts in chrome-extension-master and firefox-extension-master, but they are easily resolved with another invocation of python build.py --platform=...

The login/registration page now uses a modal dialog so I am going to close this PR. Feel free to improve the new login page with your work here.


Remove Byron Bech32 support

We use the prefix to distinguish keys, but according to the code, Byron and Shelley share the same prefix:
instance SerialiseAsBech32 (VerificationKey ByronKey) where
    bech32PrefixFor         _ =  "addr_xvk"
    bech32PrefixesPermitted _ = ["addr_xvk"]

instance SerialiseAsBech32 (VerificationKey PaymentExtendedKey) where
    bech32PrefixFor         _ =  "addr_xvk"
    bech32PrefixesPermitted _ = ["addr_xvk"]

We use the following list when deserialising:
    bech32Types =
      [ FromSomeType (AsVerificationKey AsByronKey)
                     AByronVerificationKey
      , FromSomeType (AsVerificationKey AsPaymentKey)
                     APaymentVerificationKey
      , FromSomeType (AsVerificationKey AsPaymentExtendedKey)
                     APaymentExtendedVerificationKey
      ]

So when deserialising a key like addr_xvk18359zklg0x68ru6yhxyvsv3slt6wscs00mzsc45jrv9840dfutj5uxg6z6rp4w2pany4kjgg5tly8s5xv7fuyq5tf8kw9ehr7cy4lzcenyhck, it thinks the keys are Byron because Byron appears first in the list and shares the same prefix as Shelley.
Having an instance for Byron declare that Byron keys have the addr_xvk prefix seems wrong.  This PR removes support for serialising and deserialising Byron keys with that prefix.

This fixes https://github.com/input-output-hk/cardano-node/issues/2596
With this change the following works as expected:
$ cardano-cli address build --payment-verification-key addr_xvk18359zklg0x68ru6yhxyvsv3slt6wscs00mzsc45jrv9840dfutj5uxg6z6rp4w2pany4kjgg5tly8s5xv7fuyq5tf8kw9ehr7cy4lzcenyhck --testnet-magic<PHONE_NUMBER>
addr_test1vptgn6nxuhfc0rt3s7xydxlczm2rncn7dhcqt4jp4d9edqqax2mf6%
$ cardano-cli address info --address addr_test1vptgn6nxuhfc0rt3s7xydxlczm2rncn7dhcqt4jp4d9edqqax2mf6

So now the only way to use Byron keys is via a file (using text envelope format) right?

Yep.

bors merge


fix: service name url mismatch

Context
The url link from pg-boss-worker needs to point to the correct service name.
Solution
Without really understanding how they are rendered and if the actual service name would be rendered as expceted, ensure that they are both rendered the same way (either right or wrong).
Testing
This is currently a root cause for a failure in dev-preview deployment.
As per: https://github.com/input-output-hk/wallet-world/pull/2854

The CI failure is due to an old package version of Nix in discovery runners. The image tag, however, does not change via this change set. Test have been successfully executed according to the protocol in https://github.com/input-output-hk/wallet-world/pull/2854.
Deploying now manually,


Update pulsar-client to 2.6.0

Updates org.apache.pulsar:pulsar-client from 2.5.2 to 2.6.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.pulsar", artifactId = "pulsar-client" } ]

labels: library-update, semver-minor

If you re-run this it may pass. The pulsar 2.6.0 docker was released a day after this job executed, which appears to be the cause of the Travis failure

$ docker run -d -it -p 6650:6650 -p 8080:8080 -v $PWD/data:/pulsar/data apachepulsar/pulsar:2.6.0 bin/pulsar standalone

Unable to find image 'apachepulsar/pulsar:2.6.0' locally

docker: Error response from daemon: manifest for apachepulsar/pulsar:2.6.0 not found.

See 'docker run --help'.

The command "docker run -d -it -p 6650:6650 -p 8080:8080 -v $PWD/data:/pulsar/data apachepulsar/pulsar:2.6.0 bin/pulsar standalone" failed and exited with 125 during .

Updated it manually, all passed.


Add utility for weight visualization

Regarding the file inspection tool, I have added a utility for visualizing model weights. However, I believe it would be more versatile and widely applicable to implement this directly for models rather than focusing only on saved files. As a result, I have developed logic to display the model's weights using Matplotlib.
If it sounds good, I would like to propose integrating this functionality into plot_model, or perhaps creating a new utility method that accepts a model as a parameter.
here is my gist

Codecov Report
Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 57.63%. Comparing base (cb6ece3) to head (f410114).

Files with missing lines
Patch %
Lines

keras/src/utils/weight_visualization.py
0.00%
62 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (cb6ece3) and HEAD (f410114). Click for more details.
HEAD has 14 uploads less than BASE

Flag
BASE (cb6ece3)
HEAD (f410114)

keras.applications
4
0

keras.applications-numpy
1
0

keras
4
1

keras.applications-torch
1
0

keras.applications-jax
1
0

keras.applications-tensorflow
1
0

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20225       +/-   ##
===========================================
- Coverage   82.12%   57.63%   -24.49%
===========================================
  Files         501      502        +1
  Lines       47440    47502       +62
  Branches     8711     8725       +14
===========================================
- Hits        38958    27376    -11582
- Misses       6570    18419    +11849
+ Partials     1912     1707      -205

Flag
Coverage Δ

keras
57.63% <0.00%> (-24.35%)
:arrow_down:

keras-jax
?

keras-numpy
57.63% <0.00%> (-0.22%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

keras.applications
?

keras.applications-jax
?

keras.applications-numpy
?

keras.applications-tensorflow
?

keras.applications-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks for the PR! As for https://github.com/keras-team/keras/issues/19705, the main value would be to have an interactive, nice-looking HTML-based way to visualize the content of saved files and edit them. Visualizing weights is a separate problem, which we could leverage as part of the saved file visualizer, but it's not the main value there.
If you want to add a weight visualizer, we should make it clear where the boundaries between different "slices" of weights are. Right now everything is a big 2D grid. We should have slice separators and some indicator of which axes the slices map to.
But again, the main goal of #19705 is to see and edit the content of saved files interactively. Weight visualization is secondary.

Ok, I understand your thought. So, How about using load_model and save_model method to load,edit and save the model attribute and weight rather than using directly handle savedModel format?
I think this approach could be more versatile, since there could be several saving file format include .keras and .h5 in the future.
Plz feel free to share your opinion on this.

So, How about using load_model and save_model method to load,edit and save the model attribute and weight rather than using directly handle savedModel format?

It is not possible to load a model if it doesn't match your local code. You can only load it by modifying the saved file first.
The formats to target are the .keras and .weights.h5 formats.


Change email and name of BEIS department across the app

Change<EMAIL_ADDRESS>to<EMAIL_ADDRESS>Change Department Business, Innovation & Skills to  Department for Business, Energy & Industrial Strategy

 As an Applicant I want all email contact information and references to the QAE team to be updated, so that I know they are now part of the Department for Business, Energy & Industrial Strategy

Looks ok :+1:


Setting role_name on Flask app

I can't find relevant docs on how to set cloud.role_name on a Flask app. The AppInsights class doesn't seem to have a context attribute. Is there a way to set it?

The Flask integration currently doesn't provide a way to explicitly set context attributes. You can see this here where the telemetry channel is initialized with the default context: https://github.com/Microsoft/ApplicationInsights-Python/blob/5866580ce8e9761221f5a8be606461d8f23f5e6b/applicationinsights/flask/ext.py#L98
You could use the following to set the context, but this relies on private attributes so it may not be supported in future versions:
my_context = TelemetryContext()
# ... set attributes on the context

appinsights = AppInsights(app)
appinsights._channel._context = my_context

I've submitted a pull request for this here: https://github.com/Microsoft/ApplicationInsights-Python/pull/157
If the pull request is merged, you should be able to address your use-case via the following:
appinsights = AppInsights(app)
appinsights.context.cloud.role_name = 'my-role-name'

# all telemetry (e.g. requests, traces, etc.) will include the role name
@app.route('/test')
def test():
    app.logger.info('some message')
    appinsights.flush()


Expose fields mapping (payload to hash fields).

This can be useful for setting the source pointer of an error in an application.

Closed by #10.


test: add test case for Create User Account

Add data-xx property in table element in Users section to make locate page element easy.
Add test case for Create User Account function.

Case failed on rhel-7-7 is due to #631.

@KKoukiou, @jgiardino Thanks for review. I'll not land this PR until #631 got fixed. Otherwise the following test on rhel-7-7 will fail.

@henrywang : The conflicts aren't trivial -- can you please rebase this, so that we can land this soon? This should be unblocked now. Thanks!


feat(tutorial): complete step 5

http://carbon-tutorial-lehile.mybluemix.net/

Should I wait for approves?


DSK-18281 Update the add-in developer guide and examples for the newly added API "Selection"

Here are the updates:

Add description into the developer guide for the newly added API "Selection"
Add an add-in example to demonstrate the usage of the newly added API
Update the snapshots of the existing add-in examples so that they are consistent with the newly added add-in example which is using Windows 10 style dialogs

@PerkinElmer/chemdraw-desktop-reviewers, @ASmellie, Please review.
Note: The add-in guide (PDF file) is already reviewed by Andrew and the team.

All issues are addressed. Please review.

@zhanglin-wu This is open for a very long time

We need the approvals for this PR, but we should hold on the merge until the day when ChemDraw 18 is officially released.


[Bug]: When the frontend tables have no rows, the headers are displayed weirdly

Contact details
No response
Current behavior
No response
Expected behavior
No response
Steps to reproduce
No response
Environment

SIM-PIPE version:
Platform/OS:
Browser:
Other:

Screenshots
No response
Logs
No response

css problem. Aestetically only.


Google API changes

A while back Google changed access token response for their authorization service. The response lists refresh_token param twice making it too long for Windows Credentials Manager to store.
The best would be to move away from oauth2client to a newer, Python 3 library such as google-auth  or oauthlib. That would require though refactoring Overload to Python 3 - a large undertaking, especially considering its reliance on PyZ3950 which is Py2 only.
In the meantime, the easiest way to deal with access token response is to delete one of the refresh_token params from credentials object in the oauth2client.contrib.keyring_storage  in the locked_put method.
def locked_put(self, credentials):
    """Write Credentials to file.

    Args:
        credentials: Credentials, the credentials to store.
    """

    # google updated their API auth server response, which duplicates
    # the refresh_token param, which makes credential string too long
    # for Windows credential manager
    # this is a walkaround the problem
    del credentials.token_response["refresh_token"]

    keyring.set_password(self._service_name, self._user_name,
                         credentials.to_json())

exception handling
    try:
        del credentials.token_response["refresh_token"]
    except KeyError:
        pass

    keyring.set_password(self._service_name, self._user_name,
                         credentials.to_json())

this seems to work better:
# del token response data as it duplicates the rest of creds info
credentials.token_response = None


fix(material/paginator): combobox items per page accessible label mis…

…matches visual label
Fixes a bug in the Angular Material paginator component where the screenreader accessible label for the 'Items per page:' combobox does not match the UI visual label. This is because the Angular Material select component has a function which gets the aria-labelledby string and places the value before the label.
Fixes b/286094434

Screenshots:
Before: https://screenshot.googleplex.com/6mLWEQdiRExtJSH
After: https://screenshot.googleplex.com/6Bird5GYwKkK6eg

Closing PR because after consulting Zach it looks like the bug is WAI.


[release + cherry pick] run verify codesign test on post submit only

cherry picks https://github.com/flutter/flutter/pull/120411

Umm it seems like this one wasn't merged to stable, and that might be the reason why we are still seeing presubmit checks on stable?

Closing this since it looks like 3.7.1 is no longer the stable anymore


Bug: Missing _ZN5Audio9setVolumeEd

I
Win 10x64, QLC+ 5 beta 2
I  am trying to open a v4 project which had MIDI mapping to fader,
https://gist.github.com/X-Raym/4aac0af9bb747675f767df4a78e54375
I got this error message:

Le point d'entrée de la procédure _ZN5Audio9setVolumeEd est introubavle dans la bibliothèque de liens dynamiques .... qlcplusui.dll

Thx!

You are mixing v4 with v5
You need to install them in separate folders!

@mcallegari Then this means that there is a problem with the install/uninstall process.
I can confirm: I have both QLC+ 4 and 5 right now and none of them appears into Installed program of windows.
I also confirm that running the Uninstaller of v4 manually doesnt do anything.
EDIT: seems I had to run it in administator mode, yet it still leaves plenty of folder https://i.imgur.com/yGPK91F.png
Also, both install install the same shortcut name in Start Menu, so I cant have v4 and v5 shortcuts at the same time (unless created manually). New version should probably have "5" has indicator (at least for beta)
Not of this issue are that problematic but there are definitely some things unsual here.
Thx!


running test improvements: use single test command "npm test"

hi,
i little bit simplified testing.
tested on latest osx

Thanks for the PR, but I'm not seeing how this is "simplified". Instead, it looks quite a bit more complex. What specific goal(s) did you have that prompted these changes? Also, the build is now failing, and I'm not certain what the cause is.

Yeah, I saw build is fail. Simplify means using: install selenium, start server, run test, stop..

Sorry, how is that easier than:

npm start
npm run start-webdriver
npm test

...not to mention the large number of new npm scripts you introduced?

just, nam test
and you also have to stop server/webdriver (so it’s 4 and 5)

On Jun 12, 2016, at 18:41, Ray Nicholus<EMAIL_ADDRESS>wrote:
Sorry, how is that easier than:
npm start
npm run start-webdriver
npm test
...not to mention the large number of new npm scripts you introduced?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Widen/fullstack-react/pull/9#issuecomment-225444146, or mute the thread https://github.com/notifications/unsubscribe/ACVRJCshrgT4breAgpwLgD4uh6HDySaGks5qLCiNgaJpZM4IyXEK.


Brightness control

Pxmatrix is a great lib for RGB matrix panel. But I think it is the only one missing that is Brightness Control. Is there any way that you can control brightness of RBG panel???????
<EMAIL_ADDRESS>

what about setBrightness ?


Fix/load more sort

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   89.14%   89.14%
=======================================
  Files          12       12
  Lines         479      479
  Branches      114      114
=======================================
  Hits          427      427
  Misses         52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8930091...59e9023. Read the comment docs.


gnu(17424)=3682

gnu(17424)=3682
GAP      4.8.3
GrpConst 2.5
Runtime: 2822440 ms (47.03 min)
Isomorphic groups eliminated
In case this value is new, add the next line to data/gnudata.g
GNU_SAVE( 17424, 3682, WITH_GC );

gap>
System : Windows Vista

Thank you for submitting new gnu(n). We will recalculate it and add to the database if we get the same result.
Checklist for the reviewer:

[ ] checked and assigned labels "new (n<50000)" or "recomputation", if needed
[ ] set "replication needed" label (unless it starts immediately)
[ ] changed it to "replication in progress" label when the replication has been started
[ ] changed it to "replicated" after successful replication review
[ ] reproducible value of gnu(n)
[ ] no essential runtime differences
[ ] sufficient level of technical details

Checklist for the maintainer:

[ ] correct arguments of command to store data
[ ] correct location of new line in the data file
[ ] mention submitter and reviewer in the commit message
[ ] Close corresponding issue from the commit message

gnu(17424)=3682
GAP      4.8.4
GrpConst 2.5
Runtime: 2381317 ms (39.68 min)
Isomorphic groups eliminated
Replicated by @alex-konovalov on Linux server (AMD Opteron 6376 1400 MHz processor, 512 GB RAM)
To maintainers: for new results, add to data/gnudata.g this line:
GNU_SAVE( 17424, 3682, WITH_GC );


__strReplaceRegex instead of __strReplace

Key of the StrReplaceRegex function seems incorrect, it should be "__strReplaceRegex", not "__strReplace".

The function name would have to remain the same for the historical reasons. It was like that in the beginning and cannot change in a breaking way now.

The function is not working at all due to to wrong name (which is already used by another one). You're not breaking anything since it's already broken.

__strReplace and __strReplaceRegex have both the same key __strReplace.

Wow, that changes everything. Thanks for reporting this!

New version has been released, thanks for being persistent


Feature/aws v4 signature

Adds posiblity to handle v4 aws signatures correctly.
related to https://github.com/akka/akka-http/issues/2277

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3a84f97). Click here to learn what that means.
The diff coverage is 69.23%.

@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   86.11%
=========================================
  Files             ?       25
  Lines             ?      533
  Branches          ?       47
=========================================
  Hits              ?      459
  Misses            ?       74
  Partials          ?        0

Impacted Files
Coverage Δ

.../wbaa/airlock/proxy/handler/RequestHandlerS3.scala
100% <100%> (ø)

.../airlock/proxy/provider/aws/SignatureHelpers.scala
86.13% <55.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a84f97...90bbdb2. Read the comment docs.


cppm-tool update for vcpkg serdepp-config.cmake bugfix

Codecov Report

Merging #51 (1848b8d) into main (a24b483) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   68.53%   68.53%
=======================================
  Files          16       16
  Lines         518      518
=======================================
  Hits          355      355
  Misses        163      163

Flag
Coverage Δ

unittest
68.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a24b483...1848b8d. Read the comment docs.


GOL: First frame bug

The first frame when starting an animation is always the same as the frame before.

Done with commit: 5a44f5600eb3cfa09d00b35bc545f80a4eaa01e2


[Suggestion] Add a way to see what the file size will be for batch downloads

Right now when you batch download curations, unless you manually add them up yourself, you have no way of knowing how big the download will be. Some of us don't have the internet to handle a surprise 10GB Ganon curation, and with the number of Youtube games being added, very large batches are quite possible. Even if the file size is just estimated, it will help prevent very large download surprises.

done in https://github.com/Dri0m/flashpoint-submission-system/commit/d89adee819aaeeabacf27f93f9b3a3f4d0761331


Require a file or variants found for asset: packages/alarm/assets/not_blank.mp3.

Alarm plugin version
ex: 3.0.0-dev.4
Describe the bug
after finish add the package when i run again my app, that can not run because this error "No file or variants found for asset: packages/alarm/assets/not_blank.mp3", i don't know if that is my fault the error is show up, please fix bug or if it is not a bug please tell me how to fix it sir
To Reproduce
Steps to reproduce the behavior:

...

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Device info
Provide device info (Manufacturer, OS version, ...)
POCO M3
Additional context
Add any other context about the problem here.

Hi @KetutKusuma
My bad, it looks like I made a mistake in the latest dev release. I'll publish version 3.0.0-dev.5 with a fix today or tomorrow. I'll keep you updated. If you want it to work now, I'm not sure but you can try to remove the alarm's .pubignore file.

Yeah it works very well, you did great job bro. Now i can use this package to help me, thank you bro👍

Awesome !


Add root_hints for 740xd G-CL

@asyedham Chris had mentioned that racks e26-e29 contain G-CL servers. So maybe this PR should check for the range e26-e29 instead of only e26?

@asyedham Chris had mentioned that racks e26-e29 contain G-CL servers. So maybe this PR should check for the range e26-e29 instead of only e26?

@sanjaychari Let's not add the logic now without testing it on machines from e29 rack,

@asyedham Chris had mentioned that racks e26-e29 contain G-CL servers. So maybe this PR should check for the range e26-e29 instead of only e26?

@sanjaychari Let's not add the logic now without testing it on machines from e29 rack,

@asyedham Ack

Facing this error with the latest changes.
TASK [set fact for e26 rack machines in instackenv] ****************************
task path: /var/lib/jenkins/workspace/OSP-API-tester@2/jetpack/introspect.yml:47
Wednesday 17 November 2021  14:03:48 +0000 (0:00:00.056)       1:44:35.506 ****
fatal: [undercloud]: FAILED! => {
    "msg": "'instackenv_content' is undefined"
}

Facing this error with the latest changes.
TASK [set fact for e26 rack machines in instackenv] ****************************
task path: /var/lib/jenkins/workspace/OSP-API-tester@2/jetpack/introspect.yml:47
Wednesday 17 November 2021  14:03:48 +0000 (0:00:00.056)       1:44:35.506 ****
fatal: [undercloud]: FAILED! => {
    "msg": "'instackenv_content' is undefined"
}

I think we might have to use hostvars['localhost']['instackenv_content'] instead of instackenv_content?

ansible-playbook -vvv main.yml deployed OSP 16.1 with this patch successfully on 740xd G-CL systems. I will trigger a CI build to try out deployment with tags as well.


Add Problem properties to retrieve scaled parameters; add function to…

… scale parameters

Codecov Report

Merging #198 into develop will decrease coverage by 0.39%.
The diff coverage is 42.1%.

@@            Coverage Diff             @@
##           develop     #198     +/-   ##
==========================================
- Coverage    68.58%   68.18%   -0.4%
==========================================
  Files           18       18
  Lines         1251     1270     +19
  Branches       284      288      +4
==========================================
+ Hits           858      866      +8
- Misses         344      355     +11
  Partials        49       49

Impacted Files
Coverage Δ

petab/parameters.py
81.92% <20%> (-8.49%)
:arrow_down:

petab/problem.py
63.55% <66.66%> (+0.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed24599...703e702. Read the comment docs.


support export $request_path

Describe the bug
I use the default log format
$request is "GET /xxx HTTP/1.1"
but the metric result got only "GET" but not "/xxx"
is it has some options to suport it ?

Configuration file (remove section, if not applicable):
    format: "$_ $host nginx: $http_x_forwarded_for - $remote_user [$time_local] \"$request\" \"$request_body\" $status $request_time $upstream_response_time $body_bytes_sent \"$http_referer\" \"$http_user_agent\""

Example log file (remove section, if not applicable):
2024-01-01 host_name_XXX nginx: - - - [time] "GET /metrics HTTP/1.1" "-" 200 0.545 0.545 70 "-" "xxx"

Metrics output (remove section, if not applicable):
nginx_test_http_upstream_time_seconds_hist_bucket{app="nginx_test",environment="testing",method="GET",status="200",le="0.1"}

I got it, thanks


Upgrade pip to >=8.2 for extra name handling bug fix

first off, thanks for the extra_requirements config feature, it's really useful!
i recently hit a problem with it that took a bit to debug. i had an extra named appengine-sdk, and readthedocs would try to install it, but fail with oauth-dropins 1.6 does not provide the extra 'appengine-sdk'. example build.
turns out that pip up to 8.1.2 had a bug (pypa/pip#3810) that made it not support extras with capitals or non-alphanumerics like dashes in their names. when i renamed my extra appenginesdk, it worked. example build.
looks like your requirements.txt currently pegs pip at 8.1.1. mind upgrading that to 8.2 or later for this fix? thanks in advance!
Details

Project URL: https://oauth-dropins.readthedocs.io/
Build URL (if applicable): https://readthedocs.org/projects/oauth-dropins/builds/4722454/
Read the Docs username (if applicable): snarfed

Expected Result
install the appengine-sdk extra successfully.
Actual Result
failed with oauth-dropins 1.6 does not provide the extra 'appengine-sdk' due to pypa/pip#3810.

thanks! ...except it looks like the pip bug was still in 8.1.2, and the fix didn't land until 8.2 or later.

pip was already updated and your build is passing now by installing the correct package version name appengine-sdk-1.9.50.post0. I'm closing this issue.
Please, feel free to reopen if you consider.


Is there a way to get the datafiles used in finngen pheweb for offline use?

We would like to utilize the FINNGEN version of the PHEWEB server but there is a reference in the config files to a large number of files that are not readily available, such a:

Are those files available somewhere or are they perhaps even automatically downloaded like so many other files in pheweb or is this just an example of what this pheweb server can be used for and it is up to me to construct all those files? For some of the files are not obvious what the format and content should be so this is somewhat tricky...

Hi, these are largely FinnGen specific and we don't currently have the bandwidth to provide an out-of-the-box installation unfortunately


feat: improve limit order card copy

Description
Improves the copy on the limit order cards to make more sense with historical limit orders.

Changes Expires in to Expiry to make more sense with both expired and current orders
Changes Limit price to Execution price for fulfilled limit orders

Issue (if applicable)

closes #8218
Risk

High Risk PRs Require 2 approvals

Very low risk.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing
Check that the copy on the limit order cards makes sense.

Engineering

Operations

[ ] :checkered_flag: My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

@woodenfurniture moving to draft after stamp so we don't wrongly merge this to develop as we need clean develop for ops to test https://github.com/shapeshift/web/pull/8322 in next release


Implement idm import sub-command

Frodo currently allows the export of any IDM configuration but not the import.

Completed. Closing.


update resource status theme API

Reason for change

Testing

Check out the diamond theme resource status

Checklist

[ ] CHANGELOG: The Unreleased section of CHANGELOG was updated
[ ] Prop changes: docs were updated
[ ] Prop changes: E2E tests were updated, testing from the highest level possible
[ ] Platform testing: If this change should be tested against a platform, has it been?

Code looks fine to me, but I didn't manage to track down where it was changed in Storybook. I'll approve anyway since it's just theming changes

Storybook doesn't have the changes. you can see the changes in docs while using the diamond theme


Fix aggressive coloring of native administration areas

Turns out andrew knows what this - map will color Indian reservations super harshly which kinda contrasts with the text -- def able to be toned down with the google map tools

Yeah, that's indeed what I meant with this issue. I think the problem is that it uses the administrative color defined in the Google Maps JS config.

I wonder if we can make campuses turn red instead.


AddCommand should not be performing any parsing #306

Closes #306
Proposed merge commit message:
Parsing the add command string into a Person object
is split between the AddCommandParser and the AddCommand.

It is more cohesive if the said parsing is done entirely
by the AddCommandParser itself.

Let's modify the construction of add command as follows:
    * Add an explicit check for empty prefixes and remove the use of
      NoSuchElementException to detect missing prefixes.
    * Make AddCommandParser do the parsing and create a
      fully parsed Person object.
    * Make AddCommand's constructor accept a fully parsed
      ReadOnlyPerson.

v1
@MightyCupcakes submitted v1 for review.

[v1 1/1] Move AddCommand's parsing responsiblites to AddCommandParser

(:books: Archive)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/315/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

[v1 1/1] Typo in commit message responsiblites -> responsibilities
Let's modify the constructor AddCommand -> Let's modify the constructor of AddCommand
This will be corrected in the next iteration

@PierceAndy any comments?

[v1 1/1]:

Let's modify the constructor AddCommand

How about this instead?

Let's modify AddCommand's constructor

@MightyCupcakes Thanks for the mention, I must have missed this PR in my notifications.

v2
@MightyCupcakes submitted v2 for review.

[v2 1/1] Move AddCommand's parsing responsibilities to AddCommandParser

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/315/2/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v3
@MightyCupcakes submitted v3 for review.

[v3 1/1] Move AddCommand's parsing responsibilities to AddCommandParser

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/315/3/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v4
@MightyCupcakes submitted v4 for review.

[v4 1/1] Move AddCommand's parsing responsibilities to AddCommandParser

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v3 and v4)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/315/4/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

Commit message:
Tried to rephrase to avoid proposed solution (when the commit is merged, it is no longer just proposed). Also, trying to favor bullet points over paragraphs. Can consider this kind of phrasing if you feel it's easier to read.
Let's modify AddCommand construction as follows:
* Make AddCommandParser do the parsing and create a
  Person object.
* Make AddCommand's constructor accept a fully parsed
  ReadOnlyPerson.
* Make {who?} verify that all  prefixes exists in the given arguments
  string to in order  to keep the behaviour of AddCommandParser
  consistent.

Benefits:
* The parser will always tell the user of an invalid command
  format first before passing the values to the respective Person
  attributes objects for further input verification.

v5
@MightyCupcakes submitted v5 for review.

[v5 1/1] Move AddCommand's parsing responsibilities to AddCommandParser

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v4 and v5)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/315/5/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v6
@MightyCupcakes submitted v6 for review.

[v6 1/1] Move AddCommand's parsing responsibilities to AddCommandParser

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v5 and v6)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/315/6/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v7
@MightyCupcakes submitted v7 for review.

[v7 1/1] Move AddCommand's parsing responsibilities to AddCommandParser

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v6 and v7)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/315/7/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v8
@MightyCupcakes submitted v8 for review.

[v8 1/1] Move AddCommand's parsing responsibilities to AddCommandParser

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v7 and v8)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/315/8/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

So, after pondering about the overall "off"-ness of the commit message, I realized that the commit actually consists of two separate changes:

Modification of the constructor of AddCommand, which the commit focuses on, and

Ensure that the "invalid command format" error has a higher priority than the "invalid name/email/address/phone/tag format" error.

These should be split into separate commits.
By the way, (2) above is a behavioral change and I'm surprised that none of our tests failed. I guess the testing is lacking somewhere...

Number 2 is not a behavioural change. Without it, some tests will fail because they pass in invalid Person attributes and expect an invalid command message. This is precisely because AddCommandParser will check for command format before passing it to AddCommand.

Ah okay, then I think you can split your commit as follows:

Remove the use of exceptions for control flow in AddCommandParser.
This is where you can introduce your arePrefixesPresent()

Move AddCommand's parsing responsibilities to AddCommandParser
You will then not need to mention anything about arePrefixesPresent() or "keeping the behavior consistent".

v9
@MightyCupcakes submitted v9 for review.

[v9 1/2] Remove the use of exceptions for control flow in AddCommandParser
[v9 2/2] Move AddCommand's parsing responsibilities to AddCommandParser

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v8 and v9)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/315/9/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v10
@MightyCupcakes submitted v10 for review.

[v10 1/2] Remove the use of exceptions for control flow in AddCommandParser
[v10 2/2] Move AddCommand's parsing responsibilities to AddCommandParser

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v9 and v10)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/315/10/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v11
@MightyCupcakes submitted v11 for review.

[v11 1/2] Remove the use of exceptions for control flow in AddCommandParser
[v11 2/2] Move AddCommand's parsing responsibilities to AddCommandParser

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v10 and v11)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/315/11/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v12
@MightyCupcakes submitted v12 for review.

[v12 1/2] Remove the use of exceptions for control flow in AddCommandParser
[v12 2/2] Move AddCommand's parsing responsibilities to AddCommandParser

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v11 and v12)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/315/12/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v13
@MightyCupcakes submitted v13 for review.

[v13 1/2] Remove the use of exceptions for control flow in AddCommandParser
[v13 2/2] Move AddCommand's parsing responsibilities to AddCommandParser

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v12 and v13)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/315/13/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

@MightyCupcakes @yamgent can have another look as there were some changes after you approved. @pyokagan have a look if you have time.

@kychua you too can take another look because the PR has changed after you approved.

@MightyCupcakes this needs de-conflicting

v14
@MightyCupcakes submitted v14 for review.

[v14 1/2] Remove the use of exceptions for control flow in AddCommandParser
[v14 2/2] Move AddCommand's parsing responsibilities to AddCommandParser

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v13 and v14)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/315/14/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v14
Rebased and resolved conflict


revtmd - date of last cleaning

Part of cleaning/maintanence protocol should be recording the date of deck cleaning somewhere in the revtmd coding process history. Not sure where, settings sounds wonky, but not sure where else it could go.

revtmd.py will most likely no longer be used so I'm closing this


Failing test case for #755

What this PR does / why we need it:
Test case for #755
Which issue(s) this PR fixes
None yet!

Checks obviously fail, but this illustrates the problem and should be a good starting point for fixing the issue.

closes in favor of #757


Remove deprecated methods in Options, OptionsBuilder, Attributes & AttributesBuilder

Kind of change

[ ] Bug fix
[ ] New non-breaking feature
[x] New breaking feature
[ ] Documentation update
[ ] Build improvement

Description
What is the goal of this pull request?
See https://github.com/asciidoctor/asciidoctorj/issues/1199
How does it achieve that?
Simply remove methods already marked as deprecated and fix where necessary (mostly tests).

Some extra work removing deprecated use (not the method) of Document::blocks, using now Document::getBlocks

Are there any alternative ways to implement this?
No :thinking:
Docs feed from test code, so it will be updated. Still pending a manual review though.
Are there any implications of this pull request? Anything a user must know?
It's a  breaking change for v3.0.0, nothing to do for v2.5.x branch.
Issue
Fixes #1199

I'll be off for the next 2 weeks

Enjoy! I need to review the docs and I want to start a "migration guide". We owe to the users to make the migration simple.

I decided to also remove Attributes::setAttributes(Map<String, Object>). I was NOT marked as deprecated, but it's not consistent with the approach of Java-like builders.
Users can still use AttributesBuilder::attribute(String) AttributesBuilder::attribute(String, Object) and even ones Attributes instance is created the previous String and Map setters, so no feature is lost for advanced users willing to do more (imho risky) mutable code.

Ready for review :tada:

Squashed changes to keep code and docs changes separated
Created adjacent issue to track other deprecated methods to remove for v3.0.0. That's all I have in mind that we need to v3.0.0 :thinking: (I don't know how many times I thought that already though)


Change blockquote css

[ ] No biggness
[ ] No boldness
[ ] Same styles as normal content p
[ ] Margin around the whole thing by a line or two (slightly more than the normal p + p distance)

Per @biofilo's request

@biofilo @veganstraightedge how do you feel about using a line to indicate block-quotiness?

Seems good to me.
@biofolo how is this to you?

Awesome! Well done everyone!

On Feb 19, 2017, at 4:54 PM, Shane Becker<EMAIL_ADDRESS>wrote:
Seems good to me.
@biofolo how is this to you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/crimethinc/website/issues/307#issuecomment-280952488, or mute the thread https://github.com/notifications/unsubscribe-auth/AXnJNgt_XlAjpXoIeA_tFAQAfuHgT4HAks5reLopgaJpZM4MFkno.


Double check fuel loading times logic when starting flight

When flight was in progress in agent and ground handling was completed, aborted
Restarted and fuel loading restarted/resumed ... but should have been finished

Code review and static testing worked perfect, will double check on next actual test flight

Seems to work fine on all recent flights, closing


Car Body moving

Car bodies randomly sometimes moving
https://discord.com/channels/689515979847237649/1129105388168556554/1286643325155414057
https://discord.com/channels/689515979847237649/1129105388168556554/1286643817986134038

Broken links

Updated all links.

How to reproduce? Any particular conditions need to be met?

How to reproduce? Any particular conditions need to be met?

It happens randomly, i don't know how to reproduce.

@user-grinch I don't have this issue anymore. It was a rare issue anyways. You can close or keep it open.

Did this improve in latest commit?


Special characters not deployed properly

We have a file containing special characters (encoding utf-8).

When the file is deployed to the organization, however, these special characters get replaced with "??????".

This causes some of our unit tests to fail.

Hi @ndorotte,
This was fixed in the 1.0.5 version.

Great!


Sub-Command System

We need a simple way to handle SubCommands.

SubCommands, like:
$command subcommand param0
?

Yes


Missing keys?

Did you check docs and existing issues?

[X] I have read all the which-key.nvim docs
[X] I have searched the existing issues of which-key.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9
Operating system/version
Ubuntu
Describe the bug
Hi, I've been loving using which-key, but as I learn more about Vim / Neovim it's come to my attention that a lot of lesser known / used shortcuts are missing from the pop-ups — I'm talking about keys native to Vim, as well (all my plugin keys are showing as expected!)
One example lately is that I couldn't remember what the key bindings are to go back / forward through the changelist. I knew it was g-something, so I typed g, but the mappings I was looking for weren't there. This caused me to waste a lot of time searching through other key prefixes before I realized that which-key.nvim simply doesn't show them under g.
It's such a cool and useful pair of mappings, I can't figure out why they aren't listed.
Moreover, most g-prefixed commands actually aren't there.
As I want to use which-key.nvim to remember / discover obscure and lesser-used keymaps, it sabotages a large part of the expected functionality of the plugin, and causes me to think there aren't as many awesome keybindings in Neovim as there actually are.
I've searched the docs and can't find any mention of this 'feature', nor how to fix it. If you have a plugin to teach keymaps, and you are under-selling the true number of keymaps, this is something that should be mentioned prominently in the README, near the very top!
OK, sorry if I sound dramatic, I'm really enjoying using which-key and looking forward to any help or feedback on getting ALL built-in keybindings to appear. Thanks! 😺
Steps To Reproduce
Press g
Expected Behavior
See ; and , bindings
Repro
No response

the g key works fine with my config.

return {
  'folke/which-key.nvim',
  event = 'BufReadPre',
  config = function()
    -- disable hints for certain operators
    local presets = require 'which-key.plugins.presets'
    presets.operators['v'] = nil
    presets.operators['c'] = nil
    presets.operators['d'] = nil
    presets.operators['y'] = nil

    local wk = require 'which-key'

    wk.setup {}
    wk.register({
      b = { name = 'Buffer' },
      f = { name = 'Telescope' },
      g = { name = 'LSP Actions' },
      t = { name = 'Trouble' },
    }, { prefix = '<leader>' })
  end,
}

The which-key presets don't include ALL the mappins, since that would make which-key kinda useless.
If you want more standard mappings, you can always add them in yourself.

I also would like to add some missing key bindings to the popup (i.e. gw to auto-wrap keys). How would I do that (sorry, I read the README but still can't figure out the right way to achieve this).

The which-key presets don't include ALL the mappins, since that would make which-key kinda useless.

I don't understand, why would that make which-key useless? Wouldn't it make which-key more useful?


New sonatype URLs

Looks like current hosts are now are legacy

Can you please provide a source for your findings?

https://issues.sonatype.org/browse/OSSRH-76812

Note: As of February 2021, all new projects began being provisioned on https://s01.oss.sonatype.org/. If your project is not provisioned on https://s01.oss.sonatype.org/, you will want to login to the legacy host https://oss.sonatype.org/.

https://central.sonatype.org/publish/publish-guide/#deployment

It's a pity Sonatype hasn't some dispatching facade for it, but I'm not going to change these defaults. As these are just defaults, they can and should be overridden by the user. It's probably questionable that we have a default at all, but changing it does not make much sense, as It will break lots of workflows including Mills one, and it will still be the wrong URL for other users.

We may rething, once the legacy host is shut down and all user are migrated to the new one.


Wait longer for snapshot copies in integ test

Bump the wait time to try and make this integration test fail less often.

Codecov Report

Merging #1876 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1876   +/-   ##
========================================
  Coverage    92.25%   92.25%
========================================
  Files           53       53
  Lines        10001    10001
========================================
  Hits          9226     9226
  Misses         775      775

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c24c4e...4139133. Read the comment docs.


cannot upload a file with slash in it

crashes in Filesystem as S3Storage::complete_multipart_upload

Could you list the steps and reproduce the bug with s3s-fs?

s3s-fs cannot be built. When running just dev: error: multiple versions for dependency windows-sys: 0.42.0, 0.45.0

It may be not the fault of s3s-fs since the CI is passing. It is probably caused by another outdated dependency in your project, which pulls old windows-sys crate version.
To find the cause, you can use cargo tree to list all your dependencies.

client might send the path that is urlencoded twice, thus the signature cannot be calculated correctly if not decoded once.
i did have a glance on the java implementation, might be it?
hUwUtao/s3-server/commit/173b5adbbb03ab6ce88f4dbeda4aeea6564cd8eb, tested on aws-cli, winscp