Output Stylized Image looks different on torch and coreml

I have used same image on  both models , Torch model present a good output while the Coreml model changes the main picture color .
i used this image for testing

the output from torch model is

Coreml model provides this

the model trained options
percep_loss_weight: 1
padding_type: reflect-start
batch_size: 4
arch: c9s1-32,d64,d128,R128,R128,R128,R128,R128,u64,u32,c9s1-3
resume_from_checkpoint:
style_image: images/styles/home.jpeg
max_train: -1
style_image_size: 700
tv_strength: 0.001
lr_decay_factor: 0.5
checkpoint_name: checkpoint
loss_network: models/vgg16.t7
gpu: 0
content_layers: 16
task: style
use_instance_norm: 1
tanh_constant: 150
preprocessing: vgg
style_weights: 5,5,5,5
checkpoint_every: 1000
num_val_batches: 10
num_iterations: 10000
use_cudnn: 1
pixel_loss_weight: 0
content_weights: 1
style_target_type: gram
weight_decay: 0
pixel_loss_type: L2
lr_decay_every: -1
learning_rate: 0.001
style_layers: 4,9,16,23
backend: cuda
upsample_factor: 4
h5_file: /home/Desktop/coreml/models/file.h5

my first thoughts that it's related to this part of the code
if is_grayscale:
        gray_bias = deprocessing_args.get('gray_bias', 0.0)
        W = np.array([image_scale])
        b = np.array([gray_bias])
    else:
        W = np.array([image_scale, image_scale, image_scale])

        red_bias = deprocessing_args.get('red_bias', 0.0)
        green_bias = deprocessing_args.get('green_bias', 0.0)
blue_bias = deprocessing_args.get('blue_bias', 0.0)

@engahmed1190 I can try to investigate and debug this problem if you could attach your torch7 model.

here is the torch model
https://drive.google.com/open?id=0B3sn-iPgMRP7ZWgwOVhuTjZmQU0

@engahmed1190 I tried to run the model which you provided with latest torch7 installation (without CUDA on macOS) using this command: th fast_neural_style.lua -model home.jpeg_700.t7  -input_image test.jpg -output_image test_result.jpg
I got this output:

So it looks like your output from CoreML. May be something inconsistent with torch7 installation or with fast-neural-style repo revision that you use.

i have tried the same model but different result
can you please try the same model but with batch normalization , it works with coreml in batch normalization
Batch Model

can you suggest a solution for this case @opedge
seems to be working with batch norm and instance norm getting reddish

can you suggest a solution for this case @opedge
seems to be working with batch norm but instance norm getting reddish

I've noticed that all new instance norm models don't work.  Also, all historical models in fast-neural-style don't work in torch.  Have yet to figure out the connection.

I found an older machine with an older torch setup (~ 6 months) and the server images for old models generate fine.  I then stepped through the updates that I had applied to the newer machine.
luarocks install torch
luarocks install nn
The server started screwing up image generation for old models after applying the "luarocks install nn" step.
This makes sense I believe because the pytorch convert step always screws up on new models and I suspect it has something to do with the use of "from torch.nn import InstanceNorm3d".

Ive also been having issues with instance normalization models that i have trained in coreml.
Even training with the exact same parameters as the johnson instance normalization model it causes issues.
Im trying now with batch normalization.

Yeah, batch works but lower quality and/or bigger model.

Hm i also had to turn is_bgr to false.

For appropriate conversion may be you need to implement InstanceNorm layer by yourself like I did in sample converter but using another algorithms than InstanceNorm3d layer from pytorch.

About instance normalization i ended up using this pytorch https://github.com/abhiskk/fast-neural-style implementation, and its instance normalization works straight off the bat.
class InstanceNormalization(torch.nn.Module):
    """InstanceNormalization
    Improves convergence of neural-style.
    ref: https://arxiv.org/pdf/1607.08022.pdf
    """

    def __init__(self, dim, eps=1e-9):
        super(InstanceNormalization, self).__init__()
        self.scale = nn.Parameter(torch.FloatTensor(dim))
        self.shift = nn.Parameter(torch.FloatTensor(dim))
        self.eps = eps
        self._reset_parameters()

    def _reset_parameters(self):
        self.scale.data.uniform_()
        self.shift.data.zero_()

    def forward(self, x):
        n = x.size(2) * x.size(3)
        t = x.view(x.size(0), x.size(1), n)
        mean = torch.mean(t, 2).unsqueeze(2).unsqueeze(3).expand_as(x)
        # Calculate the biased var. torch.var returns unbiased var
        var = torch.var(t, 2).unsqueeze(2).unsqueeze(3).expand_as(x) * ((n - 1) / float(n))
        scale_broadcast = self.scale.unsqueeze(1).unsqueeze(1).unsqueeze(0)
        scale_broadcast = scale_broadcast.expand_as(x)
        shift_broadcast = self.shift.unsqueeze(1).unsqueeze(1).unsqueeze(0)
        shift_broadcast = shift_broadcast.expand_as(x)
        out = (x - mean) / torch.sqrt(var + self.eps)
        out = out * scale_broadcast + shift_broadcast
        return out

@AndreJFBico sounds great! May you'd like to make a PR for your pytorch models support and instance_norm layer?

@AndreJFBico can you please provide the modified torch2coreml code for direct conversion from PyTorch pre-trained model to CoreML?

@AndreJFBico You mean use https://github.com/abhiskk/fast-neural-style implementation to train models
and convert pytorch to coreml? Could you please provide the modified torch2coreml code for direct conversion from PyTorch pre-trained model to CoreML?

@engahmed1190 I got the right result while running your torch model but got a error "ValueError: expected 5D input (got 4D input)" when I want to convert torch pre-trained model to CoreML

@engahmed1190 I got the same problem "Torch model present a good output while the CoreML model changes the main picture color" and the new CoreML model is about 6M while the old ones are about 2M.

@engahmed1190 Did you finally succeed?


Configure URL redirection for popular Kuzu links

If you search for Kuzu, there currently are some more popular links pointing to blog entries under old URL:

https://news.ycombinator.com/item?id=33609082
https://news.ycombinator.com/item?id=34959895
https://news.ycombinator.com/item?id=34358912
https://news.ycombinator.com/from?site=kuzudb.com

which point to https://kuzudb.com/blog/xxx.html.
For example https://kuzudb.com/blog/what-every-gdbms-should-do-and-vision.html
, but current URL is https://kuzudb.com/docusaurus/blog/what-every-gdbms-should-do-and-vision/.
To keep links online and spread the word for Kuzu, I'd suggest to redirect URLs https://kuzudb.com/docusaurus/blog to https://kuzudb.com/blog (shorter) and also forward/strip off trailing *.html.
Edit: Also https://kuzudb.com/docs/blog -> https://kuzudb.com/blog

Thanks @sapalli2989. This is a good advice. We should do this.

Prior to deployment of the new blog website I have set up a redirection to make sure that the old links still work (https://github.com/kuzudb/kuzudb.github.io/tree/main/blog). However, currently we cannot get rid of the docusaurus prefix easily as the website is actually two sites glued together: the front page is raw HTML and the docs and blogs are a separate React.js website managed by docusaurus. We need to redesign the front page with React.js and migrate everything to docusaurus in order to get rid of the prefix.

I think the effort is a bit too much to do this soon, I'm closing this issue for now but thanks a lot for pointing this out.


Dockerized layoutparser

https://github.com/allenai/scholar/issues/28666
Docker container and integration tests for mmda/predictors/lp_predictors.py

Basic template copied from s2agemaker-template into services/predictors/layoutparser
Moved Docker container context to top level, so we can copy in the mmda code from the local source tree
No shared code yet between projects withinservices
The layoutparser predictor produces BoxGroups which are an Annotation, but the Document class doesn't yet have a way to add them; it only manages SpanGroups, so the API response cannot be deserialized into a Document
Images are passed to the API as an array of base64-encoded images, one per page.

@kyleclo @lolipopshock are we intending for Document to keep track of Box annotations in addition to span annotations?

Per discussion, decided to let the docker build pull in the mmda code from the current commit.


Add button to close scope inspector

VSCode Version: Code - Insiders 1.9.0-insider (fcac9b686abe4292e69a774f61c8c4ce17768bf5, 2017-01-31T02:07:54.028Z)
OS Version: Darwin x64 15.6.0
Extensions:

Extension
Author
Version

vscode-eslint
dbaeumer
1.2.2

tslint
eg2
0.8.1

debugger-for-chrome
msjsdiag
2.5.0

vetur
octref
0.2.1

language-stylus
sysoev
1.6.0

vim
vscodevim
0.5.2

Currently there is no way to close it. Only switching to another tab seems to do it.
Maybe add a close button or use ESC for closing it?

PR welcome.


Scale format-value event crash (invalid pointer)

Following code causes an invalid pointer crash (tested with refc, arc and orc garbage collector) .
I've tested it with gintro 0.9.3 and 0.9.4, using Nim version 1.4.8.
Example:
import gintro/[gtk, gobject, gio]

proc onScaleFormatValue(self: Scale, value: cdouble): string =
  return "My formated string"

proc appActivate(app: Application) =
  let window = newApplicationWindow(app)
  window.defaultSize = (250, 50)
  let adj = newAdjustment(1, 1, 4, 1, 1, 1)
  let scale = newScale(Orientation.horizontal, adj)
  scale.digits = 0
  window.add(scale)
  scale.connect("format-value", onScaleFormatValue)
  window.showAll()

proc main() =
  let app = newApplication("org.gtk.example")
  connect(app, "activate", appActivate)
  discard app.run()

main()

Output:
Hint: /home/dankrad/Desktop/testsliderformat  [Exec]
munmap_chunk(): invalid pointer
Traceback (most recent call last)
/home/dankrad/Desktop/testsliderformat.nim(21) testsliderformat
/home/dankrad/Desktop/testsliderformat.nim(19) main
/home/dankrad/.nimble/pkgs/gintro-0.9.3/gintro/gio.nim(31002) run
/opt/Nim/lib/core/macros.nim(559) connect_for_signal_cdecl_activate2
/home/dankrad/Desktop/testsliderformat.nim(14) appActivate
/home/dankrad/.nimble/pkgs/gintro-0.9.3/gintro/gtk.nim(2991) showAll
SIGABRT: Abnormal termination.
Error: execution of an external program failed: '/home/dankrad/Desktop/testsliderformat '

The crash is not really surprising.
https://developer.gnome.org/gtk3/stable/GtkScale.html#GtkScale-format-value
The user function returns a char* which is then freed by glib. That is a very special case, most user functions return nothing or a bool value only.
Note that this signal has vanished in GTK4. So we need a special handling for this signal in GTK3 and for GTK4 we would need a macro similar like the idleAdd() macro in gimplgob.nim.

For the returned cstring the fix seems to be easy, we just have to call g_strdup() on it so that glib can free it with g_free. Will provide the fix tomorrow. Well only for GTK3, for GTK4 we need a macro.

Should be fixed for GTK3. Try with
nimble uninstall gintro
nimble install gintro@#head
For GTK4 we have to create a macro instead. And there seems to exist a few connect() user functions which returns gobject structs, for which I am unsure if they work. But I will delay that investigation until someone really uses one of them.
I think I will create the GTK4 macro in the next few days, as it should be easy, and we have above test code. But it is ugly that we need so many separate macros, we should try to find a better way.
Note that in your code above you can use Nim float instead of cdouble. For the current Nim implementation float is identical to cdouble, and generally gintro bindings should always work with float.

Everything works and thank you for clearing up, that float and cdouble is identical in nim. I'll fix it.
For those who are connecting to low level events with Builder, you need to duplicate the cstring with g_strdup, like this:
proc onScaleFormatValue00(self: ptr Scale00, value: float): cstring {.exportc, cdecl, dynlib.} =
  return g_strdup("My formatted string")

Thank you!

Should be fixed in v0.9.4 now.
Will close this issue, please reopen if necessary.


Added a CyberChef plugin

Added a CyberChef plugin

Update plugins.json

Cyberchef is a web-based, feature-rich coding suite framework. My plugin allows users to quickly send queries to a custom built CyberChef page efficiently.

how's it going? I tried your plugin, when the website opens it looks like the query string has been passed through but then the site seems to have reloaded and the string was lost. It works however if I hardcoded in the url into main.py

I'm sorry I wasn't aware of this bug. I tested the plugin with self-hosted CyberChef set up, so I didn't notice a type error in determining the fallback to the default site.
This issue has been fixed and the release of my plugin repository updated. Maybe you can try again.

Hi @gamous , I am still getting the same behaviour as before after downloading the new updated zip. You can test as well with pm install https://github.com/gamous/Flow.Launcher.Plugin.CyberChef/releases/download/v1.0.0/Flow.Launcher.Plugin.CyberChef.zip

Hi~ @jjw24,thank you for your patience. I fixed the behavior of the contextmenu and then used this command to uninstall and install several times to test. I'm sure this plugin works now.

Hello @gamous!
Is the newest version still 1.0.0?
If not the manifest still points to the older (non-working?) version.

Hi @Garulf ～ Yes. The newest version is still 1.0.0. I delete older and reuse the same version tag to release current zip. I thought it was reasonable to remove release that didn't work, without having to change my manifest pr submission. In other words, the submission in this pr still points to a well-worked version now.

Hi @gamous, I just tested the plugin, running the query cf hello, still the same result, website opens but still opens up as https://gchq.github.io/CyberChef/. Have I missed something?

Hi~ @jjw24. I am ashamed of this bug. You're right, it's a function issue and I don't notice. In fact, I noticed early on that the problem was URL redirection due to "=" so strip was added to remove the "=" at the end. However, due to an error, I did not find that the wrong version was submitted. I tested the release using an integer multiple of the payload so that no problem was triggered. The release file is updated.

Hi~ @jjw24. I am ashamed of this bug. You're right, it's a function issue and I don't notice. In fact, I noticed early on that the problem was URL redirection due to "=" so strip was added to remove the "=" at the end. However, due to an error, I did not find that the wrong version was submitted. I tested the release using an integer multiple of the payload so that no problem was triggered. The release file is updated.

All good, no stress :)


[DS-2396] Checksum checker and bitstream.user_format_description

This is a possible fix but is currently UNTESTED, I avoid the use of overly complex queries which nobody can read.
http://jira.duraspace.org/browse/DS-2396

+1 I've verified the bug, and verified that this PR fixes it.  Prior to this PR, the checksum checker doesn't work at all in 5.0. It now works again.  Will merge shortly


chore(cancel-redundant-workflows): tidy output from cancellations

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/ankorstore/toolbelt?version=dev:d9ac84e25fce0434545e9196277532dd6f75d135

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/ankorstore/toolbelt?version=dev:01cc7e40268bd17aab229821c083dd90ff58d0cd

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/ankorstore/toolbelt?version=0.7.3


fix: Add deletion policy database

Adding deletion_policy setting - abandon. This will allow for the solution to destroy on the first try

Lint issues were fixed in https://github.com/GoogleCloudPlatform/terraform-google-three-tier-web-app/pull/13/commits/fde60533788a72048306198e33029fc673957053


Update README.md

Hi @markjdugger -- can you review and comment if you think this is clearer? Thanks!

@TADraeseke I made edit suggestions above. I matched the wording with what we are using in the Android tutorials. (The Android tutorial changes are not merged yet, but you can see what we intend by examining the modified Java tutorials, already on the public website:

https://developers.arcgis.com/java/maps-2d/tutorials/display-a-map/#create-a-new-java-project-with-gradle

IntelliJ IDEA and Android Studio, both from JetBrains, have very similar UI, so it makes sense to use the same wording for both Java and Android.

Cool! I like you wording better. Made those changes.


Default signature attached for accounts without signature specified

I have a signature specified for one of my accounts, but have nothing for my other accounts (I prefer not to have signatures on personal emails). However, when I try to send a message with one of these accounts with no signature specified, the defualt Nylas signature is still attached. Is this a bug, or is there a setting I am missing?
Running 1.0.15 on mac OS 10.12.3

Also running into this error. Just moved to Mail from Pro.
Version 1.0.21 (1.0.21) / MacOS 10.12.3

I'm still running into this in N1 version 1.5.0 and Nylas Mail 1.0.32.

This should be fixed in 1.0.32 but sadly still in 1.5.0 :(

@sachinag  Could I use 1.0.32 as a pro user? What's the difference anymore?

http://nylas.com/pricing has the differences - You can use 1.0.32 if you prefer, but a lot of those features aren't there.

 I give up Nylas, it was fun while it lasted, but I'm going to greener pastures.


feat: full implementation of partial evaluator

Closes #603
Summary of Changes
Fully port the partial evaluator from Xtext to Langium. The Langium implementation now has all the features of the previous version (and many more).

:tada: This PR is included in version 0.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
npm package (@latest dist-tag)
v0.5.0
GitHub release

Your semantic-release bot :package::rocket:


Hypervalent N/O/F don't return HypervalentAtom

I've been thinking about corner cases because I've been putting together the unit tests for oxmol, and atom::Atom::build happily accepts NH5, OH6 and FH7 without returning HypervalentAtom.
I have a fix that works, but I'm not sure if it's the best way to handle it. This preserves the ability to represent PF5, SF6 and IF7.
in element:.rs, adjust the valence electron counts for the offending atoms:
impl Element {
    pub fn valence_electrons(&self) -> u8 {
        match self {
            // ...
            Element::N =>  3, // 5
            Element::O =>  2, // 6
            Element::F =>  1, // 7
            // ...

in atom::Atom::build, re-add the missing electrons after adding hydrogens:
        match element {
            Element::N => nonbonding_electrons += 2,
            Element::O => nonbonding_electrons += 4,
            Element::F => nonbonding_electrons += 6,
            _ => ()
        };

I don't know how neon is supposed to behave, but I think anyone representing noble gasses is likely to know their quirks anyway.

The valence electron count is designed to count all electrons in the valence shell. For nitrogen bound to three carbons, the count should be 2, for example.
This is to ensure that all molecular properties can be computed in a consistent way. For example, if you wanted to know whether a nitrogen was a lone pair donor, it would be difficult to do that if it had zero nonbonding electrons.
What you're getting at is worthwhile. Nitrogen with 5 hydrogens is weird. But it doesn't break any rules - other than regularly observed bonding behavior.
That said, a function called validate_hydrogens could work. It would accept a Molecule and for each atom check that the hydrogen count conformed to a particular view of bonding regularity.
It might not be universally applicable, however. Each research group may have a different idea of what represents bonding regularity.
The tradeoff I made in Molecule.rs was to allow anything up to and including consumption of all valence electrons. Past that, and you get an error.

That makes sense, it's a good idea to leave the valence electron counts alone, it was just the first solution that came to mind. I might emit a warning for these three in Python. A validation function could be useful, but you're right that deciding what is 'normal' might be difficult
As alternative solutions, I think enforcing the octet rule or checking the hybridisation state would work:

For the S and P block elements, Atom::build and Atom::add_bond could check that the octet rule isn't violated. This won't work for the transition metals because of dative bonding, and would need to use electronegativity to assign which atom in a bond gains/loses the electron. Leads to different behaviour for negative charges (e.g. we can make Ti20-, but P20- is a violation)
If NH5/OH3/FH2 are considered as hybridisation failures rather than valence errors, it would also be possible to catch them by checking the number of orbitals available to each element against the sum of the bond multiplicity + number of hydrogens + number of lone pairs.

Both of these feel like heavy-handed solutions for only three exceptions, though. In line with 'be liberal in what you accept', the current behaviour is preferable. I'll close this for now, if hybridisation/VSEPR shape are implemented later and the code for this is in place it might be worth revisiting.


Encrypting connections while replicating from a managed instance to an Azure DB

Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
We use GitHub issues as the primary channel for customer and community feedback about the Azure documentation.
Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[ ] The relevant Azure service or technology.
[ ] A link to the published documentation article that you have feedback about.
[ ] Clear, specific feedback that the author can act on.

Pull requests and article contributions
If you know the change that is needed in an article, we encourage you to submit the changes directly using a pull request. If the change is large, or if you want to contribute an entire article, follow these guidelines:

[ ] Don't surprise us with a big pull request or a pull request with a new article! Submit an issue that describes the details of the proposed large change or new article.
[ ] Include the service or technology area.

We'll route the issue to the appropriate content team for review and discussion.
Tech support and product feedback
If you would like to contact Microsoft about other things, such as product feedback or tech support, please review these guidelines:

If you need technical support using Azure, the paid and free support options are described here: https://azure.microsoft.com/support/options/.

Each article in the Azure technical documentation contains a product feedback button - it's best to submit product feedback directly from a relevant article. Otherwise, you can submit product feedback for most Azure products in the following product feedback forum: https://feedback.azure.com/forums/34192--general-feedback.

Hello,
I've successfully set up replication from my managed instance to an Azure SQL database using this article.  However, when I do a Vulnerability Assessment, I get the following failure:
VA1220 - Database communication using TDS should be protected through TLS
This is for Named pipe and TCP.
Further investigation shows that these connections are for replication.  As there is no SQL Server Configuration Manager in Azure, I can't enforce encrypted connections there.
Is there a way to encrypt my connection between my Managed instance and my SQL Azure database for replication?
Jim

@jdneilso Can you please provide us the URL of the Azure doc that you are having issues with? We look forward to your reply.

@jdneilso Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly reopen the issue and continue the discussion.


Implement the new command run-locally

The main advantage is that it supports executing interactive commands, including runme-in-runme, and pipes (|).
On top of that, there is the new package internal/command. It gives a better interface to create commands, as well as unifies the idea of a program config that now is defined in a proto file.
runme run-locally is not an equivalent of runme run. It's to be decided how these two can be merged. run-locally is hidden from the runme usage.
runme run-locally
This is a new command. It does not support many flags known from runme run, but it can be used to test the new capabilities like piping and REPLs as showed below.
run-locally [command1 command2 ...] also changes the approach to selecting commands. You can pass multiple of them separated by space. Additionally, glob names are supported like print-* which will execute all commands starting with print-.
Piping can be tested with the following script:
```sh {"name": "pipe"}
cat - | tr a-z A-Z
```

And run like this: echo test | go run . --filename test-run-locally.md run-locally pipe.
You can also run Python repl:
```sh {"name": "python"}
python
```

go run . --filename test-run-locally.md run-locally python
And runme-in-runme:
```sh {"name": "runme"}
runme --filename test-run-locally.md ls
```

go run . --filename test-run-locally.md run-locally runme
Config
The commands, either created programmatically or created in a service from user's input, are now based on a structure described in config.proto. This config contains all details to create the runnable command the only variable is I/O.
internal/command package
Firstly, it implements utilities around the command config, including parsing a code block to config.
Secondly, there are two implementations of commands which differ how they are execute:

Native uses OS stdin, stderr, and stdout
Virtual uses a pseudo terminal

runmev2alpha1
There is also a new service registered on the same server. It has the same methods to manage sessions and Execute() to run commands. The difference is the request message, which now contains the Config message described above.
It also contains a new method ResolveEnv() which takes a script or a list of commands, detects environment variables in them, and tries to resolve them using project, session, or provided env in the request.

Most minor comments. One thought I had was to rename ResolveEnv to ResolveExport(s) since they are ENVs but specifically the once that are exported. I think that would resolve overloading the ENV terminology. Wdyt @adambabik?
Outside of that, I'd suggest we get this merged before I try integrating it with the extension. Treat any issues/requests as separate issues after.

On further examination, I understand now that ResolveEnv, in fact, returns all ENV vars, not just the exports inside of the script/command, which invalidates the point I was making.

Most minor comments. One thought I had was to rename ResolveEnv to ResolveExport(s) since they are ENVs but specifically the once that are exported. I think that would resolve overloading the ENV terminology. Wdyt @adambabik?
Outside of that, I'd suggest we get this merged before I try integrating it with the extension. Treat any issues/requests as separate issues after.

On further examination, I understand now that ResolveEnv, in fact, returns all ENV vars, not just the exports inside of the script/command, which invalidates the point I was making.

No, it should not return all env. It should return only ones that are explicitly exported in the script or commands list.
With regard to your suggestion, I was thinking that maybe we can extend the functionality it in the future so that not only export ENV are recognised, but other variables usage like ${ENV} as well. Still, I think you're right that ResolveEnv is not the best name. Maybe ResolveVariables?

No, it should not return all env. It should return only ones that are explicitly exported in the script or commands list.
With regard to your suggestion, I was thinking that maybe we can extend the functionality it in the future so that not only export ENV are recognised, but other variables usage like ${ENV} as well. Still, I think you're right that ResolveEnv is not the best name. Maybe ResolveVariables?

Gotcha. I'm playing around with this a bit more today/tmrw. Lemme get back to you on the name change. Perhaps ResolveVariables or ResolveVars is a better choice. I will let you know soon.

I added an integration test which validates that ResolveEnv does not return not exporter vars.

No, it should not return all env. It should return only ones that are explicitly exported in the script or commands list.
With regard to your suggestion, I was thinking that maybe we can extend the functionality it in the future so that not only export ENV are recognised, but other variables usage like ${ENV} as well. Still, I think you're right that ResolveEnv is not the best name. Maybe ResolveVariables?

Gotcha. I'm playing around with this a bit more today/tmrw. Lemme get back to you on the name change. Perhaps ResolveVariables or ResolveVars is a better choice. I will let you know soon.

OK, so I think it'd like roll with ResolveVars (I'm also ok with ResolveVariables) if vars is too short, @adambabik, please.


Release/dapp v0.7.0

Dapp changelog
[0.7.0]
Changed

use @iexec/dataprotector-deserializer for handling dataprotector v2 protected data

sconify: https://jenkins.intra.iex.ec/job/Scone/job/sconify/job/master/220/

docker publish: https://jenkins.intra.iex.ec/job/Scone/job/publish/job/master/148/


Refator properties taking latest C# features into account

Just want to improve readability of NBitcoin code, by leveraging latest language features. This is just a draft/sample where basically only properties have been refactored. My goal is to go further and contribute to the project by applying best practices I know and make the code readable as a book.

You changed tabs to spaces, please change back to tabs.

@knocte , done

There are still many whitespaces changes that you have introduced, which you should revert, before a proper review can take place.

The space after if () and for () I like, but it's not consistent with the rest of the project.

@ArturKarbone I've reviewed your changes and they are mostly ok to me (there are just some details to review changes in the access modifiers for setters from public/internal to private). However, it is important follow the stablished coding style. Mixing (unintentionally) with spaces and tabs is something that many contributors have done (me too so, you are not the first one).
On the other hand, it is also important to have in mind that reviewers need to see your changes as clear as possible, and in your last commit it is no possible to do that because the comparer shows every line red on the left panel and every line green on the right panel as two completely different content.
NBitcoin is a very friendly project to join and maintainer @NicolasDorier is also very open to many changes, but not to all ofcourse. Please fix the commit and wellcome!

@Derrick- spaces after if()/for() have been removed
@lontivero - Thanks for the explanation. Completely agreeing with You now, that looking at commits are too hard since I changed from tabs/spaces back and forth. I suggest looking directly at file changes https://github.com/MetacoSA/NBitcoin/pull/244/files.
Another suggestion to all the contributors is to share Visual Studio profile for the project ( with a link somewhere in Read.ME), to avoid such situations for newcomers. I think I will create an issue for that.
Thanks

spaces after if()/for() have been removed

Nitpick: you're still missing a space change in a while call.

I suggest looking directly at file changes

That's a good workaround to be able to review easily. But ideally your change should only be in one commit before it is merged. You can squash all your 3 commits in one with git rebase -i HEAD~3 command (which will prompt an editor and you will have to mark the last commits as "f", for fixup).
In regards to the changes of the pull request, IMHO it's useful to have automatic properties (less boilerplate code), but I don't see much value in changing get-only properties from getter syntax to lambda syntax.

I think its is ready for another round of review

@lontivero just improved readability of Linq expressions and leveraged IsEmpty usage

cool, just some more spaces. Left, then I merge

@NicolasDorier done. Should I rebase intermediate commits?

that is ok I can squash commit


Enables linting via SwiftLint

Also adds configuration file that disables most of the default rules. These will be enabled individually to aid in discussion and review of resulting changes.

@qsmmorgan We have approval to move forward with this, so please re-approve when you get a chance.


feat: use API key for server-to-server scenario

For a server to server scenario, support for API key authentication could be an option. This is to avoid manual negotiation and refreshing of oauth token.
For the tooling to generate / rotate API key:

add a section in the app, around Settings, could be a subsection: Developer settings -> user can generate / rotate API keys there. Maybe also see some API usage statistics
add API key generate / rotate in CLI
add API endpoint to store the key
add a way of initialisation of akord-js with API key - API key should only allow to access the API in user account / organisation context. API key should not be a replacement of password / backup phrase. On the server akord-js can be initialised with:

API key - if access to API is needed (to access the API without token refresh)
backup phrase - if de/-encryption is needed

@rcaetano mentioned analytics for org use case - I think this is great idea. I'm thinking "Settings" could become "Account" and hold "Developer settings" as you suggest when applicable, but also include an "Analytics" tab, which we can develop for paying clients


run opm in one docker layer

@jonpspri take a look at the additional updates and let us know what you think.


Fetching work-items happens multiple times instead of once

This happens because a single context change results in multiple spaceChanged events. We need to get it down to one.


Some important zoom feature didn't find yet

Hi, thanks for this awesome library. I use this for my apps but, i think i need this kind of features.

After user zoom the image, the user click back button (or onBackPressed called) to return normal size (like first rendering)
Listener for zoom and also access foom event without pitch the screen. Suppose that i created button in corner with zoom in and zoom out i want that will be alternate of pitch zoom.

Sorry if i requested too much, but i think i didn't find these feateure yet.

PR is welcome!


[PLUGIN] Column visibility

First of all, thank you for this great tool! In the last two weeks i decided to write  some plugins for ng-table.The first plugin can handle visibility from columns in a drop down. You can find an example if u click on this link: http://nucle.github.io/examples/ng-table-plugins/colvis/complete_colvis_example.html
My github project site: https://github.com/nucle/ng-table-plugins

Hey, good stuff.

Thank you!
How can i get the rows outside from ngTable?
I want to write an export plugin.

There's already a plugin for this: https://github.com/esvit/ng-table-export
I intend to get the original demo for this plugin added back to http://ng-table.com/. In the meantime, the original demo for this can be found here: https://github.com/esvit/ng-table/blob/master/examples-old/demo15.html

Tanks but I know of it. I want to add more functionality like:

pdf, xlsx, csv and print export
Furthermore i want to export the whole table ( https://github.com/esvit/ng-table-export/issues/8 ) and i think it would be better to get the rows directly from ngTable. Maybe over binding like the columns or a getter, so i dont have to parse the html table and do not need to manipulate the count parameter.

Do you think it would be possible to get this getter/binding?
Thank you.

There is one very easy way of getting all the rows from NgTableParams directly:
var existingDataset = tableParams.settings().dataset

BUT, that only works if the table is being assigned a dataset eg: http://ng-table.com/#/loading/demo-managed-array

Thank you, i will try it.


handy Unique list

#1050
#1049
#1048
#1047  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Cobalt0s and the rest of your teammates on  Graphite

#1050
#1049
#1048
#1047  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Cobalt0s and the rest of your teammates on  Graphite


fix in delayed touchpad press - time reset

As always, thanks for taking the time to work on this.
That said, I have mixed feelings about smoothing the optical position. That is supposed to be what the positional filters are for. If we smooth the optical position then we are effectively doing double smoothing on the controller position.
Also this change is about to be made moot by the kalman filter. I have the Kalman filter working for the DualShock4 and it is really close to working for the PSMove. There is a bug in the noise calibration tool that currently prevents me from getting a proper noise measurement for the PSMove, but one more night of work and I should have the Kalman filter ready for you to test.
If after you try out the Kalman filter and you feel like it doesn't fix your tracking well then we can add your optical tracking smoothing solution (though I have some changes to suggest if we go that route).


Custom dataset causes overflow error

Hi, thanks for the great work.
My custom point cloud range is max= [ 39.4270,  41.9689, 153.3401] and min= [-63.4741, -32.5176,  13.7472]. This causes the following line to cause an overflow error :
https://github.com/Pointcept/PointTransformerV3/blob/342656c7956fc1ff59a13e0969bb858003882f49/serialization/hilbert.py#L143
The error is : RuntimeError: self.stride(-1) must be 1 to view Long as Byte (different element sizes), but got 15000
I'd appreciate any help/suggestion on how I can go about resolving this. Should I scale my point clouds?
Thanks in advance

Hi, if it is an object-level point cloud, please scale it. If it is a real-world scene, please increase the grid size.

Hi,
Thank you for the response. I saw your config files where a number of transformations have been applied (including hashing of the grid coordinates). I intend to fine-tune your model on my data (which consists of real-world data of the form [N,3]). Can I do it with just the raw coordinates? Also, since PTV3 pretrained model weights require 6 input channels, how should I go about dealing with that?
Thanks in advance

Hi, thanks for the great work.
My custom point cloud range is max= [ 39.4270, 41.9689, 153.3401] and min= [-63.4741, -32.5176, 13.7472]. This causes the following line to cause an overflow error :
https://github.com/Pointcept/PointTransformerV3/blob/342656c7956fc1ff59a13e0969bb858003882f49/serialization/hilbert.py#L143
The error is : RuntimeError: self.stride(-1) must be 1 to view Long as Byte (different element sizes), but got 15000
I'd appreciate any help/suggestion on how I can go about resolving this. Should I scale my point clouds?
Thanks in advance

Hi,
In my case it was because the tensor locs.long() was not contiguous in memory which is required by view().
You can fix that by making your tensor contiguous in your code or directly like this :
locs_uint8 = locs.long().contiguous().view(torch.uint8).reshape((-1, num_dims, 8)).flip(-1)
Hope it can help !

Hi,
Thank you for the response. I saw your config files where a number of transformations have been applied (including hashing of the grid coordinates). I intend to fine-tune your model on my data (which consists of real-world data of the form [N,3]). Can I do it with just the raw coordinates? Also, since PTV3 pretrained model weights require 6 input channels, how should I go about dealing with that?
Thanks in advance

Hi I think best choice is re-pretrain our PTv3 with single coordinate as input with our PPT settings.

Hi, thanks for the great work.
My custom point cloud range is max= [ 39.4270, 41.9689, 153.3401] and min= [-63.4741, -32.5176, 13.7472]. This causes the following line to cause an overflow error :
https://github.com/Pointcept/PointTransformerV3/blob/342656c7956fc1ff59a13e0969bb858003882f49/serialization/hilbert.py#L143
The error is : RuntimeError: self.stride(-1) must be 1 to view Long as Byte (different element sizes), but got 15000
I'd appreciate any help/suggestion on how I can go about resolving this. Should I scale my point clouds?
Thanks in advance

Hi,
In my case it was because the tensor locs.long() was not contiguous in memory which is required by view(). You can fix that by making your tensor contiguous in your code or directly like this : locs_uint8 = locs.long().contiguous().view(torch.uint8).reshape((-1, num_dims, 8)).flip(-1)
Hope it can help !

@AxelCole Thx!


Fish is stretchable

When grabbing a fish with both arms, you can pull them apart to stretch the fish. This should not happen.

This is probably something to do with the grabbing physics.

Fixed this ancient curse. Good riddance!


Segmentation fault: 11

After including node-neat and when using this...
var app = new EmberApp({
  sassOptions: {
    includePaths: require('node-neat').includePaths
  }
});

I get seg faults when trying to access these from my scss file...
@import "bourbon/bourbon";
@import "neat-helpers";
@import "neat/neat";

Serving on http://<IP_ADDRESS>:4200
Segmentation fault: 11

Any trick to getting this to work with the CLI?

We're getting this error again: https://travis-ci.org/ilios/frontend/builds/49666398

This is definitely an issue with node-sass, ember-cli-sass is a thin wrapper around node-sass (via broccoli-sass - also a thin wrapper).

I'm getting this with 3.1.0.
$ ember serve
version: 0.2.0
Livereload server on port 35729
Serving on http://localhost:4200/

zsh: segmentation fault  ember s

The app compiles fine (apart from the scss, obviously) if I take ember-cli-sass out of my package.json. I guess this is related to the node-sass bug, but I thought using 3.1.0 would fix it.
Have tried rm -rf node_modules folder, npm cache clean, switching versions of node (0.10.30 & 0.12.0) and nothing.
Maybe my package.json file is useful? Just picking up this project again after it being dormant for a few months - upgrading from<EMAIL_ADDRESS>to 0.2.0, so a bunch of things have just been updated, but this is the only thing that seems broken.
{
  "name": "paz-ember",
  "version": "0.0.0",
  "description": "Small description for paz-ember goes here",
  "private": true,
  "directories": {
    "doc": "doc",
    "test": "tests"
  },
  "scripts": {
    "start": "ember server",
    "lint": "jshint app config",
    "build": "ember build",
    "test": "ember test"
  },
  "repository": "",
  "engines": {
    "node": ">= 0.10.0"
  },
  "author": "",
  "license": "MIT",
  "devDependencies": {
    "broccoli-asset-rev": "^2.0.0",
    "ember-cli": "^0.2.0",
    "ember-cli-app-version": "0.3.2",
    "ember-cli-babel": "^4.0.0",
    "ember-cli-dependency-checker": "0.0.8",
    "ember-cli-htmlbars": "0.7.4",
    "ember-cli-ic-ajax": "0.1.1",
    "ember-cli-inject-live-reload": "^1.3.0",
    "ember-cli-qunit": "0.3.9",
    "ember-cli-sass": "3.1.0",
    "ember-cli-uglify": "1.0.1",
    "ember-data": "1.0.0-beta.15",
    "ember-export-application-global": "^1.0.2",
    "ember-validations": "^2.0.0-alpha.3",
    "express": "^4.8.5",
    "glob": "^4.4.2",
    "precommit-hook": "^1.0.7"
  },
  "precommit": [
    "lint"
  ]
}

:sos:

More digging, looks like the node-sass bug was reintroduced in 2.0.1 which broccoli-sass is using. Will see if I can override it later.

I still have this issue, right after installing ember-cli-sass. Any workaround or solution?

@darioghilardi this is certainly going to be a node-sass issue, have you tried using<EMAIL_ADDRESS>You should be able to get this by reinstalling ember-cli-sass.

Cannot get past this error and if I switch things around I'm getting the infamous Bus error: 10
I'm running latest io.js and brew install libsass --HEAD

@joshuairl, there's really nothing ember-cli-sass can do about this - it's a problem with node-sass. Here's what I'd do:

npm install --save<EMAIL_ADDRESS>If that doesn't work then try rm -rf node_modules && npm cache clean && npm install
If you're still having problems then post your issue on node-sass

Good luck!

I had the same issue in my ember project (with yarn workspaces - not sure if that is relevant to the issue).
I tried clearing out tmp and node_modules folders, but was still receiving the SIGSEGV error.
Running the build with the DEBUG=* flag I found that it died right after compiling certain files. If I deleted the whole folder, where it was dying (containing scss files that were doing @imports) and keeping other folders with similar scss files, it would build.
I was never able to debug the libsass process itself (so deeply nested in the node_modules), but after cloning a new instance of my repository (moving over my .git-folder) everything worked again.
I hope this helps others in a similar situation!


⚠ Legistar has degraded performance

In 019758d, Legistar (https://santaclara.legistar.com/) experienced degraded performance:

HTTP code: 200
Response time: 12379 ms

Resolved: Legistar performance has improved in 5253ea7 after 10 minutes.


h264: SPS update race

The end of the current picture cannot be detected before the next one starts, but before this we may have parsed a new SPS through peek_sps. If this happens, we will finish the current picture with the new SPS, which can cause inconsistencies, like the DPB not being bumped because the new max number of reference frames has increased.
In order to fix that, the current picture should keep a reference to its PPS from its creation time, and each PPS should have a reference to their SPS. Putting SPS and PPS into Rc sounds like a good way to achieve this.

Fixed by 4e94840.


New version: Joplin.Joplin version 2.12.15

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: Open in CodeFlow

Reset PR

@vedantmgoyal2009 Should this PR also remove
https://github.com/microsoft/winget-pkgs/tree/master/manifests/j/Joplin/Joplin/Pre-release/2.12.15
to avoid having v2.12.15 in releases and in pre-releases ?

https://github.com/microsoft/winget-pkgs/pull/119017


chore(go): code generation for extensions

Interfaces extended by other interfaces will be generated as embedded interfaces; for datatype interfaces, the properties will be flattened by the struct proxy. Also add code generation for setter methods on classes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 7283f3cab0b2e0c2de485dee9fef8c67d6d5ac2e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Guard against null ref when a Glob exclude fails to match any files

test.txt
I've included a sample project file that would cause a null ref in src/Shared/FileMatcher.cs. I looked around inside GetFilesRecursiveStep to see if Files should have just been set to an empty array, but it didn't appear to match stylistically with the surrounding code so I just put the guard in GetFilesRecursive.

@dotnet-bot test Ubuntu14.04 Build for CoreCLR please

Can you please:

find out why that value gets to be null (probably the true source of the bug), and then see if you can fix the bug at object creation rather than usage, since that null value might flow to other usages under different execution paths
write a unit test exposing the crash. You can use this test as a reference: https://github.com/Microsoft/msbuild/blob/xplat/src/XMakeBuildEngine/UnitTestsPublicOM/Definition/ProjectItem_Tests.cs#L624

I've added the unit test to the pull request. Fixing the root of the null is very simple, but every other use of this property was already guarded by a null check, do you want me to prevent null coming out and remove all of the (now redundant) call site null checking?

@hippiehunter
Took a closer look. Let's leave it as is, since it looks like the safest option. This is the meaning of not null: https://github.com/Microsoft/msbuild/blob/xplat/src/Shared/FileMatcher.cs#L817-L826
Otherwise, looks good to me. @Microsoft/msbuild-maintainers ?

LGTM
@dotnet-bot test Windows_NT Build for Desktop please

Thanks, @hippiehunter!


Xamarin Azure Notification Hubs Intermittent iOS device registration issues

Xamarin Intermittent iOS device registration issues on Azure Notification Hubs
I have worked with Microsoft on this issue (case<PHONE_NUMBER>01604) and Microsoft has claimed that this Azure Notification Hubs intermittent iOS device registration issue is due to a problem with Apple iOS.  The work around is to install the application using the devices Cellular Network (non-Wifi) otherwise the app will experience this issue.
https://developer.apple.com/forums/thread/128172
I believe Microsoft should be forthcoming about this and explain the issue in the Azure Notification Hub sample code README.md file.  Doing so will save developers a lot of frustration, wasted time and money...and, more importantly "confidence in you".
"If" this is a known issue and "if" it is out of your control so solve it, you must tell us about the issue.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 92f390d9-cbd0-ab8c-6c8c-49df76d1b8e0
Version Independent ID: 15739c2f-afbb-c21d-b96f-fabe7060e410
Content: Send and receive push notifications with Azure Notification Hubs and Xamarin.Forms - Xamarin
Content Source: docs/xamarin-forms/data-cloud/azure-services/azure-notification-hub.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @profexorgeek
Microsoft Alias: jusjohns

Hi @donaldashworth
Thanks for pointing this out. I've just updated the sample readme.


Configuration of CMS-Elements in different Languages in the LanguagePack Plugin

PHP Version: 8.3   | Shopware Version: <IP_ADDRESS> and <IP_ADDRESS>  | Affected area / extension: Extension:Language-Extensions

Expected behaviour:
I expected that the image of the second language forwards me to the configured category and that the forwarding of the default languages element is set for all the other languages if no link is set and if its not the first time configuring after the creation of the Element.
Actual behaviour:
I created a new CMS-Page with a normal Image as an CMS-Element. Then I added a link in the default language to a category named e.g. "Cat1". Every Language has their own Storefront. After the first configuration the image forwards me to the wanted category in every Storefront. Then I configured the image in the CMS-Page for a second language so that it should forward me to an other category named e.g. "Cat2". After that I cleared the cache, even though Im in a dev-environment. The Storefront with the default language still has the right link in it but the link in the second storefront wont forward me to "Cat2". It still forwards me to "Cat1". No matter what I do and change, it wont forward me to the Category I configured for this language. Then I changed the link of the image from the default language again to an other category e.g. named "Cat3". After this the imagine in the default language storefront forwards me to "Cat3" but the second language still has "Cat1" in it and it is nowhere configured. I cleared the cache again and still no difference. I deleted the link of the second language in hope it would take the link from the default language but this also doesn´t work.
How to reproduce:
I used <IP_ADDRESS> to test it but it already occurred in <IP_ADDRESS>. My explanation of the actual behaviour describes it good enough to recreate the Problem.

[public] Shopware automated response: This issue is linked to the internal issue: LAN-183
[created from LAN-183, comment 513631]


autoflake removing imports that are used inside eval() function

I have a code in python where i am executing code inside eval like this eval(str(code_config.get("condition")))  now inside my conditions i am using some constant that is imported above the file but autoflake is removing that import as it doesn't consider what can be used inside eval. Please fix this issue if you have the bandwidth.

There's nothing we can do in this case, please add a # noqa to the import line to have autoflake ignore it.
We could try to parse the string passed to eval, but there are no guarantees that that string is available statically, and I'd rather not go that route.


Split cloud providers into separate modules

This PR moves existing GCP scripts to dedicated directory. Also, it adds AWS directory with specific AWS resources. AWS resources are:

Security Group
Autoscaling Group
Launch Template

Closing as it's obsolete


Scripts + Questions List View Tests (Actions + Reducers)

finished scripts list view action tests

next need to add reducer tests

NOTE: no component testing as this will likely need refactor

Action + Reducer testing (for Questions + Scripts List Views)

Created a file to contain all of my client fixtures for each model
[maybe we could put all of the fixtures in one file?]
Created a file with helpers + common code, such as setting up the mock adapter and mock localStorage, a method to check for the correct props, etc.

**Not included: **

component testing, as we may need to refactor.


Update to ice/v3 for config due to breakage in webrtc 3.2.18

pion/webrtc 3.2.18 had a change that pulled in a config from ice/v3 instead of v2. that is causing SFU compilation to fail since protocol already pulled it in.

this is turning out to be more complicated. rolling back webrtc for now


Downcase residua unknown

What does the 'a' mean? It is 'C' of 122 possition in  PDB-1ETR .  Would you mind share some reference about this ? Thank you very much.

Here is 1etr.pdb and 1etr.dssp:
1etr.txt
1etr_dssp.txt

It is a way of mapping connectivity of disulfide bridges. Described in the original DSSP paper and in the current documentation at https://pdb-redo.eu/dssp/about (see the AA section).


Dead link

[Enter feedback here]
Link to  monthly rollup is dead
https://docs.microsoft.com/en-us/troubleshoot/windows-client/deployment/standard-terminology-software-updates.md#monthly-rollup

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b77c40dd-e4d2-90f5-d70a-b0ee4b430136
Version Independent ID: f0ec110b-7938-5e22-d39e-6ded935a9ced
Content: Onboard Windows servers to the Microsoft Defender for Endpoint service
Content Source: microsoft-365/security/defender-endpoint/configure-server-endpoints.md
Product: m365-security
Technology: mde
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@RAJU2529 Thank you very much for the contribution and updating the documentation with PR. @ThijsLecomte Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


SAP Cloud Platform IoT for Neo: Configuring the device for environmental sensors data

Getting 400 message in step 6 "The message doesn't conform to the given message type".

Check for typos in message type and in the message you are trying to post.

Thank you for your feedback. We haven't heard from you in the past 30 days, so we are closing the issue.
If you still have questions, feel free to reopen the issue.


Update Shannon Lal's Contact Information

The following PR will update the contact information for Shannon Lal as I have moved jobs a couple of years ago.

@shannonlal can you sign your commit please (instructions are in the previous comment)

I usually don't do that because it's private information, but if you explicitly give me the permission, I can add your information to the list by doing a PR myself.
In the meantime, I'm closing this one: feel free to reopen it if you can fix it by yourself. Add a comment to give me the permission if you want me to do it :)


Custom Mouse Scrolling on Viewer

Hello to everyone. Can you please guide me how to implement scroll up/down the viewer using my own button in custom tool bar

The viewer uses code like this to move the viewport up and down in response to the up/down arrow keys:
// up arrow
viewer.viewport.panBy(new OpenSeadragon.Point(0, -0.05));

// down arrow
viewer.viewport.panBy(new OpenSeadragon.Point(0, 0.05));

Is that what you meant or did you need help with OpenSeadragon buttons?

It solved my issue. Thanks iangilman

You might need to add this also :
viewer.viewport.applyConstraints();


Remove eslint ignores

We have a few regarding not calling back with error objects: fix them.

Fixed... The errors we were seeing were unrelated. Closing.


AppleSimUtils: replace zombie-enabled workaround with designated flag.

Enable GULGeneratedClassDisposeDisabled environment flag to disable GoogleUtilities' Swizzler from disposing generated classes when executing Detox tests. This flag works with GoogleUtilities v7.7.
This replaces the NSZombieEnabled flag, which was used as a workaround.
See: https://github.com/firebase/firebase-ios-sdk/issues/9083.

@asafkorem issue from #3123 has reappeared with this change

@fatlinesofcode I see. I will take a look at this today. I guess we need a similar fix with Expo..
Are you using firebase in your project? If so, you need to upgrade your GoogleUtilities to v7.7 for this fix to work.


revert storage medium of partition should not inherit from…

… table (#41192)
pick: https://github.com/apache/doris/pull/41192

run buildall

run buildall

already merged into 3.0 by other way


Fix filter_platform to run on targets other than x86.

The issue is that the dependencies array was hard-coded to be sorted by [none, 'cfg(foobar)', 'wasm32-unknown-unknown', host_target] where host_target is usually a target that starts with "x".  However, running the test on a target that sorts less than wasm32 causes the test to fail (such as aarch64). The order of arrays used to be ignored until #8489.  The solution here is to just sort the expected order of dependencies.  An alternate solution would be to extend with_json with more options on comparison (such as ignoring array order), but this seems simple enough.
Fixes #9238

r? @Eh2406
(rust-highfive has picked a reviewer for you, use r? to override)

@bors r+

:pushpin: Commit 95827ad3bf7a6fc6d501c3ccd45b5636434a07b5 has been approved by Eh2406

:hourglass: Testing commit 95827ad3bf7a6fc6d501c3ccd45b5636434a07b5 with merge c4da0c52a504fc4905347260d9e092d31eda1139...

:sunny: Test successful - checks-actions
Approved by: Eh2406
Pushing c4da0c52a504fc4905347260d9e092d31eda1139 to master...


closes #158 WIP Added docs using Sphinx and markdown

Added Sphinx using markdown to create docs.
With Sphinx installed recommonmark, sphinx-rtd-theme and sphinx-markdown-tables.
This example includes code example using Markdown and also uses sphinx autodoc. Also included markdown file
To build the docs run: make build-docs-html

Result example

Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md:
Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver,so make sure to pick the appropriate type. If in doubt feel free to ask :)

Hi @CarlosMart626! I was thinking maybe we could try MkDocs, Tom has added something similar to autodocs: https://twitter.com/_tomchristie/status/1182640810594095105
But, to be fair, we will probably remove the docs tools at some point (I want to build the documentation site with Gatbsy in future) :)
Let me know what you think about MkDocs! And, just a note, I think we should put the dependencies as dev dependencies :)

@patrick91  Yes! I'll take a look to MKDocs I've been in some very busy weeks hope to get an updated version soon

@CarlosMart626 can you hold off a moment? :D My friend finished the design and I'm working on implementing it using gatsby, so I think we might not need mkdocs after all ;)

i suggest that you use mkdocs with the material theme instead, i used gatsby and it is not very easy to develop with, better stay lean and remain in the python echosystem.
An example of the mkDocs material theme is uvicorn

@remorses that's a good point, luckily I'm pretty familiar with Gatsby so that won't be a problem :) I actually managed to implement the site already, but haven't published yet as I have to write the docs, it will be my focus on the holidays :)
PR is here if you want to have a look: https://github.com/strawberry-graphql/strawberry.rocks/pull/3

I'll close this PR for now, thanks a lot @CarlosMart626! Hope to see you soon at some event 😊


Add Redux

Reference
TASK_ID
Overview
Brief description of what this PR does, and why it is needed.
Acceptance Criteria

[ ] CRITERION_HERE

Demo

BeforeAfter

Reviewers' Checklist (go ahead, check 'em)

[ ] Merge destination is correct
[ ] Tests cases have been added where appropriate (Jest, Loki, Cypress)
[ ] Code is correct as understood and conforms to quality standards
[ ] Acceptance criteria have been met

Testing Instructions

How to test this PR
Prefer bulleted description
Start after checking out this branch
Include any setup required, such as bundling scripts, restarting services, etc.
Include test case, and expected output

Codecov Report

Merging #16 into develop will decrease coverage by 17.14%.
The diff coverage is 80%.

@@             Coverage Diff              @@
##           develop      #16       +/-   ##
============================================
- Coverage      100%   82.85%   -17.15%
============================================
  Files            3       11        +8
  Lines            5       35       +30
  Branches         0        6        +6
============================================
+ Hits             5       29       +24
- Misses           0        6        +6

Impacted Files
Coverage Δ

src/state/index.ts
100% <100%> (ø)

src/types/Maybe.ts
100% <100%> (ø)

src/utils/makeActionCreator/index.ts
100% <100%> (ø)

src/utils/makeReducer/index.ts
100% <100%> (ø)

src/utils/match/index.ts
100% <100%> (ø)

src/state/actions/actionTodoAdd.ts
100% <100%> (ø)

src/components/Initializer/index.tsx
100% <100%> (ø)

src/components/App/index.tsx
50% <44.44%> (-50%)
:arrow_down:

src/state/reducers/reducerTodos/index.ts
66.66% <66.66%> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3644569...d3e75a4. Read the comment docs.


Fixed data race in shim

Description
After instantiating CC in a peer, calling invoke command cause data race.
Example:
peer chaincode invoke -n cc_name -v 0 -c '{"Args":["testFunc","arg1"]}' -C channel_name
Chaincode should be runned with '-race' flag.
Motivation and Context
This fixes data race in chatWithPeer function
Checklist:

[] I have added a Signed-off-by.
[] I have either added documentation to cover my changes or this change requires no new documentation.
[] I have either added unit tests to cover my changes or this change requires no new tests.
[] I have run golint and have fixed valid warnings in code I have added or modified. This tool generates false positives so you may choose to ignore some warnings. The goal is clean, consistent, and readable code.

Signed-off-by:

Thanks for the contribution, but it's only a read-only mirror. You can go to Gerrit and submit the patch.


Error Connect with Android + FireFox 52.0.2

Firefox has problems with Android version 52.02.
But Firefox 52.02 computer, no problem

What error is Firefox for Android showing?
What does the server's output show when the Android client attempts to connect?
Is there anything that you can give us beyond "it doesn't work"?

error:
Client connected. Resource id #14 Client disconnected. Resource id #14
in android firefox version 52.02
But pc firefox version 52.02 Not disconnect.

That narrows it down to failing the handshake.  It'll take some time before I can troubleshoot further, but I'll get on it when I can.  Thanks!

I do the following to solve the problem:
add sleep(1); on function connect(
`
protected function connect($socket) {
$user = new $this->userClass(uniqid('u'), $socket);
//@@@
//echo "\n time start ".$user->id.": ".time();
sleep(1);
//echo "\n time End ".$user->id.": ".time();
//while(!strlen($user->id)>2);
$this->users[$user->id] = $user;
$this->sockets[$user->id] = $socket;
$this->connecting($user);

}
`
But quickly connect comes down.
Why?
There is a better way?

One thing is for sure, putting a sleep there (or anywhere in that code actually) will either slow everything down or prevent other connections from working.

I know
But what a way to connect Firefox Android?

i am having the same issue with android + chrome
on desktop + chrome wotks ok, but on android + chrome can not connect to socket, same error as above.


finetuned the VALL-E X model

First of all, thank you very much for the excellent work you do, it's really great!
Secondly, I'd like to ask you two questions:
I'm planning to use my datasets to fine-tune the model and train only the VALL-E X model without training the Encodec, is this ok?
And what do I need to pay attention to in the fine-tuning training? I look forward to your reply, thanks again!

Hi there,
Of course, you don't need to train Encodec during finetuning. Please simply follow lifeiteng's repo, whose link has been given in read me.
Please prepare enough data if you would like to train on a new language. If you would only like to fit in a few voices, you may apply PEFT techniques like LoRA.

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。


Share

can u implement share button
also album wise results
thank you.

sure, i will also make the downloader working soon enough


Create rankings/match scores page on mobile website

Create rankings/match scores page on mobile website.
Including scores finished matches, all rankings, search by player

see results-rankings mobile branch


nwc: eom-harvesting & misc changes

The primary focus of this PR will be activating the regex for EOM functionality as current energy harvesting isn't capable. EOM gradient was capable with a minor hiccup of the symmetry that can be reviewed in Issue #38.
Additional edits are options edits for properties and updating nwc tests with new language in updating qcel and qcengine.

Codecov Report

Merging #39 into master will increase coverage by 0.01%.
The diff coverage is 16.16%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   46.95%   46.97%   +0.01%
==========================================
  Files         141      142       +1
  Lines       15474    15503      +29
==========================================
+ Hits         7266     7282      +16
- Misses       8208     8221      +13

Impacted Files
Coverage Δ

qcdb/tests/nwchem_tests/test_tce_ccd.py
41.17% <ø> (+10.74%)
:arrow_up:

qcdb/tests/nwchem_tests/test_tddft_n2+.py
12.96% <0%> (+0.46%)
:arrow_up:

qcdb/programs/nwchem/read_options.py
0.96% <0%> (-0.01%)
:arrow_down:

qcdb/driver/properties.py
30.76% <0%> (+5.76%)
:arrow_up:

qcdb/tests/nwchem_tests/test_tce_ccsd_dipole.py
36% <0%> (ø)
:arrow_up:

qcdb/tests/nwchem_tests/test_eom_ccsd_h2o.py
10.6% <0%> (ø)
:arrow_up:

qcdb/tests/nwchem_tests/test_dft_dipole.py
50% <0%> (ø)
:arrow_up:

qcdb/programs/nwchem/graft.py
15.23% <10%> (-0.38%)
:arrow_down:

qcdb/qcvars/glossary.py
100% <100%> (ø)
:arrow_up:

qcdb/keywords/parsers.py
51.58% <12.5%> (-2.65%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ce01c...bee8557. Read the comment docs.


Deviation BUG in Funal App

There is a lot of deviation between ImGui viewport and click checkpoint.

The problem solved by rebuild ImGui


DRILL-4303: ESRI Shapefile (shp) format plugin

Shp format plugin. Main idea is to read shapefiles for joining with other sources or enabling the conversion to i.e. parquet file which is capable of storing geometry data in binary format (WKT) on hdfs.
The implementation is based on esri java lib which lets to parse single geometry definition. Custom code is written to read whole file (ShapefileByteBufferCursor). The plugin also handles reading of accompanying data file (dbf) and srid informations (srid).
Sample usage:

reading shp
select *, ST_AsText(geom) from cp.sample-data/CA-cities.shp;
conversion to parquet
alter session set store.format='parquet';
create table dfs.tmp./CA-cities-par as select * from cp.sample-data/CA-cities.shp;

There is also sample parquet file in cp.sample-data/CA-cities.parquet

HI @k255
Are you still interested in this?  I think if we're going to get the GIS functions into Drill, we really should get this in as well and I'm happy to help.  For whatever reason, I didn't see this until this morning.  Anyway, if you'd be willing to rebase this, I can help shepherd it through the review process.
-- C


fix Dates across the Admin UI

As a CSC, I need dates to display in a readable format so that we can quickly and accurately identify meaningful points in time

Notes
Before we fix the dates in the list view, we can temporarily adjust the column widths to accomodate longer month names
Tasks

[x] allow dates to use a formatted option in disabled fields
[ ] allow dates to use a formatted option in meta createdDate updatedDate fields
[ ] allow dates to use formatted options in model list views
[x] allow dates to use formatted options when showing model date fields
[x] allow dates to use formatted options in date placeholders
[ ] update any related unit tests
[ ] update Keystone in MARE package.json to point to the updated Keystone commit

Definition of Done

[ ] disabled fields use the format 'MM/DD/YYYY'
[ ] createdDate and updatedDate fields use the format 'MM/DD/YYYY'
[ ] model lists showing date columns use the format 'MM/DD/YYYY'
[ ] dates in models use the format 'MM/DD/YYYY'
[ ] date placeholders in models use the format 'MM/DD/YYYY'

does not appear to still present any issues so closing.


Unable to remove/resize custom layout

Microsoft PowerToys version
0.33.1
Running as admin
Yes
Area(s) with issue?
FancyZones Editor
Other Software
n/a
Steps to reproduce
It does not appear that I can remove and/or resize the default custom template zones.
✔ Expected Behavior
remove/resize custom layout
❌ Actual Behavior
Unable remove/resize custom layout
It does not appear that I can remove and/or resize the default custom template zones. See screenshot. Arrows shows what I am not able to remove and/or resize. I can only add to this layout.

@NVader2000
grid-based layouts are always full screen, you cannot move/resize the edges, you can resize the zones by using


map cannot display (China user)

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
(China user)All grafana reports map cannot display, cannot find a quick and correct solution, can anyone help fix it?
Expected Behavior
No response
Steps To Reproduce
No response
Relevant log output
2022-12-18 14:44:27.664 [info] MQTT connection has been established
2022-12-18 14:44:28.191 car_id=1 [info] Start / :asleep
2022-12-18 14:44:32.658 [info] GET /settings
2022-12-18 14:44:32.668 [info] Sent 200 in 9ms
2022-12-18 14:51:27.866 [info] GET /settings
2022-12-18 14:51:27.872 [info] Sent 200 in 6ms
2022-12-18 14:51:28.196 [info] GET /
2022-12-18 14:51:28.200 [info] Sent 200 in 4ms
2022-12-18 14:52:22.194 [info] GET /settings
2022-12-18 14:52:22.202 [info] Sent 200 in 7ms

Screenshots

Additional data
No response
Type of installation
Docker
Version
v1.27.1

please see the screenshoot;

https://github.com/adriankumpf/teslamate/issues/2955
openstreetmap在中国被屏蔽，看看是否挂代理吧，如果部署的机器无法挂代理的话，可能就不行了。

你是在部署的机器上面安装翻墙代理？网页可以显示地图？

代理需要装在部署机器和访问的客户端上面才能正常显示

#2956
https://github.com/adriankumpf/teslamate/issues/2956#issuecomment-1303582122
You guys can use https://github.com/WayneJz/teslamate-addr-fix

change bing map

使用teslamate的中文版本，已经解决了地图和位置无法显示的问题。
https://docs.teslamate.com.cn

If you run teslamate on your own device,use vpn can fix it.

有人把地图改成高德的了， 我想知道怎么改？  他是出售盒子的


Dev correct TSRMLS_CC

Juste add TSRMLS_CC to phpjs.c

Hi @badlee I can compile it locally (without threads) but travis is failing https://travis-ci.org/crodas/PHPJS/jobs/121166670
Although I can compile locally (I wanted to fix) but it's failing most tests. Am I missing something? Does make test passes for you locally?


.. note:: is not recognized by VSCode

Problem
.. note:: is not recognized by VSCode. A similar issue is the .. code-block:: in #1265, it can be fixed by using :: instead of .. code-block::.
Possible Solutions

[ ] Simply remove the .. note:: environment
[ ] Using the numpydoc Notes section

There are others directives, less common, that are also not recognized by VS Code (.. versionadded::, .. autolink-skip::,...). I think that is because VS Code can't render directives at all.

Using the numpydoc Notes section

Replace .. code-block:: by :: and .. note:: by the numpydoc Notes will help a lot in the current state of VS Code, even more because that directives are the most used.
However, I think this is a limitation of VS Code itself, and could be neglected if bring issues to abqpy, I mean, if abqpy get limitations due to VS Code. Besides, there is already an open discussion very up voted in pylance repository that may solve the problem that VS Code has with Sphinx.
Therefore, I think this modification could still be done only if brigs advantages to abqpy. I mean: simplify the code, make it easy to write, and so on...

Actually, at first, I am using the Notes section, but sphinx will always place the Notes section after the parameters, even if it is before the parameters in the source code, which is very inconvenient to check the documentation.

Actually, at first, I am using the Notes section, but sphinx will always place the Notes section after the parameters, even if it is before the parameters in the source code, which is very inconvenient to check the documentation.

Exactly, directives are a more robust way to use Sphinx. (I just update the link in my previous post)


Thoughts on Example for Splitting Out "Business Logic Layer"?

Hey! First off I want to say I've recently begun migrating a project I'm working on to this project and have to say I'm loving it so far. The structure is quite clean and easy to understand, and adding new pages has been a snap!
I'm at the point now where I'm getting ready to implement some interesting business logic. In my own experience I like having that stuff stowed away in a clean package on its own - similar to the service layer in a traditional three tier architecture, or the application core in hexigonal architecture. I like this approach because it's nice having technology concerns like databases, frontends, and other integrations completely isolated away from the problem you're really trying to solve.
As the application stands now, the controllers (routers, pages) talk directly to the database using the controller struct's services container. My thinking is to perhaps remove the ORM, and Database dependencies from the services.Container struct and add new services there representing those that contain business logic. Those services in turn would have access to the ORM.
I think that for many applications additional layering like this would be overkill. If you aren't doing more than simple CRUD interactions with a database, no need for a layer that doesn't actually hold any logic. But I'm curious if you have any thoughts on this is where you would make the "cut" or if you'd have another approach.
Thanks again for putting this together, it's massively appreciated. Not only did you expose me to some great new stuff in the Go world (man... Ent is crazy cool... I'm not normally a fan of ORMs but so far I'm digging this) but it's also really nice having some grounding to work from. Well done!
P.S. My previous project was using templ for templating - while it's a neat library I'm not totally sold on it yet. I re-read the go template docs while preparing to migrate to this and haven't yet really missed templ.

Thank you for the really great feedback - I appreciate it and am always glad to hear this has been useful for others. It was a lot of fun to put together and also exposed me to a ton of really excellent Go projects (ent still blows me away with how well it was done, also coming from someone who doesn't love ORMs); as well as non-Go projects (ie, HTMX, Alpine, Bulma, etc).
You're very welcome. This started because I didn't have a good answer to what I would use if I wanted to spin up a quick full-stack Go app with everything I needed to hit the ground running (without using some mega Go framework or heavy, separate JS frontend).
I'm personally a huge fan of hexigonal architecture. What you're describing is exactly what I would do if I were building out an app for myself. I didn't want to go down that path for this project because it's meant to be purely a starter kit at it's simplest form without making any bigger architectural decisions that could be difficult to unravel if that's not your preference. I didn't even include interfaces for all/most of the services on the container because I assume most people will be changing not only what's in the container, but how they function. It would end up being a waste of time on my part and probably somewhat more difficult for users to refactor to their liking. That's the great thing about this being a template rather than a framework - you're not locked in to anything at all. Actually, the AuthClient is sort of an example of what you're describing, though better practice would be if the ORM was more easily mockable for better/easier testing.
I wouldn't worry about looking for a proper "cut" between one way or another. I think what you described is better and will always suit you better in the long run. It also doesn't take much time at all to set things up that way. And it comes down to preference; go with what you like.
I'm also intrigued by templ and think it's a very promising project but I thought it was too early to consider bringing it in here. It's also a pretty big deviation from the standard library, and last I checked, IDE support was still lacking. Standard templates do leave quite a bit to be desired, but I think what I put together for this project makes them pretty easy to use.
If you have any more questions or want to share some code examples, etc, please feel free to re-open this or open a new issue. As you continue using this project more, definitely let me know what you think and if you have any feedback or suggestions. If you have some time, you can also let me know what you think about this refactor: https://github.com/mikestefanello/pagoda/pull/59 (I like the overall change but I think using init() to register handlers is a bit too fancy and will probably be removed).
Thanks again!

I did a similar thing, though yours is much, MUCH more mature than mine hahah. Glad to hear I had the vibe of the architecture down - that's a good sign!
I think templ could be good, what I started to get frustrated with was wanting just a little more power in my view layer. It could be that I'm so accustomed to the modern JS frameworks that I'm trying to do too much at the layer. But I ended up with quite a few public functions in my template files that would do a bit more prep to then call a private templ function. That was the pattern that I ended up settling on feeling the best and I wasn't happy with that. In the end it just didn't feel as obvious a win as say HTMX does.
I'm looking at your PR now - just struggling a bit because I lack some context but I'll try to give some useful feedback!


Workflow errors out on more than 2 app instances

In what area(s)?

/area runtime

/area operator

/area placement

/area docs

/area test-and-release

What version of Dapr?

edge: output of git describe --dirty

Expected Behavior
Dapr workflows runs fine even on scaling app to multiple instances(>2).
Actual Behavior
On testing with master without #6886, I was able to replicate the errors mentioned in #6874. With #6886 merged, I am successfully able to test workflow with 50 VUs(concurrency) and 500 iterations(total number of workflow runs) and workflow runs fine for 2 instances of application.
But on running the same workload with >2 instances, even with 3, it gives following errors:
time="2023-09-07T06:54:18.097698488Z" level=error msg="Error storing reminder: error saving reminders partition and metadata: no item was updated" app_id=perf-workflowsapp2 instance=perf-workflowsapp2-5b7c9ff87f-2fkbq scope=dapr.runtime.actor.reminders type=log ver=edge

time="2023-09-07T06:56:24.627547045Z" level=error msg="error deleting reminder: error deleting reminder: timed out after 30s" app_id=perf-workflowsapp2 instance=perf-workflowsapp2-5b7c9ff87f-2fkbq scope=dapr.runtime.actor.reminders type=log ver=edge
time="2023-09-07T06:56:24.636829543Z" level=error msg="error deleting reminder: error deleting reminder: timed out after 30s" app_id=perf-workflowsapp2 instance=perf-workflowsapp2-5b7c9ff87f-2fkbq scope=dapr.runtime.actor.reminders type=log ver=edge

time="2023-09-07T06:56:24.744316985Z" level=warning msg="3e8f72b4-ceee-48d3-9d32-77d48df9b7d9: execution failed with a recoverable error and will be retried later: failed to invoke activity actor '3e8f72b4-ceee-48d3-9d32-77d48df9b7d9::1::1' to execute 'sum_activity': rpc error: code = DeadlineExceeded desc = context deadline exceeded" app_id=perf-workflowsapp2 instance=perf-workflowsapp2-5b7c9ff87f-hhbcn scope=dapr.runtime.wfengine type=log ver=edge
time="2023-09-07T06:56:24.758060531Z" level=warning msg="997160c0-e3a7-4cf2-af23-809d41a22f9c: execution failed with a recoverable error and will be retried later: failed to invoke activity actor '997160c0-e3a7-4cf2-af23-809d41a22f9c::3::1' to execute 'sum_activity': rpc error: code = DeadlineExceeded desc = context deadline exceeded" app_id=perf-workflowsapp2 instance=perf-workflowsapp2-5b7c9ff87f-hhbcn scope=dapr.runtime.wfengine type=log ver=edge

Steps to Reproduce the Problem

Release Note

RELEASE NOTE:

So, we have adopted the strategy of retrying reminder creation/deletion, when etag mismatch happens.
Now, this strategy worked fine for 2 instances. But, it  is leading to more number of mismatches and retries in case of 3 or more instances and ultimately, it times out.
I am trying to play around a bit with the retry time and timeout time etc.
But, as per current reminders design - we won't go beyond a certain point.
Even if we keep infinite retries, without any timeout boundary, this strategy will not be scalable - as if anyone tries to horizontal scale, it will backfire at the moment - and user would see huge time increase in completing a reminder execution.
So, I believe, this issue would be solved properly, at root cause level, with Reminders v2 only.

ping


⚠ ClamAV has degraded performance

In 6fdae08, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 79 ms

Resolved: ClamAV performance has improved in 8df51ae.


user_group_create: Hide can_manage_group setting in prod.

This change was missed in 63a7c9061ba.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

The default for the can_manage_group setting for new groups is "Group creator" now, so hiding the setting in UI would mean the user would not know this while creating the group.

I think we no longer need this?

I think we probably need to just start allowing anonymous groups in prod, at least for settings on group objects.

Closing in favor of #32006.


Intent to implement: command to create a new build

Intent to implement: command to create a new build
It could be interesting to create a build from a command.
The command could be like :
./console phpci:create-build [projectId]

With this command, it could be easy to create a build from a CRON task.
What do you think about it ?

@jdecool Is currently possible using cURL, eg:
curl http://phpci.example.com/webhook/git/<project_id>

more info on wiki page
Having a specific command can be a plus.

I also think it would be nice to have a command to create a new build from the command line :)


SWDEV-240806 - Added enum hipGraphInstantiateFlags

Change-Id: Ibf6eba67f2eecae25a7e2fc75f7430750de12570

This change is outdated . Please use https://github.com/ROCm-Developer-Tools/HIP/pull/2481 for this.

Closing this PR as #2481 should be used instead.


Fix common bug in parsing of UTC datetimes; remove dateutil

This PR addresses a common bug related to parsing UTC datetimes, fixes the timezone of Opta F24 data and removes the dateutil dependency.
astimezone -> replace
Often, datetimes are specified as a string and use the UTC timezone. In kloppy, we want to parse these a timezone-aware datetime. Then, then string was usually parsed and converted to a timezone-aware datetime as follows:
>>> parse("2024-12-14 12:00").astimezone(timezone.utc)
datetime.datetime(2024, 12, 14, 11, 0, tzinfo=datetime.timezone.utc)  # on a system with local timezone UTC+1

The correct implementation is:
>>> parse("2024-12-14 12:00").replace(tzinfo=timezone.utc)
datetime.datetime(2024, 12, 14, 12, 0, tzinfo=datetime.timezone.utc)

The former changes the timezone, while the latter sets the timezone (i.e., makes the datetime timezone-aware).
Opta F24 timezone
According to the documentation, timestamps in the F24 files use the timezone "Europe/London".
Remove dateutil
We know the exact format of the date string in advance. Hence, we don't need dateutil's parser module.

Is there a one-minute difference between UK/London and UTC? Or did I make a mistake?
import datetime
from pytz import timezone

naive_datetime = datetime.datetime.now()
local_datetime = naive_datetime.replace(tzinfo=timezone('Europe/London'))
utc_datetime = local_datetime.astimezone(timezone('UTC'))
print("Naive datetime:", naive_datetime)
print("Local datetime:", local_datetime)
print("UTC datetime:  ", utc_datetime)

This is the output:
Naive datetime: 2024-12-14 21:53:04.383850
Local datetime: 2024-12-14 21:53:04.383850-00:01
UTC datetime:   2024-12-14 21:54:04.383850+00:00


Missing license terms

Can you please add a license file so we're covered from a legal standpoint? Without that, many organizations can just use it.
Thanks for this work!

hum forget - seems to be in the git repo  although was not in the zip dist file - sorry about that


Fix skipped transpilation of async functions in certain instances

Something in https://github.com/fusionjs/fusion-cli/commit/61f61d42fff0fd44a557b009b1ddd32d750cf22b seems to have broken transpilation of async functions in a strangely specific case.

Must be default export (non-default export works fine)
Must be in object in createPlugin call (seems to work for other functions)

This PR adds a regression test and reverts most of the dependency changes in https://github.com/fusionjs/fusion-cli/commit/61f61d42fff0fd44a557b009b1ddd32d750cf22b

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

!merge


Update to CRA v5

Once CRACO updates to v5, I need to update this to v5 asap.

Since Tailwind doesn't require CRACO anymore, this can happen right now.


Use demo.py with custom video for inference

Could you please provide any pointers to how I could modify demo.py to perform inference using a video file?

@GiorgosBetsos
You can see this issue: #28. Especially these two codes: https://github.com/cfzd/Ultra-Fast-Lane-Detection-v2/issues/28#issue-1358606313 and https://github.com/cfzd/Ultra-Fast-Lane-Detection-v2/issues/28#issuecomment-1234974971


docstring changes

It seems that just changing the docstring of a class or function is enough to trigger the re-execution of all tests that use the class/object.
I would expect to only re-execute tests that access the MyClass.__doc__

This is by design. MyClass.doc can be directly and indirectly accessed in infinite ways, and testmon doesn't try to follow code logic. I'll write a blog post what we try to achieve and what not soon.

As said, this is by design. testmon doesn't try to determine which tests read and process MyClass.doc and which don't so any test which imported MyClass will be re-executed.
Promised explanation of what testmon does:
https://github.com/tarpas/testmon/wiki/Determining-affected-tests


Build and test DevTools as part of building the SDK

This is part of the effort to improve the DevTools release process. Right now this is quite manual and the devtools binary is uploaded to CIPD. This is an issue because the built devtools binary is not actually tested against each commit to the SDK for which it is a part of.
Building and testing DevTools as part of the sdk build would ensure that changes to the VM or other APIs that DevTools depends on do not break DevTools functionality.
The Dart CI will need to build DevTools as part of the building the SDK. This build step should check out DevTools at the commit specified in the DEPS file, checkout the Flutter SDK at the version specified by DevTools,  and then build DevTools and copy the web artifacts to /bin/resources/devtools.
The Dart CI will then need to run DevTools tests. We want to ensure that Dart VM changes do not break DevTools. To test this integration, we will need to test how DevTools interacts with a Dart application that is run with the locally built Dart SDK. These tests should be written in the DevTools repo, and the Dart CI can run the test suite.
As a follow up to the above work, we should create an auto-roller to update the DevTools DEP entry so that this does not need to be done manually and breakages are caught sooner.

FYI @a-siva

@bkonyi

The main issue with pulling DevTools into the SDK to be built is the number of dependencies it has that aren't already part of the set of packages pulled into the SDK. There's roughly 14 additional packages that DevTools would need to build, and at least 8 of these are Flutter specific (list of packages here). Obviously this isn't ideal as there's general hesitancy when it comes to introducing too many new dependencies in the SDK. However, we also don't want to have to rely on hitting pub during each build, so I'm thinking we'll need to either just pull in the additional dependencies to the SDK or come up with some other compromise (e.g., pulling in the packages and only making them accessible to DevTools).
The other issue has to do with adding a dependency on Flutter in the SDK build, as we'll need Flutter to both build DevTools and eventually run integration tests on the Chromium infrastructure. This is quite a large dependency, especially if we decide to include all of the artifacts needed to build on the various platforms without having flutter_tools dynamically download them. I assume we'd have to do something similar to what we do with the pinned Dart SDK and periodically upload a stable version of Flutter to CIPD to be used for the builds. Would we have any issues with this?

As Ben stated, it seems we have two options, and I listed what Ben and I discussed about each of these options offline:

pull the additional DevTools packages into the SDK so that we can build DevTools on the CI without calling to pub

this would need to be done anyway if we ever want to develop DevTools as part of the SDK
this would make it difficult to maintain any package version changes in DevTools. We would both have to bump the pubspec version of a package in devtools, and update the SDK DEPS file with the new commit for this version. If DevTools was developed in the SDK, this could all be done in one CL, but that is not the case while the SDK and DevTools are independent repositories.

Decide to call to pub when we need to build DevTools

In DevTools, we could consider pinning our pub packages to alleviate the risk of breaking the SDK CI due to some pub versioning issue or recently published breakage
This is already done in places of the CI (e.g. the triple head bot that builds the flutter engine, flutter framework, and runs the framework tests)

Other notes:

We could ensure that the DevTools tests we want the SDK CI to run do not use Flutter test driver, but rather a Dart CLI app. This would alleviate the need to build the Flutter engine and Flutter framework as part of this test run. DevTools is built from a pinned version of Flutter, so there is no need to build the Flutter engine and framework with a local SDK to run DevTools.

My vote is for option 2) as this option solves the current issue of building and testing DevTools with the SDK, and incurs the least implementation and ongoing maintenance cost. Additionally, IMO option 1) actually causes more challenges if we intend to keep DevTools code in its own git repo. Option 1) makes more sense if we decide to move DevTools development to the SDK, but I do not know that we want to do that just yet (this would be a large undertaking).
@bkonyi please add anything I missed or any thoughts you had surrounding our discussion. Thanks.

The main issue with pulling DevTools into the SDK to be built is the number of dependencies it has that aren't already part of the set of packages pulled into the SDK

I think there are at least two other options that might also be worth considering:

Review how much we actually depend on each dependency, and see if we can trim them a bit. For example, should we just depend in a small amount of code from a package, we might be able to inline that code (if it's our code).

Rearchitect DevTools to have a common (Dart-only) part, and a Flutter part. Place just the common part in the Dart SDK, and move the Flutter part to the Flutter SDK. I don't know DevTools well enough to understand how much complexity this might introduce though...

cc @natebosch for input also

Summary from the meeting with @athomas and @kenzieschmoll last week:
"Alex, Ben, and I just met to discuss this issue further. The original two goals of trying to build and test DevTools as part of the SDK were the following:

Catch breakages in DevTools that would be caused by a change to the SDK.
Simplify the DevTools release process so that it occurs more frequently and with less manual engineering hours.

In this morning's meeting, we discussed a way to accomplish these two goals without needing to build and test DevTools as part of building the SDK, which we have discovered is more complex and potentially problematic than the solution is worth. The following is a summary of the strategy we discussed and action items moving forward.

DevTools will modify our GitHub actions CI to test against a recent Dart SDK. This will allow us to catch breakages from the VM early. To do this we can either A) add a bot to our CI that runs against Flutter master (this would have the most recent Dart SDK that made it into the Flutter build), or B) restructure our integration tests to run against a Dart CLI app instead of a Flutter app, and pull in the Dart SDK dev branch directly to run those CLI apps. Option A) is likely easier to implement since we wouldn't have to re-write our tests, but would have the downside that we wouldn't catch breakages as quickly as option B) because of the latency of rolling the Dart SDK into the Flutter framework.
An auto-roller should be set up in the SDK to build DevTools from head, upload it to CIPD, and update the DEPS file in the SDK. We may want to consider adding a script to the auto-roller that updates the DevTools version for each roll, as this would help with bug reports from users. Setting up an auto roller would virtually eliminate the current manual work of releasing DevTools and would help ensure that we do not miss release windows for Dart & Flutter, like we have been faced with recently."

2. and update the DEPS file in the SDK

What specific changes would the auto-roller make in DEPS?

@natebosch It would update the devtools_rev gclient variable.

Reassigning to @athomas to investigate setting up a builder for the DevTools artifacts.

do we have any updates on this? thanks

Not yet, it's still on the KRs, but slipped from Q2->Q3.