Include work to support corporate proxies

Hi @durck, I noticed that you have made a fork that (I believe) allows the rssh client to talk to a corporate proxy to get outbound connectivity.
I'd love to include this work if you would be happy for me to do so! (I would have open this as an issue on your fork but it doesnt have issues enabled)

Hi again @durck,
Im going to merge this work into unstable as I havent been able to get in contact with you. If you have issues with what Im merging please reach out!

Sweet, thank you!


Refactor and possibly optimise PID

PID is implemented in an inneficient way causing longer compile times. It should be refactored to split into a PID.h file and PID.cpp file.
This would allow us to reduce compile times.
We can possible also optimise what its actually doing under the hood, but not sure

Mirror Issue here

Apparently this is gonna have a  lot of issues with Templates


[musig2] two phase key aggregation

Users must transition from a AggKey into an Bip340AggKey before starting a signing session. This is the idea:

When it is a AggKey you can only apply ordinary tweaks (i.e. bip32)
When it is a Bip340Aggkey you can only apply "xonly" tweaks. (i.e. taproot)

The code and spec makes way more sense to me now. We are down to a single needs_negation boolean we keep around. We can't implement all the spec tests for this since one test requires a ordinary tweak after a "xonly" tweak. I think I'll suggest removing that from the spec.

superseded by #37


Double slash (...github.io//assets/...) in the url when use deploy

When I use : ./bin/deploy, it generating URLs with double slash after ...github.io//... Can you please help pinpoint the issue? I know it's not a problem with the page loading. Thank you.

Could it be because my base url is empty? 🤔 I have found a workaround by using build and manually git push _site/ to my GitHub pages.

Thanks for pointing this out. This might be a tiny bug somewhere in the code that requests assets. I plan to fix such minor bugs in the next release, but does this double slash affect anything now?

In terms of URL loading, there was no issue. Apparently, browser does not care whether there is single or double slash in the url string. Currently, I am building using jekyll build which does not generate double slash. Thank you.


set_issue_estimate fails with "Unknown Error"

Attempting to set_issue_estimate results in the following error.
result = zh.set_issue_estimate(repo_id, issue_number, estimate)

File "/Users/.../zenhub/core.py", line 161, in set_issue_estimate
return self._put(url, body)
File "/Users/.../zenhub/core.py", line 99, in _put
return self._parse_response_contents(response)
File "/Users/.../zenhub/core.py", line 70, in _parse_response_contents
raise ZenhubError("Unknown error!")
zenhub.core.ZenhubError: Unknown error!
Looking into the details ZenHub returns a status code of 400 along with "message":"invalid json".
changing line 98 in core.py resolved the issue:
- response = self._session.put(url=self._make_url(url), data=body)
+ response = self._session.put(url=self._make_url(url), json=body)

Hi @carl-mayer thanks for the report and the fix.
Do you want to open a PR with it?
Cheers

@goanpeca see #6 please review
FYI @georgec-s, I believe you were also seeing this issue and used the raw API for some requests


WPF filter

is it possible to apply WPF filter to some specific driver ? Thanks,

This project has not yet implemented the processing of WPF filter. There are other open source projects that have implemented WPF filter to block EDR communication.

It is normal to be detected. This is an open source project and is only used for testing.

If you want to exploit, you need to find an undisclosed exploitable driver and integrate it into this project.


Build crash

Hello tomato,
I wanted to test your admin but I have a crash right away when I run the command
npm run build

[vite]: Rollup failed to resolve import "vue3-swatches" from "vendor/tomatophp/tomato-components/resources/js/components/TomatoColor.vue".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
build.rollupOptions.external
error during build:
Error: [vite]: Rollup failed to resolve import "vue3-swatches" from "vendor/tomatophp/tomato-components/resources/js/components/TomatoColor.vue".

try
php artisan tomato-components:install
yarn
yarn build

thank you for your reply.
exact same crash when installing tomato-components
and yarn / yarn build
(nodejs -v 16.19)

okay i got the problem just install this packages and than build, we add this line to docs
yarn add vue3-editor codemirror-editor-vue3 vue3-tel-input vue3-swatches vue-draggable-next @suadelabs/vue3-multiselect
yarn build


Error when adding new Service Entries

Seems like some error happens in some cases when adding a new Service Entry when checking the state of the SDWAN. This error doesn't seem to affect the correct operation of the SDWAN though, as policies are being enforced even after seeing this error.
{"level":"info","type":"remove","name":"kubecon-demo","hosts":["kubecon.cisco.com"],"time":"2022-05-11T18:49:54Z","message":"received operation request"}
{"level":"info","waiting-duration":"1m0s","time":"2022-05-11T18:49:54Z","message":"starting waiting mode"}
{"level":"info","time":"2022-05-11T18:50:54Z","message":"busy mode activated"}
{"level":"debug","time":"2022-05-11T18:50:54Z","message":"checking authentication..."}
{"level":"info","worker":"remover","applications":["kubecon-demo"],"time":"2022-05-11T18:50:58Z","message":"removing applications, this may take a while..."}
{"level":"error","error":"could not disable applications: Code: CTEMP0003, Message: Failed to add apps and vpns, Details: Failed to edit applications","time":"2022-05-11T18:50:59Z","message":"error while removing custom applications"}
{"level":"info","time":"2022-05-11T18:50:59Z","message":"back in free mode"}
{"level":"info","event-handler":"Create","hosts":["kubecon.cisco.com"],"time":"2022-05-11T18:55:01Z","message":"reconciling service entry..."}
{"level":"info","type":"add","name":"kubecon-demo","hosts":["kubecon.cisco.com"],"time":"2022-05-11T18:55:01Z","message":"received operation request"}
{"level":"info","waiting-duration":"1m0s","time":"2022-05-11T18:55:01Z","message":"starting waiting mode"}
{"level":"info","time":"2022-05-11T18:56:01Z","message":"busy mode activated"}
{"level":"debug","time":"2022-05-11T18:56:01Z","message":"checking authentication..."}
{"level":"info","worker":"adder","names":["kubecon-demo"],"time":"2022-05-11T18:56:01Z","message":"adding custom applications, this may take a while..."}
{"level":"debug","worker":"adder","app-id":"1d3b4328-baba-4b3b-b241-754022ef1f9b","current-app":"kubecon-demo","time":"2022-05-11T18:56:02Z","message":"created custom application and received application ID"}
{"level":"debug","worker":"adder","list-id":"43b21cf9-4931-47d1-9743-76369dc78dee","current-app":"kubecon-demo","time":"2022-05-11T18:56:03Z","message":"created policy application list and received list ID"}
{"level":"debug","worker":"adder","time":"2022-05-11T18:56:06Z","message":"applications enabled successfully"}
{"level":"debug","worker":"adder","time":"2022-05-11T18:56:06Z","message":"a push is required"}
{"level":"debug","worker":"adder","operation-id":"push_file_template_configuration-c56bc261-3488-4856-8f10-be608b0dbaaa","time":"2022-05-11T18:56:07Z","message":"configuration pushed to all devices"}
{"level":"debug","worker":"adder","operation-id":"push_file_template_configuration-c56bc261-3488-4856-8f10-be608b0dbaaa","time":"2022-05-11T18:56:07Z","message":"waiting for operation to complete"}
{"level":"debug","worker":"adder","operation-id":"push_file_template_configuration-c56bc261-3488-4856-8f10-be608b0dbaaa","time":"2022-05-11T18:56:44Z","message":"finished"}
{"level":"debug","worker":"adder","#":1,"time":"2022-05-11T18:56:44Z","message":"retrieved vSmart policies"}
{"level":"debug","worker":"adder","#":1,"time":"2022-05-11T18:56:45Z","message":"retrieved AppRoute policies found"}
{"level":"debug","worker":"adder","time":"2022-05-11T18:56:45Z","message":"parsed and modified approutes before bulk update"}
{"level":"debug","worker":"adder","pocess-id":"push_feature_template_configuration-636277f4-1fbe-48fc-bded-13445d7040c6","time":"2022-05-11T18:56:49Z","message":"performed a bulk update and received processID"}
{"level":"debug","worker":"adder","id":"425b8f89-bbe0-45e1-b510-ee2f5c52eba5","name":"Central-Policy","time":"2022-05-11T18:56:52Z","message":"updated vSmart policy"}
{"level":"debug","worker":"adder","id":"425b8f89-bbe0-45e1-b510-ee2f5c52eba5","name":"Central-Policy","operation-id":"vsmart_policy_config-82743842-48ea-4b9b-a294-b4617ee9940c","time":"2022-05-11T18:56:53Z","message":"activated vSmart policy"}
{"level":"debug","worker":"adder","id":"425b8f89-bbe0-45e1-b510-ee2f5c52eba5","name":"Central-Policy","operation-id":"vsmart_policy_config-82743842-48ea-4b9b-a294-b4617ee9940c","time":"2022-05-11T18:56:53Z","message":"waiting for operation to complete"}
{"level":"error","error":"could not get summary: could not perform request: cannot unmarshal error response: invalid character '<' looking for beginning of value","time":"2022-05-11T18:57:13Z","message":"error while adding custom applications"}
{"level":"info","time":"2022-05-11T18:57:13Z","message":"back in free mode"}

An unexpected response body is being sent only when check for the status of an operation.
Thank you for bringing this up! I'll be investigating 🕵♂

This was a consequence of #1 and should be solved now.
Feel free to reopen in case it happens again.


App Store Requirements

We might need to implement some or all of these:

Require that users agree to terms (EULA) and these terms must make it clear that there is no tolerance for objectionable content or abusive users
A method for filtering objectionable content
A mechanism for users to flag objectionable content
A mechanism for users to block abusive users
The developer must act on objectionable content reports within 24 hours by removing the content and ejecting the user who provided the offending content

I don't think other group chat tools like Slack have these mechanisms, which makes me think that probably we're not being processed correctly by Apple.

@timabbott Maybe we can argue for most of these that the administration functionality in the backend serves this purpose?

Closing, since app got accepted.


Pulling other fields, not just content_html

Is there a way to pull other custom fields with this, not just content_html. Would like to use this as a basis for a calendar, but need to pull references to a start and end field as well.

you can use a custom snippet and forward whatever data you need via the options
$options = [
                    'title'       => 'Latest articles',
                    'description' => 'Read the latest news about our company',
                    'link'        => 'blog',
                    'mycustomvar' => page('other'),
                    'summaryField' => 'crazy', // use this field in you snippet <?= \Kirby\Toolkit\Xml::encode($item->{$summaryField}()) ?>
                    'snippet' => 'feedWithSummary', // site/snippets/feedWithSummary.php
                ];
                $feed = page('blog')->children()->listed()->flip()->limit(10)->feed($options);
                return $feed;

At least thats how i think it should work. :sweat_smile:

if you need real ICS files... this might be the better choice: https://github.com/bnomei/kirby3-ics

Is it possible to add an author or the article tags to the rss feed. I need it to send push notifications with articled.io.

see #34 and #36. please use a custom snippet.


Do not ACK errored messages

I had an issue with my FastAPI project where a task was throwing an exception and yet the message was being acknowledged and lost forever. I tried using the context inside the task to reject the message as shown here, but the task seemed to hang while trying to resolve the context dependency. I ended up implementing a fix I'll describe below.
For reference, here's a simplified version of my code:
# broker.py
import taskiq_fastapi
from taskiq_aio_pika import AioPikaBroker

from settings import settings

broker = AioPikaBroker(
    settings.rabbit_dsn,
    queue_name=f"myapp_{settings.environment}",
    exchange_name=f"myapp_{settings.environment}",
    dead_letter_queue_name=f"myapp_{settings.environment}.dead_letter",
    delay_queue_name=f"myapp_{settings.environment}.delay",
    qos=1,  # Consume one message at a time
)

# myservice.py
@broker.task
async def store(
    task_data,
) -> None:
    service = SomeService()
    data = await service.fetch_data_rpc(
        task_data
    )

Here, the fetch_data_rpc inside my task throws an exception. I'd expect the message to be requeued, sent to the dead letter configured in the broker, or at least not acknowledged, but that is not the case.
I'm not sure if this is an issue or an intended behavior, as I can see that in your receiver.py all messages are acknowledged regardless of their errors.
if self.ack_time == AcknowledgeType.WHEN_RECEIVED and isinstance(
    message,
    AckableMessage,
):
    await maybe_awaitable(message.ack())

This may be related with this issue,
In the end, my solution was to wrap the ACK in an if that checks if the message had errors. Now, if a task fails, the message is not acknowledged. This solves my issue, as failed messages are not lost now.
I'm sending my fix as a PR in case you consider it useful for use cases other than mine.

Yes, it is intended behavior.
If you wish to retry on error, u could implement RetryMiddleware for AioPikaBroker or define your own ack method for message
It is problem with AioPikaBroker and not Receiver

I agree with @Sobes76rus. The thing is that ack mechanism is intended to check on connection issues. For example if during reading message worker went down and couldn't process the message it would be given to another worker. But if message was received then it's up to the application to handle exceptions.


[iOS] Create xcframework with Gradle

Issue

close #459

Overview (Required)

Create XCFrameworks of KMM module with gradle.

@takahirom told me about this  https://github.com/DroidKaigi/conference-app-2021/issues/459#issuecomment-853481869, but I couldn't create with that. 😢
So I used plugin.

Add target in Package.swift about KMM module

Links

Screenshot

Before
After

Question

Build KMM module with iosArm64 architecture doesn't work. Is it an expected behavior?

I tried to build iosArm64 architecture framework with following.
Change this

  val iosTarget: (String, KotlinNativeTarget.() -> Unit) -> KotlinNativeTarget =
      if (System.getenv("SDK_NAME")?.startsWith("iphoneos") == true)
          ::iosArm64
      else
          ::iosX64

to
val iosTarget: (String, KotlinNativeTarget.() -> Unit) -> KotlinNativeTarget = ::iosArm64

I think the KMM module isn't currently available from iOS. Is it true?

When I tried to use **Repository in KMM module, it's concrete class can't instantiate. The class constructor's argument requires Api interface, but no implemented classes are available.
Will it be available after https://github.com/DroidKaigi/conference-app-2021/issues/445 implemented?

@takahirom @watanavex
I would appreciate it if you could answer 🙏🏼

I will check it🙏

I think this SDK_NAME is an environment variable that is added when it is executed in the build phase of XCode. Could you check it? 👀
https://matsukaz.hatenablog.com/entry/2015/07/06/090933

println("SDK_NAME:"+System.getenv("SDK_NAME"))
I think you can check the environment variable in build.gradle file.

I think this SDK_NAME is an environment variable that is added when it is executed in the build phase of XCode. Could you check it? 👀
https://matsukaz.hatenablog.com/entry/2015/07/06/090933

Yes! It's true.
I tried to call ./gradlew ios-framework:createXCFramework with terminal so SDK_NAME is none.
What I wanted to do here

Build KMM module with iosArm64 architecture doesn't work. Is it an expected behavior?

is creating framework for iosArm64 (for real device) is failed.
This means currently I think that it may not be possible to call KMM on the real device.
The result of executing ./gradlew ios-framework:createXCFramework is following 🙏🏼
gradle-createXCFramework.log

Thank you! I am looking 👀
         project :ios-framework
      > No matching variant of project :data:repository was found. The consumer was configured to find a usage of 'kotlin-api' of a component, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'native', attribute 'org.jetbrains.kotlin.native.target' with value 'ios_arm64' but:
          - Variant 'androidDebugAndroidTestCompile' capability conference-app-2021.data:repository:unspecified:
              - Incompatible because this component declares a component, as well as attribute

Could you try this?
export SDK_NAME=iphoneos
./gradlew ios-framework:createXCFramework

If you are doing the following, it will fail because there is a similar if statement in repository etc.
val iosTarget: (String, KotlinNativeTarget.() -> Unit) -> KotlinNativeTarget = ::iosArm64
https://github.com/DroidKaigi/conference-app-2021/pull/469#issuecomment-854914329

The Kotlin source set androidAndroidTestRelease was configured but not added to any Kotlin compilation. You can add a source set to a target's compilation by connecting it with the compilation's default source set using 'dependsOn'.
See https://kotlinlang.org/docs/reference/building-mpp-with-gradle.html#connecting-source-sets

> Task :data:db:generateIosMainDatabaseInterface

> Task :model:compileKotlinIosArm64

> Task :data:db:compileKotlinIos

> Task :data:api:compileKotlinIos

> Task :data:repository:compileKotlinIos
> Task :ios-framework:compileKotlinIos
> Task :ios-framework:linkReleaseFrameworkIos

> Task :ios-framework:createXCFramework
xcframework successfully written out to: /Users/takahirom/git/conference-app-2021/ios/build/xcframeworks/DroidKaigiMPP.xcframework

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/7.0/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 2m 20s

@takahirom

If you are doing the following, it will fail because there is a similar if statement in repository etc.

I understand!
I missed 🙏🏼
Thank you! The task succeeded!

@ry-itto
Did you able to build the XCFramework, which contains frameworks for ARM64 and X64?
If not, I would like to submit a PR to your branch to show my solution.
It seems like we need to update the workaround related to the hierarchical structure.

I think the KMM module isn't currently available from iOS. Is it true?

When I tried to use **Repository in KMM module, it's concrete class can't instantiate. The class constructor's argument requires Api interface, but no implemented classes are available.
Will it be available after #445 implemented?

https://github.com/DroidKaigi/conference-app-2021/blob/main/ios-framework/src/iosMain/kotlin/io/github/droidkaigi/feeder/IosModule.kt
You should be able to use the object resolved by Koin.

Did you able to build the XCFramework, which contains frameworks for ARM64 and X64?

No, I can't.
Currently, build target architecture only 😢

If not, I would like to submit a PR to your branch to show my solution.

Yes, please! 🙏🏼

@ry-itto
Please refer to https://github.com/ry-itto/conference-app-2021/pull/1
@takahirom @watanavex
If there is any better solution, please tell me.

Does this approach result in the iosMain directory being an arm64 directory instead of being shared? 👀
Some of the approaches I know are:
    if (System.getProperty("idea.active") == "true") {
        // Fix IntelliJ Unresolved reference
        def onPhone = System.getenv("SDK_NAME")?.startsWith("iphoneos") ?: false
        if (onPhone) {
            iosArm64("ios")
        } else {
            iosX64("ios")
        }
    } else {
        ios()
    }

This is not so good because the environment changes depending on whether it is executed from the terminal or from Idea.

@myihsan
Does this approach result in the iosMain directory being an arm64 directory instead of being shared? 👀
Some of the approaches I know are:
    if (System.getProperty("idea.active") == "true") {
        // Fix IntelliJ Unresolved reference
        def onPhone = System.getenv("SDK_NAME")?.startsWith("iphoneos") ?: false
        if (onPhone) {
            iosArm64("ios")
        } else {
            iosX64("ios")
        }
    } else {
        ios()
    }

This is not so good because the environment changes depending on whether it is executed from the terminal or from Idea.

Maybe if you use this, you can go only with ios(). .. It may not be realistic as it takes time to investigate.
https://github.com/LouisCAD/CompleteKotlin

Does this approach result in the iosMain directory being an arm64 directory instead of being shared? 👀

I am not sure what you mean, but it's being shared by iosX64Main.dependsOn(it).
And the product (XCFramework) can be run both on a simulator and a real device, so it seems no problem.
The solution you provided can cover most cases, but how about run the iOS app from Android Studio using KMM plugin?

Sorry, I'm late checking this.
I'll catch up soon. 👀

@myihsan
Thank you!
I missed iosX64Main.dependsOn(it) 👀
I didn't know it would work this way.
It's important to be able to do it for the time being, so I think it's good! 👍
I think it's better to do just one, how about fixing it as follows?
I'm afraid that if one source set makes changes to another source set, it will be difficult to find the correct information.
        val iosX64Main by getting
        val iosMain by getting {
            dependencies {
                implementation(Dep.Koin.core)
            }
            iosX64Main.dependsOn(this)
        }

↓
        val iosMain by getting {
            dependencies {
                implementation(Dep.Koin.core)
            }
        }
        val iosX64Main by getting {
           dependsOn(iosMain)
        }

@takahirom
You are right! I have followed the document of hierarchical structure without enough thought.
I will fix it.

@myihsan
I have no better ideas.
and I've learned a lot from your idea 👏

@myihsan
Please tell me if the PR is ready to review 🙏🏼
Should @takahirom review for this PR (https://github.com/ry-itto/conference-app-2021/pull/1) and approve this as well?

@ry-itto
It's ready! I fixed build.gradle as takahirom has told me.

@takahirom
Thank you for your review!
But the CI task ( test-ios ) failed still remains 😢
Please help about that?
It seems like a gradle task iosTest is ambiguous.
https://github.com/DroidKaigi/conference-app-2021/runs/2753974134?check_suite_focus=true

It seems that GitHub Actons does not have iosTest settings anymore, so I thought that CI settings might not be reflected unless merged.

It occurs my local environment too...
FAILURE: Build failed with an exception.

* What went wrong:
Task 'iosTest' is ambiguous in root project 'conference-app-2021'. Candidates are: 'iosArm64TestBinaries', 'iosArm64TestKlibrary', 'iosArm64TestProcessResources', 'iosTestBinaries', 'iosTestKlibrary', 'iosTestProcessResources', 'iosX64Test', 'iosX64TestBinaries', 'iosX64TestKlibrary', 'iosX64TestProcessResources'.

I will check it 👀

The task called iosTest is gone, and this PR removes it from the CI settings.
What task did this error run?
https://github.com/DroidKaigi/conference-app-2021/pull/469#issuecomment-855348465

The CI setting of ios-test originally renamed with test-ios in https://github.com/DroidKaigi/conference-app-2021/pull/471 .
Currently, renamed originally CI setting is failing.
The task is still iosTest.
This PR's change can be ignored.

I think that the CI settings will be reflected if they are merged.
How about reverting if it doesn't work? 👀

ok, I will merge this 🙏🏼


refactor: use hyper-rustls

From https://github.com/metrics-rs/metrics/pull/420#discussion_r1435328304:

After doing some reading, it seems like we should probably just switch to using rustls entirely.
I don't think the initial implementor choose to use hyper-tls specifically for the OS-backed/dynamically-linked aspect, and I don't personally care about esoteric SSL/TLS setups or FIPS compliance or any of that... so I'd rather go with a single solution than force users to have to spend time understanding which one they ought to choose.

This PR switches to hyper-rustls.

@tobz what do you think?

I'm going to try to get this released today.

Released in<EMAIL_ADDRESS>Thanks again for your contribution!

Thank you for merging and for the release! Have a great evening.


Fixes exit code of spellcheck test

Travis tests were not failing even though the test reported misspelled words.

One review is sufficient for merge.

I have strong recollection of using the "|xargs" way because it worked better than the "find - exec" in  regards to return codes.. I wonder if there's still some corner case. Oh well, I guess time will tell :)


Fix bumpversion config

Fix bumpversion config
Update to 2.1.4

Coverage remained the same at 28.924% when pulling f3be4f9450a201b58ea9d1134a6601f663e99d6b on update-2-1-4 into 3859c38f2b9ef732224611d0e4ee9bc25f0ffc3c on 2.1.


PHOENIX-5860 Throw exception which region is closing or splitting when delete data

@joshelser @gjacoby126 @swaroopak   , hello , could you please review this?
Thanks

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
5m 35s
Docker failed to build yetus/phoenix:871ed211e.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/phoenix/pull/874

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-874/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@joshelser , @stoty ，hello, I alter this code that postRollBackSplit. could you please review this?

Hi @wangchao316 , the logic looks good to me, do you have anything to add @joshelser ?

@joshelser ，hello， do you have anything to add?

(sorry for the wide ping)
@virajjasani @gjacoby126 @ChinmaySKulkarni @apurtell have any of your noticed this one in 1.x? The change seems reasonable to me, but I haven't kept up with the later 1.x HBase releases to have confidence in the issue and fix.

Thanks @joshelser for bringing this up. I just realized that we have this exact same issue reported sometime back this year with Phoenix 4.14.x + HBase 1.3.x for Delete queries.
Changes indeed look reasonable and simpler to understand.
I am confident about existence of the issue (not the fix though). And @wangchao316 seems to have been able to consistently repro this with minor changes in HBase split code by failing split all the times and let the flow through rollback of split, as per Jira comments.
However, let's trigger a QA run first, we don't have clear QA result on PR. If we don't see any issue, I am +1 for rolling out this change, feels worth shipping.
@gjacoby126 @ChinmaySKulkarni @apurtell Thought?

Precommit results are available: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/229/testReport/
Looks good, failures don't seem relevant. +1(non-binding) for this PR.
Thanks @wangchao316

+1. It's really required to avoid issues on split rollback cases.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 20s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
11m 12s
4.x passed

+1 :green_heart:
compile
0m 55s
4.x passed

+1 :green_heart:
checkstyle
0m 39s
4.x passed

+1 :green_heart:
javadoc
0m 44s
4.x passed

+0 :ok:
spotbugs
2m 54s
phoenix-core in 4.x has 950 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 26s
the patch passed

+1 :green_heart:
compile
0m 56s
the patch passed

+1 :green_heart:
javac
0m 56s
the patch passed

-1 :x:
checkstyle
0m 38s
phoenix-core: The patch generated 3 new + 364 unchanged - 0 fixed = 367 total (was 364)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 43s
the patch passed

+1 :green_heart:
spotbugs
3m 11s
the patch passed

_ Other Tests _

-1 :x:
unit
136m  2s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

170m 58s

Reason
Tests

Failed junit tests
phoenix.end2end.index.LocalImmutableTxIndexIT

phoenix.end2end.IndexBuildTimestampIT

TEST-[RangeScanIT_0]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-874/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/874

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 64dce7320f26 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 277b6fd

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-874/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-874/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-874/3/testReport/

Max. process+thread count
6709 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-874/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

+1. It's really required to avoid issues on split rollback cases.

Thanks, can you please merge?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
11m  0s
4.x passed

+1 :green_heart:
compile
0m 55s
4.x passed

+1 :green_heart:
checkstyle
0m 38s
4.x passed

+1 :green_heart:
javadoc
0m 44s
4.x passed

+0 :ok:
spotbugs
2m 53s
phoenix-core in 4.x has 950 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 26s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

-1 :x:
checkstyle
0m 38s
phoenix-core: The patch generated 5 new + 362 unchanged - 2 fixed = 367 total (was 364)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 46s
the patch passed

+1 :green_heart:
spotbugs
2m 59s
the patch passed

_ Other Tests _

-1 :x:
unit
140m 21s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 39s
The patch does not generate ASF License warnings.

171m  8s

Reason
Tests

Failed junit tests
phoenix.query.MaxConcurrentConnectionsIT

phoenix.end2end.AlterTableWithViewsIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-874/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/874

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 0aa40ae946ff 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 18b9f76

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-874/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-874/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-874/4/testReport/

Max. process+thread count
6597 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-874/4/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


drivers: flash: at45: Add Reset and WP pins

Adding Reset and Write-protect pins initialization during AT45 driver
start-up. Usually, these pins are driven high when not used.
The AT45 device incorporates an internal power-on reset circuit, so
there is no initial on-off reset sequence.
This PR should replace my earlier PR with only Reset pin control
https://github.com/zephyrproject-rtos/zephyr/pull/32417
Signed-off-by: Eug Krashtan<EMAIL_ADDRESS>

@mbolivar-nordic  Please, can you review this PR as you wrote a lot of comments to the previous variant? Thank you.


Suprious? warnings

The following code works, but generates warnings along the way:
<wpt title="
	This section has good overall test coverage,
	particularly through tests for [[#white-space-processing]] and subsections.

	Missing tests:
	* No test of Namimation type
	* Intrinsic (min and max) sizing tests for ''white-space/normal'' and ''nowrap''."></wpt>

The output is exactly what I'd expect, but during the build, Bikeshed emits this:
/Users/florian/Library/Python/3.7/lib/python/site-packages/html5lib/_ihatexml.py:258: DataLossWarning: Coercing non-XML name: 'white-space
  warnings.warn("Coercing non-XML name: %s" % name, DataLossWarning)
/Users/florian/Library/Python/3.7/lib/python/site-packages/html5lib/_ihatexml.py:266: DataLossWarning: Coercing non-XML name: normal'''
  warnings.warn("Coercing non-XML name: %s" % name, DataLossWarning)
/Users/florian/Library/Python/3.7/lib/python/site-packages/html5lib/_ihatexml.py:258: DataLossWarning: Coercing non-XML name: 'nowrap'''
  warnings.warn("Coercing non-XML name: %s" % name, DataLossWarning)
/Users/florian/Library/Python/3.7/lib/python/site-packages/html5lib/_ihatexml.py:266: DataLossWarning: Coercing non-XML name: 'nowrap'''
  warnings.warn("Coercing non-XML name: %s" % name, DataLossWarning)

First, woah, that damn error finally tells you what it is that's messed up, yay!
 I'm very surprised it appears to be working. I suspect that maybe the Markdowning that happens before HTML parsing is having fun on that.
I'll investigate, but if that's the case, then we should move the title text from an attribute to a child element.

Moving to a child element would seem a lot cleaner in general (and then we could remove the special processing of "lang" and "dir"), but I went with an attribute for compat with previous markup.
That said, while this does seem to indicate that something is messed up, the actual output is perfectly good, so somehow it's falling back on its feet.


⭐FEAT: Styling the search bar and scrollbar.

Is your feature request related to a problem? Please describe.
-The search bar isn't too good looking, and the alignment of it isn't proper, the margin on top is more than bottom.
-The scrollbar need to be enhanced.
Describe the solution you'd like
-I would like to add some styles and icon in the searchbar
-I would like to add some styles to the scrollbar as well.
Could you please assign me this issue, I would like to work on it.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Thanks

@kaur-rajdeep Sure thing , You can proceed. Make sure you read the project Guidelines and Contributing Guidelines well. Thankyou

@ArslanYM Hey, can i work on this issue?

@inbuilt-aura This issue is closed.


Link correction

The link in the excerpt below leads to a paper called: "Hyper-algebraic invariants of p-adic algebraic numbers"
Moe-llava: Mixture of experts for large vision-language models. arXiv, 2024 [Paper]
The correct link is:
https://arxiv.org/abs/2401.15947

Thank you for reporting this issue! I have already fixed the error and submitted the corresponding changes.


Incorrect path in "Create DAX Calculations in Power BI Desktop, Part 1" lab

Lab is referencing "D:\PL300\Labs\05-create-dax-calculations-in-power-bi-desktop\Starter"
This path does not exist.
It should be referencing "D:\PL300\Labs\04-create-dax-calculations-in-power-bi-desktop\Starter"
Edit: Recommend verifying all labs for similar issues.

This issue has been addressed.


[EAGLE-569]: AlertPublishImpl: Concurrency : Inplace change metadata …

…cause concurrent modification issue
Author : ralphsu

Fix to use copy&swap way to refresh metadata changes.


fix get tenantCode my NPE

For #1465
1 fix get tenantCode my NPE
2 add ResourcesServiceTest
modify class
ResourcesService
add UT
ResourcesServiceTest
modify root pom
<include>**/api/service/ResourcesServiceTest.java</include>

Codecov Report

Merging #1684 into dev will increase coverage by 2.4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##              dev   #1684     +/-   ##
========================================
+ Coverage   15.09%   17.5%   +2.4%
========================================
  Files         283     283
  Lines       13801   13817     +16
  Branches     2244    2250      +6
========================================
+ Hits         2083    2418    +335
+ Misses      11496   11148    -348
- Partials      222     251     +29

Impacted Files
Coverage Δ

...dolphinscheduler/api/service/ResourcesService.java
79.85% <100%> (+79.85%)
:arrow_up:

...ache/dolphinscheduler/api/service/BaseService.java
77.77% <0%> (+22.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22a2d43...3260412. Read the comment docs.


requirements.txt

We're in the process of adding automatic dependency resolution and unfortunately we realized our plugin.json wasn't the best choice and are instead going to be using the python-standard requirements.txt. We've got a blog post coming soon with more details but if you want to make a requirements.txt and get a head start, that'd be great!

Are you willing to accept a PR for this?

Ping -- happy to submit a PR for this, just would need you to generate the release once done.

Sorry I totally haven't been paying any attention to this repo, if you still care/if this is still valuable, I'll generate the release.

Honestly, given our recent improvements that do this out of the box i'm not sure it's necessary anymore. I'm inclined to just remove it from the plugin manager unless you want to update it as an example plugin and there may indeed still be some cases that z3 can solve that our default implementation cannot so either way, it's up to you.

Yup, let's just remove it from the manager. This being in product is just better. :)


Adaptive (n, 1, p)-QRACs

Summary
Details and comments

I'm going to close this, since it is being superseded by other PRs.  There's a lot of good stuff in here, but we're going to make each change one at a time instead.  It will nonetheless be useful to reference this from time to time.


Update galculator for our new launcher

Clean as well plugs and now, hook it up to current desktop theme (don't enforce Mate one).
Make also menus working in  unity7.

This change is

Comments from Reviewable

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Include tasks for debugging SU 2019 and 2020

Currently only 2017 and 2018 are available by default.

Oh, yea, this needs to be kept up to date.

I have started using a single task in newer projects, where the task has options to choose from for each SU version:
https://github.com/SketchUp/sketchup-live-c-api/blob/master/.vscode/tasks.json
Upon first run you'd pick which version, then on consecutive runs you'd Run Last Task.

Fixed as part of 1ef2da8c5a15189447b42edd4e448ae35e3b0be9


can't search in safari

I can search correctly by searching for “l” in the example of this site.
https://select2.org/selections
However, I can't search correctly if I do the following:

by searching for "aaaaa" in the example of same site in safari.
delete "aaaaa".
key press ↓or↑key.
by searching for “I” again.
I can't search it.

Can you expand upon the issue you are facing by adding a few more pieces of information to your bug report?

What browser(s) and Operating System have you tested with?
Does the bug happen consistently across all tested browsers?
Can you reproduce this issue on any of the examples in the docs?
What version of jQuery are you using? And what version of Select2?
Are you using Select2 with other plugins?

The contributing guide contains a useful section with a few questions which can help us track down the bug and speed up the process of finding a fix for it.  The creation of an isolated test case would also be useful.

What browser(s) and Operating System have you tested with?
this bug appears only mac+safari.

Does the bug happen consistently across all tested browsers?
safari.

Can you reproduce this issue on any of the examples in the docs?
What version of jQuery are you using? And what version of Select2?
Are you using Select2 with other plugins?

As described in the report above, it occurs on the following demo sites:
https://select2.org/selections

by searching for "aaaaa" in the EXAMPLE under templating.
2.delete "aaaaa".
3.key press ↓or↑key.
4.by searching for “I” again.
5.I can't search it.


Update MS Edge user client string

In Main.awk, the MS Edge user client is specfied as Edg. Change this to Edge.
Not sure if this was intentional or not, please ignore if so. :+1: :rocket:

Can you confirm if the latest Microsoft Edge UA string is Edg or Edge?
I don't have the Edge browser installed right now, but according to Microsoft's own documentation, it's just "Edg":
https://learn.microsoft.com/en-us/microsoft-edge/web-platform/user-agent-guidance#user-agent-strings
Also according to this stackoverflow comment: https://stackoverflow.com/questions/30591706/what-is-the-user-agent-string-name-for-microsoft-edge#comment122093306_33505753 , it was changed from Edge to Edg since 2019.

@soimort you are correct, the modern user agent is Edg. When I went to confirm this, I was looking at outdated documentation from 2017. This PR can be disregarded. :pray:


Handle ctrl-c

See https://github.com/pygfx/pygfx/issues/377
Inspired mostly by https://github.com/encode/uvicorn/blob/master/uvicorn/server.py
Sending sigint will stop the event loop, if we're the one running it. These changes improve the behavior of the base loop implementation, so that the subclasses can actually be made quite a bit simpler.

[x] Tested on MacOS
[x] Tested on Windows
[x] Tested on Linux

Interrupt (ctrl-c) simply calls loop.close(). This will first (attempt to) close all canvases. When all canvases are closed, the loop ends. If for some reason the windows do not close, one can close/interrupt called again to close the loop without closing the windows.


tools: upgrade linter version to v1.46.2

I was getting the following error after cleaning my go mod cache:
verifying<EMAIL_ADDRESS>checksum mismatch
        downloaded: h1:ZZq2bmyssGh8MSPz3VVziqRNIMYTJXzP8MUKG90vZ9A=
        go.sum:     h1:jMzDa13teAuv/KLeqgJw79NDe+1IT0ZO3Mht0vN1Yls=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

This dependency was used by the previous version of golangci-lint and an upgrade fixed the problem.
The new version also brings a couple of new rules, one of which we disable and one of which we fix.

@sputn1ck PTAL.

I was not able to reproduce the checksum mismatch though.

I think that only happens if you run go clean -modcache and it has to download all modules again. So I wouldn't recommend running that, even though it can free up multiple gigabytes of space on your disk.


[SPARK-21728][core] Allow SparkSubmit to use Logging.

This change initializes logging when SparkSubmit runs, using
a configuration that should avoid printing log messages as
much as possible with most configurations, and adds code to
restore the Spark logging system to as close as possible to
its initial state, so the Spark app being run can re-initialize
logging with its own configuration.
With that feature, some duplicate code in SparkSubmit can now
be replaced with the existing methods in the Utils class, which
could not be used before because they initialized logging. As part
of that I also did some minor refactoring, moving methods that
should really belong in DependencyUtils.
The change also shuffles some code in SparkHadoopUtil so that
SparkSubmit can create a Hadoop config like the rest of Spark
code, respecting the user's Spark configuration.
The behavior was verified running spark-shell, pyspark and
normal applications, then verifying the logging behavior,
with and without dependency downloads.

Test build #80945 has started for PR 19013 at commit 400f0ad.

Test build #80945 has finished for PR 19013 at commit 400f0ad.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80945/
Test FAILed.

Test build #80948 has started for PR 19013 at commit 425d9ce.

Test build #80948 has finished for PR 19013 at commit 425d9ce.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80948/
Test FAILed.

Merged build finished. Test FAILed.

Test build #80949 has started for PR 19013 at commit 3d6016e.

Test build #80949 has finished for PR 19013 at commit 3d6016e.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80949/
Test FAILed.

Merged build finished. Test FAILed.

Retest this please.

Test build #80963 has started for PR 19013 at commit 3d6016e.

Test build #80963 has finished for PR 19013 at commit 3d6016e.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80963/
Test FAILed.

Merged build finished. Test FAILed.

Retest this please.

Test build #80967 has started for PR 19013 at commit 3d6016e.

Test build #80967 has finished for PR 19013 at commit 3d6016e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80967/
Test PASSed.

Test build #81000 has started for PR 19013 at commit 16df85a.

Test build #81000 has finished for PR 19013 at commit 16df85a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81000/
Test PASSed.

Test build #81135 has started for PR 19013 at commit 8665f71.

Test build #81135 has finished for PR 19013 at commit 8665f71.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81135/
Test PASSed.

retest this please

Test build #81224 has started for PR 19013 at commit 8665f71.

Test build #81224 has finished for PR 19013 at commit 8665f71.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81224/
Test PASSed.

Merging to master.


berry simply does not launch (Arch)

I just git cloned the repo because the AUR package is broken at the moment. I successfully built it, changed the config, adjusted my .xinitrc but it simply does not launch. I tried to get some output with Xephyr but that does not seem to indicate any issues:
berry: font not specified, loading default font
berry: Successfully opened display
berry: Giving focus to dummy window
berry: Successfully assigned atoms
berry: Successfully set initial properties
berry: Setting up monitors
berry: Found 1 screens active
berry: Screen #0 with dim: x=0 y=0 w=800 h=600
berry: Successfully setup monitors
berry: Allocating color values
berry: Receieved new 16 event
berry: Receieved new 16 event
berry: Receieved new 19 event
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Handling config command of type 14
berry: Data has value 8
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Handling config command of type 15
berry: Data has value 2
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Handling config command of type 16
berry: Data has value 24
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Changing edge gap...
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Handling config command of type 7
berry: Data has value 2632246
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Handling config command of type 8
berry: Data has value 2632246
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Handling config command of type 9
berry: Data has value 9169405
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Handling config command of type 10
berry: Data has value 4474714
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Handling config command of type 11
berry: Data has value 0
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Handling config command of type 12
berry: Data has value 0
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Handling config command of type 33
berry: Data has value 0
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Handling config command of type 35
berry: Data has value 1
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Handling config command of type 34
berry: Data has value 1
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Handling config command of type 47
berry: Data has value 1
berry: Receieved new 33 event
berry: Handling 33 event
berry: Recieved event from berryc
berry: Handling new set_font request
berry: Getting text property
berry: Converting to text list
berry: Opening font by name

autostart, sxhkdrc and xinitrc

Perhaps try launching sxhkd in the background. i.e.
sxhkd -c "$HOME/.config/sxhkd/berry-sxhkdrc" &

Thanks, you have no idea how stupid I feel right now...


Development

Getting started with the portfolio by adding text, styling, and basic infrastructure for a two column structure.
The given index.html had nothing about me, so I added (a lot of unnecessary)  details about myself. I plan to model my portfolio after an old myspace profile, which has two columns, so sections have been marked with either left or right.

Once I finish all the things here, do I do another push request?

So after getting a pull request reviewed and approved you can merge it then create another branch to work on another part of the code or even use the same branch to keep doing work and then create another pull request when it's ready again.
Also don't forget to mark conversations as resolved when you are done with them so I can tell which ones. You are planning to do more for or which ones you're done with. https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request#resolving-conversations


feat: HTTPS local registry

Enabling HTTPS for the in-cluster registry
The in-cluster registry is required to run in HTTPS mode. This requires a few setups, secrets and generated certificates. In the development environment, this is already taken care of.
Secrets can be defined for production environments so the controllers can talk to the HTTPS registry.
Configuration
A set of Certificates needs to be provided to configure the HTTPS registry. There are three locations where certificates need configuration.
First, the Registry. The volume patch is located under config/registry/patches.
      containers:
        - name: registry
          image: registry:2
          env:
            - name: REGISTRY_HTTP_TLS_CERTIFICATE
              value: "/certs/cert.pem"
            - name: REGISTRY_HTTP_TLS_KEY
              value: "/certs/key.pem"
            - name: REGISTRY_HTTP_TLS_CLIENTCAS_0
              value: "/certs/ca.pem"
          volumeMounts:
            - mountPath: "/certs"
              name: "registry-certs"
      volumes:
        - name: "registry-certs"
          secret:
            secretName: "registry-cert"
            items:
              - key: "cert.pem"
                path: "cert.pem"
              - key: "key.pem"
                path: "key.pem"
              - key: "ca.pem"
                path: "ca.pem"

Second, the Controller.
The developer certificates share the server and the client certs. This is a convenience. In product environments, you can provide the server certs to the registry and the client certs to the controllers.
The controller also has a patch like the above under config/manager/patches:
      containers:
        - name: manager
          image: open-component-model/ocm-controller
          volumeMounts:
            - mountPath: "/certs"
              name: "certificates"
      volumes:
        - name: "certificates"
          secret:
            secretName: "registry-certs"
            items:
              - key: "cert.pem"
                path: "cert.pem"
              - key: "key.pem"
                path: "key.pem"
              - key: "ca.pem"
                path: "ca.pem"

Another optional setting on the controller is the location of the secrets mounted into the controller. They can be changed to a different location. Change the mount location, then set the following three command line options:
	flag.StringVar(&ociRegistryCertLocation, "cert-file", v1alpha1.DefaultRegistryCertFileLocation, "The location of the cert file.")
	flag.StringVar(&ociRegistryCertKeyLocation, "key-file", v1alpha1.DefaultRegistryKeyFileLocation, "The location of the key file.")
	flag.StringVar(&ociRegistryCALocation, "ca-file", v1alpha1.DefaultRegistryCaFileLocation, "The location of the root ca file.")

The default location is /certs.
Generating Certs / Using Trusted Certificates
There are many ways of generating a certificate. With openssl, cfssl, mkcert and others.
The ocm-controller chooses to build developer certificates using mkcert. However the certificates are provided, they must be trusted by the system that uses the controller.
We are doing this in the controllers and on CI via an entrypoint.sh script. This script will take the root certificate from a specific location ( later on could be configurable via environment properties passed to the controller ) and append it to the ca-certificates.crt container root certificate. This is to ensure that the controller trusts the certificate provided to it.
Creating Secrets
Once the certificates are generated, create and apply the secret containing them. We using kubectl to do this.
kubectl create secret generic \
  -n ocm-system registry-certs \
  --from-file=ca.pem="certs/ca.pem" \
  --from-file=cert.pem="certs/cert.pem" \
  --from-file=key.pem="certs/key.pem" \
  --dry-run=client -o yaml > ./registry_certs_secret.yaml

Developer Certificates
We need two things to run tests like our e2e tests on CI or locally. First, the generated self-signed certificate must be trusted locally, and second, the GitHub action runner environment.
Tilt
Tilt will handle everything for the local user once the secret exists. For local development, when not running e2e tests with make e2e the secret has to be generated before tilt up can be executed.
To generate the secret simply run ./hack/create_developer_certificate_secrets.sh. This will do two things. First, generate some certificates under hack/certs and second, generate the secret Tilt will use to apply to the cluster. Then, tilt up can be run as before.
When running the make e2e target, it will ensure that mkcert is installed, mkcert -install is executed, and that the secrets exist and are applied to the cluster. No additional actions will have to be done by the user when running end-to-end tests.
CI
The observant eye will see that the script for generating certificates under hack is full of sudo paragraphs. This is because GitHub action containers will not update the certificate unless run with sudo, and mkcert will fail to install the certs at the system trust store.

Finally works locally. There are some adjustments left on unit tests and the e2e test.

@Skarlso Let's not forget that after this is done, I need to build and push a new version of Repository.

Last request from my is that we add a decent overview to the PR description. I can use this as a basis to update the installation docs for the controller on the website with a section regarding configuring HTTPS.

@phoban01 Absolutely. I'm writing it up.

@phoban01 Added a huge description. I hope it's okay?

Note: adding certs to OciRepository.

I'll update the description once I implement providing a secret name instead.

MPAS flow is working.
Relevant PRs are tagged.

yes if we plan to enforce https, better to fail early.

This should not be needed once we apply latest OCM. That won't happen in this PR though to avoid breaking changes form the OCM library. We'll apply the fix in a follow-up.


IEnumerable in query parameter is not working

If you have the following model
public class MyCriteria {
    public List<String> Tags {get;set}
}

Then the following Controller
public List<Pet> FindPets([FromUri] MyCriteria c) {
    ...
}

Then the generated swagger spec seems to be missing something since that is what I see in sawagger-ui :

Whereas you can see this is working on swagger-ui demo (http://petstore.swagger.io/#!/pet/findPetsByTags)

Also note that if I have a List of MyEnumType, it should generate a swagger spec that can render (http://petstore.swagger.io/#!/pet/findPetsByStatus)

I think this is a bug in how swashbuckle use the multiple parameter of swagger spec, but I am no specialist ...
Thanks for your help

You might just need to upgrade. There was an issue around this in a previous version of the swagger-ui but it was fixed and integrated back into SB. Just verified, both cases above work as expected in the latest version of SB - 5.2.1

i'll check that tomorrow but i think we've upgraded to SB 5.2.1 last week...

We have upgraded to 5.1.5 so I close this issue and I'll get back to you if the bug persist when we have  a chance to upgrade to 5.2.1


trace: drop HTTPClient in favor of http.Client

Hi,
After playing around with the trace package, I've realized that as it is today, *HTTPClient can't be used anywhere where the *http.Client is used.
By looking at it, all that the current HTTPClient does it to proxy the Do() method to the underlying *http.Client. The NewHTTPClient method also could be changed to return a standard *http.Client ` instead of the custom one given that the trace happens at the transport not the client itself.
Doing this would allow instrumenting virtually all applications that use *http.Client without having to change anything or resort to things like: https://github.com/nlopes/slack/blob/c86337c0ef2486a15edd804355d9c73d2f2caed1/misc.go#L23...L25 in order to abstract the clients away from the library.
I'd be ok to send the CL if approved.

cc @rakyll

I am fine with just exporting the RoundTripper, please send a CL.

I've opened this: https://code-review.googlesource.com/#/c/13490/ not sure how to link it to here unfortunately.

 I'm familiar with git itself but this codereview tool is not really helpful unfortunately :( As far as I can see: https://godoc.org/golang.org/x/review/git-codereview#hdr-Rebase_work is not present as a command in the tool but it's mentioned in the docs.

Oh no problem! Ya, it's confusing at first.
So if you haven't set up aliases (eg you ran git codereview change) initially, you can run git codereview change again and you'll get an editor where you can modify the commit message. Saving buffer will update the commit. And then git codereview mail again to push the changes up to the CL.
If you had modified files, you'd need to git add them as usual before running git codereview change again.
If you've set up aliases as described at the top of https://godoc.org/golang.org/x/review/git-codereview, (eg you ran git change) initially, then just git change again.

Also, to rebase against master, git codereview sync.

Awesome! Thanks, that should be in the description of how to use the tool.

^ is in CONTRIBUTING.md in this project root.
it's also in the documentation of the tool, just not spelled out very explicitly. It's in paragraph form at the top of the godoc.
CLs welcome for both docs!


For PyPI packages, prefer source distribution over wheel distributions

Easier to validate?

Well, the directory structure for wheel and source distribution can be different. Example: hypothesis package.
An option should be passed down.


Questions about BIDS Labeling

We are working on setting up BIDS formatting at UCLA. The goal is take the data directly from the scanner servers and move it either to a personal computer or our cluster and have the data in BIDS format with little effort on the users part. We have been taking our old script and modifying it to follow BIDS format. While we have been doing that, we ran into some questions that we did not know the answers to and though we should ask.

Where should the scouts files go and how should they be named?

This appears to be brought up in another post but it is not clear what the conclusion is. Our MPRAGE images come with NORMalized (intensity normalization performed by the scanner software) and original raw T1w scans. There seemed to be a suggestion to have _proc identify it. What will the label be for the normalized and non-normalized images and will both or only one need that label?

When we have a study with multiple runs, we tend to name the BOLD scan in the scanner with either the same name (e.g. BOLD_AP and BOLD_AP) or by naming each run with a different name (e.g. BOLD_AP_Block01 and BOLD_AP_Block02). This might cause an issue when the code has to determine the run numbers itself if there are different naming conventions. This same issue applies to the task name (e.g. figuring out if it should be task-bold, task-rest, task-loc, etc). We would like to have our code be smart enough to automatically take the name of the run from the scanner and label it correctly in BIDS format. I assume it require everyone to change the name of their scan in the scanner for the BIDS script to work properly (unless there is a better way). Is there any agreement on what the names of the run in the scanner should be?

Relate to the previous issue, what happens if there is a run that was rerun and the first run's data should be discarded. This is could be because the trigger didn't catch, the code had to be restarted, or whatever. In an ideal world, the BIDS code could tell the same scan was run twice and name the second scan the normally and the first scan would have to have some sort of identifier saying this is a throw away scan. I assume this would require us to name each scan with a unique name (e.g. BOLD_AP_Block01 and BOLD_AP_Block02) so it can tell the same scan was ran twice. Has anyone else solved this issue?

This is more of a minor point but I know there is a push to no longer use the "subject" and instead use the term "participant". Unfortunately it seem the BIDS formatting uses sub everywhere. Do we have to use that naming convention? Is there another term we can use? Do scripts like fMRIPrep require sub term to be used?

Thanks for both of your feedback!
This does open the door to a potential set of rules on how people should name their scans before they start their study. I assume most people name their scans without thinking much about it. If we want BIDS to be well adopted by a lot of groups, it needs to be as simple and "idiot proof" as possible. Heudiconv is usefully, however, the user has to upload a file to inform the code which scans are what. If there is an established convention on the name of the scan, there will be no need upload a file and it will make easier on the user.


Manual Entries for Windows Auth - Feature

SQL Operations Studio Version: 0.26.7 MacOS

It would be great to have an option where someone can manually enter a domain account and password for the Windows Authentication option.  Use case: I am required to use an AD account that is not my normal working account to do DBA related tasks.
As a workaround, I tried using "open Electron" after running an "su" to my other account, which is as close to a Windows style "Run As" that I can find.  The following message is returned:
$ cd /Applications/SQL\ Operations\ Studio.app/Contents/MacOS/
$ open Electron
LSOpenURLsWithRole() failed with error -10810 for the file /Applications/SQL Operations Studio.app/Contents/MacOS/Electron.

We are tracking this request in issue https://github.com/Microsoft/sqlopsstudio/issues/112.  Please add comments to that issue if desired.  Thanks!


Add more context to service errors

Fix #347

@ilgooz I wanted to do only a small PR to finish the 1.1 milestone. Let's continue on the v1.2 milestone.


SVG and tree view examples don't work on Mac or Win8.1

The following examples don't work on my MBP Chrome or Safari and Windows 8.1 Chrome or IE11:
http://vuejs.org/examples/svg.html
http://vuejs.org/examples/tree-view.html

This was most likely due to jsdelivr CDN errors during a version upgrade. They work fine now.


Beamlattice SetRepresentation doesn't work - lib3mf v2.0.0 alpha and older versions

Beamlattice_SetRepresentation.zip
Please refer attached code/VS solution to recreate the problem.
CBeamLattice::SetRepresentation() does not set the representation mesh object the beam lattice.

Thanks for the notification. It's fixed now.


KeepAliveInterval doesn't seem to work

In my StartUp class of ASP.Net app hosted using WebListener, I am adding the WebSocketMiddleware as follows:
            var webSocketOptions = new WebSocketOptions
            {
                KeepAliveInterval = TimeSpan.FromSeconds(30),
            };
            app.UseWebSockets(webSocketOptions);

Then I am creating WebSockets as follows:
        public async Task Configure(HttpContext hc, Func<Task> next)
        {
           var webSocket = hc.WebSockets.AcceptWebSocketAsync();
           /// ...
        }

The value I use for KeepAliveInterval doesn't seem to have any effect and it still seems to take up to 2 minutes to send a ping.
I am currently using Microsoft.AspNetCore.WebSockets 1.0.2.
Am I doing anything wrong?

Takes up to 2 minutes for what? To send a Ping?

Yes.

Any thoughts?

The relevant code:
https://github.com/aspnet/WebSockets/blob/c65e8681c4a50fc33c263d1f42dfcf007cb5c035/src/Microsoft.AspNetCore.WebSockets/Internal/fx/src/System.Net.WebSockets.Client/src/System/Net/WebSockets/ManagedWebSocket.cs#L487-L501
It does have that else clause that says it will skip sending a Ping if any other send is already in progress.

Ok. In my experiments, there was pretty much no traffic other than the pings so there shouldn't be any contention on the lock.

This issue was moved to aspnet/Home#2464


-- link exposes Coder without authentication

OS/Web Information

Web Browser: Firefox
Local OS: Windows 10 x64
Remote OS: Ubuntu 20.04.2 LTS
Remote Architecture: GNU/Linux 5.4.0-29-generic x86_64
code-server --version: 3.9.3 fe2dc2deb08e378069891b622bb62ad1d261d1b1

Steps to Reproduce

run code-server --link

Expected
After using the option code-server --link for running code-server:

coder can now be accessed via xxx.cdr.co
coder is secured by authentication (by default Github as far as I understood)

Actual

coder can now be accessed via xxx.cdr.co
coder is secured by authentication only when accessed via xxx.cdr.co URL
coder's authentication is disabled when accessed via http on original Server:

after running sudo ss -tulpn
and one of the returned values being:
tcp        LISTEN      0           4096                               *:44481                        *:*          users:(("coder-cloud-age",pid=1266891,fd=7))
from any machine Coder is now accessible using http://XXX.XXX.XXX:44481/
Notes
In case this is caused by misconfiguration on my end, I'd be glad to be hear how I can fix this
hoping there is a simple fix

as it turns out, after thinking about this issue a bit, Coder being accessible was caused by my disabled firewall.
I think this fixes my issue but maybe it would be worth a shot to not turn off authentication when using Coder using --link. due to if the firewall is disabled (or from a local address) it can easily be accessed

It listens on localhost so it should only be accessible from within that machine unless something is proxying external requests to it. That limits the attack surface somewhat but I think we can do better.
One of the thoughts i had was to use a socket to communicate between code-server and the agent instead of listening on a port.
That way you could only access code-server if you have the right permissions which would mean you already have access to the machine anyway.

Closing as a duplicate of https://github.com/cdr/code-server/issues/2484


gisticOncoPlot: unable to display annotation

> gisticOncoPlot(gistic, showTumorSampleBarcodes=T, clinicalData=clinical, clinicalFeatures="Histo", annotationColor=fabcolors)
Error in legend(x = x_axp, y = 1, legend = names(x), col = x, border = NA,  :
  'legend' is of length 0

Looks like names(x) is NULL. I tried looking through the code but I couldn't find how color assignment is done. But basically the code does not plot anything as far as I can see.

It looks that this is where it's broken:
for (i in 1:length(names(clini_lvls))) {
    anno_code = clini_lvls[i]
    col = anno_cols[anno_code]
    temp_anno = as.matrix(annotation)
    temp_anno[temp_anno != names(anno_code)] = NA
    image(x = 1:nrow(temp_anno), y = 1:ncol(temp_anno), z = temp_anno,
        axes = FALSE, xaxt = "n", yaxt = "n", xlab = "", ylab = "",
        col = col, add = TRUE)
}

In particular col is NA because anno_cols has no names. In addition, I've seen that the legend exits early, before all annotations can be plotted.

Can you print fabcolors ? It should be a list of named vectors.

x = annotationColor[[i]]

In my case, where I only have one column, it will get the first value of the colors, and ignore the rest.

In case it doesn't error (legend doesn't exit) but colors are nevertheless not plotted due to col = anno_cols[anno_code] returning NA AFAICS.

I made a patch adding
names(anno_cols) = clini_lvls

after clini_lvls is properly made. I can submit that as PR if you want to.

I see.. Its hard for me to figure out the issue without a reproducible example. Can you print fabcolors so that I can make sure its not due to color formats. Or can you try once plotting without annotationColor and see if it works as it should ?

> fabcolors
$Histo
      A B        C        D
 "#D7191C"  "#FDAE61"  "#ABDDA4"  "#2B83BA"

(formatting may be off)

This looks okay to me. Just one last question, did the function work properly without annotationColor argument ?
If your patch fixes the issue, pleas do send a PR, happy to accept :)
Thanks.

And now I removed the code.... and works. Must have been some glitch in the matrix. I'll close for now and reopen if need be.

I might rework the patch to error out if annotationColors is not a list, though.

Sure. I will update the documentation and add an example to make this clear.


v0.3.0

See the CHANGELOG and use the rich diff for the README

@miller79,
Fixed the typos you mentioned, plus a few more. Apparently I didn't have the Code Spell Checker extension installed 😅


Added CLA

Added a html file for the Adobe CLA. Copied the header over from the home page into this file. Added CLA to nav bar.

You can see a running version of this PR at http://stevesgill.com/adobe.github.com/cla.html

I've filled an issue for the messed up header on mobile. https://github.com/adobe/adobe.github.com/issues/66


MM-T1246 CTRL/CMD+K - @ at beginning of username

Summary
MM-T1246 CTRL/CMD+K - @ at beginning of username
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/18653
Related Pull Requests
NA
Screenshots
NA
Release Note
NONE

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Thanks for participating in Hacktoberfest! You can claim your sticker set here: https://get.printfection.com/hacktober21/4144583267 @gpt14


Payment buttons

Button on review page says 'submit and pay' but doesn't submit until after you've paid? Also there's a second screen saying proceed to payment which feels unnecessary?

Tom and I had been discussing the cheque journey being from this page (something to add in the future...not before the release!!)
Something along the lines of, from this payment page have two options:

Pay online (journey as currently to Barclaycard)
Submit by post and pay with cheque, journey as follows:
a. change status to something like 'submitted by post'
b. when trying to access the claim again show an error message on the returning to a claim page - "You indicated that this claim would be submitted by post" (or something much much better than that!)

Pivotal story 84688476 - https://www.pivotaltracker.com/story/show/84688476


 doesn't even shallow-diff objects

Describe the bug
When using  items are rerendered even though the input doesn't change if the value is an object
Your Example Website or App
https://playground.solidjs.com/?hash=1357446748&version=1.4.1
Steps to Reproduce the Bug or Issue

Go to playground https://playground.solidjs.com/?hash=1357446748&version=1.4.1
Check the console, see that the unchanging elements are being rerendered all the time

Expected behavior
Only the things that actually changed rerender, as per https://www.solidjs.com/docs/latest/api#<for>
Screenshots or Videos
No response
Platform

OS: macOS 12.2 (21D49)
Browser: Firefox
Version: 101.0b9 (64-bit)

Additional context
No response

Well the input actually does change. Whenever you call mock_api_response, it produces a new set of arrays and objects, which isn't referentially equal to the stored signal's value. The solution here would be to provide a custom equals function to createSignal OR make the items comparable during iteration (a custom implementation to For) https://github.com/solidjs/solid/discussions/813#discussioncomment-2063718

You can use stores with reconcile if you need to diff data: https://playground.solidjs.com/?hash=-1828355856&version=1.4.1

The keyed package is the one based on the link that I gave. Take note that it just doesn't compare keys, you can compare anything that belongs to the item. It aims to emulate React's selective key mechanism.

Yeah generally we recommend reconcile for deep diffing. It's probably what you want to be doing but I suspect it might not work with the polyfill. More over props sometimes are proxies (dynamic spreads) too so working in a platform without proxies might be an issue in general.
There is the Key which is basically like the For deep you are looking for I think. It lets you take whatever you want about the object to provide uniqueness. However, I'd caution there because ultimately unless you really only care one level deep it isn't what you want and its better to use proxies.
Finally there is another option which is to manually wrap reactivity yourself. Signals in Signals. It's a bit cumbersome though and the reason we use Stores.

@ryansolid I only need one level deep in this case and also in the potential future case that I'm thinking about. Where can I find documentation on Key? Do you mean Index?

<Index> worked, TYSM!

@danieltroger We actually meant Key (The one you linked and the one in the link I mentioned)

I see. It's in a separate package though so I'd need to check how big it is and if it has unnecessary side-effects. Index seems to be fine for now! The diffing seems to just occur in the memos and reading of the signal given by Index

<Index> is key by index which is like not using the key in React. It works but it also not recommended for any sort of heavier data like model date, since it when items are move it commandeers the DOM node at the index instead of moving it which impact any state in the DOM like animations etc.. Key is basically the equivalent of key in React. We don't ship with Key because most of the time you wanted nested reactivity and opting into <Key> basically is always forcing a top-down reconcile and recreation of reactive nodes on nested updates. In a sense, Index does that too but it can be useful for simple data.

All I know about react is that I'm glad to not be working with it and that it's insanely inefficient but I can understand that Index is not gonna move nodes around if the values do. I'll keep Key in mind if I notice that using  Index is inefficient or I want something fancier. Thank you so much for all the info :)


Is their anything in PHP similar to these codes?

There is indeed a Laravel version of this code. Check out the full tutorial for more information too.


Use correct theme color name

For #162125

The color theme should be applicable on for the current window or instance. If we open multiple instances to manage multiple versions of environments of our application and want to easily distinguish between then visually then it's not possible as the theme applies to all the open windows and instances. Eg for Prod I want the color theme as red, for QA I want it to be blue and for dev dark and I want all the instances windows opened separately.


no data being logged

Hi! I'm having trouble getting any data to show up. No data is coming across when it is run from Azure or OSX. I'm using Node.js 0.12.0 on Azure and 0.12.1 on OS X. I double checked that APPINSIGHTS_INSTRUMENTATION_KEY was set to the correct key both places. Any ideas. Here is the code:
https://github.com/ctaggart/SourceLink-Proxy/blob/appinsights/server.ts#L7-L11

Thanks for reporting the issue! It looks like the request tracking is broken because of https://github.com/joyent/node/issues/9195
Basically node is returning something like this "::ffff:<IP_ADDRESS>" if the host system supports ipv6.
The data collection server rejects request telemetry sent with this value since it is not valid ipv4 so no data shows up. I'll follow up with some people to see if this is something we want to fix in the data collector service or if we should try to work around it in this SDK.

Thank you! I'll update to 0.12.5.

I upgraded to 0.12.5 and I still don't see any logs in the Portal for my app. I checked again that APPINSIGHTS_INSTRUMENTATION_KEY was set to the correct key. I downgraded to node 0.10.x  which installed 0.10.32 on Azure. I still see nothing. :(

I've seen request processing take up to 30 minutes sometimes. The back-end has a different queue for each type of data so it could be backed up. Could you try adding this somewhere before starting the server? Traces and Exceptions show up in ~1min.
appInsights.trackEvent("test");
appInsights.trackTrace("test");
appInsights.trackException("test");

If you still don't see anything let me know. In the browser you can do something like this to get more detailed logs, but IDK if it works in node.
appInsights.config.enableDebug = true;
appInsights.config.verboseLogging = true;

Please let me know if you're still having issues here. I'm no longer able to repro locally so I'm very interested in understanding the issue if something is broken. Thanks again for reporting.

I put in the debug messages at startup.
appInsights.trackEvent("test event");
appInsights.trackTrace("test trace");
appInsights.trackException(new Error("test error"));

The good news is that it is working when I run it locally. This shows it not starting if I haven't set the key, then it working when I do.

Unfortunately, I am not getting anything reported when run it is running on Azure. I've tried hardcoding the instrumentation key. It also works locally and not on Azure. Any ideas for troubleshooting?

I switched to io.js as explained in How to use.io.js with Azure Websites and it works perfectly. =)

glad to hear, thanks for letting me know :)


Change label from implicit to explicit for radio buttons

Description
Explicit labels (where label and input are linked by IDs) are better supported by assistive technology than implicit labels (where the label element wraps the input element). See link. This PR does not affect styling.
Also updates the input id to be randomly generated instead of using the text. The text is not unique per page (e.g. we could have 2 different radio questions with the same answer).
Before:

After:

Release notes:
Change label from implicit to explicit for radio buttons for accessibility.
Checklist

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Actually I need to fix the unit test first. Reverting back to draft.

Codecov Report

Merging #3112 (1327e4b) into main (8305b5a) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3112      +/-   ##
============================================
- Coverage     77.98%   77.87%   -0.12%
- Complexity     2164     2169       +5
============================================
  Files           274      275       +1
  Lines          8618     8667      +49
  Branches        584      588       +4
============================================
+ Hits           6721     6749      +28
- Misses         1679     1698      +19
- Partials        218      220       +2

Impacted Files
Coverage Δ

...lers/admin/AdminProgramTranslationsController.java
72.00% <0.00%> (-15.50%)
:arrow_down:

...ers/admin/AdminQuestionTranslationsController.java
56.52% <0.00%> (-7.48%)
:arrow_down:

...app/controllers/admin/AdminQuestionController.java
72.39% <0.00%> (-0.17%)
:arrow_down:

server/app/modules/MainModule.java
100.00% <0.00%> (ø)

...r/app/services/applicant/ApplicantServiceImpl.java

...erver/app/services/applicant/ApplicantService.java
85.50% <0.00%> (ø)

server/app/services/TranslationLocales.java
100.00% <0.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Update isctem.txt

Update Isctem Domain
We're having problems to get the student pack and it's always saying that the domain is not valid

@Pedro-Ivo-Neves I am sorry, the domain isctem.ac.mz is removed from our trusted domains list because the school allows to register an email address there even if you are not a student of the school. If you are the student of this school, please apply with official document (OFFICIAL DOCUMENT tab at https://www.jetbrains.com/shop/eform/students).

@Pedro-Ivo-Neves I am sorry, the domain isctem.ac.mz is removed from our trusted domains list because the school allows to register an email address there even if you are not a student of the school. If you are the student of this school, please apply with official document (OFFICIAL DOCUMENT tab at https://www.jetbrains.com/shop/eform/students).

Hey @philipto, Yeah I'm a student of the school and they don't allow to register an email address when you're not a student there. Could you guys review this please? And thank you for taking time to reply.


Does this build extension support Nexus Repository Manager OSS 3.0?

Does this build extension support uploading to the recently released Nexus Repository Manager OSS 3.0? Sorry couldn't find a way to post a question.

Hi Mike,
We haven't yet tested with 3.0 but we'll let you know as soon as we know ourselves.  This build extension uploads to the Nexus REST endpoint https://server/service/local/artifact/maven/content, so as long as that endpoint hasn't changed, things should work.
Thanks,
David

The extension does not works with nexus 3.0, as 3.x lacks any kind of rest api. This should be available after version 3.1, see this discussion: https://groups.google.com/a/glists.sonatype.com/forum/#!topic/nexus-users/eb7jeXKNgdU

Closing this issue as ypupo2002 seems to have answered it conclusively. If you desire support for older versions of Nexus server, please open an issue describing what you need. We can't promise that we can work with older servers, but we will consider the request.


Hide the approve/deny buttons once the Foreman provisioning reuest is approved/denied

https://bugzilla.redhat.com/show_bug.cgi?id=1209642

Looks like Travis just aborted...
Closing and opening again to restart Travis


[WIP] Separate Menu and Sidebar components

This simplifies the customization of the menu: developers just have to take care of the menu items, without worrying about the sidebar container (which is kind of complex due to responsiveness).

Back to WIP, because the sidebar gets rendered too often

And back to RFR


Delete ignored files committed by mistake

Wait 2 sec with this PR. need to add one more file

Damn it you are fast :-)


Automatically unzip files (low priority)

Unzip what files?

ISO files

That seems like a very niche use case. ISOs are hardly ever distributed in zips. Just use another app to extract it.


Bug fix: Export should only excludes assets folder if it's in the top level

All Submissions:

[x] Have you followed the guidelines stated in CONTRIBUTING.md file?
[x] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

New Feature Submission:

[ ] Does your submission pass the tests?
[ ] Have you linted your code locally prior to submission?

Changes To Core Features:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[x] Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

Previously, the export command excludes folders named assets at all levels. We should only exclude it if it is at the top level within the project directory (root_dir).
[x] Run reflex export with PR change and verify assets further within subdirectories are included in the zip.

If we expose this to the user we can maybe try to use glob.glob and provide a regex rather than a top_level_dir


Python CI.

This commit adds a CI setup for Python. WIP.
In its current state, the actual tests should fail, because the existing code on master right now has failing tests.

Quick brain dump of our plan here:
Status Quo
Right now, all but three APIs do not have tests, but three (pubsub, speech, language) were committed while work on the tests was in progress, and they fail.
The Plan
After discussing with @geigerj, what we intend to do is:

Merge this. CI will intentionally go red.
Work on #233, #234, and #235, in order. For each we will show and document that the appropriate tests went from red to green. Whichever one we do last should be a green build.
Bump all the remaining GAPICs, with proper CI verification for each.


Myk new docstrings

Docstrings for simulate.py and signal.py.
Need to add in units for few keys in init_scint() and Simulation class docstring.

can you update the .gitignore to ignore files like .DS_Store and the contents of .ipynb_checkpoints/


Incorrect length for some emojis

Hi there,
the library returns incorrect length:
len("❤"); // 2
len("👊🏽"); // 2

I don’t seem to be able to find a solution for this in ANY library except lodash which has a complicated regex...

I fixed this problem in my own library using a regex borrowed from lodash...
https://github.com/sallar/stringz

If stringz issue 27 does come through, we could replace aging astral-regex with that regex and results would be correct again in all the cases.


remove the plotnine dependency and update related function

Since the plotnine dependency produced multiple dependency conflicts(issue #225), and the conflict/bug is not straightforward to capture. I have changed the related plotnine functions using matplotlib instead and remove the dependency.
I think the changes affect some comparison plots like link counter comparison. The new comparison plot look like more consistent with other comparison plots since they all use matplotlib. Not sure why it used ggplot from plotnine previously but we can add plot style as 'ggplot' if we would like to.
New plot via matplotlib:

old ggplot via plotnine:

There is a quite old mode share comparison function OldModeSharesComparison based on another plot functions via plot nine. I think we are using TripModeSharesComparison  to show the mode share differences instead of the old function so I just remove it.

Good point @andkay. I think the gridlines are useful, so I added them to the plot.

Thanks for picking this up - Nice job :)


fix add jacoco.version in pom.xml

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?


Enrich CSV reader config: quote & escape

Is your feature request related to a problem or challenge?
Currently CSV reader doesn't allow to set: quote & escape chars.
Describe the solution you'd like
CsvReadOptions should contains methods to set quote & escape (like delimiter)
For example, how it works in csv crate: escape & quote
Describe alternatives you've considered
No response
Additional context
Escaping is optional stuff, usually it's just double usage of quote char, but it would be nice to be able to override.

I think this would be a matter of adding quote and escape to
https://docs.rs/datafusion/latest/datafusion/datasource/file_format/options/struct.CsvReadOptions.html
The arrow csv parser has support for these already: https://docs.rs/arrow-csv/43.0.0/arrow_csv/reader/struct.ReaderBuilder.html
Thus I think this would be a matter of connecting some APIs and extending tests

I am working on this.

I would like to take it.😊


constructor namespace inference: always prefer local types (#5803)

Pull request opened by the merge tool on behalf of #5803

Merged in 4055516ff95c1f1062907c8e166c4c4e664d2620


LOOP-1488: add delivery limits information screen + editors

https://tidepool.atlassian.net/browse/LOOP-1488

Just wondering: you sure this is updated from dev?

Yep, I merged in dev, but it seems like something may have gone wrong. I'm honestly confused as well.

Just wondering: you sure this is updated from dev?

When I'm looking at this now, it's saying that the changes you noted are outdated. I think I may have committed changes on my local branch but not immediately pushed them to my remote branch

Hm. I think this looks ok now... can you put up a LW PR and verify that the build works? Then we can be sure...

Build is passing


toSatisfy

What
Feature - add toSatisfy

Why
Hacktoberfest
Housekeeping

[x] Unit tests
[x] Documentation is up to date
[x] No additional lint warnings
[x] Add yourself to contributors list (yarn contributor)

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #54   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      8    +2
  Lines          33     43   +10
  Branches        5      6    +1
=====================================
+ Hits           33     43   +10

Impacted Files
Coverage Δ

src/matchers/toSatisfy/predicate.js
100% <100%> (ø)

src/matchers/toSatisfy/index.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba84be...dd96db1. Read the comment docs.

Thanks @stevebluck


Remove magic file encoding comments

Thanks @andyw8 for pointing this out.
Some files have # frozen_string_literal: true. I think this isn't helpful as long as this gem supports versions below 2.3. I'm not certain on this though. Thoughts?

Since CI is running 2.3, then I would say there's still an advantage to having the frozen_string_literals check. It helps to ensure that strings aren't inadvertently mutated, which presumably will become the default behaviour in some upcoming version of Ruby.

It helps to ensure that strings aren't inadvertently mutated

Good point


Can i change the color of 'goback' icon ?

I want to change the color of  'Go Back' icon ,can I  and how? thank you.

Check out the documentation or, if you can't find the answer there, please ask on StackOverflow. Thanks!

Ok,Thanks!


Tab + arrows keys fill the searchable select with the name of the key

Package
filament/filament
Package Version
2.17.2
Laravel Version
10
Livewire Version
No response
PHP Version
8.2
Problem description
When using the tab + arrow keys in a searchable select, it apparently fills the name of the key to the search input. I don't know if it's a desirable behavior by the community, I also didn't find topics that talked about it.
demo
Expected behavior
The arrow key name should not appear in the search field.
Steps to reproduce

Clone the repo or create a searchable select input;
Click into "Name" field and press tab to jump to "Roles" field;
Press any arrow key;
The drop down should collapse and the name of the arrow key should be in the search bar.

Reproduction repository
https://github.com/bebetoalves/bug-searchable-select-filament
Relevant log output
No response

Apparently this is a bug related to choices.js 👀
https://github.com/Choices-js/Choices/issues/1080

Okay not much we can do then, but thanks for the report.

@danharrin it looks like it was fixed in new version of Choices.js as mentioned here https://github.com/Choices-js/Choices/issues/1080#issuecomment-2305038062, any chance there will be upgrade of Choices.js library in Filament to v11? 🙏

It will be upgraded in v4 to ensure we don't introduce breaking changes: #13829

@danharrin thank you, any ETA for v4? ;)


Update -cpp-opt.md

Change formatting a bit to make cpp_opt more clear. Also asking that we update the msbuild task doc: https://github.com/MicrosoftDocs/visualstudio-docs/pull/6116

@asklar : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Update README.md

The absence of an acknowledgement that Serde was used in the example led to a good amount of wasted time for me thinking the example was out dated code and this has apparently been an issue for others too. (https://github.com/serde-rs/json/issues/728)

I feel like, if it should point to a link, that it would be better to point to https://serde.rs/derive.html. However, the fact that it uses/needs serde is somewhat self-explanatory from the name itself (serde_json) and the use declarations in the example(s).
Alternatively, maybe (also) have a comment before the import like this:
// serde = { version = "1.0", features = [ "derive" ] }
use serde::{Deserialize, Serialize};
use serde_json::Result;

One of the previous sections, "Parsing JSON as strongly typed data structures". Has the following note:

The necessary setup for using Serde's derive macros is explained on the Using derive page of the Serde site.

Maybe it would be good to have that note somewhere before all the examples.

New to Rust and somehow just had the same frustration. It wasn't obvious to me that I needed to add serde to my Cargo.toml file considering that the README has explicitly made the effort to mention serde_json


[SPARK-6731] [CORE] Addendum: Upgrade Apache commons-math3 to 3.4.1

(This finishes the job by removing the version overridden by Hadoop profiles.)
See discussion at https://github.com/apache/spark/pull/6994#issuecomment-119113167

Merged build triggered.

Merged build started.

Test build #36677 has started for   PR 7261 at commit 5a3f59e.

Test build #36677 has finished for   PR 7261 at commit 5a3f59e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

LGTM. Merged into master. (If there are problems we didn't cover, hopefully they will show up before the final 1.5 release.)