Return old Config fields for API < v1.20

Fix #16665
/cc @ibuildthecloud
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

Thanks! LGTM assuming green.

It's green ! :wink:
LGTM 🐰

Let's wait @ibuildthecloud for the  LGTM then :)

I can't test until late tonight, but I glady will.

Looks like this needs docs changes as well; IIU this brings back these fields below Config; I checked the docs and looks like the example output in these versions of the API docs need updating;

https://github.com/docker/docker/blob/master/docs/reference/api/docker_remote_api_v1.20.md#inspect-a-container
https://github.com/docker/docker/blob/master/docs/reference/api/docker_remote_api_v1.19.md#inspect-a-container
https://github.com/docker/docker/blob/master/docs/reference/api/docker_remote_api_v1.18.md#inspect-a-container

I don't think it's putting these fields back, iiu correctly from the issue,  the new api version 1.21 which will ship with docker 1.9 currently hides those fields. Those fields have been deprecated in 1.20 but probably they were directly removed and showed only for api minor or equal to 1.19 instead of 1.20. Please someone confirm my view :)

Yeah I think we're good without docs updates too. I'll just keep this open in 4-merge and give @ibuildthecloud some time to test.

This didn't work for me, I'm investigating why.

From the issue;

Also, should have mentioned that I'm testing with 1.18 client.

Should this fix be in a ContainerInspectPre121?

@runcom The 's' is supposed to be lower case, so Cpuset.  All params are
"Memory": 0,
"MemorySwap": 0,
"CpuShares": 0,
"Cpuset": ""

Also, these params were dropped in v1.20 (I just confirmed in Docker 1.8).  So these fields should be returned for <=1.19, with this patch they are returned for 1.20 too.

Fixing

Push forced, I see it was Cpuset with lowercase s https://github.com/calavera/docker/blob/c9207bc0aa57745876a3422d2cbc290be7c53da8/api/types/types.go#L268
@ibuildthecloud PTAL

1.19 and lower:
curl -s http://localhost:2375/v1.19/containers/7a/json | jq ".Config"
{

  "Cpuset": "",
  "CpuShares": 0,
  "MemorySwap": 0,
  "Memory": 0,

  "VolumeDriver": "",
  "StopSignal": "SIGTERM",
  "Labels": {},
  "OnBuild": null,
  "MacAddress": "",
  "NetworkDisabled": false,
  "Tty": false,
  "ExposedPorts": null,
  "AttachStderr": false,
  "AttachStdout": false,
  "AttachStdin": false,
  "User": "",
  "Domainname": "",
  "Hostname": "7a109e234350",
  "OpenStdin": false,
  "StdinOnce": false,
  "Env": null,
  "Cmd": [
    "top"
  ],
  "Image": "busybox",
  "Volumes": null,
  "WorkingDir": "",
  "Entrypoint": null
}

1.20:
curl -s http://localhost:2375/v1.20/containers/7a/json | jq ".Config"
{
  "VolumeDriver": "",
  "StopSignal": "SIGTERM",
  "Labels": {},
  "OnBuild": null,
  "MacAddress": "",
  "NetworkDisabled": false,
  "Tty": false,
  "ExposedPorts": null,
  "AttachStderr": false,
  "AttachStdout": false,
  "AttachStdin": false,
  "User": "",
  "Domainname": "",
  "Hostname": "7a109e234350",
  "OpenStdin": false,
  "StdinOnce": false,
  "Env": null,
  "Cmd": [
    "top"
  ],
  "Image": "busybox",
  "Volumes": null,
  "WorkingDir": "",
  "Entrypoint": null
}

Thanks @runcom, LGTM

LGTM

@ibuildthecloud see if it's now working for you pls


Add organize imports support

Description:
Need to support:

Reorder imports
Preserve a newline for import groups (imports from different organizations). see #19209

Related issues:
https://github.com/ballerina-platform/ballerina-lang/issues/21953

Created a doc to analyze and finalize on a styling guideline to organize import statements. https://docs.google.com/document/d/1eu3V6RQUiBRNCloT5TzSHeG63vxzWPNB5xBxQb2uiMU/edit#


Quick hack to keep sim robot in the field perimeter

The first if statement is complete, we need three more for the other sides. We also can make it a little smarter by getting the size of the robot and things and having it base how far it can go off of that.

Basically Done


Support the RFC 7329 Forwarded header

Problem
linkerd includes a ForwardedFilter but (1) it is disabled and the
configuration exposes no way to enable it, and (2) it is not quite
RFC-compliant.
Solution
Supoprt the addForwardedHeader configuration object on HTTP servers. By
default, no Forwarded header is added to requests. When enabled, a random
string is used for each of the by and for endpoints. Users may configure
by and for to be labeled as: an IP, an IP:PORT, a random string, the parent
router's label, or a static label.
Fixes #902

I have a feeling the documentation may need some work still?


Puerto Rico extract

I'm Víctor Ramírez from Open Street Map Puerto Rico Team. I recently visited your http://osm2vectortiles.org/ site and was very excited about the prospect of an easier way to set up self hosted vector tile maps. Unfortunately, Puerto Rico was not included in you country extracts. Even though Puerto Rico is a semi autonomous territory of the United States, the mappers here, myself included, usually create and work with maps of the island independently of the rest of the United States. We're working very hard to improve OSM data, as I am sure you can appreciate from our recent changesets, and it would be very useful for us to have a country extract.
Thanks in advance,
Víctor Ramírez
OSM Puerto Rico Team
<EMAIL_ADDRESS>

Please generate the vector tiles from an OSM planet dump for your country yourself.
Here is a step-by-step guide:
http://osm2vectortiles.org/docs/own-vector-tiles/

Thank you for the instructions for generating the tiles. If there is a way to setup the coordinate bounds for Puerto Rico and merge them into this project, so as make the Puerto Rico extract available in your site, I would gladly contribute such a patch.

Thank you for the instructions for generating the tiles. If there is a way to setup the coordinate bounds for Puerto Rico and merge them into this project, so as make the Puerto Rico extract available in your site, I would gladly contribute such a patch.

If you provide me with the BBOX of Puerto Rico I will add it to the extracts :)

Yes!!
min lat: 17.6701939
max lat: 18.7347042
min lon: -68.1976318
max lon: -65.088501

Finally uploaded it and added to the countries list (I know not politically correct but hope is ok).
https://osm2vectortiles-downloads.os.zhdk.cloud.switch.ch/v1.0/extracts/puerto_rico.mbtiles


Fix syntax error in requirementslib vendor

Compiling vendor/requirementslib/models/metadata.py raised a SyntaxError:
***   File "/gnu/store/62ms8p25ilrw7vrz5fn8fjf4pds10b02-pipenv-2022.11.11/lib/python3.9/site-packages/pipenv/vendor/requirementslib/models/metadata.py", line 17
    from pipenv.patched.pip._vendor.distlib.metadata import import Metadata
                                                            ^
SyntaxError: invalid syntax

Found through python -m compileall /pipenv/source/ when trying to add pipenv to Guix.

Would it be possible and sensible to run compileall in CI?

@haplo Should be possible but I am not familiar with compileall.  Can you also correct the source of where this problem came from:  https://github.com/pypa/pipenv/blob/main/tasks/vendoring/init.py#L90

@matteius I included a fix for the vendoring task,.

@haplo can you please fix the linting issue?

Sorry about that, fixed now @oz123


Add Raphael Pothin as Contributor to the repository

cf. Title

@all-contributors please add @rpothin for Documentation


rasa export only exports events since latest session_started event

Rasa version:
master (2de28adb36953996e5af7414ed9dd61534441231)
Rasa X version (if used & relevant):
0.28.1
Issue:
When exporting conversations from the tracker store, only the events since the latest session_started event are pulled. This is because by default, the SQLTrackerStore.retrieve() pulls events since the latest session_started event https://github.com/RasaHQ/rasa/blob/master/rasa/core/tracker_store.py#L876-L877
Command or request that led to error:
rasa export --conversation-ids <convo with sessions>

https://rasa-hq.slack.com/files/UF8DBRQ6M/F0137CW1HS6/image.png?origin_team=T0GHWFTS8&origin_channel=C36SS4N8M

I believe you can use rasa export with any tracker store, so ideally the parameter to retrieve the entire history (versus just the session) would be implemented on all tracker stores/on the base class

@ricwo medium or high?


v10 Support With Extras

This combines #241, #240, and #236 along with a number of other fixes that have been required to get v10 working.
This resolves #244, resolves #245, resolves #239,
Including, but not limited to:

lagging auras due to new animation
wall collision changes
some formatting
synthetic actor deletion
debug measuring functions
new settings to apply/remove aura effects from hidden actors (not invisible). Defaults to true. (due to invisible condition now being a thing)

Please note, if merged the manifest will need updating to point back to this repo.
You can try/use the v10 branches with the following manifests:

Active Auras: https://github.com/MrPrimate/Active-Auras/releases/download/v0.4.23/module.json
Active Token Effects/Lighting: https://github.com/MrPrimate/Active-Token-Lighting/releases/download/v0.4.02/module.json

Switching to your repo as the maintainer seems afk.


merge from arlac77/template-arlac77-github,arlac77/template-esm-only,arlac77/template-node-app

.travis.yml

chore(travis): remove true (jobs.include.skip_cleanup)

:tada: This PR is included in version 9.16.9 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add OneHot layer for generating one hot embedding for zero-based integer features

@fchollet Thanks for reviewing the PR. I wrote about the reason for a dedicated layer in https://github.com/fchollet/keras/issues/3680. Basically, we may want a flexibility in encoding categorical features during network construction.

This the layer is stateless (no weights) it is preferable to use Lambda(K.one_hot) IMO.

Agree @fchollet. Thanks for your comments. At least it is a good experience writing a custom Keras layer, :).


Add selinux support

Add support for using svirt to confine individual container instances in
separate selinux contexts.

Are the files added under pkg/ vendored verbatim or have they been modified substantially from the upstream stuff?
Typically such code would be managed as a Godep in rkt.  We don't for example have much visibility into what version of the upstream code this checked-in stuff is...
If the stuff has been modified to work with rkt we should probably at least have a separate commit where the verbatim code is pulled in recording its version information in the commit message or something, then a subsequent commit encapsulating the modifications.

They're modified, and they can't possibly work without being modified - I can drag them in in the unmodified form, but in that case there'll be a commit where the build will fail. If that's not a concern, I'll do that.

Well, as-is there's no record of how these pkgs have deviated from upstream and from what version...
I'm fine with there being a commit which adds effectively dormant unused code so we can have a record of how we get from upstream to here.
/cc @jonboulle

The two things I would like to see are:

A Documentation entry explaining any user action required, if any.
A commit of the unmodified selinux package and then a commit with these changes on top and a brief summary as @vcaputo pointed out.

Otherwise, awesome work!

:+1: this looks awesome to me

Thanks for splitting it up into separate commits.  Just some small fixes, otherwise lgtm!


Simple question regarding the scenarios

Hey Aditya,
Thanks again for your work! I just have a quick question regarding the scenario files here for Town7/10:
https://github.com/autonomousvision/transfuser/blob/main/leaderboard/data/scenarios/town07_all_scenarios.json
https://github.com/autonomousvision/transfuser/blob/main/leaderboard/data/scenarios/town10_all_scenarios.json
These two files seem to be the same as the Town2 scenario file (even the key in the dictionary is still town2 not changed). Is this intentional? Is the Town2 scenario file supposed to work on town7 and 10?
Thanks!
Xinshuo

The dense scenario files in this repo are sampled in a grid centered at the locations from the reference scenarios file. Since the reference file does not contain scenarios for Town07, 10, we do not have new scenarios for these. I probably just forgot to remove these. The Town02 scenarios should technically not work on other towns since the map is different but it is possible that some spawn locations just work since the scenario density is quite high.

I see. Thanks for the clarification!


Unsetting refresh time prevents app from opening again

If you open up preferences, then erase the default time (5 minutes) and leave it blank, then exit, the app seems to crash and will not run again after that.
System:
MacBook Air
Sierra 10.12.6

Interesting - I think I know where the problem is; I'll push out a fix soon :) Thanks for bringing that to my attention!


EV3-G API: motors

For issue #353
I'm still testing everything (so far so good) but figured I would go ahead and post it so everyone can start giving feedback before I spend too much time testing.

We also need to consider when we're updating docs+demos for these changes. I want to make sure that we don't lose track of that work.
P.S. I'm hoping I can find time to take on a few of the pending features; we'll see if I can make that work over the weekend. I don't want to take something then delay it if I get busy.

I wonder if introducing properties for various units would make a lot of these functions easier (and may be even unnecessary). For example, we could have
@property
def degrees_sp(self):
    return self.position_sp * self.POS2DEG_FACTOR
@degrees_sp.setter
def degrees_sp.setter(self, value):
    self.position_sp = value * self.DEG2POS_FACTOR

and then same thing for rotations_sp, power_sp (percentage of max_speed_sp), etc.

I think the only thing left in this PR to address is how to specify speed_pct vs speed_dps vs speed_rps so I'm going to go ahead and merge this one in and open a new issue for the speed thing.


feat: Add option to build arm64 binary

Summary
Resolves #248.
Causes the build/release scripts to generate an Apple silicon binary in addition to the Intel one.
Implementation details
Simply updates the build config for the recorder.
How to validate this change
You can do an npm run pack command to build fresh binaries locally. You should be able to run both the x64 and the arm64 versions without issues.

@justinkambic After our call, I found a way to include the correct browser directory per build. It should download and bundle the correct browser per os/architecture including Apple Silicon.

Addressed the suggested artifact naming improvements!! Now all the artifacts have the same name format including the arch.

/test

Hey @justinkambic I think this is ready to be reviewed, then merged if you are happy with it!


scan-vulnerabilityreports being created and are stuck initializing

What steps did you take and what happened:
When running Trivy Operator helmchart 0.25.0 app version 0.23.0 the Trivy-Operator deployment starts and spins up the pod, but it creates endless Jobs that are stuck. They never reach the ready phase.

Example of one of the jobs (the message repeats until the job crashes and another takes it place)

What did you expect to happen:
Created jobs finish, and generate the Kind: Vulnerabilityreport as seen missing after it runs for a while

Anything else you would like to add:
There are also these two error messages that appear in the trivy-operator pod itself after running around 10 minutes
It times out downloading policies. I think it leads to the "error":"creating job: no compliance commands found"
{"level":"error","ts":"2024-12-03T13:29:40Z","logger":"policyLoader.Get misconfig bundle policies","msg":"failed to load policies","error":"failed to download policies: failed to download built-in policies: download error: OCI repository error: 1 error occurred:\n\t* Get \"https://mirror.gcr.io/v2/\": dial tcp <IP_ADDRESS>:443: connect: connection timed out\n\n","stacktrace":"github.com/aquasecurity/trivy-operator/pkg/policy.(*policyLoader).GetPoliciesAndBundlePath\n\t/home/runner/work/trivy-operator/trivy-operator/pkg/policy/loader.go:63\ngithub.com/aquasecurity/trivy-operator/pkg/configauditreport/controller.(*NodeReconciler).SetupWithManager.(*NodeReconciler).reconcileNodes.func5\n\t/home/runner/work/trivy-operator/trivy-operator/pkg/configauditreport/controller/node.go:169\nsigs.k8s.io/controller-runtime/pkg/reconcile.TypedFunc[...].Reconcile\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.1/pkg/reconcile/reconcile.go:124\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.1/pkg/internal/controller/controller.go:116\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.1/pkg/internal/controller/controller.go:303\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.1/pkg/internal/controller/controller.go:263\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.1/pkg/internal/controller/controller.go:224"}
{"level":"error","ts":"2024-12-03T13:29:40Z","msg":"Reconciler error","controller":"node","controllerGroup":"","controllerKind":"Node","Node":{"name":"nodepool01"},"namespace":"","name":"nodepool01","error":"creating job: no compliance commands found","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.1/pkg/internal/controller/controller.go:316\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.1/pkg/internal/controller/controller.go:263\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.1/pkg/internal/controller/controller.go:224"}
Environment:

Trivy-Operator version: 0.23.0
Kubernetes version: 1.29.9
OS: Win 11

Our Helmchart values hosted with Argo. Might there be an issue that our namespace is not called the default trivy-system? Although this has worked before, before trivy-operator began having the TOOMANYREQUESTS errors.
---
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: trivy-operator
  namespace: argocd
spec:
  destination:
    name: ""
    namespace: trivy-operator
    server: "https://kubernetes.default.svc"
  source:
    path: ""
    repoURL: "https://aquasecurity.github.io/helm-charts/"
    targetRevision: 0.25.0
    chart: trivy-operator
    helm:
      values: |-
        image:
          registry: "azurecr.io"
        resources:
          requests:
            memory: 1000M
          limits:
            memory: 1000M
        operator:
          sbomGenerationEnabled: false
          clusterSbomCacheEnabled: false
          scannerReportTTL: "24h"
          cacheReportTTL: "120h"
          metricsFindingsEnabled: true
          metricsVulnIdEnabled: true
          exposedSecretScannerEnabled: true
          metricsExposedSecretInfo: true
          metricsConfigAuditInfo: true
          metricsRbacAssessmentInfo: true
          metricsInfraAssessmentInfo: true
          metricsImageInfo: true
          metricsClusterComplianceInfo: true
        serviceMonitor:
          enabled: true
        trivyOperator:
          scanJobPodTemplateContainerSecurityContext:
            runAsUser: 0
          scanJobTolerations:
            - key: "CriticalAddonsOnly"
              operator: "Equal"
              value: "true"
              effect: "NoSchedule"
        trivy:
          image:
            registry: "azurecr.io"
          resources:
              requests:
                memory: 1000M
              limits:
                memory: 1000M
          command: filesystem
          ignoreUnfixed: true
  sources: []
  project: default
  syncPolicy:
    automated:
      prune: true
      selfHeal: true

Thanks for any support :)

It was a network policy issue, closing :)

Can you please give us a copy of the network policy, i have the same issue


nxp boards: also test evaluation in CI

This was an oversight in https://github.com/NixOS/nixos-hardware/pull/556
Description of changes
Things done

[ ] Tested the changes in your own NixOS Configuration
[ ] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input

bors merge


Green layer when loading file from local storage

Easy Video Player version: 0.3.0
Device OS version: Android 4.4.2
Device Manufacturer: RKM MK902II
Device Name: Android PC
Resolution: 1920x1080p-60 using HDMI cable

Using:
player.setSource(Uri.fromFile(new File(Environment.getExternalStorageDirectory() + "/folder", "sample1.mp4")));

The video is being called, but with a green layer on top of the whole video.
Using
player.setSource(Uri.parse("URL"));

It's working normally.

Tried open the video directly, working normally.

Tried with different video player libraries inside my app, and it's working normally, without the green layer.

Tried with a MotoX First Gen, working normally.

If you need some other details, please, just ask and i'll provide it.
Nice job with this lib! Thanks!

Unfortunately, there's probably not much I can do.

I updated the android version to 5.1 and now it's working as intended. Thanks!


Write tests to wan.py

write pytest tests for wan.py
Test:
$ coverage run -m pytest
$ coverage report

in addition refactor to remove unnecessary routines


feat: finish integrating storybook

Please fill in the template below before submitting your pull request. This helps keep a consistent structure for project history.
Metadata

[x] Feature: a new feature.
[ ] Bug: a bug fix.
[ ] Refactor: a code change that neither fixes a bug nor adds a feature.
[ ] Style: changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.).
[ ] Test: adding missing tests or correcting existing tests.
[ ] Performance: a code change that improves performance.
[ ] Documentation: changes to documentation.
[ ] Build: changes that affect the build system or external dependencies.
[ ] CI: changes to our CI configuration files and scripts.

Changes
Finish the integration of Storybook.
Checklist

[x] This PR contains only a single concern and is small enough to be reviewed easily.
[x] Documentation for this issue has been added or updated with this PR.
[x] Unit tests have been added, if applicable.

Screenshots
Please include any relevant screenshots if this PR pertains to a visible UI change.
Additional Information
Please include any additional notes you feel are necessary here.

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add :cinder_volume_types to SupportsFeatureMixin

Also adds "supports_cinder_volume_types" virtual column to ExtManagementSystem to accomodate accessing that field from the API.
Supports https://github.com/ManageIQ/manageiq-ui-classic/pull/4536, which needs to be able to determine feature support via the API.

This says the travis build is still in progress but https://travis-ci.org/ManageIQ/manageiq/builds/430703492?utm_source=github_status&utm_medium=notification is green, merging.

@miq-bot add_label hammer/yes


Disable/enable taskbar thumbnail preview

Description of the new feature / enhancement
When you place the cursor over an app in the taskbar, a preview of the app is shown in a small window. I'd like to be able to disable that "feature" in an easy way.
I have tried numerous ways of disabling the "feature" but without success.
Scenario when this would be used?
To me, that preview "feature" is beyond annoying when I have multiple apps running and even more so when I have multiple RDCs going on. It's a popup bonanza.
Supporting information
No response

That's a thing implemented in Windows Explorer. I suggest you to file your suggestion in the
Feedback Hub.

I agree with Aaron. PowerToys probably wouldn't be the best place for this kind of functionality. His suggestion to report it on feedback hub is likely the best option for now. We appreciate your suggestion though!

Lol :-D So much for making suggestions. Shot down in flames :-D

Lol :-D So much for making suggestions. Shot down in flames :-D

Why? You can still make your suggestion in the feedback hub. But we're not able to influence such a thing like the thumbnail previews from PowerToys


[Alert Are Not Working!!!!!]

[Alert Are Not Working!!!!!]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6dd2bb3d-3104-1be7-7232-8a194074af4b
Version Independent ID: 2efecbe2-8538-8659-7740-6f8852f7875b
Content: Markdown reference for Microsoft Learn - Contributor guide
Content Source: Contribute/markdown-reference.md
Product: non-product-specific
GitHub Login: @meganbradley
Microsoft Alias: mbradley

Hi @MrMoshkovitz - Thank you for submitting this issue! I double-checked the Markdown page, and the alerts are working for me. Are you able to see them properly now when you view the page?

Closing this issue because alerts are working and we haven't heard back from the poster.

Doesn't need to be reopened, but I think the author's confusion was expecting the Docs format to render correctly on GitHub. That doesn't work since they're not part of the GitHub Flavored Mardkown, but custom extensions used for docs.microsoft.com


Add function to get Handle<Texture> from TextureAtlas

What problem does this solve or what need does it fill?
Currently, there is no way to get the Handle<Texture> at a given index from a TextureAtlas. This means that TextureAtlases can't be used in places that only accept Handle<Texture>s, such as ColorMaterials (I'm running into this issue because ImageBundle accepts a Handle<ColorMaterial>).
What solution would you like?
Add a way to get a Handle<Texture> from a TextureAtlas. Perhaps add a function, TextureAtlas::(&self, index: u32) -> Option<Handle<Texture>> or TextureAtlas::(&self, index: u32) -> Handle<Texture>.
What alternative(s) have you considered?
For any bundle, function, etc. that takes a Handle<Texture>, add an alternative that takes a Handle<TextureAtlas> and index.
Alternatively, if just a ColorMaterial could be generated from a Handle<TextureAtlas> and index, this would satisfy my particular use case.
Thank you!

The fields of TextureAtlas are public, so you should be able to use the handles field.
However, the handles in a texture atlas are (generally) only set if the atlas was constructed using TextureAtlasBuilder.
These handles are also weak, so for the textures to stay alive, you must already have a reference to them somewhere. In which case, you should probably just use that reference instead
If you want to use individual textures, just use individual textures.
That being said, there is an actual issue here, which is that UI doesn't natively support rendering images from TextureAtlases. I'm not sure what a good solution is to that. It feels like this part of the rendering should be modular in some way, but I'm not sure.

If I understand correctly, this was fixed by #5103, with the TextureAtlas::texture_rect method. It's not precisely Handle<Texture>, but I think it's equivalent (Option<URect> in main)

Yeah, the new API fulfills this use case


[WIP] Nunjucks

Mustache makes my dev life hard, also it's old and not that quick
Nunjucks is like Jinja and GDS like Jinja also the new GOV.UK Frontend thing coming soon uses Nunjucks because it's nice

This was just me having a play, closing


https://www.redmine.org/plugins/plantuml needs update

https://www.redmine.org/plugins/plantuml needs update to show newer version

The plugin isn't compatible with Redmine 4.0 at the moment as it uses alias_method_chain for code injection which was deprecated in Rails 5.0.
I've made a pull request (#26 ) to get it compatible with the new version of Redmine.

Merged #26.


Upgrade spring boot version

What this PR does / why we need it?
upgrade pom.xml spring boot version.
Summary of your change
Please indicate you've done the following:

[ ] Made sure tests are passing and test coverage is added if needed.
[ ] Made sure commit message follow the rule of Conventional Commits specification.
[ ] Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

用rebase重新提交？

忘记rebase了。。。


[Event Request] Codeunit 10861 Payment-Apply - OnCustomerOnBeforeModifyAll

Hi, would it be possible to get an event OnCustomerOnBeforeModifyAll in codeunit 10861, procedure DeleteApply, like this :
[Scope('OnPrem')]
    procedure DeleteApply(Rec: Record "Payment Line")
    begin
        if Rec."Applies-to ID" = '' then
            exit;

        case Rec."Account Type" of
            Rec."Account Type"::Customer:
                begin
                    CustLedgEntry.Init();
                    CustLedgEntry.SetCurrentKey("Applies-to ID");
                    if Rec."Applies-to Doc. No." <> '' then begin
                        CustLedgEntry.SetRange("Document No.", Rec."Applies-to Doc. No.");
                        CustLedgEntry.SetRange("Document Type", Rec."Applies-to Doc. Type");
                    end;
                    CustLedgEntry.SetRange("Applies-to ID", Rec."Applies-to ID");
                    OnCustomerOnBeforeModifyAll(CustLedgEntry,Rec);
                    CustLedgEntry.ModifyAll("Applies-to ID", '');
                end;

    [IntegrationEvent(false, false)]
    local procedure OnCustomerOnBeforeModifyAll(CustLedgEntry: Record "Customer Ledger Entry"; PaymentLine: Record "Payment Line")
    begin
    end;

?
Thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Create Unity Packages for downloads

I will certainly do it, currently we are still in Alpha a and I am starting to develop everything.


Speed up keras test infrastructure

Hello,
Thank you for this framework! It seems to be the best one on the market:) These changes speeds up travis testing time 2 times using some pytest and travis configuration options.
Summary of changes:

py.test is configured to display test profiling information that shows 10 slowest tests. This would allow additional speed ups if anyone has ideas on some particular test. The slowest test is usually cifar dataset test and tensorflow convolutions. It seems that there are some other IT tests that could be sped up.
py.test is configured to run with pytest-xdist with 2 processes in parallel because travis does provide multicore support (1.5 cores) and because the slowest cifar test spends time on download which can run in parallel with other tests.
travis is configured to split backend tests into test matrix to make parallel theano vs tensorflow testing as opposed to rerun all the tests twice for python 2.7.
pickle filenames in tests are renamed to avoid clashes during multiprocessing

Things that I tried or it would be nice to try in the future:

use travis container infrastructure that allows caching. This would speed up starting time and speed up dataset tests enormously. Unfortunately 14.04 is not supported with containers yet and tensorflow doesn't work on 12.04. It seems that tensorflow can be patched, but testing on 12.04 is a bad idea anyway.
create richer travis test matrix (for example, split core keras tests from integration and dataset tests)
do not test everything on every backend. Test everything of theano and have only core tests for tensorflow. At least it seems possible to avoid running IT tests (like datasets) on every backend since these are independent of the backend.
create shorter dataset versions and shorter IT tests (e.g. 5% of cifar images) with appropriate integration tests like trainers and examples that learn only part of the task.

Its 9 min vs 17 min for the previous pull requests. Notice, there is a bug in travis that reports sum of times from the matrix instead to the max one.

This looks great, I have been meaning to do something similar for a while (I wrote a couple of the original tests.) I think I will try and sit down over the weekend and try to bring test coverage somewhere closer to 90%, then maybe fchollet can switch on coveralls. Let me know if you want to collaborate on building more tests, maybe we can coordinate somehow.

Sure, I would like to help (with a certain free time constraints obviously:) We can set up gitter room or smth or just use email.

Thanks, this is great. Improving speed and coverage for our unit tests is definitely a priority at the moment.

@olegsinyavskiy @phreeza I created kerasio.slack.com a while ago to organize Keras meet ups you guys can use it if you want.

@phreeza @fchollet @EderSantana I'm going to setup testing of some examples. Testing examples and tutorials is IMHO a quite important thing for the package adoption. The first thing people do is to copypaste an example and run it. They might quit with the keras if it doesn't work out of the box. If there are no objections, I'm going to start with mnist mlp this weekend.

@olegsinyavskiy we have several examples in the examples folder (that I personally copy and past a lot from). You can also write a tutorials section on the wiki. But if you plan something different let us know. What did you have in mind?


Fix API call to create connector in ml-commons->conversational-search->rag-pipeline

Description
Fixes the API call's Body.
Current: Link
Issues:

Checklist

[x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Added one more fix to the json where there is a space between $ and {parameters.temperature} on request_body


Fix HPHX-11776 'Instructions in Introduction to Flex Layout hike are misleading'

Description
Updated text as requested in https://jira01.hclpnp.com/browse/HPHX-11776.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

@shant-hcl
@mikeangelsilva looks to have made the fix for HPHX-11776 as part of his PR mentioned below. Could you please check.
https://github.com/HCL-TECH-SOFTWARE/volt-mx-tutorials/pull/55

Cleaning up pull request...


deleted column not prefixed with table name

The deleted column is not prefixed with table name. That means that using a joinRelation while both tables in the join having the deleted column, it will result in a column reference "deleted" is ambiguous error.

Update - sorry, this was my mistake. The plugin works well and DOES prefix with the table name.


qtpbfimageplugin: 2.2 → 2.3

Motivation for this change
Changelog
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108075 run on x86_64-linux 1

3 packages built:

libsForQt5.qtpbfimageplugin (libsForQt515.qtpbfimageplugin)
libsForQt512.qtpbfimageplugin
libsForQt514.qtpbfimageplugin

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:
libsForQt512.qtpbfimageplugin.log:

lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.
Near pkgs/development/libraries/qtpbfimageplugin/default.nix:35:5:
   |
35 |     license = licenses.lgpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

libsForQt514.qtpbfimageplugin.log:

lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.
Near pkgs/development/libraries/qtpbfimageplugin/default.nix:35:5:
   |
35 |     license = licenses.lgpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

libsForQt5.qtpbfimageplugin.log:

lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.
Near pkgs/development/libraries/qtpbfimageplugin/default.nix:35:5:
   |
35 |     license = licenses.lgpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

Result of nixpkgs-review pr 108075 run on x86_64-darwin 1

1 package failed to build:

libsForQt5.qtpbfimageplugin (libsForQt512.qtpbfimageplugin)

2 packages built:

libsForQt514.qtpbfimageplugin
libsForQt515.qtpbfimageplugin

builder for '/nix/store/in0yygvy7m8djarsdal3527lq43irgdn-qtbase-5.12.9.drv' failed with exit code 1; last 10 log lines:                                                                       applying patch /nix/store/d8nj29wc99kwsj5qkhdihr956wkfd3jy-0001-qtbase-mkspecs-mac.patch                                                                                patching file mkspecs/common/mac.conf                                                                                patching file mkspecs/features/mac/default_post.prf                                                                                Reversed (or previously applied) patch detected!  Assume -R? [n]                                                                                Apply anyway? [n]                                                                                Skipping patch.                                                                                1 out of 1 hunk ignored -- saving rejects to file mkspecs/features/mac/default_post.prf.rej                                                                                patching file mkspecs/features/mac/default_pre.prf                                                                                patching file mkspecs/features/mac/sdk.mk                                                                                patching file mkspecs/features/mac/sdk.prf


Make the application container resources in Kubernetes user-decidable

Currently, the resources assigned to an application container in Kubernetes are static and defined in deploy/helm/microfunctions/values.yaml. I think these values should be configurable, so that during the workflow deployment the user can pick how much resources should be assigned to her application's containers.

@manuelstein , @paarijaat , @ruichuan, any thoughts?

In my opinion, this values.yaml is the place where one could make changes
to better adapt to its infrastructure.  Are you suggesting we should have a
settings file like what we do for ansible installation?  I feel that might
end up with a similar file as the current values.yaml ;)
On Wed, Jul 15, 2020 at 2:11 PM Istemi Ekin Akkus<EMAIL_ADDRESS>wrote:

@manuelstein https://github.com/manuelstein , @paarijaat
https://github.com/paarijaat , @ruichuan https://github.com/ruichuan,
any thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/knix-microfunctions/knix/issues/54#issuecomment-658730999,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQSEDBW56YFKDDKUABDXMDR3WMG3ANCNFSM4OGXJXNQ
.

No, I mean for the end users to configure how their workflows could be deployed (i.e., with what kind of container resources). This would be similar to the way AWS Lambda users would pick their configuration with different RAM.

The limits of a container would depend on the functions that are deployed in it and the targeted level of concurrency that the container should be able to handle. Based on this, scaling thresholds can be configured. If the concurrency level is low, scaling might start to scale-out early, and response times might suffer during the scale-out. If provided resources allow high concurrency, we accept over-provisioning for better response times.
Should we allow the user to provide an initial resource estimate per function instance?
Could we report/collect the CPU time and memory use after a function invocation has completed?

Hi Manuel, I think whenever a service provide in the future is interested in billing for KNIX FaaS-like services he will need this type of information - same as for other services like object storer to.
I share your view on allowing a user to provide an estimate on memory usage, but what will happen if the estimated memory consumption is wrong/exceeded? In case of AWS Lambda e.g. such a function could either simply fail, or not terminate within the container lifetime constraints, do we want e.g. give an extra memory allowance just in case?
Best regards, Klaus
Holen Sie sich Outlook für iOShttps://aka.ms/o0ukef

Von: Manuel Stein<EMAIL_ADDRESS>Gesendet: Wednesday, July 15, 2020 7:58:37 PM
An: knix-microfunctions/knix<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Betreff: Re: [knix-microfunctions/knix] Make the application container resources in Kubernetes user-decidable (#54)
The limits of a container would depend on the functions that are deployed in it and the targeted level of concurrency that the container should be able to handle. Based on this, scaling thresholds can be configured. If the concurrency level is low, scaling might start to scale-out early, and response times might suffer during the scale-out. If provided resources allow high concurrency, we accept over-provisioning for better response times.
Should we allow the user to provide an initial resource estimate per function instance?
Could we report/collect the CPU time and memory use after a function invocation has completed?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/knix-microfunctions/knix/issues/54#issuecomment-658914335, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADFTJENLMV52K72PIIM3RGTR3XU43ANCNFSM4OGXJXNQ.

Oh, my bad -- missed the "user configuration" part...  Then, it's
generally a good thing to have.  The question is that, whether a user
really knows how much resource its function/workflow needs, or should
knix profile the resource usage of a function/workflow for the user?
On Wed, Jul 15, 2020 at 5:13 PM Istemi Ekin Akkus
<EMAIL_ADDRESS>wrote:

No, I mean for the end users to configure how their workflows could be deployed (i.e., with what kind of container resources). This would be similar to the way AWS Lambda users would pick their configuration with different RAM.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yes, that is true. I forgot to consider that the users shouldn't have to reason about the resource usage of their functions.
I think it would be good if we could measure each function instance's CPU and memory usage. It would help to adjust the scaling policy for the kubernetes setup as well as determining the scaling policy for the bare-metal case (which is something we should also work on).
We can start gathering statistics about already deployed functions. When we need to scale out a deployed workflow, we can adjust the resources accordingly for the new scaled instance (e.g., this sandbox had 1CPU and 1GB RAM, and i am now scaling it up for 3rd time in the last 5 minutes, so maybe I'll just give it more CPU and RAM this time). Similarly, if this function is used in another workflow that is being deployed, we can also consider that information.
Then during deployment, we could pick the resources of the sandbox according to some heuristics with regards the functions and states utilized in the workflow. For example, if the workflow contains a 'Parallel' or 'Map' state, we pick a sandbox flavour with more CPU and RAM.
That said, how about we have a few different flavours of sandboxes with different RAM and CPU configurations (e.g., [1 CPU, 1 GB], [1 CPU, 2 GB], [2 CPUs, 4GB]) to choose from? Or we could just have dynamic values in the deployWorkflow procedure.
My original point was that these values are currently fixed and determined at installation time, and not adjustable afterwards during runtime, so we should try to make it more dynamic.


Bump Ruby and SWIG versions in CI

Ruby 2.5 and 2.6 are EOL. Even Debian stable (11, bullseye) ships 2.7. So I think testing against 2.5 and 2.6 is no longer necessary. Test against 2.7 and 3.2 instead.
Also bump SWIG to 4.1.1 now that our wrappers are built with that.

Build error:

Errno::ENOENT: No such file or directory @ rb_sysopen - https://github.com/taglib/taglib/archive/v1.11.1.tar.gz

Hmm, was open-uri removed from Ruby?

FYI @fusion2004


error running pip install ./DPViewer

I'm a little stuck at this point in the setup:
pip install ./DPViewer

I get the following message:
pip install ./DPViewer
Processing ./DPViewer
  Preparing metadata (setup.py) ... done
Building wheels for collected packages: dpviewer
  Building wheel for dpviewer (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> [102 lines of output]
      running bdist_wheel
      running build
      running build_py
      running build_ext
      -- Caffe2: CUDA detected: 11.3
      -- Caffe2: CUDA nvcc is: /usr/local/cuda-11.3/bin/nvcc
      -- Caffe2: CUDA toolkit directory: /usr/local/cuda-11.3
      -- Caffe2: Header version is: 11.3
      -- Found cuDNN: v8.5.0  (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libcudnn.so)
      -- /usr/local/cuda-11.3/lib64/libnvrtc.so shorthash is 8aa72235
      -- Autodetected CUDA architecture(s):  7.5
      -- Added CUDA NVCC flags for: -gencode;arch=compute_75,code=sm_75
      CMake Warning at /home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:22 (message):
        static library kineto_LIBRARY-NOTFOUND not found.
      Call Stack (most recent call first):
        /home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:127 (append_torchlib_if_found)
        CMakeLists.txt:24 (find_package)

      -- pybind11 v2.10.0 dev1
      -- Configuring done
      CMake Warning at pybind11/tools/pybind11Tools.cmake:173 (add_library):
        Cannot generate a safe runtime search path for target dpviewerx because
        files in some directories may conflict with libraries in implicit
        directories:

          runtime library [libcudnn.so.8] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
            /home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/torch/lib

        Some of these libraries may not be found correctly.
      Call Stack (most recent call first):
        dpviewer/CMakeLists.txt:8 (pybind11_add_module)

      -- Generating done
      -- Build files have been written to: /mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10
      /home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/cmake/data/bin/cmake -S/mnt/share/code/DPVO/DPViewer -B/mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10 --check-build-system CMakeFiles/Makefile.cmake 0
      /home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/cmake/data/bin/cmake -E cmake_progress_start /mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10/CMakeFiles /mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10//CMakeFiles/progress.marks
      /usr/bin/make  -f CMakeFiles/Makefile2 all
      make[1]: Entering directory '/mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10'
      /usr/bin/make  -f dpviewer/CMakeFiles/dpviewerx.dir/build.make dpviewer/CMakeFiles/dpviewerx.dir/depend
      make[2]: Entering directory '/mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10'
      cd /mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10 && /home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/cmake/data/bin/cmake -E cmake_depends "Unix Makefiles" /mnt/share/code/DPVO/DPViewer /mnt/share/code/DPVO/DPViewer/dpviewer /mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10 /mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10/dpviewer /mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10/dpviewer/CMakeFiles/dpviewerx.dir/DependInfo.cmake --color=
      Dependencies file "dpviewer/CMakeFiles/dpviewerx.dir/viewer_cuda.cu.o.d" is newer than depends file "/mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10/dpviewer/CMakeFiles/dpviewerx.dir/compiler_depend.internal".
      Dependencies file "dpviewer/CMakeFiles/dpviewerx.dir/viewer.cpp.o.d" is newer than depends file "/mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10/dpviewer/CMakeFiles/dpviewerx.dir/compiler_depend.internal".
      Consolidate compiler generated dependencies of target dpviewerx
      make[2]: Leaving directory '/mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10'
      /usr/bin/make  -f dpviewer/CMakeFiles/dpviewerx.dir/build.make dpviewer/CMakeFiles/dpviewerx.dir/build
      make[2]: Entering directory '/mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10'
      make[2]: *** No rule to make target '/usr/lib/x86_64-linux-gnu/libSM.so', needed by '../lib.linux-x86_64-3.10/dpviewerx.cpython-310-x86_64-linux-gnu.so'.  Stop.
      make[2]: Leaving directory '/mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10'
      CMakeFiles/Makefile2:115: recipe for target 'dpviewer/CMakeFiles/dpviewerx.dir/all' failed
      make[1]: *** [dpviewer/CMakeFiles/dpviewerx.dir/all] Error 2
      make[1]: Leaving directory '/mnt/share/code/DPVO/DPViewer/build/temp.linux-x86_64-3.10'
      Makefile:90: recipe for target 'all' failed
      make: *** [all] Error 2
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/mnt/share/code/DPVO/DPViewer/setup.py", line 123, in <module>
          setup(
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/__init__.py", line 87, in setup
          return distutils.core.setup(**attrs)
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 148, in setup
          return run_commands(dist)
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 163, in run_commands
          dist.run_commands()
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 967, in run_commands
          self.run_command(cmd)
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/dist.py", line 1214, in run_command
          super().run_command(command)
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/wheel/bdist_wheel.py", line 299, in run
          self.run_command('build')
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 313, in run_command
          self.distribution.run_command(command)
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/dist.py", line 1214, in run_command
          super().run_command(command)
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/command/build.py", line 135, in run
          self.run_command(cmd_name)
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 313, in run_command
          self.distribution.run_command(command)
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/dist.py", line 1214, in run_command
          super().run_command(command)
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/command/build_ext.py", line 79, in run
          _build_ext.run(self)
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 339, in run
          self.build_extensions()
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 448, in build_extensions
          self._build_extensions_serial()
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 473, in _build_extensions_serial
          self.build_extension(ext)
        File "/mnt/share/code/DPVO/DPViewer/setup.py", line 116, in build_extension
          subprocess.check_call(
        File "/home/ddetone/anaconda3/envs/dpvo/lib/python3.10/subprocess.py", line 369, in check_call
          raise CalledProcessError(retcode, cmd)
      subprocess.CalledProcessError: Command '['cmake', '--build', '.', '--verbose', '-j']' returned non-zero exit status 2.
      [end of output]

Any ideas? Maybe something wrong with my cudnn install?

I haven't come across this error, but one thing to try might be re-downloading a tarball of cudnn from the nvidia website and overriding the cudnn filepaths in cmake by setting
export CMAKE_ARGS="-DCUDNN_LIBRARY_PATH=<unzipped-tarball>/lib -DCUDNN_INCLUDE_PATH=<unzipped-tarball>/include"

If you're still having issues setting up DPVO, we just created a docker for it: https://github.com/princeton-vl/DPVO_Docker

Hmm, still seeing the same issue after trying your recommended fix. I don't think it is a cudnn actually but the error message is quite vague:
pip install ./DPViewer
Processing ./DPViewer
Building wheels for collected packages: dpviewer
  Building wheel for dpviewer (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: /home/ddetone/anaconda3/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-tc9s5h7_/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-tc9s5h7_/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-6j70tgzb
       cwd: /tmp/pip-req-build-tc9s5h7_/
  Complete output (109 lines):
  running bdist_wheel
  running build
  running build_py
  creating build/lib.linux-x86_64-3.8
  creating build/lib.linux-x86_64-3.8/dpviewer
  copying dpviewer/__init__.py -> build/lib.linux-x86_64-3.8/dpviewer
  running build_ext
  -- The C compiler identification is GNU 7.5.0
  -- The CXX compiler identification is GNU 7.5.0
  -- Check for working C compiler: /usr/bin/cc
  -- Check for working C compiler: /usr/bin/cc -- works
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Check for working CXX compiler: /usr/bin/c++
  -- Check for working CXX compiler: /usr/bin/c++ -- works
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - done
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  -- The CUDA compiler identification is NVIDIA 11.3.58
  -- Check for working CUDA compiler: /usr/local/cuda-11.3/bin/nvcc
  -- Check for working CUDA compiler: /usr/local/cuda-11.3/bin/nvcc -- works
  -- Detecting CUDA compiler ABI info
  -- Detecting CUDA compiler ABI info - done
  -- Automatic GPU detection failed. Building for common architectures.
  -- Looking for pthread.h
  -- Looking for pthread.h - found
  -- Looking for pthread_create
  -- Looking for pthread_create - not found
  -- Looking for pthread_create in pthreads
  -- Looking for pthread_create in pthreads - not found
  -- Looking for pthread_create in pthread
  -- Looking for pthread_create in pthread - found
  -- Found Threads: TRUE
  -- Found CUDA: /usr/local/cuda-11.3 (found version "11.3")
  -- Caffe2: CUDA detected: 11.3
  -- Caffe2: CUDA nvcc is: /usr/local/cuda-11.3/bin/nvcc
  -- Caffe2: CUDA toolkit directory: /usr/local/cuda-11.3
  -- Caffe2: Header version is: 11.3
  -- Found CUDNN: /usr/lib/x86_64-linux-gnu/libcudnn.so
  -- Found cuDNN: v8.5.0  (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libcudnn.so)
  -- /usr/local/cuda-11.3/lib64/libnvrtc.so shorthash is 8aa72235
  -- Autodetected CUDA architecture(s):  7.5
  -- Added CUDA NVCC flags for: -gencode;arch=compute_75,code=sm_75
  CMake Warning at /home/ddetone/anaconda3/lib/python3.8/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:22 (message):
    static library kineto_LIBRARY-NOTFOUND not found.
  Call Stack (most recent call first):
    /home/ddetone/anaconda3/lib/python3.8/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:127 (append_torchlib_if_found)
    CMakeLists.txt:24 (find_package)

  -- Found Torch: /home/ddetone/anaconda3/lib/python3.8/site-packages/torch/lib/libtorch.so
  -- pybind11 v2.10.0 dev1
  -- Found PythonInterp: /home/ddetone/anaconda3/bin/python (found suitable version "3.8.3", minimum required is "3.6")
  -- Found PythonLibs: /home/ddetone/anaconda3/lib/libpython3.8.so
  -- Performing Test HAS_FLTO
  -- Performing Test HAS_FLTO - Success
  -- Configuring done
  CMake Error at pybind11/tools/pybind11Tools.cmake:173 (add_library):
    CUDA_STANDARD is set to invalid value '17'
  Call Stack (most recent call first):
    dpviewer/CMakeLists.txt:8 (pybind11_add_module)

  -- Generating done
  -- Build files have been written to: /tmp/pip-req-build-tc9s5h7_/build/temp.linux-x86_64-3.8
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/tmp/pip-req-build-tc9s5h7_/setup.py", line 123, in <module>
      setup(
    File "/home/ddetone/anaconda3/lib/python3.8/site-packages/setuptools/__init__.py", line 165, in setup
      return distutils.core.setup(**attrs)
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/core.py", line 148, in setup
      dist.run_commands()
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 966, in run_commands
      self.run_command(cmd)
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
      cmd_obj.run()
    File "/home/ddetone/anaconda3/lib/python3.8/site-packages/wheel/bdist_wheel.py", line 223, in run
      self.run_command('build')
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/cmd.py", line 313, in run_command
      self.distribution.run_command(command)
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
      cmd_obj.run()
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build.py", line 135, in run
      self.run_command(cmd_name)
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/cmd.py", line 313, in run_command
      self.distribution.run_command(command)
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
      cmd_obj.run()
    File "/home/ddetone/anaconda3/lib/python3.8/site-packages/setuptools/command/build_ext.py", line 87, in run
      _build_ext.run(self)
    File "/home/ddetone/anaconda3/lib/python3.8/site-packages/Cython/Distutils/old_build_ext.py", line 186, in run
      _build_ext.build_ext.run(self)
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 340, in run
      self.build_extensions()
    File "/home/ddetone/anaconda3/lib/python3.8/site-packages/Cython/Distutils/old_build_ext.py", line 195, in build_extensions
      _build_ext.build_ext.build_extensions(self)
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 449, in build_extensions
      self._build_extensions_serial()
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 474, in _build_extensions_serial
      self.build_extension(ext)
    File "/tmp/pip-req-build-tc9s5h7_/setup.py", line 112, in build_extension
      subprocess.check_call(
    File "/home/ddetone/anaconda3/lib/python3.8/subprocess.py", line 364, in check_call
      raise CalledProcessError(retcode, cmd)
  subprocess.CalledProcessError: Command '['cmake', '/tmp/pip-req-build-tc9s5h7_', '-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/tmp/pip-req-build-tc9s5h7_/build/lib.linux-x86_64-3.8/', '-DPYTHON_EXECUTABLE=/home/ddetone/anaconda3/bin/python', '-DCMAKE_BUILD_TYPE=Release', '-DTORCH_PATH=/home/ddetone/anaconda3/lib/python3.8/site-packages/torch', '-DEXAMPLE_VERSION_INFO=0.0.1']' returned non-zero exit status 1.
  ----------------------------------------
  ERROR: Failed building wheel for dpviewer
  Running setup.py clean for dpviewer
Failed to build dpviewer
Installing collected packages: dpviewer
    Running setup.py install for dpviewer ... error
    ERROR: Command errored out with exit status 1:
     command: /home/ddetone/anaconda3/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-tc9s5h7_/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-tc9s5h7_/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-y5sx2aqq/install-record.txt --single-version-externally-managed --compile --install-headers /home/ddetone/anaconda3/include/python3.8/dpviewer
         cwd: /tmp/pip-req-build-tc9s5h7_/
    Complete output (111 lines):
    running install
    running build
    running build_py
    creating build/lib.linux-x86_64-3.8
    creating build/lib.linux-x86_64-3.8/dpviewer
    copying dpviewer/__init__.py -> build/lib.linux-x86_64-3.8/dpviewer
    running build_ext
    -- The C compiler identification is GNU 7.5.0
    -- The CXX compiler identification is GNU 7.5.0
    -- Check for working C compiler: /usr/bin/cc
    -- Check for working C compiler: /usr/bin/cc -- works
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Check for working CXX compiler: /usr/bin/c++
    -- Check for working CXX compiler: /usr/bin/c++ -- works
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- The CUDA compiler identification is NVIDIA 11.3.58
    -- Check for working CUDA compiler: /usr/local/cuda-11.3/bin/nvcc
    -- Check for working CUDA compiler: /usr/local/cuda-11.3/bin/nvcc -- works
    -- Detecting CUDA compiler ABI info
    -- Detecting CUDA compiler ABI info - done
    -- Automatic GPU detection failed. Building for common architectures.
    -- Looking for pthread.h
    -- Looking for pthread.h - found
    -- Looking for pthread_create
    -- Looking for pthread_create - not found
    -- Looking for pthread_create in pthreads
    -- Looking for pthread_create in pthreads - not found
    -- Looking for pthread_create in pthread
    -- Looking for pthread_create in pthread - found
    -- Found Threads: TRUE
    -- Found CUDA: /usr/local/cuda-11.3 (found version "11.3")
    -- Caffe2: CUDA detected: 11.3
    -- Caffe2: CUDA nvcc is: /usr/local/cuda-11.3/bin/nvcc
    -- Caffe2: CUDA toolkit directory: /usr/local/cuda-11.3
    -- Caffe2: Header version is: 11.3
    -- Found CUDNN: /usr/lib/x86_64-linux-gnu/libcudnn.so
    -- Found cuDNN: v8.5.0  (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libcudnn.so)
    -- /usr/local/cuda-11.3/lib64/libnvrtc.so shorthash is 8aa72235
    -- Autodetected CUDA architecture(s):  7.5
    -- Added CUDA NVCC flags for: -gencode;arch=compute_75,code=sm_75
    CMake Warning at /home/ddetone/anaconda3/lib/python3.8/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:22 (message):
      static library kineto_LIBRARY-NOTFOUND not found.
    Call Stack (most recent call first):
      /home/ddetone/anaconda3/lib/python3.8/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:127 (append_torchlib_if_found)
      CMakeLists.txt:24 (find_package)

    -- Found Torch: /home/ddetone/anaconda3/lib/python3.8/site-packages/torch/lib/libtorch.so
    -- pybind11 v2.10.0 dev1
    -- Found PythonInterp: /home/ddetone/anaconda3/bin/python (found suitable version "3.8.3", minimum required is "3.6")
    -- Found PythonLibs: /home/ddetone/anaconda3/lib/libpython3.8.so
    -- Performing Test HAS_FLTO
    -- Performing Test HAS_FLTO - Success
    -- Configuring done
    CMake Error at pybind11/tools/pybind11Tools.cmake:173 (add_library):
      CUDA_STANDARD is set to invalid value '17'
    Call Stack (most recent call first):
      dpviewer/CMakeLists.txt:8 (pybind11_add_module)

    -- Generating done
    -- Build files have been written to: /tmp/pip-req-build-tc9s5h7_/build/temp.linux-x86_64-3.8
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-tc9s5h7_/setup.py", line 123, in <module>
        setup(
      File "/home/ddetone/anaconda3/lib/python3.8/site-packages/setuptools/__init__.py", line 165, in setup
        return distutils.core.setup(**attrs)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/core.py", line 148, in setup
        dist.run_commands()
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 966, in run_commands
        self.run_command(cmd)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
        cmd_obj.run()
      File "/home/ddetone/anaconda3/lib/python3.8/site-packages/setuptools/command/install.py", line 61, in run
        return orig.install.run(self)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/install.py", line 545, in run
        self.run_command('build')
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/cmd.py", line 313, in run_command
        self.distribution.run_command(command)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
        cmd_obj.run()
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build.py", line 135, in run
        self.run_command(cmd_name)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/cmd.py", line 313, in run_command
        self.distribution.run_command(command)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
        cmd_obj.run()
      File "/home/ddetone/anaconda3/lib/python3.8/site-packages/setuptools/command/build_ext.py", line 87, in run
        _build_ext.run(self)
      File "/home/ddetone/anaconda3/lib/python3.8/site-packages/Cython/Distutils/old_build_ext.py", line 186, in run
        _build_ext.build_ext.run(self)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 340, in run
        self.build_extensions()
      File "/home/ddetone/anaconda3/lib/python3.8/site-packages/Cython/Distutils/old_build_ext.py", line 195, in build_extensions
        _build_ext.build_ext.build_extensions(self)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 449, in build_extensions
        self._build_extensions_serial()
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 474, in _build_extensions_serial
        self.build_extension(ext)
      File "/tmp/pip-req-build-tc9s5h7_/setup.py", line 112, in build_extension
        subprocess.check_call(
      File "/home/ddetone/anaconda3/lib/python3.8/subprocess.py", line 364, in check_call
        raise CalledProcessError(retcode, cmd)
    subprocess.CalledProcessError: Command '['cmake', '/tmp/pip-req-build-tc9s5h7_', '-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/tmp/pip-req-build-tc9s5h7_/build/lib.linux-x86_64-3.8/', '-DPYTHON_EXECUTABLE=/home/ddetone/anaconda3/bin/python', '-DCMAKE_BUILD_TYPE=Release', '-DTORCH_PATH=/home/ddetone/anaconda3/lib/python3.8/site-packages/torch', '-DEXAMPLE_VERSION_INFO=0.0.1']' returned non-zero exit status 1.
    ----------------------------------------
ERROR: Command errored out with exit status 1: /home/ddetone/anaconda3/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-tc9s5h7_/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-tc9s5h7_/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-y5sx2aqq/install-record.txt --single-version-externally-managed --compile --install-headers /home/ddetone/anaconda3/include/python3.8/dpviewer Check the logs for full command output.

I'll give the docker a go too, see if I can get that working

I got it working with docker yay! I guess I can close this.

I haven't come across this error, but one thing to try might be re-downloading a tarball of cudnn from the nvidia website and overriding the cudnn filepaths in cmake by setting
export CMAKE_ARGS="-DCUDNN_LIBRARY_PATH=<unzipped-tarball>/lib -DCUDNN_INCLUDE_PATH=<unzipped-tarball>/include"

before running pip install ./DPViewer

Thank you so much! Yes. I solved the problem this way and installed dpviewer successfully.
`      subprocess.CalledProcessError: Command '['cmake', '/home/lzy/workingspace/DPVO/DPViewer', '-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/home/lzy/workingspace/DPVO/DPViewer/build/lib.linux-x86_64-cpython-310/', '-DPYTHON_EXECUTABLE=/home/lzy/miniconda3/envs/dpvo/bin/python', '-DCMAKE_BUILD_TYPE=Release', '-DTORCH_PATH=/home/lzy/miniconda3/envs/dpvo/lib/python3.10/site-packages/torch', '-DEXAMPLE_VERSION_INFO=0.0.1']' returned non-zero exit status 1.
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure
× Encountered error while trying to install package.
╰─> dpviewer
note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.
`
Then , it fixed as
(dpvo) lzy@lzy:~/workingspace/DPVO$ export CMAKE_ARGS="-DCUDNN_LIBRARY_PATH=/home/lzy/Downloads/cudnn-linux-x86_64-<IP_ADDRESS>_cuda11-archive/lib -DCUDNN_INCLUDE_PATH=/home/lzy/Downloads/cudnn-linux-x86_64-<IP_ADDRESS>_cuda11-archive/include" (dpvo) lzy@lzy:~/workingspace/DPVO$ pip install ./DPViewer Looking in indexes: https://pypi.tuna.tsinghua.edu.cn/simple Processing ./DPViewer   Preparing metadata (setup.py) ... done Building wheels for collected packages: dpviewer   Building wheel for dpviewer (setup.py) ... done   Created wheel for dpviewer: filename=dpviewer-0.0.1-cp310-cp310-linux_x86_64.whl size=82191 sha256=bfc18886df66bda84751d3987bb3e2fdb83db3898d681d5bb6fcc881006c8d93   Stored in directory: /tmp/pip-ephem-wheel-cache-ttgn7c1w/wheels/03/cf/4c/781dad81380ee0347fa94f4a3fee558d68aef9521636a5a0c2 Successfully built dpviewer Installing collected packages: dpviewer Successfully installed dpviewer-0.0.1
And I have successfully run the demo 'iphone'. I'll try to train the dpvo.

https://github.com/princeton-vl/DPVO/issues/33#issuecomment-2236136060

Hmm, still seeing the same issue after trying your recommended fix. I don't think it is a cudnn actually but the error message is quite vague:
pip install ./DPViewer
Processing ./DPViewer
Building wheels for collected packages: dpviewer
  Building wheel for dpviewer (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: /home/ddetone/anaconda3/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-tc9s5h7_/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-tc9s5h7_/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-6j70tgzb
       cwd: /tmp/pip-req-build-tc9s5h7_/
  Complete output (109 lines):
  running bdist_wheel
  running build
  running build_py
  creating build/lib.linux-x86_64-3.8
  creating build/lib.linux-x86_64-3.8/dpviewer
  copying dpviewer/__init__.py -> build/lib.linux-x86_64-3.8/dpviewer
  running build_ext
  -- The C compiler identification is GNU 7.5.0
  -- The CXX compiler identification is GNU 7.5.0
  -- Check for working C compiler: /usr/bin/cc
  -- Check for working C compiler: /usr/bin/cc -- works
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Check for working CXX compiler: /usr/bin/c++
  -- Check for working CXX compiler: /usr/bin/c++ -- works
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - done
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  -- The CUDA compiler identification is NVIDIA 11.3.58
  -- Check for working CUDA compiler: /usr/local/cuda-11.3/bin/nvcc
  -- Check for working CUDA compiler: /usr/local/cuda-11.3/bin/nvcc -- works
  -- Detecting CUDA compiler ABI info
  -- Detecting CUDA compiler ABI info - done
  -- Automatic GPU detection failed. Building for common architectures.
  -- Looking for pthread.h
  -- Looking for pthread.h - found
  -- Looking for pthread_create
  -- Looking for pthread_create - not found
  -- Looking for pthread_create in pthreads
  -- Looking for pthread_create in pthreads - not found
  -- Looking for pthread_create in pthread
  -- Looking for pthread_create in pthread - found
  -- Found Threads: TRUE
  -- Found CUDA: /usr/local/cuda-11.3 (found version "11.3")
  -- Caffe2: CUDA detected: 11.3
  -- Caffe2: CUDA nvcc is: /usr/local/cuda-11.3/bin/nvcc
  -- Caffe2: CUDA toolkit directory: /usr/local/cuda-11.3
  -- Caffe2: Header version is: 11.3
  -- Found CUDNN: /usr/lib/x86_64-linux-gnu/libcudnn.so
  -- Found cuDNN: v8.5.0  (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libcudnn.so)
  -- /usr/local/cuda-11.3/lib64/libnvrtc.so shorthash is 8aa72235
  -- Autodetected CUDA architecture(s):  7.5
  -- Added CUDA NVCC flags for: -gencode;arch=compute_75,code=sm_75
  CMake Warning at /home/ddetone/anaconda3/lib/python3.8/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:22 (message):
    static library kineto_LIBRARY-NOTFOUND not found.
  Call Stack (most recent call first):
    /home/ddetone/anaconda3/lib/python3.8/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:127 (append_torchlib_if_found)
    CMakeLists.txt:24 (find_package)

  -- Found Torch: /home/ddetone/anaconda3/lib/python3.8/site-packages/torch/lib/libtorch.so
  -- pybind11 v2.10.0 dev1
  -- Found PythonInterp: /home/ddetone/anaconda3/bin/python (found suitable version "3.8.3", minimum required is "3.6")
  -- Found PythonLibs: /home/ddetone/anaconda3/lib/libpython3.8.so
  -- Performing Test HAS_FLTO
  -- Performing Test HAS_FLTO - Success
  -- Configuring done
  CMake Error at pybind11/tools/pybind11Tools.cmake:173 (add_library):
    CUDA_STANDARD is set to invalid value '17'
  Call Stack (most recent call first):
    dpviewer/CMakeLists.txt:8 (pybind11_add_module)

  -- Generating done
  -- Build files have been written to: /tmp/pip-req-build-tc9s5h7_/build/temp.linux-x86_64-3.8
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/tmp/pip-req-build-tc9s5h7_/setup.py", line 123, in <module>
      setup(
    File "/home/ddetone/anaconda3/lib/python3.8/site-packages/setuptools/__init__.py", line 165, in setup
      return distutils.core.setup(**attrs)
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/core.py", line 148, in setup
      dist.run_commands()
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 966, in run_commands
      self.run_command(cmd)
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
      cmd_obj.run()
    File "/home/ddetone/anaconda3/lib/python3.8/site-packages/wheel/bdist_wheel.py", line 223, in run
      self.run_command('build')
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/cmd.py", line 313, in run_command
      self.distribution.run_command(command)
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
      cmd_obj.run()
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build.py", line 135, in run
      self.run_command(cmd_name)
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/cmd.py", line 313, in run_command
      self.distribution.run_command(command)
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
      cmd_obj.run()
    File "/home/ddetone/anaconda3/lib/python3.8/site-packages/setuptools/command/build_ext.py", line 87, in run
      _build_ext.run(self)
    File "/home/ddetone/anaconda3/lib/python3.8/site-packages/Cython/Distutils/old_build_ext.py", line 186, in run
      _build_ext.build_ext.run(self)
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 340, in run
      self.build_extensions()
    File "/home/ddetone/anaconda3/lib/python3.8/site-packages/Cython/Distutils/old_build_ext.py", line 195, in build_extensions
      _build_ext.build_ext.build_extensions(self)
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 449, in build_extensions
      self._build_extensions_serial()
    File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 474, in _build_extensions_serial
      self.build_extension(ext)
    File "/tmp/pip-req-build-tc9s5h7_/setup.py", line 112, in build_extension
      subprocess.check_call(
    File "/home/ddetone/anaconda3/lib/python3.8/subprocess.py", line 364, in check_call
      raise CalledProcessError(retcode, cmd)
  subprocess.CalledProcessError: Command '['cmake', '/tmp/pip-req-build-tc9s5h7_', '-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/tmp/pip-req-build-tc9s5h7_/build/lib.linux-x86_64-3.8/', '-DPYTHON_EXECUTABLE=/home/ddetone/anaconda3/bin/python', '-DCMAKE_BUILD_TYPE=Release', '-DTORCH_PATH=/home/ddetone/anaconda3/lib/python3.8/site-packages/torch', '-DEXAMPLE_VERSION_INFO=0.0.1']' returned non-zero exit status 1.
  ----------------------------------------
  ERROR: Failed building wheel for dpviewer
  Running setup.py clean for dpviewer
Failed to build dpviewer
Installing collected packages: dpviewer
    Running setup.py install for dpviewer ... error
    ERROR: Command errored out with exit status 1:
     command: /home/ddetone/anaconda3/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-tc9s5h7_/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-tc9s5h7_/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-y5sx2aqq/install-record.txt --single-version-externally-managed --compile --install-headers /home/ddetone/anaconda3/include/python3.8/dpviewer
         cwd: /tmp/pip-req-build-tc9s5h7_/
    Complete output (111 lines):
    running install
    running build
    running build_py
    creating build/lib.linux-x86_64-3.8
    creating build/lib.linux-x86_64-3.8/dpviewer
    copying dpviewer/__init__.py -> build/lib.linux-x86_64-3.8/dpviewer
    running build_ext
    -- The C compiler identification is GNU 7.5.0
    -- The CXX compiler identification is GNU 7.5.0
    -- Check for working C compiler: /usr/bin/cc
    -- Check for working C compiler: /usr/bin/cc -- works
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Check for working CXX compiler: /usr/bin/c++
    -- Check for working CXX compiler: /usr/bin/c++ -- works
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- The CUDA compiler identification is NVIDIA 11.3.58
    -- Check for working CUDA compiler: /usr/local/cuda-11.3/bin/nvcc
    -- Check for working CUDA compiler: /usr/local/cuda-11.3/bin/nvcc -- works
    -- Detecting CUDA compiler ABI info
    -- Detecting CUDA compiler ABI info - done
    -- Automatic GPU detection failed. Building for common architectures.
    -- Looking for pthread.h
    -- Looking for pthread.h - found
    -- Looking for pthread_create
    -- Looking for pthread_create - not found
    -- Looking for pthread_create in pthreads
    -- Looking for pthread_create in pthreads - not found
    -- Looking for pthread_create in pthread
    -- Looking for pthread_create in pthread - found
    -- Found Threads: TRUE
    -- Found CUDA: /usr/local/cuda-11.3 (found version "11.3")
    -- Caffe2: CUDA detected: 11.3
    -- Caffe2: CUDA nvcc is: /usr/local/cuda-11.3/bin/nvcc
    -- Caffe2: CUDA toolkit directory: /usr/local/cuda-11.3
    -- Caffe2: Header version is: 11.3
    -- Found CUDNN: /usr/lib/x86_64-linux-gnu/libcudnn.so
    -- Found cuDNN: v8.5.0  (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libcudnn.so)
    -- /usr/local/cuda-11.3/lib64/libnvrtc.so shorthash is 8aa72235
    -- Autodetected CUDA architecture(s):  7.5
    -- Added CUDA NVCC flags for: -gencode;arch=compute_75,code=sm_75
    CMake Warning at /home/ddetone/anaconda3/lib/python3.8/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:22 (message):
      static library kineto_LIBRARY-NOTFOUND not found.
    Call Stack (most recent call first):
      /home/ddetone/anaconda3/lib/python3.8/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:127 (append_torchlib_if_found)
      CMakeLists.txt:24 (find_package)

    -- Found Torch: /home/ddetone/anaconda3/lib/python3.8/site-packages/torch/lib/libtorch.so
    -- pybind11 v2.10.0 dev1
    -- Found PythonInterp: /home/ddetone/anaconda3/bin/python (found suitable version "3.8.3", minimum required is "3.6")
    -- Found PythonLibs: /home/ddetone/anaconda3/lib/libpython3.8.so
    -- Performing Test HAS_FLTO
    -- Performing Test HAS_FLTO - Success
    -- Configuring done
    CMake Error at pybind11/tools/pybind11Tools.cmake:173 (add_library):
      CUDA_STANDARD is set to invalid value '17'
    Call Stack (most recent call first):
      dpviewer/CMakeLists.txt:8 (pybind11_add_module)

    -- Generating done
    -- Build files have been written to: /tmp/pip-req-build-tc9s5h7_/build/temp.linux-x86_64-3.8
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-tc9s5h7_/setup.py", line 123, in <module>
        setup(
      File "/home/ddetone/anaconda3/lib/python3.8/site-packages/setuptools/__init__.py", line 165, in setup
        return distutils.core.setup(**attrs)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/core.py", line 148, in setup
        dist.run_commands()
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 966, in run_commands
        self.run_command(cmd)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
        cmd_obj.run()
      File "/home/ddetone/anaconda3/lib/python3.8/site-packages/setuptools/command/install.py", line 61, in run
        return orig.install.run(self)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/install.py", line 545, in run
        self.run_command('build')
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/cmd.py", line 313, in run_command
        self.distribution.run_command(command)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
        cmd_obj.run()
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build.py", line 135, in run
        self.run_command(cmd_name)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/cmd.py", line 313, in run_command
        self.distribution.run_command(command)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
        cmd_obj.run()
      File "/home/ddetone/anaconda3/lib/python3.8/site-packages/setuptools/command/build_ext.py", line 87, in run
        _build_ext.run(self)
      File "/home/ddetone/anaconda3/lib/python3.8/site-packages/Cython/Distutils/old_build_ext.py", line 186, in run
        _build_ext.build_ext.run(self)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 340, in run
        self.build_extensions()
      File "/home/ddetone/anaconda3/lib/python3.8/site-packages/Cython/Distutils/old_build_ext.py", line 195, in build_extensions
        _build_ext.build_ext.build_extensions(self)
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 449, in build_extensions
        self._build_extensions_serial()
      File "/home/ddetone/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 474, in _build_extensions_serial
        self.build_extension(ext)
      File "/tmp/pip-req-build-tc9s5h7_/setup.py", line 112, in build_extension
        subprocess.check_call(
      File "/home/ddetone/anaconda3/lib/python3.8/subprocess.py", line 364, in check_call
        raise CalledProcessError(retcode, cmd)
    subprocess.CalledProcessError: Command '['cmake', '/tmp/pip-req-build-tc9s5h7_', '-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/tmp/pip-req-build-tc9s5h7_/build/lib.linux-x86_64-3.8/', '-DPYTHON_EXECUTABLE=/home/ddetone/anaconda3/bin/python', '-DCMAKE_BUILD_TYPE=Release', '-DTORCH_PATH=/home/ddetone/anaconda3/lib/python3.8/site-packages/torch', '-DEXAMPLE_VERSION_INFO=0.0.1']' returned non-zero exit status 1.
    ----------------------------------------
ERROR: Command errored out with exit status 1: /home/ddetone/anaconda3/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-tc9s5h7_/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-tc9s5h7_/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-y5sx2aqq/install-record.txt --single-version-externally-managed --compile --install-headers /home/ddetone/anaconda3/include/python3.8/dpviewer Check the logs for full command output.

I got the same question and solved it by changing the cmake version to 3.23

I got the same problem and followed @Lightingooo 's solution and the problem is solved.
Mention that when running cmake .. in Pangolin/build, cmake version 3.23 will cause other errors. I was running cmake(3.16.3) in Pangolin/build and no errors occurred. After installing Pangolin, I switched to cmake(3.23.0) and ran pip install ./DPViewer and also there were no errors.


Flatpickr become totally broken after update 2.4.9

Hello. I was using Flatpickr since february and last update i've installed on my server was 2.4.7. Yesterday you mentioned me with message, that patch 2.5.4 should fix issue #625 and i've installed fresh update, but i was already asleep and i didn't notice, that the calendar become totally broken. See screenshots below.
Patch 2.4.7: looks OK

Patch 2.4.9: broken styles

Also, there's broken monthes switching:

I assumed my custom css styles are still the issue, but then i toggled max-width property to fill days-wrapper with nums, but issue still exists:

After all, i still believe my custom styles are the cause, but i don't understand, why monthes switcher is broken.

Your Environment

flatpickr version used: 2.4.9, 2.5.4
Browser name and version: Chrome 57
OS and version: Windows 7

Hello,
The commit actually referenced the wrong issue :laugh:
Some css has changed but there are just minor differences.
To resolve your problem immediately, try setting animate: false
Then you may perhaps upgrade your css

@chmln yep, animate: false resolved this issue.

@JamesJGoodwin the only change you'd probably need to make is replace flatpickr-days in your css with .flatpickr-days .dayContainer
I'll close the issue now, but feel free to ask any questions


Automatically chose eltype of OperatorConv weights

I tried to replace FourierTransform with ChebychevTransform in OperatorKernel but this did not work since the later implicitly assumes complex weights in the OperatorConv. I changed it such that the eltype is derived from the Transform.

It looks good to me.


WiFi password with double quote

Hi, I noticed that WiFi passwords with double quotes aren't properly escaped when entered during the provisioning process. I checked the value in config.py and noticed it was truncated at the first double quote.

Cor, this was a journey - it took me about four hours to pin down the exact cause and put together a small fix for it. https://github.com/pimoroni/enviro/commit/fc91b98a27c24c2980b0aec21159279cd1ad09ed

@lowfatcode Geez, ain't that just way? Thanks so much for the fix! Appreciate the time you put in to this.


[Platforms] Maintenance of platform capability categories

As mentioned here we'd like to help projects find their place in the list of platform capabilities in the definition white paper; and/or suggest changes or additions to the list.
We'd also like to compare and contrast the list of capabilities in the platforms paper with the categories in the CNCF landscape and list of TAGs too.
It could be helpful to synchronize or correlate all of these lists to reduce complexity for users and projects.

In trying to get alignment on current WG priorities, I am going to suggest we close this topic. But before doing so, I want to give 1 week for anyone who is interested to revive the focus on this, else we can reopen in the future when we have the right people/energies to commit to this topic.
Thanks!

Per my last message, I am closing for now but am happy to reopen this conversation if it becomes higher priority / has a sponsor to drive it!


Please use SemVer (v2.1.16 breaks v2.1.15-compatible installations)

Hello,
v2.1.16 broke our setup with some backwards-incompatible indexing changes.
This should more appropriately have been v2.2.0, possibly 3.0.0.
Given a version number MAJOR.MINOR.PATCH, increment the:
MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backwards compatible manner
PATCH version when you make backwards compatible bug fixes

I didn't expect it to break backwards compatibility

Version 2.1.16  is deprecated and 2.2.0 is published


Some crashes with firebase sdk

I got some crashes with firebase sdk recently, here are some infomations. How to fix that?
the crashes list:

the details:

the sdk & version:

For each stack trace posted, can you expand the full stack trace to show the hidden symbols (click on the triangle icons on the left side of the stack trace)?

Do you know which iOS versions caused the crashes?

11.3.1 (15E302) iPhone 7
11.2.5 (15D60) iPhone 7 Plus
11.3.1 (15E302) 7 Plus

11.2.1 (15C153) iPhone 7
11.3.1 (15E302) iPhone X
11.3.1 (15E302) iPhone 6

11.2.5 (15D60) iPhone 7 Plus
11.3.0 (15E216) iPhone 7

11.2.5 (15D60) iPhone 7 Plus

11.2.5 (15D60) iPhone 7 Plus

The crashes here are all in methods that shouldn't crash (like +[NSDate date]) or in retain/release. They may not be issues related to Firebase, and we likely won't be able to debug them without repro.

@Lingyj can you try updating to Firebase 5 and seeing if these are still present?

I catght it just now but only once. I opened the Zombie Objects and run the project, the crash occured.

An other one

I guess the crash [FIRASearchAdReporter scheduleSearchAdReport]  because of nonatomic. nonatomic is not thread-safe. In the other thread, the method is executing and coursed the crash. You can read this link.

I think the self in the async block might have been deallocated. We should check whether self has been nil in the async call block. Can someone fix the FIRMutableDictionary and  FIRNetwork? @morganchen12 @ryanwilson
Regarding the screenshot of FIRAMonitor, please upgrade to the latest version and use the flag UseCFPreferencesLibrary=YES in the Info.plist? Please let us know whether you see the crash again. Thanks

@Lingyj are you able to capture the same zombie crash with an exception breakpoint enabled (or are you able to share the exception message with the backtrace)? The stack traces provided end in __dealloc_zombie, which IIRC is not indicative of a bad access when zombies are enabled.

FIRMutableDictionary seem only happened with Zombie Objects. I closed Zombie Objects and
cannot reappearance.
What about [FIRASearchAdReporter scheduleSearchAdReport], I got 18 crashes in the last 7 days. Any suggestion? We will have a new release in a few days. I did update to the latest sdk and add UseCFPreferencesLibrary .

I'll try to fix FIRASearchAdReporter but the scheduled release won't be out until next month. Sorry for keeping you waiting.

Hello, I got a serious problem with the lastest sdk.  [FIRAMeasurement monitor]  crash 140 times in two days, most on iOS11.4.0. Old crashes seems have been fixed in the lastest sdk.

Here the sdk version:

Using Firebase (5.3.0)
Using FirebaseAnalytics (5.0.1)
Using FirebaseCore (5.0.4)
Using FirebaseInstanceID (3.1.1)
Using FirebaseMessaging (3.0.2)
Using FirebasePerformance (2.0.1)
Using FirebaseSwizzlingUtilities (2.0.0)

Seems there have a singleton with FIRAMeasurement. When the signleton init, it calls [FIRAUserDefaults synchronize], and FIRAUserDefaults recall the singleton before the singleton finish.

@Lingyj : I have filed internal bug at b/110876085. The fix should be in the next release of Firebase Analytics. Thanks for reporting

The fix was shipped in Firebase 5.5.0 last week.