[10.x] ReflectiveConstants

This trait represents a refined embodiment of the original concept presented in PR #49368.
Why is this necessary?
Well, the use of class constants for various purposes is quite common, but dynamic and easy reading from external classes can become cumbersome. So, what is proposed here are implementations that exist as helper classes, traits, or similar in some systems.
I believe incorporating this into the Laravel core would be extremely beneficial. It definitely adds a super clean and concise syntax for working with constants of any class (Models, Controllers, Services, Enums, etc.).
Example in action:
<?php

// Example class
class MyClass
{
     use Illuminate\Support\Traits\ReflectiveConstants;

     const STATUS_ACTIVE = 'active';
     const STATUS_INACTIVE = 'inactive';
     const MAX_ATTEMPTS = 5;
}

Empower your codebase from external classes:
// Access the 'STATUS_ACTIVE' constant 🚀
$value = MyClass::constant('STATUS_ACTIVE');

// Access the 'MAX_ATTEMPTS' constant or gracefully handle its absence 🎯
$valueOrNull = MyClass::constantOrNull('MAX_ATTEMPTS');

// Unleash the power of 'UNKNOWN_CONSTANT' or elegantly handle its absence with style 🌈
$valueOrFail = MyClass::constantOrFail('UNKNOWN_CONSTANT');

// Access 'UNKNOWN_CONSTANT' smoothly or fallback to a default value with style 🌟
$valueOrDefault = MyClass::constantOr('UNKNOWN_CONSTANT', 'default_value');

// Get all constants of the class encapsulated in an elegant \stdClass object 🎁
$allConstants = MyClass::getAllConstants();

// Validate the existence of a specific constant with a single call 🧐
$hasConstant = MyClass::hasConstant('STATUS_ACTIVE');

Please consider the new benefits and facilities of the framework. I apologize for insisting on the purpose of this trait, but it is much cleaner than creating methods that often lack a standard for working with constants. 🚀✨"
// Dynamic usage of ConstantAccessor in a loop

$constantsToRetrieve = ['PI', 'EULER_NUMBER', 'GOLDEN_RATIO', 'SQUARE_ROOT_2'];

foreach ($constantsToRetrieve as $constantName) {
    $constantValue = MathConstants::constant($constantName);
    echo "$constantName: $constantValue\n";
}

Before
$class = new ReflectionClass(ClassName::class);
$constantValue = constant("$class->getShortName()::$constantName");

Now
$constantValue =  ClassName::constant($constantName);

What's wrong with Class::CONSTANT_NAME?

¿Qué tiene de malo Class::CONSTANT_NAME?

Nada ma

ReflectionClass

"It's not to replace that way of calling constants. If you observe, the goal is to dynamically retrieve the values of constants or conveniently handle their values. In the examples, you see the utilities that you won't be able to have with the :: accessor and the class name."

https://php.watch/versions/8.3/dynamic-class-const-enum-member-syntax-support


MRG: Do not overwrite times_in in spectral_connectivity

Reference issue
Fixes #8824.
What does this implement/fix?
The mne.spectral.spectral_connectivity method now correctly reads and uses the time axis when given a mne.Epochs data object.
It used to rewrite the time axis from the data with a generic one. This caused the time interval given as tmin and tmax arguments to not be aligned with the data.
A warning has been added if either tmin or tmax bound falls outside of the scope of the data.
A test to check for this issue has been added.
Additional information
Prior to the fix, this used to raise a ValueError as shown below:
(mnedev) ap@cookie:/opt/mne-python/mne/tests$ pytest test_spectral_connectivity.py
============================================================================================================ test session starts =============================================================================================================
platform linux -- Python 3.8.6, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
rootdir: /opt/mne-python, configfile: setup.cfg
plugins: cov-2.11.1, timeout-1.4.2, harvest-1.10.1
collected 1 item

test_spectral_connectivity.py F                                                                                [100%]

========================================================================================================== slowest 20 test modules ===========================================================================================================
0.40s total    mne/tests/test_spectral_connectivity.py

================================================================================================================== FAILURES ==================================================================================================================
_________________________________________________________________________________________________________ test_spectral_connectivity _________________________________________________________________________________________________________
test_spectral_connectivity.py:40: in test_spectral_connectivity
    ret = spectral_connectivity(epochs, method='pli', mode='multitaper',
<decorator-gen-446>:24: in spectral_connectivity
    ???
../connectivity/spectral.py:785: in spectral_connectivity
    n_signals, indices_use) = _prepare_connectivity(
../connectivity/spectral.py:948: in _prepare_connectivity
    mask = _time_mask(times_in, tmin, tmax, sfreq=sfreq)
../utils/numerics.py:493: in _time_mask
    raise ValueError('No samples remain when using tmin=%s and tmax=%s %s'
E   ValueError: No samples remain when using tmin=-0.9 and tmax=-0.2 (original time bounds are [0.0, 2.001282051803185])

I've amended the test to make them clearer as you've suggested.
Thank a lot for taking the time to check this PR!

@apadee I forgot to ask you to add yourself to doc/changes/names.inc so I took the liberty to do it for you.  If you prefer to link to a different page rather than your GitHub page, feel free to force-push a change to that file (git add doc/changes/names.inc; git commit; git push -f)

I could not push directly, see https://github.com/apadee/mne-python/pull/1

I stand corrected, I could push directly. Will merge once CIs come back happy

Congrats on your first contribution @apadee !

Thank you! It was very instructive, I am happy I could contribute! :)


Space press doesn’t change the intermediate state (Safari)

In can reproduce this issue in the UX-test app, but I can't reproduce it locally. Probably it was fixed in the meantime, maybe https://github.com/vaadin/vaadin-checkbox/issues/15 was the reason and it looks like https://github.com/vaadin/vaadin-checkbox/pull/23 fixes this issue also.
Revisit after merging https://github.com/vaadin/vaadin-checkbox/pull/23

worksforme also

Most probably this is an issue in https://wc.demo.vaadin.com/vaadin-checkbox-ux-test/ Closing for now.


dns: Add DataSource field to ProxyRequestContext

Add Datasource field to ProxyRequestContext so that NotifyOnDNSMsgFunc callback can retrieve the data source information from request context instead of assuming the data source is always "proxy".
Signed-off-by: Michi Mutsuzaki<EMAIL_ADDRESS>

/test

test-1.23-5.4: https://github.com/cilium/cilium/issues/21735
test-runtime: seems to be a new failure

/test-1.23-5.4

/test-runtime

/test-runtime


Set class for linkToAction()

I'm trying to set the class HTML attribute when using linkToAction() targeting Controller.create and it does not seem to be working.
Code:
{{ linkToAction('admin/AccountController.create', 'Create Account', {class: 'btn btn-success'}) }}
Output:
Create
Please advise.

I would suggest using the action filter http://adonisjs.com/docs/3.2/templating#_action. linkToAction is a quick way to create a link without any attributes.
Also I personally prefer designing the links by selecting the parent element, instead of giving classes to them.
Example of action file

Perfect!


Xenpv

I found that the last ci test is 18 days ago and it was failed.
Is there any problem hard to be fixed?

container creation failed in hyper::test::nfs_volume

nfs client mount succeeded. But exec hang when doing ls /export in the client container. My guess is that the nfs server got OOM-killed after client mount succeeded.

retest this please, @hykins

retest this please @hykins

LGTM


refactor attribute fakebag

To facilitate moving expressions out of mixer.
/assign @ozevren
Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: douglas-reid, kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [douglas-reid,kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
98935c46932f709806c9cf1ac4e7f7d3614b8906
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
98935c46932f709806c9cf1ac4e7f7d3614b8906
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
98935c46932f709806c9cf1ac4e7f7d3614b8906
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
98935c46932f709806c9cf1ac4e7f7d3614b8906
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master


ISPN-12892 Exclude MXParser dependency

https://issues.redhat.com/browse/ISPN-12892
:crossed_fingers:

Merged, thanks!


Support for Markdown documents

Markdown is a popular markup language commonly used to write Web documents in a concise and transparent manner.
It is the first choice of SSG users and bloggers, and the language is also a priority of mine.
Therefore, Crocc should support Markdown, especially CommonMark as it is a reasonable and accepted standard around Markdown.

A good starting point would be to use Remarkjs, a unifiedjs-compatible Markdown processor with a great ecosystem.
Also, Remark is the package used by many other Nodejs-based SSG, proving its high-quality.


Add StrictHostKeyChecking=no in SSH config

/home/onp/.ssh/config

Added that option with an alias.
https://github.com/kevydotvinu/openshift-network-playground/blob/1b2d0508f573f551c4db64ad1f055b5bc2a3b0d1/ignition/00-core.bu#L2027


Add other standards?

This is a question up for debate: should this standard include other standards which we recommend, such as WordPress (which itself contains Squiz and others) and VariableAnalysis?
Personally I think we should not, because it makes the standards too tightly coupled. I think instead we could consider creating a separate repository which was effectively just a ruleset.xml file that included all these standards. This would be similar, in a way, to babel's presets or an eslint sharable config.

Created a meta-ruleset here: https://github.com/Automattic/phpcs-neutron-ruleset
To do:

[ ] update README in this repo to refer to the meta repo


Stop retaining self in rxReuestWithProgress

Fixes inconsitency in #1294

          1 Warning

:warning:
The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

  Generated by :no_entry_sign: Danger

@AndrewSB I grabbed the error from the build log so you don't need to go hunting 😃
/Users/distiller/Moya/Sources/RxMoya/MoyaProvider+Rx.swift:64:17: value of optional type 'Cancellable?' not unwrapped; did you mean to use '!' or '?'?
Also, we have started to formalize the CHANGELOG guidelines. I noticed you added this under the Changed section but it could be better under Fixed.

This solution contains a bug, example:
    var stream = Observable<Void>.create { observer in
      return Disposables.create {
      }
    }

    stream.subscribe(onError: { _ in
      print("doOnError")
    }, onCompleted: {
      print("doOnCompleted")
    }, onDispose: {
      print("doOnDispose")
    })

No callback is called !!! Observable should be silent. If you are saying it is disposed when self is nil, call  onDispose callback

Sorry about the sloppy pull requests @SD10 @sunshinejr, both here and #1292. I'll work on testing my changes before submitting them so you guys don't have to play compiler for me -- I've been doing less Swift lately so it looks like my intuition is less on point than it used to be 😥

Codecov Report

Merging #1311 into 10.0.0-dev will not change coverage.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           10.0.0-dev    #1311   +/-   ##
===========================================
  Coverage       85.67%   85.67%
===========================================
  Files              24       24
  Lines             768      768
===========================================
  Hits              658      658
  Misses            110      110

Impacted Files
Coverage Δ

Sources/RxMoya/MoyaProvider+Rx.swift
91.66% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c74420...4ef5739. Read the comment docs.

@AndrewSB
this example:
    let singleStream = Observable<Int>
      .interval(1, scheduler: MainScheduler.instance)
      .timeout(1, scheduler: MainScheduler.instance)
      .asSingle()
      .do(onNext: { _ in
      print("onNext")
    }, onError: { _ in
      print("onError")
    }, onSubscribe: {
      print("onSubscribe")
    }, onSubscribed: {
      print("onSubscribed")
    }, onDispose: {
      print("onDispose")
    })

    singleStream.subscribe().dispose()

prints:
onSubscribe
onSubscribed
onDispose

So onDispose at least should be called, please fix

@volodg this PR focus rather on inconsistency than on fixing the Single behavior - let's focus at one thing at a time. @AndrewSB I think there is only a Changelog fix left to merge 👍

@volodg from my understanding, onDispose is already being called if the Single is disposed. in this comment https://github.com/Moya/Moya/pull/1294#issue-258728763 for example, the .debug() operator prints isDisposed.
@sunshinejr sounds good! Once I commit can you re-review before merge?

Sure thing 👍

@AndrewSB I don't see any changes to the Changelog 🤔 What I'm talking about is that comment about making it in the separate column Fixed, instead of having it in Changed.

I went ahead and fixed the Changelog. It should be good to go now. Please re-review @Moya/contributors.

@SD10 thank you!


Give links English descriptions

Linkie looks for all text that forms a URL and checks if it is broken. If we use links as the description Linkie will think they are followable links and may report them to be broken when the actual link it follows isn't.

Closing as this will be resolved by https://github.com/uccser/linkie/pull/18


Doesn't work in 4.3

When loading a project containing Cyclops in 4.3:
  res://addons/cyclops_level_builder/exporter/exporter_gltf_wizard.gd:26 - Parse Error: Class "ExporterGltfWizard" hides a global script class.
  modules/gdscript/gdscript.cpp:2936 - Failed to load script "res://addons/cyclops_level_builder/exporter/exporter_gltf_wizard.gd" with error "Parse error". (User)
  res://addons/cyclops_level_builder/exporter/exporter_godot_scene_wizard.gd:26 - Parse Error: Class "ExporterGodotSceneWizard" hides a global script class.
  modules/gdscript/gdscript.cpp:2936 - Failed to load script "res://addons/cyclops_level_builder/exporter/exporter_godot_scene_wizard.gd" with error "Parse error". (User)

When trying to play the game:
Could not resolve external class member "data".

in convexblockdata.gd:99
For some weird reason my scenes look fine in editor (blocks didn't disappear or anything).

Similar to https://github.com/blackears/cyclopsLevelBuilder/issues/192

So just to be sure, check out master branch, run create_addon_archive.py, import the result thing and everything will be fine?

Yes.  Just replace everyting in the /addon folder.  You may need to reload twice.

Um... finally got around to doing that and the exact same thing still happens. This issue is not solved.

I'm guessing that your build is out of date.  The first two errors you mention are due to Godot not registering the class names correctly.  And DataVectorByte definitely has a field named data.  I've had to deal with similar situations a few times where Godot just refuses to update how it registers (or "compiles" or whatever it is doing) different classes, even after restarting.  Sometimes deleting the .godot folder and restarting will help.  But I've had to completely rebuild my project once too, so it's possible you might need to rebuild your project in a fresh directory.
I can run my test program without error so I'm thinking this is perhaps specific to your machine.  Godot doesn't compile the scripts - it's doing something else and caching it which causes weird inconsistencies.  I was hoping this would be fixed in 4.3, but apparently not.

For those that come to this via google: To fix it, I had to delete the cyclops folder in the addons and then reinstall it from scratch from main.


Add initial support for migration using DataAccessDelegate, Migrator

This changeset adds a bunch of code necessary to support delegate-based hooks for doing migrations before the data stack is initialized, along with a Migrator protocol in Core and a CoreDataMigrator concrete implementation in the CoreData subspec.

This closes #7.


Retry for util init robot account creation

A work-around for the gcp-connector-util init server error in issue #206:
Failed to initialize robot account: 500 Internal Server Error
This definitely works - tested over 20 times.
Here's a typical run:
Visit https://www.google.com/device, and enter this code. I'll wait for you.
LJSK-DJFV
Initializing robot account
The server seems busy. Retrying ...
Initializing robot account (attempt 2)
Acquired OAuth credentials for robot account
Notes:

It only retries on the specific 500 status code failure, but other failure retries can quickly be added
For simplicity it retries forever (until Ctrl-C) but I've never seen it take more than 3 attempts
The Response clean-up might be overkill, but it guards against copy-and-paste bugs (and I learnt something)

Thanks for this code. I believe it is obsolete since we now do exponential backoff across all http requests with issue #244 closed.


Washington Daily Total Test Result not consistent with the official dashboard

On the government dashboard, the total test number is available:

but the covid19tracking dataset has total test result same as test positive result, leading to positive rate = 1!
Could you please take a look into this?

Sorry I was wrong about my statement, the government did not release total result after Aug 11.


REQUEST: Option to dump the tabs?

LOVE this module. Been hoping someone would make something like this for a long time now. The only thing is, I'm not a big fan of spreading everything out to multiple chat tabs, and would prefer it all to just be in one chat room. Is there any chance you could add a setting to turn off the chat room tabs?

Possibly.  I'll take a look into it.

v1.0.1 now has a setting to disable the extra tab.


Cd faq revamp

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664b24b58c65b18e324ce3aa--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664b374ed44591993095f5eb--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664d72cc5caf3d8f7ae26fff--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664d72f5d0044e8ae9a6eceb--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664d7784b6924d933c25f652--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664d7917e70cb88df09c1e74--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664d7a75f9717a8fb1f9ea14--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664d7aebdb6695899b65cc2c--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664db27e69e42ac5533de23f--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664db5520ea540caa615211d--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664db5935caf3dce54e24f8b--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664dc0400887e9d97c3b2403--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664dc09964fc28c9d69bf27f--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664e3cafbac6f515c11dcea2--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664e3f0e4e05c1174cc93729--harness-developer.netlify.app


Use Jest and vue-test-utils

I'd like to make a PR that replaces mocha and karma with Jest, as well as adding vue-test-utils to the project.
The reasons for Jest over Karma/ mocha:

Faster
Less config
No browser
No webpack for tests

Another issue is requiring everything the src directory. This installs vue-router, which adds $route as a read only property to the global Vue class. This means people can't stub $route in tests, and if you don't know all the files are required before running the tests, it can be difficult to debug

You have my vote :-P

I've made a PR to replace karma and mocha. I'll make another PR to add vue-test-utils when it's release

I've created a vue jest preprocessor that adds source maps. In light of the patent drama, are we still happy to go ahead with replacing Karma and mocha with Jest?

Okay so we got jest included - go get that 1.0.0 release for vue-test-utils and we can close this :)


Measurements taking a long time

When using the measuring tool, It takes quite some time.
Have tried running from two different computers, with the same result. (docker)
Running time for color_temp is 3.2h and for brightness 40.7 min

GitHub seems to dislike my files ;) hope it works now...
env.txt
CLI hs.txt

Running time for color_temp is 3.2h and for brightness 40.7 min
Slow measurement is by design

Yes, this are not shocking time. Slow measurements are by design. We need enough data points to have quality LUT files, and also wait some time between changing the light and reading the powermeter (to ensure the powermeter is stabilized to new value)
In the most ideal situation the brightness mode should take ~15 minutes, and the hs mode ~1.5 hours.
I suspect you'll maybe see some outdated measurement errors in the logs because you are using a Zwave based smart plug and that probably does not update frequent enought, causing the measurement tool to retry a few times. That wil cause the total time to take longer.
So conclusion, these times are expected. It's only a one time effort and you can just start the session and do something else and return when finished.

Sorry, forgot the time for hs-mode as well.
The hs-mode (the CLI output in file) is 279 hours, that will be over 11 days and that is quite a long time to run the test, not to mention not being able to use the ligth for that time.
So I guess I need a diffrent plug to get faster readings?

And which plug do you reccomend?

Hmm I see in your hs cli output the estimated time is actually 279.0h, that's not correct and seems like a bug in the measure tool. The estimated time is calculated by looking at the sleep times and amount of variations. It does not adapt during the measure session. So there is definitely something wrong. I will have a look if I can reproduce with your env settings.

I could try and run in over night and se what happens, otherwise I'm on my way ordering a shelly plug...

I get the same expected duration for hs when I use your settings. The problem is with these settings:
HS_BRI_PRECISION=4.0
HS_HUE_PRECISION=4.0
HS_SAT_PRECISION=4.0

I see you have increased those all from 1.0 to 4.0, which will increase the amount of variations for the light to be increased massively.
With the default settings 2025 light settings will be walked and taken measurements of.
With your settings 105633 settings will be done. Because each of the brightness, hue and sat will be increased by a factor of 4. So 444 will add up quicky.
It will wait 3 seconds between taking each sample, so do the maths ;-)
When you decrease these settings to 1.0 the measure session will take ~5 hours.

I have absolutely no memory of changing these, but I must have and that's why I didn't notice at all when I checked to the default setting...
I guess I need new glasses ;)
thanks for spotting it!

Haha no worries. Hope you'll succeed taking the measurements.

Hope so, starting to dought myself :)


Fix build error on win_arm64

Fixes the following build failure on win_arm64 (Windows on ARM64) with Visual Studio 2022 17.6.2:
[  8%] Building C object src/lib/OpenEXRCore/CMakeFiles/OpenEXRCore.dir/internal_dwa.c.obj
internal_dwa.c
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\include\emmintrin.h(20): fatal error C1189: #error:  This header is specific to X86, X64, ARM64, and ARM64EC targets
NMAKE : fatal error U1077: '"C:\Program Files\CMake\bin\cmake.exe" -E cmake_cl_compile_depends --dep-file=CMakeFiles\OpenEXRCore.dir\internal_dwa.c.obj.d --working-dir=C:\Build\_build\openexr-v3.1.8\_build-vc17-arm64\src\lib\OpenEXRCore --filter-prefix="Note: including file: " -- C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\1436~1.325\bin\HOSTAR~1\arm64\cl.exe @C:\Users\gohlke\AppData\Local\Temp\nm1EA5.tmp' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\HostARM64\ARM64\nmake.exe" -s -f src\lib\OpenEXRCore\CMakeFiles\OpenEXRCore.dir\build.make /nologo -SL                 src\lib\OpenEXRCore\CMakeFiles\OpenEXRCore.dir\build' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\HostARM64\ARM64\nmake.exe" -s -f CMakeFiles\Makefile2 /nologo -LS                 all' : return code '0x2'
Stop.
Build failed!

Should this check not be the same as the one in SimfSimd.h: #if defined __SSE2__ || (_MSC_VER && (_M_IX86 || _M_X64))?

@kdt3rd and @meshula, another instance of SSE detection gone wrong, but as @dlemstra suggests, shouldn't this be the same as the logic in src/lib/OpenEXR/ImfSimd.h?

The difference is the _M_CEE_PURE flag. if defined __SSE2__ || (_MSC_VER >= 1300 && (_M_IX86 || _M_X64) && !_M_CEE_PURE)
Aug 7, 2022 — _M_CEE_PURE Deprecated beginning in Visual Studio 2015. Defined as 001 if the /clr:pure compiler option is set. Otherwise, undefined.

the behavior of MSVC is that if the macro is undefined, the value is zero. _MSC_VER 1300 is VS 2002.... Definitely we don't need to check for VS2002, or _M_CEE_PURE, since we don't actively support VS2015 or VS2002.
the check is going to work, but it's full of stuff that should be removed. The check @dlemstra indicates makes more sense!

@cgohlke, could you possibly update your change to match @dlemstra's suggestion?  That's
https://github.com/AcademySoftwareFoundation/openexr/blob/fe463369d1c183e296024f58c4c0f2a4bd8aabc2/src/lib/OpenEXR/ImfSimd.h#L16
Or let me know and I can submit a separate PR. Thanks!

@cgohlke, could you possibly update your change

Done.


[Feat]: Add Dockerfile

What feature?
Currently, there's no Dockerfile or .dockerignore file in the repository. Adding them will make it easier to set up and easy to set up the project locally.
If you agree with this enhancement, I'd be happy to contribute by providing the Dockerfile and .dockerignore files
Add screenshots
Add screenshots
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Please assing this issue to me I will add and deploy image in docker

@Saurav-Pant I don't know anything about it. Can you share some articles or reference I can look to gain basic understanding of it.

Thanks for taking a look into it, Here's the one blog @shyamtawli
how to create docker file for react application detail blog

Hi i would like to try add this feat if it's still open. please assign it to me.


question about Appendix B

Could you please tell me which part of the main text and code corresponds to the “neural shading work h” in Appendix B of the paper? I didn’t quite understand this section.

I believe this is the corresponding section: https://github.com/half-potato/nmf/blob/7c79de00d111b5fdc0a6d0af2a9c00ee63bacb0f/models/microfacet.py#L596

I believe this is the corresponding section:
https://github.com/half-potato/nmf/blob/7c79de00d111b5fdc0a6d0af2a9c00ee63bacb0f/models/microfacet.py#L596

thank you! I’ll go take a closer look


plasmahud: fix runtime errors and other cleanup

Description of changes

fix runtime errors (fixes #209750)
clean up installPhase
fix scoping for propagatedBuildInputs
formatting
clean up src
remove with lib;

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

@asd-noor Can you check if this works now? I no longer see the error, but not sure how to test this if it's actually working either.


Add Filter Price Functionality to Search

Slider to adjust max price for search
Default is at moderate (2)

Conversion goes as the following:
(1, 2, 3, 4) -> (inexpensive, moderate, expensive, very expensive)
Demo: https://jtan-sps-summer20.appspot.com/

Do you think its possible to set a lower limit as well? People might want to go for posh restaurants :laughing:

Do you think its possible to set a lower limit as well? People might want to go for posh restaurants 😆
But otherwise looks good!

We could do that if we used a library for sliders like: https://refreshless.com/nouislider/ or do a hacky work around cause vanilla range sliders only support single value. I think I will explore more after we complete all the other feature first


ClientModel: NullableResult and Result experiment

Exploring options around NullableResult and Result inheritance relationships

API change check
APIView has identified API level changes in this PR and created following API reviews.
System.Net.ClientModel


CIP-36 test vector CBOR incorrect

as per schema.cddl:
delegation = ($voting_pub_key, $weight)

key_registration = {
  1 : [+delegation] / legacy_key_registration,
  2 : $stake_credential,
  3 : $reward_address,
  4 : $nonce,
  ? 5 : $voting_purpose .default 0
}

you can see the non-legacy delegation (key 1) is an array of delegation, a basic group that isn't array-encoded where it's defined.
However the test vector for the non-legacy format is a119ef64a50182825820a6a3c0447aeb9cc54cf6422ba32b294e5e1c3ef6d782f2acff4a70694c4d16630182582000588e8e1d18cba576a4d35758069fe94e53f638b6faf7c07b8abd2bc5c5cdee0302582086870efc99c453a873a16492ce87738ec79a0ebd064379a62e2c9cf4e119219e03581de0ae3a0a7aeda4aea522e74e4fe36759fca80789a613a58a4364f6ecef041904d20500 which decoded (using cbor.me) is:
{
    61284: {
        1: [
              [h'A6A3C0447AEB9CC54CF6422BA32B294E5E1C3EF6D782F2ACFF4A70694C4D1663', 1],
              [h'00588E8E1D18CBA576A4D35758069FE94E53F638B6FAF7C07B8ABD2BC5C5CDEE', 3]
        ],
        2: h'86870EFC99C453A873A16492CE87738EC79A0EBD064379A62E2C9CF4E119219E',
        3: h'E0AE3A0A7AEDA4AEA522E74E4FE36759FCA80789A613A58A4364F6ECEF',
        4: 1234,
        5: 0
    }
}

likewise the final human-readable part of the test vector says (2 element array with 2 element arrays as the elements):
{
  61284: {
    1: [['0xa6a3c0447aeb9cc54cf6422ba32b294e5e1c3ef6d782f2acff4a70694c4d1663', 1], ['0x00588e8e1d18cba576a4d35758069fe94e53f638b6faf7c07b8abd2bc5c5cdee', 3]],
    2: '0x1c5d88aa573da97e5a4667e0f7c4a9c6a3d848934c3b0a5b9296b401540f2aef',
    3: '0xe0ae3a0a7aeda4aea522e74e4fe36759fca80789a613a58a4364f6ecef',
    4: 1234,
    5: 0
  },
  61285: {
    1: '0x3aaa2e6b43c0a96e880a7d70df84dffb2a1a17b19d7a99a6ed27b91d499b32027c43acfbf6dff097af7634b2ee38c8039af259b0b6a64316f02b4ffee28a0608'
  }
}

According to the schema.cddl spec that key should actually be (one 4-element array):
        1: [
              h'A6A3C0447AEB9CC54CF6422BA32B294E5E1C3EF6D782F2ACFF4A70694C4D1663',
              1,
              h'00588E8E1D18CBA576A4D35758069FE94E53F638B6FAF7C07B8ABD2BC5C5CDEE',
              3,
        ],

The test vectors seem to assume that it was instead defined as delegation = [$voting_pub_key, $weight].

Kind of related, but not as big of a deal, is that the CBOR there also has a different stake credential between the human readable final output (0x1c5d88aa573da97e5a4667e0f7c4a9c6a3d848934c3b0a5b9296b401540f2aef) and the ones beforehand (0x86870efc99c453a873a16492ce87738ec79a0ebd064379a62e2c9cf4e119219e). This is the case for both the legacy and new test vectors.
The legacy delegation also differs between the human readable and CBOR parts. In the CBOR it's the same as the 1st one in the non-legacy delegation array (0xa6a3c0447aeb9cc54cf6422ba32b294e5e1c3ef6d782f2acff4a70694c4d1663) instead of the 0x0036ef3e1f0d3f5989e2d155ea54bdb2a72c4c456ccb959af4c94868f473f5a0 in the human-readable parts (both intermediate and final).

@rooooooooob @Ryun1 perhaps while CIP-0036 is under scrutiny from https://github.com/cardano-foundation/CIPs/pull/373 we could have a corrected CBOR submitted as a PR?  I'll watch out for this & get it classified as a "correction" immediately so we can put the change through quickly.

@rphair
Yes, this is a good spot from @rooooooooob, this is a mistake in the CDDL - I have checked this with Catalyst and one of the authors; @kevinhammond.
Tomorrow I will create a PR with the correction. Thanks for the heads up.

@rphair @rooooooooob
Please see, #426.

thanks @rooooooooob @Ryun1 @kevinhammond ... closing this so further review can continue in https://github.com/cardano-foundation/CIPs/pull/426.


[Feature Request] "leads to" only matching systems

if you want to add the target system of a worhole via "leads to" a drop down lists opens with all known systems which are connected to the system.
If you selected the wormhole "type" (e.g, D845 HS) still all known connected systems are shown in that dropdown list - not regarding if they are possible matches. (e.g. in the case of the selected D845 type the drop down still shows non HS systems). This requires that pathfinder "knows" the category of the connected systems - but that should be known because the category (e.g. c1) is already shown on the map.

If would be an extra feature if that category would be additinally shown in the drop down list - that would help in case there are more then one possible connection to choose from - e.g. type is K162 c1/2/3 and there are c1, c2 and c3 connected.
PS: having just switched from siggy - i find pathfinder very cool! great job!

@Raltry good suggestion!
I started with your 2nd idea and added the system type to the selection:

Your main request, requires a new "dependency" between "WH type"-select and "leads to"-select, which is a bit more complicated to implement but still possible.
I mean when you change the "WH type" of a signatur which is already mapped to a a system, what would you expect to happen?

Should we leave the "leads to"-select with no changes (which might be wrong and does not fit with the new selected "WH type"?
Should we "reset/clear" the "leads to"-select until a new option get selected?

wow - thanks for your fast reaction!
To your question "I mean when you change the "WH type" of a signatur which is already mapped to a a system, what would you expect to happen?" I suggest you do it the way you have done it already when you select the same system in "leads to" a second time - you show a little exclamation mark which indicates that there is a problem (given that there are virtualy never 2 wormholes in one system both leading to the same system). The user has to resolve it manualy.


fix typo

Hi @Jobhdez, can you please amend the title and the commit body of your PR such that it complies with the commit message guidelines?


⚠ Mobitopup has degraded performance

In 7307596, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 4057 ms

Resolved: Mobitopup performance has improved in 99fce60.


SQL adapters: Adding multiple rulesets in an OR array, 2nd instance w/ more than one criteria makes anything subsequent fail

Waterline version<EMAIL_ADDRESS>Node version: 6.10.2
NPM version: 3.10.10
Operating system: Fedora 25

Hard to explain, but when using `OR` on a find, adding more than 1 ruleset w/ more than 1 criteria, then adding an additional ruleset and the query breaks. Query is never executed, not a DB issue.
https://github.com/gotmikhail/sails-waterline-OR-multiple-rules-multiple-criteria
mysql db required, configured for user: root, password: password, db: sailstest
No need for any data imported, you'll either get back a 200 w/ an empty array, or a 500
npm install
sails lift
option 2 (drop)
In api/controller/CensusController.js, 4 functions setup to demonstrate what happens.
4 routes configured to show results
ROUTE 1
GET /census/find1 - returns 200, empty array, searched w/
Census.find({
      or: [
        {"lastName": "marshall", "middleName": "adam"},
        {"firstName": "robin"},
        //{"lastName": "fredrickson","middleName": "beth"},
        //{"middleName": "richard"}
      ]
    })

2 rule sets in OR, 1 instance w/ more than 1 criteria, success
ROUTE 2
GET /census/find2 - returns 200, empty array, searched w/
Census.find({
      or: [
        {"lastName": "marshall", "middleName": "adam"},
        {"firstName": "robin"},
        {"lastName": "fredrickson","middleName": "beth"},
        //{"middleName": "richard"}
      ]
    })

3 rule sets in OR, 2 instances w/ more than 1 criteria, 2nd instance w/ more than 1 criteria is last, success
ROUTE 3
GET /census/find3 - returns 500
Census.find({
      or: [
        {"lastName": "marshall", "middleName": "adam"},
        {"firstName": "robin"},
        {"lastName": "fredrickson","middleName": "beth"},
        {"middleName": "richard"}
      ]
    })

4 rule sets in OR, 2 instances w/ more than 1 criteria, 2nd instance w/ more than 1 critiera is 2nd to last, fail
ROUTE 4
GET /census/find4 - returns 200
Census.find({
      or: [
        {"lastName": "marshall", "middleName": "adam"},
        {"firstName": "robin"},
        {"middleName": "richard"},
        {"lastName": "fredrickson","middleName": "beth"},
      ]
    })

4 rule sets in OR, 2 instances w/ more than 1 criteria, 2nd instance w/ more than 1 critiera MOVED to last, 200 success

@gotmikhail here's the fully expanded stage 2 query from the third example:
{ using: 'user',
  method: 'find',
  criteria:
   { where:
      { or:
         [ { and: [ { lastName: 'marshall' }, { middleName: 'adam' } ] },
           { firstName: 'robin' },
           { and: [ { lastName: 'fredrickson' }, { middleName: 'beth' } ] },
           { middleName: 'richard' } ] },
     limit:<PHONE_NUMBER>740991,
     skip: 0,
     sort: [ { id: 'ASC' } ],
     select: [ '*' ],
     omit: [] },
  meta: {},
  populates: {} }

My initial thought is that it has something to do w/ the way sails-mysql / waterline-sequel-builder is building queries in the case where an or clause is composed of some disjuncts which are nested predicates (e.g. {and: [....]}) and other disjuncts which are standard eq constraints (e.g. {middleName: 'richard'})

(Side note: I verified that this works as expected w/ sails-disk, so I'm pretty certain it's something in the SQL adapters)

Agreed that it looks SQL specific. It is in the repo's package file, but I meant to include the version, sails-mysql``1.0.0-13 in this ticket as well.

@gotmikhail thanks!  Sounds like @sgress454 is on the case

@mikermcneil @sgress454 great!

Ok, published waterline-utils 1.3.16 which includes the fix for this issue!  Best way to get it is just to re-install all your dependencies.  If you continue to see problems please re-open this issue and we'll take a look!


Help files still kept even if removed from dataset.R

When removing functions the help files are kept during the buildDataSetPackage process, even though there is no longer reference to them in the dataset.R file or any other code in the data-raw folder. For example, in the AUP567 project both the backgroundSubtract.Rd and marginalize_cytokine.Rd still are help files when loading in AUP567. Should the buildDataSetPackage process eliminated no longer used Rd files in the man folder?

Probably, yes.. I'll put in a fix when I get a chance. Thanks.


adding an alternative for cross-domain issues

I found the cross-domain fix using a proxy tedious to integrate into my project (due to how we setup all our code for our CDN etc) so I came up with a different solution;
Just fetch the same stylesheet again, without using the CDN.
I'm okay with a small percentage of my users not using the CDN and it makes my life A LOT easier :-).
Instead of adding a lot of 'magic' I just added a new attribute on my <link> called respond-href with the URL to load instead, keeping it explicit, though adding an 'invalid' attribute, but I think Respond is mostly for people who're building a HTML5 website anyway, so you won't be passing the old validators anyway?
<link rel="stylesheet" type="text/css"
      href="cdn.domain.com/statics/stylesheet.css"
      respond-href="/statics/stylesheet.css" />

I like this approach a lot better as well :+1:

hmm, one of my long forgotten PRs, @scottjehl you don't want this? or is there something I can do / change to get it merged? otherwise might as well close it?!


Enable CI & push to registry for forks

Description
Enable using our GitHub Actions workflows from forks.
Why is this needed
I was developing a couple of changes to boots and trying it out in production along with @ScottGarman. The code lived in my fork and the images were being pushed up to my personal quay repository. At one point I committed a fix and left for the day, but forgot to manually build the image and push. This left @ScottGarman stuck and needing to work around my lack of push. Why must I manually push when GitHub can do it for me?
I've been after this for a while now but failed because I was trying to push the "merged" code GitHub creates for the pull_request events. This happens in the target repository's context and thus secrets are not present for PRs from forks. I had some ideas to get around this by using the pull_request_target event but that ran against some lack of features in buildx and I burned out on that effort. This is a nice compromise though. Since the build happens for the push event, this actually takes place from the source's context and can use the secrets for the fork if present. If branches are kept up to date with upstream's main then that is just as good as the pull_request's fake-merge.
How Has This Been Tested?
Tested from my fork :tada:! https://github.com/mmlb/tinkerbell-boots/actions?query=branch%3Aenable-push-to-registry-for-forks
How are existing users impacted? What migration steps/scripts do we need?
Allows for testing of code using "upstream test procedure" before opening PRs for forks.
Allows for pushing to a container image registry from a fork if secrets are defined, which makes for easier dev testing.
Checklist:
I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

Code base has moved on quite a bit. Gonna close this out, feel free to reopen.


Support EIP1559 for Safe Txs

Coverage decreased (-0.07%) to 90.939% when pulling 2e962498c123f6d69ae75b0cb2f1c3e1b7711b11 on safe-eip1559-txs into 9d8bc915fe0303b65244a2434ca067a89b3da7ce on master.


(FACT-1175) Get Solaris 10 acceptance tests passing

Can be tested with rake ci:test:aio SHA=bd98fdd74b51eba26a76dcb2fd2d3afc0fc3596c CONFIG=config/nodes/pe/solaris-10-64a SUITE_VERSION=<IP_ADDRESS>.gbd98fdd, using Beaker from MikaelSmith:feat/master/BKR-470.

What's up with that appveyor fail at https://ci.appveyor.com/project/puppetlabs/facter/build/<IP_ADDRESS>9?

The appveyor fail is clearly unrelated. This looks good.


How to configure gui to a specific screen resolution?

How to configure gui to a specific screen resolution?

Which parts of gui do you need to configure specifically?

I imagine he meant the survival GUI as it's unaligned from the map if it isn't in 1920x1024

1080*

Could putting the hunger/thirst bars in the bottom right of the screen alongside the roles be a possible solution for the problem?
In this case it might require a redesign of the roles as well.
Let me know what you guys think and I can probably try something here.
(also related to #222)

If the solution about https://github.com/ImagicTheCat/vRP/issues/557 is not enough, now the anchor can be changed (ex: botright).

Kind of deprecated, survivals display can be re-implemented by extensions.


bugfix: --backup-meta could be 0 to disable backup

closes #2272

Codecov Report

Merging #2275 (147ba64) into main (f8bb61d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2275   +/-   ##
=======================================
  Coverage   61.89%   61.89%
=======================================
  Files         137      137
  Lines       25251    25251
=======================================
  Hits        15630    15630
+ Misses       7810     7809    -1
- Partials     1811     1812    +1

Impacted Files
Coverage Δ

cmd/mount.go
61.73% <0.00%> (ø)

pkg/meta/tkv.go
76.00% <0.00%> (-0.11%)
:arrow_down:

pkg/meta/sql.go
65.76% <0.00%> (-0.10%)
:arrow_down:

pkg/chunk/disk_cache.go
81.63% <0.00%> (ø)

pkg/meta/redis.go
71.55% <0.00%> (+0.04%)
:arrow_up:

pkg/vfs/writer.go
79.66% <0.00%> (+1.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f2b03...147ba64. Read the comment docs.


Claude-3 plugin with attachments seems to ignore prompt

If llm with the llm-claude-3 plugin version 0.6 and the claude-3-5-sonnet-latest model is used with an attachment, the prompt appears to be ignored. That's not true with, say, the gemini model.
Tested with llm -m claude-3-5-sonnet-latest  -a image.png "Ignore the image, describe birds"
The output is a the same description of the image, no matter what the prompt. For the latest gemini pro model, in contrast, the interpretation of the image is dependent on the prompt.
--log shows that the prompt and the attachment are at least being logged.

Wow that's a bad bug! Thanks for catching this.

llm -m claude-3.5-sonnet 'write a poem about this' -a https://static.simonwillison.net/static/2024/pelican.jpg

This is a beautiful shot of a Brown Pelican perched on some rocky shoreline, with boats visible in the background. The pelican's distinctive profile and long beak are nicely highlighted, and there's a lovely rim lighting effect around its head and neck that creates an almost glowing appearance. The bird appears to be in its adult plumage, with the characteristic gray-brown coloring. Brown Pelicans are common along coastal areas, and this one seems right at home in what looks like a marina or harbor setting. The image has nice depth of field, keeping the pelican sharp while softly blurring the boats in the background.

Manual testing of the fix:
% llm -m claude-3.5-sonnet 'extract text from this' -a https://static.simonwillison.net/static/2024/pelican.jpg
There is no text visible in this image. The image shows a brown pelican perched on rocks near what appears to be a marina or harbor, with a boat visible in the background. The pelican is backlit, creating a glowing effect around its head and neck feathers.
% llm -m claude-3.5-sonnet 'write a poem about this' -a https://static.simonwillison.net/static/2024/pelican.jpg
Here's a poem about this pelican:

"Marina Guardian"

Perched upon the rocky shore,
Gray feathers gleaming in morning light,
The pelican stands, watching o'er
The boats that bob in waters bright.

With regal pose and seasoned grace,
Its silhouette against the bay,
Nature's fisher takes its place,
As sentinel through the day.

That ancient beak, so long and strong,
Tells tales of dives and ocean feast,
While backlit plumes, where sunbeams throng,
Create a halo, beauty released.

At harbor's edge, twixt sea and land,
This coastal king maintains its post,
Among the rocks and shifting sand,
A quiet guardian of the coast.
% llm -c 'translate to spanish'
Here's the Spanish translation of the poem:

"Guardián de la Marina"

Posado en la orilla rocosa,
Plumas grises brillando al amanecer,
El pelícano vigila majestuoso
Los barcos que flotan al aparecer.

Con pose real y gracia curtida,
Su silueta contra la bahía,
Pescador natural toma su guarida,
Como centinela durante el día.

Ese pico antiguo, largo y fuerte,
Cuenta historias de buceos y festín marino,
Mientras plumas a contraluz revierte,
Un halo de belleza en su destino.

Al borde del puerto, entre mar y tierra,
Este rey costero mantiene su lugar,
Entre rocas y arena que encierra,
Un guardián silencioso junto al mar.

Thanks for tracking this down. If you can push out a new version I would be grateful :)

Fix is out in 0.8 https://github.com/simonw/llm-claude-3/releases/tag/0.8


Unable to extract text from RTF

Thanks for the feature suggestion! It looks like there are several python modules that parse RTF documents with python; pyrtf-ng and pyth seem the most promising although its unclear how actively supported they are. There is also the option of parsing the text from the command line.
I unfortunately am not likely to have time to incorporate this feature any time soon, but if anyone else has bandwidth, here are some decent instructions on adding support for a new file type.

Thanks for the suggestion, @afrozekhan504. This will be incorporated in the next textract release, hopefully by the end of the week.

Great! Thank you for considering the suggestion and incorporating it @deanmalmgren.


new action summary print irrelevant data

https://github.com/NoMoosey/cluster-moose/actions/runs/2981719711
At the end of the report, there are lines with ">> Filename: null".
I suspect it's happening due to he use of --only-k8s-files flag.

happened because of the "--ignore-missing-schemas" flag. Fixed


The ModuleFederationPlugin does not support webpack_public_path_

Bug report

The ModuleFederationPlugin does not support webpack_public_path, and the generated remote-entry.js does not include webpack_require. p = webpack_public_path, but instead has a fixed webpack_require.p = publicPath

Thank you for creating this issue. However, issues need to follow one of our templates so that we can clearly understand your particular circumstances.
Please help us help you by recreating the issue using one of our templates.


Documentation: coreos-xhyve-run takes a URL to a cloud config

tell people how to use this feature and point to the docs.

handled by #27.


Add Troubleshooting page

Add a new page to the KLT docs for troubleshooting common problems.
To do this, create a new markdown file in this folder. Adjust the weight parameter so it appears at the correct spot on the menu (that is left up to the PR author to decide, but I suggest somewhere near the bottom of the menu).
Here are some we can start with:
KLT is installed but KLT isn't aware of my workloads

Ensure the namespace you wish to target is annotated correctly.
Ensure the workloads (eg. Deployment manifests) have the 3 required annotation

KLT is causing my pods to be pending
The most likely reason is that you have added a pre-evaluation task to your workload. The pre-evaluation task is either failing or hasn't completed yet.
It is intended behaviour that failing pre-evaluation tasks will prevent a pod being deployed.
Tasks are created as standard Kubernetes Jobs so look at the pod logs for those jobs. For example, if your application was deploying into the prod namespace:
kubectl -n prod get pods
kubectl -n prod logs job/...

I cannot see DORA metrics or OpenTelemetry traces
KLT will automatically generate DORA metrics and OTEL traces for every deployment, but by default it doesn't know where to send them. You need an OpenTelemetry collector installed and configured on the cluster.
The OpenTelemetry observability page contains more information on how to configure this.

@agardnerIT, I excited to work on this issue.


RN 0.59.10 - error while converting to cocoapods dependency in IOS

Bug
I have been using this library for over a year with dependency directly part of xcode project. Now we are changing to cocoapods due to a requirement of third party vendor library. I have tried the instructions for using this library with cocoa pods with RN 0.59.10 but none of them solved my issue. Also I have looked through the issue for similar issue but none of them solves my issue. Also currently I cannot migrate to RN 0.60.5 since one of our dependency has a need to use_frameworks from podFile which is not supported in RN 0.60.5. So am in the middle where we have deep dependency with react native device info library.
I get one of the following error

If my move my podfile out and do react-native link react-native-device-info, i get 'React/RCTUtils.h' file not found. Below is a screenshot of how this dependency is with respect to pod file

If I use the dependency through pod file by uncommenting the line from PodFile and then do pod install I get a run time error.

Environment info

React native info output:
 React Native Environment Info:
    System:
      OS: macOS 10.14.6
      CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
      Memory: 3.53 GB / 32.00 GB
      Shell: 3.2.57 - /bin/bash
    Binaries:
      Node: 11.10.1 - /usr/local/Cellar/node/11.10.1/bin/node
      Yarn: 1.13.0 - /usr/local/bin/yarn
      npm: 6.7.0 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
      Android SDK:
        API Levels: 22, 23, 25, 26, 27, 28
        Build Tools: 22.0.1, 23.0.1, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.1, 26.0.3, 27.0.3, 28.0.3
        System Images: a... | Intel x86 Atom_64, a...google_apis | Google APIs Intel x86 Atom Sys..., a...gle_apis | Google APIs Intel x86 Atom_64 ..., a...google_apis | Google APIs Intel x86 Atom Sys..., a...google_apis | Google APIs Intel x86 Atom Sys..., a...s_playstore | Google Play Intel x86 Atom Sys...
    IDEs:
      Android Studio: 3.4 AI-183.6<IP_ADDRESS>22156
      Xcode: 10.3/10G8 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.8.3 => 16.8.3
      react-native: 0.59.10 => 0.59.10
    npmGlobalPackages:
      create-react-native-app: 1.0.0
      react-native-cli: 2.0.1
      react-native-git-upgrade: 0.2.7
      react-native-rename: 2.2.2
      svg-to-react-native-cli: 0.0.3

Library version: "react-native-device-info": "^3.0.0"
PodFile
Uncomment the next line to define a global platform for your project
platform :ios, '10.0'
ignore all warnings from all pods
inhibit_all_warnings!
plugin 'cocoapods-art', :sources => [
'master',
'mobile-sdk-ios'
]
target 'MyProject' do
Comment the next line if you don't want to use dynamic frameworks
use_frameworks!
Your 'node_modules' directory is probably in the root of your project,
but if not, adjust the :path accordingly
pod 'React', :path => '../node_modules/react-native', :subspecs => [
'Core',
'CxxBridge', # Include this for RN >= 0.47
'DevSupport', # Include this to enable In-App Devmenu if RN >= 0.43
'RCTText',
'RCTNetwork',
'RCTWebSocket',
'RCTImage',
'RCTAnimation',
'RCTCameraRoll',
'RCTPushNotification',
'RCTActionSheet',
'RCTBlob',
'RCTGeolocation',
'RCTLinkingIOS',
'RCTSettings',
'RCTVibration'
]
Explicitly include Yoga if you are using RN >= 0.42.0
pod "yoga", :path => "../node_modules/react-native/ReactCommon/yoga"
Third party deps podspec link
pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'
pod 'react-native-fast-image', :podspec => '../node_modules/react-native-fast-image'
pod 'BVLinearGradient', :podspec => '../node_modules/react-native-linear-gradient'
pod 'RNVectorIcons', :podspec => '../node_modules/react-native-vector-icons'
pod 'react-native-video', :podspec => '../node_modules/react-native-video'
pod 'react-native-splash-screen', :podspec => '../node_modules/react-native-splash-screen'
pod 'RNSound', :podspec => '../node_modules/react-native-sound'
pod 'react-native-image-picker', :podspec => '../node_modules/react-native-image-picker'
pod 'ReactNativePermissions', :path => '../node_modules/react-native-permissions'
pod 'react-native-orientation-locker', :podspec => '../node_modules/react-native-orientation-locker'
pod 'lottie-ios', :podspec => '../node_modules/lottie-ios'
pod 'lottie-react-native', :podspec => '../node_modules/lottie-react-native'
pod 'BugsnagReactNative', :podspec => '../node_modules/bugsnag-react-native'
pod 'react-native-webview', :podspec => '../node_modules/react-native-webview'
pod 'RNCAsyncStorage', :path => '../node_modules/@react-native-community/async-storage'
pod 'react-native-uuid-generator', :path => '../node_modules/react-native-uuid-generator'
pod 'react-native-clear-app-cache', :path => '../node_modules/react-native-clear-app-cache'
pod 'RNCPushNotificationIOS', :path =><EMAIL_ADDRESS>pod 'SwiftLint'
pod 'react-native-bluetooth-status', :path => '../node_modules/react-native-bluetooth-status'
pod 'react-native-connectivity-status', :path => '../node_modules/react-native-connectivity-status'
pod 'RNDeviceInfo', :path => '../node_modules/react-native-device-info'
end
pre_install do |installer|
installer.analysis_result.specifications.each do |s|
s.swift_version = '5.0'
end
end
post_install do |installer|
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
config.build_settings['ENABLE_BITCODE'] = 'NO'
end
end
end

I don't know - if I were you I would move to the react-native 0.61 release candidates. they are getting close to being final (next week?), and it works with use_frameworks so you aren't in this mess. Requiring use_frameworks to work is basically a show-stopper that isn't going to work for you until 0.61

thanks @mikehardy little iffy going to rc version of react native for our production app. if rn 0.61.0 is close to getting release next week then its fine. I wasnt sure when the release dates were. Thanks for the update.

Well things can always change, and normally I would never recommend an RC except just to play around, but use_frameworks is a big deal - it is just broken in < 61. I guess worst case you can try it (really quickly - it's not a painful upgrade like 59->60, upgrade-helper site already has the RCs), and if that doesn't just untangle everything for you I can look more closely

Oh - and also worth noting that I never used a Podfile for react-native-device-info with RN0.59, if you determine that version is better for your needs, then focus on getting the link to work while your Podfile is out of the way (move Podfile, link, move Podfile back)

I've just got the RN59 script working again, it shows that it is possible and for older versions that's the most time I've got available for support, I do hope it helps


Restart on qemu.conf change

It seems like reloading libvirtd when a change is done in qemu.conf is
not enough.
When changing the libvirt_qemu_user setting the reload does not make the
change effective.
Tested on libvirt 3.0.0

Thanks a lot!


feature: add Dart config

I added dart config that based on Julia's config

Thanks for the contribution!


Sync versions.props in project folders

Proposal, for review only
https://github.com/SteeltoeOSS/Samples/issues/136

Thanks for getting this work started @korser1.
Rather than a collection of versions.props files that need to be imported into every single project file, I think we should eliminate the need for project file updates by using a convention that is recognized by MSBuild - Directory.Build.props should work now, or else Directory.Packages.props may work now but could be an even better solution at some point.
The other portion of the issue, which you have taken a stab at is updating of the .props copies. I suppose a brute force process/script that duplicates a root properties file into any folder that contains a .sln should work, but it would be more elegant if we selectively updated versions and had targeted version properties so the files themselves could be smaller... but that could also be done in the future if the brute force process causes issues so I think I'm ok with the current approach

Thanks for getting this work started @korser1.
Rather than a collection of versions.props files that need to be imported into every single project file, I think we should eliminate the need for project file updates by using a convention that is recognized by MSBuild - Directory.Build.props should work now, or else Directory.Packages.props may work now but could be an even better solution at some point.
The other portion of the issue, which you have taken a stab at is updating of the .props copies. I suppose a brute force process/script that duplicates a root properties file into any folder that contains a .sln should work, but it would be more elegant if we selectively updated versions and had targeted version properties so the files themselves could be smaller... but that could also be done in the future if the brute force process causes issues so I think I'm ok with the current approach

@Tim, thank you for your reply.
I looked into Directory.Build.props, but decided no to touch them, as this file could be introduced inside the specific project and sync script will override it. Ok, will try to replace versions.props
Regarding the packages props, I agree with you, but the feature is in the review, And should see how it will work with Dockerfile with accessing, for example.

Looks good. I've requested some mods to the copy_props.ps1 script. Specifics in it's feedback.

rename to configure.ps
convert comments to help comments
(optional) make script executable on Linux

Done


Script for loading data from S3/Azure blob storage into Kafka topic for Druid indexing

Creating new PR from the forked branch hence closing this pull request.


Optional secondary node

Related to https://github.com/CartoDB/cartodb/issues/12018
In this PR I've made two changes:

Know if a node parameter of an analysis is optional. In this case, we don't follow the existing workflow. Prior to this SQL ticket there were no optional nodes.

In model-updater we were swallowing error of analysis that didn't get even instantiated. The change check if the error has been set to the layer or analysis. If not, it gets bubbled to a visualization error.  This is related to this comment

Please @alonsogarciapablo take a look on this code to validate that it's the right way to tackle this two issues.

retest this please

Just beware that this issue should be merged just before https://github.com/CartoDB/cartodb/issues/12018

Shouldn't we merge this one? @ivanmalagon

I'd wait until the acceptance of the mother issue is done. Then, both repos will be merged and deployed.

Hey mates, we need this PR in order to have the SQL function analysis in master. Not sure if the issue in camshaft will be fixed soon. Could we go on with this solution and then get back to the previous state when it is done?

cc @jorgesancha


datetime behavior when Day portion is deleted

I'm trying to use v4.0.8 to reproduce the behavior in this fiddle which uses 3.3.4 for a mm/dd/yyyy datetime mask: https://jsfiddle.net/cr15tL3q/2/
If we enter 01/01/2000 and the delete the Day portion, the input displays 01/dd/2000.
Using 4.0.8 with almost the same code and deleting the Day, the input displays 01/20/00yy.
https://jsfiddle.net/cr15tL3q/3/
This behavior is also seen on your Demo page.
I thought shiftPositions: false would address the shifting, how else can I adjust my code to keep the digit positions and get the desired behavior when deleting?

@DanTosto ,
See #2163


Using Tiberius with named pipes

Mio 0.7 has support for Windows named pipes. The author of mysql_async (blackbeam) is having a PR open to Tokio to support them in the runtime.
I wrote a small example, trying them out with Tiberius, and they actually work!
When the support lands to Tokio, we should update our documentation to reflect these changes.
https://github.com/prisma/tiberius/pull/132

Named pipes were merged to tokio via https://github.com/tokio-rs/tokio/pull/3760


Update get_ functions to all raise a ValueError when no data can be found / too much data is found

Update get_ functions to all raise a ValueError when no data can be found / too much data is found
- If no data is found, make sure this (and keywords asked for) is clear (could include search command details here to assist?)
- If > 1 set of data is found and ranking IS NOT present / used, print message to suggest adding ranking or being more specific
- If > 1 set of data is found and ranking IS present / used, print message to suggest improving ranking details

May want to change this so they all return ValueError like get_obs_surface - if taking the "programmatic approach" to the get functions versus the search and retrieve steps

Updating the name for this to reverse original decision to make this return None based on more recent updates.

Will need to update ModelScenario to catch these errors when they occur and print details from the error, as this can continue even if this fails


Understand Monitoring Plan Data

Open in MURAL
Emissioners PI Board - EPA CAMD Business Suite - ECMPS and AMPD

All work completed


NO-TICK: Store new finality signatures in the storage.

As part of the work on NDRS-833 I've noticed that we don't store new finality signatures in the persistent storage. This PR fixes that problem.

bors merge


Efficency question

I had a similar system with Neznamy's tablist named TAB-BukkitBridge
the problem with a system that uses plugin messages to request placeholders is a huge traffic on the player channel.
For example: a player entry needs 4 placeholders. those placeholders are updated every 0.5 seconds.
assuming that you have 400 players (which isn't that many), you'll have 4*2*400=3200 requests per second and plugin messages will occupy a large portion of the traffic.
i am proposing a different approach:
since the requested placeholder identifiers are always the same 4 for every player, you only need to notify bukkit a single time to "subscribe" the placeholder value. if the placeholder value changes, the "bukkit bridge" will provide the updated value

As per discussion, closed through the impl of an expiring map cache


WINNF.FT.C.SCS.2 - CRL distribution issue

Hi sir,
Is the URL of CRL distribution point of "http://testharness.cbsd.winnf.com/crlserver.crl" available for WINNF.FT.C.SCS.2 testing?
I have tried and found that the UUT cannot get the CRL list from this URL. It seems invalid and not accessible.
Thank you in advance.

Hi,
For this test, the URL is intended to point to a local CRL or OCSP server set up by the test lab.  This also requires a local DNS server to associate the URL with the local server address.
More information is available in the WINNF CBSD/DP UUT Security Test Cases Tutorial, at:
http://www.wirelessinnovation.org/assets/winnf-in-00129-winnforum_cbsd_dp_uut_security_test_cases_tutorial_v_1_0_0_0.pdf


Unable to buy consumable product getting crashed

flutter_inapp_purchase: ^5.4.1
Android
Should buy inAppProduct
No Purchase Prompt
T Real Device
Steps to reproduce the behavior
Add any InApp Product, and getProducts, the select any one product getting below Error.
E/flutter ( 7319): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: PlatformException(InappPurchasePlugin, buyItemByType, null, null)
E/flutter ( 7319): #0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:653:7)
E/flutter ( 7319): #1      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:315:18)
E/flutter ( 7319):
E/flutter ( 7319): #2      FlutterInappPurchase.requestPurchase (package:flutter_inapp_purchase/flutter_inapp_purchase.dart:278:14)
E/flutter ( 7319):

I've experienced the same problem. Is there any solution?

I have the same problem!

I was using "flutter_inapp_purchase: ^5.0.2". Can you please change it with "flutter_inapp_purchase: 5.3.0" and try again? Please don't forget to remove "^".

This seems to be the same issue: https://github.com/dooboolab-community/flutter_inapp_purchase/issues/430
Unforunately it was closed. The posted workaround from @mdusaama0 worked for me.

Just preventing the issue from closing. Products in the last version 5.4.2 are still unusable on android.


Enable package.json updates for Dependabot

We think Dependabot is only making package-lock.json changes rather than package.json increases
For example:
https://github.com/alphagov/govuk-frontend/pull/2990 – Updating @percy/sdk-utils (child dependency) instead of @percy/cli
https://github.com/alphagov/govuk-frontend/pull/2973 – Updating jest-runtime (child dependency) instead of jest
This PR adds to the dependabot.yml config:
- package-ecosystem: npm
  versioning-strategy: increase

Related versioning-strategy documentation:
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#versioning-strategy

Related: https://github.com/apache/superset/pull/20920

I'm happy to give this a go, but is this not the default behaviour anyway? (npm increases stuff by default)

We install using npm ci in the workflows (installs exactly from package-lock.json) so won't get increases. Keeps things reproducible and easy to cache between workflow jobs.
It looks like for (mostly) npm update behaviour, with updates not written to package.json we'd want:
- package-ecosystem: npm
  versioning-strategy: increase-if-necessary

But I know we like to see updates show up in package.json so I picked the "always increase" option:
- package-ecosystem: npm
  versioning-strategy: increase

Looking at that linked PR, seems like something/anything could be interfering with dear old Dependabot here, so I'm going to approve and hopefully this'll force the package.json updates.

Yep, see what happens, and tweak again 😬


support routeProcess plugins defined in external npm modules

🧩 Feature request
Description
I would like to propose adding support for external routeProcess plugins. It would be great if their order of execution could be defined in Scully's config file.
Describe the solution you'd like
Currently the documentation for routeProcess plugins says: "There is no need to update the config file for this." But I think it is necessary to import those plugins. Otherwise Scully can't know that there is a routeProcess plugin somewhere in the node_modules folder. I think the following should work to make Scully aware of an external routeProcess plugin.
// scully.config.js
import 'my-external-route-process-plugin';

However, I think the developer experience could be improved a little. Currently the priority of routeProcess plugins is defined when registering the plugin. Since the plugin could be defined in an external node module which could have been developed by someone else it's not immediately clear by looking at Scully's config file which plugin will run first.
Once the order has been figured out by looking up all registerPlugin() calls there is no way for a Scully user to change the order if the plugins have been developed by someone else.
If I'm not mistaken routeProcess plugins are the only plugins which can be prioritized like this. All other plugins seem to be executed in the same order in which they appear in the config file.
Therefore I would like to propose adding a new entry to the config file for configuring route process plugins. It could look somehow like this:
// scully.config.js
import { myExternalRouteProcessPlugin } from  'my-external-route-process-plugin';
import { anotherExternalRouteProcessPlugin } from  'another-external-route-process-plugin';

export const config = {
    routeProcessPlugins: [myExternalRouteProcessPlugin, anotherExternalRouteProcessPlugin]
};

This new routeProcessPlugins entry would work similar as the defaultPostRenderers entry. It would allow the users of Scully to define routeProcess plugins and to re-order them as it works best for their use case. And I think it would also bring the behavior of routeProcessPlugins more inline with all other types of plugins.
Describe alternatives you've considered
As mentioned above it's currently possible to import an external routeProcess plugin with a "side-effects" import statement. However re-defining their priority is not possible so far.

What is the added value to this? You can already as many as you like. The 4rth parameter of registerplugin is a number. That number sets the order.

@SanderElias the value would be that PersonA could make a plugin and deploy it. In their NPM package they call the registerPlugin function and register it with the 4th param.
Then PersonB comes a long and they can use that person's plugin and set their own priority instead of just getting the priority of the person who built it.

I think @SanderElias is right. It's a theoretic problem so far. I only discovered this since I was implementing route process plugin support for angular-prerender. I don't have an actual use case where this would be a problem.
However if you want this to be changed before any user runs into the problem I would be happy to provide a PR. Although I'm not quite sure how to implement this in a backwards compatible way. Maybe each route process plugin that gets registered but isn't listed in the config file could log a warning for now.

@chrisguttandin I think the best way would be to enable a way to change the registration number. The actual sort happens just before they are executed.
So a setPluginPriotity function would do the trick. There is a symbol for the priority attached to the plugin.
something as:
const plugin = findPlugin('myPluginName')
plugin[routeProcessPriority]=newNumber

Would do the trick.
We might need to add the export for routeProcessPriority
I would welcome a PR for this.

@SanderElias I created a basic PR (#1329) but I wasn't sure where to put a test for the new function. Please let me know if I should add a test and where to put it.
And please let me know if there is anything else I need to change.

@chrisguttandin Thanks!
A test would be welcome. It should be added to our jest tests in ./tests/jest/src/__tests__
Just a no-fuss test would be ok, and checking the error if you try to set an unexisting one should be enough.
registerPlugin('routeProcess','one', async (x) => x, 100);
registerPlugin('routeProcess','two', async (x) => x, 200)
// some actual testing goes here.

This is done and merged


[axios] add new extractor

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[x] New extractor
[ ] New feature

Description of your pull request and other information

Add new site support for https://github.com/ytdl-org/youtube-dl/issues/24452

Read tutorial and coding conventions.


Fixes to Artik 530 and 533 getting started

Change-type: patch

Seem's to be failing because of CircleCI's current npm problems? https://status.circleci.com/

@lurch yep, that was definitely the issue. All cleared up now, thank goodness


Search option

It would be nice to search talks (title and description) and/or speakers (name and description).

I'm working on the Search feature for Android, and there are a few UI considerations to be done.

I have moved the avatar to the left side, to keep the search button on the top-right (as most apps).
The first version will use a default text field but we may want a nicer one as an improvement - there is no Search component on compose yet, so we will need to build our own.

Can you confirm these two points are OK? cc: @joreilly @martinbonnin

Search Collapsed
Search Expanded
Filter

Looks very good to me! Thinking a bit about filters, would we put them in a right drawer?
My current idea of filters is this (from the Android Makers app):

@martinbonnin sounds good. We can also use a bottom sheet instead of a right drawer.
I don't think having two icons side by side will cluster the UI but if it does, we can explore a few alternatives:

Move search to its own tab, which is a dedicated screen that consolidates both sessions and speakers;
Place search as the first item in the list and/or on the top bar fixed (I think iOS does something like that?);

I guess we can talk about that once we have both features together. 😄

@martinbonnin @joreilly an alternative layout, which is more friendly to filter can be:

Should it be its own destination in the bottom bar like in the ~Twitter~ Mastodon app for an example? That would allow to return results in all days (which I don't think is the case right now?)

search => all conference data => separate bottom bar item
filters => only for the current view => bottom sheet or right drawer

?

@martinbonnin that would be nice but ideally should aggregate all information (both sessions and speakers), not sure how hard would it be to do it with GraphQL.
I have submitted a CL with general improvements + a new UX, but I can revert the UX if needed (not super convinced).
See #428

I have reverted the new Search UX, we can discuss it separately and if needed I can submit it (I have created a new branch with it).
Here is an example:

@martinbonnin that would be nice but ideally should aggregate all information (both sessions and speakers), not sure how hard would it be to do it with GraphQL.

We download all the conference data at first launch and then use WorkManager to refresh it in the background so it should be all there (and it's not that big. Fosdem is the biggest and it's way under 1MB IIRC).
So I don't think having instant search with suggestions/autocomplete over the network is a great use case for GraphQL (although I'd be curious to explore). But I think we can get something fairly decent by searching the local data.


ignore abstruct_class from table#show

https://github.com/esminc/adhoq/pull/70#discussion_r38904370

Thanks for your PR!


feat: stabilize auto fix note

A note that some warnings could be fixed by running a cargo fix command was added in #10989 and made to work with clippy in #11399. It has only been turned on for nightly builds so far; this PR would make it show on stable.
The original motivation for making this note nightly only, was to allow for iteration on the message output. There has yet to be any feedback on the message format in the time that it has been on nightly. This was brought up in a recent cargo team meeting and it was thought that we should move forward with showing this on stable.
close #10976

A passing reference to this was made by Amos at https://fasterthanli.me/series/updating-fasterthanli-me-for-2022/part-1

This suggestion is machine-applicable, which means running "cargo fix" (or accepting the suggestion from your code editor) will fix it automatically. Not only does it make the code simpler (one less byte, yes!), it also means less work for the compiler to do, hence, faster compiles.

@rfcbot fcp merge
Example output
warning: `foo` (lib) generated 1 warning (run `cargo fix --lib -p foo` to apply 1 suggestion)
warning: `foo` (lib test) generated 1 warning (1 duplicate)

From last time, our open questions were

Should the message stay in the summary line or be on its own line?

The summary line can be very long with the current implementation

Should the command be specific or genera?
Should the command to run be per target or shown once at the end?
Should version control specific flags be added to the command to run?

but not having seen any talk of this feature, we have no way to progress without just stablizing it and refining it from there (or reverting this PR).

@bors r=epage

:pushpin: Commit 6131222ba2a0785217521308c5f9b302d98b0e7e has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 6131222ba2a0785217521308c5f9b302d98b0e7e with merge 6c095cce88dc4661e4c39f12080930cf8fcf5b6b...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 6c095cce88dc4661e4c39f12080930cf8fcf5b6b to master...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 6c095cce88dc4661e4c39f12080930cf8fcf5b6b to master...


VPS Notifications

Add a separate notification about new tables, filtered by type.

Initial attempt implemented in 2.5.0, continued with persistend state in 2.6.0


Remove 'fireable' service and facade as it's not being used.

Refer to #15
Signed-off-by: Mior Muhammad Zaki<EMAIL_ADDRESS>

Thanks!


Dashing no longer marked active (EOL)

Dashing no longer marked active in the releases overview due to Dashing EOL.
Don't know how to remove it from the https://docs.ros.org/ landing page though. That is, removing it from the "Active ROS 2 distributions" at the top and adding it to the "End-of-life ROS 2 distributions" at the bottom.
Signed-off-by: Nordmann Arne (CR/ADT3<EMAIL_ADDRESS>

@nuclearsandwich FYI

Dashing no longer marked active in the releases overview due to Dashing EOL.

We aren't quite there, as the final sync hasn't happened: https://discourse.ros.org/t/preparing-for-final-dashing-sync-and-patch-release/20524/4.  Once the final sync happens, we can merge this.

Don't know how to remove it from the https://docs.ros.org/ landing page though. That is, removing it from the "Active ROS 2 distributions" at the top and adding it to the "End-of-life ROS 2 distributions" at the bottom.

That's a hand-written page for now.  Once Dashing goes EOL, I'll move it.

That's a hand-written page for now. Once Dashing goes EOL, I'll move it.

@clalancette you've got the green light to update the page when you're ready.

@clalancette you've got the green light to update the page when you're ready.

Updated now.


Fix documentation

Closes https://github.com/huggingface/optimum/issues/379

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Installation files

Basically you open the folder than click on the files and it installs all the stuff you need for this engine besides Haxe itself.

Now THIS is pretty cool, but is there a way to make sure these commands are run in the intended order? I dunno what'd happen if  someone doesn't happen to open the README, which hasn't been changed in this PR.

Now THIS is pretty cool, but is there a way to make sure these commands are run in the intended order? I dunno what'd happen if someone doesn't happen to open the README, which hasn't been changed in this PR.

I'll most likely number them with the name

Now THIS is pretty cool, but is there a way to make sure these commands are run in the intended order? I dunno what'd happen if someone doesn't happen to open the README, which hasn't been changed in this PR.

Ok I numbered them. 1), 2), and 3)

Referen

Seems very user friendly, especially compared to copy-pasting commands into cmd.

That was what I was thinking when putting it together. "it's way easier to use than copy and pasting each individual commands"


GROOVY-5103: allow plain star imports to pick up static inner types

https://issues.apache.org/jira/browse/GROOVY-5103

Java allows "import foo.Bar.*" to resolve "Baz" to "foo.Bar$Baz"

Note: This is also a compatibility/transparency issue for Eclipse Groovy Development Tools, which has supported star imports that resolve inner types for years.

Checking star imports for type reference is limited to "real" star imports (those present in the source text) to prevent trying to resolve "java.lang", "java.util", etc. for every single ModuleNode.  Type resolution also enables display of Javadoc information for the imported type:

This seems okay. It doesn't seem to break the existing import of static classes using "import static", which while possibly unexpected from a Java point-of-view, we have supported for a long time. I'll note that your patch doesn't extend to another "exotic" case we currently support.
import java.util.Map as SomeMap
import static SomeMap.Entry as SomeEntry

assert SomeEntry instanceof Class

works but not without the static. It is also somewhat unusual but accounts for aliases to some degree and we have supported it for along time too. We can cover that off separately.

Merged, thanks.

... your patch doesn't extend to another "exotic" case we currently support.
import java.util.Map as SomeMap
import static SomeMap.Entry as SomeEntry

assert SomeEntry instanceof Class

works but not without the static. It is also somewhat unusual but accounts for aliases to some degree and we have supported it for along time too. We can cover that off separately.

If you wanted to shut down this "exotic" behavior, you could change this bit:
    public void visitClass(final ClassNode node) {
        ...
            for (ImportNode importNode : module.getStaticImports().values()) {
                ClassNode type = importNode.getType();
                if (resolve(type, true, true, true)) continue; // set flags to "false, false, true" to not use other imports to help resolve this import
                addError("unable to resolve class " + type.getName(), type);
            }

Just an option to consider.  I don't think anyone coming into the language is expecting one import to influence another.

Not planning to shut it down at this stage. I have had numerous folks (albeit quite a few years ago now) who've come up to me at conferences and expressed their like for that feature and how it made it easier for DSLs and various porting scenarios.


Fix issues in the exam mode test runs

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Server: I followed the coding and design guidelines.
[x] Server: I implemented the changes with a good performance and prevented too many database calls
[x] Server: I documented the Java code using JavaDoc style.
[x] Client: I followed the coding and design guidelines.
[x] Client: I added multiple screenshots/screencasts of my UI changes
[x] Client: I translated all the newly inserted strings into German and English

Motivation and Context
We had a recurring issue where the user object sent from the client was stored on the database on a cascade operation.
Description

Remove the cascade.Merge on Result.assessor.
Filter out the results from the submissions of student exams during conduction
Add a test_run flag for participations, adapt the isTestRunParticipation helper method. (In follow up PRs we will only use this flag to identify test run participations and their submissions)
Mark the test run submissions AFTER the instructor submits the test run & evaluate the quiz submission, instead of before.
Warn the instructor to delete the test runs before the conduction.
In case the instructor forgets to delete the testruns, delete all test runs automatically once the instructor assesses all unsubmitted exams.
Do not show second correction table for test runs (only the owner of the test runs can assess the submission once & override it)

Steps for Testing

Create an exam with all exercise types

Participate in test runs  and submit. IMPORTANT: wait for the build result to return from bamboo!

Make sure that the submissions don't appear in the assessment dashboard

Assess the test run submissions

Add complaints to the test run submissions

Review the complaints

View the summary page of the test run, make sure that the results appear correctly.

Make sure that the test runs don't appear in the exam scores

Start a test run and do not submit

Participate in the exam as a student

Assess all unsubmitted exams (button in the student exams tab)

Verify that all test runs are deleted.

Assess the exam submissions

Override with an instructor account

Complain about the submissions

Review complaints

view scores

Test Coverage
StudentExamService 90%
ExamService 91%
ParticipationService 72% -> After a followup rework of identifying test run participations will increase to > 80%
Screenshots

@airelawaleria @marvinchimeka @JohannesWeiss Thank you for testing.

This is unrelated to this PR
Good catch, I fixed it!
This is expected behavior for now, because we add results to identify test run submissions. In a followup PR we will fix this

@airelawaleria @marvinchimeka @JohannesWeiss Thank you for testing.

This is unrelated to this PR
Good catch, I fixed it!
This is expected behavior for now, because we add results to identify test run submissions. In a followup PR we will fix this

Screenshot from the testing session:

Screenshot from the testing session:

We found a bug during the testing session. When trying to click "assess unsubmitted student exams" an error 500 is thrown

This is now fixed in: f78524c

We found a bug during the testing session. When trying to click "assess unsubmitted student exams" an error 500 is thrown

This is now fixed in: f78524c

Screenshot from the testing session:

This is now fixed in: 2b04dfb

Screenshot from the testing session:

This is now fixed in: 2b04dfb

During the testing session, we found the following bug: Within a exam test-run programming exercise submitting before receiving an automatic result from bamboo, the manual assessment of the test-run programming exercise is not possible, because the result is missing.

We discussed this with @krusche and decided that we will cover this edge case in a follow up, with the refactoring of the test runs.

During the testing session, we found the following bug: Within a exam test-run programming exercise submitting before receiving an automatic result from bamboo, the manual assessment of the test-run programming exercise is not possible, because the result is missing.

We discussed this with @krusche and decided that we will cover this edge case in a follow up, with the refactoring of the test runs.

Thanks for testing, I could not reproduce this issue.
Can you give me some more details? Is this only for test runs?
If it was for the exam, did you active the student review period? (you have to add the start and end date of the review period to unlock the complaint button)

Thanks for testing, I could not reproduce this issue.
Can you give me some more details? Is this only for test runs?
If it was for the exam, did you active the student review period? (you have to add the start and end date of the review period to unlock the complaint button)

@JohannesWeiss do you have to console output of the bad request? Or the name of the call that is causing it?

@JohannesWeiss do you have to console output of the bad request? Or the name of the call that is causing it?

When evaluating complaints, there are no button to accept/reject the complaint, the complaint text and the submission itself are missing.
Also see what @JohannesWeiss said below about submission of complaints and bad request.

P.S. the previous bug with editing the submission after the test run is resolved

Culd you please list how you accessed this screen? From the screenshot I can see that there is no assessor set, which should not happen for test runs

When evaluating complaints, there are no button to accept/reject the complaint, the complaint text and the submission itself are missing.
Also see what @JohannesWeiss said below about submission of complaints and bad request.

P.S. the previous bug with editing the submission after the test run is resolved

Culd you please list how you accessed this screen? From the screenshot I can see that there is no assessor set, which should not happen for test runs

@JohannesWeiss do you have to console output of the bad request? Or the name of the call that is causing it?

The console output was a HTTP 400 error. After changing the student review period and testing again, the call worked. It seems, that this was the problem. The complaint button was active before setting that period, though.

@JohannesWeiss do you have to console output of the bad request? Or the name of the call that is causing it?

The console output was a HTTP 400 error. After changing the student review period and testing again, the call worked. It seems, that this was the problem. The complaint button was active before setting that period, though.


Skip remainingTerm subtest that fails intermittently

Adds an error margin to fix #464.

Seminal error indeed; thanks for the midair adjustment :)