ocamlPackages.frontc: 3.4 -> 3.4.1

Motivation for this change
Compatibility with OCaml ≥ 4.06.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build libbap

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: libbap
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Timed out, unknown build status on x86_64-darwin (full log)
Attempted: libbap
Partial log (click to expand)
[ 55%] Updating X86GenDAGISel.inc...
[ 55%] Building X86GenFastISel.inc...
[ 55%] Updating X86GenFastISel.inc...
[ 55%] Building X86GenCallingConv.inc...
[ 55%] Updating X86GenCallingConv.inc...
[ 55%] Building X86GenSubtargetInfo.inc...
building of '/nix/store/68ks2xi46agjxg5cs5z0rhl5y7qa84js-llvm-3.8.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/rm1wcgijmk0n1n4kxyp1v4xm30lfk0v6-ocaml4.05.0-bap-1.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/8g8qf227kfz35k4hh70bn0y0c8sdw0q8-libbap-master-2018-03-01.drv': 1 dependencies couldn't be built
error: build of '/nix/store/8g8qf227kfz35k4hh70bn0y0c8sdw0q8-libbap-master-2018-03-01.drv' failed


Allow global write access to 'storage_path'

fixes #229

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jaywcarman
To complete the pull request process, please assign yussufsh after the PR has been reviewed.
You can assign the PR to them by writing /assign @yussufsh in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @jaywcarman! It looks like this is your first PR to ocp-power-automation/ocp4-upi-powervs 🎉

Hi @jaywcarman. Thanks for your PR.
I'm waiting for a ocp-power-automation member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I'm wondering why we didn't face it earlier.
@yussufsh @Prajyot-Parab any ideas ?

I've seen the problem described in #229 several times, but not every time I provision. I haven't figured out the underlying issue, but believe this patch is an effective fix.
Perhaps this is a clue: when the permissions are not correct I've noticed that root still owns /export. Here's an example, after I've already run chmod 777 /export:
~ > ssh acm-spoke-47.mon01.ibm-power-acm.com 'ls -ld /export'
drwxrwxrwx. 4 root root 4096 Apr 24 12:48 /export

But normally /export is owned by nobody. Here's an example of a bastion that did not have any problems:
~ > ssh acm-spoke-48.mon01.ibm-power-acm.com 'ls -ld /export'
drwxrwxrwx. 4 nobody nobody 4096 Apr 21 22:56 /export
~ > grep "^nobody" /etc/passwd
nobody:x:65534:65534:Kernel Overflow User:/:/sbin/nologin

Does the automation chown /export somewhere? If so that might be a good place to look.

Does the automation chown /export somewhere? If so that might be a good place to look.

This should be handled by the helpernode playbook. I see there is already a task to change it to 777 and nobody:nobody.

@yussufsh is this the task you're looking at?
https://github.com/RedHatOfficial/ocp4-helpernode/blob/master/tasks/main.yml#L173-L181
I don't think ocp4-upi-powervs logs any Ansible output does it? I can turn that on and see if I can capture output from this playbook when root still owns /export.

This is fixed in the latest code.


Trimming a submap in the middle

This is a necessary work to replace an outdated submap with a newly generated submap that covers the same area. With this feature, I think cartographer can actually do the lifelong mapping over time. I would like to open a discussion to start the development.
I think we can break this down into two separate problems, trimming trajectory nodes and trimming a submap.
Submap trimming seems relatively easy. All we have to do is changing vector to vector just as in cartographer_rviz (and of course some following works).
Trimming trajectory nodes seems to need a design decision(or discussion) to decide how cartographer keeps the separated trajectories. Should cartographer keep the separated trajectories in the nested map structure? should it keep the entire trajectory without trimming until no constraint references this trajectory? Or any other options?
How do you think?

We thought that this should be modeled by

Split trajectory.

Trim one of the from the beginning.

is done, 1) should be relatively simple (famous last words).

If you trim nodes in the middle you have an awkward trajectory with missing data and non-even timestamp increases.

Alright. I will try to split trajectory.

I was trying to review #425, but I think we need some discussion first how we approach trimming in the middle. How I see it, there are a couple of things that matter:

we label data presented to the user with pairs of trajectory ID and node index (e.g. in RViz) where it is useful to look at individual trajectories (similarly we use ID/index pairs for submaps)
we also use these ID pairs to label input data, i.e. to tell the SLAM system which trajectory builder some data is for
we need to be able to trim arbitrary nodes and submaps for life-long mapping, and this should be efficient
the internal representation of the pose graph is an implementation detail, therefore it does not have to use ID/index pairs

I see two very different general approaches to implement trimming in the middle:

Change the so called "trajectory IDs" to only identify where data came from and allow "trajectories" to contain holes. "Trajectories" with holes are no longer a single trajectory. We must detect and handle these gaps in node indices, e.g. in RViz and SLAM. By construction this maintains labels, e.g. in RViz it is easy for users to understand what is happening. In this case, the data structures for nodes/submaps could be changed from std::vector<std::deque<..>> to std::vector<std::map<int,...>>`.
The pose graph becomes just a graph structure which does not contain labels, for input we keep track of then end of each trajectory so trajectory builders can attach new nodes/submaps. Whenever we present data to the user, we label data. For stability, e.g. in RViz, we might also keep some additional data for that purpose. Most importantly, when a trajectory is split no relabeling happens, i.e. removing every other node does not become O(n^2).

1 seems preferable to me. What do you think? Interesting alternative approaches I forgot?

I agree with your point that “cartographer should be able to trim arbitrary nodes and submaps for life-long mapping”.

Change the so called "trajectory IDs" to only identify where data came from and allow "trajectories" to contain holes. "Trajectories" with holes are no longer a single trajectory. We must detect and handle these gaps in node indices, e.g. in RViz and SLAM. By construction this maintains labels, e.g. in RViz it is easy for users to understand what is happening. In this case, the data structures for nodes/submaps could be changed from std::vector<std::deque<..>> to std::vector<std::map<int,...>>.

I actually have an experimental branch that I attempted to redesign the sparse pose graph to allow arbitrary submap and nodes trimming. See spare_pose_graph.cc and pose_grapher_trimmer.cc in better_trimmer branch. I changed the data structure of submap to std::vector<map> and separated MarkSubmapAsTrimmed into two functions to handle submap trimming and node trimming independently to allow a trimmer to have more control to determine which submaps and which nodes to trim.
To manage the gaps created by trimmed trajectory nodes, one of my idea was introducing std::vector<std::map<int, std::vector<TrajectoryNode>>> to keep split trajectory separately within the same trajectory id. Or, we can simply introduce a logic in optimization_problem.cc to detect and handle the gaps created by trimmed trajectory nodes.
I decided not to continue in this direction after @Sirver’s comment because it seemed to introduce a major data structure change which you may not like. If you consider this direction is worth to discuss, we can continue further.

The pose graph becomes just a graph structure which does not contain labels, for input we keep track of then end of each trajectory so trajectory builders can attach new nodes/submaps. Whenever we present data to the user, we label data. For stability, e.g. in RViz, we might also keep some additional data for that purpose. Most importantly, when a trajectory is split no relabeling happens, i.e. removing every other node does not become O(n^2).

One of limiting factor of the current data representation is that cartographer uses ID pair(trajectory id, index) as a unique identifier for both submaps and trajectory nodes. If we introduce another way of a unique identifier for each submaps and trajectory nodes, relabelling will not happen.
Option 1 seems relatively easy to do. So, I would also prefer option1 unless option 2 has significant benefit. Shall I revive #422 ? :)
About #425, I think it is still a valid approach regardless of this discussion. Sparse pose graph uses trajectory id as an important unique identifier to maintain its internal data structure, and map builder and trajectory builders use this trajectory id just to feed sparse pose graph. So, I think the trajectory id creation should be done within sparse pose graph since trajectory id is designed for sparse pose graph. Also, there might be a use case that having multiple map builders that share one sparse pose graph?

Your experimental branch seems to contain multiple changes. Let's focus on getting the data structure right first, and let's start with submaps first. As I see it this would also mean removing the num_trimmed_submaps which are no longer needed as this data is included in the map<int, ...>.
Regarding the std::vector<std::map<int, std::vector<TrajectoryNode>>>, I think you cannot make this efficient. It can happen that you have to split the innermost std::vector<> many times leading to quadratic behavior. Logic to detect and handle the gaps is a better idea in my opinion.
#422: Yes, but it should probably remove the num_trimmed_submaps at the same time.
Re #425: IDs are used to get input data into the sparse pose graph. I do not think the sparse pose graph should have control over these IDs.

I have tried MarkSubmapAsTrimmed in the latest code #462. It worked just fine when I removed several Finished submaps. I am planning to insert the Trimmed stuff (submap, constraints, Node) later to see the outcome.

well, trimming still needs to operate in orders, rather than from middle....I will try your solution @jihoonl

I planned to dynamically paging submaps and trajectory data between memory and disk. However, this would require the triming of arbitrary submaps and further restoring the once trimmed submaps. Now triming arbitrary submaps seems already a headache problem... I am not sure whether splitting trajectory would work in my case.

Is it possible by adding a flag in the submap struct, and then trimming the probability grids of submaps with certain flag instead? The trajectory will not be broken.

I think this issue is resolved via #472, #422


[Style] Make Trigonometric Calculator responsive

Description
In mobile view some fields are not visible i would like to fix it
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@Rakesh9100 completed all the previous issues please assign this to me

Go ahead @agastya3636


APN Update notification

Hi!
I'm having a problem with apple push notifications, if i send two or more notifications, this is accumulate in the device, its possible to have only one notification on device and if i send another one, update this? (like android does with "notId").
Thanks!!

This is not something that Remote notifications will handle for you automatically.
You may be able to achieve the same effect by using UILocalNotification from within your app. Send your push notification with all the information you need within the payload, but not in the alert property and with the content-available flag set. This should then load your app in the background. At this point you will receive the payload and can construct a UILocalNotification to appear with the payload information.
The next time this happens you can clear any local notifications which will hide them if they are currently being shown.

Thanks! i will try ;)


Bug with attachment?

I tried to reply to a thread, typed a few letters, and clicked on the paperclip, and it submitted the few letters : https://firestorm-dogfood.herokuapp.com/categories/elixir/threads/6

This is yet-to-be-implemented. Hopefully this week. For now it's just a button so it submits the form...

Closing this issue in lieue of #12


E492: Not an editor command:  SyntaxInclude javascript

Slide 2
Is less important
this.is = 'code'

This happened on OSX Catalina


Vimeo Problems

Discussion 🗣
We seem to have lost access to our Vimeo account, see:

https://github.com/accordproject/techdocs/issues/327
https://github.com/accordproject/techdocs/issues/328
https://github.com/accordproject/techdocs/issues/329

Context
Vimeo is where we host all of our video content

@irmerk I believe this is resolved?

@irmerk I believe this is resolved?

Unsure, I'll look more into this because the links in those issues are still broken I believe.

Unsure, I'll look more into this because the links in those issues are still broken I believe.

Discussion 🗣
We seem to have lost access to our Vimeo account, see:

accordproject/techdocs#327
accordproject/techdocs#328
accordproject/techdocs#329

Context
Vimeo is where we host all of our video content

Discussion 🗣
We seem to have lost access to our Vimeo account, see:

accordproject/techdocs#327
accordproject/techdocs#328
accordproject/techdocs#329

Context
Vimeo is where we host all of our video content

Unsure, I'll look more into this because the links in those issues are still broken I believe.

Only the first link is a video and it works for me:

Unsure, I'll look more into this because the links in those issues are still broken I believe.

Only the first link is a video and it works for me:

Both accordproject/techdocs#328 and accordproject/techdocs#329 are broken, unsure if they are video links.

Both accordproject/techdocs#328 and accordproject/techdocs#329 are broken, unsure if they are video links.

Fixed.

Fixed.


Flutter latest update code conflict ( 1.12.13+hotfix5 )

Hi!
after updating my flutter to latest version, my whole app ran into problems.
i can't even test a debug version. the shared_preferences plugin is deprecated.
after updating android studio and every plugin about flutter and android studio and gradle, it's giving me another error with a misspelled word in it

Steps to Reproduce

update flutter to latest version
try building a debug version of your app

Logs

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, v1.12.13+hotfix.5, on Microsoft Windows [Version 10.0.18362.535], locale en-US)

[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses
[!] Android Studio (version 3.5)
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
[!] IntelliJ IDEA Community Edition (version 2019.2)
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
[√] VS Code (version 1.41.1)
[√] VS Code, 64-bit edition (version 1.33.0)
[!] Connected device
    ! No devices available

! Doctor found issues in 4 categories.

C:\Users\Sepehr\Desktop\projects\Programming\nfcpay>flutter doctor -v
[√] Flutter (Channel stable, v1.12.13+hotfix.5, on Microsoft Windows [Version 10.0.18362.535], locale en-US)
    • Flutter version 1.12.13+hotfix.5 at C:\flutter
    • Framework revision 27321ebbad (10 days ago), 2019-12-10 18:15:01 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\Sepehr\AppData\Local\Android\Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 28.0.3
    • ANDROID_HOME = C:\Users\Sepehr\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[!] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[!] IntelliJ IDEA Community Edition (version 2019.2)
    • IntelliJ at E:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2019.2.4
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[√] VS Code (version 1.41.1)
    • VS Code at C:\Users\Sepehr\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.7.1

[√] VS Code, 64-bit edition (version 1.33.0)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.7.1

[√] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.0.0 (API 26) (emulator)

! Doctor found issues in 3 categories.

Update also your Flutter and Dart plugin

run: flutter doctor --android-licenses

Hi @Sepehr13
@JonathanMonga  suggestion seems valid,
after that could you please run
flutter clean
flutter pub cache repair
If the issue persist could you please
provide your  flutter run --verbose?
thank you


Fixed some error handling in pagination

Status code was not being checked via paginator.
Errors on the streams were not returned to client streams

Thanks


chore: Migrate at_mono module repos

Is your feature request related to a problem? Please describe.
While at_mono "works" it is currently difficult to run tests from the repo, and other forms of automation, this will be especially true as we begin to add packages to at_mono.
Describe the solution you'd like
First migrate all packages to follow the new dart repo specification:

at_server : https://github.com/atsign-foundation/at_server/pull/975
at_client_sdk : https://github.com/atsign-foundation/at_client_sdk/pull/757
at_widgets : https://github.com/atsign-foundation/at_widgets/pull/548
at_libraries
at_tools
at_app : https://github.com/atsign-foundation/at_app/pull/211

Then refactor workflows into composite actions, so that they may be reused in at_mono's workflows:

at_server
at_client_sdk
at_widgets
at_libraries
at_tools
at_app

Describe alternatives you've considered
No response
Additional context
No response

@cpswan @gkc the three open PRs listed are ready to be merged over this weekend

Minimal progress was made in PR 50, moving over to PR 51.

Backlogging to focus on docs site


rename rpc interface: 'exists' to 'status'

Codecov Report

Merging #4 into dev will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##               dev      #4   +/-   ##
=======================================
  Coverage     7.37%   7.37%
  Complexity      30      30
=======================================
  Files           15      15
  Lines         1315    1315
  Branches       189     189
=======================================
  Hits            97      97
  Misses        1198    1198
  Partials        20      20

Impacted Files
Coverage Δ
Complexity Δ

.../com/webank/wecross/console/common/JlineUtils.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...om/webank/wecross/console/common/ConsoleUtils.java
40.69% <0%> (ø)
29 <0> (ø)
:arrow_down:

...com/webank/wecross/console/common/WelcomeInfo.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...n/java/com/webank/wecross/console/rpc/RPCImpl.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...va/com/webank/wecross/console/common/HelpInfo.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...rc/main/java/com/webank/wecross/console/Shell.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../com/webank/wecross/console/mock/MockResource.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a26575f...e9946af. Read the comment docs.


Fix prow build

Make build.sh executable so it can be directly invoked from the prow job.
Add a pull request template

The below will be a part of the template once merged, this is just to keep poiana happy in the meantime.
NONE

@mstemm: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mstemm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

build-plugins
c48b54756b8c4ae39abe4ae5ef1bdb2cdfde0877
link
/test build-plugins

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mstemm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

build-plugins
dbab6cf21fdad7ebeb8ea4d9628289c0220e4e6c
link
/test build-plugins

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mstemm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

build-plugins
85740c08481a3d89e22e1ea36bf2f1012b85382f
link
/test build-plugins

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@mstemm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

build-plugins
85740c08481a3d89e22e1ea36bf2f1012b85382f
link
/test build-plugins

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@mstemm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

build-plugins
85740c08481a3d89e22e1ea36bf2f1012b85382f
link
/test build-plugins

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

3ebad2b Move pull request template to own PR

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Okay, the pull request template is removed in favor of #4.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr, mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr,mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 9e62012d62b82321dc4d125a746c6d0c53c2257c


Ubuntu 24.04 --> Maximizing causes crash 95% of the time.  Version 2.0.0

As the title says, maximizing causes crash most of the time.
Framework 14 laptop (intel 12th gen, intel graphics), wayland, all patches installed.
Besides the log below, let me know what else I can send.
Log...
[2024-06-11 14:38:09.121] [info]  Checking for update [2024-06-11 14:38:09.371] [info]  Generated new staging user ID: 3bfd27d5-dfd1-51dd-94ed-a0fd64255f6b [2024-06-11 14:38:10.539] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-11 14:38:46.455] [info]  Checking for update [2024-06-11 14:38:47.870] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-11 14:57:41.020] [info]  Checking for update [2024-06-11 14:57:44.702] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-11 14:59:35.924] [info]  Checking for update [2024-06-11 14:59:39.071] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-11 15:02:18.158] [info]  Checking for update [2024-06-11 15:02:21.871] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-11 17:28:35.508] [info]  Checking for update [2024-06-11 17:28:35.773] [error] Error: Error: net::ERR_NAME_NOT_RESOLVED     at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/browser_init:2:114379)     at SimpleURLLoaderWrapper.emit (node:events:518:28) [2024-06-11 17:28:35.799] [error] Aptabase: Failed to send event Error: net::ERR_NAME_NOT_RESOLVED     at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/browser_init:2:114379)     at SimpleURLLoaderWrapper.emit (node:events:518:28) [2024-06-12 09:27:53.894] [info]  Checking for update [2024-06-12 09:27:55.500] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-12 09:28:24.098] [info]  Checking for update [2024-06-12 09:28:25.327] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-12 12:40:04.379] [info]  Checking for update [2024-06-12 12:40:06.044] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-13 12:11:34.002] [info]  Checking for update [2024-06-13 12:11:35.496] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-13 12:12:20.120] [info]  Checking for update [2024-06-13 12:12:21.483] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-13 14:57:41.503] [info]  Checking for update [2024-06-13 14:57:43.066] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-13 14:58:04.926] [info]  Checking for update [2024-06-13 14:58:06.263] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-13 15:01:23.010] [info]  Checking for update [2024-06-13 15:01:24.400] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-13 15:01:35.069] [info]  Checking for update [2024-06-13 15:01:36.060] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-13 15:45:27.019] [info]  Checking for update [2024-06-13 15:45:28.880] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-14 11:51:09.196] [info]  Checking for update [2024-06-14 11:51:10.665] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-16 19:44:08.503] [info]  Checking for update [2024-06-16 19:44:08.998] [error] Error: Error: net::ERR_NAME_NOT_RESOLVED     at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/browser_init:2:114379)     at SimpleURLLoaderWrapper.emit (node:events:518:28) [2024-06-16 19:44:09.264] [error] Aptabase: Failed to send event Error: net::ERR_NAME_NOT_RESOLVED     at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/browser_init:2:114379)     at SimpleURLLoaderWrapper.emit (node:events:518:28) [2024-06-16 19:47:57.584] [info]  Checking for update [2024-06-16 19:47:59.878] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-16 19:49:46.072] [info]  Checking for update [2024-06-16 19:49:47.893] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-17 10:41:38.393] [info]  Checking for update [2024-06-17 10:41:39.760] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-17 10:41:54.403] [info]  Checking for update [2024-06-17 10:41:55.544] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-17 13:54:34.999] [info]  Checking for update [2024-06-17 13:54:36.696] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-18 13:30:12.686] [info]  Checking for update [2024-06-18 13:30:14.049] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-18 13:34:13.195] [info]  Checking for update [2024-06-18 13:34:14.235] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-19 08:36:00.870] [info]  Checking for update [2024-06-19 08:36:02.279] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-19 08:36:49.513] [info]  Checking for update [2024-06-19 08:36:50.756] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-19 11:45:45.505] [info]  Checking for update [2024-06-19 11:45:46.825] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-19 14:51:44.507] [info]  Checking for update [2024-06-19 14:51:45.785] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-20 08:53:15.622] [info]  Checking for update [2024-06-20 08:53:17.143] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-20 09:56:11.670] [info]  Checking for update [2024-06-20 09:56:13.055] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-20 09:56:13.265] [info]  Checking for update [2024-06-20 09:56:14.250] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-20 11:53:00.099] [info]  Checking for update [2024-06-20 11:53:01.520] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-20 15:28:24.645] [info]  Checking for update [2024-06-20 15:28:26.159] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-20 15:31:10.117] [info]  Checking for update [2024-06-20 15:31:11.532] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-20 15:33:57.004] [info]  Checking for update [2024-06-20 15:33:58.628] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-24 09:35:06.307] [info]  Checking for update [2024-06-24 09:35:07.527] [warn]  Aptabase: Failed to send event "app_started": 400  [2024-06-24 09:35:07.649] [warn]  Aptabase: Failed to send event "app_started": 400  [2024-06-24 09:35:07.828] [info]  Update for version 2.0.0 is not available (latest version: 2.0.0, downgrade is disallowed). [2024-06-24 09:35:09.669] [warn]  Aptabase: Failed to send event "app_started": 400

Weird, the log doesn't really show anything related to the issue you mentioned. Are you still facing the issue?

Hi, this was an issue in Electron v30 included in MS-365-Electron, but now it has been fixed in Electron - https://github.com/electron/electron/issues/41839. This will be fixed in the new update of MS-365-Electron as well.


Millisecond component of a DateTime value example uses nonlocalized decimal separator

It was pointed out to me in a code review for code based on this example that I was not using a localized decimal point, despite the date and time formats being localized.
I believe the millisecond component of a DateTime value example should use NumberFormatInfo.CurrentInfo.NumberDecimalSeparator, rather than assuming the separator is a period.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2691d246-9d0a-5714-a3a3-19aabfb3c5cd
Version Independent ID: 80f9e353-0de8-c715-233e-033e6dd3c375
Content: How to: Display Milliseconds in Date and Time Values
Content Source: docs/standard/base-types/how-to-display-milliseconds-in-date-and-time-values.md
Product: dotnet-fundamentals
GitHub Login: @adegeo
Microsoft Alias: adegeo

Hello! Are you saying that this section should use NumberDecimalSeparator?

@adegeo I believe that should as well as the sample code.


[Snyk] Fix for 6 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `rubygems` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

Gemfile
Gemfile.lock

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

519/1000  Why? Has a fix available, CVSS 6.1
Cross-site Scripting (XSS) SNYK-RUBY-ACTIONPACK-6274386
Yes
No Known Exploit

589/1000  Why? Has a fix available, CVSS 7.5
Exposure of Data Element to Wrong Session SNYK-RUBY-ACTIONPACK-6274388
Yes
No Known Exploit

524/1000  Why? Has a fix available, CVSS 6.2
Use After Free SNYK-RUBY-NOKOGIRI-6228056
Yes
No Known Exploit

479/1000  Why? Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-RUBY-RACK-6274383
Yes
No Known Exploit

479/1000  Why? Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-RUBY-RACK-6274384
Yes
No Known Exploit

589/1000  Why? Has a fix available, CVSS 7.5
Denial of Service (DoS) SNYK-RUBY-RACK-6274385
Yes
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Cross-site Scripting (XSS)
🦉 Use After Free
🦉 Regular Expression Denial of Service (ReDoS)

Updated packages to latest version & fixed security issues


H1 doesn't render fontFamily on Android

👋🏽
Hello! I'm implementing a simple header in my app and it seems like Android is not rendering the font properly
iOS

Android

import { H1, Theme } from 'dripsy'
import theme from './theme'

// simplified example
const App = () => (
  <DripsyProvider theme={theme}>

Hello world

  </DripsyProvider>
)

import { Theme } from 'dripsy'

const makeTheme = <T extends Theme>(t: T): T => t

const theme = makeTheme({
  fonts: {
    root: 'nunito',
  },
  customFonts: {
    nunito: {
      bold: 'nunitoBold',
      default: 'nunito',
      normal: 'nunito',
      400: 'nunito',
      500: 'nunitoSemiBold',
      600: 'nunitoBold',
      700: 'nunitoBold',
      800: 'nunitoExtraBold',
      900: 'nunitoBlack',
    },
  },
  text: {
    default: {
      fontSize: 18,
      color: 'text',
    },
    h1: {
      fontSize: [24, 32],
      color: 'text',
    },
  },
})

export default theme

I've noticed if I commented this line out in @expo/html-elements, it starts to work:
https://github.com/expo/expo/blob/master/packages/html-elements/src/elements/Headings.tsx#L39
I've tried debugging the code in my node modules but still can't figure it out. It's weird that it works perfectly fine in iOS, but not in Android 🤔
Any help is appreciated!
In the meantime, my workaround is

Hello world

and it's still able to pull variant "text.h1" 👍🏽
Thank you!!

Alternatively, is there a way to set the bold font on Android? I'm not an expert in Android fonts, but it always gave me a ton of issues, from font family to line spacing.

could you see if passing fontWeight: 400 or fontWeight: 'normal' to the style (not sx) prop fixes it?

So I've tried adding that to the theme variant (as well as inline style prop), and it ends up getting converted in to fontFamily (even if i have both fontFamily and fontWeight, fontWeight gets dropped)

I mean this

Hello world

still had the font bolded so 🤷🏽♂
Maybe I can create my own H1, H2, etc by wrapping Text and the proper variants?


timeouts on invocations like call_function and eval

for https://github.com/theduke/quickjs-rs/issues/4
i think i want to impl this a bit broader (basicly in all public methods of JSRealmAdapter) so you can allways recover from endless loops and such...
Also i want to reimpl timeouts for get_promise_result (which was removed because it was difficult to impl with Futures)

i'm guessing i should give all loop methods in JSRuntimeFacade a timeout: Option<Duration>
this should set a thread_local var which is used by the interupt handler

moving this to next milestone
i need to figureout for mysqlf if i want a global-ish timeout for all taks added to the event loop or if i want fine-grained controll over setting a timeout per job...
API wise i also want to think about timeouts on promise (fail promises if not fullfilled after x secs and such)
i also want to do some research on whether or not other engines like spidermonkey have a intterrupt handler mechanic (if not this will be a quickjs-only thing)


Enforce name and namespace length in the webhook

When the .spec.moduleLoader.container.version field is set, the combined length of the name and namespace fields should not exceed 40 characters to avoid issues with labels.
Fixes #444
/cc @yevgeny-shnaidman @mresvanis

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.04 :tada:

Comparison is base (a6ee450) 82.87% compared to head (1cf11dd) 82.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   82.87%   82.91%   +0.04%
==========================================
  Files          33       33
  Lines        3316     3324       +8
==========================================
+ Hits         2748     2756       +8
  Misses        465      465
  Partials      103      103

Impacted Files
Coverage Δ

api/v1beta1/module_webhook.go
84.81% <100.00%> (+1.71%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

/lgtm


Refactor KeyStoreSettings : Change KeyStore password to KeyEntry Password

Description
The password for KeyEntry in KeyStore can be different than that of KeyStore password itself.

storePass : Password to access KeyStore
spKeyPass : Password to access KeyEntry in the KeyStore

The KeyStoreSettings should mention spKeyPass instead of storePass.
(StorePass is not required as KeyStore is already loaded and passed while constructing KeyStoreSettings)
Changes in the PR

Replaced the KeyStore file which has different password for KeyStore and KeyEntry in the KeyStore.

KeyStore : (oneloginTestKeystore.jks; password : changeit)
KeyEntry : (alias: keywithpassword; password : keypassword)

Changed storePass to spKeyPass in KeyStoreSettings.
Refactored unit tests as per above change.
Updated README.md.

How Has This Been Tested?
Tested with unit tests.
Types of changes

[x] Refactor code
[x] Fixes description

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] All new and existing tests passed.

Coverage remained the same at 94.675% when pulling 32025f95ecc040ec4cd71caa4b3134154bd60fbe on ProcrastinatorCp:ticket-fix-keyStore into e25e39b66c60a089619bf87d054ff572da3a98e8 on onelogin:master.


tests for SO updates about cooldownPeriod

Proposal
tests in internals/ regarding cooldownPeriod updates during scaling
Use-Case
No response
Is this a feature you are interested in implementing yourself?
Yes
Anything else?
No response

/assign me pls


required package does not exist

this package listed in go.mod does not exist: github.com/russross/blackfriday/v2

Strange, it does exist :thinking:

They've switched to gopkg.in/russross/blackfriday.v2. I can't go get github.com/russross/blackfriday/v2. This repo seems to use that so I get the failure too. It is odd though because play.golang.org works fine with the old url.

It seems that issue is being discussed over here https://github.com/russross/blackfriday/issues/587
I don't get why it suddenly broke.
Just out of curiosity, how are you trying to go get the v2 version ?

So after a quick test, I can't reproduce.
go.mod
module github.com/Depado/bfchromatest

go 1.14

require (
	github.com/Depado/bfchroma v1.2.0
	github.com/alecthomas/chroma v0.7.3 // indirect
	github.com/russross/blackfriday/v2 v2.0.1
)

main.go
package main

import (
	"fmt"

	"github.com/Depado/bfchroma"

	bf "github.com/russross/blackfriday/v2"
)

func main() {
	md := []byte("# hello world")
	html := bf.Run([]byte(md), bf.WithRenderer(bfchroma.NewRenderer()))

	fmt.Println(string(html))
}

$ go run main.go

hello world

Even after I go get -u, it doesn't fail.
Are you both using go modules ?

Start with an empty ~/go:
$ go get -v github.com/Depado/bfchroma
github.com/Depado/bfchroma (download)
created GOPATH=/home/peter/go; see 'go help gopath'
github.com/alecthomas/chroma (download)
github.com/dlclark/regexp2 (download)
github.com/danwakefield/fnmatch (download)
github.com/russross/blackfriday (download)
package github.com/russross/blackfriday/v2: cannot find package "github.com/russross/blackfriday/v2" in any of:
        /my/opt/go/src/github.com/russross/blackfriday/v2 (from $GOROOT)
        /home/peter/go/src/github.com/russross/blackfriday/v2 (from $GOPATH)

go version go1.14.3 linux/amd64

Alright, I'm completely lost, if anyone has the knowledge to help me out with this one.
I'm starting fresh with a new GOPATH every time using mktemp.
Outside of a go module project
env GOPATH=(mktemp -d -t gopath-XXXXXXXXXX) go get -v github.com/Depado/bfchroma
github.com/Depado/bfchroma (download)
github.com/alecthomas/chroma (download)
github.com/dlclark/regexp2 (download)
github.com/danwakefield/fnmatch (download)
github.com/russross/blackfriday (download)
package github.com/russross/blackfriday/v2: cannot find package "github.com/russross/blackfriday/v2" in any of:
	/home/paul/go/src/github.com/russross/blackfriday/v2 (from $GOROOT)
	/tmp/gopath-WHL5VOgK5F/src/github.com/russross/blackfriday/v2 (from $GOPATH)

Inside a go module project
I'll reuse the one described in my latest comment:
// file: go.mod
module github.com/Depado/bfchromatest

go 1.14

require (
	github.com/Depado/bfchroma v1.2.0
	github.com/alecthomas/chroma v0.7.3 // indirect
	github.com/russross/blackfriday/v2 v2.0.1
)

env GOPATH=(mktemp -d -t gopath-XXXXXXXXXX) go get -v github.com/Depado/bfchroma
go: downloading github.com/Depado/bfchroma v1.2.0
go: downloading github.com/alecthomas/chroma v0.7.3
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/dlclark/regexp2 v1.2.0
go: downloading github.com/danwakefield/fnmatch v0.0.0-20160403171240-cbb64ac3d964
github.com/danwakefield/fnmatch
github.com/shurcooL/sanitized_anchor_name
github.com/dlclark/regexp2/syntax
github.com/russross/blackfriday/v2
github.com/dlclark/regexp2
github.com/alecthomas/chroma
github.com/alecthomas/chroma/lexers/internal
github.com/alecthomas/chroma/formatters/html
github.com/alecthomas/chroma/styles
github.com/alecthomas/chroma/lexers/b
github.com/alecthomas/chroma/lexers/a
github.com/alecthomas/chroma/lexers/p
github.com/alecthomas/chroma/lexers/e
github.com/alecthomas/chroma/lexers/j
github.com/alecthomas/chroma/lexers/f
github.com/alecthomas/chroma/lexers/i
github.com/alecthomas/chroma/lexers/k
github.com/alecthomas/chroma/lexers/l
github.com/alecthomas/chroma/lexers/n
github.com/alecthomas/chroma/lexers/o
github.com/alecthomas/chroma/lexers/q
github.com/alecthomas/chroma/lexers/r
github.com/alecthomas/chroma/lexers/d
github.com/alecthomas/chroma/lexers/t
github.com/alecthomas/chroma/lexers/w
github.com/alecthomas/chroma/lexers/x
github.com/alecthomas/chroma/lexers/y
github.com/alecthomas/chroma/lexers/v
github.com/alecthomas/chroma/lexers/c
github.com/alecthomas/chroma/lexers/h
github.com/alecthomas/chroma/lexers/circular
github.com/alecthomas/chroma/lexers/g
github.com/alecthomas/chroma/lexers/m
github.com/alecthomas/chroma/lexers/s
github.com/alecthomas/chroma/lexers
github.com/Depado/bfchroma

I can't seem to figure out the difference between go geting a package inside a project and go geting a package outside of a project. I tried ensuring this is the latest version of the repo using @master when go getting but that doesn't change anything since master points to the v1.2.0 release anyway.

So I've been digging around lately.
Turns out, I'm using spf13/cobra, which in turn uses a lab called md2man that depends on github.com/russross/blackfriday/v2 so I can't rollback to using the gopkg.in version. But I don't understand how it can't be build:
$ git clone git@github.com:Depado/smallblog.git
Clonage dans 'smallblog'...
remote: Enumerating objects: 13, done.
remote: Counting objects: 100% (13/13), done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 698 (delta 4), reused 12 (delta 4), pack-reused 685
Réception d'objets: 100% (698/698), 1.41 Mio | 3.25 Mio/s, fait.


Added required files for Certificate Generator UI

Hi @Anushka-codergirl, this is not exactly what was expected, but I'll have it here, so that you can update your PR after the initial demo has been added.

@Anushka-codergirl Check out the last commit or this directory.

@Anushka-codergirl Any updates on this?

Feel free to reopen when you're submitting it once again. 😁

Ya sure!


When the table name is capitalized, you cannot press and hold the Ctrl key directly in the SQL editor to click the table name

Description
When the database table name is uppercase, you cannot press and hold the Ctrl key to click the table name directly in the SQL editor。
But if you add the database name, you can click on it again

DBeaver Version
<IP_ADDRESS>309041200
Operating System
windows11
Database and driver
TiDB Driver (MySQL Connector/J 8.0)
Steps to reproduce
1、When I try to connect to the database“MySQL”、“TiDB”
2、Use the default configuration
3、Type a statement in the SQL editor, hold down the Ctrl key, and prepare to enter the data table by left-clicking the table name
4、When the database name is not added before the table name, the data table cannot be accessed

Additional context
No response

Hello @xieliangza
And what is the original table name in your case? Is it upper case and in quotes or lower case?

Related ticket: https://github.com/dbeaver/dbeaver/issues/21248
We need to improve MySQLStructureAssistant

Also, is your SQL Editor associated with the table database?

For now I'm closing as a duplicate of #21248


MigrateToLerna: updates

Proposed Changes

Fix import path of buefy-next
Fix import path of package.json of Buefy
Fix import path of buefy-next/utils/color
Remove server.fs config from vite.config.js which became unnecessary and even harmful as we started migrating to Lerna
Fix problems with the bulma-css-vars extension page:

Use vite-plugin-commonjs to import bulma-generated/bulma-color.js which is in the CommonJS format
Author Vite plugins to patch bulma-css-vars
Fix the bug that the code snippet became "0"

Restore static folder and move it under packages/docs/public
Install missing dependencies of docs package
Install pre-commit because git commit stopped without it. However, it does nothing until we restore pre-commit property in package.json.

@wesdevpro Btw, do you have any reason to directly spreading source files in packages/buefy-next rather than in packages/buefy-next/src? Putting source files in src folder looks more standard.


Support for DocumentSymbol format

findDocumentSymbols does return an array of SymbolInformation, which is deprecated in favor of DocumentSymbol (and WorkspaceSymbol, but I don't think that's relevant here). It would be great if the implementation would change to using DocumentSymbol, or alternatively for more backwards compatibility introduce findDocumentSymbolsV2. This is blocking the Svelte language service from using DocumentSymbol because we rely on this service and it doesn't seem possible to transform one format into the other.

Please track #152.


Remove unnecessary operation with -1 in AnchorGenerator

The AnchorGenerator does a -1 operation in 2 places.
In the case with for example SSD when using an input size of 300 and a scale factor of 1., the expected behaviour would be that the generated anchors produce bounding boxes with a width and a height of 30, which is not the case here (it is 28).
Other implementations such as the Tensorflow Object Detection framework don't have this behaviour.
https://github.com/tensorflow/models/blob/34a3581c0e09c293cd67b5ac2d64e8bc753cefce/research/object_detection/anchor_generators/grid_anchor_generator.py#L213:
return tf.concat([centers - .5 * sizes, centers + .5 * sizes], 1)

I just looked at other pull requests and saw you just changed this in 2.0
https://github.com/open-mmlab/mmdetection/pull/2380
Is there any timeline for the release on 2.0 and do you suggest switching to the 2.0 preview branch in the meantime?

Hi @Mxbonn ,
V2.0 should be released in the following one week. Since V2.0 changes frequently and heavily, we suggest not use it until it is merged into master and released.


Invalid Domain Name error when generating the JWT

Description:
When SAML bearer grant type is used and exchange that token to an OAuth token, token stored in the DB with SUBJECT_IDENTIFIER values appended with the prefix FEDERATED in IDN_OAUTH2_ACCESS_TOKEN table after refreshing the token.
Suggested Labels:
AM-2.2.0

Fixed with the changes done for https://github.com/wso2/product-is/issues/4189

Fixed with https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/1000. Hence closing.


Add ability to override monospaced font

Today I set my font to a monospaced font, and found some code snippets in our Slack, and I found that that is monospaced, but uses a different font. Would love to override that as well. Of course with a separate setting. Thanks for considering adding this.

Done. Enjoy!

That was fast :) Thanks for taking your time. However, I ran into issues. I can see the new option, and it's exactly how I imagined it, but it doesn't apply the font I specify. I tried setting it under the tweaks menu, and also tried toggling it in the title bar. It works well for the regular font override. I'm using latest of both Slack, and mtslack.

Maybe you didn't add the font size at the top?

Ah, I missed that. Maybe you also should note that a unit is required as well. It didn't work for me with "15 Jetbrains Mono", but it worked with "15px Jetbrains Mono". Thanks for this cool feature! 🙂


Add all data fields to the Loan class

[x] ID
[x] loanerName
[x] loanerIC
[x] loanerPhone
[x] loanerEmail
[ ] remove Address
[x] loanedBike
[x] loanStartTime
[x] loanEndTime
[x] loanRate

We discussed before (during recess week) that it would be easier to implement the fields as-is, as there isn't much point in tracking a person/customer class in particular.
Though I'm not stopping you if you want to do it.

Include LoanEndTime (Type Optional) as well.

Good consideration. Do you think it should be an absolute time (e.g. "1800" for 6 pm), or should it be a loanDuration instead? I'm thinking the latter is easier to key in. But the former prevents cases like the loan ending at 6:03 pm for example.

Refer to PR #133 and #105 for loanStartTime, loanEndTime and loanStatus.
Also, this issue is duplicated in #103.

The final remaining task, "Remove Address", has its own issue here: https://github.com/CS2103-AY1819S1-F10-2/main/issues/89
I will close this issue and use that issue to track it.


Idea: split-process service discovery

Proposal
In big installations, service discovery can be a major proportion of CPU and memory usage inside Prometheus.
Especially with lots of relabeling rules.  Spotify reported 50% in this video.
If you scale horizontally using hashmod rule (e.g. using Prometheus as an agent to send to a remote-write store), then all service discovery work is repeated on every replica.
My idea: run one process doing real service discovery (e.g. talking to Kubernetes), and have that offer HTTP service discovery, containing the targets after relabeling.
When scaling horizontally, have this process offer N sets of targets, subdivided by hashmod or similar.

Are you suggesting this be a new binary a la promtool or a new mode in prometheus like agent mode?
I've had similar thoughts, and often find myself wondering if something like https://github.com/hashicorp/go-plugin or something similar could help. Not only with regards to separating duties to a different process, but potentially also helpful in reducing binary size/build deps, as well as potentially helping with ownership of SDs (re: #14357 )

One binary run in two modes would make the image smaller.
I would prefer to look at using the existing http-SD over introducing a new protocol.

Nice, I found this via bsky
Yea, we could make this a pattern. However it feels it would need to handle load balancing too (supporting multiple Prometheus-es). You mentioned hashmod which is more stable, we could do per node too perhaps. However, it's tempting to do generic "dynamic scrape target distribution" that is generally a bad idea (less reliable, very hard to debug etc)
Somewhat relevant to https://opentelemetry.io/docs/kubernetes/operator/target-allocator/ too.

However it feels it would need to handle load balancing too

This is what I meant by "when scaling horizontally, have this process offer N sets of targets".
I'm not clear if we are just misunderstanding each other, or if you mean something more.
It is important that the division between scrapers be fairly stable, otherwise all scrapers will end up caching all target info. However it also needs to change when scrapers are added or removed.
Fairness is also an issue - suppose one target has 100 metrics and another has 100,000.
Also reminds me of #14049 - when a target moves from one scraper to another you don't want to add a stale marker.
CC @fpetkovski

This makes a lot of sense and can definitely help with resource usage. In our implementation the SD pod also does an initial scrape to estimate the cost of scraping a target. This can be tricky to get right in the general case and might introduce some initial delay.


Work around issues in Ansible 2.2

This works around a bug(?) in Ansible 2.2 involving complex pip requirements: https://github.com/ansible/ansible/issues/19321
This should allow most of the dependencies of the omero-server role to be installed, however there's another Ansible bug involving virtualenvs which means omego gets installed into the wrong place.

See https://github.com/openmicroscopy/omero-grid-docker/pull/2 for an example of where this is required

2.1 needs testing.

vagrant up omero-server passes this phase but doesn't look to be doing much:
TASK [ice : zeroc ice | setup repository] **************************************
changed: [omero-server]

TASK [ice : zeroc ice | install runtime packages] ******************************
changed: [omero-server] => (item=[u'ice', u'ice-python', u'ice-servers'])

TASK [ice : zeroc ice | install devel packages] ********************************
changed: [omero-server] => (item=[u'ice-c++-devel', u'ice-java-devel', u'ice-python-devel'])

TASK [ice : zeroc ice | install ice pip dependencies] **************************
skipping: [omero-server] => (item=None)

TASK [ice : zeroc ice | pip install packages (ansible < 2.2)] ******************
skipping: [omero-server] => (item=None)

TASK [ice : zeroc ice | pip install packages (ansible >= 2.2)] *****************
skipping: [omero-server]

Trying with ice 3.6

Re-running with ice3.6 passes:
TASK [ice : zeroc ice | setup repository] **************************************
ok: [omero-server]

TASK [ice : zeroc ice | install runtime packages] ******************************
ok: [omero-server] => (item=[u'ice-all-runtime'])

TASK [ice : zeroc ice | install devel packages] ********************************
ok: [omero-server] => (item=[u'ice-all-devel'])

TASK [ice : zeroc ice | install ice pip dependencies] **************************
ok: [omero-server] => (item=[u'gcc', u'gcc-c++', u'libdb-utils', u'bzip2-devel', u'expat-devel', u'openssl-devel', u'python-devel', u'python-pip'])

TASK [ice : zeroc ice | pip install packages (ansible < 2.2)] ******************
ok: [omero-server] => (item=zeroc-ice>=3.6,<3.7)

TASK [ice : zeroc ice | pip install packages (ansible >= 2.2)] *****************
skipping: [omero-server]

:+1:

Good to push grid update to master (Or we release our first tag?) cc: @sbesson


Add support for other version of Petkit feeder [Help Needed!]

Some of you may not have a Petkit Feeder Element SOLO, and still wants to use this plugin.
So I decide to add this feature and hope it will go public ASAP, but I may need some help since I personally just ownd a Petkit Feeder Element SOLO.
If you wanna help me, you can do some thing for me:

Your device exact model, like Petkit feeder mini or so. If possible, a link to Petkit store of your device is very very helpful.

If you know how to capture iOS app http netflow, post the url you captured, which may like one below:(“xxxxxx” is your device Id, please hide it before post it to the public.)

http://api.petkit.cn/6/feedermini/devicestate?id=xxxxxx
http://api.petktasia.com/latest/feeder/devicestate?id=xxxxxx
http://api.petkt.com/latest/feeder/devicestate?id=xxxxxx

Send a HTTP request to http://api.petkit.cn/6/discovery/device_roster" with all the headers you captured above, and you will receive a response like below:

{
  "result": {
    "devices": [{
      "data": {
        "name": "your device name in Petkit app",
        ...
      },
      "type": "FeederMini"
    }],
    ...
  }

comment with the result.devices[].type string. The example above show as "FeederMini"
jubepue
Thank you

If you wanna test the plugin, you can follow this guide:
install the demo version:
git clone -b develop_new_device https://github.com/jubepue/homebridge-petkit-pet-feeder.git
cd homebridge-petkit-pet-feeder
npm link

configure the plugin:
I add a configure to specify the device model: model. Other settings are just like the README.md said.

you can modify it throuth Homebridge UI plugin settings page

or you can modify it directly in config.json file:
for Petkit Element feeder:
"model": "Petkit Element Feeder"
for Petkit Feeder mini
"model": "Petkit Feeder mini"
for Petkit Element SOLO feeder:
"model": "Petkit Feeder SOLO"

remove this plugin:
goto plugin folder. (where you perform the git clone command)
cd homebridge-petkit-pet-feeder
npm unlink
cd .. && rm -rf homebridge-petkit-pet-feeder

change model string:
# goto plugin folder. (where you perform the git clone command)
cd homebridge-petkit-feeder-solo

# modify index.js, use vim or whatever editer you like:
vim index.js

# then locate to line 548, which says:
if (item.type == 'Feeder' && item.data) {```

# change the string Feeder to whatever you find out previosly through http request. save and restart homebridge.
service homebridge restart   // or restart homebridge through Homebridge UI.

Looking forward to your feedback.


Unable to start julia in Atom

Steps that lead to the error message

Install julia-client package on Atom
Start julia

Atom Version: 1.11.2
Electron Version: 0.37.8
System: Microsoft Windows 10 Home Single Language
Thrown From: julia-client package, v0.5.9
Stack Trace
Uncaught TypeError: _ref.monitor is not a function
At /C:/Users/HP/.atom/packages/julia-client/lib/connection/ipc.coffee:102

TypeError: _ref.monitor is not a function
    at IPC.module.exports.IPC.rpc (file:///C:/Users/HP/.atom/packages/julia-client/lib/connection/ipc.coffee:47:15)
    at mod.(anonymous function) (file:///C:/Users/HP/.atom/packages/julia-client/lib/connection/ipc.coffee:81:23)
    at Object.module.exports.boot (file:///C:/Users/HP/.atom/packages/julia-client/lib/connection.coffee:30:26)
    at boot (file:///C:/Users/HP/.atom/packages/julia-client/lib/package/commands.coffee:8:31)
    at file:///C:/Users/HP/.atom/packages/julia-client/lib/package/commands.coffee:62:72
    at Object.module.exports.disrequire (file:///C:/Users/HP/.atom/packages/julia-client/lib/connection/client.coffee:143:27)
    at disrequireClient (file:///C:/Users/HP/.atom/packages/julia-client/lib/package/commands.coffee:7:57)
    at atom-workspace.subs.add.atom.commands.add.julia-client:start-julia (file:///C:/Users/HP/.atom/packages/julia-client/lib/package/commands.coffee:62:38)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (C:\Users\HP\AppData\Local\atom\app-1.11.2\resources\app.asar\src\command-registry.js:260:29)
    at CommandRegistry.handleCommandEvent (C:\Users\HP\AppData\Local\atom\app-1.11.2\resources\app.asar\src\command-registry.js:3:61)
    at CommandRegistry.module.exports.CommandRegistry.dispatch (C:\Users\HP\AppData\Local\atom\app-1.11.2\resources\app.asar\src\command-registry.js:160:19)
    at AtomEnvironment.module.exports.AtomEnvironment.dispatchApplicationMenuCommand (C:\Users\HP\AppData\Local\atom\app-1.11.2\resources\app.asar\src\atom-environment.js:1127:28)
    at EventEmitter.outerCallback (C:\Users\HP\AppData\Local\atom\app-1.11.2\resources\app.asar\src\application-delegate.js:341:25)
    at emitTwo (events.js:100:13)
    at EventEmitter.emit (events.js:185:7)

Commands
     -0:07.1.0 julia-client:start-julia (atom-text-editor.editor.mini.is-focused)

Config
{
  "core": {
    "telemetryConsent": "limited"
  },
  "julia-client": {
    "enableMenu": true,
    "enableToolBar": true,
    "juliaPath": "C:\\Users\\HP\\AppData\\Local\\Julia-0.5.0\\bin\\julia.exe",
    "launchOnStartup": true
  }
}

Installed Packages
# User
ink, v0.4.4 (active)
julia-client, v0.5.9 (active)
language-julia, v0.6.0 (active)
latex-completions, v0.3.1 (active)
tool-bar, v0.4.0 (active)
uber-juno, v0.1.1 (active)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.44.0 (inactive)
base16-tomorrow-dark-theme, v1.2.0 (inactive)
base16-tomorrow-light-theme, v1.2.0 (inactive)
one-dark-ui, v1.6.0 (active)
one-light-ui, v1.6.0 (inactive)
one-dark-syntax, v1.3.0 (active)
one-light-syntax, v1.3.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (inactive)
about, v1.7.0 (active)
archive-view, v0.61.1 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.11.2 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.1 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.42.0 (active)
bracket-matcher, v0.82.1 (active)
command-palette, v0.38.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.201.1 (inactive)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.59.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.1 (inactive)
markdown-preview, v0.158.0 (active)
metrics, v1.0.0 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.242.2-hotfix1 (active)
snippets, v1.0.2 (active)
spell-check, v0.68.2 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.0 (active)
symbols-view, v0.113.1 (inactive)
tabs, v0.101.0 (active)
timecop, v0.33.2 (active)
tree-view, v0.209.3 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.33.0 (active)
wrap-guide, v0.38.2 (active)
language-c, v0.52.1 (active)
language-clojure, v0.21.0 (active)
language-coffee-script, v0.47.2 (active)
language-csharp, v0.12.1 (active)
language-css, v0.37.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.42.1 (active)
language-html, v0.45.1 (active)
language-hyperlink, v0.16.0 (active)
language-java, v0.23.0 (active)
language-javascript, v0.119.0 (active)
language-json, v0.18.2 (active)
language-less, v0.29.5 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.35.0 (active)
language-php, v0.37.2 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.0 (active)
language-ruby, v0.69.0 (active)
language-ruby-on-rails, v0.25.0 (active)
language-sass, v0.56.0 (active)
language-shellscript, v0.22.4 (active)
language-source, v0.9.0 (active)
language-sql, v0.23.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.28.0 (active)
language-toml, v0.18.0 (active)
language-xml, v0.34.9 (active)
language-yaml, v0.26.0 (active)

# Dev
No dev packages

Can you try updating your packages in Atom, especially ink?

I updated ink in Atom but the issue still persists.

Is this still a problem?

Yes, the problem persists even after updating ink in Atom.

Did you update julia-client as well?

Updating julia-client solved the issue. Thanks 👍


Emmet only working in HTML files.

Emmet is only working in HTML file. Its not working in any other language (eg: PHP).

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/30621456-emmet-only-working-in-html-files?utm_campaign=plugin&utm_content=tracker%2F535900&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F535900&utm_medium=issues&utm_source=github).

https://github.com/emmetio/emmet-atom#tab-key


Simple typo correction in documentation

Just changing "certifciates" by "certificates".

To be merged before the 3.0 branch.

Merged to master. Thank you for your contribution.


Add IOS support

like compose-jb in experimental repos

#23 Still work to do like adding support for vector images (which I haven't had time to work on). But you can try it out for images if you want, I published the fork to my own repo.


Example of how to specify local resources.

Hi there, thanks for releasing this! Really appreciated :)
I was just wondering, is there perhaps an example for how to specify the local resources for a launch? I can see that launch allows for an optional Dict[str, Any] to set up the resource configs. I'm guessing here the str keys refer to the nodes in the program but I'm not sure how to specify the "per-node launch configuration" for each node. Would this also be a dictionary, e.g. {"gpus": 2, "cpus": 4}? Apologies if there are examples of this that I missed.

Hi Arnu,
local_resources accepts a dictionary of {"node group" -> PythonProcess }


Docs to support the new ability to build containers using just the .NET SDK (instead of Docker Desktop)

Tell us what search terms you used and how you searched docs.
Container build with .net
.NET sdk build container
build .net container without dockerfile
csproj container build
c# container sdk build
Tell us what docs you found that didn't address your concern.
https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-publish
https://learn.microsoft.com/en-us/dotnet/core/deploying/
https://learn.microsoft.com/en-us/dotnet/core/deploying/deploy-with-vs?tabs=vs156
https://learn.microsoft.com/en-us/dotnet/core/deploying/deploy-with-cli
Explain why this article is needed
Up until now .NET users who wanted to build containers has to install Docker Desktop on their machines and they had to use Dockerfiles. With the release of .NET 7 users now have the option to build containers using the .NET SDK (with certain limitations) and avoid having to install Docker Desktop as well as avoid having to maintain a Dockerfile.
Suggest a location in the Table of Contents.
We should probably do a bunch of things about this, but at the very least the following quickly come to mind:
We should revamp the overview and include it in there
https://learn.microsoft.com/en-us/dotnet/core/deploying/
We should also include it as part of the existing page on publish
https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-publish
We should also talk about the VS integration for the feature in this existing page
https://learn.microsoft.com/en-us/dotnet/core/deploying/deploy-with-vs?tabs=vs156
Write an abstract. In one short paragraph, describe what this article will cover.
Create an outline for the new article. We'll help review the outline and approve it before anyone writes the article.
Check out the opening paragraph of the existing dotnet article on this - it's a good starting point:
Containers have many features and benefits, such as being an immutable infrastructure, providing a portable architecture, and enabling scalability. The image can be used to create containers for your local development environment, private cloud, or public cloud. In this tutorial, you'll learn how to containerize a .NET application using the dotnet publish command.

@IEvangelist , @baronfel FYI


PR template added

Added pr template as suggested in #449

Me

I believe the descriptions or context should be in a comment so can be ignored on open rather than having to remove/delete the placeholder text.

Just felt if we need to make sure the contributor must always provide information of what he did instead of making it optional . Please let me know if I am thinking it in right way

thanks done @daixiang0

To clarify my opinion is that we should comment out the placeholder/descriptive text so that we provide an indication of what to include and does not include it.

To clarify - my opinion is that we should comment out the placeholder/descriptive text so that we provide an indication of what to include and does not include it.

To clarify - my opinion is that we should comment out the placeholder/descriptive text so that we provide an indication of what to include and does not include it.

Agree, @sadath-12 please comment rather than delete.

yeah I get it now thanks @daixiang0  @mikeee


Add support for secrets for JDBC connections

@surjits254 This issue is fixed and tested. I will create a PR to merge this to main branch


Added proper links instead of hashtags

I've added proper links to the docs and books, removing the hashtags #

No-Code Contribution 🚀

Hey, before I merge this, would you be up to do some more "structural" work?
For example, I'd like to give you a template that you need to copy-paste to certain files so that people have an easier path to follow when writing the content - are you okay with this?

This sounds interesting, I'd definitely be up for this. But do you think we should do it in this PR itself? As it is quite out-of-scope for this particular PR, I think we should open up another PR for the templates along with an issue.

Hey! As this is a self-opened issue, I would not feel comfortable merging this as a full-on Hacktoberfest PR. We could either continue here with more structural tasks and craft a well-put PR, or I could merge this one and label it as "invalid" so it doesn't count - up to you. Let me know what you think.

Okay, I think we should work it up here.


[dpdk] no absolute paths

For https://github.com/microsoft/vcpkg/issues/20469
cc @ljishen

Thanks for taking care of this and I'm sorry that I was recently assigned to work on other things. I'm not sure if this will work since the mlx5 driver will need this path.

I'm not sure if this will work since the mlx5 driver will need this path.

But only if *RTE_EAL_PMD_PATH. There is also the comment:
When RTE_EAL_PMD_PATH is set, use its glue-suffixed
variant, otherwise let dlopen() look up libraries on its own.

Thanks!


Teams sides picks in Frontend

from PhlexPlexico/G5WS#18

the events are being fired now, but not displayed on the frontend

And they exist in the API? I believe the table is veto_sides, is there data contained in it?


How to apload image and save resized image?

https://github.com/MihailDev/yii2-elfinder + https://github.com/Studio-42/elFinder/issues/830


review.py: error: argument --pr: invalid int value: ''

Run<EMAIL_ADDRESS>/usr/bin/docker run --name ff1ccb9d3f9b4dac82059bcdf817b21c_31130d --label 442333 --workdir /github/workspace --rm -e INPUT_TOKEN -e INPUT_BUILD_DIR -e INPUT_CLANG_TIDY_VERSION -e INPUT_CLANG_TIDY_CHECKS -e INPUT_INCLUDE -e INPUT_EXCLUDE -e INPUT_APT_PACKAGES -e INPUT_MAX_COMMENTS -e INPUT_PR -e INPUT_REPO -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/action-sample-cpp/action-sample-cpp":"/github/workspace" 442333:ff1ccb9d3f9b4dac82059bcdf817b21c  "--clang_tidy_binary=clang-tidy-" "--token=" "--repo=" "--pr=" "--build_dir=" "--clang_tidy_checks=" "--include " "--exclude " "--apt-packages="
usage: review.py [-h] [--repo REPO] [--pr PR]
[--clang_tidy_binary CLANG_TIDY_BINARY]
[--build_dir BUILD_DIR]
[--clang_tidy_checks CLANG_TIDY_CHECKS] [--include [INCLUDE]]
[--exclude [EXCLUDE]] [--apt-packages APT_PACKAGES]
[--max-comments MAX_COMMENTS] [--token TOKEN]
review.py: error: argument --pr: invalid int value: ''

Thanks for the bug report @charliezhao! It looks like the arguments aren't getting passed through correctly. Please could you share your GitHub Actions yaml file for how you're using it?

Hi @charliezhao is this the repo you were having problems with? https://github.com/charliezhao/action-sample-cpp
I think the issue is that the yml file is overriding the defaults, so it doesn't pick up the github context for the PR number:
name: clang-tidy-review

# You can be more specific, but it currently only works on pull requests
on: [pull_request]

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v2

    - name: clang-tidy review
      # You may pin to the exact commit or the version.
      # uses: ZedThree/clang-tidy-review@33e015025bb38c888d54b66bb97ca7c81c259436
      uses<EMAIL_ADDRESS>      with:
        # Authentication token
        token: # optional, default is ${{ github.token }}
        # Directory containing the compile_commands.json file
        build_dir: # optional, default is .
        # Version of clang-tidy to use; one of 6.0, 7, 8, 9, 10
        clang_tidy_version: # optional, default is 10
        # List of checks
        clang_tidy_checks: # optional, default is -*,performance-*,readability-*,bugprone-*,clang-analyzer-*,cppcoreguidelines-*,mpi-*,misc-*
        # Comma-separated list of files or patterns to include
        include: # optional, default is "*.[ch],*.[ch]xx,*.[ch]pp,*.[ch]++,*.cc,*.hh"
        # Comma-separated list of files or patterns to exclude
        exclude: # optional, default is
        # Comma-separated list of apt packages to install
        apt_packages: # optional, default is
        # Maximum number of comments to post at once
        max_comments: # optional, default is 25
        #
        pr: # optional, default is ${{ github.event.pull_request.number }}
        #
        repo: # optional, default is ${{ github.repository }}

Please could you try remove all the arguments:
name: clang-tidy-review

# You can be more specific, but it currently only works on pull requests
on: [pull_request]

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v2

    - name: clang-tidy review
      uses<EMAIL_ADDRESS>

Same issue :(

My .yml file:
name: clang-tidy-review

# You can be more specific, but it currently only works on pull requests
on: [push]

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v2

    - name: clang-tidy review
      uses<EMAIL_ADDRESS>

I'm seeing the same issue, using the default YAML file from your README. In my case the same error appears when I ask the Action to run on pushes, and it gets run during a push. It sort of makes sense that there's no PR number associated with a push, so either we shouldn't pass in the --pr flag in case of pushes, or handle the instances when the --pr flag has an empty value.


PB-4968: Fix issue with LicensingCountBeforeAndAfterBackupPodRestart on IBM IKS runs

What this PR does / why we need it:
While running the IBM jobs we saw testcase LicensingCountBeforeAndAfterBackupPodRestart fail intermittently with the below error:
error: pods "quick-maintenance-repo-6f03bd2-28337041-778fs" not found, Description: Restart all the backup pods

This is mostly because the quick-maintenance-repo-6f03bd2-28337041-778fs job pod is a short lived job pod and is deleted in some cases between the line 1480 and 1518.
Dashboard URL :

https://aetos.pwx.purestorage.com/resultSet/testSetID/448810
https://aetos.pwx.purestorage.com/resultSet/testSetID/447222
https://aetos.pwx.purestorage.com/resultSet/testSetID/447067
https://aetos.pwx.purestorage.com/resultSet/testSetID/449688(latest)

Which issue(s) this PR fixes (optional)
Closes #PB-4968
Special notes for your reviewer:

Run post changes https://aetos.pwx.purestorage.com/resultSet/testSetID/449688

I am not clear here. We are calling this function DeletePodWithLabelInNamespace which means this function expects namespace and label. But if we are ignoring label here, then we might as well have a new function called DeleteAllPodsInNamespace

The reason why I went to update the same existing code is because the current code deletes all pods or all pods which have the mentioned label and I have updated it to run and delete pods which don't have the label. If we create a new function it'll create be redundant code here.

Successful run after rename https://aetos.pwx.purestorage.com/resultSet/testSetID/449931


[MM-24177] Don't highlight group mention if doesn't have required permission

NOTE TO SELF Add to comment and post so it doesn't have a delay!
Blocked by:
https://github.com/mattermost/mattermost-server/pull/14348
Summary

Fix group mentions shouldn't be highlighted when mentioned by someone who doesn't have permission and should highlight for everyone when triggered by someone who has the permission
Ticket Link

https://mattermost.atlassian.net/browse/MM-24177

I'm going to pause working on this as it requires some code from https://github.com/mattermost/mattermost-webapp/pull/5331 and I don't want to re-duplicate work that is done so I will wait for the PR to get merged first so I can re-use some of those functions.


Update spring-boot-starter-camunda to 8.5.11

About this PR
📦 Updates io.camunda.spring:spring-boot-starter-camunda from 8.5.10 to 8.5.11
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.camunda.spring", artifactId = "spring-boot-starter-camunda" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.camunda.spring", artifactId = "spring-boot-starter-camunda" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #91.


Use lottie-web instead of bodymovin to keep a consistent lottie API

Currently we are using bodymovin, but lottie-web adds a few extra methods and properties.

@Minishlink any comments on this?

Thanks :)


Fix duplicate text in title

Fixing the title and the reference to MVC instead of Web Forms.
There should also be some text in this article about how the .NET Upgrade Assistant isn't going to help you rewrite your web forms pages into MVC views or Razor Pages. The user will have to do that manually.

Internal previews

📄 File
🔗 Preview link

aspnetcore/migration/web_forms.md
Upgrade an ASP.NET Framework Web Forms app to ASP.NET Core ASP.NET Core MVC

Let me know when to S&M.

Let's go ahead and get these fixes in.


newline on user artifact

When processing the user artifact or any of the input files the strings need to be stripped of newline characters.
It is common on tools such as Vi too automatically append this character. It would be best practice to remove them.

Thank you for your note and feedback.


sanitycheck: Add exception check

Add exception check for psutil when running CI with nSIM
Signed-off-by: Jingru Wang<EMAIL_ADDRESS>

Would be good to have more details on why that situation happens in the first place. Otherwise we are just masking some real problem.

This exception happens when the testcase failed, but not all failed tests cause this exception.
Here I print the children processes information before killing them. The log shows that child process nsimdrv has become a zombie process, so parent process can't terminate it by calling proc.wait(0.1), so kill command doesn't apply to it.
INFO    - Total complete:   52/  86  60%  skipped:   23, failed:   26
 ./sanity-out/nsim_em/tests/kernel/mem_protect/stack_random/kernel.memory_protection.stack_random - psutil.Process(pid=4616, name='make', status='sleeping', started='05:49:40')
 ./sanity-out/nsim_em/tests/kernel/mem_protect/stack_random/kernel.memory_protection.stack_random - psutil.Process(pid=4626, name='make', status='sleeping', started='05:49:41')
 ./sanity-out/nsim_em/tests/kernel/mem_protect/stack_random/kernel.memory_protection.stack_random - psutil.Process(pid=5178, name='make', status='sleeping', started='05:49:47')
 ./sanity-out/nsim_em/tests/kernel/mem_protect/stack_random/kernel.memory_protection.stack_random - psutil.Process(pid=5179, name='nsimdrv', status='zombie', started='05:49:47')
 Exception in thread Thread-402:
 Traceback (most recent call last):
   File "./zephyr/scripts/sanity_chk/sanitylib.py", line 501, in _output_handler
     proc.wait(0.1)
   File "/depot/Python/Python-3.7.0/lib/python3.7/subprocess.py", line 971, in wait
     return self._wait(timeout=timeout)
   File "/depot/Python/Python-3.7.0/lib/python3.7/subprocess.py", line 1593, in _wait
     raise TimeoutExpired(self.args, timeout)
 subprocess.TimeoutExpired: Command '['make', 'run']' timed out after 0.1 seconds
 During handling of the above exception, another exception occurred:
 Traceback (most recent call last):
   File "/depot/Python/Python-3.7.0/lib/python3.7/threading.py", line 917, in _bootstrap_inner
     self.run()
   File "/depot/Python/Python-3.7.0/lib/python3.7/threading.py", line 865, in run
     self._target(*self._args, **self._kwargs)
   File "./zephyr/scripts/sanity_chk/sanitylib.py", line 503, in _output_handler
     self.terminate(proc)
   File "./zephyr/scripts/sanity_chk/sanitylib.py", line 458, in terminate
     os.kill(child.pid, signal.SIGTERM)
 ProcessLookupError: [Errno 3] No such process

 stty: standard input: Inappropriate ioctl for device

 ERROR   - nsim_em                   tests/kernel/mem_protect/stack_random/kernel.memory_protection.stack_random FAILED: Failed
 ERROR   - see: ./sanity-out/nsim_em/tests/kernel/mem_protect/stack_random/kernel.memory_protection.stack_random/handler.log

And the try-exception doesn't affect sanitycheck's judgment of test result, because the test result have been obtained before it is called.

Fixies: #30752

@wangnuannuan could you please update the commit message, so we can have it merged ASAP?
Thanks!
PS: haven't notice that it actually addresses the current issue with random failures on nsim_* platforms and not the issue with exception with pid file missing (which has been already fixed)


[TOMEE-4061] TomEE 9.x + Derby <IP_ADDRESS>, upon other dependencies update

This is a tentative to update Derby to 10.15.x, upon other dep updates.
Derby 10.15.x is modular, it might break CI, please merge wisely.
TO BE MERGED AFTER:

PR #938
PR #953

TomEE 9.x dependencies update:

Derby <IP_ADDRESS>

CI build ok on my fork https://github.com/sultan/tomee/actions/runs/3195891350/jobs/5217111532

rebased upon:

PR #938

@sultan Can you rebase this one? So we can create a CI task for it to see

on it.

@rzo1, rebased and ready for CI test

Thanks. I created a CI task for it: https://ci-builds.apache.org/job/Tomee/job/TOMEE-4061/

@sultan looks like two regressions:
org.apache.openejb.arquillian.EarWarResourcesXmlTest.(?)
org.apache.openejb.resource.jdbc.driver.AlternateDriverJarTest.testBoth
Might be quick ones: class not found and missing jar.

ok i'll see if i can correct

If you need help/support, just drop a message in the list or in the PR.

@jeanouii updated this test last year for it to pass, i hard coded the test so that the 'two drivers' are 10.10 and 10.14.
you both might want to review this change.

rebased upon dependencies cleanup, i do recommend:

review about the hard coded values of the multi-driver datasources tests
build on CI

TODO :

create a JIRA for this dep update

rebased upon tomee-9.x
please review

is this PR still needed ?

Only derby left. I triggered a full build for it.

I think, that we need to port these changes targeting https://github.com/apache/tomee/pull/1005 as well.

I'm ok to merge this one too. But this is with the view that we may need to revert because of the TCK setup. I remember TCK issues but probably a good time to address those as well. Thanks @sultan

I'm ok to merge this one too. But this is with the view that we may need to revert because of the TCK setup. I remember TCK issues but probably a good time to address those as well. Thanks @sultan

this will be in PR #1021 ... its a small one so no problem reverting it if needed


Not working with docker-compose.yml

I'm unsure with the syntax, but I'm unable to create a volume using docker-compose, it fails when mounting it to a service
sshvolume:
    driver: vieux/sshfs
    driver_opts:
      sshcmd: <user>@<host>:<path-in-host>
      password: <password>

service:
      - sshvolume:<path-in-docker>

the command works in console:
docker volume create -d vieux/sshfs -o sshcmd=<user>@<host>:<path-in-host> -o password=<password> --name sshvolume

@2Kable I have no issue with this compose file
version: "3"

services:
  worker:
    image: alpine
    command: sh -c "while true; do echo \`cat /etc/hostname\` >> /data/hostnames; sleep 1; done"
    volumes:
      - sshvolume:<path-in-docker>
    deploy:
      mode: replicated
      replicas: 2
      placement:
        constraints: [node.role != manager]

volumes:
  sshvolume:
    driver: vieux/sshfs
    driver_opts:
      sshcmd: <user>@<host>:<path-in-host>
      password: <password>

This issue probably is related to #15 . I have the same problem like @2Kable, but if I inspect the service I  notice the problem ist basically the same as #15 and the volume created by compose is otherwise functional.


Re-generated (re-formatted) expected entangler test bundles

We probably need to have a unit test that validates the fixtures are formatted properly.


CASMSEC-375: Remove opa-gatekeeper for CSM upgrade support (for Alice…

Summary and Scope
Remove opa-gatekeeper for CSM upgrade support (for Alice) by Jan 31 2023
Issues and Related PRs
https://github.com/Cray-HPE/csm/pull/1614/files
https://github.com/Cray-HPE/cray-drydock/pull/31/files
https://github.com/Cray-HPE/cray-drydock/pull/32/files
Testing
ncn-m001:/tmp/pradeep # helm list -n gatekeeper-system
NAME                            NAMESPACE               REVISION        UPDATED                                 STATUS       CHART                            APP VERSION
gatekeeper                      gatekeeper-system       1               2023-01-20 07:39:32.849377453 +0000 UTC deployed     gatekeeper-1.5.3                 v3.1.1
gatekeeper-constraints          gatekeeper-system       1               2023-01-20 07:41:16.204372356 +0000 UTC deployed     gatekeeper-constraints-0.5.0     1.16.0
gatekeeper-policy-library       gatekeeper-system       1               2023-01-20 07:40:25.719088453 +0000 UTC deployed     gatekeeper-policy-library-0.5.0  1.16.0
gatekeeper-policy-manager       gatekeeper-system       1               2023-01-20 07:41:27.021058894 +0000 UTC deployed     gatekeeper-policy-manager-1.3.0  0.4.0

ncn-m001:/tmp/pradeep # cat undeploy.sh
#!/usr/bin/env bash

# Copyright 2021 Hewlett Packard Enterprise Development LP

# Undeploy the chart if it exists on the system.
# Use this if a chart has been removed from a manifest and needs
# to be removed from the system as part of an upgrade.
function undeploy() {
    # If the chart is missing (rc==1) just return success.
    helm status "$@" || return 0
    # Remove the chart.
    helm uninstall "$@"
}

undeploy -n gatekeeper-system gatekeeper-policy-manager
undeploy -n gatekeeper-system gatekeeper-constraints
undeploy -n gatekeeper-system gatekeeper-policy-library
undeploy -n gatekeeper-system gatekeeper
ncn-m001:/tmp/pradeep #

ncn-m001:/tmp/pradeep # ./undeploy.sh
NAME: gatekeeper-policy-manager
LAST DEPLOYED: Fri Jan 20 07:41:27 2023
NAMESPACE: gatekeeper-system
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
Gatekeeper Policy Manager can be accessed from a Web Browser as below:
1. URL : https://opa-gpm.<external DNS of the system>
   Ex. https://opa-gpm.vshasta.io/
2. Forward communication on Port 8080 and access GPM from browser using that port
release "gatekeeper-policy-manager" uninstalled
NAME: gatekeeper-constraints
LAST DEPLOYED: Fri Jan 20 07:41:16 2023
NAMESPACE: gatekeeper-system
STATUS: deployed
REVISION: 1
TEST SUITE: None
release "gatekeeper-constraints" uninstalled
NAME: gatekeeper-policy-library
LAST DEPLOYED: Fri Jan 20 07:40:25 2023
NAMESPACE: gatekeeper-system
STATUS: deployed
REVISION: 1
release "gatekeeper-policy-library" uninstalled
NAME: gatekeeper
LAST DEPLOYED: Fri Jan 20 07:39:32 2023
NAMESPACE: gatekeeper-system
STATUS: deployed
REVISION: 1
TEST SUITE: None
W0120 07:42:16.733164  651076 warnings.go:70] admissionregistration.k8s.io/v1beta1 ValidatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 ValidatingWebhookConfiguration
release "gatekeeper" uninstalled

ncn-m001:/tmp/pradeep # helm list -n gatekeeper-system
NAME    NAMESPACE       REVISION        UPDATED STATUS  CHART   APP VERSION
ncn-m001:/tmp/pradeep #

Tested on:
drax
###Test description
Above code snippet is tested and integrated into the file "upgrade.sh" with logs.

After un-installing the gatekeeper charts, we noticed there are artefacts like namespace, clusterroles & rolebindings are there and to be removed during upgrade. If any interfaces are there to clean those during upgrade, we can initiate that. Otherwise we need to create separate functions to clean all the artefacts that are related to the charts when we removed completely  from the CSM. OR we might need to enhance the existing undeploy function to clean the artifacts(based on the arguments passed). Here Based on the PET feedback, we can implement those in a separate PR#.

After un-installing the gatekeeper charts, we noticed there are artefacts like namespace, clusterroles & rolebindings are there and to be removed during upgrade. If any interfaces are there to clean those during upgrade, we can initiate that. Otherwise we need to create separate functions to clean all the artefacts that are related to the charts when we removed completely from the CSM. OR we might need to enhance the existing undeploy function to clean the artifacts(based on the arguments passed). Here Based on the PET feedback, we can implement those in a separate PR#.

Everything that is owned or deployed by the charts should be removed. Suggest investigating if other charts own the cluster roles / role bindings. You should be able to tell this by looking at the labels/attributes on the resources. If, by chance, other charts are deploying these into the gatekeeper-system namespace, etc, you'll have some further coordination to do. If that's the case, we should open tickets with the appropriate teams.

Approving, please file and document other tickets needed to complete removal after the resource requested above.


add system tray icon hover event

SystemTrayEvent contains MenuItemClick LeftClick RightClick RightClick  event，but hover event is not contain.I think this should also be a commonly used event.

I feel the same way, after all, it is complicated to implement this feature when needed


Cast error

Hey!
Looks like this part of code from quill_delta package:
Operation next([num length = double.infinity]) {
    if (_modificationCount != delta._modificationCount) {
      throw ConcurrentModificationError(delta);
    }

    ...

    return Operation.retain(length as int);
  }

causes type 'double' is not a subtype of type 'int' in type cast.

i alse meet this problem

i also meet this problem

Hey did you find a fix for this? I am a fellow type 'double' is not a subtype of type 'int' in type cast casualty here in the year 2023.


CORE-2540 - Database Independent 'Sequence' assignment

CORE-2260 - Ability to specify which sequence to use with loadData
CORE-2540 has the info about how it works from the user's point of view.

#489 Same here...

Fixed by #489