Update manage-acronyms.md

Hi,
I wanted to bring note to this exception when there is a space in the acronym string. The form does not return a validation error and the acronym is listed under the section however searches for the string that includes a space will not return the desired acronym answer.
Thanks.

@RakeshMSFT Bumping this thread to your attention. Thanks for considering.

Thank yuoMicrosoftDocs:public

Thank you

@RakeshMSFT Wondering if you could consider the addition proposed.

We are using this feature on our SharePoint instance, but have found that although two-character searches work in general, they don't include two-character acronym entries from the glossary CSV file. Do you have any recommendations for overcoming this limitation?

We are using this feature on our SharePoint instance, but have found that although two-character searches work in general, they don't include two-character acronym entries from the glossary CSV file. Do you have any recommendations for overcoming this limitation?

Hi,
I just tried it on my tenant. Two letter acronyms with a file upload seemed to work. Did you set the state to published in the csv? Also, it can take 24-48 hours for newly uploaded acronyms to show up. Could it be either of these issues?
Best,
Bp

@bipinprakashtss Acknowledging this. Could you please elaborate the issue bit more. Possibly with one example so that we can understand it better.

Thanks Bipin for following up!
We have all the terms set to Published and waited more than 2 days for testing. I attached our current CSV file we are using for the acronym glossary.
When we search in SharePoint, we find that definitions and links for 3-character acronyms appear in the results, but none of the 2-character acronyms do.
Any suggestions would be much appreciated.
Best regards,
Ken
Ken MacAllister, Senior Learning & Development Specialist
Direct:<PHONE_NUMBER>tel:6048998703 | Toll Free:  1<PHONE_NUMBER>tel:18888863586 | Cell:<PHONE_NUMBER>tel:7788889478
1100 - 250 Howe Street, Vancouver, BC  V6C 3S9 (desk 11-47)
<EMAIL_ADDRESS>| odlumbrown.comhttp://www.odlumbrown.com/
Odlum Brown: Helping clients achieve their financial goalshttps://www.odlumbrown.com/about/our-story for over 100 years
From: Rakesh Kumar @.>
Sent: Tuesday, March 19, 2024 9:00 AM
To: MicrosoftDocs/OfficeDocs-MicrosoftSearch @.>
Cc: Ken MacAllister @.>; Manual @.>
Subject: Re: [MicrosoftDocs/OfficeDocs-MicrosoftSearch] Update manage-acronyms.md (PR #311)
You don't often get email from<EMAIL_ADDRESS>Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
EXTERNAL EMAIL
@bipinprakashtsshttps://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3135533f-454455534531-8a8fec0f9fca0702&q=1&e=6fb7e738-bc65-4ead-b442-d887f95695de&u=https%3A%2F%2Fgithub.com%2Fbipinprakashtss Acknowledging this. Could you please elaborate the issue bit more. Possibly with one example so that we can understand it better.
—
Reply to this email directly, view it on GitHubhttps://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3135533f-454455534531-1b74a48a0a80aea0&q=1&e=6fb7e738-bc65-4ead-b442-d887f95695de&u=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-MicrosoftSearch%2Fpull%2F311%23issuecomment-2007567621, or unsubscribehttps://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3135533f-454455534531-7c991f3d610d0464&q=1&e=6fb7e738-bc65-4ead-b442-d887f95695de&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FBHCQIMJV36PFYOBD23FLQRLYZBOGFAVCNFSM6AAAAABDIV7UGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBXGU3DONRSGE.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>DISCLAIMER: Without the use of encryption, e-mail is not a secure medium and privacy cannot be ensured. All e-mail communication is subject to delay and may, from time to time, be undeliverable due to technical problems. If you choose to provide us with instructions by e-mail, Odlum Brown Limited expressly disclaims any responsibility to verify the accuracy or authenticity of your instructions.
Odlum Brown Limited also disclaims any liability for damages or loss arising from the failure to execute any e-mail request to buy or sell securities or to make transfers of securities or monies in a timely manner, or at all. We therefore recommend that you do not send to us requests by e-mail containing confidential information or instructions. Member-Canadian Investor Protection Fund
Suite 1100 – 250 Howe Street Vancouver, BC, V6C 3S9  |  1-888-886-3586  |   odlumbrown.com http://www.odlumbrown.com   |  @.@.@.@.@.@.%20Ref.%20No.%20OBLTR10104116,%20Subject:%20RE:%20[MicrosoftDocs/OfficeDocs-MicrosoftSearch]%20Update%20manage-acronyms.md%20(PR%20#311),%20Date:%20%20Tuesday,%2019%20March%202024>

@bipinprakashtss Acknowledging this. Could you please elaborate the issue bit more. Possibly with one example so that we can understand it better.

Hi Rakesh,
Sure thing. The add an acronym form allows you to enter a term with a space and does not provide an error message. The search however does not yield a response after publishing. Please see attached screenshot.

In the first example, for the acronym "IT Pilot", it is listed in the list of acronyms but it does not show up when you search on Bing or any of the search endpoints. The second example "ITOffice" however works since it does not have a space. In my opinion, the form should reflect an error condition if a space is included in the acronym and since it does not, I believe the note in the documentation that I added would be very helpful. In the past, I have created a support ticket and TAC was unable to resolve it as well until I was able to ascertain what the issue was.
Best,
bp

Thanks Bipin for following up! We have all the terms set to Published and waited more than 2 days for testing. I attached our current CSV file we are using for the acronym glossary. When we search in SharePoint, we find that definitions and links for 3-character acronyms appear in the results, but none of the 2-character acronyms do. Any suggestions would be much appreciated. Best regards, Ken Ken MacAllister, Senior Learning & Development Specialist Direct:<PHONE_NUMBER>tel:6048998703 | Toll Free: 1<PHONE_NUMBER>tel:18888863586 | Cell:<PHONE_NUMBER>tel:7788889478 1100 - 250 Howe Street, Vancouver, BC V6C 3S9 (desk 11-47<EMAIL_ADDRESS>| odlumbrown.comhttp://www.odlumbrown.com/ Odlum Brown: Helping clients achieve their financial goalshttps://www.odlumbrown.com/about/our-story for over 100 years From: Rakesh Kumar @.> Sent: Tuesday, March 19, 2024 9:00 AM To: MicrosoftDocs/OfficeDocs-MicrosoftSearch @.> Cc: Ken MacAllister @.>; Manual @.> Subject: Re: [MicrosoftDocs/OfficeDocs-MicrosoftSearch] Update manage-acronyms.md (PR #311) You don't often get email from<EMAIL_ADDRESS>Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification EXTERNAL EMAIL @bipinprakashtsshttps://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3135533f-454455534531-8a8fec0f9fca0702&q=1&e=6fb7e738-bc65-4ead-b442-d887f95695de&u=https%3A%2F%2Fgithub.com%2Fbipinprakashtss Acknowledging this. Could you please elaborate the issue bit more. Possibly with one example so that we can understand it better. — Reply to this email directly, view it on GitHubhttps://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3135533f-454455534531-1b74a48a0a80aea0&q=1&e=6fb7e738-bc65-4ead-b442-d887f95695de&u=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-MicrosoftSearch%2Fpull%2F311%23issuecomment-2007567621, or unsubscribehttps://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3135533f-454455534531-7c991f3d610d0464&q=1&e=6fb7e738-bc65-4ead-b442-d887f95695de&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FBHCQIMJV36PFYOBD23FLQRLYZBOGFAVCNFSM6AAAAABDIV7UGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBXGU3DONRSGE. You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>DISCLAIMER: Without the use of encryption, e-mail is not a secure medium and privacy cannot be ensured. All e-mail communication is subject to delay and may, from time to time, be undeliverable due to technical problems. If you choose to provide us with instructions by e-mail, Odlum Brown Limited expressly disclaims any responsibility to verify the accuracy or authenticity of your instructions. Odlum Brown Limited also disclaims any liability for damages or loss arising from the failure to execute any e-mail request to buy or sell securities or to make transfers of securities or monies in a timely manner, or at all. We therefore recommend that you do not send to us requests by e-mail containing confidential information or instructions. Member-Canadian Investor Protection Fund Suite 1100 – 250 Howe Street Vancouver, BC, V6C 3S9 | 1-888-886-3586 | odlumbrown.com http://www.odlumbrown.com | @.@.@.@.@.@.%20Ref.%20No.%20OBLTR10104116,%20Subject:%20RE:%20[MicrosoftDocs/OfficeDocs-MicrosoftSearch]%20Update%20manage-acronyms.md%20(PR%20#311),%20Date:%20%20Tuesday,%2019%20March%202024>

Hi,
Are you able to add a two letter acronym manually to see if it shows up? Besides that, I would be inclined to reach out to support to see if they could help. I wish I had a better response for you. I was able to add a test two letter acronym was able to get it to show up and this was done via the CSV upload so it might be an issue with something on the tenant would be my only guess. Please see screenshot.
Regards,
Bipin

Thanks for your help Bipin, very much appreciated. I will follow up with Microsoft Support.
Ken
Ken MacAllister, Senior Learning & Development Specialist
Direct:<PHONE_NUMBER>tel:6048998703 | Toll Free:  1<PHONE_NUMBER>tel:18888863586 | Cell:<PHONE_NUMBER>tel:7788889478
1100 - 250 Howe Street, Vancouver, BC  V6C 3S9 (desk 11-47)
<EMAIL_ADDRESS>| odlumbrown.comhttp://www.odlumbrown.com/
Odlum Brown: Helping clients achieve their financial goalshttps://www.odlumbrown.com/about/our-story for over 100 years
From: Bipin Prakash @.>
Sent: Tuesday, March 19, 2024 12:03 PM
To: MicrosoftDocs/OfficeDocs-MicrosoftSearch @.>
Cc: Ken MacAllister @.>; Manual @.>
Subject: Re: [MicrosoftDocs/OfficeDocs-MicrosoftSearch] Update manage-acronyms.md (PR #311)
You don't often get email from<EMAIL_ADDRESS>Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
EXTERNAL EMAIL
Thanks Bipin for following up! We have all the terms set to Published and waited more than 2 days for testing. I attached our current CSV file we are using for the acronym glossary. When we search in SharePoint, we find that definitions and links for 3-character acronyms appear in the results, but none of the 2-character acronyms do. Any suggestions would be much appreciated. Best regards, Ken Ken MacAllister, Senior Learning & Development Specialist Direct:<PHONE_NUMBER>tel:6048998703 | Toll Free: 1<PHONE_NUMBER>tel:18888863586 | Cell:<PHONE_NUMBER>tel:7788889478 1100 - 250 Howe Street, Vancouver, BC V6C 3S9 (desk 11-47<EMAIL_ADDRESS>| odlumbrown.comhttp://www.odlumbrown.com/ Odlum Brown: Helping clients achieve their financial goalshttps://www.odlumbrown.com/about/our-story for over 100 years From: Rakesh Kumar @.> Sent: Tuesday, March 19, 2024 9:00 AM To: MicrosoftDocs/OfficeDocs-MicrosoftSearch @.> Cc: Ken MacAllister @.>; Manual @.> Subject: Re: [MicrosoftDocs/OfficeDocs-MicrosoftSearch] Update manage-acronyms.md (PR #311https://protect2.fireeye.com/v1/url?k=31323334-501cfaeb-3135533f-454455535732-e6b1aadab866cc41&q=1&e=95cb015d-00ba-4458-8763-bb294313b1d1&u=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-MicrosoftSearch%2Fpull%2F311) You don't often get email from<EMAIL_ADDRESS>Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification EXTERNAL EMAIL @bipinprakashtsshttps://protect2.fireeye.com/v1/url?k=31323334-501cfaeb-3135533f-454455535732-71e8c952975a8806&q=1&e=95cb015d-00ba-4458-8763-bb294313b1d1&u=https%3A%2F%2Fgithub.com%2Fbipinprakashtsshttps://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3135533f-454455534531-8a8fec0f9fca0702&q=1&e=6fb7e738-bc65-4ead-b442-d887f95695de&u=https%3A%2F%2Fgithub.com%2Fbipinprakashtss Acknowledging this. Could you please elaborate the issue bit more. Possibly with one example so that we can understand it better. — Reply to this email directly, view it on GitHubhttps://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3135533f-454455534531-1b74a48a0a80aea0&q=1&e=6fb7e738-bc65-4ead-b442-d887f95695de&u=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-MicrosoftSearch%2Fpull%2F311%23issuecomment-2007567621, or unsubscribehttps://protect2.fireeye.com/v1/url?k=31323334-501d2dca-3135533f-454455534531-7c991f3d610d0464&q=1&e=6fb7e738-bc65-4ead-b442-d887f95695de&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FBHCQIMJV36PFYOBD23FLQRLYZBOGFAVCNFSM6AAAAABDIV7UGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBXGU3DONRSGE. You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>DISCLAIMER: Without the use of encryption, e-mail is not a secure medium and privacy cannot be ensured. All e-mail communication is subject to delay and may, from time to time, be undeliverable due to technical problems. If you choose to provide us with instructions by e-mail, Odlum Brown Limited expressly disclaims any responsibility to verify the accuracy or authenticity of your instructions. Odlum Brown Limited also disclaims any liability for damages or loss arising from the failure to execute any e-mail request to buy or sell securities or to make transfers of securities or monies in a timely manner, or at all. We therefore recommend that you do not send to us requests by e-mail containing confidential information or instructions. Member-Canadian Investor Protection Fund Suite 1100 – 250 Howe Street Vancouver, BC, V6C 3S9 | 1-888-886-3586 | odlumbrown.com http://www.odlumbrown.com | @.@.@.@.@.@.%20Ref.%20No.%20OBLTR10104116,%20Subject:%20RE:%20[MicrosoftDocs/OfficeDocs-MicrosoftSearch]%20Update%20manage-acronyms.md%20(PR%20#311),%20Date:%20%20Tuesday,%2019%20March%202024>
Hi,
Are you able to add a two letter acronym manually to see if it shows up? Besides that, I would be inclined to reach out to support to see if they could help. I wish I had a better response for you. I was able to add a test two letter acronym was able to get it to show up and this was done via the CSV upload so it might be an issue with something on the tenant would be my only guess. Please see screenshot.
Regards,
Bipin
acronym.jpg (view on web)https://protect2.fireeye.com/v1/url?k=31323334-501cfaeb-3135533f-454455535732-64dbf74e91039c56&q=1&e=95cb015d-00ba-4458-8763-bb294313b1d1&u=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-MicrosoftSearch%2Fassets%2F57682179%2Fd44cbb4e-967f-4b1f-aa64-85d5479a4000
—
Reply to this email directly, view it on GitHubhttps://protect2.fireeye.com/v1/url?k=31323334-501cfaeb-3135533f-454455535732-109cc2504667f7e1&q=1&e=95cb015d-00ba-4458-8763-bb294313b1d1&u=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-MicrosoftSearch%2Fpull%2F311%23issuecomment-2007922626, or unsubscribehttps://protect2.fireeye.com/v1/url?k=31323334-501cfaeb-3135533f-454455535732-feed69da64f119d4&q=1&e=95cb015d-00ba-4458-8763-bb294313b1d1&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FBHCQIMJW4JZ5IZDBMWLVRYDYZCDVFAVCNFSM6AAAAABDIV7UGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBXHEZDENRSGY.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>DISCLAIMER: Without the use of encryption, e-mail is not a secure medium and privacy cannot be ensured. All e-mail communication is subject to delay and may, from time to time, be undeliverable due to technical problems. If you choose to provide us with instructions by e-mail, Odlum Brown Limited expressly disclaims any responsibility to verify the accuracy or authenticity of your instructions.
Odlum Brown Limited also disclaims any liability for damages or loss arising from the failure to execute any e-mail request to buy or sell securities or to make transfers of securities or monies in a timely manner, or at all. We therefore recommend that you do not send to us requests by e-mail containing confidential information or instructions. Member-Canadian Investor Protection Fund
Suite 1100 – 250 Howe Street Vancouver, BC, V6C 3S9  |  1-888-886-3586  |   odlumbrown.com http://www.odlumbrown.com   |  @.@.@.@.@.***%20Ref.%20No.%20OBLTR10104536,%20Subject:%20RE:%20[MicrosoftDocs/OfficeDocs-MicrosoftSearch]%20Update%20manage-acronyms.md%20(PR%20#311),%20Date:%20%20Tuesday,%2019%20March%202024>

Update on the two-character issue: we did some more testing, and two-character acronyms are now working. It speaking with testers, it appears that the initial tests that determined two-character acronyms weren't appearing in search results involved manually entering these, and likely not waiting long enough to see results. In recent tests, I made sure they were uploading a proper CSV file, and waiting long enough, and it appears two-character acronyms are indeed working. Thanks again Bipin and Rakesh for all of your help with this. You can mark this as resolved. All the best.

Glad you were able to get this issue resolved!
Best,
bp


Fractal painting artefact

When splitting the fractal into boxes for drawing there are black lines on the border between two boxes.

Fixed in branch enhancement/refactor-fractal


Dynamic [slug].svelte page is not updating after 2 navigation

Sorry again !
I have problem when i use a dynamic pages with svelte kit (node-adapter)
when i navigate between pages its change the first 2 diffirent pages but others does not change :(
here the [slug].svelte code

	<Jumbotron stats={data.stats} logoImg={data.club.slug} backgroundImg={getHeader(data.club.slug)}>

				<Cta mode="dark wtext">Je cours pour le {data.club.title}</Cta>

	</Jumbotron>

	<TeamInfo
		coloredtitle={getColoredTitle(data.club.title)}
		logo={getLogo(data.club.slug)}
		info={data.club.page}
	/>
	<Features />
	<Participate slug={data.club.slug} />
	<Video>

			{@html getColoredTitle(data.club.title)}

En quelques mots

			<Cta mode="dark">Je cours pour le {data.club.title}</Cta>

	</Video>

	<BannerClub />
	<HowToParticipate />
	<Gifts />
	<KitsGenerator club={data.club.page.shortname} />
	<Partners />

Please provide a complete, minimal, self-contained reproduction - and not just parts of your app.

Routes :

[slug].json.js
import { getClub } from '$lib/clubs.js'

/**
 * @type {import('@sveltejs/kit').RequestHandler}
 */
export async function get({ params }) {
    const { slug } = params;
    const club = await getClub(slug);

    /**
     * Fetch Club+Stats from Db
     */
    return {
        body: club
    }
}

[slug].json.js endpoint work normaly , the data charged correctly for each club
Example :
{
  "club": {
    "slug": "abc",
    "title": "ABC",
    "page": {
      "shortname": "AB",
      "createdAt": "1967",
      "location": "XXXX",
      "licensees": 0,
      "email": "XXXX",
      "website": "XXXX",
      "video": "XXXX",
      "story": "example of story. ...",
      "media": {
        "facebook": "https://www.facebook.com/.page"
      }
    }
  },
  "stats": {
    "amount": 0,
    "participants": 0
  }
}

Oh ! i think i know where the issue come
Im using a library svelte-inline-svg
and yeah when i give it the logo source svg link its work , after changing to page 2 the logo change to the 2 one
but after that , the logo never change anymore
Is there any way to force the component to reload with the new source ?

I am facing the same issue. Say you have a route /blog/[slug].svelte that displays 1 blog article and links to 10 other blog articles (all which use the same route /blog/[slug].svelte). You can navigate 2 times to any other articles but not a 3rd time using the client router. If you manually refresh the browser you can again navigate another 2 times before it stops working again. I hope that clears up the issue. Thanks.

@shah-mcc  Yes currect !
The solution i found is that you need to do like this
when you have the load data
export let data;
// and other things

you will need to do something like
export let data;

let current_data;
$: data,  (()=>{
  // and here you do the update (its like watch in vuejs)
  // document.title = `Page ${data.title}`;
  current_data = data;
})();

this is how i solv this issue for now , but im not sur if this is the right way to do its in svelte

@yassinrais Your workaround works. Thanks for that.
I guess the prop export let data doesn't update when the route page doesn't change (eg. going from blog/1 to /blog/2) but when we force it to be reactive with the $ symbol it updates and functions as expected.

Your welcome 😉,
This toke me some days to figure out,
The documentation of svelte its small and need really to be more bigger
Because i feel like trying to learn the svelte instead of using it for my project 😅
Im sur there is another way to do this more proply, but unfortunately im not svelte expert 🤭.
Greetings 👌

Closing this as a duplicate of https://github.com/sveltejs/kit/issues/1497


Optimize images for landing page

Description
This PR optimizes the images found on the landing page.
Measured with GTMetrix, it was found that the images had a huge impact on how the site is scored.

First PR free of charge? 😄

Thats how you hook 'em :P


Edgedb schema import/export

Is it possible to load(import migrations from file) or to save(export) migrations to .esdl file?
As far as I seen, not yet.
I want to implement this feature, but I need to discuss how would it work first.
My idea is to integrate it to cli like so:
edgedb schema export file_name.esdl
to export current database schema to file
edgedb schema import file_name.esdl to import to database
Where importing would just run
CREATE MIGRATION {file_name} TO {file_contents}
And exporting would save all the schema? From what I can see, there is only CREATE MIGRATION and GET MIGRATION, is it possible to get current schema or list of migrations via edgeql?

Hey @MrNaif2018!  This feature is on the roadmap for 1.0.  We are currently doing some preparatory work and refactoring needed to unblock this, including the ability to dump schema modules to .esdl files.
Roughly, the idea is that you start with .esdl files in your repo and use edgedb migration to generate and apply schema migrations.  This workflow is similar to that of Django and other such frameworks.  There will also be a certain level of interactivity for situations when the tool is not 100% sure about the schema change, e.g. to resolve renames vs drop/create operations etc.
We are also planning to reimplement the CLI tools in Golang for easier distribution, so we're holding off with major work on the current CLI frontend.

This approach similar to django is actually the only thing that stops me from using edgedb even now. Can I help somehow to speed this up by contributing?

Absolutely! Help is welcome. I'll open a new issue describing the overall design of edgedb migration and we can identify specific tasks there.

Will this issue be opened only after some refactor? I can start working on implementing this in any time.

Yes, I'll get to it once #705 and #710 are landed.

@elprans I'd like to help with the python bindings for this @MrNaif2018 I'd be happy to coordinate efforts (as opposed to working alone)

I am happy to coordinate efforts too. Together we can create faster and better!

I'm thinking that some portion of the parser (maybe this part?) would need to move to the python client for import validation.

We definitely don't want to be copying parsers to the client.  Most functionality in the language drivers should be thin wrappers around backend API.

Gotcha. I think I would need to wait for the top level API to be exposed before wrapping it on the client side then?

Also is there something I can help with as #710 issue which got closed? Maybe something from task list? (Cleanup issues?)

Also is there something I can help with

Writing more migration tests (see #710 and #715 for examples) would be excellent help.

I think I would need to wait for the top level API to be exposed before wrapping it on the client side then?

The CREATE MIGRATION command can already be used for the purpose of ESDL validation.

@elprans Is there a spec for .edsl files? Expected encoding, new line conventions, new line at end of file... that kind of thing?

@agritheory SDL is actually lexically identical to EdgeQL.   SDL declarations are identical in syntax to equivalent DDL commands without the CREATE or SET keywords.  The lexical structure of EdgeQL/SDL is documented here: https://edgedb.com/docs/edgeql/lexical

@elprans Thank you for that clarification, I'm getting more and more familiar with the edgeDB documentation every day. The intent of my original question was to ask if there were any specific encoding requirements for the file itself, like UTF-8/16 that need to be checked, and other things to make sure the file is syntactically correct. If this isn't spelled out anywhere, I can guess on some sane defaults and then they can be reviewed in a PR.

EdgeDB itself does not interact with *.esdl files directly, so we don't impose any restrictions how the file is actually encoded.  That said, I cannot think of any reason why anybody would want something other than UTF-8, as even Windows Notepad supports it nowadays.  As for the newlines, as long as it's a usual combination of \n and/or \r, it's fine.

To export current schema into .esdl files a DESCRIBE MODULE blah AS SDL command can be used.  The implementation of RFC 1000 in edgedb/edgedb-cli would take care of the inverse (import/migrations).


I want the code examples back on the front page!

Content Feature Request
Summary
I loved the fact that there was (runnable) code on the front page.
Motivation
I've tried to teach/introduce Rust to some people, there are still echoes that it's hard to learn. Seeing some (non-scary) code on the front page might help. Also, programming languages are about code, so we want to see code first!
I guess a good sample depends on the target audience:

Hello, world in many languages is cool if I want to learn programming, which is not the primary target audience. This is also why I've never referred people to the front page to start learning Rust.
Rayon examples are great for future "former C++ users".
WASM is another fantastic example, with the extra benefit that things can run at native speed in the browser.

Or all three, in tabs, starting with the primary audience (i'd say Rayon).
The community is also an important part of Rust, and is quite different from other programming communities. I think organising a permanent vote to elect the best code sample, where anyone can vote, would be quite nice. To avoid popularity contests, the code should be submitted in categories (submitted by beginner/advanced) and anonymised.

I don't have much of an opinion about what code should be on the front page, but it does feel surprising to me to have no code at all. I agree with the fire flower metaphor, that having a bullet list of generalizations about the language isn't really telling people what they need to know. But by the same token, people coming to a language's website probably do want to know what some code in the language looks like.

We've spent a lot of time investigating and debating about the best way to show the 'essence' of Rust, and eventually concluded that there is no "one true Rust way" - indeed, that's why we link so prominently to pages describing the areas you might want to use Rust for! You'll note that some of these pages do have code where it's appropriate, which provide a more tailored approach to introducing users to Rust code. We're happy with this approach and aren't looking at changing it at this time.

Sounds fair. Mainly I just wanted to check that you guys had thought about it. I bet a lot of other folks are going to end up asking the same question.

I strongly disagree with this decision. The lack of code examples is the cardinal sin of programming language websites. Even if it's on a secondary page devoted to code samples and not the front page, it's still something we absolutely should have (and if it is on a secondary page then it should have a prominent link on the front page).
I get that there's "no true Rust way", but as a developer, being able to see what the language looks like is really important. And the fact that we have the ability to offer an editable runnable code sample right in the browser is really compelling, I don't understand why we don't want to leverage that ability.

@kballard note that two of the "Learn More" links go to pages with code samples.
It sounds like Ashley and the team have met people who were actually turned away by an in-your-face generic code sample. I'd be curious to hear the stories. But I worry that calling it something we "absolutely should have" implies that they haven't even considered it, which of course they have.

It sounds like a decision has already been made here, but I'd just like to weigh in and say that when visiting websites for programming languages, I definitely want to see code samples — it's one of the primary things I'm interested in, even if it's not incredibly useful at first glance.
The current front page has so much whitespace, it'd be easy to fit a small sample in there, which I think would be really appreciated.

indeed, that's why we link so prominently to pages describing the areas you might want to use Rust for!

I completely understand, I wasn't aware of these discussions. I also said I wasn't particularly happy with the previous state of things. How about rolling/randomised examples, taken from a large enough list? How about links to examples from the first page?

hey folks- we are not going to put a code sample on the front page. that is decided at this point. please do not continue to comment on this issue.

This keeps getting mentioned in a lot places that decisions have already been made or that things were already discussed. I'm just curious if there's a place I can look at the discussion involved in these decisions that are now set in stone. Even if things aren't going to change at this point I would really like to know what the thought process or evidence behind the new design was, and honestly can't find any public discussion on a large set of issues that doesn't end with "this was already decided please don't talk anymore". Presumably there should be some instance where these topics were brought up for the first time and there was discussion?

Hi. This is not currently being considered at this time. I am now locking this issue as I've asked folks to cease commenting.


v0.12.x: A migration helper to disable core controller services when needed

Add a new service that allows kube-aws upgrades to disable core services (kube-apiserver, kube-controller-manager and kube-scheduler) on existing/legacy controllers by sending them a request to do so via a special configmap.
Update the handle-cluster-cidr-changes to use the functionality instead of its own custom job - which was unreliable.
The idea is to re-use this service when performing upgrades where the incoming kubernetes version is 2 or more versions newer than the existing controllers, so that we can shut-down the controller-manager and scheduler on the old controllers in order to force them to run on the new node and prevent upgrade incompatibilities.

Codecov Report

Merging #1640 into v0.12.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           v0.12.x    #1640   +/-   ##
========================================
  Coverage    38.13%   38.13%
========================================
  Files           75       75
  Lines         4647     4647
========================================
  Hits          1772     1772
  Misses        2630     2630
  Partials       245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1774526...c685308. Read the comment docs.


[release-1.4] The format of template has been changed since 1.2

This is an automated cherry-pick of #18415

this yaml will also be delivered as part of 1.4 release, creating a cherrypick...

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio_release-1.4
e6390811d91d1ef858e8c431f7bef98de1f5e149
link
/test integ-new-install-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Implement batch generator to combine foreground and background loci

The input json will have new field for background loci
The user will specify #samples for foreground and background (-1 for all)
The background_only option will dictate whether the bed file in the background_loci field of the input json will have weight as zero or one for mnll loss (e.g. in case of training background model the weight for background_loci will be 1)

Feature implemented


Assistant Creation: Tab Strip Not Engaging When Clicking On "Next"

Description
In the assistant creation flow, when navigating between the "Instructions," "Tools & Data Sources," and "Naming" sections using the 'Next' button, the section name at the top does not underline to indicate the active page. However, clicking directly on the section names updates the underline as expected.
Video
https://www.loom.com/share/460955e173b94b789c8a37ad96ff16db?sid=a9db5c45-304a-4bee-a0e1-48e5ad347cf3
Steps to Reproduce

Open the flow to create an assistant
Click 'Next' to move from one section to another (e.g., from "Instructions" to "Tools & Data Sources")
Observe that the section name at the top is not underlined to indicate the active page
Click directly on any section name (e.g., "Naming") and observe that the underline appears correctly

I cannot reproduce, tested on chrome/firefox/arc/safari

Looks like it was fixed.


[#1370] Use shellcheck rule from bazel-tools

Resolves #1370

It's not working as expected will close for now and test again next week


Hide program to system tray

Is your feature request related to a problem? Please describe.
It's just a new feature,and it's not related to any problems.If it's hard to achieve, it doesn't matter.
Describe the solution you'd like
I want to hide my program to system tray.
Describe alternatives you've considered
Emm...I have searched the Internet,but it seems that there are no solutions now.
Additional context

There is a solution,but it needs pywin32,and it's made by Python 2. In addition, this is a Chinese website. You may need Google translation.
https://segmentfault.com/q/1010000008579491

@NewbieXvwu
You don't really need pywin32. You need pytray... and some threading 🤔
pip install pytray

Here is simple solution, you might try limit amount of threads running on this function with ThreadPoolExecutor
from pystray import Icon, Menu, MenuItem
from threading import Thread
from PIL import Image
...
def run_tray():
    icon = Image.open('path\to\icon')
    menu = Menu(MenuItem('Show', show_function),MenuItem('Quit', quit_function))
    Icon('Name of tray',icon,'Title of tray',menu).run()

Thread(target=run_tray).start()
root.mainloop()

@Zeusek Thanks!


ci: test added changes

added commitment checks,
added changes for Ansible molecule test

/run molecule test

/run molecule test

/run molecule test

/run molecule test


Doesn't work for Fedora distribution

Tested on F23.
Error Message : gconftool: command not found
Please fix it. Really eager to use these beautiful terminal themes.

@Ace139 , I face this issue as well "Error Message : gconftool: command not found". However, I found workaround which is by creating another custom profile by yourself,  activate it and install the scheme. Installing scheme while using Unnamed profile will cause this issue.
cc @Mayccoll

on Fedora 24 (workstation edition). These steps worked for me
https://github.com/Mayccoll/Gogh
cd Gogh/themes && ./aci.sh

Close and launch gnome-terminal, new color theme is activated.

@Ace139 and @tfaruq, could you guys try again, but this time creating a command line script as described in here using option 2 and tell us if it worked, please?
Thanks in advance! [=

It does work for me in gnome-terminal but not the xfce terminal which is the default on Fedora 23.

@equick Perfect, then. Since it supports only Gnome and Phanteon, worked as expected.

@tfaruq tip fixed the problem on Fedora 25, just right click on console and "Profiles>Profile Preferences" in profile name change to a name of your desire, and happy new colors!

Note: In order to work, after changing the profiles name, just re-run the command once again, then close console and reopen to see the changes taking effect.

Bu! see you... :heart:


Draft boardings on home page

[-] Added functionality for button Draft Boardings on Home Page
[-] Added DraftBoardingsView with components (3 State)
[-] Added functionality for edit draft boardings and return on DraftBoardingsView
Fixes #294, #295, #296, #298

 Review PRs

When editing a draft report, the title should be Draft Boarding.

When editing a draft report, the title should be Draft Boarding.

Fixed

 Review PRs


[feature][broker] PIP 37: Support chunking with Shared subscription

Motivation
https://github.com/apache/pulsar/wiki/PIP-37%3A-Large-message-size-handling-in-Pulsar#option-1-broker-caches-mapping-of-message-uuid-and-consumerid
The cons of option 1 described in the original proposal don't exist
for current code because broker keeps redelivered messages into
sorted map now.
Modifications
First of all, to avoid too many code changes, an EntryAndMetadata
class is introduced to bind the Entry with the associated
MessageMetadata to avoid parsing the metadata repeatedly. It also
implements the Entry interface, so this PR changes some
List<Entry> parameters to List<? extends Entry> so that a
List<EntryAndMetadata> argument can be accepted.
Then, a SharedConsumerAssignor is introduced to assign a list of
entries to all shared consumers.

Use a default selector to select the next consumer, like
PersistentDispatcherMultipleConsumers#getNextConsumer,
Each time a consumer is chosen, assign the entries in range
[i, i+permits) to the consumer except entries that have uuid:

If uuid is not cached, cache uuid -> consumer to indicate the
chunked message of this uuid must be dispatched to this consumer.
Otherwise, assign this entry to the owner consumer of the uuid.

The assign method returns a map that maps Consumer to
List<EntryAndMetadata>. The following logic is similar to the
Key_Shared dispatcher.
Finally, cancel the limit in ConsumerImpl.
Verifying this change
SharedConsumerAssignorTest is added to show how the assignor works
in detail.
MessageChunkingSharedTest is added to verify the Shared dispatcher
works on chunked messages, including:

Single producer sends chunked messages with various chunk count to a
consumer has a limited permits.
Single producer sends chunked messages to two consumers to verify
both they can receive chunked messages.
Produce interleaved chunks via PersistentTopic directly to simulate
multiple producers, and verify the new consumer can receive all
unacknowledged messages received by the old consumer.

TODO
We need to change the implementation of ChunkMessageIdImpl to make
it possible for consumer to acknowledge all entries of a chunked
message.
Since this PR already includes many changes, I will do that later.
Documentation
Check the box below or label this PR directly.
Need to update docs?

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

This PR will fixes https://github.com/apache/pulsar/issues/7645

@codelipenghui @merlimat @rdhabalia @Jason918 @eolivelli @315157973 Could you take a look at this PR?

/pulsarbot rerun-failure-checks

@BewareMyPower Please help resolve the conflicts.


feat(OidcClientOptions): handle an optional client secret

@leastprivilege Hello: do you accept PR on this repo ?

Hey,
no sorry - this is more like a sample. Feel free to fork.


Error when running colab example in quickstart

I'm just running example code of colab in the readme file (quick start).
But the error comes out as below. (Part1 in the notebook)

What I did is just run cells sequentially.
I'm using colab pro+ with T4 GPU.
Thank you

Hey! This error is related to numpy version used in Colab and its compatibility with the library.
Usually, if you restart the runtime after the installation, it should resolve your issue.

Thanks, restart the session solved this problem.

Can you please close the issue if there are no more problems?


Wrong date range displayed when array of dates has only one item

If only one item of type Date is presented in $scope.data the x-axis doesn`t show it but instead shows weird date range of year 1980 to 2060.
A few examples of code:
http://jsfiddle.net/n5qsgb9e/3/
http://codepen.io/anon/pen/GJwdKy

Hi @yarick333
thanks for reporting this issue!
When there is just one element in the dataset the min and max values of this dataset are the same. Therefore, we try to "center" your datapoint and assume a min value of 0 and a max value of 2*x - which is completely wrong (in so many ways) for Date objects.
I will see how we can fix this! For now, setting the min and max options manually would be a workaround.
Best,
Christoph


Add ContainedIP() as fast way to check an IP

Hi, wondering if you would consider adding this because it gives a ~10% performance improvement in a project I work on.
Change is to avoid creating a route object, for callers that don't need it.

Sorry for responding late.
It looks good. Thank you for your contribution!


reauthorise error

After committing logout and performing /people it is not logging in automatically.

Works for me.
The only thing that does not seem to work in this context is:

logout
visit /people explicitly
after being redirected to the login, perform the login

Expected result: you are redirected to /people
Actual result: you are redirected to /
Should be a small fix, I'll happily accept a PR.

Closing this, no more input.


[ai-did-you-mean-this] Allow users to receive recommendations if they've opted out of telemetry.

Allow users who've not opted into telemetry to still receive recommendations. If the user opted out of telemetry, no user identifying data will be sent.
Related: #1975

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[X] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[X] Have you run python scripts/ci/test_index.py -q locally?

ai-did-you-mean-this

hi @fengzhou-msft @bim-msft could you pls help to review. @fengzhou-msft we should able to know user opt out of telemetry by checking az configure with parameter name right?


Active and modified tabs are confusing due to their very similar contrast

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
base16.lua tabline.lua
Description
When using base16.lua and tabline.lua together, distinguishing between the active and modified tabs becomes quite perplexing due to their very similar contrast. What more is the modified state have a slightly higher contrast than the active one, adding to the confusion.
Neovim version
NVIM v0.9.1
Steps to reproduce

Enable base16.lua and tabline.lua.
Open multiple buffers.
Modify one buffer.
Switch to a different buffer.

Expected behavior
More distinction between active and modified state, lower contrast and perhaps a  icon?
Actual behavior

Thanks for the issue!
There is not much that can be done here. Base16 has only 4 shades of background colors and 4 shades of foreground colors (or more like 2, because base06 and base07 are usually hardly distinguishable from white).
Highlight group for current tab has regular foreground with visible background, while all highlight groups for modified tabs use forground/background colors for background/foreground to make them stand out.
The reason you are not seeing much contrast is likely because there is not much contrast between light background (base01, base02) and dark foreground (base04).
I can suggest at least the following:

Tweak those base background/foreground colors for more contrast.
Redefine highlight groups of 'mini.tabline' to your liking after loading 'mini.base16'.

Closing as not a bug.


Setupmusic command is broken

When i do /setupmusic bot create the request channel then send the banner embed after 2-3 seconds leter delete his own banner embed everything

leme check


Add rucio secondary software release policy

After discussion with the main developers of the applications
@ftorradeflot, any comment or modification is more than welcome.
Co-authored-by: maany<EMAIL_ADDRESS>

After discussion with the main developers of the applications @ftorradeflot, any comment or modification is more than welcome.
Co-authored-by: maany<EMAIL_ADDRESS>
Looks good to me. Thanks @garciagenrique !


Use node['filebeat']['conf_d_dir'] instead for prospector, modules etc. configs

Prospectors, Modules etc. configuration files are not getting created with a prefix and does not require separate attribute directory location.
Also, in favor of Delete/Purge configurations.

Looks like that filebeat v6.x might add another location for prospectors.
Closing.


Readme example of bindings within celery tasks example, Support for channels v1.x

Thanks so much for this project! It was extremely helpful and the missing piece I was searching for!
I updated the Readme to include how to get model bindings to work with model instances within celery tasks.
I also updated the Reame and requirements.txt to indicate support for only channels 1.x, until #42 is resolved.

Maybe this can then be the basis for the last proper release for channels 1.x.

I would move the celery example out of the getting started. It's technically not required. I've fixed the package requirements on master


Profiles: not working - unable to create, change or update

Reported by more than one person. When fix? This is not working for more than a week guys...

forgot we had the verify account issue on beta
one of the last profile worker deployments had that code
just re-deployed production of the profile worker to a version of the code before the verify account functionality

prod of the profile worker  it's working again
kodadot.xyz

related, i opened it 4 days ago:

https://github.com/kodadot/nft-gallery/issues/10525


Modify docker build to use GOPROXY if set

This PR copies the Dockerfile and standard.mk changes from the managed-velero-operator to bring in the following changes:

Use GOPROXY if set
Cache go modules in a layer during build to improve build times
Use go1.12 and UBI for base images

/hold
for discussion

/lgtm

/lgtm

/hold cancel


load scripts in order without nesting?

Is this possible?
loadjs.ready(['moment/moment.js', 'moment/locale/es.js'], function() {
  console.log(moment);
});

If both scripts are loaded in parallel there is no guarantee if moment is loaded before locales?
I don't like nesting callbacks, you know, aka callback-hell.

@pateketrueke Loading scripts in parallel and executing them in order after the window "load" event can have some unintended side effects. Read the comments in this issue for more details:
https://github.com/muicss/loadjs/issues/1
If you're hosting the scripts yourself, one option to consider is wrapping them in aloadjs.ready() call. For example, if you wrap the source code of moment/locale/es.js in loadjs.ready('moment', function() {}) then this will accomplish what you want:
loadjs('moment/moment.js', 'moment');
loadjs('moment/locale/es.js');

@pateketrueke Let me know what you think about this feature proposal for async=false: https://github.com/muicss/loadjs/issues/4


Translation of card to languages other than English[Feature]

Short summary
Add translation possibility
Detailed description
First of all, thanks for preparing this card, it's been a great addition to the MercedeMe component!
Would it be possible to open translation to other languages, so that the card and the functions are displayed in the same language as rest of my dashboard?
Examples 🖼
No response
Additional context 🗒
No response

Hi, it was mentioned in the forum that in the future there will be a translation for entities... Now the names are taken from the original name by component, if translations for other languages will be available, I will add this feature to the card... But I will try to think of another way to add invidual translation for entity names.

Ok, so if I understood you correctly when the entities in Mercedes ME component will be translated to local language (Polish in my case) the addon would display them translated?
Or alternatively using the method you just discovered translations could be maintained directly in the addon?

In Home Assistant, there is an attribute called 'translation key' for entities that handles translations. This attribute displays the entity's name or state based on the language setting, provided the developer has included translation files for the component.
For our vehicles, ReneNulschDE's component uses these translation keys as internal names and also includes original name attributes that are displayed as the entity's name. To support this, I created translation files for the card, containing these keys and their respective translations.
I have now finished the translation for each sub card with English translation, only the translation for 'services' is missing. According to the eng file, I can then create a template for the other languages, which I will provide via Weblate and the other user can contribute his translation for the other languages. It was easier for me, because I have these keys ready since the beginning of the card development. For demonstration I send a preview for Czech lang 😅

@piotrgt Added translations in beta v1.1.0-alpha.. 😄 Can you try it and please give me feedback?

I installed updated version of the card and everything worked out of the box. After changing the language most of the descriptions, services and statuses were visible in Polish. Please see below screenshots.
Only strings that seem to be not included in translation are:

vehicle status on the main screen, which is either "locked" or "unlocked"
ignition state in the vehicle status tab

(On a side note I noticed that card name is not afected by card_mod font styling)

Yes I know, because for the sensor in the button I left the original state from HA, if you change the language directly in the system to PL, it will be in PL 😄  But probably in the final version, I will add also these states to translate into the chosen language.  Please check the file with PL translation.  Probably there will be some wrong translations, because I had it generated via translator, as well as for the other languages. Therefore I will be very glad for any PR that will help to improve the card more...
for header title use this, I set the font similarly from the app.. but you can change anything with this.
card_mod:
  style: |
    ha-card header h1 {
      font-family: arial !important;
    }

Great card! Can I just add a related request for translations of sensor names into local English, for example GBR terms:
Gas lock = Fuel filler flap lock
Deck lid = Luggage compartment
(Also, engineHoodStatus - aka Bonnet - is missing)

Hi @mrspouse , can you please edit the src/localize/string.json file, which is the base and create PR with new names?  Thanks 😄


error: raise HTTPError(http_error_msg, response=self)

When I trying to execute  the example code ,it presents a problem：
$ ghclone https://github.com/HR/Crypter/tree/master/app
Cloning into 'app'...
Traceback (most recent call last):
  File "g:\python-3.7.1\lib\site-packages\ghclone\ghclone.py", line 80, in clone
    r.raise_for_status()
  File "g:\python-3.7.1\lib\site-packages\requests\models.py", line 940, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://api.github.com/repos/HR/Crypter/contents%5Capp?ref=master

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "G:\python-3.7.1\Scripts\ghclone-script.py", line 11, in <module>
    load_entry_point('ghclone==1.1.0', 'console_scripts', 'ghclone')()
  File "g:\python-3.7.1\lib\site-packages\ghclone\ghclone.py", line 143, in main
    clone(api_req_url, rel_url, path, ref)
  File "g:\python-3.7.1\lib\site-packages\ghclone\ghclone.py", line 82, in clone
    exit_with_m('Failed to fetch metadata for ' + path, e)
TypeError: exit_with_m() takes from 0 to 1 positional arguments but 2 were given

In addition to this, when i pip the package ,it report a waring , I don't know if that will make a difference？
 WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out. (read timeout=15)")': /packages/a2/55/8f8cab2afd404cf578136ef2cc5dfb50baa1761b68c9da1fb1e4eed343c9/docopt-0.6.2.tar.gz

But it should have been installed successfully, as it show the result code:
 Installing collected packages: docopt, ghclone
  Running setup.py install for docopt: started
    Running setup.py install for docopt: finished with status 'done'
  Running setup.py install for ghclone: started
    Running setup.py install for ghclone: finished with status 'done'
Successfully installed docopt-0.6.2 ghclone-1.1.0

My envirement:
$ git --version
git version 2.21.0.windows.1

$ ghclone --version
1.1.0

When I visit this url:https://api.github.com/repos/HR/Crypter/contents\app?ref=master,it show like this:
{
"message": "Not Found",
"documentation_url": "https://developer.github.com/v3/repos/contents/#get-contents"
}

I fixed it @yansheng836 try it now. The issue was that it wasn't windows-path-compatible but it should be now.

Sorry, I don't know how to update this tool.Could you give me some suggestions?

No worries. Just pip install it again
pip install git+git://github.com/HR/github-clone#egg=ghclone

That’s still the old version
Try uninstalling it and then reinstalling it.
The current version is 1.2.0

Thank you very much.  The uninstall command $ pip uninstall git+git://github.com/HR/github-clone#egg=ghclone can work. Just like what you said, the new version tool can download the folder one of a repository.
The main reason is that I find the name of the library a bit strange, which I've never seen it. So I don't think the library can be uninstalled with this command and no have a try.

It’s just pip uninstall ghclone

I don't know why, it doesn't seem to work for me.

Open your Python site-packages path and delete the following:

ghclone-1.1.0.dist-info/*
ghclone/*

Then reinstall it
I tried 1.2.0 with a fresh Windows install just yesterday and everything worked fine.

Ok, thank you for your answer.


Updated new navigation on line 90

Data to Dataverse according to the new make.powerapps portal navigation.

Learn Build status updates of commit df19684:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

power-platform/guidance/coe/setup-auditlog.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

We made this change as part of our regular monthly docs update. Closing out here!


Redirect traffic between domU behind the same network instance through dom0 routing.

In a setup that has a edge-node running multiple apps attached to the same local network instance, drop rules between app instance behind the same network instance do not work as expected. Packets that are supposed to get dropped are marked with -1 but still allowed to pass through to their destination. This is because packets in this case are bridged and do not enter the virtual router in dom0. With flow logging packets drops happen by re-routing packets marked with -1 to a special dummy interfaces. With this patch, we stop advertising link local route from dnsmasq. This is done by sending network prefix as <IP_ADDRESS> inside DHCP response. This forces the apps to local network destined packets to dom0 virtual router.

I can see traffic from domU reaching internet as expected.
I can traffic between domUs that is supposed to get dropped gets dropped. Flow marking works as expected.

Also disabled icmp redirects on bridge interface.
Signed-off-by: Gopi krishna Kodali<EMAIL_ADDRESS>

LGTM. However, @gkodali-zededa can you please provide a brief description of a problem this is actually solving for us?

LGTM. However, @gkodali-zededa can you please provide a brief description of a problem this is actually solving for us?

@rvs Updated the PR description.

@gkodali-zededa do you have a window VM image you can spin up and verify it still works with the <IP_ADDRESS> mask?

I don't have a windows VM. Will check with customer success team.

@gkodali-zededa do you have a window VM image you can spin up and verify it still works with the <IP_ADDRESS> mask?

I don't have a windows VM. Will check with customer success team.

@eriknordmark I tested with windows and network connectivity worked fine. ACLS worked as expected.


Replace _getDebugCmd with new job name implementation

We should consider setting Job's jobName attribute in CWLToil to reflect the CWL step. The unitName attribute could be the sample name.

Christopher -- happy to migrate to the Toil approach for doing this. Is there documentation about what I should be setting for debugging? Just these two attributes for any classes derived from Job? Or are there other changes.

Just those two attributes are sufficient. #1197 improved debugging native Toil jobs by making Job.str return a reasonable name for the job, including the name of the method or class that defines them. The Job class automatically populates the 'jobName' attribute with this information. Users can also optionally set the 'unitName' attribute to whatever might help them with debugging, usually the sample's ID. Once these are set, calling str(job) will return the jobName followed by the unitName (if it's set), followed by the job's job store ID.
CWLToil is a special case since the steps aren't native Toil jobs so while the 'jobName' attribute is automatically set to a class name like CWLWorkflow, CWLGather, etc. they aren't particularly useful. The 'jobName' attribute should be set explicitly to a CWL analog (command?), but you can rely on the Job constructor to properly handle the 'unitName' parameter if you pass it when you construct a new CWL job.

@chapmanb mind if I take this over? I just ran into an unpicking error thrown by _getDebugCmd so I'm probably going to implement this rather than fix the existing method

jenkins, test this please

Christopher -- absolutely, thanks for taking this over. Apologies for being so slow and not yet having time to work on this. Much appreciated.

No worries! I have an first pass at it in #1368


Add a new metrics/alerts on barrier freshness (or barrier pending time)

Or alert on the barrier freshness? i.e. (current_timestamp - timestamp_of_the_latest_committed_barrier) > threshold
Slack Message
The problem is that we want a metrics for alerting on barrier piling up. Current barrier related metrics are not good enough:

barrier latency: It will be missing when barrier is stuck

barrier number: If interval is 1s, and we alert on 300 barriers, then it’s 300s after barrier piling up; If interval becomes 30s, then it’s 9000s when the alert is triggered.

Another idea for alert: notify when barrier latency metrics is missing for a while


Duplicate Scores

I am seeing that duplicate but not identical scores are being generated. If you go to Other Browsers and Latest, you can see this.
The interesting thing is there appears to be a high score and a lower score, the later of which is the one that shows at the end of the test.
Also, on Palemoon, a repeat test resulted in a higher score. While I get duplicates also on Firefox and Edge, they did not have this specific issue.
410	Pale Moon 25.6.0 on Windows 10	8 minutes ago
412	Pale Moon 25.6.0 on Windows 10	8 minutes ago
405	Pale Moon 25.6.0 on Windows 10	11 minutes ago
407	Pale Moon 25.6.0 on Windows 10	11 minutes ago

UPDATE: After updating Firefox to 40, I had a thought and 'Forgot' the HTML5Test. I was able to reproduce the same bug I saw in Pale Moon in Firefox. I suspect this is true for all browsers.

That duplicate scores are generated is correct. But they should not be visible. Right now every visitor of the main site also submits a result for the next version of the test. This is in preparation for the launch of the new version next week, so that I have enough results to generate the other browsers and compare pages.

Okay, but why are we generating 4 different scores? It's not just duplicates, it's two different sets of duplicates.


[BUG]: Dependencies conflict with Docker version

Describe the bug
Hi, I tried to run the project via docker as per the instructions in readme. i.e.
git clone https://github.com/open-mmlab/Amphion.git
cd Amphion
docker pull realamphion/amphion
docker run --runtime=nvidia --gpus all -it -v .:/app realamphion/amphion

However it is not successful. I got the error:
ImportError: cannot import name 'Wav2Vec2BertModel' from 'transformers' (/opt/conda/envs/amphion/lib/python3.9/site-packages/transformers/__init__.py)

Probably it is due to dependencies mismatch? For instance, env.sh has transformers==4.41.2 and pip list inside the container with the image shows transformers=4.30.2

Hello,
Did you find a solution ? I have the same issue.

@Athanaze I did not proceed, because I was looking for a really light-weight option.


Version Editor

Feature
Very useful tool would be Version Editor. Basically tool combining Loader with Standalone Publisher. Loader UI used to pick already published data and run actions on them (like deleting specific version, specific representation from multiple selection, some batch operations) and some of the Standalone Publisher functionality to add data to versions - for example add data for review to be uploaded to ftract, and so on.
[cuID:23rzdud]

Having delivery action available outside Ftrack sounds great!

Having delivery action available outside Ftrack sounds great!

that's actually already implemented. You can run delivery from Loader GUI in the tray.

Looking back at this issue over a year later - do we have any new ideas or input on this, maybe from an AYON perspective? Has anything changed?


[cacti] add cacti check

I found an image with Cacti, MySQL, and RRDtool, but an integration test was blocked by the need to configure Cacti in the web GUI with a fresh install.


Integrate with numpy.fromfile

Really useful library thanks!
I am currently trying to build a workflow where I have a very large dataset (consisting of images on disk) which I convert to batches of Numpy arrays before then writing them batch-wise to a single S3 object. Writing works well enough using boto3's mutlipart upload. However, afterwards I would like to also read this file in batches. Currently I have to first download it to disk, and then use something along the following lines to load in batches:
number_of_images=1024 # let's assume we know this
batch_size_to_read=128

number_of_batches = number_of_images / 128

image_width=300
image_height=300
channels=3
bytes_per_image=1314732 #the number of bytes used to store the array for a single image
pixels_per_image=image_width*image_height*channels

for i in range(number_of_batches)
    array_part = np.fromfile(
        file ="/path/local/file.npy",
        offset=1314732*0,#bytes
        count=pixels_per_image*batch_size_to_read,
        dtype="float32"
    )
    array_part = array_part .reshape(batch_size_to_read, image_width, image_height, channels)

    # ... do further stuff

It would very useful instead of first copying the file to disk, to be able to just replace the file with and opened s3fs file.
I did try using something like:
from s3fs.core import S3FileSystem
s3 = S3FileSystem(anon=False)

key = 'my/obejct/key.npy'
bucket = 'my-bucket'

with s3.open('{}/{}'.format(bucket, key)) as f:
        array_part = np.fromfile(file =f, ... )

but this results in io.UnsupportedOperation: fileno
EDIT:
Nevermind, I discovered that this already intergate seemlessly with numpy.frombuffer, as follows:

image_width=300
image_height=300
channels=3
bytes_per_image=1314732 #the number of bytes used to store the array for a single image
start_reading_from=5 # we'll skip the first five images
batch_size_to_read=10 #we'll read 10 images

with s3.open('{}/{}'.format(bucket, key)) as f:
    f.seek(start_reading_from*bytes_per_image)
    bytes = f.read(bytes_per_image*batch_size_to_read)
    ar=np.frombuffer(bytes, dtype="float32").copy()
    ar=ar.reshape((-1, image_width, image_height, channels))

    # ...do stuff

Indeed, exactly so. I had to do this too, a pity that numpy doesn't consider the arbitrary file-like object case, perhaps something to do with the option for memmaping.


Recurate forest2019

@trushaadeshara8  do i need to check anything specific?

@YojanaGadiya No, its sorted.
@sgebel discussion closed


Fix animaltype in seed data

This PR fixes an issue with the seed data that conflicts with the ability to set the field animaltype to unique = true, which should be used to minimize multiple entries.
Animal type bear is used twice, this fixes that.

cc: @jrmmba8314


split off yesod-markdown as GPL

I was confused by the presence of yesod-markdown on hackage.
If you have improved that package, please upload your version (if the author approves).
There is good reason to release it as a separate package: the code should be GPL. See discussion: https://github.com/ajdunlap/yesod-markdown/issues/2#issuecomment-3822757
Note that it may still be a good idea to maintain this under the same repo as you are doing now.

I agree, it's up to @ajdunlap but I would love to release a new markdown package. GPL is fine with me.

OK, been given permission to take over -- closing this. I'll release yesod-markdown 0.3.1 once yesod 0.10 and friends is on hackage.
Also, it's its own repo now, well still -- a fork of the existing one. I think I'll split out the goodies I've found useful and just drop the others and the goodie meta package... might not happen for a bit though.


hierarchical Support

The component work very good.
I wonder if it possible to add support for hierarchical sub-field like the original chart?
This way it would be possible to create sub chart filtered by term-field
Thanks
Hanoh

Dear Hanoh,
Thank you for your comment and sorry for the late reply.
You are right, support hierarchical data is essential for Kibana visualizations. I think that is possible to implement this feature. I hope I can add it soon to the plugin.
Best regards,

I agree it would make it much more useful, we would definitely use it more when it will support sub-buckets


Options to store toys used to obtain pre/postfit uncertainties in FitDiagnostics

Here's an option to save the toys that are produced when sampling the covariance matrix and that are used to obtain prefit and postfit uncertainties with FitDiagnostics. Keeping the toys allows to obtain uncertainties for any quantity constructed from those yields. This allows, as an example, to obtain yields grouping different processes or categories in a consistent way.

Interesting addition, however it is already possible to build these groupings by throwing toys externally to FitDiagnostics (with -t X) and using the trees which are stored in the output (using --savePredictionsPerToy. Since those will be fully frequentist toys, they are even more accurate.
Is there a situation where the existing method wouldn't work but this addition or otherwise this addition would be preferable?

hi @nucleosynthesis
thanks for checking this out. i had honestly not thought of throwing the toys externally. Indeed I think that approach should work better. I'm closing the PR then, sorry for the spam!


bind() function in Firebase-util.js is not working in IE, Firebase.util.join() also not working throwing errors

We are using Firebase chat application in Salesforce.
Expected result
Firebase Chat window should open with all the friends in the bottom of Salesforce community page
Actual result
Friends List not showing in Firebase chat and its making the page not responding. When debugged the page with F12 developer tools found some exceptions in the page as mentioned below.
1 . SCRIPT5022: Exception thrown and not caught
firebase-util.js, line 405 character 10
function bind(oThis) {
if (typeof this !== "function") {
// closest thing possible to the ECMAScript 5 internal IsCallable function
  new TypeError("Function.prototype.bind - what is trying to be bound is not callable");

}
2.Exception while Calling Firebase.util.join()
SCRIPT438: Object doesn't support property or method 'join'

Platform (OS): Windows
Version of Internet explorer: 9,10,11.
Could you please look into it and let us know whether it is known issue ?
Thanks & Regards,
Sobhan.

Sobhan,
Not sure what IE changed, but I've seen a couple of these reports over the last month. Since the polyfill being used here is a straight copy from MSDN, it's also a bit odd that it would fail at all. It seems most likely that something which is not a function is being passed into util.bind.
Could you start by providing the complete stack trace from the error (this may take some sleuthing on your part since it doesn't look like the debugger is giving you the complete stack at present) and a smallish repro? This would go a long ways to a quick solution.


New Config: de-duplicate setters/getters properties

As I see, there are a lot of properties duplicated in Producer and Consumer configurations.
As example:
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["receive.message.max.bytes"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["max.in.flight.requests.per.connection"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["metadata.max.age.ms"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["topic.metadata.refresh.interval.ms"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["topic.metadata.refresh.fast.interval.ms"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["topic.metadata.refresh.sparse"] = newValue.description }
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["topic.metadata.propagation.max.ms"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["topic.blacklist"] = newValue.joined(separator: ",") }
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["socket.timeout.ms"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["socket.send.buffer.bytes"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["socket.receive.buffer.bytes"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["socket.keepalive.enable"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["socket.nagle.disable"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["socket.max.fails"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaProducerConfiguration.swift:        set { self.dictionary["socket.connection.setup.timeout.ms"] = String(newValue) }

and
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["receive.message.max.bytes"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["max.in.flight.requests.per.connection"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["metadata.max.age.ms"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["topic.metadata.refresh.interval.ms"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["topic.metadata.refresh.fast.interval.ms"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["topic.metadata.refresh.sparse"] = newValue.description }
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["topic.metadata.propagation.max.ms"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["topic.blacklist"] = newValue.joined(separator: ",") }
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["socket.timeout.ms"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["socket.send.buffer.bytes"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["socket.receive.buffer.bytes"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["socket.keepalive.enable"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["socket.nagle.disable"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["socket.max.fails"] = String(newValue) }
./Sources/SwiftKafka/Configuration/KafkaConsumerConfiguration.swift:        set { self.dictionary["socket.connection.setup.timeout.ms"] = String(newValue) }

Probably, it make sense to put them into one place and de-dup this code or I miss something and that was made intentionally.
@felixschlegel could you suggest on that, please?

Good catch 😄 , this was intentional indeed because we wanted to have lightweight structs for our configurations without adding any new types to our public API that just serve code de-duplication internally. Did you have anything particular in mind to achieve deduplication here?

I was thinking of some protocol with extensions, e.g.:

public protocol KafkaConfig {
    var dictionary: [String: String] { get set }

    var socketTimeoutMs: UInt { get set }
}

public extension KafkaConfig {
    var socketTimeoutMs: UInt {
        get { self.dictionary.getUInt("socket.timeout.ms") ?? 60000 }
        set { self.dictionary["socket.timeout.ms"] = String(newValue) }
    }
}

public struct KafkaProducerConfiguration : KafkaConfig {...}

some struct that would be similar to Consumer/Producer configuration + computed property:

public struct KafkaSharedConfig {
    public var dictionary: [String: String] = [:]
}

public struct KafkaProducerConfiguration {
    var sharedSettings = KafkaSharedConfig()
    var producerDictionary: [String: String] = [:]

    var dictionary: [String: String] { producerDictionary + sharedSettings.dictionary }
}

Both approaches are very reasonable but clash with the idea of us not wanting to expose an extra type for the mere purpose of code deduplication. Still thank you for the effort and for bringing this up! 😄

Could you advise what is the reason for avoiding extra type, please?
Btw, other possibility which is not available until approx. September is to use new swift macros (since 5.9)

Generally, there is nothing speaking against this extra type. However, it just clutters our public API and we can never remove the extra type as adopters will most likely use this extra type in their codebase.
Ultimately it comes down to if you're happy to live with some duplication or if you want to add a new type to the public API that can never be removed. When implementing the configuration back then we decided to go with the former.
Btw, initially, I also wanted to use protocol extension but then we decided against it (See this PR)
And yes Swift Macros are great! However, we will probably want to support older Swift versions for still some time after September but for the future, the usage of Macros in our package is definitely worth investigating!

As @felixschlegel wrote this was an intentional move to duplicate some code. Introducing a public protocol that just reduced code duplication on our side brings the adopter of this library no benefit and just makes our lives harder in the future when we want to evolve the API.
Reducing code duplication is not always the goal when designing public APIs, but rather having correct and evolvable types. In the end, we just agreed that we can live with the duplication and avoid unnecessary protocols.

@felixschlegel, @FranzBusch thank you for your answers!
I believe that the question is closed now :)


Unclear documentation on behaviour when source URL is a directory

In the workflows page, it seems like it is going to explain how to provide directories as workflow URLs, but it actually only explains behaviour for workflow files:

When a directory is supplied as the sourceURL, Amazon Genomics CLI uses the following rules to determine the name of the main workflow file and any supporting files:

If the source URL resolves to a single non-zipped file...
The source URL resolves to a zipped file (.zip)...

Good call out. The actual behavior is the same as for a zip file (if the directory was zipped up). We should make this explicit in the docs.

Updated description of multifile workflows to include the case when the URL references a directory (see point 3 of https://aws.github.io/amazon-genomics-cli/docs/concepts/workflows/#multi-file-workflows)


Crash w/ThermalExpansion + 0.7.4

Just tried 0.7.4 and if I join a server then join a single player world, or simply join a singe player world twice, I get this crash. It doesn't happen with 0.7.1.
Crash log: https://gist.github.com/mmelvin0/f35a1a3b58d40ece696d
Steps to reproduce: join a single player world twice in one session.

For reference, here is my MineTweaker script: https://gist.github.com/mmelvin0/f62e6a031bb293317e52

I honestly have no idea... this is more a CoFH issue...


Drop centos support

CI is currently broken for all centos builds so we should drop it
See: https://github.com/voxpupuli/puppet-unbound/pull/295

seems its no longer broken, ,so dropping this


Move to Vitis

Hello are there plans to publish a version compatible from xilinx new sdk software: Vitis ?

Hello,
At this time, there are no plans to add Vitis support to this repository.
However, Weston Embedded Solutions does offer a commercial version with Vitis Support.


[3.1.1]: build fails on iOS: 'ReactNativeAvoidSoftinput-Swift.h' file not found with RN v0.70.7

Environment
Library version: 3.1.1
OS version: iOS 15,5  simulator
react native version : 0.70.7
Hermes and fabric are disabled.
I can build with version: ^3.0.3 and react native 0.70.5 but when updating react native my build fails so I also updated this library just to be sure and it still won't build.
I cleaned my node modules, build folder, derived data, everything I could think of.
Affected platforms

[ ] Android
[X] iOS

Current behavior
Build fails with 'ReactNativeAvoidSoftinput-Swift.h' file not found
BaseAvoidSoftInputEvent.mm imports "ReactNativeAvoidSoftinput-Swift.h"
Expected behavior
it should build
Reproduction
none

👋 @Lakston could you provide reproducible repo?

The same problem in IOS
"react-native": "0.71.1"
After adding this package I did
rm -rf ~/Library/Caches/CocoaPods
rm -rf Pods
rm -rf ~/Library/Developer/Xcode/DerivedData/*
pod deintegrate
pod setup
pod install
But it still doesn't work

Hi @AlekseyP18 could you provide reproduction repo?

I'll try to make a repo next week if I can, I won't have time this week !

@AlekseyP18 @Lakston fix for your issue is available in v3.1.3 🚀

Thank you for you quickly fix!)

Just confirming it works with RN v0.70.7 and v3.1.3, thanks mate !


Install support in CMake scripts?

The libmorton CMake scripts currently to not have installation directives. Would be nice to allow installing the headers to a system directory (possibly respecting the GNUInstallDirs CMAKE_INSTALL_INCLUDEDIR standard variable?). This would simplify integration of the library in complex software stacks where build is automated.

I could work on a patch if the project is willing to accept an enhancement.

Yep, we're open to enhancements :)


[BUG] ModalBottomSheet with nested NavHost breaks the Composition

Describe the bug
When nesting a NavHost inside a ModalBottomSheet content, it shows visual glitches instead of a correct Composables. By glitches I mean nested NavHost (bottom sheet content) is being displayed on the sheet and underneath the sheet, Compose is copying the content to two places and not displaying the original NavHost at all.
What it should show, blue is a main view (whole screen home NavHost), red is bottom sheet content (150.dp height).

What is shown, bottom sheet content displayed on the sheet and underneath it.

Minimal reproducible example
@Composable
fun App() {
    PreComposeApp {
        MaterialTheme {
            Column(modifier = Modifier.fillMaxSize()) {
                var showBottomSheet by remember { mutableStateOf(false) }
                val navigator = rememberNavigator()
                NavHost(
                    navigator = navigator,
                    navTransition = NavTransition(),
                    initialRoute = "/home",
                ) {
                    scene(route = "/home") {
                        Column(
                            Modifier.fillMaxSize().background(Color.Blue),
                            horizontalAlignment = Alignment.CenterHorizontally
                        ) {
                            Text("Main Title")
                            Button(onClick = { showBottomSheet = true }) {
                                Text("Show bottom sheet")
                            }
                        }
                    }
                }
                if (showBottomSheet) {
                    val sheetState = rememberModalBottomSheetState()
                    val scope = rememberCoroutineScope()
                    ModalBottomSheet(
                        sheetState = sheetState,
                        onDismissRequest = { showBottomSheet = false },
                        dragHandle = null,
                        content = {
                            val sheetNavigator = rememberNavigator()
                            NavHost(  // Sheet NavHost, when removed everything starts to work correctly
                                navigator = sheetNavigator,
                                navTransition = NavTransition(),
                                initialRoute = "/sheet",
                            ) {
                                scene(route = "/sheet") {
                                    Column(
                                        Modifier.fillMaxWidth().height(150.dp)
                                            .background(Color.Red),
                                        horizontalAlignment = Alignment.CenterHorizontally
                                    ) {
                                        Text("BottomSheet Title")
                                        Button(
                                            onClick = {
                                                scope.launch { sheetState.hide() }
                                                    .invokeOnCompletion {
                                                        if (!sheetState.isVisible)
                                                            showBottomSheet = false
                                                    }
                                            }
                                        ) {
                                            Text("Hide bottom sheet")
                                        }
                                    }
                                }
                            }
                        }
                    )
                }
            }
        }
    }
}

Repo: https://github.com/tomczyn/PreCompose-Sample
Branch with StateHolder fix: https://github.com/tomczyn/PreCompose-Sample/tree/fix
Workaround
It appears that wrapping the NavHost in StateHolder solves the problem with displaying the content, but the behavior of the bottom sheet is still a little bit bugged with this workaround. Instead, it sometimes doesn't show the showing/hidding animation of the bottom sheet correctly.
val stateHolder = remember { StateHolder() }
CompositionLocalProvider(LocalStateHolder provides stateHolder) {
    NavHost( // Sheet NavHost
    ...
}

It appears that rememberNavigator consistently returns the same Navigator. One possible workaround is to assign a unique name each time rememberNavigator is used.
Perhaps we should consider automatically assigning different names when using rememberNavigator

Thank you, that works! The most important thing is it can be very easily solved, but good point on the behavior change.


Token security fix

IMPORTANT: When creating your Pull Request, please use the following format for the title: Category - Resource Name & Section
PR Title samples:

Web development - CSS Portal & Tools
Web development - Leetcode & Challenges

Description:
Fixed the token security issues
Resource URL:

Insert the URL of the resource you're proposing

Checklist:
Before submitting your pull request, ensure that you have completed the following tasks:

[x] I have carefully reviewed and adhered to the contributing guidelines before creating this pull request.
[x] I followed the prescribed PR title template. (Check this if you're adding a resource)

fill the bracket with x. Something like this [x]

@jfmartinz I have fixed the security issues here


Algolia search 'query' deformed when used inside AWS lambda function

Hello 👋
Ran into a weird issue today.
I'm getting the Algolia search request/query from the frontend into my Lambda function which then executes the request and returns the result. The format of the request is an array like.
      [
        {
          "indexName": "indexname",
          "params": {
            "query": "querytext",
            "hitsPerPage": 7,
            "maxValuesPerFacet": 3,
            "page": 0,
            "facets": [
              "type"
            ],
            "tagFilters": "",
            "facetFilters": [
              "account_id:1"
            ]
          }
        }
      ]

After that I search using the API client
      const index = connectToIndex(ALGOLIA_APP,ALGOLIA_KEY,INDEX_NAME);
      const results = await index.search(requests);

Then the search query happens but I get 0 hits and when I console.log(results) the query field is deformed. I assume 0 hits due to the query being deformed
{
  "hits": [],
  "nbHits": 0,
  "page": 0,
  "nbPages": 0,
  "hitsPerPage": 20,
  "exhaustiveNbHits": true,
  "exhaustiveTypo": true,
  "query": "[{\"indexName\":\"indexname\",\"params\":{\"query\":\"querytext\",\"hitsPerPage\":7,\"maxValuesPerFacet\":3,\"page\":0,\"facets\":[\"type\"],\"tagFilters\":\"\",\"facetFilters\":[\"account_id:1\"]}}]",
  "params": "query=%5B%7B%22indexName%22%3A%indexname%22%2C%22params%22%3A%7B%22query%22%3A%22querytext%22%2C%22hitsPerPage%22%3A7%2C%22maxValuesPerFacet%22%3A3%2C%22page%22%3A0%2C%22facets%22%3A%5B%22type%22%5D%2C%22tagFilters%22%3A%22%22%2C%22facetFilters%22%3A%5B%22account_id%3A1%22%5D%7D%7D%5D",
  "renderingContent": {},
  "processingTimeMS": 1
}

but ideally the results should be like below (This is what I get when I console.log on an express server and I get the desired hits. Notice how it sends an object with a results field and the query attribute contains only the searched text)
{ results:
   [ { hits: [Array],
       nbHits: 20,
       page: 0,
       nbPages: 3,
       hitsPerPage: 7,
       facets: [Object],
       exhaustiveFacetsCount: true,
       exhaustiveNbHits: true,
       exhaustiveTypo: true,
       query: 'querytext',
       params:
        'query=querytext&hitsPerPage=7&maxValuesPerFacet=3&page=0&facets=%5B%22type%22%5D&tagFilters=&facetFilters=%5B%22account_id%3A1%22%5D',
       index: 'indexname',
       renderingContent: {},
       processingTimeMS: 1 } ]
}

Any idea what I did wrong 🤔 since I'm getting different results using the same method on lambda and express.

The first argument to index.search is the query, however you probably meant to do client.search(requests), not client.initIndex().search(query, params)

Contributor

Oof
yeah that was the issue.


LinkText should be decoded always

Pages' links are in languages that are written in non-ascii characters should be decoded in order to appear in the correct way.
For example, a link that is written in Arabic, and should be shown as كتابة 50 تدوينة خلال السنة is shown as %D9%83%D8%AA%D8%A7%D8%A8%D8%A9%2050%20%D8%AA%D8%AF%D9%88%D9%8A%D9%86%D8%A9%20%D8%AE%D9%84%D8%A7%D9%84%20%D8%A7%D9%84%D8%B3%D9%86%D8%A9.
This can be fixed easily be using decodeURI JavaScript's method.

@yshalsager Thanks for submitting your issue, the example of Arabic, and the fix! I'll try to have the change merged in soon.

@yshalsager Would you mind giving this another test and letting me know if it's properly fixed? Thank you! :heart:


Map not responsive if maxZoom is > maxNativeZoom in leaflet > 1.0.3

How to reproduce

Leaflet version I'm using: 1.2.0
Browser (with version) I'm using: Google Chrome 61.0.3163.100
OS/Platform (with version) I'm using: Windows 10

Try to zoom the map with leaflet version 1.2.0: https://plnkr.co/edit/3CszXfN7E1ZuSoJSdJog?p=preview
Try to zoom the same map with leaflet version 1.0.3: https://plnkr.co/edit/OvZ88JXjVZfFZWARE0wo?p=preview
What behaviour I'm expecting and which behaviour I'm seeing
The map should remain responsive, even if maxZoom > maxNativeZoom
See also comments following https://github.com/Leaflet/Leaflet/issues/5644#issuecomment-335219206

Thank you for the separate report.
If my understanding is correct, the 2 plunkers you provide are demonstrations of the same issue as #5644, i.e. tiles not loading if [minNativeZoom; maxNativeZoom] and [minZoom; maxZoom] do not overlap.

In my actual app the map does actually draw until it reaches maxNativeZoom, but as soon as zoom > maxNativeZoom the tab becomes unresponsive.

Please can you provide more details about this other issue and a reproduction case?
Otherwise I doubt we could investigate what could be causing such issue.
I could not get any tab freezing in Chromium or Firefox (Ubuntu) with the provided Plunkers.

Sorry for not being clear enough. I also hat a lot of trouble to save plunkers. Is it better now?

Thank you for the updated Plunkers.
If my understanding is correct, you have a "standard" case where maxNativeZoom is within [minZoom; maxZoom].
L.tileLayer(urlTemplate, {
  minZoom: 0,
  maxZoom: 22,
  maxNativeZoom: 18
})

That should normally be well covered by the released Leaflet version, but there is always the possibility for a bug of course.
After correcting the PR code so that it is usable directly within a browser, I could not reproduce your issue in Chromium or Firefox (Ubuntu):
https://plnkr.co/edit/4uhCi3qgqGpRfZHOdEQj?p=preview
Tried with master version (at https://github.com/Leaflet/Leaflet/commit/93be1ae0a72737e98fe5b61b8090174f7128cb61), v1.2.0, with and without PR #5634 re-applied.

Yep, your plunker (https://plnkr.co/edit/4uhCi3qgqGpRfZHOdEQj?p=preview) does not display this behaviour.
It is not quite clear to me why mine (https://plnkr.co/edit/3CszXfN7E1ZuSoJSdJog?p=preview), using v1.2.0, behaves differently though.
Oh. I just realized: I had copied  from your plunker. Without that my plunker works fine. Even when I use the exact same settings as in my project.
So it remains a mistery why in my project tabs freeze when using v1.2.0 but not when using v1.0.3 :-(

To be more precise: My project freezes the tab the moment zoom is > maxNativeZoom. And the layers configuration is:
import React from 'react'
import { TileLayer } from 'react-leaflet'

const OsmColorLayer = () => (
  <TileLayer
    url="//{s}.tile.openstreetmap.org/{z}/{x}/{y}.png"
    attribution="© OpenStreetMap"
    maxNativeZoom="19"
    minZoom="0"
    maxZoom="22"
  />
)

export default OsmColorLayer

I see you are using Leaflet through react-leaflet.
Please have you investigated the possibility that the issue might come from this wrapper library?
Please understand that we do not provide support ourself for such wrappers.
I do not exactly know how react and react-leaflet work unfortunately.
I hope the string values that you pass to options like maxNativeZoom are parsed into integers when provided to Leaflet.
That being said, since you say that just upgrading Leaflet from 1.0.3 to 1.2.0 triggers your bug, it is possible that something changed in Leaflet internally, that react-leaflet was using and now gets broken.
The closer I could see from the current situation would be issue https://github.com/Leaflet/Leaflet/issues/5316 with its associated PR https://github.com/Leaflet/Leaflet/pull/5319.

@ghybs You are right, it is react-leaflet that causes this behaviour. I could finally isolate it clearly: https://github.com/PaulLeCam/react-leaflet/issues/396

https://github.com/Leaflet/Leaflet/issues/5895#issuecomment-486815449 may or may not be helpful.


Error: Failed to read variables file │  │ Given variables file ../CazD_Xxx/azure-xx/terraform.tfvars │ does not exist.

Hello Team,
I am getting below error when I am running azure pipeline with terraform.
This is the error "Error: Failed to read variables file
│
│ Given variables file ../CazD_Terraform/azure-resources/terraform.tfvars
│ does not exist.
"
This is ymal file..

task: TerraformTaskV3@3
displayName: 'Terraform : azurerm plan'
inputs:
command: plan
workingDirectory: CazD_Terraform/azure-resources
commandOptions: '-input=false -var rgname=$(rgname) -var location=$(location) -var environment=$(environment) -var-file="../CazD_Terraform/azure-resources/terraform.tfvars"'
environmentServiceNameAzureRM: 59149adc-xxxxx
backendServiceArm: 59149adc-xxxxxx
backendAzureRmKey: "'tf/terraform.tfstate'"
task: TerraformTaskV3@3
displayName: 'Terraform : azurerm  validation'
inputs:
command: 'validate'
task: TerraformTaskV3@3
displayName: 'Terraform : azurerm  apply- Deploy azure Resource Groupe'
inputs:
command: apply
workingDirectory: CazD_Terraform/azure-resources
commandOptions: '-input=false -var rgname=$(rgname) -var location=$(location) -var environment=$(environment) -var-file="../CazD_Terraform/azure-resources/terraform.tfvars"'
environmentServiceNameAzureRM: 59149adcxxxxxxx
backendServiceArm: 59149adcxxxxxxx

../CazD_Terraform/azure-resources/terraform.tfvars does not seem to be the correct path.
your workingDirectory is set to CazD_Terraform/azure-resources.
I would use  $(Pipeline.Workspace) or $(Build.SourcesDirectory)  and then  as working dir.
ex  workingDirectory: $(Build.SourcesDirectory)/CazD_Terraform/azure-resources
and then use:  -var-file='terraform.tfvars'
As I don't know your your specific folder structure and the steps before so you might need to append whatever folderpath you have as the workingdirectory

Closing this due to inactivity. If you still have problems  create a new issue or just respond back here.


CLI 5.0.0, migration to the new lambda layer error, S3 Error Code: NoSuchKey

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v16.3.0
Amplify CLI Version
5.0.0
What operating system are you using?
cloud9 Ubuntu
Amplify Categories
function
Amplify Commands
push
Describe the bug
While migrating to amplify cli 5.0.0, the lambda layers are automatically updated.
Then I do a simple amplify push.
At the end of the execution it will always produce:
Resource is not in the state stackUpdateComplete
An error occurred during the push operation: Resource is not in the state stackUpdateComplete
As I trace back the errors are always at the lambda layers update, and it will provide this reason:
Error occurred while GetObject. S3 Error Code: NoSuchKey. S3 Error Message: The specified key does not exist.
Expected behavior
✔ All resources are updated in the cloud
Reproduction steps
npm install -g @aws-amplify/cli
amplify push
GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
No response

Apparently my cloud backend environment definition differs from my local ennviroment. Not sure on how that happened. However, an amplify pull  to fetch the cloud backend fix the issue.