Add a bhyve VM backend

Codecov Report

Merging #1150 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1150   +/-   ##
======================================
  Coverage    67.1%   67.1%
======================================
  Files         120     120
  Lines       20739   20739
======================================
  Hits        13916   13916
  Misses       6161    6161
  Partials      662     662

Impacted Files
Coverage Δ

vm/vm.go
80.86% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d28f4ce...8c96c09. Read the comment docs.

Is anyone interested in reviewing the patch?

I've set up a FreeBS host with ZFS and will give it a try tomorrow or Wednesday....

I've set up a FreeBS host with ZFS and will give it a try tomorrow or Wednesday....

Thanks! No rush.

I've skimmed through vm/bhyve/bhyve.go and looks good to me. I did not read into details, though. It's pity we still require so much boilerplate from each vm impl, but that's another story.
I will leave this to @tuexen for FreeBSD details.

@markjdb OK, with the latest version it runs on my machine with 22 VMs. That is really great!
However, there is one issue I observed. When starting with the -debug option, I get:
tuexen@wks2:~/go/src/github.com/google/syzkaller % sudo bin/syz-manager -config freebsd.config -debug
2019/05/11 14:24:20 limiting number of VMs from 22 to 1 in debug mode
2019/05/11 14:24:20 loading corpus...
2019/05/11 14:24:20 serving http on http://<IP_ADDRESS>:10000
2019/05/11 14:24:20 serving rpc on tcp://[::]:41032
2019/05/11 14:24:20 booting test machines...
2019/05/11 14:24:20 wait for the connection from test machine...
Error return from kevent change: Operation not supported by device
GDB: no debug ports present
KDB: debugger backends: ddb
KDB: current backend: ddb
---<<BOOT>>---
Copyright (c) 1992-2019 The FreeBSD Project.
Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994
        The Regents of the University of California. All rights reserved.
FreeBSD is a registered trademark of The FreeBSD Foundation.
FreeBSD 13.0-CURRENT SYZKALLER amd64
FreeBSD clang version 8.0.0 (tags/RELEASE_800/final 356365) (based on LLVM 8.0.0)
WARNING: WITNESS option enabled, expect reduced performance.
VT: init without driver.
CPU: Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz (2194.62-MHz K8-class CPU)
  Origin="GenuineIntel"  Id=0x406f1  Family=0x6  Model=0x4f  Stepping=1
  Features=0x9f83fbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,MMX,FXSR,SSE,SSE2,SS,HTT,PBE>
  Features2=0xfede7a17<SSE3,PCLMULQDQ,DTES64,DS_CPL,SSSE3,SDBG,FMA,CX16,xTPR,PCID,DCA,SSE4.1,SSE4.2,MOVBE,POPCNT,AESNI,XSAVE,OSXSAVE,AVX,F16C,RDRAND,HV>
  AMD Features=0x24100800<SYSCALL,NX,Page1GB,LM>
  AMD Features2=0x121<LAHF,ABM,Prefetch>
  Structured Extended Features=0x40f39<FSGSBASE,BMI1,HLE,AVX2,BMI2,ERMS,INVPCID,RTM,RDSEED>
  XSAVE Features=0x1<XSAVEOPT>
Hypervisor: Origin = "bhyve bhyve "
real memory  = 536870912 (512 MB)
avail memory = 464801792 (443 MB)
Event timer "LAPIC" quality 600
^CSIGINT: shutting down...

I'm wondering where the error message
Error return from kevent change: Operation not supported by device

is coming from.  Do you have an idea?
This is the contents of freebsd.config:
{
        "name": "freebsd",
        "target": "freebsd/amd64",
        "http": ":10000",
        "workdir": "/home/tuexen/workdir",
        "syzkaller": "/home/tuexen/go/src/github.com/google/syzkaller",
        "image": "/zroot/syzkaller/syzkaller.img",
        "kernel_obj": "/home/tuexen/debug-info/",
        "kernel_src": "/usr/home/tuexen/head/sys/",
        "sshkey": "/home/tuexen/.ssh/id_rsa",
        "sandbox": "none",
        "procs": 1,
        "type": "bhyve",
        "vm": {
                "count": 22,
                "bridge": "bridge0",
                "hostip": "<IP_ADDRESS>",
                "dataset": "zroot/syzkaller"
        }
}

@markjdb OK, with the latest version it runs on my machine with 22 VMs. That is really great!

I've been running a 30-instance config for the past couple of weeks and haven't seen any problems. :)
Next I plan to document setting up the CI system on FreeBSD. I also have some patches to dump DDB info from the console when we hit the "no output from test machine" failure, and am thinking about how we can auto-configure netdump in the VMs.

I'm wondering where the error message
Error return from kevent change: Operation not supported by device

is coming from. Do you have an idea?

It is from bhyve. It occurs when redirecting the VM console stdio streams and appears to be harmless. I have a todo entry to fix it (the error pops up in other places, for example when using the GDB debug server).

@markjdb OK, with the latest version it runs on my machine with 22 VMs. That is really great!

I've been running a 30-instance config for the past couple of weeks and haven't seen any problems. :)
Next I plan to document setting up the CI system on FreeBSD. I also have some patches to dump DDB info from the console when we hit the "no output from test machine" failure, and am thinking about how we can auto-configure netdump in the VMs.

I'm wondering where the error message
Error return from kevent change: Operation not supported by device

is coming from. Do you have an idea?

It is from bhyve. It occurs when redirecting the VM console stdio streams and appears to be harmless. I have a todo entry to fix it (the error pops up in other places, for example when using the GDB debug server).

OK. Great. Then I'll merge this since @dvyukov indicated already that he is fine with the change and that issue is not related to syzkaller.

Thanks, but it looks like the two commits were squashed? They should have been kept separate.

Thanks, but it looks like the two commits were squashed? They should have been kept separate. I guess it cannot be changed now.

When merging I choose "Squash and merge" since I though getting the functionality and the documentation for it should be in one commit since they depend on each other. Sorry for not getting that you wanted it to go in separately.


Allow specifying the link in debug console

@roblourens
Problem Statement
If I use a custom logger that implements the imported console.log because I want to see the logs in the debug window, the links all point to where I called console.log, not where I called my custom logger.
Contrived Example

Feature Request
vscode's console.log should have an optional additional argument to specify the link to the log in the debug window.
Workaround
The Debug console will render path links. This is noisy but it works.

The recommended way to deal with this is to use the skipFiles option in your launch config. The location we show on the log output will be the first non-skipped location in the stack trace.

@connor4312 nice, is this documented anywhere?

It's under one of the bullets here. Yes, it's a little hard to find since you sort of have to know to look for it.


Failed to flash verzion gs4 sch-I545

I am on Ubuntu 14.04.  I tried with the most recent package (heimdall v1.4) and also tried building the most recent master branch from source but both resulted in failures:
Attempt from apt-get install (v1.4 of heimdall) I get a failure to upload:
$ sudo heimdall flash --BOOT boot.img
Heimdall v1.4.0

Copyright (c) 2010-2013, Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/

This software is provided free of charge. Copying and redistribution is
encouraged.

If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/

Initialising connection...
Detecting device...
Claiming interface...
Attempt failed. Detaching driver...
Claiming interface again...
Setting up interface...

Initialising protocol...
Protocol initialisation successful.

Beginning session...

Some devices may take up to 2 minutes to respond.
Please be patient!

Session begun.

Downloading device's PIT file...
PIT file download successful.

Uploading BOOT
100%
ERROR: Failed to confirm end of file transfer sequence!
ERROR: BOOT upload failed!

Ending session...
Rebooting device...
Releasing device interface...
Re-attaching kernel driver...

When I build from latest master branch I can't even establish the protocol:
$ sudo ~/git/Heimdall/heimdall/heimdall flash --BOOT boot.img
Heimdall v1.4.1

Copyright (c) 2010-2014 Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/

This software is provided free of charge. Copying and redistribution is
encouraged.

If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/

Initialising connection...
Detecting device...
Claiming interface...
Attempt failed. Detaching driver...
Claiming interface again...
Setting up interface...

Initialising protocol...
ERROR: Protocol initialisation failed!

Releasing device interface...
Re-attaching kernel driver...

how we flash custom system.img on verizon models because these devices bootloader locked.
i want flash without root and without bootloader unlock


demo install puzzle

when install this demo, I am confused at add contents of the vlc version package you want to use to your app's root folder, what does this sentence mean?Do I need to download the vlc package and install first?
I check the vlc website there ary two kinds of package: desktop and webplug, which package suit for this demo?
thank you for you information, thanks!

What OS do you use?

@RSATom Mac osx 64 bit v10.10.5, I am wander how to add vlc to your demo?

You should download this and extract it near the WebChimera.js.node

You can't use vanilla vlc, since it's broken on Mac atm. Mentioned above archive contains all the same modules as vanilla vlc, but reorganized a little to workaround this bug in libvlc.

Sorry, but I am still confusing at: You should download this and extract it near the WebChimera.js.node, from your git repository, where is the WebChimera.js.node posititon?

something like this: node_modules/wcjs-player/node_modules/wcjs-renderer/node_modules/webchimera.js/build/release

As your guied, I can now run nw.js under this repository, it works, thanks so much!
I have another 2 question:

when playing some media files,it  corruption, error info:

hxz@pc0170:~/workspace/nw.js/node-vlcPlayer-demo$ nw .
[41889:1022/161354:WARNING:dns_config_service_posix.cc(151)] dns_config has unhandled options!
[00007fe229c51c98] core audio output error: option auhal-volume does not exist
[00007fe229c51c98] core audio output error: option auhal-audio-device does not exist
[00007fe22c036c38] core access error: option http-forward-cookies does not exist
[00007fe22c036c38] core access error: option http-referrer does not exist
[00007fe22c036c38] core access error: option http-proxy does not exist
[00007fe22c036c38] core access error: option http-reconnect does not exist
[00007fe22c036c38] core access error: option http-continuous does not exist
[00007fe22c036c38] core access error: option socks does not exist
[00007fe22c036c38] core access error: option ipv4-timeout does not exist
[00007fe229d510f8] core demux error: option sap-parse does not exist
[00007fe229d510f8] core demux error: option quiet does not exist
[00007fe229d510f8] core demux error: option avformat-format does not exist
[00007fe229d510f8] core demux error: option avformat-options does not exist
[00007fe22a0588b8] core decoder error: option quiet does not exist
[00007fe22a0588b8] core decoder error: option avcodec-codec does not exist
[00007fe22a0588b8] core decoder error: option avcodec-debug does not exist
[00007fe22a0588b8] core decoder error: option avcodec-workaround-bugs does not exist
[00007fe22a0588b8] core decoder error: option avcodec-error-resilience does not exist
[00007fe22a0588b8] core decoder error: option grayscale does not exist
[00007fe22a0588b8] core decoder error: option avcodec-vismv does not exist
[00007fe22a0588b8] core decoder error: option avcodec-skiploopfilter does not exist
[00007fe22a0588b8] core decoder error: option avcodec-fast does not exist
[00007fe22a0588b8] core decoder error: option avcodec-hurry-up does not exist
[00007fe22a0588b8] core decoder error: option avcodec-skip-frame does not exist
[00007fe22a0588b8] core decoder error: option avcodec-skip-idct does not exist
[00007fe22a0588b8] core decoder error: option avcodec-dr does not exist
[00007fe22a0588b8] core decoder error: option avcodec-threads does not exist
[00007fe22a0588b8] core decoder error: option avcodec-options does not exist
[00007fe229c51c98] core audio output error: option spdif does not exist
[00007fe22b11a8b8] core spu text error: option freetype-font does not exist
[00007fe22b11a8b8] core spu text error: option freetype-monofont does not exist
[00007fe22b11a8b8] core spu text error: option freetype-fontsize does not exist
[00007fe22b11a8b8] core spu text error: option freetype-opacity does not exist
[00007fe22b11a8b8] core spu text error: option freetype-bold does not exist
[00007fe22b11a8b8] core spu text error: option freetype-outline-thickness does not exist
[00007fe22b11a8b8] core spu text error: option freetype-outline-opacity does not exist
[00007fe22b11a8b8] core spu text error: option freetype-outline-color does not exist
[00007fe22b11a8b8] core spu text error: option freetype-shadow-opacity does not exist
[00007fe22b11a8b8] core spu text error: option freetype-shadow-color does not exist
[00007fe22b11a8b8] core spu text error: option freetype-shadow-angle does not exist
[00007fe22b11a8b8] core spu text error: option freetype-shadow-distance does not exist
[00007fe22b9692b8] core scale error: option swscale-mode does not exist
[00007fe22a9810b8] core filter error: option swscale-mode does not exist
[00007fe22b11a8b8] core spu text error: option freetype-font does not exist
[00007fe22b11a8b8] core spu text error: option freetype-monofont does not exist
[00007fe22b11a8b8] core spu text error: option freetype-fontsize does not exist
[00007fe22b11a8b8] core spu text error: option freetype-opacity does not exist
[00007fe22b11a8b8] core spu text error: option freetype-bold does not exist
[00007fe22b11a8b8] core spu text error: option freetype-outline-thickness does not exist
[00007fe22b11a8b8] core spu text error: option freetype-outline-opacity does not exist
[00007fe22b11a8b8] core spu text error: option freetype-outline-color does not exist
[00007fe22b11a8b8] core spu text error: option freetype-shadow-opacity does not exist
[00007fe22b11a8b8] core spu text error: option freetype-shadow-color does not exist
[00007fe22b11a8b8] core spu text error: option freetype-shadow-angle does not exist
[00007fe22b11a8b8] core spu text error: option freetype-shadow-distance does not exist
[00007fe229c86478] core vout display error: Failed to change zoom
[00007fe229c86478] core vout display error: Failed to set on top
[00007fe229c86478] core vout display error: Failed to change source AR
[00007fe229c51c98] core audio output error: option volume-save does not exist
[00007fe22b88dab8] core audio filter error: option scaletempo-stride does not exist
[00007fe22b88dab8] core audio filter error: option scaletempo-overlap does not exist
[00007fe22b88dab8] core audio filter error: option scaletempo-search does not exist

I dont't want to define the media url to some website address, can I assign local file address to it?or maybe there are some relevant api?

1.when playing some media files,it corruption, error info:

try run regular vlc with -vvv command line option and look messages there. If it will be the same - then it's better ask Videolan team about it. If you will not see such messages there - it's possible, embedded libvlc could not load some plugin by some reason - it's require some investigation then.

2.I dont't want to define the media url to some website address, can I assign local file address to it?or maybe there are some relevant api?

Yes, you can. Just add 'file://' prefix to the full path to media. You could get more details from Vlc wiki: https://wiki.videolan.org/Media_resource_locator/

Can it be closed?


chore(package): update eslint to version 3.10.2

https://greenkeeper.io/ did this, yay!
Works fine, think there was a blip with an eslint minor release.

Coverage remained the same at 83.333% when pulling d911cd3cecb66239bffed01f6b68c27de8a5309d on greenkeeper/eslint-3.10.2 into 417f359e69d3214a4e3c1f9b975f065fb81c4c97 on master.

Coverage remained the same at 83.333% when pulling d911cd3cecb66239bffed01f6b68c27de8a5309d on greenkeeper/eslint-3.10.2 into 417f359e69d3214a4e3c1f9b975f065fb81c4c97 on master.


Firmware update downloads/installs intelnuc firmware on rpi3

Describe the bug
I just tried to update RaspberryMatic from version <IP_ADDRESS>91026 to the newest version, on a rpi3 (The ELV case, RaspberryMatic CCU3).
There are two sub-issues:

There seem to be two alternative way to update the system and it is not clear which one is the preferred one. There should be only one way for clarity. (There is Einstellungen -> System Steuerung -> Zentralen Wartung, and there is Einstellungen -> System Steuerung -> System-Update.)

Using the method "Einstellungen -> System Steuerung -> System-Update -> Aktuellste Firmware Installieren" resulted in downloading and apparently installing the "intelnuc" version, plus some git hash in the filename, not the newest release released on github. After the installation I ended up in some kind of recovery mode. After a normal reboot I was back in the working old rpi3 firmware.

The bugs are:

On an rpi3 system it should never even start to download the intelnuc version.
It should not attempt to unpack and install it.

I am right now trying the other way through "Zentralen Wartung" which requires me to manually select the file which matches my hardware (rpi3 in my case I assume).
To Reproduce
Steps to reproduce the behavior:
0. On RaspberryMatic <IP_ADDRESS>91026 on an rpi3:

Go to Einstellungen -> System Steuerung -> System-Update
Click on Aktuellste Firmware Installieren
See downloaded filename containing intelnuc and not matching the latest released version number (but an even later one).

Expected behavior
When clicking on "Aktuellste Firmware Installieren" I expect the latest released firmware to be installed.
Screenshots
If applicable, add screenshots to help explain your problem.
System information (please complete the following information):

RaspberryMatic from version <IP_ADDRESS>91026
RaspberryPi3 (RaspberryMatic CCU3 in the ELV case).

Sorry, but in a standard environment there is no Einstellungen -> System Steuerung -> System-Update menu entry. This is coming from a dedicated third-party addon named "rmupdate" (see https://github.com/j-a-n/raspberrymatic-addon-rmupdate). The standard and default RaspberryMatic/CCU way of updating to newer firmware version is to use Einstellungen -> System Steuerung -> Zentralen Wartung. The other one is introduced by the named CCU Addon which you can find under Einstellungen -> Zusatzsoftware.
So please forward your problems to the author of this third-party addon or use the only official way to update via Einstellungen -> System Steuerung -> Zentralen Wartung. And yes, currently you have to manually download the firmware and then upload it to your RaspberryMatic system. But this is intentially and no bug.


Add gemfiles for rails 4.x

fixes #47

Coverage increased (+0.01%) when pulling 9e63e2777e249d103fc6d988567afc8f02734c96 on add-gemfiles-for-rails-4.x into f20c660b0a3f054006e1d5f2e8df485047943802 on master.

do not understand how & where FlexMock was used for ?
can you explain and how it was removed ?
was used only for mocking database connection ?

this gem provides support for caching AR queries. ie, with older versions of rails, if we do TaxRate.all, it will fetch tax rates from db for the first time, and for subsequent TaxRate.all queries, it will return records from the cache it maintains. But, since rails 3.2 +, and 4+ support caching query results out of box, i dont think we should support caching records feature. FlexMock was used to test this feature.

Coverage increased (+0.05%) when pulling 9ef184a11885e4ece0deb1d4e0ee4927d218f9df on add-gemfiles-for-rails-4.x into f20c660b0a3f054006e1d5f2e8df485047943802 on master.


Html/css

te a full descript

Hi @Paul-tes,
This is Adnan Is-haq, your beloved code reviewer,
You've done a very good job so far, but a few things still need to be worked on before moving on to the next project, but you're so close!

Highlights

Nice one leaving more than one comment.

Required Changes ♻

[ ] Kindly consider using GitHub inline comments as it is a requirement for the project 🙂.

[ ] For your comments to be professional, kindly consider making the purpose of suggesting this change clear and understandable. 👍 💻 Please take a look at the following example:
Example of a vague comment:

The README is not descriptive, why don't you make it better?

Example of a clear comment:

The README's "Built With" and "Getting Started" sections are currently empty. Why don't you add content, listing the technology used in the project and how to run it, to them so your README is more informative and professional?

[ ] For your comments to be professional, kindly consider making the purpose of suggesting this change clear and understandable. I would also advise you to give detailed reasons why you are suggesting a change. 😎 👍 Please take a look at the following examples below:
Example of vague comment:

The README is not descriptive, why don't you make it better?

Example of clear comment:

The README's "Built With" and "Getting Started" sections are currently empty. Why don't you add content, listing the technology used in the project and how to run it, to them so your README is more informative and professional?

Example of a unexplained comment:

Why don't you use an article tag here instead of a div?

Example of a properly explained comment:

Why don't you use an article tag for the .first-article element instead of a div, that would improve the HTML structure and make the page more accessible

[ ] Please, try not to be too condescending 😄.
I suggest you use phrases like I suggest, kindly, Please consider, or what is your opinion on.

Optional suggestions

[ ] It would be nice to use emojis when making comments. Using an emoji makes your comment sound polite and friendly. It makes it easier to communicate with as a reviewer. 👽🤖 😁

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


broadcast after resource status updated in db

make test
OCM_ENV=testing gotestsum --jsonfile-timing-events=/home/cloud-user/go/src/github.com/openshift-online/maestro/unit-test-results.json --format short-verbose -- -p 1 -v
./pkg/...
./cmd/...

Random Seed:<PHONE_NUMBER>

Will run 5 of 5 specs
•••••
Ran 5 of 5 Specs in 4.137 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
Ginkgo ran 1 suite in 8.90856437s
Test Suite Passed

/cc @morvencao @clyang82 @qiujian16


Overlapping Text In Edge Only

I'm generating a multi-page pdf with the use html2canvas The text overlaps if the element text is greater than two lines and bold.  This is happening in Edge only.  It's totally fine with other multi-line elements. Anyone else experiencing this or have an idea what might be causing this?

I figured it out.   Edge does not like display: flex.  I changed the styling so I no longer needed flex and the issue is resolved.


I can addSubView,someone help me!

I want to put addSubview at bottom of MXSegmentedPagerController but I can't do it
self.view.addSubview(bottomView) not work :(

@maxep @itVietPham is this possible?... Even i want to put a single button at the bottom which is visible in all the tabs

@maxep how did you close this issue? got a solution?


change jsmidgen and midi-file-parser to regular dependencies

fixes issue #44

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   82.89%   82.89%
=======================================
  Files          10       10
  Lines         345      345
  Branches       62       62
=======================================
  Hits          286      286
  Misses         59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f72e0...8cda0ab. Read the comment docs.

Thanks!


LeafList.hashCode() fixed

@danieldietrich @orionll #1818
I believe that only LeafList.hashCode() should be changed.

Current coverage is 97.08% (diff: 100%)

Merging #1823 into master will not change coverage

@@             master      #1823   diff @@
==========================================
  Files            87         87
  Lines         11277      11277
  Methods           0          0
  Messages          0          0
  Branches       1869       1869
==========================================
  Hits          10948      10948
  Misses          207        207
  Partials        122        122

Powered by Codecov. Last update be0b078...cfa3de4

return Objects.hash(hash, value) + tail.hashCode();

I think this can fail with StackOverflowError if the map contains large number of keys with the same hash codes.
Try something like this:
class A {
    @Override
    public int hashCode() {
        return 1;
    }

    public static void main(String[] args) {
        HashMap<A, Integer> map = HashMap.empty();
        for (int i = 0; i < 10000; i++) {
            map = map.put(new A(), i);
        }
        System.out.println(map.hashCode());
    }
}

I suggest rewriting hashCode() the same way it is done in java.util.AbstractMap. This is simple and safe: http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/37a05a11f281/src/share/classes/java/util/AbstractMap.java#l490

I also think adding hashcodes is a viable solution. I created #1818 to ensure all Hash* impls work properly.
The StackOverflow problem is real (using Objects.hash(val) ... + tail.hashCode()). I fixed it recently for List.hashCode...

@ruslansennov Looks good to me! Please merge it if no one has any further objections :)


[cordova][XWALK-4055] pack cordova 4.0 using cli way

Please provide the UT result.

The cases of all-in-one package can run successfully.

LGTM


Decode and Encode of enum

Fixes #25

Tests are in Thoth.Net, tested locally and not run here in CI, as this require a merge in https://github.com/thoth-org/Thoth.Json/pull/25

Closed in favour of https://github.com/thoth-org/Thoth.Json.Net/pull/27 which is in par with Thoth.Json API.


Lists with WRAP_CONTENT do not have their width calculated correctly

See attached image
Looks like Android is not accounting for the adjusted width (including the * and tab) correctly and is thus wrapping too early.

you can see the markdown view being instantiated here (line 350):
https://github.com/dimagi/commcare-odk/blob/7d3014791baf49565816aaaa9311f78fdab9a820/app/src/org/odk/collect/android/widgets/QuestionWidget.java#L350
helper function here (line 93)
https://github.com/dimagi/commcare-odk/blob/7d3014791baf49565816aaaa9311f78fdab9a820/app/src/org/commcare/android/util/MarkupUtil.java#L93
layout params here (line 72):
https://github.com/dimagi/commcare-odk/blob/master/app/src/org/odk/collect/android/views/media/MediaLayout.java#L72


HTML data not escaped

When viewing data that contains HTML in Data Browser, the javascript code got executed.
I expected to view HTML in raw text.

@vincent-163 we are parsing HTML so that we can provide a better search experience with highlights example

In case you need to view the raw HTML you can view it from JSON data, by clicking on {..} before the _id field


SPIKE: Investigate CSS modules

What
Based on discussions in https://github.com/alphagov/govuk-frontend/issues/1052, we could do a short spike to explore whether it's feasible for GOV.UK Frontend to support CSS modules by either:

Generating an extra [filename].modules.scss file as part of the build process.
Renaming our existing scss files to [filename].module.scss - this would be a breaking change.

Why
We know that some teams in the community use Create React App to build services. We'd like to explore whether we can support these teams by making our scss files follow the naming convention.
Tasks

[ ] Investigate options 1 and 2, as well as any other viable options
[ ] Make a recommendation on next steps

See https://github.com/alphagov/govuk-frontend/issues/1052#issuecomment-461003745


credential wizard - changes from feedback

Signed-off-by: James Talton<EMAIL_ADDRESS>https://github.com/open-cluster-management/backlog/issues/12173
Groups providers
Adds wizard preview YAML
Updates secrets format

/hold

/retest


Fixing Landing page

What does this PR do?
Fixing Landing page
Description of Task to be completed?

Remove Register button in the navbar component
add more information on the landing page (explaining how the app works and polish the responsiveness )
we can add sliding photos on the homepage
Improve the responsiveness of how it works
improve the the contact the component by adding form validations, size of input and text area
Proofreading on the footer component (Kigali,Rwanda and other mistakes,Location)
Design the pages of (Terms of services, Privacy Policy,FAQ)
Remove Contact in the footer
Add The links on social media icons that redirects you to the the social media platforms

How should this be manually tested?
Clone the repo
checkout to branch Fix-landing-page-fe
Run npm install to install modules
Run npm run dev:start to start the development server
-route:http://localhost:3000
What are

the relevant Pivotal Tracker/trello stories?
link to my pivotal tracker :-https://trello.com/c/gY243nQX
Screenshots (if appropriate)

can you remove the register menu on mobile navbar


validation difficulty

hello! I'm having trouble using form validation. When I submit a form with a require field missing, I get a validation error as expected.

Here's my form markup:
<form hydro-on:submit="@(() => Model.SubmitAsync())">

			<input type="email" asp-for="Email" placeholder="Email address" class="form-control" maxlength="65" hydro-bind />

		<button class="ms-2 btn btn-primary" type="submit">Submit</button>

</form>

and relevant part of model class
public class EmailLeads : HydroComponent
{
	public string? AlertClass { get; set; }
	public string? Message { get; set; }

	[Required(ErrorMessage = "Email is required")]
	public string? Email { get; set; } = default!;

	public async Task SubmitAsync()
	{
		//if (!ModelState.IsValid) return;
		if (!Validate()) return;

		// stuff happens in db
	}
}

The problem is after I fill in a value and click Submit, the validation has not refreshed, and Validate returns false.
I put a breakpoint in my Submit method, and I check the value of Email property, and I see it's null. Do I need to put some other binding event on my html input?

Are you using v0.14.2?

It's actually a bug in Hydro. The issue here is type="email". I will fix it shortly, but a workaround for now is to use type="text".

thank you @kjeske ! yes I'm using 0.14.2


Hosting on Firebase

I've been mucking around with Docsify and Firebase Hosting, and I'm pretty confident with it. Any objections to me making a PR for /deploy with instructions?

PR is welcome. 😇

Coming Soon:tm: to a Pull Request near you!
I should have one done before the end of next-week, at the latest


Patch safe responses

This PR does two things:

Update responses to make more sense to users, as some folks may not know what diversity means in context.
Add link fixes and spelling error fixes

hold, please; readme link is wrong


Add example for amp-font

Fixes #243

Added  a few comments. Can we also demonstrate the good case?

@sebastianbenz Thanks for your review and comments.  PTAL

You are demonstrating different amp-font scenarios. Can you structure the sample accordingly?
The sample text doesn't use the Tangerine font even if it is loaded correctly
Is it necessary to duplicate the error/loading css rules? Can we just define them once and reuse them for both fonts?

Addressed the comments. @sebastianbenz PTAL

suggestion: rename .font-does-not-exist -> .unavailable-font

@sebastianbenz PTAL

LGTM - so happy that we finally have a sample for amp-font :-)


fix: support testFileName shortcuts

Scan submitted to Checkmarx

Checkmarx SAST - Scan Summary & Details
Cx-SAST Summary
Total of 6 vulnerabilities
 0 High
 0 Medium
 6 Low
 0 Info
Checkmarx Scan Summary

Severity
Count

High
0

Medium
0

Low
6

Informational
0

Violation Summary
 2 Low
View more details on Checkmarx UI
Cx-SAST Details

Lines
Severity
Category
File
Link

16 36
Low
Use_Of_Hardcoded_Password
src/env/args.js
Checkmarx

Checkmarx SCA - Scan Summary & Details
Cx-SCA Summary
Total Packages Identified: 357
Scan Risk Score: 9.80
 4 High severity vulnerabilities
 0 Medium severity vulnerabilities
 1 Low severity vulnerabilities
View more details on Checkmarx UI
Cx-SCA vulnerability result overview

Vulnerability ID
Package
Severity
CVSS score
Publish date
Current version
Recommended version
Link in CxSCA
Reference – NVD link

CVE-2021-3918
json-schema
HIGH
9.8
2021-11-13T09:15:00
0.2.3

Vulnerability Link
CVE-2021-3918

Cx8bc4df28-fcf5
debug
HIGH
8.6
2020-12-10T17:14:00
4.3.2

Vulnerability Link
N\A

CVE-2021-3807
ansi-regex
HIGH
7.5
2021-09-17T07:15:00
5.0.0

Vulnerability Link
CVE-2021-3807

Cxdca8e59f-8bfe
inflight
HIGH
7.5
2020-12-07T10:10:00
1.0.6

Vulnerability Link
N\A

Cxda14f253-4e52
bluebird
LOW
3.7
2016-04-24T21:00:00
3.7.2

Vulnerability Link
N\A


Fixed gcloud alpha command interactive prompt.

Possible solution for this was adding the gcloud components install alpha --quiet to weather_mv/setup.py.
Ref-
https://github.com/google/weather-tools/blob/f2a255460ef23e960a7fc669ecdc27ff7d58c9c9/weather_mv/setup.py#L99-L104
But going forward we would be moving to conda instead of pip hence setup files would be removed eventually.
For now, the subprocess.run() command is passed with a negative input for any user prompt, this will not let the program hang at user input. Fixes #324.
Additionally, for the docker image, gcloud alpha commands are explicitly installed so that it's already in the environment when someone runs the tool on Dataflow providing the docker image.

LGTM! Has the deployment of this been tested so far?

Yes, it has been tested end to end. Also created a docker image locally and it had installed gcloud alpha.

Excellent, thank you!


⚠ Bofrost.de has degraded performance

In 411e5a3, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1684 ms

Resolved: Bofrost.de performance has improved in 1ec6305 after 8 minutes.


no remove namespace method

Would be nice to have a remove namespace method. I can get by with
$el.attribs{"xmlns:xyz"}:delete;

Regards,
Marcel

Thank you for reporting this. I'm not actively maintaining these libraries at the moment, but if no one else adds a direct method to remove namespaces before I get a chance, I'll do it on my next update cycle. Cheers!


add init test for SSL Termination

Hi @jacksontj , here I use another bundle of certificates because I encounter some warning/error when test with openssl/curl/requests.

When generate certificate for Intermediate CA, we need to specify X509v3 extensions as follows:
        X509v3 Basic Constraints:
            CA:TRUE

Or we would get errors when test with openssl commands.
http://serverfault.com/a/486835

It would be better to set Subject Alternative Name in leaf certificate, to prevent warning in requests.
>>> import requests
>>> r = requests.get('https://www.example.com:4443', verify='/home/ffcai/apache/trafficserver/ci/new_tsqa/files/rsa_keys3/ca.crt')
/usr/lib/python2.6/site-packages/requests/packages/urllib3/connection.py:251: SecurityWarning: Certificate has no `subjectAltName`, falling back to check for a `commonName` for now. This feature is being removed by major browsers and deprecated by RFC 2818. (See https://github.com/shazow/urllib3/issues/497 for details.)
  SecurityWarning

To enable the E2E https test, we need a customized DNS resolver, to hit localhost for like hostname www.example.com. Seems that requests does not support this yet. There's some hacky way, but I would like to find a simple way, like curl's option --resolve http://superuser.com/a/794062

Could you please take a look at this bundle of certificates? If you agree with it, I'll update about how to generate the Root CA, Intermediate CA and leaf certificate. It's generated by a handy bash script, without complicated configurations.

@ffcai Assuming the tests still pass that should be fine :)
I just finished replacing the old tsqa-- so sadly you now have a merge conflict :(

@jacksontj - You going to commit this?
Should we create JIRA's for tsqa?

 Or should I?

Hi @jacksontj , I'll fix the conflict and do the merge.

Hey Feifei,
I'm curious why are we incorporating a static pre-generated certificate, rather than, perhaps a script that just generates one to be used for testing.
One issue I see with incorporating a static test cert is the expiration time.   The ones in this patch expire April 29, 2016.

We've been doing that for all of the tests actually. In my tests at least
I'm not verifying the validity of the cert-- since I can check to make sure
its the exact one that I want. This saves some CPU for the test boxes, and
more importantly removes a moving part for the tests.
On Mon, Jul 6, 2015 at 12:26 PM, repodude<EMAIL_ADDRESS>wrote:

Hey Feifei,
I'm curious why are we incorporating a static pre-generated certificate,
rather than, perhaps a script that just generates one to be used for
testing.
One issue I see with incorporating a static test cert is the expiration
time. The ones in this patch expire April 29, 2016.
—
Reply to this email directly or view it on GitHub
https://github.com/apache/trafficserver/pull/192#issuecomment-118970165.

Hi @repodude ,
Sorry for reply so late...
Well, I've considered using a script to generate certificates. In fact, I'm doing this in my local test environment. However, I have some concern on introducing complexity to our tests. With some off-the-shelf certificates, we can focus our effect on the test itself. What do you think about these two options @jacksontj ?

Well, when accessing the certs that are checked in today you usually call a library method which returns the path to the cert. If we want to make that library call lazily create the certs (similar to how the env_cache works) we can do that-- it is just another moving part (although you won't have to worry about the certs expiring potentially).

I need to fix the conflict issue and will send a new PR later.


Enable CI workflows running on [0-9]+.[0-9]+.[0-9]+** branches

Some references:

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestbranchestags
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

The pattern [0-9]+.[0-9]+.[0-9]+** can match:

1.2.0
1.2.0-release
1.3.0
...


Unrecognised video type MUSIC_VIDEO_TYPE_PRIVATELY_OWNED_TRACKS

https://github.com/nick42d/youtui/actions/runs/9917679674

Resolved as part of #70


TenantPipelineMiddleware

This is an error that appear multiple time in my log.
System.OperationCanceledException: The operation was canceled.
at System.Threading.CancellationToken.ThrowOperationCanceledException()
at Microsoft.AspNetCore.Http.Extensions.StreamCopyOperation.d1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.AspNetCore.StaticFiles.StaticFileContext.d47.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at SaasKit.Multitenancy.Internal.TenantPipelineMiddleware1.d__5.MoveNext() in C:\Users\eddy\Documents\eddy\src\SaasKit.Multitenancy\Internal\TenantPipelineMiddleware.cs:line 44 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at SaasKit.Multitenancy.Internal.TenantResolutionMiddleware1.d3.MoveNext() in C:\Users\eddy\Documents\eddy\src\SaasKit.Multitenancy\Internal\TenantResolutionMiddleware.cs:line 42
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.ApplicationInsights.AspNetCore.ExceptionTrackingMiddleware.d4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware.d__6.MoveNext()

I'm not able to replicate this. If you're still experiencing this issue, please post more details of your application setup.


Ask teams not to update crown before 29 Jan 2024

What
Once the new versions have been released, ask teams not to update the crown before 29 January 2024.
Why
GOV.UK requested this.

Getting more info on the 'why', I think it's to do with reducing the chance that a service looks fraudulent. For example, if GOV.UK has the new crown first, it can be trusted that this is a change that is happening.

The above is true, it's to increase trust by trying to ensure that the central domain has the change before linked sub-domains.

@stevenjmesser As the crown launch has been rescheduled, should this be updated to the new (provisional) date of 19th February?

@stevenjmesser @querkmachine is this done?

@36degrees I suspect so. We included the note not to update in our changelogs and release comms, not sure if there's anything else we have to do on top of that.

I'll close this on the basis we can re-open it if @stevenjmesser disagrees!

Is done, thank you :)


Avoid XML escaping in doc code examples

Thanks for this PR. While I'm fine with using var as a workaround, I think that the more robust way to solve this problem (while we are at it) would be to use a character data section (CDATA) for

I see. I did not know about CDATA, good to know about it.
In this case, even knowing about CDATA, I would like to keep using var, since CDATA is not necessary in this case. What do you think @atifaziz ?

Sorry, closed by mistake.

do you suggested merge the CDATA PR before this? in which summaries it would be added ?

do you suggested merge the CDATA PR before this?

I would say so because that's the proper solution to avoiding escaping. However, since that is what this PR intended to address, you could also revert all changes and make this the PR that adds CDATA instead. Then once merged, using var, which is a nice to have, can come in a second PR.

in which summaries it would be added ?

I would add it to all <code>.

I would add it to all .

done.

Thanks for helping with this!

done


Synchronized openshift-kni/resource-topology-exporter (d/s) with k8stopologyawareschedwg/resource-topology-exporter (u/s)

This repo is a mirror (with some minor changes) of https://github.com/k8stopologyawareschedwg/resource-topology-exporter
We'll achieve this synchronization by vendoring all sources directly from u/s.
This way we'll be able to keep sync between u/s and d/s just by bumping the u/s version under the go.mod file.

@fromanirh @swatisehgal

/lgtm
let's start this way


SGE Tests segfault in CI

Opening an issue to triage the segfault that seems to be happening in th SGE tests.
For some time the SGE tests have been failing. When you look at the logs of a recent run on main it contains the following error.
 *** Error in `/opt/anaconda/envs/dask-jobqueue/bin/python3.8': double free or corruption (!prev): 0x00005626c18fa470 ***
/bin/bash: line 1:   588 Aborted                 (core dumped) pytest /dask-jobqueue/dask_jobqueue --verbose --full-trace -s -E sge

I also opened #652 to bump the minimum Python version here to 3.9 and I see a similar issue happening but with a slightly different error.
*** Error in `/opt/anaconda/envs/dask-jobqueue/bin/python3.9': corrupted size vs. prev_size: 0x00005560404681a0 ***
/bin/bash: line 1:   592 Aborted                 (core dumped) pytest /dask-jobqueue/dask_jobqueue --verbose --full-trace -s -E sge

Strangely in both cases pytest reports everything has passed.
9 passed, 270 skipped in 26.69s

In #654 I've been playing around with skipping various tests and enabling them again. It seems like enabling any of the tests results in the segfault. Enabling more than one only causes the error to appear once though.

I have a local reproducer now. Here are the steps I took to get it set up on my machine.
# Build SGE container
cd ci/sge
cp ../environment.yaml .
docker compose build

# Start SGE stack (based on ci/sge.sh)
./start-sge.sh
docker exec sge_master /bin/bash -c "chmod -R 777 /shared_space"

# Install dask-jobqueue in editible install
docker exec sge_master conda run -n dask-jobqueue /bin/bash -c "cd /dask-jobqueue; pip install -e ."

I also installed anyio and used @pytest.mark.anyio instead of @pytest.mark.asyncio because I find the behaviour a lot more consistent. See #655.
I then created a new test file with a single test that consistently reproduces the segfault.
# dask_jobqueue/tests/test_jsge_segfault.py
from dask_jobqueue.sge import SGECluster
from dask.distributed import Client

import pytest

@pytest.mark.anyio
@pytest.mark.env("sge")
async def test_cluster():
    async with SGECluster(1, cores=1, memory="1GB", asynchronous=True) as cluster:
        async with Client(cluster, asynchronous=True):
            pass

Then you can run the test via docker exec.
$ docker exec sge_master conda run -n dask-jobqueue /bin/bash -c "cd; pytest /dask-jobqueue/dask_jobqueue/tests/test_sge_segfault.py --verbose --full-trace -s -E sge"
*** Error in `/opt/anaconda/envs/dask-jobqueue/bin/python3.8': corrupted size vs. prev_size: 0x0000560d54c76aa0 ***
/bin/bash: line 1: 29477 Aborted                 (core dumped) pytest /dask-jobqueue/dask_jobqueue/tests/test_sge_segfault.py --verbose --full-trace -s -E sge

ERROR conda.cli.main_run:execute(125): `conda run /bin/bash -c cd; pytest /dask-jobqueue/dask_jobqueue/tests/test_sge_segfault.py --verbose --full-trace -s -E sge` failed. (See above for error)
============================= test session starts ==============================
platform linux -- Python 3.8.19, pytest-8.3.2, pluggy-1.5.0 -- /opt/anaconda/envs/dask-jobqueue/bin/python3.8
cachedir: .pytest_cache
rootdir: /dask-jobqueue
plugins: anyio-4.4.0
collecting ... collected 1 item

../dask-jobqueue/dask_jobqueue/tests/test_sge_segfault.py::test_cluster PASSED

============================== 1 passed in 1.07s ===============================

$ echo $?
134

Since upgrading to Python 3.9 in CI this issues seems to have gone away. It's strange because I'm still able to reproduce some problems locally, but perhaps there is something cached that I'm not taking into account.
Given that CI is all green and PRs and merges are passing consistently I'm going to close this out.

Looks like a similar erorr happened when running CI for #660.
 *** Error in `/opt/anaconda/envs/dask-jobqueue/bin/python3.9': free(): invalid pointer: 0x0000557fe477a210 ***
/bin/bash: line 1:   588 Aborted                 (core dumped) pytest /dask-jobqueue/dask_jobqueue --verbose --full-trace -s -E sge

ERROR conda.cli.main_run:execute(125): `conda run /bin/bash -c cd; pytest /dask-jobqueue/dask_jobqueue --verbose --full-trace -s -E sge` failed. (See above for error)

Perhaps it's not as resolved as I had hoped.

Still seeing this after bumping to Python 3.10.
 *** Error in `/opt/anaconda/envs/dask-jobqueue/bin/python3.10': double free or corruption (!prev): 0x000055e87b68bf90 ***
/bin/bash: line 1:   591 Aborted                 (core dumped) pytest /dask-jobqueue/dask_jobqueue --verbose --full-trace -s -E sge

ERROR conda.cli.main_run:execute(125): `conda run /bin/bash -c cd; pytest /dask-jobqueue/dask_jobqueue --verbose --full-trace -s -E sge` failed. (See above for error)


[BUG]: The forward function is missing from GPTLM

🐛 Describe the bug
The forward function is missing from GPTLM,
Environment
No response

Same problem for BLOOMLM


More advices for writing effective step-by-step instructions

The main issue about writing step-by-step instructions is that usually this process is incredibly time- and resource consuming. To kill two birds with one stone and get rid of voluminous technical documentation work, I have written this article who combine the best practices for writing effective work instructions that I have learned over years:
https://dokit.io/best-practices-for-writing-effective-work-instructions/
I hope this help.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 39b5e3aa-271d-e55e-5c7c-fd31ec3ae360
Version Independent ID: 18c8323f-fa16-669e-2d58-f959b8b772d7
Content: Writing step-by-step instructions - Microsoft Style Guide
Content Source: styleguide/procedures-instructions/writing-step-by-step-instructions.md
Product: non-product-specific
GitHub Login: @pallep
Microsoft Alias: pallep

Thanks for your post, we'll check it out.


callback when update place

use the vs-update directive to get a function callback called every time the place value updates.
Example:
<input
  type="text"
  name="place"
  ng-model="place.name"
  vs-google-autocomplete
  vs-autocomplete-validator
  vs-street-number="place.number"
  vs-street="place.address"
  vs-city="place.city"
  vs-district="place.neighborhood"
  vs-state="place.state"
  vs-post-code="place.zip"
  vs-latitude="place.lat"
  vs-longitude="place.lng"
  vs-update="onPlaceUpdate()"/>

Hello friend,
This a really good change and idk why the PR was not accepted, even though you forget to add the callback function on the scope params.
Have a nice day.


Attendance doesn't display on profile page

My attendance appears as "0% +0%" even though I have been attending class and checking in. The Chromium JS console presents this error:
Error: [ngRepeat:dupes] Duplicates in a repeater are not allowed. Use 'track by' expression to specify unique keys. Repeater: day in user.attendance, Duplicate key: string:2016-02-02T05:00:00.000Z, Duplicate value: 2016-02-02T05:00:00.000Z
http://errors.angularjs.org/1.3.20/ngRepeat/dupes?p0=day%20in%20user.attend…e&p1=string%3A2016-02-02T05%3A00%3A00.000Z&p2=2016-02-02T05%3A00%3A00.000Z
    at d60876a9.vendor.js:4
    at d60876a9.vendor.js:7
    at Object.d [as fn] (d60876a9.vendor.js:6)
    at n.$digest (d60876a9.vendor.js:6)
    at n.$apply (d60876a9.vendor.js:6)
    at f (d60876a9.vendor.js:5)
    at r (d60876a9.vendor.js:5)
    at XMLHttpRequest.v.onload (d60876a9.vendor.js:5)

After searching, this issue might be a duplicate of #138 but I can't know for sure because no description was provided.

thanks @cyrozap i poked Kiana and Seve about that request. It may resolve it. They have a lot happening in that request.


planning: Cortex.cpp features needed to fully support Jan

WIP list
Model Hub

Updated models, delist
Jan dogfoods this to display on UI
future: eg Cortex remote models list

View RAM, CPU usage

requires reimplementing cortex ps for each engine
Can be deployed first but currently combines all engines together resulting in inaccurate

Hardware, eg GPU support

#1165
Major Epic, needs thorough planning
cortex.cpp needs hardware detection, currently doesnt support multi-GPU
Major usage for Jan

Support Tensorrt-llm engines [Prioritised?]

Need to define Model artifact, model.yml
need to bundle artifacts (needs investigating)

multi-modal - cortex.cpp needs to be able to pull 2 models at the same time

Need to define model.yml for the models

To add  (priority, needed, blockers, effort)

Closing in favour of Jan issues

3895
https://github.com/janhq/jan/issues/3690


Add docs and workflow for pusblish them

Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] Optimization
[ ] Documentation Update

Description
Add docs and CI for publishing them using mk-docs
Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Do you have a preview link?

Do you have a preview link?

https://morenod.github.io/rosa-burner/latest/


remove the directories in the env dir passed to the slugbuilder compile

To fix the issues like this https://github.com/deis/builder/issues/454 which happens because of k8s creating some directories it would be better to remove these dirs before https://github.com/deis/slugbuilder/blob/master/rootfs/builder/build.sh#L171

fixed in #126


Unsupported parameters for (lineinfile) module: block, marker

Hello,
Running this on CentOS 8 using Ansible 2.9.21 and I'm getting the following.
TASK [/root/RHEL8-CIS : NOTSCORED | <IP_ADDRESS> | PATCH | Ensure logging is configured | mail.* log setting] ***************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (lineinfile) module: block, marker Supported parameters include: attributes, backrefs, backup,       content, create, delimiter, directory_mode, firstmatch, follow, force, group, insertafter, insertbefore, line, mode, owner, path, regexp, remote_src, selevel, serole, setype, seuse      r, src, state, unsafe_writes, validate"}

Looking at the code in tasks/section_4/cis_4.2.1.x.yml on line 58 I can see that the task looks like this:
  - name: "NOTSCORED | <IP_ADDRESS> | PATCH | Ensure logging is configured | mail.* log setting"
    lineinfile:
	path: /etc/rsyslog.conf
	state: present
	regexp: '^mail\.\*(.*)$'
	marker: "# {mark} MAIL LOG SETTINGS (ANSIBLE MANAGED)"
	block: |
	  # mail logging additions to meet CIS standards
	  mail.*                                                  -/var/log/mail
	  mail.info                                               -/var/log/mail.info
	  mail.warning                                            -/var/log/mail.warning
	  mail.err                                                /var/log/mail.err
	insertafter: '# Log all the mail messages in one place.'

Reading though the documentation https://docs.ansible.com/ansible/2.9/modules/lineinfile_module.html it seems that
the following params block, marker are not supported in the module lineinfile
Should this be using blockinfile instead?

hi @Wolskie
Thank you for raining this issue, i will look to get this fixed asap.
uk-bolly

hi @Wolskie
Thanks once again for highlighting this issue.
A fix has been merged into devel to resolve this issue.
Please feel free to close or feedback if not as expected.
uk-bolly

Thank you, looks good!


XLA commonly aborts with nvidia error

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): Source
TensorFlow version (use command below): 1.10
Python version: 3.5
Bazel version (if compiling from source): 0.15
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 9.2 / <IP_ADDRESS>
GPU model and memory: Titan
Exact command to reproduce: N/A

Describe the problem
When running XLA via the session config we commonly hit the following error:
2018-09-06 17:28:38.814423: F tensorflow/stream_executor/cuda/cuda_dnn.cc:211] Check failed: status == CUDNN_STATUS_SUCCESS (7 vs. 0)Failed to set cuDNN stream.
However, sometimes we get further than this error and see significant speed up with XLA and the loss decreasing.
What could be causing this error?
The docker image is located at: https://hub.docker.com/r/joeyearsley/tf-builds/
I can't diverge the exact script, however I do have the following:

NCCL for multi-gpu reduction like TF-Benchmark's Variable Manager
tf.data APIs including the string handles to alter between train and validation datasets.

@jlebar I got around to trying XLA again after #16045, works nicely when I get past this error, however stumped as this errors pops up frequently. Around 80% likely when running a script compared to the 20% which actually get past this error and continue.

Check failed: status == CUDNN_STATUS_SUCCESS (7 vs. 0)Failed to set cuDNN stream.

It's possible that there's an error earlier in execution, and this is just fallout.  Once there's some error on a stream, any operation on the stream will fail.
Could you look through the logs carefully for warnings?  And/or run with CUDA_LAUNCH_BLOCKING=1, which may make it easier to find "up-stream" errors.

Running it with that command still results in the same error.
It runs consistently when I include these flags TF_XLA_FLAGS="--parallel_check_failfast=false"

I changed from using the session approach to the scoped approach to try and narrow down potential places the error could occur.
It seems to be when I have opt.compute_gradients(loss, params) compiled into XLA code that I see a weird 3x speed-up but the loss doesn't decrease, and occasionally get the CUDNN_STATUS_SUCCESS.
If I just have the jit_scope around my model then it runs fine.

It runs consistently when I include these flags TF_XLA_FLAGS="--parallel_check_failfast=false"

The parallel_check_op is deleted at HEAD because it was unused.  If it were affecting things, then you should see in your logs failfast on first parallel-check failure.  If you don't see that, I don't think this flag can possibly be changing anything.
Can you confirm that you have looked carefully through the logs when running with CUDA_LAUNCH_BLOCKING and do not notice anything else suspicious?  Is it possible to post (or send privately) your full log, or if you're not comfortable with that, the log of all lines that start with W or E (i.e., all warnings and errors)?

It seems to be when I have opt.compute_gradients(loss, params) compiled into XLA code that I see a weird 3x speed-up but the loss doesn't decrease

Weird.
It could totally be a bug in XLA (or cudnn), but it may be pretty hard to debug without the ability to reproduce.

Just to double check, I can gather the logs by setting tf.logging.set_verbosity('DEBUG')? - I missed changing this previously..
I'll try making the exact copy of my script with the mnist_xla script but making use of all things like nccl for multi-gpu.

I can gather the logs by setting tf.logging.set_verbosity('DEBUG')? - I missed changing this previously..

That would be sufficient.

I'll try making the exact copy of my script with the mnist_xla script but making use of all things like nccl for multi-gpu.

OK, thanks!

No errors or warnings when logging and CUDA_LAUNCH_BLOCKING=1.
Working on a mnist_xla script now

https://github.com/joeyearsley/mnist-xla/tree/master

@d0k spent some time looking at this.  He was able to reproduce the high loss, with both XLA:GPU and XLA:CPU.  Still unclear what's going on.
One question for you is, do you have a way we can reproduce the Check failed: status == CUDNN_STATUS_SUCCESS (7 vs. 0) error?  That may be separate.

I’ll try reproducing that result with the mnist example.
We’ve also been seeing weird things with TF 1.10 and cuda streams but that’ll be another issue created after a bit more investigation - the CUDA error might be more related to that.

Trying to reproduce the CUDNN error, so far no luck as it is extremely stochastic.
Seems to be happening more frequently when there's a batch size which causes:
Allocator (GPU_0_bfc) ran out of memory trying to allocate 2.06GiB. The caller indicates that this is not a failure, but may mean that there could be performance gains if more memory were available.
and when there are multiple GPUs.
Finding it hard to make a reproducible example.

Nagging Assignee @shivaniag: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Anymore information on the XLA not working?

We haven't forgotten about this, but I don't have an update.
I don't know what's going wrong for you; a bunch of people are using XLA
internally without issue.  It's pretty surprising.
On Fri, Sep 28, 2018 at 7:35 AM Joe Yearsley<EMAIL_ADDRESS>wrote:

Anymore information on the XLA not working?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/22119#issuecomment-425453273,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJMhyyuF_j_61OrW7IRbX8ntMgxbxXQks5ufjOugaJpZM4WdaOL
.

Ok, thank you for the update!

Nagging Assignee @shivaniag: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@jlebar I notice that from TF 1.12 that it will be built with XLA by default.
Is this really a good idea with a bug such as this is still unsolved?

@jlebar I notice that from TF 1.12 that it will be built with XLA by default.
Is this really a good idea with a bug such as this is still unsolved?

It builds with XLA, it doesn't run with XLA by default. I'm quite unhappy with this bug still being around, but failed to ever reproduce the crash you're seeing.

Xla will be built, but it will not be enabled in models unless you ask for
that.
On Fri, Oct 19, 2018, 12:45 PM Joe Yearsley<EMAIL_ADDRESS>wrote:

@jlebar https://github.com/jlebar I notice that from TF 1.12 that it
will be built with XLA by default.
Is this really a good idea with a bug such as this is still unsolved?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/22119#issuecomment-431475854,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJMh0cl-c2pDpq5zMM0mX-0RUYGSx3iks5umivhgaJpZM4WdaOL
.

Fair points.
@d0k do you have any hypothesis of what the bug could be?
I’ve ignored the crash for now as I’m putting it down to some weird clash in the environment.

@d0k do you have any hypothesis of what the bug could be?

The status you're seeing is CUDNN_STATUS_MAPPING_ERROR, which hints at an internal error in cudnn, so the bug is most likely there. But it's hard to say, there are a lot of moving parts.

@tfboyd I noticed from the mailing list that you are experimenting a lot with XLA atm. Could you please try running the mnist-XLA repo I’ve posted above, do you see the same problems as myself?

I think I can make time to do that since I have a setup. Added myself to the assignee list for more visual nagging.  :-)  I run the ResNet example with tf.cnn.benchmarks a lot but I am using CUDA 10 because of the ptxas 9.0 vs 9.2 problem.  If you want to use CUDA 10 I and others have put up some binaries.  We will move TF nightly to CUDA 10 in mid/late November and then release it in January.  I wanted to go earlier but the timing did not work out.
https://github.com/tensorflow/tensorflow/issues/22706

@joeyearsley  The docker image does not have the correct XLA due to some difficulties.  I need to see if I can pull it off with just apt-get, I cannot just copy the files over due to process and previous legal issues that may be getting resolved.

Ah ok, thanks for the help and updates!

Nagging Assignees @shivaniag, @tfboyd: It has been 33 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


How can I include JavaScript dependencies in my scalajs-react-interface app?

I want to use facade https://github.com/DefinitelyScala/scala-js-algoliasearch but I am not sure how to import JavaScript dependencies. Any help?

@taimuri  https://www.scala-js.org/doc/interoperability/facade-types.html

@chandu0101 The problem is JavaScript dependencies, I have imported above Scala facade code but I can not change library code that implies I can not add @JSImport or something on facade code  as this is a compiled code.
Now when I invoke facade it looks for JavaScript dependencies and because there is not import or require(...) statement for this facade in my scalajs-output-ios.js file, I am seeing JavaScript error.

@taimuri Did the discussion on gitter help. My guess is that the library was missing @JSImport which means no require statement in the scalajs output. If this is OK now, please close.

Rakshak Bot : @taimuri you're not allowed to create issues here, please post your question here, if its a reproducible bug one of sri maintainers will create an issue back here will inform you about when/how it will be fixed.


refactor: reuse command types/utils across packages

Motivation
Noticed we copy-pasted command types/utils in different packages but we only really maintain the ones in the CLI package.

https://github.com/ChainSafe/lodestar/pull/4576
https://github.com/ChainSafe/lodestar/pull/6438

This PR aims to consolidate types by moving those into the utils package to improve consistency and reduce future maintenance.
Description

Move command types/utils to @lodestar/utils package
Fix type issues that came up in prover package after reusing stricter types
Demand option (demandOption: true) if arg must be provided instead of checking separately

:tada: This PR is included in v1.17.0 :tada:


20.6

Learn Build status updates of commit 6d179c5:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 6d179c5209724db77a89447f59d75fb268baa84b in branch main of repository https://github.com/a-emniel/dynamics365smb-devitpro-pb into branch main (commit 6e904da3bf841120775e0185bddd34dcf88a6181). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Closing and reproducing internally.


[Enhancement] Affine to be transparently multipliable with Numpy arrays

I think that most people who are using affine will also be using rasterio and, thus, working with numpy arrays. It would be nice to be able to transparently batch convert numpy arrays of coordinates with just anAffine * aNumpyArray.
As far as I know, it's standard to have lists of coordinates in numpy arrays shaped [..., 2] because it makes operations like "add (2, 1) to all coordinates" a very simple numpy operation (arr + (2, 1)).
This is what I would like to work:
import affine
import numpy as np
arr = np.array([(1, 1), (4, 6), (2, 5), (3, 1)])
aff = affine.Affine(2, 0, 3, 0, 3, 1) # scale up by (2, 3), offset by (3, 1)
print(arr * aff)

There is a work-around: you can transpose the input, and combine back into a numpy array with:
>>> print(np.array(aff * arr.T).T)
[[ 5.  4.]
 [11. 19.]
 [ 7. 16.]
 [ 9.  4.]]

But, I think it would be much nicer if aff * arr was just supported to do this operation automatically.

@Multihuntr thank you for showing the work around. I think we should not add this feature. As you point out, we only have to write one line of code in our applications to batch multiply.

Sure thing. Makes sense.


AD Connect Cloud Sync vs AD Connect

Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
We use GitHub issues as the primary channel for customer and community feedback about the Azure documentation.
Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[What is Azure AD Connect cloud sync?] The relevant Azure service or technology.
[https://learn.microsoft.com/en-us/azure/active-directory/hybrid/cloud-sync/what-is-cloud-sync] A link to the published documentation article that you have feedback about.
[Not clear if Cloud Sync support Hybrid Azure AD join] Clear, specific feedback that the author can act on.

Can be good to include this information here aswell: https://learn.microsoft.com/en-us/azure/active-directory/devices/howto-hybrid-azure-ad-join

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 623a03a6-0197-c346-7a88-beee7caf628c
Version Independent ID: 33c236b5-0eff-1adf-bba8-cf9d459a3201
Content: Configure hybrid Azure Active Directory join - Microsoft Entra
Content Source: articles/active-directory/devices/howto-hybrid-azure-ad-join.md
Service: active-directory
Sub-service: devices
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@Fredrik81
Thank you for your feedback!
Since this issue isn't directly related to improving our docs, and to gain a better understanding of your issue, I'd recommend working closer with our support team via an Azure support request. Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
Teams Q&A forum for technical questions about the configuration and administration of Microsoft Teams on Windows.
Microsoft Teams Community forum
Thank you for your time and patience throughout this issue.


qd_adaptor_buffer_t leak in http1 tests

56: self = <system_test.Tester object at 0x7f602b323ac8>
56:
56:     def teardown(self):
56:         """Clean up (tear-down, stop or close) objects recorded via cleanup()"""
56:         self.cleanup_list.reverse()
56:         errors = []
56:         for obj in self.cleanup_list:
56:             try:
56:                 for method in ["teardown", "tearDown", "stop", "close"]:
56:                     cleanup = getattr(obj, method, None)
56:                     if cleanup:
56:                         cleanup()
56:                         break
56:             except Exception as exc:
56:                 errors.append(exc)
56:         if errors:
56: >           raise RuntimeError("Errors during teardown: \n\n%s" % "\n\n".join([str(e) for e in errors]))
56: E           RuntimeError: Errors during teardown:
56: E
56: E           Process 5823 (name=EA2) error: returned error code -6
56: E           skrouterd -c EA2.conf -I /home/runner/work/skupper-router/skupper-router/skupper-router/python
56: E           /home/runner/work/skupper-router/skupper-router/skupper-router/build/tests/system_test.dir/tests/system_tests_http1_adaptor/Http1AdaptorEdge2EdgeTest/setUpClass/EA2-13.cmd
56: E           >>>>
56: E           ERROR: Aborted due to unexpected alloc pool leak of type 'qd_adaptor_buffer_t'
56: E           <<<<
56:
56: /home/runner/work/skupper-router/skupper-router/skupper-router/tests/system_test.py:1081: RuntimeError

https://github.com/ganeshmurthy/skupper-router/actions/runs/3298280750/jobs/5440239501#step:10:4398

And again:
ERROR at teardown of Http1AdaptorEdge2EdgeTest.test_2002_curl_post
https://github.com/skupperproject/skupper-router/actions/runs/3338165018/jobs/5525521181#step:10:4595

Have not seen these in over a year, closing


Add Java Solution for Problem Of The Day | 24 January 2023

Comment below if you're interested in working on this issue and would like to be assigned to it.

Shall I work on this issue?


serialization duplicates imports

Possibly only relevant to the context manifest, but sometimes the serialization code in arc.ts will directly include a manifest that the context already included.

@lindner says he looked at this previously a bit. @shans are you planning to look at this soon? Perhaps Paul can help, or if you have thoughts on approach, comment and we can discuss further.

This may be P2, I'm marking P1 as @sjmiles has it on his tracking issue https://github.com/PolymerLabs/arcs/issues/2262, but if it's not actually blocking landing shell 0_6_0 then it's probably P2.

So I dont' forget, when the shell-0_6_0 encounters this problem, it implements a workaround and emits this message:

I think this should probably be P2, or possibly even closed. I think what's happening is that the serialization code doesn't know what special fiddling the shell context code is doing, so it can't really do anything about the potential for duplicates.
We could allow duplicated importing (which would make this a P2 feature request, I think?) or just accept that this issue will resolve itself when we work out what to do with context (in which case this should be closed).

Sounds ok, although I am curious about the nature of special fiddling. :)
At this point my sense is that Shell isn't doing anything unexpected, so I would like to understand the bits that look iffy to you.

I'm marking it P2. Hopefully I can find time soon to take a quick look (and see if it's even still happening). If I find that time or not, I will aim to close this soonish.


HDDS-11254. Reconcile commands should be handled by datanode ReplicationSupervisor

What changes were proposed in this pull request?
Summary
In the placeholder reconciliation implementation, handling of reconcile container commands from SCM to datanodes are done in the KeyValueHandler. In the final implementation they should go through the ReplicationSupervisor like replication and reconstruction commands for proper scheduling.
This change also makes sure the same ContainerChecksumTreeManager instance is available in all the places it is needed within the datanode, and closes its metrics properly instead of the workaround added in HDDS-10373.
Specific Changes

Usage of ContainerChecksumTreeManager is unified to one instance for the whole datanode.
Merkle tree metrics object is properly closed.
Reconcile commands are deduplicated by container ID and peer list.

The ReplicationSupervisor should drop duplicate commands.

ReconcileContainerCommandHandler uses ReplicationSupervisor for queueing. It does not implement it's own thread pool and queue.

With this change, it also uses ReplicationSupervisor for metrics.

This is similar to how ReconstructECContainersCommandHandler and ReplicateContainerCommandHandler are implemented (total time and invocation count are unused in that class)
It would be good to have more fine grained metrics for each of these task types instead of the shared ReplicationSupervisorMetrics, but that would be a broader change outside the scope of this PR.

New test helper methods for creating KeyValueHandler and HddsDispatcher instances when only a susbet of the functionality is required were added and existing tests were updated.

This greatly reduced test dependence on the KeyValueHandler constructor allowing us to make changes here to get the ContainerChecksumTreeManager where we need it.

What is the link to the Apache JIRA
HDDS-11254
How was this patch tested?

Metrics unregistration has been seen to fail existing tests if not done properly. No failures observed here.
TestReconcileCommandHandler tests for metrics were removed since those are now covered by TestReplicationSupervisor.
Unit test added for TestReconcileContainerTask that it properly detects task failure and equality.
Existing e2e acceptance tests for reconciliation pass.

This looks good, once the CI passes on your fork we can make it ready to merge.

Passing on my fork here


WIP Feature/unr 2396 add trace lib measurements

Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.

Description
Describe your changes here.
Release note
REQUIRED: Add a release note to the ##Unreleased section of CHANGELOG.md. You can find guidance for writing useful release notes here. Documentation changes are exempt from this requirement.
Tests
How did you test these changes prior to submitting this pull request?
What automated tests are included in this PR?
STRONGLY SUGGESTED: How can this be verified by QA?
Documentation
How is this documented (for example: release note, upgrade guide, feature page, in-code documentation)?
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

Since the schema is modified, I believe RequireSetup should be updated as well?


Set up tree-sitter-rst as submodule

The biggest advantage here is that a user doesn't need to manually check the correct commit anymore, as this is already pre-set in the submodule set up.
Addresses #171

Awesome !


visualization of pyjanitor chained method calls

Brief Description
I'd like to propose some new features to pyjanitor with focus to visualization and data organization. I've made proof-of-concept repo to explain what exactly is the proposal contains: https://github.com/asmirnov69/pyjviz-poc
To be really brief - this example of pyjanitor example with corresponding diagram
Examples
more examples are here
A bit more about what is goal beyond immediate focus
Immediate focus is to have png diagram files generation working using rdflib with provided SPARQL and graphviz. There is a bigger idea of rdf logs and similarily collected data to be stored in graph database. This would be database of research&production activity which uses SPARQL and/or opencypher to provide the way to connect collected data to other knowledge graph systems (e.g. Obsidian).

I was unable to find the way to attach labels. My intent was to label this issue as 'disscussion-needed'

Hl @asmirnov69! Thanks for posting this issue. It's a really cool idea! I especially like being able to visualize both pandas and janitor functions simultaneously.
Because the POC implementation is a tad complex, would you be kind enough to point out where the key changes were needed in order to enable keeping track of which function/method calls were made? I read through the code, but was confused, as I didn't see something like a globally-instantiated NetworkX graph object (or analogous thing).
Additionally, I saw the use of a new ChainedMethodPipe object. Is the intent with the ChainedMethodPipe to keep transformations visually isolated from one another?

There is a reference from sklearn's Pipeline

https://scikit-learn.org/stable/auto_examples/miscellaneous/plot_pipeline_display.html

Hi @ericmjl
Thanks for expressing interest in the idea. I am going start with further steps. Below are answers on some of your questions.

I'd love to see this functionality implemented. We could probably house this in pyjanitor;

As for housing of viz in pyjanitor - I think it make sense to consider as main approach since visualization suppose to come as set of in-the-box features for all users. In any case it will be up to you to decide based upon the progress of some sort of parallel development.

if so, I can foresee the PR review process needing to be a bit longer than usual so that there's enough time for other maintainers to be brought up-to-speed on the implementation

PR approach seems to work well for bug fixes and small features additions. I think we can plan to use PRs. However I would expect we will need to agree on long-term existence of some parallel feature branches with separate limiter releases.

we'd probably also need time to have developer/maintainer documentation written,

after your revelation elsewhere that you are using Obsidian I decide to take second look at that system. As result all my notes both for office work and home are now in various obsidian vaults.
Do you want to experiment and start using Obsidian for viz features project documentation? I will do some initial setup on how it may look like in pyjviz-poc repo in next few days. Hopefully it will be enough to arrive to informed decision.
I will provide more answers a bit later. Some of the answers actually belong to project documentation so clarity on documentation approach would be nice to have.
Thanks again for your support, I really appreciate that.
-Andrei

@Zeroto521 thanks for posting on viz available in sklearn. pyjviz-poc proposal goes further in this direction. Main idea is to use RDF as data format to capture details needed for visualization and other uses. Visualization itself can be made as independent component as result of that.

@ericmjl Hi, I put additional answers into https://github.com/asmirnov69/pyjviz-poc/blob/main/docs/pyjviz-poc/Q%26A.md
Also take a look here for code highlights https://github.com/asmirnov69/pyjviz-poc/blob/main/docs/pyjviz-poc/README.md#code-highlights
This is the part of obsidian vault so it may be easier to use that tool.
One thing to mention here: I renamed ChainedMethodsPipe to ChainedMethodsCall. It was actually original name which somehow didn't get to proposal final commit. I think pipe as a term is overused so ChainedMethodsCall looks better and more relevant. Let me know if you think we should still use ChainedMethodsPipe.

Hi @ericmjl
After some additional thinking I realized there is a way to proceed with the proposal as separate python module - instead of an attempt to modify pyjanitor to include viz features.
I would suggest to introduce the python module pyjviz which will use pyjanitor as required dependency. I've made some initial experiments and looks like it is possible to do it this way. pyjviz will give users ability to visualize pyjanitor code in a manner close to POC examples
There are changes in the way how visualization will look like from code perspective. It will make current examples and docs useless. All new examples and docs will be in pyjviz. POC repo pyjviz-poc will be archived in next few days.
I start working on pyjviz and will report on the progress. I hope to get something done this week so we can resume discussions on how this new module will look like.
How exactly we can communicate on pyjviz dev efforts? Right now only available option is this current issue. Would it make sense to move further discussion elsewhere?

@asmirnov69 thank you for giving it thought! I think it's a good idea. I apologize for silence on my side, we've been busy with physical health issues and our 2nd baby's arrival.
I've been thinking about the development and pyjviz, and having a separate repo with an independent space makes a lot of sense. In that way, you can really drive forward and own the problem space without being too burdened by the existing code base.
Would you like a repo space under the pyjanitor-devs umbrella? I know I'd be happy for your development work to be recognized as part of a growing ecosystem of tooling to cleanly clean data, and I think the rest of the @pyjanitor-devs/core-devs would be excited to see it too. I'm happy to add you to the pyjanitor dev team as well. Please let me know.

@ericmjl Best wishes for your new baby and your family!

Would you like a repo space under the pyjanitor-devs umbrella?

Yes, new repo in pyjanitor-devs for the visualization project would be the best. Also I agree to join pyjanitor dev team as open source contributor.
Feel free to pick better name than pyjviz. Let me know when I can start using that new repo and what are the requirements.
I plan to close this issue and archive pyjviz-poc repo.

Thank you, @asmirnov69!
I have added you as a core dev, you should be getting an invite shortly.
I'm not sure what a better name would be, so we can go with pyjviz if you'd like.
One things I hope to encourage as a standard is the use of continual testing, linting, and automated publishing of docs. We can slowly make that happen; there's enough of a great pattern accumulated by other contributors over the years in the pyjanitor repo that we can copy over.
The delivery is today, I will be offline for a bit. In the meantime, could you send me an email at<EMAIL_ADDRESS> (Short-whale, which I usually use, is down.) I will also send you a link to join our discord chat room.

new repo pyjviz will be used for further development of ideas described above


pass the arithmetics conversion tests

These tests: https://github.com/polystat/py2eo/tree/master/transpiler/src/test/resources/org/polystat/py2eo/transpiler/simple-tests/arithmetic-conversion
The progress is in #264

finished with #357


Cleanup UIGestureRecognizer+Spec category

Just want to get some eyes on this before merging it in. The tests removed are part of the public API, but since we were just reimplementing it, it shouldn't be necessary to test that anymore.

Thanks @tjarratt !


Downloading Images is Slow

Maybe increase the buffer size?

Increasing buffer size, won't  help, but<PHONE_NUMBER>044e520e93942418ba2429c0ba5214 added a progress bar.


accordion-item and .picker-modal fires same event

BUG
Version: 1.4.2
I have a "accordion item" within a "picker modal" and have this event:
$$('.picker-modal').on('open', '.picker-modal', function (e) {
			e.stopPropagation();
			console.log('picker opened');
		}, false);

Unfortunately, this live-event will also be triggered if one item with css-class ".accordion-item" is expanded even if the picker-modal is already opened. The same goes for
$$('.picker-modal').on('close',
If I shrink the ".accordion-item" (after it was expanded), then the close-Event of ".picker-modal" will be fired, even if the ".picker-modal" is not really closed. I guess, ".picker-modal"-open/closed events are not really isolated from ".accordion-item"-events.
According to docs, picker-modal and accordion-items uses the same event-names (.open, .close, .opened, .closed).
However, these events have to be fired isolated from the both components by f7. Bug?

Can you create a fiddle to reproduce the problem? Thanks :) http://www.jsfiddle.net

@nimo23 this is because these events has same name, use it like:
$$('.picker-modal').on('open', '.picker-modal', function (e) {
    if ($(e.target).hasClass('picker-modal')) {
        // Event generated by picker only, not by something else inside
        console.log('picker opened');
    }
}, false);

same for close event


Enhance the UI/Design

From @mindreaderlupoDO on discord:

I don't know where to put this topic, it's not a clear question, more a general discussion.
Are there any plans (by the wasp team or by anyone out of the community) to work on the OpenSaaS UI? At the moment I think it's okay but you quickly notice, that design was not the core/priority in this project. (Admin pages different to the rest, issues with responsiveness, etc.) And that's understandable because you want to introduce wasp and not tailwind.
Anyway, for me (newbie to programming in general - which might be a typical profile for a user of OpenSaas) the UI part is very important and I struggle a lot to make all my components consistent and add special things like date pickers, collapsible menus, etc.
My questions/discussions:
Would it be a good idea to integrate a design framework on top of tailwind into OpenSaaS?
What would be recommended (open source) libraries to have a straightforward developing experience with the UI as with the rest where wasp is taking care?

So actions items based on this:

Would it make sense to include a design framework in open-saas? That does sound a bit tempting to me, although it might be too opinionated, people might find it too prescriptive?
Should we take an effort of making our current design more homogeneous?
If we are not including a design framework, should we do some recommendations at least?

Oh, nice discussion going on here 🙂
I think it's always a tradeoff, If you go for one Design -Framework, you maybe miss the opportunities of another one. Since OpenSaaS should be for a broad audience (as I assume) it's also dangerous to lock in to a very specific thing which may lead to loosing the general purpose of the boilerplate.
But if the goal is to start with a SaaS in a few Days, it would be the biggest leverage of timesaving to help folks with the UI/Design -Part.
In other aspects of SaaS you pinpointed the de-facto standards with stripe, Google Analytics, Keycloak, Sendgrid, openAI,... Isn't there something like that for Design?
I don't know much, but as far as I understood, it's kind of a hierarchy of the frameworks like css is the basic for everything, tailwind simplifies the usage and then there are component-libaries like headlessUI, radixUI or daisyUI. Maybe implementing one of those including examples for typical components would help a lot.
Which kind of component is needed in any SaaS? - I think a table view of an entity which works for desktop and mobile is always needed. Forms with input, select, checkbox, date pickers and buttons is the basic to create and edit entities.
...the more I think about this question, the more I come to the conclusion that you need the full flexibility of the big component libraries.
... Maybe it's more about the workflow how to quickly integrate them consistently. Than you don't have maintaince of this part in the OpenSaaS codebase.
Those are just brainstorming and writing down unfinished thoughts.

Since I need a solution for my project, I played around with some libraries. The one I like is shadcn. Not because of the library itself but because there is a good explanation how to integrate it with wasp.
The issue I have right now is, that there are 3 opinionated Stylings: OpenSaaS-App, OpenSaaS-Admin and Chadcn. Everything comes in light and dark mode. Now refactoring everything to be consistent is a lot of annoying work 🙂
I think if this work is done once as a standard for OpenSaaS, it would be very helpful.
I will continue juggling tailwind-classes and in case the outcome is better than it was before, I will let you know 🙂


Make newer eslint command versionless

This is for clarity and so overrides continue to work without breaking config

Decided we don't want to do this, we want to change how overrides work


Added option to use a bearer token instead of query string parameters in OAuth2Request

Xamarin.Auth Pull Request
Fixes #61.
Checklist

[ ] I have included examples or tests
[ ] I have updated the change log
[ ] I am listed in the CONTRIBUTORS file
[x] I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

Added option to use a bearer token instead of query string parameters in the OAuth2Request, for more details see #61.

@dlemstra,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.
It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot


Make comparable with other

Links to #1350

It's basically identical to the comparison in the superclass so there's no need for it.

On Mar 21, 2020, at 4:24 PM, Joey RH<EMAIL_ADDRESS>wrote:

@jarhill0 requested changes on this pull request.
This looks good. One question about why WikiPage.eq has been removed.
In praw/models/reddit/wikipage.py:

def eq(self, other: _WikiPage):

   """Return whether the other instance equals the current."""

   return (

       isinstance(other, self.__class__)

       and str(self).lower() == str(other).lower()

   )

Why was this removed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks!


Revert "Revert "implement new 'reduce' API in DefaultTensorEngine""

Reverts vespa-engine/vespa#3869
@jonmv
This was not a problem after all and I closed the PR.

Merging to get the revert in the same build.


Cannot close tabs for unsaved files

Type: Bug
CMD + n to create new file
CMD + s to save new file
file save dialogue doesn't pop up. I also cannot close this unsaved file and it gets stuck open. "Close All" tabs does not close this tab. Cannot close editor as a whole without force quit.
VS Code version: Code 1.78.2 (Universal) (b3e4e68a0bc097f0ae7907b217c1119af9e03435, 2023-05-10T14:44:45.204Z)
OS version: Darwin arm64 21.6.0
Modes:
Sandboxed: Yes

System Info

Item
Value

CPUs
Apple M1 Pro (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
8, 5, 5

Memory (System)
16.00GB (0.08GB free)

Process Argv
--crash-reporter-id c495a5b5-df0c-4155-a031-c6bb0c33886b

Screen Reader
no

VM
0%

Extensions (12)

Extension
Author (truncated)
Version

vscode-color
ans
0.4.5

markdown-mermaid
bie
1.18.1

ccs-flutter-color
cir
1.0.2

vscode-eslint
dba
2.4.0

gitlens
eam
13.6.0

prettier-vscode
esb
9.13.0

rails-snippets
Hri
1.0.8

vscode-docker
ms-
1.25.1

remote-containers
ms-
0.292.0

ruby
reb
0.28.1

sort-lines
Tyr
1.10.1

vscode-ruby
win
0.28.0

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
282f8724:30602487
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
showlangstatbar:30737416
vsctsb:30748421
pythonms35:30701012
pythonfmttext:30731395
fixshowwlkth:30730052
hidesbindicator:30730055
pythongtdpathcf:30739705

Thanks for creating this issue! To help narrow it down, please take the time to follow below steps. Thanks a lot and happy coding 🙏
Is the issue caused by an Extension?
Stop VS Code and from the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If it still reproduces, jump to the next chapter.
If you see it is an issue with the extension, please run the command Start Extension Bisect and follow the instructions to find the extension that is causing this issue.

Please report the issue to the extension causing this.
Is the issue caused by VS Code Core?
If the issue is not caused by an extension, it is maybe caused by your configuration. Try to run code --disable-extensions --user-data-dir <directory> where <directory> is an empty folder. This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.
If it still reproduces, it was maybe fixed already in our nightly release. Please download from https://code.visualstudio.com/insiders/ and see if you can reproduce the issue.
Finally, to help us narrow down what change caused the issue, please run the following command to find the build. It will start previous releases of VS Code insiders to see where the regression was introduced:

npx --yes vscode-bisect@latest
follow the instructions until you found the offending build
report back the commit range in this issue

Thanks!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


fix: builds on windows

Summary
As reported by Avislux on #163 , this commit fixes building on Windows. I don't have a Windows machine to test against, but Avislux checked out the change locally and verified that it works. It also passes all integration and end to end tests.
Fixes: #163
Other Information

I'd really like to get this merged soon... Any blockers, @jthegedus ?


Add rust-cov / cargo-cov for llvm-cov

Rust now includes llvm-cov, which is used in combination with
llvm-profdata to generate coverage reports from the .profraw files
now generated by Rust binaries compiled with -Z instrument-coverage.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @reitermarkus (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Could also use a usage example for the README but that is optional. 😅

@therealprof
I realized I need to update the crate version, and yes, added a CHANGELOG entry.
Hope it's OK if I don't update README for now?
No pressure, but just wondering, when might you be able to push this update to crates.io? (I'm updating related documentation.)
Thanks!

Aggressively pushing for a release. I like your style. 😬

bors r-

https://crates.io/crates/cargo-binutils
Released. 🎉

woohoo! It already works for me after re-running cargo install cargo-binutils!
Thanks for the really fast response!