MS Python insiders extension may be crashing on Liveshare

Issue Type: Bug
I am using "python.insidersChannel": "daily" so, I try to join a LiveShare session with my student who is the host and the new VS Code window never finishes loading the extensions, but eventually the extension host declares that it crashes ("notificationsAlerts.ts:40 Extension host terminated unexpectedly.").
I am not sure if it is a liveshare issue and/or a mspython issue, so I am including all the relevant information.
Extension version: 1.0.3206
VS Code version: Code - Insiders 1.52.0-insider (caf01baa45b9816e2e1d8a2de22b40cf89459c03, 2020-11-20T07:41:44.570Z)
OS version: Windows_NT x64 10.0.20262

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3540M CPU @ 3.00GHz (4 x 2990)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.91GB (7.29GB free)

Process Argv
--crash-reporter-id 5fbb05cc-8424-46f5-a920-45fc0475991e

Screen Reader
no

VM
0%

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
openlogontheside:30221882
python763:30178808
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
python504:30227505
vswsl492:30208929
wsl2prompt:30219162
vstry914:30226749
pythonvsdeb440:30224570
unusedprompt:30219164
folderexplorercf:30219167
openfilemenu:30219168
pythonvsded773:30223139

File Logs (DevTools console log and extension cpuprofile)
ms-python.python-unresponsive.cpuprofile.txt
DevTools console log (copy-paste into plaintext)
DevTools console log (using save to file)

According to the log, you're running VSCode Insiders, but with an old version of the extension (python-2020.3.69010 - this is from March 2020). Can you try updating it?
If it's already updated, it might be that the old version was not properly removed by VSCode - this happens sometimes on Windows, e.g. because the extension folder couldn't be deleted. Take a look at c:/Users/MavaddatJavid/.vscode-insiders/extensions, and see how many folders with names that begin with ms-python.python are there. If there's more than one, you might want to delete them all and then re-install the extension, to make sure that you have a good install.

My problem currently is that when I connect to a Python project, Live Share stagnates after initially connecting. There seems to be some kind of catastrophic interaction between Live Share and Python 2020.12.387755272-dev. The Live Share session connects at first (showing the other users' live edits), but then it persistently stops working and does not show live edits. Even ending the Live Share and re-joining does not help — the session is only live for a second.
20201205_165224_16071871440090_VSCode.log
20201205_165350_Agent.log
20201205_182617_16071927775780_VSCode.log
20201205_182622_Agent.log
20201205_182630_16071927905590_VSLSAudio.log
20201205_204559_16072011592530_VSCode.log
20201205_204610_Agent.log
Extension version: 0.4.0
VS Code version: Code - Insiders 1.52.0-insider (5e350b1b79675cecdff224eb00f7bf62ae8789fc, 2020-12-04T10:15:27.849Z)
OS version: Windows_NT x64 10.0.20270

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3540M CPU @ 3.00GHz (4 x 2990)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.91GB (6.65GB free)

Process Argv
--crash-reporter-id 5fbb05cc-8424-46f5-a920-45fc0475991e

Screen Reader
no

VM
0%

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
openlogontheside:30221882
python763:30178808
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
python504:30227505
vswsl492:30208929
wsl2prompt:30219162
vstry914:30230485
pythonvsdeb440:30224570
unusedprompt:30219164
folderexplorercf:30219167
openfilemenu:30219168
pythonvsded773:30223139
pythonvspyt600cf:30228412

A PowerShell script to execute the required commands suggested by @karthiknadig in https://github.com/microsoft/vscode-python/issues/14179 (gist here):

$pyExts = New-Object -TypeName System.Collections.ArrayList # Python extensions in VS Code as an ArrayList, scoped to be accessible outside the foreach-object context below
# Get `cmd` for VS Code
#   Stable VS Code uses `code.cmd`
#   Insider VS Code uses `code-insider.cmd`
#   Thus, Stable and Insider editions both use the pattern `code*cmd`
Get-Command -Name code*cmd -CommandType Application | ForEach-Object {
    $VSCodeCMD = $_
    # Let's be sure VS Code isn't running
    if ($null -ne ($VSCodeProcs = &$VSCodeCMD --status | Select-String -Pattern '(?<cpu>\d+)\s+(?<mem>\d+)\s+(?<pid>\d+).+main' -AllMatches)) {
        # Use `taskkill` to gently request that VS Code terminate gracefully (as opposed to violently killing the process using the `Stop-Process` cmdlet)
        $VSCodeProcs.Matches.Groups | Where-Object -Property Name -EQ pid | ForEach-Object {
            taskkill.exe /PID "$_"
            (Get-Process -PID "$_" -ErrorAction SilentlyContinue).WaitForExit(3000) | Out-Null
        }
    }
    # Get a list of Python extensions and uninstall them
    &$VSCodeCMD --list-extensions |  Where-Object { $_ -match 'python' } | ForEach-Object { $pyExts.Add($_) | Out-Null }
    $pyExts | ForEach-Object {
        Start-Process -FilePath $VSCodeCMD  -ArgumentList @("--uninstall-extension $_") -NoNewWindow -PassThru -Wait
    }
    # Remove the Python extensions' folders with confirmation
    Resolve-Path (Join-Path $env:USERPROFILE "\.vs$($VSCodeCMD.Name.TrimEnd('.cmd'))\extensions\*python*") | Remove-Item -Recurse -Force -Confirm -ErrorAction SilentlyContinue
    # Reinstall the Python extensions just removed
    $pyExts | ForEach-Object {
        &$VSCodeCMD --install-extension $_
    }
}


Clarification on the json structure of "export-all"

--export and --export-all are invaluable tools to use the contracts deployment in the target project.
What I don't understand is the idea behind the double-hash of export-all format:
the returned value is hash by the chainId, and each member is a hash by the network name.
The network object returns then contains both name and chainId, and contracts info.
e.g.:
{
    "1337": {
        "dev": {
            "name": "dev", "chainId": "1337", "contracts": { ... }
        }
    }
}

I think that for all practical reasons, an array of networks is easer to use, either when a single network is needed, or when a "query" is needed to select multiple networks.
It fact, I parse the above generated structure using:
networks = Object.values(all).map(x=>Object.values(x)).reduce((arr,a)=>([...arr, ...a]))

which let me select relevant networks using either name or chainId using a simple filter() or find()

It is probably a matter of personal preferences.
The nice thing about json hash object is that the structure format guarantee no duplicate network object with same key
Also for the top level object, this is is really useful to have it be taken depending on the current chainId.
As for why each object duplicate name and chainId, it is to keep reusing the exact same format as single export

I can understand the chainId at the top level, but not the network name underneath...
for a multi-chain project, a hash by chainId might be useful, but the name as a key isn't.

I get it
But the benefit of the current structure is that you can have 2 network with the same name

not sure what you mean: you can't have two networks (say, "dev" ) under different chainIds - in the hardhat-config, the network NAME has to be unique (and also, that network name is a folder name under your "deployments/" folder, so even "hardhat-deploy" requires a globally unique name..
so we end up with a hash by chainId, which contains a single-item hash keyed by the network name...

My point was that thebcurrent format encode that restriction. An array
would not.
On Wed, Dec 29, 2021, 11:31 Dror Tirosh @.***> wrote:

not sure what you mean: you can't have two networks (say, "dev" ) under
different chainIds - in the hardhat-config, the network NAME has to be
unique (and also, that network name is a folder name under your
"deployments/" folder, so even "hardhat-deploy" requires a globally unique
name..
so we end up with a hash by chainId, which contains a single-item hash
keyed by the network name...
—
Reply to this email directly, view it on GitHub
https://github.com/wighawag/hardhat-deploy/issues/248#issuecomment-1002550387,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGBANBXMDYSEMXSUSPAK33UTLWSTANCNFSM5K4KPDHA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

yes, it does.
but the purpose of the auto-generated format is not to encode a restriction, but to be usable. right  now it is usable - but requires parsing before it can be used..

Points taken and I agree that an array would be easier to deal with.
Now I am not sure how many are using the current export-all format and changing it would be a breaking change.
But might be the best way forward.

From  v0.10.4 onward, the format is as you suggested:
export interface Export {
  chainId: string;
  name: string;
  contracts: {[name: string]: ContractExport};
}

export type MultiExport = {
  [chainId: string]: Export[];
};


Set cell size before configuring cell

This can help in situations where the size of the cell in your nib is
different than when actually loaded.

Nevermind! This ended up being unnecessary. It did help, but it wasn't the root of our problem, so this doesn't actually need merging.


OpenXR: Allow moving vendor passthrough extensions to GDExtension

This PR is implementing an idea from @BastiaanOlij in this comment:

One of the options I was thinking off is to make this purely work the way OpenXR intended. Eg:

we deprecate the is_passthrough_enabled, is_passthrough_supported, start_passthrough and stop_passthrough methods in XRInterface
we make it clear in the documentation that get_supported_environment_blend_modes returns the available modes and what they mean
we make it clear in the documentation that set_environment_blend_mode should be used for passthrough/AR

Now in the vendor plugin, for any vendor that requires additional logic, we check what environment blend mode is set to and perform the additional logic.
We could add the ability to register a callback or emit a signal when set_environment_blend_mode changes the blend mode to make starting and stopping passthrough easier for those runtimes that require that.
To keep backwards compatibility we can:

make sure that is_passthrough_enabled and is_passthrough_supported return true if XR_ENV_BLEND_MODE_ALPHA_BLEND is returned by get_supported_environment_blend_modes
have start_passthrough set our environment blend mode to XR_ENV_BLEND_MODE_ALPHA_BLEND
have stop_passthrough set our environment blend mode to XR_ENV_BLEND_MODE_OPAQUE

This PR moves XR_FB_passthrough to 'godot_openxr_vendors', which allows this PR to be tested on the Meta Quest (it's working for me!)
The one thing that's a little messy in this PR is all the stuff with emulate_environment_blend_mode_alpha_blend, which I needed to add, because the Meta Quest (which I'm testing on) doesn't actually support XR_ENV_BLEND_MODE_ALPHA_BLEND, so if we try to set it to that, it'll just refuse. I may try to think of a better way to implement this bit - I'm open to suggestions as well!
Please let me know what you think :-)
note to merge team this should not be merged until both this PR, and the vendor plugins PR mentioned up above are both finished and approved. They should be merged in unison.

Just for some extra background information for other reviewers as what David posted in the OP doesn't contain information on what got us here.
In the OpenXR spec it was always the intension to use the blend modes on the main layer to both query the capabilities of the device used and to set the mode of the device. So:

XR_ENVIRONMENT_BLEND_MODE_OPAQUE indicates the rendered image is shown as is, no blending is performed, ergo the device is a VR only device or in VR mode (camera off in passthrough, blacked out visor, etc)
XR_ENVIRONMENT_BLEND_MODE_ADDITIVE indicates the rendered image is "added" to the background, this really refers to traditional AR where an image is projected in front of the users eye (Hololens, Northstar, etc), these devices do not have the ability to fully block out the natural image the user sees.
XR_ENVIRONMENT_BLEND_MODE_ALPHA_BLEND indicates the rendered image is alpha blended with the background. This refers to modern AR that use display technology that can obscure the natural image. This currently applies to waveguide based devices (MagicLeap) and passthrough based devices (Quest, Lynx R1, HTC Elite, etc.)

The great thing about this approach is that to the developer, it is easy to recognise these 3 modes and what they mean, to query the device which modes are supported and easy to select the desired mode without worrying how the hardware achieves that goal.
The problem that was introduced, especially in relation to passthrough, was two fold.
First, it wasn't clear from the spec that this was the desired behaviour sought after for passthrough, hence currently only Lynx R1 implementing it as designed.
Second, Meta had a need to quickly provide support for an already developer passthrough implementation when they embraced OpenXR, hence adding a vendor extension that introduced passthrough implemented similarly to their VrAPI.
We at Godot, having already implemented the VrAPI flavour of passthrough, followed suit and implemented Metas vendor extension but basing the passthrough design of Godot on this.
Fast forward to today, where some vendors are adopting the OpenXR way of doing passthrough AR while others copying Metas approach, we are faced with a confusing situation of implementing multiple different passthrough implementations and presenting them to the end user.
After much discussion internally, and asking the OpenXR WG about the original intent of the spec, we decided to present AR as designed by OpenXR to the user, and solve the platform differences internally by utilising our vendor plugin approach. Hence this PR.

Also almost forgot, we have to make sure that once this is merged, we update https://docs.godotengine.org/en/stable/tutorials/xr/openxr_passthrough.html to describe using the environment blend modes.
We can then have a chapter at the end that details that for passthrough to work on Quest and HTC, users must update to the latest vendors plugin. Here we can also mention about the start/end passthrough methods being deprecated.
I might work on a draft for this.

My latest code changes adds a new method to OpenXRAPIExtension that was needed to allow the godot-cpp PR to detect that alpha blend mode isn't really supported, to prevent it trying to emulate it when not necessary.
Anyway, at this point, I think all the review that directly pertains to this PR (as opposed to refactoring for follow-ups) has been addressed, either in a comment or with a code change.

I've consolidated OpenXRAPIExtension::is_emulating_environment_blend_mode_alpha_blend() and OpenXRAPIExtension::is_real_environment_blend_mode_alpha_blend_supported() in my latest push (per the suggestion above)

Thanks!

Oops, this was supposed to wait until we merge the counter part on the vendors plugin :P No worries, we'll deal with it.
@dsnopek we need to make sure we prioritise this next week :)


feature: Instrument communication log

Make a "comm log" that can record all communication to/from an instrument, something like:
>>> source.enable_log()
>>> source.amplitude.set(0.5)
>>> source.amplitude.get()
0.5
>>> print(source.comm_log)
-> SOUR:VOLT:AMPL 0.500
-> SOUR:VOLT:AMPL?
<- 0.500
>>> souce.disable_log()  # done debugging, drop the overhead of keeping this stuff

I've added -> and <- to the written and read strings respectively to differentiate them.
Also add timestamps to each message.
As discussed in #145
cc @spauka @AdriaanRol

handled via logging module


Support typescript 2.2

Is there any reason that angular-cli depends on typescript strictly lower than 2.2 for angular 4?
If I understood right, there was no breaking changes in 2.2 (in opposition to 2.1 that had a breaking change with 2.0, which was the reason why we are blocked with 2.0 in angular 2) so there is no reason to restrict ourselves to 2.1, right?
I did some tests on my code and everything seems to be fine for now…

Angular 2.2 support is also top of my list for what I want for angular 4

This sort of stuff usually relies on the official support statement.
Also there's no guarantee that TS 2.3 won't come and break existing projects as well.
As long as Angular 4 explicitly mentions TS 2.1, that will be what the CLI will include by default.
The CLI doesn't mind if you change the version in your own project. Everything should be the same if it doesn't have a breaking change.

@Meligy ok :)
I asked because when you use yarn (I don't know for npm), it will install typescript 2.2 in the ./node_modules/typescript and typescript 2.1 in ./@angular/cli/node_modules/typescript to satisfy both requirements.

We were letting the dust settle around 2.2 for a bit, only using it on the CLI itself. I'll make a PR to update the ng4 projects and we'll see.

@filipesilva What TypeScript version should a new RC2 project be on?
I just went through the RC upgrade and with angular/cli: 1.0.0-rc.2
The package.json generated for a ng new project has:
"typescript": "~2.0.0"
So I'm on TypeScript 2.0.10
Is this correct? Or should RC2 be using a higher version of TypeScript?

@arlowhite it depends on the Angular version.
For angular 2.x.x, you should have TypeScriot 2.0.x, for Angular 4, you should end up with 2.1.x if you want to play safe (default), or 2.x.x if you are ambitious (currently 2.2.x seems safe).

Typescript ~2.2.1 is breaking serve for me on a new project.
start a project: ng new bugts --ng4 --style=scss
upgrade typescript: "typescript": "~2.2.1"
yarn install returns:

npm install works fine.
@angular/cli rc.4. node 7.7.2, osx latest, yarn 0.21.3

@scttcper for me it works flawlessly. The only problem I noticed (and it is only happening with yarn) is that some things (I think it is angular-cli so it would make sense with your problem) depends on typescript 2.1 and others on typescript 2.2, so I had to manually force the resolution of typescript 2.1 to the 2.2 version in the yarn.lock for yarn to only use typescript 2.2.

Gotcha, manually changing yarn.lock to have only typescript 2.2.x does fix it for me as well. Gross! 😉

@scttcper actually, I had to do it also to be able to have only one version of the @angular dependencies (it was bringing both v2 and v4 in some places…) :)

@victornoel I didn't have to do that for my 4.x project but i've opened #5557

I guess we're stuck waiting for angular 4 to be the default for angular-cli. #5586 The team notes said that final version could be thursday, but I'm not sure if that means v4 will be default.

This is fixed with @angular/cli v1

Yep, thanks @scttcper


Bug when building GLFW3 app with emscripten

NBind seems to fail at runtime when using GLFW3 with emscripten. During testing I would get errors about Module["canvas"] being undefined.
I have fooled around a bit with the pre.js file and discovered two versions of Module floating around in the Object tree and the one attached to the window object has a canvas value. Copying this value to the Module passed to the nbind init seems to get passed this error but still runs into other errors. (I have yet to confirm that these errors are related to nbind at all)
The most important part of this is that static initialization of GLFW3 does not work with nbind and emscripten due to the way the Module object is passed around.
I can create a basic demo later to show you what is going on, if it is needed.

Nbind will provide an empty Module object to the asm.js code unless you pass one as the first argument to init. It doesn't leak the variable from the asm.js wrapper scope, so if you have a custom Module object, passing it to init should make everything work as normal.

Thank you for the quick response. I will see what appending a custom module does after I reset the pre.js file to normal.

So calling nbind like so seems to work properly, but now I have other problems I am still swimming around in. They are unrelated to the initial issue though. Thank you for your help.
nbind.init(Module, function(err, binding) { console.log(err, binding); });


Make some internal/private sdk classes public and extensible

We have two (may be more?) internal classes: Microsoft.DotNet.DesignTools.Client.Proxies.ProxyPropertyDescriptor and Microsoft.DotNet.DesignTools.Protocol.PropertyData. It would very useful to make them public, I will explain with a concrete example from chart control (I think it's all clear from comments and code). The code from protected override void ShowHelp(). GetPropValue is my extension method to get property value with reflection:

GridItem item = grid.SelectedGridItem;
// Original code:
//_helpTopic = item.PropertyDescriptor.ComponentType.ToString() + "." + item.PropertyDescriptor.Name;

// We have a proxy object (Microsoft.DotNet.DesignTools.Client.Proxies.ProxyPropertyDescriptor) here as PropertyDescriptor.
// So to get real type we need get PropertyData (Microsoft.DotNet.DesignTools.Protocol.PropertyData) from PropertyDescriptor and then ComponentType from it.
// Because Microsoft.DotNet.DesignTools.Client.Proxies.ProxyPropertyDescriptor and Microsoft.DotNet.DesignTools.Protocol.PropertyData are internal we need to use reflection...
if (item.PropertyDescriptor.GetPropValue("PropertyData")?.GetPropValue("ComponentType") is Microsoft.DotNet.DesignTools.Protocol.Types.TypeIdentity typeIdentity)
    _helpTopic = typeIdentity.TypeName + "." + item.PropertyDescriptor.Name;

In Microsoft.DotNet.DesignTools.Client.Editors.CollectionEditor we have two private classes: DefaultCollectionForm and DefaultViewModel. I think it would helpful to make them public with ability to extend. This should make minor modifications to the default behavior easier. I find it very costly due to minimal modification to make your own dialog like in BaseUI\DesignableCollectionEditor example.

Any response on this?
@KlausLoeffelmann can you help with similar problem please? 🙏 The code above from CollectionEditor where we have ShowHelp method to change opening link, but how to achieve same result on control properties itself? If we press F1 here:

I can't find any information about it 🤔😳

Is there any hope this could happen?  At least point 1...
/cc @KlausLoeffelmann

Hey Kirsan,
sorry for the late reply.
I can't change the scope for the APIs right now, but we can revisit them for the next part of the SDK we're currently working on the context of the Root Designer.

Hey Kirsan,
sorry for the late reply.
I can't consider changing the scope for the APIs right now, but we can revisit them for the next part of the SDK we're currently working on the context of the Root Designer.

Yea, I know that changing scope is something hard to change after release, so hope that this will be done during preview 🙏
At least Point 1, will let to do stuff without reflection...


submit with CLI

Hi, I encounter problem when submitting results with CLI.
I follow the instruction, Install evalai-cli, Add EvalAI account token to evalai-cli and make submission. But when I run command evalai challenge 2094 phase 4163 submit --file <submission_file_path> --large, it report error:
Error: {'detail': 'Given token not valid for any token type', 'code': 'token_not_valid', 'messages': [{'token_class': 'RefreshToken', 'token_type': 'refresh', 'message': 'Token is invalid or expired'}]}

Use `evalai challenges` to fetch the active challenges.

Use `evalai challenge CHALLENGE phases` to fetch the active phases.

And I run evalai challenges, I got
404 Client Error: Not Found for url: https://eval.ai/api/challenges/challenge/all

It seems that there exists problem of the evalai server? Or it is my own problem?

It has been solved


Multiple Windows Explorer processes in task manager

If you open a folder or destination a new "Windows Explorer" processes is created instead of opening under the original Windows Explorer that's always running, that might not be a issue but after closing the window the processe is still in the Task manager.
Here is a short video of the task manager
Sec 2: opened the first destination/folder
Sec 6: opened the second destination/folder
Sec 7: Closed the two folders
https://github.com/user-attachments/assets/dc7d61a0-3394-4ea4-a29f-b8a11c42eacd
Edit: Using end task in the task manager work fine

Yes, this is a problem with Windows and explorer.exe. It only happens with folders, with files it culls the process after a while.
One can replicate it by executing the following command Start-Process explorer.exe C:\.
I tried many things when the script used Python, but couldn't find a solution, now that the script uses Poweshell maybe something can be done. Right now my time is limited so I can't promise a quick fix.

My system (Windows 11 Pro, 24H2) seems to check/garbage collect orphan explorer.exe processes once every 1 minute.
If I run Start-Process explorer.exe C:\ and close the window again, the explorer process will be moved down to "Windows processes" in task manager when closed. And it will disappear entirely from task manager exactly 1 minute after it was opened.
And if I keep the explorer window open for 1 min 30 sec and then close it, the process will be flushed exactly 2 minutes after it was opened (i.e. 30 seconds after closed). So this does not seem to be an issue (anymore?)

@TobbeLino Still on 23H2, will test as soon as I get the 24H2 update.

Got the update and can confirm this issue is fixed in 24H2 👌.


update crypto-perf

Fixes: #1360

Codecov Report

Merging #1361 (b83b399) into main (3c06bc4) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head b83b399 differs from pull request most recent head ce57b51. Consider uploading reports for the commit ce57b51 to get more accurate results

@@           Coverage Diff           @@
##             main    #1361   +/-   ##
=======================================
  Coverage   51.17%   51.17%
=======================================
  Files          44       44
  Lines        4879     4879
=======================================
  Hits         2497     2497
  Misses       2239     2239
  Partials      143      143

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add CMake test adapter extension to hadouken

The vscode extension "fredericbonnet.cmake-test-adapter" makes CMake tests visible in test explorer.

Scheduled to 0.10.2 release.


Fix Travis-CI support.

@malmstein assign me this issue and I'll fix it tomorrow ;)

hey @pedrovgs I made you collaborator, otherwise it can't be assigned :dancer:

haha sorry I always forgot that. Remove me as collaborator, I'll send you a PR from my fork.

fixed by @pedrovgs https://github.com/malmstein/yahnac/pull/33


firebase disconnects user when changing scene

Please fill in the following fields:
Unity editor version: 2018.3.7
Firebase Unity SDK version: 5.4.4
Additional SDKs you are using (Facebook, AdMob, etc.): email
Platform you are using the Unity editor on (Mac, Windows, or Linux): windows
Platform you are targeting (iOS, Android, and/or desktop): android
Please describe the issue here:
(Please list the full steps to reproduce the issue. Include device logs, Unity logs, and stack traces if available.)
Please answer the following, if applicable:
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?
For some reason when I log in through the Firebase auth, I go to the next scene, however, after that scene I go to another, my user is disconnected, does anyone know the reason?

This might be an issue with Unity cleaning up Firebase data between scenes. If you're holding onto the FirebaseApp object in a monobehavior and that object gets cleaned up, the FirebaseApp (and Auth) might get cleaned up with it, causing the user to get logged out. Try holding a global reference to the FirebaseApp object that will persist between scene transitions and see if that fixes the issue.

Actually, thinking about it more, you should only need to hold on to a reference to Auth, not App, so you can try making the Auth object global instead (or do both, it won't hurt)

I found it interesting, when I tested in the cellar, there was not this error of disconnecting, how can I make to remain always active the global firebase by the unity? could you show me an example?

Thanks @alexames  it works great with reference to Auth and FirebaseApp.
public static Firebase.Auth.FirebaseAuth Auth;
public static FirebaseApp App;
public static DatabaseReference DBReference;
public static FirebaseStorage Storage;

Hi @H4rdG4m3
The simple way to make FirebaseAuth alive across the scene is as @Russel1 mentioned: using a static reference.  Or you can make the Unity Object alive using DontDestroyOnLoad flag.  Or you can use Singleton pattern.
Please let us know if this resolves your issue.

Hi @H4rdG4m3 ,
I'd like to chime in here with one more pattern, storing the reference in a ScriptableObject. This will also persist between scenes, you can reference them in serialized fields, and can cut back on the some of the code smell of a static field singleton (although it's effectively the same as one).
If the suggestions here don't resolve your issue, please feel free to re-open this bug!
--Patrick


Feature request: (maybe) rename .toMatchTypeOf

Hi @mmkal! In mmkal/ts#30 I asked for clarification on .toMatchTypeOf, because its meaning wasn't clear to me from the name alone. You've updated the documentation and it is clear after reading it, but now that some time passed I had to check again because I again wasn't sure.
Original request
I'd like to request the addition of .toBeSubtypeOf as an alias to .toMatchTypeOf, and also request the addition of .toBeSupertypeOf while you're at it. What do you think?

I'd like to separate out the idea of .toBeSuperTypeOf into a separate issue, since I'm not sure I think the added cognitive overhead is worth it. If you want to create a new issue with some use cases, feel free though.
Options as I see them:
(Also @papb I've invited you as a collaborator, which (maybe) will allow you to edit this comment, so if you think of another option, you can add here)

expectTypeOf<Apple>().toMatchTypeOf<Fruit>():

Pro: Incumbent
Pro: Similar to jest expect({a: 1, b: 2}).toMatchObject({a: 1})
Con: Unclear what it means for non-object types
Con: Unclear generally what "match" means in a type context?
Con: Kinda ambiguous even when you've really thought about it a lot

expectTypeOf<Apple>().toBeSubTypeOf<Fruit>():

Pro: Pretty clear if you're familiar with types
Pro: Also clear for non-object types? expectTypeOf<'apple'>().toBeSubTypeOf<'apple' | 'banana'>()
Cons: None?

expectTypeOf<Apple>().toBeAssignableToTypeOf<Fruit>() (suggested in #12)

Pro: Unambiguous - corresponds directly to the real typescript feature
Con: [IMO] not all that intuitive. Nobody's assigning anything, really, so it forces the user to imagine a hypothetical scenario

I think 2 probably is the best, aside from toMatchTypeOf already existing and being in use quite a lot. Maybe it could be kept around as an alias though, although I also don't love doing that.

Yeah, I also like 2. above. Assignable is definitely not a good word to use because, as far as I'm aware, expect-type does not actually check for assignability anywhere and it's impossible for it to check for "not assignable"
One example I ran into recently with type-fest was this test using tsd (see PR):
expectNotAssignable<{[key: `#${string}`]: string}>({'missingLeading#': 'oops'});

In expect-type, the following does not build (though it presumably would were it truly toBeAssignableToTypeOf):
expectTypeOf({'missingLeading#': 'oops'}).not.toMatchTypeOf<{[key: `#${string}`]: string}>();

And the following does:
expectTypeOf({'missingLeading#': 'oops'}).toMatchTypeOf<{[key: `#${string}`]: string}>();

You can verify proper TS assignability in vanilla TS with something like:
function expectAssignable<Expected = never, Actual extends Expected = Expected>(arg: Actual) {}

(The extra generic param prevents arg from inferring Expected thus requiring that it is explicitly specified)
Used like:
expectAssignable<{[key: `#${string}`]: string}>({'#withLeading': 'yay'});

As far as I'm aware, you can't write vanilla TS for expectNotAssignable. Best I can do is expectAssignable + @ts-expect-error but that doesn't really scope what specifically is failing.
TS Playground with examples

I was very happy to see the invite, @mmkal, thank you very much 😁

so if you think of another option, you can add here

None comes to mind 😅
I also prefer option 2.

Maybe it could be kept around as an alias though, although I also don't love doing that.

I also think it can be kept around as an alias, but with @deprecated.

though it presumably would were it truly toBeAssignableToTypeOf

Why? You mean the fact that excess properties are allowed in object assignments in some cases?
To be honest I don't remember well what are the exact situations in which excess properties are allowed. But I noticed that your vanilla expectAssignable also does not allow it (directly from your TS Playground):
// @ts-expect-error
expectAssignable<{[key: `#${string}`]: string}>({'trailing#': 'oops'});

The PR you linked shows that even tsd's expectNotAssignable does not allow excess properties.
So maybe you're talking about something else, not excess properties? Sorry 😅

Re: extends vs assignability. See [this playground[(https://www.typescriptlang.org/play?#code/C4TwDgpgBAogHsCA7AJgZwOoEtgAt7ABOAhgAqED2YaUAvFAN4DkECJ5VTAXFEyBGCYBfKK0SoaDANoBrCCB4ADAMQASBmiJYkAcyGKAujyQBXALYAjCIREB+KERPQeAM2IAbNBADcAKAD0-lDBAHq2vr6gkLAIyOjYeADCFISEEADGwADS8gBCJsAYlLoAKuDQ9MzKSBQA7gCyxMDpuBBo3Lz8giJicZKy8kpqGlq6+kZQppbWdg6ETlCuHl5+gcFQYRHpFEiaUCgUbQByFMAAgmhoWDpICfhsZJTUPNJyClAq6pqE2nqGxuYrDY6IwmERiFh3L9lB0mBQqO0hH5fNtdsB9oc0CdzpdrrccLgijsdGVIC8Bu9PiMfmN-pNATMQVUag0mi02rD4dRhH4gA).
Basically extends from a type expression is not the same thing as assignability. Sometimes they are but sometimes they aren't.
I'm wondering if you could mimic it with a DeepBrand on each but I'm unsure.

I'm not against doing this still, but I think I will release a v1 with the API pretty much as it is since it has a decent amount of usage already, so it shouldn't really be on v0 anymore.
This can go into a v2 someday.

Update for anyone interested - I am now leaning towards deprecating .toMatchTypeOf, and replacing it in the suggested usage documentation with .toMatchObjectType (which is as strict as .toEqualTypeOf but picks the keys from the expected object only - this is the most common way I see .toMatchTypeOf being used right now), or where you really want to check if A extends B, that would live in a better-name .toExtend.
PR: #126. Example:
type MyType = {readonly a: string; b: number; c: {some: {very: {complex: 'type'}}}; d?: boolean}

expectTypeOf<MyType>().toMatchObjectType<{a: string; b: number}>() // fails - forgot readonly
expectTypeOf<MyType>().toMatchObjectType<{readonly a: string; b?: number}>() // fails - b shouldn't be optional
expectTypeOf<MyType>().toMatchObjectType<{readonly a: string; d: boolean}>() // fails - d should be optional

expectTypeOf<MyType>().toMatchObjectType<{readonly a: string; b: number}>() // passes
expectTypeOf<MyType>().toMatchObjectType<{readonly a: string; d?: boolean}>() // passes

This still isn't .toBeAssignableTo, or .toSatisfy, but I think it's ok. There's still value in the new methods, and both assignability and satisfies are concepts relating to values, rather than types. I'm open to hearing use cases or implementation ideas for them though.


add deprecation notice to socialbakers and emplifi connectors

Link to Emplifi (formerly Socialbakers) docs: https://docs.emplifi.io/platform/latest/home/how-to-set-up-power-bi-connector.

@microsoft-github-policy-service agree company="Emplifi"

Hi, is there anything else required to merge this PR?

@alesmenzel - "(Deprecated)" should also be added to the table of contents entries for both the Emplify Metrics and the Socialbaker Metrics connectors. The table of contents file is toc.yml.
In addition, "(Deprecated)" should be added to the list of all connectors instance for both the Emplify Metrics and the Socialbaker Metrics connectors. The list of all connectors file is connectors/index.md. In this file, you should also change all check marks (yes.png) to "X" (no.png) to indicate the deprecation.

#sign-off


Global exception handler

We need a global exception handler that renders exceptions in the console and web apps in a convenient way. Most exception handlers have many bells and whistles which I don't think we need for now, but it would be nice to have readable output.
We'll also need to provide an extension point if people want to hook in their own (third party) Exception handler. Maybe this could be done with events (still wip: #6 )

Ok, so, there's a preliminary implementation in place. It's currently disabled by default, you can enable it by adding this env variable:
EXCEPTION_HANDLING=true

It would be nice if some people play around with it, because I believe there's lots of room for improvement still

For the console implementation, I've written a very basic exception handler that prints out basic info.For the HTTP implementation, I just use Symfony's var dumper for now. I made an issue for future improvements: #150


feat: add sync mode for subscription events

close https://github.com/hasura/go-graphql-client/issues/113
Add a new syncMode option to allow subscriptions to execute messages in sequence (without goroutine)
client.WithSyncMode(true)

I haven't tested in-depth about extremely high race condition use cases. However, there would be some locks on the read-message loop. For example, if the execution is too long, other messages will be locked or discarded from the WebSocket client.
So we should keep the async mode to avoid breaking changes for other users. It would be great if you could test and prove the sync mode works without issue. Thanks

I have heavily tested this version in my project, which has numerous subscriptions, and I have not encountered any issues. I think it can be merged.


⚠ Processors has degraded performance

In 3aaf6f9, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 40 ms

Resolved: Processors performance has improved in 75139c0.


Release V2.1.0

We release new client version that tackles some of the most frequent bugs and requested features:

Fix "Connection Reset by peer" error after long idle periods - asana
Add typing and explicit names for arguments in all client operations - asana
Add docstrings to all client operations - asana
Support batch upsert by passing batch_size to upsert method - asana
Improve gRPC query results parsing performance. this expect to reduct gRPC latency in 'with metadata' cases 50-70% - asana

All integration tests passed: https://github.com/pinecone-io/iac/actions/runs/3829339579


Feature Addition: Static members

Can now specify "static" for functions and properties, to have them be
attached to the class it's self, rather than it's instances.
Does NOT break backwards compatibility.
Not ready to be merged, but wanted to get things started. Seems to be working correctly, but limited unit tests so far. Would appreciate help thinking of more unit tests.
Two ways to access the inner (private/protected) static scope:
var MyClass = JOII.ClassBuilder('MyClass', {}, function (MyClass) { return {
    'private static number num' : 1,
    'public static string str' : 'Works!',
    'public test()' : function() {
        MyClass.num = 2; // uses the variable passed to this function
        this.getStatic().num = 3; // uses the getStatic() private method to retrieve access to the inner static scope
    }
}});
MyClass.getStr(); // returns 'Works!'

Hmm....
I don't like the way the developer has to use getStatic() to get to the static-scope.
Since objects can be referenced, why not just call it static?
I'd rather do this:
var MyClass = Class({
    'public static number foobar': 42,

    construct: function () {
        this.static.foobar = 50;
    }
});

console.log(MyClass.foobar); // This _should_ work and return 42.

new MyClass();

console.log(MyClass.foobar); // This _should_ work and return 50;

Since scalar values can't be used as pointers/references, I ran into this problem myself a long time ago. Hence I decided not to implement it. The way it can be achieved is indeed to use some sort of scope (object), but the way people had to use it wasn't something I liked - at all. There's also a performance impact since you have to re-bind an object to the correct scope everytime you instantiate a class, while this should only happen when you declare a class.
I would love to see a correct implementation for this, but I think there are more cons to this than pros :disappointed:
Right now, using the "const" property type does somewhat what you'd expect it to do.
var MyClass = Class({
    'const foobar': 42
});

console.log(MyClass.foobar); // 42.

The only problem with this approach is that even though the property is declared as const, it can still be modified. I haven't found a way to protect these properties from being modified. This means that effectively, the variable is a static, as long as it's called from the class declaration rather than an instantiated object:
var mc = new MyClass();

console.log(MyClass.foobar); // 42
console.log(mc.foobar); // undefined

I don't like the way the developer has to use getStatic() to get to the static-scope.
Since objects can be referenced, why not just call it static?

static is a reserved word in javascript, otherwise I would have liked to use that.
Also - they don't need to use it if they're using the function method. They can use the argument passed in to access the private static scope (probably name it the same as the class, for consistency).
Example:
var MyClass = JOII.ClassBuilder('MyClass', {}, function (MyClass) { return {
    'private static number num' : 1,
    'public construct()' : function() {
        MyClass.num = 2; // uses the variable passed to this function
    },
    'public test()' : function() {
        returns MyClass.num; // uses the variable passed to this function
    },
    'public static staticTest(number)' : function(num) {
        returns MyClass.num + num; // uses the variable passed to this function
    }
}});
var mc = new MyClass();
mc.getNum(); // undefined, because private
mc.num; // undefined, because private
mc.test(); // returns 2
MyClass.staticTest(2); // returns 4

But how is this significantly different than the current const implementation?
There isn't that much difference that's worth all this overhead.
I mean, const does exactly this (maybe it should be renamed to static instead), with the exception that it can't be used from a this-scope, but rather directly from the declared class function-prototype itself.
A usecase would be to have "namespaced" classes, for example:
var MyFramework = Class({
    'public static Router': Class({
        /* ... */
    }),

    construct: function () {
        this.Router; // undefined because it's static.
        MyFramework.Router; // Class.
    }
});

var router = new MyFramework.Router();
MyFramework.Router = "foobar"; // Since it's static, not a constant, this is allowed. (there isn't really a way to prevent this anyway...)

I don't really see any use-cases where one would have to use the "static-scope" over the current const implementation. Unless I'm missing something entirely (in which case, please exaplain ;)), I don't see that much difference between the two.

Because it enforces getter/setter, can take advantage of immutable, and best of all - static overloadable functions.

Alright.
Please extend the unit tests a bit, where there are also cases where inheritance is involved with static methods.
Once unit tests are complete, I'll merge it! :+1:

I removed support for:
this.getStatic()
since it was causing problems with proper static inheritance. The only way to reference static now is through the classname.
Also - static variables NEED to be referenced through getName()/setName(), even in a private/protected scope now for inheritance reasons (since static variables live in the class they're defined in even when inherited).

Looking good 👍
I'll hold on tagging this in a release until documentation with some code examples are created.


Send fewer indexing requests to OpenSearch in parallel on staging

So that OpenSearch don't end up leaving requests hanging for more than 30s.
Fixes #290, hopefully.

Note we'll have to watch staging carefully after merging, because if this number is too low it may result in initial indexing taking too long and k8s ending up in a crash loop. See also https://github.com/quarkusio/search.quarkus.io/issues/207#issuecomment-2197143649, which could help avoid that kind of crash loop.


podmanv2 mount and umount

add the ability to mount and unmount containers for the local client only
Signed-off-by: Brent Baude<EMAIL_ADDRESS>

LGTM

/hold
/lgtm

/hold cancel

/lgtm


Updated docker file to Dockerfile

Updated to use the the Dockerfile name.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@jweissig : Thanks for your contribution to the Azure documentation! The author, @mikkelhegn, has been notified to review your proposed change.

#sign-off


Import/Export Service API CHANGE... Missing GenerateShippingLabel API Call

A call to the Import/Export Service API, specifically, an import call to CreateJob, use to return a field called 'AwsShippingAddress' which no longer exists. Instead it requests a call to GenerateShippingLabel, which is not currently possible in botocore, AWS CLI, or boto3. The API version number has not changed, so why did the API change? Or am I missing something?
Now CreateJob states as part of the response['WarningMessage']:
Please use GetShippingLabel API endpoint to print your shipping label.

Note response was created with:
    client = session.create_client('importexport', 'us-east-1')
    response = client.create_job(ValidateOnly=True, Manifest=final_manifest, JobType='Import')

A quick search of the documentation shows the new GetShippingLabel action: http://docs.aws.amazon.com/AWSImportExport/latest/DG/WebGenerateShippingLabel.html
Notice that the botocore client interface is missing the generate_shipping_label function:
    In [61]: client = session.create_client('importexport', 'us-east-1')

    In [62]: client.
    client.can_paginate   client.get_paginator  client.update_job
    client.cancel_job     client.get_status     client.waiter_names
    client.clone_client   client.get_waiter
    client.create_job     client.list_jobs

Note the low-level interface does not support the operation:
    In [64]: import_export_api = session.get_service('importexport')

    In [65]: endpoint = import_export_api.get_endpoint('us-east-1')

    In [66]: import_export_api.operations
    Out[66]:
    [Operation:CancelJob,
     Operation:CreateJob,
     Operation:GetStatus,
     Operation:ListJobs,
     Operation:UpdateJob]

@danielgtaylor, @jamesls, could we get an update on the status of this? This API change broke our product for a client and we are stuck waiting for a fix. Why did the API change without boto being updated and without a version number of the API being updated?

@kingb This is now fixed in the latest release of botocore (0.85.0) from last week.  Looks like the commit that fixed this was not linked to this issue.
I apologize for the delay in getting this API updated.  Generally, we are in sync with service updates as they occur.  We've passed along feedback about this breaking change to the service team.  I agree that breaking changes generally have an API version bump.  We will work to ensure this does not happen again.  Thanks for your patience with this.

@jamesls Excellent. Thank you for the update. I appreciate you looking into the sync with service updates. Thank you for all your hard work on this. Keep up the great work guys! Much appreciated!


fix: apply should not fail on no changes

Codecov Report

Merging #29 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #29      +/-   ##
============================================
+ Coverage     79.39%   79.45%   +0.06%
+ Complexity      241      240       -1
============================================
  Files            51       51
  Lines           990      993       +3
  Branches         57       57
============================================
+ Hits            786      789       +3
  Misses          174      174
  Partials         30       30

Impacted Files
Coverage Δ
Complexity Δ

...n/java/com/devshawn/kafka/gitops/StateManager.java
59.53% <100.00%> (ø)
30.00 <0.00> (ø)

...va/com/devshawn/kafka/gitops/cli/ApplyCommand.java
83.33% <100.00%> (+2.38%)
3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b18aa...03a64e3. Read the comment docs.


Crowdin API v2, OAuth v2, open/save/sync as Xliff all files with translations

Added support (from customer's prospective):

Crowdin for enterprise

Works with Crowdin Enterprise accounts of any organization (on any domains)

Open/save/sync as Xliff any file which can be parsed for translations by Crowdin

Improved

Path to locally stored Crowdin files contains <project ID> <project name>/<lang code>/<branch><path to file in Crowdin project>

Migrated to new:

OAuth v2
API v2

Thanks!
Any chance you could break it into topical, one PR per one thing, PRs, though? This is huge, with several unrelated topics and apparently work-in-progress commits like fixing previous ones or "playing" with stuff, "work in progress" etc., which makes it extremely hard to review.
E.g. 64075831c26fb0ea91800ebf1213e57c1e047883 does many unrelated things, none seem at a glance related to what it says it does. Some, like de223d8352ed6949f07ddc1e45b1d73d4f44a400 or the other version changes, don't make sense to me.

Any chance you could break it into topical, one PR per one thing, PRs, though?

May be rather as single PR but just with more granular and stepped commits just without "work in progress", "playing with stuff" and mixing with version update and other unrelated topics per commit? Since nevertheless most of things in this PR are highly correlated and dependent each from other so without most of commits some of functionalities or improvements would be just broken and incomplete so it might be even most complicated to review one PR without other. Goog examples:

New API v2 does not work with old OAuth since they just does not accept token from it
New OAuth v2 does not work with old API v1 since they just does not accept token from it.
.po saving/syncing does not work with new API v2 due API v2 does not include file and project ID as x-headers inside .po
Open/save/sync as Xliff  to/from Crowdin does no work with old API v1 since they just does not allow to download or upload any translatable file as Xliff

Thought in any case I will try to group/split and squash commits by real mostly complete functionalities/improvements within next week and will let you know once done. And if you will still prefer those already rearranged commits to be spread as separate PRs nevertheless - I will do this as well just to follow and reach your expectations to simplify review

May be rather as single PR but just with more granular and stepped commits

Yes, you're right. What I'm after is having clearly separated smaller chunks that are self-contained (except having dependencies on prior commits), do exactly one thing, and are easier to review as a whole: I can assess that this part is OK, I understood the whole picture and focus on the rest now. For example, there are some independent bits that the rest depends on, such as http_client additions, new dependency additions (those don't make sense on their own, sure, but touch so many things it's better to just keep them in a single commit).
I'll try to do some initial review as-is, but please keep in mind that it's going to be superficial, i.e. focusing on the things easily spotted in a wall-of-diff, rather than on actually important higher-level review. Apologies for that in advance.

I'll try to do some initial review as-is, but please keep in mind that it's going to be superficial, i.e. focusing on the things easily spotted in a wall-of-diff, rather than on actually important higher-level review. Apologies for that in advance.

May be better for you to hold on with reviewing as is until I rearrange according to your expectations (hopefully within first couple days of this week, that is why I made this PR as draft for a while just to better get your opinion/impression/expectations). So you would just save your time and efforts while doing what you really like to focus on during review and having more consistent picture of what is why and for what.

May be better for you to hold on with reviewing

Sure. I figured it was worth getting some sense of the scope and comment on trivia that are ideally dealt with precisely when cleaning up stuff.

Closing this in favour of #633 as to final clean version of this (as @vslavik mentioned by email it makes sense) so all further work (final review, discussion, refinements etc) moving to there


404 not handled correctly with multilingual websites when defaultContentLanguageInSubdir enabled

Preliminary Checks

[X] This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/HugoBlox/hugo-blox-builder/issues?q=is%3Aissue
[X] This issue is not a question, feature request, or anything other than a bug report directly related to Hugo Blox Builder. Please post those things on Discord: https://discord.gg/z8wNYzb

Description
When setting  defaultContentLanguageInSubdir: true, 404 error at the website roots are not handled correctly because hugoblox doesn't generate a 404.html at the root. Then it's the server 404 error page instead of hugoblox default one.
Reproduction Link
https://github.com/CravateRouge/CravateRouge.github.io
Steps to Reproduce

Set defaultContentLanguageInSubdir: true in hugo.yaml
Put all website content into content\en
Remove public folder and relaunch hugo server
Access to a non existing page of the website e.g. example.com/blabla and you'll see the server error page instead of the hugoblox one
...

Expected Result
We should have the standard hugoblox 404 page:

Actual Result
We have the default 404 server page:

What Hugo Module versions does your site use?
module github.com/HugoBlox/theme-landing-page
go 1.19
require (
github.com/HugoBlox/hugo-blox-builder/modules/blox-plugin-netlify v1.1.2-0.20231108143325-448ed0e3bd2b
github.com/HugoBlox/hugo-blox-builder/modules/blox-tailwind v0.2.1-0.20240602133901-492e343c2a33
)
What operating system(s) are you seeing the problem on?
Windows, Android, iOS, Linux
What browser(s) are you seeing the problem on?
Firefox, Microsoft Edge
Which Hugo Blox template are you using?
Landing Page
What version of Hugo are you using?
0.126.3

maybe this solution will solve your problem click


Add meaningful error for CSV parsing when source_identifier column is not present

Given a CSV Parser that has a source_identifier field
And a CSV that does not have a column for the source_identifier field
When I got to import that CSV
Then I should receive a meaningful error message indicating that I'm missing a required field

The documentation on required fields is something that should be enforced.
At present, if I have a CSV that lacks the source_identifier column, I get the following exception:
IndexError:
  string not matched
# ./app/models/concerns/bulkrax/has_matchers.rb:70:in `[]='
# ./app/models/concerns/bulkrax/has_matchers.rb:70:in `set_parsed_object_data'
# ./app/models/concerns/bulkrax/has_matchers.rb:55:in `block in add_metadata'
# ./app/models/concerns/bulkrax/has_matchers.rb:31:in `each'
# ./app/models/concerns/bulkrax/has_matchers.rb:31:in `add_metadata'
# ./app/models/bulkrax/csv_entry.rb:87:in `block in add_ingested_metadata'
# ./app/models/bulkrax/csv_entry.rb:85:in `each'
# ./app/models/bulkrax/csv_entry.rb:85:in `add_ingested_metadata'

The exception is opaque in regards to the underlying problem.

I'm investigating this further, as there might be something more going on.


Missing Property File in the git server cause the Applition to keep retrying and putting load on git server

Hi All,
I am looking at the option for protecting the config server against multiple request from rogue app.
If the application property file is missing in the GIT Server, it will be retrying continuously. Do we have the option to stop retrying ? My understanding is failfast work in case config server is down.
This has been causing issues and bombarding the git server with multiple calls continuously.
Can we have it wrapped as part of the hystrix and have circuit breaker enabled for such calls to limit the number of request hitting the git server.

I don't think config client retries on a missing property. Config client doesn't know if a property is missing or not. Something else is going on. Maybe a health check?

It's a container based application and keep restarting. But still let's assume I am hitting continuously through postman , Can we put some circuit breaker on it to stop same request from hitting again and again

This one may help to protect the git server at least: https://github.com/spring-cloud/spring-cloud-config/pull/749

I don't know there's much we can do here. You can setup the retry along with fail-fast an exponential backoff.


Please provide a docker-compose file that can use the provided dockerfile

I would love to deploy this. Can you please provide a docker-compose file...thanks!

me too

https://github.com/InternLM/MindSearch/pull/97

this would be awesome especially if we could use SearNXG as the search engine :)


Implement dependency locks

Feature Request
Desired behaviour
https://docs.npmjs.com/cli/shrinkwrap

Seems to work to make staging.dockstore.org deployment with docker-compose more reliable


fix(module:drawer): header scrolling position  style

Issues  #3274
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3274
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@DreamPWJ ZORRO 不会主动修改 ant-design 样式，而是通过机器人与 https://github.com/ant-design/ant-design 样式保持同步，你可以向  https://github.com/ant-design/ant-design 提交 PR，合并发布之后将自动同步此样式。

@hsuanxyz  我都提交了issues了，但是react那边给关闭了，不处理https://github.com/ant-design/ant-design/issues/16113#issue-433574268

https://ng.ant.design/components/drawer/zh#components-drawer-demo-from-drawer


Cloudtrace plugin

Current state is not propogating spans correctly.

testing with various main.py's that look like the following. the spans are not being nested properly, which makes me suspect the context is not being set and passed along properly.
from goblet import Goblet, goblet_entrypoint, jsonify, Response
from goblet.resources.plugins.opentelemetry_goblet_instrumentation import GobletInstrumentor
# import sys
import logging
# from opentelemetry.trace import Link
from opentelemetry import trace

app = Goblet(function_name="tracing")
goblet_entrypoint(app)

GobletInstrumentor().instrument_app(app)

app.log.setLevel(logging.DEBUG)  # configure goblet logger level

@app.http()
def test_route(request):
    app.log.info(dir(app.g))
    ctx = app.g.prop.extract(carrier=app.g.carrier)
    # context = trace.get_current_span().get_span_context()
    with trace.get_tracer(__name__).start_span("child", context=ctx):
        print("test")
    return "tracing"

Codecov Report
Base: 88.72% // Head: 88.72% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (3a3797a) compared to base (6b75e48).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   88.72%   88.72%
=======================================
  Files          45       45
  Lines        3654     3655    +1
=======================================
+ Hits         3242     3243    +1
  Misses        412      412

Impacted Files
Coverage Δ

goblet/decorators.py
86.30% <100.00%> (+0.06%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add Archive plugin

Pull Request Test Coverage Report for Build 113050601

43 of 44 (97.73%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 54.453%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

plugin/archiveplugin/hooks.go
38
39
97.44%

Totals

Change from base Build 112220724:
0.09%

Covered Lines:
1339

Relevant Lines:
2459

💛  - Coveralls


Command Locale

CI fail has been fixed on main, this PR contains only locale changes and does not checked by lint anyway.


Add batch compressing of bundle files

Be able to load all bundles in a folder, select destination folder, keep the name of the files the same. Select compression method like you do for single files. Batch compress into destination folder.

Already planned and work in progress for UABEANext. Closing this since we have like 10 of these requests.


Simulate smoke-test locally

We should have a script to simulate the smoke-test locally, that can run as part of a pre-commit hook. This can help to avoid situations where CI failures cause lost time.

This would be hard: On the Python side, we could look at something to like tox to manage different environments, but that's only part of the picture.
I'd suggest looking at the places where we have been surprised by failures in CI, and focus on improving those; The notebook failures when python tests pass has been a problem recently, and I can try making an improvement there.


IPv6 Support

Docker v1.5 added IPv6 support, could you please add IPv6 addresses in the structure emitted by docker-gen?

It doesn't look like the underlying library used by docker-gen supports IPv6: https://github.com/fsouza/go-dockerclient/search?utf8=✓&q=LinkLocalIPv6Address
Neither does samalba/dockerclient, the more popular Go library for the Docker API, though they at least have an open PR: https://github.com/samalba/dockerclient/pull/114

Fixed via #122


Select Application

Add ability to change servicenow application.
Available update sets should reflect the current application.
Maybe same for available records when adding.

Remaining tasks.

[ ] Cached records to cross scope boundary.
[ ] Ensure quickpick item detail always show scope.
[ ] Store Selected application in cache
[ ] Reestablish Application and update in case of session timeout.
[ ] Implement test - Refresh record
[ ] Implement test - Change update set
[ ] Implement test - Change Application

Steamline caching of script includes.

All but codelense have been added in #165


feat(lib/vscode): add log out to application menu

This adds a new option to the Application Menu called Log out. It deletes the code-server cookie and logs a user out.
Screenshot

TODOs

[x] use vscode logger
[x] refactor Cookie to be in lib/vscode so we can use it
[x] write e2e test
[x] refactor Cookie and don't share between lib/vscode

Fixes #778

So I was wondering why tsc was "failing" to use outDir...
Turns out it was, but since we import from lib/vscode in src now, what used to be out/node/entry.js has now become out/src/node/entry.js (and there's an out/lib/vscode/.../cookie.js).
Since our build script, ./ci/steps/build-code-server.sh looks for out/node/entry.js, it fails.

I think it might be best to just duplicate the key cookie.

Ah okay. Yeah it doesn't seem worth it to have to fix everything else for one thing to not be duplicated 😂 thanks for looking into this! I'll convert to draft and fix!

Love this!

Nice! Just a thought - can you also add it to the profile icon at the bottom of the left sidebar? That seems like the most intuitive place to look for it.

@binaryfire thanks for the suggestion! There's some issues with the profile icon (see #2913) but when we work on that, we can consider it! Feel free to leave more thoughts there


routes not working after clearing route cache

after I published routes  everything was working fine and then I added new resource controller and added routes to it in routes/admin.php. when I couldn't see the newly added routes I ran php artisan route:clear. but after that all routes in admin.php are suddenly not working for some reason
Laravel Version 7.5

my bad, I was looking for /admin and the real route is /Admin


[Callout Quote and Media]: design updates

The problem
The Callout Quote and Callout with Media components need some design updates:

Option to use a light background to align to the updated brand direction
Review how the callout components are aligned to the grid.

The solution
Background color
Considerations:

ui-background (g10 in white theme)
Possibly incorporate a cyan 10 or other colors for Callout Quote only (with media will possibly look strange on a colored background)

Grid alignment

The callout components currently overhang further than cards or images on the grid.
The type is not aligned to other components, and is inset 64px(reference specs)
Explore alternative grid alignment

Container should not hang farther than the cards or images
Consider 8 column and 12 column layout?

Resources

Callout Quote specs Sketch
Callout with Media specs Sketch

Application/website
Carbon for IBM.com
Business priority
Low Priority = release date is not dependent on fix or not upcoming
What time frame would this ideally be needed by (if applicable)
No response
Examples

White theme page

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate issues

Figma file
Feedback in Design crit 10/27/22

Double check color contrast for g10, cyan10 themes.
Overhang 16px should stay on both sides.
To display a quote that aligns with the type of a content section, you can use quote component.
Add color options to callout quote - regular color theme from quote, gray10 background, and cyan10.


Support PyTorch DDP compatibility layer.

it is now supported by https://github.com/BaguaSys/bagua/pull/312


⚠ Bofrost.at has degraded performance

In f8a0169, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1063 ms

Resolved: Bofrost.at performance has improved in 2800389.


Add blog config

Set up blog path, default author, and date format in config.

Hello, could you add those new vars to the README so other people know whats going on?

@ibarria0 Done. Perhaps koenbok/CactusBlog should also be transferred to eudicots and updated with the newer Cactus?

@antons Indeed. I will email Koenbok about that.


Linker script references palette file, but Ci4/Palette segments don't generate one

I have a segment with a ci4 image called data/map/test_grid/test_grid_txt and a corresponding palette called data/map/test_grid/test_grid_tlut.rgba16 as follows.
# ...
  - name: test_grid
    type: code
    vram: 0x06000000
    start: 0xBD8EC0
    subsegments:
      - { start: 0xBD8EC0, type: ci4, name: img/map/test_grid/test_grid_txt.ci4, palette: img/map/test_grid/test_grid_tlut.rgba16, width: 64, height: 64 }
      - { start: 0xBD96C0, type: palette, name: img/map/test_grid/test_grid_tlut.rgba16, size: 0x20 }
# ...

This works fine, but when running splat, it references a non-existing test_grid_tlut.rgba16.pal palette file in the linker script. I assumed this file was being generated by Splat (similar to the ci4 png that is generated)

However, this is not the case. I have tinkered with the configuration a number of different ways to see if I was missing something to get Splat to generate the palette file, but no luck. I also browsed the source code of N64SegCi which parses the palette. I noticed there is no line to save the parsed palette to disk, similar to how N64SegPalette saves the raster here.
def split(self, rom_bytes):
    if self.raster is None:
        # TODO: output with no raster
        log.error(f"orphaned palette segment: {self.name} lacks ci4/ci8 sibling")

    assert self.raster is not None
    self.raster.n64img.palette = self.parse_palette(rom_bytes)  # type: ignore

    self.raster.n64img.write(self.out_path())
    self.raster.extract = False

Long story short, I just want to understand if this is a bug, or if I am misunderstanding how to use these segments properly.
Thank you for the great work with Splat!

You can find most of us on the public N64 Decomp discord server :+1:

@blazkowolf linked the recent PR to your issue just cause you might care to know, the way palettes and ci segments are linked has changed a bit, hopefully for the better. let us know if you have any questions :)


Could NOT find PythonLibs (missing: PYTHON_LIBRARIES) (found version   "2.7.12")

I changed this to this
-SET(PYTHON_LIBRARY "/usr/lib/python2.7/config/libpython2.7.so")
+SET(PYTHON_LIBRARY "/usr/lib/python2.7/config-x86_64-linux-gnu/libpython2.7.so")
However I still get this error:
`-- The C compiler identification is GNU 5.4.0
-- The CXX compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1")
-- Checking for module 'opencv'
--   Found opencv, version 2.4.13
-- Boost version: 1.58.0
-- Found the following Boost libraries:
--   python
--   system
-- Found PythonLibs: /usr/lib/python2.7/config-x86_64-linux-gnu/libpython2.7.so (found version "2.7.12")
-- Boost version: 1.58.0
-- Found the following Boost libraries:
--   python
--   system
CMake Error at /usr/share/cmake-3.5/Modules/FindPackageHandleStandardArgs.cmake:148 (message):
Could NOT find PythonLibs (missing: PYTHON_LIBRARIES) (found version
"2.7.12")
Call Stack (most recent call first):
/usr/share/cmake-3.5/Modules/FindPackageHandleStandardArgs.cmake:388 (_FPHSA_FAILURE_MESSAGE)
/usr/share/cmake-3.5/Modules/FindPythonLibs.cmake:265 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
cmake/boost-python.cmake:10 (find_package)
CMakeLists.txt:26 (boost_python_module)
-- Configuring incomplete, errors occurred!
See also "/home/nicolaetitus12/github/numpy-opencv-converter/build/CMakeFiles/CMakeOutput.log".`

Try commenting out the 2nd pythonlibs line:
SET(PYTHON_LIBRARY "/usr/lib/python2.7/config/libpython2.7.so")

Worked in my Ubuntu: install the following dependencies:
sudo apt-get install python3-dev python3-pip python3-tk python3-lxml python3-six

thanks, I'll try this again soon

I have the same problem. Installing python3-dev python3-pip python3-tk python3-lxml python3-six doesn't solve it. Give me the error:
-- Boost version: 1.62.0
-- Found the following Boost libraries:
--   python
--   system
CMake Error at /usr/share/cmake-3.5/Modules/FindPackageHandleStandardArgs.cmake:148 (message):
  Could NOT find PythonLibs (missing: PYTHON_LIBRARIES) (found version
  "3.5.2")
Call Stack (most recent call first):
  /usr/share/cmake-3.5/Modules/FindPackageHandleStandardArgs.cmake:388 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.5/Modules/FindPythonLibs.cmake:265 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  cmake/boost-python.cmake:10 (find_package)
  CMakeLists.txt:25 (boost_python_module)

I have the same problem. Installing python3-dev python3-pip python3-tk python3-lxml python3-six doesn't solve it. Give me the error:

Maybe you can try installing all the corresponding packages from Python 2.7 as well (at least that is possible to find), i.e. something like python-dev python-pip python-tk python-lxml python-six. You may use aptitude search python, etc. to find which are available. That's because I believe this error is due to some specific library missing.

There are tons of packages for python2.7, installing all of them would be unrealistic. I installed the packages you mentioned, but still no luck. Then I manually edited the CMakeCache.txt to set values for PYTHON_INCLUDE_DIR, PYTHON_LIBRARY, PYTHON_LIBRARY_DEBUG, PYTHON_LIBRARY_RELEASE, which were apparently not found as indicated by the NOT_FOUND value. Then I run cmake .. again, and make. Don't know if solved the problem, because then I ran into the problem of opencv3, as in issue #9.
I guess something went wrong when cmake tries to find python library, don't know why.

I tried to fit CMakeLists.txt to my Ubuntu.

/usr/lib/python2.7/config/libpython2.7.so ===> ```/usr/lib/python2.7/config-x86_64-linux-gnu/libpython2.7.so``

but it doesn't work for me.
However, the following works well.
my local commit log is following :
-if (NOT PYTHON_INCLUDE_DIRS OR NOT PYTHON_LIBRARY)
-    SET(PYTHON_INCLUDE_DIRS "/usr/include/python2.7")
-    SET(PYTHON_LIBRARY "/usr/lib/python2.7/config/libpython2.7.so")
-endif()
+#if (NOT PYTHON_INCLUDE_DIRS OR NOT PYTHON_LIBRARY)
+#    SET(PYTHON_INCLUDE_DIRS "/usr/include/python2.7")
+#    SET(PYTHON_LIBRARY "/usr/lib/python2.7/config-x86_64-linux-gnu/libpython2.7.so")
+#endif()
+include_directories("/usr/include/python2.7")

and then, I tried to edit cmake/boost-python.cmake a little because python 2 and 3 is installed on my Ubuntu. I don't know it is important but did it.
my local commit log is following:
-  find_package(PythonLibs REQUIRED)
+  find_package(PythonInterp 2.7 REQUIRED)
+  find_package(PythonLibs 2.7 REQUIRED)

두 파일을 변경하고 README 에 있는 대로 수행하면 잘되었다.

if you are using cmake v3.12 or later, use variable Python instead of PythonLibs and PythonInterp. see https://chttps://cmake.org/cmake/help/v3.12/module/FindPython.html

What file are you modifying? I'm having a similar error

if you are using cmake v3.12 or later, use variable Python instead of PythonLibs and PythonInterp. see https://chttps://cmake.org/cmake/help/v3.12/module/FindPython.html

Thanks!

if you are using cmake v3.12 or later, use variable Python instead of PythonLibs and PythonInterp. see https://chttps://cmake.org/cmake/help/v3.12/module/FindPython.html

Thanks!


Flag Button , Picker view, list view not showing flag image

@IBOutlet weak var fpnTf: FPNTextField!
fpnTf.setFlag(countryCode: .ID)
I already tried to set it like that in the documentation. But the image won't show. Is there anything that I missed ?
It's like leaving a blank margin there. Please help

Same here! Have someone found a solution?

It seems to be working if I first try to directly load a dummy image from the framework's bundle, for example in my AppDelegate, using this simple line of code UIImage(named: "", in: Bundle.FlagIcons, compatibleWith: nil)... but I'm wondering why! 🤷🏻♂

It seems to be working if I first try to directly load a dummy image from the framework's bundle, for example in my AppDelegate, using this simple line of code UIImage(named: "", in: Bundle.FlagIcons, compatibleWith: nil)... but I'm wondering why! 🤷🏻♂

UIImage(named: "", in: Bundle.FlagIcons, compatibleWith: nil) worked for me


publish: expand rel-shortlinks

bug: when publish finds a rel-shortlink link and uses it as the backlink, it should fully expand it first. details in swentel/indieweb#411. thanks @swentel @yoroy for reporting!

deployed the fix.

Works: https://twitter.com/royscholten/status/1130845783782301701
Thank you!


Fix bug in ASGI when no content-length header

Overview
Previously, if there was no content length header and browser injection was enabled, the ASGI wrapper would fail with a TypeError as the header_value would be None. Now, the except clause catches both type and value errors.
Fixes #1150.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.64%. Comparing base (45b575f) to head (504abd1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1160      +/-   ##
==========================================
+ Coverage   81.61%   81.64%   +0.03%
==========================================
  Files         195      195
  Lines       21643    21643
  Branches     3779     3779
==========================================
+ Hits        17663    17671       +8
+ Misses       2885     2873      -12
- Partials     1095     1099       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add opt out flag DISABLE_OPENCOLLECTIVE

When the environment variable DISABLE_OPENCOLLECTIVE is set to any value other than 0 or false, this flag will let users opt out of the postinstall-cli. This is useful in places that need to parse output and CI.
Fixes: Issues#8, opencollective-cli: Issue#7

@xdamman Any thoughts?

Sorry, I'm only seeing this now 🤦🏻♂
This is a great idea. Can you just move this above the line that reads the package.json.
No need to do that if it's disabled.

@xdamman fixed

Sorry, one more thing: can you update the README.md?
Otherwise people won't find out about this flag.

@xdamman done

Maybe it should look at CI env too, which is commonly set in CI environments.


Conflicts with dwave-cloud-client because both install /usr/local/lib/python3.9/site-packages/dwave/init.py

See https://github.com/dwavesystems/dwave-cloud-client/issues/531#issuecomment-1214449041


Release/7.0.0

:white_check_mark: Build TheIdServer 7.2.1.build.3019 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/8568a0bfea by @semantic-release-bot)


State Machine Implementation

[x] Transitions
[x] Check for memory leaks (just by running it for a while and seeing if the memory increases at all)

This seems to be fine with memory being constant, but I do not understand how there is not a memory leak.

[x] State machine reads from config file
[x] Transition Guard
[x] Better checks for validity of state machine config (duplicates/???)
[x] BuildScript
[x] Run on main board
[x] Transition Functions

Having some trouble running it on the real board, so lets wait to merge

Major changes in the previous commit, getting the yaml libraries to work on the board is more trouble than it is worth. Also cleaned up build scripts and README.md.

If the example plugin is meant to provide a minimum working example of the state machine, I think it needs to be pared down some. Let's make it agnostic to the fact that this is even satellite code. Just create a few tasks with overly verbose names and varying frequencies/delays. Here's a suggestion

repeat_every_5_seconds_task
repeat_every_10_seconds_start_later_task
etc (as needed to demonstrate functionality)

If the example plugin is meant to provide a minimum working example of the state machine, I think it needs to be pared down some. Let's make it agnostic to the fact that this is even satellite code. Just create a few tasks with overly verbose names and varying frequencies/delays. Here's a suggestion

repeat_every_5_seconds_task
repeat_every_10_seconds_start_later_task
etc (as needed to demonstrate functionality)

This will be done in a separate pull.


Retry if GCM registration fails

@destil @martinadamek I created a "naive" implementation for the exponential back-off in the branch error_retry. I am just retrying the registration inside the AsyncTask and delaying the next retry by Thread.sleep(). The registration is retried after 2, 4, 8, 16 and 32 seconds. The AsyncTask is executed on AsyncTask.THREAD_POOL_EXECUTOR to prevent blocking other AsyncTasks on Android 3.0+ (as they run in serial).
This could have been done by a Service, AlarmManager or maybe Handler - but I think it does not matter if the system kills the AsyncTask or if it's not 100% guaranteed to retry exactly 5 times. So this seemed to me like a good compromise and a simple implementation (easier to understand/modify).
The wakelock will be release after 5 retries in a special case of the MY_PACKAGE_CHANGED broadcast. (WakeLock is not held during normal registration started from MainActivity).
Thanks for taking a look.

LGTM (Looks good to me :)

LGTM (Looks good to me :)


feat: removes dependabot auto merge

What
feat: removes dependabot auto merge

:tada: This PR is included in version 0.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Bug] DHCP transient issue investigation

This issue has been resolved by https://github.com/futurewei-cloud/alcor-control-agent/commit/e1ebe89b0dc1978399cb5dbdcef27b85d5e58862.

The issue has been addressed in PR https://github.com/futurewei-cloud/alcor-control-agent/pull/137.
The fix has been verified in E2E test env and code merged to ACA master.


Bug 1743302: Add KuryrConfig.OpenStackServiceNetwork for CNO

Trying to apply OpenStack Octavia to OpenShift networking models we
realized that the subnet for OpenShift Services created in OpenStack
needs to be twice the size of the subnet used by OpenShift, as Octavia
uses 2 IP's per loadbalancer - VIP (i.e. the one assigned to a Service
by OpenShift) and VRRP that is assigned by Neutron.
To address this OpenStackServiceNetwork setting is added to KuryrConfig
to serve as this broader OpenStack network CIDR. If not set
cluster-network-operator will set it to ServiceNetwork expanded by one
bit.

/assign @soltysh

At this stage in the release, this needs a blocker bug or an exception and an ack from @openshift/sig-networking / @squeed

I do believe that Kuryr has an exception @dulek, can you confirm?
Adding this field gets a :+1: from me - it's openstack-only and solves a real problem.

@deads2k: So Kuryr support epic got a feature freeze exception, but this commit is related to us fixing an integration bug. I see @squeed being okay with the change, do you still want me to create a bugzilla?
@sttts: Good point, fixing that now.

/retest
Some permissions issues seem unrelated?

/lgtm

/approve
based on having an exception.  for bugs, you need to write the bug in the title.

based on slack, there's some issues with paperwork.
/hold
holding for the bugzilla to be in the title of the PR.  Bug <number>: description will do.  It must be a bugzilla.

/retest
I've rechecked this on my local env and I don't see any issues. Let's try again.

https://bugzilla.redhat.com/show_bug.cgi?id=1743302 still needs blocker flag, I'm working on that.

/hold cancel

/hold
to stop retrying the broken test

/retest

/hold cancel


Extract relationship stack variables to checker scope

We think this'll be useful for some improvements in checking (better detecting recursive types), and should be good for perf on its own, too.

@typescript-bot run dt
@typescript-bot user test this
@typescript-bot test this

RWC and DT diffs are interesting.... each only has pretty much one specific type where something's changed... I think it's worth looking into why.


Fix doc strings in hll.hpp

While I'm here, include <string>, which is needed in some of the APIs.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.871%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2328

Relevant Lines:
2480

💛  - Coveralls

Thank you.
Just curious, which compiler/IDE and settings complains about sorted header order? One of the longer-term plans is to increase our warnings settings and remove as many as we can. I think MSVC has the most, but also the most sensitive settings -- and is the most annoying to address since none of our primary devs use Windows.

Newer clang-format will fix header order for you.

Mostly botch transfer from java, which I believe was me.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+4.7%) to 98.592%

Totals

Change from base Build<PHONE_NUMBER>:
4.7%

Covered Lines:
9800

Relevant Lines:
9940

💛  - Coveralls


resume training

Thanks for providing the code. Just wondering, does the code support to resume training process? So I can continue the training process after a certain epoch without training from scratch again. Thanks.

Ys, it supports re-training. By default, it will load pre-trained weights,
as long as the naming of model folder is identical.
On 10 September 2017 at 19:59, popleyi<EMAIL_ADDRESS>wrote:

Thanks for providing the code. Just wondering, does the code support to
resume training process? So I can continue the training process after a
certain epoch without training from scratch again. Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/duxingren14/DualGAN/issues/9, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACc6ezvohDXHx8_pvgh7PagwumHfyf4rks5shKH2gaJpZM4PSlAa
.

thanks for your quick response


Correct NatSpec in Attested event

@param uid is not the UID of a revoked attestation but of the newly created one

Thanks @wildanvin!


Fully update footer with legal language

The text in the footer has been updated with the new AA/EO text in #13. The accessibility text is already present as well.


sqlite3.DatabaseError: authorization denied

Running the exporter returns the following error:
Traceback (most recent call last):
  File "/Users/p/Library/Python/3.9/bin/wtsexporter", line 8, in <module>
    sys.exit(main())
  File "/Users/p/Library/Python/3.9/lib/python/site-packages/Whatsapp_Chat_Exporter/__main__.py", line 271, in main
    extract_iphone_media.extract_media(args.backup)
  File "/Users/p/Library/Python/3.9/lib/python/site-packages/Whatsapp_Chat_Exporter/extract_iphone_media.py", line 65, in extract_media
    if is_encrypted(base_dir):
  File "/Users/p/Library/Python/3.9/lib/python/site-packages/Whatsapp_Chat_Exporter/extract_iphone_media.py", line 50, in is_encrypted
    with sqlite3.connect(os.path.join(base_dir, "Manifest.db")) as f:
sqlite3.DatabaseError: authorization denied

It's an unencrypted backup, on MacOS.
Trying to opening the Manifest.db using the sqlite3 command does not seem to work. I suspect that may be the cause of the problem (?)
sudo sqlite3 Manifest.db
Password:
Error: unable to open database "Manifest.db": unable to open database file

I have tried deleting the backup, running the backup again, but I seem to get the same errors every time.

Seems to be something related to the security mechanism of macOS. Try to see if access to the directory or file is blocked.

Thanks! Copying the backup directory to a subfolder of my home folder did the trick. Not sure what was stopping the export from working, but I guess that's a problem on my side rather than a bug in the WhatsApp-Chat-Exporter.


add some detail to the read me. not much though lol

hi its me ya boi thinkablelegoman/lolrandom
i know stuff now

ty! the readme hasn't been updated in a while (only updated it to fix formatting) so it's quite bare. it'll get more detailed as development progresses, hopefully


RCLC Actions Implementation

I propose here a draft implementation for ROS 2 Actions in the RCLC executor. By now I have integrated the Action server and client in the RCLC executor and created some utility functions.
The design should be discussed in the following points:

Should this RCLC Action implementation be multithreaded or thread-safe? Or we are ok with handling one action call per time?
Should some callbacks like the client's rclc_action_client_goal_callback_t be hidden from the user and be called directly from the executor?

Related:

https://github.com/micro-ROS/micro-ROS-demos/pull/53
https://github.com/micro-ROS/rcl/pull/10

TODO:

[x] Document code
[x] Client cancel goal
[ ] ~Client status~ (Is this neccesary?)
[x] Tests

Please feel free to add comments about the design or the implementation.
CC: @Acuadros95

Update API need to be modified, in RCLCPP user provides the following callbacks:

Action server: handle_goal, handle_cancel, handle_accepted
Action client: goal_response_callback,  feedback_callback, result_callback

In the client, goal_response_callback should be optional and the executor should be in charge of request the result if goals were accepted. Feedback callback also should be optional and the middleware layer should be in charge of discard non-read messages. Result callback should be compulsory in RCLC Actions API.

Related:

RCL Action implementation using static memory: https://github.com/micro-ROS/rcl/pull/10

@Acuadros95 I cannot add you as a reviewer, but at some point next week would be nice if you precheck this new API.

@mergify backport master

As type structs e.g. rclc_executor_handle_t are updated, this would break ABI stability if merged in Galactic. I propose to merge this PR to main (Rolling).

Codecov Report

Merging #170 (30ba172) into galactic (dc6767c) will increase coverage by 3.45%.
The diff coverage is 72.60%.

@@             Coverage Diff              @@
##           galactic     #170      +/-   ##
============================================
+ Coverage     60.95%   64.40%   +3.45%
============================================
  Files            13       16       +3
  Lines          1493     2152     +659
  Branches        445      642     +197
============================================
+ Hits            910     1386     +476
- Misses          377      449      +72
- Partials        206      317     +111

Impacted Files
Coverage Δ

rclc/src/rclc/action_client.c
68.75% <68.75%> (ø)

rclc/src/rclc/action_server.c
69.62% <69.62%> (ø)

rclc/src/rclc/executor.c
61.74% <73.00%> (+5.28%)
:arrow_up:

rclc/src/rclc/action_goal_handle.c
75.15% <75.15%> (ø)

rclc/src/rclc/init.c
59.45% <0.00%> (-5.66%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc6767c...30ba172. Read the comment docs.

How about using a for-loop with just a state-checking condition?

I agree with the better performance argument, it will also simplify the code.

I was thinking about sometheing like this:
entity = handle->action_client;
rclc_action_goal_handle_t * handle = entity->used_goal_handles
 for(handle=  entity->used_goal_handles; handle != NULL; handle= handle->next)
{
  if (handle->available_feedback)
  {
   // do sth
  }
 }

You might want to generalize this function with the condition-check as parameter function if you like.
But already with this restructuring using this  for-loop instead of while-loopand the  rclc_action_find_first_handle_with_XXX functions, which travers the linked list multiple times, the code does not have the problem of unbounded while loops.

Maybe we can modify rclc_action_put_goal_handle to return the next value on the list previous to the delete,
so it works more or less like iterators on c++:
entity = xxx->action_client;
rclc_action_goal_handle_t * handle;
 for(handle =  entity->used_goal_handles; handle != NULL;)
{
  if (handle->available_feedback)
  {
    if (...)
    {
        // ...
        handle = handle->next;
    }
    else
    {
        handle = rclc_action_put_goal_handle(...);
    }
  }
 }

Anyway, this can lead to infinite loops too.

@JanStaschulat Just rebased onto master.
Also, update with for-loop style where possible: 3d617a24040ada27db8c2fed5d3a0994cf22cb26

@pablogs9 @Acuadros95 do you have some time today for a short telco to discuss about the while-loop issue? e.g. 11.30am or in the afternoon would be fine for me. I would like to understand in detail the correctness of the termination of the while loop. We could use the OFERA google meet.

I'll send a invitation

Please resolve DCO check

removed reset of data_available flag

DCO and we are done @Acuadros95

Please @JanStaschulat add your final review and we are ready to merge

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/micro-ros-fully-supports-ros-2-features/23213/1

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/ros-2-humble-hawksbill-released/25729/14