Helper functions for rdm discovery response

I added some helper functions that I need to make the device discoverable via RDM.
The example was tested using the "Botex Dr. RDM | DMX RDM Tester" and it works.
Do you think it would make sense to add basic rdm stuff like discovery, getting/setting the dmx address etc. directly to the
esp_dmx.h? Imo there is no need for the user to implement the basic stuff himself.

Hmm okay, the more I read your code and try to add stuff, the more I think that this PR is not the way to go :D
I'll leave it open for now because I am still adding stuff and experimenting with rdm but I don't think this should be merged.
Probably I'll rewrite everything once I have an rdm prototype working

Yeah, I agree. I apologize - I'm not exactly making it easy to submit pull requests. I've been making all my changes on the v3 branch pretty quickly lately. Just yesterday I renamed the dmx_event_t type to dmx_packet_t so I imagine that will mess up anything you've worked on so far. I will start working in the dev branch and merging features moving forward.
A little background about where the state of this repo stands right now: I believe that the RDM controller works. I've implemented the the minimum required RDM parameters. The list of those can be found in the readme. I've also implemented RDM discovery so that end-users don't need to worry about that. I'll add some discovery example code today. The other examples have been updated for v3, so perhaps that will help to take a look at.
The next big hurdle is implementing the DMX responder. I am not exactly sure what that will look like. Based on the feedback I've gotten, most people that use this library are hobbyists. So I've really been trying to strike a balance between usability for the newbies still learning how DMX/RDM works, and powerful features for the professionals who are actually using this library to create a product. To that end, I'm envisioning an rdm_reply() function that users can call which will parse an RDM request and automatically send responses. Users can then attach callbacks to the RDM driver so that when the ESP32 receives a SET DMX_START_ADDRESS request, the ESP32 can run the callback which will set the start address appropriately and then it will send an ACK back to the RDM controller, or a NACK if the callback returns some other value.
Before that, I'm working on documentation. After documentation is squared away, I'm thinking about releasing a v3.0-beta to get some more people testing the library while working on implementing the RDM responder.

Yeah, I agree. I apologize - I'm not exactly making it easy to submit pull requests. I've been making all my changes on the v3 branch pretty quickly lately. Just yesterday I renamed the dmx_event_t type to dmx_packet_t so I imagine that will mess up anything you've worked on so far. I will start working in the dev branch and merging features moving forward.
A little background about where the state of this repo stands right now: I believe that the RDM controller works. I've implemented the the minimum required RDM parameters. The list of those can be found in the readme. I've also implemented RDM discovery so that end-users don't need to worry about that. I'll add some discovery example code today. The other examples have been updated for v3, so perhaps that will help to take a look at.
The next big hurdle is implementing the DMX responder. I am not exactly sure what that will look like. Based on the feedback I've gotten, most people that use this library are hobbyists. So I've really been trying to strike a balance between usability for the newbies still learning how DMX/RDM works, and powerful features for the professionals who are actually using this library to create a product. To that end, I'm envisioning an rdm_reply() function that users can call which will parse an RDM request and automatically send responses. Users can then attach callbacks to the RDM driver so that when the ESP32 receives a SET DMX_START_ADDRESS request, the ESP32 can run the callback which will set the start address appropriately and then it will send an ACK back to the RDM controller, or a NACK if the callback returns some other value.
Before that, I'm working on documentation. After documentation is squared away, I'm thinking about releasing a v3.0-beta to get some more people testing the library while working on implementing the RDM responder.

Yeah, I agree. I apologize - I'm not exactly making it easy to submit pull requests. I've been making all my changes on the v3 branch pretty quickly lately. Just yesterday I renamed the dmx_event_t type to dmx_packet_t so I imagine that will mess up anything you've worked on so far. I will start working in the dev branch and merging features moving forward.

Don't worry, I am used to developing in fast moving systems :) Renaming took less than 30 seconds :D
I really like, that you are implementing features this fast. I know, that whatever I implement will be obsolete within weeks and I am fine with that :)

The next big hurdle is implementing the DMX responder. I am not exactly sure what that will look like. Based on the feedback I've gotten, most people that use this library are hobbyists. So I've really been trying to strike a balance between usability for the newbies still learning how DMX/RDM works, and powerful features for the professionals who are actually using this library to create a product. To that end, I'm envisioning an rdm_reply() function that users can call which will parse an RDM request and automatically send responses. Users can then attach callbacks to the RDM driver so that when the ESP32 receives a SET DMX_START_ADDRESS request, the ESP32 can run the callback which will set the start address appropriately and then it will send an ACK back to the RDM controller, or a NACK if the callback returns some other value.

I was thinking the same thing and have started implementing a very crude first test version in 32c2495. This is still in the tinkering phase and will likely remain there far longer than it would take you to implement it correctly because my time is limited due to work :(
Imo it could be nice to implement a parameter-object server that supports all standard objects and allows for the addition of custom user specified objects. The dmx responder would have access to the parameter server and can forward get/set calls.
In the parameter server you can attach custom callbacks to the objects to get notifications when something changes.
This is a concept that I see often in all kinds of industrial field bus systems (e.g. canOpen, Ethernet/IP, Profinet) and it seems to work well. I may start to implement something along those lines in December maybe :)

Imo it could be nice to implement a parameter-object server that supports all standard objects and allows for the addition of custom user specified objects. The dmx responder would have access to the parameter server and can forward get/set calls.
In the parameter server you can attach custom callbacks to the objects to get notifications when something changes.
This is a concept that I see often in all kinds of industrial field bus systems (e.g. canOpen, Ethernet/IP, Profinet) and it seems to work well. I may start to implement something along those lines in December maybe :)

This sounds excellent! I may get a head start on you, but we will see. I have a feeling chasing bugs in the RDM controller code is going to slow me down. :)
In the meantime, I'll close this pull request. Thank you!


how to install prometheus plugin ?

Is there a way to install Prometheus exporter plugin for each node in the cluster

i guess you could just build your own custom image with the exporter (and all relevant config for it) in it? depending  on how you scrape your nodes this might however not work: if you use the k8s annotations on the pods then this won't work as they won't be present (the operator currently wouldn't know that it'd have to add them).
there's however an open ticket to add proper support for the prometheus exporter: #18

Hey @KannappanSomu, we are working on a new feature that will install the plugin, service and service monitor.
hope to be ready on next release

See #200 and #201

Hey @KannappanSomu, take a look on #200 , will be added to the next release


GH-34252: [Java] Support ScannerBuilder::Project or ScannerBuilder::Filter as a Substrait proto extended expression

Rationale for this change
To close https://github.com/apache/arrow/issues/34252
What changes are included in this PR?
This is a proposal to try to solve:

Receive a list of Substrait scalar expressions and use them to Project a Dataset

[x] Draft a Substrait Extended Expression to test (this will be generated by 3rd party project such as Isthmus)
[x] Use C++ draft PR to Serialize/Deserialize Extended Expression proto messages
[x] Create JNI Wrapper for ScannerBuilder::Project
[x] Create JNI API
[x] Testing coverage
[x] Documentation

Current problem is: java.lang.RuntimeException: Inferring column projection from FieldRef FieldRef.FieldPath(0). Not able to infer by column position by able to infer by colum name. This problem is solved by https://github.com/apache/arrow/pull/35798
This PR needs/use this PRs/Issues:

https://github.com/apache/arrow/pull/34834
https://github.com/apache/arrow/pull/34227
https://github.com/apache/arrow/issues/35579

Receive a Boolean-valued Substrait scalar expression and use it to filter a Dataset

[x] Working to identify activities

Are these changes tested?
Initial unit test added.
Are there any user-facing changes?
No

Closes: #34252

HI @lidavidm, this PR enable Dataset Projections and Filters using Substrait Extended Expressions. This depends of another 02 PRs yet:

https://github.com/apache/arrow/pull/35798
https://github.com/apache/arrow/pull/34834

Could be possible when you have some time to give some feedback for Java side implementation?
Thank you in advance.

@davisusanibar is it possible to rebase so it's clear which commits are for this PR and which are from the other PRs?

@davisusanibar is it possible to rebase so it's clear which commits are for this PR and which are from the other PRs?

Just merge with main branch and another 02 PRs dependents

What I meant is if you could stage this as a rebase on top of those PRs, so that there's a separation. Otherwise I can review as is but I will assume no C++ or Python changes are from this PR specifically

Please consider that any change as part of cpp/, python/ won't be part of this PR. Only consider: java/* and docs/*

I guess people are okay with current projection usage and not seeking for subtrait integration for that.
for me, I am looking for a method to pass my java filter down to the native scanner.  and at this stage only the simplest filter expressions, not the ones with function calls etc ( I guess these can be followed up separately).
in a sense https://github.com/apache/arrow/pull/14287/files satisfies what I wanted but it is active and closed.
I'm generally good with using subtrait in the implementation, but I'd suggest let's keep the java interface simple.

Hi @danepitkin could you help me also with a code review?

I added one last small comment about the tests, but otherwise LGTM! I would approve it if I had the capability.


State Management Discussion

im in a bit of a decision with the state management...
at the moment we have one "global" shared state in the form of an ipfs hash
the state can be seen as a json object or a folder structure
on the colab side the IPFS state is persisted directly to and from the file system
the colab writes to /output pollinations writes to /input
and whenever either has changed the global state it sends a new hash on a pubsub channel
but its not so clean because both can change either /input or /output its not completely unidirectional data flow
so im thinking the colab notebook should only send its output content id and pollinations should only send the input content id
but then i loose the niceness of having one hash
that describes the whole run including inputs and outputs

So this hash is overriden by two different clients
Then first of all, I was thinking if keeping the same  after i click reset/cancel makes sense or not
if we made it more unidirectional it wouldnt have these failure stages. i.e. colab cannot change /input and pollinations cannot change /output but only read from it vice versa
theres a finite state machine in there somehow
yeah each small thing you do the theory was it goes into the global state. so if pollinations wants to cancel the current proces colab is doing it merges a {input: {requestCancel:true}} to the global state
and then i had made colab remove the requestCancel once it had actually cancelled the run18m
but that meant both were writing to the same object
and it got a bit messy
Yep I think this is the problem
I think they should not write to same state

then i thought we have a satte of colab and a state of pollinations which both represent kindof the inputs and the outputs to a computation
and we could just join them inn the frontend
to one hash
which is in the url you share etc

you want to add a word to the prompt
11m
then you want to cancel it
11m
change the prompt a bit
11m
and restart
11m
You
you want to add a word to the prompt
This won't happen that much
10m
Either i can still reset it
10m
Or more than that, i never know really what deepdaze is gonna come up with
9m
So i want to see this result first
9m
And run it again with the word
9m
gokay
And run it again with the word
After adding the word i tried to mean
8m
ok i will finish my new state implementation in the most simple way without a cancel/stop functionality
8m
and then we see if it is easy to fit in
8m
❤
i agree that its best to keep things simple and stable at first
8m
because its there now
7m
but its not even really usable
7m
and just complicates things

I think a bug I encountered is also related https://github.com/pollinations/pollinations/issues/10


WebJars: Upgrade Momentjs from 2.22.2 to 2.24.0

Can you reference the JIRA in your commit message

Sure @ern , my mind was somewhere else and I forgot that ;)


Different black boarder size

Hi, I notice that the tags have to be unique and of the same family to be used, but can they have different width of the black boarder (borderbits)? We have a single 6x6 apriltag grid calibration board where there is a double outer black boarder of each tag (The default generated from kalibr). We want to use this board with other tags with a black boarder of only 1 width. Is this supported or does all the tags have to have the same number of borderbits?

Sorry, I now see you specifically stated the number of borderbits has to be the same. For the future, apriltag 3 does not longer seems to natively support the option of adjusting the number of borderbits.

Andreas, thanks for pointing this out.
I'd love to use the Apriltag3 version as well, but it's not conveniently accessible in the ROS apriltag package I'm using right now.
Chao (@versatran01), what are your plans for integrating Apriltag3 into your package? Obviously we'd still want the option to switch to the MIT detector so we can handle border width of 2. Any comments?

If you think it is stable then I can work of master branch to replace old umich with the new one.
If you can do a PR then it's even better


Refactor MapInstance for code hygiene and less merge conflicts

We have talked this before in Discord, and since EmailHandler PR is finally merge I'd like to start doing this.
The idea is to split MapInstance into multiple CPP files categorized as Services (so, like GameDbSyncService I guess), each one dealing with their own specific functions. For example, an EmailService would take all the email-related functions in MapInstance, and etc.
Why?

Reduce the big file size and line count in MapInstance
More resistant towards merge conflicts because now people will be editing and/or adding their own files, as opposed to one singular big file

What to do:

Don't need to do anything with MapInstance.h
Split up MapInstance.cpp into multiple Services, all of which would include MapInstance.h
Create a new folder to store all the Services (oh, dealing with all the Cmake stuff again...)
Maybe create a Service class that derives from EventProcessor, but we'll see if there's some kind of function that all these Services must implement that is not already in EventProcessor

Looking through the MapInstance class, the services could probably be:

ClientConnection - client connect, disconnect, on_expect_client, link_lost, timeout, etc

ZoneTransfer - Doors, map transfers, hospitals, etc

CharacterRelated - Powers, inspirations, enhancements, levelup, etc

LocationRelated - Plaques, Waypoints, Location visited

Email

Teams / Supergroups - probably related

Settings - Console, Settings, Options, Keybinds, etc

Chat - The chat parsing could probably go in to a separate thing and be used also for slashcommands #756

There's then things like trade, shops which could go in a separate service or go in to one of the others.
Several of these could also be used for the SlashCommands refactor I imagine (zone transfers, teams/supergroups, etc)
There's probably also quite a lot of duplicate code that could be reduced, such as sending events to the maplink, getting an entity from a session, etc.

Marking this for v7, as I'd love to get it in if possible.


External Service Entry to support non-http protocols like ldap,netconf,ssh,FTP etc.,

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
External Service Entry to support non-http protocols like ldap,netconf,FTP etc.,
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
It would be great if you guys to help workaround to make the container execute the above protocols

@mkharibalaji You should assign protocol-specific name to the Port name on the Service Entry.
See https://istio.io/docs/reference/config/networking/v1alpha3/gateway/#Port for example of how to do this.
See https://istio.io/docs/setup/kubernetes/additional-setup/requirements/ for Istio's list of protocols that can be applied to the name.

Related to https://github.com/istio/istio/issues/15776
I don't know the details of all these protocols, but we are bounded by what envoy supports. For FTP at least I think it requires UDP so we are blocked by https://github.com/istio/istio/issues/1430

I think the state of this is:

Any protocol we support needs to be supported by Envoy (since that is what it means for us to support a protocol)
If there is a protocol supported by envoy that we don't yet support, it shouldn't be that much work for us to add support
Any protocol that needs UDP is blocked by https://github.com/istio/istio/issues/1430
Any protocol that is not UDP and not supported by Envoy specially can just use the TCP proxy

So I don't think there is any work to do here


[PT Run] Fix Program Plugin launching issue in Turkish locale

Summary of the Pull Request
What is this about:
This PR tries to fix #9776
On environments with Turkish locale selected, you can't run programs with capitalized I because I becomes ı thus fails to open the specified program.

What is include in the PR:
I suppressed CA1308 for user facing text and used InvariantCulture for the launch issue.
How does someone test / validate:
Here's the end result:

One needs an environment with locale set to Turkish and try to run a program or a shortcut that has capitalized I in it.
Thankfully Windows has one in: C:\Program Files\Windows Photo Viewer\ImagingDevices.exe
I just needed to create a shortcut (LNK) for that and tested with it and it worked.
Quality Checklist

[x] Linked issue: #9776
[ ] Communication: I've discussed this with core contributors in the issue.
[x] Tests: Added/updated and all pass

Contributor License Agreement (CLA)
I signed the CLA.

@enricogior your call for .37 at this point but seems like a solid fix.

@crutkas
this can cause problems to other locales, so we will have to make sure before merging it. For sure not for 0.37.

What other locales?  lets make sure we account for them then in the tests.

AFAIK this problem only occurs in Turkish language:

What's Wrong With Turkey? (2008)
Does Your Code Pass The Turkey Test? (2008)

@dogancelik
Your PR can conflict with #11364!


Filter and notification dialogs are not displaying when your extension is enabled.

Hi, thank you for your hard work. I've noticed the following issue when using your extension in Google Chrome (Version 118.0.5993.71 (Official Build) (64-bit)):

Nothing appears when I click on the filter button (located to the right of the search bar).
Nothing appears when I click on the notifications.
The video pauses as soon as I click on it, and I need to manually unpause it.

If your extension is disabled, everything above works fine.

Hey Mouaad, thanks for opening the first issue in the repo!
To answer your feedback:

Nothing appears when I click on the filter button (located to the right of the search bar).
Nothing appears when I click on the notifications.

This behavior is by design. The extension works in the background and no information is shown when clicking the extension button. Maybe it is something I could implement to give the user more data. Please let me know if this is of interest. The only information returned by the extension is some logs that can be seen in the dev console.

The video pauses as soon as I click on it, and I need to manually unpause it.

I was able to reproduce this bug. I've pushed a commit that should fix this issue. Please let me know if it works as expected now so I can close this issue.
Cheers!

@Mouadabdelghafouraitali I'm reading this issue again and I think I misunderstood your feedback.

Nothing appears when I click on the filter button (located to the right of the search bar).
Nothing appears when I click on the notifications.

Do you mean the search and notification buttons inside YT's page?


update: Add link for the PVC access modes docs

…docs
What this PR does / why we need it:
This PR improves the documentation of the storage section.
Which issue(s) this PR fixes:
Not applicable
Fixes #
Quality checks

[ ✅] My content adheres to the style guidelines
[ ✅] I ran make test module="<module>" it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

thanks @ligh1yagami for the PR!


Edit categories feels broken, bad UX

Summary:
Actually the first few times I thought the dialog is broken.

could not find a search box
even worse: dialog closes when clicking anywhere inside the dialog (else than the icon)

I only saw some wired lines below, tried to click on them but instead of a textbox appearing, the dialog closed.
Only later I found these are buttons with ~1px height, but clicking not only there, but anywhere in the dialog closes it.

Proposal:

Have the search box focused (and so keyboard broght up)
Let the buttons always by there in full size, but disabled if nothing is selected

Steps to reproduce:
on an uploaded image go to details and click the edit icon next to categories
Device and Android version:
android version: 7, lineage os
Commons app version:
app version: 3.0.0~a36017d81
Would you like to work on the issue?
no

I agree on this one, this issue does exist on the latest master.
@nicolas-raoul I would like to fix this one if you can confirm this from your side. Thanks!

Thanks @NotSoImportant for formalizing this, I always felt uncomfortable using this UI indeed.
And thanks @Pratham2305 for accepting to work on it!


Add rescrape of source when uploading a new source

It was requested that when a CSV is uploaded to a collection, that new sources will get scheduled to be scraped

this will only apply to created sources and not updated sources

Ok, I think that is a good solution. I will implement for v1 and have research give feedback

Added suggested checkbox


router.trailingSlash cause problems on nested routes

Version
v2.10.2
Reproduction link
https://codesandbox.io/s/codesandbox-nuxt-drxmn?fontsize=14&hidenavigation=1&theme=dark
Steps to reproduce
nuxt.config.js
export default {
  ...,
  router: {
    trailingSlash: true,
    extendRoutes(routes, resolve) {
      console.log(routes);
    }
  },
  ...
};

pages structure:
-- pages
---- test.vue
------ test/index.vue

What is expected ?
expected generated routes:
[
  {
    path: '/test/',
    component: '/sandbox/pages/test.vue',
    chunkName: 'pages/test',
    pathToRegexpOptions: {
      strict: true
    },
    children: [
      [Object]
    ]
  },
  {
    name: 'index',
    path: '/',
    component: '/sandbox/pages/index.vue',
    chunkName: 'pages/index',
    pathToRegexpOptions: {
      strict: true
    }
  }
]

What is actually happening?
generated routes:
[
  {
    name: 'test',
    path: '/test/',
    component: '/sandbox/pages/test.vue',
    chunkName: 'pages/test',
    pathToRegexpOptions: {
      strict: true
    },
    children: [
      [Object]
    ]
  },
  {
    name: 'index',
    path: '/',
    component: '/sandbox/pages/index.vue',
    chunkName: 'pages/index',
    pathToRegexpOptions: {
      strict: true
    }
  }
]

Additional comments?
And of course we got the following warning message in console:
WARN  [vue-router] Named Route 'test' has a default child route. When navigating to this namedroute (:to="{name: 'test'"), the default child route will not be rendered. Remove the name fromthis route and use the name of the default child route for named links instead.
WARN  [vue-router] Duplicate named routes definition: { name: "test", path: "/test/" }

This bug report is available on Nuxt community (#c10047)

Is this related #6783


Job Limits Broken

*Description of issue:
Job limits appear broken on 4.16.2 - Current setup on 4.16.1, no changes, set to limit earnings to $1million per hour and without changing anything on 4.16.2 the timer starts a new hour and sometimes it fails to give any income just giving XP.
Running "/jobs resetlimit all" when this happens gives it a kick, but it keeps happening again seemingly at random.
ERROR (DELETE IF YOU HAVE NO ERROR):
No errors given.

CONFIG SECTION (DELETE IF NOT RELEVANT):

  Limit:
    # Money gain limit
    # With this enabled, players will be limited how much they can make in defined time
    # Time in seconds: 60 = 1 min, 3600 = 1 hour, 86400 = 24 hours
    Money:
      Use: true
      # Do you want to stop money gain when exp limit reached?
      StopWithExp: false
      # Do you want to stop money gain when point limit reached?
      StopWithPoint: false
      # Equation to calculate max limit. Option to use total level to include players total amount levels of current jobs
      # You can always use simple number to set money limit
      # Default equation is: 500+500*(totallevel/100), this will add 1% from 500 for each level player have
      # So player with 2 jobs with level 15 and 22 will have 685 limit
      MoneyLimit: 1000000
      # Time in seconds: 60 = 1 min, 3600 = 1 hour, 86400 = 24 hours
      TimeLimit: 3600
      # Delay between announcements about reached money limit
      # Keep this from 30 to 5 min (300), as players can get annoyed of constant message displaying
      AnnouncementDelay: 30

Server Type (Spigot/Paperspigot/etc):
PaperSpigot
Server Version (using /ver):
03.10 21:17:28 [Server] INFO This server is running Paper version git-Paper-209 (MC: 1.16.3) (Implementing API version 1.16.3-R0.1-SNAPSHOT)
03.10 21:17:28 [Server] INFO Checking version, please wait...
03.10 21:17:28 [Server] INFO Previous version: git-Paper-208 (MC: 1.16.3)
Relevant plugins (Delete if this isn't needed):
Jobs 4.16.2.

There is no any limit related changes, only added a new command argument for reseting limit. Send your generalConfig to a paste server

The issue was definitely not present on 4.16.1, but has been reported by players multiple times, requiring a "/jobs resetlimit all" to fix it each time, since updating to 4.16.2 without any changes to any of the config files so the issue is definitely something either in the 4.16.2 updates themselves or with the configs that were fine on 4.16.1 and older (though we had to update for the fix to furnace ownership)
generalConfig.yml: https://pastebin.com/rCRctWvr

To confirm it just happened again - no errors, no warning, only thing that's happened that should have any effect on anything since the last time I had to run "/jobs resetlimit all" was a server restart but it also happened multiple times yesterday at random through the day.

A player just stated:
so my job limit time just reset and I was not getting money for farmer again, which was the job I was doing just before the timer reset
went to mine a single block of stone, since I'm also a miner and that fixed it it seems, also for farmer money

So when the timer resets it's not paying them for what they were doing right beforehand, but if they go do their other job it kicks it

3d48656311e87b2986cafe2928b4351627be03a8
@BetaBurnt Made some changes to payment limit handling, if issue repeats after next update, please let us know.


Support all animation-timing-function values

The polyfill can’t handle this:
animation: reveal cubic-bezier(0.215, 0.61, 0.355, 1) forwards;
animation-timeline: scroll();

Switching the animation-timing-function to a value of linear works fine:
animation: reveal linear both;
animation-timeline: scroll();

The culprit seems to be that the css parser uses a list of predetermined keywords defined in ANIMATION_KEYWORDS. This list does not cater for the cubic-bezier, steps, or linear functions.

As a workaround, authors can define linear in the shorthand, and then override the animation-timing-function using the longhand:
animation: reveal linear both;
animation-timing-function: cubic-bezier(0.215, 0.61, 0.355, 1); /* 👈 Override linear from the shorthand with the needed value */
animation-timeline: scroll();


Feature: Investigate RCL and KCL.

Description
Look into RCL and KCL.
Additional information
Suggested in issue #435

Just a thought. https://github.com/corn-config/corn seems like a promising lang too and maybe it's possible to either prompt for / submit PRs to have conditionals and imports added to it's spec.
It's language is familiar to people that use nix and it's codebase seems early enough to adopt those changes without breaking already existing specs.


Tracking Issue for -Z doctest-in-workspace

Summary
Original issue: #8097 #8993
Implementation: #9105
Documentation: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#doctest-in-workspace
The -Z doctest-in-workspace flag changes the behavior of the current working directory used when running doctests. Historically, Cargo has run rustdoc --test relative to the root of the package, with paths relative from that root. However, this is inconsistent with how rustc and rustdoc are normally run in a workspace, where they are run relative to the workspace root. This inconsistency causes problems in various ways, such as when passing RUSTDOCFLAGS with relative paths, or dealing with diagnostic output.
The -Z doctest-in-workspace flag causes cargo to switch to running rustdoc from the root of the workspace. It also passes the --test-run-directory to rustdoc so that when running the tests, they are run from the root of the package. This preserves backwards compatibility and is consistent with how normal unittests are run.
Unresolved issues
None at this time.
About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
cc @Swatinem

I wonder what's the current status of this feature. It seems that there is nothing left but stabilizing rustdoc --test-run-directory flag. Should we propose a stabilization on rustdoc's side?

I would love to!
… and even go a step further and maybe make this the default in a future edition?

Out of curious. What's the consequence of making it the default in terms of compatibility from users' perspective. I can see one that all relative paths of test output format switch to workspace-relative.

I opened up a PR to stabilize rustdoc --test-run-directory and wrote a stabilization report.
Doing so I realized that the rustdoc flag itself is just an implementation detail of the doctest-in-workspace cargo flag.
The cargo flag itself is used to opt into fixing an inconsistency in how different categories of tests are compiled and executed.
@ehuss would you agree to push for stabilization of the cargo flag? And to eventually change the default from opt-in to opt-out? If there is backwards compatibility concerns, that can be done as an edition change.
I believe the only user visible change here is the command line output when running doctests, otherwise this should only be implementation details.
Also, can you think of any way to stabilize this cargo feature without necessarily having to stabilize the underlying rustdoc feature?

I would lean towards just changing it without an opt-in/out. I don't expect there to be widespread breakage, and it is clearly not working as it should, and thus I would categorize this as a bug fix.
Unfortunately using new rustdoc flags can be difficult, so I typically wait until they hit stable to switch Cargo over. That means if --test-run-directory can be stabilized in 1.67, then Cargo can start using it in 1.69. That means landing in Cargo's master branch some time late January and reaching stable in late April.

Also, can you think of any way to stabilize this cargo feature without necessarily having to stabilize the underlying rustdoc feature?

I think --test-run-directory is essentially required. An alternate solution could be --persist-doctests and have cargo handle running the tests, but I would prefer to not do that.

@rust-lang/cargo I'm going to propose stabilizing this feature now that --test-run-directory is available on stable.
I think the risk of this causing breakage is relatively low. With this feature enabled, tests run in the same directory as they did before. It just affects things like relative paths in RUSTDOCFLAGS. There aren't a lot of flags that have relative paths, and it seems unlikely that most of them are being used when running doctests. However, there is a definite risk so I wanted to start this to poll the team to see what you think.
Unfortunately I can't think of a good way to test this, since we don't have a good way to try out various workspaces. I don't see any issues with the rust-lang/rust repository, but more testing there is probably warranted.
If the risk seems too large, then we could make this an option that gets flipped in the next edition, but I'm reluctant to do that for a change that seems like it shouldn't affect too many people.
Note: I did find one thing that is broken, --persist-doctests doesn't work, see https://github.com/rust-lang/rust/issues/112191. I hope that a fix for that should be easy. That flag is nightly-only.
@rfcbot fcp merge

Thanks @ehuss for creating the fcp.
The PR to actually stabilize/enable this is in #12221

Is it required that TOOL in --runtool <TOOL>  becomes relative to --test-run-directory?
Given that is also a nightly feature, I have no concern right now.
@rfcbot reviewed

That's a good point about --runtool. I opened https://github.com/rust-lang/rust/issues/112210 since it looks like it is not working correctly. The fix for that also looks like it should be pretty simple.


RenderToggleable class not available in latest dev and master, but is available on stable.

RenderToggleable class is not available in dev channel 2.1.0-12.1.pre version

Seems to be available on latest Stable (2.0.2), but not on master as well.

Master:

Stable:

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.2, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
    • Flutter version 2.0.2 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 8962f6dc68 (6 days ago), 2021-03-11 13:22:20 -0800
    • Engine revision 5d8bf811b3
    • Dart version 2.12.1

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.54.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (3 available)
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                               •
      web-javascript • Google Chrome 89.0.4389.90

! Doctor found issues in 1 category.

see https://github.com/flutter/flutter/pull/76745 for context

I have the same issue,
After upgrading, The RenderToggleable  is not resolvable now.
It used in circular_check_box here.,
Info:
$ flutter doctor --verbose
[✓] Flutter (Channel stable, 2.2.1, on Linux, locale en_US.UTF-8)
    • Flutter version 2.2.1 at ***/sdk/flutter
    • Framework revision 02c026b03c (8 days ago), 2021-05-27 12:24:44 -0700
    • Engine revision 0fdb562ac8
    • Dart version 2.13.1

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at ***/sdk/android/
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = ***/sdk/android/
    • Java binary at: ***/ide/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+0-b944-P17168821)
    • All Android licenses accepted.

[✗] Chrome - develop for the web (Cannot find Chrome executable at google-chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[✓] Android Studio (version 4.2)
    • Android Studio at ***/ide/android-studio
    • Flutter plugin version 57.0.2
    • Dart plugin version 202.8488
    • Java version OpenJDK Runtime Environment (build 11.0.8+0-b944-P17168821)

[✓] Android Studio
    • Android Studio at ***/ide/android-studio/
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = ***/ide/android-studio/
    • Java version OpenJDK Runtime Environment (build 11.0.8+0-b944-P17168821)

[✓] Connected device (1 available)
    • Linux (desktop) • linux • linux-x64 • Linux

! Doctor found issues in 1 category.

I am also dealing with same issue. After upgrading to flutter 2.2.2 , the RenderToggleable is not available in stable channel which is used in circular_check_box here.
This lead to crash my working app.
Error:
Launching lib/main.dart on MAR LX2 in debug mode...
../../../development/flutter/.pub-cache/hosted/pub.dartlang.org/circular_check_box-1.0.4/lib/circular_check_box.dart:328:39: Error: Type 'RenderToggleable' not found.
class _RenderCircularCheckBox extends RenderToggleable {
                                      ^^^^^^^^^^^^^^^^
../../../development/flutter/.pub-cache/hosted/pub.dartlang.org/circular_check_box-1.0.4/lib/circular_check_box.dart:292:27: Error: The return type of the method '_CircularCheckBoxRenderObjectWidget.createRenderObject' is '_RenderCircularCheckBox', which does not match the return type, 'RenderObject', of the overridden method, 'RenderObjectWidget.createRenderObject'.
 - '_RenderCircularCheckBox' is from 'package:circular_check_box/circular_check_box.dart' ('../../../development/flutter/.pub-cache/hosted/pub.dartlang.org/circular_check_box-1.0.4/lib/circular_check_box.dart').

Also tried to extend in class but 😞

Flutter Info
$ flutter doctor --verbose
[✓] Flutter (Channel stable, 2.2.2, on macOS 11.2.3 20D91 darwin-x64, locale en-NP)
    • Flutter version 2.2.2 at /Users/sahsantoshh/development/flutter
    • Framework revision d79295af24 (8 days ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/sahsantoshh/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/sahsantoshh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.23.0

Seems to be available on latest Stable (2.0.2), but not on master as well.

Master:

Stable:

flutter doctor -v

Is there a replacement class

I am also dealing with same issue. After upgrading to flutter 2.2.2 , the RenderToggleable is not available in stable channel which is used in circular_check_box here.
This lead to crash my working app.
Error:
Launching lib/main.dart on MAR LX2 in debug mode...
../../../development/flutter/.pub-cache/hosted/pub.dartlang.org/circular_check_box-1.0.4/lib/circular_check_box.dart:328:39: Error: Type 'RenderToggleable' not found.
class _RenderCircularCheckBox extends RenderToggleable {
                                      ^^^^^^^^^^^^^^^^
../../../development/flutter/.pub-cache/hosted/pub.dartlang.org/circular_check_box-1.0.4/lib/circular_check_box.dart:292:27: Error: The return type of the method '_CircularCheckBoxRenderObjectWidget.createRenderObject' is '_RenderCircularCheckBox', which does not match the return type, 'RenderObject', of the overridden method, 'RenderObjectWidget.createRenderObject'.
 - '_RenderCircularCheckBox' is from 'package:circular_check_box/circular_check_box.dart' ('../../../development/flutter/.pub-cache/hosted/pub.dartlang.org/circular_check_box-1.0.4/lib/circular_check_box.dart').

Also tried to extend in class but 😞

Flutter Info
$ flutter doctor --verbose
[✓] Flutter (Channel stable, 2.2.2, on macOS 11.2.3 20D91 darwin-x64, locale en-NP)
    • Flutter version 2.2.2 at /Users/sahsantoshh/development/flutter
    • Framework revision d79295af24 (8 days ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/sahsantoshh/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/sahsantoshh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.23.0

Handsome guy，Is there a replacement class

I am also dealing with same issue. After upgrading to flutter 2.2.2 , the RenderToggleable is not available in stable channel which is used in circular_check_box here.
This lead to crash my working app.
Error:
Launching lib/main.dart on MAR LX2 in debug mode...
../../../development/flutter/.pub-cache/hosted/pub.dartlang.org/circular_check_box-1.0.4/lib/circular_check_box.dart:328:39: Error: Type 'RenderToggleable' not found.
class _RenderCircularCheckBox extends RenderToggleable {
                                      ^^^^^^^^^^^^^^^^
../../../development/flutter/.pub-cache/hosted/pub.dartlang.org/circular_check_box-1.0.4/lib/circular_check_box.dart:292:27: Error: The return type of the method '_CircularCheckBoxRenderObjectWidget.createRenderObject' is '_RenderCircularCheckBox', which does not match the return type, 'RenderObject', of the overridden method, 'RenderObjectWidget.createRenderObject'.
 - '_RenderCircularCheckBox' is from 'package:circular_check_box/circular_check_box.dart' ('../../../development/flutter/.pub-cache/hosted/pub.dartlang.org/circular_check_box-1.0.4/lib/circular_check_box.dart').

Also tried to extend in class but 😞

Flutter Info
$ flutter doctor --verbose
[✓] Flutter (Channel stable, 2.2.2, on macOS 11.2.3 20D91 darwin-x64, locale en-NP)
    • Flutter version 2.2.2 at /Users/sahsantoshh/development/flutter
    • Framework revision d79295af24 (8 days ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/sahsantoshh/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/sahsantoshh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.23.0

Handsome guy，Is there a replacement class

I @JokerGHit I reverted back to 2.0.5 now, it's working fine.

Seems to be available on latest Stable (2.0.2), but not on master as well.

Master:

Stable:

flutter doctor -v

Our team wants to use the latest 2.2.2 stable version, is there any other solution?

@JokerGHit I don't think we have any other solution until the flutter team fixes this issue or you can create PR to fix the issue but we can see the issue linked with it is already merged.

Is there any updates on this being solved?

isn't it a major issue for custom widgets ?, can some action / suggestion be announced please

Hi guy, I found an alternative library, I don’t know if it can solve your problem, we are currently using this solution.
See details:
https://pub.dev/packages/circle_checkbox
hope to help you

@bradolh
Please look at the related PR description, https://github.com/flutter/flutter/pull/76745#issue-579709328 which suggests to use ToggleableStateMixin instead of RenderToggleable. The latter seems to have been removed as I don't see the class on latest dev, master and stable anymore.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Fix emitter velocity controls

When you enter a negative magnitude value for an emitter's velocity, it causes weird values to be calculated for the angle, and that can cause the angle slider to stop working.
Angle slider should always be clamped to a value between 0 and 360, and the calculation should be able to handle negative magnitude values without causing issues.

Fixed in 4a7d41cff05b20f04c0df83167963ca1fec0c661.  Calculated angle is now clamped between 0 and 360.


to_numpy(?datetime) should return a valid numpy dtype

numpy has NaT (Not-a-Time) for missing datetime values. We should use this instead of throwing an error.

timedelta64 works with NaT as well.


[fix] #2880: Close websocket connection properly

Signed-off-by: Shanin Roman<EMAIL_ADDRESS>

Description of the Change
Close websocket connection properly.

Issue
Closes #2880.

Benefits
Properly closed connection.

Possible Drawbacks
None.

Can we also fix panic_on_invalid_genesis.sh?


Change logging to use tstring

Addresses feedback from https://github.com/dotnet/dotnet-monitor/pull/1766#discussion_r853306326

/backport to main


Do not serialize some properties on JsonWebKey

When trying to serialize an instance of JsonWebKey there are a few properties that are showing up on the wire even though they are not set.
{
  "key_ops": [],
  "kid": "DevelopmentKey.5efea89c-6b7f-4ab3-9579-14b1134a4636",
  "kty": "RSA",
  "e": "AQAB",
  "n": "",
  "use": "sig",
  "x5c": [],
  "keySize": 2048,
  "hasPrivateKey": false,
  "keyId": null,
  "cryptoProviderFactory": {
      "customCryptoProvider": null
}

It would be good if you could hide these properties by using JsonIgnore http://www.newtonsoft.com/json/help/html/T_Newtonsoft_Json_JsonIgnoreAttribute.htm
(KeySize, HasPrivateKey, KeyId, CryptoProviderFactory)
It would also be good if you can add a setter to the collection properties so that they can be set to null and not send over the wire when empty.
This issue is related to https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/578

@javiercn definitely we will put the 'ignore' into 5.1.4 for
(KeySize, HasPrivateKey, KeyId, CryptoProviderFactory)
As for setting collections to null, that is always a discussion with two camps. Allowing null as https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/master/src/Microsoft.IdentityModel.Tokens/TokenValidationParameters.cs#L502 leads to always checking for null when using concat when aggregrating keys for validation. We changed to always having a non-null collections and enums as per .Net guidelines.
Perhaps though we could introduce a JsonSerializer that skips the empty collections.

Maybe you could do this for collections http://www.newtonsoft.com/json/help/html/ConditionalProperties.htm

@javiercn something like that might work.
We will endeavor to get this into 5.2.0


Update jupiter-interface to 0.13.0

About this PR
📦 Updates com.github.sbt.junit:jupiter-interface from 0.11.4 to 0.13.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (0.11.4).
You might want to review and update them manually.
ci/mill.bat
main/define/src/mill/define/Discover.scala
readme.adoc

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.sbt.junit", artifactId = "jupiter-interface" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.github.sbt.junit", artifactId = "jupiter-interface" }
}]

labels: library-update, early-semver-major, semver-spec-minor, old-version-remains, commit-count:1

Superseded by https://github.com/com-lihaoyi/mill/pull/3382


Some more options to handle text

I've added some modification and add these things:

Ability to change typeface of menu item
Ability to change text size (in both default and selected) of menu item
Ability to add message in string over menu (like numbers, but accept String)

updated commit:

update Travis config
ability to change colors on-the-fly

I've merged your request into the dev branch. Probably in the next release. But I do not think these properties are necessary.

Thank you, maybe but I extend your library base of required things in my in-developing app. so i think it is very good that developer have these options with your great library.

I recently updated version 2. The code is completely different

how can i change typeface?

In the latest version, the font is fixed in the Material mode. But you can set whatever you want in Custom mode.


FAILED in TestIoSys, Cannot create file

Hello, may I ask you，Why does the following error occur when I use the Io500 to connect to S3?

My config-s3.ini configuration is as follows:

Can the configuration of the config-s3.ini file for interconnecting with S3 be provided?

Hi, please be careful with the secret key. We have run IO500 with various providers, however, not with Amazon itself.
In the results directory, one can see the IOR call, can you try running ior using these parameters?

Hi, please be careful with the secret key. We have run IO500 with various providers, however, not with Amazon itself. In the results directory, one can see the IOR call, can you try running ior using these parameters?

The secret key should be correct.
The results directory spatiotemporal, No orders were generated.

I tried with a S3 endpoint from Ceph, basically a call like:
./src/ior --S3-libs3.host=XXX --S3-libs3.secret-key=XX --S3-libs3.access-key=XX -a=S3-libS3

with and without --S3-libs3.s3-compatible,  --S3-libs3.region=defaultRegion --S3-libs3.location=defaultLocation works any time.
I used the latest version available here: https://github.com/bji/libs3.git
Which LibS3 version are you using?

I downloaded the master branch io500, compilation is online installation, I think libs3 should also be the latest version.

I tried with a S3 endpoint from Ceph, basically a call like:
./src/ior --S3-libs3.host=XXX --S3-libs3.secret-key=XX --S3-libs3.access-key=XX -a=S3-libS3

with and without --S3-libs3.s3-compatible, --S3-libs3.region=defaultRegion --S3-libs3.location=defaultLocation works any time.
I used the latest version available here: https://github.com/bji/libs3.git Which LibS3 version are you using?

I downloaded the master branch io500, compilation is online installation, I think libs3 should also be the latest version.

I downloaded the latest libs3 from the git hub, and running libs3 alone is fine.
Address: https://github.com/bji/libs3

When I tested S3 with the latest IO500 (https://github.com/IO500/io500), I encountered the following problems:

Can you provide for me temporary access then I will be able to debug it.
You can send it just to my email address: @.***

Message ID: @.***>


docker-compose file ownership

When running steps in docker-compose that produce artifacts, the artifacts end up being owned by root and then cleanup fails.  Im sure Im not the first to stumble into this, is there a solution before I do [terrible] things ?

The containers still run as whatever is defined as the USER in your Dockerfile.
If you're using the official docker-compose plugin, there's a parameter you can pass in a magical parameter that maps your build user: https://github.com/buildkite-plugins/docker-compose-buildkite-plugin#propagate-uid-gid-optional-run-only-boolean

@moensch much obliged, Samuel!
👏

Thanks for commenting with the fix for this issue @moensch 👏 I’m going to close this issue but feel free to re-open or leave another comment if we can help further.


SparkSQLCompare and spark submodule

In the following PR I've created:

bumped version to 0.13.0 (breaking changes)
new Compare class called SparkSQLCompare

the Pandas on Spark API while simplified did not seem to be performant.
this new logic seems to be much faster and should yield almost identical result
support for pandas 2.0+ unlike SparkPandasCompare

renamed SparkCompare -> SparkPandasCompare
reorganized all the spark logic into a submodule spark
cleaned up some typing
updates for docs

Some benchmark numbers to follow

single machine: 16 CPUs, 64 GB RAM
100 Million rows x 10 cols:
----------------------------------------------- benchmark: 1 tests -----------------------------------------------
Name (time in s)          Min       Max      Mean   StdDev    Median     IQR  Outliers     OPS  Rounds  Iterations
------------------------------------------------------------------------------------------------------------------
test_vanilla         133.7600  384.2520  161.6279  78.2540  137.0472  4.0239       1;1  0.0062      10           1
------------------------------------------------------------------------------------------------------------------

500 Million rows x 10 cols:
Does not run: OOM

Distributed: 20 executors, 8 cores, 32GB RAM
100 Million rows x 10 cols:
--------------------------------------------- benchmark: 1 tests ---------------------------------------------
Name (time in s)         Min      Max     Mean   StdDev   Median     IQR  Outliers     OPS  Rounds  Iterations
--------------------------------------------------------------------------------------------------------------
test_vanilla         37.7553  91.5924  47.2185  16.2070  41.5550  6.0568       1;1  0.0212      10           1
--------------------------------------------------------------------------------------------------------------

500 Million rows x 10 cols:
----------------------------------------------- benchmark: 1 tests -----------------------------------------------
Name (time in s)          Min       Max      Mean   StdDev    Median     IQR  Outliers     OPS  Rounds  Iterations
------------------------------------------------------------------------------------------------------------------
test_vanilla         110.8866  239.6311  130.9814  38.4822  118.5674  7.5951       1;1  0.0076      10           1
------------------------------------------------------------------------------------------------------------------

One thing to mention, I do seem to get several of the following warning when performing a Spark SQL compare: No Partition Defined for Window operation! - looks like you'd need to add a partition to the Windows in the dataframe merge to silence these.
I think this is coming from the following lines:

df1 = df1.withColumn(
    "__index",
    row_number().over(Window.orderBy(monotonically_increasing_id())) - 1,
            )
df2 = df2.withColumn(
    "__index",
    row_number().over(Window.orderBy(monotonically_increasing_id())) - 1,
)

I need to create an index column but the increasing number need to happen across the whole dataframe, so there isn't anything to really partition on. This only happens when there are dupes

One thing to mention, I do seem to get several of the following warning when performing a Spark SQL compare: No Partition Defined for Window operation! - looks like you'd need to add a partition to the Windows in the dataframe merge to silence these.

I think this is coming from the following lines:
df1 = df1.withColumn(
    "__index",
    row_number().over(Window.orderBy(monotonically_increasing_id())) - 1,
            )
df2 = df2.withColumn(
    "__index",
    row_number().over(Window.orderBy(monotonically_increasing_id())) - 1,
)

I need to create an index column but the increasing number need to happen across the whole dataframe, so there isn't anything to really partition on. This only happens when there are dupes.
I think I can just use monotonically_increasing_id without any windowing. It should still give the same effect.

Re-testing locally with a small dataframe, it seems what use to be a ~6-7 second run is now ~25 seconds due to this specific change. I'm not sure how this scales with larger dataframes and running locally vs a cluster, but it may be worth checking this doesn't have a meaningful affect on performance.

One thing to mention, I do seem to get several of the following warning when performing a Spark SQL compare: No Partition Defined for Window operation! - looks like you'd need to add a partition to the Windows in the dataframe merge to silence these.

I think this is coming from the following lines:
df1 = df1.withColumn(
    "__index",
    row_number().over(Window.orderBy(monotonically_increasing_id())) - 1,
            )
df2 = df2.withColumn(
    "__index",
    row_number().over(Window.orderBy(monotonically_increasing_id())) - 1,
)

I need to create an index column but the increasing number need to happen across the whole dataframe, so there isn't anything to really partition on. This only happens when there are dupes.
I think I can just use monotonically_increasing_id without any windowing. It should still give the same effect.

Re-testing locally with a small dataframe, it seems what use to be a ~6-7 second run is now ~25 seconds due to this specific change. I'm not sure how this scales with larger dataframes and running locally vs a cluster, but it may be worth checking this doesn't have a meaningful affect on performance.

@rhaffar Any chance you have some sample code I can try and recreate locally?

One thing to mention, I do seem to get several of the following warning when performing a Spark SQL compare: No Partition Defined for Window operation! - looks like you'd need to add a partition to the Windows in the dataframe merge to silence these.

I think this is coming from the following lines:
df1 = df1.withColumn(
    "__index",
    row_number().over(Window.orderBy(monotonically_increasing_id())) - 1,
            )
df2 = df2.withColumn(
    "__index",
    row_number().over(Window.orderBy(monotonically_increasing_id())) - 1,
)

I need to create an index column but the increasing number need to happen across the whole dataframe, so there isn't anything to really partition on. This only happens when there are dupes.
I think I can just use monotonically_increasing_id without any windowing. It should still give the same effect.

Re-testing locally with a small dataframe, it seems what use to be a ~6-7 second run is now ~25 seconds due to this specific change. I'm not sure how this scales with larger dataframes and running locally vs a cluster, but it may be worth checking this doesn't have a meaningful affect on performance.

@rhaffar Any chance you have some sample code I can try and recreate locally?
on a 10K row dataset I get:

New: 286 ms ± 65.9 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
Old: 586 ms ± 128 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

Sure, can't share ipynb files so I'll just copy paste the code block. Frankly this was tested with dataframes that are only a few rows, and was run locally, so I suppose not super meaningful for performance testing. If you're getting improved performance with the updated code on a larger dataset then I think that's much more useful
`import datetime
from pyspark.sql import SparkSession
import datacompy
import datacompy.spark.sql as sp
Building the SparkSession and name
it :'pandas to spark'
spark = SparkSession
.builder
.appName("datacompy_spark")
.getOrCreate()
from pyspark.sql import Row
This example assumes you have a SparkSession named "spark" in your environment, as you
do when running pyspark from the terminal or in a Databricks notebook (Spark v2.0 and higher)
data1 = [
Row(acct_id=10000001234, dollar_amt=123.45, name='George Maharis', float_fld=14530.1555,
date_fld=datetime.date(2017, 1, 1)),
Row(acct_id=10000001235, dollar_amt=0.45, name='Michael Bluth', float_fld=1.0,
date_fld=datetime.date(2017, 1, 1)),
Row(acct_id=10000001236, dollar_amt=1345.0, name='George Bluth', float_fld=None,
date_fld=datetime.date(2017, 1, 1)),
Row(acct_id=10000001237, dollar_amt=123456.0, name='Bob Loblaw', float_fld=345.12,
date_fld=datetime.date(2017, 1, 1)),
Row(acct_id=10000001239, dollar_amt=1.05, name='Lucille Bluth', float_fld=None,
date_fld=datetime.date(2017, 1, 1))
]
data2 = [
Row(acct_id=10000001234, dollar_amt=123.4, name='George Michael Bluth', float_fld=14530.155),
Row(acct_id=10000001235, dollar_amt=0.45, name='Michael Bluth', float_fld=None),
Row(acct_id=None, dollar_amt=1345.0, name='George Bluth', float_fld=1.0),
Row(acct_id=10000001237, dollar_amt=123456.0, name='Robert Loblaw', float_fld=345.12),
Row(acct_id=10000001238, dollar_amt=1.05, name='Loose Seal Bluth', float_fld=111.0),
Row(acct_id=10000001238, dollar_amt=1.05, name='Loose Seal Bluth', float_fld=111.0)
]
df_1 = spark.createDataFrame(data1)
df_2 = spark.createDataFrame(data2)
compare = sp.SparkSQLCompare(spark, df_1, df_2, join_columns=['ACCT_ID'])
#compare.matches(ignore_extra_columns=False)
print(compare.report())
`

@rhaffar thanks for flagging. Running some benchmarks with dupes in there. not sure if this might be an issue when running on very small data since it all gets moved to one partition vs multiple. With larger datasets moving everything over to one partition would cause OOM errors. Let's see with 10M or 100M and distributed.

LGTM

Thanks! I think looking at this on distributed for 10M rows:
withColumn("__index", monotonically_increasing_id())
--------------------------------------------- benchmark: 1 tests ---------------------------------------------
--
Name (time in s)         Min      Max     Mean   StdDev   Median     IQR  Outliers     OPS  Rounds  Iterations
--------------------------------------------------------------------------------------------------------------
test_vanilla         17.3825  75.0905  24.8319  17.8866  18.2787  1.5836       1;2  0.0403      10           1
--------------------------------------------------------------------------------------------------------------

vs
withColumn(
"__index",
row_number().over(Window.orderBy(monotonically_increasing_id())) - 1,
)
---------------------------------------------- benchmark: 1 tests ---------------------------------------------
Name (time in s)         Min       Max     Mean   StdDev   Median     IQR  Outliers     OPS  Rounds  Iterations
---------------------------------------------------------------------------------------------------------------
test_vanilla         47.3446  159.5515  60.6921  34.8873  47.9401  6.9533       1;1  0.0165      10           1
---------------------------------------------------------------------------------------------------------------

Hypothesis seems to make sense. Large data would benefit from the first vs smaller data.

@fdosani , I tried this pull request using remote databricks spark cluster using databricks-connect library. With this library, I get pyspark.sql.connect.dataframe.DataFrame and when I pass it to SparkSQCLompare(), I get following error:
TypeError: df1 must be a pyspark.sql.DataFrame
pyspark.sql.connect.dataframe.DataFrame worked earlier with legacysparkcompare.

@fdosani , I tried this pull request using remote databricks spark cluster using databricks-connect library. With this library, I get pyspark.sql.connect.dataframe.DataFrame and when I pass it to SparkSQCLompare(), I get following error:
TypeError: df1 must be a pyspark.sql.DataFrame
pyspark.sql.connect.dataframe.DataFrame worked earlier with legacysparkcompare.
I am checking how to convert pyspark.sql.connect.dataframe.DataFrame to pyspark.sql.DataFrame

So I don't know much about Spark Connect, but it seems to allow remote spark connects to run dataframes commands etc.
I think you won't be able to get a normal pyspark.sql.DataFrame since you are using a remote cluster.
For your natural workflow are you using Spark Connect, or was this just to test out?

@fdosani , I tried this pull request using remote databricks spark cluster using databricks-connect library. With this library, I get pyspark.sql.connect.dataframe.DataFrame and when I pass it to SparkSQCLompare(), I get following error:
TypeError: df1 must be a pyspark.sql.DataFrame
pyspark.sql.connect.dataframe.DataFrame worked earlier with legacysparkcompare.
I am checking how to convert pyspark.sql.connect.dataframe.DataFrame to pyspark.sql.DataFrame

So I don't know much about Spark Connect, but it seems to allow remote spark connects to run dataframes commands etc. I think you won't be able to get a normal pyspark.sql.DataFrame since you are using a remote cluster.
For your natural workflow are you using Spark Connect, or was this just to test out?

We always use databricks spark via spark connect from servers outside databricks, so I need to find workaround to convert this. I am looking the PR https://github.com/apache/spark/pull/46129 to see if such conversion possible.

@satniks can you try this branch quickly? https://github.com/capitalone/datacompy/tree/spark-connect-test

@satniks can you try this branch quickly? https://github.com/capitalone/datacompy/tree/spark-connect-test

Wow.  Thanks @fdosani  It worked and shown expected differences. It also fixed performance issues I reported earlier with version 0.12 with databricks sparks.
Now waiting for version 0.13 :-)


Examples not working

Did everything good, but examples are not working as I wrote here.

Make sure you are using updated code here
Also make sure the username and channel you are connecting to are typed in all lowercase. it might be worth having code like:
username=lower(username  = sys.argv[1])
cannel=lower(channel   = sys.argv[4])

That would be
username=(sys.argv[1]).lower
channel=(sys.argv[4]).lower
in Python 3(.6)


feat: sync feature from beta/1.0.3

PR Type

Improvement

Related Links

Description

sync following pr
https://github.com/tier4/vehicle_voice_alert_system/pull/44

Review Procedure

Remarks

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[ ] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets
[ ] Write release notes

CI Checks

Build and test for PR: Required to pass before the merge.

@tkhmy これ今日入れてしまいますか

@yabuta はい、お願いします。


[Automation] Generate Fluent Lite from commerce#package-2015-06-preview

[Automation] Generate Fluent Lite from commerce#package-2015-06-preview

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-resourcemanager-commerce


is_url returns false on uppercase URL scheme

What?
I've found that checking a URL with an uppercase scheme name with the is_url checker results in a "False" result.
Desired Behaviour
RFC-3986 specifies that the scheme portion of a URL should be case-insensitive:

Scheme names consist of a sequence of characters beginning with a
letter and followed by any combination of letters, digits, plus
("+"), period ("."), or hyphen ("-").  Although schemes are case-
insensitive, the canonical form is lowercase and documents that
specify schemes must do so with lowercase letters.  An implementation
should accept uppercase letters as equivalent to lowercase in scheme
names (e.g., allow "HTTP" as well as "http") for the sake of
robustness but should only produce lowercase scheme names for
consistency.

I believe that the checker should return "True" if an uppercase scheme is provided, even if the validator wants to coerce it to lowercase later.  I'd be interested to hear your thoughts :smile:
Demonstration
$ pip3 freeze | grep validator-collection
validator-collection==1.4.2

$ python3
Python 3.7.7 (default, Jun 29 2020, 14:21:56)
[Clang 11.0.3 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from validator_collection import checkers
>>> url = "https://www.google.com"
>>> checkers.is_url(url)
True
>>> url = "HTTPS://www.google.com"
>>> checkers.is_url(url)
False

The desired behaviour would be:
>>> url = "HTTPS://www.google.com"
>>> checkers.is_url(url)
True

Yep, this definitely looks like a bug. I’ll fix it in the next release. Good catch, and thanks!

Thanks for the quick bugfix!  Appreciate it!


Broken links on PropertyInfo.GetValue Method

Some links on this page are in markdown - which is not rendering correctly. I assume they should be <see> links instead.
Reporting this instead of fixing as I'm not set up to do that right now - sorry!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd911afa-c74f-48a8-2b02-365ffe4c8fc7
Version Independent ID: e67c98df-4339-0ec5-3700-2def4d21d496
Content: PropertyInfo.GetValue Method (System.Reflection)
Content Source: xml/System.Reflection/PropertyInfo.xml
Service: .net
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

Thanks, @ChrisMaddock, for pointing out the broken links. There's no need to apologize for not fixing them yourself. I'll open a PR to do it shortly.


DaggerGlobalComponent not found

hi, i try to import and explore the project, bu failed upon building because DaggerGlobalComponent class is not found, the import path is pointed to import com.byoutline.kickmaterial.dagger.DaggerGlobalComponent; but got nu luck find it there
found out that this class was used in com.byoutline.kickmaterial.KickMaterial and com.byoutline.kickmaterial.espressohelpers.DaggerRules
any suggestion? thanks for the help

try to checkout to develop, but couldn't find either

Build the app.

@Rainer-Lang you are goddamn right, this should be somewhere around wiki or how to tho.. thanks btw!


Update docs link in readme

:information_desk_person:  just a tiny fix for your readme

Beautiful! Thank you so much for your contribution!


Revert 25521

Details

Revert 25521, wrongly fixed showing the report of an attachment after close.
Fixed Issues

$ https://github.com/Expensify/App/issues/23068
PROPOSAL: https://github.com/Expensify/App/issues/23068#issuecomment-1712578656
Tests

Open the app
Copy the URL of any attachment
Paste that URL in another report
When clicking on the link URL it should open the attachment view
When closing it should not redirect to the report of the attachment it should stay on the same chat you were on when opening the attachment

[ ] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Open the app
Copy the URL of any attachment
Paste that URL in another report
When clicking on the link URL it should open the attachment view
When closing it should not redirect to the report of the attachment it should stay on the same chat you were on when opening the attachment

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/41372145/fa6e9188-4ed9-4f30-a7c2-8f7dced4f610

Android: mWeb Chrome

https://github.com/Expensify/App/assets/41372145/3143e903-9a12-47da-967c-f73a77f4ec41

iOS: Native

https://github.com/Expensify/App/assets/41372145/d2faabf0-dd3e-4150-8400-bf7910b9efba

iOS: mWeb Safari

https://github.com/Expensify/App/assets/41372145/e6631f63-a8b6-4b15-b2bc-851c302731f9

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/41372145/e10397dd-e751-42b2-a8ba-703552e269f5

MacOS: Desktop

https://github.com/Expensify/App/assets/41372145/2d0cc776-193b-4e14-b142-89acbfd85492

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


CORE-18071 Quasar ignore net.corda.ledger.common.data.transaction package

This fix is related to a bug that came up recently. We've been getting Cannot read field "merkleTreeProvider" because  "$this" is null errors in flow worker logs.

@nkovacsx : apologies for force pushing, I need to rebase the PR against release/os/5.1 and disable the Fiber Cache in order to run some tests.


Can't Run .js Code

I am following the GDAX Trading Toolkit User's Guide (0.0.1 : https://coinbase.github.io/gdax-tt/gtt_installation.html) and I am able to install the package using yarn and I do not get any error messages in regards to installation, however when I try to test the require statement when running my .js file I get this error:
PATH_TO_DIRECTORY/node_modules/ccxt/js/base/Exchange.js:337
let partial = async params => this[methodName] (url, type, uppercaseMethod, params || {})
^^^^^^
SyntaxError: Unexpected identifier
at createScript (vm.js:56:10)
at Object.runInThisContext (vm.js:97:10)
at Module._compile (module.js:542:28)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (PATH_TO_DIRECTORY/node_modules/ccxt/ccxt.js:33:19)
According the the User's Guide I was able to test the installation since this command:
./node_modules/.bin/gdaxConsole  --product BTC-USD -t
returned what was expected. But when I run my .js file I receive that error as shown above. What can I do to fix this? Thanks!

Thanks @kroitor!


Workload tracking improvement - emit event both at the beginning and end of each workflow operation

LST-Bench workload comprises of various operations, including phase, task, and statement. Currently, for tracking purpose, the workload executor emits telemetry events at the end of each operation. The event payload indicates operation start and end times in addition to status of the operation execution. However, this approach poses a problem in error situations and also makes it harder to track progress till an operation completes. It becomes unclear whether the operation had even started or not. To address this issue, I propose enhancing our workload execution tracking by emitting an additional event at the beginning of each operation, in addition to the existing event at the end. Note, missing end event would indicate operation failure.
This approach partially borrows from popular event frameworks like XEvent in Sql Server. For e.g., SQL Server emits an xevent when SQL statement execution starts, and can emit an event when the statement completes or fails.
Another advantage of this change is its potential for extension to other components of the benchmark, going beyond just the workload tracking.
As such, each event will carry the following fields:

experiment id: experiment run identifier)
timestamp
event name (e.g. operation started, operation completed, operation failed, etc.)
event id (e.g. operation instance identifier. Start and end events of an operation carry the same id)
operation name (e.g. operation identifier from the workload config file)
event payload [optional]

This change will require changes to analysis scripts that depend on both start and end times.

@jcamachor what do you think about the proposal?

Thanks for putting together this proposal, @ashvina ! I think it makes sense and heads in the right direction. As the project evolves, if more flexibility is needed, maybe we can create more complex extensions, that if I'm not mistaken is something that the XEvent framework also considers?
When it comes to the analysis scripts, I hope we can get testing for the metrics module shortly (#22), including some integration testing between core and metrics modules as well. That way we can catch any issues more easily moving forward.
CCing @anjagruenheid for awareness.


[WFLY-9762] JMS message is not received when using a non-transactiona…

…l JMSConnectionFactoryDefinition
Issue: https://issues.jboss.org/browse/WFLY-9762
Problem caused by the fact, that the value of the transactional attribute (from annotation JMSConnectionFactoryDefinition ) is ignored. If there is value false, it has to be propagated into artemis, to be used during transaction logic.
This change needs following change in ActiveMQ Artemis - https://github.com/apache/activemq-artemis/pull/1857
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:

[ ] Pull Request title is properly formatted: [WFLY-XYZ] Subject or WFLY-XYZ Subject
[ ] Pull Request contains link to the JIRA issue(s)
[ ] Pull Request contains description of the issue(s)
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Attached commits represent units of work and are properly formatted

For bigger changes, major and minor component upgrades make sure your PR also meets following requirements:

[ ] Pull Request requires a change to the documentation
[ ] Documentation have been updated accordingly
[ ] Tests were added to cover changes

For new features ensure as well:

[ ] Analysis was done
[ ] Test Plan has been done
[ ] Tests were verified in advance

If you are not an active contributor of the WildFly project you can request sponsorship by one of the members to help guide you through the process.

Retest this please

@kabir this change can not be successful without change in ActiveMQ Artemis - apache/activemq-artemis#1857

@JiriOndrusek Adding the hold label. Ping @wildfly/mergers-full when ready

@JiriOndrusek Looking at https://github.com/apache/activemq-artemis/pull/1857 it appears to have been closed and not merged. Is this PR still relevant?

@kabir I'm looking into it too.It seems, it seems that change from apache/activemq-artemis#1857  has been commited by https://github.com/apache/activemq-artemis/commit/58c058f60e7f493a836823e319c39daec2419494 . I think that this change has to be also propagated into branch jboss-1.5.5-x to be used by this PR (and wildfly). I'll try to simulate problem in current wildfly and if needed, I'll create PR fir jboss-1.5.5-x.
(I think that this PR is still relevant)

@JiriOndrusek I think the current aim is to have Artemis 2.x for 14 (if the team makes it). @jmesnil can advise on the exact version we will have

@Kabir If 2.x will be ready, than this PR could be re-tested again and should be green.

@Kabir I've quick validated it with 1.5.5-x (with cherry-picked change from 2.x) and it is working, so as soon as artemis is switched to 2.x, or PR for 1.5.5-x is merged, this PR can be merged too.

Retest this please
@JiriOndrusek please keep an eye out as this has been open for so long, so I will probably forget all about it :)

@kabir I think this could merged. Wildfly uses artemis2.x -  <version.org.apache.activemq.artemis>2.6.3.jbossorg-001</version.org.apache.activemq.artemis>. Tests are successful.


Sample implementation of using Kubernetes leases instead of daemonset lock

Resolves #25
This is a demo implementation that I have working in my local environment. We can't directly use the leaderelection package from client-go without some modification (the daemonset will persist post restart of the node, so the original context of leader election will be lost).
Would love to chat about this implementation and get it ready for inclusion in this library. Thanks for your work on this great tool!

I would like to dig deeper into this. I need to understand more about leases behaviour, api impact on large clusters. Okay to discuss this ? I added you on linkedin for better coordination.


Minor typo in readme.

Please see pull request: https://github.com/underarmour/dynago/pull/16

done


[Menu/Dialog] Focus resets to top of the page upon exiting dialog.

📝 Feedback
When using keyboard navigation with Menu and Dialog components, the focus resets to the top of the page.
🔦 Context
For a11y, if user attempts to use only keyboard navigation with a Menu component, where if an item displays a dialog, the focus is reset to the top of the page when exiting out of the dialog.
It would be good to have the focus reset to the action button of the menu prior to showing the menu items so users can resume at where they left off of previously
💻 Code Sample
https://codesandbox.io/s/frosty-jasper-8188g
Please use keyboard navigation to open the menu, select open and then press escape to exit dialog. Observe when you exit the dialog and notice that the focus is reset to the top of the page.

🌍 Your Environment

Software
Version(s)

adobe/react-spectrum
latest 3.15.x

Browser
Chrome

Operating System
MacOS Big Sur

🧢 Your Company/Team
Adobe/AEP

This is because the menu item that opened the dialog has unmounted. Duplicate of #2444.


RTT numbers are quoted in JSON, should be without quotes as they are numbers

Solved in commit 4152c02


Using with React 0.14.8, resize not working

I am trying to get this working in a project that is using react 0.14.8, I have set the version of react-grid-layout to 0.10.10. This seems to work (no visible errors), however it looks like the resize library is breaking as I can no longer resize the items in the grid.
It appears the 0.10.10 versions dependency for the resize library is carroted "react-resizable": "^1.2.0" , and the version it is pulling is dependent on react ^15. I am not sure this is causing the issue, but this is my best guess. I am wondering if there is a way to get the resize working with react 0.14.8 (everything else works great). Much appreciated!

I'm sorry, but older React versions are not supported. You could work around this by using a shrinkwrap file to pin the resizable dependency.


feature: Build schema on upstream version 3.8.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (a017a86) to head (a16182e).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           aiven-anton/3.7.0      #206   +/-   ##
===================================================
  Coverage             100.00%   100.00%
===================================================
  Files                     14        14
  Lines                    822       822
  Branches                 132       132
===================================================
  Hits                     822       822

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BUG] Translation issue on Markdown fields

Version information

Laravel: v5.8
Voyager: v1.2.6
PHP: 7.2
Database: MariaDB

Description
When a given field has type "markdown" in BREAD, the translation buttons don't change the markdown editor content. Whenever I click "EN" or "FR" into the edition form, the WYSYWYG content remains unchanged.
However:

when I go to the "view" page, it does work fine.
when I set this field as "textarea", it does work fine.

Steps To Reproduce

Set a field as Markdown
Add a content, translate it and save
Go back to the edit form. Click on the translation buttons.

Expected behavior
When clicking on the "EN" button, the content should display the english translation
Screenshots

Would you be able to submit a PR with a test showing this failing? It would help identify the issue and help build out our test suite.

Sorry @fletch3555 I won't have time to setup a new instance of Voyager with a test case. But it's quite simple to reproduce on any existing instance of Voyager.
Into my form, I am able to find the hidden field containing my translations:
<input type="hidden" data-i18n="true" name="content_i18n" id="content_i18n" value="{"fr":"Je suis français\n","en":"I'm english"}">

I did not find the fix yet but I suppose this is related to vendor/tcg/voyager/resources/assets/js/multilingual.js.
I can see line 199:
           if (inpUsr.hasClass('richTextBox')) {
                var $_mce = tinymce.get('richtext'+inpUsr.prop('name'));
                $_val = $_mce.getContent();
            }

There is a special case for richTextBox.
Shoudn't it be a special case for SimpleMDE Markdown editor too ?
Thanks

Any update on this one?

Ran into this issue myself - submitted a PR with the fix I'm using.

Fixed in #4361 (merged into 1.x)


How to test/run polynomial.js?

I would like to test the library, however, in the example code there is require() which is non-standard Javascript but probalby node.js.
How can I run the code without the need of node.js?
I included the script: <script src="polynomial.js" type="text/javascript"></script>
Then I tried to run this example:
console.log(new Polynomial("3891238912389182391919282829x^3+4").add("23819218x^2-381").toString());

But I get:
TypeError: invalid 'instanceof' operand Fraction

Thanks in advance.

RTFM: https://github.com/infusion/Polynomial.js#using-polynomialjs-with-the-browser :)

Oh, but it's indeed a good catch. I'll fix this error, it should be possible to embed the file the way you did.  But if you want to use rational or complex polynomials you have to include fraction.js and complex.js, which can be found on my github repo here or can be downloaded simply with npm or bower.

Fixed, you now can use polynomial.js with


Updated Github Actions config with Environment Files

Fixing #146, I used the new Github Actions Environment Files and removed ACTIONS_ALLOW_UNSECURE_COMMANDS. I also updated the build tools versions:

CMake: 3.17.0 -> 3.19.7
Ninja: 1.10.0 -> 1.10.2
ccache: 3.7.7 -> 4.2.1

Thank you, merged!


TestConnect: Extend timeout, only listen locally

@hardening Looks like a too tight timeout check was at fault


!gen gives this: The chat is disabled.

I just installed it and i also have every dependency.
I don't know if i forgot something so please help.

Same here, and if i try to put the !gen command in the server console (not inside of csgo) it gives me a "!gen is not a command" error

Did you find a solution

I just installed it and i also have every dependency. I don't know if i forgot something so please help.

Did you find a solution bro


Core dump issue

Hi, I have read paper of SViCT and tried to use this tool for my analysis
The compilation was successful and ran this tool using cfDNA sample and the core dump has raised.
Command line I have used is shown below
$SVICT/svict -i sample.bam -r hg38.fa -o outfile
The GDB's strack trace using core file generated shown below
#0  0x000000000042eddc in svict_caller::generate_intervals(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool) () (gdb) bt #0  0x000000000042eddc in svict_caller::generate_intervals(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool) () #1  0x0000000000436b60 in svict_caller::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int, int, int, int, int, int, bool, int, int, int, double, bool, bool) () #2  0x0000000000409d3b in predict(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool, bool, int, int, int, int, int, int, int, int, int, bool, int, int, int, double, bool, bool, bool) () #3  0x0000000000404a4c in main ()
The computer is equipped with Ubuntu 16,04 LTS and 32 cores of Xeon Phi system.
Our compiler is gcc 5.4.0
The reference sequence I have used is GRCh38 version
Thanks ins advance

We are looking into this. Please keep tuned.

We pinpoint the issue. We will resolve it in the next few days and push it once tested. Thanks.

Should be fixed in v1.0.1. Please let us know if you still experience similar issues.