generateSignInWithEmailLink(...) in Admin Auth DSK

Is your feature request related to a problem? Please describe.
We are implementing Firebase authentication on our project, which uses Javascript Client SDK for direct user interaction, but we want to use PHP Admin SDK for generating and sending the login links by email directly to the user (Basically this thing) But I see this particular method is not (yet?) implemented in this lib.
Describe the solution you'd like
I would love to see the generateSignInWithEmailLink(...) method added to the Auth SDK
Describe alternatives you've considered
Using the Admin SDK from another language?... but that seems like a huge overkill to add a new language to the "zoo" just for the sake of this single call.
Additional context
Here it was mentioned that it is likely to be added in the future release.
With some guidance on where to start and how to properly implement this I don't mind getting my hands dirty and I could contribute in the form of PR(s).
But I'm rather fresh to Firebase terminology and I'm not quite fully comprehending the structure/architecture of this library, so might need quite some help.

Thanks for letting me know/reminding me! I‘ve had a Look at the other SDKs and the internals have changed a little since I last touched the component, so it will take me a bit to apply this to the library - but know that this is now on the top of my todo list.

Glad to hear! Let me know if I can help in any way. Looking forward to this

@mkilmanas I just created a draft PR at #360 which should include the basic functionality, would you like to give it a try and see if it works for you so far? There is still a lot missing, but I believe I'm onto something ^^.

@jeromegamez looks great! I've tried it out and seems to work nicely.
All but one thing - is it currently respecting the ActionCodeSettings parameter? From what I found in the Firebase Docs the 'url' parameter should mean the 'continueUrl', i.e. where to redirect upon verification (or did I misinterpret that?), but currently I get "Error encountered / Continue URL is required for email sign-in!". It only works if I manually append '&continueUrl=' . urlencode($continueUrl); at the end of the retrieved url. Is that expected? Or is that To-Do?
Anyway, thanks a bunch for such a quick turnaround 👍

@mkilmanas I just pushed new code and modified the code examples in the PR description.
PS: Would it be okay for you to continue the discussion in #360 so that I don't have to switch between #359 and #360 for talking to you? 😅

And now it's released, another issue closed 🎉, thank you for (re-)pushing the idea and testing the implementation! 🤗
https://github.com/kreait/firebase-php/releases/tag/4.37.0


Implement CSS logical properties

Discovered through #3495 — it appears that<EMAIL_ADDRESS>introduces CSS logical properties, part of the RTL improvements they’ve been working through.
Probably a larger initiative for us to consider as well, but don’t believe these changes seem too widespread for us to update in one of our routine dependency updates.
### Tasks
- [ ] https://github.com/carbon-design-system/ibm-products/issues/5236

Could leverage VRT to aid with the before/after.

Is this still in review or complete? @kennylam

Check in on whether this is blocked by Percy.

Okay to close @elycheea ?

@ljcarot The PR is still open and pretty old.
After changing the base branch to main, there’s actually several conflicted files so I recommend we pop this one back to backlog for the new year and we remake the changes on a new branch since this was originally pointing to the percy-integration branch.


Broken intellisense

intelli sense doesn’t work - try typing “runIn” - it will insert “runInBackground” instead of “basic.runInBackground"

Multi-level intellisense not working. Dup of #1511


Add diagnostic for files that need proofing

Name of diagnostic:
Remediated files that need proofing
To list in the diagnostic:
All files that have @status="IML-TEI_proofing" on <revisionDesc>

Does this need a diagnostic? You can just right-click on data/texts and search for that status value to get a list of documents. Do we want to add more time to the build for that?

Good point. We already have a Diagnostic that checks for this at the Anthology diagnostics level (i.e., files that don't have the @status="published"). That's probably a better place for it since my team does not want to do the proofing if we don't have to.
Closing this ticket.


Undo the Secrets controller sync wait.

When Secrets permissions have not been granted (which is likely to be the case for users not needing the basic auth feature), the watch on the Secrets API will never yield a response, thereby causing the controller to never sync successfully, and in turn causing the check for all controller synchronizations to fail consistently. Thus, no event will ever be handled.
Fixes #1826
Reverts a part of #1798
Verified that #1794 continues to be fixed
Reviewers and @containous/traefik: PTAL.

@errm agreed -- I have filed #1784 a few days ago to track this effort.


Added missing OTP validation error message

#ATCP

These references to localizing the UI elements should be removed, and a reference made to the localisation docs instead or to the lower section optional-localize-the-ui.

Ok, just to confirm, the doc samples should not contain the metadata overrides at all and natural flow for the user should be to the localization section within the same article?
"After you add the localized strings, remove the OTP validation error messages metadata from the LocalAccountSignUpWithLogonEmail and LocalAccountDiscoveryUsingEmailAddress technical profiles." should also be removed from optional-localize-the-ui by reckoning...
Once you confirm @JasSuri I'll update the PR :)

Ok, just to confirm, the doc samples should not contain the metadata overrides at all and natural flow for the user should be to the localization section within the same article?

That is right. We don't want users doing any localisation in the metadata section of a technical profile.

"After you add the localized strings, remove the OTP validation error messages metadata from the LocalAccountSignUpWithLogonEmail and LocalAccountDiscoveryUsingEmailAddress technical profiles." should also be removed from optional-localize-the-ui by reckoning...
Once you confirm @JasSuri I'll update the PR :)

We just need to remove the metadata items entirely, it will use the default strings when they are not present.

@JasSuri IS THIS GOOD TO GO NOW? CAN WE GET IT SIGNED OFF?

@bolt-io : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good

Looks good

It looks like this is approved, so we'll set it to "ready to merge" for when publishing resumes in the repo on Tuesday. Thanks, all.


Google Health DICOM Store Integration

Request
I'd love to see Google Health DICOM Store integration added back to v3. If no one is taking on this one, is it possible to get some guidance on this task? I'd love to contribute,
Why should we prioritize this feature?
This is important as it is supported by OHIF-V2 and prevent the community who uses GCP for DICOM storage from using OHIF V3.

Hi @j6u!
So the OpenID Connect integration with Google Cloud Heathcare API works fine right now in v3, the only thing that's missing is the user interface that exists in v2 to manually switch between projects / locations / datasets etc.
If you want to use a single DICOM store, you can write an app-config like this:
window.config = {
  routerBasename: '/',
  // This is an array, but we'll only use the first entry for now
  oidc: [
    {
      // ~ REQUIRED
      // Authorization Server URL
      authority: 'https://accounts.google.com/',
      client_id:
        '72392840.........2rhu69vlnibipmmk9i57p.apps.googleusercontent.com',
      redirect_uri: '/callback',
      response_type: 'id_token token',
      scope:
        'email profile openid https://www.googleapis.com/auth/cloudplatformprojects.readonly https://www.googleapis.com/auth/cloud-healthcare', // email profile openid
      // ~ OPTIONAL
      post_logout_redirect_uri: '/logout-redirect.html',
      revoke_uri: 'https://accounts.google.com/o/oauth2/revoke?token=',
      automaticSilentRenew: true,
      revokeAccessTokenOnSignout: true,
    },
  ],
  // whiteLabelling: {},
  extensions: [],
  modes: [],
  showStudyList: true,
  // filterQueryParam: false,
  dataSources: [
    {
      friendlyName: 'dcmjs DICOMWeb Server',
      namespace<EMAIL_ADDRESS>      sourceName: 'dicomweb',
      configuration: {
        name: 'GCP',
        wadoUriRoot:
          'https://healthcare.googleapis.com/v1/projects/ohif-cloud-healthcare/locations/us-east4/datasets/ohif-qa-dataset/dicomStores/ohif-qa-2/dicomWeb',
        qidoRoot:
          'https://healthcare.googleapis.com/v1/projects/ohif-cloud-healthcare/locations/us-east4/datasets/ohif-qa-dataset/dicomStores/ohif-qa-2/dicomWeb',
        wadoRoot:
          'https://healthcare.googleapis.com/v1/projects/ohif-cloud-healthcare/locations/us-east4/datasets/ohif-qa-dataset/dicomStores/ohif-qa-2/dicomWeb',
        qidoSupportsIncludeField: true,
        imageRendering: 'wadors',
        thumbnailRendering: 'wadors',
        enableStudyLazyLoad: true,
        supportsFuzzyMatching: true,
        supportsWildcard: false,
      },
    },
    {
      friendlyName: 'dicom json',
      namespace<EMAIL_ADDRESS>      sourceName: 'dicomjson',
      configuration: {
        name: 'json',
      },
    },
    {
      friendlyName: 'dicom local',
      namespace<EMAIL_ADDRESS>      sourceName: 'dicomlocal',
      configuration: {},
    },
  ],
  defaultDataSourceName: 'dicomweb',
};

If you'd like to start building the UI to select projects, that would be awesome! We were calling it the Google Cloud Adapter. I'm honestly not sure where it would live in v3 though, maybe as a separate page before loading the study list..

Hello @sedghi
I am using embedded OHIF Viewer with Google Healthcare API in my application. My application has valid Google Bearer token which I can use in calling Healthcare APIs.
My application already has Google OAuth Login page. Is there any way to inject token to OHIF Viewer to bypass OHIF Viewer login page?

I added and removed IDC candidate label, because for us the smaller task of basic support through URL (no GUI / fancy picker) is in the critical path.

Hi, I'm trying to use the viewer with Google Health API, I am using the following code to generate the token
from google.oauth2 import service_account
import google.auth.transport.requests
Load the credentials from your service account key file
credentials = service_account.Credentials.from_service_account_file(
'XXXX.json', scopes=['https://www.googleapis.com/auth/cloud-healthcare'])
Use the credentials to obtain an access token
auth_req = google.auth.transport.requests.Request()
credentials.refresh(auth_req)
Using this token, I can get all requests in python easily, however, the OHIF is giving me 401 error, any idea what needs to be adjusted? I am using the google.js config file from public/config. I also tried dicomweb-server.js, same issue.
Any idea?

@alib022 You need to add the client_id and register it with Google.
We have updated Google Store docs https://docs.ohif.org/deployment/google-cloud-healthcare


Even more Input Idea's

ok bear with me I know there has already been alot of changes to input that love2d didn't have.
this should be my final suggestion for inputs so I will try to make sure I don't miss anything.
the following functions should be implemented for more control over your game
Mouse

MouseButton Mouse.GetDown()
MouseButton Mouse.GetDownPrevious()
bool Mouse.IsDown(MouseButton button)
bool Mouse.IsDownPrevious(MouseButton button)

Keyboard

KeyConst        Keyboard.GetDown()
KeyConst        Keyboard.GetDownPrevious()
bool                Keyboard.IsDown(KeyConst key)
bool                Keyboard.IsDownPrevious(KeyConst key)

GamepadButton

GamepadButton Joystick.GetDown()
GamepadButton Joystick.GetDownPrevious()
bool                Joystick.IsDown(GamepadButton button)
bool                Joystick.IsDownPrevious(GamepadButton button)

GamepadAxis

GamepadAxis Joystick.GetAxis()
GamepadAxis Joystick.GetAxisPrevious()
bool                Joystick.IsAxisChange(GamepadAxis axis, bool deadzone)
bool                Joystick.IsAxisChangePrevious(GamepadAxis axis, bool deadzone)

doing this makes the newer Pressed and Released functions pointless because now you can make your own class and do something like
var Joystick = Joystick.GetJoysticks()[0];
var buttonCurr = Joystick.GetDown();
var buttonPrev = Joystick.GetDownPrevious();
var anyButtonPressed =
(
    Joystick.GetDown(buttonCurr) &&
   !Joystick.GetDownPrevious(buttonPrev )
);
var anyButtonReleased =
(
    !Joystick.GetDown(buttonCurr) &&
     Joystick.GetDownPrevious(buttonPrev )
);

which you could remove them or add pressed and released variants for JoyStickAxes as well so we can check if they just changed from 0 or just changed to 0
idk what do you think @endlesstravel?

sorry for late to reply.
i think there may be multiple buttons pressed at the same time. so, it
Mouse.GetDown Keyboard.GetDown Joystick.GetDown   should return array values.
As for and  Joystick.GetAxis, I don't think it's reasonable. It's confusing if he only returns one value when he has multiple inputs. If he returns a value, he must return a key-to-value pair(which axis is pulled) of arrays.
Anyway, I try to give you a class:
copy the code https://gist.github.com/endlesstravel/db0f9f6f93b89a23cc8f56b44b70396c into your project.
and here is test code:
    class ISSUE69 : Scene
    {
        public override void Update(float dt)
        {
            Input.Update();
        }

        public override void Draw()
        {
            Graphics.Print(string.Join("\n",
                $"mouse down {string.Join(",", Input.GetMouseDown())}",
                $"key down {string.Join(",", Input.GetKeyboardDown())}",
                $"joy key {string.Join(",", Joystick.GetJoysticks().Select(joy => string.Join(",", Input.GetGamepadDown(joy).Select(name => joy.GetGUID() + ":" + name))))}",
                $"joy axis {string.Join(",", Joystick.GetJoysticks().Select(joy => string.Join(",", Input.GetGamepadAxis(joy).Select(name => joy.GetGUID() + ":" + name))))}"
                ));
        }

    }

These could return arrays

MouseButton Mouse.GetDown()
MouseButton Mouse.GetDownPrevious()
KeyConst Keyboard.GetDown()
KeyConst Keyboard.GetDownPrevious()
GamepadButton Joystick.GetDown()
GamepadButton Joystick.GetDownPrevious()
GamepadAxis Joystick.GetAxis()
GamepadAxis Joystick.GetAxisPrevious()

as for they joystick axes they could be made to take array like everything else.
if I recall correctly lua love2d using used key to pair values with the key being a string
as for the class you posted I really don't want to have to call a update function that's kinda why I suggested this so you could have a input manager that doesn't require a update function.

If you have no problems with these functions, I will integrate them into the library. I provide class is mean in  facilitate your testing and understanding of my intentions.
I think the most controversial issue so far is the GetGamepadAxis and IsAxisChange.

GetGamepadAxis
I think structure is more appropriate in C# than dictionary. so it was

public static AnxisValue GetGamepadAxis(this Joystick joy)

The define of AxisVlaue here line 165

IsAxisChange
It's like this right now :

public static bool IsGamepadAxisChange(this Joystick joy, GamepadAxis axis)

I'm not sure what your deadzone means. Can you give me some description?
I want to add them to other namespaces(You don't need to call update manually either.). for example Love.Misc.Input. The reason is to prevent them from being used by the official Love in the future. It's best if you can accept it. But if you strongly suggest, I will add them to the library.

deadzone is the amount you need to press the joystick before it registers or return true.
I think these could be very useful in the love library,
however they would need their previous counterparts so we can check press and release values
as for the namespace I don't really know I think the the events should have been exposed in the original love2d as functions and things like getting input should have been easier
maybe I need to start suggesting features for love2d instead of love2dcs this way they can be native.

so you need a function to set the dead zone size ?

no I just thought that if the user was able to pass a deadzone it could return a bool instead of a float.

so,  you want input a function as parameter, the Joystick.IsAxisChange will not return true until the input function returns true.
so, is it like:
public delegate bool DeadZoneFunc();
bool Joystick.IsAxisChange(GamepadAxis axis, DeadZoneFunc preparatoryFunction)

?

basicly deadzone would just do
return (Maths.Abs(Joystick.IsGetAxis()) > deadzone)

ok,I'm still confused. .I don't recommend such a "complex" function, which is too confusing. On the one hand, it returns to the case of changing the axis, on the other hand, it demands to limit the dead zone. If these two conditions are combined, the situation may be different.

don't worry about the deadzone parameter users can check it manually.
its better that way anyways.
so just do..
float Joystick.IsAxisChange(GamepadAxis axis)
float Joystick.IsAxisChangePrevious(GamepadAxis axis)

Why is the function return float, can you give some description?

the float is how far you press the joystick axis.
for example if you press it left and you're using the constant GamepadAxis.LeftX it would be -1 and if your pressing right and you're using the constant GamepadAxis.LeftX it return 1;
pressing nothing would be 0;

@endlesstravel so I had an idea to reduce the function count.
basically have a enum call InputState which would contain the options for previous and current.
you would pass these into the function optionally like so..
var currMouseInput = Mouse.GetDown(MouseButton.Left, InputState.Current);
var prevMouseInput = Mouse.GetDown(MouseButton.Left, InputState.Previous);

        public static AnxisValue GetGamepadAxis(this Joystick joy);
        public static AnxisValue GetGamepadAxisPrevious(this Joystick joy);
        public static GamepadButton[] GetGamepadDown(this Joystick joystick);
        public static GamepadButton[] GetGamepadDownPrevious(this Joystick joystick);
        public static KeyConstant[] GetKeyboardDown();
        public static KeyConstant[] GetKeyboardPrevious();
        public static MouseButton[] GetMouseDown();
        public static MouseButton[] GetMouseDownPrevious();
        public static bool IsGamepadAxisChange(this Joystick joy, GamepadAxis axis);
        public static bool IsGamepadDown(this Joystick joystick, GamepadButton gbtn);
        public static bool IsGamepadDownPrevious(this Joystick joystick, GamepadButton gbtn);
        public static bool IsKeyboardDown(KeyConstant key);
        public static bool IsKeyboardPrevious(KeyConstant key);
        public static bool IsMouseDown(MouseButton button);
        public static bool IsMouseDownPrevious(MouseButton button);

Love.Misc.InputBoost available  11.0.34

@endlesstravel
some issues to note

1
all functions should take a parameter for whether you want the current input or the previous.
so for example these..
var currMouseInput = IsMouseDown(MouseButton.Left);`` var prevMouseInput = IsMouseDownPrevious(MouseButton.Left);should bevar currMouseInput = IsMouseDown(MouseButton.Left, InputState.Current); var prevMouseInput =IsMouseDown(MouseButton.Left, InputState.Previous);`
this would would make number 2 unnecessary

2
adding to number 1, we need a way to get the current and previous axis value not whether it changed or not.
so public static bool IsGamepadAxisChange(this Joystick joy, GamepadAxis axis);
should be
var currGamepadAxis = GetGamepadAxisValue(Joystick joy, GamepadAxis.LeftX, InputState.Current);
var prevGamepadAxis = GetGamepadAxisValue(Joystick joy, GamepadAxis.LeftX, InputState.Previous);

3
AnxisValue  is misspelled and should be AxisValue
`AnxisValue GetGamepadAxis(this Joystick joy);
should also return a array of single axis values to be consistent with the rest of the get functions

4
MouseButton  should be a enum in the love system not the love.misc system


Repeatable build related errors and warnings dont have docs

For exampe NU1004 https://docs.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu1004
//cc @jainaashish @anangaur

//cc @rrelyea This is the issue we discussed in stand-up.

@nkolev92, @anangaur, @rrelyea - ping!


Appstudio update test-component-pac-rdri

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-rdri-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
27 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
7 seconds
sast-snyk-check

✅ Succeeded
23 seconds
inspect-image

✅ Succeeded
22 seconds
deprecated-base-image-check

✅ Succeeded
40 seconds
clamav-scan

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
6 seconds
label-check

✅ Succeeded
6 seconds
show-summary

✅ Succeeded
6 seconds
show-sbom

Pipelines as Code CI/test-component-pac-rdri-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
27 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
7 seconds
sast-snyk-check

✅ Succeeded
23 seconds
inspect-image

✅ Succeeded
22 seconds
deprecated-base-image-check

✅ Succeeded
40 seconds
clamav-scan

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
6 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/test-component-pac-rdri-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
21 seconds
clone-repository

✅ Succeeded
23 seconds
build-container

✅ Succeeded
7 seconds
sast-snyk-check

✅ Succeeded
27 seconds
deprecated-base-image-check

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
36 seconds
clamav-scan

✅ Succeeded
1 minute
inspect-image

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
25 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary


⚠ Bofrost.at has degraded performance

In ad342e7, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1533 ms

Resolved: Bofrost.at performance has improved in 2800ac2.


Add "silent" option

I really like that the polyfills were separated from the core in the latest release. Making a faster loading experience for users of modern browsers is for sure a priority over shipping a more bulky library for the benefit of a small percentage of users on legacy browsers.
I upgraded without adding polyfills, but wanted to take it even a step further -- if a user is on IE, I'd rather have the plugin not run at all than commit to loading polyfills into all browsers or muddying up the code with a runtime conditional polyfill load for IE. Since this plugin is not functional and is purely aesthetic for my use-case, my preference is just to have it not load for legacy browser users - I am using it for id-based jump links, so the browser native functionality still works and it will jump to the section, but without the smooth scroll.
To accomodate this, I added a new option, silent, which is false by default, but if set to true will suppress the error thrown when the browser doesn't support the features required by smooth-scroll. Setting this option to true indicates that you are aware that older browsers will not support smooth-scroll, but are OK with it.
Surely this feature can be dangerous is set without careful consideration of where and how smooth-scroll is being used, which is why it is false by default.
I tested this feature using IE11 and it is working as intended.
I also added a npm script to run the gulp compile, which makes it easier and quicker for contributors to run without having the correct version of gulp installed globally 😁

Can you tell me a bit more about this?

I also added a npm script to run the gulp compile, which makes it easier and quicker for contributors to run without having the correct version of gulp installed globally 😁

Oops, closed by accident!
Sure - https://github.com/cferdinandi/smooth-scroll/pull/438/commits/db200f5f5d301270c589301d936fa22db5514b66#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R37
If you clone down the project, install dependencies, and run npm run build, it will build out the project now with this "script" in place, automatically using the local version of gulp from the dependencies, and without any need to have gulp globally installed on your machine. Tiny change, but makes things a little more accessible 😁

Hmm - interesting! A couple thoughts:
I feel like this change would be more likely to cause problems for users overall. It's one thing to note in the readme that the production version has no explicit compatibility checks, but it's another thing to actually have the production version run the compatibility checks and silently shut down if it's not compatible without giving any waring. I wouldn't be shocked at all if a torrent of "doesn't work in IE" issues started pouring in if this were implemented. As much as readmes are great, people only actually read them very rarely, unfortunately.
You could modify the proposal to say that the production version just doesn't check for browser support or compatibility at all to reduce extra code, but that would still result in errors - as soon as it hits a spot where one of the unsupported globals is used, there would be an error still thrown, but a more confusing one.
I'm also not aware of any major libraries that silently error by default, even in the production version. I know that many libraries give much more detailed error logs and traces in the dev than the production version, which I think is reasonable, but I don't think those same libraries actively suppress errors in production - if something goes wrong, you still get an error but perhaps not as thorough of an explanation to save some bytes.
I also don't feel like it's exactly safe to assume that the non-minified version is only going to be used in dev. With bundlers like webpack being so common, most people actually prefer to consume an unminified version, or better yet an ESM version from the package source, and let their own bundler setup do the minifying. In order to be safe with this assumption, I think you'd need to follow react's example and bundle separate dev and production versions explicitly, regardless of whether they are minified or not.
So I guess overall I don't really feel like that approach is the best direction, but of course it's ultimately up to you as the author of this package (and by the way, thank you for writing this! it has been incredibly useful for me and my employer 😁 )

Not sure if you're aware, but the error message is actually a new addition. Prior versions all failed silently if supports() returned false.
I mention this because the change would actually be a reversion to the default for the .min versions, with the thrown error being an enhancement for unminified versions of the build.
My understanding was that React, Vue, and Angular all have production and dev versions, and the big differences in production were that:

They're minified
They don't throw as many errors

Good catch on destroy(). Let me give some more thought to the silent vs. loud errors.

Just checking in again on this one!


Connect using authentication in redis server

Hi is it possible to add the auth key to the uri?
I've tried redis://[:PASSWORD@]HOST[:PORT] but does not seem to work

fixed it by encoding the url, if you have special characters in your password, you need to encode it with any url encoder tool, such as https://meyerweb.com/eric/tools/dencoder/


[BUG] Mac OS 14.2.1 setup.py install failed

setuptools version
setuptools==69.0.3
Python version
Python 3.9
OS
Mac OS 14.2.1
Additional environment information
pip==23.3.2
Description
try to install using: pip install -e . but failed.
My system path is:
['',
'/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python39.zip',
'/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9',
'/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/lib-dynload',
'/Users/nick.cheng/Library/Python/3.9/lib/python/site-packages',
'/Users/nick.cheng/Documents/WorkSpace/llama_index',
'/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/site-packages']
but setuptools cannot find the right path
===Log===
Checking .pth file support in /Users/nick.cheng/Library/Python/3.9/lib/python3.9/site-packages
/Library/Developer/CommandLineTools/usr/bin/python3 -E -c pass
TEST FAILED: /Users/nick.cheng/Library/Python/3.9/lib/python3.9/site-packages does NOT support .pth files
bad install directory or PYTHONPATH
You are attempting to install a package to a directory that is not
on PYTHONPATH and which Python does not read ".pth" files from.  The
installation directory you specified (via --install-dir, --prefix, or
the distutils default setting) was:

    /Users/nick.cheng/Library/Python/3.9/lib/python3.9/site-packages

and your PYTHONPATH environment variable currently contains:

    ''

Here are some of your options for correcting the problem:

* You can choose a different installation directory, i.e., one that is
  on PYTHONPATH or supports .pth files

* You can add the installation directory to the PYTHONPATH environment
  variable.  (It must then also be on PYTHONPATH whenever you run
  Python and want to use the package(s) you are installing.)

* You can set up the installation directory to support ".pth" files by
  using one of the approaches described here:

  https://setuptools.pypa.io/en/latest/deprecated/easy_install.html#custom-installation-locations

Please make the appropriate changes for your system and try again.

Expected behavior
install into '/Users/nick.cheng/Library/Python/3.9/lib/python/site-packages'
How to Reproduce
git clone https://github.com/geekan/MetaGPT.git
cd /your/path/to/MetaGPT
pip install -e .
Output
    Checking .pth file support in /Users/nick.cheng/Library/Python/3.9/lib/python3.9/site-packages
    /Library/Developer/CommandLineTools/usr/bin/python3 -E -c pass
    TEST FAILED: /Users/nick.cheng/Library/Python/3.9/lib/python3.9/site-packages does NOT support .pth files
    bad install directory or PYTHONPATH

    You are attempting to install a package to a directory that is not
    on PYTHONPATH and which Python does not read ".pth" files from.  The
    installation directory you specified (via --install-dir, --prefix, or
    the distutils default setting) was:

        /Users/nick.cheng/Library/Python/3.9/lib/python3.9/site-packages

    and your PYTHONPATH environment variable currently contains:

        ''

    Here are some of your options for correcting the problem:

    * You can choose a different installation directory, i.e., one that is
      on PYTHONPATH or supports .pth files

    * You can add the installation directory to the PYTHONPATH environment
      variable.  (It must then also be on PYTHONPATH whenever you run
      Python and want to use the package(s) you are installing.)

    * You can set up the installation directory to support ".pth" files by
      using one of the approaches described here:

      https://setuptools.pypa.io/en/latest/deprecated/easy_install.html#custom-installation-locations

    Please make the appropriate changes for your system and try again.

Hi @mrocker, it seems that the installation of Python that you have in your machine, does not recognise /Users/nick.cheng/Library/Python/3.9/lib/python3.9/site-packages as the correct installation path.
There might be a series of reasons for that, but I think that the first thing to be tried is to run
pip install --use-pep517 -e .

instead of simply pip install -e .
Does that work for you?
This happens because years ago there was a change in the Python ecosystem and setuptools decided to focus on only building packages; letting pip handle the installation part. As such, it was required for package developers to some implement changes (e.g. stop relying on setuptools' install command, because setuptools is no longer used for that) and explicitly opt into this new model - by adding a pyproject.toml file to their project. If the package does not have this file pip will still try to use setuptools under the hood. You can force pip opt into the "new" behaviour[^1] using the --use-pep517 flag.
The problem in using setuptools for the installation part is that this code path has been deprecated for a long time, and works in the "best effort mode". Therefore some edge cases might fail.
[^1]: This behaviour is not actually new... it is several years old now and has been standardised a while ago.


Add mocha context snippet

looks good, could you get rid of the back merge please?

could you get rid of the back merge please?

Done.


[Not an issue] Performance comparison on different Pi models?

First of all, I would like to extend my gratitude to @nisargjhaveri for creating this project.
I tried this on my Pi Zero W and Pi Zero 2W (Car: Honda City 2022, Phone: Galaxy S22 Ultra). However, the avg performance difference measured over 10 cold starts was just 3-5 sec (avg boot time 22 sec). Sometimes the Pi Zero W starts faster than Pi Zero 2W and vice versa. But overall, I can't say that there is any significant performance difference between the two boards even though 02W is almost 50% faster than 0W.
I am willing to purchase a Pi 4 and try it on that, but my reservations are whether I would get any reasonable performance benefits and whether the car USB port would be enough to keep the Pi 4 powered on.
Can someone throw some more light on this?
@nisargjhaveri Do you have any test data for the performance of various boards?

Hi, I'm glad to answer your questions.
I'm using a Pi 4 for testing.
The version is 0.41 (Pi 4, Pi Zero 2W).
The car stereo is Pioneer 5050BT, which takes about 22 seconds (matching your test results).
However, the Pi 4 tends to overheat (I haven't installed any cooling devices).
The Pi Zero 2W freezes and disconnects when the car stereo screen is tapped multiple times.
The exact cause is still unknown, but the Pi 4 is indeed more stable.
Here's a summary:
The Pi 4 can be powered via USB and has better response and stability with the car stereo.
Compared to the Pi Zero 2W, the 2W is more prone to freezing, but there are no other differences.
The above conversation was translated with the assistance of Claude.ai. I hope I've expressed my meaning clearly.
Thank you.

Hi, I'm glad to answer your questions. I'm using a Pi 4 for testing. The version is 0.41 (Pi 4, Pi Zero 2W). The car stereo is Pioneer 5050BT, which takes about 22 seconds (matching your test results). However, the Pi 4 tends to overheat (I haven't installed any cooling devices). The Pi Zero 2W freezes and disconnects when the car stereo screen is tapped multiple times. The exact cause is still unknown, but the Pi 4 is indeed more stable. Here's a summary: The Pi 4 can be powered via USB and has better response and stability with the car stereo. Compared to the Pi Zero 2W, the 2W is more prone to freezing, but there are no other differences. The above conversation was translated with the assistance of Claude.ai. I hope I've expressed my meaning clearly. Thank you.

Thanks for your in-depth reply. I will try out Pi 4 in the future if I face problems with my Pi Zeroes 🙂

Using it on Rpi4 as well on Peugeot 208 ii with Redmi note 10 Pro on Pixel OS A14
Is stable. First boot takes no longer then 22 seconds and AA starts on car unit. Way more stable then cable connection

I dont think pi4 would be a good option you can get dongle in that price


Caching doesn't work in Jupyter notebook on macOS

When trying to compile a Numba function with cache=True in a Jupyter notebook, the following error occurs:
RuntimeError: cannot cache function 'func': no locator available for file '/var/folders/xc/gg95jg7j1z94g_qds0gqpxxc0000gn/T/ipykernel_9751/3025015800.py'

Python version: 3.8.9
Numba version: 0.54.1
OS: macOS Big Sur
notebook version: 6.4.6

Numba and notebook are installed both in a virtual environment.
When running numba functions without caching in the notebook it works without problems. When running numba functions with caching within the same environment, but from a python script, it also works fine.
Steps to reproduce:

Create virtual environment python3 -m venv ./.venv
Install numba and notebook after activating the env pip install numba=0.54.1 notebook==6.4.6
Starting a notebook server and creating the following functionfrom numba import jit

@jit(nopython=True, cache=True)
def func():
    return 3

Try to execute the cell

Checklist:

[x] I have tried using the latest released version of Numba (most recent is
visible in the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
[x] I have included a self contained code sample to reproduce the problem.
i.e. it's possible to run as 'python bug.py'.

Full stack trace:
/var/folders/xc/gg95jg7j1z94g_qds0gqpxxc0000gn/T/ipykernel_9751/3025015800.py in <module>
      1 @jit(nopython=True, cache=True)
----> 2 def func():
      3     return 3

~/.../lib/python3.8/site-packages/numba/core/decorators.py in wrapper(func)
    217                           **dispatcher_args)
    218         if cache:
--> 219             disp.enable_caching()
    220         if sigs is not None:
    221             # Register the Dispatcher to the type inference mechanism,

~/.../lib/python3.8/site-packages/numba/core/dispatcher.py in enable_caching(self)
    875
    876     def enable_caching(self):
--> 877         self._cache = FunctionCache(self.py_func)
    878
    879     def __get__(self, obj, objtype=None):

~/.../lib/python3.8/site-packages/numba/core/caching.py in __init__(self, py_func)
    608         self._py_func = py_func
    609         self._impl = self._impl_class(py_func)
--> 610         self._cache_path = self._impl.locator.get_cache_path()
    611         # This may be a bit strict but avoids us maintaining a magic number
    612         source_stamp = self._impl.locator.get_source_stamp()

~/.../lib/python3.8/site-packages/numba/core/caching.py in __init__(self, py_func)
    345         else:
    346             raise RuntimeError("cannot cache function %r: no locator available "
--> 347                                "for file %r" % (qualname, source_path))
    348         self._locator = locator
    349         # Use filename base name as module name to avoid conflict between

RuntimeError: cannot cache function 'func': no locator available for file '/var/folders/xc/gg95jg7j1z94g_qds0gqpxxc0000gn/T/ipykernel_9751/3025015800.py'

@ylieder thank you for reporting this! I believe there is an error in the reproduction instructions. The command to install the dependencies should be:
pip install numba==0.54.1 notebook==6.4.6

Unlike conda, pip does not support the single equals = syntax.

@ylieder thank you again for reporting this. With the modified installation line as above I was able to reproduce this:

@ylieder I tried this with the master from today at: 8f3cd87a07 and it seems to work fine:

I would assume that a pull-request during the current development cycle has fixed this and would assume that this will no longer be an issue with the upcoming 0.55 release.

I am closing this issue now, assuming resolved. If this does persist after the release of 0.55.0 please don't hesitate to re-open this issue, thank you for your help to improve Numba!

Quick note: I would guess this was resolved by https://github.com/numba/numba/pull/7345


Error inside CommonResponse does not have getter/setter

https://github.com/payeezy/payeezy_java_sdk/blob/548e9df9238f1bc03221cfcd4cabee1a0be8cfca/src/main/java/com/firstdata/payeezy/models/transaction/CommonResponse.java#L23

https://github.com/payeezy/payeezy_java_sdk/compare/master...zardojunior:patch-1


create_and_save creates corrupted docx files on win32 platforms

Using latest version available on git (0.4.4), and create a simple ruby program.
require 'htmltoword'
file = Htmltoword::Document.create_and_save( "<title>Simple title</title>Hello docx", "out-001.docx" )
Running this on Mac OS-X works, fine and generates a docx file that can be opened. However generating and opening the same file on Win32 (Windows XP) results in a corrupted file.
Ruby version = 2.0.0p195 (but could be tested on more recent rubies)

Have managed to develop a bug fix for this. Issue lies in
lib\htmltoword\document.rb line 14
replace
         File.open(file_path, "w") do |out|

with
        File.open(file_path, "wb") do |out|
`
To ensure that files are written back in binary.
I'll try and issue a git pull request for this change,

Great!

Code merged into master. Closing issue.

In the Rubygem v0.4.4 - this bug has regressed back to the broken version, without the
File.open(file_path, "wb") do |out|

It appears the document.rb in the gem is not the same as that on github, even if you point your Gemfile to github as in
gem 'htmltoword', :git => "https://github.com/karnov/htmltoword.git"

I just downloaded and unpacked the gem straight from rubygems, the create_and_save method does open the file with the wb options, maybe it's something else? I don't use windows, so it's a bit hard to debug :confused:

I did the same as you, and yes, the extracted gem has the wb is correctly there. Did a bundle clean -force and reinstalled all gems from scratch, all seems to be ok now. Very odd. Closing call for the moment, unless I can repeat.


melgan residual stack config

Hi, In original melgan paper, the kernel size of the second conv1d layer is 3, I see that in this melgan residual config it's 1.  Is it a better config?

Hi, i didn’t know that, i follow the official code on github and the kernel size is 1.

Hi, i didn’t know that, i follow the official code on github and the kernel size is 1.

could you give a link on the official code?

@superhg2012 here, https://github.com/descriptinc/melgan-neurips/blob/master/mel2wav/modules.py#L80

@dathudeptrai thxs


Does 30x really require a Location header?

Regarding the following docs:
https://github.com/nginx/unit-docs/blob/85744c8a1de8a8805950562cbecc4a40dde3af28/source/configuration.rst#instant-responses-redirects
$ grep -rn -B1 'required if the'
source/configuration.rst-1976-   * - :samp:`location`
source/configuration.rst:1977:     - URI, required if the :samp:`return` value implies redirection.

The current behavior of Unit is that the "location" URI is optional.  The following is allowed:
"action": {
    "return": 301
}

Also, the current RFC doesn't seem to explicitly require (or I couldn't find it) that a Location header is used for 30x redirects:
https://www.rfc-editor.org/rfc/rfc7231#section-7.1.2
Should we reword that?
See also: https://github.com/nginx/unit/issues/674

A summary of the 30x codes shows that 'required if redirection is implied' is more suitable than not, so I'd rather leave this as is:
https://www.rfc-editor.org/rfc/rfc7231#section-6.4
300 Multiple Choices

   If the server has a preferred choice, the server SHOULD generate a
   Location header field containing a preferred choice's URI reference.

301 Moved Permanently

   The server SHOULD generate a Location header field in the response
   containing a preferred URI reference for the new permanent URI.

302 Found

   The server SHOULD generate a Location header field in the response
   containing a URI reference for the different URI.

303 See Other

   The 303 (See Other) status code indicates that the server is
   redirecting the user agent to a different resource, as indicated by a
   URI in the Location header field, which is intended to provide an
   indirect response to the original request.

 307 Temporary Redirect

   The server SHOULD generate a Location header field in the response
   containing a URI reference for the different URI.


Enable reading of new configuration

As a cobigen developer, I want to be able to read both versions of configurations (the old templates folder as well as the new developed in #1456) so that we don't disturb existing users by breaking their installation.

Tested the new context configuration reader in the CLI.
All results are as expected.

With the new template structure (context.xml in template subfolders):
Successful generation
With the old template structure (context.xml in the root folder of all templates):
Successful generation
With both configurations (context.xml in root and subfolders):
Exception:

←[31m←[1mcom.devonfw.cobigen.api.exception.InvalidConfigurationException: C:\Users\jgunther\.cobigen\templates\CobiGen_Templates\src\main\templates\context.xml:
You are using an old configuration of the templates in addition to new ones. Please make sure this is not the case as both at the same time are not supported. For more details visit this wiki page: https://github.com/devonfw/cobigen/wiki/cobigen-core_configuration#update-old-config←[21m←[39m←[0m
←[3m    at com.devonfw.cobigen.impl.config.reader.ContextConfigurationReader.<init>(ContextConfigurationReader.java:91)←[23m←[0m
←[3m    at com.devonfw.cobigen.impl.config.ContextConfiguration.readConfiguration(ContextConfiguration.java:49)←[23m←[0m

With no context.xml:
Exception:

←[31m←[1mcom.devonfw.cobigen.api.exception.InvalidConfigurationException: C:\Users\jgunther\.cobigen\templates\CobiGen_Templates\src\main\templates\context.xml:
Could not find any context configuration file.←[21m←[39m←[0m
←[3m    at com.devonfw.cobigen.impl.config.reader.ContextConfigurationReader.<init>(ContextConfigurationReader.java:83)←[23m←[0m
←[3m    at com.devonfw.cobigen.impl.config.ContextConfiguration.readConfiguration(ContextConfiguration.java:49)←[23m←[0m
←[3m    at com.devonfw.cobigen.impl.config.ContextConfiguration.<init>(ContextConfiguration.java:38)←[23m←[0m


494 Edit Most Common Ports tooltip (CRASM-528)

Edited custom bar layer of graph to match MUI tooltip component used throughout app.

🗣 Description

Wrapped custom bar layer in a MUI Tooltip component.
Edited verbiage to be more clear and concise.

💭 Motivation and context

Closes #494
Closes CRASM-528

🧪 Testing

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

Are tool tips not subject to 508 compliance. Also you should think about removing the // TO-DO comment

I thought we were supposed to document To-Do's in the code?
And i'm pretty sure these tool-tips are 508 compliant.
A keyboard user will get the same info if they tab through it. The tool tip launches on focus.
The ariaLabel will catch the rest if the User is relying on a screen reader.


Simplify Makefile

There's some opportunity for code reuse in the Makefile.
@sakrejda let me know when you're done working on the Makefile for a bit and I'll work on this.

Just go for it, I don't have anything going now and I can monkey whatever
pattern you set up. K
On Mar 7, 2016 2:09 PM, "Allen Riddell"<EMAIL_ADDRESS>wrote:

There's some opportunity for code reuse in the Makefile.
@sakrejda https://github.com/sakrejda let me know when you're done
working on the Makefile for a bit and I'll work on this.
—
Reply to this email directly or view it on GitHub
https://github.com/sakrejda/protostan/issues/47.


Allow an inline code way to override rules

Something like a comment-based format to override rules.
Maybe ' bslint "rule-name": "severity"
As an example to turn off the rule no-print you would add the following comment:
' bslint "no-print": "off"

A new proposal that surfaced recently was to use conditional compilation constants as annotations for scoped blocks. For example
#const __suppress_wist_rule_name = true
function breakRuleHere() as Void
...
end function

#const __suppress_wist_rule_name = true
function anotherFunction() as Void
...
end function


Scope svelte-check properly and make it use the correct tsconfig.json

While investigating something else I noticed that this might be configured slightly incorrectly

Not sure what this does but your call ✅

It's typechecking our .svelte files (the ones used in tests). tsc itself is not capable of that


[FeatureRequest] add quick-setting tile for hiding files

Feature Description / 功能描述
Add a tile for android's drop down menu quick settings
Reason / 理由
i think it's handier than a persistent notification imo
Suggest Solution / 实现方案
obviously keep the two!

Hi @formula-spectre
We've already had a quick setting tile :D
Just click on the edit icon in the quick settings panel and check "Available toggles" - you'll find it there.

me blind apparently, apologies!


Support rolling back resources

Support rollback for resources. Make the ReadyBuffer not require its item to implement PartialEq. ReadyBuffer should only have one item per tick and so only the tick needs to be compared and not the item. Call App::add_resource_rollback<R>() to add rollback support for a resource.
Fixes https://github.com/cBournhonesque/lightyear/issues/585

This looks really good overall! I just left a couple comments

Thanks! the changes look great


UX: open input field for additional input when selecting Contribution>Other

Report from user from Loom: https://www.loom.com/share/7da7aae4aa9e4a9cb48965e73e61f1a6?sid=ef95c42e-f387-48c2-84d6-4a0d68334082

Hey team! Could you assign this to me? I can improve all the details described in the Loom video :)

Hey! I had been busy but managed to install and run the app, and wrote some updates for the README 01_setup.md setup guide. Should I open up an issue describing these changes?

On the other hand, I have questions regarding the input change.

What is the design pattern for the components in src/components/ui folder?
I have added a reference for the Select element (called selectRef) in line 173 of ApplicationForm.tsx and I am trying to use it to render the input for "OTHER" type dynamically, inserting this in line 182:

{select.current?.value === "OTHER" && (
  <FormControl required name={`contributionLinks.${i}.other`}>
    <Input placeholder="Specify other contribution type" />
  </FormControl>
  )}

However I'm getting selectRef.current as null even after selecting an option.
This could be answered if you answer question 1.


Enable container images

Pull Request Test Coverage Report for Build b93f2dd091e78206bd309e182b9dec4cf5f9a3e2-PR-10

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.381%

Totals

Change from base Build 625ece81de64bb33624b8ddca5a9abdfe9f182b0:
0.0%

Covered Lines:
101

Relevant Lines:
113

💛  - Coveralls


Added .delete() method to remove cookie from browser

Refer to Issue #13
This includes a test to verify both of my use cases:

remove key(s) inside of values that are objects by deleting the inner keys or setting them to undefined. This was already possible without the PR, but the test proves that.
instruct the browser to remove the cookie using both expires and max-age when using the added .delete() method

I didn't update the README, as I figured you would like to do that.

Updated README


Will not load

Starting about three days ago, the integration will no longer load. Log traceback:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/setup.py", line 256, in _async_setup_component
result = await task
File "/config/custom_components/o365/init.py", line 81, in async_setup
await _async_setup_account(hass, account, conf_type)
File "/config/custom_components/o365/init.py", line 168, in _async_setup_account
is_authenticated = account.is_authenticated
File "/usr/local/lib/python3.10/site-packages/O365/account.py", line 79, in is_authenticated
token = self.con.token_backend.get_token()
File "/usr/local/lib/python3.10/site-packages/O365/utils/token.py", line 94, in get_token
self.token = self.load_token()  # store the token in the 'token' property
File "/usr/local/lib/python3.10/site-packages/O365/utils/token.py", line 240, in load_token
token = self.token_constructor(self.serializer.load(token_file))
File "/usr/local/lib/python3.10/json/init.py", line 293, in load
return loads(fp.read(),
File "/usr/local/lib/python3.10/json/init.py", line 346, in loads
return _default_decoder.decode(s)
File "/usr/local/lib/python3.10/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/local/lib/python3.10/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

What version of Home Assistant are you using and what version of the O365 integration?
It looks like a problem with your token, which usually the easiest fix is to delete and re-authorise.

I'm using 2023.3.0 (now 2023.3.1) and the latest release of the integration. The error started a few weeks ago when we were still in the 2023.2s but I didn't think much of it and figured it would resolve on its own.
I'll try the reauthentication route and let you know how it goes.

My home assistant is:
Home Assistant 2023.3.2
Supervisor 2023.03.1
Operating System 9.5
Käyttöliittymän versio: 20230306.0 - latest
After the latest versions of home assistant and after configuring this integration again with the new way, it seems this integration looses its authentication almost in every reboot.
Clearing the token and reauthenticating works, but after next reboot these errors appear:
No token, or token doesn't have all required permissions; requesting authorization for account: Account1
Minimum required permissions not granted: ['Presence.Read', []]

Can you post the contents of the token with access and refresh token redacted. Is that the full error from the log?

Also, is your a personal account? Because you can’t use a status or chat sensor if it is. That error indicates that you either haven’t provided presence.read permission or it is a personal account.

No further information provided, so closing.


Linter-Flake8 executable path for Atom-Portable?

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Trying to setup portable Atom with Linter-Flake8 package but don't know portable Atom's package executable path?
Steps to Reproduce

Make Atom portable by moving .atom folder as explained in installation notes
Install Linter-Flake8 package
Package not working, instucted to update Executable path for package

Expected behavior: Linter-Flake8 should show errors in python code OR complain that package is not found
Actual behavior: Absolutely nothing...
Versions
Atom V. 1.14.1
Windows (mainly 8 and 10, but it shouldn't matter)

Question found to be incorrect as issue was with flake8's install and not setups inside of atom.


Consider moving to local jekyll builds

This will let us use plugins.
https://github.com/stereobooster/jekyll-press

Or use Travis-CI to build and deploy... this might be the smartest option...


Sidebar menu adjustments

Extend clickable area of 'My account' link to full width when user is not logged in

Change arrow tag from span to button and extend clickable area (50% for link and 50% for arrow will be good)

Change tags of top icons to button

@Aekal I've just assigned this one to you :)


DO NOT MERGE: Test verify codeclimate fails linting errors

JUST A TEST, DO NOT MERGE

This was only test.
It worked.  CodeClimate correctly detected the intentional linting error.


[BUG] clone! loses closure arguments span information, leading to poor diagnostics

Bug description
If you provide a closure to the clone! macro that takes the wrong number of arguments, you'll get a diagnostic like this:
error[E0593]: closure is expected to take 4 arguments, but it takes 0 arguments
   --> src/places_sidebar.rs:301:25
    |
301 |               drop_target.connect_drop(clone!(@weak item => move || {
    |  _________________________^^^^^^^^^^^^_-
    | |                         |
    | |                         expected closure that takes 4 arguments
302 | |             }));
    | |______________- takes 0 arguments
    |
help: consider changing the closure to take and ignore the expected arguments
    |
301 |             drop_target.connect_drop(|_, _, _, _|);
    |

This is because rustc is unable to determine the span of the closure arguments, so it falls back to the span of the entire closure. I believe we should be able to thread the correct span back to rustc if we emit the expanded closure arguments with the same span as the original closure. That would lead to a diagnostic like this:
error[E0593]: closure is expected to take 4 arguments, but it takes 0 arguments
   --> src/places_sidebar.rs:301:25
    |
301 |               drop_target.connect_drop(clone!(@weak item => move || {
    |                           ^^^^^^^^^^^^                           -- takes 0 arguments
    |                           |
    |                           expected closure that takes 4 arguments
302 |               }));
    |
    |
help: consider changing the closure to take and ignore the expected arguments
    |
301 |             drop_target.connect_drop(|_, _, _, _|);
    |

Backtrace
N/A

The whole macro needs to have its error reporting fixed, there are a lot of places where it does panic instead of properly erroring out with a span

CC @GuillaumeGomez

Fixing.

I think https://github.com/gtk-rs/gtk-rs-core/pull/963 should make everyone happy with the new error output.


spec/p2p: Document reactors and the Reactor interface

Reactor is the generic name for a component that interacts with the p2p communication layer.
The interaction between a reactor and the p2p layer is in both directions. To become a reactor, the component has to implement the p2p.Reactor interface and register with the p2p layer. The p2p layer invokes invokes the reactor to process relevant events, for instance, to deliver incoming messages and to inform when it has established connections to peers. The reactor invokes the p2p layer to send message to peers and to control its operation, for instance, for disconnecting from a peer.
Definition of Done
This interaction is relatively complex and needs to be properly documented:

[x] #714

Improve the documentation of the p2p.Reactor interface methods
Describe the interaction p2p layer <-> Reactor using a Grammar
Model and formalize the operation of a Reactor using Quint

[x] #758

Perhaps in this work, we could figure out how reactor-survey.md can be incorporated into the specifications. This document discusses how we can think about the system-level requirements that translate into requirements for p2p. The rest of #80 is less relevant for this issue, and we don't need to merge them soon, so we may close the PR once we have added the survey.

Perhaps in this work, we could figure out how reactor-survey.md can be incorporated into the specifications. This document discusses how we can think about the system-level requirements that translate into requirements for p2p. The rest of #80 is less relevant for this issue, and we don't need to merge them soon, so we may close the PR once we have added the survey.

https://github.com/cometbft/cometbft/issues/598#issuecomment-1594508348


Generate affiliate rover links

Would be nice to have a simple method or property that contains an ebay affiliate rover link
Here's is the  manual link generator tool all it needs is a product id input:
https://epn.ebay.com/tools/link-generator
also found this...looks like there is an endpoint to generate an affiliate link?
http://developer.ebay.com/devzone/guides/ebayfeatures/Basics/eBay-AffiliateTrackingConcepts.html

Any update on this?


Config map updates are not picked up by controller without bouncing the controller

Pre-requisites

[X] I have double-checked my configuration
[X] I can confirm the issues exists when I tested with :latest
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?
I updated the config map parallelism setting, but the changes were not reflected until I redeployed the controller. Auto config map read was added as a feature in the past. Look at this issue. But looks like the feature was removed as part of this refactor commit.
Version
latest
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: hello-world-
spec:
  entrypoint: whalesay
  templates:
    - name: whalesay
      container:
        image: docker/whalesay
        command: [ cowsay ]
        args: [ "hello world" ]
        resources:
          limits:
            memory: 32Mi
            cpu: 100m

Logs from the workflow controller
//

Logs from in your workflow's wait container
kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

//

I use https://github.com/stakater/Reloader


Feature Request - Add copy-tags support from EBS volumes to Snapshots

This is supported already here:

EC2 -> snapshots
EC2 -> EBS Volumes

For example:
policies:
  - name: ec2-snapshots
    resource: ec2
  actions:
    - type: snapshot
      copy-tags:
        - Name

This feature request would allow ebs volumes to copy their tags to their snapshots upon deletion.
For example:
policies:
- name: ebs-snapshot
  resource: ebs
  comments: |
    Snapshot and ebs volumes that have reached the 30 day mark.
  filters:
    - type: marked-for-op
      tag: orphaned
      op: snapshot
  actions:
    - type: snapshot
      copy-tags:
        - Name

Thanks for the feature request, this is a duplicate of https://github.com/capitalone/cloud-custodian/issues/2497, closing


embed-go: Avoid creation of empty files if no boxes found

Moving check for empty boxes set a bit earlier, to avoid creating
an invalid rice-box.go file (an empty one) that makes next rice invokation fails.

Tihs feature has been implemented in #101


Taura - The background should be visible now

Changes / Comments
The background of the character sheet was not showing on the application. The css change should fix that.
Plus, the html elements ,  and  where removed from the html file.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[x] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

When you say "should be visible now", does that imply you have or haven't tried out the proposed changes inside Roll20, using a the code applied in a custom character mode?

Hi, @Anduh
I have tested everything but the image. I don't know how to upload image in the pro account editor in Roll20

Hi, @Anduh
I have tested everything but the image. I don't know how to upload image in the pro account editor in Roll20

You don't upload images into the editor, you directly reference the image location on github.
See one of my latest PR for a functioning way of showing images.
I'll also point out that currently you're using the background image as a "sheet preview image", where the sheet preview should be a real representation of how the sheet looks like. After you've changed the background-image url, you should be able to get the sheet look as it should, after which you can take a screenshot of how it looks and use the new image for the "preview" image in the sheet.json.

Ok, I'll close the pull request and do se. Thanks!


add application/vnd.microsoft.portable-executable and application/x-dosexec

Description
When using File Libraries,
$file->getMimeType(); returns null in files with extension .exe
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[ ] Conforms to style guide

https://www.iana.org/assignments/media-types/application/vnd.microsoft.portable-executable

The first MIME type is IANA recognized. However, the second one I cannot find. Is it acceptable?

Thank you @totoprayogo1916


introduce the stm32h7rs serie

This PR is introducing the new stm32h7RS serie from STMicroelectronics
https://www.st.com/en/microcontrollers-microprocessors/stm32h7r7-7s7.html
Based on the stm32H7 with 64KB of internal Flash memory and  Arm Cortex-M7 MCU
Requires https://github.com/zephyrproject-rtos/hal_stm32/pull/200
The stm32h7s78_dk is the disco kit with a external   1‑Gbit Octo‑SPI NOR flash memory (MX66uw1g45)

rebase including the hal_stm32 05ee82ff431deefc32322cccf112b9b6aff4aec6

CI failure due to missing hal_stm32 missing the stm32h7rs serie

Please remove the last commit ....

Please remove the last commit ....

removed

Taking assignment as @galak is not much active these days.


Feature/GitHub default

[1.3.1] - 2024-10-30
Added

Guide explaining how to set up Workload Identity Federation for AutoMLOps
Created new docs/ directory

Changed

Made github and github-actions the default options for source_repo_type and deployment_framework respectively
Updated example notebooks so that they are set to use_ci=False by default
Provided samples in the example notebooks that demonstrate how to use the github and github_actions setup
Added a guide for setting up Workload Identity Federation
Updated github actions op versions (checkout and auth)

Fixed

Fixed broken default of now deprecated Cloud Source Repositories
Updated sklearn version of training example00 to use v1.3
Removed build_trigger_location from resources manifest output

Looked over guide, gtg


Lab 1: Yihan Wang, Worked with Xiayu Zeng

https://github.com/WenyuWang1/ese5190-2022-lab1-firefly-1.git


Feedback for “Migrations” page of docs

On https://orm.drizzle.team/docs/migrations
import { index, integer, mysqlTable, bigint, varchar } from 'drizzle-orm/mysql-core';
should be
import { index, int, mysqlTable, bigint, varchar } from 'drizzle-orm/mysql-core';

Hello @goldjacobe. Thank you, it was fixed


Weird Polymer Catalog Bug (Md) -- "paper-toast"

Dear Sirs,
It seems I found a bug in Polymer Catalog. To reproduce, please follow these steps:

Open polymer catalog: https://elements.polymer-project.org/
Choose Md (Paper Elements)
From paper elements select paper-button; switch to demo in left pane
Select "paper-toast" from "other elements"
Now, select any other element, e.g. "paper-menu" -- "paper-toast" disappears from elements catalog.

More weird behavior:

Repeat steps 1-4 above
Now, select "paper-toggle-button"
Now, again select "paper-toast" -- "paper-toggle-button" disappears!
You can toggle between "paper-toast" and "paper-toggle-button" by clicking "paper-toast" element.

Best regards!

I think this is a feature. It actually makes sense to remove an element from the other elements list upon being selected.

@francisbrito, did you try to reproduce this? This bug is not about selected element removed from other elements list.

@bakirov, I see. I misread your report. Following the steps described above works as expected for me: selected element is hidden from the "other elements" list, unselected elements are shown.
Could this be a browser related issue? I tested on Chrome 43 for Linux.

Uploading a screenshot of a behavior.
I use a Chrome version 43.0.2357.81 m on Windows 7 (64-bit).

Hmm, in Chrome Incognito and in Firefox everything is OK.

@bakirov We were unable to reproduce the double paper-tabs in your last screenshot.
As far as we can tell, your earlier description of the currently selected item being removed from the "other elements" when selected list is by design, as @francisbrito suggested.
Can you try and provide any additional information that might help us reproduce the double paper-tabs issue?

auto-moving this issue to Polymer/polymer-element-catalog#101 and closing this one


python3Packages.MDP: reenable tests

Motivation for this change
Tests were disabled years ago by 140136ad956 (mdp: disable tests, 2017-09-14) because of missing dependencies that are not in nixpkgs, but current version 3.6 prints a warning and run the tests just fine.
============================= test session starts ==============================
platform darwin -- Python 3.9.6, pytest-6.2.5, py-1.10.0, pluggy-1.0.0
          python: 3.9.6.final.0
             mdp: 3.6
 parallel python: NOT AVAILABLE: No module named 'pp'
          shogun: NOT AVAILABLE: No module named 'shogun'
          libsvm: NOT AVAILABLE: No module named 'libsvm'
          joblib: NOT AVAILABLE: No module named 'joblib'
         sklearn: NOT AVAILABLE: No module named 'scikits'
            numx: numpy 1.21.2
          symeig: symeig_fake
Random Seed: 7710873

Things done
Add a custom checkPhase to run pytest.

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[X] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 140516 at 30453bbf run on aarch64-linux 1

2 packages built successfully:

python38Packages.MDP
python39Packages.MDP


Weight_converter

Describe the bug
In the project Weight_converter (https://github.com/TusharKesarwani/Front-End-Projects/tree/main/Projects/Weight_converter)
when the input is a negative number then also it is converting it into other units.
Expected behavior
When a negative number is given as input a message should be displayed "Enter a positive number".
Screenshots

@TusharKesarwani @zugzwang03 @harshit-paneri Please assign this issue to me under SSOC 2.0

#460


Build the SSL context with jre key store to back up the KeyVaultKeyStore's own functions.

KeyVaultKeyStore is used to build TLS connection, but KeyVaultKeyStore itself is a remote key store so itself needs TLS to back up its own function. Then here is a dead loop. To cease this dead loop, we need build the SSL context with jre key store to back up the KeyVaultKeyStore's own functions.

Fixes #23591


Revert "Wait file closed before unmount fuse"

This reverts commit 8f618358891ca89f753b369316d58221e8fb9b74 to stablize tests

alluxio-bot, merge this please


Level 3

Same amount of food objective as level 2
Random obstacles instead of blocking surrounding

synced using issuesync
used to create 65 found at https://api.github.com/repos/ChristosHadjigeorghiou1996/djangodiscord/issues/65

synced using issuesync
used to create 66 found at https://api.github.com/repos/ChristosHadjigeorghiou1996/djangodiscord/issues/66

synced using issuesync
used to create 67 found at https://api.github.com/repos/ChristosHadjigeorghiou1996/djangodiscord/issues/67

synced using issuesync
used to create 68 found at https://github.com/ChristosHadjigeorghiou1996/djangodiscord/issues/68

synced using issuesync
used to create 71 found at https://github.com/ChristosHadjigeorghiou1996/djangodiscord/issues/71

synced using issuesync
used to create 72 found at https://github.com/ChristosHadjigeorghiou1996/djangodiscord/issues/72


Continue Self hosting

Same as history file.
the cluster id cache chile can now be a a .ost collection file with 2 clusters. a user_id cluster and a cluster_id cluster
this will make it easier to delete user and cluster ids after they are no longer needed.
configs can also be stored in a .ost file.

Configs now self hosted in: e840444da4ddce074d95b7b66745516e9382ab22

IDs now self hosted!

Completed in: 287917c38f2b0def1311e1839a5b8c67b97b183c


Cleanup trailing whitespace

I know some programmers don't care much about this, but trailing whitespace really bugs me. Even in languages where it doesn't make any semantic difference it just gets in the way when you're copying stuff around and clutters up diffs when you got to review. As I started poking around the code I started to run into quite a few instances.
Rather than clean it up on a case by case basis I find it best to do it all at once. This way little fixes here and there don't end up creeping into future diffs and cluttering up the code review process. Also by batching them you easily verify this whole PR shouldn't break anything by running git diff --ignore-all-space alerque/feature/normalize-whitespace...master.
I split this into two commits because one of them touches files that were clearly automatically processed. By having that set in a separate commit they could be reverted in order to get a clean comparison if that set was ever re-imported. Just makes the potential git magic that much easier to do.

Thank you very much!


[Bug]: Visual of the browse sessions card

What happened?
I think that the margins should be equal between all cards, becuase it doesn't look great if they cards are above each other with different starting margin...
How to reproduce the bug
When you look at the margins at the top of different cards it seems messy to me...

Package Version
1.0.19
PHP Version
8.2.0
Laravel Version
11.11.0
Which operating systems does with happen with?
Windows
Notes
No response

If you'll agree with me, I think it should be easy to fix with removing highlighted text: https://github.com/joaopaulolndev/filament-edit-profile/blob/e7e37650f06929dbbb7fe6c904c2da9cb96853f5/resources/views/forms/components/browser-sessions.blade.php#L7C25-L7C29

Hi @Grolicek , thanks for this help.
Already fixed, please update the package.


how to rename extension.

'title' => 'array('{{timestamp}}')', //New file name
how to use custom extension. such as .jpg

You can't :(. What you can do is to rename the file after uploading.


How to add SerialNumber as Subject alternative Name in Bouncy Castle

I am trying to add SerialNumber and UID as SAN but don't know how to add it, I am trying this code but it gives me error:
 GeneralName name1 = new GeneralName(GeneralName.DnsName, "bc1.local");
 GeneralName name2 = new GeneralName(X509Name.SerialNumber, "1234567890");
 GeneralName name3 = new GeneralName(X509Name.UID, "123456789123456");

 certGen.AddExtension(X509Extensions.SubjectAlternativeName, false,  name1,name2,name3);

the error I got it Argument 'number' cannot convert from string to int and I want it to be as string to add it in CSR.

It is necessary to use constructor with X509Name.
var oids = new List<DerObjectIdentifier>(){X509Name.SerialNumber,X509Name.UID   };
var values = new List<string>() { "1234567890", "123456789123456" };

 GeneralName name1 = new GeneralName(GeneralName.DnsName, "bc1.local");
 GeneralName name2 = new GeneralName(new X509Name(oids, values));

 certGen.AddExtension(X509Extensions.SubjectAlternativeName, false,  name1,name2);


Tests with an actual browser

We might be able to test some stuff relatively easily as we have a high degree of control in the browser through ther websocket connection
Selenium
https://github.com/pytest-dev/pytest-splinter
Saucelabs
that other CI service who's name I forgot

Any CI service with browser + webdriver installed should be compatible, e.g. Codeship :)

After more reading I'm starting to like pytest-selenium as well... it apparently supports headless browsers as well.
http://pytest-selenium.readthedocs.io/en/latest/user_guide.html#quick-start

Related to #12

We do have app/tests/test_live.py that tests using XUL (firefox) on CI. The discussion continues in #210.


#define vkGetPhysicalDeviceSurfaceCapabilitiesKHR glad_vkGetPhysicalDeviceSurfaceCapabilitiesKHR
                                                  ^
./glad/vulkan.h:3415:61: note: previous definition is here
GLAD_API_CALL PFN_vkGetPhysicalDeviceSurfaceCapabilitiesKHR glad_vkGetPhysicalDeviceSurfaceCapabilitiesKHR;
                                                            ^
In file included from ../vk_wrapper.go:6:
./vk_wrapper.h:480:10: error: redefinition of 'glad_vkGetPhysicalDeviceSurfaceFormatsKHR' as different kind of symbol
VkResult vkGetPhysicalDeviceSurfaceFormatsKHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, uint32_t* pSurfaceFormatCount, VkSurfaceFormatKHR* pSurfaceFormats);
         ^
./glad/vulkan.h:3418:46: note: expanded from macro 'vkGetPhysicalDeviceSurfaceFormatsKHR'
#define vkGetPhysicalDeviceSurfaceFormatsKHR glad_vkGetPhysicalDeviceSurfaceFormatsKHR
                                             ^
./glad/vulkan.h:3417:56: note: previous definition is here
GLAD_API_CALL PFN_vkGetPhysicalDeviceSurfaceFormatsKHR glad_vkGetPhysicalDeviceSurfaceFormatsKHR;
                                                       ^
In file included from ../vk_wrapper.go:6:
./vk_wrapper.h:481:10: error: redefinition of 'glad_vkGetPhysicalDeviceSurfacePresentModesKHR' as different kind of symbol
VkResult vkGetPhysicalDeviceSurfacePresentModesKHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, uint32_t* pPresentModeCount, VkPresentModeKHR* pPresentModes);
         ^
./glad/vulkan.h:3420:51: note: expanded from macro 'vkGetPhysicalDeviceSurfacePresentModesKHR'
#define vkGetPhysicalDeviceSurfacePresentModesKHR glad_vkGetPhysicalDeviceSurfacePresentModesKHR
                                                  ^
./glad/vulkan.h:3419:61: note: previous definition is here
GLAD_API_CALL PFN_vkGetPhysicalDeviceSurfacePresentModesKHR glad_vkGetPhysicalDeviceSurfacePresentModesKHR;
                                                            ^
In file included from ../vk_wrapper.go:6:
./vk_wrapper.h:482:10: error: redefinition of 'glad_vkGetPhysicalDevicePresentRectanglesKHR' as different kind of symbol
VkResult vkGetPhysicalDevicePresentRectanglesKHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, uint32_t* pRectCount, VkRect2D* pRects);
         ^
./glad/vulkan.h:3402:49: note: expanded from macro 'vkGetPhysicalDevicePresentRectanglesKHR'
#define vkGetPhysicalDevicePresentRectanglesKHR glad_vkGetPhysicalDevicePresentRectanglesKHR
                                                ^
./glad/vulkan.h:3401:59: note: previous definition is here
GLAD_API_CALL PFN_vkGetPhysicalDevicePresentRectanglesKHR glad_vkGetPhysicalDevicePresentRectanglesKHR;
                                                          ^
In file included from ../vk_wrapper.go:6:
./vk_wrapper.h:483:10: error: redefinition of 'glad_vkAcquireNextImage2KHR' as different kind of symbol
VkResult vkAcquireNextImage2KHR(vksProcAddr* addrs, VkDevice device, VkAcquireNextImageInfoKHR* pAcquireInfo, uint32_t* pImageIndex);
         ^
./glad/vulkan.h:3104:32: note: expanded from macro 'vkAcquireNextImage2KHR'
#define vkAcquireNextImage2KHR glad_vkAcquireNextImage2KHR
                               ^
./glad/vulkan.h:3103:42: note: previous definition is here
GLAD_API_CALL PFN_vkAcquireNextImage2KHR glad_vkAcquireNextImage2KHR;
                                         ^
In file included from ../vk_wrapper.go:6:
./vk_wrapper.h:484:10: error: redefinition of 'glad_vkGetDeviceGroupSurfacePresentModesKHR' as different kind of symbol
VkResult vkGetDeviceGroupSurfacePresentModesKHR(vksProcAddr* addrs, VkDevice device, VkSurfaceKHR surface, VkDeviceGroupPresentModeFlagsKHR* pModes);
         ^
./glad/vulkan.h:3354:48: note: expanded from macro 'vkGetDeviceGroupSurfacePresentModesKHR'
#define vkGetDeviceGroupSurfacePresentModesKHR glad_vkGetDeviceGroupSurfacePresentModesKHR
                                               ^
./glad/vulkan.h:3353:58: note: previous definition is here
GLAD_API_CALL PFN_vkGetDeviceGroupSurfacePresentModesKHR glad_vkGetDeviceGroupSurfacePresentModesKHR;
                                                         ^
In file included from ../vk_wrapper.go:6:
./vk_wrapper.h:485:10: error: redefinition of 'glad_vkGetDeviceGroupPresentCapabilitiesKHR' as different kind of symbol
VkResult vkGetDeviceGroupPresentCapabilitiesKHR(vksProcAddr* addrs, VkDevice device, VkDeviceGroupPresentCapabilitiesKHR* pDeviceGroupPresentCapabilities);
         ^
./glad/vulkan.h:3352:48: note: expanded from macro 'vkGetDeviceGroupPresentCapabilitiesKHR'
#define vkGetDeviceGroupPresentCapabilitiesKHR glad_vkGetDeviceGroupPresentCapabilitiesKHR
                                               ^
./glad/vulkan.h:3351:58: note: previous definition is here
GLAD_API_CALL PFN_vkGetDeviceGroupPresentCapabilitiesKHR glad_vkGetDeviceGroupPresentCapabilitiesKHR;
                                                         ^
In file included from ../vk_wrapper.go:6:
./vk_wrapper.h:486:10: error: redefinition of 'glad_vkQueuePresentKHR' as different kind of symbol
VkResult vkQueuePresentKHR(vksProcAddr* addrs, VkQueue queue, VkPresentInfoKHR* pPresentInfo);
         ^
./glad/vulkan.h:3440:27: note: expanded from macro 'vkQueuePresentKHR'
#define vkQueuePresentKHR glad_vkQueuePresentKHR
                          ^
./glad/vulkan.h:3439:37: note: previous definition is here
GLAD_API_CALL PFN_vkQueuePresentKHR glad_vkQueuePresentKHR;
                                    ^
In file included from ../vk_wrapper.go:6:
./vk_wrapper.h:487:10: error: redefinition of 'glad_vkAcquireNextImageKHR' as different kind of symbol
VkResult vkAcquireNextImageKHR(vksProcAddr* addrs, VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, VkSemaphore semaphore, VkFence fence, uint32_t* pImageIndex);
         ^
./glad/vulkan.h:3106:31: note: expanded from macro 'vkAcquireNextImageKHR'
#define vkAcquireNextImageKHR glad_vkAcquireNextImageKHR
                              ^
./glad/vulkan.h:3105:41: note: previous definition is here
GLAD_API_CALL PFN_vkAcquireNextImageKHR glad_vkAcquireNextImageKHR;
                                        ^
In file included from ../vk_wrapper.go:6:
./vk_wrapper.h:488:10: error: redefinition of 'glad_vkGetSwapchainImagesKHR' as different kind of symbol
VkResult vkGetSwapchainImagesKHR(vksProcAddr* addrs, VkDevice device, VkSwapchainKHR swapchain, uint32_t* pSwapchainImageCount, VkImage* pSwapchainImages);
         ^
./glad/vulkan.h:3430:33: note: expanded from macro 'vkGetSwapchainImagesKHR'
#define vkGetSwapchainImagesKHR glad_vkGetSwapchainImagesKHR
                                ^
./glad/vulkan.h:3429:43: note: previous definition is here
GLAD_API_CALL PFN_vkGetSwapchainImagesKHR glad_vkGetSwapchainImagesKHR;
                                          ^
In file included from ../vk_wrapper.go:6:
./vk_wrapper.h:489:6: error: redefinition of 'glad_vkDestroySwapchainKHR' as different kind of symbol
void vkDestroySwapchainKHR(vksProcAddr* addrs, VkDevice device, VkSwapchainKHR swapchain, VkAllocationCallbacks* pAllocator);
     ^
./glad/vulkan.h:3316:31: note: expanded from macro 'vkDestroySwapchainKHR'
#define vkDestroySwapchainKHR glad_vkDestroySwapchainKHR
                              ^
./glad/vulkan.h:3315:41: note: previous definition is here
GLAD_API_CALL PFN_vkDestroySwapchainKHR glad_vkDestroySwapchainKHR;
                                        ^
In file included from ../vk_wrapper.go:6:
./vk_wrapper.h:490:10: error: redefinition of 'glad_vkCreateSwapchainKHR' as different kind of symbol
VkResult vkCreateSwapchainKHR(vksProcAddr* addrs, VkDevice device, VkSwapchainCreateInfoKHR* pCreateInfo, VkAllocationCallbacks* pAllocator, VkSwapchainKHR* pSwapchain);
         ^
./glad/vulkan.h:3264:30: note: expanded from macro 'vkCreateSwapchainKHR'
#define vkCreateSwapchainKHR glad_vkCreateSwapchainKHR
                             ^
./glad/vulkan.h:3263:40: note: previous definition is here
GLAD_API_CALL PFN_vkCreateSwapchainKHR glad_vkCreateSwapchainKHR;
                                       ^
In file included from ../vk_wrapper.go:6:
./vk_wrapper.h:491:82: error: unknown type name 'VkDisplaySurfaceCreateInfoKHR'
VkResult vkCreateDisplayPlaneSurfaceKHR(vksProcAddr* addrs, VkInstance instance, VkDisplaySurfaceCreateInfoKHR* pCreateInfo, VkAllocationCallbacks* pAllocator, VkSurfaceKHR* pSurface);
                                                                                ^
./vk_wrapper.h:492:96: error: unknown type name 'VkDisplayModeKHR'
VkResult vkGetDisplayPlaneCapabilitiesKHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, VkDisplayModeKHR mode, uint32_t planeIndex, VkDisplayPlaneCapabilitiesKHR* pCapabilities);
                                                                                ^
./vk_wrapper.h:492:140: error: unknown type name 'VkDisplayPlaneCapabilitiesKHR'
VkResult vkGetDisplayPlaneCapabilitiesKHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, VkDisplayModeKHR mode, uint32_t planeIndex, VkDisplayPlaneCapabilitiesKHR* pCapabilities);
                                                                                ^
./vk_wrapper.h:493:86: error: unknown type name 'VkDisplayKHR'
VkResult vkCreateDisplayModeKHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, VkDisplayKHR display, VkDisplayModeCreateInfoKHR* pCreateInfo, VkAllocationCallbacks* pAllocator, VkDisplayModeKHR* pMode);
                                                                                ^
./vk_wrapper.h:493:108: error: unknown type name 'VkDisplayModeCreateInfoKHR'
VkResult vkCreateDisplayModeKHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, VkDisplayKHR display, VkDisplayModeCreateInfoKHR* pCreateInfo, VkAllocationCallbacks* pAllocator, VkDisplayModeKHR* pMode);
                                                                                ^
./vk_wrapper.h:493:184: error: unknown type name 'VkDisplayModeKHR'
VkResult vkCreateDisplayModeKHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, VkDisplayKHR display, VkDisplayModeCreateInfoKHR* pCreateInfo, VkAllocationCallbacks* pAllocator, VkDisplayModeKHR* pMode);
                                                                                ^
./vk_wrapper.h:494:93: error: unknown type name 'VkDisplayKHR'
VkResult vkGetDisplayModePropertiesKHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, VkDisplayKHR display, uint32_t* pPropertyCount, VkDisplayModePropertiesKHR* pProperties);
                                                                                ^
./vk_wrapper.h:494:141: error: unknown type name 'VkDisplayModePropertiesKHR'
VkResult vkGetDisplayModePropertiesKHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, VkDisplayKHR display, uint32_t* pPropertyCount, VkDisplayModePropertiesKHR* pProperties);
                                                                                ^
./vk_wrapper.h:495:147: error: unknown type name 'VkDisplayKHR'
VkResult vkGetDisplayPlaneSupportedDisplaysKHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, uint32_t planeIndex, uint32_t* pDisplayCount, VkDisplayKHR* pDisplays);
                                                                                ^
./vk_wrapper.h:496:134: error: unknown type name 'VkDisplayPlanePropertiesKHR'
VkResult vkGetPhysicalDeviceDisplayPlanePropertiesKHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, uint32_t* pPropertyCount, VkDisplayPlanePropertiesKHR* pProperties);
                                                                                ^
./vk_wrapper.h:497:129: error: unknown type name 'VkDisplayPropertiesKHR'
VkResult vkGetPhysicalDeviceDisplayPropertiesKHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, uint32_t* pPropertyCount, VkDisplayPropertiesKHR* pProperties);
                                                                                ^
./vk_wrapper.h:498:97: error: unknown type name 'VkDisplayPlaneInfo2KHR'
VkResult vkGetDisplayPlaneCapabilities2KHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, VkDisplayPlaneInfo2KHR* pDisplayPlaneInfo, VkDisplayPlaneCapabilities2KHR* pCapabilities);
                                                                                ^
./vk_wrapper.h:498:140: error: unknown type name 'VkDisplayPlaneCapabilities2KHR'
VkResult vkGetDisplayPlaneCapabilities2KHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, VkDisplayPlaneInfo2KHR* pDisplayPlaneInfo, VkDisplayPlaneCapabilities2KHR* pCapabilities);
                                                                                ^
./vk_wrapper.h:499:130: error: unknown type name 'VkDisplayProperties2KHR'
VkResult vkGetPhysicalDeviceDisplayProperties2KHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, uint32_t* pPropertyCount, VkDisplayProperties2KHR* pProperties);
                                                                                ^
./vk_wrapper.h:500:135: error: unknown type name 'VkDisplayPlaneProperties2KHR'
VkResult vkGetPhysicalDeviceDisplayPlaneProperties2KHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, uint32_t* pPropertyCount, VkDisplayPlaneProperties2KHR* pProperties);
                                                                                ^
./vk_wrapper.h:501:94: error: unknown type name 'VkDisplayKHR'
VkResult vkGetDisplayModeProperties2KHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, VkDisplayKHR display, uint32_t* pPropertyCount, VkDisplayModeProperties2KHR* pProperties);
                                                                                ^
./vk_wrapper.h:501:142: error: unknown type name 'VkDisplayModeProperties2KHR'
VkResult vkGetDisplayModeProperties2KHR(vksProcAddr* addrs, VkPhysicalDevice physicalDevice, VkDisplayKHR display, uint32_t* pPropertyCount, VkDisplayModeProperties2KHR* pProperties);
                                                                                ^
233 errors generated.

I added a glad folder to the repo and now I get
Long Error

Did you list all those extensions in vkxml.yml before running header-generator?

I tried to fix all these in my fork, and run export DYLD_LIBRARY_PATH="/usr/local/lib" before running the Go command, but now I get
dyld: Symbol not found: _mecab_get_feature
  Referenced from: /System/Library/PrivateFrameworks/CoreNLP.framework/Versions/A/CoreNLP
  Expected in: /usr/local/lib/libmecab.dylib
 in /System/Library/PrivateFrameworks/CoreNLP.framework/Versions/A/CoreNLP
Abort trap: 6

Are you using Vulkan for Natural Language Processing? This is a very interesting use of Vulkan. Or does NLP mean something else?

For your repo I'm getting
./vk_wrapper.h:7:10: fatal error: 'vulkan/vulkan.h' file not found
#include <vulkan/vulkan.h>
         ^~~~~~~~~~~~~~~~~
1 error generated.

Am I missing something?

Have you installed Vulkan SDK?

Yes

I added a glad folder to the repo and now I get
Long Error

Did you list all those extensions in vkxml.yml before running header-generator?

I didn't run a header generator, I used your fork with the glad folder added

I tried to fix all these in my fork, and run export DYLD_LIBRARY_PATH="/usr/local/lib" before running the Go command, but now I get
dyld: Symbol not found: _mecab_get_feature
  Referenced from: /System/Library/PrivateFrameworks/CoreNLP.framework/Versions/A/CoreNLP
  Expected in: /usr/local/lib/libmecab.dylib
 in /System/Library/PrivateFrameworks/CoreNLP.framework/Versions/A/CoreNLP
Abort trap: 6

Are you using Vulkan for Natural Language Processing? This is a very interesting use of Vulkan. Or does NLP mean something else?

I'm not sure what CoreNLP is, but I am just using the vulkan example program + some modifications to your fork (nothing that involves CoreNLP). I was hoping you would know more about what is causing this error

For your repo I'm getting
./vk_wrapper.h:7:10: fatal error: 'vulkan/vulkan.h' file not found
#include <vulkan/vulkan.h>
         ^~~~~~~~~~~~~~~~~
1 error generated.

Am I missing something?

Have you installed Vulkan SDK?

Yes

Where is the SDK installed? In some custom directory or in the directory of the operating system with all other include files?

I added a glad folder to the repo and now I get
Long Error

Did you list all those extensions in vkxml.yml before running header-generator?

I didn't run a header generator, I used your fork with the glad folder added

I don't have a glad folder in my repository.

I tried to fix all these in my fork, and run export DYLD_LIBRARY_PATH="/usr/local/lib" before running the Go command, but now I get
dyld: Symbol not found: _mecab_get_feature
  Referenced from: /System/Library/PrivateFrameworks/CoreNLP.framework/Versions/A/CoreNLP
  Expected in: /usr/local/lib/libmecab.dylib
 in /System/Library/PrivateFrameworks/CoreNLP.framework/Versions/A/CoreNLP
Abort trap: 6

Are you using Vulkan for Natural Language Processing? This is a very interesting use of Vulkan. Or does NLP mean something else?

I'm not sure what CoreNLP is, but I am just using the vulkan example program + some modifications to your fork (nothing that involves CoreNLP). I was hoping you would know more about what is causing this error

I think that this problem is not related to this project in any way.

For your repo I'm getting
./vk_wrapper.h:7:10: fatal error: 'vulkan/vulkan.h' file not found
#include <vulkan/vulkan.h>
         ^~~~~~~~~~~~~~~~~
1 error generated.

Am I missing something?

Have you installed Vulkan SDK?

Yes

Where is the SDK installed? In some custom directory or in the directory of the operating system with all other include files?

It was in my /usr/local/include but I added that to the search path and this error went away

I tried to fix all these in my fork, and run export DYLD_LIBRARY_PATH="/usr/local/lib" before running the Go command, but now I get
dyld: Symbol not found: _mecab_get_feature
  Referenced from: /System/Library/PrivateFrameworks/CoreNLP.framework/Versions/A/CoreNLP
  Expected in: /usr/local/lib/libmecab.dylib
 in /System/Library/PrivateFrameworks/CoreNLP.framework/Versions/A/CoreNLP
Abort trap: 6

Are you using Vulkan for Natural Language Processing? This is a very interesting use of Vulkan. Or does NLP mean something else?

I'm not sure what CoreNLP is, but I am just using the vulkan example program + some modifications to your fork (nothing that involves CoreNLP). I was hoping you would know more about what is causing this error

I think that this problem is not related to this project in any way.

Its just that this is the error I'm getting now and I can't figure out how to fix it

I tried to fix all these in my fork, and run export DYLD_LIBRARY_PATH="/usr/local/lib" before running the Go command, but now I get
dyld: Symbol not found: _mecab_get_feature
  Referenced from: /System/Library/PrivateFrameworks/CoreNLP.framework/Versions/A/CoreNLP
  Expected in: /usr/local/lib/libmecab.dylib
 in /System/Library/PrivateFrameworks/CoreNLP.framework/Versions/A/CoreNLP
Abort trap: 6

Are you using Vulkan for Natural Language Processing? This is a very interesting use of Vulkan. Or does NLP mean something else?

I'm not sure what CoreNLP is, but I am just using the vulkan example program + some modifications to your fork (nothing that involves CoreNLP). I was hoping you would know more about what is causing this error

I think that this problem is not related to this project in any way.

Its just that this is the error I'm getting now and I can't figure out how to fix it

What version of macOS are you using? What do you use CoreNLP for? Can you uninstall it?

I'm not sure what is happening with the NLP side of things, since that library isn't related to go or vulkan (to my knowledge).
But I do know that starting with vulkan 1.3, you have to enable the portability subset extension to use MoltenVK, which is required to make any of this work on a mac.  I opened an issue, and will be updating it shortly to address that change.


Made changes including -g/directory typos, consistent formatting of t…

…erms, clarification of instructions, build status formatting, and user stories

Looks good to me, and it's a non-breaking change, so I'm merging it


BIP39 derived seed for a BIP84 wallet

This PR derives a BIP84 wallet from a BIP39 seed phrase and exposes a corresponding rust api through the flutter rust bridge. Additionally this PR already improves the structuring (to the best of my limited flutter skills).
resolves #68 #11
This PR is still draft as the seed screen needs a little bit more care.

Actually, that PR is already quite big and there are a lot of useful things already in there. I've created a follow up ticket to build the seed widget. https://github.com/itchysats/10101/issues/84.

Given that @klochowicz is working on figuring out what is best to achieve libaray API calls into ruest, I would propose that we don't implement complete features where we touch the UI and the rust backend, but we implement either UI or backend.
I think the initial focus should be on the UI, because the UI as consumer should drive the API design for what is needed in rust. I propose that we focus on the when working on issues like #85 and #84, and plug in the rust code later. We can discuss the API while working on such tickets and then ramp up the rust code in parallel.

[snip]
This PR is still draft as the seed screen needs a little bit more care.

It's not marked as Draft PR on GiHub, is that on purpose?

Thanks @klochowicz @da-kami  for the comments. The rest of them will be addressed in follow up PRs.

bors r+

bors r-

bors r+