Deployment on Ubuntu 14.04 cluster

Hi,
I cant to run Flynn on a cluster of Ubuntu VM 14.04. Hope for your help.
Setup:

Host machine with OpenSuse (holds a configured DNS)
Three nodes under Ubuntu VM (ubuntu/trusty64) launched with Vagrant in a private netwrok:

config.vm.network "private_network", ip: "<IP_ADDRESS>" -- Node 1
config.vm.network "private_network", ip: "<IP_ADDRESS>" -- Node 2
config.vm.network "private_network", ip: "<IP_ADDRESS>" -- Node 3

From all three nodes I can ping CLUSTER_DOMAIN (in my case: cluster.myflynn), which was configured as requested [ https://flynn.io/docs/installation ]. Here is the ping for Node 1:
node1$ ping cluster.myflynn
PING cluster.myflynn (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=64 time=0.387 ms

node1$ ping cluster.myflynn
PING cluster.myflynn (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from vagrant-ubuntu-trusty-64 (<IP_ADDRESS>): icmp_seq=1 ttl=64 time=0.017 ms

Steps:
On the first node:
sudo bash < <(curl -fsSL https://dl.flynn.io/install-flynn)
sudo flynn-host init --init-discovery
__CODE__

On the 2nd and 3rd nodes:
sudo bash < <(curl -fsSL https://dl.flynn.io/install-flynn)
sudo flynn-host init --discovery __CODE__

On the 1st, 2nd and 3d node:
sudo start flynn-host

Other:
I have found out that no etcd run, however it was said that Flynn uses it.
Debug output for node 1: https://gist.github.com/ashkarin/67224dcbc6cc32e0490c
Debug output for node 2: https://gist.github.com/ashkarin/586f1f884ec381dfb4fb
Thanks :)

Did you run the bootstrap step as described in the documentation?

@titanous Sorry, I forgot to mention it. Yes, I start the bootstrap on Node1:
node1$ sudo CLUSTER_DOMAIN=cluster.myflynn flynn-host bootstrap --min-hosts 3 --discovery __CODE__
13:38:27.712961 check online-hosts
13:38:57.827748 check online-hosts error: timed out waiting for 3 hosts to come online (currently 0 online)

I also tried to clean up nodes with the following commands and repeat, but it didn't help.
sudo stop flynn-host
sudo rm /var/lib/flynn/host-state.bolt
sudo rm /var/log/upstart/flynn-host.log

Okay, please run the install script again with --clean and generate a new discovery token. If it doesn't work, make sure you post the flynn-host log from each host.

@titanous Done, here are commands again. Please fine logs in the end of the message.

Init Node1 to get discovery key, init other nodes with obtained key
Start flynn-host at Node 1, 2, 3
Run bootstrap on Node 1

node1$  sudo flynn-host init --init-discovery
https://discovery.flynn.io/clusters/d5b084a9-897b-47d1-9a46-833f5807fdbc
node2$ sudo flynn-host init --discovery https://discovery.flynn.io/clusters/d5b084a9-897b-47d1-9a46-833f5807fdbc
node3$ sudo flynn-host init --discovery https://discovery.flynn.io/clusters/d5b084a9-897b-47d1-9a46-833f5807fdbc

node1$ sudo start flynn-host
flynn-host start/running, process 9147
node2$ sudo start flynn-host
flynn-host start/running, process 3542
node3$ sudo start flynn-host
flynn-host start/running, process 3547

...10 seconds after...

node1$ sudo status flynn-host
flynn-host start/running, process 9147
node2$ sudo status flynn-host
flynn-host start/running, process 3542
node3$ sudo status flynn-host
flynn-host start/running, process 3547

node1$ sudo CLUSTER_DOMAIN=cluster.myflynn flynn-host bootstrap --min-hosts 3 --discovery https://discovery.flynn.io/clusters/d5b084a9-897b-47d1-9a46-833f5807fdbc
14:02:11.746557 check online-hosts
14:02:41.962903 check online-hosts error: timed out waiting for 3 hosts to come online (currently 0 online)

Here are logs and results of ps faux:
Node 1: https://gist.github.com/ashkarin/2c6b9e4f844d8e24b118
Node 2: https://gist.github.com/ashkarin/98380bb846dce3b278ad
Node 3: https://gist.github.com/ashkarin/0fce8f6c620f5b27c71d

Would you please check the IP addresses of your nodes? All of them are getting the same discovery instance ID, so I suspect the IPs are the same.

Specifically <IP_ADDRESS>.

The solution is to pass --external-ip to each flynn-host init call.

@titanous Thank you! The solution works. :+1:


Revert the revert

Context
We made the mistake of reverting PR #377 from mcagov/sar_backup_export. This PR reverts the revert commit: re-adding all the changes we should have kept from PR #377 from mcagov/sar_backup_export.
Changes in this pull request

Re-adds all the code from PR #377 from mcagov/sar_backup_export
Re-adds the code that hides the backup contingency button

The reason why there are 32 files changed in this PR rather than the 33 originally in the old PR #377 from mcagov/sar_backup_export is that index.scss is the same on main as it is in the revert_the_revert feature branch. Specifically, main has the following already:
`#download-progress-circle {
margin-left: 120px;
margin-top: 20px;
}
.hidden-button {
display: none;
}`


Pubkey auth.

First pass implementation. Adds pubkey handshake to the authentication state.
Requires the addition of pycrypto - could be replaced with C bindings to openssl crypto library. Can then use the bin/gen_keys utility to generate an RSA keypair.
Default behavior is to not try to perform a pubkey handshake if no key files are supplied when the client / server is invoked. New command line option is -K / --keyfile for both server and client.
Needs some work with handling failed authentication.
Needs move of token exchange to something post-encryption setup.
@millerjs ?

closing in favor of PR #17 to branch dev


undo does too much undoing

visit the demo page:
https://editor.bitwiser.in/

enable vim mode

enter insert mode

type I will delete this WORD after typing this

hit escape

move the cursor to the front of WORD

type dw in command mode to delete the word

press u in command mode to undo deleting the word

notice that the end of the  sentence this is also now gone.

I think this might be a monaco specific issue, not a library problem with monaco-vim?
When I type a bunch into this codepen, and then trigger the undo (like you're doing in the library) it's just removing a whole bunch of stuff :/
https://codepen.io/anon/pen/MNeKxg


fix(bug): Fixing a bug in the instantiation of the library

:tada: This PR is included in version 1.6.2 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


sqlparser: Limit nesting of parenthesized exprs

Correction: This only addresses one parenthesized construct.
The next pull request will address the rest.
This addresses https://github.com/youtube/vitess/issues/767
as well as other situations where there's possibility of
indefinite nesting of SQL constructs. There may be other
non-parenthesized constructs that allow nesting, but this fix
doesn't address them for now.
I've also made a few lint fixes. sql.go is still in violation,
but that requires bigger work.

LGTM

Going to merge the additional additional change also, since it's just an extension of the previous one.


How to create a Tensorflow Dataset without labels? Input 'filename' of 'ReadFile' Op has type float32 that does not match expected type of string

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
-Linux Ubuntu 20.04
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below): 2.3.1
Python 3.8.5
CUDA/cuDNN version: 11.0
GPU model and memory: RTX 2060 8GB

I was trying fit my model using instances of the tf.data.Dataset class. I need the repeat() method to perform a custom image augmentation for every epoch.
Using Tensorflow 2.3.1, I'm trying to create an instance of the class tf.data.Dataset without labels, from the images I have stored in  .png files in a folder './Folder/'. For creating the minimal working sample, I think the only relevant line is the one where I am calling tf.keras.preprocessing.image_dataset_from_directory.
The class definition is here:
Standalone code to reproduce the issue
After storing some PNG files in the folder ./Folder/' , the minimal working sample is just this line:
 dataset = tf.keras.preprocessing.image_dataset_from_directory('./Folder/',label_mode=None,batch_size=100)
I expected the tf.data.Dataset instance dataset to be created, and a message:
Found 449 files ...
Instead, I get the message:
Found 0 files belonging to 0 classes. , followed by this error:
Traceback (most recent call last):
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/framework/op_def_library.py", line 465, in _apply_op_helper
    values = ops.convert_to_tensor(
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/framework/ops.py", line 1473, in convert_to_tensor
    raise ValueError(
ValueError: Tensor conversion requested dtype string for Tensor with dtype float32: <tf.Tensor 'args_0:0' shape=() dtype=float32>

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "04-vaeAnomalyScores.py", line 135, in <module>
    historicKLD, encoder, decoder, vae = artVAE_Instance.run_autoencoder()  # Train
  File "/media/roi/9b168630-3b62-4215-bb7d-fed9ba179dc7/images/largePatches/artvae.py", line 403, in run_autoencoder
    trainingDataSet = self.loadImages(self.trainingDir)
  File "/media/roi/9b168630-3b62-4215-bb7d-fed9ba179dc7/images/largePatches/artvae.py", line 230, in loadImages
    dataset,paths = tf.keras.preprocessing.image_dataset_from_directory(dir[:-1]+'Downscaled',label_mode=None,batch_size=self.BATCH_SIZE,
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/keras/preprocessing/image_dataset.py", line 192, in image_dataset_from_directory
    dataset = paths_and_labels_to_dataset(
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/keras/preprocessing/image_dataset.py", line 219, in paths_and_labels_to_dataset
    img_ds = path_ds.map(
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/data/ops/dataset_ops.py", line 1695, in map
    return MapDataset(self, map_func, preserve_cardinality=True)
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/data/ops/dataset_ops.py", line 4041, in __init__
    self._map_func = StructuredFunctionWrapper(
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/data/ops/dataset_ops.py", line 3371, in __init__
    self._function = wrapper_fn.get_concrete_function()
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/eager/function.py", line 2938, in get_concrete_function
    graph_function = self._get_concrete_function_garbage_collected(
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/eager/function.py", line 2906, in _get_concrete_function_garbage_collected
    graph_function, args, kwargs = self._maybe_define_function(args, kwargs)
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/eager/function.py", line 3213, in _maybe_define_function
    graph_function = self._create_graph_function(args, kwargs)
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/eager/function.py", line 3065, in _create_graph_function
    func_graph_module.func_graph_from_py_func(
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/framework/func_graph.py", line 986, in func_graph_from_py_func
    func_outputs = python_func(*func_args, **func_kwargs)
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/data/ops/dataset_ops.py", line 3364, in wrapper_fn
    ret = _wrapper_helper(*args)
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/data/ops/dataset_ops.py", line 3299, in _wrapper_helper
    ret = autograph.tf_convert(func, ag_ctx)(*nested_args)
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/autograph/impl/api.py", line 255, in wrapper
    return converted_call(f, args, kwargs, options=options)
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/autograph/impl/api.py", line 532, in converted_call
    return _call_unconverted(f, args, kwargs, options)
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/autograph/impl/api.py", line 339, in _call_unconverted
    return f(*args, **kwargs)
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/keras/preprocessing/image_dataset.py", line 220, in <lambda>
    lambda x: path_to_image(x, image_size, num_channels, interpolation))
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/keras/preprocessing/image_dataset.py", line 228, in path_to_image
    img = io_ops.read_file(path)
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/ops/gen_io_ops.py", line 574, in read_file
    _, _, _op, _outputs = _op_def_library._apply_op_helper(
  File "/home/roi/.local/lib/python3.8/site-packages/tensorflow/python/framework/op_def_library.py", line 492, in _apply_op_helper
    raise TypeError("%s expected type of %s." %
TypeError: Input 'filename' of 'ReadFile' Op has type float32 that does not match expected type of string.

@xenon3dfx
Please share simple indented stand alone code to replicate the issue or if possible share a colab gist with the error.

import tensorflow as tf
dataset = tf.keras.preprocessing.image_dataset_from_directory('./folder/',label_mode=None,batch_size=100)

Just put png files in the ./folder/ directory

Have the same issue. Did you manage to solve the problem @xenon3dfx ?

Have the same issue. Did you manage to solve the problem @xenon3dfx ?

How was this issue solved? I still have the same issue in Tensorflow 2.4. It looks like label_mode=None is not really recognized by the API.


Allow multiple PennyLane transforms to work with Catalyst

PR #280 introduced support PennyLane QNode transforms, but only for one transform per function.
Extend the support for multiple such transforms.
Reference comment: https://github.com/PennyLaneAI/catalyst/pull/280#discussion_r1388533648

Multiple transforms are supported since the rework of transformations in pennylane (introduction of the transform program).


Feat: confirm basket transaction

Move confirm screens and modals to OperationsConfirm folder
Create sign operation component with confirm step for basket transactions

@Asmadek if the operation is not Valid then the user should not be able proceed to signing


Problem with generate and dynamic params?

I want to static generate my dynamic route so there won't be api requests on the deployed site. However I seem to be doing something wrong since my asyncData method is always skipping to the "else" condition.
In my nuxt.config.js
const axios = require('axios')

module.exports = {
  generate: {
    routes: function () {
      return axios.get('http://exmaple.com/api/cases')
      .then((res) => {
        return res.data.objects.map((content) => {
          return {
            route: '/case/' + content.slug,
            payload: content
          }
        })
      })
    }
  }
}

And in my dynamic page/route component
export default {
  async asyncData ({ params, error, payload }) {
    if (payload) return { content: payload }
    else return {
      content: 'something else'
    }
  }
}

It is always skipping to "something else", both before and after nuxt generate has been completed.
From my understanding, the else return should be returned during dev "npm run dev", else the payload from routes generate should be returned?
EDIT: is it possible to generate a 100% static site and decouple the API?

@jesperlandberg did you solve this? I'm having the same issue, I think. See #2149 also.

I am having this problem as well.
Since you closed the issue @jesperlandberg, have you been able to get this to work?

payload is only provided to the serverside asyncData execution during the nuxt generate. It is not provided on client loads.
If you want to package static data with your distribution, you can generate json see https://github.com/qm3ster/linnertmedia for a basic example that also uses payload to speed up generation and doesn't require the static folder to run a server during generation.
For further explanation see #2149


restore march LN spec calls

these two are breaking the scrapers for some reason so I removed them in https://github.com/bitcointranscripts/bitcointranscripts/commit/f47d1c48968776c14bc1a34e215c8855dd933ef9. Keep in draft until we can figure out why...

removed some whitespace - will try this again
cc @carlaKC


Investigate possibility of borrowing some features/ideas from Explainable Boosted Machines

Summary
Borrow ideas from InterpretMLs Explainable Boosting Machine to make LGBM more interpretable as well as more comparable to their EBM.
Description
I am sure you are somewhat aware of InterpretMLs Explainable Boosting Machine - also a Microsoft innovation!
I have been a long time user of LGBM and now an recent fan of EBM. Clearly, they are similar in ways and each have their strong points and weaknesses. There are trade-offs of choosing either. That said, I have been playing around with some settings in LGBM to make the final models behave more like the EBMs. The reasons for this are two fold:

Increase LGBM interpretability
Allow more direct comparisons of results/functionality.

Some tips, tricks and findings are as follows:
Setting n_estimators high, learning_rate low, and num_leaves low, begins to mimic some of the behaviours of the EBM. That is, iteratively building LOTS of VERY shallow trees, VERY slowly. I add feature constraints so that each tree is univariate. Pairwise interactions could also be added where needed. This allows the model to learn incrementally small amounts from each feature, rather like the EBM.  Essentially, replicating a model of the form:
lgb = F0(X0) + F1(X1) + ... + Fn(Xn)
which is effectively a GLM/GAM.
lgb = LGBMRegressor(
    n_estimators=5000, #large
    learning_rate=0.01, #small
    num_leaves=4, #shallow
    interaction_constraints=[[i] for i in range(X.shape[1])], #[[i, j] for i in range(X.shape[1]) for j in range(X.shape[1]) if i != j]
#     feature_contri=[10 for i in range(X.shape[1])], #use to reduce single feature dependence?
#     monotone_constraints=[1 for i in range(X.shape[1] - 1)] + [-1], #use for expert knowledge. I used in my temperature vs gas use case. temp -> gas monotonically decreasing.
)

To me, however, there seems to be two relatively simple features that could be added to facilitate this further.

The addition of a Constant Term.
Schedulable Feature Cycling.

The Constant Term
This would allow the model to remove the extra/redundant initial "value"* from the first set of splits on the first feature. This is the same as shifting your y-variable (e.g. lgb.fit(X, y - C), but until the initial run, you do not know what C is.
Schedulable Feature Cycling
This could be done in many ways, but essentially, all that is needed is the ability to cycle through each feature in-turn. With the current model params this is done at random. Combined with the above issue, this means that any features disproportionately picked at random in the first few trees would have an artificially inflated "value"*.
Hopefully it is clear how this would help improve the understanding of how an LGBM model is behaving.
This is aimed at being an ongoing discussion, so please chime in. Any questions, please ask!!
Motivation

Increase LGBM interpretability.
Allow more direct comparisons of results/functionality.
Borrow other idea from EBMs.
Open discussion on how to do this.

References
*"value" as defined in the table generated by: tree = lgb.booster_.trees_to_dataframe().
InterpretML: A Unified Framework for Machine Learning Interpretability
InterpretML: A toolkit for understanding machine learning models
InterpretMLs Explainable Boosting Machine

Closed in favor of being in #2302. We decided to keep all feature requests in one place.
Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature.

The Constant Term
This would allow the model to remove the extra/redundant initial "value"* from the first set of splits on the first feature. This is the same as shifting your y-variable (e.g. lgb.fit(X, y - C), but until the initial run, you do not know what C is.

This constant term is simply the mean of y. Is this just setting init_score to be the mean?

Schedulable Feature Cycling
This could be done in many ways, but essentially, all that is needed is the ability to cycle through each feature in-turn. With the current model params this is done at random. Combined with the above issue, this means that any features disproportionately picked at random in the first few trees would have an artificially inflated "value"*.

@StrikerRUS this is conceptually a very easy thing to implement, though imagine it to be at the internal level (C code level). It would simply require a parameter, lets say feature_sampling, and the options to be random or cyclic.
Can I add this as a separate feature request and then add it under the New features section? I feel it would be incredibly easy to implement so being under New Algorithm makes it seem a bit too big a task.

@JoshuaC3

This constant term is simply the mean of y in EBMs.

For mean value I think boost_from_average param should help. For any other custom values init_score can be used, as you correctly mentioned.

Can I add this as a separate feature request and then add it under the New features section? I feel it would be incredibly easy to implement so being under New Algorithm makes it seem a bit too big a task.

Sure! As you are quite familiar with EBM, feel free to split this big issue into multiple smaller separate feature requests which will be self-contained and will not require a lot of efforts for writing new code. I believe it will help to evolve more people into improvement process of LightGBM.

@StrikerRUS Thanks! I will do this.
In Python, how do you return the init_score after the model is trained? I cannot find any functions or attributes for it. Thanks!!

Do you mean something like this?
import numpy as np
import lightgbm as lgb

from sklearn.datasets import load_boston

X, y = load_boston(return_X_y=True)
lgb_data = lgb.Dataset(X, y, init_score=np.ones_like(y))
lgb_data.get_init_score()

In LightGBM init_score is tight with Dataset object.

Precisely that. Thanks. I was looking on the Booster class and via the sklearn api.
I will add "Expose the get_init_score to the Booster class" as a feature request and also expose it in the sklearn api too. I think I might be able to do this as it all looks like pythons all the way up.


Image Cover

When downloading files the image comes up in preview but when importing songs to itunes the cover is not recognised. Is this a simple problem that could be solved?

I think the issue is within these lines, I will probably just fix it myself


Second clabot check

logs showing I am already signed up:
Unexpected event. I'll just pretend nothing happened
Skipping Collaborator/Contributor

[clabot:check]


JUnit jupiter fix for @Disabled tag order.

testEverythingWithLargeSet() had the tags in the wrong order
It appears the latest version of JUnit Jupiter was not respecting the @Disabled tag if the @Test tag was first. This resulted in this test (which was previously ignored) to run. The test was disabled due to previously failing, so when the tag was no longer recognized, it failed the build.

what a wild bug. nice find!


[Bug][github_graphql] repo's owner is null

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

Owner is null when collecting Organization's repo.
What do you expect to happen
Collect right
How to reproduce
use github_graphql to collect apahce/incubator-devlake
Anything else
We need this block.

query ($name: String!, $owner: String!) {
  rateLimit {
    cost
  }
  repository(owner: $owner, name: $name) {
    name
    databaseId
    url
    languages(first: 1) {
      nodes {
        name
      }
    }
    description
    owner {
      ... on Organization {
        login
        name
      }
      ... on User {
        login
        databaseId
        name
        company
        email
        avatarUrl
        url
      }
    }
    createdAt
    updatedAt
    parent {
      databaseId
      url
    }
  }
}

Version
main
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

It's out-of-time because of scope refactor.


test(e2e): running e2e on nap

Fixes #
Description
This PR is based on @Bryce-Soghigian's here:

https://github.com/Azure/karpenter-provider-azure/pull/178

I'm specifically pulling out the workflow files, and cleanup their code to prevent as much duplication.
How was this change tested?

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.716%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
35591

Relevant Lines:
36423

💛  - Coveralls


Waiting time too long or Bad Gateway returns

It is currently taking too long to get the IP with this api https://api.ipify.org

Seeing the same thing. Started about a week or so ago with the get statement (we use axios) the response time is way down and will time out. manually typing api.ipify.org into the browser this morning I received the Bad Gateway but then refreshed and got the IP. Sometimes it responds fast for a bit then similar issues.

I have the same problem, I changed to the version https://api64.ipify.org/ which is more stable but still fails.

Experiencing the same. Sent them a message through their Geolocation API website where they promote paid services.

Reply from IPIFY:
"We have some problems with our service, api.ipify.org, that cause a long-time-response issue. We are working to fix it, and the response time will recover to normal value in the near future. All our paid services (including IP geolocation API or VPN & Proxy Detection API) have dedicated servers and don't have such problems. Unfortunately, we have no paid alternative for api.ipify.org, so we have to wait until our technical team resolves this issue."

Reply from IPIFY:
"We have some problems with our service, api.ipify.org, that cause a long-time-response issue. We are working to fix it, and the response time will recover to normal value in the near future. All our paid services (including IP geolocation API or VPN & Proxy Detection API) have dedicated servers and don't have such problems. Unfortunately, we have no paid alternative for api.ipify.org, so we have to wait until our technical team resolves this issue."


Switch to using automatically renewing SSL certificate from GlobalSign

:tada: This PR is included in version 1.18.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Updated Roland's details

Included username, as well as smileys

According to the issue (https://github.com/joewadcan/FirstPullRequest/issues/246#issue-503187794) we opened, please also add your favorite Berkeley restaurant? Thank you.


0.7.x hangs on Google Cloud components using Python 3.8

As reported in https://github.com/dask/gcsfs/issues/278#issuecomment-685125685 and later comments, 0.7.x runs into issues under some conditions on GCP.
Symptoms are:

gcsfs.GCSFileSystem(token='cloud') or gcsfs.GCSFileSystem() executes w/o error - doesn't mean correctly instantiated
following ls(), exists() or glob() (confirmed methods so far) run forever, no error raised
experienced on GCF, GKE and Composer

Workaround: stick to 0.6.2
EDIT: important finding: latest gcsfs works fine on GCP with Python 3.7. This could indicate a library conflict.

In my case python version is the same (3.6.10) in 2 Composer environments, but GCC version differs (gcsfs works well with GCC 5.4.0 20160609, hangs with GCC 7.5.0). Not sure if that could be the cause though.

Can you please list the versions of aiohttp, fsspec, python, google sdk and anything else that looks like it might be involved? The env is installed using pip, right? It may have something to do with the new version of pip.
@rm3195 - I can't see how GCC would be involved, unless I am very wrong.

can you please call gcs.maybe_refresh() immediately after instantiation, to see if anything happens? It should populate gcs.heads/gcs.credentials. It may be worthwhile explicitly calling gcs._connect_cloud() too; or if you have a JSON credentials file, perhaps gcs._connect_token/service().
Referring to the code in https://github.com/dask/gcsfs/issues/278#issuecomment-749249318 , perhaps I would try moving gcsfs.GCSFileSystem() inside the function, just in case it needs the context to already exist when it gets called.

Moving gcsfs.GCSFileSystem() inside the function actually works, thanks! Although interesting why it worked another way before...

Confirming instantiating in the function vs. global works too in GCF.
Fine with me going forward but as @rm3195 indicates, why different with 3.8 vs. 3.7, or 0.6.2 vs. 0.7.x remains a mystery.
Note that this did not work:
import gcsfs

gcs = gcsfs.GCSFileSystem()
gcs.maybe_refresh()
gcs._connect_cloud()

def hello_gcs(event, context):

    file_name = event['name']
    input_bucket = event['bucket']

    file_path = f'{input_bucket}/{file_name}'
    if gcs.exists(file_path):
        print('Confirmed exists: ' + file_path)

I would also try inverting the order
gcs = gcsfs.GCSFileSystem()
gcs._connect_cloud()
gcs.maybe_refresh()

but I suspect that

creating the context (before calling the function, and after import, apparently) in the google lib creates additional information relevant to auth
the timing of creating the credentials object versus refreshing the token is not the same as it used to be, but I'm not sure what the difference is.

Thanks for investigating and bearing with us...

That still doesn't answer why the calls hang indefinitely - one would expect a timeout if, for example, the token refresh URL wasn't resolvable. Either we are in an auth refresh loop, or the underlying aiohttp lib gets some corrupted response (we saw something similar in s3fs, but seems less likely here).

I would also try inverting the order
gcs = gcsfs.GCSFileSystem()
gcs._connect_cloud()
gcs.maybe_refresh()

but I suspect that

creating the context (before calling the function, and after import, apparently) in the google lib creates additional information relevant to auth
the timing of creating the credentials object versus refreshing the token is not the same as it used to be, but I'm not sure what the difference is.

Thanks for investigating and bearing with us...

Same result - still hanging.

That still doesn't answer why the calls hang indefinitely - one would expect a timeout if, for example, the token refresh URL wasn't resolvable. Either we are in an auth refresh loop, or the underlying aiohttp lib gets some corrupted response (we saw something similar in s3fs, but seems less likely here).

Would aiohttp be called if asynchronous=False (the default) ?

Would aiohttp be called if asynchronous=False (the default) ?

Yes, it is the only backend. asynchronous indicated whether you intend to call the aync def functions directly, because the calling code is already running within an event loop. If False, we still use a loop internally to allow, for example, fetching and putting many files concurrently.


[Feature Request] Delegate SMP address information

Currently, SMP always sends the address type corresponding to its connection
https://github.com/google/bumble/blob/044597de66355672a5bba42fda455fe9c653337d/bumble/smp.py#L1038
However, in some cases(especially on Dual-mode devices), users may want to perform RPA exchange over a connection using random address(or vice versa, though it makes no sense).

This feature should now be supported with PR #231  , right?

Yes for the SMP part. Another issue is that bumble doesn't support address resolution yet. There is only a random_address field in device probably hold all kind of address here.


Several Infos improvement,Label map,pokestop info ,gym info and pokemom

Added Gym Info:
Team Name
Prestige : Total xp
Guarding Pokemon Name and id
Location
Get directions url google maps
Added Pokestop info:
Location
Get directions url google maps
Pokemon info:
Pokemon Name
Location
Get directions url google maps
All tested by on my map in windows 10 and Ubuntu 14.04
Last Developer Branch.
Date: 16/01/2017

@m3g4mInD can you fix the conflict :(

Yes i gonna fix thanks

I  need to check something and maybe change some code about layers,after i sleep :)

Git in my windows 10 as rip me off,i close this #pr but i open a update pull request.  https://github.com/Noctem/pokeminer/pull/42


fix: 2389- replaced logger unformatted strings with template literals

Which problem is this PR solving?

Good First issue bug-fix for OpenTelemetry-JS issue 2389.
Logger was using printf style formatting, which was resulting into unformatted strings (%s, %d).

Short description of the changes

All instances of such unformatted strings were searched and were replaced with Template Literals to resolve the issue.

Codecov Report

Merging #13 (7b36ec5) into main (6a78db1) will decrease coverage by 2.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   93.20%   91.06%   -2.14%
==========================================
  Files         137       54      -83
  Lines        5017     2071    -2946
  Branches     1060      419     -641
==========================================
- Hits         4676     1886    -2790
+ Misses        341      185     -156

Impacted Files
Coverage Δ

...telemetry-sdk-trace-base/src/MultiSpanProcessor.ts

packages/opentelemetry-propagator-b3/src/common.ts

...ntelemetry-core/src/common/global-error-handler.ts

...esources/src/platform/node/default-service-name.ts

...pentelemetry-core/src/platform/node/performance.ts

...elemetry-sdk-trace-base/src/BasicTracerProvider.ts

...ontext-async-hooks/src/AsyncHooksContextManager.ts

...opentelemetry-core/src/platform/node/timer-util.ts

...es/opentelemetry-propagator-b3/src/B3Propagator.ts

packages/opentelemetry-core/src/utils/url.ts

... and 70 more


Overlay shows on PoH death & Zulrah resurrection

Hi, nice plugin. I've run into two edge cases where it triggers but isnt relevant.

Dying in your PoH to poison or Vardorvis bleed. You just spawn outside your house but definitely technically die
Dying to Zulrah with the elite western province diary completed and the resurrection bringing you back alive

Thanks, I think if I add a check to confirm the inventory has changed after
the death event it would resolve these cases, and potentially others
On Tue, 2 Jul 2024, 13:59 Alfie94, @.***> wrote:

Hi, nice plugin. I've run into two edge cases where it triggers but isnt
relevant.

Dying in your PoH to poison or Vardorvis bleed.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


enhancement: first draft of a basic contributing.md file

What does this PR do?
Adds a basic CONTRIBUTING.md file. Closes #10.

Thanks @synek, will review later

It might be good to have some (non-enforced, optional) commit message convention.
The "Conventional Commits" you use seem good for this.
This might look something like the following:

Give commits on main a useful message. A summary of what you did, and why.
You can rewrite (and squash together) old throwaway commits on a personal branch using git rebase -i.
You can format your commit message however you want;
If you want to format them consistently however, look at previous commits
or check out Conventional Commits.

It might be good to have some (non-enforced, optional) commit message convention. The "Conventional Commits" you use seem good for this.

I think that might be a bit too much for academics to be honest. Even professional developers lack the discipline to write good commit messages. I'm happy to just use it personally and let people also pick it up if they happen to notice it in my commit messages.

yeah.
Hence my proposed text (useful commit messages only on main; and format however you want).
The pointer to suggested ways to format is to unblock decision paralysis-prone people like me


not woking

There's a video in readme already

hi..i just tried everything and it is not working. all it says is error occured.

What error exactly

nothing when i ran the main .py file i typed 0 and then it went on showing a list of links like short earn, curiosoty stream  with an error occured again and again. I would be thankful to you  is you can solve this problem
regards
--hmm-star

can you please record a video of that, and send it here, thanks


DataHarmonizer2 - "sequence submitted by validation" issue

Testing valid data and for some reason "sequence submitted by" is marking valid data as invalid. The only way to overcome this is to reselect the value from the picklist - see Public Health Ontario (PHO) in screenshot of validated sheet.

This often means a space or possibly an other UTF braces code was used in encoding the string.  I'll retype in source vocabulary, usually that fixes.

Same thing appears to have happened with Newfoundland and Labrador under geo_loc_name (province/territory). Perhaps there was an issue with the last vocabulary import as all the values experiencing this problem were changed in the last vocabulary update.

In both these documents:

I imported the file,
selected valid terms from the picklists,
then saved it from DataHarmonizer,
and then reimported it and they were deemed invalid again.

Ah, that discounts that explanation.  Must be an extra space getting inserted in menu item selection.  Will check.

I was running a serious of experiments, still getting weird character inserts (observable in UTF-7), but then I refreshed the window and started running another set and it doesn't appear to be happening anymore. Will run a couple more checks to confirm.

Unable to reproduce using the same source data and branch. Will close this issue for the time being and reopen if this issue arises again.


feat!: enable interchain accounts

Closes https://github.com/celestiaorg/celestia-app/issues/3062
Remaining tasks

[x] app.go is really difficult to read. Consider refactoring app.go prior to merging this change
[x] Update specs
[ ] Add tests

Links

https://github.com/strangelove-ventures/interchaintest
https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/base_test.go

Need to enable tx indexing in the celestia-appd Docker image that is used in interchain test because:
        	Error Trace:	/Users/rootulp/git/rootulp/celestiaorg/celestia-app/interchaintest/ica_test.go:65
        	Error:      	Received unexpected error:
        	            	exit code 1:  2024-03-14T19:28:49.880923Z	error	Failed to wait for block inclusion	{"provider_type": "cosmos", "error": "cannot determine success/failure of tx because transaction indexing is disabled on rpc url"}

I'm observing that commits on PRs in celestia-app don't push Docker images to GHCR. I expected them to push considering we have workflows for it. But I think it's not pushing because this PR was created from a branch on a fork.
Ref:

https://github.com/celestiaorg/.github/blob/813fe4729dd8c6bd7d08b4fe686cf03c4017b96e/.github/workflows/reusable_dockerfile_pipeline.yml#L293
https://github.com/celestiaorg/celestia-app/actions/runs/8300697747/job/22719267376?pr=3045#step:9:6
https://github.com/celestiaorg/celestia-app/pkgs/container/celestia-app

Deprecated in favor of https://github.com/celestiaorg/celestia-app/pull/3182


Document that RESIN_HOST_CONFIG_enable_uart = 1  is needed when using a CAN shield

@vipulgupta2048 there is no link to the doc that needs this fixing

Closing stale issues


Update hive version in build.gradle

What changes were proposed in this pull request?
Update hive version in build.gradle so that it matches with the the parent project snappydata.
https://github.com/TIBCOSoftware/snappydata/pull/1553
How was this patch tested?
precheckin

Merging this PR as precheckin run is complete with a few failures. But these are seen with earlier state of the base branch too.
We may need to address these separately.


Block processing for SAR filtering

This PR introduces the block processing for the SAR filtering.
For the edge cases (i.e. polar regions), the number of bursts could be more than 60. In this case, the memory issue can occur and the workflow can fail. To avoid this issue, the block processing for filtering could be one solution.

@oberonia78 If I remember correctly, the PR #44 includes the features implemented in this PR. If correct, can you consider closing this PR?


Support for module / no-module pattern

Added legacyConfig and modern build in Webpack configuration to support module/no-module
Added module/nomodule support with loadable-components

Closes #15


Enable JSX files extension

JSX extension is essential in React, this would be a natural addition.

See: https://github.com/facebook/react-native/issues/2303

Closing in favor of: https://github.com/facebook/react-native/pull/5233


Update gallery.yaml with codex-clustergrammer2

My example runs on MyBinder (see https://github.com/ismms-himc/codex_dashboard) and I followed the https://github.com/voila-gallery/gaussian-density example. The example shows how we can use our custom widget https://github.com/ismms-himc/clustergrammer2 and bqplot to visualize high-dimensional single cell data. Here's a tutorial link http://www.youtube.com/watch?v=JlUvt4rpF-s

Thanks @cornhundred, that's a cool example!

We are continuing to develop the dashboard so any feedback is welcome :)

Sounds good!
In the meantime we are going to add support for "pinning" examples (https://github.com/voila-gallery/gallery/pull/59).
It means that you can iterate on yours on master, and then open a new PR here to update with the new version once it's ready.

@jtpio Great! Thanks for the merge

@jtpio I'm seeing a 500 Internal server error when I try to run the codex-clustergrammer2 example from https://voila-gallery.org/services/gallery/
I raised the issue here: https://github.com/voila-gallery/gallery/issues/63


Asking for Help

When two users using Pull, Push or Clone commands, one client will always waiting another client finished, how to fix it?

I will assume you are using SSH.  Try increasing the threadpool size.  Set this in your gitblit.properties file.
execution.defaultThreadPoolSize = 10

It works for me! thanks~


Syntax error while installing with go get

Hi @joushou, great project. Unfortunately, I am unable to install it:
go get github.com/joushou/serve2d
# github.com/joushou/serve2
gocode/src/github.com/joushou/serve2/serve.go:78: syntax error: unexpected range, expecting {
gocode/src/github.com/joushou/serve2/serve.go:97: non-declaration statement outside function body
gocode/src/github.com/joushou/serve2/serve.go:99: non-declaration statement outside function body
gocode/src/github.com/joushou/serve2/serve.go:107: non-declaration statement outside function body
gocode/src/github.com/joushou/serve2/serve.go:108: syntax error: unexpected }
# github.com/joushou/serve2/proto
gocode/src/github.com/joushou/serve2/proto/tlsmatcher.go:114: cs.Version undefined (type tls.ConnectionState has no field or method Version)

Same on go version go1.2 linux/arm and go version go1.2 linux/amd64.

Thanks for liking the project!
I suspect that the issue is on your end, however. Serve2d is built using the latest releases of Go, meaning 1.4.2 and 1.5rc1. I believe the errors you are receiving are because of syntactic constructs that weren't added till 1.3 and 1.4.
Are you able to upgrade to at least 1.4.2? If your distribution has no official way to install, consider either using "gimme" (https://github.com/travis-ci/gimme/ - what TravisCI uses), "gvm" (https://github.com/moovweb/gvm), or just installation from source which is super simple. 1.2 is quite outdated. I can also add more binaries to the release if you'd like.
If you want to code go yourself, I heavily suggest updating so that you get the convenience features, bugfixes and performance of 1.4.2 or 1.5rc1.

I've added 1.4.2 as a requirement under "Installation", to avoid future confusion. Thanks for pointing it out that this was lacking, btw.
When you've gotten things to work, or you need more guidance, comment on the issue. I'll close it when things seem to be working for you, or I haven't heard from you long enough.

Hey, thanks for the quick response.
Yes, I already suspected that my version was too old. I normally use current-stable versions as well, but I'd love to have Serve2d running on a Raspberry Pi, where installing Go hasn't been that straightforward last time. But I'll try with 1.4+.
Issue can be closed imho, since you mention the required version now. Thanks again.

In go1.5rc1, boostrapping the toolschains for cross-compilation is as easy as calling make.bash with GOOS and GOARCH set to things like "linux" and "arm", making the actual cross-compilation for Rasberry Pi "GOOS=linux GOARCH=arm go build".
It does require that Go was built from source (which gimme, gvm, and homebrew (OS X) does), as the package would otherwise have to bundle the cross-compilation suite as well.
If you can wait two minutes, I'll upload a linux/arm build to the v0.3 release zips. It's built from OS X, so there's no cgo, but tell me if it works.

Uploaded: https://github.com/joushou/serve2d/releases
Try it and tell me if it works!

Yes, I've got it working on the Pi with your latest ARM binary, thanks a lot :).
Two small remarks:

When using the example JSON from the README instead of example_conf.json in the source code zip, serve2d exits silently after reading the config (afaics, it doesn't like the logFile param).
Also, it seems to have trouble parsing any config file comments ("invalid character '/' looking for beginning of object key string" etc.).

Ah, right. See, those comments are for documentary purposes. JSON, in any form, doesn't actually support comments, so if you copy paste the thing from the README, the JSON parser in Go will commit harakiri. :(
... It should, however, notice that the logging framework has not yet been set up, and error out to stderr. That, I believe, is what my setups usually do if I screw up the config. I'll take a look at it, though.
logFile does work - that's how I run my own servers! It looks sane to me, although do remember that it's relative to the current working directory, so it will need to be able to make files in the working directory, or write permissions to the file if it already exists. I have absolute paths as logFile paths for that reason, and touched and chmodded the logfile before use, so it can be in /var/log where the serve2d user wouldn't normally have permissions to make files.


⚠ Bofrost.de has degraded performance

In 06f3d17, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1534 ms

Resolved: Bofrost.de performance has improved in 0bca84f after 3 hours, 47 minutes.


ethers-cli with Abscissa

Motivation
This PR is for #3, creating a CLI for ethers-rs.

Solution
This PR is a work in progress. CLI is built with Abscissa. Abscissa is a  microframework for building Rust applications (either CLI tools or network/web services), aiming to provide a large number of features with a minimal number of dependencies, and with a strong focus on security.
This version of Abscissa uses gumdrop

PR Checklist

[x] Abi Generator Command
[ ] Send ETH
[ ] Send ERC-20 tokens
[ ] Wrap ETH
[ ] Unwrap ETH
[ ] Sign data
[ ] Compile solidity contract
[ ] Deploy solidity contract
[ ] Account info
[ ] Tx info
[ ] Wait for pending transaction

@gakonst can you tryout the Abigen command?
abigen [contract_name] [contract_source]

@hannydevelop I'd encourage looking into cast (cli) which has many of these commands already. We can port over the abigen command there.


DBZ-1781 Add support for sharded MongoDB collections

Rebased and applied. Thanks a lot, @jgraf50!


Disallow ImplicitAccountCreationAddress in SDRUC/Expiration

Closed by https://github.com/iotaledger/iota-sdk/pull/1703


Error: require() of ES Module - Instead change the require of index.js in applicationMutation.ts to a dynamic import() which is available in all CommonJS modules.

Hello,
When in the backend (Express) with Typescript,
I do this
npm install @passwordless-id/webauthn

then:
import { server } from '@passwordless-id/webauthn'
const applicationMutation = {
  createPasskeyApplication: async (_parent: unknown, args: Args, ctx: Ctx): Promise<Application> => {
     const registrationParsed = await server.verifyRegistration(args, expected)
  }
}

When I compile, I have this error:
[ERROR] 18:29:27 Error: require() of ES Module<EMAIL_ADDRESS>from /Users/alan/Documents/app/backend/server/graphql/src/resolvers/mutation/applicationMutation.ts not supported.
Instead change the require of index.js in /Users/alan/Documents/app/backend/server/graphql/src/resolvers/mutation/applicationMutation.ts to a dynamic import() which is available in all CommonJS modules.
(node:22269) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.

Any idea where this issue might come from?
Thanks fro your help!

Too old target or node version perhaps?

closed due to inactivity

getting this same error in nestJS as well. @alan345 did you figure this out?

@rogue-kitten What's your node version?

it's the latest one, 20.7.0

https://github.com/passwordless-id/webauthn/issues/35

Is it possible to use the build module in CommonJS?

See also https://github.com/passwordless-id/webauthn/issues/35#issuecomment-1900264705


Introduce core.gardener.cloud/v1beta1.InternalSecret API

How to categorize this PR?

/area dev-productivity usability
/kind enhancement
What this PR does / why we need it:
Introduce core.gardener.cloud/v1beta1.InternalSecret API based on core/v1.Secret API types, conversion, validation, etc.
Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/7999
Special notes for your reviewer:
Based on https://github.com/gardener-community/hackathon/blob/main/2023-05_Leverkusen/README.md#-introducing-internalsecret-resource-in-gardener-api / https://github.com/rfranzke/gardener/tree/hackathon/internal-secrets
Release note:

gardener-apiserver now exposes a new `core.gardener.cloud/v1beta1.InternalSecret` API, see the [documentation](https://github.com/gardener/gardener/blob/master/docs/concepts/apiserver.md#internalsecrets) for more information.

/test pull-gardener-e2e-kind

/retest-required

/retest-required

/approve


"export 'GridLayout' was not found in 'vue-grid-layout'

vue:2.5.2
vue-grid-layout:2.4.0
browser:chrome
Describe the bug
The vue-grid-layout doesn't seem to be exporting anything, therefore vue fails run the project with error message:
"export 'GridLayout' was not found in 'vue-grid-layout'

The same thing happened to me.

Can you provide some source code for us to review? I can't seem to write any code to reproduce this problem.

ref to build config: https://github.com/jbaysolutions/vue-grid-layout/blob/master/vue.config.js#L14
The cjs/umd exports ONLY export default, which is install() plugin.

why


Extend discriminator to support a default/fallback model

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
Currently, Pydantic's discriminator for discriminated unions requires all possible values of the discriminator field to be explicitly listed using Literal. This works well for a fixed set of options, but it becomes less flexible when dealing with potentially open sets or when a "catch-all" or default behavior is desired.
When using a discriminated union, if the discriminator field's value doesn't match any of the defined Literal values in the union members, a validation error is raised. There's no built-in way to handle these cases with a default or fallback model.
Introduce a way to specify a default or fallback model for the discriminator. This could be achieved in a few ways:
for Example:
class Cat(BaseModel):
    pet_type: Literal['cat']
    meows: int

class Dog(BaseModel):
    pet_type: Literal['dog']
    barks: float

class Lizard(BaseModel):
    pet_type: Literal['lizard']
    scales: bool

class OtherPet(BaseModel):
    pet_type: str  # Could be any string not 'cat', 'dog', or 'lizard'
    description: str

class Model(BaseModel):
    pet: Union[Cat, Dog, Lizard,OtherPet] = Field(discriminator='pet_type')
    n: int

This feature would significantly improve the usability of discriminated unions in scenarios where there's a need to handle unexpected or less common cases.
Affected Components

[ ] Compatibility between releases
[X] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Hi @Creat55,
We offer callable discriminators for this use case. For example:
from pydantic import BaseModel, Field, Tag, Discriminator
from typing import Literal, Union
from typing_extensions import Annotated

class Cat(BaseModel):
    pet_type: Literal['cat']
    meows: int

class Dog(BaseModel):
    pet_type: Literal['dog']
    barks: float

class Lizard(BaseModel):
    pet_type: Literal['lizard']
    scales: bool

class OtherPet(BaseModel):
    pet_type: str
    description: str

def pet_discriminator(v) -> str:
    pet_type = v.get('pet_type')
    if pet_type in ('cat', 'dog', 'lizard'):
        return pet_type
    return 'other_pet'

class Model(BaseModel):
    pet: Union[
        Annotated[Cat, Tag('cat')],
        Annotated[Dog, Tag('dog')],
        Annotated[Lizard, Tag('lizard')],
        Annotated[OtherPet, Tag('other_pet')],
    ] = Field(discriminator=Discriminator(pet_discriminator))
    n: int

m = Model(pet={'pet_type': 'other_pet', 'description': 'a zebra'}, n=4)
print(repr(m))
#> Model(pet=OtherPet(pet_type='other_pet', description='a zebra'), n=4)

I could see a case where we add an attribute to Discriminator where you can just specify a fallback model to simplify this process.


fix(brave): settings page

🔧 What does this fix? 🔧
Fixes unthemed elements on settings page

🗒 Checklist 🗒

[x] I have read and followed Catppuccin's contributing guidelines.
[x] I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

weeee

🤨
gaa whoops, thanks for reminding


Don't require 'static

I see in the docs a todo labeled "don’t require 'static". I assume this is getting at how:
#[derive(ts_rs::TS)]
struct Foo<'a> {
    field: &'a str,
}

fails unless we add the constraint 'a: 'static.
So far ts-rs is really great for helping keep my backend and frontend in sync, but not supporting non-'static lifetimes is a big limiter for my higher performance uses, where I really don't want copies in serde. Is there an ETA on this feature?
Thanks again for creating a great crate, by the way.
-Peter

Okay, I decided to jump in and see if I could hackily make this work. Here's my attempt:
https://github.com/Aleph-Alpha/ts-rs/pull/117/files
I'd love input if this is even remotely a reasonable way to get ts-rs to support non-'static lifetimes.

The docs are actully outdated on this. Lifetimes were fixed in #128


Move notificationKey to model as deployment metadata key

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/lgtm

/approve


rename RequestMethodInterface

tests/Stubs/Requests/CreditCardAuthorise.php:21

This class can also implement the interface :)


chimera on steam deck issues

so i recently replaced the EMMC hard drive on my steam deck with an NVME 2TB one, and steam OS 3 recovery image wasnt found on my steam deck from a disk on key, so i decided i heard a lot about chimera and tried and loved it a lot, i should try it on the steam deck,
current issues are in desktop mode where stuff take a little to load,
fan goes super fast when nothing is open,
controls dont work whatsoever even if steam is open or closed
i am planning to use chimera on my steam deck regardless, since it works quite smooth and would like to use emulators without needing to install a bunch of software,
hope those issues are helpful to improve chimera

so i recently replaced the EMMC hard drive on my steam deck with an NVME 2TB one, and steam OS 3 recovery image wasnt found on my steam deck from a disk on key, so i decided i heard a lot about chimera and tried and loved it a lot, i should try it on the steam deck,
current issues are in desktop mode where stuff take a little to load,
fan goes super fast when nothing is open,
controls dont work whatsoever even if steam is open or closed
i am planning to use chimera on my steam deck regardless, since it works quite smooth and would like to use emulators without needing to install a bunch of software,
hope those issues are helpful to improve chimera

how'd you get it to boot? mine returns device timed out.


Get-DbaDbRecoveryModel, add tests for RecoveryModel

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[x] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[x] Adding code coverage to existing functionality
[x] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Adding coverage for the RecoveryModel parameter, which was left out
Approach
Add a test case for the RecoveryModel parameter

Thank you niph! Will merge once it passes.


Deprecate --service-* CLI args and replace with bootstrap config/overrides

All locality information cannot be set with the old CLI arguments and this causes confusion.

Interested in picking this up. I suppose this involves adding a deprecation notice when running with the --service-* CLI args, followed with removal of these args?

@derekargueta yup

@mattklein123 For this I imagine we still want to increment deprecated_feature_use for each deprecated flag used? (I ask because if so then a bit of extra plumbing will be needed since option parsing happens before the runtime is created)

Yeah for anything we want to deprecate at this point we have to both warn, increment the stat, and go through the multi-version deprecation with warn -> fail -> delete.


feat: search pills

The type of this PR is: TYPE

This PR solves [PROJECT-XX]
Description

@rajsam003 - is this still needed with https://github.com/artsy/force/pull/12276?

@rajsam003 - is this still needed with #12276?

No it not.
I am closing it. Thanks


[FEAT] Upgrade to Pydantic v2

This will allow multiple benefits.
Use cases:

multiple values allowed for aliases with AliasChoices and AliasGenerator

I need to validate a df that can have multiple names for a specific column. Let's say it could be col1 or `col[1-10]'.
I have a df that is created, and the column names can be a few different things but the same column, and I need a way to validate all the possible names. I've tried multiple things, custom validators, creating a model dynamically, and they have yet to work.

Running list of todos here, perhaps we can farm these off into narrower issues if the implied solution is precise enough:

[] pydantic.error_wrappers.ErrorWrapper has been deprecated, need to update validation error reporting to conform to pydantic's new style

It looks like @thomasaarholt has some work on #4 to support the printing of data frame validation error messages
the library currently handles dataframe validation in patito.validation._find_errors, but pydantic expects validation to occur at the model level, which makes conforming to pydantic's error handling style somewhat difficult. Perhaps we could brainstorm a more "pydantic2" way of running validation on dataframes.

[] subclass/extend pydantic's Field (or FieldInfo) to handle patito custom attributes (unique, derived_from, dtype, others?)
[] workaround (or polars-side solution) to support the json serialization of polars DataType and Expr objects, to address serialization errors when calling BaseModel.model_json_schema() on models that contain polars elements.


fixture/load ignores fixtures in subdirectories

What steps will reproduce the problem?
Problem involves fixture search process on fixture/load ( yii\console\controllers\FixtureController::actionLoad() ).
Let's say we have these fixtures under fixture namespace:
fooFixture.php
barFixture.php
sub\bazFixture.php
sub\fooFixture.php

The confirmation dialog would find all of them, but strips everything to basename():
foo
bar
baz
foo

On confirmation, it would try to find & load them directly under fixture namespace, ignoring subdirectories.
What is the expected result?
Instead of stripping found fixtures to basename(), their relative path sould be used (relatively to namespace dir). For aforementioned example, expected result is:
foo
bar
sub\baz
sub\foo

What do you get instead?
foo
bar
baz
foo

Additional info
Mentioned expected result  raises another problem in FixtureController::getFixtureConfig(): flag isNamespaced is calculated by presence of slashes in fixture name, whereas fixtures in subdirectories would have slashes and have no namespace.

Q
A

Yii version
2.0.5

PHP version
7.0.13

Operating system
Ubuntu 16.04

Made a pull request with proposed solution.
Would like to hear some comments / critics first, expecially about getFixturesConfig() changes.

Is it related to https://github.com/yiisoft/yii2-faker/pull/24?

Yes, current issue totally "mirrors" yiisoft/yii2-faker#24.


Fix the example exception typo

I would rather leave fix the parent class and change it to 'code' class variable...

@flugger what do you think?

I agree with the comments, definitely read better. But, the rename from $code to $errorCode would be a breaking change. Perhaps hold off on that for now?

@flugger cheers! please have a look at the parent class, it should be named like that otherwise it won't show the correct error code... I made this change cause it didn't work for me during the development...

Oh, I thought this was a change to the HttpException itself, but I see now this only changes the documentation. My bad! Looks all good then, nice catch, thanks :)

@flugger thanks!


Fix heading on 6.1.1

Coverage decreased (-0.3%) to 99.304% when pulling a8d3322557ac5a27a9e1c6105fb5833eacde38a7 on dschaller:patch-1 into 5f4d3439d787f769b19a5f2ea676165f2154e2e3 on evcohen:master.

@ljharb can you merge this?


small change that allows the plugin to be run with php < 5.6

Using functions when instantiating properties seems to be not possible in php < 5.6. This small change makes oauth-server compatible with lower php versions (tested on php 5.5)

Thanks. Forgot that older PHP versions don't support this!


ModuleNotFoundError: No module named 'server'

I just cloned the project and used following command to run the server :
python main.py run_webserver
but I got the following error:
    from server.config import *
ModuleNotFoundError: No module named 'server'

How can I fix that?

You should remove server. from first 2 lines of webserver.py file.

Then you might encounter with RuntimeError: Directory 'client/static' does not exist error, which means you should change "client/static" on line 7 to "../client/static".
If you don't have INPUT_FILE_PATH & OUTPUT_FILE_PATH files prepared, server won't run. You can simply create two excel files with columns "first_name", "last_name", "phone_number" and "ticket_id" for INPUT_FILE_PATH and an empty excel file for OUTPUT_FILE_PATH.

Thanks for your attention. This issue has been resolved.

Thanks for your attention. This issue has been resolved.


Cloud formation api gateway HTTP integration

Hi, I'm trying to create a yaml template using Cloud formation to make an api gateway which integrate to HTTP but couldn't succeed as template throwing errors in yaml. Can you help me with the snippet.
Thanks in advance.
/Sanjeev

I am not sure what CloudFormation template you are referring to. Both api-gateway-lambda-integration and api-gateway-mock-integration are valid and deploy successfully.

I came across your excellent blog post (thank you) to try to fix an error...but unfortunately, when I run your template and test the endpoint, the same error appears:

Execution failed due to configuration error: statusCode should be an integer which defined in request template

Seems like something's up.


tests: test_class_image

This PR adds following test cases into test_class_image,

testSetImageImport
testLastImportLayer
testGetLastImportLayer

Resolves/Fixes #562
Signed-off-by: mukultaneja<EMAIL_ADDRESS>

@mukultaneja There are a few changes I requested and a questions I had but overall, your work on this PR will bring Tern's coverage percentage for classes/image.py to 99% up from 83%. Nice work!

@rnjudge thanks for reviewing the PR. I have updated the code to incorporate all the changes. Please review it again!

Looks good to me. @nishakm want to take a look to make sure I'm not missing anything?

@mukultaneja Could you squash your two commits into one?

@nishakm, Done!

@mukultaneja One more thing: can you remove the Resolves/Fixes from your commit message as there is no issue associated with this PR? Once that is done, I will merge this. Thanks for contributing!

@mukultaneja One more thing: can you remove the Resolves/Fixes from your commit message as there is no issue associated with this PR? Once that is done, I will merge this. Thanks for contributing!

@nishakm There is an issue open to increase test coverage: https://github.com/vmware/tern/issues/539
@mukultaneja However, since this PR does not fix the entirety of the issue, please use Works towards #539 in your commit message.

@nishak, @rnjudge I have updated the commit message. Please review it!

@nishakm ok to merge?

@rnjudge Works for me. Merging.


Bad type highlighting in helix

The problem
User types aren't highlighted in the helix editor with the current highlights.scm
To Reproduce
Open d file in helix.
Expected behavior
User defined types should be highlighted as types
Fix
As a workaround I made these changes to the highlights.scm for helix where @function was used
(call_expression (identifier) @function)
(call_expression (type (identifier) @function))
(call_expression (type (template_instance (identifier) @function)))
(call_expression (type (template_instance (template_arguments (identifier) @type))))
(type (identifier) @type)

I don't understand how tree sitter or the highlighting system works so I'm posting it so you can decide if it's good enough for now, the highlighting in general isn't as rich as in other languages, but for me personally this is one of the most important things to have highlighted.

I've made some changes to the main highlights.scm.  I'm not using Helix right now, so I can't easily assess if those changes are good or not.

@MightyPrinny can you tell me if the changes in the highlights.scm are good?  I don't maintain the helix plugin.

I don't think so, I tried the current highlights.scm in neovim and now functions look like types and types aren't highlighted in pointer declarations.

I'm not sure if neovim's queries are compatible...  I need to look into this.

The grammar for call_expression is this:
    call_expression: ($) =>
      prec.left(
        choice(
          seq($._unary_expr, $.named_arguments),
          seq($.type, $.named_arguments),
        ),
      ),

This isn't particularly satisfying.
Realistically, we'd like to call out uer defined types.  But it's also the case that we basically have no way to distinguish between constructors and bare functions.  (UFCS also makes this a bit harder.)


Add Scala 2 optimizer/inliner

This PR enables the Scala2 optimizer to squeeze out some extra free performance. Since the project has both a core part and a cli part the optimizer is enabled differently for each
core: As the core is published as part of ci-release, the optimizer is only enabled in CI (i.e. github actions). It also uses "-opt-inline-from:<sources>" which is the most conservative option designed for libraries (i.e. it only optimizes the sources within each sbt module individually)
cli: Since the cli is designed to be distributed as an application/executable (i.e. we create a fatjar via sbt-assembly) we can take advantage of this and do global optimization. There are 2 types of global optimization, one is optimizing everything including the JDK and the other is optimizing everything aside from the JDK (i.e. inside the scala.tools.jardiff package). I opted to go for the scala.tools.jardiff package because we are also distributing the fatjar generally as an artifact in github so we can't control what JDK the user runs on. Note that while it may seem like the difference between <sources> and scala.tools.jardiff is negligible now it will matter more when more sbt modules made (i.e. an additional one aside from core) since it globally inlines everything form that package (which as a fatjar is generally safe).

I wish I had backported the improved optimi(s/z)er options. IIRC there was only a bit of tweaking for options to parse it correctly.
The new syntax is just -opt:inline:<sources> for inlining power and -opt:local for minimum strength safety.


Test support for Arm64

Added arm64 test support in .github/workflows/maven.yml and modified pom.xml file for running the test for arm64 platform.
Signed-off-by<EMAIL_ADDRESS>

@odidev Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@odidev Thank you for signing the Contributor License Agreement!


Dropdown exceeds mobile viewport

Task Description
Approved projects dropdown exceeds mobile view, need to find a reliable way to ensure all dropdowns never exceed viewport. (Solution should be general, feel free to ping me or @thesanjeevsharma to discuss for the solution)

To Note
Please only work on the issues that you are assigned to, PRs will be ignored if you are not assigned to the task. If the assigned issues have not been worked on for more than 3 days, we will remove the assignment.

Submitted PR, #29

@wakawakathedev do you know if this ticket is still relevant? We don't have the approved projects page on the developer portal anymore and I didn't see that breadcrumb dropdown anywhere else. Didn't dig into the code though so not 100% certain if we still need this update or not.

@wakawakathedev please check if we have a dropdown in the breadcrumb, and see if the bug was solved or not

Not reproducible on dev-portal


[Feature to main] Explainability in hybrid query

Description
Merge "Explainability in hybrid query" from feature branch to main, we do have clearance from app sec team.
Includes PRs:

https://github.com/opensearch-project/neural-search/pull/970

Related Issues
Resolves https://github.com/opensearch-project/neural-search/issues/658
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] API changes companion pull request created.
[X] Commits are signed per the DCO using --signoff.
[X] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

LGTM! Once this is merged, we should try to add more tests and increase the code coverage.

yup, for sure. Codecov was broken at time I was working on implementation PR, in this PR I just want to merge from feature branch, and anything else will be in a separate PR


Microsoft.EntityFrameworkCore.Design Stopped to work

I having the next exception when im runing "dotnet ef" in the comand line, this is really unexpected. I did a full clean of the nuget cache, resintalling .net core, last thing that i didnt try is re-formatting the laptop. So, next is the error details.
I have no idea what i did wrong, but i will help to found the error in the bug, if exist.
The exeption:
Exception message:
System.IO.FileLoadException was unhandled
Message: An unhandled exception of type 'System.IO.FileLoadException' occurred in Unknown Module.
Additional information: No se puede cargar el archivo o ensamblado 'Microsoft.Extensions.Logging.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' ni una de sus dependencias. La definición del manifiesto del ensamblado no coincide con la referencia al ensamblado. (Excepción de HRESULT: 0x80131040)
EF Core version: "Microsoft.EntityFrameworkCore": "1.0.0"
Operating system: Win10 x 64
Visual Studio version: VS 2015

@ingdotrodriguezbarrios are you mixing RTM packages form NuGet with pre-release packages from the nightly feeds? That error occurred while trying to load a pre-release 1.1 version of a logging package.

Im not loading 1.1, this is my project.json
project.json.zip

I tried reproducing this but I got no error.
Steps followed:

Run dotnet new on command line to start a new project.
Copy project.json file from above attachment to the newly create project (replacing the default project.json)
Run dotnet restore
Run dotnet ef

You project.json looks correct. Try restoring packages again.
You can also follow above steps and see if it works to figure out if something is wrong with your project or nuget config/cache.

Closing as unable to reproduce.


minimal fix for upload_url in rx.download

minimal fix on get_upload_url to at least avoid compilation errors.
Disclaimer: this PR ignore the fact that rx.download is not a true download for CORS situation (including the backend), this will be adressed by #3041.

not sure how this change would result in those reflex-web errors, maybe that's something else?


Driver: Don't imply -enable-anonymous-context-mangled-names with optimizations enabled, even if -g is used.

The option -enable-anonymous-context-mangled-names prevents stripping of dead metadata to improve debuggability.
But with optimizations enabled, we do a lot of dead code stripping which affects debuggability anyway.
rdar://problem/48123944

@swift-ci test

@eeckstein Is it worth adding a test that the relevant metadata is stripped with this option on?

@slavapestov Yes it is! I added a test case.

@swift-ci smoke test

@swift-ci smoke test


Disallow sign-in redirects to external domains

Description
This changes the sign-in code so that if a hostname is specified in the redirect URL, the redirect is denied with an error.
Motivation and Context
We have a code scanning issue that indicates that this could potentially be a security problem. We don't know if rejecting external redirects will break anything, but these changes should make it immediately obvious if something has broken.
Affects: https://www.notion.so/lyrasis/Address-codeql-code-scanning-security-alert-670d45248a4a49739a04165a1bb88bac
How Has This Been Tested?
I ran the existing test suite, and wrote a new test to show that redirects including a hostname are denied.
Checklist

[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.

That's odd. The code certainly takes the changed sign_in path in the test suite. :thinking:

Going to just blanket refactor every redirect in that file. :hammer:

It looks like there's actually a better/stronger check we can perform that I'm currently experimenting with. It looks like we can enforce redirects only to endpoints that werkzeug knows about.

Unfortunately, because we have catch-all rules, we can't use that stronger check. The answer would always be "yes, of course this server can accept that URL!".
I've adjusted the check so that the hostname (if given) in the redirect must match the Flask host.


Error handing missing for RemoteReporter TimerTask

In the following code for TimerTask, ArrayBlockingQueue could throw exceptions such as IllegalStateException and so on but the code is not catching and logging these errors properly. Code should catch and log proper exceptions via slf4j logger and may be capture this error in some metrics.
https://github.com/uber/jaeger-client-java/blob/ebda740068a0568650f321f56db6c2b658cb0e99/jaeger-core/src/main/java/com/uber/jaeger/reporters/RemoteReporter.java#L72
Exception in thread "Timer-3" java.lang.IllegalStateException: Queue full
at java.util.AbstractQueue.add(AbstractQueue.java:98)
at java.util.concurrent.ArrayBlockingQueue.add(ArrayBlockingQueue.java:312)
at com.uber.jaeger.reporters.RemoteReporter$1.run(RemoteReporter.java:73)
at java.util.TimerThread.mainLoop(Timer.java:555)
at java.util.TimerThread.run(Timer.java:505)

Good catch, @hzariv
I think this needs a bit of refactoring too. In close() method we should be using blocking put, but in report() and timer we can use add() and catch state exception. I don't think we need to log anything. We already increment metric in report(), it just needs to happen in catch clause. As for failing to add flush command - I'd just swallow that exception, the client should be already alerting on the dropped metric.


Replace ts.hasOwnProperty.call(...) with hasProperty(...)

This was introduced in #48389; it relies on the fact that ts is an object to get access to this commonly-used helper, but this confuses the module transform into thinking it can actually import this from the TS namespace (I'm working around it for now). Just use the helper we have in core.ts instead.

Thank you!

🤦♀ definitely not intentional to use the Object method directly.


[FLINK-11844][table-api] Simplify over window API classes and improve documentation

What is the purpose of the change
This PR removes duplicate code and thus simplifies the over window API classes. It improves the documentation as well.
Brief change log

Duplicate classes removed
Docs about windows updated

Verifying this change
This change is already covered by existing tests, such as OverWindowITCase.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@sunjincheng121 Would be great if you can take a quick look.

Thanks for the review @hequn8128 and @sunjincheng121. I addressed your comments. Will merge this now...

@walterddr good point with the documentation. I will change it to optional and add a sentence about the default behavior.

@walterddr the documentation for Flink 1.7 is correct. This behavior has been changed recently for Flink 1.8 (see FLINK-10676).


Proposal: merge github.com/pkg/errors

I think that the API suggested by @davecheney in his GopherContalk and implemented in the repo github.com/pkg/errors should be integrated into the errors package of the standard lib.
I learned that this is already his plan [1], but failed to find an issue or proposal here to track the progress, hence I created this one.
[1] https://twitter.com/davecheney/status/771688315573579778

I very much like @davecheney's const error suggestion (type Error string) he's made before and I wish that could make it into the stdlib. (Obviously for Go 2...)
I'm not sure I would care for Errorf gathering a stack trace. It's handy in some situations, that seems like unnecessary overhead for the general case.
Perhaps I just do not see what benefits this provides. It seems more like a debugging tool, imo.

Perhaps I just do not see what benefits this provides. It seems more like a debugging tool, imo.

You seem to have answered your own question in the same breath. It is a debugging tool, and that is the benefit it provides.

@SamWhited sorry, I wasn't as clear as I should've been.
I do not see what benefits this provides for the errors package the way the it is currently structured. I wouldn't mind something like NewWithStackTrace (obviously with a much better name).

As @davecheney said (https://twitter.com/davecheney/status/771688315573579778), the bar to entry for the standard library is very high.
I would ask for Dave to write a more formal design document and enter the proposal process, but I can say at this point that the likelihood of this happening is close to zero. I agree we should do something more about errors, but it's more of a Go2 item.
I'm going to close this for now.

Related to #15192

Agreed.
On Tue, Oct 25, 2016 at 9:16 AM, Brad Fitzpatrick<EMAIL_ADDRESS>wrote:

Closed #16968 https://github.com/golang/go/issues/16968.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/16968#event-834621901, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAAcA7Xfvb-5NKKempdFMSz_eFAld7Y1ks5q3S4sgaJpZM4JzrxI
.


✨ Dio.clone

New Pull Request Checklist

[ ] I have read the Documentation
[ ] I have searched for a similar pull request in the project and found none
[ ] I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
[ ] I have added the required tests to prove the fix/feature I'm adding
[ ] I have updated the documentation (if necessary)
[ ] I have run the tests without failures
[ ] I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

Independent of this PR, what do you think of making the Dio instance completely immutable in version 6?

Independent of this PR, what do you think of making the Dio instance completely immutable in version 6?

Yeah I like the idea, and I'm also exploring the path. The thing is Dio's structure makes pieces nested, we cannot fluently use Dio in cases of grouping usage. So going immutable might be a better path to improve the overall usability and readability.


Money after the 50% threshold reached is not paid after Destination Reached Properly

This is related to the "destination reached" flag not propagating to clients, and/or something else.

Reviewed and identified an issue with the method getPayCashTo in PlayerManager. Updated to work as expected.
For 1870 where there are Destinations, but companies are fully capitalized (like 1830), this should not be an issue


[4/5] Adding an object that tracks the scrolling state.

Pull Request Test Coverage Report for Build 24

63 of 65 (96.92%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 82.689%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

widgets/text/scroll.go
63
65
96.92%

Totals

Change from base Build 18:
0.5%

Covered Lines:
1605

Relevant Lines:
1941

💛  - Coveralls

Pull Request Test Coverage Report for Build 24

63 of 65 (96.92%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 82.689%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

widgets/text/scroll.go
63
65
96.92%

Totals

Change from base Build 18:
0.5%

Covered Lines:
1605

Relevant Lines:
1941

💛  - Coveralls

Pull Request Test Coverage Report for Build 24

63 of 65 (96.92%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 82.689%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

widgets/text/scroll.go
63
65
96.92%

Totals

Change from base Build 18:
0.5%

Covered Lines:
1605

Relevant Lines:
1941

💛  - Coveralls


Cannot install anything: "Could not automatically acquire pwsh"

Describe the bug
I cannot install any packages. All of them give me the error:
Could not automatically acquire pwsh because there is no entry in D:\source\test\vcpkg\scripts\vcpkgTools.xml for os=windows. You may be able to install pwsh via your system package manager.
Environment

OS: Windows 10 2004 (19041.572)
Compiler: Visual Studio 2019 16.7.6
vcpkg version: 2020.06.15-nohash

To Reproduce
Steps to reproduce the behavior:

mkdir test
cd .\test\
git clone https://github.com/microsoft/vcpkg.git
cd .\vcpkg\
.\bootstrap-vcpkg.bat
.\vcpkg.exe install fmt
This gives:

Computing installation plan...
The following packages will be built and installed:
    fmt[core]:x86-windows
Detecting compiler hash for triplet x86-windows...
Could not automatically acquire pwsh because there is no entry in D:\source\test\vcpkg\scripts\vcpkgTools.xml for os=windows. You may be able to install pwsh via your system package manager.

.\vcpkg.exe install mimalloc
This gives:

Computing installation plan...
The following packages will be built and installed:
    mimalloc[core]:x86-windows
Detecting compiler hash for triplet x86-windows...
Could not automatically acquire pwsh because there is no entry in D:\source\test\vcpkg\scripts\vcpkgTools.xml for os=windows. You may be able to install pwsh via your system package manager.

.\vcpkg.exe install ms-gsl
This gives:

Computing installation plan...
The following packages will be built and installed:
    ms-gsl[core]:x86-windows
Detecting compiler hash for triplet x86-windows...
Could not automatically acquire pwsh because there is no entry in D:\source\test\vcpkg\scripts\vcpkgTools.xml for os=windows. You may be able to install pwsh via your system package manager.

Expected behavior
I should be able to install things.

Will fixe in #14271. duplicate to #9606.


How to protect presign object?

Using refile with a s3 backend (store & cache)
I see that site.com/attachments/cache/presign returns a presign object (JSON) to everyone.

Is this secure?
Seems everyone could request the presign object, and upload to the cache backend.

How can I add authentication (pundit / cancancan) to this endpoint?

How can I customized the presign object? Adding acl, shorten expire time, etc

Thanks!!

@jnicklas I absolutely second first point, while if well configured cache backend will expire its content, it's still not advisable to allow everyone to upload what they want, especially when using S3 as backend since that will cost money.
Also I'd add point 1b to the previous list, i.e. one can upload to the cache whatever he wants by using (for instance) curl with
curl -XPOST -v localhost:3000/attachments/cache -F 'file=@Gemfile'

If for whatever reason cache folder is exposed in the public folder (a la carrierwave) this would be a serious issue.
I'd start to think to a default way of authenticate these kind of requests and to make the default authentication block to return false. In this way any refile user will need to think on how to authenticate upload requests.
Alternatively, since the upload endpoint is only needed for the javascript helper, I'd disable it by default.
What do you think?

@TangRufus here's a quick and dirty monkey patch to authenticate any upload request, put it into refile initializer and change the authentication logic to match your environment (I'm using Devise+CanCan with an AdminUser model)
module RefileUploadAuthentication

  # Redefine upload allowed, super is available because of Module#prepend
  def upload_allowed?
    super && can?(:create, Picture)
  end

  private

  # Mimic devise current user method and make it available in the above checks
  # @see https://github.com/hassox/warden/wiki/Authenticated-session-data
  def current_user
    warden = env['warden']
    warden.user if warden.authenticated?(:admin_user)
  end

  # Mimic CanCan helper for checking permissions
  def can?(*args)
    (@_ability ||= AdminAbility.load_ability(current_user)).can?(*args)
  end

end
# Patch refile app with the authentication method for upload
Refile::App.prepend(RefileUploadAuthentication)

"Secure" is pretty relative here. There is no way to exploit this maliciously other than uploading lots of files, which while costing you money isn't really terribly useful to an attacker. It's worth considering though that any kid of app where your users can sign up freely and access upload functionality inherently has the same problem. Adding authentication in that case does nothing. It's super easy to take the session cookie and copy it into the console and continue running CURL. The only kind of app where this matters is one where sign up is closed off. Given that lots of people build applications all the time which allow open sign ups and file uploads, it seems that they are comfortable with exposing upload functionality.
That being said, it seems doable to add the same kind of cryptographic protection that we already have for GET requests, which would probably still not be perfect, but better than the status-quo.
If you're not comfortable with this, it's pretty easy to disable this functionality entirely or to wrap it in some kind of other authentication scheme. If you have Warden anyway, why not wrap the Refile app in a middleware which does the authentication? Easier and more stable than monkey-patching the Refile app.
Regarding the third question, we don't currently provide any way of configuring the presign object, though I'd certainly be open to doing this kind of thing.

"Secure" is pretty relative here. There is no way to exploit this maliciously other than uploading lots of files, which while costing you money isn't really terribly useful to an attacker. It's worth considering though that any kid of app where your users can sign up freely and access upload functionality inherently has the same problem.

In my opinion there are two issues here:
The first is about all cms like applications where authenticated users provide content and guest users just read it. For these kind of applications a guest user should not be able to upload anything thus upload authentication is a must.
The second issue is about consequences of untrusted uploads, in the case of S3 backends, as already discussed earlier, it will cost money. With filesystem backends the upload endpoint may be used for a denial of service attack, a malicious user can potentially fill up an hard drive with lot of huge files taking down a server in minutes.

Adding authentication in that case does nothing. It's super easy to take the session cookie and copy it into the console and continue running CURL. The only kind of app where this matters is one where sign up is closed off. Given that lots of people build applications all the time which allow open sign ups and file uploads, it seems that they are comfortable with exposing upload functionality.

That's correct, it's pretty hard to limit uploads in a reliable (and generic) way, for this reason I think that a definitive solution to the issue does not belong to this gem. However refile gem should provide an extension point to allow the hosting application to enforce authentication and/or rate limiting.
A solution I like is the one provided by comfortable mexican sofa cms (which is in some way similar to the monkey patch above). They provide config accessors for authentication modules, default implementation which essentially is a noop for the public part, and finally they mix in the configured modules in their controllers.
In this way it would be easy for any hosting app to do whatever they want to protect uploads (and potentially downloads) in the context of the Refile::App having access to request, session and whatever.
What do you think? Would you accept a such pull request?

If you're not comfortable with this, it's pretty easy to disable this functionality entirely or to wrap it in some kind of other authentication scheme.

How to do that without monkey patching?

If you have Warden anyway, why not wrap the Refile app in a middleware which does the authentication? Easier and more stable than monkey-patching the Refile app.

That was my first thought, however devise authenticated constraint does not provide request in the block, only the user. If I constraint the whole refile application in an authenticated block then  unauthenticated user won't be able to see images because refile app contains all the endpoints including the download ones.

How to do that without monkey patching?

To disable (on master): Refile.allow_uploads_to = []
To wrap it in authentication, just create a middleware and wrap it around. You should be able to do pretty much the same you did in your monkey patch, only in a middleware.

I'm closing this issue for now. While it would be nice to add cryptographic authentication to these actions to protect them, doing so is outside of my expertise when it comes to crypto.
I think we'd have to design something similar to Amazon's own presign scheme, and I'm not confident I can get that right. If someone were to attempt to do this, I'd like to be confident that their cryptography skills are strong enough that they can design an implementation which is safe against possible side-channel attacks. This kind of crypto is a lot harder than the simple HMAC signature verification we do on GET requests.
I've created #352 to track that we should add some documentation on how to wrap the application in authentication middleware.


Fix muting bug with FXH parser

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
It adds a two line bug fix to an error Beatscribe and I found with the FX Hammer parser, the first NR51 write ignores the used/unused channels, thus muting the unused channel.

What is the current behavior? (You can also link to an open issue here)
If a sound effect only uses one channel, there's the chance the opposite channel will get muted via a null NR51 write.

What is the new behavior (if this is a feature change)?
A failsafe check for CH2Pan and CH4pan that ORs the necessary bits if CH2Pan or CH4Pan are 0.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.

Thanks @coffeevalenbat, merged now. Sorry it took me 10 months to get around to reviewing this!!


COAR Notify impossible to send/receive message from another DSpace

References
Add references/links to any related issues or PRs. These may include:

Fixes https://github.com/DSpace/DSpace/issues/9644
Requires DSpace/DSpace#9645

Description
This PR introduce important fixes in order to address https://github.com/DSpace/DSpace/issues/9644.
It also contains a porting of fixes for the suggestions page from DSpace-CRIS.
Instructions for Reviewers
List of changes in this PR:

Added 'announce-relationship' as supported pattern when configuring a LDN service
When configuring a LDN service the pattern is no longer mandatory
Improved LDN form by adjusting form button color following application guidelines
Renamed and reorganized suggestion data services
Fixed an issue in the suggestion page with pagination of the suggestion entries

Include guidance for how to test or review your PR.
Please refer to instructions present in the REST PR here https://github.com/DSpace/DSpace/pull/9645#issuecomment-2162953741.
Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

thanks @tdonohue
changes applied

Merging, however this is flagged as needs documentation because we need to document how to send messages between DSpace instances using COAR Notify, perhaps in a new page under https://wiki.lyrasis.org/display/DSDOC8x/COAR+Notify


trunk: 0.17.2 -> 0.18.0

Description of changes
fixes https://github.com/NixOS/nixpkgs/issues/274133
https://github.com/trunk-rs/trunk/releases/tag/v0.18.0
https://github.com/trunk-rs/trunk/compare/v0.17.2...v0.18.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 274304 run on x86_64-linux 1

1 package built:

trunk

duplicate of https://github.com/NixOS/nixpkgs/pull/273792   but there are useful changes in both PRs

@marsam I believe Darwin build was still broken. Or has it been fixed?

I think it's better to handle in another PR, since kashw2 might not have access to a darwin machine https://github.com/NixOS/nixpkgs/pull/275119