RSpec/DescribedClass mis-identifies inside of rspec-rails anonymous controllers

Versions:

rubocop — 0.74.0
rubocop-rspec — 1.34.1

RSpec/DescribedClass will correct code like this:
RSpec.describe SomeConcern, type: :controller do
  controller(ApplicationController) do
    include SomeConcern
  end
  ...
end

to this:
RSpec.describe SomeConcern, type: :controller do
  controller(ApplicationController) do
    include described_class
  end
  ...
end

Resulting in this error:
An error occurred while loading ./spec/controllers/concerns/some_concern.rb.
Failure/Error: include described_class

NameError:
  undefined local variable or method `described_class' for #<Class:0x000056272150a908>
  Did you mean?  descendants

For reference, please see https://relishapp.com/rspec/rspec-rails/v/3-8/docs/controller-specs/anonymous-controller

Thanks for reporting, I'll take a look.

It works fine for some blocks, so I'd rather not make any code changes:
class A
  def self.described_class
    'A'
  end

  def self.y(&block)
    block.call
  end

  y do
    puts self # => A
    puts described_class # => A
  end

  def self.x(&block)
    Class.new(&block)
  end

  x do
    puts self # => #<Class:0x00...
    puts described_class # fails
  end
end

There's no way to statically determine what kind of block it is.
It's a known caveat, and there's a configuration option to work this around, SkipBlocks:
RSpec/DescribedClass:
  SkipBlocks: true

I suggest you add a .rubocop.yml file with this snippet above only, and put it to a directory where the specs for controller concerns reside. That should solve the issue you're experiencing and will keep the detection for rest of the code base intact.
Please let me know if it works for you, @benhutton, @anthony-robin.

Thanks @pirj ! The SkipBlocks: true option solved offenses I had 👍

@benhutton Did adding a directory-local RuboCop configuration file solve the issue you're experiencing?

@pirj right now, I'm preferring to use a single-line # rubocop:disable comment to get things working. Maybe I'm being too greedy. I think in general this cop is doing great stuff and wish there was a way it could be made smarter! I wonder if adding a block blacklist configuration would make sense? That way, we can tell it to ignore controller do blocks and nothing else (until that becomes necessary). My guess is that MOST blocks work correctly and a select few cause problems.

@benhutton Unfortunately, there's no other way to set configuration options per-directory right now.
You mean that situation when in a controller test there a non-controller do block that is using a class name instead of described_class, and you'd like to detect it?
Do you think it is worth it?
Speaking of described_class, you might be interested in an ongoing discussion.

@pirj I'm not talking about configuring per-directory. I'd do it globally.
That discussion is interesting. And I think this adds an interesting detail: you can't even actually use described_class consistently / all the time.
That said, I don't do the things that make it hard to use. It always works for me (except in these controller specs!). So I would probably keep it around. Maybe with a described_module alias.
For this particular cop, it feels really tricky, right? The cop cannot do what it purports to do reliably. So it's unsafe. So maybe I would disable the whole cop by default and then go with the SkipBlocks option you have now, and maybe some other knobs, to try to get it working flexibly? I suppose it really depends on how decisions like this get made for other cops with similar caveats...

The mention of controller do caveat is in cop's documentation.
As far as I know, it's a common way to configure cops in directories.
There is a TODO to mark this cop as "Unsafe to autocorrect" on cop metadata roadmap.
Is there anything that can be done in the scope of this ticket, @benhutton ?

@pirj from what I can tell, the caveat is in the cop's specs, not in the actual docs (https://rubocop-rspec.readthedocs.io/en/latest/cops_rspec/#rspecdescribedclass). Thus, it's a known and tested-for caveat, but not one that is well-communicated to users. So I'd say that the safest thing to do would be to enhance the docs clarifying why the skip blocks option exists and when/how to use it?

Fair enough. I was completely sure that it was in the docs, I've definitely seen it somewhere, my bad, and please accept my apologies.
Please take a look #802, @benhutton. Do you think this would be enough to avoid confusion?
Just for history: #59

yes! that is great! thanks so much @pirj


shorter mixin imports?

What do folks think of changing the imports from this:
import ComponentQueryManager from "ember-apollo-client/mixins/component-query-manager";

to this:
import { ComponentQueryManager } from "ember-apollo-client/mixins";

or even this:
import { ComponentQueryManager } from "ember-apollo-client";

IMO that's a big improvement. Any objections?

The last one, for me. But it would come in a major version, right?

Or have both and deprecate the old one.

Yes, #145 will probably be a breaking change anyway. Although it would be good to introduce the new import paths in a 1.x release and also deprecate the old ones to allow for a cleaner migration.
If anybody wants to take a stab at this before I get to it, please do! :pray:

I took care of adding the new imports, but I would also like to deprecate the old ones (prior to any 2.x betas that include ember-auto-import). Could use help with that part.


Openvino android

Add demo app that can build with android studio.

@wistal, thanks!
Is it possible to remove all the generated files and just add a guide of how to initialize them by Android Studio?


Fix tls in xmpp by setting ServerName

Fixes error message shown by tls: "either ServerName or InsecureSkipVerify must be specified in the tls.Config"

Thanks for the fix!


Rename to flask-allows-2?

Hi, do you guys think that it's possible to republish this under flask-allows-2?
Rationales:

Original repository is archived.
Since it's used in production and you should not use git links as a pypi dependency.
Its easier to update.

At the moment I don't want to maintain another dependency (outside of FlaskBBs scope) and deal with all those maintainance stuff. For now, I'll try to fix stuff so that FlaskBB runs again. My time is very limited at the moment and I am just trying to get back into it. My priority now is to get everything updated and running again.
Maybe someone else can pick it up? Before creating a hard fork, maybe @justanr can add another maintainer to its repo if someone is willing to maintain it :)

I'm happy to turn over the pypi package name, but I'd rather not resurrect the repository under my personal account.


master_discovery memory leak

I'm using the latest master version compiled on NVidia Jetson TX2, TX2i and NX.
All three boards run on Ubuntu 18.04 LTS.
The longer the master_discovery service runs the more memory it needs.
I suspect it has a memory leak!

I run some tests with five ROS-Master's (five master_discovery, five master_sync and one node_manager) on Ubuntu 18.04.
I record the memory usage with psrecord.
With no changes on ROS-Master the memory usage increases slowly (almost an hour) until an upper limit (60MB)

With a ROS-Node stop/start every 5 seconds the limit of 60 MB is reached faster and stay at this level.

I don't know exactly what the reason for the increase is at the beginning and whether it can be fixed at all.

I now upgraded to Ubuntu 20.04 LTS and ROS noetic
After a couple of days it increases from 40MiB to 140MiB

Any progress on this?
Please re-open it.


API — Change WelcomeBot Behaviour

At the moment, WelcomeBot will send messages to the Global stream as soon as a new account is created. Given how few new accounts actually use the service to write a single post, it would make sense to change this functionality to be a little more useful.
To this end, WelcomeBot needs to change to do the following things:

Send a welcome message after a person publishes their first post, regardless of type
Send a "welcome back" message after a person publishes their first post after a set period of days

Done and done. The operation is looking pretty good and existing accounts have had their AccountMeta information updated ahead of time to ensure that WelcomeBot wasn't spamming everyone with unnecessary welcome messages.
Closing Ticket.

Done and done. The operation is looking pretty good and existing accounts have had their AccountMeta information updated ahead of time to ensure that WelcomeBot wasn't spamming everyone with unnecessary welcome messages.
Closing Ticket.


bug: the file  .../nvim/runtime/filetype.lua runs twice

Did you check docs and existing issues?

[X] I have read all the lazy.nvim docs
[X] I have searched the existing issues of lazy.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.1
Operating system/version
Linux
Describe the bug
I found a strange behavior when i looked at a nvim starting log (--startuptime flag). For some reason the file filetype.lua sourced twice.
Steps To Reproduce
Just run nvim with lazy
Expected Behavior
The file  .../nvim/runtime/filetype.lua runs once
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

Which is fine?
Lazy loads filetype.lua since some plugins depend on it.
Neovim also loads filetype.lua at a later stage.
Check the source code of filetype.lua. It won't do its thing twice

Yeah, that's right. It just was a little unexpected...


feat: add .ipynb for adding and updating models to ollama

Hey! Maybe we can keep this internal if only to be used to add and update models within ollama? Otherwise I think we're good with making this a Python script instead and parametrize it to allow for future versions, rather than a Jupyter Notebook IMO 👍🏻

@dvsrepo

@leiyre looks good but maybe we can align the fonts a bit better with each other?
I feel the things in the markdown are a lot larger. And we have another message about what Argilla is "a platform to build high-quality AI datasets". Maybe we can skip this because we are using a lot of these different messages in a lot of different places.
For me, it might also be nicer to show all text + argilla logo within the same white block and align everything to the left, but I leave that up to you :)

Ooops @davidberenstein1957 I'm afraid that the messages above are not related to Notus and should be moved to https://github.com/argilla-io/argilla instead 🙁 I think that was your original intention and probably those were pasted here by mistake?


It doesn't work.

Title.

Yes it does.

# # # # #

[****]([url]([url](

`[1. url](

url

)`
)))


Error while running compute_fbank_aishell.py

Hi, while reproducing the Aishell egs, I get the following error. Any ideas what am I doing wrong? Thanks
2022-04-04 13:40:17 (prepare.sh:58:main) stage 0: Download data
2022-04-04 13:40:17 (prepare.sh:89:main) Stage 1: Prepare aishell manifest
2022-04-04 13:40:19 (prepare.sh:100:main) Stage 2: Prepare musan manifest
2022-04-04 13:40:19 (prepare.sh:104:main) It may take 6 minutes
2022-04-04 13:41:34,837 WARNING [qa.py:116] There are 15 recordings that do not have any corresponding supervisions in the SupervisionSet.
2022-04-04 13:43:15 (prepare.sh:112:main) Stage 3: Compute fbank for aishell
2022-04-04 13:43:17,119 INFO [compute_fbank_aishell.py:67] Processing train
2022-04-04 13:43:17,120 INFO [compute_fbank_aishell.py:79] extractor=<lhotse.features.kaldi.extractors.Fbank object at 0x7fb6bd62b940>, storage_path=data/fbank/feats_train, num_jobs=15 if None is None else 80, executor=None, storage_type=LilcomHdf5Writer
Traceback (most recent call last):
File "./local/compute_fbank_aishell.py", line 111, in
compute_fbank_aishell(num_mel_bins=args.num_mel_bins)
File "./local/compute_fbank_aishell.py", line 86, in compute_fbank_aishell
storage_type=LilcomHdf5Writer,
File "/usr/local/lib/python3.6/dist-packages/lhotse/cut.py", line 4483, in compute_and_store_features
cut_sets = self.split(num_jobs, shuffle=True)
File "/usr/local/lib/python3.6/dist-packages/lhotse/cut.py", line 3635, in split
self, num_splits=num_splits, shuffle=shuffle, drop_last=drop_last
File "/usr/local/lib/python3.6/dist-packages/lhotse/utils.py", line 334, in split_sequence
f"Cannot split iterable into more chunks ({num_splits}) than its number of items {num_items}"
ValueError: Cannot split iterable into more chunks (15) than its number of items 0

Did you make any changes to local/compute_fbank_aishell.py?
The error log

ValueError: Cannot split iterable into more chunks (15) than its number of items 0

says that your cut_set is empty. Can you post the output print(cut_set)?
You can put it just before the following line
https://github.com/k2-fsa/icefall/blob/87cf9231ea73631f1e4453400b3be06d45bcebf5/egs/aishell/ASR/local/compute_fbank_aishell.py#L78

2022-04-04 13:40:17 (prepare.sh:89:main) Stage 1: Prepare aishell manifest
2022-04-04 13:40:19 (prepare.sh💯main) Stage 2: Prepare musan manifest

Are you using the latest master? Also, the log shows that your State 1 took only 2 seconds, which is unexpected.
Can you show the output of
ls -lh data/manifests/

It should print something as follows:
-rw-r--r-- 1 kuangfangjun root 5.2M Mar  8 20:20 recordings_dev.json
-rw-r--r-- 1 kuangfangjun root 234K Mar  8 20:20 recordings_music.json
-rw-r--r-- 1 kuangfangjun root 341K Mar  8 20:20 recordings_noise.json
-rw-r--r-- 1 kuangfangjun root 155K Mar  8 20:20 recordings_speech.json
-rw-r--r-- 1 kuangfangjun root 2.6M Mar  8 20:20 recordings_test.json
-rw-r--r-- 1 kuangfangjun root  44M Mar  8 20:19 recordings_train.json
-rw-r--r-- 1 kuangfangjun root 4.2M Mar  8 20:20 supervisions_dev.json
-rw-r--r-- 1 kuangfangjun root 170K Mar  8 20:20 supervisions_music.json
-rw-r--r-- 1 kuangfangjun root 2.1M Mar  8 20:20 supervisions_test.json
-rw-r--r-- 1 kuangfangjun root  35M Mar  8 20:19 supervisions_train.json

My data directory only has the download folder in it, which contains the downloaded musan and aishell folders, together with the lm.
drwxr-xr-x.  3 root root  22 Apr  4 13:40 ./
drwxr-xr-x. 11 root root 330 Apr  4 13:40 ../
drwxr-xr-x.  3 root root  44 Apr  4 13:40 download/

These are the commands in my run.sh.
cd egs/aishell/ASR
export LC_ALL=C.UTF-8
export LANG=C.UTF-8
./prepare.sh
./conformer_ctc/train.py --num-epochs 10
./conformer_ctc/decode.py --method 1best --max-duration 100

My data directory only has the download folder in it

There should be no download directory inside data. download should be in the same folder as ./prepare.sh.
Could you post the output of ls -lh ./download/*? I suspect that you have not downloaded the data yet.

I put the data in dl_dir: /workspace/icefall/data/download

Could you show the changes you made to prepare.sh?

line 31: dl_dir=/workspace/icefall/data/download

By default, the script is run using the following commands
cd egs/aishell/ASR
./prepare.sh

and it generates files in ./data and ./download.  You can select a different directory for download by changing dl_dir in prepare.sh, but the folder for data is fixed.
From the output of /workspace/icefall/egs/aishell/ASR/data/manifests, it looks like everything goes as expected.
Do you still have the above errors?

Oh, wait.
-rw-r--r--. 1 root root 2 Apr 4 14:55 recordings_test.json
-rw-r--r--. 1 root root 2 Apr 4 14:55 recordings_train.json
-rw-r--r--. 1 root root 2 Apr 4 14:55 supervisions_test.json
-rw-r--r--. 1 root root 2 Apr 4 14:55 supervisions_train.json

this does not look right.
Can you check that /workspace/icefall/data/download contains the folders described below?
https://github.com/k2-fsa/icefall/blob/87cf9231ea73631f1e4453400b3be06d45bcebf5/egs/aishell/ASR/prepare.sh#L13-L16

This is inside aishell
drwxr-xr-x. 4 1682 500  62 Mar 30 17:03 ./
drwxr-xr-x. 4 1682 500 130 Mar 31 18:50 ../
drwxr-xr-x. 4 1682 500  47 Jun 16  2017 data_aishell/
drwxr-xr-x. 2 1682 500  57 Jun 21  2017 resource_aishell/
and this is inside musan
drwxr-xr-x. 5 1682 500   80 Nov 16  2015 ./
drwxr-xr-x. 4 1682 500  130 Mar 31 18:50 ../
-rwxr-xr-x. 1 1682 500 1765 Oct 30  2015 README*
drwxr-xr-x. 7 1682 500  128 Oct 30  2015 music/
drwxr-xr-x. 4 1682 500   73 Oct 30  2015 noise/
drwxr-xr-x. 4 1682 500   66 Oct 30  2015 speech/

The reason for the error is that you have empty manifest files for aishell, Your following files are actually empty.
-rw-r--r--. 1 root root 2 Apr 4 14:55 recordings_test.json
-rw-r--r--. 1 root root 2 Apr 4 14:55 recordings_train.json
-rw-r--r--. 1 root root 2 Apr 4 14:55 supervisions_test.json
-rw-r--r--. 1 root root 2 Apr 4 14:55 supervisions_train.json

You can step into the following code
https://github.com/k2-fsa/icefall/blob/87cf9231ea73631f1e4453400b3be06d45bcebf5/egs/aishell/ASR/prepare.sh#L87-L96
to see what went wrong.
You have to delete data/manifests/.aishell_manifests.done before going forward.

I even ran lhotse prepare aishell $dl_dir/aishell data/manifests directly but the above files are still empty.

You can see breakpoints in https://github.com/lhotse-speech/lhotse/blob/master/lhotse/recipes/aishell.py#L72
and to debug it.
For instance, change
    corpus_dir = Path(corpus_dir)
    assert corpus_dir.is_dir(), f"No such directory: {corpus_dir}"

to
    import pdb
    pdb.set_trace()
    corpus_dir = Path(corpus_dir)
    assert corpus_dir.is_dir(), f"No such directory: {corpus_dir}"

When you run lhotse prepare aishell $dl_dir/aishell data/manifests, it will enter pdb, you can try to find what is wrong.

The issue was that I had forgotten to unzip the tar files inside aishell/data_aishell/wav/
After that, the manifests got generated (with some warnings about some missing transcripts) and now it's computing fbank. Thanks a lot for your help! :)

Sorry, my bad. I encountered such an issue before, and fixed it here (https://github.com/lhotse-speech/lhotse/pull/388). But I forgot to change if condition in prepare.sh. see https://github.com/k2-fsa/icefall/pull/291.


Maven plugin prints (but does NOT fail due to) a ClassNotFoundException: org.apache.commons.io.file.PathUtils

(This message has been edited from an originally wrong interpretion of cause and effect.)
The mariaDB4j-maven-plugin prints the following:
    [INFO] [INFO] --- mariaDB4j-maven-plugin:2.5.0:stop (post-integration-test) @ start-stop ---
    [INFO] [INFO] Stopping MariaDB4j...
    [INFO] [INFO] Program [/tmp/MariaDB4j/base/bin/mysqld, --no-defaults, --console, --skip-grant-tables, --max_allowed_packet=64M, --basedir=/tmp/MariaDB4j/base, --datadir=/tmp/MariaDB4j/data/42757, --port=42757, --socket=/tmp/MariaDB4j.42757.sock] (in working directory /tmp/MariaDB4j/base) just exited, with value 0
    [INFO] [INFO] Successfully destroyed Program [/tmp/MariaDB4j/base/bin/mysqld, --no-defaults, --console, --skip-grant-tables, --max_allowed_packet=64M, --basedir=/tmp/MariaDB4j/base, --datadir=/tmp/MariaDB4j/data/42757, --port=42757, --socket=/tmp/MariaDB4j.42757.sock] (in working directory /tmp/MariaDB4j/base)
    [INFO] [INFO] Database stopped.
    [INFO] [INFO] ------------------------------------------------------------------------
    [INFO] [INFO] BUILD SUCCESS
    [INFO] [INFO] ------------------------------------------------------------------------
    [INFO] [INFO] Total time:  5.672 s
    [INFO] [INFO] Finished at: 2021-11-28T22:21:48+01:00
    [INFO] [INFO] ------------------------------------------------------------------------
    [INFO] [INFO] cleanupOnExit() ShutdownHook quietly deleting temporary DB data directory: /tmp/MariaDB4j/data/42757
    [INFO] Exception in thread "Shutdown Hook Deletion Thread for Temporary DB /tmp/MariaDB4j/data/42757" java.lang.NoClassDefFoundError: org/apache/commons/io/file/PathUtils
    [INFO]      at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1341)
    [INFO]      at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:324)
    [INFO]      at org.apache.commons.io.FileUtils.deleteQuietly(FileUtils.java:1236)
    [INFO]      at ch.vorburger.mariadb4j.DB$1.run(DB.java:474)
    [INFO] Caused by: java.lang.ClassNotFoundException: org.apache.commons.io.file.PathUtils
    [INFO]      at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
    [INFO]      at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
    [INFO]      at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247)
    [INFO]      at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
    [INFO]      ... 4 more

This should be made to not appear only on mvn release:prepare, but for every mvn package, so that whatever PR broke this (possibly #477 or #478 or #482 or #483 today) would fail to pass CI for this to be noticed much earlier.
@robin-xyzt-ai given your interest in the Maven Plugin in #476, would you be willing to contrib. a PR for this?
This blocks #334.

The error above actually does not block or have anything to do with mvn release:prepare (only #TBD does); it also appears when running mvn verify (or just using the plugin in another project, presumably).
This must be some issue with MariaDB4j fixing commons-io to version 2.4.1... but #491 doesn't fix it either.

This should be made to not appear only on mvn release:prepare, but for every mvn package

That's just because Travis runs mvn package which does not include ITs that are only part of verify. I've changed that in #490, and Travis currently still passes - and shows Build Summary: Passed: 3, Failed: 0, Errors: 0, Skipped: 0.
PS: #489 does not seem to fix this error.

See also #207 for some history about this.

@vorburger I googled a bit and bumped into this issue. It sounds like there are workarounds but they are brittle and ugly.
I would propose for this issue to either:

Replace that call to FileUtils#deleteQuietly with calls using only the classes in the standard JDK (basically inlining the code behind that call)
Or, if you want to keep using FileUtils#deleteQuietly as that behavior is tested, wrap that call with a try-catch, and do our own cleanup using standard JDK classes in case of the ClassNotFoundException. That way, we only trigger the new code path in tests and not in production.

I can probably provide a PR with the above approach. If you don't like this approach, I'm gonna pass for this issue. Just like you, I don't fancy digging into Maven-related classloading.

bumped into this issue

Interesting, thanks for having searched and sharing the finding!

Replace that call to FileUtils#deleteQuietly with calls using only the classes in the standard JDK (basically inlining the code behind that call)

I like that, that's probably the simplest and clearest solution.
If by inline you essentially mean "copy/paste Apache Commons IO's implementation" then it's not even particularly "risky" anyway.

Or, if you want to keep using FileUtils#deleteQuietly as that behavior is tested, wrap that call with a try-catch, and do our own cleanup using standard JDK classes in case of the ClassNotFoundException. That way, we only trigger the new code path in tests and not in production.

That's perhaps overly cautious, and only confusing for maintenance. Also I suspect (but have not personally tested) that this problem actually doesn't just affect the Maven plugin's integration test, but even real world usage of the plugin in full projects? Because if this ONLY shows up during the local build of MariaDB4j itself due to some Classloader issues in Maven Plugin integration tests themselves, but not when using MariaDB4j Maven plugin as an end-user, then perhaps it's less of a priority alltogether.

I can probably provide a PR with the above approach.

Go for it, I'd be happy to review and merge a PR about this.

To my surprise, creating my own FileUtils class which contains all the necessary code just results in
[INFO] Exception in thread "Shutdown Hook Deletion Thread for Temporary DB /tmp/MariaDB4j/data/46521" java.lang.NoClassDefFoundError: ch/vorburger/mariadb4j/FileUtils
[INFO]  at ch.vorburger.mariadb4j.DB$1.run(DB.java:474)
[INFO] Caused by: java.lang.ClassNotFoundException: ch.vorburger.mariadb4j.FileUtils
[INFO]  at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
[INFO]  at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
[INFO]  at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247)
[INFO]  at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)

There clearly isn't much what you can do in a shut down hook. Perhaps it works if I put all the code in a single file,

Oh if the fact that it's called from a Shutdown Hook is the real issue here
(sorry I hadn't entirely grasped that earlier), then perhaps the best
approach is simply to make our Maven Plugin here use MariaDB4j without a
Shutdown Hook at all (I can't remember if the Builder has something to
prevent it, but you could add it), and instead ensure that some Maven
Lifecycle stop kind of event stops the DB server explicitly "at the right
time" (whatever that means exactly)?

The shutdownhook is installed in a protected method of a non-final class with a protected constructor (DB#cleanupOnExit).
As such, people could have created an instance of this class and rely on this method. The documentation even states that it will install a shutdown hook.
Anyway, by being creative I managed to put all the code in a single class, and that seems to get rid of the stacktrace.
That class:

Contains the actual shutdown hook code. You'll see some suppliers in the constructor to pass in non-final fields.
Contains all the file deletion code copied from Apache (not a 100% literal copy as I removed some code paths which we didn't trigger)
Implements FileVisitor as I needed a FileVisitor, and I could not use an inner/anonymous class without bumping into the same issue.

I'll create the PR immediately. Feel free to reject it if you think that instead we need to get rid of the shutdown hook.

Feel free to reject it if you think that instead we need to get rid of the shutdown hook.

Whatever works!
Thanks again.


esp-thread-br router build fails with Errors. (TZ-197)

Target hardware: The Wi-Fi based ESP Thread Border Router consists of two SoCs:
Host: Raspberry Pi 4 8GB on Ubuntu 20.04 LTS 64 bit.
Followed the exact steps detailed here: https://docs.espressif.com/projects/esp-thread-br/en/latest/esp32/dev-guide/build_and_run.html
Succesfully completed  until :
esp-idf/examples/openthread/ot-rcp
idf.py --preview set-target esp32h2
idf.py menuconfig
idf.py build
Encountered the below error while building the esp-thread-br.
cd esp-thread-br/examples/basic_thread_border_router
idf.py menuconfig
idf.py build
The build step failed with below errors. Please check the attachment for the complet logs.
Question: Is there a working code that I can simply build and flash it to the board? Is there any specific commits that is 100% working?
**_```
home/pi/esp/esp-thread-br/examples/basic_thread_border_router/managed_components/espressif__esp_ot_cli_extension/src/esp_ot_iperf.c: In function 'esp_ot_process_iperf':
/home/pi/esp/esp-thread-br/examples/basic_thread_border_router/managed_components/espressif__esp_ot_cli_extension/src/esp_ot_iperf.c:33:8: error: 'iperf_cfg_t' has no member named 'format'
33 |     cfg.format = KBITS_PER_SEC;
|        ^
/home/pi/esp/esp-thread-br/examples/basic_thread_border_router/managed_components/espressif__esp_ot_cli_extension/src/esp_ot_iperf.c:33:18: error: 'KBITS_PER_SEC' undeclared (first use in this function)
33 |     cfg.format = KBITS_PER_SEC;
|                  ^~~~~~~~~~~~~
/home/pi/esp/esp-thread-br/examples/basic_thread_border_router/managed_components/espressif__esp_ot_cli_extension/src/esp_ot_iperf.c:33:18: note: each undeclared identifier is reported only once for each function it appears in
/home/pi/esp/esp-thread-br/examples/basic_thread_border_router/managed_components/espressif__esp_ot_cli_extension/src/esp_ot_iperf.c:112:32: error: 'iperf_cfg_t' has no member named 'format'
112 |                             cfg.format = idx;
|                                ^
/home/pi/esp/esp-thread-br/examples/basic_thread_border_router/managed_components/espressif__esp_ot_cli_extension/src/esp_ot_iperf.c:117:65: error: 'iperf_cfg_t' has no member named 'format'
117 |                 otCliOutputFormat("f:%sbit/s\n", strcmp(unit[cfg.format], "B") == 0 ? "\0" : unit[cfg.format]);
|                                                                 ^
/home/pi/esp/esp-thread-br/examples/basic_thread_border_router/managed_components/espressif__esp_ot_cli_extension/src/esp_ot_iperf.c:117:102: error: 'iperf_cfg_t' has no member named 'format'
117 |                 otCliOutputFormat("f:%sbit/s\n", strcmp(unit[cfg.format], "B") == 0 ? "\0" : unit[cfg.format]);
|                                                                                ^
[1148/1183] Building C object esp-idf/espressif__esp_ot_cli_extension/CMakeFiles/__idf_espressif__esp_ot_cli_extension.dir/src/esp_ot_udp_socket.c.objFAILED: esp-idf/espressif__esp_ot_cli_extension/CMakeFiles/__idf_espressif__esp_ot_cli_extension.dir/src/esp_ot_udp_socket.c.obj

Also,

**_```
/home/pi/esp/esp-thread-br/examples/basic_thread_border_router/managed_components/espressif__esp_ot_cli_extension/src/esp_ot_udp_socket.c: In function 'esp_ot_process_mcast_group':
/home/pi/esp/esp-thread-br/examples/basic_thread_border_router/managed_components/espressif__esp_ot_cli_extension/src/esp_ot_udp_socket.c:481:5: error: implicit declaration of function 'esp_openthread_task_switching_lock_release' [-Werror=implicit-function-declaration]
  481 |     esp_openthread_task_switching_lock_release();
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/pi/esp/esp-thread-br/examples/basic_thread_border_router/managed_components/espressif__esp_ot_cli_extension/src/esp_ot_udp_socket.c:496:5: error: implicit declaration of function 'esp_openthread_task_switching_lock_acquire' [-Werror=implicit-function-declaration]
  496 |     esp_openthread_task_switching_lock_acquire(portMAX_DELAY);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
[1149/1183] Building C object esp-idf/espressif__esp_ot_cli_extension/CMakeFiles/__idf_espressif__esp_ot_cli_extension.dir/src/esp_ot_ip.c.objninja: build stopped: subcommand failed.
HINT: Please check that the function name is correct. Also it is possible that you've forgot to import esp_openthread_task_switching_lock_release library(s) in header file or add the necessary REQURIES component. Try to add missing libraries to your project header file or check idf_component_register(REQUIRES ...) section in your component CmakeList.txt file. For more information run 'idf.py docs -sp api-guides/build-system.html'.
Also, please check if the function has been removed, renamed or replaced by an alternative function - refer to the migration guide for more information.
ninja failed with exit code 1, output of the command is in the /home/pi/esp/esp-thread-br/examples/basic_thread_border_router/build/log/idf_py_stderr_output_35298 and /home/pi/esp/esp-thread-br/examples/basic_thread_border_router/build/log/idf_py_stdout_output_35298
```_**

[tbr_failed.txt](https://github.com/espressif/esp-thread-br/files/12100290/tbr_failed.txt)

@topraveenpaul Seems you were using an old IDF version, could you fetch the latest IDF master branch and try again. Feel free to comment if any further issues.

@chshu . Thank you for your response. Yes, it works after I feteched from the master. I will close the issue now.


Use of tailwind-merge

The library currently lacks a way to customize the components classes.
It would be great to use tailwind-merge like flowbite-react and flowbite-svelte did in my opinion. What do you think?

@LockBlock-dev from what I could see, you can set all the tw classes you want to use to customize a component as !important.
Example
<Navbar class="!bg-pink-300 !text-yellow-300">
   // ... content
</Navbar>

Would give you what you'd expect:

It's not a great solution, there are drawbacks, but it would allow you customize the components until / without tailwind-merge.


Tizen TV app no HTTP sample

Hello no HTTP calls are working even with http://tizen.org/privilege/internet
this will fail:
  HttpClient client;
  var uri = new Uri("https://samples.openweathermap.org/data/2.5/weather?q=London,uk&appid=b6907d289e10d714a6e88b30761fae22"));
  client = new System.Net.Http.HttpClient();
  var response = await client.GetAsync(uri);

Hello, Delaire
Could you let us know more detailed information?
Emulator or Target?
Mobile or TV or Wearable?
4.0 or 5.0?
thanks in advance

Hello @sgchoi5 its Tizen TV , target framework tizen 5 using the emulator tv-samsung-5.0-x86
https://www.dropbox.com/s/cwzh4jz3565xk2m/TizenXamlApp1.zip?dl=0
Emualtor details:
https://i.imgur.com/CKzbefS.png

Hi @Delaire
I prepare  Http sample app for TV.
It works on samsung-tv 5.0 emulator.
(Emulator binary's build information : tizen_20190411.1652408)
I cannot reproduce your error case.
Could you try to test this app on your side?
It also works well when I test your uri + my api key in TizenTVHttpSample app. (screenshot)
BTW, about emulator binary's build info, you can check it using Tizen.System.Information API.
(sample code is here : 46 to 49 lines of MainPageModel.cs )

Thank you for the quick response.
So I don't have the latest build, here is what I have:
BuildInfo: "tizen_20181210.1228946"
BuildDate : "20181210_063435"
I would have thought that the emulator manager app would have told me if a new TV emulator build was available. Your current solution also fails with the emulator that I have.
Ill update my emulator and see if this works and post back here.

Could you reinstall 5.0 TV(Main SDK) and TV Extension-5.0(Extension SDK) through Tizen Studio Package Manager? After then, please try it again.

I have update the SDK with Package Manager and you code is working. Thank you for your help!


Remove and replace line 16 & 18 on header.html to adhere to project standard

https://www.hawaii.edu/jira/browse/GROUPINGS-844

There are plans to resolve the reported conflicts?

There are plans to resolve the reported conflicts?

Yes, it is a simple fix.


build(deps): change sqlite3 to vscode version

Signed-off-by: Jytesh<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.8%) to 98.038%

Totals

Change from base Build<PHONE_NUMBER>:
0.8%

Covered Lines:
1237

Relevant Lines:
1253

💛  - Coveralls


During CLI updation problem facing

Hello,
We have update angular CLI version and node version so on running project we got some errors and we are using WebStrom in that whenever I open my project that time only opened files not displaying any folders. and when I am installing npm and CLI that time I am facing error like below.
 npm ERR! Linux 4.4.0-63-generic
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
npm ERR! node v7.4.0
npm ERR! npm  v4.0.5
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: `ng serve`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'ng serve'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the vadtal-cli package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     ng serve
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs vadtal-cli
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls vadtal-cli
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /var/www/sampleproject/public/vadtal_upgradation/npm-debug.log

And whenever I am updating npm

npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

We are using Ubutnu OS.
Ubutnu Version 16.04 LTS
Node Version : 7.4.0
npm Version : 4.0.5
We are using 3 laptops with same configurations but in one system working fine other two are facing same issue.
Thanks

@aminsmartsense
Please follow below step for resolve your issue

First you need to update node sudo n stable
Install letest CLI npm install -g angular-cli
clone your project or create your project
npm install
If any error accrued then remove node_module
npm install
Install Typescript npm install typescript -g

If any module not install please try with sudo.

@smartHasmukh Working fine..
Thanks


Is it possible to officially upgrade to Qt6 & PySide6?

I see the App is developed by Qt5 & PySide2, I tried to upgrade to Qt6 & PySide6, but failed.
Is it possible to officially upgrade to Qt6 & PySide6?

Ryven uses QtPy as wrapper to seamlessly switch between APIs. QtPy meanwhile has PySide6 support, you can call Ryven from python with ryven.run_ryven(qt_api='pyside6'), tough it won't work yet as PySide6 changes some imports etc. but it might be easy to add those changes to the code.

closed in https://github.com/leon-thomm/Ryven/releases/tag/v3.5.0
you can now use Python 3.11 with PySide6<6.7 pip install 'pyside6<6.7'
note that the default is still PySide2, just run ryven -q pyside6


Setting bottle.BaseRequest.MEMFILE_MAX does not affect tornado.httpserver.HTTPServer max_body_size

I'm trying to send a multipart/form-data request to a bottle service that is using the tornado server.  I set bottle.BaseRequest.MEMFILE_MAX=1048576000 in my instance and bottle does not complain about the size of the request.  However, the size of the body exceeds tornado's default value of 104857600, so tornado returns a HTTP 413 error
Malformed HTTP message from <IP_ADDRESS>: Content-Length too long

Is there any way to make bottle.BaseRequest.MEMFILE_MAX propagate through to the instance of tornado.httpserver.HTTPServer that is instantiated in bottle.TornadoServer?
class TornadoServer(bottle.TornadoServer):
    """ The super hyped asynchronous server by facebook. Untested. """
    def run(self, handler): # pragma: no cover
       import tornado.wsgi, tornado.httpserver, tornado.ioloop
       container = tornado.wsgi.WSGIContainer(handler)
       server = tornado.httpserver.HTTPServer(container) # <- Line to change below
       server.listen(port=self.port,address=self.host)
       tornado.ioloop.IOLoop.instance().start()

Passing the max_body_size when instantiating tornado.httpserver.HTTPServer resolves my issue:
server = tornado.httpserver.HTTPServer(container, max_body_size=1048576000)

Is there any way to do this from bottle's interface?

The same happens with the meinheld server 👍

MEMFILE_MAX limits the maximum amount of data hold in memory buffers instead of temporary files. It does not limit the total size of the body part. If a request is larger than MEMFILE_MAX it is simply buffered into a file instead of an io.BytesIO to prevent out of memory errors.
So, while it is a good idea to make max_body_size configurable, MEMFILE_MAX is certainly the wrong value.


[Bug]: Set Wallpaper Not Working Correctly

Summary
The Set Wallpaper feature in the contributions page does not inform the user that it has failed to set wallpaper. Also, I am unable to abort this dialog.
The issue is not that set wallpaper is failing to set the Image as wallpaper but that it is NOT Informing the user that it has failed and dialog is still appearing on the screen which the user cannot close.
Also, we should make the "set as wallpaper"  a background task that does not block the UI Thread as sometimes this can take long ( it is pretty similar to download )
Steps to reproduce

Open the app
Open any Contribution in Explore or your contribution
Click "Set as Wallpaper"

Expected behaviour
Sets the wallpaper or if it fails then the dialog ends and the user is informed
Actual behaviour
set wallpaper keeps on going
Device name
Xiaomi 11 Lite NE
Android version
Android 13
Commons app version
4.2.1-debug-main
Device logs
HTTP FAILED: java.io.IOException: Canceled
2024-02-16 20:52:02.709 16877-17104 OkHttp                  fr.free.nrw.commons.beta             V  --> GET https://upload.wikimedia.beta.wmflabs.org/wikipedia/commons/thumb/6/6f/Sea_View.jpg/640px-Sea_View.jpg
2024-02-16 20:52:02.709 16877-17104 OkHttp                  fr.free.nrw.commons.beta             V  Cache-Control: no-store
2024-02-16 20:52:02.709 16877-17104 OkHttp                  fr.free.nrw.commons.beta             V  --> END GET

Screen-shots
https://github.com/commons-app/apps-android-commons/assets/126143257/b7ce8dfb-9482-48b7-ae7c-004cac5ca137
Would you like to work on the issue?
Yes

Hey @shashankiitbhu, it seems the issue is with the beta server, as I was able to set wallpaper successfully using  prodDebug Screencast

@ShashwatKedia no that's not the issue, if you read the summary again I have mentioned that failing is not the problem, but dialog still appearing after failing is l

Strange in my case the wallpaper is set successfully in milliseconds. However, this is about handling the case when the process is failed, right?

However, this is about handling the case when the process is failed, right?

Yes

Well, I just faced the same with betaDebug flavor😅

If you don't mind can I work on this as I was digging it up recently and found the exact solution which is causing the bug and fix? Can I work on it if you wish or can we collaborate?

This is how I solved it.  @shashankiitbhu @nicolas-raoul
Root cause of issue.
Currently code handles the issue when the url is not present it handles the failures. But what if we have a url but receive error from the API side this could include (Wrong URL, server high time in response, xyz issues from server side), this is not handled in our API side.
Currently
I checked the if the url threw the error dismiss the progressdialog and show toast, which solves the issue somewhat but not optimal.
Working Video
https://github.com/commons-app/apps-android-commons/assets/60827173/235e8c9e-b684-4498-9a8b-b241c088a48f
Additional Improvements
Add Failure mechanism directly at the API level (calling api).(if org approves I can work on it)
For example I have worked similarly on one of my project like this.
    fun parseFailedResponse(t: Throwable): String {
        return when (t) {
            is SocketTimeoutException -> {
                "Connection Lost, please try again - ${t::class.java.simpleName}"
            }
            is MalformedJsonException,
            is JsonSyntaxException -> {
                t.printStackTrace()
                "SERVER sent invalid response - ${t::class.java.simpleName}"
            }
            else -> {
                t.printStackTrace()
                "Could not connect to SERVER - ${t::class.java.simpleName}"
            }
        }
    }

If you don't mind can I work on this as I was digging it up recently and found the exact solution which is causing the bug and fix? Can I work on it if you wish or can we collaborate?

I have already worked on it and presented a solution, I was waiting for mentors approval to make the PR and take inputs for changes

If you don't mind can I work on this as I was digging it up recently and found the exact solution which is causing the bug and fix? Can I work on it if you wish or can we collaborate?

I have already worked on it and presented a solution, I was waiting for mentors approval to make the PR and take inputs for changes

Sure, no problem ;)

@shashankiitbhu Sorry do you still need anything from us? If yes would you mind summarizing or posting a link here? Thanks :-)

@shashankiitbhu Sorry do you still need anything from us? If yes would you mind summarizing or posting a link here? Thanks :-)

If this issue is stale then I would like to take it as I have already fixed the issue locally. Since @shashankiitbhu is currently assigned to it, I have refrained from submitting a pull request. However, I can offer a patch fix for the changes. You can easily apply the patch by copying from clipboard from Android Studio

@shashankiitbhu Sorry do you still need anything from us? If yes would you mind summarizing or posting a link here? Thanks :-)

Actually, as mentioned above I was waiting for your confirmation on whether I should Implement the enhancement or not , whether it's worth doing or not according to you.

The issue is not that set wallpaper is failing to set the Image as wallpaper but that it is NOT Informing the user that it has failed and dialog is still appearing on the screen which the user cannot close.\n\nAlso, we should make the "set as wallpaper" a background task that does not block the UI Thread as sometimes this can take long ( it is pretty similar to download )

@nicolas-raoul This is the enhancement I have suggested

Based on this issue, it also made me remind that Progress Dialog is deprecated. I guess the better approach would be to remove the Progress dialog. Google  Deprecated Progress Dialog
According to Google

This class was deprecated in API level 26.
ProgressDialog is a modal dialog, which prevents the user from interacting with the app. Instead of using this class, you should use a progress indicator like ProgressBar, which can be embedded in your app's UI. Alternatively, you can use a notification to inform the user of the task's progress.

The better approach according to me would be to handle it like this.

Additional Improvements
Add Failure mechanism directly at the API level (calling api).(if org approves I can work on it)
For example I have worked similarly on one of my project like this.

Also CC : @psh as mentioned in https://github.com/commons-app/apps-android-commons/issues/5556#issuecomment-1978977703 can we add a failure mechanism to our api level

@shashankiitbhu Sounds good! 🙂

@nicolas-raoul Added the PR for this enhancement above, Please Review


Lock eventID mapping so it mirrors ID mapping

When Occurrence is mapped as an extension on the Event core, two mappings for eventID get shown:

as the ID term
under the class Event

This makes it possible for publishers to:

forget to map eventID, thinking it was already done by mapping the ID term
mistakenly map different source columns to eventID and the ID term

Ultimately, the ID term and eventID should always map to the same source column. To fix this problem, the eventID mapping should be locked so it mirrors the ID term mapping.
The fix should also handle similar cases too, since the same problem can arise with the taxonID mapping when Occurrence is mapped as an extension to the Taxon core.

Issue verified.


Make Get-Process  work as well as Get-Process

Fixes #2722
At the end of RetrieveMatchingProcessesByProcessName,
a check is added to see if the pattern is a positive integer.
In that case an attempt is made to match it to a process id.

Hi @powercode, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

It looks like this implements what I asked for, but there was agreement that the behavior is potentially dangerous and should be interactive only.

I know I'm the one that asked for exactly the behavior you've implemented here, but the discussion in #2722 has me convinced that

the proposed behavior is potentially dangerous
the general mechanism of enabling parameter metadata customization (e.g. in a users profile) enables a solution to this case for folks that can live the with potentially dangerous behavior, plus it enables many more interesting scenarios.


Does AWS (4.4.0-1060-aws) with g2.2X large support TensorFlow - GPU ?

Installed CUDA 9.0 and CuDNN on Ubuntu 16.04 (4.4.0-1060-aws; g2.2X large).
I got an error as - The GPU Driver (GPU Name: Persistence-M; NVIDIA-SMI 396.26) is not TensorFlow compatible. Below is my Linux screenshot).
2018-05-24 22:08:28.707495: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1406] Ignoring visible gpu device (device: 0, name: GRID K520, pci bus id: 0000:00:03.0, compute capability: 3.0) with Cuda compute capability 3.0. The minimum required Cuda capability is 3.5.
Does AWS (4.4.0-1060-aws) with g2.2X large support TensorFlow - GPU ?
Thanks.

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 30 days with no activity and the awaiting response label was assigned. Is this still an issue?

We are closing this issue for now due to lack of activity. Please comment if this is still an issue for you. Thanks!


WIP: Add more matchers

Add core Chef matchers that are missing
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

I can't load the diff, but 👍 once 💚

More free time on a plane and I'll implement the last examples.


Banned from server?

Hello guys, i'm really sorry if i did anything but im not really sure what i was banned for. I may have started up the wrong modpack and went onto the server which is entirely my fault but I would really appreciate it if i could recieve a second chance. I had a lot of fun on this server and put in quite a bit of time into things such as my base and team and I would hate to lose them, again im very sorry if i did and thank you to whoever is reading this. Have a good day

Can see you've logged in twice with these mods lately so Im inclined to believe you started up with the wrong modpacks, so I will unban you. Please delete or disable any and all hacks / mods that you might have next time you are on, as, if you are found to be having these mods enabled again, you will be banned promptly.


Add continuous integration to cgl-docker-lib

http://jenkins.cgcloud.info/job/cgl-docker-lib/

First step:  Write a cgcloud role for the jenkins slave box that where the building/testing will take place.

Hannes and I will set this up Friday (9/17/15)

Issue:
Successfully running make on a tool doesn’t do anything to ensure that the tool actually does anything meaningful.
Only solution I've thought of yet is to write a companion unittest for each tool that gets run when that tool gets rebuilt.

Re: Smoke testing each container: I think that's a good idea. That should happen for every modified tool, and before the image is pushed such that nothing is pushed if the test fails. A test failure in one tool should prevent any tool from being pushed, it shouldn't prevent other modified tools from being tested.
It's now pretty easy to pull Docker into a role. See ToilJenkinsSlave.

credential files were placed in the jenkins master home directory and the global jenkins configuration was modified to include those credentials when creating slaves.

Fixed by https://github.com/BD2KGenomics/cgcloud/commit/f8b675b1c2ed0412f83cd00b38db4e121ce9a5a7


Add tests for merging reports

This PR adds tests for #4192. The problem seems to be happening for Detekt/Android, but not Detekt/Jvm.

I would vote to move the tests back to Java 16 then. Until gradle supports Java 17.

I think this can be left on blocked till Gradle 7.3 is out which should be really soon (they're on RC)

This PR is now unblocked since Gradle 7.3 supports Java 17 officially

You might need to check and force push again, the diff is now empty...


Filtering data in Maps with shapes

Description
Adds page to explain how to filter data in maps by drawing shapes.
Issues Resolved
Closes #2543
Checklist

[x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hi Caroline, please remove the backport labels, since this is a 2.7 feature. You can add the 2.7 and release-note labels. Thanks!

Closing this PR because it is a duplicate.


controller: add ReclaimSpaceJob controller

This commit adds ReclaimSpaceJob controller code
and unit tests for the same.

ReclaimSpaceJob controller watches for ReclaimSpaceJob,
validates resource, finds connections, makes respective
grpc requests and updates the status.

Signed-off-by: Rakshith R<EMAIL_ADDRESS>

This pr still has needs some logging, setting failure conditions and bit more polishing.
But the general workflow should work as expected, please review @csi-addons/kubernetes-csi-addons-contributors .

@mergifyio rebase


board: hsdk: add cy8c95xx I/O expander support

hsdk has an on board cy8c95xx I/O expander, some on board peripherals using expander GPIO.
This PR add initial support for cy8c95xx I/O expander, no interrupt support currently, then add
LEDs, arduino_header and arduino_header to hsdk dts, and remove ili9340 from hsdk dts, as it's not
a part of hsdk board, it's a shield device.

with this PR, samples/basic/blinky can run on hsdk board!

dev-review (April 15, 2021): How to structure the devicetree for this.  Suggestion is to have a node per GPIO port as the device has up to 8 GPIO ports.

@mnkp @galak  Could you please give some advice how to structure the device tree to have a node per GPIO port. I have checked there is no similar design in zephyr currently.
gpio_pca95xx.c has multi ports, but only write driver for one port: https://github.com/zephyrproject-rtos/zephyr/blob/master/drivers/gpio/gpio_pca95xx.c
is this right? :
&i2c0 {
	status = "okay";
	clock-frequency = <I2C_BITRATE_STANDARD>;
	cy8c95xx_port0: cy8c95xx_port0@20 {
		compatible = "cypress,cy8c95xx";
		reg = <0x20 0x00>;
		label = "cy8c95xx_io_port0";
		gpio-controller;
		#gpio-cells = <2>;
		ngpios = <8>;
	};
	cy8c95xx_port1: cy8c95xx_port1@20 {
		compatible = "cypress,cy8c95xx";
		reg = <0x20 0x01>;
		label = "cy8c95xx_io_port1";
		gpio-controller;
		#gpio-cells = <2>;
		ngpios = <8>;
	};
	// ...
	// ...
	cy8c95xx_port7: cy8c95xx_port7@20 {
		compatible = "cypress,cy8c95xx";
		reg = <0x20 0x07>;
		label = "cy8c95xx_io_port7";
		gpio-controller;
		#gpio-cells = <2>;
		ngpios = <8>;
	};
};

I believe it would be better to make it look similar to

dts/bindings/gpio/silabs,gecko-gpio.yaml
dts/bindings/gpio/silabs,gecko-gpio-port.yaml

The SiLabs GPIO module is a SoC internal one, but we could take a similar approach and split the device in one node with compatible = "cypress,cy8c95xx" and several nodes with "compatible = "cypress,cy8c95xx-port". The reason for splitting is the architecture of the cy8c95xx. All the device registers are accessible via a single I2C address, this will be represented by compatible = "cypress,cy8c95xx" node. And the device can have up to 8 ports, they will be represented by "compatible = "cypress,cy8c95xx-port"`.
In all cases the reg property should have only address cell, no size cell, i.e. for compatible = "cypress,cy8c95xx" it should be reg = <0x20> representing the address on the I2C bus. For "compatible = "cypress,cy8c95xx-port" the reg property could represent the port number, i.e. be defined as a reg = <n> where n is a number between 0 and 7.
@galak, could you double check that the above approach is the right one.

I believe it would be better to make it look similar to

dts/bindings/gpio/silabs,gecko-gpio.yaml
dts/bindings/gpio/silabs,gecko-gpio-port.yaml

The SiLabs GPIO module is a SoC internal one, but we could take a similar approach and split the device in one node with compatible = "cypress,cy8c95xx" and several nodes with "compatible = "cypress,cy8c95xx-port". The reason for splitting is the architecture of the cy8c95xx. All the device registers are accessible via a single I2C address, this will be represented by compatible = "cypress,cy8c95xx" node. And the device can have up to 8 ports, they will be represented by "compatible = "cypress,cy8c95xx-port"`.
In all cases the reg property should have only address cell, no size cell, i.e. for compatible = "cypress,cy8c95xx" it should be reg = <0x20> representing the address on the I2C bus. For "compatible = "cypress,cy8c95xx-port" the reg property could represent the port number, i.e. be defined as a reg = <n> where n is a number between 0 and 7.
@galak, could you double check that the above approach is the right one.

Thanks @mnkp , I have updated the codes, Can you help review again.

Thanks, that looks good. Just the last few bits.
Let's squash the following two commits, since they describe one logical change

boards: hsdk: add documents for I/O expander and LEDs
boards: hsdk: add cy8c95xx I/O expander, LEDs support

thanks for your review, fixed.

tests/drivers/gpio/gpio_api_1pin results:
*** Booting Zephyr OS build zephyr-v2.5.0-2554-gaa813e22470c  ***
Running test suite gpio_api_1pin_test
===================================================================
START - test_gpio_pin_configure_push_pull
Running test on port=cy8c95xx_port1, pin=4
 PASS - test_gpio_pin_configure_push_pull in 0.108 seconds
===================================================================
START - test_gpio_pin_configure_single_ended
Running test on port=cy8c95xx_port1, pin=4
When configured as input test pin value is low
Open Source configuration or Pull Down pin bias is not supported
 SKIP - test_gpio_pin_configure_single_ended in 0.136 seconds
===================================================================
START - test_gpio_pin_set_get_raw
Running test on port=cy8c95xx_port1, pin=4
 PASS - test_gpio_pin_set_get_raw in 0.62 seconds
===================================================================
START - test_gpio_pin_set_get
Running test on port=cy8c95xx_port1, pin=4
 PASS - test_gpio_pin_set_get in 0.62 seconds
===================================================================
START - test_gpio_pin_set_get_active_high
Running test on port=cy8c95xx_port1, pin=4
Step 1: Set logical, get logical and physical pin value
Step 2: Set physical, get logical and physical pin value
 PASS - test_gpio_pin_set_get_active_high in 0.144 seconds
===================================================================
START - test_gpio_pin_set_get_active_low
Running test on port=cy8c95xx_port1, pin=4
Step 1: Set logical, get logical and physical pin value
Step 2: Set physical, get logical and physical pin value
 PASS - test_gpio_pin_set_get_active_low in 0.132 seconds
===================================================================
START - test_gpio_pin_toggle
Running test on port=cy8c95xx_port1, pin=4
 PASS - test_gpio_pin_toggle in 0.36 seconds
===================================================================
START - test_gpio_port_set_masked_get_raw
Running test on port=cy8c95xx_port1, pin=4
 PASS - test_gpio_port_set_masked_get_raw in 0.65 seconds
===================================================================
START - test_gpio_port_set_masked_get
Running test on port=cy8c95xx_port1, pin=4
 PASS - test_gpio_port_set_masked_get in 0.66 seconds
===================================================================
START - test_gpio_port_set_masked_get_active_high
Running test on port=cy8c95xx_port1, pin=4
Step 1: Set logical, get logical and physical port value
Step 2: Set physical, get logical and physical port value
 PASS - test_gpio_port_set_masked_get_active_high in 0.192 seconds
===================================================================
START - test_gpio_port_set_masked_get_active_low
Running test on port=cy8c95xx_port1, pin=4
Step 1: Set logical, get logical and physical port value
Step 2: Set physical, get logical and physical port value
 PASS - test_gpio_port_set_masked_get_active_low in 0.192 seconds
===================================================================
START - test_gpio_port_set_bits_clear_bits_raw
Running test on port=cy8c95xx_port1, pin=4
 PASS - test_gpio_port_set_bits_clear_bits_raw in 0.54 seconds
===================================================================
START - test_gpio_port_set_bits_clear_bits
Running test on port=cy8c95xx_port1, pin=4
 PASS - test_gpio_port_set_bits_clear_bits in 0.53 seconds
===================================================================
START - test_gpio_port_set_clr_bits_raw
Running test on port=cy8c95xx_port1, pin=4
 PASS - test_gpio_port_set_clr_bits_raw in 0.42 seconds
===================================================================
START - test_gpio_port_set_clr_bits
Running test on port=cy8c95xx_port1, pin=4
 PASS - test_gpio_port_set_clr_bits in 0.38 seconds
===================================================================
START - test_gpio_port_toggle
Running test on port=cy8c95xx_port1, pin=4
 PASS - test_gpio_port_toggle in 0.36 seconds
===================================================================
START - test_gpio_int_edge_rising
Running test on port=cy8c95xx_port1, pin=4
Pin interrupt is not supported.
 SKIP - test_gpio_int_edge_rising in 0.27 seconds
===================================================================
START - test_gpio_int_edge_falling
Running test on port=cy8c95xx_port1, pin=4
Pin interrupt is not supported.
 SKIP - test_gpio_int_edge_falling in 0.27 seconds
===================================================================
START - test_gpio_int_edge_both
Running test on port=cy8c95xx_port1, pin=4
Pin interrupt is not supported.
 SKIP - test_gpio_int_edge_both in 0.27 seconds
===================================================================
START - test_gpio_int_edge_to_active
Step 1: Configure pin as active high
Running test on port=cy8c95xx_port1, pin=4
Pin interrupt is not supported.
 SKIP - test_gpio_int_edge_to_active in 0.30 seconds
===================================================================
START - test_gpio_int_edge_to_inactive
Step 1: Configure pin as active high
Running test on port=cy8c95xx_port1, pin=4
Pin interrupt is not supported.
 SKIP - test_gpio_int_edge_to_inactive in 0.30 seconds
===================================================================
START - test_gpio_int_level_high
Running test on port=cy8c95xx_port1, pin=4
Pin interrupt is not supported.
 SKIP - test_gpio_int_level_high in 0.27 seconds
===================================================================
START - test_gpio_int_level_low
Running test on port=cy8c95xx_port1, pin=4
Pin interrupt is not supported.
 SKIP - test_gpio_int_level_low in 0.27 seconds
===================================================================
START - test_gpio_int_level_active
Step 1: Configure pin as active high
Running test on port=cy8c95xx_port1, pin=4
Pin interrupt is not supported.
 SKIP - test_gpio_int_level_active in 0.30 seconds
===================================================================
START - test_gpio_int_level_inactive
Step 1: Configure pin as active high
Running test on port=cy8c95xx_port1, pin=4
Pin interrupt is not supported.
 SKIP - test_gpio_int_level_inactive in 0.30 seconds
===================================================================
START - test_gpio_pin_toggle_visual
Running test on port=cy8c95xx_port1, pin=4
LED ON
LED OFF
LED ON
LED OFF
 PASS - test_gpio_pin_toggle_visual in 6.50 seconds
===================================================================
Test suite gpio_api_1pin_test succeeded
===================================================================
PROJECT EXECUTION SUCCESSFUL


feat: Add podAnnotations for deployment

Added support for customizable pod annotations in the deployment.yaml and values.yaml files.

Introduced a new podAnnotations field in values.yaml to allow users to define custom annotations for pods.
Updated deployment.yaml to apply annotations from values.yaml using Helm's templating system.
Removed redundant end statement in tolerations block for cleaner YAML structure.

@zakkg3 Please review

Any updates with it ?

I have to fix the e2e test and if that passes ill merge this. I guess in the next days I hope I find the time for this.
sorry for the delay.

I have to fix the e2e test and if that passes ill merge this. I guess in the next days I hope I find the time for this. sorry for the delay.

Super good. Thank you.

thanks for the pr.
merging all here https://github.com/zakkg3/ClusterSecret/pull/143

BTW the e2e test are failing cause the was some changes on the chart without bumping the chart version. will fix this all on the fix-all pr


build using Py3.8 and test across more OSs

closes #505
also further discussion is warranted

now this also runs on Windows 7

capa.exe 478040c

whats our status here?

If we're fine with Python 3.8 I can remove the testing code and get this set up before the next release.

bump @Ana06 and @williballenthin
can I enable this / remove the comments for a merge?

Done!


proxy support with authentication

What does this PR do?

provides a way to test proxy usage with & without authentication using a squid proxy container
currently instruments Authenticator.register* static methods to provide an automatic fallback (still WIP)

In a regular application, using proxy with authentication requires to setup a global Authenticator as described here.
The goal here is not to merge this as-is, but rather to discuss how to properly implement support for proxies using authentication.
Constraints

agent uses java.net.HttpUrlConnection to communicate with backend server
http.proxyHost and http.proxyPort JVM system properties allow to set a global proxy for the whole JVM
while http.proxyUser and http.proxyPassword are also defined, they can't be used without registering an Authenticator instance explicitly
unless using Java 9 and later, there is no way to avoid the global authenticator that is set through Authenticator.setDefault(...), also, Authenticator.getDefault() is only available on Java 9.
once the JVM has authenticated against a proxy server, credentials are cached and reused to avoid round-trips with the proxy

Proposal

get rid of the jdk Authenticator instrumentation as it introduces extra complexity for a very minor benefit
add a new opt-in configuration option : proxy_authenticator which can have values auto (default), false, true
when set to false, feature is disabled
when set to true, a global authenticator will be registered if http.proxyUser and http.proxyPassword are set
when set to auto, behavior depends on Java version:

Java < 9: equivalent to false, users have to explicitly set true to enable proxy authentication
Java >= 9: a global Authenticator will be registered only if application did not already set one (we have a getter on the global instance).

This allows to:

avoid any extra complexity in agent code (proxies with/without authentication aren't used by most users)
do not have any impact on applications that already register a global Authenticator instance
provide a fallback option for users that do not have any Authenticator instance in their application (the app isn't using the proxy) without having to modify their application.
bonus of this PR: provide tests for proxy support.

Alternatives

Still provide an option to register a global Authenticator (true|false) to make it work with java 7 and 8. With java >= 9, use reflection to set Authenticator on the connection.

Checklist

[x] This is an enhancement of existing features, or a new feature in existing plugins

[ ] I have updated CHANGELOG.asciidoc
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Added an API method or config option? Document in which version this will be introduced
[ ] I have made corresponding changes to the documentation

Update after discussing with @felixbarny:
We don't have enough data/feedback about proxy usage to make a proper decision on what is best to do, thus we will keep proxy-support it as-is for now.
Key points:

making this work with java 9+ with a per-connection Authenticator sounds a good idea
for older java versions, the global Authenticator is a decent fallback, but we are not (yet) required to provide one.
merging the tests in this PR allow to future-proof proxy usage by the agent, this part will be pushed through another separate PR.


URLConverter is unreliable on Domino

@ddumont Please review

@ddumont, please review

so we don't hit this on domino, what does that mean?

We'll just get a reference to it from the context each time we need it instead of saving it?

Without the URLConverter service reference, we won't use the URLConverter at all.  So all access to resources in bundles will be made through the OSGi bundle api rather than the file system.  This might have some performance implications, and I don't know if it will resolve the bundle extraction problems we're seeing on Domino, but it's worth a shot.

Hmm...   We can try it but I'm not very hopeful.

Merged.  Please create a snapshot so I can run tests.


Remember repo list filter

resolves #3552
Changes:

store filter in local storage instead of session storage, so it is remembered on abapgit restart
filter is saved whenever it is changed instead of page unload
removed debug output, it doesn't need to clutter the main page

Hmm, the code looks OK, but test didn't work for me - win10, 752(dev-edition), entered filter, pressed enter (filter worked), exited AG, run AG again - no filter

You may have the browser configured to deny permission to persist data (Or it was a private/incognito session). I can test tomorrow

Retested and it works for me.

@FreHu ok, will have a look later today. It is strange indeed, I double checked - the localstorage is supported in IE, it really should work.
P.S. just in case, GUI 7.40

Works fine for me as well, GUI 7.60

Ok ... did some debugging ...

saving "detail" and "Fav" flags do work
But based on PR description I was expecting that filter will also be saved - it does not work. But ... if was not intended - it is OK.
One thing that would suggest improving is double save onLoad. onLoad calls ``toggle...which callssaveFilter`. Not critical ... but could be improved.

debug output on start, SF = save filter, OPL = on page load. Don't mind the details, just note 2 "SF" at the end
storage OPL: true RepoOverViewHelperState
{"isDetailsDisplayed":true,"isOnlyFavoritesDisplayed":true}
storage SF: true RepoOverViewHelperState
storage SF: true RepoOverViewHelperState

Sorry for the confusion, I only meant to save the icon state. I fixed the page load, save is now only done on toggle.


Correction for raw affiliation PHIM Plant Health Institute, Univ Montpellier, IRD, CIRAD, INRAE, Institut Agro, Montpellier, France

Correction needed for raw affiliation PHIM Plant Health Institute, Univ Montpellier, IRD, CIRAD, INRAE, Institut Agro, Montpellier, France
raw_affiliation_name: PHIM Plant Health Institute, Univ Montpellier, IRD, CIRAD, INRAE, Institut Agro, Montpellier, France
new_rors: 05kpkpg04;05q3vnk25;03rnk6m14;003vg9w96;051escj72;03fkrcm40;05y5s3h28
previous_rors: 05kpkpg04;05q3vnk25;03rnk6m14;003vg9w96;051escj72;03fkrcm40
works_examples: W4301373378
contact: 61c4070c1c0f9b3cc4325a453cc2a2f7:760bef2dc9d2c214d19abe6698a832cf6f0e @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


modal popup for new case not dismissed on history.back()

Describe the bug
Pressing back when modal popup of new case is shown should dismiss the modal, instead the page behind it goes back.
To Reproduce
Steps to reproduce the behavior:

Go to dev-curator.ghdsi.org
Click on linelist to go to /cases
Click on Create New -> Line list Case
Press back

Expected behavior
The modal disappears and we're back /cases.
Instead the page behind it goes to /

Also if we can fix the fact that the /cases/new URL was lost when moving to the modal dialog that'd be great, there's no way to link to a new case or to open the app directly on the modal dialog.
I don't know how this got implemented but when the modal popup is shown we should push /cases/new to the URL history, and if we go to that URL it should show the dialog also.

Fixed by https://github.com/open-covid-data/healthmap-gdo-temp/commit/c4d18e4ccdf674bcfb11f7328b7fa3a7693b57cf which accidentally wasn't PRed


Cannot create FlannBasedMatcher with parameters

FlannBasedMatcher::new requires Ptr<_> versions of IndexParams and SearchParams, which do not appear to have constructor functions that return Ptrs. I don't know very much about C++, but I tried creating new Ptr objects from the pointers of the index and search parameters, and this caused a segfault:
let mut index_params = IndexParams::default().unwrap();
index_params.set_algorithm(FLANN_INDEX_KDTREE).unwrap();
index_params.set_int("trees", 5).unwrap();
let mut search_params = SearchParams::new(50, 0., true).unwrap();
let index_params = unsafe { Ptr::from_raw(index_params.as_raw_mut_IndexParams()) };
let search_params = unsafe { Ptr::from_raw(search_params.as_raw_mut_SearchParams()) };

let flann = FlannBasedMatcher::new(&index_params, &search_params); // segfault

Thanks! This is definitely a deficiency of the API, I’ll see how this can be fixed.

Can you please check out the ptr branch and tell me if it works for you? There is a new method of non-abstract inner types for Ptr.

Looks like it's working perfectly now. Thank you for the very quick response! Should I keep this issue open while you merge it?

Yes, please, I’ll close it when the feature is released

This is now released in version 0.44.0


Addresses release feedback and updates build related versions

This adds the missing NOTICE file and removes the git plugin from the
license check. Since we don't use a date expression in our headers, the
git plugin was unnecessarily fragile.
This also updates build related versions, leaving functional versions
alone (Karaf ones). They can be updated separately as sensitive to
itests.

thanks for the review folks


[Sema] Crash fix for key path for an optional chain to optional lvalue.

Incorrect condition here resulted in incorrectly trying to optional-wrap for an optional chain to optional lvalue.
Resolves SR-6106 | rdar://problem/34911379.

@swift-ci Please smoke test

Thanks! This shouldn't really be possible, though, since the optional chain is supposed to force the rest of the following keypath to be read-only.


Server certificate problems should be communicated prominently

Steps to reproduce:

Open a page on a new domain.
Re-generate the certificate used by the domain (on the Gemini server).
Open another page / reload the page on the same domain.

Result:

Lock icon (left of the URL input) becomes orange.
Certificate status is shown as matching and not expired, but "Not trusted".
No further information is available.

Expected result:

A very obvious and visible indication that there may be a security issue.
More detailed information about the certificate mismatch (comparison of two certificates?).
Instructions for non-advanced users on what to do.

Note: popular web browsers replace the whole page with a warning view in similar cases.

One more thing: the orange color of the lock icon somewhat matches the orange color used by the light theme:

So it just seems like a normal-state-and-not-a-warning UI.

One more option would be to invert the colors of both the lock icon and the URL input (e.g. white on red). This could work for the color-blind users too.
Although replacing the whole page with a warning may still be the least problematic option.

One more thing: the orange color of the lock icon somewhat matches the orange color used by the light theme:

Good point. I prefer to use dark mode myself so have missed this detail. This needs to be prominently displayed in all UI themes.

Gemini spec says the following on this matter (4.2):

On all subsequent connections to that hostname, the received certificate's fingerprint is computed and compared to the one in the database. If the certificate is not the one previously received, but the previous certificate's expiry date has not passed, the user is shown a warning, analogous to the one web browser users are shown when receiving a certificate without a signature chain leading to a trusted CA.

https://gemini.circumlunar.space/docs/specification.html

Here's a preview of what I'm working on:

The new warning banner appears at the top of the page if there is a certificate trust issue.
The orange-on-white lock icon has been replaced with a warning symbol.

When it comes to certificate fingerprints, would it be useful to easily copy them to the clipboard for example?

This is much much better than just the color of the icon. I think the banner placement is good, even if it may get confused with page content -- it will not get ignored.
The contrast for the warning text seems a bit lower than for the page text and the color scheme doesn't exactly say "Warning!" :smile: .
Also this looks like it could be expanded in the future with more functionality (review both certificates, check with some observatory, accept the new one, etc. ).
I think it would be really useful to be able to get the problematic certificate details somehow. Maybe add them to the Certificate Status dialog?

Thanks for the improvement ideas! I'll close this issue but keep working along those lines. I'm thinking the Certificate Status should be expanded into a more general-purpose Page Information dialog. Then it would be natural to put more info/tools in there.


savePath issue with compiled files

Hi,
When running Watch sass in VS code, the css files are stored in my scss folder. This became an issue with the old live sass compiler, I then installed yours. It worked, now I just opened up another project and the same thing occurs. It do not create the css / dist/css folders and instead puts the files in the scss folder as mentioned.
I will try to uninstall and install, but second time it happens so I wanted to post it. When it works it's awesome!
.vscode -> settings.json
{
"liveSassCompile.settings.formats": [
{
"format": "expanded",
"extensionName": ".css",
"savePath": "/css"
},
{
"extensionName": ".min.css",
"format": "compressed",
"savePath": "/dist/css"
}
],
"liveSassCompile.settings.excludeList": ["/node_modules/", ".vscode/**"],
"liveSassCompile.settings.generateMap": false,
"liveSassCompile.settings.autoprefix": ["defaults"]
}
It has worked, but now it doesn't.

Sorry to hear you're having a problem.

Before doing any of the below, can you take a screengrab of the folder structure?
Are those the settings for the project that works and the project that doesn't?
Once open, can you change the showOutputOnsetting to trace, save a file and then include the output here?
Does it save the files to the /css and /dist/css folders if you manually create them?

Response time === A+.
Update: Uninstalled and installed (same project, folder structure and .vscode/settings.json) and it started to work.
Same code for the project that worked and this that didn't. Before uninstall/install I did try to create the /css and /dist/css folder manually, it didn't have any affect.
I will save your instruction for fail search next time it happens, and post it accordingly.

Glad it's working again for you.
As it's now working, I'll close this issue. Still post the comment/details here, once it happens again, and I'll reopen it.
Thanks in advance 😁


Extract: Ability to Accept or Reject an extracted event

This PRs remove the ability to delete an extract event and replaces it with the ability to "Accept" or "Reject" one.
We introduce a new status field for ExtractedEvents.
Done:

Introduce new status field.
Update the API to remove the DELETE and replace it with a patch.
Replace the "Delete" button by two new buttons "Accept" and "Reject".

Next PR will focus on the UI:

Properly display the status
Rework the help content.

Second Next PR I'll try to handle a basic update mechanism to edit an event -> to keep it simple for a first step I'll check if relevant to reuse what we have on the Dust apps to play with JSON fields.

No need to ask reviews for Extract :+1:


ModuleNotFoundError: No module named 'numpy'

Could I please ask if you know how to work around this issue?
Here's what I did:
git clone git@github.com:klarman-cell-observatory/pegasus.git

cd pegasus

pip install -e .

Here's what I get:
Obtaining file:///home/ks38/work/github.com/klarman-cell-observatory/pegasus
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  ERROR: Command errored out with exit status 1:
   command: /projects/kamil/miniconda3/bin/python /projects/kamil/miniconda3/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmp9ei50s40
       cwd: /home/ks38/work/github.com/klarman-cell-observatory/pegasus
  Complete output (18 lines):
  Traceback (most recent call last):
    File "/projects/kamil/miniconda3/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py", line 280, in <module>
      main()
    File "/projects/kamil/miniconda3/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py", line 263, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "/projects/kamil/miniconda3/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py", line 114, in get_requires_for_build_wheel
      return hook(config_settings)
    File "/tmp/pip-build-env-ggysd_bv/overlay/lib/python3.7/site-packages/setuptools/build_meta.py", line 150, in get_requires_for_build_wheel
      config_settings, requirements=['wheel'])
    File "/tmp/pip-build-env-ggysd_bv/overlay/lib/python3.7/site-packages/setuptools/build_meta.py", line 130, in _get_build_requires
      self.run_setup()
    File "/tmp/pip-build-env-ggysd_bv/overlay/lib/python3.7/site-packages/setuptools/build_meta.py", line 254, in run_setup
      self).run_setup(setup_script=setup_script)
    File "/tmp/pip-build-env-ggysd_bv/overlay/lib/python3.7/site-packages/setuptools/build_meta.py", line 145, in run_setup
      exec(compile(code, __file__, 'exec'), locals())
    File "setup.py", line 7, in <module>
      import numpy
  ModuleNotFoundError: No module named 'numpy'
  ----------------------------------------
ERROR: Command errored out with exit status 1: /projects/kamil/miniconda3/bin/python /projects/kamil/miniconda3/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmp9ei50s40 Check the logs for full command output.

I continue to get the same error after upgrading numpy:
pip install --upgrade numpy

Requirement already satisfied: numpy in /projects/kamil/miniconda3/lib/python3.7/site-packages (1.18.1)
Collecting numpy
  Downloading numpy-1.19.4-cp37-cp37m-manylinux2010_x86_64.whl (14.5 MB)
     |████████████████████████████████| 14.5 MB 2.3 MB/s
Installing collected packages: numpy
  Attempting uninstall: numpy
    Found existing installation: numpy 1.18.1
    Uninstalling numpy-1.18.1:
      Successfully uninstalled numpy-1.18.1
Successfully installed numpy-1.19.4

Sorry, this issue was entirely my fault.
The cause was a new file I created called pegasus/test-igraph.py.
In that file, I had import numpy as np.
After I deleted pegasus/test-igraph.py, the issue is now resolved.


Update webapp-runner to version <IP_ADDRESS> to support UTF-8 URI Encoding

Hi!
I am having an issue with URI encoding when query parameters are sent to the server with special characters in Spanish that are written with accent marks such as á, é, í, ó, ú.
To solve this problem in Tomcat you have to define the URIEncoding attribute in the connector as UTF-8.
<Connector port='8080' protocol='HTTP/1.1' connectionTimeout='20000'
           redirectPort='8443' URIEncoding='UTF-8' />

With webapp-runner (in newer versions) there is an argument that could be sent so as to specified the URI Encoding, which is:
--uri-encoding  utf-8

This could be easily configured in RUNNER_OPTS Config Variables from a Heroku App. But with the version that is configured now in the buildpack, we do not have this option.
Could it be possible to upgrade the webapp-runner version to <IP_ADDRESS>?
Thanks!
Sebastian

I've updated the master branch with webapp-runner <IP_ADDRESS>. We'll probably release the buildpack today or tomorrow, but in the meantime you use it by running:
$ heroku buildpack:set https://github.com/heroku/heroku-buildpack-grails.git

Thanks!


OIDC/OAuth support

Is your feature request related to a problem? Please describe.
I'm always frustrated when I want to share a big file with my friends, since allowing unauthorised user to upload big file might cause the disk space abused.
Describe the solution you'd like
Allowing user login via OIDC, and add limitation options for login user and unauthorised user seperatelly.
ALLOW_UPLOAD = "none" / "login" / "all"
ALLOW_UPLOAD_FILE =  "none" / "login" / "all"

Hello! I've wanted to do something similar myself, and in case you find it helpful I'll share how Caddy + Authelia can be used to make uploading require login:
pastes.example.com {
    route /raw/* {
        reverse_proxy :4144 {
            header_down Content-Type "text/plain; charset=UTF-8"
        }
    }
    @public path /static/* /upload/* /file/* /p/* /raw/* /u/* /qr/* /auth/* /auth_file/*
    route @public {
        reverse_proxy :4144
    }
    route * {
        import auth
        reverse_proxy :4144
    }
}

The one thing that I'd actually consider helpful is allowing removal of password auth for the admin page, since I'm now handling access/auth myself.


Include versions in deployments

It should be possible to access the version, display it in the app, etc.

We should use the git-commit-id plugin that we use in OTP for this.


You have to double hit the key to get the chinese punctuation corretly in vim/neovim in this terminal!

Environment
Windows build number: Microsoft Windows NT 10.0.18362.0
Windows Terminal version: v0.8.10261.0 and 2019/6/21 published on MS-Store
NeoVim version: 0.4.3
Input method editor: Microsoft Pinyin

Steps to reproduce

Install vim/neovim
Open powershell in the terminal and type nvim test.md
Switch to Chinese input method editor
Feel free to type some Chinese punctuation like ，。？！（） and you'll get what I say

Expected behavior
If I just write in English in the terminal, it performs pretty well. And I have tested it in cmder and nvim-qt.exe, have no problem.

( BTW, nvim-qt is not a terminal actually )

Actual behavior
In windows terminal, whatever I use nvim in powershell or vim in WSL bash, I have to hit the key twice in order to input the Chinese punctuation. So I pretty sure it's a bug of windows terminal.
More interested, you need not have to hit the same key twice, just hit whatever first and then hit what you want to input, it seems that the first key has been eaten by terminal.
Most interested is: I clicked some emoji in MS pinyin with the mouse, but it did not appear here immediately., when I typed some Chinese ( NOT ENGLISH ), all the emojis swarm into my terminal.

Thanks for the report! This sounds like a /dupe of #3745


title bar/decorations no longer appear in fullscreen mode

System

Operating System
macOS v10.14.6

Rust Version
rustc 1.38.0 (625451e37 2019-09-23)

When did this start happening?
Things work as expected in v0.3.0 and break in v0.40 and master.
Behavior
When full-screened, I no longer see the title bar or decorations. Also, placing the cursor near the top of the screen for a couple of seconds shifts window contents down, but no longer shows the macOS menu bar.
This may be unrelated, but I'm also noticing 'jitteryness' on certain actions, such as ctrl+L (ClearLogNotice).
Config
Window settings are:
window:
  padding:
    x: 2
    y: 2
  dynamic_padding: false
  decorations: full
  startup_mode: windowed

I believe this is due to https://github.com/rust-windowing/winit/issues/1195.


Link to "Gitmoji commit standards" in README.md gives 404

https://github.com/apartresearch/deepdecipher?tab=readme-ov-file#repo-standards
gives a link to https://github.com/apartresearch/deepdecipher/blob/main/gitmoji.dev
but that file does not exist, giving an error: 404

Fixed in #147

🚀


fivetran_connector crashes on hubspot, slack, zoom, intercom, adyen, notion

Describe the bug
fivetran_connector crashes on the following services:
hubspot, slack, zoom, intercom, adyen, notion
also, there seem to be no documentation for intercom and adyen
To Reproduce
resource "fivetran_connector" "hubspot_connector" {
group_id    = var.group_id
service     = "hubspot"
}
Expected behavior
A clear and concise description of what you expected to happen.
provision an incomplete connector or give an error why that's not possible. But i'm sure it's possible, on other connectors it is sufficient to add the required parameters, group_id and service name
Logs & Output
Provide terraform CLI output on plan | apply. If it is possible, please, refer to this guide to enable debug output.
Stack trace from the terraform-provider-fivetran_v1.1.19.exe plugin:
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x20 pc=0xe4623f]
goroutine 31 [running]:
github.com/fivetran/terraform-provider-fivetran/fivetran/framework/core/model.getDestinatonSchemaForConfig({0x14a9bd8?, 0xc00089a298?}, {0x0, 0x0}, {0x0, 0x0}, {0x0?, 0x0?})
github.com/fivetran/terraform-provider-fivetran/fivetran/framework/core/model/connector.go:257 +0x35f
github.com/fivetran/terraform-provider-fivetran/fivetran/framework/core/model.(*ConnectorResourceModel).GetDestinatonSchemaForConfig(0xc000118700)
github.com/fivetran/terraform-provider-fivetran/fivetran/framework/core/model/connector.go:167 +0x530
github.com/fivetran/terraform-provider-fivetran/fivetran/framework/resources.(*connector).Create(0xc0001100b8, {0x14a6360, 0xc00099dda0}, {{{{0x14ab5d8, 0xc0009f4c30}, {0x11fe5c0, 0xc0009e6240}}, {0x14ad2c0, 0xc000138640}}, {{{0x14ab5d8, ...}, ...}, ...}, ...}, ...)
github.com/fivetran/terraform-provider-fivetran/fivetran/framework/resources/connector.go:117 +0x556
github.com/hashicorp/terraform-plugin-framework/internal/fwserver.(*Server).CreateResource(0xc000240420, {0x14a6360, 0xc00099dda0}, 0xc00089b2c0, 0xc00089b260)
github.com/hashicorp/terraform-plugin-framework@v1.4.2/internal/fwserver/server_createresource.go:101 +0x5b8
github.com/hashicorp/terraform-plugin-framework/internal/fwserver.(*Server).ApplyResourceChange(0x14a6360?, {0x14a6360, 0xc00099dda0}, 0xc0001399f0, 0xc00089b430)
github.com/hashicorp/terraform-plugin-framework@v1.4.2/internal/fwserver/server_applyresourcechange.go:57 +0x4a8
github.com/hashicorp/terraform-plugin-framework/internal/proto6server.(*Server).ApplyResourceChange(0xc000240420, {0x14a6360?, 0xc00099dc50?}, 0xc0001399a0)
github.com/hashicorp/terraform-plugin-framework@v1.4.2/internal/proto6server/server_applyresourcechange.go:55 +0x27b
github.com/hashicorp/terraform-plugin-mux/tf6muxserver.(*muxServer).ApplyResourceChange(0x14a62b8?, {0x14a6360?, 0xc00099d920?}, 0xc0001399a0)
github.com/hashicorp/terraform-plugin-mux@v0.12.0/tf6muxserver/mux_server_ApplyResourceChange.go:36 +0x1b5
github.com/hashicorp/terraform-plugin-go/tfprotov6/tf6server.(*server).ApplyResourceChange(0xc0004a8140, {0x14a6360?, 0xc00099cf30?}, 0xc0001ae2a0)
github.com/hashicorp/terraform-plugin-go@v0.19.0/tfprotov6/tf6server/server.go:857 +0x574
github.com/hashicorp/terraform-plugin-go/tfprotov6/internal/tfplugin6._Provider_ApplyResourceChange_Handler({0x12e0060?, 0xc0004a8140}, {0x14a6360, 0xc00099cf30}, 0xc0001ae230, 0x0)
github.com/hashicorp/terraform-plugin-go@v0.19.0/tfprotov6/internal/tfplugin6/tfplugin6_grpc.pb.go:467 +0x170
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0001b2000, {0x14abb60, 0xc0001044e0}, 0xc000bc2000, 0xc0001b4510, 0x1acb698, 0x0)
google.golang.org/grpc@v1.57.0/server.go:1360 +0xe23
google.golang.org/grpc.(*Server).handleStream(0xc0001b2000, {0x14abb60, 0xc0001044e0}, 0xc000bc2000, 0x0)
google.golang.org/grpc@v1.57.0/server.go:1737 +0xa2f
google.golang.org/grpc.(*Server).serveStreams.func1.1()
google.golang.org/grpc@v1.57.0/server.go:982 +0x98
created by google.golang.org/grpc.(*Server).serveStreams.func1
google.golang.org/grpc@v1.57.0/server.go:980 +0x18c
Error: The terraform-provider-fivetran_v1.1.19.exe plugin crashed!
This is always indicative of a bug within the plugin. It would be immensely
helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue.
Plugin version:
Please specify Fivetran Terraform Provider version you are using.
terraform {
required_providers {
fivetran = {
source  = "fivetran/fivetran"
version = ">= 1.1.17"
}
}
}
Additional context
Add any other context about the problem here.
I tried with all sorts of permutations like adding auth/config section, destintaion_schema etc. However, even with the basics it crashed for hubspot, slack, zoom, intercom, adyen, notion
also, there seem to be no documentation for intercom and adyen

Hey @petero2024, thank you for the feedback, will dig into it right now.
Looks like we missed that destination_schema should be mandatory field itself in resource schema.

these connectors do not work even if destination schema was provided.
I tried with all sorts of permutations like adding auth/config section, destintaion_schema etc. However, even with the basics it crashed for hubspot, slack, zoom, intercom, adyen, notion
also, there seem to be no documentation for intercom and adyen

Yeah, I know, I'm just noticing that provider allows to omit this field, but shouldn't

@petero2024 I've just checked with destination_schema:
resource "fivetran_connector" "hubspot_connector" {
  group_id = data.fivetran_group.testing.id
  service = "hubspot"
  destination_schema {
    name = "hubspot_tftest"
  }
}

Everything works fine on v1.1.19

Reproduced only absence for adyen and issue with omited destination_schema field.
Everything else works.
Will prepare fix for the issues I've reproduced.

hubspot and intercom seem working now.
slack, zoom, adyen, and notion are still crashing regardless destination_schema supplied

There's another issue:
│ When applying changes to fivetran_connector.hubspot_connector, provider
│ "provider[\"registry.terraform.io/fivetran/fivetran\"]" produced an unexpected new value:
│ .config: was absent, but now present.

It will be fixed with https://github.com/fivetran/terraform-provider-fivetran/pull/283

And issue with
panic: Unknown serviceslack

goroutine 82 [running]:
github.com/fivetran/terraform-provider-fivetran/fivetran/common.GetFieldsForService(...)
...

Will be fixed with updated Open API schema, also with next release tomorrow)

I wasn't able to reproduce issue because I've testing on latest main build, not on 1.1.19

sorry, one more thing Google Search console seem to be missing from the docs too. Does it have a fivetran_connector?
I now managed to create incomplete connectors with adding the destination schema for the following:
hubspot, intercom, slack, zoom, notion

Yes, it should be google_search_console, and it's included in resource schema already.

I'll update schema and docs tomorrow to make it consistent with latest API version.

@petero2024 I've released new v.1.1.20, tested hubspot, intercom, slack, zoom, notion - succesfully created.
As for adyen - it's not yet supported in Fivetran API.

Tested on 1.1.20 - no isses.


405 multiple analysis objs

we had alrady merged thsi and I continued working on it, so basically just updating journals and a new simulation2.ini test file


[Bug] Failing to parse Cargo.toml

I'm running cargo debstatus against the a newly cloned popsicle repo.
The following error occurs:
cargo debstatus
    Updating crates.io index
    Updating git repository `https://github.com/pop-os/dbus-udisks2`
    Updating git repository `https://github.com/ids1024/iso9660-rs`
error: failed to select a version for the requirement `clap = "=4.0.8"`
candidate versions found which didn't match: 3.2.23, 3.2.22, 3.2.21, ...
location searched: crates.io index
required by package `popsicle_cli v1.3.0 (/home/werdahias/popsicle/cli)`
Error: cargo metadata returned exit status: 101

This clap version exists: 4.0.8. I suspect that cargo debstatus pulls in the 3.x release track and that causes it to error.
Cheers

This looks like the local crates.io index is out of sync, even though it shows Updating crates.io index as one of the steps. Can you try running cargo update in any project to force an update, then try again?

Hm, I just deleted .cargo/registry and .cargo/.git and ran cargo update in another directory but the error persists. Prefacing the command with CARGO_NET_GIT_FETCH_WITH_CLI=true doesn't work, too.

yeah, semt to be a weird bug