Fix the path for logging when -datadir and working folder specified

Included unit test verifies the implemented logic, but not the actual implementation. #1307

Please see my comments in #1307

From what I see when running the node, the Datafolder paths are always rooted so I'm not sure what this fixes.
If this is to support the case where a non-rooted DataFolder is passed, I'm not sure this is necessary.
Also the tests seems to be testing the system.IO.Path class rather than any of our classes. Is that intentional?

I stand corrected, they're not if you specify the datadir in the command line.
If there's no root in the DataFolder paths, the current directory will be used, so the questions remain.

@sondreb @Aprogiena  I found the issue.
In NodeSettings.cs if datadir is not null, we create a folder for it, but the DataDir property itself stays root-less, so all the paths in DataFolder are without a root.
Have a look:
// Setting the data directory.
if (this.DataDir == null)
{
	this.DataDir = this.CreateDefaultDataDirectories(Path.Combine("StratisNode", this.Network.RootFolderName), this.Network);
}
else
{
	// Create the data directories if they don't exist.
	string directoryPath = Path.Combine(this.DataDir, this.Network.RootFolderName, this.Network.Name);
	---> Directory.CreateDirectory(directoryPath);
    ---> this.DataDir = directoryPath;
	this.Logger.LogDebug("Data directory initialized with path {0}.", directoryPath);
}

The fix is to replace
Directory.CreateDirectory(directoryPath);
this.DataDir = directoryPath;

by
this.DataDir = Directory.CreateDirectory(directoryPath).FullName;
and it should be ok.
@sondreb I'll let you do it.

So as we merged the other PR fixing this, we can probably close this, right?

yep.


[Extension] Fix library resource waiting for Godot auto prefix.

Temporary workaround while we wait for godotengine/godot#71274 (beta11 cycle).

Why not just use the version from this comment?

I already did and tested the changes in this branch.


Helm uniq and --set 'something={1,2}' not parsed the same as a list in a YAML file

Problem
# _helpers.tpl

{{ define "chart.global" }}
  {{- $globalDefaults := (dict) -}}
  {{- $globalDefaults := mustMerge $globalDefaults (dict "podSecurityContext" (dict "supplementalGroups" (list))) -}}
  {{ if .Values.global }}
    {{- mustMergeOverwrite $globalDefaults .Values.global | mustToJson -}}
  {{ else }}
    {{- $globalDefaults | mustToJson -}}
  {{ end }}
{{ end }}

{{- define "chart.supplementalGroups" -}}
  {{- $global := fromJson (include "chart.global" .) -}}
  {{- $globalSupplementalGroups := default list $global.podSecurityContext.supplementalGroups }}
  {{- $localSupplementalGroups := default list (.Values.podSecurityContext).supplementalGroups }}
  {{- concat $globalSupplementalGroups $localSupplementalGroups | mustUniq | toYaml }}
{{- end -}}

# test.yaml
supplementalGroups: {{- include "chart.supplementalGroups" . | nindent 2 }}

# testvalues.yaml
global:
  podSecurityContext:
    supplementalGroups:
      - 1
      - 2
podSecurityContext:
  supplementalGroups:
    - 1

helm template --debug chart/ --values testvalues.yaml gives:
supplementalGroups:
  - 1
  - 2

helm template --debug chart/ --set 'global.podSecurityContext.supplementalGroups={1,2}' --set 'podSecurityContext.supplementalGroups={1}' gives (notice that uniq has not removed a 1):
supplementalGroups:
  - 1
  - 2
  - 1

However, if I in the Helm named template chart.supplementalGroups replace $global.podSecurityContext.supplementalGroups with .Values.global.podSecurityContext.supplementalGroups, then uniq works fine and it removes the extra 1.
This confuses me a lot, as I have checked that the kindOf $global.podSecurityContext.supplementalGroups is a slice still, so uniq should work.
Extra info
Output of helm version:
version.BuildInfo{Version:"v3.8.0", GitCommit:"d14138609b01886f544b2025f5000351c9eb092e", GitTreeState:"clean", GoVersion:"go1.17.5"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.2", GitCommit:"f66044f4361b9f1f96f0053dd46cb7dce5e990a8", GitTreeState:"clean", BuildDate:"2022-06-15T14:22:29Z", GoVersion:"go1.18.3", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.4
Server Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.1", GitCommit:"e01e27ba1fcd49adae44ef0984abfc6ee999c99a", GitTreeState:"clean", BuildDate:"2023-03-13T17:51:47Z", GoVersion:"go1.19.5", Compiler:"gc", Platform:"linux/amd64"}
WARNING: version difference between client (1.24) and server (1.26) exceeds the supported minor version skew of +/-1
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
Custom

@naruse666 though as you can see, I use two --set in my original post, one for each thing I set.

From https://helm.sh/docs/helm/helm_install/:

You can specify the '--set' flag multiple times. The priority will be given to the last (right-most) set specified.

@naruse666 if there is no different in the output, how come uniq works with when you had no space in your test, but using two ---set did not?
I am not sure what you are trying to say. Are you saying there is a bug somewhere in my code or in Helm?

Then your problem is different from mine? Unfortunately the entire thread got derailed by that now.
I add all the parts for the error I see in this issue, so what you see there for _helpers.tpl is what I have.

Yes, the mustUniq works fine with setting the Helm parameters in a .yaml file with --values, but not when using --set. As the original post shows.


Update tf-repo to clear the workspace after each repo is processed

Under the current behavior, if the plan includes multiple repos to be processed, the working directory that each repo is cloned into is not cleaned properly after an existing execution. This fixes that bug by performing an rm and mkdir for each repo.

good find, LGTM!


Feature Request: moveMouseRelative

For some situations (Like automating/interacting with games) it is very handy to be able to set the relative movement because most games don't work that well when setting absolute positions (In windows at least).
To circumvent this limitation I have implemented my own moveMouseRelative function in robotjs and build that locally. Though my implementation only covers windows, I have found similar workarounds on the Issue tracker for OSX, don't know how this affects linux.
Expected Behavior
Moving mouse should not cause erratic behavior in games
Current Behavior
Absolute positioning doesn't work well with games running under windows (And according to other issues also doesn't work well with games in OSX)
Possible Solution

Change moveMouse to always use relative commands (As this emulates a mouse better than absolute, which I think is intended for pen tablets etc)
Implement a moveMouseRelative function for those who wish to interact with applications that are dependant on relative movement.

Steps to Reproduce (for bugs)

Open incompatible game (GTA5 in my case)
try to move the camera viewport with mouseMove commands

Your Environment

RobotJS version: ^0.5.1
Node.js version: 8.12.0
npm version: 6.4.1
Operating System: Windows 10

For those interrested here is my current implementation of relative mouse move:
void moveMouseRelative(MMPoint point)
{
#if defined(IS_MACOSX)
	//Osx Implementation
#elif defined(USE_X11)
         //linux implementation
#elif defined(IS_WINDOWS)

	INPUT mouseInput;
	mouseInput.type = INPUT_MOUSE;
	mouseInput.mi.dx = point.x;
	mouseInput.mi.dy = point.y;
	mouseInput.mi.dwFlags = MOUSEEVENTF_MOVE;
	mouseInput.mi.time = 0; //System will provide the timestamp
	mouseInput.mi.dwExtraInfo = 0;
	mouseInput.mi.mouseData = 0;
	SendInput(1, &mouseInput, sizeof(mouseInput));

#endif
}

This issue has been closed because it has been inactive for > 240 days.
You may reopen this issue if it has been closed in error.


LUCENE-9997 Second pass smoketester fixes for 9.0

https://issues.apache.org/jira/browse/LUCENE-9997
This is the second pass of changes to smoketester for the new gradle build.

Adapt to the new source-tgz file layout
Tested gradlew commands
Change --test-java12 with --test-java17
Make Lucene Demo work with new -Dsmoketester=true

The smoketester is tested locally and currently stops at verify maven artifact sigs
command "gpg --homedir /tmp/smoke_lucene_9.0.0_537d435f5ee7c884221371a59673b878d82f6ffa_18/lucene.gpg --verify /tmp/smoke_lucene_9.0.0_537d435f5ee7c884221371a59673b878d82f6ffa_18/maven/org/apache/lucene/lucene-analysis-common/9.0.0/lucene-analysis-common-9.0.0-javadoc.jar.asc /tmp/smoke_lucene_9.0.0_537d435f5ee7c884221371a59673b878d82f6ffa_18/maven/org/apache/lucene/lucene-analysis-common/9.0.0/lucene-analysis-common-9.0.0-javadoc.jar" failed:
gpg: can't open '/tmp/smoke_lucene_9.0.0_537d435f5ee7c884221371a59673b878d82f6ffa_18/maven/org/apache/lucene/lucene-analysis-common/9.0.0/lucene-analysis-common-9.0.0-javadoc.jar.asc': No such file or directory
gpg: verify signatures failed: No such file or directory

Looks like the gradle build does not sign the maven artifacts? @dweiss do you know?

I merged with main where the artifact-signing changes landed. The buildAndPushRelease.py works for me (although it does create that stray file so I suspect it won't run properly unless in dev mode).

I merged with main where the artifact-signing changes landed. The buildAndPushRelease.py works for me (although it does create that stray file so I suspect it won't run properly unless in dev mode).

Thanks. I get the gpg: signing failed: Cannot allocate memory error with gpg, caused by gpg daemon running out of mem during many parallell signing commands. I found a workaround by adding auto-expand-secmem to ~/.gnupg/gpg-agent.conf and then running gpg-connect-agent killagent /bye to restart the agent, and it works. This could perhaps be documented as a prerequisite for using gpg, if you don't want to run serially. Or the script could run the main build in parallel and then run just the signing serially.

@mocobeta I got the same as you - looks like LICENSE and NOTICE are not copied into the maven jars. Strange, since they exist in the binary-release jars. Looks like maven task re-build the jars.. Could not the maven task use the pre-built jars that already have NOTICE and LICENSE?
I also notice that MANIFEST.MF is empty in the maven jars, simply one line, which is also wrong:
Manifest-Version: 1.0

I created https://issues.apache.org/jira/browse/LUCENE-10186 for maven artifacts.
Re-opened LUCENE-10174 for the buildAndPushRelease changes.

I use Windows - these scripts are not compatible. I don't think we have to make it a priority to make them compatible. Too many variables to think of.


Support Plone umd loading and refactor theme resources

[x] switch theme resources to dist subdirectory
[x] integrate backend with simple theme
[x] remove styleguide templates

The theme resources should be loaded from the parent directory to keep the rules file separate and the subdirectory is actually a bad idea

This has already been implemented during the live search integration


[BUG] [ws-tool-name] Error while transfer policies which including "Requires Review"

Hi,
I think I found a bug:
Bug Description
Getting an error message during execution
$ ws_copy_policy -u https://saas-eu.whitesourcesoftware.com/api -k ${WS_USERKEY} -o ${WS_APIKEY} -s project -t 5
starting...
validating parameters
using url https://saas-eu.whitesourcesoftware.com/api
found destination project: xxxx. Key value: cloud_backend
found destination project: xxxx. Key value: cloud_backend
found source project: Cloud Backend. Key value: cloud_backend
TOTAL: 2 projects have a destination tag value and should be handled
handling 1 out of the 2 projects.
adding policy Unknown Licenses to the project xxxxx
Error code: 3012
Error message: Invalid license id: -1
Status: FAILURE

Steps to Reproduce
Steps to reproduce the behavior:
When a policy is used which has a license group with "Requires Review" present
Expected Behavior
should be copied as other licenses
Environment Details
last version.

Hi @NatalyaDalid ,
I used the following script to install ws_copy_policy:
pip install --no-cache-dir ws-copy-policy==0.2.2
So I think I have the latest version running.
 Step 4/6 : RUN pip install --no-cache-dir ws-copy-policy==0.2.2     && mkdir /copy_policy
  ---> Running in 324ba7757f6f
 Collecting ws-copy-policy==0.2.2
   Downloading ws_copy_policy-0.2.2-py3-none-any.whl (11 kB)
 Collecting configparser~=5.0.1
   Downloading configparser-5.0.2-py3-none-any.whl (19 kB)
 Collecting requests~=2.25.1
   Downloading requests-2.25.1-py2.py3-none-any.whl (61 kB)
 Collecting certifi>=2017.4.17
   Downloading certifi-2021.10.8-py2.py3-none-any.whl (149 kB)
 Collecting chardet<5,>=3.0.2
   Downloading chardet-4.0.0-py2.py3-none-any.whl (178 kB)
 Collecting urllib3<1.27,>=1.21.1
   Downloading urllib3-1.26.8-py2.py3-none-any.whl (138 kB)
 Collecting idna<3,>=2.5
   Downloading idna-2.10-py2.py3-none-any.whl (58 kB)
 Installing collected packages: urllib3, idna, chardet, certifi, requests, configparser, ws-copy-policy
 Successfully installed certifi-2021.10.8 chardet-4.0.0 configparser-5.0.2 idna-2.10 requests-2.25.1 urllib3-1.26.8 ws-copy-policy-0.2.2
````
regards,
the_stift

Hi @thestift ,
We released a new version which fixes the reported issue :
https://pypi.org/project/ws-copy-policy/0.2.3/
Please notice that the fix also provides a workaround for another bug ( being handled by our application team ) - if a reassign policy is set to some group and the group was removed afterwards - the reassign group will be changed to 'null'.

In such case the copy-policy tool won't copy that specific policy and a message will be logged for that.
For now ,If you have any reassign policy which is set to a 'null' group , change it to an existing group.
Please let us know if the new version works for you as expected.

Hi @rammatzkvosky,
I haven't checked it yet, but from the code side it's seems you are just ignoring the license "Requires Review" which I think has id -1. So this won't be copied over with the other licenses - am I correct with my assumption?

Hi @thestift ,
The mentioned  id is under the filter-license attribute which is not requiered to add policy.
In general , the fix we implemented is a specific workaround for the copy policy tool to overcome an issue of adding a policy with  filter , license =-1 in the WS application ( which was already addressed internally to our application team ).
For example , here is getProjectPolicies output of a Requires Review policy which was generated from a template using the copy policy tool.
Under the filter attribute it  got id -1 automatically .
{
  "policies": [
    {
      "id": 70371,
      "name": "rr_policy",
      "owner": {
        "id": 6899,
        "email"<EMAIL_ADDRESS>        "name": "Ram Matzkovsky"
      },
      "creationTime": "2022-03-10",
      "priority": 1,
      "filter": {
        "type": "LICENSE",
        "licenses": [
          {
            "id": -1,
            "name": "Requires Review"
          }
        ],
        "scoreFrom": 0.0,
        "scoreTo": 0.0
      },
      "inclusive": false,
      "action": {
        "type": "REASSIGN",
        "user": {
          "id": 6899,
          "email"<EMAIL_ADDRESS>          "name": "Ram Matzkovsky"
        },
        "failPolicyCheck": false
      },
      "productLevel": false,
      "enabled": true,
      "policyContextName": "test_proj_2",
      "policyContextToken": "3ebf49d801bf4fc58fd8f09a05ec9da2f2b93c397cc94f9a91da3f48aa4250ce",
      "policyContext": "PROJECT"
    }
  ]
}

Please check the latest version and update if you faced any issues.

thanks a lot for the explanation !


Launch another window via --new-window-if-not-first appears to be broken

VSCode Version: Code - Insiders 1.9.0-insider (27240e71ef390bf2d66307e677c2a333cebf75af, 2017-02-01T11:43:14.109Z)
OS Version: Linux x64 4.8.0-34-generic
Extensions:

Extension
Author
Version

EditorConfig
EditorConfig
0.3.4

lorem-ipsum
Tyriar
1.0.0

theme-glacier
Tyriar
0.0.10

theme-sapphire
Tyriar
0.0.3

vscode-svgviewer
cssho
1.3.0

python
donjayamanne
0.5.7

tslint
eg2
0.8.1

git-project-manager
felipecaputo
1.0.1

vsc-travis-ci-status
felixrieseberg
1.0.5

md-navigate
jrieken
0.0.1

vscode-scss
mrmlnc
0.6.0

csharp
ms-vscode
1.6.2

seti-icons
qinjia
0.1.3

java
redhat
0.0.9

annotator
ryu1kn
0.10.1

There is also a problem where opening files via nautilus will always open a new window.

Pushed to release/1.9.

Verification steps under Ubuntu:

Launch VS Code
On the 'task bar' shift+click or middle click on the VS Code app icon, a new window should launch
Open the file browser (nautilus)
Right click a text file and select open with other application
Select VS Code and hit Select, the file should reuse a window, not create a new one

I'll verify this.

Verified!


Parsing arguments from memory panics

We should instead fail the test and suggest upgrading the tool/using higher specific version
This was the case especially for the new Cheatcode interface which can be used as a case study

I think we shouldn't suggest using any specific version when parsing arguments. User might use cheatcode API directly as well, we should just handle it nicely. Version incompatibility will be resolved with #1481

@MaksymilianDemitraszek could you elaborate on what needs to be done exactly?

We shouldn't rust level panic when we cannot parse cheatcode input


ProcessGroupNCCL alltoall error

Traceback (most recent call last):
  File "./comms.py", line 526, in <module>
    main()
  File "./comms.py", line 523, in main
    collBenchObj.runBench(comms_world_info, commsParams)
  File "./comms.py", line 485, in runBench
    backendObj.benchmark_comms()
  File "/home/ubuntu/param/train/comms/pt/pytorch_nccl_backend.py", line 252, in benchmark_comms
    self.commsParams.benchTime(index, self.commsParams, self)
  File "./comms.py", line 426, in benchTime
    comm_fn=collectiveFunc, compute_fn=computeFunc
  File "./comms.py", line 164, in runColl
    comm_fn(self.collectiveArgs)
  File "/home/ubuntu/param/train/comms/pt/pytorch_nccl_backend.py", line 108, in all_to_all
    async_op=collectiveArgs.asyncOp,
  File "/usr/local/lib/python3.6/dist-packages/torch/distributed/distributed_c10d.py", line 1827, in all_to_all_single
    work = group.alltoall_base(output, input, output_split_sizes, input_split_sizes, opts)
RuntimeError: ProcessGroupNCCL only supports alltoall* for NCCL lib version >= 2.7.0

However setting NCCL_DEBUG=INFO I see i have a NCCL lib version >=2.7.0
ip-172-31-44-177:11401:11401 [0] NCCL INFO Using network AWS Libfabric
NCCL version 2.7.8+cuda11.0
ip-172-31-44-177:11404:11404 [3] NCCL INFO Bootstrap : Using [0]ens32:<IP_ADDRESS><0>

However if I remove the --collective stanza altogether it works

@amrragab8080 Could you tell us on which platform you are testing ? And the exact test command ? Thanks.

I am specifically testing the Collective-Comms benchmark. I am using AWS with the p4d - A100s with Pytorch 1.7
My stack is built according to this: https://github.com/aws-samples/aws-efa-nccl-baseami-pipeline
/opt/amazon/openmpi/bin/mpirun -np 128 -N 8 --hostfile hostfile \
-x PATH -x LD_LIBRARY_PATH -x NCCL_ALGO=ring -x NCCL_DEBUG=info -x RDMAV_FORK_SAFE=1 \
-x FI_EFA_USE_DEVICE_RDMA=1 --mca pml ^cm --mca btl tcp,self \
--mca btl_tcp_if_exclude lo,docker0 --bind-to core --map-by numa \
 /home/ubuntu/param/train/comms/pt/comms.py --master-ip <IP_ADDRESS> \
--b 8 --e 8192M --n 100 \
 --f 2 --z 1 --collective all_to_all

Linked issue
https://github.com/pytorch/pytorch/issues/47291
all2all will be merged in the Pytorch 1.7.1


Toolchain lookup is broken in v0.7.0.

For some reason, this code isn't working properly:
        let settings = (params.settings as! JSValue)[languageServerSettingsKey]

        guard let toolchainPath = settings["toolchainPath"].string else {
            throw "The path to the Toolchain must be set."
        }
        self.toolchainPath = toolchainPath
        log("configuration: toolchainPath set to %{public}@", category: languageServerLogCategory, toolchainPath)

        self.packagePath = "\(projectPath!)/Package.swift"
        self.includePath = "\(toolchainPath)/usr/lib/swift/pm"
        self.swiftPath = "\(toolchainPath)/usr/bin/swift"

Need to look into why the proper settings dictionary isn't being retrieved.

The work-around for now is to create a link in your /Library/Developer/Toolchains directory.
cd /Library/Developer
sudo mkdir Toolchains
sudo ln -s /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain swift-latest.xctoolchain

This is only necessary if you're using the Xcode version of Swift instead of the toolchain drops.

Looking at this again, I forgot to save the changes to settings.json. The simple workaround of setting the swift.toolchainPath does work.
Add this to your settings.json file:
"swift.toolchainPath": "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain swift-latest.xctoolchain"

Should be fixed in v0.8.0.


Bool function SGDTrainer::initFromStream

What on earth is the point of this as a bool when it only returns true? Should be void.

Good point. Pull request?

Fixed by 65d4f8c63ad57d9bd68a13962fb5a341580f65d9


RYA-301 owl:ReflexiveProperty inference

Description

Added owl:ReflexiveProperty inference: If :hasFamilyMember is reflexive, then ?x :hasFamilyMember ?y is true for ?x==?y. Inference engine now loads reflexive properties like it does transitive and symmetric properties, and a visitor expands triples involving reflexive properties to match both when the triple actually exists or when the subject and object are the same.

Minor cleanup to wrap up latest inference changes: added/fixed configuration constants to enable/disable those inference visitors that were missing them or using the wrong one; fixed packaging for two test classes.

Tests
Test rewriting done by ReflexivePropertyVisitor; test that InferenceEngine correctly determines property types; test queries involving reflexive properties.
Links
Jira
Checklist

[x] Code Review
[x] Squash Commits

People To Reivew
@meiercaleb @pujav65 @ejwhite922 @isper3at

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/462/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/464/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/467/Failed Tests: 3incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.prospector: 3org.apache.rya.prospector.mr.ProspectorTest.testCountorg.apache.rya.prospector.service.ProspectorServiceEvalStatsDAOTest.testCountorg.apache.rya.prospector.service.ProspectorServiceEvalStatsDAOTest.testNoAuthsCount


Add basic styles for output terminal

When https://github.com/launchrctl/web/pull/22 merged we need to fix terminal and probably actions list styles and components.
Current view:

Imo should be something like this:

Running action first.
Collapsible fixed block in bottom.
Tabs style navigation.


ivolo/disposable-email-domains

Include (or replace) https://github.com/ivolo/disposable-email-domains

See also https://github.com/martenson/disposable-email-domains


Feature - archive a project

working on #4021

Closing this out in favor of a ProjectLifecycle-based approach to be considered, instead of a boolean on the table.
Thanks for trying it out!


optimize: add tcc fence log clean task delay check

[ ] I have registered the PR changes.

Ⅰ. Describe what this PR did
ScheduledThreadPoolExecutor#scheduleWithFixedDelay() 方法中，long delay 参数不能 <=0，否则会抛出异常。可以对 cleanPeriod 做一个 check, 当值 <=0 时，不启动 clean task 定时任务
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #5089 (1e1ed71) into develop (0a09db2) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

:exclamation: Current head 1e1ed71 differs from pull request most recent head 7e9a343. Consider uploading reports for the commit 7e9a343 to get more accurate results

@@              Coverage Diff              @@
##             develop    #5089      +/-   ##
=============================================
- Coverage      48.48%   48.44%   -0.04%
+ Complexity      4139     4137       -2
=============================================
  Files            743      743
  Lines          26520    26522       +2
  Branches        3294     3295       +1
=============================================
- Hits           12857    12848       -9
- Misses         12264    12275      +11
  Partials        1399     1399

Impacted Files
Coverage Δ

...in/java/io/seata/rm/tcc/config/TCCFenceConfig.java
0.00% <0.00%> (ø)

...rage/redis/store/RedisTransactionStoreManager.java
72.06% <0.00%> (-2.09%)
:arrow_down:

...torage/file/store/FileTransactionStoreManager.java
55.62% <0.00%> (-0.65%)
:arrow_down:

...o/seata/server/coordinator/DefaultCoordinator.java
44.67% <0.00%> (+0.40%)
:arrow_up:

麻烦将pr的登记转到2.0.0的md中，该pr将合并到2.x分支

@a364176773 PR登记已转到2.0.0.md

优化的，develop也提一个的吧？

@wangliang181230 @a364176773 往 2.x 分支上也提交了一个。这个 PR 合到 develop 上吧


Use better MIME type for TTF.

http://www.iana.org/assignments/media-types/application/font-sfnt

Hello @jdm!
Thanks for your email about the activity on the repo. I have no idea why notifications got turned off for it, but at least no one got impatient and withdrew their PRs! Some good work had been sitting here for a while now.
I didn't realize the Servo project was using my humble little crate! I'm quite honored! If I had known, I would have been more on top of maintenance. Let me know if there's anything you guys need.
Nothing I've merged today appears to have been a breaking change. #6 was close but it shouldn't break previous usage of guess_mime_type(). This looks good to merge as-is.
I'm going to work on making get_mime_type_str() copy-free, because I don't like that it has to create a new lowercase String and I know I can do better. Do you think it should handle non-ASCII uppercase to lowercase conversions or no?


http conn manager: configure cidr_ranges for internal address

This PR addresses the issue highlighted here -> https://github.com/envoyproxy/envoy/issues/19844
Adds cidr_ranges to http connection manager's internal address configuration API
adds helper function to determine if cidr_ranges is empty in cidr_ranges.cc
Adds unit test for same

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@ggreenway - thanks for reviewing this. I was trying to generate the docs as well using ./docs/build.sh but i've been running into this issue and haven't had any luck trying to figure out how to fix it. Do you have thoughts / suggestions ?

➜  envoy git:(devesh24/internal-address-enhancement) ./docs/build.sh
INFO: Build option --action_env has changed, discarding analysis cache.
ERROR: /private/var/tmp/_bazel_devesh.kandpal/eaa029ba95e9ee447c7dcec0acedcbf2/external/base_pip3_sphinx/BUILD.bazel:22:11: no such package '@base_pip3_importlib_metadata//': The repository '@base_pip3_importlib_metadata' could not be resolved: Repository '@base_pip3_importlib_metadata' is not defined and referenced by '@base_pip3_sphinx//:pkg'
ERROR: Analysis of target '//docs:html' failed; build aborted:
INFO: Elapsed time: 0.638s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (373 packages loaded, 3263 targets configured)
    currently loading: @base_pip3_uvloop// ... (8 packages)
    Fetching @local_config_xcode; Fetching the default Xcode version

@ggreenway - when you have a moment - could you please take a look at the PR ? Thanks.

@ggreenway - gentle reminder, if you could take a look at this PR when you have a moment. Appreciate your time!

@deveshkandpal1224 please fix DCO

closing this PR because of issue fixing DCO. Current branch has other commits from main which is making the commit history difficult to fix. Will create a separate PR with the changes proposed from this PR in place.

@deveshkandpal1224 its much better just to fix DCO on this PR and force push
the new PR has lost all the existing reviews, and makes the reviewers job harder


Running linting

Sample pre commit linting in a file called .pre-commit-config.yaml
repos:
  - repo: https://github.com/PyCQA/autoflake
    rev: v2.3.1
    hooks:
      - id: autoflake
        args: [--remove-all-unused-imports, --remove-unused-variables, --in-place, --recursive]

  - repo: https://github.com/psf/black
    rev: 24.4.0
    hooks:
      - id: black
        args: [--line-length=180]

I'd suggest trying ruff for linting, formatting and import sorting to consolidate to one tool and for performance.
e.g.
repos:
  - repo: https://github.com/astral-sh/ruff-pre-commit
    # Ruff version.
    rev: v0.7.1
    hooks:
      # Run the Ruff linter.
      - id: ruff
        args: [ --fix ]
      # Run the Ruff formatter.
      - id: ruff-format


auth_complete is not used as a view

The function is only called from the authentication backend.
Move the code to the authentication backend.

This is to make the backend simple, and technically speaking the backend is just a wrapper for auth_complete, which is part of django-mfa2


Fancy Zones: Multiple windows of the same application snapping to the same zone

Microsoft PowerToys version
0.59.1
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
I am using Fancy Zones to quickly set up a system monitoring machine's window layout in a business environment but am having issues with the "Move newly created windows to their last known zone" feature. This machine is running 7 monitors and we have our different resource monitors set up in specific spots. Most applications work fine and snap to their last known location on reboot but I am having issues getting it to work with web browsers. We have 3 separate Edge windows and 7 separate Chrome windows. Unfortunately, I am not able to upload a bug report log as I found sensitive information in the log.
Steps to reproduce:

Set up custom layouts and snap windows to desired locations
Reboot machine
Open Edge and click restore; Open Chrome, if start up settings are not configured click restore.

✔ Expected Behavior
Separate windows of the same browser type should be treated as separate windows and snap to their last known location.
❌ Actual Behavior
This may be a limitation of how Edge and Chrome handle the at startup config or page restoration process but I thought I'd add it here. I hope this can be addressed or maybe verbiage should be adjusted to something like "Move newly opened applications to their last known zone" or something.
Upon startup it seems Fancy Zones selects one of these windows for each application, places it in it's last known location, then stacks the remaining windows under or over that. Edge and Chrome and exhibiting slightly different behavior, though.
Edge:
If the system is just rebooted, Edge will give you the option to restore your pages the next time it's opened, keeping them as separate windows. Upon doing this it behaves as described above with all windows being stacked on the same zone.
If you close Edge properly first it will behave according to its configured start up settings. "Open tabs from your previous session" will only pick tabs from 1 window and will not restore multiple windows while "Open a specific set of pages" will open the pages in 1 window. This seems like a limiting factor but behaves as expected.
Chrome:
Remembers multiple windows and will open them as such if startup browser settings are set to "Continue where you left off" but one window will be snapped to a zone and all other windows will be stacked on the same zone.
Other Software
No response

I have experienced the same issue with Chrome.  This behavior is recent (as of a few months) - a previous version of PowerToys (can't remember exactly) handled the multiple Chrome windows correctly and remembered them in their separate zones.

Thanks for your input! I ended up using your tip to open all my browser based monitoring tools as separate windows. --Kiosk ended up not being useful for my use case but --app= was great.
I'm not too familiar with Chromium but my hope was that this would open them as a sort of Chromium based application instead of a new tab or browser window and Fancy Zones would see them as separate but it unfortunately did not help. I still have all the Chrome windows and all the Edge windows stacking on top of each other upon reboot.
Hopefully this can get resolved as it would make my mornings so much easier. For now using the zone snapping across multiple monitors helps a lot but I'd really like to get this completely automated.

Haha I'm glad some of my info was useful.
Agreed!  I'd love to see this issue resolved as well.
I refuse to downgrade to an earlier version even though I know this used to work how we want it to.

Just to keep up the give and take. I run a Chrome extension that auto refreshes the page at a interval I can set. --app= actually disables extensions but you can get them to work again by adding --enable-extensions to your command line argument.
Example: "C:\Program Files\Google\Chrome\Application\chrome.exe" --app=https://YourSiteHere --enable-extensions
Hopefully you find that useful. :)

Oh that's really good to know, thanks!

Same behavior with Obsidian (Electron app). Multiple instances of the app and their detached window are treated as the same app in Fancyzones. On restart, windows from Obsidian instance 1 are snapped in the same zone and monitor as the last opened windows from Obsidian instance 2.

Confirmed issue still exists.
TL;DR;
⭐ Unchecking this setting 'fixed' the issue for me:

Overview
1: Worked
I use multiple Chrome profiles (dev, work, personal, etc.) and close/open profiles as I context switch. Previously, when I would open a Chrome profile, all the windows would restore to their previous positions.
2: Broke
I'm not sure if it was an update or me changing settings but a few days ago I started experiencing the same issue. When I open a Chrome profile, all the windows open in the same zone as whatever window Chrome decided to open first.
3: (hot) Fixed
What solved my issue was unchecking the Move newly created windows to their last known zone  setting.

Deets
The documentation states "Automatically move a newly opened window into the last zone location that application was in." so maybe this is the intended functionality..?

ℹ I am new to PowerToys and am reacclimating myself to Windows in general (just switched back after serving a 5 year sentence in Macintosh correctional Macilities, as required by previous employer) so I could simply be misunderstanding the settings.
Don't shoot me, I'm just a guy trying to hack myself through each work day until I have the time to open the (black) rabbit hole of migrating my 400+ Mac keybindings over to Windows... 😭
(stumbled upon this thread and wanted to post in case my fix helps someone else)

I'm sure unchecking this setting has side effects I haven't noticed yet and is not a valid 'solution' for others, just mentioning it in case it helps someone else until this is actually resolved. Or maybe this is the intended functionality, I dunno. 🤷
Specs / Versions
Windows
Edition: Windows 11 Home
Version: 21H2
OS build: 22000.978

PowerToys
v0.62.1

Chrome
Version 105.0.5195.127 (Official Build) (64-bit)

Upvoting, similar issue. The other possible workaround is to add Chrome to exceptions but then you can't snap its windows other than built in way.

Thanks @pbriggs28 , this was driving me up the wall.

same behavior with Chrome apps and Edge apps

To contribute my feedback to the conversation:
I've just recently picked up FancyZones and it gets me so much more out of my four-monitor setup.
As they're not stacked 2x2, the snap to last zone feature makes saves me so many mouse flicks snapping them manually.
The problem I run into as a designer is that the CAD software I operate opens in two separate application windows that the snap to last zone feature does not distinguish between, so it just stacks them on the same zone.
I'd exclude them and go back to losing two full screens of real-estate, but it really helps having one or two slim pdf or excel windows on the same screen without fiddly resizing (which messes with the software, as opposed to the clean control over window size FancyZones allows) or constant alt tabbing, which defeats the whole purpose.
I think an elegant solution would be a /switch you could add in the existing exclusion list after an application's name on the same line, controlling what it's excluded from.
For instance, to use FancyZones on chrome but exclude it from snap-to-last:
chrome.exe /L
This is simple and expandable without interfering with the existing system so long as you use an illegal character like '/' or '?'.
Forget expanding it though, as I can imagine the debugging migraine if you added even a handful of these with how many applications there are out there to break a conditional setting.
A separate exclusion list for snap-to-last would do the trick too, and it'd go a long way, but a whole list for one setting doesn't quite feel right.
 As a CAD designer, my hand is glued to the mouse at all times. Even [Ctrl+Shift+Win+Arrow Keys] would be significantly more one-handable, and I'd love to customize it if overriding the windows default isn't as hard as it sounds. That's probably the only other pain point of this entire software package for me, but it's not really a relevant comment here.
Anyways, FancyZones is the best <3
Thanks for reading, and happy coding everyone!

Hmmm, it seem is Chromium issue. New windows always same position old windows if already opening (work if kill task in task manager). I want to uninstall Chrome and only using Edge, but this issue forced me using both Chrome and Edge if want to open each browser each monitor.


Explanation of all settings in sample project menu

I noticed there are some settings in the menu that are not explained in the documentation. Under Tracker Settings there are 'Active Observation', 'Multi-Anchor Placement', 'Single-Anchor Placement' and 'Single-Anchor Scaled'. What do these do?

Good call. We'll try to get this information updated in our documentation in our next round of updates.
Internal reference number is 38627534.


Login method not working (Open to fixes)

It seems there is an Internal Error 500 when trying to log in to HAC. As this method worked before, it could because of a change in how HAC handles logins. I've tried many combinations of headers in the HttpClient, however none of them works. It may be time for a migration unless there is a possible fix.

Not sure if this is still needed!
I remember there was a token generated when you started up the main /login page. It is required that you put this in the post-login request.
Looking to get back into this to develop a robust API! I love the one you have built!

It turned out that the token was the issue! Now there are so many new issues since its been 2 years since I worked on this code. I'll push the fixed code soon~ Thanks for your help!
I'd love to add you on Discord but your tag is invalid, add me on Phytal#8213


Conditional Ergo Expression fails when contained within a {{#with}} and {{#ulist}}

Describe the bug
This could be user error but I think there's a bug when using a conditional Ergo expression inside a complex model.
Here is the model....
enum State {
  o ACT
  o NSW
  o NT
  o SA
  o QLD
  o TAS
  o VIC
  o WA
}

concept VendorPerson {
  o Party party
}

concept Address {
  o String street
  o String suburb
  o String postCode
  o String lotSectionNumber optional
  o State stateTerritory
}

participant Party extends AccordParty {
  o String fullName
  o String email
  o String mobile
  o String ABN
  o Address address
}

asset MyContract extends AccordContract {
  o Party agent
  o VendorPerson[] vendorPersons
}

Here is the grammar....
#### AGENT

{{#with agent}}
{{fullName}}\
{{#with address}}{{street}}, {{suburb}}, {{stateTerritory}} {{postCode}}{{/with}}\
email: {{email}}\
mobile: {{mobile}}\
{{%
    if length(agent.ABN) > 0
    then "ABN: " ++ agent.ABN
    else ""
%}}
{{/with}}

#### VENDOR(S)

{{#ulist vendorPersons}}
{{#with party}}
{{fullName}} (Private Individual)\
{{#with address}}{{street}}, {{suburb}}, {{stateTerritory}} {{postCode}}{{/with}}\
email: {{email}}\
mobile: {{mobile}}\
{{%
    if length(party.ABN) > 0
    then "ABN: " ++ party.ABN
    else ""
%}}
{{/with}}
{{/ulist}}

The following data.json was used as test data.
{
    "$class": "org.accordproject.ulist_party.MyContract",
    "contractId": "1faHJLoIRxQphIRoXxjpZZZsyEi",
    "agent": {
        "$class": "org.accordproject.ulist_party.Party",
        "fullName": "Peter Parker",
        "email"<EMAIL_ADDRESS>        "mobile": "0432 232323",
        "address": {
            "$class": "org.accordproject.ulist_party.Address",
            "street": "335-339 Camberwell Rd.",
            "suburb": "Camberwell",
            "postCode": "3142",
            "stateTerritory": "VIC"
        },
        "ABN": "",
        "partyId": "1faHNZ0ZHPdomxjge22rj6rj7MK"
    },
    "vendorPersons": [
        {
            "$class": "org.accordproject.ulist_party.VendorPerson",
            "party": {
                "fullName": "Jack Walnut",
                "partyId": "1faHQ7sXpJbyVXsKt7FVIxB1NDv",
                "email"<EMAIL_ADDRESS>                "mobile": "0432 123456",
                "ABN": "12 345 678 900",
                "address": {
                    "$class": "org.accordproject.ulist_party.Address",
                    "street": "335-339 Camberwell Rd.",
                    "suburb": "Camberwell",
                    "postCode": "3142",
                    "stateTerritory": "VIC"
                }
            }
        },
        {
            "$class": "org.accordproject.ulist_party.VendorPerson",
            "party": {
                "fullName": "Frank N Furter",
                "partyId": "1faHQ7sXpJbyVXsKt7FVIxB1NDv",
                "email"<EMAIL_ADDRESS>                "mobile": "0432 987654",
                "ABN": "",
                "address": {
                    "$class": "org.accordproject.ulist_party.Address",
                    "street": "335-339 Camberwell Rd.",
                    "suburb": "Camberwell",
                    "postCode": "3142",
                    "stateTerritory": "VIC"
                }
            }
        }
    ]
}

All of the above were used as inputs to the following draft command.
$>  cicero draft --template . --data ./data.json --output ./text/sample.md --unquoteVariables
Observed behaviour
The first Ergo expression (i.e. AGENT) works fine and renders the following markdown.
#### AGENT

Peter Parker\
335-339 Camberwell Rd., Camberwell, VIC 3142\
email<EMAIL_ADDRESS>mobile: 0432 232323\

However, the second Ergo expression (i.e. VENDORS) throws an error...
error: Type error (at file formula_393cac54e12a308db70b7c356580f67850c5469e9085161768f68d9eba5c581e line 2 col 14). The field `party' does not exist in type `{agent: Party, contractId: String, parties: ~org.accordproject.cicero.contract.AccordParty[]?, vendorPersons: VendorPerson[] ..}'
    if length(party.ABN) > 0

Expected behavior
Expected the following markdown...
#### AGENT

Peter Parker\
335-339 Camberwell Rd., Camberwell, VIC 3142\
email<EMAIL_ADDRESS>mobile: 0432 232323\

#### VENDOR(S)
-  Jack Walnut (Private Individual)\
   335-339 Camberwell Rd., Camberwell, VIC 3142\
   email<EMAIL_ADDRESS>   mobile: 0432 123456\
   ABN: 12 345 678 900\

-  Frank N Furter (Private Individual)\
   335-339 Camberwell Rd., Camberwell, VIC 3142\
   email<EMAIL_ADDRESS>   mobile: 0432 987654\

Version
$ cicero --version
0.21.8

ZIP Archive
ulist_party.zip

I am having the exact same issue Martin. I'm not sure if it can be solved with clever reformatting of the text so the ergo expression sits outside the ulist/with - but either way it would be nice to be able to just do it as you've proposed above.


fix: Occasionally missing red squiggles under errors

This PR intends to resolve/mitigate #139. However, I couldn't reproduce the issue myself so I can't confirm the fix myself. Moreover, it may improve the mixed experience reported in #126.
Instead of creating a new decoration object with every request, only a single one is created.

Indeed, good catch ! If you don't remove previous decorations, VSCode will just migrate them and never remove them from the code (you'd have to assign them empty ranges for that).


Clarify step 3

For step 3:

In the table of contents, hover over the selected layer and click More Options > Copy

You might want to mention that you have to hover over the three '•••' else, 'More options' will not appear.

thanks for the feedback @jsolly!  you're referring to the lab below, correct?
https://github.com/Esri/geodev-hackerlabs/blob/gh-pages/design/customize_vector_map/lab.md

yes @jgravois I must have put my comment in the wrong section. Woops!

this is definitely the right place.  just needed a little clarification.  you can find a proposed fix in #140.  let me know if it seems sufficient.


[SPARK-45783][PYTHON][CONNECT] Improve error messages when Spark Connect mode is enabled but remote URL is not set

What changes were proposed in this pull request?

This PR improves the error messages when SPARK_CONNECT_MODE_ENABLED is defined but neither spark.remote option nor the SPARK_REMOTE env var is set.
Why are the changes needed?

To improve the error message. Currently the error looks like a bug:
url = opts.get("spark.remote", os.environ.get("SPARK_REMOTE"))

>          if url.startswith("local"):
E          AttributeError: 'NoneType' object has no attribute 'startswith'

Does this PR introduce any user-facing change?

No
How was this patch tested?

New unit test
Was this patch authored or co-authored using generative AI tooling?

No

cc @HyukjinKwon @zhengruifeng

cc @HyukjinKwon @zhengruifeng I've addressed the comments.

Merged to master.


Publish goals for Phase 2

Make this part of roadmap for the project and publish on GitHub. Similar stuff done by Programs weekly scoping and retros in the collaboration repo.

Done!
https://github.com/TBD54566975/collaboration/blob/main/planning/web5-getting-started.md

70256acc853dd6a1a2c0dc7ed2b878a9acca6a15


Support for XHR options

This pull request expands the load(url) method to support object initialisation. This means you will be able to add headers and other request specific properties to the load function.
Example:
this.wavesurfer.load({
    url: '/url/to/file.wav',
    requestHeaders: [
        {
            key: "Authorization":
            value: "my-token"
        }
    ]
});

Other options within ws.util.ajax will also be overridable.
Short description of changes:

I've added the support for adding request headers on the the XHR request.
I've handling the support for having the url variable both as a string and as a object.
I've added a preload check whether the object as a minimum contains a url property.

Breaking in the external API:
Should not be any.
Breaking changes in the internal API:
Should not be any.
Todos/Notes:
We could argue that url is not a suitable name for the variable anymore, since it can now be a string, object and an element.
Related Issues and other PRs:
Authorization headers enhancement #1038
#1100

@janhartmann refactored the changes and added an xhr parameter. Instead of passing the object to load use that wavesurfer option instead and supply it with an object, e.g.
var xhr = {
    requestHeaders: [
        {
            key: "Authorization":
            value: "my-token"
        }
    ]
}

Also incorporated the withCredentials option from #1100.

This is perfect for our needs, thank you so much!


Add PULL REQUEST and ISSUE TEMPLATES for the "openebs/upgrade" repo

Description
Add PULL REQUEST and ISSUE TEMPLATES for the https://github.com/openebs/upgrade repo
Possible Solution
Check templates https://github.com/openebs/cstor-csi/tree/master/.github for the idea for configuring the templates.

@prateekpandey14 I would like to work on this issue!

Great @Hard-Coder05 , assigned  :+1:

@prateekpandey14 I have made the PR. Do review it once!

This issue was addressed in the PR https://github.com/openebs/upgrade/pull/54


Customisable default option

Option to default to share/copy the cleaned link without having to do an extra click on the UI.
PS: if this seems viable, I'd like to work on this issue :)

The links are not expected to be always transformed immediately, for example expanding the short link may take seconds, so it can't be a seamless experience. Whereas if we show the UI during the time it's processing then the UI dismissing itself is also a bit strange given that the user has already seen the UI which can provide alternatives that's just one click away. So unfortunately I don't think this can work well (also the reason I didn't implement it myself.)

The links are not expected to be always transformed immediately, for example expanding the short link may take seconds, so it can't be a seamless experience. Whereas if we show the UI during the time it's processing then the UI dismissing itself is also a bit strange given that the user has already seen the UI which can provide alternatives that's just one click away. So unfortunately I don't think this can work well (also the reason I didn't implement it myself.)

alright, thanks for the detailed explanation.


Support for connection to Neo4j Aura

Driver version**: .NET driver 4.0.0-alpha
.Net Core 2.2 web api
It would be great if the v4-driver would support connecting to the new Neo4J Aura service, from what I understand, that is not yet supported, which would mean that I currently need to downgrade my .NET Core -version to 1.0 (lame) and use the 1.7.2-driver instead.

Hi @davidwandar ,
First a warning that the 4.0.0 drivers are still in pre-release stages, it is not yet ready for production use. You can of course using it in your development, but pls keep in mind the API is not stable yet.
Then for Aura support, the new 4.0.0 drivers shall support Neo4j Aura. We just put out a new beta01, could you give it a try and let us know if it works as expected?
The new 4.0 drivers does not have encryption on by default, while I think Neo4j Aura may enforce encrypted connections by default. So if you encounter any connection issues, check if your encryption settings are correct on two sides.
The full changelog can be found here
Cheers,
Zhen

Thanks for the response. I just realised that Neo4j Aura appears to be running v3.5 wich would exclude itself from this driver, correct?

Hi @davidwandar,
4.0 driver supports 3.5 and 4.0 servers. But when using the driver with 3.5, you cannot use features only supported by 4.0 servers such as reactive and database names.
Cheers,
Zhen

Thanks for your help. I am now up and running on the new beta 👍

Hi @davidwanda,
I am closing this issue as it seems your problem has been solved. Let us know if you found anything while using this driver.
Cheers,
Zhen


[docs] Improvements for Start tab [skip ci]

I took a closer look at the Start tab in the new documentation https://ddev.readthedocs.io/en/latest/ and changed a few things:

fixed several small typos
corrected the position for !!!warning, !!!note, !!!tip (they must be separated by a new line from everything above)
removed extra spaces
fixed code style for bash inserts
removed/changed links from the old docs
"macOS Full Disk Access for Special Directories" was in Windows tab
"macOS-specific NFS debugging" was in the wrong place (not in the macOS tab, but under it, and with broken formatting)
added formatting for file paths (e.g. settings.php became settings.php)

Awesome, thanks! I just enabled pull requests on readthedocs, https://docs.readthedocs.io/en/stable/pull-requests.html - so you should be able to push another commit and see the results on readthedocs.

Opened https://github.com/readthedocs/readthedocs.org/issues/9422

Thanks for the great work!

If you're willing to try it, please rebase since #3980 went in.

Done.

the suggested admonition probably needs looking at when running mkdocs serve

Done.

If you want to take on tabbing the extra-config section please add that. If not, it can wait.

I'm busy with other things now.

We have to find out why the spellchecker didn't flag the egregious typos.

I also noticed (locally with my spellchecker) that any spell checking rules don't apply to lines that aren't at the root level. Literally just indent and every check is lost.

I think your theory is correct about spellchecker. Opened

https://github.com/drud/ddev/issues/3981
Sorry you had to see all those typos! There are plenty more, will have to sort that.

Thanks so much for doing this!


Fix: Don't use executeCommand on python sub-shell for WSL

Related: https://github.com/microsoft/vscode-python/pull/24418
Further resolves: https://github.com/microsoft/vscode-python/issues/24422
Shell integration does not exist on windows python repl so dont use execute command on python subshell in this case. --- Guard against WSL too.
This will prevent keyboard interrupt from happening even when setting for shell integration is enabled for python shell (which is currently only supported on mac and linux)

Closing this for now. Just talked with @Tyriar and looks like we won't encounter the keyboard interrupt issue for wsl since readline still seems to be available when in WSL although its not available on windows itself.  Will keep very close eye on this and test this again with @Tyriar to make sure.


Runtime caching. Getting error "start_url does not respond with a 200 when offlineThe start_url did respond, but not via a service worker."

Library Affected:
workbox-build
Browser & Platform:
Google Chrome Version 80.0.3987.116 (Official Build) (64-bit)
Description:
I have cached all website pages using runtimeCaching:
        {
          urlPattern: new RegExp('/'),
          handler: 'StaleWhileRevalidate'
        },
        {
          urlPattern: new RegExp('/page-1'),
          handler: 'StaleWhileRevalidate'
        },
        {
          urlPattern: new RegExp('/page-2'),
          handler: 'StaleWhileRevalidate'
        },
       ...

All pages seems to be cached when I'm inspecting website with Chrome Dev Tools.

When website is tested with Lighthouse, only main page / is shown as available offline.
When other pages is being tested with Lighthouse I am getting an error:
start_url does not respond with a 200 when offlineThe start_url did respond, but not via a service worker.
Also I've tried to add cache expiration in seconds with no success - getting same result.
Is there something I am missing?
Or Runtime cached pages can't be validated using Lighthouse?

I have created a test repository to reproduce this issue:
https://github.com/coolemur/workbox-test
Reproduce:

Run workbox-test on MAMP or other Web server.
Run Lighthouse audit on base url (/).
Result - base url is fully PWA as expected.
Go to page 1 or page 2.
Inspect with Dev tools - it shows that base url and page url are cached (as expected).
Run Lighthouse audit on page url (/page1.html or /page2.html).
Result - Lighthouse audit throws 200 error.

Seems like I've found a solution. (Going to investigate this further)
Looks like each page must have its own manifest.json with start_url.
Created Dynamic manifest (commit, named "Dynamic manifest" in https://github.com/coolemur/workbox-test).
Correct me if there is another cleaner solution.

Anyone found a solution for this issue?

Hey all—I'd recommend following up with the Lighthouse project if you've got questions specific to how they detect the start_url behavior.
If you're running into any issues with functionality separate from Lighthouse audits, we can reopen and dig in further.


Unit Tests and Code Coverage

Build available at https://circleci.com/gh/seanoshea/material-motion-runtime-android/13. Associated code coverage report available at https://codecov.io/gh/seanoshea/material-motion-runtime-android/commit/549ba9f04036f7ae4f5ad6af1911cd8aed12aa4d.
Forced a unit test failure locally and received:
com.google.android.material.motion.runtime.ApplicationTest > testOne[Nexus_6_API_23(AVD) - 6.0] FAILED
> Buildijunit.framework.AssertionFailedError: expected:<1> but was:<0>
	at com.google.android.material.motion.runtime.ApplicationTest.testOne(ApplicationTest.java:32)
:library:connectedDebugAndroidTest FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':library:connectedDebugAndroidTest'.
> There were failing tests. See the report at: file:///Users/sean.oshea/github/material-motion-runtime-android/library/build/reports/androidTests/connected/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 11.74 secs
soshea-mbpr:material-motion-runtime-android sean.oshea$ ./gradlew library:connectedAndroidTest

While I started off trying to get this working with travis-ci, I couldn't successfully get the app to build consistently as documented in https://github.com/material-motion/material-motion-runtime-android/issues/4. Switched over to circleci and was able to get the app to build, run the unit tests and produce code coverage. Not sure if the original intent of the Github issue was mostly to get continuous integration working or if you're ok with a circleci continuous integration implementation.
cc @pingpongboss on this as we had a chat about this on discord.

This is great! Just to clarify, the original intention of the issue is to research how to enable CI for our repos. TravisCI was named as a potential solution, and it is slightly preferred over other CI solutions because our objc/swift counterparts use it. But it looks like enabling CircleCI is a great solution.

@pingpongboss - yep, its unfortunate that I couldn't get travis to work as you mentioned other material-motion counterparts use travis. According to https://docs.travis-ci.com/user/languages/android, their Android support is still in beta though (and has been for the past year or so) - perhaps its not a priority at this time. circleci seems to work fine though.

Please hold on this PR. There are some reservations in Discord about granting circleci read/write access to repos. Will try to resurrect travis-ci efforts.

Went back to the drawing board on this. I think I have the last three travis builds passing:
https://travis-ci.org/seanoshea/material-motion-runtime-android/builds/152863695
https://travis-ci.org/seanoshea/material-motion-runtime-android/builds/152862160
https://travis-ci.org/seanoshea/material-motion-runtime-android/builds/152855028

cc @pingpongboss @jverkoey

Lookin' stable!

@jverkoey The code in travis.yml is exactly the same as it was prior to me previously giving up on travis and trying out circleci. So, the fact that it's stable doesn't have anything to do with changes as part of this PR. Either the build is happening on a more favorable machine, or travis have fixed something with their Android implementation.
But, yeah - it's looking a little more stable at this time.

Oh, that's worrying then hah. Is there a specific question we could ask the Travis CI team to get more information? They're decently responsive on twitter.

Tried pinging them with https://twitter.com/seanoshea/status/763155140404731904 and https://twitter.com/seanoshea/status/763155327101575168, but no response.
https://github.com/material-motion/material-motion-runtime-android/blob/ef1052b5308eb8e860e9eedfb72a773e923a581f/.travis.yml is where I disabled travis-ci the first time. https://raw.githubusercontent.com/seanoshea/material-motion-runtime-android/4f0f228bc6b0af8e3543a9c1ffafe4371b3fc552/.travis.yml is what it looks like now & you'll notice that they are exactly the same.
I think we have a couple of options here:

Reach out to travis and see whether they have any information on whether any changed on their end to help support Android development a bit more. Perhaps ask them if they have any plans to make Android a 1st class citizen on their platform for opensource projects.
Convert the tests to Robolectric which doesn't require a simulator and might help the tests run a little more consistently & continue to use travis.
Go back and use circleci as that appeared to be always consistent.

As a point of reference, here's facebook/rebound's .travis.yml file: https://raw.githubusercontent.com/facebook/rebound/master/.travis.yml
Is there anything going on in there that's different to how we're approaching this?

From their latest build, it appears that they are just invoking smokeTest which looks like https://github.com/facebook/rebound/blob/master/build.gradle#L71. I believe this just builds a jar and doesn't require them to fire up an emulator to run unit tests.
Actually, looking at https://s3.amazonaws.com/archive.travis-ci.org/jobs/152636483/log.txt, I don't believe they are running tests as part of their CI flow at all. Hmmmm.
Had a look at a few Square libraries (I really like their opensource Android stuff) and it looks like they generally rely on travis to build their default gradle target & don't actually ever fire up the emulator:
https://github.com/square/spoon
https://github.com/square/picasso
https://github.com/square/dagger
https://github.com/square/leakcanary
https://github.com/square/android-times-square

Unsure of how best to proceed with this PR. In https://github.com/material-motion/material-motion-runtime-android/issues/4, it was suggested that we could possibly upgrade gradle to help with the stability. Happy to give that a try if you think it would help this PR.
The other option on the table would be to transition over to robolectric tests which doesn't require the emulator to be running to actually run the tests.
So, the tradeoff is between running standard Android tests & potentially running into issues with getting the emulator up and running in the future vs using a non-standard Android unit testing framework in a mocked up emulator.

I'm inclined for us to move forward with this PR and to resolve flakiness/issues over time as they appear. @pingpongboss thoughts?

Right, I think this PR is a step in the right direction. Let's merge it. @seanoshea is this ready to be merged?

@pingpongboss @jverkoey - Yes, I think this is good to go. Gave it one final go with https://travis-ci.org/seanoshea/material-motion-runtime-android/builds/154627845 and it passed, so I think any flakiness has disappeared for the time being.
Once this is merged in, I'll check and see if I can get travis and codecov to pick up the builds.


[fix] Python gateway can not upload to resource center

in #12076 we refactor our resource center, remove the resource table, it is a good refactor but it failed python api upload, this patch try to fix python api upload function
ref: #12076

Codecov Report

Merging #13042 (8148bfd) into dev (e180e16) will decrease coverage by 0.03%.
The diff coverage is 69.23%.

@@             Coverage Diff              @@
##                dev   #13042      +/-   ##
============================================
- Coverage     39.36%   39.32%   -0.04%
+ Complexity     4273     4270       -3
============================================
  Files          1067     1069       +2
  Lines         40121    40104      -17
  Branches       4601     4584      -17
============================================
- Hits          15793    15772      -21
- Misses        22551    22558       +7
+ Partials       1777     1774       -3

Impacted Files
Coverage Δ

...heduler/api/service/impl/ResourcesServiceImpl.java
38.69% <63.63%> (+0.07%)
:arrow_up:

...che/dolphinscheduler/api/python/PythonGateway.java
17.93% <100.00%> (ø)

...r/api/service/impl/ProcessInstanceServiceImpl.java
63.96% <0.00%> (-6.42%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...erver/master/processor/queue/TaskEventService.java
75.00% <0.00%> (-5.36%)
:arrow_down:

...hinscheduler/plugin/alert/script/ScriptSender.java
70.58% <0.00%> (-1.64%)
:arrow_down:

...erver/worker/runner/WorkerTaskExecuteRunnable.java
38.51% <0.00%> (-1.23%)
:arrow_down:

...cheduler/plugin/alert/dingtalk/DingTalkSender.java
34.13% <0.00%> (-0.78%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.86% <0.00%> (-0.55%)
:arrow_down:

... and 31 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


dead code removal / fixes

[ ] ~Closes #xxxx~
[ ] ~Tests added / passed~
[x] Passes black dask / flake8 dask

(factored out of #7215)

Thanks Ryan! 😄


Request to resolve the pop up's

Hi,
We are not able to display output graphs inline ( as embedded objects, like in the earlier release) the popups are annoying and hang.
How to switch back to display the results inline as embedded objects in the latest release.

Well solved the issue by using
%matplotlib inline
import matplotlib.pyplot as plt
import matplotlib


Fix read to not hang after disconnecting from serial

If you read from serial in one thread and disconnect in another thread, the reading thread will hang.  This pull request changes it so that the reading thread raises an exception.

:+1:


Create Template 10 Queue service

Maybe.

What does this service actually do?

The idea is a simple MSMQ.
Queue.Add(T message);
T Queue.Next();
Etc.
The reason for this is to implement the design pattern for "local queuing" of work for the sake of high-performance apps. The idea is to acknowledge to the user to intent to do the work, but to delay the work for the sake of 1) batch 2) continued responsiveness and 3) delayed for undo. I want to build a simple implementation that doesn't reinvent the wheel. Supporting most cases and allowing it to be extensible for other uses. Make sense?

sounds really good

Something like this perhaps.
public class Queue<T>
{
    public static Queue<T> Instance { get; } = new Queue<T>();
    private Queue()
    {
        // private constructor
    }

    System.Collections.Generic.Queue<T> queue
        = new System.Collections.Generic.Queue<T>();

    public event TypedEventHandler<T> Enqueued;

    public void Enqueue(T item)
    {
        Enqueue(item);
        Enqueued?.Invoke(null, item);
    }

    public event TypedEventHandler<T> Dequeued;

    public T Dequeue()
    {
        var item = Dequeue();
        Dequeued?.Invoke(null, item);
        return item;
    }
}

Not a bad idea. I'll start working on a basic implementation for testing. I'm on school holidays at the moment; it's not like I've got any better use for my time.


How to use the IN operator on an attribute of a JSONB column?

Hello,
First many thanks for this great library 🙇♂
Please, with PostgreSQL 11 and Objection.js latest version as of this writing (2.2.14), how to perform a query with the IN operator on an attribute value of a JSONB column, like the following SQL query does?
SELECT * FROM users WHERE metadata->>'countries' IN ('Chad', 'Japan');

I've tried to use the following code with no success:
const countries = ['Chad', 'Japan'];
const query = SomeModel.query().whereIn(ref('metadata:country'), countries);

As this produces the following error:
DataError: select "some_model".* from "some_model" where "metadata"#>'{country}' in ($1, $2) - invalid input syntax for type json

I couldn't find the ->> jsonb operator in the source code of Objection.js.
What would be the best/cleanest way to achieve this? With a raw query? But if so, would it still be possible to use ref in this raw query?
Thank you!
PS: The use of the IN operator for JSONB fields is for example described in this document:
https://medium.com/hackernoon/how-to-query-jsonb-beginner-sheet-cheat-4da3aa5082a3

I forgot to say that, before asking, I've done many tests, many searches on the web and reading of the source code with no success 😟

Try:
const query = SomeModel.query().whereIn(ref('metadata:country').castText(), countries);

That works great! Thanks a lot @elhigu! Kiitos!


Webpack DLL

This massively speeds up recompiling and hot reloading.
The only downside is the DLL must be built before starting the webpack dev server for the first time, and again after updating installed modules.
Use npm run build-dll to build it.
The initial list of modules included in the DLL is based on the largest modules in the browser bundle according to the output of the Webpack bundle analysis. Feel free to adjust it.

Thanks for submitting this PR @kane-c. Supporting DLL builds is great, but it's too big a breaking change to require npm run build-dll before running npm start. If we're going to add this, it needs to be done seamlessly / as part of the same build step.
Also, imports that reference the dist folder such as this one folder are inherently brittle - the folder is intended to be ephemeral and not a constant part of the build system; only files that are already in dist should (locally) reference siblings files.
If the above can be considered, I'm all for adding this.

Thanks for the feedback, couldn't agree more.
I've moved the DLL manifest into kit/webpack (let me know if there's a better place for it) instead of in dist.
Also I added the DLL build step into the browser npm script - the impact on the initial build time is a lot smaller than I thought so it's harmless there. This way there is no breaking change :)

Closing due to releasing a new 3.0.0 kit - please reopen at https://github.com/leebenson/reactql if you feel it's still relevant, thanks.


Jerrard Smith - SprintChallenge UserInterface WIP

@47analogy

Git-Comments

[x] Utilizing Meaningful Commit Messages
[ ] Committing Often: On Every Breakthrough or Feature Completion.
[x] Submitted a Pull Request with your First & Last Name in the title.

Comments

I would like to see you work on future projects towards using all the methods mentioned above. It will help in your future life as a developer and will help you better leverage git version control.
 If you have not yet tried it
Using git from the command line with bash you can do the following:

git commit -m "Implemented Desktop Break-Points
> CSS Break-Points with mediaquery at 1024px max-width
> Tested in Chrome, Firefox
> Fluid transition between breakpoints."

Press Enter when you want a new line. When you see the `>` symbol this means that you have pressed Enter and there is a new line. Remember to close your quotes at the end of your message and press Enter to submit the command.


Viewing ignored file prevents further linting

I'm not sure what the steps to troubleshoot this are—I'm not even sure it's an issue with this package specifically—but here's what I'm seeing...
package.json
{
  "standard": {
    "ignore": [
      "app/assets/javascripts/vendor/*.js"
    ]
  }
}

Linting works as expected until I open an ignored file within app/assets/javascripts/vendor, at which point linting ceases to function on every file. Invoking the linter on a file manually has no effect. The only way I'm able to get linting to function properly again is to restart Atom.
OS X 10.11.1
Atom 1.0.19

Hmm interesting... I will take a look. :+1:

Let me know if you'd like to me provide any additional information

I also encounter this problem, and I try to debug it but I'm not familiar with Atom enough to understand exactly what going on there but I found something that maybe will help you:

In select-style.js inside "requireWithLocalOverride" function, the require loader always throw an error and goes to the catch part.
in the same file, inside "pickStandard" function, the returning object (Linter object) after opening ignored file is always with cmd == 'no-style'.

@ricardofbarros, would be great if can look at this and help me solve the issue.
Thanks!

From what I can tell, this has been fixed with https://github.com/ricardofbarros/linter-js-standard/commit/b863435dbaa7c805d9d33fb2cb595f9f8b3c44c0 (v3.8.0 or later).


Updated Integration Tests Workflow to Resolve OpenSearch Dashboards Compile Issue -2.x

Description

Updated Integration Tests Workflow to Resolve OpenSearch Dashboards Compile Issue seen in PR #434
Added compile step before Cypress runs

Issues Resolved
Related to #434
Check List

[ ] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[data-testid="selectDataToImportButton"] is added in #434. PR434 is not yet merged causing a test to fail. All other tests are passing. Tyler, please take a look and let merge if everything is ok.


Add import numpy as np in concept.md

In line 87 of concepts.md np is used but not imported. This just adds that import statement.
action = np.random.choice(action_list, p=prob_list)

Good catch!

We have integrated this PR internally, so this will go out on the next push to github. Thanks!

Happy to help.

Oh there was need to close it. Our push to github does that and associates the commits with it, so I like to keep it up until we do the push.


GitHub Actions job summaries

Investigate new feature
https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/
Benefit:
View summary of action runs rather than clicking through to see summary.

Example using summaries.
https://github.com/pavelzw/pytest-action

echo "{markdown content}" >> $GITHUB_STEP_SUMMARY
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary


Added link to sharepoint-migration-identity-mapping-tool-azure-active-direct…

…ory-identity-scan.md
Closes https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/2202.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@JoanneHendrickson PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@JoanneHendrickson could you please check and merge? Thanks!

@JoanneHendrickson could you please check and merge? Thanks!


TOOL: Upgrade consult and coordinated planning session

As a dev team, I would like to connect with the devs (before we do the next upgrade) about how we will do the next upgrade, as well as expectations, roles and sharing of skills among the devs.
<> document some of the wok, approach

@Alison - We'll need ot set up a session for this consult this week. I will reach out to Simen and book a meeting invite for Simen, Iman, Bhumin, Andrew.


Mismatch between Globalize and other libraries when dealing with missing skeletons as per TR-35.

Here is another potential spec bug with missing skeletons in Globalize 1.3 which is similar to #764.
See the code sample below:
//Setup
const Globalize = require('globalize');
Globalize.load( require( "cldr-data" ).entireSupplemental() );
Globalize.load( require( "cldr-data" ).entireMainFor('it') );
Globalize.locale('it');

const formatterOptions = {
  skeleton: 'yMMMMdjmm',
};

// Create a localized formatter.
const f = Globalize.dateFormatter(formatterOptions);

// Format a localized date
const localDate = f(new Date(2017,00,01));

// Setup en-US data
Globalize.load( require( "cldr-data" ).entireMainFor('en') );
Globalize.locale('en-US');

// Create an english formatter
const f2 = Globalize.dateFormatter(formatterOptions);
const englishDate = f2(new Date(2017,00,01));

console.log(localDate);
// 1 gennaio 2017 00:00

console.log(englishDate);
// January 1, 2017 at 12:00 AM

Per my read of the TR-35 spec on matching skeletons and what the CLDR data shows, Globalize is doing the right thing. The width of the months is long and there is no weekdays in the above skeleton. However, the output does not match that of iOS and ICU4j which is -

1 gennaio 2017, 00:00

I can do a workaround in a manner similar to what was done for #764 but I wanted to highlight this as another potential cause for trouble.

Thanks Chetan!

A similar issue happens for pt-PT as well.
The spec (TR-35) directs us to use the dateFormatLength full when using the pattern "yMMMMdjm"

Combine the patterns for the two dateFormatItems using the appropriate dateTimeFormat pattern, determined as follows from the requested date fields:
If the requested date fields include wide month (MMMM, LLLL) and weekday name of any length (e.g. E, EEEE, c, cccc), use
Otherwise, if the requested date fields include wide month, use
Otherwise, if the requested date fields include abbreviated month (MMM, LLL), use
Otherwise use

As per the spec, this should end up using the dateFormatLength type long but both ICU4j and iOS end up using the dateFormatLength type short or medium (They are both identical so I am not sure which one is being picked)

Also, all my tests are on CLDR 28

This also happens for es-CL. That is enough information to suppose it is an issue for all locales.

Another example of this helps narrow this down as an ICU4j bug is as follows -
In the locale "fr-BE", for pattern "yyMdjm", we are combining the date and time patterns since the pattern is not available together.
Now, in this case, per my reading of TR-35, we should fall through to using the dateTimeFormatLength = "short" pattern.

Globalize output -> 'd/M/yy HH:mm'
ICU4j output -> 'd/M/yy  à HH:mm'

This is after I overrode Globalize to pick up d/M/yy as the pattern for yyMd so please bear that in mind. The area to focus here is the separator between date and time values.
Per my reading of TR-35, Globalize should use the short pattern, which is what it is doing.
The medium, long and full pattern separators are all "{1} 'à' {0}". ICU4j is using one of these.
Given the observations in the previous comments, I would hypothesize that ICU4j is always using medium dateTimeFormatLength value, making this an ICU4j issue. Thoughts?
(I am using CLDR 28, ICU4j 56 and Globalize 1.3)


[test] Fixing integration test to cleanup cleanly

Commit Message: [test] Fixing integration test to cleanup cleanly
Additional Description:
Fixing the DownstreamSendingEmptyMetadata integration test to cleanup cleanly by closing the upstream connection before closing the client.
Risk Level: Low - tests only.
Testing: Fixed a current test.
Docs Changes: N/A.
Release Notes: N/A.
Platform Specific Features: N/A.
Part of the fix of #18290.
Signed-off-by: Adi Suissa-Peleg<EMAIL_ADDRESS>

Executed with bazel test --config=remote-tsan //test/integration:multiplexed_integration_test --runs_per_test=1000 and did not receive the error.


Dataset length question

Hello
im testing our learning using your code.
Thank you always.
Currently, I have created a dataset with a 1:1 ratio of 8k and 64k datasets.
Afterwards, learning was conducted using code, but
    q_embed = (q * cos) + (rotate_half(q) * sin)
RuntimeError: The size of tensor a (1024) must match the size of tensor b (8192) at non-singleton dimension 2
  0%|          | 0/301 [00:00<?, ?it/s]

An error has occurred.
My prediction is that there will be no problem with the 64k dataset, but a problem appears during the process of learning the 8k dataset.
Should I set the length of the dataset the same when learning?
For datasets shorter than seq-length, I am wondering whether I should pad it.
Thanks for your help.
--seq-length 65535 \

I feel this is a problem with RoPE cache. If we train on 64K seq, each card with 8K tokens, some RoPE implementation in HF will only spawn 8K RoPE sin-cos cache (such as Qwen2, Mistral, but llama3 does not have this issue). But the position index we use can can have range 0-64K

thank you reply 👍


Fix  rule to push  onto list.

Fix for exprs rule:
 exprs
        : exprs COMMA expr
-               { $$ = $1; $$.push($1); }
+               { $$ = $1; $$.push($3); }
        | expr
                { $$ = [$1]; }
        ;

To test out the fix:
$ gulp jison-compile
$ gulp js-merge
$ ( cd test/parser && mocha test003.js  )

  1 passing (15ms)

Fixes this query (the GROUP BY won't parse correctly without this patch):
SELECT a, b FROM T GROUP BY a, b


POST Get_orgs_contact ---line 140 db_query

💡 Summary
Add new REST endpoints that mirror existing sql queries and replace existing sql query with REST
Specifically: Convert "get_orgs_contacts()" TSQL query to an API endpoint
Motivation and context
There are two major reasons to use endpoints in place of sql queries.

Replace the need to know t-sql
Off load data aggregation to fastapi parallel workers

Implementation notes

Gather existing queries from code.
Create new endpoints at fastapi.
Secure new endpoints in same fashion as existing endpoint.

Acceptance criteria

[X] home/models.py model created
[X] dataAPI/schemas.py schema created
[X] dataAPI/views.py functions created
[X] dataAPI/tasks.py function created
[X] Verified endpoint is working
[X] pushed endpoint to api-extended

Endpoint completed and pushed to the api-extended branch


The "delete" button in apps list does nothing

When clicking delete nothing happens.

Hm … I think you are on to something …

The callback that is supposed to be called when clicking the button is never initialized other than Default::default()
I created the issue to not forget :) I'll try to fix it

I'll try to fix it

that would be cool

Fixed in #122


Add support for CSV dataset

Hi,
I like spring-dbunit, unfortunately I work with a legacy database where some columns names contain # characters. The XML datasets fail to parse as # is not allowed in tag or attribute names.
Hence, my proposed patch to support CSV datasets.
I added the support and a unit test demonstrating it in the HSQLDB test.
Please let me know what you think.
Thanks,
Jean

Very cool, thank you!
I've released a 1.1.4.


Add the <search> element

Spec: https://html.spec.whatwg.org/multipage/grouping-content.html#the-search-element
OP: https://github.com/whatwg/html/issues/5811
https://www.scottohara.me/blog/2023/03/24/search-element.html
Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1824121
Safari: https://bugs.webkit.org/show_bug.cgi?id=254327
Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=1294294 (or https://crbug.com/1277435? 🤔)

+1 to this issue. I came here as well to request adding <search>.

https://groups.google.com/a/chromium.org/g/blink-dev/c/5CHw-SXYKGc/m/IPYMJeMTAQAJ
Shipping in Chrome 118: https://chromestatus.com/feature/5126108151808000

Also, available via MDN by now: https://caniuse.com/mdn-html_elements_search


Auto-saving or caching profile/message information as it is typed

If I'm filling out my profile information and refresh the "Edit Profile" page, my changes, unsurprisingly, disappear.
Can there be a mechanism to periodically "auto-save" information a user enters into their profile or into a message? I imagine that users will be writing long blocks of text on their profile (and long, thoughtful messages!), so it would be nice to have a safety net in case something happens to the user's browser (e.g. the accidentally close the app).
The information could go into a temporary cache and re-populate the text boxes in question if the browser is reloaded. But the profile pages should not be updated until the "save" button is actually saved.
Feel free to close the issue if this is not a suitable idea.

BTW I don't have permissions to add labels, so if someone can label this issue appropriately (frontend, priority: low?) it would be appreciated.

Similarly, if I'm refreshing the page or clicking away and have unsaved data, a warning popup would be great (potentially with three options: cancel, save, continue)

Current functionality is fine. Auto-saving is not universally superior, people don't always like their drafts being published.

Very strongly disagree.  Nothing worse than spending a half hour filling something out only for it to disappear.

This is for auto-saving, not warning

Yes, but a warning before closing/refreshing a tab would help. (e.g. chrome sometimes has "Leave this page? Changes you made may not be saved")

Opened a new issue for that https://github.com/Couchers-org/couchers/issues/1635


After closing modal dialog window loses it's scroll focus

After closing dialog window it isn't possible to scroll document anymore.
Considered as blocker.

@Blackening999 Not sure when this issue cropped up, but it looks to be fixed now?

Works now.


Why my rtp video track published to livekit by server-sdk-go is not display on flutter

I use server-sdk-go create room and publish rtp track ,some h264 video can display ,but some h264 rtp packets not display on flutter sdk, use my js code run on web is ok,how can i debug? some config i mistake ?
follow  is livekit debug info,
"participant": "kvs:50:9a:4c:3c:2d:b5"

no video play(use my device rv1126  video capture h264,
but use kvs example h264 file transfer  is ok) ,
audio all is ok,
on my web js code client all is ok,use same rtp forward

2022-07-06T07:34:52.905+0800	INFO	livekit	service/rtcservice.go:211	new client WS connected	{"room": "50:9a:4c:3c:2d:b5", "participant": "user", "connID": "user", "roomID": "RM_e6gBu37aP4iM"}
2022-07-06T07:34:52.908+0800	INFO	livekit	rtc/room.go:276	new participant joined	{"room": "50:9a:4c:3c:2d:b5", "roomID": "RM_e6gBu37aP4iM", "pID": "PA_5JQYKWzKnU8F", "participant": "user", "protocol": 7, "options": {"AutoSubscribe":true}}
2022-07-06T07:35:33.057+0800	INFO	livekit	service/rtcservice.go:211	new client WS connected	{"room": "50:9a:4c:3c:2d:b5", "participant": "kvs:50:9a:4c:3c:2d:b5", "connID": "kvs:50:9a:4c:3c:2d:b5", "roomID": "RM_e6gBu37aP4iM"}
2022-07-06T07:35:33.058+0800	INFO	livekit	rtc/room.go:276	new participant joined	{"room": "50:9a:4c:3c:2d:b5", "roomID": "RM_e6gBu37aP4iM", "pID": "PA_vE4HgC9pzeXV", "participant": "kvs:50:9a:4c:3c:2d:b5", "protocol": 7, "options": {"AutoSubscribe":true}}
2022-07-06T07:35:34.294+0800	INFO	livekit	rtc/participant.go:1151	mediaTrack published	{"room": "50:9a:4c:3c:2d:b5", "roomID": "RM_e6gBu37aP4iM", "participant": "kvs:50:9a:4c:3c:2d:b5", "pID": "PA_vE4HgC9pzeXV", "kind": "audio", "trackID": "TR_AMJuQZmPPHCxh7", "rid": "", "SSRC": 745830919}
2022-07-06T07:35:34.294+0800	INFO	livekit	buffer/buffer.go:187	REMB not supported, RTCP feedback will not be generated	{"room": "50:9a:4c:3c:2d:b5", "roomID": "RM_e6gBu37aP4iM", "participant": "kvs:50:9a:4c:3c:2d:b5", "pID": "PA_vE4HgC9pzeXV", "trackID": "TR_VCGKbmpLww8AWY", "mime": "video/h264", "layer": 2}
2022-07-06T07:35:34.295+0800	INFO	livekit	rtc/participant.go:1151	mediaTrack published	{"room": "50:9a:4c:3c:2d:b5", "roomID": "RM_e6gBu37aP4iM", "participant": "kvs:50:9a:4c:3c:2d:b5", "pID": "PA_vE4HgC9pzeXV", "kind": "video", "trackID": "TR_VCGKbmpLww8AWY", "rid": "", "SSRC": 560412114}

"participant": "obstest:50:9a:4c:3c:2d:b5"  is obs rtmp covert to webrtc all is ok
2022-07-06T07:39:05.453+0800	INFO	livekit	service/rtcservice.go:211	new client WS connected	{"room": "50:9a:4c:3c:2d:b5", "participant": "obstest:50:9a:4c:3c:2d:b5", "connID": "obstest:50:9a:4c:3c:2d:b5", "roomID": "RM_e6gBu37aP4iM"}
2022-07-06T07:39:05.456+0800	INFO	livekit	rtc/room.go:276	new participant joined	{"room": "50:9a:4c:3c:2d:b5", "roomID": "RM_e6gBu37aP4iM", "pID": "PA_LiTqAuQrzHnr", "participant": "obstest:50:9a:4c:3c:2d:b5", "protocol": 7, "options": {"AutoSubscribe":true}}
2022-07-06T07:39:06.721+0800	INFO	livekit	buffer/buffer.go:187	REMB not supported, RTCP feedback will not be generated	{"room": "50:9a:4c:3c:2d:b5", "roomID": "RM_e6gBu37aP4iM", "participant": "obstest:50:9a:4c:3c:2d:b5", "pID": "PA_LiTqAuQrzHnr", "trackID": "TR_VCTnxmAftWjUpM", "mime": "video/h264", "layer": 2}
2022-07-06T07:39:06.722+0800	INFO	livekit	rtc/participant.go:1151	mediaTrack published	{"room": "50:9a:4c:3c:2d:b5", "roomID": "RM_e6gBu37aP4iM", "participant": "obstest:50:9a:4c:3c:2d:b5", "pID": "PA_LiTqAuQrzHnr", "kind": "audio", "trackID": "TR_AMgy7FXF2ctPap", "rid": "", "SSRC":<PHONE_NUMBER>}
2022-07-06T07:39:06.722+0800	INFO	livekit	rtc/participant.go:1151	mediaTrack published	{"room": "50:9a:4c:3c:2d:b5", "roomID": "RM_e6gBu37aP4iM", "participant": "obstest:50:9a:4c:3c:2d:b5", "pID": "PA_LiTqAuQrzHnr", "kind": "video", "trackID": "TR_VCTnxmAftWjUpM", "rid": "", "SSRC": 882893420}

this is my published code:
	if t.VideoRTPTrack == nil {
		if strings.Contains(trackRemote.Codec().MimeType, "video") {
			videoRTPTrack, err := webrtc.NewTrackLocalStaticRTP(trackRemote.Codec().RTPCodecCapability, streamname+"-video", streamname)
			if err != nil {
				panic(err)
			}

			// r.RoomClient.MutePublishedTrack(r.Ctx,)
			// var local_video *lksdk.LocalTrackPublication
			if t.Videopub, err = t.RoomConnect.LocalParticipant.PublishTrack(videoRTPTrack, &lksdk.TrackPublicationOptions{Name: streamname + "-video"}); err != nil {
				log.Debug("Error publishing video RTP track->", err)
				return err
			}
			t.VideoRTPTrack = videoRTPTrack
			r.Localtracks[streamname] = t
			// r.Localtracks[streamname] = &LocalTrackPublication{p: local_video, Track: videoTrack, Trackname: streamname + "-video"}
			log.Debug("published video track -> ", streamname)
		}
	}
	if t.AudioRTPTrack == nil {
		if strings.Contains(trackRemote.Codec().MimeType, "audio") {
			audioRTPTrack, err := webrtc.NewTrackLocalStaticRTP(trackRemote.Codec().RTPCodecCapability, streamname+"-audio", streamname)
			//audioTrack, err := lksdk.NewLocalSampleTrack(webrtc.RTPCodecCapability{MimeType: webrtc.MimeTypeOpus})
			if err != nil {
				panic(err)
			}
			// var local_audio *lksdk.LocalTrackPublication

			if t.Audiopub, err = t.RoomConnect.LocalParticipant.PublishTrack(audioRTPTrack, &lksdk.TrackPublicationOptions{Name: streamname + "-audio"}); err != nil {
				log.Debug("Error publishing audio track", err)
				return err
			}
			t.AudioRTPTrack = audioRTPTrack
			r.Localtracks[streamname] = t
			log.Debug("published audio track -> ", streamname)
		}
	}

this is write rtp data:
func (r *Room) TrackSendRtpPackets(trackname, kind string, data []byte) (n int, err error) {
	if trackname == "" {
		log.Debug("Track name is null")
		return 0, fmt.Errorf("input trackname is null")
	}
	// var t *webrtc.TrackLocalStaticSample
	var t *webrtc.TrackLocalStaticRTP
	track := r.Localtracks[trackname]
	if track == nil {
		log.Debug("Track is nil ->", trackname, "<- no to publish")
		return 0, fmt.Errorf(" track is null,no to publish")
	}
	if kind == "video" {
		t = track.VideoRTPTrack
	} else if kind == "audio" {
		t = track.AudioRTPTrack
	}
	if t == nil {
		log.Debug("Track is nil ->", trackname, "<- no to publish")
		return 0, fmt.Errorf(" track is null,no to publish")
	}

	n, err = t.Write(data)
	return n, err

}

which platform are you testing with for Flutter? It's probably due to the profile used for H.264. WebRTC spec only supports constrained baseline; While some browsers may render other profiles fine, mobile devices can be very limiting when it comes to decoding support.
Ensure your H.264 video is encoded like this

thx,flutter for web edge ,i use h264 profile is 77 (main) not 66 baseline, let me try baseline

always only audio play ,not video play,i set config my device h264 encode profile to baseline

what do the client logs say? can you check chrome://webrtc-internals to see if the track exists?

yes the track exists ,but not frame received ,the audio track is ok

Unfortunately, we aren't able to reproduce this. Are you able to give us a small example that could reproduce this? Ideally with our flutter example app.


fix small bug of run_batch.py for using drr fold

This PR fixed a small bug of wrong input arguments of verify_effectiveness and a bug of checking collection name when drr fold is used.

Will be dealt with by another PR


Move helper package to backends

EES-4269
Package core/help is too generic. This PR splits those packages into other more specific.

👍


Investigate if MDC Web Menu

Investigate if MDC Web Menu component uses patterns that will work for the React Component.

MDC Menu is wrappable by MDC React


Define enum description

Define Enum description by DescriptionAttribute or summary.

I don't really understand the problem this solves. Additionally, this PR is now out-of-date (my bad not yours) and there's conflicts so I'm going to close for now.
If your problem is still valid, please start with an issue that clearly articulates it with uses cases and code examples - then we can start from there and figure out a suitable path to resolution. Thx

I don't really understand the problem this solves. Additionally, this PR is now out-of-date (my bad not yours) and there's conflicts so I'm going to close for now.
If your problem is still valid, please start with an issue that clearly articulates it with uses cases and code examples - then we can start from there and figure out a suitable path to resolution. Thx


[BUG] "AccountName" renamed to "Account Name"

Summary

On the Violations page, the filter "AccountName" should be named to "Account Name" (needs a space added)
Screenshot

Is this what you are referring to?
https://github.com/PaladinCloud/CE/blob/a55289458e1ba6c0ab283196bff48e6808509f61/commons/pac-api-commons/src/main/java/com/tmobile/pacman/api/commons/Constants.java#L114-L118
Is there any documentation that states when it should and should not have a space between terms?

Yes, I believe that's the spot, and you make a great point. I lean towards it should always be with a space if it's for display purposes, but that should likely also apply to many of those other values too. Let me check with the team and get back to you.

Anywhere that account name is displayed to users, then it should have a space. So, if this bleeds into other pages or filters, that should be good. Of course, cleaning up the codebase needs to happen at some point, but to keep this issue from scope creep, let's scope this issue to improve the Violations Page UI.

Hey can I  Solve this issue?

Fixed in 3.0


Loc Automation - Updating ETA of loc job: 204

Loc Automation Updating ETA of loc job: 204

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

Line 111: [Error] W:\be42-s\jobs\100\Pages\Pricing\docfx.json for docset Pricing doesn't exist

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[BugFix] fix cast expr cause npe in streamload (#19237)

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #19237
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)


664 metadata panel leftovers

fixes #664

This PR deals exclusively with the styling of the trash icon both in the context menu and in list items and the animation added to a list item when first added.

Hi! The trash icon works ok, but there is something missing in the implementation: it is not possible to add multiple licenses, like it should. This is a video explaining how it should work:
https://github.com/user-attachments/assets/0ee4a78d-58e4-43b2-8210-1f100165b011
Here is what I see in the improved version:
https://github.com/user-attachments/assets/a8688367-57f8-44b2-af94-70896562df7f

Hi @romicolman the specific ticket for licenses explicitly said only one license can be added at a time. I think I asked also this in the chat.

Sorry for this. Yes, you are right. Please, merge this and I'll create a new ticket to implement multiple licenses. I have double check it and we need to keep it as it was in the original version.


Update references to 1.0 to aardvark schema scripts

https://github.com/mjanowiecki/geoportal/tree/main/aardvark

There is also a GeoCombine branch in the works: https://github.com/OpenGeoMetadata/GeoCombine/tree/121-migrate-to-aardvark

Right now scripts are being referenced in two places on the website:

At the bottom of the upgrade guide
The dedicated scripts and tools page

I'd recommend moving all scripts and tools to that dedicated page, and replacing the content on the upgrade guide with a link to that page.


Adding zoom callout for .form-control-sm

After I noticed my page zooming, I searched for how to prevent it and found this:
http://stackoverflow.com/questions/2989263/disable-auto-zoom-in-input-text-tag-safari-on-iphone
If there was a callout, I probably would have avoided ever attempting to use .form-control-sm.
In the callout itself, I was unsure whether I should present a single recommended solution, or if I should present all possible solutions.  In this case, the other solutions are to prevent zoom onFocus with custom Javascript or to prevent zoom altogether with a viewport restriction.  Since both impact accessibility, I decided to only present the option of avoiding use.

or to prevent zoom altogether with a viewport restriction

latest iOS versions ignore any such restrictions altogether, so you can't stop zooming

Closing as a won't fix given this isn't limited to Bootstrap. Happy to revisit with a more generic callout that's not limited to a small Bootstrap input if folks feel strongly.


[BUG] timed out while waiting for a dynamic mapping update

Describe the bug
Opensearch is updatting a mapping and ends up timing out.
To Reproduce
Steps to reproduce the behavior:
It's pretty hard to reproduce, it's actually intermittent.

Use dynamic mappings.
Index large batch of documents in Opensearch (10,000 documents per documents)
One of these batches might return this.

(
    [index] => Array
        (
            [_index] => index_name
            [_type] => _doc
            [_id] => entity_id
            [status] => 500
            [error] => Array
                (
                    [type] => mapper_exception
                    [reason] => timed out while waiting for a dynamic mapping update
                )
        )
)

Expected behavior
It looks like one of the fields is different in some documents than others, which triggers Opensearch to update the dynamic mapping. But it shouldn't time out.
Getting the name of the field that triggers the update accross all other documents would be nice

Hi @MerwaneHAMADI, Thanks for reporting this. do you mind add more details about your use-case? field mapping settings? does adding the field name will help root cause the issue?
It sounds to be more of mapping explosion, which could be fixed by flat field type.


Fix doc related to 4228267

4228267 renamed the "roles" attribute of Security annotation to "view". This PR fixes the corresponding documentation accordingly.

@jean-gui thanks for the contribution!