Fix UT failures caused by SQLite concurrency support

SQLite is not designed for large scale concurrency. But it actually can support low level concurrency.

Progress:

We have tried Shared-memory and in-memory features. They are not helpful in our case.
We found that all UTs can be finished successfully on SSD, but failed on HDD. Because writing to SSD is much faster than HDD, which means that database/file lock interval will be much less. This difference make SQLite passes all UTs.

According to this progress, this issue cannot be solved immediately. I will switch to other issues and keep one eye on this issue.

LTNP


Crash on scenes changing

Godot version:
3.1.2
OS/device including version:
MacOS Mojave, Macbook Pro 2018
Issue description:
The debugger seems to lose track of autoload nodes after switching scenes. If you click on such a node, it will crash the game and give you a drivers/unix/net_socket_posix.cpp:199 - Socket error: 54 error. If it's something in my code, I apologize but I can't seem to find out what the issue is.
Steps to reproduce:
Run project, change the scene a few times, and then try and click on the autoloaded node.
Minimal reproduction project:
https://github.com/ja-brouil/TBS_GoDot

You can close this. Something was fixed in the update on Godot.


integration tests should share an app

Each integration test file is an island currently. In particular, we waste a lot of time creating, git pushing, and destroying apps, even when that functionality isn't specifically under test.
Perhaps with some ref-counting setUp/tearDown approach, we could have the tests all share a single Deis app that is only updated or destroyed when the test calls for that. This should speed up the integration tests significantly.

:+1:

This improvement isn't likely to happen for Deis v1 (although pull requests are of course welcome). Instead, see the current state-of-the-art testing for Deis v2 at https://github.com/deis/workflow-e2e/issues.


Not recognizing vext types

In some cases it doesn’t know NetEvents, WebUI etc.

And it doesn't know about json.encode. Not sure if it’s the same issue


Fixed #24799 -- Fixed deleting of empty session cookie when using SESSION_COOKIE_DOMAIN

Also, this is my first Django PR! Let me know if I can do anything better. :)

Buildbot, test this please.

buildbot, add to whitelist.

buildbot, test this please.

As this is a candidate for backporting to stable/1.8.x, you could add release notes for 1.8.2.

Done!

merged in 2dee853ed4def42b7ef1b3b472b395055543cc00, thanks!


NTR: [Mitochondrial protein quality control]

Hi GO,
I would need a term for Mitochondrial protein quality control process. There is a good review (PMID:38280230) that describes the proteins involved in this process. Note that we already have terms for other subcellular localizations (cytoplasm and nucleus)
Thanks
Sylvain
Mitochondrial protein quality control
Definition: The chemical reactions and pathways resulting in the breakdown of misfolded proteins in the mitochondrion, which are targeted for degradation.
Child of : GO:0006515 protein quality control for misfolded or incompletely synthesized proteins
XRef: PMID:38280230

+[Term]
+id: GO:0141164
+name: mitochondrial protein quality control
+namespace: biological_process
+def: "The chemical reactions and pathways resulting in the breakdown of misfolded proteins in the mitochondrion, which are targeted for degradation." [PMID:38280230]
+is_a: GO:0006515 ! protein quality control for misfolded or incompletely synthesized proteins
+property_value: term_tracker_item "https://github.com/geneontology/go-ontology/issues/27044" xsd:anyURI
+created_by: pg
+creation_date: 2024-02-14T07:11:38Z
+


WIP: Fix macOS readline support

Fixes https://github.com/conda-forge/sqlite-feedstock/issues/22
Makes sure that sqlite links against our copy of readline and not the system copy of editline.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This does correctly pick up readline. However it seems to be picking up the system copy of ncurses, which is not a problem before.

@conda-forge-admin, please rerender.

Ack! Got the wrong ncurses again. Trying to fix in PR ( https://github.com/conda-forge/sqlite-feedstock/pull/24 ).


Seems only natural...

PS. This is humour.

:stuck_out_tongue_closed_eyes:
"unless" is one of the biggest source of flamewars on rubyland. I was trying to avoid it.


pr initiator merge after reviewed.

Gitea version (or commit ref): 1.14.1 built with GNU Make 4.2.1, go1.16.3 : bindata, sqlite, sqlite_unlock_notify

can pr initiator merge after reviewed?
our app ci will run after merge. I hope the initiator controls the timing of the merger.

Your question is hard to follow, you can try asking with more details on our discord :)


dmd D compiler update

Motivation for this change
#124758 rebooted, and this time also including DMD 2.097.0
Unlike in #124758, overriding packages and switches of ./sourcebuild.nix should now really work, at least the Foundation parameter that's specified in top-level.nix gets passed.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

cc @lionello @ThomasMader


[Add] nl command integration tests

You don't have to write anything.
This issue is made as a TODO list.

Added tests


Reveal animation in doesn't work in 6.6.1

What should happen?
Reveal opening should be animation with animation that set in a data attribute.
What happens instead?
Only reveal closing is animated.
Possible Solution

...
Test Case and/or Steps to Reproduce (for bugs)

https://jsfiddle.net/fxrwdvbe/ - 6.6.0 works
https://jsfiddle.net/L9tvkg07/ - 6.6.1 doesn't work
Your Environment

Foundation version(s) used: 6.6.1
Browser(s) name and version(s): Chrome 78.0.3904.108
Device, Operating System and version: Win 10

Checklist

[x] I have read and follow the CONTRIBUTING.md document.
[x] There are no other issues similar to this one.
[x] The issue title and template are correctly filled.

Hi @Lazerproof,
Thanks for reporting this.
Can you provide codepen links instead of jsfiddle? That would be very helpful.

In general your 6.6.0 version is in fact 6.5.3, see https://github.com/cdnjs/cdnjs/issues/13636
That's why we do not recommend cdnjs (you can try unpkg).

Facing same problem after upgrading to 6.6.1!

Hi @vimalnair007,
can you provide a codepen which we can use as testcase? That would be awesome.

I found the culprit using git bisect.
It seems the code was needed here but lacked a proper comment.
c9b7c7a3f4b517ef6e688886e503e2327d2f17ad
See also https://gist.github.com/paulirish/5d52fb081b3570c81e3a

@DanielRuf I tested your fix by manually adding changes to foundation.min.js and animation working as expected on reveal.
Can you please add this changes to dist files as well?
Thank you for the fix and expecting PR to be merged soon.

Can you please add this changes to dist files as well?

dist files are generally not updated in a PR. If needed I can provide patched dist versions.
We update dist files on prepublish / prepare.

Depending on your project you can use git apply, patch or `patch-package] to apply the patches.

Depending on your project you can use git apply, patch or patch-package to apply the patches.

Thanks for the information. Its okay, i have applied it manually for now in my project - hope it will not cause any problem. I wanted dist files in repo with final changes and prevent adding manual fix to keep remote and local files in sync.
I hope your changes will be part of next patch release dist after it is merged.

I hope your changes will be part of next patch release dist after it is merged.

Yes, this is planned for the next patch release.
cc @joeworkman

Thank you for the fix! Any rough idea when the next patch version is expected?

This issue has been mentioned on Foundation Open Source Community. There might be relevant details there:
https://foundation.discourse.group/t/reveal-animation-in-bug/1780/2


Add 'single_visit' option to local repository and rename to DirectoryRepository

Add an option 'single_visit' to the LocalRepository (to be renamed DirectoryRepository) to avoid having to restructure the project directories to include the visit sub-directories.

implemented in develop branch


Physical Light Units break Default Omni/Spot Lights

Godot version
4.0 Beta 2
System information
Windows 11, Vulkan, GTX 1050 Ti 516.94
Issue description
Left = Default,  Right = Expected
Physical Light Units

Non Physical Light Units

Steps to reproduce
Toggle Physical Light Units on and off in Projects settings
Minimal reproduction project
Lights.zip

For other users stumbling on this issue in the meantime, there are two primary quirks that users need to be aware of when using Physical Light Units:

default exposure is tuned to match the default lighting (one DirectionalLight3D and ProceduralSky background). The default brightness of the DirectionalLight3D is 100,000 lux (roughly the sun's brightness at midday) and the sky is 30,000 nits (roughly the earth's sky brightness at midday). Omnilights and Spotlights are significantly dimmer than DirecrtionalLights by an order of about 500x. This means to use OmniLights and spotlights, exposure needs to be adjusted to match their range.
The default background brightness is 30,000 nits. So when used in a scene light this, the background dominates the scene luminance and will have the biggest impact on auto exposure. Meaning that auto-exposure won't be able to properly expose your scene for the dim omni/spot lights when the background is so bright.

In the MRP reducing the background to 50-100 nits and increasing the exposure multiplier to 200-500 brings the scene luminance into expected levels

Fixed by https://github.com/godotengine/godot-docs/pull/6390


Bad link

The Greg Ward website link to anywhere.com, is bad.

Greg Ward opened a new website at:
www.anyhere.com


[Feature Request]: Add Cursor Tail Effector for Enhanced User Experience ✨

Is there an existing feature request for this?

[X] I have searched the existing feature requests

Describe the feature you would like to request
I want to add a Cursor Tail Effector...
I propose adding a cursor tail effector to improve the overall user experience. This subtle but visually appealing effect will make interactions feel more dynamic and engaging for users, enhancing the visual feedback as they navigate through the site... 🔵✨
PA please assign me this task.

What problem does this feature solve?
.
Alternative solutions
No response
Confirmation

[X] I have read the Bitbox Contributing Guidelines
[X] I am a GSSOC-EXT contributor
[X] I am a HACKTOBERFEST contributor
[X] I have starred the Bitbox repository
[X] I would like to help implement this feature

@Anuj3553

Hyy @Subhajit-2023-44 please add some more screenshots or visuals to your issues from your privious work how the design you create

Hyy @Subhajit-2023-44 please add some more screenshots or visuals to your issues from your privious work how the design you create

wait

Hyy @Subhajit-2023-44 please add some more screenshots or visuals to your issues from your privious work how the design you create

@Harshit7492 I want to add this Cursor Tail Effector... It improve the overall user experience. This subtle but visually appealing effect will make interactions feel more dynamic and engaging for users, enhancing the visual feedback as they navigate through the site... 🔵✨
Please assign me this task with level 3
https://github.com/user-attachments/assets/ef69ce5b-7fb9-4015-a53c-447c02697ad0

Sorry @Subhajit-2023-44  we dont want this functionality but thank you for your support


don't use sse

Current dependencies on/for this PR:

main

PR #480   👈

This stack of pull requests is managed by Graphite.


Release language 1.0.2

This pull request was generated using releasetool.

Release is at https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/language-1.0.2


⚠ BeyondHD has degraded performance

In c641d6e, BeyondHD ($BHD) experienced degraded performance:

HTTP code: 200
Response time: 17360 ms

Resolved: BeyondHD performance has improved in 67afd2e.


Tests are flaky

Tests randomly fail on Elixir 1.5.3 using latest master:
  1) test it generates a transaction name based on request method and path (NewRelixir.Instrumenters.PlugTest)
     test/new_relixir/instrumenters/plug_test.exs:35
     Assertion with == failed
     code:  assert [{"hello#GET", :total}] == get_metric_keys()
     left:  [{"hello#GET", :total}]
     right: [{"TestTransaction", {:db, "FakeModel.update"}}, {"hello#GET", :total}]
     stacktrace:
       test/new_relixir/instrumenters/plug_test.exs:39: (test)

  1) test does not record a transaction when New Relic is not configured (NewRelixir.Instrumenters.PhoenixTest)
     test/new_relixir/instrumenters/phoenix_test.exs:41
     Assertion with == failed
     code:  assert [] == get_metric_keys()
     left:  []
     right: [{"TestTransaction", {:db, "SQL"}}]
     stacktrace:
       test/new_relixir/instrumenters/phoenix_test.exs:45: (test)

  1) test does not record a transaction when New Relic is not configured (NewRelixir.Instrumenters.PlugTest)
     test/new_relixir/instrumenters/plug_test.exs:53
     Assertion with == failed
     code:  assert [] == get_metric_keys()
     left:  []
     right: [{"TestTransaction", {:db, "FakeModel.delete"}}]
     stacktrace:
       test/new_relixir/instrumenters/plug_test.exs:57: (test)

thanks, fixed


Refresh required when accessing accounts after switching budgets

Name of Defective Feature
-Account list on left banner after budget switch
System Settings (Required)

ToolKit Version: 2.9.5
Operating System (Mac/Windows/Etc): Mac OS High Sierra 10.13.6
Browser (Chrome/Firefox/Safari): Chrome 72.0.3626.96
Browser Version: 72.0.3626.96
Other Extensions:
Dyslexia Unscrambled
Evernote Web Clipper
Google Docs Offline
Pinterest Save Button

Export of Toolkit Settings (Bottom Left of Settings Page)

Settings Export
[{"key":"AccountsDisplayDensity","value":"2"},{"key":"AccountsEmphasizedOutflows","value":false},{"key":"AccountsStripedRows","value":true},{"key":"AutoDistributeSplits","value":false},{"key":"AutomaticallyMarkAsCleared","value":false},{"key":"BetterScrollbars","value":"0"},{"key":"BudgetCategoryFeatures","value":true},{"key":"BudgetProgressBars","value":"goals"},{"key":"BudgetQuickSwitch","value":true},{"key":"CalendarFirstDay","value":"0"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"0"},{"key":"ChangeEnterBehavior","value":true},{"key":"CheckCreditBalances","value":false},{"key":"CheckNumbers","value":false},{"key":"ClearSelection","value":false},{"key":"CollapseSideMenu","value":true},{"key":"ColourBlindMode","value":false},{"key":"CompactIncomeVsExpense","value":true},{"key":"CreditCardEmoji","value":false},{"key":"CurrentMonthIndicator","value":false},{"key":"CustomFlagNames","value":false},{"key":"DaysOfBuffering","value":true},{"key":"DaysOfBufferingHistoryLookup","value":"0"},{"key":"DisableToolkit","value":false},{"key":"DisplayTargetGoalAmount","value":"3"},{"key":"DisplayTotalMonthlyGoals","value":true},{"key":"DisplayUpcomingAmount","value":true},{"key":"EasyTransactionApproval","value":false},{"key":"EditAccountButton","value":"2"},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"EnterToMove","value":false},{"key":"GoalIndicator","value":true},{"key":"GoalWarningColor","value":false},{"key":"GoogleFontsSelector","value":"0"},{"key":"HideAccountBalancesType","value":"0"},{"key":"HideAgeOfMoney","value":false},{"key":"HideHelp","value":false},{"key":"HideReferralBanner","value":false},{"key":"HighlightNegatives","value":false},{"key":"ImportNotification","value":"0"},{"key":"IncomeFromLastMonth","value":"0"},{"key":"IncomeVsExpenseHoverHighlight","value":true},{"key":"LargerClickableIcons","value":false},{"key":"MonthlyNotesPopupWidth","value":"0"},{"key":"NavDisplayDensity","value":"0"},{"key":"Pacing","value":"0"},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":"0"},{"key":"QuickBudgetWarning","value":true},{"key":"ReconciledTextColor","value":"0"},{"key":"RemovePositiveHighlight","value":false},{"key":"RemoveZeroCategories","value":false},{"key":"ResizeInspector","value":false},{"key":"ResizeSidebar","value":true},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"0"},{"key":"RowsHeight","value":"0"},{"key":"RunningBalance","value":"1"},{"key":"SeamlessBudgetHeader","value":false},{"key":"SetMultipleFlags","value":false},{"key":"ShowCategoryBalance","value":false},{"key":"SpareChange","value":false},{"key":"SplitKeyboardShortcut","value":true},{"key":"SplitTransactionAutoAdjust","value":false},{"key":"SquareNegativeMode","value":false},{"key":"StealingFromFuture","value":true},{"key":"SwapClearedFlagged","value":false},{"key":"TargetBalanceWarning","value":true},{"key":"ToBeBudgetedWarning","value":false},{"key":"ToggleMasterCategories","value":false},{"key":"ToggleSplits","value":false},{"key":"ToggleTransactionFilters","value":"0"},{"key":"ToolkitReports","value":true},{"key":"TransactionGridFeatures","value":true},{"key":"ViewZeroAsEmpty","value":false},{"key":"l10n","value":"0"}]

Steps to Reproduce the Behavior

Left hand banner, click on drop down menu beside budget name.
Click on Open Budget (because the other budgets don't list there anymore)
Select your budget from the list.
Select and click on an account from your account list.

Expected Behavior
With this I would expect the transaction list from the account selected to populate the main area.
Actual Behavior

Once Refresh is done then budget works as expected.

Thank you for looking into this.  A small inconvenience but it can't be fixed if we don't ask right?

I think I have a fix for this -- we'll likely get it in our next release (targeting tomorrow).

Hey @jennpetersen the fix for this should be in our current release! If you notice the issue still exists and you're definitely running the newest version of the toolkit, please reopen! Thanks!
Please note, all browser can take up to an hour to provide updates to all users. You can force an update if it's available for you by going to chrome://extensions and clicking the "Update" button. Firefox users can go to about:addons, click the setting cog, and click "Check for updates...".


Installing free starter template fails if yarn is not installed

Current Behavior
Running npm create tamagui@latest without having yarn installed results in an error when selecting the 'Free' template:
npm create tamagui@latest

▀█▀ ▄▀█ █▀▄▀█ ▄▀█ █▀▀ █ █ █
 █  █▀█ █ ▀ █ █▀█ █▄█ █▄█ █

Creating tamagui app...
✔ Project name: … group-garden-tamagui
✔ Pick a template: › Free - Production ready base universal app monorepo

Creating a new tamagui app /Users/tomspencer/Code/projects/group-garden-tamagui...
group-garden-tamagui folder created.
✔ Do you want to use git? … yes

Setting up /Users/tomspencer/.tamagui/tamagui/starter-free.git...
$ cd /Users/tomspencer/.tamagui
Cloning tamagui base directory

$ git clone --branch main https://github.com/tamagui/starter-free.git "/Users/tomspencer/.tamagui/tamagui/starter-free.git"

Cloning into '/Users/tomspencer/.tamagui/tamagui/starter-free.git'...

Updating tamagui starters repo

From https://github.com/tamagui/starter-free
 * branch            main       -> FETCH_HEAD

$ git pull --rebase --allow-unrelated-histories --depth 1 origin main

Copying starter from /Users/tomspencer/.tamagui/tamagui/starter-free.git into group-garden-tamagui...

group-garden-tamagui created!

$ cd /Users/tomspencer/Code/projects/group-garden-tamagui

$ git init
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint:
hint: 	git config --global init.defaultBranch <name>
hint:
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint:
hint: 	git branch -m <name>
Initialized empty Git repository in /Users/tomspencer/Code/projects/group-garden-tamagui/.git/
Installing packages. This might take a couple of minutes.

installing with npm
> npm install
npm WARN deprecated<EMAIL_ADDRESS>This functionality has been moved to @npmcli/fs
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-numeric-separator instead.
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-catch-binding instead.
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-export-namespace-from instead.
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-nullish-coalescing-operator instead.
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-async-generator-functions instead.
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-chaining instead.
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-object-rest-spread instead.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>This functionality has been moved to @npmcli/fs
npm WARN deprecated<EMAIL_ADDRESS>support for ECMAScript is superseded by `uglify-js` as of v3.13.0
npm WARN deprecated<EMAIL_ADDRESS>Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated<EMAIL_ADDRESS>"Please update to latest v2.3 or v2.2"
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.

> postinstall
> yarn check-deps && yarn build

sh: yarn: command not found
npm ERR! code 127
npm ERR! path /Users/tomspencer/Code/projects/group-garden-tamagui
npm ERR! command failed
npm ERR! command sh -c yarn check-deps && yarn build

npm ERR! A complete log of this run can be found in: /Users/tomspencer/.npm/_logs/2024-01-02T16_30_30_179Z-debug-0.log

[tamagui] error installing with npm
 npm install exited with non-zero code: 127
node:child_process:965
    throw err;
    ^

Error: Command failed: node /Users/tomspencer/.npm/_npx/d01fabec74a282ea/node_modules/create-tamagui/dist/index.js
    at checkExecSyncError (node:child_process:890:11)
    at Object.execSync (node:child_process:962:15)
    at Object.<anonymous> (/Users/tomspencer/.npm/_npx/d01fabec74a282ea/node_modules/create-tamagui/run.js:6:26)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:86:12)
    at node:internal/main/run_main_module:23:47 {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 10774,
  stdout: null,
  stderr: null
}

Node.js v18.18.0
npm ERR! code 1
npm ERR! path /Users/tomspencer/Code/projects
npm ERR! command failed
npm ERR! command sh -c create-tamagui

npm ERR! A complete log of this run can be found in: /Users/tomspencer/.npm/_logs/2024-01-02T16_30_16_194Z-debug-0.log

Expected Behavior
Installation should proceed without an error.
Tamagui Version
1.8.4

Platform (Web, iOS, Android)
All

Reproduction
- Use a system which doesn't have `yarn` installed
- Run `npm create tamagui@latest` and choose the 'Free' template

System Info
System:
    OS: macOS 13.5.2
    CPU: (10) arm64 Apple M2 Pro
    Memory: 2.46 GB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.0 - ~/.nvm/versions/node/v18.18.0/bin/node
    npm: 9.8.1 - ~/.nvm/versions/node/v18.18.0/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Browsers:
    Chrome: 120.0.6099.129
    Safari: 16.6

If yarn is required, I guess it needs to be added to the Installation guidelines.

Ah yea we do require yarn tbh because the entire repo uses many commands for it. Yarn has good compat with RN, better than any other.

Added some docs, and made it default to yarn c1402ab4d1e408fa0f3652b7975769e048951e98


add new attribute to change whether or not show the axis arrow

Hi Kevin. This is Aaron from Xi'an,China. First great chart Library for IOS. I am using it in my project now Thanks. and I am now using the scatter chart. and I think it will be better if an options is given to change whether the axis arrow in show or not. In my option, without the arrow, the chart looks better.

oops~ build failed. see the log. and it seem some issue with ruby version?

oops~ build failed. it seems a issue about the ruby version

I'll close this pr then please try a new one.


rewrite tplx templates

Currently we have two tplx templates, that contain almost the same content. Change this into a inheritance based concept.

Fixed in 347a856


Fix Panic in Go 1.6

This should fix #23 unfortunately it uses additional allocation using malloc, but I didn't come up with a different solution to avoid passing pointer to go pointer into iconv (cgo). I tried to stick to the naming convention used in the code, although it became a bit too long around shift tracking.
Existent tests and examples seem to be working now both with go <1.6 and 1.6

sorry, for late answer - been busy.
@dimandzhi Thanks for pointing that out :+1:  Storing a pointer in C was a great hint, although cgo is not guaranteed to run in single thread even with GOMAXPROC==1, so having a global pointer in C and returning it's address would lead to panics. Alternative would be to make some table in C to store the pointers and make it thread-safe, but that would be still messy.
Apparently the simplest thing to be done, was to write a wrapper around iconv, which allows to omit the unnecessary allocations and go back to previous way of handling pointer shifting, without the mess I introduced  ;)
size_t call_iconv(iconv_t ctx, char *in, size_t *size_in, char *out, size_t *sizeout){
   return iconv(ctx, &in, size_in, &out, sizeout);
}

As for your last question, passing a slice as a parameter into function does not involve any copying of the slice content.

A slice is a descriptor of an array segment. It consists of a pointer to the array, the length of the segment, and its capacity (the maximum length of the segment).

with you did with call_iconv wrapper looks like what I expected would end up being the solution i thnk, so now I have confirmation bias.
can you squash your commits and reference the issue number in the commit message?

Since, the approach (fortunately) changed, the byteSliceToC helper func could have been omitted as well as the white space
If that bothers you I can remove both with another squashing

the extra changes did bug me a little, I will not complain if you amend them out.
Thanks.

adjusted :)


Add packet timeout callback #50 (Rebase)

Hello,
I've been following #176 for a little while, and figured I'd take a stab at rebasing the work done by @hamptonmoore. I'm hoping I did it correctly; if not, feel free to request changes as needed and I'll do my best. I'd love to see this get merged in.
Thanks!

See https://github.com/go-ping/ping/pull/226


Cinel

@andreitudos Could you please:

Rename lib/domains/pt/cinel to lib/domains/pt/cinel.txt
Please provide us with an URL of a page on the official website where an IT-related long-term (>1 year) course is offered by the school

@andreitudos You might miss my previous comment. Please reply.

@andreitudos You might miss my previous comment. Please reply.

Done
http://www.cinel.pt/appv2/Oferta-Formativa/Plano-de-Formacao

@andreitudos You have closed this request. Does it mean that you do not wish to add CINEL to this repository now?

hi Philip,
I made a mistake,  instead of putting pt/cinel/formandos.txt, I placed pt/formandos/cinel/formandos.txt.
Then I decided to close this request and open another request #4056.

@andreitudos Thank you for the clarification. I am closing this request as not needed because #4056 was just merged.


Add all to useForm mode Documentation

Added option all to useForm Documentation.
Note: I used google translate for all translations (excluding english).
Doing my part to help get V6 out into the world! 😸

Thank you @pmaier983!


Remove Simulacrum partially or fully

The Simulacrum library has barely been used.
And it adds complexity that might not be worth it.
Remove it from where it is unused and possibly fully remove it.

Removed all unused references. Including the one from all the image traits.
There are only 2 non essential traits using Simulacrum now.

Fully removed.


Facebook icon should be a square

Facebook logo isn't the f letter, is the square with the letter. I think it can be designed like the following:

This was the logo I had planned to make originally. However, this version of the Facebook logo doesn't work well within the constraints of Feather. The outside box must be 20x20 which makes the "f" too small. Feather's Facebook logo is still easily recognizable and works within the constraints of the set.

It's a pity :(. Thank you for you response!
I'll close the issue.


Make composite resource the default resource type

Lets make composite resource the default resource type, instead of generic, when content is being added to HydroShare.  This is part of the process of encouraging use of composite resource types more.

Do we have composite resource nailed?  If we are going to make this change, it better be ready for prime time.

@dtarb, @pkdash
Could you confirm if the Composite Resource type is ready to be used as default?

Confirmed.

Included as part of Create Resource page revamp (https://github.com/hydroshare/hydroshare/pull/1957)

Implemented


remove duplicate index region

remove duplicate index region

@andrijapanicsb can you explain

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-847

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-986)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 23074 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3882-t986-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 74 look OK, 5 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_vpc_privategw_static_routes
Failure
249.51
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
243.54
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Failure
293.82
test_privategw_acl.py

ContextSuite context=TestVPCRedundancy>:setup
Error
0.00
test_vpc_redundant.py

ContextSuite context=TestVPCNics>:setup
Error
0.00
test_vpc_router_nics.py

ContextSuite context=TestRVPCSite2SiteVpn>:setup
Error
0.00
test_vpc_vpn.py

ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup
Error
0.00
test_vpc_vpn.py

ContextSuite context=TestVpcRemoteAccessVpn>:setup
Error
0.00
test_vpc_vpn.py

ContextSuite context=TestVpcSite2SiteVpn>:setup
Error
0.00
test_vpc_vpn.py

test_01_cancel_host_maintenace_with_no_migration_jobs
Error
0.06
test_host_maintenance.py

test_02_cancel_host_maintenace_with_migration_jobs
Error
0.06
test_host_maintenance.py

test_03_cancel_host_maintenace_with_migration_jobs_failure
Error
0.06
test_host_maintenance.py

test_01_cancel_host_maintenance_ssh_enabled_agent_connected
Error
0.02
test_host_maintenance.py

test_03_cancel_host_maintenance_ssh_disabled_agent_connected
Error
0.02
test_host_maintenance.py

test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected
Error
0.02
test_host_maintenance.py

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-869

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Checked backend, we've some issues. Based on previous test run and Travis LGTM. Essentially this is a simple DB related fix, validated through Travis.


Use cypress run events to automatically signal the test run to VRT

In my opinion it would make sense if the plugin automatically starts and stops when the cypress run starts and stops.
My suggestion would be to use the cypress events to do it. Makes the usage much simpler and also prevents the VRT plugin turn on / off the progress indicator for every spec.
Whats your opinion on this?

Yeah I can do it.

Still have to test it though

@tobmaster Hi there! Would you have time to update this PR?
I could then try to mimic the behaviour in agent-playwright to have them matching.


Various fixes and cleanups

Fixes #53
Changes proposed in this pull request:

stop tracking some files that shouldn't be tracked
change how non-preflight CORS requests are handled (#53)

@mathewrapid regarding BC stuff it's fine, gonna bump the major version anyway


Fix loading font data on Windows.

Fix for not properly loading font data on Windows as described in #410.

In fact, probably all reads should be binary, what with UTF8 and everything. But this is a good start, thanks!

I briefly did a quick check on io.open, but it seems like other calls deal with text reads, which should be fine even with UTF8. This was the only one that was working with binary data after my cursory look.


refactor(modal): use ngAnimate for animation

Supercedes #1772
This makes use of the new $animate:close event to determine that the animation is done instead of using $transition. There are minimal changes to the current code and there's one fix and the removal of some timers.

I'd like to see it merged as well. :)

@chrisirhc - it can no longer merge automatically.

Should fix #3182 as well. I plan to rebase this once #2699 is merged.

Rebased. Now if anyone can take a look, I'll merge this.

Other than that one minor comment (may be a non-issue), this PR LGTM.


File viewing

Should the eye icon on the file listing open the raw file in a new tab, should open in tab be an option on the modal that pops up when you click it now?

Github does some wrapping around plaintext files, for example if you try to save the raw .ini the file save dialog will end with .ini.txt.  PDF's in repos just have a download button.
The two alternatives is that we have a new endpoint along the lines of item/raw which serves the file contents wrapped in the pre tag like Github. Or we add a full screen button to the FilePreview modal.

@TristanWright Girder recently added this functionality, might be worth looking at what they are doing.

#505 addresses this

closed with #505


License is missing

The package.json file says the project is under BSD License, but there isn't a license file in the repository. Please add the license.

We appreciate you for the recognition you gave us.
The license 'BSD' was written wrong.
The correct license is 'Apache 2.0' and we fixed 'package.json' correctly.
Also we added LICENSE file into this project.
Thank you again.


UX Sizing

It would be great if more screen real estate could be afforded to listing the tasks. Current issues are:

font size is not adjustable within styles.css and the default is larger than the sidebar font size. It takes up too much space on the left sidebar. It would be great if this could be adjustable.
the progress line that tracks down on the left has too much padding on the left side leaving the tasks to push too far over on the right. If the progress line was further left, you could conserve more space for listing the tasks.

Hello, @Owlf-Dev,
Please update the plugin and re-check.


Merge similar production entries into bundles

Primary production page would be standard and display the earliest known release but it would include a Variants panel containing all known/hosted similar files.
The variant panel will contain an itemised list that includes a title, the different production release date, a download link and highlight any other differences (music track etc.)

Moved issue.


Fix Travix CI config

See failing of Travis CI checks in https://github.com/eidottermihi/rpicheck/pull/194 and https://github.com/eidottermihi/rpicheck/pull/189 and please fix these.

done with 500d2198908e2dc06f1a2458095e3cdae7ac6c72


fix: uinput set analog trigger when zero

Fix the analog trigger value never being set back to zero after being pressed.

Thanks for the PR!
I'm also working on that, and I'm adding some better unit testing of this implementation using SDL in order to check how well the virtual devices are working. I'll better review your changes in the next few days once I've got everything properly setup.


Release patch

Relates to #87 (previous release)
Relates to #73 (addressing suspected "Release / Branch" error)

Summary
Release v0.2.5

The automated release following this Pull Request partially failed. The "Release / Branch" job failed to update the v0 branch as the push was rejected. This is likely due to the git history not being fetched in its entirety, which should be fixable by changing:
        - name: Checkout repository
          uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3.1.0
+         with:
+           fetch-depth: 0


fetch the daemon pid in ExecInDaemon()

Signed-off-by: Lai Jiangshan<EMAIL_ADDRESS>

LGTM


chore: bdd-spring-1581036698 to 0.0.1

chore: Promote bdd-spring-1581036698 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Opening a File for reading with atomic=True truncates file

Python 2.7.1 (OS X 10.7), Click 4.0
import click

@click.command()
@click.argument("file", type=click.File(mode="r+", atomic=True))
def clobber(file):
    # This should be a read-only operation, but the file is empty on exit.
    # File is already empty by the time read() is called on it.
    click.echo(file.read())
    return

if __name__ == "__main__":
    clobber()

My use case is opening a file that needs to be read from and then optionally written to. However, opening the file with mode r or r+ truncates the file for atomic=True. What is the best way to update a file?
In any case, having your file clobbered with mode r is certainly not expected.

Atomic file writes work by creating a temporary file that is moved over the original one, since rename is atomic. Your file appears to be empty because the temporary file really is, at the end of your CLI app the original file is replaced.
Because atomic file writes work the way they do, you can't "just modify a file in-place" without copying the whole file to a temporary location. But I think if click started doing that implictly for the +-modes, I think we'd hide the performance penalties that come with copying the whole file. Furthermore none of this would be really atomic anymore. I strongly suspect that you're using the atomic=True option in a case where it can't be even applied.
There is some usability bug in click. I'm not sure how to solve it. Perhaps we should disallow any other mode than w if atomic=True is used.

I've had to roll my own atomic file before, and I resolved this issue by not bothering to create/copy the temporary file if the mode was read-only. Of course, that doesn't solve the "r+" case.  Perhaps this could be tied to lazy=True so that the temporary file is only created on write, not read.

not bothering to create/copy the temporary file if the mode was read-only

I don't think that's a good behavior for Click, since this pretty much defeats the purpose of atomic=True.

Perhaps this could be tied to lazy=True so that the temporary file is only created on write, not read.

So read would actually use a different fp than write does?

So read would actually use a different fp than write does?

Hmm. In this case, I guess that it would. I agree the current behavior is probably the best way to handle this, but, to prevent surprised, the documentation should mention that atomic=True should not be mixed with reading.

the documentation should mention that atomic=True should not be mixed with reading.

Would you be okay with preventing that edgecase in the code itself (by raising a clear error message)? Is there a situation where the user actually wants to pass both r+ and atomic=True if they know what they are doing?

Would you be okay with preventing that edgecase in the code itself (by raising a clear error message)?

I think that's fine.

Is there a situation where the user actually wants to pass both r+ and atomic=True if they know what they are doing?

For me, r+ means the file doesn't get modified unless you write to it, which is not the case here. The way it works now, atomic=True really gives you w+ semantics.

I've added some error messages to master, but I think this might as well be fixed by https://github.com/mitsuhiko/click/issues/320


Discover master from etcd/consul?

I have a feeling that switchboard is designed only for master-master clusters where switchboard is responsible for master selection.
In our PG cluster system we are orchestrating the master selection and promotion; we just want to communicate the new master/leader to the TCP routing layer and have it sever client connections to force them to reconnect. Possible?

Hi @drnic,
Right now, Switchboard is a simple project with plenty of potential. You're right that it's designed to independently choose amongst a set of masters. It doesn't have any concept of who might be promoted from slave to master.
Part of this is because we wanted switchboard's failover to be fast. So it monitors the health of all masters, and when a master starts to fail, it very aggressively cuts connections and start routing new connections to a different master.
This is sort of a limitation today, in that we can't have a horizontally scalable tier of switchboards. In the case of MySQL multi-master, you want all read/write queries to go to the same master, else suffer the small possibility of deadlocks. Switchboard doesn't sync its decision of who the new master is, so it's possible that independent switchboards will choose different masters. Thus, we direct everyone who implements cf-mysql-release to add an additional Load Balancer in failover mode above switchboard.
This is something we plan to address. We haven't decided if we want to put more effort into switchboard right now - we are going to investigate MaxScale as a better solution for cf-mysql-release.

--
Marco Nicosia
Product Manager
Pivotal Software, Inc.

Hi @drnic,
I think I'm going to go ahead and close this issue for now. Of course, feel free to re-open any time.
--
Marco Nicosia
Product Manager
Pivotal Software, Inc.


Don't highlight or display large files

Viewing my 168 project submission, which has 1.4 MB JSON files, takes a long time to load and causes my browser to become very slow. We should still show the download link, but the file contents should be replaced by a message that the file is too large to show.

Fixed by #975

We seem to have regressed: For example http://okpy.org/cal/cs168/fa16/proj3_measurement/submissions/ep0WyN/ times out. Might be related to #1032, or maybe the display size limit is too high.

Some ideas:
File-specific limits (.ipynbs could be ~2MB)
We could have one more tier

Don't diff anything over 64KB (Existing)
Don't attempt to syntax highlight anything over 512KB
Don't display files over 2MB

Kinda leaning toward the second one personally


Output error details when a track download fails from a list file

What is the purpose of your issue?

[ ] Bug
[ ] Feature Request
[ ] Question
[x] Other

Description
At the moment, we just output WARNING: Failed to download song. Will retry after other songs when a track being downloaded from a list file fails without displaying any further details on error. A better way to do it would be to also display the error message.
For example, this output is not very helpful (Refer #236):
INFO: Preparing to download 3 songs

INFO: 1. Tito ''El Bambino'' Ft Zion Y Lennox - Mi Cama Huele a Ti [El Patrón] (http://www.youtube.com/watch?v=8YKGlV6VGuA)
WARNING: Failed to download song. Will retry after other songs

INFO: 2. el amor tito el bambino lyrics (http://www.youtube.com/watch?v=kbNuBvpfDuY)
WARNING: Failed to download song. Will retry after other songs

INFO: 3. LO APRENDÍ DE TI -  HA ASH- PRIMERA FILA- HECHO REALIDAD (http://www.youtube.com/watch?v=L4dxE5GYNnc)
WARNING: Failed to download song. Will retry after other songs

Instead, we could have something like this:
INFO: Preparing to download 3 songs

INFO: 1. Tito ''El Bambino'' Ft Zion Y Lennox - Mi Cama Huele a Ti [El Patrón] (http://www.youtube.com/watch?v=8YKGlV6VGuA)
ERROR: .....
............
WARNING: Failed to download song. Will retry after other songs

INFO: 2. el amor tito el bambino lyrics (http://www.youtube.com/watch?v=kbNuBvpfDuY)
ERROR: .....
............
WARNING: Failed to download song. Will retry after other songs

INFO: 3. LO APRENDÍ DE TI -  HA ASH- PRIMERA FILA- HECHO REALIDAD (http://www.youtube.com/watch?v=L4dxE5GYNnc)
ERROR: .....
............
WARNING: Failed to download song. Will retry after other songs

@ritiek solved, we can close this issue


ValueError: X.shape[1] = 387 should be equal to 303, the number of features at training time

Rasa Core version:0.9.0a3
Python version: 3.6.5
Operating system (windows, osx, ...):10
Issue: On making the parse request to the http server i am getting this error. My code is hosted on the windows os server. Same bot is working fine on my local system.
Content of domain file (if used & relevant):

You're most likely using a different spacy model on the local system/server. Try retraining your model on the server

@akelad i know this problem gets resolved on training the data again.. But on training the data again my intent's are getting mismatched

I assume there's an issue with your training data, or nlu config then. Have you added new intents/entites?

yes the same training data works well on local system but on training the data on server misbehaves sometimes, specially happens with intent catching an custom regex

could it be that you switched to different spacy version?

@Ghostvv  thanks your suggestion solved my problem :)


Change description

In Default reason code, select a default reason code. The reason codes must have already been set up in Accounts receivable > Setup > Customer write-off reason codes or Accounts payable > Setup > Customer write-off reason codes. The Default settle remainder account will default to the account assigned to the write-off reason code.
Change to:
In Default reason code, select a default reason code. The reason codes must have already been set up in Accounts receivable > Setup > Customer write-off reason codes or Accounts payable > Setup > Vendor write-off reason codes. The Default settle remainder account will default to the account assigned to the write-off reason code.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3c8635ed-273e-839d-2f47-7f96cbe8324b
Version Independent ID: 1c546cbd-7db6-a30e-b2e7-0e63d6d0e55d
Content: Settle remainder - Finance | Dynamics 365
Content Source: articles/finance/cash-bank-management/settle-remainder.md
Service: dynamics-365-finance
Product: ****
Technology: ****
GitHub Login: @angelad116
Microsoft Alias: angelading

Bug 785982 has been logged to address this issue.

@twheeloc, can you find the appropriate owner for this.  Thanks!

@twheeloc, can you find the appropriate owner for this. Thanks!

@twheeloc, I confirm the suggested change is valid.  Will you change it or I shall do it?

@pmjmg, thank you for the feedback. The content will be updated.


Redirect if_ruby's stderr to vim message

Problem
Sometimes Ruby program outputs warnings to stderr. And it breaks vim drawing when using if_ruby.
For example:
" in vimrc
ruby $stderr.write 'something'

It breaks Vim drawing. And reading the warning is hard. Because the warning will fade out by re-rendering of Vim.
Solution
Redirect stderr to vim message same as stdout.
This change will display warnings as vim's message, so it does not break drawing of Vim. And we can look again warnings by :messages command.

Codecov Report

Merging #3238 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3238      +/-   ##
==========================================
- Coverage   76.44%   76.42%   -0.02%
==========================================
  Files          93       93
  Lines      136798   136802       +4
==========================================
- Hits       104570   104554      -16
- Misses      32228    32248      +20

Impacted Files
Coverage Δ

src/if_ruby.c
58.2% <100%> (+0.32%)
:arrow_up:

src/gui_gtk_x11.c
47.63% <0%> (-0.45%)
:arrow_down:

src/ex_cmds.c
79.81% <0%> (-0.23%)
:arrow_down:

src/channel.c
83.03% <0%> (-0.08%)
:arrow_down:

src/undo.c
83.09% <0%> (-0.07%)
:arrow_down:

src/window.c
81.69% <0%> (-0.04%)
:arrow_down:

src/if_py_both.h
76.57% <0%> (ø)
:arrow_up:

src/if_xcmdsrv.c
84.71% <0%> (+0.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6183ccb...0e0508f. Read the comment docs.


chore: migrate blur to glsl 330

migrate blur shader for gls330
the blur is used for bloom, haze.
required PR: https://github.com/Terasology/CoreRendering/pull/46

 OpenGL migrations


feat: pass go back props

The type of this PR is: Feature

This PR resolves []
Description

PR Checklist (tick all before merging)

[ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[ ] I have tested my changes on iOS and Android.
[ ] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[ ] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added an app state migration, or my changes do not require one. (What are migrations?)
[ ] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Pass back props - dimatretyak

This PR contains the following changes:

Dev changes (Pass back props - dimatretyak)

  Generated by :no_entry_sign: dangerJS against 6ca3d888c56f4345b76a0a4835bb2ed95dba913f


compiler_rt testing

I have been trying to test the compiler_rt flag and am a bit confused.  It seems like the file is being loaded and the functions are not being used.
I have put a raise "testing" inside the __mulodi4 rt function.
https://github.com/crystal-lang/crystal/blob/master/src/crystal/compiler_rt.cr#L4
After building crystal and running .build/crystal eval "puts 1_i64 * 1_i64" I would expect crystal to raise "testing" and it does not.
I have checked the build output and the "compiler_rt" flag is being passed.
$ make
Using /usr/local/opt/llvm@6/bin/llvm-config [version=6.0.1]
c++ -c  -o src/llvm/ext/llvm_ext.o src/llvm/ext/llvm_ext.cc<EMAIL_ADDRESS>-stdlib=libc++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -DNDEBUG   -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
cc -fPIC    -c -o src/ext/sigfault.o src/ext/sigfault.c
ar -rcs src/ext/libcrystal.a src/ext/sigfault.o
CRYSTAL_CONFIG_PATH="/Users/jack/source_code/open_source/crystal/src" CRYSTAL_CONFIG_LIBRARY_PATH="/usr/local/Cellar/crystal/0.28.0/embedded/lib" CRYSTAL_CONFIG_BUILD_COMMIT="8e3075027" ./bin/crystal build -D preview_overflow -D compiler_rt  -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib

also if I put a raise in the file itself after the compile check and it seems like the file is being loaded.
Am I missing something?

You need to use bin/crystal

instead of .build/crystal

@asterite I just rebuilt on master and I am still not seeing a raise.
$ bin/crystal eval "puts 1_i64 * 1_i64"
Using compiled compiler at `.build/crystal'
1

Because multiplying two int64 is just an llmv primitive (I think mul), I don't see why compiler rt would be involved.

Oh, it's with overflow. Did you try with -D preview_overflow?

When building the compiler -D preview_overflow is there.
I am pretty sure the file is being loaded.
When I cause an overflow I am kind of suprised by the results but that seems like another issue.

You need to pass the flag when compiling any program, not just the compiler. I don't think bin crystal passes it.

It seems like it still does not work how I would expect.
$ bin/crystal eval "puts 1_i64 * 1_i64" -D preview_overflow -D compiler_rt
Using compiled compiler at `.build/crystal'
1

There could be many reasons:

LLVM notices the result is obvious and doesn't need to call that function
compiler_rt isn't used in all platforms

I have tried compiling this on linux and I have been getting the same results.
I am curious I have not used fun on the top-level before.
Is that where it should go?

AFAIK compiler_rt is only used on a few platforms that miss some features (i.e. Int128 on i386 arch). It's not used or linked for anything else or any other architecture.
I.e. it's just a convenience to implement some features that would be otherwise broken on some targets. It's not used unless it really has to.

@ysbaddaden is right. The compiler_rt.cr is used in 32bits arch to multiply 64 bits integers.
In 64 bits the 64bits multiplication (ie: @llvm.smul.with.overflow.i64 do not use __mulodi4)


Resolved: GO Portal is back up in 7f7627a.


Change 'Blog' in footer to 'News' and point to https://www.freeukgenealogy.org.uk/news

E0 U2 S4 C8: P14

@UTpH No, it seems this still needs doing. The newly added 'Developer' label may mean that the person who takes this task on needs to be able to access our systems. @smrr723 can you advise?

@DeniseColbert correct - needs to be a Developer and will need to be set up on cloud9 or have FreeCEN running locally after going through the instructions in https://github.com/FreeUKGen/FreeCENMigration/blob/master/CONTRIBUTING.md

Wondering if the GFI label is appropriate here, in that case?

I think so @DeniseColbert  - it's still a Good First Issue for new volunteer developers.

Ah, so GFI + Dev = GFI for Dev. Gotcha 👍


Revert "Update README.md"

Reverts beautiful-discord-community/resources#52

@Nerdietony Can you upload the image to a more reliable server? I merged your PR but noticed the image didn't resolve.

I don't think it's necessary in this case, as this is more of a "copy paste" type snippet, most people would want to put their custom pictures anyway

^*

If it becomes a problem we can always fix it later, for now its fine.


Remove devDep from terra-clinical-package.json template

Description of Issue
Update terra-clinical-package.json template to remove terra-toolkit from the devDependencies. This dependency is no longer needed. PR #80 in terra-clinical repo.

This has been released in v1.0.2


AppearanceDelegate

Hey
I think you have changed the
calendarView.appearanceDelegate

to something else and forgot to update your readme file?
Since Xcode complaints after I copy the code in the readme to set the delegates.
BTW, it is a very nice calendar :)

@Mr-Getting-It-Done As far as I can tell there hasn't been any changes to the mentioned line. Could you name the file and also what the actual issue is? Thanks!

@elsesiy  It looks like it may now be calendarView.calendarAppearanceDelegate

Has been fixed in 2bb7176 accordingly. Thanks :+1:


Update Composer dependencies (2021-07-04-00-06)

Visual regression test passed!
View the visual regression test report


i want to use your engine as a base to mine

hi,
i wanna make a ray tracing plugin to a game engine called godot iam not one of the gme engine's devs or smth just a user soo i wanna use your engine as a base to mine i will add alot more features and optimizations to it so it works perfectly with a game and the plugin will be completely free and open source after making everything in python i will translate them to gdnative to make the plugin i just want to take permission from you for using it and your name will be mentioned in the vreators page of the plug in,
thnx in advance zenux

Hi!
There is no problem with using and modifying this ray tracer in your project; just cite this repository.
Best wishes for your project, and keep me updated about it!

Hi!
There is no problem with using and modifying this ray tracer in your project; just cite this repository.
Best wishes for your project, and keep me updated about it!

thnx alot and sure i will keep you updated about it

thnx alot and sure i will keep you updated about it

hi i was wondering is there a way to read obj or fbx files to be putten in scene instead of basic ones using scripting or smt?

I already have implemented a class named  TriangleMesh  to load arbitrary .obj files as triangle meshes.
However, the rendering is quite slow because we need to loop for every triangle of the mesh, and Python loops are very slow. A bounding volume hierarchy acceleration structure could be implemented, but I think renders will still take a lot of time.
If you want to render arbitrary triangle meshes, Python isn't the language to work with.
I worked some time ago in making a very similar Python interface to the C++ Ray Tracing in one-weekend project. I didn't implement an obj loader, but it shouldn't take a lot of work. The raytracer can already quickly render complex scenes with a very similar scene scripting language to this raytracer written in pure Python.
I can share the project with you if you want. However, you should be proficient in C++ to be able to modify it.

oh ok iam not fammiliar with c++ but i gotta learn it cause godot's plugins should be made with c++ to work fast and even to work soo ya thnx alot again


Add Gitpod config

This way we can start the Gitpod with MongoDB running, and the DATABASE_URL env set.

@Gustavoggsb I was successfully able to start the project connected to the database. Could you test as well?


#161 fix, drag+drop handling on reorderable list header

-Partial fix for #161, null ref when viewing gameobject with null script.  Not displaying the usually missing script unity warning, but no longer throwing a null ref.
-Addition of drag + drop handling on the reorderable list header the way unity lists supports
-Fix for custom type propertydrawers not rendering properly when using just the reorderable list header.

Merged into the v2 branch

842f290e6d4e8fcc4a870458650b08af84f2dcf6
4ec9023fe4a15df5bd108e33905f61813e6acf98

I shielded the null reference exception, and also added an error message for a missing script, because I want the user to know that something is not right.
I also extended your drag and drop support. If you drag and drop a game object onto a list that holds transforms/monobehaviours, the transforms/monobehaviours will be extracted from the game objects.


Refactoring of the way dropzone works

This is a fix for #7916 alternative to #7921
We basically have a new JavaScript global object (ccm_fileUploader) that we can use to upload files via Dropzone.
When we have the file manager, we tell ccm_fileUploader to use the whole page as a drop zone, without a place where upload progress should be reported (we'll use only NProgress).
When we open the Add Files dialog, we (re)initialize the Dropzone, so that upload progress is reported in that dialog (but the drop zone is still the whole page).
When we close the  Add Files dialog, we (re)initialize the Dropzone as it was before opening the dialog.

This looks great in my testing. A definite improvement.
One thing that's interesting is that dragging multiple files into the file manager window no longer treats them like a bulk upload of multiple files. Instead it opens multiple upload complete dialogs for each one. Whereas if you upload them in the dialog box, it opens a complete dialog for all files, letting you bulk set sets, attributes, etc... Not a huge deal, but interesting.
Thanks!


Is there way to remove metrics over api?

We have distributed graphite cluster, and tons of test boxes, and I trying to figure out how to make cleanup destroyed boxes from graphite.
Is there way to remove metrics from whisper over graphite-web api?

@blacked check out https://github.com/Kixeye/graphite-web/tree/0.9.x-deletemetrics if you're running 0.9.x... Not sure if it's still a clean merge but pretty sure it was working just not QA'd.


Implement dependabot scanning of integration tests.

Use dependabot scanning for integration tests as well once https://github.com/dependabot/dependabot-core/issues/2178#issuecomment-2020450225 is implemented and released on GitHub.

Some of the tests now rely on fixed versions to test certain cases so for now I am closing this until it is needed as a higher priority. Will reassess when the Dependabot Beta is publicly accessible on GitHub.


full shuffle of the dataset

We currently split dates between tasks / workers and then the shuffling is performed in these subsets. These changes shuffle the dataset consistently on all workers and then each worker takes its subset from the shuffled indices.
Thx to @JoffreyDumontLeBrazidec for testing.

This can be merged.


Garbage Collection: Background deletion.

Page: https://kubernetes.io/docs/concepts/architecture/garbage-collection/#background-deletion

Background cascading deletion

In background cascading deletion, the Kubernetes API server deletes the owner object immediately and the controller cleans up the dependent objects in the background. By default, Kubernetes uses background cascading deletion unless you manually use foreground deletion or choose to orphan the dependent objects.

I have problems understanding this text.
First: If I read that, then I think Finalizers seem to get ignored if you use background-deletion. But I don't think so.
Second: "... the controller cleans up the dependent objects". What is "the controller" here? If I have a custom controller for my CRDs. Is that meant with "the controller"?

/retitle Garbage Collection: Background deletion explanation is hard to understand

/triage accepted
/priority backlog

If there is still room to work on this issue, I would like to work on this. @guettli
@ayushpatil2122
Kindly assign this to me


Asahi Linux installer failure (alternative distro Debian)

Hello,
Please find the installer.log file attached to this message. It reports a failure during the installation process.
installer.log
Thanks a lot for your work.
Sébastien

This repo is for upstream Asahi Linux. You would need to ask Thomas Glanzmann for support for his Debian installer.
Please note that Glanzmann's Debian installer is separate from the Debian Bananas who are working on official Asahi Debian support: https://wiki.debian.org/Teams/Bananas

Hello,
Sorry for that. I followed Thomas Glanzmann instructions. I will check with him.
Thank you for the note.
Good evening.


[CU-26pmc5q] Adds test file for test PR

This is a test PR to make sure a preview build is triggered when a PR is opened.

Task linked: CU-26pmc5q Add preview deploys

Closing since this PR is only to test that the preview build is triggered by a PR and not meant to be merged.


Support Project owner to see istio links

Proposed changes
Support Project owner to see istio links

Types of changes

Bugfix (non-breaking change which fixes an issue)

Linked Issues
https://github.com/rancher/rancher/issues/20695
https://github.com/rancher/rancher/issues/20713

Further comments

@westlywright backend in


Add Windows installer using InnoSetup 6

Possible fix for #3224 😘
This adds an InnoSetup script and modifies the GitHib Actions workflow to run the necessary steps that produce a self-contained installer file from the contents of the ZIP file of the Windows (with Java) build artifact.
So far this is untested on the GitHub Actions CI, but a proper installer is produced like this, when the InnoSetup Command Line Compiler is invoked manually with "%ProgramFiles(x86)%\Inno Setup 6\iscc.exe" -DMyAppVersion="3.8-SNAPSHOT" -DMyProgramFiles="target\openrefine-3.8-SNAPSHOT" "packaging\openrefine.iss" from the repository root after manually copying the contents of the folder in the ZIP file to packaging\target\openrefine-3.8-SNAPSHOT (that's what I got from running mvn -B deploy -DskipTests -Dgpg.skip).
It's still running at https://github.com/dorianmuthig/OpenRefine/actions/runs/4931761252 but I can obviously not properly test this, because of reliance on the digital signature workflow.
Also it seems like the Windows action does not wait for the Mac action to finish on first glance.
So that this can run on autopilot, what would you prefer?

build on Windows, and thus build twice, or
[x]  find a way to make it wait until the macos build process has finished

Any other suggestions and feedback?

IssueHunt Summary

Referenced issues
This pull request has been submitted to:

#3224: Allow easier install and uninstall on Windows

Okay, I forgot the needs: <job_id> directive.
Seems to looks right now: https://github.com/dorianmuthig/OpenRefine/actions/runs/4932031312
Still can't test the workflow further, but I do expect it to work like this.

@dori4n Hi and thanks!
I don't think we expect you to fully modify our snapshot release process!  That's something that we can certainly do later on our side.
I think for now, just create a brand new GitHub workflow file on your end... call it windows_release.yml and add this as a commit and revert the changes on our snapshot_release.yml file for now.
Then we'll be able to check out your branch... run that particular windows_release.yml workflow file (and any of your other INNO setup files) to verify in our own private repos that indeed a INNO package is created successfully and I can run it on my Windows 11 machine and do more testing.
Later on we can modify our own CI release process.  We can reuse your windows_release.yml as a step in our snapshot_release.yml  ... which is done through this process https://docs.github.com/en/actions/using-workflows/reusing-workflows and which we'll gladly take care of on our side.  We can call that windows_release.yml and even pass data down into it including secrets, keys, envs, etc.  Which is something you don't have to worry about.

I think we can already work with what is here, I don't think there is a need for a new GitHub workflow file as it would duplicate many steps that we currently have :)
Thanks a lot @dori4n, I will try it out in the coming days and get back to you.

One question: why unzip the artifact in the MacOS job, and upload it (as a duplicate artifact) to the release?
Would it not be simpler to unzip the artifact within the Windows job directly, removing the need for this duplicate artifact?

@wetneb

One question: why unzip the artifact in the MacOS job, and upload it (as a duplicate artifact) to the release?

It was easier to do it this way. A GitHub Actions workflow artifact is like a file share, and the upload and download is fast. Going through the release artifacts and downloading them from there and then unzipping takes more time, but also requires using PowerShell on Windows, because a native terminal unzip command does not exist, or 7-Zip (which does come pre-installed).
Also, the ZIP archive generated is generated in such a way that the files in the archive are placed into a directory inside the archive. Dealing with one less naming conflict is one less headache to worry about.

Would it not be simpler to unzip the artifact within the Windows job directly, removing the need for this duplicate artifact?

It depends. It can be.  And since workflow artifact folders are different from release artifact files, this was to the best of my knowledge, the faster option (though, I don't know if that is still true, it's been a while).

Ok, got it, I had not paid attention to the difference between release and workflow artifacts. That makes sense to me.
With this proposed workflow, the installer will only be published for official releases. I wonder if it should also be published for snapshot releases. We currently publish all four packaged variants (MacOS, Linux, Windows with java and Windows without Java, both as zip files) in Maven Central for snapshot releases, so it would feel consistent to have the installer there too. It would at least make testing the pipeline easier!
I am not too sure how to go about this though. We could call Maven again after your workflow, registering the generated exe as an artifact and deploying it to Maven Central, but that seems rather complicated.
For testing purposes, why don't you upload the generated .exe as a workflow artifact (in all cases, or just when it's not an official release)? I would then merge this so that we can test out the workflow in its intended environment. We think again after how to best publish this afterwards.

@wetneb

why don't you upload the generated .exe as a workflow artifact (in all cases, or just when it's not an official release)?

Like this? 🥳

I did some more experimenting in a separate branch where I have turned off the GPG signing process and skipped OSSRH deployment, and I've discovered that the generated file name of the build artifact always ends in -3.8-SNAPHOT, instead of the actual version number and commit hash. I don't think that's ideal.
But I also don't know where to change that and how to the adapt the pattern in to the name of the build artifact.
In fact, this is even true for a release build, such that I cannot believe the workflow as present in the master branch was even working to publish a release as is.
I'm sorry. I'm getting a little confused now.
I can fix your GitHub workflow, but I feel like this is getting a little out of scope for this issue now.
The installer works, and so does the GitHub workflow to create one, even if the file paths may be wrong in a release build.
On the test branch with signing disabled:
Commit build: https://github.com/dorianmuthig/OpenRefine/actions/runs/4961976622#artifacts
Release build: https://github.com/dorianmuthig/OpenRefine/actions/runs/4961996873 (I cheated and created a tag with #3.8-SNAPSHOT for this)
Release artifacts: https://github.com/dorianmuthig/OpenRefine/releases/tag/3.8-SNAPSHOT

It is normal that the files generated by the Maven workflow only have 3.8-SNAPSHOT in their name. The additional metadata is added by Maven Central after upload. You can see that the files available for download have a datestamp in them (just try downloading any of the snapshot releases).

@wetneb

It is normal that the files generated by the Maven workflow only have 3.8-SNAPSHOT in their name

That is not what I meant. I mean the steps at .github/workflows/snapshot_release.yml, lines 239 onwards (on the master branch), where the release artifacts are uploaded to GitHub when you publish a tagged release.
Even the workflow script as is without my changes would fail, because the asset_path uses ${{ steps.get_release_upload_url.outputs.tag_name }} in the file name, even though it is 3.8-SNAPSHOT in the output file name, if the tag is set to something else.
The Maven build does include the current commit hash into the build artifact and this is shown in the bottom left corner of the web interface. This means that it should be possible somehow to have it use the right file name.
But I can also just change it to 3.8-SNAPSHOT and be done with it.

When we do a release, the name of the tag is equal to the version which is stored in the pom.xml files, so I am not sure where you see a problem. I do think it works, that's how we have been publishing releases for a while now :) Anyway, if you want to make any change to this, we can consider it, but it's probably irrelevant to this PR so we should be discussing that somewhere else.

@wetneb
Hm... okay.
Then I will leave it as it is now. Just don't forget that you will have to change all occurrences of 3.8-SNAPSHOT in the workflow file when you change it. I just have a strong preference to having versioning artifacts in as few places as possible, so that you only need to change them once.
It is possible to also upload the other build artifacts as GitHub Actions artifacts in addition to the Maven repository, but I don't think that this is necessary or within scope. I might do that, if I get bored today, maybe.
I don't know how to upload the installer file to the Maven repository, and I cannot test that anyway, so it's better if you do that.
You will probably want to digitally sign the executable file, too, because if you don't Windows SmartScreen will be complaining and preventing users from running the installer after downloading it. I tried it with the workflow artifacts from my tests in a newly installed Windows VM, and I had to click through 5 different prompts to keep the downloaded file in Edge and then run it, and I would never recommend anyone who doesn't know exactly what they are doing to click past any of that.

Then I will leave it as it is now. Just don't forget that you will have to change all occurrences of 3.8-SNAPSHOT in the workflow file when you change it. I just have a strong preference to having versioning artifacts in as few places as possible, so that you only need to change them once.

Ah right, of course the new workflow steps that this PR introduces should not have a hard-coded version number in them. (But that's not a problem with the existing workflow steps, right?)
We could simply store the version number in an environment variable earlier in the workflow. It can be computed with:
mvn org.apache.maven.plugins:maven-help-plugin:3.1.0:evaluate -Dexpression=project.version -q -DforceStdout

@dori4n what do you think about the approach above? I think it would be good to deduplicate the steps you have introduced, so that we just extract the version number once and then use it in the following steps, regardless of whether it is a snapshot or final release.

@wetneb I've had other things to deal with so I couldn't look at it, yet.

We could simply store the version number in an environment variable earlier in the workflow. It can be computed with:
mvn org.apache.maven.plugins:maven-help-plugin:3.1.0:evaluate -Dexpression=project.version -q -DforceStdout

I'm going to have to look into how to make that work. All the old ways of passing string data between workflow steps are deprecated and I also don't know if passing values between systems and runners' instances is possible using the new way.

what do you think about the approach above?

Sounds good in theory.

I think it would be good to deduplicate the steps you have introduced, so that we just extract the version number once and then use it in the following steps, regardless of whether it is a snapshot or final release.

Well, the way it is now, my changes do add a duplication for the steps that use the version number and also to decide whether to attach a workflow artifact or a release artifact for the installer, depending on whether it is a commit run or a release run, respectively. But like I said, I can't imagine ${{ steps.get_release_upload_url.outputs.tag_name }} being replaced with the proper value when you publish a release, unless you do this manually and adjust the pom.xml accordingly, just before you do.
You can't just create a tag on a commit and then publish the release on GitHub like this, because this definitely fails: https://github.com/dorianmuthig/OpenRefine/actions/runs/4962428433/jobs/8880469348
I'll go get some sleep, and then I'll look into whether I can get rid of the duplications, and ideally make it such that publishing a release on GitHub is as easy as creating a commit tag and hitting publish on the website for it, like I suspect this was supposed to work. 😉

Ok! Perhaps this page is helpful to understand our current workflow:
https://openrefine.org/docs/technical-reference/version-release-process

@dori4n polite nudge.  What the state of things?  Anything our team can further help you along with on this?  We'd love to see you claim the bounty.  If the blocker is truly about GitHub Actions or limitations you are struggling with, we can even invite GitHub Support here to help you out more. (I know a few folks)

I'm sorry, I've been sick. And then I kinda forgot about it for the past week while dealing with other things.
My thoughts on how to go on from what you can see have been:

Differentiating from release and push actions
Automatically setting the version to the release tag (possibly escaping invalid characters?), if it's a release, like step 2 from https://openrefine.org/docs/technical-reference/version-release-process
Using the command you provided with your comment here to extract the current version number and piping it into a job step output variable (gonna have to experiment with the format of that to see how to use it properly) so that it can be used to to dynamically set the file names and the names of the artifact uploads

What I was struggling with three weeks ago was dealing with transitioning the job step output from the Mac runner to the Windows runner. The documentation says jobs.<job_id>.needs should be enough to make jobs.<job_id>.outputs available, but it wasn't working properly with bruceadams/get-release (or maybe I made a mistake, not sure) so I put it in twice to make it work. I'm a bit worried I may not be able to do 3. Or at least not without duplication.
I've been up all night and am a bit tired now, and I really need to grab some sleep. I'll look at it again in the evening. 🙂

@wetneb @thadguidry
Okay, the last test is running now at https://github.com/dorianmuthig/OpenRefine/actions/runs/5402979084
If it doesn't fail, I would consider this safe to merge.
Open issues (not breaking):

Code signing for the Windows binaries
I can't test that, as it requires key configuration in the GitHub account, and a code signing certificate. However, recent changes to rules for certificate authorities now require code signing certificates to be generated on and used with a hardware cryptography token. I'm not sure this is compatible with GitHub actions (and the nextgens/authenticode-sign-action signing tool). One of you would have to configure and test that, if it is wanted.
How to upload the Windows installer file to OSSRH/Maven for commit snapshots
You have made some changes to the workflow file since. I hope there are no conflicts with my changes now.

@wetneb
Looks like it worked and the installer artifact is available at https://github.com/OpenRefine/OpenRefine/suites/14066426575/artifacts/786206866 🥳

I really like it!
Notes from my own testing

@wetneb
Hi

during the install phase we are presented with a license text with "copyright Google 2010" or something like that: we should update that to include "OpenRefine contributors" as well

I have just passed in the LICENSE.txt file from the build output root. It is possible to omit that step from the installer entirely, too, if it doesn't contain anything the user has to agree to for merely using the software. This isn't really true considering the disclaimer in all caps in the last line of the file.
However the issue you raise is present in all copies of the license, and not installer specific

At the end of the install process I was given the option to open the README file automatically (and this option was ticked by default). Because the README file is README.md, my computer failed to open it. We should likely have a .txt file instead or disable this feature entirely:

That error appears, because no application is associated with the .md file extension. JrSoftware recommends using .txt or .rtf files, which are associated with Notepad and WordPad, respectively, on Windows by default.
You can disable this by commenting out line 72 in openrefine.iss.


HTML5 not working when I try to play a song on it

Describe your problem here.
I compile the game to HTML5 and everything works perfectly but when I enter any song, it stops working. here is what it shows on the inspect element console

im on 0.6.3
Are you modding a build from source or with Lua?
Source
What is your build target?
HTML5/Browser
Did you edit anything in this build? If so, mention or summarize your changes.
No

0.6.3 is not supported anymore, don't report issues about it.

0.6.3 is not supported anymore, don't report issues about it.


Add mp3 file icons

Current Behaviour

I think that any of these icons would be a great fit in this case:

Unfortunately no seti icon other than nf-seti-audio which isn't the greatest fit.

Apologies for the miscommunication @pauchiner ; I simply meant that there was nothing available from seti for us to use.
Please do raise a PR with one of the icons you proposed.
If you're keen we could add it for some more file types but that's up to you.

I created the PR with only the mp3 file icons. I also add more audio files extensions that uses those icons?

I created the PR with only the mp3 file icons. I also add more audio files extensions that uses those icons?

That would be fantastic, yes please.
If specific icons are created in the future we can easily change to them.


⚠ Turnos 24x7 has degraded performance

In 0e22008, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 884 ms

Resolved: Turnos 24x7 performance has improved in 83c8915.


Initial EKS cluster creation

What type of PR is this?
/label kind/documentation
What this PR does / why we need it:

Refactoring the cluster module to simplify the managed node groups creation on EKS and updating to Windows 2022.
Adding README for the Terraform EKS

Which issue(s) this PR fixes:
Fixes #98

Why are we dropping the config for the jumper ?

Why are we dropping the config for the jumper ?

I think I missed the jumper setup, is data "aws_ami" "ubuntu_2204" bringing the EC2 or just setting the data?

@marciogmorales will take over from here.

/lgtm


Feature - Dump Progress Callback

It would be great if there was an option you could pass in that would call a callback function to indicate progress.
I am currently running mysqldump in a cron task but if the tasks takes too long it will fail. I can extend the lock time but it would be great to continually call a keepLock() function during a progress update of some sort.
I thought of a couple work arounds. I could not await the promise returned from the dump and create some sort of setInterval that would watch the file being created and see that it continues to grow, however having something inside the library would be great.
Thanks

Couldn't you just start the dumo as well as starting a setInterval, and then clear the interval once the promise resolves?
It'd achieve the exact same result without any changes to the library.
Otherwise we'd have to find a logical place within the library to call a callback. Depending where that is, it could be an inconsistent duration between callbacks depending on the size of the tables being processed.
Doing this in user land would be much more consistent.

Yeah that was my proposed alternative if I had to figure it out without any changes to mysqldump.
It would just be nice if there was a way internal to the library that I got an everything is progressing just fine. Some of my larger database dumps take about 65 minutes or so.


SIGGEGV when enable tree-sitter on macos

I config rust-mode on my archlinux device, it works well.
(use-package rust-mode
  :init
  (setq rust-mode-treesitter-derive t))

But when I try to use the same init.el on my macbook (with apple silicon), after I press enter or input symbol like "(", the emacs crashed with the error below:
$ emacs main.rs
Fatal error 11: Segmentation fault
zsh: segmentation fault  emacs main.rs
SEGV $

I have no idea how to debug the error.

It seems to be a bug of emacs built-in rust-ts-mode, it's confusing.


Blob properties dialog: adding metadata handles keyboard focus poorly

Storage Explorer Version: 1.2.0
Platform: Windows
Architecture: win32
Regression From: Unknown
Steps to Reproduce:

Open the properties dialog for a blob
Tab to the add metadata button
Hit enter

Expected Experience:
Keyboard focus should go into the textbox for the new metadata
Actual Experience:
Keyboard focus stays on the button

This issue has been fixed. So close it.


No PNG image support

Search before asking

[X] I have searched the Autodistill issues and found no similar bug report.

Bug
Autodistill does not appear to support reading and/or copying PNG images, either from command line or Python script. When running autodistill from the CLI or Python script, it will not copy any PNG images in the input images folder to the specified output dataset folder. Given that JPG can be fraught with compression issues and are a generally lower quality than a lot of our native PNG or TIF images, this is problematic as it requires converting every single image to a compressed format.
Native support for PNG images is necessary.
Environment
Windows 11 with bash console
Created and configured environment via:
conda create -n autodist python=3.12
conda activate autodist
which nvcc
pip install torch torchvision torchaudio –index-url https://download.pytorch.org/whl/cu121
pip install jupyter scikit-learn roboflow
pip install -e .

To get PyTorch to configure properly for GPU use, I install it from a whl URL with the compatible version of CUDA. This configured the environment properly to get the program to run without any missing packages.
Minimal Reproducible Example
CLI:
autodistill images --base="grounding_dino" --target="yolov8" --ontology '{"rock": "rock", "mussel": "mussel", "crayfish": "crayfish"}' --output="./dataset"

Python script:
from autodistill_grounding_dino import GroundingDINO
from autodistill.detection import CaptionOntology
from autodistill_yolov8 import YOLOv8

# define an ontology to map class names to our GroundingDINO prompt
# the ontology dictionary has the format {caption: class}
# where caption is the prompt sent to the base model, and class is the label that will
# be saved for that caption in the generated annotations
base_model = GroundingDINO(ontology=CaptionOntology({"fish": "fish"}))

# label all images in a folder called `context_images`
base_model.label(
  input_folder="./images",
  output_folder="./dataset"
)

target_model = YOLOv8("yolov8n.pt")
target_model.train("./dataset/data.yaml", epochs=200)

python train_model.py
Additional
Happy to help if there is anything I can do. It's just frustrating to not be able to use a variety of images in their native format but have to instead convert them to JPG format with lower quality.
Are you willing to submit a PR?

[ ] Yes I'd like to help by submitting a PR!

There seems to be native PNG support in the base model loading, but you need to specify your extension.


Need clarity on Loopings

Would be great if someone could clarify on what the Loopings task is intended for. Right now the problem points highlighted are essentially closed ways and there seems to be no unusual tags associated with those, but still they are indicated as erroneous ones. A few screenshots from the task.

cc @Rub21 @aaronlidman @planemad

@ramyaragupathy from http://keepright.ipax.at/

loopings
Any way that contains any single node more than twice is considered an error. Any way may contain just one node twice. If more than one node is found twice it is considered an error.

Although the data seems to be throwing up a lot of false positives, or else its outdated and have been fixed. I'd say just go with the above description for now.


Scout / Meilisearch Support

I have implemented a custom solution for scout/meilisearch support in my datatables around a month ago. Here are some explanations of it so you get the idea. If there is interest in this, i can clean this up, try to make it generally compatible to all scout engines (currently only meilisearch) and create a pull request @yajra
The core idea was to keep the normal search/ordering/filter abilities and add the meilisearch engine on top of it so both can be used together. If the meilisearch engine is not indexed yet or has a downtime, the system automatically falls back to the normal search engine. Additionally it is possible to define both meilisearch filters and normal filters so that you can join and filter other tables/cols after the meilisearch search was already done.
In my case there are static products (that are indexed to meilisearch and searched via meilisearch), but these products had dynamic prices that were changing too often to index them properly. So the search engine first searches for all products matching the keyword and then adds a mysql filter on top of them.
Example usage:
public function dataTable(QueryBuilder $query): EloquentDataTable
{
	return datatables()
		->eloquent($query)

		// Enable scout search engine for App\Models\Product
		->enableScoutSearchWith(Product::class)

		// Add filters for the scout search engine
		->scoutFilter(function ($keyword) {
			// ...
		})

		// Add filters that are applied after getting the results of the scout search engine / on the fallback search engine
		->filter(function ($query) {
			// ...
		}, true);
}

Process:

User types in search keyword
Check if scout search engine is enabled (enableScoutSearchWith method)
Apply scout search (or if it fails, fall back to default search)

Raw search for the keyword + filters from scoutFilter method (limit: 1000 / all)
Pluck the primary key of the results
Apply a whereIn('id', all_search_result_ids) to the query
Apply a orderBy to the query with the ordering of the search results
Continue the normal process (adding the filters from filter method)

If there are any questions, feel free to hit me up :)

@frknakk thank you for taking the time to implement this. I did attempt to support Scout via https://github.com/yajra/laravel-datatables-scout but wasn't able to update it accordingly.
Anyway, I like your idea and implementation flow. Please submit a PR and will review it ASAP.

Question:

So the search engine first searches for all products matching the keyword and then adds a mysql filter on top of them.

It's a great feat that you accomplished this. Does it cause an N+1 issue?
Looking forward to your PR. Thanks!

Question:

So the search engine first searches for all products matching the keyword and then adds a mysql filter on top of them.

Does it cause an N+1 issue?

Nope. The queries can get ugly if there are a lot of results, but it's limited to 1000 hits per default anyway for most engines.
Queries for default search
1. select count(*) as aggregate from `products`
2. select count(*) as aggregate from `products` where (LOWER(`products`.`id`) LIKE ? or LOWER(`products`.`name`) LIKE ?
3. select * from `products` where (LOWER(`products`.`id`) LIKE ? or LOWER(`products`.`name`) LIKE ? order by `id` desc limit 10 offset 0

Queries for my scout search implementation
Before: fetch product id's via scout engine
1. select count(*) as aggregate from `products`
2. select count(*) as aggregate from (select * from `products` where `id` in (5865, 6487) order by FIELD(id, '5865','6487')) count_row_table
3. select * from `products` where `id` in (5865, 6487) order by FIELD(id, '5865','6487') limit 10 offset 0


Potential to be multithreaded?

Great software but I am noticing that it only uses 1 core.  Can it be made to scale to all available ones?

See related thread https://github.com/google/guetzli/issues/50#issuecomment-287424297


Kubelet was not installed on Windows nodes which initialized via worker_groups field

I have issues with Windows nodes, which was created via worker_groups
I'm submitting a...

[ ] bug report
[ ] support request

What is the current behavior?
I added one more item to the worker_groups of  terraform-aws-eks module.
Here is my implementation:
 {
      name = "win-worker-group-1"
      instance_type = "t2.large"
      asg_desired_capacity = 2
      ami_id = "ami-0a774308f6524a726"
      additional_security_group_ids = [aws_security_group.worker_group_mgmt_one.id]
   },

AMI id for my region i found here: https://us-east-1.console.aws.amazon.com/systems-manager/parameters/%252Faws%252Fservice%252Fami-windows-latest%252FWindows_Server-2019-English-Full-EKS_Optimized-1.14%252Fimage_id/description?region=us-east-1
but after initializing cluster i didn't see those nodes when i put kubectl get nodes. On the other hand i can find nodes via AWS console. Status for that is Available. I tried to dig deeper inside that and found that kubelet was not installed...
PS C:\Windows\system32> Get-Service kubelet
Get-Service : Cannot find any service with service name 'kubelet'.

What i need to do with this? Do i need to install k8s services manually for Windows nodes?
Thanks for your advice?
P.S. Linux nodes are working fine with the same configurations. Security group settings - not the issue.
If this is a bug, how to reproduce? Please include a code sample if relevant.
add code which i provided to the https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/examples/basic/main.tf , update providers and execute terraform init && terraform apply from related module folder
What's the expected behavior?
Cluster should be available with Windows Nodes, kubelet should be also available and user must see Windows nodes via kubectl get nodes.
Environment details

Affected module version: v6.0.2
OS: Windows
Terraform version:

Terraform v0.12.19
+ provider.kubernetes v1.6.2
+ provider.local v1.4.0
+ provider.null v2.1.2
+ provider.random v2.2.1
+ provider.template v2.1.2
+ eks.cluster_version: 1.14

Hello @hodduc  @max-rocket-internet !
We have found how to do that. Thanks for your help!

I will add the mr with detailed instructions soon

@max-rocket-internet @hodduc could you please review related mr? Thanks in advance!

@hodduc   could you please tell me , will you have any plans to automate this approach ?

@max-rocket-internet thanks for merge! :)


User  clicks project name in /explore to go to the project page

What is it?
A

Exposing the slug in the API call here
https://github.com/opensource-observer/oso/pull/537

Plasmic 26.0.1


Gear config followup - Add Analysis File Suggestion

api/gears/<gear-id>/suggest/session/<session-id> will now also return analyses with suggestion blocks in the file objects. This is the union of #483 and #488.
If we only want to return analyses file suggestions for certain gear categories, that can be accommodated. Returning for all gears currently. @lmperry, would a there be a usecase for running non-analyses gears on analysis output?
Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

@kofalt and I discussed these changes offline earlier this week. Tested, merging now.

@nagem: There should never be a use case that would involve a Utility gear consuming the output of an analysis gear.


Failed to resolve %23clip in a css file

Fusebox version 4.0.1-next.7
Issue is with mapbox-gl,
full error:
Failed to resolve %23clip in /Users/joshpike/Projects/aquipa/client/node_modules/mapbox-gl/dist/mapbox-gl.css:1:28436
Should probably ignore urls looking like '#blah' as they can't be resolved before build

I replaced all occurrences of %23clip with #clip
sed -i 's/url(%23clip)/url(#clip)/g' mapbox-gl.css

Sorry mate. I've moved onto angular bundler cause they can't be assed providing easy tooling for 3rd party bundlers... and esbuild for my server

I'm having this same issue...where do you run this command?  I can see the %23clip in the CSS in the dist folder, but not in the source.    Do I run it in the build pipeline?

@hound-realscore you can run it in any directory as long as the last argument to sed is the file that has %23clip in it