Jellyseerr won't start after latest update

Description
I updated both Jellyfin and Jellyseerr today to their latest versions and Jellyseerr will no longer start. Please see attached photo for logging.
Version
v2.1.0
Steps to Reproduce

Start with a previous version of Jellyseerr
Update to the latest version

Screenshots

Logs
2024-11-13T10:22:30.510Z [info]: Commit Tag: $GIT_SHA
2024-11-13T10:22:30.984Z [info]: Starting Overseerr version 2.1.0
2024-11-13T10:22:31.512Z [error][Jellyfin API]: Something went wrong while creating an API key from the Jellyfin server {"error":"Unauthorized"}
2024-11-13T10:22:30.510Z [info]: Commit Tag: $GIT_SHA
2024-11-13T10:22:30.984Z [info]: Starting Overseerr version 2.1.0
2024-11-13T10:22:31.512Z [error][Jellyfin API]: Something went wrong while creating an API key from the Jellyfin server {"error":"Unauthorized"}
... repeats hundreds of times

Platform
desktop
Device
Any
Operating System
Unraid 7.0.0-beta.2
Browser
Edge, but n/a
Additional Context
No response
Code of Conduct

[X] I agree to follow Jellyseerr's Code of Conduct

For anyone reading this issue having the same issue, you can read the log error it tells you what to do. In this case, have to add apiKey key to settings.json's jellyfin block and you can obtain the apikey from jellyfin dashboard

For everyone as confused as me, this is how I fixed this issue for me.

Go to your jellyFIN, click on "person" icon in top right corner, then "Dashboard" and then "API Keys" on the bottom left.
Here create a new API key, name it whatever.
Bring down your jellySEER container.
Go to "/config/" folder and open/edit "settings.json".
 This is where I added the API key I created in jellyFIN.
After I added the  "apiKey": "supersecretapikey123", , jellyFIN came up without a problem.

@Fallenbagel we should add this to the docs

@Fallenbagel we should add this to the docs

Yeah and we can link the docs url in the error message

im using portainer and cant figure out how to access that if I look under inspect  text under "Config":  { there is no 'jellyfin'section

im using portainer and cant figure out how to access that if I look under inspect  text under "Config":  { there is no 'jellyfin'section

It's whereever you mounted your config folder. If you didn't mount your config folder, that's not a proper setup.

mine looked a bit different but literally just adding that section under serverid worked

I don't think you can do this change with Portainer, or at least I don't know how to.
My docker-compose looks like this:
version: '3'
services:
    jellyseerr:
       image: fallenbagel/jellyseerr:latest
       container_name: jellyseerr
       environment:
            - LOG_LEVEL=debug
            - TZ=Narnia
       ports:
            - 5055:5055
       volumes:
            - ./config:/app/config
       restart: unless-stopped

So for me the config folder is located in the same location as docker-compose.yml i.e. root.

Yep I just went to the jellyseer folder in root and added it under the
server
On Thu, Dec 5, 2024, 7:33 AM grannymaster @.***> wrote:

I don't think you can do this change with Portainer, or at least I don't
know how to.
My docker-compose looks like this:
version: '3'
services:
jellyseerr:
image: fallenbagel/jellyseerr:latest
container_name: jellyseerr
environment:
- LOG_LEVEL=debug
- TZ=Narnia
ports:
- 5055:5055
volumes:
- ./config:/app/config
restart: unless-stopped
So for me the config folder is located in the same location as
docker-compose.yml i.e. root.
image.png (view on web)
https://github.com/user-attachments/assets/ce8d4de4-0082-4556-8553-96dd18a3d74d
—
Reply to this email directly, view it on GitHub
https://github.com/Fallenbagel/jellyseerr/issues/1095#issuecomment-2520340413,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIEQ6IMI6UMAU2SDNFF6RUD2EBI3PAVCNFSM6AAAAABRWECJISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRQGM2DANBRGM
.
You are receiving this because you commented.Message ID:
@.***>

I don't think you can do this change with Portainer, or at least I don't know how to.

You can. Even if you use docker volumes you can just mount that volume into another container like running debian image or alpine image and then just access the shell and delete settings.json or edit it.

Ah I see, thanks for the tip!


Enable omnibus build cache

What does this PR do?
This PR enables omnibus git cache, in order to stop rebuilding all of our dependencies during each CI job.
All packages before the agent are expected to rarely change, and shouldn't have to be rebuilt every single time.
On average, this saves about 15/20 minutes per job.
This also allows individual developers to skip rebuilding every single dependencies if they wish to add a new software dependency to the agent. All they need to do is to provide the OMNIBUS_GIT_CACHE_DIR environment variable to a directory of their choosing.

Motivation
This is part of the currently running initiative to reduce the median pipeline duration under 2 hours. This specific investigation is listed under https://datadoghq.atlassian.net/browse/APL-1805
Associated RFC: https://docs.google.com/document/d/1PSGpd2ixXXMbfzC1j0o514SXypcDiVamxBL3db__Bt0/edit?usp=sharing

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge

/merge

/merge

/merge -c

/merge


Spinner process occasionally prints after cleanup

This only occurs in Julia 1.5, which is unsupported. Project.toml already specified Julia 1.6 or higher.
6a1bde3a92f61c395dd8b0035be80f4858cc5ef1

The main process now waits for the spinner process to terminate before cleaning up.


Support filtering DOM nodes that will be processed in href()

Often it is useful to filter the set of links that will be processed by the router. One common case for this is if you are linking to content inside the same domain that is not a part of your application.
This PR implements an optional filtering function that can be given to href() as a parameter. The function receives a DOM node and the truthiness of it's return value will be used to determine whether to call cb and save the url to history using pushState or not.
This also addresses issue 15.

Hmm, I quite like the idea behind this - but think it would lag one step behind the solution proposed in #15 - namely that we can be smart about how / when links should be handled.

Sensible defaults, and ideas suggested in the issue, are definitely good, but sometimes finer control is needed. The need for bypassing processing of links can also be very specific to the app and environment in question, so IMO it is good to provide users the power to choose what gets left out in addition to providing good defaults.

Hmm, I'd solve that by being explicit in the links themselves and setting a property similar to:

  my cool link

Feel that if we expose more API surface here, instead of dealing with the problem in the router we're instead pushing it onto users of this project - which is not quite solving it.

Exposing a DOM node that's a candidate for routing is not that bad in my opinion, since traversing the DOM etc. is done for the user of the library, but I get your point.
A predefined bypass attribute like data-router="false" would also solve the issue in my case, though it would give less control to other users. Then again you can always write your own href implementation if needed. If this approach is preferred, I can change the PR accordingly.
I'd prefer if the attribute would be false by default (so it being absent would mean that it is not active), so we could use boolean attributes and have a name that would be unlikely to clash with other libraries. What do you think? How about data-sheet-no-routing?

Sounds reasonable, curious to hear other people's opinions on this. Think I'd go for a shorter atrribute though, as 4 words is a bit long. Perhaps:
my cool link

This wouldn't work in yo-yo / choo straight away tho:

https://github.com/substack/hyperx/issues/14
https://github.com/shama/bel/issues/28

So initially it should be written as:
my cool link

You reckon that sounds reasonable? A PR for that would def be appreciated.

Okay. We'll have to keep data--prefix though to be valid HTML 5. Sure, let's do this in its own PR.


Optimise polynomial evaluation

Copying an idea of @asn-d6's from chat:

you can avoid a needless non-batched bls_modular_inverse in evaluate_polynomial_in_evaluation_form() by computing and caching inverse_width at boot time. then you wouldn't need:
fr_from_uint64(&tmp, FIELD_ELEMENTS_PER_BLOB);
fr_div(out, out, &tmp);
and you could replace it with a multiplication by inverse_width instead

Closing this given the tiny benefit. Let's revisit if we need to hyperoptimize the barycentric.

I guess it seems like I don't have the powers to close this :D


Manylinux wheel doesn't support full screen

Fullscreen on Ubuntu installed using manylinux wheel (from nightly) doesn't seem to work.
When setting fullscreen, the graphics drivers (nvidia) went crazy and didn't actually show anything. The monitor seemed to cycle between inputs and then stopped showing the desktop afterwards until I restarted. When I then installed kivy from source, everything worked as expected.

Do people really use native fullscreen though, i don't think anybody should, but on the other hand, we do support it, so it's indeed bad that it reacts this way. I could get out of the weird mode by using xrandr to reset my output to its normal mode (xrandr --output eDP1 --mode 1920x1080 for me) but it's not easy to do that while only seeing a very small part of your screen.

Why shouldn't you use native fullscreen? My app is running a projector that needs to project full screen.

borderless + screen size window is a lot less intrusive, basically what "auto" or "fake" does, whether you do it manually or not, it avoids changing screen mode just to start your app, and changing again if you switch focus to another app temporarily. It also plays a lot better with multiple screens.

I tried borderless + screen size on ubuntu and it's not actually the same as real fullscreen. The former doesn't cover e.g. the application bar. Is that a know thing?

Is there any advance in this issue ? I also the met the problem of cannot switch to fullscreen mode in Ubuntu 18.04, but the code code run correctly in MacOS.   How can I solve this problem, does anybody could help ?  Thanks a lot !

Facing the same issue on Ubuntu 20.10. As @matham stated already, with just borderless + screen-size I can't cover the status/application bar, which is quite important for my use-case, too.

The workaround to this is to install kivy from source.

so would this come from the version of libsdl we build against in manylinux wheels? or the way it is built?

We distribute sdl2 in our wheel so we don't rely on libsdl. So either we don't build it correctly, we're missing some component, or building sdl2 on one system and using on another doesn't work well enough, despite manylinux taking extra care to only build against very core system binaries.
This is very similar to https://github.com/kivy/kivy/issues/6536 I bet.

I initially faced this on Ubuntu 18, but I had the same issue on 20, recently.

yes, i was also wondering if it was the same kind of issue as with the mixer… it might be that sdl2 doesn't work properly when moved across systems…
I'm on ubuntu 20.04, i'll try "true" fullscreen later, i usually don't need it because there is no overlay in my window manager (i3), i tend to forget about the specifics of unity.
I can confirm that true fullscreen is problematic on my current machine with ubuntu, when installed from wheels.

And I can confirm, that the issue is fixed when installing from source. Would be great to have the wheels fixed. :-)

@matham do you still have this hardware with nvidia graphics?
Seems that the 2.2.0rc1 wheel is not affected anymore (now we use a self-built version of sdl, with KMSDRM)
See: https://github.com/kivy/kivy/issues/7845#issuecomment-1544499427

It is indeed fixed in the latest wheel!


Fix Scrollspy to work with all valid HTML5 element ids

Fixes #34381 by using document.getElementById() instead of document.querySelector() when testing the validity of an element ID.
Whereas document.querySelector() only allows valid CSS selectors and requires ID-based selectors to start with a letter, document.getElementById() handles all valid HTML5 element IDs.

@XhmikosR @GeoSot Any update on this? What more needs to be done to get this merged?


Cannot install

Hello the error code I am getting is :
Command "/usr/bin/python -c "import setuptools, tokenize;__file__='/private/tmp/pip-build-       PG4g5k/kivy/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'),      __file__, 'exec'))" install --record /tmp/pip-K9ESpR-record/install-record.txt --single-version-externally-    managed --compile" failed with error code 1 in /private/tmp/pip-build-PG4g5k/kivy```

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/12320642-cannot-install?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github).

Same here.
clang: error: no such file or directory: '/private/tmp/pip-build-O7Lk_7/kivy/kivy/core/camera/camera_avfoundation_implem.m'
clang: error: no input files
 error: command 'cc' failed with exit status 1

Same error here on OS X Yosemite. Tried both with built-in python and brew's python.

AVFoundation has never worked properly w/ MacOSX.  Either you can get the MacOSX installer from the kivy website that is provided in a .dmg or if you are trying to build, do the following.  I believe the last time they pushed out the latest version MacOSX was at platform 10, 7 ? Date looks about right...
This is what I did to build from source -- (Do the obvious & make sure xcode is at latest, etc..)
1:)  git clone http://github.com/kivy/kivy
2:)  cd kivy
3:) vi setup.py
4:) :712  (go to line 712) and you will see this
if mac_ver >= [10, 7]:
Comment out this line w/ a #
and set to 1 platform version higher so change the [10, 7] to [10, 11] if on yosemite.
To determine your mac_ver use the above line in a simple python script:
import platform as _platform
mac_ver = [int(x) for x in _platform.mac_ver()[0].split('.')[:2]]
print mac_ver
What ever is returned go up a level and update the setup.py to that or make sure that 'use_avfoundation' returns  false/0
5:) make
6:) if no further errors make install
Fixed... I am doing more investigation around avfoundation and seeing if I can fix what is broken.  If I can I will come back and let you all know..
End result:
running install_egg_info
Writing /Library/Python/2.7/site-packages/Kivy-1.9.1_dev-py2.7.egg-info

From what I read from the header files in:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/ApplicationServices.framework/Frameworks/QD.framework/Headers
ColorSyncDeprecated.h shows that this functionality has been deprecated since 10.6, I think in setup.py this is a bug and the eval should be:
if mac_ver < [10, 7]:
Other wise you would need to use the new API to accomplish these tasks and the only documentation of this functionality that I could find was in the actual header files themselves.  I think this is a bug for the kivy team. I will open a bug and see what they say.

@SuperFoodIQ thanks! I was lucky to get this error few hours after you posted the fix, saved me some time. However, even after installing pillow and pygame I failed to get the example from the homepage to work on osx+py3.5.

There are some bugs still w/ python3 from what I understand after reading some reddit posts.  I really want to change the kivy file format to native JSON. It would be really nice if you could generate the kivy customization files accurately...  In my case I want to be able to customize my UI and build custom screens for clients so the requirements would change and using say a jenkins job to generate the UI would be really slick. Don't get me wrong it is possible in the current kivy format but, it would be nice if this was based on a standard and you could have some kind of validation via templates.
The whole avfoundation is b0rked after 10.6 as I stated.  I updated the bug on the kivy bugtracker and pointed them in the right direction.
If you are still getting this error let me know and I can dig further if you need assistance.

This is a duplicate of https://github.com/kivy/kivy/issues/3320 which has been fixed by https://github.com/kivy/kivy/commit/e56d44feeac37ed9f433afe5c59b0fa938f33216
The fix has not been released to pypi yet (https://github.com/kivy/kivy/issues/3717) so you have to install with
pip install<EMAIL_ADDRESS>
or if using homebrew with
USE_OSX_FRAMEWORKS=0 pip install<EMAIL_ADDRESS>

Python3 is not supported as of yet... Please read the requirements
carefully and do not just assume that py3 is supported!
I know there is extensive development around the py3 platform..
-luke
On Thu, May 28, 2015 at 3:23 AM, Andrei Fokau<EMAIL_ADDRESS>wrote:

@SuperFoodIQ https://github.com/SuperFoodIQ thanks! I was lucky to get
this error few hours after you posted the fix, saved me some time. However,
even after installing pillow and pygame I failed to get the example from
the homepage to work on osx+py3.5.
—
Reply to this email directly or view it on GitHub
https://github.com/kivy/kivy/issues/3309#issuecomment-106228145.


ContextState: Attempt to fix cross app domain issues on teamcity

Sorry for the downside of #6492.

No worries mate. I'll pull it in since the tests are broken anyway, but could you maybe explain a bit why this may work?

Not sure at all but someone already solved in Orchard the same kind of issue around the cross app domain lifetime. If i remember correctly it was in the context of the command line (so with cross app calls) and for all the objects that inherit from MarshalByRefObject. And the DefaultOrchardHost uses the ContextState (for _tenantsToRestart) during all the app life... But again not sure at all.

Ok. Well, we'll see how it goes.

Ok, thanks to be patient.
I'm not married with Logical CallContext ;)
But if we get rid of it, i would like to understand why...

@sebastienros, @sfmskywalker
So, because i can now repro exactly the same failing tests on my local, i could work on it and i found how to fix it (see below). But i don't want to disturb the Orchard timeline. Indeed, the easiest way is to revert my 2 last PRs and maybe do a last one to only use the new IsBackgroundHttpContext() extension.
Otherwise, if you think it's worth to give it a last try, i can do easily a last PR and here my last findings. But you know maybe other little drawbacks on the dev branch... That said, i could run all unit tests and specflows. Only 4 tests in Orchard.Profile failed but it was the same before my updates.
1st issue
In a Cross AppDomain context during specflows, the first kind of issue was that an object retrieved from the Logical CallContext can be a transparent proxy not related to a local instance. The fix was to add this check:
var data = handle != null && !RemotingServices.IsTransparentProxy(handle) ? handle.Unwrap() : null;
2nd issue
Based on the exception message it was related to an assembly that failed to load. The fix was to replace the following in Orchard.Resources/web.config. And i've done the same in Orchard.Conditions/web.config because there are the only 2 web.config files where PublicKeyToken=null for these asemblies.
            <add assembly="Orchard.Framework, Culture=neutral, PublicKeyToken=null" />
            <add assembly="Orchard.Core, Culture=neutral, PublicKeyToken=null" />

With:
            <add assembly="Orchard.Framework" />
            <add assembly="Orchard.Core" />

So, let me know, i can easily revert the updates and only use the new extension, or try the above one last time. Anyway, i again learned a lot with this.
Best

Well, if this fixes the unit tests and works on both Setup from IIS as well as Orchard.exe, I think we should give it a go. Perhaps you could add some of the green stuff explaining the reasoning (in a nutshell)?

Apply the fix

Ok, i'll re-fetch the last source and re-run all tests. Then i'll do the PR.


[FEATURE-REQUEST] Create custom link

It would be great to have the ability to create a custom link in the menu.
For instance if you want a link that point to Phoenix LiveDashboard, or an API Swagger UI.

This is done in master and explained in README.


[HxGrid] sorting on IQueryable

Hello,
i use your hxgrid. And i processing data on seperate service. I do pagination, filtering and sorting. I want use your implementation of sorting because i want do it in my service. In your component is this:
			#region Sorting
			if ((Sorting != null) && Sorting.Any())
			{
				Contract.Assert(Sorting.All(item => item.SortKeySelector != null), "All sorting items must have set SortKeySelector property.");

				IOrderedEnumerable<TItem> orderedData = (Sorting[0].SortDirection == SortDirection.Ascending)
					? resultData.OrderBy(Sorting[0].SortKeySelector.Compile())
					: resultData.OrderByDescending(Sorting[0].SortKeySelector.Compile());

				for (int i = 1; i < Sorting.Count; i++)
				{
					orderedData = (Sorting[i].SortDirection == SortDirection.Ascending)
						? orderedData.ThenBy(Sorting[i].SortKeySelector.Compile())
						: orderedData.ThenByDescending(Sorting[i].SortKeySelector.Compile());
				}
				resultData = orderedData;
			}
			#endregion

But this is working only for IEnumerable. I would like have sorting on iquryable, because filtering and pagination i have. I try your implementation and it doesn't work on IQuryable. I try my custom implementation and it works for only string columns. It doesn't work for int... Do you have any help? Thanks
       if (sortingItems != null)
          {
              foreach (var sortingItem in sortingItems)
              {
                  if (sortingItem.SortDirection == Havit.Collections.SortDirection.Descending)
                      source = source.OrderByDescending(sortingItem.SortKeySelector);
                  else
                      source = source.OrderBy(sortingItem.SortKeySelector);
              }
          }

          return source;

Do you think you'll ever add support to IQueryable? Thank you very much :)

Duplicate with #66

Hello, i understand the second part and why isn't good use quryable in frontend. I use dbcontextfactory so It still wouldn't work for me. I should have thought more. But here is still first question maybe more like advice. Do you have implementation of sorting for iquryable in backend? Thank you

we have some helpers but most of the time we code it manually
We use Havit.Collections.SortItem[] as Data Transfer Object (DTO) between client and the server. The column is represented with string there + we use nameof(...) for better maintainability.
On client-side you map the sorting request to DTO:
Sorting = request.Sorting.Select(s => new SortItem(s.SortString, s.SortDirection)).ToArray()

...server-side sorting of IQueryable (OrderBy() and OrderByMultiple() are extension methods from Havit.Linq.QueryableExt):
		if (Sorting is not null)
		{
			queryable = queryable.OrderByMultiple(Sorting, sortingExpression => sortingExpression switch
			{
				nameof(ClientCardSort.LastName) => new() { cc => cc.LastName, cc => cc.CompanyName },
				nameof(ClientCardSort.City) => new() { cc => cc.Address.City },
				nameof(ClientCardSort.LegalType) => new() { cc => cc.LegalType },
				nameof(ClientCardSort.BirthNumber) => new() { cc => cc.BirthNumber, cc => cc.CompanyNumber },
				nameof(ClientCardSort.Rating) => new() { cc => cc.Rating },
				nameof(ClientCardSort.CardValidity) => new() { cc => cc.Validity },
				nameof(ClientCardSort.LastActivity) => new() { cc => cc.LastModified, cc => cc.LastBtClientCardEventTimestamp },
				nameof(ClientCardSort.BtCreated) => new() { cc => cc.BtCreated },
				_ => throw new InvalidOperationException($"Unknown SortingItem.Expression {sortingExpression}.")
			});
		}
		else
		{
			// default sorting
			queryable= queryable.OrderByDescending(cc => cc.LastModified).ThenByDescending(cc => cc.LastBtClientCardEventTimestamp);
		}

(the OrderBy() version where you don't have sortings by several columns is simpler, you just return the lambda of the property to use for sorting).

Closing as duplicate.


Contributors

Properly attribute each issue / PR which is part of a release.
Resolves #89

@gep13 please review at your convenience but do not merge yet. I just rebased your recent changes and I am now investigating how to implement my new feature in GitLat.

I solved all the remaining issues. This logic is compatible with multiple issues/PRs being associated with a given issue/PRs and also  the GetLinkedIssues method has been implemented for GitLab.

@Jericho please accept my apologies for the radio silence on this PR! Simply put, I haven't had any time to even think about looking at this.  I am hoping to review this in the coming days, and will provide some feedback (if there is any).
Thanks again for your help with this!

No apologies necessary. I'm just glad to be contributing.

@Jericho apologies again! I haven't had a chance to look at this yet, and looks like I am going to have to do an immediate release to fix the issue with creating releases as a result of a required change upstream to Octokit.

Rebased to pull in yesterday's commits.

@Jericho is there something "special" that has to be done to get the generated release notes to contain the contributors?
The reason that I ask is that we have an upcoming release of Chocolatey CLI, and I thought I would take this for a spin to see it in action, however, I am not seeing anything other than the normal output in the generated release notes.  I can see that in code, the contributors for the issues are populated in the GetContributors call, but the template changes don't seem to be taking effect.

If you are referencing my beta package #tool nuget:https://f.feedz.io/jericho/jericho/nuget/?package=GitReleaseManager&version=0.17.0-collaborators0003, nothing special that you need to do. The result will be release notes similar to the notes on this project: https://github.com/Jericho/StrongGrid/releases (please note, I started using my beta package in late December 2023 if I remember correctly, so only consider releases since January 2024).
If you are running GRM from source in Visual Studio, make sure you "rebuild" the whole project. It seems that changes to templates are not effective until you rebuild. This issue has caused my grief on several occasions where I thought modified the template but my changes were no reflected in the resulting release notes. I don't know who's to blame for this issue. Is it a Visual Studio problem? Git problem? I don't know why changes are not picked up automatically. Anyway, long story short: make sure you rebuild the project and you should be good to go.

Thank you for the hint, although that doesn't seem to have helped.
I am trying this out of Visual Studio.
I went as far as closing Visual Studio, manually deleting the bin and obj folders in each project folder, then re-opening the solution, and running the GitReleaseManager.Tool project.
The contributors are still not being added into the generated release notes.

Just tried using the GitReleaseManager.Cli as the startup project, and it is having the same result.

And while we're on the topic of templates, double-check the presence of contributors.sbn and contributor-details.sbn in the src\GitReleaseManager.Core\Templates\default folder.

While I do make use of custom templates on some projects, I can confirm that none are in play when testing this PR.  I can confirm this here:

Where the default file path, i.e. the embedded resource, is being used.
Yes, I can confirm that the index.sbn is the same as your screenshot.
And yes, I can also confirm that the two contributor sbn files are in that folder.

Doh! I have figured it out...
I suddenly remembered about the .tt file!

You have to right click on that, and then click Run Custom Tool to have it generate the .cs file, which is then embedded into the assembly.
I don't know exactly when this is run as part of the normal build process, but it might also explain why you found you had to clean the files in order to get things to work properly.
@AdmiringWorm might be able to provide some insight into when this part of the tooling works.  Thinking about it, I "think" it runs as part of the Cake build, but I thought it ran inside Visual Studio as well.
Now that I have this working, I should be able to take this for a proper trial.

@AdmiringWorm might be able to provide some insight into when this part of the tooling works. Thinking about it, I "think" it runs as part of the Cake build, but I thought it ran inside Visual Studio as well.

It is indeed run as part of the Cake build, it is a separate task called Transform-TextTemplates. Do note that it is not the same as when running it through Visual Studio (not sure why, but the support in VS seems to become worse and worse for TT templates), but it should be close enough.

@Jericho :wave: apologies again for not coming back to you sooner about this one! I would try to give an excuse, but I really don't have one, so, moving on...
A couple of questions/observations...

What are your thoughts about adding an IncludeContributors property to the CreateConfig class, to allow control over whether or not to include Contributors within the release notes?  As it stands, Contributors are always included, and a user would need to edit the default template if they didn't want to include that information.  Having this be controllable via the configuration file would seem like a natural way to do things, and would be inline with other configuration options that already exists.
When running the SingleMilestone test (without making any changes to the code) I noticed something interesting. In the rendered markdown, there is this Improvement

Issue 113 was indeed raised by Geoffrey, however, there is a linked Pull Request that was raised by me.  Shouldn't the description for this issue include the information about the link to the PR?

The default template is becoming quite "busy", with lots of different options and switches that can be pulled.  Do you think it would make sense to include another template by default, which would specifically be used when including Contributors?  That way, the Default template can remain slightly smaller, and less involved.

Instantiating the GraphQLHttpClient here doesn't seem right. This client should probably be injected in the constructor or maybe, rather than mixing the REST GitHub client with the graph QL client in the same provider, there should be a separate provider specifically for graphQL operations.

I haven't really got a strong opinion either way.  If we go down the route of using a Configuration value to include/exclude the Contributor information, then we could control when this is instantiated? Or, as you say, perhaps split this out into a separate provider.  That might make things a little more complicated in the long run though.

I haven't tested this yet against a GitLab repository, as I would need to set one up for testing this out. Things seem a little simpler to do via the GitLab client though, as it doesn't involve GraphQL.

Again.. I am loving this PR, and the functionality that this provides! Thank you so much for putting the work in so far to get this to where it is!

Regarding GitLab, I have just tested it on a repository that has an issue with a linked MR, but the generated release notes doesn't mention the associated MR.  The LinkedIssues property is empty on the issue.  Did you have to do anything "special" within GitLab to make an issue link through to an MR?

Related to the above, if I use this:

I can get the associated MR for the issue in question, so that makes me wonder if I haven't done something between the issue and the MR in GitLab to link them in the correct way.

What are your thoughts about adding an IncludeContributors property to the CreateConfig class, to allow control over whether or not to include Contributors within the release notes?

Sure, no problem. I can add a Boolean property to the CreateConfig class to allow developers to indicate whether they want contributors to be included in the release notes or not.

When running the SingleMilestone test (without making any changes to the code) I noticed something interesting. In the rendered markdown, there is this Improvement Issue 113 was indeed raised by Geoffrey, however, there is a linked Pull Request that was raised by me. Shouldn't the description for this issue include the information about the link to the PR?

Please make yourself comfortable, answering this seemingly simple question might take a while. Here goes my attempt to explain, based on my (potentially flawed) understanding.
GitHub's API does not have a way to retrieve the list of issues/PRs linked to a given issue. The only workaround I was able to find is to use GitHub's graphql API. But even this API does not allow you to easily retrieve the linked issues/PRs. You have to retrieve so called "timeline events" of specific types (in our case we want "connected" and "disconnected"), sort them in chronological order and then we can derive which issues and PRs have been "connected" to the desired issue without having been disconnected. Here's a fictitious example: let's say you link a PR with the issue, realize you made a mistake and unlink this PR and finally you correct your mistake by linking another PR. In this fictitious scenario, the graphQL API would return the following timeline items:

first item: issue 111 connected to PR 222
second item: issue 111 disconnected from PR 222
third item: issue 111 connected to PR 333

In this example, you can see that PR 222 is initially associated to the desired issue but subsequently unlinked. and finally, PR 333 is linked and it's not unlinked. Based on these timeline events we can conclude that PR 333 is the one PR associated to the desired issue. I hope you're following me so far. FYI: this logic is similar to what is described in this StackOverflow comment.
ok, so now that we have the theory out of the way, let's try to investigate specifically what is going on with issue 113 in the GitReleaseManager repo. Here's the tool I use to debug the graphql query and here's the query that you can copy and paste in this tool:
{
  repository(name: "GitReleaseManager", owner: "GitTools") {
    issue(number: 113) {
      timelineItems(first: 50, itemTypes: [CONNECTED_EVENT, DISCONNECTED_EVENT]) {
        nodes {
          __typename
          ... on ConnectedEvent {
            createdAt
            id
            source {
              __typename
              ... on Issue {
                number
              }
              ... on PullRequest {
                number
              }
            }
            subject {
              __typename
              ... on Issue {
                number
              }
              ... on PullRequest {
                number
              }
            }
          }
          ... on DisconnectedEvent {
            createdAt
            id
            source {
              __typename
              ... on Issue {
                number
              }
              ... on PullRequest {
                number
                author {
                  avatarUrl
                  resourcePath
                }
              }
            }
            subject {
              __typename
              ... on Issue {
                number
              }
              ... on PullRequest {
                number
              }
            }
          }
        }
      }
    }
  }
}

After you click the "Run" button, you will see this result:

As you can see in the result, there are no timeline events!!!! Not a single one!!!! Allow me to repeat what I just said, for dramatic effect: not a single one! In other words: GitHub is telling us that this issue was never connected to any other issue or PR. This does not make sense. You and I know that the issue is indeed linked to a PR, therefore we expect at the very least one "connect" timeline event. But the reality is that the API returns zero records.
The ultimate question is: why is GitHub's graphQL Api returning data that seems incorrect or incomplete. I do not know with certainty the answer to this question but I have a theory (emphasis on "theory"): if you go back the the graphQL query that I presented earlier and that you copied/pasted into the GraphQL explorer, you'll notice that I added a "filter" when querying timeline items, like so: timelineItems(first: 50, itemTypes: [CONNECTED_EVENT, DISCONNECTED_EVENT]) {. The filter indicated that I am interested in "connected" and "disconnected" events because, as previously explained, these are the types of events that signify that a given issue/PR was linked/unlinked to the desired issue. My theory is that the issue and PR were associated in a way to generated a different type of event. What type of event you might ask? I have no idea. But if my theory is correct, it would explain why our graphQL query returns zero timeline event.
Anyway, I'm sure I have bored you to death with all this information. The TL;DR is that I suspect there's another type of event that in some scenarios, such as the one for issue number 113, represents the association of two records. I have no clue what if this theory is true and if it is, what would be the type of event in question. I have been using a beta copy of GRM to generate my release notes for at least 6 months and never noticed this problem. So I'm wondering if this issue you found is an edge case or if it's common.

The default template is becoming quite "busy", with lots of different options and switches that can be pulled.  Do you think it would make sense to include another template by default, which would specifically be used when including Contributors?  That way, the Default template can remain slightly smaller, and less involved.

In other words, leave index.sbn alone and create a new index-with-contributors.sbn? Sure, no problem.

Or, as you say, perhaps split this out into a separate provider. That might make things a little more complicated in the long run though.

Separating it in a distinct provider would have been my preferred method but GitLab doesn't have this concept of a GraphQL client. So I was at a loss to design a way that works for both Git environments.

I haven't tested this yet against a GitLab repository, as I would need to set one up for testing this out. Things seem a little simpler to do via the GitLab client though, as it doesn't involve GraphQL.

Yes indeed, much much much simpler.

Related to the above, if I use this:

I can get the associated MR for the issue in question, so that makes me wonder if I haven't done something between the issue and the MR in GitLab to link them in the correct way.

My code for GitLab retrieves the issues/PRs that close a particular issue when merged. The line of code you added in your code snippet retrieves issues/PRs that are merely "related" and don't necessarily close the desired issue. That's a very subtle nuance I must admit, but as your scenario demonstrates quite important. I will change my logic to match your code snippet.

@Jericho said...
Sure, no problem. I can add a Boolean property to the CreateConfig class to allow developers to indicate whether they want contributors to be included in the release notes or not.

Woot! 😄

@Jericho said...
In other words, leave index.sbn alone and create a new index-with-contributors.sbn? Sure, no problem.

No, this wasn't exactly what I was referring to.  Rather here at this location:
https://github.com/GitTools/GitReleaseManager/tree/develop/src/GitReleaseManager.Core/Templates
We create a new folder, perhaps named contributors or something similar, and we place all the required files to generate the release notes, including the contributors in there.  That way, we keep things completely separate.  Then, within the code, when the new configuration value is in play, we use this named template, rather than the default one.
Does that make sense?  This idea came from @AdmiringWorm, so if I haven't made this clear, perhaps he can help to elaborate.

@Jericho said...
Separating it in a distinct provider would have been my preferred method but GitLab doesn't have this concept of a GraphQL client. So I was at a loss to design a way that works for both Git environments.

Hmm, that is a fair point.
What about adding an overload to the GitHubProvider, to pass in an instance of the GraphQL Client, and then in the Program.cs, based on when the contributors config value has been set, either call the new constructor with an instance of the client, or call the other one?  That way, it is only created when needed.  Just an idea, haven't dug into this too much, so I could be missing something here.

@Jericho said...
My code for GitLab retrieves the issues/PRs that close a particular issue when merged. The line of code you added in your code snippet retrieves issues/PRs that are merely "related" and don't necessarily close the desired issue. That's a very subtle nuance but, as your scenario demonstrates, quite an important one. I will change my logic to match your code snippet.

Just to level set here... Do you have an example of a GitLab issue/PR pair that works with the current code that you have in place?  How exactly did you create the association between the two?  The repository I was using for testing isn't public, so I can't share, but within the issue body, there is this section:

Do you have that in the issue that you have created?  Or do you have another section?  If so, I would be curious to know how you have associated the two together, as I could be doing something wrong.

Changes since last review:

Added a configuration option so users can specify whether they want contributors to be included in the release notes
Created a separate template which is used when the config option is set to true
Enhanced the GraphQL query to reduce the number of queries to fetch all necessary info about all the linked issues/PRs
Injectable GraphQL client

Ready for another review


"0 reads mapped" in sample where CellRanger maps 66M reads / 9915 cells

Hi @rob-p and team
We have a very strange issue with piscem... (Called by simpleaf but piscem seemed like the natural place for this issue.)
The sample mapped fine with CellRanger, as noted in the title, but piscem mapped 0 reads.
Here is the contents of the map_info.json file:
{
    "cmdline": "sc_ref_mapper -i /projects/site/pred/neurogenomics/resources/scprocess_data/data/alevin_fry_home/human_2020-A_splici/index/piscem_idx -g chromium_v3 -1 /projects/site/pred/neurogenomics/users/macnairw/Macnair_2022/data/fastqs/zero_mapping_POOL1_S3_L001_R1_001.fastq.gz,/projects/site/pred/neurogenomics/users/macnairw/Macnair_2022/data/fastqs/zero_mapping_POOL1_S3_L002_R1_001.fastq.gz -2 /projects/site/pred/neurogenomics/users/macnairw/Macnair_2022/data/fastqs/zero_mapping_POOL1_S3_L001_R2_001.fastq.gz,/projects/site/pred/neurogenomics/users/macnairw/Macnair_2022/data/fastqs/zero_mapping_POOL1_S3_L002_R2_001.fastq.gz -t 16 -o /projects/site/pred/neurogenomics/users/macnairw/Macnair_2022/output/ms01_alevin_fry/af_zero_mapping/af_map",
    "num_mapped": 0,
    "num_reads": 284823970,
    "percent_mapped": 0.0,
    "runtime_seconds": 235.0
}

It's a strange one...! Any ideas what could be going on?
I've shared a folder ("zero_mapping") with you, with the relevant files. Let me know if you need anything else.
Best
Will

Hi @wmacnair,
Ok, so this seems like another strange one.  I grabbed the first pair of files:
zero_mapping_POOL1_S3_L001_R1_001.fastq.gz
zero_mapping_POOL1_S3_L001_R2_001.fastq.gz

and tried to map them with piscem using the same index from the previous simpleaf issue.  In that pair of files, out of 142756504 reads it mapped 126833786.
The map_info.json shows:
{
    "cmdline": "sc_ref_mapper -i ../simpleaf_issue_99/piscem_index/index/piscem_idx -g chromium_v3 -1 zero_mapping_POOL1_S3_L001_R1_001.fastq.gz -2 zero_mapping_POOL1_S3_L001_R2_001.fastq.gz -t 16 -o mapping_res",
    "num_mapped": 126833786,
    "num_reads": 142756504,
    "percent_mapped": 88.8462398883066,
    "runtime_seconds": 416.0
}

Do you see any obvious differences between our commands, apart from me only using the first pair of files?
--Rob

Hmm, nothing obvious to me... These are the two cmdline entries, with extraneous paths deleted:
# me:
sc_ref_mapper -i .../piscem_idx -g chromium_v3 \
  -1 zero_mapping_POOL1_S3_L001_R1_001.fastq.gz,zero_mapping_POOL1_S3_L002_R1_001.fastq.gz \
  -2 zero_mapping_POOL1_S3_L001_R2_001.fastq.gz,zero_mapping_POOL1_S3_L002_R2_001.fastq.gz \
  -t 16 -o /af_zero_mapping/af_map

# robp
sc_ref_mapper -i .../piscem_idx -g chromium_v3 \
  -1 zero_mapping_POOL1_S3_L001_R1_001.fastq.gz \
  -2 zero_mapping_POOL1_S3_L001_R2_001.fastq.gz \
  -t 16 -o mapping_res

Tagging @marusakod as she has had exactly the same issue, and will be more able to help today and Monday.
Will

Weird, I've tried running both with both, with just L001, and with just L002 and get 0 reads mapped each time.
What are your first thoughts on what could be wrong?
Will

Ah interesting, thanks! Very strange that this one sample in the study is v2 while the others are v3...
It also makes me slightly concerned about whether we have the right chemistry for the other samples in the study. Do you have any suggestions for how to check this?
I guess we would call this user error rather than a bug, but could it be helpful to add a suggestion to the error message? e.g. when 0 reads are mapped, suggest rerunning with an alternative chemistry?
Thanks as ever for the speedy response!
Will

Hi @wmacnair,
Of course; no worries!  We can certainly add some diagnostics and warnings and will do that for the next release.  It's easier (and safer) from our end than adding full auto-detection.
The easiest way for you to check is just to look at the reads in the R1 file. The v2 chemisty uses a 16bp barcode and a 10bp UMI, while v3 uses a 16bp barcode and a 12bp UMI. While it's not strictly required that content after the barcode and umi are not sequenced, in most samples this simply implies that a v2 file will have a 26bp read 1 and v3 files will have a 28bp read 1.  This is one quick check for the chemistry.
Best,
Rob

Hi @rob-p
It turns out that this issue was a bit stranger than we originally thought...
Apparently this sequencing run included samples from two different kits:

10x single cell 5' kit v1.1
10x single cell 3' v3
To allow both to be sequenced together, the read lengths were chosen such that both should work. This ended up being 26 nt for R1 (16 nt for 10x barcode, 10 nt for UMI), and 90 nt for R2.

I was thinking that this wouldn't work with simpleaf, but then I just discovered this piece of documentation:
a-note-on-the-chemistry-flag :D
Previously, just hacking around, we got something that seemed to work by using v2 chemistry, but with the v3 barcode whitelist. I'm now thinking that that is exactly the right thing to do, because the chemistry in v2 is "1{b[16]u[10]x:}2{r:}", which is exactly what we need.
I think that's the case, but it would be great if you could confirm!
Best
Will

This is .... a very strange sample. So they mixed a sequencing run with data from 2 separate technologies?
So, among the available options (at least the ones that don't involve trying to split/de-multiplex the reads before quantification), the geometry you suggest seems right. The 5' kit v1.1 has 10bp UMI as you say, so you need to use the shorter geometry specification for it.
Of course, this means that you'll lose the last 2bp of the UMI information from the v3 chemistry.  This is unavoidable, as it wasn't sequenced - so that's not a simpleaf problem, but a general one.
I couldn't immediately find information about the 5' v1.1 kit "whitelist".  Assuming it uses the same barcodes as v3, then this approach seems to make total sense.  I'll be interested to see what you get from the sample, of course ;P.
Best,
Rob

Yes it is very strange, and it would have saved quite a bit of confusion if they had just split into two runs... 🙄
@marusakod found this description of which barcode lists are used in which kits:

(One minor clarification - we're only looking at the 3' v3 samples, so I don't think we need to be concerned with demultiplexing.)
One comment here - for all that CellRanger is muuuuch much slower and handles spliced / unspliced worse etc, it is actually pretty good at guessing what the right chemistry is for a given sample. I think it has guessed right for all of the unusual samples we've seen, including these. More broadly, CellRanger handles "unusual" sample configurations well (e.g. multiplexed, multiome with ATACseq), while these take a bit more effort and knowledge with simpleaf.
As a user, it would be great if this is some functionality that could be added to simpleaf at some point. I'm sure it's on your list, but here's another +1 in favour 😄.
Best, and thanks again
Will


Current period

An api for the current period in the day would be nice! :)

This is not an issue, but merely a suggestion, and will not be considered. If you would like to add a feature, you can do it yourself by making a pull request.


[web] FormatException: Unexpected end of input (at character 1)

flutter channel beta
flutter upgrade
flutter config --enable-web
flutter create step
cd step
flutter run -d chrome
chrome has opened, and close Immediately, terminal show this log:
Launching lib/main.dart on Chrome in debug mode...
Syncing files to device Chrome...
13,022ms (!)
Unable to connect to Chrome debug port: 51629
 FormatException: Unexpected end of input (at character 1)

^

[✓] Flutter (Channel beta, v1.17.0, on Mac OS X 10.14.4 18E226, locale en-CN)
    • Flutter version 1.17.0 at /Users/bangben_home/development/flutter_remote
    • Framework revision d3ed9ec945 (4 days ago), 2020-04-06 14:07:34 -0700
    • Engine revision c9506cb8e9
    • Dart version 2.8.0 (build 2.8.0-dev.18.0 eea9717938)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/bangben_home/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS (Xcode 11.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3.1, Build version 11C504
    ! CocoaPods 1.7.5 out of date (1.8.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin
        usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade:
        sudo gem install cocoapods

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 43.0.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.43.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.1

[!] Proxy Configuration
    • HTTP_PROXY is set
    ! NO_PROXY is not set

[✓] Connected device (4 available)
    • GM1900     • 207b81be                             • android-arm64  • Android 10 (API 29)
    • iPhone 8   • 2BC76F91-3625-4E34-B837-6F6D4ECE8474 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)
    • Chrome     • chrome                               • web-javascript • Google Chrome 80.0.3987.163
    • Web Server • web-server                           • web-javascript • Flutter Tools

! Doctor found issues in 2 categories.

Hi @linwenbang
can you please provide your flutter run  -d Chrome  --verbose?
Thank you

Hi @linwenbang
can you please provide your flutter run -d Chrome --verbose?
Thank you

it's ok after i restart system...  =。=, i could not found  it reproduce again

Hi @linwenbang
given your last message I feel safe to close this issue,
if you disagree please write in the comments and I will reopen it.
Thank you


Add RSC support

I tried to use this wonderful library, but unfortunately it doesn't work with RSC. Fortunately, I fixed this by removing useRef.
Open to any discussion and suggestions.

@sibiraj-s hey, do you think you can merge it or should I do something before it?

Lets merge this, I will figure out stuffs later.


Steps that don't interact with browser will be swallowed

What are you trying to achieve?
We want to still print out the steps that don't interact with browser in console.
What do you get instead?
They are swallowed.
Details
I am using the examples from https://github.com/codeceptjs/examples to reproduce the issue. Instead of assertion, I simply replace one of them with a console log in a step. The log is still printed out but the step description is missing from the console.
command line
npx codeceptjs run --verbose todomvc-tests/features/create-todos.feature

output
CodeceptJS v3.0.6
Using test root "/Users/henry/repo/examples"
Helpers: Playwright, REST, CustomHelper
Plugins: screenshotOnFail, retryFailedStep

Create Todos with BDD --
    [1]  Starting recording promises
 › [Session] Starting singleton browser session
  Create a single todo item @bdd
log here
    Given I have an empty todo list
      TodosPage: goto
        I am on page "http://todomvc.com/examples/angularjs/#/"
        › [Browser:Error]
        › [Browser:Info]
        › [Browser:Error]
        I refresh page
        I execute script () => sessionStorage.clear()
        › [Browser:Error]
        › [Browser:Info]
        I execute script () => console.error('Boom!')
        › [Browser:Error] JSHandle@Boom!
        I wait for visible ".new-todo"
    When I create a todo 1
      TodosPage: enterTodo "1"
        I fill field ".new-todo", "1"
        I press key "Enter"
---> (shouldn\'t "Then I see the new todo on my list" still be printed here?)
  ✔ OK in 825ms

 › [Session] cleaning cookies and localStorage

feature file
Feature: Create Todos with BDD

Scenario: Create a single todo item @bdd
  Given I have an empty todo list
  When I create a todo 1
  Then I see the new todo on my list

step file
const { I, TodosPage } = inject();

Given('I have an empty todo list', () => {
  TodosPage.goto()
})

When(/I create a todo (\d+)/, (todo) => {
  TodosPage.enterTodo(todo)
})

Then('I see the new todo on my list', () => {
  TodosPage.seeNumberOfTodos(1);
})

page object snippet
    seeNumberOfTodos(numberOfTodos) {
        // I.seeNumberOfVisibleElements('.todo-list li', numberOfTodos)
        console.log('log here')
    },

CodeceptJS version: 3.0.6
NodeJS Version: v12.20.1
Operating System: MacOS
Playwrite
Configuration file:

{
  tests: './todomvc-tests/**/*_test.js',
  output: './output',
  helpers: {
    Playwright: {
      url: 'http://localhost',
      waitForTimeout: 5000,
      show: true,
    },

    REST: {},

    CustomHelper: {
      require: './todomvc-tests/helpers/custom.helper.js'
    }
  },
  plugins: {
    retryFailedStep: {
      enabled: true
    },
  },
  gherkin: {
    features: './todomvc-tests/features/*.feature',
    steps: [
      './todomvc-tests/step-definitions/create-todos.steps.js'
    ]
  },

  include: {
    TodosPage: './todomvc-tests/pages/todos.page.js'
  },
  bootstrap: null,
  mocha: {},
  name: 'codecept demo tests'
}

The issue is because the CLI reporter gathers the step name in step.started event and prints it. But if a gherkin step doesn't issue I.doSomething() command, then it will never trigger a step.started event and that particular step won't be printed ever. This is mostly a concern only in gherkin mode.

Known issue. A gherkin step must contain I. steps to be invoked


chore(coverage): improve tests cases

Proposed changes

This PR primarily deals with improving test coverage.
Specifically, this PR does the following:

removes unnecessary methods in host class.
uses string instead of char* in Host::ip.
improves testing of host class.
improves testing of paths class.
updates connection test to use string.
improves testing of host class.
updates the change log.

Types of changes

[x] Other... Please describe:

Improves class members and test coverage to 100%.
Checklist

[x] I have read the CONTRIBUTING documentation
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works

@faustbrian
Looks like CircleCI is bugging out again.
This build task isn't in my CircleCI jobs,
and it doesn't look like it appears here either: circleci/ArkEcosystem
Passing tests here:
circleci/sleepdefic1t/cpp-client
100% CodeCov:
codecov/sleepdefic1t/cpp-client

gonna try something..

Codecov Report

Merging #93 into master will increase coverage by 3.59%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #93     +/-   ##
=======================================
+ Coverage    96.4%   100%   +3.6%
=======================================
  Files          14     14
  Lines         250    245      -5
=======================================
+ Hits          241    245      +4
+ Misses          9      0      -9

Impacted Files
Coverage Δ

src/host/host.cpp
100% <100%> (+31.81%)
:arrow_up:

src/api/paths.cpp
100% <0%> (+0.64%)
:arrow_up:

src/http/os/http.cpp
100% <0%> (+2.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63837f...b57d988. Read the comment docs.


Can't install with npm 5.3.0

When trying to install with npm install -g https://github.com/reasonml/reason-cli/archive/beta-v-1.13.6-bin-linux.tar.gz, using npm 5.3.0, the installation fails with the following error:
/usr/local/bin/ocamlmerlin -> /usr/local/lib/node_modules/reason-cli/.bin/ocamlmerlin
/usr/local/bin/ocamlmerlin-reason -> /usr/local/lib/node_modules/reason-cli/.bin/ocamlmerlin-reason
/usr/local/bin/ocamlrun -> /usr/local/lib/node_modules/reason-cli/.bin/ocamlrun
/usr/local/bin/ocamlc -> /usr/local/lib/node_modules/reason-cli/.bin/ocamlc
/usr/local/bin/ocamlc.opt -> /usr/local/lib/node_modules/reason-cli/.bin/ocamlc.opt
/usr/local/bin/ocamlopt -> /usr/local/lib/node_modules/reason-cli/.bin/ocamlopt
/usr/local/bin/ocamlopt.opt -> /usr/local/lib/node_modules/reason-cli/.bin/ocamlopt.opt
/usr/local/bin/rtop -> /usr/local/lib/node_modules/reason-cli/.bin/rtop
/usr/local/bin/ocaml -> /usr/local/lib/node_modules/reason-cli/.bin/ocaml
/usr/local/bin/utop -> /usr/local/lib/node_modules/reason-cli/.bin/utop
/usr/local/bin/refmt -> /usr/local/lib/node_modules/reason-cli/.bin/refmt
/usr/local/bin/refmttype -> /usr/local/lib/node_modules/reason-cli/.bin/refmttype
/usr/local/bin/reopt -> /usr/local/lib/node_modules/reason-cli/.bin/reopt
/usr/local/bin/rebuild -> /usr/local/lib/node_modules/reason-cli/.bin/rebuild
/usr/local/bin/reactjs_jsx_ppx -> /usr/local/lib/node_modules/reason-cli/.bin/reactjs_jsx_ppx
/usr/local/bin/reactjs_jsx_ppx_2 -> /usr/local/lib/node_modules/reason-cli/.bin/reactjs_jsx_ppx_2
/usr/local/bin/berror -> /usr/local/lib/node_modules/reason-cli/.bin/berror
/usr/local/bin/menhir -> /usr/local/lib/node_modules/reason-cli/.bin/menhir
/usr/local/bin/ocamlfind -> /usr/local/lib/node_modules/reason-cli/.bin/ocamlfind
/usr/local/bin/reason-cli -> /usr/local/lib/node_modules/reason-cli/.bin/reason-cli

><EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/reason-cli
> ./postinstall.sh

gzip: rel.tar: Permission denied
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: `./postinstall.sh`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jim/.npm/_logs/2017-07-26T12_10_30_040Z-debug.log

Using my previous npm version (4.1.2), the installation does work. Haven't tried any other versions of npm, just thought you should know this.

I also encountered this issue on Arch linux.

Same issue on OSX 10.12.6 and npm 5.3.0.

Thank you for reporting. I think this is a legitimate issue because I just tried on npmc (their canary). I previously have had no problems with npmc, so something changed with how either npm handles permissions, or how we alter permissions on our releases. Old npm still works well for me, as you've noted.

I think this is a legitimate issue because I just tried on npmc (their canary). I previously have had no problems with npmc, so something changed with how either npm handles permissions, or how we alter permissions on our releases. Old npm still works well for me, as you've noted.

 This might be a bug on their end, or a new security feature. Does anyone know?

This issue supposedly says it's fixed, but it still looks broken to me (in the latest canary (5.4 canary 1)).

I've filed an issue here on npm's repo. It looks like it's a bug in npm5 :(

We can do sh ./postinstall.sh as a workaround?

@andreypopp Yes, you should be able to do npmc install -g --ignore-scripts theUrl, and then cd into the npm install location, then chmod 777 postinstall.sh, and then ./postinstall.sh.

@jordwalke thanks for answer. It help!
A little hint who stucked with that problem too:
npm global packages folder can be found by $ npm list -g.
For example, at Fedora path is /usr/lib/node_modules/reason-cli/

What did you have to do to get it working?

Same issue on OSX 10.12.6 , node 8.7.0 and npm 5.4.2

@mikowiec do you use nvm or something like that or this was just plain brew install of Node?

do you use nvm or something like that or this was just plain brew install of Node?
No, I've installed the latest release node-v8.7.0.pkg from nodejs.org
I've make workaround with postinstall.sh and installation finished well.
But, the similarly issue occurred when I installed "bs-platform" for testing purposes.

I've uninstalled v8.7 and then installed LTS node-v6.11.4.pkg (where is npm 3.10.10).
Then installed "bs-platform" and made the simple project.
It was OK for LTS and fault for latest node (npm).

My NPM version is 5.5.1 and I still had this issue. Jordan's workaround above worked fine though.

@adrianmcli and what is your OS?

@jordwalke I was using official npm release 5.5.1 on Mac OS 10.12.6 Sierra. Willing to try other combinations if you'd like.

Same issue with npm 5.6.0

As explained in the other opened issue, I fixed it in this way:
MacOs 10.13.2, npm 5.6 and node 9.2.0.
To fix it, I ran npm install with the --ignore-scripts flag to not execute the faulty post-install script:
npm install -g --ignore-scripts  https://github.com/reasonml/reason-cli/archive/3.0.4-bin-darwin.tar.gz

inside the installation dir .nvm/versions/node/v9.2.0/lib/node_modules/reason-cli/
I had to change the file ownership and group because they were totally wrong:
ll ~/.nvm/versions/node/v9.2.0/lib/node_modules/reason-cli/r/build-eject/bin/esyImportBuild
-rwx------  1 653775386<PHONE_NUMBER>

sudo chown -R $USER r

execute the postinstall script with sudo
sudo ./bin/esyBuildRelease bin install

and everything worked.
It could be that passing --unsafe-perm to the npm install could fix the issue as well but I didn't try it as I already spent 2 hours trying to fix the issue.


Bot Framework Emulator not working

suddenly, The Bot Framework Emulator not working although it was working before

"not working" can be interpreted a number of ways. Can you describe the failure?

are you experiencing same issue as myself? https://github.com/Microsoft/BotFramework-Emulator/issues/350

Closing due to inactivity. Post here if you'd like the issue reopened.

It was resolved after check the following option


issue when building locally with newest update (academic 4.2.2 + Hugo 0.55.2)

Hi,
I have this error message when building locally with newest update
ERROR 2019/04/18 07:54:56 render of "taxonomyTerm" failed: "C:\Hugo\bosscha-academic-test-2\themes\academic\layouts\_default\list.html:8:66": execute of template failed: template: _default/list.html:33:5: executing "_default/list.html" at <partial "pagination" .>: error calling partial: "C:\Hugo\bosscha-academic-test-2\themes\academic\layouts\partials\pagination.html:8:66": execute of template failed: template: partials/pagination.html:8:66: executing "partials/pagination.html" at <.Paginator.Next.RelPermalink>: can't evaluate field RelPermalink in type *page.Pager ERROR 2019/04/18 07:54:56 render of "taxonomyTerm" failed: "C:\Hugo\bosscha-academic-test-2\themes\academic\layouts\author\terms.html:5:66": execute of template failed: template: author/terms.html:27:5: executing "author/terms.html" at <partial "pagination" .>: error calling partial: "C:\Hugo\bosscha-academic-test-2\themes\academic\layouts\partials\pagination.html:5:66": execute of template failed: template: partials/pagination.html:5:66: executing "partials/pagination.html" at <.Paginator.Prev.RelPermalink>: can't evaluate field RelPermalink in type *page.Pager ERROR 2019/04/18 07:54:56 render of "taxonomyTerm" failed: "C:\Hugo\bosscha-academic-test-2\themes\academic\layouts\_default\list.html:5:66": execute of template failed: template: _default/list.html:33:5: executing "_default/list.html" at <partial "pagination" .>: error calling partial: "C:\Hugo\bosscha-academic-test-2\themes\academic\layouts\partials\pagination.html:5:66": execute of template failed: template: partials/pagination.html:5:66: executing "partials/pagination.html" at <.Paginator.Prev.RelPermalink>: can't evaluate field RelPermalink in type *page.Pager Total in 5608 ms Error: Error building site: failed to render pages: render of "taxonomyTerm" failed: "C:\Hugo\bosscha-academic-test-2\themes\academic\layouts\author\terms.html:8:66": execute of template failed: template: author/terms.html:27:5: executing "author/terms.html" at <partial "pagination" .>: error calling partial: "C:\Hugo\bosscha-academic-test-2\themes\academic\layouts\partials\pagination.html:8:66": execute of template failed: template: partials/pagination.html:8:66: executing "partials/pagination.html" at <.Paginator.Next.RelPermalink>: can't evaluate field RelPermalink in type *page.Pager
I don't have any idea why. I did successfully build my site with academic 4.2.0 + hugo 0.54.0
many thanks

Additional information: I update my theme via git submodule:
git submodule update --remote --recursive
and there were no errors. But it seems that several things is not updated properly (e.g. netlify.toml (still shows 0.54.0 instead of 0.55.2 in HUGO_VERSION; academic.toml in themes\academic\data\still shows version 4.2.0 instead of 4.2.2,  etc)

Ran into this same issue when upgrading.
Overriding layouts\partials\pagination.html with

»

to

»

lets everything else build fine without apparent issue.
Weird as seemed part of the upgrade fix?

I also got another weird issue.  It seems that some of markdown features (such as lists and bold/italic format) are broken in both note and warning block. I encounter this issue on hugo 0.55.2 with academic 4.2.0 (but not on hugo 0.54.0 + academic 4.2.0)

The paginater links were upgraded in v4.2.2 based on Hugo release notes, but it now appears this instance of URL didn't change in Hugo (yet). Therefore, reverted this change in v4.2.3 to fix the issue.

Closing this issue as it is solved. If any further issues are found with Hugo 0.55.2, please open a new issue.


device-mapper-driver documentation update looses thinpool configuration info

Referring to #22166
The last commit of the device-mapper documentation by @chenchun clarified the overall use.
But as I go through the steps, I'm missing the part where the thinpool configuration on /data and /metadata is done.
The diff shows that the previous version had this covered in lines 254 and following

ping @mbentley could you have a look what's missing?

There are a number of steps missing from this; looks like someone wrote docs on an old version and it was merged.  From what I can see of the history, a7b2f87b0637a3711e90c0f1d0a99dd5d32bd60f seems to have reverted some old docs.  The last time to docs were correct was 24ec73f754da16e37726a3f1c6a59de508e255fc.  I'd suggest we revert to 24ec73f754da16e37726a3f1c6a59de508e255fc and have the updates done in a7b2f87b0637a3711e90c0f1d0a99dd5d32bd60f rebased.

Hm, may become tricky, because the changes in https://github.com/docker/docker/commit/24ec73f754da16e37726a3f1c6a59de508e255fc are for 1.12 (which renames docker daemon to dockerd), so those cannot go live yet

Then we'll need to revert to b21d90c28faaa9f906c4e3b2145ddf661a19e994 for now.

OK, I gave it a stab.  That was more of a pain than I realized.  I believe I also included the formatting changes made in other commits since the dm docs were messed up.


Initial pass at fleshing out the readme

Preview the readme here: https://github.com/material-motion/motion-interchange-objc/blob/69507b133b991f70cf3f074663a8c2d66518fc7d/README.md

I will need to make a few passes at improving the technical documentation and how-to guides. Will do so in a follow-up PR.


Option to stay on search results when creating Post

When drafting/publishing a Post, would be nice to leave the user on the search results page.  Maybe give them a link to the new Post, but make them click another link to go there.

I am thinking we can just make this the default behavior.
So, after saving a new post, the search result the new post is based on would get the standard treatment for posts that have already been imported, including a link to edit the draft/published post in WordPress.

Sounds good to me.

Merged into master.  Releasing shortly.


[rtve] Add new extractor for rtve infantil

Updated RTVE extractor for download shows from http://www.rtve.es/infantil/

Merged, thanks.

sorry for the errors and thanks a lot for the merge...

No problem.
Do you want to be listed in the AUTHORS file? If so, under which name?

Of course,  Eduardo Ferro Aldama :-)
Thanks


Streaming Sound Wave playback keeps being reset to 0

Hello everyone, nice to meet you 👋
I got an issue with audio streaming and it feels like I am stack. Spent around three days on that already.
I receive audio bytes from my python server using web sockets. After that I feed it to Append Audio Data from Encoded. Looks like it works as expected in general. But it keeps resetting my sound wave playback time to 0 every time it receives new data. When it receives the last chunk it plays the whole message from the very start to the very end. I thought that maybe somehow I feed wrong data. But I am not sure.
The error looks like that and I receive them every time I process new data chunk:
Validity of PCM data in memory: Valid, number of PCM frames: 2304, PCM data size: 2304
LogRuntimeAudioImporter: Stopping the active sound 'BP_TEST_C_2' because it is using the same sound wave 'StreamingSoundWave_7' (only one imported sound wave can be played at a time)
LogRuntimeAudioImporter: The playback time for the sound wave 'StreamingSoundWave_7' will be set to '0.000000'
LogRuntimeAudioImporter: Stopping the active sound 'BP_TEST_C_2' because it is using the same sound wave 'StreamingSoundWave_7' (only one imported sound wave can be played at a time)

Even though I initialize Streaming Sound Wave at begin play event and set it to variable. Which I then reuse. I attached a screenshot with my blueprint logic. Any advice is appreciated as I am not sure what else to try. Thank you.

Hi, the reason for this behavior, where playback starts from 0 each time audio data is populated, is simply because you're calling the PlaySound2D function every time after you call AppendAudioDataFromEncoded. If you want to play it persistently as you receive your audio data, you should call the PlaySound2D function only once, such as on Begin Play, and then only call the AppendAudioDataFromEncoded. This should resolve your issue.

Thank you very much. Looks like I was code blind. Your suggestion helped.


Add onError to Image Events

Resolves #1209

Coverage remained the same at 100.0% when pulling c269c13f38238382b880393f3384e05b07a76871 on jackmoore:patch-1 into 1369ab358a735a67d33c1287e4c15c8a1c85ef58 on developit:master.


Fixed some config reload cluster tests

Use checkClusterFormed() to minimize risk of test failures due
to the subscription not being registered through the cluster.

Coverage increased (+0.3%) to 91.466% when pulling 28d4420a2c1844fd8e0e62144c15061949029454 on config_reload_cluster_tests into f246c094117664cf65482f3b56b6d031f03191b5 on master.


Run hpack compressor test with mode

This patch fix a minor bug when run compressor specs: It changes options in Compressor and Decompressor so they will run with options all of encoding options

Thank you!


Disable admin

Looks like I can not  use admin on heroku... How can I disable it?

@narcisobenigno can you explain a bit more what you mean when you say you can't use the admin? Can you also include any errors you're getting?
Thanks.

Hi, I would like to disable the admin, too in some situations. However I don't have any problems with it yet, it's just dump when you need to configure multiple instances of finatra on a single server, ports clashing everywhere, so the less ports you need to configure, the better.

The Ports trait is not meant for configuration. Its purpose is to expose the ports during integration tests so that HTTP clients can point at the correct destination.
https://github.com/twitter/finatra/blob/master/http/src/test/scala/com/twitter/finatra/http/test/EmbeddedHttpServer.scala#L39

Oh however httpExternalPort is still used for the http server info message which is wrong.
The next thing is there a way to set a flag inside the code?

Sorry by delay, and thanks by the feedback!
I don't know if is possible to configure in heroku to see de finatra admin dashboard. Then I wish to disable the dashboard (not startup it), just the server http port.

@narcisobenigno the admin dashboard is a twitter-server (which Finatra is built on-top of) feature. What is the actual error you're seeing when trying to start your service on Heroku?

@narcisobenigno it should be possible to just set the admin port twitter-server flag to 0, e.g.,
-admin.port=:0

I've tested this with a sample finatra application running on Heroku. Please let me know if that works for you. Thanks!

Okay, I will try.
Thanks
On Thu, May 28, 2015, 14:15 Christopher Coco<EMAIL_ADDRESS>wrote:

@narcisobenigno https://github.com/narcisobenigno it should be possible
to just set the admin port twitter-server flag to 0, e.g.,
-admin.port=:0
I've tested this with a sample finatra application running on Heroku.
Please let me know if that works for you. Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/twitter/finatra/issues/208#issuecomment-106499118.

@cacoco @narcisobenigno  Setting the port to 0, assigns a random port bound to all interfaces. You can check with sudo netstat -plunt

@sergio91pt yep -- unfortunately there's no way to get two assigned ports with Heroku currently so this is the workaround. You won't be able to access the admin as like you said it will be on some random port. Thanks!

It's hacky but this works on Heroku.
Procfile
web: target/universal/stage/bin/hello-world -- -admin.port=:0 -http.port=:$PORT
Server/Module
class AdminClientModule(adminServer: => ListeningServer) extends HttpClientModule {
  override def dest: String = ":" + adminServer.boundAddress.asInstanceOf[InetSocketAddress].getPort
}

object HelloWorldMain extends HelloWorldServer

class HelloWorldServer extends HttpServer {

  override protected def modules: Seq[Module] = Vector(new AdminClientModule(adminHttpServer))
  ...
}

Controller
class AdminController @Inject()(httpClient: HttpClient) extends Controller {

  // NOTE(aaron): Use a wildcard in order to avoid being catalogued as an admin route in HttpRouter.partitionRoutesByType.
  get("/admi:*") { request: Request =>
    httpClient.execute(request)
  }
}

Bump - is there no way to disable the admin server?

@aliakhtar Yep: https://twitter.github.io/finatra/user-guide/getting-started/twitter_server.html#disabling-the-twitterserver-adminhttpserver

@cacoco I did this but I still see the routes for admin server being created in the output when I start up the server:
2020-02-21 23:07:40,074  DEBUG main i.n.i.InMemoryDbServerMain$.updateMuxer - AdminHttpServer Muxer endpoints:
	/admin/ping => com.twitter.server.handler.ReplyHandler
	 => com.twitter.finagle.filter.OffloadFilter$Server.andThen(com.twitter.server.handler.AdminRedirectHandler)
	/admin => com.twitter.finagle.filter.OffloadFilter$Server.andThen(com.twitter.server.handler.SummaryHandler)
<snip>

I'm guessing this is because I'm not setting the value of admin.port to be the same as http.port. For http.port, I'm overriding the field in the class:
override val defaultHttpPort: String = ":8420"
but I can't find which field to override for admin.port?

@aliakhtar as mentioned in the documentation, the admin is started and then shut down in the process of bringing up the server. You will see routes created but the listening server which accepts requests will not be started.
Also as linked to from the documentation the TwitterServer AdminHttpServer is what defines the admin.port flag and it's default which can be overridden in code:
https://github.com/twitter/twitter-server/blob/develop/server/src/main/scala/com/twitter/server/AdminHttpServer.scala#L117
Thus you would do:
override val defaultAdminPort: Int = 0

Thanks!


delete of multiple files throws errors

This happens once an instance is running from MyBinder. If you go to the Jupyter dashboard where the Jupyter UI lists files for the typical launched notebooks (not JupyterLab), if you try to delete more than one file, you get an error "Forbidden".
Tim Head was actually unclear on where to file but suggested here first.

humm. actually not sure where that should be filed as error, binderhub or the notebook, probably best to start with binderhub.

(Workaround is to delete in the terminal or using exclamation and command in the notebook. Or use python in the notebook.)

A super simple repository like https://mybinder.org/v2/gh/terna/pandas-datareader/master also reproduces this bug. Trying to delete even a single file leads to the following error:

Traceback (most recent call last): File "/srv/venv/lib/python3.6/site-packages/tornado/web.py", line 1512, in _execute result = yield result File "/srv/venv/lib/python3.6/site-packages/tornado/gen.py", line 1055, in run value = future.result() File "/srv/venv/lib/python3.6/site-packages/tornado/concurrent.py", line 238, in result raise_exc_info(self._exc_info) File "", line 4, in raise_exc_info File "/srv/venv/lib/python3.6/site-packages/tornado/gen.py", line 307, in wrapper yielded = next(result) File "/srv/venv/lib/python3.6/site-packages/notebook/services/contents/handlers.py", line 235, in delete yield gen.maybe_future(cm.delete(path)) File "/srv/venv/lib/python3.6/site-packages/notebook/services/contents/manager.py", line 278, in delete self.delete_file(path) File "/srv/venv/lib/python3.6/site-packages/notebook/services/contents/filemanager.py", line 499, in delete_file send2trash(os_path) File "/srv/venv/lib/python3.6/site-packages/send2trash/plat_other.py", line 185, in send2trash dest_trash = find_ext_volume_trash(topdir) File "/srv/venv/lib/python3.6/site-packages/send2trash/plat_other.py", line 145, in find_ext_volume_trash trash_dir = find_ext_volume_fallback_trash(volume_root) File "/srv/venv/lib/python3.6/site-packages/send2trash/plat_other.py", line 139, in find_ext_volume_fallback_trash check_create(trash_dir) File "/srv/venv/lib/python3.6/site-packages/send2trash/plat_other.py", line 84, in check_create os.makedirs(dir, 0o700) File "/usr/lib/python3.6/os.py", line 220, in makedirs mkdir(name, mode) NotADirectoryError: [Errno 20] Not a directory: b'/home/jovyan/README.md/.Trash-1000'

(the formatting is already screwed up in the notebook UI) Two questions: does anyone remember having successfully deleted files via the UI before? I have never tried, so this might not be a new bug but one that was there all along. If this used to work, ideas on what got changed to get us started tracking this down?

The error is in send2trash and they released a new version a few days ago, but pip show send2trash on the example repo above says we are still on 1.4.2 from November 2017.
However https://github.com/hsoft/send2trash/compare/1.4.2...master suggests that @takluyver fixed something related to permissions exactly where this error is coming from. I'd suggest we make a PR to https://github.com/jupyter/repo2docker to upgrade send2trash to the latest version and see what happens.

It's probably going to need a new release of notebook as well to take
advantage of the changes in send2trash.
On 26 Feb 2018 10:04 p.m., "Tim Head"<EMAIL_ADDRESS>wrote:

The error is in send2trash and they released a new version a few days
ago, but pip show send2trash on the example repo above says we are still
on 1.4.2 from November 2017.
However<EMAIL_ADDRESS>https://github.com/hsoft/send2trash/compare/1.4.2...master suggests
that @takluyver https://github.com/takluyver fixed something related to
permissions exactly where this error is coming from. I'd suggest we make a
PR to https://github.com/jupyter/repo2docker to upgrade send2trash to the
latest version and see what happens.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jupyterhub/binderhub/issues/471#issuecomment-368667159,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUA9QzS3VUJcRCqSu8_Czn6zQHvCLdKks5tYypagaJpZM4ST1Pp
.

Related https://github.com/jupyterhub/jupyterhub/pull/1688
I think that PR (once it gets deployed) should fix this?

Yup, if send2trash is disabled, this shouldn't come up.

Sounds like this wasn't a BinderHub bug.


Standalone Typescript React Template " Add integration for Empty ASP.NET Web API Project option" not available.

In this document, Step 3. " Add integration for Empty ASP.NET Web API Project option" is not available for Standalone Typescript React Template in VS2022 Version 17.1.3
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f5beb7f5-5d28-d5e5-92ba-3e04c75e44b5
Version Independent ID: 867e3a3f-2387-ba46-c911-10822f8c4a81
Content: Create an ASP.NET Core app with React - Visual Studio (Windows)
Content Source: docs/javascript/tutorial-asp-net-core-with-react.md
Product: visual-studio-windows
Technology: vs-javascript
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

Hi,
In fact, Step 3 of the document states "The standalone TypeScript React Template is not currently supported in this tutorial". The option is available with the JavaScript version of the Template (VS 17.1.6).
That's being said, it would be very nice to have the option for the TypeScript version of the Template :)

@MarcusGambit Thanks for the feedback! If you are looking for functionality that isn’t currently provided by the product, please use our new “Suggest a feature” option in the Visual Studio Developer Community. We’d be happy to have this on record, where others can view it and upvote it, too. For more information about this new functionality in the dev community, see our Suggest a feature page.


Feature : MillerRabin Algorithms

Hey, I want to add program to find the number is prime or not using very very big number  in c++ .

@keshavsingh4522  I have solve this Issue kindly merge my PR #2761


Hyprpaper can't found file with socat but can with hyprctl

hi, i am trying to make variety support hyprpaper but i don't  want to only make it support only hyprland so i can't use hyprctl.
When using socat it seem hyprpaper's preload function can't found the wallpaper but can when using it with the exact same argument with hyprctl hyprpaper, i even made a bash script so i am sure i don't do any error.
here the simple bash script:
WP=/home/cylian91/.config/variety/wp/burningflag.jpg
hyprctl hyprpaper preload $WP
sleep 10 # wait just in case
echo             "preload $WP" | socat - UNIX-CONNECT:/tmp/hypr/$HYPRLAND_INSTANCE_SIGNATURE/.hyprpaper.sock

the script return
ok
preload failed (no such file)

it look like socat add these:
[LOG] char 57: 32
[LOG] char 58: 92
[LOG] char 59: 110
[LOG] char 60: 10

might be an issue with socat then no?
If you don't wanna use hyprctl, why not connect to the socket via normal, plain old C, or whatever programming language you use?

yes its an issue wit socat and not hyprland, the issue can be closed


This should use self.log.

Otherwise these log messages pollute the root logging level, making them hard to filter.

Thanks. Fixed in SHA: a3f3ad7


fix(ios): track hierarchy artifacts

Description
This pull request addresses absent UI hierarchy artifacts in our Allure reports.
It should be helpful for anyone who's using: https://github.com/wix-incubator/detox-allure2-adapter

This is a mere fix, @d4vidi, not an attempt to reimagine the subsystem. I have a vision regarding the new iteration of artifacts, and it is based on making all artifact creating APIs public, plus a thin integration attaching to test runner lifecycle to call those API.
Anyways, here I just align the implementation with my initial API design in 2019. All artifacts undergo track/untrack, but it seems that I was a bit slack last time (the UI hierarchy is one of the last plugins we added), and simply forgot to add it.
We use tracking and untracking to make sure that artifacts get cleaned up even if the artifact plugin forgets to do that.
Allure integration just hops on trackArtifact to spy on artifact.doSave whenever an artifact is created. I hope that explains.


Run tox

on update from black 23 to 24, some things changed. This runs black src and isort docs/examples

Also requires changing jax.numpy.row_stack to jax.numpy.vstack, as row_stack was depcreated in 0.4.16 and removed in 0.4.24

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e693128) 94.75% compared to head (fae0d93) 94.74%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   94.75%   94.74%   -0.01%
==========================================
  Files          11       11
  Lines         934      933       -1
==========================================
- Hits          885      884       -1
  Misses         49       49

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Specify node version for NVM

What is the context of this PR?
Specify to use node carbon to:

Set netlify to use the correct node version when building
Set correct node version locally

How to review

Ensure that in the netlify deploy logs for this PR that it uses node 8.12.0
That with nvm installed correctly that when you switch into the directory that your node version switches to 8.12.0

How do you access the Netlify logs?

Logs available when netlify is in the 'deploying' state.


[Bug]: S3 Web browser file upload CORS

Contact Details
<EMAIL_ADDRESS>Is there an existing issue for this?

[X] I have searched all the existing issues

Priority
high
Environment
- CubeFS version:3.3.2
- Deployment mode(docker or standalone or cluster): cluster
- Dependent components:Object Node
- OS kernel version(Ubuntu or CentOS): Ubuntu
- CPU/Memory:
- Others:

Current Behavior
After configuring the object storage node and cross domain configuration according to the tutorial, uploading on the page still requires cross domain configuration
Expected Behavior
Provide more convenient cross domain configuration, such as cfs cli command-line configuration volume
Steps To Reproduce
No response
CubeFS Log

Anything else? (Additional Context)
No response

按照手册配置如图

@tangdeyi Please help to check the issue.

Your host setting is wrong. You should fill it out according to the actual host, not the sample host. The actual host is in the error message. For example, if the cross-domain is not configured, the error message XXX from origin "http://cubefs.com" will be reported. Then the source should be configured as http://cubefs.com.

The address I configured should be correct,
<IP_ADDRESS> is the deployment address for GUI, and <IP_ADDRESS> is the Object Node address

Do not configure origin to *, the browser will intercept such requests
Check your preflight cross-domain request, the error message XXX from origin "host" is printed in the log, use it to fill in the origin field of cors

Check if your cors configuration contains spaces and which version you are using


Improve tutorial

Hello @matteobachetti! Thanks for submitting the PR.

In the file docs/conf.py, following are the PEP8 issues :

Line 6:80: E501 line too long (80 > 79 characters)
Line 18:80: E501 line too long (80 > 79 characters)
Line 60:1: E265 block comment should start with '# '
Line 108:1: E265 block comment should start with '# '
Line 113:1: E265 block comment should start with '# '
Line 124:1: E303 too many blank lines (3)
Line 125:1: E265 block comment should start with '# '
Line 138:1: E265 block comment should start with '# '
Line 151:80: E501 line too long (80 > 79 characters)
Line 180:80: E501 line too long (88 > 79 characters)
Line 181:1: W391 blank line at end of file


Removed aria-labels from legends

Aria-labels are not accepted attributes on legends, and were raising the issue below on Axe:

"Elements must only use allowed ARIA attributes" is a MUST requirement for WCAG 2.0 (A) (ref)
This layout of legend, then label is replicated from the QAVS question template, where some legends were empty but used to satisfy fieldset + legend relationship.
@mauricioac what are you thoughts on this solution vs reworking _question.html slim to remove some questions from fieldsets altogether?

There should not be a aria-label on legends
legends are needed on groups of fields, like address, checkboxes and on radio buttons.
I'm not sure how easy it would be to fix this on _question.html.erb


Feature [Allow Optionals Params]

Pull Request Summary
This pull request introduces several enhancements and updates to the codebase. The changes include the addition of new functionality, internal documentation updates, improvements to the README.md file, the creation of a new class, updates to the concatUserFlow method, and UI refinements using the Visibility widget.
Changes Made

Added the ability to include optional parameters in the AADLoginButton widget to customize the URL. The optionalParameters parameter now accepts a list of OptionalParam objects, where each object represents a parameter name and its corresponding value.

Updated the README.md file to include detailed instructions on how to utilize the optionalParameters parameter. An example was provided to demonstrate the addition of new parameters to the URL.

Created a new class, OptionalParam, to encapsulate the key-value pairs for the optional parameters.

Improved the concatUserFlow method to incorporate the optional parameters in the URL generation process.

Updated the UI implementation to utilize the Visibility widget. This change allows for the removal of unnecessary Stack widgets, resulting in a cleaner and more efficient UI structure.

These changes enhance the flexibility and customization options of the AADLoginButton widget, while also improving code organization, readability, and user experience.
Please review the changes and provide any feedback or suggestions for further improvements.
Thank you.

@microsoft-github-policy-service agree company="nnoxx-inc"

Marking this pull request as ready for review.

@Baxi19  thank you for your contribution, I will review it in some days :)

Hi @mohanajuhi166
What is the next step to merge this pull request?

@Baxi19 thank you for your contribution, it's deployed now to pub.dev
We would love to know how this package is being currently utilized as we want to add a documentation going forward and also open up issues/features :)
Kind regards,
Mohana

Hello @mohanajuhi166 ,
Thank you for reviewing my pull request.
Currently, the package is being used in a project where it serves as a WebView for Azure Active Directory B2C authentication.
In this particular project, we required the ability to include an optional parameter in the URL to differentiate between app mobile and web page sources. This addition allows us to handle different scenarios and customize the behavior accordingly.
By adding support for optional parameters, it enhances the flexibility and adaptability of the package, making it more versatile for various use cases.
If you have any further questions or need additional information, please feel free to let me know. I'm glad to assist you in any way I can.
Best regards,
Randald Villegas.

thanks @Baxi19 !, if you want to be one of the active contributors here ,let us know :) .

@mohanajuhi166  Yes, I would like to be one of the active contributors here.
I am eager to contribute and assist in any way I can.

@Baxi19 thank you!! will include you as a reviewer for other pull requests etc :)


Competitors?

“ If you're worried about competitors messing with your priority list, maybe use something else.”
It’s probably not (just) competitors that you should worry about here. It’s more that a user that really wants a feature is easily able to outvote the other features as the limit of 1 per user is client-side enforced only.
Maybe use a real api behind it? (Or change the readme so users are made more aware to not use this for roadmaps where commercial interests are at play).

Made the readme more clear to address this. Would be nice if there’s another api we can use for this that handles this better yet is still easy to set up. Any thoughts?

Unsure what options CountAPI has, as I can't actually even load the website (making this library not work for me) but gating options could include one vote per IP, or the optional ability to provide the Roadmap library with a user identifier -- where this comes from depends on the user but could be identifierForVendor or a custom login solution.
Probably makes sense to abstract the CountAPI solution from the library so plugins can be provided? (As long as it sits behind an interface, the user could override it with their own backend with auth etc). I could be tempted into open-sourcing a backend for this lib to handle these reqs.

Strange that it doesn't work for you @Sherlouk , any idea why that could be? https://countapi.xyz
We've definitely gotten some feedback on making the backend more flexible. I'm a novice on that stuff so would love to hear opinions on how best to approach it.

Strange that it doesn't work for you @Sherlouk , any idea why that could be? https://countapi.xyz

I've always had problems with the .xyz TLD - no idea why, my local network just refuses to connect and I've heard of others with the same experience.
I think this library, as is, would benefit from being able to customise the backend by providing your own - while still using CountAPI as the default and embedded solution. I'm happy to raise a PR with this, it should just be a case of adding a new protocol to act as a middleman between the library and the backend, and adding a new configuration item for it.

I think this library, as is, would benefit from being able to customise the backend by providing your own - while still using CountAPI as the default and embedded solution. I'm happy to raise a PR with this, it should just be a case of adding a new protocol to act as a middleman between the library and the backend, and adding a new configuration item for it.

If you could, that would be great! Something like a FeatureVoter protocol that comes with the vote() method which is called from the vote button should be sufficient


Please add title replacement for describe functions

There is an open PR for this. Would be excellent to have this. Please ship. Thanks!!!
https://github.com/fluentsoftware/data-driven/pull/3

:+1: for this fix

and context, too, please!  Thank you for the library!


Return success from FileManager recursive directory creation even if a directory was created by another thread concurrently.

If another thread creates one of the same directories in the target path, the !fileExists check may pass while the mkdir call fails with EEXIST. However, if the existing file is a directory, then that should still be a success.
Fixes SR-12272.

@swift-ci Please test.

@swift-ci test linux

@millenomi Is this test job stuck or something? How come it has not run yet?

Sometimes the traffic on CI is so high that requests get dropped.

@swift-ci please test and merge

@swift-ci please test and merge

@swift-ci test linux

@swift-ci test macOS

Resolved the conflict. Please re-trigger the tests.

@swift-ci please test

Yay, passed! Can we merge?

@swift-ci please test and merge


Content Break and Left Border apply to whole section not columns block

See https://www.stewart.com/en/what-we-offer/insurance.html

@shsteimer — unless I am misunderstanding the bug here (I probably am), I don't think this requires a code change? This can be achieved by placing a columns block inside the teal section. See: https://main--stewart--hlxsites.hlx.page/en/what-we-offer/insurance