Support for OpenTelemetry Events on a Span

Add support for OpenTelemetry Events, which allow for reporting an event at a specific time with attributes.

Thanks, @AndrewRissing! This is certainly something that is on New Relic's radar.
Unfortunately, it's a bit more involved than just enabling sending up events from our exporter - that is, New Relic's backend does not yet support ingesting OTel events and therefore we do not currently display OTel event data anywhere in our UIs.
Though, I am curious about your use cases for using events. The OpenTelemetry community has a few that I am aware of:

recording exceptions
gRPC messages
logs
adding custom events

Are there particular use cases you're interested in?

Thanks, @AndrewRissing! This is certainly something that is on New Relic's radar.
Unfortunately, it's a bit more involved than just enabling sending up events from our exporter - that is, New Relic's backend does not yet support ingesting OTel events and therefore we do not currently display OTel event data anywhere in our UIs.
Though, I am curious about your use cases for using events. The OpenTelemetry community has a few that I am aware of:

recording exceptions
gRPC messages
logs
adding custom events

Are there particular use cases you're interested in?

I had assumed the limitation existed on the backend,  based on what I've seen.  For us, we're really looking at it for events (#4) with handled exceptions (#1) being a special case of that.
Perhaps some synergy might exist between NR's concept of an event and OTel events, but that might be a bit presumptuous based on how NR's backend is setup.

I had assumed the limitation existed on the backend,  based on what I've seen.  For us, we're really looking at it for events (#4) with handled exceptions (#1) being a special case of that.
Perhaps some synergy might exist between NR's concept of an event and OTel events, but that might be a bit presumptuous based on how NR's backend is setup.

I'm expecting precise timing events to be included in spans. For example, the StackExchange Redis client instrumentation adds events for each step in the command-processing pipeline:

Enqueued
Sent
ReponseRecieved

(see: RedisProfilerEntryToActivityConverter)
This information is critical for diagnosing performance bottlenecks around Redis use.

I'm expecting precise timing events to be included in spans. For example, the StackExchange Redis client instrumentation adds events for each step in the command-processing pipeline:

Enqueued
Sent
ReponseRecieved

(see: RedisProfilerEntryToActivityConverter)
This information is critical for diagnosing performance bottlenecks around Redis use.

I'd like to see logging capabilities: system, custom, and exceptions.
I was able to attach them to the current Activity and send them to Jaeger here: https://github.com/open-telemetry/opentelemetry-dotnet/issues/1739#issuecomment-777841656
I tried to use the same approach for NR:
.AddNewRelicExporter(options => {
    options.ApiKey = "my-key";
    options.ExportProcessorType = ExportProcessorType.Batch;
})

I was hoping to at least get an error message when an exception occurs but all I get is this

I also tried to manually add tags like this
{ "error.message", data.Exception }

and
Activity.Current.SetTag("error.message", data.Exception);

About error logging.
According to the OpenTelemetry spec it has these fields
attributes["error.code"]
attributes["error.id"]
attributes["error.message"]
attributes["error.stack_trace"]

If I add my exception like this
activity.SetTag("error.message", data.Exception.Message)
        .SetTag("error.stack_trace", data.Exception.StackTrace);

then NR actually sees the stack trace but refuses to get the message

I tested the same code on Zipkin and Jaeger and both take my fields as expected. It looks like a bug.

Hi @iSeiryu thank you for experimenting with different options for getting the information you want sent to New Relic.

I'd like to see logging capabilities: system, custom, and exceptions.

This is something on New Relic's radar, but is not currently supported by this exporter. In the meantime you should still be able to send your logs to New Relic using the methods defined in our log management getting started documentation.

I was hoping to at least get an error message when an exception occurs but all I get is Unspecified error

New Relic gets error information based on the span specifications where error information is added to otel.status_code and otel.status_description, which is what the Jaeger exporter is supposed to do as well. The New Relic exporter currently uses otel.status_description to define an error.message tag. You should be able to use the SetStatus api to control both the status code and status description for the span. There is an extension method in the OTel SDK for .NET that can help you with setting this status code.

If I add my exception like this
activity.SetTag("error.message",     data.Exception.Message)
       .SetTag("error.stack_trace", data.Exception.StackTrace);

then NR actually sees the stack trace but refuses to get the message

This is a result of New Relic using otel.status_description to create an error.message tag for you, so New Relic is treating error.message as a tag that would be ignored if it was directly set on a span. The list of all reserved tag names in use by the exporter can be seen here.

Is there any provision for associating events with a span in NewRelic? I'd be happy to do some custom work with my exporter and telemetry to shape the data to what NewRelic needs, but I don't see a way to get the associated information in there.
In my specific case, I want to know how much time in a Redis interaction was spent on the network. Visually, this could be splitting the span into sub-activities, or otherwise delineating sections of time between key events. Any suggestions on how we might do this?

For everyone wanting to see their events on spans within New Relic, there is a new option that you may want to consider. Instead of using this exporter to send your data to New Relic, you can send your data to New Relic using the OTLP exporter provided by the .NET OTel SDK. We’re currently running a pre-release for our native OTLP endpoint, which includes support for sending events on spans to New Relic. The events on spans are currently available to query via NRQL using something like SELECT * FROM SpanEvent where trace.id = '<traceId>'.
Here's the sign-up form if you’re interested.


Wrong color panel in setting.json

Issue Type: Bug
I added
  "workbench.colorCustomizations": {
    // "editorIndentGuide.background": "#2ac285",
    "activityBar.background": "#5a1515",
    "activityBar.activeBackground": "#4e0606"

  },

in my settings.json
now on hovering over #4e0606, I get the color panel of #5a1515  and I also separated both lines with 10 empty lines in between but still the same thing happens
VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:32:10.090Z)
OS version: Linux x64 5.8.0-40-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-6006U CPU @ 2.00GHz (4 x 1963)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: unavailable_offvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 1

Memory (System)
7.67GB (1.29GB free)

Process Argv
--no-sandbox --unity-launch --crash-reporter-id 38b71edf-6167-42ed-9e3c-25ff294e3f9a

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

Extensions (5)

Extension
Author (truncated)
Version

es7-react-js-snippets
dsz
3.1.0

gitlens
eam
11.1.3

prettier-vscode
esb
5.8.0

better-cpp-syntax
jef
1.15.5

JavaScriptSnippets
xab
1.8.0

A/B Experiments
vsliv368:30146709
vsreu685:30147344
openlogontheside:30221877
python383:30185418
pythonvspyt617:30244266
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30211402
wsl2promptcf:30224613
pythonvsdeb440:30248342
unusedpromptcf:30224611
folderexplorer:30224614
openfilemenucf:30224648
pythonvsded773:30248341
pythonvspyt875:30251590

I'm not able to reproduce. Is it always reproducible for you?

Not often ..this was the second time I got it like this, last was around 1 week ago but, that time there was too much load on the system, so I thought that its because of that, but this time only vscode was open and nothing else running

@aeschli
Check out this comment https://github.com/microsoft/vscode/issues/115512#issuecomment-771276211


Missing key(s) in state_dict: "roberta.embeddings.position_ids".

Hi there,
when I try to start the detector (python -m detector.server detector-base.pt), I obtain the error: Missing key(s) in state_dict: "roberta.embeddings.position_ids"..
How can I solve this and play around with the detector?
Thanks
Precondition
I downloaded (and tried with) both detector-base.pt and detector-large.pt. Either way, I get the same error. I can see that in previous issues, people correctly started the detector, so maybe there is an issue with the .pt files I am downloading.
Full execution log
$ python -m detector.server detector-base.pt

Loading checkpoint from detector-base.pt
Some weights of the model checkpoint at roberta-base were not used when initializing RobertaForSequenceClassification: ['lm_head.dense.weight', 'lm_head.layer_norm.weight', 'lm_head.dense.bias', 'roberta.pooler.dense.bias', 'lm_head.bias', 'lm_head.decoder.weight', 'roberta.pooler.dense.weight', 'lm_head.layer_norm.bias']
- This IS expected if you are initializing RobertaForSequenceClassification from the checkpoint of a model trained on another task or with another architecture (e.g. initializing a BertForSequenceClassification model from a BertForPreTraining model).
- This IS NOT expected if you are initializing RobertaForSequenceClassification from the checkpoint of a model that you expect to be exactly identical (initializing a BertForSequenceClassification model from a BertForSequenceClassification model).
Some weights of RobertaForSequenceClassification were not initialized from the model checkpoint at roberta-base and are newly initialized: ['classifier.dense.bias', 'classifier.out_proj.bias', 'classifier.dense.weight', 'classifier.out_proj.weight']
You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.
Traceback (most recent call last):
  File "/opt/anaconda3/envs/detector/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/opt/anaconda3/envs/detector/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/Users/user/workspace/stanford/gpt-2-output-dataset/detector/server.py", line 120, in <module>
    fire.Fire(main)
  File "/opt/anaconda3/envs/detector/lib/python3.9/site-packages/fire/core.py", line 141, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/opt/anaconda3/envs/detector/lib/python3.9/site-packages/fire/core.py", line 475, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/opt/anaconda3/envs/detector/lib/python3.9/site-packages/fire/core.py", line 691, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "/Users/user/workspace/stanford/gpt-2-output-dataset/detector/server.py", line 89, in main
    model.load_state_dict(data['model_state_dict'])
  File "/opt/anaconda3/envs/detector/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1604, in load_state_dict
    raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for RobertaForSequenceClassification:
	Missing key(s) in state_dict: "roberta.embeddings.position_ids".
	Unexpected key(s) in state_dict: "roberta.pooler.dense.weight", "roberta.pooler.dense.bias".

Hi, the code is pretty old at this point and you will need to pin an older version of transformers (because I didn't put an upper bound in requirements.txt). In #35, there are some reports that installing transformers==2.9.1 fixes the problem, and 2.1.1 was the latest version when the model was published in Nov 2019. Will close this in as duplicate of #35.


Xformers for A100

Can you help me locate the proper code in order to run the notebook on the colab + GPU models
I believe I will need a precompiled xformers wheel.

sure
install this one for A100
%pip install https://github.com/camenduru/stable-diffusion-webui-colab/releases/download/0.0.15/xformers-0.0.15+e163309.d20230103.ColabProA100-cp38-cp38-linux_x86_64.whl

i will use this for the next update so i if it's detect A100 it will install xformers wheels for A100 instead
  s = getoutput('nvidia-smi')
  if install_xformers:
    if 'T4' in s:
      %pip -q install https://github.com/camenduru/stable-diffusion-webui-colab/releases/download/0.0.16/xformers-0.0.16+814314d.d20230118-cp38-cp38-linux_x86_64.whl
      !pip -q install --pre triton
    if 'A100' in s:
      %pip -q install https://github.com/camenduru/stable-diffusion-webui-colab/releases/download/0.0.15/xformers-0.0.15+e163309.d20230103.ColabProA100-cp38-cp38-linux_x86_64.whl

But you need to wait for people compiling xformers 16 for A100


Make a list of UX bugs in application

There are several. Spend 1-4 hours making a list of issues that should be fixed.
Example: When you resolve a question, that isn't updated in the question index immediately.

Cannot update during an existing state transition (such as within render). Render methods should be a pure function of props and state.


The wording in the Mandatory template for info.description is unclear

Problem description
The wording in the Mandatory template for info.description is unclear.
Which specific authorization flows are to be used will be determined during onboarding process, happening between the API Client and the Telco Operator exposing the API, taking into account the declared purpose for accessing the API, while also being subject to the prevailing legal framework dictated by local legislation.

Expected behavior
At a minimum add a the before onboarding process or use the plural onboarding processes if that was the intent.
- during onboarding process
+ during the onboarding process

Alternative solution
Alternately, split this into two sentences.
"The specific authorization flows to be used will be determined during the onboarding process between the API client and the Telco operator exposing the API. This determination will consider the declared purpose for accessing the API and be subject to the prevailing legal framework dictated by local legislation."
Additional context
We've added this Mandatory text to QoD and it isn't clear.
I'm happy to create a PR and discuss further.

During the ICM meeting on 17. July we decided to change info.description after the release


Added a test thing

Hey I finished this story it is ready to be merged into the main application

no


Audio classification functionality

HuggingFace audio classification using their pipeline
Adding general speech emotion recognition code
Testing and documentation for basic classification of emotions

Codecov Report
Attention: Patch coverage is 90.90909% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (release_040@dc9d0c5). Learn more about missing BASE report.

Files
Patch %
Lines

...tasks/classification/speech_emotion_recognition.py
85.71%
6 Missing :warning:

Additional details and impacted files
@@              Coverage Diff               @@
##             release_040      #76   +/-   ##
==============================================
  Coverage               ?   87.46%
==============================================
  Files                  ?       46
  Lines                  ?     1691
  Branches               ?        0
==============================================
  Hits                   ?     1479
  Misses                 ?      212
  Partials               ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


BUG: Unable to buy any token except ETH on ARB UNI V3 TWAP BOT. see Loom

See Loom Recording here: https://www.loom.com/share/82b69a6c858f4a488c1676866b839c0e?sid=acf7b64b-d7ad-49bd-acfc-623767414d21

Fixed with https://github.com/VolumeFi/palomabot/pull/344


GROK-12873: Chord viewer: help page created

Created a help page for Chord viewer.

Will deal with lint errors and re-create the pull request


GUACAMOLE-1503: Japanese Character input cannot be switched By full-width half-width key.

Fixed so that full-width and half-width keys work correctly and Japanese input switching works.
Hope to include it in the next release. Thank you.

I'm really sorry. I wasn't able to see the exchanges of past issues.（GUACAMOLE-520,GUACAMOLE-951)
Also, some change requests are mistaken.
I would like to confirm the contents again and send a separate pull request.
I canceled this pull est
What should I do now?

I didn't comment in particular, so I will close it. I apologize to you for a fuss over.


Is it possible to inject using "useInitializer" when method includes swift pure protocols?

I have the following initializer
 init(database: DatabaseProtocol, deserializerFactory: DeserializerFactory ) {
        self.database = database
        self.deserializerFactory = deserializerFactory
}
and I try to inject parameters using
definition.useInitializer("initWithDatabase:deserializerFactory:") {
         (initializer) in

         initializer.injectParameterWith(self.dataStoreAssembly.database())
         initializer.injectParameterWith(self.dataStoreAssembly.deserializerFactory())
}
So far I understand, I should add @objc to DatabaseProtocol. Problem is that I can't do this since it has members that can't be represented in objective c

Hello @claudioredi !
You can declare your initializer as:
 dynamic init(database: DatabaseProtocol, deserializerFactory: DeserializerFactory ) {
        self.database = database
        self.deserializerFactory = deserializerFactory
}

Also please ask these kinds of questions on StackOverflow's Typhoon channel - its very well indexed by Google and so helps other users in future.


Request support for eMylo WiFi&RF 2 Gang

Config
filename: emylo_wifi_and_rf_2gang.yaml
name: eMylo 2 gang switch
products:
  - id: jupECyrdMrUifHd8
    name: eMylo WiFi&RF 2 Gang
primary_entity:
  entity: switch
  name: Switch 1
  dps:
    - id: 1
      name: switch
      type: boolean
secondary_entities:
  - entity: switch
    name: Switch 2
    dps:
      - id: 2
        name: switch
        type: boolean

There are already 2 gang switches that should work

ok, just thought of having the branded one and as an exercise of setting it up on my own. Thanks anyway

Actually, after checking more closely, all the dual switches have timers and/or other config options, there was no config for simple two switches and nothing else.
Branding is only useful with a product id to which it applies, or to differentiate more complex configs. This one is so simple it will certainly match dozens of other devices, so branding is not useful for the filename.


Should have all warnings show by default

Looks like someone else eventually added this flag in the meantime - sorry Mez :)


Implement /loop command

Since we've updated to wavelink==2.0, we can now use its new loop feature.
/loop command has to work like a switch: if loop is off, then song must be set on loop, and otherwise the loop must be disabled.

Documentation for the Queue.loop command: link
There is also a Queue.loop_all function, so you might as well add a /loop_all command


Move SMS line API calls to intermediate states

Still getting bitten by the double calls creating duplicates in Snappy Bouncer. Thankfully they 409 the double POST so no duplicates in Snappy.

@imsickofmaps Please review.

:+1:


Add trackInlineScripts to BrowserConfig

Goal

trackInlineScripts is supported on the browser and should be reflected in the TypeScript types (docs), but is not represented in the .d.ts file.
Design

This pattern matches all the other "browser only" configuration options.
Changeset

Added trackInlineScripts to BrowserConfig.
Testing

N/A, just a TypeScript definition.

Thanks @blimmer, we'll take a look into this.

Thanks @xander-jones. I noticed the backlog tag got added, which looks like it's used primarily on issues. Just a heads up that this is a PR that fixes the problem 😄

Our backlog tag is used to signify issues & PRs which we're going to be taking a look into. No worries though, we know it's a PR 😄 . There are a few additional tasks that we need to do beyond merging  so we use this tag to help track which ones we need to work on.

Thanks @blimmer. In order to get the tests to run on our private infrasctructure, I've opened up https://github.com/bugsnag/bugsnag-js/pull/1102. This includes your changes and a small addition to the tests.
Closing in favour of #1102.

Hey @blimmer, this has been added in https://github.com/bugsnag/bugsnag-js/releases/tag/v7.5.1

Thank you for the mention!


sites and datasets should resolve from

virtualflybrain.org/site/{some site short_form}
virtualflybrain.org/dataset/{some dataset short_form}
@robbie1977

rules added to iri routing:
http://VirtualFlyBrain.org/dataset/Jenett2012
http://VirtualFlyBrain.org/site/FlyLight


fix typo

copy paste error i guess

I think the reason this wasnt caught is because the two functions aren't even used


Assitive technology testing - several improvements

The page here:
https://accessibility-manual.dwp.gov.uk/best-practice/assistive-technology-testing
should have a title of (missing an 's):
Assistive technology testing
I think i've you'd been using tools like this that spelling error would be caught:
https://accessibility.civicactions.com/posts/how-we-scale-inclusive-website-content-with-automated-testing-and-open-source-tools
I do this myself sometimes, so noticed:
"screenreaders" should all be "screen readers"
The paragraph:
Every page should be tested using common screenreaders. If you’re using Apple devices you can use Voiceover for free, and if you’re using Windows then you can use NVDA for free.
Would be improved (I think), if it were:
Every page should be tested using common screen readers. If you’re using Apple devices VoiceOver is built-in. If you’re using Windows for testing we recommend installing the open source [NVDA](https://www.nvaccess.org/) screen reader for free. NVDA has become one of the [most popular screen readers](https://webaim.org/projects/screenreadersurvey8/) and although it is less powerful than JAWS, it is better for catching many accessibility errors.
There is still a preference for JAWS, as it is what governments are used to testing for. There are good reasons why testers should be focusing on NVDA though.
This is mostly in /app/views/best-practice/assistive-technology-testing/partials/screenreader-testing.md

Thanks @mgifford changes made. Changed all instances of screenreader to screen reader. I think I picked up the habit from Ashleigh in the GDS Accessibility Personas so could be worth us raising it there to get it changed also.

Updated in v1.1.0


Is Edgware train supported?

Edgware is stable, but README doesn't says if it is supported.

hi @malafeev would you be able to contribute test for it? Add it to makefile and then use travis stage to execute it.

sure, if it's not urgent, I can do it tomorrow :)

@pavolloffay why Camden was removed from build?
Readme says Camden is supported.

It's quite old and I guess spring-stream would not work with it. cc @gytis

@pavolloffay if you want to align with RHOAR Dalston is more up to date than Camden.
Also, it is used by Artemis Spring Cloud Stream binder. And because opentracing-spring-messaging-it is in the same project, integration tests which run stream with Artemis fail because of API differences between Camden and Dalston. I think Camden could still be supported for java-spring-cloud as long as it's not mixed with Artemis binder.
In general I think it would be good to move opentracing-spring-messaging to the separate repo similarly like java-jms and add it as a dependency to java-spring-cloud.


Make better use of default methods

Turn all the "high level" / "convenience" methods into default methods, so implementations don't need to duplicate them

Fixed with 3.2


Command-line option class-log-level should be allowed more than once

I think it would be better if I could write:
-cll firrtl.transforms.CheckCombLoops:Info -cll firrtl.transforms.DeadCodeElimination:Info instead of having to write -cll firrtl.transforms.CheckCombLoops:Info,firrtl.transforms.DeadCodeElimination:Info

I think that would be better to but AFAIK scopt does not support that idiom, I've tried and could not find a way.

It looks like there's an unbounded() option: https://javadoc.io/doc/com.github.scopt/scopt_2.12/3.7.0. I think we should switch to allowing arguments multiples times rather than using commas

FWIW, this is marked as unbounded in the options refactor of #764/#765. In fact, every option is marked as unbounded for the reason that annotation/option validation only happens when a view is attempted and it seems logical to not do any type of early checking (which is technically what a lack of unbounded does).
Note that currently both styles are supported as the option argument for this is Seq[String] (which scopt will split on , and we further, manually subdivide by :) and this is marked as unbounded.
Is there a convention that we want to adopt here or do we want to support both?

Fixed via #1005.


Deprecate annual membership

Why not fix it? Maybe simply make it 80% cash-back? Just need to store referrer and registrar info somewhere, restore/reuse them when membership expires.

Anyway, IMHO it shouldn't be decided by developers alone. Having multi-level membership structure is a good pricing strategy, we'd better let stake holders make decisions on how to set it up. Labeling this ticket "NextRelease" without any description is a bit rushing.

Agreed.

The committee has raised the annual membership fee significantly in order to deactivate annual upgrades for now

FYI theoreticalbts wrote a new post: [Why annual memberships are going away] (https://bitsharestalk.org/index.php/topic,21846.0.html)

I meant to link that here, thanks.

Above commit allows you to replay the chain and log annual member registration events


Missing path parameters in parent

This was pointed out to me by @kgamecarter
Example YAML:
swagger: '2.0'
info:
  title: Reference parameters
  version: v0.0.1
paths:
  '/orders/{orderId}/order-items/{orderItemId}':
    parameters:
      - $ref: '#/parameters/OrderId'
      - $ref: '#/parameters/OrderItemId'
    delete:
      summary: Delete an order item
      description: >-
        This method allows to remove an order item from an order, by specifying
        their ids.
      responses:
        "204":
          description: No Content.
        default:
          description: Default response
          schema:
            $ref: '#/definitions/Error'
definitions:
  Error:
    type: object
    properties:
      message:
          type: string
parameters:
  OrderId:
    name: orderId
    in: path
    description: Identifier of the order.
    required: true
    type: string
    format: uuid
  OrderItemId:
    name: orderItemId
    in: path
    description: Identifier of the order item.
    required: true
    type: string
    format: uuid

Generated code:
public interface IReferenceparameters
{
	/// <summary>
	/// This method allows to remove an order item from an order, by specifying their ids.
	/// </summary>
	[Delete("/orders/{orderId}/order-items/{orderItemId}")]
	Task OrderItems();
}

missing orderId and orderItemId path parameters

This should be fixed in this pull request by @kgamecarter


[spi_device] Add config knob for tracking last_read_addr in Passthrough

Discussed in https://github.com/lowRISC/opentitan/pull/14590
Current last_read_addr tracks the last byte host read in Flash / Passthrough mode except it hits the mailbox.
This issue is to implement the config knob, so that SW can select if HW tracks the address or not in passthrough mode.

CC: @weicaiyang
@a-will Do you think it is helpful the HW tracks which address host read in passthrough mode? Current hw supports it by reading last_read_addr. However, DV support may be difficult. If not much helpful, then we may remove the feature entirely (actually probably adding conditions)

@a-will Do you think it is helpful the HW tracks which address host read in passthrough mode? Current hw supports it by reading last_read_addr. However, DV support may be difficult. If not much helpful, then we may remove the feature entirely (actually probably adding conditions)

I'm not aware of any significant use case for it, nor any feature request from known users. We're likely fine to remove it.

Ah OK. Good.

On Aug 26, 2022, at 3:15 PM, Alex Williams @.***> wrote:
@a-will https://github.com/a-will Do you think it is helpful the HW tracks which address host read in passthrough mode? Current hw supports it by reading last_read_addr. However, DV support may be difficult. If not much helpful, then we may remove the feature entirely (actually probably adding conditions)
I'm not aware of any significant use case for it, nor any feature request from known users. We're likely fine to remove it.
—
Reply to this email directly, view it on GitHub https://github.com/lowRISC/opentitan/issues/14612#issuecomment-1229005832, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJDG3QL4DMO7SA4ELAPO73V3E6X7ANCNFSM57XOJ4EQ.
You are receiving this because you were assigned.

I already aligned the scoreboard with the behavior of last_read_addr in passthrough.
I'm fine to either remove it or keep it.

OK then. Let me close this. I may refactor this part of the code later (to consolidate all address calc. inside spid_readbuffer.sv module)


Whichever page was active the home button was highlighted and underlined

Can we see your output

Yes Sir

Ok send me screen shot

Sir, the above screenshot is of the output of the changes that I did.
Do I need to send the screen shot of the code also?

No need....now it's looking fine 🙂


API-4339: Get topic by topicName and ClientId endpoint added with tests

I'm not sure about the query. Other than that looks good to me.


How to retrieve a date value

@jamalex Thanks so much for this! I am trying to retrieve a date value from a collection row and get a value like <notion.collection.NotionDate object at 0x10ce17510> - is there a way to convert this to a date?

@chrishumphries see my script below on how to get a count of stuff due today in my todo list. If you're in a loop, you can access the date by firing the functions due_date.start.
from notion.client import NotionClient
from datetime import datetime

client = NotionClient(token_v2="...")
page = client.get_collection_view("...")
collection = page.collection.get_rows()
today = 0

for c in collection:
    due_date = c.due_date
    if 'start' in dir(due_date):
        if c.status != 'Completed' and due_date.start <= datetime.today().date():
            today = today + 1
    print(today)

Hope that helps.

How do I convert notion.collection.NotionDate to a datetime?
And vice-versa please!


As the user, I want to group similiar content together

Delete reason: ...

Closing this in favor of other features for now


cargo clippy to fix Rust code style guidelines

Using the include field in the Cargo.toml the crate is now 138Kb vs 155kB.
Run cargo clippy to fix Rust styles:

Add the is_empty() method to the ChunkState struct. Clippy warning
Use '' instead of "" in contains() and split() Clippy warning
Remove Hash derivation in the Hash struct since PartialEq is implemented Clippy warning
Remove a needless borrow since the key is going to be dereferenced immediately by the compiler Clippy warning

Thanks for the cleanup. My past experiences with Clippy are that it has a lot of false positives in this crate. (Or I should say, things that I would personally prefer not to change 😄 ) But things like avoiding unnecessary &'s are good fixes, let's definitely do those.

Thank you so much for the comprehensive comments, very helpful and well done. I should have made the requested changes, I hope they meet the specifications.

Congrats again on the result and implementation, really good work. If I may say so, maybe you could specify in the CONTRIBUTING.md that the code has already been checked by cargo clippy, in order to avoid not very useful PR like this one.


wireplumber plugin should be able to view/control the audio input (source), not just the audio output (sink)

It is great that by default, the wireplumber plugin binds itself to the volume level of the default audio sink for wireplumber, via this line in src/modules/wireplumber.cpp:
  g_signal_emit_by_name(self->def_nodes_api_, "get-default-node", "Audio/Sink", &defaultNodeId);

However, it would also be nice to have the wireplumber plugin work for the default input level as well.  That is, the default Audio/Source instead of the Audio/Sink.  In particular, when on a call, i might want to use the waybar to both see and adjust my mic level.
Please consider adding a configuration option direction to the wireplumber plugin that can be either source or sink (defaulting to sink).  Then a user who wants to control their mic from the waybar should be able to just add a second copy of the wireplumber plugin with direction set to source.

I had originally phrased this as asking the wireplumber plugin to be configurable enough to select "any other device" but i think that might be too much flexibility.
If you really wanted to aim for more flexibility, instead of naming the config variable direction you could name it perhaps node, and it could default to  something that means "the default audio sink".  It should be easy to choose instead "the default audio source".  But what you then do with other strings i don't really know.  there are so many different (and overlapping) possible labels and identifiers within pipewire that you could potentially try to match on to select a node that i am dizzy thinking about it.  (for a sense of what might be matchable, consider the output of wpctl inspect @DEFAULT_AUDIO_SINK@).
So if you want to preserve room for more flexibility for targeting arbitrary nodes, without committing to any particular search/match pattern amid the bewildering options, you could just:

reserve two keywords that mean "default audio source" and "default audio sink", and
make "default audio sink" the default, and
reject any other string for now.


Publish to Maven local.

Signed-off-by: dblock<EMAIL_ADDRESS>Description of changes:
Workaround to build and publish to maven local.
CheckList:
[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Superseded with #8


[FEATURE] Add mod name to custom items

User Story
As a mod author I want to know the mod name of of a custom Item/Piece/Prefab so that I can display it.
Envisioned Solution
When a mod is adding an Item/Piece/Prefab it has always to provide the name of the mod. Additionally there needs to be a way to get all added instances, currently all lists are internal with no access methods. This should be a breaking change so everyone is forced to add the mod name, otherwise it would take way to long before it would be used. With H&H this should be  a good opportunity anyway.
Additional context
I am the author of VNEI and would like to display the mod name and more important, make it possible to search with @ for a specific mod. When it is embedded here not everyone has to write individual support for VNEI and I don't have to support a lot of other mods individually.

Hey,
actually I have plans for this already and did some thinking about it. I need to check if there is an automated way to to this. Maybe getting the executing Assembly and query BepInEx' chainloader. I really would like to have this as non-breaking since I still got hope that Jötunn can mitigate at least some H&H changes so that old mods which will not be updated any more can still work in some way.

mostly done


Change default charset for UPID texts to latin-1

Current default charset is ascii but I think latin-1 would make more sense because that one is lossless.
Lossless conversion is essential for text fields that may contain binary data such as the ATSC content_id. With latin-1 it is always possible to recover the original values.

Richard,
I really appreciate the effort but I need  to keep ascii as the default, latin-1 is not mentioned anywhere in the spec.
I am going to keep this change, this is good idea,

            "content_id": self.bitbin.as_charset((self.upid_length - 4) << 3, charset),

So you can set it to latin-1 and and it will give you what you need.

For example the content_id field in the ATSC_content_identifier is allowed to contain binary values, see ATSC A/57B (4.2 ATSC Content Identifier, content_id):

The identifier may be any combination of human readable and/or binary values

With ascii this would break, with latin-1 there is no loss while still maintaining compatibility with ASCII input. That makes latin-1 the better default choice.
See also this Hackernews comment by garethrees:

There is a particular use case which leads to frustration with Python 3, if you don't know the latin1 trick.
The use case is when you have to deal with files that are encoded in some unknown ASCII-compatible encoding. That is, you know that bytes with values 0–127 are compatible with ASCII, but you know nothing whatsoever about bytes with values 128–255.
The use case arises when you have files produced by legacy software where you don't know what the encoding is, but you want to process embedded ASCII-compatible parts of the file as if they were text, but pass the other parts (which you don't understand) through unchanged (for example, the files are documents in some markup language, and you want to make automatic edits to the markup but leave the rest of the text unchanged). Processing as text requires you to decode it, but you can't decode as 'ascii' because there are high-bit-set characters too.
The trick is to decode as latin1 on input, process the ASCII-compatible text, and encode as latin1 on output. The latin1 character set has a code point for every byte value, and bytes with the high bit set will pass through unchanged. So even if the file was actually utf-8 (say), it still works to decode and encode it as latin1, and multi-byte characters will survive this process.
The latin1 trick deserves to be better known, perhaps even a mention in the porting guide.


Update glossary.html by adding missing whitespace after colon for AKA list

This pull request implements miscellaneous changes to the layout of glossary pages by adding missing whitespace after the colon in the list of "also known as" values.

Before

After

/area web-development
This changes lots of entries, so although it's a small fix, it's worth having.
/lgtm
/approve

Ideally: we make that string localizable.


move cni statefile to subdir and add migration functionality in json store initialization

Reason for Change:

Issue Fixed:

Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests

Notes:

/azp run


app.get("myComponent") returns undefined

I have loaded my custom component in the connector server when i try to access this component via
app.get("myComponent")
it returns undefined.
app.configure('production|development', 'connector', function() {   app.load("myComponent", myComponent); });
while this code app.components.myComponent working fine.

yeah, you should set it before use it
var cmp = new myComponent();
app.set('sessionService', cmp);


Supermarket link problem

I don't really know how to report this, but the link to this source is broken in the supermarket.chef.io portal, as the "View Source"/"View Issues" redirects to https://github.com/chef-cookbooks/tomcat

Thanks! You've reported in exactly the right place. I've fixed this.


Add nix flake build

To more easily incorporate this in a package build process, would love to be able to build it off of - and expose it to - a flake.
This flake doesn't work currently, because flakes can't fetch information from the internet; the flake refuses to resolve github.com during the build process.
Any help here would be appreciated.

flakes can't fetch information from the internet

you'd likely have to parse zigmod.lock and reimplement the core parts of Zigmod in Nix language so that the build script sees that theyre already downloaded


Develop

Codecov Report

Merging #191 (f680a67) into master (e2598b5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   96.65%   96.65%
=======================================
  Files          22       22
  Lines        1077     1077
=======================================
  Hits         1041     1041
  Misses         36       36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2598b5...f680a67. Read the comment docs.


Implement group_by_columns argument for relevant tests

This is a:

[ ] documentation update
[ ] bug fix with no breaking changes
[x] new functionality
[ ] a breaking change

All pull requests from community contributors should target the main branch (default).
Description & motivation
Description
This PR closes #450 and #447 by implementing an optional group_by_columns argument across many of the core tests in dbt-utils. Specifically, I extended this check to allow of the relevant tests. Collectively:

equal_rowcount()
fewer_rows_than()
recency()
at_least_one()
not_constant()
sequential_values()
non_null_proportion()

For example, to test for at least one valid value by group, the group_by_columns argument could be used as follows:
  - name: data_test_at_least_one
    columns:
      - name: field
        tests:
          - dbt_utils.at_least_one:
              group_by_columns: ['grouping_column']

Motivation
The motivation for this PR is outlined as greater length in this blog post. In short:

Some data checks can only be expressed within a group (e.g. ID values should be unique within a group but can be repeated between groups)
Some data checks are more precise when done by group (e.g. not only should table rowcounts be equal but the counts within each group should be equal)

Implementation
In implementing this PR, I considered a few core principles:

Make this feature as unobtrusive and isolated as possible with respect to the macros broader implementation
Follow standard DRY principles (e.g. specifically, render needed text as few times as possible)
Implement consistently across macros

With these principles in mind, the majority of implementations are like that of the recency macro (L7-11)  where all relevant SQL strings are precomputed:
{% set threshold = dbt_utils.dateadd(datepart, interval * -1, dbt_utils.current_timestamp()) %}
{% if group_by_columns|length() > 0 %}
  {% set select_gb_cols = group_by_columns|join(' ,') + ', ' %}
  {% set groupby_gb_cols = 'group by ' + group_by_columns|join(',') %}
{% endif %}

The main deviations to this were the sequential() macro (requiring a window function) and the equal_rowcount()/fewer_rows_than() (requiring joins)
Notes

A "test" PR for initial design feedback is discussed in #451. Due to significant changes to dbt-utils, I'm sending this as a fresh PR, but the prior issue may add additional context.
Per the checklist below, I do not believe that it is relevant to change the README.md for this PR since it only demonstrates simpler examples of macro usage. Please let me know if you would like me to do so.

Checklist

[x] I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)

[x] BigQuery
[ ] Postgres
[ ] Redshift
[ ] Snowflake

[x] I followed guidelines to ensure that my changes will work on "non-core" adapters by:

[x] dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
[x] using the limit_zero() macro in place of the literal string: limit 0
[x] using dbt_utils.type_* macros instead of explicit datatypes (e.g. dbt_utils.type_timestamp() instead of TIMESTAMP

[x] I have updated the README.md (if applicable)
[x] I have added tests & descriptions to my models (and macros if applicable)
[x] I have added an entry to CHANGELOG.md

YAY. Thanks @emilyriederer - I will dig into this probably next week?

Thanks for reviewing, @joellabes !
I fixed the simpler comma issue and outlined a few options for the other.
Since it feels like we are close, I'll ask one bigger picture question: Is there any better way I should document these changes?
This felt like too small of a feature to note on the README that discusses macro usage. However, as it stands, this will be quite a "hidden feature" that users only learn if they read the underlying source code for the macros. (And, even there, there's no comment to define what that argument does so they'd literally have to parse it out for themselves.)

@emilyriederer thanks for doing the research! have replied on that comment above.

This felt like too small of a feature to note on the README that discusses macro usage

Nah I think this is a big deal! To save a ton of repeated documentation, I would recommend documenting it all once at the list of the generic tests, and then saying something like "This test also supports the group_by parameter; see group by for details". (that anchor obviously doesn't work in this issue)

Thanks @joellabes ! I've added that section to the README along with other changes. Let me know if you want either more/less detail.

Thanks for the review, @joellabes ! Excited to have this merged and to start using 🤓

I just reverted it as I'll put it onto the 1.0 branch, not main - I think it'll get very confusing if it's in the readme now but doesn't come out for a while longer! Sorry for the confusion 😩 will sort it out properly when I'm back online next week 🙇♂

(as with all git installs, you'll be able to install that branch directly if you want to get ahead of the curve though!)

Totally makes sense - thanks for the headsup!

@emilyriederer

Can this feature be used to test that the count of groups are monotonically increasing over time? SELECT COUNT(*) FROM table GROUP BY (month-year, segment)
Can this feature be used to test that the count of "groups" and count of rows in the groups are the same across two tables? SELECT COUNT(*) FROM table_a GROUP BY (month-year, segment) , SELECT COUNT(*) FROM table_b GROUP BY (month-year, segment)

Appreciate it!
Thanks!

Hi @mgcdanny - this feature extends the following checks:

equal_rowcount()
fewer_rows_than()
recency()
at_least_one()
not_constant()
sequential_values()
non_null_proportion()

Those all work the same as in dbt-utils, but they are now assessed separately for each group provided.
None of these compare between groups, so I don't believe any could accomplish your first question. However, I believe the second can be implement with equal_rowcount()


ContextMenu was not found in the UIManager

I have followed the instructions to set it up but getting this error on the simulator (iPhone 8, 13.5).

Configuration -
react-native-cli: 2.0.1
react-native: 0.61.1

It Worked. I have react-native link it before pod install. Thanks for the lib.


Some android devices are occasionally crashing

Hello,
I have in my Xamarin Insights dashboard sometimes the following exceptions:
System.ArgumentExceptionsavePoint is not valid, and should be the result of a call to SaveTransactionPoint. Parameter name: savePoint
Wrap
Raw
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () <0x00028>
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.m__0 (object) <0x0003f>
at Android.App.SyncContext/c__AnonStorey0.<>m__0 () <0x00027>
at Java.Lang.Thread/RunnableImplementor.Run () <0x0003f>
at Java.Lang.IRunnableInvoker.n_Run (intptr,intptr) <0x0003b>
at (wrapper dynamic-method) object.d3c36e1f-3031-484b-8259-29512134df11 (intptr,intptr) <0x0003b>
Any idea what could be causing this?

()


BFS in C++ graphs

BFS is missing in algorithms in C++ language. I know algorithms in C++ very well please assign me this issue i can code the complete algorithm.

can i close this issue ?


400 Bad Request

I've been trying out the xAPIWrapper for the first time but I keep getting this error in the browser console (XXXXX refers to my endpoint ID):
cloud.scorm.com/tc/XXXXX/statements:1
POST
https://cloud.scorm.com/tc/XXXXXX/statements 400 (Bad Request)

My authentication code is:
var conf = {
            "endpoint": "https://cloud.scorm.com/tc/XXXX/",
            "user": "XXXX",
            "password": "XXXXX"
        };
ADL.XAPIWrapper.changeConfig(conf);

I've used these same credentials with the tin can prototypes (http://tincanapi.com/prototypes/) and it works fine. Not sure what's going on?

Fixed the issue. It was a piece of rogue from elsewhere in my codebase.


A F# script that detects files that don't have EOL at EOF

@realmarv let's modify CI to include a call to this script and fail CI if there's any offending file.

@realmarv I see that your CI is hanging because it's asking for user input:
debconf: falling back to frontend: Readline
Configuring tzdata
------------------

Please select the geographic area in which you live. Subsequent configuration
questions will narrow this down by presenting a list of cities, representing
the time zones in which they are located.

  1. Africa      4. Australia  7. Atlantic  10. Pacific  13. Etc
  2. America     5. Arctic     8. Europe    11. SystemV
  3. Antarctica  6. Asia       9. Indian    12. US
Geographic area:

The way to workaround/fix this is to attach something in front of the apt install command that is causing trouble, like we do in geewallet: https://github.com/nblockchain/geewallet/blob/master/.github/workflows/CI.yml#L124

Last but not least: delete the EOL line (TODO) in ReadMe please.

Why did you rebase if there were no conflicts?

Why did you rebase if there were no conflicts?

Just to clean the commit history by squashing WIP commits. Shouldn't I do it?

Just to clean the commit history by squashing WIP commits. Shouldn't I do it?

Sorry I thought you were rebasing, not squashing. Rebasing is only needed when there are conflicts.

Last but not least: delete the EOL line (TODO) in ReadMe please.

Done


spec: document behavior of type switches containing type parameter cases

Specifically, document behavior when type instantiation leads to duplicate entries in the switch.
From conversation with @danscales:

I think you may want to specify that a type parameter can be one of the types used in the type(s) of a case, as long as the typeparam satisfies the type of x (based on its bound).   You may want to mention explicitly that there may be duplicate cases after instantiation of a generic function/method with type args, and that is fine.   So, then, the first case matched is chosen.  Duplicate cases are only checked before instantiation.

cc: @danscales

The proposal has this: https://go.googlesource.com/proposal/+/refs/heads/master/design/43651-type-parameters.md#generic-types-as-type-switch-cases


Multi Task per Worker

Hi,  Is there way to have multiple Task registered for each work.
Like calling build_fn multiple times to register multiple task.  I found that this can be done by registering multiple workers but don't want to waste resource

This should help https://github.com/geofmureithi/apalis/discussions/20

Thanks Yes.


[BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

Replace python built-in hash() function with hashlib md5, which is deterministic.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @tvalentyn
Went with hashlib instead.

@tvalentyn-- I can't seem to pass the codecov/patch report, but have added unit tests for the combiner that should go through the paths that are highlighted. Also,I think the other 3 failing tests failing for other merged PR's as well.

 And modified the unit test to confirm the expected error-- the error for this algorithm is an expected error, not a max error, so certain inputs will exceed the expected error.

ptal! i've added an optional import for mmh3, since mmh3 is significantly faster than md5.

Run Portable_Python PreCommit

LGTM, thanks a lot, @monicadsong !

thank you all for reviewing :)


Cross compilation with sbt 1.0

The plugin should cross compile with sbt 1.0.

Closed by https://github.com/47deg/sbt-microsites/pull/225


Refactor egress controller

Decouple ExternalIPPool controller and MemberList controller from Egress controller.
Signed-off-by: Xu Liu<EMAIL_ADDRESS>

Codecov Report

Merging #2824 (467be81) into main (1399ddf) will decrease coverage by 6.59%.
The diff coverage is 78.48%.

@@            Coverage Diff             @@
##             main    #2824      +/-   ##
==========================================
- Coverage   59.23%   52.64%   -6.60%
==========================================
  Files         284      286       +2
  Lines       23549    23614      +65
==========================================
- Hits        13949    12431    -1518
- Misses       8117     9801    +1684
+ Partials     1483     1382     -101

Flag
Coverage Δ

kind-e2e-tests
31.70% <0.00%> (-14.44%)
:arrow_down:

unit-tests
41.32% <79.43%> (+0.19%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.


Bug Report/Feature Request for vhost/fuzz mode

Bug:
fuzz mode: Doesn't work on Host Header.
Command:
gobuster.exe fuzz -u http://<IP_ADDRESS>/ -H "Host: FUZZ.domain.com" -b400,302 -w Subdomain.txt

Feature Request:
vhost mode: I don't know the internals of this module, If it's same as fuzz then better if -b or -s (or both) can be added.

Thanks, this is now fixed on the dev branch!


Ionic serve not working on OSX Serria ionic-app-script:Permission Deny

I have got a project working on Windows 10, I had transferred the project to my MacBook Pro running on OSX Serria and when I finish installing Node, Ionic, Cordova (all using sudo), when I try to run ionic serve the following error pops up.
** my ionic info **
Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.4
Ionic CLI Version: 2.1.17
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 0.0.47
ios-deploy version: 1.9.0
ios-sim version: 5.0.13
OS: macOS Sierra
Node Version: v6.9.2
Xcode version: Xcode 7.3.1 Build version 7D1014

Bennys-Mac:rlph Benny$ ionic serve

> ionic-hello-world@ ionic:serve /Users/Nizi/Desktop/Projects/Ionic/rlph
> ionic-app-scripts serve

sh: /Users/Nizi/Desktop/Projects/Ionic/rlph/node_modules/.bin/ionic-app-scripts: Permission denied

npm ERR! Darwin 16.1.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "ionic:serve" "--"
npm ERR! node v6.9.2
npm ERR! npm  v3.10.9
npm ERR! code ELIFECYCLE
npm ERR! ionic-hello-world@ ionic:serve: `ionic-app-scripts serve`
npm ERR! Exit status 126
npm ERR!
npm ERR! Failed at the ionic-hello-world@ ionic:serve script 'ionic-app-scripts serve'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the ionic-hello-world package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     ionic-app-scripts serve
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs ionic-hello-world
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls ionic-hello-world
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/Nizi/Desktop/Projects/Ionic/rlph/npm-debug.log
There was an error serving your Ionic application: There was an error with the spawned command: serve

My problem is solved apparently my ionic-app-script has no execution permission this command solved it
chmod a+x /Users/Nizi/Desktop/Projects/Ionic/rlph/node_modules/.bin/ionic-app-scripts


Update repo with new boilerplate names

Please verify the following:

[ ] Everything works on iOS/Android
[ ] npm test ava tests pass with new tests, if relevant
[ ] ./docs/ has been updated with your changes, if relevant

Describe your PR
Updates ignite boilerplate references in preparation for renaming those packages. I just wanted to get eyes on the code changes ahead of time to make sure everything looks good and I didn't miss anything.
Depends on:
https://github.com/infinitered/ignite-ir-boilerplate-andross/pull/235
and
https://github.com/infinitered/ignite-ir-boilerplate-bowser/pull/133

:tada: This PR is included in version 2.1.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat: filter inactive clusterQueues in scheduling

Signed-off-by: kerthcet<EMAIL_ADDRESS>
What type of PR is this?
/kind feature

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes https://github.com/kubernetes-sigs/kueue/issues/251
Special notes for your reviewer:

cc @ahg-g

PTAL @ahg-g when you have time.

Updated as advised.

squashed.

/lgtm
/approve


add bnb testnet deployment for teleportation, update docs

:clipboard: Related to #1034
Overview
Deploy Teleportation on BNB Testnet (L1) and update docs.
Changes
Describe your changes and implementation choices. More details make PRs easier to review.

Docs updated
BNB testnet deployment teleportation

https://github.com/bobanetwork/boba/pull/1045


add pytorch vision model wrapper for image classification tasks

Add a pytorch vision model wrapper, by re-using the one for tabular tasks, to the image classification task.
Note I needed to refactor several classes in order to fix circular dependencies (since image model wrapper now used some common functionality with tabular scenario), which as a byproduct also significantly reduced the size of the model_wrapper.py file.

Codecov Report

Merging #69 (128881f) into main (a2a4d44) will increase coverage by 1.10%.
The diff coverage is 77.04%.

:exclamation: Current head 128881f differs from pull request most recent head e33439b. Consider uploading reports for the commit e33439b to get more accurate results

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   68.35%   69.46%   +1.10%
==========================================
  Files          19       24       +5
  Lines        1204     1264      +60
==========================================
+ Hits          823      878      +55
- Misses        381      386       +5

Flag
Coverage Δ

unittests
69.46% <77.04%> (+1.10%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...odel/wrapped_classification_without_proba_model.py
33.33% <33.33%> (ø)

python/ml_wrappers/model/base_wrapped_model.py
55.55% <55.55%> (ø)

python/ml_wrappers/model/pytorch_wrapper.py
82.92% <66.66%> (-1.29%)
:arrow_down:

python/ml_wrappers/model/evaluator.py
80.64% <80.64%> (ø)

python/ml_wrappers/model/image_model_wrapper.py
93.10% <80.95%> (-6.90%)
:arrow_down:

.../ml_wrappers/model/wrapped_classification_model.py
88.63% <88.63%> (ø)

...thon/ml_wrappers/model/wrapped_regression_model.py
91.66% <91.66%> (ø)

python/ml_wrappers/model/__init__.py
100.00% <100.00%> (ø)

python/ml_wrappers/model/function_wrapper.py
80.85% <100.00%> (+0.41%)
:arrow_up:

python/ml_wrappers/model/model_wrapper.py
86.00% <100.00%> (+12.31%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Character sheet is not displaying correctly on any browser

This might be associated with https://github.com/Roll20/roll20-character-sheets/issues/12949
The sheets are essentially unusable at the moment.

Hello marie, im the RTI sheet author, the roll20 bug fix did not solve the issues
I submitted a PR to update the sheet to CSE, so it no longer uses the legacy sanitation

Hello marie, im the RTI sheet author, the roll20 bug fix did not solve the issues I submitted a PR to update the sheet to CSE, so it no longer uses the legacy sanitation

Thanks Mago! Displays correctly now. Glad you could fix it.


[Bug Report] Connecting banner overlaps logo on iOS integration build

Expected Behavior
No overlap on banner
Current Behavior
Connecting to celo banner overlaps logo

I believe this has been addressed


API design changes to InvariantParser

Based on API review, a few core suggestions were made:

Rename the InvariantParser class
Remove the bytesConsumed parameter and pass index by ref
Investigate splitting culture & encoding data
Rename methods so they are not all one overload of TryParse -- instead, have individual methods for TryParseByte, etc.
Rename utf8Text parameter to reflect the fact that it can accept any number of encodings

/cc @KrzysztofCwalina

I think these are done


docs: add star history and contributors in Readme

Description
What changes are made in this PR? Is it a feature or a bug fix?
Additional Information
Before submitting this issue, please make sure you do the following.

[x] Read the contributing guide
[ ] Added documentation related to the changes made.
[ ] Added or updated tests (and snapshots) related to the changes made.

We have standardized READMEs across out projects. Can look into adding something like this at some point (if we do, can give you credit).


cmd/go: If strip the windows binary with binutils it won't run.

What version of Go are you using (go version)?

$ go version
go version go1.20.2 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOHOSTARCH="amd64"
GOOS="windows"
GOVERSION="go1.20.2"
GCCGO="gccgo"

What did you do?
See https://github.com/jclab-joseph/issue-go-windows-strip-not-working
The file built with the go build were stripped through binutils.
The stripped file runs on linux, but not on windows.
I'd like to keep the debug files separate to reduce the size.
What did you expect to see?
It should work on Windows PC.
What did you see instead?

This doesn't seem like a cmd/go bug at all. If you're using binutils to modify a binary that runs, and it produces a binary that doesn't run, you should open an issue against binutils.
 It works fine except for go-lang .


Hidden/Lost progress feeback on re-run after correcting the issue

Description
After submitting a query with an issue (usually  mis-spelled name), we get an error as below:

The above is expected but after correcting the error and re-run, DBeaver is not  displaying the progress feedback  with the "Cancel" button.  We have to find other ways to kill the running query.  The following display that the query is still running:

The work around is to remember to close the "Result" tab and let DBeaver instantiate a new tab so that I can get back a normal progress feedback.
DBeaver Version
Community Edition 23.0
Operating System
Windows 11
Database and driver
Oracle
Steps to reproduce

Type in a query that should run a long time and deliberately mis-spell the table name.
Execute it.  You should get an error
Fix the mis-typed and re-execute.
The bug is that DBeaver is not surfacing the progress with the "Cancel" button.

Additional context
No response

DBeaver Progress Bug.pdf


poisson regresson in lightgbm

Thank you really very much for your amazing package!
Any plans to introduce:
a. poisson regression as objective?
b. Offset parameter like in poisson regression?
This would permit to handle variable exposure observations in count regressions

Please give me the definition of poisson regression as objective.
When I have free time, I'll add if possible.

Hi thank you very much for your reply. I think that regarding point one you can have a look to xgboost "poisson regression" as objective xgboost (see also the max_delta_step_parameter). Regarding the offset parameter it depends:
a. the gbm r package has an offset parameter explicity,
b. the approach used in xgboost to obtain the same result (well I got the same result in a similar applicaton) can be found in this SO question (http://stats.stackexchange.com/questions/223939/poisson-xgboost-with-exposure)[stackoverflow]

Is the loss definition this, right?
(from https://en.wikipedia.org/wiki/Poisson_regression)

I think so but I am not sure.

@henry0312 Using that formula provides no direct solution. You need to go for negative log-likelihood so gradient descent can be applied.
Therefore, you would need an exponential and you end up with:

Gradient: exp(pred) - label
Hessian (gradient derivative by pred): exp(pred)

Due to exp(pred) as the hessian, stability issues can occur quickly, in both sides (low values or gigantic values). Therefore, for satisfying convergence and stability, you would use an offset to the hessian. xgboost uses 0.7 for instance (exp(pred) + 0.7, where max_delta_step = 0.7), but there could be better / worse values.

Thanks, BTW are also you planning to support offset?
Il lun 30 gen 2017, 17:29 Guolin Ke<EMAIL_ADDRESS>ha scritto:

Closed #233 https://github.com/Microsoft/LightGBM/issues/233 via #270
https://github.com/Microsoft/LightGBM/pull/270.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/LightGBM/issues/233#event-941621674, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAyWxq-0zofVpfo9dfprOTPOM4GLURdpks5rXg_dgaJpZM4Llq8S
.

@spedygiorgio It is already supported. You must use the bias (initial score in LightGBM).
Do remember in the case of Poisson regression + non-linear model to modify accordingly either the label or the bias.
Let's suppose you have claims and account count, either is right:

y = claims/accounts, x = ...
y = claims, x = ..., base score = log(accounts)


I am new in open source

This is a test issue. please Ignore

@biswajit42 Please do not test on a public repository. This causes dozens of developers to get notifications.
For future tests, please make use of your own account/repos, or, at least, fork any repo you want to test on, and do the tests on your personal fork.
Thank you.

I’m sorry for my mistake. I’ll make sure it never happens again.


Fix a potential crash on 32-bit systems

For reference: lovell/sharp#4125 and https://github.com/lovell/sharp/issues/4125#issuecomment-2175281472
Thanks to @kleisauke for debugging and proposing a patch!

I can confirm that this PR resolves https://github.com/lovell/sharp/issues/4125. Thank you! :thumbsup:


[Abide] Form + abide validation does not submit

How can we reproduce this bug?
I've tested locally with Prepos, Yeti launch and online on my web server and jsfiddle, all with the same result. I cannot submit the form with abide validation.
I think my setups have been good (otherwise any tips are welcome).
I've made a basic test at jsfiddle to show the same result.

Go to:
example jsfiddle
Submit the form with abide validation without a value present.
You ll see the normal validation error.
Fill in a value.
Submit the form.
Or directly fill in a value and submit.
The second form is for comparison only, the only difference is it has no validation.

What did you expect to happen?
If no value is present abide prevents the form being submitted. That works fine.
If a value is present in the abide form > the form should be submitted when Submit is clicked.
What happened instead?
Nothing when a value is present on submit. No error is shown and cannot submit.
Test case
example jsfiddle

After upgrading to Foundation 6 I have run into this same problem.  Using the Abide plugin on a form prevents the form from being submitted, even when validation criteria have been met.  Additionally, the validation does not work on any other kind of input than type="text".  Hoping this gets resolved quickly because it is a big deal breaker.

Same here! After validation the form will not submit.

@anothergituser Great! This #7357 solves the issue.

Should be fixed with #7590, please comment and submit pr's to the abide branch until 6.1 release.


update to 1.3.2

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 6 committers have signed the CLA.:white_check_mark: FlyingQianMM:white_check_mark: jiangjiajun:white_check_mark: chliang:x: wangsiyuan06:x: lailuboy:x: syyxsxxwangsiyuan06 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 6 committers have signed the CLA.:white_check_mark: FlyingQianMM:white_check_mark: jiangjiajun:white_check_mark: chliang:x: wangsiyuan06:x: lailuboy:x: syyxsxxwangsiyuan06 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


I built a site with Eleventy!

https://kula.blog/
Personal blog with book reviews and a little programming opinions. :)

please close this issue because the site already exists


U+0332 COMBINING LOW LINE and U+0333 COMBINING DOUBLE LOW LINE don't connect

According to Unicode, U+0332 COMBINING LOW LINE and U+0333 COMBINING DOUBLE LOW LINE should connect on left an right, creating an underline appearance for the whole phrase. But they don't. See the attached screenshot for the following text:
U+0331: A̱Ḇ
U+0332: A̲B̲
U+0333: A̳B̳
The first line is correct, but the last two lines should connect instead of being disconnected.

In some fonts (haven't checked Noto) the underlines are at different
heights on different characters, because of descenders in letters like
lower case p and q.  There is no limit to the length of the series of
characters, so you might have to join and unify heights across twenty or
more characters.  I don't know that opentype can do this well.
If one could determine from font data what the position of an underline for
a character should be, then a rendering engine could look for character
sequences in which this combining mark (and precomposed characters with
it?) occur in a series, and substitute text with no underline/double
underline plus a generated underline adornment (like underline in
higher-level protocols) at a height it determines from examining the ideal
height for each character.  It's not clear to me that you'd want to do
that, but you could in principle.
A more doable approach is to design the glyphs such that the underscore
matches the advance width and is at a uniform height (perhaps with breaks
around descenders).  This could look messy with double-underscore.  Or you
could drop the underscore below the descenders, but this is like a below
mark and requires a larger line height/leading.  And of course
tracking/justification/kerning could break the underscores apart.  At
least, a unified height could allow opentype to handle this by just dealing
with pairs of characters.
I note that Wikipedia says that U+0331 should also join.
https://en.wikipedia.org/wiki/Macron_below
On Fri, Aug 21, 2015 at 11:01 AM, Roozbeh Pournader <
<EMAIL_ADDRESS>wrote:

According to Unicode, U+0332 COMBINING LOW LINE and U+0333 COMBINING
DOUBLE LOW LINE should connect on left an right, creating an underline
appearance for the whole phrase. But they don't. See the attached
screenshot for the following text:
U+0331: A̱Ḇ
U+0332: A̲B̲
U+0333: A̳B̳
The first line is correct, but the last two lines should connect instead
of being disconnected.
[image: 400]
https://cloud.githubusercontent.com/assets/302255/9415392/eb90be3e-47f3-11e5-8105-1c8ef7936756.png
—
Reply to this email directly or view it on GitHub
https://github.com/google/roboto/issues/98.

The way I’m doing this is by creating multiple variants of the over/under line glyphs with different widths and substituting then contextually substitute them. I have a script that generates the variant glyphs and the substitution rules. To avoid creating too many glyphs, it puts the glyphs that have closer widths into groups and create one glyph and substitution rule for each group.
For this to work the marks need to be placed at the same level (I use the ascender for over line, and under line position for under line) which might not look always nice.

I'm with @khaledhosny! His solution makes a lot of sense to me.
@dougfelt, you are misreading the Wikipedia article. It says U+0332 (low line) joins, but U+0331 (macron below) doesn't.

Yes, sorry my mistake.
On Fri, Aug 21, 2015 at 12:32 PM, Roozbeh Pournader <
<EMAIL_ADDRESS>wrote:

I'm with @khaledhosny https://github.com/khaledhosny! His solution
makes a lot of sense to me.
@dougfelt https://github.com/dougfelt, you are misreading the Wikipedia
article. It says U+0332 (low line) joins, but U+0331 (macron below) doesn't.
—
Reply to this email directly or view it on GitHub
https://github.com/google/roboto/issues/98#issuecomment-133538335.

U+0305 and U+033F should behave the same way but above, they should connect as well.

Friendly ping?


Command::spawn support

We have a small library that allows the use of quoted strings and like. Once you made the 0.3.0 release, I started looking at porting old code to this. However, I noted the lack of spawn() support. We use this, for example in:
https://docs.rs/easy_process/0.2.0/easy_process/fn.run_with_stdin.html
Is it possible to add support for it?

Thanks for the feedback,
Yes it's definitely possible and planed but I realized I made a hug
mistake. Even if adding this feature means you can use the library in the
future
there are likely people which can't (or don't want to due to the large
differences).
As such I think it's better to make v0.3.0 a new library so that people
staying on the (minimal but well working) older version are not nudged
to upgrading by the various "outdated crate" detection tools.
So I will yank 0.3.0, publish 0.2.3 with warnings fixed and a note in the
readme and publish 0.3.0 under a new name, soon.
I also will post here once the "spawn" use-case is supported.
On Mon, Jan 25, 2021 at 9:09 PM Otavio Salvador<EMAIL_ADDRESS>wrote:

We have a small library that allows the use of quoted strings and like.
Once you made the 0.3.0 release, I started looking at porting old code to
this. However, I noted the lack of spawn() support. We use this, for
example in:
https://docs.rs/easy_process/0.2.0/easy_process/fn.run_with_stdin.html
Is it possible to add support for it?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rustonaut/checked-command/issues/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB2HJEK3XTXJBR2JUIOFE7DS3XFYDANCNFSM4WSJKK4Q
.

Thanks for the feedback,
Yes it's definitely possible and planed but I realized I made a hug
mistake. Even if adding this feature means you can use the library in the
future
there are likely people which can't (or don't want to due to the large
differences).
As such I think it's better to make v0.3.0 a new library so that people
staying on the (minimal but well working) older version are not nudged
to upgrading by the various "outdated crate" detection tools.
So I will yank 0.3.0, publish 0.2.3 with warnings fixed and a note in the
readme and publish 0.3.0 under a new name, soon.
I also will post here once the "spawn" use-case is supported.
On Mon, Jan 25, 2021 at 9:09 PM Otavio Salvador<EMAIL_ADDRESS>wrote:

We have a small library that allows the use of quoted strings and like.
Once you made the 0.3.0 release, I started looking at porting old code to
this. However, I noted the lack of spawn() support. We use this, for
example in:
https://docs.rs/easy_process/0.2.0/easy_process/fn.run_with_stdin.html
Is it possible to add support for it?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rustonaut/checked-command/issues/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB2HJEK3XTXJBR2JUIOFE7DS3XFYDANCNFSM4WSJKK4Q
.

Have you done that?

I have published it under a different name: https://crates.io/crates/mapped-command
But some things got in my way so I had not yet time to implement the spawn functionality.
Luckily I did take notes about my analysis about how to implement spawn functionality for different use cases, so I can easily continue where I left of once I find the time to do so.


[BugFix] Fix the error when getting the memory limit in cgroup v2

cgroup V1 in Centos7 store memory limit in /sys/fs/cgroup/memory/memory.limit_in_bytes cgroup V2 in Ubuntu 22 store memory limit in /sys/fs/cgroup/memory.max
StarRocks encounters error when running in docker installed Ubuntu 22.
cat: /sys/fs/cgroup/memory/memory.limit_in_bytes: No such file or directory
can't get mem info from /sys/fs/cgroup/memory/memory.limit_in_bytes
There is not /sys/fs/cgroup/memory/memory.limit_in_bytes file for a centos-7 base docker container.
E.g, running this command in a centos-7 based docker container got this error.

This pull request figure out a solution by check the version of cgroup. According to the cgroup version, the memory limit will been automatically parsed.
What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #13548
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[x] 2.4
[x] 2.3
[x] 2.2

run starrocks_admit_test

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4

@Mergifyio backport branch-2.3

@Mergifyio backport branch-2.2


Support EndpointSlice in Antrea proxy

Support EndpointSlice in Antrea proxy, ServiceTopology is not implemented in this commit.

Codecov Report

Merging #1310 into master will decrease coverage by 22.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master    #1310       +/-   ##
===========================================
- Coverage   63.64%   41.62%   -22.02%
===========================================
  Files         157      150        -7
  Lines       12626    12014      -612
===========================================
- Hits         8036     5001     -3035
- Misses       3747     6322     +2575
+ Partials      843      691      -152

Flag
Coverage Δ

#integration-tests
?

#kind-e2e-tests
41.62% <0.00%> (-5.22%)
:arrow_down:

#unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/agent/proxy/endpoints.go
0.00% <0.00%> (-88.58%)
:arrow_down:

pkg/agent/proxy/endpointslicecache.go
0.00% <0.00%> (ø)

pkg/agent/proxy/proxier.go
0.00% <0.00%> (-74.81%)
:arrow_down:

pkg/features/antrea_features.go
100.00% <ø> (ø)

pkg/agent/proxy/service.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/agent/proxy/types/groupcounter.go
0.00% <0.00%> (-95.00%)
:arrow_down:

pkg/controller/networkpolicy/crd_utils.go
0.00% <0.00%> (-94.65%)
:arrow_down:

pkg/agent/controller/networkpolicy/priority.go
4.66% <0.00%> (-85.34%)
:arrow_down:

pkg/agent/proxy/types/types.go
0.00% <0.00%> (-84.62%)
:arrow_down:

pkg/ovs/openflow/ofctrl_group.go
0.00% <0.00%> (-84.38%)
:arrow_down:

... and 75 more

Thanks for working on this @weiqiangt.

what is your plan to test this support?
the commit and PR message should include a quick discussion about whether this affects compatibility between Antrea versions & K8s versions. As of now, Antrea support K8s >=1.16, and the EndpointSlice API is enabled by default in 1.17 (beta). With this change, can we still support kube-apiserver 1.16? Or will we get an error when creating the informer for EndpointSlices?

@antoninbas, thanks for reviewing. I'm also thinking about these questions, for now, my opinions are:

Alongside with noEncap with antrea proxy enabled E2E test, we can add a new e2e test in noEncap mode with both antrea proxy and endpointslice enabled. Since e2e tests are usually run in parallel, I think it would not extend check duration significantly.  For the newly added endpointslicecache.go which is modified from upstream, if we want to ensure the coverage number looks good we can also copy the endpointslicecache.go also. The reason I didn't locate the source to the third_party is that the cycle importing will be hard to handle.
If the endpointslice feature is not enabled in upstream APIServer, the watch will keep logging errors. This behavior is the same as kube-proxy. In kube-proxy, it only checks whether the flag is enabeld in its own feature gates options.

Codecov Report

Merging #1310 into master will decrease coverage by 20.63%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master    #1310       +/-   ##
===========================================
- Coverage   64.42%   43.79%   -20.64%
===========================================
  Files         159       75       -84
  Lines       12675     5727     -6948
===========================================
- Hits         8166     2508     -5658
+ Misses       3655     2942      -713
+ Partials      854      277      -577

Flag
Coverage Δ

#integration-tests
43.79% <0.00%> (-1.12%)
:arrow_down:

#kind-e2e-tests
?

#unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.


[BUG] Defer (ignore = True) is missing for Unstable Version

Currently Using V4.0.2 unstable version and I noticed for componentContext the await defer (ignore= True ) option is missing

There is no such thing as an ignore field in the API docs for deferring. You may have been mistaken for ephemeral, which is the proper name of hiding an interaction response.

There is no such thing as an ignore field in the API docs for deferring. You may have been mistaken for ephemeral, which is the proper name of hiding an interaction response.

No, there used to be an ignore param in v3 defer

But you are right that it's not in API


Implement Drush Site Aliases Connector for Lagoon

add project: to .lagoon.yml
Implement JWT Token getting via auth-ssh service
query the old and new API
Create Lagoon Site Aliases which work with https://github.com/amazeeio/lagoon/issues/52
Load existing environments via https://github.com/amazeeio/lagoon/issues/66

Needed for:

Drush8 (current implementation)
New Drush 9 Plugin Implementation

all done, except the Drush 9 integration, opened #147


Move Alist.Alist 3.15.1 to AList.AList 3.15.1

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Update view-reports-for-mdo.md

Added information about URL click protection action

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/4501

@msbemba

@MSFTTracyP Please merge this PR. Thanks.


[BACKLOG-14239]Upgrade to rxjava2

Newer rxjava2 provides native support for converting to/from reactive streams
Version 1 branches are also feature-frozen and approaching EOL
@CodeOnCoffee @ccaspanello @mkambol

Holding until #3435 is merged


Allow anonymous user-contributed notes on every page

When I started with PHP ( many years ago... ), one of the great parts about it was that you could read other people's clarifications, warnings and solutions for common usages of a command.
E.g. you go to research substr and the top comment actually warns you to use mb_substr instead, or the top comment for microtime() of course describes how to trace execution time by only using one var, etc.
The important part is that the notes :

can be submitted quickly and without having to sign up anywhere
are

 formatted
and syntax highlighted from the get-go

No fanciness, just quick notes dropped off when you need them.

Was added by @markknol

With github comments - great! Thanks for that!


Verilog asynchronous reset pattern leads to corrupted $check, $print control signals

Version
Yosys 0.38+92 (git sha1 f7737a12c, clang++ 11.1.0 -fPIC -Os)
On which OS did this happen?
macOS
Reproduction Steps
read_verilog -sv <<EOF

module top(q, d, clk, rst);
	input wire clk;
	input wire rst;
	input wire [1:0] d;
	output reg [1:0] q;
	always @(posedge clk, posedge rst) begin
		if (rst) begin
			q <= 0;
		end else begin
			q <= d;
			$display("q <= %x", d);
			assert(!(d & (d - 1)));
		end
	end
endmodule

EOF
proc
dump t:$print t:$check

Expected Behavior
The emitted $print and $check cells are conditioned on !rst.
Actual Behavior
The EN port of the cells in question is driven high by a constant.
  attribute \src "<<EOF:13.4-13.26"
  cell $check $assert$<<EOF:13$3
    parameter \ARGS_WIDTH 0
    parameter \FORMAT ""
    parameter \PRIORITY 32'11111111111111111111111111111110
    parameter \TRG_POLARITY 2'11
    parameter \TRG_ENABLE 1
    parameter \TRG_WIDTH 2
    parameter \FLAVOR "assert"
    connect \ARGS { }
    connect \A $logic_not$<<EOF:13$6_Y
    connect \EN 1'1
    connect \TRG { \rst \clk }
  end

  attribute \src "<<EOF:12.4-12.27"
  cell $print $display$<<EOF:12$2
    parameter \ARGS_WIDTH 2
    parameter \FORMAT "q <= {2:>01hu}\n"
    parameter \PRIORITY 32'11111111111111111111111111111111
    parameter \TRG_POLARITY 2'11
    parameter \TRG_ENABLE 1
    parameter \TRG_WIDTH 2
    connect \ARGS \d
    connect \EN 1'1
    connect \TRG { \rst \clk }
  end

AFAICT this exact issue of there being hidden assumptions on RTLIL processes is what prompted Amaranth to give up on emitting synchronization rules entirely: amaranth-lang/amaranth#603

Yep. (It's also that it is a completely undocumented contract between two parts of Yosys, which Amaranth really should not be relying on.)
My view is that Verilog frontend should stop emitting them too, by means similar to those of Amaranth, and then sync rules should be removed from RTLIL.

My view is that Verilog frontend should stop emitting them too, by means similar to those of Amaranth, and then sync rules should be removed from RTLIL.

One obstacle to making this change is that the synchronization rules are a useful intermediate representation for the inference of latches.

Can you not do this while collecting left-hand sides of assignments? If every branch assigns to a bit, then that is a flop, otherwise a latch.

That would still regress this example, though I have no idea whether this is idiomatic Verilog and something we ought to support
module top(q, d, en);
	input wire en;
	input wire [1:0] d;
	output reg [1:0] q;
	always @(*) begin
		if (en)
			q <= d;
		else
			q <= q;
	end
endmodule

Of course we could detect when the LHS and RHS bit are identical, and special-handle those, but then there are more complicated examples that are covered under the current traversal of the mux network by proc_dlatch. In any case we could introduce a special cell to be consumed by proc_dlatch, independent on any processes, and replace the current scheme with that.

That would still regress this example, though I have no idea whether this is idiomatic Verilog and something we ought to support

IEEE 1364.1 doesn't consider this a latch:

So I think we should not care about it. No one really wants latches anyway.

That makes things simpler. So a combinational loop would be emitted for that example if we move the inference of latches up into the frontend.

Yep!


Add helper function to get chrono::DateTime from MonotonicTime

What do you think about adding a helper API to retrieve a chrono datetime from a MonotonicTime ?
The chrono::DateTime  is an extremely convenient time format to work with, similar to the Python datetime API. If you think this might be a worthwhile addition, I can open a PR. I have already added something similar in the spacepackets crate for a unix timestamp wrapper object.
It would probably make sense to hide this behind a chrono feature gate similar to how it was done for serde.

I guess this could make sense, especially if MonotonicTime becomes its own crate.
Thinking loud, here are some things to consider:

the maintenance effort must be weighted against the benefits given that chrono is still pre-1.0 (hence might see breaking changes) and that this can already done (albeit clumsily) with a one-liner without needing to switch an extra feature, i.e. DateTime::from_timestamp(time.as_unix_secs(37), time.subsec_nanos()),
is there a reason to privilege the chrono crate over the time crates? In any case, for forward compatibility it would be best to name the methods according to the crate (e.g.  as_chrono_date_time() -- but for the time crate it's harder to find a name that isn't confusing...),
the method would still need to take leap seconds as argument,
if we go for this, it would probably make sense to add as well from_chrono_date_time(), also with a leap seconds argument.

Please let me know what you think.

Not strictly related, but looking at the spacepackets crate it looks like the CCSDS time code should be TAI-based and not UTC based (based on a quick look at the spec so I could be wrong, but I'd be surprised if they didn't use a monotonic time stamp).

I do not know what the release plan is for chrono or the time library.. I think the effort would be manageable though
No reason :) chrono was one of the first major time libraries which is why I selected it. To be honest, from having a look at the download counts for both libraries, both seem to be used commonly. Maybe I'll even add time support to the spacepackets library. I like the idea with distinct names. Maybe as_timelib_date_time() would work alternatively?
Yup, leap seconds still need to be accounted for. Possible solution: Ignore timestamps before 1972 or throw an explicit error? I would guess most use-cases use current time and not 1970..

About spacepackets: All timecodes except CUC are UTC based. So I definitely need to correct this there..

I will be busy today but if you want I can have a look at the spacepacket's fix tomorrow. Just one think that caught my eyes in the tests' comments: there were actually leaps seconds before 1972, but these were not integer numbers. For the particular case of the 1958 epoch, however, AFAIK the number of leap seconds was indeed 0 (by design). Yes, it's all but simple...

To be honest, I am now also working on refactoring other components of the time library. The UnixTimestamp is also planned to have nanosecond precision, so other structures like the CUC timestamp can also be more easily created from a UnixTimestamp.
Incidentally, the structures become identical except the leap second offset with that change. In any case, I will create conversion methods to/from MonotonicTime for the UnixTimestamp, especially if MonotonicTime goes into its own crate. Another idea I had would be to simply move the UnixTimestamp into that new crate as a UnixTime struct as well, especially because those two are so similar and do not share a lot of dependencies.. But those are just som ideas..

I just found another good reason to include MonotonicTime in a separate crate: It is actually a type which could be useful on no_std systems to track elapsed times where std::time::Instant is not available. For cases like this, I used UnixTimestamp, which relies on the non-monotonic UNIX time. That would require layering the code so that alloc and std dependent features are behind a feature gate.

(sorry for the late PR review of spacepackets, done!).
I agree that the CUC time should not be leap-second aware, especially that the leap offset could become invalid when the CucTime is modified by arithmetic operations to a date with a different offset.
Yes, making MonotonicTime a no_std crate make a lot of sense. I would prefer to keep it really bare-bone though, I think it is always possible to build related structs like UnixTime or our seqlocked version of MonotonicTime in separate crate with very little penalty (I think the only penalty is the assert in MonotonicTime::new() which could be avoided by having access to the private fields, but we can probably live with that).

The first candidate version of a standalone and more generic version of MonotonicTime with no-std, serde and chrono support is now available at https://github.com/asynchronics/tai-time/.
I will thus close this issue in favor of https://github.com/asynchronics/tai-time/issues/1.
I would be grateful for any feedback before the official release (please use the above new issue).


Audio

Only added the SFML library and header files from the DirectXTK_DESKTOP_2015 tutorial

I guess I can approve this.


docs: add professional support

Description
Add professional support section to README.md
Checklist

Code is easy to understand
No obvious errors or bugs
CI/CD Pipelines did run successfully
Tests were implemented
Documentation was created

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.96%. Comparing base (3cfc636) to head (b2967f6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #653   +/-   ##
=======================================
  Coverage   40.96%   40.96%
=======================================
  Files          19       19
  Lines         598      598
  Branches       78       78
=======================================
  Hits          245      245
  Misses        276      276
  Partials       77       77

Flag
Coverage Δ

unittests
40.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Bug] Azure.AI.TextAnalytics / WestEroup

Package Name: Azure.AI.TextAnalytics
Package Version: 5.2.0
Operating System: Windows
.NET runtime version: .NET6
Visual Studio Enterprise 2022 version: 17.4.4

await healthOperation.WaitForCompletionAsync();
it was working fine but before two days it stopped without any change in the code or the SDK
and there is no response for this line of code!

Document details
⚠ *Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
Language Quickstart Feedback

Content: Quickstart: Using Text Analytics for health client library and REST API - Azure Cognitive Services
Content Source: articles/cognitive-services/language-service/text-analytics-for-health/quickstart.md
Section: Clean-up-resources
Service: cognitive-services
Sub-service: language-service

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Thank you for reporting this issue! We have identified a problem related to healthcare analysis in the West Europe region and are currently investigating.

https://github.com/Azure/azure-sdk-for-net/issues/33509


Game crash on opening crafting grid

Issue description:
the game crashed on opening a crafting grid
What happens:
it crashes
What you expected to happen:
not crash
Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.1
Forge: 2467
Refined Storage: 1.5.18

Does this issue occur on a server? [yes/no]
yes
If a (crash)log is relevant for this issue, link it here:
https://paste.ee/p/Jg0Cq

This looks like a Minecraft bug. I cannot reproduce it either.


Contacts do not appear

Contacts does not seem to be providing any results or appearing at all

There was a "Terminal would like access to your contacts" prompt hidden amongst the windows.  After clicking ok, contacts appeared in the results.


Creating a backup of our code

As part of an ideal Business Continuity Plan and Disaster recovery, we should create a backup of the code and repositories present in Github for the Open Targets Platform, Open Targets Genetics and PPP.
Tasks

[ ] Scoping the best and most efficient way of maintaining a backup of all the code (e.g. EBI Gitlab, bitbucket)
[ ] Creating an automated scheduled backup for the code

@mbdebian to review this in the next couple of months.


Addition to Porn List

Add the following url to porn list please:
camera.com

Thank you for this Jon @JonathanSpalding.
Ping @sinfonietta for inclusion in the porn list.

@StevenBlack I have added camera.com.

Thank you @Sinfonietta.  Closing.


More Highlight Languages Please

Typescript and Powershell are not supported in the syntax highlighting. Can we add them? For that matter, why not add the other languages HighlightJS supports?

Hmm I'll have to poke around our markdown library and see why it's not recognizing those two.