Remove some duplicated URL generation code

I went down a rabbit hole while trying to untangle the bug in the dockbit and bitrise examples https://github.com/badges/shields/pull/2234#pullrequestreview-169997546.
The URL generation code is spaghetti-like, with functions, many of which I wrote, with opaque names, doing similar but not identical things, and making slightly incompatible assumptions about the way query strings are handled.
I got a bit lost and need to take a step back.
Meanwhile, this is a smalle piece of work I did that’s worth keeping. It doesn’t scratch the surface of the tangle, but it does remove a bit of duplication.
It also makes a minor stylistic ES6 change in the handling of default arguments.

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

  Generated by :no_entry_sign: dangerJS


Refresh templates on every time range change

Without this change, the templates are calculated only once, for default time range (30d) so for older snapshot they are empty and there is no simple way to refresh them.
Refreshing the set of values seems to be quite fast so I hope this won't be a big performance issue, but we will see.
/assign @oxddr

That sounds reasonable to me, I don't expect big performance hit because of that (but we will see). Thanks!
/lgtm


Does this project have an active maintainer?

It's been over a year since any changes were published for this package, and given that it is an ssh library. It would be good to know that someone is keeping up with any potential security issues that may arise now or in the future.

Due to the inactivity of this repository and the need to maintain it within one of the Google Summer of Code organizations in which I collaborate. If anyone else needs it, this is the new repository created from this one with this change (and others applied).

Yes, this is still maintained. Many thanks for your time 🚀


Advisory improvement for GHSA-566m-qj78-rww5

Updates

Affected products
Description

Evidence:
See the updated CVE details over at NIST:
https://nvd.nist.gov/vuln/detail/CVE-2021-23382#VulnChangeHistorySection
And release notes for postcss 7.0.36:
https://github.com/postcss/postcss/releases/tag/7.0.36
Context/commentary:
This CVE was fixed on the 7.x branch of postcss. Which is great for folks still on @rails/webpacker who are stuck on postcss 7.x as a transitive dependency, and who otherwise can't trivially patch for this CVE.
All I can see that's left is to update GitHub's advisory listing to match, so I opened this PR.
Regarding the description update:
I should probably have worded the 8.x thing as "between 8.0.0 and 8.2.13 (exclusive)" or something... But that still sounds super clunky. Thinking about if there's a nicer and still succinct way to do that in prose.
Or just leave the description as-is, since it appears to have been copy-paste verbatim from the NIST/official CVE description... Yeah, maybe it's better to just update the affected version ranges and leave the description? I dunno.
Thanks:
THANKS so much for making it possible to suggest improvements to these advisories. I was just thinking about how great this would be the other day, and boom. There it is. Thank you!!

Better description change, I think:
"The package postcss before 7.0.36, or 8.x before 8.2.13, are vulnerable to Regular Expression Denial of Service (ReDoS) via [ . . . ]"
(Or leave it as the exact text from the official CVE description)

Hi @DeeDeeG! Thank you so much for being one of the first folks to submit a community contribution! We value you making our database better.
I'd love to learn more about your use case.
Would be interested in chatting with me for 30 minutes in the next month via Zoom? If so, please follow the link below to schedule a time that works best for us both. In recognition of your time, we’ll send you a $60 gift card/cash card/credit for the GitHub Swag store.
https://calendly.com/security-advisories-ux-calls/25min?back=1&month=2021-10

Sure!
I responded to the link -- will do my best to be available at that time, but it is somewhat dependent on my work whether it will line up.
Thanks again for opening up the advisory database to community contributions/improvements!

Hi folks.
This may be a weird request, but... Any way the Security Advisory credit can be removed for me on this advisory, or clarified that I didn't add any security research to this, just tweaked the metadata for the affected package version ranges to be accurate?
I get a badge visible here:

https://github.com/advisories?query=credit%3ADeeDeeG
https://github.com/advisories/GHSA-566m-qj78-rww5

And on my GitHub account profile page.
(IMO my actual contribution (this PR) was valid and appropriate/within my ability even not as a security researcher, since I was able to point to the existing, official documentation of this CVE to correct metadata here, I had no reservation contributing like that. But the little badge I got for it afterward feels slightly off somehow.)
My reasoning for asking for this is: Just personally I don't want to take credit, for one thing, but also I don't know how I feel about anyone thinking of me of a security analyst or security researcher. I don't have that kind of qualification/skill.

Hey @DeeDeeG!
Thank you so much for this thoughtful and well-explained feedback. I totally get where you're coming from and want to compliment your humility here. Plenty of others are seeking the opposite!
I'll go ahead and document this and if we get more feedback around it we'll reconsider our approach of matching the CVE schema.
Thanks again for being a great community member,
Kate


test: Add tests for duplicate path parameter rule

Add tests for duplication path parameter rule.  These were supposed to be included in PR #112, but somehow "got lost".

:tada: This PR is included in version 0.15.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


OMOP -  observations?

Hi,
I am testing patient-viz against a OMOP CDM v5. Procedures and conditions look great but I don't see any observations. Wondered if this was available.
thanks,
-R

Yes, I never implemented it since I don't have a database at hand that populates those tables. What are the important fields? Or, if you want to implement the bit yourself you can look here and here as example. Pull requests are always welcome :)


Fix a DEBUG-only null ref due to Name Resolver

Pull Request Test Coverage Report for Build 307635

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 58.103%

Totals

Change from base Build 307634:
0.0%

Covered Lines:
19813

Relevant Lines:
34100

💛  - Coveralls


Implement the /api/v1/applications endpoint

Context
Changes proposed in this pull request
Guidance to review
Link to Trello card
https://trello.com/c/IojPPFnZ/990-implement-the-smallest-possible-api-into-the-real-application

A note on the current state of this branch before vendor forum this afternoon: we have a failing spec that asserts that our response conforms to the schema in the OpenAPI spec. The spec fails because in our spec definition we say that optional subresources like offer may be null by setting nullable: true in the openAPI spec. This concept does not exist in vanilla JSON schema, so that JSON::Validator gem we're using to validate the response against the spec doesn't know how to handle it: null is not acceptable, but {} lacks the required fields. I've tinkered a bit with https://www.npmjs.com/package/openapi-schema-to-json-schema, which promises to paper over this particular crack:
const toJsonSchema = require('openapi-schema-to-json-schema');
const swaggerParser = require('swagger-parser');

swaggerParser.validate('openapi-spec.yml', (err, api) => {
  if (err) {
    console.error(err);
  } else {
    console.log(toJsonSchema(api));
  }
});

I haven't got much further than taking the output of that and treating it as a JSON schema. Naturally, that doesn't work right off the bat.


twitter: /statuses/retweets.json returns 403 Forbidden

for https://brid.gy/twitter/iwontsignuphere , every poll. other API calls beforehand succeed. not sure why. we're incorrectly (maybe?) interpreting it as rate limiting.
example log:
Params: NestedMultiDict([('last_polled', u'1970-01-01-00-00-00'), ('source_key', u'aglzfmJy...')])

Error 403, response body: {"errors":[{"code":"200", "message":"Forbidden."}]}
Error 403, response body: {"errors":[{"code":"200", "message":"Forbidden."}]}
Error 403, response body: {"errors":[{"code":"200", "message":"Forbidden."}]}
Rate limited. Marking as error and finishing. HTTP Error 403: Forbidden
Updating iwontsignuphere (Twitter) /twitter/iwontsignuphere : {'poll_status': 'error', 'rate_limited': True}
Added poll task<PHONE_NUMBER>3700949421 with args {'countdown': 80642.525166884909}

error code 200 isn't listed in https://dev.twitter.com/overview/api/response-codes , and https://dev.twitter.com/rest/reference/get/statuses/retweets/%3Aid doesn't mention this error.
however, https://twittercommunity.com/t/protected-tweets-with-statuses-retweets-id/12903/4 has lots of other people reporting the same thing: /statuses/retweets.json returns the same error for a protected account.
my best guess is this is intentional for protected accounts, so i should catch it and handle it.

confirmed, same things happens with another protected account, snarfed_org: /statuses/retweets/701173347606880256.json returns 403 {"errors":[{"code":"200", "message":"Forbidden."}]}.

fixed by snarfed/granary@34a7bcb

happening again, but an odd variant, for ianvellosa. example log below.
we fetch his tweets with /statuses/user_timeline.json, as usual, and then we fetch retweets for tweet id<PHONE_NUMBER>01069825, which returns HTTP 403 with error code 200, same as above. oddly though, that tweet isn't in his timeline! i don't understand where we're getting it.
no matter i guess, fix is probably to just handle HTTP 403 + error code 200.
2019-08-12 20:25:06.373158 I Source: ianvellosa (Twitter) ianvellosa, https://brid.gy/twitter/ianvellosa
...
2019-08-12 20:25:06.789362 I urlopen GET https://api.twitter.com/1.1/statuses/user_timeline.json?include_entities=true&tweet_mode=extended&count=50&screen_name= {}
2019-08-12 20:25:07.059948 I urlopen GET https://api.twitter.com/1.1/statuses/retweets.json?id=262967438101069825&tweet_mode=extended&since_id=976198456070037504_favorited_by_20429282 {}
2019-08-12 20:25:07.127041 W Error 403, response body: u'{"errors":[{"code":..."message":"Forbidden."}]}'
2019-08-12 20:25:07.145029 I Updating ianvellosa (Twitter) /twitter/ianvellosa : {u'poll_status': u'error'}
2019-08-12 20:25:07.226816 E HTTP Error 403: Forbidden
Traceback (most recent call last):
...
  File "/base/data/home/apps/s~brid-gy/background:8.420268296435611139/tasks.py", line 95, in post
    self.poll(source)
  File "/base/data/home/apps/s~brid-gy/background:8.420268296435611139/tasks.py", line 161, in poll
    min_id=source.last_activity_id, cache=cache)
  File "/base/data/home/apps/s~brid-gy/background:8.420268296435611139/models.py", line 348, in get_activities_response
    resp = self.gr_source.get_activities_response(**kwargs)
  File "/base/data/home/apps/s~brid-gy/background:8.420268296435611139/local/lib/python2.7/site-packages/granary/twitter.py", line 351, in get_activities_response
    tweet['retweets'] = self.urlopen(url)
...
HTTPError: HTTP Error 403: Forbidden

Does anyone have the same problem? I am using Tweepy 3.8.0 and having exactly the same problem...


Bump Workbench version to 2024.09.0

@GCRev They don't yet, so this PR shouldn't be merged until they do. Pending the merge of rstudio/rstudio-docker-products#845

I feel like we've been on 2024.09 for long-enough now that we should have docker builds of it, but maybe I'm thinking about the preview tags here: https://hub.docker.com/r/rstudio/r-session-complete-preview/tags

The 2024.09.0 images have now been built from main on rstudio/rstudio-docker-products


fix(preloader): fix preloader animation

Status :
Ready

Description :
Fix animation on loader 3.
#287
Todos

[x] Tests
[x] Documentation

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix: ui glitch when navigatin to user detail (#354)

Before (slowed to 0.25x)

After (slowed to 0.25x)

Hmmm.... I want to try a few things with this to make sure there aren't intended consequences.

Yeah, this isn't the fix for the issue. The issue is that the SearchBar is getting unmounted and re-mounted. I'm not sure what's causing it just yet, but if we figure that out this issue will probably go away. Either way, we need to figure that out first before we merge this.

This is caused by Remix Dev Tools. Removing it resolves the bug. @AlemTuzlak, could you please figure out why routes are getting unmounted and remounted on search param changes?

@kentcdodds will do! I think this will probably be mitigated by the new way of initializing the dev tools I'm working on. Will investigate it further as well

@kentcdodds I've been taking a very deep dive into Remix internals the last couple of days and have figured out some issues with my approach to rendering the component, I am working on a release that will land soon that will not cause re-renders or issues on the UI at all because the component will be rendered in a completely different way instead of it being in the root. I use the epic stack as a testing env in remix-development-tools and I can confirm this issue is gone with the new approach. Will be making a PR to address this asap

I've removed the dev tools temporarily until this gets fixed.

@kentcdodds FYI I found the root cause of this, will be fixed in the upcoming v2 along with some more stability improvements!


winbox.default is not a constructor

I'm trying to use your lib in a React project. When importing it with: import WinBox from "winbox", I receive an empty object. So trying to instantiate a new winbox triggers the error: winbox.default is not a constructor.
Here is the test code I wrote:
import React from "react";
import WinBox from "winbox";

export default function App() {

  const createModal = () => {
   const modal = new WinBox({
      title: "Set innerHTML",
      html: "
hello
"
    });
    return modal
  };

  console.log("WinBox", WinBox) // returns {}

  return (

      <button onClick={createModal}>new modal</button>

  );
}

Here is a codesandbox: https://codesandbox.io/s/pedantic-bush-lplpl?file=/src/App.tsx

for anyone else wandering, you need to import the js from deeper down in the module and the css from another path in the module:
import WinBox from "winbox/src/js/winbox";
import "winbox/dist/css/winbox.css";

If you try use with SSR (NextJS etc) and have some troubles:

IF You have this error “Must use import to load ES Module” - rename winbox.js to winbox.cjs or write "type": "module";
If You have this error Next.js: document is not defined - import this module dynamicaly on client. detail.

P.S. When used in conjunction with nextjs, I did not find answers to these questions. I suppose this might help. Many thanks to the author for such a tool!

G

If you use TypeScript I guess you can only do something like
import 'winbox';

declare const WinBox: WinBox.WinBoxConstructor;

export default function useWinBox() {
    return {
        create(options: VueWinBoxOptions) {
            return new WinBox({
                ...options
            })
        }
    }
}


Update version to 1.1.18-0 on staging

Update version to 1.1.18-0

🚀 Deployed to staging by @OSBotify in version: 1.1.18-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Do in-depth demo

User Story

So that I get an understanding of how the Data Lake works, as a Topo Developer, I want to understand how it works and it's limitations.

Acceptance Criteria

[ ] Given [a pre-condition], when [an event happens], then [an expected outcome occurs]
[ ] Given [a pre-condition], when [an event happens], then [an expected outcome occurs]

Additional context

Tasks

[x] run through prior to demo and cut off merges/ changes before demo
[x] set up date
[x] do the demo
[x] document feedback

Definition of Ready

[ ] This story is ready to work on, according to the team's definition

Definition of Done

[ ] This story is done, according to the team's definition

Demo done, stories created and prioritised


⚠ ClamAV has degraded performance

In a2b7edb, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 76 ms

Resolved: ClamAV performance has improved in 33d1ee0 after 5 minutes.


Override DbConnection.DbProviderFactory

We should start returning the singleton provider factory for Sqlite so that DbProviderFactories.GetFactory(DbConnection) starts to work in 2.1.
cc @roji @alexkeh @bgrainger since this is probably missing in many ADO.NET providers that target .NET Standard 2.0.

Thanks for the heads-up; already implemented in MySqlConnector here: https://github.com/mysql-net/MySqlConnector/blob/307679552f4c39d0f1bf565a58f8afd286f2d81a/src/MySqlConnector/MySql.Data.MySqlClient/MySqlConnection.cs#L219

Same here for Npgsql: https://github.com/npgsql/npgsql/blob/dev/src/Npgsql/NpgsqlConnection.cs#L1366, this was present when .NET Standard 2.0 was implemented.

I stand corrected. I checked after I read @bgrainger's answer and it seems DbConnection.DbProviderFactory is in .NET Standard 2.0, so it shouldn't be a problem to override it.


git is working every 10 seconds

Issue Type: Bug
Here is what i see in vs code every 10 seconds in git output. This happens even if git.autoFetch is false (in settings)
git status -z -u

git symbolic-ref --short HEAD
git rev-parse master
git rev-parse --symbolic-full-name master@{u}
git rev-list --left-right master...refs/remotes/origin/master
git for-each-ref --format %(refname) %(objectname) --sort -committerdate
git remote --verbose

I just found a setting where if i add it and set it to false, this stops happening.
"git.autorefresh": false,
Is this intentionally set to true by default?
It is distracting to see the git icon with a timer working every few seconds in the sidebar icon.
VS Code version: Code - Insiders 1.28.0-insider (5ba5f14c954682df46f04a541f0b272166605366, 2018-09-26T07:25:01.336Z)
OS version: Darwin x64 17.7.0

System Info

Item
Value

CPUs
Intel(R) Xeon(R) W-2140B CPU @ 3.20GHz (16 x 3200)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
32.00GB (0.11GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (30)

Extension
Author (truncated)
Version

ng-template
Ang
0.1.10

markdown-preview-github-styles
bie
0.1.3

path-intellisense
chr
1.4.2

vscode-markdownlint
Dav
0.20.0

vscode-eslint
dba
1.6.0

EditorConfig
Edi
0.12.4

tslint
eg2
1.0.39

vscode-npm-script
eg2
0.3.5

prettier-vscode
esb
1.6.1

vscode-pull-request-github
Git
0.1.6

Angular1
joh
0.2.0

angular-essentials
joh
0.4.0

Angular2
joh
6.1.5

dotenv
mik
1.0.1

vscode-azureappservice
ms-
0.9.1

vscode-azurefunctions
ms-
0.11.0

vscode-cosmosdb
ms-
0.8.0

azure-account
ms-
0.4.3

azurecli
ms-
0.4.2

vsliveshare
ms-
0.3.735

vsliveshare-audio
ms-
0.1.32

vsliveshare-pack
ms-
0.1.3

debugger-for-chrome
msj
4.10.1

angular2-inline
nat
0.0.17

vetur
oct
0.12.7

vscode-docker
Pet
0.3.1

material-icon-theme
PKi
3.6.0

polacode
pnp
0.2.2

vue-vscode-snippets
sdr
1.3.0

code-settings-sync
Sha
3.1.2

(1 theme extensions excluded)

cc @chrisdias - per our chat yesterday

Git will refresh its state due to file change events, at most once every 10 seconds. So your workspace must have some file change events occurring. Does it

I have auto save on but even fin I sit there and just watch it we can see it working.
Please reopen

@johnpapa Does this only happen on a single project, or on all the git repositories in your system?
Let's try something:

Fully shutdown Code.
In a command line, run code --verbose FOLDER. Please reference the folder in which this issue occurs.
Open the devtools
Wait

While you wait, are there any file events?


Run CI against supported Ruby versions 2.6 and 2.7

Running the CI with Ruby 2.6 would have caught the issue reverted in #10


Nesting rule is broken?

Hey there,
I'm using grunt-sass-lint (v0.2.0) with sass-lint (v1.8.2) and I'm having troubles with the nesting rule. There is this specific pattern where the rule isn't working anymore.
I'm using nesting-depth with max-depth: 1, the whole configuration file is attached. (sass-lint.yml.txt)
So here is what I do:
.a {
    content: "root";

    .x1 {
        content: "first level - without this, it works";
    }

    .b {
        content: "first level";

        .x2 {
            content: "second level - without this, it works";
        }

        .c {
            content: "second level";

            .x3 {
                content: "third level - without this, it works";
            }

            .d {
                content: "third level";

                .e {
                    content: "fourth level";
                }
            }
        }
    }
}

This piece of code is not being reported by sass-lint with max-depth set to 1, but as soon as I remove one of the .xN classes, the linting is reporting that nesting is wrong. But I am expecting it to report .x2 and .c straight from the beginning.
The output when I remove .x1 for example:

src/main/sass/styles.scss
56:9  warning  Nesting depth 2 greater than max of 1  nesting-depth
60:9  warning  Nesting depth 2 greater than max of 1  nesting-depth

When .x1 is still there, sass-lint will be quiet. I tried an IDE plugin as well as the CLI.

Hello @mzdr,
We've been investigating this in one of our project for a couple of days. We just realized that this rule is working as expected.
You and us are looking for something different, the SelectorDepth rule which is/was available in scss-lint. Unless I missed it, it remains to be added  to the project.
Here's a bit of doc. about the SelectorDepth:
https://github.com/brigade/scss-lint/tree/master/lib/scss_lint/linter#selectordepth
Is that what you are looking for?
Cheers,
Axel


fix: ensure local manifest and remote manifest models are comparable

Currently, the change to fully qualified name in the manifest has a discrepancy with the model name that is reported by the remote manifest built.
To fix that for the moment, the comparison is made with comparable model name.
Related to the PR #1362, if we use array of felts or ByteArray, we should then be able to get back to fully qualified comparison on both sides.
This fixes the sozo migrate --world 0x... where transactions are always sent as the migration detects changes, but there are not.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3fd7f3c) 67.41% compared to head (01b95e3) 67.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1424      +/-   ##
==========================================
+ Coverage   67.41%   67.46%   +0.05%
==========================================
  Files         218      218
  Lines       20978    21014      +36
==========================================
+ Hits        14142    14178      +36
  Misses       6836     6836

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[COR-102] Add ability for operator to run psql commands

Add a function to CoreDB implementation that allows for calling psql commands in the primary postgres container. The kube API exec feature is used to connect to the container.

debugging a flake, found this error message.
psql: error: connection to server on socket "/var/run/postgresql/.s.PGSQL.5432" failed: No such file or directory
Is the server running locally and accepting connections on that socket?

that's the message you get when pg not running. something like it's restarting the DB right after it starts? especially since the command before that exits in success oddly

it's just because pg restarts when the container starts because that's how the entrypoint of the PG container we are using is written. will adjust readiness of pod to account for that

running it a few times to check there are not flakes

I'm also having Darren of cincinnati ventures review it

some notes from peering with Darren:
Mods in the lib.rs should go at top of file
Implement CoreDB should be directly under the CoreDBSpec
RENAME kube.rs to coredb.io
What about test fixtures?
Lazy static inside test module?
Rstest?


Improve the speed of the tile layer.

When animating transitions where the center and zoom is changing, only generate one pan action per time step (we had been generating two).
Don't trigger geo events on each tile.
Remove some code that does nothing.  The _deferredPurge feature was never invoked, nor was an already cached tile ever purged immediately.
Cache the tileOffset calculations.
When using the vgl renderer, skip some of the code that is needed by the other renderers.
Reduce the number of times _update is called on the tile layer.  The layer and featureLayer inits were both binding geo.event.*, resulting in two calls to _update each time an event was triggered.  Add a flag to the layer init function to avoid binding events when we know we are going to bind them in the subclass.  We ALWAYS fire a pan event after a zoom event when we generate the events internally.  Therefore, on the tileLayer, ignore zoom events for _update.  It just wastes time.

This is a nice improvement.  LGTM.


Add audio classification for speechbrain

This PR shows how to do audio classification with Speechbrain. This enables inference for existing repos such as

Language identification: https://huggingface.co/speechbrain/lang-id-commonlanguage_ecapa
Command recognition: https://huggingface.co/speechbrain/google_speech_command_xvector
Speaker recognition: https://huggingface.co/speechbrain/spkrec-xvect-voxceleb

FYI @patrickvonplaten @anton-l @TParcollet

@osanseviero lets merge it unless you wanna quickly take care of https://github.com/huggingface/huggingface_hub/pull/312#discussion_r702770252


CIS Checks should all have the CIS tag

All CIS checks should have the CIS tag

PR #642 has a lot of these

This is completed.


HPAT unable to handle non-existent dataframe index name.

HPAT crashes if it gets a Pandas dataframe with non-existent dataframe index.  Many users create ones without such indexes (as is shown in Pandas docs), so it would be useful to fix this bug.
@akharche perhaps the changes to indexing made this behavior happen?
import pandas as pd
import numpy as np
import hpat

df = pd.DataFrame({'0':[100,200,300,400,200,100]})
df2 = pd.DataFrame([100,200,300,400,200,100])
df3 = pd.DataFrame({'A':[100,200,300,400,200,100]})

@hpat.jit
def test_func(data_frame):
    return data_frame

test_func(df) # works with warnings
test_func(df2) # fails and crashes kernel
test_func(df3) # works with warnings

Thank you for the example. I guess this issue is not connected to non-existent dataframe index (I mean the additional column "Index").
Hpat is limited in handling DataFrames created such way df2 = pd.DataFrame([100,200,300,400,200,100]), Hpat expects column name like df2 = pd.DataFrame([100,200,300,400,200,100], columns=['A'])  or a dictionary like in your examples.
It is mentioned in Hpat docs.

So an additional thought then since we are adding this ability:
Is there a way we can elegantly handle unsupported features in the future? As in throw a warning, don't continue, leave as Python Object code?

It is of course possible to just not compile anything and leave the entire function uncompiled.
It's less straight forward to partially fall back to object mode. It is conceptually possible for certain functions, e.g. those which are trivially data parallel. There is no default fallback for others, like reductions, joins etc. The situation is different if we separated distribution from compilation: going to object-mode in (a hypothetical) non-distributed mode should always be possible.


predicting compressive strength of concrete

predicted the compressive strength of concrete using  deep nueral networks and a readme file is attached to it

#27

#27

@all-contributors please add @nitya123-github for Code and Documentation

@all-contributors please add @nitya123-github for Code and Documentation


some small changes in default layout

@vsoch Please have a look !
Compared with https://fly.io/docs.
I observed that current default layout looks like this:
https://github.com/heykapil/tw-jekyll/blob/58b8ae44af642607bd42221b489d6c36435f7268/error-web.png
instead of
https://github.com/heykapil/tw-jekyll/blob/58b8ae44af642607bd42221b489d6c36435f7268/correct-web.png
It has fixed some of glitches that were right there for me:
-Mobile menu is moving left / right while expanding.
-Content in desktop website is touching left side scroll bar (in case of more items in left side bar).

Please ignore uploaded images they are just for reference of layouts being changed.

Thank you @heykapil ! So I do think I remember making this change because (aestehetically) I thought the page was more balanced like this:

versus:

I think visually for the second one, at least for me it felt like there was too much white space between the left navigation and page content, and that's why I changed the structure there.
Perhaps the balance seems off because I didn't also move the search bar? If we remove ml-auto from the search bar we get:

If I remove the long navigation on fly.io to not have the scrollbar - I think it might look more similar to the design without the large space (as it is now, but with the sidebar moved over too?)

Clicking back and forth between the pages I think the see the difference - the fly design left navigation starts further into the page, so that particular spacing looks okay. Perhaps we should try that here (and then we can restore the removed ml-auto?

Thanks @vsoch for pointing out the balanced changes that you made!
But in my case of build the problem is something like this below:
(look at left side bar being too close to content)

Yeah I totally get it! So my proposal is to integrate your changes, but also shift everything slightly more to the right (so left margin is bigger) so it matches fly. Do you want to try that?

And super cool you are making a matrix algebra course! 🧮

Integrated these changes. Much better now. Closing this PR. Thanks again for help!

So you aren’t interested in completing the work and improving the template here? I misunderstood the nature of the PR.

That's not the case, I'll keep suggesting you tweaks, features, changes and possible fixes (whatever i can do to help you in this project) while creating one for teaching my students. I'm from mathematical background and not primarily a programmer, i just know a few things about static websites.
Regarding PR, as discussed it was just a minor suggestion and you were aware of the changes and fixes.
On 19-Mar-2022 4:30 pm, Vanessasaurus @.***> wrote:
So you aren’t interested in completing the work and improving the template here? I misunderstood the nature of the PR.
—
Reply to this email directly, view it on GitHubhttps://github.com/vsoch/tw-jekyll/pull/5#issuecomment-1072988812, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYHINSOYDJGQCAHTUPCO4S3VAWXU7ANCNFSM5RDWOFBQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you modified the open/close state.Message ID: @.***>


docs: :memo: use nightly Rust shorthand in the basics

⚡ Changes

use nightly Rust shorthand count in the code example instead of count.get()

⚠ Notes
In that case, you used both syntaxes.
Since you mentioned at the beginning of the book that nightly Rust will be used in the following code examples, I kept the shorthand syntax.

No, I'd actually like to keep it as is. The distinction between these two/possibility of shortening is discussed at length just below. Your change would update the initial example but not any of the discussion, so the page is now out of sync with itself. The changed version is also more verbose than it needs to be, and clippy will warn that it's a redundant closure, which is true: {move || count()} can simply be {count}.

Thanks for your answer @gbj  👍
I think you didn't get my point. The code example doesn't work when you use the Rust stable version.

Line 31 set_count(3) it's the short version of set_count.set(3), that works only if you use nightly Rust.
I just wanted to make this example coherent.
Does it make more sense, or do I miss something?

I understand that it doesn't work when you use the stable version.
My point is that this page uses count.get() 5 times, and the PR only changes one of them. Changing the text to only update it in one place makes it confusing when reading the whole chapter.
It would be possible to change all five of them to count(). However, I'd

It makes sense 👍.
I made the changes and I also moved 2 code comments. If you think it's not relevant, please let me know.
I let you have a look.


Hail of Thorns isn't working

Applying the automation seems to work. it applies concentration and the hail of thorns buff, but the additional damage and aoe trigger don't happen. The buff and concentration aren't removed after attack.

Seeing the same.

I made some small tweaks for the next update, but it doesn't look broken to me. Please provide your CPR troubleshooter here or on the Discord server.

/////////////// Game Information ///////////////
Foundry: 11.315
System: 3.1.2
Language: en
Chris's Premades: 0.10.61

/////////////// Required Modules ///////////////
Automated Animations: 4.2.72
Build A Bonus: 11.10.2
Dynamic Active Effects: 11.3.17
DFreds Convenient Effects: 6.0.3
Effect Macro: 11.2.2
libWrapper: <IP_ADDRESS>
Midi-Qol: 11.4.23
Sequencer: 3.1.4
Socketlib: 1.0.13
Template Macro: 11.0.1
Times Up: <IP_ADDRESS>
Token Attacher: v4.5.15
Warpgate: 1.19.2

/////////////// Optional Modules ///////////////
Advanced Token Effects: 0.7.2
About Time: 11.0.1
Animated Spell Effects: Cartoon: Missing!
Custom Character Sheet Sections: Missing!
D&D Beyond Importer: 5.1.15
Dice So Nice!: 4.6.10
Simple Calendar: 2.4.13
FXMaster: 4.0.2
Jules&Ben's Animated Assets (F): 0.6.7
Jules&Ben's Animated Assets (P): Missing!
Quick Insert: 2.8.5 (Disabled)
Small Time: 1.19.2
Tidy 5e Sheet: Missing!
Visual Active Effects: Missing!
Universal Animations: Missing!
Gambit's Premades: Missing!
Midi Item Showcase - Community: Missing!

 Here's the info from the troubleshooter.
/////////////// Game Information ///////////////
Foundry: 11.315
System: 3.1.2
Language: en
Chris's Premades: 0.10.62
/////////////// Required Modules ///////////////
Automated Animations: 4.2.72
Build A Bonus: 11.10.2
Dynamic Active Effects: 11.3.17
DFreds Convenient Effects: 6.0.3
Effect Macro: 11.2.2
libWrapper: <IP_ADDRESS>
Midi-Qol: 11.4.23
Sequencer: 3.1.4
Socketlib: 1.0.13
Template Macro: 11.0.1
Times Up: <IP_ADDRESS>
Token Attacher: v4.5.15
Warpgate: 1.19.2
/////////////// Optional Modules ///////////////
Advanced Token Effects: 0.7.2
About Time: 11.0.1
Animated Spell Effects: Cartoon: Missing!
Custom Character Sheet Sections: Missing!
D&D Beyond Importer: 5.1.15
Dice So Nice!: 4.6.10
Simple Calendar: 2.4.13
FXMaster: 4.0.2
Jules&Ben's Animated Assets (F): Missing!
Jules&Ben's Animated Assets (P): 0.6.3
Quick Insert: 2.8.5
Small Time: Missing!
Tidy 5e Sheet: 3.3.1
Visual Active Effects: Missing!
Universal Animations: Missing!
Gambit's Premades: 0.1.20
Midi Item Showcase - Community: Missing!
  I did find the console was generating a warning.

I also disabled all modules, restarted, then enabled only Chris's premades (along with all of the required modules it specified).  Same behavior, and the same message.

Culprit in the end was having the DnD5e concentration automation turned on.  Disabled that, re-enabled Midi-Qol's concentration automation and is now working as intended.  Sorry for the waste of time, I'm not even sure how it was turned on and Midi's disabled.


Release of v1.2.2?

Are there any plans on publishing a new release on PyPI? Looks like mpmath v1.0.0 through v1.2.1 is affected by CVE-2021-29063: Regular Expression Denial of Service (ReDOS) vulnerability when the mpmathify function is called. The flaw has already been fixed in the master branch: https://github.com/fredrik-johansson/mpmath/commit/46d44c3c8f3244017fe1eb102d564eb4ab8ef750
For more details please refer to https://pyup.io/v/51549/f17/.

According to PyPI it would actually be v1.2.2 https://pypi.org/project/mpmath/#history

Oops, actually a duplicate of https://github.com/mpmath/mpmath/issues/648


ReferenceError when using angular plugin

I've been trying to use raven.js and plugins/angular.js in our app , which always seems to result in
60:1 ReferenceError: module is not defined

Tried to load the plugin before and after the main raven.js, also tried loading it before and after the Raven.config().install() without success. I'll probably have some time to investigate in the next few days, but someone else may be able to fix faster?
(related note: using the git/bower version with plugins isn't very well documented, docs seem to point to the CDN versions in most cases)

@geotob – Sounds like #446
How are you loading these files? <script> tags? Or with a module loader?

@benvinegar how did I miss #446, sorry! And there's a PR for it too, great:) And yes, <script> tags it is... who uses module loaders cough

@GeoTob Thanks for clarifying. I've already merged that PR and I am going to put out a 2.1.0-beta release shortly that should solve this.
Closing because dupe.


[CHALLENGE SUBMISSION]

Please provide the following information for your submission:
What is your name? (First, Last)
Marcus Turewicz
Where is your GitHub Repo ?(With your challenge solution)
https://github.com/marcusturewicz/25-days-of-serverless-challenge/tree/master/Day-08
What Challenge is this for? (Challenge number between 1 and 25)
8
(Optional) Anything else we should know? e.g., language used, location, blog post?
C# Azure Functions with Azure Storage of status data, SignalR service for real-time updates to an Angular app.
See repo README for further details and gif of app working.

From all of us on the Cloud Advocacy team at Microsoft, thank you @marcusturewicz for creating this issue!
Have a Happy Holiday season!

THANK YOU FOR YOUR #25DaysOfServerless SUBMISSION
We checked out your repository and are thrilled to say your solution is now listed in our Hall of Fame
Thank you for your contributions!
This issue is now resolved! 🎉


[BUG]: Not able to take volumesnapshots

Bug Description
When trying to create a VolumeSnapshots the creation hanging in pending state forever. According to the csm-isilon-controller log it it missing patch privileges.
After updating the ClusterRole csm-isilon-controller with verb "patch" for
apiGroups:

snapshot.storage.k8s.io
resources:
volumesnapshotcontents

and

apiGroups:

snapshot.storage.k8s.io
resources:
volumesnapshotcontents/status

it start working.  But the operator seems to remove these configuration after a while at which point the VolumeSnapshots fails again.
Logs
2023-09-06T17:39:15.830379848Z I0906 17:39:15.830342       1 snapshot_controller.go:190] updating VolumeSnapshotContent[snapcontent-d673d5a9-b354-4c93-9a73-280a3521d733] error status failed volumesnapshotcontents.snapshot.storage.k8s.io "snapcontent-d673d5a9-b354-4c93-9a73-280a3521d733" is forbidden: User "system:serviceaccount:sebshift-powerscale-csi:csm-isilon-controller" cannot patch resource "volumesnapshotcontents/status" in API group "snapshot.storage.k8s.io" at the cluster scope
2023-09-06T17:39:15.830379848Z E0906 17:39:15.830365       1 snapshot_controller.go:107] createSnapshot for content [snapcontent-d673d5a9-b354-4c93-9a73-280a3521d733]: error occurred in createSnapshotWrapper: failed to add VolumeSnapshotBeingCreated annotation on the content snapcontent-d673d5a9-b354-4c93-9a73-280a3521d733: "snapshot controller failed to update snapcontent-d673d5a9-b354-4c93-9a73-280a3521d733 on API server: volumesnapshotcontents.snapshot.storage.k8s.io "snapcontent-d673d5a9-b354-4c93-9a73-280a3521d733" is forbidden: User "system:serviceaccount:sebshift-powerscale-csi:csm-isilon-controller" cannot patch resource "volumesnapshotcontents" in API group "snapshot.storage.k8s.io" at the cluster scope"
2023-09-06T17:39:17.430232402Z I0906 17:39:17.430226       1 snapshot_controller_base.go:185] Failed to sync content "snapcontent-dab19496-b06a-4e96-b790-d60fc3aee8b7", will retry again: failed to add VolumeSnapshotBeingCreated annotation on the content snapcontent-dab19496-b06a-4e96-b790-d60fc3aee8b7: "snapshot controller failed to update snapcontent-dab19496-b06a-4e96-b790-d60fc3aee8b7 on API server: volumesnapshotcontents.snapshot.storage.k8s.io "snapcontent-dab19496-b06a-4e96-b790-d60fc3aee8b7" is forbidden: User "system:serviceaccount:sebshift-powerscale-csi:csm-isilon-controller" cannot patch resource "volumesnapshotcontents" in API group "snapshot.storage.k8s.io" at the cluster scope"
2023-09-06T17:39:17.430341585Z I0906 17:39:17.430319       1 event.go:285] Event(v1.ObjectReference{Kind:"VolumeSnapshotContent", Namespace:"", Name:"snapcontent-dab19496-b06a-4e96-b790-d60fc3aee8b7", UID:"03e793cd-d9c0-41b3-ad21-a9da77e83468", APIVersion:"snapshot.storage.k8s.io/v1", ResourceVersion:"3668603121", FieldPath:""}): type: 'Warning' reason: 'SnapshotCreationFailed' Failed to create snapshot: failed to add VolumeSnapshotBeingCreated annotation on the content snapcontent-dab19496-b06a-4e96-b790-d60fc3aee8b7: "snapshot controller failed to update snapcontent-dab19496-b06a-4e96-b790-d60fc3aee8b7 on API server: volumesnapshotcontents.snapshot.storage.k8s.io "snapcontent-dab19496-b06a-4e96-b790-d60fc3aee8b7" is forbidden: User "system:serviceaccount:sebshift-powerscale-csi:csm-isilon-controller" cannot patch resource "volumesnapshotcontents" in API group "snapshot.storage.k8s.io" at the cluster scope"
Screenshots
No response
Additional Environment Information
The privileges that seems to be missing in ClusterRole csm-isilon-controller are:

apiGroups:

snapshot.storage.k8s.io
resources:
volumesnapshotcontents
verbs:
create
get
list
watch
update
patch  <---
delete

apiGroups:

snapshot.storage.k8s.io
resources:
volumesnapshotcontents/status
verbs:
update
patch     <---

Steps to Reproduce
Install the Dell Container Storage Modules 1.2.0 and the PowerScale v2.7.0 module.
Expected Behavior
We expect to be able to take a volumesnapshot.
CSM Driver(s)
CSIDRIVERTYPE: isilon   CONFIGVERSION  : v2.7.0
Installation Type
Operator 1.2.0
Container Storage Modules Enabled
isilon v2.7.0
resiliency v1.6.0
observability  v1.5.0
Container Orchestrator
OpenShift 4.11.37
Operating System
RHEL 8.6

Hi N1K68, thanks so much for bringing this issue to our attention -- we will take this up asap and look into a fix.

Hi
I am facing the same issue. Were you able to reproduce?
Running on Openshift 4.12.31

We are syncing permission (RBAC) using ArgoCD but it looks like the operator is changing it back permission.

This bug is being addressed in 1.9.0, thanks for reporting the issue


Tap on Note icon to view and edit note

In the native app, you can tap on a note to view the note in a popup.  There is a pencil icon to edit the note.


feat: add .Values.persistentVolume.volumeName

Summary of changes:
Add .Values.persistentVolume.volumeName to pvc.yaml.
I have a usecase where I configure the PVC to use a SMB CSI/share. I'd like to be able to have the created PVC to always reference this PV, without needing to configure any extra claim templates/manifests.
Checklist:

[x] I updated the artifacthub.io/changes in Chart.yml
[x] Optional: I updated README.md

Hello @chr0n1x
Thanks for your contribution, added!


BAT-P3 List Of Parameters

Hello @johandc,
Where can I locate the list of valid parameters for the BAT-P3 module? I am just getting familiar with the part by reading its datasheet, and I see a list of parameters retrieved with /bin/bash on page 9. That list is titled, "Example telemetry using ‘satctl’ with CAN-dongle on a PC".
I want to get at the description of these parameters and ideally look over their implementation in the available libparam source so that I can identify the types of the arguments as well. If these descriptions are in some document somewhere, that would do as well. Thank you.
Nuertey

The list is in the table on page 7.

Thank you @johandc. I did see the table on page 7. However, I am puzzled that the parameters in that table only seem to be a subset of the actual parameter values shown retrieved in the list on page 9. Should I ignore the extra parameters--for example ina_vbus or gndwdt--shown retrieved on page 9?
I have been tasked to write a module which amongst other things is responsible for exposing an API of the list of parameters for the BAT-P3 and its Aggregator to the user. I simply want to ensure that I have accounted for all possible parameters both write or strictly read. Thank you.
By the way, is the PCDU-12 what is considered the BAT-P3's 'Aggregator'? Thanks.

Yes you can safely ignore some of the many additional parameters. However we do have an additional set of parameters, which we call platform parameters. They are the same on all subsystems, and relate to bootloader, CSP and then there's the ground watchdog. We have description of those in a separate document, as we don't like to repeat them in all datahseets.
Please contact me on my email, for further support. As this big tracker is public.
The PCDU is not the Aggregator module.


Many new functions for the Profiler JavaFX UI

Hi,
I've tried to stage all my changes in such a way that the consecutive commits are as clear as possible.
Some steps (such as the early reverts) are artifacts of my being new to git, so bear with me...
The commit "Refactor Step 8" though is the big one, which actually introduces all the new features.
The full list of UI changes can be found in that step, but for easy reference here it is again.
More features are coming in the near future, such as tree diffs, aggregation across threads (i.e. pull all traces from threads doing similar things together in a single tree), progress bar when loading a larger profile, copy/paste supprt, Tree View filtering, ...
List of functional changes :

Allow opening multiple profiles
Instead of Landing View, open log files or machines from Menu Bar
Use Choice Box for selecting views
Specify filters using UI instead of a string description
Extended filter capabilities :

Also filter on Method Name
Added several comparison operators
Allow hiding threads which contain only "error" frames (works only in Tree View)

Changing filter or removing filter will reapply filters to "original" profile which was filtered
Collapse All / Expand All buttons added in Tree View
Right-click on node in tree view for more expand/collapse options on the node itself
Allow creating a diff of the flat views between two profiles (keyed by method name)

Diff view shows base and new numbers, and highlighted difference

Export flat view or diff view as currently shown (i.e. filters taken into account) to a CSV file (using export button)
Export (part of) a stack in tree view to a text file by right-clicking the node
Show Thread Names in Tree View when known
Show sample counts as well as percentages

Hi @PhRX, great pull request.
I'm worrying about https://github.com/RichardWarburton/honest-profiler/pull/173/commits/2de095ae0506f3400b9fa8c9a4df5c23dc4c3b42. I don't think it's a correct way to solve the issue for Linux. The issue is caused by this lines:
jvmtiEvent events[] = {JVMTI_EVENT_CLASS_LOAD, JVMTI_EVENT_CLASS_PREPARE,
               JVMTI_EVENT_VM_DEATH, JVMTI_EVENT_VM_INIT, JVMTI_EVENT_COMPILED_METHOD_LOAD
 #ifdef GETENV_NEW_THREAD_ASYNC_UNSAFE
        ,JVMTI_EVENT_THREAD_START,
         JVMTI_EVENT_THREAD_END,
        JVMTI_EVENT_NATIVE_METHOD_BIND
 #endif
};

I haven't tested it, but I think placing  #ifdef GETENV_NEW_THREAD_ASYNC_UNSAFE before JVMTI_EVENT_NATIVE_METHOD_BIND will solve the problem and will not introduce any new one.

Hi @ikavalio,
All I can reasonably say is that the fix (proposed by a colleague) works for me and my colleagues, but AFAIK we're all running Linux Mint, or maybe Ubuntu in one case.
I guess that if JVMTI_EVENT_THREAD_START and JVMTI_EVENT_THREAD_END are safe events on any platform, then your proposal makes more sense.
At any rate I'm fine with that commit being excluded, it's fairly trivial for me to keep it locally. Alternatively, feel free to add a commit with your proposed change to the pull request, or let me know if you want me to do that.
Apologies for the formatting issues BTW, which make the diff unclear. This was my first in-depth encounter with git so I suffered from some teething problems (CRLF in this case). I'm more or less up-to-speed now.

Hi @PhRX,
I've pointed out to this change only because it breaks existing functionality as it seems to me. Sorry I can't compile and test agent at the moment, but it looks like in your case controller won't be started at all under Linux. Controller will be started only if GETENV_NEW_THREAD_ASYNC_UNSAFE is undefined (for all platforms except FreeBSD and OS X by author's design). But after that commit it will defined for Linux as well:
#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__linux)
   #define GETENV_NEW_THREAD_ASYNC_UNSAFE
#endif
...

#ifndef GETENV_NEW_THREAD_ASYNC_UNSAFE
     if (CONFIGURATION->host != NULL && CONFIGURATION->port != NULL) {
         controller->start();
     }
 #endif

Could you please clarify that you can control your agent by TCP socket?
I do believe that it is safe to define JVMTI_EVENT_THREAD_START and JVMTI_EVENT_THREAD_END events for all platforms, at least I can't imagine any situation why this events should be disabled for Linux. I'm not original author of this code, but it looks like a wrong place for ifdef.

Hi @ikavalio,
I fixed it as per your suggestion. All tests pass, and the start=1 autostart feature still works on Linux as well.
Thanks for the clarifications !

I've started looking through the PR, it is very large and the work is appreciated.
It would make it easier to review this work if better discipline was exercised around style/white-space/formatting changes which increase the noise. This is mostly a fault of the review tools IMO, but still makes the reviewer life harder.

Hi @nitsanw,
I fully understand your frustration, and I apologize for the formatting changes, which may seem arbitrary.
In my defense however, a number of points I'd like to make :

The formatting of the source material seems variable. The maximum length of the lines before wrapping is as far as I can tell not constant. This is undoubtedly a natural consequence of having various contributors with varying IDEs.
I have checked in the settings for my Eclipse formatter. I did take quite some time to try and get the settings such that any reformatting would affect the source as little as possible - i.e. I tried to craft it so that the vast majority of the conventions on this project are respected. The places where it doesn't are either an oversight or mistake on my part, or due to the limitations of the formatting options in Eclipse.
I have Eclipse automatically format the file when I save. This, in the long run, makes for the most stable history, since any formatting mistakes get automatically corrected to a standard. Also, since I want to proceed really really fast, and the formatting rules for this project does not conform to my current "style" (which is 90% determined by the local dev team here, and 10% of my own "quirks"), auto-formatting is the easiest way of ensuring the format is fairly stable.\
I paid special attention to any code in the core part, since I try to change that as little as possible. The FX part, I cared less about, since the volume of my changes would make diffing a pretty hairy business by any standards. Also, the first batch of changes (called the refactoring in the commit comments) was made in a different VCS, because I wasn't sure at that point whether my changes would be worth contributing...

As I wrote to @RichardWarburton at some point, I think formatting/whitespace/... should be treated much more like skinning by all development tools : when you're coding and viewing, the code should be auto-formatted to your own standards. Whenever published/checked in, the code should be auto-formatted to the repository standard. But, of course, that ain't the current way of things :(
So again, apologies for the frustration. I'll turn the format-on-save off from this point onwards, to try and ensure more consistency with what is already there...

@nitsanw Alternatively, if you have eclipse formatting settings (or for some IDE) which do conform to what you need, please feel free to send them my way, that'd be optimal AFAICS.

"I have Eclipse automatically format the file when I save. This, in the long run, makes for the most stable history, since any formatting mistakes get automatically corrected to a standard. Also, since I want to proceed really really fast, and the formatting rules for this project does not conform to my current "style" (which is 90% determined by the local dev team here, and 10% of my own "quirks"), auto-formatting is the easiest way of ensuring the format is fairly stable."
I think this is the culprit. I believe there is an option to reformat only code which you touch.
Re-formatting the licence blurb and existing toString methods is just making a large change larger.
If you do want to tackle formatting it is better done IMO as separate, explicitly non-functional PRs, but that's extra work so mostly people skip it.
I would appreciate it if you worked through the diff and reverted any formatting changes. You are in a better position to tell what's whitespace and what isn't, but I understand if you don't have time for that.

@PhRX to be clear, I don't care about formatting, just the overheads of reviewing. If tools hid all the semntically neutral choices from me I'd be happier.

@nitsanw OK I changed the setting to only format edited lines.
I'm not very familiar with github (or git for that matter) yet so quick question : you just posted a number of diffs as reviews on this pull request. Are these "proposed changes" I can accept somehow on github, or do I have to manually check and repair the diffs in my IDE for each file ?

@PhRX Further note, I think it's great you're investing your effort here. I also understand you are tacking quite a few issues as you find them. Please consider that smaller PRs are MUCH MUCH easier to review and merge (on all project, not just this). So if you have bits of this PR (or future PRs) which can be separated to different PRs, it would help if you did that.

@PhRX these are comments on the diff, not changes. You can choose to act on those, or discuss them or ignore them. I add them to mark bits of the review I need not look at at this point.

@nitsanw Not being familiar with github, pull requests etc., I basically staged the refactoring into separate commits which were as small and coherent as possible. This was after I had a couple of days of changes already in the local VCS. The idea was that each commit in that refactor could hopefully be reviewed separately and more easily.
However I didn't know yet that commits "pile up" in the PR, so it all becomes one big effort from review point anyway.
After the initial "big push" I've been committing as nicely as possible - i.e. one "real change" at a time, with as few files affected as possible. I still don't see however how I can translate this to smaller PRs, since the commits will be bunched up into it. Short of branching for each change of course, but then the VCS overhead on development starts to become prohibitive.
Not having reviewed anything on github, I don't have any idea what "works" and "doesn't work" as workflow. I'll google some articles on git(hub) workflow.

@nitsanw OK having thought over what is the most efficient use of my time, I propose that I fix the formatting to be 100% consistent with the "original code" for all classes outside the ports.javafx package. That should make it easily reviewable.
In ports.javafx, I've pretty much rebuilt most of the UI anyway, reusing only a couple of the components. The amount of changed code is big enough to make reviewing by looking at diffs impractical IMHO. Just trying it out and seeing whether things work as expected would take a lot less time (keeping in mind that tree filtering is broken, if I have time left I'll fix that today).

@nitsanw I think I reverted all unnecessary formatting differences from unchanged lines in the core package. Thanks for reviewing BTW :)

Hi, just a head's up.
I'm happy to review this PR at some point. But with 8000 lines total diff I don't see time for it in my schedule soon. That's not to say that the work isn't appreciated, but for future reference the best way (for both you and me) to get changes into this project are a series of small, single-feature changes. Things that could be reviewed quickly and easily.

Hi @RichardWarburton,
Yes, now that I'm a bit more familiar with the github workflow I see how I can do this both technically and organizationally, and I'm committed to doing just that, get the future changes in nicely bite-sized (I've been doing that at commit/push level for a while now). The most important realization for me is that a PR actually keeps growing with new commits (I originally thought it grouped the commits at the PR point and that only explicit additions to the PR would be added, i.e. some sort of lightweight fork I guess).
Unfortunately, for this particular PR that boat has long sailed, and I'm painfully aware I should have gone about it a bit differently...
To resolve I'm working towards a particular milestone which I have in mind - which is the implementation of the Tree Diff view, and some refactoring to make the Controllers a lot cleaner.
I'll mark that point with a label, and fork (I guess, but I'll do some research into what is the best "git-way-of-doing-things" in case of frequent changes).
After that, the reviewing effort should be simplified somewhat :

The code in the core package can be reviewed using the classical diff-based reviewing. I've taken pains to ensure there's no "noise" left from reformatting or styling differences, and to keep it 100% backward compatible (i.e. if you were to move the core code into the code before the fork, it should just work).
The code in the javafx package should probably be reviewed at that point "on its own merit", i.e. diffs will probably not help at all - correctness would possibly be best accounted for by just trying it out, and style/code quality can be determined by looking at the classes on themselves, which should be reasonably fast since I'll refactor for clarity and simplicity at some point before the milestone.

In the meantime I hope some people at least get some joy from the new features...
Thanks, and best wishes,
Philip

@PhRX please let me know when you are done and I'll review

@nitsanw Much appreciated ! If all goes well (but does it ever...) II hope to finish the "milestone" tomorrow.
I've already cleaned up/refactored a lot, and the code has become simpler and controllers less cluttered. The last major bit left over is cleaning up (and slightly fixing) the renditions of the columns in the tables.
But that's for tomorrow :)

Hi @nitsanw and others,
I'm done for the milestone I set myself, which means I won't add anything to this PR anymore unless by explicit request from reviewers.
I refactored to eliminate duplicate code as much as possible, documented the abstract controller superclasses, and tried to homogenize the naming as much as possible.
As a result, the javafx code should be a lot more readable, and concise.
There's one outstanding issue I'm aware of: the context menus on the comparison (or diff) tree view are having issues and are only appearing sporadically. There's an underlying bug somewhere I'm sure but I wasn't able to locate it. I have to leave that for next monday...
Xeers,
Philip

Hi,
Re: Gradle : does providing the extra alternative break anything? My aim was not to change it, but to have it as an alternative for anyone who has their tooling set up for gradle rather than maven. My own first checkin was very neutral. The second commit contained changes made by a colleague, I think it didn't add anything that would break the maven build ?
Also, the gradle wrapper mechanism (./gradlew run) makes it very easy for anybody without any tooling to run the project straight away (well the java part at least).
Re: Formatter: I'm ok with defining a common style using eg checkstyle. However I don't think checkstyle contains any actuall reformatting tools, only checkers ? The idea of checking in my formatter (which can be updated very easily) is to help people who happen to be using eclipse to maintain the format. I'm willing to construct equivalent settings for IntelliJ or any other IDEs and check those in too.
Generally I try to follow an inclusive approach - which is to provide tools or configuration for all kinds of setups rather than singling out any particular one as the "One Ring To Rule Them All" :) . I know it's a bit more work and might be the occasional source of an issue but the payoff should to my mind be that more people might pick it up more quickly and contribute. I know that if proper formating settings had been available to me when I started out on this, the formatting issues with my early commits would never have occurred.
Anyway, It's ok for me if the gradle or eclipse files are not integrated. I guess I could maintain them pretty easily on a separate fork just for that purpose.

I figured out the issue with the context menus last friday and fixed it (and i18ned the menu text in the process). What would be the way to go for these fixes: check them in on a new branch from my fork?  Or wait until the PR is closed ?

@PhRX
Thanks for your reply, comments inline. If possible in future replying to specific comments directly rather than on the main thread might help, but I didn't want to just ignore your reply so I've replied to it here. I'll try to find some time this week to review a bit more of the PR, but I'm very busy atm so it might take some time.
re: build system - The reason I don't want to accept multiple build systems is that it makes the whole project much harder to maintain going forward. If someone has a pull request that touches the build system they have to test it with both and maintain both. if someone reports a compilation, testing or heck even a runtime issue I need to know what build system to reproduce it with. Not having a canonical build script that can build a project is a big fail IMHO. I really wouldn't be happy maintaining the project with multiple build systems.
I think the same thing with maintaining IDE-specific configuration. It would be much better to use an Independent tool that can be imported into any IDE and then maintain the configuration in one place, rather than in multiple places.
re: merging menus/i18n: I think I would appreciate not merging in any more changes until we can get a handle on the existing PR. Having said that if the i18n stuff helps cleanup any other code or helps you improve things more easily then I'm ok with it being merged into this PR.

@RichardWarburton
Thanks for your insights !
I'll maintain the gradle build stuff on a new fork then. Easy enough for me to manage in that case and it doesn't affect the main project at all. I'll always merge from the master to the fork so that other than the gradle stuff there's no differences. And any other work I do can be done on branches from that fork, and I can launch my PRs from there (and I should be able to exclude any gradle-related commits from the PR).
Should I delete the gradle files from the PR myself, or can you, when eventually merging the PR, just choose to leave them out ? I.e. not 100% sure whose responsibility this is.
I do hope that for maven you have something lined up along the lines of the https://github.com/shemnon/javafx-gradle javafx gradle plugin, which, although no longer maintained, still works and makes it easy to create e.g. an "all in" package (including a runtime java) which has linux and/or windows executables starting up the application. It's great for providing a no-config deployable for end users.
I also checked and found out that it's possible to generate an eclipse formatter from checkstyle configuration (see http://stackoverflow.com/questions/984778/how-to-generate-an-eclipse-formatter-configuration-from-a-checkstyle-configurati) so yes, having just a checkstyle config checked in makes more sense with that in mind. Same question though - do I delete the eclipse formatter config in the PR or can the PR merger just leave it aside ?
Finally - yes I'd like to integrate the context menu fix + I18N, since it does make the superclass code a bit more consistent (I introduced 2 slightly different ways of configuring columns trying to fix the issue, only the issue was something else entirely; the code is a little less consistent as a result). I need to clean it up, I'll push the changes in an hour or so unless I get feedback in the meantime not to do that after all...

Hi @PhRX,
re: gradle I think it would be better if you removed it. Easier if it's just you editing the PR ;)
I don't know if there's a maven equivalent to the plugin you linked. I don't even object necessarily to switching the build to gradle as such. I just don't want to have two build systems or worry about build system differences in this PR. But I think such a move should probably be an issue that we discuss separately.
re: other points: awesome!

To any potential reviewers : In the meantime I've reworked quite some things, and everything is now on the "integration" branch of my fork.
If nobody has started reviewing this PR yet, then it might make sense to merge my integration into this PR, since the code is more consistent still, and has a number of important improvements and fixes (see below).
I think it won't be (much) more work to review this new state - there is a bit more code, but everything has been streamlined a lot so the important bits of code tend to be concentrated, with little unnecessary duplication, and it should be easier to read.
Also, I documented (javadoc) a number of methods/classes already, which should make things a bit easier. I'll do more documentation in the near future, hopefully.
Please let me know what you think - merge into the PR or wait for the current PR to be accepted before submitting a new one ?
Here's a list of the most important changes :

FileLogSource now has a limited-size buffer which is a moving window over the file. Latest version also is fixed for the issues which arose from not taking into account that position could be set backwards in case of partial reads
Top-level frames of stacks are now aggregated correctly - inside a thread there can be multiple top-level frames
Time is now processed and aggregated, and shown. All views now have consistent data
Aggregation happens at "fully qualified method name" (FQMN == FQCN + method name) level, so a method shows up only once in the flat view. Everything is in place to make it a user option to aggregate on method id instead, or FQMN + line nr, or file + bci or whatever.
LogCollector / Profile / ... has been replaced by LeanLogCollector / LeanProfile / ... In this new setup, the collector does much less aggregating. An emitted profile is passed to a background task which turns it into an AggregationProfile (starting point for aggregations). The result is published to the front-end by the task. This effectively decouples the thread responsible for parsing / profile emission and the FX thread for updating the UI.
The LeanLogCollector now operates on a pull-model : the front-end signals it'd like a new profile, and only then the collector will emit one. This means the emission rate can now easily be controlled from the front-end. The collector won't emit profiles when not asked for, which saves on processing for that thread.
Filtering is now much more generic, and works on all columns - although there are some semantic issues left with tree filtering; and for time filtering the input still is in nanos whereas the display is in ms, so that's to be fixed.
The Controllers have been refactored and share a lot more code at different levels, making them much easier to read and maintain. Column & field names have been standardized internally for easier maintenance as well.
Monitoring or opening the same log now is blocked.

In the meantime I've added new features on the integration branch on my fork (by branching then merging, to somewhat separate the various features and fixes). If nobody has started reviewing this PR, wouldn't it make sense to merge integration into it ? If anything, there's more documentation, and the code should mostly have become cleaner and clearer. On the minus side, yes, there's even more of it.

Obsoleted by #184


Tobin gh643 fb valid usage

Add all Framebuffer valid usage checks along with tests to verify the checks.

Tobin, this looks great!  +1.  I really like the comments.

:+1:

cherry-picked and pushed to master


fix(v8): improve SubmissionError detection

Now event after obfuscation, or importing SubmissionForm
from a different context, isSubmissionError will return true
only for SubmissionError
Closes #4641

Codecov Report

Merging #4652 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4652   +/-   ##
=======================================
  Coverage   99.47%   99.47%
=======================================
  Files          74       74
  Lines        1709     1711    +2
=======================================
+ Hits         1700     1702    +2
  Misses          9        9

Impacted Files
Coverage Δ

src/immutable.js
100.00% <ø> (ø)

src/index.js
100.00% <ø> (ø)

src/SubmissionError.js
100.00% <100.00%> (ø)

src/handleSubmit.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 638dc44...0af5b20. Read the comment docs.


New version: GeoStatsBase v0.5.0

Registering package: GeoStatsBase
Repository: https://github.com/juliohm/GeoStatsBase.jl
Created by: @juliohm
Version: v0.5.0
Commit: 39cb2e97cacf63477f62100e8034a312093c71b6
Reviewed by: @juliohm
Reference: https://github.com/juliohm/GeoStatsBase.jl/commit/39cb2e97cacf63477f62100e8034a312093c71b6#commitcomment-33986843

Could you please merge without the explicit restrictions? As I mentioned in
other PRs. I'm intentionally dropping old lower bounds created before Julia
1.x. they are just polluting my Project.toml files.
Appreciate if you can merge this and other PRs because currently
GeoStats.jl solvers are in a broken state.
On Tue, Jun 18, 2019, 04:42 Fredrik Ekre<EMAIL_ADDRESS>wrote:

@fredrikekre commented on this pull request.
In G/GeoStatsBase/Compat.toml
https://github.com/JuliaRegistries/General/pull/1423#discussion_r294650396
:

@@ -16,6 +16,6 @@ Parameters = "0.7.3-0"
["0.4.1-0"]
julia = "1"

-["0.4.2-0"]
+["0.4.2-0.4"]
Parameters = "0.7.3-*"
Please keep these restrictions for 0.5
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JuliaRegistries/General/pull/1423?email_source=notifications&email_token=AAZQW3L2GBNGWQUR24BYCY3P3CGX7A5CNFSM4HYZYUJ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB32JSUI#pullrequestreview-250911057,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZQW3OXFXCLI5H2GV6K2B3P3CGX7ANCNFSM4HYZYUJQ
.

I have to say it is annoying to add these compat entries manually when the value added is minimum.
Anyways, since I am forced to do this, the PR is now updated. Could you please merge now?
Answering your question. When you merged DirectGaussianSimulation.jl for example without merging this PR, the package is assuming that the changes in this PR are available, and they are not. That is why the solvers are broken.
Please consider adding some mechanism of PR dependency where the JuliaRegistrator is informed of dependencies not merged in General.

Answering your question. When you merged DirectGaussianSimulation.jl for example without merging this PR, the package is assuming that the changes in this PR are available, and they are not. That is why the solvers are broken.

Can you given an example? The new version of DirectGaussianSimulation requires GeoStatsBase 0.5 so it should never be installed. If you still got that new version it is a bug in Pkg that you should report.

I see so the new version will not be installed in anyone's computer until
the dependency is merged. Makes sense.
On Tue, Jun 18, 2019, 18:58 julia-tagbot[bot]<EMAIL_ADDRESS>wrote:

I've created release v0.5.0, here
https://github.com/juliohm/GeoStatsBase.jl/releases/tag/v0.5.0 it is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JuliaRegistries/General/pull/1423?email_source=notifications&email_token=AAZQW3LN3LPJHIUQ3XVWRMLP3FLAFA5CNFSM4HYZYUJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYACY4I#issuecomment-503327857,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZQW3NVHS36PUJYR6DKZADP3FLAFANCNFSM4HYZYUJQ
.


Add id or cssClass option to rating stars wrapper

The component is awesome, but I need to style the parent wrapper (that holds individual stars) to things like align center. currently it doesn't have a css id and the props don't get passed through

You are not the first one requesting this kind of flexibility (#68). I think it makes sense to propagate the className to the wrapper element. I will take a look.

Now id, style, and className are propagated to the container element.
Released in version 1.2.0

I'll take care of publishing the new version to npm and updating the docs about this, during the weekend.


.add() method

Summary
No idea how to start
Description:
I know that

check if student available, orElse(new Student)
check if module available, orElse(new Module)
check if Assessment available, orElse(new Assesment)
but I have no idea how to start this with.

Code Snippets
Attach code snippets (if any)
Screenshots
Screenshots (if any)

Hi, I think you can make use of put().
My idea is: If the input Module exists, then put the input Assessment into the existing Module, orElse put the input Assessment into a new Module. Do the same when you check for existing Students.
But I did the "checking" and "putting" separately. I assigned the Module (existing or new) to tempModule first, and similarly for Assessment and Student. Then at the end I returned a new Roster with:
return this.put( tempStudent.put( tempModule.put( tempAssessment ) ) );

Hope this helps!

Hi! I think you do not have to check if Assessment is available, you can immediately create a new Assessment with the given title and grade. If the assessment already exists, then it will be replaced by the new Assessment since their keys are the same, so there will not be any duplicates!
As what Zhe Ming says, you can use the put method to update the roster.

Assessment findAssessment = new Assessment(assessment, grade);
moduleMap = moduleMap.put(assessment, findAssessment);
If assessment exist, it will update the grade. else, it will add to the records.
Hope this helps


[FEATURE] longhorn backup alerts

Hello,
We are having more and more Kubernetes clusters using longhorn as a storage and it becomes difficult to go into each cluster and check whether the backups are done properly, therefore i'm writing to you guys to ask if we can have some alerts as email notifications or so about the status of the backups for each volume within a cluster.
Thanks.

I feel like the the monitoring & alerting (email, etc) might be out of scope of longhorn.
Then a simple cron/batch or prometheus service is all that would be needed and could be shared by the community.
What we can improve on though is make it easier to retrieve the status of a backup / job :)
We started doing so with the creation of the backup CRD's but some additional work on the reoccurring jobs might be necessary.
CC @innobead @c3y1huang @jenting

I feel like the the monitoring & alerting (email, etc) might be out of scope of longhorn. Then a simple cron/batch or prometheus service is all that would be needed and could be shared by the community.
What we can improve on though is make it easier to retrieve the status of a backup / job :) We started doing so with the creation of the backup CRD's but some additional work on the reoccurring jobs might be necessary. CC @innobead @c3y1huang @jenting

Well, having some Prometheus metrics is also fine.
One of your colleagues said that an community user provided the Prometheus configuration on how to monitor the backup and send alerts, can i have the link please?

Well, having some Prometheus metrics is also fine. One of your colleagues said that an community user provided the Prometheus configuration on how to monitor the backup and send alerts, can i have the link please?

cc @PhanLe1010

Related to the prometheus metrics for backups. Ref:

https://github.com/longhorn/longhorn/issues/2940
https://github.com/longhorn/longhorn/issues/1180#issuecomment-693003131

Closing this and follow up with #2940 instead.


String Interpolation

This PR is based from #6339

closing this so i can reopen it on a fork that I can push to...


start: more Windows (Cmd) blocks

Follow-up to #3273

Per #3311 (rel #2939) - Data Versioning page

Our statistics show we have very few Windows cmd users, anyone who's interested in DVC is using it on WSL probably. I think we can deprioritize this.

@iesahin this fixes existing Windows tabs in https://dvc.org/doc/start/data-and-model-versioning, please approve/merge and we can figure out whether to remove them later. That's a discussion for https://github.com/iterative/dvc.org/issues/3311


is display_svg possible?

Hi, great plugin, I got vim to talk to ipython and was able to produce a matplotlib plot thru %matplotlib qt ; but I couldn't figure out how to display an svg image (nothing shows up but the console doesn't complain, it simply shows the In[10]: line ). It seems that Ipython can display images using a similar approach from here: [(https://stackoverflow.com/questions/28237210/image-does-not-display-in-ipython)]
I tried

from IPython.display import display_svg, SVG
SVG(img.write('svg')) ) #img.write is from another module that writes SVG imgs
display_svg(img)

It works in jupyter. Can it work thru your plugin? Thanks for your time.

It works in jupyter.

You mean jupyter notebook? We need something that can display an svg image. I can imagine adding a handler that writes images to a temporary file and then a user-specified command to open it in a tab of their browser of choice.


oso-nodejs: make support for 'not' operator in custom data filtering conditions

Yes, I know we could use negative conditioning instead of not operator, but providing built-in support for not operator comes handy when we are dealing with conditions using big list of values.

Also, the list condition (example: using 'in' operator) trying to convert into simple conditions using 'or/and'  operators, which is ok with small list but against the large list !! this is not an efficient way to do that. so, providing straight forward solution to this will help. like following
{
   lhs:{
     typename:'Article',
     fieldname:'id'
  },
  cmp:'in',
  rhs:{
    value:[] // for very large list
  }
}

Classic example would be fetching all the repos(let's say 100+ repo under his id) of a user. if we'd support in operatory then the query conversion would be easy and efficient by using sql 'in' operator.

Hi @trendchaser4u , I think (2) is a great suggestion, since the whole point of data filtering is to produce efficient queries. Could you give an example of what you mean by (1)?

Sure,
I'm not a big fan of using not with in operator, but still we can't predict the use cases.
For argument sake I've a list of premium suppliers and want to fetch the list the products from the non-premium suppliers,
like this..
let premiumsuppliers=[...]; //25 items
Select * from product p where p.supplier not in (...premiumsuppliers);


Dubbo GSoC 2023 - Refactor the http layer

Background
Dubbo currently supports the rest protocol based on http1, and the triple protocol based on http2, but currently the two protocols based on the http protocol are implemented independently, and at the same time, they cannot replace the underlying implementation, and their respective implementation costs are relatively high.
Target
In order to reduce maintenance costs, we hope to be able to abstract http. The underlying implementation of the target implementation of http has nothing to do with the protocol, and we hope that different protocols can reuse related implementations.
https://issues.apache.org/jira/browse/DUBBO-112

Hi. Community, I am doing research on the http refactoring plan. I will reply to the instructor after I understand it.

Discussion related to this issue


Linked List cycle

would like to solve this problem
https://leetcode.com/problems/linked-list-cycle/

@piyushsharma220699  can you please assign this to me ?

I would like to solve this problem using Java with proper explanation if assigned.

Assign this, I can do this in Java/C++/Python with explanation.

@shraddhavp Which Language?
@abhi-43 Assigned in Java
@katariahk Assigned in Python :)

plz assign me this problem in c++

@piyushsharma220699  in C++

@piyushsharma220699 Could you please assign this to me in cpp? I'd like to make my contribution with my personal understanding of it.

@shraddhavp I'll assign this to you in C++, but now this repo has been excluded from Hacktoberfest 2021, please read the pinned issue of this repo to know more!

Hii , I am able to fix the issue in a optimal way in C++. Please assign to me.
Thanking you...!!!

@piyushsharma220699 please assign this to me in C++


Add a forked version.

Changes to the forked version:

Required packages are not hardcoded in the setup.py file. All the required packages are inside the requirements folder.
Package requirements are broken down into separate files::

.. code:: bash
├── requirements
│   ├── dev.txt
│   ├── prod.txt
│   ├── test.txt

Creates a default class based on the package name.

Thanks @ardydedase.


⚠ Bofrost.fr has degraded performance

In 32709fc, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1713 ms

Resolved: Bofrost.fr performance has improved in 86f005e after 7 minutes.


[Smart File System] zero sized files should not be handled as invalid

i really love the smart file system, i already blogged about it and integrated it in some projects. it behaves smart and helps me to get unified SmartFileInfo <3 but in the case of zero sized files it behaves too "smart". since when a zero sized file is an invalid file? if i want to compare 2 directories if, for example, all log files are initialized with empty or filled files it simply would "eat up" all my zero sized files, which are perfectly valid files.
i was starting a merge request but then i saw that there even exists a text for exact this behavior. :(
so i decided to open a ticket first.
please handle zero sized files as normal files. in my opinion the currently behavior is wrong and can lead to really unexpected behavior. also that it happens silent leads to a WTF behavior™ which this package "promised" to prevent not produce.
my suggestion would be to change this behavior or at least to make in configurable as in the symfony finder.
Symfony\Finder:
...
    public function __construct()
    {
        $this->ignore = static::IGNORE_VCS_FILES | static::IGNORE_DOT_FILES;
    }
...
    public function ignoreUnreadableDirs($ignore = true)
    {
        $this->ignoreUnreadableDirs = (bool) $ignore;

        return $this;
    }
...
    public function ignoreDotFiles($ignoreDotFiles)
    {
        if ($ignoreDotFiles) {
            $this->ignore |= static::IGNORE_DOT_FILES;
        } else {
            $this->ignore &= ~static::IGNORE_DOT_FILES;
        }

        return $this;
    }
...

Not sure why that was added anymore :thinking:
Feel free to make Smart approach default and include those empty files

Closed by https://github.com/symplify/symplify/pull/1936


rename integrational_tests directory

!test

Refer to this link for build results (access rights to CI server needed):
http://jenkins.2gis.local/job/vmmaster.staging.regression/167/
Test PASSed.

:+1:

:+1:


Verify compiler will catch missing returns in the future

We have to reproduce why 2d5510fdbbebdd17867c55f17f629d944e3411aa wasn't caught by our CI. Maybe the compile flags are too forgiving.
You can assign this issue to me, I'm already working on it.

It was caught by the compiler, we just missed it because we didn't use -Werror, see e.g. Job #4.1

See PR #13

Thanks!


Items not being update when item props change

Hi!
I'm not sure if I'm doing something wrong but I'm having problems whith list items no being updated when props change.
I have a list with items in ReactList
<ReactList
    itemRenderer={this.renderItem}
    length={items.length}
    type="simple"
    pageSize={PAGE_SIZE}
    view={preferences.listView}
/>

Every item has a button to mark it as Favourite. This button triggers an Action and then it should receive new props and show a Fav icon. This works fine if use items.map(function(listItem){...}) but when using ReactList, items are not updated. When clicking this fav button nothing change but when I reload the page, the state has been changed.
Seems like itemRenderer should trigger when an item is updated. Am i wrong?
Thank you!

Duplicate of #36.
ReactList has no notion of your items object, so it can't know to update when you modify it.


cibuildwheel doesn't build Windows libraries

When cibuildwheel attempts to download Python 3.5 (32 bit), an undisclosed error occurs.
If this issue occurs only for Python 3.5, I will have to drop support for it in upcoming releases.
But before that I need to do some investigations.

No tears here for dropping 3.5.

I wouldn't miss it either, but unfortunately the issue exists for all Python versions and not just 3.5.

The issue was fixed in cibuildwheel v1.11.0.


Context max size is 8bytes PA-RISC require 12bytes

Having a context with more then 8 bytes result in shift overflow because internally the constraint of context is done using u64.
The error message is thread 'main' panicked at 'attempt to shift left with overflow', icicle-emu/sleigh/sleigh-compile/src/matcher/cases.rs:130:24, but the problem is more widespread. such in:
https://github.com/icicle-emu/icicle-emu/blob/2706b71b0275b0ceae2aa0ee9b83aef1866213b4/sleigh/sleigh-compile/src/matcher/cases.rs#L75
A temporary solution is to replace the u64 with u128s.
The final solution could be using Vec<u8> instead of INTs for constraining pattern/context bytes, or even something like Vec<Option<bool>> for individual bits.

I had thought this could have been an issue, but none of the sleigh specifications I tested with required large context values.
The reason u64s were used is for performance since case matching is probably the most time consuming part of decoding. So some amount care will be required to handle this well.
My original idea was to split matching into multiple steps whenever large matches are required, however this is somewhat complex to implement, particularly when taking into account backtracking.


Avoid using slots dunder method

The attrs 18.2.0 package adds an additional item to __slots__ that is not present in the defined attributes.

Demo
master: https://ocd.appscale.com:8080/job/Create-Eucalyptus-Image/6501/
branch: https://ocd.appscale.com:8080/job/Create-Eucalyptus-Image/6502/


Vulnerability of dependency "golang.org/x/net"

Hello, we are a team researching the dependency management mechanism of Golang. During our analysis, we came across your project and noticed that it contains a vulnerability (CVE-2022-41723). In your project, the golang.org/x/net package is being used at version golang.org/x/net v0.0.0-20211112202133-69e39bad7dc2, but the patched version is v0.7.0. To fix the vulnerability, we recommend modifying the go.mod file to update the version to v0.7.0. Thank you for your attention to this matter.

done


chore(deps): update common-dev-assets digest to 6565341

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
10ac9e5 -> 6565341

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 4.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


no 'classify_image' and error: msrest.exceptions.HttpOperationError: Operation returned an invalid status code 'Request-URI Too Long'

Trying to run the code, I think the SDK has changed and I am getting the error "Request-URI Too Long".
Python 3.6.6 on Windows 10
azure.cognitiveservices.vision.customvision.prediction version 2.0
when you run dir(CustomVisionPredictionClient), you see the following:
['class', 'delattr', 'dict', 'dir', 'doc', 'enter', 'eq', 'exit', 'format', 'ge', 'getattribute', 'gt', 'hash', 'init', 'init_subclass', 'le', 'lt', 'module', 'ne', 'new', 'reduce', 'reduce_ex', 'repr', 'setattr', 'sizeof', 'str', 'subclasshook', 'weakref', 'close', 'predict_image', 'predict_image_url', 'predict_image_url_with_no_store', 'predict_image_with_no_store']
note there is not a 'classify_image()' used by the sample.
Running the following code:
from azure.cognitiveservices.vision.customvision.prediction import CustomVisionPredictionClient
import os
prediction_key="81cc"
ENDPOINT="https://southcentralus.api.cognitive.microsoft.com/"
projectId="ded569"
predictor = CustomVisionPredictionClient(prediction_key, endpoint=ENDPOINT)
dirToProcess = "C:\Users\ksaye\Desktop\movement"
for filename in os.listdir(dirToProcess):
print("processing: " + os.path.join(dirToProcess,filename))
image_contents = open(os.path.join(dirToProcess, filename), mode="rb")
results = predictor.predict_image(projectId, "Iteration 1", image_contents.read())
print(results)
I get the error below:
C:\Users\ksaye\Desktop>python classifyImages.py
processing: C:\Users\ksaye\Desktop\movement\26223.jpg
Traceback (most recent call last):
File "classifyImages.py", line 14, in <module>
results = predictor.predict_image(projectId, "Iteration 1", image_contents.read())
File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\lib\site-packages\azure\cognitiveservices\vision\customvision\prediction\custom_vision_prediction_client.py", line 206, in predict_image
raise HttpOperationError(self._deserialize, response)
msrest.exceptions.HttpOperationError: Operation returned an invalid status code 'Request-URI Too Long'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 646cbb8a-041e-9d99-0385-272f31793552
Version Independent ID: b9ae4376-2e8f-f311-8b1b-d4e3120bf5b5
Content: Quickstart: Create an image classification project with the Custom Vision SDK for Python
Content Source: articles/cognitive-services/Custom-Vision-Service/python-tutorial.md
Service: cognitive-services
Sub-service: custom-vision
GitHub Login: @areddish
Microsoft Alias: areddish

@ksaye, Thanks for the feedback! We are investigating and will update you shortly.

@ksaye It looks like there’s an older version of the python package installed. You will need to upgrade to the latest version to use classify_image.
If you are installing via pip then:
pip install —upgrade azure-cognitiveservices-vision-customvision

@ksaye
We will now proceed to close this thread. If there are further questions regarding this matter, please respond here and @YutongTie-MSFT and we will gladly continue the discussion.

Thanks, you were right, I was using 2.0 and 3.0 does show the methods.  Thanks for the suggestion.


Issue with parameters naming

If a parameter is created with mapdl.get('AR1','node',' ','count' ) , the value of the AR1 parameter can be seen in mapdl.parameters, but if two digits are used for the name ('AR11'), the parameter is not shown in mapdl.parameters.
This seems to happen for any combination of double digits

It seems it is a MAPLD issue...
In MAPDL you can run both:
*GET,AR1,node, ,count,,,,
*GET,AR10,node, ,count,,,,

and the output is:

I believe it is a conflict with naming convention (p.e. ARGX for functions), I'm pinging @FredAns for further info.

Confirmed it's a MAPDL issue.
@germa89, let's patch this on the PyMAPDL side by raising a ValueError when a MAPDL variable contains more than one digit at the end of it.

Hi @pmaroneh @germa89 @akaszynski Not sure if this helps but the MAPDL help on parameter names states that: "Parameter names ARG1 through ARG9 and AR10 through AR99 are reserved for local parameters. Generally, local parameters are used in macros (see Local Variables). Use of these names as "regular" parameters is not recommended."
Mike

Thanks for the suggestion @mikerife . I was indeed using these for local parameters, I just find it surprising that some parameters can be checked and some not. But as @akaszynski mentioned this is an issue with MAPDL directly, not pyMAPDL.

@mikerife  I found some info regarding that in the Ansys Parametric Design Language Guide in the section 5.3.2. Local Variables Within Macros.
Is there any other place in the documentation I should look into?
I think we are just going to raise a warning if the user try to store a parameter which follows any of the patterns mentioned by @mikerife

Hi @germa89 Yep, that is the help section.  Well maybe section 3.1 on parameter names as well.  Leading _ are reserved for Ansys Inc macros and ARG/AR can be tricky to use.  So normally we (in training, support etc) suggest using an _ somewhere.  For example instead of XMAX use X_MAX.  Or instead of AR10 use AR10_ etc if you want a global parameter.   *STATUS and *DEL have trailing _ specific behavior which can be useful in MAPDL...not yet sure of PyMAPDL.

I see.... Based on your recommendations and my reading, now PyMAPDL raise an exception:

If the parameter name starts with _ and it does not ends on _ too.
If the parameter name starts with a number.
If the parameter name is longer than 32 characters
If the parameter name contains any other simbol than underscore (_), a letter or a number.


The lost example information

Hi, when I try to open the shared link to  Jupyter notebooks for conducting full landmark analyses of LiAlSiO4 and Li12La3Zr2O12 as in our paper, it shows the page could not be found, would you check that?
Thanks

The link seems to have broken — here's the new one:
https://archive.materialscloud.org/record/102


custom file component

Hello
I want to create a custom file component in which I can have more than one url address and I can use my own token and request header to access those addresses.
for example  authorization: Bearer ${window.localStorage.getItem('token')}
How can I do this?
i use<EMAIL_ADDRESS>Thanks

Agent Jeriah Henley linked Freshdesk ticket 51662 for this issue.

Hey @faezeh1378 check out our docs here: https://help.form.io/faq/tutorials-and-workflows/custom-component


API to set initial view point

Hey,
Is there an API that I can use to set initial viewpoint when starting 360?
Thanks,
Eliza

For now MetalScope does not have that function.

@junpluse thanks for your response, it will be great to expose if possible.
now you have the center function but if as external user i am interested to start from my last view point it will be great to reflect it.
Thanks!

@ElizaSapir hi, i'm just wondering if you did the feature by your self? i mean did you find any alternative way to do it?

hey @ganico,
nop I didn't just used this lib for small POC.
good luck :)

hi @ElizaSapir may I know what lib are you using??


Create table with metadata about stations

Stations need a good metadata table that includes GeoJSON data.

Done.


Lost translation for 'Column' in locale zh-cn

Lost translation for 'Column' in locale zh-cn, maybe other locale too.

Please translate and submit a pull request. I do not know "zh-cn"

sorry but I do not know how to submit a pull request.


Fix failure when decrypting an empty string

Fixes #43

Friendly bump on this; going through old PRs today.

Waiting on #68 to resolve Go / govulncheck (1.21.x) CI failure.

I'm having a little trouble understanding this change. It seems like there are two important parts:

Decrypt, when given an empty ciphertext, now has a short-circuit path to return empty (nil) plaintext.
Checking for plaintext == nil now happens in each iteration of the loop over recipients instead of at the end.

Naively, looking at this code, I would say the problem is that it treats plaintext == nil as an error, in both Decrypt and DecryptMulti. But of course plaintext == nil is semantically the same as var plaintext []byte, which just means an empty byte string (as you point out at the return sites). It seems like the fix should just be to remove the if plaintext == nil stanzas entirely, right?
And if that hypothesis is right, it seems like the existing decryption primitives handle empty strings fine, and we don't need the short-circuit return nil, nil path.

I like this approach, I'll take a look tomorrow and make sure that it doesn't introduce any other unexpected failures.

Neat @jsha, that approach seems to work. I added a small check just to make sure that ciphertext is actually empty before we treat the plaintext == nil as okay.