OWLS-75359, OWLS-75638, added test to cover endtoend monitoring exporter sample

jenkin passed, ready for review
http://wls-jenkins.us.oracle.com/job/weblogic-kubernetes-operator-javatest/1922/

@marinakog please update USECASES.MD

I see hard-coded password welcome1. Can you use the variable available in base test

replaced with values from BaseTest


Add the README.md

currently, the readme is not good to see so, rewrite the new readme
I am giving one reference here

@root-ansh can you please work on this

Reference readme is good, implementing that won't be difficult.
Let someone else give it a try for now. If someone else don't respond in next 3 days, I will work on it this sunday

I can take it!


Add knitr to markupGrammars

Once https://github.com/christophergandrud/language-knitr/pull/4 is merged we support knitr as well 🎉

OH EM GEE

Yeah the PR is shipped. This is ready to go now 🚀

And shipped on apm! Excellent.


Update document statuses

Move the document status meta-specification into the README.md. This is not applicable to the target GDI repositories and it is confusing having it in the specification when it is about the specification.
Add document statuses to all specification documents.

@signalfx/gdi-specification-approvers PTAL


Login not possible despite correct credentials in Properties file

Issue solved. Source and Target parameters are now separated in source-code.


HDDS-9252. NPE in TestNSSummaryTask

What changes were proposed in this pull request?
TestNSSummaryTask and related tests are implemented as nested classes.  If we run the nested test class directly (either explictly, or via some selector, e.g. package name), these nested classes run into exceptions, because JUnit does not execute the @BeforeClass setup code in the outer class.
This change converts these tests to JUnit5, which handles nested class setup properly.
https://issues.apache.org/jira/browse/HDDS-9252
How was this patch tested?
$ mvn -am -pl :ozone-recon -Dtest='TestNSSummaryTaskWithLegacy$TestProcess' clean test
...
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.ozone.recon.tasks.TestNSSummaryTaskWithLegacy
[INFO] Running org.apache.hadoop.ozone.recon.tasks.TestNSSummaryTaskWithLegacy$TestProcess
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.055 s - in org.apache.hadoop.ozone.recon.tasks.TestNSSummaryTaskWithLegacy$TestProcess
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.768 s - in org.apache.hadoop.ozone.recon.tasks.TestNSSummaryTaskWithLegacy
...

$ mvn -am -pl :ozone-recon -Dtest='TestNSSummaryTask$TestReprocess' clean test
[INFO] Running org.apache.hadoop.ozone.recon.tasks.TestNSSummaryTask
[INFO] Running org.apache.hadoop.ozone.recon.tasks.TestNSSummaryTask$TestReprocess
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.04 s - in org.apache.hadoop.ozone.recon.tasks.TestNSSummaryTask$TestReprocess
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.876 s - in org.apache.hadoop.ozone.recon.tasks.TestNSSummaryTask
...

CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/6163907068/job/16728478679

@ArafatKhan2198 alternative fix for HDDS-9252, keeping nested test structure

Thanks @hemantk-12 for the review.


[Request] Low Priority CPU

Hey I'm wondering if you can impliment an option like cpu cores, to add an option to autoset ffmpeg CPU Priority Low.
Comment not your program, but Topaz its insane they don't have this stuff, like repositioning queue and CPU priority and pause all implimented into the software its fairly simple things.

Hi, I think it already have the option to limit how many cores ffrmpeg will use, it's an experimental feature tho, but you can right click on the icon to use it


Fix '10' example in Basics

The current 10 example actually produces the "10" (i.e. a string), instead of the number 10 as the previous three example do. I've wrapped the expression in an extra pair of brackets, and added a leading + to convert it for a number

Eagleeye! Thanks for fixing this.


Windows Exclusions

Could you provide the line in code which adds exclusions?

Here's where it's added into the run string:
https://github.com/UnamSanctam/UnamDownloader/blob/55067bf6288b1dc6f930a5e35cbb3695090e887c/UnamDownloader/Builder.cs#L169
But I'm also working on updating it to the one from my SilentCryptoMiner as well.

The one from the crypto miner is definitly better. Thank you for your respone.


[cxx-interop] Fix crash when indexing with C++ interop enabled.

This is a stop-gap solution to prevent crashes.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Refs https://github.com/apple/swift/pull/40893.


Updated js runtime to use the latest SDK

Description

Updated js runtime to use the latest 4.11.0-rc1 version of SDK to adopt the latest changes.
Task Item

Screenshots

We can change the version of sdk to 4.11 once 4.11 released. For now, I have to use next version.

Coverage remained the same at 55.227% when pulling 0952b9abc9158f3296fc08033844d48da10db037 on zim/update-js-runtime into 819481b04ac6b34b92b03058fd7d4aef63a8d616 on main.

@chon219 could you please check the test cases failure especially for the BotProject-nodejs.

@chon219 Zichuan Ma FTE could you please check the test cases failure especially for the BotProject-nodejs.

OK, I'll try to fix that.

@chon219 , schemas are already in JS RC3, let's take that package and support JS custom action in this PR.

--imports="../dialogs/imported" what does this mean? I tried that and didn't see any folder created.

ping @chon219

--imports="../dialogs/imported" what does this mean? I tried that and didn't see any folder created.

Imported assets from referenced packages (exported folder) would be copied into dialogs/imported to be consumed by composer, which might be empty if there is no imported assets.

@benbrown All comments resolved, is it okay to merge this change?


ready to join

"ready to join" should change to "ready to start"

is deleted in new design.

is deleted in new design

Done

I still see this part on the stage @ehsan-g

hmm, very weird i changed it then, please check I changed it again. @aghpr

it still is there @ehsan-g
:))

@aghpr به مولا نیست  :))....press F5 plz

به جدم هست. f5 رو هم زدم هردفعه


Redundant subdimensions being created when finalizing subdomains

When attaching  M SubDomain's to an N-dimensional grid M*N SubDimension's are currently being created, but often some SubDimension's can, and should, be re-used.
Therefore, during the finalization of a SubDomain a check should be carried out to see if a previously created SubDimension can be used. An easy way to this would be to at, e.g., a grid._subdimensions property which is checked against and appended too during the finalization of each SubDomain.

@EdCaunt is this now fixed with all the new updates?

Yes. SubDimensions are now unique for concretisation, but their names in the generated code are abridged by the abridge_dim_names compiler pass.


fix(restclient): set defaultauths to one of the available if not set

Current dependencies on/for this PR:

main

PR #36   👈

PR #37

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

main

PR #36   👈

PR #37

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: 🔄 Waiting for checks to pass
This pull request is currently waiting for CI and mergeability checks to pass before being merged.
This comment was auto-generated by Graphite.

Job Reference: m70Y70s4R49EIQIAok4y


Potential tensor extraction issue

Hi,
In the recent commit three weeks ago, I noticed that extraction of tensor components dxx, dyy, dzz was changed from 0, 3, 5 (found at the beginning before the change) to 0, 2, 5 (found at the end after the change). After a test run I found that the final alps values were larger than expected. Since FSL's tensor order is [Dxx, Dxy, Dxz, Dyy, Dyz, Dzz], I was wondering if this was a typo?
Thanks!

Hi,
Thank you so much for noticing this. Yes, this was a typo. I apologize.
Thanks again,
Giuseppe


Elder Ray Index

Hello,
I try to use the latest version, and I don't see Elder Ray Index (eri), mentioned on main page. A list of indicators (ta.indicators()) doesn't contain eri too. Is it implemented?
Thnx

Hello @sv136,
I assume by no response that the solition provided was sufficient. Thus I will be closing this issue in a few days.
Please ⭐ if you find the library useful.
Thanks,
KJ


haddock-library-1.4.4.x without internal libraries?

Internal libraries do not quite yet seem ready for prime time: We can't build haddocks https://github.com/haskell/cabal/issues/4969 and we can't build with nix https://github.com/NixOS/nixpkgs/issues/32980. Can we have a new release of 1.4.4.x so we can use haddock-api-2.18.x without hacking around these issues until they're properly fixed?

fwiw, http://hackage.haskell.org/package/haddock-library

Do you know how they're built? Using new-haddock maybe? (haven't tested if that works)

Tbh, I don't remember, I'll retry regenerating them, then I should be able to tell you.


TUT-21 Merge the two current notebook github repos into one.

Hi Neel,
I did some tests and it seem ok.
Please verify and let me know if anything missing.
Thanks,
Phuc Vinh

Hi Phuc, I would go with the results of these tests:

Binder works in the merged branch. [Neel]
The built Docker container works. [Phuc/Lucien]
Spark notebook continues to work with the build instructions for Linux and MacOS. [Kiran/Rahul]

Can you please make sure the testing is completed in the branch, after which we can merge. Thanks.

Hi Neel,

The built Docker container works.

I did build & test (using Lucien instruction) and all passed, but it’s better to have Lucien verify.
Thanks,
Phuc Vinh

On Jun 24, 2021, at 11:36 AM, Neel Phadnis @.***> wrote:
Hi Phuc, I would go with the results of these tests:
Binder works in the merged branch. [Neel]
The built Docker container works. [Phuc/Lucien]
Spark notebook continues to work with the build instructions for Linux and MacOS. [Kiran/Rahul]
Can you please make sure the testing is completed in the branch, after which we can merge. Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/aerospike-examples/interactive-notebooks/pull/22#issuecomment-867865882, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATRQQQEATE2BLNJR3WKUBOLTUN3JJANCNFSM47IMSUCA.

My binder launch from the branch fails:
...
Reading package lists...
Building dependency tree...
Reading state information...
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Removing intermediate container 537d9bbc6ce4
---> dadc62cf2f01
Step 12/20 : COPY aerospike.template.conf /etc/aerospike/aerospike.template.conf
---> 11827bbcbaeb
Step 13/20 : COPY entrypoint.sh /entrypoint.sh
---> fd4ff3cf94aa
Step 14/20 : COPY spark /home/$NB_USER/spark
COPY failed: stat /ssd/docker/tmp/docker-builder045304997/spark: no such file or directory

Just talk to Rahul and he confirmed that it's ok to merge.


revisit cloning

after #5 need to revisit how we clone our data to see if we can save some memory
more numpy background needed most likely

wontfix for now since not actual issue


test(ProductiveCard): add avt test coverage

Closes #6472
adds accessibility tests for productive card
Since we are in v12 OverflowMenu. i noticed that passing aria-label prop to v12 OverflowMenu spreads it to the overflow menu container which is a div and is reported as violation
v12 OverflowMenu uses single Label prop to set tooltip text on menu button and aria-label for list container (ul)
which means we might need to deprecate either iconDescription or overflowAriaLabel as Label prop handles both with v12 OverflowMenu.
useful references
https://github.com/carbon-design-system/ibm-products/pull/5803
https://github.com/carbon-design-system/ibm-products/pull/6395
i have passed label as below, and awaiting for any review suggestions
label={iconDescription || overflowAriaLabel}

What did you change?
e2e/components/ProductiveCard/ProductiveCard-test.avt.e2e.js
packages/ibm-products/src/components/Card/Card.tsx
How did you test and verify your work?
yarn avt

@elycheea fixed it

Also agree it might be good to deprecate iconDescription or overflowAriaLabel if they are now redundant. If iconDescription overrides overflowAriaLabel, that may be preferable unless the latter is more widely used. 🤔

im pretty sure we can deprecate iconDescription as it has been introduced recently compared to overflowAriaLabel.
also changed the override order to prioritise overflowAriaLabel. and updated the pr accordingly.
although a more generic name label could be more convenient (just like we have in core. a common prop to pass to button tooltip and aria-label for v12 OverflowMenu) when compared to having overflowAriaLabel that also sets tooltip text.
any additional thoughts or suggestions?

@anamikaanu96 done


AT command port for ESP-Launcher

Tell me how to set the correct AT-command port for ESP-Launcher ?

@edbek please refer to https://docs.espressif.com/projects/esp-at/en/latest/Compile_and_Develop/How_to_set_AT_port_pin.html#esp8266-at

@edbek please refer to https://docs.espressif.com/projects/esp-at/en/latest/Compile_and_Develop/How_to_set_AT_port_pin.html#esp8266-at


IPFS crashes on wake from hibernate

OS: Windows 11
Version of IPFS Desktop: 0.24.0

Describe the bug
When I wake my computer from hibernation, IPFS crashes.
To Reproduce
Steps to reproduce the behavior:

Verify IPFS Desktop shows as connected in system tray.
Hibernate computer.
Wake computer from Hibernation.
Notice that IPFS Desktop is off in system tray (grey icon).
Notice that the context menu indicates it crashed.

Expected behavior
IPFS doesn't crash and fail to recover when waking from hibernate.
Additional context
Woke from hibernation at around 2022-10-28T04:59:00Z.  I have a VPN running that may or may not cause some weird blips when the computer wakes from Hibernate as it needs to recover the connection.
2022-10-28T04:59:02.191Z info: [ipfsd] stop daemon STARTED
2022-10-28T04:59:02.370Z info: [ipfsd] stop daemon FINISHED 0.17919450002908707s
2022-10-28T04:59:02.425Z info: [ipfsd] start daemon STARTED
2022-10-28T04:59:04.177Z error: [ipfsd] start daemon FetchError: request to http://<IP_ADDRESS>:5001/api/v0/id failed, reason: net::ERR_NETWORK_CHANGED
    at ClientRequest.<anonymous> (C:\Users\****\AppData\Local\Programs\IPFS Desktop\resources\app.asar\node_modules\electron-fetch\lib\index.js:1391:14)
    at ClientRequest.emit (node:events:526:28)
    at ClientRequest._die (node:electron/js2c/browser_init:101:8492)
    at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/browser_init:101:7229)
    at SimpleURLLoaderWrapper.emit (node:events:526:28)

Note: This issue is relatively new as it started happening after I updated to 0.24.0.  I sometimes skip updates, and I'm not sure what version I was running previously, so I can't say exactly what version this issue was introduced in.

Thanks for submitting the issue @MicahZoltu, since you've been seeing this issue recently sounds like it's a bug, we'll need to investigate this further to reproduce this issue before we can figure out a solution for this.

@MicahZoltu does the IPFS daemon start fine once in this error state or does the app need to be shut down and re-opened?

When it is in this state (after hibernate), I can right-click on the system tray icon for IPFS Desktop and choose Restart from the top of the list and that fixes everything.  I don't know what that does under the hood.
(screenshot is from after restart)


Add images:verify to refresh-images pipeline

Also clean up trailing whitespace
Also also fix some indentation around the worked area
Email failure, don't abort

First swing at this. I followed the pattern I saw elsewhere.

Depends on https://github.com/openshift/enterprise-images/pull/157/


Add detection for documentation in templated test cases

Fixes #526
@bhirsz Can you help me with tests for this depending on the value of the parameter?
Currently, the ignore_templated param for missing-doc-test-case is set to True, but the tests only work when it is set to False. We need to add tests checking both of the values for the param. I need guidance.

Codecov Report

Merging #602 (78da1f6) into master (64a0ee2) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
- Coverage   97.35%   97.32%   -0.04%
==========================================
  Files          23       23
  Lines        2651     2656       +5
==========================================
+ Hits         2581     2585       +4
- Misses         70       71       +1

Impacted Files
Coverage Δ

robocop/checkers/misc.py
99.13% <ø> (ø)

robocop/checkers/documentation.py
96.77% <75.00%> (-3.23%)
:arrow_down:

robocop/utils/misc.py
98.64% <100.00%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a0ee2...78da1f6. Read the comment docs.


WASM Support: Install burn without installing libsqlite3

Describe the bug
Attempting to bundle burn into a WASM rust library results in a compile-time failure because libsqlite3 is included

To Reproduce
Installing burn with this snippet (attempting to disable the sqlite flag) causes the failure.
[dependencies.burn]
version = "0.12.1"
default-features = false
features = ["std", "train", "ndarray"]

[dev-dependencies.burn]
version = "0.12.1"
default-features = false
features = ["std", "train", "ndarray"]

Expected behavior
Disabling the sqlite feature should not attempt to install libsqlite3.
Looking at the dependency tree, this is coming from:
burn-core => burn-dataset => r2d2_sqlite => rusqlite => libsqlite3-sys
Desktop (please complete the following information):

OS: MacOS
Browser: N/A - All WASM
Version: 0.12.1

Additional context
I see an example repo that seems to be avoiding this issue, but I'm not sure how. Thanks in advance!

In the above PR I change burn-train's Cargo.toml default featureset to
default = ["metrics", "tui", "burn-core/default", "burn-core/dataset"]

while simultaneously doing
burn-core = { path = "../burn-core", version = "0.12.0", default-features = false }

This removes the burn-dataset dependency from burn-core. Perhaps this is enough to build to wasm.

Train in wasm is not supported. You should build with default features disabled, which would force you the library be no-std compatible.


7-17更新版本出现问题（There are issues with the updated version 7-17）

Cannot import F:\comfyui\custom_nodes\ComfyUI-IF_AI_tools module for custom nodes: No module named 'ComfyUI-IF_AI_tools.IFTextTyperNode'Updated version from July-17.However, the version with the omost node updated from July 7-16
has no issues.

一样的问题，更新后就报这错了。
Same issue, gets this error after the update.
ModuleNotFoundError: No module named 'ComfyUI-IF_AI_tools.IFTextTyperNode'

same

same issue


add Turing School of Software and Design

Add https://turing.edu/

@abdulredd Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


Why Not Just Host this on github pages?

We can use github actions and build it and host it on github pages

I like where you're going.  Most people using this are self-hosters but this sounds awesome too.  Let me think about this and if this is possible with the repo in it's current state.

https://github.com/techno-tim/littlelink-server/pull/19

Reference and context in https://github.com/techno-tim/littlelink-server/pull/19


Bug Fix: Overflow Text View; Improvement: Make Title Single Line and Ellipsize;

Description

Bug fix: overflow text view "ADD TO LIST".
Improvement : make title into single line and make it ellipsize whenever text reach the view itself.

Issue Resolved
Issue https://github.com/PEC-CSS/MovieDroid/issues/88 : RESOLVED ✅
Screenshots
Tested on AVD Nexus 5 (360 x 640 dp, XXHDPI) ✅

Another Preview on Generic AVD

Screen
Size

2.7" (320 x 427 dp, LDPI)

3.2" (320 x 480 dp, MDPI)

3.3" (320 x 533 dp, LDPI)

3.4" (320 x 576  dp, LDPI)

3.7" - NEXUS ONE (320 x 533 dp, HDPI)

4.7" (640 x 360 dp, XHDPI)

Checklist
Please make sure to review the following before submitting your PR:

[x] I have read the contribution guidelines.
[x] I have read the code of conduct.
[x] I have reviewed my submission in detail.

Lgtm


Feature/shortcut indication

(builds upon Pull request 16)

Hey, can you merge with master so I can just see the new diff?
Also, can you please add a link inline to dismiss the hints? It might be annoying for users to always have to see the hints.

Oh, I'll do the merging soon.
Regarding the link to the shortcut hints I think the images are not clear, time for a gif:

shortcut is always visible, and it changes to the hint when it is clicked.
I couldn't find a way to link directly to the chrome's extension keyboard shortcuts. It could be possible to set a shortcut directly from the extension itself through chrome.commands, but that would require a UI.

now it is done

Sorry for the delay. I'll take a look next week.

shortcut is always visible, and it changes to the hint when it is clicked.

Do you think an option to disable the shortcut it would be useful?

@dbuezas Closing this due to inactivity.

Oh, sorry for that, I didn't even remember this PR.
In the meanwhile I made my own palette from scratch with modern tools https://github.com/dbuezas/chrome-palette/tree/master


default lmdb storage size is too large, causing boot error

https://github.com/hyperledger-labs/trusted-compute-framework/blob/fead0d3f715a53cef1079cb271015b27d655bae9/tcs/core/common/packages/db_store/lmdb_store.cpp#L35-L40
The default lmdb storage size is too large, which may cause boot error. Can we set it as a booting config parameter ❓

I guess we are using DEFAULT_DB_STORE_SIZE parameter to set the map size using mdb_env_set_mapsize(). It will set the map size to this 1TB, but allocate that much memory affront. As per the mdb API mdb_env_set_mapsize(), size should be a multiple of the OS page size. The default is 10485760 bytes. The size of the memory map is also the maximum size of the database. The value should be chosen as large as possible, to accommodate future growth of the database.
This size can be read from boot config parameter.

LMDB files are "sparse" files and do not use disk space until needed. So a 1TB sparse file does not use 1TB of disk storage.
To copy or backup these files, Linux commands have sparce file options, such as cp --sparse or tar -S

closed by #45


Overload leads to BlockingOperationException [JIRA: CLIENTS-925]

Riak Java Client: 2.0.6
Java version: 1.8.0_74
Riak version: 2.1.2
Operating system: Linux, Debian 7
When updating objects in Riak under load, the riak-java-client occasionally throws a io.netty.util.concurrent.BlockingOperationException. Since https://github.com/basho/riak-java-client/issues/523 is fixed, this happens only in - what I assume is - an overload-scenario.
The exception:
2016-07-13 14:41:12.789  localhost [nioEventLoopGroup-2-2] ERROR
com.basho.riak.client.core.RiakNode - Operation onException() channel:
id:237445453 localhost:8087 {}
io.netty.util.concurrent.BlockingOperationException:
DefaultChannelPromise at 77ccd827(incomplete)
        at io.netty.util.concurrent.DefaultPromise.checkDeadLock(DefaultPromise.java:390)
        at io.netty.channel.DefaultChannelPromise.checkDeadLock(DefaultChannelPromise.java:157)
        at io.netty.util.concurrent.DefaultPromise.await(DefaultPromise.java:251)
        at io.netty.channel.DefaultChannelPromise.await(DefaultChannelPromise.java:129)
        at io.netty.channel.DefaultChannelPromise.await(DefaultChannelPromise.java:28)
        at com.basho.riak.client.core.RiakNode.doGetConnection(RiakNode.java:697)
        at com.basho.riak.client.core.RiakNode.getConnection(RiakNode.java:656)
        at com.basho.riak.client.core.RiakNode.execute(RiakNode.java:587)
        at com.basho.riak.client.core.DefaultNodeManager.executeOnNode(DefaultNodeManager.java:91)
        at com.basho.riak.client.core.RiakCluster.execute(RiakCluster.java:322)
        at com.basho.riak.client.core.RiakCluster.execute(RiakCluster.java:240)
        at com.basho.riak.client.api.commands.kv.StoreValue.executeAsync(StoreValue.java:117)
        at com.basho.riak.client.api.commands.kv.UpdateValue$1.handle(UpdateValue.java:182)
        at com.basho.riak.client.api.commands.ListenableFuture.notifyListeners(ListenableFuture.java:78)
        at com.basho.riak.client.api.commands.CoreFutureAdapter.handle(CoreFutureAdapter.java:120)
        at com.basho.riak.client.core.FutureOperation.fireListeners(FutureOperation.java:176)
        at com.basho.riak.client.core.FutureOperation.setComplete(FutureOperation.java:224)
        at com.basho.riak.client.core.RiakNode.onSuccess(RiakNode.java:878)
        at com.basho.riak.client.core.netty.RiakResponseHandler.channelRead(RiakResponseHandler.java:30)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:318)
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:304)
        at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:276)
        at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:263)
        at io.netty.handler.codec.ByteToMessageCodec.channelRead(ByteToMessageCodec.java:103)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:318)
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:304)
        at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:846)
        at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131)
        at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:511)
        at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:468)
        at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:382)
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:354)
        at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:112)
        at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137)
        at java.lang.Thread.run(Thread.java:745)

Then shortly thereafter:
2016-07-13 14:41:12.820  localhost [nioEventLoopGroup-2-2] ERROR com.basho.riak.client.core.RiakNode - Write failed on RiakNode localhost:8087 id: 237445453; cause: {}
java.nio.channels.ClosedChannelException: null
2016-07-13 14:41:12.843  localhost [nioEventLoopGroup-2-2] ERROR com.basho.riak.client.core.RiakNode - Write failed on RiakNode localhost:8087 id: 237445453; cause: {}
java.nio.channels.ClosedChannelException: null

The result is a hanging thread, never returning from the call to RiakClient.execute(). It would be better, if in such a case, the client threw a RiakException (as javadoc says).
Riak's error.log shows nothing about this.
In the meantime, how do I protect against overloading Riak? Setting RiakNode.Builder().withMaxConnections() to something like 60 or below (on my single-node dev system here) seems to work: Attempts to open more connections lead to a com.basho.riak.client.core.NoNodesAvailableException. What is considered overload?

As I'm loadtesting my application, trying to find a sweetspot, I notice that limitting maxConnections alone doesn't work. Sometimes I get BlockingOperationExceptions, and there are only about 40 connections established. Sometimes way more than 100 connections are established, and the loadtest goes through fine.
My current conclusion is: I'd have to set maxConnections (what feels like) really really low to be guaranteed safe, but I'd probably be sacrificing performance, right?

@hankipanky How many nodes do you have the client configured to talk to in your tests?

In our architecture, we place one instance of our (Riak-CS-like) application colocated with / in front of each Riak node, and loadbalance over them with HAproxy.
For testing purposes, I use a single-node cluster on a (relatively meager) VM on my development machine.
We have since done a number of things to reduce likelihood of an overload (reduce size of chunks that are stored in riak; pre-start around 30 connections to Riak; reduce HTTP threadpool size of the application, to queue requests better; etc).
The (probably naive) point of this ticket is though: through bad configuration or silly loadtesting, I'll probably still find a way to get Riak into overload. I'd prefer if that results in a RiakException (just like in #523), which I can react to.

Ok, so it seems like we're not catching a few exceptions where we should be.  Since the UpdateValue's Store operation runs on the Netty worker thread, we can get into trouble if it decides it's "deadlocked", when actually we're waiting on either a channel permit, or a channel.
The two areas/ blocking operations that I can see us getting hung up on are:

aquire permit when blockOnMaxConnections is true
get connection await

I believe if I catch BlockingOperationException in those two blocks and send it down the normal error path, it should fix this.  If it fails it would then go through the retrier code path, and eventually spit out a RiakException.

@hankipanky I released a fix for the "BlockingOperationException" issue with 2.0.7, let me know if you still see the issue with overload.  If so I'll have to write more complicated tests.

Thanks so much. I was following the progress and looked at the changeset - looks great. I'll report back after testing. you guys rock!


Still No sha in tag event

I 'm working on integrat with Drone and gogs .
In file Drone/Remote/gogs.go I saw a comment . need sha for tag event .
and I found a branch called drone-ci , not look into it .
quick check with you , any merging plan ?

Sorry for wrong issue format . tag event means web hook - tag created . Could I know which version of gogs have sha in tag created web hook ?

https://github.com/drone/drone/blob/master/remote/gogs/gogs.go#L181

Thanks for the link, but from what I read, I didn't see anything related to "tag event" you talked about.

I don't know what you're talking. Do your tests on demo site and reproduce it, otherwise I can't help much...

gogs.zip
a short screen movie help u

I used gogs which version is <IP_ADDRESS>1 .

Thanks for the zip, but I absolutely have no idea what you're trying to achieve without using latest version for a feature request.

will try on new feature , thank you . :)
feedback you later

I have to say . in lastest version gogs , web hook tag create still does't work with drone


Enable golangci-lint

Enable https://golangci-lint.run and fix the issues it found.
If you don't like any of these linters, I'm happy to disable them and revert the changes related to them, but in general I think all I enabled now are useful.

Hi, thanks for your PR :) I will look into it the next days.


Redirect web part fails if there are specific permissions on list items

Category

[x] Bug

Describe the bug
The Redirect extension works correctly when both the "PnP Redirect Links" list and list items therein do not have their permissions modified.
When list items have specific permissions (i.e. breaking inheritance and applying specific permissions to list items) then the Redirect extension fails.
Expected or Desired Behavior
Expected that the Redirect continues to work even with specific list item security.
Observed Behavior
Redirect fails with console message "Failed to create custom list PnP Redirect Links" when item level security is applied.
Steps to Reproduce
Install the Redirect extension and let it create the custom list.
Create two list items, each with same source URL and different destination URL's
Go to the source URL - Redirects correctly on the first "found" item.
Now, stop inheriting permissions on each item and only allow members of specific groups to see the list items.
When user logs in they can navigate to the custom list and they will only see ONE of the two items.
Redirect now fails with console message "Failed to create custom list PnP Redirect Links"
NOTE:  I have determined that the bug appears to be in the this line:
       const ensureResult: ListEnsureResult = await sp.web.lists.ensure(redirectionsListTitle,
       'Redirections',
        100,
        true);

The "ensure" method fails, even though the list exists for the user.
My workaround is to
a) allow the default extension to create the list in the first place
b) replace line 67
   if (await this.ensureRedirectionsList(redirectionsListTitle))

with
   if (true)

then build a new version of the extension
then deploy the extension
Environment Details (Development & Target environment)
SharePoint online

Since you have broken inheritence, can you confirm whether the users have access on the list level for READ, and not just the list item?

Hi and thanks for picking this up.
To confirm, users do have "Read" access to the list (Inheritance is not broken at list level - only at item level).
If I login as a user then they can see the list and open the list.
A user will see their single list item.
A site admin will see all the items in the list.

Thank you. I have looked into this a bit further, apologies for the delay. It appears the ensure() method requires elevated permissions, as users with READ permissions cannot use the Ensure() method.
We will need to update the code and remove and/or update the ensure method logic to better establish the existence of the list.

@eoverfield - I am going to put in a fix for this. As above, a user with "read" permission is unable to call the ensure() function. Question for you:
Would you prefer we...

Simplify the code and make an assumption that the list exists and is accurate (remove ensure())
Put in more logic to determine whether the current user can call the ensure() method, this could still result in a 404 for end users with Read.

My preference would be option a - to remove the ensure all together, given that if the list isn't set up correctly in the first place, a read user would still be unable to redirect.


[BUG] Longhorn installation fails sometimes with longhorn-manager pods stuck to come up healthy.

Describe the bug
The longhorn v1.0.1 installation sometimes fails on a cluster of 4 nodes(3 worker, 1etc/control plane)
To Reproduce
Steps to reproduce the behavior:

Create a cluster of 3 workers and 1 etc/control plane.
Install longhorn v1.0.1 from the catalog app.
Try to install and uninstall multiple times
Sometimes longhorn installation fails with longhorn-manager pods stuck in crashloop.
Engine image is marked as incompatible

Expected behavior
Installation should be always successful
Log
time="2020-08-04T17:41:17Z" level=info msg="Start overwriting built-in settings with customized values"
time="2020-08-04T17:41:17Z" level=info msg="cannot list the content of the src directory /var/lib/rancher/longhorn/engine-binaries for the copy, will do nothing: Failed to execute: nsenter [--mount=/host/proc/7970/ns/mnt --net=/host/proc/7970/ns/net bash -c ls /var/lib/rancher/longhorn/engine-binaries/*], output , stderr, ls: cannot access '/var/lib/rancher/longhorn/engine-binaries/*': No such file or directory\n, error exit status 2"
time="2020-08-04T17:41:17Z" level=info msg="New upgrade leader elected: khushboo-test-wk3"
time="2020-08-04T17:41:37Z" level=info msg="Start upgrading"
time="2020-08-04T17:41:37Z" level=info msg="No API version upgrade is needed"
time="2020-08-04T17:41:37Z" level=info msg="Finish upgrading"
E0804 17:41:37.844128       1 leaderelection.go:282] Failed to release lock: Lease.coordination.k8s.io "longhorn-manager-upgrade-lock" is invalid: spec.leaseDurationSeconds: Invalid value: 0: must be greater than 0
time="2020-08-04T17:41:37Z" level=info msg="Upgrade leader lost: khushboo-test-wk2"
E0804 17:41:37.854043       1 kubernetes_node_controller.go:256] Couldn't get nodes khushboo-test-wk2: node "khushboo-test-wk2" not found
time="2020-08-04T17:41:37Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.1 to be ready"
time="2020-08-04T17:41:37Z" level=info msg="Start Longhorn node controller"
time="2020-08-04T17:41:37Z" level=info msg="Start Longhorn volume controller"
time="2020-08-04T17:41:37Z" level=info msg="Start Longhorn Engine Image controller"
time="2020-08-04T17:41:37Z" level=info msg="Start Longhorn websocket controller"
time="2020-08-04T17:41:37Z" level=info msg="Start Longhorn engine controller"
time="2020-08-04T17:41:37Z" level=info msg="Start Longhorn Setting controller"
time="2020-08-04T17:41:37Z" level=info msg="Starting Longhorn instance manager controller"
time="2020-08-04T17:41:37Z" level=info msg="Start kubernetes controller"
time="2020-08-04T17:41:37Z" level=info msg="Start Longhorn Kubernetes node controller"
time="2020-08-04T17:41:37Z" level=info msg="Start Longhorn replica controller"
time="2020-08-04T17:41:38Z" level=debug msg="Start monitoring instance manager instance-manager-r-037f05af"
time="2020-08-04T17:41:38Z" level=debug msg="Start monitoring instance manager instance-manager-e-eb769411"
time="2020-08-04T17:41:43Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.1 to be ready"
time="2020-08-04T17:41:49Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.1 to be ready"
time="2020-08-04T17:41:55Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.1 to be ready"
time="2020-08-04T17:42:01Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.1 to be ready"
time="2020-08-04T17:42:07Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.1 to be ready"

Environment:

Longhorn version: v1.0.1
Kubernetes version: 18.6
Node OS type and version: Ubuntu 18.04

Script to install and uninstall longhorn continuously
install.sh.zip
Requires longhorn.yaml in the same location to run the script.
longhorn.yaml.zip

Log from first starting
time="2020-08-05T16:49:18Z" level=info msg="Start overwriting built-in settings with customized values"
time="2020-08-05T16:49:18Z" level=info msg="cannot list the content of the src directory /var/lib/rancher/longhorn/engine-binaries for the copy, will do nothing: Failed to execute: nsenter [--mount=/host/proc/3732/ns/mnt --net=/host/proc/3732/ns/net bash -c ls /var/lib/rancher/longhorn/engine-binaries/*], output , stderr, ls: cannot access '/var/lib/rancher/longhorn/engine-binaries/*': No such file or directory\n, error exit status 2"
time="2020-08-05T16:49:18Z" level=info msg="Start upgrading"
time="2020-08-05T16:49:18Z" level=warning msg="Cannot verify current CRD version, assume it's not v1alpha1: unable to verify if version matches v1alpha1: settings.longhorn.rancher.io \"default-engine-image\" is forbidden: User \"system:serviceaccount:longhorn-system:longhorn-service-account\" cannot get resource \"settings\" in API group \"longhorn.rancher.io\" in the namespace \"longhorn-system\""
time="2020-08-05T16:49:18Z" level=info msg="Initialized CRD API Version to longhorn.io/v1beta1"
time="2020-08-05T16:49:18Z" level=info msg="Finish upgrading"
E0805 16:49:18.647398 1 leaderelection.go:282] Failed to release lock: Lease.coordination.k8s.io "longhorn-manager-upgrade-lock" is invalid: spec.leaseDurationSeconds: Invalid value: 0: must be greater than 0
time="2020-08-05T16:49:18Z" level=info msg="Upgrade leader lost: yasker-longhorn-demo-1"
time="2020-08-05T16:49:18Z" level=info msg="Start Longhorn replica controller"
time="2020-08-05T16:49:18Z" level=info msg="Start Longhorn node controller"
time="2020-08-05T16:49:18Z" level=info msg="Start Longhorn engine controller"
time="2020-08-05T16:49:18Z" level=info msg="Start Longhorn volume controller"
time="2020-08-05T16:49:18Z" level=info msg="Start Longhorn Engine Image controller"
time="2020-08-05T16:49:18Z" level=info msg="Start Longhorn Setting controller"
time="2020-08-05T16:49:18Z" level=info msg="Start Longhorn Kubernetes node controller"
time="2020-08-05T16:49:18Z" level=info msg="Start Longhorn websocket controller"
time="2020-08-05T16:49:18Z" level=info msg="Start kubernetes controller"
time="2020-08-05T16:49:18Z" level=info msg="Starting Longhorn instance manager controller"
time="2020-08-05T16:49:20Z" level=info msg="Latest Longhorn version is v1.0.1"
time="2020-08-05T16:49:20Z" level=debug msg="Cannot update latest Longhorn version: settings.longhorn.io \"latest-longhorn-version\" is invalid: metadata.resourceVersion: Invalid value: 0x0: must be specified for an update"
time="2020-08-05T16:49:23Z" level=debug msg="Updated setting default-engine-image to longhornio/longhorn-engine:v1.0.1"
time="2020-08-05T16:49:23Z" level=debug msg="Updated setting default-instance-manager-image to longhornio/longhorn-instance-manager:v1_20200514"
time="2020-08-05T16:49:23Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"yasker-longhorn-demo-1\", UID:\"2292c011-8f5e-44c4-9af5-d35123f13353\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"23239990\", FieldPath:\"\"}): type: 'Warning' reason: 'Ready' Node yasker-longhorn-demo-1 is down: the manager pod longhorn-manager-qr8n9 is not running"
time="2020-08-05T16:49:23Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"yasker-longhorn-demo-1\", UID:\"2292c011-8f5e-44c4-9af5-d35123f13353\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"23239990\", FieldPath:\"\"}): type: 'Normal' reason: 'Schedulable' "
time="2020-08-05T16:49:23Z" level=debug msg="Prepare to create default instance manager instance-manager-e-af4df4b2, node: yasker-longhorn-demo-1, default instance manager image: longhornio/longhorn-instance-manager:v1_20200514, type: engine"
time="2020-08-05T16:49:23Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"yasker-longhorn-demo-1\", UID:\"2292c011-8f5e-44c4-9af5-d35123f13353\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"23239990\", FieldPath:\"\"}): type: 'Normal' reason: 'Ready' Disk default-disk-4b0d97e476dc21d3(/var/lib/longhorn/) on node yasker-longhorn-demo-1 is ready"
time="2020-08-05T16:49:23Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"yasker-longhorn-demo-1\", UID:\"2292c011-8f5e-44c4-9af5-d35123f13353\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"23239990\", FieldPath:\"\"}): type: 'Normal' reason: 'Schedulable' Disk default-disk-4b0d97e476dc21d3(/var/lib/longhorn/) on node yasker-longhorn-demo-1 is schedulable"
time="2020-08-05T16:49:23Z" level=debug msg="Created engine image ei-3bd16bdf (longhornio/longhorn-engine:v1.0.1)"
time="2020-08-05T16:49:23Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.1 to be ready"
time="2020-08-05T16:49:23Z" level=debug msg="Prepare to create default instance manager instance-manager-r-14d475de, node: yasker-longhorn-demo-1, default instance manager image: longhornio/longhorn-instance-manager:v1_20200514, type: replica"
time="2020-08-05T16:49:24Z" level=debug msg="Engine Image Controller yasker-longhorn-demo-1 picked up ei-3bd16bdf (longhornio/longhorn-engine:v1.0.1)"
time="2020-08-05T16:49:24Z" level=info msg="Created daemon set engine-image-ei-3bd16bdf for engine image ei-3bd16bdf (longhornio/longhorn-engine:v1.0.1)"
time="2020-08-05T16:49:24Z" level=debug msg="Instance Manager Controller yasker-longhorn-demo-1 picked up instance-manager-e-af4df4b2"
time="2020-08-05T16:49:24Z" level=warning msg="Starts to clean up then recreates pod for instance manager instance-manager-e-af4df4b2 with state stopped"
time="2020-08-05T16:49:24Z" level=info msg="Created instance manager pod instance-manager-e-af4df4b2 for instance manager instance-manager-e-af4df4b2"
time="2020-08-05T16:49:25Z" level=debug msg="Instance Manager Controller yasker-longhorn-demo-1 picked up instance-manager-r-14d475de"
time="2020-08-05T16:49:25Z" level=warning msg="Starts to clean up then recreates pod for instance manager instance-manager-r-14d475de with state stopped"
time="2020-08-05T16:49:25Z" level=warning msg="cannot get engine version for ei-3bd16bdf (longhornio/longhorn-engine:v1.0.1): cannot get volume version: Failed to execute: /var/lib/longhorn/engine-binaries/longhornio-longhorn-engine-v1.0.1/longhorn [version --client-only], output , stderr, , error fork/exec /var/lib/longhorn/engine-binaries/longhornio-longhorn-engine-v1.0.1/longhorn: text file busy"
time="2020-08-05T16:49:25Z" level=info msg="Created instance manager pod instance-manager-r-14d475de for instance manager instance-manager-r-14d475de"
time="2020-08-05T16:49:27Z" level=debug msg="Start monitoring instance manager instance-manager-e-af4df4b2"
time="2020-08-05T16:49:27Z" level=debug msg="Start monitoring instance manager instance-manager-r-14d475de"
time="2020-08-05T16:49:29Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:v1.0.1 to b

It seems due to

time="2020-08-05T16:49:25Z" level=warning msg="cannot get engine version for ei-3bd16bdf (longhornio/longhorn-engine:v1.0.1): cannot get volume version: Failed to execute: /var/lib/longhorn/engine-binaries/longhornio-longhorn-engine-v1.0.1/longhorn [version --client-only], output , stderr, , error fork/exec /var/lib/longhorn/engine-binaries/longhornio-longhorn-engine-v1.0.1/longhorn: text file busy"

@ttpcodes Tried multiple installations with the image quay.io/ttpcodes/longhorn-manager:engine-image-wait, Installation still fails sometimes.
time="2020-08-10T20:44:03Z" level=info msg="Start overwriting built-in settings with customized values"
time="2020-08-10T20:44:03Z" level=info msg="cannot list the content of the src directory /var/lib/rancher/longhorn/engine-binaries for the copy, will do nothing: Failed to execute: nsenter [--mount=/host/proc/9529/ns/mnt --net=/host/proc/9529/ns/net bash -c ls /var/lib/rancher/longhorn/engine-binaries/*], output , stderr, ls: cannot access '/var/lib/rancher/longhorn/engine-binaries/*': No such file or directory\n, error exit status 2"
time="2020-08-10T20:44:03Z" level=info msg="Start upgrading"
time="2020-08-10T20:44:03Z" level=info msg="No API version upgrade is needed"
time="2020-08-10T20:44:03Z" level=info msg="Finish upgrading"
time="2020-08-10T20:44:03Z" level=info msg="Upgrade leader lost: khush-test-lh-wk1"
E0810 20:44:03.236733       1 kubernetes_node_controller.go:256] Couldn't get nodes khush-test-lh-wk1: node "khush-test-lh-wk1" not found
E0810 20:44:03.237854       1 kubernetes_node_controller.go:244] Couldn't get nodes khush-test-lh-wk1: node "khush-test-lh-wk1" not found
time="2020-08-10T20:44:03Z" level=info msg="Start Longhorn Engine Image controller"
time="2020-08-10T20:44:03Z" level=info msg="Start Longhorn replica controller"
time="2020-08-10T20:44:03Z" level=info msg="Start Longhorn engine controller"
time="2020-08-10T20:44:03Z" level=info msg="Start Longhorn volume controller"
time="2020-08-10T20:44:03Z" level=info msg="Start Longhorn Setting controller"
time="2020-08-10T20:44:03Z" level=info msg="Start Longhorn node controller"
time="2020-08-10T20:44:03Z" level=info msg="Start Longhorn websocket controller"
time="2020-08-10T20:44:03Z" level=info msg="Starting Longhorn instance manager controller"
time="2020-08-10T20:44:03Z" level=info msg="Start kubernetes controller"
time="2020-08-10T20:44:03Z" level=info msg="Start Longhorn Kubernetes node controller"
time="2020-08-10T20:44:03Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:44:03Z" level=debug msg="Start monitoring instance manager instance-manager-r-7359ee3b"
time="2020-08-10T20:44:03Z" level=debug msg="Start monitoring instance manager instance-manager-e-070d93e5"
time="2020-08-10T20:44:09Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:44:15Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:44:21Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:44:27Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:44:33Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:44:39Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:44:45Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:44:51Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:44:57Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:45:03Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:45:09Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:45:15Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:45:21Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:45:27Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:45:33Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:45:39Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:45:45Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:45:51Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:45:57Z" level=debug msg="Waiting for engine image longhornio/longhorn-engine:master to be ready"
time="2020-08-10T20:46:03Z" level=fatal msg="Error starting manager: failed to wait for engine image longhornio/longhorn-engine:master: Wait for engine image longhornio/longhorn-engine:master timed out"

After this modification, the engine image can not become ready anymore once it is (wrongly) marked as incompatible. That's why we will encounter this issue only in v1.0.1.

In order to verify if the error is caused by the incompleteness of the binary, I tried to modify this line to "if [ $? -ne 0 ]; then dd if=/usr/local/bin/longhorn of=/data/longhorn bs=1 count=1 && chmod +x /data/longhorn && echo installed; fi && " then generate the image shuowu/longhorn-manager:incomplete-binary, the error log is

E0811 10:54:54.298468       1 engine_image_controller.go:197] fail to sync engine image for longhorn-system/ei-e6aacd98: cannot get engine version for ei-e6aacd98 (shuowu/longhorn-engine:ffa1472): cannot get volume version: Failed to execute: /var/lib/longhorn/engine-binaries/shuowu-longhorn-engine-ffa1472/longhorn [version --client-only], output , stderr, , error fork/exec /var/lib/longhorn/engine-binaries/shuowu-longhorn-engine-ffa1472/longhorn: exec format error
time="2020-08-11T10:54:54Z" level=warning msg="Dropping Longhorn engine image longhorn-system/ei-e6aacd98 out of the queue: fail to sync engine image for longhorn-system/ei-e6aacd98: cannot get engine version for ei-e6aacd98 (shuowu/longhorn-engine:ffa1472): cannot get volume version: Failed to execute: /var/lib/longhorn/engine-binaries/shuowu-longhorn-engine-ffa1472/longhorn [version --client-only], output , stderr, , error fork/exec /var/lib/longhorn/engine-binaries/shuowu-longhorn-engine-ffa1472/longhorn: exec format error"

I still don't know how we can exactly reproduce the error text file busy. There is no better way to reproduce the error for now.

Verified on Master - 08-11-2020
Validation - Passed
Ran installations above 200 iterations, all installations passed successfully.

Is there any hotfix or workaround for Longhorn version 1.0.2

@uluzox This should have been fixed in v1.0.2. You still have the same issue? Can you provide us the support bundle?

Actually, no. Firstly, Longhorn fails to create the Support Bundle in my case. Secondly, after a night's sleep and another installation attempt, my error looks different. I opened a new issue instead https://github.com/longhorn/longhorn/issues/1945

@uluzox Can you try the following workaround?

Run kubectl -n longhorn-system get engineimages.longhorn.io to get the CR name for the engine image
Directly delete the CR kubectl -n longhorn-system delete engineimages.longhorn.io
Manually Re-deploy the image in Longhorn UI page

Notice that the volumes operations will be temporarily invalid during the workaround

1.0.2 same issue
kubernetes version 1.19.3
I tested the method provided by @shuo-wu , but unfortunately my UI keeps showing 502 errors.

I am a newbie to longhorn and I cannot install longhorn through kubectl.....

1.0.2 same issue
kubernetes version 1.19.3
I tested the method provided by @shuo-wu , but unfortunately my UI keeps showing 502 errors.

I am a newbie to longhorn and I cannot install longhorn through kubectl.....

It seems that the UI part somehow doesn't work. The workaround won't cause this 502 error.
As for the installation, you don't need to install Longhorn via kubectl. The workaround steps is also feasible in the Longhorn installed via Rancher/Helm.

When I try to delete with kubectl, the longhorn-system namespace is always in Terminating state...

I just tried kubectl apply -f https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml according to the documentation, and then I used kubectl delete -f https://raw ....; This is too scary, the namespace created by longhorn cannot be deleted, it seems to have a permanent impact on my cluster.

You need to follow the uninstall instructions here https://longhorn.io/docs/1.0.2/deploy/uninstall/ . Use Longhorn uninstaller, or Helm instead of yaml for installation.

It's already working, so exciting! But I’m curious why I can’t install using kubectl?

@mritd Of course, you can. But you need to follow the instruction to uninstall (rather than just do kubectl delete). There are things we need to clean up during uninstallation that cannot be done by kubectl delete.

@yasker Thanks, I check the helm repo code 😀.


:warning: Update to go 1.22

Fix issues with the extension-developer-e2e and operator-sdk

Description

Reviewer Checklist

[ ] API Go Documentation
[ ] Tests: Unit Tests (and E2E Tests, if appropriate)
[ ] Comprehensive Commit Messages
[ ] Links to related GitHub Issue(s)

@tmshort the last commit in this PR was trying to do the same, without bumping go for now.
We are bumping controller-gen for generating oc manifests here, but keeping controller-runtime and other related deps like helm-operator plugins the same. Its better to keep them tied together, so we can either bump it all in this or do an immediate follow up for the same?

Bumping things like operator-controller, etc, creates an avalanche of other changes. To get things completed and done faster (i.e. reviews), it's easier to do smaller, incremental changes. We'll get there, it's just doing it in one big chunk is probably not a good idea.

@tmshort the last commit in this PR was trying to do the same, without bumping go for now.

We're still having trouble updating rukpak... that change is quite big, and should be done "as it's own thing". If we can make that PR simpler by doing some of that work here, so much the better.

The executable for controller-gen has been updated consistently, so we're not running different versions of the same tool.


Correct descriptions for map in table

Seems like some copy paste slipped through ;)

Thanks, that sometimes happens when I write docs at 2am :)


Fix a first character problem in IME with autoClosingPairs.enabled

With autoClosingPairs.enabled (default)
In IME, enter "「" (for instance)
Wrong braces appear around the input.

#2338 doesn't fix this case. This PR fixes it.

Just tried it out - looks good to me. Thanks @ackey for all your help fixing up the IME - really appreciate it! 💯  Bringing this in now.


Re-enable overmind

I'm curious if this is an M1 issue or if it has actually been fixed, because I updated tmux to 3.3a on my mac (not M1) with brew and it's working for me. Thought I'd open this PR in case it started working for anyone else too.

There's also a newer comment over in the issue in the comment I deleted which suggests running this:
> brew uninstall --ignore-dependencies tmux
> brew install tmux

But I feel like it would be more of a hassle to require our developers to do this if it's not working, so if it's not working on M1s, it's probably better to just wait as opposed to trying to run it in something like bin/configure.


Fix data race

I think these are only used for tests, so it doesn't really matter, but I was trying to go test -race something else and this kept getting in the way.

Fixed

@maxtaco ping


derive_var_obs_number creating unexpected changes to TRTA and TRTP (ADVS)

What happened?
TRTA and TRTP are derived correctly during the first half of the ADVS template, but when I get to the following section of code, both variables are changed and start showing large numbers of NA's.
advs <- advs %>%
  # Calculate ASEQ
  derive_var_obs_number(
    new_var = ASEQ,
    by_vars = vars(STUDYID, USUBJID),
    order = vars(PARAMCD, ADT, AVISITN, VISITNUM, VSSEQ),
    check_type = "error"
  )
Essentially, before I run that code, they are correct, and after I run that code, they are wrong.
As far as I can tell, that code shouldn't have any impact on TRTA and TRTP. TRT01A and TRT01P still stay the same.
I have cleared the  workspace and restarted the session, and the same thing happens each time.
Session Information

sessionInfo()
R version 4.1.3 (2022-03-10)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 20.04.4 LTS

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.9.0
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.9.0
locale:
[1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C               LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8     LC_MONETARY=en_US.UTF-8
[6] LC_MESSAGES=en_US.UTF-8    LC_PAPER=en_US.UTF-8       LC_NAME=C                  LC_ADDRESS=C               LC_TELEPHONE=C
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C
attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base
other attached packages:
[1] stringr_1.4.0   lubridate_1.8.0 admiral_0.7.0   dplyr_1.0.9
loaded via a namespace (and not attached):
[1] rstudioapi_0.13  magrittr_2.0.3   hms_1.1.1        getPass_0.2-2    tidyselect_1.1.2 R6_2.5.1         rlang_1.0.3      fansi_1.0.3      httr_1.4.3
[10] tools_4.1.3      utf8_1.2.2       DBI_1.1.3        cli_3.3.0        ellipsis_0.3.2   assertthat_0.2.1 tibble_3.1.7     lifecycle_1.0.1  crayon_1.5.1
[19] tidyr_1.2.0      purrr_0.3.4      readr_2.1.2      tzdb_0.3.0       vctrs_0.4.1      curl_4.3.2       rice_3.0         glue_1.6.2       haven_2.5.0
[28] stringi_1.7.6    compiler_4.1.3   pillar_1.7.0     forcats_0.5.1    generics_0.1.2   jsonlite_1.8.0   pkgconfig_2.0.3
Reproducible Example
vs <- convert_blanks_to_na(vs)
---- Lookup tables ----
Assign PARAMCD, PARAM, and PARAMN
param_lookup <- tibble::tribble(
~VSTESTCD, ~PARAMCD, ~PARAM, ~PARAMN,
"SYSBP", "SYSBP", "Systolic Blood Pressure (mmHg)", 1,
"DIABP", "DIABP", "Diastolic Blood Pressure (mmHg)", 2,
"PULSE", "PUL", "Pulse Rate (beats/min)", 3,
"WEIGHT", "WGHT", "Weight (kg)", 4,
"HEIGHT", "HGHT", "Height (cm)", 5,
"TEMP", "TEMP", "Temperature (C)", 6,
"RESP", "RESP", "Respiratory Rate (breaths/min)", 7,
"OXYSAT", "OXYSAT", "Oxygen Saturation (%)", 8
)
attr(param_lookup$VSTESTCD, "label") <- "Vital Signs Test Short Name"
Assign ANRLO/HI, A1LO/HI
range_lookup <- tibble::tribble(
~PARAMCD, ~ANRLO, ~ANRHI, ~A1LO, ~A1HI,
"SYSBP", 90, 130, 70, 140,
"DIABP", 60, 80, 40, 90,
"PUL", 60, 100, 40, 110,
"TEMP", 36.5, 37.5, 35, 38,
"RESP", 8, 20, NA, NA
)
ASSIGN AVALCAT1
avalcat_lookup <- tibble::tribble(
~PARAMCD, ~AVALCA1N, ~AVALCAT1,
"HGHT", 1, ">100 cm",
"HGHT", 2, "<= 100 cm"
)
---- User defined functions ----
Here are some examples of how you can create your own functions that
operates on vectors, which can be used in mutate().
format_avalcat1n <- function(param, aval) {
case_when(
param == "HGHT" & aval > 140 ~ 1,
param == "HGHT" & aval <= 140 ~ 2
)
}
---- Derivations ----
Get list of ADSL vars required for derivations
adsl_vars <- vars(TRTSDT, TRTEDT, TRT01A, TRT01P, AP01SDTM)
advs <- vs %>%
Join ADSL with VS (need TRTSDT for ADY derivation)
derive_vars_merged(
dataset_add = adsl,
new_vars = adsl_vars,
by_vars = vars(STUDYID, USUBJID)
) %>%
Calculate ADT, ADY
derive_vars_dt(
new_vars_prefix = "A",
dtc = VSDTC,
flag_imputation = "none"
) %>%
#calculate astdy and aendy
derive_vars_dy(reference_date = TRTSDT, source_vars = vars(ADT)) %>%
calculate adtm
derive_vars_dtm(new_vars_prefix = "A",
dtc=VSDTC,
flag_imputation="both")
advs <- advs %>%
Add PARAMCD only - add PARAM etc later
derive_vars_merged(
dataset_add = param_lookup,
new_vars = vars(PARAMCD),
by_vars = vars(VSTESTCD)
) %>%
Calculate AVAL and AVALC
mutate(
AVAL = VSSTRESN,
AVALC = VSSTRESC,
AVALU = VSSTRESU
)
get visit info
advs <- advs %>%
Derive Timing
mutate(
AVISIT = ifelse(!is.na(ADTM) & ADTM<= AP01SDTM, "BASELINE", VISIT)
)
advs <- advs %>%
Derive Timing
mutate(
AVISIT = ifelse(str_detect(VISIT,"(?i)Unscheduled"), "Unscheduled", AVISIT)
)
advs <- advs %>%
Derive Timing
mutate(
AVISITN = ifelse(AVISIT == "BASELINE", 0, VISITNUM)
)
advs <- advs %>%
Calculate ONTRTFL
derive_var_ontrtfl(
start_date = ADT,
ref_start_date = TRTSDT,
ref_end_date = TRTEDT,
filter_pre_timepoint = AVISIT == "Baseline"
)
Calculate ANRIND : requires the reference ranges ANRLO, ANRHI
Also accommodates the ranges A1LO, A1HI
advs <- advs %>%
derive_vars_merged(dataset_add = range_lookup, by_vars = vars(PARAMCD)) %>%
Calculate ANRIND
derive_var_anrind()
Derive baseline flags
advs <- advs %>%
Calculate BASETYPE
derive_var_basetype(
basetypes = rlang::exprs(
"LAST Period 01" = !is.na(AVISIT),
"NA" = is.na(AVISIT)
)
) %>%
Calculate ABLFL
restrict_derivation(
derivation = derive_var_extreme_flag,
args = params(
by_vars = vars(STUDYID, USUBJID, PARAMCD),
order = vars(ADTM, VSSPID, VSSEQ),
new_var = ABLFL,
mode = "last"
),
filter = (!is.na(AVAL) &
ADT < TRTSDT & !is.na(BASETYPE) & AVISIT == "BASELINE" )
)
Derive baseline information
advs <- advs %>%
Calculate BASE
derive_var_base(
by_vars = vars(STUDYID, USUBJID, PARAMCD, BASETYPE),
source_var = AVAL,
new_var = BASE
) %>%
Calculate BASEC
derive_var_base(
by_vars = vars(STUDYID, USUBJID, PARAMCD, BASETYPE),
source_var = AVALC,
new_var = BASEC
) %>%
Calculate BNRIND
derive_var_base(
by_vars = vars(STUDYID, USUBJID, PARAMCD, BASETYPE),
source_var = ANRIND,
new_var = BNRIND
) %>%
Calculate CHG
derive_var_chg() %>%
Calculate PCHG
derive_var_pchg()
ANL01FL: Flag last result within an AVISIT and ATPT for post-baseline records
advs <- advs %>%
restrict_derivation(
derivation = derive_var_extreme_flag,
args = params(
new_var = ANL01FL,
by_vars = vars(USUBJID, PARAMCD, AVISIT),
order = vars(ADT, AVAL, VSSEQ),
mode = "last"
),
filter = !is.na(AVISITN) & ONTRTFL == "Y"
)
Get treatment information
advs <- advs %>%
Assign TRTA, TRTP
mutate(
TRTP = TRT01P,
TRTA = TRT01A
) %>%
Create End of Treatment Record
restrict_derivation(
derivation = derive_var_extreme_flag,
args = params(
by_vars = vars(STUDYID, USUBJID, PARAMCD),
order = vars(ADT, VSSEQ),
new_var = EOTFL,
mode = "last"
),
filter = (4 < VISITNUM &
VISITNUM <= 13 & ANL01FL == "Y")
) %>%
filter(EOTFL == "Y") %>%
mutate(
AVISIT = "End of Treatment",
AVISITN = 99
) %>%
union_all(advs) %>%
select(-EOTFL)
#at this point TRTA and TRTP are still correct
Get ASEQ and AVALCATx and add PARAM/PARAMN
advs <- advs %>%
Calculate ASEQ
derive_var_obs_number(
new_var = ASEQ,
by_vars = vars(STUDYID, USUBJID),
order = vars(PARAMCD, ADT, AVISITN, VISITNUM, VSSEQ),
check_type = "error"
)
#after this section, the majority of TRTA and TRTP are NA

@pharmaverse/admiral Can someone please take a closer look at this?

I think the issue is in the creation of "Create End of Treatment Record" when you do a union back with ADVS
union_all(advs) %>%.
The ADVS here, is from before TRTA and TRTP are created, so the only records with TRTA and TRTP populated, are for the records with AVISIT = "End of Treatment".
If you move the creation of TRTA and TRTP to after the creation of "Create End of Treatment Record", it should be OK.

Nice spot @millerg23! Indeed while in the mutate() both TRT variables are populated for all records, they are subsequently filtered and the unioned back with the ADVS from the chunk before wherethe TRT variables have not been created, yet. So @morrishj I don't think the issue is the derive_var_obs_number() step but rather what @millerg23 described. Anyhow, this is an error in our template which we have to fix.

Shall we get this done for the release?

Ideally, yes!

@morrishj want to take this one on?

Yep I can do this one!
On Thu, 11 Aug 2022 at 14:20, Ben Straub @.***> wrote:

@morrishj https://github.com/morrishj want to take this one on?
—
Reply to this email directly, view it on GitHub
https://github.com/pharmaverse/admiral/issues/1357#issuecomment-1211980921,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZUPJH62KXS5EGBTOGLEVFLVYT42ZANCNFSM56ADTIEA
.
You are receiving this because you were mentioned.Message ID:
@.***>


feat(input): add support for more input attributes

@jelbourn I've cleaned up #343 so that it is off an up-to-date master and only one commit.

Looks good side from a few minor comments.

@jelbourn if we use the property notation (eg. [autocomplete]="autoComplete) then the property is always present on the resulting input element. In some cases it's possible to set a default (for example 'off' for autocomplete), but this may not be the required behavior - for example with autocomplete if the property is not set it defaults to the parent form's value, where if we set it explicitly by default to false it will not. It's not clear for other properties (like min and max) what a reasonable default would be.
So I think using the attribute notation and only setting the input properties when they have been set on the md-input will give a result closer to normal expectation than using property notation and defaults. It also results in cleaner generated markup - for example not setting step="any" on input[type="text"] elements where it doesn't make sense. This is the behavior that's captured by the tests.
Point taken on the parentheses for fixture - that's a quick fix.

@matthewdenobrega good point, I hadn't seen Angular tacking on the superfluous attributes yet. I also looked at tabIndex with Misko today and it seems that it's going to need special handling in core due to its weirdness.
Looks good other than needing a rebase now.

@jelbourn I've removed the parentheses from the tests and rebased.

LGTM


Update to checkstyle 8.29

since the code change at https://github.com/checkstyle/checkstyle/issues/7119 causing too many custom.import.order.separated.internally violations, I set the import check to info level

Codecov Report

Merging #1018 into develop will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1018   +/-   ##
==========================================
  Coverage      38.61%   38.61%
  Complexity       626      626
==========================================
  Files            112      112
  Lines           4695     4695
  Branches         728      728
==========================================
  Hits            1813     1813
  Misses          2735     2735
  Partials         147      147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 780dfc7...8826da9. Read the comment docs.


Adding documentation for procedural textures library

I only push the new  .md file and the updated statics.json
Not sure that I am supposed to push the generated html files. :)

Don't worry, I'll rebuild it :) Thanks !


PendingIxs refactoring and decode tx shared wallets

[x] I have introduced PendingIxs in AddressDerivation and reused it in both sequential and shared mode
[x]  I have implemented endpoint for decode tx for multisig working for all cases supported for construct tx
as in https://github.com/input-output-hk/cardano-wallet/pull/3378
[x]  I have added integration tests

Comments

Issue Number
adp-2008

bors r+

bors r+

bors retry

bors r+

bors r+


Timestamp precision in the schema of the DeltaTable of the transaction log.

Hello!
Coming from the Delta-RS community, I have several questions regarding the timestamp type in the DeltaTable schema serialization saved in the transaction log.
Context
The transaction protocol schema serialization format specifies the schema serialization format for the timestamp type with the following precision:

timestamp: Microsecond precision timestamp without a timezone.

It means that Spark uses a timestamp with microsecond precision here given a local or given timezone. But when Spark writes timestamp values out to non-text data sources like Parquet using Delta, the values are just instants (like timestamp in UTC) that have no time zone information.
Taking that into account, if we look at the configuration "spark.sql.parquet.outputTimestampType" here, we see that the default output timestamp used is "ParquetOutputTimestampType.INT96.toString". This timestamp used by this default is with a nanosecond precision when writing .parquet files. But it also could be changed to ParquetOutputTimestampType.INT64 with TIMESTAMP_MICROS or ParquetOutputTimestampType.INT64 with TIMESTAMP_MILLIS.
Use-case
When I am applying a transaction log schema on a DeltaTable (using timestamp with the microsecond precision here), I have a mismatched between the precision of the timestamp given by the schema of the protocol and the real one:

The precision of the timestamp type referenced by the transaction log is with a microsecond precision
The precision of the timestamp type written in the .parquet files is with a nanosecond precision because it uses the default outputTimestampType (but could be microseconds or milliseconds depending on the configuration)
The schema couldn't be applied on the .parquet files because I have a mismatched precision error on a timestamp column

Questions

Why the precision of the timestamp is not written with the timestamp type inside the schema of the transaction log?
It will be used if we want to get the DeltaTable schema timestamp precision if we read the DeltaTable without the Spark dependency.

Does it means that the precision of the timestamp with microsecond precision for internal Spark/Delta is for internal processing only?
In other words, the schema of parquet files must only be directly read from the .parquet files and not from the DeltaTable transaction protocol.

If we change the default timestamp precision to nanoseconds here for applying the schema on .parquet files, it will work only for the default spark.sql.parquet.outputTimestampType configuration, but not for the TIMESTAMP_MICROS and TIMESTAMP_MILLIS ones, right?

Thank you for your help!

Did the loop on this ever get closed? I've ran into this a few times when adding parquet files to delta tables because the timestamps are written with different configurations.

Since parquet 2.6 has a great int64 timestamp nanos type, could delta standardize on top of that? Java also has nanosecond precision

Iceberg is adding nanosecond type too: https://github.com/apache/iceberg/pull/8683

@alippai that's great! Unfortunately for Delta we are bound by what the delta protocol states :(

@ion-elgreco how can we extend the delta protocol? I thought this is the correct issue / repo for that.

@ion-elgreco how can we extend the delta protocol? I thought this is the correct issue / repo for that.

It's the correct repo, but it needs to get accepted in the protocol first


Create development page

Overview (Required)

From information page.
Debug info and debug menu on the page.

What kind of debug info do you want to show there?

@shiraji Sorry, I have no concrete plan now 🤔

How about clearing cache?

Like u2020, I can add debug setting drawer and easily switch retrofit behaviour for debugging purpose(e.g. change error rate, network delay).

Hi guys, I just made a PR to add a debug menu on the app, you might want to take a look.
However, it's not following the requirement listed here. Probably I should add Debug info and debug menu on the information page.


[Task]: Add legacy transaction history

Task description
TBD, think how to include this feature

load on demand and include in tx history
load when exporting to csv (feature missing)

Requirements
TBD
Creation checklist

[ ] I have assigned this task to the correct people
[ ] I have added the most appropriate labels
[ ] I have linked the correct milestone and/or project

We will provide the historical addresses and the full tx history can be checked in the explorer


macOS debug build issue

System information

OS Platform and Distribution: macOS Big Sur 11.6
TensorFlow installed from (source or binary): source
TensorFlow version: 2.6
Bazel version (if compiling from source): 3.7.2
GCC/Compiler version (if compiling from source): Apple clang via Xcode <IP_ADDRESS>E507
CUDA/cuDNN version: CPU only
GPU model and memory: CPU only

Describe the problem
Reincarnation of #46566 (truncated or malformed object (LC_SEGMENT_64 command 0 fileoff field plus filesize field extends past the end of the file) during linkage of debug build) but with latest versions (tensorflow 2.6, bazel 3.7.2, Xcode 12.5.1, macOS 11.6). I'm also fine with re-opening #46566 (I can't, permission denied).
I even tried bazel 4.2.1 (in case this was fixed there but not backported to v3.x) by increasing the max-allowed-version beyond 3.99.0 in tensorflow/configure.py. However this didn't change anything.
Seems that the size of the debug symbols grew beyond some maximum supported threshold.

FAILED: Build did NOT complete successfully
FAILED: Build did NOT complete successfully

Steps to reproduce:
$ git clone https://github.com/microsoft/vcpkg
$ ./vcpkg/bootstrap-vcpkg.sh

Remove the work-around I added in microsoft/vcpkg/pull/20015 in file ./vcpkg/ports/tensorflow-common/tensorflow-common.cmake at line 190
		elseif(VCPKG_TARGET_IS_OSX)
			set(BUILD_OPTS --compilation_mode=fastbuild) # debug build on macOS currently broken

by reverting back to --compilation_mode=dbg. Then start the build:
$ ./vcpkg/vcpkg install tensorflow

this did the  trick for me on M1:
bazel build -s --config=dbg --config=macos_arm64 --copt=-mcmodel=large --cxxopt=-mcmodel=large tensorflow/tools/pip_package:build_pip_package

@jgehw , Could you please refer the above comment and let us know if that works for you. Thanks!


Add Wiki file. Quickly explains how to use the tool.

I have written a short instruction guide on how to build/install the tool. Note: I have written this from a Windows perspective, as I do not have a spare Linux machine to test this on. I believe the instructions should be the same.
As I cannot create a pull request for the WIKI, I will need @bauersimon to copy+paste the markdown from WIKI.md to the Wiki page on the repository.

Done! Thank you so much!


fix(codec-jackson): fix json response error when response type is generic type.

Motivation:
When response type is generic type, json decode occur error.
public List<DemoResponse> say3(List<DemoRequest> list);

Modification:
Save response generic type to jackson's JavaType.
Result:

Codecov Report

Merging #921 into master will decrease coverage by 0.07%.
The diff coverage is 70.58%.

@@             Coverage Diff              @@
##             master     #921      +/-   ##
============================================
- Coverage     70.02%   69.95%   -0.08%
  Complexity      816      816
============================================
  Files           395      395
  Lines         16436    16440       +4
  Branches       2580     2580
============================================
- Hits          11510    11501       -9
- Misses         3581     3590       +9
- Partials       1345     1349       +4

Impacted Files
Coverage Δ
Complexity Δ

...ipay/sofa/rpc/codec/jackson/JacksonSerializer.java
83.47% <66.66%> (-1.28%)
34.00 <0.00> (ø)

...m/alipay/sofa/rpc/codec/jackson/JacksonHelper.java
84.61% <72.72%> (+0.40%)
8.00 <3.00> (ø)

...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java
64.17% <0.00%> (-5.23%)
0.00% <0.00%> (ø%)

...pay/sofa/rpc/transport/ClientTransportFactory.java
73.84% <0.00%> (-4.62%)
0.00% <0.00%> (ø%)

...ofa/rpc/registry/zk/ZookeeperOverrideObserver.java
39.34% <0.00%> (-1.64%)
0.00% <0.00%> (ø%)

...va/com/alipay/sofa/rpc/server/bolt/BoltServer.java
74.48% <0.00%> (-1.03%)
0.00% <0.00%> (ø%)

...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java
88.65% <0.00%> (-0.93%)
0.00% <0.00%> (ø%)

...ofa/rpc/message/bolt/BoltFutureInvokeCallback.java
79.24% <0.00%> (+7.54%)
0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a801c...8955ec4. Read the comment docs.


Force CLASP to use preset configurations through libclasp's API

Hello,
I am using the ClaspFacade API in order to do Pseudo-Boolean optimization. However, I am not getting the same performance from CLASP using the API that I get when passing an .opb file to the CLASP application.
I believe it is due to the fact that I am not passing the default PB configuration (trendy) to the ClaspFacade when calling startPB.
This is the code that I have right now:
...
ClaspFacade clasp;
ClaspConfig clasp_config;
config.solve.optMode = MinimizeMode_t::optimize;
clasp.startPB(config);
...

Is there some way for me to obtain the trendy configuration (or others like crafty) as a ClaspConfig object and pass it to the ClaspFacade on the call to startPB? I have been looking through the code searching for a way to do so, but with no luck.
Thank you in advance.
Best regards,
Miguel Neves

Hi,
the easiest thing would be to use Clasp::Cli::ClaspCliConfig instead of ClaspConfig.
For this, you have to

include <clasp/cli/clasp_options.h>
link against the libprogram_opts library

You can then do something like this:
Clasp::Cli::ClaspCliConfig config;
const char* args = "--config=trendy";
// init configuration to 'trendy'
config.setConfig(&args, &args + 1, Clasp::Problem_t::Pb);
...

Just tried it and it is working properly now. Thank you very much!
Best regards,
Miguel Neves


Brane Log

While working on CI, MSRV in particular, I'm running into an issue with Brane log.
For MSRV I'm running a script along the lines of find . name Cargo.toml -exec .... However, this is failing now because of Brane-Log. What is the current state of Brane log? Should we keep this around, or can we move this over to a separate branch until it's done, for example?
I could also make my tooling more robust, and ideally I would like to, but I cannot really afford to spend more time on CI right now.

I worked around the issue in this case, but I'm still curious on the state of log and whether we should move this to a long lived branch while we are not using it. The less is in the main tree, the better if you ask me.

The only reason I kept it around all these years is a stinging reminder that Brane desperately needs a form of audit logs akin to what the policy-reasoner itself has. Just something that forms as a trusted service per node that collects important events that are relevant to checking policy (although, maybe slightly less necessary with the current policy scheme? Idk, at the very least, warrants thinking about).
So... yeah no worries removing it if we just create an issue or TODO somewhere xD


Fix misc small issues

Remove tarball from SCM. Replaced with a text file pointing anyone looking for it to the UH HPCTools github page
Updated ABI link on README, per @rouson's request (https://gitter.im/sourceryinstitute?at=56746177f240f5a004173aa5)
Also disabled the allocate_as_barrier_proc test if on OS X and Travis-CI

Current coverage is 38.57%

Merging #76 into master will not affect coverage as of 4a32cfd

@@            master     #76   diff @@
======================================
  Files            2       2
  Stmts          884     884
  Branches         0       0
  Methods          0       0
======================================
  Hit            341     341
  Partial          0       0
  Missed         543     543

Review entire Coverage Diff as of 4a32cfd

Uncovered Suggestions

+1.92% via src/mpi/mpi_caf.c#1892...1908
+1.58% via src/mpi/mpi_caf.c#1990...2003
+1.58% via src/mpi/mpi_caf.c#1557...1570
See 7 more...

Powered by Codecov. Updated on successful CI builds.

I'm going to merge these changes. It's been almost 24 hours since initiating the request, and the only change effecting the build at all is the CMakeLists.txt minor changes to prevent failing builds on Travis OS X and provide a menu of build types in ccmake or cmake-gui.


pkg/trace: make pkg/trace/agent control the lifecycle of pkg timing

What does this PR do?
Revamp the timing package and make pkg/trace/agent control its lifecycle.

Motivation
fixes https://github.com/DataDog/datadog-agent/issues/22030

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

@knusbaum thanks! I ended up implementing a different and simpler approach.

/merge


fix: amazon captcha false-positives

Description
Bandaid fix for amazon captcha page false-positives.
Testing
Running the script after updating and haven't seen any more false-positives for amazon searches yet.
The amazon captcha page looks like this:

After running the script for a few hours after this change, I have still seen 2 false positives with amazon captcha pages.  It does appear to happen less frequently, but this is just a temporary bandaid solution anyways.  I won't be offended if this gets closed without merging.


Signature parsing with regular expression failure

The regular expression used for splitting the signature accesses index 3.
stdout.split(/(\r\n|\n\n)/)[3];
This is breaking since the regular expression doesnt work as expected. The signature is actually present at index 6.

The issue is not with the index. The issue is with the regular expression itself.
it should have been var signature = stdout.split(/(\r\n\r\n|\n\n)/)[3];
#64 broke this in 2.2.0 release.

The regular expression is capturing '\r\n' and '\n\n'. Therefore 3 more captured line breaks are in the result array of stdout.split(/(\r\n\r\n|\n\n)/) and the signature appears in position 6 instead of 3.
I am having success by removing the bracket in the regular expression.
var signature = stdout.split(/\r\n|\n\n/)[3];


Adds back in cloud-stream-rabbit sample

This adds back in the SCSt Rabbit binder sample.

Current state of SCSt wrt to AOT/Native is that both Kafka and Rabbit binder samples work in AOT mode but not yet in Native mode.
Once this is merged these 2 samples can be moved into the smoke test repo.

@mhalbritter do you mind merging this?
Contributes toward #1532

Thanks!


chore: release main

:robot: I have created a release beep boop
@libp2p/multidim-interop: 2.0.8
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/webrtc bumped from ^4.0.7 to ^4.0.8
@libp2p/webtransport bumped from ^4.0.7 to ^4.0.8
libp2p bumped from ^1.0.7 to ^1.0.8

@libp2p/webrtc: 4.0.8
Dependencies

The following workspace dependencies were updated

devDependencies

libp2p bumped from ^1.0.7 to ^1.0.8

@libp2p/webtransport: 4.0.8
Dependencies

The following workspace dependencies were updated

devDependencies

libp2p bumped from ^1.0.7 to ^1.0.8

libp2p: 1.0.8
1.0.8 (2023-12-04)
Bug Fixes

make transports optional (#2295) (887c6ff)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/libp2p/js-libp2p/releases/tag/multidim-interop-v2.0.8 :sunflower:

:robot: Release is at https://github.com/libp2p/js-libp2p/releases/tag/webrtc-v4.0.8 :sunflower:


Unable to target HTML elements with classes or IDs within CSS modules

Describe the bug
When using CSS modules, you cannot target HTML elements using their classes or IDs. You can however, still target the element type.
I have checked that inline styles still work, regular CSS files work, CSS modules work until you start the specific targeting.  The styles will not show up in development or production.
Reproduction
https://stackblitz.com/edit/vitejs-vite-y1hnti?file=style.module.css
Steps to reproduce
Style an element using classes or IDs in a *.module.css file.
Look for style changes or style declarations within compiled CSS in dev tools.
System Info
System:
    OS: Linux 5.15 Ubuntu 22.04.3 LTS 22.04.3 LTS (Jammy Jellyfish)
    CPU: (8) x64 Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz
    Memory: 6.33 GB / 7.71 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 18.15.0 - ~/.nvm/versions/node/v18.15.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.15.0/bin/yarn
    npm: 9.6.4 - ~/.nvm/versions/node/v18.15.0/bin/npm
  npmPackages:
    vite: ^4.3.2 => 4.4.11

Used Package Manager
yarn
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I think this is working as intended. CSS Modules are meant to be local. If you want to make it global, you'll need to wrap the selector with :global.
p:global(#style) {
  color: orange;
}


[RFE] Add support for multi-view

VK: https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_multiview.html
D3D12: https://microsoft.github.io/DirectX-Specs/d3d/ViewInstancing.html
D3D11: ???

Duplicate :(


i.fitted.icon needs !important for margins

Looks like i.fitted.icon needs !important for removing margins - otherwise .ui.label > .icon overrides it.
Example: https://codepen.io/indreksiitan/pen/QQbyzw

Fix is in 2.3.1