Deneb Branch for mock relay testing (Devnet-7)

Issue Addressed
Which issue # does this PR address?
Proposed Changes
Please list or describe the changes introduced by this PR.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.

Testing notes today

geth's devnet-8 fork still missing shouldOverrideBuilder
testing with devnet-7 now

getting forkChoiceUpdatedV1 not available from builder EE when using a local EE
tried using noop builder instead, seeing problems with encoding & decoding execution payload deneb, check the fields on monday.


Plugin broken on godot 3.5 'problem with plugin.GD'

Godot 3.5 mono windows 64
plugin version 1.0.0
Windows 11 device
The plugin will not enable in godot 3.5 mono with the text: 'Unable to load addon script from path: 'res://addons/dreadpon.spatial_gardener/plugin.gd'. This might be due to a code error in that script.
Disabling the addon at 'res://addons/dreadpon.spatial_gardener/plugin.cfg' to prevent further errors.'
I have checked plugin.gd and it has the error: (16,48) couldn't fully preload the script, possible cyclic reference or compilation error. use "load()" instead if a cyclic reference is intended.'
This error is on the line referencing the garderner.gd file. When I opened that fine I received the same error about line 18, referencing the defaults script. The defaults script had the same error at line 9 referencing the toolshed script, which had the same error at line 11 referencing the toolshed_brush script which has the error message "Script isn't fully loaded (cyclic preload?)"
To reproduce attempt to add the plugin on the 3.5 mono version of godot.

This is related to this issue: https://github.com/dreadpon/godot_spatial_gardener/issues/8
The signal should probably be generally removed now, as 3.5 is out officially

There are a number of things I'd like to implement, including fixing this and making a proper 3.5 release.
I'll get on it soon.

For now, closing it in favor of #8.


Storage of found items is unclear

How should these be stored? Historically they have been stored in three separate maps. This seems questionable. It would be better to have a single searchable data structure for them all.

IxSet may be a good choice. Alternatively, a database.

IxSet was throwing runtime errors which seemed unHaskell to me. The current slice uses a map from tuple of list of int and string tagged with origin or hop to set of ortho. On insert it explodes the origin and hop and does multiple inserts, and on query, it does multiple searches and collects results. This seems to violate the idea that the data should be stored once, but thinking on it more, in a DB if there were a normalized version of this it would soon be joined on query, or it would be saved denormalized. The remaining question is whether it is best to tag the string or to add a hop up front and have two sub-maps. The current approach provides a nicer internal interface, but it will slow down query and insert of origin as it will be outweighed in number by hop. That said, the first added layer of indirection would not be without cost, and all of this is assuming implementation details of heavily optimized built in maps.


Setup Continuous Integration

This is dependent on #2
We need to setup a Circle CI config and integrate it with GitHub to run all our tests against each pull request.

This was done in #5.


Problem details /2

contributes to #26685
Internal review URL

Public review  of the doc build:

download the HTML files
unzip
view HTML file in a browser.
For links outside the doc, remove the review. from URL.
@sammychinedu2ky  start at

Client error response

Public review of the doc build:

download the HTML files
unzip
view HTML file in a browser.
For links outside the doc, remove the review. from URL.
@sammychinedu2ky  start at

Client error response

Thanks @Rick-Anderson 😅, but I wasn't able to see how the problem was resolved since the controller writes the problem details to stream before the middleware handles it.
Since there is no way around it than changing the controller like this:

Should I live the code as it is since you explained why in the post?

Should I leave the https://github.com/dotnet/AspNetCore.Docs.Samples/issues/60as it is since you explained why in the post?

No, do a PR and create a 3rd controller named Values3Controller. After explaining the problem we'll show the work around.

Should I leave the https://github.com/dotnet/AspNetCore.Docs.Samples/issues/60as it is since you explained why in the post?

No, do a PR and create a 3rd controller named Values3Controller. After explaining the problem we'll show the work around.

I can only see one controller from my end or am I mistaken?

@Rick-Anderson

https://github.com/dotnet/AspNetCore.Docs.Samples/blob/main/fundamentals/middleware/problem-details-service/Controllers/ValuesController.cs#L39
2 controllers, one file. Put the 3rd controller in the same file.

https://github.com/dotnet/AspNetCore.Docs.Samples/blob/main/fundamentals/middleware/problem-details-service/Controllers/ValuesController.cs#L39
2 controllers, one file. Put the 3rd controller in the same file.

Ooh I need to pull, I don't have this locally 😅

Ooh I need to pull, I don't have this locally 😅

Never do a PR from your old branch.

Ooh I need to pull, I don't have this locally 😅

Never do a PR from your old branch.

Sure thanks

The sample app ~also~ contains the following database context class:
dead wood

The sample app ~also~ contains the following database context class:
dead wood

Does "dead wood" mean something special here? 😂


Parquet pages for different columns cannot be read in parallel

All ColumnChunkPageReader instances use the same decompressor.
https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java#L1286

BytesInputDecompressor decompressor = options.getCodecFactory().getDecompressor(descriptor.metadata.getCodec());
return new ColumnChunkPageReader(decompressor, pagesInChunk, dictionaryPage);

The CodecFactory caches the decompressors for every codec type returning the same instance on every getCompressor(codecName) call. See the caching happening here:
https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/CodecFactory.java#L197

@Override
 public BytesDecompressor getDecompressor(CompressionCodecName codecName) {
    BytesDecompressor decomp = decompressors.get(codecName);
    if (decomp == null){
       decomp = createDecompressor(codecName); decompressors.put(codecName, decomp);
    }
    return decomp;
 }

If multiple threads try to read the pages belonging to different columns, they run into thread
safety issues. This issue prevents increasing the throughput at which applications can read parquet data by parallelizing page reads.
Reporter: Samarth Jain / @samarthjain
Assignee: Samarth Jain / @samarthjain
PRs and other links:

GitHub Pull Request #668
GitHub Pull Request #670

Note: This issue was originally created as PARQUET-1641. Please see the migration documentation for further details.

Samarth Jain / @samarthjain:
Note that I ran into this issue when files were compressed using GZIP. Reading the code, it seems like BuiltInGzipDecompressor is not meant to be pooled. But the CodeFactory$HeapBytesDecompressor is still sort of pooling it.


Broken formatting of varargs

prettyplease formats this code
extern "C" {
    fn printf(format: u8, ...);
}

into this code
extern "C" {
    fn printf(format: u8...);
}

The comma before the vararg was lost.

Thanks!


Connection leak when redis cluster has "<IP_ADDRESS>" in its node list.

Expected behavior
An exception in adding a cluster member connection should not result in a connection leak
Actual behavior
Our redis cluster had two nodes which had configured themselves as "<IP_ADDRESS>:6379" in the cluster configuration.  Upon connecting two this cluster, redisson properly threw exception
org.redisson.client.RedisConnectionException: Unable to connect to Redis server: /<IP_ADDRESS>:6379

Later in the logs we find, repeatedly
Can't connect to master: redis://<IP_ADDRESS>:6379 with slot ranges: [[0-5461]]

Each of these subsequent attempts appear to leave a new connection open to the redis node from which redisson is gathering cluster nodes information.  Over the course of ~2h, this used the remainder of that redis node's 10k connection limit.
Steps to reproduce or test case
I'm not sure how our redis server came to this state originally, but I was able to reproduce by stopping a cluster member, changing the address field in the "myself" line in the cluster config (in our case, /var/lib/redis/redis-6379.conf) from
<IP_ADDRESS>:6379@16379
to
<IP_ADDRESS>:6379@16379
Redis version
6.0.9
Redisson version
3.15.0
Redisson configuration
    fun redissonClient(): RedissonClient {
        val config = Config()
        config.useClusterServers()
            .addNodeAddress("redis://$redisHost")
        config.codec = StringCodec.INSTANCE
        val redisson: RedissonClient = Redisson.create(config)
        val topic: RTopic = redisson.getTopic(testTopic)
        topic.addListener(Any::class.java) { channel, msg ->
            log.info { "$channel - $msg" }
        }
        return redisson
    }

Where $redisHost resolves by dns to A records for each node in the redis cluster.

Please try version attached
redisson-3.15.1-SNAPSHOT.jar.zip

Fixed

Can you share log output with TRACE logging level for org.redisson package?


[INLONG-8727][Dashboard] Approval management Application details optimization

Prepare a Pull Request
(Change the title refer to the following example)

Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Fixes https://github.com/apache/inlong/issues/8727

Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve?
Modifications
Describe the modifications you've done.
Verifying this change

@bluewang
A little idea:
The icon(☑) can be changed (not related to the current content), or no icon.


Switch to using an updated combine-lists library

I can't get the maintainer of combine-lists to merge my changes, so I self published the library. This is just a change to that reference. /cc @khezen
Update: it also contains a fix for a lodash vulnerability

npm published.
Sorry it took so long, I was on Holidays.

np, thanks!


CDD Support for Piecewise Linear Data

Support CDD data types that have different scaling for different value ranges (COMPTBL or "Piecewise Linear")
Will still add unit tests for the new feature but feel free to already give me some feedback!

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

145 of 151 (96.03%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 94.033%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cantools/database/utils.py
47
48
97.92%

cantools/database/diagnostics/data.py
20
22
90.91%

cantools/database/diagnostics/formats/cdd.py
70
73
95.89%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
7076

Relevant Lines:
7525

💛  - Coveralls

I did some refactoring to my previous implementation that should clear up the remaining open points.
Mainly, the piecewise data types now no longer reuse the maximum / minimum fields but instead have a new (optional) tuple that defines start/end points of individual segments.
Besides that, there is now also a unit test covering the new feature and some general cleanup of my previous "quick and dirty" solution. (Sorry for all the mixed in formatting changes, I wrongly assumed the code had already been formatted with black before)
Would appreciate if you could have another look @andlaus

The change ended up being quite a bit bigger than anticipated but as an added bonus the common interfaces between Signal and Data are now united in a common base class which gets rid of a bit of duplicate code and allows Signal to support piecewise linear datatypes as well, once it passes a segment_boundaries value to its super().__init__() call.
All Signal related unit tests still pass without any modifications so there should have been no unintentional change to existing external interfaces.

@1atabey1 @andlaus What do you think about extracting the DataElement super class into a separate PR to reduce the complexity of this one?

I'd appreciate it, but IMO it is not necessary: I'd much rather have a better name for that class than DataElement ("Anything").

@1atabey1: BTW, if you can convert your CDD file to ODX (e.g., using ODXStudio),  you might want to consider proceeding using the odxtools module. The feature set needed for automotive diagnostics supported by it should be much more comprehensive than that the one of cantools...

@1atabey1: BTW, if you can convert your CDD file to ODX (e.g., using ODXStudio), you might want to consider proceeding using the odxtools module. The feature set needed for automotive diagnostics supported by it should be much more comprehensive than that the one of cantools...

Yep thanks for the hint, was already playing around with it a bit but unfortunately the odx export was combining multiple jobs into one which created a data type that is not yet supported by odxtools (TableKeyParams). I am also planning on moving our test systems to that and contributing but short term we just needed something that works (mostly) :)

unfortunately the odx export was combining multiple jobs into one which created a data type that is not yet supported by odxtools (TableKeyParams)

Okay, thanks for the hint. I'll put that on my TODO list for odxtools ;)

@andlaus @zariiii9003 push :)
Would you mind having a look again?

Yes, sorry, i'll try to do it this week 😅

I'm also on it (as usual, I stumbled over quite a few unrelated issues which I indend to fix). expect a PR for your PR soonish...

@1atabey1: the changes which I would like to see are in https://github.com/1atabey1/cantools/pull/2 .
I found that reviewing this PR was extraordinarily difficult (and I might even have missed a few things). For your next PR, I would be grateful if you did not run a code reformatter on existing files during the excercise and if you rebased your PR's branch on top of the new master while the PR is open instead of merging it...
@zariiii9003, @juleq: If you find some time for this, I would be grateful if you had a closer look as well...

This PR increases the encoding time by 218% and the decoding time by 500%. And reviewing this feels like work 😄
I think that some of the code in this and Andreas' PR looks clunky and needs refactoring. What do you think about extracting the scaling logic into separate classes like IdentityScaling, LinearScaling, NamedSignalScaling and PiecewiseLinearScaling?
Then we could perform most of the checks at instantiation and remove runtime checks.
We could create a factory function which returns that correct scaling class:
def scaling_factory(
   scale: Union[List[float], float] = 1.0,
   offset: Union[List[float], float] = 0.0,
   choices: Optional[Choices] = None,
   is_float: bool = False,
   segment_boundaries: Optional[PiecewiseSegment] = None,
) -> ScalingBase:
    ...

The SignalBase would then be instantiated with the ScalingBase instance.

This PR increases the encoding time by 218% and the decoding time by 500%.

hm, I cannot see this, at least not for the https://github.com/1atabey1/cantools/pull/2 version:
> cat benchmark.py
#! /usr/bin/python3

import cantools
import timeit

db = cantools.database.load_file("tests/files/dbc/vehicle.dbc")

msg = db.get_message_by_name("RT_SB_Trigger_Timestamp")

decoded = {
    "Validity_Trigger_Timestamp": 1,
    "Accuracy_Trigger_Timestamp": 35,
    "Trigger_Number": 12,
    "Trigger_Timestamp_Type": "Rising edge",
    "GPS_High_Resolution_Time": 24*3600*3 + 4*3600 + 18*60 + 54.35,
}

n = 500*1000
dt = timeit.timeit('msg.encode(decoded)',
                   number=n,
                   globals=globals())
print(f"encode time: {dt/n * 1e6} us")

encoded = msg.encode(decoded)
n = 500*1000
dt = timeit.timeit('msg.decode(encoded)',
                   number=n,
                   globals=globals())
print(f"decode time: {dt/n * 1e6} us")

> git checkout master; python3 benchmark.py
Switched to branch 'master'
encode time: 12.626726176124066 us
decode time: 8.277152920141816 us
> git checkout piecewise_linear; python3 benchmark.py
Switched to branch 'piecewise_linear'
encode time: 15.316010738024486 us
decode time: 7.754923384170979 us

which implies an increase of 21% in encode time and 6.7% in decode time. I suspect that this is mainly because this PR makes signal.{scale,offset} properties...

I think that some of the code in this and Andreas' PR looks clunky and needs refactoring.

I agree. That said, it seems to work ;)

What do you think about extracting the scaling logic into separate classes like IdentityScaling, LinearScaling, NamedSignalScaling and PiecewiseLinearScaling?

this requires that user code no longer scales values manually but always uses signal.{raw_to_scaled,scaled_to_raw}(). A significant chunk of my proposed changes concern themselfs with that. I'm also not sure what the performance implications would be and how to implement this elegantly. (Finally, there would need to be a LinearWithNamedValuesScaling as well a PiecewiseLinearWithNamedValuesScaling.)

I can't share the dbc file, but this is my test code (python 3.11):
print(f"{len(message.signals)=}")
n = 10_000
dt = timeit.timeit('data = message.encode(unpacked, strict=False, scaling=True)', globals=globals(), number=n)
print(f"encode time: {dt/n * 1e6} us")
dt = timeit.timeit('message.decode(packed, decode_choices=False, scaling=True)', globals=globals(), number=n)
print(f"decode time: {dt/n * 1e6} us")

master branch:
len(message.signals)=39
encode time: 11.362459999963903 us
decode time: 5.778760000021066 us

1atabey1/dev:
len(message.signals)=39
encode time: 33.58198999999331 us
decode time: 27.92778000002727 us

andlaus/piecewise_linear:
len(message.signals)=39
encode time: 24.20640000000276 us
decode time: 12.794269999994867 us

I'd suggest once again that we start with refactoring and merge the non-controversial changes in small easy-to-review chunks. Once those are merged we can try different solutions to implement the scaling stuff.

@andlaus @zariiii9003 Thanks for the feedback! Sorry for being afk for a while got sick and didnt really check my github.
I see your concerns and would personally suggest to redo this feature from scratch based on https://github.com/cantools/cantools/pull/563 and decline this merge request. (and disable my formatter before the next one :) )
@andlaus I assume that this might also make major parts of your pr https://github.com/1atabey1/cantools/pull/2 obsolete and if there still is something relevant you can maybe merge it to master instead?

I see your concerns and would personally suggest to redo this feature from scratch based on https://github.com/cantools/cantools/pull/563 and decline this merge request. (and disable my formatter before the next one :) )

+1. let's do that. I suggest that you close the PR yourself, though...

@andlaus I assume that this might also make major parts of your pr https://github.com/1atabey1/cantools/pull/2 obsolete and if there still is something relevant you can maybe merge it to master instead?

if I didn't screw up, the relevant parts should already be merged into master...

It would be great if you created separate PRs for BaseSignal and the piecewise-linear stuff 😄


ViteJS doesn't seem to properly resolve symlinks

[x] Read the docs.
[x] Make sure this is a Vite issue and not a framework-specific issue.
[x] This is a concrete bug.

Describe the bug
ViteJs doesn't properly resolve symlinks.
Reproduction
Repro repo: https://github.com/dbismut/preconstruct-repro
After installing dependencies, please run yarn vite.
See comment here for hint at a solution.
https://github.com/preconstruct/preconstruct/issues/378#issuecomment-789681043
Relevant bit from comment

We might notice here that the importer is in the dist directory - but it's actually a linked file and thus it should be resolved to the real path (in the src directory). This is IMHO a problem with Vite's resolver as this works correctly with most of the popular tools.
This particular issue can be fixed by adjusting the body of this condition:
https://github.com/vitejs/vite/blob/39820b96cec2c672e849e160b92b42c979b85285/packages/vite/src/node/plugins/resolve.ts#L348-L355
to:

resolved = fs.realpathSync(resolved)
return { id: resolved }

but I'm not super convinced that this is the appropriate place for the fix - the resolving logic in Vite is quite complex and has some layers. So it would really be best for them to assess at what level this should be fixed. It's also worth noting that it might be worthwhile to use fs.realpathSync.native if it's available in the given node version.

System Info

vite version: 2.0.5
Operating System: MacOS 11.2.2
Node version: 12.8.4
Package manager (npm/yarn/pnpm) and version: yarn 2.4.1

Logs (Optional if provided reproduction)

Run vite or vite build with the --debug flag.
Provide the error log here.

[vite] Internal server error: Failed to resolve import "./data". Does the file exist?
  Plugin: vite:import-analysis
  File: /Users/david/repos/preconstruct-repro/packages/a/dist/myrepo-a.esm.js
  1  |  import { data } from "./data";
     |                        ^
  2  |
  3  |  export function fn1() {
      at formatError (/Users/david/repos/preconstruct-repro/node_modules/vite/dist/node/chunks/dep-e0f09032.js:45829:46)
      at TransformContext.error (/Users/david/repos/preconstruct-repro/node_modules/vite/dist/node/chunks/dep-e0f09032.js:45825:19)
      at normalizeUrl (/Users/david/repos/preconstruct-repro/node_modules/vite/dist/node/chunks/dep-e0f09032.js:47321:26)
      at async TransformContext.transform (/Users/david/repos/preconstruct-repro/node_modules/vite/dist/node/chunks/dep-e0f09032.js:47450:57)
      at async Object.transform (/Users/david/repos/preconstruct-repro/node_modules/vite/dist/node/chunks/dep-e0f09032.js:46027:30)
      at async transformRequest (/Users/david/repos/preconstruct-repro/node_modules/vite/dist/node/chunks/dep-e0f09032.js:61631:29)
      at async /Users/david/repos/preconstruct-repro/node_modules/vite/dist/node/chunks/dep-e0f09032.js:61739:32
  vite:time 7ms   Users/david/repos/preconstruct-repro/packages/a/dist/myrepo-a.esm.js +22ms

I just tried with Vite 2.1.0 and the issue persists.

I have the same problem with sveltekit - I opened an issue in sveltekit, but I'll copy the main parts here:
Describe the bug
I want to be able to develop some code that can be used by more than one website. So I want the contents of /routes to be populated with some real files but symlinked folders too.
I try to symlink a local folder into /routes/p and access a markdown file from that folder:
Logs
I get this error:
Cannot find module 'svelte/internal' from '<my-project>/src/routes/p'
To Reproduce
I'm using a symlink on mac to link a folder into /routes/p
ln -s ~/path/to/markdown/folder ./src/routes/p

I'm using a very simple mdsvex config
/** @type {import('@sveltejs/kit').Config} */
const config = {
	extensions: [".svelte", ...mdsvexConfig.extensions],
	// Consult https://github.com/sveltejs/svelte-preprocess
	// for more information about preprocessors
	preprocess: [
		preprocess({
			postcss: true,
		}),
		mdsvex(mdsvexConfig),

	],
	kit: {
		vite: {
                     ......

Expected behavior
There should be a way to configure preserveSymlinks. I dug into the vite code and it looks like this is hardcoded to false unless running from pnp or something?
If I hardcode it to true instead of false, my code works.
https://github.com/vitejs/vite/blob/8b5a6a855091e6f744cc7b886cf927d14dc74d50/packages/vite/src/node/utils.ts#L36-L50
Additional context
I commented on mdsvex issues looking for an alternative solution to my problem.

I'm also having this issue -- I'm using yalc to develop some app dependencies locally. Those dependencies compile to CommonJS modules. I added the dependencies to optimizeDeps since they're found outside of the node_modules folder, and when I do, I get the following error:
Error: Build failed with 1 error:
dep:@genability_api:1:23: error: Could not resolve<EMAIL_ADDRESS>(mark it as external to exclude it from the bundle, or surround it with try/catch to handle the failure at run-time)```

It would be nice to just have it exposed through the config.
Ran into the same issue with shared code for an admin interface inside of svelte-kit. (like @Madd0g )

@dbismut @Madd0g , I published a workaround. With it I fake a pnpapi package.
Have fun 😉
<EMAIL_ADDRESS>

https://github.com/vitejs/vite/pull/4708 was just merged, which should fix this


Create a Transaction tracker

We would like to put less strain on the dai.poa.network so it would be cool to have a node app that tracks burner wallet transactions and stores them in a database so we can query it for a list of transactions.
We don't really want any analytics built into the wallet on purpose so I propose we use a specific gas price to signify a transaction is coming from a burner wallet.
So any account that sends using 1.010101 gwei gas should have all their transactions stored in a centralized database so we can query that for a transaction list instead of scraping blocks from the network.
It would also be cool to have a graph of transaction numbers just so we can see burner wallet activity.

The funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @johngrantuk.

Closing this. Feel free to reopen.


feat: port Analysis.Convex.Basic

[ ] depends on: #2866
[ ] depends on: #2869
[ ] depends on: #2923
[ ] depends on: #3050

This PR/issue depends on:

leanprover-community/mathlib4#2866
leanprover-community/mathlib4#2869
leanprover-community/mathlib4#2923
leanprover-community/mathlib4#3050
By Dependent Issues (🤖). Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#2866
leanprover-community/mathlib4#2869
leanprover-community/mathlib4#2923
leanprover-community/mathlib4#3050
By Dependent Issues (🤖). Happy coding!


Subtitles don’t display

When I try to mine a subtitle, it tells me to open a file. When I open a ass file, it doesn’t do anything, and if I try to open it from the webpage it turns white. The file works elsewhere so I think it’s an asb problem

Can you upload the file here? What site are you seeing this problem on?

No response

Sorry for not responding. I tried another file and it worked, so I think it was the ass

@SomieStuff If you are able, can you upload the file here? Maybe I can fix it.


README: short links in examples should be HTTPS

From #22

kubectl apply is arbitrary code execution as your user on a cluster. As such, the urls should not be trivially MITM-able to malicious code on. e.g. coffee shop wifi.

We should find a solution for serving the short links over https.

For the watchers on this issue, we're working on getting the redirector service upgraded to support https. I'm tentatively marking this for 0.2 although, because of the multiple people involved in coordinating this change, it may arrive before or after 0.2.

Fixed https://github.com/heptio/contour/commit/3805706f13b113efb617dac825dfb63300f526ca


Github Action got archived

This actions which you are using for your changelog is currently unmaintained.

Oh good spot 👍 that must have happened recently.
Some suggestions from their README

https://github.com/elgohr/Github-Release-Action
https://github.com/marvinpinto/action-automatic-releases
https://github.com/softprops/action-gh-release
https://github.com/ncipollo/release-action

Okay how do I create a PR for this?

I would love to work on this 😄


add login screen and store, type, i18n boilerplate

Add a bunch of boilerplate and start for login screen

Opened integration/auth PR instead


How do you initialize the model？

Hi,I don't find the option for initialization in your code..

We just utilize default PyTorch initialization.
It works very well, and we found that other initialization methods actually do not boost the model performance.


convert XCTests to the new swift testing framework

Feel free to close this PR if it isn't something you're interested in changing. I just used this opportunity to learn the new swift testing framework.
All tests pass.

Looks great!


Confusing use of search and get_obs_surface in first tutorial

We should update this to reframe

search_* (and retrieve?) as exploratory - find out what data is there and grab it
get_* as programmatic - the get functions will only allow one set of data to be returned and will give details if this is not the case


Improve incremental build in presence of globs

First iteration, looking for feedback. Filename, where I ended up putting it (Common targets vs Roslyn Core targets, etc.).

Fix issue with incremental build with globs.
Add a target that runs before CoreCompile that will record and store the state of the Compile ItemGroup. This file is added to the CustomAdditionalCompileInputs which is an input to CoreCompile. When this file changes, CoreCompile will run again. This fixes the issue of deleting a file or adding a file with an old timestamp to a glob (e.g. *.cs).

Add WriteOnlyWhenDifferent to WriteLinesToFile
Add option to not write the file when the file would not have changed (preserves the timestamp).

The original prototype wrote the file after compile and then subsequent runs could read that before compile and compare the file to the Compile ItemGroup. I went with this approach as it was far simpler and hopefully more elegant, but required a change to WriteLinesToFile to preserve the time stamp when the file doesn't change.

Right now we don't have any logic around incremental build in the compiler and right now that feels appropriate.
Basically, the compiler itself just executes build commands from MSBuild -- so it feels like whether or not to issue the command is the responsibility of the MSBuild core tasks + targets, while figuring out how to execute the build is the responsibility of the Roslyn tasks + targets.

@agocke Agreed, that totally meshes with the MSBuild model. But do you have any objection to this approach of writing references + source files to a file and using that as an additional input, so that we can catch the "compile *.cs" + "delete something.cs" + build (and actually re-invoke the compiler)?

@rainersigwald I think the general strategy is OK, but you'll need much more than just the references + source files to guarantee deterministic recompilation. @jaredpar Has the list of inputs for the compiler that need to be considered.
Regarding specifically adding files, have you considered looking at the last-modified timestamp of the directories in the glob? That may be simpler if you only care about adding/removing source files.

Yeah, this is not a complete did-anything-change implementation, but it addresses a problem that will be more prevalent with the new dotnet SDK templates' use of wildcarding (because you can delete a file without changing the project file if it's not individually listed). The existing did-a-project-file-change check is the main "miscellaneous changes" catch.

@dotnet-bot test Windows_NT Build for Desktop please

@dotnet-bot test Windows_NT Build for Desktop please


link error with PETSc

Hi ;)
I just upgraded PETSc from 3.13 to 3.15 and tried to link with MFEM 4.2 . The following errors appeared after the input:
make parallel  MFEM_USE_PETSC=YES MFEM_USE_MPI=YES

The configure options of PETSc are :
--download-f2cblaslapack --with-hypre-dir=../hypre-2.20.0/src/hypre --with-fc=0 --with-shared-libraries=0 --with-cc=mpicc --with-cxx=mpicxx
Can anyone advise what's wrong with the compilation ? It works well with the previous PETSc 3.13, which was deleted for the upgrade to 3.15.
Thanks !
Bright

Bright, can you try using the master branch of mfem?

You can also try this patch: https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/mfem/mfem-4.2-petsc-3.15.0.patch.

There was a change in PETSc API since the latest MFEM release. You should use MFEM's master  to use PETSc 3.15 or fix the calls yourself (basic)

The compilation and build is successful from the master branch.
Thanks for the advices !
Bright

Hi
Since the upgrade to PETSc-3.15, the error was reported by PetscNonlinearSolver for the problem with 70292 unknowns (Nedelec), which was not encountered before the upgrade.  Any ideas why this happens with the new PETSc ? Thanks !

Hi @brightzhang91. This is strange, the stack trace seems corrupted. Can you provide a reproducer?

Hi @brightzhang91. This is strange, the stack trace seems corrupted. Can you provide a reproducer?

Thanks stefanozampini  for your support !
Please see the MFEM code and the mesh file produced with Gmsh.
The Out of memory error was encountered in the serial run, and non-convergence was encountered in the parallel run.
https://github.com/brightzhang91/EM-solvers/blob/main/magnetodynamic_inductive.cpp
https://github.com/brightzhang91/EM-solvers/blob/main/torus2.msh
Thanks very much ;)
Bright

Can you try using https://github.com/mfem/mfem/commit/30da55f38fdd9fcd3686de6b826b98c619629ec8?
I have run your code using the patch in https://github.com/mfem/mfem/commit/30da55f38fdd9fcd3686de6b826b98c619629ec8 and the error goes away. I have opened an issue in PETSc https://gitlab.com/petsc/petsc/-/issues/940.
However, if I run sequentially, I'm getting software errors from failing line search though, not sure about that.
[szampini@localhost petsc]$ cat rc_ex10p_jfnk
# matrix-free Jacobian action, preconditioner constructed using PetscPreconditionerFactory
-snes_linesearch_monitor
-snes_converged_reason
-snes_monitor
-snes_mf_operator
-ksp_type minres
-jfnk_pc_type jacobi

[szampini@localhost petsc]$ mpiexec -n 1 ./ex1p --petscopts rc_ex10p_jfnk
Options used:
   --mesh ../torus2.msh
   --petscopts rc_ex10p_jfnk
Number of local H(Curl) unknowns: 70292
Number of global H(Div) unknowns: 508791
Creating Magnet Solver
Number of domains 2
Number of boundaries 4
essential true dofs num 11172
Creating Coefficients
Creating bilinear objects
Hcurl true size every process70292
Hform started
Hform constructed
H form Operator created
comm is<PHONE_NUMBER>
Start initialization Magnet solver.
Number of H(Curl) unknowns: 70292
Number of H(Div)  unknowns: 508791
H field initialized
Initialization ODE solver finished.
Writing VisIt files ... done.
Time t= 0.2
H norm 0
H_rhs norm0
BC values initialized
PETSC
Mult start
nonlinear Mult updated
residual norm 0
 Mult finished
  0 SNES Function norm 0.000000000000e+00
 Jacobain started
Jacobian finished
 use PCfactory
      Line search: Initial direction and size is 0
Mult startlinesearch
nonlinear Mult updated
residual norm 0.000386108
 Mult finished
Nonlinear  solve did not converge due to DIVERGED_LINE_SEARCH iterations 0

Verification failed: (petsc_solver->GetConverged()) is false:
 --> Newton solver did not converge.
 ... in function: virtual void MagnetodynamicSolver::ImplicitSolve(double, const mfem::Vector&, mfem::Vector&)
 ... in file: /home/szampini/Devel/petsc/arch-h2opus/externalpackages/git.mfem/examples/petsc/ex1p.cpp:635

application called MPI_Abort(MPI_COMM_WORLD, 1) - process 0

In parallel instead
[szampini@localhost petsc]$ mpiexec -n 2 ./ex1p --petscopts rc_ex10p_jfnk
Options used:
   --mesh ../torus2.msh
   --petscopts rc_ex10p_jfnk
METIS Error: A contiguous partition is requested for a non-contiguous input graph.

Mesh::GeneratePartitioning:  error in METIS_PartGraphKway!
application called MPI_Abort(MPI_COMM_WORLD, 1) - process 0

Can you try using 30da55f?
I have run your code using the patch in 30da55f and the error goes away. I have opened an issue in PETSc https://gitlab.com/petsc/petsc/-/issues/940.

Thanks Stefano for this patch !
I run in parallel with this patch and the new rc_ex10p_jfnk, the following messages disappeared :
==14619== Warning: set address range perms: large range [0x25ecaa028, 0x484374bac) (noaccess)
==14616== Warning: set address range perms: large range [0x2a919c028, 0x518d5894c) (noaccess)
==14617== Warning: set address range perms: large range [0x283a94028, 0x4cdf48b2c) (noaccess)
==14618== Warning: set address range perms: large range [0x28df38028, 0x4e289070c) (noaccess)

However convergence is still not achieved, with the message:
Line search: Initial direction and size is 0
and
Nonlinear  solve did not converge due to DIVERGED_LINE_SEARCH iterations 0
Why does the Newton solver report non-convergence so early, without doing more iterations ? Parallel run is more important to me so I can abandon serial run if parallel convergence can be achieved.
Thanks ;)
Bright

I don't know why it is failing, you should double-check your code to find the cause. Was it running with PETSc 3.14? and with 3.13?
Can you use the same MFEM branch and use an older version of PETSc to confirm?

I don't know why it is failing, you should double-check your code to find the cause. Was it running with PETSc 3.14? and with 3.13?
Can you use the same MFEM branch and use an older version of PETSc to confirm?

I just changed PETSc 3.15 to 3.14 and ran with the same branch, it shows the same non-convergence problem in the parallel run.  I'm confused if this early termination caused by non-convergence (without iterations) is due to problems in my code or some other problems?
The MFEM examples (such as ex10p) work well.
Thanks !
Bright

Again, I don't know what to answer since I have not written the code. Here is what I would do:

use MFEM 4.2 and PETSc 3.13 . Does it work?
use MFEM 4.2 and PETSc 3.14 . Does it work?
use the new branch and PETSc 3.14. Does it work? (answer no)
use the new branch and PETSc 3.15. Does it work? (answer no)

Hi Stefano
After the testing I think the problem is within my code, as neither of the four options work without the non-convergence problem.
Thanks very much for your support ! It'll be great if you can help think of  some possible causes for the error:
Nonlinear solve did not converge due to DIVERGED_LINE_SEARCH iterations 0
Thanks ;)
Bright

The only help I can give you is to wish you good luck


[BUG] main branch does not build

Describe the bug
When I checkout main and run cargo build, it fails on a version requirement mismatch for wasmbus-rpc. Screenshot below.
To Reproduce
Steps to reproduce the behavior:

Sync and Checkout main
Run cargo build
Observe error.

Expected behavior
For the build to complete successfully.
Screenshots

**Environment (please complete the following information) **

OS: macOS
Shell zsh
wash Version v0.12.0-alpha.1

Additional context
I'm assuming this is from the version upgrades in this PR, however I haven't been able to easily figure out the issue as the other wasmcloud crates all look up to date, and wasmbus-rpc v0.9 (and 0.9.1, 0.9.2, etc) are present on crates.io.
Also tried nuking my .cargo/registry with no luck.

Well, nuking my entire .cargo and reinstalling Rust from scratch fixed it. Never seen that happen with Rust/cargo before!


feat: add support for kotlin

Adds support for Kotlin, via sdkman, such that Kotlin install should only be attempted when it is known that the Java install was successful.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 18 (100.0%)  changed or added relevant lines in 2 files are covered.
35 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.1%) to 78.395%

Files with Coverage Reduction
New Missed Lines
%

tool.js
3
79.52%

golang.js
10
58.33%

node.js
10
74.26%

python.js
12
13.89%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
450

Relevant Lines:
557

💛  - Coveralls

@dgschwindturo going to close this since it has been opened for a while. We can always reopen if still relevant


PICO 4 Hand tracking and Passthrough

Hi. How to get passthrough and hand tracking working on pico 4?  I only see meta support in the settings

Hey! It will work on the Pico 4 just the same.
I am not sure if you also have to set the options on the Meta XR Features for a Pico build, but as long as your project is properly configured for OpenXR with handtracking enabled, and your Pico 4 have handtracking also enabled then it will work the same as the Meta Quest. Same with passthrought.

@BastiaanOlij Are there manifest tags / permissions that need to be added for Pico devices?

@m4gr3d I don't believe so, if I recall correctly only extra manifest entries were needed for eye tracking. Though it was Dirk who did any changes needed to make Pico work way back when so it may be good to compare the old loaders plugin to see if we lost any in the refactor.
Do note that for pass through, @dsnopek changes were merged in master last week, while the changes in the vendor plugin are still being finalised, and passthrough will definitely not work on master with the 2.0.3 release.

Sounds good! Closing the issue then.
@LakoMoor Feel free to reopen if you run into issues getting it to work.


Allow changing mode in navigationOptions for dynamic modal

I need dynamic modals in my project and couldn't wait for https://github.com/react-community/react-navigation/pull/1378. It looked simple enough to implement, so I went ahead with it :)
I've got navigation animations working, but I'm having a heck of a time configuring the "back" animation.
Any idea where I can configure the navigator in such a way that I can influence the animation, and have per-screen navigationOptions available? As far as I can tell, isModal is currently defined in CardStackTransitioner here: https://github.com/react-community/react-navigation/blob/master/src/views/CardStack/CardStackTransitioner.js#L77, which seems to apply isModal to the navigator universally.

Turns out I was wrong, setting isModal in CardStackTransitioner doesn't do the trick either, so I have no idea where the back animation comes from if not there, I can't find any reference to it.

@JulianKingman Back animation seems to be a separate issue. Even without your changes it's behaviour is odd in "Modal Stack Example" - "Go to profile screen" is animated vertically, but back-animation is horizontal.
In your modified example back navigation starts to work as expected if you click "Go to a photos screen" one more deeper and then click "Go back".

Nope, I was wrong. In "Modal Stack Example" there is a nested navigator that causing unintuitive behaviour.
But the good news is I made it to work correctly during back navigation! Check this out:
https://github.com/procraft/react-navigation/commit/fa2a383fde51d76e0b05edee5b56d3c590b36a55#diff-95db94c88696779a7ac6a0fe1af87ebeR390

Brilliant, thanks @davojan! I added the fix to my PR.

Test thoroughly and describe how you tested it
I added examples to  the NavigationPlayground and tested a modal type screen in a card stack, and a card type screen in a modal
Add an example to the playground app that utilizes this new option
Yes, done (see SimpleStack and ModalStack for examples)
Take screenshots/videos of the behavior on both platforms
Here:

Write documentation
Done

@ericvicenti FYI, ready for review

@JulianKingman I guess you should fix linter errors reported by the circleci before they'll consider reviewing :)

Fixed.

Getting this error when trying to use this fork:

Working well for me, would be nice to see it merged. Thanks for the contribution, @JulianKingman!

Looks like there are some conflicts, can you fix them? I'll try to check the PR asap

Any updates on this? It seems the conflicts are minimal (documentation and dependencies), so I guess it shouldn't be too hard to update and approve it?

id also love to get this merged

So I fixed the conflicts, but the examples appear to be broken, and I didn't want to go in and change everything to get them working.

Ok, thanks. I'll take a look at it this weekend, but I'm not sure when I'll merge it. We're waiting on a big PR to fix a lot of the codebase and I'd prefer to land that one before this; we'll see.

This PR touches a few parts, so smart move, thanks!

Are you still attempting to tackle this @kelset?

@antgly as I mentioned in my previous comment, we first had to merge some huge PRs (that become beta.16) before thinking of merging this. We are now tackling a couple issues related to the new version.
That said I won't review this personally but it's in a shortlist of PRs we are trying to review & merge.

Could this be merged ? how can I help ?
Thnx

@rborn

Could this be merged ?
No, at the moment there are some conflicts that must be resolved.

how can I help ?
You can add your review, which will surely help us.

@kelset am I blind or the reported conflicting  files don't really have conflicts?

@rborn first off thanks for the review.

@Andreyco I think yes, that's the idea. This PR would simplify a lot the navigation :).
@JulianKingman correct?

Correct. This PR allows a mode option in navigationOptions, so it can be set at the router or route level.

@JulianKingman lovely, could you have a look at the review and fix the conflicts, and the maybe we can bribe @kelset to merge it? 😋

i like this

One question here... Is it possible to override mode for screen when it is pushed?
Imagine situation where you have, e.g, Profile screen. In one case, you want to push it as card (from right to left), in another case you need modal.
Is something like this possible?
props.navigation.navigate('ProfileScreen', { mode: 'modal' })

@Andreyco maybe you can use it in navigationOptions in Profile component

@JulianKingman could you update your branch to latest master?

maybe you can use it in navigationOptions in Profile component

If I am not mistaken, unless nav options are not passed at "push", they are could be consider as "static" a have to be defined prior to "push".
In my opinion, how is screen presented could/should be defined dynamically. It's other navigation options (title, buttons, ...) could be defined upfront (as is now)

@JulianKingman good job.
Are you having any issues to update this branch?

Codecov Report

Merging #2308 into master will increase coverage by 0.07%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master    #2308      +/-   ##
==========================================
+ Coverage   72.75%   72.83%   +0.07%
==========================================
  Files          53       53
  Lines        1659     1671      +12
  Branches      435      439       +4
==========================================
+ Hits         1207     1217      +10
- Misses        357      359       +2
  Partials       95       95

Impacted Files
Coverage Δ

src/routers/createConfigGetter.js
96.42% <ø> (ø)
:arrow_up:

src/TypeDefinition.js
0% <ø> (ø)
:arrow_up:

src/views/CardStack/CardStack.js
44.61% <100%> (+2.21%)
:arrow_up:

src/views/CardStack/CardStackTransitioner.js
81.25% <75%> (-7.64%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7141f66...ecd0eef. Read the comment docs.

@spencercarli @stereodenis @Andreyco @kelset the branch is now updated.
Can you review it again?

I think @ericvicenti should be the one reviewing this because we are undergoing some massive changes so I'm not sure this will be needed

we are undergoing some massive changes

is that documented somewhere, this makes me worried.

You can check the commits on master. We are not yet ready release a new version / post the release notes because we are still changing stuff, but yeah PR section & commits in master are the best way to be up-to-date if you don't want to wait for next release.

And yes, as @kelset  mentioned, we do have some big changes happening in this area. It should make features like this easier to add, moving forward!
See the suggested changes here: https://github.com/react-navigation/react-navigation/pull/3392
and the RFC here: https://github.com/react-navigation/rfcs/blob/master/text/0002-navigator-view-api.md
@raarts , we are ramping up support, it shouldn't concern you! Feel free to follow along with progress on the issues and PRs in this repo, and by keeping an eye on the RFCs repo: https://github.com/react-navigation/rfcs

My bad for the intrusion, but is this still in consideration to merge in or similar future solution? I need this bad.

I agree with @ericvicenti's assessment here, I'm not sure that this is the way we want to go for supporting modals. It may be, but I'd like to discuss further and have a proper RFC for this as it's a really key piece of the ergonomics of a navigation library (that we have up until now not provided a well-defined and supported path for, aside from creating a modal stack navigator). Please see this RFC placeholder issue: https://github.com/react-navigation/rfcs/issues/15 -- if you want to take a stab at designing a solution to this, let's discuss there and we can take it into a formal RFC. Thank you @JulianKingman for this PR and creating good discussion around this, and sorry to everyone who has to continue to use a fork to support this feature!


Add structured metadata (JSON-LD) support

Nice simple theme. You should consider adding structured JSON-LD metadata to make it easier for search bots to parse post content.

See the source code of one of my blog posts
See the structured metadata for this post in Google's testing tool
See the source code in my theme for how to implement this

Thanks for your advise! I will takes a litte time to implement this.


Implement recycle protocol

By recycling a channel, a new funding transaction is pushed on-chain,
spending the previous funding transaction.
In this state, the protocol has little use but the next step would be to
add custom inputs and outputs to this recycle transaction to allow
recharging or withdrawing bitcoin from the channel while only spending
the fees of one transaction.
This will be probably be renamed to rebalance or splicing once said
features are done.

This will be probably be renamed to rebalance or splicing once said
features are done.

How about calling it upcycling 😬?

This will be probably be renamed to rebalance or splicing once said
features are done.

How about calling it upcycling 😬?

We'll change the terminology to splicing :)

Nicely done. My only concern is that we have added too much functionality to the FundingTransaction to accommodate for this edge case of "recycling" a channel.
In particular a funding transaction is meant to be signed by the users' wallets, which is why we originally didn't provide a way to compute the digest, sign using a private key or add signatures to the transaction body.
I think it would be best to model this new type of transaction which originates from an already open channel as a separate type at first.

I'll fix that in the second to next PR.

bors r+
Comments will be taken in the follow-up PR


Travisci

I think it's configured...but there's four travis checks and I only need one.  Fixing later.


Add type property to generated action creator

This comes in handy to have a singular representation of an action, whether using the function for dispatching or the type for reducers/sagas/etc.

Duplicated with #32, but imo not as simple as #32. I will close this PR, sorry.

While #32 is a nice solution, it doesn't cover something like redux-saga's take/takeEvery/takeLatest/etc.

Will this PR cover these things? I haven't used redux-saga yet, sorry. I more detailed explanation would be helpful for me to understand how this PR is different to #32.

The basic idea is to have access to the action type string accessible. In the case of redux-saga actions can be intercepted by the type string. http://yelouafi.github.io/redux-saga/docs/api/index.html#takepattern
Originally I had this as a constants file but especially with #32 it's becoming very redundant to have a file with type constants and another file with actions declared with redux-actions when basically the latter can be fully replaced without the use of an extra constants file.


Added HTML Markup/CSS

Nice work! Design & implementation. Thanks for fixing the GigaTask also :D. One little thing related to process: I'd put these two changes in two separate commits if not PRs. They are unrelated and you might want to revert one while keeping the other in future. Bump me a msg if you want to discuss it.


DOC: Visual description of each symbol

A written description of each symbol in the README table could be helpful for training and memory purposes.
I wrote this; please feel free to reuse none or any of it without attribution:

Each of the symbols are drawn within a triangle pointing up:

Immediate Help Needed (orange; downward triangle \n SOS),
Shelter Needed (cyan; like a guy standing in a tall pentagon without a floor),
OK: No Help Needed (green; upward triangle \n OK),
First Aid Kit Needed (yellow; briefcase with a first aid cross),
Water Needed (blue; rain droplet),
Area with Children in Need (lilac; baby looking thing with a diaper on),
Food Needed (red; pan with wheat drawn above it),
Area with Elderly in Need (purple; person with a cane)

Thanks for the contribution @westurner! I've updated the README and listed you as a contributor.

Thanks!


[flutter_plugin_tools] Auto-retry failed FTL tests

Currently the flake situation for Firebase Test Lab tests is very bad,
and the task running those tests are some of the slowest tasks in the
CI. Re-running failed tests is slow, manual work that is signficantly
affecting productivity.
There are plans to actually address the flake in the short-to-medium
term, but in the immediate term this will improve the CI situation, as
well as reducing the drag on engineering time that could be spent on the
root causes.
Part of https://github.com/flutter/flutter/issues/95063
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

The tests failed after second re-try. Great validation to see if this PR works lol

The tests failed after second re-try. Great validation to see if this PR works lol

😭
Maybe we'll need to set this to three 😐  I want to try two for a while though since I'm okay with continuing to be reminded that there's a flake problem as long as it's not torturous like it has been recently.

Landing on red since in theory this will help with the things that are currently red. (In practice, I'm not sure how much it's actually going to help given that it seems like the timeouts are happening twice quite frequently :( )


Allow Kotlin-only activities

In the past, all Android docs had at least Java code snippets and examples so we required the java prop in ContextlessAndroidActivityToggle. In most future releases, all Android docs will have Kotlin snippets (and will likely not have Java snippets).
How to test
A copy of this component is used on the cmcg-adding-nav-1.0-examples branch in /android-docs.
QA checklist

[ ] No errors logged to console.
[ ] Accessibility score in Chrome DevTools Audit/Lighthouse is 100% with Lighthouse version: #.#.#.
[ ] Component is accessible at mobile-size viewport.
[ ] Component is accessible at tablet-size viewport.
[ ] Component is accessible at laptop-size viewport.
[ ] Component is accessible at big-monitor-size viewport.
[ ] Create a PR in a site repo, copy the component, and test it. Push to staging and let the reviewer know they can also test the component there.

Open the test cases app locally on:

[ ] Chrome, no errors logged to console.
[ ] Firefox, no errors logged to console.
[ ] Safari, no errors logged to console.
[ ] Edge, no errors logged to console.
[ ] IE11, no errors logged to console.
[ ] Mobile Safari, no errors logged to console.
[ ] Android Chrome, no errors logged to console.

@katydecorah I attempted to implement your suggestion in https://github.com/mapbox/dr-ui/pull/278#discussion_r427301422! Can you take another look?


Add alias for "git clone"

After doing extensive research (roughly 42 seconds), I have come up with a rather Christian alias for git clone, and that's git breadandfish. This refers to when Jesus fed the 5000 by "cloning" five 🍞 and two 🐟.
Other considerations:

git eve (God sort of cloned Adam? Okay not really, but you get the idea.)
That's all I have.

It's a WIP. 🐑

Also some formatting. Blame my editor. 🤷♂

Both of these are righteous! Merging now, might add eve as an alternative later. The Bible says nothing about multiple aliases for the same Git command being a bad thing.

🕺


Inconsistent events with createFileActivityStream

Operation System: MacOS Sierra 10.12.3
Beaker Version: Tested on both 0.7 and master
I'm working on a project which makes lots of little writes to a DatArchive and almost always publishes/commits them immediately (it's a collaborative text editor - hope to have something to show soon!). To "confirm" when these writes have been propagated to the dat, I've been using DatArchive.createFileActivityStream() to listen for changes (this unifies some logic for clients which pull changes locally vs. those that pull them across the network).
Because I'm in development, there are often unrelated file changes in the dat which makes it a "staging" dat (until the next write is committed). Tracing some of the logic of how createFileActivityStream is implemented for staging dats, under the hood it looks like it feeds from a stream wrapped around an event emitter, which is triggered (ultimately) by recursive-watch, which uses an FSWatcher. What I'm seeing, though, is that under some circumstances (often it's when I'm creating a createFileActivityStream on load, in multiple tabs, and reloading one of the tabs during development) the staging dat watcher will stop firing change events. I'm not honestly sure why — there may be some limit to file watchers for a path that I'm unaware of? Maybe it's unrelated to the watcher(s), and has to do with how these streams are tracked across tabs?
At any rate, what I'm curious about: right now, the createActivityStream function will always use the local fs.watcher for a staging dat. Could that be made configurable? e.g. if I'm only concerned with the changes that have been published, even for a local/staging dat, would there be any merit in some kind of options hash ({ watchStaging: true}) where you could configure whether or not you care about staging updates?
I'd be happy to mock something like this up in a PR if this seems like a worthwhile direction, but curious to hear what you think either way 😄  & thanks for all your hard work on Beaker! It's really cool!

@saranrapjs so this is all really good analysis and that's a good suggestion. But we actually have removed the staging area from dats in version 0.8 -- mainly because it was complex to work with, and didn't really give us the value we wanted.
For making applications or sites, we're adding a "workspace" concept, which has a similar flow, but isn't integrated into the entire Dat Web API. So, no more commit() method, and no more changes to the workspace causing change events to be emitted.
Closing. Feel free to continue conversation here.


💡[FEATURE]: Improving about us section

Is your feature request related to a problem? Please describe.
About us section is not looking attractive.
Describe the solution you'd like
I want to make it look attractive by adding some CSS features.
Describe alternatives you've considered
Additional context
I am SSOC'24 contributor.
Please assign me this issue.

I can change the about us section into a better version ,can you assign me this issue under SSOC'24

Hey, hope you're doing great! As an GSSoC contributor, I'm keen on ramping up my involvement for GSSoC'24. Could you assign this issue to me? I'm excited to continue contributing to the project. Thanks a bunch!!


Add mermaid support for our mdbook

Issue Addressed
Just browsing our book and noticed we don't have mermaid support.
This adds support for mermaid diagrams, however I've had to mess with the workflow and I've not tested the new build.
This works locally, but it remains to be seen if this holds up in the CI
Clone of #53

Nope, thanks for the catch.
Fixed


Java post transformations in AutoRest

Issue
Some AutoRest.Java customers are not happy with the output Java code and want to make changes. Today they are doing the transformations in README in TypeScript and the experience is less than ideal.
Why not...
Q: Fix the generator to generate what they want?
A: Some of the fixes they do are context specific, and require human input. AutoRest.Java v4 doesn't yet have AI built in. In some cases where our customers prefer one style over another, we simply can't make everyone happy out of the box.
Q: Add dials and knobs (commandline arguments) to control output behavior?
A: Some common requests or changes that require lots of transformations should absolutely be done by us and the users should be handed with a simple switch. But some are simple few-line changes that if added to AutoRest.Java, we will have a hundred commandline arguments. This not only makes many options less discoverable at least, it also gets AutoRest.Java contributor lost among the available features.
Q: Add extensions to Swagger?
A: For features that apply to other languages, yes, we will propose additions to current extensions or features in modeler four. But this proposal is focused on Java specific output changes.
Q: Change output code directly after generation?
A: As a contributor to AutoRest, I'm happy to take this solution :) But my conscience tells me to come up with a solution.
Q: Write a convenience layer wrapping the output code?
A: This is a viable solution and has been working well for some services. But we've seen some big models that require only one small change, that are deplicating lots of code. We want to offer a way to easily find the place to fix the small issue in the generated code.
Q: Learn how to write TypeScript transformations in README?
A: It's a steep learning curve for many Java developers who just want to generate some Java code and move on with their life. Also, the find-replace way to transform is not very definitive. We intend to replace it with a more definitive way to locate the code to modify and easily modify it.
Proposal
A post processor in the generation pipeline
Today we have a pipeline that generates Java code:
-> AutoRest Core (reads swagger)
-> ...
-> modeler four (outputs code model)
-> preprocessor (outputs modified code model)
-> javagen (outputs Java files)

We will add a step to allow changes to the final Java files. But text operations on the Java files directly are prune to errors and gives up lots of convenience in syntax processing and style processing in javagen. Thus the operations will be done on the DSL describing the files rather than the output files.
-> AutoRest Core (reads swagger)
-> ...
-> modeler four (outputs code model)
-> preprocessor (outputs modified code model)
-> javagen (outputs Java DSL)
-> postprocessor (outputs Java DSL)
-> javawriter (outputs Java files)

An object based DSL
Luckly we already have a set of DSL for Java files in our code base. They are currently String based and it should be a simple coversion to make them object based with toString() method handling the conversion to String. This way we can still preview the output in the Debug window.
The structure looks like this today:
JavaLibrary
|- JavaPackage
  |- JavaFile
    |- JavaInterface
      |- JavaMethod
      |- JavaMethod
      ...
  |- JavaFile
    |- JavaClass
      |- JavaMemberVariable
      |- JavaMemberVariable
      |- JavaMethod
          |- JavaIfBlock
          |- JavaElseBlock
          ...
      |- JavaMethod
      ...
|- JavaPackage
  |- JavaFile
    |- JavaEnum
  ...

An example:
FooService
|- com.azure.foo
  |- FooClient.java
    |- FooClient
      |- createFoo()
      |- deleteFoo()
      ...
  |- FooClientBuilder.java
    |- FooClientBuilder
      |- HttpPipeline httpPipeline
      |- String connectionString
      |- httpPipeline(HttpPipeline)
      |- build()
        |- if (connectionString != null) { ... }
        |- else { ... }
      ...
|- com.azure.foo.models
  |- FooType.java
    |- FooType
      |- TYPE_A
      |- TYPE_B
      ...
  ...

Users will have access to the top level packages and make modifications on the DSL objects.
Modifying the DSL in the post processor
Users don't have to learn how to add a plugin into the AutoRest pipeline. AutoRest Java will create a post processing pipeline, which will accept an implementation of JavaModelProcessor
public interface JavaModelProcessor {
    public JavaLibrary process(JavaLibrary javaLibrary);
}

AutoRest Java will load the implementation class at runtime and process in our post processor.
An example usage
public class SearchServiceProcessor {
    public JavaLibrary process(JavaLibrary javaLibrary) {
        JavaPackage models = javaLibrary.getPackage("com.azure.search.models");
        JavaClass document = models.getFile("Document.java").getJavaClass();
        JavaMethod hasValueGetter = document.getMethod("isHasValue");
        document.publicMethod(hasValueGetter.visibility, hasValueGetter.returnType, "hasValue", hasValueGetter.parameters, hasValueGetter.methodBlock());
        document.removeMethod(hasValueGetter);
    }
}

Tasks

Convert the current DSLs to be Object based, adding necessary methods to interact with the models
Add post processor module and dynamically load JavaModelProcessor implementation class

My 2 cents:
Instead of a customized document object, will it help to use more well-known utils like JavacParser (java11) https://www.javadoc.io/doc/org.kohsuke.sorcerer/sorcerer-javac/latest/com/sun/tools/javac/parser/JavacParser.html, or JavaParser https://github.com/javaparser/javaparser

Providing the Java files is probably easier but it will push users back to literal string find and replaces. It probably will work just fine but I'm trying to see if there are options that are more definitive and gives users access to DOMs directly.
The customized document object is actually just modified versions of what we have today. We are not really doing any parsing and I don't think most of our users are familiar with any well-known parsers out there anyways.
We can start with a literal string find-and-replace plugin, since that's easier.

Agree. We could start with an easier file content, see what user will do to it (simply do regex replacement, or more complex as parse - modify - output), and improve on their feedback.
Let's check input from Srikanta @srnagar as well.

Also is there any user proposal to add another plug-able point before preprocessor? If we really need to remove a method, there should be the best place. After java class generated, they need to do it in multiple places as client method, proxy method, etc.
Personally I do not have this kind of remove/add method case. The current case I might use a plugin before preprocessor is due to m4 bug (it mistakenly flattened a type to nothing in parameter).
My case as postprocessor would be due to service bug or core bug. I will need to add a few @JsonInclude(content = JsonInclude.Include.ALWAYS) to certain Map property since service will respond with error if that property is missing.

Customizations support added.


Horizontal matrix aggregation

It should be possible to aggregate single rows of a matrix to a single number (min, max, avg, median, etc.).

I will replace that with same as in lineup as in sketch

Can I test this state? In which branch do I see it? There is no link to any commit.

You can switch to branch matrix. Sorry, I forgot to link the commit to this issue.

OK.

Current State: Sketch Below:
Points of discussion:

Should the other stratifiers and the support view of matrices be removed or keep as it is ?

If the matrix is converted to vector. Currently, it is stacked at the bottom of the filter list which also takes part in sorting.It is just the normal numerical column similar to other. It will be part of filter operation and sorting by changing its position which will also reflect on the table view.

If the vector is converted to matrix it is stacked at the bottom of the filter list and remove from sort hierarchy. This situation will be same as before we switch back to vector.

ad1: I think it should behave the same as in the case of rows. In other words - if you have a matrix stratified by continent, I would expect that after custom aggregation, it would end up with 3 columns of (average / etc.) values per each continent.
ad2&3: looks nice and quite easy to follow in my opinion, great job @bikramkawan

Strategy:
CM = Column Manager
Matrix to Vector Conversion:

Stratify  columns then choosing aggregate function and trigger  to the CM -> App

Convert Matrix Views in vector(V1, V2...) with aggregate function

Create independent columns and filters accordingly for each vector(V1, V2...)

Add all the column stratifiers of the original matrix as a flag to V1, V2...

update main view and support view

Vector to Matrix Conversion

Choose conversion icon and trigger to the CM -> App

Get matrix data from Number Columns i.e. V1, V2...

Create independent Matrix Columns (M1, M2...) and filters accordingly for each vector(V1, V2...)

Initially, there will be no column st ratifiers i.e. empty columns in support view of the newly created matrix.

Add all the column stratifiers of the original matrix as a flag to M1, M2...

Trigger SupportView to restore the previous column stratifiers on the top of matrix

update main view and support view

I am not sure if splitting it into threee different columns in this manner makes sense...I would vote more for something like this:
https://docs.google.com/presentation/d/1I7y-VKfG02UyAIlYT_ZsklegRdiLz4rrrX5WiqO-hP0/edit#slide=id.g1b9192e035_0_103   (slides 39 up)

Works in principle. New issues will be filed for buggy behavior.


integrate with sockjs and my websocket

I have an chat application ,i using sockjs for connect to my websocket that implement by java spring websocket  framework. how can i use push.js and integrate with my websocket channel and show  new messages ?

Hi @azizkhani! Thanks for using the library! You have a couple options, actually. You could either stick a Push.create() call inside the code block that executes when the client receives a new message from the server, or you could push notifications from the server side when the client sends a message. This allows notifications to be shown even when the browser is closed and uses Firebase Messaging to do so, but of course you'll need the official Push FCM plugin and a Firebase account if you choose that route.


Addon Name

Addon Manifest URL
https://www.strem.io/s/movie/price-of-parenting-13271264
Addon Description
No response
Language of Content
French (fr-FR)
Choose Labels

[ ] anime
[ ] asian drama
[X] bollywood
[ ] cartoons
[ ] debrid support
[ ] http streams
[ ] live tv
[ ] metadata
[ ] misc
[X] movies
[ ] music
[ ] nsfw
[ ] podcasts
[ ] radios
[ ] subtitles
[ ] torrents
[ ] tv shows
[ ] video games

i don't know what this is, but it's not an addon, closing it


redbox does not seems to works correctly on client

If you call an undefined variable for example when you switch to a new page, redbox does not handle things. I only got error in browser console.

Work for me on syntax error

this is not the runtime redbox (that is red, not pink). I got a case where something was undefined (this.contexte.something) and did not get the real redbox.

Will try to reproduce like you said

Got it. Redbox won't show up if eslint catch the error first. Webpack failed before babel transform

Cannot reproduce with my initial description.


Use appropriate Python version classifier in package

https://pypi.org/classifiers/ lists available classifiers for setup.py
With no version classifier, it's easy to accidentally install this into a Python 2, or Python 3.4 environment, where it does not work.
Due to use of type hinting this package requires python 3.6 or greater, and that should be annotated.

Got it. I'll add those when I have a spare moment. As far as the type hints go, I'll probably move all type hints over to a stub file so as not to require a python version that supports them.

The Python version classifiers will be in the next release.


Allow Play Across Internet

Big feature:

need server
need TCP
global naming etc. red pig in Palo Alto
server side computation? at minimum back to alternating computation

may be try supabase.com real-time subscription? low traffic personal project is free.
https://supabase.com/pricing


fix return value of nagle_enable

The old implementation returns the wrong value (ACK delay duration) and doesn't describe if the Nagle algorithm is enabled or not.

Thank you!
bors r+


Expand only on pressing accessory view

Great library. Is there a way to expand only on pressing accessory view on the cell?

Well I guess I'll have to use delegate from table view cell class.

@eshwartm
how did you solve this?
I also want to use + & - buttons for expand/collapse. I want to use didselect for selection
Thank you,

@av089

Make a UITableViewCell subclass for your cell.
Make a protocol having a function expandCollapseCell.
Set the delegate to the main Tree View class (let's call it TreeViewController).
When the arrow/+/- button is pressed, toggle expand/collapse state in the cell
Call the protocol's function expandCollapseCell to the main TreeViewController.
In that delegate function implementation, use the library's in-built expandRowForItem or collapseRowForItem.


Add spearbit deal

#266
#265
#264  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jvmi7 and the rest of your teammates on  Graphite


Update glide vendor script

With the latest version of glide and glide-vc, running the glide-update script resulted in an unbuildable tree because glide-vc deleted too much stuff (such as actool).
Adding the --use-lock-file flag made it work correctly on my machine (only picking up one new file, included as well).
cc @sgotti

I assume others have been updating things with this script and its been working for them (@lucab), so I'd also be interested in knowing how it's working for you and if there's a trick to it, I'd be happy to switch to documentation instead of this.

@euank thanks a lot, I should have catched this earlier here actually, my bad!!
This was introduced in https://github.com/sgotti/glide-vc/pull/21, and probably also the reason, why we didn't see it as our local binaries are probably older than this. There was a pretty long discussion about the changed semantics on how to prune the vendor directory.
TLDR for rkt: since we are not only vendoring compile-time libraries, but also additionally declare binaries (like actool) to be vendored in the glide.yaml file, we have to provide this option.

And this LGTM to me :+1:


feat: subheader, divider & badges

This extends the menu according to the new figma designs.

@johnsBeharry what do you think?

dammmmmmn. looking sexy!


Difference ratio calculated incorrectly

Hey! Thanks for this repo, it pointed me in the direction of PIL which I could use to solve a similar sort of problem :smile:.
One thing I noticed was that the difference was calculated based on a factor of 100 as the maximum difference:
https://github.com/nicolashahn/diffimg/blob/5a5293dd5fb8d17f32bb3167e48b8cfa5165966e/diffimg/__init__.py#L46-L51
But for normal RGB the values are in the range 0-255, so the difference could be up to 255. You can repro this with a script that generates black and white images and diffs them (which should print 1.0):
>>> import diffimg
>>> import PIL
>>> PIL.Image.new('RGB', (10,10), (0,0,0)).save('a.png')
>>> PIL.Image.new('RGB', (10,10), (255,255,255)).save('b.png')
>>> diffimg.diff('a.png', 'b.png')
2.55

Ooof, that's a pretty bad oversight on my part. I'll fix this ASAP, thanks for bringing it to my attention.

Version 0.2.0 has this change - let me know if you notice anything else.


electron.d.ts Property is incomplete

Property is incomplete, for example: minimizable, maximizable etc.

Please log type issues with the type definition. Electron does not live here.


[composer] Command-Palette-> Fold levels are functioning the same way like folding line by line

Description:
Issue

Right click on source-> Command-Palette-> Fold levels (fold level1 to fold level 9) seems folding line by line only (functioning like same way).
Sort keys given is not working. I could use Ctrl+Shift +n +K (n => 1-9)

Observed
command-palette-> Fold : folding entire code from where the cursor
command-palette-> Fold All :  folding entire code from where the cursor

Affected Versions:
ballerina-tools-0.970.1-SNAPSHOT
OS, DB, other environment details and versions:
Ubuntu 15.10
Firefox 59.0.2

Composer is discontinued hence closing the issue.


Support for wasmJs & ios targets

Hi Sean,
I started using your library in my app. And I must say it is great!!
The only thing I am really missing currently is the wasmJs and ios* targets.
Looking at your build files and version catalogue, I see nothing that would prevent it.
Could you please add those targets?

I can certainly add the wasmJs target. iOS targets need to be built on a Mac, which I don't use for development. I could use GH actions to build the releases. This is a bit more time than I'd like to invest at the moment in supporting a target that I am not currently using. If you create a PR that adds the targets and a GH action to publish, I'll certainly accept it. Currently to publish I just run ./gradlew publishAndReleaseToMavenCentral.

I can certainly add the wasmJs target. iOS targets need to be built on a Mac, which I don't use for development. I could use GH actions to build the releases. This is a bit more time than I'd like to invest at the moment in supporting a target that I am not currently using.

That's fair!
I would be very happy with the wasmJs target already! :smile:

If you create a PR that adds the targets and a GH action to publish, I'll certainly accept it. Currently to publish I just run ./gradlew publishAndReleaseToMavenCentral.

I'll look into it. Thank you!

Thanks to @eyedol, we have iOS support in 0.10.1.


Various asf.yaml updates

I browsed the asf.yaml docs, and found several new capabilities related to GitHub that I believe we should add:

protected_branches - our main branch should at least be protected from force-push
protected_tags - prevent deletion of release* tags
autolink_jira - make references to short-form SOLR JIRA issues in PRs clickable
collaborators - list of github user names to allow full PR edit karma

Also, I consider required_conversation_resolution, which will require all conversations to be resolved before merging is possible. I have seen too quick merges of looong PRs where the author missed an open conversation.


install instead of copy man pages

little enhancement : install the man pages (just like the binary) instead of copying it.

:+1:


Command line works perfectly! Any way to prevent deployment on error?

Hey @joostfarla -- Fantastic step forward on solving the ES6 use strict optimizer problem. Command line test works perfectly!
Related to Serverless optimizer and deployment issue,
ES2015 Deployed Code Crashes -- Optimizer not observing strict mode, is there any way to have this plugin cause serverless dash deploy to fail deployment if a syntax error is found?

It's on the roadmap! I want to implement some hooks which will auto-perform the linting before deployment.

:thumbsup:


Recommended way of adding thousands or even millions of items to a GtkTreeView

Got a worker that when finishes, sends a message with a huge vector of items, to be displayed in a GtkTreeView widget.
The widget is backed by a TreeStore model.
In the update function of the main window component of my program, I iterate through the list of those items and add them one by one to the TreeStore model using insert_with_values function.
Unfortunately, adding half a million of items to the TreeStore takes several tens of seconds (even in release mode).
Even worse, during that process, the UI gets locked and Ubuntu displays a message that the app became unresponsive.
What is the idiomatic way of dealing with this problem?

I tried splitting the message to smaller chunks, but to my surprise, that also blocks and the app becomes unresponsive until all items are added.

Ok, if I do a large enough sleep between adding chunks, then the UI does not lock up, but then adding items is very slow.
sender.output(AppMsg::ClearFileGroups);
for chunk in data.chunks(10) {
     sender.output(AppMsg::AddFileGroups(chunk.to_vec()));
     thread::sleep(Duration::from_millis(50));
}

You might find better answers for this question in the gtk-rs room: https://matrix.to/#/#rust:gnome.org
I'm not experienced enough with GTK's internals to help you with this.

Thanks, so it looks like subclassing a TreeStore is not an easy task, and generally not supported yet.
https://github.com/gtk-rs/gtk4-rs/pull/169
So, forget for a moment the fact that performance is not as good as I like, but focus more on the UI lockup issue.
If I got rid of that problem, I could release what I have and work on performance later.
I'm doing all the hard work on the worker thread and emitting chunks of data, each chunk in a separate message.
Then those messages are processed in the update function of my component like this:
 AppMsg::AddFileGroups(groups) => {
                for group in groups {
                    let hash_str = group.file_hash.to_string();
                    let file_len = group.file_len.0;
                    let group_row = self.file_groups.insert_with_values(
                        None,
                        None,
                        &[(0, &hash_str), (1, &file_len), (2, &false)],
                    );
                    ...

I thought that if each chunk is small enough, this would not block the main event loop of GTK. But apparently it does – it looks as if the messages emitted by the worker were processed first, before the other events, and they starve the main loop.
Is there any way to force processing of the other events on the main event loop, so that it would process everything pending before it gets to adding the next chunk of my data to the tree view?

Can you try to use the "change-prio" branch and set the priotity of the component to glib::PRIORITY_HIGH_IDLE ?
I think that should be enough to prioritize drawing over the components event loop.

So far I solved it the way that instead of worker pushing the chunks of data whenever they are ready, the worker just memorizes them in its field. Then the UI component asks for the next chunk, adds it to its TreeView, and when ready, asks for another chunk, and so on. This does not block the UI if chunks are small enough.
Unfortunately adding items to the TreeStore is embarassigly slow. I'm afraid I will need my own model but aaaargh, that's complex.


Fix Notification Registration

Fix Notification Registration
:recycle: Current situation & Problem

Firebase is doing method swizzling ... not great and breaks the notification registration.

https://firebase.google.com/docs/cloud-messaging/ios/client#method_swizzling_in

:gear: Release Notes

Disable method swizzling and fix notifications mechanism.

Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[x] I agree to follow the Code of Conduct and Contributing Guidelines.

@pauljohanneskraft @nriedman @Supereg I will create a PR in Spezi to add better diagnostics around this + we should set this flag in the template application. An other reason why swizzling is not a great idea.

What issues were the swizzeled methods causing?
It seems we can easily add the necessary infrastructure within SpeziFirebase using a NotificationTokenHandler that sets the deviceToken in Messaging.
Another example of a framework trying to do too much magic.

@Supereg The delegate methods in the Spezi subclass of the application delegate were never called. Therefore we ran into timeouts even on App Store and TestFlight builds.
Pretty sure this works well in a normal use case but they might not correctly dispatch a call to the actual implementation in a case where you have a subclass hierarchy as we have.
Agree; if someone needs to do this they can pass all these things to Firebase manually and it shouldn't be a blocker in any way or form. And TBH we don't want or should use any of the analytics functionality always so even better that it's not just grabbing data and tokens behind the scenes ...

For context, this seems to be the location where they create the selectors for the delegate methods: https://github.com/google/GoogleUtilities/blob/d6cf51c4617a34bbce94a25428051d1aa98c2e44/GoogleUtilities/AppDelegateSwizzler/GULAppDelegateSwizzler.m#L478-L488.
Might it make sense to report this as an issue to the GoogleUtilities project that their setup fails with certain class inheritances?
Thank you for the documentation changes in Spezi 🚀

Agree; we can report this to Google. I have made the unfortunate experience that their support, especially around Firebase, is non-responsive. But maybe creating an issue in the repo might lead to some better results, their engineers & technical team members seem to be responsive & competent.

Just reported it as https://github.com/firebase/firebase-ios-sdk/issues/13566. In my minimal reproducible example I found that it seemingly never calls the original delegate. So it is now even the inheritance we use that is the culprit. It seems this feature is just broken.

Thank you @Supereg!


Using a string variable in a require from a JSON file returns an error.

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
Able to pass a string into require
If the current behavior is a bug, please provide the steps to reproduce.

use a $http angular service to GET a JSON file.
reference a string value within that JSON file and assign it to a variable.
use require to require the string so it can be used to hash an image.
E.G: var test = './image.png'; $scope.image = require(test);
an error will appear: Error: Cannot find module "." at webpackMissingModule

What is the expected behavior?
To be able to load that image referance and hash the image on the html
If this is a feature request, what is motivation or use case for changing the behavior?
not a feature request
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
node - v7.7.2
webpack - 2.3.3
OS - OSX El Capitan

Hello, @Elliot-Evans-95 !
I tested it without angular, and it worked...
I use node on Win7, but I had similar error on mac, a week ago.
I think something crash with webpack on OSX...
I can't help for now, but I will try to find the problem, soon.
Goodbye!

same problem with webpack2 on mac
cont img = require('./xx.png')
error cannot find module "."

my config
    {
        oneOf: [
          {
            test: /\.(png|gif|jpg|jpeg|svg|woff|ttf|eot)$/,
            resourceQuery: /\?.*/,
            loader: 'url-loader'
          },
          {
            test: /\.(png|gif|jpg|jpeg|svg|woff|ttf|eot)$/,
            loader: 'file-loader',
            options: {
              name: '[path][name].[ext]'
            }
          }
        ]
      },

it‘s work fine on webpack1
anyone can help me ?


Directive input and options naming convention

One of the things that I think can be a source of confliction and non-readability in angular 1 is that attributes can be used as both directives (normally behavioural directives) and inputs for directives. The latter can be an isolated scope binding or something used like scope.$eval(attrs.someOptionsForFooDirective) inside some directive's link function.
So when you see something like this:

It's not obvious that ns-lazy-src is a directive and delay is an input for that directive.
Some directive writers use namespace also for directive options and inputs:

While it solves the problem of naming collision and it's definitely better than not using the namespace for directive's inputs and options, the problem of non-readability still exists.
I think a naming convention for options and inputs of directive makes everything cleaner.
I haven't thought about the best style but maybe inputs of directives (I mean isolated bindings) can be prefixed with in- and  options of directive can be prefixed with opt-

However it may introduce a confliction probability!

interesting. Would love some community feedback on this. I'll mark as "help wanted"


Remove default grace period and timeout when draining a node.

By default, the grace period is -1, or whatever the pod specifies on
its terminationGracePeriodSeconds spec. The pod can know better than
us what it needs to cleanly stop, and we don't need to apply arbitrary
timeouts. If this is not specified, the default terminationGracePeriodSeconds
value is 30 seconds. After this grace termination period, a SIGKILL will
be sent to the process when evicting pods.
Aside from this, we should have an "inifinite" timeout. Given that this
process doesn't stall, it's safer to perform this operation until it
succeeds. If we have proof that this is causing problems we should add
a timeout, but in general the draining process should not hang.
The alternative is in reality the real problem: if we timeout the draining
process, it can happen that certain pods with remote volumes (nfs, rbd...)
are never evicted, and when we go to restart the machine it hangs, because
systemd fails to kill the processes when there are active mounts.
Since there are no sensible defaults for the grace period and for the global
timeout is better to let the first one to the pod definition, and the second
one to just "infinite" until we really hit an issue because of this.
Fixes: bsc#1085980

 [urgent: v2] Bug 1085980 - L3: Machine stucks at reboot


Web App Sample versoin

Thank you for making this sample. Do you have a Cordova Web app version? I am unable to get Tizen's instructions working for reading NFC.

Contacting proper developer for your question...

Hello,
regarding to Cordova Web Application, Tizen does not support Cordova directly using Cordova CLI. Even though CLI is not supported, Tizen web application supports a set of cordova plugins using a workaround based on procedure of manual inject JS code related to Cordova plugins.
The sample of application capable to use Cordova plugins is available here: in git project:
review.tizen.org:29418/platform/core/api/cordova-plugins branch: tizen directory: sample
The procedure of using it with Tizen Studio is described here: _https://cordova.apache.org/docs/en/5.0.0/guide/platforms/tizen/_
Here is the list of available features of Cordova _https://developer.tizen.org/development/guides/web-application/cordova_
According to NFC, you didn't provide much details, but here is the guide which describes most common scenarios of using NFC - _https://developer.tizen.org/development/guides/web-application/connectivity-and-wireless/nfc_
Full API reference is here: _https://developer.tizen.org/dev-guide/5.0.0/org.tizen.web.apireference/html/device_api/mobile/tizen/nfc.html_


Pretrained weights and demo available?

Thank you for your attention,
the final model weight has been uploaded to https://drive.google.com/file/d/18slzp3azV_XHrXCTu3KAQW7mKW62-kEk/view?usp=drive_link.
We do not have a plan to create a demo, you can use the provided weight for inference.
We will organize the inference commands and provide them later.
Additionally, may I ask if you are also a participant in the VSS track?
best,
Chang


Handle nested properties in GeoJSON reader and writer

The GeoJSONReader currently silently omits any nested property. This serializes the Value for an Array or Object back to a string to store within a ColumnValue::Json.
The GeoJSONWriter currently silently omits any ColumnValue::Json or ColumnValue::Binary. This PR writes the contained JSON string to the output writer. It leaves writing binary to a future PR (which should probably at least have the option of converting to hex?)
I'm not sure why but I was unable to run tests locally because they failed with
  = note: ld: library 'pq' not found

I'm guessing this has something to do with Postgres' libpq, but brew install libpq says it's already installed.

Anything else I can do to push this along?


Better C++ docs

Right now we are using doxygen out of the box - which is fine, although, honestly I think it could be better - both in terms of usability and looks. I have two different approaches in mind, which I think are worth considering:
Approach 1. Use MCSS theme

Pros: Best part, IMO, is the quick search feature as soon as you press tab. It increases usability by a lot.
https://mcss.mosra.cz/documentation/doxygen/
Example (magnum): https://doc.magnum.graphics/magnum/

Approach 2. Integrate with sphinx/readthedocs

sphinx/readthedocs seems to have support for C++ code. Although I have yet to look into how viable an option this is.
Pros: This would bring both Python and C++ documentation to a single place. This means common concepts could be documented together. However, it is worth evaluating this approach further if coupling them together might complicate some other things.
https://www.sphinx-doc.org/en/master/usage/restructuredtext/domains.html#cpp-domain

Right now I am leaned a bit towards Approach 1.
Any ideas/suggestions/contributions towards this would be greatly appreciated.

Went ahead with Approach 1. Has been implemented in https://github.com/adonmo/meos/commit/d17cedfc04f2ef13456fbd352741adf2fc54bada.
The new documentation is live at: https://meos.netlify.app/
Also, a similar change has been contributed to the upstream template on which the base CMake code structure of MEOS was based on: https://github.com/TheLartians/ModernCppStarter/pull/49.