LayoutController insert 0 not working

I am trying to insert surface to the top of the layout, but the surface doesn't seem to be rendered.
I checked the getDataSource() and the added surface is in the list, but not rendered on the screen.
Sample code I am using:
define(function(require, exports, module) {
  var View = require('famous/core/View');
  var Surface = require('famous/core/Surface');
  var LayoutController = require('famous-flex/LayoutController');
  var ListLayout = require('famous-flex/layouts/ListLayout');
  var CollectionLayout = require('famous-flex/layouts/CollectionLayout');

  function Debug(options) {
    View.apply(this, arguments);
    this.layout = new LayoutController({
      layout: ListLayout,
      flow: true,
      direction: 1,
      autoPipeEvents: true,
      alwaysLayout: true,
      layoutOptions: {
        margins: [0, 15]
      }
    });
    this.add(this.layout);

    this.contentHeaderSurface = new Surface({
      size: [undefined, 34],
      content: 'contentHeaderSurface'
    });
    this.layout.push(this.contentHeaderSurface);

    this.addButton = new Surface({
      size: [undefined, 40],
      content: 'Add Surface',
      properties: {
        backgroundColor: '#144170',
        color: '#fff',
        textAlign: 'center',
        padding: '8px'
      }
    });
    this.addButton.on('click', this._onaddButtonClick.bind(this));

    this.removeButton = new Surface({
      size: [undefined, 40],
      content: 'Remove Surface',
      properties: {
        backgroundColor: '#ffbf25',
        color: '#000',
        textAlign: 'center',
        padding: '8px'
      }
    });
    this.removeButton.on('click', this._onremoveButtonClick.bind(this));

    this.buttons_grid = new LayoutController({
      layout: CollectionLayout,
      layoutOptions: {
        direction: 1,
        cells: [2, 1],
        spacing: [15, 0]
      },
      dataSource: [
        this.addButton,
        this.removeButton
      ]
    });
    this.layout.push(this.buttons_grid);
  }

  Debug.prototype = Object.create(View.prototype);
  Debug.prototype.constructor = Debug;
  Debug.prototype._onremoveButtonClick = function() {
    this.layout.remove(this.contentHeaderSurface);
  };
  Debug.prototype._onaddButtonClick = function() {
    this.layout.insert(0, this.contentHeaderSurface);
  };
  module.exports = Debug;
});

Insert is working for FlexScrollView but not for LayoutController.
Can you suggest which way is better?

Hmm, that's weird.
Just wondering, have you tried ensureVisible(..) on the newly inserted surface. Does that fix your problem?

ensureVisible(..) is only available for ScrollController. It doesn't work with LayoutController.
I will use ScrollController and disable the scroll.

Hey Howard,
I know what the problem is. The layout-controller doesn't change the "first visible node" when you insert a node. Using ScrollController is an option, but do note that when you "insert" before the first visible node, it doesn't necessarily show that node. If you want to ensure that the node is visible also call ensureVisible on ScrollController.
An other option would be to to reset the whole datasource of the layoutcontroller, this way it will always render from the first node in the datasource:
layoutController.setDataSource([header,content]);

I like the latter option since flex controller will calls the layout function when I add/remove elements. This way I can ensure the correct elements rendered on the screen and the performance should be the same.

Awesome, glad to hear that's a suitable solution.
As for fixing this.. I've decided not to fix this in the current famous-flex version. Instead I will be focusing on the mixed-mode version and will take this issue into account when writing the new LayoutController.
cheers


Traceback Handling in Python Subscriber

Is your feature request related to a problem? Please describe.
When using a python subscriber possible tracebacks (due to exceptions of breaking code) are not printed to stdout/stderr
Describe the solution you'd like
A way to get and/or detect tracebacks within python subscriber callbacks
Describe alternatives you've considered
A hostwide log where errors (like tracebacks) are stored
Additional context

I am using ProtoSubscriber()
It also seems like debugging a callback with breaking points in tools like VSCodes is not possible. In this context I would be thankful if you could elaborate the threading/process model of python apps with subscribers and publishers a bit more.

Hi @nullket,
I think we've previously hit this issues too.
The thing is, eCAL is using a native threading model. Callbacks are always executed in different threads than the main thread.
Currently, the Python wrapper is implemented in such a way, that the callback thread will try and acquire the GIL, execute the callback, and then again release the GIL.
You can find the code [here] (https://github.com/continental/ecal/blob/854285b737826a58c8b5fc82df8a427acfadc769/lang/python/core/src/ecal_wrap.cxx#L529)
You also have the possibility to continously poll on sub_receive instead of registering a callback, you will then receive the data in the main thread.
Publishing, on the other hand, always takes place in the main thread.
I don't know, maybe it's possible to "move" the actual data into the main thread? To synchronize? But unfortunately I have very few experience here, if you have any experience it will be welcome.

Hello @nullket thanks for the quick reply.
Imho it makes totally sense to have each callback being executed in its own thread. In my applications the main is more than often doing other blocking things and would mess with the whole timings it all would run in one thread.

You also have the possibility to continuously poll on sub_receive instead of registering a callback

Sure but having the downsides of polling just for the sake tracebacks seems a bit like a bad deal.

I don't know, maybe it's possible to "move" the actual data into the main thread? To synchronize?

To my knowledge this already the default behavior of the regular threading in python. I mean at the end it is just another thread not another process, right? I created very quick python only demo for this (threading like this will acquire the GIL as well):
import threading
import time

class MultiThreadDemo():
    def __init__(self) -> None:
        self.thread_loop_1 = threading.Thread(target=self.async_loop_1, daemon=True)
        self.thread_loop_1.start()
        self.thread_loop_2 = threading.Thread(target=self.async_loop_2, daemon=True)
        self.thread_loop_2.start()

    def async_loop_1(self):
        while True:
            time.sleep(1)
            print("[loop_1]")

    def async_loop_2(self):
        ii = 0
        while True:
            time.sleep(1)
            print("[loop_2]")
            ii += 1
            if ii > 3:
                print("Causing a traceback in loop_2:")
                raise Exception("Artifical Trace")

if __name__ == "__main__":
    demo = MultiThreadDemo()
    while True:
        time.sleep(1)

/bin/python /tmp/thread.py
[loop_1]
[loop_2]
[loop_1]
[loop_2]
[loop_1]
[loop_2]
[loop_1]
[loop_2]
Causing a traceback in loop_2:
Exception in thread Thread-2:
Traceback (most recent call last):
  File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/tmp/thread.py", line 24, in async_loop_2
    raise Exception("Artifical Trace")
Exception: Artifical Trace
[loop_1]
[loop_1]
[loop_1]
[loop_1]

So the reason might lay in the c++ wrapper? I don't want to start some kind of comparison but ros executes its python callbacks in their own threads as well but tracebacks are visible and logged. Maybe they solved this particular issue already.

So I am not 100% sure from what I see, but it seems that ros_py is a pure Python implementation? https://github.com/ros/ros_comm/tree/noetic-devel/clients/rospy/src/rospy/impl
If there is a C++ (also) a C++ wrapper, and you have the link, I am more than willing to look at it.
Or if you have any other references regarding this topic. Btw I asked a very, very similar question some years back on StackOverflow, but that was regarding QT Threads.
Maybe you can actually try this in your callback.
We'll put in on our agenda, but if it is not an easy fix it might not get highest prio.

So I am not 100% sure from what I see, but it seems that ros_py is a pure Python implementation?

Yes, I just saw this as well. It is all python and therefore uses threading which then uses the low-level _thread module and this is in c which seems to work with exception hooks.

Or if you have any other references regarding this topic.

I am definitely no expert as I have never written a c++ python wrapper/module myself. From a quick research it seems like the whole pyErr_*() functions from the c-API are what we are looking for? Just from the documentation it seems like you would regularly check for tracebacks at the end of the callback wrapper with PyErr_Occurred() and in case a traceback occurred you would fetch or print it directly with PyErr_Print(). Here is a rather old stackoverflow questions towards this. From my understanding something minimal like following could work already:
PyObject_CallObject(...)
if (PyErr_Occurred ()) {PyErr_Print ();}

On the other hand in your current implementation you are not using the return value of the PyObject_CallObject() call. The return value should be NULL in case the call failed. Maybe this would be more efficient than always calling PyErr_Occurred() but I am not sure.

Maybe you can actually try this in your callback.

Thanks I will try this out!

Thanks for the pointers, we will take a look.
Also I am not sure what is the desired behavior in the whole program in the case of an exception?
Should the programm continue it's execution (which I guess it currently does)? I rather doubt it.
What is the Python behavior if there is an exception in a different thread?

What is the Python behavior if there is an exception in a different thread?

The thread stops as shown in the example above. But in ecal the thread exists after a (successful) callback anyways and a new thread will be created on the next callback, right?
I do not know what would be best: Having a lot of tracebacks due to callbacks failing or automatically unsubscribing after the first traceback. Somehow I favor more for the first as it gets harder to miss but would no lead to unpredictable behavior (image the callback works sometimes but sometimes not)

From my understanding something minimal like the following could work already:

PyObject_CallObject(...)
if (PyErr_Occurred ()) {PyErr_Print();}

I just recompiled ecal with this extensions and this works perfectly. Tracebacks are printed to the main window (every time the subscriber executes the callbacks which is perfectly fine for me)


Enable Dependabot

Dependabot is now enabled by adding the Gradle Dependency Submission workflow.
This uncovered, that our use of the Gradle Checkstyle plugin was pulling in an ancient checkstyle release, which in turn pulled in some vulnerable dependencies.
I upgraded the checkstyle tool to the latest version, which fixed the Dependabot alerts.


Wrap all css rules in .pdebug

Nice plugin btw!
Just a small improvement.. I'm using this plugin in a project that has bootstrap (css framework) and all my checkboxes are being changed to toggle images (which incidentally I cant see where they're used in the debug interface anyway)
I think it would be better if all css rules began with .pdebug
e.g.
.pdebug .checkbox { ... }

They do in main.less, looks like I forgot it in forms.less.

5694a7eba76d5470aac6dbda94ef668398e49491


Keep the connection alive for  5 sec

closing this as some targets do not have the http module - a better solution would be to allow overriding fetch


Separate name resolution from elaboration

Pushing and popping names during elaboration/unification/semantics is an annoyance (#488). It would be nice if we can separate name resolution to a separate pass performed before elaboration.
A potential hurdle is that some aspects of name resolution are type-sensitive, and so AFAIK cannot be purely syntax-directed. Namely, elaboration of surface::Term::Tuple depends on the type being checked against: if it elaborated to a RecordLiteral, no new bindings are inserted. But if it is elaborated to a RecordType or RecordFormat, a new binding is inserted for each element of the tuple. We may be able to find a workaround for this.

Prior art

rustc and rust-analyzer perform name resolution as a separate phase before type checking. IIUC name resolution in Rust is purely syntax directed, at least for locals (though not for globals, methods, associated types etc)
GHC has a "renamer" pass between parsing and type checking (GHC commentary, GHC wiki

I’m not sure about this to be honest. Doesn’t this still require us to push and pop parameters and definitions during elaboration? Not really sure what separating name resolution out would buy us, but I could be missing something. The issue in elaboration is more that we are mutating the state of the context in-place - that includes both the name environment and the type environment.

I think it would allow us to simply mutate the environment, rather than pushing/popping.
eg currently when elaborating a let-expression:
let name = pattern.name();
let (expr, r#type_value) = self.synth(def_expr);
let expr_value = self.eval_env().eval(&expr);
self.local_env.push_def(name, expr_value, r#type_value);
let body_expr = self.synth(body_expr);
self.local_env.pop();

instead it would simply be:
let name = pattern.name();
let (expr, r#type_value) = self.synth(def_expr);
let expr_value = self.eval_env().eval(&expr);
self.local_env.set(pattern, expr_value, r#type_value);
let body_expr = self.synth(body_expr);

where self.local_env is a FxHashMap<ByAddr<&'arena Pattern<ByteRange>, (ArcValue<'arena>, ArcValue<'arena>)

Oh, so would we be switching to unique names in the syntax, as opposed to de Bruijn indices?

No, I think we still want de Bruijn indices so that alpha equivalence is trivial


[HOW-TO] UDP server h264 format

How to write a server for receiving and displaying a video stream received over udp and encoded in h264 format, as is done in the example for sending a video stream over udp

Hi, thanks for the question. Do the suggestions here help?
Note that I would recommend ffplay over vlc these days; recent versions of vlc don't handle vanilla h264 streams properly.


Refactor InvokeTransaction creation in native_blockifier.

This change is

Codecov Report

Merging #960 (44106a1) into main (4fb3261) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #960      +/-   ##
==========================================
- Coverage   68.61%   68.41%   -0.20%
==========================================
  Files          45       46       +1
  Lines        5967     5984      +17
  Branches     5967     5984      +17
==========================================
  Hits         4094     4094
- Misses       1499     1516      +17
  Partials      374      374

Files
Coverage Δ

crates/native_blockifier/src/lib.rs
0.00% <ø> (ø)

crates/native_blockifier/src/py_transaction.rs
0.00% <0.00%> (ø)

crates/native_blockifier/src/py_invoke_function.rs
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Make dbs downloaded selectable using package.json property

Here is the pull request allowing user to select which dbs are downloaded using a property on the optional "geolite2" property within package.json.
It does not break the current API, if the property is absent, it will download all dbs.
index.js was adjusted so that only dbs downloaded have path values. Tests were adjusted to only run for downloaded dbs.
Closes #30.

Also, I tested the package by installing it using npm from github and it worked in client projects as well.

Issue with failing builds is because of the fork. I've added you as collaborator - you should get invite.
If it's not too much trouble, can you please create a branch in this repo so that Travis would do more meaningful job?

Sure, sounds good.

Breaks Travis build.


error after 12 minutes of running

13:20:03 picking a random subreddit
13:20:03 checking subreddit: MoneroMining
13:20:04 replying to comment
13:22:00<PHONE_NUMBER>16 < 0.005 = True
running action: reddit_post_chance
13:22:00 running repost
13:22:00 finding a post to re-post
13:22:00 picking a random subreddit
13:22:00 checking subreddit: Hawaii
13:22:00 searching post in sub: Hawaii
13:22:00 pushshift-url: https://api.pushshift.io/reddit/search/submission/?subreddit=Hawaii&before=1602609720&after=1602523320&score>=5000&limit=1&author!=[deleted]&selftext:not=[deleted]
pushshift http error: 500
13:22:30<PHONE_NUMBER>38 < 0.002 = True
running action: reddit_remove_low_scores
13:22:30 checking for low score content to remove
13:22:30 no low score content to clean up. I'm a good bot! :^)
13:22:43<PHONE_NUMBER>25 < 0.005 = True
running action: reddit_post_chance
13:22:43 running repost
13:22:43 finding a post to re-post
13:22:43 picking a random subreddit
13:22:43 checking subreddit: gamernews
13:22:43 searching post in sub: gamernews
13:22:43 pushshift-url: https://api.pushshift.io/reddit/search/submission/?subreddit=gamernews&before=1602609763&after=1602523363&score>=5000&limit=1&author!=[deleted]&selftext:not=[deleted]
Traceback (most recent call last):
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\urllib3\connectionpool.py", line 699, in urlopen
httplib_response = self._make_request(
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\urllib3\connectionpool.py", line 445, in _make_request
six.raise_from(e, None)
File "", line 3, in raise_from
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\urllib3\connectionpool.py", line 440, in _make_request
httplib_response = conn.getresponse()
File "C:\Users\devin\AppData\Local\Programs\Python\Python310\lib\http\client.py", line 1368, in getresponse
response.begin()
File "C:\Users\devin\AppData\Local\Programs\Python\Python310\lib\http\client.py", line 317, in begin
version, status, reason = self._read_status()
File "C:\Users\devin\AppData\Local\Programs\Python\Python310\lib\http\client.py", line 286, in _read_status
raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\requests\adapters.py", line 439, in send
resp = conn.urlopen(
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\urllib3\connectionpool.py", line 755, in urlopen
retries = retries.increment(
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\urllib3\util\retry.py", line 532, in increment
raise six.reraise(type(error), error, _stacktrace)
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\urllib3\packages\six.py", line 769, in reraise
raise value.with_traceback(tb)
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\urllib3\connectionpool.py", line 699, in urlopen
httplib_response = self._make_request(
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\urllib3\connectionpool.py", line 445, in _make_request
six.raise_from(e, None)
File "", line 3, in raise_from
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\urllib3\connectionpool.py", line 440, in _make_request
httplib_response = conn.getresponse()
File "C:\Users\devin\AppData\Local\Programs\Python\Python310\lib\http\client.py", line 1368, in getresponse
response.begin()
File "C:\Users\devin\AppData\Local\Programs\Python\Python310\lib\http\client.py", line 317, in begin
version, status, reason = self._read_status()
File "C:\Users\devin\AppData\Local\Programs\Python\Python310\lib\http\client.py", line 286, in _read_status
raise RemoteDisconnected("Remote end closed connection without"
urllib3.exceptions.ProtocolError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\devin\Documents\reddit-karma-farming-bot-master\src\init.py", line 10, in
bot.run()
File "C:\Users\devin\Documents\reddit-karma-farming-bot-master\src\bot.py", line 8, in run
reddit.run()
File "C:\Users\devin\Documents\reddit-karma-farming-bot-master\src\bots\reddit\bot.py", line 63, in run
self.tick()
File "C:\Users\devin\Documents\reddit-karma-farming-bot-master\src\bots\reddit\bot.py", line 58, in tick
action.call()
File "C:\Users\devin\Documents\reddit-karma-farming-bot-master\src\bots\reddit\actions\post_actions.py", line 96, in repost
api_call=requests.get(post.url).status_code
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\requests\api.py", line 75, in get
return request('get', url, params=params, **kwargs)
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\requests\api.py", line 61, in request
return session.request(method=method, url=url, **kwargs)
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\requests\sessions.py", line 542, in request
resp = self.send(prep, **send_kwargs)
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\requests\sessions.py", line 655, in send
r = adapter.send(request, **kwargs)
File "C:\Users\devin.virtualenvs\reddit-karma-farming-bot-master-FR336Gl1\lib\site-packages\requests\adapters.py", line 498, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
exiting...
Press any key to continue . . .

Thanks, I didn't know about code blocks sorry :s
Actually, it's been like this for me for 2 days now. Relaunching the bot doesn't really solve it...

Download the bot 2x on 2 different folders, and you might need to use a VPN/Proxy but im not too sure. @johanviper972

Got it, thanks

Got it, thanks @sheepsushis

where you able to run this severally on one pc?


How to run the converted code with V8？

I'd like to use v8 to run js file converted by traceur, but get the error:ReferenceError: $traceurRuntime is not defined.
The poc.js is as follows:
var SomeClassExample = function() {
  "use strict";
  function SomeClassExample() {}
  return ($traceurRuntime.createClass)(SomeClassExample, {}, {});
}();

the cmd is
v8 poc.js

then I noticed the runtime, so add the traceur-runtime.js
v8 ../node_modules/traceur/bin/traceur-runtime.js poc.js

but still get the error: ModuleEvaluationError: Cannot read properties of undefined
../node_modules/traceur/bin/traceur-runtime.js:233: Error: ModuleEvaluationError: Cannot read properties of undefined (reading 'Object') in<EMAIL_ADDRESS>        throw ex;
        ^
ModuleEvaluationError: Cannot read properties of undefined (reading 'Object')
    at polyfillSymbol (../node_modules/traceur/bin/traceur-runtime.js:484:25)
    at ../node_modules/traceur/bin/traceur-runtime.js:499:3
 loaded by<EMAIL_ADDRESS> loaded by<EMAIL_ADDRESS> loaded by<EMAIL_ADDRESS>
I install the traceur through npm
sudo npm i traceur

I use the traceur-runtime at node_modules/traceur/bin/traceur-runtime.js.
the version of traceur is 0.0.11.
the version of v8 is 9.7.28， installed by jsvu.
So, how can I run js files on the terminal through the V8 command line?

First, I'm not sure why you need Traceur any more? V8 supports all* of the features Traceur supports and more.
[*] Traceur has a few experimental features like decorators which are not in v8.

I do not think the v8 cli takes multiple files. It might have a global load function so you could do something like:
load('traceur-runtime.js');
load('poc.js');


Add auto merge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/aiotube-feedstock#2.


Fix broken link to nodejs versions

Nodejs must have updated their URLs

Well that's annoying... thanks for fixing it!


I wanted simply to know the list of correct extensions to send an audio / voice, because if send an unmanaged extension (opus / aac) creates exception

Steps to reproduce
Expected  behavior
Actual behavior
Environment data
NuGet Package Version: (e.g. 10.3.0)
.NET Version: (e.g. 4.6, Core RTM, Mono, etc.)
IDE: (e.g. VS2015, VS Code, etc.)
App: (e.g. Desktop, iOS, Android, etc.)

SendAudio
https://core.telegram.org/bots/api#sendaudio

Your audio must be in the .mp3 format.

SendVoice
https://core.telegram.org/bots/api#sendvoice

For this to work, your audio must be in an .ogg file encoded with OPUS

not all the .ogg OPUS file work, only the native file made with telegram,
the converted file doesn't work
2017-04-19 13:00 GMT+02:00 Robin Müller<EMAIL_ADDRESS>
SendAudio
https://core.telegram.org/bots/api#sendaudio
Your audio must be in the .mp3 format.
SendVoice
https://core.telegram.org/bots/api#sendvoice
For this to work, your audio must be in an .ogg file encoded with OPUS
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MrRoundRobin/telegram.bot/issues/321#issuecomment-295218633,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXkrZR0n992VnElQ2MwjOd_3NptomH_dks5rxelegaJpZM4MpG7q
.


in iOS, can setting pull to refresh for webview?

I faced  can not webview pull to refresh for reload
in android, can enable pull to refresh by rememberPullToRefreshState
but in ios,  can not detect this

@karorok Could you provide the code?


In editing mode, images come out of their flow and overlap other content

Hi,
Great plugin. Although I have an issue with using (bigger) images.

They do go back to their regular flow after saving though.
This happens because of the images displaying as background-images, and using the dimensions of the image itself, how can I fix this (I located the code to the minified JS file, but I'm kinda hesitant to change anything in there).
Thank you in advance

Hey, best will be to use it as img tag.


worth_buy not defined!

worth_buy not defined in senti_analysis_per_product.py
Check for loop

Fixed the problem. Had uploaded the old code by mistake. Try it out once!!


Sometimes I see an error that tor listener is not running even tor indicator is green

Nothing what we can do, seems like it is starting timing problem. I can't reproduce it with mwc713


Robust independent maintenance page for cloud deployments

Currently, indep. maint.page goes frequently out of sync (e.g. update of lb.tf without updating corresponding maintenance_lb.tf, or new CI artifacts that are not added) and we have no means to see / be warned about that until we start indep. maint. page during production deploy and it breaks.
Also when terraform changes are need to be deployed, we cannot use indep. maint. page separately
Also the LB network traffic switch take 2-3 minutes during some of which we show 404. this is not ideal

Duplicate of https://github.com/ITISFoundation/osparc-ops-environments/issues/658


missing /api/info/queue endpoint documentation

I'm thinking about how to set drone Docker workers to autoscale inside our Mesos/Marathon/Metronome cluster which isn't covered in the "offical" autoscaler & noticed it seems to have /api/info/queue endpoint that provides the needed info about the build queue - I found it referenced in a few closed tickets about it's creation but no documentation about it or any /api/info
Is this endpoint still valid in 1.0 API? if so shouldn't it be documented?

:wave: hey there, per our issue template, for end-user support please use one of our support channels, such as our chatroom or our mailing list.


FormatException when getting IndexMetrics from responseMessage

We are continuously addressing and improving the SDK, if possible, make sure the problem persist in the latest SDK version.

Describe the bug
We recently started observing an exception in our test environment when running Sql queries in CosmosDb. From our logs we see that this happens after the query has been executed and we are trying to log the Index recommendations from the returned response message. We use the FeedIterator.ReadNextAsync API to run the search query. From the below call stack this seems to be happening when the index is being converted to string inside CosmosDb.
The CosmosDb ActivityId for one such search query is: 291abd2d-2d74-462e-b347-546fb0fd1bb3 (within the last one day). Account Name = onedf-andrsync-3
To Reproduce
Not sure which search query will hit this, since not all queries are hitting this issue. But we get this by calling the FeedIterator.ReadNextAsync API and then by trying to log the responseMessage.IndexMetrics

Expected behavior
Exception should not be hit
Actual behavior
Format exception being thrown when accessing IndexMetrics from ResponseMessage
Environment summary
SDK Version: 3.37.1, 3.38.1
OS Version (e.g. Windows, Linux, MacOSX): Windows
Additional context
Exception stack:
System.FormatException: The input is not a valid Base-64 string as it contains a non-base 64 character, more than two padding characters, or an illegal character among the padding characters.
at System.Convert.FromBase64_Decode(Char* startInputPtr, Int32 inputLength, Byte* startDestPtr, Int32 destLength)
at System.Convert.FromBase64CharPtr(Char* inputPtr, Int32 inputLength)
at System.Convert.FromBase64String(String s)
at Microsoft.Azure.Cosmos.Query.Core.Metrics.IndexUtilizationInfo.TryCreateFromDelimitedBase64String(String delimitedString, IndexUtilizationInfo& result)
at Microsoft.Azure.Cosmos.ResponseMessage.<>c__DisplayClass46_0.b__0()
at System.Lazy1.CreateValue()    at System.Lazy1.LazyInitValue()
at Microsoft.Intune.CloudStorage.CosmosDb.CosmosDbQueryV32.<ExecuteNextAsync>d__12.MoveNext() <>     at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    <>    at Microsoft.Intune.CloudStorage.CosmosDb.Decorators.AutoOpenDecorator1.d__51.MoveNext() <>     at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    <>    at Microsoft.Intune.CloudStorage.CosmosDb.Decorators.MetricsAndErrorHandlingDecorator1.d__4`1.MoveNext()

Just for clarification, what type is responeMessage in your code?

It's the Microsoft.Azure.Cosmos.ResponseMessage:


[Issue 637] Fix bash example generation for arrays on @queryParam or @bodyParam

Picks up on solution discussed at https://github.com/mpociot/laravel-apidoc-generator/issues/637
There is an error in the proposed solution, so I fixed it and hope we can integrate this bugfix back into your repo.

On vacation till January 3.
(Also, check tests.)

Can you add this to the other language templates? Also, the tests are failing because the resulting HTML does not match exactly. Looks like you need to fix some indentation in your template.

Ping @lucianobargmann still on this?

Closed in favour of #700. Thanks for the initial groundwork.

Closed in favour of #700. Thanks for the initial groundwork.


Move FLCC sprites to separate folders to prevent conflicts with Flush…

…elineHelper
I did my best to make sure this won't break existing maps using those entities.

i approve but am worried about existing map compatibility

I believe the only thing this would break is if people are using those sprites for other modded entities.


work team page

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

45 of 45 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 94.338%

Totals

Change from base Build<PHONE_NUMBER>1:
0.007%

Covered Lines:
1859

Relevant Lines:
1947

💛  - Coveralls


Update RxSwift and Nimble

RxSwift now on 3.0 (finally 🎉 )
Nimble now on 5.1

I also changed the Cartfile/Podspec version specification to the 'compatible with' operator.

Hi,
Thanks as always! :-)
Do tou have any idea why Travis check has failed? Looks like Travis problem I suppose, not something with code itself.

Looks like it is a travis bug: https://github.com/travis-ci/travis-ci/issues/4725
I just updated the .travis.yml with a sleep 5 after success, which should fix the error.
I also updated some other stuff in the .travis.yml like using the current Carthage because the carthage/RxSwift problems described in the previous .travis.yml seem resolved.
I also added the -verbose flag to xcodebuild, so if the problem (or others) appears again, we may get a better problem description.

Now it looks all fine.
Merging it to master :-)
Good work Kevin 👍


Transfer XLM To Coinbase Fail

Yesterday I tried to transfer XLM from my Ledger wallet to Coinbase. There was an issue with the "add a tag" function but I sent it anyway and the XLM never appeared in my Coinbase account. Is recovery of my stellar crypto possible?

Yesterday I tried to transfer XLM from my Ledger wallet to Coinbase. There was an issue with the "add a tag" function but I sent it anyway and the XLM never appeared in my Coinbase account. Is recovery of my stellar crypto possible?

Hello @ARoyBoy
We apologize for the inconvenience you’re experiencing. For personalized assistance, please contact our support team directly.
Ticket ID:CBE005621
Coinbase support Network:
To start a chat with a live support agent, click the live chat icon at the bottom corner of the page.

Yesterday I tried to transfer XLM from my Ledger wallet to Coinbase. There was an issue with the "add a tag" function but I sent it anyway and the XLM never appeared in my Coinbase account. Is recovery of my stellar crypto possible?

Hello @ARoyBoy
You're experiencing transcript error. It sounds like your query would be best dealt with by the support team.
I'll have to refer you to the official support live chat with the ticket ID XLM07638
Please see the link below to our dedicated support line:
Coinbase Network DApps Support Ticket Requests.
Note; Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent.


fix(yandex-metrika) update URLs in package.json

@Atinux I think this one can be closed.
Changes has been made into https://github.com/nuxt/modules/blob/5b73828c0b60618a24684cfd2a24412cc64c25bf/modules/yandex-metrika.yml#L6

@Atinux I think this one can be closed.
Changes has been made into https://github.com/nuxt/modules/blob/5b73828c0b60618a24684cfd2a24412cc64c25bf/modules/yandex-metrika.yml#L6


ng lint does not support --app option

I have created two app in my project named as main and login. I configured my .angular-cli.json as follows:
{
  "$schema"<EMAIL_ADDRESS>  "project": {
    "name": "multi-demo"
  },
  "apps": [
    {
      "root": "login",
      "outDir": "dist/login",
      "assets": [
        "assets",
        "favicon.ico"
      ],
      "index": "login.html",
      "main": "main.ts",
      "polyfills": "polyfills.ts",
      "test": "test.ts",
      "tsconfig": "tsconfig.app.json",
      "testTsconfig": "tsconfig.spec.json",
      "prefix": "app",
      "styles": [
        "styles.css"
      ],
      "scripts": [],
      "environmentSource": "environments/environment.ts",
      "environments": {
        "dev": "environments/environment.ts",
        "prod": "environments/environment.prod.ts"
      }
    },
    {
      "root": "main",
      "outDir": "dist/main",
      "assets": [
        "assets",
        "favicon.ico"
      ],
      "index": "index.html",
      "main": "main.ts",
      "polyfills": "polyfills.ts",
      "test": "test.ts",
      "tsconfig": "tsconfig.app.json",
      "testTsconfig": "tsconfig.spec.json",
      "prefix": "app",
      "styles": [
        "styles.css"
      ],
      "scripts": [],
      "environmentSource": "environments/environment.ts",
      "environments": {
        "dev": "environments/environment.ts",
        "prod": "environments/environment.prod.ts"
      }
    }
  ],
  "e2e": {
    "protractor": {
      "config": "./protractor.conf.js"
    }
  },
  "lint": [
    {

      "project": "login/tsconfig.app.json",
      "exclude": "**/node_modules/**"
    },
    {
      "project": "login/tsconfig.spec.json",
      "exclude": "**/node_modules/**"
    },
    {
      "project": "main/tsconfig.spec.json",
      "exclude": "**/node_modules/**"
    },
    {

      "project": "main/tsconfig.app.json",
      "exclude": "**/node_modules/**"
    },
    {
      "project": "e2e/tsconfig.e2e.json",
      "exclude": "**/node_modules/**"
    }
  ],
  "test": {
    "karma": {
      "config": "./karma.conf.js"
    }
  },
  "defaults": {
    "styleExt": "css",
    "component": {}
  }
}

Now I when I use ng lint command on root directory its giving output as follows:
ng lint --format stylish
D:/UI Workspace/Angular 5/multi-Demo/login/app/home/home.component.ts
ERROR: 3:9   import-blacklist  This import is blacklisted, import a submodule instead

D:/UI Workspace/Angular 5/multi-Demo/main/app/app.component.ts
ERROR: 8:26  one-line          missing whitespace

Lint errors found in the listed files.

So, the requirement is that I want fire ng lint command on individual app contained my root project and generate individual lint report.

Thanks for reporting this issue. This issue is now obsolete due to changes in the recent releases. Please update to the most recent Angular CLI version.
If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior.


issue 118 - One pool per redis instance

There is already a pull request for the same issue, but to me that implementation could have been simpler. That implementation introduced even more dependecies from the none sharding code (BinaryJedis and Jedis) to the shardinfo implementation. In my opinion. these classes should not know anything about sharding.To return the Jedis instance to the correct pool I decided to use the host and port from the shardinfo and jedis client.

Since Jedis has changed too much, we can't apply this.
Furthermore, we agree that we don't treat ShardedJedis as core of Jedis, and for now we don't improve it.
If you think that we really need this feature, please leave an issue and link this so that we don't forget it.
Closing. Thanks!


Error on block_gte for blocks before the start block

https://github.com/graphprotocol/graph-node/pull/3673 introduced a change where the graphQL API would error for blocks before the start block.
This makes sense for filtering by block number (example)
But filtering by number_gte should return the latest data (example)

Users have also expressed a preference to be able to query for blocks before the startBlock (previously it returned null), but this might not make sense with the change from #3673 @lutter

Users have also expressed a preference to be able to query for blocks before the startBlock (previously it returned null), but this might not make sense with the change from #3673 @lutter

Yes, we should not allow querying for block { number } before the start block. number_gte though should be made to work even with block 0


Disable\Block progressive web apps from being installed for all users

Good day,
I hope you are well,
I have a client with all endpoints which are Intune managed and want to block\prevent progressive web apps from being installed.
Is this possible? I have done some research online and have not found any clues to block PWA's.
Thank you in advance.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 55284993-672a-b950-38ec-f3e175dfbf93
Version Independent ID: 0617203d-5c57-037e-74b9-11c025917d07
Content: Overview of Progressive Web Apps (PWAs) - Microsoft Edge Development
Content Source: microsoft-edge/progressive-web-apps-chromium/index.md
Product: microsoft-edge
Technology: pwa
GitHub Login: @MSEdgeTeam
Microsoft Alias: msedgedevrel

Hello. I found two Microsoft Edge Enterprise policies that are somewhat related to what you're looking for:

WebAppInstallForceList: https://learn.microsoft.com/en-us/deployedge/microsoft-edge-policies#webappinstallforcelist
WebAppSettings: https://learn.microsoft.com/en-us/deployedge/microsoft-edge-policies#webappsettings

They don't do what you're looking for, but I thought I'd mention them in case this helps put you on the right track.
In any case, I suggest reaching out through the Enterprise repository instead of this repo, which is dedicated to web developer docs only. Here is the repo you should ask in: https://github.com/MicrosoftDocs/Edge-Enterprise/
Hope this helps!

@captainbrosset Thank you very much for your response and the information provided. I do appreciate it.
Kind Regards
Caleb


Mta browse page mvp functionality

Approving to keep things moving, but do look at the comments

I made the minor changes,  I would prefer to make the destructuring changes  and filtering w/o DOM elements changes during the "integration" PR so that I am not introducing new bugs. I don't have access to data atm and will be coding blind. Happy to discuss ofc

I had a little extra time this morning  and I got those props destructures done :)


[BLIP2] The number of layers in ViT-L is confusing.

Thank you for this amazing work and the releasing codes.
According to the description in your paper, the ViT-L used in BLIP2 should be 23 layers.

For the frozen image encoder, we explore two state-of-the-art pre-trained vision transformer models: (1) ViT-L/14 from CLIP (Radford et al., 2021) and (2) ViT-G/14 from EVA-CLIP (Fang et al., 2022). We remove the last layer of the ViT and uses the second last layer’s output features, which leads to slightly better performance

However, it is set to 22 layers in the code, which should be 23.
https://github.com/salesforce/LAVIS/blob/36d1e988caa977c96d4fe237a61845ec5053b3df/lavis/models/clip_vit.py#L233-L240
What confuses me even more is that you have removed another layer during building the model, so there are actually only 21 layers in use.
https://github.com/salesforce/LAVIS/blob/36d1e988caa977c96d4fe237a61845ec5053b3df/lavis/models/clip_vit.py#L162-L167
Is this a bug?

I am also confused. The number of layers of eva-vit-g is correct

I am confused too.Does the ViT-L understood by the author have a total of 24 layers, including the first two layers (conv1 and ln_pre)? Then remove the last output layer, leaving 23 layers, so there are 21 ResidualAttentionBlock in total?


[Compute] Add missing tests for vmss redeploy and perform maintenance.

Generated code were already merged by https://github.com/Azure/azure-sdk-for-net/pull/4129, but this PR contains the Swagger spec update of
https://github.com/Azure/azure-rest-api-specs/pull/2589
However, the tests for this Swagger spec updated were not included in the previous PR, so this PR adds the tests for the above Swagger spec update.

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please add REST spec PR link to the SDK PR
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@hyonholee once the CI passes, this is good to be merged


JiT with Azure Firewall

When using JiT with Azure Firewall, I've observed some odd behaviour.
If you let the requester specify the IP/range to be allowed as the source for the connection, JiT will configure a DNAT rule on the Firewall with the source as specified. Fine. But JiT will then configure the NSG rule with the same source. The problem here is that the VM sees the traffic as coming from the Firewall, not from the real source IP. So the NSG doesn't let the traffic through.  The NSG rule should have the address space of the Firewall subnet as the source.
If, in the JiT policy, you force the use of a certain range as the source and use the Firewall subnet range here, the NSG rule is opened up correctly but the Firewall DNAT rule is then wrong - its source IP should be the real IP but of course it uses the same Firewall subnet range.
So what I've had to do is use the Firewall range in the policy so the NSG rule is good but then use my own DNAT rule to get in through the Firewall. The DNAT rule created by JiT is not used. This means that the connection info shown in the JiT screen is wrong as the port used is different - one has to remember to use the port in the DNAT rule you created, not the port JiT wants to use.
There's also another less critical issue. My Firewall has 3 PIPs and I want to use #3 for inbound RDP connections. The DNAT rule that JiT creates (albeit I'm not using it) uses PIP #1 - it would be good if the JiT config could give you a choice of which PIP you want the connections to come in on.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 25f0758b-8274-d2b5-4702-2c7ca6b0b14a
Version Independent ID: d1215107-abf9-fefd-a63b-b20ec3f7f744
Content: Just-in-time virtual machine access in Azure Security Center
Content Source: articles/security-center/security-center-just-in-time.md
Service: security-center
GitHub Login: @memildin
Microsoft Alias: memildin

I have experienced the same issue and resolved it in a similar way to scenario described above, which is:

If you let the requester specify the IP/range to be allowed as the source for the connection, JiT will configure a DNAT rule on the Firewall with the source as specified. Fine. But JiT will then configure the NSG rule with the same source. The problem here is that the VM sees the traffic as coming from the Firewall, not from the real source IP. So the NSG doesn't let the traffic through. The NSG rule should have the address space of the Firewall subnet as the source.

@SaurabhSharma-MSFT any updates on this?

@ChrisSommers @kutluomeroglu can you share your subscription Id by using email - AzCommunity[at]microsoft[dot]com including this issue link so that I can investigate it.

@ChrisSommers Apologies for the delay. Based on internal discussion it looks like it is a requirement to have an inbound rule where we allow traffic from firewall private IPs on the NSG which is infront of the VM due to Azure Firewall doing SNAT.
Please refer to the documentation provided here.

@ChrisSommers We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


fix: padding and line break on buyer guarantee page

This PR:

Adds padding to The Artsy Guarantee table on Mobile and Desktop

Creates a line break for the Money-Back Guarantee Passage

Jira Ticket: PURCHASE-2699

LGTM! Feel free to merge when you're ready!

I noticed one thing...we have a media wrapper around these components to render one grid or the other based on the screen size. I noticed there are no padding changes on the mobile/xs breakpoint (https://github.com/artsy/force/blob/08dc2f5bd0da8b4b61987566ee38bb7fbd3401c3/src/v2/Apps/BuyerGuarantee/Routes/BuyerGuaranteeIndex.tsx#L448). Is that intentional or did we want to add it to both?


Refactor/replace behaviour mess

@bobthemighty wouldn't it be preferable to keep the subscribe_to create_subscription interface and not introduce special methods for subscribing to $all but rather enable those methods to handle $all?

I had a lengthy debate with the developers at Made about the iter/iter_all
split. I would have preferred to keep the same method, but pass some
sentinel value to represent the all stream.
In practice, though, the paging is also different, since $all uses global
positions rather than event numbers.
We decided it was better to duplicate the methods on Client and be explicit
about the difference.
That said, there's a LOAD of duplication in the conversations module that
I'll refactor out, but I just wanted to get a working prototype together
for you and Brandon.
On Mon, 15 Apr 2019, 11:08 betaboon<EMAIL_ADDRESS>wrote:

@bobthemighty https://github.com/bobthemighty wouldn't it be preferable
to keep the subscribe_to create_subscription interface and not introduce
special methods for subscribing to $all but rather enable those methods
to handle $all?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/madedotcom/photon-pump/pull/139#issuecomment-483191281,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADGzZXS7h2qv8XVRqUT7AjSKA6LDrY1ks5vhE-ZgaJpZM4cu21H
.

thanks for the insight :)


Limiting the file types to upload

What is the best way to limit the type of the file that can be uploaded? For example I want to allow users to upload *.docx and *.pdf only

Right here => https://github.com/spring-guides/gs-uploading-files/blob/master/complete/src/main/java/hello/FileUploadController.java#L44-L53
You have the opportunity to screen for what is acceptable and plug in your own rules.


fix: Message is shown if edittext is empty.

Fixes #203
Changes: If edit text is empty and the user presses the fab to send, a toast is shown and no action is taken.
Screenshots for the change:

@adityastic @anhanh11001 please review.

@adityastic I made the change you told as well as another thing. Please review the pr again.

Please also resolved conflicts.


Add bootc build commit

This should take over the role of ostree container commit, however following up on https://github.com/ostreedev/ostree-rs-ext/pull/569 we can change our thoughts on /var.

Can you sketch out where bootc build commit would be called?  Dockerfile/Buildah?

Yes as part of a RUN invocation

@cgwalters any reason for this not to be a pass-thru to ostree-ext for now?

One reason is we kind of just did a pivot around our handling of /var since https://github.com/ostreedev/ostree-rs-ext/pull/569 - and while this needs more testing and validation - we may want to degrade the /var bits to a warning for example.
A tricky thing about making it a literal re-exec style passthrough is right now ostree container is shipped by rpm-ostree, and ultimately we want to support bootc-only images, so we probably want to expose the container commit processing as a Rust API.  Or possibly we split it out into a separate component/package.

Just a heads up that we are working this issue on our mobbing sessions. Specially based on this comment:
https://github.com/containers/bootc/pull/217#issuecomment-1864960639
I am not sure if this is intended to intersect with: #367

I'm a bit uncertain about doing this versus offering a container image that can work as part of a multi-stage build and do this stuff.  That's inherently maximally flexible and avoids shipping potentially all sorts of tools in smaller images.
i.e. we'd document:
FROM quay.io/someuser/useros:latest as rootfs
FROM quay.io/exampleos/bootc-image-tool
RUN --mount=type=bind,from=rootfs,target=/sysroot bootc-image-scan /sysroot

Now don't get me wrong, it does seem quite convenient to ship basic scanning stuff as part of the image itself so you can just stick a RUN bootc build-scan or whatever as part of your single image flow...but on the flip side, this isn't something that exists in the podman/docker ecosystem by default.
If we take the "bootc does one thing and does it well" philosophy then this may end up being outside it, right?
I could go either way...
BTW one thing that we should have a basic lint checker for is having a single kernel (like rpm-ostree does).

If we take the "bootc does one thing and does it well" philosophy then this may end up being outside it, right?

I can always be persuaded by the original Unix philosophy. I say we close this then.

I keep going back and forth honestly :smile:
One thing here is that while we have a stance that bootc is not a build system (you can use any container build system) there are in reality some rules it enforces specifically (such as the "one kernel" rule).
Even if we had an external tool, it could call out to bootc build-lint or whatever we call it for that set of rules.
But we should probably think about what other things we need to lint for.  There are potentially a lot...but I don't know how much is bootc specific in the end, versus "generic Linux" stuff.

OK another one we hit recently is where a user has a restrictive umask 077, and is doing a container build from a git clone that has a Dockerfile that is doing
COPY usr /usr

Since the copy will preserve permissions (without --chmod) then we end up overwriting /usr with permissions 0700 which will just break running any code as non-root.
I think we should probably lint against this by default.  There's not a really good use case for having /usr be permissions 0700.
As for a larger fix for this case...well, it's probably not going to be viable in reality to force everyone doing git clones to reset the umask to 022.
A COPY --chmod=0755 will work, but will also make all files unnecessarily executable.  The simplest thing may be to show a pattern of splitting up data and executables via e.g.:
COPY --chmod=0755 usr-exe /usr
COPY --chmod=0644 usr-data /usr

Where usr-exe holds executables, and usr-data holds non-executables.
There is also https://docs.docker.com/reference/dockerfile/#copy---link - but we still need to canonicalize the permissions in that case.

@cgwalters, I feel this issue isn't actionable yet.  Shall we groom it or is it a WIP?

Looks like https://github.com/containers/bootc/pull/381 helps but does not fully fixes this.


Add link to creating symbol packages to quickstart

OPS Build status updates of commit 6804143:
:clock10: Preparing: average preparing time is 40 sec(s)

OPS Build status updates of commit 6804143:
:clock10: Incremental building: average incremental building time is 22 sec(s)

OPS Build status updates of commit 6804143:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/quickstart/create-and-publish-a-package-using-the-dotnet-cli.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Upgrade to Polkadot v1.6.0

Issue #37.

@gianfra-t please link to the relevant ticket

@prayagd #37 I put in the description, you mean the master one?


AV-4535 feat(us_verification): adding transient id field to us verification a…

Adding transient id to us verification

closed for this https://github.com/lob/lob-go/pull/30


The default "source" module determined by Logger/LogHandler is usually wrong

Expected behavior
Given this package layout:
.
|- Package.swift
 |- Sources
  |- ModuleA
   |- Subdir1
    |- Impl.swift
  |- ModuleB
   |- Subdir1
    |- Impl.swift

If I perform someLogger.info("hello") in ModuleA/Subdir1/Impl.swift and someLogger.info("world") in ModuleB/Subdir1/Impl.swift, I expect that the source parameters which reach the underlying LogHandler will be, respectively, ModuleA and ModuleB.
Actual behavior
In practice, the source parameter will be Subdir1 in both calls.
SwiftLog version/commit hash
SwiftLog 1.3.0
Swift & OS version (output of swift --version && uname -a)
Apple Swift version 5.3 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin19.5.0
Darwin macbookpro.local 19.5.0 Darwin Kernel Version 19.5.0: Tue May 26 20:41:44 PDT 2020; root:xnu-6153.121.2~2/RELEASE_X86_64 x86_64

Further information
This is the natural result of using what is essentially basename(dirname(#file)) as the default for source in Logger.currentModule(filePath:) (https://github.com/apple/swift-log/blob/57c6bd04256ba47590ee2285e208f731210c5c10/Sources/Logging/Logging.swift#L762) and Logger.log(level:_:metadata:source:file:function:line:) (https://github.com/apple/swift-log/blob/57c6bd04256ba47590ee2285e208f731210c5c10/Sources/Logging/Logging.swift#L75). It assumes that all or most packages will use a flat structure for their source files beneath the "per-module" level. This is not the case for the vast majority of packages in, e.g., Vapor (see any of several repositories listed under https://github.com/vapor/ ), and in other common usage in large projects. Because this default is declared on Logger's log() method, it is difficult to override it via, for example, a project's choice of LogHandler, with the result that this new source parameter (otherwise a very useful input) must be ignored in favor of continuing to use such problematic solutions as parsing #file or #filePath (the irony that this behavior is also the cause of this very issue is not lost on me!).

Damn, feeling silly this slipped through when we were talking about source for weeks 😥
Will ponder some more soon and try to see if a "real" solution is anywhere near in sight...

Marked as 1.3.1 but I don't think we'll actually solve it there, just a reminder for myself to poke around some more.

Is this easy to fix now that we have #fileID which should always start with Module/?

Do you want to send in a PR @porglezomp ? That'd help a lot :-)

It looks like this is actually already fixed in Swift 5.3+, with PR #187.
The behavior is tested in LoggingTest.testLogsEmittedFromSubdirectoryGetCorrectModuleInNewerSwifts, so I think it's safe to close this issue?

Excellent, thanks for the info and sorry I missed the reply here way back then :)


Add body bottom padding

The text can go right to the bottom now. See https://www.dropbox.com/s/eabd6bvh450hxtc/Screenshot 2018-08-16 10.21.43.png?dl=0

Closed by 5f13a3ad9e8c5638221d05a89a15752c588a8ebe


ENG-7153 - No network logic

Looks like all 4 cases are take care of

network and  collections, do nothing
network and not collecting and sessionId, start collection (taken care of in startSession())
no network and collecing, pause
no network and not collecting, no nothing

🚢


Add google-sheets component

This PR contains the basic implementation of the google-sheets component introducing google-sheets and google-sheets-stream scheme.
Users can:

Create spreadsheets
Get spreadsheets
Update/append value ranges
Get sheet values as grid data value range
Clear sheets

Looks really good thanks for this. Just one thing: I created this JIRA issue to track the component https://issues.apache.org/jira/browse/CAMEL-12950, can you please add a reference to CAMEL-12950 in the commit message? Thanks!

Reference to the JIRA issue in commit message is done. Thanks for the approval!

Thanks, I'll merge after lunch :-)

Awesome!

Merged on master, just some minor fix to codestyle, but it was really good. Thanks @christophd


duplicate code

.proto files in the /mtproto/schemas/....

duplicate files in the /mtproto/...

I think all file in schemas folder can be removed (expect scheme.tl -- it can move to parent folder) because they also exist in mtproto folder.


fix: Allow lists on FeatureTestTrait#post $params

Description**
Fixes a bug that doesn't allow to send lists in JSON format in FeatureTestTrait#post or #call('POST',.... This because it expected params to always be an associative array.
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPDoc blocks, only if necessary or adds value
[x] Unit testing, with >80% coverage
[x] User guide updated
[x] Conforms to style guide

You can test the bug by deleting is_string($index) && on line 293 of system/HTTP/RequestTrait.php and then running the tests.

Thank you for your first contribution!
Can you also add an entry to the changelog,  under the section "Bugs Fixed"?
If you're unsure how it should look, you can check previous releases.

Done

Sorry, now I see that this is about something different than I originally thought - even though you described it correctly from the beginning.
I guess it was too early for me this morning...
This is a bug in FeatureTestTrait class and should be fixed in this file. It seems to me that we should check $this->bodyFormat in the populateGlobals() method when we check the condition for post: https://github.com/codeigniter4/CodeIgniter4/blob/develop/system/Test/FeatureTestTrait.php#L382
I'm afraid the proposed changes are not the right ones. But after my slip-up, I will wait for the opinions of others.

No problem. I just patched it blindly, but surely someone more familiar with the codebase can come up with a better approach.


Changes to run e2e for private cluster

Fixes #N/A
Description
How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 82.342%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
90.32%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
5330

Relevant Lines:
6473

💛  - Coveralls


raidboss: Support for objects in trigger outputStrings

This is #5551, with some additional changes on top to resolve a few conversations.
Closes #5551.

@valarnin Sorry to step on your patch, but I wanted to get this in while it was on my mind since there's a bunch of changes after this that would be good to make.

All good, I'm fine with you taking it over. This fell a bit to the wayside due to IRL obligations.

All good, I'm fine with you taking it over. This fell a bit to the wayside due to IRL obligations.

Yeah, I figured! Did you want to take a look at the changes?


Connection denied from localhost

Describe the bug
Hello everyone,
I have this issues when I try to deploy the project on emulator, I'm running the node server on a vps
I've setup the project following the LOCAL_DEV.md file, everythings seems to work fine, when I run the command  npm run start:dev it doesn't display any error, but when I reach my server on chrome it display this:
PORT 3001 display kitty logo with sign in and signup button, but when i click on it I get a grey screen and the message "connection denied from localhost"
PORT 3000 print "not found"
PORT 8701 redirect to /accounts and display account info
PORT 5432 page not working "the page is not sanding any data"
PORT 8080 print "gRPC requires HTTP/2"
this is what the console display after I run the command:
`

<EMAIL_ADDRESS>start:dev
./scripts/run-local.sh "npm" "run" "start:dev"
lerna notice cli v4.0.0
lerna info Executing command in 3 packages: "npm run dev"
kitty-items-api: ><EMAIL_ADDRESS>dev
kitty-items-api: > tsnd src/index.ts --respawn --dev
fcl-dev-wallet: ><EMAIL_ADDRESS>dev
fcl-dev-wallet: > next dev --port 8701
kitty-items-web: ><EMAIL_ADDRESS>dev
kitty-items-web: > export PORT=3001 && react-scripts start
kitty-items-api: [INFO] Invalid Date ts-node-dev ver. 1.1.7 (using ts-node ver. 9.1.1, typescript ver. 4.3.5)
fcl-dev-wallet: Loaded env from /root/fcl-dev-wallet/.env.local
fcl-dev-wallet: (node:64624) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at /root/fcl-dev-wallet/node_modules/postcss/package.json.
fcl-dev-wallet: Update this package.json to use a subpath pattern like "./*".
fcl-dev-wallet: (Use node --trace-deprecation ... to show where the warning was created)
fcl-dev-wallet: ready - started server on <IP_ADDRESS>:8701, url: http://localhost:8701
kitty-items-web: ℹ ｢wds｣: Project is running at http://<IP_ADDRESS>:3001/
kitty-items-web: ℹ ｢wds｣: webpack output is served from
kitty-items-web: ℹ ｢wds｣: Content not from webpack is served from /root/web/public
kitty-items-web: ℹ ｢wds｣: 404s will fallback to /
kitty-items-web: Starting the development server...
fcl-dev-wallet: event - compiled successfully
kitty-items-api: Starting Flow event worker ....
kitty-items-api: fetching latest block height
kitty-items-api: Starting API server ....
kitty-items-api: Listening on port 3000!
kitty-items-api: latestBlockHeight = 20
kitty-items-api: fromBlock=20 toBlock=20 latestBlock=20
kitty-items-api: fromBlock=20 toBlock=20 latestBlock=20
kitty-items-web: Compiled with warnings.
kitty-items-web: ./src/pages/root.page.js
kitty-items-web:   Line 1:17:  'Component' is defined but never used  no-unused-vars
kitty-items-web: ./src/pages/not-found.page.js
kitty-items-web:   Line 1:17:  'Component' is defined but never used  no-unused-vars
kitty-items-web: ./src/pages/account/index.js
kitty-items-web:   Line 1:17:  'Component' is defined but never used  no-unused-vars
kitty-items-web: ./src/parts/base.comp.js
kitty-items-web:   Line 1:17:  'Component' is defined but never used  no-unused-vars
kitty-items-web: ./src/parts/auth-cluster.comp.js
kitty-items-web:   Line 1:17:  'Component' is defined but never used  no-unused-vars
kitty-items-web: ./src/parts/init-cluster.comp.js
kitty-items-web:   Line 1:17:  'Component' is defined but never used  no-unused-vars
kitty-items-web: ./src/parts/balance-cluster.comp.js
kitty-items-web:   Line 1:17:  'Component' is defined but never used  no-unused-vars
kitty-items-web: ./src/parts/market-items-cluster.comp.js
kitty-items-web:   Line 1:17:  'Component' is defined but never used  no-unused-vars
kitty-items-web: ./src/parts/account-items-cluster.comp.js
kitty-items-web:   Line 1:17:  'Component' is defined but never used  no-unused-vars
kitty-items-web: ./src/parts/market-item-cluster.comp.js
kitty-items-web:   Line 1:17:  'Component' is defined but never used  no-unused-vars
kitty-items-web: ./src/hooks/use-market-item.hook.js
kitty-items-web:   Line 45:6:  React Hook useEffect has missing dependencies: 'key' and 'setItem'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
kitty-items-web: Search for the keywords to learn more about each warning.
kitty-items-web: To ignore, add // eslint-disable-next-line to the line before.
`

I don't even know if this is a problem with the emulator, the flow api, my server or postgress (the last one in fact I'm using it for the first time)
I hope someone can help me as I have been stuck on this step for a long time now, if some information is missing to identify the problem, please write it so I am attaching it.
Thanks in advice

@fontanamichele Hey sorry to hear that. The old local instructions are getting an upgrade.
Take a look at this branch for the latest. This will get merged very soon.

First of all thank you for your time,
in your opinion, therefore, until the documentation is updated, I will not be able to test my contracts? Is there another way to deploy this dapp in "edit" mode?
I have read that releasing the contracts on the testnet implies the impossibility of modifying them independently.

anyone have any updates on this?

This should no longer be an issue.


Added support for Webdriver Standalone

The before function is currently already being called with the arguments of config, capabilities, browser.
Since the browser object will be the same, this change allows the service to be compatible with the CLI Testrunner
and WebDriver standalone. Documentation in the README and a new test has been added also.
Closes #138

See linked issue for more description

@chmanie Could you please take a look at this PR? :)

👍 Requested changes have been made, thanks for the feedback

👀  Looking into failed tests

In order to get the tests to run locally, I had to update chromedriver to v92. Not sure if this will fix the tests in the CI.

Awesome, thanks!

@christian-bromann Will a new version of this package be published to npm automatically? Apologies if this is a silly question 😅

No but just triggered the release pipeline.


update caliban example integration with the latest schema changes

See #166 for details

@paulpdaniels could you help us out with updating caliban test integration with the latest schema changes?

Completed in https://github.com/apollographql/apollo-federation-subgraph-compatibility/pull/210


New package: re-volt.RVGLLauncher version <IP_ADDRESS>a1

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Resolve #142901

Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

[!warning]
With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

Automatic Validation ended with:
(Automated response - build 867.)

https://github.com/microsoft/winget-pkgs/issues/142854


prevent caption overlap on nav grid. nav grid spacing better.

This is meant to be "atomic".
These CSS adjustments prevent caption box overlapping nav grid on certain screen sizes and spreads out the nav buttons a bit better.

what are those certain screen sizes so I can see myself?

"what are those certain screen sizes so I can see myself?"
BRB

This is from using FF's responsive mode:
(320x480; portrait)
https://www.dropbox.com/s/6d3z1dpbza0wefh/Screenshot 2016-10-12 22.54.56.png?dl=0
(320x480, landscape)
https://www.dropbox.com/s/op9ysicyiruhrqy/Screenshot 2016-10-12 22.55.40.png?dl=0
(568x320, landscape)
https://www.dropbox.com/s/3lrs5s5nwfhn8dw/Screenshot 2016-10-12 22.56.15.png?dl=0
(568x320, portrait)
https://www.dropbox.com/s/3oi3sb4cmlpuh3w/Screenshot 2016-10-12 22.57.32.png?dl=0
Those are some examples. From what I can tell, the overlap doesn't occur for small sets.

Merged the essential parts :-) Thanks!

You're welcome. To reiterate, I really appreciate your patience.
Christopher
On Oct 13, 2016 11:12 AM, "Veeck"<EMAIL_ADDRESS>wrote:

Merged the essential parts :-) Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rejas/imagelightbox/pull/57#issuecomment-253542874,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHMMn7Z9WgzwXOZkXb0YhEpo5saONbJTks5qzkpKgaJpZM4KUI0i
.

And I do yours :-)


generator.generate_slice_for_vector function only handles .c files.

Hello,
I recently ran into an error generating a patch for a repository where changes were made to both header and implementation files. It seems like the error is rooted in the implementation of the generate_slice_for_vector function in app/tools/generator.py, where it expects the vector path to contain a .c file:
def generate_slice_for_vector(vector_path, use_macro=False):
    # ...
    source_file, segment = vector_path.split(".c.")
    # ...

However, this breaks when FixMorph passes it a vectorfile that was constructed from a header file: /dirs/iotop-c-a/src/iotop.h.func_humanize_val.vec:
                        [ERROR] Crash during finding segment clones in target, after 0.100 minutes.
                        [ERROR] Transformation Failed
                        [ERROR] not enough values to unpack (expected 2, got 1)
                        [ERROR] Unexpected error during finding segment clones in target.
                        [ERROR] Runtime Error
                        [ERROR] Error. Exiting...

To update this issue, after introducing logic to properly handle whether a file is a header or source,
I was then met with this error output:
                        [ERROR] [error] neighborhood not found
                        [ERROR] Seg Code: func
                        [ERROR] PA: /dirs/iotop-c-a/src/iotop.h-humanize_val
                        [ERROR] PB: /dirs/iotop-c-b/src/iotop.h-humanize_val
                        [ERROR] PC: /dirs/iotop-c-c/src/iotop.h-turn_into_human_value
                        [ERROR] Transformation Failed
                        [ERROR] unable to evolve the code
                        [ERROR] Crash during evaluate code slices, after 0.082 minutes.
                        [ERROR] Transformation Failed
                        [ERROR] Error. Exiting...
                        [ERROR] Unexpected error during evaluate code slices.
                        [ERROR] Runtime Error
                        [ERROR] Error. Exiting...


API json seems to be from a different extension

https://github.com/quasarframework/app-extension-qcalendar/blob/dev/src/component/QCalendar.json

Oh, it is, just copied over. I haven't even started on the JSON api yet

JSON API still not done, but no longer showing QMarkdown api

available on next release


Don't pipeline degenerate loops

This PR fixes two things:

If a loop is fully degenerate, don't insert pipeline pragmas, since no loops are actually emitted.
When checking if a loop is innermost, don't take degenerate loops into account.

@manuelburger This should fix your issue with GEMV


Let Array#sort only use <=>, and let <=> return nil for partial comparability

Fixes #6608
This PR does a few things:

Array#sort and related methods used to use < and <= instead of <=>, as documented. This is fixed to only use <=>.
Merge Comparable and PartialComparable into a single type. <=> can now return nil, meaning that the two objects aren't comparable. This can be used when two objects of the same type can be compared, but not always (partial order). One such example are floats: they are usually comparable, except for NaN values.
Let Array#sort and related methods handle the case when <=> return nil, and raise an exception in that case
Let Number <=> Number return nil for the case of NaN values, but provide an optimized implementation for Int <=> Int that doesn't return nil

I ran the benchmarks provided in the PR that introduced intro sort, but only checking for sort and sort with block, and compared them to the current implementation. The performance is the same, except when <=> can return nil, in which the sorting is a bit less than 3 times slower. But that makes sense, because there's a nil check for every comparison now. I personally prefer to give a correct result than to silently fail at runtime. But this performance penalty only applies when <=> returns nil, so it's not a very common case.
The reason for removing PartialComparable and merging it with Comparable is that it's simpler to have just one module, and let it automatically indicate partial order if nil is returned. If nil isn't returned, compiling with --release should give the same performance, because the check for nil will be optimized out.
This PR also fixes the fact that even though we had PartialComparable, you couldn't sort such types (Array#sort didn't handle the possibility of nil from <=>).
Note: I replaced an Int32? restriction with U forall U to allow for sort's block to be of type Int32 or Int32?, for performance reasons. Ideally we should be able to do U < Int32? or some other condition over a free variable, but that's currently not supported. Eventually we can improve that code.

I'd suggest to add the explanation about the performance regarding Nil to the API docs.

@straight-shoota What do you suggest? Something like "You can return nil if your need partial ordering. However, that will result in a slower performance when sorting such objects. In that case, you might considering not modeling your program correctly (as you should) just so that you can gain a small performance improvement that will probably never be the bottleneck of your program"?

@straight-shoota Or, well, I could add "Note that if  there is a chance that<=> returns nil, Array#sort will perform a bit slower".  But I'd rather not to, because then many would probably try to prematurely optimize their program at the cost of a worse modeling.

No offense taken. But I think it should be worth mentioning that there is a difference in performance depending on whether Nil type is included or not. If written positively, like for completely comparable types the comparator value is not nilable and the nil check will be optimized out.
Obviously it is not a good advice to apply an incorrect comparison model just to be faster. But it is good to know that when you have a completely comparable type, that it wont waste performance on nil checks.
This was actually my most important concern when reading the PR (and your comments in #6608), how performance would play out for sorting completely comparable types vs. partially comparable types. And  I think the implementation is really great.

@straight-shoota Sounds good. Where should I add such comment? In Comparable, in Comparable#<=> or in one of the Array#sort methods?

I think I'd put it in Comparable following the description of nil return value.

@straight-shoota Added the performance note.

@asterite Could you rebase this?

@straight-shoota Done! :-)

@asterite Needs a rebase!

Rebased!

There was a recent PR that improved Comparable's docs. In this PR I had already done that so I kept my docs which also includes the fact that nil can be returned now from <=>. I should have mentioned that in the other PR to avoid wasting someone else's time.

Shouldn't the src/partial_comparable.cr file now be deleted?

Yes, but it's a breaking change to do so, so we must be a bit careful.

Unfortunately the Deprecated annotation doesn't support modules yet. I would say it should just be removed because it's not really used anywhere: https://github.com/search?l=Crystal&q=PartialComparable&type=Code.

Why don't we add a deprecation notice in the API docs and remove it in 0.29.0?

We could flag the <=> method as deprecated during 0.28 if someone wants to tackle that.
The std lib path is not ignored by default, so that should warn about PartialComparable usages.
Maybe another check for deprecated methods is to detect overrides of abstract methods with @[Deprecated].


Initial project structure

WIP, setting up the project.
I'll be adding some actual analyzers in the coming days.
Todo:

[x] Add some analyzers.
[x] Plan out a lightweight process when people want to contribute a new analyzer.
[x] Setup CI/CD
[x] Write docs

I kinda of chose Hints as F# lint uses it as well, see https://github.com/fsprojects/FSharpLint/tree/master/src/FSharpLint.Core/Rules.
Not realizing that Hint is also a Severity level as well.
We probably want to rename that folder. I never meant to use the severity levels as folder names.


Update GSoD-interest.md

Adding my proposal link for GSoD 2020 to the table.

@tharun143 could you please provide a DCO signature.

Thanks for PR @tharun143.
Just thought of giving a small hint.
You need not close the PR if you miss a sign-off for a commit, you can try this next time
$ git commit --amend --signoff

This would add the signoff to the previous commit.
I hope this helps. :smile:

I thought if doing it. But I made the PR through Github. Is there any way to add the DCO signature through Github instead of adding -s to the command. @vchrombie If you know tell me pls. This would help me in the future.

I thought if doing it. But I made the PR through Github. Is there any way to add the DCO signature through Github instead of adding -s to the command. @vchrombie If you know tell me pls. This would help me in the future.

Yes, you can do it in multiple ways. :grimacing:

(easy) You can use this extension, scottrigby/dco-gh-ui
(medium) While committing, you can add the sign-off string in the description box under the commit title
(hard) Clone the repository and the branch and sign-off using command and force push

:smile:
You can always go for the first option. Just install the extension, it will take care of the sign-off.

@vchrombie I tried the second one. But it didn't work for me. I will give another try 👍 Thanks 😄


How to apply data augmentation?

It is important that augmentation is used only on the training data, so that the validation and test data does not contain samples that are augmented copies of the training data.
I did not find a way to apply augmentation during KerasClassifier.fit.

I'm not sure what you mean by data augmentation. Could you point me to ScikitLearn or Keras docs? Thanks

@adriangb
https://www.tensorflow.org/tutorials/images/data_augmentation
In my case, data augmentation would be used to artificially increase the number of training samples by flipping each image, for example.
The keras ImageDataGenerator class also supports augmentation, but I assume it is not compatible with scikeras.
https://machinelearningmastery.com/how-to-configure-image-data-augmentation-when-training-deep-learning-neural-networks/

Why not apply augmentation to X_train before, you may ask?
Because this leads to a form of leakage into the validation split: Suppose an image is in the training split and its flipped version is in the validation split. Then the latter is too easy to predict, making the validation performance metrics look too good.

Keras does the validation split internally, it's not something that sklearn is aware of. Would making the preprocessing layers part of the model itself, as suggested by the first link you included work (see Option 1: Make the preprocessing layers part of your model)? I'd imagine since it's recommended in the tutorial it doesn't lead to any important amount of data leakage.

@adriangb  Perhaps it would, I'll have to look at it.
Alternatively, should it be possible to pass the validation dataset to the KerasClassifier constructor?

@adriangb   Adding the augmentation as layers to the network is indeed a working solution.

Thank you for coming back and sharing a solution!