[CardHeader] We can't override the header title color or the subheader title color.

Problem description
If you try to change the title or subtitle color, you can't do that, this is because the component is using a Typography component to render the text but doesn't exists any classname to override the default values.
Link to minimal working code that reproduces the issue
const style = {
  color: #fff,
};
<Card>
  <CardHeader
    title="Title"
    className={classes.header}
    classes={{
      content: classes.headerColorText,
    }}
    style={style}
  />
</Card>

Versions

Material-UI: 1.0-beta
React: All
Browser: All

You are right. What about implementing the same solution as with the DialogTitle?

Hi @oliviertassinari ,
I think is a good solution but, if you only want to use the header like title, you will need to pass the hole Typography component, maybe you can add to the Typography element the property color="inherit" or add a new class to support override the classes that the Typography object use.
Best,

I'm interested in helping out - and think I can follow along enough to go with @oliviertassinari's solution. Any objections?

@bmuenzenmeyer I was thinking of the following:

We can have a disableTypography property that simply removes them and let users providing it.
We can also have a classes.title and classes.subheader customization point

The first addition is brutal and allows full customization while the addition gracefully covers 80% of the use cases.

@oliviertassinari would you expect both of these efforts to be made in the same PR? As the following will demonstrate, I think it is necessary.
In my attempts at only undertaking the second point, I have the following in CardHeader.js:

  return (
    <CardContent className={className} {...other}>
      {avatar &&

          {avatar}

}

+       <Typography type={titleType} component="span" className={classes.title}>
          {title}
        </Typography>
        <Typography
          type={subheaderType}
          component="span"
          color="secondary"
+         className={classes.subheader}
        >
          {subheader}
        </Typography>

    </CardContent>
  );
}

which only seems to work if I pass the whole classes object into <CardHeader/> like this, inside docs/../RecipeReviewCard.js
  <CardHeader
    avatar={
      <Avatar aria-label="Recipe" className={classes.avatar}>
        R
      </Avatar>
    }
+   classes={classes}
    title="Shrimp and Chorizo Paella"
    subheader="September 14, 2016"
  />

This looks to completely override the default styles of CardHeader.js, which I doubt is an intended side-effect (but does achieve the goal of being able to pass classes defined on RecipeReviewCard down into the title and subheader).
I think the main problem (I am a bit new to react, apologies), is that the render() function of <CardHeader/> does not support the composition of the title and subheader like it does the avatar... hence my first question about attempting the larger scale refactor of the Typography elements within CardHeader. I imagine exposing these as unique, "composable" components like avatar would help.
(I didn't feel this was ready for PR, so hence the long comment)

Oh, I understand, re-reading the OP, the expected usage would be.
  <CardHeader
    avatar={
      <Avatar aria-label="Recipe" className={classes.avatar}>
        R
      </Avatar>
    }
+  classes={{
+    title: classes.title,
+    subheader: classes.subheader,
+  }}
    title="Shrimp and Chorizo Paella"
    subheader="September 14, 2016"
  />

@bmuenzenmeyer You are on the right path 👍 . You can submit two PRs if you prefer.


Systematically change all the "check the results with " text with something more general.

Here's the text by @complexbrains

If you have any questions regarding the module content please ask them in the relevant module channel on the school Discord server. If you do not have access to the server and would like to join, please send us an email at school [dot] brainhack [at] gmail [dot] com.
Follow up with your local TA(s) to validate you completed the exercises correctly.

Do a run down after resolving all the maintenance

I can take care of that if you want ! @htwangtw


Surface after_import errors

Currently, if the after_import method of the importer generates an error, the ProcessImport will update the import state accordingly. However, there's no way to see the reason why the process failed, which is relevant where the after_import does most of the persisting work, ie on OrderImporter.
This change simply joins all error messages found during the Order persistence and tweaks ProcessImport so that it updates the final SolidusImporter::Import message accordingly

@cesartalves I think this looks good.
Out of curiosity, is there a reason that you're not passing an array until the very end for context[:messages], and joining them in the @import.update call? It looks like that would spare you the need to also create a confusing context[:_messages] key.
Just wanted to flag it, but I don't think it's blocking.

No reason in particular, really. I thought this was a bit more cautious because I didn't know whether I would be overriding a messages key already present on the context. But it seems to be completely unnecessary. I will adjust accordingly 👍 Thanks for flagging this


[Event Request] Codeunit 90 Purch.-Post - OnBeforeCheckTrackingAndWarehouseForShip

Hi, would it be possible to get an event OnBeforeCheckTrackingAndWarehouseForShip in codeunit 90 Purch Post, like this :

Thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


adding proxy example with HTTPS

Proposed changes

The proxy example on this page isn't great. It doesn't include HTTPS. Most environments that have a proxy for HTTP would also have one for HTTPS.
Related issues

Fixes #847

LGTM

Thanks @mstanleyjones and @johnharris85 for having a look. Thanks @frankgreco for the PR!


auth override like mission control possible?

mission control has this nice feature:where you could override the base class of its controller
Rails.application.configure do
MissionControl::Jobs.base_controller_class = "AdminController"
end
my controller looks like this:
class MissionControlController < ApplicationController
skip_before_action :require_authentication
before_action :require_admin!
private
def require_admin!
authorize :admin, :index?
end
end
you think this would be possible? or do you suggest another way without basic auth for users without devise?
thanks a lot for this excellent work

@thisIsLoading Great idea! I’ll be sure to include this feature in the next release. Thanks!


Subclasses missing in generated @JsonSubTypes

Hi,
I have the following openapi spec
openapi: 3.0.0
info:
  version: "4.0"
  title: Pet Service

paths:
  /animal:
    post:
      requestBody:
        content:
          application/json:
            schema:
              $ref: "#/components/schemas/Animal"
        required: true
      responses:
        200:
          description: OK
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/Animal"

components:
  schemas:
    Animal:
      type: object
      properties:
        name:
          type: string
      discriminator:
        propertyName: dtype
    Mammal:
      allOf:
        - $ref: '#/components/schemas/Animal'
    Nonmammal:
      allOf:
        - $ref: '#/components/schemas/Animal'
    Fish:
      properties:
        saltwater:
          type: boolean
      allOf:
        - $ref: '#/components/schemas/Nonmammal'
    Bird:
      properties:
        altitude:
          type: integer
      allOf:
        - $ref: '#/components/schemas/Nonmammal'

The resulting Animal class is only annotated with the directed descendants Mammal and Nonmammal.
@com.fasterxml.jackson.annotation.JsonSubTypes({
	@com.fasterxml.jackson.annotation.JsonSubTypes.Type(value = Mammal.class, name = "Mammal"),
	@com.fasterxml.jackson.annotation.JsonSubTypes.Type(value = Nonmammal.class, name = "Nonmammal"),
})
public abstract class Animal {
...
}

It is missing Bird and Fish. This will cause an error if Bird or Fish are posted to the server.
The correct JsonSubTypes annotation would be:
@com.fasterxml.jackson.annotation.JsonSubTypes({
	@com.fasterxml.jackson.annotation.JsonSubTypes.Type(value = Mammal.class, name = "Mammal"),
	@com.fasterxml.jackson.annotation.JsonSubTypes.Type(value = Nonmammal.class, name = "Nonmammal"),
	@com.fasterxml.jackson.annotation.JsonSubTypes.Type(value = Fish.class, name = "Fish"),
	@com.fasterxml.jackson.annotation.JsonSubTypes.Type(value = Bird.class, name = "Bird")
})
public abstract class Animal {
...
}

I cannot reproduce this, see 5996980.
May the discriminator.mapping is missing in your spec?

That was it! The missing discriminator.mapping was the problem. Thank you, Stephan.


Update to CI v4.5.2

Supersedes #224

Patch framework (v4.5.1 => v4.5.2)
composer update

$ vendor/bin/patch
$ composer update

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.727%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
244

Relevant Lines:
275

💛  - Coveralls


Fix target detection on FreeBSD

Hi,
here is a small and quick fix because on FreeBSD, arch = "amd64" so the case raises and impossible to download esbuild even if FreeBSD is supported.
iex(1)> :erlang.system_info(:system_architecture)
'amd64-portbld-freebsd13.0'

/cc @mcrumm

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


v-link-active is always there when map to '/'

Hello Evan,
Please see this jsfiddle. The class 'v-link-active' is always on the menu item 'home'.
The menu item 'home' is mapped to '/'.
Is this a bug or I just did something wrong somewhere else?

@panteng Use the exact option on v-link. ex:

Home

@rpkilby oh my word. It seems that I should read the doc more carefully :laughing:. Thanks dude.

no problem!


Ensure RawPath match Path when resolving reference

What this PR does / why we need it:
When the repo url contains URL-encoded parts, and doesn't end with /, relative downloads are not properly resolved.
Example (with a patched Gitlab):
$ helm repo add foo https://gitlab.example.org/api/v4/projects/external-packages%2fargocd/packages/helm/stable
"foo" has been added to your repositories

$ helm show chart foo/argo-cd --debug
show.go:173: [debug] Original chart version: ""
Error: failed to fetch https://gitlab.example.org/api/v4/projects/external-packages/argocd/packages/helm/stable/charts/argo-cd-3.6.5.tgz : 404 Not Found
helm.go:81: [debug] failed to fetch https://gitlab.example.org/api/v4/projects/external-packages/argocd/packages/helm/stable/charts/argo-cd-3.6.5.tgz : 404 Not Found
helm.sh/helm/v3/pkg/getter.(*HTTPGetter).get
        /home/circleci/helm.sh/helm/pkg/getter/httpgetter.go:73
helm.sh/helm/v3/pkg/getter.(*HTTPGetter).Get
        /home/circleci/helm.sh/helm/pkg/getter/httpgetter.go:41
helm.sh/helm/v3/pkg/downloader.(*ChartDownloader).DownloadTo
        /home/circleci/helm.sh/helm/pkg/downloader/chart_downloader.go:99
helm.sh/helm/v3/pkg/action.(*ChartPathOptions).LocateChart
        /home/circleci/helm.sh/helm/pkg/action/install.go:675
main.runShow
        /home/circleci/helm.sh/helm/cmd/helm/show.go:179
main.newShowCmd.func4
        /home/circleci/helm.sh/helm/cmd/helm/show.go:116
github.com/spf13/cobra.(*Command).execute
        /go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:850
github.com/spf13/cobra.(*Command).ExecuteC
        /go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:958
github.com/spf13/cobra.(*Command).Execute
        /go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:895
main.main
        /home/circleci/helm.sh/helm/cmd/helm/helm.go:80
runtime.main
        /usr/local/go/src/runtime/proc.go:204
runtime.goexit
        /usr/local/go/src/runtime/asm_amd64.s:1374

As you can see, %2f was replaced by / which leads to 404 Not found.
Workaround: Add the slash when issuing helm repo add:
$ helm repo add foo  https://gitlab.k8s.qt.insee.test/api/v4/projects/external-packages%2fargocd/packages/helm/stable/
"foo" has been added to your repositories

$ helm show chart foo/argo-cd
apiVersion: v2
appVersion: 2.0.3
dependencies:
- condition: redis-ha.enabled
  name: redis-ha
  repository: https://dandydeveloper.github.io/charts/
  version: 4.12.14
description: A Helm chart for ArgoCD, a declarative, GitOps continuous delivery tool for Kubernetes.
home: https://github.com/argoproj/argo-helm
icon: https://raw.githubusercontent.com/argoproj/argo/master/docs/assets/argo.png
keywords:
- argoproj
- argocd
- gitops
maintainers:
- name: alexec
- name: alexmt
- name: jessesuen
- name: seanson
name: argo-cd
version: 3.6.5

Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

PRs must be linked to an existing issue. If none exists, may you please open one explaining the issue and expected outcome?
Please also write tests to test and verify this PR fixes your issue. Thanks.

PRs must be linked to an existing issue. If none exists, may you please open one explaining the issue and expected outcome?
Please also write tests to test and verify this PR fixes your issue. Thanks.

Thanks @cndoit18. Issue #9764 filled.

@cndoit18 This PR has tests and it fixes my problem.

@cndoit18 Anything to do on this PR?

Note: There is a similar problem for helm dependency build here. Should I create another PR or push to this one?

@cndoit18 I went ahead and fixed the following commands:

helm install when repo_url is not ending with /
helm dependency build
helm get (ChartDownloader)
helm repo index

Please review again. I can split in 4 PRs if needed.

@cndoit18 I went ahead and fixed the following commands:

helm install when repo_url is not ending with /
helm dependency build
helm get (ChartDownloader)
helm repo index

Please review again. I can split in 4 PRs if needed.

split

I tend to split into multiple PRs

@cndoit18 I went ahead and fixed the following commands:

helm install when repo_url is not ending with /
helm dependency build
helm get (ChartDownloader)
helm repo index

Please review again. I can split in 4 PRs if needed.

I tend to split into multiple PRs

Splitted as:

#9763 + #9824: When repo URL contains encoded parts and doesn't end with slash (workaround: add trailing /)
#9822: To fix  helm dependency build. :fire: This one has no workaround
#9825: To fix helm repo index. Edge case.

For some reason CircleCI does not run on this PR. I created #9922 to try to run tests with the same commits and it has not run yet. There appears to be a partial outage... https://status.circleci.com/incidents/kxw3dyhykqkb
The webhook for this PR is consistently returning a 400 status code (and re-runs do the same thing).
Locally the commits pass tests for me. If not resolved before the next meeting we can talk about this CI issue there.

Tests pass for this. See #9922 for the passing tests. Merging.

Thanks @mattfarina! Would you also take a look at #9822?


Adding Order Page

Hello @codervivek5 ,
The Order Page is not ready yet.
Creating a order page for the website.
Kindly assign this issue.
Screenshot  :

Please assign me

@codervivek5 ,
Please assign this issue to @SakiraAli1115 👍🏻

I can contribute to the issue with a clean and efficient code. Kindly accept my issue under GSSOC'24.

change it order to Your Order

before making any changes kindly share any sample image first then start working

before making any changes kindly share any sample image first then start working

Yeah, she will.

Can you please assign me this issue i can work on it and im also working under GSSOC'24


⚠ Bofrost.ch has degraded performance

In 97617ec, Bofrost.ch (https://www.bofrost.ch) experienced degraded performance:

HTTP code: 200
Response time: 3213 ms

Resolved: Bofrost.ch performance has improved in f41f17e.


implement Echo command

Codecov Report

Merging #26 (db16faa) into master (1ef6aa1) will decrease coverage by 0.42%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #26      +/-   ##
============================================
- Coverage     70.19%   69.77%   -0.43%
  Complexity      415      415
============================================
  Files            75       77       +2
  Lines          1322     1330       +8
  Branches        137      137
============================================
  Hits            928      928
- Misses          351      359       +8
  Partials         43       43

Impacted Files
Coverage Δ

...java/seedu/address/logic/commands/EchoCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
80.00% <0.00%> (-4.22%)
:arrow_down:

.../seedu/address/logic/parser/EchoCommandParser.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef6aa1...db16faa. Read the comment docs.


Ogg parser missed RFC 3533 - Page 7

Based on RFC 3533, there are a few points to consider:
1. Note that a lacing value of 255 implies that a second lacing value follows in the packet, and a value of less than 255 marks the end of the packet after that many additional bytes.
2. A packet of 255 bytes (or a multiple of 255 bytes) is terminated by a lacing value of 0.  Note also that a 'nil' (zero length) packet is not an error; it consists of nothing more than a lacing value of zero in the header.

However, the implementation in the provided repository missed these specifications, resulting in incorrect results for certain OPUS packet parsing tasks.
I'm doing similar things recently and found we made the same mistake 😉
To rectify this issue, we need to undertake the following steps:
    const parsedSegmentTable: number[] = [];

    // RFC3533 Page 7
    let accumulatedSize = 0;

    for (const segmentSize of this.segmentTable) {
      if (segmentSize === 255) {
        accumulatedSize += segmentSize;

        continue;
      }

      if (accumulatedSize > 0) {
        accumulatedSize += segmentSize;
        parsedSegmentTable.push(accumulatedSize);
        accumulatedSize = 0;

        continue;
      }

      if (segmentSize !== 0) {
        parsedSegmentTable.push(segmentSize);
      }
    }

Good catch. I think this should be an easy fix. Another issue is edge-case where a packet can be split across multiple pages. I'll defer that until #47 is fixed.


Missing support PHPUnit 8

As mentioned https://github.com/laravel/laravel/pull/5324#issuecomment-647395330, collision 5 should support PHPUnit 8.

https://github.com/nunomaduro/collision/blob/805929cb4bb6b24ef56a28a4121eb1336803effd/src/Adapters/Laravel/Commands/TestCommand.php#L66


[Bug][worker] There are no worker groups generated in zk, and task instances are not executed

Configure worker group cxc, execute sh install.sh, check the worker group in zk, no cxc group is generated

Run the workflow, the task is not executed

Which version of Dolphin Scheduler:
-[dev]

Worker group now should be configurated in worker.properties. #2815


app restructure suggestion

Worked on this Issue: https://github.com/10secondsofcode/coding-ai/issues/17
I had some suggestion in mind:

file names
improve use of router and switch plus typos
added some comments here and there to explain what I was thinking when I changed the code :)
I left the search functionality not complete on purpose so that someone else could take it ad a task
would be nice to provide id field for the data, so that we could create the MentorProfile component

Worked on this Issue: #17
I had some suggestion in mind:

file names
improve use of router and switch plus typos
added some comments here and there to explain what I was thinking when I changed the code :)
I left the search functionality not complete on purpose so that someone else could take it ad a task
would be nice to provide id field for the data, so that we could create the MentorProfile component

@Sreilys thanks for your valuable feedback for apps suggestions. I will go through and will update the feedback. I will pull your modified changes in local and will merge. Thanks a lot your help.


Optimize TupleDomain.columnWiseUnion during dynamic filtering partition collection

Otherwise, the collection complexity is quadratic in the number of partitions.

Many thanks!


Certificate isn't integrated in rancher-ha.sh when it is generated

Rancher Version:
v1.1.0
Docker Version:
Docker version 1.10.3, build 20f81dd
OS and where are the hosts located? (cloud, bare metal, etc):
RancherOS v0.4.5
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Sigle or three nodes HA with external DB
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
Just trying to enable HA with my company certificate
Results:
The certificate isn't included in the script:
# Uncomment below to force HA enabled and not require one to set it in the UI
# export CATTLE_HA_ENABLED=true
EOF

echo Creating /var/lib/rancher/etc/server/encryption.key
if [ -e /var/lib/rancher/etc/server/encryption.key ]; then
    mv /var/lib/rancher/etc/server/encryption.key /var/lib/rancher/etc/server/encryption.key.`date '+%s'`

Expected:
To have the certificate in the script as expected

duplicate issue: https://github.com/rancher/rancher/issues/5311
we can track progress on that one.


proc/proc: Extend GoroutinesInfo to allow specifying a range

Instead of unconditionally returning all present goroutines,
GoroutinesInfo now allows specifying a range (start and count). In
addition to the array of goroutines and the error, it now also returns
the next goroutine to be processed, to be used as 'start' argument on
the next call, or 0 if all present goroutines have already been
processed.
This way clients can avoid eating large amounts of RAM while debugging
core dumps and processes with a exceptionally high amount of goroutines.
Fixes #1403

@aarzilli Thanks, I've applied your suggestions and command.go code looks cleaner now. Also, please excuse the obvious bugs. As I'm jumping from one project to the other (switching languages and coding styles along with them) I'm not able to gain enough fluency to catch them earlier.

@derekparker @aarzilli I've just updated the doc. Thanks!


[Feature]: Use the fixme and skipped annotation to report different states to azure test plans

We use test.fixme() intentionally skip broken tests, test.skip() to skip if it is not applicable for other reasons.
Both gets reported to azure test plans as 'Paused', it would be nice if the test.fixme() would be reported differently.
Also a skipped due to previouse error in cobination with test.describe.configure({ mode: 'serial' }) is reported as 'Paused'.
The fixme / skipped / other state could be detected when the testCase.status is skipped and the testCase.annotations contain the fixme annotation / skip annotation / none of them.
The test.fixme() could then be reported as 'Paused' state, the test.skip() as 'Not Applicable' state and the others as 'Blocked' state.
(All states should exisits in azure testplans, as far is i can tell by using google)
The 'Blocked' could e.g. be reached when using test.describe.configure({ mode: 'serial' }) and the first test failed, than the following tests are 'Blocked'.
For the sake of backwards compatibility the config could provide the option the map theses state differently e.g.
{
   'fixme': 'Paused',
   'skip': 'Not Applicable',
   'other': 'Blocked'
}

PW contains only this teststatus
"passed"|"failed"|"timedOut"|"skipped"|"interrupted"

and they don't contain fixme and other

it is not reported as a status, status will be skipped in any of these cases.
there should be an annotation, e.g. in the html report

@alexneo2003 do you need more input on this?

@alexneo2003 do you need more input on this?

do you offer me to additionally determine the status of the test by the type of attachment?

This is a example how the exact status of the test can be determinated:
import type { Reporter, TestCase, TestResult } from '@playwright/test/reporter';

export type ExtendedTestStatus = 'passed' | 'failed' | 'timedOut' | 'skipped' | 'interrupted' | 'fixme' | 'blocked';

class MyReporter implements Reporter {

  onTestEnd(test: TestCase, result: TestResult) {
    let state: ExtendedTestStatus;

    if (result.status == 'skipped') {
      if (test.annotations.findIndex((e) => e.type === 'fixme') != -1) {
        state = 'fixme'
      } else if (test.annotations.findIndex((e) => e.type === 'skip') != -1) {
        state = 'skipped'
      } else {
        state = 'blocked'
      }
    } else {
      state = result.status
    }

    console.log(`Finished test ${test.title} in state: ` + state);
  }

}

export default MyReporter;

@alexneo2003 is the example above working for you?


More robust version for beverage-machine & Proper distribution of matches for IPL-tournament

the PR consists...

removed code redundancy for all beverage classes...only a single function to handle all the stuff.
Round robin match scheduling to schedule matches among teams.

@kathanLunagariya just curious, if you got a chance to look at above review comments and improvize it further?

@kathanLunagariya just curious, if you got a chance to look at above review comments and improvize it further?

Thanks for reaching out to me...
Yes, I had seen the comments and also went through the mentioned resources but haven't made any changes yet.


Redirect to the CLI Extension docs?

Instead of having docs showing what's no longer applicable, can we link to the help docs for the extension instead?
These docs are more accurate and will lead to less confusion.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 41f71b1e-7a13-664a-9382-a69931e566c1
Version Independent ID: 7f44a1c2-c6a1-ead6-f286-cdf54bc6ec5c
Content: az kusto
Content Source: latest/docs-ref-autogen/kusto.yml
Service: data-explorer
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

route to CXP team


Add next-css resourceQuery options for enable/disable CSS modules.

Base on @Everettss solution
https://github.com/zeit/next-plugins/issues/97#issuecomment-377894706

I'm going to close this in favor of https://github.com/zeit/next.js/issues/8626
Thanks for your contribution 🙏


Remove examples if-then-else pattern

In bigquery example we have the following patttern:
Table table = getTable(...);
if (table == null) {
  // create table
} else {
  // load data
}

in storage we have:
Blob blob = getBlob(...);
if (blob == null) {
  // create blob
} else {
  // get and update blob's content
}

In both cases we should remove the else branch and rather execute it after table/blob creation.
Also in datastore we do:
Entity entity = getEntity(...);
if (entity = null) {
  // create entity
} else {
  // update entity access type
}

@ajkannan @aozarov @mderka Do you guys think we should remove the else branch also for datastore's example? It makes slightly less sense to me.

I agree that the datastore "else" makes a more sense because users typically won't create an entity and right away modify it.

My first reaction was that we should not change the datastore example as it is different from the big query example in that the create (the then part of the if~else) also populate the content.
However, this is also true for storage as both parts of the if~else also set the content.
Indeed, the datastore example makes more sense to me as the "else" part
is showing a way to update an entity that already exists by splitting name into
first and last name (as oppose to a complete override of the content as we do for storage)
but maybe that is too much to show for such example (not to mention that typically
this should be done transactionally which would even further complicate the example).
I do think we should modify the big query example, as suggested earlier, to remove the else
so that in the same request we create the table if needed and upload data to it.
Honestly, I think for storage best would be to split the example into 2 separate example
snippets. One for get and display (meta data and content) and one for create.
We could probably do the same for datastore or maybe add some comments to the existing
example and even big query can add a snippet for reading data.
Also, while at it, should resource manager example modified as well? replace just after create is not a typical usage pattern.
Thoughts?

I agree with the idea to split "create" and "update" actions in the snippets for storage, datastore, and resource manager.
This is probably slightly more convenient for users as well.  If they run a snippet with create/update combined and creation works, but adding/updating data errors, a user can't simply run the same snippet over again.  They'll have to modify their code because they can't create the same exact resource again.

I agree with both @ajkannan and @aozarov, i.e., splitting storage and data store into snippets, and modifying big query to create-if-needed-and-load meaning. All of them make sense. Same for resource manager---short snippets would be my preferred way.

I agree that we should split create and update, even though I wouldn't expect users to simply copy-paste snippets but rather use them to write their own first simple program.
I will take care of fixing the snippet situation as soon as #614 is merged in. I'll also try to fix #607.

Fixed by #635


Code scanning alerts reveal secrets

Unfortunately the findings in the code scanning alerts contain the secrets themselves - is that intentional?
Example: https://github.com/the-tatanka/github-action-gitleaks/security/code-scanning

Would be good for security reasons that the secrets would not be shown here too.
Maybe a "redact" flag would be good here as well.
Great action, also good that the Azure secrets are included.

ok, thnaks for the answer and the action.
Redact option for gitleaks output works as aspected.
Looks like GitHub displays the matching code snippet.


api_z1/0 not running on bosh-lite

Hi,
I'm using the latest v231 release on bosh-lite (virtualbox). On deploying the release I get the following error:
 Started updating job consul_z1 > consul_z1/0 (406f6732-1dcb-41b8-915c-f5e34c3e6881). Done (00:00:11)
  Started updating job ha_proxy_z1 > ha_proxy_z1/0 (88cc99e1-9bfb-4bd6-b926-337ff2d50881). Done (00:00:29)
  Started updating job nats_z1 > nats_z1/0 (a344b107-9de6-4b94-a3c1-28c5dcc117db). Done (00:00:12)
  Started updating job etcd_z1 > etcd_z1/0 (857a81ed-f13a-47af-94c2-ed58532e5a28). Done (00:00:29)
  Started updating job blobstore_z1 > blobstore_z1/0 (6afcffe9-632a-41ab-97f7-319071fb7a19). Done (00:00:11)
  Started updating job postgres_z1 > postgres_z1/0 (b5e86b74-415e-4b11-a84a-b91b98f65fb8). Done (00:00:09)
  Started updating job uaa_z1 > uaa_z1/0 (35f70625-9661-4872-85e2-104810138600). Done (00:00:58)
  Started updating job api_z1 > api_z1/0 (557ede7d-c3b4-40e9-8258-c4aaf9547938). Failed: `api_z1/0 (557ede7d-c3b4-40e9-8258-c4aaf9547938)' is not running after update (00:04:24)

Error 400007: `api_z1/0 (557ede7d-c3b4-40e9-8258-c4aaf9547938)' is not running after update

Task 6 error

Looking to the /var/vcap/sys/log/cloud_controller_ng_ctl.log it states
[2016-02-29 17:42:49+0000] ------------ STARTING cloud_controller_ng_ctl at Mon Feb 29 17:42:49 UTC 2016 --------------
[2016-02-29 17:42:49+0000] Checking for blobstore availability
[2016-02-29 17:43:21+0000] Blobstore is not available
[2016-02-29 17:43:36+0000] ------------ STARTING cloud_controller_ng_ctl at Mon Feb 29 17:43:36 UTC 2016 --------------
[2016-02-29 17:43:36+0000] Checking for blobstore availability
[2016-02-29 17:44:08+0000] Blobstore is not available

Any thoughts?

Hi @rahulkj
I believe the team responsible for Cloud Controller are currently investigating some issues related to the CC Blobstore on BOSH-Lite deployments.  I'll ask them to try and help you out.
/cc @utako @SocalNick

Hi @rahulkj
We have indeed been investigating some issues related to the CC blobstore on bosh-lite. We've recently added the ability to store files using WebDAV, though the default is still NFS. A couple questions to help us debug:

Is this a fresh deployment?
Are you transitioning from NFS to WebDAV?
How are you generating your bosh-lite manifest?

Best,
Frank && Jeff
CF CAPI Team

Hi,
Yes this is a fresh deployment on bosh-lite.
I generated the manifests using the https://github.com/cloudfoundry/cf-release/blob/master/scripts/generate-bosh-lite-dev-manifest using spiff
I haven't done anything special for the WebDAV. What is it that I need to do?

Hi @rahulkj,
Interesting. We have not seen this specific issue before, but we'd be happy to help you debug. Would you mind coming to our Slack channel at cloudfoundry.slack.com in the #capi channel so we could help in real time? If not, we are happy to help here.
Best,
Frank && Jeff
CF CAPI Team

@fkotsian - I'll ping you tomorrow on slack to debug this.

Closing this issue, as the stemcell I was using was really old... by using the latest 3147, the deployment went fine. Thanks @fkotsian


Capture DMX ?

Hi everyone,
First of all thank you for your work. It's a great job!
As I asked in the DMX repository a while ago : Is there a way to capture DMX input?

I would love to, but unfortunately I don't have the skills... Even less in TS :-(
Can i use DMX-TS in a non TS projet ?

Unfortunately, I don't have time for that right now...

I understand no worries. I was just asking the question ;-)


Add support for chained calls to set()

This commit adds support for chained calls to set(), such that request headers can be specified one at a time (as is possible for superagent). This addresses issue #17.

:+1: Thanks for contributing :wink:

:+1: great, thank you !

Tag 1.9.0


Incorrect edit when word wrap is enabled, line is wrapped and you make an edit on that line

Enable the setting editor.experimentalEditContextEnabled which enabled the native edit context adoption (make sure to reload the editor)
Toggle word wrap on
Resize the editor, so one of the lines is wrapped
Type on that line
Part of the line is deleted/incorrectly edited 🐛

https://github.com/user-attachments/assets/cd7ae0d3-2747-4f19-a194-a43b39c048b9

Looks like this could be an issue with the coordinate system chosen too.


Cleanup cilium/proxy golang dependencies and golang dependencies

This PR cleans up a couple of dependencies that are not really needed by cilium/proxy
After discussing with @jrajahalme we came into the conclusion that we were downloading golang dependencies to the developer VM that aren't necessary to build Cilium.
cilium/proxy will have its own Gopkg.toml file which contains the list of dependencies that envoy uses to generate the golang protobufs.
Also pinned the gops that is installed in the cilium docker image as well as pinned down the version of innefassign installed in the cilium-builder image.
Do not merge, waiting for https://github.com/cilium/proxy/pull/13 to be merged

This change is

test-me-please

test-me-please

Coverage decreased (-0.02%) to 41.933% when pulling d34b98c7a94e0b0b9bbad6b11eadf176279927f0 on pr/fix-envoy-imports into 3ad951c0cc7e793aa832b83d364b5122c8f8d9ea on master.

Testing cilium/proxy#13 to make sure cilium-envoy-builder still builds: https://quay.io/repository/cilium/cilium-envoy-builder/build/55c118c6-d14c-4d51-a158-b44f702683dc

envoy-builder build passed, cilium/proxy#13 merged. Updated proxy APIs, new cilium/proxy master SHA is c8aa9b116d3244623292255863cadd314fb88c0e.

test-me-please

test-me-please

@aanm How did you get dep ensure -v to pass with this? I get:
Solving failure: No versions of github.com/lyft/protoc-gen-validate met constraints:
	v0.0.13: Could not introduce<EMAIL_ADDRESS>as it has a dependency on github.com/golang/protobuf with constraint ^1.2.0, which has no overlap with existing constraint v1.3.1 from (root)
	d75a15c1da0f853ca31399f30c49088ca5716b04: Could not introduce github.com/lyft/protoc-gen-validate@d75a15c1da0f853ca31399f30c49088ca5716b04, as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	v0.0.14: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	v0.0.13: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	v0.0.12: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	v0.0.11: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	v0.0.10: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	v0.0.9: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	v0.0.8: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	v0.0.7: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	v0.0.6: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	v0.0.5: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	v0.0.4: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	v0.0.3: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	v0.0.2: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	v0.0.1: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	master: Could not introduce github.com/lyft/protoc-gen-validate@master, as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	apr30-protobuf-changes: Could not introduce github.com/lyft/protoc-gen-validate@apr30-protobuf-changes, as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	fix-nested-rules: Could not introduce github.com/lyft/protoc-gen-validate@fix-nested-rules, as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.
	fix-readme: Could not introduce github.com/lyft/protoc-gen-validate@fix-readme, as it is not allowed by constraint v0.0.13 from project github.com/cilium/proxy.

test-me-please

The following commit(s) from this PR were backported to v1.5:

https://github.com/cilium/cilium/commit/f27130849a88ec74f1397705c659481de63c0509


Repository description needs to be updated

Currently is Future Debian/Ubuntu package for The Lounge, should remove the future.

Done, thanks!


Unable to build from source

build fails in final yarn start in 32 bit Ubuntu MATE (trying to build as suggested in #89)
Attachment: npm-debug.log.txt
Error message:

yarn start v0.23.2
$ cross-env XDE_NPM_START=1 npm run _start

@ _start /home/raj/applications/xde
concurrently --kill-others --raw "npm run webpack" "npm run app"

@ webpack /home/raj/applications/xde
node scripts/webpack

@ app /home/raj/applications/xde
gulp rebuild && npm run electron

[21:12:08] Requiring external module babel-register

@ webpack-dev /home/raj/applications/xde
webpack -w --env.dev

/home/raj/applications/xde/node_modules/electron/index.js:9
throw new Error('Electron failed to install correctly, please delete node_modules/electron and try installing again')
^
Error: Electron failed to install correctly, please delete node_modules/electron and try installing again
at Object. (/home/raj/applications/xde/node_modules/electron/index.js:9:9)
at Module._compile (module.js:570:32)
at Module._extensions..js (module.js:579:10)
at Object.require.extensions.(anonymous function) [as .js] (/home/raj/applications/xde/node_modules/babel-register/lib/node.js:152:7)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (/home/raj/applications/xde/gulp/build-tasks.js:3:1)
npm ERR! Linux 4.4.0-72-generic
npm ERR! argv "/home/raj/.nvm/versions/node/v6.10.2/bin/node" "/home/raj/.nvm/versions/node/v6.10.2/bin/npm" "run" "app"
npm ERR! node v6.10.2
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! @ app: gulp rebuild && npm run electron
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @ app script 'gulp rebuild && npm run electron'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the  package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp rebuild && npm run electron
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/raj/applications/xde/npm-debug.log
npm ERR! Linux 4.4.0-72-generic
npm ERR! argv "/home/raj/.nvm/versions/node/v6.10.2/bin/node" "/home/raj/.nvm/versions/node/v6.10.2/bin/npm" "run" "_start"
npm ERR! node v6.10.2
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! @ _start: concurrently --kill-others --raw "npm run webpack" "npm run app"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @ _start script 'concurrently --kill-others --raw "npm run webpack" "npm run app"'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the  package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     concurrently --kill-others --raw "npm run webpack" "npm run app"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/raj/applications/xde/npm-debug.log
error Command failed with exit code 1.

throw new Error('Electron failed to install correctly, please delete node_modules/electron and try installing again')

Did you try the step suggested by the error message?

Did you try the step suggested by the error message?

That thrown node_modules/electron path not found error. nvm install v6 didn't setup node_modules/electron. npm install did setup node_modules/electron, but it was throwing up lot of syntax errors.
So, I tried to do everything from the scratch and getting different errors now:

xde-log1.txt
xde-log2.txt (after launching new terminal)

Any suggestions will be highly helpful.

@dikaiosune Any hint please? Or, am I asking too basic?

Hm, I'm not sure what would be causing that TypeError. Unfortunately we don't have enough resources to provide a lot of help and troubleshooting for building XDE from source :(. I'd recommend looking on the Electron repo for open issues and maybe looking at the script that produces that error.

For anyone watching this issue... posted to electron forum at https://discuss.atom.io/t/error-when-building-xde-from-source/42250

I'll close this because it indeed seems to be an issue with electron building on your machine. I'd try creating a simple electron project and debugging that way. Let me know if you find the solution!


Reset project feature does not give www-data permission to write

If you reset a project here's what it looks like:
-rw-r--r-- 1 root www-data   57 Nov  6 13:53 00changelog.i
-rw-r--r-- 1 root www-data   12 Nov  6 13:53 requires
drwxr-xr-x 2 root www-data 4096 Nov 28 13:15 store
-rw-r--r-- 1 root www-data    0 Nov 28  2023 thgstatus

www-data doesn't have write permission, so hg can't write to it.
This resulted in a 500 for me locally and in prod.
Here's the prod trace: https://ui.honeycomb.io/sil-language-forge/environments/prod/result/ivH7fn9QdE5/trace/c2RQAJUJBs9?fields[]=s_name&fields[]=s_serviceName&span=cb990bdf6409bf24.

I know the least about this sort of thing, but

if LexBox were running as user 33, then the umask would be 002 instead of 022, which sounds good, but that gave me an exception when it apparently tried to write to /var/www (a folder that I could never find 😆)

good catch Tim, I don't think this should be difficult as we're already setting permissions when initing a repo, we just need to recurse though the .hg folder calling File.SetUnixFileMode on each file and folder.


Important cookietemple template update 1.1.0 released!

A new release of the main template in cookietemple has just been released. This automated pull-request attempts to apply the relevant updates to this Project.
Please make sure to merge this pull-request as soon as possible. Once complete, make a new minor release of your Project.
For more information on the actual changes, read the latest cookietemple changelog.

Codecov Report

Merging #27 (97ed181) into development (1215f22) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development      #27   +/-   ##
============================================
  Coverage        39.70%   39.70%
============================================
  Files                7        7
  Lines               68       68
============================================
  Hits                27       27
  Misses              41       41

Flag
Coverage Δ

unittests
39.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1215f22...97ed181. Read the comment docs.


Return nil a video with asset.url

I can't get a video selected with this (url is asset.url):
let data = NSData(contentsOfURL: url!)
Always data returns nil

I think I can add a method to get the raw data of the selected asset like this:
pickerController.didSelectAssets = { [unowned self] (assets: [DKAsset]) in
    print("didSelectAssets")
    print(assets.map({ $0.url}))

    if let rep = assets.first?.originalAsset?.defaultRepresentation() {
        let sizeOfRawDataInBytes = Int(rep.size())
        let rawData = NSMutableData(length: sizeOfRawDataInBytes)!
        let bufferPtr = rawData.mutableBytes
        let bufferPtr8 = UnsafeMutablePointer<UInt8>(bufferPtr)

        rep.getBytes(bufferPtr8, fromOffset: 0, length: sizeOfRawDataInBytes, error: nil)
        print(rawData)
    }

    self.assets = assets
    self.previewView?.reloadData()
}

You can get the raw data of the selected asset on 2.3.5 branch like this:
let rawData = assets.first?.rawData

Very nice work dude!


Fix code snippet won't compile issue

The original code won't compile with TS compiler, due to the missing field content in the data. Add the field to eliminate compiler error.

Hi @onlyice ,
That shouldn't be the case. The Post model's content field is marked as optional:
model Post {
  id        Int     @id @default(autoincrement())
  title     String
  content   String?
  published Boolean @default(false)
  author    User    @relation(fields: [authorId], references: [id])
  authorId  Int
}

Could you confirm that your model is set up correctly?

Hi @jharrell, I can confirm that the problem is caused by the reason you stated. Thanks for your reply.


internal-error: inferior_thread: Assertion `tp' failed.

Latest release. Using GDB v7.7
1-gdb-set target-async on
2-environment-directory "c:\\dev\\trunk/Sw/A_XMC/out/obj"
3-target-select remote localhost:4444
Reading symbols from c:\dev\trunk\Sw\A_XMC\out\use\A_Myriad_A_5_9.elf...
done.
../../gdb-<IP_ADDRESS>40303/gdb/thread.c:85: internal-error: inferior_thread: Assertion `tp' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session?
(y or n) [answered Y; input not from terminal]
undefined
This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.
../../gdb-<IP_ADDRESS>40303/gdb/thread.c:85: internal-error: inferior_thread: Assertion `tp' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Create a core file of GDB?
(y or n) [answered Y; input not from terminal]

Not on the clear what this could be...

um... report the core file + log to the GDB team?

Good idea. Unfortunately not. I will do some investigations with gdb.


Fix: After going back from a thread, clicking on New Message button doesn't scroll to the new message at the bottom

Details
After going back from a thread, clicking on New Message button doesn't scroll to the new message at the bottom. This PR fixes this bug.
Fixed Issues
$ https://github.com/Expensify/App/issues/21603
PROPOSAL:  https://github.com/Expensify/App/issues/21603#issuecomment-1620319845, https://github.com/Expensify/App/issues/21603#issuecomment-1630963492
Tests

Open any LONG chat
Scroll up the chat list
Go into any sub-thread
Click Back button on Mobile or Browser to go back to the main chat
Input any text and Click on send button
Verify to scroll down to the latest/new message

Offline tests
Same above
QA Steps

Open any LONG chat
Scroll up the chat list
Go into any sub-thread
Click Back button on Mobile or Browser to go back to the main chat
Input any text and Click on send button
Should be verified to scroll down to the latest/new message

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/114150992/790e6108-80a2-4588-b3d3-cb754ab92d7c

Mobile Web - Chrome

https://github.com/Expensify/App/assets/114150992/e12ee54a-f1b8-4d92-8a90-5738237d148d

Mobile Web - Safari

https://github.com/Expensify/App/assets/114150992/6ac5da25-8627-48b5-9f33-3695ad767d71

Desktop

https://github.com/Expensify/App/assets/114150992/49f32383-c1b8-44d4-8735-980888c080e8

iOS

https://github.com/Expensify/App/assets/114150992/34254eab-1d6f-424c-bc92-f5544e1a7f65

Android

https://github.com/Expensify/App/assets/114150992/6139e300-1a6b-4986-9a30-06429643e78c

I have read the CLA Document and I hereby sign the CLA

@thesahindia, could you please review my pull request (PR)?  Please let me know if I missed anything in the PR.

@allroundexperts This is the proposal for this PR.
https://github.com/Expensify/App/issues/21603#issuecomment-1634670845
Thanks.

Hi @allroundexperts ,
thanks for your review.  this issue can't be produced on Desktop because Desktop version doesn't have the function backing to main screen from thread.
Please take a look again.

it works for desktop perfectly. i attached screen recording.
https://github.com/Expensify/App/assets/114150992/503df1ea-950a-425e-bc03-82f1cae87998

@allroundexperts i attached the screen record on Desktop in description.

@allroundexperts I added QA steps in description.

LGTM!

@allroundexperts thanks for your review.

@deetergp please review the PR and let me know if you need any updating.

@lazar-stamenkovic lint is failing and one NAB

@lazar-stamenkovic lint is failing and one NAB

@mountiny fixed lint errors.  thanks for review

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Thanks everyone!
@lazar-stamenkovic Congratulations to your first contribution! We are very glad to have you here, hope to see many more 🍾

Thanks @mountiny

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Swap cycloneDX lib for an official lib

Today we are using an in-house set of struct definitions for CycloneDX support, however, an official lib now exists: https://github.com/CycloneDX/cyclonedx-go . We can remove our in house definitions and use the official lib.

implementation related: https://github.com/anchore/syft/issues/631


Reopen with Encoding is not working on VS Code Web - Insiders

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: insiders.vscode.dev (Insiders Release)
OS Version:Windows 10

Steps to Reproduce:
1.Open insiders.vscode.dev
2.Open a file
3.Call Change File Encoding command OR Click in the Encoding Status Bar item
4.Select Reopen with Encoding
5.You will notice this error in Notification area: [object Event]
6. Looking at DevTools / Console, you will see this:
workbench.web.api.js:788
       Error: [object Event]
    at Object.b [as ensureError] (loader.js:259:22)
    at i._createLoadError (loader.js:1511:33)
    at i._onLoadError (loader.js:1522:30)
    at d (loader.js:1668:27)
    at Object.errorback (loader.js:1688:25)
    at e.triggerErrorback (loader.js:635:36)
    at loader.js:622:151
    at HTMLScriptElement.d (loader.js:658:17)

The same happens not only in the browser (insiders.vscode.dev) but also if you install it as PWA
The default encoding in VS Code is UTF-8, and the error occurs while opening not only Windows 1252 but also UTF-8 files.
Thank you

-> Clear Browser Caches

Weird, but it seems it was not necessary.
I was going to test your suggestion, but the error stopped. Probably because of the restarts/reopenings (both on browser and PWA)
Thank you

BTW, I just noticed a delay for the Syntax Highlight (md, js, html) to work in Insiders, both on web and PWA. It took about 10 min after the initial opening of an instance, before the text to be properly highlighted.
Is there any download required for that? Maybe AnyCode related?


Feature/jenkins 35828 status colors

Related to issue # JENKINS-35828
Summary of changes:

Remove baked-in margin from Favorite that will cause positioning issues when it needs to be flush-right
Fix a bug where the "noBackground" variant of LiveStatusIndicator was not correctly rendering in the queued and not_built states
@reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

🐝


Hex colors not supported: E.g. #2A3E51

Hi @mayashavin
I am trying to add a custom color. On the url it would look like this: co_rgb:2A3E51. Using the Java SDK or other SDKs, it would understand that it's not a normal color and add the "_rgb" for me.
How do I do this with your plugin?
Thank you :-)

Nevermind.... colorify to the rescue!! :-)

@bjornharvold :) great that you figured that out. I will release a package with extra tools like converting hex/hsl to the supported format soon. Thank you for using my plugin :)


Create Streetplay.html

Changed the image of street play page

I have moved the streetplay.html into events now

I have moved the streetplay.html into events now

This is the updation of the image to the street play code
Kindly check it again.

I have moved the streetplay.html into events now


[Feat]: Add OpenTelemetry Instrumentation for Google AI Studio

Overview:

This PR adds a OpenTelemetry instrumentation for monitoring Google AI Studio based LLM Applications
Changes:

New Google AI Studio Instrumentation files

Visuals (If applicable):

NA
Checklist:

[x] PR name follows conventional commit format: [Feat]: ... or [Fix]: ....
[x] Added visuals for changes (If applicable)
[x] Checked OpenLIT contribution guidelines

@sourcery-ai review


Bosma Arhinia Microphthalmia Syndrome

Hi!
I noticed that you have the following terms as synonyms of Bosma Arhinia Microphthalmia Syndrome.  You may consider on grouping all these three terms together.

arhinia, choanal atresia, and microphthalmia MONDO:0011323

arrhinia-choanal atresia-microphthalmia syndrome  MONDO:0015238

hyposmia-nasal and ocular hypoplasia-hypogonadotropic hypogonadism syndrome  MONDO:0016393

Note: In NORD we have a report entitled: "Bosma Arhinia Microphthalmia Syndrome" (we list "arrhinia-choanal atresia-microphthalmia syndrome" in the NORD list with is a synonym for Bosma Arhinia Microphthalmia Syndrome); but we also list "hyposmia-nasal and ocular hypoplasia-hypogonadotropic hypogonadism syndrome" as per Orphanet.  Therefore, I wrote a ticket to Orphanet  as both " Arrhinia-choanal atresia-microphthalmia syndrome" and "Hyposmia-nasal and ocular hypoplasia-hypogonadotropic hypogonadism syndrome" are linked to the same OMIM ID 603457 for Bosma arhinia microphthalmia syndrome.  Based in a literature review these are all the same entities. Brasseur B, Martin CM, Cayci Z, Burmeister L, Schimmenti LA. Bosma arhinia microphthalmia syndrome: Clinical report and review of the literature. Am J Med Genet A. 2016 May;170A(5):1302-7. doi: 10.1002/ajmg.a.37572. Epub 2016 Feb 3. Citation on PubMed
Gordon CT, Xue S, Yigit G, Filali H, Chen K, Rosin N, Yoshiura KI, Oufadem M, Beck TJ, McGowan R, Magee AC, Altmuller J, Dion C, Thiele H, Gurzau AD, Nurnberg P, Meschede D, Muhlbauer W, Okamoto N, Varghese V, Irving R, Sigaudy S, Williams D, Ahmed SF, Bonnard C, Kong MK, Ratbi I, Fejjal N, Fikri M, Elalaoui SC, Reigstad H, Bole-Feysot C, Nitschke P, Ragge N, Levy N, Tuncbilek G, Teo AS, Cunningham ML, Sefiani A, Kayserili H, Murphy JM, Chatdokmaiprai C, Hillmer AM, Wattanasirichaigoon D, Lyonnet S, Magdinier F, Javed A, Blewitt ME, Amiel J, Wollnik B, Reversade B. De novo mutations in SMCHD1 cause Bosma arhinia microphthalmia syndrome and abrogate nasal development. Nat Genet. 2017 Feb;49(2):249-255. doi: 10.1038/ng.3765. Epub 2017 Jan 9. Citation on PubMed
See also MedlinePlus for further clarification:  https://medlineplus.gov/genetics/condition/bosma-arhinia-microphthalmia-syndrome/

Dear @galyea123
Thank you for reaching out to the Mondo Disease Ontology, part of the Monarch Initiative!
We have received your ticket and will review it as soon as possible.
If you have any additional information or updates relevant to your inquiry, please add them in a comment on this ticket. Your input is valuable in helping us understand and resolve the issue effectively.
Thank you for your patience and for your contributions to Mondo!
Sincerely,
The Mondo Team

@galyea123 Thank you for this request!
I agree with your assessment that these terms represent the same concept and can be combined.
First, MONDO:0015238 Arrhinia-choanal atresia-microphthalmia syndrome appears to come from Orphanet:1135, but this  entity has been excluded from the Orphanet nomenclature of rare diseases and moved to Hyposmia-nasal and ocular hypoplasia-hypogonadotropic hypogonadism syndrome.
Based on this, I think that we can obsolete MONDO:0015238 and merge it with the other terms.
I also think that we can merge MONDO:0016393 into MONDO:0011323 based on the overlapping synonyms and references to the same OMIM:603457.
This would mean that we would obsolete MONDO:0015238 and MONDO:0016393 and merge these terms into MONDO:0011323.
Please let me know if this plan sounds reasonable. Thank you!


feat: Persist dev mode

Saves dev mode state in persistent store, so it's automatically enabled on app launch if it was previously enabled.
Closes #214.

Actually wanted to work on this the other day but then some other stuff happened and I was too busy again, so many thanks for taking over <3
What I was thinking by changing dev mode to be persistent we could actually drop auto-enabling it on debug builds.
The main reason it was auto-enabled on debug builds was cause having to spam click version number to switch to dev view to test some new feature and then having to repeat that process on each backend-end recompile got really annoying. By storing dev mode in persistent store, one can in turn now just enable it once  now and it'll stay on, so auto-enabling it on debug builds is technically no longer needed ^^
Would also help in decoupling debug builds vs dev mode ;)
Thoughts?

I agree with you!
Your points were addressed in a0aef64a71a0dd0b4d65735313031d6643ea0987.


Can I Remove schema qualification from the data editor query?

System information:

deepin 20.1
DBeaver enterprise  7.3.0
Additional extensions

Connection specification:

MySQL 5.6.0-UDAL-DBPROXY-2.4.0-2018-09-06T12:22:21Z
MySQL Connector Java mysql-connector-java-5.1.48 ( Revision:<PHONE_NUMBER>9c32d3ab7e5cac2e6acee69ff6b4aa )

Describe the problem you're observing:
the MySQL middleware we're using does not support scheme qualifier, either.
In addition, the UPDATE/DELETE clause generated when submitting changes made in Data Views should not include scheme qualifier for the same reason.

Steps to reproduce, if exist:
Include any warning/errors/backtraces from the logs

We already have such feature.
Press Script on the bottom toolbar after editing a table (before saving changes). Separate window will be opened with generated SQL expression. You can remove schema name there and copy the expression.

Please ask to reopen the ticket if my advice doesn't cover your needs

use fully qualified names is disabled

@kseniiaguzeeva

Hello @wowsonsun
What DBeaver version do you use?
We fixed this problem several releases back.

DBeaver Enterprise 21.0.0 @LonwoLonwo


Extract optical flow and frames

I failed to compile dense flow due to opencv version.
So I tried to extract optical flow on my own by using opencv lib.
Here, I got a question.
Did you extract frames with interval 6 or every frame?
What about optical flow with inverval 6?
What method did you use to compute optical flow? basic TVL1?
There are some lib for optical flow in opencv.
And does optical flow need to be normalized with range [0,1] for input?

Also, when I run test code with dataset configured by every frame, I got out of memory error.
I set --arch='BNInception', modality='Flow', and test_batch size=1.
The GPU is 1080ti.

Interval is 6 in most experiments. DenseFlow uses TVL1 flow algorithm. Read the TSN paper on how to process your optical flow.


Proposal: cmd mode-- accelerate timeout when a pod looks like it will fail

See discussion in #207
In cmd mode, it's possible for a pod that is executing a discrete action to enter a state from which it has little or no chance of recovering and completing successfully. In such cases, it might be prudent to detect these conditions, possibly accelerate the timeout (rather than just give up entirely), and return an error.
This is issue isn't a priority atm.

We've split steward into steward-framework, the Go SDK for Kubernetes resources and control loops, and steward-cf, the CF broker API implementation on top of steward-framework.
If and when we create a steward-cmd, which would be a command-mode implementation on top of steward-framework, we should reconsider this; closing.


[FEATURE REQUEST] suggester / GenericSuggester to support selection of multiple records from a displayed list

Is your feature request related to a problem? Please describe.
I have a quickadd script to select from a recordset retrieved from an API call to a data resource. Sometimes I see multiple records in the displayed list that are useful for me and I'd like to select more than one record at a time. Currently I have to select a record, repeat the search, select the next useful record etc.
Describe the solution you'd like
I'd like to be able to use the suggester / GenericSuggester with a parameter to indicate that I want to be able to select multiple records (perhaps with a checkbox?) and get back a list of selected records rather than a single item.

+1

GenericSuggester uses FuzzySuggestModal from the obsidian API, so I guess this request should go to the Obsidan developers directly - will open a thread on the forum.


Support Event Hubs telemetry in Python?

Thanks for this useful tutorial. Just wondering is there any timeline for the support Event Hubs telemetry in Python?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1868eeb9-a217-6c7a-4ac6-770dde264e47
Version Independent ID: 229ac447-410b-871c-624b-a7c1cbae54e9
Content: Get started with Azure IoT Hub (Python)
Content Source: articles/iot-hub/iot-hub-python-getstarted.md
Service: iot-hub
GitHub Login: @dsk-2015
Microsoft Alias: dkshir

@Xirui Thanks for the feedback! We are currently investigating and will update you shortly.


[New API] : E-commerse product Api

Hello @dishamodi0910 ,
🎯 Title and Issue Number
[New API] : E-commerse product Api
Closes #334

🗒 Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x]  I have gone through rules of when PR will get merged.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have followed proper file structure.
[x] I have gone through CONTRIBUTING GUIDELINES.md.

Output

All Products

Category

Specific Product

Thank you for contributing!❤
Don't forget to show some love by ⭐ the repository!

Hey @sivaprasath2004, Thank you for creating PR! We will review it super soon. 😇❣
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣

@sivaprasath2004 We're thrilled to inform you that your pull request has been successfully merged into the APIverse🚀🎁
Your hard work, dedication, and expertise have made a significant impact on our project, and we couldn't be more grateful for your contributions.😇
Your code will now be a part of our growing ecosystem, helping developers worldwide to create exceptional APIs.❣🔥
Happy Coding! ✨
Will See you soon❣


Playground: Gist UI Tweaks

This PR just lays out the gist/demo controls as below. Not final, not perfect, but I would certainly claim it to be releasable, while we're waiting on the design gurus.


Create setup.cfg file and mode data from setup.py

This is necessary otherwise pip does not install dependencies when called as:
pip install "slip_control @ git+https://github.com/ami-iit/slip_control"

cc @traversaro we also need a new 0.2 tag after merging

cc @traversaro we also need a new 0.2 tag after merging

Ok, can you handle merge and release? Thanks!

Sure! Thanks @traversaro.


Issue at nvet_subnet

I got this error,
containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="SubnetNotFound" Message="Could not find subnet kube4-aks-subnet in vnet kube4-vnet from resource group kube4-rg of subscription 6bea75b7-34c4-477e-bd72-02c58414d151."
│
│   with module.aks.azurerm_kubernetes_cluster.aks,
│   on modules/azure_aks/main.tf line 2, in resource "azurerm_kubernetes_cluster" "aks":
│    2: resource "azurerm_kubernetes_cluster" "aks" {
│
In file: "modules/azure_aks/variables.tf" i think here is the root of the issue
variable
variable "aks_vnet_subnet_id" {
default = null
}

If you're using the sample-input.tfvars and have not defined your own network as outlined in the sample-input-byo.tfvars sample file, that value is set here. There error message is saying that subnet is not found. Can you share your tfvars file?

****************  REQUIRED VARIABLES  ****************
These required variables' values MUST be provided by the User
prefix   = "kube5" # this is a prefix that you assign for the resources to be created
location = "westus2" # e.g., "eastus2"
ssh_public_key = "/root/.ssh/id_rsa.pub" # Name of file with public ssh key for connecting to the VMs
****************  REQUIRED VARIABLES  ****************
!NOTE!
**************  RECOMMENDED  VARIABLES  ***************
default_public_access_cidrs = ["<IP_ADDRESS>/32"] # e.g., ["<IP_ADDRESS>/32"]
**************  RECOMMENDED  VARIABLES  ***************
Tags can be specified matching your tagging strategy.
tags = {} # for example: { "owner|email" =<EMAIL_ADDRESS>"key1" = "value1", "key2" = "value2" }
From: Thomas S. Pangborn @.>
Sent: Wednesday, June 9, 2021 8:15 PM
To: sassoftware/viya4-iac-azure @.>
Cc: Henry Mora @.>; Author @.>
Subject: Re: [sassoftware/viya4-iac-azure] Issue at nvet_subnet (#163)
If you're using the sample-input.tfvars and have not defined your own network as outlined in the sample-input-byo.tfvars sample file, that value is set herehttps://github.com/sassoftware/viya4-iac-azure/blob/main/variables.tf#L550-L556. There error message is saying that subnet is not found. Can you share your tfvars file?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/sassoftware/viya4-iac-azure/issues/163#issuecomment-858184682, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUNPLY3BQJIEDTNXH7DNKGDTR77XLANCNFSM46NAASXQ.

I think if it left blank it should create a whole virtual network. Should’nt it?
Henry
From: Thomas S. Pangborn @.>
Sent: Wednesday, June 9, 2021 8:15 PM
To: sassoftware/viya4-iac-azure @.>
Cc: Henry Mora @.>; Author @.>
Subject: Re: [sassoftware/viya4-iac-azure] Issue at nvet_subnet (#163)
If you're using the sample-input.tfvars and have not defined your own network as outlined in the sample-input-byo.tfvars sample file, that value is set herehttps://github.com/sassoftware/viya4-iac-azure/blob/main/variables.tf#L550-L556. There error message is saying that subnet is not found. Can you share your tfvars file?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/sassoftware/viya4-iac-azure/issues/163#issuecomment-858184682, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUNPLY3BQJIEDTNXH7DNKGDTR77XLANCNFSM46NAASXQ.

So you are using the minimal sample file and did not set the subnet value. Yes it should create the network. I'll have to look into this. Thx.

I used the following sample file : https://github.com/sassoftware/viya4-iac-azure/blob/main/examples/sample-input-defaults.tfvars and only changed the what was needed in that file and had no issues in creating a cluster. You'll have to provide more information. Seems like your following the steps correctly.

@henmo09 any updates here? Looking for extra information. Thx.

@henmo09 this is probably the issue:
default_public_access_cidrs = ["<IP_ADDRESS>/32"] # e.g., ["<IP_ADDRESS>/32"]
This only allows 1 public ip address to hit your cluster: <IP_ADDRESS> which I do not believe that's what you intended.
If you're not familiar with CIDR blocks and/or your current network setup you might want consult with someone and choose a more appropriate value.


deis apps:run should receive stderr

From @mboersma on July 22, 2015 16:2
@Joshua-Anderson pointed out that deis run doesn't return stderr. At first glance, it looks like the canonical implementation for fleet could call paramiko's makefile_stderr function to do so. This would require similar, possibly backward-incompatible changes in the other schedulers (or no-ops), and probably in the controller models, REST API, and client(s).
Copied from original issue: deis/deis#4085

From @laurrentt on December 1, 2015 20:50
I know we're slowly getting away from fleet but I got a fix for this one if you're interested:
            def _do_ssh(cmd):
                with tran.open_session() as chan:
                    chan.get_pty() # <--- this make the stderr to show up (in order) in the output
                    chan.exec_command(cmd)


How to start script many times at same time

On windows i can run script with same name multiple times (with different params). On linux, this doesn't work. After start first script, others scripts not starting. Event onWorkerStart called just first time. How can i run same script multiple times in linux?
<?php

use Workerman\Connection\TcpConnection;

require_once dirname(__DIR__) . DIRECTORY_SEPARATOR . 'Libs' . DIRECTORY_SEPARATOR . 'init.php';

$args = getopt('', ['port:']);

global $argv;

$argv[1] = 'start';
$argv[2] = '-d';

$sw = new \Workerman\Worker('websocket://<IP_ADDRESS>:' . $args['port']);
$sw->count = 1;

$sw->onWorkerStart = function (\Workerman\Worker $worker) {
    echo $args['arg1'] . PHP_EOL; // this line called only once
};

\Workerman\Worker::runAll();

<?php
use Workerman\Connection\TcpConnection;

require_once dirname(__DIR__) . DIRECTORY_SEPARATOR . 'Libs' . DIRECTORY_SEPARATOR . 'init.php';

$args = getopt('', ['port:']);

global $argv;

$argv[1] = 'start';
$argv[2] = '-d';

// The key
\Workerman\Worker::$pidFile= __DIR__ . '/worker.' . $args['port'] . '.pid';
$sw = new \Workerman\Worker('websocket://<IP_ADDRESS>:' . $args['port']);
$sw->count = 1;

$sw->onWorkerStart = function (\Workerman\Worker $worker) {
    echo $args['arg1'] . PHP_EOL; // this line called only once
};

\Workerman\Worker::runAll();

@walkor thx, its work


Add bike share example

Add an example application to highlight frameback, using city bikes

@doug-wade - This is awesome!  What a great example!

So, this is cool.  It's a good example of the stated use-case for frameback.  But... in order to actually demonstrate the benefit the list page needs to be slow.  I haven't pulled this to try it out, yet, but something to keep in mind.  If the list page isn't slow then you're better off with normal client transitions.

@doug-wade - Hit an error trying to get this running:

@gigabo The page loads in between 2.17s and 2.24s in my testing, which is slower than the recommended 2 second page load time

Listing page

Details page

@gigabo the revision I just pushed should resolve your npm i problem.

@doug-wade - Just tried this out.  Looks like it's blocked by #228?  Details pages are failing to load for me, and that error's appearing in the log.

Oh, no, I see.  It's actually the second details page that fails, due a CORS violation.

We'll need to either pass those requests through a data endpoint or disable reuseFrame.

I did the quick 'n' dirty ™ thing and pulled reuseFrame -- I'm not ready to recommend lerna (or some other js monorepo tool) as part of our examples.

I added the rawResponse endpoint, migrated to react-server 0.3.1, and cleaned up the props.  I think this should be good to merge.

Awesome!  Looks great!


Connection Refused: Fatal Exception

My apologies if this is inappropriate to post here; I am new to Kotlin and I think that may be a big part of my problem, but I have not been able to find a solution. I have asked on a Kotlin forum but so far no response, I'm hoping someone can help me or at least point me the right way.
I have a very simple usage where I am trying to get a simple string value back from a HTTP endpoint:
try {
    Fuel.get(url, params).responseString { request, response, result ->
        handleResults(result.get())
    }
}
catch (e:Exception) {
    handleError(e)
}

But when there is a connection problem such as the server being down, I get a fatal exception that isn't handled by my catch block. This action happens when the app opens, so this is causing the app to fail completely, crashing immediately upon start. I just want to get past this so I can display an error for the user.
I have been reading about coroutines and async operations to try to find a way around this, but I haven't found anything that works with the code I'm using. I'm hoping someone can help me understand how to handle this error better?
This might be a bug, but I think it's more likely just my inexperience with Kotlin. For reference, here is the full stack trace:
E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.my.app PID: 19026
    java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:756)
     Caused by: java.lang.reflect.InvocationTargetException
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:866)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:756)
     Caused by: Connection refused
    com.github.kittinunf.fuel.core.FuelError$Companion.wrap(FuelError.kt:84)
    com.github.kittinunf.fuel.core.FuelError$Companion.wrap$default(FuelError.kt:83)
    com.github.kittinunf.fuel.core.requests.RequestTaskCallbacks.call(RequestTaskCallbacks.kt:30)
    com.github.kittinunf.fuel.core.requests.RequestTaskCallbacks.call(RequestTaskCallbacks.kt:20)
    java.util.concurrent.FutureTask.run(FutureTask.java:237)
    java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
    java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
    java.lang.Thread.run(Thread.java:761)
    Caused by: Connection refused
    com.github.kittinunf.fuel.core.FuelError$Companion.wrap(FuelError.kt:86)
    com.github.kittinunf.fuel.toolbox.HttpClient.executeRequest(HttpClient.kt:40)
    Caused by: java.net.ConnectException: Connection refused
    java.net.PlainSocketImpl.socketConnect(Native Method)
    java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:334)
    java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:196)
    java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:178)
    java.net.SocksSocketImpl.connect(SocksSocketImpl.java:356)
    java.net.Socket.connect(Socket.java:586)
    com.android.okhttp.internal.Platform.connectSocket(Platform.java:113)
    com.android.okhttp.Connection.connectSocket(Connection.java:196)
    com.android.okhttp.Connection.connect(Connection.java:172)
    com.android.okhttp.Connection.connectAndSetOwner(Connection.java:367)
    com.android.okhttp.OkHttpClient$1.connectAndSetOwner(OkHttpClient.java:130)
    com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:329)
    com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:246)
    com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:457)
    com.android.okhttp.internal.huc.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:126)
    com.github.kittinunf.fuel.toolbox.HttpClient.sendRequest(HttpClient.kt:145)
    com.github.kittinunf.fuel.toolbox.HttpClient.doRequest(HttpClient.kt:79)
    com.github.kittinunf.fuel.toolbox.HttpClient.executeRequest(HttpClient.kt:37)
    com.github.kittinunf.fuel.core.requests.RequestTask.executeRequest(RequestTask.kt:23)
    com.github.kittinunf.fuel.core.requests.RequestTask.call(RequestTask.kt:44)
    com.github.kittinunf.fuel.core.requests.RequestTask.call(RequestTask.kt:14)
    com.github.kittinunf.fuel.core.requests.RequestTaskCallbacks.call(RequestTaskCallbacks.kt:28)
    com.github.kittinunf.fuel.core.requests.RequestTaskCallbacks.call(RequestTaskCallbacks.kt:20)
    java.util.concurrent.FutureTask.run(FutureTask.java:237)
    java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
    java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
    java.lang.Thread.run(Thread.java:761)

        at com.github.kittinunf.fuel.core.FuelError$Companion.wrap(FuelError.kt:84)
        at com.github.kittinunf.fuel.core.FuelError$Companion.wrap$default(FuelError.kt:83)
        at com.github.kittinunf.fuel.core.requests.RequestTaskCallbacks.call(RequestTaskCallbacks.kt:30)
        at com.github.kittinunf.fuel.core.requests.RequestTaskCallbacks.call(RequestTaskCallbacks.kt:20)
        at java.util.concurrent.FutureTask.run(FutureTask.java:237)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
        at java.lang.Thread.run(Thread.java:761)
     Caused by: Connection refused
    com.github.kittinunf.fuel.core.FuelError$Companion.wrap(FuelError.kt:86)
    com.github.kittinunf.fuel.toolbox.HttpClient.executeRequest(HttpClient.kt:40)
    Caused by: java.net.ConnectException: Connection refused
    java.net.PlainSocketImpl.socketConnect(Native Method)
    java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:334)
    java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:196)
    java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:178)
    java.net.SocksSocketImpl.connect(SocksSocketImpl.java:356)
    java.net.Socket.connect(Socket.java:586)
    com.android.okhttp.internal.Platform.connectSocket(Platform.java:113)
    com.android.okhttp.Connection.connectSocket(Connection.java:196)
    com.android.okhttp.Connection.connect(Connection.java:172)
    com.android.okhttp.Connection.connectAndSetOwner(Connection.java:367)
    com.android.okhttp.OkHttpClient$1.connectAndSetOwner(OkHttpClient.java:130)
    com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:329)
    com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:246)
    com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:457)
    com.android.okhttp.internal.huc.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:126)
    com.github.kittinunf.fuel.toolbox.HttpClient.sendRequest(HttpClient.kt:145)
    com.github.kittinunf.fuel.toolbox.HttpClient.doRequest(HttpClient.kt:79)
    com.github.kittinunf.fuel.toolbox.HttpClient.executeRequest(HttpClient.kt:37)
    com.github.kittinunf.fuel.core.requests.RequestTask.executeRequest(RequestTask.kt:23)
    com.github.kittinunf.fuel.core.requests.RequestTask.call(RequestTask.kt:44)
    com.github.kittinunf.fuel.core.requests.RequestTask.call(RequestTask.kt:14)
    com.github.kittinunf.fuel.core.requests.RequestTaskCallbacks.call(RequestTaskCallbacks.kt:28)
    com.github.kittinunf.fuel.core.requests.RequestTaskCallbacks.call(RequestTaskCallbacks.kt:20)
    java.util.concurrent.FutureTask.run(FutureTask.java:237)
    java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
    java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
    java.lang.Thread.run(Thread.java:761)

        at com.github.kittinunf.fuel.core.FuelError$Companion.wrap(FuelError.kt:86)
        at com.github.kittinunf.fuel.toolbox.HttpClient.executeRequest(HttpClient.kt:40)
     Caused by: java.net.ConnectException: Connection refused
        at java.net.PlainSocketImpl.socketConnect(Native Method)
        at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:334)
        at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:196)
        at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:178)
        at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:356)
        at java.net.Socket.connect(Socket.java:586)
        at com.android.okhttp.internal.Platform.connectSocket(Platform.java:113)
        at com.android.okhttp.Connection.connectSocket(Connection.java:196)
        at com.android.okhttp.Connection.connect(Connection.java:172)
        at com.android.okhttp.Connection.connectAndSetOwner(Connection.java:367)
        at com.android.okhttp.OkHttpClient$1.connectAndSetOwner(OkHttpClient.java:130)
        at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:329)
        at com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:246)
        at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:457)
        at com.android.okhttp.internal.huc.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:126)
        at com.github.kittinunf.fuel.toolbox.HttpClient.sendRequest(HttpClient.kt:145)
        at com.github.kittinunf.fuel.toolbox.HttpClient.doRequest(HttpClient.kt:79)
        at com.github.kittinunf.fuel.toolbox.HttpClient.executeRequest(HttpClient.kt:37)
        at com.github.kittinunf.fuel.core.requests.RequestTask.executeRequest(RequestTask.kt:23)
        at com.github.kittinunf.fuel.core.requests.RequestTask.call(RequestTask.kt:44)
        at com.github.kittinunf.fuel.core.requests.RequestTask.call(RequestTask.kt:14)
        at com.github.kittinunf.fuel.core.requests.RequestTaskCallbacks.call(RequestTaskCallbacks.kt:28)
        at com.github.kittinunf.fuel.core.requests.RequestTaskCallbacks.call(RequestTaskCallbacks.kt:20)
        at java.util.concurrent.FutureTask.run(FutureTask.java:237)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
        at java.lang.Thread.run(Thread.java:761)

I don't think you should use get() if you don't expect it to be thrown. result.get() will throw the underlying exception inside.
The better way for you is to handle it nicely for example with result.failure. Consider the following;

I'm afraid I don't quite understand.
I expect things to work normally most of the time, but there are cases (such as the device is not connected to a network) where it fails, and the exception crashes the app.
I don't want to consume the failure result. If it fails, then there is nothing to do. I want to consume the successful result, but not get a fatal error when something goes wrong.

You are absolutely right that you should expect things to work normally and most of the time it should work. It is a valid assumption.
However, things may go wrong and error will eventually appear, users' phones might go off the grid, or as you mentioned the server may be down.
As I mentioned, I personally believe that you should have the error case without do the explicit catch. Result is designed to handle the error without explicit catch the exception, we have a couple of handy methods to handle when you face error.
Result's get() would throw the exception, if you don't want this you should probably want to handle it differently. At the very least, doing if check is probably sufficient if you don't care the failure case.
val result = ....

if (result is Result.Success) {
  //do something the value.
}


DateRollingFileStream has possible memory leak

This log4js issue would seem to point to a memory leak in DateRollingFileStream.

After testing this I couldn't find a memory leak. So closing until someone can give me more info.


Beef up tests

Currently, the tests only exercise the core converter function, but there's logic to format the input before that function is called that remains untouched by the tests.

Hi! I would like to work on this if that's alright ^^

Of course!  I'll assign it to you and you can jump right in.

Would it be okay for me to split some parts of the main function into separate functions for better/easier testing? mainly the "Sort out the optional indexed argument" and "Convert input number to base 10" sections

Absolutely.  Those probably should have been separate functions to begin with.

Realized there could always be more tests.  Leaving this open in case anyone else wants to come along and add some.


Bumping version

Codecov Report

Merging #72 (d6d903d) into main (a9132ef) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #72   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           12        12
  Lines          370       370
=========================================
  Hits           370       370

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9132ef...d6d903d. Read the comment docs.


Improve chat thread UI for better readability

Description
The current chat thread UI is hard to read and it's difficult to distinguish between User and LLM messages. The updated layout is inspired by GitHub Copilot to make it easier to read. Additionally, this new layout will allow more detailed information and options to be displayed for each thread message in future updates.

Updated the chat thread UI with a GitHub Copilot-inspired design.
Added the continue Logo SVG.
Made several minor UI improvements.

Checklist

[x] The base branch of this PR is dev, rather than main
[x] The relevant docs, if any, have been updated or created

Screenshots
Demo: https://discord.com/channels/1108621136150929458/1131313996750917835/1264192750086127646
Before:

After:

This looks great! Quick question, in the second screenshot I see the model changed. Was this the result of you changing the model between messages?

This looks great! Quick question, in the second screenshot I see the model changed. Was this the result of you changing the model between messages?

Yes, this is for the demo. I was changing models for each model to ensure it works.

Got it, thanks for clarifying. Great work on this!


Suggestion to use a switch in the circuit

I have used the circuit here  which is a simple modification to the pymcuprog UPDI diagram. You can use an FTDI device as a programming conduit as well as a serial comms device. I've tested this on my AVR4809. Do serial comms in one switch position and program the chip using pymcuprog in the other position. Hope it helps.

Hello,
I found following solution working well in application in which you would like to use FTDI chip for both programming and UART communication. It consists of smart circuit utilizing RTS signal which I tested is being switched at the beginning of programming cycle. This signal is being used to control a relay which re-routes RxD, TxD and UPDI signals. With this solution I can connect via UART immediately just after programming cycle is finished.
It works well in my case - maybe just because by simple coincidence. It works at least with current version of both pymcuprog as well as pyupdi. I hope authors of both programming scripts will not change this behavior in near future :). I hope you can find it working as well :).


Create a algorithm to calculate tax from income tax slabs.

User will give you the number of slabs in income tax layer and amount of tax to be charged (mean to say these values are variable).
Create a program to implement these and also given the same inputs you have to calculate the salary from the tax paid.
You can break this program into parts to solve. But should be under one file.

@Iltwats  can your review #108

please assign me this issue @Iltwats


Javascript errors when switching submission rules while creating a new assignment

Steps to reproduce:

start creating a new assignment
choose any of the submission rules and enter some text into the text fields, but do not submit anything
switch to another submission rule and enter some more text
observe the javascript errors start popping up in console

All js errors are similar to:
grace_periods is null
onchange()onchange (line 2)
event = change
the function at fault is:
function onchange(event) {
grace_periods.refresh();
}

I can take this one as well, Egor :) Can someone assign it to me?

Working on this fix now!