Negative KL warning even if KL='abs' and KL='full'

I'm using PPOTrainer to RLHF a llama2 model, and I sometimes get negative KL in my experiments. I've noticed that PPOTrainer prints a warning about that, even if I set kl_penalty="abs" or kl_penalty="full", even though (by my understanding) it should be impossible to get negative KL in those cases.
Two questions:

Checking the code, it looks like the KL divergence that's reported to wandb, and that is also used to determine whether the "negative KL" warning is printed, is calculated separately from the KL that is used for training; and the reported KL is always using the standard estimate. Did I understand that correctly, and does that mean I can ignore the "negative KL" warning if I'm using "abs" or "full" KL? (I can see that the non-score reward is non-positive if I use abs or full KL, and if I'm reading the code correctly the does indicate that the KL used in training is likely positive.)
Conceptually, is there any issue or drawback with using "abs" or "full" instead of "kl"?

Thank you so much!

Indeed, that might be a bug, would you like to open a PR to fix it? In general full should be fine but we have observed some issues with the KL becoming negative and then abs is safer.

Indeed, that might be a bug, would you like to open a PR to fix it? In general full should be fine but we have observed some issues with the KL becoming negative and then abs is safer.

Yes, happy to open a PR! Give me a few days.
And just to make sure my understanding of everything is correct:

With kl and negative KL, the real issue is that the negative KL leads to a positive non-score reward, and that opens up a loophole where the algorithm can get almost arbitrarily good returns just by driving down the KL into large-magnitude negative numbers.
Negative KL with kl means that the log-prob of the chosen tokens were on average less than the log-probs of those same tokens in the reference model.
That in itself (log-probs of chosen tokens being less than in the ref model) isn't necessarily an issue. It probably just means that the 'peak' of the token probability distribution decreased, i.e. the probability weight was spread out more across tokens, i.e. entropy increased. That could be indicative of an issue depending on what you're trying to do, but it doesn't have to be a problem. Is my intuition here roughly in line with how you are thinking about this?

And as an aside, can you get negative full KL? I thought KL by definition is non-negative; or is full still just an estimate pf the real KL?
Thank you so much!

All above points are correct. For the last point:

That in itself (log-probs of chosen tokens being less than in the ref model) isn't necessarily an issue. It probably just means that the 'peak' of the token probability distribution decreased, i.e. the probability weight was spread out more across tokens, i.e. entropy increased. That could be indicative of an issue depending on what you're trying to do, but it doesn't have to be a problem. Is my intuition here roughly in line with how you are thinking about this?

Since we average over a large sample it should still be mostly positive (the expected value is strictly positive but here we sample). In our experiment it usually meant you screwed something up with the generation and you are not sampling from the natural distribution of the model output. There is a full section in the docs.
This can all be quite subtle so the abs strategy was to see if you can avoid this edge cases.

All above points are correct. For the last point:

That in itself (log-probs of chosen tokens being less than in the ref model) isn't necessarily an issue. It probably just means that the 'peak' of the token probability distribution decreased, i.e. the probability weight was spread out more across tokens, i.e. entropy increased. That could be indicative of an issue depending on what you're trying to do, but it doesn't have to be a problem. Is my intuition here roughly in line with how you are thinking about this?

Since we average over a large sample it should still be mostly positive (the expected value is strictly positive but here we sample). In our experiment it usually meant you screwed something up with the generation and you are not sampling from the natural distribution of the model output. There is a full section in the docs.
This can all be quite subtle so the abs strategy was to see if you can avoid this edge cases.

Ah, yes, I've seen that discussion in the documentation. I meant, assuming the generation is working correctly, then negative estimated KL itself isn't an issue. I.e. if the kl case leads to negative KL, then assuming one has verified that generation is working correctly, simply switching to abs or full would be OK to do in general?
In any case, I've opened a PR! Thanks so much for your explanations.

Yes that's correct!


module 'nussl' has no attribute 'AudioSignal'

Description

When I import nussl and run:
history = nussl.AudioSignal('HistoryRepeatingPropellerHeads.wav')

It gives me the error in the title.
Steps/Code to Reproduce

see above
Expected Results

No error occurs
Actual Results

This output:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'nussl' has no attribute 'AudioSignal'

Versions

import platform; print(platform.platform())
Darwin-18.2.0-x86_64-i386-64bit
>>> import sys; print("Python", sys.version)
Python 3.7.1 (default, Nov  6 2018, 18:46:03)
[Clang 10.0.0 (clang-1<IP_ADDRESS>)]
>>> import numpy; print("NumPy", numpy.__version__)
NumPy 1.15.4
>>> import scipy; print("SciPy", scipy.__version__)
SciPy 1.2.0
>>> import sklearn; print("Scikit-Learn", sklearn.__version__)
Scikit-Learn 0.20.2
>>> import librosa; print("librosa", librosa.__version__)
librosa 0.6.2
>>> import nussl; print("nussl", nussl.__version__)

First, if you're using the nussl master branch, it won't work with Python 3 as far as I know. We're working on updating to Python 3. And also, yes it seems that AudioSignal is not in all for some reason! Wonder how that happened. An easy fix though, and you've done it already!
Thanks!

I was using the train branch which I saw from the other issue was expected to work in python3?

Oh great. Yes it does. If you hold up for a bit, I'm about to commit stuff into that branch (actual training code) and can include this fix!

Pushed! It still needs documentation but it all works right now.

I just noticed that the documentation also makes reference to things like nussl.Repet which doesn't exist in all. I got rid of all in the top level. That documentation should work now.

Yeah, I just noticed that too. Thanks for responding so quickly!

Should be fixed now in the pip install.


ITaskQueue should have "hasTask" function

Background
In FetchTaskThread.run method ,using getAllTasks to determine if there is a task，why not using "hasTask"
Solution
1、ITaskQueue add "boolean hasTask(String key)" function
2、ZookeeperOperator add “public boolean hasChildren(final String key)” fuction
public boolean hasChildren(final String key){
try {
Stat stat = zkClient.checkExists().forPath(key);
return stat.getNumChildren() >= 1;
} catch (InterruptedException ex) {
logger.error("hasChildren key : {} InterruptedException", key);
throw new IllegalStateException(ex);
} catch (Exception ex) {
logger.error("hasChildren key : {}", key, ex);
throw new RuntimeException(ex);
}
}

https://github.com/apache/incubator-dolphinscheduler/issues/1742

Codecov Report

Merging #1744 into dev will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev    #1744      +/-   ##
==========================================
- Coverage   20.27%   20.25%   -0.03%
==========================================
  Files         287      287
  Lines       14039    14048       +9
  Branches     2369     2370       +1
==========================================
- Hits         2847     2846       -1
- Misses      10867    10878      +11
+ Partials      325      324       -1

Impacted Files
Coverage Δ

.../dolphinscheduler/common/zk/ZookeeperOperator.java
0% <0%> (ø)
:arrow_up:

...dolphinscheduler/common/queue/TaskQueueZkImpl.java
0% <0%> (ø)
:arrow_up:

...cheduler/server/worker/runner/FetchTaskThread.java
0% <0%> (ø)
:arrow_up:

...scheduler/alert/template/AlertTemplateFactory.java
42.85% <0%> (-14.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7762a62...a1ad1b9. Read the comment docs.


Remove model parallelism references from FAQ

Description
Remove from the FAQ outdated references to model parallelism.
Model parallelism should be avoided as it is less performant than data parallelism, better accumulate gradients through multiple mini batches of small batch size rather than splitting the model to move bigger batches across GPUs.

[x] Changes are complete (i.e. I finished coding on this PR)

I just fixed the broken links in that FAQ. :expressionless:
I think content should removed if it is "bad" information, however wouldn't it be better to provide a disclaimer at the top saying This is considered less performant that x y and z and we recommend you look at this other amazing tutorial before you try the following model parallel approach. Even talk a lot more about the reasoning and provide references... but then leave the content. What if someone has some super massive model and they really, really want to do it this way anyway?

@aaronmarkham I agree, after a previous PR[1] where @indhub had written a Model parallelism tutorial, we had an offline discussion and decided that the penalty incurred by doing model parallelism when you should actually be doing data parallelism outweighed the benefit for the few users that would actually need model parallelism.
[1] https://github.com/apache/incubator-mxnet/pull/10568/files

@ThomasDelteil - I think the content is not bad like @aaronmarkham  said. It is only communicating the pros/cons and setting the right context of when is this applicable or not.
Is there any strong  need to remove this?

Agree with @sandeep-krishnamurthy comment.
@ThomasDelteil maybe you want to refine the doc a bit?

@sandeep-krishnamurthy @aaronmarkham @lupesko closing for now, will follow up with other stakeholders and see if we actually need to remove. For the records, I don't think either strongly that we should remove this FAQ


Fix #2165

Fixes #2165

Just tested and it does in fact fix the problem! Thank you @Rua @marc0246 <3


Working but laggy dungeon Integration + Mobspawning

Re-add mobspawning
Start of Blockentities
3/4 of DungeonIntegration

You can go into dungeons and move

👍


[fix][broker] Fixed getting incorrect KeyValue schema version

Fixes #21587
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report

Merging #21632 (e58be2b) into master (e1d06b5) will increase coverage by 36.46%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #21632       +/-   ##
=============================================
+ Coverage     36.83%   73.29%   +36.46%
- Complexity      376    32716    +32340
=============================================
  Files          1715     1892      +177
  Lines        131097   140706     +9609
  Branches      14318    15495     +1177
=============================================
+ Hits          48288   103137    +54849
+ Misses        76424    29462    -46962
- Partials       6385     8107     +1722

Flag
Coverage Δ

inttests
24.09% <0.00%> (-0.15%)
:arrow_down:

systests
24.64% <0.00%> (-0.28%)
:arrow_down:

unittests
72.63% <100.00%> (+40.77%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

.../pulsar/broker/admin/impl/SchemasResourceBase.java
89.32% <100.00%> (+29.32%)
:arrow_up:

...g/apache/pulsar/client/impl/HttpLookupService.java
81.25% <100.00%> (+26.37%)
:arrow_up:

.../apache/pulsar/client/impl/schema/SchemaUtils.java
75.57% <ø> (+8.39%)
:arrow_up:

... and 1455 files with indirect coverage changes


fix(diagnostics): run diagnostics thread forever

Issue

Link: https://nebraltd.slack.com/archives/C024BNQ1Y6T/p1649362757425709
Summary: Run diagnostics thread forever.

How

Was previously executing once and exiting. Thread's run method now in an infinite loop that will continue forever.
~Also added an unrelated Sonar ignore. We were previously manually ignoring this from time to time.~

Screenshots

References

Checklist

[ ] Tests added
[ ] Cleaned up commit history (rebase!)
[ ] Documentation added
[ ] Thought about variable and method names

Related to #188


feat: [CDS-92895]: improve docs for tanzu command with manifests

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screenshot.

Approved with some edits. Let me know when to merge.

thank you @roshnisarangadharan
let's merge

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65e1b4f18759c2bc4f15d266--harness-developer.netlify.app


Hyundai: remove 90° steering lockout

@gregjhogan and I found we can cut torque for two frames before a fault is imminent without any negative effects to steering. Two is required, as we're very slightly out of sync with the EPS's 100hz thread and it randomly drops our no steer request messages multiple times in a row if we only send one.
Suspected EPS fault counters from Greg:

90 degree limit: 95 frames above limit. openpilot will use an angle limit of 85 degrees, and a fault counter of 90 to allow some tolerance.
Sending torque with CF_Lkas_ActToi set to 0: Sonata supposedly only allows 4 frames, Palisade supposedly allows 10 frames. openpilot only needs two to reset 90 degree limit counter

TODO:

[x] ~Understand what role CF_Lkas_ToiFlt has here~. If you don't set this fault bit, we drop torque immediately and the outcome is very similar to an EPS-caused steering fault—a clicking noise and wheel jitter. With it, no noticeable wheel movements or sounds occur.

Related: Write panda safety to ensure we can never wind up torque with CF_Lkas_ActToi bit set to 0 and then set to 1 to effectively bypass panda torque rate limits, while also allowing us to disable CF_Lkas_ActToi for two frames while controls allowed.
Applying 255 torque continually for over 10 minutes with no faults at >400 degrees: https://imgur.com/a/1yVAX81

The thread in the firmware that controls electronic steering is separate from what reads and parses the CAN messages (the snapshot of the CAN data is passed through global variables).  If we send one message with steering disabled and then the next message with it enabled too close together, the thread controlling electronic steering may never see that we disabled steering for one frame, and the fault counter for being over 90 deg never resets.
I also found in the firmware the fault injection bit CF_Lkas_ToiFlt in the same message when set causes wind down from the last request value to zero.  This wind down first holds the last requested torque for two frames, so we can use this to prevent loss of torque while resetting the fault counter for being over 90 deg.
Another approach for ensuring the counter gets reset would be to set LKAS11.CF_Lkas_ActToi = 0 and LKAS11.CF_Lkas_ToiFlt = 1 until we see MDPS12.CF_Mdps_ToiFlt == 1.  The current approach is susceptible to a bunch of LKAS11 CAN messages getting flushed all at once due to lagging or other things happening on the CAN bus, but this approach may be slower than we want and steering torque will start to wind down.


Shutting down ActiveMQ causes a White Screen of Death on many actions

What steps does it take to reproduce the issue?

Current
Any related open or closed issues to this bug report?
https://github.com/stomp-php/stomp-php/issues/167

Also see Slack discussion

Resolved with https://github.com/Islandora/islandora/commit/d8d101e5710c42804f06eff0f6c6a4ee3c69adbd


Improve ui build

This PR improves the UI build

It extracts styles to css file on production build
it defines to use cache buster on production build
it injects the files to the ejs template & copy it to dist
applying vendor bundle code split
Improves Developer experience on TS compilation

I'm working on a redesign
Hope that it will be ready till the end of the week.

Some progress :]


Individual warp penalties

Added the ability to set distance penalties for each individual warp, since some warps are much more open-spaced than others. The penalty just adds on top of the already set warpDiff. Also changed name and description of the initial guess slightly, and reduced the slight bit of downtime from waiting until a burrow is loaded by updating more frequently (shouldn't impact performance negatively since it's just a normal function being called).

i think the penalty settings should be in the customize tab with a sub category, and i dont know if that a to advanced setting vor the avg user xD

yea i was thinking that too, but its really nice for some people (me) xD, i was like ill just make a pr so i dont have to maintain separate branch


get/set configuration parameter

Ok, this pull request is actually based on the last one (Enhanced compatibility with neo4j 3.x).
Most of the changes you see are just some codestyle changes. Existing tests are still running through.
Most important about this pull request are the two new options get-config and set-config.
Unit tests for both functions are still missing, because I don't know, if this implementation fits into the rest or you have more ideas to do this in a better way.
So right now get-config allows you to get one or multiple parameters (using *) from one, multiple or all instances. I used a "glob-like" search for parameters. I am not sure if this is the best or a regexp would be better? The problem with regexp is, that all parameter names contain a ".", which is a placeholder for a char and most people will use it "wrong". An output switch offers 3 different kind of formats (list = comparable to instances output, ini = like a ini file output, value = just the value itself to use in other scripts).
The set-config allows to set a single parameter to one, multiple or all instances. If a parameter doesn't exist yet, it will be appended to the end of the config file. It also allows to comment and uncomment an existing value in neo4j config file. I really do have trouble with the way instances are used in the CLI command:
# ineo set-config twitter param value will set "param=value" in twitter config file
# ineo set-config twitter google param value will set "param=value" in twitter and google config file
# ineo set-config -d twitter param will comment param in twitter config file like "#param=value"
BUT if you do the following by mistake and forgot the -d option than
# ineo set-config twitter google param will add "google=param" in twitter config
Also the argument handling is not easy with multiple instances, as you can see in the code. Arguments have to be processed in reverse order (somehow). Any suggestions or ideas to this?
A big concern is, that neo4j doesn't offer a config check, so next time the instance gets restarted, it might crash.

Ok, your ideas and code looks good. I will play with this pull request then I will comment about it. Also I need to review/update the roadmap and issues according this pull request and other ideas.

I rebased temp into feature/v1.1, so I changed the base for this pull request. Also I'm going to delete the temp branch.

ineo is finally mac and linux compatible again. All tests are successful with macos 10.13 and ubuntu 16.04.
sed command is a lot less capable on macos than on ubuntu. The -i option is incompatible because one of the OSes needs a space in between the option and argument, the other fails with it. Also certain "features" in regexp like "(a|b|c)" are not supported by macos. Same is true for [0-9]+. a.so.
Anyway, what is still missing in this pull request are the unit tests for the configuration actions.


Minimize all interfaces

Remove all additional data from INode and IEdge to just contains minimum possible data

It would just take too much to redo all of this... I prefer to land implementation of properties getter/setters to nodes and edges themselfs. Like you could pass a reference to dictionary with colors of nodes to each node itself. Yeah, this implementation sucks because you cannot just pass different weights, colors, positions to any method working with corresponding properties right away, but well you could make a mediator for all nodes and edges that will be able to give and set any kind of data, and change data inside of single mediator so it will change properties of all nodes and edges themselfs as well. There is a way to do work-around with this. I prefer simplicity so currently just assume you will store all data about node and edge in themselfs.


Updated iam-auth to v0.5.9 for 1.19 - 1.23

Issue #, if available:
closes #1070
related to 1.19-21, 1.20-18, 1.21-16, 1.22-9, and 1.23-3 releases on #1067
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Container automatically scrolls to top, when using dynamic sized items based on web-components

Describe the bug
We encounter strange scrolling behaviour when using tanstack-virtual with dynamically sized virtual elements like Card from @ui5-webcomponents-react.
I adapted the dynamic example from the official example sandbox
Container 1:
If you scroll down the first container to the bottom and then scroll-up, the container scrolls automatically to the top.
Container 2:
I added a plain JSX  element to the virtual-element container. -> Now scrolling and virtualization works as expected. I have no clue why this is happening.
I would appreciate some guidance if there is bug in my Card Component or this is a bug in tanstack-virtual.
Your minimal, reproducible example
https://codesandbox.io/p/sandbox/prod-dawn-xpotyh?file=%2Fsrc%2Fmain.tsx&selection=[{"endColumn"%3A35%2C"endLineNumber"%3A67%2C"startColumn"%3A35%2C"startLineNumber"%3A67}]
Steps to reproduce
Scroll down the container till bottom and then scroll up.
Expected behavior
Container should scroll up normally when reaching the bottom of the container.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform

macOS Chrome 110

tanstack-virtual version
v3.0.0 beta 52
TypeScript version
No response
Additional context
No response
Terms & Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

@veithlukas looks like it's because in time of rendering when item mount, size of is 0, then resize observer callback is triggered with real size. There is special logic when we read sizes for items before scroll offset to adjust the scroll position main to compensate the difference between estimated size and real size.
We can disbale the scroll adjustments in scrollToFn, but the real question whey initial size is 0?
https://codesandbox.io/p/sandbox/magical-ishizaka-hgdbsq


Sometimes Can't Load from Keychain

I've got another weird one, but first - I've got a commit that adds some stuff to show the logging in the app. I wasn't sure if you'd want it, so I didn't do a PR, but let me know if you'd like me to do that.
Anyway, I've got four devices I'm testing with:

iPhone 6
iPhone 5S
iPhone 5
iPad 4

When I run the Locksmith app in the simulator or build it directly to these devices everything works perfectly. Then, when I archive the app and distribute it though HockeyApp, things get weird.
The iPad and 5 also work normally, but then on both the 6 and 5S, loading doesn't work. I tap save, then I tap load and get nothing.
I've got the iOS Console app up and I'm not seeing anything there and the performRequest method isn't returning an error, so I don't know what's going on.
This is what was happening to me with the code I wrote myself and is why I got interested in Locksmith in the first place. I'm new to iOS development, so I assumed I was doing something wrong, but now I'm seeing this behavior with the Locksmith code too, so I thought I'd open an issue on it.
One thing that I'm wondering about is how TouchID could possibly play into this. One of the hardware differences between the devices that are behaving and those that aren't is that TouchID sensor - maybe that matters?
I don't know, seems like a longshot. Have you been able to get this app to work on a device where you haven't just built it directly from Xcode? I don't know if you use HockeyApp or TestFlight or something else, but I'd be very interested to know if it's working for you.
Thanks!
Jon

Hi @matthewpalmer, I got the same issue on Xcode 6.1.1 (6A2008a) and lost some hours, there doesn't seem to be a note on the master branch README, it'd be good to have it there...thanks!

@kukabi the note was removed from the readme because this issue was fixed in later versions of this library and Xcode. Sorry about you losing so much time though! Please let me know if this continues to be an issue if you update Xcode to 6.2.


Technical: improve coherence for catalogUrl usage

Please describe the task that needs to be done
Due to Multiplying architecture, time and resource constraints (and my lack of React knowledge), I incorporated changes working but which are not very robust and might be complicated to maintain. There is currently quite a mix between passing the catalogURL through properties on the React component and using the settingsManager. it would be surely better to use one way or the other only.
see https://github.com/KaotoIO/kaoto/pull/1211

already improved in the PR directly


BestValueTrigger does not work well in mpi run like multi node setting

What happened
_DistributedSnapshot with BestValueTrigger gets stuck.
code
https://gist.github.com/dhgrs/56424106e00bafee9617b0a15a028c2c
command
CUDA_VISIBLE_DEVICES=0,1 mpiexec -N 2 python3 mnist.py
Why it causes
Reporter works in all mpi processes without all reduce operation so that BestValueTrigger check different values in each process. It causes that some processes are triggered but the others are not. _DistributedSnapshot waits for all mpi processes but some of them would never finish because are not triggered.
Workaround
Apply all reduce operation manually before reporting. But is this the best way? Will ppe support auto all reduce?

I think that maybe just removing the barrier should work.
In a distributed environment the reduction step is an implicit barrier, and it gets executed every few iterations so the snapshots will be correctly synchronized.
The multinode snapshot in ChainerMN didn't have a barrier as probably they were enforcing this behavior through reduction.
https://github.com/chainer/chainer/blob/master/chainermn/extensions/_multi_node_snapshot.py

As you suggested, removing the barrier would solve _DistributedSnapshot with BestValueTrigger. But I think the core problem is BestValueTrigger.

It causes that some processes are triggered but the others are not.

Is this expected behavior?

Apparently the trigger doesnt fire equally in all the workers, I think this is expected.
I am printing here the rank first, the previous value and the actual value
0 None 1.0 fired
1 None 1.1 fired
0 1.0 2.0
1 1.1 0.1 fired
0 1.0 1.0
1 0.1 1.1
0 1.0 1.0
1 0.1 1.1


Provide to_hstring(IStringable const&) overload

Provide an overload of to_hstring for IStringable that simply returns IStringable::ToString. This will unify the stringification of WinRT classes and primitive types. This is also useful for XAML since it's only aware of to_hstring and not IStringable::ToString when using from C++/WinRT.

Where does XAML use to_hstring?

@sylveon When binding to something that's not a string to a string.

Seems like a reasonable addition.

Of course, I don't know whether that would actually be used by Xaml without changes to Xaml - you'd have to experiment first to see whether that's effective. The overload of to_hstring could also not appear beside the other overloads since it depends on Windows.Foundation.

I suppose a lot of XAML wouldn't work without Windows.Foundation anyways :P


bidname didn't refund correctly

Bidname: com
Bid timeline:

Account tokeneconomy bid on "com" with 490 EOS at 2018-06-28 15:52:45, tx is: f16069bcff6385157e8b637227af8eb50456e1b34fcabf43bab87292ee77f275

Account gi3dmnjugqge bid on "com" with 500 EOS at 2018-06-30 08:18:59, tx is: ca49a9b41316c2ba2bf8e79418bfb5389663f1a2f203992e97b7e14be5d1c7d3
This transaction was successful but it should be failed because the price 500 EOS is less than 110% of former bid price 490 EOS.
Two actions of this transaction are the same, which are also wrong.

Account starteosiobp bid on "com" with 550 EOS at 2018-06-30 16:28:46, tx is: 5d95ef88e7c5d3df033605273476b7e581fa48843f4e6915296fc7c9bfa78265
In this transaction, an action will refund bid on "com" to tokeneconomy with 490 EOS. Now the 500 EOS of gi3dmnjugqge is missing.

In general, there are two problems:
1. The above step2 should not be passed.
2. The 500 EOS of gi3dmnjugqge is missing.

Also, if gi3dmnjugqge's bid went through, tokeneconomy should have been refunded after step 2.

step2 is not real 'bidname' transaction.
Account gi3dmnjugqge just transferred 500 EOS to eosio.names with memo "bid name com".
To bid a name, you should call action "bidname" of "eosio.system" contract.
So there's nothing wrong in above 3 transactions.

@alienzin make sense, thank you.
btw, can the account get the 500 EOS back from eosio.names ?


Fix getting hostname

Coverage decreased (-0.49%) to 72.72% when pulling 24d2084d9faec8bf828e3255ab785bfa061433d0 on guidow:fix_getting_hostname into 0efb65af54bd668b2495cfd1e87ada25b83a1608 on pyfarm:master.

Coverage decreased (-0.49%) to 72.72% when pulling 24d2084d9faec8bf828e3255ab785bfa061433d0 on guidow:fix_getting_hostname into 0efb65af54bd668b2495cfd1e87ada25b83a1608 on pyfarm:master.

Ok loos good now, thanks.


DCOS-8071: Fix status dots in task detail

This adds the right coloring for task states:

Reviewer: @orlandohohmeier

This looks great! Nice work!

It's beautiful (': ✨

By the way are all states right?
\cc @leemunroe

Let's please double check it this state is valid:

Looking great. Couple of nitpicks, open to discussion if you disagree on any.

Looks like there are 2 shades of grey text going on e.g. Finished is different than Killed. Is there a good reason? I'd expect them to be the same shade.
I'm not quite sure what the sequence is of all these statuses occur, can you confirm? Created > Starting > Started > Running
Now that I see Staging as yellow I'm wondering why we decided that. I think we copied that from Marathon. Does it still make sense to call that status out as yellow?

The 2 shades of grey came from a document in which light grey was mentioned for those states. I can change that. That is also were the yellow color came from for Staging.
I am currently trying to confirm that the status sequence is right.

There are two shades of grey for the dots, but the text should be the one shade of grey so it is legible
And you're right about the yellow for staging, I just wanted to check with you guys if you had an opinion, lgtm

Updated the styles and removed the 2 shades of grey in the fonts.
The yellow is maybe drawing to much attention, staging isn't a bad state right? As a user I might be confused? I always consider red to be the color of an error and yellow being a warning / notice of unusual behaviour. This is what I do think about it.

hmm i'm currently testing it and staging looks like this:

Yeh seems odd to me. Lets make it white. We can change it in the future if we find there's a good reason to call it out.
Re. staging having a red dot, can a task be unhealthy before it is Running? Doesn't seem right to me.

All states documented in Mesos in their order:
  TASK_STAGING
  TASK_STARTING
  TASK_RUNNING

  TASK_KILLING

  TASK_FINISHED
  TASK_FAILED
  TASK_KILLED
  TASK_LOST
  TASK_ERROR

I'll check for the staging part.

Is there a reason for not coloring tasks of suspended/idle services?

This doesn't seem right...

mesosphere-ci retest this please

@orlandohohmeier i cant reproduce your 2nd screenshot. Can you ?

LGTM 💯 ✨


Reflection Document

4. Reflection
rubric={reasoning:6}
In this section,
your group should document on what you have implemented in your dashboard so far
and explain what is not yet implemented.
It is important that you include what you know is not working in your dashboard,
so that your TAs can distinguish between features in development and bugs.
Reflect on what you think your dashboard does well
what its limitations are,
and what are good future improvements and additions.
This section should not be more than 500 words
and the reflection-milestone2.md document should live in your GitHub.com repo
in the doc folder.

There is an overview in point form in the issues for what has and hasn't been done: #31 #32 #26

There is an overview in point form in the issues for what has and hasn't been done: #31 #32 #26


Drop cutlass tests

Upgraded to libcnb-* to 0.15.0
Moved all the test fixtures that were in the shared fixture folder (/test/fixtures) to the buildpack test folder of the integration test that uses them
Added or updated tests to cover previous cutlass validations
Switched all integration tests to:

use a default builder (heroku/builder:22) if the environment variable INTEGRATION_TEST_CNB_BUILDER is not set
use either composite buildpack heroku/nodejs or heroku/nodejs-function as the buildpack under test

Updated CI workflow to:

not run cutlass
pass in INTEGRATION_TEST_CNB_BUILDER to the integration test run using a strategy of heroku/builder:22 and heroku/builder:20

TODO: remove required cutlass checks once approved

Closing this massive PR.  I'm going to split this into smaller reviewable bits.


Clearfilters not working

NodeJs Version: 20.4.0
Lavalink Version: 4.0.0-beta.2
Magmastream NPM Package Version: 2.2.1
Describe the Bug
Whenever I start a filter for ex: Bassboost, it works perfectly but when I do .clearFilters(), nothing happens. I have checked for errors etc and I had no errors.
To Reproduce
Steps to reproduce the behavior:

Play the music
Turn on the filter
Wait for it to turn on
Using clearFilters will never turn it off now

Expected Behavior
It should clear all filters using clearFilters but it is not working and expected.
Screenshots
N/A
Additional Context
N/A

Just released an update to fix your issue.
npm install<EMAIL_ADDRESS>

I cannot see the fix, still the clearFliters() ain't changing a thing.

I cannot see the fix, still the clearFliters() ain't changing a thing.

What version do you have installed?

2.3.1, the newest i guess

2.3.1, the newest i guess

Can you provide code?

sure, here you go:
if (player.filters.getFilterStatus("eightD")) {
      player.filters.clearFilters();
      return client.sendMessage(
        message.channel,
        `Turned off`
      );
    } else {
      player.filters.eightD();
      return client.sendMessage(
        message.channel,
        `Turned on`
      );
    }

player.filters.clearFilters()

player.filters.clearFilters() -> await player.filters.clearFilters()

Oh jesus, I just saw in the documentation that it returns Promise, and I did not await it.... Thanks..

Oh jesus, I just saw in the documentation that it returns Promise, and I did not await it.... Thanks..


PHP syntax overview is outside of the PHP heading

Describe your problem and how to reproduce it:
A PHP syntax overview article is outside of the PHP heading.
Add a Link to the page with the problem:
https://guide.freecodecamp.org/php-syntax-overview/
Tell us about your browser and operating system:

Browser Name: Google Chrome
Browser Version: 69.0.3497.100
Operating System: Mac OS High Sierra 10.13.6

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):

Can I take this one? This would be my first ever pull request to a real issue.
To fix it I would drag the "PHP Syntax Overview" folder into the "PHP" folder here:
https://github.com/freeCodeCamp/freeCodeCamp/tree/master/client/src/pages/guide/english


Missing I18N

In a new isntalation is missing this module.

vendor.js:22732 Uncaught Error: Cannot find module "./I18N"
    at webpackMissingModule (vendor.js:22732)
    at Object.4e5f36ba1d (vendor.js:22732)
    at __webpack_require__ (vendor.js:21)
    at Object.ea7e0636b5 (vendor.js:67956)
    at __webpack_require__ (vendor.js:21)
    at vendor.js:20293
    at Object.4474af9d4d (vendor.js:20326)
    at __webpack_require__ (vendor.js:21)
    at Webiny_Webiny_Core_Vendor.0.module.exports (vendor.js:63)
    at vendor.js:68

Hey @inluxc, thank you so much for giving Webiny a go!
I just released a new tag, 1.0.1 to fix your issue.
To get the new version you can simply run composer update webiny/webiny from your project root. Run the development build after that and you should be good to go :)
Can you please tell me what environment you are using, and your host OS?
We are developing this on OSX and Ubuntu and never noticed this case letter problem.
Thank you for your time!

Using Ubuntu.

Ok, thanks! Hope it works for you now :)

Its still giving the same error... with the update.

Please update. Version 1.0.2. There was still one wrong letter.
It is interesting, however, why we can't reproduce the problem on our local machines.
Please let me know if the problem still persists.
Thanks

MacOs = case insensitive filesystem
Linux = case sensitive

Well, I am running Ubuntu on Vagrant, and my webpack builds are running on that same Ubuntu (I ssh into Vagrant box and run the cli tool from there) so Linux rules should apply. Am I missing something?


Remove API Key from Authorization Profile flow

APS is removing the Kong API Key option from the Authorization Profile flow. This feature remains available through the API for use if required and is being removed because it is not valuable for clients.
From the Authorization Profile Screen select Create Profile. The following needs to be removed from the flow:

Also confirm any options or screens that would have appeared following are updated as well. The current functionality for creating an Authorization Profile is not working via the API Services Portal UI. (https://app.zenhub.com/workspaces/bc-gov-api-services-60943b8bf73eb300102d9c97/issues/bcgov/api-services-portal/349)

@elisafw-ux  @Jonesy  @ikethecoder  Please confirm ticket is ready for addition to the Product Backlog.


Adds Carthage support

Thanks for creating this framework! I've simply made the scheme shared, and remove the README.md from the list of Compile Sources so that the project can be built using Carthage.

Thank you!


Missing states for Bahamas

I encountered an error with the API today

Request
curl --location 'https://countriesnow.space/api/v0.1/countries/states' \   --header 'Content-Type: application/json' \   --data '{       "country": "Bahamas"   }'

Response
{"error":true,"msg":"country not found"}

Is there anything wrong with my API call or is it an issue with the API data?

I notice that the country name returned from API **Get countries and ISO2&3 Codes** for Bahamas is **Bahamas**, while the actual name that is valid in API **Get single country and its states** and **Get all countries and their states** should be **Bahamas The**. Details in This API docs
This seems to be a conflict in data among the APIs.
Can you please fix this?

Hi @namln-hust yes this is a bug, Ideally the name should be "Bahamas" uniformly.

@namln-hust sorry, this took a while but it should be resolved now.


Dual editors - Text is inserted in the wrong editor instance (Post Refactoring)

In the dual editor demo page, if we enter text in the second editor, the insertion happens in the first editor.
https://user-images.githubusercontent.com/11160141/180649718-25ceba24-d2fd-48fe-986a-ed9268f352ef.mov

Well, after looking closely at this issue I figured out that actually the issue was with the demo itself. I was using the same focusNode in 2 editors.


Plugin not sending notifications from platform 6.3.0 in Android 8

Your Environment

Plugin version: 2.3.2
Platform: Android
OS version: 8.0
Device manufacturer and model: LG Nexus 5x / Samsung J7 2017
Cordova version (cordova -v): 7.1.0
Cordova platform version (cordova platform ls): android 6.3.0

Context

We've tested out Ionic 1 and Ionic 3 apps in many devices and different Android versions. The scenario is:

The default version of the android plaftorm that Cordova installed by default is 6.3.0.
Our Ionic 1 apps and new Ionic 3 ones worked well in every version of Android < 8.0.0
Our Ionic 1 apps worked well even in Android 8.0.0

Expected Behavior

When start sending position with BackgroundGeolocation start function, a new resident notification should appear even when the app is started or not. The only thing that happens correctly is the position is being sent correctly.
Actual Behavior

There's no notification at all.
Possible Fix

The only thing we guess is there's something changed in version 6.3.0 that override or extends the functionality of the previous android platforms and Android 8 is not taking into account.
Steps to Reproduce

Install Android 8
Deploy an app that has been deployed witi android 6.3.0 platform
Go to a section wherever the backgroundgeolocation has to be started, or force by console the call by using breakpoints.
You will not see the notification, but the position is being sent correctly.

Context

Our customers cannot be sure the backgroundgeolocation position is being sent and they are worry even if the app is on the front or in the background.
Debug logs

There's no messages in the log at all, so it seems nothing indicates an error is being thrown.

Do you think is an affordable issue? We're requesting plugins whose minimal required platform is<EMAIL_ADDRESS>and we cannot get rid of your plugin, so we're in an embarrassing situation. Thanks so much!

Is this related to Android 8 or cordova-android 6.3.0?

Is actually a combination of both versions, so I'm afraid it may be happening with above versions because a short time ago, I installed cordova-android 6.4.0 and no way. To summarize, for the sake of the apps can be working after an Android update, we're using cordova-android 6.2.0 in order to your plugin go on working, with the desire we can use cordova-android 6.3.0 or above. Thanks!

I found a solution, so maybe it can be solved by mauron by adding this to the plugin. In a test project i added the notification channels (the Android O convention) to the place where te notification is build.
btw i'm using:
Plugin version: 2.3.3
Cordova version (cordova -v): 8.0.0
Cordova platform version (cordova platform ls): android 6.3.0
Device: Galaxy S8 with Android O, Emulator with Android O, Galaxy S6 without Android O
Before this solution the notifications where not working on the S8 and the emulator. They did on the S6
NotificationCompat.Builder builder = new NotificationCompat.Builder(this);
builder.setContentTitle(config.getNotificationTitle());
builder.setContentText(config.getNotificationText());

......

PendingIntent contentIntent = PendingIntent.getActivity(context, 0, launchIntent, PendingIntent.FLAG_CANCEL_CURRENT);
            builder.setContentIntent(contentIntent);

// -- start notification channels, this is the part to add
NotificationManager mNotificationManager = (NotificationManager) getSystemService(NOTIFICATION_SERVICE);
String CHANNEL_ID = "background_location";
// Android O requires a Notification Channel.
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
  CharSequence name = getString(R.string.app_name);
  // Create the channel for the notification
  NotificationChannel mChannel =
    new NotificationChannel(CHANNEL_ID, name, NotificationManager.IMPORTANCE_DEFAULT);

  // Set the Notification Channel for the Notification Manager.
  mNotificationManager.createNotificationChannel(mChannel);
  builder.setChannelId(CHANNEL_ID); // Channel ID
}
// -- end notification channels

Notification notification = builder.build();
notification.flags |= Notification.FLAG_ONGOING_EVENT | Notification.FLAG_FOREGROUND_SERVICE | Notification.FLAG_NO_CLEAR;
startForeground(startId, notification);

For me it is showing the notification now, on all of the earlier named devices. It's not the best way of solving it for me, because it's not in the plugin, but maybe as i said earlier, Mauron can add this and test it. I don't really have the time for it to fully test it on more devices, then the ones i own.
Btw, i was checking if react native worked, and it seems that there are no problems with the notification on react native on a device with Android O, even though the code is kinda the same and doesnt have the channels.

I merged @Chal131313 changes. Can you plz try:
npm i<EMAIL_ADDRESS>

@mauron85 I have tested it with the same devices as i used earlier. I can confirm that it works.
There were some problems with using it, because i'm using it with ionic (ionic didn't recognized the plugin, probably because of the "3.0.0-alpha.15-oreo.2", and i didn't knew how to solve that. But i got it working by just directly calling the cordova plugin, and then it works fine and most important, it's showing the notification

Hmm, little correction. It seems that the notification closes itself when the app is closed. Don't know if thats my fault or the plugins fault

Ok, i found out it was my fault. Forgot to configure it to don't stop at terminate.


installation.MD: add ubuntu installation instructions

If I get a chance I'll add RHEL based installation instructions.
I tried to get up and running on Windows but I spent a couple of hours and ran into numerous problems getting busted installed.

I've just noticed SETUP.md, ignore this PR, sorry.


Rearchitect for optimization at browser-level

Is your feature request related to a problem? Please describe.
We achieved optimization in this lib at sufficient level, with improving js, css and React technique.
However it seems to be difficult to be the fastest without rethinking its architecture to become suitable for optimization at browser level.
Of course it would make it difficult to maintain, so we have to choose the one which has clear benefits and acceptable cons.
Describe the solution you'd like

DOM recycling

implemented in iron list,  cdk-virtual-scroll-viewport, recyclerlistview (but not DOM), etc.
cons: maybe having problem on accessibility and state.

Synchronous scrolling

implemented in Monaco Editor and (probably) older CodeMirror
cons: probably hard to implement smoother than native asynchronous scrolling

or something better (need to investigate)

Describe alternatives you've considered
N/A
Additional context
N/A

Closing because tricky optimization can decrease maintainability and flexibility.

Consider recycling mode in #280


UV Hydro - plot corrections

If "corrections" exists in the JSON (as an array), for each correction, plot corrections[n].startTime and corrections[n].endTime as vertical blue bars in the lower chart. Each bar should be labeled with "<Start/End> - <corrections[n].comment"

Amendment to the above. We will be passing two sets of corrections, primarySeriesCorrections and secondarySeriesCorrections. Check for the existence of data and only plot if exists. Plot primary on the upper plot, and secondary on the lower plot.
I will hopefully be able to update the example data shortly.


allow empty start and end

if start not set, default to head of the branch.
if end not set, default to tail of the branch.

done by #7


[FX-5716] Use icon for dropdown arrows

FX-5716
Description
This pull request aligns dropdown arrows with BASE design.
Confirmed with @whymancreates here.
Details
How it used to work before
The triangle arrow was in fact a rectangle with top border being white and other borders being transparent to form the triangle.

Options
There are three ways to solve the problem

modify existing "rectangle borders that form the triangle" approach to make it look like the icon in BASE
use existing icon ArrowDownMinor16
use custom icon (in fact, ArrowDownMinor16, but with modified viewBox)

Approach (1) is too hacky, so it was abandoned right from the start.
Approach (2) looks like the most straightforward one, but the problem is that Picasso icons have whitespace around the actual paths, so it heavily affects the calculations of space between elements in the dropdown.

Icon component
Icon paths

In order to deal with extra whitespace in icon, negative margins need to be used to cut away this whitespace. However, in some cases negative margins still affect the overall layout, so all elements are shifted like in the visual test below

However, there is another way to deal with SVG whitespace – modification of viewBox. After adjusting it to ignore the whitespace, there is no need in negative margins, so the overall layout is more clear. Additionally, there are no layout shifts affected by margins as you can see in visual test changes – differences are only about the arrow itself, no surroundings were affected.

Considering the fact that the Icons API should not allow modification of viewBox (there might be problems with overall calculations), it was decided to have a local copy of ArrowDownMinor16 SVG with custom modifications needed particularly for this case.
How to test

Test temploy in various browsers (feel free to use corporate account at https://browserstack.com)
Check the visual changes, they should be only about arrow itself

Screenshots
Before and after
Development checks

[x] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[N/A] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[N/A] Annotate all props in component with documentation
[N/A] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[N/A] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[x] Covered with tests (visual tests included)

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers

@toptal-anvil ping reviewers

@toptal-bot run package:alpha-release


Indexing Error During Predictions

Trying to get predictions using the ReadME tutorial and getting the below error during run_prediction.py
09/23/2024 21:12:42 - INFO - __main__ -   ***** Running prediction  *****
09/23/2024 21:12:42 - INFO - __main__ -     Num examples = 86690
09/23/2024 21:12:42 - INFO - __main__ -     Batch size = 32
Predicting:   0%|          | 0/2710 [00:02<?, ?it/s]
Traceback (most recent call last):
  File "run_enhancer.py", line 1287, in <module>
    main()
  File "run_enhancer.py", line 1157, in main
    prediction = predict(args, model, tokenizer, prefix=prefix)
  File "run_enhancer.py", line 518, in predict
    outputs = model(**inputs)
  File "/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
  File "/iEnhancer-BERT/src/transformers/modeling_bert.py", line 1273, in forward
    all_layer = torch.transpose(torch.cat(tuple([t.unsqueeze(0) for t in outputs[2]]), 0), 0, 1)
IndexError: tuple index out of range

Based on what I can tell from DNABERT this is using the dev.tsv file. I have run the one from that repo using the 6kmer pretrained as well as one I created using the 3kmer and get the same error. below is the code I am running
import os

modelPath = "../data/DNABERT_models/3-new-12w-0"
dataPath = "../data/training_data/layer1_3mer"
outputPath = "../results"

os.system('python run_enhancer.py '
    '--model_type dna '
    '--tokenizer_name=' + modelPath + '/vocab.txt  '
    '--model_name_or_path ' + modelPath + ' '
   ' --task_name dnaprom '
   ' --do_predict '
  '  --data_dir ' + dataPath + '   '
   ' --max_seq_length 200 '
    '--per_gpu_pred_batch_size=32 '
    '--output_dir ' + modelPath + '  '
   ' --predict_dir ' + outputPath + '  '
    '--n_process 4'
)

Hi, the pre-trained model provided by DNABERT is large-scale MLM unsupervised learning on a genome-wide scale. It doesn't have any knowledge of the downstream task, so you can't use DNABERT directly to predict enhancers (or strong/weak enhancers). You need to first train a model according to 3.1 3.2 (for your dataset or using the paper's dataset) and then make predictions.


How to correctly create EU IOSS pieces (Vendor Collect populated) - DDU, DDP or something else?

Here's the background: "A shipper’s IOSS Number, VOEC Number, or PVA Number are referred to by UPS as a Vendor Collect ID or (VCID). VCIDs are new types of VAT registration numbers that are used for verified point-of-sale VAT charges collected for lower-value goods to customers in certain countries. VCIDs can speed up customs clearance and prevent unnecessary import fees."
I cannot see anywhere in the documentation if shipments using a Vendor Collect ID should use Incoterms DDP, DDU, or something else.  Shippers wouldn't want to state DDP if that triggers UPS systems to calculate and bill the shipper for the already prepaid taxes.  However, shippers wouldn't want to be incorrectly stating DDU if that triggers UPS's automated systems to start billing the recipients.
In an ideal word, one would hope that UPS systems would notice the Vendor Collect ID is populated and treat the package as prepaid import taxes/VAT.
Can anyone advise whether to use DDU or DDP, and anything else that means these seamlessly flow through?

I created a couple of test pieces and shipped them via DDU.  Both cleared customs and went out of delivery today.  It looks like UPS systems work with DDU code, at least when combined with the API populated UPS commercial invoice as opposed to own commercial invoice.


Fix: crash on WebStorm (fixes #14)

Fixes # 14.

Codecov Report

Merging #15 into master will decrease coverage by 0.56%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   97.43%   96.87%   -0.57%
==========================================
  Files          25       25
  Lines         312      320       +8
==========================================
+ Hits          304      310       +6
- Misses          8       10       +2

Impacted Files
Coverage Δ

lib/internal/get-linters.js
86.66% <80%> (-13.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8766b6...70ccb72. Read the comment docs.


Ability to use configured vim diagnostic signs

Hi, awesome plugin!
Right now, the "icon" that is displayed is the same for all types of diagnostics and is configured via the signs.diag option in the plugin setup.
Neovim however already lets you configure specific signs for your diagnostics via vim.diagnostic.config.signs. Other plugins like folke's trouble will use those signs automatically for the various diagnostic types. I was wondering if it would be possible to either provide this behavior as an option, or allow it to be configured rather than just having one sign for all types of diagnostics.
(I am also happy to attempt a PR for this behavior if desired)

Hi, thank you !
I did add it. You need to set:
{
     options = {
          use_icons_from_diagnostic = true
     }
}

And it will fetch signs from your vim.diagnostic config.
Also, I did a major overhaul of the code, so it may be unstable. Do not hesitate to tell me if something is wrong

Amazing, thanks!


Create JebScape plugin

This is a highly experimental plugin that is currently being deployed for very early public testing purposes. Right now, it only supports drawing ghost men of other players in other worlds. Movement, orientation, and animations are currently supported. Cross-world chat is planned for the future. Stability and player count support at any given time may vary depending upon the status and development stage of the server at the time.

The server is live again now and works with the current submitted plugin. I should be done with plugin changes for now.

3 players on 3 different worlds. Depending upon how long this review takes, I may get chat in there in time. It might be better to wait to do so though if unfiltered chat ends up being a problem for approval.

Version 0.1.1 is now ready for merge, pending approval...

Any chance this merge request can be reviewed soon? It’s been a month and this PR remains the oldest plugin-add request without a response.

Any chance this merge request can be reviewed soon? It’s been a month and this PR remains the oldest plugin-add request without a response.

Are you saying this because you see new plugins that have gotten responses?

More that I was told 2-3 weeks was the typical waiting time for a review. I’ve also donated over $400 to RL but paying more doesn’t seem to give any faster service. I did see some Quest Helper changes were immediately merged before anyone else’s though. Gotta learn his secret…

Existing plugin updates are prioritized over new plugin additions; consider having your plugin testers use a shadow jar while it is still WIP

This is a long-term development effort and I’m at a stage where I want to make a public video about it to get a large number of users on it at its current level of development. It’d obviously be better if such a video were accompanied with the plugin already on the hub rather than having people download a jar. I’m also paying for server hosting that isn’t being used, so that’s another concern.
I can continue to wait if needed. Could I have an ETA at the very least?

I did see some Quest Helper changes were immediately merged before anyone else’s though. Gotta learn his secret…

His secret is he's been developing the plugin for the past 2.5 years, and with the exception of the quest that got added, there was a whopping 82 lines of code added in that PR, your PR is at least 1500 lines of brand new code that needs to be reviewed.
It's open source, sometimes things get backed up.

We've been very busy with other things as of late. I'll likely do a first pass review this weekend.

Thank you!

Awesome! I see there’s 1 approval. What’s the next step before merging occurs? Another review?


Alamofire 3.5.0/4.0.0 pod fails to build with ld: framework not found Foundation

Tried to install pod with CocoaPods 1.1.0.rc.2, running Xcode Version 8.0 (8A218a)
Error:
Ld /Users/Robert/Library/Developer/Xcode/DerivedData/SnapMeApp-bdhntvipgfszuvbselinvxhsyxnk/Build/Products/Debug-iphonesimulator/Alamofire/Alamofire.framework/Alamofire normal x86_64
    cd /Users/Robert/Documents/Workspace/snapmeapp/ios/Pods
    export IPHONEOS_DEPLOYMENT_TARGET=8.0
    export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -arch x86_64 -dynamiclib -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator10.0.sdk -L/Users/Robert/Library/Developer/Xcode/DerivedData/SnapMeApp-bdhntvipgfszuvbselinvxhsyxnk/Build/Products/Debug-iphonesimulator/Alamofire -F/Users/Robert/Library/Developer/Xcode/DerivedData/SnapMeApp-bdhntvipgfszuvbselinvxhsyxnk/Build/Products/Debug-iphonesimulator/Alamofire -filelist /Users/Robert/Library/Developer/Xcode/DerivedData/SnapMeApp-bdhntvipgfszuvbselinvxhsyxnk/Build/Intermediates/Pods.build/Debug-iphonesimulator/Alamofire.build/Objects-normal/x86_64/Alamofire.LinkFileList -install_name @rpath/Alamofire.framework/Alamofire -Xlinker -rpath -Xlinker @executable_path/Frameworks -Xlinker -rpath -Xlinker @loader_path/Frameworks -mios-simulator-version-min=8.0 -Xlinker -object_path_lto -Xlinker /Users/Robert/Library/Developer/Xcode/DerivedData/SnapMeApp-bdhntvipgfszuvbselinvxhsyxnk/Build/Intermediates/Pods.build/Debug-iphonesimulator/Alamofire.build/Objects-normal/x86_64/Alamofire_lto.o -Xlinker -export_dynamic -Xlinker -no_deduplicate -Xlinker -objc_abi_version -Xlinker 2 -fobjc-arc -fobjc-link-runtime -fapplication-extension -L/Applications/Xcode.app/Contents/Developer/Toolchains/Swift_2.3.xctoolchain/usr/lib/swift/iphonesimulator -Xlinker -add_ast_path -Xlinker /Users/Robert/Library/Developer/Xcode/DerivedData/SnapMeApp-bdhntvipgfszuvbselinvxhsyxnk/Build/Intermediates/Pods.build/Debug-iphonesimulator/Alamofire.build/Objects-normal/x86_64/Alamofire.swiftmodule -framework Foundation -single_module -compatibility_version 1 -current_version 1 -Xlinker -dependency_info -Xlinker /Users/Robert/Library/Developer/Xcode/DerivedData/SnapMeApp-bdhntvipgfszuvbselinvxhsyxnk/Build/Intermediates/Pods.build/Debug-iphonesimulator/Alamofire.build/Objects-normal/x86_64/Alamofire_dependency_info.dat -o /Users/Robert/Library/Developer/Xcode/DerivedData/SnapMeApp-bdhntvipgfszuvbselinvxhsyxnk/Build/Products/Debug-iphonesimulator/Alamofire/Alamofire.framework/Alamofire

ld: framework not found Foundation
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Update:
The same issue appears to happen with Alamofire 4.0.0.
This Issue is reproducible by just creating a new project and adding just Alamofire to the Podfile.

TestProject.zip
Here is a project that reproduces this issue.

Thanks for providing your test project. It builds successfully for me, as do my own Alamofire-from-CocoaPods test projects. So it just seems to be a general build issue with your environment.
These types of questions are best suited for Stack Overflow and tag Alamofire. We use our GitHub project for bug reports and feature requests.
Best of luck!

From our Contribution Guidelines
Asking Questions
We don't use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.

@jshier Sorry about that. Thanks for trying the test project!

@RobertBiehl
The test project builds successful for me, but my original project i am getting the same issue which you mentioned, finally I fix it simply go to build settings then search Framework Search Paths
Add: $(CONFIGURATION_BUILD_DIR) and select recursive
Hope this helps you.


Add support for #[sv::] attributes for all sylvia attribtues.

For now, we want all attributes to be in the form of #[sv::], eg. #[sv::msg], #[sv::messages], etc.
We still want to support the non-prefixed attributes for attributes already existing but emit a deprecation warning with the information they most probably would not be supported since v1.0.0.

We need to figure out the system to remember deprecated things to be removed in 1.0.0 BEFORE starting this task.

TODO(1.0.0): deprecated

Is a possibility


How to set initial value, when list-data is provided via ajax-search?

Hi!
I'm trying to get get this to work:
Data I can select out, is only available when typed in the search box (via ajax). (So no data via [data] attribute). The selected value will be saved.
When, a value was chosen, and the user returns to the view with the Select, that value should be visible in the Select.
When a value changes, I only get the ID. But how can I set the initial value? (I guess I need an object providing both ID, and Text?)
How does this mechanic work?

this.options.initSelection = function(element, callback: (data: any) => void) {
                        callback({id: result.id, text: result.name});
                    };

That is how I did it. In case if you getting initial value in some async request there is possible to change "data" property right after you set initial selection. I did this:
 this.data = [];


Changes for build on macOS

Description
Changes for building 3.3.0 on macOS machine (with MacPorts and Homebrew "visible" to build_visit)

Ran into various issues with Mili. Removed some obsolete Mili build logic
Fix shebangs after sphinx install
Constrain build of numpy to avoid depending on libs in /opt/local/lib (MacPorts stuff)
Constrain build of Pillow to avoid depending on libs in /opt/local/lib (MacPorts stuff)
Document various things related to masonry build

Type of change

[x] Bug fix~~
[ ] New feature
[ ] Documentation update
[ ] Other

How Has This Been Tested?
I've run it manually on my machine.
Checklist:

[x] I have followed the style guidelines of this project.~~
[x] I have performed a self-review of my own code.~~
[x] I have commented my code where applicable.~~
[ ] I have updated the release notes.
[x] I have made corresponding changes to the documentation.~~
[ ] I have added debugging support to my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have confirmed new and existing unit tests pass locally with my changes.
[ ] I have added new baselines for any new tests to the repo.
[x] I have NOT made any changes to protocol or public interfaces in an RC branch.~~
[x] I have assigned reviewers (see VisIt's PR procedures for more information).~~

Ok, @cyrush and @brugger1 this is ready for review.


--add-metadata always evalutes

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.07.16. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.07.16

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[X] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.07.16
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue required an account credentials please provide them or explain how one can obtain them.
I'm using youtube-dl to keep an archived local copy of a particular youtube channel.  What I have found that each time my script is executed to download new files, --add-metadata is evaluated and the metadata is updated for every video it finds whether it is a new file or not. I imagine that this is working as expected since this would be useful if say someone ran an instance of youtube-dl without --add-metadata and later decided they wanted to add metadata but in my case it seems to be extra redundant work that could be eliminated. My suggestion is maybe a flag for --add-metadata, maybe something like "--add-metadata new-only" that would execute the add metadata portion if the video it just downloaded was new.

Use --download-archive.


Cross-kernel influence in binding allocation

Clvk currently assumes that the highest binding number in a descriptor set is less than the number of resources that require a binding. This no longer seems to be true with recent versions of clspv (https://github.com/kpet/clvk/issues/233). While accomodating this in clvk is trivial, I wanted to double check that this bit of clspv behaviour was expected before doing so. Specifically, it seems that in some cases bindings for one kernel are allocated after those for another kernel. Consider the following code:
kernel void k0(int v, local int* l, global int* b){}
kernel void k1(global int* b){}

which leads to the following descriptor map:
kernel_decl,k0
kernel,k0,arg,l,argOrdinal,1,argKind,local,arrayElemSize,4,arrayNumElemSpecId,3
kernel,k0,arg,b,argOrdinal,2,descriptorSet,0,binding,0,offset,0,argKind,buffer
kernel,k0,arg,v,argOrdinal,0,offset,0,argKind,pod_pushconstant,argSize,4
kernel_decl,k1
kernel,k1,arg,b,argOrdinal,0,descriptorSet,0,binding,2,offset,0,argKind,buffer
spec_constant,workgroup_size_x,spec_id,0
spec_constant,workgroup_size_y,spec_id,1
spec_constant,workgroup_size_z,spec_id,2

Generally, this seems to happen when there are POD and local arguments. I haven't looked into the details.
Is this expected behaviour? If yes, what is the rationale for this behaviour?

If the sample was rewritten as:
kernel void k0(global int* b, int v, local int* l){}
kernel void k1(global int* b){}

Clspv would reuse binding 0 for by k0 and k1 b arguments. Currently clspv only shares bindings when the argument index and types match. This allows code generation to generate a single variable for the descriptor set and binding pair. That's why you end up with binding 2.
There are improvements in this regard. For example, DirectResourceAccess attempts to leverage reused bindings to avoid variable pointers. It should be the other way around and AllocateDescriptors should consider which resources can be shared before assigning bindings (a sort of graph colouring problem). Any change here though would necessitate changes in the SPIR-V producer to generate variables differently. This isn't necessarily difficult, but it is not currently accounted for.

I see, makes sense. Thank you for the explanation. I'm amazed I'm only bumping into this now! I'll push a fix to clvk.

@kpet, Can we close this issue now?

Maybe @alan-baker wants to keep it to track his suggested improvements. Maybe a new issue would be better. I'm fine with closing it if Alan's fine.

I've filed #1061.


Bump @hpke/hybridkem-x-wing to 0.4.0.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.48%. Comparing base (3e3df51) to head (50a16fc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #457   +/-   ##
=======================================
  Coverage   88.48%   88.48%
=======================================
  Files          60       60
  Lines        4716     4716
  Branches      448      448
=======================================
  Hits         4173     4173
  Misses        542      542
  Partials        1        1

Flag
Coverage Δ

unittests
88.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


RoundedCorners seems to ignore background color

The code below produced transparent corners in previous version.
Now the corners are black no matter what color i choose for the background.
Btw. many thanks for this great library!
var result = new MemoryStream();
using (var factory = new ImageFactory())
{
factory.Load(imageStream)
.BackgroundColor(Color.Transparent)
.Format(new PngFormat());
factory.Resize(newSize);
factory.RoundedCorners(radius);
factory.Save(result);
}
return result;

Ah yes, I know why. We’re now respecting the original input pixel format which would be 24bit. May have to revert that.

Just a heads up though. From the Readme:

ImageProcessor is in Soft Archive Mode.
Focus for the ImageProcessor libraries has switched to a new library ImageSharp. As such, no new features will be added to this library. Bug fixes will continue to be added and only via PR.

Yes, already got it. We use only some basic image manipulations so ImageProcessor is completely sufficient to our needs. But i will check ImageSharp when i got time. From what i saw it sounds very promising!


improved the Run a local chain guide

Summary by CodeRabbit

Documentation

Enhanced clarity and organization of the guide for running a local chain.
Added an "Overview" section outlining the purpose of the document.
Reformatted instructions into a numbered list for improved readability.
Included additional commands and clarifications for installation checks.
Introduced a new option for downloading and using a devnet snapshot.
Added tips and notes to assist users through the process effectively.

Everything looks good. Merging the PR!


Cluster IDs in space is incorrent/current frame is not highlighted for a timelapse in version 0.5.2

Hi, all!
There is a bug in version 0.5.2 (not sure about 0.5.1, I haven't tested that one). However, in 0.5.0 it works perfectly.
In the image below, on the left - version 0.5.2, and on the right - 0.5.0 with exactly the same data, reg props file and manual cluster. The current timepoint is not highlighted in the plot, and manual clustering in the generated cluster_ids_in_space is wrong.

It would be nice if somebody could confirm that they also encounter this bug.
I cannot dig deeper right now, so I will continue using the older version and fix this when I have more time unless somebody is faster :)

Yeah, that's unfortunate. I recommend relabeling sequentially per timepoint and adding a section in the documentation.

dictionary mapping instead of pyclesperanto
I would like to veto the dictionary mapping because there is no single algorithm on earth that allow us post-processig these LUT-mapped label images. This strategy appears to me as a dead-end.

I would like to veto the dictionary mapping because there is no single algorithm on earth that allow us post-processig these LUT-mapped label images. This strategy appears to me as a dead-end.

Good, then I will just make the requirements for the uploaded files clearer in the documentation.
Do you think it makes sense to implement a check whether labelling is sequential/missing labels are still in the csv file and issue a warning if not, so the user would be warned that visualisation is incorrect?

Yes, maybe we should implement such a check. I'm afraid it will take some time and thus, we need to be careful where to put it. So that it's not executed again and again all the time...


Gender if unclear

Do we include MorphoDiTa's unclear gender categories (H, Q, T, Z)? In the original script they are used with nouns, adjectives, pronouns and numerals, but not with verbs.
The original script also labels gender of some nouns as MA and MI but doesn't do such labeling with any other POS.

MA and MI labeling of nouns only adheres to the behavior defined by the manual.


glade: fix build with meson 0.61

Description of changes
Not part of GNOME 42 PR and no new release so far.
Patch taken from open-for-two-month-but-still-not-merged PR https://gitlab.gnome.org/GNOME/glade/-/merge_requests/117
Things done

Built on platform(s)

[x] x86_64-linux (with meson 0.62.0 <- not typo)
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg build glade


Ekos exposure count down and guiding issue

@Ronald I have finnally had some time to test your driver with my HQ Camera imx477 under actual sky.
It was really plesent experiance. Best I had with my HQ Camera so far! Long exposures worked as expected. I did 60 sec without a glitch.
I starter indiserver remotelly over SSH with this command:
indiserver -v ./indi_pylibcamera.py indi_eqmod_telescope indi_gpsd
And then remotelly connected to it with Kstars 3.6.3 stable from Windows 11 machine.
What worked:

CCD Tab: Long esposures up to 60 sec with gain 22.23 (didn't test longer, but I guess it's working)
Align Tab: Capture & Solve worked really great! I't was amazing feeling to see HQ Camera in action! Wow, thank you for that! ;)

What didn't worked:

When doing exposure, Ekos progress countdown doesn't work. With 10 sec exposure, progress stayed at value 10 all the time. I guess driver doesn't provide proper feedback to Ekos

Guiding doesn't seams to work either. I'm speculating that driver doesn't provide proper feedback to Ekos. Drift graph didn't update. (I must admit that it's my first time trying guiding with HQ Camera) Should try with Binning 2x2 enabled. Yesterday it was not enabled yet.
It is possible to set binning up to 10, but values greater than 2 give you error 2023-03-10T21:22:33 Failed to set binning. I guess there should be upper limit set to 2.

It's really amazing to see such great progress with your driver! Keep up great work! Thank you!

Thank you very much for your kind words. That makes me happy.
Good to read that solving works! When I tried it last time the solver had serious issues to detect stars. But I tried it with an older version of KStars/EKOS and the image FITS still had the garbage columns.
Regarding the not working things you listed:

The driver does not send data to EKOS for the countdown. I did not give that priority. But you are right: when you do long term exposures it is comfortable to know the remaining time. I will implement this in the next days.
It surprises me that guiding does not work. Do you use the internal guider or PHD2? Does the guider get image frames? Is a guiding star detected? Last time (2 weeks ago with an earlier version of the driver) I had a clear night and tested with PHD2. After setting up PHD2 for my Alt-Az mount I saw the drift graph and guiding pulses. But guiding accuracy was bad. Maybe this was because the old driver was not providing the correct binning information. Or I made something wrong when configuring PHD2. I will try that again in the next clear night.
The driver tells EKOS the binning value range. In thre driver control window, in focus tab and in solver tab the binning options are "1x1" and "2x2". Only in the camera tab the binning allows values above 2 (and it allows different values for horzontal and vertical which does not make sense). When I use the CCD simulator the camera tab does it right. I will try to find out what the CCD simualtor does different.

I will work on it.

The latest version in the main branch has:

exposure countdown implemented,
allows aborting of an exposure and
has the binning control fixed.

I could not test the guiding with the latest version. Too many clouds on the sky :-(

Great work!
Last time I forgot to mention another problem.
Steps to reproduce:

go to Guide tab in Ekos
press Loop button
after some time press Stop button
go back to CCD tab
start another exposure

In previous version that didn't work. It seams, that aborting exposure that you implemented fixed that problem too! Awsome!
I will test guiding as soon as possible to report back my findings.

I had a clear night to Monday and tested guiding with my HQ camera. The internal guider and PHD2 get images, can detect stars, calibrate and start guiding. So I think the camera does its work. But the guiding actions do not work with my setup (both internal and PHD2). For instance I see that RA of my mount drifts to one side. PHD2 starts to send pulses in the other direction, but RA continues to drift away. PHD2 increases the pulses in the other direction without success. And than RA of my mount "jumps" to the other side, far too much. It does not matter how I adjust the regulation parameter in PHD2, that cycling newer stops or gets lower.
This is very frustrating because I did all the effort with the indi_pylibcamera driver to get auto-guiding working (the gear imperfections limit me to 20s exposure time without auto-guiding).
Maybe the root cause is my mount driver. INDI has 2 or 3 candidates for my mount and maybe I took the wrong one. Or I need to update the mount firmware. All that is off-topic here. If you agree I will close this issue as solved.

What mount are you using?

I tested with a Skywatcher Synscan https://www.astroshop.de/teleskope/skywatcher-teleskop-n-150-750-star-discovery-p1-50i-synscan-wifi-goto/p,57364. This is an Alt/Az mount and I followed instructions in https://telescopemount.org/guiding-the-panther-alt-az-mount-with-phd2/.
The mount is controlled by the Synscan App on my Android phone. The INDI driver I used is indi_synscan_telescope.
Before I connect the INDI mount driver I do alignment in the App. With the INDI driver I can control the mount in KStars (mount goes to targets with pretty good precision). Tracking also works fine. When PHD2 does calibration I can also see the guiding star moving. That makes me believe PHD2 can control the mount.
When taking 20s exposures without PHD2 autoguiding the stars are nearly round. With PHD2 autoguiding the stars are wiggled. That also makes me believe that PHD2 can control the mount.
The problem is the stability of the regulation loop. With the settings from the link above the regulation overshoots and never comes to a stable operation. Tweaking the settings did not help. It is like the mount ignores guiding pulses or it has a very long dead time.
I will update the Synscan App to the Pro version. I will also try other INDI driver (indi_azgti_telescope, indi_skywatcherAltAzMount).
I also plan to test it with my Meade LXD55. This is an equatorial mount (PHD2 was mad for such mounts) and will have a different INDI driver. When it works with the Meade than I can eliminate the camera as error source.
Unfortunately all this needs to be done in clear nights, which are seldom this year.
By the way, yesterday I fixed a bug in the SCALE value stored in the FITS images. The wrong SCALE confused the field solver. After fixing I can solve in ASTAP and EKOS (using Load & Slew). I recommend to update your installation.


Select does not detect changes in options array

It's entirely possible I'm not understanding something, but I've been trying different ways to modify the options list using sui-select with no luck, but when switching to bare angular, things are working smoothly.
View the stackblitz below and attempt to add and remove elements and their effect on the respective select/options
https://stackblitz.com/edit/angular-dmdgh4

Try to change select.filteredOptions into options.
<sui-select-option *ngFor="let option of options" [value]="option">
</sui-select-option>

Check this solution, its working.
addOption(){
    this.options = [...this.options,{'name':'new','id':2}];
  }
  removeOption(){
    this.options.pop();
    this.options = [...this.options];
  }

I don't know what is wrong with the library, but it doesn't refresh new array till you provide new reference.
May we should resolve this problem first.


Add Storybook integration

Will try out a fresh install: https://storybook.js.org/docs/vue/get-started/introduction

Done! Closed by #10


Use Aqua in tests

Can we skip failures in codecov upload?  They just add noise.

Can we skip failures in codecov upload? They just add noise.

They keep failing randomly for no reason

The Codecov error says Error: Codecov token not found., so one job out of many couldn't find the token? Bizarre

Is this good to merge?

I think so


Who knows how to train my own datasets in this model?Can you give me a normative preocess?

I have realitived the model at Tusimple datasets,but I do not know how to train my own datasets,because the Tusimple datasets' format is very complex.So how should I do?I have writed some transfomal python file to change Tusimle datasets,but I do not know it is a right way.

I think this might help: https://www.kaggle.com/code/hikmatullahmohammadi/road-lane-line-tusimple-dataset-preparation .


Enable cmake for building SSE or VR

Sorry, the maintenance task appears to have readded the offsets. Let me figure out how to fix that.

Ok figured out the script issue.


How we can use Baal for NER using huggingface

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hello,
I'm not super familiar with NER, but Baal should be able to handle it easily.
Here is a script that load a NER model and outputs prediction. We use MC-Dropout to get the predictions and BALD to estimate the uncertainty.
Note that to get the uncertainty, we need to swap the axes to have the probabilities on the axis 1. [?, PROBS, Sequence, MC-Dropout].
from datasets import load_dataset
from transformers import pipeline

from baal.active.heuristics import BALD
from baal.bayesian.dropout import patch_module
from baal.transformers_trainer_wrapper import BaalTransformersTrainer

dataset = load_dataset("conll2003")

pipeline = pipeline('ner', model='issifuamajeed/distilbert-base-uncased-finetuned-ner')
tokenizer = pipeline.tokenizer

# Apply MC-Dropout
model = patch_module(pipeline.model)
trainer = BaalTransformersTrainer(model=model)

def preprocess(example):
    results = tokenizer(" ".join(example['tokens']), max_length=50,
                        truncation=True, padding='max_length')
    return results

tokenized_dataset = dataset.map(preprocess)

# Shape [Batch_size, Num-Tokens, Probabilities, Iterations]
predictions = trainer.predict_on_dataset(tokenized_dataset['test'], iterations=10)

# Predictions with Class first [batch_size, Probabilities, Num Tokens, Iteration]
next_to_label = BALD(reduction='sum')(predictions.swapaxes(1, 2))
uncertainties = BALD().get_uncertainties(predictions.swapaxes(1, 2))

I hope this helps!

hi @Dref360,
So next_to_label contain a list of indexes, So, these are in sorted order i.e, if list contain [4,5,1,2] means 4 have highest uncertainty?
How we can use this in ActiveLearningLoop?

Hello,

Yes those would have the highest uncertainty.

I had to do some modifications to Baal to make ActiveLearningLoop work on NER. I opened #263 to fix that.
I edited my code to showcase a complete active learning experiment on NER.
If you pull the branch and run this gist, it should work as expected.

Hii @Dref360
for _ in range(2):
    print(f"Active learning: labelled={al_dataset.n_labelled} unlabelled={al_dataset.n_unlabelled}")
    trainer.train()
    trainer.load_state_dict(init_weights)
    trainer.lr_scheduler = None
    trainer.evaluate()
    loop.step()

If we add this Piece of code does it means we
We are training the model on 100 sample of label data again and again and now we are adding 100 data from unlabelled data?
or it means in first iteration we are adding 100 sample of unlabel data to training and in next step model will train on 200 dataset and now will predict next 100 dataset?


Standardized naming of the kernels

It seems that inconsistencies have been introduced into the kernel naming convention of the routines as well as some configuration options (see also #9).
In general
E.g. what does ... mean or when to use ...

generic
stencil suffix like d3q27

Decide on

[ ] When to put the stencil in the routine name
[ ] When to use generic
[ ] Which order to use for the routine name: e.g. scheme_regularization_stencil_generic or regularization_scheme_stencil_generic
[ ] Which order to use for configuration options

Correction routines
Besides, how should we name the correction routine bgk_HybridRecursiveRegularizedCorr ?  It only differs in the blending parameter sigma but is now called for different configure options as listed below:
    case ('hrr_bgk_corrected', 'prr_bgk_corrected', 'rr_bgk_corrected')
      select case (trim(layout))
      case ('d3q27')
        compute => bgk_HybridRecursiveRegularizedCorr_d3q27
      case ('d3q19')
        compute => bgk_HybridRecursiveRegularizedCorr_d3q19
      case ('d2q9')
        compute => bgk_HybridRecursiveRegularizedCorr_d2q9

Suggestion:
bgk_blendedRecursiveRegularizedCorrected
Please note also the change of word ordering and removed trailing capital later in routine name.
Decide on

[ ]  routine name for correction routines

Control
Once the naming convention is set for the routine names as well as the configuration options, we should check all routines for discrepancies and to identify need for renaming.
Harald asked @KannanMasilamani to decide on the names.

Thanks @geriJana. This mostly affects source/init/mus_initFluid_module.f90, I think.

To handle several variants of the scheme relaxations, we have decided to extend the relaxation option in scheme identify table as a table with additional variant option.
identify = {
  kind = 'fluid',
  relaxation = {
    name = 'bgk',
    variant = 'improved'
  },
  layout = 'd3q27'
}

If that variant requires addditional parameters then they should be inside the relaxation table like
identify = {
  kind = 'fluid',
  relaxation = {
    name = 'bgk',
    variant = 'hybrid_recursive_regularized',
    regularization_omega=0.98
  },
  layout = 'd3q27'
}

Default variant can be defined by any of these forms:

relaxation='bgk'
relaxation={ name = 'bgk'}
relaxation={name='bgk', variant='default'}

Here is the new naming convection of the kernels.
mus_advRel_k<kind>_r<relaxation>_v<variant>_l<layout>
Examples:

mus_advRel_kFluid_rBGK_v_ld3q19
mus_advRel_kFluidIncomp_rBGK_ld3q19
mus_advRel_kFluid_rBGK_vHRR_ld3q19

For non-specific implementation leave names out. So we do not use generic keyword in the kernel names anymore.
Examples:

mus_advRel_kFluid_rBGK_v_l
mus_advRel_kMsLiquid_rBGK_v_l

mus_advRel_kFluidIncomp_rBGK_ld3q19 does not seem to follow the naming convention outlined above (doesn't have a _v part). Is this on purpose to show that some parts might be left out? Or is this a typo?

Yes, it was a type. Corrected it now.

@geriJana I believe we can close this issue with the merge of #14. Do you open points from this issue  that still need to be addressed?

Yes, thanks! We can close this issue now.


fix: Add support of ElementNotInteractable in assert_util

I have read the CLA Document and I hereby sign the CLA

LGTM

:tada: This PR is included in version 1.1.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Upgrading all dependencies.

coverage: 100.0%. remained the same
when pulling cb8a295d52cded26d9da1248623175577be373fa on deps-2024-01-20
into b7f56abcae35c42c7867df919c74e677d9c7ef2a on master.


glTF 1.0: treat vec2 normals as oct-encoded to prevent crashes

Recently we've seen quite a few cases where glTF 1.0 assets are crashing in CesiumJS 1.97 due to the NORMAL attribute being a vec2 rather than a vec3. In every case I've seen so far, this is because the glTF 1.0 technique oct-decodes the attribute in the vertex shader.
In Model, we don't do this, as we prefer things to use glTF 2.0 extensions. For example, with KHR_draco_mesh_compression, attributes can be quantized (positions) or oct encoded (normals). We handle this by creating a Quantization object in GltfLoader, and then the DequantizationPipelineStage handles this.
Talking with @lilleyse just now, here's one idea:

Somewhere in GltfLoader (and/or GltfVertexBufferLoader if needed) if we come across an attribute from a glTF 1.0 with semantic = NORMAL, type = VEC2, do the following:

look at the component type to determine the quantization range (e.g. it could be 16- or 32- bit)
Generate a ModelComponents.Quantization object that describes oct-encoded normals. Include the quantization range. See the code for loading Draco attributes for an example.

Try a failing model and verify that DequantizationPipelineStage handles it correctly.

CC @sanjeetsuhag

This came up on the forum here: https://community.cesium.com/t/3dtiles-error-when-upgrade-cesium-to-1-97/20477

I started to fix this in the branch oct-encoded-normals but I'm having trouble finding test data. The old Power Plant model (asset id 8564) won't load out of the box for a different reason and the ISS model has VEC3 texcoords causing a separate crash. Are there any models I'm forgetting about?

There's also the NYC CityGML dataset in https://demos.cesium.com/NewYork/index.html (which has a download link)
The branch works except that lower sections of the buildings have slightly wrong normals. I haven't inspected the glTF close enough to know why. Local sandcastle demo.

Render
Debug

Here's one of the tiles with the shaders extracted: 0.zip
The oct decode function looks like czm_octDecode so I'm not sure what else could explain the artifacts.

To be more specific about the normal artifacts, When looking from above at the tops of buildings and rotating the view, the color changes from shades of magenta (+x, +z) to shades of blue-green (+x, +y), but never just blue (+z) like I would expect for normals in eye-coordinates.

It may be worth noting that such glTF 1.0 files can sometimes be "upgraded" with the 3D Tiles Tools. A recent version added the required functionality. This is not available as a command-line functionality for a single file (i.e. there is no built-in upgradeGltf command or so). It is only applied to glTF 1.0 that is contained in B3DM that are part of a tileset, as part of the general upgrade --targetVersion 1.1 functionality. But if there is demand, offering a command for upgrading standalone glTF 1.0 files to 2.0 should be fairly trivial.


Added Auto Dark mode

If the system colour scheme is set to dark, JS will trigger dark mode.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

thats a lot of code just for that

Hey, thanks for the contribution!  We already have a manual dark mode, which doesn't require the complexity or uncertainty added by this plugin.  If users do want features like this, there's always the DarkReader plugin to add! :)