[macOS] cmake errors

macos 10.14.6
cmake 3.20.5

-- The C compiler identification is AppleClang <IP_ADDRESS>00033
-- The CXX compiler identification is AppleClang <IP_ADDRESS>00033
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/local/bin/pkg-config (found version "0.29.2")
-- Found OpenGL: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/OpenGL.framework
-- Found GLEW: /usr/local/lib/cmake/glew/glew-config.cmake
-- Found GLM: /usr/local/include
CMake Error at CMakeLists.txt:164 (add_subdirectory):
  The source directory

    /Users/freder/Downloads/SHADERed/libs/SpvGenTwo

  does not contain a CMakeLists.txt file.

CMake Error at CMakeLists.txt:171 (add_subdirectory):
  The source directory

    /Users/freder/Downloads/SHADERed/libs/assimp

  does not contain a CMakeLists.txt file.

CMake Error at CMakeLists.txt:176 (add_subdirectory):
  The source directory

    /Users/freder/Downloads/SHADERed/libs/glslang

  does not contain a CMakeLists.txt file.

CMake Error at CMakeLists.txt:179 (add_subdirectory):
  The source directory

    /Users/freder/Downloads/SHADERed/libs/SPIRV-VM

  does not contain a CMakeLists.txt file.

CMake Deprecation Warning at libs/cppdap/CMakeLists.txt:16 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

-- Configuring incomplete, errors occurred!
See also "/Users/freder/Downloads/SHADERed/build/CMakeFiles/CMakeOutput.log".

it looks like the submodules have not been initialized. try:
git submodule update --init --recursive


Peer review: Do not make me review my own uploads

I should only be asked to review images uploaded by others, because peer review is about getting a second opinion.

I think Peer Review already has a mechanism to skip particular images, hopefully this can be reused.

Can you assign this issue to me?

@shashankiitbhu It is yours! Please let us know about your progress every week or so, thanks! :-)

#5435


Fix for #552 Bind doesn't save orientation (just applies it to canvas)

Thx, I added your changes and it works !


[HOLD for payment 2023-01-30]  In the “Something went wrong” page, Expensify logo and  home bar are too close at the bottom

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Enable #focus mode on desktop
Open the mobile app iOS
Some random chat is showing without any chat history
Tap on it

Expected Result:
In the error message page there should be enough space between expensify logo and home bar
Actual Result:
In the “Something went wrong” page, Expensify logo and  home bar are too close at the bottom
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] iOS / native

Version Number: 1.2.53-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673513890584989
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01be353b0b68d8dc70
Upwork Job ID:<PHONE_NUMBER>391966720
Last Price Increase: 2023-01-13

Gonna just handle this one internally.

Will review and test this today.

@marcaaron Can you assign someone for the payout here? Also I think this was missed in this PR https://github.com/Expensify/App/pull/13580 where we added the bottom padding, so should we link the PR for the regression?

@mananjadhav Sorry, I don't know the answer to that question. I would suggest asking in Slack.

I think this was missed in this PR https://github.com/Expensify/App/pull/13580 where we added the bottom padding, so should we link the PR for the regression?

Yea, I think yes we should just for consistency. Though, that was a tough one to QA since it touched all screens. There's not much I'd say about how to improve the review or testing there. I think everyone did as good of a job as they could.

Asked @mananjadhav to apply for the job so I can hire/pay. Updating to daily to stay on it.

Hired/paid @mananjadhav
Closing, reopen if something isn't right.


formState.isSubmitting doesn't reflect the correct state of form submission

I need to read useTsController().formState.isSubmitting from input components, but it just flashes from true to false real quick.
Shouldn't we await here?
https://github.com/iway1/react-ts-form/blob/3fcd707eee60dc8e88cb2cac04f517aeb8796056/src/createSchemaForm.tsx#L381
I can contribute if needed.

Are you wanting isSubmitting to be true while some network request is being sent?

Are you wanting isSubmitting to be true while some network request is being sent?

Exactly.

Would you be able to give a code example of what this looks like with vanilla react-hook-form?
Asking because I typically don't use the isSubmitting property of react hook form for form loading states and don't really know how it works (personally I use react-query's isLoading property`)

If you pass an async function to handleSubmit it will await for it and set isSubmitting to false after it's resolved:
https://github.com/react-hook-form/react-hook-form/blob/28e33c96644d845b9f6146e25e0c621ab117092f/src/logic/createFormControl.ts#L1024
You can read isSubmitting from useForm().formState.isSubmitting as well. Here's the example from RHF docs:
https://codesandbox.io/s/react-hook-form-async-submit-validation-hy9oe


Support freeipa server and client installtion

Issues Resolved by this Pull Request
Fixes #435
Description of the Solution

Install freeipa server on manager node
Install freeipa client on login node
Install freeipa server before k8s installation. freeipa server installation modifies the file /etc/resolv.conf. In order to solve this problem, we take a back up of resolv.conf before server installation and restore the resolv.conf after the insatllation with updated domain name provided by the user.
Adding hosts info in login node and manager node's /etc/hosts file.

Suggested Reviewers
@j0hnL @lwilson

In latest ansible-lint, the following warning does not appear,
[204] Lines should be no longer than 160 chars


[BUG]: Power Platform Admin View app - Choice field Finace spelling mistake

Describe the bug
Hello,
In the "Power Platform Admin View" model-driven app - when editing a "PowerApps App" record, in the "Admin Review" section is a choice field called "Category". One of the values is Finace, but I think it is mean to be "Finance", right?
Component (please tell us which flow or app you are experiencing issues with):

App or Flow: Power Platform Admin View

To Reproduce
Steps to reproduce the behavior:

Go to Power Platform Admin View model-driven app
Click on Apps down the left hand side
Select an app record
Select the Audit tab
In the "ADMIN REVIEW" section, click the field "Category" and scroll down to the value Finace

Expected behavior
I think it should say Finance. I even Googled what does Finace mean, haha,, but couldn't find anything for it, so I think it might be a spelling mistake,
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Nothing else. Thanks.

Thank you! Haha, it's clearly not something we look at very often - just fixed and will go out with the next release!

Updated with the new version that we just released. Thank you for using the CoE!


dependency track integrate with defectdojo

As per the given official document https://documentation.defectdojo.com/integrations/parsers/file/dependency_track/
applied all the steps but still the dependency report is not generated. I have one doubt should we do any scan to import the report or just integrating the depedency track with defectdojo is enough? kindly guide me to solve this.
@dougmorato @Juu @olafz @hasantayyar @0x4d4e @

I am tagged here. My last contribution to this project was years ago and it was very tiny. I am afraid I am not useful here.

@naveen2131-hue,
The integration works fine.  Just follow the steps in the documentation, I took a look at it. You have to upload a bom file to the dependencytrack project which is linked with defectdojo and the bom file has to include a vulnerable dependency. Then, the vulnerability is linked from dependencytrack to defectdojo.
This can be closed @mtesauro


feat(providers): add email outgoing provider

Feature or Problem

Add a provider for performing outgoing emails -- relies on https://github.com/wasmCloud/wasmCloud/pull/2347 (i.e. this PR should be rebased on top of that one)
Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

Closing this given #2347


Implement "expected to fail" functionality

Our CI fails due to expected test failures. Implement "expected to fail" functionality in order to get signal from CI again (i.e., make failing CI meaningful again).

Closing with 8c0619cdeba4e54a17c47e1e16388845d6060429.


Return Path Analysis Can Be Bypassed

CS-FSSA-003
At the end of the semantic analysis, a return path analysis is performed to ensure that all paths that are
required to return a value do so. This analysis is performed on a return path graph generated for each
function. The function ensure_all_paths_reach_exit performs this check by traversing the graph
node by node and making sure that all end nodes with no neighbors reach the exit node or the return
type of the function is unit in which case the function does not return a value.
However, if the graph has a depth of more than 50, the return path analysis will always succeed. This is
because a fixed depth of 50 is used to limit the traversal of the graph.
The following code snippet shows how an invalid function can be compiled by bypassing the return path
analysis check :
script;
fn main(){
}
fn f() -> bool {
 if true {
 return true;
 } else {
 return false;
 };
 // Repeat the above block 50 times
 // Now anything can be returned here.
}

The absence of this check can lead the execution to undefined behavior.

I am unable to reproduce this error.
I have tried to compile the example program, and it correctly reports the following error:
          520 |     // Not a bool - should not be allowed
          521 |     return 42
              |            ^^ Mismatched types.
          expected: bool
          found:    numeric.
          help: Return statement must return the declared function return type.
          522 | }

The test program I used can be found here: https://github.com/FuelLabs/sway/compare/master...jjcnn/no_limit_to_return_path_analysis

Ah, found the problem: The issue isn't that an incorrect type can be returned, but rather that it's possible to not return a value at all.


Failed to link files

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

setup object entry to '...'
send CAN request '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
CANopen Stack (please complete the following information):

Device: [e.g. STM32F429]
OS: [e.g. none]
Version [e.g. v1.2.3]

Additional context
Add any other context about the problem here.

Sorry for the late response. Have you solved this issue?
I have no glue, what is going wrong at your side.
Is the cmake configuration running without errors?
On which Host operating system are you working?


Getting paired with the same people

Issue
I keep getting paired with people I have already been paired with
Possible solutions

the Pairing Bot could store some sort of history to give lower weights to already paired combinations so that people have a higher chance of pairing with a new person

This is great! Thanks for submitting an issue @lainekendall :)
My thoughts:

I think that the "mix and match" function is probably working correctly, but

Even if 30 people are signed up for Pairing Bot, there may only be a few people scheduled for matches on a given day, thus
After a few weeks, it's particularly likely to get re-matched with a person on that day

I'm super into giving Pairing Bot a memory, and prioritizing matches that haven't already happened. However, I'd like to do it in the simplest way possible. Do you have any thoughts about what that might look like? If not, that's totally fine! The database schema currently looks like this:

recurser

email [string]
id [int]
isSkippingTomorrow [bool]
name [string]
schedule

monday [bool]
tuesday [bool]
wednesday [bool]
thursday [bool]
friday [bool]
saturday [bool]
sunday [bool]

If you have any thoughts about ways we could do this, let me know! :)

Hi @marenbeam, how about using a "subcollection" (the name used by Firestore; I have no experience using Firestore -- I just perused the docs)? My initial thought is to have a subcollection lastPaired inside each recurser doc, where each doc of lastPaired has two keys, recurserId (a reference to a recurser.id) and date (I guess a date type if there is one, otherwise a string of form "YYYY-MM-DD"?).
And then adding a command to the bot one can issue from zulip like ipairedwith @**Maren Beam (she) (SP2'19)** 2019-11-19 to add that document to my subcollection. This date-based ledger allows config for when to be paired again with someone, like the default could be after two weeks (if pairing bot finds no one else), but one could change to "never", "one week", etc.

@marenbeam btw I would be interested in "pairing" on this (I don't know Go/Firebase at all, so it would resemble "watching" more than "pairing").

This is a great plan @dwinston :) Thanks so much for putting the time and effort into writing it out!
Unfortunately, Pairing Bot’s gonna get a python re-write, and switch to SQLite as the db — so the Go/Firestore specific parts of this soon won’t apply. But your plan for the database sounds great! I think we should implement it that way.
For anyone reading this — my hope in rewriting pairing bot entirely in python is that it’ll make it easier for more people to contribute and help maintain as time goes on. Also, I don’t know python and I’d like to!

Yay!
I do feel competent with both Python and SQLite, so your hope works for me! :)

No longer moving to Python and SQLite, sticking with Go and Firestore. Closing for now, since solving this matching problem has proven to be non-trivial for chat bot. I'm willing to revisit!


SNOW-847321: Missing optional dependency: pandas despite no pandas dataframe being used

A bug introduced in 1.5.0 is causing some dependency check logic to mistake lists (and likely other data structures) for pandas dataframes. See below for more info, including an MRE.
The issue can likely be worked around by installing pandas, but my understanding is that this shouldn't be necessary.

What version of Python are you using?

Python 3.8.17 (default, Jun 13 2023, 16:09:51)
[GCC 10.2.1 20210110]

What operating system and processor architecture are you using?

I upgraded to snowpark-python 1.5.1 (from 1.4.0). I believe the cause of the issue is the "missing dependency check improvement" introduced in #837, which was included in the 1.5.0 release.
I've put together an MRE:
import os
from snowflake.snowpark.session import Session

def do_things():
    connection_parameters = {
        "account": os.environ['SNOWFLAKE_ACCOUNT'],
        "user": os.environ['SNOWFLAKE_USER'],
        "warehouse": os.environ['SNOWFLAKE_WAREHOUSE'],
        "role": os.environ['SNOWFLAKE_ROLE'],
        "database": os.environ['SNOWFLAKE_DATABASE'],
        "password": "***redacted***"
    }

    list_of_strings = ["this", "is", "a", "list"]

    session = Session.builder.configs(connection_parameters).create()
    session.create_dataframe(list_of_strings) # This throws an exception

if __name__ == "__main__":
    do_things()

What did you expect to see?

I expect the MRE to pass without an error. Instead, create_dataframe throws an exception saying the pandas dependency is missing. It appears that the list of strings passed to the function is mistaken for a pandas dataframe.
Traceback (most recent call last):
  File "snowpark_mre.py", line 20, in <module>
    do_things()
  File "snowpark_mre.py", line 17, in do_things
    session.create_dataframe(list_of_strings)
  File "/home/vscode/.cache/pypoetry/virtualenvs/full/lib/python3.8/site-packages/snowflake/snowpark/session.py", line 1473, in create_dataframe
    if not isinstance(data, (list, tuple, pandas.DataFrame)):
  File "/home/vscode/.cache/pypoetry/virtualenvs/full/lib/python3.8/site-packages/snowflake/connector/options.py", line 44, in __getattr__
    raise errors.MissingDependencyError(self._dep_name)
snowflake.connector.errors.MissingDependencyError: Missing optional dependency: pandas

@bjorhn : Thanks for reporting. This looks like a bug to me introduced by https://github.com/snowflakedb/snowpark-python/commit/549a17c1e0a5134602bbb9150349957f03609b0e (thanks @sfc-gh-stan )
if not installed_pandas and isinstance(data, pandas.DataFrame):
If I'm reading it correctly, if the user does not install pandas, then we will try to load pandas.DataFrame for isinstance check and trigger this error. We'll fix this in the next release.

The idea was trying to provider better message if pandas is not imported but the bug happened and delivered this snowflake.connector.errors.MissingDependencyError: Missing optional dependency: pandas :slightly_smiling_face: not too bad, but the code needs to fix.


Unable to create new SS2Ds or edit existing ones (4.0)

Seems upgrading to Godot 4.0 (understandably) broke the addon. I am unable to create new SS2D nodes or edit the points of existing ones.

The buttons just say "ActionProperty" and there is no option to create a new SS2D node in the node browser


Tiny Llama pretraining script

Adds a script to pretrain the TinyLlama model. The training script and hyperparameters is adapted from the original authors. The data preprocessing pipeline was replaced by our own optimized data processing and streaming datasets from lightning.data.

@carmocca @Andrei-Aksionov I've addressed the major reviewer comments so far. I'm waiting for https://github.com/Lightning-AI/lightning/pull/18988 to land to unblock the CI installation issue.


New Tab Option

Summary

Add a checkbox that says "Open in new window/tab".
This should produce target="_blank" rel="noopener.
Brief explanation of the feature.
Motivation
Some inline links links to external website needs to be opened in a new tab.

On a related note, some browsers (Firefox, Safari) are now assuming that target blank implies rel="noopener" See: https://github.com/whatwg/html/pull/4330

I think this is a feature that could only be available when editing html
Unfortunately CommonMark does not support setting those two properties. If the markdown parser of choice allows this feature, maybe a tinacms:wysiwyg plugin could add that behaviour

maybe with https://github.com/arobase-che/remark-attr (similar to https://www.npmjs.com/package/markdown-it-attrs)

If anyone still needs this.
You can work around this limitation by passing a component that handles anchor elements to TinaMarkdown
Example
const settleRichText = (value: TTinaRichText, components: Record<string, object> = {}) => {
    const formattedComponents = {
        ...{
            a: (props?: {
                url: string;
                children: React.JSX.Element;
            }) => {
                const url = props?.url || "#"
                const target = url.startsWith("https://oxentree.com") || url.startsWith("/") ? "_self" : "_blank"

                return <Link href={url} target={target}>{props?.children}</Link>
            }
        },
        ...components
    }

    return <TinaMarkdown components={formattedComponents} content={value} />
}


Title of "Zookeeper Hut" in tutorial becomes "First Day"

Describe the bug
Title of "Zookeeper Hut" in tutorial becomes "First Day"
Steps to reproduce the behavior

Navigate to https://arcade.makecode.com/--skillmap#zoo
Start first tutorial "Zookeeper Hut"
Observe the title of tutorial

Actual behavior
Title of "Zookeeper Hut" in tutorial becomes "First Day"
Expect behavior
Title should be same with the name of tutorial.
Screenshot

Additional context
1.OS: Windows11
2.arcade version: 1.12.30
3.Microsoft MakeCode version: 8.5.41

Thank you. Fixed in next PR.


how to merge the column

I wanna export the data to excel, and I can merge the rows but i need merge the columns, as i marked in the pic. please help me, thx

@Calvin1121 - Did u find a solution to this?

@Calvin1121 - Did u find a solution to this?

yep~ the plugin provides an api for merging the columns. For example:['A1:J1', 'A2:B2', 'C2:E2', 'F2:G2', 'H2:J2', 'A4:A6']. but it's to diffcult to solve the data and map the merged array. so I asked for help from the backend to do this.

The "!merges" key of the worksheet can be an array of the ranges you want to merge.  See https://github.com/SheetJS/sheetjs/issues/416#issuecomment-286932882 for an example


NPE from Frozen Knight

Hey!
Several of my users have experienced crashes when a Mob Grinder from Industrial Foregoing tries to kill a Frozen Knight.
Crashlog
EmberRootZoo-1.12-1.3.5

Looks like crash happened because the skeleton was trying to respond-attack and also deal damage by applying slowness potion effect onto, something.

Is the Frozen Knight hostile towards other mobs?

Currently it is not.  There is a config to make it avoid wolves, and a config to make it attack villagers.
If you have suggestions I could add other similar toggles

The current configs seem good to me, thanks though.
Do you think I could avoid the crash by turning off the Frozen Knight's slowness potion attack?

I have a fix for crash in next release.  But until you get it, yeah turning off the slowness potion config might fix it

Thanks a lot!


Assert in DynamicAABBTree.h

Hi,
i have a new assert which popped up today.

Assertion failed: (mNodes[nodeID].isLeaf()), function getNodeDataPointer, file ext/reactphysics3d/src/collision/broadphase/DynamicAABBTree.h, line 285.

I guess it happens after adding/removing a body.
The full backtrace looks like:
(gdb) bt
#0  0x000000080274384a in thr_kill () from /lib/libc.so.7
#1  0x0000000802743814 in raise () from /lib/libc.so.7
#2  0x0000000802743789 in abort () from /lib/libc.so.7
#3  0x00000008027bee61 in __assert () from /lib/libc.so.7
#4  0x0000000000aa69b3 in reactphysics3d::DynamicAABBTree::getNodeDataPointer (this=0x8062ba5b8, nodeID=1141) at DynamicAABBTree.h:285
#5  0x0000000000aa5e7f in reactphysics3d::BroadPhaseAlgorithm::computeOverlappingPairs (this=0x8062ba5b8, memoryManager=@0x8062ba008)
    at ext/reactphysics3d/src/collision/broadphase/BroadPhaseAlgorithm.cpp:285
#6  0x0000000000ac2afa in reactphysics3d::CollisionDetection::computeBroadPhase (this=0x8062ba4b0) at ext/reactphysics3d/src/collision/CollisionDetection.cpp:100
#7  0x0000000000ac2a99 in reactphysics3d::CollisionDetection::computeCollisionDetection (this=0x8062ba4b0) at ext/reactphysics3d/src/collision/CollisionDetection.cpp:77
#8  0x0000000000acf2c6 in reactphysics3d::DynamicsWorld::update (this=0x8062ba000, timeStep=0.0329999998) at ext/reactphysics3d/src/engine/DynamicsWorld.cpp:126
#9  0x00000000005cb043 in tdme::engine::physics::World::update (this=0x8062ba000, deltaTime=0.0329999998) at src/tdme/engine/physics/World.cpp:179
#10 0x0000000000447729 in asw::ASWServerGameLogicThread::run (this=0x80651d070) at src/asw/ASWServerGameLogicThread.cpp:436
#11 0x0000000000831a94 in tdme::os::threading::Thread::pThreadRun (thread=0x80651d070) at src/tdme/os/threading/Thread.cpp:55
#12 0x000000080245abc5 in pthread_create () from /lib/libthr.so.3
#13 0x0000000000000000 in ?? ()

However if disabling assertions everything works as expected.
Best regards
Andreas

Thanks for reporting this.
I am not able to reproduce this. Do you have some code that I can run with this issue ?

Hi,
Will try to set some code up. It will take some time though.
Best regards
Andreas

Hi,
is it possible that this dissappeared with fix of https://github.com/DanielChappuis/reactphysics3d/issues/60 or another one? I was not able to reproduce it today.
Many thanx and
Best regards
Andreas

Hi,
Yes, it might be related. Do you have a test where this bug can be reproduced in your code so that I can check if it has been fixed by the patch for bug #60 ?

Hi,
did not come up with a test until now. Wanted to create one today after #60 has been fixed.
Tested with our game. It disappeared. :)
So I guess its gone.
Many thanx and
Best regards
Andreas

Ok thanks. I am closing this issue.


Thunderbird support

This extension works very well in Firefox, and it would be nice to see this extension in Thunderbird, too.
Although #13 mentions that the "System theme" in Thunderbird can switch between light and dark themes, it only works if the operating system has this feature. Not all operating systems have light/dark themes or automatic switching. This extension also offers more options, including theme selection and custom times.

Yes, I would love to see this one in TB either! Although I have other extensions like gnome night switcher on linux which all provide day light support etc, I only need all my applications to change using my keyboard shortcut when I go in lit places. So far, I had to stick with "system theme".

Hi guys, thanks for the feedback.
I'll be straight up about this -- I don't use Thunderbird (although maybe I should) and I'm a slave to Gmail at the moment. So I don't have any intention of bringing the extension anytime in the near future.
I'll leave the issue open. It's something I (or someone else) could explore in the "farther" future.

Unfortunate, but I do highly recommend trying out Thunderbird for your email(s), instead of gmail, outlook, ... (as a mail client). It's much faster (offline) and has advanced filtering functionality (just like gmail). It's overwhelming at first though and doesn't look "pretty", but you'll start to appreciate most decisions over time while you find out about all functionality. Yes you'll still be a slave to gmail when using gmail addresses, but less :p
That way, you can start feeling the need for TB support; heheh ;) I may try out creating extensions for TB/FF myself and porting yours to TB eventually, but I have little experience and for now quite little time.

Hi there, it seems that the extension already works fine in Thunderbird 102.6.1, at least the "Manual times" setting.
You can install it manually:

Download the .xpi file from Mozilla's add-ons website (right-click the install button and choose "Save link as..."). If you already have it installed, you can create a new profile or access the website from another browser.
Open Thunderbird, go into the add-ons manager, click the cogwheel and pick "Install Add-on from file".

Then you can configure exactly like you would on Firefox.

I didn't even test the other options, but I believe the OS based theme listener didn't work with version 91 (as that's what Ubuntu 20.04's apt offered, but well that is updated to 102 because of security issues). I was waiting however for a fix to the OS theme's listener fix (#31), to find out what's happening differently. I didn't know you could install them permanently though, but it makes sense since Firefox allows it as well. Perhaps it's possible to drag and install them as well; thanks!

For me it works well in Thunderbird 115.5.1 on Linux. However, Thunderbird does not open a permission dialog popup to allow the location permissions. It would be great if besides access to location you could also enter Lat-Lon-Values to calculate the sunrise and sunset times, respectively.
Is that doable at least?

Hi guys, thanks for the feedback.
I'll be straight up about this -- I don't use Thunderbird (although maybe I should) and I'm a slave to Gmail at the moment. So I don't have any intention of bringing the extension anytime in the near future.
I'll leave the issue open. It's something I (or someone else) could explore in the "farther" future.

Hi, thanks for your work!
This extension can just work fine on ThunderBird, you can remove "location" option from html and directly submit to Thunderbird!


Full test's api part sometimes fails

I expect that the initialization takes so long that the first test function's timeout goes full

I expect that the initialization takes so long that the first test function's timeout goes full

Did not solve the issue

Did not solve the issue

Mixed use of async and done seem to have been the bug reason


Autorun of modified scripts

The idea is to run script on modification. Currently to run script after modification we need to restart APM bundle. New implementation should watch for script changes an after any modification it should run the script.

In APM 5.0.0 there is mechanism to launch script after package installation. It may also launch scripts only if they're changed.


istioctl bug-report: collect node info

To fix https://github.com/istio/istio/issues/30835

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
254e7475fe875afb9743ae49c9a4275e57317428
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-tests_istio


Cannot signup from Firebase!

May be sign-in method Email/Password from firebase authentication console is not enabled?

Hi, we will soon set up a firebase account for developers. Till then, please work with a private account.

Sure! :100:

@Dilu9218 mam can you provide a test login so that i can go through the workflow of the entire app....

@Dilu9218 mam can you provide a test login so that i could once test the entire workflow of the app

Hello @icancode23 ! You can register the app in Firebase console and get the google-services.json file and create an account with a valid email address and a password :)

@Dilu9218 I have developed the Firebase user registration part with my own Firebase project. I'll submit a pull request on that :)


security?

Hi. Amazing light desktop! :)
Would be difficult to add some user-password security to VNC access?

No it won't, I will look into it

Were you able to add this?


IDL Program

There should be a separate program that stores the IDLs as PDAs of a program id and version number, instead of embedding the IDL instructions into the program directly.

Adding the diagrams from the discord thread for posterity.
Go from this:

To this:

An additional question we should consider is how to atomically update the program binary with the IDL. This is important for explorers. There are two options

Add a custom ELF section (can you do that?) to the .so file with the IDL, or append the IDL to the end of the bytecode.
Assume the user uses the Anchor CLI to deploy and provide a new command to do the program upgrade/deploy + IDL upgrade/deploy in the same tx.

I'm not sure if I fully grasp #1, I'm not familiar with the details of solana executables (and I got a C in operating systems haha) but #2 sounds reasonable to me.
A question I have is how do we manage the ownership/deployment of the IDL Program? Someone (I'm assuming you) will have to generate a keypair and be responsible for keeping the private key safe + deploying the program. We could set up a CI/CD deployment pipeline and store the encrypted private key so it can auto-deploy.

Someone on discord suggested using this project for key management/deployment: https://github.com/GokiProtocol/goki
I don't have experience with it but it looks interesting.

Dealing with upgrading the IDL program is probably the main argument against such a program. We would need some governance (probably a DAO) around it. My instinct is that it's better to just leave that up to the governance mechanism of the associated program rather than introduce another one.

I agree that is probably the main argument against this. Do you have any idea how the SPL handles this for those programs?

IDL generation is an anchor feature and the SPL programs dont use anchor so they dont have to think about it

I'm now also of the opinion that it would be better to keep it inside the programs for the reason that I think introducing any kind of dao or similiar governance structure around anchor will slow us down too much.
In the future, this could be revisited tho imo. Having a separate program has the benefit that upgrading the IDL of all anchor programs, e.g. in case there's a bug in it, can be done through upgrading a single program.
Without an IDL program, if there's a bug in the IDL generation code, each anchor program has to upgrade themselves. For some this may be easy, for others, whose upgrades are subject to governance and timelocks, it will be more difficult. In addition, upgrading to a new anchor version would also mean incorporating other new anchor code into their projects (how much of a bad thing that it, I'm not sure yet).

I know SPL programs don't use IDL, I just meant how do they handle governance/upgrades


Enable Auto-Formatting

Formatting conventions are effortlessly enforced using auto-formatting. It saves waste amounts of time and mental energy of both developers and reviewers.
This MR enables auto-formatting of Lua code using StyLua. The project seems to be actively maintained.
See also:

https://github.com/Enapter/marketplace/pull/195#discussion_r1118420872

@kulti, thank you for your comment :)
I cannot think of a simple way to exclude files from being reformatted/checked. I suppose we would be better off spending time reviewing the changes than inventing a mechanism to format a subset of files.

It replace multiline comment (--[[...]]--) with multiple single line comments in one place, but in another change only end of multiline comment from:
]]--

This is my fault, I accidentally included manual changes in the commit that does auto-formatting. It was actually another linter complaining about the commented out code. I moved this changes into separate commit to be explicit.

It replace multiline comment (--[[...]]--) with multiple single line comments in one place, but in another change only end of multiline comment from:
]]--
to strange:
]]
--

Well, the Lua syntax for multi-line comments is --]] followed by a comment followed by ]]. So this -- in the end is a redundant single-line comment.
As for scnum_list changes, such long lists of values may be moved down the file to avoid distracting the reader, the same way as we move main() down the file.

@kulti, thank you for your comment :)
I cannot think of a simple way to exclude files from being reformatted/checked. I suppose we would be better off spending time reviewing the changes than inventing a mechanism to format a subset of files.

I agree with that. Pre-commit already works with changed files only and for CI I can suggest a solution in the following way:
      - name: Get Changed Files
        id: changes
        run: |
          echo "changed-files=$(git diff --name-only ${{ github.event.pull_request.head.sha }} ${{ github.sha }} | xargs)" >> "$GITHUB_OUTPUT"
      - name: Check Formatting
        uses: JohnnyMorganz/stylua-action@v2
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          version: v0.16.1
          args: --check --allow-hidden ${{ steps.changes.outputs.changed-files }}

@kulti, I have removed all the auto-formatting changes, adjusted the CI check to run only if some files have changed, updated README and created an issue to track the review progress. I think this MR can now be merged.


Django strategy should respect X-Forwarded-Port

This change modifies the django strategy's request_port method to respect the USE_X_FORWARDED_HOST setting, and the USE_X_FORWARDED_PORT setting in django >= 1.9.
It should achieve the same thing as https://github.com/omab/python-social-auth/pull/741 but without introducing new settings.

It would solve a problem of mine if this were merged.

I've ported this PR into social-app-django.
Thanks!


Pool: Remove SaaS import logic

Currently, the Pool contains integration logic with a SaaS provider to import business partner data. However, the Pool should be independent of a specific SaaS provider. Therefore, we should remove that logic from the Pool.
For future providers who want to integrate against the Pool, they can use the Pool API to create and update business partners.

Done on https://github.com/eclipse-tractusx/bpdm/pull/206


CRASH - dispatch_async in AFURLSessionManager.m

How to fix it?

Having same issue.

The same issue...

Same. Reproducible on iOS10. Works fine on iOS9.

Any idea how to reproduce this? Can some generate a test case showing the failure? We have Xcode 8 on Travis now, so it should be able to run and catch it there.

If it's any help to someone putting together a test, the issue for me presented itself on download requests.  I had a "test" that would run 10 consecutive downloads (> 400mb) and it would produce this error at varying points. I wrote some code to switch to NSURLSesssion and it crashed as well on iOS 10 (but not 9).

@gmcerveny Does that lead you to believe its a bug in NSURLSession?

Is it related to this?
https://forums.developer.apple.com/thread/60622
because my crashlog says something about 'BUG IN CLIENT OF LIBPLATFORM: Unlock of an os_unfair_lock not owned by current thread'


Deleted party

This is possibly outside the intended scope of the program, but when a save from an Emerald that was modified to have more Pokemon was loaded, all Pokemon in the party were deleted (the only 'new' Pokemon in that save were in the party).
(The particular mod overwrote some of the Glitch Pokemon slots (between Celebi and Treecko) with those Pokemon)

You are correct, unfortunately this is outside of the scope of Trigger's PC. supporting modded games becomes difficult when the structure can vary so much.
Could you leave the name of the game/mod in the title so that others can take note?

Sure.
This was not a specific mod - I had modded a stock Emerald to insert Pokemon based on the some of the Delta Pokemon from the TCG in the slots between Celebi and Treecko (index numbers 252 and 254 in this case specifically).
I suspect similar issues might arise with mods using any of the empty item indices.

Yeah, it's definitely a guarantee to expect non-existent IDs to produce undefined behavior. I haven't really worked with the codebase since 2016 so I can't recall exactly how it handles things. But my guess would be that it eliminates any undefineds.


Integrate small gicp aka (fast_gicp2)

Kenji Koide released a new GICP package for point cloud registration: which might really speed up registration performance in Multi-Robot-Graph-SLAM
https://github.com/koide3/small_gicp

done with dba87fa910ef66e9b3afe529ed4d280cdab4ac13


how to build for windows 7.x

This project is excellent.how can i build it for windows 7.x

No idea. I should mention this is very tightly coupled to Memories, and at this point there's likely no way to make it useful on Windows.


Static code analyses

Yeah it got a bit out of hand 😁
Its is always so difficult to not start fixing things you come across.


[new Exercise] lens-person

created lens-person/ in exercises/practice
added .meta/config.json
added Instruction and Introduction in .docs/
added lens-person.js, lens.person.spec.js and .meta/proof.ci.js files
copied babel.config.js, LICENCE, .npmrc, .gitignore, .eslintrc
created src/ for util classes like Person.js, Name.js, Born.js, Address.js, Lens.js
I have checked test cases. But I am still not sure if tests are running fine, Please help me by checking the test cases especially test cases for immutability

Hi Reviewers,
Need review.

@sarava338
Is this still being worked on?
As it is now, it doesn't pass the CI checks.

@sarava338
Hi @Cool-Katt

Is this still being worked on?
I could not able to solve this CI checks. And I have manually created all the files. But, I saw your commit msg in other new exercises that's being added to exercism, it's generated by configlets. I don't know how to do that as of now.

As it is now, it doesn't pass the CI checks.

if you don't mind, Could you please take over this exercise. I am yet to learn more to create a new exercise on exercism...

@sarava338
Okay then, with your permission, I'll file another PR.
About configlet, and other tooling we use, you can read more on the docs page. It may be useful to acquaint yourself with the docs and proper procedures for adding an exercise to the track.

@sarava338
Okay then, with your permission, I'll file another PR.
About configlet, and other tooling we use, you can read more on the docs page. It may be useful to acquaint yourself with the docs and proper procedures for adding an exercise to the track.

@Cool-Katt Thanks Mate 🙂


Compatibility with the \usetikzlibrary{external}

Situation: The tikz lib external is often used to externalize some complex tikz picture. However, only use \usetikzlibrary{external}\tikzexternalize will try to external all the things generated by tikz including what snaptodo does. This will give an error.
My work around: I use \tikzexternalize[only named=true] and \tikzsetnextfilename{filename} to explicitly state which tikzpicture should be externalized. See the documentation for only named. This will let exteranl library skip what snaptodo does.

A minimul tex file

\documentclass{article}
% main document, called main.tex
\usepackage{tikz}
\usepackage{snaptodo}

\usetikzlibrary{external}
\tikzexternalize[only named=true] % activate only for named pictures

\begin{document}
\tikzsetnextfilename{fig1} % name a picture
\begin{tikzpicture}
  \node {root}
    child {node {left}}
    child {node {right}
      child {node {child}}
      child {node {child}}
    };
% or other plot that plot data here
\end{tikzpicture}

A simple image \snaptodo{still work} is \tikz \fill (0,0) circle(5pt);.
\end{document}

I post it here in case anyone want to use it. Potentially it can be integrated to the documentation. The external package also provide a api /tikz/external/export to disable externalizing maybe it can be used in the future version to disable externalizing snaptodo automatically.

Thank you for the report.  I will get back to this when I have time.
Another quick fix is to put \tikzset{external/export next=false} before each \snaptodo.  One way to automate this is shown below
% !TEX encoding = UTF-8 Unicode
% !TEX program = pdflatex
\documentclass{article}
\usepackage{tikz, snaptodo}
    \usetikzlibrary{external}
    \tikzexternalize
    \makeatletter
    \def\Zenithtodo{%
        \tikzset{external/export next=false}%
        \snaptodo@initialize
        \gdef\Zenithtodo{%
            \tikzset{external/export next=false}%
            \snaptodo@main
        }%
        \Zenithtodo
    }
    \makeatother
\begin{document}
    I am talking some serious business
    \Zenithtodo{Now I am talking about some minor issues}
    \Zenithtodo{The minor issues are not going to be exported}
    \Zenithtodo{No matter how hard I tried}
    \tikz[baseline=(X.base)]\node(X){But this node will be exported.};
\end{document}


TinyUSB Audio is flawed: https://github.com/raspberrypi/pico-sdk/issues/653

Set up
Standard Raspberry Pi Pico RP2040 and also Adafruit Macropad RP2040
Windows 10 Pro with Pico SDK, Recommended ARM GCC and additionally Arduino IDE
Windows 10 Pro Runtime OS Device Manager and additionally Windows 10 on ARM with the same universal device behaviour
Describe the bug
Please see: https://github.com/raspberrypi/pico-sdk/issues/653 for more information
"i2s_dummy_buffer" @ https://github.com/raspberrypi/tinyusb/blob/d49938d0f5052bce70e55c652b657c0a6a7e84fe/examples/device/audio_4_channel_mic/src/main.c#L394
https://github.com/raspberrypi/tinyusb/blob/d49938d0f5052bce70e55c652b657c0a6a7e84fe/examples/device/audio_4_channel_mic/src/main.c#L419
Appears to be causing bit-crushing distortion to any wave applied through it, especially 2 in 2 out USB audio interfacing
To reproduce

Download the Pico SDK and Build the usb examples (especially audio_4_channel_mic from tinyusb and other relevant audio tests)
Ideally adapt the example to create "audio_2i2o", a 2 input 2 output Audio Unit USB interface with the Pico or RP2040 board
Deploy the example UF2 file (converted from .elf with ELF2UF2) onto the Pico, look in Device Manager and Record it in FL Studio
Optionally Audacity can be used for the recording. Increase the volume of the sample to 300% to make the interference pronounced.

Screenshots

PicoSample.zip
Log
No log available from the Pico while it is processing audio over USB, other than all TU_LOG2() statements included in the audio_4_channel_mic example (code reaches all the segments it needs to). Same issue with logging from Macropad but identical data can be observed in the recorded audio sample (which could eventually be used as a trace).

The TinyUSB repo is at https://github.com/hathach/tinyusb. You need to file this issue against that repo, not this one. This does not seem to be an issue related to RP2040 specifically or related to the Pico C/C++ SDK.


Initial journal reorganization

This PR reorganizes journal to support the consensus engine architecture changes.

Updated confusing comments @jsmitchell


replaced prints with debug logs

This PR replaces some debug prints in utils.py with logging. I'm not sure all these are necessary, so let me know if I should remove some of them altogether.
Thanks for maintaining this package!

Coverage remained the same at 100.0% when pulling 0e5da0568bdeb9efeffed1c66d167d83aa06735e on lkindrat-xmos:develop into 638f67af428413ef6b2a45633b6e4f034b11f272 on WoLpH:develop.

Coverage remained the same at 100.0% when pulling 0e5da0568bdeb9efeffed1c66d167d83aa06735e on lkindrat-xmos:develop into 638f67af428413ef6b2a45633b6e4f034b11f272 on WoLpH:develop.

Coverage remained the same at 100.0% when pulling 0e5da0568bdeb9efeffed1c66d167d83aa06735e on lkindrat-xmos:develop into 638f67af428413ef6b2a45633b6e4f034b11f272 on WoLpH:develop.

Thank you for the help! As you assumed correctly... they're not actually needed, but a few debug log statements won't hurt anyone so that's a good fix to keep these in.
It's just a silly mistake of me to commit this


Angular 2 Duplicating the  &

After running dotnet new angular from the Microsoft.AspNetCore.SpaTemplates::* the sample project is duplicating   and .
The check this you can load the sample project, then press Control U in the browser.
The Snippit of the html is below (notice the duplicated elements)
<html>                        <!-- HEAD 1 -->
    <head>
        <meta charset="utf-8" />
        <meta name="viewport" content="width=device-width, initial-scale=1.0" />
        <title>Home Page - temp</title>
        <base href="/" />
        <link rel="stylesheet" href="/dist/vendor.css?v=2OSKmU2Rna58MvkZa-1vCDjb7C1cgTMqz-guh-WoUGU" />
    </head>
    <body>               <!-- BODY 1 -->

<app><html><head><style>@media (max-width: 767px) {    <!-- HTML 2 / HEAD 2 / APP 1 -->
    ...
@media (min-width: 768px) {..
...
}</style></head><body><app _nghost-c0="" ng-version="4.1.2"><div _ngcontent-c0=""
class="container-fluid">   <!-- BODY 2 / APP 2 -->
    <div _ngcontent-c0="" class="row">
        <div _ngcontent-c0="" class="col-sm-3">
            <nav-menu _ngcontent-c0="" _nghost-c1=""><div _ngcontent-c1="" class="main-nav">
            </ul>
        </div>
    </div>
</div>
<script src="/dist/vendor.js?v=8G5nuphpleAMB8hDVj0v8l9es64guglhqGWIwYdey3M"></script>

    <script src="/dist/main-client.js?v=mDzK2Vggpkqz7CNaSstSNAR7vz3wBRBzl8SBziBUh84"></script>

    </body>
</html>

Yes, this is a limitation of how Angular handles server-side prerendering. You can read more discussion about it here: https://github.com/aspnet/JavaScriptServices/issues/662
If this is a problem for you, two things you can do:

Add logic to your boot-server.ts file to capture state.renderToString() as a string, and then manually strip off the unwanted parts.
Report this as a bug to Angular. Basically, you would be asking for an alternative to state.renderToString() that does not insist on wrapping its output in extra HTML doc elements. You will have to supply a repro case that does not involve the JavaScriptServices template, otherwise they will (reasonably) not know whether the issue is occuring on their side or not.


unity driver for everything + table renaming

This PR does the following:

Allows you to choose unity as the single provider for all databases used in a test.
Better naming for sql tables.

Hi @arner , for NWO, it is nice to test also when you have unity and another database. Then, for any other application you can do whatever you want. Not sure if I understood your request though. Can you clarify, please?

Yes, I agree. Maybe I'm wrong, but I thought the config currently requires you to do something like this if you want unity everywhere:
      db:
        persistence:
          type: unity
          opts:
            driver: sqlite
            dataSource: file:/var/dc/data/bank1/db.sqlite?_pragma=journal_mode(WAL)&_pragma=busy_timeout(5000)&_txlock=immediate
      ttxdb:
        persistence:
          type: unity
      auditdb:
        persistence:
          type: unity
      tokendb:
        persistence:
          type: unity
      identitydb:
        persistence:
          type: unity

And I thought it would be nice if unity would be the default, so that you don't need the bottom 12 lines in my example. Or is that already the case?
Anyway I see now that this is separate from the configurability in NWO.

HI @arner , no, that is not needed anymore.  This is enough:
       db:
        persistence:
          type: unity
          opts:
            driver: sqlite
            dataSource: file:/var/dc/data/bank1/db.sqlite?_pragma=journal_mode(WAL)&_pragma=busy_timeout(5000)&_txlock=immediate


Odd vertical buttons in file explorer

Device: Samsung S20
Steps

In File Explorer long press a file

Expected result: buttons are wide and usable
Actual result: buttons are tall and hard to choose "Delete" :)
I tried switching to default theme and back, didn't fix. Tried changing font size, no go. Upgraded theme, still happens.

Well, that's definitely not intended behaviour. I managed to reproduce it on my end. Will work on a fix!

Just wanted to let you know that I've managed to fix it, and it will be back to normal in the next release.

Thanks so much!

This should be fixed in version 0.6.3

It's been working great, thanks for fixing!
On Thu, Feb 10, 2022, at 8:23 AM, jdanielmourao wrote:

This should be fixed in version 0.6.3
—
Reply to this email directly, view it on GitHub https://github.com/jdanielmourao/obsidian-sanctum/issues/129#issuecomment-1034917270, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBB5ZHHCEOHZBAVOM5SDG3U2O33ZANCNFSM5M4Z4VIA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>


fix IstioOperatorSpec wrong link (#23906)

Manual cherry pick of https://github.com/istio/istio/issues/24094

Hey @erdun , can you please comment @googlebot I consent.

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test release-test_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test release-test_istio_release-1.6

integ-pilot-k8s-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-pilot-k8s-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test release-test_istio_release-1.6

integ-pilot-k8s-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-pilot-k8s-tests_istio_release-1.6

unit-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test unit-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test release-test_istio_release-1.6

integ-pilot-k8s-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-pilot-k8s-tests_istio_release-1.6

unit-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test unit-tests_istio_release-1.6

integ-local-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-local-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test release-test_istio_release-1.6

integ-pilot-k8s-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-pilot-k8s-tests_istio_release-1.6

unit-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test unit-tests_istio_release-1.6

integ-local-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-local-tests_istio_release-1.6

lint_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test lint_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test release-test_istio_release-1.6

integ-pilot-k8s-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-pilot-k8s-tests_istio_release-1.6

unit-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test unit-tests_istio_release-1.6

integ-local-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-local-tests_istio_release-1.6

lint_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test lint_istio_release-1.6

integ-distroless-k8s-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-distroless-k8s-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test release-test_istio_release-1.6

integ-pilot-k8s-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-pilot-k8s-tests_istio_release-1.6

unit-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test unit-tests_istio_release-1.6

integ-local-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-local-tests_istio_release-1.6

lint_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test lint_istio_release-1.6

integ-distroless-k8s-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-distroless-k8s-tests_istio_release-1.6

integ-conformance-k8s-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-conformance-k8s-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test release-test_istio_release-1.6

integ-pilot-k8s-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-pilot-k8s-tests_istio_release-1.6

unit-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test unit-tests_istio_release-1.6

integ-local-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-local-tests_istio_release-1.6

lint_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test lint_istio_release-1.6

integ-distroless-k8s-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-distroless-k8s-tests_istio_release-1.6

integ-conformance-k8s-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-conformance-k8s-tests_istio_release-1.6

integ-mixer-k8s-tests_istio_release-1.6
7c24831a20bb36a419075c22fe70030c51d9ba9a
link
/test integ-mixer-k8s-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[RFE] IG mode with static configuration with static tracers

Current situation

IG is deployed automatically with kubectl deploy or manually with the yaml provided by kubectl deploy; either way it contains the DaemonSet, the Trace CRD and other RBAC configuration.
The set of tracers to use is defined dynamically with either the Trace CR (or possibly later with other APIs: gRPC or kubectl-exec API, see work in progress PR#1396); either way, it is dynamic and it needs a process to act as a client to the API.

Impact
The dynamic definition of tracers is fine for some use cases (quick debugging session) but not when users want to permanently enable some gadgets (exporting data in a file or in a Prometheus metrics endpoint).
We run in the following problems with the current setup:

When deploying the set of yamls from IG, we also need a component deploying the Trace CRs or implementing the gRPC client.
When a new node is added to the cluster (or when a node is rebooted), we need a client to enable the traces on the new node dynamically
CRD are not namespaced in Kubernetes, so it is impossible to deploy IG twice with different static configuration

Ideal future situation
In addition to the current dynamic configuration of tracers via CRD or other gRPC API, we should have a way to deploy Inspektor Gadget statically, with a static tracers.
Implementation options

The gadget pod spec has an environment variable to enable or disable CRD. This would control a parameter to gadgettracermanager. It would be enabled by default to keep the current mode but allow users to disable it and deploy IG with static tracers.
A ConfigMap contains the list of tracers (for example enabling the trace dns gadget with the Prometheus output). The ConfigMap can be mounted in the gadget pod and gadgettracermanager is started with --static-tracers=/etc/gadget/static-tracers.yaml
Optionally: kubectl gadget deploy could have additional options:

--trace-controller=false
--static-tracers=./my-static-tracers.yaml
--namespace=gadget2

Additional information

https://github.com/inspektor-gadget/inspektor-gadget/pull/1396
Previous discussion about static configuration https://github.com/inspektor-gadget/inspektor-gadget/issues/673#issuecomment-1184069295
Prometheus output https://github.com/inspektor-gadget/inspektor-gadget/pull/1384

cc @flyth

Related https://github.com/inspektor-gadget/inspektor-gadget/issues/1932

There is a new issue with more information in #2492. I'll close this one, feel free to add information to the new issue in case something is missing.


Add primitive parser for normalized, non-empty line

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b950c08) 100.00% compared to head (328cbbb) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines          114       130   +16
=========================================
+ Hits           114       130   +16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[5.9] MoveOnlyAddressChecker: Reintroduce debug info for variables after reassignment

• Explanation: When a noncopyable binding's value is consumed, we mark the variable as absent in debug info so that the debugger does not attempt to show the expired value. This patch reintroduces the variable in cases where it's reassigned and becomes valid again.
• Scope of Issue: Improves debug info.
• Origination: Quality of implementation of debug info for the new noncopyable types feature.
• Risk: low -- improves debug info for a new feature. Should have no impact on existing code that doesn't adopt the noncopyable types feature.
• Reviewed By: @gottesmm
• Automated Testing: Swift CI

@swift-ci Please test


Update PPP (aweijun)

Details
Update PPP for aweijun.

Codecov Report

Merging #300 (87d5efc) into master (378c498) will increase coverage by 0.29%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #300      +/-   ##
============================================
+ Coverage     61.98%   62.28%   +0.29%
- Complexity      475      480       +5
============================================
  Files            88       88
  Lines          1710     1710
  Branches        194      194
============================================
+ Hits           1060     1065       +5
+ Misses          565      561       -4
+ Partials         85       84       -1

Impacted Files
Coverage Δ

...edu/trackermon/logic/parser/SortCommandParser.java
78.94% <0.00%> (+1.31%)
:arrow_up:

...main/java/seedu/trackermon/model/show/Comment.java
75.00% <0.00%> (+12.50%)
:arrow_up:

.../main/java/seedu/trackermon/model/show/Rating.java
94.44% <0.00%> (+16.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378c498...87d5efc. Read the comment docs.


Added HttpBasic authorisation to the TokenPurchases and TokenReprint resources

These resources should have had basic auth from the beginning.

Hmm, how do we change this if there are non-electrum implementations that don't have auth implemented on those endpoints? If they upgrade their dependency it wont break anything as the annotations don't actually affect whether or not the server uses auth do they?

Yeah, code wise it isn't a breaking change, but from an API point of view,
it can be considered as a breaking change, but perhaps this also depends on
the implementation of the API?
Funny enough, when we first added basic auth, it was a patch (v1.1.1 ->
v1.1.2), although this could have been an error as well.
On Wed, Oct 2, 2019 at 10:48 AM Joshua Ramsbottom<EMAIL_ADDRESS>wrote:

Hmm, how do we change this if there are non-electrum implementations that
don't have auth implemented on those endpoints? If they upgrade their
dependency it wont break anything as the annotations don't actually affect
whether or not the server uses auth do they?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/electrumpayments/prepaidutility-service-interface/pull/14?email_source=notifications&email_token=AGHHUVDQOP4X6FFD7ULP7WTQMRN7VA5CNFSM4I4LQ6I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAEA6QI#issuecomment-537399105,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGHHUVE7KP52GMBZJCK4PG3QMRN7VANCNFSM4I4LQ6IQ
.

--
Regards,
Veenesh Jeena
Electrum Payments (Pty) Ltd
www.electrum.co.za
<EMAIL_ADDRESS><EMAIL_ADDRESS>+27 21 447 1227 (support)
--
Read the Electrum email disclaimer at www.electrum.co.za/email-disclaimer
http://www.electrum.co.za/email-disclaimer


[ingestion/data-quality issue] CSAF VEX file creates both CertifyVEX and CertifyVuln

Describe the bug
Ingesting a CSAF VEX file creates both CertifyVEXStatement and CertifyVuln which duplicates the "vulnerabilities" affecting a package which looks wrong considering a CSAF VEX should be reflected exclusively in a CertifyVEXStatement.
To Reproduce
Run Test_csafParser that expects both Vex and CertifyVuln to have values
Expected behavior
Only a CertifyVEXStatement should be created
GUAC version
main branch
Ingested document(s)
Refer to the test data mentioned above

From discussion in https://github.com/guacsec/guac/pull/1497#pullrequestreview-1730972772 this is not a bug.


VMD to Godot 4

Bake using motion project. Use 3.3 to open project for baking vmds to vrm
save as gltf without blend shapes in 3.x godot editor
Copy MMD animation to godot
Play

Done.


jscs tries to validate excluded files =(

Specific rules that that have issues (jscs --verbose helps with this)

it doesnt relate to rules

A failing test would be amazing

➜  jscs-exlude-files-bug git:(master) ✗ cat .jscsrc
{
  "plugins": ["jscs-config-nordnet"],
  "preset": "nordnet",
  "excludeFiles": [
    "app/templates/_index.test.js"
  ]
}
➜  jscs-exlude-files-bug git:(master) ✗ npm run jscs
><EMAIL_ADDRESS>jscs /Users/vlasta/projects/jscs-exlude-files-bug
> jscs app

parseError: undefined at app/templates/_index.test.js :
     1 |import sinon from 'sinon';
     2 |import { expect } from 'chai';
     3 |import <%= camelModuleName %> from './../src/index';
---------------^
     4 |
     5 |describe('<%= camelModuleName %>', () => {

1 code style error found.

you can reproduce this error here https://github.com/iamstarkov/jscs-exlude-files-bug

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/25449617-jscs-tries-to-validate-excluded-files?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

it seems to work fine, if you will delete plugins field

I check docs and jscs-config-nordnet implementation and cannot see any problem with jscs-config-nordnet

change preset from "nordnet" to "airbnb" also solve the issue

but anyway it should be some bug in jscs

What happens if you change
 "excludeFiles": [
    "app/templates/_index.test.js"
  ]

to
 "excludeFiles": [
    "./app/templates/_index.test.js"
  ]

?

it doesn’t help https://travis-ci.org/iamstarkov/jscs-exlude-files-bug#L43-L65

Thank you for the repo, this looks severe, so this should fixed soon and release should happen on monday.

@markelog any news here? also is there anything I can help with?

There you go - #1652


Angular2 Support?

Do you have any plans to add Angular2 support? I know it's still under development, so I don't expect a working version now, but do you expect to update this library when Angular2 is stable?

I think we could give it a shot. Angular2 has made drastic changes in regards to directive approach, so it may require a complete rewrite.
Still, it'll be a fun experiment to do so yes -- I'll give it a shot. =)

Good to hear. We're rewriting our app from ng1 to ng2, and it's nearly a complete rewrite, so I get that it's non-trivial. Part of it for us will be rewriting or replacing 3rd-party libs that no longer work, so it's good to hear that ng-pattern-restrict might not have to be on that list :)
Thanks

Hi @LMFinney, just a heads up since I know you're relying on me.
I have not been able to get into Angular2 yet there are a few things to finish on my queue before I even do. I think that this could take a little bit more, I'm thinking in the range of weeks or a few months, depending on what else comes up in my personal life.
PS: I'd be really interested to see what project (if public) you're using this library in. I never took it very seriously and knowing that it is actually being used in real projects makes me really happy.

No problem - we aren't going to be freezing code on this project for many months, so we have time to wait on your or look for alternatives (or perhaps rewrite ourselves and offer a PR).
Unfortunately, it's not a public project - it's the user interface for a medical device.

I have migrated ng-pattern-restrict.js to TypeScript/Angular 2 beta.1 locally. I have requested permission from my management to contribute this new code back to you. If I get clearance, how would you like it? I haven't done a PR before, and I'm not sure you want a PR on top of the working AngularJS version, so maybe that wouldn't be the best (maybe you prefer to post it in a new fork, for example).
I'll let you know if/when I get permission, and then we can arrange how you want me to contribute the code back.

The initial response from management prohibits me from contributing back. We'll keep trying.

Hi @LMFinney. That's great, thank you very much.
The code is distributed under MIT licensing, so companies are allowed to make efforts out of it and not share it. I really appreciate you putting up a fight in that aspect, but I understand a company may decide otherwise.
As for how to contribute it, I had created an angular-beta branch, and your initial PR would basically wipe out anything that I have in place and set the foundation for the new version. This will be a branch that would evolve with AngularJS until it is actually released, at which point, after a final revision and adjustment, I'd switch branches around to make the Angular2 version the official for this repository, and the Angular1+ an old version that we support.
Thanks again, I really appreciate it!

I have created a sister project for Angular 2+ compatibility. There are certain aspects missing on that project, like the correct setup of automated testing, but the overall working of the directive is in place.
The project is a-pattern-restrict.


fix(datastore): initalSync should be successful in case of unauthorized errors

initalSync should be successful in case of unauthorized errors
Issue #, if available:
Description of changes:
Check points:

[ ] Added new tests to cover change, if needed
[ ] All unit tests pass
[ ] All integration tests pass
[ ] Documentation update for the change if required
[ ] PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1299 (7acd315) into main (0d1eb60) will decrease coverage by 1.11%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
- Coverage   60.60%   59.49%   -1.12%
==========================================
  Files         660      616      -44
  Lines       19820    18622    -1198
==========================================
- Hits        12012    11079     -933
+ Misses       7808     7543     -265

Flag
Coverage Δ

API_plugin_unit_test
65.74% <ø> (+0.09%)
:arrow_up:

AWSPluginsCore
?

Amplify
48.65% <ø> (ø)

Analytics_plugin_unit_test
73.41% <ø> (ø)

Auth_plugin_unit_test
82.31% <ø> (ø)

DataStore_plugin_unit_test
74.32% <8.33%> (-0.40%)
:arrow_down:

Predictions_plugin_unit_test
33.51% <ø> (ø)

Storage_plugin_unit_test
57.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...gin/Sync/InitialSync/InitialSyncOrchestrator.swift
62.96% <8.33%> (-17.99%)
:arrow_down:

...lugin/Operation/AWSAPIOperation+APIOperation.swift
78.37% <0.00%> (-5.41%)
:arrow_down:

...sCore/Model/Support/GraphQLDocumentnputValue.swift

...Plugins/Core/AWSPluginsCore/AWSPluginOptions.swift

...luginsCore/Model/Support/ModelSchema+GraphQL.swift

...e/AWSPluginsCore/Model/Support/Model+GraphQL.swift

...SPluginsCore/Auth/Provider/AuthTokenProvider.swift

...ginsCore/Auth/Provider/IAMCredentialProvider.swift

...ins/Core/AWSPluginsCore/API/AppSyncErrorType.swift

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d1eb60...7acd315. Read the comment docs.


[Feature Request] Make homescreen search widget functional and not just a shortcut to the DuckDuckGo app

As a FOSS AOSP user - one of the features I miss from the Google Launcher is a functional search bar widget that launches my default browser with a query.
It'd be awesome if this use-case could be accounted for in your widget.

Isn't there an option to open search  in default browser within settings? I think its "Use External Browser" with options always/Never.

@poppypundit the flow goes as such:

widget looks like an input on the homescreen
go to touch widget to input a search and instead of the keyboard popping up, the DuckDuckGo app launches at it's start screen.
From there if you enter a search it will launch your browser if the preference you mentioned is selected.

What I'd love:

click on the homescreen widget and a keyboard pops up and I'm able to type a query in the widget
on enter it launches the browser

Off-topic: It be amazing if DuckDuckGo maintained an open-source forked version of SWE (Chromium Browser for Snapdragon) and ensured it was always on stable and included DuckDuckGo as a search provider!  The few that stay up-to-date are closed source and don't always include DuckDuckGo


Go get fails to get a package when mod file has replace in a repo that imports packages from another go module in the same repository

What version of Go are you using (go version)?

go version go1.13.4 darwin/amd64

Does this issue reproduce with the latest release?
yes it does
What operating system and processor architecture are you using (go env)?
go env Output
GO111MODULE=""
GOARCH="amd64"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.13.4/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13.4/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/_4/g37z5y0j0t7dppmsyxymdsx00000gn/T/go-build977671086=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

api
├── apiA
│   ├── apiA.go
│   └── go.mod
└── lib
    ├── go.mod
    └── lib.go

Here is my mod file contents
apiA mod contents

module api/apiA

replace api/lib => ../api/lib

require (
    github.com/fatih/structs v1.1.0 // indirect
    github.com/grpc-ecosystem/go-grpc-middleware v1.1.0 // indirect
    github.com/sirupsen/logrus v1.4.2
    api/lib v0.0.0-00010101000000-000000000000 // indirect
)

In the above mod file last line the the require api v0.0.0-00010101000000-000000000000 is actually generated for the module in lib directory
Everything works fine as the code builds and runs fine but when I try to get a package from github with
go get<EMAIL_ADDRESS>What did you expect to see?
expected to get the package and add it to go.mod file
What did you see instead?
It throws below error
go: malformed module path "api/lib": missing dot in first path element
api/lib is referring to my module in lib directory and not sure why its making an http call to get api/lib though I used replace

shouldn't the replacement path be ../lib?

shouldn't the replacement path be ../lib?

Sure. Even if its so, that is not solving the issue that I am having

based on the information you gave, your current setup (ignoring the go get) won't build because your replace points to some nonexistent directory
if you fix the replace it will build and will go get properly (reason being it needs the entire dependency tree for version selection)

based on the information you gave, your current setup (ignoring the go get) won't build because your replace points to some nonexistent directory
if you fix the replace it will build and will go get properly (reason being it needs the entire dependency tree for version selection)

May I know why api/lib is  non existent directory ?

your replace is ../api/lib so go up from api/libA into api, go down into api/api, then down again into api/api/lib which doesn't exist in the directory structure you showed

This seems like a duplicate of #35273.

your replace is ../api/lib so go up from api/libA into api, go down into api/api, then down again into api/api/lib which doesn't exist in the directory structure you showed

Ah. I had to create an example as I cannot give away the structure I am actually using. but my local structure builds fine and go get fails at the last line of require section of go.mod

Hi @dayadev,
This sounds similar to #35273. What does the require statement in api/apiA.go? What does the package declaration at the top of lib/lib.go look like?


Auto-Assign Merge Conflict PR's

When there is a merge conflict doing the auto-sync from Master into the Feature and Child branches, is it possible to have the auto-generated PR automatically assigned to the last person who committed into the branch with the conflict or possibly the owner/creator of the branch?

Just realized this really belongs in the MetaCI repo. Closing this issue here.


JoinOn fails when referencing rowtype field in join condition

SELECT *
FROM tableA
INNER JOIN tableB
ON rowColumn.field = tableB.column
fails with:
Non-equi joins not supported

This is fixed in https://github.com/facebook/presto/pull/3636


While requesting Azure OpenAI I get Validation error "Extra inputs are not permitted"

Library name and version
Azure.AI.OpenAI-1.0.0-beta.16
Query/Question
I am using the library to create the request. It goes through but I get the validation error.
My request is configured in the following way
 var client = new OpenAIClient(new Uri(ENDPOINT_URL), new AzureKeyCredential(KEY));
 var chatCompletionsOptions = new ChatCompletionsOptions()
{
    DeploymentName = DEPLOYMENT_NAME,
    Temperature = (float)0.3,
    MaxTokens = 1024,
    NucleusSamplingFactor = 1,
    User = ACCOUNT_ID,
    ToolChoice = ChatCompletionsToolChoice.None,
    ChoiceCount = 1,
    Messages =
    {
        new ChatRequestSystemMessage(INSTRUCTIONS),
    }
};
  chatCompletionsOptions.Messages.Add(new ChatRequestUserMessage(question) { Name = ACCOUNT_ID });
  await foreach (StreamingChatCompletionsUpdate chatUpdate in client.GetChatCompletionsStreaming(chatCompletionsOptions))
{
	//PROCESS RESPONSE
}

This used to work without a hitch and I have not reports of model being changed
Any idea why this is happening?

Chiming in that I have also had problems starting yesterday (April 25 2024 ~12:00 EST) in making requests to the chat completions API through the SDK when including the optional Name parameter on ChatRequestUserMessage objects (and all the other variants)
Exception details:
Azure.RequestFailedException: Service request failed.
Status: 400 (Bad Request)

Content:
{"error": {"requestid": "1d1feecd-e686-44bb-9419-ec95212c0bad", "code": 400, "message": "Validation error at #/messages/1/name: Extra inputs are not permitted"}}

No changes to the SDK package we are using or the models that we have deployed.
Had to push a rush fix to remove usage of this Name parameter in our code to construct the chat history context for our requests to the chat completions API.


Delete is not working

Description
When I want to delete anything inside the File App it's not working. I tried in the Explorer and it worked fine.
Steps To Reproduce
Try to delete something with Del Button or the Menu
Requirements

e.g. Fix crash that occurs when...
No Crash

Files Version
Latest
Windows Version
22631.3296
Log File
debug.log

Thanks for the report,

Can you try restarting your PC
What version of Files are you on. Files settings > About

Additionally, is the app crashing? If not, are there already a lot of items in Recycle Bin?

Is the app crashing? If not, are there already a lot of items in Recycle Bin?

Let me check

@PierrunoYT Can you provide the information requested in the last comment

@PierrunoYT Can you provide the information requested in the last comment

I could not check it. Will open  new issue when I experience again.


⚠ Bofrost.be has degraded performance

In 4e77835, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1514 ms

Resolved: Bofrost.be performance has improved in 36ec0a3 after 6 minutes.


Spelling mistake

[Enter feedback here]
The document is good but i noticed a spelling mistake at the beginning of the article. first sentence said "There are numerous benefits to writing unit tests". i think it should be "There are numerous benefits to write unit tests"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 51947dc8-9ae8-21fa-13db-a7ffb3f9bc0e
Version Independent ID: be661bf5-6f6e-cd18-344b-253edf5751ae
Content: Best practices for writing unit tests - .NET Core
Content Source: docs/core/testing/unit-testing-best-practices.md
Product: dotnet-core
GitHub Login: @jpreese
Microsoft Alias: wiwagn

Hi @HadyAllam - thank you for posting this issue, however; this is proper English and the sentence structure is correct. I'm going to close this issue, but if you find anything else - by all means please open an issue.
Thank you


Reduce dangling session handle

Problem
There are lots of dangling session handle in our code, due to following 2 reasons:

The session is out of its life-span
The session is a unauthenticated session (PASE and CASE pairing)

Case.1 is solved by using Optional<SessionHandle>
Case.2 will be solved in the future by assigning an unauthenticated session, associate the session with its peer address
Change overview

Remove default constructor of SessionHandle
Replace some SessionHandle field with Optional<SessionHandle>, if the life-span of the field can be longer than the session. For example, ExchangeContext::mSessionHandle, the ExchangeContext can still exist even if the session has been closed, in this circumstance, the mSessionHandle should not hold a session.

Testing
Manually tested using unit-tests.

@mspang I have rebased the PR to use the new optional implementation.


Controller rigidbody/collider as separate tracked object

At the moment the controller rigidbody is attached to the controller so when it's active and it touches another rigidbody, the real world physics of the controller supersede game physics meaning the player can force the rigidbody through the other rigidbody (because the controller is updated with transform.position)
This can cause issues where the other item (e.g. if it's using joints) goes crazy in the games physics engine.
One solution is to have the controller a track_object so it's moved by it's rigidbody using velocity in the game world, however this has the issue that the controller model can become detached from the real world controller position and look jarring.
Another solution discussed in the slack channel was to have the rigidbody and colliders to be a separate track object that follow the controller model, but whereas now the rendered model can still pass through things to keep the 1:1 position lock with the real controller, however the colliders and rigidbody always adhere to game physics.
So if you pushed a button, your controller would pass through it with enough force but the rigidbody would stop at the full depress of the button (meaning it wouldn't snap through and provide force on the underside of the button)

IMO (and I believe this was the conclusion) the second option is much better. The first option sounds like what NewtonVR is doing, which definitely has it's pros but It doesn't seem like that is the direction VRTK wants to go.

yeah the first option is what NewtonVR does. However it can leave you in a situation where you can lose your controller behind an object (or even lock it in a drawer then it can't find it's way to snap back to the real position of the actual controller)

It seems you could do the same with the second option as well, except the collider and rigid body would be stuck and the player would have no idea where they went, so I assume some kind of timed/distance based snapping mechanism would need to be put into place.

Yeah exactly, a distance based reset (like what there already is on the Track Object)
So if you get too far away then the rigidbody snaps back to the controller.
However, this then has the issue again if you pass the object through something and the rigidbody exceeds the distance and snaps back then again it can apply force from the other side of the object.
It's an annoying trade off between losing synchronisation between the game controller and real world controller and not unduly applying forces to things

Did we ever get anywhere on this? The transform.position nature of the controller makes it impossible for me to swing a bat and hit a ball, my bat just passes through the ball every single time. It's a shame because there are so many great features to this engine, but without s solution i'm literally at a stand still on production.

@Igameart I think NewtonVR sounds like a good solution for you, have you tried it? It was built from the ground up for that kind of physical interaction.

@hcorion I had originally looked into that one but liked the extra goodies that this came with. After running into this issue though, i've started digging into NewtonVr a bit deeper. Just gotta add some locomotion and I think i'll be able to suffice with it. Thanks!

@Igameart @hcorion You want to use the Track Object grab mechanic if you want objects to move around with velocity rather than positional updates.
This is the same mechanic that NewtonVR uses.
This issue is about the controller colliders, not grabbed object colliders.

Can achieve this with an update to the Rigidbody Follow script.
I have a plan!

The rigidbody that is applied to the controller should never be used as a physics collider.
I propose removing the enable rigidbody on grab mechanic from the InteractGrab script and never have the controller colliders turn to non trigger (and the rigidbody non-kinematic).
In place I suggest a new script that enables a rigidbody with a set of controller colliders that follows the controller around.
It can have an activation button to enable the rigidbody and colliders that are tracking the controller. Also have the option to 1:1 track (which would just use the Set option on the rigidbody follow script).

https://github.com/thestonefox/VRTK/pull/1592


you don't have permission to view the data , server response : app configurations failed :something went wrong

Could you elaborate a bit more with respect to what issue you are facing? Which step in the deployment are you facing this issue? Are you able to configure the power apps and the flow properly? Have you ensured that you are using the same tenant for each of the steps in the deployment? More information would be helpful in closing this issue.


Update redirects in Readme

Created with https://github.com/dkhamsing/frankenstein

Thanks for sharing a frankenstein. I will look closer and probably add a checker to travis build.
As least there are no breaking links :)

:sweat_smile:

Actually this link
404 http://www.math.sci.hiroshima-u.ac.jp/~ m-mat/MT/SFMT/index.html
From
## Data Generators
 * [random.cr](https://github.com/scidom/random.cr) - Random number generation, provides interface for the [SIMD-oriented Fast Mersenne Twister (dSFMT)](http://www.math.sci.hiroshima-u.ac.jp/~%20m-mat/MT/SFMT/index.html)


Update continuous-integration.md

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: update release notes with required version of delegate
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6716b27c43c3d7bb0f961780--harness-developer.netlify.app


Hitting TOOMANYREQUESTS for scan-engine job

See https://github.com/dagger/dagger/actions/runs/11233423649/job/31227113107
Stdout:
invoke: input: container.from.withMountedDirectory.withMountedCache.withMountedDirectory.withExec.sync resolve: process "trivy fs --format=json --exit-code=1 --scanners=vuln --vuln-type=library --severity=CRITICAL,HIGH --show-suppressed /mnt/src" did not complete successfully: exit code: 1

Stderr:
2024-10-08T10:20:52Z	INFO	Need to update DB
2024-10-08T10:20:52Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-10-08T10:20:52Z	FATAL	Fatal error	init error: DB error: failed to download vulnerability DB: database download error: oci download error: failed to fetch the layer: GET https://ghcr.io/v2/aquasecurity/trivy-db/blobs/sha256:95d05be1e5cf9431ddaa617d84af4d0526511a39984d7a709f4043339931da6a: TOOMANYREQUESTS: retry-after: 454.813µs, allowed: 44000/minute
Error: Process completed with exit code 2.

This is annoying, there's maybe a token somewhere we need to be passing into the trivy container? Filing this issue and moving on, but will circle back unless someone picks this up.

Still seeing this, even after #8645.

Ohhh. I think https://github.com/dagger/dagger/pull/8645#issuecomment-2399543690 is the right fix, but I think the docker.json we pass only has creds for docker hub - not for ghcr.io.
We need to do a docker login ghcr.io somewhere.

Could this be a per image limit? 44000/minute is 733/s which I seriously doubt that we are generating this ourselves. Checking if I can find something about this upstream.

These seem related:

https://github.com/aquasecurity/trivy/issues/7598
https://github.com/aquasecurity/trivy/issues/7659

--db-repository public.ecr.aws/aquasecurity/trivy-db seems to be the short-term fix that we want: https://github.com/aquasecurity/trivy/issues/7598#issuecomment-2401784140


Consider migrating containers to GitHub Container registry

Docker killed free team organizations and then reversed its decision, as summarized here. We should consider migrating our containers to the GitHub Container registry as an alternative to DockerHub in case Docker goes ahead with this change in the future.

Nistha is working with All of Us data, which requires hosting containers on Google Cloud. We are going to look into generalizing SPRAS to support more than one container registry. That would also make it easier to migrate all of our containers off DockerHub in the future if we ever choose to.

The registry is now configurable after #132 so this would be easy to support if we decide to push containers to GitHub Container registry.


Conditionals with time

Looking for help on this...
hour = 3
minute = 45
There are plenty of places to get a late night bite to eat. However, they have different hours, so when choosing where to go, you have to think about who's still open!
Imagine you're choosing between the following restaurants:
Barrelhouse: Closes at 11:00PM
Taco Bell: Closes at 2:00AM
Cookout: Closes at 3:00AM
Waffle House: Never closes. Ever.
Assume that this list is also a priority list: if Barrelhouse is open, you choose Barrelhouse. If not, you choose Taco Bell if it's open. If not, you choose Cookout if it's open. If
not, you choose Waffle House.
However, there are two wrinkles:
We're using 12-hour time. hour will always represent a time from 10PM to 5AM.
That means that if hour is 10 or 11, it's PM; if hour is 12, 1, 2, 3, 4, or 5, it's AM. This will make your reasoning a little more complex. You may assume that all four restaurants open later than 6AM, though, so you don't have to worry about opening time, just closing time.

It's been a while, but this might still be useful. I've tested this code with all 8 relevant hours and it seems to work.
places = [("Barrelhouse", 11), ("Taco Bell", 2), ("Cookout", 3), ("Waffle House", None)] # A priority list of tuples containing the restaurant name and closing hour, or None if it never closes

def check_place(hour, minute):
    for place, closing_hour in places: # Iterate through each option
        if closing_hour is None: # If the place never closes, we can eat there
            print(place, hour) # Do what you want with the place name here
            break # Stop searching for places to eat
        if closing_hour in (10, 11) and hour not in (10, 11): # If this place closes in PM, then any current AM time will mean it's closed
            continue # Keep looking for a place to eat
        elif closing_hour in (10, 11) and hour in (10, 11): # If this place closes in PM but our current time is PM, we can compare them to see if it's still open
            if hour < closing_hour: # It's still open
                print(place, hour) # Do what you want with the place name here
                break # Stop searching for places to eat
        elif closing_hour not in (10, 11): # If the place closes in AM, then any AM time before the closing time or any PM time will work
            if hour in (10, 11): # Our hour is PM, so it will always be early enough
                print(place, hour) # Do what you want with the place name here
                break # Stop searching for places to eat
            elif hour < closing_hour: # If our hour is AM, we can directly compare it to the AM closing time to see if it has already closed (or closed this hour)
                print(place, hour) # Do what you want with the place name here
                break # Stop searching for places to eat


kubectl diff should have an option to use kubectl replace instead of kubectl apply to generate the diff

What would you like to be added:
A --replace flag or similar to make kubectl diff use kubectl replace over kubectl apply
Why is this needed:
currently there is no way to see fields that have been removed from a desired manifest in kubectl diff
for example, with live manifest:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: example-deployment
spec:
  template:
    spec:
      containers:
      - name: example-container
        image: example-image
        env:
        - name: THING
           value: blah

and desired.yaml:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: example-deployment
spec:
  template:
    spec:
      containers:
      - name: example-container
        image: example-image

kubectl diff -f desired.yaml will result in no diff
with --replace it would correctly show:
-        env:
-        - name: THING
-          value: blah

the change to kubectl is very simple and i've made and tested it locally. Happy to make a PR but wanted to make sure there is appetite for this change first

apply command is always the recommended command (especially with --server-side flag) and I don't think, we'd want to invest time on a imperative command replace.
I'd recommend always using kubectl apply --server-side and while using diff command, again always using diff --server-side (this should print out the removed environment variable in your example).
/close