TaggedScalar instead of Schema when using make_component

Hi,
if I try to load a  Component  registered through  make_component, I obtain a TaggedScalar instead of a Schema instance. For example:
test.yaml:
!ray.HyperBandScheduler

test.py:
schema = yaml.load(open("test.yaml"))
print(schema)
# Output: <ruamel.yaml.comments.TaggedScalar at 0x7fe8db40b310>
# Expected output: flambe.compile.component.Schema(...)

How can I obtain a Schema instance?

Solved, I was calling make_component with wrong arguments.


Makes actions accept a function

Hi there!
First of all: thanks a lot for this handy tool. It's easy to setup, configure and use. It's super-flexible compared to the custom Yeoman generator we used before — no need to publish a new version and ensure everyone is up-to-date. That's awesome ;-)
In our main project we quickly ran into a use case: when we create a new module it can have a collection+model or just a model, it may need a single item view or a collection view or a composite view…
The current way to do it would be either:

to create one generator per scenario, which would quickly scale into a monster
to create a module, then to create a collection, then to create a model…

That would be nice if plop asks us if we want a model or a collection+model right during module creation, and produces everything needed as once.
Hence, I simply made actions accept an array or a function that returns an array. If you provide a function, you've got prompts response in parameters. This way you can adapt actions regarding the answers.
This was the best solution I found to keep it simple. I've updated the README accordingly to explain this + made a usage example.
Passing by, this PR includes:

ignoring example/folder/ so it doesn't bother us in git when testing
a little typo correction

Let me know if something is wrong or missing.
Cheers!

Hi, thanks for taking the time to contribute. i'm so glad that others are finding plop to be as useful as I have. I'll review your PR soon and probably pull it in. I think the idea of having actions take an array or function is great! It adds a lot of flexibility without complicating the API. :+1:

:+1: Thanks a lot =)
Did you plan to create a new release that will include this change anytime soon also?

Yes, very soon. I'm just finishing up a little work I've been meaning to do, then I'll do another release and update NPM.

Sweet! That's good to know :smiley:

released and published to npm with v1.1.0 :-)

let me know if you experience any issues with this release. I don't anticipate any, but I still need to add tests (on my hit list)

No problem, thanks for the release ;-) :+1:


Version 2.2.2 middleware break Picture tags

Describe the bug
When I was developing app, I noticed images weren't loading properly (only alt image)
After messing around I disabled middleware for i18n and images came to life
Rollbacking to 2.2.1 proved it was astro-i18n update since on 2.2.1 it works
To Reproduce
Steps to reproduce the behavior:

Install latest astro-i18n
Add some Picture and Image tags
Check the result of _image query (it'll tell image is invalid and alt text will show up)

Expected behavior
Image loading properly
Mandatory reproduction repository
https://github.com/Herob527/astro-i18n-image-reproduction-repo
Additional images
Result without middleware:

Result with middleware:

@Herob527 can you try with defineAstroI18nConfig({ run: "server" }) ?

Can you try with this version ?  To install a local package you can pnpm add ./astro-i18n-2.2.2.tgz.

I did thing that I used Ctrl+F5 to ensure image will not be taken for browser cache
Logs with client+server

<EMAIL_ADDRESS>start
astro dev

astro  v4.2.1 ready in 101 ms
┃ Local    http://localhost:4321/
┃ Network  use --host to expose
23:33:11 watching for file changes...
response Response {
[Symbol(realm)]: { settingsObject: {} },
[Symbol(state)]: {
aborted: false,
rangeRequested: false,
timingAllowPassed: false,
requestIncludesCredentials: false,
type: 'default',
status: 200,
timingInfo: null,
cacheState: '',
statusText: 'OK',
headersList: HeadersList {
cookies: null,
[Symbol(headers map)]: [Map],
[Symbol(headers map sorted)]: null
},
urlList: [],
body: { stream: undefined, source: null, length: null }
},
[Symbol(headers)]: HeadersList {
cookies: null,
[Symbol(headers map)]: Map(1) { 'content-type' => [Object] },
[Symbol(headers map sorted)]: null
},
[Symbol(astro.cookies)]: AstroCookies {}
}
redirection null
response.bodyUsed false
body  Astro

  Astro
new body  Astro

  Astro
23:33:12 [200] / 139ms
response Response {
[Symbol(realm)]: { settingsObject: {} },
[Symbol(state)]: {
aborted: false,
rangeRequested: false,
timingAllowPassed: false,
requestIncludesCredentials: false,
type: 'default',
status: 200,
timingInfo: null,
cacheState: '',
statusText: 'OK',
headersList: HeadersList {
cookies: null,
[Symbol(headers map)]: [Map],
[Symbol(headers map sorted)]: null
},
urlList: [],
body: { stream: undefined, source: null, length: null }
},
[Symbol(headers)]: HeadersList {
cookies: null,
[Symbol(headers map)]: Map(1) { 'content-type' => [Object] },
[Symbol(headers map sorted)]: null
},
[Symbol(astro.cookies)]: AstroCookies {}
}
redirection null
response.bodyUsed false
body  Astro

  Astro
new body  Astro

  Astro
23:33:16 [200] / 17ms
response Response {
[Symbol(realm)]: { settingsObject: {} },
[Symbol(state)]: {
aborted: false,
rangeRequested: false,
timingAllowPassed: false,
requestIncludesCredentials: false,
type: 'default',
status: 200,
timingInfo: null,
cacheState: '',
statusText: '',
headersList: HeadersList {
cookies: null,
[Symbol(headers map)]: [Map],
[Symbol(headers map sorted)]: null
},
urlList: [],
body: { stream: undefined, source: [Uint8Array], length: 749 }
},
[Symbol(headers)]: HeadersList {
cookies: null,
[Symbol(headers map)]: Map(4) {
'content-type' => [Object],
'cache-control' => [Object],
'etag' => [Object],
'date' => [Object]
},
[Symbol(headers map sorted)]: null
}
}
redirection null
response.bodyUsed false
body

no html
23:33:16 [200] /_image 35ms
response Response {
[Symbol(realm)]: { settingsObject: {} },
[Symbol(state)]: {
aborted: false,
rangeRequested: false,
timingAllowPassed: false,
requestIncludesCredentials: false,
type: 'default',
status: 200,
timingInfo: null,
cacheState: '',
statusText: '',
headersList: HeadersList {
cookies: null,
[Symbol(headers map)]: [Map],
[Symbol(headers map sorted)]: null
},
urlList: [],
body: { stream: undefined, source: [Uint8Array], length: 58684 }
},
[Symbol(headers)]: HeadersList {
cookies: null,
[Symbol(headers map)]: Map(4) {
'content-type' => [Object],
'cache-control' => [Object],
'etag' => [Object],
'date' => [Object]
},
[Symbol(headers map sorted)]: null
}
}
redirection null
response.bodyUsed false
body RIFF4�
Logs with server:

<EMAIL_ADDRESS>start
astro dev

astro  v4.2.1 ready in 108 ms
┃ Local    http://localhost:4321/
┃ Network  use --host to expose
23:33:30 watching for file changes...
23:33:31 [200] / 127ms
23:33:33 [200] / 15ms
23:33:33 [200] /_image 55ms
23:33:33 [200] /_image 161ms

Can you please retry with 2.2.3 ? I pushed a possible fix based on the logs.

2.2.3 and 2.2.4 for my usage work find

great


Fuzz normal when layered on top of coat

Coat uses geometry_coat_normal, while other layers including fuzz use geometry_normal. Now that fuzz is on top of coat, this may no longer be correct.
Consider a material with a bumpy base layer, and a smooth coat layer on top that fills in the bumps. The fuzz should then have a smooth normal as well?
A solution could be to blend geometry_normal and geometry_coat_normal with coat_weight, and use that as the fuzz normal?

Can be closed, addressed in https://github.com/AcademySoftwareFoundation/OpenPBR/pull/117


[SPARTA-541][WEB]: Fix error editing policy

Fixed cube edition in order to be able to change values to attributes:

Fixed measure
isAutoCalculatedId
dateType

:shipit:

Comment accepted. Will treat it ASAP

Squashing and checks in progress.


individual pairing settings for each channel

Would it be possible to change the pairing settings for each icebreaker channel individually and right in the channel?
Otherwise one would have to deploy an icebreaker for each team/channel where different settings are required.
https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/95
https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/67
https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/80

For this microsoft-teams-apps-icebreaker repository, we are currently only making changes to fix critical bugs or deployment failures. Please consider forking the repository to implement your improvement and post back here if you're successful.

Good to know, thanks.

Thank you for submitting this issue, as we work to ensure consistent responses with items logged in our issues list, we are working to address these items that did not get responses. Please let us know if you are still facing this issue and require assistance and we will be happy to discuss. If no further action is needed at moment and no response is received, we will close out the issue in 3 business days. You may also always open a new issue or respond here if something does come back up. Thank you!

I'd recommend implementing it if someone's has the skills and time, I'm sure many regular users would benefit.

@markusd1984 We have added the feature/enhancement request to our backlog items. We will be taking it in our future releases depending upon the priority and bandwidth. For now, we are marking this request closed.

@markusd1984 We have added the feature/enhancement request to our backlog items. We will be taking it in our future releases depending upon the priority and bandwidth. For now, we are marking this request closed.

Many thanks, does this mean that there is still some life in the support and Dev roadmap for this kind of keyboard in coming months/year?
Logitech had a huge opportunity to disrupt the keyboard market especially for professional with workflow related apps.


Use utf8 decode on csv data to address internationalized chars

Apply utf8 decoding to csv data to display internationalized characters like à, ë correctly.
Before -

After -

https://bugzilla.redhat.com/show_bug.cgi?id=1570992

looks nice! thanks @AparnaKarve !


Fix various issues

Commit splitted and new consistent signed-off.
Changes have been tested on nvidia carrier board with tx2i module.

Hi @aragua,
Thank you for your work and contribution to meta-rauc-community. I have merged the pull request.
Thanks,
Leon


update dependencies and add versioneye badge

Problem
We have some dependencies out of date.
Solution
Update the dependencies.
Notes

I've added the versioneye badge so it'll be easier to track new versions.
I've removed the waffle.io badge, we aren't using it and I think its label "ready" is confusing.

Checklist

[x] Unit test all changes
[x] Update README.md if applicable
[x] Add [WIP] to the pull request title if it's work in progress
[x] Squash commits that aren't meaningful changes
[x] Run sbt scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

:+1:

:+1:


Material Design Icons v4.9.95

Would love to see Material Design Icons updated to v4.9.95 😃

@jizc  this has now been updated, and it will be released in the next version.


python311Packages.angr: 9.2.58 -> 9.2.59

Description of changes
Bump angr stack.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 243110 run on x86_64-linux 1

32 packages built:

python310Packages.ailment
python310Packages.ailment.dist
python310Packages.angr
python310Packages.angr.dist
python310Packages.angrcli
python310Packages.angrcli.dist
python310Packages.angrop
python310Packages.angrop.dist
python310Packages.archinfo
python310Packages.archinfo.dist
python310Packages.claripy
python310Packages.claripy.dist
python310Packages.cle
python310Packages.cle.dist
python310Packages.pyvex
python310Packages.pyvex.dist
python311Packages.ailment
python311Packages.ailment.dist
python311Packages.angr
python311Packages.angr.dist
python311Packages.angrcli
python311Packages.angrcli.dist
python311Packages.angrop
python311Packages.angrop.dist
python311Packages.archinfo
python311Packages.archinfo.dist
python311Packages.claripy
python311Packages.claripy.dist
python311Packages.cle
python311Packages.cle.dist
python311Packages.pyvex
python311Packages.pyvex.dist


The Editor Attaching checkbox step in Get started with Visual Studio and Unity is no longer valid

The Editor Attaching checkbox step on this page is no longer present in Unity as of the 2020 release, confusing first time users.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a35176f2-ca94-7bb8-08a5-9e415d364ef3
Version Independent ID: a9f184a6-78b9-315b-4a02-1c93bd4c3940
Content: Getting Started with Visual Studio Tools for Unity
Content Source: gamedev/unity/get-started/getting-started-with-visual-studio-tools-for-unity.md
Product: visual-studio-dev16
Technology: vs-unity-tools
GitHub Login: @therealjohn
Microsoft Alias: johmil

This issue is still actionable.

We've updated the docs and tried to reduce confusion on this. Thanks for reporting it and my apologies for the long time to resolution on this. Thank you!

#close

@WilliamAntonRohm This issue can be closed.

#please-close


AT-5.3: Review archived audits

Test Case ID: AT-5.3
User Story: ALTA-5.3 (#64)
As an inventory manager, I want to be able to review archived audits so that I can analyze the inventory’s accuracy levels for trends.
Acceptance Criteria
Given that the user is logged in as an inventory manager,

The user should be redirected to the Dashboard page.
The user selects the Audits side menu option.
The user is presented with a table containing the list of ongoing and archived audits.
The user selects the arrow at the end of a recorded audit. A brief drop-down table lists an overview of the select audit's content.
The user selects a desired audit and is presented with another table detailing the information of the audit.

Accepted.


Bootstrap styles not loaded: Bootstrap 4 + angular 2 webpack starter

I'm submitting a ...
[X] bug report / Missing Documentation

Do you want to request a feature or report a bug?
Repor bug / Missing Documentation

What is the current behavior?
After following https://github.com/AngularClass/angular-starter/wiki/How-to-use-Bootstrap-4-and-Sass-(and-jQuery) on how to install bootstrap, styles are not getting loaded

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
https://github.com/Abhijith-Nagaraja/Angular-WebPack-Starter-with-Bootstrap

I have cloned the Angular-starter repository. Removed all the components except the HomeComponent. Added Bootstrap according to https://github.com/AngularClass/angular-starter/wiki/How-to-use-Bootstrap-4-and-Sass-(and-jQuery).
run npm install and npm run server to simulate the problem

What is the expected behavior?
Bootstrap styles should be loaded on startup

Please tell us about your environment:

Angular version: ~4.3.1
Browser: [all]

Stack Overflow Link
https://stackoverflow.com/questions/45518183/angular2-4-with-bootstrap-scss-angular-webpack-starter#45518183

Sorry my bad. Some silly configuration issue.


Add secondaryHidden prop to avoid re-renders

This pull request provides an alternative API to hide the secondary pane.
Goal of this alternative API is to give users the possibility to avoid re-renders when hiding the secondary pane as described here #43 .
Therefore the new property secondaryHidden is introduced on SplitterLayout, which might be used as an alternative to conditional hiding the secondary pane.
If something is missing, please let me know.

Coverage decreased (-0.8%) to 99.219% when pulling 0d2580e76ef34b9d862bc2e67e5db8888ee30dcd on sebastianfrey:master into e0e54194071b778d83894179622b9ae1c58b8d34 on zesik:master.


Terraform 0.10.7 upgrade and plugins versioned

Updates to Terraform 0.10.7
Terraform 0.10 includes a change in provider-plugin handling, where all plugins get downloaded without versioning (latest).
As a measure to deal with plugin-versioning this pull-request also includes modified Dockerfile that downloads all needed plugins to a plugin-directory and the kn-apply command now includes the --plugin-dir pointing to this static directory.
Some changes in disk management in the google terraform modules to handle deprecated methods from earlier Terraform version
Update Docker image from alpine 3.4 to 3.6

GitHub cross-links

Fixes:

Docs:

closing in favour of #248


[FLINK-25686][Connector/Pulsar] Add schema evolution support for Pulsar connector

What is the purpose of the change
Currently the source connector reads all messages as Message<byte[]>, and implements a deserialization abstraction to deserialize the byte array message. This deserialization abstraction supports both flink schema and pulsar schema. However because of this extra layer of abstraction, even when using pulsar schema, the schema info is not provided to the consumer (client), so it is not using any pulsar’s schema validation mechanism. (If pulsar client has a schema, it will send the schema to broker on connect and broker will validate if it is a valid schema according to a preset compatibility rule: pulsar.apache.org/docs/en/schema-evolution-compatibility).
Brief change log

Add new BytesSchema for wrapping Pulsar original schema.
Added tests for different schemas.
Changed PulsarSchemaWrapper#decode() method.
Passing schema to split reader.
Refactor KeyValueSchemaFactory.

Verifying this change
This change added tests and can be verified as follows:

Added tests in PulsarDeserializationSchemaTest

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
The serializers: (yes)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (JavaDocs)

@flinkbot run azure

@tisonkun I'll check it.

KafkaShuffleExactlyOnceITCase always failed on my PR. I hate it.

With https://github.com/apache/flink-connector-pulsar/pull/1 getting close to get merged, let's not merge this PR but:

Wait for the mentioned PR to be merged
We'll release the Pulsar connector 3.0.0, which is the equivalent of the release-1.16 version.
We'll update the Pulsar connector with whatever changes that exist in master but haven't been externalised yet.
Move this PR (and other Pulsar PRs) to the external connector repository so we can separately from the Flink release, release a new version of the Flink connector.

Closing...


In eshell normal-mode using layout bepo, c is bound to evil-collection-eshell-evil-change

What did you expect to happen?
In eshell, normal-mode, using layout bepo, I would expect c to be bound to evil-backward-char.
What actually happened?
c is bound to evil-collection-eshell-evil-change.
Additional details:
These are the bindings for c in eshell-mode.
evil-collection-eshell-evil-change is an interactive function defined
in evil-collection-eshell.el.

Signature
(evil-collection-eshell-evil-change BEG END &optional TYPE REGISTER YANK-HANDLER DELETE-FUNC)

Documentation
Like evil-change but will not delete/copy the prompt.

Key Bindings
eshell-mode-map <normal-state> c

All three other movement keys (t, s, and r) are fine.
Steps to reproduce:

open an eshell
enter normal-mode
hit c

System information:
https://pastebin.com/pL15stRd

@gagbo is the maintainer of the :input (layout +bepo) submodule. Hopefully he can offer some insight into this.

The absence of a eshell-mode-map-evil-collection-backup-map in that describe-key probably means that the evil-collection-hook did not run on eshell-map. I'll try to check that later, but I'll probably have a go first at info-mode


[Things] Fix for applying tags to newly created todo(s)

Description

#13560: Tags are correctly appended to the deeplink while creating new todo(s).
Updated dependencies and resolved security vulnerabilities.

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

closes https://github.com/raycast/extensions/issues/13560

Thanks for your contribution 🔥
@loris do you want to check this?

Hey @pernielsentikaer @loris , thanks for the traction with testing. Although I don't have Things to test, the problem is pretty straight forward as I explained here: https://github.com/raycast/extensions/issues/13560#issuecomment-2244488891


Implements a flag to allow ignoring of empty hypotheses

Empty hypotheses passed for evaluation (common during early stages of training and evaluation) will raise an Assertion Error unless the ignore_empty argument of the get_scores method of the Rouge class is set to True.

Thanks for this PR.
I slightly modified it to make the feature available from command line (using a new --ignore_empty flag).
Note that this behavior should be avoided by default.

fixes: https://github.com/pltrdy/rouge/issues/14


[BUG] Volume head is always dirty after taking new snapshots

After taking a new snapshot and the application doesn't write new data to volume, the volume head is supposed to be clean. However, the volume head always has some data after taking new snapshots.
As a result, the recurring snapshot/backup job always taking a new snapshot/backup, and it overrides the important snapshots/backups.
This problem occurs in Longhorn v1.1.1 but not in v1.1.0
To Reproduce

Install Longhorn v1.1.1
Create a pod using a Longhorn volume
Wait for the actual size of the volume to stop increasing.
Take a snapshot. See that the volume head has a weird 4kb of data.
Repeat step 4 a few times.

Environment:

Longhorn version: v1.1.1

Just wondering does your test pod have a liveness probe or anything else that does a read operation on the filesystem? Does this happen when the volume is just attached i.e. not mounted?

Just wondering does your test pod have a liveness probe or anything else that does a read operation on the filesystem?

I think no.

I haven't tried attach only yet. I will do more investigation and report here.

It only happens when the volume is mounted. Possible the side effect of the fsfreeze -u command that we recently added https://github.com/longhorn/longhorn-engine/blob/3cc56fd7c02269718bbe276f78fe7257e46c6c1a/pkg/controller/control.go#L183. After taking snapshot, we unfreeze filesystem

The problem disappears after removing the fsfreeze -f and fsfreeze -u logic

After discussing in the team meeting, we decided not to fix this problem. We want to keep the fsfreeze logic because the filesystem's integrity is more important than the duplicated backups.

closing as per the discussion.


Question: Control the output of related data

Heya fairly new to ORM in general, I was wondering how to use withRelated to control the output of related data. For example:
I have a Post model and a Tags model, the Post Model is something like this:
	var Post = bookshelf.Model.extend({
		tableName: 'posts',
		tags: function() {
			return this.hasMany(Tags, ['post_id']);
		}
	});

and the Tags Model is:
	var Tags = bookshelf.Model.extend({
		tableName: 'tags',
		post: function() {
			return this.belongsTo(Post);
		}
	});

Currently if I do:
	Post.where('id', post_id)
		.fetch({
			withRelated: [
				{
					tags: function(query) {
						query.column('post_id', 'name'); // I understand that this doesn't work without post_id
					}
				}
			]
		})
		.then(function(post) {
			console.log(JSON.stringify(post, ' ', 2));
		})
		.catch(function(err) {
			console.error(err);
		});

I've found out by digging into the issues here how to select which columns I want from the related data, but the above outputs:
{
  id: 123,
  title: 'title',
  ...
  tags: [
    {
      post_id: 123
      name: 'tag 1'
    },
    {
      post_id: 123
      name: 'tag 2'
    }
    {
      post_id: 123
      name: 'tag 2'
    }
  ]
}

What I would like ultimately would be simply:
{
  id: 123,
  title: 'title',
  ...
  tags: ['tag 1', 'tag 2', 'tag 3']
}

Is this something that can be achieved with Bookshelf?

Depends on what you mean by "with Bookshelf". You can get that output by overriding the serialize method of any model, but that will be permanent, so you are probably better off just formatting the output using lodash or a simple Array.map.

I meant if it could be achieved within a model rather than using Array#map. Thanks, I'll look into serialize.
Are there any drawbacks in making it permanent if I want my data to look like that all the time?

Using models it's not possible since models will always serialize into an object. So, I think my first answer isn't correct. You should override toJSON(), which on second thought, is what allows you to control how a model will be transformed into a string.
AFAIK there are no drawbacks to that approach except for the obvious of only having one type of output when you want to stringify your models, or convert them to pure javascript objects.


added env vars and serverless permissions

Addresses Issue 1

Added ability to specify command-line arguments to make deploy target
make deploy AWS_ACCESS_KEY_ID=XXXX AWS_SECRET_ACCESS_KEY=XXX STAGE=dev REGION=us-east-1<EMAIL_ADDRESS><EMAIL_ADDRESS>Lambda function reads sender/recipient/region from environment variables
Added IAM roles to serverless deployment

@tkeech1 read my mind on the IAM role stuff. Perfect!


Catch invalid input type to OpConvertUToPtr

Fixes https://crbug.com/906426

Added a test

Can you update the description to say what the issue was you're fixing?


Added medusa-plugin-postmark

Added medusa-plugin-postmark.
README.md includes sample config and sample json files for pdf invoices

Thanks 🙏


Increase memory and CPU so OPP products will install

The attempt to install OPP failed because more CPU and Memory was needed. Increasing resources to match what AWS uses.
Running a test with this PR to see if it resolves the resource issue.

I moved the values to the configmap for aws and vmware.  This is ready for another look.


Select dropdowns do not support keyboard selection

When a plain <select> is opened or focused, you can use your keyvoard to navigate to an element. For example, if you have one with the options "foo", "foobar" and "flappy" (in this order), typing "f" will select "foo", but if you enter a lowercase L right afterwards, it'll select "flappy".
This is incredibly useful, especially for more technical people since scrolling through a big dropdown is kind of an unnecessary hassle if you already knoe what you want to select.
I realize there's the "Search Selection Dropdown" which does this, but I think it would make sense to provide functionality like in the native select widget even when not SSD.

Regular select and ui.dropdown side by side for easy comparison: http://jsfiddle.net/37yvutd0/1/
It looks like .ui.dropdown should close the list when you hit esc as well.

For some reason the escape hide menu shortcut was set to only work when menu was already closed :unamused:

I'm a bit afraid of the additional code overhead for adding the letter shortcuts into dropdown, but will investigate.

@ThiefMaster @Einkoro
Take back everything I said, I've gone ahead and implemented this and love it as a new feature :smile:


'AudioFileReadPackets' is deprecated: first deprecated in iOS 8.0

DOUAudioStreamer/src/DOUAudioDecoder.m:313:21: 'AudioFileReadPackets' is deprecated: first deprecated in iOS 8.0

用 AudioFileReadPacketData 替换掉上面这个过时的方法吧。


New Command in order to list all available blueprints

Please provide us with the following information:

In order to know all available blueprints (service, component, class, pipe, ...), the only (I think), is to checkout the blueprints folder on Github. Am i right ?
It should be interesting to add a new command in order to list these blueprints to the user, in order to know which element we can generate from angular-cli.

OS?  Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Versions. Please run ng --version. If there's nothing outputted, please run
in a Terminal: node --version and paste the result here:

Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code? etc.

The log given by the failure. Normally this include a stack trace and some
more information.

Mention any other details that might be useful.

Thanks! We'll be in touch soon.

Is the following command doing what you describe?
$ ng --help generate

ng --help generate partially does it, but also lists a lot of stuff we don't actually support.

For some reason there's a difference when running ng --help generate vs ng generate --help the former is controlled by ember-cli while the later allows our addon (the angular-cli) to override the generate command.


[DataTable&TableHeader]Object.values not supported for IE

Detailed description
see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/values
https://github.com/carbon-design-system/carbon-components-react/blob/master/src/components/DataTable/TableHeader.js#L93
https://github.com/carbon-design-system/carbon-components-react/blob/master/src/components/DataTable/DataTable.js#L101

Hi @nicoxxie! 👋 Thanks for making this issue. For features that aren't supported in older browsers, typically we recommend teams to include something similar to: https://github.com/babel/babel/tree/master/packages/babel-preset-env in their build environment so that these features can be polyfilled.
Let me know if this is an issue for your team!

Closing this due to inactivity. Feel free to re-open or comment if you feel like this wasn't addressed!


Remove embedded dependencies

As suggested by @furyfire, it would be good to remove the dependencies from the library. It was impossible before because of PubSubClient that would not accept a method as its callback function, so I had to modify the library. It is now possible since knolleary/pubsubclient@98a9c296f6d469a9b6221eb2e29655610b4d7583 , and released in version 2.5.
So, to work, Homie would require PubSubClient >= 2.5, Bounce2 >= 2.0 and ArduinoJson >= 5.0.8 to be installed. The problem is there is no way to declare dependencies for Arduino libraries. Users would have to download 4 libraries, instead of just one. But they would benefit from the library manager of the Arduino IDE, enabling Homie to use latest versions of the dependencies without us maintaining.
Maybe just provide in the installation guide, the links to the 3 .zip of the 3rd party libraries? This is an overhead, but this is definitely cleaner than just embedding the libs.
What do you think? @enavarro222

I'm behind you on this. Mostly because I use platformio which makes it fairly easy to download required libs. I know the platformio project is brewing on building a framework for dependency management under embedded development (think npm, bower and composer for embedded)

I know, I advised them to use semver. But until 3.0 is released, there is no reliable way to declare dependencies. And, PlatformIO is not very used yet.

Nice ! Will be clearly better without copy of dependency.
With arduino IDE library manager it's really trivial to install dependency (I'm quite sure that the 3 needed are available with the default config).
So yes, one step more to have a basic Homie example working. But it's a small one.
Another point : I'got a Homie device that also use Bounce2. If one include it naively (from arduino lib. dir) it do not compile (conflict with the homie/3rd/bounce)... Same could appear with the JSON lib.

Yes, I did not managed to import libraries into the Homie namespace, this is one of the reasons why I want not to embed dependencies.

Done in 9644a8cc85ecd46cece591e92f5d5c90328d4ece. I added a note in the Wiki, about dependencies.


error: filterBy is not a function

I don't see any issues on this so it's probably just me so I apologize in forehand. I get "filterBy is not a function" error.
This is my render method:
var table =
;

return (

        { table.filterBy( query ) }
        { table }

);

Rather than storing the return value of
 and referencing that, in your case you need to use a React ref, on the
, and reference that.

I'm sorry but I can't wrap my head around this. I get the same error as before. When i console this.refs.itemsTable I see that the first time it will be undefined. Then it will render two more times with reference to the table.
This is my render:
this.refs.itemsTable.filterBy( query );
return (

);


Produce list of synonyms for addresses

i.e. St = Street, Rd = Road, etc
The format should follow Elasticsearch conventions, for the above it would be:
court => court, ct
street => street, st

I'll take a first crack at this if no one has started.
Between @wpears link and the Pub 28 site I think I have enough. If there is something else to look at let me know.

@awolfe76 This is already being worked on by @lesgou, please coordinate with her.

lets bring this up at scrum.  i kind of want @kgudel to do this, for the experience.  has someone proposed a format?  am assuming json (like what @wpears sent - https://github.com/openaddresses/machine/blob/master/openaddr/expand.py)

@feomike @awolfe76  There is a specific format that Elasticsearch needs for the synonyms file (synonyms.txt), I already sent that out to @lesgou and it looks something like this (contrived example):
# Abbreviations
court => court, ct
3 street => street, st

#States
4 maryland => md, maryland

ok, got it.  thanks @jmarin

@jmarin i was using a slightly different format.
court, ct
street, st

maryland, md

From my understanding this way there is no "replacement" of values, it just treats the two as the same at search time.

I took a stab at this a while back as part of the parser.  It's based on
the pub28 abbreviations.
https://github.com/hkeeler/grasshopper-parser/blob/normalize/abbreviations.yaml
On Fri, Aug 21, 2015, 8:59 AM Juan Marin Otero<EMAIL_ADDRESS>wrote:

@feomike https://github.com/feomike @awolfe76
https://github.com/awolfe76 There is a specific format that
Elasticsearch needs for the synonyms file (synonyms.txt), I already sent
that out to @lesgou https://github.com/lesgou and it looks something
like this (contrived example):
Abbreviations
court => court, ct
3 street => street, st
#States
4 maryland => md, maryland
—
Reply to this email directly or view it on GitHub
https://github.com/cfpb/grasshopper/issues/134#issuecomment-133473319.

Here's the ES documentation on the syntax for synonyms file. You'll see multiple formats for the synonyms:
https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis-synonym-tokenfilter.html#_solr_synonyms
After the after scrum meeting the => method is the way to go. Its better for several reasons when you know the data set has a standard. For example, in tiger we know that Avenue is always spelled out in the data (it's never ave or av).
For data sets that don't have this standard another synonyms format may be better.
@jmarin @feomike - just want to make sure I have that right.

:+1:

That is correct


:sparkles: Make site images configurable through db

I've suggested a change for your seeder - simply press "commit changes" for them to apply.
Besides that I noticed you have added an entry in your seeder for the backdrop on the "me" page, but there's no code that actually uses this - I've posted the code necessary below.
Go to app.css within resources/themes/atom and on line 101 remove the following: background: rgba(0, 0, 0, 0.3) url('/public/assets/images/kasja_mepage_image.png');
Next up go to the me-backdrop.blade.php and replace

with

Otherwise great job! and thank you for the contribution 👍🏻


[SR-12827] [Diagnostics] Improve diagnostics keypath hole involving generic argument

Improve diagnostics involving key path root and generic arguments.
cc @xedin @hamishknight
Let me know what you think :)

Resolves SR-12827.

@swift-ci please smoke test


Button not injected when returning to Code tab

To reproduce:

go to a Github repo page (ie https://github.com/redhat-developer/try-in-web-ide-browser-extension

Click on 'Issues'

Click on 'Code'

The button is not injected:

Fixed by https://github.com/redhat-developer/try-in-web-ide-browser-extension/pull/16


Provide proper documentation for non-mutating functions

A quick clean up to help with #160 to avoid wasting time.

I think this still needs to be addressed.

Ah sorry, I thought I'd save you some time with this. Should I close this?

@jon-tow no, this is good work. We can discuss some things about the variety of functions in Math.swift, this does save time.

I confirm the co-authoring!


[question] Reproduce the result of PPO on RoboschoolHumanoidFlagrunHarder

Hi @araffin ,
Current I am trying to reproduce the result of PPO paper with the environment RoboschoolHumanoidFlagrunHarder.
As I have tried almost every settings, there is still a big gap between mine and their.
I have just modified the code to make logstd=LinearAnneal(-0.7, -1.6) as in the paper.
As I printed the logstd in the distribution.py file, I got:
<tf.Variable 'model/pi/logstd:0' shape=(1, 17) dtype=float32_ref>
However, as I tried to add the following code to the end of PPO2 constructor:
with tf.variable_scope("model", reuse=True):
    self.logstd = tf.get_variable(name='pi/logstd:0')

I got this:
ValueError: Variable model/pi/logstd:0 does not exist, or was not created with tf.get_variable(). Did you mean to set reuse=tf.AUTO_REUSE in VarScope?

I had also just use the variable name "pi/logstd" but it was still failed.
How could I change the value of logstd during training?
Thanks.

Hello,

I had also just use the variable name "pi/logstd" but it was still failed.

I think the variable you are looking for is created here when it is called from the [policy].(https://github.com/hill-a/stable-baselines/blob/master/stable_baselines/common/policies.py#L440)
I would check what is the scope of that variable (probably model/... and not directly pi/)

This works for me (without the :0):

with tf.variable_scope('model', reuse=True):
    print(tf.get_variable(name='pi/logstd'))

I will try that. Thank you.

Anyway, where did you put that?
I have tried that at the end of PPO2 constructor but it still shows the same error message:
ValueError: Variable model/pi/logstd does not exist, or was not created with tf.get_variable(). Did you mean to set reuse=tf.AUTO_REUSE in VarScope?

Could you show the code for that testing? I have tried it even in other places but it still shows the same error. Thanks.

@doviettung96 Let me know if you're able to train RoboschoolHumanoidFlagrunHarder successfully.  I was not able to, even with annealing the logstd.

@BruceK4t1qbit ,
How good is your trained agent? Could you provide some statistics like mean reward or the tensorboard graph? I am trying to use the logstd annealing but for now the Roboschool library runs into a problem of building from source.
Anyway, did you try all the settings from the PPO paper?
Thanks.

@doviettung96
I tried to use all the settings from the PPO paper (It was a while ago, I forget the details).  Modified the original baselines' code to do this.
I didn't use tensorboard - just looked at the rendering.
I've found the pybullet_env is much easier to install than roboschool...

@BruceK4t1qbit ,
I think you might need the mean of episode rewards to have something to compare. For now, I have also changed the code to use all the settings. As suggested, openai baselines or stable baselines are not the original version of the code using in the PPO paper. Therefore, I am not sure if we could reproduce the result. If you could find any improvement, please let me know.
Thanks.

@BruceK4t1qbit ,
I just have a test with it and found that logstd annealing is not important. The result is quite far from the paper.

@doviettung96
I recently also tried SAC on it, which seemed to get stuck in the same local optimum...

@BruceK4t1qbit ,
Really? My next step is also DDPG, TD3 and SAC. With this news, I don't know if we could train it successfully. Thanks.

@BruceK4t1qbit ,
I have not tested the result carefully, but just by now, my result is quite close to the trained agent in the roboschool.
Everything is set as in the paper. The agent is trained with 400M timesteps (as in the roboschool trained agent).
Just try it again.

So it is just a matter of good luck?

I don't think so. Changes are necessary to improve the performance for those tasks. Just it is quite difficult to know what should we add up to improve.

So what did you change?

@erniejunior ,
It depends on your starting point. If your starting point is the PPO paper, just increase the total timesteps to 400M and use deeper network (hidden layer: 512-256-128 with relu activation for example).

Thanks!  I didn't try such a big network


Update tests for Cdn service

Update tests for Cdn service based on the most recent changes
https://github.com/Azure/azure-rest-api-specs/pull/5850

@hytao tests are still failing here
https://azuresdkci.westus2.cloudapp.azure.com/view/NetCore-SDK/job/NetCore-SDK-Sign/558/console

Tests are passing here
https://azuresdkci.westus2.cloudapp.azure.com/view/NetCore-SDK/job/NetCore-SDK-Sign/560/console


Reminder Notifications - Post to Request History

As a user
I want to confirm that a reminder has been sent, by seeing it posted in the request history
so that I know the other user has been notified

Assumptions & Scope
This story is meant to cover off any notification around due date reminders, to ensure they are logged as part of the request history. This is an important part of the audit trail and is a feature requested by users.
What is IN scope?
Any reminder related notification will be posted to the request history portion of the application
What is NOT in scope?
Acceptance Criteria
Scenario 1: System Sends Reminder Notification

GIVEN a request has a due date associated with it
WHEN the notification is sent to assigned users for that due date
THEN the notification comment will also be posted to the request history as a system generated comment

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

Testing on EDU-2022-113355 - but must wait for tomorrow to confirm (can't spoof date or force notification on my end)

Divisional due dates are showing up in the Request History Comments - however, I assume we also want CFR and LDD due dates be posted as well? To confirm.

Yes @KyEggleston. CFR & LDD due dates also should be posted.

Thanks @aparna-aot - found some requests to confirm notifications for CFR and LDD are posted (as I couldn't backdate or spoof a date to test). Closing ticket.


I'm not sure how changeMonth() method works

Below my datepicker, I need 2 links that allow the user to go N months ahead. I must be using it wrong though, because even in very simplified circumstances (jsfiddle bellow), nothing happens (not even an error).
console.log(fp) shows an instance after clicking the link, so that should not be the issue.
Fiddle
https://jsfiddle.net/cibulka/tj2Lo4z7/8/
Environment

flatpickr version used: 4.1.4
Browser name and version: Firefox 57.0.1
OS and version: OSX 10.12.6

Hello,
I don't see any issues.
After clicking the link, the calendar closes and the month changes to may 2018.

Thanks for a quick response!
I've updated text of the link in the fiddle to make it a bit clearer. The link "+5 months" should add 5 months to currently selected date by using method changeMonth.
When I select the date and click on the link, nothing happens (not even an error) - that makes me think that I don't understand how to use changeMonth method.
Could you tell me what am I doing wrong? Thanks!

Oh, I see.
changeMonth() simply changes the current month in the calendar, it doesn't affect the selected date.
If you wanna manipulate the date(s), use the selectedDates field which contains the selected dates, add months to it, then update the selected date.
Something like https://jsfiddle.net/chmln/3fqd91um/1/
:)

Thank you very much, especially for a very clear example! This is exactly what I needed.


Java branch

Thank you very much @amroessam  you basically gave us the solution, I've just cleaned it up to Working solution using java 7 and documented with how to's for dummies.

Included in:
https://github.com/leantechnologies/integration-snippets/pull/3


Issue with the ios

The same issue as the previous one

Can you test example?

Yeah it is the same but the methods should work for our application
Thanks and Regards,
Zorawar Singh
On 10-Aug-2021, at 1:32 PM, Pansheriya Jayesh @.***> wrote:

Can you test example?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/jayeshpansheriya/flutter_native_contact_picker/issues/2#issuecomment-895817805, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT4GQ6ULKGBHUMOGATMZJUDT4DMIVANCNFSM5B2Q3ZEQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

@Zorawar920  create new flutter project add flutter_native_contact_picker: ^0.0.3 in your yml file and check it, its working, i have also check its working, you can also check i have given example.
Thank you.

https://github.com/jayeshpansheriya/flutter_native_contact_picker/pull/8
https://github.com/jayeshpansheriya/flutter_native_contact_picker/pull/9
Fixes in above PR


Fix cop header comment

The following unification/fixes were implemented.

Line break after @example
Good/Bad -> good/bad
better -> good
Add empty comment line at the end of header comment
Fixed indentation errors
Fixed function header errors

The indentation will also be modified on the document as follows.
before

after

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[-] Added tests.
[x] Updated documentation.
[-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[-] Added the new cop to config/default.yml.
[-] The cop is configured as Enabled: pending in config/default.yml.
[-] The cop is configured as Enabled: true in .rubocop.yml.
[-] The cop documents examples of good and bad code.
[-] The tests assert both that bad code is reported and that good code is not reported.
[-] Set VersionAdded in default/config.yml to the next minor version.

If you have modified an existing cop's configuration options:

[-] Set VersionChanged in config/default.yml to the next major version.

While all these changes look 👍🏼 and consistent, I cannot help but think we need … a linter :-) Do we have anything available, or would we need to build something ourselves?
Also @ydah can you show why the changes are necessary with e.g. screenshots of how it renders before after indentation change, etc.?

While all these changes look 👍🏼 and consistent, I cannot help but think we need … a linter :-) Do we have anything available, or would we need to build something ourselves?

I too would like to leave this kind of work to the linter ;-)
But, I have no idea of a good Linter right now.


SwapStrategies is undefined:  "cannot load 'after' of undefined"

I'm submitting a bug report

Library Version:
1.0.1

Please tell us about your environment:

Operating System:
Windows 10

Node Version:
7.7.4

NPM Version:
4.4.4

JSPM OR Webpack AND Version
using CLI

Browser:
Chrome up to date

Language:
TypeScript 2.2

Current behavior:
When loading the app, I get  cannot load 'after' of undefined. and a blank screen. This appears to come from router-view.swap() at the following line:
         var swapStrategy = _aureliaTemplating.SwapStrategies[_this2.swapOrder] || _aureliaTemplating.SwapStrategies.after;
because swapStrategies is undefined.
I'm not at all familiar with this code but I didn't see any other reference of swapStrategies in this module so I don't know where it's supposed to be created.
When reverting to 1.0.0, it seems to work well (and I can see swapStrategies declaration in the code).

What is the expected behavior?
It should not affect the loading of the page. I have no swap-order defined on the router-view, anyway...

What is the motivation / use case for changing the behavior?
Seems to prevent the app from loading

Make sure all your dependencies are up to date.

@EisenbergEffect I have the same issue after upgrading my project to latest aurelia release:
_aureliaTemplating.SwapStrategies[_this2.swapOrder]
causes
ERROR [app-router] TypeError: Cannot read property 'before' of undefined
I am sure that my dependecies are up to date.

How can it be fixed ?

One way to pull in the latest aurelia-templating is to explicitly add it to your project e.g.
npm install --save aurelia-templating

If it's being pulled in as the dependency of another package then ncu doesn't seem to update it.


bug fix: fix navbar toggler in responsive mode #23926

This PR fixes #23926; it seems to do the trick.
Tested in recent versions of Chrome, Firefox,...and IE10.

Sorry @Fouzyyyy but not only doesn't solve the issue but it's also not an elegant solution in my opinion. What I did on my PR works, I just need to adjust it to different breakpoints.


enable FIPS in 4.x by default

FIPS checks and details are here: https://issues.redhat.com/browse/OADP-63
As far as we can all of our 4.x projects will have to be FIPS compliant.

Is this still relevant and gtg?

oh my.. 12 months ago.. I've been here 12 months?
I suspect this patch doesn't do enough for it to be a problem.  Crazy no rebase is needed, low bandwidth repo


[Bug]: get_cursor_location_for_pane seems wrong for the side panel in crab saber

What happened?
It looks like the x coordinate of the cursor location on the side panel in crab saber is wrong, with a value along the lines of (correct_x + width)/2. Not sure yet if this is because it's not centered, or because it's not square, or because of something weirder.
Version
latest
In which Hotham component are you seeing the problem on?
Core
What VR System are you seeing the problem on?
Quest-2
What OS are you seeing the problem on?
No response
Relevant log output
No response

I believe this has been fixed


Atomics.wake(...) always returns 0 on non-win32 platforms

While working on Atomics tests for Test262, I observed that any test which checked that the return value of Atomics.wake(...) was some non-zero value, the test would fail. I've tracked the cause:
https://github.com/Microsoft/ChakraCore/blob/c0723f4985c468937c6ac12260bdbe5da6d25539/lib/Runtime/Library/SharedArrayBuffer.cpp#L764-L780

On a related tangent, TC39 has apparently agreed to rename Atomics.wake to Atomics.notify.  See, e.g. this Node.js issue:
https://github.com/nodejs/node/issues/21219


support quay robot token pattern

The only official reference to syntax I could find was this image

from https://access.redhat.com/documentation/en-us/red_hat_quay/3/html/use_red_hat_quay/use-quay-manage-repo
Pretty sure it's just "[A-Z0-9]{64}" though.

This particular pattern might be overly susceptible to false positives, but maybe sufficient to only check within word-boundaries, "\b[A-Z0-9]{64}\b"

Seems awfully slow too :sweat: . Seeing almost 100x runtime overhead :/

Hi @jmelahman, for patterns without a predefined prefix, ripsecrets relies on the random secret detector (found here: https://github.com/sirwart/ripsecrets/blob/main/src/matcher/mod.rs#L9). This will catch these tokens as long as they're on the same line as something that indicates it's a secret (such as "token", "secret", or "password").


Manual build in Github Actions failing at start attempt of secretservice: Error: Process completed with exit code 3.

Hi I'm doing a manual build from a ubuntu runner in github actions and it gets up to the command "systemctl status --user secretserviced.service" and it fails there. Your docs don't indicate any dependencies, are any required?
// some of the lines are my own comments
go: downloading github.com/sirupsen/logrus v[1](https://github.com/archway-network/keyring-go/actions/runs/4387744808/jobs/7683401489#step:7:1).8.1
go: downloading github.com/godbus/dbus/v5 v5.0.6
go: downloading gopkg.in/natefinch/lumberjack.v2 v2.0.0
go: downloading gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
go: downloading golang.org/x/sys v0.0.0-20220209214540-3681064d5158
go: downloading github.com/google/uuid v1.3.0
go: downloading github.com/monnand/dhkx v0.0.0-20180522003156-9e5b033f1ac4
go: downloading golang.org/x/crypto v0.0.0-20220210151621-f4118a5b[28](https://github.com/archway-network/keyring-go/actions/runs/4387744808/jobs/7683401489#step:7:29)e2
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading github.com/spf13/viper v1.10.1
go: downloading github.com/spf13/cobra v1.3.0
go: downloading github.com/fsnotify/fsnotify v1.5.1
go: downloading github.com/magiconair/properties v1.8.5
go: downloading github.com/mitchellh/mapstructure v1.4.3
go: downloading github.com/spf13/afero v1.8.1
go: downloading github.com/spf13/cast v1.4.1
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading gopkg.in/ini.v1 v1.66.4
go: downloading golang.org/x/text v0.3.7
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/pelletier/go-toml v1.9.4
copy secreteserviced.service file
Start systemctl
Enable secretserviced
Created symlink /home/runner/.config/systemd/user/default.target.wants/secretserviced.service → /home/runner/.config/systemd/user/secretserviced.service.
Enable secretservice
● secretserviced.service - Service to keep secrets of applications
     Loaded: loaded (/home/runner/.config/systemd/user/secretserviced.service; enabled; vendor preset: enabled)
     Active: activating (auto-restart) (Result: exit-code) since Fri 2023-03-10 19:20:22 UTC; 6ms ago
       Docs: https://github.com/yousefvand/secret-service
    Process: 3430 ExecStart=/home/runner/work/keyring-go/keyring-go/secretserviced (code=exited, status=203/EXEC)
   Main PID: 3430 (code=exited, status=203/EXEC)
        CPU: 1ms
Error: Process completed with exit code 3.

I have no idea. You may look at my setting as an example.


python311Packages.guidance: 0.1.6 -> 0.1.11

Diff: https://github.com/guidance-ai/guidance/compare/refs/tags/0.1.6...0.1.11
Changelog: https://github.com/guidance-ai/guidance/releases/tag/refs/tags/0.1.11
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 293140 at 6b6eaf83 run on x86_64-linux 1

1 package marked as broken and skipped:

python312Packages.guidance

1 package built successfully:

python311Packages.guidance

Result of nixpkgs-review pr 293140 at 1b7d1bd6 run on aarch64-darwin 1

2 packages built successfully:

python311Packages.guidance
python312Packages.guidance


Update section title and add-in link

Make the section title more friendly.
Update the add-in link from store to app source one, which supports work/school account

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/actionable-messages/actionable-messages-via-email.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Auditing {Hashtbl,Table}.add{,exn}

I grepped all usages of these functions to check we were using them correctly. That is, consistent with the understanding that these functions should only be used when the given key is not yet in the table.
Here is the summary. There are several remaining usages I need the author to check. I used git blame and request that the author of each usage examine whether the function is being used correctly, and if so to approve this PR. Thank you!
Need info
src/app/cli/src/coda_worker_testnet.ml:464 @psteckler
src/app/cli/src/coda_worker_testnet.ml:529 @wu-s-john
src/lib/cache_lib/impl.ml @ghost-not-in-the-shell
frontend/website/src/Links.re @Schmavery
src/lib/kademlia/membership.ml @bkase
src/lib/transition_handler/catchup_scheduler.ml @ghost-not-in-the-shell

There's only 1 add_exn in cache_lib/impl.ml:
    let register_exn t x =
       let final_state = Ivar.create () in
       Hashtbl.add_exn t.set ~key:x ~data:final_state ;

It used to return an Or_error.t:
    let register t x =
       let%map () = Hash_set.strict_add t.set x in
       Cached.create t x

while in all usage site, we would do something like this:
let x = Or_error.ok_exn (Cache.register cache data) in
ignore (Or_error.ok_exn (Cache.register cache data)) ) ;
let cached = Or_error.ok_exn (Cache.register cache data) in
Cache.register cache data |> Or_error.ok_exn
let src = Or_error.ok_exn (Cache.register cache data) in

Since we are using Or_error.ok_exn every time in the usage site, I thought maybe it's cleaner that we let the function throw the exception by itself. That's the justification behind the use of add_exn there.

As for catchup_scheduler, the use of add_exn is justified because I just did the membership check 1 line above it.

src/app/cli/src/coda_worker_testnet.ml:464 @psteckler: the add_exn is in code used for the delegation test, where it's run exactly once.
Conceivably, if a test called this delegation test function more than once, with the same delegator/delegatee/fee, this would raise an exception. But it's in test code, so doesn't make the  code for users vulnerable.

src/lib/kademlia/membership.ml @bkase this can definitely have duplicates and we don't want to crash -- right now it's done with let _ = Peer.Table.add ... we should probably switch to Peer.Table.set, yeah?

frontend/website/src/Links.re should be fine, we only call add if mem is false

The usage for src/app/cli/src/coda_worker_testnet.ml:529 should be fine


change_it

Alluxio Version:
What version of Alluxio are you using?
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior (as minimally and precisely as possible)
Expected behavior
A clear and concise description of what you expected to happen.
Urgency
Describe the impact and urgency of the bug.
Additional context
Add any other context about the problem here.

Do you have any bug to report @andylin23865 ? If yes, feel free to reopen this issue and state your bug explicitly


Accept prefiltered MIDAS species list to midas_run_snps.

Add a command-line option to accept a user-specified species list (one MIDAS species_id per line) that bypasses the coverage filtering apparatus.
This same feature could also be added to midas_run_genes.

Hi Byron, this request totally make sense to me. I will add back the species_id options to midas_run_snps. To keep things consistent, for now, I will leave your PR as it is for reference.


[BUG] autosize does not autosizes graph height to browser window size

When creating a plotly.graph_objects.Figure() object without the resampling, the plot automatically scales when changing the window size of the browser.
With the plotly_resanpler.FigureResampler(plotly.graph_objects.Figure()) object, only the width of the plot automatically scales with the window size and not the height.
import plotly.graph_objects as go
import pandas as pd
import plotly_resampler

df = pd.read_csv(<filename>)

fig = plotly_resampler.FigureResampler(go.Figure().update_layout(autosize=True))
for col in df.columns:
    fig.add_trace(
        go.Scattergl(name=col, text=df[col].values,
                     hovertemplate=hover_template(column=col)),
        hf_x=df.index,
        hf_y=df[col]
    )

fig.update_layout(
    autosize=True
)

fig.show_dash()

Versions
Python 3.10
Plotly 5.11.0
Plotly-resampler 0.8.1

Hi @Olivier0330,
I spend some time to try reproducing your behavior via plain dash and plotly Figure objects and I do not seem to get it working via this way.
Hence, could you provide me with a working example; i.e., where the height autoscales using plain dash and plotly? This way I can better aid you!
import dash
import plotly.graph_objects as go
import pandas as pd; import numpy as np

# create some data
N = 50_000
x = np.arange(N)
noisy_sin = (3 + np.sin(x / 200) + np.random.randn(len(x)) / 10) * x / 1_000
x_time = pd.date_range("2020-01-01", freq="1s", periods=len(x))

# create a plain plotly figure
fig = go.Figure()
fig.add_trace(go.Scattergl(name="noisy_sin", x=x, y=noisy_sin))
# autosize the width height of the figure
fig.update_layout(autosize=True, width=None, height=None)

app = dash.Dash(__name__)
app.layout = dash.dcc.Graph(id="resample-figure", figure=fig)

if __name__ == "__main__":
    app.run_server(debug=True, port=9023)

kind regards,
Jonas

Hi @jonasvdd,
Thanks for your response. I was also playing around a bit and there seems to be a difference when using just plotly or using it in a dash application. I therefore do not think this as a bug from your side.
Here is the example where the autoscale does work without using dash.
import plotly.graph_objects as go
import numpy as np
import pandas as pd

N = 50_000
x = np.arange(N)
noisy_sin = (3 + np.sin(x / 200) + np.random.randn(len(x)) / 10) * x / 1_000
x_time = pd.date_range("2020-01-01", freq="1s", periods=len(x))

# create a plain plotly figure
fig = go.Figure()
fig.add_trace(go.Scattergl(name="noisy_sin", x=x, y=noisy_sin))
# autosize the width height of the figure
fig.update_layout(autosize=True, width=None, height=None)

fig.show()

I however changed something in the figure_resampler.py file to make it work for me. For me it is a useful feature when plots on full screen are required and when using different monitors with different resolutions.

Hi @Olivier0330,
Thank you for making the effort to further investigate this, much appreciated! 💪🏼
I can certainly see the added value of your required feature, and as such, I played around with the configuration and came to the conclusion that we should indeed provide this functionality with show_dash!
I especially envision the use-case of multiple subplots that scales to the canvas height really useful!
I will look into this while finishing up the rangeslider PR (see #254)

Fixed in #273, which is now merged to main, This will be released in plotly-resampler-0.9.2.


Memory leak when using sockets APIs and unrelated threads.

This report describes a situation I encountered when working with my ESP32 project that has taken me nearly 8 working hours to get to this level of documentation.  It was a strange problem and had many potential distractions that could have contributed but I believe I have it stripped down to its smallest description.
This will be wordy report in order to fully describe and provide an understanding of what I am experiencing and have done so far to capture.
At the core, we have a memory leak.  It originally manifested in my primary project when I ran a soak test on the app and it crashed due to being out of memory.  I then instrumented my project with logs of the free heap space over time and, sure enough, the amount of free heap was diminishing.  This then took me down the path of attempting to find where within my code the heap was being lost ... and after hours and hours of examination ... I am at a belief that the heap is being leaked in ESP32 ESP-IDF code.
Let us start at the beginning ...
I have a macro which is called "HEAP_CHANGE_START()".  When called, it obtains and remembers the current heap value.  There is a second macro called "HEAP_CHANGE_END()".  When it is called, it compares the current heap with the last one remembered.  If they are different, there has been a heap leakage and we log the changed value.  If the heap hasn't changed (which is the most common case) then we increment a counter that says how many times we ran the test and the heap didn't change.
I use these in a function that looks as follows:
#include "esp32_memory.h"
#include <esp_log.h>
#include "sdkconfig.h"

static char tag[] = "heap_test";

void heap_test(void *ignore) {
	ESP_LOGD(tag, "Starting heap test");
	while(1) {
		HEAP_CHANGE_START();
		int i;
		int j=0;
		for (i=0; i<10000; i++) {
			j=j+1;
		}
		HEAP_CHANGE_END("end_item");
	}
}

This is a function that loops forever.  In each iteration of the loop, we do 10000 numeric operations, just to burn time.  Surrounding the 10000 operations, we examine the HEAP values to see if there has been a change between the start and the end.
When I run this logic, I get output that looks as follows:
D (760206) memory: end_item: Heap changed by 36, new size: 53616, counter: 811
D (760411) memory: end_item: Heap changed by 36, new size: 53580, counter: 798
D (760616) memory: end_item: Heap changed by 36, new size: 53544, counter: 811
D (760821) memory: end_item: Heap changed by 36, new size: 53508, counter: 812
D (761025) memory: end_item: Heap changed by 36, new size: 53472, counter: 812
D (761230) memory: end_item: Heap changed by 36, new size: 53436, counter: 811
D (761435) memory: end_item: Heap changed by 36, new size: 53400, counter: 811
D (761640) memory: end_item: Heap changed by 36, new size: 53364, counter: 812
D (761845) memory: end_item: Heap changed by 36, new size: 53328, counter: 812
D (762049) memory: end_item: Heap changed by 36, new size: 53292, counter: 812

If we look at each line, we see that in each case, the free heap has shrunk by 36 bytes.  But notice also, that the heap doesn't change for EACH iteration of the loop, rather it changes at variable numbers of iterations through the loop (with the predominant number being ~812).
So what we have here is code which is reporting a heap leakage where there should be no possibility of any being leaked.  I did some further digging.
Since the ESP32 is using FreeRTOS, LWIP and other technologies, a question that would appear to be needing to be asked is "what other tasks are running" ... and what I am about to describe appears to be the recipe needed to manifest the problem:
I have a standard ESP32-Template app that connects to an access point.  When it has connected and we have been allocated an IP address, I then start a socket server.  In the socket server I perform:
socket();
bind();
listen()
accept();
recv() <- until all data received;
close(clientSocket);
close(ServerSocket);
call heap_test(); <---- here is where the heap test loop is performed

If I do NOT perform the sockets APIs prior to calling heap_test, no leakage is found.
I am attaching a tar file (renamed as a ZIP ... rename back to .tar before extraction) containing the project as part of this issue.  The version of ESP-IDF that I am using is the latest as of this date (https://github.com/espressif/esp-idf/commit/f807d16310719b0dcef07de0276934653b6e48ed)
To test, run the app and wait for it to connect and pause ...
Send in some data:
$ nc <ipaddress> 8001
Hello World
^D

And now look at the console of the ESP32.
heap.tar.ZIP

First, you forgot to delete connection_info.h.
I confirm what you are seeing.  I notice if you call esp_wifi_disconnect before running heap_test that there is no memory leak.

Thank you kind sir for replicating.  It is always welcomed when someone other than the issue reporter manages to duplicate ... there is always the potentiality that the issue is local to my environment and hearing that it can be recreated is great news.

Here's what happens when it gets to zero:
E (559173) wifi: error malloc bcn_param

I had assumed that the two cores were partitioned ... one was meant to run networking related housekeeping while the other ran application code.  Is my model wrong?  Can you help me understand what would need to be changed to run in "dual core mode"?  What are the implications of running in dual core mode?

config FREERTOS_UNICORE
bool "Run FreeRTOS only on first core"
default y

Hi,
Sorry, I didn't properly read the comments on this last week before marking as a bug. @negativekelvin's diagnosis is correct, the "heap check" while loop task is starving lower priority tasks and causing data to accumulate in background buffers, hence causing the memory leak in the test program. (The leaks I was able to trigger were on incoming packets, waiting to be processed by the server socket.)
One clue in esp-idf is the "task watchdog", which is enabled by default,  picks up that the heap_task task is not yielding within the timeout period and prints watchdog timeout warnings.
This kind of bug is easy to write in RTOS environments due to real-time scheduler effects, but some good design habits will prevent it in most cases.
The best way is as suggested by @negativekelvin , add a vTaskDelay(1) or similar inside any tight while() loop that polls rather than blocking. This isn't necessarey if the system is blocking waiting on data via RTOS primitive (ie reading from a queue, or blocking on a socket as the sockets use RTOS primitives behind the scenes.)
Another way is to lower the priority of the heap checker task to run at tskIdlePriority or tskIdlePriority+1, so other system tasks will always preempt it and run. Even if doing this it is best to also add a delay, to help the low priority task coexist with other low priority tasks.
The "idle hook" functionality is another way to have something run on the CPU only when no other task is waiting to run.

Hello projectgus,
I was having the exact same issue, with a HTTP server listener in a tight while loop. I kept seeing decreasing heap but I could not figure why.
After adding a vTaskDelay(1) to that loop I no longer have a memory leak.
So I would like to thank you very much for this answer that has tremendously helped me understand the inner and finer workings of freeRTOS.
Cheers!


Improve error reporting

Example error:
Execute failed: java.net.SocketTimeoutException: timeout

Or
Execute failed: Not Found

Include which identifier gave the error.

Timeout and not found exception have been catched and rethrown with nicer message


Depth of conv layers compared to DCGAN paper

According to the paper, the generator reshape the noise into 441024, but in the code
self.h0 = tf.reshape(self.z_, [-1, s_h16, s_w16, self.gf_dim * 8])
// here gf_dim is 64
And the shape should be 44512
Is this intentional?

Good catch! A note in the README about this difference could be helpful.

Yes that's a difference but I followed the code of Soumith who is one of the author of DCGAN. I thought if depth of layer is not that important, I preferred shorter one for a fast training.

A note in the README would be super helpful, just like the note about training the generator twice. Also, the image in the README is a lie.  That would be helpful to have noted as well...


⚠ ClamAV has degraded performance

In 48115d9, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 439 ms

Resolved: ClamAV performance has improved in 3d51b31.


DTSPO-16830-remove utiac

Jira link (if applicable)
DTSPO-16830
Change description
remove utiac to fix pipeline
Checklist

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)
[ ] Does this PR introduce a breaking change

Why commenting and not removing?

Plan Result (nonprod)
:warning: Resource Deletion will happen :warning:
This plan contains resource delete operation. Please check the plan result very carefully!
Plan: 4 to add, 0 to change, 4 to destroy.

Replace

module.pcol.sendgrid_domain_authentication.domain-authenticate["hmcts.net"]
module.pcol-dns.azurerm_dns_cname_record.record1["hmcts.net"]
module.pcol-dns.azurerm_dns_cname_record.record2["hmcts.net"]
module.pcol-dns.azurerm_dns_cname_record.record3["hmcts.net"]

Change Result (Click me)

  # module.pcol.sendgrid_domain_authentication.domain-authenticate["hmcts.net"] must be replaced
-/+ resource "sendgrid_domain_authentication" "domain-authenticate" {
      + custom_dkim_selector = "pnl" # forces replacement
      - custom_spf           = false -> null
      ~ dns                  = [
          - {
              - data  = "pnl.domainkey.u33702686.wl187.sendgrid.net"
              - host  = "pnl._domainkey.hmcts.net"
              - type  = "cname"
              - valid = false
            },
          - {
              - data  = "pnl2.domainkey.u33702686.wl187.sendgrid.net"
              - host  = "pnl2._domainkey.hmcts.net"
              - type  = "cname"
              - valid = false
            },
          - {
              - data  = "u33702686.wl187.sendgrid.net"
              - host  = "em2865.hmcts.net"
              - type  = "cname"
              - valid = false
            },
        ] -> (known after apply)
      ~ id                   = "20540841" -> (known after apply)
      ~ ips                  = [] -> (known after apply)
      ~ subdomain            = "em2865" -> (known after apply)
      ~ username             = "hmcts-pcol-nonprod" -> (known after apply)
      ~ valid                = false -> (known after apply)
        # (3 unchanged attributes hidden)
    }

  # module.pcol-dns.azurerm_dns_cname_record.record1["hmcts.net"] must be replaced
-/+ resource "azurerm_dns_cname_record" "record1" {
      ~ fqdn                = "pnl._domainkey.hmcts.net." -> (known after apply)
      ~ id                  = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformmgmtrg/providers/Microsoft.Network/dnsZones/hmcts.net/CNAME/pnl._domainkey" -> (known after apply)
      ~ name                = "pnl._domainkey" # forces replacement -> (known after apply) # forces replacement
      ~ record              = "pnl.domainkey.u33702686.wl187.sendgrid.net" -> (known after apply)
      - tags                = {} -> null
        # (3 unchanged attributes hidden)
    }

  # module.pcol-dns.azurerm_dns_cname_record.record2["hmcts.net"] must be replaced
-/+ resource "azurerm_dns_cname_record" "record2" {
      ~ fqdn                = "pnl2._domainkey.hmcts.net." -> (known after apply)
      ~ id                  = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformmgmtrg/providers/Microsoft.Network/dnsZones/hmcts.net/CNAME/pnl2._domainkey" -> (known after apply)
      ~ name                = "pnl2._domainkey" # forces replacement -> (known after apply) # forces replacement
      ~ record              = "pnl2.domainkey.u33702686.wl187.sendgrid.net" -> (known after apply)
      - tags                = {} -> null
        # (3 unchanged attributes hidden)
    }

  # module.pcol-dns.azurerm_dns_cname_record.record3["hmcts.net"] must be replaced
-/+ resource "azurerm_dns_cname_record" "record3" {
      ~ fqdn                = "em2865.hmcts.net." -> (known after apply)
      ~ id                  = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformmgmtrg/providers/Microsoft.Network/dnsZones/hmcts.net/CNAME/em2865" -> (known after apply)
      ~ name                = "em2865" # forces replacement -> (known after apply) # forces replacement
      ~ record              = "u33702686.wl187.sendgrid.net" -> (known after apply)
      - tags                = {} -> null
        # (3 unchanged attributes hidden)
    }

Plan: 4 to add, 0 to change, 4 to destroy.


Missing contributing guidelines in the Readme.md

There is no description of how to set up the env file in the Readme.md . The contributors will not be able to work with the website on their local computers.

hey @prernadabi23  I have noted this issue I will fix this issue soon. Please hold on for a moment.


added plotColGraph and plotRowGraph function

@FelixErnst the plots look cool and function works well. I assume that the process of creating the graph table will be shown in MiaBook?
One more point, in plotRowGraph
plotRowGraph(row_graph,
             genus,
             colour_by="Kingdom",
             edge_colour_by="weight",
             edge_width_by="weight",
             show_label=TRUE*)

*this is tricky because too many points to label. Would it be possible to have a user defined cut-off for labels? For.eg.
if a node has more than three or four edges with weights more than a give value, that node is labelled? Something similar to the prevalence option, i.e. detection atleast 0.001 in 50% samples.

@FelixErnst the plots look cool and function works well. I assume that the process of creating the graph table will be shown in MiaBook?
One more point, in plotRowGraph
plotRowGraph(row_graph,
             genus,
             colour_by="Kingdom",
             edge_colour_by="weight",
             edge_width_by="weight",
             show_label=TRUE*)

*this is tricky because too many points to label. Would it be possible to have a user defined cut-off for labels? For.eg.
if a node has more than three or four edges with weights more than a give value, that node is labelled? Something similar to the prevalence option, i.e. detection atleast 0.001 in 50% samples.

I get this warning when show_label=TRUE
##Warning message:
Ignoring unknown parameters: max.overlaps

I get this warning when show_label=TRUE
##Warning message:
Ignoring unknown parameters: max.overlaps

I get this warning when show_label=TRUE
##Warning message:
Ignoring unknown parameters: max.overlaps

I'll have a look at it.

I get this warning when show_label=TRUE
##Warning message:
Ignoring unknown parameters: max.overlaps

I'll have a look at it.

*this is tricky because too many points to label. Would it be possible to have a user defined cut-off for labels? For.eg.
if a node has more than three or four edges with weights more than a give value, that node is labelled? Something similar to the prevalence option, i.e. detection atleast 0.001 in 50% samples.

Instead of having a specific argument, you can use logical, integer and character values to subset to specific labels. I adjusted the man page regarding this behavior and included other examples.

##Warning message:
Ignoring unknown parameters: max.overlaps

I couldn't reproduce this. Which version of ggraph do you have installed?

These are the versions of key packages
R version 4.0.3 (2020-10-10)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 18363)

Matrix products: default

locale:
[1] LC_COLLATE=English_Netherlands.1252  LC_CTYPE=English_Netherlands.1252
[3] LC_MONETARY=English_Netherlands.1252 LC_NUMERIC=C
[5] LC_TIME=English_Netherlands.1252

attached base packages:
[1] parallel  stats4    stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
 [1] miaViz_0.98.8                   ggraph_2.0.3
 [3] ggplot2_3.3.2                   mia_0.98.31
 [5] TreeSummarizedExperiment_1.99.9 Biostrings_2.58.0
 [7] XVector_0.30.0                  SingleCellExperiment_1.12.0
 [9] SummarizedExperiment_1.20.0     Biobase_2.50.0
[11] GenomicRanges_1.42.0            GenomeInfoDb_1.26.0
[13] IRanges_2.24.0                  S4Vectors_0.28.0
[15] BiocGenerics_0.36.0             MatrixGenerics_1.2.0
[17] matrixStats_0.57.0

Let me know, whether it works for you now or not. The argument in question is used in geom_node_label and hasn't changed since 2.0.3 so I have no idea, what could be wrong.

The warning message persisted. I think the max.overlaps  is passed on to the ggrepel::geom_text_repel(). I had ggrepel v0.8.2. Therefore, I updated ggrepl to v0.9.1 and the error is now gone. The rest is all okay including the new addition of edge_type.


Stripe API keys are hard-coded

https://github.com/jamstack-cms/jamstack-ecommerce/blob/88a2d489af4204d11d8612b4fb3c24a14321c030/src/pages/checkout.js#L20
Expected:
Keys to be loaded from a secure place.

Agreed! You can create a .env file, add it to gitignore & import all important keys securely from there  🙂


gdal 2.* build failed

OS: Windows 10
Platform : VS 2017
triplet : x64-windows
With error code:
nmake-build-x64-windows-release-err.log
NMAKE : fatal error U1077: “"C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.11.25503\bin\HostX64\x64\cl.EXE"”: 返回代码“0xc0000005”
Stop.
NMAKE : fatal error U1077: “"C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.11.25503\bin\HostX64\x64\nmake.EXE"”: 返回代码“0x2”
Stop.

nmake-build-x64-windows-release-out.log
***
***
cpl_hash_set.cpp
cl: 命令行 error D8000 :cl: 命令行 error D8000 :cl: 命令行 error D8000 :cl: 命令行 error D8000 :cl: 命令行 error D8000 :cl: 命令行 error D8000 :cl: 命令行 error D8000

Sorry for the Chinese character, I think this is a internal compiler error, I have experienced this once using  nmake myself. And a solution is to use x64_86 instead of native x64 nmake to build gdal.
My question is, is it possible to select x86-64 pipeline instead of native x64 for x64-windows pipeline?

fix by set(VCPKG_PLATFORM_TOOLSET "v140"). It seems that this is only exist for vs 2017

i have the same problem, are you resolve it?


Website currently stuck at the hour glass

Dear community,
the beloved ABAP repos list is currently stuck on page load. Would be great if you could give it a look. Seems like a data source is not supplying anticpated values.

KR
Martin

merged https://github.com/dotabap/dotabap-validator/pull/303 earlier today, probably somewhere around that

@MartinPankraz try again
fixed with https://github.com/dotabap/dotabap-generated/commit/29800e561b7964ffaf375520af64c94b56911da8

it is alive 🧟♂again. Thanks for the prompt fix @larshp!


create a countdown clock

I’d like to have it always counting down a “count down clock”
Ideally it’d go like this:
I could issue a PR to a config file with something like:
Days of life: 100
End Date: 1/1/2019
and then it would calculate & show the days, hours, minutes & seconds
and always be counting down like  2 years, 10 months, 5 days, 3 days, 12 hours, 34 minutes, 5 secs
and it would just tick down all the time
then, people could submit their image to override that as a default
maybe their image stays up for some amount of time, like for 1 minute
and then it reverts back to the default

done!


documentation: clarify/correct the usage of routes in the ipam host-local plugin

networking.md suggests the following to configure routes within the ipam section:

"List of IP routes in CIDR notation. The routes get added to pod namespace with next-hop set to the gateway of the network."

Doing so by using the following example
{
    "name": "containers_ipv4",
    "type": "ipvlan",
    "master": "enp0s20u1u1",
    "ipam": {
            "type": "host-local",
            "subnet": "<IP_ADDRESS>/24",
            "gateway": "<IP_ADDRESS>",
            "routes": [ "<IP_ADDRESS>/24" ]
    }
}

leads to a failure when running rkt:
2015/05/03 23:04:16 ADD: json: cannot unmarshal string into Go value of type plugin.route
2015/05/03 23:04:16 ADD: exit status 1
Failed to setup network: error adding network "containers_ipv4": exit status 1

Digging through the code at https://github.com/appc/cni/blob/master/pkg/plugin/types.go#L61 you can see that the expected element is a dictionary with the keys dst and optionally gw.
The following is a tested working example:
{
    "name": "containers_ipv4",
    "type": "ipvlan",
    "master": "enp0s20u1u1",
    "ipam": {
            "type": "host-local",
            "subnet": "<IP_ADDRESS>/24",
            "gateway": "<IP_ADDRESS>",
            "routes": [
                { "dst": "<IP_ADDRESS>/24" }
            ]
    }
}

What's bugging me is that the cni host-local README.md doesn't agree with the cni repo README.md.
I'm sure @eyakubovich or someone else knows what the plan is.

This is fixed in the cni and rkt docs now!


Update to webpack 5 and elm-webpack-loader 8

Fixes #21

Any update on this?

Bump... I'm willing to help if there are still items remaining to be done.

Also curious if this will get merged

This is stalled now for such a long time that I think it is worth considering forking, and asking @klazuka to deprecate this repo?

Yeah lets get this sorted. I've been doing --force installs for like a year.

I'm gonna publish a fork unless someone else really wants to?

I'm gonna publish a fork unless someone else really wants to?

Go for it!

Yeah I'll get round to it at some point. I have backed up this fork.

Perhaps we should re-open this issue.
More importantly, which repo will own this code in the future. It ought to be something with multiple owners - elm-community comes to mind


Ignore IDEA files

Coverage remained the same at 93.585% when pulling 02b86353df3927fdc51b4baf90bd9d5aa17cc8c7 on xalvarez:ignore-idea-files into be168327b01e977c15990b4cc068d7a026ba3f34 on ePages-de:master.


Web - Split Bill - Money request confirmation list stays highlighted after press

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open a group chat
Start a Split Bill and proceed until the confirmation page
Unchecks the items in the list

Expected Result:
The item is not highlighted if we don't hover it or is not focused
Actual Result:
The item stays highlighted after press and also the first item that is not clickable is highlighted if we click it
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/062ce13b-eda9-41a0-8725-6b645a56e9a4
https://github.com/Expensify/App/assets/93399543/22f1a4f8-18f9-4d6c-8e60-14d1cf20ef55
Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686202285251059
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0110ed1d7d5b0b56cb
Upwork Job ID:<PHONE_NUMBER>418042880
Last Price Increase: 2023-06-17

I can reproduce but I don't see why this is a bug - asking for more information https://expensify.slack.com/archives/C049HHMV9SM/p1686604097827569?thread_ts=1686202285.251059&cid=C049HHMV9SM

Reached out here for some help - https://github.com/Expensify/App/pull/19612#issuecomment-1589882706

@bernhardoj @Christinadobrzyn I reverted my changes for testing and still, I got the same bug (even in PRs merged before #19612). However, I think I know where is the problem. It is caused because of not disabling focusing in this list. I will write the proposal

Hmm, that's strange. I removed focusStyle and the issue is gone. To have us in the same page, the first row should not be highlighted (ss taken from video above).

Proposal
Please re-state the problem that we are trying to solve in this issue.
The money request confirmation list stays highlighted after press
What is the root cause of that problem?
There are two root causes of this problem. The first one is that we don't disable focusing on this list. The second one is that we have two places that specify focus styles for PressableWithFeedback
What changes do you think we should make in order to solve the problem?

We should pass the disableFocusOptions prop to the <OptionsList> component. This is the parent component of the user list where the bug exists. By passing this option the optionIsFocused  prop in OptionRow will be always false.
After we change this, we should remove focus styles from the style prop in PressableWithFeedback because we can just use focusStyle prop.
Next, we should make focusStyle disabled when optionIsFocused is false, so we can change it to this.props.optionIsFocused ? styles.sidebarLinkActive : null}.
After we do these changes, the issue should be fixed, however we will have to fix again this issue. To do this we should change a little bit PressableWithFeedback structure and move the styles from OpacityView to the parent component GenericPressable. These changes will resolve both issues
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Hmm, that's strange. I removed focusStyle and the issue is gone. To have us in the same page, the first row should not be highlighted (ss taken from video above).

Hmm maybe I misunderstand something, I thought that after we select/unselect something nothing should be highlighted. So last clicked element should be on focus?

Oh okay, now I think I understand, we want to focus last unselected element to enable the user to select it by clicking enter but the other highlight is wrong. Hmm, I tested it and its really buggy so I thought that we don't want this 😅
https://github.com/Expensify/App/assets/39538890/c14e6071-bd07-4c3a-a117-0ff4181f712c

I guess that's another bug to be solved haha. I think we should focus on the wrong highlight here.

Okay, so to fix this issue we have to move styles in PressableWithFeedback to the parent component, to not break this fix. Also, we need to remove focusStyles prop in OptionRow because focused element is different then highlighted element (the last unselected item)

The bug with switching between items using arrows and enter button occurs after you change the focused item using the tab button. The focusedIndex from ArrowKeyFocusManager is not changing so we have two different items "focused"

Holding this one based on this comment: https://github.com/Expensify/App/issues/19766#issuecomment-1595163834

Nope, placed Hold on the wrong issue title. my bad

Thanks @Skalakid! I'm going to add an engineer to this just to make sure I'm getting everything. Sounds like we'll fix this with https://github.com/Expensify/App/pull/20838
I added @bernhardoj as the C+ since you've already been discussed in this issue and an engineer for tracking. Let me know if there's anything else I need to do at this time!

Looks like @Skalakid is working on this issue. The assigned engineer on the PR is @Julesssss, and the assigned C+ is @s77rt, so I will fix the assignments here to keep everything in sync.

The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/19612
The offending PR has been commented on: https://github.com/Expensify/App/pull/19612#discussion_r1239679476
A discussion in #expensify-bugs has been started: I doubt we have much to discuss, this could have been caught during testing
Determine if we should create a regression test for this bug: No

Looks like no regressions - paying this out -
I think this is a regression of another bug, right so I would only pay the reporter? If that's not the case, will you please let me know if there's a speed bonus for this?
@Julesssss @s77rt

This is a regression, right so I would only pay the reporter? If that's not the case, will you please let me know if there's a speed bonus for this?

Not a regression that was caught during regression period (i.e. not a regression from something that we worked on recently) so I think we should pay everyone here. No bonus though.

Thanks @s77rt!
Here's the Upwork job posting:
Internal: https://www.upwork.com/ab/applicants/1670152822418042880/job-details
External: https://www.upwork.com/jobs/~0110ed1d7d5b0b56cb
@s77rt as C+
@bernhardoj as reporter

Paid out based on https://github.com/Expensify/App/issues/20585#issuecomment-1615219217
Closing


fixes for linter run by github-actions in tap repos

Thanks for providing this super useful GitHub Action!
I saw a couple of minor errors when running it. The first is in my project repo where the action runs:
Configuration file not found: /github/workspace/Homebrew/Library/.rubocop.yml

I think coming from:
logger.debug `rubocop -c Homebrew/Library/.rubocop.yml -x #{tempfile.path}`

which is think is due to:
COPY Homebrew /

(contents of Homebrew copied to / so there is no Homebrew top level dir)
The second is after it pushes the changes back to my tap repo I get some errors in the tap repo from the brew test-bot --only-tap-syntax GitHub Action that was installed automatically when I did brew tap-new to create it.
Error: Inconsistent indentation detected.
Error: Use 2 (not 0) spaces for indentation.
Error: Trailing whitespace detected.
Error: `end` at 12, 2 is not aligned with `bottle do` at 8, 0.
Error: Extra blank line detected.
Error: Trailing whitespace detected.

coming from:
    bottle_expression = <<~RUBY
      bottle do
          root_url "#{root_url}"
          #{"rebuild #{rebuild}\n" if rebuild}
          #{bottles.join("\n    ")}
        end
    RUBY

e.g. https://github.com/anentropic/homebrew-tap/runs/2487670091

Still testing, I'll re-open once it's all working 🤦♂


Update url for repository rename in setup.py

What do these changes do?
Fix url because the repository name changed.
Are there changes in behavior for the user?
No.
Related issue number
N/A.
Checklist

[ ] I think the code is well written
[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes
[ ] If you provide code modification, please add yourself to CONTRIBUTORS.txt

The format is <Name> <Surname>.
Please keep alphabetical order, the file is sorted by names.

[ ] Add a new news fragment into the CHANGES/ folder

name it <issue_id>.<type> (e.g. 588.bugfix)
if you don't have an issue_id change it to the pr id after creating the PR
ensure type is one of the following:

.feature: Signifying a new feature.
.bugfix: Signifying a bug fix.
.doc: Signifying a documentation improvement.
.removal: Signifying a deprecation or removal of public API.
.misc: A ticket has been closed, but it is not of interest to users.

Make sure to use full sentences with correct case and punctuation, for example:
Fix issue with non-ascii contents in doctest text files.

Thanks!


email,api: simplest invitation link that could possibly work

Generate a really big url that wraps a password change link as the redirect URL inside of an email validation link (with yet another url wrapped inside of the password change link).

This method generates a 2190-character URL in my test environment, which is asking a lot of browsers, load-balancers, and servers. There are a number of other possible approaches to this, but none I could think of with such a small diff.

Withdrawing this approach for now in favor of something a bit more deliberate.


update module path

Hello, I am trying to scraping soundtrack information with your package. But I am unable to go get github.com/stavia/imdbsoundtracks/pkg/scraping in a project outside $GOPATH.
The error message is
go: github.com/stavia/imdbsoundtracks/pkg/scraping upgrade => v0.0.0-20200524101155-859145181224
go get<EMAIL_ADDRESS>parsing go.mod:
        module declares its path as: scraping
                but was required as: github.com/stavia/imdbsoundtracks/pkg/scraping

I think we need to declare the module path as github.com/stavia/imdbsoundtracks/pkg/scraping.

Hi, you're right! Thanks!