CLI predictions are very slow

Hi,
I have a dataset with 800M instances for training and 100M for validation.
The dataset is in LibSVM format. I use the command line interface with Ubuntu.
The training time was very reasonable compare to the size of the dataset ~ 6-7 hours.
After the training finished, I overridden the gbdt_prediction.cpp with the hard coded model dumped from the convert_model, convert_model_language option.
Even with all this, the prediction are really slow. After 3 hours, I have only a few hundred thousand instances predicted dumped in the prediction file.
How can I speed up the prediction drastically ?
Thank you,

@araujoalexandre
can you provide the number of your feature ?
and the parameters used in training ?
Did you try the prediction without if-else conversion ? Is that even slower ?

I have 134 features
Yes I tried without If-else conversion. I think it's a bot slower.

@araujoalexandre Did you use the code of master branch?
I think it should be very fast.

Yes, I used the master branch.
In the LibSVM, indexes are in a 2**25 dimension space.
Would that be the problem ?

@araujoalexandre
134 feature with  2**25 dimension ?
Yeah, it will be a big problem.
A possible solution: set num_thread to 1 or 2, to reduce the memory cost.

I used the hashing trick to create the dataset.
So the number of feature is not very high but the dimension is very large to avoid collision.
I'll try with 1 or 2 treads.
Otherwise I guess I need to re map the index in a smaller dimension space.
Would that resolve the problem ?

@araujoalexandre
yeah, it will be much faster if feature dimension is small. But you need to retrain the model as well.

@guolinke
I tried with 1 thread, it is still very slow.
I tried to do a re map of the index into a much smaller dimension space.
The thing I don't understand is why the training is fast with the same dimension space but the prediction is slow.

@araujoalexandre
We have many optimizations for the training with high dimension data.
However, for the prediction, it needs many random access on feature space. And we didn't optimize for it yet.

@guolinke
It worked, after a re map of the index into a decent dimension space, the predictions took only a few minutes on 100M rows  !
Thanks a lot !


update help link and UG

replace help link to team's UG page
add more explanation on the dateTime format and how leap days are handled
update constraints for year field
fix add resume formatting on UG
closes #143
closes #136
closes #110
closes #138
closes #107

LGTM


Replace references to serializer with values() and later create JSON …

…for all SyncOutView APIs

Changed SyncOutView APIs from class-based view to function based view
use of values() to create JSON instead of serialize
commented out export SyncOutView function from app url file
Updated apis_v1 url file with function based view
removed format JSON from API documentation for SyncOut APIs

Thank you @mnneelam! 👍


Whenever API bindings are used, 'null' shows up while waiting for API responses

This is a very serious problem. See attached video as an example. It happens everywhere and is very noticeable when API responses are slow.
I don't think anyone can ship any app with this issue and it is prevalent everywhere including our kitchen sink.  Unfortunately this is one of those case where we just don't know the exact dimension before the image loads, hence the jerkiness. Our intelli-sense has a warning on this.

If you try to add the missing width or height, the image will nicely fade in from a random beautiful color. We should publicize the need for width/height (or stretch parent via expanded).

For non-Image items, we might have to review them case by case (please list them out if you have). Perhaps the concept of initialValue for the binding will help.

@vusters you may be confusing this with a different issue. This has to do with the "null" showing up for a few seconds while the API is being processed. It is caused by the platform executing the bindings without data and affects many apps.

dude it affects so many apps that I stopped keeping a count. We can't have a case by case and need a proper general solution. - Auto navigator, Kitchen Sink, Doctor appt app and in fact all customer apps I know have this issue today

I got you. I was referring to the UI collapsed then expanded when API returns.

added example in the title for the auto navigator app, shows up as null for a while while waiting for API response


gefyra list --containers doesn't list container from gefyra run

I executed gefyra run and expected to see that container listed with gefyra list --containers. However that list remains empty.

duplicates #59


Fuelchain type generation wrong for Vec inputs

After generating types from a contract that uses Vec<b256>, the code generated creates a Vec Structure instead of the correct type like in the case of Vec<b256> as input of type Array<string>.
Examples:
fn echo_b256_vector(vector_1: Vec<b256>, index: u32) -> b256;

Types generated
  encodeFunctionData(
    functionFragment: "echo_b256_vector",
    values: [VecInput, BigNumberish]
  ): Uint8Array;

Expected Types generated
  encodeFunctionData(
    functionFragment: "echo_b256_vector",
    values: [Array<string>, BigNumberish]
  ): Uint8Array;

I want to confirm some things about the code/types generation.
This  sway contract

code
contract;

struct Geo {
    x: u8,
    y: u8
}

abi MyContract {
    fn example_a(vec_str: Vec<str[3]>, param_a: u8) -> u8;
    fn example_b(vec_u8: Vec<u8>, param_b: [u8; 2]) -> [bool; 2];
    fn example_c(vec_bool: Vec<bool>) -> bool;
    fn example_d(vec_geo: Vec<Geo>) -> [u8; 2];
    fn example_e(struct_geo: Geo) -> [u8; 2];
    fn example_f(array_geo: [Geo; 2]) -> [u8; 2];
}

impl MyContract for Contract {

    fn example_a(vec_str: Vec<str[3]>, param_a: u8) -> u8 {
        10
    }

    fn example_b(vec_u8: Vec<u8>, param_b: [u8; 2]) -> [bool; 2] {
        [true, false]
    }

    fn example_c(vec_bool: Vec<bool>) -> bool {
        vec_bool.get(0).unwrap()
    }

    fn example_d(vec_geo: Vec<Geo>) -> [u8; 2] {
        let vg = vec_geo.get(0).unwrap();
        [vg.x, vg.y]
    }

    fn example_e(struct_geo: Geo) -> [u8; 2] {
        [struct_geo.x, struct_geo.y]
    }

    fn example_f(array_geo: [Geo; 2]) -> [u8; 2] {
        [array_geo[0].x, array_geo[0].y]
    }
}

Generates this typescript

code
import type {
  Interface,
  FunctionFragment,
  DecodedValue,
  Contract,
  BytesLike,
  BigNumberish,
  InvokeFunction,
  BN,
} from "fuels";

export type RawVecInput = { ptr: BigNumberish; cap: BigNumberish };
export type RawVecOutput = { ptr: BN; cap: BN };
export type VecInput = { buf: RawVecInput; len: BigNumberish };
export type VecOutput = { buf: RawVecOutput; len: BN };
export type GeoInput = { x: BigNumberish; y: BigNumberish };
export type GeoOutput = { x: number; y: number };

interface MyContractAbiInterface extends Interface {
  functions: {
    example_a: FunctionFragment;
    example_b: FunctionFragment;
    example_c: FunctionFragment;
    example_d: FunctionFragment;
    example_e: FunctionFragment;
    example_f: FunctionFragment;
  };

  encodeFunctionData(functionFragment: "example_a", values: [VecInput, BigNumberish]): Uint8Array;
  encodeFunctionData(functionFragment: "example_b", values: [VecInput, [any, any]]): Uint8Array;
  encodeFunctionData(functionFragment: "example_c", values: [VecInput]): Uint8Array;
  encodeFunctionData(functionFragment: "example_d", values: [VecInput]): Uint8Array;
  encodeFunctionData(functionFragment: "example_e", values: [GeoInput]): Uint8Array;
  encodeFunctionData(functionFragment: "example_f", values: [[any, any]]): Uint8Array;

  decodeFunctionData(functionFragment: "example_a", data: BytesLike): DecodedValue;
  decodeFunctionData(functionFragment: "example_b", data: BytesLike): DecodedValue;
  decodeFunctionData(functionFragment: "example_c", data: BytesLike): DecodedValue;
  decodeFunctionData(functionFragment: "example_d", data: BytesLike): DecodedValue;
  decodeFunctionData(functionFragment: "example_e", data: BytesLike): DecodedValue;
  decodeFunctionData(functionFragment: "example_f", data: BytesLike): DecodedValue;
}

export class MyContractAbi extends Contract {
  interface: MyContractAbiInterface;
  functions: {
    example_a: InvokeFunction<[vec_str: VecInput, param_a: BigNumberish], number>;
    example_b: InvokeFunction<[vec_u8: VecInput, param_b: [any, any]], [any, any]>;
    example_c: InvokeFunction<[vec_bool: VecInput], boolean>;
    example_d: InvokeFunction<[vec_geo: VecInput], [any, any]>;
    example_e: InvokeFunction<[struct_geo: GeoInput], [any, any]>;
    example_f: InvokeFunction<[array_geo: [any, any]], [any, any]>;
  };
}

Observations

The u8 type is converted into different types depending on the purpose:

BigNumberish — when used as a parameter type
number — when used as a return type

Everything inside arrays is converted to any types (why?):

[u8; 2] becomes [any, any]
[bool; 3] becomes [any, any, any]

Are these expected and/or documented somewhere?

cc @luizstacio @QuinnLee

Are these expected and/or documented somewhere?

I don't think these are expected - IMHO they are bugs.

The u8 type is converted into different types depending on the purpose

This should be consistent - BigNumberish in both is correct

Everything inside arrays is converted to any types (why?)

I think this is techdebt rolled over when the ABI for array types was updated https://github.com/FuelLabs/fuels-ts/issues/138. we should update it to not have any

| Are these expected and/or documented somewhere?
It's expected this enables the user to input a number, BN, or HEX into the field, when is u8, u16, or u32, they are returned as a normal number as they are below the SAFE_MAX from javascript. When the number is u64, it will accept all the same possibilities but will return a BN object.
cc: @arboleya @QuinnLee

Ok, so type variations are working as expected.
Arrays with only any inside are not — it's a bug.
Thanks!


Fix offense message from Rails/TimeZone.

Now, Rubocop generate "Use #Time.zone.[:new] instead." for following code.
Time.new(2014, 1, 1)

But Time.zone.new does not exist. We should use Time.zone.local.
As requested in the contributing guidelines:
$bundle exec rubocop -V
0.30.0 (using Parser <IP_ADDRESS>, running on ruby 2.2.0 x86_64-linux)

Please, remove the . from the commit message's title and add an entry to the changelog regarding this bugfix.

I fix it and rebase on master.

Btw, Time.zone.local would be the equivalent only in case there are any arguments. Otherwise the equivalent would be Time.zone.now or Time.current.

Oh, I miss it. I add a commit to suggest Time.zone.now when {DateTime, Time}.new is called without any arguments.
$ bundle exec rubocop -R ~/tmp/bar.rb
Inspecting 1 file
C

Offenses:

/home/mzp/tmp/bar.rb:1:6: C: Do not use Time.new without zone. Use #Time.zone.now instead.
Time.new
     ^^^
/home/mzp/tmp/bar.rb:3:6: C: Do not use Time.new without zone. Use #Time.zone.local instead.
Time.new(2014, 1, 1)
     ^^^

:+1: Thanks!

Thanks!


Support for clusters with AMD gpus?

Hello,
I would like to run Habitat on a cluster with AMD Instinct MI250x GPU's. However, at least the version installed with conda (habitat-sim=0.3.0 [withbullet headless]) fails to run with the error
Platform::WindowlessEglApplication::tryCreateContext(): unable to find CUDA device 0 among 9 EGL devices in total

From the docs it is not completely clear if the conda packages are built with cuda support, so I'm wondering if building Habitat from source without cuda would work with the AMD gpu's.
Now, reading through https://github.com/facebookresearch/habitat-sim/issues/1511 I get the impression that Habitat actually depends on the Nvidia OpenGL driver. Is this so, or is there a way to run Habitat without Nvidia gpu's?

I'm answering myself after a bit of digging. Seems like AMD GPU's / ROCm do not provide functionality to align the GPU 'CUDA device index' with the GPU 'EGL device index'.
See:
https://doc.magnum.graphics/magnum/classMagnum_1_1Platform_1_1WindowlessEglApplication.html#Platform-WindowlessEglApplication-device-selection
This is required in the Magnum library to place the simulator instance on the same GPU as PyTorch. So, enabling AMD support seems unlikely.
Could @erikwijmans comment, since I see you wrote the Magnum code for Nvidia GPU device selection? Would similar functionality be possible with the mesa driver?
Br,
Lauri

Hey @lasuomela
@erikwijmans is not actively working on the project at this time.
I also don't see much motivation for our team to support AMD GPUs in the foreseeable future.
However, thanks for pointing out the primary issue! I would love to see you or someone else solve this problem and unblock the feature, but for now I don't think we'll have the bandwidth to do so.

All right, I see. I also don't have the time to pursue this, but at least this issue makes this concern visible.
Thanks!
-Lauri


v1.14 Backports 2023-07-25

[x] #27005 (@ldelossa)
[x] #26950 (@julianwiedmann)
[x] #26967 (@danehans)
[ ] #27039 (@dylandreimerink)

Once this PR is merged, you can update the PR labels via:
for pr in 27005 26950 26967 27039; do contrib/backporting/set-labels.py $pr done 1.14; done

or with
make add-labels BRANCH=v1.14 ISSUES=27005,26950,26967,27039

This quick backport round was fast-tracked in preparation for the 1.14 release, it only makes changes to the documentation and helper strings, so we do not need to run any CI for this one.


Added Omnia school located in Finland, Espoo

@mruokojo Pull request merged. Thank you for your contribution!


Live Preview: Failed to execute 'postMessage' on 'DOMWindow'

Link to reproduction
No response
Payload Version
3.0.0-canary.6de2b29
Node Version
20.15.1
Next.js Version
15.0.0-rc.0
Describe the Bug
Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('http://localhost:3000') does not match the recipient window's origin ('http://localhost:3030').

[Error] Unable to post message to http://localhost:3000. Recipient has origin http://localhost:3030.

Getting this warning (in Chrome) or this error (in Safari). The payload.config.ts has a cors value set:
export default buildConfig({
  serverURL: process.env.PAYLOAD_SERVER_URL || 'http://localhost:3030',
  cors: [process.env.PAYLOAD_LIVE_PREVIEW_URL || 'http://localhost:3000'],
  …

The live preview loads the iFrame correctly, but does not update at all.
Reproduction Steps
If necessary we can invite you to our monorepo!
Adapters and Plugins
No response

It is worth noting, that we are using a custom endpoint to fetch data in our frontend, but it seems that the error/warning is unrelated.

@robinscholz it sounds to me like this is an issue related to your front-end implementation. In order to achieve cross-domain communication, the child window must open first and "call" back to the parent window before it begins sending its messages down. Otherwise, this error is thrown. This is a security feature built directly into the postMessage API. I can add some troubleshooting docs based this discussion, once we can confirm this is the issue.

Closing for now, since this is likely an improper configuration and not an issue with core functionality. @robinscholz If you can show me what your front-end implementation looks like, I can try and help further. Feel free to keep the conversation in this issue going.


Support for non-standard HTTP versions (Shoutcast)

I noticed an odd bug in mitmproxy: if I try to connect to a shoutcast stream, the client receives a 502 error, and the mitmproxy curses UI prints HttpError("Invalid HTTP version in line: 'ICY'",) in red with no HTTP code. However, if I look at my network connections, mitmproxy has connected to the shoutcast stream and is downloading it.
It also doesn't write any of the data that it's streaming to the flows file when I use the -w option.
It's like there's zombie connection that mitmproxy has forgotten about.
Example:
$ http_proxy=localhost:8080 curl http://xstream1.somafm.com:8002
            <html>
                <head>
                    <title>502 Bad Gateway</title>
                </head>
                <body>HttpError("Invalid HTTP version in line: 'ICY'",)</body>
            </html>

When I check my network traffic, mitmproxy is still streaming the audio from somafm.com. If I connect multiple times, it'll have multiple downloading streams. They won't stop until I kill the process.
(This happens on the latest git checkout.)

Hi there. There are two things going on here. First, by default mitmproxy tries to spool an entire response in memory before relaying it to the client. This is necessary if we're going to allow you to intercept and modify the response before it is relayed, and unfortunately there's no generic way to tell if a response is an infinite stream. To cope with this, we have the --tcp option that lets you specify hosts that are forwarded with a generic TCP proxy - that is, the data is handed to the client as it arrives.
So, the real issue here is how we're handling the non-standard HTTP version error. First, we need to make sure we correctly terminate the upstream connection if we see an error we can't handle. Second, we need to consider whether we want to simply pass invalid HTTP versions down to the client. My inclination is to to be as permissive as possible - if we see it in the wild, however non-standard, we should be able to relay it.

Hi! Thanks for the response!
Good to know about the --tcp option. That may come in handy! I'm currently using mitmproxy as an adblocking proxy for my phone, that also lets me spy on what it's doing: https://github.com/epitron/mitm-adblock
So, once the ICY HTTP version issue is resolved, would setting --stream SIZE cause mitmproxy to start streaming the response after it received SIZE amount of data, instead of buffering it up forever?

I tracked this issue down today - the error we're seeing is acually a problem that occurs while closing the socket.
Here's how this issue was made possible:

On Windows, test_server.TestTransparentResolveError failed. This should have happened:
Resolving the target address fails.
We return a 502 error here.
The client receives a 502 error page.
This actually happened:
Resolving the target address fails.
We return a 502 error here.
We directly close the connection afterwards.
Closing a connection with pending readable data issues a RST on Windows, which arrived at the client before the HTML messages was transferred completely.
The client did not receive a 502 message but a disconnect instead.

To counter this, we started to read all data from the socket before closing it (here). Now, this fixes the issue mentioned above, but introduces a new one: If the remote endpoint continues sending data infinitely (as in a shoutcast stream), we're stuck in a loop here.
I see two ways how we can fix this:

Just sleep for a second after sending an error message (which is, as I see it, the only case where the still-data-on-the-socket-close-gracefully case applies)
Read a maximum on N bytes from the socket.

The close-socket topic comes up again and again because it's apparently very hard to fix (the current workaround survived more than half a year). @cortesi, do we want to attempt a fix before the next point release or do we want to play the safe ball here?

Ok, we agreed to make an attempt to fix the infinite read immediately, which is now commited to netlib and should be part of the next major release. This doesn't fix invalid HTTP versions though. My concern would be that just allowing any kind of HTTP version may yield to obscure error messages for non-HTTP protocols. How about just treating the HTTP version as an arbitrary string, but checking it against a whitelist: .startswith("HTTP/") or .startswith("ICY")?

Nice! Thanks for looking into this. The Windows TCP stack sounds delightful. :)

I'm in two minds about this. On the one had, whitelisting custom HTTP version specifiers seems over-specific to me. On the other hand, the Shoutcast protocol is NOT HTTP, just one that looks a lot like it.  The clincher for me is that many of the "real world" tools out there do interpret the version spec liberally - Shoutcast passes through many proxies (including Squid, with the right settings), and tools like CURL and so forth will happily do the same. I think this is a strong argument for relaxing the strictness here. I suggest we expand pathod and netlib to allow fiddling with the version to mimic this, and then wash that through into the tooling.

The first step has been completed: We do not attempt to parse the version string anymore but store it as plain bytes.

FWIW, in Fiddler I simply hacked this such that if the server's HTTPVersion value string starts with ICY, it is treated as HTTP/1.0 with streaming enabled and response bodies dropped as they are read. This seemed to placate the userbase.


Save status in finish process block, update isHypersyncCondition

#1323  👈
feature/proof-of-stake

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lazynina and the rest of your teammates on  Graphite


#1911 Change default quote in druid jdbc

Description

We need to change default quote for druid JDBC according to calcite spec.
Because the default identifier quoting character is double-quote(") and back-quote(`) would be an error without additional configuration.

As-Is: using ` for quote
To-Be: changed \" for quote

Related Issue :

#1911
How Has This Been Tested?

Create a data connection with the druid.
Create datasource with the above connection. (as linked type)
Create a dashboard with the above datasource.
Databoard created successfully.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Additional Context

run build
deploy to 1

Is this not to be included in the extension interface? I think it is not good to hard code the connection type in the "switch" statement.


Adding selection support

The multiple commits are caused by me uploading code via Github. I will rebase it all before I merge.

I've rewritten the code in main.js (which I will upload next) to make it more simple. @sbruchmann Unfortunately, I can't wait anyore and therefore I need to go on with this project. I'm not merging until now because there's a bug somewhere.

This feature is now ready. I'll rebase and merge it soon.

This issue has been fixed in #20. If anyone encounters any issues, they are kindly asked to open an issue. I'll close this pull request since it's "useless" now.


Can not install ubuntu 16.04 amd64

sudo dpkg -i ./pb-for-desktop-linux-x64-v2.1.0.deb
[sudo] password for redman:
dpkg: error processing archive ./pb-for-desktop-linux-x64-v2.1.0.deb (--install):
package architecture (x64) does not match system (amd64)
Errors were encountered while processing:
./pb-for-desktop-linux-x64-v2.1.0.deb

Note to maintainer:
Debian packages should be amd64 not x64
and i386 not ia32

Same here.

hi,
same here.

Joe from omgubuntu.co.uk repacked the .deb. you can acess the .deb searching by his comment on http://www.omgubuntu.co.uk/2016/09/app-to-get-android-push-notifications-on-ubuntu-desktop

@redpop1 , @philborman @ledshark24 & @canalet0  - thanks for your feedback. I could reproduce the issue.
The .deb  package is built via CI (see travis.yml), so there seems to be an issue with the build configuration / build matrix. Those issues will be dealt with in the next minor release at the latest - of course, pull requests are welcome :-)
Thanks for the bug report.

@redpop1 Please re-test with version 2.2.1, which should fix the architectures issue.

@sidneys  @redpop1 Works fine, even the name file is a little mess IMHO. The file name shpuld be:
pb-for-desktop_2.2.1_amd64.deb
pb-for-desktop_2.2.1_i386.deb
Once is a Debian package there is no need to explain is a Linux version (because Debian packages is only available for Linux).

works fine

@mhalano Thanks for the suggestion, naming schemes have been amended.


docs(tutorials/jokes): Silence typescript error

Closes: #5843

[x] Docs
[ ] Tests

Reverting this in #6329 for the reasons mentioned there


Check on sick machines

As @ilyas1974 and I chatted about the root cause of S360 alerts that showed up despite "machines used under 7 days are already excluded from telemetry", I began considering ways to avoid the problem in the future.
The root cause of some machines lasting more than a week is twofold: skipped rollouts and sick machines. We can't do much about skipped rollouts but we can delete sick machines even if we're not rolling out. @ilyas1974 mentioned this in https://dev.azure.com/dnceng/internal/_workitems/edit/4948#7312352 and suggested I create this issue.
We could start w/ a query and a process change i.e., have a canned query to list sick machines (in the sense they're orphaned from Helix and likely generally incommunicado) and a process we execute on (say) Mondays and Fridays to run the query and kill the listed machines manually. Might even be able to get away w/ less e.g., just do the process on Wednesdays when we are delaying or skipping our usual rollout.
The fullest approach would be to automate executing the query and deleting the machines. If that ran (say) daily, rollouts should go smoother and we should never (well, never say never) get S360 alerts just because a machine "lived" too long.

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[x] Internal Infrastructure Improvements

Release Note Description
At the first click stop, a note such as "Designed a query and enhanced our processes to avoid leaving unregistered build and test machines around. The aim here is to avoid unactionable security alerts.

and we should never (well, never say never) get S360 alerts just because a machine "lived" too long.

Yeah, I think it's still possible for this to happen under unlikely-but-not-unheard-of circumstances.

I think I don't understand why this is different from what the dead VM cleaner does. Do we think there's a bug there? We recently fixed the service to run quicker. I'm going to close this issue as I can't see how having a manual process would help here. Feel free to reopen and bring back to triage if you believe the fixes to the vm cleaner are not sufficient for this scenario.

@riarenas does the VM cleaner really do a solid job❔ I thought cleaning up machines that shouldn't exist in various scale sets was a big part of our rollouts. And, VMs that hang around for 7 days or more is a clear indicator something isn't happening that should be.

VM cleaner needs two passes to clean any machines that are not heartbeating. Which means it takes two hours and makes it unsuitable for point in time efforts like the rollouts.
I still reject the idea of having a manual process that we make part of our weekly rotations for something that doesn't happen often.

I'm confused. I didn't suggest the end state would be manual

The only actionable piece of this issues that could be started by me as the person in rotation on ops is:

We could start w/ a query and a process change i.e., have a canned query to list sick machines (in the sense they're orphaned from Helix and likely generally incommunicado) and a process we execute on (say) Mondays and Fridays to run the query and kill the listed machines manually.

Do we want to maybe split the issues?
How often do we have machines that live long enough to trigger this alert?

Do we want to maybe split the issues?

that might make sense

How often do we have machines that live long enough to trigger this alert?

we've seen S360 alerts about machines that shouldn't live longer than a day (but last a week) multiple times but I don't have a count. we'd need to inventory the machines mentioned in the S360 dashboard a few times to get accurate numbers.
how often do you, @garath, and @AlitzelMendez hit machines the VM cleaner shouldn't have left around but cause problems during rollouts❔ that number might be easier to guage

how often do you, @garath, and @AlitzelMendez hit machines the VM cleaner shouldn't have left around but cause problems during rollouts❔ that number might be easier to guage

Given how we only fixed the vm cleaner this past rollout, that will require some more time to be able to gauge. My anecdotal experience is that most machines I have to clean have only existed for a few hours.


Undo/Redo buttons not in IE and Firefox

The undo and redo buttons do not appear in Internet Explorer and FireFox, even on the demo site. http://alex-d.github.io/Trumbowyg/
Also great work on this tool :)
Informations
Browser + version: FireFox 47.0.1 and Internet Explorer 11
OS: Windows 8
Resolution: 1920x1080
How to reproduce the bug?
http://alex-d.github.io/Trumbowyg/

Just looked into the code a bit, and it looks like this is just supported in Chrome? Is there a reason?

It's juste because it's not possible to undo/redo via execCommand (content editable API) on IE and Firefox :/

Ah, makes sense. Thanks. One more thing though, idk if you officially support MS Edge (25.10586.0.0 Microsoft Edge) yet for Windows 10. The undo/redo buttons appear there, but do not work. As a workaround, I added:
&& !navigator.userAgent.includes("Edge/")

Thanks, I will check that :)


mcontrolcenter: init at 0.4.1

MControlCenter provides a relatively full-featured control panel for MSI laptops, written in Qt. It allows users to control MSI laptop power plans, fan speed, battery charging limits, keyboard backlight settings, USB power sharing and more.
The application comes with strong desktop integration: shortcuts, taskbar item, etc. etc. -- screenshots here:
https://github.com/dmitry-s93/MControlCenter/blob/main/README.md
This package has been previous requested by the NixOS community: https://github.com/NixOS/nixpkgs/issues/244881
The package comes with a patch that corrects MControlCenter's path to the modprobe binary, allowing it to automatically load the ec_sys kernel module (included with NixOS by default) with the right settings when launched.
This NixOS package has been fully tested on a NixOS Plasma5 desktop.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I would consider closing this pull request. I contacted personally the author and he is not interested in completing it any more, he also encouraged me to take over the work if I have a need for this package. I think is better to move the effort to https://github.com/NixOS/nixpkgs/pull/306216 and try to get this package merged.

#306216 has just been merged, mcontrolcenter is now into master, there is no need for this pull request any more, please can we close it?


Can't see the full menu in Chrome for Mac OS 10.13.3

Hey, thanks for the report.  Difficult for me to reproduce since I don't have a Mac, but let me see if I can track down a Mac user or two to see if I can at least see it on another computer.

I have the easiest workaround ever!
I discovered that if, when I get the error I reported, I simply click a second time, the full menu appears.
This extension is SO awesome!
Thank you for your work!
Where is your donation button, may I ask?

PS: Being unfamiliar with this terrain, I made the same, "Eureka" post as a new issue... my bad.

So glad to hear it!  Still not clear as to what's causing the display issue, but will poke further when possible. This is a passion project - no donations needed, but positive reviews are appreciated as they help more people to learn about the extension. :) You can do so here:
https://chrome.google.com/webstore/detail/free-your-stuff/hlkhpekhgcaigleojiocoeockhcaglia/reviews?hl=en


[PluggableDevice] Add TF_OpKernelConstruction_GetNodeDef

Although the API has functions like TF_OpKernelConstruction_GetAttrInt32, it lacks an abstract to iterate through all the attributes and get their names as well as their value. Since some device backends have relatively slow kernel creation times, being able to access the NodeDef allows them to uniquely identify kernels for caching purposes.

@jpienaar Can you please review this PR ? Thanks!

We already have taken some steps to get rid of most iteration over attributes towards enabling the backing to not be NodeDef.
Additionally exposing the NodeDef results in exposing unregistered attributes which are in the UB part of the world. But I don't know what the policy is PluggableDevice side.

@jpienaar I can certainly change this PR provide ways to iterate through attributes instead of exposing the NodeDef itself. The ultimate goal here is to be able to cache kernels that have identical attributes to avoid creating kernels that have a long initialization cost multiple times. Can you point me towards the steps taken so far to decouple attributes from the NodeDef?

@jpienaar  Can you please assist on above comments from @PatriceVignola. Thanks!

@jpienaar Can you please assist on above comments from @PatriceVignola. Thanks!

@gbaned Done!

@PatriceVignola Can you please resolve conflicts? Thank you!

@gbaned Done!


SPSearchServiceApp is using incorrect variables when setting service account

Details of the scenario you try and problem that is occurring:
On line 276 in SPSearchServiceApp, the code is using the incorrect variables. It should be $params. instead of $variablename:
https://github.com/PowerShell/SharePointDsc/blob/dev/Modules/SharePointDsc/DSCResources/MSFT_SPSearchServiceApp/MSFT_SPSearchServiceApp.psm1#L276
The DSC configuration that is using the resource:
SPSearchServiceApp
Version of the Operating System and PowerShell the DSC Target Node is running:
Windows Server 2016
Version of SharePoint that is used (e.g. SharePoint 2016):
SP2016
Version of the DSC module you're using:
v<IP_ADDRESS>

Fix will be included in my next Bugfix PR

Closed via PR #838


Prettify cargo crev verify

I've improved formatting, but at least some color would help.

I think the result rows should be sorted: unknown, verified, and then flagged. In this way the most important results will be the most visible. I also think that they should be sorted a second time alphabetically. The summary statistics should then be underneath all of that.
@dpc @Dylan-DPC What do you guys think?

I for one like the way stuff is displayed currently. It is easily grepable and shows up in real-time, without having to wait. But I guess the default could be something more human-friendly.
@rffrancon Seems to me that the logical sorting order should be ether verified, unknown, flagged or in reverse. Probably flaggged stuff should be at the bottom.  I agree about sorting in alphabetical order.
A --no-sort would by nice too that would just display stuff as it goes through it.

I agree with you. I like the realtime side of it also. But it would just be nice if the results were displayed in a consistent way, changes would be easier to spot. --no-sort is a nice plan.
We could also verify asynchronously from what I can tell, but perhaps that is over complicated for this stage.

@rffrancon Yeah, the simpler the better.

Note: Now verify deps will have review counters. 286d69d4ed2d46633275c732d1d9fe60696c4bad

I used verify deps just now and asked myself what these numbers are. A table header would be great to show what the columns mean.

How about outputing to csv format?

We could use (as a user) xsv to prettify as a table
The csv would contain the header. If I pipe the versify output to a file (cargo crev crate verify --show-all --for-id ... > crev.log) the header is not included in the file.
Headers are hard to associate to columns due to alignments. Using csv format woulf fix that.

@nbigaouette It shouldn't be difficult to add outputs in any format (considering how nice serde is). PRs welcome. I really can't invest much time in nice-to-have features right now.

Good enough now, methinks.


Modal shows too fast

It might be a silly issue, but to be honest when testing on live demo I got jumpscared by the modal.
Maybe a prop to set transition/display speed?

@johnathan-codes Thanks for the suggestion! Having more configuration is definitely something I have considered. Hopefully will find some time to implement it soon.
Feel free to open a PR if you fancy having a go yourself in the mean time.


This has a number of advantages over the current approach:

When a game uses dirty regions, we only need to make a copy of those parts. Previously we had to copy the entire resource.
This is significant in Nostale which keeps reusing a single 512x512 managed texture and writes data into it before every draw call. The data written is usually just ~60x60px so we only have to copy that instead of the whole 512x512 texture over and over again.
Should result in slightly less GPU load because the GPU also has to do less copying.
We don't need to synchronize the CS thread at all when a game locks a managed/sysmem resource
It works with broken games that keep the managed pointer for too long (Warhammer Online)

Nine (or rather Radeonsi) also does it this way. The downside is, that games that only lock and write their managed textures once might need more memory/address space and might load a bit slower. We copy the entire texture for textures that need to be converted in a compute shader because it seemed a bit painful to only copy the dirty parts there. I don't think that's a big deal anyway.
I'm rather scared of this, so it's gonna need a lot of testing.

Mass Effect is crashing so hard and badly for me with the last commit (950M, 461.92 and 465.89) that if that happens when I have MSI afterburner open, my whole pc shuts down too.

The crash was there even without overlays, that only transformed it in an entire system lock.
Anyway, now everything works properly (including rivatuner)

In Everquest 2 these new patch causes some texture issues.
(Wrong textures or texture overlays: Grass in desert, blue grass where green grass was expected)

Can you make an apitrace of Everquest 2? Doesn't matter whether you use the PR, regular DXVK or WineD3D for that.

I am not familar with apitrade.
Did a "apitrace trace -a d3d9 everquest2.exe" and got around 18 GB for 5 minutes ingame.
Don't think I should upload.
Any specific command how to trace?

You'd usually just drop the 32bit apitrace wrapper d3d9.dll next to the games exe file. Your approach works too. Large files are to be expected. 18GB is on the larger side but not entirely unheard of. I don't need you to run it for 5 minutes either. Anything between 30s and 2 minutes should do the trick.
On top of that, trace files can usually be compress very well.

@K0bin
Will try it later after work.
Just recognized: when using above command it uses not dxvk d3d9 lib and only apitrace wrapper and original d3d9 (no graphic issue).
dxvk d3d9.dll is next to everquest2.exe, d3d9.dll wrapper of apitrace is in apitrace/lib subfolder.
Copying wrapper lib next to everquest2.exe would overwrite dxvk d3d9.dll
Using Apitrace command with linking to d3d9.dll of dxvk gives graphic errors, but no tracefile.
Maybe I have to copy dxvk d3d9.dll to syswow64, but atm windows refuses.

@Wishbringer71

Just recognized: when using above command it uses not dxvk d3d9 lib and only apitrace wrapper and original d3d9 (no graphic issue).

That's not a problem. Even if you can't reproduce the issue while making the trace, I will be able to when I replay the trace with DXVK afterwards.

Maybe I have to copy dxvk d3d9.dll to syswow64, but atm windows refuses.

Don't do that. That's a bad idea and might potentially break your Windows installation.
If your original method worked for you, you can just do it that way again. That's perfectly fine too.

Apitrace EQ2 compressed .7z
https://1drv.ms/u/s!AqyqBv-ep8SMhofAFdfxtHfvKq2XThI?e=lwaiug
PW: K0bin
expires at 06.04.2021

@Wishbringer71 The Everquest 2 issue is also present on master and I can even reproduce it with 1.8.1 and 1.7.3. So it seems like its not caused by this PR. I'll look into it nonetheless.

@K0bin
Thanks!
I recognized issue (pictures above) only in builds with your "copy on dirty regions",
otherwise I would have normally reported it under issues.

Split it up into smaller commits.

@Wishbringer71 Are you sure it works on DXVK master?
I can reproduce the problem using your trace all the way back to DXVK 1.5.5. That's just the oldest version I've tested.

@K0bin
At least it worked with 1.8.1 and master with AMD 21.3.2 at a Radeon RX 5700XT.
Maybe it‘s an additional problem with NVidia (seeing your drivers 465.89.0)

Someone reported another problem with it on Discord.

pr 1987 causes a rendering issue with some of the text elements on the menu in Remember Me. Tested on Windows, nvidia turing.  Apitrace: https://www8.zippyshare.com/v/fVbi43VK/file.html

https://mega.nz/#!UjgBiQbC!hNh--CBYZXKJbcrEvTgSFni_iprMDaBBrpQ_EsSrM-I

Fixed.

@K0bin
Issue is still there.

I can't fix it without having access to the game.
It also happens with every other DXVK version when replaying the trace.

Ok I downloaded the game. @Wishbringer71 How do I get to that area?

@K0bin
Use Fasttravel to the Plane of Magic
Use Teleportation-Pad to Pakiat Bluffs

@Wishbringer71 How do I do any of that after just making a character?

@K0bin
Sorry, for longyear players it's often difficult to see things like a new player.
Hope, you could create a "Heroic" character and not a level one.
Because the areas are level 100+.
In cities there are blue shimmering globes (eg. at ports) for fast traveling through the World Norrath.

But from there you can't enter the higher level zones.
Please teleport to Enchanted Lands, there head east and walk some time to an alteran spire. Clicking on Spire.
Best use "Open Map = M"
Most creatures are not aggro. aggro creatures have read surrounded names.

There you can select the Plane of Magic.

Open Map again, head to Teleportion Pad.
At Isle there are no aggro creatures.
Use Pad, standing on it, clicking on it. Select Pakiat Bluffs, press ok/travel.

Now you are in an area, where bug is shown each time.

I hope, pictures were helpful.

Unless you find a way to reproduce any of this in the starting areas for a level 1 character, I'm not gonna be able to fix any of this.

@Wishbringer71 Would you mind joining our discord server to help me reproduce this?
https://discord.gg/xmJ5NyPE
I made a level 100 character but when I try to teleport to the plane of magic it just says that I do not meed the requirements.

@K0bin
Maybe it‘s really paid content.
Because there are no more accessquest requirements for these zones.
They were there when these zones were released 4 years ago, but with new expansions old requirements are gone.
Sorry for your effort.
Will try to find one ore two places in the lowlevel zones to reproduce issues.
Wasn‘t long time there.

@Wishbringer71 I fixed another issue. Can you test Everquest 2 again please?

@K0bin
Sorry, "still green":

Meanwhile I travels around alot in the "old world" = older zones. But only the newer zones from Plane of Magic, Elementar planes, Luclin and so on upward have these issues.
And these all new zones seems are not accessible for free.
So I think developers used a new featur in terraincreation. Old zones looks good.
Will try further to find a zone where this problem persists and is accessible for free, but there are hundreds and it's only in some areas.

@Wishbringer71 are you sure that the apitrace you made shows that area? Can you make another one with that specific spot in your screenshot?

@K0bin
with aktuell master "dxvk-master-fb0b11903baeaf2ebacea26e077cd220b09e00ce" all looks fine
with merge "dxvk-merge-7a52ba660850e9975f73a520e93ecea1958637ca" from "D3D9: Copy only dirty regions" I got above picture (Plane of Magic - Pakiat Bluffs)
Apitrace is from that area, just logged in with another character at another computer and did a new trace. Location is on top of an spire (should be the same from picture above).
https://1drv.ms/u/s!AqyqBv-ep8SMhofCAds6195ikOg4axo?e=ypnsb4
PW: K0bin
Expires: 2021-04-21

The apitrace replays fine (I think that's how it's supposed to look?) for me. Can you reproduce the issue when replaying the apitrace with dxvk?

@DadSchoorse
For me it plays fine with actual dxvk master and of course with original d3d9 (includes issues with AMD drivers).
Only with D3D9: Copy only dirty regions I get green areas instead of desert.
atm I use dxvk on windows only to escape d3d9 issues with AMD drivers for RX 5700XT (wrong anisotropy and washed out textures)

Can you make an apitrace on Linux with DXVK installed?

I smell an amdvlk issue coming here 🙄

@Wishbringer71
Sry that I have to keep bothering you but I'd like to fix this and I can't reproduce it locally.
Could you make another apitrace at the exact same spot but this time use the dlls in this zip file:
apitrace_dxvk.zip
Just put both of them into the Everquest 2 folder right next to the exe file and start the game.

@K0bin
No problem, compressing trace atm.
Here a short video of trace
https://1drv.ms/u/s!AqyqBv-ep8SMhofCEm3GdyOaefiM_Rk?e=uIWbEr
And here is the trace
(will be entered when compressed and uploaded)

The Everquest 2 issue appears to be a driver bug. Someone else tested that exact same spot with this PR and it was fine.

@K0bin
ok, thanks for Info,
will test it with some older driver versions and new ones when released.
Report to AMD is out.

@K0bin
Afeter some testing:
with newest driver 21.4.1 issue is still there,
traced back to 20.5.1 hws (oldest driver I had, 11 months old), issue was there too.
So if it is a driver bug, it's a very long lasting one.

@Joshua-Ashton

Looks fine upon initial review, I am sure we will find edgecases down the line :-)

I think i might have just found one of those... With Star Wars - The Old Republic, although not with "Dirty Regions" but rather "Use staging buffer for managed copies" https://github.com/doitsujin/dxvk/commit/4261ff6ec1aa7efdc6d7bf6a5b9434c2eb6cc184
I run SWTOR through steam, and upon last Proton6.3-5 update, dxvk got updated to 1.9 and the "stutter out of hell" problem happened. Reverting DXVK to 1.8.1 i have no issues. Bisecting this, it started happening at the above linked commit. It is a bit better on 1.9+GIT, as when i turn around it stutters for 10-20 seconds and seems to even out.. until i move forward a bit and stuttering starts again.
Can you work with a apitrace from windows? (Saw a link above with d3d9.dll and d3d9_dxvk.dll posted)... as i think i need a "for-dummies" explanation if i should get this working from proton...
If so, ill create a new issue for this, since source has changed quite a bit since this PR.

A Windows apitrace works fine, doesnt even have to be made with DXVK and yes, pls also open a separate issue.
This is pretty weird though. If anything the changes should reduce stuttering. I'll have to investigate that.


Added gpt-4-0125-preview as a model option

I've taken the pricing from https://openai.com/pricing which is the same as the current gpt-4-1106-preview

For those who want to be automatically upgraded to new GPT-4 Turbo preview versions, we are also introducing a new gpt-4-turbo-preview model name alias, which will always point to our latest GPT-4 Turbo preview model.

For those who want to be automatically upgraded to new GPT-4 Turbo preview versions, we are also introducing a new gpt-4-turbo-preview model name alias, which will always point to our latest GPT-4 Turbo preview model.

That might be good as an additional feature and I would be using it if it were added, but there is a disconnect there where we would not be communicating which model version the user is using exactly, plus we would still need to update the token costs manually if it changes between versions.

So, my primary concern is the fact that our API keys will be sent through
the website and presumably stored. What's to prevent bad actors from using
our keys?
On Thu, 25 Jan 2024 at 18:04, Luke Aaron @.***> wrote:

I've taken the pricing from https://openai.com/pricing which is the same
as the current gpt-4-1106-preview
You can view, comment on, or merge this pull request online at:
https://github.com/ztjhz/BetterChatGPT/pull/521
Commit Summary

42e0f54
https://github.com/ztjhz/BetterChatGPT/pull/521/commits/42e0f547de0c2de2a7910524560261631fdb3d2e
Added gpt-4-0125-preview as a model option

File Changes
(2 files https://github.com/ztjhz/BetterChatGPT/pull/521/files)

M src/constants/chat.ts
https://github.com/ztjhz/BetterChatGPT/pull/521/files#diff-5991d1a42d0cf29dd25cd52fee80b0c81b0782d1c3351b728c2783a2fd824205
(8)
M src/types/chat.ts
https://github.com/ztjhz/BetterChatGPT/pull/521/files#diff-149830263521dd5458cda6d3607035614de3c2d8c55a4784ac632891361601e7
(2)

Patch Links:

https://github.com/ztjhz/BetterChatGPT/pull/521.patch
https://github.com/ztjhz/BetterChatGPT/pull/521.diff

—
Reply to this email directly, view it on GitHub
https://github.com/ztjhz/BetterChatGPT/pull/521, or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAORNT6J4C7NKWDR6LV4FDLYQMFLPAVCNFSM6AAAAABCLPBXR6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYDCNBVGQ2DSNY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@AETHER-ENGINEERS I don't think this is relavent to this PR. You might want to make a new issue to discuss.
FYI the API key is stored on the client side using localstorage and according to the sourcecode on GH only used when being checked, set and posting requests directly to OpenAI.

@DigitallyTailored Why was the token length reverted back to 4096?

@DigitallyTailored Why was the token length reverted back to 4096?

As per @NN1985 comment: https://github.com/ztjhz/BetterChatGPT/pull/521#discussion_r1468530493
The original 4096 appears to be correct.

@ztjhz  @DigitallyTailored  First, thank you for the update on this matter.
However, when a token length of 4096 is specified, I am unable to input long text, which I was able to do successfully with the previous version (gpt-4-1106-preview).
I also tried running BetterChatGPT locally after I rewrote the constant in src/constants/chat.ts as follows, there are no errors when receiving API output:
export const modelMaxToken = {
  'gpt-3.5-turbo': 4096,
  'gpt-3.5-turbo-0301': 4096,
  'gpt-3.5-turbo-0613': 4096,
  'gpt-3.5-turbo-16k': 16384,
  'gpt-3.5-turbo-16k-0613': 16384,
  'gpt-3.5-turbo-1106': 16384,
  'gpt-3.5-turbo-0125': 16384,
  'gpt-4': 8192,
  'gpt-4-0314': 8192,
  'gpt-4-0613': 8192,
  'gpt-4-32k': 32768,
  'gpt-4-32k-0314': 32768,
  'gpt-4-32k-0613': 32768,
  'gpt-4-1106-preview': 128000,
//  'gpt-4-0125-preview': 4096,
  'gpt-4-0125-preview': 128000,
};

Is this still the correct value of 4096? Does gpt-4-0125-preview not accept long inputs like gpt-4-1106-preview version?


Translation to Danish

I have completed this translation in crowdin.
Some of them might be wrong depending on the context in which they are used. But they should be 90% accurate, and the rest is probably easier to spot in-app

@PTST sorry for the delay. The danish translation is now live in build 48 on TestFlight.


Issue #318 Pass location to service search REST endpoint if the user …

…permits it

@bensinjin for review

@bensinjin can you have another look at this PR, I needed to make some changes in the service search saga to handle error conditions. Could you also give it a QA sweep on iOS, I've only tested in on Android. With or without the app having permission to access location, with or without location services being turned on. Expected behaviour when the app does not have location is to show the services in random ordering, so you should see services with locations far away.


[website] The "fork me on github" banner is not clickable

This makes it very confusing.
I'm using firefox.

hmm, I am not able to reproduce in Firefox 46.0.1 on Mac.
Can you give any further specifics?

sorry, I missed some info. this is happening on the documentation page. It is working fine on the homepage

Ok. Here after long long time and I see that the issue comes up when you are in 90% zoom mode. Basically the Contents sidebar div is overlaying on top of the banner around the Fork Me area. Adding an explicit z-index: 1 solves the issue. I think in any case, we would want the banner to be on top of everything.
I'll send a PR for this one and see what happens :)


When loading attachments, it gives an error...

When loading attachments and bot avatar, it gives an error: Failed to send message: HTTP 500 Internal Server Error, {"message": "500: Internal Server Error", "code": 0}

Hey, I'm not sure if I understand what you mean. Are you trying to send attachments or trying to set the bot avatar?


To-do: Make hayt less friendly

Add checks to morning and night scripts to only say hello or good night once every day.

Imma do dis tomorrow.

I think this is resolved with the recent hax, closing.


What can replace 'initializer = tf.contrib.layers.xavier_initializer_conv2d()' in tensorflow 2.0?

Now that tensorflow has no attribute 'contrib'. Thanks a lot!

You can find the Glorot initializer which is a different name for the Xavier initializer here: tf.keras.initializers.GlorotNormal
I hope this helps!

@lufol It really works. Thank you!

Can we close this issue as it was resolved.Thanks!

I am closing this issue as it was resolved.Thanks!


Update UserSearch.php

Fixes syntax error, unexpected '::' (T_PAAMAYIM_NEKUDOTAYIM).

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Fixed issues
#921

Fixed in https://github.com/dektrium/yii2-user/commit/a025d446c6d512ef042d30211107a2f336b86734
Thanks!


User Guide needs a better versioning scheme

We currently use an ad-hoc method of documenting API differences between versions. It would be good to have a UX where the entire user-guide is versioned, not just individual pages. Something akin to the TensorFlow docs would be useful for Turi Create.

I agree this should be addressed.
I really like how scikit-learn does the versioning of their user guide. Basically you can always choose a different version from the left hand nav. If you're looking at anything other than the most recent version, you get a big red warning text box at the top.

Who knows whether or not to use too when currency block chain technology

有谁知道 tixoncash  是否使用区块链技术


ISPN-5993 ClassCastException in ProtobufMetadataManagerInterceptor fo…

…r clear
Since clear is now non-tx we can just remove the lines of code that attempt to lock .errors key and the issue is gone.
Jira: https://issues.jboss.org/browse/ISPN-5993

Integrated, thanks Adrian!

Integrated in 8.1.x as well.


[BUG]: Latest sort skips real latest item

Gorse version
Gorse master @ 0.4.14
Gorse server @ 0.4.14
Gorse worker @ 0.4.14
Describe the bug
Currently the latest sort only shows items from the second most recent item and older. It completely disregards the first most recently created item.
To Reproduce

Purge Gorse
Add an item
See that the item has been added to the cold storage database (postgres)
See there is nothing @ /api/latest
Wait an arbitrary amount of time (30 seconds, 2 hours, ...)
Add another item
See that the first item you added is the only item @ /api/latest

Expected behavior
The latest sort should not truncate the most recent item

Disregard, this was an artifact of a bug fix I made on a forked branch


Endpoint request timed out

Dear Rigetti gods,
my code failed to connect to 8Q-Agave device and asked me to send you the following snippet:
  File "../vqe_helium_example.py", line 74, in expectation_estimation
    result = q_device.run(meas_prog, qubits_to_measure, sample_number)
  File "/Users/lg4/CK-TOOLS/lib-pyquil-compiler.python-3.6.5-macos-64/build/pyquil/api/qpu.py", line 178, in run
    job = self.wait_for_job(self.run_async(quil_program, classical_addresses, trials, needs_compilation, isa))
  File "/Users/lg4/CK-TOOLS/lib-pyquil-compiler.python-3.6.5-macos-64/build/pyquil/api/qpu.py", line 286, in wait_for_job
    status_time if status_time else self.status_time)
  File "/Users/lg4/CK-TOOLS/lib-pyquil-compiler.python-3.6.5-macos-64/build/pyquil/api/_base_connection.py", line 49, in wait_for_job
    job = get_job_fn()
  File "/Users/lg4/CK-TOOLS/lib-pyquil-compiler.python-3.6.5-macos-64/build/pyquil/api/qpu.py", line 283, in get_job_fn
    return self.get_job(job_id)
  File "/Users/lg4/CK-TOOLS/lib-pyquil-compiler.python-3.6.5-macos-64/build/pyquil/api/qpu.py", line 268, in get_job
    response = get_json(self.session, self.async_endpoint + "/job/" + job_id)
  File "/Users/lg4/CK-TOOLS/lib-pyquil-compiler.python-3.6.5-macos-64/build/pyquil/api/_base_connection.py", line 78, in get_json
    raise parse_error(res)
  File "/Users/lg4/CK-TOOLS/lib-pyquil-compiler.python-3.6.5-macos-64/build/pyquil/api/_base_connection.py", line 105, in parse_error
    raise UnknownApiError(str(body))
pyquil.api.errors.UnknownApiError: {'message': 'Endpoint request timed out'}

The server has failed to return a proper response. Please describe the problem
and copy the above message into a GitHub issue at:
    https://github.com/rigetticomputing/pyquil/issues

@ens-lg4  Are you still experiencing this problem?

@ens-lg4 hey Leo, can you please give more details on what you were trying to run? We would like to try to replicate the issue.


Add tag prop to form

Here is an example:

  <my-component v-for="(detail, i) in details" :detail="detail" inline-template @change="changeDetail(detail, i)">
    <vue-form tag="tr" :state="formstate">
      <validate tag="td">
        <input type="text" name="name" required>
      </validate>
    </vue-form
  </my-component>

I'll merge this to allow customization of vue-form tag (although it makes for it to be a <form> since it binds to the submit event).
Not sure about the use case above. Would it make more sense to have the table wrapped with <vue-form> then have dynamic name within the loop?

I have a synthetic submit event in each row. Each row gets its own form
validation. I'll make a minimal example to demonstrate.
On Mon, Apr 3, 2017, 04:14 fergaldoyle<EMAIL_ADDRESS>wrote:
I'll merge this to allow customization of vue-form tag (although it makes
for it to be a  since it binds to the submit event).
Not sure about the use case above. Would it make more sense to have the
table wrapped with  then have dynamic name within the loop?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fergaldoyle/vue-form/pull/45#issuecomment-291076655,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAekZP_An0TnQznRoy9cN-Zb7pxZyF8lks5rsKp0gaJpZM4Mw5vC
.

Right now, I use code like this:
const VueForm = require('vue-form');
const VueFormComponent = VueForm.mixin.components[VueForm.config.formComponent];
const MyComponent = {
    mixin: [VueForm],
    props: ['item'],
    data() {
        return {
            state: {},
        };
    },
    components: {
        VueForm: {
            mixin: [VueFormComponent],
            render(h) {
                var vnode = VueFormComponent.render.call(this, h);
                vnode.tag = 'tr';
                return vnode;
            },
        },
    },
},

Perhaps instead if you prefer, I could document this approach?

I could use a parent form as you suggest and create names based on the index:
<validaor v-for="(item, i) in items">
    <input :name="`item${i}`">
</validator>

But, it would be nice if the behavior was more like how Vue treats refs and turn it into an array:
<validaor v-for="(item, i) in items">
    <input name="item">
</validator>

And then one could access formstate.item[index].$error
https://github.com/fergaldoyle/vue-form/blob/master/src/components/vue-form.js#L51
https://github.com/vuejs/vue/blob/e7a2510e631bd25f46b4e1125b83a9236a50ff1d/src/core/vdom/modules/ref.js#L34
I have not fully read all of the vue-form code yet to determine how difficult this would be to implement.

Fixed in v4


feat(Button): add advanced handling of disabled prop

This PR:

fixes #1775
performs a refactoring of  the render() method
improves the test coverage

Codecov Report

Merging #1781 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1781      +/-   ##
==========================================
- Coverage   99.75%   99.75%   -0.01%
==========================================
  Files         142      142
  Lines        2459     2452       -7
==========================================
- Hits         2453     2446       -7
  Misses          6        6

Impacted Files
Coverage Δ

src/elements/Button/Button.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ea612...e450045. Read the comment docs.

Perfect, thank you.

Released in<EMAIL_ADDRESS>


cosmetic changes

Pull Request Test Coverage Report for Build 425777966

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 43.105%

Totals

Change from base Build 424466713:
0.0%

Covered Lines:
24114

Relevant Lines:
51261

💛  - Coveralls

Solving an issue with long names. Without fix it looks like this:


Fix linting

Fix linting after https://github.com/st4lk/django-rest-social-auth/pull/97

Coverage remained the same at 91.29% when pulling 8d8d7cb6b62c20f13b2f40c1272873d13bf47e5b on fix-linting into 23ace26372bf36e71e895e4e3d6767620eefb087 on master.


Zombie extension host

Write an extension that does while(true); and run it. Restart VS Code and notice you have zombie extension host process running forever on your system.

fyi @dbaeumer

@alexandrudima we discussed that when being in Redmond. We need a watch dog which monitors detached processes.

Let's continue tracking in #26445


[BUG] Writing multiple messages to a single Eventhub

Investigative information

Timestamp: 2021-12-18T18:29:00
Function App name: (debugging locally)
Function name(s) (as appropriate):(debugging locally)
Core Tools version: 4.0.3971 Commit hash: d0775d487c93ebd49e9c1166d5c3c01f3c76eaaf  (64-bit)

Repro steps
The function.json file is
{
  "scriptFile": "__init__.py",
  "bindings": [
    {
      "type": "eventHubTrigger",
      "name": "inputEvent",
      "direction": "in",
      "eventHubName": "device.data.raw",
      "connection": "EVENT_HUB_CONNECTION_STRING",
      "cardinality": "one",
      "consumerGroup": "$Default",
      "dataType": "string"
    },
    {
      "type": "eventHub",
      "direction": "out",
      "name": "$return",
      "connection": "EVENT_HUB_CONNECTION_STRING",
      "eventHubName": "device.data.decoded"
    }
  ]
}

Test 1 - As per first proposition of 327
def main(inputEvent: func.EventHubEvent) -> typing.List[func.EventHubEvent]:
    return (inputEvent.get_body(), inputEvent.get_body())

Test 2 - As per first proposition of 327
def main(inputEvent: func.EventHubEvent) -> typing.List[func.EventHubEvent]:
    return (inputEvent.get_body(), inputEvent.get_body())

Test 3 - As per #192
def main(inputEvent: func.EventHubEvent) -> str:
    return (inputEvent.get_body(), inputEvent.get_body())

Expected behavior
One of the methods should be able to send several messages to Eventhub
Actual behavior
Test 1
Function can not be started
[2021-12-08T17:36:04.098Z] Executed 'Functions.decode' (Failed, Id=a20e6894-0641-48be-a974-98e13ba7517e, Duration=329ms)
[2021-12-08T17:36:04.098Z] System.Private.CoreLib: Exception while executing function: Functions.decode. System.Private.CoreLib: Result: Failure
Exception: FunctionLoadError: cannot load the decode function: has invalid non-type return annotation typing.List[azure.functions._eventhub.EventHubEvent]
Stack:   File "C:\Program Files\Microsoft\Azure Functions Core Tools\workers\python\3.9/WINDOWS/X64\azure_functions_worker\dispatcher.py", line 311, in _handle__function_load_request
    self._functions.add_function(
  File "C:\Program Files\Microsoft\Azure Functions Core Tools\workers\python\3.9/WINDOWS/X64\azure_functions_worker\functions.py", line 240, in add_function
    raise FunctionLoadError(
.

Test 2
Function can not be started
[2021-12-08T17:40:06.521Z] Executed 'Functions.decode' (Failed, Id=f3a5d015-67b4-4b50-bdb4-a4d14a3625de, Duration=256ms)
[2021-12-08T17:40:06.527Z] System.Private.CoreLib: Exception while executing function: Functions.decode. System.Private.CoreLib: Result: Failure
Exception: FunctionLoadError: cannot load the decode function: has invalid non-type return annotation typing.List[str]
Stack:   File "C:\Program Files\Microsoft\Azure Functions Core Tools\workers\python\3.9/WINDOWS/X64\azure_functions_worker\dispatcher.py", line 311, in _handle__function_load_request
    self._functions.add_function(
  File "C:\Program Files\Microsoft\Azure Functions Core Tools\workers\python\3.9/WINDOWS/X64\azure_functions_worker\functions.py", line 240, in add_function
    raise FunctionLoadError(
.

Test 3
Function is started but there is an execution error:
[2021-12-08T17:56:36.411Z] Executed 'Functions.decode' (Failed, Id=cc123efe-9b7a-419c-8e4a-a29b3be2e8cb, Duration=40ms)
[2021-12-08T17:56:36.412Z] System.Private.CoreLib: Exception while executing function: Functions.decode. System.Private.CoreLib: Result: Failure
Exception: NotImplementedError: unexpected Datum type: None
Stack:   File "C:\Program Files\Microsoft\Azure Functions Core Tools\workers\python\3.9/WINDOWS/X64\azure_functions_worker\dispatcher.py", line 427, in _handle__invocation_request
    return_value = bindings.to_outgoing_proto(
  File "C:\Program Files\Microsoft\Azure Functions Core Tools\workers\python\3.9/WINDOWS/X64\azure_functions_worker\bindings\meta.py", line 117, in to_outgoing_proto
    return datumdef.datum_as_proto(datum)
  File "C:\Program Files\Microsoft\Azure Functions Core Tools\workers\python\3.9/WINDOWS/X64\azure_functions_worker\bindings\datumdef.py", line 190, in datum_as_proto
    raise NotImplementedError(
.

Known workarounds
N/A
Contents of the requirements.txt file:
azure-functions==1.8.0
requests==2.26.0

Hi, Microsoft team,
Did you had the opportunity to look at this? Thanks

@Oliv4945 sorry for late reply! is the issue fixed for you now?

I am able to reproduce this issue on coretool v4, py 3.9.

Hi @YunchuWang, yes I still have the issue. Glad that you are able to reproduce

@Oliv4945 thanks for the reply and raising the issue! I come up with a working solution writing multiple strings without specifying return type hint. (please see below)
The return type hint validation in current function runtime will be under internal investigation/discussion. For the time being, please do not specify return type hint if you write multiple messages to eventhub output.
Apology for missing examples on writing multiple messages to eventhub via output. Essentially when you return multiple messages in eventhub output, please also ensure return a list of json-serializable objects (ref at how python worker encodes eventhub output value at https://github.com/Azure/azure-functions-python-library/blob/dev/azure/functions/eventhub.py#L90-L91)
Funtime version: ~4
Python version: 3.9
Function file
from typing import List
import azure.functions as func

def main(events: List[func.EventHubEvent]):
    return [events[0].get_body().decode('utf-8'), events[1].get_body().decode('utf-8')]

function.json file
{
  "scriptFile": "__init__.py",
  "bindings": [
    {
      "type": "eventHubTrigger",
      "name": "events",
      "direction": "in",
      "eventHubName": "input",
      "connection": "EVENT_HUB_CONNECTION",
      "cardinality": "many",
      "consumerGroup": "$Default",
      "dataType": "binary"
    },
    {
      "type": "eventHub",
      "direction": "out",
      "name": "$return",
      "connection": "EVENT_HUB_CONNECTION",
      "eventHubName": "output_event"
    }
  ]
}

Please let me know if you have any further questions.

Thanks @YunchuWang for those explanations.


no pattern checking for query parameters

Hello,
I defined in a raml, a query parameter with a pattern:
...
        myQueryParam:
          type: string
          required: true
          repeat: false
          pattern: |
              ^.{1,255}$
...

The issue is that the generated decorator does not reflect the pattern and the requiredfields .
I would expect the decorator method to have something like :
...
        @RequestParam
        @NotNull //expected
        @Pattern(regexp = "^.{1,255}$")  //expected
        String myQueryParam,
...

That leads to differences between what is exposed by the raml and the code.

I don't think we can support this, i've tried experimenting with @Valid and @Pattern alongside the query parameters and path variables within the method signature and spring seems to ignore them. From our end we use jsonschema2pojo to generate objects and that supports JSR303 annotation checking

if you have any code examples of how this works, i'd love to see it


Error setting up entry for gardena_smart_system

Logger: homeassistant.config_entries
Quelle: config_entries.py:604
Erstmals aufgetreten: 14. August 2024 um 10:29:30 (1 Vorkommnisse)
Zuletzt protokolliert: 14. August 2024 um 10:29:30
Error setting up entry for gardena_smart_system
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/httpx/_transports/default.py", line 69, in map_httpcore_exceptions
yield
File "/usr/local/lib/python3.12/site-packages/httpx/_transports/default.py", line 373, in handle_async_request
resp = await self._pool.handle_async_request(req)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/httpcore/_async/connection_pool.py", line 216, in handle_async_request
raise exc from None
File "/usr/local/lib/python3.12/site-packages/httpcore/_async/connection_pool.py", line 196, in handle_async_request
response = await connection.handle_async_request(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/httpcore/_async/connection.py", line 99, in handle_async_request
raise exc
File "/usr/local/lib/python3.12/site-packages/httpcore/_async/connection.py", line 76, in handle_async_request
stream = await self._connect(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/httpcore/_async/connection.py", line 122, in _connect
stream = await self._network_backend.connect_tcp(**kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/httpcore/_backends/auto.py", line 30, in connect_tcp
return await self._backend.connect_tcp(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/httpcore/_backends/anyio.py", line 114, in connect_tcp
with map_exceptions(exc_map):
File "/usr/local/lib/python3.12/contextlib.py", line 158, in exit
self.gen.throw(value)
File "/usr/local/lib/python3.12/site-packages/httpcore/_exceptions.py", line 14, in map_exceptions
raise to_exc(exc) from exc
httpcore.ConnectTimeout
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 604, in async_setup
result = await component.async_setup_entry(hass, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/gardena_smart_system/init.py", line 49, in async_setup_entry
await gardena_system.start()
File "/config/custom_components/gardena_smart_system/init.py", line 85, in start
await self.smart_system.authenticate()
File "/usr/local/lib/python3.12/site-packages/gardena/smart_system.py", line 80, in authenticate
self.token_manager.load_from_oauth2_token(await self.client.fetch_token(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/authlib/integrations/httpx_client/oauth2_client.py", line 125, in _fetch_token
resp = await self.post(
^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/httpx/_client.py", line 1892, in post
return await self.request(
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/authlib/integrations/httpx_client/oauth2_client.py", line 90, in request
return await super().request(
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/httpx/_client.py", line 1574, in request
return await self.send(request, auth=auth, follow_redirects=follow_redirects)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/httpx/_client.py", line 1661, in send
response = await self._send_handling_auth(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/httpx/_client.py", line 1689, in _send_handling_auth
response = await self._send_handling_redirects(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/httpx/_client.py", line 1726, in _send_handling_redirects
response = await self._send_single_request(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/httpx/_client.py", line 1763, in _send_single_request
response = await transport.handle_async_request(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/httpx/_transports/default.py", line 372, in handle_async_request
with map_httpcore_exceptions():
File "/usr/local/lib/python3.12/contextlib.py", line 158, in exit
self.gen.throw(value)
File "/usr/local/lib/python3.12/site-packages/httpx/_transports/default.py", line 86, in map_httpcore_exceptions
raise mapped_exc(message) from exc
httpx.ConnectTimeout

Just an update, I removed and reinstalled the device and all worked well again.

It is very strange, the rot cause seems too be "httpx.ConnectTimeout"
I see a network error there, either on gardena side or on your network.
Please tell em if everything works now ?

Yep, all is working again like before

Thanks a lot for the prompt feedback !


Question About Defining Custom Safety Settings in Version 1.12

In your Enums.cs file, I noticed that you’ve defined enumeration types for safety settings. However, it appears there isn’t a straightforward way to specify these safety settings for the model which, from what I can tell, appears to be using the defaults from Google. Does version 1.12 of the your unofficial SDK accommodate customizing the safety settings?

Hi,
You would need to create a request manually to specify the safety settings. e.g.
`csharp
var model = new GenerativeModel(apiKey);
model.GenerateContentAsync(new GenerateContentRequest()
{
Contents = new[] { RequestExtensions.FormatGenerateContentInput("Tell me about terrorism") },
SafetySettings = new[]
{
new SafetySetting()
{
Category = HarmCategory.HARM_CATEGORY_DANGEROUS_CONTENT,
Threshold = HarmBlockThreshold.BLOCK_ONLY_HIGH
}
}
});`
if you have any suggestion to simplify this, I would happily implement it into the library.


Optional"No Upcoming Events" text

Hello,
I was wondering if it's possible to get a toggle for the text to appear when there is an empty_event_list.
There are different ways to implement it ofc, but I think it would be pretty minor.
Looks like after adding the toggle cell, R.string.no_upcoming_events can be set to empty and then everything in the EventAppWidgetProvider would work normally as it does:
        @IdRes int emptyViewId = R.id.empty_event_list;

        rv.setEmptyView(R.id.event_list, emptyViewId);

        rv.setTextViewText(emptyViewId, settings.getContext().getText(

                permissionsGranted ? R.string.no_upcoming_events : R.string.grant_permissions_verbose

        ));

Thanks!

So we have these options now, as I understand:

Display "No upcoming events" / "No events to show" as this is now (since v.3)
Display nothing as I understood @arjunkalburgi   Correct?
Display current day header (even if day headers are turned off), ass suggested in #282

@arjunkalburgi Or I misunderstood what you mean by "toggle for the text"
Since v.3 the Widget layout doesn't have a separate view to show, when there are no events: I simply add a list item that tells this. See screenshots here: https://github.com/plusonelabs/calendar-widget/issues/282#issuecomment-536169071


chore(main): release 0.17.2

:robot: I have created a release beep boop
0.17.2 (2024-12-11)
Bug Fixes

Branch name (#72) (362f954)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.17.2
:sunflower:


Warning for non required components of type enum without default

Refers to #150
So far, it was checked if enum valued components have a possible initial (ABAP) value, are required or have a default. If not, we wrote a warning.
Now, having an initial value is not enough anymore.

I like that the JSON Schema tells the default value. I just wonder what this change means to (all) JSON Schema/Interface types from the AFF repository. Do we need to update all AFF type definitions an JSON Schema?

I checked the type that are actually in the AFF repository and created this issue https://github.com/SAP/abap-file-formats/issues/396. There are all types listed that need an adaption.

LGTM. Changes in AFF are compatible, so let's improve this


feat(Pointer): Customized compound teleport

VRTK_SimplePointer: get the material from customPointerCursor to be set
on all the objects composing the pointerTip.
CurveGenerator: using a custom tracer the first segment must be
displayed, otherwise the curve seems to start in the air and not emitted
by the controller.
VRTK_BezierPointer: Define a custom teleport pointer composed by two
different types of game objects.
A set of objects is like the previous custom pointer, with the materials
changed when the destination is allowed or not.
Another game object (e.g. teleport beam) can be defined to appear only
if the teleport is allowed (its material will not be changed ).
Custom teleport tracer in VRTK_BezierPointer: rescale each pointer
tracer element according to the length of the Bezier curve.
Add member rescalePointerTracer both in VRTK_BezierPointer and
CurveGenerator, add an extra parameter in CurveGenerator.Create()
(default=false).
Add example scene  and related resources.
Add as prefabs (with their related 3D models and textures) a custom
teleport pointer, a custom pointer tracer and a custom object to be
attached as teleport beam.
Add a new example scene 036_Controller_CustomCompoundPointer.unity to
test the new teleport features.

Some screenshots from the example added within this branch:

That looks swish! When I get back from my vacation I'll test this out and hopefully merge it!

Looks as if a bunch of materials haven't been set or included when I open this (in unity 5.3.5f)

I see a lot of comments now, I will go through through each of them
answering your questions and fixing bugs, sorry.
Thank you for your review.
StoneFox wrote:

Looks as if a bunch of materials haven't been set or included when I
open this (in unity 5.3.5f)
image
https://cloud.githubusercontent.com/assets/1029673/17269388/b07f58c8-563e-11e6-9434-1cc47105ca26.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thestonefox/SteamVR_Unity_Toolkit/pull/302#issuecomment-236355086,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATW1qbKvtLF7_szNWwG0OiGlsdDAtfAvks5qaxZ_gaJpZM4JUFH6.

I committed my changes, now I am going to merge the master branch to my branch in order to test my changes with the last version.
What shall I do after? Shall I create a new pull request or whatever?

Don't merge the master branch.
Once you've sorted it and got it working on your branch (the branch for this PR) just do a force push back to your branch, it will update this PR for you.

I'm in trouble with the conflicts with the current version of VRTK, because of those changes in your commit: "fix(Pointer): ensure pointer is cleaned up correctly on disable". I hope I will get everything working again, and finally rebase my branch on the last version on master.

I think we should get the other PR merged in, let's try get that done today then you can just have that change prior to this PR and you won't need the code duplicated in this PR.

Finally I succeded to rebase, but I cannot squash my commit into a single one (probably because I already pushed these commits to my repository), anyway now I think this branch is ready to be pulled.

i think i may be able to squash your commits when I merge (it's a feature github offers, i'll try it when ready to merge)

There are quite a few conflicting issues with the commits :( bringing in old code that was changed, even bringing back large chunks of the readme that were moved.
I think it may be worth just starting on a fresh version of the master branch and migrating the relevant files over.
I can do it if you want, looks straight forward enough to do?
Would be my name on the PR though and not yours, you may want the accolade for this awesome work :)

Definitely I need my name on this branch (the same holds for future PR, I had to prove to my employer I worked on it...). I can open a new PR (only in this case) and add a reference to this. In future I hope I will be more effective in requesting a pull. Your opinion?

sure no worries, i'll await your new pull request :)
lemme know if you need any help

OK, I made a new PR #345 and added some updated screenshots (the tracer beam here changes color, not as in the old images). I don't think it is neccessary to add also a link to this PR that will be closed (or deleted?) soon.
I hope now you can merge it. Thank you for your collaboration.
Anyway I learnt some useful lessons about Git:

do not push before squashing commits
always check remote repository before rebasing to master
do not rebase while editing commit messages (do it in 2 steps)
maybe still a lot to learn about Git...

Superseded with https://github.com/thestonefox/SteamVR_Unity_Toolkit/pull/345


$sendMessage is bugged

i am getting this error for some reason

@Just-Mohamed the usage of $sendMessage is $sendMessage[message;return message id (yes or no)] none of the fields are optional

@Just-Mohamed the usage of $sendMessage is $sendMessage[message;return message id (yes or no)] none of the fields are optional

dev branch has optional field system
@soudblox

New commit in dev branch should fix the issue.


DynamoDB indexes not being removed on amplify push rollback

Describe the bug
Not exactly sure how I got to the point where a rollback happened, but I did. After that I went into a loop of rollbacks until I realized the root of the problem.
After my initial rollback the DynamoDB tables where deleted. My theory is that I did a push in CLI and later I committed code to Git which triggered a Console automatic deployment/push but I did not commit the schema.graphql so it removed my tables (this should not happen when the Console is deploying maybe or we should have the chance to protect tables?).
Anyways, in the following attempts to push using CLI, I noticed in the flow of errors that it was trying to create an index to a new schema on an existing table (this table was in my schema since project day 1 and was doing a named connection to the new table, hence the automatically created index). When I looked at the DynamoDB browser console, the index was there, even after the rollback completed. This also happened on another table so it was not a single bird.
So once a situation happens and Amplify ends up doing rollback, Amplify fails to clean up to a clean rollback state, which then blocks future pushes even if the original problem is corrected. Manually deleting the index(es) solves the problem.
To Reproduce
Not exactly sure what's the simplest way to reproduce but it should be easy to confirm that DynamoDB indexes are not deleted on rollback.
Expected behavior
Amplify should in the best case delete the indexes on rollback, to prevent this from becoming blocking on the next push. In addition, an attempt to create an index should maybe not be blocking but only a warning so it does not result in a rollback.
Additional context
I'm using Amplify CLI 3.0.0 in both CLI and Console.

@houmark thank you for reporting this issue. This is the limitation that cloud formation has when dealing with DynamoDB as documented

Global secondary indexes to be created on the table. You can create up to 20 global secondary indexes.

Important

If you update a table to include a new global secondary index, AWS CloudFormation initiates the index creation and then proceeds with the stack update. AWS CloudFormation doesn't wait for the index to complete creation because the backfilling phase can take a long time, depending on the size of the table. You can't use the index or update the table until the index's status is ACTIVE. You can track its status by using the DynamoDB DescribeTable command.

If you add or delete an index during an update, we recommend that you don't update any other resources. If your stack fails to update and is rolled back while adding a new index, you must manually delete the index.

We are brainstorming how best we can handle this from Amplify CLIs side. We have a couple of ideas how we should handle this

If the rollback happens, show an error message and asking users if they want to delete the newly created indexes
Before doing a push, check if the GSI is present from previous deployment and then remove it.

We still need to investigate if there are any other side effects of doing either of this, but I have added this into our backlog and will get it prioritized .

Yes, I think 1 and 2 both apply here.
AN UPPERCASE RED message at the end of the rollback would at least notify me to go and delete the indexes manually (I guess it knows which indexes it created, so it could point me pretty deep to the index). If that can even result in a prompt in the CLI which gives me the option to safely delete the exact indexes, then that's even better.
And doing an index comparison before push to see if this push would create indexes that conflicts, bail out and warn to the user. That at least is much faster to correct for me as a dev, than to wait for minutes before it fails, starts rolling back, and then that takes another 5-10 mins. I guess this could solve other edge cases where this happens due to other reasons (for example if I created an index manually with the same name).

@houmark We have a sanity check in place right now which runs before amplify push- exactly as you've mentioned above to prevent this issue. We have in our backlog to make this experience between by queueing DDB deployments in a scenario like yours.


Add Docker Support and Hide Completed TV Shows

Feel free to immediately decline this PR but I added a feature I wanted which is a button that allows you to see only TV Shows that have not been completed - this is kind of like a Watchlist for TV Shows only and works with how I want to use the app.
I have not written any tests and have zero PHP experience but I would be willing to write them if you are interested in incorporating the feature (I've started using it and will fix any bugs I see).
Also with regards to the Dockerfile and TrustedProxies, I can take them out if you aren't comfortable with them, right now the container runs PHP via Nginx but does not have the Redis cache (mostly because I have no way of knowing if its working or not simply due to my lack of PHP knowledge).
Lastly, I fixed a small bug where the z-index of all-filters was below item-actions and looked weird, especially when on mobile.

Sorry for the much too late reply. Thanks a lot for taking the trouble.
But i will close the PR, for the simple reason that I will completely redevelop Flox. But I will add the possibility to hide finished shows :)

All good! Thanks for the project, I can't wait to see what you have in store!


Added .DS_Store for Mac operating system!

Reasons for making this change:
.DS_Store files are useless and annoying so I am preventing them from being committed!

It would be better to setup a global gitignore with macOS.gitignore to ignore all macOS related files all together.


Implemented Fluid navbar features

Implemented several Fluid-specific features of the navbar, including:

Products dropdown menu
Nav item dropdown menu
Nav item child items
Status indicators

Also, introduced the $size-base variable to have a more appropriate variable to use for general size settings that are not font related (but it has the same value as $font-size-base).

I wanted to add some additional comments to clarify the thinking behind the base font size, $font-size-base, and $size-base.
The base font size is whatever the font size of the <html> element is set to. In our case, it is 14px, as this is the default font size specified by Fluid. By setting this, everything in Bootstrap that uses rem units directly will be scaled to the Fluid base font size. However, it would be much nicer to have a $font-size-base that we can use to derive other font sizes from using relatively simple multipliers. If we set $font-size-base to 10px, then we can use multipliers that directly tell you how many pixels you are calculating, for example: $font-size-base * 1.6 = 16px.
However, we cannot specify $font-size-base in pixels directly because Bootstrap uses it in calculations with rem units, and so px will break those calculations. Therefore, we must get 10px in rems. So, we set the font size of the root element to 14px and then calculate $font-size-base as .714285714285714rem, which equals 10px. From this, we set the <body> font size to 14px using $font-size-base * 1.4, so that the default (inherited) font size is 14px, per the Fluid spec.
Furthermore, the goal for Bootstrap in general is to use rems wherever possible, rather than px. So, we would like to be able to specify all sorts of sizes in our CSS using $font-size-base, because it makes it really simple to do the pixels to rems conversion. But the variable name $font-size-base makes it inappropriate to use for setting sizes not related to fonts. What we really need is a general $size-base. We can then set $font-size-base = $size-base as a starting point, but if we ever want to change one of them in the future, we know that $font-size-base will only affect font sizes and $size-base will affect everything else.
There is a final concern that changing the value of $font-size-base to something different from the actual base font size on the <html> element will affect some of the original Bootstrap styles that used $font-size-base and assumed that it was equal to the actual base font size. So, I have already gone through Bootstrap and found all the places where $font-size-base was used and fixed the calculations so that they produce the right sizes relative to the actual 14px base font size.
Also, while writing this, I realized that we could just as well set $size-base to the rem equivalent of 1px and then use formulas like $font-size-base * 16 = 16px, which might be even better. :)

In a comment that I have now hidden, I fully explained the reasoning behind the sizing variables used in this pull request. However, while writing that explanation, I realized there is an even better way to accomplish the goal of a simple sizing API for this theme. In my next PR, I have implemented a Sass function to perform all pixel to rem conversions. That allows us to set the $font-size-base back to 1rem and return all previously altered Bootstrap variables back to their defaults. See the next PR for details.


Refactoring ENUMs

In the original suggestion,
https://github.com/SAP/abap-file-formats/issues/92#issuecomment-841975386
the ABAP code has access to both the internal and external values.
This is not the case right now, https://github.com/SAP/abap-file-formats/blob/main/file-formats/typesUsedForAll/zif_aff_types_v1.intf.abap#L9
I have not looked at how to do serialization to and from ABAP file formats yet, but expect this to give problems

Let's take the following example:
https://github.com/SAP/abap-file-formats/blob/b569b7b519e4b6b93aa2920cbcc522a8730f8550/file-formats/intf/type/zif_aff_intf_v1.intf.abap#L11-L33
I understand it the following way:

Internal values (e.g., which are stored in the database) are the values of the constants.
Example: The internal for BAdI definitions is value is 01
External values are derived from the constant name by creating camelCase values.
Example: The internal value for BAdI definitions (field badi_dafinition) is badiDefinition

Do I miss anything? Wouldn't this be sufficient.
If it is sufficient, most probably, specification has to be adapted to describe this behavior.

ah, I did not remember, also see #61


regenerate syntax

 if self.regen_cbz_checkbox.isChecked():
            commands += " --regenerate-cbz"

the above is not a valid command:

nhentai: error: no such option: --regenerate-cbz

Was the intention here to use "regenerate" or "--cbz" options? Or perhaps the options have changed since this was written.
 -C, --cbz             generate Comic Book CBZ File
 --regenerate          regenerate the cbz or pdf file if exists

This was just changed in 0.5.8 I didn't see it, I'll fix it and add the new --artist command as well.

Fixed in (7cf2e73)


Copy selected/all from list to clipboard

A user should be able to interact with the batch list in the same way they would an excel table. They should be able to use control and shift to highlight the entries they are interested in. When they right click they should be given the  options to copy all and copy selected. This will allow the users to take these into other applications or text files.

Currently there is a delete and delete all option; however, there is no copy or copy all feature.

@topowright This is now available in PR #339

@kgonzago Going to kick this one back.  Part of the requirements was the ability to "interact with the batch list in the same way they would an excel table."
We are still missing the ability to:

[ ]  Select multiple items in the list using the control and shift keys.
[ ]  Right clicking should not include the "delete all" option.(we have a clear all button at the bottom)
[ ]  Selecting multiple items, right click wording should be  "delete selected" instead of "delete all".

fyi @dfoll

The delete all option needs to come off the right click option.

there is one thing still missing on this issue, pretty minor in my opinion

[ ] do not need a "Delete all" in the right-click menu, there is a clear all button on the bottom (still need the delete button though

Copy functionality has been implemented, we currently have "Copy all" and "Copy" .... "Copy all" copies all coordinates from the list (this is what we want). "Copy" copies the selected values (also what I would expect)

Closing this issue as designed.


Support different railway values

Currently only railway=rail is supported. This PR adds support for configuring different allowed railway= values, e.g. tram, light_rail etc.
Also fixes some small bugs and normalizes indentation.

Thank you for your contribution.


Session not stored or properly handled in local Memory Store

Sails version: ~0.12.2
Node version: 7.0.0
NPM version: 3.10.8
Operating system: macOS Sierra

Posted on StackOverflow too...
I am building a react (ES6) application with Webpack in SailsJS.
The problem I came across is that session is not properly handled or stored in Local Memory Store IF the action is triggered from the frontend
Setup:
// TestAPIController:
module.exports = {
  create: function(req, res){
    // TODO: Add user authentication piece
    var user = {name: 'test user'};
    req.session.user = user.name;
    req.session.authenticated = true;
    console.log('session:', req.session);
    // req.session.save();
    res.json(req.session);
  },
  echo: function(req, res){
    console.log('session:', req.session);
    return res.json({message:'got it'});
  }
};

Policy:
TestAPIController: {
  echo : 'sessionAuth'
}

Route:
'GET /TestAPI/create' : {
  controller: 'TestAPIController',
  action:'create'
},
'GET /TestAPI/echo' : {
  controller: 'TestAPIController',
  action:'echo'
},

Front End
onClickCreate(e){
  fetch('/TestAPI/create').then( res => res.json());
}

onClickEcho(e){
  fetch('/TestAPI/echo').then(res => res.json());
}

MarkUp

Create Test

Echo Test

Senario A
Click on Create, and here is the Console Log: [CORRECT!]
Requested ::  GET /TestAPI/create
session: Session {
  cookie:
   { path: '/',
     _expires: 2017-01-18T20:21:01.069Z,
     originalMaxAge: 86400000,
     httpOnly: true },
  user: 'test user',
  authenticated: true }

And Then click on Echo, Console Log: [WRONG!]
Requested ::  GET /TestAPI/echo
verbose: Sending 403 ("Forbidden") response:
 You are not permitted to perform this action.

Senario B
Now type in http://localhost:3000/TestAPI/create in browser's address bar hit enter
Browser prints the return from the call. and Log in verbose log:
Requested ::  GET /TestAPI/create
session: Session {
  cookie:
   { path: '/',
     _expires: 2017-01-18T20:21:13.645Z,
     originalMaxAge: 86400000,
     httpOnly: true },
  user: 'test user',
  authenticated: true }

And then enter http://localhost:3000/TestAPI/echo
Browser prints the return from the call [CORRECT!]
Requested ::  GET /TestAPI/echo
session: Session {
  cookie:
   { path: '/',
     _expires: 2017-01-18T20:25:24.019Z,
     originalMaxAge: 86400000,
     httpOnly: true },
  user: 'test user',
  authenticated: true }

Maybe there is some fundamental principle I'm not following?
Or maybe there is a better way to control sessions?
Any help would be appreciated.
P.S. the framework setup is very close to this repo

ok, fixed!

hey @Voxis this issue is not about Sails, is about how the fetch method works.
Fetch does not use cookie by default, try this:
fetch(url, {
  credentials: "same-origin"
}).then(...).catch(...);

And if are working with cross-origin requests -> credentials: 'include'

@Josebaseba That really helped me. Thanks man.
BTW to make it easier, I found this wrapper file in https://github.com/github/fetch/issues/319


MD file error

I found something wrong in the document.
NSAttributedString extensions    link  to nothing
UIAlertController extensions  link to NSAttributedString extensions

@wudijimao fixed, thank you!