[WIP] allow tickets to be viewed and replied to via secret url

This PR adds "codes" to topics, so that tickets may be viewed and replied to via a secret URL.
The desire for this change comes from a need to make "email" an optional field for creating a new ticket when not authenticated (we don't want to require an email address when asking questions of an email provider).
I don't know if something like this would be welcome in helpy, but if so, then here is one possible solution. This current PR is not particularly clean, but I am pushing it here to stimulate a conversation.
The approach taken here is to use a random string for the user.email field if email is missing, since there is an index on the email column that requires an unique value.
The disadvantage of this is that a new user is created for every anonymous ticket, and that new user is never destroyed. Before, when email was required, when the same person created a second ticket, the email address could be used to fetch the existing user object to associate with the new ticket.
This is not really a problem, but it does suggest that it would be good to create scripts to clean out old users and old closed private topics.

Hey @elijh thanks for contributing this!  Sorry for the delay getting to review this, I have been completely backed up on another project.
This has been an interesting problem that we have discussed before- #69 and in other places.  I like the secret URL approach because it lets users check their ticket without logging in.  What if we provided a way for users to "claim" their user account by providing a path from the secret url... ie- prompt them to enter their email and then remove the access via secret code?


Can't assign a drive letter or mount point

Trying to mount as an NTFS folder but I'm getting the error per the title.
If I use a drive letter e.g. M the mount occurs without error.
Tried the mount.exe sample application that comes with Dokan, but it also throw error "Cant assign a drive letter" when a directory is specified.
Running on Windows 10.0.018362
Ideas ?

Hi @ordinaryorange ,
How does your mount path / options looks like ?

Tests with mount.exe from Dokan installer ("mount" directory confirmed as not present on machine before execution)
mirror /r c:\users /l c:\mount
mirror /r c:\users\ /l c:\mount
mirror /r c:\users /l c:\mount\
mirror /r c:\users\ /l c:\mount\

All the above fail with the error "Cant assign a drive letter"
This works
mirror /r c:\users /l x:
Also tried with the DokanNetMirror sample, changing only lines 23 and 27
The stdout produces

Using unsafe methods: False
04/07/2020 10:57:16 - [DokanNet] GetVolumeInformationProxy:
04/07/2020 10:57:16 - [DokanNet]        Context {, False, False, False, False, #4, False, False}
04/07/2020 10:57:16 - [Mirror] GetVolumeInformation('', {, False, False, False, False, #4, False, False}, out DOKAN, out CaseSensitiveSearch, CasePreservedNames, UnicodeOnDisk, PersistentAcls, SupportsRemoteStorage, out NTFS) -> Success
04/07/2020 10:57:16 - [DokanNet]        VolumeNameBuffer        DOKAN
04/07/2020 10:57:16 - [DokanNet]        FileSystemNameBuffer    NTFS
04/07/2020 10:57:17 - [DokanNet]        VolumeSerialNumber      4094363
04/07/2020 10:57:17 - [DokanNet]        FileSystemFlags CaseSensitiveSearch, CasePreservedNames, UnicodeOnDisk, PersistentAcls, SupportsRemoteStorage
04/07/2020 10:57:17 - [DokanNet]        MaximumComponentLength  256
04/07/2020 10:57:17 - [DokanNet] GetVolumeInformationProxy Return : Success
Error: Can't assign a drive letter or mount point

@ordinaryorange Let's try to make it work with the C mirror first. Can you provide the output if mirror.exe /r C:\users /l C:\mount /d /s?
Be sure the mount folder already exist and the user running the command has access to it.

Hi @Liryna, problem solved. Issue was me.
I had made the assumption that the mount path should not exist, and that Dokan would create it. But your last comment indicates that the mount folder should exist.
When I created the c:\mount folder and then ran Dokan, it all worked perfectly.
Thank you for you assistance.


The download link for   mit_hybrid_vsad.mat is broken.

The download link for mit_hybrid_vsad.mat is broken. Could you fix it please？

The link has been fixed.

Thanks!


Needs to restart dev server to apply changes from the schema on iframe based preview

Description
Using the new iframe based preview the fields are not updated in realtime on the Admin UI when changing the schema from files imported outside of the .tina directory.
Steps to reproduce

Make config.ts based on new iframe based previews.
Make a change to the schema on the config.ts file directly
Changes should be applied
Import a file from outside the .tina directory
Changes are not applied to the Admin UI

Expected result
What should happen?
The dev server should watch for all imports on the config.ts
Actual result
The dev server is not restarted
What actually happened?
No changes in the UI until restarting the server
Environment
Tinacms Package Versions

├──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ ├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>

Tools

Tool
Version

browser
Firefox 106.0.1

os
MacOS Monterey 12.0.1

node
v14.18.0

npm
6.14.15

This should probably be an "enhancement" instead of a "bug"

@brvnonascimento Any objects to renaming this "CLI server should watch all imported files" ?

Done!


Always on top option for mini player

Add a option to keep mini player always on top

duplicate of https://github.com/Venipa/ytmdesktop2/issues/78


Feature request: provide way to acquire latest, stable 2.1 Windows/macOS bits

Is your feature request related to a problem? Please describe.
Starting in .NET Core 2.1, the .deb/.rpm acquisition experience changed. Linux users can now reference dotnet-sdk-2.1 and dotnet-runtime-2.1. This makes it easy to upgrade by just running apt upgrade. There is no way to get the equivalent behavior on Windows and macOS
Describe the solution you'd like
I'd like a way to be able to get the latest, stable 2.1 runtime and SDK. I'm not concerned about floating the patch version.
Describe alternatives you've considered

Update dotnet-install.ps1 to support a "2.1" stable channel.
Use a stable link that I can curl/wget from such as https://aka.ms/dotnet/2.1/dotnet-runtime-2.1-win-x64.{exe,zip}

Additional context
https://github.com/travis-ci/travis-build/pull/1397#issuecomment-393988234

Moving to core-setup

Issue moved to dotnet/core-setup #4187 via ZenHub


feat: initial verion of the quarkus picker

This PR was deployed with mocked data in the following URLs for your appreciation:

Frontend: https://fabric8-launcher-frontend-pr-1304-app.surge.sh
Welcome App: https://fabric8-launcher-frontend-pr-1304-welcome-app.surge.sh
Storybook: https://fabric8-launcher-frontend-pr-1304-storybook.surge.sh


Bump ghost version to 5.50.4

v5.50.4  was released in the meantime. https://github.com/TryGhost/Ghost/releases/tag/v5.50.4
It's 5.50 with the bugfixing and no new features.
I believe this package should exist. Later, I'll also propose 5.51

Doh, looks like the automated update has been failing since https://github.com/docker-library/official-images/pull/14779 thanks to our Alpine 3.16 base image no longer being supported :see_no_evil:

Doh, looks like the automated update has been failing since docker-library/official-images#14779 thanks to our Alpine 3.16 base image no longer being supported 🙈
Edit: #385 🤦

Oh! So that's what it's about.
Any way I can help speeding up the process?

Your prod was very helpful, thanks!  See https://github.com/docker-library/official-images/pull/14834 :+1:


Add more golem actions

New Actions
fail(message) : mark the test as failure, stop, jump to teardown
error(message) : add an error to the test, the test should continue, will be marked as error at the end
verify_url(url) : verify the current url
verify_url_contains(url_substring) : verify the current url contains the url_substring passed as argument
get_current_url() : returns the current url
tab management (open tab, close tab, get current tabs, switch to tab)
alerts (verify alert is present, verify alert text, close alert)
verify_window_title
verify_window_title_contains
scroll
IFrame (switch to IFrame)
get_element_text(element) : returns the text of an element
Current Actions Refactor
capture() : rename to screenshot()
verify_text_in_element(element, text) : rename to verify_element_text(element, text)

Can we also request some actions in this issue ? I would like to have the following:
get_text: returns the text of an element

Sure, go ahead!
Since this is a standalone function and not a webelement method get_element_text would be best

I'm pretty new at Golem and probably this feature is already implemented, but I didn't figure it out, but just in case it's not: a function to close a specific tab would be very useful.

@IvanPenev92  This feature is already planned to be implemented in the description above (Tab management)


check trainerfn == FITTING before configuring sync_batchnorm

What does this PR do?

Fixes #9243
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Would like some help debugging why the "TPU-tests" CI is failing. I've glanced over the logs, but haven't found anything that would indicate that this PR is related. Thanks!

Would like some help debugging why the "TPU-tests" CI is failing. I've glanced over the logs, but haven't found anything that would indicate that this PR is related. Thanks!

Let me take a stab!

Thank you for the patience


[17.06] backport networkdb fixes

Backport fixes to bump_17.06.0 branch:

#1860 Network db stabilization
#1836 NetworkDB incorrect number of entries in networkNodes

The commit 297c3d4 taken from #1836 is needed to make the cherry pick go in clean.
Cherry picked commits 297c3d4 bede778 4cf74e8 26db0b9:
$ git cherry-pick -s -x 297c3d4 bede778 4cf74e8 26db0b9

@fcrisciani @mavenugo PTAL

LGTM


Artemis: cb: Support switch error event

Description

Support switch CCR cyctem error event.
Support ACCL card power good fail event.

Motivation

Support switch CCR cyctem error event.
Support ACCL card power good fail event.

Check switch CCR cyctem error event ......
0    all      2018-03-09 06:27:45    pldmd            Device type: CB_PESW_0 (0x11), board info: MAIN_SOURCE (0x0), event type: SYSTEM_ERROR (0x6) Assert event
0    all      2018-03-09 06:27:45    pldmd            Device type: CB_PESW_0 (0x11), board info: MAIN_SOURCE (0x0), event type: PEX_FATAL_ERROR (0x7) Assert event
0    all      2018-03-09 06:27:45    pldmd            Device type: CB_PESW_1 (0x12), board info: MAIN_SOURCE (0x0), event type: POR_BISR_TIMEOUT (0x8) Assert event
0    all      2018-03-09 06:27:46    pldmd            Device type: CB_PESW_1 (0x12), board info: MAIN_SOURCE (0x0), event type: FLASH_SIGNATURE_FAIL (0x9) Assert event
......

Hi @williamspatrick ,
We rebase main and force update this branch.
Please help to review it again, thank you.


Fixes

create 5letters.txt from the todo list using grep (command line in commit comment)
fix whitespace per PEP
fix a non-idiomatic "while" condition
fix typo = vs == in "if" condition

No grep on my system (Win10) but these all look fine. Doable with grep and lots of other tools, but doing it programmatically & internally gives us the tools to trim & shape rules (valid words) from within the repo regardless of platform.


Contract method not generated in Pharo 7

Since Pharo 7.0, contract methods are not automaticaly generated anymore. Probably a problem with Traits in Pharo 7.0 with Pragma.
Temporary solution :
Use MolComponentFactory defineComponent: YourComponentImpl for generate your contract methods from required Traits.

MolComponentFactory >> defineComponent: is called when a method with <componentContract>  is updated.
First, the PragmaCollector which is listening <componentContract>  is initialized with a MolComponentFactory. We have to instanciate it to initialize the pragma. It has been corrected.
Then, when you create your component implementation by adding a subclass of MolAbstractComponentImpl or using MolComponentImpl trait, none of <componentContract> methods (of your ComponentType trait) is updated. So the method MolComponentFactory >> defineComponent: is not called.
We have to continue to use MolComponentFactory >> defineComponent:...


Composer with Lumen

When installing Lumen, issues arise with file permissions in ~/.composer/vendor/laravel/lumen-installer throwing Permission denied in  ~/.composer/vendor/laravel/lumen-installer/src/NewCommand.php. Not sure if a problem in Lumen, or something that needs to be solved in php7dev.

My mistake, wrong file permissions in the /var/www/default folder.


Fix L1 instruction and OP cache mixup in the Zen 4 Instruction Fetch view.

Disabling the OP cache now shows 0% for Op$ Hitrate instead of L1i Hitrate.
Before:

After:

The "Op$ Ops" field value also seems suspect, but it's not clear what the fix is. The values shown are very different from the "Op Cache Ops" field from the "Loop Buffer" view. Switching this from counterData.ctr5 (L2 iTLB miss (page walk)) to counterData.ctr0 (OC Access) still shows disagreement with the "Loop Buffer" view.

Thanks for catching this! While looking over it I also noticed I left the oc ops field in there when I intended to move that to the "Loop Buffer" view. Also renamed "Loop Buffer" to "Ops from Frontend". I originally created that to work out Zen 4's loop buffer size, but it really gives an overview of where the frontend is sourcing its ops.
Fixed with a couple of commits


[Removal]:

Hotspot Name
DIZZY CLAY BEAR - FESTIVE SNOWY SAWFISH - HIDDEN JUNIPER FOX - FANTASTIC FUZZY SWAN - FANTASTIC FUZZY SWAN - HUGE FUZZY TROUT - QUICK BASIL CRAB - UPBEAT BRONZE SARDINE - JOVIAL SAFFRON CORGI - RECUMBENT SATIN ANT - CHEERFUL WOOL SNAIL - AMUSING FLINT MOTH - PRECISE LATTE PELICAN
Hotspot b58 Address
112McwESVc22K4yVBZjvcyx8dyGXZRRm9ncVQmkANMbusaYBaHSj - 112EMZ1dNj3xCoE1FX91Zc4YDwEmLUQhsvbJpEHn1TaDanqimyuA - 112LHBaZdzEq8wd4AwcEVzPRFKpkvfMkZQKgN5NydXgtjmGDsEHQ - 11fyPnNwe5m4c44nzBmS27fBQp8DTV5JpQBeo8owUhQng2jwTEw  - 112w6md5P9xxvUQcHRXHPhkkPB7Pjuk3Z4LaYD2iPyYUWwKm3X5E - 11GAde4bBwSX2mijyQSxZFrTR82pvtHMkQVcsP1EdzTJ1DCa2se  - 112mo2Dk9JNLiQoDoCu7byevd2PKXzRvS22unpDj2uSwmbnbwdQL - 112WK7rYKZWGw7SWd5SMr87aam7BNyB4M22SkUrZmG1tPCY7cEzn - 1125SKitCBdVzAC69zgcHwatKykXB49PUjsok4pEwEW2C1MqrASe - 11fqV53LobPvU1m4VZfBcVsXgpN4tRQjBLbBjzSVTtNGEs3y8nQ - 112Gfqu7KXJp3UcrdgQQuXzQaZ77qJuJLdZqvCR2dK3D7ZEQK3wN - 112s6PeVSqDK2dMz3TmfdVohnvC9Uwg9ATCBJUMLCAvKNY4PWKcs- 11gNVQmZ29tWgmAMvamAcrPSukonpDqM4h7X6o6XNjbngK7wwWp
Discord Handle
No response
Hotspot Manufacturer
Sensecap
Removal Reason
These hot spots are installed in the correct location, all hot spots in our town have been added to the banned list, please help me remove them, thank you.
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
Hi, they put my access points on the denylist, all my access points are installed in the correct locations. I would like to know how to remove them from the denylist.
Greetings and thank you very much

Without any proof like photos there is probably not much that can be done.

Good morning.
Thank you very much for your quick reply.
I'm not very clear about that from the photos.
Do I have to send the photos of the equipment and something else?
In Helium explorer I can send the screenshots of the witiness, of the other
HotSpots installed in the area.
Please tell me what you need so I can prepare everything to be able to
remove the Hotspots from the denylist
Best Regarda
El El dom, 21 ago 2022 a las 13:07, Gratje V. @.***>
escribió:

Without any proof like photos there is probably not much that can be done.
—
Reply to this email directly, view it on GitHub
https://github.com/helium/denylist/issues/7319#issuecomment-1221523489,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZNVWHLHFJY5O3IA4EWXPGTV2IEXPANCNFSM57EXP5AQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Un Saludo
Christian Fabio

34 681135183

Take an example at.
https://github.com/helium/denylist/issues/7320

@NegoLouco Do these account belong to you?
if not, why are you transferring HNT to these account?
Pool and transit accounts:
1)13upiKWUpsAecvuewbWKKdwTjZoimmT95C3gm82ZfTQ4dZ7DMn4
Take a look at the accounts that transfer HNT to this account. Most of them have established HS clusters in Spain and are in the denylist.


Implement cache remember

Each pull request should address a single issue and have a meaningful title.
Description
Explain what you have changed, and why.
Checklist:

[ ] Securely signed commits
[ ] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[ ] Conforms to style guide

---------Remove from here down in your description----------
Notes

Pull requests must be in English
If the PR solves an issue, reference it with a suitable verb and the issue number
(e.g. fixes 12345)
Unsolicited pull requests will be considered, but there is no guarantee of acceptance
Pull requests should be from a feature branch in the contributor's fork of the repository
to the develop branch of the project repository

Pull Request Test Coverage Report for Build 487768816

17 of 31 (54.84%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 83.154%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

system/Cache/Handlers/FileHandler.php
4
5
80.0%

system/Cache/Handlers/MemcachedHandler.php
4
5
80.0%

system/Cache/Handlers/PredisHandler.php
4
5
80.0%

system/Cache/Handlers/RedisHandler.php
4
5
80.0%

system/Cache/Handlers/WincacheHandler.php
0
5
0.0%

system/Test/Mock/MockCache.php
0
5
0.0%

Totals

Change from base Build 486905817:
-0.06%

Covered Lines:
12804

Relevant Lines:
15398

💛  - Coveralls

Pull Request Test Coverage Report for Build 487768816

17 of 31 (54.84%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 83.154%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

system/Cache/Handlers/FileHandler.php
4
5
80.0%

system/Cache/Handlers/MemcachedHandler.php
4
5
80.0%

system/Cache/Handlers/PredisHandler.php
4
5
80.0%

system/Cache/Handlers/RedisHandler.php
4
5
80.0%

system/Cache/Handlers/WincacheHandler.php
0
5
0.0%

system/Test/Mock/MockCache.php
0
5
0.0%

Totals

Change from base Build 486905817:
-0.06%

Covered Lines:
12804

Relevant Lines:
15398

💛  - Coveralls


Delete Fourier-Doubling.py for Moving

Commit after moving the file to the actual location. Thanks .


Fix playButton not triggering when clicking on playButtonIcon

This pull request fixes the playPause event not triggering when clicking on playButtonIcon.
https://user-images.githubusercontent.com/33200113/160168128-dede3fd8-e69d-4ae2-8f5d-6d198679234e.mp4
Please do give feedback! This is my first ever code PR on github.

Great job man


Fix compatibility with react 15

[x] Compare with 0.14.7 https://github.com/facebook/react/compare/v0.14.7...v15.0.0-rc.1
[x] Fix breaking changes
[x] Port changes to react-dom onto react-three-renderer
[x] Update other npm dependencies
[x] Make all tests pass
[x] Test new version with the examples project
[ ] Cleanup and refactor final bits
[ ] Publish new version

See #49.

Almost done!

Are there still any issues with React 15 or should this be closed?


Components

All the project requirements for the step 2 of the project - Components have been implemented: I have created a directory called components from CRA(text,images,styles).Inside components, created a new Calculator.js file and then created a react component that matches the below design.
Design

HI, as per the feedback given previously to me ,I have used functional components now in the pull request and removed  the unnecessary files of logo.svg


Add support for component template APIs

Description
Adds support for the component template APIs
Issues Resolved
Part of #404
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock @Yury-Fridlyand @VachaShah Could I get a review on this please?

@dblock Had to rebase and fix conflicts, could I get a re-approval please?

@Xtansia Is it not possible to generate these APIs? Or are they already generated?

@VachaShah They're partially generated, the methods on the client class and the parts of the objects defining query parameters are generated (they're under a _Generated path). It's just the req/resp bodies and tests that are hand written at the moment.


[HOLD for 1:1:1] [NewDot Unapprove] Non-admin approvers aren’t able to Unapprove reports on OldDot

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.67-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @garrettmknight
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714131911473989
Action Performed:
Pre-req In OldDot:

User A (ex. c.dobrzyn+123@expensifail.com): create a Collect with Submit & Approve workspace in OldDot
User A: Add User C (ex<EMAIL_ADDRESS>as a member of the workspace (not admin) > Make User C the Submit & Approve workspace approver

Reproduction Steps:

Sign in as User A
Submit a report to Users C
Sign in as User C
Navigate to the report.
Approve the report

Expected Result:
Approver in OldDot who is the "Submit and Approve" Approver should be able to Unapproved reports in OldDot (and NewDot when we add Unapprove).
Actual Result:
Approver in OldDot who is the "Submit and Approve" Approver can't Unapproved reports created in NewDot - they can only approve

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014d67da3ebc3f7c4d
Upwork Job ID:<PHONE_NUMBER>907881472
Last Price Increase: 2024-04-29

testing:
test workspace: Testing NonAdmin approver
Owner<EMAIL_ADDRESS>Admin<EMAIL_ADDRESS>Employee<EMAIL_ADDRESS>(Approver in OldDot)
I can't reproduce when submitting to an employee.. trying to submit to a workspace...

I can't reproduce this, I can't get a report that can be unapproved by anyone in a workspace. I'll keep testing

Okay I narrowed down the steps to reproduce in OP - this is going to be internal so adding our labels!

trying to get some help here - https://expensify.slack.com/archives/C036QM0SLJK/p1715068029301439

posted in BZ to try and get help - https://expensify.slack.com/archives/C01SKUP7QR0/p1715153127360859

asking Tom for some guidance - https://expensify.slack.com/archives/C036QM0SLJK/p1715068029301439

Discussed in Slack, but this seems like a new behavior from what we can tell. Taking over and setting as a New Feature

Adding to https://github.com/Expensify/Expensify/issues/384891

Oh amazing! Thank you @garrettmknight!

Still holding.

Still holding.

Still holding.

Taking this off hold!

Awaiting a volunteer!

Awaiting a volunteer!

To be clear, we also want admins who AREN'T the current approver to be able to unapprove, right? Or no?

I think we do. If it's easiest to do that as part of this bug fix, cool!

I think it makes sense, at least whoever works on this main issue will also probably have to get enough context that they'll easily be able to fix the 2nd part too :D
Should we add Hot Picks & move this to #wave-control?

Grabbing this one

Hmm we currently don't allow Admins (who aren't the approver / "manager") to unapprove, in Auth -> I'll have to update that both for OldDot & NewDot 😅

Huh, kind of wild that you need to be both an admin and the assigned approver, but if that's how it's set then this isn't really a bug I guess. @Beamanator let's not change in OldDot in that case and just handle NewDot in the Unapproved project.

The one thing we miiiiiiiight want to do is allow non-admin managers to unapprove, which we could still do in this issue

I like designing to allow for non-admin approvers to unapproved in NewDot - I'm less passionate about changing OldDot to match if it's not what OldDot was initially coded to do.

Brought the convo to slack

PR in review!

Merged!

Reopening as per this convo

should be on prod!


[CVEs/1.28] Assorted vulnerability fixes

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/wait for changelog update

realizing this PR doesnt need the changelog update - its the release pr that needs it


⚠ Bofrost.de has degraded performance

In b99c806, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1435 ms

Resolved: Bofrost.de performance has improved in ee0f009.


How to properly add automation script to HA Bridge?

Hi, I'm having some problem adding automation script with HA bridge. So far it works fine with switch
Using similar setup to this
https://community.home-assistant.io/t/simple-tv-channel-command-sequencing-broadlink-rf-ir-blaster/14056/9?u=ferbulous
The automation script is listed in homeassistant devices

However, nothing happens when I tried turning it on in ha bridge and broadlink device was not blasting ir signal at the same time.
The configuration is working fine as I can still use ifttt to trigger the channel automation or from the front end

Is there any anything else I need to configure properly with automation script?

Please check your log for errors. Post the log here if there are questions.

Hi, this is the log output

Dec 27 23:35:07 bpi-iot-ros-ai hass[1384]: #033[32m2017-12-27 23:35:07 INFO (MainThread) [homeassistant.components.http] Serving /api/services/switch/turn_on to <IP_ADDRESS> (auth: True)#033[0m
Dec 27 23:35:07 bpi-iot-ros-ai hass[1384]: #033[32m2017-12-27 23:35:07 INFO (MainThread) [homeassistant.core] Bus:Handling <Event call_service[L]: service=turn_on, service_call_id=3047619536-74, service_data=entity_id=switch.fan_speed_2, domain=switch>#033[0m
Dec 27 23:35:07 bpi-iot-ros-ai hass[1384]: #033[32m2017-12-27 23:35:07 INFO (MainThread) [homeassistant.core] Bus:Handling <Event service_executed[L]: service_call_id=3047619536-74>#033[0m
Dec 27 23:35:08 bpi-iot-ros-ai avahi-daemon[367]: Invalid response packet from host <IP_ADDRESS>.
Dec 27 23:35:08 bpi-iot-ros-ai avahi-daemon[367]: Invalid response packet from host <IP_ADDRESS>.
Dec 27 23:35:09 bpi-iot-ros-ai avahi-daemon[367]: Invalid response packet from host <IP_ADDRESS>.
Dec 27 23:35:09 bpi-iot-ros-ai avahi-daemon[367]: Invalid response packet from host <IP_ADDRESS>.
Dec 27 23:35:09 bpi-iot-ros-ai avahi-daemon[367]: Invalid response packet from host <IP_ADDRESS>.
Dec 27 23:35:09 bpi-iot-ros-ai avahi-daemon[367]: Invalid response packet from host <IP_ADDRESS>.
Dec 27 23:35:09 bpi-iot-ros-ai avahi-daemon[367]: Invalid response packet from host <IP_ADDRESS>.
Dec 27 23:36:32 bpi-iot-ros-ai avahi-daemon[367]: Invalid response packet from host <IP_ADDRESS>.
Dec 27 23:36:33 bpi-iot-ros-ai hass[1384]: #033[32m2017-12-27 23:36:33 INFO (MainThread) [homeassistant.components.http] Serving /api/services/automation/turn_on to <IP_ADDRESS> (auth: True)#033[0m
Dec 27 23:36:33 bpi-iot-ros-ai hass[1384]: #033[32m2017-12-27 23:36:33 INFO (MainThread) [homeassistant.core] Bus:Handling <Event call_service[L]: service=turn_on, service_call_id=3047619536-77, service_data=entity_id=automation.maya_hd, domain=automation>#033[0m
Dec 27 23:36:33 bpi-iot-ros-ai hass[1384]: #033[32m2017-12-27 23:36:33 INFO (MainThread) [homeassistant.core] Bus:Handling <Event service_executed[L]: service_call_id=3047619536-77>#033[0m
Dec 27 23:36:33 bpi-iot-ros-ai avahi-daemon[367]: Invalid response packet from host <IP_ADDRESS>.
Dec 27 23:36:33 bpi-iot-ros-ai avahi-daemon[367]: Invalid response packet from host <IP_ADDRESS>.
Dec 27 23:36:34 bpi-iot-ros-ai avahi-daemon[367]: Invalid response packet from host <IP_ADDRESS>.
Dec 27 23:36:34 bpi-iot-ros-ai avahi-daemon[367]: Invalid response packet from host <IP_ADDRESS>.
Dec 27 23:36:34 bpi-iot-ros-ai avahi-daemon[367]: Invalid response packet from host <IP_ADDRESS>.
Dec 27 23:36:35 bpi-iot-ros-ai avahi-daemon[367]: Invalid response packet from host <IP_ADDRESS>.

The first action is for my fan speed which works, second is for tuning channel where nothing happens

Is there any error in the ha-bridge log? Not sure what to say about issues within HomeAssistant.


⚠ Bofrost.fr has degraded performance

In fc4485f, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1865 ms

Resolved: Bofrost.fr performance has improved in 5987d6d after 3 hours, 55 minutes.


Remove version: Giuspen.Cherrytree version <IP_ADDRESS>

Newer version <IP_ADDRESS> merged yesterday #151360
Microsoft Reviewers: Open in CodeFlow

URL: https://www.giuspen.net/software/cherrytree_<IP_ADDRESS>_win64_setup.exe
OK
(Automated message - build 859)


Right to Left sentences in zulip text box

Hi, I want to write Right to Left sentences in zulip text box, but it's not correctly worked.

Can you please elucidate on the purpose of this enhancement.  Is it for writing english from right to left, or any other language. Also , should the messages  sent be from right to left for the specific user?
Thank You!

Oh, this was fixed some time ago in #9889; this was apparently a duplicate of the original issue.  So nothing needs to be done here; thanks for your interest @Ajayneethikannan!


Add README for Event Hub example

Please ignore the code in this PR (that PR will be merged after the next release of the Provider).

@gsgvijay is it expected you are having 60 files in this PR?


Worker deploy fails due to type: 'map'

🐛 Bug Report
This bug appears to be related to the action itself within GitHub when it's trying to deploy. I cannot get it to complete successfully and it fails every time at the below (line 16).

This is my main.yml file for the action.

I suspect the error comes from your wrangler.toml that doesn't parse. Could you please post your wrangler config here (remove the secret things)?

I suspect the error comes from your wrangler.toml that doesn't parse. Could you please post your wrangler config here (remove the secret things)?

while this is likely a user configuration problem, we should do better about surfacing toml parse errors in a way that the user can figure out what the problem is and fix it themselves


Does not generate domain model classes

Before asking the question:

[x] have you checked the faq, the documentation in the docs folder and couldn't find the information there
[x] have you checked existing issues for a similar question?

Hi
I'm trying to follow the example to generate a client. (https://github.com/Azure/autorest/blob/main/docs/generate/readme.md)
And when I run
autorest --input-file=pets.json --csharp
I get a PetClient class and a PetClientOptions class. But it does not generate the Dog or Kitten classes for me, eventhough I can see the they are defined the pets.json file.
What am I missing here?
/peter

Please use this flag  'generation1-convenience-client' and have a try.

Adding --generation1-convenience-client seemed to do the trick. Thanks :)


Integrate D-Pad patch?

I wonder, could the D-pad patch described here be integrated as a randomizer quality-of-life option?
https://retrogamecorps.com/2020/09/24/guide-enable-d-pad-controls-on-the-legend-of-zelda-nintendo-ds-games/
I vaguely remember reading somewhere that it already was, but I don't see that in the README, so maybe I'm remembering wrong.

You probably saw this https://github.com/phst-randomizer/ph-randomizer/discussions/246#discussioncomment-4385556.
As we develop the randomizer, we're taking care not to touch any of the memory locations used by the Dpad patch; so, it will definitely be possible for one to run the randomizer on a rom that has the dpad patch applied. Including it in the randomizer as an option is certainly something we will look at in the future once we have a stable release ready.


generic-amd64: update logo to be vendor agnostic

Change-type: patch
Signed-off-by: Joseph Kogut<EMAIL_ADDRESS>

@balena-ci I self-certify!


CombinedMemory will not accept repeating memory variable

Using CombinedMemory on memory objects that share the same memory variable results in output value for that memory variable being overriden by memory object that comes latest in the list.
example_1 = ConversationBufferMemory(memory_key="bar")
example_2 = ConversationBufferMemory(memory_key="bar")

combined_memory = CombinedMemory(memories=[example_1, example_2])
combined_memory.load_memory_variables({})
# Memory key 'bar' will take the value output by `example_2`.

This is probably not the desired behavior. I added validator that raise ValueError when this happens so that repeating memory variables won't get passed silently.
Also added some tests for it.

Any reason why the test is failing? Not sure how to fix it.


⚠ SolarOscp has degraded performance

In 3f63e6f, SolarOscp ($SOLAROSCP_URL) experienced degraded performance:

HTTP code: 200
Response time: 303 ms

Resolved: SolarOscp performance has improved in a32c03e after 12 minutes.


Lookup of css and static source files invalid when deploying into subdirectory (self-hosted)

🐛 Bug Report
Placing the build files into a subdirectory does yields broken css and js.
Have you read the Contributing Guidelines on issues?
Yes.
To Reproduce

npx docusaurus-init
cd website
yarn build
put built files into subdirectory on website via ftp
visit page

You can see for yourself by visiting this site:
zenahr.com/docs/unreal-engine
That's where I've put my docosaurus built files into.
Expected behavior
Look for css and js resources inside root-directory, not via global domain name.
Actual Behavior
On local environment it works fine, but when opening up dev-tools on the hosted version you see the following:

This is for the url http://www.zenahr.com/docs/unreal-engine/
Your Environment

Docusaurus version used: 1.14.4

Reproducible Demo
http://www.zenahr.com/docs/unreal-engine/
(Screenshot of deployed site) (tested with chrome and firefox, same result)

(Screenshot of local-dev version)

Found the cause.
I didn't test it yet but I guess I need to change the baseUrl variable inside siteConfig.js in order for it to work properly.
Would be nice to add this tip to the deployment wiki when deploying on own servers.

Having the same issue. Also trying to serve the static files in a simple FTP server. Tried messing around with baseUrl, but I only seem to get as far as loading the images and logo on the home page correctly with baseUrl: './', but none of the docs load properly. Were you able to find a fix for this problem? Thanks


[Certification]: Hibernate 6.6.0.X Jakarta Data 1.0

Organization
Red Hat
Implementation
HIbernate ORM 6.6.0.Alpha1
https://hibernate.org/orm/releases/6.6/
Specification
Jakarta Data 1.0
Technology Compatibility Kit (TCK)
Jakarta Data 1.0.0 TCK
https://download.eclipse.org/ee4j/data/jakartaee11/staged/eftl/
Technology Compatibility Kit (TCK) Validation
starksm@Scotts-Mac-Studio /tmp % shasum -a256 data-tck-1.0.0.zip
02dda1984b67f57bf6996942bea6b1234476e7d1a14bd5770f54f1264decaf35  data-tck-1.0.0.zip
Technology Compatibility Kit (TCK) Results
https://github.com/jakartaredhat/hibernate-data-tck/wiki/JD_100_TCK_Results
Additional Specification Requirements
None
Java Runtime(s)
openjdk version "<IP_ADDRESS>" 2022-08-12
OpenJDK Runtime Environment Temurin-<IP_ADDRESS>+1 (build <IP_ADDRESS>+1)
OpenJDK 64-Bit Server VM Temurin-<IP_ADDRESS>+1 (build <IP_ADDRESS>+1, mixed mode
openjdk version "21.0.1" 2023-10-17 LTS
OpenJDK Runtime Environment Temurin-21.0.1+12 (build 21.0.1+12-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.1+12 (build 21.0.1+12-LTS, mixed mode)
Environments
starksm@Scotts-Mac-Studio arq % uname -a
Darwin Scotts-Mac-Studio.local 21.6.0 Darwin Kernel Version 21.6.0: Mon Feb 19 20:25:23 PST 2024; root:xnu-8<IP_ADDRESS>7.4~1/RELEASE_ARM64_T6000 arm64
Eclipse Foundation Technology Compatibility Kit License (EFTL)

[X] By checking this box I acknowledge that the organization I represent accepts the terms of the EFTL

TCK Requirements and Compatibility

[X] By checking this box I attest that all TCK requirements have been met, including any compatibility rules.

@KyleAure @njr-11 This has been updated for the staged release of the 1.0.0 TCK

Closing as approved by lazy consensus


Add local test environment to get flakey test from dev environment

Changelog

Add local test environment to collect flakey tests from dev environment
Resolves https://github.com/buildkite/test_collector_elixir/issues/9

This looks great, except that you need to add your new module to the list in BuildkiteTestCollector.CiEnv.detect_env/0

@jimsynz Went ahead and added that -- thank you for catching it!


Remove: pnpm.pnpm.6 version 6.31.0

Replaced by pnpm.pnpm

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.2 schema?

Microsoft Reviewers: Open in CodeFlow

@russelbanks - The urls for v6 still work, so I'm confused as to why these are being removed


deps undefined the BOOL in include/sqltypes.h

Proposed changes
When ENABLE_PCH = false, this define will be conflict with BOOL in include/arrow/type_fwd.h.
The ODBC table will be deprecated in 2.1, so I just simply undefined the BOOL in include/sqltypes.h
to make compile OK
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


advanced doesn't properly filter based on query text when filters provided

should change "should" => "must" in query construction.  idea was originally to avoid filtering based on the query, but the feel of that behavior is all wrong.


will cause electron stuck when pasting in linux platform

I require this module at the top of main.js for main process.
I copy any word and paste into electron's input field, then the interface of electron become unresponsive.
It just happened on linux platform, and there is no problem on windows or mac.
I guess that's probably because the clipboard cannot be used befor app ready.
I require this module after main window ready, it won't happen.

`mainWindow.once('ready-to-show', () => {
   mainWindow.show()
   const clipboard = require('electron-clipboard-extended')
   clipboard
     .on('text-changed', () => { /* do something */ })
     .startWatching()
})`

Very interesting, thanks for sharing this. So I can work around this by placing this code in ready-to-show in main process?

That solution can solve my problem very well.
There's another way to solve this,  may be you can initialize previousText/previousImage with empty string(in line 5), it will read clipboard  for the first time after startWatching, and app is ready at that time because there is 500 millisecond delay.
It's just my test result，you can reconfirm it.

Very interesting thanks for sharing! I actually am not using this module anymore, but if I do I'll this out and let you know.

This is an important note, so maybe rather then just closing this, we should document clearly that we they should not use this until app.on('ready')?

Yes, it would be better if add some notes about this.


Total Mana not accounting for Grand Spectrums

Grand Spectrums seems to be properly calculated for the base mana, however, their addition to base mana isn't factored in when calculating the total mana.

Oops, looks like I managed to break that one while restructuring the calculation code; it'll be fixed in the next update.


[ObjC] run cpp ios cronet test with bazel

Cleanup and remove ios cpp test cronet
To test manually:
./tools/bazel test //src/objective-c/tests:CppCronetTests
@sampajano

I believe this should be mergeable after tests are fixed now?

@yashykt Hey Yash! Do you mind reviewing the cpp/client/ changes? Thanks!

@yashykt Hey Yash! Do you mind reviewing the cpp/client/ changes? Thanks!
(btw other changes LGTM!)

@yashykt Hey Yash, a friendly reminder! 😃

Rebased and fixed CI, ready to merge.


Frontend rewrite to Vue

Rewrote the frontend JS to Vue.JS. Mainly because we needed a search function, but I ended up rewriting the rest aswell.
As for features, it's on par with the previous frontend with these changes:

Search, you can now search using the name, organization or the URL
Errors, errors are now setup as a list to accomodate the various problems that could be going on
Progress animation with status
Form validation and gradual apperance of the required elements of the web page
Styling

I'm not a frontend dev by any stretch of the imagination, so critique is very welcome!

Some screenshots from the new page

The content should be centered on page, but not text-align: center
I've aligned a lot of the text to the left now, but still kept some text center alligned as I thought it looked better.
There is too much jumping around when clicking UI elements. Stuff should stay in the same position.
I've tried to reduce this aswell. And the sporadic jumping when the status was showing up briefly is fixed and I think it looks decent now. If we want the UI elements to be even more static, we'd have to preallocated containers for the different elements, but I personlally don't think that looks good.
The search box should have a border to make it look like a search box. It should also be positioned directly below the logo.
Fixed.
The search box should be automatically focused when loading the page.
Fixed.
We are still lacking some documentation.
I'm unsure here; should we create a doc.html template and link to it in a navbar at the top of the page?
What should the contents of the doc be?
Sorting should be case insensitive.
Did the insensitive sort in the go code before it's passed to the frontend.
The clear button isn't really useful.
Removed.
Tests?
Yes. Working on this next

Features

increase width and align elements on the left
Several computed props
Added a more results button incase the user get's a lot of results and isn't quite sure of the name
move errorlist to bottom
added no result text
Fully clickable radio-buttons and checkboxes
Better transition between loading, errors and submissions, reduce the amount of jumping around on the screen

Bug Fixes

Reset teams between repository selection

The last point of contention is if the repository name should be filled into the searchbar once clicked. For now I'm keeping it that way, both because I have a bunch of logic relying on it. Aswell as it looks a lot better with the one repo selected and the available teams / the error page just beneath that.
If we go for the other solution The team and submit button wil most likely go past the screen and you'd have to scroll and everything would just look more cluttered.


team.html: Fix section heading links.

The headings on this page do not have the ID attribute set, so
section heading links are broken.
@timabbott @alya FYI :)

Merged, thanks @eeshangarg!


ScalabilityMode is not defined (when publishing track with VP9 codec)

Describe the bug
When publishing screen track with VP9 codec an error occurs:
ReferenceError: ScalabilityMode is not defined
    at videoLayersFromEncodings (LocalVideoTrack.ts:486:1)
    at LocalParticipant.<anonymous> (LocalParticipant.ts:711:1)
    at Generator.next (<anonymous>)
    at fulfilled (DefaultReconnectPolicy.ts:33:1)

Server

Version: 1.4.4
Environment: DEV (Google Chrome Version 110.0.5481.177,  Linux )
any other information about your deployment setup
command:

server --dev

Client

SDK:  Javascript
Version: 1.12.2

To Reproduce
Publish screen track with VP9 codec.
this.room.localParticipant.publishTrack(screenTrack, {
            simulcast: false,
            scalabilityMode: "L3T3",
            source: Track.Source.ScreenShare,
            videoCodec: "vp9",
})

Hey @onthegit, this was reported in the JS repo here and has been fixed.
The update is released in 1.12.3
While I have you here, do you mind taking a look at the CLA on your PR here so we can get it merged?


Test go version used on release-2.3 branch

Signed-off-by: Daniel Farrell<EMAIL_ADDRESS>

/hold


Bug: Radio Button's not Binding to Nested Properties

Overview of the problem
Buefy version: 0.5.4
Vuejs version: 2.4.4
OS/Browser: Mac OS Sierra/ Chrome
Description
I noticed a bug when using the radio buttons as demonstrated here: https://buefy.github.io/#/documentation/radio (the physical buttons as opposed to the bullets)
In my testing I was not able to get them to work properly while using v-bind to bind them to a nested property such as foo.bar. If i pulled the property up to the top level such as fooBar then it would bind correctly, but moving it into a nested property caused issues.
Specifically, the radios seem to be able to set the nested property, but the other buttons would not deselect as the property changed to another radio in the group.
They were all bound to the same v-model property, i went as far as to copy the code on the documentation page exactly, and just moved the bound property from the base layer to a nested layer. It would work and not work as it moved in and out of being nested in another property.
Steps to reproduce

Copy code for the radio buttons on this page: https://buefy.github.io/#/documentation/radio
Move the bound property from radioButton (such as the example given in the documentation) to radio.button
Refresh the page for the code to take effect
If you set a default value for the nested property you will notice that the radio buttons do not acknowledge the value and no buttons will be selected upon a refresh
Click and change the selected radio

Interestingly, the value for the nested radio.button will update if you inspect it with each click of a radio
However, the buttons will never "deselect" and once a radio button has been selected once, it can not set the property again (assuming you try to switch away and back to that radio)

Now create a property at the base level radioButton and you will see that this works as intended.

Just to recap.
Given the example below. The radios bind correctly to radioButton property (because it is top level) but do not bind correctly to radio.button because it is nested.
var app = new Vue({
    el: '#app',
    data: {
        radioButton: 'foo',     // good to go!
        radio: {
            button: 'foo'       // no bueno :(
        }
    }
});

Expected behavior
Radio button will select and deselect as other buttons bound to the same property are pressed
Actual behavior
Buttons can be selected but not de-selected 😢

@jacurtis bRadioButton works like native radio button and when it's selected is not possible unselect it.  As workaround, you could attach<EMAIL_ADDRESS>and if the v-model data is the same then set it to default value or empty. For example:
<b-radio-button @click.native="unselect" v-model="radioButton" ...
...
unselect(event) {
   if (this.radioButton === event.target.value) {
       this.radioButton = ''
   }
}

Not sure if it's your issue but something about nested properties on v-model has been fixed on vue 2.5: https://github.com/vuejs/vue/issues/5932#issuecomment-334040085

You are right, this is fixed now 😄


WIP: Setup script for puppetize course

Changing title to WIP for now, it didn't work when I retested it.

I think I'm going to rewrite it in ruby, there were enough weird bash issues.


theme.getColorSchemeSelector is not a function

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
theme.getColorSchemeSelector("light") or theme.getColorSchemeSelector("dark")

https://codesandbox.io/p/sandbox/gracious-babbage-d8xdpy?file=%2Fsrc%2FDemo.tsx%3A27%2C21-27%2C59
Current behavior 😯
theme.getColorSchemeSelector("light") Doesn't work at root level
but work at a lower level
const theme = useTheme()
theme.getColorSchemeSelector("light") => Work

Expected behavior 🤔
Works at root level like MUI JOY :
https://codesandbox.io/p/sandbox/cool-sun-j6wjvf?file=%2Fsrc%2FDemo.js%3A110%2C71
Context 🔦
No response
Your environment 🌎
No response

This is because getColorSchemeSelector is appended by CssVarsProvider because the function needs attribute from CssVarsProvider's props.
I think we can improve this by delegating the attribute to the extendTheme and set getColorSchemeSelector to the theme. With this, zero-runtime can read and use the attribute internally cc @brijeshb42

Thank you for providing feedback.
If we can deliver in extendTheme instead of under CssVarsProvider then customization will be better
Currently I can temporarily rewrite the getColorSchemeSelector function for use:
export function getMode(mode) {
  if (mode === 'light') {
    return `[data-mui-color-scheme="light"] &`;
  }
  return `[data-mui-color-scheme="dark"] &`;
}

But I realized other functions like pallet also don't work inside extendTheme like Mui Joy.
My need is to customize the theme before creating in <CssVarsProvider theme={theme}>
So I need properties like mode (console.log("palette", theme.palette.mode);)
There is also solution for this using global state. But then  const { mode, setMode } = useColorScheme(); will lose its meaning and we have to write some extra code to further handle the mode state, which is not necessary

Hopefully this will improve.


chore: remove explain create source

Signed-off-by: tabVersion<EMAIL_ADDRESS>I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title
Checklist
- [ ] I have written necessary rustdoc comments
- [ ] I have added necessary unit tests and integration tests
- [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).

[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)
resolve #4776

@tabVersion Does it mean that this command is not supported any more?


Drop flask-selfdoc

What to refactor?
Remove Autodoc from the project
Refactor reason
The refactoring is needed because it's not used, and the endpoint doesn't work.
Suggested solution

[ ] remove package https://github.com/jwg4/flask-selfdoc
[ ] remove Autodoc usage from the code
[ ] remove documentation endpoint /documentation

Tests

[ ] CI should pass

I would like to work on it

Hi @free1f 👋
Do you have progress on this?

Hi, I see there hasn't been any progress on this and I'd like to work on it.


⚠ ClamAV has degraded performance

In 01348e1, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 125 ms

Resolved: ClamAV performance has improved in 5e3ad8f after 12 minutes.


Add info texts

Currently the form isn't very easy-to-use unless you know the spec. We need to figure out what fields need additional info texts and where they should be placed (either behind an info button popup or the placeholder of text fields).

Info texts needed based on previous issues:

Headers, Examples, Tags, Consumes and produces subsections under Path section
Consumes & Produces sections

Fields that need info texts (based on previously opened issues):

Headers, examples, tags, consumes and produces under Paths
Consumes and produces (global)
Host field
License section under Info

Fields that need info texts (based on previously opened issues):

Headers, examples, tags, consumes and produces under Paths
Consumes and produces (global)
Host field
License and contact sections under Info

@tulir thanks for doing an advanced work.
I'll review it and explore around the UI myself to see if some additional fields should be included in the list.

We should look through the form and see what is still needed now that we have validation and placeholders.


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 16:09:29 on 2023.05.11
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 5, errors out: 0
Original problem ID: 20563
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=20563

Problem has been resolved in 6m 0s at 16:15:29 on 2023.05.11
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 20563


[SMALLFIX]Update wording for chown command in docs/_data/table/en/operation-command.yml

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17600/
Test PASSed.


The README is missing the step to create a custom connection for Cosmos DB

Required to successfully run evaluate-chat-prompt-flow.ipynb
Creating Custom Connection (contoso-cosmos)

Visit https://ml.azure.com instead
Under Recent Workspaces, click project (contoso-chat-aiproj)
Select Prompt flow (sidebar), then Connections (tab)
Click Create and select Custom from dropdown
Name: contoso-cosmos
Provider: Custom (default)
Key-value pairs: Add 4 entries (get env var values from .env)
key: key, value: "COSMOS_KEY", check "is secret"

key: endpoint, value: "COSMOS_ENDPOINT"
key: containerId, value: customers
key: databaseId, value: contoso-outdoor
Click Save to complete step.

This issue appears to be resolved now (see Step 4.6 in README.md)


Initial commit with working version.

lgtm with some suggestions - this looks great!

Done. PTAL and merge if it looks good :)


Throw type error when TS class decorator returns an object.

function Deco(){
  return {}
}

@Deco()
class Foo{}

TS allows decorator returns any value. When Reflect.decorate defined by reflect-metadata, TS will use this function to define metadata instead of TS implements. Reflect.decorate couldn't process un-class return value returned by a class decorator.
//Reflect.js
          function DecorateConstructor(decorators, target) {
            for (var i = decorators.length - 1; i >= 0; --i) {
                var decorator = decorators[i];
                var decorated = decorator(target);
                if (!IsUndefined(decorated) && !IsNull(decorated)) {
                    if (!IsConstructor(decorated))
                        throw new TypeError(); // !!HERE!!
                    target = decorated;
                }
            }
            return target;
        }

I need the feature that class decorator returns an object.
https://github.com/microsoft/TypeScript/issues/49753

i met the same problem,how to solve?

@DreamMoon93 According to tc93 decorator stage 3. Class decorator must return a class constructor. So TS's class decorator is non-standard.

Class decorators receive the class that is being decorated as the first parameter, and may optionally return a new class to replace it. If a non-constructable value is returned, then an error is thrown.

so the problem need ts support, or we can do nothing?

I will try to adapt my code to standard.

Class decorators should either return a function or void:

TS's __decorate helper assumes valid inputs since invalid inputs should result in compile time errors. The Reflect.decorate helper does not assume valid inputs and thus is more exhaustive.

@rbuckton I can't quite tell, but it seems like your response here is assuming stage 2 decorators - is that true? Is there discussion or documentation somewhere on what impact the shift to stage 3 decorators will have on reflect-metadata?

I've also met this error and seems only happen on old android machine


Auto-mount emptyDir volumes for k8sapi/kubelet or runAsNotRoot: true(?) executors

Summary
Will there be support for outputs from base image layer instead of using emptyDir to save params/artifacts when using the kubelet or k8s api executors?
Motivation
I was running Kubeflow Pipelines with the container runtime executor as kubelet, but I kept hitting errors with the pipelines completing their tasks.
I then tried the https://github.com/argoproj/argo/blob/master/examples/artifact-passing.yaml example to try to narrow down the problem and realized that I had to mount an emptyDir volume in order for it to work.
My question is will there be support for outputs from base image layer with k8s api and kubelet executors in the future? Or is it not possible due to the way these executors work?

We use PNS ourselves - so this would be a great one for a community contribution.

As far as I know, it’s not possible now.
https://github.com/kubernetes/kubectl/issues/454

Argo already adds volumes to capture artifacts for docker executor. Why not for other executors? If Argo tells us to "mount an emptyDir volume", why can't it just auto-mount that volume itself?

Our users need artifacts to work for some non-docker executor.

I agree with @Ark-kun. The controller should add emptydir volume automatically if non-docker executors configured. This is a nice feature and will reduce many support questions.

Related: https://github.com/kubeflow/pipelines/issues/1654 https://github.com/kubeflow/pipelines/issues/561 https://github.com/kubeflow/pipelines/issues/3407

Let's keep this up

Hey everyone, we use the "k8sapi" executor to run Argo on Openshift. Wanted to see if there is progress on this issue?

I've spent some time updating the documentation for the executors and how and when to use [emptyDir]https://argoproj.github.io/argo/empty-dir/).
TL;DR:

Use the docker executor if you don't care about security and do care about performance. Use the k8sapi executor if you care about security and not about performance. Use PNS for something in between. Don't use kubelet.
If you use emptyDir you don't get many of the security problems.

It is reasonable for the kubelet and k8sapi executors to automatically mount empty dir volumes for output artifacts.
To do this, copy addInputArtifactsVolumes and make the obvious changes.
Would anyone like to submit a PR?

Argo already adds volumes to capture artifacts for docker executor.

@Ark-kun I'm not sure this is correct?

@Ark-kun I'm not sure this is correct?

AFAIK, Argo tries to use mirrored volumes to make the input artifacts accessible to the main container and capture the output artifacts.
See https://github.com/argoproj/argo/blob/4de64c618dea85334c0fa04a4dbc310629335c47/workflow/controller/workflowpod.go#L793 https://github.com/argoproj/argo/blob/4de64c618dea85334c0fa04a4dbc310629335c47/workflow/controller/workflowpod.go#L896
https://github.com/argoproj/argo/blob/e14f4f922ff158b1fa1e0592fc072474e3257bd9/workflow/executor/executor.go#L369

Perhaps we should add logic such that for every output artifact there should be an emptyDir mounted at it's parent directory unless there is another volume already mounted underneath.

thank you @Ark-kun

I'm not sure this has been fixed.

Re-opened. This got closed by a PR and should not have been close. Would anyone be interested in investigating how to fix this?

This would be for k8sapi and kubelet executors. I think it may also be needed for whenever runAsNotRoot: true.

argoproj/argoexec:auto-emptydir and argoproj/workflow-controller:auto-emptydir available for anyone who wants to test this.

I'm going to wait for user testing before proceeding.

bump! please let me know if you really want this by testing the controller

bump! please let me know if you really want this by testing the controller

bump! please let me know if you really want this by testing the controller

I think it is safe to say that we do really want this. Just have a look at the number of upvotes for such a technical issue and the other similar bugreports in kubeflow etc. It might help if  you could provide images for testing or even some short instructions for a kubernetes cluster. Then everyone can test his workloads. Otherwise everyone has to dig into how to build the images etc.

bump! please let me know if you really want this by testing the controller

I think it is safe to say that we do really want this. Just have a look at the number of upvotes for such a technical issue and the other similar bugreports in kubeflow etc. It might help if  you could provide images for testing or even some short instructions for a kubernetes cluster. Then everyone can test his workloads. Otherwise everyone has to dig into how to build the images etc.

I think this issue will be moot with the Emissary Executor.
What is the Emissary Executor?
Why?

As fast as the fastest executor (docker)
As secure as the securest executor (k8iapi).
Every feature of all other executors.

@terrytangyuan @Ark-kun would you be able to test this new executor, please?
You need dev builds of the controller and executor:

alexcollinsintuit/workflow-controller:emissary
alexcollinsintuit/argoexec:emissary

I think this issue will be moot with the Emissary Executor.
What is the Emissary Executor?
Why?

As fast as the fastest executor (docker)
As secure as the securest executor (k8iapi).
Every feature of all other executors.

@terrytangyuan @Ark-kun would you be able to test this new executor, please?
You need dev builds of the controller and executor:

alexcollinsintuit/workflow-controller:emissary
alexcollinsintuit/argoexec:emissary

I have tested it with kubeflow pipelines 1.3
There are only minor issues.

op.set_security_context(V1SecurityContext(run_as_user=1000))
leads to permission errors in /var/argo/templates
But without that addition all pipelines finished successfully with runasnonroot.

Kubeflow pipelines runs with argo 2.7.5 by default. So the artifacts etc where successfully uploaded to minio. Nevertheless it seems that there was a communication error such that i cannot download them from the kubeflow pipelines webinterface anymore, even though they are in minio. So the output location is most likely not properly submitted. This is also the case if i use pns with your special emissary images, so i guess the 2.7.5 interface is just in some way not compatible with 2.12+ .

Since kubeflow pipelines are going to use argo 2.12 in the future, it would be good if the emissary executor is compatible with 2.12.

I have tested it with kubeflow pipelines 1.3
There are only minor issues.

op.set_security_context(V1SecurityContext(run_as_user=1000))
leads to permission errors in /var/argo/templates
But without that addition all pipelines finished successfully with runasnonroot.

Kubeflow pipelines runs with argo 2.7.5 by default. So the artifacts etc where successfully uploaded to minio. Nevertheless it seems that there was a communication error such that i cannot download them from the kubeflow pipelines webinterface anymore, even though they are in minio. So the output location is most likely not properly submitted. This is also the case if i use pns with your special emissary images, so i guess the 2.7.5 interface is just in some way not compatible with 2.12+ .

Since kubeflow pipelines are going to use argo 2.12 in the future, it would be good if the emissary executor is compatible with 2.12.

I don't plan to backport the emissary to v2.12. It's a big and therefore risky change.

I don't plan to backport the emissary to v2.12. It's a big and therefore risky change.

I think v2.12 is the right version for Kubeflow. I'd like us to get more involved and help out with Kubeflow more. Can you add me to the PR you're working on please?

I think v2.12 is the right version for Kubeflow. I'd like us to get more involved and help out with Kubeflow more. Can you add me to the PR you're working on please?

Well if the interfaces are somewhat compatible its fine. Then i just have to use the upstream argoexec and workflow-controller images for the emissary executor. That worked for 2.7.5 with 2.11 images as far as i remember.
https://github.com/kubeflow/pipelines/issues/4553 is the issue for argo 2.12 in kubeflow
and i think you are already in the conversation because of https://github.com/argoproj/argo/discussions/4953

Well if the interfaces are somewhat compatible its fine. Then i just have to use the upstream argoexec and workflow-controller images for the emissary executor. That worked for 2.7.5 with 2.11 images as far as i remember.
https://github.com/kubeflow/pipelines/issues/4553 is the issue for argo 2.12 in kubeflow
and i think you are already in the conversation because of https://github.com/argoproj/argo/discussions/4953


Users SBAT get a message/warning if the number is already verified

Expected Behavior
Users should get a message/warning if their number is already verified before overwriting the number<->address mapping with a new address.
Current Behavior
If a user verifies a number with a new account, no message/warning is shown about a previous existing account.

tackling as part of a larger issue around multiple mapped phone numbers


Ability to change Texture Format

Due to https://github.com/bevyengine/bevy/blob/main/crates/bevy_render/src/view/window/mod.rs#L245 the default TextureFormat might be different from Bgra8UnormSrgb

Thanks for your contribution! I think removing the hard-coded texture format here is definitely worthwhile. I wonder though, whether it would be better to try to obtain the texture format automatically from the extracted primary window's swap_chain_texture_format rather than requiring the user to specify this themselves via the plug-in configuration?

ExtractedWindows is not yet populated at the point of imgui plugin initialisation (where the texture format is currently being set). Might be possible to extract it from somewhere else but i am not that familiar with bevy's window/rendering workflows to figure it out on my own.

Okay. Just to provide an update here, I'm going to take a look at alternative options before merging this. I feel that pushing this up into the config structure just passes this problem on to the user, but in doing so, we'll then be asking them for something that they also cannot compute. I'll see if I can restructure the plug-in a bit to allow us to obtain this information before initialising the imgui renderer

Hey @Nhlest - I've pushed up an alternative PR for automatically handling texture formats - do you think this solution would address your issues too?


fix: selector "#feature" won't point to an element in "www.plasmo.com"

I discussed with @louisgv about this tiny issue on Discord. Here is the link:
https://discord.com/channels/946290204443025438/1044559116581994527
With changes in this PR, now the website will be affected like this:

Louis is a really nice guy and he helps me with many questions, thanks louis!

BTW, since the example repo is as a submodule of the plasmo repo. After this PR is merged, should I do something else to make the submodule be synced?

Another outdated selector has been fixed:

BTW, since the example repo is as a submodule of the plasmo repo. After this PR is merged, should I do something else to make the submodule be synced?

DW I got you :)


load custom badges for old chat as well

the custom mod badges are loaded here already as well, might as well also refresh the custom sub and cheer badges here so they show up in the history.
resolves #716

Works, thank you


[5.3] Use getter instead of accessing the protected property directly.

Use getter instead of accessing the protected property directly to avoid having error like below:
PHP Fatal error:  Uncaught Error: Cannot access protected property

:+1:


Add Fluid Framework to Realtime

Updated readme.md to include Fluid Framework for building real time collaborative experiences.
Link: https://github.com/microsoft/FluidFramework
Fluid framework is the open source framework that is being increasingly used to power real time, collaborative experiences in applications like Microsoft Word, Microsoft teams, Sharepoint etc, that can scale to hundreds of users at the same time. It is built in Typescript/Node.js and can be used with any client framework like react, angular, vue.js or event plain html/js.
Most other real time frameworks like socket.io provide a way to transfer data in real time. Fluid framework provides an abstraction over it so that developers only deal with higher level DDS (Distributed Data Structures) line string, map etc and the framework manager the real time sync across devices over the internet.
By submitting this pull request, I promise I have read the contribution guidelines twice and ensured my submission follows it. I realize not doing so wastes the maintainers' time that they could have spent making the world better. 🖖
⬆⬆⬆⬆⬆⬆⬆⬆⬆⬆

By submitting this pull request, I promise I have read the contribution guidelines twice and ensured my submission follows it. I realize not doing so wastes the maintainers' time that they could have spent making the world better. 🖖

By submitting this pull request, I promise I have read the contribution guidelines twice and ensured my submission follows it. I realize not doing so wastes the maintainers' time that they could have spent making the world better. 🖖

Hey. Sorry, but the comment is not very clear.
Is something missing and I need to double check the contributing guidelines?

Yes


Use AssemblyName.Clone when possible.

AssemblyName.Clone is not available in early versions of .NET Core.
Until we can upgrade MSBuild to use .NET Core 2.0, we can't call the
Clone method directly. This change will attempt to call .Clone using
reflection and if not available fallback to the previous .NET Core
behavior.
Potential fix for #2015 (when running on .NET Core 2.0).

@dotnet-bot test Windows_NT Build for CoreCLR please

@dotnet-bot test Windows_NT Build for CoreCLR please


Remove Kausal & Freshtracks, add Grafana Labs.

Removing freshtracks whilst I'm there, see https://blog.freshtracks.io/swan-song-96ce02ef854f

Signed-off-by: Tom Wilkie<EMAIL_ADDRESS>

@brian-brazil PTAL.   Also re-added FT, as don't want to clash with @RichiH's PR.

We could have done it in one.


Deploy streamlit app

Deployed to https://tango-ai.streamlit.app/ and added to project description


Add --dns-loop-detect to dnsmasq used in kube-dns

It prevents DNS loops when host's DNS server is a localhost DNS server,
or when DNS server of cluster is also added as an upstream DNS server
See:
https://github.com/kubernetes/kubernetes/issues/67299
https://github.com/kubernetes/kubernetes/pull/67302

does this apply to CoreDNS too ?

I've not checked CoreDNS yet. Does it also run dnsmasq? If it does, and passes upstream DNS servers to it, it'll need this.
If CoreDNS replaces dnsmasq, it probably needs a similar mechanism to prevent DNS loops.

does this apply to CoreDNS too ?

No. CoreDNS does not need it.

ci check this


Toadette Moons

Toadette Moons do not Sync

I think they aren’t meant to sync because literally every other moon asides from hint adds sync


Fix pointer 'session_info' checked for NULL may be dereferenced.

Fix: #1475
Fix: #1476
Signed-off-by: Zhao, Zhiqiang<EMAIL_ADDRESS>

The issue is reported by static analysis tool, when we build release image, where the ASSERT is nothing.


Enabling using Transform to Lower/Upper/Title Case without changing String Literals

Hi there,
I would love to have the 'Transform to Lower/Upper/Title Case' command to be aware of string literals.
What I mean by that is I would love to have the option to enable the following behavior for that commands:
Input that I'm going to Ctrl + A and then Ctrl + Shift + P -> Transform to Lowercase:
SELECT
  *
FROM TABLE
WHERE USER = 'TESTUSER';
Should result in the following expected behaviour:

The expected output:
select
  *
from table
where user = 'TESTUSER';

The same goes for Transform to Uppercase and Transform to Title Case.
This is especially helpful when you have to rewrite/code a lot of inherited code that doesn't comply with your coding style guide for example.

Previously requested at #106807 but didn't get enough support to get onto Backlog

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

Is this still regarded as a candidate for the backlog?

Ping

Is this still regarded as a candidate for the backlog?

It achieved the necessary upvotes on May 18, 2022 and moved onto Backlog.


Video Under Water - Lag when playing with LEDs

The video is not playing correctly with the LED animations
The reason might too many things happening at the same time:

[ ] test with just video
[ ] test with slower led animations

On underwater video

See https://weareleka.slack.com/archives/C04F19WD6/p1675862481202179


Rate Limiting

Is your feature request related to a problem? Please describe.
A common problem with web services and APIs is that they may be overwhelmed by a high volume of requests from a single source, such as a bot or an unauthorized user. This can lead to reduced performance and potentially even downtime. Rate limiting is a technique used to mitigate this problem by restricting the number of requests that can be made within a certain time period. However, if rate limiting is not implemented properly, it can also result in legitimate users being blocked from accessing the service. Therefore, finding the right balance between preventing abuse and ensuring access for legitimate users can be a challenge.
Describe the solution you'd like
For rate limiting, I would like to see web services and APIs implement effective and configurable rate limiting policies that can differentiate between legitimate and abusive traffic. Specifically, I would like to see rate limiting policies that can:
Limit the number of requests made by an individual user or IP address within a given time frame
Allow for flexibility in adjusting the rate limit threshold and time window to accommodate changing traffic patterns
Distinguish between normal user traffic and malicious traffic, such as DDoS attacks or bots, and apply more strict rate limiting policies to abusive traffic
Provide meaningful feedback to users who are being rate limited, such as error messages with information on how to resolve the issue and/or contact support
Monitor and analyze traffic patterns to adjust rate limiting policies and improve their effectiveness over time.
In general, the goal should be to implement rate limiting policies that strike a balance between preventing abuse and ensuring that legitimate users can access the service without disruption.

rate limit middleware come by default default with .net core please check this doc. just few line of code
https://learn.microsoft.com/en-us/aspnet/core/performance/rate-limit?view=aspnetcore-8.0


Provide built-in JSON reporter

Hi there,
I‘m wondering why JSHint has not provided a built-in JSON reporter. Currently, 3 reporters are provided:

jslint - XML
checkstyle - XML
unix - line oriented

https://github.com/jshint/jshint/blob/7c36c8102bf4a0490820c824f5f01ad1acece36f/src/cli.js#L17
I can use a 3rd-party JSON reporter jshint-json, but I think it would be wonderful if we could use a JSON reporter more easily without any extra installation.
For example, I have just written a custom reporter to output a JSON report:
https://github.com/sider/runners/blob/83b73bf27552cffb63906feb757b2e23161c73a3/images/jshint/custom-json-reporter.js
What do you think about this suggestion? I would appreciate your feedback.
Thank you.

Hi there! JSHint's "custom reporter" feature is how we give consumers fine-grained control of JSHint's output without the formal approval of the maitenance team. It's also a benefit to the maitenance team because it helps us limit the amount of code that we're responsible for.
I'd be happy to offer another built-in reporter, but I would like some indication that folks would use it. Honestly, at this stage in JSHint's lifetime, it seems unlikely that there's enough demand to warrant even a small feature like this, but I'm happy to be proven wrong! So if anyone would be interested, leave a positive "reaction" on @ybiquitous's original feature request above.


Fix/use entity path

Codecov Report

Merging #3 into master will increase coverage by 5.9%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           master       #3     +/-   ##
=========================================
+ Coverage   89.65%   95.55%   +5.9%
=========================================
  Files           3        2      -1
  Lines          58       45     -13
  Branches       14       12      -2
=========================================
- Hits           52       43      -9
+ Misses          6        2      -4

Impacted Files
Coverage Δ

src/components/SearchBar.ts
94.73% <75%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb7d04...097b16e. Read the comment docs.


Problem with Reference Equality

This is not verifying for reasons unknown:
function select<T>(int x, int y, T t1, T t2) -> (T r)
ensures (x >= y) ==> (r == t1)
ensures (x < y) ==> (r == t2):
    //
    if x >= y:
        return t1
    else:
        return t2

public export method test():
    &int p1 = new 8
    &int p2 = new 16
    //
    &int r1 = select(1,2,p1,p2)
    //
    assert r1 == p2

This is actually subsumed by #48.

This is actually subsumed by #48.


When using cdxgen to generate SBOM for a Python application The hash is stored in the wrong format

I've got a Python application which I used cdxgen on to generate the BOM file, When I try to upload it to DependencyTrack I get an error
43.511 ERROR [BomUploadProcessingTask] Error while processing bom javax.jdo.JDOFatalUserException: Attempt to store value "77c6f6e3aeb8e7ad5dd1ddf875d7da79ce78eb7e9de74d9dedc79ae9edbd73779a7faf1fddd7fad7cd3ceb77b6d7ae9e" in column ""SHA_256"" that has maximum length of 64. Please correct your data!
I believe we've found the issue in the code here: https://github.com/AppThreat/cdxgen/blob/master/utils.js#L597
should be
p._integrity = "sha256-" + toBase64(digest["sha256"]);
I'm going to open a PR to fix this following this issue.

Hi @shayrybak , I fixed a similar error yesterday as part of #30 . The fix is live in 2.2.7. Can you re-test and let me know how it looks for you?

Sure let me test that, and I'll update here.

@prabhu Thank you, I can confirm this is working in 2.2.7. going to close my PR.

Closing the issue as well, as this is fixed.


ENH: Epochs vectorizer

To elegantly pipe mne.Epochs through sklearn.pipeline.Pipelines
cc @trachelr @kingjr @agramfort ...

Epochs vectorizer is here as ConcatenateChannels.
We just need to rename the class ConcatenateChannels and make deprecation warning.
I can do it in PR #2292

closing issue as it seems this is already addressed


Repleace python from appveyor

We should replace the the python from appveyor with the official python Installer. Because without the official installer fife installer dont find the installed python.
https://www.python.org/downloads/

I don't think that this is needed.
For example, when

installing the SDK into d:\fifesdk
Python will be installed into d:\fifesdk\python

When the MSI installer (for Python27 libfife) is executed by the SDK installer it
asks for the install location and the user can simply provide it, see:

I forgot to write why i asked about this change. The Problem was:

installed sdk
installed fife
get UH and it dont found python and dont found fife.
installed offical python fife installer found python by it self UH found python but not fife
added "C:\Python27\Lib\site-packages\fife" to path UH runs fife (needed extra dep. python yaml)

That's probably a problem with the UH installer itself, then...
I think it expects Python at C:\Python27 and doesn't take other Python versions (3.x) or custom install locations of Python into account.
This file needs to be adjusted for Python3 support i think:

https://github.com/unknown-horizons/unknown-horizons/blob/dcbdef20b771920b506bbb7fd7860d38163f25de/development/create_windows_installer.sh

When i look at the installer template, then there is INSTDIR = https://github.com/unknown-horizons/unknown-horizons/blob/dcbdef20b771920b506bbb7fd7860d38163f25de/development/nsi.template#L65
This would mean that UH finds Python, when it is installed into the same folder: fifesdk, which doesn't make much sense, because you want UH in it's own folder. Guess, the UH installer needs a dialog, select Python location.

I have taken UH from git without installer. Problem is to when you type python on the CMD it dont find it. Because its not in the PATH Variable.

And because of the installer im thinking about to change it to inno setup too.

Problem is to when you type python on the CMD it dont find it

Ok, then we are back at "set PATH to Python during the installation of FifeSDK", right?

And because of the UH installer im thinking about to change it to inno setup too.

Not sure if rewriting the UH installer is really needed, because NSIS und INNO are pretty similar.
But, i wish i had more time to help you with that.. :(

Yeah we must find an way how to set python to path. Maybe i will found something.
And because of switching to Inno i think it would be easier to maintain because then fife and UH use the same installer. And we could maybe fix easier bugs then too in both installers. And i dont know how to write the NSIS installer for appveyor.
About fife i will wait some time what prock say about the open pr then retag fife to 0.4.0 and release it after it i hope we have done fife sdk. That i can start with UH.

I found something but i dont understand it:
http://stackoverflow.com/questions/3304463/how-do-i-modify-the-path-environment-variable-when-running-an-inno-setup-install
http://www.jrsoftware.org/isfaq.php#env
And i found how we can set Installer Icon :)
http://www.jrsoftware.org/isfaq.php#setupicon

And i found how we can set Installer Icon

Every detail counts, once the big issues are resolved.
By the way: the installer images have a transparency problem.
Ok, the StackOverflow solution makes sense.
They set the PATH var by adding it as Registry Key, which looks scary, but works:
So the base is this:
[Registry]
; set Python PATH
Root: HKCU; Subkey: "Environment"; ValueType:string; ValueName:"PATH"; ValueData:"{olddata};{app}\Python"; Flags: preservestringtype

[Setup]
; Tell Windows Explorer to reload the environment
ChangesEnvironment=yes

Here the old PATH data is appended with {app}\Python.
Two problems:

The fist problem is that you don't know, if this path is already on the PATH.
That's why the SO answer includes function NeedsAddPath in the [Code] section.
The second problem is that you have to make sure that is removed properly during uninstallation.

Maybe only set PATH when the user installs the python version forum our sdk? When that is makeable with the installer?
And about removing this would be need testing :)

Because of transparency maybe we must use PNG instand of BMP?

Because of transparency maybe we must use PNG instand of BMP?

PNG isn't supported, only BMP. It might be an alpha channel issue,
http://www.jrsoftware.org/ishelp/index.php?topic=setup_wizardimagefile

And about removing this would be need testing :)

We need clones or robots  🤖 too much work, not enough time 🕐

Yeah more time would be very nice :( Yeah reporting Bugs is good we will never find all problems together :D I will later take an look on the bmp files and see what GIMP have settings for the format.

I found something more that could help here: http://stackoverflow.com/questions/16157700/python-distribute-module-using-inno-setup
I Searched how i can install python moduls with inno setup and found this but i think it could help to with our problem?

[ ] path to python
[ ] path to installed libfife (= python site-packages folder, because DLLs)

function NeedsAddPath(Param: string): boolean;
var
  OrigPath: string;
  ParamExpanded: string;
begin
  //expand the setup constants like {app} from Param
  ParamExpanded := ExpandConstant(Param);
  if not RegQueryStringValue(HKEY_LOCAL_MACHINE,
    'SYSTEM\CurrentControlSet\Control\Session Manager\Environment',
    'Path', OrigPath)
  then begin
    Result := True;
    exit;
  end;
  // look for the path with leading and trailing semicolon and with or without \ ending
  // Pos() returns 0 if not found
  Result := Pos(';' + UpperCase(ParamExpanded) + ';', ';' + UpperCase(OrigPath) + ';') = 0;
  if Result = True then
     Result := Pos(';' + UpperCase(ParamExpanded) + '\;', ';' + UpperCase(OrigPath) + ';') = 0;
end;

@jakoch can we add this 1:1 into our code?

or maybe this: http://legroom.net/software/modpath

[x] added env path helper for innosetup
[x] added path to python
[x] added path to installed libfife (= python site-packages folder, because DLLs)

Status:

[ ] needs testing

Appveyor Build failed
log.txt

The build succeeded after a couple of fixes: FifeSDK-0.0.44-Setup-VC14-x86.exe

It dont set any paths :(

Maybe we should add offical Python installers into the sdk and for cmake too?

The missing python27.dll is a new issue. Seems it's not in the Python folder, but in the Windows folder.
We need to copy it into the Python folder first, then the installer includes it during packaging.
Here is a new installer for testing the following things:

installation of libfife into python folder
add paths
uninstallation triggers uninstallation of libfife
uninstallation removes paths

FifeSDK-0.0.49-Setup-VC14-x86.exe

Tested now: FifeSDK-0.0.52-Setup-VC14-x86
it finds python but .py files must be set that i get open with python one time.
Uninstall works but PATH dont get removed.

You can remove this line: +;Source: "C:\Windows\SysWOW64\python35.dll";     DestDir: "{app}\python";                Flags: recursesubdirs ignoreversion; Components: "Python\py35"
Python3 dont have any problems:

About PATH Delete i found this:
http://stackoverflow.com/questions/26762668/inno-setup-how-to-uninstall-registry-value
and
http://stackoverflow.com/questions/35410421/inno-setup-remove-path-from-path-environment-variable-while-uninstalling-a-pro
but the first one is very short and when it works it would be cool.

Flags: uninsdeletekey is not an good idea it have delete the complete entry in my reg.....

:(
We are already using the second solution, see https://github.com/fifengine/fife-windows-sdk/blob/master/installer/includes/envpath.iss#L45
Guess, we need to run the uninstaller with logging enabled to find out what's going on.

Your last git changes dont help. Should i create an bug report at inno setup? maybe they can help us?

Contacting the InnoSetup team isn't needed. Btw. they only give support via mailinglist... old age and i would always ask on StackOverflow first for getting a faster response.
Yes, i'm still trying to track the issue down.
For debugging the uninstaller: unins000 /LOG=c:\fife_uninst.log
I think we have registry key mismatch:
the installer writes to the user env path, but the uninstaller tries to remove from the system env path

Can't we maybe set the system path then instand of user?

I've justed added additonal functions to envpath.iss  to support env path modification on both of the registry keys HKEY_Current_User and HKEY_Local_Machine.
For now the modified path is HKEY_Current_User, if that works, we could still decide to modify LocalMachine.

Finally, it's working...
2016-12-27 17:42:10.250   Prepare to remove from Old PATH [%USERPROFILE%\AppData\Local\Microsoft\WindowsApps;C:\server-086\bin\mariadb\bin;c:\fifesdk\python;c:\fifesdk\python\Lib\site-packages\fife]
2016-12-27 17:42:10.251   Path [c:\fifesdk\python\Lib\site-packages\fife] removed from PATH => [%USERPROFILE%\AppData\Local\Microsoft\WindowsApps;C:\server-086\bin\mariadb\bin;c:\fifesdk\python]
2016-12-27 17:42:10.251   PATH written
2016-12-27 17:42:10.251   Prepare to remove from Old PATH [%USERPROFILE%\AppData\Local\Microsoft\WindowsApps;C:\server-086\bin\mariadb\bin;c:\fifesdk\python]
2016-12-27 17:42:10.251   Path [c:\fifesdk\python] removed from PATH => [%USERPROFILE%\AppData\Local\Microsoft\WindowsApps;C:\server-086\bin\mariadb\bin]
2016-12-27 17:42:10.251   PATH written
2016-12-27 17:42:10.251   Prepare to remove from Old PATH [%USERPROFILE%\AppData\Local\Microsoft\WindowsApps;C:\server-086\bin\mariadb\bin]

I can confirm that too :)
You are the best jakoch :) I will never let you leave the fife team :P 👍 🥇

I close this here and created an new issue for the default python problem: #14


Tr update pre commit checks 217

Current precommit checks require terraform installed locally, most developers don't need terraform so we should not require it as part of precommit checks.
This pr resolves this issue.
Closes #247

When this pr is in a good place can you schedule 25 mins for us to walk through together @tnrahim? Any open spot on my calendar works.

Woohoo!


[Feature Request] Generate Conv3D results on another set of coordinates?

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Does TorchSparse support generate Conv3D() results on another set of coordinates? Which means calling forward(input, coords), and the output is a sparse tensor with the same coordinates as coords, but the features are computed with corresponding features  on input.

I recommend doing this:
x_A = torchsparse.SparseTensor(feats=feats, coords=coords_A)
x_B = torchsparse.SparseTensor(feats=feats, coords=coords_B)
my_conv_layer = nn.conv(...)
y = my_conv_layer(x_A)
y.C = x_B.C

I recommend doing this:
x_A = torchsparse.SparseTensor(feats=feats, coords=coords_A)
x_B = torchsparse.SparseTensor(feats=feats, coords=coords_B)
my_conv_layer = nn.conv(...)
y = my_conv_layer(x_A)
y.C = x_B.C

Thank you for answering. But maybe I havn't describe my problem clearly enough.
In my case, for each coordinates $C_B^i$ in x_B, I need to find correspoinding points in x_A within the kernel size and centerd in $C_B^i$. Then use their feats to compute with kernel, and the results stored in $F_B^i$. Is this possible?
You code seems to simply change the coordinates of the result on x_A though.

I recommend doing this:
x_A = torchsparse.SparseTensor(feats=feats, coords=coords_A)
x_B = torchsparse.SparseTensor(feats=feats, coords=coords_B)
my_conv_layer = nn.conv(...)
y = my_conv_layer(x_A)
y.C = x_B.C

Thank you for answering. But maybe I havn't describe my problem clearly enough. In my case, for each coordinates C B i in x_B, I need to find correspoinding points in x_A within the kernel size and centerd in C B i . Then use their feats to compute with kernel, and the results stored in F B i . Is this possible? You code seems to simply change the coordinates of the result on x_A though.

Is x_A.C == x_B.C ?

I recommend doing this:
x_A = torchsparse.SparseTensor(feats=feats, coords=coords_A)
x_B = torchsparse.SparseTensor(feats=feats, coords=coords_B)
my_conv_layer = nn.conv(...)
y = my_conv_layer(x_A)
y.C = x_B.C

Thank you for answering. But maybe I havn't describe my problem clearly enough. In my case, for each coordinates C B i in x_B, I need to find correspoinding points in x_A within the kernel size and centerd in C B i . Then use their feats to compute with kernel, and the results stored in F B i . Is this possible? You code seems to simply change the coordinates of the result on x_A though.

Is x_A.C == x_B.C ?

No. They are different coordinates. The purpose of this operation is to transfer the attributes of A to another sets of coordinates B.

@Tortoise0Knight Ok I think this might help?
x_A = torchsparse.SparseTensor(feats=feats, coords=coords_A)
my_conv_layer = nn.conv(...)
y = my_conv_layer(x_A)

#  Apply the attributes of arbitrary tensors y, onto a tensor with coords_B.
X_B = torchsparse.SparseTensor(feats=y.F, coords=coords_B)

@Tortoise0Knight Ok I think this might help?
x_A = torchsparse.SparseTensor(feats=feats, coords=coords_A)
my_conv_layer = nn.conv(...)
y = my_conv_layer(x_A)

#  Apply the attributes of arbitrary tensors y, onto a tensor with coords_B.
X_B = torchsparse.SparseTensor(feats=y.F, coords=coords_B)

Sorry. I think your solution is still not what I want. E.g. the y.F possibly not have the same number of points to coords_B. In that case, we can not create the result tensor.
I think this problem needs implementation from the Engine, not user code. For example, https://nvidia.github.io/MinkowskiEngine/convolution.html#MinkowskiEngine.MinkowskiConvolution.forward

@Tortoise0Knight  I don't understand how you can apply features to a difference number of points. Each point needs to have a feature. Is there another library function that does this?

I think this request refers to the ability to apply a convolution to points that are different from the points of the features.
As far as I understand, torchsparse only supports applying convolutions centered at a set of points x_A using features at x_A (f_A) (red).
But one might be interested in sparse convolutions centered at other points  x_B but still using f_A (blue), creating new features for those points:

I don't know if other libraries do this.

I think this request refers to the ability to apply a convolution to points that are different from the points of the features. As far as I understand, torchsparse only supports applying convolutions centered at a set of points x_A using features at x_A (f_A) (red). But one might be interested in sparse convolutions centered at other points x_B but still using f_A (blue), creating new features for those points:

I don't know if other libraries do this.

Thank you for clear explanation of what I mean. Minkowski Engine actually can do this. In calling https://nvidia.github.io/MinkowskiEngine/convolution.html#MinkowskiEngine.MinkowskiConvolution.forward, you can give coordinates. If not given, the coordinates of input is used (this is the most common case).
The ability to apply convolution on differents sets of coordinates is very useful. It can be used as a NN replacement for traditional feature extraction like KNN, as I tested on Minkowski Engine.

@Tortoise0Knight
Thanks for detailing this. I recommend you do some MinkowskiEngine layer, inside your TorchSparse model. You will have to swap between MinkowskiEngine sparse tensors and TorchSparse sparse tensor, but it will work. I've done this before and the speed is pretty good.


Defect #2902, removing paket.exe from list of files not added to version control.

My first commit to this project. Based on discussion here it seemed like I should remove the reference to paket.exe because that is a file that is needed into source control.
I'm not sure what your current branching strategy is, if you want me to change which branch to merge into let me know.
Let me know if you have any questions, comments or suggestions.

HI, I think it would be better to keep that paragraph, change it a bit and link to https://fsprojects.github.io/Paket/bootstrapper.html#Magic-mode


Bug in detection urls

There is currently a bug in detection urls.
A text like "test..." is detected as a url.

Screenshot...

Perhaps use this RegEx:
r'(?:(?:https?|ftp):\/\/)?[-a-z0-9@:%._\+~#=]{1,256}\.[a-z0-9]{1,6}(\/[-a-zA-Z0-9()@:%_\+.~#?&\/=]*)?'

I wrote a possible solution to this issue in #21

thank you for creating the issue! I just released version 2.3 which should fix this problem by using your regex.


[SPARK-6278][MLLIB] Mention the change of objective in linear regression

As discussed in the RC3 vote thread, we should mention the change of objective in linear regression in the migration guide. @srowen

Test build #28465 has started for   PR 4978 at commit f87ae71.

This patch merges cleanly.

Test build #28465 has finished for   PR 4978 at commit f87ae71.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class KMeansModel (val clusterCenters: Array[Vector]) extends Saveable with Serializable

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28465/
Test PASSed.

Test build #28506 has started for   PR 4978 at commit bfd6cff.

This patch merges cleanly.

Test build #28506 has finished for   PR 4978 at commit bfd6cff.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28506/
Test FAILed.

Test build #28539 has started for   PR 4978 at commit fb3bbe6.

This patch merges cleanly.

Test build #28539 has finished for   PR 4978 at commit fb3bbe6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28539/
Test PASSed.

Merged into master and branch-1.3.