Amplify says it has failed to push, succeeds in pushing

Describe the bug
amplify push says
✖ An error occurred when pushing the resources to the cloud

Cannot read property 'Region' of undefined
An error occured during the push operation: Cannot read property 'Region' of undefined

When, in reality, the stack update was successful.
Amplify CLI Version
Just updated from amplify 3.15 to 4.13.
To Reproduce
amplify push
Expected behavior
When the update is successful, it doesn't say that it wasn't
Full console dump
❯ amplify push
✔ Successfully pulled backend environment NONE from the cloud.

Current Environment: NONE

| Category    | Resource name      | Operation | Provider plugin   |
| ----------- | ------------------ | --------- | ----------------- |
| Function    | testFoo            | Create    | awscloudformation |
| Function    | corpNameLookup     | Update    | awscloudformation |
| Auth        | cognitoab2d7a9c    | No Change | awscloudformation |
| Analytics   | capbase            | No Change | awscloudformation |
| Hosting     | S3AndCloudFront    | No Change | awscloudformation |
| Api         | capbase            | No Change | awscloudformation |
| Storage     | userDocuments      | No Change | awscloudformation |
| Predictions | imageTextExtractor | No Change | awscloudformation |
? Are you sure you want to continue? Yes
⠼ Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS capbase-20181117083404 AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:31 GMT-0500 (Eastern Standard Time) User Initiated
UPDATE_IN_PROGRESS hostingS3AndCloudFront AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:36 GMT-0500 (Eastern Standard Time)
⠇ Updating resources in the cloud. This may take a few minutes...

CREATE_IN_PROGRESS functiontestFoo               AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:36 GMT-0500 (Eastern Standard Time)
UPDATE_IN_PROGRESS storageuserDocuments          AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:36 GMT-0500 (Eastern Standard Time)
UPDATE_IN_PROGRESS analyticscapbase              AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:36 GMT-0500 (Eastern Standard Time)
UPDATE_IN_PROGRESS predictionsimageTextExtractor AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:36 GMT-0500 (Eastern Standard Time)
UPDATE_IN_PROGRESS functioncorpNameLookup        AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:36 GMT-0500 (Eastern Standard Time)
UPDATE_COMPLETE    hostingS3AndCloudFront        AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:37 GMT-0500 (Eastern Standard Time)
⠹ Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS capbase-20181117083404-functioncorpNameLookup-1HE04UNUOTNXN AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:37 GMT-0500 (Eastern Standard Time) User Initiated
⠸ Updating resources in the cloud. This may take a few minutes...

 This may take a few minutes...

CREATE_IN_PROGRESS capbase-20181117083404-functiontestFoo-1XSVEFR5AROBV AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:37 GMT-0500 (Eastern Standard Time) User Initiated
CREATE_IN_PROGRESS LambdaExecutionRole                                  AWS::IAM::Role             Sun Feb 02 2020 18:33:41 GMT-0500 (Eastern Standard Time)
CREATE_IN_PROGRESS LambdaExecutionRole                                  AWS::IAM::Role             Sun Feb 02 2020 18:33:41 GMT-0500 (Eastern Standard Time) Resource creation Initiated
⠏ Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS capbase-20181117083404-apicapbase-1TOT5NZ1RJIJD AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:41 GMT-0500 (Eastern Standard Time) User Initiated
⠙ Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS LambdaFunction AWS::Lambda::Function Sun Feb 02 2020 18:33:42 GMT-0500 (Eastern Standard Time)
⠇ Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS InvestorProspectStatus AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:51 GMT-0500 (Eastern Standard Time)
⠋ Updating resources in the cloud. This may take a few minutes...

UPDATE_COMPLETE LambdaFunction AWS::Lambda::Function Sun Feb 02 2020 18:33:50 GMT-0500 (Eastern Standard Time)
⠹ Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS ObjectReference AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:52 GMT-0500 (Eastern Standard Time)
UPDATE_IN_PROGRESS DummyModel      AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:52 GMT-0500 (Eastern Standard Time)
⠏ Updating resources in the cloud. This may take a few minutes...

CREATE_COMPLETE LambdaExecutionRole AWS::IAM::Role Sun Feb 02 2020 18:33:55 GMT-0500 (Eastern Standard Time)
⠋ Updating resources in the cloud. This may take a few minutes...

 This may take a few minutes...

UPDATE_COMPLETE_CLEANUP_IN_PROGRESS capbase-20181117083404-functioncorpNameLookup-1HE04UNUOTNXN AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:52 GMT-0500 (Eastern Standard Time)
⠴ Updating resources in the cloud. This may take a few minutes...

UPDATE_COMPLETE functioncorpNameLookup AWS::CloudFormation::Stack Sun Feb 02 2020 18:33:59 GMT-0500 (Eastern Standard Time)
⠋ Updating resources in the cloud. This may take a few minutes...

CREATE_IN_PROGRESS LambdaFunction        AWS::Lambda::Function Sun Feb 02 2020 18:33:57 GMT-0500 (Eastern Standard Time)
CREATE_IN_PROGRESS LambdaFunction        AWS::Lambda::Function Sun Feb 02 2020 18:33:58 GMT-0500 (Eastern Standard Time) Resource creation Initiated
CREATE_COMPLETE    LambdaFunction        AWS::Lambda::Function Sun Feb 02 2020 18:33:59 GMT-0500 (Eastern Standard Time)
CREATE_IN_PROGRESS lambdaexecutionpolicy AWS::IAM::Policy      Sun Feb 02 2020 18:34:01 GMT-0500 (Eastern Standard Time)
⠙ Updating resources in the cloud. This may take a few minutes...

 This may take a few minutes...

UPDATE_IN_PROGRESS Invitation                 AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:02 GMT-0500 (Eastern Standard Time)
UPDATE_IN_PROGRESS InvestorContactInvolvement AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:02 GMT-0500 (Eastern Standard Time)
UPDATE_IN_PROGRESS CompanyInquiry             AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:02 GMT-0500 (Eastern Standard Time)
UPDATE_IN_PROGRESS Document                   AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:02 GMT-0500 (Eastern Standard Time)
⠋ Updating resources in the cloud. This may take a few minutes...

CREATE_IN_PROGRESS lambdaexecutionpolicy AWS::IAM::Policy Sun Feb 02 2020 18:34:02 GMT-0500 (Eastern Standard Time) Resource creation Initiated
⠹ Updating resources in the cloud. This may take a few minutes...

 This may take a few minutes...

UPDATE_IN_PROGRESS ConnectionStack2 AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:09 GMT-0500 (Eastern Standard Time)
UPDATE_IN_PROGRESS SearchableStack  AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:10 GMT-0500 (Eastern Standard Time)
UPDATE_IN_PROGRESS ConnectionStack  AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:10 GMT-0500 (Eastern Standard Time)
UPDATE_COMPLETE    ConnectionStack2 AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:10 GMT-0500 (Eastern Standard Time)
UPDATE_COMPLETE    SearchableStack  AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:10 GMT-0500 (Eastern Standard Time)
UPDATE_COMPLETE    ConnectionStack  AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:11 GMT-0500 (Eastern Standard Time)
⠹ Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS CustomResourcesjson AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:16 GMT-0500 (Eastern Standard Time)
UPDATE_COMPLETE    CustomResourcesjson AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:16 GMT-0500 (Eastern Standard Time)

CREATE_COMPLETE lambdaexecutionpolicy AWS::IAM::Policy Sun Feb 02 2020 18:34:15 GMT-0500 (Eastern Standard Time)
⠴ Updating resources in the cloud. This may take a few minutes...

CREATE_COMPLETE capbase-20181117083404-functiontestFoo-1XSVEFR5AROBV AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:17 GMT-0500 (Eastern Standard Time)
⠦ Updating resources in the cloud. This may take a few minutes...

UPDATE_COMPLETE_CLEANUP_IN_PROGRESS capbase-20181117083404-apicapbase-1TOT5NZ1RJIJD AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:21 GMT-0500 (Eastern Standard Time)
⠋ Updating resources in the cloud. This may take a few minutes...

CREATE_COMPLETE functiontestFoo AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:25 GMT-0500 (Eastern Standard Time)
⠙ Updating resources in the cloud. This may take a few minutes...

UPDATE_COMPLETE                     apicapbase             AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:28 GMT-0500 (Eastern Standard Time)
UPDATE_COMPLETE_CLEANUP_IN_PROGRESS capbase-20181117083404 AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:31 GMT-0500 (Eastern Standard Time)
⠹ Updating resources in the cloud. This may take a few minutes...

UPDATE_COMPLETE storageuserDocuments          AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:32 GMT-0500 (Eastern Standard Time)
UPDATE_COMPLETE analyticscapbase              AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:32 GMT-0500 (Eastern Standard Time)
UPDATE_COMPLETE hostingS3AndCloudFront        AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:32 GMT-0500 (Eastern Standard Time)
UPDATE_COMPLETE predictionsimageTextExtractor AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:32 GMT-0500 (Eastern Standard Time)
⠼ Updating resources in the cloud. This may take a few minutes...

UPDATE_COMPLETE functioncorpNameLookup AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:43 GMT-0500 (Eastern Standard Time)
UPDATE_COMPLETE apicapbase             AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:43 GMT-0500 (Eastern Standard Time)
UPDATE_COMPLETE authcognitoab2d7a9c    AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:44 GMT-0500 (Eastern Standard Time)
UPDATE_COMPLETE capbase-20181117083404 AWS::CloudFormation::Stack Sun Feb 02 2020 18:34:45 GMT-0500 (Eastern Standard Time)
✖ An error occurred when pushing the resources to the cloud

Cannot read property 'Region' of undefined
An error occured during the push operation: Cannot read property 'Region' of undefined

Desktop (please complete the following information):

OS: Mac OS
Node Version: 10.16.3

Additional context
I wouldn't be completely shocked if this had something to do with the fact that our environment here is named NONE, since our env predates multienv in amplify

@nagey
Could you open the CloudFormation console,  check the stacks, and see which one of them are in the Failed status? Let's first identify the template that's causing the problem.

@UnleashedMind — well, that's just the thing. All of the stacks are in UPDATE_COMPLETE. Everything is green, no errors.

@nagey I suspect this error comes from the fact that your Amplify App might not be created on the Amplify console. When you move from 3.15 to 4.13, the CLI creates an Amplify app for you which you can view on the Amplify console. Could you please check your amplify/team-provider-info.json and see if you an AmplifyAppID for your environment?

It doesn’t seem to: the team provider info has the following keys:
{
"NONE": {
"awscloudformation": {
"AuthRoleName",
"UnauthRoleArn",
"AuthRoleArn",
"Region",
"DeploymentBucketName",
"UnauthRoleName",
"StackName",
"StackId"
},
"categories": {
"auth": {
"cognitoab2d7a9c"
}
}
},
"undefined": {
"categories": {
"auth": {
"cognitoab2d7a9c"
}
}
}
}
We do have this app setup in the amplify console though, is there a way I can manuallly insert that mapping into this file?
—

On Monday, Feb 10, 2020 at 12:14 AM, Kaustav Ghosh<EMAIL_ADDRESS>(mailto:notifications@github.com)> wrote:
@nagey (https://github.com/nagey) I suspect this error comes from the fact that your Amplify App might not be created on the Amplify console. When you move from 3.15 to 4.13, the CLI creates an Amplify app for you which you can view on the Amplify console. Could you please check your amplify/team-provider-info.json and see if you an AmplifyAppID for your environment?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (https://github.com/aws-amplify/amplify-cli/issues/3322?email_source=notifications&email_token=AAADLQJH2YBGTIKRDTP5F7TRCDPBXA5CNFSM4KO437Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELHIC2I#issuecomment-583958889), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAADLQMCVHASWUQ7VALKB7LRCDPBXANCNFSM4KO437YQ).

The Amplify Console project setup happen after a successful push.
What region did you setup your backend aws resources?

us-east-1

since I replied by email that one time, and it didn't like Markdown…
{
    "NONE": {
        "awscloudformation": {
            "AuthRoleName",
            "UnauthRoleArn",
            "AuthRoleArn",
            "Region": "us-east-1",
            "DeploymentBucketName",
            "UnauthRoleName",
            "StackName",
            "StackId"
        },
        "categories": {
            "auth": {
                "cognitoab2d7a9c"
            }
        }
    },
    "undefined": {
        "categories": {
            "auth": {
                "cognitoab2d7a9c"
            }
        }
    }
}

@nagey Are you still stuck on this?

no — I deleted the undefined env from team provider — though unclear how it got created in the first place

Closing this issue.
You can comment on this issue or open a new issue if it pops up again.

I got the same issue and there was an undefined env in the team provider.

amplify version 4.41.2 the issue has again appeared.

amplify version 4.41.2 the issue has again appeared.


Depend on compat_resource instead of apt and yum cookbooks

This is me clocking off for the holidays. If you want further changes to #88 before merging this one then that's cool. Have a good one. :christmas_tree:

Once everything else is merged, i will make a release, then merge this after

Merging via https://github.com/shortdudey123/chef-gluster/pull/92 since github merge conflict resolution dirties the commit history


Generated tools  SBOM required to build product SBOM

Autogenerated desired SBOM for tool container , based on complete SBOM from product SBOM


Unable to pass options to child_process.exec

I ran into a scenario where the stdOut buffer from one of my git commands (via gittle) exceeds the default maxBuffer size for child_process.exec. If I was able to, I'd pass an option down to gittle to increase the maxBuffer. But currently no such feature exists.

Not sure, but it also looks like I can't pass args to the commit command. Like if I wanted to run as --quiet to suppress copious stdout.


Add a contributors page

Please add a contributors page that would show all the contributors to this repository and add a proper link at the bottom section of the readme.

I would like to work on this!

Go ahead @shreyateeza 😄

i can work pn this issue


knack.util.ensure_dir can cause race conditions

This checks if a directory exists and then calls mkdir to create it. During automation or scripting where parallelism can come into play this can cause a  race condition easily:
knack.util.ensure_dir
def ensure_dir(d):
    """ Create a directory if it doesn't exist """
    if not os.path.isdir(d):
        os.makedirs(d)

To prevent this race condition, use try/expect: to create the  directory, then ignore "File exists" errors, which mean the directory  was there.
 try:
        os.makedirs(path)
except OSError as e:
        if e.errno != errno.EEXIST:
            raise

Or for 3.2+
os.makedirs('/path/to/dir', exist_ok=True)

This looks to be a duplicate of 159

@Swells Isn't this already fixed in #159 using same approach as you suggested?


⚠ Processors has degraded performance

In 11888bd, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 50 ms

Resolved: Processors performance has improved in bcac340.


Reduce impact of LSP color listener by default.

@predragnikolic: Noticed while closing views after find-replace in pyls:
Traceback (most recent call last):
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime_plugin.py", line 506, in run_async_view_listener_callback
    vel.__class__.__dict__[name](vel)
  File "/Users/tomv/Library/Application Support/Sublime Text 3/Packages/LSP/plugin/color.py", line 47, in on_activated_async
    self.schedule_request()
  File "/Users/tomv/Library/Application Support/Sublime Text 3/Packages/LSP/plugin/color.py", line 53, in schedule_request
    current_point = self.view.sel()[0].begin()
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime.py", line 649, in __getitem__
    raise IndexError()
IndexError

We should probably fix the above issue (maybe it's rare but I ran into this edge case pretty quickly)
We could avoid creating ViewEventListeners for a few kinds of irrelevant views: Read-only, transient, unsupported syntaxes ( Maybe DocumentSyncListener is_applicable is suitable?)
We could avoid running LspColorListener's schedule_request until a session with colorProvider for a given view has been found.

Hello @tomv564 .
Can you tell me what steps do I need to take to get that error?
I have been trying to reproduce it, but I didn't succeed.

Sorry, it should be a "replace in files".
Replace all 'debug' with 'dbg' in all of LSP.
Close these these files (ctrl-w or cmd-w) selecting "Don't Save" and you should see the error.

Thanks, I reproduced it. Now I can work on a fix.

I fixed the IndexError.

The schedule_request is not called until a session is found.

Added a is_supported_syntax check to is_applicable method in LspColorListener.

What I didn't do from the above is:
"avoid creating ViewEventListeners for a few kinds of irrelevant views: Read-only, transient".
Why the need to avoid Read-only and transient views?


feat: added support for embeddings via HuggingFace Inference API

Added support for generating embeddings via the HuggingFace Inference API. The same exists in the Python version but missing in LlamaIndexTS.

@tasmay looks good, please resolve conflicts, then we can merge it

Done. Thanks @marcusschiesser and @himself65


Please add interface to create buttons

https://api.slack.com/docs/message-buttons
Basically attachment needs:

set/getFallback
set/getCallbackId
addAction(array)
getActions

Ping, any comment on that? )

@cleentfaar , I see that the last commit was made year ago. It this library active or abandoned?


[DO NOT MERGE] Add publication groups 1 and 2

https://trello.com/c/t1OsZPiN/1494-identify-changes-to-how-to-guidance-based-on-publications-workflow-and-draft-them
We need to tell users that they can create publications with file attachments in Content Publisher when we've released them.

Adding a "DO NOT MERGE" flag as these shouldn't be merged until we can release Publications.

Decided to close this since it's no longer active work, due to the project being paused.


ImportError

ImportError                               Traceback (most recent call last)
 in <cell line: 14>()
12 import librosa
13 import note_seq
---> 14 import seqio
15 import t5
16 import t5x
5 frames
/usr/local/lib/python3.10/dist-packages/flax/core/axes_scan.py in
20 from jax import core
21 from jax import lax
---> 22 from jax.extend import linear_util as lu
23 from jax.interpreters import partial_eval as pe
24 import jax.numpy as jnp
ImportError: cannot import name 'linear_util' from 'jax.extend' (/usr/local/lib/python3.10/dist-packages/jax/extend/init.py)

NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.
To view examples of installing some common dependencies, click the
"Open Examples" button below.

I encountered the same problem.

The module seqio seems to be inconsistent with jax (before the change ?).
I fixed it with the following code for now:
import jax.linear_util
jax.extend.linear_util = jax.linear_util

该模块seqio似乎与jax（更改之前？）不一致。 我现在用以下代码修复了它：
import jax.linear_util
jax.extend.linear_util = jax.linear_util

How do you use it on colab?
I don known how to replace the code in module seqio on colab.
I try to install jax 0.4.11 instead, but falled.

How do you use it on colab?

"Setup Environment" installs jax and "Imports and Definitions" imports seqio; so add a code cell between them.

And sorry, I misstyped the code above.

你如何在 Colab 上使用它？

“Setup Environment”安装jax和“Imports and Definitions”导入seqio；所以在它们之间添加一个代码单元。

抱歉，我输错了上面的代码。（不过，由于我的会议，import jax.linear_util可能也是必要的。）

TKS


Tomoz/support inverse modulation

Codecov Report

Merging #21 (25c5e53) into master (abbc62c) will increase coverage by 3.11%.
The diff coverage is 47.61%.

:exclamation: Current head 25c5e53 differs from pull request most recent head 5670998. Consider uploading reports for the commit 5670998 to get more accurate results

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage    6.96%   10.07%   +3.11%
==========================================
  Files          24       25       +1
  Lines        1020     1052      +32
==========================================
+ Hits           71      106      +35
+ Misses        949      946       -3

Impacted Files
Coverage Δ

src/event.jl
12.19% <ø> (+12.19%)
:arrow_up:

src/event_execution.jl
0.00% <ø> (ø)

src/params/age_coupling.jl
5.00% <0.00%> (-1.67%)
:arrow_down:

src/params/outside_cases.jl
0.00% <0.00%> (ø)

src/params/strains.jl
0.00% <ø> (ø)

src/simparams.jl
0.00% <ø> (ø)

src/simstate.jl
0.00% <ø> (ø)

src/params/modulations.jl
96.55% <100.00%> (+96.55%)
:arrow_up:

src/utils/population_grouping.jl
72.72% <100.00%> (+2.72%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abbc62c...5670998. Read the comment docs.


Fix GlobalBuildInfoPlugin for Gradle 8.8 compatibility

Description
Fixes GlobalBuildInfoPlugin usage of a deprecated constructor removed in Gradle 8.8.
Related Issues
Resolves #13921
Check List

~[ ] New functionality includes testing.~

~[ ] All tests pass~

~[ ] New functionality has been documented.~

~[ ] New functionality has javadoc added~

~[ ] API changes companion pull request created.~
~[ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)~
[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
~[ ] Public documentation issue/PR created~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Actually this fix doesn't work. They removed all public constructors, there are static builders present, but they are not compatible with earlier gradle versions. How do we handle this?

Thanks @dbwiddis , there is a pull request already https://github.com/opensearch-project/OpenSearch/pull/13584 but need more work to replace fileCollection API

Thanks @dbwiddis , there is a pull request already #13584

Apparently my search-fu didn't work very well past midnight last night.  I'll close this PR.


Audit Oauth2 Access Token Requests

Coverage decreased (-0.02%) to 45.296% when pulling 980b5259811010cd9f8a4ba6eb1656a14069e4f2 on oauth2-request-audit into bd2030e62cc637172eebf7a4dd9cb14b0f9cfdaa on master.


Project Sample for This Section

Type of issue
Missing information
Feedback
Could you provide a sample code snippet on this page?
Page URL
https://learn.microsoft.com/en-us/microsoftteams/platform/tabs/open-content-in-stageview?tabs=modal#stageview-multi-window
Content source URL
https://github.com/MicrosoftDocs/msteams-docs/blob/main/msteams-platform/tabs/open-content-in-stageview.md
Author
@Rajeshwari-v
Document Id
7b685a2e-18e0-a401-e44f-905a47d2415d

@joylin2024 - Thanks for reporting your issue. We will check this and update you soon.

Great, I look forward to receiving more information soon!

@joylin2024 -
The description and code are already provided in the document.
To open the stageview multi-window, you have two options: via the stageview API or deeplink.

For both the stageview API and deeplink, you need to use the openMode property.

To open the stageview multi-window, you need to set the openMode property to popout.
Please refer below sample for implementation:
https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/ed44552e419f6fbc4910d6bec92cf13700a184c4/samples/tab-stage-view/csharp/TabInStageView/Views/Home/SampleTab.cshtml#L46C18-L46C24
@surbhigupta12 - Could you please add the Code sample section for this document and add below .Net and Node.js sample link in that section?
csharpt sample link: https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/tab-stage-view/csharp
nodeJS sample link: https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/tab-stage-view/nodejs

Stageview Multi-window activates during meetings when the host clicks the 'Share to Stage' button, causing the multi-window to pop up on the guests' screens?

@joylin2024 - We are checking this with engineering team. We will let you know once we get any updates from them.

I appreciate the update.

Does StageView multi-window activation occur during meetings when the host clicks the 'Share to Stage' button, causing the multi-window to open on the guests' screens?

Could you please clarify this? I'm not sure which scenario you are describing. Could you please provide snapshots and videos? It will help us understand better.

Hi, please refer to the image below. When the host clicks the 'Start Sharing' button, the window will split into two panels: one for the guest to view the host’s screen and another dedicated to user engagement.

@joylin2024 - Apologies for the delay. We are checking this with engineering team, we will update you soon.

Great. Thanks!


digiKam can't find exiftool

Describe the bug
The following message appears whenever I start digiKam:

ExifTool is not available in your digiKam installation or is not working correctly. Go to the digiKam settings and check the availability of the ExifTool binary file in the metadata section.
Error message: ExifTool does not exists or exec permission is missing

Steps To Reproduce
Steps to reproduce the behavior:

Install digiKam from current unstable
Run digiKam

Expected behavior
All tools necessary for digiKam should be in its derivation.
Screenshots

Notify maintainers
@pbsds @emilazy @bnapolitano
Metadata

system: "x86_64-linux"
host os: Linux 6.10.2, NixOS, 24.11 (Vicuna), 24.11pre661606.d04953086551
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.18.5
channels(root): "nixos, nixos-hardware"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Add a :+1: reaction to issues you find important.

Hmm, it’s never had ExifTool in the $PATH so this at least shouldn’t be my fault. It might be as simple as just adding it here. Looks like we could also patch exiftoolbinary.cpp.

It looks like it's been reporting "ExifTool process cannot be started" since at least 179fee08738e934995dae7771ec81be9f2c6023c.

I'm experiencing the same error message on Windows 10 with DigiKam 8.4.0. The v.8.3.0 didn't show the error.
Even trying to add the exiftool.exe located in the DigiKam installation folder doesn't work.

I encountered the same problem in digikam 8.5.0. How can I solve it?

I encountered the same problem in digikam 8.5.0. How can I solve it?

In my case the exiftool was indeed not installed.
in case of Debian you need to do
sudo apt install libimage-exiftool-perl

Thanks.


Extract tiles from Composite tiles

Add a stage to recursively extract tiles from composite tiles, including support for composites of composites.

Functions added in #42.  CLI extracts glbs.


Listen to error and complete events

This fixes the issue as discussed in #73

[x] The test/helper must be updated to emit error and complete events to restore tests to passing.

CI Build: https://travis-ci.org/pro-src/cloudflare-scrape/builds/501311699?utm_medium=notification&utm_source=email

@codemanki, I apologize again for letting this slip by me. I was solely relying on the unit tests to verify that everything was working properly but it's fixed now! :stuck_out_tongue_winking_eye:

Thanks so much :) !


Repo-wide cleanup of mention and artifacts after test recordings were moved out

With the test recording json file clean-up and move effort (done in https://github.com/Azure/azure-sdk-for-cpp/pull/4118), there are remnants of a few files/artifacts related to test recordings that can be cleaned-up now.
This isn't an exhaustive list, but it is start of what to fix:

Do we still need AZURE_TEST_RECORDING_DIR?
For example, see:
https://github.com/Azure/azure-sdk-for-cpp/blob/efee11268ec3e0dcf98dea8d3c5f2abc5c529f41/sdk/keyvault/azure-security-keyvault-administration/test/ut/CMakeLists.txt#L12-L13
We can remove the opt-out for cspell since those directories don't exist:
https://github.com/Azure/azure-sdk-for-cpp/blob/efee11268ec3e0dcf98dea8d3c5f2abc5c529f41/.vscode/cspell.json#L28
The contributing guide still mentions the use of a /recordings folder:
https://github.com/Azure/azure-sdk-for-cpp/blob/main/CONTRIBUTING.md#test-mode

All the AZURE service network responses are recorded in a json file within the /recordings folder from the /test/ut directory.

AZURE_TEST_RECORDING_DIR is actually used to determine the path where the test proxy stores the recordings, to give it the relative path where to  recording is stored, so we actually need it.

and 3. addressed


Research calendar links and scheduling UX

Building on #832, I'd love to see confirmation of a scheduled meeting in the conversation UI.
To start, this is more of a research project.
Is it possible to get a URL of sorts for a meeting? And if so, can we "subscribe" to that for changes? That would be great to sync into a native UI element to show both parties of the scheduled meeting.
If not, what is the minimum UI required to collect meeting information from the business after they schedule something? Date, time, and meeting URL maybe? Presenting that as a modal after clicking "Schedule a meeting" could be a quick win. With the option to edit, of course.
I'm open to ideas on this one - so let me know if you've done this before or have suggestions.
I'm not looking for concrete code or even a PR just yet. I want to figure out what can be done before deciding which direction to take this.

@joemasilotti 👋🏻 I have some insight on this, happy to do some more research on the topic! TY

Sounds great, thank you @kat-s92!

@joemasilotti 👋🏻
Please see below, I hope it's helpful!
Is it possible to get a URL of sorts for a meeting? And if so, can we "subscribe" to that for changes?
Calendly and SavyCal both generate a one-time link for the meeting event and redirect to a sort of custom event event page. It is not possible to "subscribe" to the changes made to the event, every time a meeting is rescheduled, the other person receives an email with the change confirmation or another form of confirmation like text message. (Interesting side note, although not super useful in our case: [https://prnt.sc/fto_mV13MqsS])
**What is the minimum UI required to collect meeting information from the business after they schedule something? **
From many years of experience in scheduling interviews, I would say you'd need Names, Date + Time, Time Zone, meeting URL. I would include the duration of the meeting too.
If I understand correctly, if there is no dynamic way to access the meeting info / keep up with the meeting changes, you would like to ask the users to input the meeting info after they have scheduled the call via their respective scheduling tools?
If so, it might get tricky with rescheduling of meetings, as every time they need to reschedule (which ofc they ideally would not be) a meeting via Calendly/SavyCal, they would also need to edit it on RailsDevs.
It might be an option to just have a UI element like a checkbox where they can confirm that a meeting has been scheduled and display something like "intro call scheduled" to both parties in their chat (I think you have the idea of showing this in the chat from what I read in the other issues)
Please lmk what else you need to research on this.
TY


Demo additional python decorator

@BorisTasevski Can this be closed, since this was pretty early & implementation might be more suitable for memgraph/memgraph?

@BorisTasevski one more ping whether this can be closed.


Build fixes/debugging instrumentation

This hotfixes a number of build issues encountered while debugging #195, published as requested in that thread.
It is not:

well written
tested beyond reproducing #195
working well to reproduce #195
up to date with current requirements

This updates the Minimum SDK version to v14 (Ice Cream Sandwich), so any users on older devices will be unable to use the app from this point onwards. Given those devices are 6-7 years old at this point I suspect that is reasonable, but exactly how that affects the current userbase is something you'll only be able to see from the Google Play Console.
It also updates the target API version to 25, which as of 2018-10-31 was sufficient to build, while not introducing the extra dependencies within AccountManager for access to accounts, and also sufficiently new for the app to be publishable in the Play store. However, "from November" (it's unclear which end of November), it appears the minimum will become API 26 which introduces further requirements - see https://developer.android.com/about/versions/oreo/android-8.0-changes#aaad for more information here. This basically means that my change to UserHelper will need to be further modified once the API version is pushed to 26. Note that the dependencies for the support libraries will also need to be updated with the move to API 26.
It's also worth noting that my changes to UserHelper work only on the second attempt - the first attempt is used to get the permission, then the next launch manages to successfully use that permission - it's clunky but workable for development/debugging.
I'm also throwing a generic Exception in GCMIntentService - this is bad and I should be using a more specific exception, but it's debugging code so hey. I'll leave this to you to fix if GCM is vanishing.
The changes to IrssiNotifierActivity to move off Sherlock and onto AppCompat are completely untested, as I can't get that far into the app. It compiles though, so it's unlikely to be too broken. Likewise
with the theme updates to AppCompat, it's mostly untested apart from the registration screen appears to me mostly OK; message boxes render interestingly.

Thanks! I'll start merging the stuff and testing the issue on this weekend.
There's bunch of other PRs too in the backlog which I've been neglecting, I guess it's time to clean this project up a bit.

Working from your base helped a lot, thanks. The UI broke down a little bit with the removal of ActionBarSherlock which I'll need to fix, and we have to drop support for Android 2.x but I guess that's pretty whatever at this year.


⚠ Mitsubishi has degraded performance

In 4b17d44, Mitsubishi (https://mitsubishimotorsid-mobileapp.com/app/login) experienced degraded performance:

HTTP code: 200
Response time: 5971 ms

Resolved: Mitsubishi performance has improved in 279bdab after 1 minute.


Serverless webhook always crashes initially

Description
Investigate why serverless webhook always crashes initially. After restart it works.
Also - it starts considerably long
Steps to reproduce
Deploy kyma cluster essentials:
kyma provision k3d
kyma deploy -s main --component cluster-essentials

Install serverless-manager
kubectl apply - f https://github.com/kyma-project/serverless-manager/releases/latest/download/serverless-manager.yaml

Apply sample serverless CR
kubectl apply - f https://raw.githubusercontent.com/kyma-project/serverless-manager/main/config/samples/operator_v1alpha1_serverless_k3d.yaml

Observe restart of webhook:
kubectl get pods -n kyma-system -w                                                                                NAME                                                     READY   STATUS    RESTARTS   AGE
serverless-manager-controller-manager-7ff5c47c69-7wwsd   2/2     Running   0          28s
serverless-ctrl-mngr-57b9466f65-rhr8r                    0/1     Running   0          9s
serverless-webhook-svc-558bdb78c6-bk88k                  0/1     Running   0          9s
serverless-webhook-svc-558bdb78c6-bk88k                  0/1     Error     0          13s
serverless-webhook-svc-558bdb78c6-bk88k                  0/1     Running   1 (1s ago)   14s

Error log
{"level":"ERROR","timestamp":"2023-03-22T08:41:24Z","caller":"webhook/main.go:107","message":"failed to read caBundle file: /tmp/k8s-webhook-server/serving-certs/server-cert.pem: open /tmp/k8s-webhook-server/serving-certs/server-cert.pem: no such file or directoryfailed to setup certificates and webhook secret","context":{}}

Attachment
Alternatively follow steps described in the scenario
https://killercoda.com/kyma-project/scenario/serverless
Related
Depends on https://github.com/kyma-project/serverless-manager/issues/7

Actually it fails now permanently (at least on killercoda)

Blocked because we want check if we need webhook at all
https://github.com/kyma-project/kyma/issues/17562

Closing in favor of #247


Add ability to customize compression level.

As transfers times are often the bottleneck, would be nice if it was possible to pass custom arguments to zstd compression (like -19 or even -U -30) and trade compute for storage space.

I'd be weary of adding too many customization options especially if we decide to not use zstd at some point.
FWIW it is possible to disable the default behavior by setting doInstallCargoArtifacts = false; and then using your own hook to do the compression.
It's not ergonomic, but I'd like to at least explore alternatives for optimizing the build artifacts #74 before we add more configurations here


.travis.yml: add oraclejdk9

Coverage increased (+0.01%) to 95.18% when pulling 6b119a59589c5b66c18cbef7f8e7b8c8ec82c7ca on PascalSchumacher:add_jdk9_to_travis into daeed97201c060563c9509e7d63b23094cb31664 on apache:master.

Coverage increased (+0.01%) to 95.18% when pulling ab27ff788a3193aa1c985ffa146fc987afc6fbbb on PascalSchumacher:add_jdk9_to_travis into daeed97201c060563c9509e7d63b23094cb31664 on apache:master.

Coverage increased (+0.01%) to 95.18% when pulling 2055a7d929a83b6edfae1e1c1414dd4b55d8e803 on PascalSchumacher:add_jdk9_to_travis into daeed97201c060563c9509e7d63b23094cb31664 on apache:master.

Coverage increased (+0.01%) to 95.18% when pulling 2055a7d929a83b6edfae1e1c1414dd4b55d8e803 on PascalSchumacher:add_jdk9_to_travis into daeed97201c060563c9509e7d63b23094cb31664 on apache:master.


[BUG]

Hello ，I found a problem
When the keyboard pops up and the font color or background color is selected, the palette display is incomplete

Thanks for the report, I fixed this - now the keyboard will be hidden when pressing the color button if the keyboard is active

Which version fixes this problem? I use 2.2.0

You'd have to use a git dependency on master , I didn't push it to a version yet

Sorry I just realized, git dependency on the 2.2.0-dev.1 branch :)

How can I hide the keyboard when pressing the color button?


implementation new Vue option 'guard' which supported listen data before...

... change event

This has some overlap with write filters - although my general opinion remains that Vue data objects should behave just like plain objects and manipulating it should not give you surprises (i.e. if I set a.b = 123 I expect a.b === 123)

I'm glad to discuss all  with you. For save my English. Could you added my QQ 624998961


ens

Seems like you are plagiarizing #46 . If no further explanation is given, this PR will be closed.

If not needed,Close this!

https://github.com/NextDotID/proof_server/pull/71

Add the slack platform support https://github.com/NextDotID/proof_server/pull/71


Initial support for Mac OS

This commit should provide initial support for Mac OS. It requires pngpaste to work.
Is the doc file generated automatically from the README? If so, could you please tell me how? If not, I'll update it as well.

No I write the doc manually

No worries, it's not even been one day!
Would you be interested in merging this? If so, I'll update the docs as well.

Yes please

@ekickx I have updated the docs.

Lgtm. Thank you for the PR

Also if you can, please use semantic/conventional commit message.

@ekickx Done.
Feedback is very welcome (this is my first lua patch). Otherwise this should be ready for merging.

Merged. Thanks for your PR


Increase max size of request to accomodate for large files

Addresses issue of having large customs descriptions input file: https://app.clubhouse.io/flow/story/16482/imports-improve-error-for-too-large-files
Solution found here: https://stackoverflow.com/questions/36283702/playframework-2-4-6-error-413-request-entity-too-large

@jlogeart thoughts on this change? Alternative I see is to force people to upload to s3 and send us a URL (vs. taking up a thread in proxy).... want to be sure we feel okay supporting long term

Lgtm as quick fix.
Should we consider sending the file as an octet stream and streaming the content provided that we do not need the full content in memory?

@mbryzek I don't think we can expect people to upload to s3 first... long term, that feels annoying.
@jlogeart like that idea, not sure how to do it yet right now

Lgtm
On Fri, Mar 8, 2019 at 7:23 PM Paolo Lim<EMAIL_ADDRESS>wrote:

@mbryzek https://github.com/mbryzek I don't think we can expect people
to upload to s3 first... long term, that feels annoying.
@jlogeart https://github.com/jlogeart like that idea, not sure how to
do it yet right now
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flowvault/proxy/pull/377#issuecomment-471123524, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADC04fbgePsF0Lb056ziRL9BAglFhgOks5vUv8TgaJpZM4bmGUw
.

--
*MICHAEL BRYZEK - *Founder / CTO
m.917.494.1197 <917.693.6074>  |  www.flow.io
Global Ecommerce now has Flow


asymptote program file

Asymptote searches $HOME/.asy if $ASYMPTOTE_HOME is not set. This provides the details for setting that environment variable.
Source: Asymptote Documentation Section 2.5

Thanks!


MSSQL Support

Hi Toni,
Could you explain the "high level" process to include MSSQL support (or others) in Alfresco BART?
We are interested to collaborate with you to include this enhacement.
Kind regards!

Hi Javi, no plans to include MSSQL at this time since Bart only works in Linux. Do you think it worth it to include it in for linux?

Hi Toni, I managed to make it works on linux. In a few days I'll share the integration.
Regards!

@JavierMartinezRojo Any news about this?

@JavierMartinezRojo Any news about this?

Hi @douglascrp .. I need to check if we applied it to a customer but, in ensence :

You will need mssql-cli on linux -> https://docs.microsoft.com/es-es/sql/tools/mssql-cli?view=sql-server-ver15
You will need to share the folder where the DB is stored in MSSQL Server, to be accesible from BART script.
Disclaimer : I don't remember if incremental backups are working correctly with this strategy.

KR!

I see.
Well, feel free to create a PR if you think it is possible.
If not, I think we can close this.


Changing TS highlight priority

I'm not sure if this is something tokyonight has under control, but what I'm trying to do is the following:
I want to color @error

However, if I try to do it like this:
        hl["@error"] = { fg = c.red }

It doesn't change anything because @punctuation.delimiter is taking priority. If I change the bg of error, for example, it works (probably because @punctuation.delimiter doesn't have a bg set.
I tried manually setting both to see if the order changes something, but the result is always the same:

I'm unsure if this is because tokyonight sets TS colors after the on_highlights or if this priority is happening inside TS.
In any case, is there a known way to change this priority?

This is a Treesitter / Neovim problem. There's currently no way to set priorities of the highlight groups. The last group applied will take precedence.
You could set {sp = "red", undercurl=true} for example. I might actually add that to tokyonight as a default.


Nominating Christopher Horrell @chorrell to the Docker WG

In #58 @pesho brought up that Christopher should be invited to the Docker Working Group, and I could not agree more! I reached out to Christopher, and he replied positively when I asked if he would like to join the Docker Working Group.
For those who do not know Christopher, he works as Solutions Engineering Manager at Joyent and has been maintaining the official node Docker image @ joyent/docker-node. Christopher has a lot of experience with maintaining and testing container images and I believe he will be a valuable addition to the Working Group.

:+1:

+1

Ping @jlmitch5 and @wblankenship

sounds good!  :)

According to the Governance bylaws we need a unanimous consensus for adding new members to the working group. Ping @wblankenship

The governance doc is a copy of an earlier version of the core governance document. You should probably take the latest one (which does not require unanimous consent) because the unanimous consensus thing is super annoying and unnecessary. Also, in a consensus seeking system even if you require "unanimous consent" that could be interpreted to mean that if anyone objects it doesn't pass but by no means should you require every single person to vote in the affirmative, that's just process for the sake of process and should be avoided if possible.

I agree with @mikeal. I think everyone in the WG have had plenty of time to voice their opinion on this issue. I will merge this by the end of today unless anyone disagrees.
I will PR an updated governance doc with the current core governance policy.

I will PR an updated governance doc with the current core governance policy.

Thanks for that!

I agree with @mikeal. I think everyone in the WG have had plenty of time to voice their opinion on this issue. I will merge this by the end of today unless anyone disagrees.

While I agree in general, merging this now is technically a violation of our current governance policy. As there is no rush, it would be better to first update the policy, and then do the merge (unless @wblankenship votes as well, of course).

While I agree in general, merging this now is technically a violation of our current governance policy.

That depends on how you interpret the rule. The default rule for decision making is consensus seeking with a majority vote if a consensus cannot be reached. This old amendment to that rule doesn't clearly state whether it's amending the entire consensus seeking process or just the majority vote when a consensus cannot be reached. I would interpret this as the latter and continue to use lazy consensus seeking without unanimous affirmative approval and just treat any dissent as a lack of unanimity.
BTW, this is one of the few parts of the governance document I didn't write so I can't speak to the original intention. I actually consider the entire provision a bad idea which is why I proposed, and the TSC approved, removing it from the TSC governance.

Sorry yall.
:+1:
:+1: to updating the governance doc as well

We have reached consensus- merging. Welcome to the Working Group @chorrell!

@chorrell should also be added to the @nodejs/docker team. @mikeal, can you do that?

:smiley:

Heh, I was a little bit concerned that this whole thread had gone 100%
without Christopher chiming in; glad to see he's on board, too. :+1:

Yep!


[Improvement-4069][server] When the tenant does not exist, the task execution should throw an exception

#4069
What is the purpose of the pull request
When the workflow task node executes, if the tenant does not exist, the worker Task should not create the tenant, but throw an exception and the task ends.
Brief change log
When the workflow task node executes, if the tenant does not exist, the Worker Task prints the log and returns it
Verify this pull request
This pull request is already covered by existing tests

pull request的目的是什么
工作流任务节点在执行时，如果租户不存在，worker task不应该去创建租户，而是抛出异常，任务结束。
简短的更改日志
工作流任务节点在执行时，如果租户不存在，worker task打印日志，返回
验证此pull request
此拉取请求已被现有测试覆盖

Codecov Report

Merging #4108 (db99822) into dev (145314b) will decrease coverage by 0.12%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                dev    #4108      +/-   ##
============================================
- Coverage     39.58%   39.46%   -0.13%
+ Complexity     2995     2991       -4
============================================
  Files           467      467
  Lines         22138    22128      -10
  Branches       2714     2713       -1
============================================
- Hits           8763     8732      -31
- Misses        12559    12580      +21
  Partials        816      816

Impacted Files
Coverage Δ
Complexity Δ

...pache/dolphinscheduler/common/utils/FileUtils.java
29.62% <ø> (+0.70%)
9.00 <0.00> (ø)

.../server/worker/processor/TaskExecuteProcessor.java
26.56% <50.00%> (-40.66%)
3.00 <0.00> (-2.00)

...apache/dolphinscheduler/server/utils/LogUtils.java
81.25% <0.00%> (-6.25%)
6.00% <0.00%> (-1.00%)

...inscheduler/service/zk/CuratorZookeeperClient.java
60.97% <0.00%> (-4.88%)
7.00% <0.00%> (-1.00%)

...inscheduler/server/worker/config/WorkerConfig.java
11.11% <0.00%> (-3.71%)
3.00% <0.00%> (-1.00%)

...inscheduler/common/task/sqoop/SqoopParameters.java
74.00% <0.00%> (-2.00%)
25.00% <0.00%> (ø%)

...er/master/dispatch/host/assign/RandomSelector.java
83.33% <0.00%> (+5.55%)
4.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 145314b...db99822. Read the comment docs.

local test results:


[BUG] com.azure:azure-storage-file-datalake.12.12.1 library not usable with Spring boot 2.7.3

Describe the bug
I am developing a application with  Spring boot 2.7.3 and azure-storage-file-datalake.12.12.1. Compiling the application is failing with error. Look like transitive dependencies are not getting resolved.

cannot access com.azure.core.client.traits.TokenCredentialTrait class file for com.azure.core.client.traits.TokenCredentialTrait not found

There is also a

WARNING The POM for com.azure:azure-storage-file-datalake:jar:12.12.1 is invalid, transitive dependencies (if any) will not be available

Exception or Stack Trace
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] cannot access com.azure.core.client.traits.TokenCredentialTrait
class file for com.azure.core.client.traits.TokenCredentialTrait not found
[ERROR] cannot access com.azure.core.client.traits.AzureNamedKeyCredentialTrait
class file for com.azure.core.client.traits.AzureNamedKeyCredentialTrait not found
[INFO] 2 errors
To Reproduce
Steps to reproduce the behavior: Simple application with Springboot 2.7.3 and com.azure:azure-storage-file-datalake.12.12.1 as dependency
Code Snippet
@Bean
	public DataLakeFileSystemClient getDataLakeFileSystemClient (@Qualifier("adlsg2") Properties properties) {
		return new DataLakeFileSystemClientBuilder()
				.endpoint(properties.getProperty("endpoint"))
				.sasToken(properties.getProperty("sasToken"))
				.fileSystemName(properties.getProperty("fileSystemName"))
				.buildClient();
	}

Expected behavior
Able compile the run the application
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):

OS: Windows 10
IDE: Eclipse
Library/Libraries: [e.g. com.azure:azure-core:1.16.0 (groupId:artifactId:version)]
Java version: 11
App Server/Environment: Tomcat
Frameworks: Spring Boot 2.7.3

If you suspect a dependency version mismatch (e.g. you see NoClassDefFoundError, NoSuchMethodError or similar), please check out Troubleshoot dependency version conflict article first. If it doesn't provide solution for the problem, please provide:

verbose dependency tree (mvn dependency:tree -Dverbose)
exception message, full stack trace, and any available logs

Additional context
Add any other context about the problem here.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[ ] Bug Description Added
[ ] Repro Steps Added
[ ] Setup information Added

Thanks for filing this issue @vmaroli.
Do you have any details on what is causing the azure-storage-file-datalake POM to be considered invalid? I've also found this StackOverflow post around invalid POMs, could you see if the solution there can help resolve this issue?

Thanks for the quick response. The StackOverflow post helped me resolving the issue. Problem was that, I had an obsolete parent pom.xml in my local


When deploying the contract using typescript code, the variables are not initialized, but there is no problem using npx fuels deploy

What version of fuels-ts are you using?
0.89.1
Steps to Reproduce
https://github.com/bookswapxyz/fuel-swap/blob/main/AMM/exchange-contract/src/main.sw
storage {
    liquidity_pool_supply: u64 = 0
}

#[storage(read)]
fn test1() {
    log(storage.liquidity_pool_supply.read());
}

#[storage(read)]
fn test2() {
    log(storage.liquidity_pool_supply.try_read());
}

deploy the exchange-contract with yarn start --task=createPool, and then check it with yarn start --task=test1, yarn start --task=test2,
Expected Behavior
yarn start --task=test1, yarn start --task=test2 not return exception
Actual Behavior
yarn start --task=test1

returns exception like this:
  return new FuelError(ErrorCode.SCRIPT_REVERTED, errorMessage, metadata);
         ^
_FuelError: The transaction reverted with an unknown reason: 0
    at extractTxError (/home/cherideal/work/ShareWin/fuel-swap/Play-Ground/node_modules/@fuel-ts/account/src/providers/utils/extract-tx-error.ts:128:10)
    at _Provider.extractDryRunError (/home/cherideal/work/ShareWin/fuel-swap/Play-Ground/node_modules/@fuel-ts/account/src/providers/provider.ts:1803:12)
    at _Provider.getTransactionCost (/home/cherideal/work/ShareWin/fuel-swap/Play-Ground/node_modules/@fuel-ts/account/src/providers/provider.ts:1176:20)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async FunctionInvocationScope.getTransactionCost (/home/cherideal/work/ShareWin/fuel-swap/Play-Ground/node_modules/@fuel-ts/program/src/functions/base-invocation-scope.ts:230:20)
    at async FunctionInvocationScope.fundWithRequiredCoins (/home/cherideal/work/ShareWin/fuel-swap/Play-Ground/node_modules/@fuel-ts/program/src/functions/base-invocation-scope.ts:248:20)
    at async FunctionInvocationScope.simulate (/home/cherideal/work/ShareWin/fuel-swap/Play-Ground/node_modules/@fuel-ts/program/src/functions/base-invocation-scope.ts:396:32) {
  VERSIONS: { FORC: '0.60.0', FUEL_CORE: '0.27.0', FUELS: '0.89.1' },
  metadata: {
    logs: [],
    receipts: [ [Object], [Object], [Object] ],
    panic: false,
    revert: true,
    reason: 'unknown'
  },
  code: 'script-reverted'
}

Hey @cherideal I suspect this may be because the pool wasn't initialized, after running

Hey @cherideal I suspect this may be because the pool was not initialized, after running
yarn start --task=initPool

then running
yarn start --task=test1

I got the following output
fuel19ztwgeul8yzffsr0df0me8kk8vtr5xpnwlkup79aksv8m47m9h0qdxlfru
0xf8f8b6283d7fa5b672b530cbb84fcccb4ff8dc40f8176ef4544ddb1f1952ad07 1929679
test1 done
0x580085ecb00ce878a662d19582a5d40cbe4417184f2514ed427c937ce4f50781 test USD tUSD 6
0x299ea939953a56ab887dc663140b7b65da4be47851eb5f216d5201290cdae30d test BTC tBTC 10
{
  tokenContract: '0xf1ea11be20f8d6d7a30ff69f21bffc1a95910e0459b03fbdd5c5070f4f48f82d',
  tokens: [
    {
      assetId: '0x580085ecb00ce878a662d19582a5d40cbe4417184f2514ed427c937ce4f50781',
      subId: '0x0000000000000000000000000000000000000000000000000000000000000000',
      name: 'test USD',
      symbol: 'tUSD',
      decimals: 6
    },
    {
      assetId: '0x299ea939953a56ab887dc663140b7b65da4be47851eb5f216d5201290cdae30d',
      subId: '0x0000000000000000000000000000000000000000000000000000000000000001',
      name: 'test BTC',
      symbol: 'tBTC',
      decimals: 10
    }
  ],
  ammContract: '0xe00f7e7f0508ef31649b828bdfc1518c38e1b9ae09e04cb9681cfe6ba66a66de',
  pools: {
    '0x580085ecb00ce878a662d19582a5d40cbe4417184f2514ed427c937ce4f50781': {
      '0x299ea939953a56ab887dc663140b7b65da4be47851eb5f216d5201290cdae30d': '0x5600472e368e0934a39d5c2c25db0b56152939265a9181e6a91bf8fc3d68d04a'
    },
    '0x299ea939953a56ab887dc663140b7b65da4be47851eb5f216d5201290cdae30d': {
      '0x580085ecb00ce878a662d19582a5d40cbe4417184f2514ed427c937ce4f50781': '0x5600472e368e0934a39d5c2c25db0b56152939265a9181e6a91bf8fc3d68d04a'
    }
  }
}
✨  Done in 4.89s.

and then
yarn start --task=test2

❯ yarn start --task=test2
yarn run v1.22.19
warning ../../../package.json: No license field
$ ts-node src/index.ts --task=test2
The Fuel Node that you are trying to connect to is using fuel-core version 0.29.0,
which is not supported by the version of the TS SDK that you are using.
Things may not work as expected.
Supported fuel-core version: 0.27.0.
fuel19ztwgeul8yzffsr0df0me8kk8vtr5xpnwlkup79aksv8m47m9h0qdxlfru
0xf8f8b6283d7fa5b672b530cbb84fcccb4ff8dc40f8176ef4544ddb1f1952ad07 1929679
test2 done
0x580085ecb00ce878a662d19582a5d40cbe4417184f2514ed427c937ce4f50781 test USD tUSD 6
0x299ea939953a56ab887dc663140b7b65da4be47851eb5f216d5201290cdae30d test BTC tBTC 10
{
  tokenContract: '0xf1ea11be20f8d6d7a30ff69f21bffc1a95910e0459b03fbdd5c5070f4f48f82d',
  tokens: [
    {
      assetId: '0x580085ecb00ce878a662d19582a5d40cbe4417184f2514ed427c937ce4f50781',
      subId: '0x0000000000000000000000000000000000000000000000000000000000000000',
      name: 'test USD',
      symbol: 'tUSD',
      decimals: 6
    },
    {
      assetId: '0x299ea939953a56ab887dc663140b7b65da4be47851eb5f216d5201290cdae30d',
      subId: '0x0000000000000000000000000000000000000000000000000000000000000001',
      name: 'test BTC',
      symbol: 'tBTC',
      decimals: 10
    }
  ],
  ammContract: '0xe00f7e7f0508ef31649b828bdfc1518c38e1b9ae09e04cb9681cfe6ba66a66de',
  pools: {
    '0x580085ecb00ce878a662d19582a5d40cbe4417184f2514ed427c937ce4f50781': {
      '0x299ea939953a56ab887dc663140b7b65da4be47851eb5f216d5201290cdae30d': '0x5600472e368e0934a39d5c2c25db0b56152939265a9181e6a91bf8fc3d68d04a'
    },
    '0x299ea939953a56ab887dc663140b7b65da4be47851eb5f216d5201290cdae30d': {
      '0x580085ecb00ce878a662d19582a5d40cbe4417184f2514ed427c937ce4f50781': '0x5600472e368e0934a39d5c2c25db0b56152939265a9181e6a91bf8fc3d68d04a'
    }
  }
}

Could you retry the commands and then let me know if this solves your issue?

yarn start --task=initPool is used to manually initialize variables, but the problem now is that the variables are not initialized when they are defined.

yarn start --task=initPool is used to manually initialize variables, but the problem now is that the variables are not initialized when they are defined.

My bad thanks for the clarification, the issue is that you weren't passing the storageSlots as an option when you were deploying the pool contract in the createPool task.
I've applied the fix here and it works for me. See the code snippet below:
export const deploy_pool_contract = async (wallet: Account, assetIdA: string, assetIdB: string) => {

    const bytecodeDir = join(__dirname, '../../AMM/exchange-contract/out/debug/exchange-contract.bin')

	// Get the storage slot directory
    const storageSlotsDir = join(__dirname, '../../AMM/exchange-contract/out/debug/exchange-contract-storage_slots.json')

    const bytecode = readFileSync(bytecodeDir)

    // Parse the Storage slot JSON object
    const storageSlots = JSON.parse(readFileSync(storageSlotsDir, 'utf-8'))

    const factory = new ContractFactory(bytecode, ExchangeContractAbi__factory.abi, wallet)

    // Ensure it's passed to the deployContract function call
    let contractAbi = await factory.deployContract({ storageSlots })

    return contractAbi as ExchangeContractAbi
}

Does this solve your issue?

This solves my problem, but what is the purpose of the initialization here?
storage {
liquidity_pool_supply: u64 = 0
}

This solves my problem, but what is the purpose of the initialization here? storage { liquidity_pool_supply: u64 = 0 }

Those said values that where initialized in a storage slot also need to be deployed with the smart contract in order for the VM to allocate the storage blocks. That's the purpose of the custom storage slots. You can read more about storage here
I'm going to close this issue since the initial problem has been addressed. Feel free to open a discussion or forum post if you have any more questions about storage.


Splatfest (traditional) Turf War support

#1106

[x] Icons for Splatfest (Pro) and Splatfest (Open) modes
[x] Add lobbies
[x] Clout
[x] xN battle
[ ] Title and exp
[x] Fest power for Pro

I have decided not to implement the Splatfest title and its experience at this time.

It looks SplatNet's data does not include them.
If they assume they add them, the rest of the SplatNet data seems to indicate that the translated strings are likely to be included as they are.
For me, the natural way to hold data is to hold them by ID (=key), not by string.

If they are kept as strings, it is difficult to translate and display them.


Feat 199: Add awaitTxConfirmation function

Summary
Closes #199
Type of Change
Please mark the relevant option(s) for your pull request:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code refactoring (improving code quality without changing its behavior)
[ ] Documentation update (adding or updating documentation related to the project)

Checklist
Please ensure that your pull request meets the following criteria:

[ ] I have read the Contributing Guide
[x] My code follows the project's coding style and best practices
[x] My code is appropriately commented and includes relevant documentation
[x] I have added tests to cover my changes
[x] All new and existing tests pass
[ ] I have updated the documentation, if necessary

Testing
New Providers Mashup tests:

[x] Await Tx Confirmed - Submitted Tx
[x] Await Tx Confirmed - Timeout for non-existing Tx

Thanks @alegadea for this useful PR. I have reviewed it, kindly let me know about the comments.

@alegadea Did you implement for this in provider of plutus-simple-model?

@alegadea Did you implement for this in provider of plutus-simple-model?

Thinking more, I don't think we need for PSM, though would have required if this PR was bringing change to GYTxQueryMonad but that is not the case.


fix: handle error from pool.run

When an error was thrown from pool.run, vitest finished without any error messages.
This PR handles that error.
I found this while implementing https://github.com/vitejs/vite/pull/8049.
Before
 RUN  v0.12.8 D:/documents/GitHub/vite

····*···---******************************---------··········***····································******···*********·····*·**··········***

There was no error message.
After
 RUN  v0.12.8 D:/documents/GitHub/vite

stderr | unknown test
"default" is imported from external module "path" but never used in "playground-temp/ssr-vue/src/entry-server.js".

················································---································································---------··················-----------··············································--·*··························-··································-****·············································································-------··---····································----------·······················································*·············************··

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
 FAIL  playground/react-emotion/__tests__/react.spec.ts [ playground/react-emotion/__tests__/react.spec.ts ]
Error: Cannot find package '@emotion/babel-plugin' imported from D:\documents\GitHub\vite\babel-virtual-resolve-base.js
 ❯ new NodeError node_modules/.pnpm/@babel+core@7.17.10/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:2669:5
 ❯ packageResolve node_modules/.pnpm/@babel+core@7.17.10/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:3325:9
 ❯ moduleResolve node_modules/.pnpm/@babel+core@7.17.10/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:3359:18
 ❯ defaultResolve node_modules/.pnpm/@babel+core@7.17.10/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:3398:13
 ❯ node_modules/.pnpm/@babel+core@7.17.10/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:3421:14
 ❯ asyncGeneratorStep node_modules/.pnpm/@babel+core@7.17.10/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:63:103
 ❯ _next node_modules/.pnpm/@babel+core@7.17.10/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:65:194
 ❯ node_modules/.pnpm/@babel+core@7.17.10/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:65:364

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯Serialized Error: {
  "code": "PLUGIN_ERROR",
  "hook": "transform",
  "id": "D:/documents/GitHub/vite/playground-temp/react-emotion/index.html?html-proxy&index=0.js",
  "plugin": "vite:react-babel",
  "pluginCode": "ERR_MODULE_NOT_FOUND",
  "watchFiles": [
    "D:/documents/GitHub/vite/playground-temp/react-emotion/index.html",
    "vite/modulepreload-polyfill",
    "D:/documents/GitHub/vite/playground-temp/react-emotion/index.html?html-proxy&index=0.js",
  ],
}
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯
Test Files  1 failed | 57 passed | 3 skipped (64)
     Tests  422 passed | 47 skipped (487)
      Time  22.63s (in thread 174.57s, 12.97%)

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Unhandled Errors ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Vitest caught 1 unhandled error during the test run. This might cause false positive tests.
Please, resolve all the errors to make sure your tests are not affected.

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Unhandled Error ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯AggregateError:
 ❯ Object.runTests ../../../../file:/D:/documents/GitHub/vitest/packages/vitest/dist/vendor-cli-api.bcfd31a5.js:8250:15
 ❯ processTicksAndRejections ../../../../node:internal/process/task_queues:96:5
 ❯ async ../../../../file:/D:/documents/GitHub/vitest/packages/vitest/dist/vendor-cli-api.bcfd31a5.js:10440:9
 ❯ async Vitest.runFiles ../../../../file:/D:/documents/GitHub/vitest/packages/vitest/dist/vendor-cli-api.bcfd31a5.js:10450:12
 ❯ async Vitest.start ../../../../file:/D:/documents/GitHub/vitest/packages/vitest/dist/vendor-cli-api.bcfd31a5.js:10377:5
 ❯ async startVitest ../../../../file:/D:/documents/GitHub/vitest/packages/vitest/dist/vendor-cli-api.bcfd31a5.js:11113:5
 ❯ async start ../../../../file:/D:/documents/GitHub/vitest/packages/vitest/dist/cli.js:665:9
js:661:3

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯Serialized Error: {
  "errors": [
    [Error: ENOENT: no such file or directory, open 'D:\documents\GitHub\vite\playground-temp\js-sourcemap\dist\assets\index.704baece.js'],
    [Error: ENOENT: no such file or directory, open 'D:\documents\GitHub\vite\playground-temp\worker\dist\iife\index.html'],
    [Error: ENOENT: no such file or directory, open 'D:\documents\GitHub\vite\playground-temp\worker\dist\iife-sourcemap\assets\my-worker.b928aeec.js'],
  ],
}
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

It shows as a Unhandled Error but it is now much better than no error message.
To be honest, I don't know where it should be handled.

Also, we are calling this function in
https://github.com/vitest-dev/vitest/blob/a23fb585df1c20407842ac938ba371250087954e/packages/vitest/src/node/core.ts#L220
Which has a try/catch 🤔

Also, we are calling this function in
https://github.com/vitest-dev/vitest/blob/a23fb585df1c20407842ac938ba371250087954e/packages/vitest/src/node/core.ts#L220
Which has a try/catch 🤔

When an error happens here, these two .close() will not be called.
https://github.com/vitest-dev/vitest/blob/478465a050557c98e578fbad79b41bbd236fd537/packages/vitest/src/node/pool.ts#L94
https://github.com/vitest-dev/vitest/blob/478465a050557c98e578fbad79b41bbd236fd537/packages/vitest/src/node/pool.ts#L95-L96
I don't know what happens if it is not called, but it seems it needs to be called.

When an error happens here, these two .close() will not be called.

I guess they need to be called, yes (so we need to keep your try/finally), but do we need to throw AggregateError then? Or you think it's better for overall DX? If so, I think we might need a better error message showing where errors came from.

If I use Promise.all instead of Promise.allSettled, vitest finishes immediately with an error.
Yes I thought it is better to use AggregateError for DX.

I think we might need a better error message showing where errors came from.

I thought it will be better to have those too but I didn't come up with how to implement it.


warn the user when the project is too big (AST cache is ineffective)

AST_CACHING_POLICY sets an implicit limit on how large a Dart project can be to get good performance. If the project is too large to fit in the cache, it will still work, but performance will start to suffer since sometimes the analyzer will need to parse Dart files more than once.
This suggests a simple metric to tell when a Dart project is "too big". We can keep track of how often Dart files are compiled more than once during a full analysis. If it exceeds a threshold, we could tell the user that they will get better performance by reducing the project size. (That is, we could send a notification to the IDE, which is in an better position to indicate how to accomplish this.)

Is there any reason why you don't mention increasing the cache size? Just getting told that "this project is too large for Dart" doesn't sound optimal if the hardware etc. would actually allow for a bigger cache. ;-)

I disabled the cache by making it very large and it improved the analysis time for a large app by 30%.
It didn't make much difference to heap size.
For some command-line stand-alone scenarios it might make sense to disable caching.
The caches would still be important when the analyzer is running as a service to support an editor as the user can visit many large projects.

For now the plan is to double the size. (I will send out the CL on Monday.) Maybe try that and see if it has the same results?
There's always going to be some project size where analyzer performance falls below acceptable limits. If nothing else, the OS will start swapping, or perhaps the VM will throw errors before that? So I think the general principle stands that if you push it hard enough, at some point we should start warning the user that they're in the red zone. Otherwise they'll just think their IDE is being really slow (as they often are) and maybe not be able to diagnose the reason for it.

As someone who does tend to edit many projects together, I am very much in
favour of anything that helps that work for me but if I really have pushed
it too far then to warn me.
On Sun, 27 Mar 2016 at 9:20 AM, Brian Slesinsky<EMAIL_ADDRESS>wrote:

For now the plan is to double the size. (I will send out the CL on
Monday.) Maybe try that and see if it has the same results?
There's always going to be some project size where analyzer performance
falls below acceptable limits. If nothing else, the OS will start swapping,
or perhaps the VM will throw errors before that? So I think the general
principle stands that if you push it hard enough, at some point we should
start warning the user that they're in the red zone. Otherwise they'll just
think their IDE is being really slow (as they often are) and maybe not be
able to diagnose the reason for it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/dart-lang/sdk/issues/26095#issuecomment-201941535

If nothing else, the OS will start swapping, or perhaps the VM will throw errors before that?

Quite likely, for large enough applications. I've started having problems with the 32-bit VM crashing when analysis server has a large number of projects open and I try to get performance data in the VM. Performance data is quite large, and allocating a large chunk of memory causes it to crash. (Not sure whether this can happen with user code, or only when using the debug protocol.)


Light themes and color refactor

This PR adds a light theme and performs several refactors to the color system
things this PR does:

themes

restructure the themes constant
add stripes as an option for bars
add option for light themes

make the UI look good in light mode
use CSS variables for shades of grey to accommodate light mode
replace icons with SVG to allow changing colors

store logo color instead of image
remove "line" color
add light default theme
add candy cane theme

replace 4 systems of color with 2 (kind of 3)

use dark color for rank
use dark/light color for stats depending on theme
use dark/light color for lore depending on theme
use dark colors for item rarity background
shift greyscale Minecraft colors instead of inverting extreams

add more screenshots for manifest
remove fallback for browsers with no webp support

fix #367
fix #247
Candy Cane Theme:

themes menu with new themes:

Before:

After:

After (light):

Before:

After:

After (light):

Before:

After:

After (light):

Before:

After:

After (light):

Before:

After:

After (light):

Before:

After:

After (light):

Looks good to me. You guys should merge this.


ClickHouse allows creating Distributed view onto itself, leading to infinite query loop

It's currently possible to create a loop such as this:
:) CREATE TABLE loop AS system.parts ENGINE = Distributed('cluster', 'default', loop, rand())

When queried, it will infinitely spawn new subqueries. Attempts to connect to the server will fails, because all connection slots are exhausted:
$ clickhouse-client -h server -u me --stacktrace
Connecting to server:9000 as user me.
Code: 32. DB::Exception: Attempt to read after eof

Stack trace:
0. clickhouse-client(StackTrace::StackTrace()+0x16) [0x2a95a76]
1. clickhouse-client(DB::Exception::Exception(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int)+0x1f) [0x109ec0f]
2. clickhouse-client(DB::throwReadAfterEOF()+0x47) [0x109ec77]
3. clickhouse-client(DB::Connection::receiveHello()+0xa8a) [0x2cb97fa]
4. clickhouse-client(DB::Connection::connect()+0x6d4) [0x2cbb714]
5. clickhouse-client(DB::Connection::getServerVersion(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, unsigned long&, unsigned long&, unsigned long&)+0x2e) [0x2cbc33e]
6. clickhouse-client(DB::Client::connect()+0xa4e) [0x10e2efe]
7. clickhouse-client(DB::Client::mainImpl(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&)+0x2ff) [0x10f33df]
8. clickhouse-client(DB::Client::main(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&)+0x26) [0x108ce26]
9. clickhouse-client(Poco::Util::Application::run()+0x33) [0x3342853]
10. clickhouse-client(mainEntryClickHouseClient(int, char**)+0x62c) [0x10c90cc]
11. clickhouse-client(main+0x164) [0x1086dc4]
12. /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1) [0x7fd70c7c52b1]
13. clickhouse-client(_start+0x2a) [0x109bcda]

The HTTP interface just hangs, or fails with maximum simultaneous queries exception:
$ clickhouse-cli -h server -p 8123
clickhouse-cli version: 0.2.3
Connecting to server:8123
Error:
Too much simultaneous queries. Maximum: 256

The client can be lucky and get a connection at some point, but KILL QUERY doesn't seem to terminate the recursing query completely:
KILL QUERY WHERE query LIKE 'SELECT count() FROM loop%'

waiting	63fd27d2-36f6-4317-9f75-afff83dbb6a0	default	SELECT count() FROM loop
waiting	c898f8fe-d716-4a37-9101-e22930ec2ef5	default	SELECT count() FROM loop
waiting	68913e52-621e-4ce5-9249-e7cf856bea45	default	SELECT count() FROM loop
waiting	1ad8db4c-f09f-47c8-9ad5-9a3f35a61736	default	SELECT count() FROM loop
waiting	8e7c3cd8-7e70-447d-815c-175aa8fbbc95	default	SELECT count() FROM loop
waiting	6fcc9f92-76d2-4ac0-8aa6-6175603e2c7d	default	SELECT count() FROM loop
waiting	02d94565-b932-40f2-b029-8426a6fdbaaa	default	SELECT count() FROM loop
waiting	18460600-0a68-41cf-93bb-fad9344621d5	default	SELECT count() FROM loop
waiting	495d0f51-3445-4f4f-865f-b0e4684f9c06	default	SELECT count() FROM loop
finished	d9f4a435-0de4-4d09-8a13-65989ab25ce8	default	SELECT count() FROM loop
finished	e584e524-09a6-4722-888e-3af5afc750f0	default	SELECT count() FROM loop
finished	00b13cfd-2fde-47d6-91dd-63c9760dcd98	default	SELECT count() FROM loop
finished	44638e19-aaa5-487c-b6cb-6daed71c032f	default	SELECT count() FROM loop
finished	cbcbffa0-678a-496a-acfe-a737166c8a62	default	SELECT count() FROM loop
finished	2405bb3a-039d-4f70-bf6f-b96a6500d47f	default	SELECT count() FROM loop
finished	62af974f-0de4-4b0d-9e2c-7de267f53251	default	SELECT count() FROM loop

So it's impossible to recover from this other than stopping and then starting all servers I guess.

I understand there are some other possible ways how to create a loop, for example using Merge engine, so perhaps the recommendation would be to make such query killable without having to restart the whole cluster. HTTP interface didn't seem to have many connections, but still rejected all queries due to the limit for simultaneous queries. Perhaps it should accept connection first, and allow certain queries despite the query limit (SYSTEM, KILL)?

Perhaps it should accept connection first, and allow certain queries despite the query limit (SYSTEM, KILL)?

Now it's possible to execute KILL query regardless to the number of simultaneous queries.


tvnamer: fix building on all platforms

Description of changes
This change unblocks tvnamer by using the latest version of tvnamer. In addition, it fixes the build of requests-cache 0.5.2 dependency, that was missing setuptools.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

And the update to the python library should be in its own commit.

Nice, thanks!


VSTS Deployment Request Timeout

Environment

Server - VSTS or TFS on-premises?
VSTS

Agent - Hosted or Private:
Hosted

Issue Description
We are having an issue with Deploying To Linux Web App. Basically the PUT request times out. I couldn't find any information online about this issue, so would appreciate help. Let me know if more information is needed.
Thanks
Error logs
2018-03-10T17:15:53.3688181Z ##[debug]Performing Linux built-in package deployment
2018-03-10T17:15:53.3714741Z<EMAIL_ADDRESS>2018-03-10T17:19:01.0846803Z ##[error]Failed to deploy web package to App Service.
2018-03-10T17:19:01.0884186Z ##[debug]Processed: ##vso[task.issue type=error;]Failed to deploy web package to App Service.
2018-03-10T17:19:01.0906281Z ##[debug]task result: Failed
2018-03-10T17:19:01.0943956Z ##[error]Error: Error: Failed to deploy App Service package using kudu service : Request timeout: /api/zip/site/wwwroot/

@msternik ,  we have fixed the issue by moving to ZIP DEPLOY API.
The fix will be available in ~2-3 weeks.

@vincentdass Do you guys have any workarounds for this issue? I can't deploy my app because of this.
Thanks!

@lumogox , the deployment is currently in progress and is deployed in most of the regions.
A quick workaround is to deploy the core content of the app (without app dependencies) and install the app dependencies using post deployment script.

reopening...

@msternik , @lumogox , the deployment is completed in most of the regions. Can you please queue a new release and observe the behavior?

@vincentdass I'm still getting the same error:
2018-03-20T07:52:29.5966944Z ##[error]Failed to deploy web package to App Service.
2018-03-20T07:52:29.5966944Z ##[error]Error: Error: Failed to deploy App Service package using kudu service : Request timeout: /api/zip/site/wwwroot/
The region for this App Service is West Europe.

@lumogox , Can you please share the version of the task? You can queue a new release / re-deploy to view the latest version.
(or) you can browse https://<account_name>.visualstudio.com/_apis/distributedtask/tasks and view the task version here. (There would be two major versions, 2.* and 3.* and we are interested in 3.*)

@lumogox , @msternik ,
The deployment with Zip Deploy feature is completed in all the rings.
Please re-queue the release for the latest task version.

I just ran into the same issue trying to deploy from VSTS using the Azure App Service Deploy task. I defined the release pipeline to use 3.x. The app was deployed using a self-hosted Linux agent, to a Linux- based ASE.
I fixed it by changing the version of the task to 4.x (PREVIEW).
From the logs I could see that the 3.x task was trying to use the zip api, and the 4.x task uses zipdeploy.


mafft: 7.508 -> 7.515

Description of changes
minor update
https://gitlab.com/sysimm/mafft/-/tags/v7.515

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 221864 run on aarch64-darwin 1

1 package built:

mafft


Add a second environment variable for Urls

Add ASPNETCORE_URLS in addition to server.urls.

Curious why we want to add another environment variable that does the same thing? Is it because environment variables containing dots are hard to set in certain environments? If that's the case, maybe we should consider renaming the environment variable instead simply adding another one?

Curious why we want to add another environment variable that does the same thing? Is it because environment variables containing dots are hard to set in certain environments?

If that's the case, maybe we should consider renaming the environment variable instead simply adding another one?

We don't want to break anybody so we're going to add a new one and deprecate the old one. Eventually we can remove it.


Passing probabilistic data through Python embedding does not work.

This issue was raised via MET-Help:
https://rt.rap.ucar.edu/rt/Ticket/Display.html?id=92694
The user passed data with python embedding to Point-Stat and set "prob = TRUE;" in the config file, but no probabilistic output was produced.
The problem existing in the VarInfoPython::set_dict() function in var_info_python.cc.  It fails to parse the "prob" setting from the input dictionary.
In the master_v8.1 bugfix branch (for met-8.1.2), fix this by updating that function in the python library.
In the develop branch (for met-9.0), fix this by factoring the parsing of "prob" output from the derived libraries (vx_data2d_grib, vx_data2d_grib2, vx_data2d_python, vx_data2d_nc_met, vx_data2d_nccf, vx_data2d_nccf) and do it once in the base class (VarInfo::set_dict()) instead.

Fixed in master_v8.1 and the develop branches.


Add deprecate to CosmosDbStorage

Fixes https://github.com/microsoft/botframework-sdk/issues/5634
Deprecate CosmosDbStorage and CosmosDbStorageOptions with recommendation to use CosmosDbPartitionedStorage

Pull Request Test Coverage Report for Build 106340

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.255%

Totals

Change from base Build 106328:
0.0%

Covered Lines:
8733

Relevant Lines:
10025

💛  - Coveralls


added xml support

just added xml as a filetype and made it handled the same as a txt file

Should be simple enough to add the actual XML loader: https://python.langchain.com/docs/integrations/document_loaders/xml

https://github.com/h2oai/h2ogpt/commit/1f70f34b5c572c6c57c284bfe23d382f5a1132ad


Add/Use version sub directory

Hi,
I tried your OTA solution and it works as advertised, thank you for this.
I would like to add this as an enhancement for easier use of your project.
I had to create a bash script to get the files uploaded with the correct names.
Which is fine, but if you add a version dir I think you can make your project easier to use.
server-root/
|- <project_name>/
|  |- version <- version file
|  |  <version dir> |- <filename1>
|  |  <version dir> |- <filename2>
|  |  <version dir> |- ...

This way you can use filenames without versions and keep uploading/syncing with your webserver easy.
For now this is my bash script:
#!/usr/bin/env bash

echo "uploading version: ${1} for ${2}"

`echo "$1" > version`

scp version mm:/var/www/html/$2/version
scp boot.py mm:/var/www/html/$2/$1_boot.py
scp main.py mm:/var/www/html/$2/$1_main.py
scp config_$2.py mm:/var/www/html/$2/$1_config.py

usage: ./upload.sh 1.0.4 tuinhuis_monitor

Hey @Swieep, thank you very much for your proposal. I really appreciate that.
Nice idea, but implementing it this way only would be a breaking change. What about adding your proposed solution as another flavor of how this library can act? We could give the user the opportunity to choose by setting a config flag like use_version_dirs or something like that what directory structure he wants to use?

Hey @Pax-IT, I just implemented the feature. If you want, you can test it. The py-file is available here: micropython_ota.py
Feel free to review and comment the corresponding pull request #12.
Kind regards
olivergregorius


multi-room: volume automatically dropping to 36

Raspberry Pi 4 with balenaOS 2.47.1+rev1. And that´s correct I´m NOT using DAC.

[robertgzr] This issue has attached support thread https://jel.ly.fish/#/56f2a57e-76f5-46de-a693-f8539400f2a5

I can vouch for this. I'm using balenaOS v2.38.0+rev1, as this is required due to #62
Despite setting the device variable SYSTEM_OUTPUT_VOLUME to 100 I inspected the bluetooth-audio container and ran alsamixer. I found that the volume was 36, same as the issue title. I turned it up manually here.

Ah! I think I've observed the behavior fully. Here's what occurs.

Device boots
Variable is applied somewhere in the entrypoint
Bluetooth connection is established
Music plays at 100% volume initially for around 1-2 seconds
Volume reverts to 36 seconds after bluetooth connection is established

Indeed, every time a bluetooth device is connected, the volume reverts to 36.
[  847.092383] input: 28:16:7F:63:61:91 as /devices/virtual/input/input2 this also occurs and is visible in the kernel log at the same time.
Interestingly, it seems udevd is having a hard time with these virtual inputs, and sometimes it actually kills them. At one point this did actually cause the volume to drop back down to 36, but the audio still sounded as if it was intact. In other words, all I perceived audibly was a volume drop back down to 36.
[  504.409162] systemd-udevd[29]: seq 1854 '/devices/virtual/input/input0' is taking a long time
[  544.409371] systemd-udevd[29]: seq 1861 '/devices/virtual/input/input1' is taking a long time
[  624.409862] systemd-udevd[29]: seq 1854 '/devices/virtual/input/input0' killed
[  624.411246] systemd-udevd[29]: worker [107] terminated by signal 9 (Killed)
[  624.411290] systemd-udevd[29]: worker [107] failed while handling '/devices/virtual/input/input0'
[  664.410022] systemd-udevd[29]: seq 1861 '/devices/virtual/input/input1' killed
[  664.411363] systemd-udevd[29]: worker [106] terminated by signal 9 (Killed)
[  664.411393] systemd-udevd[29]: worker [106] failed while handling '/devices/virtual/input/input1'
[  685.410126] systemd-udevd[29]: seq 1858 '/devices/virtual/input/input0' is taking a long time
[  805.410831] systemd-udevd[29]: seq 1858 '/devices/virtual/input/input0' killed
[  805.413128] systemd-udevd[29]: worker [105] terminated by signal 9 (Killed)
[  805.413169] systemd-udevd[29]: worker [105] failed while handling '/devices/virtual/input/input0'
[  847.092383] input: 28:16:7F:63:61:91 as /devices/virtual/input/input2
[  896.411215] systemd-udevd[29]: seq 1864 '/devices/virtual/input/input1' is taking a long time
[  907.411279] systemd-udevd[29]: seq 1867 '/devices/virtual/input/input2' is taking a long time

Thanks @MatthewCroughan for the thorough investigation. I'll work on fixing this shortly, the information you compiled surely does help.

I've just solved this issue. It might be a good idea to change the title of this issue since it doesn't seem to be a problem with multi-room specifically, but rather with the use of the amixer sset commands in the udev rule and entrypoint of the bluetooth-audio container.
https://github.com/balenalabs/balena-sound/blob/ce2470e07bf74a6fa4b96271b6ee9056d78898a8/bluetooth-audio/start.sh#L21-L22
https://github.com/balenalabs/balena-sound/blob/ce2470e07bf74a6fa4b96271b6ee9056d78898a8/bluetooth-audio/bluetooth-udev#L22-L23
Let's say I want to use 50% volume in the container, I'll execute amixer sset PCM,0 50%
The problem is that by default, amixer is not using the command line option -M which means "Mapped Volume", and instead is being supplied a 'raw value' which does not equate to the human readable/audible volume mapping we want. For example, without -M, 50% is equal to 13% as can be seen in the AlsaMixer gui, or a value of -4919 which is close to -50dB. I have no idea what is actually happening here since I'm not clued up on these systems. The absence of a % sign also changes this behaviour, so supplying 100% vs 100 changes the value.
Before -M (mapped volume)

After -M (mapped volume)

This may have been overlooked because the value 100% is the max number, no matter the supplied options, so someone may have tested with 100% and assumed it worked since it changes from the default value.
TL;DR
Simply supplying -M to the amixer commands fixes this.
This information was gleamed from this stackoverflow post
I'll submit a pull request with the fix shortly.

Excuse the poor commits and force commits, I was just confused about how to actually follow the contribution guidelines. I did not know that putting multiple commit messages would separate them out into paragraphs like that.


Finalize prototype

Extracted from Q3 planning meeting notes.
Meta-issue for tracking remaining work involved in getting this prototype "done" and making it available at (e.g.) status.nextstrain.org. @genehack to build a more detailed roadmap.

I've made the site available at https://status.nextstrain.org.
As far as I can tell, this status dashboard is "done enough". We're using it, it gets small tweaks/improvements over time as we desire, and we have the ability to add more status pages using the same framework over time. If there's more that's desired, let's get it written out so we can do it. :-)


Memory leak in the latest netty version when executing tests

I just updated to the latest netty version (4.1.26.Final, boring.ssl  2.0.12.Final) and my test run had crashed due to OutOfMemoryError.
I have a special test set with 200 tests. Every test starts the server and at the end of test stops it. Before tests were executed just fine. With the latest version on 100-th test, my RAM of 32 GBs is out.
I haven't dig into it yet, just let you know. Probably this is related to recent "finalizer" changes and object cleaner.
java version "10.0.1" 2018-04-17
Java(TM) SE Runtime Environment 18.3 (build 10.0.1+10)
Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.1+10, mixed mode)

Prev version was:
4.1.25.Final
boring.ssl 2.0.8.Final

@doom369 can you show me how you configure your SslContextBuilder ?

also what version you used before ?

@normanmaurer updated ticket with prev version. I build it with this - https://github.com/blynkkk/blynk-server/blob/master/server/core/src/main/java/cc/blynk/server/SslContextHolder.java

I wonder if you can try to run the tests with SslProvider.JDK and if you can try to run it with SslProvider.OPENSSL but not use a key file but use a KeyManagerFactory ?

@normanmaurer tried SslProvider.JDK, issue still present.

SslProvider.JDK doesn't help.

interesting... Would it be possible get a heap dump ?

Also I wonder if you could try to just revert 5b1fe611a637c362a60b391079fff73b1a4ef912 and see if you still see the issue. At the moment I am not sure what the cause is really :(

I thinks this should give you some clues:

hmm... can you tell me what holds the reference to the byte[] and also how many EventLoop instances you have ? It seems you may have 500k+ of these ?

@normanmaurer ok, narrowed down the issue to
        this.asyncHttpClient = new DefaultAsyncHttpClient(new DefaultAsyncHttpClientConfig.Builder()
                .setUserAgent(null)
                .setKeepAlive(true)
                .setUseNativeTransport(true)
                .setUseOpenSsl(true)
                .build()
        );

After setting .setUseNativeTransport(false) all is ok. Probably issue is because AsyncHttpClient uses prev. netty version. Sorry for false alarm.

@doom369 ok... I wonder if the async http client not tears down the event loop correctly and so its possible the native memory is not released.

@normanmaurer could it be because of changed native bindings to epoll transport?

@doom369 I don't think so... The only reason I can think of is because of this change:
https://github.com/netty/netty/commit/05e5ab1ecb98963604d686c1f59b2196cf73e244#diff-824cfcec3522343772416dd064658a83
As now we reserve the native memory on EventLoop creation directly while before it was only reserved on first usage via EpollDatagramChannel. This memory will be released once you call EpollEventLoopGroup.shutdownGracefully() tho, so I suspect AsyncHttpClient  not tears down its EventLoops correctly.

Ok. Thanks I'll move this to AsynClient Report.

@doom369 having 500k+ instances does not look right to me, or I am reading it wrong in the screenshot ?

I don't know what IovArray is, so I can't tell :). The thing is - I never closed explicitly the asyncHttpClient between my tests run and seems like that's a reason for a leak. I thought that when it GCed it should release all things it holds, but seems like this is not true anymore. Adding asyncHttpClient.close(); fixes the issue.

@doom369 it was also not true before it just leaked less as it only leaked IovArray before and now it also leaks NativeDatagramPacket ;)

@doom369 thanks for the help to debug this :)

@normanmaurer thank you too! Will do digging before posting next time :).

Probably issue is because AsyncHttpClient uses prev. netty version.

I released AHC 2.5.1 w/ Netty 4.1.26 earlier today :)


Has this project been abandoned?

Hi just wantet to ask whether this project is still active or not? If not, it would be nice if it were mentioned in the description of the repo or the repo was to be archived!

This extension was contributed, hasn't been updated or maintained for a while. I stopped taking in additional reports leaving them to be community managed since it's too much for me to maintain myself. Will indicate this in the readme, cheers


New Feature proposal - Token-ERC-721 in GO

Hello,
I've translated the code from token-erc-721 from JS (the only version available now) to golang. I got a full implementation, along with unit tests. I kept the same comments as in the JS version, and following the README.md instructions, anyone could choose whether to use JS or GO. I have the code ready and fully tested with said instructions.
I'd like to contribute this code, how can I proceed?
Thank you

You are welcome to contribute it, but not to this repository. This repository holds the Fabric core (orderer and peer) and tokens is business logic, not infrastructure.
You can take a look at fabric-samples repository, which holds examples.
Alternatively you can contribute the code to the fabric-token-sdk which is an evolving project that lets you do token exchange and asset management over Fabric and other blockchains.

Right, I intended to post this on fabric samples, my bad. Thanks for your prompt response.