HDFS-16477. [SPS]: Add metric PendingSPSPaths for getting the number of paths to be processed by SPS

JIRA: HDFS-16477.
Currently we have no idea how many paths are waiting to be processed when using the SPS feature. We should add metric PendingSPSPaths for getting the number of paths to be processed by SPS in NameNode.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m  4s

Maven dependency ordering for branch

-1 :x:
mvninstall
21m 27s
/branch-mvninstall-root.txt
root in trunk failed.

-1 :x:
compile
16m 14s
/branch-compile-root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
root in trunk failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
13m 43s
/branch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root in trunk failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
checkstyle
3m 37s

trunk passed

+1 :green_heart:
mvnsite
3m 20s

trunk passed

+1 :green_heart:
javadoc
2m 28s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 28s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
5m 56s

trunk passed

+1 :green_heart:
shadedclient
23m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 15s

the patch passed

+1 :green_heart:
compile
21m 59s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
21m 59s
/results-compile-javac-root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 generated 188 new + 1624 unchanged - 0 fixed = 1812 total (was 1624)

+1 :green_heart:
compile
19m 48s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
javac
19m 48s
/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 172 new + 1515 unchanged - 0 fixed = 1687 total (was 1515)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 39s

the patch passed

+1 :green_heart:
mvnsite
3m 21s

the patch passed

+1 :green_heart:
javadoc
2m 24s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 31s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 17s

the patch passed

+1 :green_heart:
shadedclient
25m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
31m 58s

hadoop-common in the patch passed.

-1 :x:
unit
240m 15s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 13s

The patch does not generate ASF License warnings.

469m  9s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4009

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux c2ebb12705a0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d68ce2bb0c3a2235649d8705e13358ca8e7ee3c5

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/1/testReport/

Max. process+thread count
3143 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 59s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 31s

trunk passed

+1 :green_heart:
compile
22m 24s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 39s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 37s

trunk passed

+1 :green_heart:
mvnsite
3m 22s

trunk passed

+1 :green_heart:
javadoc
2m 30s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 30s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
5m 49s

trunk passed

+1 :green_heart:
shadedclient
23m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 15s

the patch passed

+1 :green_heart:
compile
21m 49s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
21m 49s

the patch passed

+1 :green_heart:
compile
19m 39s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
19m 39s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 34s

the patch passed

+1 :green_heart:
mvnsite
3m 24s

the patch passed

+1 :green_heart:
javadoc
2m 23s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 31s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 15s

the patch passed

+1 :green_heart:
shadedclient
23m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
25m  1s

hadoop-common in the patch passed.

+1 :green_heart:
unit
248m 42s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  9s

The patch does not generate ASF License warnings.

480m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4009

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux 188ae4e762b2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f9b315a8898895e1f0841ea8d282922bae909c2b

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/2/testReport/

Max. process+thread count
3156 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @jojochuang @Hexiaoqiao , PTAL. Thanks.

Hi @tasanuma @ayushtkn @virajith , could you please also take a look at this? Thanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m 14s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
11m 28s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 46s

trunk passed

+1 :green_heart:
compile
22m 25s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 44s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 40s

trunk passed

+1 :green_heart:
mvnsite
3m 27s

trunk passed

+1 :green_heart:
javadoc
2m 27s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 26s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
5m 55s

trunk passed

+1 :green_heart:
shadedclient
23m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 15s

the patch passed

+1 :green_heart:
compile
23m 43s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
23m 43s

the patch passed

+1 :green_heart:
compile
23m 19s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
23m 19s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 25s

the patch passed

+1 :green_heart:
mvnsite
3m 37s

the patch passed

+1 :green_heart:
javadoc
2m 32s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 46s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 32s

the patch passed

+1 :green_heart:
shadedclient
28m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
17m  2s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
unit
0m 34s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+0 :ok:
asflicense
0m 43s

ASF License check generated no output?

246m 27s

Reason
Tests

Failed junit tests
hadoop.metrics2.source.TestJvmMetrics

hadoop.fs.viewfs.TestViewFSOverloadSchemeCentralMountTableConfig

hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4009

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux 754b3ee36d57 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bf4dd789dde088b50806349702430aa25bcfe2e1

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/3/testReport/

Max. process+thread count
2221 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Unit tests failed because of OOM, regardless of changes.

We need to have this metric is Router as well, as we do have for other FSN related metrics. The value there would be the sum of values from all other namespaces.

Thank you @ayushtkn very much for the review. I will update it ASAP.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 45s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m 43s

trunk passed

+1 :green_heart:
compile
24m  8s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
20m 46s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 54s

trunk passed

+1 :green_heart:
mvnsite
4m  0s

trunk passed

+1 :green_heart:
javadoc
3m  3s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
4m 29s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 25s

trunk passed

+1 :green_heart:
shadedclient
23m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 54s

the patch passed

+1 :green_heart:
compile
23m 38s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

-1 :x:
cc
23m 38s
/results-compile-cc-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt
root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 32 new + 291 unchanged - 32 fixed = 323 total (was 323)

+1 :green_heart:
javac
23m 38s

the patch passed

+1 :green_heart:
compile
20m 49s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
cc
20m 49s
/results-compile-cc-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 22 new + 301 unchanged - 22 fixed = 323 total (was 323)

+1 :green_heart:
javac
20m 49s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 49s
/results-checkstyle-root.txt
root: The patch generated 2 new + 237 unchanged - 1 fixed = 239 total (was 238)

+1 :green_heart:
mvnsite
4m  1s

the patch passed

+1 :green_heart:
javadoc
3m  0s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
4m 20s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
8m  1s

the patch passed

+1 :green_heart:
shadedclient
24m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 45s

hadoop-common in the patch passed.

-1 :x:
unit
330m 21s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
unit
32m 19s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m  8s

The patch does not generate ASF License warnings.

626m 41s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.mover.TestMover

hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4009

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux 693df36a2c46 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 702fa3f93221cd92a28774f456026df035a8fe24

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/4/testReport/

Max. process+thread count
2318 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @ayushtkn , the failed unit tests seem unrelated to the change. Could you please take a look. Thanks.

Hi @tasanuma @virajjasani , could you please also take a look. Thanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 48s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m  4s

trunk passed

+1 :green_heart:
compile
24m 20s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
20m 59s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 51s

trunk passed

+1 :green_heart:
mvnsite
4m  5s

trunk passed

+1 :green_heart:
javadoc
3m  6s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
4m 24s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 28s

trunk passed

+1 :green_heart:
shadedclient
24m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 53s

the patch passed

+1 :green_heart:
compile
23m 54s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

-1 :x:
cc
23m 54s
/results-compile-cc-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt
root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 20 new + 303 unchanged - 20 fixed = 323 total (was 323)

+1 :green_heart:
javac
23m 54s

the patch passed

+1 :green_heart:
compile
20m 57s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
cc
20m 57s
/results-compile-cc-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 35 new + 288 unchanged - 35 fixed = 323 total (was 323)

+1 :green_heart:
javac
20m 57s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 47s
/results-checkstyle-root.txt
root: The patch generated 2 new + 237 unchanged - 1 fixed = 239 total (was 238)

+1 :green_heart:
mvnsite
4m  3s

the patch passed

+1 :green_heart:
javadoc
3m  3s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
4m 20s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
8m  7s

the patch passed

+1 :green_heart:
shadedclient
24m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 45s

hadoop-common in the patch passed.

-1 :x:
unit
397m  2s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
unit
1m 19s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
asflicense
1m  0s

The patch does not generate ASF License warnings.

647m 48s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA

hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

hadoop.hdfs.server.namenode.TestLargeDirectoryDelete

hadoop.hdfs.server.namenode.ha.TestHASafeMode

hadoop.hdfs.server.blockmanagement.TestPendingReconstruction

hadoop.hdfs.server.namenode.ha.TestDNFencing

hadoop.hdfs.server.blockmanagement.TestBlockInfoStriped

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4009

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux e1346c01df78 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 237442f4f30fba38743ea40405788104a2957b8f

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/5/testReport/

Max. process+thread count
1927 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 35s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m  9s

trunk passed

+1 :green_heart:
compile
22m 44s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 56s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 43s

trunk passed

+1 :green_heart:
mvnsite
4m 24s

trunk passed

+1 :green_heart:
javadoc
3m 23s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
4m 44s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 28s

trunk passed

+1 :green_heart:
shadedclient
21m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 50s

the patch passed

+1 :green_heart:
compile
21m 54s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

-1 :x:
cc
21m 54s
/results-compile-cc-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt
root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 35 new + 288 unchanged - 35 fixed = 323 total (was 323)

+1 :green_heart:
javac
21m 54s

the patch passed

+1 :green_heart:
compile
19m 54s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
cc
19m 54s
/results-compile-cc-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 31 new + 292 unchanged - 31 fixed = 323 total (was 323)

+1 :green_heart:
javac
19m 54s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 36s

root: The patch generated 0 new + 238 unchanged - 1 fixed = 238 total (was 239)

+1 :green_heart:
mvnsite
4m 21s

the patch passed

+1 :green_heart:
javadoc
3m 20s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
4m 47s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
8m  2s

the patch passed

+1 :green_heart:
shadedclient
21m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 47s

hadoop-common in the patch passed.

+1 :green_heart:
unit
232m 24s

hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
21m 18s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

491m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4009

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux bef95d0cca97 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cbf86e2471d67cafa48d4c4e591d53c51c26975a

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/6/testReport/

Max. process+thread count
3113 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @ayushtkn @Hexiaoqiao @ferhui , could you please take a look. Thanks.

Hi @ayushtkn , could you please take a look at this? Thank you.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 33s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 29s

trunk passed

+1 :green_heart:
compile
24m 44s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
21m 14s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 56s

trunk passed

+1 :green_heart:
mvnsite
4m  8s

trunk passed

+1 :green_heart:
javadoc
3m  6s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
4m 28s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 34s

trunk passed

+1 :green_heart:
shadedclient
24m 34s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 56s

the patch passed

+1 :green_heart:
compile
24m  7s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

-1 :x:
cc
24m  7s
/results-compile-cc-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt
root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 32 new + 291 unchanged - 32 fixed = 323 total (was 323)

+1 :green_heart:
javac
24m  7s

the patch passed

+1 :green_heart:
compile
21m 12s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
cc
21m 12s
/results-compile-cc-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 16 new + 307 unchanged - 16 fixed = 323 total (was 323)

+1 :green_heart:
javac
21m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 52s

root: The patch generated 0 new + 237 unchanged - 1 fixed = 237 total (was 238)

+1 :green_heart:
mvnsite
4m  4s

the patch passed

+1 :green_heart:
javadoc
3m  3s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
4m 22s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
8m  2s

the patch passed

+1 :green_heart:
shadedclient
24m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 54s

hadoop-common in the patch passed.

+1 :green_heart:
unit
333m 49s

hadoop-hdfs in the patch passed.

-1 :x:
unit
32m 32s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m 16s

The patch does not generate ASF License warnings.

618m  0s

Reason
Tests

Failed junit tests
hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4009

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux 191251b372b9 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 81f2aaf1aca6665fb035e1f7849f5a32f59e4c9b

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/7/testReport/

Max. process+thread count
2293 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @ayushtkn , the failed unit test is unrelated to the change. Please have a look again. Thank you very much.

TestRouterDistCpProcedure seems to be failing with timeout. Doesn't look related. If you have bandwidth can track & increase the timeout for it in a separate jira

Thank you very much, I will open a new JIRA to do this.

I have retriggered the build. Lets wait. If all clean will push this post that

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
35m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
11m 31s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m 11s

trunk passed

+1 :green_heart:
compile
21m  0s

trunk passed

+1 :green_heart:
checkstyle
3m 50s

trunk passed

+1 :green_heart:
mvnsite
4m 34s

trunk passed

+1 :green_heart:
javadoc
5m  4s

trunk passed

+1 :green_heart:
spotbugs
7m 36s

trunk passed

+1 :green_heart:
shadedclient
20m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 52s

the patch passed

+1 :green_heart:
compile
21m 21s

the patch passed

-1 :x:
cc
21m 21s
/results-compile-cc-root.txt
root generated 10 new + 195 unchanged - 10 fixed = 205 total (was 205)

+1 :green_heart:
javac
21m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 47s

root: The patch generated 0 new + 238 unchanged - 1 fixed = 238 total (was 239)

+1 :green_heart:
mvnsite
4m 33s

the patch passed

+1 :green_heart:
javadoc
4m 51s

the patch passed

+1 :green_heart:
spotbugs
8m 16s

the patch passed

+1 :green_heart:
shadedclient
21m  4s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
18m  3s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
230m 25s

hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
21m 47s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m 14s

The patch does not generate ASF License warnings.

475m  9s

Reason
Tests

Failed junit tests
hadoop.crypto.TestCryptoStreamsWithOpensslSm4CtrCryptoCodec

hadoop.crypto.TestCryptoCodec

hadoop.service.launcher.TestServiceInterruptHandling

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4009

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux 5b6a171da275 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 075b0cab50eec18cbcff666a5cd030f19507602f

Default Java
Red Hat, Inc.-1.8.0_322-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/9/testReport/

Max. process+thread count
3678 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/9/console

versions
git=2.9.5 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

The cc warnings seem related to mapreduce-client.  I'll rebase and retrigger the build.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 44s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 14s

trunk passed

+1 :green_heart:
compile
24m 43s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
21m  6s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 51s

trunk passed

+1 :green_heart:
mvnsite
4m  6s

trunk passed

+1 :green_heart:
javadoc
3m  9s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
4m 25s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 32s

trunk passed

+1 :green_heart:
shadedclient
24m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 55s

the patch passed

+1 :green_heart:
compile
24m  6s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

-1 :x:
cc
24m  6s
/results-compile-cc-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt
root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 27 new + 296 unchanged - 27 fixed = 323 total (was 323)

+1 :green_heart:
javac
24m  6s

the patch passed

+1 :green_heart:
compile
21m  7s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
cc
21m  7s
/results-compile-cc-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 24 new + 299 unchanged - 24 fixed = 323 total (was 323)

+1 :green_heart:
javac
21m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 54s

root: The patch generated 0 new + 237 unchanged - 1 fixed = 237 total (was 238)

+1 :green_heart:
mvnsite
4m  6s

the patch passed

+1 :green_heart:
javadoc
3m  3s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
4m 30s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
8m  1s

the patch passed

+1 :green_heart:
shadedclient
24m 29s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 33s

hadoop-common in the patch passed.

+1 :green_heart:
unit
361m 52s

hadoop-hdfs in the patch passed.

-1 :x:
unit
1m 17s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

615m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4009

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux d0214cff25d9 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 05ded5a300190673c0f73f3ea131232c5a994805

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/10/testReport/

Max. process+thread count
2288 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @ayushtkn , the jenkins log seems compiled failed. But I can compiled successfully locally.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project hadoop-hdfs-rbf: Compilation failure
[ERROR] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-4009/ubuntu-focal/src/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/NamenodeBeanMetrics.java:[877,2] error: method does not override or implement a method from a supertype

And the cc warings seem related to mapreduce-client, but not the changes.
Do we need to retrigger the build? Thanks.

Hi @aajisaka , do you know the cause of these cc warnings? This PR does not change the c++ code associated with mapreduce-client. Could you please take a look? Thank you very much.
/results-compile-cc-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 20s

trunk passed

+1 :green_heart:
compile
24m 41s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
21m 10s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 56s

trunk passed

+1 :green_heart:
mvnsite
4m  6s

trunk passed

+1 :green_heart:
javadoc
3m  4s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
4m 32s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 28s

trunk passed

+1 :green_heart:
shadedclient
24m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 54s

the patch passed

+1 :green_heart:
compile
24m  0s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

-1 :x:
cc
24m  0s
/results-compile-cc-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt
root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 36 new + 287 unchanged - 36 fixed = 323 total (was 323)

+1 :green_heart:
javac
24m  0s

the patch passed

+1 :green_heart:
compile
21m  7s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
cc
21m  7s
/results-compile-cc-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 2 new + 321 unchanged - 2 fixed = 323 total (was 323)

+1 :green_heart:
javac
21m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 49s

root: The patch generated 0 new + 237 unchanged - 1 fixed = 237 total (was 238)

+1 :green_heart:
mvnsite
4m  7s

the patch passed

+1 :green_heart:
javadoc
3m  2s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
4m 26s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
8m  5s

the patch passed

+1 :green_heart:
shadedclient
24m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 50s

hadoop-common in the patch passed.

+1 :green_heart:
unit
333m 49s

hadoop-hdfs in the patch passed.

-1 :x:
unit
35m 53s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m  0s

The patch does not generate ASF License warnings.

620m 45s

Reason
Tests

Failed junit tests
hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4009

Optional Tests
dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux c3bdef33929a 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d66ff060a6cdf670897aa5f43193c1e166c46802

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/11/testReport/

Max. process+thread count
2293 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4009/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @ayushtkn , I add timeout for the failed unit test in this PR #4129. The cc warning is still here and I think it is not related to this change.

Anyway it says
generated 2 new + 321 unchanged - 2 fixed = 323 total (was 323)
2 new and 2 fixed. some issue with the yetus. The change doesn't touch mapreduce anyway. Proceeding with the commit considering this as a false alarm.
If by chance it isn't will revert

Thanks @ayushtkn .


EarliestMatching search for Download-BcNuGetPackageToFolder

For runtime creation / OnPrem deployments it's usually needed to retrieve runtime packages with the earliest matching version. This approach feels almost too easy so please point out if I missed something but it seemed to resolve the way I want it to.
#3590

Generally looks good - a few things missing though:

[ ] In the parameter description for select, EarliestMatching should be added
[ ] There are a few comments mentioning "latest matching", which should be latest or earliest matching
[ ] Please add a line to the release notes under 6.0.30
[ ] Please add the same parameter description and value to the validateSet of Publish-BcNuGetPackageToContainer

Added the requested changes. Hope I found all comments refering to match search.


What mean is this？

Don;t run titan as an Administrator

Fine.
Does anyone know that an account with a CSGO game is required to use it? For example, if you have a version of CSGO China（ csgo.com.cn ）, can use it?

As CS:GO is now free to play, your question obsoletes itself.


thrift.transport.TTransport.TTransportException: TSocket read 0 bytes

Thanks for writing down this great library. I am new to using thrift services. I can't seems to get it work.
This is how I am querying thrift service with thrift_connector. This is throwing error that Tsocket read 0 bytes.

import thriftpy
import thrift_connector.connection_pool as connection_pool
from tools.services.thriftservices import ExternalThriftServices
import json

request = <JSON_OBJECT>

pool = connection_pool.ClientPool(
        ExternalThriftServices,
        <HOST_NAME>,
        <PORT>,
        connction_class=connection_pool.ThriftClient
        )

pool.executeService(<SERVICE_NAME>, json.dumps(request))

However, I was able to extablish successful single connection with this code and receive the correct response.

import json
from thrift.transport import TSocket
from thrift.transport import TTransport
from thrift.protocol import TBinaryProtocol
from tools.services.thriftservices import ExternalThriftServices

request = <JSON_OBJECT>

socket = TSocket.TSocket(<HOST_NAME>,<PORT>)
transport = TTransport.TFramedTransport(socket)
transport.open()
protocol = TBinaryProtocol.TBinaryProtocol(transport)
thrift_client = ExternalThriftServices.Client(protocol)

thrift_client.executeService(<SERVICE_NAME>, json.dumps(request))

from tools.services.thriftservices import ExternalThriftServices

you need to use the service loaded from thriftpy, not from the code generated by native thrift

So, If I change earlier connection_pool usage to
import thriftpy
import thrift_connector.connection_pool as connection_pool
from tools.services.thriftservices import ExternalThriftServices
import json

request = <JSON_OBJECT>
service = thriftpy.load("thriftService.thrift")

pool = connection_pool.ClientPool(
        service.ExternalThriftServices,
        <HOST_NAME>,
        <PORT>,
        connction_class=connection_pool.ThriftClient
        )

pool.executeService(<SERVICE_NAME>, json.dumps(request))

Then I get this error:
AttributeError: type object 'ExternalThriftServices' has no attribute 'Client'
Is it because of mismatch between protocols or thriftpy versions?

We have a simple example for simple cases like this, please refer to the section (Usage) [https://github.com/eleme/thrift_connector#usage] in our readme.

Close old issues...
If you find this problem still there, feel free to reopen.


Implement DeleteFile and UpdatePlaceholderIfNeeded in ProjFS.Linux

The DeleteFile(), UpdatePlaceholderIfNeeded(), and ReplacePlaceholderFileWithSymLink() methods are currently stubbed out.
They are used by the GVFS provider when it needs to add/remove files to ensure the working directory matches a newly checkout-out Git branch, because Git (when used with VFSForGit) does not do so itself -- Git only manages files which have been directly modified by the user; all others have to be updated by VFSForGit.
The Mac implementation of these methods ultimately uses normal C/C++ syscalls like unlink()/rmdir() to do this, but has a number of TODO comments suggesting that races with file hydration are yet to be handled properly.
We could potentially implement these methods using additional libprojfs functions, e.g., projfs_delete_file(), etc., which would acquire a lock using the internal get_path_userdata()/finalize_userdata() functions on the file/directory or parent directory, as necessary, to avoid races with the hydration performed by projfs_fuse_proj_locked().
However, we should avoid excess locking where possible and rely on the Linux VFS to handle most contention issues, and it's also valid for any program (Git or otherwise) to attempt to add/update/remove files under our mount point just using regular POSIX syscalls.  So an initial implementation should likely follow the Mac model and simply use POSIX calls like unlink(), etc., without adding any functions to the libprojfs API.

See WIP PR in microsoft/VFSForGit#1128.

Resolved by microsoft/VFSForGit#1128.


[Feature Request] - Filter on request and response body

Hello,
Is it possible to add the functionnality to filter on request body (contains or not contains) and response body (contains or not contains) ?
I think it could be very useful.

Hi,
I totally agree with you, this is already implemented but not released. You can either download and build the project or wait for the next release.

Implemented with the latest release

Very cool! Thank you.


A framework for N-dimension points

Don't merge yet
Playing around with some ideas on how to deal with tangent spaces of points in N-dimensional spaces that might not be linear (i.e. parameterized by Cartesian coordinates). There is a Point type for Affine points but in general there exists an AbstractPoint class with the ability to add/subtract vectors to points and to subtract points from each other. There are clever tricks to e.g. allow the UTMZ type from Geodesy to keep it's zone intact.
Not yet sure if this approach is the right one. It seems useful for UTM types which are quasi-vector-like, but the real problem we are trying to solve is getting access to the tangent space of arbitrary coordinate parameterizations and the kinds of subtractions defined here make less sense for e.g. spherical coordinates (since displacement vectors don't have to be small). Perhaps this could be a lighter-weight interface involving size() and add_derivs() / get_derivs() or similar... or there could be some kind of wrapper type for a point and its tangent space.
@c42f

Coverage decreased (-4.8%) to 58.141% when pulling 87707d2739f203f1a61db783954084bc5417a706 on points into dd19fe24f2809be5c5766bb8f2cb9cea52cfdc02 on master.

As I said in person, I'm not quite sure what to think about this yet :-) Need to go dredging in memorywikipedia for some differential geometry that I've forgotten.

Oh, and btw, I do think this prototyping is great, but I don't think it really belongs in StaticArrays - it's more about differential geometry than it is about small arrays.

Yes, agreed. It was more there for the similarities of implementation and
convenience of not having to make yet another new package.
On 29 July 2016 at 22:47, Chris Foster<EMAIL_ADDRESS>wrote:

Oh, and btw, I do think this prototyping is great, but I don't think it
really belongs in StaticArrays - it's more about differential geometry than
it is about small arrays.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/andyferris/StaticArrays.jl/pull/3#issuecomment-236171192,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC1jPodv6WljkHoIBARt0CwRZ3XDuPRWks5qafZagaJpZM4JVH-F
.

Yeah, let's do it.


Much improved type reconstruction from Flow annotations.

includes generic parameters: Foo<Bar, Baz>
handles tuple types: [string, number]
handles union types: string | void
handles nullable types: ?string

Thanks for this PR. I've tested it locally with our environment and it works well. Hope this gets merged soon!

Thanks! And sorry for the late reply.
It looks good to me. I'd like to merge, so please add a test code.

Added the tests.

This would fix so much for me - please fix this soon.

I added tests, so in theory it's just waiting to be pushed.
I've actually made other improvements in a forked copy so I'll see about getting those into another PR.

I just added them here. It's all work I did a while ago and which we've used extensively on a massive code base, so I'm pretty confident that this is all a strict improvement over what used to be.


FieldArray  remove and add button not working as expected

i am trying to add same repeat section as provided in formly  example in my code but remove and add button not working as expected.

as above when i click on remove button it also remove add button as well like this

Can you please try to provide a stackblitz with your example?

hi thanks for replying me issue now fixed...


add some update type and CreateChatInviteLink

I added the CreateChatInviteLink method.
change name method kickChatMember to banChatMember
I kept the previous name so that users don't have problems when changing the version
And add multiple update types:
my_chat_member
chat_member
chat_join_request

Please check out the comments I put in your previous PR @ABOLFAZLVALIKHANI : https://github.com/Ali-Toosi/django-tgbot/pull/20
ChatInviteLink is a type in Telegram. I understand there is also a method called CreateChatInviteLink but there is also a type called ChatInviteLink. See this: https://core.telegram.org/bots/api#chatinvitelink
That means we don't need the assistants folder and the file in there. We just need to create a type for ChatInviteLink in the types folder.

Thanks for your patience,
I understanded and deleted assistant folder.
Please check my new commit.

Thanks for your patience,
I understanded, but I forget to delete assistant folder.
I will Delete it tomorrow


Constraints which are generic mapped types should have a constraint of the same mapping over their generic's constraint

Code
function f<
    T extends { member: string },
    TParam extends Readonly<T>
>(param: TParam, mutableSet: T): TParam {
    const x: string = param.member;
    return param;
}

Expected behavior:
Code works
Actual behavior:
Property member does not exist on type TParam.
When you call f, you must pass a first (and second) argument which provide a member named member (this is enforced), so it's common sense that within f you should always have access to the field of TParam named member. It seems like the issue today is that when calculating a generic's constraint, we don't consider a mapped type's generics' constraints when calculating its constraint.

Just looking at old bugs; this one was fixed all the way back in https://github.com/microsoft/TypeScript/commit/eeabd527ca0f4e00deb16bb3ca0fee1fb57b1d08 as part of #26698.


devices not found compiling foresp32 arduino core

I've updated esp32 arduino core and now it is correctly compiled.
But as opposite to the esp8266, discovery doesn't find any device.
I tried changing cpu frequency to 240Mhz, before at lower speed the board was continuously resetting, but no way to fiìnd the devices.
I added debug and this is the log:
rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0018,len:4
load:0x3fff001c,len:1100
load:0x40078000,len:10088
load:0x40080400,len:6380
entry 0x400806a4
[D][WiFiGeneric.cpp:342] _eventCallback(): Event: 0 - WIFI_READY
[D][WiFiGeneric.cpp:342] _eventCallback(): Event: 2 - STA_START
Connecting to WiFi
Connecting.....[D][WiFiGeneric.cpp:342] _eventCallback(): Event: 4 - STA_CONNECTED
[D][WiFiGeneric.cpp:342] _eventCallback(): Event: 7 - STA_GOT_IP
[D][WiFiGeneric.cpp:385] _eventCallback(): STA IP: <IP_ADDRESS>, MASK: <IP_ADDRESS>, GW: <IP_ADDRESS>
.
Connected to Vodafone-roberto
IP address: <IP_ADDRESS>
Constructing device 1
Adding device 1
Constructing device 2
Adding device 2
Adding device 3
Espalexa Begin...
MAXDEVICES 10
Done
Got UDP!
NOTIFY * HTTP/1.1
HOST: <IP_ADDRESS>:1900
CACHE-CONTROL: max-age=100
LOCATION: http://<IP_ADDRESS>:49152/description.xml
NT: urn:schemas-wifialliance-org:service:WFAWLANConfig:1
NTS: ssdp:alive
SERVER: Linux/2.6.36, UPnP/1.0, Portable SDK for U
any suggestion?
thanks
Originally posted by @robademar in https://github.com/Aircoookie/Espalexa/issues/40#issuecomment-458240790

I used the same code for both esp8266 and 32 . this is the log of esp8266 test started from my browser
esp log.txt
If you successfully tested the esp32 version I would think that there is something wrong in my arduino environment. For the board I used the last available version I downloaded after your suggestion .
thanks for your time

Just test for ESP8266 & ESP32 with the basic example using same network.
All work perfectly for ESP8266.
ESP32 is connected and is found in http://[EspIP]/espalexa. But never be discovered.
I will test again later.

@Aircoookie
Hi, got some hints now.

Example of EspalexaBasic.ino using ESP32, none can be discovered.

Adding #define ESPALEXA_DEBUG before Espalexa.h, all three devices always be discovered.

I repeated these tests three times (three times with debug, three times without debug), each time with debug, it is easy to find all three devices.

my Espalexa.h was contains already the changes you suggested . This is:
//not found URI (only if internal webserver is used)
void serveNotFound()
{
EA_DEBUGLN("Not-Found HTTP call:");
#ifndef ESPALEXA_ASYNC
EA_DEBUGLN("URI: " + server->uri());
EA_DEBUGLN("Body: " + server->arg(0));
if(!handleAlexaApiCall(server->uri(), server->arg(0)))
#else
EA_DEBUGLN("URI: " + server->url());
EA_DEBUGLN("Body: " + body);
if(!handleAlexaApiCall(server))
#endif
server->send(404, "text/plain", "Not Found (espalexa-internal)");
}
and I used the debug option in my code, but it doesn't work.

Your version is still the original one. Where are the brackets?
And do not use old Alexa app to discover which never works for me.
Use https://alexa.amazon.com or latest Alexa app, both work!

sorry I've misread the suggestion.
Now I changed but still not working
I tried with web browser, ios app and alexa discovery. No message comes through.
this is the log
log after changes to Espalexa_h.docx

@robademar I suddenly could not find any more with more 10 times trials.
Then I switched my phone WIFI to 2.4HGz from 5GHz, it finds now!
I read similar problem from one using FauxmoESP. I am still testing...

debug removed, same result. My phone is on a 5 GHz network

#44 Read this. I think there is fundamental problem for ESP32 version. Even when it is found, it will freeze and  not response after a period of time. Similar to what I am testing now, sometimes it works, sometimes it does not.
But earlier for discovery is reliable, but not now.
And no such problem for ESP82166.

Putting the EA_DEBUGLN in brackets shouldn't really affect anything, non-debug-mode discovery worked for me without them, so I can't confirm this. I don't know why 5Ghz would be an issue (maybe it depends on the router, could be that some models don't forward broadcast packets to the 2.4G network).
I noticed a different issue though, sometimes the ESP32 doesn't connect to the network and you have to hit the reset button for it to connect. This happens both in debug and normal mode, as well as async and non-async. I believe it is an DHCP issue, but not sure on that one.
@eos1d3 once again, thank you for all your help :)

For discovery issue, I would like to talk here. Here is a more solid test results.
I suspect Amazon is changing their server right right now. I have the same latest Alexa Android app for 2 days, but I never see discovery have notifications on Android!!
Just around an hour ago, when I successfully discovered ESP-8266 devices, There were three notifications on my mobile phone: "New Light named Light x found. To control it, say "Alexa, turn off Light x". At the same time, Alexa will say by voice of similar message. And the Alexa app icon has a red 3 showing. All these were never seen before.
I am still seeing this notifications for most of the time after discovery. But I did found at least once no notification at all but devices are found.
And for ESP8266, the discovery is a lot better now. Using Alexa app get 80% to find the devices. Using Alexa web page just gets around 50 - 60% to find.
I left home for around one hour. After that, I used my phone to control ESP8266 devices, they are still there and no error at all! This is so nice to see.
For ESP32, it can be found, but may be less than 10% chance for Alexa App. Almost never found when using Alexa web page. (But yesterday, it is almost at good at ESP8266)
But device controls will break networking of ESP32.
During my tests, UPnP is not affecting any operation. And I almost disable it during tests now. Actually I did not see any port is opened by UPnP even I enabled it.

And for ESP32 log, this is before discover operation:
Connecting to WiFi
Connecting........
Connected to xxx
IP address: <IP_ADDRESS>
Constructing device 1
Adding device 1
Constructing device 2
Adding device 2
Adding device 3
Espalexa Begin...
MAXDEVICES 10
Done
Got UDP!
M-SEARCH * HTTP/1.1
HOST: <IP_ADDRESS>:1900
MAN: "ssdp:discover"
MX: 1
ST: urn:dial-multiscreen-org:service:dial:1

Got UDP!
M-SEARCH * HTTP/1.1
HOST: <IP_ADDRESS>:1900
MAN: "ssdp:discover"
MX: 1
ST: urn:dial-multiscreen-org:service:dial:1

Got UDP!
M-SEARCH * HTTP/1.1
HOST: <IP_ADDRESS>:1900
MAN: "ssdp:discover"
MX: 1
ST: urn:dial-multiscreen-org:service:dial:1

Got UDP!
NOTIFY * HTTP/1.1
HOST: <IP_ADDRESS>:1900
ETHERNET: 00.06.dc.81.d7.a5
CACHE-CONTROL: max-age=1800
LOCATION: http://<IP_ADDRESS>:2020/myiBoxUPnP/description.xml
NT: urn:schemas-upnp-org:device:SyabasSTB:1
NTS: ssdp:alive
SERVER: Linux/SMP86xx

Sometimes, I see no M-SEARCH * HTTP/1.1 section, sometimes I see 1 to 3 times as shown above.
What is the normal log?

@Aircoookie

5G WIFI issue

I read that from FauxmoESP, someone said this problem for FauxmoESP. But for my test with your library, my mobile phone is on 5G (or my PC with Ethernet), ESP8266 with 2.4GHz, it just works! xD

Putting the EA_DEBUGLN in brackets shouldn't really affect anything

I will test again later.

sometimes the ESP32 doesn't connect to the network

Both ESP8266 and ESP32 have this issue. But I always make sure they are connected before discovery. So there is never a connection issue for my tests.
Your library is nice. And the Alexa app can control device on/off/dim by just touching the buttons on mobile phone (I do not know if these exist before). This is excellent! I like this so much.

That's interesting, I've never got any notifications about discovered devices before either. Yes, I can also confirm that ESP8266 seems to be a lot more reliable than ESP32 currently. Did you also try #define ESPALEXA_ASYNC? The async version seems to work a bit better for me.
The M-SEARCH packets with ST: urn:dial-multiscreen-org:service:dial:1 are unrelated and sent by other services (router, phones, media devices) . Alexa discovery M-SEARCH packets either have ST upnp:rootdevice or device:Basic:1.
Thank you! Yes, control in the app is very handy and it even works if your phone is not in the home network!

@Aircoookie Amazon is definitely playing with their server side right now!!
I used "https://alexa.amazon.com/" to discover devices with my Mac. And suddenly my phone got three discovery notifications and Echo dot said the same things!
So these notifications are not from new version of Alexa app. It is from server side!

@Aircoookie Just tested with ESPALEXA_ASYNC, all problems are the same. Around 20% can discover devices. Controlling devices will disconnect ESP32 too.
What timeout settings for related network requests? My ESP calls Amazon server from Asia, I expect network may take longer time. Just a guess as I am seeing the discovering so unpredictable.

I believe the communication is Phone <-> Amazon Server <-> Echo <-> ESP device, so the notifications would make sense. However, the discovery itself shouldn't be related to the server at all, it is only between the Echo and the ESP. First, the Echo sends broadcast SSDP discovery requests. The ESP answers those, then the Echo will "follow up" and request device details which the ESP will provide. At no point the ESP will connect to any Amazon server by itself (it could be that the Echo communicates with Amazon servers during the process though to add the new device to the database).
Still your argument with the server could be valid, I live in Germany (Ireland Alexa server), so that could make a difference, since I'm not having any discovery issues (but I am still affected by #44, so I'll try to investigate some more about that ASAP. The fact that /espalexa stops working means that the ESP is no longer connected to the network, so there must be a cause for that, most likely a bug in an Espalexa method)

The fact that this works makes me believe that this "no discovery" issue and #44 might be the same and the ESP32 just loses the connection really early (possibly when receiving the first SSDP request that is not by Alexa).

I do not know if connection dropped and reconnected, but each time after discovery, ESP32 is always connected. Only Alexa app control operations for on/off/dim will break connection.
See these:
Before discovery:
Free Heap: 272540
Uptime: 252792

After discovery:
Free Heap: 272532
Uptime: 276655

I think you may find the bug very soon. Happy new year too!

BRAVOOO!
First tests are ok tomorrow I will do more
Thanks Gio

Confirmed version 2.3.3 fixed discovery bug for ESP32. Notifications are always there for each device.
Great work!


RE: BSD-9343 Noticed a difference for the references (English compared to French) - Reference #20190611-150922-000-A

Moved from GCCode:  https://gccode.ssc-spc.gc.ca/iitb-dgiit/nw-ws/sgdc-cdts/issues/144
@StdGit opened issue
Good day Scott and thank you for your patience!
My name is Eric Guitard and I’m with the Content & IA team for Canada.ca at Service Canada. After a brief investigation with our development team, they don’t think the error is related to your pages being slow. Setting an expiration date for a page is more about content delivery optimization and not necessary linked with performance issue.
That said, the link you provided are pages from CDTS which Principal Publisher are not responsible for so I’m forwarding your request to them via this email so they can be aware and  see if they can provide us  with any guidance on this issue.
For further details, please don’t hesitate to contact me.
Thank you again and have a great day!
Eric Guitard
Business Analyst and Information Architect
Citizen Service Branch
Service Canada / Government of Canada
<EMAIL_ADDRESS>/ Tel:<PHONE_NUMBER>
Analyste des activités et Architecte de l’information
Direction générale de service aux citoyens
Service Canada / Gouvernement du Canada
<EMAIL_ADDRESS>/ Tél. :<PHONE_NUMBER>
From<EMAIL_ADDRESS><EMAIL_ADDRESS>Sent: 11 juin 2019 15:09
To: NC-AIDE_WEB_HELP<EMAIL_ADDRESS>Smith, Scott [TC-TC]<EMAIL_ADDRESS>Subject: BSD-9343 Noticed a difference for the references (English compared to French) - Reference #20190611-150922-000-A
Do not respond to this automatic acknowledgment email.
The Service Desk within the Principal Publisher of Canada.ca will review your request and forward it to the appropriate resolver group for action. As part of our commitment to you and the quality of Canada.ca, we will make every effort to respond to your request in a timely fashion.
Do you have another request? Submit it through the Request form for Canada.ca (http://requestform.portal.gc.ca/tickets.html).
Thank you.
Summary of your request:
Reference Number: 20190611-150922-000-A
Client Name: Scott Smith
Client Email<EMAIL_ADDRESS>Telephone number:<PHONE_NUMBER>
<EMAIL_ADDRESS>/ Tel:<PHONE_NUMBER>ion: Transport Canada
Issue: Canada_ca_Redesign
Sub-type: Canada.ca Redesign
Summary: Noticed a difference for the references (English compared to French)
Description:Hi,
We were working on an issue as we received a complaint about a web page loading slowly.
An online tool pointed to these references as not having an expiration, only the French page reports this. The English page doesn't show these issues.
I was wondering if someone could check the French files so we could eliminate this difference as a possible cause for the page load timing difference.
https://www.canada.ca/etc/designs/canada/cdts/gcweb/rn/cdts/compiled/wet-fr.js (expiration not specified)
https://www.canada.ca/etc/designs/canada/cdts/gcweb/v4_0_30/assets/sig-blk-fr.svg (expiration not specified)
https://www.canada.ca/etc/designs/canada/cdts/gcweb/v4_0_30/js/i18n/fr.min.js (expiration not specified)
Thanks,
Scott Smith
613-762-0886

RE_BSD-9343_Noticed_a_difference_for_the_references__English_compared_to_French__-_Reference__20190611-150922-000-A.zip

@MaximMartel Could you confirm this issue is still valid for version 4.0.39 ? Thanks.

Après avoir vérifié le temps d'attente dans FireFox et Chrome pour la version "run" v4_0_39
Avec les options de Cache et No Cache
Pour les 3 fichiers
Nous n'avons noté aucune différence notable.
La seule différence signifative étant que Chrome chargait les fichiers deux fois plus rapidement en moyenne.
Si nous devons faire de plus amples tests nous aurons besoin du même outil que le client a utilisé.
After checking the waiting time in Firefox and Chrome for the "run" version V4_0_39
With Cache and  No cache options
For the 3 files
We did not notice any noticeable difference.
The only significant difference being that Chrome loaded files twice as fast on average.
If we need to do further testing we will need the same tool the client used.

Après avoir vérifié le temps d'attente dans FireFox et Chrome pour la version "run" v4_0_39
Avec les options de Cache et No Cache
Pour les 3 fichiers
Nous n'avons noté aucune différence notable.
La seule différence signifative étant que Chrome chargait les fichiers deux fois plus rapidement en moyenne.
Si nous devons faire de plus amples tests nous aurons besoin du même outil que le client a utilisé.
After checking the waiting time in Firefox and Chrome for the "run" version V4_0_39
With Cache and  No cache options
For the 3 files
We did not notice any noticeable difference.
The only significant difference being that Chrome loaded files twice as fast on average.
If we need to do further testing we will need the same tool the client used.


angular: add dev envs configuration

Will merge your PR, so we'll be able to rebase all the others to use the default screenshoot


Display StyleCop.Analyzers Warnings in VS Code

Environment data
dotnet --info output:

.NET Command Line Tools (1.0.4)
Product Information:
Version:            1.0.4
Commit SHA-1 hash:  af1e6684fd
Runtime Environment:
OS Name:     Mac OS X
OS Version:  10.12
OS Platform: Darwin
RID:         osx.10.12-x64
Base Path:   /usr/local/share/dotnet/sdk/1.0.4

VS Code version: 1.15.0
C# Extension version: 1.12.1
Steps to reproduce
Follow the steps here to enable StyleCop.Analyzers:
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/DotNetCli.md
using this ruleset:
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/StyleCop.Analyzers/StyleCop.Analyzers.ruleset
and this settings file:
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/StyleCop.Analyzers/stylecop.json
Expected  behavior
SAXXXX warnings appear in the "Problems" tab of VS Code, and inline in the source files.
Actual behavior
Warnings reported in the "Problems" tab of VS Code are not changed from the default set (even after restarting OmniSharp), but running dotnet build does display the warnings from StyleCop.Analyzers.

Thanks for taking the time to report this issue. We're using https://github.com/OmniSharp/omnisharp-vscode/issues/43 to track this work for the future.


DB2 connection error

https://stackoverflow.com/questions/69292371/getting-connection-error-from-flyway-command-line-with-db2-drivers
There's an error in the way we handle JDBC connections with DB2 when retrieveMessagesFromServerOnGetMessage=true is set in the URL; see the above post for full details.

This seems to be a limitation of the DB2 JDBC driver
It errors when the URL contains properties and when we pass properties to the driver directly at the same time, even when the two sets of properties are distinct.
It also errors when the set of properties we pass to the driver is null/empty.
The correct solution for the time being is to pass all properties through the jdbcProperties parameter


Get-PnPListItem - PageSize Does Not Work when Query is specified

It looks like Get-PnPListItem seems to be ignoring PageSize when Query is specified.
I keep getting "Get-PnPListItem : The attempted operation is prohibited because it exceeds the list view threshold enforced by the administrator." error

However, if I run Get-PnPListItem -ListName $ListName -PageSize 5000 it works just fine and returns correct item count:

I have the most recent SharePointPnPPowerShellOnline module installed
$
And using PowerShell 5.1

Please advise.

@officedocsbot assign @yogkumgit

Hello @YuriySamorodov thanks for your feedback.
Let me tell you that this issue resource is specifically to address issues in documentation, so your request is needs to be treated as an issue in cmdlet's behavior, besides that, this is already submitted here https://github.com/SharePoint/PnP-PowerShell/issues/879 we will proceed closing this one.

@officedocsbot close


hautelook/phpass is not available anymore 404

hautelook/phpass is used in the files below but the developer behind it has removed it from github or made it private so the installation now stops
https://github.com/munkireport/munkireport-php/search?q=hautelook%2Fphpass
/composer.json
"hautelook/phpass": "^1.1",
namespace munkireport\lib;
use Hautelook\Phpass\PasswordHash;
/README.md

phpass 0.3.5 for encrypting passwords

0/79 [>---------------------------]   0%    Failed to download hautelook/phpass from dist: The "https://api.github.com/repos/hautelook/phpass/zipball/b2daca28508000d1dd126e93ec472d771626a774" file could not be downloaded (HTTP/2 404 ):
{"message":"Not Found","documentation_url":"https://docs.github.com/rest/reference/repos#download-a-repository-archive"}
Now trying to download from source

Syncing hautelook/phpass (1.1.0) into cache

Looks like someone mirrored here: https://github.com/bordoni/phpass
But, long term wondering if that would be maintained or not.

also fixed in wip branch

Hotfix would be needed in the main branch too


Add terragrunt example as a first class example on terratest.gruntwork.io

Addresses https://github.com/gruntwork-io/terratest/issues/122#issuecomment-924846867
Since we don't have preview for docs site, here are screenshots of how this looks like:

Am I just blind, or is the actual terragrunt.hcl file missing from this PR?

Nope not blind - that is correct and is intended. I am reusing the existing terragrunt-example that we already have on main.

Thanks for review! Merging this in now.


Small tweak to bytecode dumper

Updated DumpConstantTable to annotate property strings if the constant strings are indeed property strings

@dotnet-bot test OSX static_osx_osx_release please

@dotnet-bot test OSX static_osx_osx_debug OSX static_osx_osx_test please

@dotnet-bot test OSX static_osx_osx_test please


Moved blocks of code into seperate packages.

Changes consist of:

Updated code to remove requirement that Multus run (used to depend on
NetworkStatus annotation).
Moved types into its own pkg. There was a circular dependancy otherwise.
Moved userspace specific code to its own package to isolate imports from
Userspace-CNI. Instead of duplicating structures, importing directly from
Userspace-CNI.
Moved Multus specific code to its own package to isolate imports from
Multus-CNI. Instead of duplicating structures, importing directly from
Multus-CNI.
Updated glide to account for imports from Userspace-CNI and Multus.
Updated the sample annotations. Same file was in "sample/c_app/" and
"sample/go_app/". Moved into its own directory and updated one copy represent
an annotation if Multus was NOT run. Updated the Userspace-CNI annotation
names to match latest merged code.

Signed-off-by: Billy McFall<EMAIL_ADDRESS>

make c_sample failed below error:
gopath/src/github.com/openshift/app-netutil/c_api/netutil_c_api.go:121:8: identifier "_Ctype_int" may conflict with identifiers generated by cgo make: *** [Makefile:6: c_sample] Error 2
nit: (don't have to do that in this PR) It would be good to have glide update in a separate commit, that will make it easier to find which file is changed.


refactoring / flake8 compliance

This PR improves the compliance of our codebase with the wemake-python-styleguide, which checks syntax using flake8. (It also disables many wemake-python-styleguide checks that aren't useful for our situation.) These changes should make our code more readable and maintainable.

All tests are passing on the GPU too.

I'm going to go ahead and merge because refactoring PRs like this one can cause a lot of merge conflicts if they linger.

Thanks @jeff-regier looks like a useful PR !


Reload TLS certificate files when they change

fixes https://github.com/edgedb/edgedb/issues/4277

Is there an asyncio-compatible watching library we can use instead of spawning threads?

Is there an asyncio-compatible watching library we can use instead of spawning threads?

No popular and trusted one afaik. Maybe we spawn a thread and just check mtime in a loop every 5 seconds?

Is there an asyncio-compatible watching library we can use instead of spawning threads?

No popular and trusted one afaik. Maybe we spawn a thread and just check mtime in a loop every 5 seconds?

Threads mean GIL.  If it can't be in the event loop, then a monitoring subprocess sending SIGHUP to the main process seems better to me.

Threads mean GIL. If it can't be in the event loop, then a monitoring subprocess sending SIGHUP to the main process seems better to me.

That's too complicated.
@fantix how about we add a hidden API to uvloop to expose libuv watchers?

There is https://github.com/samuelcolvin/watchfiles which is mostly an interface to https://github.com/notify-rs/notify but its not 1.0 yet.

There is https://github.com/samuelcolvin/watchfiles which is mostly an interface to https://github.com/notify-rs/notify but its not 1.0 yet.

It also uses threads for its async API.

@fantix how about we add a hidden API to uvloop to expose libuv watchers? That should be easy.

I'm looking into this now - we can start with tweaking MagicStack/uvloop#474, the basic API should be pretty straightforward.
~Even though we don't need the recursive watching in this PR, it'll be needed by the edgedb-python codegen --watch mode. However, libuv doesn't support recursive watching out of the box on Linux, and libuv is likely NOT going to add support for that. So IMO we should at least make the hidden uvloop API friendly-enough for implementing recursive watching, given aside of whether we want to support Linux recursive watching directly in uvloop. I'll try something on top of @jensbjorgensen's implementation, and start a new thread in the uvloop repo for further discussion.~
Oh, edgedb-python doesn't depend on uvloop, and --watch mode will probably be just an extra feature that doesn't necessarily require uvloop for watching changes recursively. So it'll be easy then, literally quoting Yury's "we add a hidden API to uvloop to (simply) expose libuv watchers".

@fantix can you pick this one up given that we have the necessary new API in uvloop?

Closing in favor of the merged #4297.


eaglemode: 0.86.0 -> 0.94.0

The build is no longer breaking so this derivation is no longer marked
broken.
Motivation for this change
Existing version if marked broken and there have been a lot of releases since.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build eaglemode


Non-isobaric transmission spectra

In summary, I added 3 files:

1 file called "transmission_novais_2024.ipynb", where I wrote the part of the code to load and interpolate opacities (similar to https://shone.readthedocs.io/en/latest/shone/examples/transmission.html)
1 file called "novais_2024.py", where the non-isobaric equations are written
I also modified the original file "io.py" to include a non-isobaric interpolation function

Closing in favor of #25. Thanks @astroaline!


Tree Improvments

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ca55be6) 83.80% compared to head (3eb4d61) 83.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   83.80%   83.80%
=======================================
  Files          47       47
  Lines        6378     6378
=======================================
  Hits         5345     5345
  Misses       1033     1033

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Integrate Xamarin.Auth (native login) with AppService?

Hi all
I'm trying to integrate my native login (in this case Google) I do through Xamarin.Auth with my Azure AppService. A posting on the Xamarin blog showed (partially) the use of the LoginAsync method with a custom token, but as far as Google is concerned: Is this even possible?
This ends up with an Unauthorized error (the auth object contains the data I got form the Xamarin.Auth login:
            var jObject =  new JObject(
                new JProperty("access_token", auth.AccessToken),
                new JProperty("id_token", auth.IdToken));

            await ServiceClient.LoginAsync(MobileServiceAuthenticationProvider.Google, jObject);

Some context: I used to do server-side flow before, which works fine because I register web application OAUTH credentials with a client ID and client secret on Azure. With native login, I'm getting a token for Android OAUTH credentials, and AppService doesn't seem to know what to do with that.
As an alternative, I could generate a custom token on Azure (I'm doing that for manual logins with email/password anyway), but I guess it would be quite a hassle to verify that the data (token) I receive is legit?
Thanks,
Philipp

I posted this on S/O and got some feedback. Turns out I can just register my Android Client ID with Azure AppService and a fake secret and it "magically" works. I'm not sure though whether I just exposed a gaping security hole there, or Azure falls back to verifying the token according to https://developers.google.com/identity/sign-in/web/backend-auth#verify-the-integrity-of-the-id-token. In any case, it's weird that it doesn't complain about a secret that obviously doesn't match.
Also, this approach would mean that I can only authenticate Android or iOS users given that an app client ID should be restricted to a given Android or iOS app for security reasons (so I have two client IDs).
I'm keeping this open for now, and will also post back here if I learn more about this.

Any progress on this?  I have been searching for something like this for weeks and I finally came across this post.  Same scenario here with the bogus client secret in Azure.

@hardcodet We dont plan to support this scenario in Azure Mobile Apps SDK.

Hi elamalani,
Thank you for that clarification, however, could you point us to a resource to tell us how to use Google OAuth via Xamarin Forms, Azure App Service, and client authentication?
Thanks,
Kenon

@kpronz Please use the documentation link below:
https://docs.microsoft.com/en-us/azure/app-service-mobile/app-service-mobile-dotnet-how-to-use-client-library#clientflow

HI @elamalani ,
Thank you for that link, unfortunately, the Google implementation seems to be out of date.  When I only send the access_token in the token argument I get an error back from the call to LoginAsync saying that id_token is required.  Then, when I send the id_token, I get an error back saying "Unauthorized".  I am using an "Android" Google OAuth client in the Android app and have configured the Azure App Service to use a "Web" Google OAuth client, in the same Google project.  What all do I need to pass in the token to LoginAsync so that Azure App Proxy will authenticate correctly?
As an aside, as stated above by @hardcodet , if I set the Azure App Proxy to use the "Android" Google OAuth client id and put in a bogus client secret, then the authentication works.  However, I'm planning on writing an iOS app for this project as well so that's not going to work for me as iOS will have a separate Google OAuth client id.
Thanks,
Kenon

Hi @elamalani ,
Any updates on the documentation?
Thanks,
Kenon

I'm trying to get Google login client-flow to work with Azure Mobile App backend with no luck.
I run into same issues as @kpronz. First got "id_token required" and after providing that calling client.LoginAsync() just returns Unauthorized.
Please, let us know if this is something that should work or is it something I should give up trying to do.

I figured out what the issue was in my app. I didn't set the ServerClientID before doing the login with google.

Hi @taimila , could you explain what "ServerClientID" you had to set?  Also, in the Azure App Service authorization configuration, did you put the Google "Android" or "iOS" clientID in that blank or did you put the Google "Web" clientID and client secret in that dialog?

First some background: I use Xamarin.Forms and implemented client-flow for Google on iOS and Android. I found this blog post very helpful.
I configured app as instructed for server-flow login when using Azure Mobile App backend. So, on Google platform I registered the app as Web-application and then used created client_id and client_sercret in Azure Portal where Google Authentication is configured.
Using the code from linked blog post lead to same issues you had. However, when I changed the GoogleManager class a bit, it started to work.
On iOS before calling SignIn.SharedInstance.SignInUser(); I just set the client_id (same as in Azure portal) to Shared instance of SignIn like this SignIn.SharedInstance.ServerClientID = "client id here";.
On Android I had to add the same client_id to GoogleSignInOptions builder. I did it by adding the request for token id:
GoogleSignInOptions gso = new GoogleSignInOptions.Builder(GoogleSignInOptions.DefaultSignIn)                                                              .RequestIdToken("client id here")                                                              .RequestEmail()                                                              .Build();
I hope this helps you get forward. I am by no means expert on this subject, just lucky.

@taimila Thank you, thank you, thank you!  It's working!  Awesome job figuring that out!  I was lost for months!  If you're ever in Phoenix, AZ, I'll buy you a beer  :-).

@hardcodet Thanks for using Azure Mobile Apps. Please read the Readme section on this repo which talks about the future of Azure Mobile Apps. Since this is a feature request in the product, I'll close this issue for now as we are not adding new features, but feel free to ask us questions if you have any. Thanks!

@taimila why would you register as web-application in the firebase console if you are doing native android login like in the post you shared? I am registering in azure backend as below accessToken parameter below is the one i provide from        ```
GoogleSignInAccount account = result.SignInAccount;
account.IdToken

var zumoPayload = new Newtonsoft.Json.Linq.JObject();
zumoPayload.Add("access_token", accessToken);
                var result = await App.Client.LoginAsync(provider, zumoPayload);

ok I found the problem. code should be as below. Facebook SDK returns accesstoken while google sdk only returns idtoken. you should make it optional. I wonder if that is really hard to document somewhere.
var zumoPayload = new Newtonsoft.Json.Linq.JObject();
                    if(provider== MobileServiceAuthenticationProvider.Facebook)
                    zumoPayload.Add("access_token", accessToken);

                    if (provider == MobileServiceAuthenticationProvider.Google)
                        zumoPayload.Add("id_token", accessToken);

                    var result = await App.Client.LoginAsync(provider, zumoPayload);


Add instances to Nullable

Adding a load of missing instances to Nullable. Unfortunately, a couple of these are necessary for us, but I think they're all correct. Not that I'm advocating their use, of course...

So, after talking on the Slack, this is certifiably a Bad Idea™ and, rather than tainting the type, I'll push for a refactor. 😳

One alternative might be to provide stand-alone versions of these functions - i.e: not as instances.


How to move data from local installation to docker installation?

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
I want to move my local installation from local install to docker install as it is much easier to maintain and update for me. How can I move my existing data from the local installation to docker installation. I'm using docker-compose.yml file in the docker directory.
🐻 Uptime-Kuma Version
1.20.1
💻 Operating System and Arch
Debian 11 bullseye
🌐 Browser
Firefox
🐋 Docker Version
23.0.1
🟩 NodeJS Version
16.19.1

All data is stored in the /data directory. So long as this is copied over all data should be kept

All data is stored in the /data directory. So long as this is copied over all data should be kept

I  moved all data from /data to my docker appdata directory. I do see the login page but it says invalid username password. I use a password manager so it can't really be wrong.

Usually moved to an incorrect location. Please provide absolute paths or screenshots, so that people can actually understand your situation.

Usually moved to an incorrect location. Please provide absolute paths or screenshots, so that people can actually understand your situation.

I moved all the data from this directory,

to here,

and here is docker-compose.yml.

Usually moved to an incorrect location. Please provide absolute paths or screenshots, so that people can actually understand your situation.

OK, I managed to fix it. I found this page https://github.com/louislam/uptime-kuma/wiki/Reset-Password-via-CLI
and I ran this command to reset the password.
docker exec -it <container name> bash
npm run reset-password

It worked.


Discovery credentials 080521a

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Two unit test failures. My suggestion is run npm test locally before committing so we don't have a long feedback cycle via the Github Actions CI.


Mento exchange quotes are inverted when called using the contract kit

Expected Behavior
Fetching quote stable buy using the contract kit i.e.
    const kit = newKit(CELO_RPC);
    kit.defaultAccount = publicKey;
    kit.addAccount(privateKey);
    const mentoExchange: ExchangeWrapper = await kit.contracts.getExchange(
        StableToken.cUSD,
    );
    mentoExchange.quoteStableBuy(convertToWei(stableAmount))

should return the amount of celo a user would need to exchange to receive the stableAmount of stable token.
Current Behavior
quoteStableBuy returns the value quoteGoldBuy should return (the amount of stable token a user would need to exchange to receive the buyAmount of CELO. And Vice versa.
version: "@celo/contractkit": "^1.3.3",

Since @martinvol is removing this code from thee repo im closing


Config file/How to build

Dope project, and it's also the fastest windows neofetch I've project but then comes the customisation. I don't know anything about Cpp, I've spent the past 3 hour trying to build so that I can customise the ascii art but I've just been getting compilation error after compilation error, can you add like a config file option or something cause having to build just to customise the art is a pain.

Nevermind I found a solution. Incase anyone else faced the same problem I found out some include statements were missing, I edited the include statements in neofetch-win/neofetch-win/source.cpp to
#include <winreg.h>
#include <algorithm>
#include <iostream>
#include <random>
#include <string>
#include <vector>

command I ran during build, ran from the root directory  msbuild.exe /p:IncludePath=. /nologo /clp:ErrorsOnly /p:Configuration=Release

Sorry, I was sleeping at the time lol
if you're compiling with c++17 or earlier you will need these headers:
#include <iostream>
#include <windows.h>
#include <string.h>
#include <Lmcons.h>
#include <chrono>
#include <iomanip>
#include <algorithm>

however, if you're compiling with c++20 those last two headers are unnessecary because iomanip.h and IIRC some of algorithm.h is now included in the standard library. To clear up any further confusion I have decided to update the source so that it will compile in older C++ versions. I will also include a compile config in the readme.
Thanks for the ticket, feel free to reopen if you have any other questions


Double-click on test results describe/on/it does not jump to source

In the test results window, when I double-click on any of the describe/on/it levels I expect
the editor to jump to the source location of the corresponding block. Double-clicking does nothing.

This is one of the top productivity issues with this plugin for me.

The default Android JUnit run configuration type, does at least support jumping to the correct file (right-click on the class name in test results, or press F4 on it).
So it should be possible for the Spek - Android type to support at least that much.

The top level (navigate to class) doesn't work for me either. Right-clicking on it shows "Nothing here". Version 0.5.5-studio3.0 with Android Studio 3.1.1.
Android Studio's built-in Android JUnit run configuration type does at least support jumping to the correct object (via right-click or F4).

@raniejade maybe at least implement to go to File/Class anywhere you click will open this File/Class
What do you think ? at least something to navigate to source code