TargetFQDN issue while redirection

after establishing connection, connecting to target server - TargetFQDN gives error on ip resolve:

[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - flags: 0x0400, redirFlags: 0x00000B0D length: 306, sessionID: 0x00000AF0
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - redirectionFlags = {
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_NET_ADDRESS
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - 	LB_USERNAME
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - 	LB_DOMAIN
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_FQDN
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_NETBIOS_NAME
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_NET_ADDRESSES
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - }
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - Username: CHANGED
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - Domain: UNIVERSITY
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - TargetFQDN: SSoft2012-RDSH1.university.local
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - TargetNetBiosName: SSOFT2012-RDSH1
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - TargetNetAddressesCount: 2
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - TargetNetAddresses[0]: CHANGED
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.redirection] - TargetNetAddresses[1]: CHANGED
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.nego] - Enabling security layer negotiation: TRUE
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.nego] - Enabling restricted admin mode: FALSE
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.nego] - Enabling RDP security: TRUE
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.nego] - Enabling TLS security: TRUE
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.nego] - Enabling NLA security: TRUE
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.nego] - Enabling NLA extended security: FALSE
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.nego] - state: NEGO_STATE_NLA
[14:24:33:764] [9785:9786] [DEBUG][com.freerdp.core.nego] - Attempting NLA security
[14:24:38:766] [9785:9786] [ERROR][com.freerdp.core] - freerdp_set_last_error ERRCONNECT_DNS_NAME_NOT_FOUND [0x00020005]
[14:24:38:766] [9785:9786] [ERROR][com.freerdp.core] - WSAEventSelect returned 0x00002743
[14:24:38:766] [9785:9786] [ERROR][com.freerdp.core] - WSAEventSelect returned 0x00002743

TargetNetAddresses[0] && TargetNetAddresses[1] are real IPv4& IPv6 adresses.
It works only with workarround, by adding TargetFQDN with IPv4 to the /etc/hosts file.

$ xfreerdp -version
This is FreeRDP version 2.0.0~dev (git n/a)
$ cat /etc/lsb-release
DISTRIB_ID=LinuxMint
DISTRIB_RELEASE=18.2
DISTRIB_CODENAME=sonya
DISTRIB_DESCRIPTION="Linux Mint 18.2 Sonya"
$

@pokemonas Could you add some information like the command line you use for connection?
Do you have a DNS name or IP in it?

command used is simple -
$ xfreerdp cpub-pdshell16-StudSoft-CmsRdsh.rdp /u:"university\abcd1234" /log-level:TRACE
as per trace log - its visible redirection to "SSoft2012-RDSH1.university.local". Obviously name is not really FQDN from "outside" of university, but in other hand - from logs visible that "SSoft2012-RDSH1" TargetNetAddresses are got. So why after IP resolve, the FreeRDP instead of using gotten IPs still tries to connect via internal FQDNs (on which obviously fails because of internal name does not exist [or not fit] at outer world FQDN)

@pokemonas Ok, got your use case now. The address resolve failure should not matter, it just redirects the code to the appropriate connection function. What is strange from the logs though are the WSAEventSelect returned 0x00002743 statements.

So if I reword the issue SSoft2012-RDSH1.university.local is not resolved locally but the addresses given in TargetNetAddresses[0|1] are correct and should be used to connect to the host.

kind of yes... and no, - I would rather say so - after to connecting to GW,
internally redirected host name "SSoft2012-RDSH1.university.local" IPs were
resolved at GW and this is where IPs TargetNetAddresses[0|1] came from;
however the FreeRDP further still tries to use GW redirection NAME
(which is not world-wide QFDN in this case, but internal name behind of GW)
instead of resolved IP...
On 15 September 2017 at 17:48, David Fort<EMAIL_ADDRESS>wrote:

So if I reword the issue SSoft2012-RDSH1.university.local is not resolved
locally but the addresses given in TargetNetAddresses[0|1] are correct and
should be used to connect to the host.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FreeRDP/FreeRDP/issues/4132#issuecomment-329804228,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AP5iyVClBbqN58vSz55sDJdBsnjceklIks5sio42gaJpZM4PXeoa
.

--
Regards,
Valdas Zemaitis
m: +370.685.05426
Learning is like sex, reading books is not enough

@pokemonas  I've attached a small patch, does that work for you?
0001-Try-TargetNetAddress-if-hostname-not-resolvable.zip

Hi,
tested, - no, it doesn't work. And as I checked - this DNS_NAME error comes from tcp.p:freerdp_tcp_resolve_hostname() function (at 721 line)

Possible fix in https://github.com/akallabeth/FreeRDP/tree/redirect_fix
Please verify

@pokemonas Hi, did you find time to test my branch or did you already find another solution?

Hi,
did check, but unfortunately is the same.
getting same error:
[10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - flags: 0x0400, redirFlags: 0x00000B0D length: 306, sessionID: 0x00001308 [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - redirectionFlags = { [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_NET_ADDRESS [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - 	LB_USERNAME [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - 	LB_DOMAIN [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_FQDN [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_NETBIOS_NAME [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_NET_ADDRESSES [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - } [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - Username: *CHANGED* [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - Domain: UNIVERSITY [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - TargetFQDN: SSoft2012-RDSH1.university.local [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - TargetNetBiosName: SSOFT2012-RDSH1 [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - TargetNetAddressesCount: 2 [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - TargetNetAddresses[0]: *CHANGED* [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.redirection] - TargetNetAddresses[1]: *CHANGED* [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.nego] - Enabling security layer negotiation: TRUE [10:40:28:031] [18969:18970] [DEBUG][com.freerdp.core.nego] - Enabling restricted admin mode: FALSE [10:40:28:032] [18969:18970] [DEBUG][com.freerdp.core.nego] - Enabling RDP security: TRUE [10:40:28:032] [18969:18970] [DEBUG][com.freerdp.core.nego] - Enabling TLS security: TRUE [10:40:28:032] [18969:18970] [DEBUG][com.freerdp.core.nego] - Enabling NLA security: TRUE [10:40:28:032] [18969:18970] [DEBUG][com.freerdp.core.nego] - Enabling NLA extended security: FALSE [10:40:28:032] [18969:18970] [DEBUG][com.freerdp.core.nego] - state: NEGO_STATE_NLA [10:40:28:032] [18969:18970] [DEBUG][com.freerdp.core.nego] - Attempting NLA security [10:40:28:032] [18969:18970] [ERROR][com.freerdp.core] - WSAEventSelect returned 0x00002743 [10:40:28:032] [18969:18970] [ERROR][com.freerdp.core] - WSAEventSelect returned 0x00002743 [10:40:28:032] [18969:18970] [DEBUG][com.freerdp.core.nego] - RequestedProtocols: 3 [10:40:28:032] [18969:18970] [ERROR][com.freerdp.core.transport] - BIO_should_retry returned a system error 32: Broken pipe [10:40:28:032] [18969:18970] [ERROR][com.freerdp.core.nego] - Protocol Security Negotiation Failure [10:40:28:032] [18969:18970] [ERROR][com.freerdp.core] - freerdp_set_last_error ERRCONNECT_SECURITY_NEGO_CONNECT_FAILED [0x0002000C] [10:40:28:032] [18969:18970] [ERROR][com.freerdp.core.connection] - Error: protocol security negotiation or connection failure [10:40:28:032] [18969:18970] [ERROR][com.freerdp.core.transport] - BIO_read returned a system error 107: Transport endpoint is not connected [10:40:28:032] [18969:18970] [DEBUG][com.freerdp.core.transport] - transport_check_fds: transport_read_pdu() - -1 [10:40:28:032] [18969:18970] [DEBUG][com.freerdp.core.rdp] - transport_check_fds() - -1 [10:40:28:032] [18969:18970] [ERROR][com.freerdp.client.x11] - Freerdp connect error exit status 1
To compare to working example which I'm getting with fixed ip addresses in /etc/hosts, by adding IPv4 address:
CHANGED SSOFT2012-RDSH1 SSoft2012-RDSH1.university.local
[10:43:55:796] [19034:19035] [DEBUG][com.freerdp.core.redirection] - flags: 0x0400, redirFlags: 0x00000B0D length: 306, sessionID: 0x00001308 [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - redirectionFlags = { [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_NET_ADDRESS [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - 	LB_USERNAME [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - 	LB_DOMAIN [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_FQDN [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_NETBIOS_NAME [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_NET_ADDRESSES [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - } [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - Username: *CHANGED* [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - Domain: UNIVERSITY [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - TargetFQDN: SSoft2012-RDSH1.university.local [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - TargetNetBiosName: SSOFT2012-RDSH1 [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - TargetNetAddressesCount: 2 [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - TargetNetAddresses[0]: *CHANGED* [10:43:55:797] [19034:19035] [DEBUG][com.freerdp.core.redirection] - TargetNetAddresses[1]: *CHANGED* [10:43:55:798] [19034:19035] [DEBUG][com.freerdp.core.nego] - Enabling security layer negotiation: TRUE [10:43:55:798] [19034:19035] [DEBUG][com.freerdp.core.nego] - Enabling restricted admin mode: FALSE [10:43:55:798] [19034:19035] [DEBUG][com.freerdp.core.nego] - Enabling RDP security: TRUE [10:43:55:798] [19034:19035] [DEBUG][com.freerdp.core.nego] - Enabling TLS security: TRUE [10:43:55:798] [19034:19035] [DEBUG][com.freerdp.core.nego] - Enabling NLA security: TRUE [10:43:55:798] [19034:19035] [DEBUG][com.freerdp.core.nego] - Enabling NLA extended security: FALSE [10:43:55:798] [19034:19035] [DEBUG][com.freerdp.core.nego] - state: NEGO_STATE_NLA [10:43:55:798] [19034:19035] [DEBUG][com.freerdp.core.nego] - Attempting NLA security [10:43:55:833] [19034:19035] [DEBUG][com.freerdp.core.nego] - RequestedProtocols: 3 [10:43:55:865] [19034:19035] [DEBUG][com.freerdp.core.nego] - RDP_NEG_RSP [10:43:55:865] [19034:19035] [DEBUG][com.freerdp.core.nego] - selected_protocol: 2 [10:43:55:865] [19034:19035] [DEBUG][com.freerdp.core.nego] - state: NEGO_STATE_FINAL [10:43:55:865] [19034:19035] [DEBUG][com.freerdp.core.nego] - Negotiated NLA security [10:43:55:865] [19034:19035] [DEBUG][com.freerdp.core.nego] - nego_security_connect with PROTOCOL_NLA [10:43:55:936] [19034:19035] [DEBUG][com.winpr.sspi] - InitSecurityInterfaceExA [10:43:55:937] [19034:19035] [TRACE][com.freerdp.core.nla] -  InitializeSecurityContext status SEC_I_CONTINUE_NEEDED [0x00090312] [10:43:55:937] [19034:19035] [DEBUG][com.freerdp.core.nla] - Sending Authentication Token <...>

@pokemonas Sorry for the delay, too busy :/ I've updated the branch, it now logs the connection addresses it tries.

ok - now I'm lost completely - not able to test the original situation due to error while "feeding" rdp file.
What wrong am I doing ?
$ WLOG_LEVEL=TRACE ./client/X11/xfreerdp cpub-pdshell16-StudSoft-CmsRdsh_LF.rdp
[17:47:01:896] [5605:5605] [DEBUG][com.freerdp.utils] - Registering signal hook...
[17:47:01:900] [5605:5605] [DEBUG][com.freerdp.client.common.cmdline] - windows: 0/0 posix: 0/0 compat: -1000/0
[17:47:01:900] [5605:5606] [ERROR][com.freerdp.core] - freerdp_set_last_error ERRCONNECT_PRE_CONNECT_FAILED [0x00020001]
[17:47:01:900] [5605:5606] [ERROR][com.freerdp.core] - freerdp_pre_connect failed
[17:47:01:901] [5605:5606] [ERROR][com.freerdp.client.x11] - Freerdp connect error exit status 1

do you redirect your home drive? There was a bug #4333 that is not fixed here yet.

ah, yes it was - I commented out drive redirection in rdp file. now I'm getting something, but ...
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - flags: 0x0400, redirFlags: 0x00000B0D length: 306, sessionID: 0x0000027A
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - redirectionFlags = {
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_NET_ADDRESS
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - 	LB_USERNAME
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - 	LB_DOMAIN
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_FQDN
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_NETBIOS_NAME
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - 	LB_TARGET_NET_ADDRESSES
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - }
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - Username: abcd1234
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - Domain: UNIVERSITY
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - TargetFQDN: SSoft2012-RDSH1.university.local
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - TargetNetBiosName: SSOFT2012-RDSH1
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - TargetNetAddressesCount: 2
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - TargetNetAddresses[0]: <IP_ADDRESS>
[11:02:39:720] [24312:24313] [DEBUG][com.freerdp.core.redirection] - TargetNetAddresses[1]: 2002:9e81:c051::9e81:c051
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core.nego] - Enabling security layer negotiation: TRUE
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core.nego] - Enabling restricted admin mode: FALSE
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core.nego] - Enabling RDP security: TRUE
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core.nego] - Enabling TLS security: TRUE
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core.nego] - Enabling NLA security: TRUE
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core.nego] - Enabling NLA extended security: FALSE
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core.nego] - state: NEGO_STATE_NLA
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core.nego] - Attempting NLA security
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core] - hostname=<IP_ADDRESS>, port=3389, getaddrinfo returned 0
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core] - hostname=<IP_ADDRESS>, port=3389 connecting...
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core] - hostname=2002:9e81:c051::9e81:c051, port=3389, getaddrinfo returned 0
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core] - hostname=2002:9e81:c051::9e81:c051, port=3389 connecting...
[11:02:39:721] [24312:24313] [ERROR][com.freerdp.core] - WSAEventSelect returned 0x00002743
[11:02:39:721] [24312:24313] [ERROR][com.freerdp.core] - WSAEventSelect returned 0x00002743
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core.nego] - RequestedProtocols: 3
[11:02:39:721] [24312:24313] [ERROR][com.freerdp.core.transport] - BIO_should_retry returned a system error 32: Broken pipe
[11:02:39:721] [24312:24313] [ERROR][com.freerdp.core.nego] - Protocol Security Negotiation Failure
[11:02:39:721] [24312:24313] [ERROR][com.freerdp.core] - freerdp_set_last_error ERRCONNECT_SECURITY_NEGO_CONNECT_FAILED [0x0002000C]
[11:02:39:721] [24312:24313] [ERROR][com.freerdp.core.connection] - Error: protocol security negotiation or connection failure
[11:02:39:721] [24312:24313] [ERROR][com.freerdp.core.transport] - BIO_read returned a system error 107: Transport endpoint is not connected
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core.transport] - transport_check_fds: transport_read_pdu() - -1
[11:02:39:721] [24312:24313] [DEBUG][com.freerdp.core.rdp] - transport_check_fds() - -1
[11:02:39:721] [24312:24313] [ERROR][com.freerdp.client.x11] - Freerdp connect error exit status 1
$
the IP in logs - is accessible :
$ telnet <IP_ADDRESS> 3389
Trying <IP_ADDRESS>...
Connected to <IP_ADDRESS>.
Escape character is '^]'.
^]
telnet> Connection closed.
$

@pokemonas Assuming you're not on a IPv6 capable network?

@pokemonas Ok, fixed some issues in freerdp_tcp_connect_multi and rebased to master. Should now at least properly tell what is going on (or hopefully actually connect)

Any update on this? #4411 may have fixed this.

@pokemonas Is this issue resolved?

#4548 contains the relevant fix, when redirecting prefer TargetNetAddress over FQDN


[WFLY-10941] System.out cleanup - vdx, basic (jms), clustering

[WFLY-10941] System.out cleanup - vdx, basic (jms), clustering
https://issues.jboss.org/browse/WFLY-10941
Please make sure your PR meets the following requirements:

[x] Pull Request title is properly formatted: [WFLY-XYZ] Subject or WFLY-XYZ Subject
[x] Pull Request contains link to the JIRA issue(s)
[x] Pull Request contains description of the issue(s)
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Attached commits represent units of work and are properly formatted

There are similar cases in elytron/security tests and in JPA tests, I asked @msve and @mjurc to take a look at them and create separate PRs. Some of those tests may need additional polishing.

PR updated - info level in clustering one, vdx is ok with debug, this was added here by me, DeserializationMessagingBean change is keeping the same level of information

Stopping CI for this one as it is not urgent and all the slaves are busy, and I need to test other things


Feature/update name

:tada: This PR is included in version 0.7.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Support single quote name in flag usage

Change-Id: I1645a24e879beb72ad629941780330b152bab8bf

Codecov Report

Merging #13 (8a91fd6) into main (6aa9fcb) will increase coverage by 0.20%.
The diff coverage is 89.65%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   85.34%   85.55%   +0.20%
==========================================
  Files           8        8
  Lines        1515     1537      +22
==========================================
+ Hits         1293     1315      +22
+ Misses        160      159       -1
- Partials       62       63       +1

Files Changed
Coverage Δ

flag.go
86.07% <89.65%> (+0.18%)
:arrow_up:

... and 1 file with indirect coverage changes


Missing Sample Names in lmerge file

Hello. I was able to successfully generate a merged vcf for a large number of accessions. However, of over 27,000 SV calls there were 128 calls that did not have SNAME included on their line. These calls were of varying types. I could not find any documentation on why this would be. Could anyone shed some light on this? I need to be able to see where these calls are coming as my set is too large to sort through manually. I think this was done intentionally because all of the calls without samples are above part of the header.
Additionally the accession that is listed in our lmerge file's header, TS-86, is not present in any SV call list.

I don't believe we've encountered this before. It seems likely we've hit some sort of parsing error if these calls are intermixed with the header. Which header lines are found after the variant lines? Which are before?
For TS-86, could you clarify what you mean when you say it is listed in the lmerge file's header? Do you mean it is listed in a line starting with ##SAMPLE=<ID= but isn't listed in any calls?
Have you checked to see if your 128 calls that are missing the SNAME look to be from this sample?

My research just ended, so I do not have access to the file on me. But if you are interested in this issue from a developer standpoint I would be happy to retrieve it for you.
TS-86 was on the same line as chrom, pos, type, etc. Just like the accession would be in a regular (unmerged) VCF.
Yes. The only time that accession appears is on the line that reads "CHROM\tPOS..." It is not found under SNAME at all.
Apologies for the late response. We had to buckle down for a bit there.


FileUtils#rm_r removes a symlink itself

This is for fix and improvement both.
If a directory have a symbolic link, FileUtils#rm_r fails with an error message like:
Unable to remove directory '/path/to/the/symlink': Not a directory

And if the symlink also points to a directory, rm_r also deletes all files under the directory. I feel it's a bit dangerous. The rm command and Ruby's FileUtils#rm_r remove a symlink itself instead.
Thank you!

Good catch! What about a distinct it "doesn't follow symlinks" spec?

@ysbaddaden Thank you. How about my new spec?

@ysbaddaden I can remove the line, but I think it is still needed to assert that rm_r successfully removes a directory even if it has symlinks. Because the older test is not asserting that. Confirm this again. Thanks.

@mosop ok


1.0 Roadmap

I'm starting this issue to discuss our path to a 1.0 release. Please feel free to request features here and discuss areas that need improvement or bug fixes.

[ ] OAuth / Provider test mocking (see omniauth mocking)

[ ] Fake successful auth call for any provider
[ ] Fake unsuccessful auth call for any provider

[ ] Additional Providers for External

[ ] Live Connect (Windows LiveID Replacement)
[x] Flickr (saw an open pull request for this one)
[ ] Yahoo

[ ] Token auth #70

[ ] Support usage of multiple authentications for a single user (not sure if this is already implemented)

[ ] Support accounts without passwords (strictly external auth)

[x] Contribution guide?

Some things that come to mind:

[ ] OAuth / Provider test mocking (see omniauth mocking)
[ ] Additional Providers for External

[ ] Live Connect (Windows LiveID Replacement)
[x] Flickr (saw an open pull request for this one)
[ ] Yahoo

[ ] Support usage of multiple authentications for a single user (not sure if this is already implemented)
[ ] Support accounts without passwords (strictly external auth)

Was  https://github.com/NoamB/sorcery/issues/70 implemented? Should make it into 1.0

@iwada no, #70 hasn't been implemented yet.

I'd like to be able to easily create custom submodules for specific cases (or override the existing ones because I need special functionality). Make them more like a plugin. You could even extract the current submodules into separate gems. Would keep core smaller and easier to maintain. Would also allow for different maintainers for the extracted submodules.
Probably be smart to extract external providers and ORMs in the same way.

@pbougie We've talked about extracting things into gems.

Deprecating rails 3/ruby 1.9 and adding support for rails 5 might be of note? (Good thing to add to the README at least.)

What about this issue? https://github.com/NoamB/sorcery/issues/24

@rubenmoya I'm not sure multiple models being able to authenticate is especially in keeping with the spirit of the gem. Perhaps I'm missing something?

I'm wondering if Sorcery project would be moved to organization to make collaboration easy.

@toshimaru Yeah, that's on the list as well. Ideally at some point soon we will move to Sorcery/sorcery or similar and add several people as maintainers. Presently we're waiting on @NoamB.

@Ch4s3 how about extracting providers-strategies out of Sorcery. Each provider has some hardcoded configuration which can change from time to time, and whole gem have to be updated for the reason of some 3rd party provider changed url. If community agree with this I can make an issue for that and make some experiments on implementing it

@IvanShamatov I expect it to be a lot of work. That said, I think it's the right path forward. If you're willing to start on it then I'll pitch in.

@Ch4s3 I'll do my best, if you take a look at that thread https://github.com/NoamB/sorcery/issues/533 — there are some points on making sorcery work with omniauth and all its already built strategies.

Yeah @IvanShamatov I think Omniauth as discussed in #533 is a good route.

Great news! Thanks to the generosity of Github and whoever originally registered the name, I've managed to create a Sorcery organization. I've invited all the maintainers that I'm aware of to the organization, @arnvald, @Ch4s3, please let me know how we'd like to proceed.
Sorcery/sorcery, here we come. :)

@NoamB, I've invited you as an Owner to the new Sorcery organization.

@Ch4s3, @arnvald, Seeing as a complete refactor seems pretty likely (break modules into multiple gems, use Omniauth strategies for external, etc), what if we set the current work to release towards 0.10.0 instead of 1.0.0, and let 1.0.0 be the first release of the refactored code? It would also help emphasize that the current work (updating to Rails 5, deprecating Rails 3, etc) is breaking changes, but not major changes.

Hey, I like the idea of moving to new organization. @athix thanks for helping with getting the Sorcery name for organization. We'd need to move anyway, because only Noam has access to grant permissions to Github repo and I didn't get any answer from him.
However, I could grant access to rubygems.org, so @Ch4s3 now you can push gem there.
The next step would be to go through all the issues and PRs and move the relevant ones to new organization. Later I'll update the repo readme with the link to new address

@arnvald, @Ch4s3: I copied over the existing Repo to Sorcery/sorcery, so we should be able to start making the transition. Let me know if I need to resend any of the org invites, once you accept you should have full access to everything.

Ok, I'm set up. I'm traveling at the moment, but I'll do some work soon.
On Fri, Sep 16, 2016 at 6:40 PM Josh Buker<EMAIL_ADDRESS>wrote:

@arnvald https://github.com/arnvald, @Ch4s3 https://github.com/Ch4s3:
I copied over the existing Repo to Sorcery/sorcery, so we should be able to
start making the transition. Let me know if I need to resend any of the org
invites, once you accept you should have full access to everything.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NoamB/sorcery/issues/787#issuecomment-247725047, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB2n9HkGRsay0t_DV5KfOxsID8BHSsG7ks5qqxrVgaJpZM4JQyYm
.

I'm following you, guys.

@IvanShamatov find us on the new org repo https://github.com/Sorcery/sorcery/issues/32

at this point, should we figure a 1.0 is probably not coming anytime soon?

@jrochkind Honestly, unless there's a build-up of momentum that seems fairly likely. I (and I assume @Ch4s3 as well) have a lot of other projects to work on that personally feel higher priority. If there's any specific features that you need merged in however, I'd be more than happy to help on a PR.


Iterative categorical matching

As described in #13

Adding notes from discussion to check and implement, then can merge:

[ ] Confirm we can run for the whole population
[ ] Add config table matching: for columns to include optional matching and a value for n_matches (if not passed, no threshold)

The new iterative_match_categorical function does not need to be iterative. We can run an exact match on specified column as shown in the last commit. We do the following:

add all columns to required_columns
keep optional_cols empty - that means we will only have one iteration see here
make n_matches = 0

# Define required columns for matching
required_columns_fixed = [
    "number_adults",
    "number_children",
    "number_cars",
    "num_pension_age",
    "rural_urban_2_categories",
]

# Define optional columns in order of importance (most to least important)
optional_columns_fixed = []

# # Match using iterative matching
matcher_fixed = MatcherExact(
    df_pop=spc_matching,
    df_pop_id="hid",
    df_sample=nts_matching,
    df_sample_id="HouseholdID",
    matching_dict = matching_dfs_dict,
    fixed_cols=required_columns_fixed,
    optional_cols=optional_columns_fixed,
    n_matches=0,
    chunk_size=50000,
    show_progress=True,
)

matches_hh_level_fixed = matcher_fixed.iterative_match_categorical()

[ ] also add docs in the config toml explaining order is the order in which features are dropped

Thanks for adding this @Hussein-Mahfouz, this looks great with the matching algorithm clearer, configurable and tested. As discussed, I'll go ahead and merge this now following running for Greater London as part of #58.


Update zio, zio-streams, zio-test, ... to 2.0.14

About this PR
📦 Updates

dev.zio:zio
dev.zio:zio-streams
dev.zio:zio-test
dev.zio:zio-test-sbt

from 2.0.6 to 2.0.14
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (2.0.6).
You might want to review and update them manually.
project/plugins.sbt

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Superseded by #874.


text encoders

I dont see any code (inside this branch\fork) which download and store T5 model and encoders
May be i am dumb but please show me where (in which .py file) hf_hub_download or wget are used
I see T5_MODEL = "google/t5-v1_1-xxl"  and dont see how it is dowloaded with code

Just follow the chain of function calls.
The model is downloaded by T5Tokenizer.from_pretrained() / T5EncoderModel.from_pretrained() from the transformers library, which will then eventually download the model using the huggingface_hub library.
Check your site-packages if you want to see the code.


change active child

hi
how change active child in circle menu ???????

Hi @HoseinAsadi!
It is not possible to set the selected child programatically.
You would need to implement it yourself. It should be really similar to how tapping an item behaves.

hello and thank you for the really cool menu
i cant add it to fragment because i use view pager indicator  it crashes.

@bagherhasani
Please provide log messages related to the crash


Correction in comment..

Just a little correction in comment.

http://dictionary.cambridge.org/us/grammar/british-grammar/let-let-s


Add SDL_RaiseWindow

FYI: https://github.com/mellinoe/veldrid/issues/97

Right - so is the idea to only expose functions that are needed? I thought it might be cleaner for my code if all the SDL functions are in one place - i.e. in Veldrid.SDL2

yeah, looks like that's the idea.

I don't have a problem with adding useful functions to Veldrid.SDL2, especially if they are windowing- or input-related.


[DISCO] Video streaming started encounters shared_ptr error

My platform is
- Indigo
- Ubuntu 14.04
- Disco Platform

When running roslaunch bebop_driver bebop_node.launch, we received
 INFO] [1481012040.781340550]: Initializing nodelet with 4 worker threads.
[ INFO] [1481012040.842065688]: [BebopSDK] 16:14:00:841 | Bebop:225 - Bebop Cnstr()
[ INFO] [1481012040.842178176]: Nodelet Cstr
[ INFO] [1481012040.852265261]: Connecting to Bebop ...
[ INFO] [1481012040.858184131]: [CB] 16:14:00:858 | Ardrone3PilotingStateFlatTrimChanged:382 - [STATES] Enabling states/ardrone3/PilotingState/FlatTrimChanged
[ INFO] [1481012040.860158026]: [CB] 16:14:00:860 | Ardrone3PilotingStateFlyingStateChanged:426 - [STATES] Enabling states/ardrone3/PilotingState/FlyingStateChanged
[ INFO] [1481012040.862821376]: [CB] 16:14:00:862 | Ardrone3PilotingStateNavigateHomeStateChanged:528 - [STATES] Enabling states/ardrone3/PilotingState/NavigateHomeStateChanged
[ INFO] [1481012040.864662541]: [CB] 16:14:00:864 | Ardrone3PilotingStatePositionChanged:586 - [STATES] Enabling st
....

which seems that ROS has been correctly connect with Parrot Disco, but after a while, we received the following errors
[ INFO] [1481012048.090233874]: Enabling video stream ...
[ WARN] [1481012048.090320800]: [BebopSDK] 16:14:08:090 | StartStreaming:359 - Video streaming started ...
[ INFO] [1481012048.090545332]: Nodelet lwp_id: 8498
[ INFO] [1481012048.090600575]: [CameraThread] thread lwp_id: 8922
[ INFO] [1481012048.090657502]: bebop_driver nodelet loaded.
[ INFO] [1481012048.090768550]: [AuxThread] thread lwp_id: 8923
bebop_driver_node: /usr/local/include/boost/smart_ptr/shared_ptr.hpp:648: typename boost::detail::sp_member_access<T>::type boost::shared_ptr<T>::operator->() const [with T = const bebop_msgs::Ardrone3PilotingStatePositionChanged_<std::allocator<void> >; typename boost::detail::sp_member_access<T>::type = const bebop_msgs::Ardrone3PilotingStatePositionChanged_<std::allocator<void> >*]: Assertion `px != 0' failed.
[bebop/bebop_driver-2] process has died [pid 8498, exit code -6, cmd /home/alvin/bebop_ws/devel/lib/bebop_driver/bebop_driver_node __name:=bebop_driver __log:=/home/alvin/.ros/log/f0e64cc0-bb8b-11e6-ac45-34de1a0f21c0/bebop-bebop_driver-2.log].
log file: /home/alvin/.ros/log/f0e64cc0-bb8b-11e6-ac45-34de1a0f21c0/bebop-bebop_driver-2*.log

I googled and found that it might be the boost::shared_ptr error, however, I am not so familiar with boost and bebop_autonomy source code.
Would it be possible to share some information about this issue？
Thanks.

Thanks for this bug report. Unfortunately I do not have access to a Disco FPV and I can not confirm that this driver works (at least without further modification) with the Disco. However, the issue you are facing might be caused by a bug in the driver's code.
Could you please change this line from:
if ((gps_state_ptr->header.stamp - last_gps_time).toSec() > util::eps)

to
if (gps_state_ptr && ((gps_state_ptr->header.stamp - last_gps_time).toSec() > util::eps))

and recompile/test the driver?

@mani-monaj Hi, thank you for your kind reply.
I recompiled the whole package as you recommended, and received the similar errors
...
[ WARN] [1481511105.839228628]: [ARNETWORK_Receiver] 10:51:45:839 | ARNETWORK_Receiver_ThreadRun:271 - [0x7f75342812c0] Received an old frame for buffer 127
[ WARN] [1481511105.841021120]: [ARNETWORK_Receiver] 10:51:45:840 | ARNETWORK_Receiver_ThreadRun:271 - [0x7f75342812c0] Received an old frame for buffer 127
[ WARN] [1481511105.841111476]: [ARNETWORK_Receiver] 10:51:45:841 | ARNETWORK_Receiver_ThreadRun:271 - [0x7f75342812c0] Received an old frame for buffer 127
[ INFO] [1481511109.201209276]: Dynamic reconfigure callback with level: -1
[ INFO] [1481511109.232303990]: Enabling video stream ...
[ WARN] [1481511109.232424631]: [BebopSDK] 10:51:49:232 | StartStreaming:359 - Video streaming started ...
[ INFO] [1481511109.232769860]: Nodelet lwp_id: 10372
[ INFO] [1481511109.232848724]: [CameraThread] thread lwp_id: 10758
[ INFO] [1481511109.232944684]: [AuxThread] thread lwp_id: 10759
[ INFO] [1481511109.233010189]: bebop_driver nodelet loaded.
bebop_driver_node: /usr/include/boost/smart_ptr/shared_ptr.hpp:653: typename boost::detail::sp_member_access<T>::type boost::shared_ptr<T>::operator->() const [with T = const bebop_msgs::Ardrone3PilotingStateSpeedChanged_<std::allocator<void> >; typename boost::detail::sp_member_access<T>::type = const bebop_msgs::Ardrone3PilotingStateSpeedChanged_<std::allocator<void> >*]: Assertion `px != 0' failed.
[bebop/bebop_driver-2] process has died [pid 10372, exit code -6, cmd /home/amax/Workspace/120.bebop_autonomy/devel/lib/bebop_driver/bebop_driver_node __name:=bebop_driver __log:=/home/amax/.ros/log/df071712-c015-11e6-9a86-001d4320131b/bebop-bebop_driver-2.log].
log file: /home/amax/.ros/log/df071712-c015-11e6-9a86-001d4320131b/bebop-bebop_driver-2*.log
^C[rosout-1] killing on exit
[master] killing on exit
^Cshutting down processing monitor...
... shutting down processing monitor complete
done

by running
roslaunch bebop_driver bebop_node.launch

Should we change all the shared_ptr related codes? Thanks.

Thanks for the update. I think the problem is that the driver's code does not properly guard against all cases of NULL [shared] pointers before accessing them.
Looking at the code and your error report, I guess the problem is from this line:
if ((speed_esd_ptr->header.stamp - last_speed_time).toSec() > util::eps)

Could you please change it to
if (speed_esd_ptr && ((speed_esd_ptr->header.stamp - last_speed_time).toSec() > util::eps))

Then recompile and test?
Since I do not have access to a Disco, it is helpful if you could run the driver in a debugger such as gdb. This is what I use to run a Nodelet with gdb:
$ rosrun --prefix "gdb --args" nodelet nodelet standalone bebop_driver/BebopDriverNodelet

Prior to running this command, please catkin clean your workspace and recompile it with catkin build -DCMAKE_BUILD_TYPE=Debug [or -DCMAKE_BUILD_TYPE=RelWithDebInfo. When gdb starts, use the run command to execute the code. When it SEGFAULTS, use bt to get the call stack that led to the fault. You may find this tutorial helpful.

@mani-monaj Hi, sorry for my late testing. The camera streams was receivedl, as shown

but there were some warnings related to H264Filter
[ WARN] [1482484759.094475629]: [ARSTREAM2_H264Filter] 17:19:19:094 | ARSTREAM2_H264Filter_fillMissingSlices:1660 - #222 AUTS:879945444 Missing NALU is probably a slice
[ WARN] [1482484759.094522639]: [ARSTREAM2_H264Filter] 17:19:19:094 | ARSTREAM2_H264Filter_fillMissingSlices:1703 - #222 AUTS:879945444 Current slice is not a P-slice, aborting
[ WARN] [1482484759.097729950]: [ARSTREAM2_H264Filter] 17:19:19:097 | ARSTREAM2_H264Filter_enqueueCurrentAu:1006 - AU output cancelled (!outputIncompleteAu)
[ WARN] [1482484759.925153540]: [ARSTREAM2_H264Filter] 17:19:19:925 | ARSTREAM2_H264Filter_fillMissingSlices:1621 - #226 AUTS:880779600 previousSliceFirstMb:960 previousSliceMbCount:160 currentSliceFirstM

Another problem is, I could not access the autopilot state, following are the topic list and service list.
/bebop/autoflight/navigate_home
/bebop/autoflight/pause
/bebop/autoflight/start
/bebop/autoflight/stop
/bebop/bebop_driver/parameter_descriptions
/bebop/bebop_driver/parameter_updates
/bebop/camera_control
/bebop/camera_info
/bebop/cmd_vel
/bebop/fix
/bebop/flattrim
/bebop/flip
/bebop/image_raw
/bebop/image_raw/compressed
/bebop/image_raw/compressed/parameter_descriptions
/bebop/image_raw/compressed/parameter_updates
/bebop/image_raw/compressedDepth
/bebop/image_raw/compressedDepth/parameter_descriptions
/bebop/image_raw/compressedDepth/parameter_updates
/bebop/image_raw/theora
/bebop/image_raw/theora/parameter_descriptions
/bebop/image_raw/theora/parameter_updates
/bebop/joint_states
/bebop/land
/bebop/odom
/bebop/record
/bebop/reset
/bebop/snapshot
/bebop/states/ardrone3/CameraState/Orientation
/bebop/states/ardrone3/GPSState/NumberOfSatelliteChanged
/bebop/states/ardrone3/MediaStreamingState/VideoEnableChanged
/bebop/states/ardrone3/PilotingState/AltitudeChanged
/bebop/states/ardrone3/PilotingState/AttitudeChanged
/bebop/states/ardrone3/PilotingState/FlatTrimChanged
/bebop/states/ardrone3/PilotingState/FlyingStateChanged
/bebop/states/ardrone3/PilotingState/NavigateHomeStateChanged
/bebop/states/ardrone3/PilotingState/PositionChanged
/bebop/states/ardrone3/PilotingState/SpeedChanged
/bebop/states/common/CommonState/BatteryStateChanged
/bebop/states/common/CommonState/WifiSignalChanged
/bebop/states/common/FlightPlanState/AvailabilityStateChanged
/bebop/states/common/FlightPlanState/ComponentStateListChanged
/bebop/states/common/MavlinkState/MavlinkFilePlayingStateChanged
/bebop/states/common/MavlinkState/MavlinkPlayErrorStateChanged
/bebop/states/common/OverHeatState/OverHeatChanged
/bebop/takeoff
/rosout
/rosout_agg
/tf

these optics seems dead becasue I could not use rostopic echo to get data and the rqt_graph shows nothing about this topcis.
/bebop/bebop_driver/get_loggers
/bebop/bebop_driver/list
/bebop/bebop_driver/load_nodelet
/bebop/bebop_driver/set_logger_level
/bebop/bebop_driver/set_parameters
/bebop/bebop_driver/unload_nodelet
/bebop/image_raw/compressed/set_parameters
/bebop/image_raw/compressedDepth/set_parameters
/bebop/image_raw/theora/set_parameters
/bebop/set_camera_info
/rosout/get_loggers
/rosout/set_logger_level

Thanks @weiweikong for the update.

To clarify, does the changes I propose fix the segfault issue? Could you please send a Pull Request with all those changes if that's the case?

Could you please run the driver, do a rosbag recored -a and upload/share the resulting bag file with me? It can be huge since it will include non-compressed image topics. The order I suggest to run the commands is:

Run roscore

rosbag record -a

Launch the driver

Kill the recored script after 30 seconds or so.

Sorry for my late replay.
rosbag record -a failed
When I run the command line
rosbag record -a

there were following warnings and the nodes crashed
[ INFO] [1483364228.753029394]: [CB] 21:37:08:752 | Update:1420 -   No
[ INFO] [1483364228.754733563]: Value for NetworkSettingsWifiSelectionBand recved: 0
[ INFO] [1483364228.754828603]: [CB] 21:37:08:754 | Update:1438 - Checking if NetworkSettingsWifiSelectionBand exists in params ...
[ INFO] [1483364228.755995494]: [CB] 21:37:08:755 | Update:1441 -   No
[ INFO] [1483364228.757409919]: Value for NetworkSettingsWifiSelectionChannel recved: 6
[ INFO] [1483364228.757477382]: [CB] 21:37:08:757 | Update:1459 - Checking if NetworkSettingsWifiSelectionChannel exists in params ...
[ INFO] [1483364228.758744974]: [CB] 21:37:08:758 | Update:1462 -   No
[ INFO] [1483364228.771349406]: Value for PictureSettingsVideoStabilizationModeMode recved: 3
[ INFO] [1483364228.771445612]: [CB] 21:37:08:771 | Update:1539 - Checking if PictureSettingsVideoStabilizationModeMode exists in params ...
[ INFO] [1483364228.772760891]: [CB] 21:37:08:772 | Update:1547 -   Yes
[ INFO] [1483364228.780480640]: Value for GPSSettingsReturnHomeDelayDelay recved: 10
[ INFO] [1483364228.780566953]: [CB] 21:37:08:780 | Update:1939 - Checking if GPSSettingsReturnHomeDelayDelay exists in params ...
[ INFO] [1483364228.781891282]: [CB] 21:37:08:781 | Update:1947 -   Yes
[ INFO] [1483364228.783519477]: Value for GPSSettingsHomeTypeType recved: 0
[ INFO] [1483364228.783627727]: [CB] 21:37:08:783 | Update:1859 - Checking if GPSSettingsHomeTypeType exists in params ...
[ INFO] [1483364228.784873432]: [CB] 21:37:08:784 | Update:1867 -   Yes
[ INFO] [1483364232.038771032]: Dynamic reconfigure callback with level: -1
[ INFO] [1483364232.038956437]: [CB] 21:37:12:038 | UpdateBebopFromROS:309 - PilotingSettingsMaxDistanceValue changed!
[ INFO] [1483364232.039010804]: [CB] 21:37:12:038 | UpdateBebopFromROS:323 - Sending PilotingSettingsMaxDistance changes to bebop
[ INFO] [1483364232.056417989]: Value for PilotingSettingsMaxDistanceValue recved: 200
[ INFO] [1483364232.056491649]: [CB] 21:37:12:056 | Update:351 - Checking if PilotingSettingsMaxDistanceValue exists in params ...
[ INFO] [1483364232.057692696]: [CB] 21:37:12:057 | Update:359 -   Yes
[ INFO] [1483364232.072941835]: Enabling video stream ...
[ WARN] [1483364232.073075975]: [BebopSDK] 21:37:12:073 | StartStreaming:359 - Video streaming started ...
[ INFO] [1483364232.073392469]: Nodelet lwp_id: 19021
[ INFO] [1483364232.073478692]: [CameraThread] thread lwp_id: 19433
[ INFO] [1483364232.073590521]: [AuxThread] thread lwp_id: 19434
[ INFO] [1483364232.073664378]: bebop_driver nodelet loaded.
[ WARN] [1483364232.155402193]: [ARSTREAM2_H264Filter] 21:37:12:155 | ARSTREAM2_H264Filter_RtpReceiverNaluCallback:2174 - ARSTREAM2_RtpReceiver NALU buffer is too small, truncated AU (or maybe it's the fi
[ WARN] [1483364232.191659456]: [ARSTREAM2_H264Filter] 21:37:12:191 | ARSTREAM2_H264Filter_enqueueCurrentAu:1018 - AU output cancelled (waitForSync)
[ WARN] [1483364232.327678192]: [ARSTREAM2_H264Filter] 21:37:12:327 | ARSTREAM2_H264Filter_sync:550 - SPS/PPS sync OK
[ INFO] [1483364232.327748749]: [BebopSDK] 21:37:12:327 | DecoderConfigCallback:147 - H264 configuration packet received: #SPS: 26 #PPS: 9 (MP4? 0)
[ WARN] [1483364232.327901892]: [ARSTREAM2_H264Filter] 21:37:12:327 | ARSTREAM2_H264Filter_generateGrayIFrame:1254 - Waiting for a slice to generate gray I-frame
[ WARN] [1483364232.327967009]: [ARSTREAM2_H264Filter] 21:37:12:327 | ARSTREAM2_H264Filter_generateGrayIFrame:1254 - Waiting for a slice to generate gray I-frame
[ WARN] [1483364232.328274023]: [ARSTREAM2_H264Filter] 21:37:12:328 | ARSTREAM2_H264Filter_generateGrayIFrame:1322 - Gray I slice NALU output size: 3609
[ INFO] [1483364232.328330583]: [BebopSDK] 21:37:12:328 | FrameReceivedCallback:174 - Frame Recv & Decode LWP id: 19436
[ INFO] [1483364232.329614947]: [Decoder] 21:37:12:329 | InitCodec:117 - H264 Codec is partially initialized!
[ INFO] [1483364232.329667044]: [Decoder] 21:37:12:329 | Decode:263 - Updating H264 codec parameters (Buffer Size: 35) ...
[ERROR] [1483364232.337201280]: [Decoder] 21:37:12:337 | Decode:302 - Frame size changed to 1280 x 720
[ INFO] [1483364232.337291103]: [Decoder] 21:37:12:337 | ReallocateBuffers:123 - Buffer reallocation request
[ INFO] [1483364232.345410540]: camera calibration URL: package://bebop_driver/data/bebop_camera_calib.yaml
[ WARN] [1483364232.849684167]: [ARSTREAM2_H264Filter] 21:37:12:849 | ARSTREAM2_H264Filter_fillMissingSlices:1660 - #4 AUTS:163231289 Missing NALU is probably a slice
[ WARN] [1483364232.849788518]: [ARSTREAM2_H264Filter] 21:37:12:849 | ARSTREAM2_H264Filter_fillMissingSlices:1688 - #4 AUTS:163231289 Streaming info is not available
[ WARN] [1483364232.879619300]: [ARSTREAM2_H264Filter] 21:37:12:879 | ARSTREAM2_H264Filter_enqueueCurrentAu:1006 - AU output cancelled (!outputIncompleteAu)
[ WARN] [1483364233.867120714]: [ARSTREAM2_H264Filter] 21:37:13:867 | ARSTREAM2_H264Filter_fillMissingSlices:1621 - #9 AUTS:164232278 previousSliceFirstMb:2560 previousSliceMbCount:160 currentSliceFirstMb
[ WARN] [1483364233.867220104]: [ARSTREAM2_H264Filter] 21:37:13:867 | ARSTREAM2_H264Filter_fillMissingSlices:1660 - #9 AUTS:164232278 Missing NALU is probably a slice
[ WARN] [1483364233.867289447]: [ARSTREAM2_H264Filter] 21:37:13:867 | ARSTREAM2_H264Filter_fillMissingSlices:1735 - #9 AUTS:164232278 Skipped P slice NALU output size: 14
[ WARN] [1483364234.828379126]: [ARSTREAM2_H264Filter] 21:37:14:828 | ARSTREAM2_H264Filter_fillMissingSlices:1621 - #14 AUTS:165066444 previousSliceFirstMb:3040 previousSliceMbCount:160 currentSliceFirstM
[ WARN] [1483364234.828481850]: [ARSTREAM2_H264Filter] 21:37:14:828 | ARSTREAM2_H264Filter_fillMissingSlices:1660 - #14 AUTS:165066444 Missing NALU is probably a slice
[ WARN] [1483364234.828534436]: [ARSTREAM2_H264Filter] 21:37:14:828 | ARSTREAM2_H264Filter_fillMissingSlices:1735 - #14 AUTS:165066444 Skipped P slice NALU output size: 14
[ WARN] [1483364235.708033429]: [ARSTREAM2_H264Filter] 21:37:15:707 | ARSTREAM2_H264Filter_fillMissingSlices:1621 - #20 AUTS:166067433 previousSliceFirstMb:2880 previousSliceMbCount:160 currentSliceFirstM
[ WARN] [1483364235.708122364]: [ARSTREAM2_H264Filter] 21:37:15:708 | ARSTREAM2_H264Filter_fillMissingSlices:1660 - #20 AUTS:166067433 Missing NALU is probably a slice
[ WARN] [1483364235.708183792]: [ARSTREAM2_H264Filter] 21:37:15:708 | ARSTREAM2_H264Filter_fillMissingSlices:1735 - #20 AUTS:166067433 Skipped P slice NALU output size: 14
[ERROR] [1483364235.718997728]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364235.869788093]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ WARN] [1483364236.105199278]: [ARSTREAM2_H264Filter] 21:37:16:105 | ARSTREAM2_H264Filter_fillMissingSlices:1621 - #22 AUTS:166401089 previousSliceFirstMb:1760 previousSliceMbCount:160 currentSliceFirstM
[ WARN] [1483364236.105304645]: [ARSTREAM2_H264Filter] 21:37:16:105 | ARSTREAM2_H264Filter_fillMissingSlices:1660 - #22 AUTS:166401089 Missing NALU is probably a slice
[ WARN] [1483364236.105353805]: [ARSTREAM2_H264Filter] 21:37:16:105 | ARSTREAM2_H264Filter_fillMissingSlices:1703 - #22 AUTS:166401089 Current slice is not a P-slice, aborting
[ WARN] [1483364236.105432652]: [ARSTREAM2_H264Filter] 21:37:16:105 | ARSTREAM2_H264Filter_enqueueCurrentAu:1006 - AU output cancelled (!outputIncompleteAu)
[ERROR] [1483364236.194404638]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364236.368872766]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364236.519622992]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364236.686597241]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364236.866207055]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364237.040443423]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364237.194072226]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364237.368995708]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364237.568133959]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364237.706373040]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364237.862976849]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364238.029445407]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364238.207800515]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364238.377621552]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ WARN] [1483364238.553557064]: [ARSTREAM2_H264Filter] 21:37:18:553 | ARSTREAM2_H264Filter_fillMissingSlices:1621 - #36 AUTS:168903567 previousSliceFirstMb:1120 previousSliceMbCount:160 currentSliceFirstM
[ WARN] [1483364238.553662374]: [ARSTREAM2_H264Filter] 21:37:18:553 | ARSTREAM2_H264Filter_fillMissingSlices:1660 - #36 AUTS:168903567 Missing NALU is probably a slice
[ WARN] [1483364238.553744020]: [ARSTREAM2_H264Filter] 21:37:18:553 | ARSTREAM2_H264Filter_fillMissingSlices:1735 - #36 AUTS:168903567 Skipped P slice NALU output size: 13
[ERROR] [1483364238.564942387]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364238.707610524]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364238.924333099]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364239.041933244]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364239.222264614]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364239.381847730]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364239.543403647]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364239.693019626]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364239.862729064]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364240.031721912]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ WARN] [1483364240.214733317]: [ARSTREAM2_H264Filter] 21:37:20:214 | ARSTREAM2_H264Filter_fillMissingSlices:1660 - #46 AUTS:170571889 Missing NALU is probably a slice
[ WARN] [1483364240.214801296]: [ARSTREAM2_H264Filter] 21:37:20:214 | ARSTREAM2_H264Filter_fillMissingSlices:1688 - #46 AUTS:170571889 Streaming info is not available
[ WARN] [1483364240.214908181]: [ARSTREAM2_H264Filter] 21:37:20:214 | ARSTREAM2_H264Filter_enqueueCurrentAu:1006 - AU output cancelled (!outputIncompleteAu)
[ERROR] [1483364240.371076192]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364240.523647819]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ WARN] [1483364240.724804942]: [ARSTREAM2_H264Filter] 21:37:20:724 | ARSTREAM2_H264Filter_fillMissingSlices:1621 - #48 AUTS:171072389 previousSliceFirstMb:320 previousSliceMbCount:160 currentSliceFirstMb
[ WARN] [1483364240.724905439]: [ARSTREAM2_H264Filter] 21:37:20:724 | ARSTREAM2_H264Filter_fillMissingSlices:1660 - #48 AUTS:171072389 Missing NALU is probably a slice
[ WARN] [1483364240.724960989]: [ARSTREAM2_H264Filter] 21:37:20:724 | ARSTREAM2_H264Filter_fillMissingSlices:1735 - #48 AUTS:171072389 Skipped P slice NALU output size: 13
[ERROR] [1483364240.744473982]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ WARN] [1483364240.873289929]: [ARSTREAM2_H264Filter] 21:37:20:873 | ARSTREAM2_H264Filter_fillMissingSlices:1621 - #49 AUTS:171239211 previousSliceFirstMb:160 previousSliceMbCount:160 currentSliceFirstMb
[ WARN] [1483364240.873376826]: [ARSTREAM2_H264Filter] 21:37:20:873 | ARSTREAM2_H264Filter_fillMissingSlices:1660 - #49 AUTS:171239211 Missing NALU is probably a slice
[ WARN] [1483364240.873427042]: [ARSTREAM2_H264Filter] 21:37:20:873 | ARSTREAM2_H264Filter_fillMissingSlices:1735 - #49 AUTS:171239211 Skipped P slice NALU output size: 13
[ERROR] [1483364240.885535517]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364241.060601196]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ WARN] [1483364241.228509686]: [ARSTREAM2_H264Filter] 21:37:21:228 | ARSTREAM2_H264Filter_fillMissingSlices:1621 - #51 AUTS:171572878 previousSliceFirstMb:2720 previousSliceMbCount:160 currentSliceFirstM
[ WARN] [1483364241.228596233]: [ARSTREAM2_H264Filter] 21:37:21:228 | ARSTREAM2_H264Filter_fillMissingSlices:1660 - #51 AUTS:171572878 Missing NALU is probably a slice
[ WARN] [1483364241.228665956]: [ARSTREAM2_H264Filter] 21:37:21:228 | ARSTREAM2_H264Filter_fillMissingSlices:1735 - #51 AUTS:171572878 Skipped P slice NALU output size: 14
[ERROR] [1483364241.239967276]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364241.413180179]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364241.540202121]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ WARN] [1483364241.835026202]: [ARSTREAM2_RtpReceiver] 21:37:21:834 | ARSTREAM2_RtpReceiver_ProcessData:1251 - Change of timestamp without marker bit set on previous packet
[ WARN] [1483364241.835119066]: [ARSTREAM2_H264Filter] 21:37:21:835 | ARSTREAM2_H264Filter_fillMissingEndOfFrame:1803 - #54 AUTS:172073378 missingMb:400 firstMbInSlice:3200
[ WARN] [1483364241.835170742]: [ARSTREAM2_H264Filter] 21:37:21:835 | ARSTREAM2_H264Filter_fillMissingEndOfFrame:1835 - #54 AUTS:172073378 Missing NALU is probably a slice
[ WARN] [1483364241.835228299]: [ARSTREAM2_H264Filter] 21:37:21:835 | ARSTREAM2_H264Filter_fillMissingEndOfFrame:1910 - #54 AUTS:172073378 Skipped P slice NALU output size: 14
[ WARN] [1483364241.845122071]: [ARSTREAM2_H264Filter] 21:37:21:845 | ARSTREAM2_H264Filter_fillMissingSlices:1584 - #55 AUTS:172240211 Missing NALU is probably a SPS, PPS or SEI or on previous AU => OK
[ERROR] [1483364241.847111286]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364241.868995196]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364242.034487413]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).
[ERROR] [1483364242.200640873]: Compressed Depth Image Transport - Compression requires single-channel 32bit-floating point or 16bit raw depth images (input format is: rgb8).

it seems that the bag record could not save the data correctly.
However, without rosbag action, we could see the image stream correctly through rqt_gui.
Running the driver again, sometimes encountered following errors.
$ roslaunch bebop_driver bebop_node.launch
... logging to /home/amax/.ros/log/67d14ee8-d0ef-11e6-ade1-001d4320131b/roslaunch-amax-X10DRi-16459.log
Checking log directory for disk usage. This may take awhile.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.

started roslaunch server http://amax-X10DRi:38870/

SUMMARY
========

PARAMETERS
 * /bebop/bebop_driver/bebop_ip: <IP_ADDRESS>
 * /bebop/bebop_driver/camera_info_url: package://bebop_d...
 * /bebop/bebop_driver/cmd_vel_timeout: 0.2
 * /bebop/bebop_driver/odom_frame_id: odom
 * /bebop/bebop_driver/publish_odom_tf: True
 * /bebop/bebop_driver/reset_settings: True
 * /bebop/bebop_driver/states/enable_altitudechanged: True
 * /bebop/bebop_driver/states/enable_autotakeoffmodechanged: True
 * /bebop/bebop_driver/states/enable_camerastate_orientation: True
 * /bebop/bebop_driver/states/enable_commonstate_batterystatechanged: True
 * /bebop/bebop_driver/states/enable_commonstate_wifisignalchanged: True
 * /bebop/bebop_driver/states/enable_controllerstate_ispilotingchanged: True
 * /bebop/bebop_driver/states/enable_flightplanstate_availabilitystatechanged: True
 * /bebop/bebop_driver/states/enable_flightplanstate_componentstatelistchanged: True
 * /bebop/bebop_driver/states/enable_gpsstate_numberofsatellitechanged: True
 * /bebop/bebop_driver/states/enable_mavlinkstate_mavlinkfileplayingstatechanged: True
 * /bebop/bebop_driver/states/enable_mavlinkstate_mavlinkplayerrorstatechanged: True
 * /bebop/bebop_driver/states/enable_mediastreamingstate_videoenablechanged: True
 * /bebop/bebop_driver/states/enable_numberofsatellitechanged: True
 * /bebop/bebop_driver/states/enable_overheatstate_overheatchanged: True
 * /bebop/bebop_driver/states/enable_pilotingstate_altitudechanged: True
 * /bebop/bebop_driver/states/enable_pilotingstate_attitudechanged: True
 * /bebop/bebop_driver/states/enable_pilotingstate_flattrimchanged: True
 * /bebop/bebop_driver/states/enable_pilotingstate_flyingstatechanged: True
 * /bebop/bebop_driver/states/enable_pilotingstate_navigatehomestatechanged: True
 * /bebop/bebop_driver/states/enable_pilotingstate_positionchanged: True
 * /bebop/bebop_driver/states/enable_pilotingstate_speedchanged: True
 * /rosdistro: jade
 * /rosversion: 1.11.20

NODES
  /bebop/
    bebop_driver (bebop_driver/bebop_driver_node)

ROS_MASTER_URI=http://localhost:11311

core service [/rosout] found
process[bebop/bebop_driver-1]: started with pid [16478]
[ INFO] [1483363743.860228667]: Initializing nodelet with 24 worker threads.
[ INFO] [1483363743.937334855]: [BebopSDK] 21:29:03:937 | Bebop:225 - Bebop Cnstr()
[ INFO] [1483363743.937479750]: Nodelet Cstr
[ INFO] [1483363743.951448377]: Connecting to Bebop ...
[ INFO] [1483363743.958524284]: [CB] 21:29:03:958 | Ardrone3PilotingStateFlatTrimChanged:382 - [STATES] Enabling states/ardrone3/PilotingState/FlatTrimChanged
[ INFO] [1483363743.961307858]: [CB] 21:29:03:961 | Ardrone3PilotingStateFlyingStateChanged:426 - [STATES] Enabling states/ardrone3/PilotingState/FlyingStateChanged
[ INFO] [1483363743.965026216]: [CB] 21:29:03:964 | Ardrone3PilotingStateNavigateHomeStateChanged:528 - [STATES] Enabling states/ardrone3/PilotingState/NavigateHomeStateChanged
[ INFO] [1483363743.967815264]: [CB] 21:29:03:967 | Ardrone3PilotingStatePositionChanged:586 - [STATES] Enabling states/ardrone3/PilotingState/PositionChanged
[ INFO] [1483363743.970562269]: [CB] 21:29:03:970 | Ardrone3PilotingStateSpeedChanged:651 - [STATES] Enabling states/ardrone3/PilotingState/SpeedChanged
[ INFO] [1483363743.973231005]: [CB] 21:29:03:973 | Ardrone3PilotingStateAttitudeChanged:716 - [STATES] Enabling states/ardrone3/PilotingState/AttitudeChanged
[ INFO] [1483363743.977066743]: [CB] 21:29:03:977 | Ardrone3PilotingStateAltitudeChanged:832 - [STATES] Enabling states/ardrone3/PilotingState/AltitudeChanged
[ INFO] [1483363743.986335192]: [CB] 21:29:03:986 | Ardrone3MediaStreamingStateVideoEnableChanged:1245 - [STATES] Enabling states/ardrone3/MediaStreamingState/VideoEnableChanged
[ INFO] [1483363743.990059231]: [CB] 21:29:03:990 | Ardrone3CameraStateOrientation:1347 - [STATES] Enabling states/ardrone3/CameraState/Orientation
[ INFO] [1483363743.996099879]: [CB] 21:29:03:996 | Ardrone3GPSStateNumberOfSatelliteChanged:1565 - [STATES] Enabling states/ardrone3/GPSState/NumberOfSatelliteChanged
[ INFO] [1483363744.003564555]: [CB] 21:29:04:003 | CommonCommonStateBatteryStateChanged:146 - [STATES] Enabling states/common/CommonState/BatteryStateChanged
[ INFO] [1483363744.012018098]: [CB] 21:29:04:011 | CommonCommonStateWifiSignalChanged:508 - [STATES] Enabling states/common/CommonState/WifiSignalChanged
[ INFO] [1483363744.021283716]: [CB] 21:29:04:021 | CommonOverHeatStateOverHeatChanged:963 - [STATES] Enabling states/common/OverHeatState/OverHeatChanged
[ INFO] [1483363744.024872899]: [CB] 21:29:04:024 | CommonMavlinkStateMavlinkFilePlayingStateChanged:1058 - [STATES] Enabling states/common/MavlinkState/MavlinkFilePlayingStateChanged
[ INFO] [1483363744.027500237]: [CB] 21:29:04:027 | CommonMavlinkStateMavlinkPlayErrorStateChanged:1123 - [STATES] Enabling states/common/MavlinkState/MavlinkPlayErrorStateChanged
[ INFO] [1483363744.035790733]: [CB] 21:29:04:035 | CommonFlightPlanStateAvailabilityStateChanged:1457 - [STATES] Enabling states/common/FlightPlanState/AvailabilityStateChanged
[ INFO] [1483363744.038355413]: [CB] 21:29:04:038 | CommonFlightPlanStateComponentStateListChanged:1508 - [STATES] Enabling states/common/FlightPlanState/ComponentStateListChanged
[ INFO] [1483363744.057407953]: [ARCONTROLLER_Network] 21:29:04:057 | ARCONTROLLER_Network_GetAvailableSocketPort:108 - d2c_port port: 44586
[ INFO] [1483363744.057753144]: [ARCONTROLLER_Stream2] 21:29:04:057 | ARCONTROLLER_Stream2_Open_Socket:122 - udp local port stream: 54803
[ INFO] [1483363744.057810341]: [ARCONTROLLER_Stream2] 21:29:04:057 | ARCONTROLLER_Stream2_Open_Socket:122 - udp local port control: 54024
[ERROR] [1483363749.063183500]: [ARDISCOVERY_Device] 21:29:09:063 | ARDISCOVERY_Device_NewARNetworkAL:241 - error: timeout error
[ERROR] [1483363749.063281283]: [ARCONTROLLER_Network] 21:29:09:063 | ARCONTROLLER_Network_New:335 - error: Error during the getting of the ARNETWORKAL_Manager from the device
[ INFO] [1483363749.063485440]: [ARCONTROLLER_Device] 21:29:09:063 | ARCONTROLLER_Device_StartRun:4815 - Start failed or canceled.
[ERROR] [1483363749.063616357]: [ARCONTROLLER_Device] 21:29:09:063 | ARCONTROLLER_Device_StopNetwork:5288 - Error occured durring unregistering ARCommands to the feature ARCONTROLLER_DICTIONARY_KEY_ARDRO
[ERROR] [1483363749.063672050]: [ARCONTROLLER_Device] 21:29:09:063 | ARCONTROLLER_Device_StopNetwork:5297 - Error occured durring unregistering ARCommands to the feature ARCONTROLLER_DICTIONARY_KEY_COMMO
[ERROR] [1483363749.063723330]: [ARCONTROLLER_Device] 21:29:09:063 | ARCONTROLLER_Device_StopRun:4858 - StopNetwork failed with error :Bad parameters
[ERROR] [1483363749.063797837]: [ARCONTROLLER_Device] 21:29:09:063 | ARCONTROLLER_Device_StartRun:4823 - Start fail error :Error during the getting of the ARNETWORKAL_Manager from the device
[ INFO] [1483363749.064076647]: [BebopSDK] 21:29:09:064 | Cleanup:326 - Bebop Cleanup()
[FATAL] [1483363749.064461464]: Init failed: Waiting for device failed: No error
[ INFO] [1483363749.064663151]: Bebop Nodelet Dstr: 0
[ INFO] [1483363749.064700328]: Killing Camera Thread ...
[ INFO] [1483363749.064739088]: Killing Aux Thread ...
[bebop/bebop_driver-1] process has died [pid 16478, exit code -11, cmd /home/amax/Workspace/120.bebop_autonomy/devel/lib/bebop_driver/bebop_driver_node __name:=bebop_driver __log:=/home/amax/.ros/log/67d14ee8-d0ef-11e6-ade1-001d4320131b/bebop-bebop_driver-1.log].
log file: /home/amax/.ros/log/67d14ee8-d0ef-11e6-ade1-001d4320131b/bebop-bebop_driver-1*.log
all processes on machine have died, roslaunch will exit
shutting down processing monitor...
... shutting down processing monitor complete

Other topics information
Would it be possible to access autopilot data such as IMU, gyro raw data through the driver by ROS node?

@mani-monaj  Any update about other topic information with ROS node?

Any update @mani-monaj ?

@weiweikong Sorry for my delayed response. I will be back on the development track very soon. I will update this issue with my answers. Any update on your side?

@mani-monaj No more update. : (

Hello @weiweikong,
Sorry for the late reply. The bebop_autonomy ros driver is currently limited to the information that is provided by the Parrot, so information such as IMU, gyro raw data is not available. Here is a link to the list of information that these Parrot drones can provide http://developer.parrot.com/docs/reference/all/index.html. We hope to work towards providing support for the Disco platform (which upgrading to the latest SDK will add some new information for).

Disco is supported in #168.


Using pytest-pyvista to improve tests of geovista

📰 Custom Issue

pytest-pyvista is a plugin to test PyVista plot outputs.
We can add tests of geovista's plotting using this.

@tkoyama010 Cool.
Ultimately I'm aiming to use https://github.com/matplotlib/pytest-mpl/pull/150.
This may complement the testing framework you're suggesting?

Nice. It might be a good idea to encourage PyVista to move from pytest-pyvista to pytest-mpl based on that.

@tkoyama010 We've using the perceptual image hash approach on SciTools/iris for a few years now, so I'm pretty satisfied that it gives the stability and control to detect image differences.
I'm keen to get my PR merged on pytest-mpl (it's well overdue) and there is also talk of pytest-mpl being capable to test images that are not generated by matplotlib. I definitely interested in helping make that happen on pytest-mpl as it will allow me to use that testing infrastructure with geovista.
I'll take a peek at pytest-pyvista to see how it works too, out of interest 👍

there is also talk of pytest-mpl being capable to test images that are not generated by matplotlib.

Great. Could you point me to where the talk thread is? I am really interested in it.

See https://github.com/matplotlib/pytest-mpl/issues/201
But I've talked to other pytest-mpl core devs about this capability.

I would expect pytest-pyvista to be more profitable than pytest-mpl for GeoVista, but I don't think I can explain it because of my less knowledge of pytest-pyvista.
@MatthewFlamm I would like to hear your opinion if you like.

I'm not super familiar to pytest-mpl but these packages look very similar.  One problem with using pytest-mpl even if it becomes more generic is that it will require a lot of boilerplate and tinkering to get testing to work with pyvista.
pytest-pyvista hooks natively into PyVista, so you can do:
def test_my_plot(verify_image_cache):
    pv.Sphere.plot()

and it will do the image comparison.
In an ideal world in the scientific software field we would have a meta level comparing tool that is agnostic for how the images are generated.  Then each tool provides a wrapper for generating those images.
But practically and selfishly, I think it benefits the pyvista community more if we make pytest-pyvista more robust.  If we can offload parts of that pipeline to pytest-mpl, I think that would be great.  It gets slightly closer to my ideal state above.  pytest-pyvista, in my opinion, has a more flexible interface.  It uses a fixture, so it allows you to do more custom things like for example doing multiple image comparisons in one test, turning off and then back on image capturing inside a test, etc....

After glancing at your PR in pytest-mpl, I get the sense that it adds the ability to do different kinds of comparison.  But it doesn't much touch the meta-level problem I highlighted above?  I need to learn more though so please educate me.
I think there is a strong opportunity to replace the homegrown image comparison in pytest-pyvista with a better supported comparison tool.  This will not be a tiny effort in PyVista as the are a lot of tests in pyvista that generate images with a lot of variance based on architecture, etc.

Can you point to the discussion on making pytest-mpl hook better into other image generation tools?

@MatthewFlamm Seems like you found it and chipped into the conversation on https://github.com/matplotlib/pytest-mpl/issues/201 👍

@MatthewFlamm I'm also going to make time to understand better pytest-pyvista, but can you just confirm the technique that it's using for performing the image comparison / differences?
Also, would you guys be open to extending it's support to optionally use perceptual image hashing? I'd happily contribute that functionality if you wanted it?

I am 100% in favor of opening it up for more kinds of image hashing if it doesn't make things too complicated.  I slightly worry that we will have to think about maintaining those in pytest-pyvista even though we don't use it for pyvista.  So we should avoid implementing too many custom things.  If we could leverage widely used image comparison tools (either directly from pytest-mpl or some other package), this would have lower downsides.
One thing that we'd need to think about is that the success criteria in pytest-pyvista is really geared heavily towards the home-grown tool.  So it might require a bit of an overhaul of how this is specified, for example if other image comparison tools have different kinds of criteria or multiple criteria.  But making it more usable for more packages is the reason we split it out of pyvista in the first place.  So, I would support this sort of re-work.
To your question about what technique it uses:
https://github.com/pyvista/pytest-pyvista/blob/597da3865bb9f548fb66242ef37ed72cfa4a4af7/pytest_pyvista/pytest_pyvista.py#L208
which is from
https://github.com/pyvista/pyvista/blob/c7e301c35558e18afda76be9668f9b0d71522ae9/pyvista/plotting/utilities/regression.py#L142
True to form, we use vtk itself to do the comparison.

@MatthewFlamm Yes, it's interesting that pytest-pyvista uses a fixture as opposed to the decorator approach adopted by pytest-mpl. In your experience, do you consider such pytest fixtures more flexible and powerful than decorators? If so, how? (Just curious and keen to understand better)
Also, take a look at https://github.com/matplotlib/pytest-mpl/issues/146 where I argued the case for pytest-mpl to adopt perceptual image hash.
With regards to metadata, do you mean that on pytest-pyvista you have different base images cached for each test depending on the architecture et al when performing the image comparison between the base image and the test output image?
If so, I believe that perceptual image hash solves this problem. But maybe I'm misunderstanding you, sorry.

It is simple to apply the fixture to all the tests in a module or test suite or test class, etc.  I'm not sure that it is so easy with a decorator this way. One interesting thing we can do with a fixture is that it can be interacted with inside the test itself in a flexible way.  For example, we do something like this in our tests:
def test_something(verify_image_cache):
    # Allows the code to run, but don't use the image compare check for a vtk version
    verify_image_cache.skip = pv.vtk_version_info > (9, 1)

This is a really compelling type of usage.  You might be able to do the same in a decorator for this exact case, but imagine that you have two parts to this test and only the first part depends on the needing the vtk version.  Or what if you want to use a higher image regression threshold for the first image in a test, but a second image regression threshold for the second image in the same test.  All of these things are straightforward to do with the fixture approach.

On the question on architecture, we do not save multiple images for different architectures.  I think this is due to the overhead for this, but the current structure of pytest-pyvista would allow for this (see below).  We have selective tests where we entirely skip the image check on a different architecture.  In other cases we specify a different success criteria to account for differences in architecture or vtk version.
This is another reason that the fixture approach is very nice.  You can create a wrapper fixture that would override the baseline image path depending on the architecture and set autouse=True and it will automatically apply to all your tests.  This will be cumbersome with decorators.  If this is more widely used, we should build in helpers into the internal pytest-pyvista fixture that enables this.

@MatthewFlamm Yes, it's interesting that pytest-pyvista uses a fixture as opposed to the decorator approach adopted by pytest-mpl. In your experience, do you consider such pytest fixtures more flexible and powerful than decorators? If so, how? (Just curious and keen to understand better)
Also, take a look at https://github.com/matplotlib/pytest-mpl/issues/146 where I argued the case for pytest-mpl to adopt perceptual image hash.
With regards to metadata, do you mean that on pytest-pyvista you have different base images cached for each test depending on the architecture et al when performing the image comparison between the base image and the test output image?
If so, I believe that perceptual image hash solves this problem. But maybe I'm misunderstanding you, sorry.

Awesome, thanks @MatthewFlamm for taking the time to clarify and explain, much appreciated 🍻


feat(rviz): remove old pull over marker

PR Type

Improvement

Related Links

Description

Related to https://github.com/autowarefoundation/autoware.universe/pull/1843, remove old pull_over marker and use the one which was add in https://github.com/tier4/autoware_launch/pull/462.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[ ] Code follows coding guidelines
[ ] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code follows coding guidelines
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets
[ ] Write release notes

CI Checks

Build and test for PR: Required to pass before the merge.
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

udpated awf's one in https://github.com/autowarefoundation/autoware_launch/pull/85


cmd/cgo: tsan hooks broke linux-amd64-sid builder

@josharian notes that https://go-review.googlesource.com/17421 broke the linux-amd64-sid builder:
e.g.
http://build.golang.org/log/cd17e7f7d6e331b31d626105c6abbab6753eccf8
##### ../misc/cgo/testsanitizers
skipping msan tests: -fsanitize=memory not supported
FAIL: tsan
FAIL: tsan2
2016/02/28 05:10:58 Failed: exit status 1
2016/02/28 05:10:58 FAILED

This is also broken on x86 Fedora (22 and 23) at the moment. The latest git tip (with the report stderr commit) reports:
##### ../misc/cgo/testsanitizers
skipping msan tests: clang version 3.7 (older than 3.8) incompatible with linux version 4.3 (4.1 or newer)
# command-line-arguments
/usr/bin/ld: cannot find /usr/bin/../lib/clang/3.7.0/lib/linux/libclang_rt.tsan-x86_64.a: No such file or directory
clang: error: linker command failed with exit code 1 (use -v to see invocation)
FAIL: tsan
# command-line-arguments
/usr/bin/ld: cannot find /usr/bin/../lib/clang/3.7.0/lib/linux/libclang_rt.tsan-x86_64.a: No such file or directory
clang: error: linker command failed with exit code 1 (use -v to see invocation)
FAIL: tsan2
2016/02/29 10:55:40 Failed: exit status 1

As far as I can tell, Fedora doesn't build or package libclang_rt.tsan-x86_64.a. It does package gcc versions (as libtsan/libtsan-static), which I didn't have installed until I went looking for them; installing them made no difference in the error here.

This is working now.


Flux Sensu package

Closes #1217

[x] Tests pass (no build errors)
[x] Rebased/mergeable

@sranka Feel free to take a look at this PR.


[SPARK-12012] [SQL] Show more comprehensive PhysicalRDD metadata when visualizing SQL query plan

This PR adds a private[sql] method metadata to SparkPlan, which can be used to describe detail information about a physical plan during visualization. Specifically, this PR uses this method to provide details of PhysicalRDDs translated from a data source relation. As shown in the following screenshot:

cc @andrewor14 @yhuai

Test build #46765 has started for PR 10004 at commit b6a32c7.

Test build #46765 has finished for PR 10004 at commit b6a32c7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46765/
Test FAILed.

Merged build finished. Test FAILed.

I wouldn't have the top level name be "PhysicalRDD" - that term just makes no sense to users.
I'd consider just putting "Orc" there. If it is a Hive table, just saying "Scan: table name" might work too".
BTW - if the path is super long, is the box going to be expanded to super wide as well?

@rxin Updated. Now it shows ParquetRelation and OrcRelation etc. instead of PhysicalRDD. Hive metastore table name is also attached. For the long input paths scenario, yes it makes the box super wide. So in the last commit, I truncate the text if it's longer than 100 characters. This is somewhat brutal, but I'm not sure about the best practice here. Maybe doing the truncation in JS side is a better idea?

Test build #46825 has started for PR 10004 at commit 8cbf0ff.

Test build #46825 has finished for PR 10004 at commit 8cbf0ff.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46825/
Test FAILed.

Test build #46833 has started for PR 10004 at commit 6925eb3.

Test build #46833 has finished for PR 10004 at commit 6925eb3.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46833/
Test FAILed.

retest this please

Test build #46835 has started for PR 10004 at commit 6925eb3.

Test build #46835 has finished for PR 10004 at commit 6925eb3.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46835/
Test FAILed.

Test build #46841 has started for PR 10004 at commit 5d12dd7.

Test build #46841 has finished for PR 10004 at commit 5d12dd7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46841/
Test PASSed.

Can we not show PushedFilters if there are no pushed filters?

Comments addressed.

Is it possible to only show the short text in the normal box, and then when hover, show the full path? I'm very concerned about long paths.
cc @zsxwing

Test build #46959 has started for PR 10004 at commit 6891876.

Test build #46959 has finished for PR 10004 at commit 6891876.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46959/
Test FAILed.

Merged build finished. Test FAILed.

@rxin One problem I found is that, the tooltip box is of fixed width. This means that the full path can never be fully observed if it's too long. But I agree that we should keep the normal box relatively smaller. I'll just remove the metadata entries in the normal box.

Test build #47050 has started for PR 10004 at commit 863df7c.

Test build #47050 has finished for PR 10004 at commit 863df7c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Can you add a screenshot if the path is really long?

@nongli Uploaded new screenshot and rebased to master.

Test build #47422 has started for PR 10004 at commit 02448a6.

Test build #47422 has finished for PR 10004 at commit 02448a6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47422/
Test PASSed.

Merged build finished. Test PASSed.

I know that the current visual effect of super long paths isn't perfect, but at least it doesn't introduce super wide plan nodes. And this is also how our current UI handles super long text.

I'm going to merge this into master/1.6.

hm i had trouble cherrypicking it into 1.6. Can you do it yourself?

Since there's a conflict and 1.6 is in RC phase, I opened #10250 to backport this one to branch-1.6, so that it's tested on Jenkins.


kube-advisor appears to be a dead open source project

kube-advisor which is linked to in this article appears to be an abandoned Azure open source project. This page is therefore irrelevant and should not recommend outdated/abandoned tools.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd6a725f-02ee-4337-609d-bdb4adff3359
Version Independent ID: 8b2116c8-5ca3-32ee-e187-87e665c999a0
Content: Operator best practices - Basic scheduler features in Azure Kubernetes Services (AKS) - Azure Kubernetes Service
Content Source: articles/aks/operator-best-practices-scheduler.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@derek-burdick  Thanks for bringing this to our attention. Your feedback  has been shared with the content owner for further review.

Thank you @derek-burdick for the feedback!
We've added an item to the backlog and will prioritize accordingly.
#please-close


Creating subscriptions programatically

How can we create subscriptions programmatically?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a9b18e22-18d0-f82d-cbd0-e9ca300ee655
Version Independent ID: 2737fc2f-cb47-c881-e2ca-1eba4efa26d2
Content: Create subscriptions in Azure API Management
Content Source: articles/api-management/api-management-howto-create-subscriptions.md
Service: api-management
GitHub Login: @dlepow
Microsoft Alias: danlep

Hello @alexdrenea - Thank you for your feedback! You can use the REST API: https://docs.microsoft.com/en-us/rest/api/apimanagement/2021-04-01-preview/subscription/create-or-update
Same operations should also be available in various languages of SDKs made available by AutoRest. For example, Azure for .NET SDK has the same operations: https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.management.apimanagement.subscriptionoperationsextensions?view=azure-dotnet

Thank you for your reply Mike!
This is definitely pointing me in the right direction...
I was not able to find this info / link / documentation from any of the API Management Docs pages. Did I miss it? If I didn't, do you think it might be a good addition to the main APIm Docs tree to include a reference to the REST endpoints / options to do this?
Thanks again!

@alexdrenea Of course! We do have link trail to the above REST info off the main menu tree, under Reference.

Hey @alexdrenea - We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


FSDP miconfigurations

System Info
Latest main version, torch nightly, cuda 12.6

Information

[ ] The official example scripts
[ ] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[ ] My own task or dataset (give details below)

Reproduction
use accelerator.get_state_dict()
Expected behavior
Bugged functionality was added in #2959, so instead of first unwrapping model and then using with FSDP.state_dict_type(model, StateDictType.FULL_STATE_DICT, full_state_dict_config):, which would break FSDP handler, we should do
elif self.distributed_type == DistributedType.FSDP:
    from torch.distributed.fsdp import FullStateDictConfig, StateDictType
    from torch.distributed.fsdp import FullyShardedDataParallel as FSDP

    full_state_dict_config = FullStateDictConfig(offload_to_cpu=True, rank0_only=True)
    with FSDP.state_dict_type(model, StateDictType.FULL_STATE_DICT, full_state_dict_config):

        print(f"using this config: {StateDictType.FULL_STATE_DICT}")

        state_dict = model.state_dict()

I'm not 100% sure that's the fix, but it seems to work

Current behavior:
[rank0]:   File "/home/ubuntu/efs_gpu/libs/accelerate/src/accelerate/accelerator.py", line 3340, in get_state_dict
[rank0]:     with FSDP.state_dict_type(model, StateDictType.FULL_STATE_DICT, full_state_dict_config):
[rank0]:   File "/home/ubuntu/efs_gpu/miniconda3/envs/diffusion_torch2.5/lib/python3.11/contextlib.py", line 144, in __exit__
[rank0]:     next(self.gen)
[rank0]:   File "/home/ubuntu/efs_gpu/miniconda3/envs/diffusion_torch2.5/lib/python3.11/site-packages/torch/distributed/fsdp/fully_sharded_data_parallel.py", line 835, in state_dict_type
[rank0]:     FullyShardedDataParallel.set_state_dict_type(
[rank0]:   File "/home/ubuntu/efs_gpu/miniconda3/envs/diffusion_torch2.5/lib/python3.11/site-packages/torch/distributed/fsdp/fully_sharded_data_parallel.py", line 711, in set_state_dict_type
[rank0]:     state_dict_config_type = _state_dict_type_to_config[state_dict_type]
[rank0]:                              ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
[rank0]: KeyError: None

Because FSDP state_dict_type function expects FSDP module:
    @staticmethod
    @contextlib.contextmanager
    def state_dict_type(
        module: nn.Module,
        state_dict_type: StateDictType,
        state_dict_config: Optional[StateDictConfig] = None,
        optim_state_dict_config: Optional[OptimStateDictConfig] = None,
    ) -> Generator:
        """Set the ``state_dict_type`` of all the descendant FSDP modules of the target module.

        This context manager has the same functions as :meth:`set_state_dict_type`. Read the document of
        :meth:`set_state_dict_type` for the detail.

        Example::

            >>> # xdoctest: +SKIP("undefined variables")
            >>> model = DDP(FSDP(...))
            >>> with FSDP.state_dict_type(
            >>>     model,
            >>>     StateDictType.SHARDED_STATE_DICT,
            >>> ):
            >>>     checkpoint = model.state_dict()

        Args:
            module (torch.nn.Module): Root module.
            state_dict_type (StateDictType): the desired ``state_dict_type`` to set.
            state_dict_config (Optional[StateDictConfig]): the model ``state_dict``
                configuration for the target ``state_dict_type``.
            optim_state_dict_config (Optional[OptimStateDictConfig]): the optimizer
               ``state_dict`` configuration for the target ``state_dict_type``.
        """
        prev_state_dict_settings = FullyShardedDataParallel.set_state_dict_type(
            module,
            state_dict_type,
            state_dict_config,
            optim_state_dict_config,
        )
        yield
        FullyShardedDataParallel.set_state_dict_type(
            module,
            prev_state_dict_settings.state_dict_type,
            prev_state_dict_settings.state_dict_config,
            prev_state_dict_settings.optim_state_dict_config,
        )

Unwrapping before state_dict = model.state_dict() causes incomplete checkpoint
Printing out state_dict of state_dict = fsdp_model.state_dict() shows no fsdp in keys, but original module names.
So I guess it's unrequired, I'm using FULL_STATE_DICT type

@evkogs yes I can see why that'd be an issue. Would you like to put in the fix/refactor? (sorry it took a bit to find your issue)

Yeah I think I will, I need to answer 2 questions before that:

Using torch 2.4 and 2.5, recently introduced default behavior leads to error. Why did @alex-jw-brooks implement it this way? Did he test it? Maybe older pytorch version required it?
I didn't run tests thoroughly, and used it only with FULL_STATE_DICT. Maybe with other state dict types we won't end up with a correctly unwrapped original module, which is done automatically now.

Yeah it's tricky.
But with torch 2.5 I tried to unwrap inside a handler before model.state_dict() and ended up with incomplete checkpoint. However I face various issues with corrupted checkpoints (mostly of untrained modules) when using accelerate with FSDP, and so far not a single corrupted state_dict of target model.

I am having the same problem with accelerate==0.34.2 and torch==2.4.1; this following function for me at the moment
def save_with_accelerate(
    accelerator: Accelerator,
    model: torch.nn.Module,
    tokenizer: PreTrainedTokenizer,
    output_dir: str,
    use_lora: bool = False,
    ) -> None:
    if accelerator.is_main_process and (not os.path.isdir(output_dir)):
        os.mkdir(output_dir)

    if use_lora:
        # When using lora, the unwrapped model is a PeftModel, which doesn't support the is_main_process
        # and has its own save_pretrained function for only saving lora modules.
        # We have to manually specify the is_main_process outside the save_pretrained function.
        if accelerator.is_main_process:
            model.base_model = model.base_model.merge_and_unload()
            torch.save(model.state_dict(), os.path.join(output_dir, 'pytorch_model.bin'))
    else:
        # don't use safetensors for saving for now
        if isinstance(model, PreTrainedModel):  # TODO: this needs to be tested
            model.save_pretrained(
                output_dir,
                is_main_process=accelerator.is_main_process,
                save_function=accelerator.save,
            )
        else:
            torch.save(model.state_dict(), os.path.join(output_dir, 'pytorch_model.bin'))

    if accelerator.is_main_process:
        tokenizer.save_pretrained(output_dir)


Initial AeroMap changes for ElastoDyn and BeamDyn

Feature or improvement description
This PR updates ElastoDyn and BeamDyn with changes needed for AeroMap generation (which will be added in a later pull request, after AeroDyn and InflowWind are also modified). In AeroMaps, linearization is done on only one blade, with a subset of states. Thus, the linearization code in these modules must change.
The flag that activates the new code is set to false, so the code should behave as it did before.
I also updated some comments in FVW and modified some error handling in the ED and BD nodal outputs (it will now still output some of the requested outputs if the number requested exceeds size limits)
Related issue, if one exists
None
Impacted areas of the software
ElastoDyn and BeamDyn, particularly with linearization.
Additional supporting information

Test results, if applicable
This should not change test results.

Thank you for sending us these changes.

These are the easy ones. :) I'll try to get the AeroDyn and other modules to you "soon" too.


added dependabot - Fix Issue: #434

Fix Issue: #434

Dependabot Basic setup for four package managers

Maintain dependencies for GitHub Actions
Maintain dependencies for NPM
Maintain dependencies for Yarn
Maintain dependencies for the composer

Time Frequency for checking the updates

Weekly

@leonardomso


CountryMap can translated by message.po

@cdmikechen commented on Dec 5, 2019, 2:59 AM UTC:
I found that in CountryMap.js country name can be replace by ID_2, but it can not translated by message.po. If someone changes BABEL_DEFAULT_LOCALE in apache-superset (like zh) , he can not see province name by Chinese. Can we use @superset-ui/translation to translate name in *.geojson?
import { t } from '@superset-ui/translation';

  const selectAndDisplayNameOfRegion = function selectAndDisplayNameOfRegion(feature) {
    let name = '';
    if (feature && feature.properties) {
      if (feature.properties.ID_2) {
        name = feature.properties.NAME_2;
      } else {
        name = feature.properties.NAME_1;
      }
    }
    bigText.text(t(name));
  };

This issue was moved by kristw from apache-superset/superset-ui-plugins#288.

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: https://github.com/apache/superset/issues/13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this issue on the main repo if it is still relevant.


⚠ GET to /dummy has degraded performance

In 0bc5fc1, GET to /dummy (https://dev.factiverse.no/v1/dummy) experienced degraded performance:

HTTP code: 200
Response time: 3655 ms

Resolved: GET to /dummy performance has improved in 938ab25.


Zero Trust tunnel config example uses resources from

Which Cloudflare product does this pertain to?
Zero Trust
Existing documentation URL(s)

https://developers.cloudflare.com/cloudflare-one/connections/connect-apps/deployment-guides/terraform/

Section that requires update
Section "Configure Cloudflare resources", which covers the content of the Cloudflare-config.tf terraform file
What needs to change?
The example is based around a cloudflare_argo_tunnel resource, which no longer exists as of version 4 of the terraform provider.
How should it change?
Update to use the current cloudflare_tunnel and cloudflare_tunnel_config terraform resources would be great - I haven't been able to find a worked example of cloudflare_tunnel_config with terraform anywhere online.
Additional information
No response

addressed in #10442


Instance is being refreshed too many times on initial load

When workin on fit to size improvement noticed that shapes are getting shuffled around(second part of video), and I first thought, that it's due some bug in the implementation, but after a some investigation it's due some multiple updated props which cause rerender of the whole composer.
Weridly enough it doesn't happen on refresh, but only when moving from service inventory view
https://github.com/inmanta/web-console/assets/113331659/b587341d-eac2-4820-8d42-4418942fd74d