Compatibility with x86-32bit

I packaged btrfs-dedupe for nixos and the builds for x86 are failing, while builds for x86_64 are working. the error suggests, that minilzo is not compiling.
My request would be:

Would it be possible to add 32bit support?
If it is already implemented what do i need to do, to make it compile/work?

Thanks, ikervagyok

Here is the error, which i get when compiling btrfs-dedupe:
building path(s) ‘/nix/store/n160qsibkvjlkjgiqmzsbxxxknqm62n0-btrfs-dedupe-1.1.0’
unpacking sources
unpacking source archive /nix/store/i97ykw2p7bzl9lm0dhllmhc29db3d5a7-archive.tar.bz2?ref=72c6a301d20f935827b994db210bf0a1e121273a
source root is btrfs-dedupe-72c6a301d20f935827b994db210bf0a1e121273a-72c6a301d20f935827b994db210bf0a1e121273a
Using cargo deps from /nix/store/z3218s53bxxhv9vrlhvmbmq18l5wkxz6-btrfs-dedupe-1.1.0-fetch
Using indexHash '-ba82b75dd6681d6f'
Using rust registry from /nix/store/mnsaxh5zksckcar3pxz7b6yac980r08c-rustRegistry-2017-02-19-d822c58
warning: custom registry support via the `registry.index` configuration is being removed, this functionality will not work in the future
warning: custom registry support via the `registry.index` configuration is being removed, this functionality will not work in the future
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file btrfs-dedupe-72c6a301d20f935827b994db210bf0a1e121273a-72c6a301d20f935827b994db210bf0a1e121273a/Cargo.lock
warning: file btrfs-dedupe-72c6a301d20f935827b994db210bf0a1e121273a-72c6a301d20f935827b994db210bf0a1e121273a/Cargo.lock may be generated; SOURCE_DATE_EPOCH may be non-deterministic
patching sources
configuring
building
Running cargo build --release
warning: custom registry support via the `registry.index` configuration is being removed, this functionality will not work in the future
   Compiling vec_map v0.6.0 (registry file:///dev/null)
   Compiling log v0.3.6 (registry file:///dev/null)
   Compiling lazy_static v0.2.2 (registry file:///dev/null)
   Compiling rustc-serialize v0.3.22 (registry file:///dev/null)
   Compiling unicode-xid v0.0.3 (registry file:///dev/null)
   Compiling quote v0.3.10 (registry file:///dev/null)
   Compiling unicode-segmentation v1.0.1 (registry file:///dev/null)
   Compiling byte-tools v0.1.2 (registry file:///dev/null)
   Compiling bitflags v0.7.0 (registry file:///dev/null)
   Compiling crc v1.4.0 (registry file:///dev/null)
   Compiling ansi_term v0.9.0 (registry file:///dev/null)
   Compiling unicode-width v0.1.4 (registry file:///dev/null)
   Compiling dtoa v0.2.2 (registry file:///dev/null)
   Compiling itoa v0.1.1 (registry file:///dev/null)
   Compiling libc v0.2.18 (registry file:///dev/null)
   Compiling typenum v1.5.1 (registry file:///dev/null)
   Compiling uuid v0.3.1 (registry file:///dev/null)
   Compiling strsim v0.6.0 (registry file:///dev/null)
   Compiling fake-simd v0.1.2 (registry file:///dev/null)
   Compiling term_size v0.2.1 (registry file:///dev/null)
   Compiling minilzo-sys v0.1.0 (registry file:///dev/null)
   Compiling ioctl v0.3.3 (registry file:///dev/null)
   Compiling minilzo v0.1.0 (registry file:///dev/null)
   Compiling minilzo v0.1.0 (registry file:///dev/null)
error[E0308]: mismatched types
   --> /tmp/nix-build-btrfs-dedupe-1.1.0.drv-0/deps/registry/src/-ba82b75dd6681d6f/minilzo-0.1.0/src/lib.rs:121:13
    |
121 |             inlen as u64,
    |             ^^^^^^^^^^^^ expected u32, found u64

error[E0308]: mismatched types
   --> /tmp/nix-build-btrfs-dedupe-1.1.0.drv-0/deps/registry/src/-ba82b75dd6681d6f/minilzo-0.1.0/src/lib.rs:161:13
    |
161 |             inlen as u64,
    |             ^^^^^^^^^^^^ expected u32, found u64

error: aborting due to 2 previous errors

Build failed, waiting for other jobs to finish...
error: Could not compile `minilzo`.

To learn more, run the command again with --verbose.
builder for ‘/nix/store/09977dmw443ww1xhracjlipj794s11hi-btrfs-dedupe-1.1.0.drv’ failed with exit code 101

Thanks for the report. I'll take a look to get it working on 32-bit

Oh wait, I already fixed that and released a new version. Just upgrade the dependency.

Thanks, so I should ask the btrfs-dedupe developer to update his crate.toml? Sorry, but I am not very familiar with rust packaging.

All it needs would be a rebuild of the included Cargo.lock, which currently is fixed to v0.1.0 of minilzo.
Approaching the upstream dev of btrs-dedupe would be the best idea


IndexError: list index out of range when using VertexAIEmbeddings with SemanticChunker

Checked other resources

[x]  I added a very descriptive title to this issue.
[x]  I searched the LangChain documentation with the integrated search.
[x]  I used the GitHub search to find a similar question and didn't find it.
[x]  I am sure that this is a bug in LangChain rather than my code.
[x]  The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Description
I'm splitting documents using SemanicChunker with VertexAIEmbeddings.
When the number of chunks is high enough (more than ~120), I'm getting IndexError: list index out of range .
Please note that the issue does not occur when using the previous implementation from langchain.embeddings.VertexAIEmbeddings, but it obviously triggers a deprecation warning.
The problem seems to come from the batch-size calculation, in langchain_google_vertexai/embeddings.py, which produces arbitrarily low values for the batch size, despite the total number of texts being higher. More exactly, the first batch is ok, but the second has a lower size despite the remaining number of chunks should produce more batches.
Example Code
import os
import getpass
import itertools
import lorem
from dotenv import load_dotenv
from google.cloud import aiplatform
# from langchain.embeddings import VertexAIEmbeddings  # this one works
from langchain_google_vertexai import VertexAIEmbeddings # this one fails
from langchain_experimental.text_splitter import SemanticChunker

load_dotenv()
# .env file must looks like this:
#
# GOOGLE_APPLICATION_CREDENTIALS=
# PROJECT_ID=
# LOCATION=
#

PROJECT_ID = os.environ.get("PROJECT_ID")
LOCATION = os.environ.get("LOCATION", "europe-west1")

if PROJECT_ID is None:
    PROJECT_ID = getpass.getpass("Project ID")

aiplatform.init(project=PROJECT_ID, location=LOCATION)

embedding_model = VertexAIEmbeddings("text-embedding-004")

text_splitter = SemanticChunker(embedding_model)

NB_SENTENCES = 200 # up to 120 it is ok

document_chunks = text_splitter.split_text(" ".join(itertools.islice(lorem.sentence(word_range=(8, 16)), NB_SENTENCES)))

Error Message and Stack Trace (if applicable)
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
Cell In[1], line 34
     29 text_splitter = SemanticChunker(embedding_model)
     32 NB_SENTENCES = 200 # up to 120 it is ok
---> 34 document_chunks = text_splitter.split_text(" ".join(itertools.islice(lorem.sentence(word_range=(8, 16)), NB_SENTENCES)))

File ~/Projects/ml/ml-research/vertex-rag/.venv/lib/python3.12/site-packages/langchain_experimental/text_splitter.py:215, in SemanticChunker.split_text(self, text)
    213 if len(single_sentences_list) == 1:
    214     return single_sentences_list
--> 215 distances, sentences = self._calculate_sentence_distances(single_sentences_list)
    216 if self.number_of_chunks is not None:
    217     breakpoint_distance_threshold = self._threshold_from_clusters(distances)

File ~/Projects/ml/ml-research/vertex-rag/.venv/lib/python3.12/site-packages/langchain_experimental/text_splitter.py:200, in SemanticChunker._calculate_sentence_distances(self, single_sentences_list)
    196 embeddings = self.embeddings.embed_documents(
    197     [x["combined_sentence"] for x in sentences]
    198 )
    199 for i, sentence in enumerate(sentences):
--> 200     sentence["combined_sentence_embedding"] = embeddings[i]
    202 return calculate_cosine_distances(sentences)

IndexError: list index out of range

System Info
langchain==0.2.6
langchain-community==0.2.6
langchain-core==0.2.11
langchain-experimental==0.0.62
langchain-google-community==1.0.6
langchain-google-vertexai==1.0.6
langchain-text-splitters==0.2.1
Mac M3 Pro (macOS 14.5)
Python 3.12

Can you please re-install langchain-google-vertexai from Github, and try again? I believe there was a bug that was fixed last week.
P.S. Don't forget you need to uninstall the existing version before installing from Github.

Thank you @lkuligin
Indeed, the GitHub version does not have the issue. I am waiting now for its release.
In the meantime, here is a way to make it work, with pip:
pip uninstall langchain-google-vertexai
pip install<EMAIL_ADDRESS>


Add a a Single Source of Truth for Python package dependencies. I vote for setup.py.

This may/will require changing the logic in setup.py to set its values based on the contents of requirements.txt.   I'd be interested in thinking about going the other way also...   why not make 'setup.py' the single source of truth, and omit requirements.txt altogether?

I vote we make setup.py the single source of truth.  Then we can reserve "requirements" files for special purposes... like "test" and "docs".

no objections there, and logical from user perspective

I've actually implemented a setup_requirements.txt... the setup.py is not easily portable due to the nature of how setup.py works with the setup utility.  Thus, I would have to parse the setup.py script, which is doable; however, very heavy and potentially a vulnerability bug-wise with the necessary moving parts.
This is also part of the requirement that the native-building docker files that both build and test for this should be as independent as possible from any tool that i might use to automate the parsing of the setup.py script.  There, we're trying to make it as barebones as possible, yet I would like the test automation to handle testing the passing of dependency names from the source versus what the packages are built for, and that's easier handled natively within the test docker container.
This is addressed in Issue #980

closing as merged


Missing dependency for html report

If I activate in qtaf.json the html report feature with
"htmlReport": {     "enabled": true   } then I cannot find a html report file in the log directory. I don't get an error message for a missing dependency.
After i add the dependency explicit in the qtaf.json, it will generate the log.

Why don't we get the dependency resolved automatically?
Why can't we find a description of how to add the dependency in the manual?

Hello Moritz, a description of the HTML plugin can be found in the documentation:
https://qytera-gmbh.github.io/projects/qtaf/sections/steps/HTML_Report_Plugin/
Would you like to see further improvements here. If so, which ones?
I agree that this behaviour is somewhat unintuitive. An error message indicating the absence of the dependency would be helpful in my opinion. As you suggested, it would probably be even better if the dependency could be added automatically by QTAF when the HTML report is set to "true" in the qtaf.json. We should discuss what behaviour we think makes the most sense and turn this issue into a feature request.

In my situation, I got this auto generated qtaf.json config with an enabled htmlReport. Then my expectation is that my test script will run with the pre-configured feature or I'll get an error, that I use a not implemented (depended) feature.


pythonPackages.nbxmpp: 4.4.0 → 4.5.0

Description of changes
https://dev.gajim.org/gajim/python-nbxmpp/-/blob/4.5.0/ChangeLog?ref_type=tags
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build gajim python310Packages.nbxmpp python311Packages.nbxmpp

Result of nixpkgs-review pr 265166 at 5de3a8ea run on aarch64-darwin 1

2 packages built successfully:

python310Packages.nbxmpp
python311Packages.nbxmpp


Add overload to HttpClientWrapper to accept Client

User can now specify the HttpClient as well as user/pass

Fixes issue #163


Refactor SAI analyzer configuration; add built in analyzers

The current OPTIONS configuration for the index_analyzer does not correctly model the available configuration options. In order to make the configuration more directly match the single tokenizer, and the lists of filters and charFilters, I propose we update the expected JSON schema. Further, we can add some default analyzers to simplify the configuration of generic tokenizers.

Is it tractable to add the STOP and language analyzers?

Is it tractable to add the STOP and language analyzers?

I can easily add those analyzers if we want. I did not because the existing SAI analyzer implementation prevents configuring the stop filter:
https://github.com/datastax/cassandra/blob/5afe63d6b0dc2ac37ab4f1ee8278c2ccff5ccb95/src/java/org/apache/cassandra/index/sai/analyzer/JSONAnalyzerParser.java#L36-L42
Perhaps that justification is wrong though.
Note that the lucene language analyzers appear to be pretty careful with opening files lazily. For example, the SpanishAnalyzer ensures the file of stop words is read once when it is first accessed: https://github.com/apache/lucene/blob/cc342ea7407c729a743123d8f7957aff6c6f9792/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishAnalyzer.java#L55-L75

Okay, no Stop analyzer.
I don't want to try to solve the "deploy a file of stop words" problem, can we expose the language ones just with defaults?

Yes, we can expose the language ones with the default stop words. I'll push up a commit adding those analyzers soon.
Also, we could allow indexes to be created with custom stop word lists--the lists will be supplied in the args section for the filter.

if it's an easy improvement then let's do it.  if it's not easy then let's wait for someone to need it. :)

I was able to easily add the language and stop analyzer. However, we still have a restriction that prevents users from creating SAI with the stop filter because the StopFilterFactory in lucene only accepts stop words from a file. If custom stop words become a requirement, I would recommend adding a new way to construct StopFilterFactory so that we can pass the stop words as an array of strings in the index OPTIONS.

LGTM.


v1.1.20

This repository contains GitHub workflows for managing releases automatically.
Please name this issue what you would like the new release to be called. E.x. "v1.0.0"
The following slash commands are available to use in comments on this issue:

Command
Description
Parameters

/release
Creates a new released based on the current state of the master branch
frontend=<version>backend=<version>gitapi=<version>status=<version>dispatcher=<version>agnosticv=<version>anarchy=<version>poolboy=<version>

/promote
Promotes the created release to the next environment
N/A

/cancel
Cancels the current release (and closes this issue)
N/A

/finish
Completes the current release (and closes this issue)
N/A

/release frontend=v1.1.14 backend=v1.0.14 gitapi=v1.0.11 status=v1.0.0 dispatcher=v1.0.12

/release frontend=v1.1.14 backend=v1.0.14 gitapi=v1.0.11 status=v1.0.0 dispatcher=v1.0.12

/promote

/promote

/promote

/promote

/close

/finish


Adding pending contributors to the contributor's list of NeoAlgo

Adding pending contributors to the contributor's list of NeoAlgo.
Please, comment down if your name is not added in contributors list of NeoAlgo i.e. https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTORS.md

plz assign me this issue.

@iamrajiv

I am not added

I am not added

@yashsahay2014 can you mention the PR which was made by you and got merged.

@Kritika37 I have added you please take a look https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTORS.md

@iamrajiv I have made PR which is yet to be merged by you. Issue #641

@Kritika37 I have added you please take a look https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTORS.md

Thank you

Add me too plz
https://github.com/TesseractCoding/NeoAlgo/pull/645

@raksha009 I have added you please take a look https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTORS.md

@raksha009 I have added you please take a look https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTORS.md

Thanks

@iamrajiv my PR is yet to be merged #628 #620

@cherryWood55 I have added you please take a look https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTORS.md

add me too please i have two pr merged @iamrajiv

@NEEHITGOYAL I have added you please take a look https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTORS.md

@iamrajiv please add me, my 2 PR are merged.

@rutujadhanawade I have added you please take a look https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTORS.md

Please add me for coding as well
My PR got merged #566

@Kritika37 Your are already added please take a look https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTORS.md

@Kritika37 Your are already added please take a look https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTORS.md

Yes I know, I'm added but only for documentation thing. Add me for coding as well

@Kritika37 I have updated the list please take a look https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTORS.md

@Kritika37 I have updated the list please take a look https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTORS.md

Thank you

Hi @iamrajiv my PR has not still merged
Please check
https://github.com/TesseractCoding/NeoAlgo/pull/459

I have not been added @iamrajiv

@smv1999 I have added you please take a look https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTORS.md

@smv1999 I have added you please take a look https://github.com/TesseractCoding/NeoAlgo/blob/master/CONTRIBUTORS.md

Thank you !


Design Doc: Outbound Webhook Notifications

Goal
Send webhook notifications to external systems facilitating integration with third party services like Slack and HipChat. Types of events that will trigger webhook notifications include:

Releases
Scale events

Allow webhook consumers to be added/removed through the API or the CLI using webhooks, webhooks:add, and webhooks:remove commands.
The goal of this feature is not to integrate directly with a bunch of 3rd party services like Slack and HipChat. That would require Deis to support a different notification format and set of configurations for each service. Instead, a single notification format will sent to consumers with information about the Deis event. The consumers can take these events and do whatever they want with them, such as post messages to Slack or HipChat. If Deis would like to ship with a default consumer that integrates with popular 3rd party services, it can do so at a future time. At first it would be up to users to create their own consumers.
Code Changes

Create a new /apps/<id>/webhooks/ endpoint which supports listing, adding, and removing webhooks
Update the controller to send events to all webhooks registered for a product when releases and scale events occur
Ensure the controller retries delivery of webhooks a few times with an exponential back-off
Add webhooks, webhooks:list, webhooks:add, and webhooks:remove commands to the workflow CLI
Sign events so that clients cat verify they originated from the Deis platform. Travis CI has a neat way of doing this using (https://docs.travis-ci.com/user/notifications#Verifying-Webhook-requests)

Tests
It should be possible to create a test consumer application in https://github.com/deis/workflow-e2e and verify that it is receiving events.

My team currently makes use of HipChat and PagerDuty in our continuous deployment setup, and would love to keep using them as we move to Deis. I see that outbound webhooks are listed on the roadmap, but asking on Slack it sounds like it's not on the short-term roadmap. Instead of putting effort towards creating some hack that only works for us, I'd love to try and properly implement the feature in Deis.
I put some of my initial thoughts above. If anyone has any feedback, please let me know. I haven't actually discussed this with anyone, so I don't know how far off the mark I am from what was in mind when the item was added to the roadmap.

This is an excellent proposal, @jschneiderhan. The idea of a webhook design rather than an events API which users will have to poll is a better overall design and better reflects current use cases.
I think the only change I'd make would be that the CLI commands be deis webhooks, deis webhooks:list, deis webhooks:add and deis webhooks:remove rather than deis workflow. workflow might confuse others since that is the official name of the product (Deis Workflow).
Going with travis' implementation of signing the webhooks also sounds like a great idea. We'd also need to add an endpoint to the API server that displays the public key used to sign webhooks as well as generate a new secret key, but the implementation doesn't sound too hard or over-complicated.
Looks good to me! 👍

As far as testing goes, it could be possible to write an end-to-end test for this in https://github.com/deis/workflow-e2e. Potentially it could be an application that is deployed onto the cluster, then a webhook is sent to appname.k8s.local, then we check the logs and verify it saw the webhook after creating a new release for the app. Essentially the app would be listening to its own events.
That's just an idea, but you get the picture :)

@bacongobbler oops - using webhooks was my intention - that was a slip up. I'll fix that.
Do you think the webhooks should be configured for each app, or should there be a single set for the entire platform?
Take my current use case. We have two product teams, and each has it's own HipChat room. With app-level webhooks, I would have a simple webhook consumer running for each team configured to send messages to their room. With platform-level webhooks, I would have a single more complicated consumer that would figure out which room to send to based on the app specified in message details.
I think I like the app-level webhooks. It allows me to keep my consumer simple, but I may have to run multiple consumer instances, and configure a webhook for every app. I notice that other projects which send webhooks, like Travis, are configured at what would be comparable to the app-level. I could be sold the other way, though.

Do you think the webhooks should be configured for each app, or should there be a single set for the entire platform?

I think per-app is a good design. As you mentioned, each application may only be relevant to a certain slack channel so the webhooks for one app may differ to another.

This was implemented by @bacongobbler in the Workflow v2.10.0 release.

Oh wow, excellent!

https://github.com/deis/controller/issues/1153 for anyone else looking for the implementation.


Support a build script for Tizen target

There does not exist appropriate build script for Tizen software platform.
This commit is to fix #847.
Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>

\CC: @myungjoo , @jijoongmoon , @wonsubkim

After this PR: Build is Okay.!!!!

tizen4.0# git clone
tizen4.0# git checkout v0.7.0
tizen4.0# mkdir build && cd build
tizen4.0# ../scripts/build_tizen.sh
     . . . Upper Omission . . .
[100%] Built target text_file_reader_utils_test
Linking CXX executable binaries/typeid_test
[100%] Built target typeid_test
Linking CXX executable binaries/utility_ops_test
[100%] Built target utility_ops_test
Linking CXX executable binaries/workspace_test
[100%] Built target workspace_test

real	41m4.901s
user	148m25.972s
sys	0m43.360s
bash-3.2#

Hardware specification: CPU, Memory, HDD, Graphic

invain@u1604:~$ sudo dmidecode --type=processor | grep CPU
	Version: Intel(R) Core(TM) i5-3570 CPU @ 3.40GHz

invain@u1604:~$ free
              total        used        free      shared  buff/cache   available
Mem:       16306332     6165812      510236      113348     9630284     9617236
Swap:       4194300        9436     4184864

invain@u1604:~$ sudo smartctl -i /dev/sda | grep "Device Model"
Device Model:     Samsung SSD 850 EVO 500GB

invain@u1604:~$ lspci | grep VGA
00:02.0 VGA compatible controller: Intel Corporation Xeon E3-1200 v2/3rd Gen Core processor Graphics Controller (rev 09)

Parallel build screenshot using QEMU (V-Type1)

continuous-integration/travis-ci/pr  — The Travis CI build failed

@Yangqing , I have completed a self-verification after applying your review. From my experiment, the build test is okay as I summarized above. Could you give me a comment  or person in charge on "The Travis Ci build failed"?

This looks great - since it is standalone file let's go ahead and merge it. The travis build failure is a separate issue.


Angular 4

Hi,
Is it possible to have an Angular 4 based build?
Thanks in advance,
Adrian

@amihailes ha ha, yes, it only came out last night, but I'm working on it.

Good news!

It's perhaps the opportunity to rename the project to something like angular-bs3-modal. With Angular 4, Google is suggesting to remove the Angular version from the libraries.

oh, ng2-bootstrap was renamed to ngx-bootstrap.

I just tried upgrading my project to angular 4, before doing so I made sure to have the latest ng2-b3-modal component.
npm is throwing peer dependency warnings that<EMAIL_ADDRESS>requires angular ^2.0.0 versions.
Can I safely ignore these?

@grichards23 - I believe you can. I'm working on trying to get an Angular v4 version out, just haven't had a whole lot of time lately.

@grichards23 I have no trouble besides the peer dependencies not meeting the requirements. It works perfectly fine!

Hey @dougludlow Can you please upgrade the repo to support angular4 and bs4? I am using ng2-bs3-modal in my project which uses angular4. I am planning on upgrading my project to BS4. So it will be better if ng2-bs3-modal supports all the dependencies. Thank you in advance.

Hey @dougludlow , I am curious as to how you're using ng2-bs3-modal with angular4 given that the current version has a peerDependency on<EMAIL_ADDRESS>...this is in fact what is blocking me right now.

Peer dependency error messages are warnings, not errors. You can safely ignore them.

Got it, thanks @wartab, I guess I'm just one of those perfectionists who hate warnings ;) I like clean output :)

It's clean if you close your eyes :)

But I agree, the peer-dependencies should be ^2.0.0 || ^4.0.0

@dougludlow any news? Last we heard of this was April :)

It works but the warnings make it impossible to use npm shrinkwrap.
Peer dependencies should be ^2.0.0 || ^4.0.0 and that would fix the issue.

any solution for this?

+1 Please fix it as suggested by equipe404
have problems as follows:
npm ERR! peer invalid<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer invalid<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer invalid<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer invalid<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer invalid<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>

+1 Please fix it as suggested by equipe404
have problems as follows:
npm ERR! peer invalid<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer invalid<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer invalid<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer invalid<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer invalid<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>

This seems already fixed on Master... any chance it can be released?

@Stefan-Aurea I've got it released finally as v0.11.5. Enjoy.

Awesome! Thank you very much @dougludlow


Export types from mockserver client

In some projects the eslint rule import/no-unresolved is triggered when using the types from mock server client. We need to expose it in order to not face this issue.
some people use the rule below because of this
'import/no-unresolved': ['error', { ignore: ['mockserver-client/mockServer'] }]
This PR fix it

Thanks, I'll merge this and I expect to do a new release in the next couple of weeks which will include this change.


All the model parameter files you provide do not match the final version of the network structure  DPN3d26-FasterRCNN.

All the model parameter files you provide do not match the final version of the network structure  DPN3d26-FasterRCNN.

DPN models are in https://github.com/wentaozhu/DeepLung/tree/master/detector/dpnmodel
Res18 models are in https://github.com/wentaozhu/DeepLung/tree/master/detector/resmodel


[phpstan-rules] can't find anonymous class

After upgrading to symplify/phpstan-rules 10.0.8, I get the following error when using an anonymous class:
"Class  was not found while trying to analyse it - discovering symbols is probably not configured properly"
The error disappears if I remove vendor/symplify/phpstan-rules/config/naming-rules.neon from my phpstan.neon, is there something new to be configured to use anonymous classes?
Code to reproduce would be something like this:
<?php declare(strict_types = 1);

class Test
{
	public function testSomething(): void
	{
		$class = new class() {};
	}
}

Also I can't ignore the error, if I add it to the ignore-list in phpstan.neon, I get the following message:
"Error message "Class  was not found while trying to analyse it - discovering symbols is probably not configured properly." cannot be ignored, use excludePaths instead."

Hi, thanks for reporting.
Which exact rule is causing it?

Is there a way to include or exlude a single rule from a predefined package using the phpstan-config?
I checked the rules by removing them from vendor/.../naming-rules.neon one by one, the rule that produces the error is "Symplify\PHPStanRules\Rules\PrefixAbstractClassRule".

I checked the rules by removing them from

That's the fastest way I know.
PHPStan would deserve rule ignoring feature 👍
Thanks

Fixed in https://github.com/symplify/symplify/pull/3870/files :+1:


Bug: Embedded link in logo on events page throws 404

Hi. The embedded link within the logo on the navbar on the events page is incorrect. It throws a 404 not found. I would like to fix this issue. Could you assign it to me under GsSOC'23?

Hello , Could I work on this issue, please let me know under GSSoc'23

Yes sure, go ahead @rayyan016


Json compression

Added compressed json encoders to reduce size of output json. These make use of Cell-, OntologyAnnotation- and Stringtables to deduplicate information.
In DotNet it's not only much smaller, but also much faster. Unfortunately, this is not the case for JS. Therefore the performance test is pending in Fable.

#312


Output SVG alongside DXF in debug mode

For each DXF file that src/cli.js outputs, src/cli.js --debug additionally outputs a corresponding JSON file. With this change, the --debug form also outputs an SVG file.
This is useful for getting real-time feedback while authoring a config. I said in Discord:

I found a decent workflow for editing with live visual feedback:

Tweak io.js to output SVG alongside DXF (https://github.com/brow/ergogen/commit/3e064605fe6b73acbda0900f5547b7c40ae2787b)
fswatch -0 jklp.yaml | xargs -0 -n1 node src/cli.js -c jklp.yaml -o jklp --debug
Use an SVG viewer that automatically refreshes when the file changes—e.g., Gapplin on macOS

Absolutely valid use case. Accepted, thanks!


Style tweaks to answer buttons & labels

align label text with its radio button - .radioCustomButton, .radioCustomLabel
move answer option to the upper-right (v current upper-left)

Addressed in https://github.com/smcnally/office_quiz/pull/6


PI-831 added pagination support for GET requests

@jwineman

Also I know this is my fault but lets move
Client($this->getEndpoint());

into the constructor and add a setter so we can test this class too.


Enable vault name mapping and error suppression

Description
Enable vault name mapping and error suppression. This PR supersedes #1051 including the original changes from @yash-nisar
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #887
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation

Thanks for the review @philliphoff. I will review your comments and make any amendments


Add Al Al-Bayt University

@mqanneh I am sorry, the domain st.aabu.edu.jo is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Page 6510 in Function SetSourceSpecOnBeforeSetSourceSpec(TrackingSpecification,ReservEntry);

Hi,
Please add publisher in Page 6510 in Function SetSourceSpec to add filters for Tracking and reservationentry.
OnBeforeSetSourceSpec(TrackingSpecification,ReservEntry);
with VAR.

thanks!
regards,
srinivas

ReservEntry is empty at this point and filters will be reset later. So what this event is supposed to do?

ReservEntry is empty Custom filters will be applied, But the ReservEntry not RESET later.

we need to filter reservEntry, if we have event in AddReservEntriesToTempRecSet is also good for us.
Like below

This should have been implemented as part of #2260


Make the building of our build image smarter per issue 2329

Checks to see if the image is in our docker cache too, instead of just
looking for .scBuildImage
Closes: #2329
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

How do I see the error from the test? When I click on the link it says:
Unable to load build details from gs://kubernetes-jenkins/pr-logs/pull/kubernetes-incubator_service-catalog/2330/pull-service-catalog-xbuild/270
/test pull-service-catalog-xbuild

works for me.
/lgtm

/approve


Added Weibenfalk to the list

Would love to have my Youtube channel here as well. I focus on Front end. Much React stuff and code along tutorials with a fun touch. =)

Moved now … What is the criteria for the order?

4 jan. 2020 kl. 10:02 skrev Alexander Alemayhu<EMAIL_ADDRESS>@scanf requested changes on this pull request.
Can you move to the bottom of the list?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/ErikCH/DevYouTubeList/pull/71?email_source=notifications&email_token=ACVRL3VLO2MJONBGHFZMJSTQ4BGCLA5CNFSM4KCS6BU2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQVLVOI#pullrequestreview-338344633, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVRL3SVRAMP7CHOLB4FHQ3Q4BGCLANCNFSM4KCS6BUQ.

Thanks!


How to remove timeout from command line?

Whenever I'm working in the portainer web ui's command line for any container I feel like I'm in a race against time, because the very short timeout when inside a command line (terminal session) always kicks me out (feels like) almost as soon as I'm idle for more than a few seconds.
I'm constantly having to re-click the command line icon to re-enter it. I'd like it to just stay open permanently until either I manually close it, or the tab/browser. With the extremely short timeout it makes it so I can't really even read manual pages for commands, etc. while the session is open because as soon as I come back to it it's closed again. Very very frustrating.
How can I do this?

Here's a vid of it happening in real-time. It shows that you don't even have time (for example) to switch browser tabs or windows to look up anything or do something else before it closes on you after only about a minute and 45 seconds.
https://user-images.githubusercontent.com/39491297/166071389-2f4b72d5-5593-4917-be7f-ba6117acba0b.mp4

portainer/support There still seems to be no way to remove/modify this timeout


Allow single-line code spans

🚧 Builds on #3150
Fixes dotnet/aspnetcore#27102

ping ^

The issue this fixes is already fixed, so I don't see a reason not to close this.


Manually include sass gem in Gemfile

Middleman has updated to sassc but sprockets hasnt, so need to include
sass gem manually in the meantime
see this thread - https://github.com/middleman/middleman-sprockets/issues/132

Needed to fix a dependabot caused problem


Set Up Integration Suite Trial

Tutorial URL: https://developers.sap.com/tutorials/cp-starter-isuite-onboard-subscribe.html
Please specify the step you are referring to
Step 5, after activating the Integration Suite I'm still Forbidden, even though I configured the security as required and even logged out and back in.

Hello @danhenry00,
The forbidden error usually comes if there are no specific roles have been assigned.
In your case, you are mentioning even though you assigned a role but you are unable to launch the integration suite application.
Could you please follow the below steps.

Clear your browser cache and try launching it.
Try in incognito mode
You have already tried logout and login.
if the issue still persists, just try deleting your existing subaccount and re create the new one and follow the tutorial steps again.

Regards,
Vikram Kulkarni

Hi,
I really appreciate your response.  I tried logging in again before going
to bed and it did work. Looking forward to checking it out more today.
Thanks
Dan
On Sun, Nov 29, 2020 at 4:40 AM Vikram Kulkarni<EMAIL_ADDRESS>wrote:

Hello @danhenry00 https://github.com/danhenry00,
The forbidden error usually comes if there are no specific roles have been
assigned.
In your case, you are mentioning even though you assigned a role but you
are unable to launch the integration suite application.
Could you please follow the below steps.

Clear your browser cache and try launching it.
Try in incognito mode
You have already tried logout and login.
if the issue still persists, just try deleting your existing
subaccount and re create the new one and follow the tutorial steps again.

Regards,
Vikram Kulkarni
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SAPDocuments/Tutorials/issues/6248#issuecomment-735367301,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQTZFNO6ZHVQ34LF3X665H3SSIJI5ANCNFSM4UF44G6Q
.

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
If you still have questions, feel free to reopen the issue.


Jardilio route redirect fix

See #3332

I accidentally changed the authorship of the first commit. I will change back before merging...

Where are the docs ? :stuck_out_tongue:

I would also mention resolve amoong the things that don't get processed in the BC notice.

So at the moment null works differently so this pr does not change that. We should consider making null work like undefined in a follow up pr

I'll add checks commit message and docs for resolve

@gkalpak and @Narretz PTAL!

LGTM

Don't forget to change back the authorship though!

The commit message mentions that null cancels the redirection. Remove it when merging to avoid confusion.
LGTM

Oops. Well I guess I have to fix the null path now then, eh?


No loca feature for Macedonian and Serbian Cyrilic in Roboto Italic

Current handling of Macedonian and Serbian Cyrilic by Roboto Italic:

The text above was created by https://github.com/googlei18n/fontdiff using

Macedonian 0413 г 0414 д 041F п 0422 т 0403 ѓ

Serbian 0413 г 0414 д 041F п 0422 т 0403 ѓ

as input.
I copied the text below which was created by https://github.com/elTooDR in https://github.com/googlei18n/noto-fonts/issues/794 (it pertains to Macedonian but it also applies to Serbian).
Also please note that if you sequence Macedonian (or Serbian) Unicode 0422 then 041F then 0413 they all should be "visually compatible" (but listed from the longest to the shortest). [I'm not a designer sorry for a convoluted description.] For example,
Noto Sans Italic

Noto Serif Italic

<beginning of copied text>"
Macedonian needs a local/vernacular version for a number of lower case characters when italicized. These are mentioned below.
Unicode 0413 - Г г г - IPA /g/ - English equivalent g
Regular   |   Incorrect Italics    |   Correct Italics

The correct lower case g does not have a curve on the vertical stroke and it also has macron over it. The correct character would be similar to iota in Greek “ι” as opposed to a mirrored “s, s”.
Unicode 0403 - Ѓ ѓ ѓ - IPA /ɟ/ - English equivalent gy
Regular   |   Incorrect Italics    |   Correct Italics

As above, except with an acute diacritic above the macron.
Unicode 0414 - Д д д - IPA /d/ - English equivalent d
Regular   |   Incorrect Italics    |   Correct Italics

The lower case d in Macedonian should have the tail pointing down. It is similar to italicized g in English.
Unicode 041F - П п п - IPA /p/ - English equivalent p
Regular   |   Incorrect Italics    |   Correct Italics

The lower case p in Macedonian should look like a u with a macron over it. Currently, it seems to be very similar to n in English.
Unicode 0422 - Т т т - IPA /t/ - English equivalent t

The lower case t in Macedonian should look like the character “sh” Unicode: 0428 ш with a macron over it. Currently, it seems to be very similar to m in English.
I hope everything is clear.
The Macedonian Ministry of Information Society (MIO) released a number of fonts (Skola) to the general public which may help - http://www.mio.gov.mk/?q=node/2182. Click on Преземи ги фонтовите to download the fonts.
"<end of copied text>

I haven't checked Roboto Slab nor Roboto Condensed but I suspect they suffer from the same issue (if they have italics).

@marekjez86 This font in italics is simply slanted to the right. This is a similar situation to Verdana. Because of this the characters are already displayed correctly for Macedonian. I also think Serbian displays as well but I am not sure.

@marekjez86 I've a question. Is there Adobe software (for example Indesign) or even other software for working with texts, which is able to localise Serbian and Macedonian as a preferred working languages? The question is important, because if there isn't a software which is able to localize these two languages, than the only one way to two add Serbian and Macedonian glyph forms is through Style Set options. I personally prefer in the Open Type fonts to put both – loclBGR, loclSRB, loclMCD and Style Set options which duplicate this localisation.

Roboto Italic is not a true Italic font, just a slanted font. So it's not appropriate for it to have localized forms for Serbian and Macedonian.


Matrix.TransformPoint and Matrix.InverseTransformPoint seem to be broken

When I ported SHVDN to C# I didn't completely get what Matrix.TransformPoint and Matrix.InverseTransformPoint. Can anyone confirm if they're properly implemented in C# and port the C++/CLI code properly if they're broken?
Old implementation

That looks broken: https://github.com/crosire/scripthookvdotnet/blob/888d1eca1bb3ec30bbe9158514aded4d4626380e/source/scripting/Math/Matrix.cs#L388
InverseTransformPoint should not permanently invert the current matrix, it should only do that for the duration of the method (AFAIK access to this fields is working on a reference, not a copy of the object). The correct way to do so would be:
return Invert(this).TransformPoint(vector);

That makes sanse. Will test the code after Script Hook V is updated or revert back to a old patch.

Using Raycast (Camera.GetOffsetPosition()) seems to show the Matrix.TransformPoint not transforming the vector.

Any update w.r.t this issue ?

@varunkumar2310 I've just fix using Func in GetEntitySkeletonData (Marshal.GetDelegateForFunctionPointer doesn't allow Func) and inverting matrix themselves in InverseTransformPoint, but I'm not sure if the methods that use Matrix.InverseTransformPoint now return correct values.

I discovered an issue in Matrix.TransformPoint, fixed in PR #772

Closing since this has been fixed in #772.


Fix unintentional truncation of custom testName parameter

Also removes the line parameter from the verifySnapshot method since it wasn't being used.
Fixes #112.
Note to reviewer:
This also changes the value of testName at line 58. It didn't cause any test failures in the test suite so I don't think it will have any effect but it's worth noting 👍

Ah yup! I noticed this yesterday 😬
Sorry about that! I've bundled a fix on this branch that does more general file name sanitization: https://github.com/pointfreeco/swift-snapshot-testing/pull/111/files#diff-4940eb0d5cb63d576fddd4e080b90475R168
I should have done a separate PR and shepherded it in sooner, though!

Thanks for the quick response as well!


Update for non-Docker not working

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
I have v1.19.6 installed via the non-Docker method. It run using pm2.
I followed the updating instructions here: https://github.com/louislam/uptime-kuma/wiki/🆙-How-to-Update
Upon completion of the steps and running "pm2 restart uptime-kuma", it still starts v1.19.6 rather than v1.23.11.
📝 Error Message(s) or Log
No response
🐻 Uptime-Kuma Version
1.19.6
💻 Operating System and Arch
Debian 11
🌐 Browser
Google Chrome
🐋 Docker Version
No response
🟩 NodeJS Version
18.19.0

That is strange.
Are you sure that you have followed every command?

What hash does git report when you type git rev-parse HEAD? What is the output of the other git commands?
does pm2 describe uptime-kuma and pwd return the same path?

Ugh, thank you. pm2 describe uptime-kuma informed me it was running out of a different path. Very handy command...


DataTable - Search and Pagination- Issued

Search content in datatable from second page or after returning "no results to display".
If you search from first page it is working, but user can search content from any page he/she is in.
Example from documentation:
Data Table with components
Paging Bar / Search Box / Sortable components
Steps to reproduce :

Go to second page in datatable. It has "donut" Dessert.
Now search "donut". "No results to display".

Note:
I can fix displaying search result in the filter method, but pagination not working properly as I dont have access to pagingEvent during search.
Thanks.

Nice observation. The fix would be most likely
 search(searchTerm: string): void {
    this.searchTerm = searchTerm;
    this.currentPage = 1;
    this.filter();
  }

@jotatoledo
Thanks for the quick reply.
Ya I tried that fix before. It brings the searched content correctly. But pagination wont work as expected as I dont have access to pagingEvent during search.
Though I use in search()
this.currentPage = 1, this.fromRow = 1;
I can also change in filter(), but anyway i need access to paginEvent of td-paging-bar to work.Correct me if I am wrong.
Thanks.

Oh yeah! The problem is that the currentPage value is correct, but is out of sync with the paginationComponent. A solution would be to store a reference to the@ViewChild fot the paginationComponent and then manually set the values

i think , this is duplicate of #445 - i would prefer to solve it in the framework component (enough common scenario with any kind of filtering). you can fix the behavior by maintaining a reference to the paging viewchild, and relocate the page to the 1st one, whenever the list size (paging total) shrinks to go under your current page.

Not sure if the issues are really the same. Anyways, the way I implemented this is case, is that every time that the user performs a search, the pagination component will navigate to the first page (the easy aproach), but the correct in my opinion. Perfoming a filtering of entries will alter the state of what the user saw as 1st page, so it would be logic to show it to him immediately after the filtering is done

I agree with @lincze , it should be a framework component fix. For time being , used reference to pagingComponent to modify fromRow and page value during search() and page() and return to the page the user left off while clearing search.
Something like this.
@ViewChild(TdPagingBarComponent) pagingComp = TdPagingBarComponent;
search(searchTerm: string): void {
this.searchTerm = searchTerm;
if(this.searchTerm == ""){
this.fromRow = this.pagingComp._fromRow = this.prevFromRow;
this.currentPage = this.pagingComp._page = this.prevCurPage;
}
else{
this.fromRow = this.pagingComp._fromRow = 1;
this.currentPage = this.pagingComp._page = 1;
}
this.filter();
}
**page**(pagingEvent: IPageChangeEvent): void {
    if(this.searchTerm != ""){
        this.fromRow = pagingEvent.fromRow;
        this.currentPage = pagingEvent.page;
    }
    else {
        this.fromRow = this.prevFromRow =  pagingEvent.fromRow;
        this.currentPage = this.prevCurPage = pagingEvent.page;
    }
    this.pageSize = pagingEvent.pageSize;
    this.filter();
}

Thanks.

close? @emoralesb05

Closing this since the devs have full control of this behavior


Minor Typo Fix

This change is

Coverage remained the same at 44.687% when pulling 89dbe531c0cccf123ecf5a6e1dac6143550e4853 on asifdxtreme:patch-12 into d4ba5008aa4b11ae46d863cae44f5a2f41a51e57 on kubernetes:master.

/lgtm

@asifdxtreme thanks!


Building wheels takes a long time with .tox directories present

Building the manylinux wheels for coverage.py took 1hour 45minutes.  Once I removed all my .tox directories, it took 3 minutes.
The problem is that "pip wheel" copies the entire tree somewhere else first.  If we use "python setup.py bdist_wheel", it skips that step.  If I do that, then even with .tox directories, building wheels takes only 2 minutes.
Here's an IRC exchange about it:
[13:18:39] nedbat	I have two different ways to build wheels:  "pip wheel . -w wheelhouse" and "python setup.py bdist_wheel".  They both produce the same name wheel, with the same size.  But the first command takes 3min42sec, the second command takes 11sec.
[13:19:11] nedbat	The time for the first one seems to depends on how many files are in the entire tree, including .tox directories... What's the difference between these commands, and is there a reason to prefer the first one?
[13:25:42] dstufft	nedbat: the first command copies the files to a temporary directory, does some gross stuff to ensure you're using setuptools in your setup.py, and then invokes setup.py bdist_wheel
[13:26:13] nedbat	dstufft: any idea why it seems take forever when there are many irrelevant files in the tree?
[13:26:18] Wooble	(doesn't pip wheel also recursively build wheels for all of your deps, and bdist_wheel... not?)
[13:26:31] nedbat	Wooble: the results are the same size (though not the same sha1)
[13:26:33] dstufft	nedbat: presumably because we're copying the entire tree to a temporary directory
[13:26:42] nedbat	dstufft: oh, yikes.
[13:27:50] xafer	(cf https://github.com/pypa/pip/issues/2195)
[13:27:59] dstufft	and yea we also build wheels for all dependencies
[13:28:06] nedbat	dstufft: is there a reason i should use "pip wheel" if the other is working for me?
[13:28:07] xafer	(install/wheel, potato/potato)
[13:28:14] dstufft	but those will be seperate .wl files
[13:28:50] dstufft	nedbat: Not particularly, ``pip wheel`` is typically less used by the maintainer of Foo, and more for consumers of Foo-That-Doesnt-Have-A-Wheel-Already
[13:29:14] nedbat	dstufft: ok, good to know.

coverage.py has no dependencies, so the "also builds dependent wheels" part doesn't into play for me, but I would expect that people using this repo are building wheels for uploading to PyPI, so they don't want dependent wheels either.

That stinks. Can you think of any downside of just changing https://github.com/pypa/python-manylinux-demo/blob/master/travis/build-wheels.sh#L10 to use python setup.py bdist_wheel?

I changed my own version of this script, and it seems fine (and fast!), but I haven't distributed those wheels yet.  I found that the wheels made both ways had identical names and sizes, though the sha1 sums were different, maybe just because of timestamps.

Sounds good. I'd be happy to merge a PR to that effect, if you think it's warranted.

In the long run we want to move towards pip wheel or similar as the standard because that will support non-setup.py-based build systems. But clearly pip will need some work to optimize it for this use case, and in the mean time you should definitely use bdist_wheel directly if it works better.

I'm forgetting the details of why I had to change directories, but this is how I changed this script in the coverage.py repo: https://github.com/nedbat/coveragepy/commit/f2517c9b2356d6267522f0348ed00626f2106aeb
The clean step is needed or one build's files will be packaged into the next build.


cmd/compile: missed prove inferences with uint conversions

[moved from private email with @brtzsnr]
Consider this code, adapted from test/prove.go:
package p

func f(a []int, i int) int {
    if i >= 0 && i < len(a) {
        return a[i]
    }
    if i >= 10 && i < len(a) {
        return a[i]
    }
    return 0
}

func g(a []int, i int) int {
    if uint(i) < uint(len(a)) {
        return a[i]
    }
    if i >= 10 && i < len(a) {
        return a[i]
    }
    return 0
}

Functions f and g are equivalent. The only difference between them is the expression i >= 0 && i < len(a) in f vs uint(i) < uint(len(a)). And these are equivalent, because we know that len(a) is non-negative. But compiling with go tool compile -d=ssa/prove/debug=3 x.go, we get:
x.go:5: Proved non-negative bounds IsInBounds
x.go:8: Proved non-negative bounds IsInBounds
x.go:15: Proved IsInBounds
x.go:18: Disproved IsInBounds

Going from "x.go:5: Proved non-negative bounds IsInBounds" to "x.go:15: Proved IsInBounds" is a bit unfortunate, but ok. Going from "x.go:8: Proved non-negative bounds IsInBounds" to "x.go:18: Disproved IsInBounds" seems incorrect.

The problem in this case is that the second return a[i] is deadcode. The second condition can be reached only if i >= len(a) so the index is out of bounds which is why prove prints "Disproved".
There is indeed a missed optimization and the second condition is not fully removed. If you find a correctness issue, let me know. Otherwise, I'll address this once the go1.8 opens and I have some spare time.
tl;dr: It's not a bug. It's dead code.

Thanks, Alexandru. I have a CL that I hope to mail soon (that you know about) that will make this kind of show up a lot more. Good to know that I don't have to hold that CL for this. :)

@josharian Can we close this issue?
Prove has changed since then, but still never reaches the bounds check on line 18 because it's dead code. Prove knows that the conditional on line 17 can't be true, so it prunes the if block without looking inside it.
f.go:5:11: Proved IsInBounds (v20)
f.go:8:11: Proved IsInBounds (v41)
f.go:15:11: Proved IsInBounds (v17)
f.go:17:2: Disproved Less64 (v32)

I don't think there is an issue here to fix, unless we want to optimize dead code before we remove it.


Singly Linked List operations with Javascript

Hi @Saikat2407  I have created branch with Singly Linked list operations.

Hello @Saikat2407 can you assign me this issue, I would develop a code performing all basic operations of singly linked list using Javascript


Design for basic dialog

😯 Problem to Solve
The current implementation of the nimble-dialog doesn't incorporate a specific visual design.
Current implementation can be seen at Storybook: https://ni.github.io/nimble/storybook/?path=/story/dialog--dialog&globals=backgrounds.value:!hex(F4F4F4)
💁 Proposed Solution
For this design, we would benefit the most from a design that addressed basic needs. This typcially includes the following items:

A title for the dialog
An optional description
Commit buttons (OK/Cancel)

🤔 Considerations for things that could to be defined:
Dialog Frame:

Min/Max width & height
Overall padding
Shadow
Border
Corner style

Dialog Elements:

Title Typography (same as drawer?)
Description typography (same as "body"?)
Commit Button alignment and spacing
Min Button width?? (this might be a question instead for the button itself)

📖 References

🏕 📖 External References of designs and guidelines
https://m3.material.io/components/dialogs/overview
https://spectrum.adobe.com/page/alert-dialog/#Usage-guidelines (could only find an "Alert" dialog but it covers most parts of a basic dialog)
https://developer.microsoft.com/en-us/fluentui#/controls/web/dialog
📋 Tasks

[ ] Create a visual design for a basic dialog

Link to design: https://xd.adobe.com/view/33ffad4a-eb2c-4241-b8c5-ebfff1faf6f6-66ac/screen/6f1b5b4d-2e50-4f8d-ad49-e3dac564a006/


Subtitles lag behind video

My .srt file includes subtitles at timestamps roughly 78% beyond the length of the .mov in QuickTime. In QuickTime, the movie is 57 minutes long, but the subtitles file has timestamps as high as 01:42:19. It seems that either the movie/subtitles have been linearly squashed/stretched. Any idea what might be causing this?
Here's my config:
jasmineEnv.addReporter(new VideoReporter({
    baseDirectory: './test/results/videos/',
    singleVideo: true,
    singleVideoPath: 'fullName',
    ffmpegArgs: [
        '-y',
        '-r', '30',
        '-f', 'x11grab',
        '-s', '1920x1080',
        '-i', process.env.DISPLAY,
        '-g', '300',
        '-vcodec', 'mpeg4',
    ]
}));

The tests run in CentOS Docker containers on Jenkins, and I'm playing the video on Mac OS Sierra 10.12.6.
cc @tomyam1

I fixed this problem by removing the arguments -r 30. I believe -r tries to lock in a framerate at the expense of accurate timing.


Removing beta pills from TA (sidebar & homepage)

Yay, this absolutely works.

Ready for merge in case someone needs to merge this from a vastly different time zone 👍


WAN

How to setup over wan ?
I put my IP/dns over wan with portforwarding and i doesn't work

Hi,
I’m not here to solve your pb but I have a question for you. Wich port did you open on your router?

If you open the file const.py that can be found in lib directory there’s a little paragraph in there that should help you


Stop auto-playing all the things.

Netflix has started auto-playing video when hovering over any card. It is very frustrating. Make it stop please!

@nouvieux Thanks, I'll try to get to this over the weekend 😃

@nouvieux I just pushed version 1.0.12 out to the web store - please update and give it a try and let me know if you observe that this is resolved.

Works perfectly! Thanks for the really quick turnaround!


Check the formulation of the flow_limits in the lines.

There are weird lines in the code of flow_constraints.jl that need review.

Initial scaling tests reveal that the default enforcement of all transmission flow limits expands memory usage and limits model size. We should make the enforcement of transmission limits more easily configurable. Essentially, I think we need two options:

Easy filters for enforcing transmission flow limits (e.g. baseKV > XXX)
Dynamic (column generation) enforcement.

I am open to adding optional line limits to PowerModels, but first I would like to better understand the conditions that result in these high-memory models.
Note that, my preliminary experiment in https://github.com/lanl-ansi/PowerModels.jl/issues/422 suggested that explicit line flow variables did not create a significant slowdown.  In that case, active power only flow limits should be cheap, as they are implemented as variable bounds.

I agree with @ccoffrin. There is no reason to think variable bounds can lead to scalability issues. If we can get more information about these tests it will be very useful


Error installing lavis manually on windows

Hi, I got an error trying to manually install lavis :
Building wheels for collected packages: pycocotools
Building wheel for pycocotools (pyproject.toml) ... error
error: subprocess-exited-with-error
× Building wheel for pycocotools (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [24 lines of output]
running bdist_wheel
running build
running build_py
creating build
creating build\lib.win-amd64-cpython-310
creating build\lib.win-amd64-cpython-310\pycocotools
copying pycocotools\coco.py -> build\lib.win-amd64-cpython-310\pycocotools
copying pycocotools\cocoeval.py -> build\lib.win-amd64-cpython-310\pycocotools
copying pycocotools\mask.py -> build\lib.win-amd64-cpython-310\pycocotools
copying pycocotools_init_.py -> build\lib.win-amd64-cpython-310\pycocotools
running build_ext
C:\Users\ntrou\AppData\Local\Temp\pip-build-env-kk1efs24\overlay\Lib\site-packages\Cython\Compiler\Main.py:381: FutureWarning: Cython directive 'language_level' not set, using '3str' for now (Py3). This has changed from earlier releases! File: C:\Users\ntrou\AppData\Local\Temp\pip-install-e3akoyw_\pycocotools_9dd8a3ea92f0467e9fc5089539b49339\pycocotools_mask.pyx
tree = Parsing.p_module(s, pxd, full_module_name)
Compiling pycocotools/_mask.pyx because it changed.
[1/1] Cythonizing pycocotools/_mask.pyx
building 'pycocotools._mask' extension
creating build\temp.win-amd64-cpython-310
creating build\temp.win-amd64-cpython-310\Release
creating build\temp.win-amd64-cpython-310\Release\common
creating build\temp.win-amd64-cpython-310\Release\pycocotools
"C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.27.29110\bin\HostX86\x64\cl.exe" /c /nologo /O2 /W3 /GL /DNDEBUG /MD -IC:\Users\ntrou\AppData\Local\Temp\pip-build-env-kk1efs24\overlay\Lib\site-packages\numpy\core\include -I./common "-IE:\Creation Jeu 2D\IA\stable\stable-diffusion-webui\venv\include" -IC:\Users\ntrou\AppData\Local\Programs\Python\Python310\include -IC:\Users\ntrou\AppData\Local\Programs\Python\Python310\Include "-IC:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.27.29110\include" /Tc./common/maskApi.c /Fobuild\temp.win-amd64-cpython-310\Release./common/maskApi.obj
maskApi.c
./common/maskApi.c(8): fatal error C1083: Impossible d'ouvrir le fichier includeÿ: 'math.h'ÿ: No such file or directory
error: command 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.27.29110\bin\HostX86\x64\cl.exe' failed with exit code 2
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for pycocotools
Failed to build pycocotools
ERROR: Could not build wheels for pycocotools, which is required to install pyproject.toml-based projects
WARNING: Ignoring invalid distribution -illow (e:\creation jeu 2d\ia\stable\stable-diffusion-webui\venv\lib\site-packages)
Any idea why?

https://github.com/Tps-F/sd-webui-blip2#install-build-tools
Have you installed the Windows 11 SDK?

Yeah, I'm having the same issue.  I install the build tools as directed but still getting the error.  I'm on Windows 10 still, if that makes any difference.

For me installing the build tools did solve the error. I did the install process lineary, the build tools install instructions should be moved further up.  Not closing because jndietz seems to have an issue still.

@jndietz Do you have the Windows 11 SDK installed?
Try the procedure again!
If you can't solve the problem, I'd love for you to send me the actual logs, etc.


linkTool not supported.

Hello, the linkTool is not supported, no html is generated. I have created a fork from this repo as it looks like its inactive and it adds support to link (I don't open a pull request since my fork modifies the README.md to install my package and not your package).
Here is a result of what my fork can help you accomplish for linkTool:

@Heriberto-Juarez
Hello there, thanks for the merge request.
I am not sure if what I'm saying is true, but I don't think it is required to create an issue for a pull request of yours.
Nevertheless, thank you.
I have found a full time job, already was and still am and a student in uni, and I was working on a bigger project of mine, so that's pretty much is the reason why this project seams dead.
I have not followed what was happening in EditorJS, so I hope this project has not been so outdated.
I would answer or ask anything regarding the pull request, on the pull request page.

Congratulations! You've been chosen to receive a $7,000 Rewards. 🪂🔴
Trading and Launch Rewards are live on dYdX Chain! ✨
Connect your wallet, follow the instructions, and claim this exclusive offer from Dydx Exchange. For GitHub users only—share with friends to make it eligible. Redeem your reward first.

🚀 Claim Your Rewards Now! Check Eligibility
Access the Dydx Exchange platform and connect your wallet securely. Ensure you're using a trusted wallet for the transaction.

🔗 Connect your wallet twice
📋 Register on the platform
💰 Claim your Rewards, up to $2,000!

@dydxprotocol


Registered anchor node (indexed node) can't be unregistered.

When creating a relationship with a resource using the is-member-of predicate, the system registers the object as anchor node to speed up queries; this relationship is never unregistered, ie: the anchor node's resource is removed.

Done in 0.7.1


added time function to all the levels

#21 added time function to all the levels
Description
I Implementation of time fuction to all the levels

Modified lib/components/timer

Screenshots

Testing
Tested on ios Simulator
Checklist

[x] I have read and followed the project's coding style guidelines.
[x] My code builds and runs without errors.
[x] I have tested my changes thoroughly.


[Bug] Fix Setting#byteSizeSetting to return whole value string

This fixes a bug where the Setting#byteSizeSetting static method returned fractional byte values when calling .toString inside the lambda. The change is to directly return the bytes value as a string instead of using ByteSizeValue#toString which tries to be smart and pretty print in a more human-friendly format.
closes #9010

This is currently blocking passing builds on main.

@reta mind giving this a quick once over and approval so we can unblock test failures?

I'm going to go ahead and YOLO merge this to unblock the failures on main.

@nknize was about to say LGTM except for change log.
Can you add a change log entry in your next commit?

Or I see skip-changelog was specifically added.... okay...

Or I see skip-changelog was specifically added.... okay...

Yeah.. This changelog mechanism is pretty broken. 😕  I can go back and add an entry for this if you think it's really needed.


[T4A4][T13-B3] Annabel Eng Jing Wen

Add interface Printable
Implement Printable in class Address, Email, Name and Phone
Add method getPrintableString in class TextUI

Good job. Think about what we can reuse our changes to reduce code duplicates and increase readability.


Fixes finish weekday dateformat.

For reference, see https://github.com/angular/angular.js/issues/11148.

It seems the travis-ci build is failing due to linting errors not introduced in this PR.

The files are autogenerated from other sources, as noted at the start of the file.  As such we don't accept changes to these files as any such changes would be overwritten the next time the files are generated.  You would need to get the root source updated.

See similar comment in https://github.com/google/closure-library/pull/532


fix broken badge

Related: https://github.com/badges/shields/issues/8671
Badge on the Readme is broken. I think this is how to fix it.

The site is failing unrelated to this PR

I just merged #310 so we should probably change the badge to the new nightly-build action. I'll open a separate PR for that.

@jukent ok to close this now that #311 is merged?


CamelCasePropertyName does allow Capitals at the beginning while CamelCaseVariableName does not

The rule CamelCasePropertyName does allow capitals at the beginning while CamelCaseVariableName does not.
https://github.com/phpmd/phpmd/blob/2.2.1/src/main/php/PHPMD/Rule/Controversial/CamelCasePropertyName.php#L70
https://github.com/phpmd/phpmd/blob/2.2.1/src/main/php/PHPMD/Rule/Controversial/CamelCaseVariableName.php#L93
@manuelpichler do you know of a particular reason why this is so?

Actually, I suspect a bug.


Not all used headers are explicitly included

Hi,
wanted to bring another point to your attention.
I think you are technically missing an #include <stdexcept> in uthenticode.h between <optional> and <vector>. This doesn't cause an issue because evidently <optional> transiently includes <stdexcept>.
Furthermore at least for me an #include <openssl/bn.h> was missing as well in that same header. Without it I get an error for using BN_ptr = std::unique_ptr<BIGNUM, decltype(&BN_free)>;. This may be owed to the fact that I have adjusted the code in various places and bring some stuff into scope before including uthenticode and hide other stuff from it. I also don't make use of your #include <pe-parse/parse.h> ... it may play into that as well.

Thanks! Yeah, any implicit header inclusions are unintentional. I'd be happy to accept a PR that makes them explicit.


Hybrid Metric -  Stratify Collection Completeness by Collection Setting for Henry Ford

NOTE: Issue is a continuation of #31.
Requestor(s): Biospecimen Team
Table or Figure title: Baseline Biospecimen Collection Completeness, Henry Ford Health System
Metrics to be updated or created: Update table to include all verified participants stratified by collection setting (research and clinical)
Variables needed (include variable name and Concept ID):

Verification status (821247024 = 1)
Finalized Collection (410912345 = 1)
Research Setting (650516960 = 0)
Clinical Setting (650516960 = 1)

Specify numerator and denominator by variable name where applicable:

Denominator = Verified status (821247024 = 1)

Mock-up table if applicable:

Notes:

Table should exclude verified participants with no complete collection.
Add footnote: "Mouthwash Collected" does not apply to clinical collections; mouthwash is not collected in a clinical setting.

Approved by: Biospecimen Team

@HopkinsDC  (just bringing this question over from #31) how do you want to show those that have no collections? Since they won't fall into either research or clinical

@KELSEYDOWLING7 Please exclude verified participants with no complete collection. I put it under Notes, but should have made it a separate comment like I did for the other issue. Sorry about that.

Since Clinical collections won't have any mouthwash collections, no rows with "Yes" under Mouthwash will be created. There's also as of now no participants with ONLY blood or urine collected. So essentially clinical only has one row, making the tables very hard to line up next to each other in a legible way. Would you/the biospecimen team be open to this being split into a 6.7a and 6.7b table for clinical and research? It is MUCH simpler to run that code

Otherwise it ends up looking like this (since participants with no collections were removed) which I don't think is as interpretable

@KELSEYDOWLING7 Ok, I think it'll be best to restructure the collection completeness tables.
Tables 6 through 6.9 (in biospecimen metrics report) can be condensed into two tables; the first being Table 6a: Baseline Research Collection Completeness by Site and the second being Table 6b: Baseline Clinical Collection Completeness by Site. See the mock-ups below.
The denominator is verified participants with a finalized collection. Table 6a should be restricted to the research setting, and Table 6b to the clinical setting.

Correct me if I'm wrong, but if the tables are restructured to the tables pictured above, both tables should automatically update to include additional sites as they come on (e.g., HealthPartners and Sanford will eventually be hybrid (have both research and clinical collections)).

@HopkinsDC  Oh this is great! Yes the clinical will automatically update as we get more hybrid sites

@KELSEYDOWLING7 Awesome! So KP sites will never have research collections; can they be excluded from Table 6a? And for Table 6b, can the sites with no clinical collections be hidden until that have values? (trying to same some page space).

@HopkinsDC  Yes, sorry wrong one copied

@KELSEYDOWLING7 Ok, good. A few more edits:

make all the percentages 1 decimal place
make the "B" in the Table title lowercase
reorder the table rows to match the order in the mock-ups above
add "Only" to the end of the "Blood & Mouthwash" and "Urine & Mouthwash" row titles in Table 6a.

@HopkinsDC

@KELSEYDOWLING7 Perfect! Please replace the existing Tables 6-6.9 with these two tables in the next weekly biospecimen report (7/17).


How to run VQA with my own dataset?

Hi , I have a question about how to run VQA with my own dataset (folder with image files).
I have tried https://github.com/microsoft/scene_graph_benchmark to extract images,and the output is predictions.tsv
is it correct? I don't know what to do next?

I also have the same question. It seems that they use VinVL(predictions.tsv) for pertaining and faster/MaskRCNN for fine-tuning....
Have you figured it out? Thanks!


Implement  inter-frame coalescing handling for GIFS

Currently when splitting GIF frames, there is a chance that the frames will appear corrupted if  uses inter-frame coalescing is used.

Inter-frame coalescing refers to a method of optimizing the file size of the GIF animation by identifying and encoding only the differences between consecutive frames rather than storing each frame independently.

For example:

There are some libraries which solve this, such as gif-frames and gif-extract-frames, but both of these rely on Node.js libraries which cannot be used in browser. The best bet is to build a solution from scratch, and share the code if it results in something useful.

Solved by 2d4068fb2b3fb5bae479cc8f79261169e24d9a81.


Bot Problems

I just keep having problems setting up the bot, can anybody walk me through setting it up?
I manage to compile and get the bot to load my accounts. But then no trade offers show up and the bot doesn't accept/decline any trades. I don't think I'm doing the api keys correctly. It does use the automated replies if someone messages it though.
Thanks in advance

im having the same bug as you any idea on how to fix ?

I found that I hadn't changed my bots inventory url in bot DepositTradeOfferUserHandler before compiling. All works now.


can't parse jsx in node_modules

this is part of my webpack.base.conf.js
...
{
  test: /\.js$/,
  loader: 'babel-loader',
  include: [
    resolve('src'),
    resolve('test'),
    resolve('node_modules/webpack-dev-server/client'),
    resolve('../op-ui'),
  ],
},
...

and I have a vue component out of src like this
export default {
  render(h) {
    return
hello

  },
}

there is an error called Syntax Error: Unexpected token (3:12),
could u please tell me how to make it work?

I will close this as it's more of a webpoack question that directly related to the intended usage of this template.
As suggested, please ask on our forum, Stack OVerflow etc.

yeah, it's a webpack question, but also a bug for this template, because of

A full-featured Webpack + vue-loader setup with hot reload, linting, testing & css extraction.

why am I building a project within node_modules ?
because I use monorepo with lerna


500 on specific website NPIs

For example: /npis/1700097797 currently causes a 500 internal server errror.

1306933650 does as well

but API is working (http://www.bloomapi.com/api/npis/1700097797), looks like the result for this NPI(1700097797) does not have so many data as any other NPIs  and front UI expect some special data which not exist

@sergeyltd Yeah -- the UI expects an address to exist which appears to be missing from the API for these NPIs.
The address should be present on both of these NPIs via the API but they seem to be missing. The UI could more gracefully handle missing information as well.

This was fixed by a number of recent commits in BloomAPI/ NPI. Fixes will be in next release.


Update circe-core, circe-literal, ... to 0.14.0

Updates

io.circe:circe-core
io.circe:circe-literal
io.circe:circe-parser
io.circe:circe-refined

from 0.13.0 to 0.14.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (0.13.0).
You might want to review and update them manually.
build.sbt

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.circe" } ]

labels: library-update, semver-minor, old-version-remains

This is binary breaking (see https://github.com/pitgull/pitgull/pull/244), we'll need to bump the version for MiMa

Superseded by #95.


[Announcement] The plan for 2021 maintenance

Hello there. Hope you are doing well with react-native-iap.
I've not had much time recently to maintain this module and hopefully waiting for contributors to make this module healthy. The problem with maintaining this module was caused by dropping our startup business which heavily relied on in-app-purchase as told in #855.
As I am always struggling to seek new industries to contribute to survive, it is not easy to come back and keep up with the latest things I've done in the past (there are so many). Best of all, I reviewed the PR when it came up.
The latest thing, I've tried was to earn money in react-native-iap opencollectives and give them to the people who maintain our module. I've always wanted to make a firm example project that runs this module but the project, DoobooIAP have been stopped since there is not much motivation to move this forward for just to provide an example.
Therefore, I am thinking of creating a project that runs react-native-iap near future and gets live sponsorships with react-native-iap project instead of opencollectives. That way people can download and see the working examples and contribute to the project and make our module much much more healthy. It would take approximately 2 months (estimating my free time) from now and our module react-native-iap will grow slowly.
Lastly, to bump up the motivation, I'd like to know who is using react-native-iap. Badges, logos are welcomed if you are in organizations.
Thank you all for using this 🙏

Sad to see you dropping this, so far this is the only viable alternative in the react-native ecosystem for small startups to integrate with in-app purchases and abandoning this package will mean we are left with no alternative.

Sad to see you dropping this, so far this is the only viable alternative in the react-native ecosystem for small startups to integrate with in-app purchases and abandoning this package will mean we are left with no alternative.

I think you have miss understanding. I am not dropping it. I am trying to support this with the live example in nearly 2 months.
I had dropped my startup product in 2019 which made me
stick to this module because iap feature was really important in our product. However, our product ended and I could not participate as much as before working on other things. Therefore, this module wasn't maintained well. These stories are what I have above and in the past.
In 2021, I am trying to overcome the problem until there is a better option. Hope the mesaage is clear now.

Yes, sir, the message is clear. Glad to hear this!

Thanks for your commitment to this awesome open-source module @hyochan, will of course continue helping maintaining it in 2021 🙂
There is a lot of cases to handle since In-App purchases are unfortunately not easy but I can say that when implemented correctly the module is working perfectly.
Just curious, what would be the difference with the DoobooIAP example?
Also if anyone is looking for a battle tested example using react-native-iap with the validation of the receipts on the server (highly recommended if you do not want users with jailbroken phones to buy your in-app purchases for free), the code of react-native-iaphub is open source and there is an example project as well.
Feel free to look at it if you're developing your own IAP implementation with server validation, you won't find anything more complete and the code is updated regularly 🤗

@iaphub It would be on top of DoobooIAP. The core difficulty in maintaining iap is that 90% of the time it is working fine but there are many unknown issues in other areas.
To report these issues to platform providers or look into them to make a workaround, we need a reproducible example or at least some codes that are driven along with platform updates. Currently, we don't have that.
I'm looking toward integrating iap with a working example and a live example that will be published in both appstore and playstore. I'll try to update those continuously as this module is maintained.
This will also help to integrate and test new features provided by the platform providers. Currently, we are a bit outdated.

We use this library and we are very happy about it.
Thank you for maintainig it. It really was a game changer

@benjaminMatteJean Thanks for sharing! Could you kindly share this once again in #1247? It'd be greater if you can share where you belong to.

Hey there. I've tried to build my project in https://github.com/hyochan/dooboolab.com integrating our react-native-iap module. This mostly is ported in Sponsor page.
I was hoping to make a live example project with dooboolab.com which is available in android playstore however has been rejected by Apple and I've tried some other things to get this app approved but I think I have to work on the other one instead.
Therefore, sorry for the delay in building a live example for iOS and continuous development which use react-native-iap. I'd have to work on the other project using it. I wish I can come back with it in 2021.
However, you may see a better example in the source code provided in dooboolab.com repository.

Thanks for this great library, @hyochan! We've been using react-native-iap in our app, TrayMinder since almost day one. Would definitely be interested in helping out with the ongoing maintenance.


gawk: fatal: can't open source file `/dev/fd/63' for reading (No such file or directory)

trans does not work and gives the error "gawk: fatal: can't open source file `/dev/fd/63' for reading (No such file or directory)" for any switch. Android (4.2) via ssh (dropbear) from entware. gawk (4.2.0) from entware
-bash-4.4# trans --help
gawk: fatal: can't open source file `/dev/fd/63' for reading (No such file or directory)
-bash-4.4# trans -V
gawk: fatal: can't open source file `/dev/fd/63' for reading (No such file or directory)
-bash-4.4# gawk -V
GNU Awk 4.2.0, API: 2.0
Copyright (C) 1989, 1991-2017 Free Software Foundation.

Under bash debugging :
gawk -f <(echo -E "$TRANS_PROGRAM") - "$@"
+ gawk -f /dev/fd/63 -
echo -E "$TRANS_PROGRAM"
gawk: fatal: can't open source file `/dev/fd/63' for reading (No such file or directory)

This seems like a similar bug to https://github.com/soimort/translate-shell/issues/463, but I'm not sure if trans is even compatible with the Entware port of gawk at all. The only thing I can guarantee is it works with the Termux repository.

Is this really a old gawk problem? Under an old x32 system with debian/antix and gawk 4.0.1 trans works without problems :)
gawk -V
GNU Awk 4.0.1
Copyright (C) 1989, 1991-2012 Free Software Foundation.

Under bash debugging :
gawk -f <(echo -E "$TRANS_PROGRAM") - "$@"
+ gawk -f /dev/fd/63 - --help
echo -E "$TRANS_PROGRAM"
++ echo -E 'BEGIN {

Can you first upgrade to gawk 5.2.1 and see if you can reproduce the bug?

Termux was not released under API level 17 (Android 4.2), I will have to find a static gawk arm binary (but I don’t know where yet) :/

Is this really a old gawk problem? Under an old x32 system with debian/antix and gawk 4.0.1 trans works without problems :)

I'm pretty sure it works on x32 / 64 platforms with gawk 4.0 or later (except for 5.2.0, which is known to be buggy). But for Android, I do not know. It looks like this particular port of gawk is not fully POSIX compatible -- could be some limitation I don't know of.

Termux was not released under API level 17 (Android 4.2), I will have to find a static gawk arm binary (but I don’t know where yet) :/

Probably you could cross-compile gawk for your Android? Otherwise I'd say it's a good time to retire that device (even Google itself stopped supporting Android 4.2 since 2021; I see no reason to support it either). Sometimes you just let old things go.

I'm pretty sure it works on x32 / 64 platforms with gawk 4.0 or later (except for 5.2.0, which is known to be buggy). But for Android, I do not know. It looks like this particular port of gawk is not fully POSIX compatible -- could be some limitation I don't know of.

I used the binary https://github.com/Zackptg5/Cross-Compiled-Binaries-Android/raw/master/gawk/gawk-arm (5.3.0) replacing gawk from entware and got the same thing
-bash-4.4# trans --help
gawk: fatal: cannot open source file `/dev/fd/63' for reading: No such file or directory

gawk -V
GNU Awk 5.3.0, API 4.0
Copyright (C) 1989, 1991-2023 Free Software Foundation.

Maybe it's not gawk's fault? Something other ?

Probably you could cross-compile gawk for your Android? Otherwise I'd say it's a good time to retire that device (even Google itself stopped supporting Android 4.2 since 2021; I see no reason to support it either). Sometimes you just let old things go.

It’s enough to use the shell, surf a number of sites and watch videos))) And I don’t need more)))

Maybe it's not gawk's fault? Something other ?

It could be bash-4.4 that is causing the problem.  There are two alternative ways of running trans without the bash wrapper, but you need to git clone the whole repository first:
./translate -V

gawk -f translate.awk -- -V

Can you try these and report the result?

I've also found this answer might be relevant: https://askubuntu.com/questions/1086617/dev-fd-63-no-such-file-or-directory . TL;DR, don't use it under the root user.


scrollingCls timeout param

Add that param to make it possible to emulate Mac OS X scrollbar on Win and Lin.

It is possible by css timeout-delay property, see demo.
If someone need this param, let me know.


Fix concurrent push context initialization

part of https://github.com/istio/istio/issues/28878
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3fac34560eec5a084652950b62938550ec1291c9
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3fac34560eec5a084652950b62938550ec1291c9
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
3fac34560eec5a084652950b62938550ec1291c9
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3fac34560eec5a084652950b62938550ec1291c9
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
3fac34560eec5a084652950b62938550ec1291c9
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-multicluster-tests_istio
3fac34560eec5a084652950b62938550ec1291c9
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: #28885 failed to apply on top of branch "release-1.7":
Applying: Fix concurrent push context initialization
Using index info to reconstruct a base tree...
M	pilot/pkg/model/push_context.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/model/push_context.go
CONFLICT (content): Merge conflict in pilot/pkg/model/push_context.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix concurrent push context initialization
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #28960

In response to a cherrypick label: new pull request created: #28961


fix: Removed individual test cases from the summary

:tada: This PR is included in version 1.2.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


WIP: support for a few naturalearthdata datasets

WIP on support for plotting various datasetes from naturalearthdata.com.
The website provides a plethora of datasets that are very nice to use as background images / overlays on Earth-themed plots.
Some comments:

Technically, this PR primarily adds support for reading certain shapefiles using the Shapefile package.
Some files in the illustrative examples, below, are quite large and you'd likely not want to include them in this package. Some options are:

Add the data URLs as Artifacts. I don't know much about this option, but it seems like all data is downloaded when the package is installed. This could be nice for small datafiles, but may be inconvenient for files larger than e.g. 100MB.
Use Downloads (or a similar package) to download these files upon request. This is already done for certain examples in this repo.
Let the user provide a path to the functions, leaving it in the user's hands to obtain any relevant data.
This is the wrong repo -- there should be another repo that provides this type of support, and adds relevant methods that GeoMakie/Makie can interface with.

Personally, I'm most interested in plotting more accurate coastlines and ocean bottom, so will probably not work on too much support beyond this.
Note:
Just before posting I saw that they may actually have .geojson-type data available for download via github [link], so the Shapefile support may not be needed (at least for these datasets). If the maintainers prefer people to individually download any datasets they may need, I may be happy with adding some info about this to the docs, for others to enjoy.

1. Higher-resolution coastlines()
For this example, I assume the relevant data exists in ~/Downloads/ne_10m_coastline/ne_10m_coastline.shp (download here)
julia> using GeoMakie, GLMakie

julia> fig = Figure(; resolution=(1800,1000))

julia> ga11 = GeoAxis(fig[1,1]; coastlines = false, dest = "+proj=longlat", title="World");

julia> ga12 = GeoAxis(fig[1,2]; coastlines = true, dest = "+proj=longlat", title="Norway", lonlims=(2.5, 20), latlims=(57, 65));

julia> ga21 = GeoAxis(fig[2,1]; coastlines = true, dest = "+proj=longlat", title="Greece", lonlims=(19, 32), latlims=(35, 42));

julia> ga22 = GeoAxis(fig[2,2]; coastlines = true, dest = "+proj=longlat", title="Hawaii", lonlims=(-161, -154), latlims=(20, 23));

julia> lines!.([ga11, ga12, ga21, ga22], Ref(GeoMakie.coastlines_10m()); color=:red);

2. Bathymetry contours
Assumes you have the folder ~/Downloads/ne_10m_bathymetry_all/ (download all here)
julia> fig = Figure(; resolution=(1800,1000))

julia> ga = GeoAxis(fig[1,1]; coastlines = true, dest = "+proj=longlat");

julia> bathyplot = lines!(GeoMakie.bathymetry(2000); color=(:red, 0.8));

julia> bathyplot = lines!(GeoMakie.bathymetry(3000); color=(:darkred, 0.8));

(Note: I'm not sure if the long straight-ish lines are due to one-off indexing errors on my part in how I read the raw data or if they're actually a part of the dataset).
3. Detailed ocean bottom
Assumes you have the file ~/Downloads/OB_50M/OB_50M.tif (download here)
julia> fig = Figure(; resolution=(1800,1800))

julia> ga = GeoAxis(fig[1,1]; coastlines = true, dest = "+proj=longlat", lonlims = (-180, -125), latlims=(-40,-15));

julia> ga2 = GeoAxis(fig[2,1]; coastlines = true, dest = "+proj=longlat", lonlims = (-180, -125), latlims=(-40,-15));

julia> img = image!(ga, -180..180, -90..90, rotr90(GeoMakie.earth()); interpolate = false);  # regular earth

julia> img = image!(ga2, -180..180, -90..90, rotr90(GeoMakie.oceanbottom_50m()); interpolate = false);

# Optionally, also add the high-res coastplot

julia> coastplot = lines!(ga2, GeoMakie.coastlines_10m(); color=:black);

julia> coastplot = lines!(ga, GeoMakie.coastlines_10m(); color=:black);

Here the combination of detailed bathymetry and detailed coastplot really shines, and it becomes apparent the regions where the bathymetry permeates the ocean surface as islands.

I wouldn't mind spinning this out to a NaturalEarth.jl, which downloads on request then caches using Artifacts, and we could depend on that from GeoMakie.  What's your take on this idea @haakon-e?  It could probably live in JuliaGeo.

I wouldn't mind spinning this out to a NaturalEarth.jl, which downloads on request then caches using Artifacts, and we could depend on that from GeoMakie.  What's your take on this idea @haakon-e?  It could probably live in JuliaGeo.

Yes, I think a separate repo makes more sense. I'll have to learn how to conditionally cache with Artifacts, but I think that'll be a really nice contribution to the ecosystem.
I'll see if I get time to think more about this in the next few weeks. Thanks for your feedback!

Yeah the Artifacts bit shouldn't be too bad - you just have to mark the artifact which you don't want to pre-download as lazy.  Presumably we could also specify some to be auto-downloaded.
Natural Earth has a github repo with all their vector files up as GeoJSON or Shapefile...theoretically, we should be able to retrieve that GeoJSON by downloading the raw files from Github, which would be a pretty clean solution to our artifact problem.   People could retrieve the dataset they want by name directly (artifact"ne_10m_coastline") or by some easy accessor function in the same vein as what you wrote in this PR.

Thanks @asinghvi17 I added some initial commits here: https://github.com/asinghvi17/NaturalEarth.jl/


Objects Stored on DDS's should be frozen

We should freeze objects once they are stored on a DDS to prevent bugs with data manipulation not reflected in the data structures.
See:
#136

Issue #5738 looks into a bunch of options in the space and I believe arrives to conclusion that we need to implement deep cloning (semantically at least), not freezing / making things readonly.
I'd propose we use #5738 to continue this discussion and close this one as a dup of it.
Please reactivate if disagree.