Validation Bulk Fixes

Docs Build status updates of commit b686300:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/latest/resourcemanager-appservice-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-appplatform-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-authorization-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-cdn-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-compute-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-containerinstance-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-containerregistry-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-containerservice-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-cosmos-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-dns-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-eventhubs-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-appservice-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-appplatform-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-authorization-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-cdn-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-compute-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-containerinstance-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-containerregistry-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-containerservice-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-cosmos-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-dns-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-eventhubs-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 24774b0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/latest/resourcemanager-appplatform-readme.md
:white_check_mark:Succeeded
View (azure-java-stable)

docs-ref-services/latest/resourcemanager-appservice-readme.md
:white_check_mark:Succeeded
View (azure-java-stable)

docs-ref-services/latest/resourcemanager-authorization-readme.md
:white_check_mark:Succeeded
View (azure-java-stable)

docs-ref-services/latest/resourcemanager-cdn-readme.md
:white_check_mark:Succeeded
View (azure-java-stable)

docs-ref-services/latest/resourcemanager-compute-readme.md
:white_check_mark:Succeeded
View (azure-java-stable)

docs-ref-services/latest/resourcemanager-containerinstance-readme.md
:white_check_mark:Succeeded
View (azure-java-stable)

docs-ref-services/latest/resourcemanager-containerregistry-readme.md
:white_check_mark:Succeeded
View (azure-java-stable)

docs-ref-services/latest/resourcemanager-containerservice-readme.md
:white_check_mark:Succeeded
View (azure-java-stable)

docs-ref-services/latest/resourcemanager-cosmos-readme.md
:white_check_mark:Succeeded
View (azure-java-stable)

docs-ref-services/latest/resourcemanager-dns-readme.md
:white_check_mark:Succeeded
View (azure-java-stable)

docs-ref-services/latest/resourcemanager-eventhubs-readme.md
:white_check_mark:Succeeded
View (azure-java-stable)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@weidongxu-microsoft
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you


New plugins proposal

I have created two new plugins:
Bottle-errorsrest:
returns all errors in json format (even those generated with HTTPError)
Bottle-cerberus:
Integrates cerberus schemas into bottle decorators

thank you @kianxineki


Failed to build RiderLink v2<IP_ADDRESS>1

When trying to upgrade the RiderLink plugin from 2<IP_ADDRESS> to 2<IP_ADDRESS>1 we get the following error:
AppData\Local\Temp\UnrealLink\Boxomic\HostProject\Plugins\RiderLink\Source\RD\src\rd_framework_cpp\src\main\wire\SocketWire.cpp(119): error C2220: the following warning is treated as an error
    AppData\Local\Temp\UnrealLink\Boxomic\HostProject\Plugins\RiderLink\Source\RD\src\rd_framework_cpp\src\main\wire\SocketWire.cpp(119): warning C4267: 'argument': conversion from 'size_t' to 'const T', possible loss of data

Looking at the code SocketWire.cpp line 119 is missing a static_cast<int32_t>

Hello, @carl-haven
Thanks for feedback! The issue fixed https://youtrack.jetbrains.com/issue/RIDER-73850. Please try latest commit https://github.com/JetBrains/UnrealLink/commit/e5233121e3ade37b152acd1a02f55eb1303ac4cf


Update er-design-zpl-labels.md

All text into section Design a domain-specific data model is duplicated because it is already described in Design a model mapping for the configured data model point. So it should be removed.

Please, remove this pull request. The proposed modification is not correct.


Toggle on/off

When activated, one must leave active page to "unload" foldersize view. Would have been nice to be able to toggle on/off when pressing the same button

That is conflict with the current design, which is refreshing the folder size.

I've moved size information into a dedicated popup dialog which looks like the following screenshot in 0.7.0.


Azure : Restart-AllDeployments is failing with error - "Resource Group not found"

Logs -
02/27/2019 07:07:08 : [INFO ] Triggering Restart-LISAv2-OneVM-str-4282-74-JT74-20190227070225-role-0...
02/27/2019 07:07:08 : [INFO ] Waiting until VMs restart...
VERBOSE: Performing the operation "Restart" on target
"LISAv2-OneVM-str-4282-74-JT74-20190227070225-role-0".
VERBOSE: Performing the operation "Restart" on target
"LISAv2-OneVM-str-4282-74-JT74-20190227070225-role-0".
VERBOSE: Performing the operation "Restart" on target
"LISAv2-OneVM-str-4282-74-JT74-20190227070225-role-0".
02/27/2019 07:07:11 : [ERROR] Restart-LISAv2-OneVM-str-4282-74-JT74-20190227070225-role-0 failed with error: Resource group 'LISAv2-OneVM-str-4282-74-JT74-20190227070225' could not be found.
ErrorCode: ResourceGroupNotFound
ErrorMessage: Resource group 'LISAv2-OneVM-str-4282-74-JT74-20190227070225' could not be found.
ErrorTarget:
StatusCode: 404
ReasonPhrase: Not Found
OperationID : ee170e6f-5122-4348-9c67-71d7641a07ff Resource group 'LISAv2-OneVM-str-4282-74-JT74-20190227070225' could not be found.
ErrorCode: ResourceGroupNotFound
ErrorMessage: Resource group 'LISAv2-OneVM-str-4282-74-JT74-20190227070225' could not be found.
ErrorTarget:
StatusCode: 404
ReasonPhrase: Not Found
OperationID : f9bb8e71-1dcf-4dcb-bf9a-4e4f1b598113 Resource group 'LISAv2-OneVM-str-4282-74-JT74-20190227070225' could not be found.
ErrorCode: ResourceGroupNotFound
ErrorMessage: Resource group 'LISAv2-OneVM-str-4282-74-JT74-20190227070225' could not be found.
ErrorTarget:
StatusCode: 404
ReasonPhrase: Not Found
OperationID : 05bc5031-a5d7-47fc-984e-46414baed767 Failed to restart Azure VM LISAv2-OneVM-str-4282-74-JT74-20190227070225-role-0

I can't repro this issue on my local machine.

@LiliDeng , I also checked that I can't repro it. But somehow, in our jenkins jobs, this is reproducing. I'm debugging.

@iamshital  i saw it yesterday as well try mutiple restarts

The repro looks inconsistent. Will keep an eye on this.

@juhlee-microsoft , I think this is Azure side (temporary) issue and not the LISAv2.

Close non-P0 issues


[Bug]: cannot configure filter_kind properly due to filetype mapping

Describe the bug
I'm using filetype mapping (see :help aerial-filetype-map) for filter_kind. If I set _ to false (default setting for filetypes not present in the table) Aerial uses default configuration, the one shown in README with only 8 symbols. But it shouldn't exclude anything because false is used to display all symbols.
System information

Aerial config:

-- Paste your call to require("aerial").setup(...) in here
require('aerial').setup {
  backends = { "lsp", "treesitter", "markdown" },
  filter_kind = {
    ["_"] = false,
    lua = {
      "Enum",
      "Function",
      "Method",
    },
  },
}

To Reproduce
Steps to reproduce the behavior:

Use provided config
Open a file (not a lua one)
Notice that false setting for _ is ignored

Possible fix
Probably there's a bug at line 311, because false and nil are equally false conditions:
https://github.com/stevearc/aerial.nvim/blob/6f1b28b549147c2f9e09de16869fcc34cf076253/lua/aerial/config.lua#L311
Substituting line 311 with the following code seems to fix the issue
      if option["_"] ~= nil then
        return option["_"]
      end
      return default

Thanks for the report! Should be fixed now

It's fixed indeed, thanks


reworked log transformer tests

moved tests for LogTransformer to new setup

updated changelog here https://github.com/lvgig/tubular/pull/268/commits/a198103e0120832f4941060cce042e3c40558102


[RFC] Remove DOMElementPool

⚠  Not sure if we should do this ⚠
Since we introduced the DOMElementPool, Chrome has made some improvements to its garbage collection of DOM nodes. With those improvements, storing DOM elements in an object pool does not provide the same performance benefits that it once did. This PR removes the DOMElementPool and replaces its usages with simple calls to document.createElement and HTMLElement.remove.
Results
I compared the experiences of scrolling for 4 seconds straight in a large file with syntax highlighting (text-editor-component-spec.js) before and after removing the element pool. I could discern a difference in the average frame rate or its variance from the timelines.
Looking at the statistics though, it looks like the CPU stays idle for a slightly higher percent of the time with the DOMElementPool. And as you would expect, the memory usage is slightly more stable with the pool.
With element pool

Without element pool

Conclusion
Overall, the pool does improve performance very slightly (maybe imperceptibly).
@nathansobo @as-cii @kuychaco In a way, the element pool is still a good idea, but if we keep it, we need to understand that bug that we saw in the line number rendering. What do you think?

Thanks for collecting this data, @maxbrunsfeld! ❤
Based on your results above, it looks like the difference between the two relative idle times is about 0,04% and we could probably suppose it is noise. Now, assuming the two code paths perform identically over a long time span, I believe the only difference between the two approaches is that with the element pool we pay a small cost for recycling nodes during each frame, while without it we pay a higher cost for garbage collection in between groups of frames, possibly blocking the UI for a long time. To some degree, it's almost like the element pool amortizes the cost of GC across animation frames, making the UI responsiveness more consistent.
So I think the question is: is Chromium intelligently scheduling garbage collection when the user is not performing any task? If not, is there a way we can tune the GC to be less aggressive (https://v8project.blogspot.it/2017/02/one-small-step-for-chrome-one-giant.html)? If either one of these two questions has a positive answer I think we should go ahead and drop it, otherwise it's probably a good idea to keep it and troubleshoot the issue @kuychaco has observed on master.

I think in light of the complete rewrite that we're doing of this layer (https://github.com/atom/atom/pull/13880), we can close this.


Fix TRS list headers

Fix for #2838 , headers for list endpoint was not hooked up properly when converting from v2 final responses to v2 beta responses

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

See the complete overview on Codacy


SAK-30253 : formatting  in List of events view is poor

Screenshots provided in JIRA : https://jira.sakaiproject.org/browse/SAK-30253


Does this support shell pages?

I'm trying to use this with Shell and it doesn't seem to work. I may be using Shell wrong as it's my first time. This is the code I have for my shell page.
<?xml version="1.0" encoding="utf-8" ?>
<Shell xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
    xmlns:pages="clr-namespace:Garsonix.LinkCheckerApp.Pages"
    xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
    x:Class="Garsonix.LinkCheckerApp.MainPage">

    <FlyoutItem FlyoutDisplayOptions="AsMultipleItems">
        <Tab Title="Report">
            <ShellContent ContentTemplate="{DataTemplate pages:ResourcesListPage}" />
        </Tab>
    </FlyoutItem>
</Shell>

My ResourcesListPage has one constructor injected dependency and the page and its dependency are both registered with DI.
So does PageResolver support shell and I'm doing it wrong, or does it not and I should be doing this a different way?
If it does support it, could you add an example to the instructions. If it doesn't, would it be possible for it to do so?

It's not really meant for use with Shell, given that the intended use is for scenarios where you would otherwise new a page. E.g., to replace
var myPage = new MyPage();
await Navigation.PushAsync(myPage);

Given that you don't use this pattern in Shell, I'm not sure how you would use it.
Also, I'm not sure yet as I'm waiting for the team to explain how it will work, but I'm pretty sure the GA version of .NET MAUI will do this for you with Shell. I.e., register your dependencies and then using Shell routes just navigate to your page and it will resolve them for you.
Anyway in the meantime happy to help if I can.
Can you let me know how you're using it in your code?

Thinking about it, one way you could go would be to use the service locator pattern and call the resolver in your constructor, rather than injecting the dependencies.
E.g., instead of:
public class ResourcesListPage : ContentPage
{
    public ResourcesListPage(ResourcesListViewModel viewModel)
    {
        BindingContext = viewModel;
    }
}

you could use
public class ResourcesListPage : ContentPage
{
    public ResourcesListPage()
    {
        var viewModel = Resolver.Resolve<ResourcesListViewModel>();
        BindingContext = viewModel;
    }
}

This might get you through for now, but I think this is an anti-pattern, and once we get some clarification from the MAUI team about how to use DI with Shell you would probably want to update it.

Thanks for the advice. Looks like the anti pattern is a good way to go for now, even if it makes me a little sad. I should be able to use a dependency injected constructor for testing alongside the parameter free constructor.
There is this PR for MAUI at the moment that looks promising to fix this in the hopefully near future:
https://github.com/dotnet/maui/pull/3375

@NogginBox  Just in case folks find this and avoid trying... I've taken the sample and added Shell at the root and it works as is since it makes use of INavigation.PushAsync not Shell.Current.GoToAsync.  There is a weird display artifact when you navigate back to the ShellContent page when the navigation bar is removed.
Interestingly ActivatorUtilities.CreateInstance actually calls the IQueryAttributable interface but since the attached property is not public the dictionary is always empty. Though it doesn't really matter since you already have the Page/VM objects after the create call returns so you could pass in whatever you want.
As an aside It might make sense to add a way to push Navigation Parameters to the extension methods which then test for the IQueryAttributable interface.

Thanks @bakerhillpins. Shell has built in dependency resolution, so I wouldn't use PageResolver for pages that have routes registered in Shell. It's only real use in a Shell app would be for modal pages, or potentially for the Autoreg add-on.

As an aside It might make sense to add a way to push Navigation Parameters to the extension methods which then test for the IQueryAttributable interface.

That's in interesting idea, I'll look into that!


DevKit Unreproducible bug:  Quick Fix... actions appear, but don't complete

Environment data
dotnet --info output:
VS Code version: 1.81.1
C# Extension version: v2.9.346
OmniSharp log
none
Steps to reproduce
unknown
Expected  behavior
For the listed quick fixes to apply
Actual behavior
The quick fixes list just fine, and I can even load them in the refactoring preview, but actually applying it just fails silently.
I've searched as best as I can similar issues, to no avail, so any help or direction would be welcome.

can reproduce, vscode's Windows produce the following stacktrace:
2023-08-11 01:24:51.469 [error] Unable to resolve resource c:%5CUsers%5Ctinta%5CDocuments%5CRepo%5CC#%5CBannerlord%5CFarmerlord%5CEntities%5CCrops%5CScripts%/StandingPointForMainAgent.cs: Error: Unable to resolve resource [...]/StandingPointForMainAgent.cs
    at r.m (vscode-file://vscode-app/c:/Program%20Files/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2308:37515)
    at r.m (vscode-file://vscode-app/[...]/workbench.desktop.main.js:2308:37501)
    at async d.acquire (vscode-file://vscode-app/[...]/workbench.desktop.main.js:19:30395)
    at async c.createModelReference (vscode-file://vscode-app/[...]/workbench.desktop.main.js:2308:38836)
    at async Promise.all (index 0)
    at async r.p (vscode-file://vscode-app/[...]/workbench.desktop.main.js:770:10800)
    at async r.apply (vscode-file://vscode-app/[...]/workbench.desktop.main.js:770:10942)
    at async m.o (vscode-file://vscode-app/[...]/workbench.desktop.main.js:2319:22800)
    at async m.perform (vscode-file://vscode-app/[...]/workbench.desktop.main.js:2319:22377)
    at async h.apply (vscode-file://vscode-app/[...]/workbench.desktop.main.js:2319:24090)
    at async h (vscode-file://vscode-app/[...]/workbench.desktop.main.js:663:61045)
    at async _a.p (vscode-file://vscode-app/[...]/workbench.desktop.main.js:698:47907)

no sensitive information is shared in the previous stacktrace

Thanks - there's an issue with URIs in the prerelease version.  It's been fixed in https://github.com/dotnet/vscode-csharp/pull/6091 and we're planning another release this week.


Documentation with // Styles

I mot found the section for (unordered/ordered) Lists with specific styles like square, disc and other...

ol: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ol#Attributes
ul: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ul#Attributes


feature ID warning message

It would be great to get a warning message when the feature IDs of the assay table do not match the feature IDs in the feature table.

@agalperina Could you please provide an example or some more context where this issue arose? At what step did you expect to see a warning? When a study package is created, OmicNavigator validates that all the feature IDs in the assays table are present in the features table.

Bug fixed in https://github.com/abbvie-external/OmicNavigator/commit/260f71d61ce770f5a89ced0fccb6a670a88bf66d. Now addAssays() will throw an error if any of the assays tables has a non-numeric column.
Thanks @agalperina for the bug report!


Update TemporalContinuousDistributionSection

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Files
Coverage Δ

src/flamme/section/continuous.py
100.00% <ø> (ø)

:loudspeaker: Thoughts on this report? Let us know!.


feat: introduce source and sink related deterministic recovery tests

Is your feature request related to a problem? Please describe.
No response
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response

@wangrunji0408 Can this be marked done?

Not done yet. 🥵


add setplaytime command + add exclusive_roles property for commands

The code looks good.  However we need to support Timezone as an option. Could you please add this as the third parameter?
!setplaytime 10:00 20:00 +7  -> GMT+7
We never know if the next time our server will be deployed in Amazon Cloud US region.


Jax jvp

I have enhanced the xtrain_baseline.py script by substituting jax.grad with jax.jvp. This modification has resulted in a speed increase for xtrain_baseline.py when executed on CPUs.
However, I am currently in the process of understanding ZCS and have not yet applied the same changes to xtrain_zcs.py.

Changes has been added by Kuangdai, along with measurements


fix: Buy now and add to cart over latest nft mints

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[x] Feature

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #9771

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed UI

Copilot Summary
copilot:summary
copilot:poem

thanks!
pay 20 usd

😍 Perfect, I’ve sent the payout
💵 $20 @ 11.46 USD/DOT ~ 1.745 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xeeb08e773ff421d4cce0b6ddd95654c3141b92b3a2b38f3ac0fdb419f786f856
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


[Accessibility][Name, role and value- Recognizer Type (LUIS)]: Role is not defined for the placeholder text in text editor of adaptive dialog.

User Experience
It will create confusion for low vision user as the placeholder text in 'Text editor' looks like normal text as well as it can be deleted.
Test Environment
Browser: Microsoft Edge Canary Version: 82.0.425.0 (Official build)
OS build: 2004 (19564.1005)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here
Repro Steps:

Open the above mentioned URL in EDGE and turn on narrator.
"Bot Framework Composer" homepage will gets opened.
Select any of the previously created bot from "Recent Bots" or create one from the available Bots under 'Examples' and activate it.
Navigate to the "Bot name.main" available under filter edit field and activate it.
Navigate to 'Adaptive dialog' available at right side of the pane.
Navigate to 'recognizer type' and select 'LUIS' in it.
Navigate to the edit field below and observe the issue.

Actual:
The placeholder of the edit field under "Recognizer Type" looks like normal text. As well as it is defined in div due to which if user edit the edit field, pre-defined text is not automatically gets erased.
As well as link mentioned in the edit field is accessible.
Expected:
It should looks like placeholder so that when user navigate and edit into the edit field, content gets cleared. In code it should have role as placeholder.
MAS Impacted: MAS4.1.2
Attachment:

Uploading MAS4.1.2_Role is not defined for the placeholder text.zip…

This doesn't look repro-able in the current version. The box is now "Default result" with a sensible default of "dialog.result", which is not a placeholder.

As per new UI we are not able to locate the pane. So, HCL is closing the issue.


Public Domain UI issues

Date - 12/2/19
Results:

[x] Target and Certificate should not be side by side.  Target on top & Cert below it, with the gray line between them.

[x] Radio buttons should be Horizontal not Vertical with the fields below it.

Example:

@lvuch
Can we add a grey line between Target & Cert to show they are two sections?  Like we do in router.
Example:

Date - 12/5
Verified fixed


Readonly prefix added to wrong instructions when doVerify is false

I was hitting an issue where dynamic methods created with doVerify set to true work, while the same emitted instructions throw an InvalidProgramException when doVerify is set to false.
After checking the generated instructions I noticed the readonly. prefix is only added when doVerify is false. Normally this should not cause an InvalidProgramException, but it does because they're prefixed to the wrong instructions!
Example:
emit.LoadLocal(myLocal);
emit.LoadConstant(0);
emit.LoadElement<DateTime?>();

ldloc.0
readonly.ldc.i4.0
ldelema System.Nullable`1[System.DateTime]

or
emit.LoadLocal(myLocal);
emit.BranchIfTrue(myLabel);

ldloc.3
readonly.brtrue.s _label8

or
emit.StoreElement<DateTime?>()

readonly.stelem System.Nullable`1[System.DateTime]

I will debug further and hopefully will be able to submit a pull request once I have some more time available.

It seems the InjectReadOnly uses the TypeOnStack.UsedBy field which is set by the VerifiableTracker which is called by the RollingVerifier. Either we need to disable the readonly prefix when doVerify is false or make the RollingVerifierWithoutVerification still keep track of stack usage so it can determine readonly prefixes. @kevin-montrose What are your thoughts on this? I would be happy to work either way.

It seems that this project is abandoned.
Anyway, I was hitting a problem with the readonly prefix too. I'm not sure is the same as yours, though.
https://github.com/chaplin89/Sigil/commit/b00e1e19405b91deafd4ac413fc541251776789c


Add option to ignore recorded violations

This adds a command-line option --ignore-recorded-violations to check and check-contents commands that skips filtering out recorded violations. This is especially useful in editor integrations to see all the violations, even those recorded in package_todo.yml.

Nice thanks!


A Hero widget cannot be the descendant of another Hero widget.

The following assertion was thrown building Hero(tag: name1234657965045645640665605ffa6506afaf6f4a4f, dirty, state: _HeroState#c78d7):
A Hero widget cannot be the descendant of another Hero widget.
'package:flutter/src/widgets/heroes.dart':
Failed assertion: line 390 pos 7: 'context.findAncestorWidgetOfExactType() == null'
Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:

Closing this as a duplicate of #38684.


Support the FHIR standard

As a Healthsites data administrator I want to support the FHIR standard so that facility lists that support FHIR can send and receive health facility data with Healthsites.

See https://github.com/healthsites/healthsites/issues/1042


feat(runs_on): permit using array of string to select specific runner

Check List

[X ] Read CONTRIBUTING.md

[X ] Read OSS Contribution Guide

[X ] Write a GitHub Issue before creating a Pull Request

Link to the issue: https://github.com/suzuki-shunsuke/tfaction/issues/1738

[X ] All commits are signed

This repository enables Require signed commits, so all commits must be signed

[X ] Avoid force push
[ X] Do only one thing in one Pull Request

Permit using array of string to select GitHub runners on which run jobs.
Necessary to select self hosted runners.

Your commits aren't singned.

[X ] All commits are signed
This repository enables Require signed commits, so all commits must be signed

Hi,
I saw that we could sign with our SSH key. I thought that since I was using my SSH key to clone the repo, the associated commits were automatically signed. But indeed, a bit of configuration was missing...
I have redone my commits as indicated in the procedure and force-pushed these two rebased commits with a signature.
I would like to ensure that all the changes I have made work correctly before merging them. It is quite complicated to test due to all the internal references to suzuki-shunsuke/tfaction@main. I saw that we could use a GitHub Action to create the PR and point to it in our workflows?

@NikitaCOEUR You can test this pull request using the version pr/1740.

https://github.com/suzuki-shunsuke/tfaction/pull/1740#issuecomment-2214098796

@NikitaCOEUR You can test this pull request using the version pr/1740.

https://github.com/suzuki-shunsuke/tfaction/pull/1740#issuecomment-2214098796

Yes thanks I saw that but I couldn't find any time for that now. Maybe next week!

Hi,
I've added a new commit to fix an issue I introduced where the runs_on field was no longer optional in certain configurations. This should restore the previous behavior.
Additionally, I've retested everything, but I still encounter an error that I don't understand:

 bash: /home/runner/work/_actions/suzuki-shunsuke/github-action-terraform-init/71673ab29266f67c4470773675e087e9a4dda3c5/main.sh: No such file or directory

Despite this, the changes I've made seem to have the desired effect:
content of my tfaction-root.yaml :
target_groups:

# Target group 1 with specific self hosted runner (specified via array of strings)
- working_directory: terraform/env-TF-ACTION-TEST/
  target: TF-ACTION-TEST/
  environment: TF-ACTION-TEST
  runs_on:
    - self-hosted
    - runners
  secrets: # GitHub Secrets
  - env_name: AWS_ACCESS_KEY_ID # Environment variable name
    secret_name: BACKEND_ACCESS_KEY_ID
  - env_name: AWS_SECRET_ACCESS_KEY # Environment variable name
    secret_name: BACKEND_SECRET_KEY
  - env_name: SOPS_AGE_KEY
    secret_name: SOPS_AGE_KEY

# Target group 2 with specified runners (with string)
- working_directory: terraform/env-TF-ACTION-TEST2/
  target: TF-ACTION-TEST2/
  environment: TF-ACTION-TEST
  runs_on: ubuntu-latest
  secrets: # GitHub Secrets
  - env_name: AWS_ACCESS_KEY_ID # Environment variable name
    secret_name: BACKEND_ACCESS_KEY_ID
  - env_name: AWS_SECRET_ACCESS_KEY # Environment variable name
    secret_name: BACKEND_SECRET_KEY
  - env_name: SOPS_AGE_KEY
    secret_name: SOPS_AGE_KEY

# Target group 3 without any runs_on specified
- working_directory: terraform/env-TF-ACTION-TEST3/
  target: TF-ACTION-TEST3/
  environment: TF-ACTION-TEST
  secrets: # GitHub Secrets
  - env_name: AWS_ACCESS_KEY_ID # Environment variable name
    secret_name: BACKEND_ACCESS_KEY_ID
  - env_name: AWS_SECRET_ACCESS_KEY # Environment  variable name
    secret_name: BACKEND_SECRET_KEY
  - env_name: SOPS_AGE_KEY
    secret_name: SOPS_AGE_KEY

Target group 1 with specific self hosted runner (specified via array of strings)

Target group 2 with specified runners (with string)

Target group 3 without any runs_on specified

Could you please help me with this issue?
Thanks!

 bash: /home/runner/work/_actions/suzuki-shunsuke/github-action-terraform-init/71673ab29266f67c4470773675e087e9a4dda3c5/main.sh: No such file or directory

I'm not sure why this error occurred. main.sh should exist.
    - run: bash ${{ github.action_path }}/main.sh

https://github.com/suzuki-shunsuke/github-action-terraform-init/blob/71673ab29266f67c4470773675e087e9a4dda3c5/action.yaml#L28
This error would occur if you run this action in a container, but I guess you didn't do that.

https://github.com/actions/runner/issues/2185

Hmm ..
Indeed, I am using containers to run my GitHub actions.
That seems to be the problem.
I just saw a workaround suggested by someone: https://github.com/actions/runner/issues/716#issuecomment-795238933
I'm not sure if that would make sense here?

Could you allow me to push commits to the feature branch?
e.g. https://github.com/aquaproj/aqua-registry/pull/24089
Maintainers are allowed to edit this pull request.

So, I had to transfer the ownership of the fork to my user account to be able to activate this option.

So, I had to transfer the ownership of the fork to my user account to be able to activate this option.

Oh, really. I didn't know that.
The document seems not to refer that.
Anyway, thank you for your update.

a0f260e84fa76fc2a970a05dbbb7c0156953e6b5 Replaced ${{github.action_path}} with $GITHUB_ACTION_PATH.

Here's the translation:

The purpose of this pull request seems fine.
However, I have issues with the Taskfile combined with the execution of my GitHub Actions in a container.
I use a Taskfile at the root of my project as a wrapper for Terraform commands. This is used when a task command is executed from the root or in one of the subfolders. But they have implemented a safeguard based on directory ownership; task ascends through parent directories and stops if it does not find a Taskfile or as soon as the owner of the current directory changes compared to the previous one(https://github.com/go-task/task/blob/573949573968cc7056b98e0fdbee1d145ad869a9/taskfile/taskfile.go#L149) ... And this is the case since the containers on GitHub Actions are executed with the root user...
Also, the repo is cloned on the runner, and the volume is mounted in the container. When accessing the repo's folders, the root folder of the repo belongs to the user running Docker, but the subfolders belong to the user of the container (root).

It seems that a workaround exists : https://github.com/actions/checkout/issues/47#issuecomment-536109176
I'll test that tomorrow.

The purpose of this pull request seems fine.

Thank you for testing. It looks good.
Seems like your issue has nothing to do with tfaction.

It seems that a workaround exists : actions/checkout#47 (comment)
I'll test that tomorrow.
Doesn't work )=

But I have a workaround for my problem with Taskfile, which I posted in an issue: https://github.com/go-task/task/issues/1683#issuecomment-2234287796
However, this problem appears again with the git command. I just opened an issue here: https://github.com/suzuki-shunsuke/github-action-terraform-init/issues/19

However, this problem appears again with the git command. I just opened an issue here: https://github.com/suzuki-shunsuke/github-action-terraform-init/issues/19

The issue was solved.

https://github.com/suzuki-shunsuke/github-action-terraform-init/issues/19#issuecomment-2235974391

So everything is fine, right?

Workflows also run smoothly when they are not inside a container!
Tested and approved by me!
Thanks for your help and support.

Do you have some doc to update for this feature ?

Do you have some doc to update for this feature ?

~/repos/src/github.com/suzuki-shunsuke/tfaction-docs main                                                                             07:49:57
$ git grep runs_on
docs/config/tfaction-root-yaml.md:  runs_on: ubuntu-latest # default is "ubuntu-latest". This is useful to use GitHub Actions Self Hosted Runner for the specific provider

https://github.com/suzuki-shunsuke/tfaction-docs/blob/bfc28814d4acfaf8d535de76509affe052a34d8e/docs/config/tfaction-root-yaml.md?plain=1#L177

I'll update the document.

I can't ensure non-regression without running within a container. I have an issue; I don't know if it's caused by the transition from ${{GitHub.action_path}} to $GITHUB_ACTION or if it's on my end.

I have an issue

Could you explain the detail of your issue?

I can't ensure non-regression without running within a container.

I've already confirmed this pr worked fine without a container.

I have an issue

Could you explain the detail of your issue?

No, it's on my end then; the problem only occurs when I run without a container. I get an exit code 2 when running Terraform through my wrapper. But it must be due to the context change. I use the action within a container anyway, so there's no problem for me.

v1.5.2 is out 🎉
https://github.com/suzuki-shunsuke/tfaction/releases/tag/v1.5.2


Add 'catch-all' server block to suppress Invalid HTTP_HOST exception

Got Invalid HTTP_HOST exception in default configuation.
Add catch-all server block to suppress those suspicious requests.

@nattster, have you got a chance to test this in production?

@webyneter With default configuration I got random Invalid HTTP_HOST headers 2-3 times a day.

Add this configuration helps preventing those suspicious request from reaching Django. Suppressing these errors.

Thanks for submitting this PR, but we are going to switch to Caddy any time now making this more or less obsolete.


Added a JSONPath tester tool

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[X] New feature or enhancement
[ ] UI change (please include screenshot!)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Internationalization and localization
[ ] Other (please describe):

What is the current behavior?
Issue Number: #749
What is the new behavior?
Added a new tool dedicated to testing JSONPath.
Also, moved Regex Tester and XML Validator tools to a new Testers group.
Other information

Quality check
Before creating this PR:

[X] Did you follow the code style guideline as described in CONTRIBUTING.md
[X] Did you build the app and test your changes?
[ ] Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
[X] Did you verify that the change work in Release build configuration
[X] Did you verify that all unit tests pass
[X] If necessary and if possible, did you verify your changes on:

[X] Windows
[ ] macOS (DevToys 2.0)
[ ] Linux (DevToys 2.0)

Hum quick thinking, should we keep the XML Validators in the same group or we could create a new Validators groups?
I think it's weird to have the XML Validators with the Testers.

Thanks for the suggestion. XML Validator, in the end, "tests" an XML against its XSD. How about renaming XML Validator to XML / XSD Tester or XML Tester ? What do you think @btiteux ?

Ok we can rename the XML Validator for XML Tester.
No test for this tool?

Ok we can rename the XML Validator for XML Tester.

Done !

No test for this tool?

There are tests for the helper, but I admit there aren't for the gui and command line.

Thanks @btiteux , I just pushed a few more tests for UI and command line


Server-side async streaming issue: premature RPC closure

What version of gRPC and what language are you using?
v1.34.0
What operating system (Linux, Windows,...) and version?
Linux, Debian 64-bit, 10.7
What runtime / compiler are you using (e.g. python version or version of gcc)
Stock Debian gcc 8.3.0
What did you do?
I have a distributed locker service where callers can watch certain keys. Every key modification results in a streaming notification to N interested clients. I have a set of smaller integration tests that exercise this "watch" and things work correctly. Yet when I use the component from another distributed service (which applies some load), I observe premature closure of the outstanding server-side RPC objects.
The following RPC dispatch loop senses the premature closure and destroys the RPC:
    worker_ = std::thread([cq = cq_.get()] {
        DCHECK(cq != nullptr);
        void *tag = nullptr;
        bool ok;
        while (cq->Next(&tag, &ok)) {
            DCHECK(tag != nullptr);
            auto call = static_cast<rpc::Call *>(tag);
            if (ok) {
                call->Proceed();
            } else {
                LOG(INFO) << "GRPC reported shutdown. Destroying RPC: " << call;
                call->Destroy();
            }
        }
    });

What did you expect to see?
I do not expect the code above to execute until the server shuts down. The issue is hard to repro... The component-level tests never hit this...
What did you see instead?
I saw some server-side RPCs reported via the CompletionQueue::Next() API with ok=false. This should not happen until the server is shutdown...
Detailed GRPC logs
Old message pertaining to the tag in question
I20201228 18:51:53.331117 15025 completion_queue.cc:1079] RETURN_EVENT[0x55b6954ce6c0]: OP_COMPLETE: tag:0x7fc0dc27d1b8 OK

The server-side code notifies one watcher via the async stream:
I20201228 18:51:58.426393 15024 Constituent.cc:480] Notifying watcher on session_id=5 for key: logger/bucket/2/leader
I20201228 18:51:58.426400 15024 rpc_server.h:187] 0x7fc0dc27cbe0 Notification: writing a streaming RPC response: key { key: "logger/bucket/2/leader" version: 1 data: "\004\000\000\000\000\000\000\000" }

GRPC complains about the stream
I20201228 18:51:58.426419 15024 call.cc:1966] grpc_call_start_batch(call=0x7fc0dc26cfa0, ops=0x7fc0e3ff5870, nops=1, tag=0x7fc0dc27d1b8, reserved=(nil))
I20201228 18:51:58.426422 15024 call.cc:1562] ops[0]: SEND_MESSAGE ptr=0x7fc0b4052400
I20201228 18:51:58.426434 15024 completion_queue.cc:704] cq_end_op_for_next(cq=0x55b6954ce6c0, tag=0x7fc0dc27d1b8, error={"created":"@1609210318.426428215","description":"Attempt to send message after stream was closed.","file":"/home/oleg/3p/grpc/src/core/lib/surface/call.cc","file_line":1190}, done=0x55b693b77940, done_arg=0x7fc0dc26fa90, storage=0x7fc0dc26fad8)

The server-side code notifies another watcher via the async stream:
I20201228 18:51:58.426482 15024 Constituent.cc:480] Notifying watcher on session_id=6 for key: logger/bucket/2/leader
I20201228 18:51:58.426488 15024 rpc_server.h:187] 0x7fc0dc372890 Notification: writing a streaming RPC response: key { key: "logger/bucket/2/leader" version: 1 data: "\004\000\000\000\000\000\000\000" }

GRPC accepts the data and pushes it out
I20201228 18:51:58.426499 15024 call.cc:1966] grpc_call_start_batch(call=0x7fc0dc356660, ops=0x7fc0e3ff5870, nops=1, tag=0x7fc0dc373068, reserved=(nil))
I20201228 18:51:58.426503 15024 call.cc:1562] ops[0]: SEND_MESSAGE ptr=0x7fc0b4052d80
I20201228 18:51:58.426519 15025 completion_queue.cc:1079] RETURN_EVENT[0x55b6954ce6c0]: OP_COMPLETE: tag:0x7fc0dc27d1b8 ERROR

GRP notifies the server-side code about RPC closure:
I20201228 18:51:58.426527 15025 Server.cc:295] GRPC reported shutdown. Destroying RPC: 0x7fc0dc27cbe0

Other stuff... the second stream works correctly:
I20201228 18:51:58.426533 15025 metadata_array.cc:34] grpc_metadata_array_destroy(array=0x7fc0dc27cca0)
I20201228 18:51:58.426537 15025 call.cc:581] grpc_call_unref(c=0x7fc0dc26cfa0)
I20201228 18:51:58.426535 15024 completion_queue.cc:704] cq_end_op_for_next(cq=0x55b6954ce6c0, tag=0x7fc0dc373068, error="No Error", done=0x55b693b77940, done_arg=0x7fc0dc359150, storage=0x7fc0dc359198)
I20201228 18:51:58.426540 15025 metadata_array.cc:34] grpc_metadata_array_destroy(array=0x7fc0dc26da68)
I20201228 18:51:58.426546 15025 completion_queue.cc:978] grpc_completion_queue_next(cq=0x55b6954ce6c0, deadline=gpr_timespec { tv_sec:<PHONE_NUMBER>854775807, tv_nsec: 0, clock_type: 1 }, reserved=(nil))
I20201228 18:51:58.426551 15025 completion_queue.cc:1079] RETURN_EVENT[0x55b6954ce6c0]: OP_COMPLETE: tag:0x7fc0dc373068 OK

Final thoughts
It appears that GRPC erroneously considers one of the streams as "closed", even though I have not touched it. In fact the associated tag was used about 5 seconds earlier... The issue is not easy to repro... and it just so happens that I lose about three RPCs this way in a larger integration test that brings up a whole bunch of components and nodes in a single process...
Perhaps there is something very sly with the server-side streaming contract and the associated state machine... I believe I implemented the flow control correctly...
What else can I check to narrow down the issue further? Thanks in advance!

Analysis
Here is the a lifetime of the RPC object when the issue occurs:
I20201228 19:36:00.252887 15504 rpc_server.h:97] 0x7f1ea82b5b80 allocated
I20201228 19:36:00.253015 15504 rpc_server.h:106] 0x7f1ea82b5b80 Got a req: key: "logger/bucket/0/leader" session_id: 5 reactivate: true
I20201228 19:36:00.604547 15501 rpc_server.h:188] 0x7f1ea82b5b80 Notification: writing a streaming RPC response: key { key: "logger/bucket/0/leader" data: "\003\000\000\000\000\000\000\000" }
I20201228 19:36:00.605296 15504 rpc_server.h:220] 0x7f1ea82b5b80 Done with writes for now. Marking as Writable...
I20201228 19:36:05.813485 15503 rpc_server.h:188] 0x7f1ea82b5b80 Notification: writing a streaming RPC response: key { key: "logger/bucket/0/leader" version: 1 data: "\003\000\000\000\000\000\000\000" }
I20201228 19:36:05.814301 15504 Server.cc:295] GRPC reported shutdown. Destroying RPC: 0x7f1ea82b5b80
W20201228 19:36:11.067242 15502 rpc_server.h:120] 0x7f1ea82b5b80 dropped a streaming response (explired state): key { key: "logger/bucket/0/leader" version: 2 data: "\003\000\000\000\000\000\000\000" }
W20201228 19:36:16.408736 15502 rpc_server.h:120] 0x7f1ea82b5b80 dropped a streaming response (explired state): key { key: "logger/bucket/0/leader" version: 3 data: "\003\000\000\000\000\000\000\000" }

The only thing the catches my eye is the 5s gap between the the first streaming response and the one that causes the closure. And that is exactly the deadline specified by the client-side code. So, it appears to be enforced by the server-side code.
Answer
This is the async server-side streaming that I am using to communicate change notifications. As such, there is no meaningful deadline.
So, the answer to the question is simple - avoid specifying a deadline when working with server-side streaming. That makes no sense :)


Update direct-routing-plan.md

Correcting Australia DCs to refer to AU East and Southeast (there's no AU West Azure Datacentre)

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@CarolynRowe PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


interceptor should handle default values of download and upload throughput

When download and upload throughout are set to their default values, the timer would compute negative delay and keep spinning forever. There was no problem with emulation from devtools because latency, download throughput and upload throughput are always specified.
Fixes https://github.com/electron/electron/issues/8203

Thanks for this @deepak1556


docs: add Python 3.11 to classifiers in metadata

Hi there, my first PR to the project.
The tests in GitHub Actions run on Python 3.11 as well. I guess you should add it to the project metadata then.

Thanks @afuetterer!


Maze solver and mountain runners shows no video

https://juliadynamics.github.io/AgentsExampleZoo.jl/dev/examples/maze/
https://juliadynamics.github.io/AgentsExampleZoo.jl/dev/examples/runners/
@AayushSabharwal maybe you can take a look for this one?

Looks like it's just missing FileIO as a dependency


Investigate UDP transport

While the current implementation using both tcp and quic work, there might be benefits to implementing proper "plain" UDP sockets. While these won't be useable with the current connection trait, an approach would be to add a a slightly differnet read/write loop for this. The current frames can be encoded pretty easily, and we might be able to properly support recvmmsg and sendmmsg (double m intended yes)

This will likely not be done as a result of #253. However, a hybrid solution might be possible (especially for quic), where protocol messages use reliable communication, and data forwarding uses plain udp. Quinn supports sending unreliable datagrams for instance. This would require reworking the connection trait

there might be benefits to implementing proper "plain" UDP sockets

what is the benefit?


do not override explictly set autoupdate fields

(For a schema using timestamps) if the updated_at field isn't set, Ecto will
autoupdate it. If it's part of the changeset, Ecto will use that value.
The issue is that when putting changes, Ecto will not add identical values.
If during an update, the updated_at field is set to the models (original)
updated_at value, it will not be part of the changeset. If another value is
changed (so the schema has changes), the updated_at field will (potentially)
have a different value (depending on the timing of the update call). As the
field was being explicitly set to a specific value, this was surprising.
This fix forces the updated_at field to be added to the changeset, even when
it's identical to the original value. I assumed this logic would apply to
all autoupdated fields, and not just timestamps.

Thanks for the PR!
Changesets work on a simple contract, changeset and we wouldn’t want to
augment it and couple it with schemas any more than necessary.
Also, the behavior can be achieved with force_change, so please use said
API instead.
--
José Valim
www.plataformatec.com.br
Skype: jv.ptec
Founder and Director of R&D

Thanks for the quick review. I noticed this on a schema that is sometimes populated from external data, and was surprised by this behaviour of cast (I'd explicitly set updated_at in my tests, and the persisted value would occasionally be a second later). But the argument against any further coupling make sense. I thought this approach might have been rejected due to the possibility of unnecessary DB write, so I'm glad I proposed this PR before I tried a more complex solution. Thanks again


Use SimpleBlockModel instead of BasicBlockModel for coverage blocks

The BasicBlockModel does not split basic blocks on instruction that branch outside of the function (i.e. calls). This can lead to instructions being highlighted even if they are not covered, usually when a called function never returns. Ghidra offers the SimpleBlockModel, which is a drop-in replacement (also implements the CodeBlockModel interface) and splits blocks on all flow-breaking instructions.
Below, I have an example where I loaded a coverage file for an ARM binary, with only the basic block at 36c of length 1 being covered.
Current state using BasicBlockModel, coverage is extended beyond the memset call

Coverage using SimpleBlockModel, coverage is not extended beyond the memset call

Nice catch! To clarify - the program you've collected coverage for as an illustration throws a segfault at the memset and terminates - but Cartographer continues to highlight the following instructions because it's highlighting on a BasicBlockModel rather than the SimpleBlockModel?
I'm not with nccgroup but I'll merge this into my fork if my understanding is correct - thanks!

Nice catch! To clarify - the program you've collected coverage for as an illustration throws a segfault at the memset and terminates - but Cartographer continues to highlight the following instructions because it's highlighting on a BasicBlockModel rather than the SimpleBlockModel?
I'm not with nccgroup but I'll merge this into my fork if my understanding is correct - thanks!

Yes, this is precisely what happens. In general, the coverage will be wrong when a function doens't return,so

when a fault is created inside of the function
when the function is non-returning by definition (e.g. exit)
execution of the program is stopped from outside (timeout is reached)

For the program in the screenshot, the memset might actually be fine, it was just the first example program I had at hand, and I created the coverage manually to include the first BB of the function.


Add additional links to chapters in main readme

Is your feature request related to a problem? Please describe.
At main readme there is no links to chapters where chapters are described.
Describe the solution you'd like
Add missing links to enhance navigation


add operator-sdk from local bin

specify version for operator-sdk for make bundle
download operator-sdk pinned version when generating bundle update make bundle to use local operator-sdk update to 1.31 version

/test dataplane-operator-build-deploy-kuttl


Add sales number on asset teaser

It would be useful to add the sales number on the asset teaser as well. Works really well with https://github.com/oceanprotocol/market/issues/1522

It would be useful to add the sales number on the asset teaser as well. Works really well with #1522

Agree. I propose one of this UI options:

1 looks nice


Version rollback after db.open() if page reloading took place. Bug!

Found a bug. db.open() gets previous version of db if the page was reloaded.
At the first picture my code works as described below. Dexie object will be initialised only once and the structure of db might be modified many times successfully. I always can get the actual version after db was opened in the part 2.

But if I reloaded the page, then new Dexie object will be created. So I can't get the actual version after db.open() in the part 2. Before I run db.open() in the part 2, my db.verno == version, but right after db was openned, my db.verno == version -1. So I can't change db structure anymore after page reloading. This situation is described at the second picture.

I understand that it is really hard to explain my situation, but I tried. If you need more details, please ask. Hope it is possible to fix.

Thanks for your effort to describe this issue. Still it is hard to understand what is going wrong without a full sample code. Could you link to a jsfiddle or attach a page that reproduce the error? I will do my best to try find the eventual bug. Thanks in advance! // David

Our company decided to use raw IndexedDB API, so that code doesn't exist nomore.
The main idea in my issue was in fact that I got the previous version after page refreshing, not the last.

Closing this issue because we cannot reproduce it and it's not occurring in our unit tests (test-upgrading).


Add automatic non-interactive wallet unlock command

Wallet unlock with SIA_WALLET_PASSWORD environment variable non-interactively
Addresses trello public road map feature
https://trello.com/c/yRFaIgLb/65-enable-the-wallet-to-unlock-at-startup-without-user-intervention-advanced-less-secure-feature-primarily-for-hosts
see transcript below
➜  001 cat typescript.txt
Usage:
./siac wallet [flags]
./siac wallet [command]
Available Commands:
address         Get a new wallet address
addresses       List all addresses
autounlock      Automatically (non interactively) unlock the wallet
balance         View wallet balance
change-password Change the wallet password
init            Initialize and encrypt a new wallet
init-seed       Initialize and encrypt a new wallet using a pre-existing seed
load            Load a wallet seed, v0.3.3.x wallet, or siag keyset
lock            Lock the wallet
seeds           View information about your seeds
send            Send either siacoins or siafunds to an address
sweep           Sweep siacoins and siafunds from a seed.
transactions    View transactions
unlock          Unlock the wallet
Flags:
-h, --help   help for wallet
Global Flags:
-a, --addr string   which host/port to communicate with (i.e. the host/port siad is listening on) (default "localhost:9980")
Use "./siac wallet [command] --help" for more information about a command.
➜  siac git:(master) ✗ ./siac wallet autounlock
SIA_WALLET_PASSWORD not set
➜  siac git:(master) ✗ SIA_WALLET_PASSWORD="abc" ./siac wallet autounlock
Could not unlock wallet: error when calling /wallet/unlock: provided encryption key is incorrect
➜  siac git:(master) ✗ SIA_WALLET_PASSWORD="boil envy pram jogger sidekick bakery sunken gown mayor necklace navy certain noted bygones tidy zebra ongoing laboratory fierce duplex password changed for security reasons but environment variable good for docker" ./siac wallet autounlock
Wallet unlocked
➜  siac git:(master) ✗

@lukechampine might be worth taking another look at this, as we have "Enable the wallet to unlock at startup without user intervention" in our roadmap for next release.
I spoke with @rudibs, he is willing to refine it and add 1-2 other variations.


Add react toastify for invalid url response

Add react toastify for invalid url response

assign this to me

Hey @Sahilll15, currently we are migrating from react to next.js with tailwind and also we are adding to addition features, once all these issues get resolved you can work on this.

okay


REQ: A new file type "ask2edit" to complement read only and regular file loads

I wanted to propose an additional type of file for aider to load in to the conversation.  I'm sure we can come up with a more elegant name, but for now I'll call it "ask2edit".
At the moment we can load files that are editable, or we can load files that are read only and use Sonnet's cache mechanism.
The purpose of the ask2edit load type would be that the file can be edited by the LLM but the LLM doesn't have carte blanche to make changes, instead it should only make changes when the user has reviewed and approved them.
Working through a larger project I'm refining my process of product requirements, architecture, design and implementation planning and then proceeding with coding and debugging.  As is the norm during development, adjustments to the product requirements and related cascading changes will need to be made.  However the LLMs have a habit of removing or altering things we may not want to have altered in the requirements or design documents, when trying to update them to reflect additions or changes that happen during development.
As part of my conventions.md I would like to tell the LLM that when we materially update or enhance a feature that is mentioned in the product requirements document, also update that requiremetns document so it stays in sync with the project code as built.  However, I would like the LLM to present the current version of the relevant section and the proposed changes while identifying the file it wants to change - then have it ask whether it can make those changes or allow me to iterate and request updates to the proposed wording.  This way we could iterate on a the wording changes before the edits take place.
So with ask2edit files, the idea is that the file shouldn't be updated during normal operations to avoid it accidentally being modified during the development cycle when it was meant purely as a reference but when the LLM is asked to perform an explicit operation on that file, draft wording and present it for approval or dialog.

Thank you for filing this issue.
You can add all files you need as read-only with /read first and then move select ones to a writable state /add.

That is a possible work around but not quite what I'm envisioning.  I'll sleep on it and see if I can explain it more clearly.


Added Entity Masker

Plugin made to mask out specific entities in Runescape while still keeping them clickable.
Having the ability to mask out specific entities is something I've read a few requests for.
Currently it has a default list for epilepsy and a few common phobia's but you can also make your own.
I'm no expert in the field so feedback on the concept as well as the actual code is always highly appreciated!

Don't forget to unregister your overlay using overlaymanager and npcoverlayservice.
Also probably resize your jad image to be smaller and re-encode your secretImage.


Update Autocomplete to fix namespace bug

Update The file with backslash before InvalidArgumentException so php can find this class.
The current namespace doesn't hold this class

Thanks =)


New version: KnuthBendix v0.3.3

Registering package: KnuthBendix
Repository: https://github.com/kalmarek/KnuthBendix.jl
Created by: @kalmarek
Version: v0.3.3
Commit: 6476dec730e4475a916fa637ab62affbd2179eec
Reviewed by: @kalmarek
Reference: https://github.com/kalmarek/KnuthBendix.jl/commit/6476dec730e4475a916fa637ab62affbd2179eec#commitcomment-81369617
Description: Pure Julia implementation of the Knuth-Bendix completion (focused primarily on groups and monoids)

superseded by https://github.com/JuliaRegistries/General/pull/66387


HOTFIX: Close transactional producers in all new tests

cc @hachikuji @ijuma

I don't see any of the garbage in the test output, so it looks like this fixed the problem.


spdk: add vfio-user

For some reason when adding --with-vfio-user
RPM build is not working any more
So changing this to regular build instead
Also note: --without-shared
Signed-off-by: Boris Glimcher<EMAIL_ADDRESS>

moved to https://github.com/opiproject/opi-spdk-bridge/pull/6


Click & drag menu items should just work

In a native menu, if you start dragging from a menu item on top of another one, the latter one will execute. The current implementation executes neither.

dupe of #52907


initFilterMultipleTables filter type select/chosen + multiple selectboxes

Hi,
is there posibility to have multiple selectboxes for initFilterMultipleTables? My idea is to have multiple tables, with same number and type of columns, but to have single filter to filter them. (one filter for one column in each table)

You want multi select input for multiple tables? Asking because you mentioned it in issue title but havent done so in your posted code sample. ..

yes, that is correct :)

Massive enhancement to the initMultipleTables , now it also read the columns data automatically and place it into select element options still need to add multi select for this one, please test it and see how it behaves for you

thank you very much, im trying it right now, but one question. Will it create filter for each column, or one filter for all columns? (as filter i now think option element)

i made a bit tests and woooow it seems like it works. thank you very much, +5 internets for you :)
only one problem i found, but manage to solve it.
when i try to initialize it like this
    yadcf.initMultipleTables(subTablesList,[{column_number: [1], filter_container_id:'multiFilterContainer_1', filter_type: 'select', column_data_type: 'rendered_html'},
                                            {column_number: [2], filter_container_id:'multiFilterContainer_2', filter_type: 'select', column_data_type: 'rendered_html'},
                                            {column_number: [3], filter_container_id:'multiFilterContainer_3', filter_type: 'select', column_data_type: 'rendered_html'},
                                            {column_number: [4], filter_container_id:'multiFilterContainer_4', filter_type: 'select', column_data_type: 'rendered_html'},
                                            {column_number: [5], filter_container_id:'multiFilterContainer_5', filter_type: 'select', column_data_type: 'rendered_html'},
                                            {column_number: [6], filter_container_id:'multiFilterContainer_6', filter_type: 'select', column_data_type: 'rendered_html'},
                                            {column_number: [7], filter_container_id:'multiFilterContainer_7', filter_type: 'select', column_data_type: 'rendered_html'},
                            ])

there is issue with tablesSelector variable, which isnt empty for next filter processing on line 2660
(so i added line tablesSelectors = '' before loop)
tablesSelectors = ''
			for (i = 0; i < tablesArray.length; i++) {
				//tablesSelectors += tablesArray[i].settings()[0].oInstance.selector + ',';
                                tablesSelectors += '#' + tablesArray[i][0].id + ',';
			}

and also there is minor problem, that my datatables dont have .oInstance.selector, but it may be only my issue

another question, is there implemented saveState for multiple filters multiple columns?

Will take a closer look at  the bugs you found and the tweeks you did for your scenario in a few days (hopefully) regarding state saving - since its not a standard filtering and nut supported directly by datatables probably I will  have to write some additional code for that... open a nee issue for that. But know that I don't know when I will have the time for that since there are other open issues

about filtering i was just asking. im now trying to make that running. And about datatables, they remember state, only filters stay empty.

Please grab the new 0.8.7.beta.8 version and update me on what am I still missing in my implementation, latest version don't rely on table selector and the filtering was also improved
Also added a showcase page http://yadcf-showcase.appspot.com/dom_multi_columns_tables_1.10.html

HI vedmack, sorry for my delay, but im totaly bussy with exams now. But will reply test and reply ASAP

Im looking for 0.8.7.beta.8 but found only 0.8.7. Is it still availible?

Its not a beta anymore... 0.8.7 is the final form of that version... (0.8.7

0.8.7.beta.XXX) :)

On Tue, Feb 24, 2015 at 1:05 PM, Muhahe<EMAIL_ADDRESS>wrote:

Im looking for 0.8.7.beta.8 but found only 0.8.7. Is it still availible?
—
Reply to this email directly or view it on GitHub
https://github.com/vedmack/yadcf/issues/132#issuecomment-75737452.

okay sorry :) i will test it now

So i test it and i miss suport for chosen multiselect and for save state. Or am i missing some initialization?

Only the fact that this issue is still open and the other issue https://github.com/vedmack/yadcf/issues/143 is still open too :) I still haven't finish those two, my last commits on this feature were 1) don't rely on table selector 2) improve filtering mechanism

okay thanks :) my bad. this seems it works fine to me (just made a some minor changes because of my issue somewhere)

Done in 0.8.8.beta.10, see in action and scroll down to see code snippet


=> vs. |> precedence

While porting over cli.civet to more Civet notation, I noticed the following:
version := => import("../package.json") |> await |> .version
↓↓↓
const version = (await () => import("../package.json")).version

I expected to instead get:
const version = async () => (await import("../package.json")).version

Any opinions on which is correct? Should => or |> have higher precedence?

I'm not sure, maybe we could collect some more examples and see what other languages do in a similar situation.

By the way, the workaround for now is to add an indentation:
version := =>
  import("../package.json") |> await |> .version

(And this may be evidence for why it should be interpreted this way.)

More evidence: version := -> import("../package.json") |> await |> .version parses like I expected, not how => parses.
I think the current parse is a consequence of the => expr rule (where we don't need a braced block), and is a bug; it should match ->.


transpose_rhs argument in matmul

What is the reason for having the transpose_rhs in the matmul signature? Is it to somehow aide the compiler to fuse the transpose? But it seems then we take the transpose (rhs.T) and do the matmul anyway. Can't we have the user do the transpose on the outside?
Should we remove this argument? Unless we have a good reason to keep it, I think it should be removed. Let's not complicate the signature.
If we need to keep it, its default value should be False, to match the signature of torch's matmul in the default case.

@stellaraccident, what do you think?

Almost all matmuls in any modern ml model are the transpose_rhs form, and frankly, I got tired of having the baseline thing be strangely transposed. I shouldn't have called this "matmul" though.
There are many kernels, especially on the inference side, that are only defined for transpose_rhs, and it is useful to be able to specialize those without relying on fusion heuristics -- I'd go so far as to say that the absence of this one thing is a key factor in why torch isn't very good for inference out of the box.
So, if I had to choose one, I would ignore defining specializations for plain matmul, as it rarely shows up on its own.

I've since added the linear op: https://github.com/nod-ai/sharktank/blob/b5d9add33bb6b594039fed043e8bb90d5a928007/sharktank/sharktank/ops/signatures.py#L202
And was thinking of migrating all of the transpose_b matmul stuff to that, then switching the default or dropping the flag.

I can migrate to the linear op. For matmul I will retain the flag but change its default.
I would also like to add the transpose method to the signatures. I want it for the sharded tensors. Maybe add the T property to the InferenceTensor to match torch and make model porting easier.

Done with #60.


Option to choose if to show file extensions or not

As the Win32 File Explorer does

this is required!!

Indeed, the ability to see file extention goes with the ability to change it.

Thank you for reporting this issue.

@SOI7 This is now fixed in the develop branch.

This should be fixed with the v0.7.2 release, which is currently in certification in the Microsoft Store.


Default Token Lifetimes?

If a tenant is not using Conditional Access, what are the default token lifetimes including MFA?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9561a367-20d8-62e9-57e5-694bab4c0878
Version Independent ID: a7c757e0-052b-fc42-70c5-030081baa573
Content: Configure authentication session management - Azure Active Directory
Content Source: articles/active-directory/conditional-access/howto-conditional-access-session-lifetime.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@Weychris
Thanks for your feedback! We will investigate and update as appropriate.

Closing this out as a duplicate of https://github.com/MicrosoftDocs/azure-docs/issues/55757


Refactor workflow

baseline for new workflow

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


python311Packages.pysmartthings: 0.7.7 -> 0.7.8

Diff: https://github.com/andrewsayre/pysmartthings/compare/0.7.7...0.7.8
Changelog: https://github.com/andrewsayre/pysmartthings/releases/tag/0.7.8
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 243117 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.smartthings
python310Packages.pysmartthings
python310Packages.pysmartthings.dist
python311Packages.pysmartthings
python311Packages.pysmartthings.dist

Result of nixpkgs-review pr 243117 run on aarch64-darwin 1

4 packages built:

python310Packages.pysmartthings
python310Packages.pysmartthings.dist
python311Packages.pysmartthings
python311Packages.pysmartthings.dist

Result of nixpkgs-review pr 243117 run on aarch64-linux 1

5 packages built:

home-assistant-component-tests.smartthings
python310Packages.pysmartthings
python310Packages.pysmartthings.dist
python311Packages.pysmartthings
python311Packages.pysmartthings.dist


Make HttpContextAccessor static AsyncLocal

#723 The .NET 4.5.1 version is static but the .NETStandard1.3 version isn't, which can cause problems if you end up with different instances of HttpContextAccessor.

@dotnetjunkie

Part of me doesn't like this change. The http context accessor should be a singleton, newing it up now shares the async local state with all other instances.
@dotnetjunkie Remind me how you ran into this.

@davidfowl, try not to act purely on feelings. That typically not works out well :)
Here's a simple way to reproduce the issue:
services.AddTransient<IHttpContextAccessor, HttpContextAccessor>();

The inconsistency is an issue but I'd rather make .NET Framework act like .NET Core than vice versa. Adding a transient IHttpContextAccessor is just broken.

Yes, making that component transient is clearly broken, but by no way does the framework guide developers into the right direction.
It is really easy for a user to do the wrong thing, while it is really hard for the user to track down the bug that is the result of this. I already shown two completely different scenarios (both in the previous comment and in #723) that can cause bugs.

Agreed but that can be solved in other ways. I'm just of the opinion this is the wrong fix for this particular problem. There are been some huge improvements made to the allocation profile to async locals in .NET Core vnext so maybe it's time to turn this back on by default again and measure. Also dropping .NET 4.5.1 (and rebasing to .NET Framework 4.6) support would let us use async local on both .NET Core and .NET Framework.
That solves both the lifetime issue and saves the implementation from hard coding statics.

The only actual fix here is to make the AsyncLocal field static, because it's very easy for a user to accidentally create a second instance of the HttpContextAccessor as explained in #723.

The only actual fix here is to make the AsyncLocal field static, because it's very easy for a user to accidentally create a second instance of the HttpContextAccessor as explained in #723.

I'm not convinced that would be common if we were able to add this service back to hosting by default.

I'm not convinced that would be common if we were able to add this service back to hosting by default.

Wait. What? You are considering registering it by default? Is that what you're saying? I thought the registration was omitted by default because of performance considerations. Can you elaborate on that?

I mentioned it here https://github.com/aspnet/HttpAbstractions/pull/753#issuecomment-271504778

As a data point, we have many uses of AsyncLocal and most of them are static.
https://github.com/search?q=org%3Aaspnet+AsyncLocal&type=Code
@davidfowl how much of your concern applies to these other cases?


Why is ARC putting all headers in lower case?

I've been using ARC for about a year. there was an update to in a couple of weeks ago and i noticed that i could not log in any more to our webapi. did a little checking a figured out that the headers are being put into lower case which is why it stopped working. Is there  a way to turn this off? and why did you guy or guys (what ever) change this?

This is duplicate of #491


Rethink the focus mode

UX test summary:

Two separate 'focus modes' is confusing. The user doesn't understand when the focus is at the input field and when he can navigate the overlay days with arrow keys
Today and cancel buttons can't be used without a mouse (tab closes the overlay)
Closing the dropdown (without selecting a date) was expected to cancel, instead it selects the highlighted value.

Perhaps we should not support navigating the input at all when the overlay is open.
The current “proto-pre-beta” branch does the following (related to these issues):

When the input is empty, we wait for the user to either press an arrow key or to start typing in the input. If the user presses arrow keys, we navigate the calendar (focus is in the overlay). If the user starts typing, left and right arrow keys navigate the input (focus is in the input).
Today and Cancel buttons are focusable with they keyboard (tabindex=0)

Let's start off by making it visually explicit where the focus lies currently. Blur the input field when keyboard is used to navigate the overlay. And "blur" the overlay when input is focused.
After that we can start think of ways of improving how the focus is moved between input and the overlay.

The final prototype is in https://github.com/vaadin/vaadin-date-picker/commits/pro-overlay-focus , It contains some patches from https://github.com/vaadin/vaadin-date-picker/commits/proto-pre-beta .

UX testing feedback: https://docs.google.com/document/d/1uO1NlZETV6hQbjv-x0X7oLHDgS-5iifnzYPpAOL1Jnw/edit#


[add-resource] New Plugin

I would like to add my new plugin/theme to the Grav Repository.
Here are the project details: https://github.com/Ralla/grav-plugin-dotenv

I'll add this soon.  Thanks!

Should show on GPM soon.


Big Endian CPU issues

Although most things are working properly, some issues have been found when testing on MIPS hardware (tested on EdgeRouter Lite, Octeon+ MIPS 64r2 CPU):

LZW encoding is not working properly.
Locale case conversion not passing the test (this may be a false positive, as the test assume that machine has compliant locales -with the exception of Turkish mode, which requires special handlng-).

Locale conversion problems were because on EdgeOS 1.6 (EdgeRouter Lite) there is no Unicode support, so local OS case conversion used for the test were not working (the Unicode support in libsrt is working properly, as it requires no OS support for it).
LZW/RLE encoding is not working properly on big endian CPUs: confirmed (easy to fix).

Fixed. There were two bugs: 1) proper endianess detection for the big endian case, 2) S_LD_U32 macro was wrong (using logical or instead of arithmetic).

Fix hash: a9c8c170b195b7d2f9fdf56ce796dd6d717706c8


Use React Hooks and yup validation more consistently across the app

Description
Many of the forms in our app use different types of validation. We should be more consistent in our use of React hooks and yup to validate forms.
Related: #2269

Related: #2267


Updated swift-tools to version 5.0

This Pull request makes SwiftyJSON compatible with Swift 5.0
Swift 5.0 enforces the use of swift-tools > 4.0
To make the code comply, it has to be restructured in a few ways.

Package.json has to have more information
targets have to be named explicitly and a Folder has to exist for each target.

Also, since the file structure is changed, I had to change how the Tests.json File is imported during Unit Tests

Any chance to get it merged? It seems the project stopped months ago but I hope not, it’s really great!


Not recognizing tests written in groovy

The test classes in src/androidTest/java directory will be picked up by default. However, the groovy source files in src/androidTest/groovy directory are not compiled. Reading the source code of the plugin I would expect it to work.
See https://github.com/zhihan/groovyandroid for an example.

I just want to report some of my further investigation. The Groovy files in the "src/androidTest/grovvy" directory was compiled and generated to the right place. However, the task to generate test-classes for JAVA is called compileTestDebugJava instead of compileDebugTestJava (compared to 'compileDebugTestGroovy' in the plugin).

Your test is using robolectric. The androidTest folder is for Android unit tests.

I don't think that is the issue. The Robolectric tests written in JAVA in the same directory works fine. BTW I have also tried to put the unit tests in src/test/groovy directory, adding sourcesets specifying the directory, and replacing Robolectric with the testing framework provided by android sdk with no success.
BTW, could you also explain what is the difference between "Android unit tests" and Robolectric, a unit testing framework written for Android?

Robolectric is  bunch of stubs written so that you can run unit tests on the JVM. Android unit tests are actually run on the device. I'm guessing that if you want to run robolectric you will need to load groovy-all instead of grooid and use the groovy plugin.

Thanks. I think the issue is that the groovy-android plugin does not work with the Robolectric plugin. It was the Robolectric plugin that performs the tasks of unit testing, not the android plugin from android sdk.     Feel free to close this issue if you want. It is more of a feature request than bug.

It's been a while since I've used Robolectric, but if you want to use groovy with it I would recommend looking into Robospock.

@zhihan Please see this repository using the latest snapshot: https://github.com/morgotth/AndroidJavaAlternatives. There is no reason your tests should not pass.


How to specify proper agentId for applications running with docker and managedby k8s?

You know there are more and more such applications:

Running in a docker container
K8s manages and might dispatch them anywhere & anytime

So we may want to know:
How to respectively set proper agentId for different instances of certain application, otherwise one application's all instance will have the same agentId!

PP's server-side applications, including web and collector, both run natively on Linux and are not releated with docker, ONLY pp's agents run within a docker container.

@Xylus Thanks a lot, v1.6.2 is my pp server's version, would be so kind as to explain how to configure it in detail for the agent application?

@fengnex
Please bear in mind that I can't (and shouldn't) tell you how you should set your agent ids as this is something that you will have to decide.
All I can do is simply give some ideas as to how you might be able to configure your agent ids so that they don't produce duplicates.
One of them could be to take a look at the downward API, and choose some values to expose as environment variables. Then you can use those env variable to configure the agent id.

I also interested in this topic as i didn't found solution for multiple replicas where you configure only single deployment. Issue that i have is https://github.com/naver/pinpoint/issues/3504

I was trying to use pod name or pod id but the value is too long.

@dawidmalina thx, and could you please introduce how you set different agentIds for different instances respectively?
I wonder if it is really necessary to manually set the ID for user,  and why the value cannot be generated automatically? Can anyone explain it?

I did it via downward API but the problem is that in my case pod name or pod id are too long and agent will not start because of agent id limit. It's working with replicas: 1 and short name provided manually.

Could you do something like this to have different replicas have different agent id?
# if HOSTNAME or pod name(?) is "my-web-service-6cd47d4f78-sn2w9"

AGENT_ID_PREFIX="my-web"
AGENT_ID_SUFFIX="$(echo $HOSTNAME | rev | cut -d'-' -f-2 | rev)"
AGENT_ID="$AGENT_ID_PREFIX-$AGENT_ID_SUFFIX"

# AGENT_ID would then be "my-web-6cd47d4f78-sn2w9"

Though with the 24 character limit, AGENT_ID_PREFIX would be limited to 7 characters.
I don't know the exact spec for how the pod name(?) is generated, but if you feel like you can get away with just using -sn2w9 then AGENT_ID_PREFIX could be longer - my-web-service-sn2w9.

You know there are more and more such applications:

Running in a docker container
K8s manages and might dispatch them anywhere & anytime

So we may want to know:
How to respectively set proper agentId for different instances of certain application, otherwise one application's all instance will have the same agentId!

兄弟这个问题解决了么

解决了，但是是临时的 哈哈！ 我用传参的方式搞定的，例如把生成agentid的脚本和主命令写进shell里面用copy到镜像里  用entrypoint启动  shell脚本里面定义几个参数 $1 $2 等等  用k8s的command传参

@xiaofeng886521 @dawidmalina @fengnex
Would there be a fixed spec for pod names/ids? As in a guarantee that they'll be at most certain number of characters in length?
What we could do temporarily would be to increase the current limit of 24 characters for agent ids to something that could work with kubernetes.
Let me know what you all think.

From my side we can use id of the pod which for sure is unique. It is UUID string so we need 36 characters.

我用传参的方式搞定的，例如把生成agentid的脚本和主命令写进shell里面用到复制到使用里点entrypoint启动shell脚本里面定义几个参数$ 1 $ 2等等用k8s的命令传参

多个pod时，可以选择取值pod的hostname。
我想问兄弟，你是怎么在k8s里部署起来的server端。


A way to make OnlyOffice default for links instead of download

Would like docs xlsx and pptx to open in OnlyOffice by default when clicking on the file name link in Owncloud (just like OpenOffice community)

Great idea, I agree...


Fix opening line on task list pattern page

We forgot to update this line when renaming the page... 🤦

@colinrotherham @stevenjmesser we spotted this when demoing the page to people in the workshop at Design History Day... 🤦


Do not deepcopy the cache!

Deepcopy'ing the cache is unnecessary and is causing massive performance problems for certain uses cases (specifically, large directories). This change fixes the performance problems.

Looks like PRs should be opened against the dev branch?

Thank you for the suggestion. I agree that the deepcopy operation was unnecessary (on the namespace's cache and other parts).
Your suggested edit, however, still uses deepcopy. I would suggest the following:
                # Do not reuse the namespace object, making an identical copy
                ns = self.add_namespace(Namespace(namespace.prefix, namespace.uri))

and we can also remove the deepcopy import that is no longer required.

@jfennick Merged. Thanks a lot!

No problem! Any chance for a point release soon? We have some users that are currently affected by this.

No promise, but I will try to make a release this weekend.

@jfennick I've made a release. Sorry for the delay.


nixos/exwm: allow custom Emacs load script

Add config option services.xserver.windowManager.exwm.loadScript,
which is passed to Emacs (as the -l option) to load after the user's init file.
Motivation for this change
This allows me to specify that (exwm-enable) should be run on the exwm Emacs instance, without putting it in my general Emacs config.
Things done
Tested on my NixOS box, both with default configuration (leaves everything as it currently is), and with example configuration (adding (exwm-enable)).

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x]  NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

What's the use-case for this?

What's the use-case for this?

It allows some Emacs init code to be conditionally run depending on whether or not Emacs is launched from the command line or as the window manager, without having to make any changes to the init file.
Currently, the only conditional option is whether to enable the default config or not. I don't use the default config, so I've set the load script to just initialise exwm and the rest of the configuration is done in my init file.

I am at the moment struggling to get a system tray running with EXWM on NixOS (any hints/alternatives appreciated).
This PR would solve my problems elegantly, since the EXWM docs say, one should require the exwm-system-tray before exwm itself.
I'd appreciate a merge

@stale, I don't see a reason why this PR does not get attention. Defaults are not changed and at the moment, the system is just not flexible enough.

@Stale, I don't see a reason why this PR does not get attention. Defaults are not changed and at the moment, the system is just not flexible enough.

@moritzschaefer Thanks for pinging this again; I'd also like a merge (I'm currently using this commit rebased on top of a local nixpkgs repo). Not sure exactly if there's anything else I need to do, or if there are any maintainers we can ping to get this looked at (I can't see any maintainers listed in the source file).

We can try to ping @jonringer or @SuperSandro2000.

you rang?


Handling lost gpu context on stage3d

Primitive way to handle lost context. Keeps texture data in memory when created via createTextureFromImage. Custom made textures need to listen on hasGPU and recreate manually.
usage - add compiler flag:
-D stage3d_handle_context_loss
Notes:

Increases memory usage. If that is a problem it should be possible to reload the data from source, I didn't need it though and it would be more complicated. @purplepwny has implemented embedded assets with flash preloader, which I improved for my needs. There it would make more sense to load from source (since it's embedded).
For some reason my builds sometimes fail with flambe.platform.BasicTexture.R has no field readPixels/writePixels/createTexture. If I remove @:generic from BasicTexture it works. It also works if I return back again after it compiled first time. Not sure what is going on.
Fixes #217

Hey guys, did it work for anyone?
I'm having some trouble with context lost after showing the users a video commercial


Can't combine Static Web App settings from portal and bicep template

Describe the bug
When I deploy Static Web App app settings using bicep, it overwrite the ones that were assigned through the Azure Portal. I tried fixing this by retrieving the current app settings and then combining those with the new ones, as I have done many times for Function Apps, but it doesn't seem to work for Static Web Apps.
To Reproduce
main.bicep
targetScope = 'subscription'

param resourceGroupName string
param resourceGroupLocation string
param staticWebAppName string
param staticWebAppCdnLocation string
param staticWebAppSku string
param applicationInsightsName string
param logAnalyticsWorkspaceName string
param tags object = {}

resource resourceGroup 'Microsoft.Resources/resourceGroups@2022-09-01' = {
  name: resourceGroupName
  location: resourceGroupLocation
  tags: tags
}

module resources 'modules/resources.bicep' = {
  name: 'resource-deployment'
  scope: resourceGroup
  params: {
    staticWebAppName: staticWebAppName
    staticWebAppCdnLocation: staticWebAppCdnLocation
    staticWebAppSku: staticWebAppSku
    logAnalyticsWorkspaceName: logAnalyticsWorkspaceName
    applicationInsightsName: applicationInsightsName
    tags: tags
  }
}

resources.bicep
param staticWebAppName string
param staticWebAppCdnLocation string
param staticWebAppSku string
param applicationInsightsName string
param applicationInsightsLocation string = resourceGroup().location
param tags object = {}

resource logAnalyticsWorkspace 'Microsoft.OperationalInsights/workspaces@2022-10-01' = {
  name: logAnalyticsWorkspaceName
  location: logAnalyticsWorkspaceLocation
  properties: any({
    retentionInDays: logAnalyticsWorkspaceRetentionInDays
    sku: {
      name: logAnalyticsWorkspaceSku
    }
  })
  tags: tags
}

resource applicationInsights 'Microsoft.Insights/components@2020-02-02' = {
  name: applicationInsightsName
  location: applicationInsightsLocation
  kind: 'web'
  properties: {
    Application_Type: 'web'
    WorkspaceResourceId: logAnalyticsWorkspace.id
    RetentionInDays: 90
    IngestionMode: 'LogAnalytics'
    publicNetworkAccessForIngestion: 'Enabled'
    publicNetworkAccessForQuery: 'Enabled'
  }
  tags: tags
}

module staticWebAppMod 'staticWebApp.bicep' = {
  name: '${staticWebAppName}-deployment'
  scope: resourceGroup()
  params: {
    name: staticWebAppName
    cdnLocation: staticWebAppCdnLocation
    sku: staticWebAppSku
    applicationInsightsId: applicationInsights.id
    applicationInsightsInstrumentationKey: applicationInsights.properties.InstrumentationKey
    applicationInsightsConnectionString: applicationInsights.properties.ConnectionString
    tags: tags
  }
}

staticWebApp.bicep
param name string
param cdnLocation string
param sku string
param applicationInsightsId string
param applicationInsightsInstrumentationKey string
param applicationInsightsConnectionString string
param tags object

var staticWebAppTags = union({
    'hidden-link: /app-insights-resource-id': applicationInsightsId
    'hidden-link: /app-insights-instrumentation-key': applicationInsightsInstrumentationKey
    'hidden-link: /app-insights-conn-string': applicationInsightsConnectionString
  }, tags)

resource staticWebApp 'Microsoft.Web/staticSites@2023-01-01' = {
  name: name
  location: cdnLocation
  sku: {
    name: sku
    size: sku
  }
  properties: {}
  identity: {
    type: 'SystemAssigned'
  }
  tags: staticWebAppTags
}

module staticWebAppSettingsMod 'staticWebAppSettings.bicep' = {
  name: '${name}-appsettings'
  params: {
    staticWebAppName: name
    currentAppSettings: list(resourceId('Microsoft.Web/staticSites/config', name, 'appsettings'), '2023-01-01').properties
    newAppSettings: {
      APPINSIGHTS_INSTRUMENTATIONKEY: applicationInsightsInstrumentationKey
      APPLICATIONINSIGHTS_CONNECTION_STRING: applicationInsightsConnectionString
    }
  }
}

staticWebAppSettings.bicep
param staticWebAppName string
param currentAppSettings object
param newAppSettings object

resource staticWebAppSettings 'Microsoft.Web/staticSites/config@2023-01-01' = {
  name: '${staticWebAppName}/appsettings'
  properties: union(currentAppSettings, newAppSettings)
  kind: 'config'
}

Deployment of main.bicep results in the following error:
ERROR: {"status":"Failed","error":{"code":"DeploymentFailed","target":"/subscriptions/***/providers/Microsoft.Resources/deployments/main","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.","details":[{"code":"ResourceDeploymentFailure","target":"/subscriptions/***/resourceGroups/rg-example-dev/providers/Microsoft.Resources/deployments/resource-deployment","message":"The resource write operation failed to complete successfully, because it reached terminal provisioning state 'Failed'.","details":[{"code":"DeploymentFailed","target":"/subscriptions/***/resourceGroups/rg-example-dev/providers/Microsoft.Resources/deployments/resource-deployment","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.","details":[{"code":"ResourceDeploymentFailure","target":"/subscriptions/***/resourceGroups/rg-example-dev/providers/Microsoft.Resources/deployments/stapp-example-dev-deployment","message":"The resource write operation failed to complete successfully, because it reached terminal provisioning state 'Failed'.","details":[{"code":"DeploymentFailed","target":"/subscriptions/***/resourceGroups/rg-example-dev/providers/Microsoft.Resources/deployments/stapp-example-dev-deployment","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.","details":[{"code":"BadRequest","message":""}]}]}]}]}]}}

Expected behavior
I would expect deployment of main.bicep to combine the app settings that were assigned to the Static Web App through the Azure Portal (if there are any) with the ones specified in staticWebApp.bicep.
Screenshots

Additional context
Here is a working example of how you would do it for a Function App: https://stackoverflow.com/questions/72940236/is-there-a-workaround-to-keep-app-settings-which-not-defined-in-bicep-template/72946083#comment137036530_72946083

I actually asked the same question on stackoverflow and got an answer on how to solve it there. You can find it here: https://stackoverflow.com/questions/77730853/combine-app-settings-from-portal-with-those-defined-in-bicep-template-for-static/77735025#77735025.
I searched all over the docs and couldn't find any info about the existence of the 'listAppSettings' function (and I still can't find it). I would really encourage you to make that kind of stuff more visible to users. It would at least have saved me several hours of debugging.


Save Author relation updates

RelatedManager.add and RelatedManager.remove don't automatically save changes.

:+1: