I got error message like following when I try create .gitignore file for node.

An unexpected error occurred.
{ Error: unable to get local issuer certificate
at TLSSocket. (_tls_wrap.js:1116:38)
at emitNone (events.js:106:13)
at TLSSocket.emit (events.js:208:7)
at TLSSocket._finishInit (_tls_wrap.js:643:8)
at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:473:38) code: 'UNABLE_TO_GET_ISSUER_CERT_LOCALLY' }
If there is any workaround, please let me know. could you explain of process and when use certi?
thanks in advance.

What exact command are you running?

I get the same thing. I have tried running it as:
gitignore -types
npx gitignore -types
Fetching available types...
An unexpected error occurred.
Error: unable to get local issuer certificate
at TLSSocket.onConnectSecure (node:_tls_wrap:1535:34)
at TLSSocket.emit (node:events:513:28)
at TLSSocket._finishInit (node:_tls_wrap:949:8)
at TLSWrap.ssl.onhandshakedone (node:_tls_wrap:730:12) {
code: 'UNABLE_TO_GET_ISSUER_CERT_LOCALLY'
}


Implement simple hydrodynamic journal bearing

Implement simple hydrodynamic journal bearing as described on Friswell's book considering:

the flow is laminar and Reynolds’s equation applies
the bearing is very short, so that L/D << 1, where L is the bearing length and D is the bearing diameter, which means that the pressure gradients are much larger in the axial than in the circumferential direction
the lubricant pressure is zero at the edges of the bearing
the bearing is operating under steady running conditions
the lubricant properties do not vary substantially throughout the oil film
the shaft does not tilt in the bearing

We implemented an analytical and a numerical way to calculate pressure in fluid flow. The results are very close, but we still need to implement a test as well as define a tolerance. This is already a requirement in issue #37 thus I'm closing this issue.


Provide Actual Instructions or Script it

Hello,
Can you provide actual instructions how how get it to look like this? https://github.com/jothi-prasath/SmallSur/raw/master/img/sample2.png

Adjust the Plank settings to customize the dock appearance and behavior.
Configure the XFCE panel to organize and manage the top bar elements.

It isn't clear what needs to be changed.

Adjust the Plank settings to customize the dock appearance and behavior.
Configure the XFCE panel to organize and manage the top bar elements.

Adjust the settings depending upon screen size / aspect ratio / preference

other than that the script itself explains the instructions.

Why doesnt the script make all the required changes then. By just running the script you don't get the advertised desktop, not by a long shot.


fix: Bug 279: Clear the DT cookie when restarting AuthN workflow

Overview
In 1.0.0 the DT (device token) cookie was added, maintaining state on
the 2nd auth factor, between client and server. However, when the Okta
session expires, the old DT was still sent. The Okta server doesn't like
when an old DT, is used with a new session and re-prompts for 2FA with an
web form.
The aws-okta logic doesn't know about this 2FA web form, can't parse it,
and errors our.
We fix this bug, by clearing the DT cookie, whenever we restart the
AuthN workflow. Then the session and device token cookies are always in
sync between the client and server.
Testing
Manually tested:

aws-okta env - with out-of-date Okta session and DT
aws-okta env - with garbage Okta session and out-of-date DT
aws-okta env - with no stored Okta session or DT

https://github.com/segmentio/aws-okta/releases/tag/v1.0.1


Add tf.io.browserIndexedDB

for saving model artifacts to browser IndexedDB and loading them.
Towards: https://github.com/tensorflow/tfjs/issues/13

This change is

Hello all I am e beginner in open source and have a basic knowledge of javascript and want to get started with contributing to this project!Can somebody please help me?I also know a bit of NLP and deep learning.

@arunikayadav42 Great to see you are interested in contributing. Maybe you can take a look at the list of our issues with the "help wanted" tag and see which ones interest you. https://github.com/tensorflow/tfjs/issues?q=is%3Aissue+is%3Aopen+label%3A"help+wanted"

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.

src/io/indexed_db.ts, line 35 at r2 (raw file):

  return new Promise<void>((resolve, reject) => {
    const deleteRequest = idbFactory.deleteDatabase(DATABASE_NAME);
    deleteRequest.onsuccess = () => {

simplify these:
deleteRequest.onsuccess = () => resolve();

src/io/indexed_db.ts, line 45 at r2 (raw file):

function getIndexedDBFactory(): IDBFactory {
  if (typeof window === 'undefined') {

Can you add an environment flag for the environment? Maybe called "IS_NODE" so we don't have these checks sprinkled everywhere?
Add in 3 places:
https://github.com/tensorflow/tfjs-core/blob/master/src/environment.ts#L30
https://github.com/tensorflow/tfjs-core/blob/master/src/environment.ts#L53
https://github.com/tensorflow/tfjs-core/blob/master/src/environment.ts#L324

src/io/indexed_db.ts, line 55 at r2 (raw file):

  // tslint:disable-next-line:no-any
  const theWindow: any = window;
  return theWindow.indexedDB || theWindow.mozIndexedDB ||

not all browsers support this, should we throw if it's null?

src/io/indexed_db.ts, line 83 at r2 (raw file):

    return new Promise<SaveResult>((resolve, reject) => {
      const modelArtifactsInfo: ModelArtifactsInfo = {

this seems to be pretty common -- maybe pull out into a util.

src/io/indexed_db.ts, line 96 at r2 (raw file):

      // Create the schema.
      openRequest.onupgradeneeded = () => {

openRequest.onupgradeneeded = () => this.setUpDatabase(openRequest);

src/io/indexed_db.ts, line 113 at r2 (raw file):

          reject(putRequest.error);
        };
        tx.oncomplete = () => {

tx.oncomplete = () => db.close();
follow this convention elsewhere where you can as well, you dont need the {} for single-line body callbacks.

src/io/indexed_db.ts, line 127 at r2 (raw file):

      const openRequest = this.indexedDB.open(DATABASE_NAME, DATABASE_VERSION);

      openRequest.onupgradeneeded = () => {

openRequest.onupgradeneeded = () => this.setUpDatabase(openRequest);

src/io/indexed_db.ts, line 138 at r2 (raw file):

        const getRequest = store.get(this.modelPath);
        getRequest.onsuccess = () => {
          if (getRequest.result === undefined) {

double equals null

src/io/indexed_db.ts, line 149 at r2 (raw file):

          reject(getRequest.error);
        };
        tx.oncomplete = () => {

tx.oncomplete = () => db.close();

src/io/indexed_db.ts, line 153 at r2 (raw file):

        };
      };
      openRequest.onerror = (error) => {

openRequest.onerror = error => reject(openRequest.error);

src/io/indexed_db.ts, line 166 at r2 (raw file):

/**
 * Factory function for browser IndexedDB IOHandler.

Same comment here: "Creates a browser IndexedDB IOHandler for saving models."

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 11 unresolved discussions.

src/io/indexed_db.ts, line 59 at r2 (raw file):

      theWindow.shimIndexedDB;
}

Please add something analogous to the local_storage comment here.
/**

IOHandler subclass: Browser IndexedDB.

See the doc string to browserIndexedDB for more details.
*/

src/io/indexed_db.ts, line 161 at r2 (raw file):

 db.createObjectStore(OBJECT_STORE_NAME, {keyPath: 'modelPath'});

This method can fail.  It seems it's ok if it fails because the objectStore already exists, but some of the other reasons should maybe be caught?
https://developer.mozilla.org/en-US/docs/Web/API/IDBDatabase/createObjectStores

Comments from Reviewable

Review status: 0 of 6 files reviewed at latest revision, 13 unresolved discussions.

src/io/indexed_db.ts, line 35 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
simplify these:
deleteRequest.onsuccess = () => resolve();

Done.

src/io/indexed_db.ts, line 45 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
Can you add an environment flag for the environment? Maybe called "IS_NODE" so we don't have these checks sprinkled everywhere?
Add in 3 places:
https://github.com/tensorflow/tfjs-core/blob/master/src/environment.ts#L30
https://github.com/tensorflow/tfjs-core/blob/master/src/environment.ts#L53
https://github.com/tensorflow/tfjs-core/blob/master/src/environment.ts#L324

I don't feel I'm familiar with environment.ts enough to be able to do it correctly. But I agree we should  deduplicate and centralize these checks. I added a TODO item to get that done in a later PR, maybe with your help. Let me know whether that's okay.

src/io/indexed_db.ts, line 55 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
not all browsers support this, should we throw if it's null?

Good point. Done.

src/io/indexed_db.ts, line 59 at r2 (raw file):
Previously, bileschi (Stanley Bileschi) wrote…
Please add something analogous to the local_storage comment here.
/**

IOHandler subclass: Browser IndexedDB.

See the doc string to browserIndexedDB for more details.
*/

Done.

src/io/indexed_db.ts, line 83 at r2 (raw file):

common
Good point. Done.

src/io/indexed_db.ts, line 96 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
openRequest.onupgradeneeded = () => this.setUpDatabase(openRequest);

Done.

src/io/indexed_db.ts, line 113 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
tx.oncomplete = () => db.close();
follow this convention elsewhere where you can as well, you dont need the {} for single-line body callbacks.

Done. Simplified all places like this in this file.

src/io/indexed_db.ts, line 127 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
openRequest.onupgradeneeded = () => this.setUpDatabase(openRequest);

Done.

src/io/indexed_db.ts, line 138 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
double equals null

Done.

src/io/indexed_db.ts, line 149 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
tx.oncomplete = () => db.close();

Done.

src/io/indexed_db.ts, line 153 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
openRequest.onerror = error => reject(openRequest.error);

Done.

src/io/indexed_db.ts, line 161 at r2 (raw file):

fail

If this method fails, it should throw an error and the error will surface in the BrowserIndexedDB.save and .load calls.

src/io/indexed_db.ts, line 166 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
Same comment here: "Creates a browser IndexedDB IOHandler for saving models."

Done. Added the word "loading" as the returned IOHandler also supports loading.

Comments from Reviewable

Review status: 0 of 6 files reviewed at latest revision, 13 unresolved discussions.

src/io/indexed_db.ts, line 153 at r2 (raw file):
Previously, caisq (Shanqing Cai) wrote…
Done.

still has braces

src/io/indexed_db.ts, line 75 at r3 (raw file):

!modelPath

!modelPath also check modelPath === null

src/io/indexed_db.ts, line 94 at r3 (raw file):

          getModelArtifactsInfoForKerasJSON(modelArtifacts);

      const openRequest = this.indexedDB.open(DATABASE_NAME, DATABASE_VERSION);

the database code for save and load method are quite similar, maybe better to refactor to a wrapper class that
takes in transaction type and onsuccess function.

src/io/indexed_db.ts, line 122 at r3 (raw file):

readwrite

will read be enough?

src/io/indexed_db.ts, line 127 at r3 (raw file):

        const getRequest = store.get(this.modelPath);
        getRequest.onsuccess = () => {
          if (getRequest.result == null) {

use ===

src/io/indexed_db_test.ts, line 135 at r3 (raw file):

async

since you are using done, is the async still needed?

Comments from Reviewable

Review status: 0 of 6 files reviewed at latest revision, 18 unresolved discussions.

src/io/indexed_db.ts, line 153 at r2 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
still has braces

Done.

src/io/indexed_db.ts, line 94 at r3 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
the database code for save and load method are quite similar, maybe better to refactor to a wrapper class that
takes in transaction type and onsuccess function.

Done. Thanks for the suggestion.

src/io/indexed_db.ts, line 127 at r3 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
use ===

Done. Using === undefined.

src/io/indexed_db_test.ts, line 135 at r3 (raw file):
Previously, pyu10055 (Ping Yu) wrote…

async

since you are using done, is the async still needed?

Good point. async is no longer needed in these tests. Removed them.

Comments from Reviewable

Reviewed 4 of 5 files at r3, 2 of 2 files at r4.
Review status: all files reviewed at latest revision, 18 unresolved discussions, some commit checks failed.

src/io/indexed_db.ts, line 29 at r4 (raw file):

tensorfowjs

typo

Comments from Reviewable

Review status: 5 of 6 files reviewed at latest revision, 19 unresolved discussions, some commit checks failed.

src/io/indexed_db.ts, line 29 at r4 (raw file):
Previously, davidsoergel (David Soergel) wrote…

tensorfowjs

typo

Done.

Comments from Reviewable

 Nice work! Sorry for delay - things are a little busy. Left a few comments but nothing blocking, thus LGTM

Review status: 5 of 6 files reviewed at latest revision, 19 unresolved discussions.

src/io/browser_files.ts, line 39 at r4 (raw file):

  constructor(fileNamePrefix?: string) {
    // TODO(cais): Use central environment flag when it's available.

todo's are easy to forget about. better to file an issue and link to it: e.g. TODO(https://github.com/tensorflow/tfjs/issues/999): .../

src/io/indexed_db.ts, line 59 at r2 (raw file):
Previously, caisq (Shanqing Cai) wrote…
Done.

Since we are not going to expose this class, I think there is no need for the jsdoc, because it's another thing to keep in sync if we rename things.
Also BrowserIndexedDB implements IOHandler is self-documenting and the jsdoc just repeats that.

src/io/indexed_db.ts, line 21 at r5 (raw file):

import {getModelArtifactsInfoForKerasJSON} from './io_utils';
import {IOHandler, ModelArtifacts, ModelArtifactsInfo, SaveResult} from './types';

remove extra newline

src/io/indexed_db.ts, line 44 at r5 (raw file):

  // TODO(cais): Use central environment flag when it's available.
  if (typeof window === 'undefined') {
    // TODO(cais): Add more info about what IOHandler subtypes are available.

remove todo and file an issue. this way we open the door to discussion and potential contributors that can tackle this problem.

src/io/indexed_db.ts, line 120 at r5 (raw file):

      openRequest.onsuccess = () => {
        const db = openRequest.result as IDBDatabase;

double checking IDBDatabase and IDBFactory are built-in types right?

src/io/indexed_db.ts, line 178 at r5 (raw file):

 *   which can be used with, e.g., `tf.Model.save`.
 */
export function browserIndexedDB(modelPath: string): BrowserIndexedDB {

since there are no special methods on specific IOHandlers (by design), let's return IOHandler here instead of BrowserIndexedDB and update @returns to just say it returns an IOHandler that stores data in IndexedDB and it should be used with tf.Model.save.

src/io/indexed_db_test.ts, line 25 at r5 (raw file):

import {deleteDatabase} from './indexed_db';

describe('IndexedDB', () => {

describeWithFlags('IndexedDB', CPU_ENVS, () => { ...} to constraint it to run only on cpu, otherwise this test will fail on node environment, Also no need to run this explicitly on webgl either. We will need to fix the other tests (e.g. localStorage) to also run only on cpu. See https://github.com/tensorflow/tfjs/issues/279

src/io/local_storage.ts, line 38 at r5 (raw file):

export function purgeLocalStorageArtifacts(): string[] {
  // TODO(cais): Use central environment flag when it's available.
  if (!(window && window.localStorage)) {

typeof window === 'undefined'

Comments from Reviewable

Review status: 5 of 6 files reviewed at latest revision, 25 unresolved discussions, all commit checks successful.

src/io/indexed_db.ts, line 45 at r2 (raw file):
Previously, caisq (Shanqing Cai) wrote…
I don't feel I'm familiar with environment.ts enough to be able to do it correctly. But I agree we should  deduplicate and centralize these checks. I added a TODO item to get that done in a later PR, maybe with your help. Let me know whether that's okay.

Sounds good!

src/io/indexed_db.ts, line 138 at r2 (raw file):
Previously, caisq (Shanqing Cai) wrote…
Done.

I still see triple equals undefined. Prefer double equals null.

src/io/indexed_db.ts, line 127 at r3 (raw file):
Previously, caisq (Shanqing Cai) wrote…
Done. Using === undefined.

You shouldn't be using === undefined here (see comment above).

Comments from Reviewable

Review status: 5 of 6 files reviewed at latest revision, 25 unresolved discussions, some commit checks failed.

src/io/indexed_db.ts, line 59 at r2 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
Since we are not going to expose this class, I think there is no need for the jsdoc, because it's another thing to keep in sync if we rename things.
Also BrowserIndexedDB implements IOHandler is self-documenting and the jsdoc just repeats that.

It doesn't hurt to have the doc string here.

src/io/indexed_db.ts, line 75 at r3 (raw file):
Previously, pyu10055 (Ping Yu) wrote…

!modelPath

!modelPath also check modelPath === null

=== null is covered in == null

src/io/indexed_db.ts, line 122 at r3 (raw file):
Previously, pyu10055 (Ping Yu) wrote…

readwrite

will read be enough?

Using more restrictive permissions in the new helper function (databaseAction).

src/io/indexed_db.ts, line 127 at r3 (raw file):

=== undefined

OK. Sorry about the back and forth. I agree with Nikhil that == null is better here, because in the lines below we are going to access the modelTopologhy field of getRequest.result`.

src/io/indexed_db.ts, line 21 at r5 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
remove extra newline

Done.

src/io/indexed_db.ts, line 44 at r5 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
remove todo and file an issue. this way we open the door to discussion and potential contributors that can tackle this problem.

Filed. https://github.com/tensorflow/tfjs/issues/282
I'll keep the TODO item here just so it's easy to understand what the issues is talking about.

src/io/indexed_db.ts, line 120 at r5 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
double checking IDBDatabase and IDBFactory are built-in types right?

They seem to be built-in types for TypeScript.

src/io/indexed_db.ts, line 178 at r5 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
since there are no special methods on specific IOHandlers (by design), let's return IOHandler here instead of BrowserIndexedDB and update @returns to just say it returns an IOHandler that stores data in IndexedDB and it should be used with tf.Model.save.

I agree. Done. Using the same pattern elsewhere as well.

src/io/indexed_db_test.ts, line 25 at r5 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
describeWithFlags('IndexedDB', CPU_ENVS, () => { ...} to constraint it to run only on cpu, otherwise this test will fail on node environment, Also no need to run this explicitly on webgl either. We will need to fix the other tests (e.g. localStorage) to also run only on cpu. See https://github.com/tensorflow/tfjs/issues/279

Done.

src/io/local_storage.ts, line 38 at r5 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
typeof window === 'undefined'

Done.

Comments from Reviewable

Reviewed 2 of 5 files at r3, 6 of 6 files at r6.
Review status: all files reviewed at latest revision, 25 unresolved discussions, all commit checks successful.

src/io/indexed_db.ts, line 75 at r3 (raw file):
Previously, caisq (Shanqing Cai) wrote…
=== null is covered in == null

according ts style guide, always use === http://go/tsstyle#equality-checks

Comments from Reviewable


update M2 with M1 fixes

You did it @dinakarmeda!
Thank you for signing the Anthem Opensource Software CLA.


config set LOAD_STREAM_PER_NODE default to 2

Proposed changes
Set session variable LOAD_STREAM_PER_NODE default to 2.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


How to use new inquirer.Separator() in Yeoman

resolved
https://github.com/yeoman/generator/issues/922


fix(worker/README): Usage section

In the section Usage of README file, we have:
mason make worker --name <brick_name> --description <brick_description> --author <brick_author> --license <brick_license>
However license is not a valid param and the param type is missing in the example

After https://github.com/dart-pacotes/.bricks/issues/83 the license will start to be a valid param with the following valid values MIT, GNUGPLV3 and none


Shared Application Gateway with the ingress controller add-on

According to https://docs.microsoft.com/en-us/azure/application-gateway/ingress-controller-overview#difference-between-helm-deployment-and-aks-add-on
multiple AGICs targeting one Application Gateway is not a supported scenario, but it doesn't state why, is it planned for future versions of the add-on?

Shared AGIC is only supported via Helm right now.
Not sure if it is planned, i've been using AGIC for a while and theres no sign this will be supported by the add-on.

Would love to know the answer to this as well. I can't tell you how many extra app gateways I have in order to support our multiple AKS clusters. And now, I don't want to use Helm.

+1
I have this problem too. Been trying to setup two clusters with a shared APPGW using HELM. The ingress will just overwrite the other clusters Ingress. Even tried using AzureIngressProhibitedTargets but it does not help.

I wish shared was on by default, is there no way to configure this outside of helm? I'm using terraform, can I simply add the required env var onto config map / pod?


feat: Add error messages for missing version sections

Description
Adds specific error messages for version ranges missing minor or patch versions.
With the current version, adding the following version to gleam.toml:
mist = ">= 1.2 and < 2.0"

...results in the error message:
encountered unexpected token: " "

If this PR is applied, that error message changes to:
encountered invalid range: "1.2 <- Missing patch version."

There's also a dedicated error message for missing minor versions.
Closes issue 33.

@lpil Done!


MockBot: Clean up Markdown

Per this PR comment:
The card markdown text strings are extremely messy and hard for humans to read. Clean it up so it looks nicer. This should only be a few minutes.

Did some research - it doesn't look like prettifying markdown inside a .json file is possible.


[BUG] State is not maintained in home screen after returning from result screen

hi @danger-ahead  the user input in dropdown and input field value is not maintained when user search for a word and come back to home screen.

Observed.
Can you work on this? I can assign you then.

yeah i can fix this. assign it to me


 It seems that the current ruby timeout leaves the processes running. The behavior is controlled with TERMINATE_CHILD_PROCESS_ON_TIMEOUT env.
The processes are killed a bit before the ruby timeout hits. The 2 seconds is just something I pulled out of thin air so I'm all in for changing it to something.
This also catches both kinds of timeouts in deployments and appends a notification to the error log that there was a timeout so this pr also kind of takes care of rest of the issues in #88.
We'll need to run this for a while ourselves to test how this actually performs, but opened this for initial thoughts.

Thanks @Mumakil


Ability to use composer from PATH

I am loving the plugin, good work there. On to the question: I'm using sync-settings to transfer my configuration between home and work. Using php from path makes me able to not use absolute names, but for some reason composer.phar requires the absolute path, and I can't just add "composer" (which I added to PATH). There's probably a valid reason for this not working, but could you explain it to me/revisit it?

If you're syncing stuff, and this does not work, what you might want to do is set COMPOSER_HOME to the same folder on your work and home computer, then install composer via composer.phar globally, and then specifying the full composer path in Atom.
Here's an example of what I mean:
mkdir /var/composer
export COMPOSER_HOME=/var/composer
echo COMPOSER_HOME=/var/composer >> ~/.bashrc

composer.phar global require composer/composer
# now use: /var/composer/vendor/bin/composer

With that, you can sync the /var/composer directory, either via a symlink to your Dropbox folder if that's what you're using.


Officer Table Overhaul

Adding tests for Officer API endpoints
Creating association objects for:

Accusation (Officer/Perpetrator)
Employment (Officer/Agency)

Added new officer endpoints

Get all officers
Get officer by ID
Create Officer

Recreated PR #352 after it stopped synchronizing with the branch.


codeLength with the value MAX_INT

Today I tried to deobfuscate a class using the library manually, as well as using RecafX4, all the errors indicated a lack of memory, while investigating in the library I found this stack frame

the class file itself is working and can be launched

of course, here is the class file
dec.zip

@Kawanaao what Java version are you using to run this class? I cannot get the JVM to parse it properly.

I don't have a lot of time to look at this yet, but I'm guessing a custom ClassLoader is used to parse it. Seems like every UTF-8 string in the constant pool beginning with forge is set to be seven bytes too large. Some other clever manipulation is done to string lengths, I didn't catch it all.
The constant pool also defines strings of interest:
Ldev/xdark/iras/api/antitamper/RECrash;

Oh, great observation about the pattern. I ditched the class after noticing the incorrectly reported sizes.
This is of course beyond the scope of cafedude so perhaps this issue should be closed @Col-E?

The invalid string length is definitely out of scope, but I'm curious how @Kawanaao got that far. Maybe the bug raised in the first post is in-scope. Then again, the relevant anti-RE author is a semi-frequent contributor to this repo. Someone should reach out to them and ask ;)


additional training ..

Thank you for your AnoGAN.
I have two questions.
First,  It goes out because of a lack of capacity while studying.
I use my data with the size of 1024, batch size of 1
Second, I want to additional training.
What should I say on the command ?

If there is a pretrained model in checkpoint directory with the given shape (dataset name, batch size, output width, output height), the model is being loaded by default before the training.


chore: replaced market name with tradable instrument name (1259)

Related issues 🔗
Closes #1259
Related https://github.com/vegaprotocol/vega/issues/6031
Description ℹ
The market framework spec does not mention a name at the top level definition of a market. There should only be a name and code at the instrument level.

I thought this might clash with https://github.com/vegaprotocol/frontend-monorepo/pull/1265, but it doesn't! Hooray.


Bluetooth: audio: correct arg usage in BT_CODEC_LC3_CONFIG_DATA

Correct _frame_blocks_per_sdu usage in BT_CODEC_LC3_CONFIG_DATA
Signed-off-by: Chris St John<EMAIL_ADDRESS>

@Chris-StJohn-Bose Please add a commit message to your commit :)

@Chris-StJohn-Bose why did you rebase?
Looks like no code was changed, so seems like it didn't need any rebase.
The issue with rebasing and re-pushing is that all approvals get dismissed :D

@Chris-StJohn-Bose why did you rebase?
Looks like no code was changed, so seems like it didn't need any rebase.
The issue with rebasing and re-pushing is that all approvals get dismissed :D

@Thalley - yes it said I had 2 approvals but merge was blocked without a rebase so I rebased. How do I get this change into main?

@Chris-StJohn-Bose why did you rebase?
Looks like no code was changed, so seems like it didn't need any rebase.
The issue with rebasing and re-pushing is that all approvals get dismissed :D

@Thalley - yes it said I had 2 approvals but merge was blocked without a rebase so I rebased. How do I get this change into main?

What do you mean by it was blocked without a rebase?
Unless there is a file conflict, which I assume there isn't, there shouldn't be any reason to rebase :)
Once it has two approvals, then someone with merge rights will merge it at some point :)

@Thalley It is this message that suggest the PR needs a re-base:

Should that just be ignored?

@Thalley It is this message that suggest the PR needs a re-base:  Should that just be ignored?

Yes, this just indicates that main has newer commits than this branch (which is to be expected, as we merge roughly 10 commits per day on average).

@Thalley It is this message that suggest the PR needs a re-base:  Should that just be ignored?

Yes, this just indicates that main has newer commits than this branch (which is to be expected, as we merge roughly 10 commits per day on average).

Furthermore I can also mention that pressing the Update branch button in the web GUI would also rebase the PR, but without dismissing the reviews, as Github does not consider this a new push.

Filed https://github.com/zephyrproject-rtos/zephyr/pull/53204 to mention that button in the contribution workflow, unfortunately we can't disable it.


401 Unauthorized on  /store/customers/me

On page loads, I always get this error. How do I remove it?
ET http://localhost:9000/store/customers/me 401 (Unauthorized)

The error occurs because of this line of code: https://github.com/medusajs/nextjs-starter-medusa/blob/06c7381c9596897f1dfe01f592690cf81ae2791e/src/lib/context/account-context.tsx#L26-L30. It checks if the user is logged in and if they are not, then it will obviously fail. You could update the logger of React Query to prevent the errors being printed to the console – https://tanstack.com/query/v4/docs/guides/custom-logger :)


minimumDelayBeforeDisplay feature

This wonderful library already supports minimumDisplayTime and it is very useful, but I need something  to better handle unknown operations. what I mean is: my app' going to call a web service to acquire some information, naturally it can't be sure how long it'll take, it can be less than a second, or up to a few seconds depending on network speed. now, with all the tools we have now, we can display the indeterminate progress for all operations and use minimumDisplayTime to make sure it doesn't get jumpy, but that's not good enough, it could be great if we could couple minimumDisplayTime with something like: minimumDelayBeforeDisplay to make sure we are not showing any progress if the operation was instantaneously! Of course it needs to be paired with minimumDisplayTime because the operation's duration is still unknown.
This could be very useful I think. Thanks.

Hello @mohpor!
Thanks for the good idea! I can understand why you would want such a feature. But waiting a minimum amount of time is maybe not the best approach. Here's my thoughts on this:
You have something to load and want to show the user that something is loading (and possibly blocking the user from interacting meanwhile). So what you want to be sure is that the user have time to see that something is going on (feedback), that's why we can have a minimum display time of the loader. But we would also want the loader to not show if the loading was quick enough => the problem here is that, first, the user could have no feedback that something was loaded (maybe you have a relevant message with the loader to show for the user) and second, that even if you wait for (e.g.) 0.3 seconds before showing the loader, if the loading takes 0.4 seconds or even 0.31 seconds, the loader is gonna be displayed anyway and it could have be done since the beginning of the loading.
Maybe there's a better approach to handle this problem. Don't hesitate to give me your thoughts!
And thanks for using KVNProgress :)

Hello @kevin-hirsch
You're right about the facts you've mentioned about the unknown delay and even I have noticed it after I wrote the text above. It's still a valid point to consider because the loading time will be unknown, we can't possibly know how much time we should wait before the loading indicator should show up. But, for my case at least, I'm almost sure of the size of the packet I'm transferring. So, what I could (and have) done is to try and load the packet on as many network configurations as I could achieve (Obviously using Network Conditioner) and come to a conclusion about a cut off point that I should display the loading indicator. For instance, consider my packet size to be around 500KB, if my connection is in a good condition and I'm on LTE, it'll take under 2 seconds at most. After projecting all the data I could achieve (by rigorously benchmarking and logging events in my code) I came to a conclusion that I need my loading indicator to be visible at least 3 seconds while in many cases it'll take up to 2 seconds to load the data. But, if the connection is poor or the network is slow by its nature, it might take up to 30 seconds to load this packet!
And about the first part of your argument, I have to say, there are times that loading indicator is not necessarily a way to inform the user of the loading event at any cost. I believe the network loading indicator of the iOS itself does this job good enough. Especially in case of background loadings. In a world that connections are good enough for small chunks of data, we shouldn't clutter the UI by showing the loading indicator (as exciting and beautiful as they are, no doubt) at every loading event. Especially if it's just an informative indicator. Loading of data that doesn't concern current user's activity should go as seamless as possible.
Anyway, thanks for the time and if you decided to go about it, I can share the burden.
P.S.: I have a minimal pod list to add to every project I start, regardless of their requirements and KVNProgress is the first on the list ;)

Any updates?


Chat title

It would be quite useful to have an ability to put specific title to the conversation chat like it is done in Open Web UI. Also maybe display it on the top as a header.
In addition, it would be great to have some structure, like folders, as it is done in Notion and emoji support too 🙂

I totally agree with @olegshulyakov
If we can't organize our chats, at least we should be able to rename them


[todo-mvp-loaders] A lot of instances of the loader are being created.

A lot of loaders are being created in the todo-mvp-loaders branch. I have logged the callbacks of the LoaderManager.LoaderCallbacks are here are some logs -
I/TasksPresenter: onCreate()TasksLoader{cfba741 id=0}
I/TasksPresenter: initLoader: 1
I/TasksPresenter: onCreateLoader: 1
I/TasksPresenter: onLoadFinished: TasksLoader{cfba741 id=1}
I/TasksPresenter: onCreate()TasksLoader{45d2d8f id=0}
I/TasksPresenter: initLoader: 1
I/TasksPresenter: onLoadFinished: TasksLoader{cfba741 id=1}
I/TasksPresenter: onCreate()TasksLoader{de425f id=0}
I/TasksPresenter: initLoader: 1
I/TasksPresenter: onLoadFinished: TasksLoader{cfba741 id=1}
I/TasksPresenter: onCreate()TasksLoader{7fad32f id=0}
I/TasksPresenter: initLoader: 1
I/TasksPresenter: onLoadFinished: TasksLoader{cfba741 id=1}
I/TasksPresenter: onCreate()TasksLoader{877dfff id=0}
I/TasksPresenter: initLoader: 1
I/TasksPresenter: onLoadFinished: TasksLoader{cfba741 id=1}

As we can see a lot of instance of the Loader are created (one in every onCreate() of the Activity).
Also, we aren't supposed to use setRetainInstance() in a Fragment as mentioned by Ian Lake in his blog post about Loaders.
One solution is getting the loader instances from the LoaderManager something like this -
TasksLoader tasksLoader = getSupportLoaderManager().getLoader(TASKS_QUERY);
if (tasksLoader == null) {
    tasksLoader = new TasksLoader(getApplicationContext(), repository);
}

However, I am unable to type cast the generic Loader<D> to TasksLoader. Any other suggestions?

@malmstein any updates on this issue?

loaders branch is deprecated.


pull request for e2e test at 01/24/2017 08:26:13

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Network Connectivity Center module

Creation and management of NCC-based hub-and-spoke architectures.

@LucaPrete I don't see good reasons to do that. The module would be simpler, sure, but also for sure it wouldn't be more useful to be able to create one spoke only instead of multiple.
@juliocc Right, complexity is mostly on the CR but linked to NCC with NVAs. Enough in my opinion as to have this module. Creating a blueprint where you configure NCC and multiple spokes "by hand" would show this complexity. I did it, and that's why I wanted to encapsulate it and created this module. Also as said, these CRs are closely linked to NCC & NVAs and they can't be reused for other tasks (you can't interface them to e.g. a VPN tunnel).

@juliodiez what if we'll need to add different spokes to the hub? Also, I'd honestly prefer to call 1 ncc-ra-spoke module per spoke from outside and iterate with a for_each to create more, then having one huge module with multiple spokes...but hey, personal preference
@juliocc I think it makes sense to have a module for this. We talked about this for a long time in the new net stage of FAST. It will cleanup the code quite a lot

@LucaPrete

"what if we'll need to add different spokes to the hub?": sorry, I don't get the question, that's exactly what the module can easily do, see the README.
The downside I see in having one ncc-ra-spoke module and iterate with for_each is that the user needs to manage complexity in code creating the logic by themselves, whereas the module does this work for them offering a data interface instead.

@juliodiez can we add a blueprint that shows how to use the module, and why?

@ludoo Sure, I will create one. I would ask if having a blueprint is not independent of the module, but I presume you also doubt whether this should be a module. I see NCC as a design resource with elements quite coupled without benefit by breaking them apart, let's see if a blueprint adds to this argument.

@ludoo Sure, I will create one. I would ask if having a blueprint is not independent of the module, but I presume you also doubt whether this should be a module. I see NCC as a design resource with elements quite coupled without benefit by breaking them apart, let's see if a blueprint adds to this argument.

Exactly. We won't know if the design is the best one until we actually use the module. So while the module will undoubtedly change a few times throughout its life, we should start with a good fit with at least one use case. I know this is a bit of a PITA, but it would be my preferred way of bringing this in. :)

@juliodiez apologies I wrote my comment quickly in between call and might have been misunderstood.
My doubt is how to integrate this with other types of spokes, without making this module becoming a "huge monster" :)
For example, what if you'll need to add a VPC or a VPN type of NCC spoke? That's why I'd really recommend, btw reflecting what Fabric does in many other places, to make the hub at a very least optional. At that point, I think using a module construct for each spoke and a hub in common would give us the ability to keep the module useful but simple enough.
Ideally, in a blueprint (or in the stage02) I'd like to see something like
resource "hub" "my_hub" {
...
}

module "spoke_ra_1" {
   hub.    = module.my_hub.id
   region = "europe-west1"
   routes = ["<IP_ADDRESS>/24", "<IP_ADDRESS>/24"]
   vms     = ["vm1", "vm2"]
   ...
}

module "spoke_ra_2" {
   hub.    = module.my_hub.id
   region = "europe-west1"
   routes = ["<IP_ADDRESS>/24", "<IP_ADDRESS>/24"]
   vms     = ["vm1", "vm2"]
   ...
}

In the future things like
module "spoke_vpc_1" {
   hub.    = module.my_hub.id
   region = "europe-west1"
   vpc.     = "my_vpc"
   ...
}

and so on...
...I think the blueprint will end up being at this stage the same of the readme :)

@LucaPrete Oh, I see, I understand you now. And honestly, your approach makes sense to me but let me explain why I took this path. TL;DR: this module is not intended to include other type of spokes.
This module covers site-to-cloud connectivity, I mention it in the README at the beginning. This is only achieved by router appliances. VPNs and VLANs spokes are for data transfer, not for site-to-cloud, and data transfer has not been available in EMEA for so long that I doubt it will (and I'm biased towards EMEA customers :)
So I wanted to create an NCC module useful for most common cases, and (remember my bias) these are for me NVAs connecting VPCs and, more importantly, SD-WAN topologies.
It's probably in the middle between a module and a blueprint, but we don't have more granularity and I see advantages in grouping the elements that otherwise would always be repeated.
However, I agree that maybe in the future (NCC future, fingers crossed) we need to factor out and implement something like what you described. I didn't look that far (not for NCC, sorry).
So I will leave the founders decide what to do now. Maybe we could rename the module to make apparent that it's not a "general" NCC module?

Right now I myself am not sure I want to continue this module as is and am considering re-implement it as Luca's approach. But it's late, I'll resume thinking on it tomorrow :)

I heard you, and re-implemented the module to manage one spoke. Thanks especially to @LucaPrete for changing my mind. PTAL.

All comments addressed, PTAL.
One point: in custom_advertise I defined ip_ranges as a map of descriptions and address ranges, e.g.
"peered-vpc" = "<IP_ADDRESS>/24"
when it's usually the opposite, a map of address ranges and descriptions. That doesn't seem intuitive to me but if you force me I will change it.

"values are then marked optional in the type" -> I don't get it. In both cases, vpn or my module, the type is map(string) and the semantics are in the assignment, kind of:
  range           = range.key
  description = range.value

vs
  range           = range.value
  description = range.key

(btw, I've always thought that who opens a comment should resolve it :)

"values are then marked optional in the type" -> I don't get it. In both cases, vpn or my module, the type is map(string) and the semantics are in the assignment, kind of:
  range           = range.key
  description = range.value

vs
  range           = range.value
  description = range.key

true :) maybe in the CR advertisement? I'm pretty sure that was the rationale; regardless, we should have all modules use the same interface

Ofc I'll abide by the rules and resolve, but don't agree ;) (e.g. random ref.)

Ofc I'll abide by the rules and resolve, but don't agree ;) (e.g. random ref.)

Good! Just send a PR after this one to invert the type anywhere we're using ranges. Tests should make it pretty easy to spot issues.

No, no. I changed semantics and left as the rest of code (IP range = key). I meant I don't agree with who should resolve a comment

No, no. I changed semantics and left as the rest of code (IP range = key). I meant I don't agree with who should resolve a comment

let me put it this way: as a reviewer, I trust you to do the right thing once a comment has been sent :)


Alpine 3.16 EOL

[x] Create a release (if necessary - which ensures images are up to date before deprecating )
[ ] Open a PR
[ ] Update templates (if necessary)
[x] Update https://github.com/devcontainers/images/issues/90
[ ] Update Microsoft Artifact Registry docs

Have raised corresponding work pr's for mcr docs updation, templates updation, images updation


Jobs Reborn v4.15.9 doesn't load at server start

Jobs Reborn version 4.15.9 doesn't load on a server start, the following error occurs in the log: https://pastebin.com/wY2UHKqR
Version 4.15.7 works fine (there is no 4.15.8 in the version history).
For all users who joined before we downgraded the job plugin that was disabled at the server start a second entry was created in the database, which caused job loss.
Paper 1.15.2 - 226

https://github.com/Zrips/Jobs/commit/ca459b62e98bfeff38bd158d72ae8a124df397c9

Thank you for the fix!, will there be a github release? :D


JLR API change update

So JLR has made a change to their API and now the add on isn’t working, however the devs at WattCat and MyPace have found an easy work around. Could you implement the change here too? I’m not sure what the change is to be honest though.

See #132


west.yml FileNotFoundError during west update

Zephyr Commit hash
d51a67b7c098c8bb5479a7b87f05dc40fb76e065
Golioth SDK Commit Hash
cc65be097d269d8938e4c91222cea63f8099aefb
Hardware Target
all platforms
What host OS are you using?
This affects every OS
Current Behavior
Known Issue
This is a known issue, we're filing this as a bug to make the fix more visible
Anyone who installed the Golioth SDK prior to May 2022 and tries to update it will see a FileNotFoundError for the west.yml when updating their repo and running west update.
Expected Behavior
How to fix
Overview
Edit the config file in the <project root>/.west directory to point to west-zephyr.yml (or west-ncs.yml if you are using the NCS version of our SDK)
Steps to fix:

Edit zephyrproject/.west/config
Change file = west.yml to file = west-zephyr.yml
Update westcd ~/zephyrproject/modules/lib/golioth
git pull
west update

Steps To Reproduce
Start with a Golioth Zephyr SDK installed prior to May 2022

cd ~/zephyrproject/modules/lib/golioth
git pull
west update

Logs, console output, or any kind of debug information
$ cd ~/zephyrproject/modules/lib/golioth
$ git pull
$ west update
Traceback (most recent call last):
  File "/home/mike/zephyrproject/.venv/bin/west", line 8, in <module>
    sys.exit(main())
  File "/home/mike/zephyrproject/.venv/lib/python3.8/site-packages/west/app/main.py", line 781, in main
    app.run(argv or sys.argv[1:])
  File "/home/mike/zephyrproject/.venv/lib/python3.8/site-packages/west/app/main.py", line 106, in run
    self.run_command(argv)
  File "/home/mike/zephyrproject/.venv/lib/python3.8/site-packages/west/app/main.py", line 336, in run_command
    cmd.run(args, unknown, self.topdir, manifest=self.manifest)
  File "/home/mike/zephyrproject/.venv/lib/python3.8/site-packages/west/commands.py", line 140, in run
    self.do_run(args, unknown)
  File "/home/mike/zephyrproject/.venv/lib/python3.8/site-packages/west/app/project.py", line 802, in do_run
    self.update_all()
  File "/home/mike/zephyrproject/.venv/lib/python3.8/site-packages/west/app/project.py", line 856, in update_all
    self.manifest = Manifest.from_file(
  File "/home/mike/zephyrproject/.venv/lib/python3.8/site-packages/west/manifest.py", line 1153, in from_file
    return Manifest(**kwargs)
  File "/home/mike/zephyrproject/.venv/lib/python3.8/site-packages/west/manifest.py", line 1283, in __init__
    source_data = source_file.read_text()
  File "/usr/lib/python3.8/pathlib.py", line 1236, in read_text
    with self.open(mode='r', encoding=encoding, errors=errors) as f:
  File "/usr/lib/python3.8/pathlib.py", line 1222, in open
    return io.open(self, mode, buffering, encoding, errors, newline,
  File "/usr/lib/python3.8/pathlib.py", line 1078, in _opener
    return self._accessor.open(self, flags, mode)
FileNotFoundError: [Errno 2] No such file or directory: '/home/mike/zephyrproject/modules/lib/golioth/west.yml'

I think I ran into the same issue on a fresh install (Raspberry Pi, Aarch64):
(.venv) pi@minirack:~ $ west init -m https://github.com/golioth/golioth-zephyr-sdk.git --mr main ~/zephyrproject
=== Initializing in /home/pi/zephyrproject
--- Cloning manifest repository from https://github.com/golioth/golioth-zephyr-sdk.git, rev. main
Cloning into '/home/pi/zephyrproject/.west/manifest-tmp'...
remote: Enumerating objects: 2871, done.
remote: Counting objects: 100% (1074/1074), done.
remote: Compressing objects: 100% (304/304), done.
remote: Total 2871 (delta 852), reused 867 (delta 762), pack-reused 1797
Receiving objects: 100% (2871/2871), 622.87 KiB | 2.76 MiB/s, done.
Resolving deltas: 100% (1750/1750), done.
FATAL ERROR: can't init: no west.yml found in /home/pi/zephyrproject/.west/manifest-tmp
  Hint: check --manifest-url=https://github.com/golioth/golioth-zephyr-sdk.git and --manifest-rev=main  You may need to remove /home/pi/zephyrproject/.west before retrying.

Adding back west.yml fixed the issue: https://github.com/beriberikix/golioth-zephyr-sdk/commit/27ae34b056c267920fff2795826876a756d297c8

west init -m https://github.com/golioth/golioth-zephyr-sdk.git --mr main ~/zephyrproject --mf west-zephyr.yml fixes the issue. It feels a bit clunky and I'd prefer to support the default of west.yml, but at least we have a fix.

@beriberikix The new approach to installing the SDK specifies west-zephyr.yml as the manifest file instead of west.yml.
west init -m https://github.com/golioth/golioth-zephyr-sdk.git --mr west-zephyr.yml ~/golioth-zephyr-workspace

I'll make sure to get that merged into docs on Monday, sorry.

No worries! You don't need to specify --mf?

No worries! You don't need to specify --mf?

Yes, I copy pasted incorrectly. Have corrected it above (copied from the SDK readme this time).


Crash when trying to modify Emitting parameter on CPUParticles2D when Signal finished() is linked to queue_free()

Tested versions

Reproducable in 4.2.stable, 4.2.2-stable, 4.3-beta3. Tried in earlier release 4.1.4-stable, but the finished() signal did not exist so seems to have been introduced in 4.2.

System information
Godot v4.2.2.stable unknown - Manjaro Linux #1 SMP PREEMPT_DYNAMIC Mon Jul 15 21:39:34 UTC 2024 - X11 - GLES3 (Compatibility) - AMD Radeon RX 6800 XT (radeonsi, navi21, LLVM 18.1.8, DRM 3.54, 6.6.40-1-MANJARO) () - AMD Ryzen 9 3950X 16-Core Processor (8 Threads)
Issue description
Editor will crash if modifying the Emitting parameter of a CPUParticles2D node, if the Signal finished() is linked to queue_free()
From stdout:
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.2.2.stable.arch_linux
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /usr/lib/libc.so.6(+0x3cae0) [0x7f8633d65ae0] (??:0)
[2] /usr/bin/godot(+0xecc9f8) [0x55e7e14f09f8] (??:?)
[3] /usr/bin/godot(+0x12e09d7) [0x55e7e19049d7] (??:?)
[4] /usr/bin/godot(+0x12e5d3f) [0x55e7e1909d3f] (??:?)
[5] /usr/bin/godot(+0x1492a3) [0x55e7e076d2a3] (??:?)
[6] /usr/bin/godot(+0x3c20321) [0x55e7e4244321] (??:?)
[7] /usr/bin/godot(+0x3a1d855) [0x55e7e4041855] (??:?)
[8] /usr/bin/godot(+0x3fac2e2) [0x55e7e45d02e2] (??:?)
[9] /usr/bin/godot(+0x3c50d97) [0x55e7e4274d97] (??:?)
[10] /usr/bin/godot(+0x192739) [0x55e7e07b6739] (??:?)
[11] /usr/bin/godot(+0x987be) [0x55e7e06bc7be] (??:?)
[12] /usr/lib/libc.so.6(+0x25c88) [0x7f8633d4ec88] (??:0)
[13] /usr/lib/libc.so.6(__libc_start_main+0x8c) [0x7f8633d4ed4c] (??:0)
[14] /usr/bin/godot(+0xa45c5) [0x55e7e06c85c5] (??:?)
-- END OF BACKTRACE --

Steps to reproduce

Open or create a new project.
Create a new scene of type CPUParticles2D
In Signals create a new Signal link for the finished() function.
Link it to Node->queue_free()
In the Inspector of the CPUParticles2D node, toggle Emitting.
Editor will now crash.

Minimal reproduction project (MRP)
test.zip

Thank you for reporting, consolidating in:

https://github.com/godotengine/godot/issues/87287

See there for more details, if you think something was missed about this and it's not the same issue, please comment here and it can be reopened


Create a map of inclusive projects within NHS D

What
Create a map on Mural of inclusive activities/projects happening within NHS D
Why
To identify:
• where we can improve
• what we can build on top of
• people already working on inclusive projects
Done when

[x] all the service manual team have had the opportunity to contribute
[x] we have opened the map up to others within the inclusion collective
[x] the map has been analysed and ordered to showcase any trends
[x] the map has been peer reviewed and revised accordingly

Finished map can be found here: https://app.mural.co/t/nhsdigital8118/m/nhsdigital8118/1617972595782/20a44749471eb63d8051aab1930c4cafcc05dbe6


Wrong position of the torso first collision link

It seems that the origin of the first collision box of the torso is not correct. I expect it to be
 <origin rpy="0 0 0" xyz="0 0 0.25" />

https://github.com/pal-robotics/tiago_robot/blob/31790ca2cd84b4f591ff22b497127e0129bfc4ca/tiago_description/urdf/torso/torso.urdf.xacro#L46
This is related to https://github.com/pal-robotics/pmb2_robot/issues/6

Could you please elaborate on this?
Visually in rviz and gazebo I see them align, and if I increase z by 0.20 cm it is floating in the middle of the torso.
They are aligned by default:

Actually, you are right, the issue may not be that the box is not well placed indeed.
When I measure with a ruler on the robot the height of the small step where the arm is placed when off, I get something between 45 and 50mm. If I do the same in rviz, with collision enabled, along the black line below, I get about 33mm.

Yeah that could be, again we'll pass this to the mechanical department so they can generate more up to date collision meshes.
Thanks for reporting it.


save_explanation and load_explanation methods can't handle sparse local importance values

Describe the bug
Save_explanation and load_explanation methods can't handle sparse local importance values.
We need to add the logic, similar to that in explanation client, to handle sparse data.
See disabled test "test_save_and_load_sparse_explanation"

closing issue as this has been fixed a month ago with PR https://github.com/interpretml/interpret-community/pull/477


Upgradle, remove findbugs, add errorprone, fix errorprone warns

This change is

Reviewed 22 of 22 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


Sort sub app by url length for better matching

There is a problem when multiple sub apps start with the same url.
For eg.
site = picoweb.WebApp(__name__)
site.mount("/long", app1.app)
site.mount("/longer", app2.app)

With current setup
for subapp in app.mounts:
    root = subapp.url
    #print(path, "vs", root)
    if path[:len(root)] == root:
        app = subapp
        found = True
        path = path[len(root):]
        if not path.startswith("/"):
            path = "/" + path
        break

first sub app that match beginning of request url will be chosen for further processing.
That could be problematic in above example if request url is following: /longer/something
because better match is second app.
One way to solve is to start searching from longest possible mount

Thanks for the patches! Could you please take time to do git log to familiarize yourself with the commit message conventions of this project? Otherwise, please allow for some time for reviewing and consideration, as I usually try to consider different solution alternatives.

Thanks for fast response. I'll take a look at commit messages and change it to adhere convention

I'll take a look at commit messages and change it to adhere convention

@laky55555: Thanks for the update, and sorry for taking so long time to get back to it. Partly that's due to the fact that github doesn't send any notification when you push a rebased branch, so any project where you'd submit a PR would appreciate an explicit comment when there's an update.
Otherwise, as I mentioned, I wanted to look for other alternatives to do subapp matching, because I still consider this solution a workaround. The matter, I'd like to avoid using functionality in picoweb which isn't strictly necessary. E.g. you could write a bunch of (simple) webapps which never call list.sort, thus you could compile that method out of Pycopy to save some code space on frugal microcontroller. But here, we add dependency on list.sort.
Anyway, I'm busy with other parts of Pycopy ecosystem, so let's merge the available fix (but I'm adding a TODO comment there).

Merging, thanks! 1.7.2 released.


Division with timedelta input

This PR enables the division of a timedelta array by a scalar or array of a different type.
The main change is typing of the output. Currently  timedelta64[M] / int is incorrecly typed as timedelta64[] which produces as a lowering error No conversion from timedelta64[M] to timedelta64[].
These changes make the output to be typed as timedelta64[M] (or any other time unit that matches the input), which eliminates the lowering error.
This PR builds on #5060 (and includes the changes from that PR) and is required before #4480.

Thanks very much for the PR, I've queued it for review.

/AzurePipelines run

@guilhermeleobas thanks for the review. I addressed your points in the latest commits.

@guilhermeleobas thanks for reviewing this. We are planning to release a 0.50.0RC1 this week so this will likely be parked until after that since it is in the 0.51.0 milestone. I'll mark it as 'waiting for reviewer' since an initial review has taken place and to attract attention .

Flake8 is complaining about a long line in the branch HEAD:
numba/np/numpy_support.py:407:81: E501 line too long (81 > 80 characters)


🚀 Feature: Catalog filter by language tag, powered by linguist plugin

🔖 Feature description
Allow for the linguist plugin to emit entity tags, allowing for users to easily search for components by language in the catalog index page.
🎤 Context
Often times, people ask a question like "How many services do we have written in NodeJS vs Java". We could ask for teams to self-report by manually adding tags, but automation may provide more value more quickly.
✌ Possible Implementation
Linguist plugin provides a processor you can hook up to the catalog which will fetch the language breakdown of a component and then modify the entity to include the language tag if it is not already there.
Likely we would also want this configurable, for example:

List of allowed languages to add tags for
List of disallowed languages to not add tags for
Number of bytes threshold for a language to exceed before the tag is added for that language

👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

I tried doing this myself, but I am just getting my feet wet with custom processors and probably don't know what I'm doing.
I tried passing all the PluginEnvironment into my processor and using this to try creating a connection to the linguist DB
private async connect(): Promise<LinguistBackendStore> {
    if (!this.linguistDbClient) {
      const dbclient = await this.env.database.getClient();
      const linguistDB = await LinguistBackendDatabase.create(dbclient);
      this.linguistDbClient = linguistDB;
    }
    return this.linguistDbClient;
  }

I then tried using this in preProcessEntity with the following code
    if (entity.kind === 'Component') {
      const entityRef = stringifyEntityRef(entity);
      try {
        const linguistDB = await this.connect();
        const { breakdown, processedDate } = await linguistDB.getEntityResults(
          entityRef,
        );
        entity.metadata.tags ||= [];
        breakdown.forEach(language => {
          if (
            language.type === 'programming' &&
            !entity.metadata.tags?.includes(language.name)
          ) {
            this.logger.info(
              `${entityRef} adding ${language.name} - ${language.type}`,
            );
            entity.metadata.tags?.push(language.name);
          }
        });
      } catch (err) {
        this.logger.warn(`Err pre-processing ${err}`);
      }
    }
    return entity;
  }

And this consistently threw the following error
Error: The migration directory is corrupt, the following files are missing:<PHONE_NUMBER>3813_init.js

I am going to guess I'm doing this entirely wrong and shouldn't be accessing the linguist DB directly, but I am not sure exactly what the right way to do this is. Should I be using the LinguistAPIClient instead? This seemed much harder to build, as it requires a lot of dependencies (more than just the DB connection).

TL; DR; Use the HTTP API for this 👍
I've been thinking about how I would build this myself for some time now here's roughly my approach:

Create a tags table
When processing an item in Linguist if the flag generate the tags is on then generate the tags so that they are valid based on the rules for them
Create a route for getting the tags using an entityRef
Create a processor that would simply fetch the tags by entityRef (if you don't get anything back just continue, it will be there later or eventually)
Add the tags to the entity
Add an annotation where the value is the id (PK from tags table?) for the tags

Reasons for some things:

Getting linguist to generate the tags itself and having the processor do less of that work means it won't drag that down as people can have many processor and the generation can be slow as it needs to pull down all the code and scan it.
Formatting the tags is needed as there are specific rules for this and I have a high confidence the languages names won't play nice with them. For example C# would need to be formatted differently somehow
How do you handle updates? If the languages change we need a way to know the current tags that were added and then the new tags. We can't just blow away all the tags as you might have added some from other places (YAML, other providers, other processors).This is where the annotation comes in. You could do a look up using the id to get the existing tags and the by entityRef would get you the latest.

Keep in mind this is all in my head and I'm not sure the real world impact of some of these ideas but maybe this can be helpful for you

How do you handle updates?

I'm not sure how all this part works as I don't fully understand the backend.
So, doesn't the original location that generated that entity eventually re-fetch and merge back into the catalog, so shouldn't the linguist processor eventually get an entity handed to it that it has seen already but doesn't have the tags already since it is being re-generated from the location?
That makes it sounds that by just appending to the list of tags should be fine. If the language breakdown changes, eventually the entity will be refreshed by the catalog importer and the linguist processor will then omit the tag

Create a tags table
When processing an item in Linguist if the flag generate the tags is on then generate the tags so that they are valid based on the rules for them

Yeah, I think there isn't a need to store a new tags table here if we can just fetch the language breakdown, which is already pretty close to tags. Fetching it over the HTTP API means that it will either return no data (linguist hasn't processed yet), or it will fetch whatever was last pulled by linguist, which has its own re-processing phase configured in the router.

TL; DR; Use the HTTP API for this 👍

Is there a best practice for how to hit the HTTP API of a plugin from a processor? Like an apiRef or something I should be passing to the processor from the catalog builder?

As it stands right now the Linguist data is not stored in the entity at all, it gets pulled from its database via its API to show the card on the entity's page.
We can't just append, for example we were using a CI/CD that was all based on Java but now we are using GitHub Actions which is all YAML. We've seen the Java drop off and the YAML show up in the Linguist card as we've done this change.
When Linguist regenerates the data it does an "upsert" so we would no longer have the previous state this is why I came up with creating the tags table. Maybe this needs to be changed? I'm open to that as an alternative - not doing an upsert, keeping the old data, and then using a date column to determine the latest data.
As far as I know there isn't a nice way to make these call in the Backend using the apiRef pattern. I've just been pulling in the backend.baseUrl and then building up the rest of the string as needed. Maybe @freben or @jhaals have suggestions?
Really happy to see this getting worked on, is this something you are going to contribute or is this just something you are doing internally?

FYI @regicsolutions - you had asked for something like this in the PR that added the Linguist plugin so thought you might want to track this issue 👀

@awanlin I tried this out and have confirmed the processor will drop the tag if the languages breakdown changes. If you have time can you try it out to see if it works for your use case?

@bforbis sure, I just switched over to a new team so I might be a little slow with this. I have dedicated time for this on Friday every week so that's when I'll try it out. But I will give that PR a review now to at least get that started

Finding the URL of a plugin to call should always be done through the discovery API which is in the env.

Yeah I think the two of you were talking about different upserts right? It's correct that the processor always runs on the raw input yaml over and over again, so it doesn't have to take into account what it emitted last time it was called.


fix double normal selectivity section

Resolves issue #169.

Looks good overall.
It's good to have mention of pattern 2 added here, but since it's now mentioned, we should provide more info.
I see that the section on Pattern 2 in the status-quo manual is missing a link to the section on male selectivity offsets:
https://github.com/nmfs-stock-synthesis/doc/blob/553c2aea2df58edbbfb2be74c08ae15d36dc5d4d/9control.tex#LL1767C83-L1767C138. That is, the link is present in the code, but not showing up in the resulting HTML (highlight is mine in screenshot below):

I think it would be helpful to add something to the description of double the edited section like "Pattern 2 differs from Pattern 24 only in the treatment of sex-specific selectivity. See male selectivity offset for more detail." [ideally with a link that works]

@iantaylor-NOAA that link should now be working

@Rick-Methot-NOAA - do you mind re-reviewing/approving the changes so that I can merge this PR?


Text Labeling Support

-added new marker, clear.png, 1x1 transparent pixel
-added text labelling support
gmap.text(lat,lng,color,text) will add to new self.text attribute
gmap.write_text iterates over text attribute, writes text in color
and location specified.  Utilizes clear.png marker so no marker is
shown, only text.
possible improvements: allow user to specify text size and alignment.

What's the deal here? This would be super helpful.

Thanks for the submission!


Possible improvements for resource provisioning scripts and sample job

Context
Late June and early July, we ran a bug bash on the automated provisioning scripts and on the sample experiment. No major bugs were found, but the attendees did provide a lot of useful feedback and suggestions. We might not get to implement all the suggested changes, but at the very least we want to capture them here for future reference.

Explain what "Contoso" is.
What would it take to make the scripts bash-compatible?
Maybe provide arguments to the scripts in a config file or in some environment variables?
Make it clear that, for prerequisite number 3, only the extensions listed at the link are required, not the existing k8s cluster.
Slightly change the text for Prerequisite number 4 to something like "install and setup the v2 version of the Azure CLI ML extension".
To facilitate onboarding, maybe prepare a docker image containing all the prerequisites? Or a single script to install everything? Or a Deploy to Azure button?
Include instructions about execution policy to set up with PowerShell.
Make it clear that the Procedure section is a preview, and that all details are given in the following sections.
Typo with default value of $RGLocation parameter in CreateK8sCluster.ps1.
Underscores not supported in workspace names. Double check whether this restriction is absolutely necessary or not (probably not). At the very least, if we keep the restriction, make it clear in the error message that this is an extra restriction, not an Azure-wide limitation.
The set of prerequisites at the beginning is a bit confusing; it might be worth to explain why install this package or that package.
Maybe consider using Terraform for helping with all of this resource provisioning and management?
Not critical, but probably better to not give the workspace information in the config file. Instead, just include "to-do" tags, or some other string that is easy to search for. (This one relates to the sample experiment.)

This issue is for a:
- [x] feature request
- [x] documentation issue or request

will also include Amit's feedback


Mark the Continuation type as .acyclic. to keep orcs hands off it

this should allow CPS to be used with orc.
This does need some more discussion before merging...

Of course better would be if we can get rid if the cycle altogether, but I still don't properly understand the details of this.

Can you prove we never need a cycle?  What about making an acyclic subtype?
This doesn't feel like an easy guarantee to break, nor does it feel like an easy guarantee to make.  😒

Of course better would be if we can get rid if the cycle altogether, but I still don't properly understand the details of this.

AFAIK the only "intentional" cycle we make in the library is child -> mom, mom -> child where the former is required to return control and the latter is used to obtain procedure results.
I don't see a good way to get rid of the former but the latter can potentially be removed if we have some form of "message passing" (ie. a way to set variables in a continuation outside of it).
We can potentially side-step this issue altogether if we store the continuation "stack" in an array or something, but then that'd require either analysis to predetermine the maximum "stack" size, or a seq which have its own set of problems.
Then, of course, we still have the potential of intentional cycle by the user, which is a pain on it's own, although we can just say "don't make cycles", I guess?

We should move to result pointers to solve problems with result recovery.  This coincidentally solves some cycles, but really, I think we should stop caring so much about cycles.  They are only a problem for technical reasons and not semantic ones.  Better to design for cycles, instead.

I think a way to pass data in-out on resume/suspend points would be pretty neat. I can't think of /how/ to achieve that safely, though.
The idea is that if we have "native" data passing, we don't need the current tricks for result, and suspending magic can actually "return" value without pointer/continuation shenanigans.

What does "safely" mean in this context?
Suspend/resume points just means continuation legs, to me, so I see a number of options once we accept that the trampoline may have to change yet again.
It probably needs to be implemented as a core macro.

What does "safely" mean in this context?

Some kind of type-safety, either by clever use of generics or simply RTTI.

Clearly, this isn't the solution.


Fix for Kiosk: Always save scores on game over

@kiki-lee if the carnival extension's game over called info.saveAllScores();, it should fix the issues running in Kiosk.

Rock on!  I do believe it does.


Update build.gradle.kts

Description
This will fix a build error. 0.6.0-SNAPSHOT doesn't exist anymore, it's been replaced by 0.7.0-SNAPSHOT.
More : https://github.com/vanniktech/gradle-dependency-graph-generator-plugin
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] With a build

Test Configuration

Firmware version :
Hardware :
Toolchain :
SDK :

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Thanks @rvasseur31 for your contribution :)


Test with Amazon Linux 2023 ansible-core + python versions

Feature Request or Enhancement

Enhancement [X]

Summary of Request
The pipeline-testing and local-testing parts of README.md list a few different ansible-core/Python combinations that the ansible-lockdown/AMAZON2023-CIS is tested with.
We added a packaged ansible-core to Amazon Linux 2023 in the 2023.2.20230920 release. As per the full package list, this is currently ansible-core version 2.15.3-1.amzn2023.0.1, which works with the system python, which is 3.9.
Seeing as this role is likely only going to be run on Amazon Linux 2023, the testing matrix should likely include this exact combination of ansible and python versions. This could probably be done in an AL2023 based container image with the associated packages being installed. I've not looked into the details of how you test the various bits, and am unsure if something requires booting an instance or not.
Describe Alternatives You've Considered
This feels like something we should package in Amazon Linux so that it can be easily available to all AL2023 users. I'll open a tracking issue in https://github.com/amazonlinux/amazon-linux-2023/issues and post the link here, but before doing that, I'd love to hear the opinion of the maintainers here on that as a possibility.
Suggested Code
none as of yet, happy to help if that's of assistance.

hi @stewartsmith
Thank you for taking the time to raise this issue, apologies for the delay is responding, unfortunately subscribers and other project have taken priority.
Reading through the thread, it appears that you would run the playbook itself on an AL2023 host (localhost?), when we test we run from an ansible control node, so not run against the host itself, in this case local testing is general a MAC and local venvs against vagrant images or cloud image in this case, then the pipeline runs with a runner based upon ubuntu latest and the latest AL2023 build only a merge time.
At this time we don't have any plans to build a package, although keen to find out more if the Amazon thread picks up traction, we could work with them to achieve it.
many thanks
uk-bolly


Update react-router dependency to allow for stable 1.0 releases

This leaves open option to use with all pre-release 1.0 react-router versions; it's likely you'll want to eventually close them off (via ^1.0.0). You could also decide to do this now, if so, please ignore PR.
Also used ^ instead of ~ because I trust the react-router folks will correctly use semver.
Thanks much!

This is good, much better than updating it whenever there's a new RC :+1:


BackdropFilter does not work when compiling with --wasm

Steps to reproduce
Use the provided AppBar. When targetting CanvasKit everything works as expected. When compiling using --wasm blur is not applied.
Expected results (CanvasKit)

Actual results (WASM + skwasm)

Code sample
Code sample
AppBar(
      forceMaterialTransparency: true,
      flexibleSpace: ClipRect(
        child: BackdropFilter(
          filter: ImageFilter.blur(sigmaX: 10, sigmaY: 10),
          ),
     ),
);

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel master, 3.24.0-1.0.pre.197, on macOS 14.5 23F79
    darwin-arm64, locale en-DE)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.3)
[✓] Android Studio (version 2021.3)
[✓] Android Studio (version 2022.2)
[✓] VS Code (version 1.91.1)
[✓] Connected device (3 available)
[✓] Network resources

• No issues found!

Do you use extendBodyBehindAppBar on Scaffold? Can you share a complete sample code in a main.dart file so that we can run and confirm this issue?

Here a full code sample:
import 'dart:ui';

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      debugShowCheckedModeBanner: false,
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({
    super.key,
  });

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      extendBodyBehindAppBar: true,
      appBar: AppBar(
        forceMaterialTransparency: true,
        flexibleSpace: ClipRect(
          child: BackdropFilter(
            filter: ImageFilter.blur(sigmaX: 30, sigmaY: 30),
            child: AnimatedContainer(
            decoration: BoxDecoration(
              border: Border(
                bottom: BorderSide(color: Colors.black.withOpacity(0.09)),
              ),
              color: Colors.white10,
            ),
            duration: const Duration(milliseconds: 300),
          ),
          ),
        ),
        title: Text("Title"),
      ),
      body: SizedBox(
        height: double.infinity,
        width: double.infinity,
        child: Image.network(
            "https://fastly.picsum.photos/id/428/700/700.jpg?hmac=uGO0h-whSs6ScNzRZ4co4JfKP6otpf16kDrZ0qtEer8",
         fit: BoxFit.cover,
        ),
      ),
    );
  }
}

Thanks for the update. It is replicable as reported on latest master version.

 master flutter doctor -v

[!] Flutter (Channel master, 3.24.0-1.0.pre.197, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.24.0-1.0.pre.197 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 0bac2be379 (76 minutes ago), 2024-07-19 00:15:26 -0400
    • Engine revision ea1e53a4e8
    • Dart version 3.6.0 (build 3.6.0-55.0.dev)
    • DevTools version 2.37.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Also ran into this issue. @dxvid-pts I think your example is actually working on my Chrome, but I'm on 3.24.0-1.0.pre.542. That said, here's another test case that demonstrates:
void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});
  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return _FilterTest(Row(
      mainAxisAlignment: MainAxisAlignment.center,
      children: [
        DecoratedBox(
          decoration: BoxDecoration(
            border: Border.all(
                color: Colors.red,
                width: 2,
                strokeAlign: BorderSide.strokeAlignOutside),
          ),
          child: ClipRect(
            child: BackdropFilter(
              filter: ImageFilter.blur(sigmaX: 10, sigmaY: 10),
              // ignore: sized_box_for_whitespace
              child: Container(
                height: 200,
                width: 200,
              ),
            ),
          ),
        ),
        const SizedBox(width: 8),
        DecoratedBox(
          decoration: BoxDecoration(
            border: Border.all(
              color: Colors.blue,
              width: 2,
              strokeAlign: BorderSide.strokeAlignOutside,
            ),
          ),
          child: ClipRect(
            child: BackdropFilter(
              filter: ImageFilter.blur(sigmaX: 10, sigmaY: 10),
              child: Container(
                color: Colors.transparent,

                height: 200,
                width: 200,
              ),
            ),
          ),
        ),
      ],
    ));
  }
}

// This is just a colorful backdrop
class _FilterTest extends StatelessWidget {
  const _FilterTest(Widget child, {this.brightness = Brightness.light})
      : _child = child;
  final Brightness brightness;
  final Widget _child;

  @override
  Widget build(BuildContext context) {
    final Size size = MediaQuery.sizeOf(context);
    final double tileHeight = size.height / 4;
    final double tileWidth = size.width / 8;
    return CupertinoApp(
      home: Stack(fit: StackFit.expand, children: <Widget>[
        // 512 color tiles
        // 4 alpha levels (0.416, 0.25, 0.5, 0.75)
        for (int a = 0; a < 4; a++)
          for (int h = 0; h < 8; h++) // 8 hues
            for (int s = 0; s < 4; s++) // 4 saturation levels
              for (int b = 0; b < 4; b++) // 4 brightness levels
                Positioned(
                  left: h * tileWidth + b * tileWidth / 4,
                  top: a * tileHeight + s * tileHeight / 4,
                  height: tileHeight,
                  width: tileWidth,
                  child: ColoredBox(
                    color: HSVColor.fromAHSV(
                      0.5 + a / 8,
                      h * 45,
                      0.5 + s / 8,
                      0.5 + b / 8,
                    ).toColor(),
                  ),
                ),
        Padding(
          padding: const EdgeInsets.all(32),
          child: CupertinoTheme(
            data: CupertinoThemeData(brightness: brightness),
            child: _child,
          ),
        ),
      ]),
    );
  }
}

This only occurs when the BackdropFilter does not have a child that is painted. I'm not sure why this is.

I did some investigation on this, and it turns out there are two things causing this:

If the saveLayer operation has no pictures within it, we skip it entirely: https://github.com/flutter/engine/blob/4b7306dc7fd42463787b508dc23a14b17f13c53d/lib/web_ui/lib/src/engine/layers.dart#L774 We shouldn't do that, the operation should be applied anyway.
There is a skia issue where if the actual drawn contents of the layer that go on top of the backdrop filter are clipped out of the region of the canvas, the backdrop filter does not apply. I filed https://g-issues.skia.org/issues/362552959. Essentially the reason this happens in Skwasm and not CanvasKit is because Skwasm uses a SkBBHFactory to let skia accurately calculate the bounds of the picture. In this case the picture is "empty" in that there is nothing drawn over the backdrop, but we still want the backdrop filter to apply. There are more nitty gritty details and minimal examples in the linked skia issue.

I fixed (1) here but the issue is still occurring until (2) is fixed (the skia issue).

Related: https://github.com/flutter/flutter/issues/154698 , which should be fixable once this issue is addressed.

Amazing, thanks @eyebrowsoffire !


prod_comp_changed_with_priority: add a mail skiplist for the people w…

…ho changed prod/comp
It's a fix for issue: https://github.com/mozilla/relman-auto-nag/issues/752

Coverage decreased (-0.005%) to 25.791% when pulling b454b2c5a55fff00441fb34e5b064475c45334fa on calixteman:fix_prod_comp_changed into 4bc711bf2271e46df34d04fc9562229e7d78a5e2 on mozilla:master.


[3872] Update content for Request an account page on production

Context
https://trello.com/c/Pc91XzlT/3872-update-content-for-request-an-account-page-on-production
Changes proposed in this pull request

Updated page with new content

Guidance to review

Go to /request-an-account

Important business

Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

 Update content for Request an account page on production


Friendly pool names

Is your feature request related to a problem? Please describe.
As more pools with 8+ tokens are introduced, it becomes harder for users to parse pool names. Upcoming Managed Pools also need friendly names for marketing purposes.
Describe the solution you'd like
Home page in the Investment Pools table

If a pool has a friendly name, replace the current pool symbols with the friendly name.
If a pool has it's own pool icon, replace the underlying assets with the pool icon.

Pool page

If a pool has a friendly name, replace the currently title (which displays the pool type) with the friendly name.
If a pool has a friendly name, add new text in the description to state what the pool type is.

Additional context

@garethfuller Can you please add some context around any implementation solutions you recommend on how to maintain a list of friendly pool names?


torch compile issues

https://github.com/kohya-ss/sd-scripts/pull/1024#issuecomment-1940954544
I have written about some errors with torch compile above, but there are currently two issues with the torch compile option:

When using einops version 0.6.1, an "unhashable type: non-singleton SymInt" error occurs during finetuning. This issue does not occur with version 0.7.0.
When saving a model using torch compile, a prefix '_orig_mod.' is added to the saved model, which breaks the structure if saved as is.

I have been able to reproduce these issues in my local environment, but could someone please verify the situation in another environment?

einops 0.6.1 requires you to manually register its operators as compilable, which sd-scripts fails to do.
einops 0.7 does this automatically.
https://github.com/arogozhnikov/einops/wiki/Using-torch.compile-with-einops

einops 0.6.1 requires you to manually register its operators as compilable, which sd-scripts fails to do. einops 0.7 does this automatically. https://github.com/arogozhnikov/einops/wiki/Using-torch.compile-with-einops

Thank you for verification.
I understood why error occurred with 0.6.1.

[2024-02-24 05:02:51,702] [33/29] torch._dynamo.variables.higher_order_ops: [ERROR] self mismatch for bound method
I’ｍ also concerned about the continued occurrence of the above error while exec sdxl_train_network.py. Is this occurring in other environments?

When saving a model using torch compile, a prefix '_orig_mod.' is added to the saved model, which breaks the structure if saved as is.

It should be noted that this is incompatible with other applications such as a1111 as it is, or it should be modified to remove orig_mod as explained above.


Validate endpoint's schema objects

Currently if an endpoint references a $postResponse but we never defined a $postResponse in the list of schema objects, this will not cause signals to throw a validation error. It doesn't error until you actually go to compile/run the code in Xcode.
This would also likely be fixed once #23 is implemented.

Note: Api parser check to validate that objects are actually defined in schema list


tflite conversion

System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04):
TensorFlow installed from (pip3 install tensorflow==1.13.1):
TensorFlow version (1.13.1):

Provide the text output from tflite_convert
Some of the operators in the model are not supported by the standard TensorFlow Lite runtime. If those are native TensorFlow operators, you might be able to use the extended runtime by passing --enable_select_tf_ops, or by setting target_ops=TFLITE_BUILTINS,SELECT_TF_OPS when calling tf.lite.TFLiteConverter(). Otherwise, if you have a custom implementation for them you can disable this error with --allow_custom_ops, or by setting allow_custom_ops=True when calling tf.lite.TFLiteConverter(). Here is a list of builtin operators you are using: CAST, MEAN, PACK. Here is a list of operators for which you will need custom implementations: DecisionTreeResourceHandleOp, TreeSize.

Also, please include a link to a GraphDef or the model if possible.
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

@dimridd,
In order to expedite the trouble-shooting process, could you please provide the complete code to reproduce the issue reported here. Thanks!

These don't seem to be popular TF ops. You might need to implement TFLite custom ops to perform their behavior.
Also look at our general advice in the FAQ to handle unsupported ops.
Thanks!


Performance degradation in VsTestV2 for searching TestAdapter

Environment
azure-pipelines-task-lib version: 2.x
Issue Description
File system is traversed to find test adapters even when file system was already traversed to search test assemblies. As described in #516 file system traversal is very expensive for some projects (see log attached at 516).
Files found in the filesystem could be re-used to find test adapters.
Expected behaviour
Redundant file system traversals should be eliminated.

I'm not sure I understand, how is this different from #516? Or should we close here and just track this there?

Thank you for the reply and sorry for the confusion. I will try to describe it more precisely.
Situation
Test test files (testAssemblyVer2): *A.dll, *B.dll, *C.dll.
Actual behavior
There are four file system traversals performed:

File system traversal for *A.dll
File system traversal for *B.dll
File system traversal for *C.dll
File system traversal for **\*TestAdapter.dll

Related issue
Performance degradation for repeating file traversal for test files in bullets 2 and 3 are in #516.
This issue
In this issue I try to describe that searching for **\*TestAdapter.dll in bullet 4 adds one more file system traversal, which was already performed (and the found files are already in memory). Only one file system traversal should be performed for searching all four patterns (depends on configuration, of course).

As far as I understand:
#516 says, that 1+2+3 are implemented as single call of findMatch() with three patterns and the internal implementation of findmatch() can be easily adjusted not to perform file system traversal for every single pattern again and again.
#517 says, that although (1+2+3) vs. 4 are probably two different calls to findMatch(), they perform the very same slow file system traversal and this should be improved too.

Ah, that makes more sense, thanks for the clarification.
For this issue, I'm not really sure how we can improve this. Since we don't know ahead of time which files will be searched for again and we can't store all of the files we ever traverse in memory, I'm not sure there's a good way to do this. Maybe I'm missing something here, but as I see it this doesn't feel like something that can be solved.
I'll address #516 in its own issue. It seems more tractable to me, but I need to think a little bit more about it.

Is there any chance to wrap the find(findPath, findOptions) calls (implementation) with some simple memory-cache?

That could help. I'm not sure I'd want it enabled by default, but it could be a useful parameterized option to include.
I'll take a harder look at this when I get bandwidth, there are some other things in this library that I probably want to address first though. We also take PRs if you want to take a crack at it 😃

I renamed, this doesn't look like it degraded due to a change. Please correct me if I'm wrong.

Thats fine, thanks.


Generalize

bors r+
🤖

Iterator-based traversal methods, like ancestors, siblings and descendants,
include the node itself.
On Thu, 19 Mar 2020 at 20:08, Veetaha<EMAIL_ADDRESS>wrote:

@Veetaha commented on this pull request.
In crates/ra_syntax/src/algo.rs
https://github.com/rust-analyzer/rust-analyzer/pull/3650#discussion_r395257911
:

@@ -73,6 +73,10 @@ pub fn least_common_ancestor(u: &SyntaxNode, v: &SyntaxNode) -> Option<SyntaxNod
v.ancestors().find(|it| u_ancestors.contains(it))
}

+pub fn neighbor<T: AstNode>(me: &T, direction: Direction) -> Option {

me.syntax().siblings(direction).skip(1).find_map(T::cast)

@matklad https://github.com/matklad, what is skip(1) for?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rust-analyzer/rust-analyzer/pull/3650#pullrequestreview-378015618,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANB3MYPTRENAQGASF6EPMDRIJUUVANCNFSM4LPFXQVQ
.


Remove deprecated fields in device API. More comments. Switch to using new PhyIoType

The added enums don't seem to cause any issues, so it's best to merge this and move on.
@zedvijay @deitch @bharani-zededa please review.
We should add more comments in a second pass.
Signed-off-by: eriknordmark<EMAIL_ADDRESS>

I've just realized you actually requested a review on this @eriknordmark ;-) Let me update the branch and review.

LGTM


Flatpak support

Would it be possible to make a flatpak and host it in Flathub?
https://flathub.org/
That way more linux distros could have access to your app!

I believe that was the point behind building for Snapcraft.  I guess there can never be one cross platform standard, but adding every system becomes a nightmare for releasing.

I didn't realize there was a snap package. I believe flatpaks are a bit more popular than snaps but I could be wrong.

I don't know, but flatpak's reputation got a dent with the inability for apps to use system theming, among other things, and still a lack of good GUI (or even CLI) options. Snapcraft is much better in this category, despite having its own share of problems.
The journey to the one cross-distro standard is long and twisted.


Users/ersciple/m111willow

Is the fix already in master?  If not, link the bug tracking that work.
yes
What testing was done?
Tested on a machine with VS2017 and VS2015 to get a good range of combinations. And then hacked up the script to exercise paths where VS2017 is not installed and validated different version-input selections.
Also ring 0 canary builds succeed.
Does this fix change the AT/DT contract?
no
Does this fix include any database servicing changes?
no
Were tests added to cover this to make sure it doesn't regress?  If not, link a bug or user story tracking that work.
n/a

discussed offline w/ bryan, he approved

@lafritay for approval

Approved.
The one reservation I had is we previously limited the COM API to if VS15 chosen.  Now we always go through COM API unless not there and fallback to reg.  Late to do change but makes sense since (1) this makes VS 15 "latest" and (2) code will be more manageable.  The COM API needs to be reliable but that's also why we're getting in QU1 RC1 - we get a little runway for QU1 RTM.

This has my approval