0.5.4 crashing with PANIC "Milestones missing between (2272659) and (2272661)"

Describe the bug
Did run 0.5.3 up until it did hang at 2272659. Did shut it down and started 0.5.4.
Using the docker-image
Environment information:

HORNET version 0.5.4 via docker

Additional context
hornet_1  |               ██╗  ██╗ ██████╗ ██████╗ ███╗   ██╗███████╗████████╗
hornet_1  |               ██║  ██║██╔═══██╗██╔══██╗████╗  ██║██╔════╝╚══██╔══╝
hornet_1  |               ███████║██║   ██║██████╔╝██╔██╗ ██║█████╗     ██║
hornet_1  |               ██╔══██║██║   ██║██╔══██╗██║╚██╗██║██╔══╝     ██║
hornet_1  |               ██║  ██║╚██████╔╝██║  ██║██║ ╚████║███████╗   ██║
hornet_1  |               ╚═╝  ╚═╝ ╚═════╝ ╚═╝  ╚═╝╚═╝  ╚═══╝╚══════╝   ╚═╝
hornet_1  |                                    v0.5.4
hornet_1  |
hornet_1  |
hornet_1  | 2020-11-13T12:52:55Z        INFO    CLI     Profile mode 'auto', Using profile '8gb'
hornet_1  | 2020-11-13T12:52:55Z        INFO    CLI     Loading plugins ...
hornet_1  | 2020-11-13T12:52:55Z        INFO    Node    Loading Plugin: CLI ... done
hornet_1  | 2020-11-13T12:52:55Z        INFO    Node    Loading Plugin: Graceful Shutdown ... done
hornet_1  | 2020-11-13T12:52:55Z        INFO    Node    Loading Plugin: Profiling ... done
hornet_1  | 2020-11-13T12:52:55Z        WARN    Database        Deleting invalid milestone 2272660 (JVYIDMDDFISYRAMQL9W9YQTDSWKVOLHOISWTFDVNNQGZAQUYLWMYYMLXQQCVVVXJWHWG9ULP9QEJJUQDC)
hornet_1  | 2020-11-13T12:52:55Z        WARN    Database        Deleting invalid milestone 2272661 (RKAZMTNNOOZGEIS9SYUVLFRRRRFWALTHSSKZPVNQPSCIX9CYHTIJXNWBXVQECJYLJKY99YMWIBBJXILXC)
hornet_1  | 2020-11-13T12:52:56Z        INFO    Node    Loading Plugin: Database ... done
hornet_1  | 2020-11-13T12:52:56Z        INFO    Node    Loading Plugin: Curl ... done
hornet_1  | 2020-11-13T12:52:56Z        INFO    Local   Initialized local: peer://DxPMDJRQrG4LCQ95gH7fC98NU3d95p5u9YvtKpRW1wd9@<IP_ADDRESS>:14626
hornet_1  | 2020-11-13T12:52:56Z        INFO    Node    Loading Plugin: Autopeering ... done
hornet_1  | 2020-11-13T12:52:56Z        INFO    Node    Loading Plugin: WebAPI ... done
hornet_1  | 2020-11-13T12:52:56Z        INFO    Node    Loading Plugin: PoW ... done
hornet_1  | 2020-11-13T12:52:56Z        INFO    Node    Loading Plugin: Gossip ... done
hornet_1  | SnapshotInfo:
hornet_1  |     CooAddr: UDYXTZBE9GZGPM9SSQV9LTZNDLJIZMPUVVXYXFYVBLIEUHLSEWFTKZZLXYRHHWVQV9MNNX9KZC9D9UZWZ
hornet_1  |     SnapshotIndex: 2272169 (YKIDVOOWSHWYTKPUMOEGOMLCUPGIMIQGLRJFYNBIDLGSNVZOUHOAODYQVWIZKNURWUXCJGBEGSTW99999)
hornet_1  |     EntryPointIndex: 2212085
hornet_1  |     PruningIndex: 2212085
hornet_1  |     Timestamp: 2020-11-12 18:12:28 +0000 UTC
hornet_1  |     SpentAddressesEnabled: true
hornet_1  | 2020-11-13T12:52:56Z        INFO    Node    Loading Plugin: Tangle ... done
hornet_1  | 2020-11-13T12:52:56Z        INFO    Node    Loading Plugin: Peering ... done
hornet_1  | 2020-11-13T12:52:56Z        INFO    Node    Loading Plugin: WarpSync ... done
hornet_1  | 2020-11-13T12:52:56Z        INFO    Node    Loading Plugin: URTS ... done
hornet_1  | 2020-11-13T12:52:56Z        INFO    Node    Loading Plugin: Metrics ... done
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Loading Plugin: Snapshot ... done
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Loading Plugin: Dashboard ... done
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Skipping Plugin: ZMQ
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Skipping Plugin: MQTT
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Skipping Plugin: Spammer
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Skipping Plugin: Coordinator
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Skipping Plugin: Prometheus
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Executing plugins ...
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Starting Plugin: CLI ... done
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Starting Plugin: Graceful Shutdown ... done
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Starting Plugin: Profiling ... done
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Starting Plugin: Database ... done
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Starting Plugin: Curl ... done
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Starting Plugin: Autopeering ... done
hornet_1  | 2020-11-13T12:53:05Z        INFO    WebAPI  Starting WebAPI server ...
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Starting Plugin: WebAPI ... done
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Starting Plugin: PoW ... done
hornet_1  | 2020-11-13T12:53:05Z        INFO    Node    Starting Plugin: Gossip ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    Tangle  Starting TangleProcessor ...
hornet_1  | 2020-11-13T12:53:07Z        INFO    Node    Starting Plugin: Tangle ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    Node    Starting Plugin: Peering ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    Node    Starting Plugin: WarpSync ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    Node    Starting Plugin: URTS ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    Node    Starting Plugin: Metrics ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    Node    Starting Plugin: Snapshot ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    Dashboard       You can now access the dashboard using: http://localhost:8081
hornet_1  | ⇨ http server started on <IP_ADDRESS>:8081
hornet_1  | 2020-11-13T12:53:07Z        INFO    Node    Starting Plugin: Dashboard ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    Node    Starting background workers ...
hornet_1  | 2020-11-13T12:53:07Z        INFO    WebAPI  Starting WebAPI server ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    WebAPI  You can now access the API using: http://<IP_ADDRESS>:14265
hornet_1  | 2020-11-13T12:53:07Z        INFO    Gossip  Running BroadcastQueue
hornet_1  | 2020-11-13T12:53:07Z        INFO    Gossip  Running MessageProcessor
hornet_1  | 2020-11-13T12:53:07Z        INFO    Tangle  Starting TangleProcessor[ProcessMilestone] ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    PoW     Starting PoW Handler ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    Curl    Starting Curl batched hashing ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    Peering Peering Server (<IP_ADDRESS>:15600) ...
hornet_1  | 2020-11-13T12:53:07Z        INFO    Peering Peering Server (<IP_ADDRESS>:15600) ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    Autopeering
hornet_1  |
hornet_1  | WARNING: The autopeering plugin will disclose your public IP address to possibly all nodes and entry points. Please disable this plugin if you do not want this to happen!
hornet_1  |
hornet_1  | 2020-11-13T12:53:07Z        INFO    Autopeering     salt updated; expires=13 Nov 20 13:23 UTC
hornet_1  | 2020-11-13T12:53:07Z        INFO    Autopeering     started: ID=KDYjfdUmxrK Address=<IP_ADDRESS>:14626/udp PublicKey=DxPMDJRQrG4LCQ95gH7fC98NU3d95p5u9YvtKpRW1wd9
hornet_1  | 2020-11-13T12:53:07Z        INFO    Tangle  Starting TangleProcessor[ReceiveTx] ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    Snapshot        Starting LocalSnapshots ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    Tangle  Starting TangleProcessor[MilestoneSolidifier] ... done
hornet_1  | 2020-11-13T12:53:07Z        INFO    Peering trying to connect to 3 peers
hornet_1  | 2020-11-13T12:53:07Z        INFO    Autopeering     discovered: <IP_ADDRESS>:14626 / eWj93Ci2BLr
hornet_1  | 2020-11-13T12:53:07Z        INFO    Peering handshaking with <IP_ADDRESS>:15600...
hornet_1  | 2020-11-13T12:53:07Z        INFO    Peering handshaking with <IP_ADDRESS>:15600...
hornet_1  | 2020-11-13T12:53:07Z        WARN    Peering error read tcp <IP_ADDRESS>:55914-><IP_ADDRESS>:15600: read: connection reset by peer
hornet_1  | 2020-11-13T12:53:07Z        INFO    Peering moved disconnected <IP_ADDRESS>:15600 into the reconnect pool
hornet_1  | 2020-11-13T12:53:07Z        INFO    Peering handshaking with <IP_ADDRESS>:15600...
hornet_1  | 2020-11-13T12:53:07Z        INFO    Peering connected with <IP_ADDRESS>:15600 [alias: dterango#6389] [feature set(s): Chrysalis-Pt1]
hornet_1  | 2020-11-13T12:53:07Z        INFO    Tangle  Valid milestone detected! Index: 2273189, Hash: FUQJOHTIWOFHERDWTZBDVOLRWBGUTJAXROMAYEYEALLPMHZAIMAEOOSWGBDKGWWZPHASQZONVNHXA9999
hornet_1  | 2020-11-13T12:53:07Z        INFO    Tangle  Run solidity check for Milestone (2272662)...
hornet_1  | 2020-11-13T12:53:07Z        INFO    Tangle  Valid milestone detected! Index: 2272661, Hash: ZZPEAOXFDIZHOWXDWYNTYWIYKSPMAWJTVJYJWTR9VIHNAFOTMVXSCGLRJTDCNXWBXNSFNLAFIATCZ9999
hornet_1  | 2020-11-13T12:53:07Z        INFO    Tangle  Solidifier finished: txs: 8, collect: 0s, solidity 3ms, propagation: 0s, total: 3ms
hornet_1  | 2020-11-13T12:53:07Z        INFO    Tangle  Run solidity check for Milestone (2272661)...
hornet_1  | 2020-11-13T12:53:07Z        INFO    Tangle  Solidifier finished: txs: 0, collect: 0s, solidity 0s, propagation: 0s, total: 0s
hornet_1  | 2020-11-13T12:53:07Z        PANIC   Tangle  Milestones missing between (2272659) and (2272661).
hornet_1  | github.com/gohornet/hornet/plugins/tangle.solidifyMilestone
hornet_1  |     /__w/hornet/hornet/plugins/tangle/solidifier.go:413
hornet_1  | github.com/gohornet/hornet/plugins/tangle.configureTangleProcessor.func3
hornet_1  |     /__w/hornet/hornet/plugins/tangle/tangle_processor.go:49
hornet_1  | github.com/iotaledger/hive.go/workerpool.(*WorkerPool).startWorkers.func1
hornet_1  |     /github/home/go/pkg/mod/github.com/iotaledger/hive.go@v0.0.0-20201016154508-2514b782563a/workerpool/workerpool.go:158
hornet_1  | 2020-11-13T12:53:07Z        INFO    Tangle  Run solidity check for Milestone (2272661)...
hornet_1  | panic: Milestones missing between (2272659) and (2272661).
hornet_1  |
hornet_1  | goroutine 217 [running]:
hornet_1  | go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc000132d10, 0x0, 0x0, 0x0)
hornet_1  |     /github/home/go/pkg/mod/go.uber.org/zap@v1.15.0/zapcore/entry.go:230 +0x55f
hornet_1  | go.uber.org/zap.(*SugaredLogger).log(0xc0009852c8, 0xc004e5d104, 0x133fb16, 0x29, 0xc004071df8, 0x2, 0x2, 0x0, 0x0, 0x0)
hornet_1  |     /github/home/go/pkg/mod/go.uber.org/zap@v1.15.0/sugar.go:234 +0xf6
hornet_1  | go.uber.org/zap.(*SugaredLogger).Panicf(...)
hornet_1  |     /github/home/go/pkg/mod/go.uber.org/zap@v1.15.0/sugar.go:159
hornet_1  | github.com/gohornet/hornet/plugins/tangle.solidifyMilestone(0x100000000)
hornet_1  |     /__w/hornet/hornet/plugins/tangle/solidifier.go:413 +0x5f4
hornet_1  | github.com/gohornet/hornet/plugins/tangle.configureTangleProcessor.func3(0xc00039b700, 0x2, 0x2, 0xc000a071a0)
hornet_1  |     /__w/hornet/hornet/plugins/tangle/tangle_processor.go:49 +0x76
hornet_1  | github.com/iotaledger/hive.go/workerpool.(*WorkerPool).startWorkers.func1(0xc003769310)
hornet_1  |     /github/home/go/pkg/mod/github.com/iotaledger/hive.go@v0.0.0-20201016154508-2514b782563a/workerpool/workerpool.go:158 +0x1b6
hornet_1  | created by github.com/iotaledger/hive.go/workerpool.(*WorkerPool).startWorkers
hornet_1  |     /github/home/go/pkg/mod/github.com/iotaledger/hive.go@v0.0.0-20201016154508-2514b782563a/workerpool/workerpool.go:134 +0x5f

After automatic restart of docker container
hornet_1  | 2020-11-13T12:53:09Z        WARN    Tangle  HORNET was not shut down correctly, the database may be corrupted. Starting revalidation...
hornet_1  | 2020-11-13T12:53:09Z        INFO    Tangle  reverting database state back from 2273187 to local snapshot 2272169 (this might take a while)...
hornet_1  | 2020-11-13T12:53:11Z        INFO    Tangle  deleting milestones...80/795 (10.06%). 17s left...
hornet_1  | 2020-11-13T12:53:13Z        INFO    Tangle  deleting milestones...195/795 (24.53%). 12s left...
hornet_1  | 2020-11-13T12:53:15Z        INFO    Tangle  deleting milestones...250/795 (31.45%). 13s left...
hornet_1  | 2020-11-13T12:53:17Z        INFO    Tangle  deleting milestones...374/795 (47.04%). 9s left...
hornet_1  | 2020-11-13T12:53:19Z        INFO    Tangle  deleting milestones...490/795 (61.64%). 6s left...
hornet_1  | 2020-11-13T12:53:21Z        INFO    Tangle  deleting milestones...606/795 (76.23%). 3s left...
hornet_1  | 2020-11-13T12:53:23Z        INFO    Tangle  deleting milestones...713/795 (89.69%). 1s left...
hornet_1  | 2020-11-13T12:53:25Z        INFO    Tangle  deleting milestones...795/795 (100.00%) done. took 16.099s
hornet_1  | 2020-11-13T12:53:27Z        INFO    Tangle  analyzed 86942 ledger diffs
hornet_1  | 2020-11-13T12:53:28Z        INFO    Tangle  deleting ledger diffs...0/0 (100.00%) done. took 3.595s
hornet_1  | 2020-11-13T12:53:30Z        INFO    Tangle  analyzed 7461 transactions
hornet_1  | 2020-11-13T12:53:32Z        INFO    Tangle  analyzed 14953 transactions
hornet_1  | 2020-11-13T12:53:34Z        INFO    Tangle  analyzed 22746 transactions
hornet_1  | 2020-11-13T12:53:36Z        INFO    Tangle  analyzed 30635 transactions
hornet_1  | 2020-11-13T12:53:38Z        INFO    Tangle  analyzed 38276 transactions
hornet_1  | 2020-11-13T12:53:40Z        INFO    Tangle  analyzed 41023 transactions
hornet_1  | 2020-11-13T12:53:42Z        INFO    Tangle  analyzed 45625 transactions
hornet_1  | 2020-11-13T12:53:44Z        INFO    Tangle  analyzed 53162 transactions
hornet_1  | 2020-11-13T12:53:46Z        INFO    Tangle  analyzed 60620 transactions
[..]

I removed peer.db, snapshot.db, spent.db and tangle.db so that hornet did a restore from the latest snapshot from before the COO crashed. Didn't see a hornet crash again.

I enconter this problem when I upgrade from 0.5.3 to 0.5.5
So I change the version back to 0.5.4 and after revalidating the database, the node is sync now.
I think there is a better solution, though.

Thx for the bug report @c0deright .
We fixed this with v0.5.5.
I wasn't able to test the fix myself, since I don't have an affected database, but I saw this fix working already for several other people with version 0.5.5.
Are you really sure that you were running the 0.5.5 after you upgraded @EasonC13 ?
Can you please provide full logs of the crash?

Fixed with #744


Factor out control flow from lax.py into lax_control_flow.py.

Also moves control flow tests to lax_control_flow_test.py.

Sorry this is so big... the price of progress? Most of it is copy/paste.

Wow nice! Thanks for doing this!
The test failures are probably from some tricky naming: lax.py defines a reduce function, and so the references to reduce in the new file probably need to call lax.reduce rather than the builtin.
Similarly, another thing to be wary of, which you might have already caught, is that lax.py defines operations like max and min, while in that file the builtins are referred to as _max and _min. There might be a few other things like that...

Thanks Matt. I went ahead and committed this to prevent overwriting any control flow changes in lax.py that may sneak in without me/git noticing. The tests pass, so hopefully nothing's too broken... Please feel free to review and I can address any comments in a follow-up PR.

For anyone following along, we made the lax package so imports shouldn't need to change: https://github.com/google/jax/commit/0cf14837c91d8f05dc213a8b50a3c1b17088332d


#29: Streamline the Ultet processing

The process is now:

initialization
source code analysis and creating the db app model
target database(s) analysis, and update of the DbAppModel with it.
DbItems (diffs) generation for each database and grouping them per transaction
SQLs generation from DbItems
execution/print of the SQLs

Other chances:

Using Balta for queries now
Multiple databases (in source only) support
Finished and refactored table diffing

Depends on #13
Partially solved for #8
Closes #29
Closes #12
Closes #6

This item depends on:

AbsaOSS/ultet#13
By Dependent Issues.

This item depends on:

AbsaOSS/ultet#13
By Dependent Issues.


use detection code of sonarqube directly

i.e. get the "offline" mode working, without the Web API (that was the initial idea actually)
(per our discussion on today's meeting)

I looked around a bit. There are 2 ways I can think of.

Install server locally either by docker or their bin file by downloading the .zip for installation . This solution would make the tool more inconvenience.

to run their server locally with the bin file, it requires Java 11
Docker is great but will have problem in the Jenkins plugin later

Use JavaCheckVerifier during runtime. I investigated this a bit today and found some issues. This fires some warnings regarding this is illegal and will be fixed in the future (I check the maintainer of this class on Git and they seems to be inactive regarding this- google net.sf.cglib.core.ReflectUtisl).

Currently I am working on the second solution and it requires some workaround like running JUnit in the normal code to bypass the java.lang.AssertionError by CheckVerifier inside JavaCheckVerifier when it found issues with the file. I can't catch the exception through JavaCheckVerifier, which require workaround. Any great tips of how to do this would be great :) .

Will make a PR for this after PR #80 and #81 are merged :) .

Per discussion, Fernanda is working on this issue :) .


STYLE: Use trailing return type instead of typename + dependent type

This is a follow-up to b18668b639becf9e3dc6324ca68f915ab7bf0a1e and b37ac532060361739a2653bbbd2176dee0282d09.
It reapplied regex replace from b18668b639becf9e3dc6324ca68f915ab7bf0a1e.
PR Checklist

[x] No API changes were made (or the changes have been approved)
[x] No major design changes were made (or the changes have been approved)

Thanks @dzenanz Still don't know why I overlooked these when I originally ran the regex! Sorry! 🤷
The regex certainly did overlook lines of code that started with inline. Can you please check if these are now also included? I mean:
Find what: ^inline typename (\w+<.+>::)(.+)\r\n\1(.+)\r\n{\r\n


perimeterx updates

Codecov Report

Merging #5 into master will increase coverage by 20.83%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##           master      #5       +/-   ##
==========================================
+ Coverage   66.66%   87.5%   +20.83%
==========================================
  Files           1       1
  Lines           6      24       +18
==========================================
+ Hits            4      21       +17
- Misses          2       3        +1

Impacted Files
Coverage Δ

lib/index.js
87.5% <84.21%> (+20.83%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b5c27...5c0dc35. Read the comment docs.


Nodes who have children shouldn't contain any OctreeObject

Hi Nition,
If I understand the code correctly, when adding an object into the octree, if the current node contains enough object, we create children and move all the objects a level deeper. But in "GetNearby" function, I found that if a node has children, it STILL contains all the objects. Its children will have copies of the same objects. Could you please look into this? Or am I misunderstanding anything here?

Hey, I haven't got time to check this out properly at the moment unfortunately but I just want to say I have read it and I'll have a look when I can.
Objects should be getting removed from the parent when they're added to the children, yeah. I see the code that should be doing it in SubAdd:
objects.Remove(existingObj); // Remove from here
If they're hanging around, something's going wrong somewhere.

I fixed a very similar bug just recently. Could you please update and see if your bug is now fixed? As you say, nodes who have children shouldn't contain any octree objects, at least in the Point octree. In the Bounds octree, objects that don't fit into a child (crossing the border between two children) will stay in the parent.

Closing this since it's been 10 days, but feel free to respond if you're still getting the issue.


Feat/live 5099 lld add account ff

📝 Description
Rework add account feature flagging in manager app.
We fetch all existing flags and check if any currency app is impacted by the feature flag
❓ Context

Impacted projects: LLD LLC
Linked resource(s): ``

✅ Checklist

[x] Test coverage
[x] Atomic delivery
[x] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

👋  we just merged https://github.com/LedgerHQ/ledger-live/pull/3359 which greatly improved the TypeScript checks on Ledger Live Desktop projects (components, modals, screens) and effectively make it type check on the CI. Could you rebase with it and ensure there is no issue on pnpm desktop typecheck? Thanks and don't hesitate to ask for any TS help.


Enhancement: GridField DetailsForm missing a class refering to the managed model

The CMS edit form seems to have no reference to the managed Model, and that makes it hard to create javascript that acts on one Model class only.
I found this out when I wanted to add some JavaScript to the save button on one class. And it's not very easy to add a custom class to the form yourself.
This may be solved by adding the following in GridFieldDetailForm_ItemRequest::ItemEditForm()
$form->addExtraClass('edit-form-' . $this->gridField->getModelClass());

Probably better stored as a data attribute. Would you like to PR?

Unfortunately, Silverstripe CMS 3 has entered limited support in June 2018. This means we'll only be fixing critical bugs and security issues for Silverstripe CMS 3 going forward.
You can read the Silverstripe CMS Roadmap for more information on our support commitments.


Remove obsolete private_in_public lint in nightly.

RFC 2145 is on nightly now, deprecating the public_in_private lint.
https://rust-lang.github.io/rfcs/2145-type-privacy.html
See PR #113
public_in_private has been superceded by three new lints. The first two are warn-by-default and the third is allow-by-default. See the excerpt below for some details.

Lint private_interfaces is reported when a type with visibility x is used in primary interface of an item with effective visibility y and x < y. This lint is warn-by-default.
Lint private_bounds is reported when a type or trait with visibility
x is used in secondary interface of an item with effective
visibility y and x < y. This lint is warn-by-default.
Lint unnameable_types is reported when effective visibility of a
type is larger than module in which it can be named, either
directly, or through reexports, or through trivial type aliases
(type X = Y;, no generics on both sides). This lint is
allow-by-default.
Compatibility lint private_in_public is never reported and removed.

PR #113 is merged, this is closed.


added padding and increased header size

After changes:

Looks good! 🔥
Thank you for contributing. Don't forget to leave a star if you liked the project! ⭐
If you have any queries related to this project or want to connect with me, feel free to DM me on Twitter.
My Twitter username is @pushkaraj2007 🤝


added transforms and image preprocessing

like the title says

The targets and transforms were included in #14. The only difference to the function of this is when the transforms are called. I cannot think of an example when this is necessary, so hopefully won't be an issue.
Good effort and the credit maybe should have gone to you. Sorry. 😅


Ensure services with no operations generate valid Rust

Description

Add test coverage for a service with no operations
Correct the service builder code to allow for this

Following the decision made in https://github.com/awslabs/smithy-rs/pull/1369 we should NOT generate code for this Smithy class of models and instead throw an exception.


Feature/add proxy interval

Introduction
Adding a ProxyInterval class to ease Interval manipulation see #60

@shadowhand I've updated the package to add a ProxyInterval abstract class. What do you think ?

Looks good to me!


materialization support for storedprocedure or udf similar to view

Hi
Not sure this is right place to ask this question, I am trying to use dbt for devops setup for snowflake https://medium.com/hashmapinc/doing-devops-for-snowflake-with-dbt-in-azure-db5c6249e721 based on this blog recommendation , and i mainly see materialization works for both table and views.
Does anyone know if materialization can support stored procedures and udf's also ? Please help.
if anyone had templates for stored procedures please provide the link.
Thanks in advance.
Regards,
Bala

Hi Bala
I am the author of the blog you mentioned. The good news is that it is possible for udfs, procedures etc. I have custom implemented for a client. I have added these support in my git repo (which is also referenced in the blog)
dbt-hacks

Hi Venkat,
First of all kudos for your blog post :) I will download code and replay for stored procedures .
Is there any other channel that i can contact for your help if needed ? or i can ask over on this forum.
Thank you!

You can ask here; i will try to answer if possible

Hey @venkatra - this is awesome! Thanks for sharing that link.
I'm super open to supporting Stored Procedures and UDFs in a first-class way. I think the materializations in dbt-hacks (great name) are a super good starting point :)
Thanks for making this issue @BalaMuralibi - really cool discussion!

Hi Venkat,
Could you Please help with following error while deploying changes to snowflake, Deployment was working fine last time when i tested , it is failing now with error in attached log [same error today when i tried to just deploy code from [https://github.com/venkatra/dbt_hacks/tree/PERSISTENT_TABLE_MATERIALIZATION]  . is it something with dbt ? or python version issue
tasklog_7.log
Between, did you try with multiple database schema to deploy model scripts , i tried to follow this https://docs.getdbt.com/docs/using-custom-databases , but couldn't get to done exactly the way i want , if i have to add custom schema it always creating <custom_schema>_<default_schema>.sql.
Is there any work around for this ?

I see the below in the log
2019-11-25T15:43:39.8860237Z ./deploy_persistent_models.sh: line 10: **./configs.sh: No such file or directory**
Looks like you are sourcing this file, I am wondering if this is a file from your environment ?
I am guessing because of the above error, the variable is not set hence you are getting the error below
2019-11-25T15:43:46.8188952Z 'NoneType' object has no attribute 'lower'
Hence I would go by looking at how you had executed first.
Regarding : "multiple database schema"
I am not clear what you mean. In my client we did not go the way of seperate schema for each developer. All the developers where using the same schema ex: 'CUSTOMER'. I followed the suggesion in
https://docs.getdbt.com/docs/using-custom-schemas
and it worked

Thanks for your reply !
It seems this warning is not potential problem, i cross check with blog post https://github.com/venkatra/dbt_hacks/blob/PERSISTENT_TABLE_MATERIALIZATION/doc/images/dbt_run_log.jpg.
And ./deploy_persistent_models.sh this script is taken from https://github.com/venkatra/dbt_hacks/blob/PERSISTENT_TABLE_MATERIALIZATION/deploy_persistent_models.sh , from last successful release 2weeks ago, nothing has been changed in terms of variables /dbt profiles. It appears to me "dbt run -m $model_name"  is not working as expected now (could be due to changes in dbt code base) .
I have taken code to test from dbt_hacks repo https://github.com/BalaMuralibi/dbtblog . Please let me know if this info is not enough to explain problem.

Thank you very much for your reply, the error is due to empty table schema in target snowflake database, it was created by error.
Regarding Multiple table schema, i have adjusted get_custom_schema in macros and it works now.
I will have to try more scenarios , such as deleting table/view under models is throwing error now when IdentifyGitBuildCommitItems.py script try to fetch file that is deleted , may be i should change it to allow .py script to find only add/edit commit types. did you come across this scenario ?
Regards,
Bala

I did not have logic for detecting if a table script got dropped from the
build and taking appropriate action
.
I left it for the user to handle manually, as there could be potential
reasons on why the table scripts was dropped from git (Restructuring may
be).
On Tue, Nov 26, 2019 at 11:10 AM BalaMuralibi<EMAIL_ADDRESS>wrote:

Thank you very much for your reply, the error is due to empty table schema
in target snowflake database, it was created by error.
Regarding Multiple table schema, i have adjusted get_custom_schema in
macros and it works now.
I will have to try more scenarios , such as deleting table/view under
models is throwing error now when IdentifyGitBuildCommitItems.py script try
to fetch file that is deleted , may be i should change it to allow .py
script to find only add/edit commit types. did you come across this
scenario ?
Regards,
Bala
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fishtown-analytics/dbt/issues/1919?email_source=notifications&email_token=AAYAPHM2EE3TMENFOSF3E5DQVVC7JA5CNFSM4JM2LPI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFGRUMI#issuecomment-558701105,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYAPHLS26RBPYOQGQP37JDQVVC7JANCNFSM4JM2LPIQ
.

--
*Venkatesh Sekar,**Cell:<PHONE_NUMBER> /<PHONE_NUMBER> *
Email<EMAIL_ADDRESS>Linked In http://ca.linkedin.com/pub/venkatesh-sekar/1/7b7/636

Hi venkat,
Sorry for bothering you much , I have created materialization for table [based on persistent_table] , In my case i don't want to take backup of table. I want to create table if not exits , if table exist i check for add /drop columns and data type changes. it is working fine when table doesn't exist , but fails when i modify to add /drop column. Could you please point me if possible where i made error  https://github.com/BalaMuralibi/dbtblog/blob/master/plugins/snowflake/dbt/include/snowflake/macros/materializations/table_definition.sql. I see following error.
Thank you!
D:\Playground\snowflake>dbt run -m TEST
Running with dbt=0.15.0
Error sending message, disabling tracking
Found 5 models, 0 tests, 0 snapshots, 0 analyses, 136 macros, 0 operations, 0 seed files, 0 sources
17:38:16 | Concurrency: 1 threads (target='dev')
17:38:16 |
17:38:16 | 1 of 1 START table_definition model PUBLIC.TEST...................... [RUN]
Unhandled error while executing model.snowflakeproj.TEST
'NoneType' object has no attribute 'status'
17:38:28 | 1 of 1 ERROR creating table_definition model PUBLIC.TEST............. [ERROR in 12.43s]
17:38:29 |
17:38:29 | Finished running 1 table_definition model in 18.07s.
Completed with 1 error and 0 warnings:
'NoneType' object has no attribute 'status'
Done. PASS=0 WARN=0 ERROR=1 SKIP=0 TOTAL=1

Hi
If you do not want to retain a copy of the table, just set the config flag 'retain_previous_version_flg' to false. like below
{{
config(materialized='persistent_table'
,retain_previous_version_flg=false
,migrate_data_over_flg=false
)
}}

I have done it slightly different without using any flags in materialization, its working as expected.
Thanks.

HI Venkat, hope you are doing good.
While execute DBT_Run task in release pipeline i am getting below error.
Command used:
export SNOWSQL_ACCOUNT=$(ENV_SNOWSQL_ACCOUNT)
export SNOWSQL_USER=$(ENV_SNOWSQL_USER)
export DBT_PASSWORD=$(ENV_DBT_PASSWORD)
export SNOWSQL_ROLE=$(ENV_SNOWSQL_ROLE)
export SNOWSQL_DATABASE=$(ENV_SNOWSQL_DATABASE)
export SNOWSQL_WAREHOUSE=$(ENV_SNOWSQL_WAREHOUSE)
export DBT_PROFILES_DIR=./
chmod 750 ./deploy_persistent_models.sh
./deploy_persistent_models.sh
Error:
2020-10-13T06:12:26.6356893Z chmod: cannot access './deploy_persistent_models.sh': No such file or directory
2020-10-13T06:12:26.6599167Z /d/a/_temp/ca32c0f5-f437-4dd6-98a2-2d2339d9dd92.sh: line 9: ./deploy_persistent_models.sh: No such file or directory
tasklog_9 (1).log
I have forked your git repository and hence all the files are present in my repository but still getting this error. Could you please help me?


allow update timepicker options from controller

This PR allow to change pick-a-time-options from controller. See example:
<div ng-controller="MyController">
<input type="text" ng-model="skipHours" >
  <input type="text" data-ng-model="my time" required pick-a-time="curTime" pick-a-time-options="pickATimeOptions" >
</div>

controller('MyController', ['$scope', function($scope){
  $scope.skipHours = 0;
  $scope.pickATimeOptions = {disable: {[$scope.skipHours,30]}};
}])

Thanks for this pull request. It seems OK, but could you write the same feature for datepicker too ?

ok, I'll do it late

@Toilal check commits please

Please ping me when removing the log call, and then i'll merge ! Thanks.

@Toilal removed, sorry forgot about that :sheep:

Released in 0.3.1 thanks


Allow space after json key name. JSONEncoder has this (used by swift-driver)

@swift-ci please smoke test

⛵


Minor clarifications

These are 2 places where I paused, asked myself "is this OK or not?" and didn't find an answer in the docs.

Merged: https://github.com/openshiftio/appdev-documentation/commit/d2d54db932bcb52db51b51773a8c5335f5645895


Missing info: git-lfs required

The readme does not mention this, but the install requires git lfs to be installed (e.g. via sudo apt -y install git-lfs)

I guess development moved to https://gitlab.kitware.com/keu-computervision/slam anyways?


change Remove by RemoveName to fix DeleteRecords not working

after the issue: https://github.com/libdns/rfc2136/issues/1
i've tested replacing Remove by RemoveName and is working fine (i use bind as dns server).
this example work fine (we need to specify Type record with Name, without that we crash on RemoveName because rr is nil).
// delete records
deletedRecs, err := provider.DeleteRecords(ctx, zone, []libdns.Record{
{
	Name: "sub",
	Type: "A",
},
})

@mcarbonneaux Let me know if you don't hear from @KoHcoJlb soon -- then ping me, and I assume your change is a good fix and will merge it.

In that case could this be merged now?

I just noticed that the implementation by @emersion (which is nearly identical to this repo, oops -- we're working on addressing that soon) uses Remove():
https://github.com/libdns/dnsupdate/blob/2e79c50ea2ee12b484ae312b13e4ac81ffe78623/provider.go#L135
Are we sure that deleting all the RRSets is right?

I've also checked this today.
RemoveName would remove all records with the same name, which I believe is non intended usage of the interface.
Separate method could be added for this, or just simple Get-Filter-Delete)


[Question] Why the client-type for the Python Cart Service is Java

When trying to create the Service Connector for the Cart Service to Azure Cache for Redis, seems like the cart service is a Python application, why the client type is set to Java?
az spring-cloud connection create redis \
    --resource-group ${RESOURCE_GROUP} \
    --service ${SPRING_CLOUD_SERVICE} \
    --connection $CART_SERVICE_CACHE_CONNECTION \
    --app ${CART_SERVICE_APP} \
    --deployment default \
    --tg ${RESOURCE_GROUP} \
    --server ${AZURE_CACHE_NAME} \
    --database 0 \
    --client-type java

ERROR: az spring-cloud connection create redis: 'python' is not a valid value for '--client-type'. Allowed values: java, springBoot, dotnet, none.

Currently, Service Connector only supports basic runtime in Azure Spring Cloud as Azure Cli showed: java, spring-boot, dotnet. We may plan to support more client-type if it could actually run on Azure Spring Cloud.
In the Redis scenarios, connection strings are same among most of languages, so it doesn't matter to use client-type as java.

@ChenTanyi - Azure Spring Apps Enterprise can run Spring, Java, Dotnet, NodeJS, Python and Go.

@saragluna, please let me know if the note added in #33 is a sufficient explanation.

Thanks @maly7. The note is sufficient.


Version 0.5

Reference Issues/PRs
#77 #89 #90 #91
What does this implement/fix? Explain your changes.
Version 0.5
Any other comments?

@sadrasabouri Hi
Please complete this review until Monday - 2022-03-21 - 11:59 AM GMT+3:30
Notice: Only review, don't need to merge


Add a simple example for PIO.

Just a simple blinky, this time implemented using PIO.
This fixes #114.

Oops, sorry, that NOP is a leftover comment. I had NOPs in earlier versions (similar to the one here https://github.com/ithinuel/ws2812-pio-rs/blob/main/src/lib.rs#L56 ) but removed them later, to keep the example as simple as possible.

I found this very helpful as-is. I will create a pull request for pio-rs w.r.t. pio_proc::pio!() to fix usage in no-std code - once that works, I'd suggest adding an example for that macro as well, because it is far more comfortable.

Please could you add this to https://github.com/rp-rs/rp-hal/blob/main/boards/pico/README.md, so it all says in sync? Thanks!

Sure, I wasn't aware there was a list of examples in the README.

@jonathanpallant, as the example is located in rp2040-hal/examples/pio_blink.rs, not boards/pico/examples/..., is the README you mentioned really the right place to add it to?
Or should the example be moved?
(I'm not sure about that: On the one hand, the PIO is not specific to the pico board, so the point of the example applies to all boards using an RP2040. On the other hand, it does use the pico boot loader and GPIO25 for the LED, which would not be correct for other boards. But in that sense, most examples in rp2040-hal/examples would not run unmodified on all boards.)

This is a good point! Sorry, I did not spot which folder the example was in.
I think this example should be in the pico folder as it is specifically designed to work on the Pico and not all RP2040 boards have an LED on Pin 25. However, I can also see a use for an example in the rp2040-hal/examples folder which demonstrates the use of the PIO.
Perhaps an example in rp2040-hal/examples could talk in generic terms about setting up a PIO program to use an arbitrary pin, and an example in the boards/pico/examples folder could talk in concrete terms in blinking an LED on GPIO25.
If you're happy to do that, then please do update this PR. If not, we can merge this as-is and I can split it into two examples - one designed to run on a Pico and one that shows how to use the PIO crate.  I will also make a note to review the other examples and ensure nothing in rp2040-hal makes any assumption about which board it runs on.

How could a generic example work? Sure, it could toggle some arbitrary GPIO pin. But that's not better than the current example, just that this arbitrary pin happens to be connected to a LED on the Pico.
Perhaps I could leave the example in rp2040-hal/examples but change the description? Like, "this example toggles a GPIO pin. If it is connected to a LED, like on the rp pico, the LED should blink"?

It would be an example for reading rather than an example for executing - because as you say, it can't make any assumptions about the pin arrangements. I'll make it clear in the rp-hal README that all the examples are of that type.
Yes the code is fine as-is - the subtlety is in the documentation. Your proposed wording is good.

Brilliant - thanks!


updated qldds (1.31)

Please brew reinstall cask-repair, it's been updated - it now autofills the PR template


connectedk8s should validate the helm version

(This bug was created in conjunction with a debug session with the connectedk8s team).
Repro
Create a link from helm to microk8s.helm (instead of to microk8s.helm3).
What
The connectedk8s cli collects the version of helm, but only uses it for telemetry. The output generated is:
helm version --short --client
Helm not available, try enabling it with 'microk8s enable helm'

When it should look like:
v3.0.2+g19e47ee
Fix:
Parse the output to validate the v3, before sending to telemetry.

connectedk8s


Adjust logo text color in README

We use an onyx logo in all our README files (e.g. this one) which already adjust in light/dark mode.
However, the README is sometimes also integrated in other pages like the Nuxt module or npmjs which might have their own dark mode applied so the text color does not update in dark mode.
Maybe we can find a way for the SVG text color to adjust based on the application font color.

@larsrickert Is the issue still reproducible?
Looks fine on my system with dark mode.

@larsrickert Is the issue still reproducible? Looks fine on my system with dark mode.

The issue only occurs when the README is embedded by some 3rd party, like in the Nuxt module docs and you set your system preference to light + manually setting the Nuxt docs to dark
Our README logo adjusts its font color based on the users system settings. But this does not work if the application light/dark theme differs from this


Scheduling prover on another thread

The prover currently blocks the main Chronos thread. It should be scheduled on thread similar to the erasure coding as done in https://github.com/codex-storage/nim-codex/pull/716.

Notes on the circom-compat prover and Nim / Rust data ownership needed to do the threading properly:

the only current backend CircomCompat uses a Nim library nim-circom-compat
nim-circom-compat uses a C API exposed in a small Rust wrapper library circom-compat-ffi
circom-compat-ffi wraps the Rust library circom-compat, which is the core Circom / Ark library
the circom-compat-ffi wrapper creates a context pointer which owns the Rust memory for everything

More notes:

the Nim ffi boils down to calling Circom's builder.push_input through the C API

each call copies each bigint into memory owned by the CircomCompatCtx Rust pointer
CircomCompatCtx is manually created and released on the Nim side

calling builder.push_input copies the BigInt's into the circom-compat's builder which holds the data in a HashMap<String, Vec<BigInt>>

Updates: Adding a thread using taskpools results in memory corruption and crashes in either the Rust library code or on the Nim side after calling into the Rust library.
I've tried lots of variations on the problem. Initially my thinking was that there was something fairly simple like using sharing a piece of mutable memory between threads. However, I'm fairly competent I've tracked down all the places on the inputs where this occurs.
Things I've tried which haven't resolved issue:

updating circom-compat-ffi to create a new rng for each thread
duplicating CircomBn254Cfg on the main thread
create a new CircomBn254Cfg from circuit files (wasm, zkey, etc)
updating circom-compat-ffi to explicitly clone builder keys using to_owned
not freeing / releasing memory from CircomBn254Cfg or CircomCompatCtx to see if Nim side is calling something wrong

The Nim side appears to be working fine running the builder and creating the CircomBn254Cfg or CircomCompatCtx objects, however, as soon as prove is called it begins corrupting memory . Printing Nim inputs to the builder shows corruption in the builder keys, despite using to_owned to ensure the Rust will make it's own copy of the strings.

I'm going to setup a docker image so I can run valgrind on my mac and try to see what's going on.


As a curator, I would like to create a DwC Occurrence Report that includes custom predicates

The DwC Occurrence Report does a great job of combining CO and CE data into a single row, suitable for import and processing by other software. However, there is no way to include custom data attributes associated with the CO and CE.
A set of checkboxes to select which predicates are included for the CO and CE (using the dwc_occurrences/predicates.json endpoint to filter out unused/empty ones) would be sufficient.

Re-iterate that endpoint is done.

@LordFlashmeow this is implemented, but not strongly tested.  Close if it meets your needs at a basic leve.

Closing, reopen with issues.


I like my deps small

No need to use something that's supported by the standard lib. Complete removal will be done when https://github.com/TBD54566975/ssi-sdk/pull/412 is merged and we upgrade.

Codecov Report

Merging #532 (0218654) into main (584e140) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
- Coverage   20.06%   20.05%   -0.01%
==========================================
  Files          49       49
  Lines        6150     6152       +2
==========================================
  Hits         1234     1234
- Misses       4687     4689       +2
  Partials      229      229

Impacted Files
Coverage Δ

integration/common.go
1.62% <0.00%> (-0.01%)
:arrow_down:

The PR this depends on was closed as not happening, so closing this as well.


Code creating a most simple numpad

Further tweaks to the lib to support better QoL for coders
Fixed typos/omissions in the sample file

bors r+


On build, Command failed: dotnet build

Describe the bug
I downloaded the Bot Composer using the guide https://docs.microsoft.com/en-us/composer/install-composer?tabs=windows#prerequisites-for-installing-composer-as-a-desktop-application
However, I cant create a new bot using C#. Using Node I can with no problems, but I need it with C#.
I followed almost every guide that was on here, including this steps:
https://github.com/microsoft/BotFramework-Composer/issues/7876#issuecomment-881082316
however nothing was wrong. I updated drivers, reinstalled Composer and NET CORE but no results.
Bot Composer: v2.1.2
.NET Core SDK: v3.1.422
To Reproduce
Steps to reproduce the behavior:

Create an empty bot.

Click create after setting it up.

Loads for a while

See error

Expected behavior
Create a simple, empty bot.
Thanks in advance to anyone who helps me.

Hi @Osuna0102,
When you created a new C# bot outside of Composer using yeoman, what was the output of the dotnet build command? Did you get any error messages? If not, were you able to then run the bot? If the latter, what happened when you tried to run it?

Hi, @anishprasad01 thanks for the reply, im a little noob on things so please bear with me.

I got this, which is in spanish, and the translation goes like this: "Specify the project or solution file to be used as this folder contains more than one project or solution file."

The error message seems to be suggesting you have multiple csproj files within the same folder. Have you ensured there is only one bot's files within the folder? What are the contents of the folder?

This is how the folder looks. I dont see more than 1 csproj or sln files in it.
I re-created the bot in case I messed up before, but I got the same error.

Delete the .botproj file and rebuild. This is an older template, but this might help up find out why dotnet build is failing.

It says: Determinating which proyects to restaurate:
Error: Local origin of ProgramFiles/Microsoft SDKs/NuGetPacakges does not exist
Error compiling
Error: Local origin of ProgramFiles/Microsoft SDKs/NuGetPacakges does not exist
Is that usefull?

I solved it. Thank you very much for your help.
I searched on google the error stated above: "Local origin of ProgramFiles/Microsoft SDKs/NuGetPacakges does not exist"
Used this guide https://stackoverflow.com/questions/56558843/local-source-of-nuget-packages-doesnt-exist
and just used dotnet new nugetconfig to build repair it.
If anyone else is running this problem, just run on cmd "dotnet new nugetconfig" and it should be fixed

That would do it. Thanks for posting your resolution.


Add support for AppCode

See #18

Hi @dubreuia
I installed the 2.2.0 version on AppCode and for now, it seems to work fine!
I'll continue to test it for the next days and I'll tell you more.
(I was using it on Android Studio every day since 1 year so thank you for this plugin!)

Hello @dubreuia , is there any plan to release this? 🙏
I am happy to help testing it if needed 🙌 🙌 🙌


PBIS -"I have no name!" : after the addition to the domain and the configuration of the groups the user returns "I have no name!"

During the installation of pbis and the join to the domain no problems emerge, but by logging in with the user, he cannot get the id and the user group by returning "I have no name!"
PS: for security reasons I blocked the IP with xxx
##########################################################
Version: <IP_ADDRESS>1
OS/Distro: Red Hat Enterprise Linux Server release 6.10
Issue/Impact:
Note: replace content with your own
When reporting an issue it's important that we have as much detail as you can provide. The following is a list of commands to check.

[root@pprospectsvil ~]# ps -efa|grep lwsmd
root      6024 30789  0 08:23 pts/0    00:00:00 grep lwsmd
root     30145     1  0 Oct30 ?        00:00:00 /opt/pbis/sbin/lwsmd --start-as-daemon

[root@pprospectsvil ~]# /opt/pbis/bin/lwsm list
lwreg          running (container: 30168)
dcerpc         stopped
eventlog       running (container: 30196)
lsass          running (container: 30928)
lwio           running (container: 30247)
netlogon       running (container: 30222)
rdr            running (io: 30247)
reapsysl       running (container: 30306)
usermonitor    stopped

[root@pprospectsvil ~]# /opt/pbis/bin/domainjoin-cli query
Name = pprospectsvil
Domain = xxxxxxx
Distinguished Name = CN=PPROSPECTSVIL,CN=Computers,DC=gmt,DC=xxxxx,DC=it

[root@pprospectsvil ~]# pbis status
LSA Server Status:
Compiled daemon version: <IP_ADDRESS>1
Packaged product version: 9.1.551.2
Uptime:        0 days 19 hours 22 minutes 9 seconds
[Authentication provider: lsa-activedirectory-provider]
Status:        Online
Mode:          Un-provisioned
Domain:        xxxxxxxx
Domain SID:    xxxxxxxx
Forest:        xxxxxxxx
Site:          VI
Online check interval:  300 seconds
[Trusted Domains: 5]

[Domain: GMT]

        DNS Domain:       xxxxxxxx
        Netbios name:     xxxxxxxx
        Forest name:      xxxxxxxx
        Trustee DNS name:
        Client site name: VI
        Domain SID:       xxxxxxxx
        Domain GUID:      xxxxxxxx
        Trust Flags:      [0x001d]
                          [0x0001 - In forest]
                          [0x0004 - Tree root]
                          [0x0008 - Primary]
                          [0x0010 - Native]
        Trust type:       Up Level
        Trust Attributes: [0x0000]
        Trust Direction:  Primary Domain
        Trust Mode:       In my forest Trust (MFT)
        Domain flags:     [0x0001]
                          [0x0001 - Primary]

        [Domain Controller (DC) Information]

                DC Name:              xxxxxxxx
                DC Address:           xxxxxx
                DC Site:              xxxxxxxx
                DC Flags:             [0x0001f1fc]
                DC Is PDC:            no
                DC is time server:    yes
                DC has writeable DS:  yes
                DC is Global Catalog: yes
                DC is running KDC:    yes

        [Global Catalog (GC) Information]

                GC Name:              xxxxxxxx
                GC Address:           xxxxxx
                GC Site:              xxxxxxxx
                GC Flags:             [0x0001f1fc]
                GC Is PDC:            no
                GC is time server:    yes
                GC has writeable DS:  yes
                GC is running KDC:    yes

[Domain: CRIGA]

        DNS Domain:      xxxxxxxx
        Netbios name:     xxxxxxxx
        Forest name:      xxxxxxxx
        Trustee DNS name: xxxxxxxx
        Client site name: PD
        Domain SID:       xxxxxxxx
        Domain GUID:      xxxxxxxx
        Trust Flags:      [0x0022]
                          [0x0002 - Outbound]
                          [0x0020 - Inbound]
        Trust type:       Up Level
        Trust Attributes: [0x0048]
                          [0x0008 - Forest transitive]
        Trust Direction:  Twoway Trust
        Trust Mode:       In other forest Trust (OFT)
        Domain flags:     [0x0000]

        [Domain Controller (DC) Information]

                DC Name:              xxxxxxxx
                DC Address:           xxxxxx
                DC Site:              PD
                DC Flags:             [0x0000f1fc]
                DC Is PDC:            no
                DC is time server:    yes
                DC has writeable DS:  yes
                DC is Global Catalog: yes
                DC is running KDC:    yes

        [Global Catalog (GC) Information]

                GC Name:              xxxxxxxx
                GC Address:           xxxxxx
                GC Site:              PD
                GC Flags:             [0x0000f1fc]
                GC Is PDC:            no
                GC is time server:    yes
                GC has writeable DS:  yes
                GC is running KDC:    yes

[Domain: INTRALOT]

        DNS Domain:       xxxxxxxx
        Netbios name:     xxxxxxxx
        Forest name:      xxxxxxxx
        Trustee DNS name: xxxxxxxx
        Client site name:
        Domain SID:       xxxxxxxx
        Domain GUID:      xxxxxxxx
        Trust Flags:      [0x0022]
                          [0x0002 - Outbound]
                          [0x0020 - Inbound]
        Trust type:       Up Level
        Trust Attributes: [0x0048]
                          [0x0008 - Forest transitive]
        Trust Direction:  Twoway Trust
        Trust Mode:       In other forest Trust (OFT)
        Domain flags:     [0x0000]

[Domain: BETOS]

        DNS Domain:       xxxxxxxx
        Netbios name:     xxxxxxxx
        Forest name:
        Trustee DNS name: GMT.GAMENETGROUP.IT
        Client site name:
        Domain SID:       S-1-5-21-461410778-2417026049-1146536909
        Domain GUID:      00000000-0000-0000-0000-000000000000
        Trust Flags:      [0x0020]
                          [0x0020 - Inbound]
        Trust type:       Up Level
        Trust Attributes: [0x0000]
        Trust Direction:  Zeroway Trust
        Trust Mode:       External Trust (ET)
        Domain flags:     [0x0000]

[Domain: WINCO]

        DNS Domain:       xxxxxxxx
        Netbios name:     xxxxxxxx
        Forest name:      xxxxxxxx
        Trustee DNS name: xxxxxxxx
        Client site name:
        Domain SID:       S-1-5-21-2458678039-2337093563-2379887208
        Domain GUID:      00000000-0000-0000-0000-000000000000
        Trust Flags:      [0x0022]
                          [0x0002 - Outbound]
                          [0x0020 - Inbound]
        Trust type:       Up Level
        Trust Attributes: [0x0048]
                          [0x0008 - Forest transitive]
        Trust Direction:  Twoway Trust
        Trust Mode:       In other forest Trust (OFT)
        Domain flags:     [0x0000]

[root@pprospectsvil ~]# /opt/pbis/bin/enum-users | grep s.desantis
Name:              s.desantis
Home dir:          /home/GMT/s.desantis
Name:              s.desantis.admin
Home dir:          /home/GMT/s.desantis.admin

attach logs

/opt/pbis/bin/lwsm set-log-target -p lsass -  file /tmp/lsass.log
/opt/pbis/bin/lwsm set-log-level -p lsass - debug
attach log

Output/Error:
[root@pprospectsvil tmp]# su - s.desantis.admin
/usr/bin/id: cannot find name for user ID<PHONE_NUMBER>
/usr/bin/id: cannot find name for group ID<PHONE_NUMBER>
/usr/bin/id: cannot find name for user ID<PHONE_NUMBER>
[I have no name!@pprospectsvil ~]$ id
uid=1656238626 gid=1656226305 groups=1656226305,1656226304,1656226310,1656226311,1656226364,1656226899,1656227014,1656227015,1656227016,1656227017,1656227021,1656227377,1656227411,1656227509,1656227724,1656227797,1656227849,1656228415,1656228539,1656228609,1656228652,1656228654,1656228659,1656234744,1656234823,1656236524
[I have no name!@pprospectsvil ~]$
lsass.log

Can you verify that your /etc/nsswitch.conf file has the lsass in the passwd: and group: entries?
e.g.  passwd:  compat lsass

they are present  :
passwd:     files lsass
shadow:     files
group:      files lsass
#hosts:     db files nisplus nis dns
hosts:      files dns myhostname
Example - obey only what nisplus tells us...
#services:   nisplus [NOTFOUND=return] files
#networks:   nisplus [NOTFOUND=return] files
#protocols:  nisplus [NOTFOUND=return] files
#rpc:        nisplus [NOTFOUND=return] files
#ethers:     nisplus [NOTFOUND=return] files
#netmasks:   nisplus [NOTFOUND=return] files
bootparams: nisplus [NOTFOUND=return] files
ethers:     files
netmasks:   files
networks:   files
protocols:  files
rpc:        files
services:   files
netgroup:   files
publickey:  nisplus
automount:  files
aliases:    files nisplus

Were you able to figure out the issue?


runtime error when removeDistantBlocks is enabled;

thanks for sharing your latest work.   when i enable the max_block_distance_from_body to small value like 2.0;  updateESDF function always have illegal memory access, I tried to check for null_ptr  and skip the following access to them,    but then the updateEsdf will hanging sometimes.
What is the best way to get rid of it if  I need to enable max_block_distance_from_body ;

sorry to mention that the problem only exists if removeDistantBlock also executes for esdf layer;


InitialDateTime for minute Time Picker

So i can init the default time with InitialDateTime like this, but only hour is change, minute always init 0 no matter what number i choose

same

The version 2.3.1 just published check it out
for time constructor now you need to set the initalTime with the Time class
example
BottomPicker.time(
      title: 'Set your next meeting time',
      titleStyle: TextStyle(
        fontWeight: FontWeight.bold,
        fontSize: 15,
        color: Colors.orange,
      ),
      onSubmit: (index) {
        print(index);
      },
      onClose: () {
        print('Picker closed');
      },
      bottomPickerTheme: BottomPickerTheme.orange,
      use24hFormat: true,
      initialTime: Time(
        minutes: 23,
      ),
      maxTime: Time(
        hours: 17,
      ),
    ).show(context);


error with "hdf5-sys v0.6.1" when i run the example code

#D:\time_test>cargo run --release
Compiling hdf5-sys v0.6.1
error: failed to run custom build command for hdf5-sys v0.6.1
Caused by:
process didn't exit successfully: D:\time_test\target\release\build\hdf5-sys-0c82dab37fabc7d4\build-script-build (exit code: 101)
--- stdout
Searching for installed HDF5 (any version)...
Found no HDF5 installations.
--- stderr
thread 'main' panicked at 'Unable to locate HDF5 root directory and/or headers.', C:\Users\songroom.cargo\registry\src\github.com-1ecc6299db9ec823\hdf5-sys-0.6.1\build.rs:523:13
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace.
thanks!

@songroom2016 Where is your HDF5 installed on this Windows machine?

Closing since no response from OP, if details are provided we can reopen this.


add examples of reset and error onsubmit

It would be super cool if you could provide an example of how to  use the reset and error params passed with onValidSubmit()
 handleSubmit = (data, reset, err) => {
    console.log(data, reset({}));
    // return this.props.inviteManager(data, this.props.account.id);
  }

tried calling reset() and reset({}) to no avail. would be cool if i could just do reset(true) and reset all fields.

issue was from getValue not returning an empty string


Julia Broke Sphinx (classic)

if anyone can help me fix sphinx I would really appreciate it (i tried uninstall then reinstall but feel free to try it again)

What is the specific error you are seeing?

$ sphinx-quickstart
failed to create process.


Resolved an issue where the React modules would not load

In earlier PRs the yarn.lock file was updated apparently in a wrong way.
I did a git bisect to find the commit that initially caused the issue and it was ee066b46c99b5304f1cd9437f225e623474cfaed which only touched the yarn.lock file. I reverted that commit and cleaned all local files (node_modules, caches, etc.) Then I rand a full build which updated the yarn.lock file properly and this build worked fine locally. Let's download the build from this CI run before merging to make sure and try to avoid one more RC :)
Fixes #5300

Oh and reviewers, because of the revert and the fix, the yarn.lock shows entirely modified, so to make it easier to review the actual fix, this is easier to reason about https://github.com/dnnsoftware/Dnn.Platform/pull/5305/commits/e5fc598288e5adfecea222428c83da79c3169622 (second commit in this PR)


[Bug]: No Favicon

Description
There is no favicon present in the tab bar in a web browser.

To Reproduce

Go to '4c.rocks'
See error

Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Can I get assigned to this?

Sure!!@LinuxGamer.

there are favicon

It works right?

hmm

Awesome! 🚀🚀🚀

It works on my end @sumanpaikdev. You can take it if you want to bro.

@tobySolutions yes please

check console and these errors popped up

you can disable the cohort that is currently set as TRUE. Now set the cohort as FALSE manually then it will work perfectly fine.

I use Ubuntu as well @LinuxGamer and it works fine on my pc. You can try @sumanpaikdev's suggestion though


Ensure header and footer script tag validation is case insensitive

PR: https://github.com/NationalSecurityAgency/skills-service/pull/2869

:+1:


VircadiaLauncher Directory would be better called Vircadia Launcher

in App Data it is VircadiaLauncher and in program files its Vircadia  Launcher.  These should match each other.

This has been completed and deployed with release v0.0.1q, the old directory will still exist and the installs will not be migrated (I wrote functions but it's just more trouble needing admin... etc., I will setup further control and functionality for the launcher to handle itself over time though so if we need to migrate to a new directory later, I can automate it.)


Enhancement: Method for determining a recompile

In the preprocess.less method I'm pulling variables from somewhere else in the app that are ran through lodash templating to produce some new LESS code to append to my less src that is returned from this preprocess.less method. That way, I'm able to dynamically inject and override LESS variables.
This is great and works well. However, I want to recompile when those external variables I'm interpolating into a template have changed since the last time I compiled. The middleware currently only recompiles based on mtimes and import paths, but none of that has changed in the preprocess modification scenario.
If there were another preprocess method like shouldCompile: function(src, req) that returned a boolean, it'd give the necessary control. If that method isn't defined or returns false, it could still perform your normal check on mtimes and less imports.
Thoughts?

I think that is a good idea. Would work for almost all use cases without much overhead.


controller: Fix hang in controller tests

The tests were hanging during TestStreamDeployment, and I noticed that pgx was blocking trying to acquire a connection. Looking at the code, we were creating transactions before reading from the database, and so I moved the transactions and it no longer hangs.
I don't know the specific reason this was an issue (I assume reading inside a transaction is an ok thing to do?).

Maybe the connection pool was too small? In any event, there's no reason to start the transaction early.

LGTM


Add Sintel Dataset to the dataset prototype API

This PR attempts to add Sintel Dataset to the prototype API.
There are a few TODOs:

[x] Add comments wherever required
[x] Add sha256 value

Though these TODOs should not block the review process, and I'm looking forward to the first round of review for this PR. In case there are things that I missed, please feel free to point out.
Special thanks to @pmeier on being very helpful with the bug fixing, and helping with the PR.
cc: @pmeier @NicolasHug
cc @pmeier @bjuncek

Update:
The code had a logical bug in the filter function and has been fixed now. I remember @pmeier mentioning in the review to have the scene returned in the dict as label, and that has been added in the recent commit.
I'm a little caught up today but will try working on the test as suggested by @pmeier above. Thanks!

EOL for Python 3.6 is next month, but I don't know when PyTorch will stop supporting it officially

According to https://github.com/pytorch/pytorch/issues/66462 the next release should be >= 3.7, but I'll ask for confirmation

@malfet confirmed that the tentative plan is to drop 3.6 with the next release.
Leaving that aside, I disregarded one fact in https://github.com/pytorch/vision/pull/4895#pullrequestreview-811255311 that makes the solution straight forward: the images are ordered. Thus, we need don't need to keep an arbitrary sized buffer, but only need to store the bytes of a single image. I've pushed a commit adding this feature and now we should be able to finalize this PR.


Label Padding content

calc( 0.5rem + 1px)
better: calc (0.5rem + 1px)

This is another issue, The label-padding editor shouldn't be shown, because it's always calculated based on input-padding and input-border. There are also other editors which are visible and shouldn't be visible.


Default VR camera FOV should come from the device

https://developer.mozilla.org/en-US/docs/Web/API/VREyeParameters/currentFieldOfView
We should use this as the default fov for VR Cameras.

@kkananen is this done? looks like it? https://github.com/vizorvr/vizor/blob/develop/browser/plugins/three_vr_camera.plugin.js#L10


error when using php 8.2

It sends me this error from the cdn, but apart from that if I don't have internet your library can help us, there should be a way to download that cdn

Hi,
Seems to me that your application has returned an error, which is not in json format and that's why it can not be decoded.
Check out the content of the http response.


How to render SharePoint page in Teams static tab in Teams Desktop client?

What type of issue is this?
Question
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[X] other (enter in the "Additional environment details" area below)

Additional environment details
-Teams Desktop client
Issue description
I’m trying to create a Teams personal tab app that renders our intranet homepage. Works on web browser but is blank on Teams desktop. Any ideas on how to debug the issue? My best guess is it’s an SSO issue. Here's what my Teams app manifest looks like (currently in test):
{
"$schema": "https://developer.microsoft.com/en-us/json-schemas/teams/v1.14/MicrosoftTeams.schema.json",
"manifestVersion": "1.14",
"version": "1.0.0",
"id": "${{TEAMS_APP_ID}}",
"packageName": "com.microsoft.teams.extension",
"developer": {
"name": "Teams App, Inc.",
"websiteUrl": "${{TAB_ENDPOINT}}",
"privacyUrl": "${{TAB_ENDPOINT}}/index.html#/privacy",
"termsOfUseUrl": "${{TAB_ENDPOINT}}/index.html#/termsofuse"
},
"icons": {
"color": "color.png",
"outline": "outline.png"
},
"name": {
"short": "JDTest-${{TEAMSFX_ENV}}",
"full": "Full name for JDTest"
},
"description": {
"short": "Short description of JDTest",
"full": "Full description of JDTest"
},
"accentColor": "#FFFFFF",
"bots": [],
"composeExtensions": [],
"configurableTabs": [
{
"configurationUrl": "${{TAB_ENDPOINT}}/index.html#/config",
"canUpdateConfiguration": true,
"scopes": ["team", "groupchat"]
}
],
"staticTabs": [
{
"entityId": "index",
"name": "SP",
"contentUrl": "https://.sharepoint.com?app=portals/_layouts/15/teamslogon.aspx?spfx=true&dest=/",
"websiteUrl": "https://.sharepoint.com?app=portals/_layouts/15/teamslogon.aspx?spfx=true&dest=/",
"scopes": ["personal"],
"context": ["personalTab"]
}
],
"permissions": ["identity", "messageTeamMembers"],
"validDomains": ["${{TAB_DOMAIN}}"],
"webApplicationInfo": {
"id": "00000003-0000-0ff1-ce00-000000000000",
"resource": "https://***.sharepoint.com/"
}
}

@JonoSuave - your manifest is incorrect.
You should not replace {teamSiteDomain} placeholder with your actual tenant domain.
It should remain as is: https://learn.microsoft.com/en-us/sharepoint/dev/spfx/deployment-spfx-teams-solutions#developer-provided-microsoft-teams-app-manifest--package
However, i general I would recommend using Viva Connections to display your intranet in Teams.


cardTitle in React code snippet example not closed properly

in the react example code snippet for card, where <AUcardTitle> is used, it has been closed with a </h3> instead of  </AUcardTitle>

I will correct it


edits and suggestions

offer used 2x in a sentence and grammar issue, other stuff

thanks for these edits! :)


fix default value for settings initialization

default value was not set, causing program to crash since its writing "" to file instead of default value

Codecov Report

Merging #1187 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1187   +/-   ##
=======================================
  Coverage   43.65%   43.65%
=======================================
  Files          32       32
  Lines        3569     3569
  Branches      579      579
=======================================
  Hits         1558     1558
  Misses       1869     1869
  Partials      142      142

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eca1d2...fab613f. Read the comment docs.

ha, yep, good fix.


Batch Size

Hi, why did you use 1 as the batch size? Have you tried other batch sizes?

It's limited by my hardware. Please feel free to use more than 1 if allowed by your gpu.


ModuleNotFoundError: No module named 'scraping_hub'

Is this project active, I see only 1 commit to it?
I am getting this error when adding it to middleware. Any suggestions?

I’m at the same point at you.
Could anybody help us please?

Hi!!
Thank you for your support!
The spider is getting closed, take a look:
"C:\Users\Luis\Mister>scrapy crawl mercado -o file.csv -t csv
2018-07-25 21:46:15 [scrapy.utils.log] INFO: Scrapy 1.5.0 started (bot: mercado)
2018-07-25 21:46:15 [scrapy.utils.log] INFO: Versions: lxml <IP_ADDRESS>, libxml2 2.9
.7, cssselect 1.0.1, parsel 1.2.0, w3lib 1.18.0, Twisted 17.5.0, Python 2.7.14 |
Anaconda, Inc.| (default, Nov  8 2017, 13:40:45) [MSC v.1500 64 bit (AMD64)], py
OpenSSL 17.5.0 (OpenSSL 1.0.2n  7 Dec 2017), cryptography 2.1.4, Platform Window
s-8-6.2.9200-SP0
2018-07-25 21:46:15 [scrapy.crawler] INFO: Overridden settings: {'NEWSPIDER_MODU
LE': 'mercado.spiders', 'FEED_URI': 'file.csv', 'AUTOTHROTTLE_TARGET_CONCURRENCY
': 2.0, 'SPIDER_MODULES': ['mercado.spiders'], 'AUTOTHROTTLE_START_DELAY': 2, 'B
OT_NAME': 'mercado', 'ROBOTSTXT_OBEY': True, 'USER_AGENT': 'Mozilla/5.0 (X11; Li
nux x86_64; rv:10.0) Gecko/20100101 Firefox/10.0', 'FEED_FORMAT': 'csv', 'AUTOTH
ROTTLE_ENABLED': True, 'DOWNLOAD_DELAY': 2}
2018-07-25 21:46:15 [scrapy.middleware] INFO: Enabled extensions:
['scrapy.extensions.feedexport.FeedExporter',
'scrapy.extensions.logstats.LogStats',
'scrapy.extensions.telnet.TelnetConsole',
'scrapy.extensions.corestats.CoreStats',
'scrapy.extensions.throttle.AutoThrottle']
2018-07-25 21:46:16 [scrapy.middleware] INFO: Enabled downloader middlewares:
['scrapy.downloadermiddlewares.robotstxt.RobotsTxtMiddleware',
'scrapy.downloadermiddlewares.httpauth.HttpAuthMiddleware',
'scrapy.downloadermiddlewares.downloadtimeout.DownloadTimeoutMiddleware',
'scrapy.downloadermiddlewares.defaultheaders.DefaultHeadersMiddleware',
'scrapy.downloadermiddlewares.useragent.UserAgentMiddleware',
'scrapy.downloadermiddlewares.retry.RetryMiddleware',
'mercado.middlewares.CloudFlareMiddleware',
'scrapy.downloadermiddlewares.redirect.MetaRefreshMiddleware',
'scrapy.downloadermiddlewares.httpcompression.HttpCompressionMiddleware',
'scrapy.downloadermiddlewares.redirect.RedirectMiddleware',
'scrapy.downloadermiddlewares.cookies.CookiesMiddleware',
'scrapy.downloadermiddlewares.httpproxy.HttpProxyMiddleware',
'scrapy.downloadermiddlewares.stats.DownloaderStats']
2018-07-25 21:46:16 [scrapy.middleware] INFO: Enabled spider middlewares:
['scrapy.spidermiddlewares.httperror.HttpErrorMiddleware',
'scrapy.spidermiddlewares.offsite.OffsiteMiddleware',
'scrapy.spidermiddlewares.referer.RefererMiddleware',
'scrapy.spidermiddlewares.urllength.UrlLengthMiddleware',
'scrapy.spidermiddlewares.depth.DepthMiddleware']
2018-07-25 21:46:16 [scrapy.middleware] INFO: Enabled item pipelines:
['mercado.pipelines.MercadoPipeline']
2018-07-25 21:46:16 [scrapy.core.engine] INFO: Spider opened
2018-07-25 21:46:16 [scrapy.extensions.logstats] INFO: Crawled 0 pages (at 0 pag
es/min), scraped 0 items (at 0 items/min)
2018-07-25 21:46:16 [scrapy.extensions.telnet] DEBUG: Telnet console listening o
n <IP_ADDRESS>:6023
2018-07-25 21:46:16 [scrapy.core.engine] DEBUG: Crawled (200) <GET https://www.m
ister-auto.es/robots.txt> (referer: None)
2018-07-25 21:46:19 [scrapy.core.engine] DEBUG: Crawled (200) <GET https://www.m
ister-auto.es/global_search2.html?idx=prod_monoindex_ESes&q=FEBI+BILSTEIN> (refe
rer: None)
2018-07-25 21:46:19 [scrapy.core.engine] INFO: Closing spider (finished)
2018-07-25 21:46:19 [scrapy.statscollectors] INFO: Dumping Scrapy stats:
{'downloader/request_bytes': 633,
'downloader/request_count': 2,
'downloader/request_method_count/GET': 2,
'downloader/response_bytes': 20923,
'downloader/response_count': 2,
'downloader/response_status_count/200': 2,
'finish_reason': 'finished',
'finish_time': datetime.datetime(2018, 7, 25, 19, 46, 19, 543000),
'log_count/DEBUG': 3,
'log_count/INFO': 7,
'response_received_count': 2,
'scheduler/dequeued': 1,
'scheduler/dequeued/memory': 1,
'scheduler/enqueued': 1,
'scheduler/enqueued/memory': 1,
'start_time': datetime.datetime(2018, 7, 25, 19, 46, 16, 229000)}
2018-07-25 21:46:19 [scrapy.core.engine] INFO: Spider closed (finished)"
My settings.py following your instructions:
"# -- coding: utf-8 --
Scrapy settings for bitcointalk_bot project

For simplicity, this file contains only settings considered important or
commonly used. You can find more settings consulting the documentation:

http://doc.scrapy.org/en/latest/topics/settings.html
http://scrapy.readthedocs.org/en/latest/topics/downloader-middleware.html
http://scrapy.readthedocs.org/en/latest/topics/spider-middleware.html
BOT_NAME = 'mercado'
SPIDER_MODULES = ['mercado.spiders']
NEWSPIDER_MODULE = 'mercado.spiders'
Crawl responsibly by identifying yourself (and your website) on the user-agent
USER_AGENT = 'Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20100101 Firefox/10.0'
Obey robots.txt rules
ROBOTSTXT_OBEY = True
Configure maximum concurrent requests performed by Scrapy (default: 16)
#CONCURRENT_REQUESTS = 32
Configure a delay for requests for the same website (default: 0)
See http://scrapy.readthedocs.org/en/latest/topics/settings.html#download-delay
See also autothrottle settings and docs
DOWNLOAD_DELAY = 2
The download delay setting will honor only one of:
#CONCURRENT_REQUESTS_PER_DOMAIN = 16
#CONCURRENT_REQUESTS_PER_IP = 16
Disable cookies (enabled by default)
#COOKIES_ENABLED = False
Disable Telnet Console (enabled by default)
#TELNETCONSOLE_ENABLED = False
Override the default request headers:
#DEFAULT_REQUEST_HEADERS = {
'Accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8',
'Accept-Language': 'en',
#}
Enable or disable spider middlewares
See http://scrapy.readthedocs.org/en/latest/topics/spider-middleware.html
#SPIDER_MIDDLEWARES = {
'bitcointalk_bot.middlewares.TutorialSpiderMiddleware': 543,
#}
Enable or disable downloader middlewares
See http://scrapy.readthedocs.org/en/latest/topics/downloader-middleware.html
DOWNLOADER_MIDDLEWARES = {
'mercado.middlewares.CloudFlareMiddleware': 560
}
Enable or disable extensions
See http://scrapy.readthedocs.org/en/latest/topics/extensions.html
#EXTENSIONS = {
'scrapy.extensions.telnet.TelnetConsole': None,
#}
Configure item pipelines
See http://scrapy.readthedocs.org/en/latest/topics/item-pipeline.html
ITEM_PIPELINES = {
'mercado.pipelines.MercadoPipeline': 100,
}
Enable and configure the AutoThrottle extension (disabled by default)
See http://doc.scrapy.org/en/latest/topics/autothrottle.html
AUTOTHROTTLE_ENABLED = True
The initial download delay
AUTOTHROTTLE_START_DELAY = 2
The maximum download delay to be set in case of high latencies
#AUTOTHROTTLE_MAX_DELAY = 60
The average number of requests Scrapy should be sending in parallel to
each remote server
AUTOTHROTTLE_TARGET_CONCURRENCY = 2.0
Enable showing throttling stats for every response received:
#AUTOTHROTTLE_DEBUG = False
Enable and configure HTTP caching (disabled by default)
See http://scrapy.readthedocs.org/en/latest/topics/downloader-middleware.html#httpcache-middleware-settings
#HTTPCACHE_ENABLED = True
#HTTPCACHE_EXPIRATION_SECS = 0
#HTTPCACHE_DIR = 'httpcache'
#HTTPCACHE_IGNORE_HTTP_CODES = []
#HTTPCACHE_STORAGE = 'scrapy.extensions.httpcache.FilesystemCacheStorage'"
And my middleware.py as yours:
-- coding: utf-8 --
Define here the models for your spider middleware

See documentation in:
http://doc.scrapy.org/en/latest/topics/spider-middleware.html
from scrapy import signals
from cfscrape import get_tokens
import logging
class MercadoSpiderMiddleware(object):
# Not all methods need to be defined. If a method is not defined,
# scrapy acts as if the spider middleware does not modify the
# passed objects.
@classmethod
def from_crawler(cls, crawler):
    # This method is used by Scrapy to create your spiders.
    s = cls()
    crawler.signals.connect(s.spider_opened, signal=signals.spider_opened)
    return s

def process_spider_input(self, response, spider):
    # Called for each response that goes through the spider
    # middleware and into the spider.

    # Should return None or raise an exception.
    return None

def process_spider_output(self, response, result, spider):
    # Called with the results returned from the Spider, after
    # it has processed the response.

    # Must return an iterable of Request, dict or Item objects.
    for i in result:
        yield i

def process_spider_exception(self, response, exception, spider):
    # Called when a spider or process_spider_input() method
    # (from other spider middleware) raises an exception.

    # Should return either None or an iterable of Response, dict
    # or Item objects.
    pass

def process_start_requests(self, start_requests, spider):
    # Called with the start requests of the spider, and works
    # similarly to the process_spider_output() method, except
    # that it doesn’t have a response associated.

    # Must return only requests (not items).
    for r in start_requests:
        yield r

def spider_opened(self, spider):
    spider.logger.info('Spider opened: %s' % spider.name)

Thank you clemfromspace for this middlware
https://github.com/clemfromspace/scrapy-cloudflare-middleware
class CloudFlareMiddleware:
"""Scrapy middleware to bypass the CloudFlare's anti-bot protection"""
@staticmethod
def is_cloudflare_challenge(response):
    """Test if the given response contains the cloudflare's anti-bot protection"""

    return (
        response.status == 200
        and response.headers.get('Server', '').startswith(b'cloudflare')
        and 'jschl_vc' in response.text
        and 'jschl_answer' in response.text
    )

def process_response(self, request, response, spider):
    """Handle the a Scrapy response"""

    if not self.is_cloudflare_challenge(response):
        return response

    logger = logging.getLogger('cloudflaremiddleware')

    logger.debug(
        'Cloudflare protection detected on %s, trying to bypass...',
        response.url
    )

    cloudflare_tokens, __ = get_tokens(
        request.url,
        user_agent=spider.settings.get('USER_AGENT')
    )

    logger.debug(
        'Successfully bypassed the protection for %s, re-scheduling the request',
        response.url
    )

    request.cookies.update(cloudflare_tokens)
    request.priority = 99999

    return request

Can you help me?

From: Andre Fritsche<EMAIL_ADDRESS>Sent: Sunday, July 15, 2018 3:25 PM
To: clemfromspace/scrapy-cloudflare-middleware
Cc: Godtooro; Comment
Subject: Re: [clemfromspace/scrapy-cloudflare-middleware] ModuleNotFoundError: No module named 'scraping_hub' (#1)
I found a way. It is not the best one but it works for my purpose. Just use the good old copy&paste. There is an example within my bitcointalk scraper repostiotry, how I included this middleware. Although bitcointalk doesn't use cloudflare at the moment.

Middlware: https://github.com/ihgalis/bitcointalk_scraper/blob/master/bitcointalk_bot/middlewares.py#L65

Settings: https://github.com/ihgalis/bitcointalk_scraper/blob/master/bitcointalk_bot/settings.py#L56

Maybe it helps ...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/clemfromspace/scrapy-cloudflare-middleware/issues/1#issuecomment-405099030, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AnPsirib8mNplVLGpmvkDISpbt0mSCuBks5uG17PgaJpZM4Ukb0L.

Maybe obeying the robots.txt is the problem. Just have a look at it:
https://www.mister-auto.es/robots.txt
You can change this within the settings: ROBOTSTXT_OBEY = False
And in general: Always try to see the websites without javascript. Just install NoScript or something similiar into your browser and see the page as it is seen by scrapy (not exactly but at least without javascript). Sometimes your crawler doesn't work because contents may be provided with javascript. If you encounter this problem also have a look at the splash middleware: https://github.com/scrapy-plugins/scrapy-splash
Good luck!

Hey there, actually the README was wrong, I fixed it, you should put scrapy_cloudflare_middleware.middlewares.CloudFlareMiddleware in your DOWNLOADER_MIDDLEWARES settings.


Add a code of conduct

👉  Click here to view the rendered version of the doc
This is a lightly edited version of the Rust CoC.

The first section is taken from Contributor Covenant
The other sections are taken from the Rust CoC verbatim

Attribution
This Code of Conduct is based on the Rust Code of Conduct, which is adapted from the Node.js Policy on Trolling as well as the Contributor Covenant version 1.3; and also the WeAllJS Code of Conduct, which is itself based on Contributor Covenant version 1.4, and the LGBTQ in Technology Slack Code of Conduct.

I'm very happy with the current iteration. Thank you so much for the work you put into this (and for facilitating the discussion on discord).


🐛 Bug Report: Directions of dropdown arrow misaligned.

📜 Description
Direction of dropdown arrow should be downwards when not selected and upwards when selected.

👟 Reproduction steps
Go to main page. See the sidebar.
👍 Expected behavior
Direction of dropdown arrow should be downwards when not selected and upwards when selected.
👎 Actual Behavior with Screenshots

💻 Operating system
Windows
What browsers are you seeing the problem on?
Chrome
🤖 What development environment are you experiencing this bug on?
Docker
🔒 Did you set the correct environment variables in the right path? List the environment variable names (not values please!)
No response
📃 Provide any additional context for the Bug.
No response
📖 Relevant log output
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🔗 Are you willing to submit PR?
Yes, I am willing to submit a PR!
🧑⚖ Code of Conduct

[X] I agree to follow this project's Code of Conduct

@dartpain Please assign me this issue.


Remove type: module

Author of the package mentioned potentially removing the type:module to make this package work again under Webpack 5.
Checklist

[ ] My commits follow Conventional Commits
[ ] documentation is updated

Resolved in #676


hmac settings failed

reference the link https://www.trustwave.com/en-us/resources/blogs/spiderlabs-blog/modsecurity-advanced-topic-of-the-week-hmac-token-protection/
I try to configure hmac in modsecurity, but the homepage is loaded disorderly。
hmac_debug file

hmac config file

old page

destory page

system version MacOS10.15
modsecurity version:2.9.2
nginx version:1.11.12
And I found the same problem on ubuntu(4.8.2-19)

Closing as a duplicate of:  https://github.com/SpiderLabs/ModSecurity/issues/2450


Upgrade @rjsf v5 dependencies to beta.17

Signed-off-by: Paul Cowan<EMAIL_ADDRESS>Hey, I just made a Pull Request!
It would be good to test the recent beta.17 changes in the @rjsf/-v5 dependencies.
This PR also moves back to using the @rjsf/validator-ajv8 validator.
:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

@dagda - there's beta.18 now, do you want to move to that instead? Also, not sure if we're going to get a release before they go stable so you might have to test it with the nightlies but does that work ok for you?

@dagda - there's beta.18 now. Do you want to move to that instead? Also, not sure if we're going to get a release before they go stable so you might have to test it with the nightlies but does that work ok for you?

Good catch. I did not check for any upgrades.  Nightlies are perfect for testing.
I've upgraded, and formData is now optional, so please check my logic for adding an initializer in the Stepper onSubmit.


Add type hinting to CascadeDirection comperator

This should decrease the compile. Should resolve issue #400

Thank you very much. this helps a lot! I've never worried about compilation time before. Now it brings my attention.

I've also checked it. Everything is fine, good job BennX!
lkzhao, you are a lucky developer! I've seen projects with 1-3 minutes of wasted time during each compilation. So, each time I get a new swift project, the first thing I do is searching for slow compiling functions. To prevent the project from being "slow" compiling I usually simplify everything like this:
let red = parameters.getCGFloat(0) ?? 1
let green = parameters.getCGFloat(1) ?? 1
let blue = parameters.getCGFloat(2) ?? 1
let color = UIColor(red: red, green: green, blue: blue, alpha: 1)
let opacity = parameters.getCGFloat(3) ?? 1
return .overlay(color: color, opacity: opacity)

instead of using a one line solution
return .overlay(color: UIColor(red: parameters.getCGFloat(0) ?? 1, green: parameters.getCGFloat(1) ?? 1, blue: parameters.getCGFloat(2) ?? 1, alpha: 1), opacity: parameters.getCGFloat(3) ?? 1)

@Ikzhao @iwheelbuy glad to help 😊 was a simple and nice fix. Hope the speed up is good enough.


Naming convention for parameter names

The JSON code
"teststring-1"  : "teststring-1 value",
${teststring-1} : "${teststring-1} extended"

causes
'The variable '${teststring-1}' is not available!'
Reason is the minus character inside the parameter name.
Outcome: We need to define and publish a naming convention for parameter names.
If minus characters are allowed, the expected value is:
{'teststring-1': 'teststring-1 value extended'}
If minus characters are not allowed, the expected result is an error message telling about a naming convention violation.
But that the variable is not available, should not happen.

Hi Holger,
we should allow

starting with letter / capital letter / underscore /
followed
letter / capital letter / number / underscore "_" / dot "."
identically to the python rules.

According to this rules
"teststring-1"  : "teststring-1 value",
should raise an error that "-" is not allowed as part of a variable.
Now this brings me really in trouble...
On jsonpreprocessor level it is allowed to define a variable with hyphen, json has no limitations for names, even spaces should be allowed as key?
But: What is RobotFramework core doing if it reaches there?
Thank you,
Thomas

Hi Thomas,
we should start with a smooth naming convention for stand alone JsonPreprocessor.
If it is necessary to strengthen this in case of the JsonPreprocessor is used in the context of RobotFramework AIO, this would be an issue for the TestsuitesManagement.

Update:
Now the error message is:
Error: 'The variable '${teststring-11}' is not available!'!
Suddenly '11' instead of '1'. From where does the '11' come from?

Still open.

Update:
Now the error message is:
Error: 'The variable '${teststring-11}' is not available!'!
Suddenly '11' instead of '1'. From where does the '11' come from?

Hello Holger, I pushed new commit 2c562386eef to stabi branch to correct the error message issue above.
Hello @test-fullautomation, can we move this naming convention ticket to next release after we have a discussion about this ticket.
Thank you,
Son

'11' issue from
https://github.com/test-fullautomation/python-jsonpreprocessor/issues/157#issuecomment-1822774616
is solved.

To answer the question in
https://github.com/test-fullautomation/python-jsonpreprocessor/issues/157#issuecomment-1746903631
JSON code passed to JsonPreprocessor:
"teststring-1"  : "teststring-1 value",
${teststring-1} : "teststring-1 value new",
${teststring-1} : "${teststring-1} extended"

Outcome:
Error: 'The variable '${teststring-1} ' is not available!'!
Same JSON code - but with added scope 'params.global' - passed to TestsuitesManagement:
"teststring-1"  : "teststring-1 value",
${params.global.teststring-1} : "teststring-1 value new",
${params.global.teststring-1} : "${params.global.teststring-1} extended",

Works fine. Value of ${teststring-1} is: 'teststring-1 value new extended'
Astonishing that the TestsuitesManagement works properly with code, that is not accepted by the JsonPreprocessor.
Why does the JsonPreprocessor not pass his error to the TestsuitesManagement?
Which behavior is the desired one?

Cross check with asterisk inside parameter name:
JsonPreprocessor:
"teststring*1"  : "teststring*1 value",
${teststring*1} : "teststring*1 value new",
${teststring*1} : "${teststring*1} extended"

TestsuitesManagement:
"teststring*1"  : "teststring*1 value",
${params.global.teststring*1} : "teststring*1 value new",
${params.global.teststring*1} : "${params.global.teststring*1} extended",

Outcome: Both components react with error: "Invalid parameter format in line: ..."

Hi Holger,
can I close this ticket?
Thank you,
Thomas

Hi Thomas,
some questions still not clarified:
Astonishing that the TestsuitesManagement works properly with code, that is not accepted by the JsonPreprocessor.
Why does the JsonPreprocessor not pass his error to the TestsuitesManagement?
Which behavior is the desired one?

https://github.com/test-fullautomation/python-jsonpreprocessor/issues/157#issuecomment-1907774471

Retest successful.
Both JsonPreprocessor and TestsuitesManagement are able to handle a parameter with name 'teststring-1'
Issue can be closed.

integrated in RobotFramework AIO 0.11.0


My one gripe with this app

When you type in your State and Details, on the rich presence, you'd expect the state on top and the details on the bottom. But in discord it's the other way around. So this just clears that up

sure


Any way to set slaveAgentPort

Wonder if there is neat way to set slaveAgentPort. This is allow plugins to be installed using this role module

I added task in setting.xml same as previous ticket

name: Modify slaveport in config file
lineinfile:
dest: "{{ jenkins_home }}/config.xml"
regexp: ''
line: '{{ slaveAgentPort }}'
state: present


Update bitcoin node version

Adds a script gen-sample-contract.sh that creates a contract an hour in the future instead of manually editing.
Updates the bitcoin-core image to the latest. In doing this, the wallets have to be legacy for the RPC client to work. The RPC client will have to update to use descriptors in the derive_contract_signer method.

If you rebase on master the clippy errors should be gone.


undefined method zero?' for {:exact_text=>"somestring"}:Hash for wait_until__invisible(text: 'somestring')

Environment

Operating System: Mac
Capybara: 2.18, Site_Prism: 2.11
RSpec 3.7.0 (e2e tests without rails app)
Chrome 66.0.3359.181, chromedriver=2.37.544337

Expected Behavior
I expected Capybara Query options to work - https://github.com/natritmeyer/site_prism#methods-supporting-capybara-options
I have a method:
  def save_question
    submit_btn(text: 'Add').click
    wait_until_submit_btn_invisible(text: 'Add')
  end

submit_btn(text: 'Add').click works as intended.
Basing on the doc linked above, I would assume that if this @results_page.wait_until_<element_or_section_name>_invisible(text: 'Some ajaxy text disappears!') works, then wait_until_submit_btn_invisible(text: 'Add') should work.
Actual Behavior
wait_until_submit_btn_invisible(text: 'Add')
raises the following error:
 NoMethodError:
       undefined method `zero?' for {:exact_text=>"Add"}:Hash
     # /Users/anks/.rvm/gems/ruby-2.5.1/gems/site_prism-2.11/lib/site_prism/element_container.rb:156:in `block (2 levels) in create_invisibility_waiter'
     # ./support/sections/jobs/screening_questions_section.rb:52:in `save_question'
     # ./spec/jobs/screening_questions_spec.rb:42:in `block (4 levels) in <top (required)>'
     # /Users/anks/.rvm/gems/ruby-2.5.1/gems/rspec-retry-0.5.7/lib/rspec/retry.rb:115:in `block in run'
     # /Users/anks/.rvm/gems/ruby-2.5.1/gems/rspec-retry-0.5.7/lib/rspec/retry.rb:104:in `loop'
     # /Users/anks/.rvm/gems/ruby-2.5.1/gems/rspec-retry-0.5.7/lib/rspec/retry.rb:104:in `run'
     # /Users/anks/.rvm/gems/ruby-2.5.1/gems/rspec-retry-0.5.7/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
     # /Users/anks/.rvm/gems/ruby-2.5.1/gems/rspec-retry-0.5.7/lib/rspec/retry.rb:33:in `block (2 levels) in setup'

If I use simply wait_until_submit_btn_invisible without the query option, it works without error.
Also, look at this:
[3] pry(#<JobsScreeningQuestionsSection>)> has_no_submit_btn?(text: 'Add')
=> true
[4] pry(#<JobsScreeningQuestionsSection>)> wait_until_submit_btn_invisible(text: 'Add')
NoMethodError: undefined method `zero?' for {:text=>"Add"}:Hash
from /Users/anks/.rvm/rubies/ruby-2.5.1/lib/ruby/2.5.0/timeout.rb:76:in `timeout'

Not sure if this is an error or am I just using the query option incorrectly.

We have seen similar issues to this occurring due to frame usage. Can you attach a small sample page we can re-run this test against.
We have unit / feature tests for this specific use case which run successfully. So it's likely there could be some frame interfering.
Could you also attach your POM file, so we can see how your defining your selectors.

@luke-hill I've put everything here https://gist.github.com/matisnape/a5480e83af17a89d82a4488b97480280
This page is built with Angular components, if that's helpful.
Let me know if you need more details.

There are some tickets in which will fix some issues and possibly this.
However should these not work, are you able to (Not yet), produce a smaller more concise example. I logged in to that webpage and there is way too much going on. Ideally we'd want something in a single webpage, with a small example. See http://sscce.org/ for tips.

If the above is proving problematic you can see if using the latest uncut master works for you.
Amend your gemfile to point to our master branch. And that should be enough to give it a trial. Note that this is still unreleased, so could have some unknown issues.

Closing as fixed in 12478a4170d44521da6eb27921909313e75ec5c7


I need to display the email editor in browser like in UI Screen, which am using angular and HTML

I'm trying to build an email editor using pure Angular and HTML. I need to be able to read the content from the editor, insert custom HTML elements, and display the result on the screen. I've managed to configure the editor to render, but it's not appearing in the UI. Can you help me troubleshoot this issue?

The project is written in React and meant to be used with React applications. We cannot help troubleshoot an angular issue.

Thank you


Various app polish tasks (need to be broken apart)

Expected Behavior
Polish in this doc completed: https://docs.google.com/document/d/1thh3gXycni84bc7GWNO6Pxkiy--x0JEM54gvL-UigzM/edit
Current Behavior
Not all finished

Created #836 #837 #838
Other issues in the doc are already fixed.


Cant pass custom Ref from Functional component

So i'm using 'hooks'
function TaskColumn({ title, children }) {
  const taskFieldRef = useRef()

Then in rendrer i'm trying to pass my ref
<TextareaAutosize
              innerRef={taskFieldRef}
              className='AddTaskField'
              value={newTaskField.value}
              placeholder={newTaskField.config.label}
              onChange={event => fieldChangedHandler(event)}
            />

But its not working. Can you maybe explain why and how to do it with hooks?

It's inputRef, not innerRef.

It's still failing. Says Uncaught TypeError: _this.props.inputRef is not a function. You got a ref object not a function from the useRef hook.

Could you prepare a runnable repro case?

I've released the new major version which uses forwardRef under the hood so you should be able to just use ref prop now without any problems.


Script errors out - The term 'Get-AzureADDirectorySetting' is not recognized as the name of a cmdlet

Uninstalled AzureAD module, installed <IP_ADDRESS> AzureADPreview module and am getting this error when I run the script:
Get-AzureADDirectorySetting : The term 'Get-AzureADDirectorySetting' is not recognized as the name of a cmdlet,
function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the
path is correct and try again.
as well as for:
Get-AzureADDirectorySettingTemplate
New-AzureADDirectorySetting
$PSVersionTable.PSVersion
Major  Minor  Build  Revision

5      1      22621  963

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 445c0a2e-1a22-d90f-0c73-0edf34f2b99a
Version Independent ID: d534ac69-134d-0198-fcb9-e19d1ed44d4b
Content: Manage who can create Microsoft 365 Groups
Content Source: microsoft-365/solutions/manage-creation-of-groups.md
Service: o365-solutions
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@TheDeuceYouSay Thank you for your feedback. I was able to test this and it works fine.

If you continue to have an issue, I'd recommend opening a support ticket via the need help section on the admin center.
Hope this helps!
Thanks
Sri


build(deps): move prettier to dev dependencies

What Changed
having prettier in the dependency list causes all packages using this package to download this version of prettier - causing possible version conflicts for formatting their own code
How to test
run prettier - if it still works it works
Change Type

[x] maintenance
[ ] documentation
[ ] patch
[x] minor
[ ] major

closing in favor of https://github.com/storybookjs/mdx1-csf/pull/14 @shilman