[Question] What do you think about change Api instance constructor params ?

I guess it is not a good solution:

HttpClient.ts

  constructor(apiConfig: ApiConfig<SecurityDataType> = {}) {
    Object.assign(this, apiConfig);
  }

For example, with --modular option the field securityWorker doesn't make any sense.
Because I should send securityWorker for each modular api instance

const API_CONFIG = {
  baseUrl: `${process.env.NODE_ENV === "production" ? location.origin : process.env.API_URL}/api/v1`,
  baseApiParams: {
    headers: {
      "Content-Type": ContentType.Json,
    },
  },
  securityWorker: (token) =>
    token
      ? {
          headers: {
            Authorization: token,
          },
        }
      : {},
};

export const api = {
  auth: new Auth(API_CONFIG),
  jobs: new Jobs(API_CONFIG),
};

I think would be better if I will send HttpClient instance to each Api constructor. 🤔

const httpClient = new HttpClient<string>({
  baseUrl: `${process.env.NODE_ENV === "production" ? location.origin : process.env.API_URL}/api/v1`,
  baseApiParams: {
    headers: {
      "Content-Type": ContentType.Json,
    },
  },
  securityWorker: (token) =>
    token
      ? {
          headers: {
            Authorization: token,
          },
        }
      : {},
});

export const api = {
  http: httpClient,
  auth: new Auth(httpClient),
  jobs: new Jobs(httpClient),
};

and generated Api:
export class Auth<SecurityDataType = unknown> {

  constructor(private http: HttpClient<SecurityDataType>) {}

  // methods
}

I will create the CLI flag for this solution

https://github.com/acacode/swagger-typescript-api/blob/next/tests/spec/singleHttpClient/schema.ts#L225

It will at the next release with the --single-http-client cli option


Updated libuavcan to 883cba97 + NuttX IRQ patch

@dagar @LorenzMeier @DanielePettenuzzo
This is a continuation of https://github.com/PX4/Firmware/pull/9219
This is current libuavcan @ 883cba97 with the upstream NuttX IRQ changes needed since NuttX 7.22
Depending on how @pavel-kirienko takes in the pr https://github.com/UAVCAN/libuavcan/pull/134 we can repoint this to master or keep it on the branch if @pavel-kirienko feels we need to support NuttX < 7.22

Updated to libuavcan master after https://github.com/UAVCAN/libuavcan/pull/134 merged.

@dagar @DanielePettenuzzo @LorenzMeier - the update of libuavcan was not a fix for https://github.com/PX4/Firmware/issues/9648 but this is https://github.com/PX4/Firmware/pull/9652 https://github.com/PX4/Firmware/commit/e295f7100dd9c1194860a12ea2ed626cff051149

@davids5 yes I only wondering if it's worth considering in that context as well.


bug: PHP Symbol Outline Not Hierarchical when using LSP

Neovim version (nvim -v)
v0.9.5
Operating system/version
Fedora Linux 39
Output of :AerialInfo
Aerial Info
-----------
Filetype: php
Configured backends:
  lsp (supported) (attached)
  treesitter (supported)
  markdown (not supported) [Filetype is not markdown]
  man (not supported) [Filetype is not man]
Show symbols: all symbols

Describe the bug
I installed intelephense as my LSP server on Neovim, I have treesitter as well for my code highlighting. When aerial uses LSP for outlining the code, I don't see any indentation on symbols outline:
󰌗 MusaSpecialUsersListTable
 __construct
󰆧 get_columns
󰆧 column_default
󰀫 $item
󰀫 $column_name
󰀫 $wpdb
󰆧 get_sortable_columns
󰆧 prepare_items
󰀫 $wpdb
󰀫 $per_page
󰀫 $current_page
󰀫 $total_items
󰀫 $columns
󰀫 $hidden
󰀫 $sortable
󰀫 $order
󰀫 $orderby

However it's fine if I prioritize treesitter over lsp, it works fine. I don't want to do that because treesitter only shows functions and classes :(
󰌗 MusaSpecialUsersListTable
├ 󰆧 __construct
├ 󰆧 get_columns
├ 󰆧 column_default
├ 󰆧 get_sortable_columns
├ 󰆧 prepare_items
├ 󰆧 column_cb
├ 󰆧 column_user
├ 󰆧 get_bulk_actions
├ 󰆧 handle_row_actions
└ 󰆧 single_row
󰊕 musa_users_page
󰊕 musa_get_wp_users_callback
󰊕 musa_add_special_user_callback
󰊕 musa_users_inline_edit_callback

I though it might be LSP problem but intelephense works fine on other editors.
What is the severity of this bug?
tolerable (can work around it)
Steps To Reproduce
I use AstroNvim for my base setup so...

Install AstroNvim
Install intelephense LSP server, this is my custom config for intelephese:

    intelephense = function(opts)
      opts.root_dir = function() return vim.loop.cwd() end
      local key = io.open(os.getenv "HOME" .. "/intelephense/license", "rb")
      if not key then return opts end
      opts.init_options = { licenceKey = key:read "*all" }
      key:close()
      return opts
    end,

Open a PHP file
Open the aerial outline window or use the top heirline to see the position in code

Expected Behavior
It would be great if aerial shows the hierarchical of the symbols, like this:
󰌗 MusaSpecialUsersListTable
├  __construct
├ 󰆧 get_columns
├ 󰆧 column_default
│ ├ 󰀫 $item
│ ├ 󰀫 $column_name
│ └ 󰀫 $wpdb
├ 󰆧 get_sortable_columns
└  󰆧 prepare_items
  ├ 󰀫 $wpdb
  ├ 󰀫 $per_page
  ├ 󰀫 $current_page
  ├ 󰀫 $total_items
  ├ 󰀫 $columns
  ├ 󰀫 $hidden
  ├ 󰀫 $sortable
  ├ 󰀫 $order
  └ 󰀫 $orderby

Minimal example file
No response
Minimal init.lua
No response
Additional context
No response

I am very skeptical that the LSP is returning items in a hierarchy, when LSP servers do that we display the symbols in a hierarchy.
First, double check that your LSP server is up-to-date, then run :LspInfo to confirm that only intelephense is attached to your buffer. Then, run the following code (preferably on a small sample file):
local bufnr = vim.api.nvim_get_current_buf()
local params = { textDocument = vim.lsp.util.make_text_document_params(bufnr) }
local client = vim.lsp.get_active_clients({ bufnr = bufnr })[1]
client.request("textDocument/documentSymbol", params, function(err, result, ctx, config)
	vim.print(result)
end, bufnr)

This should print some output (which you can see with :messages), which will allow us to see the raw data that the server is actually giving us.

I also thought that LSP is missing something but as it worked well on both VS Code and Gnome builder I thought it probably is not LSP.
This is the output of the lua code above:
          start = {
            character = 9,
            line = 36
          }
        },
        selectionRange = {
          ["end"] = {
            character = 14,
            line = 36
          },
          start = {
            character = 9,
            line = 36
          }
        }
      }, {
        kind = 13,
        name = "$product",
        range = {
          ["end"] = {
            character = 10,
            line = 37
          },
          start = {
            character = 2,
            line = 37
          }
        },
        selectionRange = {
          ["end"] = {
            character = 10,
            line = 37
          },
          start = {
            character = 2,
            line = 37
          }
        }
      }, {
        kind = 13,
        name = "$musa_product",
        range = {
          ["end"] = {
            character = 15,
            line = 42
          },
          start = {
            character = 2,
            line = 42
          }
        },
        selectionRange = {
          ["end"] = {
            character = 15,
            line = 42
          },
          start = {
            character = 2,
            line = 42
          }
        }
      } },
    kind = 12,
    name = "musa_get_product",
    range = {
      ["end"] = {
        character = 1,
        line = 48
      },
      start = {
        character = 0,
        line = 33
      }
    },
    selectionRange = {
      ["end"] = {
        character = 25,
        line = 33
      },
      start = {
        character = 9,
        line = 33
      }
    }
  }, {
    children = { {
        kind = 13,
        name = "$user",
        range = {
          ["end"] = {
            character = 40,
            line = 59
          },
          start = {
            character = 28,
            line = 59
          }
        },
        selectionRange = {
          ["end"] = {
            character = 33,
            line = 59
          },
          start = {
            character = 28,
            line = 59
          }
        }
      }, {
        kind = 13,
        name = "$limit",
        range = {
          ["end"] = {
            character = 53,
            line = 59
          },
          start = {
            character = 42,
            line = 59
          }
        },
        selectionRange = {
          ["end"] = {
            character = 48,
            line = 59
          },
          start = {
            character = 42,
            line = 59
          }
        }
      }, {
        kind = 13,
        name = "$start",
        range = {
          ["end"] = {
            character = 65,
            line = 59
          },
          start = {
            character = 55,
            line = 59
          }
        },
        selectionRange = {
          ["end"] = {
            character = 61,
            line = 59
          },
          start = {
            character = 55,
            line = 59
          }
        }
      }, {
        kind = 13,
        name = "$wpdb",
        range = {
          ["end"] = {
            character = 14,
            line = 62
          },
          start = {
            character = 9,
            line = 62
          }
        },
        selectionRange = {
          ["end"] = {
            character = 14,
            line = 62
          },
          start = {
            character = 9,
            line = 62
          }
        }
      } },
    kind = 12,
    name = "musa_get_withdraws",
    range = {
      ["end"] = {
        character = 1,
        line = 81
      },
      start = {
        character = 0,
        line = 50
      }
    },
    selectionRange = {
      ["end"] = {
        character = 27,
        line = 59
      },
      start = {
        character = 9,
        line = 59
      }
    }
  } }

I didn't understand much of it 😅

I'm not really familiar with how LSP works but based on this output I think LSP is fine...
This is the code I tested it on with the aerial outline near:

And this is the output of the code:
{ {
    kind = 5,
    location = {
      range = {
        ["end"] = {
          character = 1,
          line = 30
        },
        start = {
          character = 6,
          line = 2
        }
      },
      uri = "file:///home/mahdi/Documents/aerial/main.php"
    },
    name = "Calculator"
  }, {
    containerName = "Calculator",
    kind = 7,
    location = {
      range = {
        ["end"] = {
          character = 16,
          line = 5
        },
        start = {
          character = 9,
          line = 5
        }
      },
      uri = "file:///home/mahdi/Documents/aerial/main.php"
    },
    name = "$result"
  }, {
    containerName = "Calculator",
    kind = 9,
    location = {
      range = {
        ["end"] = {
          character = 3,
          line = 11
        },
        start = {
          character = 18,
          line = 8
        }
      },
      uri = "file:///home/mahdi/Documents/aerial/main.php"
    },
    name = "__construct"
  }, {
    containerName = "Calculator",
    kind = 6,
    location = {
      range = {
        ["end"] = {
          character = 3,
          line = 17
        },
        start = {
          character = 18,
          line = 14
        }
      },
      uri = "file:///home/mahdi/Documents/aerial/main.php"
    },
    name = "add"
  }, {
    containerName = "add",
    kind = 13,
    location = {
      range = {
        ["end"] = {
          character = 26,
          line = 14
        },
        start = {
          character = 22,
          line = 14
        }
      },
      uri = "file:///home/mahdi/Documents/aerial/main.php"
    },
    name = "$num"
  }, {
    containerName = "Calculator",
    kind = 6,
    location = {
      range = {
        ["end"] = {
          character = 3,
          line = 23
        },
        start = {
          character = 18,
          line = 20
        }
      },
      uri = "file:///home/mahdi/Documents/aerial/main.php"
    },
    name = "subtract"
  }, {
    containerName = "subtract",
    kind = 13,
    location = {
      range = {
        ["end"] = {
          character = 31,
          line = 20
        },
        start = {
          character = 27,
          line = 20
        }
      },
      uri = "file:///home/mahdi/Documents/aerial/main.php"
    },
    name = "$num"
  }, {
    containerName = "Calculator",
    kind = 6,
    location = {
      range = {
        ["end"] = {
          character = 3,
          line = 29
        },
        start = {
          character = 18,
          line = 26
        }
      },
      uri = "file:///home/mahdi/Documents/aerial/main.php"
    },
    name = "getResult"
  }, {
    kind = 13,
    location = {
      range = {
        ["end"] = {
          character = 5,
          line = 33
        },
        start = {
          character = 0,
          line = 33
        }
      },
      uri = "file:///home/mahdi/Documents/aerial/main.php"
    },
    name = "$calc"
  } }

This is using the deprecated SymbolInformation structure for the symbols, which cannot provide a hierarchy. From the spec:

SymbolInformation[] which is a flat list of all symbols found in a given text document. Then neither the symbol’s location range nor the symbol’s container name should be used to infer a hierarchy.

Allegedly Intelephense migrated off of that to DocumentSymbol in 2019 (source). You could try filing an issue with Intelephense asking if they could update their document symbol provider, but there's nothing aerial can do about this.

Oh, I thought the containerName in every single block is the parent of that symbol.
Anyway thank you so much for your response and the time you spent on this issue, I appreciate it so much.


splunksql: Add splunksql.OpenDB function

Add splunksql.OpenDB function for ones who dislike the sql.Open and splunksql.Open which use global state.
Something similar to https://pkg.go.dev/github.com/XSAM/otelsql#OpenDB
Desired API: func OpenDB(c driver.Connector, cfg InstrumentationConfig) *sql.DB.
We should also add OpenDB functions to all other sql-based instrumentation libraries that will use splunksql.OpenDB.
Implementation guidelines: https://github.com/signalfx/splunk-otel-go/pull/88#discussion_r711116734
Originally posted by @pellared in https://github.com/signalfx/splunk-otel-go/pull/88#discussion_r710032375

Waiting until anyone asks for this feature.

Is it possible to use this feature for dynamodb or s3 calls?

@ccoqueiro Can you be more precise in your question? If you ask about AWS DynamoDB and S3 instrumentation then it should be possible using the otelaws instrumentation library (here you can find also some AWS docs and here is an example usage)

Hi, we want splunksql.OpenDB function. We want to use pgx Connector's option (e.g. OptionAfterConnect) but we can't use it with splunksql.

@joshi-kamitsukasa Could you please add a snippet how would you use such function?
My guess is that it would rather prefer having  func OpenDB(config pgx.ConnConfig, opts ...stdlib.OptionOpenDB) *sql.DB added to  https://pkg.go.dev/github.com/signalfx/splunk-otel-go/instrumentation/github.com/jackc/pgx/v5/splunkpgx.
Of course we would need to create splunksql.OpenDB anyway 😉

@pellared Thanks for your reply.
For example below,
	return stdlib.OpenDB(*pgxConfig, []stdlib.OptionOpenDB{
		stdlib.OptionAfterConnect(func(ctx context.Context, conn *pgx.Conn) error {
			pgxdecimal.Register(conn.TypeMap())
			return setXxxxxFunc(ctx, conn)
		}),
		stdlib.OptionResetSession(setXxxxxFunc),
	}...), nil

We are going to contact support. Thanks.


Fix request/pipeling decision with 0 reqs

The trigger for when we should use a Request rather than Pipeline
should be when the client and the server agree on the tip, that is they
are both waiting on the next block to be forged.
Previously the descision to do a Request only happened when the server
was exactly one block ahead of us and we had no outstanding requests.

Fixes #2919.

bors r+


clean up use of word: simply

Create replacement text for word: simply.
Related to #17070.

/kind cleanup


docs: landing page

Follow-up to #2328. This moves the _index.htm file to ensure the docs landing page exists at the site root.
Signed-off-by: flynnduism<EMAIL_ADDRESS>
Description:

Affected area:

New Functionality      [ ]
Documentation          [x]
Install                [ ]
Control Plane          [ ]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Performance            [ ]
Other                  [ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

Preview link (from the Netlify deploy-preview check above):
https://deploy-preview-2396--osm-docs.netlify.app/

Preview link (from the Netlify deploy-preview check above):
https://deploy-preview-2396--osm-docs.netlify.app/


Git credentials failed

I'm having problems cloning the project using Windows. I'm the most current version of vscode and GIT. Everything seems to work, I can log into the amazon account. However, credential management seems to fail. When I try to download the project, during cloning it asks for a username and password and I don't know what to put, and I really shouldn't. I've tried everything, I've reinstalled everything and nothing works. I did a test on the iMac, and it works on the first try. Only in windows no. I don't know what else to do, can anyone help me.

[debug - 2021-07-01 11:35:55.203Z] Calling method: ask.container.viewAllSkills
[verbose - 2021-07-01 11:35:55.203Z] Calling method: ask.container.viewAllSkills.skillsQuickPick
[verbose - 2021-07-01 11:35:55.203Z] Calling method: ask.container.viewAllSkills.checkAndSetQpItems, args: [{"_extensionId":{"value":"ask-toolkit.alexa-skills-kit-toolkit","_lower":"ask-toolkit.alexa-skills-kit-toolkit"},"_id":3,"_visible":true,"_expectingHide":true,"_enabled":true,"_busy":false,"_ignoreFocusOut":true,"_value":"","_buttons":[{"iconPath":{"dark":{"$mid":1,"path":"/c:/Users/Kleber/.vscode/extensions/ask-toolkit.alexa-skills-kit-toolkit-2.6.0/third-party/resources/from-vscode-icons/dark/refresh.svg","scheme":"file"},"light":{"$mid":1,"path":"/c:/Users/Kleber/.vscode/extensions/ask-toolkit.alexa-skills-kit-toolkit-2.6.0/third-party/resources/from-vscode-icons/light/refresh.svg","scheme":"file"}},"tooltip":"Refresh skills"}],"_handlesToButtons":{},"_onDidAcceptEmitter":{"_disposed":false,"_listeners":{"_first":{"next":{},"prev":{}},"_last":{"next":{},"prev":{}},"_size":1}},"_onDidChangeValueEmitter":{"_disposed":false,"_listeners":{"_first":{"next":{},"prev":{}},"_last":{"next":{},"prev":{}},"_size":1}},"_onDidTriggerButtonEmitter":{"_disposed":false,"_listeners":{"_first":{"next":{},"prev":{}},"_last":{"next":{},"prev":{}},"_size":1}},"_onDidHideEmitter":{"_disposed":false},"_pendingUpdate":{"id":3},"_disposed":false,"_disposables":[{"_disposed":false,"_listeners":{"_first":{"next":{},"prev":{}},"_last":{"next":{},"prev":{}},"_size":1}},{"_disposed":false},{"_disposed":false,"_listeners":{"_first":{"next":{},"prev":{}},"_last":{"next":{},"prev":{}},"_size":1}},{"_disposed":false,"_listeners":{"_first":{"next":{},"prev":{}},"_last":{"next":{},"prev":{}},"_size":1}},{"_disposed":false},{"_disposed":false}],"_items":[],"_handlesToItems":{},"_itemsToHandles":{},"_canSelectMany":false,"_matchOnDescription":true,"_matchOnDetail":true,"_sortByLabel":true,"_activeItems":[],"_onDidChangeActiveEmitter":{"_disposed":false},"_selectedItems":[],"_onDidChangeSelectionEmitter":{"_disposed":false},"_title":"All skills"}]
[verbose - 2021-07-01 11:35:55.203Z] Calling method: ask.container.viewAllSkills.calculateTimeExceedHourly, args: [1625138813340,1625139355203,1]
[verbose - 2021-07-01 11:35:55.203Z] Calling method: ask.container.viewAllSkills.setQPItems, args: [{"_extensionId":{"value":"ask-toolkit.alexa-skills-kit-toolkit","_lower":"ask-toolkit.alexa-skills-kit-toolkit"},"_id":3,"_visible":true,"_expectingHide":true,"_enabled":true,"_busy":false,"_ignoreFocusOut":true,"_value":"","_buttons":[{"iconPath":{"dark":{"$mid":1,"path":"/c:/Users/Kleber/.vscode/extensions/ask-toolkit.alexa-skills-kit-toolkit-2.6.0/third-party/resources/from-vscode-icons/dark/refresh.svg","scheme":"file"},"light":{"$mid":1,"path":"/c:/Users/Kleber/.vscode/extensions/ask-toolkit.alexa-skills-kit-toolkit-2.6.0/third-party/resources/from-vscode-icons/light/refresh.svg","scheme":"file"}},"tooltip":"Refresh skills"}],"_handlesToButtons":{},"_onDidAcceptEmitter":{"_disposed":false,"_listeners":{"_first":{"next":{},"prev":{}},"_last":{"next":{},"prev":{}},"_size":1}},"_onDidChangeValueEmitter":{"_disposed":false,"_listeners":{"_first":{"next":{},"prev":{}},"_last":{"next":{},"prev":{}},"_size":1}},"_onDidTriggerButtonEmitter":{"_disposed":false,"_listeners":{"_first":{"next":{},"prev":{}},"_last":{"next":{},"prev":{}},"_size":1}},"_onDidHideEmitter":{"_disposed":false},"_pendingUpdate":{"id":3},"_disposed":false,"_disposables":[{"_disposed":false,"_listeners":{"_first":{"next":{},"prev":{}},"_last":{"next":{},"prev":{}},"_size":1}},{"_disposed":false},{"_disposed":false,"_listeners":{"_first":{"next":{},"prev":{}},"_last":{"next":{},"prev":{}},"_size":1}},{"_disposed":false,"_listeners":{"_first":{"next":{},"prev":{}},"_last":{"next":{},"prev":{}},"_size":1}},{"_disposed":false},{"_disposed":false}],"_items":[],"_handlesToItems":{},"_itemsToHandles":{},"_canSelectMany":false,"_matchOnDescription":true,"_matchOnDetail":true,"_sortByLabel":true,"_activeItems":[],"_onDidChangeActiveEmitter":{"_disposed":false},"_selectedItems":[],"_onDidChangeSelectionEmitter":{"_disposed":false},"_title":"All skills"}]
[verbose - 2021-07-01 11:35:55.203Z] Calling method: getCachedSkills, args: [null]
[verbose - 2021-07-01 11:35:55.203Z] Calling method: getSkillNameFromLocales, args: [{"pt-BR":"cake time"},null]
[error - 2021-07-01 11:35:55.219Z] Telemetry is disabled. Not uploading any data..
[verbose - 2021-07-01 11:35:56.853Z] Calling method: getSkillMetadata, args: ["amzn1.ask.skill.189f96d7-93b1-4cc3-bab1-b77d10e046f7","development"]
[debug - 2021-07-01 11:35:57.103Z] Calling method: askContainer.skillsConsole.cloneSkill, args:  [{"data":{"skillSummary":{"_links":{"self":{"href":"/v1/skills/amzn1.ask.skill.189f96d7-93b1-4cc3-bab1-b77d10e046f7/stages/development/manifest"}},"apis":["custom"],"lastUpdated":"2021-06-22T18:42:41.075Z","nameByLocale":{"pt-BR":"cake time"},"publicationStatus":"DEVELOPMENT","skillId":"amzn1.ask.skill.189f96d7-93b1-4cc3-bab1-b77d10e046f7","stage":"development"},"hostedSkillMetadata":{"alexaHosted":{"repository":{"type":"GIT","url":"https://git-codecommit.us-east-1.amazonaws.com/v1/repos/189f96d7-93b1-4cc3-bab1-b77d10e046f7"},"runtime":"python3.7"}},"isHosted":true},"label":"amzn1.ask.skill.189f96d7-93b1-4cc3-bab1-b77d10e046f7"}]
[verbose - 2021-07-01 11:35:57.103Z] Calling method: createSkillFolder
[verbose - 2021-07-01 11:36:05.536Z] Calling method: getSkillNameFromLocales, args: [{"pt-BR":"cake time"},null]
[debug - 2021-07-01 11:36:05.536Z] Skill folder d:\Projetos Outros\Alexa\caketime already exists.
[debug - 2021-07-01 11:36:08.197Z] Confirmed skill folder overwrite option. Overwriting d:\Projetos Outros\Alexa\caketime.
[verbose - 2021-07-01 11:36:08.210Z] Calling method: cloneSkill, args:  [{"_proxy":{},"_handle":2}]
[verbose - 2021-07-01 11:36:08.210Z] Calling method: checkGitInstallation
[verbose - 2021-07-01 11:36:08.210Z] Calling method: isGitInstalled
[verbose - 2021-07-01 11:36:08.210Z] Executing git command : git --version
[verbose - 2021-07-01 11:36:08.701Z] Calling method: setupGitFolder
[verbose - 2021-07-01 11:36:09.050Z] Calling method: downloadGitCredentialScript, args:  ["d:\Projetos Outros\Alexa\caketime"]
[verbose - 2021-07-01 11:36:09.052Z] Executing git command : git init "d:\Projetos Outros\Alexa\caketime" --quiet
[verbose - 2021-07-01 11:36:09.470Z] Executing git command : git config --local credential.https://git-codecommit.us-east-1.amazonaws.com/v1/repos/189f96d7-93b1-4cc3-bab1-b77d10e046f7.helper ""
[verbose - 2021-07-01 11:36:09.890Z] Executing git command : git config --local --add credential.https://git-codecommit.us-east-1.amazonaws.com/v1/repos/189f96d7-93b1-4cc3-bab1-b77d10e046f7.helper "!'C:\Users\Kleber.ask\scripts\git-credential-helper' default amzn1.ask.skill.189f96d7-93b1-4cc3-bab1-b77d10e046f7"
[verbose - 2021-07-01 11:36:10.313Z] Executing git command : git config --local credential.https://git-codecommit.us-east-1.amazonaws.com/v1/repos/189f96d7-93b1-4cc3-bab1-b77d10e046f7.UseHttpPath true
[verbose - 2021-07-01 11:36:10.747Z] Executing git command : git remote add origin https://git-codecommit.us-east-1.amazonaws.com/v1/repos/189f96d7-93b1-4cc3-bab1-b77d10e046f7
[verbose - 2021-07-01 11:36:11.173Z] Calling method: getOrInstantiateGitApi
[error - 2021-07-01 11:36:54.445Z] Git folder setup failed for d:\Projetos Outros\Alexa\caketime. Reason: Failed to execute git {
"exitCode": 128,
"gitErrorCode": "AuthenticationFailed",
"gitCommand": "fetch",
"stdout": "",
"stderr": "warning: invalid credential line: Failed to fetch a LWA access token.\nfatal: Authentication failed for 'https://git-codecommit.us-east-1.amazonaws.com/v1/repos/189f96d7-93b1-4cc3-bab1-b77d10e046f7/'\n"
}
[error - 2021-07-01 11:36:54.459Z] Telemetry is disabled. Not uploading any data..
[error - 2021-07-01 11:36:54.460Z] Skill clone failed. Reason: Git folder setup failed for d:\Projetos Outros\Alexa\caketime. Reason: Failed to execute git {
"exitCode": 128,
"gitErrorCode": "AuthenticationFailed",
"gitCommand": "fetch",
"stdout": "",
"stderr": "warning: invalid credential line: Failed to fetch a LWA access token.\nfatal: Authentication failed for 'https://git-codecommit.us-east-1.amazonaws.com/v1/repos/189f96d7-93b1-4cc3-bab1-b77d10e046f7/'\n"
}
[error - 2021-07-01 11:36:54.461Z] Telemetry is disabled. Not uploading any data..

Hi @krsmga , are you still the issue on the latest VSCode extension?


[api doc] addvolume and removevolume have no body in our api reference

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What happened:
https://kubevirt.io/api-reference/v0.36.0/operations.html#_vm-addvolume has no body. The generated API doc is incomplete.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/assign @awels

/lifecycle frozen

@rmohr Does this mean I am just missing a 'consumes' for those? I am not entirely sure what I am missing.


Put components in different modules if this helps reduce the JS production bundle size

This may not be that necessary as Material Web's bundle sizes are not very big already.


v1.6.6 - Better podcast handling, more native UI and more

When podcast is playing, 15-sec rewind buttons are displayed instead of forwads/backwards buttons
Updated playback buttons to use more native icons
Playback buttons now animate on mouse hover
Improved hadnling of menu bar information for podcasts
New keyboard shortcut to show/hide popover
Lowered minimum menu bar item width from 100px to 75px
Code is a bit more optimised to make less background calls to Spotify/Apple Music
Background code maintenance and cleanup

/release


Arduboy2::drawFastVLine causes TypeError

Whenever I use drawFastVLine in a sketch, an error appears in the Log tab: "TypeError: Cannot set property 'title' of undefined." The issue does not appear with drawFastHLine, or any other function I've tested.
Here is the code I used to test:
#include <Arduboy2.h>

Arduboy2 ab;

void setup() {
  ab.begin();
  ab.clear();
  ab.drawFastVLine(64, 0, 64, WHITE);
  ab.display();
}

void loop() {

}

EDIT: It works fine using Arduboy2Base, but not Arduboy2

Confirmed and fixed in the online version.
Thanks for the report! :)

In the new Version 0.78 happened a similar issue with the drawRect function. Like the last issue it works fine using Arduboy2Base, but not Arduboy2.

Is this the offline version?

No

Odd. The web version shows version 0.8.10 for me. Try clearing your browser cache and reloading the page.
P. S. This appears to be the same issue, as drawRect uses drawFastVLine.

Sorry for the inconvenience but the error went away as I just tested it again using Arduboy2. I don't know how the error occurred.Thanks for the help,


Clarify the Section about NCRONTAB expressions

The NCRONTAB expressions section needed improvement in my opinion. Specifically the second entry about a timer that runs every day at hour 5 and executes every minute. The previous explanation made a confusing statement about this running 60 times a day. My change aims to clarify that this execution will happen 60 times within the specified hour.

@ZarPeter : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks, @ZarPeter!
#sign-off


See Also links should be on separate lines

Reintroduce change from 31b5392 which was accidentally removed in fc94ef1.

@mikkelbu,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


Basic Needs Compatibility is buggy

I have only one Garden, with 'Full Sun'. If I go to one guide with the 'Full Sun' Basic Need, it says I'm compatibile. If I go to another Guide also with the 'Full Sun' Basic Need, it says I'm not compatible because 'I have Partial Sun' according to the tooltip.
Hmmm?

What are the two guides?


Disable buffer security checks in VS release builds

Closes #18

Waiting on discussion in https://github.com/lemire/simdcomp/issues/18

Seems like the issue did not warrant a PR. Resend if you disagree.


Use note title for wiki link names

Is your feature request related to a problem? Please describe.
First up, congrats on a cool app! I started using Dendron and so far my single issue with it (after getting the hang of it) is that the metadata is not used more widely, especially for one important thing: named Wiki links. It would be so cool if a Wiki link got its "title" as what is displayed in the preview, and not a whole hierarchy - "something.foo.bar.Baz is cool", but "Baz is cool".
Would make this much more natural inline in text, if your concept is somewhere deep in a hierarchy but it's also a topic you might want to mention in a sentence.
Describe the solution you'd like
It would be great if either a) the behaviour by default would be for the link to use the title or b) there could be simple way to make this happen, like some special character before the name (e.g. a dot - [[.something.foo.bar.Baz]])
Describe alternatives you've considered
Naming everything explicitly, but this is such a pain in the neck. Especially when you rename things, change titles etc - it would be so cool to keep everything consistent by just using the metadata item which we already have.

(of course I might be getting something wrong and it's already possible to do this, but I have not seen it)

thanks for the input! using the last part in the wiki link makes a lot of sense.
for implementation, I like both your suggestions and think it makes sense to have both. Instead of a ., I might just have a | without a alias default to title [[|something.foo.bar.Baz]].
our november backlog is quite full at the moment but I've put this us a December milestone unless someone gets to it ahead of me :)

I like this, but I'd prefer if the frontmatter title was used instead of the last part of the wiki-link.

that would be something we could configure. eg. dendron.defaultAlias: title|leafOfHierarchy

Thanks for the positive feedback :) Actually, I think the frontmatter title indeed is the best option for what to show. That;s what I had in mind but I didn't make myself clear. That would kind of make the frontmatter title much more useful.
Of course having a config for this does not hurt - indeed some people might even prefer the current behavior! But I'd make the frontmatter title the deafult, because that's what people expect in Wiki-like frameworks normally.

this is now implemented as a dendron option :)
https://dendron.so/notes/eea2b078-1acc-4071-a14e-18299fc28f48.html#usenotetitleforlink


[FLINK-32562][connectors/filesystem] Handle compressed streams correctly in ConcatFileCompactor

What is the purpose of the change
Provides a way to handle output stream based compaction in case the data stream is compressed. The problem is described well in the Jira ticket. The relevant logical changes are in CompactService, where in case of a COMPRESSED_STREAM, now we create a different BucketWriter that will instantiate its writer via the newly introduced RawBulkWriterFactory, that makes sure in case of compressed part files it simply writes out the bytes into the compacted file as is, so the produced compacted file will be a valid compressed file.
Brief change log

Introduce new CompactingFileWriter  type COMPRESSED_STREAM .
Add compressed flag to ConcatFileCompactor that denotes COMPRESSED_STREAM.
Handle COMPRESSED_STREAM in CompactService appropriately.
Changed AbstractCompactTestBase to protected to be able to use in the new CompactServiceTest that is in a diff. package.
Moved some test helper methods to AbstractCompactTestBase to avoid/eliminate duplication.
Extracted TestBucketWriter to its own class, as it is now used in multiple test files.

Verifying this change

Added new unit tests for the newly introduced logic in CompactServiceTest.
Added integration tests for the available concatenable compressions in CompressedCompactionITCase.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? debatable
If yes, how is the feature documented? JavaDocs

Seems like the actual change set is working for particular compression types and not working for others (an example is snappy). Solving the problem partially would generate bad UX for users so I would suggest to re-evaluate the general approach.


ENH: Disable test drivers compilation if Python wrapping ON for Azure…

… pipelines
Disable test drivers compilation should have a significant positive impact
on build time. It also does not impact testing negatively as these tests
are run on non-Python builds.

See #684


feat: configure Python versions with variables

Have you read the Contributing Guidelines?
Issue #
Changes description
Changes allow to configure multiple Python versions within Connect - the section in the configuration is generated with variables and template.
Without changes in the config template it wouldn't be possible to configure more than 1 version of Python. With rstudio_connect_config it's possible to pass configuration, however it's a map, so it's forbidden to define multiple Executable keys.

Proper PR is here: #24


Dark Theme :focus and :disabled not working as intended

Having a dark theme with a focus effect doesn't seem to work as intended. I expect the border to change to red when I focus an input text field but it just doesn't change at all. Also removing the default :focus and :disable renders different results on the dark theme focus when focused.
Am I doing this wrong?
module.exports = {
    theme: {
        customForms: theme => ({
            dark: {
                'input, select, checkbox, multiselect, textarea': {
                    backgroundColor: theme('colors.transparent'),
                    borderColor: theme('colors.blue.900'),
                    color: theme('colors.white'),
                },
                input: {
                    '&:focus': {
                        boxShadow: undefined,
                        borderColor: theme('colors.red.200'),
                    },
                    '&:disabled': {
                        backgroundColor: theme('colors.gray.700'),
                        opacity: 0.4,
                    },
                },

            },

            default: {
                'input, select, textarea': {
                    backgroundColor: theme('colors.transparent'),
                    '&:focus': {
                        boxShadow: undefined,
                        borderColor: theme('colors.gray.800'),
                    },
                    '&:disabled': {
                        backgroundColor: theme('colors.gray.100'),
                        opacity: 0.4,
                    },
                },

                checkbox: {
                    width: theme('spacing.6'),
                    height: theme('spacing.6'),
                },
            },

            sm: {
                'input, textarea, multiselect, select': {
                    fontSize: theme('fontSize.sm'),
                    padding: `${theme('spacing.1')} ${theme('spacing.2')}`,
                },
                select: {
                    paddingRight: `${theme('spacing.4')}`,
                },
                'checkbox, radio': {
                    width: theme('spacing.3'),
                    height: theme('spacing.3'),
                },
            },
        }),
    },
    plugins: [
        require('@tailwindcss/custom-forms'),
    ],
};

Was an applied style override happening.


Canadian County, OK Parcels

https://maps.meshekgis.com/arcgis/rest/services/public/Canadian_County_Parcels/MapServer/0

All I can find there is an owners address- couldn't find a mapserver with Situs.

no data


remove if-branch at downsample pad in zipformer for onnx-export compatibility

this if-branch can't trace in onnx-exporting when we use tensor which T-dim is an even number , throw RuntimeError when we run the onnx model :

The input tensor cannot be reshaped to the requested shape. Input shape:{219,1,384}, requested shape:{110,2,1,384}

even though it can export successfully without any error
we can allow he number of pads to be 0 to make this an unconditional execution.

Thanks.


Fix layout on mobile

It's not great right now, especially on my iPhone mini! We probably need to make the two-column design work more responsively, maybe putting the tags list behind a hamburger menu?

Hi @ckolderup is this issue fixed yet?

@HavreLoic no, it's unlikely that I'll get to styling/display stuff until after the backend & Mastodon integration is better solidified.


[FIXED]  FPS gets capped to 60 when in Fullscreen

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
Adrenaline was capping the FPS to 60
FPS gets capped to 60 when in Fullscreen. When losing focus or running in the background it uncaps itself and gets above 60. It is not "Exclusive Fullscreen". Framerate limit is set to 170. FastFlags used are in the picture (Doing Vulkan, because I want Roblox to fully utilise my AMD GPU) (Max buffer size is self explanatory) (MSAA to 16 because typical Roblox sharpening is ass) (GameBasicSettingsFramerateCap because im trying to fix this issue). This has happened today. Yesterday it was working fine.

https://streamable.com/yegh4i <- see the issue

Resolved on Discord


Apply CU after mitigate with EOMT

Hello,
For an exchange  server 2016 CU7,  I have ran the EOMT script to mitigate it.
I have planned to apply the CU and the security patch in next day but do I need do something  before apply the CU and patch security ? any rollback ? or just update my exchange server ?
Thanks.

Hi @AGS-ntomio
For your scenario i'd suggest re-running EOMT after you finish the CU upgrade prior to the Security Update. We found that a CU upgrade will overwrite the URL Rewrite rules leaving the server in a vulnerable state. After the Security Update be sure to run EOMT -RollbackMitigation

I am applying the CU20 patch tonight. I have the security patch in since march 13th.  Is there anything else I should be doing? Is the CU going to do anything to the patch already in place?

Hi @susanTCI
Making sure I understand your scenario correctly.
You installed the SU from March in your environment and your now installing the CU on top of the patch correct?
If that's the case you will be protected from only the following CVEs

CVE-2021-26855
CVE-2021-26857
CVE-2021-26858
CVE-2021-27065

As of yesterday (April 13th 2021) new CVEs were addressed. Information on the new April security update can be found here:
https://techcommunity.microsoft.com/t5/exchange-team-blog/released-april-2021-exchange-server-security-updates/ba-p/2254617
I highly recommend after your update to CU20 is complete to apply the April security update. You can do this immediately after the CU is complete on each server.

I did what you suggested and all is running.  The only problem I had is during the install of the CU and SU is that iphlpsvc would not stop unless I did a taskkill.  And if I didn't do that. They both timed out. I know to watch that now with each update I put in. It too a while to figure it out.  Any idea what could be causing this?

I bounced that off a few people, and the consensus seems to be that a CU install hang due to IP Helper Service is not something we've seen. It would take some investigation to figure out what happened there.


✨ Default props

Description
Add the ability for default props to be passed into the components created by style-element, this is an extension of #8 and therefore would need to be typed, ideally.

I think we just need to use react component api:
import style from<EMAIL_ADDRESS>
export const DocBadge = style.div(
    'r:3 inline-flex font:12 font:medium font:mono ls:-.5 lh:1.5rem px:6 font-feature:normal',
    {
        color: {
            gold: 'fg:gold-60@light bg:gold-95@light fg:gold-70@dark bg:gold/.2@dark',
            fade: 'bg:slate-90@light bg:gray-30@dark fg:major'
        }
    }
)

// <DocBadge>
DocBadge.defaultProps = {
    color: 'fade'
}


Prevent untracked files from being added to the release commit

Fixes #23
@rwjblue I'm thinking that this doesn't need a minor version bump, since it's kind of a bug. Thoughts?

Ya, agreed that this feels like a bug fix to me.


Change edx-app-gradle-plugin repo url from https to ssh

Description
OSPR-1682
This PR changes the url from the repo edx-app-gradle-plugin. Using https the app builds correctly locally but while trying to build with Circle CI the build process fails. When I change it to ssh it works on both. I don't know if this would break in Travis but nothing to lose here and try it.
Reviewers

[ ] Code review: @danialzahid94
[ ] Code review: @saeedbashir

Thanks for the pull request, @jagonzalr! I've created OSPR-1682 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.
If you like, you can add yourself to the AUTHORS      file for this repo, though that isn't required.     Please see the CONTRIBUTING     file for more information.

@jagonzalr Tests are failing. Can you have a look?

@saeedbashir it says No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Maybe I need to run it again? How can I do that without making a new commit?

@jagonzalr There is a restart button (I pressed it for you). Usually when all jobs have the same result, restarting might not help but let's wait and see.

@jagonzalr I think the change is causing the build to fail. Would you like to make any other changes, otherwise we can close this PR.


C++ operator sugar - add std::string & wstring operators

Hi,
People using C++ wrapper will most definitely want to use c++ strings. What do you think of adding std::string & std::wstring operators?
In my project I've added this code and it's very useful:
     #ifdef __cplusplus

           #include <string.h>
           #include <string>

     ...

     inline operator std::string () const
     {
        switch (type)
        {
           case json_string:
               return std::string(u.string.ptr);

           default:
               return "";
        }
     }

     inline operator std::wstring () const
     {
        std::string string;
        switch (type)
        {
           case json_string:
              string = u.string.ptr;
              break;
        }
        return Utf8ToWide(string);
     }

Function Utf8ToWide() is windows only:
#include <windows.h>

std::wstring Utf8ToWide(const std::string& utf8String) {
    int requiredSize = MultiByteToWideChar(CP_UTF8, 0, utf8String.c_str(), -1,
                                           0, 0);
    wchar_t* wideString = new wchar_t[requiredSize];
    int copiedCharacters = MultiByteToWideChar(CP_UTF8, 0, utf8String.c_str(),
            -1, wideString, requiredSize);
    std::wstring returnedString(wideString);
    delete[] wideString;
    return returnedString;
}

For cross-platform conversion there is mbstowcs() function:
http://www.cplusplus.com/reference/cstdlib/mbstowcs/
But I've read there are some problems when using mbstocws() on Windows, seems that it depends on current locale, see this topic:
http://www.gamedev.net/topic/443913-what-is-different-between-multibytetowidechar-and-mbstowcs/

Taking a quick look in VC8's CRT source, it appears mbstowcs calls
MultiByteToWideChar. However, it's only doing so when the current locale
is changed from the default locale. So I'm guessing the default locale is the
C-locale, and conversion from multibyte to wide character is a simple char
to wchar_t assignment. Consistent with what you present.

So maybe for windows use this specific code and for other platforms mbstowcs()?
Czarek.

Sorry for the late reply.  My problems with this:

It would drag STL into anything that includes json.h, and quite a few projects use C++ without STL.  I suppose this could be avoided with an ifdef.

The wide string conversion is way out of the scope of the parser as a library.

Maybe you could define a std::string conversion outside of json_value instead?

Closing old issues...


Add BZ component to OWNERS

Adds the OLM BZ component to the OWNERS file.

This is a no-op so adding the labels manually.
/label px-approved
/label qe-approved
/label docs-approved


Add Polytimer

This is a pull request for adding https://polytimer.rocks to the list. Polytimer is a ultility/experiment pwa for setting timers. It uses Polymer and service worker.

Something else to optimize?  😃

Looking good! Merging 👍

When the new version is going live? 😄

@davi-mbatista It’s already live. The website is updated automatically on every push to master.

Ow... I can't find the app that was added on this pull request though.

@mathiasbynens, we're currently having problems with auto deploy, could you please have a look?

@pepelsbey Done.

@mathiasbynens @pepelsbey Awesome!


Configure more lints and switch from black to ruff format

looks good to me but might mess now with other PRs?


Added missing "spring." to oauth2 config

Without the spring. the sso wont be enabled

Merged in 870b15d


Pantheon update script

Motivation for this change
Eval for treewide change.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@kjuvi Btw, you can run
nix-shell maintainers/scripts/update.nix --argstr  maintainer kjuvi

to use this script to update the packages.

https://nixos.org/nixpkgs/manual/ passthru.updateScript.

@GrahamcOfBorg build pantheon.nixpkgs-github-update


Any inventory changes should be going through InventoryManager

At the moment, a couple of places in the code (for example ItemSystem) modify the inventory directly, rather than use InventoryManager. As a result - some events that would normally be sent are not being sent.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/12197265-any-inventory-changes-should-be-going-through-inventorymanager?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github).

Did #1695 relate to this at all?

Not really, it added one more method that might be required to eliminate all non-InventoryManager usages though.

@Josharias do you think this is complete after you extracted inventory from the engine into Core? Plain ItemSystem doesn't even exist anymore, at least not by that exact name.

Hrm.  I don't recall any places that do this from my extraction of inventory from the engine.  I'll do a double check next time I have Terasology open.

Just so that we don't have to wait another year :smile: Did you have a look at this in the meantime @Josharias ?


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/68016

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/83444

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/86539

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/86542

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/97941

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/97967

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/109277

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/113407

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/115529


Update and reformat of site_example_configuration

Simply updating the specified config regarding format alteration largely

This looks great, I think a few more files will need updating, the streamed/pre_saved batches config files and also I think the pinned version of ocf-data-sampler will need updating

@all-contributors please add @felix-e-h-p for code.


Enable ActiveLogin.Authentication to be used without the built in GUI

Is your feature request related to a problem? Please describe.
If you want to use ActiveLogin.Authentication.BankId without the built in GUI in ActiveLogin.Authentication.BankId.AspNetCore it is not possible since a lot of functionality is currently placed in ActiveLogin.Authentication.BankId.AspNetCore.
It's a show stopper if you want to build a REST service with ActiveLogin.Authentication.BankId without using the:
services.AddAuthentication(CookieAuthenticationDefaults.AuthenticationScheme)
                .AddCookie()
                .AddBankId(...)

What area is it related to
BankID, API
Describe the solution you'd like
To pull out common functionality from ActiveLogin.Authentication.BankId.AspNetCore into a new project. Suggestions:

ActiveLogin.Authentication.BankId.Common
ActiveLogin.Authentication.BankId
ActiveLogin.Authentication.Common

Describe alternatives you've considered
Copy/pasting from ActiveLogin.Authentication.BankId.AspNetCore into our project and just use the ActiveLogin.Authentication.BankId.Api package
Additional context
We will add areas that need to be moved soon...

Thank you for the suggestion @FredrikK!
I agree this could be beneficial if done right. The downside is that at the moment some of these things are "implementation" details and we can make changes without introducing breaking changes, therefore we need to be careful on what things are exposed publicly as we'll have to live with those for some time.
A few questions:

The reason for doing this, is that you don't want to use the UI. Are you able to share why that is? Do you have an existing implementation that you want to keep? We would like to make the UI part as good and customization as possible so that you don't have to build it yourself. One reason I can see myself now is that if you want to use it from "old" ASP.NET (as I know we have cases for).

ActiveLogin.Authentication.BankId.Common would be where I put my vote on at the moment. As far as I know we don't have to much in common between BankID/GrandID and don't want to create a to big of common package.

Could you provide a more detailed list of suggested functionality that should be moved into a common package. Please also provide a "pitch" for those cases. As described above, exposing this functionality comes with some side effects, so each feature moved with a public API needs to be thought through.

Hi again @FredrikK! Any additional input on this? We are getting closer to release 3.0.0 of our package, and that would be a good time to include this as it might be a breaking change.
No stress, we could plan it for a 4.0.0 release as well.

Still interested in this @FredrikK? We wither need to know the needs, as described above, or we'll close it for now.

Hi @PeterOrneholm, sorry for the late reply.
Unfortunately we had to proceed without ActiveLogin.Authentication but the idea still stands (in my opinion) so I will try and answer the questions above.

We have a lot of business and regulatory rules to have a very custom login web with several auth methods. We also have a few other web pages that need access to the BankID api. So our idea is to make a custom BankID.Rp rest-service that is a "proxy" to api.bankid.com with extra rules.

Sounds great. I hate the namespace "Common", but i wrote it first :-(

I think we ended up with config and certificate-classes

Thanks for input!

We have a lot of business and regulatory rules to have a very custom login web with several auth methods. We also have a few other web pages that need access to the BankID api. So our idea is to make a custom BankID.Rp rest-service that is a "proxy" to api.bankid.com with extra rules.

I see, at the moment the API wrapper is a separate package. Could you use that in any way?

Sounds great. I hate the namespace "Common", but i wrote it first :-(

I've given it some thoughts, and looked at other packages. "Core" seems to be a better name.
ActiveLogin.Authentication.BankId.Core
And if we have common stuff that's not only relevant for BankID:
ActiveLogin.Authentication.Core

I think we ended up with config and certificate-classes

Ok, I see. So basically configuring the HttpClient when using the Api wrapper only?
I think this is a good direction to go to, but would like to wait it out until we have a good description on how and exactly for what it should be used, so we make the best out of it. Will close it for now, but can reopen again when we have more usecases :)


Use identicon image for default gravatar.

Use geometric pattern image as default gravatar. It is easier to distinguish different people.
Before:

After:

Codecov Report

Merging #2767 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2767   +/-   ##
======================================
  Coverage    26.9%   26.9%
======================================
  Files          88      88
  Lines       17289   17289
======================================
  Hits         4652    4652
  Misses      11958   11958
  Partials      679     679

Impacted Files
Coverage Δ

modules/base/tool.go
73.99% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a257f88...dfef83b. Read the comment docs.

LGTM

LGTM


[Bug]

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
1.2.x
What's Wrong?
except single column wrong

What You Expected?
except sytex should be support  input sungle column calc
How to Reproduce?
No response
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I just try redo what you had done,
when I tried the sql after analyze command , it worked.
analyze table student;
SELECT * except(age) from student;

could you please just do a double check?

Can you post be’s log and fe’s log here?


[Suggestion]

[Suggestions]
Allow Us To Set Players 2Fa Service Keys
So The Owner Has Control Of Changing Of There Service Keys And If There Service Keys Lost We The Owners Can Change It In The Config Or Something
[Also Please Not Just A Command Because I Want To Set A 100 Character Service keys For Admins]

I must recommend against setting the 2FA keys manually, but if you want to do that, you can directly edit the database.
A command would be pointless since it can cause many many problems.

服务器地址可以用微软的吗？我找不到微软的服务器地址。谷歌的我连接不上，被墙

服务器地址可以用微软的吗？我找不到微软的服务器地址。谷歌的我连接不上，被墙

Switching to a different provider, like Microsoft, is possible as long as they do have this serivce.

Closing for irrelevance


Saving GRU with dropout to SavedModel fails

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Colab
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): Pip
TensorFlow version (use command below): v2.0.0-rc2-26-g64c3d38 2.0.0
Python version: python 3.6.8
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

Describe the current behavior
When Model containing GRU layer, dropout is set and activation='relu', the model is not savable.
Error:
Attempted to save a function b'__inference_GRU_layer_call_fn_8041' which references a symbolic Tensor Tensor("dropout/mul_1:0", shape=(None, 3), dtype=float32) that is not a simple constant. This is not supported.
Describe the expected behavior
Model gets saved.
Code to reproduce the issue
from tensorflow import keras
from tensorflow.keras import layers

inputs = keras.Input(shape=(784,3), name='digits')
x = layers.GRU(64, activation='relu', name='GRU',dropout=0.1)(inputs)
x = layers.Dense(64, activation='relu', name='dense')(x)
outputs = layers.Dense(10, activation='softmax', name='predictions')(x)

model = keras.Model(inputs=inputs, outputs=outputs, name='3_layer')
model.summary()
model.save('model',save_format='tf')

Based on: https://www.tensorflow.org/guide/keras/save_and_serialize

Issue replicating for TF-2.0, kindly find the gist of colab.Thanks!

@fhausmann,
The error disappears if dropout=0 or if layers.Dense instead of layers.GRU. The link, https://www.tensorflow.org/guide/keras/save_and_serialize, provided by you doesn't demonstrate on how to Save the Model with layers.GRU.
Can you please refer Image_Captioning_Tutorial, Text_Generation_Tutorial and NMT_With_Attention_Tutorial where, usage of layers.GRU is demonstrated and let us know if it helps. Thanks!

@rmothukuru Thanks for your answer.
The error also disappers if 'activation' is not set and yes the link is maybe a bit missleading, since the example there is for Dense layer only. However, I thought this was a good minimal working example also with GRU.
I had a look into your links, but unfortunately non of them demonstrate how to save a model with GRU layer in the SavedModel format.
I tried for the Text_Generation_Tutorial (added model.save('model',save_format="tf") after training, but it also failed here (with another error: AssertionError: Tried to export a function which references untracked object Tensor("StatefulPartitionedCall/args_2:0", shape=(), dtype=resource).TensorFlow objects (e.g. tf.Variable) captured by functions must be tracked by assigning them to an attribute of a tracked object or assigned to an attribute of the main object directly.)
Seems that GRU models does not allow saving in SavedModel format at the moment?

Maybe related to #33355 ?

@fhausmann,
Model is Saved Successfully if you replace model.save('model',save_format="tf") with model.save('model.h5') . Here is the Gist.

Yes, this probably solves the issue for most people, but its a different format , binary HDF5 vs. SavedModel.

@fhausmann,
In your case, you can either use keras.models.save_model(model=model, filepath='model') or
model.save('model'). Please let me know if it works. Thanks!

There is an issue, probably with the argument, save_format='tf' because, the code, model.save('model', save_format='tf') is resulting in the Error mentioned by you.

@rmothukuru
I tried both on your gist and both give me the error. Only the 'model.h5' works in my hands

I also encountered the same problem. Have you solved it?

tf.keras.experimental.export_saved_model(model, 'modelfolder') and tf.keras.experimental.load_from_saved_model('modelfolder')
seems to be a workaround even they are deprecated.

To add more information, Model is Saved without any Error if we build the Model using Dense or using LSTM and Dense. But if we build the Model with GRU as one of the Layers, it is resulting in either the Error,
Attempted to save a function b'__inference_GRU_layer_call_fn_8041' which references a symbolic Tensor Tensor("dropout/mul_1:0", shape=(None, 3), dtype=float32) that is not a simple constant. This is not supported.``` or the Error,

`AssertionError: Tried to export a function which references untracked object Tensor("StatefulPartitionedCall/args_2:0", shape=(), dtype=resource).TensorFlow objects (e.g. tf.Variable) captured by functions must be tracked by assigning them to an attribute of a tracked object or assigned to an attribute of the main object directly.`.

Here is [Gist_of_Error1](https://colab.sandbox.google.com/gist/rmothukuru/00386fc1a493b344282b1b8aa97e20e7/33247.ipynb) and [Gist_Of_Error2](https://colab.sandbox.google.com/gist/rmothukuru/78f245f68f3729eb1c8f0da1e0df93a1/33355.ipynb).

See the above link. I don't think LSTM works as well

Does anyone have the commit ID which resolved this issue? I don't want to run a nightly release, and need to backport the fix into a stable version.

@phemmer New stable version (TF2.2) will be release soon. Please check the recent announcements here. Thanks!

Can we not just have the commit ID? Yes 2.2 may be close, but it's still a few weeks off I'd imagine. And in addition, I'm using IBM's Large Model Support patch, which will likely take an additional several weeks to be updated to 2.2.


NickelDBus not working with 4.37.21533

I recently upgraded my read to the 4.37.21533 firmware and found that NickelDBus doesn't seem to expose its DBus interface anymore:
# qndb
interface not valid

# qndb -m pfmRescanBooks
interface not valid
failed with:  "method failed with err: org.freedesktop.DBus.Error.ServiceUnknown and message: The name com.github.shermp.nickeldbus was not provided by any .service files"

# dbus-send --system --print-reply --dest=org.freedesktop.DBus  /org/freedesktop/DBus org.freedesktop.DBus.ListNames
method return sender=org.freedesktop.DBus -> dest=:1.28 reply_serial=2
   array [
      string "org.freedesktop.DBus"
      string ":1.28"
      string "name.marples.roy.dhcpcd"
      string ":1.24"
      string ":1.0"
   ]

Could it be that we need a .service file in /usr/share/dbus-1/services/?

I just tested with my dev Glo, which is running FW 4.37.21533. It seems to work fine.
It sounds like the plugin hasn't loaded, can you check for errors via logread? Specifically, you'll be checking to see if it has aborted loading due to loading from a failsafe.
If this is the case, you will need to delete the failsafed libndb file from /usr/local/Kobo/imageformats, and reinstall NickelDBus. (you could also just try renaming the file back to libndb.so)

You were absolutely right, somehow I must have triggered failsafe:
Jul  3 10:15:49 nickel: (NickelDBus) (NickelHook) initializing 'NickelDBus' (version: 0.2.0)
Jul  3 10:15:49 nickel: (NickelDBus) (NickelHook) ... desc: Observe and control Nickel over D-Bus
Jul  3 10:15:49 nickel: (NickelDBus) (NickelHook) creating failsafe
Jul  3 10:15:49 nickel: (NickelDBus) (NickelHook) ... failsafe: info: allocating memory
Jul  3 10:15:49 nickel: (NickelDBus) (NickelHook) ... failsafe: info: finding filenames
Jul  3 10:15:49 nickel: (NickelDBus) (NickelHook) ... failsafe: error: lib was loaded from the failsafe for some reason (check failed: !(d && !strcmp(d, ".failsafe")))
Jul  3 10:15:49 nickel: (NickelDBus) (NickelHook) ... error creating failsafe, returning
Jul  3 10:15:49 nickel: (NickelDBus) (NickelHook) done init

I've renamed libndb, rebooted and renamed it back to libndb.so. It seems to be working again, thanks!


Unable to update to v 1.0.5

Describe the bug
Unable to update to v 1.0.5, installed version is 1.0.4, same behaviors in two vaults, both on Windows and Linux
To Reproduce
Steps to reproduce the behavior:

Install the plugin
Go to update
Dialog comes up that it is installing
Seems to finish but installed version is still 1.0.4, pressing check for update prompts that an update is available

Expected behavior
Should update to 1.0.5 automatically
Obsidian Version:

[ ] Mobile
[x] Desktop

Same here. I think there is some mismatch in the manifest, perhaps?

Yeah, the manifest of 1.0.5 says version 1.0.4. So you actually have the latest version, but it is confusing Obsidian by having the wrong version number in the manifest.

I manually edited the manifest file to get rid of the incorrect update notification.

Thanks for catching this, I have fixed! Try updating now. There might be a delay in Obsidian so if it's not updated yet, just update the manifest directly. The code & styles should be correct.


Live Preview just works after saving file

System:
Ubuntu 12.10 64 bits
Chrome 34.0.1847.116
Steps:

Install brackets 38 via .deb package.
Open brackets and run live preview of the "Getting Started with Brackets" default html file -> This works OK: Launches Chrome, shadows in blue the part of the web page I'm editing and auto-updates the browser with the content I edit in Brackets.
From the File menu I open a simple html file and run live preview -> This doesn't fully work: It launches Chrome but shows a dot under the live preview icon which says "Live Preview (save file to refresh)". As a consequence I don see the blue shadow in the part of web page I'm editing and Chrome doesn't auto-update with my edits until I hit save in Brackets.
I quit Brackets and right-click "Open with Brackets" on a simple .html file within Nautilus -> This doesn't work: The selected file is not opened and instead I get the "Getting Started with Brackets" default html file.
From here onward I can repeat steps 2 and 3 with the same results as above.

Expected results:

I would expect a full Live Preview behavior for simple html pages, including blue shadowing of the web page area I'm editing and Chrome content auto-updating without saving the document.
I would also expect to be able to open files directly from Nautilus, but compared to the previous this is a minor annoyance.

Oh my Good Lord. This pose finally, FINALLY clarified why real time Brackets updating was not working for me. It all boiled down to the concept of setting the correct Project Folder!!!! So many other posts I found on Google was not making this clear. Thank You, Thank You, Thank You!!!!...even though I am writing this over 3 years after the fact. That is how grateful I am to have found this.

@MarcelGerber Thanks for the suggestion! This worked for me.


Adding types to Trove

Adds types to trove so that it becomes easier to work with typed luau while using Trove as the connection cleaner

I think it would be better to create a type of Trove that the constructor returns which contains all the typings. Also, we should avoid using the any type, as it is meaningless to the consumer.

@Sleitnick I made some big changes to the typing, could you give some feedback about it?

Typings added in latest Trove version


Gazetteer - Manage wildcards and spaces

It should be possible to use a space to use two or more like matches.
e.g. man a will find manchester airport.

to enable set these on dataset item:
{ "space_wildcard": true, "minLength": 2 // this is optional for minimum search string length }


CachedSchemaRegistry getting 404 response codes

Description
I was playing around with the following example: https://github.com/confluentinc/confluent-kafka-dotnet/blob/master/examples/AvroSpecific/Program.cs using our schema registry.
I started getting a 404 from the schema registry.
How to reproduce

Set SchemaRegistryUrl to https://xxx.dev/schema-registry
Run the program
Examine the requests using Fiddler:
-- Expected: https://xxx.dev/schema-registry/subjects/sucrose-external-value/versions
-- Actual: https://xxx.dev/subjects/sucrose-external-value/versions

I tracked down the issue and it seems that there's some weird functionality when using HttpClient. Basically when adding prepending the / here: https://github.com/confluentinc/confluent-kafka-dotnet/blob/98edaaf8a746d1a38e85418933da34c2e3a220c2/src/Confluent.SchemaRegistry/Rest/RestService.cs#L234
causes HttpClient to discard part of the url.
Checklist
Please provide the following information:

[ ] A complete (i.e. we can run it), minimal program demonstrating the problem. No need to supply a project file.
[ ] Confluent.Kafka nuget version.
[ ] Apache Kafka version.
[ ] Client configuration.
[ ] Operating system.
[ ] Provide logs (with "debug" : "..." as necessary in configuration).
[ ] Provide broker log excerpts.
[x] Critical issue.

Any news on this, please?

thanks for the PR! closing this issue in favor of that.


Support for matmuls which don't tile perfectly

This issue discusses support for vectorized matmul (and other vectorized operations) for shapes which are not tiled by the vector width.
Consider for example
%C = linalg.matmul(%A, %B) : tensor<13x17xbf16>, tensor<17x19xbf16> -> tensor<13x19xf32>

The target atomic size of a matmul on AIE2 is m=n=4, k=8. So this matmul with m=13, n=19, k=17 is not tiled by the target atomic size, and the matmul cannot be handled by the vectorized matmul without some additional handling.
Approach 1: global padding:
The approach to handle this is to pad the input tensors to the next multiple of the target atomic size. This can be done upfront:
%A_padded = my.pad_with_zero %A : tensor<13x17xbf16> to tensor<16x24xbf16>
%B_padded = my.pad_with_zero %B : tensor<17x19xbf16> to tensor<24x20xbf16>
%C_padded = my.matmul %A_padded, %B_padded : tensor<16x24xbf16>, tensor<24x20xbf16> -> tensor<16x20xf32>
%C = my.slice %C_padded : tensor<16x20xf32> to tensor<13x19xf32>

Above we are incurring an O(mk + kn) overhead for the padding and slicing operations, as well as potentially expensive O(1) costs for having multiple kernels which need to be run. However, sometimes the padding operations can be merged with operations with produce the operands (and the slice operation)? TODO: more details.
IREE has some support for this, links have been shared by @nirvedhmeshram  and Stan:
https://github.com/iree-org/iree/blob/main/compiler/src/iree/compiler/Preprocessing/Common/PadToIntrinsics.cpp
https://github.com/MaheshRavishankar/iree/blob/dfa593104cc539abfcbf94572a6166eb79c5f413/compiler/src/iree/compiler/Preprocessing/Common/PadToIntrinsics.cpp#L1
in response to similar discussions (see for example https://discord.com/channels/689900678990135345/1169307503633383664/1232760520575029309).
Approach 2: padding in DMA:
The AIE has the option to pad in the MM2S channels of Memory Tiles. See:
https://docs.amd.com/r/en-US/am020-versal-aie-ml/AIE-ML-Memory-Tile-Memory
I don't think this is useful for this use case, because we want to pad in the MM2S of the Shim Tile, not the MM2S of the memtile.
Approach 3: Handle edges separately:
In approach 1 we padded the inputs, but an alternative is to slice the edges of the inputs and handle them separately (thus not padding whole tensors, just padding the sliced off edges). Won't work in the k-dimension.

@jtuyls please feel free to update or add more info

Adding some thoughts and additional information to the above approaches.

Approach 1: global padding:
The approach to handle this is to pad the input tensors to the next multiple of the target atomic size. This can be done upfront:
%A_padded = my.pad_with_zero %A : tensor<13x17xbf16> to tensor<16x24xbf16>
%B_padded = my.pad_with_zero %B : tensor<17x19xbf16> to tensor<24x20xbf16>
%C_padded = my.matmul %A_padded, %B_padded : tensor<16x24xbf16>, tensor<24x20xbf16> -> tensor<16x20xf32>
%C = my.slice %C_padded : tensor<16x20xf32> to tensor<13x19xf32>

Above we are incurring an O(m_k + k_n) overhead for the padding and slicing operations, as well as potentially expensive O(1) costs for having multiple kernels which need to be run. However, sometimes the padding operations can be merged with operations with produce the operands (and the slice operation)? TODO: more details.
IREE has some support for this, links have been shared by @nirvedhmeshram and Stan:

Some remarks:
While in the worst case there are additional copies inserted, I think in a lot of cases the padding operations can be fused into the producer. This producer operation could be offloaded to the CPU, but it could also be offloaded to AIE and in that case the local AIE core processors can take care of padding and slicing the data in fast L1 memory. Consider for example two back-to-back matmuls with a ReLU in between:
%A_padded = my.pad_with_zero %A : tensor<13x17xbf16> to tensor<16x24xbf16>
%B_padded = my.pad_with_zero %B : tensor<17x19xbf16> to tensor<24x20xbf16>
%C_padded = my.matmul %A_padded, %B_padded : tensor<16x24xbf16>, tensor<24x20xbf16> -> tensor<16x20xf32>
%C = my.slice %C_padded : tensor<16x20xf32> to tensor<13x19xf32>
%Relu= my.relu %C_padded : tensor<13x19xf32 to tensor<13x19xf32>
%Relu_padded = my.pad_with_zero %Relu : tensor<13x19xbf16> to tensor<16x24xbf16>
%B2_padded = my.pad_with_zero %B2 : tensor<17x19xbf16> to tensor<24x20xbf16>
%Out_padded = my.matmul %Relu_padded , %B2_padded : tensor<16x24xbf16>, tensor<24x20xbf16> -> tensor<16x20xf32>
%Out = my.slice %Out_padded : tensor<16x20xf32> to tensor<13x19xf32>

While naively only the matmuls would be offloaded to AIE, with a bunch of pad/slice type operations in between going to CPU, the padding, ReLU and slicing operations could be optimized by:

A graph transformation which gets rid of the no-op pad-slice patterns.
Fusion of those operations into the preceding operations until they can be executed on local AIE memory.

This could result in two back-to-back AIE kernels:
%C_padded = my.matmul %A_padded, %B_padded : tensor<16x24xbf16>, tensor<24x20xbf16> -> tensor<16x20xf32>
%C = my.slice %C_padded : tensor<16x20xf32> to tensor<13x19xf32>
%Relu= my.relu %C_padded : tensor<13x19xf32 to tensor<13x19xf32>
%Relu_padded = my.pad_with_zero %Relu : tensor<13x19xbf16> to tensor<16x24xbf16>

and
%B2_padded = my.pad_with_zero %B2 : tensor<17x19xbf16> to tensor<24x20xbf16>
%Out_padded = my.matmul %Relu_padded , %B2_padded : tensor<16x24xbf16>, tensor<24x20xbf16> -> tensor<16x20xf32>
%Out = my.slice %Out_padded : tensor<16x20xf32> to tensor<13x19xf32>

Advantages

Simplest approach and will always work as we're relying on other hardware to pad the tensors to multiples of convenient AIE shapes. Gets around the limitation of DMAs only being able to transfer multiples of 32-bit words.
Might be quite performant if pad-slice no-ops can be eliminated and/or aggressively fused.

Disadvantages

Needs capable graph-level no-op elimination transformations and/or fusion strategies.
If pad-slice operations can't be eliminated and/or fused, this might result in a lot of back-and-forth between different devices (AIE-CPU), incurring expensive kernel launch costs.

Approach 2: padding in DMA:
The AIE has the option to pad in the MM2S channels of Memory Tiles. See:
https://docs.amd.com/r/en-US/am020-versal-aie-ml/AIE-ML-Memory-Tile-Memory
I don't think this is useful for this use case, because we want to pad in the MM2S of the Shim Tile, not the MM2S of the memtile.

The Shim tile and it's indeed not capable of padding, however, you could move the data to MemTile first and pad when transferring data from MemTile to AIE. However, there are still a couple of caveats to this approach:

Transferring data and padding can only happen in multiples of 32-bit words.
Padding has a limited number of bits (4), limiting it to 16 values. Therefore, padding in certain dimension happens in multiples of the previous dimension. This complicates padding + packing cases a lot, but there are even simple padding cases that might not be supported like strides: [1], sizes: [7], padding_after: [17] (unless there is a fancy way of achieving this which I am not seeing).

Advantages

Potentially most performant option if possible as the padding can be done by DMAs in parallel to core AIE processing.

Disadvantages

Hardware limitations limit the number of cases that can be handled (multiples of 32-bit words, limited number of bits and availability on only select DMAs).
Hardware limitations like availability on only select DMAs make it hard to compile high-level computations down to these HW configurations, typically resulting in a need for a lot a handholding and hardcoded logic to achieve correct and performant DMA configurations.

Approach 3: Handle edges separately:
In approach 1 we padded the inputs, but an alternative is to slice the edges of the inputs and handle them separately (thus not padding whole tensors, just padding the sliced off edges). Won't work in the k-dimension.

Could be combined with either approaches 1) or 2) and would therefore take the advantages/disadvantages of the respective approaches. However, this approach would add additional concat type operations to combine the result edge slices with the main result. As AIE isn't very well suited for this type of data copying operations, we would have to make sure that this concatenation would be fused into preceding operations.
Adding an additional approach:
Approach 4: Local handling of odd shapes
This approach handles odd shapes in local memory by either:

Having the AIE scalar processor pad the data before a computation.
Having an odd local AIE computation.

Advantages

Performance. All computations and padding/slicing can happen inside the AIE array. Note: odd local AIE computations might not be performant.

Disadvantages

Input/output tensors that are not multiples of 32 bit words can't be transferred into/out of the AIE array.
Complex local code generation due to the need to keep the local code performant (vector processor) +  packing and padding combination.

Just saw this in-depth follow-up, thanks @jtuyls
My concern with approach 2 (and please correct me anyone if I'm wrong) is that it cannot work for large tensors. Suppose you're feeding tiles of size 128x128 from a tensor A of size 255x255 in DDR, to the memory tiles. In this case, you only perform padding on the right-most tiles (A[0:128, 128:255] and A[128:256, 128:255]). It isn't possible for the memory tile to selectively pad. It is sizes: [127], padding_after: [1] (which we want for the rightmost tiles) or sizes: [128], padding_after: [0] (which we want for the interior tiles) but it cannot do both.


add :awscli option for config values

What is this?
This adds :awscli option for config values, this will use ConfigParser
to try and read the config files used by the awscli (Python) app. It
supports loading values from the default or named profiles.
Notes
This is my 1st pass for Issue #132. I would like to make this a bit more testable, moving usage of ConfigParser to load from config similar to json_codec. But right now the File.exists? would still make testing a bit harder. But without it ConfigParser.parse_file would raise an error if the file doesn't exist.

I have some ideas about how to make the code more testable, but one question I had is if we actually want the warnings. The usual procedure for a lot of AWS libraries is that you just specify a list of possible ways to get the access keys and then it just falls back until it's done. I could see maybe debug output, but warnings seem not quite right to me.
We'll also want to make sure this gets cached one way or another because adding file read + parsing time to every requests seems undesirable.

I hadn't thought about caching, but your definitely right. I'll rework this removing the warnings and caching the parsed config.

Just as a note, I already do some caching around looking up auth from instance roles, whatever caching we do here may already be covered by that mechanism, it's been long enough since I've looked at it that I'm not sure.

I think I can do this as a separate dependency and module. Something like
awscli_config that will read the file and set application env variables
on startup. I'll hack on that some tomorrow and if it works I'll close this
PR.
On Thu, Apr 14, 2016, 9:38 AM Ben Wilson<EMAIL_ADDRESS>wrote:

Just as a note, I already do some caching around looking up auth from
instance roles, whatever caching we do here may already be covered by that
mechanism, it's been long enough since I've looked at it that I'm not sure.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/CargoSense/ex_aws/pull/139#issuecomment-209975010


Better error message for invalid function type annotation

Just as an example, how better error descriptions could be implemented.
Would fix #351 (at least as a workaround). Later referencing filename and lineno would be nice.

Thanks!


[Manage attachments] 'No data' and 'No results found' appears for each section.

EPAM AI DIAL chat version
0.17.0
What happened?

Expected result:

If there are no any files in a section -> don't show the section
If there are no search results -> do not show the section
Please use the 'Conversation list' panel as an example

Confidential information

[X] I confirm that do not share any confidential information

Verified the following scenarios:

No search results in all sections

when no data the section -> it's not shown
wasn't able to find any user without files in Organization to check No data label


Re-enable cached client

Part of #597

Current issue:
{"level":"info","ts":1597090478.910229,"logger":"cluster|5kkrl","msg":"","error":"Failed to retrieve cached client","stacktrace":"
github.com/konveyor/mig-controller/pkg/apis/migration/v1alpha1.(*MigCluster).GetClient()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/pkg/apis/migration/v1alpha1/migcluster_types.go:130
github.com/konveyor/mig-controller/pkg/controller/migcluster.(*ReconcileMigCluster).validateSaTokenPrivileges()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/pkg/controller/migcluster/validation.go:250
github.com/konveyor/mig-controller/pkg/controller/migcluster.ReconcileMigCluster.validate()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/pkg/controller/migcluster/validation.go:79
github.com/konveyor/mig-controller/pkg/controller/migcluster.(*ReconcileMigCluster).Reconcile()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/pkg/controller/migcluster/migcluster_controller.go:144
github.com/konveyor/mig-controller/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:215
github.com/konveyor/mig-controller/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:158
github.com/konveyor/mig-controller/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133
github.com/konveyor/mig-controller/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134
github.com/konveyor/mig-controller/vendor/k8s.io/apimachinery/pkg/util/wait.Until()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88
runtime.goexit()
	/usr/local/Cellar/go/1.14.4/libexec/src/runtime/asm_amd64.s:1373"}

New issue: looks like indexes on fields aren't in place when using cached client. May need to consult with @jortel on why this is happening.
{"level":"info","ts":1597092139.212936,"logger":"plan|gcgww","msg":"","error":"Index with name field:status.phase does not exist","stacktrace":"
github.com/konveyor/mig-controller/pkg/controller/migplan.ReconcileMigPlan.validatePodLimit()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/pkg/controller/migplan/validation.go:326
github.com/konveyor/mig-controller/pkg/controller/migplan.ReconcileMigPlan.validate()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/pkg/controller/migplan/validation.go:177
github.com/konveyor/mig-controller/pkg/controller/migplan.(*ReconcileMigPlan).Reconcile()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/pkg/controller/migplan/migplan_controller.go:216
github.com/konveyor/mig-controller/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:215
github.com/konveyor/mig-controller/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:158
github.com/konveyor/mig-controller/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133
github.com/konveyor/mig-controller/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134
github.com/konveyor/mig-controller/vendor/k8s.io/apimachinery/pkg/util/wait.Until()
	/Users/dwhatley/code/go/src/github.com/konveyor/mig-controller/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88
runtime.goexit()
	/usr/local/Cellar/go/1.14.4/libexec/src/runtime/asm_amd64.s:1373"}

Modified MigMigration controller logic to retry on NotFoundError. I seem to have introduced a new annoying log message in the process. Puzzled on this log message since I can't find anything in mig-controller that watches replicationcontrollers so far.
reflector.go:251] sigs.k8s.io/controller-runtime/pkg/cache/internal/informers_map.go:196
   : Failed to watch *v1.ReplicationController: unknown (get replicationcontrollers)

I'm still running into NotFound errors at this time that are breaking the migration. I need to re-examine error handling and error unwrapping.

Benchmarks
Running a migration of parks-app repeatedly and calculating sum(mtc_client_request_elapsed) to find total time spent waiting on APIserver as measured by compat client metrics.
Master
This PR

Run 1: 8061 milliseconds
Run 2: 2333 milliseconds

Working on benchmarking with kube-kong load generation today

Noticed today that during the "Cancel" routine with cached client turned on, I get watch errors on:

ReplicationControllers (we List these in listReplicationControllerTemplatePodsForNamespace()
LimitRanges (we List these in func buildResourceLimitMapping()). We don't formally watch either of these resources from mig-controller.

My thought is that the cached client is setting up watches automatically on any resource kind we read with a cached client.  @alaypatel07 does this seem reasonable to you?
E0819 21:00:28.648044       1 reflector.go:251] sigs.k8s.io/controller-runtime/pkg/cache/internal/informers_map.go:196: Failed to watch *v1.ReplicationController: unknown (get replicationcontrollers)
E0819 21:00:28.795989       1 reflector.go:251] sigs.k8s.io/controller-runtime/pkg/cache/internal/informers_map.go:196: Failed to watch *v1.LimitRange: unknown (get limitranges)

Found this useful piece of info on the JS kubernetes client github:
The main difference between a Watch and an Informer is that a Watch can disconnect (network problems, timeout, etc) whereas an Informer tries to re-list and re-watch to hide such failures from the caller.

The cache is also there so you can use list/get semantics instead of event-driven semantics if you prefer.

This explains why the watch behind the scenes is able to lose connection (as is often evidenced in the logs), but the client itself is connected to the informer which will hide these temporary interruptions.

I think I'm encountering an old cached client bug: I seem to have 2 backupstoragelocations when I should only have 1.
oc delete backupstoragelocation -n openshift-migration --all
backupstoragelocation.velero.io "mig-311-wfjmf" deleted
backupstoragelocation.velero.io "mig-311-zrrd2" deleted

@sseago does this sound familiar?

https://github.com/konveyor/mig-controller/blob/3e8f9fe72c3a5a3fec64b3a0b1bbb0e7101fc544/vendor/sigs.k8s.io/controller-runtime/pkg/cache/internal/informers_map.go#L178
@djwhatle yes, I think the cached client will try to setup up listwatch for all the gvks we try to get or list. It happens in the above line. The createStructuredListWatch and createUnstructuredListWatch function are passed to InformerMap structs via the functions you traced and stored in createListWatcher func. In which case your synopsis is correct we need list/watch permissions for all GVKs we get/list in the controller with cached client on

My thought is that the cached client is setting up watches automatically on any resource kind we List() with a cached client. @alaypatel07 does this seem reasonable to you?

@djwhatle I don't remember exactly what happened before when we were using the cached client, but I don't remember this particular one. I think the main bug I remember hitting with the cached client before was that Secrets that existed weren't being found.

Memory consumption running a migration before and after re-enabling cached client. Somehow the result I got from running the same migration was 15% reduction in memory consumption switching to the cached client.
Master - 184 MiB

This PR (cached client enabled) - 157 MiB, 85%


No module named 'src.pyforest' (Installation failure)

Environment

Operating System:
Python Version: 3.6.7
Pip version: 19.1.1
How did you install pyforest: pip install pyforest
Python packages:
req.txt

Description of Issue

What did you expect to happen?
Installation of pyforest

What happened instead?

ERROR: Complete output from command python setup.py egg_info:
ERROR: Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "C:\Users\LUCASM~1\AppData\Local\Temp\pip-install-ibv5qzhr\pyforest\setup.py", line 10, in <module> from src.pyforest.auto_import import setup as setup_auto_import
    ModuleNotFoundError: No module named 'src.pyforest'

Reproduction Steps

pip install pyforest

What steps have you taken to resolve this already?

Nothing

Anything else?

In my second computer (python 3.7.3 and pip 19.0.3) the install did work.

Hi @brenoufes , thanks for your interest in pyforest. I am Guido from 8080 Labs.
In which environment did you try to install pyforest?

We can reproduce this error with Python 2. However, we cannot reproduce it with Python3.
Please make sure that your pip is using Python3 or maybe use pip3?

Hi @guido611 and @FlorianWetschoreck. Windows 10 with pip 19.1.1 and python 3.6.7

I received the same error message trying to install pyforest on my mac three days ago. I googlet the error message, found this tread, and followed it.
When trying to reproduce in a clean conda environment today I ended up with a successful install. I have tried it in a few of my other environments and it all went smooth.
Looking at some terminal history and trying to remember back to the first install makes me belive my problem with pyforest originated when i messed with my .condarc file.
Sorry for not capturing the environment configurations when the error occurred.

@haugstve thank you for exploring the issue and sharing your thoughts on this.
@brenoufes Can you replicate the issue with a fresh python evironment (penv)? I am having a hard time replicating the error on my side.

@tkrabel I updated my python version and then I was able to sucessfully install the pyforest. After that, I was unable to to replicate the error with a fresh env.