Meltano Framework Requirements

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/65
Originally created by @iroussos on 2018-08-09 16:54:10

This is a discussion issue on what is needed in order to bring the new (monorepo) Meltano framework on par with the custom extractor implementations that we have built on GitLab Analytics and the steps required in order to be able to migrate the extractors to the new implementation.
To start with, the minimal Extract > Load flow requirements I can think of are:

Each Extractor must be able to extract multiple entities from a specific source.

Each Extractor's data are stored in a specific schema in the target Data Store (e.g. a relational DB like Postgres).

Creating the schema and loading the extracted data to the Data Store should not be a concern of the Extractor (extractors should be agnostic to the nature of the target data store). The extractor just sends the data for each entity (e.g. as Pandas Data Frames at the current iteration) and should not worry about what happens in the next step.

INSERTing / UPSERTing data should properly work.

Each Loader must be able to automatically add an imported_at timestamp for each record imported.

Each Loader must support Schema creation on the target Data Store with at least attribute metadata (like NOT NULL) and unique constraints provided (for supporting UPSERTing of extracted data). (proper schema updates and multiple attribute constraints can be postponed for further in the future).

The details/specification of the schema to be created for each entity should be provided to the Loader through a Loader specific Data Manifest.

This manifest may be different depending on the type of the Data Store (e.g. a Relational Database vs a Document Store) and should be provided at run time by the user of the framework. i.e. the Data Manifest should be a run time parameter, not a hard-coded schema definition in the code of the Extractors.

We could also support a fall back (defaulting) to just creating a schema based on the Data Frame provided to the Loader, but let's discuss this.

The manifest format provided in the remotes/origin/original_integrated_monorepo branch is the format we have agreed in past sync meetings, so we should built on top of it. @mbergeron has already provided a working implementation for reading/writing such manifests, so that code should be the starting point. (I just think that we should move away from the Entities approach and just use sqlalchemy as in the current implementation).

Both the Extractors and the Loaders must support asynchronous communication with batches of data (identified by their Entity) sent from one to the other.

This is the most important requirement towards supporting extraction from real world data sources, as some (like the Gitlab Pings one) may generate millions of new records per day.

This is already supported by @mbergeron in the original_integrated_monorepo implementation, so we should build on top of it and follow a similar approach (but without using the pyarrow module as its compile phase is flaky / not working for all OS flavors).

Users of the framework should be able to add Extractors and Loaders dynamically.

Adding Extractors/Loaders/Transformations should be as simple as adding the relevant folder to the respective directories.

A request to run a specific Extractor or Loader should result in the Meltano Framework dynamically finding the Extractor/Loader, validating it (in a future iteration), dynamically instantiating its class and properly running it according to the Meltano Interface specifications.

This is also already supported by @mbergeron in the original_integrated_monorepo implementation, and the MeltanoService can be brought in and used as is with minimal updates. (Example can be found in two previous commits that were removed in followup MRs: extractor self registration, loader self registration, dynamic loading )

Each Extractor may require different types of parameters in order to run.

For example, some extractors require a [start_date, end_date] interval while others may work with number of days in the past to be extracted. And there are additional, extractor specific, parameters that may be needed, like the type of transactions to be extracted from NetSuite or the --only_offers flag we had for Lever.

We must find an elegant approach to exposing those required parameters to the Caller (in case an extractor is directly called, e.g. from inside a controller in Meltano Analysis) or the CLI.

Extractors, loaders and transformers should be self sufficent. No dependencies between them. Do not assume common things.

CLI parameters:

debug parameter: Each Extractor should have a "debug" mode which will show the raw response from the API.

load conflict parameter: Each Loader should support all three types of loading data in case of PK/UKs conflicts: {Upserting new rows, Appending new rows, Throwing an error}

On top of that, the aforementioned simple requirements will allow us to add in the future multiple additional Transformation or Filtering steps in between the Extractor and the Loader, support more complex pipelines, etc without any additional changes required.
As a general approach to the architecture, my personal opinion is that Meltano should:

Be as easy to download and run as MySQL (in contrast to the current state of creating ETLs that is more like building a custom SAP implementation).
It should provide a GUI through Meltano Analysis, but also a full featured CLI: this is useful not only for power users, testing or creating scripts, but, most importantly, for running extractors in CI/CD pipelines and integrating Meltano with various other tools.
A data analyst should be able to clone the project, run a couple of commands to properly set the proper python environment and run Meltano Analysis in a couple of minutes.
My opinion is that this also means that we should not use libraries/modules that are known to cause issues in various Operating Systems or Linux Flavors (like for example the issues with compiling pyarrow). We should opt for a simple, clean experience that always works and does not need a cli guru in order for Meltano to work.
A data engineer should be able to add a new Extractor by supporting the Meltano Extractor interface and be able to test that it works without having to worry about loaders, transformations, etc. Towards that goal, I really believe that the way to go is offering MeltanoExtractor / MeltanoLoader abstract classes that will provide the common required interface and which all Extractors/Loaders should inherit from. This is already supported by @mbergeron in the original_integrated_monorepo implementation, so we should follow that approach. No need for something fancy, just a basic interface for Extractors and Loaders with the additional requirement that it should be async like in the original_integrated_monorepo implementation.
The approach in original_integrated_monorepo to a working CLI with meltano as an available command is pretty elegant, so we should not deviate from that. From a CLI perspective, it is way more elegant to write meltano extract fastly than python cli.py extract fastly

View 19 previous comments from the original issue on GitLab


Update README

Removed discord references and fixed some grammar mistakes.

@valanm22, Thank you for your contributions. Unfortunately, I will be rejecting this merge request as someone else picked up the issue and went above and beyond the ask. Regardless, as a thank you for your time I will be adding you to the contributors list. More issues will be created soon, and I would appreciate if you continue contributing to the project. Thank you so much for your time!


Icon picker should have a last entry to search for icon packs on the marketplace

Similar to how we show this for themes:

Very cool - I suggest we use a query like this:
Extension Name: Seti Theme
Category: Theme
Tag: Icon
Specifically:
category:themes tag:icon
Which results in...
https://marketplace.visualstudio.com/search?term=category%3Athemes tag%3Aicon&target=VSCode&sortBy=Downloads
cc: @waderyan @joaomoreno

I added it. For now it searches for category:themes until we have a way to differentiate between icon and color themes.


Unity CloudBuild Build fails if using multiple platforms.

Describe the bug
When creating a Unity CloudBuild target for a project that uses this SDK, the build fails and produces the message error CS0234: The type or namespace name 'CognitiveServices' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?)
This is because the Microsoft.CognitiveServices.Speech.csharp.dll file for each platform conflicts.  As a quick workaround folders must be deleted for other build platforms. I.e. if you are building for android, you must delete the IOS and WSP folders otherwise the build will error. This does not fix the bug permanently however. For that, the .dll's should be re-named, e.g. with _android, _ios and _wsp.
To Reproduce
Steps to reproduce the behavior:

Create a new Unity project and an associated Git repository.
Import the Azure Speech SDK for Unity and commit to the git repo (may need to use Git-lfs for large files)
Set up CloudBuild for the selected project either in the Unity Editor or on the Dashboard.
Trigger a build to run.

Expected behavior
The build will run for some time and then fail with the previously mentioned error message.
Version of the Cognitive Services Speech SDK
1.16.0 as linked in the README here.
Platform, Operating System, and Programming Language

Unity CloudBuild

Additional context

N/A

@jhakulin I'm sorry but I tried doing both of the actions you suggested: 1. Adding tags to the assets, and 2. Using the linked plugin folder with updated meta files (copying the x86_64 dll to the WSA folder).

The CloudBuild still resulted in the same error as logged in the initial issue comment.
Caused the following error in the editor:
PrecompiledAssemblyException: Multiple precompiled assemblies with the same name Microsoft.CognitiveServices.Speech.csharp.dll included or the current platform. Only one assembly with the same name is allowed per platform. Assembly paths:  Assets/SpeechSDK/Plugins/x86_64/Microsoft.CognitiveServices.Speech.csharp.dll Assets/SpeechSDK/Plugins/WSA/Microsoft.CognitiveServices.Speech.csharp.dll
Which I assume is because you asked me to copy the dll across? Did you mean I should just move it instead?

@Tiger-Cross Meta files should prevent collision between WSA and x86_64, did you do following ?

Copy Microsoft.CognitiveServices.Speech.csharp.dll from \Plugins\x86_64 folder to \Plugins\WSA folder
Replace all meta files under /Plugins from Plugins.zip
Make a build again

@jhakulin I can confirm those are the steps that I took. Although I did 1. and 2. the opposite way around to what you suggested because otherwise the copying would have been overwritten.

@Tiger-Cross Could you please send a picture of Unity inspector for both /x86_64/Microsoft.CognitiveServices.Speech.csharp.dll and WSA/Microsoft.CognitiveServices.Speech.csharp.dll ?

@jhakulin of course. Also to make this absolutely clear, I'm not seeing this error on a local unity build.
Here's the screenshot for the x86_64 dll:

And here's the one from the WSA dll:

I've also just noticed that when using the META files from the plugins folder you zipped and sent earlier I see this error in the Unity Editor:
Unable to open Assets/SpeechSDK/Plugins/x86_64/Microsoft.CognitiveServices.Speech.csharp.dll: Check external application preferences.

@Tiger-Cross What is the Unity version you have ? Have you installed iOS and/or UWP support ?
The settings are not correct. What you should have for example for x86_64 is following

And for WSA (when using the meta files I sent as zip attachment)

@jhakulin I am using Unity 2019.4.19 and on my CloudBuild whatever the lastest 2019.4 subversion is. I should add that my build target is for android so I do not need IOS or UWP support in this case.

@Tiger-Cross Could be that because you have not installed iOS and UWP support, Unity do not know how to map the libraries for iOS and Windows from Speech SDK unity package and thus you need to either remove or rename the libraries. I'll check if there is something we can do to make it easier.

@jhakulin that would be really helpful thanks! It's not possible (to the best of my knowledge) to install those configurations while specifying a different build target. For now I'll continue to use the temporary solution I mentioned which was the deletion of the IOS and UWP libraries.

@jhakulin I should also add that I am not the only one experiencing this issue. I voiced this issue on a slack group with many Unity developers and I heard from others that have also run into it. This is how I heard of the initial workaround.

@Tiger-Cross Since Speech SDK Unity plugin contains libraries for Windows/iOS/Android platforms (and in next release also for Mac) and meta files are used to target the libraries to specific platforms/architectures, if Unity installation does not include the all platforms, meta files do not provide the purpose. We can add note in our documentation for Unity CloudBuild in the coming release.

That's great thanks a lot!


chore: clean tests to use multiple backend utils

I copied functions and some constants to the utils for previous pull requests, but left the clean-up to afterwards so the pull request wouldn't be too long. This is the clean-up PR.

@ironman-machine try

Hello @electrachong
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/15777' with the following env. args:
{
    "SCALITY_INTEGRATION_BRANCH": "ultron/master",
    "REPO_NAME": "S3",
    "DEFAULT_BRANCH": "master",
    "SCALITY_S3_BRANCH": "chore/multibackend-utils-cleanup"
}

End to end passed although auto-retried due to a bug. Merging manually


Change cmake

Existing Sample Changes
Description
PR to just run on CI
Check if changing cmake fix path length
Fixes Issue#
External Dependencies
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Implement fixes for ONSAM Jiras

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Command Line
[ ] oneapi-cli
[ ] Visual Studio
[ ] Eclipse IDE
[ ] VSCode
[ ] When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

Checked on remote machine with 2022.0, this fix wont work


Integration of llama3.1 fixes

Quick question: when is an update to an optimum-habana version which includes https://github.com/huggingface/optimum-habana/issues/1154 (fix for rope_scaling @ llama3.1 family) planned?

I will look into this today as well see also
https://github.com/HabanaAI/vllm-fork/issues/140

I staged some changes on my local repo, and when the PR request for optimum is finished, i will update my fork and make a PR to update the dependencies.

I created a fork and was able to get llama3.1 8b instruct working, but it reports that some of the token id's are wrong, but the inference appears to work correctly, see e.g.
#199 (comment) https://github.com/endomorphosis/tgi-gaudi/tree/endomorphosis/llama3.1_tokenizer
However for the moment being I have not yet gotten llama 3.1 405b fp8 working

Hi
I'm trying to build docker with your repo https://github.com/endomorphosis/tgi-gaudi/tree/endomorphosis/llama3.1_tokenizer, but meet some issues when building docker, seems the packages are conflict, could you please help to have a look? Thanks a lot!
docker build -t tgi_gaudi_llama3.1  .

I created a fork and was able to get llama3.1 8b instruct working, but it reports that some of the token id's are wrong, but the inference appears to work correctly, see e.g.
#199 (comment) https://github.com/endomorphosis/tgi-gaudi/tree/endomorphosis/llama3.1_tokenizer
However for the moment being I have not yet gotten llama 3.1 405b fp8 working

Hi I'm trying to run llama3.1_8b with your repo https://github.com/endomorphosis/tgi-gaudi/tree/endomorphosis/llama3.1_tokenizer, but meet some issues when building docker, seems the packages are conflict, could you please help to have a look? Thanks a lot!
docker build -t tgi_gaudi_llama3.1  .

this branch is for debugging, there was a push today, https://github.com/huggingface/optimum-habana/pull/1163#issuecomment-2274261009 i will make a new docker container based on the new push

I created a fork and was able to get llama3.1 8b instruct working, but it reports that some of the token id's are wrong, but the inference appears to work correctly, see e.g.
#199 (comment) https://github.com/endomorphosis/tgi-gaudi/tree/endomorphosis/llama3.1_tokenizer
However for the moment being I have not yet gotten llama 3.1 405b fp8 working

Hi I'm trying to run llama3.1_8b with your repo https://github.com/endomorphosis/tgi-gaudi/tree/endomorphosis/llama3.1_tokenizer, but meet some issues when building docker, seems the packages are conflict, could you please help to have a look? Thanks a lot!
docker build -t tgi_gaudi_llama3.1  .

this branch is for debugging, there was a push today, huggingface/optimum-habana#1163 (comment) i will make a new docker container based on the new push

Thanks a lot! Can I ask when will the new TGI docker container ready? I may want to directly try that one~

I'll start working on it in about 45 minutes
On Wed, Aug 7, 2024 at 8:13 PM XinyaoWa @.***> wrote:

I created a fork and was able to get llama3.1 8b instruct working, but it
reports that some of the token id's are wrong, but the inference appears to
work correctly, see e.g.
#199 (comment)
https://github.com/huggingface/tgi-gaudi/pull/199#issuecomment-2270682678
https://github.com/endomorphosis/tgi-gaudi/tree/endomorphosis/llama3.1_tokenizer
However for the moment being I have not yet gotten llama 3.1 405b fp8
working
Hi I'm trying to run llama3.1_8b with your repo
https://github.com/endomorphosis/tgi-gaudi/tree/endomorphosis/llama3.1_tokenizer,
but meet some issues when building docker, seems the packages are conflict,
could you please help to have a look? Thanks a lot!
docker build -t tgi_gaudi_llama3.1  .
[image: image]
https://private-user-images.githubusercontent.com/82487983/356062282-211fde63-7084-4803-a6c8-9c10d4b4540f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjMwODU5NjIsIm5iZiI6MTcyMzA4NTY2MiwicGF0aCI6Ii84MjQ4Nzk4My8zNTYwNjIyODItMjExZmRlNjMtNzA4NC00ODAzLWE2YzgtOWMxMGQ0YjQ1NDBmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODA4VDAyNTQyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNhNDBkNTgwOTE2ZmI4ZjhlNmUwMTVlOGNmYTUyZWQ1OWM2ZThjZjI1NTc1YmJkMGZiYjRjNmI1MjNiZGU5ZGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.-NrxXmeF2d7E16ExYxidf_6Kv3JidjKbSEuCs5tZM_A
this branch is for debugging, there was a push today, huggingface/optimum-habana#1163
(comment)
https://github.com/huggingface/optimum-habana/pull/1163#issuecomment-2274261009
i will make a new docker container based on the new push
Thanks a lot! Can I ask when will the new TGI docker container ready? I
may want to directly try that one~
—
Reply to this email directly, view it on GitHub
https://github.com/huggingface/tgi-gaudi/issues/197#issuecomment-2274871246,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZ7LEW62JFPQOAJEWYWE4DZQLO6HAVCNFSM6AAAAABLUQ6Z7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZUHA3TCMRUGY
.
You are receiving this because you commented.Message ID:
@.***>

I have fixed the dependencies and built the docker container

I have fixed the dependencies and built the docker container

Great!! Where can I found the ready docker container, is there a link in dockerhub? Thanks a lot!

I just pushed it to endomorphosis/tgi_gaudi as per your request
Note:
There is not yet a formal release in huggingface/optimum and huggingface/optimum_habana so it uses git for the python dependencies.
I have not yet fixed the quantization bug present in huggingface/optimum_habana json configuration key mismatch, and i have not yet validated whether I can quantize llama 3.1 405B with a single node using parameter offloading, nor do I have multiple gaudi machines to quantize the llama 405b for habana, and llama 3.1 405B fp8 huggingface repository will load weights as bf16 right now.
Please inquire with the OPEA team whether they can assist me with the quantization effort, so that I can subsequently then try to add speculative decoding with llama 3.1 8b as the draft model.

I just pushed it to endomorphosis/tgi_gaudi as per your request
Note: There is not yet a formal release in huggingface/optimum and huggingface/optimum_habana so it uses git for the python dependencies.
I have not yet fixed the quantization bug present in huggingface/optimum_habana json configuration key mismatch, and i have not yet validated whether I can quantize llama 3.1 405B with a single node using parameter offloading, nor do I have multiple gaudi machines to quantize the llama 405b for habana, and llama 3.1 405B fp8 huggingface repository will load weights as bf16 right now.
Please inquire with the OPEA team whether they can assist me with the quantization effort, so that I can subsequently then try to add speculative decoding with llama 3.1 8b as the draft model.

Thanks a lot for your docker container, I will download and have a check~
For the quantization, here are the OPEA team members @changwangss @thuang6 @kevinintel who are responsible for this part, maybe you can consult them~

@regisss do you think that having #222 integrated should also fix this one? I don't have the time to test it now, but would be good to close if it should work now, thanks.

I haven't tested it in a while, I gave up on trying to get llama405b on a single node because of the dependency problems, that come along with using any method of quantization, but I assume that any half precision models should work.

@regisss do you think that having #222 integrated should also fix this one? I don't have the time to test it now, but would be good to close if it should work now, thanks.

I think it should work but I have not tried it yet. @tthakkal Have you already tried to run Llama 3.1?

@regisss do you think that having #222 integrated should also fix this one? I don't have the time to test it now, but would be good to close if it should work now, thanks.

I think it should work but I have not tried it yet. @tthakkal Have you already tried to run Llama 3.1?

We tested Llama3.1-8B and Llama3.1-70B bf16 and fp8
Llama3.1-8B on 1 card
https://github.com/huggingface/tgi-gaudi?tab=readme-ov-file#llama31-8b-on-1-card
https://github.com/huggingface/tgi-gaudi?tab=readme-ov-file#llama31-8b-on-1-card-1
Llama3.1-70B 8 cards
https://github.com/huggingface/tgi-gaudi?tab=readme-ov-file#llama31-70b-8-cards
https://github.com/huggingface/tgi-gaudi?tab=readme-ov-file#llama31-70b-on-8-cards

you shouldn't need 8 cards, two cards is sufficient.

you shouldn't need 8 cards, two cards is sufficient.

That could work, just haven't tested it


feat: create with-injected-component example

I think we should merge this into the content-scripts-ui example. Will season it a bit!

I think we should merge this into the content-scripts-ui example. Will season it a bit!

ok, np, i'm going to change it rn


[FIXED - Implemented][Feature Request] Asymmetrical timing for pump/piu

Please Select the game mode your feature request is about.
pump
Is your feature request related to a problem?
Timing in official PIU games is asymmetrical, with judgments biased towards late hits. There's currently no way of doing this in OutFox, which can be a deal breaker for some players.
Describe the solution you'd like
The ability to freely configure timing windows to be either symmetrical or asymmetrical in pump/piu mode.
Describe alternatives you've considered
N/A
Additional context
The following is a graphical representation of the asymmetrical PIU timing windows:

This is in game, but we need to give you an example of this so you can implement.

Fixed in Lua -


responsible-gherkin configure: fails when 1-3 arguments are passed

Caused by https://github.com/dotnet/command-line-api/issues/1711

No longer relevant, now that responsible-gherkin configure  has been removed.


NAT works with Ghidra 9.0.2, files download etc.; Checkout function broken.

Describe the bug
It is possible to get ghidra working through a NAT however checking out files always fails, the files download but the server never registers that they have been checked out. All other functions of ghidra work with this.
To Reproduce
Steps to reproduce the behavior:

in the server wrapper you have to set the property java.rmi.server.hostname to your NAT's DNS hostname and java.rmi.server.useLocalHostname to true.

Expected behavior
Checkouts should succeed.
Attachments
If applicable, please attach any files that caused problems or log files generated by the software.
Environment (please complete the following information):

OS: All
Java Version: Tested on 11.0 and 12.0
Ghidra Version: 9.0.2

Additional context
I suspect this is due to the client sending the public ip address along with the checkout information or something, I haven't actually looked at the code yet for this specific issue.

#645


add Nutil contentType

ContentType schema:

https://humanbrainproject.github.io/openMINDS/v3/ --> select core/DATA/ContentType
https://github.com/HumanBrainProject/openMINDS_core/blob/v3/schemas/data/contentType.schema.tpl.json

required property: name
recommended property: extension, as well as description AND/OR link to specification
Missing contentTypes (suggested names):

application/vnd.nutil.quantifier (extension: .nut)
application/vnd.nutil.transform (extension: .nut)
application/vnd.nutil+csv
image/vnd.nutil+png

@leuat, @sharoncy and @majpuc: Are the .nut file for Nutil all the same regardless of which function is used (e.g. Transform vs. Quantifier)?

No they are different. The .nut file structure also varies between Nutil versions.

No they are different. The .nut file structure also varies between Nutil versions.

Thank you for the rapid response, @sharoncy.
So, this means that we will need to add 4 contentTypes for the nut file extension - one per function:

Transform
Quantifier
TiffCreator
Resize

Correct?

I discussed this with Ulrike in person: 4 contentTypes for the nut file extensions is a good idea. To fit with the OpenMINDS schema she suggested sharing the different Nutil features as different "software", each linked to a different contentType (so a different KG datacard for Nutil Quantifier, Transform, Resize and TiffCreator). This sounds like a good idea as the Nutil features are standalone. But this may have implications elsewhere, let's discuss @Majpuc and @leuat .

Thank you for the info. This is going to be tricky as the software that are registrered in the KG  need to have corresponding descriptions in the TC documents. Currently, we have one ID for Nutil as a whole and one ID for Nutilweb as a whole, because the web version will have a different access point and don't allow all features. They also use different content types. What do you think @leuat? We discussed this a lot during the meeting yesterday. I propose to have a meeting about this in order to give you a bit more background information.

Yes please, I am not fully informed. @leuat @Majpuc

@sharoncy you said the nut files are also different between nutil versions? meaning how many versions should we cover for the 4 nut files?

We will have to discuss this and get back to you. @Majpuc @leuat

Hi, some considerations and questions:

There are 9 versions of Nutil on NITRC. Only 3 of them are listed on EBRAINS (0.33, 0.403, 0.7.0). Do you want content type for all of them? v0.33 did not have a .nut file but an Excel template. If we are sticking to v0.403 and 0.7.0 then there are 2 versions of the nut file. If we are interested in all 9 versions then we'll have to go back and compare. Many of them are intercompatible (for example the nut files from v0.7.0 can be used with v0.8.0).

As Sharon mentioned above:  4 contentTypes for the nut file extensions is a good idea. To fit with the OpenMINDS schema she suggested sharing the different Nutil features as different "software", each linked to a different contentType (so a different KG datacard for Nutil Quantifier, Transform, Resize and TiffCreator).

@lzehl @jagru20 Could you have a look at Maja's comment and let me know your thoughts?
I am happy to make the contentType instances once we have settled on them. Let's try to get this issues closed asap!

I think the only thing I can really comment on at this point is, that curating the nutil features as different softwareVersion instances would be no problem, as they can still be linked to the nutil software instance. In fact, this could possibly be a use case for the "isAlternativeVersionOf" property, what do you think @lzehl?
Alternatively we can also split them on the ResearchProduct (i.e. Software) level.

For point 1 in @Majpuc last comment:
I actually would suggest (in the long run) to register all Nutil versions in EBRAINS to have a full representation. Respective contentTypes (if they are version dependent) need to be generated in that case.
I have a question for point 2 in @Majpuc last comment before I can answer:
Are the Nutil "features" independent software components, meaning can they be installed independent of each other?

Point 1: Yes, indeed
Point 2: No, all the features are available in the same package.

Hi @lzehl
I've reassessed this issue. We have 4 released versions of Nutil that are working properly and shared through KG. It turns out that all "flavors" of  the .nut files can be open in the software, regardless of the feature or version. The feature is recognized automatically and there is no need to specify it.
Would it be possible to have only these content types:
application/vnd.nutil (extension: .nut)
application/vnd.nutil+csv
image/vnd.nutil+png

@Majpuc thanks for picking up this issue again. I'll add the first two content types for nutil asap. For the third (the image) I'll just want to ask if it is really a special nutil PNG? Or is just a PNG created by nutil with no special elements (that only nutil can read/interpret)?

Thanks @lzehl the png's generated by Nutil are just regular png files, nothing special about them.

@Majpuc then the png is just the regular png content type for nutil. Another question though:
There is already one content type for nutil registered instances/data/contentTypes/nutil.quantifier+json.jsonld. Is this still a valid content type or does it need to be removed?

@Majpuc I need more information on what the *.nut and *.csv files are used for in nutil (what is their purpose).

The .nut file is listing the analysis parameters, so in a sense it contains the metadata of the run.
The .csv file is an output result file. It consists of a serie of tables giving the quantification of objects per regions, load, etc..

The json content type is still valid. It is one of the output files allowing to visualise the objects as point clouds in MeshView.

@Majpuc done. The content types should appear for EBRAINS sometime tomorrow.


commonmark-v2

Bump min PHP to 7.4
Bump League\CommonMark to ^2.0
Fixed Tests

Hey, thanks for the PR :)
can you please provide a description (maybe from the issue) and more importantly fix the tests for this PR?
I will be able to look into this next monday I hope, if you added the things above.
This might require a new major version since it not only adds Support vor CommonMark 2.0 but seems breaks compatibility with the previous version
Again thanks for contributing 👍

I'm a hobbyist, never did tests before...
Time to get my feet wet :)
Btw I'll do a few more changes and also bumping min PHP to 7.4 since "Typed properties are only allowed since PHP 7.4".
Definitely needs a major version bump yes.

I've no idea what I'm doing here either ¯_(ツ)_/¯ but the tests should be quite straightforward :)
The suggested changes sound reasonable, could be  "php": "^7.4 || ^8.0", then like in the commonmark package 👍

Done... tests passing.
Easier than I thought :)

Hey, cool, looked into it. To complete this, we would need to update the readme, could you do this as a last step?
I will maybe then link the hash of the old readme so we can tell people how to install the 1.x version in one line, like "If you are using commonmark v.1.x click here.
Thanks for the contribution already, really appreciate your work :)

Sorry for the delay, was really busy...
Here you go, I updated the readme codeblocks.
You can update the readme according to your preference concerning this library's versioning.

Hey, no problem 'bout the busyness, I am quite in a stretch too atm, so this might take some time. But thanks a lot for all your effort already!


[WFSSL-70] update license name in the pom.xml to match the SPDX license name

https://issues.redhat.com/browse/WFSSL-70

The tests failure don't seem to be related to this PR

@fjuma can you please merge this one?


Question for the course personnel

Does the bug fix need to have the Sonarcloud-analysis also, or only in the new feature implementation part of the project?

Hello,
Every time you produce code, you run Sonar analyser. So, in both phases (bug fix and new feature) Sonar is used. It would be good software engineering practice to run Sonar analyser before pull request to the original OS project repo. If you get Sonar issues, fix/refactor what you see necessary, and run analyser again.
At Moodle there is pdf file "Guidelines to fill-in the quality diary report".
It says: "Every time you analyze your code with Sonarcloud and refactor the SonarQube rules violated in your code, you must report it in the diary. "

Priority: Low


Add Share to Reddit and Copy Share URL to Share Menu

This address the request on PR #1636 to simplify Share options:
a.  Removes Share to Reddit from metadata panel
b.  Adds Share to Reddit in Share Menu
c.  Adds Copy Share URL to Clipboard in Share Menu
d.  Fixes issue with sharing to reddit when no Systems selected creating a post title with empty [ ] at the end.  Checks to see if systems.length > 0.
One opportunity to improvement is to change the text of "Copy Share URL" to "copied!" when the button is clicked, to provide some visual cue to the user that something has happened successfully.  But I'm not sure yet how to do that and don't want to hold this up.

Further, I think it would be nice to add the brew description to the reddit post by default.  I did that on my branch here, and can submit a PR for it if desired.


How can i change yAxisLabel in React Native Chart Kit?

I'm creating Weather app in React Native and I'm using react-native-chart-kit to display temperature chart. Is there a way to change yAxisLabel values to a fixed values, or is there any props that can do that.
this is my code

const chartConfig = {
  backgroundColor: "#1cc910",
  backgroundGradientFrom: "#eff3ff",
  backgroundGradientTo: "#efefef",
  decimalPlaces: 2,
  color: (opacity = 1) => `rgba(0, 0, 0, ${opacity})`,
  fillShadowGradient: "#037d50",
  fillShadowGradientOpacity: 0.8,
  barPercentage: 0.8,
  style: {
    borderRadius: 20,
  },
};
const data = {
      labels: this.createtime(Object.values(this.state.res), histogramType),
      datasets: [
        {
          labels: [0, 20, 50, 100],
          //this function just to get data from API
          data: this.createData(Object.values(this.state.res), histogramType),
        },
      ],
    };

       <BarChart
          data={data}
          width={350}
          height={550 * 0.7}
          showBarTops={true}
          withInnerLines={true}
          // showValuesOnTopOfBars={true}
          chartConfig={chartConfig}
          verticalLabelRotation={90}
          fromZero={true}
          style={styles.barChartStyle}
        />

'm creating Weather app in React Native and I'm using react-native-chart-kit to display temperature chart. Is there a way to change yAxisLabel values to a fixed values, or is there any props that can do that.
this is my code

you can make this with this param
 formatYLabel={(value) => value}

put this attribute and return the desired value

Hello @fernando-pascoal
I used this param but nothing is changed,
how can I use it with the correct method


Change default branch to main

@paxos and @arfon: is it a good time for me to do this now?

Yep. Let's do it!

Done!


map compiler location to LSP range

Changes
For compiler warnings, the visual markers were also displayed on some characters in the following line. Maybe I misunderstood something here, but I fixed it to the best of my knowledge :)
Testing
Manually tested.
There are test for Compiler Points but those functions seem to be outdated not to be in use anywhere?
Docs
n.a., bug fix

There are test for Compiler Points but those functions seem to be outdated not to be in use anywhere?

Those are for the AST positions, we used them not too long ago for mapping code actions, but they're currently unused. I'm keeping them around because it is quite likely that we'll use them in the future


Performance issue in full screen mode

Hi,
I tried searching for this and could not find any reports of this issue - sorry if it's a duplicate.
Using 3.2 (also duplicated in 3.1.2), when my game is in fullscreen mode on a Mac, the FPS is consistently dropped in half in certain areas of the game.
A bit of research and I discovered these posts:
http://stackoverflow.com/questions/27758027/sprite-kit-serious-fps-issue-in-full-screen-mode-on-os-x
https://forums.developer.apple.com/thread/26809
So I went ahead and modified cocoa_window.m to create fullscreen windows that are +1 in height. The result is that the FPS went back to the normal 60FPS in all areas of the game. This is a crapy solution, but will have to do for now until somebody can figure out a proper solution to this issue.
Here's the patch:
124a125,126
>     // Sheado - adding +1 to the height for a performance issue workaround for fullscreen opengl windows on OSX
>     // http://stackoverflow.com/questions/27758027/sprite-kit-serious-fps-issue-in-full-screen-mode-on-os-x
128c130
<                                     bounds.size.height);

---
>                                     bounds.size.height+1);
968c970,972
<         contentRect = NSMakeRect(xpos, ypos, mode.width, mode.height);

---
>         // Sheado - adding +1 to the height for a performance issue workaround for fullscreen opengl windows on OSX
>         // http://stackoverflow.com/questions/27758027/sprite-kit-serious-fps-issue-in-full-screen-mode-on-os-x
>         contentRect = NSMakeRect(xpos, ypos, mode.width, mode.height+1);

Works for me! Removed the stuttering on fullscreen window. Thank you for this.
A hacky solution. Maybe there is a better one ?

@Sheado hi... Im having the same problem. I'm using cocos2d-x where should i make the changes?

SDL changes width back to normal:
        [nswindow setFrame:frameRect display:NO];

fullscreen case do not call setFrame, it sets origin and size separately:
    [nswindow setContentSize:rect.size];
    [nswindow setFrameOrigin:rect.origin];

May be this helps?


Article

Hi @yakubsiyam can you please take some time to write a description of what this PR is about?

Hi @yakubsiyam can you please take some time to write a description of what this PR is about? For example:

add a title to the pr
add a description regarding the pr
add a label to the pr (like bug fix, enhancement)

Okay


xtf: 0-unstable-2024-07-25 -> 0-unstable-2024-08-30

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for xtf is: Xen Test Framework and Suite for creating microkernel-based tests
meta.homepage for xtf is: https://xenbits.xenproject.org/docs/xtf/index.html
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0-unstable-2024-08-30 in filename of file in /nix/store/mm8hzcy66a56haqls9ai4179cfx383pj-xtf-0-unstable-2024-08-30

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

xtf

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mm8hzcy66a56haqls9ai4179cfx383pj-xtf-0-unstable-2024-08-30 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A xtf https://github.com/r-ryantm/nixpkgs/archive/7c4ff8df70f600cdf0f1e6e84d083062dbd0bdf0.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7c4ff8df70f600cdf0f1e6e84d083062dbd0bdf0#xtf

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mm8hzcy66a56haqls9ai4179cfx383pj-xtf-0-unstable-2024-08-30
ls -la /nix/store/mm8hzcy66a56haqls9ai4179cfx383pj-xtf-0-unstable-2024-08-30/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

xtf
xtf.dev
xtf.doc

Maintainer pings
cc @SigmaSquadron for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


Allow for custom disk size and type when using VertexAI Step Operator

Updated our step operator to allow for custom disk sizes when using VertexAI step operator.
Pre-requisites
Please ensure you have done the following:

[x] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.
[x] I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

@avishniakov we don't do vertex tests, but I have tested it to ensure it works.


Monitor disk r/w rate

When performing a large transaction benchmark on fabric, I got very high Traffic In/Out for each peer and the specified orderer of 1.1 GB ~ 2.5 GB from the statistic result but nothing about the disk read/write rate of these nodes. Is it possible to monitor the hard disk read/write rate of each node?

@pplam I'm 100% not sure, but @jiangyaoguo we can investigate on it.

Resolved by PR #237


Generate config before running the escript

Fixes https://github.com/bitwalker/exrm/issues/286

Sorry for the delay! Thanks for the PR!

@bitwalker no worries! Thanks for merging! As always, I'd appreciate a release on hex.pm so we're not dependent on GitHub.

I'll get a new release out today, on the road currently, but should be able to do it later in the evening.

Appreciate it!

@MSch Done!


demonstrate kkrt handling the get_caller_address zero case w/ error

Time spent on this PR: 2 hrs
Resolves: #
addresses: #216
Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[X] Testing

What is the new behavior?
This small pr introduces a potential pattern where pre-alpha testers can do PR's w/ solidity contracts. Currently using testsequencer, which is a little involved, the idea is to have a solidity_contracts directory that pre-alpha tests can add solidity code that isnt working and have those contracts ran against the CI
Does this introduce a breaking change?

[ ] Yes
[X] No

As discussed this morning, I don't feel like we need to add this kind of tests here. For the RPC I'd like us to focus first on the conformance tests.
Regarding this CALLER (and ORIGIN) opcode issue, we made some tests with @danilowhk to make sure that we understood correctly the expected behavior of the EVM, and tl;dr added an issue for adding from and origin to the ExecutionContext.
I'd like to close this issue here and focus on this task on the main kakarot repo side.


Incomplete Box<S:Socket> implementation

Bug Description
The Socket trait implementation for Box<S:Socket> does not implement the poll_flush() method, which doesn't play well with TLS backends. I noticed this inconsistency while working on sqlx-exasol.
Info

SQLx version: 0.7.1

closed by #2742


extract more info for reboot reason and separate reboot stack

Signed-off-by: eriknordmark<EMAIL_ADDRESS>

Hey @nordmark I need to take a bit of a closer look here, ok?

@rvs Looks like there are some odd yetus and build failures.
Yetus shows "Artifact not found"
build fails in a vendor arm directory; are we building for arm or is that a red herring?

We are not yet building on ARM @nordmark -- not sure what that is all about

LGTM


Add fallback for Object.hasOwn

Object.hasOwn only exists in Node versions >= 16.9. Fallback to Object.prototype.hasOwnProperty: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwnProperty

Otherwise, make a note that this repository requires Node ≥ 16.9


React build shows empty rows

Describe the bug (required)
This is a very strange issue but I was using react-table 7.0.0.rc16 and I recently upgraded to react-table 7.0.1 the problem is my data works in dev mode but as soon I create a react build it wont render anything I would like to know why and I am attaching my package.json in sandbox link for the same.
Provide an example via Codesandbox! (required)
https://codesandbox.io/s/quizzical-paper-hmzxh?file=/src/App.js to reproduce the issue.
Steps To Reproduce (required)
whenever the build is deployed it renders an empty table
Expected behavior (Recommended)
table should render with data
Desktop (please complete the following information):

OS: [ubuntu 16.04]
Browser [mozilla]
Version [84.0.2]

Additional context
here is a link to the deployed code https://csb-hmzxh-ap5fj53r4.vercel.app/

@vinayakshahdeo did you work out a fix for this in the end? I am experiencing the same issue on version 7.6.3 (Chrome)

Hi guys, I am experiencing the same problem. Locally my react table works fine, but when I use it on a build version, the rows come out empty. After spending 1 week working on a dynamic table and ready to present it to my client, I moved it to build only to see that no row was showing up, despite all the functionality (filters, etc) working as displayed by the row count attribute.

I am also facing this issue. Both the Header and Cells are empty when i build for production but everything works fine in dev mode. Can someone pls help out?

I was also facing this issue with version 7.7.0. It worked perfect locally, but in production build I couldn't see anything. Downgrading to 7.0.2 helped.

I had to downgrade too


Doc changes for 2.5.0 and 1.7.2

@bganapa  @mattbriggs

Docs Build status updates of commit 03b6bb1:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/azure-docs-powershell, working directory: W:\h1m3-s, target branch: master, target branch commit: 3e142234752b7b79c0ff4801ac41aa3329757746, source commit: 03b6bb15e73c25c7c5ad59e9ea53b31459c84428.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix/finding #2 Fix Salt Determinism

This PR addresses security audit finding #2 regarding non-deterministic salt computation in the createAccount function across several factory contracts. The following updates were made:

K1ValidatorFactory:

Updated NatSpec documentation.
Fixed non-deterministic salt issue by ensuring all parameters are correctly hashed together.

NexusAccountFactory:

Rewritten assembly code for correct salt computation.
Added missing NatSpec documentation.

RegistryFactory:

Corrected assembly code for deterministic salt computation.
Optimized gas usage by changing isModuleAllowed from public to private.

Test Cases:

Added tests to verify that manually computed addresses match those generated by the updated computeAccountAddress function, ensuring the correctness of the salt computation fix.

audit finding #2 is linked wrong. it links to some issue

please check


Added a VSCode project folder along with a README for instructions.

Nice work! Do we need the .vscode directory here??? Or is that all personal config stuff?

Nice work! Do we need the .vscode directory here??? Or is that all personal config stuff?

Yep, it's required to tell VSCode how to go about compiling the code.

The .vscode directory may have been gitignored... We can make a .gitignore with !.vscode to un-ignore it in this directory.

Ok, I think this should do it. Sorry about that mistake.


High cpu usage and maybe memory leak

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ X ] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
I run skywalking in our uat env, cpm about 1000, It's pretty small right?
I use a 4core/16G machine to deploy skywalking, when I use 2g memory, it will crash in 15min.
when I use 8G memory, It will crash after one night.
I want to know it normal?

23200 root      20   0 12.2g 8.7g  22m S 374.2 56.1  32:53.31 java
22170 elastics  20   0 10.3g 2.6g 206m S  3.0 17.0  40:37.98 java
24113 root      20   0 15036 1300  944 R  0.3  0.0   0:00.27 top

Bug

Which version of SkyWalking, OS and JRE?
skywalking 6.5.0
os Red Hat Enterprise Linux Server release 6.5 (Santiago)
JRE 1.8_152
I have test it on the java11, but problem as before.

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

Which storage are you using? If you are just using quick-start, which is a memory mode. We highlighted that in the document already.

Which storage are you using? If you are just using quick-start, which is a memory mode. We highlighted that in the document already.

but I use elasticsearch.

Then you should analysis the memory dump file. We may could have a clue there.

Then you should analysis the memory dump file. We may could have a clue there.

thanks, I will try.


Convert RestartPolicy to string for v1beta3.

Fixed #3607 and spiritually support #5475
cc/ @bgrant0607

Thanks! LGTM.


Ask for the text pull secret instead of a file

Each time the user clicks start, the tray asks for the pull secret.
We could ask the user to copy/paste the secret in a text box and put it in the keystore for future usage.

The daemon API doesn't support this currently, we can only pass the path to pull-secret-file for the start command. also the config pull-secret-file is available in the preferences window which  user can configure.

done in https://github.com/code-ready/tray-macos/pull/110


Fix suggested by STATIC_CALLED_ON_INSTANCE warning is incorrect

Godot version
v4.0.stable.official [92bee43ad]
System information
Steam OS Holo, Steam Deck
Issue description
The STATIC_CALLED_ON_INSTANCE warning includes a suggested fix, which only applies when the static function is defined in the base class.  Attempting to follow the suggestion blindly (which novice programmers may do) causes an error.
Test.gd:
extends Node

static func foo():
	pass

func _process(delta):
	foo()

The warning printed by Godot in the case above is as follows, even though Node.foo() doesn't exist:
W 0:00:00:0454   The function 'foo()' is a static function but was called from an instance. Instead, it should be directly called from the type: 'Node.foo()'.
  <GDScript Error>STATIC_CALLED_ON_INSTANCE
  <GDScript Source>Test.gd:7

It's not clear to me what the correct fix is in this case, because the script doesn't provide a class name.  But it's worth noting that the STATIC_CALLED_ON_INSTANCE warning is unchanged by defining a class_name.
I suspect this may be a case where it's hard to print an accurate and reliable suggestion.  Maybe it would be better to phrase it as an example, instead, and not try to detect the base class?
W 0:00:00:0454   The function 'foo()' is a static function but was called from an instance. Instead, it should be directly called from the type, for example: 'Type.foo()'.
  <GDScript Error>STATIC_CALLED_ON_INSTANCE
  <GDScript Source>Test.gd:7

Steps to reproduce
N/A
Minimal reproduction project
N/A

Without a class_name one would probably have to do preload("res://path/to/class.gd").foo().

Still present in 4.0.1. It uses the base class even if class_name is provided

This is quite problematic if the script in question does not have a class_name set.
Without class_name, there is no good way to refer to the class itself.
Using preload("res://path/to/class.gd") feels very hack like to me.
Maybe this could be solved by introducing a keyword to refer to the class itself, something like Self.foo() maybe.
But looks like, at least this warning can be ignored on the project settings level:
debug/gdscript/warnings/static_called_on_instance

It doesn't seem like there's any good way to tell a developer how to fix their code.

Does the code actually needs fixing in the first place?
The code you posted in your original comment works correctly.
The engine correctly identifies the static function, and calls it successfully.
Why is it even a warning to call a static function without specifying the type?
Especially as the type does not always exists, and forcing the type to be present can not be correctly done for all valid cases.
As I stated before, the preload seems like a hack, and the extra resource paths introduced makes refactoring more difficult if the script is moved in the file system.
And adding a class_name needlessly pollutes the global namespace, which I would say is even worse.
If the type can not be specified, and any solution leads to a worse code, then issuing the warning itself is actually the problem.
This could be solved by the following ways:

Introduce a way to always be able to refer to the type of the current class (E.g.: Self keyword).
But introducing a new keyword is not an easy task, and it would probably needs a dedicated discussion on it.
Do not issue the warning if the correct type can not be specified.
This leads to the question: Why do we want the developer to use the type if available, otherwise being OK with it.
Remove this warning type altogether.

Does anybody see a problem with that? If not, I'll open a PR.

This would make the situation better but the underlying issues would still remain.
The developer would try to look for a good solution while there is none, wasting time and energy, leading to bad user experience.

I just ran into this and I'm also confused why it's an error in the first place.
My situation is basically:
Foo.gd (autoload)
extends Node

static func foo():
	pass

Bar.gd
extends Node

func _ready():
    Foo.foo()

It seems to work as intended. And it's not like I need a class_name because that's what the autoload is already doing. So what's the point of the error?

Does the code actually needs fixing in the first place? The code you posted in your original comment works correctly. The engine correctly identifies the static function, and calls it successfully.
Why is it even a warning to call a static function without specifying the type?

I think it is bad practice.  The code works, but because the function is static it could be doing something that the user did not intend.  Maybe the developer is calling the static function for every instance of an object (but the developer who wrote the class intended for them to call it once), or the developer thinks they're modifying an instance (but they're not).
I think this is why it is a warning and not an error -- Godot is encouraging the developer to take a second look at the line, not necessarily to correct it.  The warnings about integer division, etc, have similar behavior.
This is why I'm focusing on what the warning says rather than why it exists.  I agree that developers should take a second look at code that calls static functions from an instance.  But following the advice in a warning shouldn't make the situation worse, and definitely shouldn't lead to an error -- that's a bad user experience.

This would make the situation better but the underlying issues would still remain. The developer would try to look for a good solution while there is none, wasting time and energy, leading to bad user experience.

I disagree that there is no good solution.  I agree there is no universally good solution, but there are solutions.  Adding a class_name or using @warning_ignore might be good solutions, depending on the codebase.

It seems to work as intended. And it's not like I need a class_name because that's what the autoload is already doing. So what's the point of the error?

@craigostrin: It's not an error, it's a warning.  You don't have to fix it unless you want to.
I personally think in your case the warning might be helpful.  If all the functions in Foo are static, then you might not need an autoload.  If there's only one instance of Foo in the scene tree, the function probably doesn't need to be static.  I don't think these features are the same: static makes functions available without an instance of the class, and autoload automatically adds an instance of the class to every scene.

At some point this issue has worsened. Now, if you do this to try to appease the warnings:
class_name NameOfClass
extends Node

static func foo():
	pass

func _process(delta):
	NameOfClass.foo()

you get this fun compiler error:
res://name_of_class.gd:9 - Compile Error: Identifier not found: NameOfClass
Is this a bug of it's own or expected? Someone tell me. But it makes the warnings extra annoying.
No idea when it sprung up, but I'm on v4.2.beta.custom_build [09946f79b]
Anyways, honestly, the warning should be done away with for classes calling their own static functions. No other language that I know of spits a warning if you do that. It's generally actually the expected usage.

The code works, but because the function is static it could be doing something that the user did not intend

What, exactly, can a static function do that an instance function cannot? I understand warning or even disallowing static functions called from instance variables: the user probably intended to do something to or retrieve some value from the instance. But calling a static function from its own class without a qualifier? What danger could that even pose if a programmer thought they were calling an instanced function? It will likely still do exactly what they intended, unless the static function was very poorly designed and documented in the first place.


Peer Dependencies Error

It looks like recent versions of react-addons-shallow-compare (15.x.x) cause peer dependency problems:
npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>
Dropping back to 0.14.8 works fine.

@haydn looks like "react-addons-shallow-compare" should be in peerDependencies with a permissive version number, and in devDependencies with >=0.14.0 <0.15.0.

Closing this issue since #74 is now landed (please install react-vis 0.3.4 or later to use this change).


Make the URL meaningful

It could be great if I could send a request to another developer by just copying the URL of the extension.
Instead of always be
chrome://restclient/content/restclient.html
we could get something more useful like
chrome://restclient/content/restclient.html#method=GET&ulr=http://example.com/api

I think this will be hard if you consider that it also has to work for other HTTP methods (POST, PUT, PATCH), using custom HTTP headers (maybe containing secret authentication data) and probably huge HTTP bodies.

That is exactly what I am thinking.
The verb (POST, PUT) the headers and the HTTP body can all be stored in a URL (probably the bodies are the ugliest of them to show in an URL, but who cares, it can even be compressed).
Your concern about secret auth data should not be so terrible if we think this tool is for developers testing APIs. What I am afraid is that the browser won't be able to manage really long URLs.


Running Riak on a modern OTP version (19-22)

We're working on updating the erlang package for homebrew and we have an open question surrounding the version of erlang required for riak. It looks like version 17 is the most recent version of erlang that is compatible based on my reading of the rebar config. However, the most recent release of v17 is 4 years old, and there have been many developments in the language since then.
I'm not an expert in riak so I'm uncertain if there is a reason why we shouldn't be able to upgrade. If anyone could provide a bit more detail on the specifics for this choice I would greatly appreciate it.

@tomciopp there's quite a bit of ongoing work to run riak on OTP20. It's at a point where it compiles, but is not yet releasable. I'd anticipate that it might be around 3 - 6 months before we get to that point.


Automated cherry pick of #2349: fix: project_id/domain_id was cleared after FetchProjectInfo/FetchDomainInfo called

Cherry pick of #2349 on release/2.12.
#2349: fix: project_id/domain_id was cleared after FetchProjectInfo/FetchDomainInfo called

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@559a98b). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.12   #2352   +/-   ##
==============================================
  Coverage                ?    7.1%
==============================================
  Files                   ?     454
  Lines                   ?   71406
  Branches                ?       0
==============================================
  Hits                    ?    5073
  Misses                  ?   65915
  Partials                ?     418

Flag
Coverage Δ

#aFlag
7.1% <0%> (?)

Impacted Files
Coverage Δ

pkg/cloudcommon/db/fetch.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 559a98b...e77fd75. Read the comment docs.

/approve
/lgtm


How to combine multi TypedException in one decorator?

Question
Because of reuse in many places, I want to do the following, but when I run the  npx nestia swagger command, it doesn't work.

import { applyDecorators } from "@nestjs/common";

export function TypiaHttpExceptionCommon(): MethodDecorator {
  return applyDecorators(
    TypedException<IAppResponse>(400, 'description 400'),
    TypedException<IAppResponse>(404, 'description 404'),
    TypedException<IAppResponse>(500),
  );
}

@Controller('user')
export class UserController {
  constructor(private readonly userService: UserService) {}

  /**
   * @tag User
   */
  @TypedRoute.Post()
  @TypiaHttpExceptionCommon()
  create(@Body() createUserDto: CreateUserDto) {
    return this.userService.create(createUserDto);
  }

  @TypedRoute.Get()
    @TypiaHttpExceptionCommon()
  findAll() {
    return this.userService.findAll();
  }

  @TypedRoute.Get(':id')
  @TypiaHttpExceptionCommon()
  findOne(@Param('id') id: string) {
    return this.userService.findOne(+id);
  }

Is there any other way I can implement it?
and is there a ClassDecorator to set tags in swagger?
i found only commentdoc for each function @tag public, it will repeat the code
/**
     * Deprecated API.
     *
     * Would be marked as "deprecated".
     *
     * For reference, top sentence "Deprecated API." can replace the `@summary ` tag.
     *
     * @tag public
     * @summary Public API
     * @returns Updated content
     */
    @TypedRoute .Put ( ":id" )
     public async update (){}

Here is not nestia, but no idea yet about your issue.

About Tag decorator, nestia v2 supports it.


Problem_Statement_18

Given a string num that contains only digits and an integer target, return all possibilities to add the binary operators '+', '-', or ''
between the digits of num so that the resultant expression evaluates to the target value.
Example :
Input: num = "123", target = 6
Output: ["12*3","1+2+3"]

I'm Aditi Oak (TY, E&TC) (CCEW , Pune) . I would like to work on this issue.

You have been assigned this problem statement. You will be getting 3 days to work on it. All the best.

Submitted!

HI @aditioak  Thanks for creating the PR on time. Although, for the next issue we hope to see you work harder on writing your own solutions. Merged your solution


Feat/add owallet

[x] Add Owallet extension adapter
[x] Update README , include link to Owallet extension
[x] Passed lint  & test

asset-manifest.json

zenledger-20230929-163048.csv

@toandq2009 Hi, I can't merge this because this branch has conflicts with main branch. Can you try merge main and try resolve the conflicts first ?

@toandq2009 Hi, I can't merge this because this branch has conflicts with main branch. Can you try merge main and try resolve the conflicts first ?

Thank you, twhy. I have resolved the conflicts on this branch. Now you can merge my branch.


1.1.1

@rultor release, tag=1.1.1

@rultor release, tag=1.1.1

@jloisel OK, I will release it now. Please check the progress here

@rultor release, tag=1.1.1

@jloisel Done! FYI, the full log is here (took me 6min)


Campaigns Lister Page (Admin) Update button to use text rather than an icon

On the Administrator Campaigns Lister Page (e.g. http://allready-d.azurewebsites.net/Admin/Campaign) we have a publish button which is shown if the campaign is in draft.
This uses a very unclear icon. We should replace the icon with the text "Publish" instead. Here is the current button...

Closed via #2292


Is it possible to send messages with attachments via API?

As you guys know, I'm building a PHP library for Papercups. I'm also building an app and making use of this Papercups, but I paused when I didn't know how to upload an attachment and send it at the same time.
I tried monitoring Network on DevTools and found /api/upload, and I managed to write code like here and here.
With that function I get a response like this
{
  "content_type": "image/jpeg",
  "file_url": "https://papercups-files-test.s3.amazonaws.com/...",
  "filename": "...",
  "id": "fb15ed9c-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
  "object": "file"
}

Then I tried to send a message with an additional key, namely "attachments" with the resulting value from the json above, but when the webhook arrived on my server, the attachment only contained an empty array and on the Papercups dashboard there was no attachment.
Are attachments not supported for the API yet?
Thank you😀

at the moment this is not possible, but we'll fix it soon!


DateTimeEditor has no localization of the hint 'set to now'

Please, add a localization to the inplace button hint in the DateTimeEditor.ts
$("

").attr('title', 'set to now')

Good job! Thanks.


How to apply a workload to many clusters? Do I have to create multiple ManifestWorks?

If i want to apply a deployment to cluster a and b, do I have to create two ManifestWorks to apply the deployment to cluster a and cluster b? If i want to update the workload, do I have to update all the ManifestWorks about the workload?

no, you don't

use placement

/close
this repo is going to be archived, please create an issue in ocm repo


security stuff (ssl cert verification, connecting to http(s))

docker-py is able to turn off ssl certificate verification and is able to connect to plain http registries (by default it requires https).
This should be configurable and I think, it should verify certificates by default (same for https).
What do you think? @hhorak @vpavlin @humaton

create an option for this


chore: release 1.2.2

:robot: I have created a release *beep* *boop*
1.2.2 (2021-05-14)
Bug Fixes

unused env variable in module template (7d3b567)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/keq-request/keq-cli/releases/tag/v1.2.2 :sunflower:


Import tilebbox from vt-util

It is used in the SQL created by generate-sqltomvt

This repo has been merged into https://github.com/openmaptiles/openmaptiles-tools#importing-into-postgres.  Please re-submit this PR there. Thanks!

Also, note that PostGIS 3 adds ST_TileEnvelope(), which is likely faster than the one in postgis-vt-util. I think we might as well just copy the code (since it is just one function that is likely to eventually go away), and wrap it in an IF condition, checking if the current postgis version is < 3. If it is, create the polyfill ST_TileEnvelope.  The only downside is if someone tries to migrate their existing database to PostGIS 3, the upgrade script might try to re-create it automatically.

please close - this PR is not needed.


Remove 'trigger' requirement

Use case
I'd like to only open the popper programmatically, which I am currently achieving toggling the 'force-show' prop. However when I click on the component, I want to have some things happen in the contents of the reference slot before the click event fires.
Suggestion
Set the 'trigger' prop to accept a empty string '' value (or something along those lines)
props: {
     trigger: {
        type: String,
        default: 'hover',
        validator: value => ['click', 'hover', ''].indexOf(value) > -1
      },
      ...
}

sure! something like this would work:
<template>

        <popper ref="popper" :force-show="showPopper">

wazam

shazam

        </popper>
        <button @click="openPopper">openpopper</button>

</template>

This would be very useful, can I add that it would be great if the document-click event would still be fired when no trigger is given.

I have edited your solution to get rid the trigger issue,
Add popper to a dummy div under (or above) the target element.
If the div has zero height, it won't be clickable
You can use 'force-show' prop to toggle it

shazam

<popper ref="popper" :force-show="showPopper">

wazam

 </popper>

<button @click="openPopper">openpopper</button>

Thanks bagelbyte and geongeorge. The reason why I need to use this type of programming method is because I have interactive components inside the popper and if they effectively make the HTML reactive, the popper gets dismissed. I tried to use click.prevent, but that didn't help. It would stop the popper from dismissing, but only if there was a non-reactive change.
I do have success with dynamic reactivity (loading spinner -> show data), but specifically when I insert rows into a table or toggle a row's visibility, the popper dismisses and without error. Using force-show works around this problem.
The side effect of all of this is that the user can no longer dismiss the popper by clicking outside of the popper. They now need to toggle or use a close button. Is there a way I can gain that feature back? Like emit an event clickOutside?

if 'force-show ' was used , don't listener trigger events.
mounted() {
        this.referenceElm = this.reference || this.$slots.reference[0].elm;
        this.popper = this.$slots.default[0].elm;

        // add next line
        if (typeof this.forceShow === 'boolean') return

        switch (this.trigger) {
            // ...
        }
    },

It's solution ?


Broken fragments in "Terms defined by reference"

For example, in https://drafts.csswg.org/css-flexbox-1/#index-defined-elsewhere , if I click "fragmentation context", the panel says:
Referenced in:
• 10. Fragmenting Flex Layout (2)

10. Fragmenting Flex Layout links to https://drafts.csswg.org/css-flexbox-1/#ref-for-fragmentation-context , and (2) links to https://drafts.csswg.org/css-flexbox-1/#ref-for-fragmentation-context①, which is a broken fragment.

It seems to be fixed by https://github.com/tabatkins/bikeshed/commit/0da7328bb90ef81993146377e4e0fed236969c4c
Closing.


GLSL to bgfx .bin via ANGLE

Hey all, I really like bgfx, but I would rather use standard GLSL and profit from all the resources (WebGL etc.).
So I built shader_translator.exe and used it on this fragment shader:
precision mediump float;
varying vec4 v_forFragColor;
void main()
{
	gl_FragColor = v_forFragColor;
}

Command line:
shader_translator.exe -b=h11 -o fs.frag

It produces this output:
#### BEGIN COMPILER 0 INFO LOG ####

#### END COMPILER 0 INFO LOG ####

#### BEGIN COMPILER 0 OBJ CODE ####
#ifdef ANGLE_ENABLE_LOOP_FLATTEN
#define LOOP [loop]
#define FLATTEN [flatten]
#else
#define LOOP
#define FLATTEN
#endif
// Varyings
static  float4 _v_forFragColor = {0, 0, 0, 0};

static float4 gl_Color[1] =
{
	float4(0, 0, 0, 0)
};

cbuffer DriverConstants : register(b1)
{
};

#define GL_USES_FRAG_COLOR
;
void gl_main()
{
(gl_Color[0] = _v_forFragColor);
}
;

#### END COMPILER 0 OBJ CODE ####

Then I save the source code of it (and rename gl_main to main, otherwise "no entrypoint" error) as raw_glsl.frag and use shaderc.exe like this:
shadercDebug.exe --raw  -f raw_glsl.frag  -o shaders/dx11/fs_cubes.bin --platform windows --type fragment -p ps_4_0

The shader actually does compile and a .bin is generated, but the fragment shader totally changes its function:
How it's supposed to look:

How the raw HLSL shader generated through ANGEL looks:

Does anybody know how to get "correct" results?

bgfx is using GLSL. Not sure what you're trying to achieve here.
Also bgfx binary shaders are not plain HLSL/GLSL/etc. you need to correctly format header for it because it contains some reflection data.

Uhm, what do you mean with "bgfx is using GLSL"?
I tried to use a GLSL shader, but it needs be be converted with several steps, example of this vertex shader: http://www.mathematik.uni-marburg.de/~thormae/lectures/graphics1/code/WebGLShaderLightMat/ShaderLightMat.html

Rewrite the varying stuff
I can't use the global const variables. The shader will compile but just doesn't work
This syntax is not supported: vec3 vertPos = vec3(vertPos4) / vertPos4.w;
And the * for matrices, so using mul() instead

Hm, true about the reflection data. I have no clue where the reflection data is derived from (e.g. from HLSL or GLSL shader or the bgfx shader), never looked into that.
Basically what I try to archive is to use GLSL shaders without fitting them into bgfx shader language. Would be awesome to just take GLSL shader examples and make them run inside bgfx.

Would be awesome to just take GLSL shader examples and make them run inside bgfx.

Do you really think I just arbitrarily added those restrictions? The reason why you're not achieving what you want is because you're not providing all the data for bgfx to function correctly. If you don't want to use bgfx shaderc GLSL syntax, you have to provide all the data shaderc produces during compilation. So figure out how to get reflection data, how to store it, etc.


Performance improvements with use of SPI API

Hi, I have changed just 2 rows of the LedControl.cpp so that the library can use the SPI protocol.
I added

#include <SPI.h>  as the first row,
SPI.transfer(spidata[i-1]); at row 206 instead of shiftOut(SPI_MOSI,SPI_CLK,MSBFIRST,spidata[i-1]);

With this simple changes now I'm able to show a message with an high scrolling rate (depending also on how you initialize the SPI interface).
This is the initialization chunk in the setup() function:
...
SPISettings settingsA(8000000, MSBFIRST, SPI_MODE0);
void setup() {
  // initialize SPI:
  SPI.begin();
  SPI.beginTransaction(settingsA);
  ...
}

Yes, thanks for the enhancement.
I know that hardware SPI is much faster than my bit-toggle solution. By the time I wrote the LedControl library the arduino IDE did not have a SPI-library and using SPI would frequently clash with  other SPI-controlled devices.
I never changed the LedControl implementation because (for me) one of the main features is that you can use any 3 IO-Pins to connect your device.  You are not tied to the Hardware-SPI pins.
If you don't mind I'll leave this issue open so others can see how you did it...
Thanks for the contribution
Eberhard

OK, thanks for your answer. I'm agree to leave the issue open.
If you are interested, I have also do a porting to the Raspberry Pi (very easy thanks to your clean code, always with the SPI) that use the bcm2835 library.

I love the library but would also like to have the option of hardware SPI.  Can we not merge the two techniques and give the users the option of hardware vs bit banged?

I have a created fork that allows the choice between hardware and software SPI.


GH-34347: [C++] Add an initial fuzz test for the scanner

This is just an starting point.  There are a number of different things that will hopefully be eventually added (support for more formats, different scanning scenarios, running multiple scans in parallel).
It's currently exposed as a unit test and can maybe be a bit slow (takes ~30 seconds with one thread on my machine).  Eventually it might make more sense to change this to a nightly test that runs for a longer duration.  We should also probably have a version that runs on release mode.
I also fixed an issue encountered with partition guarantee normalization.  I could separate that into a separate PR if desired.

Closes: #34347

These test failures are legimate.  I hacked at this a little today and it quickly started to get out of control :laughing:
The basic issue is that I am transferring to a model where all expressions (projections, filters, guarantees) get normalized as we start to work with them.  This allows us to cleanly handle duplicate column names and similar issues.  Unfortunately, it's exposing a number of places in the current datasets code where we are explicitly relying on named refs and I am needing to work around that.

Closing because it has been untouched for a while, in case it's still relevant feel free to reopen and move it forward 👍


error callback may not happen on timeout

The NSI error callback may fail when a reservation times out. The oscars connection is deleted before the message starts getting sent resulting in db lookup error.

This was happening because NSI error callbacks were spun off in separate threads that then would have a race condition with the main thread. Decided to just put this work back into the main thread & block until done.


create author class and also set the list of authors

[ ] Create an Author class with an association to the Item class (in a separate .rb file).
All Author class properties visible in the diagram are defined and set up in the constructor method.
set the author list

Hi @huzaifakhan0308 5 👋,
Status: Approved 🟢
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights

All linters checks passed ✔
Created Author Class in separate .rb file ✔
All the Author Class properties that are in the Uml are present and set up in the constructor method ✔
Method to list the authors is present as well  ✔

Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.


Fix HTML search not working with Sphinx-1.8.

Unfortunately, Sphinx-1.8 breaks HTML search on sphinx_rtd_theme.
(see: https://github.com/sphinx-doc/sphinx/issues/5460 )
To fix that, could you merge this please?
I'm sorry for trouble you.
Thanks,
Note:
Since Sphinx-1.7, Sphinx has exported search options as
documentation_options.js.  This starts to refer it instead of
definitions of JavaScript variables.
In addition, this also uses js_tag() function which added in 1.8
to support additional attributes for scripts (ex. async attribute).

+1 for using scripts block.

I am all for using blocks also.

An issue about the broken search was just filed #673 and I don't have time to do a full "inherit stuff from the base theme using blocks" effort, so let's proceed with these changes (once reviewed) so we keep search functionality with Sphinx 1.8+
Refactoring to extend the base theme is a longer term goal that should still happen.

@agjohnson @ericholscher Poke, we need to do a release!

I'm also not super into the conditional logic used here, but agreed it's best for now. I'll open an issue to readdress this in our next release and get a release of 0.4.2 out

release v0.4.2 including this sphinx 1.8 fix soon?


CLIMATE-852 Addressing warnings in ocw documentation build

Addressed the warnings in documenation.
Made the conf.py code PEP8 compliant.

Merged build triggered. Test Failed.

@lewismc can you please check if you are able to reproduce the warnings once again. Thanks.

closing this off, since it is a duplicate of #410


[FLINK-10255] Only react to onAddedJobGraph signal when being leader

What is the purpose of the change
The Dispatcher should only react to the onAddedJobGraph signal if it is the leader.
In all other cases the signal should be ignored since the jobs will be recovered once
the Dispatcher becomes the leader.
 That way we can avoid race conditions
between granting and revoking leadership as well as the onAddedJobGraph signals. This is
important since we can only lock each JobGraph once and, thus, need to make sure that
we don't release a lock of a properly recovered job in a concurrent operation.
cc @GJL
Brief change log

Only react to SubmittedJobGraphListener#onAddedJobGraph when being the leader
Serialize recovery operations by introducing a recoveryOperation future in order to avoid wrong unlocking of guarded resources

Verifying this change

Added ZooKeeperHADispatcherTest#testStandbyDispatcherJobExecution and ZooKeeperHADispatcherTest#testStandbyDispatcherJobRecovery

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Travis show relevant failures, will take a close look later.
testGrantingRevokingLeadership(org.apache.flink.runtime.dispatcher.DispatcherHATest)  Time elapsed: 0.024 sec  <<< ERROR!
org.apache.flink.runtime.util.TestingFatalErrorHandler$TestingException: java.lang.UnsupportedOperationException: Should not be called.
	at org.apache.flink.runtime.util.TestingFatalErrorHandler.rethrowError(TestingFatalErrorHandler.java:51)
	at org.apache.flink.runtime.dispatcher.DispatcherHATest.teardown(DispatcherHATest.java:98)
Caused by: java.lang.UnsupportedOperationException: Should not be called.
	at org.apache.flink.runtime.dispatcher.DispatcherHATest$BlockingSubmittedJobGraphStore.releaseJobGraph(DispatcherHATest.java:306)
	at org.apache.flink.runtime.dispatcher.Dispatcher.lambda$null$26(Dispatcher.java:809)
	at org.apache.flink.util.function.BiFunctionWithException.apply(BiFunctionWithException.java:49)
	at java.util.concurrent.CompletableFuture.biApply(CompletableFuture.java:1105)
	at java.util.concurrent.CompletableFuture$BiApply.tryFire(CompletableFuture.java:1070)
	at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:442)
	at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:39)
	at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:415)
	at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
	at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
	at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
	at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)

Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.45 sec <<< FAILURE! - in org.apache.flink.runtime.dispatcher.DispatcherHATest
testGrantingRevokingLeadership(org.apache.flink.runtime.dispatcher.DispatcherHATest)  Time elapsed: 0.028 sec  <<< ERROR!
org.apache.flink.runtime.util.TestingFatalErrorHandler$TestingException: java.lang.UnsupportedOperationException: Should not be called.
	at org.apache.flink.runtime.util.TestingFatalErrorHandler.rethrowError(TestingFatalErrorHandler.java:51)
	at org.apache.flink.runtime.dispatcher.DispatcherHATest.teardown(DispatcherHATest.java:98)
Caused by: java.lang.UnsupportedOperationException: Should not be called.
	at org.apache.flink.runtime.dispatcher.DispatcherHATest$BlockingSubmittedJobGraphStore.releaseJobGraph(DispatcherHATest.java:306)
	at org.apache.flink.runtime.dispatcher.Dispatcher.lambda$null$26(Dispatcher.java:809)
	at org.apache.flink.util.function.BiFunctionWithException.apply(BiFunctionWithException.java:49)
	at java.util.concurrent.CompletableFuture.biApply(CompletableFuture.java:1105)
	at java.util.concurrent.CompletableFuture$BiApply.tryFire(CompletableFuture.java:1070)
	at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:442)
	at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:39)
	at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:415)
	at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
	at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
	at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
	at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)

A TaskManager should go into a clean state in case of a JobManager failure(org.apache.flink.api.scala.runtime.jobmanager.JobManagerFailsITCase)  Time elapsed: 121.247 sec  <<< FAILURE!
java.lang.AssertionError: assertion failed: timeout<PHONE_NUMBER>30 nanoseconds) during expectMsg while waiting for Acknowledge
	at scala.Predef$.assert(Predef.scala:170)
	at akka.testkit.TestKitBase$class.expectMsg_internal(TestKit.scala:387)
	at akka.testkit.TestKitBase$class.expectMsg(TestKit.scala:364)
	at akka.testkit.TestKit.expectMsg(TestKit.scala:814)
	at org.apache.flink.api.scala.runtime.jobmanager.JobManagerFailsITCase$$anonfun$1$$anonfun$apply$mcV$sp$3$$anonfun$apply$mcV$sp$4.apply$mcV$sp(JobManagerFailsITCase.scala:118)
	at org.apache.flink.api.scala.runtime.jobmanager.JobManagerFailsITCase$$anonfun$1$$anonfun$apply$mcV$sp$3$$anonfun$apply$mcV$sp$4.apply(JobManagerFailsITCase.scala:104)
	at org.apache.flink.api.scala.runtime.jobmanager.JobManagerFailsITCase$$anonfun$1$$anonfun$apply$mcV$sp$3$$anonfun$apply$mcV$sp$4.apply(JobManagerFailsITCase.scala:104)
	at akka.testkit.TestKitBase$class.within(TestKit.scala:345)
	at akka.testkit.TestKit.within(TestKit.scala:814)
	at akka.testkit.TestKitBase$class.within(TestKit.scala:359)
	at akka.testkit.TestKit.within(TestKit.scala:814)
	at org.apache.flink.api.scala.runtime.jobmanager.JobManagerFailsITCase$$anonfun$1$$anonfun$apply$mcV$sp$3.apply$mcV$sp(JobManagerFailsITCase.scala:104)
	at org.apache.flink.api.scala.runtime.jobmanager.JobManagerFailsITCase$$anonfun$1$$anonfun$apply$mcV$sp$3.apply(JobManagerFailsITCase.scala:85)
	at org.apache.flink.api.scala.runtime.jobmanager.JobManagerFailsITCase$$anonfun$1$$anonfun$apply$mcV$sp$3.apply(JobManagerFailsITCase.scala:85)
	at org.scalatest.Transformer$$anonfun$apply$1.apply$mcV$sp(Transformer.scala:22)
	at org.scalatest.OutcomeOf$class.outcomeOf(OutcomeOf.scala:85)
	at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
	at org.scalatest.Transformer.apply(Transformer.scala:22)
	at org.scalatest.Transformer.apply(Transformer.scala:20)
	at org.scalatest.WordSpecLike$$anon$1.apply(WordSpecLike.scala:953)
	at org.scalatest.Suite$class.withFixture(Suite.scala:1122)
	at org.apache.flink.api.scala.runtime.jobmanager.JobManagerFailsITCase.withFixture(JobManagerFailsITCase.scala:37)

Hi @tillrohrmann , is it possible that two async operation that modifies the same recoveryOperation at the same time? Would that be serializable in that case?

Thanks for the reply, that'll make sense.


Create BBC News Clone

Project title
Create a website clone for BBC News
Project Description
This is issue would create a clone for BBC News using HTML, CSS and JS.
Stack:
And in order to tick the check box just but x inside them for example - [x] like this. Please delete options that are not relevant.

[X] Html
[X] CSS
[x] JavaScript
[ ] ReactJS

/assign

@san-droid371 Hey I think you assigned it to yourself by mistake

@san-droid371 Hey I think you assigned it to yourself by mistake

no, I want to work on this.

@khushi-purwar Please resolve this issue

You have to assign the issue yourself by writing the /assign. @Kumar-laxmi you have created the issue 3 days ago. But you have not assigned it.. it is mentioned in the message.  @san-droid371  assigned it. Now @san-droid371 will work on it. @Kumar-laxmi you can create another issue.


Add Byron serialisation roundtrip property tests

Addresses #1090.
This is a sanity check that we can deserialise the serialised blocks/headers/txs/etc. We use the generators from cardano-ledger for this.

bors r+


CAMEL-10914: Apply the same fix as CxfConsumer to CxfRsConsumer

Follow-up fix to: https://issues.apache.org/jira/browse/CAMEL-10914
@WillemJiang @oscerd @davsclaus Can anyone merge this too, please?

@tadayosi sure

@tadayosi the PR has been merged. Can you close this? Thanks!

@oscerd Awesome! Thanks.


Add more Norwegian stations

In addition to the station in #160, there's:

[ ] NMBU in Års
[x] Agda University (also has spectral)
[x] IFE (also has albedo and spectral): https://ife.no/service/ife-pv-module-outdoor-test-site/
[ ] Tromsø Universitet

Tromsø station described in this thesis (supervised by Tobias Bostrom): https://munin.uit.no/bitstream/handle/10037/19123/thesis.pdf


Indentation rules?

I gave vue components a shot for the first time yesterday, and while the syntax highlighting for different regions seems to be working fine, I don't get any indentation rules. In my set up at least, I get no auto-indentation whatsoever, which is pretty annoying. (I'm using filetype indent settings with filetype plugin indent on.)
Is there any possibility of getting vim to adjust indentation settings to match the syntax regions this sets up?

Can you give an example file to try reproduce it?
While I'm aware indentation doesn't work very well, I've don't have a lot of experience with VimL and I really don't know how to fix that. However I still get the indentation right while editing css, js, jade and coffee.

Hm: I wonder why your indentation works. It could very well be something about my vim setup, I guess. Do you have filetype plugin indent on in your .vimrc?

I forgot to say, but yes, as I'm using Vundle I do have the filetype plugin indent on in my vimrc

Hm: I wonder why your indentation works. It could very well be something about my vim setup, I guess. Do you have filetype plugin indent on in your .vimrc?
This is an example .vue file. Here is my .vimrc file, though I don't really mean to implicate you in my own troubleshooting or what-have-you.
Right now my best thought is just to set up some simple key bindings to switch filetypes on the fly.
<style lang="sass">
.some-list {
	padding: 10px;
}
</style>

<template lang="jade">
.some-list
	.row
		.col-xs-12
			h1 Some Things
	.row
		.col-xs-12
			input(
				v-model='searchText'
				v-on:keyup='search'
			)

	.row
		.col-xs-12
			ul
				li(v-for='thing in things')
					a(
						href='{{ thing.user.username }}/{{ thing.slug }}'
					) {{ thing.name }}
					= ' '
					span.version(
						v-if='thing.version'
					) ({{ thing.version }})

</template>

<script>
module.exports = {
	props: [
		'things'
	],
	route: {
		data: function (transition) {
			this.$http({
				url: '/api/things',
				method: 'GET'
			}).then(function (response) {
				this.things = response.data.things;
				this.total = response.data.total;
				transition.next();
			}, function (response) {
				console.log('error', response);
			});
		}
	},
	data: function () {
		return {
			things: [],
			total: '',
			searchText: ''
		};
	},
	methods: {
		search: function () {
			this.$http({
				url: '/api/things',
				method: 'GET',
				params: { search: this.searchText }
			}).then(function (response) {
				this.things = response.data.things;
				this.total = response.data.total;
			}, function (response) {
				console.log('error', response);
			});
		}
	}
};
</script>

I tested the file and everything work as in any other file. I guess I didn't understand well the question.
Indentation partially works, which is, indeed, a shame. I found some clues here http://vim.wikia.com/wiki/User:Ipkiss/Using_vim_to_edit_tips#Comments I'll give it a try tonight :smile:

Sorry for not being clearer in my question. I can try to rephrase: in Vim, I've got special indentation rules for different filetypes, so indentation works differently in my JavaScript files from the way it works in Jade files or Sass files.
This plugin works as advertised: it changes the syntax highlighting for different regions of a .vue file that combines different languages, but it doesn't change indentation rules (nor does it bring in any of the other things linked to filetype in my vim setup, like linting).
That makes writing JavaScript, especially, in a .vue file a really inferior experience to the way it works in its own file.
That's not your responsibility to fix, by any means, I just wondered, since you're someone else clearly using Vim to create and edit Vue files, if you had any thoughts on a possible solution. If multi-language components are going to be a thing going forward, it seems like we Vim users need to figure out a way of bringing all the tools associated with filetype to files with language-specific regions.

It seems to me that multi region is not well supported in vim (it usually lags with big files). Adding syntastic support should be possible.
Making the plugin better is interesting. I'm open to contributions

I solved this problem by adding Plugin 'othree/html5.vim'.

@ijse Not changing anything for me regarding the indentation inside
Could you share a bit more of your setup ?
I currently change the filetype to html to indent inside

@rleger Yes, me too. and it works well, dosen't it?

Changing the filetype is the only thing that really deals with the issue, as it brings in not just proper indentation, but filetype-based tools like snippets, linting, etc. But that's really clumsy.
Assigning the filetype switch to some kind of shortcut improves things slightly, but it'd still be a lot better if there were some way of dynamically switching it.

@neagle exactly.
I wish vim could handle multiple languages in a single file better. I don't fully understand the difference between syntax and filetype though.
A filetype can have multiple syntax regions but the indentation and other language specific features seems to be ignored.
I have to look a bit more into syntax

@rleger don't forget to create a PR if you find a solution :smile:

Just started using vim yesterday and I came across this issue as well. As stated before it works fine with files with .html-extensions but not with .vue.
I installed othree/html5.vim and then added below in my .vimrc:
au BufRead,BufNewFile *.vue set filetype=html

Which sets the filetype to html. Now indent works as expected and highlight works nicely too.

@nivv Highlighting isn't perfect but to me it's the best solution yet, thank you for sharing.

Good new @neagle! #23 will fix this!

set filetype=vue.html did the trick for me. Gives me the region highlighting from this plugin and the indent rules of html 👍


Integrate helmet.js

https://github.com/helmetjs/helmet/blob/master/README.md

Done in nodebootstrap-microservices


Full website

Changes made:

Implemented routing with React.
Built the Home, Calculator, Quote, and NotFound pages for the website.
Added new styling to the pages.

Hello @arslanbisharat 👋
Thank you 🙌
I will proceed to merge the changes into the dev branch.
Best regards. 🚀


Polish SoundCloud provider implementation

I'm waiting on SoundCloud to allow new applications for API access and implementing other OAuth providers for my project. I came accross your PR and noticed that createS256CodeChallenge should be called from SoundCloud.createAuthorizationURL, per other S256 provider implementations (e.g. Zoom).

Thanks, saw your message on the arctic repo. Will merge this and then I guess once either of us  are able to get SoundCloud API access we can give this a test and then merge into arctic?
Thanks for the pr!


目录不能显示新创建的文件

新创建的文件不能在左侧目录上显示出来，但是实际上已经创建了，在终端下可以看到。

Translated:
The directory can not display the newly created file
Newly created files can not be displayed on the left side of the directory, but in fact has been created at the terminal can be seen.


/cast Auto Shot cannot be used when addon is enabled

When this addon is enabled, you cannot use /cast Auto Shot in a macro. It simply does nothing.

Odd. I cannot reproduce it now.. It happened non stop all yesterday, until I unloaded YaHT and it worked again.
I verified by re-enabling YaHT and the issue restarted... But today? Not reproducible... Whaaat?