async subscription context failing test

This PR is just a draft for a failing test that shows the async subscription context bug.
It basically the same as the existing test for custom context, but with an artificial delay simulating a common http request delay.

Would you mind to also fix it? I'm not sure what's the problem:/

Would you mind to also fix it? I'm not sure what's the problem:/

I found this solution (that could be improved with an isPromise helper function), which is to basically let the socket connection be created and delay the await until handleConnectionInit.
I'd like to know if it sounds good to you.

(or instanceof Promise if it should only support native Promises).

In the last changes I just assumed this, I honestly don't know if I can assume this

I found another kinda important thing, when an error happens inside the execution of a subscription the error is not being catched properly, and it just replies with the result is not async iterable .
Following the type definitions docs in graphql-js subscribe function, those errors are returned in the execution results without the promise itself being thrown.
I just added
if (result.errors) {
      throw result.errors[0];
}

in subscription-connection.js
And it works as expected.
I don't know if I should add it to this PR 🤷♂

@PabloSzx I wonder if your latest finding might be related to https://github.com/mcollina/fastify-gql/issues/208

@PabloSzx I wonder if your latest finding might be related to #208

Yes, it is,  it's ok if you assigned yourself this fix yourself👍
The graphql package itself validates the error thrown in the execution, it means there should be no need of validating the error inside result.errors, but I am not sure if it's needed to handle that there might be more than a single error.
Test I made in subscription.js if it's helpful at all

test('subscription server send correct error if execution throws', t => {
  const app = Fastify()
  t.tearDown(() => app.close())

  const emitter = mq()
  const schema = `
    type Notification {
      id: ID!
      message: String
    }

    type Query {
      notifications: [Notification]
    }

    type Subscription {
      notificationAdded: Notification
    }
  `

  const resolvers = {
    Subscription: {
      notificationAdded: {
        subscribe: () => {
          throw Error('custom execution error')
        }
      }
    }
  }

  app.register(GQL, {
    schema,
    resolvers,
    subscription: {
      emitter
    }
  })

  app.listen(0, err => {
    t.error(err)

    const ws = new WebSocket('ws://localhost:' + (app.server.address()).port + '/graphql', 'graphql-ws')
    const client = WebSocket.createWebSocketStream(ws, { encoding: 'utf8', objectMode: true })
    t.tearDown(client.destroy.bind(client))
    client.setEncoding('utf8')

    client.write(JSON.stringify({
      type: 'connection_init'
    }))

    client.write(JSON.stringify({
      id: 1,
      type: 'start',
      payload: {
        query: `
          subscription {
            notificationAdded {
              id
              message
            }
          }
        `
      }
    }))

    client.on('data', chunk => {
      const data = JSON.parse(chunk)

      if (data.id === 1 && data.type === 'error') {
        t.equal(chunk, JSON.stringify({
          type: 'error',
          id: 1,
          payload: 'custom execution error'
        }))

        client.end()
        t.end()
      }
    })
  })
})

I confirm the issue if the contextFn is async the subscription listener is missing the messages sent in the 1st PR test, but the 2nd test works. I guess we can't do async stuff before binding the message handler.
I think it would be better to remove the context creation from createConnectionHandler and pass the subscriptionContextFn to SubscriptionConnection constructor.
But this rises an other issue concerning connection_init and message order.
Based on apollo implementation https://github.com/apollographql/subscriptions-transport-ws/blob/52758bfba6190169a28078ecbafd2e457a2ff7a8/src/server.ts and https://github.com/apollographql/subscriptions-transport-ws/blob/master/PROTOCOL.md, if an onConnect handler is defined and returns false a GQL_START message should return a GQL_CONNECTION_ERROR.

@PabloSzx I just assigned myself as an ToDo item, because the person that has created the issue seems to be not interested in fixing & I have a slight feeling that this can hit us as well once we're done migrating from Apollo to Fastify. That being said, I would suggest that you can re-assign this to you & I also think it would be reasonable to fix it within this PR (of course, this is just my subjective opinion)

I confirm the issue if the contextFn is async the subscription listener is missing the messages sent in the 1st PR test, but the 2nd test works. I guess we can't do async stuff before binding the message handler.
I think it would be better to remove the context creation from createConnectionHandler and pass the subscriptionContextFn to SubscriptionConnection constructor.
But this rises an other issue concerning connection_init and message order.
Based on apollo implementation https://github.com/apollographql/subscriptions-transport-ws/blob/52758bfba6190169a28078ecbafd2e457a2ff7a8/src/server.ts and https://github.com/apollographql/subscriptions-transport-ws/blob/master/PROTOCOL.md, if an onConnect handler is defined and returns false a GQL_START message should return a GQL_CONNECTION_ERROR.

related to #207 I think

@PabloSzx I just assigned myself as an ToDo item, because the person that has created the issue seems to be not interested in fixing & I have a slight feeling that this can hit us as well once we're done migrating from Apollo to Fastify. That being said, I would suggest that you can re-assign this to you & I also think it would be reasonable to fix it within this PR (of course, this is just my subjective opinion)

I will do, no problem, plus the #207

I am hit big time by this atm, good to see that it's almost merged!


Matrix integration

Good job. I like your idea. But the main purpose of a social network is communication. It would be a great idea if your social network supported the matrix protocol at an early stage of development (https://element.io/). It implements this idea minds.com and other sites (https://gitlab.com/groups/minds/-/epics/84). Then you can communicate outside the social network, which will increase the status and benefit of the project for users.

We decided to have some central signup / user control, and mix this with distributed message servers. The reason to go this way is to prevent bad actors from joining / controlling pieces parts of the network.
Philosophically this may seem like a dangerous direction, but we (obviously) disagree. We want checks and balances. If independently controlled message hubs don't exist, the network dies. But if the message hubs become wastelands of hate and disinformation, the network admin has tools to deal with it.
Sure, this assumes that the network admin is somehow able to make judgements that suit the entire community. This could go south, or it could work beautifully, but will most likely be something in between and require some modifications as time goes by.


Appstudio update test-component-pac-wlex

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-wlex-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
30 seconds
build-container

✅ Succeeded
16 seconds
deprecated-base-image-check

✅ Succeeded
16 seconds
inspect-image

✅ Succeeded
2 minutes
clair-scan

✅ Succeeded
45 seconds
clamav-scan

✅ Succeeded
15 seconds
sbom-json-check

✅ Succeeded
9 seconds
optional-label-check

✅ Succeeded
9 seconds
label-check

✅ Succeeded
4 seconds
show-summary

Pipelines as Code CI/test-component-pac-wlex-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
9 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
31 seconds
build-container

✅ Succeeded
14 seconds
deprecated-base-image-check

✅ Succeeded
13 seconds
inspect-image

✅ Succeeded
37 seconds
clamav-scan

✅ Succeeded
10 seconds
clair-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
13 seconds
label-check

✅ Succeeded
12 seconds
optional-label-check

✅ Succeeded
5 seconds
show-summary


Can't access the WSL discussion forum so I publish my issue here

I can't access the WSL forum under http://wsl-forum.qztc.io/ from some reason. When I try to, I get "This site can't be reached".

Maybe it's due to the fact I'm new to Linux but I am looking for a way to download files from my VPS after I SSH tunneled into it via WSL. This will use me in making immediate backups of my files and SQL (wget and curl could download from a url, but of course, no domain here as it's just an SSH tunnel).
This is the code I wrote so far, but I miss a download utility (where it is written "download"):
zip -r /var/www/html/html.zip /var/www/html
mysqldump -u root -PASSWORD --all-databases > ./db.sql && zip ./db.zip ./db.sql
zip backup.zip html.zip db.zip
DOWNLOAD backup.zip /mnt/c/Users/USER/Desktop
rm /var/www/html/.zip*

Not sure, but maybe scp would serve your needs?

That seems to be the solution as I managed to copy a file to my users directory. But I must share something wired:
I don't have a c directory under /mnt. Suddenly.

Reported here:
https://github.com/Microsoft/BashOnWindows/issues/1864

Incidentally, thanks @Benosika for the heads-up about wsl-forum.qztc.io .  It seems to be back up now.  There must have been some sort of network issue -- it seemed to be working from some networks but not others.  (So far the forum hasn't gotten a whole lot of users so I haven't been able to justify paying for good hosting :-) )


Fix lost connection after resume

Fix lost connection after resume
I've also made a few additions to the parameters
Below all the changes (in the CHANGELOG.md file too)
New

MQTTClient: handles reconnection after disconnection

Change

Upgrade packages:

MQTTNet from 4.0.0-preview3 to <IP_ADDRESS>8
Newtonsoft.Json from 10.0.3 to 13.0.3
PlayniteSDK from 6.2.0 to 6.9.0

Metadata: add link to simeonradivoev GitHub project
Settings:

declare variable with the right type
add options for notification and show status changed
group options

MQTTClient: use new options to show or not notifications

Fix

MQTTClient: WithTls() is deprecated. Replaced by WithTlsOptions
MQTTClient: Add an explicit cast for the client declaration

Log

151da59 - feat(MQTTClient): use new settings for displaying message or notifications. Fix can't disconnect after a power resume.
663121c - feat(Settings): group settings in view. Add settings for display (QoL)
dc16494 - chore(metdata): add link to GitHub
2e32297 - chore csproj file change
d3756e8 - chore: restore code in PowerChange method
558e3dc - chore: remove unecessary using
2b364d0 - fix: add an explicit cast for CreateMqttClient()
892cf6c - chore: replace deprecated WIthTLS() method by WithTlsOptions()
17526d8 - chore: update plugin version
98c8a24 - feat: update MQTTnet, Newtonsoft.json and PlayniteSDK packages
f92d85f - feat: handle disconnection after power resume

Nice!

Now I have to figure out again how to build the plugin :(


prebuild-install doesn't find binaries

I recently have released an npm module, that is a C++ addon, using prebuild to compile binaries. Here my CI (I use github actions):
name: CI

on:
  push:
    branches: [master]

jobs:
  release:
    runs-on: ubuntu-latest

    env:
      GITHUB_TOKEN: ${{ secrets.AT }}

    steps:
      - uses: actions/checkout@v2
      - name: Use Node.js 14
        uses: actions/setup-node@v1
        with:
          node-version: "14"
      - run: |
          git config user.email<EMAIL_ADDRESS>          git config user.name "Matteo Di Sabatino"
          npm i
          npm test
          npm run release

  build-linux:
    needs: release

    runs-on: ubuntu-latest

    env:
      GITHUB_TOKEN: ${{ secrets.AT }}

    steps:
      - uses: actions/checkout@v2
      - name: Use Node.js 14
        uses: actions/setup-node@v1
        with:
          node-version: "14"
      - run: |
          git pull
          npm i
          npm run prebuild -- -u $GITHUB_TOKEN

  build-macos:
    needs: release

    runs-on: macos-latest

    env:
      GITHUB_TOKEN: ${{ secrets.AT }}

    steps:
      - uses: actions/checkout@v2
      - name: Use Node.js 14
        uses: actions/setup-node@v1
        with:
          node-version: "14"
      - run: |
          git pull
          npm i
          npm run prebuild -- -u $GITHUB_TOKEN

  build-windows:
    needs: release

    runs-on: windows-latest

    env:
      GITHUB_TOKEN: ${{ secrets.AT }}

    steps:
      - uses: actions/checkout@v2
      - name: Use Node.js 14
        uses: actions/setup-node@v1
        with:
          node-version: "14"
      - run: |
          git pull
          npm i
          npm run prebuild -- -u %GITHUB_TOKEN%

  publish:
    needs: [build-linux, build-macos, build-windows]

    runs-on: ubuntu-latest

    env:
      NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

    steps:
      - uses: actions/checkout@v2
      - name: Use Node.js 14
        uses: actions/setup-node@v1
        with:
          node-version: "14"
      - run: |
          git pull
          echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" > .npmrc
          npm publish --access=public

As you can read, first I use the module release-it in order to update the changelog, create the tag and the release, but not publish to npm. Then I build the source for Linux, macOS and Windows and, finally, I publish the module to npm.
I supposed all worked fine since the binaries have been attached to the release (see here) but I was wrong in fact, if I try to install my module via npm i @matteodisabatino/gc_info, I receive this warning prebuild-install WARN install No prebuilt binaries found (target=14.15.5 runtime=node arch=x64 libc=musl platform=linux).
I suppose this mean that the binaries are attached to the release but npm was not able to find them. What am I wronging?
P.S.: the command npm run prebuild runs prebuild --target 64 --target 72 --target 83 --target 88 --force --strip --tag-prefix \"\" since I decided to compile for Node.js 10, 12, 14 and 15 only.

prebuild-install WARN install No prebuilt binaries found (target=14.15.5 runtime=node arch=x64 libc=musl platform=linux)

Your prebuilds are linked against glibc and you are running a musl based distro. I don't see musl prebuilds in your release assets so prebuild-install is correct with the warning.

You gotta reason: I didn't know that alpine switched to musl. Sorry.
But using node:14-buster I also receive an error: prebuild-install WARN install No prebuilt binaries found (target=14.15.5 runtime=node arch=x64 libc= platform=linux). It seems prebuild-install was unable to find the libc version. Should I install some Debian package?
Moreover, is there a way to compile either against gblic and musl in order to use binaries with alpine too?

Ah, I see.. your tag format is not the default. Either rename your tags with a prefixed v like v0.0.2 or change your install script to overwrite the default prefix with --tag-prefix <prefix>         (github tag prefix, default is "v") to match your choice.
I don't have any experience with building against musl via CI but I think Github workflows can do something like
  alpine-linux:
    name: alpine 3.11.6 (musl)
    runs-on: ubuntu-18.04
    container: alpine:3.11.6

Thank you very much for your support 😀

Hi @mathiask88, sorry to bother again but I still have got problems: I created a new release in which I added tag prefix also for install (commit) but, despite this I'm still unable to download the binary.
I repeated the test of yesterday: I created a node container using image node:14-buster and then I installed my module but still I receive this error:
prebuild-install WARN install No prebuilt binaries found (target=14.15.5 runtime=node arch=x64 libc= platform=linux)

Very strange... seems like libc version is undefined.

Okay, so now we are talking about an issue :) Problem is this check in https://github.com/prebuild/prebuild-install/blob/master/util.js#L26 We currently ignore/overwrite empty tag prefixes. IMHO this should not be the intended behaviour. What do you think @vweevers ?

Ok, I'll what for this clarification. If the exposed one is the correct behaviour, the only thing I can do is modify release-it options in order to prepend the "v" to the releases and the delete the option the option --tag-prefix "" to prebuild and prebuild-install. But I don't know if it's possibile. We will see :-)

Okay, so now we are talking about an issue :) Problem is this check in https://github.com/prebuild/prebuild-install/blob/master/util.js#L26 We currently ignore/overwrite empty tag prefixes. IMHO this should not be the intended behaviour. What do you think @vweevers ? @ralphtheninja as well, you had the wish for that check in #90 (comment) :)

So the provided tag prefix is an empty string, which is falsey and then it falls back to 'v' anyway?

Okay, so now we are talking about an issue :) Problem is this check in https://github.com/prebuild/prebuild-install/blob/master/util.js#L26 We currently ignore/overwrite empty tag prefixes. IMHO this should not be the intended behaviour. What do you think @vweevers ? @ralphtheninja as well, you had the wish for that check in #90 (comment) :)

So the provided tag prefix is an empty string, which is falsey and then it falls back to 'v' anyway?

Correct and we set the default in rc.js anyway.

@matteodisabatino So if I understand correctly, your release use case looks something like:

you tag gc_info, like git tag 0.0.6 && git push --tags
github actions
npm run release
release-it --ci

Is this correct?

Hi @ralphtheninja,
No, the workflow is:

git push
github actions (=CI)
npm run release (=release-it --ci) --> this creates the release and the tag and updates the changelog
npm run prebuild
npm publish

@matteodisabatino Ah ok. And how does release-it determine which tag to set? Is that the https://github.com/release-it/conventional-changelog defined in your .release-it.json config?

@matteodisabatino I think these lines might be of interest: https://github.com/release-it/conventional-changelog/blob/master/index.js#L31-L32

I cannot answer with extreme accuracy because it's the time I'm using this module. From tests I made I've noticed that:

One or more commits starting with "fix" triggers a patch release
One or more commits starting with "feat" triggers a minor release
One or more commits starting with "refactor" + "BREAKING CHANGES" triggers a patch major

Sorry for spamming :smile:
conventional-changelog seems to be not using v as prefix, since the previously seen tag didn't have a v in it. And it looks like you can set tagName in the options passed to conventional-changelog. This should solve your problems.

Switching to the default v tag prefix is of course a solution for this. But I think we should allow an empty tag prefix, if someone wants to use it, whatever the reason is.

Switching to the default v tag prefix is of course a solution for this. But I think we should allow an empty tag prefix, if someone wants to use it, whatever the reason is.

Sure. I'm not against it. But @matteodisabatino could fix this right now without waiting for prebuild-install to be updated. Just rubber ducking a bit :smile:

@ralphtheninja Yes but this means I have to manually set the tagName anytime for every release... so bad... better configure release-it in order to let releases be prefixed by "v" but I don't know if such option exists.

@ralphtheninja Yes but this means I have to manually set the tagName anytime for every release... so bad... better configure release-it in order to let releases be prefixed by "v" but I don't know if such option exists.

No.

@ralphtheninja could you be more clear?

Check these lines https://github.com/release-it/conventional-changelog/blob/master/index.js#L32-L33
If you set configuration to conventional-changelog to something like:
{
  "git": {
    "commit": true,
    "push": true,
    "tag": true
  },
  "github": {
    "release": true
  },
  "npm": {
    "publish": false
  },
  "plugins": {
    "@release-it/conventional-changelog": {
      "preset": "angular",
      "infile": "CHANGELOG.md",
      "tagName": "v${version}"
    }
  }

Then tagTemplate at row 32 will have the value 'v${version} which means currentTag on row 33 will receive the value vx.y.z based on the value of x.y.z.

Thanks for the clarification 😄
I try immediately and I let you know.

@ralphtheninja, @mathiask88 We finally did it! (here the release) 😄😄😄😄😄😄😄😄 .
And here the correct release-it config:
{
  "git": {
    "commit": true,
    "push": true,
    "tag": true,
    "tagName": "v${version}"
  },
  "github": {
    "release": true
  },
  "npm": {
    "publish": false
  },
  "plugins": {
    "@release-it/conventional-changelog": {
      "preset": "angular",
      "infile": "CHANGELOG.md"
    }
  }
}

Thank so much all 😄.

@ralphtheninja, @mathiask88 We finally did it! (here the release) smilesmilesmilesmilesmilesmilesmilesmile .
And here the correct release-it config:

Aaaah, the config was supposed to be under git. Nice! :partying_face:

Yes, looking good..
npm i @matteodisabatino/gc_info --verbose --arch=x64

><EMAIL_ADDRESS>install C:\Users\mathi\Desktop\Neuer Ordner\node_modules\@matteodisabatino\gc_info
> prebuild-install || node-gyp rebuild

prebuild-install info begin Prebuild-install version 6.0.0
prebuild-install info looking for cached prebuild @ C:\Users\mathi\AppData\Roaming\npm-cache\_prebuilds\8f90e2-gc-info-v0.0.7-node-v83-win32-x64.tar.gz
prebuild-install http request GET https://github.com/matteodisabatino/gc_info/releases/download/v0.0.7/gc_info-v0.0.7-node-v83-win32-x64.tar.gz
prebuild-install http 200 https://github.com/matteodisabatino/gc_info/releases/download/v0.0.7/gc_info-v0.0.7-node-v83-win32-x64.tar.gz
prebuild-install info downloading to @ C:\Users\mathi\AppData\Roaming\npm-cache\_prebuilds\8f90e2-gc-info-v0.0.7-node-v83-win32-x64.tar.gz.15328-3f8b8dfb1349d.tmp
prebuild-install info renaming to @ C:\Users\mathi\AppData\Roaming\npm-cache\_prebuilds\8f90e2-gc-info-v0.0.7-node-v83-win32-x64.tar.gz
prebuild-install info unpacking @ C:\Users\mathi\AppData\Roaming\npm-cache\_prebuilds\8f90e2-gc-info-v0.0.7-node-v83-win32-x64.tar.gz
prebuild-install info unpack resolved to C:\Users\mathi\Desktop\Neuer<EMAIL_ADDRESS>prebuild-install info install Successfully installed prebuilt binary!

and after #143 lands this should have no prefixed v in the github URL anymore and  also work
npm i<EMAIL_ADDRESS>--verbose --arch=x64

><EMAIL_ADDRESS>install C:\Users\mathi\Desktop\Neuer Ordner\node_modules\@matteodisabatino\gc_info
> prebuild-install --tag-prefix "" || node-gyp rebuild

prebuild-install info begin Prebuild-install version 6.0.0
prebuild-install info looking for cached prebuild @ C:\Users\mathi\AppData\Roaming\npm-cache\_prebuilds\3d2e17-gc-info-v0.0.5-node-v83-win32-x64.tar.gz
prebuild-install http request GET https://github.com/matteodisabatino/gc_info/releases/download/v0.0.5/gc_info-v0.0.5-node-v83-win32-x64.tar.gz
prebuild-install http 404 https://github.com/matteodisabatino/gc_info/releases/download/v0.0.5/gc_info-v0.0.5-node-v83-win32-x64.tar.gz
prebuild-install WARN install No prebuilt binaries found (target=14.15.5 runtime=node arch=x64 libc= platform=win32)

And just for the sake of completeness the output of
npm i<EMAIL_ADDRESS>--verbose --arch=x64

with 6.0.1 (#143)
><EMAIL_ADDRESS>install C:\Users\mathi\Desktop\Neuer Ordner\node_modules\@matteodisabatino\gc_info
> prebuild-install --tag-prefix "" || node-gyp rebuild

prebuild-install info begin Prebuild-install version 6.0.1
prebuild-install info looking for cached prebuild @ C:\Users\mathi\AppData\Roaming\npm-cache\_prebuilds\8ef98c-gc-info-v0.0.5-node-v83-win32-x64.tar.gz
prebuild-install http request GET https://github.com/matteodisabatino/gc_info/releases/download/0.0.5/gc_info-v0.0.5-node-v83-win32-x64.tar.gz
prebuild-install http 200 https://github.com/matteodisabatino/gc_info/releases/download/0.0.5/gc_info-v0.0.5-node-v83-win32-x64.tar.gz
prebuild-install info downloading to @ C:\Users\mathi\AppData\Roaming\npm-cache\_prebuilds\8ef98c-gc-info-v0.0.5-node-v83-win32-x64.tar.gz.768-faa488445a2f9.tmp
prebuild-install info renaming to @ C:\Users\mathi\AppData\Roaming\npm-cache\_prebuilds\8ef98c-gc-info-v0.0.5-node-v83-win32-x64.tar.gz
prebuild-install info unpacking @ C:\Users\mathi\AppData\Roaming\npm-cache\_prebuilds\8ef98c-gc-info-v0.0.5-node-v83-win32-x64.tar.gz
prebuild-install info unpack resolved to C:\Users\mathi\Desktop\Neuer<EMAIL_ADDRESS>prebuild-install info install Successfully installed prebuilt binary!

Very good 😀. Thanks everybody ☺


karate-ui enhancements part 2

Add support for

resizing of featurePanel, rawContentPanel (vertical) and varsPanel (horizontal)
http request/response shown as addressable grid (clicking on method step to highlight corresponding row as mentioned in https://github.com/intuit/karate/pull/325#issuecomment-364824629)

@ptrthomas please review https://github.com/intuit/karate/pull/494 at your convenience

@vmchukky there's this big commit that dropped:
https://github.com/intuit/karate/issues/444#issuecomment-416246283
so I have wired the UI to the new model objects, I think it is working - but the old off-by-one errors may have been re-introduced. if you get a chance - do take a look

@ptrthomas will take a look

@ptrthomas #444 is shaping up pretty good, I didn't find any major issues in UI.  I have one small PR (applied on top of latest cukexit branch in my fork), please review https://github.com/intuit/karate/pull/515 at your convenience.

@vmchukky this helps - thanks !


Does this package support lumen 5.4

I am going to make api first project. can i use it in lumen?

it does not support


Receiving error: ./frogbot: No such file or directory

Hi Team,
I am trying to automate frogbot scan on my organization using azure pipeline when a PR is raised.
inputs:
script: |
getFrogbotScriptPath=$(if [ -z "$JF_RELEASES_REPO" ]; then echo "https://releases.jfrog.io"; else echo "${JF_URL}/artifactory/${JF_RELEASES_REPO}"; fi)
curl -fLg "$getFrogbotScriptPath/artifactory/frogbot/v2/[RELEASE]/getFrogbot.sh" | sh
./frogbot cfpr
From the above script from frogbot setup (https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot/setup-frogbot/setup-frogbot-using-azure-pipelines), my org was blocking to download getFrogbot.sh, so we have downloaded this file manually and kept it in project folder same root location where frogbot.yml is present and changed the above script to just like below:
    inputs:
      script: ./frogbot spr

Now when we run the pipeline, we are getting ./frogbot: No such file or directory
Not sure what is causing the issue. Can someone please help resolve this.

Hello @vbaranwal24, thank you for using Frogbot!
If I understand correctly, it seems that your organization is blocking the download of getFrogbot.sh from https://releases.jfrog.io/. As a workaround, you manually downloaded the script into ./frogbot and attempted to execute it manually. Please let me know if I misunderstood.
Regarding your solution, it's important to note that Frogbot is not intended to be used in the manner you described. Here are some suggestions that may help address your issue:
Confirm the flow you were trying to run. You mentioned wanting to perform a scan upon PR, but provided the script for Scan-repository. Please ensure that you have configured the pipeline for the scan-pr flow, as the CI files may differ from each other.
Note that the correct directory for Frogbot configuration files is "./.frogbot" (with the dot), not "./frogbot". Additionally, this directory is meant to hold only the 'frogbot-config.yml' file, and the flow automatically searches for this file in the target branch. The workaround you attempted may not work as intended.
Keep in mind that Frogbot always searches for configuration files in the target branch, which is typically the base branch you defined. Unmerged changes to configuration files, including additions to CI files or frogbot-config.yml, will not be applied until merged.
You can use a dedicated environment variable, JF_RELEASES_REPO, for cases where you cannot download from https://releases.jfrog.io/. Detailed information about this environment variable can be found in our documentation: JF_RELEASES_REPO Documentation
If none of the above suggestions help resolve the issue or if you have any further questions, please don't hesitate to contact us again.

Hello @vbaranwal24
Did my suggestion helped fixing your issue? Can I close this ticket?

Sure. Close it.
From: Eran Turgeman @.>
Date: Thursday, May 30, 2024 at 6:16 PM
To: jfrog/frogbot @.>
Cc: Vishal Baranwal @.>, Mention @.>
Subject: Re: [jfrog/frogbot] Receiving error: ./frogbot: No such file or directory (Issue #688)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Hello @vbaranwal24https://github.com/vbaranwal24
Did my suggestion helped fixing your issue? Can I close this ticket?
—
Reply to this email directly, view it on GitHubhttps://github.com/jfrog/frogbot/issues/688#issuecomment-2139480108, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFZODGS5OXZZIXMNECKD24TZE4NRVAVCNFSM6AAAAABGUCASYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZZGQ4DAMJQHA.
You are receiving this because you were mentioned.Message ID: @.***>


lib/setup_multibox.sh:313 Quorum-genesis: command not found

Hi
I am having this error on a fresh installed ubuntu OS, whenever I run the setup.sh.
Do I missed any pre-requisive library like ethereum or quorum to be installed prior quorum-maker?
Thank you

Closing as no longer relevant in the current release V2.0


Facing issues while using different dataset

I am trying to convert some standard datasets to robag file and use them. But the ROS topics my bag files are far less and different than the ROS topics in the data given in repository. How to make this work?

Changing the topic name and the frame is easy, just give it in you launch file e.g:
  <node name="urban_road_filt" pkg="urban_road_filter" type="lidar_road" output="screen">
      <param name="topic_name" value="/left_os1/os1_cloud_node/points"/>
      <param name="fixed_frame" value="left_os1/os1_lidar"/>
  </node>

If you are struggling with basic ROS concepts i suggest to have a look at the tutorials: http://wiki.ros.org/ROS/Tutorials
I will close the issue now, if you still have problems with this issue, feel free to reopen it.


Crash when setting new command

It crashes when setting a new command: https://gfycat.com/EachUncomfortableCuttlefish
is this a bug or I am doing something wrong?
EDIT: when settings everything, not just commands. Maybe I need a clean install?
Any way to export/backup already existing sensors?

Nah this should not be happening at all. Thank you for reporting, I'll have a look tonight.

Seeing same

It crashes when setting a new command: https://gfycat.com/EachUncomfortableCuttlefish
is this a bug or I am doing something wrong?
EDIT: when settings everything, not just commands. Maybe I need a clean install?
Any way to export/backup already existing sensors?

Seeing the same here. rolling back to .34 and it works again.

I'm pretty sure this is related to #49.  So this will most likely be fixed in the next release.

This should be fixed after updating. Could you please confirm when you have the time?

I confirm it is not crashing anymore, but also not saving the command? 🤔
https://gfycat.com/annualdishonestbarasingha

It seems like the old version of the background service is still running. You can kill it using task manager or simply restart your computer.

Ok it is working perfectly now, thanks a lot 👍


Usage of wasmparser::Validator for function bodies

Hi!
While implementing a tool based on wasmparser I found that there is a lack of information about validating function bodies. In particular, for any other resource but FunctionBody there exists an entry in WasmModuleResources, which kind of provides us a way to random-access WASM data (I know that wasmparser is not about random-access).
However, when validating a function Validator returns ValidPayload::Func, but doesn't give any information on if the returned structs are related to each other or not (for example, FuncValidator::finish specifies, that a function must be called for it to be validated correctly, but what is a "call"? Reading FunctionBodys BinaryReader up to the very end?)
Is there any guidance on how to use a Validator correctly (at least on function bodies)?

Within ValidPayload::Func you'll find a FuncValidator as well as a FunctionBody. You can use FunctionBody::get_operators_reader to read the operators of the function (and other readers there to read the locals). This operator and local information is passed to FuncValidator via methods like FuncValidator::op. You can also wholesale validate the entire body with FuncValidator::validate
Does that answer your question? Or is there something that could use improvement?

Within ValidPayload::Func you'll find a FuncValidator as well as a FunctionBody. You can use FunctionBody::get_operators_reader to read the operators of the function (and other readers there to read the locals). This operator and local information is passed to FuncValidator via methods like FuncValidator::op. You can also wholesale validate the entire body with FuncValidator::validate
Does that answer your question? Or is there something that could use improvement?

My bad, I missed the meaning of If this function is not called in https://docs.rs/wasmparser/0.80.1/wasmparser/struct.FuncValidator.html#method.finish and interpreted as If the function being validated is not called. Sorry for bothering.


Android: Task :rn-alioss:verifyReleaseResources FAILED

When building android release with ./gradlew assembleRelease for React Native 0.70.1/rn-alioss 0.25/gradle on MacOS Monetary/gradle 7.5.1, the build failed with the following error:
> Task :app:compressReleaseAssets
Execution optimizations have been disabled for task ':app:compressReleaseAssets' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/Users/macair/Documents/code/js/xyz_app6/android/app/build/intermediates/assets/release/mergeReleaseAssets'. Reason: Task ':app:compressReleaseAssets' uses this output of task ':app:copyReleaseBundledJs' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.5.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.

> Task :rn-alioss:verifyReleaseResources FAILED
<============-> 96% EXECUTING [5m 35s]
> IDLE
> :react-native-reanimated:downloadBoost > boost_1_76_0.tar.gz > 57.44 MB/124.2
> IDLE
> IDLE
> IDLE
> IDLE
> IDLE
> IDLE

And more:
> Task :rn-alioss:verifyReleaseResources FAILED
w: Detected multiple Kotlin daemon sessions at build/kotlin/sessions

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':rn-alioss:verifyReleaseResources'.
> A failure occurred while executing com.android.build.gradle.tasks.VerifyLibraryResourcesTask$Action
   > Android resource linking failed
     ERROR:/Users/macair/Documents/code/js/xyz_app6/node_modules/rn-alioss/android/build/intermediates/merged_res/release/values/values.xml:2723: AAPT: error: resource android:attr/lStar not found.

npx react-native run-android runs successfully. Here is the output of npx react-native info:
System:
    OS: macOS 12.5
    CPU: (8) arm64 Apple M1
    Memory: 64.39 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.7.0 - /opt/homebrew/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.15.0 - /opt/homebrew/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
    Android SDK:
      API Levels: 29, 30, 31, 32, 33
      Build Tools: 30.0.2, 30.0.3, 31.0.0, 33.0.0
      System Images: android-33 | Google APIs ARM 64 v8a
      Android NDK: Not Found
  IDEs:
    Android Studio: 2021.2 AI-212.5712.43.2112.8609683
    Xcode: 14.0/14A309 - /usr/bin/xcodebuild
  Languages:
    Java: 18.0.2 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.1.0 => 18.1.0
    react-native: 0.70.1 => 0.70.1
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

After deleting all under ./gradle and node-modules, and ./gradlew clean, yarn install again. But the error remains the same.
Build on React Native 0.68.2 was successful.

in build.gradle for rn-alioss, add the following at the end solved my problem:
configurations.all {
    resolutionStrategy {
        force 'androidx.core:core:1.6.0'
        force 'androidx.core:core-ktx:1.6.0'
    }
}

在 rn-alioss 的 build.gradle 中，在最后添加以下内容解决了我的问题：
configurations.all {
    resolutionStrategy {
        force 'androidx.core:core:1.6.0'
        force 'androidx.core:core-ktx:1.6.0'
    }
}

@emclab Thanks for your resolve if you can pls give me pr

I found this fork can work.


Feat: Converting Blog's Page to TailwindCSS According as Per New Theme

Describe the feature
As our website has been upgraded to Tailwind CSS, I want to convert the blogs page to use Tailwind CSS as well. This conversion will include updating the layout, typography, and component styles to align with the Tailwind design system.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I'm a VSoC'24 contributor
[X] I want to work on this issue

@shreyash3087 you are assigned


Cucumber if: Contradictory EqualTo and greaterThan constraints as part of an "allOf" "if" statement does not fail as expected

Bug Report
An "if" request is made will an "allOf" statement that contains contradictory "greaterThan" and "equalTo" statements should fail. This request did not fail as expected.

Scenario: Running an 'if' request that contains a contradictory allOf statement should fail with an error message
Given the following fields exist:
| foo |
| bar |
And foo is in set:
| 1 |
| 2 |
| 3 |
| 4 |
And bar is in set:
| "a" |
| "b" |
And there is a constraint:
"""
{
"if": { "allOf": [
{ "field": "foo", "is": "greaterThan", "value": 1 },
{ "field": "foo", "is": "equalTo", "value": 1 }
]},
"then": { "field": "bar", "is": "equalTo", "value": "a" },
"else": { "field": "bar", "is": "equalTo", "value": "b" }
}
"""
Then I am presented with an error message
And no data is created

Steps to Reproduce:

Run if.feature file from cucumber tests
See **Scenario: Running an 'if' request that contains a contradictory allOf statement should fail with an error message ** fails
Look at error message generated for the failure

Expected Result:
Where data cannot be created in an if statement due to contradictory statements then this should fast fail with a message to the user.
Actual Result:
No error message was created and the test fails with the following error:

1 Scenarios (1 failed)
7 Steps (1 failed, 1 skipped, 5 passed)
0m0.936s
java.lang.AssertionError:
Expected: is
but: was
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:956)
at org.junit.Assert.assertThat(Assert.java:923)
at  com.scottlogic.deg.generator.cucumber.steps.GeneralTestStep.dataGeneratorShouldError(GeneralTestStep.java:88)
at ✽.I am presented with an error message(C:/data-engineering-generator/generator/src/test/java/com/scottlogic/deg/generator/cucumber/If.feature:51)

Environment:
ifTestsUpdated branch running in full generation strategy on IntelliJ.

If the statements in the if are contradictory normal behaviour would just be that it always evaluates as false and so uses the 'else' branch. Has this been discussed elsewhere?

Closing as a non-issue, all data should be generated as the condition to the if produces an empty condition.
Test has been updated to reflect the current behaviour.


Suggestion: Automatable Ore detection

I want to suggest to add a piston movable block that outputs a redstone signal when a ore vein is nearby.
Running around with the stick works, but it is quite tedious for larger areas in my opinion.
Maybe it could output the type of vein with a comparator too.

I don't know if a comparator is a good idea, since there might be more than 15 ore veins. Given that this is still a Create addon, i'd put that kind of output in the goggles interface.

You could also create a new block, such as a sonar, that uses rotational force and some other element to locate the veins in the specific chunks, for it to work you would have to introduce books so that when you find one that writes the location on it and what is.
Another method could be a kind of hammer that hits the ground (that's why it needs rotational force) and that, depending on how it detects the waves, vibrations, etc. Know where there is a vein and what mineral it is


InfoMetricFamily’s add_metric() parameters are strangely named and should provide default values

Hey.
I was looking into InfoMetricFamily’s add_metric() and I either I just don't get it or the API is a bit strange.
With an Info object I'd have done something like this:
m = prometheus_client.Info("logical_drive", "foobar", ("controller_name",
                                                       "array_name",
                                                       "logical_drive_name",
                                                       "caching",
                                                       "device",
                                                       "raid_level",
                                                       "logical_drive_label",
                                                       "multidomain_status",
                                                       "parity_initialization_status",
                                                       "status"
                                                      )
                      )

and then set it like:
m.labels(controller_name=controller_name, array_name=array_name, logical_drive_name=logical_drive_name,
         **{n: logical_drive_properties.get(n, "")  for n in (
                                                              "device",
                                                              "raid_level",
                                                              "logical_drive_label",
                                                              "multidomain_status",
                                                              "parity_initialization_status",
                                                              "status"
                                                             )
           },
         caching=bool_or_none_to_label_value( logical_drive_properties.get("caching") )
        )

(here an example where I set some of the properties directly, and some via dict unpacking)

It would fail if I forgot a label.
I could use label names as attribute names, like controller_name= rather than "controller_name"=... which is however not super important

With InfoMetricFamily seem quite a bit different:

add_metric() now has the parameters labels and value.
As far as I understand the code, labels are actually not labels, but values for these, namely the ones set with labels in the constructor of InfoMetricFamily.
It's no longer possible to give labels as dict, one really needs to give them in the right order as sequence. Why does Info allow that but not this?
AFAICS, there is no check if exactly those labels are set, that were given in the constructor. Why over at Info but not here? What sense does it then even make to set the labels in the constructor?
value is misleading in so many ways. It's not the value of the metric (that is 1) and even if it relates to the labels being the “value”, then it should be values.
It might have perhaps even been better to swap the two names... or rater use some completely different names.

Anyway... guess this can't be changed now without breaking the ABI.
However, as far as I understand the code:
https://github.com/prometheus/client_python/blob/09a5ae30602a7a81f6174dae4ba08b93ee7feed2/prometheus_client/metrics_core.py#L372
the idea is one can give labels and/or value and both are merged in a final dict of label/value pairs.... but then it would be nice if labels and value were not required.
Why not simply give them default values () respectively {}?
I could provide a patch if nothing speaks against that particular change. But the above points are IMO still problematic. Especially also that the behaviour is considerable different from Info, which is not really obvious.
Cheers,
Chris.

It seems even worse... the other objects like GaugeMetricFamily do not allow to set their labels as dict... so one always must present them in the right order, which is error prone.
Why don't they just offer the same means as Gauge.labels() :-(


Update plugin docs

There was a few lines already but I just filled the section out a bit and added a title. I think updating plugin documentation directly will help make this process more understandable.
But if there's any thoughts I'm happy to include them/discuss

What's written is good, but that page isn't very easy to find unless you know to look for custom plugins. Could a version of that writeup be included in the Application Module docs? Or have it linked to clearly from there?

Not really related to these changes, but should there even be mentions of SpringRoll v1 in the docs now? It's been a really long time since v2 came out, and I doubt anyone needs to transition over anymore.

Definitely a good question. Something worth discussing.


Suggestion: Use HTML5 localStorage to save default settings

It would be helpful to load default settings when navigating to the main page (with no hash).
You could easily use HTML5 localStorage for this (with JSON.stringify and JSON.parse).

I think there are three parts to this:

Add a button to the settings tab which will save the current settings to local storage.
Add a button to the settings tab which will load the saved settings.
Load those settings if the URL fragment is empty.

I've forked your code and made it work on a locally hosted site - the only annoying thing is GitHub thinks I've changed everything because of the way Atom Beautifier works. Do you have a code formatter that you use (that I can use to compare changes in my code)?

I do not use a code formatter. I do it all by hand, for better or worse.


ValueError: could not convert string to float:

I'm getting the following error.
Anyone else?
Traceback (most recent call last):
  File "./dl.py", line 25, in <module>
    ptime = datetime.utcfromtimestamp(float(content))
ValueError: could not convert string to float:

Looks like yout last.txt file got corrupted. Deleting it would fix the problem.


TypeError: this.data[startingIndex] is undefined

I'm getting the error below in the browser on a route with a single mutation and subscription. I'm not sure yet what could be causing it.
Any suggestions for how to debug or resolve this?
Thanks for any help
Console Error
Uncaught (in promise) TypeError: this.data[startingIndex] is undefined
    resolveLayer storage.js:152
    mutation mutation.js:80
    instance callback.svelte:52
    run index.mjs:18
    mount_component index.mjs:1803
    flush index.mjs:1067
    init index.mjs:1895
    Root root.svelte:920
    createProxiedComponent svelte-hooks.js:341
    ProxyComponent proxy.js:242
    Proxy<Root> proxy.js:349
    initialize start.js:706
    _hydrate start.js:1606
    start start.js:1643
    <anonymous> callback:629
storage.js:152:13

Route Code
<script lang="ts">
	import { onMount } from 'svelte';
	import { browser } from '$app/env';
	import { goto } from '$app/navigation';
	import { query, mutation, subscription, graphql } from '$houdini';
	import * as config from '$lib/config-public';

	export let installCode: string;

	const sendExchangeRequest = mutation(graphql`
		mutation SendExchangeRequest($installCode: String!) {
			ExchangeInstallCode(input: { installCode: $installCode })
		}
	`);
	onMount(() => {
		try {
			sendExchangeRequest({ installCode });
		} catch (error) {
			goto('/oauth/error?type=codeError');
		}
	});

	let { data: matchingExchangedCodes } = subscription(
		graphql`
			subscription MatchingExchangedCodes($installCode: String!) {
				AccountReadModels(filter: { lastRequestCode: { eq: $installCode } }) {
					id
					authExpiresAt
					lastRequestCode
				}
			}
		`,
		{ installCode }
	);
</script>

<template lang="pug">

  +if('!!$matchingExchangedCodes?.AccountReadModels')
    p Connected!
    +else()
      p Connecting...

</template>

Hey @ClaytonFarr - looks like you're running into an issue caused by the recent optimistic response patch. Let me see if I can figure out what could be happening on one of my apps. Is your project public or could you put together a small reproduction so I can make sure to fix the issue?

Oh, interesting. So I think the issue is the mutation inside of onMount. could you try putting that on a button or something so we can verify?

I'm pretty sure #259 will fix this. Even if it doesn't, it's a situation I didn't think about and needed to cover so thanks for bringing this up. Going to deploy this now so you can tell me if we need to reopen it

Wow @AlecAivazis , quick hands 🙌
It looks like the error still shows up when you move the mutation outside of onMount and call it explictly as well

Thanks Alec, when that's ready I'll test it again and get you a sample repo if it has issues. Really appreciate the help

My guess is that this is caused when a mutation resolves before a query is fired - does that sound like what's happening for you?

Perhaps. In this case the mutation is firing before the subscription is created and called - at least when the mutation is in onMount.
When the mutation was called via a button it would have been after the subscription creation (and still crated console error)

I tried updating to the new package (0.13.8) but it didn't come down. I'm guessing these take a while to publish to npm?
I'll try this again a bit later and circle back. Thanks Alec

I'm running into a problem with the changesets action. If you want to test the changes locally, you can edit the $houdini/runtime/cache/storage.js and add the following block on line 234 (after the check for startingIndex === null):
// if we are resolving the base layer make sure we start at zero
if (startingIndex === -1) {
    startingIndex = 0
}

Okay, looks like 0.13.8 has been deployed now. thanks for being patient

@AlecAivazis, that fix removed the error on my end too 💯 Thanks!

Great to hear!


Shadowcorns: Throwing Shade - Social data Queries

Create queries for Garden of Forking Paths social data:

[ ] Which tokens chose which paths at each stage in each session?
[ ] How many tokens chose each path at each stage in each session?
[ ] Which tokens made it to the end of the session?

Create a crawler which will make this information public (on S3 bucket) for Shadowcorns: Throwing Shade.

According to Crypto Unicorns team, this is a low priority.

No need for this anymore - they decided to cancel Throwing Shade.


[release-4.14] USHIFT-2159: Upgrade osbuild copr package versions after copr cleanup

Manual cherry-pick of #2851

/label backport-risk-assessed
/label jira/valid-bug
/label cherry-pick-approved

/lgtm


Fixing issue #3510

This PR will fix the issue mentioned in #3510.

A new inspection was created.

The inspection completed: No new issues

Hello again @dejury
Thanks for spotting one more. I'v just been testing this out and it completely solves our problem.
I just have one comment though. I think we can avoid introducing another class here by using:
$(this).next("input[type=hidden]:not([name='clear_"+fieldName+"[]'])").remove();

If you agree with me, would you mind doing that change so I can mark the PR as ready for merge ? If not let me know why, maybe I am missing something here.
Thanks again @dejury , wish you the best man! 👍

A new inspection was created.

@pxpm Here you go, good addition to the initial change!

The inspection completed: No new issues

@dejury once again, but don't gets old, thank you so much :)
I will be moving this to ready to merge, it should be merged and tagged by next Monday.
Wish you the best,
Pedro


[10.x] Move resolveStubPath to GeneratorCommand to avoid duplications

The resolveStubPath method was moved to the parent GeneratorCommand class in order to prevent duplication.

Thank you for your PR but I'm going to close this one for the reasons detailed by @crynobone.


Automatic window size determine for gap-filling

To fill in gaps in the time series, an important hyperparameter is the size of the moving window.  To fill in the gaps, use time series forecasting models that need to specify this parameter.
The problem is as follows

In some cases, the window size will not allow us to train the model to fill in the gap, in others, the selected window size will reduce the learning ability of the model. So, there is a need to implement an efficient algorithm for determining the optimal window size and embedded it in a single mechanism for effectively gap-filling.

Since the lagged transformation operations can now be used in separate nodes and window size in it adjusted to the size of the time series (they can not exceed it), the problem is solved.


want to remove namspaces

https://laracasts.com/discuss/channels/tips/repoist-laravel-5-repository-generator?page=1
following this one.
Repositories Without Schema
php artisan make:repository Task
Will output:
app/Repositories/Task/TaskRepository.php
app/Repositories/Task/EloquentTaskRepository.php
I want this same as it is above.
but when i run php artisan make:repository Task
it creates two folders.
app/Contracts/Task/TaskRepository.php (contract)
app/Repositories/Eloquent/EloquentTaskRepository.php
i want to to get rid of this.
please help

What exactly do you want to remove?


Update api

Current coverage is 44.14% (diff: 100%)

Merging #196 into master will increase coverage by 0.06%

@@             master       #196   diff @@
==========================================
  Files            11         11
  Lines          8917       8917
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           3930       3936     +6
- Misses         3938       3939     +1
+ Partials       1049       1042     -7

Powered by Codecov. Last update 663c52d...31819ff


property named "next" causes parse errors

There is a parse error when using a property called next on an object. I just ran this on a roku, and it works.

Another in the family of #164 and #182, in which some keywords aren't reserved words and can be used for other purposes.  next likely needs to be lexed as an Identifier with text next, and anything that'd normally use next as a keyword has to look for an identifier instead.


Added basic webserver for status

I have parameterized the script I mentioned in #87 , pulling the path variables from config file to establish paths. This uses os.statvfs which will not work on WIndows. I believe this is the only limitation.
I also added Disk Info about the ARMPATH as well as RAWPATH as you can see in my screenshots below.
Please try this out, put this python file in your ARM directory and use as follows.
I am expecting some folks to test before adding this in. Right now the script must be run manually, which is good for this testing phase I think.
Very basic web access to log and queue monitor for ARM (Automatic Ripping Machine) https://github.com/ahnooie/automatic-ripping-machine

Usage::
    Place script in /opt/arm directory
    sudo ./logserve.py [<port>]

View the empty.log in reverse order::
    http://localhost:[port]

View the Info page
    http://localhost:[port]/info/

Screenshot of empty.log in browser: (must manually reload)

Screenshot of Info page in browser: (refreshes every 60 seconds)

Here are some updated screenshots since I updated the script to do some sorting and made the Log load much different/faster.

This is failing for me:
sudo ./logserve.py 8000
File "./logserve.py", line 33
def getsize(path)
^
SyntaxError: invalid syntax
I've tried hardcoding the paths to see if that helped, and it didn't :)
Any ideas?

Thanks Frank,
Yes, complete syntax boo-boo.
I forgot the : at the end of def getsize(path)
I have just changed and committed that.

This was manually pulled into v2 so I'm going to close it.


rdpq_rect: implement rdpq_texture_rectangle_flip

Still missing a doc comment.

@9nova I'm a bit more dubious on this as this primitive is a bit complex to use. I'd rather rdpq manage to lower this barrier if possible.
What about adding a rdpq_rectangle_rotated instead, with a 4-way rotation argument, and let it expand to the right primitive, adjusting the arguments accordingly? I think this would make things easier on the user.

The map editor I used handles that at build time and just spits out a set of flags (flip dsdx, flip dtdy, swap dy/dx). So my game actually needs the low-level call: https://github.com/N64brew-Game-Jam-2023/alien-sun/blob/main/src/render.c#L470-L473
I agree though that there should be a higher level way to access it if someone is not using this kind of build step, so I'll try to add it to the PR


WIP [ART-7190] Switch to openshift-eng/art-tools

Switch to openshift-eng/art-tools. Ref ART-7190
Gen-assembly test run.
Prepare-release test run

Do not merge before @ashwindasr runs the code to sync doozer and elliott to art-tools

Can you include a test job?

Can you include a test job?

Apologies, have added now

/retitle [ART-7190 Switch to openshift-eng/art-tools

/assign @ashwindasr

/retitle [ART-7190] Switch to openshift-eng/art-tools

/unhold /wip

/wip

Closing in favor of https://github.com/openshift-eng/aos-cd-jobs/pull/3881


verilator: 4.210 -> 4.218

Motivation for this change
Version bump
Things done
Change to fetch source from github as the source for newer versions are not published at the same location anymore.  Also add configure/build/install-phases as verilator uses autoconf (autoreconfHook is not supported by verilator).

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@SuperSandro2000 the package does not build with this change https://github.com/NixOS/nixpkgs/pull/157122/commits/71cbfd1a727fc77d6665ab8c753ec0b510308b6e

@SuperSandro2000 the package does not build with this change 71cbfd1

I need some more details than that to help you.

@SuperSandro2000 the package does not build with this change 71cbfd1

I need some more details than that to help you.

Looked into this in more detail. autoconf is not run automatically, so I have changed the code to run autoconf as a preConfigurePhase. Otherwise the correct configure and make calls happens automatically as you said and the package builds 👍🏻


Added option to force the language

It would be convenient to be able to force the language instead of having it established by the transcriber, as it sometimes makes mistakes.
I have seen that whisper uses the --language option for this very purpose, through the DecodeOptions you already use in the model.transcribe().
So I just added the option and setting of the args ["language"] variable for valid values.
Note that when checking conditions, the "model" comes last, so that it overrides the "language" option itself.

works thx for nice commit <3


make get methods return Option instead of Result

From the ergonomics perspective, it's better if get methods return Option instead of Result.
The previous change also makes it possible to remove all of the TrieError variants except FixedSizeKeyLengthExceeded needed for the fallible conversions.
Convert two occurrences of TrieError::Other() into a proper TrieError::VersionIsOld variant.

For the future, we should probably take care of the conversion methods from strings and slices for fixed size keys, and make them consistently return Result<..., TrieError::FixedSizeKeyLengthExceeded> instead of (debug) asserts.

Thanks @gsserge for this! Do you think it is ok if we can remove the dependency on result in the snapshot? There are some functions (like iter, range, etc) which don't need a result now that there is no dependency on closed

I have this PR where I found some other places I had unnecessarily used Result. I'd appreciate your review! The PR is pointing to this branch


Support emmet syntax and complete tags without opening <

Closes #20
This also includes support for Emmet syntax:
https://github.com/liveview-native/liveview-native-vscode/assets/13581484/8ef732ea-d858-4a1c-81ec-c28131a7d669

Detection of self-closing tags was added to this PR:
https://github.com/liveview-native/liveview-native-vscode/assets/13581484/4f11b7f0-ed42-4752-83af-316693029023


#119 TsLogged.java:38-42: This class not implemented yet

task #119
implemented TsLogged
created TsLogedTest
created stub for BkLogged

Thanks for the pull request, let me find a reviewer..

@pinaf it's yours,please review

@dmzaytsev 5 comments above.

@pinaf I did push new commit, but it doesn't appear here.
here I see two commits in the PR #122, but here I see only one commit

@pinaf I'll contact with Github support

@pinaf response from support

Sorry for the trouble. We deployed a change that seems to have created some PR buginess.
We're working on a fix, and I'll let you know when we have an update.

@pinaf  Github resolved the issue
the PR updated

@dmzaytsev looks good! thanks!

@rultor merge

@rultor merge

@pinaf Thanks for your request. @yegor256 Please confirm this.

@dmzaytsev Takes interface was removed from the project (in #133), together with this puzzle. you can just close this pull request and the original ticket will be closed automatically (and paid)

@yegor256 if this puzzle will be closed, how should be implemented BkLogged, FtLogged, PsLogged ?

@dmzaytsev good question. We'll have to create tickets for them, separately, not through puzzles

@elenavolokhova review this ticket please, for compliance with our quality rules

@pinaf

davvd commented 6 days ago
Thanks for the pull request, let me find a reviewer..

According to our quality rules:

Messages in a ticket always start with a name of a user they are addressed to.

As far as you are the performer of this ticket you are responsible for its quality. Please make sure that everyone follows this rule in your tickets in the future.
Please confirm that everything is clear and you have no questions regarding this approach.

@yegor256 this was closed 5 days ago

@pinaf same here, waiting for QA confirmation here, see http://www.teamed.io/qa.html

@elenavolokhova I confirm

@pinaf Thank you!

@davvd Ticket passed QA review. Quality is acceptable.

@davvd Ticket passed QA review. Quality is acceptable.

@elenavolokhova thanks, got it. everybody, please try to make it good next time

@pinaf I added 10 mins to @elenavolokhova (for QA review) in transaction 55485753. Much obliged! I have added 20 mins to your account in payment "AP-2ES826934D191343A", 49 hours and 12 mins spent. extra minutes for review comments (c=5). +20 added to your rating, current score is: +7004


Payment processing failed System.NullReferenceException

Testing geth faced with such an error
[2018-10-26 16:06:11.7300] [E] [PayoutManager] [gol1] Payment processing failed System.NullReferenceException: Object reference not set to an instance of an object.
   at Miningcore.Blockchain.Ethereum.EthereumPayoutHandler.ClassifyBlocksAsync(Block[] blocks) in /home/user/NEW/miningcore/src/Miningcore/Blockchain/Ethereum/EthereumPayoutHandler.cs:line 152
   at Miningcore.Payments.PayoutManager.UpdatePoolBalancesAsync(PoolConfig pool, IPayoutHandler handler, IPayoutScheme scheme) in /home/user/NEW/miningcore/src/Miningcore/Payments/PayoutManager.cs:line 136
   at Miningcore.Payments.PayoutManager.ProcessPoolsAsync() in /home/user/NEW/miningcore/src/Miningcore/Payments/PayoutManager.cs:line 98    at Miningcore.Blockchain.Ethereum.EthereumPayoutHandler.ClassifyBlocksAsync(Block[] blocks) in /home/user/NEW/miningcore/src/Miningcore/Blockchain/Ethereum/EthereumPayoutHandler.cs:line 152
   at Miningcore.Payments.PayoutManager.UpdatePoolBalancesAsync(PoolConfig pool, IPayoutHandler handler, IPayoutScheme scheme) in /home/user/NEW/miningcore/src/Miningcore/Payments/PayoutManager.cs:line 136
   at Miningcore.Payments.PayoutManager.ProcessPoolsAsync() in /home/user/NEW/miningcore/src/Miningcore/Payments/PayoutManager.cs:line 98

./geth --datadir /home/user/db -rpc --ws --wsorigins="*"
"EnableDaemonWebsocketStreaming": true,
"daemons": [
	{
		"host": "<IP_ADDRESS>",
		"port": 2009,
		"portWs": 2018

	}
],
"paymentProcessing": {
	"enabled": true,
	"minimumPayment": 0.01,
	"payoutScheme": "PPLNS",
	"payoutSchemeConfig": {
		"factor": 0.1
	},
	"coinbasePassword": "pass",
	"keepUncles": false,
	"keepTransactionFees": false
}

there is also a problem with payments
System.Exception: Unable to unlock coinbase account for sending transaction
different coins of different reward per block would be good if the reward per block was exhibited in coins.json

have you try to add --wsport in your geth? by default it listen on port 8546
https://github.com/ethereum/go-ethereum/wiki/Command-Line-Options

I use a coin to test Goldiam her default --wsport 2018

@Konstantin35 I need more info here. Any chance for you run this in the debugger?

How to make it better tell me

Umm, what?

What kind of information do you need to understand what's going on

Why did you close it?

Without the support of the geth isn't working for me

I made some changes and tested one coin everything works fine
https://github.com/Konstantin35/miningcore


How can I change the spectrogram renderer to multicanvas?

When the canvas width becomes a large size such as 70000 when using the spectrogram plugin, the canvas drawing fails.
I'm thinking about drawing with multicanvas to solve this,
How can I change the drawer to multicanvas?

I am also facing issue but at very low minPxPerSec . The waveform is getting removed when I am zooming in it. Please help.


Dead Link in the docs

The link "Linked Data" is now leading to a 404. You can see the previous contents on the Internet Archive here
The link is Located here

Thanks! Fixed it.


Issue : Stripe Payment gateway not working

Issue: Stripe Payment Gateway Not Working When Clicking on "Add Coins"
Description
We have encountered an issue with the Stripe payment gateway when users attempt to add coins to their account. Upon clicking the "Add Coins" button, the payment process does not complete successfully. This issue is preventing users from making purchases and adding coins to their accounts.
Steps to Reproduce

Log in to the application.
Navigate to the "Add Coins" section.
Click on the "Add Coins" button.
Follow the prompts to complete the payment process using Stripe.

Expected Result
The payment should be processed successfully, and the user's account should be credited with the purchased coins.
Actual Result
The payment process does not complete, and the user is unable to add coins to their account. No error message is displayed, and the transaction does not go through.
Additional Information

Browser: [e.g., Chrome, Firefox]
Version: [e.g., 1.0.0]
Operating System: [e.g., Windows 10, macOS]
Any relevant error logs or screenshots

Priority
High
Please investigate this issue and provide a fix as soon as possible. Thank you!

This issue had been resolved in the latest pull request #30


How to use source image with higher resolution.

Nice work!
I'd like to know is there any way I can use a source image with higher resolution?
I tried to use image with 1024*1024 size, but the prediction results were really wierd. Even after I changed the "frame_shape" in the config/vox_256.yaml， the result still failed.
Any solutions for this? Many thanks!

Hi, check #20


"application" key mapping stops working in updates after 0.90.70

Hi Developers, I have a mapping that maps the "application" key of a Windows keyboard (the key is usually to the left of the Right Control key) to the Left Command key on a Mac and it's been working well until version 0.90.70. All subsequent updates after this version simply render this mapping useless. I have to reinstall Karabiner Elements from the dmg file (Karabiner-Elements-0.90.70.dmg) to get the mapping back.
Anyway just so that you are aware of it. Great job on the app guys, keep it up!

This happened for me, too.

Same issue here.


gitlab: 17.3.6 -> 17.3.7

https://about.gitlab.com/releases/2024/11/13/patch-release-gitlab-17-5-2-released/
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Also tested manually on my instance.

Add a :+1: reaction to pull requests you find important.

@NixOS/gitlab


Added types to exports to support TypeScript with node12 module resolution

When using "moduleResolution": "node12" (currently requires nightly TS), if exports is specified, then TypeScript will ignore the top-level main, types, etc. Because of this, it cannot find the type definitions. Adding the types to exports fixes this.

@argon-dev Thank you for your contribution!


I'll need more context like the output of the splat operation or something, symlinks have worked since the beginning as they are critical for case-sensitive file systems, in particular windows.h is the most commonly incorrectly cased header in the history of mankind, so that one not working indicates that you've told xwin not to create symlinks, or something is wrong in the case-sensitivity detection. https://github.com/Jake-Shadle/xwin/blob/07cc74af2f67b51e7994560daec3095b38fc3e5a/src/ctx.rs#L220-L235

Error: no cab files were referenced by the MSI

This indicates you are not using the most recent version which fixes an issue where MS split up header files into more packages in the latest SDK.

I'd suggest nuking the cache directory entirely, I assume it's using a slightly outdated cached manifest that points to a broken SDK, removing the cache directory will download the latest manifest and all relevant files, which I just did to confirm that it works.
xwin [main] % fd driverspecs .xwin-cache/splat
.xwin-cache/splat/sdk/include/shared/DriverSpecs.h
.xwin-cache/splat/sdk/include/shared/driverspecs.h
.xwin-cache/splat/sdk/include/shared/sdv_driverspecs.h

Ok, well, it doesn't make sense to me why 10.0.26100 works perfectly fine for me, but at least you have a workaround.

Oh, guess not all cases are covered, GL was a special case I think, and I only care about Linux so rely on others to run into Mac issues.

Fixed in https://github.com/Jake-Shadle/xwin/releases/tag/0.6.4

Ok, actual fix in https://github.com/Jake-Shadle/xwin/releases/tag/0.6.5


Module not found: Can't resolve 'protobufjs/dist/minimal/protobuf.js'

Import trace for requested module:
./node_modules/.pnpm/@cesium+engine<EMAIL_ADDRESS><EMAIL_ADDRESS>./components/cesium/CesiumWrapper.js
./pages/index.js
Got this error While trying to run
pnpm run dev,
there might be a dependency conflict I am missing Can you help?

We actually don't use cesium anymore (it was for a homepage animation in the early days), weird that you get this error. I'll take a look

Researched this, seems like npm install<EMAIL_ADDRESS>should fix this error.

This error should no longer occur
https://github.com/codergautam/worldguessr/commit/6b22fba35907ece04a02a2b36975d50b78dfeca4


Add a git tag to a repository

Is there a way in huggingface_hub to add a git tag at a specific revision without cloning the repo locally ?
This would be useful to allow users to specify a git tag when they do push_to_hub for a model or dataset, so that they can reload it later at that resivion.

Hi @lhoestq, it is currently not possible to tag a commit in create_commit using the HF API (therefore not in push_to_hub either).
@Pierrci @SBrandeis is this something the commit endpoint can do on the Hub ?
(also, is this table supposed to be exhaustive ? do we have an internal endpoints table ?)

also, is this table supposed to be exhaustive ? do we have an internal endpoints table ?

I don't think it is - the internal endpoint table is https://github.com/huggingface/moon-landing/blob/main/server/server.ts 🙃

if we do this, API-design-wise i don't know whether it should be an extra param to create_commit, or a dedicated create_tag(commit="...") method

A tag endpoint has been added to the Hub (internal link) ! :tada:
So we can now implement it in huggingface_hub as well. Preferred solution is to have a separate method for this (e.g. create_tag(commit="...")).

Also helpful for cases like this: https://huggingface.slack.com/archives/C034A8MG0JK/p1663775251718419 :)


Error encountered running DeepSpeedExamples/HelloDeepSpeed/train_bert.py

Error encountered running DeepSpeedExamples/HelloDeepSpeed/train_bert.py
$ python train_bert.py --checkpoint_dir ./experiments
Traceback (most recent call last):
  File "train_bert.py", line 9, in <module>
    import datasets
ModuleNotFoundError: No module named 'datasets'

@jeyblu, is this still a problem? Thanks!

Yes it's still a problem. Thanks.

It looks like that datasets package is missing from your current environment, which is specified in this requirements.txt file.
Did you do pip install -r requirements.txt prior to running python train_bert.py --checkpoint_dir ./experiments?


Switch back to Vagrant's ansible_local provisioner when 1.8.2 is released

In #445 I switched Drupal VM back to using the JJG-Ansible-Windows provisioning shell script because so many users have been affected by https://github.com/mitchellh/vagrant/issues/6793.
I'd love to switch back to ansible_local, but I'm waiting on a Vagrant 1.8.2 release for that. It looks like it's being held up by a couple other bugs with the ansible_local provisioner.

It's time to switch back to ansible_local, methinks.

I'm curious as to when you're expecting this one to be complete?

Bumping this one back up to the fore—it looks like Vagrant 1.8.5 resolves the NFS issues that have been plaguing so many Mac OS X users, and that was the main thing I was waiting for some resolution on since 1.8.2, 1.8.3, and 1.8.4 all seemed to create as many little quirks as they resolved.
I think the time for this has come, especially since #814, an improvement I dearly want to make now, would require hacking my own upstream JJG-Ansible-Windows project, but if we use the ansible_local provisioner, no problem at all since we can just not specify the galaxy file :)
I'll also need to bump the version recommendation in the README when I re-do this.


defaultStrumXY for lua scripts

What feature do you want to get added on the base engine?
so something like
if direction <= 3 then
	yourMom = _G["defaultOpponentStrumXY"..direction]
end
if direction >= 4 then
	yourMom = _G["defaultPlayerStrumXY"..direction]
end

can be shortened into
yourMom = _G["defaultStrumXY"..direction]
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

Already exists in the wiki.

💀


VSCode is not recognizing some merge conflicts and just accepting incoming.

Update: I tested with Gitkraken and it has the same issue. So this may be a problem with git rather vscode

Does this issue occur when all extensions are disabled?: Yes/No
Yes

VS Code Version:
OS Version:
Version: 1.87.2 (user setup)
Commit: 863d2581ecda6849923a2118d93a088b0745d9d6
Datum: 2024-03-08T15:20:17.278Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
Betriebssystem: Windows_NT x64 10.0.22631

I have uploaded 2 examples. example 1 are two files from different branched that should be merged and example 2 is another example to show that it happens not just with those specific file contents. I have also added screenshots to show the issue. As you see, there are differences between the files that are not shown as conflicts. In example 1 the UseFormReturn type is not marked as conflict and the incoming is just accepted. Other merge conflicts are correctly marked as seen in the screenshot.
In Example 2 I am showing that it is not just an issue with types. The useForm hook is very different in between the two files, but the merge editor only recognizes some other conflicts and line removals. But for example not the removal of "name: ...." etc.
Steps to Reproduce:

Have one branch (master) with example1 attached file. And one branch hook-form with other example1 attached file.
try to merge master into the hook-form branch.
Observe that not all merge conflicts are displayed.
issue.zip

Please verify if this happens also with vanilla git, without VS Code.

Observe that not all merge conflicts are displayed.

If you don't even see conflict markers in the normal text editor (not the new 3 way merge editor), this is a git issue.

I don't see conflict markers in the normal editor and see the same issue in gitkraken. So it seems like the issue must be with git. I have opened a bug report with git and will close this ticket.


security: update yarn.lock for snyk fixes

https://snyk.io/vuln/SNYK-JS-JSYAML-173999
Resolves #issueNumber
Impact: minor
Type: chore

OK apollo-client v2.5 breaks out tests, so I pinned it to v2.4.12.


cannot reshape array of size 2940000 into shape (980,20,50,1)

Hi,
When I run model_cnn.py, the program stop with this error. Could you suggest me some solution?
Thank you
Traceback (most recent call last):
File "C:/Users/minhdl/PycharmProjects/stocks/model_cnn.py", line 103, in
main()
File "C:/Users/minhdl/PycharmProjects/stocks/model_cnn.py", line 99, in main
model_selection(clusters)
File "C:/Users/minhdl/PycharmProjects/stocks/model_cnn.py", line 89, in model_selection
X_train, y_train, X_valid, y_valid, X_test, y_test = get_Feature_Label(clusters=clusters)
File "C:/Users/minhdl/PycharmProjects/stocks/model_cnn.py", line 43, in get_Feature_Label
X = X.reshape(X.shape[0], 20, 50, 1).astype('float32')
ValueError: cannot reshape array of size 2940000 into shape (980,20,50,1)

Hi, @DangLienMinh , I changed the framework to a new version, it is much more powerful and easier to understand, you are welcome to take a look at it.


lalala blablabla

High-level description
What features does this change enable? What bugs does this change fix?
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS- Foo the Bar so it stops Bazzing.

Related tickets (optional)
Other tickets related to this change:

DCOS_OSS- Foo the Bar so it stops Bazzing.

Checklist for all PRs

[ ] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[ ] Read the DC/OS contributing guidelines
[ ] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot sync

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

@mesosphere-mergebot restart mergebot/test-imitation DCOS-56263

@mesosphere-mergebot restart mergebot/test-imitation DCOS-56263

@mesosphere-mergebot restart mergebot/test-imitation DCOS-56263

@mesosphere-mergebot restart mergebot/test-imitation DCOS-56263

@mesosphere-mergebot backport 1.10 1.11

@mesosphere-mergebot backport 1.12 1.13

@mesosphere-mergebot backport 1.13

@mesosphere-mergebot backport 1.12


Create birdsofpuertorico.com.md

I'm seeing 484.9 --> https://tools.pingdom.com/#5f54e240d0400000

I've updated it to reflect the current site weight.


[$500] Expensify comment to enter the details for the deleted expense request

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.36-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danieldoglas
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707168112041529
Action Performed:

smartscan invalid receipts and wait for to fail
Delete th requests

Expected Result:
No message saying that Receipt scanning failed. Enter the details manually.
Actual Result:
hey now had a comment from Expensify saying that Receipt scanning failed. Enter the details manually. . Because of those comments, the expense policy chat is now always showing as a GBR, when it shouldn't show anything since I can't act on it.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/203bc721-8ab8-4650-8b02-c7cc9f729e6c

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018bc064bf2f244ac3
Upwork Job ID:<PHONE_NUMBER>080993792
Last Price Increase: 2024-02-27

@abdulrahuman5196 thoughts on the proposal above?

Hi, Will review the proposal in my morning

Reviewing now

@CortneyOfstad Could you kindly confirm the expectation here?
Should we not show the failure message or not show the whole request itself? I am not sure what we should expect here.

@danieldoglas since you reported the issue, I would love your input here. I'm leaning towards not showing the whole request, but wondered if you had a preference. Thanks!

We should dismiss the GBR or RBR if we cancel the request. There's nothing else to do there, so it doesn't make sense to keep it alerting.

Sounds good @danieldoglas! Does that make sense for you @abdulrahuman5196?

Bump @abdulrahuman5196 ^^^

Bump @abdulrahuman5196 on the comment here  — thanks!

Hi, @CortneyOfstad  sorry for the delay. Will check on the review in my morning.

Reviewing now

This is the expected from @danieldoglas comment

We should dismiss the GBR or RBR if we cancel the request. There's nothing else to do there, so it doesn't make sense to keep it alerting.

@dukenv0307 proposal targets to delete the request in case of it only having expensify notifications. But the expectation here is to not show the green indicator alone. So the proposal is invalid at this point.
@danieldoglas Do correct me if misunderstood the proposal in any way.

No new proposals to review.

The problem with deleting everything is in case we have messages that are not related. Let's say for example that you add a comment in a money request, then delete the money request. The comment will still be there, and we need to show it as available.
What's happening here is that we're not removing the GBG or RBR if we delete the money request.

We already do the same (remove the request completely)

Those are different types of reportActions though - we can't delete those messages specifically because they're not currently considered system messages.

@danieldoglas Just checking to see if you had a follow-up to @dukenv0307's comment here?
I agree with @dukenv0307's line of thinking that if there is a comment, the request should remain (or at least a message indicating the request was deleted/removed), but interested to hear your thoughts! Thanks!

Ok, I agree with that as well. Thanks @dukenv0307

One edge I see here, currently as of this issue only expensify notification comment is Receipt scan failed notification. But what if in future we started having different kind of expensify notification itself and we don't want to delete the request even if it had those notification(for eg: like some bank related notification from coincerge, just think out load)
Is there a property to just say if the expensify notification comment is the Receipt scan failed one? and we can only delete the report if only had the specific expensify notification comments like receipt failed?
@dukenv0307

Ok, I agree with that as well. Thanks @dukenv0307

Hi @danieldoglas , Wanted to confirm again, since the last decision seems to have changed.
With the recent discussion we are fine with proceeding in the expectation mentioned by @dukenv0307 - https://github.com/Expensify/App/issues/35861#issuecomment-1928662194, that is to delete the request if we only have expensify notification messages.
I think the proposal is technically reasonable, so if we confirm on the above, I can go ahead with the next steps.

I agree with that, let's move forward

@abdulrahuman5196 to confirm, are we moving forward with @dukenv0307's proposal? Thanks!

@abdulrahuman5196 bump on the above and if so, we should have @dukenv0307 restate their proposal with any feedback implemented 👍

Hi, @CortneyOfstad Will check and update today

Thank you!

Hi @sonialiap! I am heading OoO and will be back March 11th, so reassigned to have someone keep this moving until I am back. At this stage, we're waiting for @abdulrahuman5196 to review the proposal of @dukenv0307 to see if it needs to be restated with the feedback provided. Thanks!

@dukenv0307 I was trying out the proposal here https://github.com/Expensify/App/issues/35861#issuecomment-1928662194
Just updating here https://github.com/Expensify/App/blob/d7f87c5663096798e5bb959a713aa209215d39a8/src/libs/actions/IOU.ts#L2579 doesn't actually delete the request.
And even after i tweaked the code and delete the request, the green indicator is not removed.

@dukenv0307 Bump on the above

@abdulrahuman5196 bumping Duke's question :)

@abdulrahuman5196 bumping!

Cortney, you're back today so I'm unassigning myself

Thanks @sonialiap!
@abdulrahuman5196 can you please provide an update by EOD on where we're at with this? Thanks!

Hi, I have to provide video on my claim that the proposal was not working. Will check on it in my morning

@dukenv0307 bump on the comment above ^^^ Can you follow up by EOD? Thanks!

Thanks @dukenv0307!

@abdulrahuman5196 any thoughts on the update here? Thanks!

Sure thing CortneyOfstad

It removes the green indicator for while, but it comes back. If you have any specific code I have to try out, do share the same with me.

@abdulrahuman5196 Here's the test branch. It works fine for me.

It removes the green indicator for while, but it comes back.

I was able to reproduce now this with a scan in a workspace, this is because we didn't make the change in back-end so it sends back Pusher data with hasOutstandingChildRequest: true. Once we made the adjustment in the back-end, the green dot will no longer show.

We might want to fix the back-end to follow the same logic too.

Got @dukenv0307 . I suspected backend since it came after a while.
What do you think @danieldoglas ?
I think we might also need backend changes. If possible can we confirm on backend changes.
Or we can proceed to make frontend changes and have a follow-up on backend changes?

What do you think @danieldoglas ?
I think we might also need backend changes. If possible can we confirm on backend changes.
Or we can proceed to make frontend changes and have a follow-up on backend changes?

@danieldoglas do you agree with this strictly being BE or do you think they can make the FE changes for now to keep this rolling? This issue is low-priority, but I am in the camp of keeping this moving wherever possible.
My only concern with doing the FE pieces now is the potential of creating more work on the BE side later. Do you see that happening, or is that not the case? Thanks!

@danieldoglas bump on the above ^^^ TIA!

Bump @danieldoglas ^^^ Thanks!

my bad, started a conversation here: https://expensify.slack.com/archives/C03TQ48KC/p1711377098976279

@danieldoglas any update? From what I could gather on the chat thread, it appears that we want to remove the violation as a message, but wanted to hear your thoughts on the best plan forward 👍

working on the PRs to work on this internally!

Sorry @dukenv0307 — there is a PR request (here) to remove the message 👍

@dukenv0307 - Since we now have violations, the comment for smartscan failed won't be added anymore. So if you delete the request, since it won't have any comments, this will work automatically.

Issue not reproducible during KI retests. (First week)

Great, closing this!


Explain what the region setting does

What

From a power user:
Explain what the region setting does.

What if the App/System language is different from that regions language?
The first product I wanted to edit had a name in a foreign language (neither System nor region language).
Should I delete it and replace it with the name in my language?
Must that correspond to the regions language/whats written on the product sold in that region?
How does all the language handling work at all?

Most of it will be answered by
[ ] #2514

Hello @teolemon where we have to explain these. Do we have to write separate section in the app?


Separation of Universum from RimNauts2. Update .NET from 4.7.2 to 4.8 in Universum.csproj

Initial commit populating Universum in separate repo from RimNauts2, effectively separating Universum into its own standalone mod. Please see RimNauts2 commit history previous to commit 83ff163 to view original Universum changes.

Missing defs, but I can add it in another pull request


Remove send trait from EthereumAccount

While implementing the zksync-rs crate into our software we are running into errors due to the Send trait.
It seems this was added as an unexpected side-effect of using async_trait
This PR Removes the trait since it looks like its not required.

Closing since this will not work: it forces the removal of Send from too many futures.


1.4.0a1

Fixes a few deployment issues

Codecov Report

Merging #153 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   89.93%   89.93%
=======================================
  Files          10       10
  Lines        2573     2573
  Branches      567      567
=======================================
  Hits         2314     2314
  Misses        167      167
  Partials       92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30cb635...aef73b0. Read the comment docs.


Update btp-cockpit-setup.md to fix broken link to Free trial account …

The link point to create a free tier account in BTP was broken. It should point to https://github.com/sap-tutorials/Tutorials/blob/master/tutorials/hcp-create-trial-account/hcp-create-trial-account.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Is it possible to just fetch the Atmosphere Data? (Pricing)

Hey,
is it possible to just fetch the Atmosphere Data and ignore the Contact Data, since therefore extra money has to be spend..

Hi there,
Greetings!
It seems the logic requires only a few things from whole detail api call.
You can change line no 25 in crawler.py to DETAIL_URL = BASE_URL + "details/json?placeid={}&fields=place_id,name,types,geometry,formatted_address&key={}" to get the bare minimum.


System Request: 13th Age/Toolkit13

I would appreciate if you could add support for the 13th Age system: https://gitlab.com/asacolips-projects/foundry-mods/archmage
Being able to see HP, Defenses, Recoveries, and Icon Relationships in particular would be useful.

Do characters have different icons among themselves or it's just a setting thing?

And how exactly should the info be displayed? Relationship + Bonus, or just one of them?

For context an Icon is a powerful NPC/faction that a character has a relationship with. These are tracked in a few different ways, they have a strength (either 1, 2, or 3) as well as a nature of the relationship (either positive, conflicted, or negative) and in each session, a player might have one or more "5" benefits, or "6" benefits that they/the GM can spend to influence the story, or no benefit at all. Different characters can have different and independent relationships with icons and they can have anywhere from 2-5 relationships total. It looks like this in the character sheet and I think this is a good way of handling it?

I just noticed in some of the other screenshots for this module that tabs are possible. So maybe the "General" tab could have HP, Recoveries (remaining and total, somewhat like 5E hit dice), AC, PD, and MD (3 defenses). An "Icons" tab could have the relationship stuff mentioned previously and a "Backgrounds" tab could show everyone's backgrounds (sort of a freeform skill system with numerical ratings, looks like this on the character sheet:

Hopefully that makes sense, I'm not sure exactly what information you need. Please let me know if I can provide any more assistance.

That's enough info. I needed to know if there could be 5+ icons per game, so the table would be better transposed.
Here's an example:

Backgrounds will look more standard, like this:
| Name |
|---|---|
| a | Shadow Port (+5), Magical Auras (+3)

I think that looks good except, for each Icon associated with a PC, it's important to know if they still have an icon benefit to spend. In the screenshot I posted, I have a "5" to spend with the Shadow Prince, and a "6" to spend with The Three.

Also, not sure if this matters for the backgrounds tab: characters have a minimum of 2 backgrounds but you could theoretically have like 20 if you built your character in a really weird way. I wouldn't expect most people to have more than, say, 5 though. But it can easily be a different number for different characters.

Update and check it out.

Looks great! Thank you very much.


[MM-9374] Open Permalinks in app

Summary
Open permalinks in-app the same way we do the search result preview
Ticket Link
https://mattermost.atlassian.net/browse/MM-9374
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] All new/modified APIs include changes to mattermost-redux (https://github.com/mattermost/mattermost-redux/pull/408)
[x] Includes text changes and localization file updates

Device Information
This PR was tested on:

iOS 11.2 iPhone 6 and iPhone X Simulator
11.2.5 iPhone 6s
Android 7.1.1 and Android 8.0 Emulator
Android 6.0.1 Samsung J5

@hmhealey changes made