Kernel boot time ahead of CSV

I was trying this bundle, without success.
Upon debugging i figured the profiles are filtered out based on kernel boot time (which theoretically makes sense :))
First run:
^ "Profile: 2022-07-12 12:25:36"
^ "Kernel:  2022-07-12 12:26:21"

Second run:
^ "Profile: 2022-07-12 12:26:22"
^ "Kernel:  2022-07-12 12:26:28"
^ "Profile: 2022-07-12 12:25:36"
^ "Kernel:  2022-07-12 12:26:28"

Im not entirely sure why profiles are stored first :thinking: nor do i have another solution, but perhaps food for thought.

Hey, nothing comes to mind with that context, but let's try to figure this out :).
Could you provide more information about how you've configured the differents bundles, your environment php/symfony versions and how you're using the bundle (behat, phpunit, etc).

im using thebin/console ... --toolbar integration
sf 4.4 / php 7.4 / containerized
i will try to debug the order of execution soonish :+1:

@adrienbrault reading comes before writing somehow ... thus a priority issue.
^ "Sourceability\ConsoleToolbarBundle\EventListener\ConsoleToolbarListener::onTerminate" // reads
^ "Sourceability\Instrumentation\EventListener\CommandProfilerListener::onTerminate" // writes


remove tf v1 compat for CBas VAE usage

under the imports of src/poli/objective_directory/gfp_cbas/make_vae tf v2 behavior is disabled.
This kills eager execution across the whole environment.
For experiment usage we require eager execution (to be Trieste compatible).
Commenting out or removing that line from the code seems to not affect functionality.
This has to be confirmed and tested.

While addressing this bug, I recommend to also address "cosmetic" Attribute Error arising from the added BaseVAE class.
Multiprocessing attempts to pickle BaseVAE lambda objects. This is wrapped, but appears as Error to the user. Gracefully wrap and perhaps suggest to not multiprocess here.
Traceback (most recent call last):   File "/Users/rcml/poli/src/poli/objective.py", line 158, in run     conn.send(["ATTRIBUTE", attribute])   File "/Users/rcml/miniforge3/envs/poli__protein_cbas/lib/python3.9/multiprocessing/connection.py", line 206, in send     self._send_bytes(_ForkingPickler.dumps(obj))   File "/Users/rcml/miniforge3/envs/poli__protein_cbas/lib/python3.9/multiprocessing/reduction.py", line 51, in dumps     cls(buf, protocol).dump(obj) AttributeError: Can't pickle local object 'BaseVAE._build_latent_vars.<locals>.<lambda>'

This might be related, and could maybe be addressed by this issue too: the first time we import poli from an environment that has tensorflow, we get the following warning:
WARNING:tensorflow:From /usr/local/lib/python3.10/dist-packages/tensorflow/python/compat/v2_compat.py:108: disable_resource_variables (from tensorflow.python.ops.variable_scope) is deprecated and will be removed in a future version.
Instructions for updating:
non-resource variables are not supported in the long term

Hopefully this warning will disappear as soon as we remove the tf v1 compatibility.


Fix Odometer_mi charger dashboard

Odometer_mi override was set to km instead of mi in charges dashboard
should fix #3533
(edited this is in codespaces so dunno if this would break updating it)
also added a version change to the dashboard don't know what is required to be updated or if a single change in the json breaks them

@DrMichael will this pull request respect the setting that the user has set within TeslaMate? I know other Grafana dashboards use the user driven setting to show km or mi. This seems like it is hard coded to be one or the other.

@DrMichael will this pull request respect the setting that the user has set within TeslaMate? I know other Grafana dashboards use the user driven setting to show km or mi. This seems like it is hard coded to be one or the other.

I only changed the used unit for that override it's not like i'm changing how they are selected just the unit it is displayed as
but I bet the api returns odometer_km or odomoter_mi which ever the case is for that set car

@DrMichael will this pull request respect the setting that the user has set within TeslaMate? I know other Grafana dashboards use the user driven setting to show km or mi. This seems like it is hard coded to be one or the other.

I only changed the used unit for that override it's not like i'm changing how they are selected just the unit it is displayed as
but I bet the api returns odometer_km or odomoter_mi which ever the case is for that set car

Agree with that entirely. Just wanted a second validation. Digging further into the code, it looks like there was a copy paste with a lack of replace when adding the odometer.
Thanks for the PR 😄

Right, it was just a naming error on my side... Depending on the setting, either odometer_km or odometer_mi will  be set.


React SwiperSlider gaps  Issue on autoplay and loop mode

I realized there are gaps in the swiperSlider when in loop and autoplay mode on page reload. even though I consider on page reload sliders can be blank because components are mounting but when I click the next button I get all sliders alright but I get gaps at the end of the last slider before the  loop kicks in to the first slider.

Your issue is closed because it is not filled correctly. Before you open an issue please review the contributing guideline.
Please fill the issue template correctly and:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with isssue

It will save a lot of time for other contributors to check your issue and fix it.


Fix issue #3523，add AOP test for shenyu-client-sofa

Fixes #3523

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #3563 (fe46a73) into master (ad84b54) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3563      +/-   ##
============================================
- Coverage     62.83%   62.52%   -0.31%
+ Complexity     5574     5543      -31
============================================
  Files           842      842
  Lines         23351    23376      +25
  Branches       2118     2124       +6
============================================
- Hits          14672    14617      -55
- Misses         7331     7402      +71
- Partials       1348     1357       +9

Impacted Files
Coverage Δ

...plugin/logging/rocketmq/LoggingRocketMQPlugin.java
22.72% <0.00%> (-72.73%)
:arrow_down:

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
75.00% <0.00%> (-25.00%)
:arrow_down:

...controller/ShenyuClientHttpRegistryController.java
77.77% <0.00%> (-22.23%)
:arrow_down:

...ogging/rocketmq/body/LoggingServerHttpRequest.java
0.00% <0.00%> (-20.00%)
:arrow_down:

...ruptor/RegisterClientServerDisruptorPublisher.java
52.94% <0.00%> (-11.77%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

.../apache/shenyu/admin/model/dto/BatchCommonDTO.java
50.00% <0.00%> (-7.15%)
:arrow_down:

...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java
57.14% <0.00%> (-7.15%)
:arrow_down:

...enyu/client/tars/TarsServiceBeanPostProcessor.java
79.26% <0.00%> (-7.10%)
:arrow_down:

...java/org/apache/shenyu/common/utils/UUIDUtils.java
75.00% <0.00%> (-6.25%)
:arrow_down:

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad84b54...fe46a73. Read the comment docs.


Add references section

Use linked in recommendations.
Q) Can we automate via rest-api?
https://developer.linkedin.com/docs/rest-api
Else copy rec text and link to profile.
Edit: LI API won't give me recs - just scrape them for now - it's not like I get them that often.

Scrape would be during build process anyway.


Conduct a retrospective, and publish its results.

Retro results published https://github.com/opensearch-project/dashboards-search-relevance/issues/204#issuecomment-1597509160


Can't translate a buffer that includes multiple frames

I found an infinite loop in Draft_10.translateFrame.
If a buffer includes multiple frames is passed to Draft_10.translateFrame,
the while loop (commented "Read as much as possible full frames") becomes an infinite loop.
Maybe an offset calculation is missing in Draft_10.translateSingleFrame.
I guess "payloadstart" should be "foff + payloadstart" in following codes
(also "maskskeystart" ?):
124: byte[] maskskey  = ByteBuffer.allocate ( 4 ).put (  b , maskskeystart , 4 ).array ();
126: payload.put ( ( byte ) ( (byte)b[ payloadstart + i ] ^ (byte)maskskey[ i % 4  ] ) );
130: payload.put ( b , payloadstart , payloadlength );
133: buffer.position ( payloadstart + payloadlength );

I fixed them, and it seems to work fine.

thanks for finding that bug!!
"foff" has to be added to both "maskskeystart" and "maskskeystart"


ci: Create sonar project properties for showcases

Pull Request checklist
🚨 Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Don't request your main!
[x] Make sure you are making a pull request against the main branch (left side).
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.

Description
This pull request set things up for sonar monorepo strategy.
Does this introduce a breaking change?

No

Other information
fix #35
❤ Thank you!

@jlind23 many thanks!!

@jlind23 many thanks!!


Reporting breakage and feedback

Feature Request
Description:
Capability for submitting breakage reports directly to Google.
User Story:
As a developer/web-user observing and analyzing PS/3PCD debugging scenarios I want to be able to report breakages to the right feedback channels.
Acceptance Criteria:

[ ] Report form aligns with Bug Report Template
[ ] Configurable endpoints (e.g. Buganizer, Github)

We have added an issue template to help users report a breakage, closing this task for now.


Children items are not vertically aligned properly when the height of the parent is undefined

Sample input:
{
  style:{
    flexDirection:"row"
  },
  children:[
    {
      style:{
        width:100,
        flexDirection:"row"
      },
      children:[
        {
          style:{
            width:20,
            height:20,
            alignSelf:"flex-end"
          }
        }
      ]
    },
    {
      style:{
        width:100,
        height:200
      }
    }
  ]
}

"flex-end" in the sample is not doing anything.

correct:

wrong:

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

:+1:

Facing this issue

We may be experiencing a very similar issue in which flex properties have no effect unless the width is explicitly defined. In other words, centering is basically impossible unless the width is explicitly set. This could be solved if width:100% were possible, but that's a separate (but again, related?) issue.

+1


fix(label): fix weight

Fix weight in InputLabel
https://jira.zopa/browse/ZDS-27

:tada: This PR is included in version 4.6.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[WFCORE-5775] Remove the org.wildfly.management.expression-resolver-e…

…xtension-registry capability
https://issues.redhat.com/browse/WFCORE-5775
This is an old branch I found sitting unpushed, so let's see if it works.

It works, so I've moved this out of draft state.

Thanks @bstansberry


Added runtime dependencies for KafkaAppender to gradle build (#770)

Some jar dependencies are needed to use the KafkaAppender in Log4j. These were added to the list of runtime dependencies.

I believe we have to use the internal version of Kafka. Have you check with the Kafka team?

The internal version of Kafka should be able to communicate with the external version of Kafka. I've also tested this using the external Kafka on our machines and they work fine.

Just recording what was discussed offline.
This code introduces compile time dependencies on Kafka. I'm just wondering whether that's the best way to go.

Closing this as if people want to use Kafka at run time, they should include the runtime dependency in themselves.


Broker process gets killed by kernel due to OOM

This issue is still present. No errors or exceptions can be seen in the broker log.
Broker process gets killed by kernel due to OOM.
$ dmesg returns the following :
[863081.188433] [29541]  1004 29541 13691125  7552481 61505536        0             0 java
[863081.188441] Out of memory: Kill process 29541 (java) score 980 or sacrifice child
[863081.196640] Killed process 29541 (java) total-vm:54764500kB, anon-rss:30209924kB, file-rss:0kB, shmem-rss:0kB
[863082.678027] oom_reaper: reaped process 29541 (java), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB

Can you share your Broker runtime.properties and jvm config please?

System configuration is 8 vCPUs and 30GB memory.
jvm.config
-server
-Xms24g
-Xmx24g
-XX:MaxDirectMemorySize=28g
-Duser.timezone=UTC
-Dfile.encoding=UTF-8
-Djava.io.tmpdir=/var/tmp
-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager

The above gives the JVM 24GB of heap but also allows the process to acquire up to 28gb of memory for offheap structures like direct bytebuffers, exceeding the system;s total memory. You may want to look at the example configuration  https://github.com/apache/incubator-druid/blob/master/examples/conf/druid/broker/runtime.properties

@Dylan1312 For now, introducing one high configuration instance of broker has resolved the issue.
I think I will choose to replace the low configuration instance with a high configuration one in the later future since the work division between two brokers is equal and not well balanced.
And, any suggestion on what to tune in the runtime.properties?


Unable to list columns for Delta tables

System information:

Operating system (distribution) and version: macOS Monterey
DBeaver version: <IP_ADDRESS>207091909
Additional extensions

Connection specification:

Database name and version: Apache Kyuubi 1.5.2 (Incubating) with Spark 3.2.1 and Delta Lake 1.2.1
Driver name: Apache Hive/ Apache Spark / Apache Kyuubi (Incubating)

Describe the problem you're observing:

Unable to list columns, show table properties, or generate SQLs for Delta tables
Querying using SQL works fine however

Steps to reproduce, if exist:
https://user-images.githubusercontent.com/1594393/180228686-4800ee9f-e417-4126-ac61-f6dd2a650269.mov
Include any warning/errors/backtraces from the logs

errors.log

Could you please send the log files? You can find instructions here: https://dbeaver.com/docs/wiki/Log-files/. Thank you.

@LonwoLonwo here is the exported log: errors.log

Ok, thanks for the logs. Maybe you have some database examples for testing?

@LonwoLonwo sure.
It can be reproduce by a simple Delta table
CREATE EXTERNAL TABLE delta_table_example (name STRING, age INTEGER) USING DELTA;
INSERT INTO TABLE delta_table_example (name, age) VALUES ('Michael', null);
INSERT INTO TABLE delta_table_example (name, age) VALUES ('Andy', 30);
INSERT INTO TABLE delta_table_example (name, age) VALUES ('Justin', 19);

Then double click on the new table on Database Navigator/Projects will give the same error as in the description.

One thing I noticed is that if I just set the database/schema from a Script editor, e.g. executing USE default; then the table properties, columns and "Generate SQL"  will work properly. So my guess is these errors have something to do with multi-level table identifier (Kyuubi catalog and Spark 3.x.x have namespace concepts)

Thanks for the report.

I also faced same issue.


Documentation missing in the initial samples snippets validateField

It's only on the API

OOps, sorry duplicated,


How To remember plots Positions( pan , zoom , visibility, etc) before clearing needed for update with live data?

I am using plt.clear() and creating my new plt.Plottables.  Since my update is every 1 minute the performance is not a big concern for now, but if I have Zoomed or changed limits , etc after update I will lose them.

double[] originalAxisLimits = plt.Axis();
plt.clear();
/* plot new stuff */
plt.Axis(originalAxisLimits);

Something like this should do the trick!

You may also find the Margin() method useful:
plt.AxisAuto(horizontalMargin: 0, verticalMargin: 0.5);


Use esbuild for prepacking

https://github.com/mhsdesign/jit-browser-tailwindcss/commit/48847787122cb6f55eea9798d2fcfcd75da56a0b


How to add second scenario with different 'given' statement?

I have such feature:
Feature: main feature
  Scenario: 1 scenario
    When 1 step
    Then finish
  Scenario: 2 scenario
    When 2 step
    Then finish
How can I use steps from 2 different files (steps/first.js, steps/second.js) ?
import first_steps from './steps/first.js';
import first_steps from './steps/second.js';

export default function (assert) {
  return ...; // what I must return here?
}

:smile: Good one never though of that.
They both import the main steps library?

The idea was originally that you would create a chain of steps files so one base one for the application
acceptance/steps/steps.js and then a feature specific one per feature acceptance/steps/main-feature.js.
But I think it's possible but you have to change the ./steps/first.js and the ./steps/second.js a bit.

first or second steps should look something like this:
export default function(steps, assert) {
  steps.given('yadda yadda', function(next) {
    assert.ok(false);
  });
});

import steps from './steps.js`;
import first_steps from './steps/first.js';
import second_steps from './steps/first.js';

export default function (assert) {
  const first = first_steps(steps(assert), assert);
  return second_steps(first, assert);
}

The idea is that we create one library at the end. And we look for that in the acceptance/steps folder at the same location as your feature file with the same name.

Or you could chain them:
steps.js -> first_steps.js -> second_steps.js.

@olegdovger did it work?


Clean up databases and couch DBs with addCleanup instead of tearDown

Wondering if this has anything to do with the WorkQueue problem @alexanderrichards has been looking at.

test this please

Test this please

test this please

test this please

test this please

@ticoann @alexanderrichards This is Alex's patch plus a bit of my own to make the cleanup more reliable. I still don't understand this, but frankly I'm tired of it. Please merge it. It's not going to fix all the stability problems, but it may help.


files referenced in pv db have wrong path

All file references in all pv-*.mdb files need to be changed to D:\parts\ (from D:\vault\parts)

Need to double-check before closing.

This is not an application issue (ithe error is in the entered data).


[FLINK-24768][runtime-web] upgrade Angular and NG-ZORRO versions to 13

What is the purpose of the change
Upgrade Flink Runtime Web's dependencies Angular and NG-ZORRO versions to 13. Close FLINK-24768.
Brief change log
Update flink-runtime-web's dependencies and devDependencies.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): yes
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

I have to explicitly add @ant-design/icons-angular as a dependency for flink-runtime-web even thought it is a dependency for NG-ZORRO.
When I ran npm install under node v14.18.X, everything worked fine. But if I ran the former command under node v16.10.X, @ant-design/icons-angular did not install as expected. This may be caused by the fact that NG-ZORRO's package.json engines field still uses ^12.20.0 || ^14.0.0, missing ^16.0.0 (according to angular version guide).
Once NG-ZORRO fixes this issue, I can then safely remove this explicit dependency.

Can you please open an issue both against NG-ZORRO and one in the Flink JIRA to track this?

Thanks for the advice. Here is an issue tracking the problem: FLINK-25714

@flinkbot run azure


Add support for Craft Docs importer [https://www.craft.do/]

With backlink converter

This is a duplicate of #27


feat: added avatar tailoring and uploading

Add: https://github.com/casbin/casdoor/issues/18

Updated yarn.lock now. @hsluoyz

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Send local broadcasts instead of System wide

I noticed that the library sends a system wide broadcast: com.tonyodev.fetch2.action.QUEUE_BACKOFF_RESET
I wanted to know what made you send system-wide broadcasts? It is not possible to use LocalBroadcastManager for this purpose ?

@amsurana Great catch! I have added intent.setPackageName(context.packageName) to limit the scope. The reason why we don't use LocalBroadcastManager is because we would have to add the androidx support library as a dependency to only use LocalBroadcastManager.


[Bug]: "Default settings" missing in console mobile view

Preflight Checklist

[X] I could not find a solution in the documentation, the existing issues or discussions
[ ] I have joined the ZITADEL chat

Environment
ZITADEL Cloud
Version
No response
Database
None
Database Version
No response
Describe the problem caused by this bug
Can't access the default settings when viewing the console on mobile.
To reproduce

On a small screen go to the console
Try to get to the "default settings" page

Screenshots

Expected behavior
Navigation should be accessible on the mobile device.
Operating System
No response
Relevant Configuration
No response
Additional Context
When switching to landscape mode the button is visible; If this is the expected use, then that should be indicated to the user

I'm working on this.


update readme

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2cb3b46). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             master        #4   +/-   ##
==========================================
  Coverage          ?   100.00%
==========================================
  Files             ?         7
  Lines             ?       150
  Branches          ?         0
==========================================
  Hits              ?       150
  Misses            ?         0
  Partials          ?         0


Provide an option (--config config.json) to pass in the configuration

I would like to provide an option to pass in the configuration so we can skip the prompts similar to what is provided for liferay-js-toolkit.
This will allow us to programmatically invoke the generators for unit tests and for blade-cli without requiring a users input.

Hey @david-truong, which versions of the Toolkit will need this option? Can you provide an overview of the setup that will be integrating it?

We will need it for 8.x and 9.x.
For blade have a project with the following package.json
8.x
	"devDependencies": {
		"generator-liferay-theme": "8.1.2",
		"yo": "3.1.0"
	},
	"scripts": {
		"build-theme": "yo liferay-theme --skip-install",
		"import-theme": "yo liferay-theme:import --skip-install"
	},
	"version": "1.0.0"
}```

9.x

{
"devDependencies": {
"generator-liferay-fragments": "1.2.1",
"generator-liferay-js": "2.18.2",
"generator-liferay-theme": "9.5.0",
"generator-liferay-theme-themelet": "1.2.0",
"yo": "3.1.0"
},
"scripts": {
"build-fragment": "yo liferay-fragments",
"build-theme": "yo liferay-theme",
"build-widget": "yo liferay-js"
},
"version": "1.0.0"
}```
and we run $YO_PATH liferay-theme --config config.json

See how this feature is used in https://github.com/liferay/liferay-js-themes-toolkit/pull/467

This has been tested and works, so I'm closing it.


Implement server restart tests to mitigate regression issues

There is another pr for this same tests which is merged


Add search integration

Description:
Putting this up for feedback.
Our data is interconnected, making it a graph. This means that we can also search it as a graph. This integration can give you related items based on any node in the graph. Currently only implemented areas, devices, entities.

Putting PR up mainly for feedback.
Goal of this integration will be to provide related data in the UI. Example use cases:

Show scenes that impact a specific area
List automations that use a specific input_boolean

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

I've added support for scenes and config entries.
When we find a config entry, scene, automation or script (the outputs!), we will no longer further resolve it into subtypes. Because if I query for a device, I don't want to return all devices that share a scene or config entry with the device that I am querying for.
It's still possible to pick any of those as an entry point, in which case they will be resolved. So these types are search type only.
Support for script/automation should move to a new PR to no longer further complicate this.

This is ready for approval/merging.

The result is not a graph, it only contains all vertices, but missing the edges.
We can extend the search methods to return a tuple (vertices, edges).
self.results = defaultdict(set)  #vertices
self.edges = defaultdict(set)

# in Searcher class
def search(self, item_type, item_id):
  self.results[item_type].add(item_id)
  self._to_resolve.add((item_type, item_id))

  while self._to_resolve:
    search_type, search_id = self._to_resolve.pop()
    await getattr(self, f"_resolve_{search_type}")(search_id)

  return (self.results, self.edges)

# for example device
def _resolve_device(self, device_id) -> None:
  device_entry = self._device_reg.async_get(device_id)
  if device_entry is not None:
    if device_entry.area_id:
      self._add_or_resolve("area", device_entry.area_id)
      # add edge
      self.edges[("device", device_id)] = ("area", device_entry.area_id)
    for config_entry_id in device_entry.config_entries:
      self._add_or_resolve("config_entry", config_entry_id)
      # add edge
      self.edges[("device", device_id)] = ("config_entry", config_entry_id)

  for entity_entry in entity_registry.async_entries_for_device(
    self._entity_reg, device_id
  ):
    self._add_or_resolve("entity", entity_entry.entity_id)
    # add edge
    self.edges[("device", device_id)] = ("entity", entity_entry.entity_id)

Well I wonder if we should return it as a graph? The user just wants to see related data. It doesn't care much about the relationship maybe?

Nice!
Will this gain other ways of searching in the future or is it just for finding related objects? (Wondering if there is a more descriptive name if its just for finding related objects).

@Jc2k for now it's just related items. I'll update the websocket endpoint.


ts: Convert util module to TypeScript.

Are these sections of this we should merge now to head off merge conflicts?  (It seems potentially reasonable to merge the imprecise type with topic/subject now and then clean that up in a follow-up PR, if it doesn't result in too much clutter to do so).

The first five commits are certainly mergeable, though I don’t expect them to be much of a conflict problem.

js: Use method chaining for multiple array operations.
util: Cleanup CachedValue class.

Nit—the verb is “clean up”, not “cleanup”.

rtl: Use _.sortedIndex instead of util.lower_bound.
util: Make less function required for lower_bound.
util: Rewrite same_recipents to not use switch.

But I think I’d prefer not to proactively introduce a bunch of .topic ?? .subject conditionals to be fixed later, because that code transformation loses information about which one we expect to exist.

OK, merged the first 5 commits as the series ending with 1e94f6ac966b8214a61db9cc64db3221a94c0cd3.  (Oops, failed to fix your nit before doing so, oh well).

@priyank-p are you up for rebasing this, after I merged your other two typescript PRs today?  Also, it'd be great if you can comment if you believe you've resolved the remaining comments, since I didn't see an explicit confirmation on that one way or another.

For this PR to be integrated, the plan was to migrate the codebase to use message[TOPIC_FIELD_NAME] instead of message[TOPIC] first and then rebase this on top.

A version of this was completed in 911b3b5365d9bfd935b04b5406bb302616c02783, thanks for the work on this @priyank-p!


Additional YAML document header when rendering CRDs to stdout

Output of helm version:
version.BuildInfo{Version:"v3.14.4", GitCommit:"81c902a123462fd4052bc5e9aa9c513c4c8fc142", GitTreeState:"clean", GoVersion:"go1.22.2"}

Context: the CI for our charts renders all the content including CRDs before piping the result to kyverno to check compliance with internal policies. This step fails because helm produces empty documents.
This bug arises only for CRDs when rendering to stdout, if the yaml file for the CRD in the subchart starts with the document separator ---.
To reproduce, in this repository:
# Add a --- at the beginning of the CRD file
$ echo -e "---\n$(cat ./cmd/helm/testdata/testcharts/subchart/crds/crdA.yaml)" > ./cmd/helm/testdata/testcharts/subchart/crds/crdA.yaml
# render
$ helm template --include-crds cmd/helm/testdata/testcharts/subchart/ | head

The output:
---
# Source: subchart/crds/crdA.yaml
---
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  name: testcrds.testcrdgroups.example.com
spec:
  group: testcrdgroups.example.com
  version: v1alpha1

After looking at the code, I suspect that the problem lies in this code that directly write the crd file content: https://github.com/helm/helm/blob/14d0c13e9eefff5b4a1b511cf50643529692ec94/pkg/action/action.go#L190

the PR in question that fixes the issue is still not merged, can we please have this issue stay open till then? Thanks in advance!


Enable convert data for AKS deployments

Description
Add an option to enable $convert-data for AKS deployments.
FHIR Team Checklist

[x] Update the title of the PR to be succinct and less than 50 characters
[ ] Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
[ ] Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
[ ] Tag the PR with Azure API for FHIR if this will release to the Azure API for FHIR managed service (CosmosDB or common code related to service)
[ ] Tag the PR with Azure Healthcare APIs if this will release to the Azure Healthcare APIs managed service (Sql server or common code related to service)
[ ] CI is green before merge
Review squash-merge requirements

Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)

/azp run

/azp run

Thank you for your contribution @Alan-Kuan!


an API that returns which fonts should be loaded for a particular piece of math

We're scaling KaTeX output based on screen size and how wide the rendered math is.  Unfortunately, it's hard to know when the math is finished rendering b/c we have to wait for the fonts to load before we get the final rendering.  I'm using https://github.com/typekit/webfontloader to wait for the most common fonts to be loaded before measuring the output, but this has some drawbacks: I'm loading unnecessary fonts in some cases and in other cases I'm not waiting for certain fonts that aren't the most common.

I do have something along these lines in my #251 render to canvas branch. There the result I'm returning from the prepare function contains a fontsUsed property which is an object with webfontloader-compatible FVDs as keys (and CSS font descriptions as values, but that's of little practical value). I'm using this in CindyJS.


Warnings emitted when importing aws:lb:Listener, One or more imported inputs failed to validate

Similar to #4361 importing aws:lb:Listener works but emits warnings:
  aws:lb:Listener (listener):
    warning: One or more imported inputs failed to validate. This is almost certainly a bug in the `aws` provider. The import will still proceed, but you will need to edit the generated code after copying it into your program.
    warning: aws:lb/listener:Listener resource 'listener' has a problem: expected default_action.0.order to be in the range (1 - 50000), got 0. Examine values at 'listener.defaultActions[0].order'.

Thanks for reporting this @Zaid-Ajaj! I have a hunch that this is nils/default values for primitives returned by the AWS SDK not being handled correctly.
I tried reproducing this, but couldn't trigger this exact error. But another one:
aws:lb/listener:Listener resource 'testitest' has a problem: expected default_action.0.forward.0.stickiness.0.duration to be in the range (1 - 604800), got 0. Examine values at 'testitest.defaultActions[0].forward.stickiness.enabled'.

This is the Listener I tried importing:
const listener = new aws.lb.Listener("my-listener", {
    loadBalancerArn: loadbalancer.arn,
    port: 80,
    defaultActions: [{
        type: "forward",
        targetGroupArn: targetGroup.arn,
    }],
});

I'm quite sure this line here is triggering the initial issue. It's converting the pointer to Order to an int32, which will yield 0 if Order is nil:
https://github.com/hashicorp/terraform-provider-aws/blob/3724def77810f619392ecb79fd3e40915c0b0214/internal/service/elbv2/listener.go#L977
Similarly this here will trigger the issue I was able to find because it coerces the pointers for stickiness duration & enabled config into primitives:
https://github.com/hashicorp/terraform-provider-aws/blob/3724def77810f619392ecb79fd3e40915c0b0214/internal/service/elbv2/listener.go#L1170-L1171
We'll need to fix the upstream handling of optional values in read for elbv2 Listener.

Correcting the code of the imported resource and running pulumi up correctly aligns the state.
This is in line with the behavior in upstream. e.g. see Step 4 - Import here https://github.com/hashicorp/terraform-provider-aws/issues/37211#issuecomment-2127911378.
Running this terraform program and then importing the resource (terraform import aws_lb_listener.testitest "arn:aws:elasticloadbalancing:eu-central-1:REDACTED:listener/app/my-lb-68bcf24/37b75057b7294e93/8480247a88078e97") shows the same behavior as with Pulumi.
terraform {
  required_providers {
    aws = {
      source  = "hashicorp/aws"
    }
  }
}

provider "aws" {
  region = "eu-central-1"
}

resource "aws_lb_listener" "testitest" {
    load_balancer_arn = "arn:aws:elasticloadbalancing:eu-central-1:REDACTED:loadbalancer/app/my-lb-68bcf24/37b75057b7294e93"
    port              = 80

    default_action {
        type             = "forward"
        target_group_arn = "arn:aws:elasticloadbalancing:eu-central-1:REDACTED:targetgroup/my-tg-355c5dc/12565d1a2120a867"
    }
}

tf apply output
aws_lb_listener.testitest: Refreshing state... [id=arn:aws:elasticloadbalancing:eu-central-1:REDACTED:listener/app/my-lb-68bcf24/37b75057b7294e93/8480247a88078e97]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_lb_listener.testitest will be updated in-place
  ~ resource "aws_lb_listener" "testitest" {
        id                = "arn:aws:elasticloadbalancing:eu-central-1:REDACTED:listener/app/my-lb-68bcf24/37b75057b7294e93/8480247a88078e97"
        tags              = {}
        # (5 unchanged attributes hidden)

      ~ default_action {
          + target_group_arn = "arn:aws:elasticloadbalancing:eu-central-1:REDACTED:targetgroup/my-tg-355c5dc/12565d1a2120a867"
            # (2 unchanged attributes hidden)

          - forward {
              - stickiness {
                  - duration = 0 -> null
                  - enabled  = false -> null
                }
              - target_group {
                  - arn    = "arn:aws:elasticloadbalancing:eu-central-1:REDACTED:targetgroup/my-tg-355c5dc/12565d1a2120a867" -> null
                  - weight = 1 -> null
                }
            }
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

aws_lb_listener.testitest: Modifying... [id=arn:aws:elasticloadbalancing:eu-central-1:REDACTED:listener/app/my-lb-68bcf24/37b75057b7294e93/8480247a88078e97]
aws_lb_listener.testitest: Modifications complete after 1s [id=arn:aws:elasticloadbalancing:eu-central-1:REDACTED:listener/app/my-lb-68bcf24/37b75057b7294e93/8480247a88078e97]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

Opened upstream issue: https://github.com/hashicorp/terraform-provider-aws/issues/38861

Adding this to https://github.com/pulumi/pulumi-terraform-bridge/issues/2028 as well -  I do think this could be mitigated by https://github.com/pulumi/pulumi-terraform-bridge/issues/2314 if it could be made to handle recursive values.

The issue was fixed upstream and just released as part  of v5.69.0. This should be fixed when we pull this release into pu-aws in the next days.


Error fetching Quote:[object Object]

Hi, I get this error every so often.
It dosn't appear to impact any functionality, once i click the error the TV charts are loaded.
(Chrome Version 62.0.3202.94 (Official Build) (64-bit))
Rgds
K,

same here on osx
Version 62.0.3202.94 (Official Build) (64-bit)

Same here : Version 63.0.3239.84 (Official Build) (64 bits)


Question about Training Time

Hi,
Thx for your great work! I'm trying to rerun the training process of DETR3D on a 8-V100 machine using the default setting of detr3d_res101_gridmask_cbgs.py and the estimation of the training time is 8 days (I notice that the training epoch in paper is 12 while the code is 24, so for you the time should be 36h in this config?), which is 5.4x longer than the time you reported in the paper. Is this normal? I think 3090 should not be 5.4x faster than V100...

Hi,  zehuichen
In the paper, we list the training time for 12 epoch with 8x 3090 without using cbgs. I am sorry we didn't make it clear.
CBGS dataset will over-sample the dataset, leading to around 3x-4x(I may remember the wrong number, but this should be close) more samples per epoch.

Thanks for your clarification.


Modulation based on via-points using ProMP or KMP?

Hi, would you add any demo for the trajectory modulation based on via-points using KMP?

We do not have plans to include these new functionalities using ProMP or KMP, but we would still be open to review pull requests from contributors that bring these new nice features :)


Problem with the operation of cables

Hi, I need to know how to transport the energy from my solar generator to my electric arc furnace. But I do not know how the cables are used. I use version 1.7.10

You just need to build the cabels and put them under your solar panels but I would recommend to use other cabels if avaible.

Still not working can you send me an image to see how it is placed?

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.


OpenXR doesn't support acceleration and angularAcceleration

Hi,
Hardware providers rely more and more on OpenXR. However, OpenXR does not support acceleration and angularAcceleration input (not velocity derived), which are, as position and orientation, key inputs of XR devices and tha are available for many headset products on the market. Accelerations and AngularAccelerations are the only vectors which are available when the handler are not visible by the headset. As such, they allow for the estimation of the movement when the disappearance of the handlers are momentary.
**

** ? This lack is a major issue since, at the present time, there is no other way to get this informations.
Best Regards

Closing as a dupe to the other one I replied  to. (#504 )


No module named skimage.draw

I have installed scikit-image using command 'pip install scikit-image'. But I still get this error? What happened?

When I run 'python experiments/faster_rcnn/rcnn_end2end_train_test.py --cfg experiments/faster_rcnn/cfgs/resnet_v1_101_voc0712_rcnn_dcn_end2end.yaml'.
Errors are as follows,
/usr/local/lib/python2.7/dist-packages/h5py/init.py:36: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
from ._conv import register_converters as _register_converters
Traceback (most recent call last):
File "experiments/faster_rcnn/rcnn_end2end_train_test.py", line 17, in
import train_end2end
File "experiments/faster_rcnn/../../faster_rcnn/train_end2end.py", line 51, in
from utils.load_data import load_gt_roidb, merge_roidb, filter_roidb
File "experiments/faster_rcnn/../../faster_rcnn/../lib/utils/load_data.py", line 9, in
from dataset import *
File "experiments/faster_rcnn/../../faster_rcnn/../lib/dataset/init.py", line 4, in
from coco import coco
File "experiments/faster_rcnn/../../faster_rcnn/../lib/dataset/coco.py", line 23, in
from .pycocotools.coco import COCO
File "experiments/faster_rcnn/../../faster_rcnn/../lib/dataset/pycocotools/coco.py", line 54, in
from skimage.draw import polygon
ImportError: No module named skimage.draw


@hapi/joi package has been deprecated

Author message:
joi is leaving the @hapi organization and moving back to 'joi' (https://github.com/sideway/joi/issues/2411).
I am using https://www.npmjs.com/package/joi and joi-extract-type is incompatible with Joi.
##So when we are going to depend on joi instead of @hapi/joi

joi-extract-type has not been made compatible with Joi 16 yet,
https://www.npmjs.com/package/joi only has version 17.  And deprecated versions (14)
This will have to be addressed first: https://github.com/TCMiranda/joi-extract-type/issues/22

Thank you so much for quick response.


Graph Editor crashes when trying to rename

If you select the name of the element in the property editor and clear it, the Graph Editor will crash
as it seems to throw an exception when trying to update the UI.
Side Effect
This is the call stack:
MaterialXGraphEditor.exe!MaterialX_v1_38_8::InheritanceIterator::operator++() Line 209	C++
MaterialXGraphEditor.exe!MaterialX_v1_38_8::InterfaceElement::getActiveInputs() Line 406	C++
MaterialXGraphEditor.exe!MaterialX_v1_38_8::InterfaceElement::hasExactInputMatch(std::shared_ptr<MaterialX_v1_38_8::InterfaceElement const> declaration, std::string * message) Line 616	C++
MaterialXGraphEditor.exe!MaterialX_v1_38_8::Node::getNodeDef(const std::string & target, bool allowRoughMatch) Line 113	C++
MaterialXGraphEditor.exe!Graph::propertyEditor() Line 3206	C++
Seems to think there is a cycle and throws an uncaught exception.
Reproducible Steps:

Start up the editor. The default marble will be shown.
Select the marble shader (SR_marble1). Check that the node's properties are visible in the Property Editor on the left.
Select the text in the name field and delete the text. `SR_marble1)
An exception will be thrown which can be examined in a debugger.
The call stack is when trying to update the UI attributes in the editor.  Namely tying to resolve the name of the input.

Root Cause:
The main issue is that the code does not handle an empty name properly by allowing this to be performed and then not handled properly
Possible Fixes:

Prevent an empty name from being entered (in UI code).
Prevent an empty name from being set in the setName() API.
Fix the code which is throwing this exception as it does not handle empty names properly.

All 3 are actually recommended by as a "first issue" fix, 1, 2 seem reasonable to understand the property editor code (1), and
a small bit of the core code. (3) involves understanding more about how unique name resolution is performed but
is "doable".

Bonus Issue :)
There is also an issue with trying to rename a node to an existing node under the same parent. This results
in continuous renaming of the node on every refresh.
Repro Steps

rename SR_marble1 to be NG_marble1
the name of the node will keep on changing between NG_marble2 and NG_marble3.

Root Cause:
This seems to be due to not updating the UI node with the actual node name store on the MaterialX node (which is generated when calling setName().
Note that it would be good to fix this as part of firewalling name setting but can be split out into another issue...

Hi,
I will try to pick up this defect. I am new to this repo so hopefully I can finish within reasonable time.

Thanks for looking at this. Feel free to ping here or on Slack for anything.

Yes, I always hit this one, but I developed the memory muscle to avoid it.
Instead, what I also see is that if you selct a node and try to edit the name, if you hid Del to remove a character it instead deletes the node.
Or if you hit Tab to try and move to the next parameter it brings up the nodes add dialog.

There is a general issue that keystrokes and mouse controls are not being captured in the correct panel, or "leak" into all panels. Should probably log separate issues  for those not recorded yet.

Not sure the keystroke issue is logged. It also triggers an Up-One-Level command when I type a name that contains "u".

@zicher3d, @lfl-eholthouser : I have logged a new issue for keystrokes (separate from mouse interaction). https://github.com/AcademySoftwareFoundation/MaterialX/issues/1424

Thanks for flagging that @kwokcb

@kwokcb I think adding validation in setName(const std::string& name) makes the most sense. Just out of curiosity though how would you deal with the case of an empty name? Throw an exception, or default to some value?
setName gets called around 10 times in Graph.cpp.  Can write a wrapper method around it, that will catch an Exception. But after catching the exception, what would be the behavior from that point on?
So like...
Element.cpp
void Element::setName(const string& name)
{
    if (name.empty())
    {
        throw EmptyNameException("Element name cannot be set to empty name");
    }
    ...

Graph.cpp
void elementWrapperSetName(ElementPtr ptr, const std::string& name) {
  try {
    ptr->setName(name)
  } catch (const EmptyNameException& e) {
     // what do we do here? make random temp name?
  }

@ZelboK @kwokcb Is an empty element name actually invalid in MaterialX?  Since there's no specification rule to prevent this, I would have thought that an empty element name is completely valid, and that we should just support this in the graph editor as well.  Let me know, though, if I'm missing a subtle case that invalidates this usage more broadly.

@jstone-lucasfilm I was a bit hesitant on touching the Core API, for reasons you've listed. I don't have enough familiarity with the codebase to comment on an empty name being invalid in MaterialX, but if the way names are being set are problematic according to @kwokcb in the graph editor, then maybe just a wrapper around setName(const std::string& name) with validation and processing logic is the simplest solution where
void elementWrapperSetName(ElementPtr ptr, const std::string& name) {
  if (validated(name)
    ptr->setName(name);
  else {
    auto fixedName = doSomethingToFixName(name);
     ptr->setName(fixedName)

     }
 }

That's a great overview, @kwokcb, and I agree with your conclusions here.
Based on this interpretation, I like the idea of generating a valid name when setName is called with an empty string, following the approach in Element::addChildOfCategory:
https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/source/MaterialXCore/Element.cpp#L229

Will make a PR for this and push it. Thanks!

Thanks so much for looking into this issue, @ZelboK, and your initial investigation was invaluable in tracking down the core issues, which turned out to be more subtle and interconnected than I originally suspected.
Here's a proposal to address all of these issues, including the handling of empty names and other related issues that could trigger crashes when renaming nodes in the graph editor:
https://github.com/AcademySoftwareFoundation/MaterialX/pull/1501

Thanks for this original report, @kwokcb, and I'm closing this issue as resolved in #1501.


RFE: Use germline resources in MuTect2 to reduce artifacts in tumor-only mode

I thought this would be interesting to have, as described in:
https://software.broadinstitute.org/gatk/documentation/tooldocs/current/org_broadinstitute_hellbender_tools_walkers_mutect_Mutect2.php
However it needs yet another potential duplicate file which is part of the GATK resource bundle (and we already have gnomAD). I think however that the option might be very useful for tumor-only analyses to remove sources from being called (they are prefiltered) also reducing runtime times.
Thoughts?

The file in question (af-only-gnomad.hg38.vcf.gz) and its b37 counterpart are ~3G in size. I can't tell if it's worth downloading them or try somehow to replicate them off the gnomAD data already available.

Thanks! I think that would be a good improvement. Can you point me to where you downloaded that file?

It's available at<EMAIL_ADDRESS>(that is, a specific sublocation of the GATK resource bundle). I'd give the exact link but I can't access the URL right now.

I wonder if it'd be feasible to actually process our gnomAD files to produce something that is palatable for the GATK. That would avoid maintaining yet another resource.

Thanks-- if the Broad's files are kind of small, it might be easier to just use their preprocessed files. Our gnomAD prep takes hours-- @naumenko-sa do you see that as well? I think bcftools annotate in the recipe preparation is probably the culprit.

I haven't had yet the opportunity to test them, I think they're fairly minimal. A quick bcftools view showed this:
chr1    10067   .       T       TAACCCTAACCCTAACCCTAACCCTAACCCTAACCCTAACCC      30.35   PASS    AC=3;AF=7.384e-05
chr1    10108   .       CAACCCT C       46514.3 PASS    AC=6;AF=0.0001525
chr1    10109   .       AACCCT  A       89837.3 PASS    AC=48;AF=0.001223
chr1    10114   .       TAACCCTAACCCTAACCCTAACCCTAACCCTAACCCCTAACCCTAACCCTAACCCTAACCCTAACCTAACCCTAACCCTAACCCTAACCCTAACCCTAACCCTAACCCTAACCCTAACCCCTAACCCTAACCCTAAACCCTA  CAACCCTAACCCTAACCCTAACCCTAACCCTAACCCCTAACCCTAACCCTAACCCTAACCCTAACCTAACCCTAACCCTAACCCTAACCCTAACCCTAACCCTAACCCTAACCCTAACCCCTAACCCTAACCCTAAACCCTA,T      36729   PASS    AC=9,1;AF=0.0002246,2.496e-05
chr1    10119   .       CT      C       251.23  PASS    AC=5;AF=0.0001249
chr1    10120   .       T       C       14928.7 PASS    AC=10;AF=0.00025
chr1    10128   .       ACCCTAACCCTAACCCTAAC    A       285.71  PASS    AC=3;AF=7.58e-05
chr1    10131   .       CT      C       378.93  PASS    AC=7;AF=0.0001765
chr1    10132   .       TAACCC  T       18025.1 PASS    AC=2;AF=5.049e-05

Hence I guess it uses just AC' and AF` for each locus.

I wonder if we need to do anything at all-- we have those fields in the gnomAD files so we can probably just feed those in directly, if GATK is parsing the file at all reasonably.

Indeed. I'll try to feed one of the gnomAD files I have and see if it's processed correctly.

Thanks Luca!

Well, it didn't blow up at least. ;) It might be worth including it. @roryk @chapmanb As I believe gnomAD is optional, this should be done only if it's there. What's the cleanest way to check whether it is present?

https://github.com/bcbio/bcbio-nextgen/blob/master/bcbio/variation/vcfanno.py#L154 has a function find either exac or gnomAD, so I'd make a version of that that just checked for gnomad_exome.

@roryk
This looks very useful to filter germline variants. Has the --germline-resource options been integrated into bcbio?

Hello, I think we are leaning to not implementing this. I talked with Brad about it and he had a good practical take. The reasoning behind not implementing it is that if we filter them while we are calling them, the variants completely disappear and cannot be recovered. If we annotate them as being in gnomAD, then later on people can decide what they want to do with them-- whenever we add filtering, eventually folks will complain they are missing variants they are expecting to see. If we annotate then at least they can see why we filtered them, if we filter them, since at some point the variants will exist. This will slow down the mutect2 calls, since it will be caling in places it would have skipped, is the downside.

better later than never :) we need this resource for t-only mutect2 and purecn

@naumenko-sa, just looking at this, are these commits just adding the af_gnomad file or are you considering implementing the germline resources option for Mutect?

yes, I'm pushing germline resources in mutect as well.


Added EAP-Controller (Omada)

Description:
Added possibility to get data from EAP-Controller (new name 'Omada').
Tested with Controller V2.5.3 running on Linux.
Example entry for configuration.yaml (if applicable):
unchanged
Checklist:

[X] The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:
no new requirements

Hi @IVI053,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Also, here apply the same as mentioned in this comment.

Going to close this. Please open a new PR when you based off the right branch


[iOS] Test Rule remains invisible to iOS Verifier App

Describe the bug
Given the following VAC Certificate created with an imaginary non-existing Vaccine, scanned for country "Belgium" the iOS Verifier says "Valid" while the Android Verifier sees a rule.

Expected behaviour

The expectation is that the iOS Verifier App would also show orange because the rule has failed.
Steps to reproduce the issue

Technical details
iOS Verifier App 1.1.5-tst

Possible Fix

Additional context

@RalicaY @ltranvan could you check this with release 1.1.5.

@kerstin-oppermann-tsi , mit  iOS 1.1.5-tst für Belgien wird es immer noch grün angezeigt.  Meine Mutmaßung ist, dass die Regeln für Belgien von tst kommen und aus irgendeinem Grund unsichtbar bleiben.  Für Lithuania kriege ich schon GELB.    Deswegen habe ich das Ticket explizit für "Belgien" erstellt.

Ok @alexchornyi @Hendrik-Schmidt-Schierhorn-TSI can you check this issue please.

@RalicaY Fixed. But we need use one date format in all rules. The best solution - it's use iso date format.
Fixed will be available in next build.

@RalicaY can you retest this issue please. For me it works in the new iOS release.
@alexchornyi it would be cool if you can always link the appropriate pull requests to the ticket (and the other once you have worked on), so they will automatically closed when the PR is merged.

Successfully retested


fix: Use new config when creating special notes

This PR:

Fixes issue with journal and scratch note creation configuration still using values from deprecated config location.

related to: #944

Added test for correct behavior


Guzzle 6

Hey Guys - Wondering what it would take to get this package running on Guzzle 6, since that's what Laravel 5.2 is currently loading by default. Thanks!

I think it shouldn't be much of a problem, will do it over the weekend

Thank you! Much appreciated


OpenROAD Main README.md update

It resolves #1953

Thanks, @vijayank88 LGTM. @QuantamHD do you have any feedback on this and can you confirm this meets the criteria to close the issue?

LGTM otherwise! Looks great


Command Authorization Exception

Moving from https://github.com/SpongePowered/SpongeAPI/pull/181 since I'm going to be handling the cleanup.
This is what I was thinking with the changes I wanted made. @Zidane please take a look at the special case for SimpleCommandService.

I think this PR is a bit too coupled to permission nodes -- there may be other reasons for lack of authorization.

I don't see a reason for this to exist anymore.

If this pushes through then its just making permission checks a little bit more work, having to deal with an exception being thrown instead of just a simple if check.

@modwizcode Closing this as you said there isn't much reason for this to exist.
As well, it should be noted that (if I remember correctly) @zml2008 is working on a Commands PR for the near future.


Explosion effect/behavior

Hi there,
I'd like to create a kind of explosive barrel that may impact the surrounding objects.
Can I get such behavior with cannon.js ?
Ty,
G.

This should be pretty easy. I think you'll want to use body.applyImpulse to objects within the radius of the explosion of the barrel - apply a greater impulse to objects which are further away from the barrel (1/radius, maybe?). Calculate the direction of the impulse with something like otherBody.position.subVectors( barrelBody.position). Not sure if it's called subVectors - but just use vector subtraction.
Here is the impulse demo:
https://schteppe.github.io/cannon.js/demos/impulses.html
https://github.com/schteppe/cannon.js/blob/master/demos/impulses.html
Good luck!


Ease NXOntology serialization

Context: I'm currently working on serializing the trained model. Since the feature transformers have learnt state, they also need to be serialized, along with the actual model. I'm currently making sure that all objects whose references are held by feature transformers can be serialized reasonably well. This includes NXOntology (which reference is currently held by PrepareNodeFeatures).
@dhimmel I'd like your input on 2 aspects:

Do we want to serialize the exact version of the ontology when we freeze the feature pipeline?

Cons:

Would make it hard to predict on a version of the ontology which is different than the one trained on

Pros:

Some properties derived of the graph state need to end up serialized (e.g. PCA weights post "fitting")
More robust (e.g. avoid "schema" change issues across versions, training/predict data drift, ...)
The node_info call becomes part of the feature pipeline / coupled

If we do want to serialize the version of the ontology as part of the feature pipeline, are you cool with the approach below? (gist: Instead of saving the whole graph, assume the graph is backed by an immutable url and only save the url).

A quick note: The PR doesn't make use of HostedNXOntology yet, but the idea it to ultimately replace the usage of NXOntology[str] by HostedNXOntology wherever it's serialized.
cc: @ravwojdyla, in case you have opinions.

Do we want to serialize the exact version of the ontology when we freeze the feature pipeline?

In the context of nxontology-data, it is likely that we will store a local file with the nxontology prior to the machine learning. Such that you will read it locally and not from a URL. There's a chance we can just pass it in via memory and only serialize after additional node attributes are added with the predictions. All parts of the ontology that are used to derive features will not be modified.
My intuition would be to not serialize the nxontology here and leave that up to the user. Just serialize the model. Perhaps there is something I am missing.
I don't think its absolutely necessary for all learnt state to be serialized especially if its generation is deterministic. I think the main goal is to be able to inspect models or parameters should questions arise.
If easy to serialize everything, then do it. But don't think we should invest in large amounts of infrastructure to do so if its not straightforward.

Interesting, thanks for your inputs @dhimmel. I guess we should first gain clarity regarding the reasons why want to serialize the model in the first place.

In the context of nxontology-data, it is likely that we will store a local file with the nxontology prior to the machine learning. Such that you will read it locally and not from a URL.

That's good to know!

There's a chance we can just pass it in via memory and only serialize after additional node attributes are added with the predictions. All parts of the ontology that are used to derive features will not be modified.

This would invalidate likely invalidate the serialization assumption made in the PR (unlike relying on a stable url / file path).

My intuition would be to not serialize the nxontology here and leave that up to the user. Just serialize the model. Perhaps there is something I am missing.
I don't think its absolutely necessary for all learnt state to be serialized especially if its generation is deterministic. I think the main goal is to be able to inspect models or parameters should questions arise.

A few observation:

I don't think the learnt parameters for the feature transformers are more deterministic than the model's parameters. (e.g. The vectors used for embeddings are stochastically sampled from BERT (and fitted for PCA), akin to the learnt catboost weights during stochastic gradient descent)
In my mind, the parameters learnt while "training" the feature transformers are logically identical the weights learnt while training the model. (i.e. I don't really understand a scenario where we'd want to save one but not the other)
Even thought the model isn't strictly deterministic, it's likely "epsilon deterministic" (i.e. 2 independent invocations would be very close, within a reasonably small epsilon).
If model inspection is the goal, we could only save training metrics + feature importance instead of all the weights of model + features (that's the approach I took to track experimental results).

If easy to serialize everything, then do it. But don't think we should invest in large amounts of infrastructure to do so if its not straightforward.

Making all feature transformers serializable is not a huge amount of work, but it does make sense to check whether serialize the model + features is really useful in the first place.

How about this: If we aren't sure yet about how/why a serialized model would be actually used, perhaps we should not serialize it for now and wait for an actual use case to pop up?

If we aren't sure yet about how/why a serialized model would be actually used, perhaps we should not serialize it for now and wait for an actual use case to pop up

Sounds good. I'll add a comment at https://github.com/related-sciences/nxontology-ml/issues/35 on what the best next steps are


Update annotation.yml

adding in structure ready to link in TSI anno wfs

@AnnaSyme feel free to change the first subsection title to something else:


Khumbu and other glaciers in the Everest region

I checked the updated outlines for the Khumbu region and tend to disagree with the outlines of the termini. It is clearly very challenging to identify the correct margin of these debris-covered glaciers and I understand the criteria applied by Akiko, but I would add some more parts, in particular for Khumbu.
See the comparison of the outlines I used in Bolch et al. 2011, TC (red) and Sakai (black). The DEM differencing results (e.g. SRTM vs. HMA DEM from King et al. 2019, Sci Rep) show that ice loss would be missed if the outlines from Sakai would be used. As the Khumbu region is well known and these glaciers heavily studied, I think these outlines should be discussed and adjusted for 7.0.

Data received from Tobias. I will need info on imagery and methods to ingest, however.

This is now in RGI7a! Thanks all


"Porting" to Python

I'm interested in making a Skype bridge sort of thing with Python, and as far as I'm aware there are not libraries for the Skype web api for Python (there is one for the old desktop api, but it's getting harder and harder to use).  This makes me evaluate the possibilities of writing my own api wrapper for the web api in Python.
For this I have two questions:

Can I take this code base and use it as a starting point for such a library?  I'm now familiar with how the licensing and rules around that goes, the code itself isn't going to be verbatim copied as Java and Python are quite different.  But it's ideas and solutions to problems certainly will.  Obviously credit will be given.
Am I free to chose whatever license I want if I do this, or would you prefer I'd stick with the same license?  If I'm free to chose I'd go for the MIT license, as I just want something simple and permissive.

Apart from these two issues, do you have any recommendations, or things I should know before starting out with this?

Hello!
Thanks for your interest in this project.
For 1), you can feel free to do so. I think everything is reasonably laid out in Endpoints.java, and what they do can be found by tracing their usages through the API (most of the heavy lifting is done in the internal package). If you have any question feel free to ask.
As for 2), because you are re-writing the API in Python I doubt much code will be copy/pasted.  You are free to use the results of any research I've done under whichever license you like. However if you do end up copy/pasting code (eg maybe you decided to use a Python to Java bridge) then I would appreciate it if you would follow the Apache 2.0 guidelines for the code that you are using.
Apart from those two things, I would say get used to looking at obfuscated JavaScript. The last time I checked the entire JavaScript file is around 2.5MB, so you'll need a pretty hefty text editor for that. Skype also tends to force CAPTCHAs on you when you're experimenting, so be prepared for that too.
Finally, I would like to ask you if you are OK with my using any new things you've discovered along the way. It would save me time as well and everyone gets the best of both worlds.

Thanks for the answers :smile:.
Given that I value collaboration on this, I've decided to use the Apache 2.0 License.  I don't expect anything to be copied between these projects, but who knows what the future will hold.
Shouldn't be to hard to figure that I'm pretty open on sharing solutions, knowledge, and experience building this.  But first, it looks like I've got some works to do.


AttributeError: module 'tensorflow' has no attribute 'compat'

Thank you for working on this new tool! I really enjoyed reading the preprint about it.
I've been working on getting this set up, but keep running into the same error in the title. This error comes up when I try to run the following:
C:\Users\atsi\anaconda3\envs\badgers-cas13\badgers-cas13-main>python design_guides.py diff wgan_am ".\E484K_variant_identification" ".\E484K_test.tsv"
The Traceback is as follows:
Traceback (most recent call last):
File "design_guides.py", line 32, in
from badgers.models.cas13_mult import Cas13Mult
File "C:\Users\atsi\anaconda3\envs\badgers-cas13\badgers-cas13-main\badgers\models\cas13_mult.py", line 5, in
from badgers.utils import cas13_cnn as cas13_cnn
File "C:\Users\atsi\anaconda3\envs\badgers-cas13\badgers-cas13-main\badgers\utils\cas13_cnn.py", line 4, in
from adapt.utils import predict_activity
File "C:\Users\atsi\anaconda3\envs\badgers-cas13\lib\site-packages\adapt\utils\predict_activity.py", line 14, in
tf.compat.v1.logging.set_verbosity(tf.compat.v1.logging.ERROR)
AttributeError: module 'tensorflow' has no attribute 'compat'
I am quite inexperienced with running scripts on using Anaconda Prompt, having only used it previously to use ADAPT and it's related design scripts. Is this a common issue?
I have tried downgrading to TensorFlow 2.3.2 which is the version of the software listed as being compatible with adapt-diagnostics 1.3.0, but then receive a message that I need to upgrade it back to >=2.11 for compatibility with Tensor Probability.
I have followed all directions to create a virtual environment and install dependencies manually using pip and am unsure where the issue lies.

Was able to fix the issue by creating a new environment and doing the following:
pip install tensorflow==2.11.0
pip install flexs==0.2.8
pip install adapt-diagnostics==1.3.0
pip uninstall tensorflow==2.3.2
pip install tensorflow==2.11.0
pip install fastaparser==1.1
pip install matplotlib==3.3.4
I used the following to check that tensorflow was properly installed in between steps:
python
import tensorflow as tf
print(tf.version)
Everything seems to be working now!


[SPARK-9852] Let reduce tasks fetch multiple map output partitions

This makes two changes:

Allow reduce tasks to fetch multiple map output partitions -- this is a pretty small change to HashShuffleFetcher
Move shuffle locality computation out of DAGScheduler and into ShuffledRDD / MapOutputTracker; this was needed because the code in DAGScheduler wouldn't work for RDDs that fetch multiple map output partitions from each reduce task

I also added an AdaptiveSchedulingSuite that creates RDDs depending on multiple map output partitions.

@shivaram, @JoshRosen, @zsxwing this may be relevant to you

Merged build triggered.

Merged build started.

Test build #42739 has started for   PR 8844 at commit f4d2519.

Test build #42739 has finished for   PR 8844 at commit f4d2519.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42739/
Test PASSed.

Alright, I made the suggested changes. I don't think we need to make those classes private[spark] because they are in src/test, right?

Yep, sorry for overlooking that.

Merged build triggered.

Merged build started.

Test build #42917 has started for   PR 8844 at commit 9eac9d6.

Test build #42917 has finished for   PR 8844 at commit 9eac9d6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42917/
Test PASSed.

Merged build finished. Test PASSed.

Alright, let me know if you guys have any other comments.

LGTM

Alright, merged this, thanks.


Specifying what to parse is not working as expected

exifr.parse(file, ['Model', 'FNumber', ...]) still returns the full exif object in react

Hello. Yes :D sorry for the misunderstading. This is the syntax for version 3.0.0. I've been developing it on separate branch and just merged it to master a couple of days ago. But 3 isn't yet publish because I found a few more things to polish. I'm very close to publishing. I think tomorrow because I still want to investigate #12 later today.
For now you can clone this repo, or just comment the ['Model', 'FNumber', ...] and just use exifr.parse(file) because it will work when you upgrade to v3.
thank you

Hi
Cool, no problem thanks for the quick reply. Great library BTW😊
Now that I have your attention…
It would be great if you can consider parsing HEIF also for the new iphones. That is the only thing I’m missing in this great library!
Regards,
Franco
From: Mike<EMAIL_ADDRESS>Sent: Tuesday, 18 February 2020 12:26
To: MikeKovarik/exifr<EMAIL_ADDRESS>Cc: FrancoAucamp<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MikeKovarik/exifr] Specifying what to parse is not working as expected (#17)
Hello. Yes :D sorry for the misunderstading. This is the syntax for version 3.0.0. I've been developing it on separate branch and just merged it to master a couple of days ago. But 3 isn't yet publish because I found a few more things to polish. I'm very close to publishing. I think tomorrow because I still want to investigate #12 https://github.com/MikeKovarik/exifr/issues/12  later today.
For now you can clone this repo, or just comment the ['Model', 'FNumber', ...] and just use exifr.parse(file) because it will work when you upgrade to v3.
thank you
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/MikeKovarik/exifr/issues/17?email_source=notifications&email_token=AOS2ULUQUDH2VZ7TJFLNMD3RDPAVPA5CNFSM4KXCPLL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMBT4TI#issuecomment-587415117 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AOS2ULU6SU4AIN4XSLWISDTRDPAVPANCNFSM4KXCPLLQ .  https://github.com/notifications/beacon/AOS2ULRHK2CV6QP2WCSDJJTRDPAVPA5CNFSM4KXCPLL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMBT4TI.gif

No problem, I'm glad you use it. And I'm actually happy that there's someone using it and wanting to improve it.
Actually HEIC (or HEIF, afaik there's many names for the same thing) support is already done in this v3. There's a src/file-parsers/heic.js for that. And you can try it out right now by going to mutiny.cz/exifr/. It's hosted directly from github's master so it already runs v3 with HEIC. You can just drag and drop your files there to see if it works. Or let me know and send the photos that don't. I would write fix around them and add write tests for them.


Support more than 5 SecurityGroups on one CRD

Issue #, if available:
Modify the maxitems in SecurityGroups.
According to "Amazon VPC Quotas," it should be able to use up to 16.
One CRD must support at least 10 security groups
If I need more than 5 security groups, it's hard to manage
because I need more than one crd. I don't know why one crd doesn't support more than 10 security groups
Description of changes:
We need to use more than 10 security groups.
Increase the maxitems to the maximum number of allowable (16), and modify the descritions and README.
https://docs.aws.amazon.com/vpc/latest/userguide/amazon-vpc-limits.html#vpc-limits-security-groups
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The default number of security groups per Network Interface is 5. Updating the MaxItems=16 could lead to customers erroneously adding more than 5 SGs in the security group policy prior to increasing the service quota.
The recommended way is to define more than 1 security group if you need more than 5 SGs to be specified, as documented in the README.
Can you help me understand if any issues with multiple CRDs? We understand this is harder to manage than 1 CRD, but hopefully it is a one-time setup effort for SGP CRDs.

If I apply it without increasing the qutos, won't it be rejected by the vpc qutos anyway?

I need to check on this.

Is there any advantage to enforcing this through maxitems?

Yeah, as mentioned before this avoids customers from specifying more than the default number(5) of security groups in the CRD.

how about making it possible to dynamically modify maxitems?

Hm, this might be possible if we set maxItems in CRD based on the service quota value. Let me see if it is feasible.

@sushrk
How about using servicequotas to look up the vpc service qutos(securitygroup) value to set maxitems when vpc cni is deployed?
Let me see if it is feasible too.

We would love this feature also. We have increased service quotas and currently rely on a fork of the VPC RC to get around this

@sushrk
Hi!
How's it going? I'm curious because I haven't seen any updates.

Sorry for the late reply. Thinking about this, it makes sense to me to set the maxItems to absolute maximum of 16 in CRD definition and internally check that the number of SGs specified is lower than the service quota value at CRD creation.
We'd need to document this more clearly though, especially when customers want to lower their quota so it does not break existing workloads.
I'll need to confirm the customer experience with PM, will post an update tomorrow.
@changhyuni are you planning to add the support for this?

@sushrk
Hi. Thank you for your comment.
I think I can create a webhook to check the number of security groups in the CRD.
What do you think? I'v tried to make webhook and will add test code soon.
Can I use the aws-go-sdk-v2? I looked at your other code and it doesn't seem to use it.

I think I can create a webhook to check the number of security groups in the CRD.

Can you explain why we are adding a webhook to check the number of SGs? Does this validate the CRD at creation/update/both?
Also, we need to handle the case where more than one SGP CRD can be applied to a pod, probably will not be sufficient to validate individual CRD objects. We should add this validation at pod creation.

Can I use the aws-go-sdk-v2? I looked at your other code and it doesn't seem to use it, it uses an api package.

We use aws-go-sdk for EC2 operations, but through a wrapper and helper functions.

@sushrk
Hi I had some time and made a few additions.
Created an API via ec2 wrapper and added logic to validate on pod webhooks

@sushrk
Could you check this out when you have a time?

We need avoid adding upstream service support check in pod mutating webhook. The webhook need to be light and respond quickly. Always calling upstream API will be more and more expensive for most of users who don't have the need to support more than 5 security groups. Since users should be aware that their service quotas before applying the setting to the CRD, I think fail a pod creation and send a pod event as a message should be good enough.

@haouc
Hi. Thanks you for comment I agree that API calls increase
I'll remove the pod webhook, so could you merge the crd settings change for the 16 maxitems?

@haouc @sushrk
Hi
If you have time could you check this?

@haouc
Hello, How is the requirement coming along?
I'd like to assist if possible. How can I make any necessary changes?


Replacing bus functionality with nuget package

Bus functionality is moved to the service bus solution. Now only using this nuget package instead for make sure the same functionality can be used in all solutions.
Also encapsulation the Message object inside the nuget package, so no we rather only work with seraliazed json instead of Mesasge objects.

Failing pipeline.
Reviewing when fixed

Pipeline working now! Please review


Release 0.1.4

Would it be possible to release version 0.1.4 with the recent (streaming) changes? This would allow me to remove a vendored dependency on the repo in my internet of streams project.

Yep! Done.


change market get data time interval

Hi. Thanks for this awesome project!
Is there any way to change the interval of when market data is pulled, say from Bittrex?
I was looking for something like getting json data say every 1 or 5 min.
Thanks!

Thanks for that :)
Currently it is not supported but will enhance it in the future. Will keep you posted on the changes.

What would happen if I inserted a sleep statement in bitcoinexchangefh.py, which appears to have something to do with running the subscriptions window, with pulling the market data down? I'm wondering if this would possibly slow it down some? Thanks for your insight!

The sleep occurs on each thread (or exchange).
For example, it sleeps between each call of getting the depth and the trades.

Understood. Thank you for the quick update and info!


Different mypy output from ci and pre-commit

Describe the bug
mypy check on CI is passing, while mypy check in precommit hook is failing
To Reproduce

checkout develop
pre-commit run -a (setup pre-commit if not already)

Expected behavior
pre-commit hook and CI are running mypy in same way
Additional context
Add any other context about the problem here.

In the CI the mypy won't be executed.

No, this is not the reason as requirements.txt is generated using pip-compile pip-compile --all-extras --output-file=ci/requirements.txt pyproject.toml.
Same pacakges will be installed if you install using pip based on pyproject.toml pip install .[dev,doc] which is what I do.


Queue Trigger Bash Function

Add output to Blob. If impossible let's remove the template. Make sure we have parameter name.
rename trigger queue to "samples-workitems"

We can do this, but we're trying to keep these simple. We'll be adding additional templates in the Next milestone and we'll do this across the languages.


Embedded functions do not load model weights

Dear developer,
First of all, thank you for your amazing job. It is a wonderful net.
While I was using MedViT, I noticed that it does not load weights. There is the code from medvit.py:
@register_model
def MedViT_small(pretrained=False, pretrained_cfg=None, **kwargs):
model = MedViT(stem_chs=[64, 32, 64], depths=[3, 4, 10, 3], path_dropout=0.1, **kwargs)
return model
@register_model
def MedViT_base(pretrained=False, pretrained_cfg=None, **kwargs):
model = MedViT(stem_chs=[64, 32, 64], depths=[3, 4, 20, 3], path_dropout=0.2, **kwargs)
return model
@register_model
def MedViT_large(pretrained=False, pretrained_cfg=None, **kwargs):
model = MedViT(stem_chs=[64, 32, 64], depths=[3, 4, 30, 3], path_dropout=0.2, **kwargs)
return model
I presume that  it should be something like that:
@register_model
def MedViT_large(pretrained=False, pretrained_cfg=None, **kwargs):
model = MedViT(stem_chs=[64, 32, 64], depths=[3, 4, 30, 3], path_dropout=0.2, **kwargs)
if pretrained is True:
model.load_state_dict(torch.load(pretrained_cfg, weights_only=True)['model'])
return model
One more time, thank you for your great job!

Hi,
1- To use pre-train weights, follow the stracture of this repo : https://github.com/Omid-Nejati/MedViT/blob/main/CustomDataset.md
2- Download pre-train from the table based on model size.
3- Address the location of pre-train weights in this code for finetune :
cd CustomDataset/
"bash train.sh 8 --model MedViT_small --batch-size 30 --lr 5e-6 --warmup-epochs 0 --weight-decay 1e-8 --epochs 30 --sched step --decay-epochs 60 --input-size 384 --resume ../checkpoints/MedViT_small_im1k.pth --finetune --data-path your_data_path "

Hi!
Please, take a look on the code, it does not load pretrained weights:
Line 515 of the file MedViT.py:
CODE*************************
def MedViT_large(pretrained=False, pretrained_cfg=None, kwargs):
model = MedViT(stem_chs=[64, 32, 64], depths=[3, 4, 30, 3], path_dropout=0.2, kwargs)
return model
END OF CODE**************
it takes a file with the pretrained weights, but it does nothing with it. The same is true for MedViT_large and MedViT_base.

Thanks for your comment. We have updated the code and fixed errors about pre-train loading.
A simple colab file for medvit-large is attached.
CIFAR100.zip

Thanks for your comment. We have updated the code and fixed errors about pre-train loading. A simple colab file for medvit-large is attached.
CIFAR100.zip
Hi, I think what AlKukharskii means is that in the code, the function defined for creating the model has a parameter called pretrained which is not actually used, as shown in the diagram.

Additionally, I noticed that you have placed the loading of training weights in main.py, and specified that it should only occur when args.resume=True. This makes the overall structure seem a bit odd, or rather different from the usual steps of handling.

Fixed in PR #14


added pfp

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Filename test is not passed. Change your filename to your username as in 404Nikhil.json

done


refactor(interval): extract and reuse _sizeAbsShift getter

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
445

Relevant Lines:
445

💛  - Coveralls


TBC: Add voter ID card registration date

There is a chance that before May 2023 Voter ID cards will be introduced for some UK elections.
Voter ID will be in the form of existing IDs that might be held by would be voters, but there is provision for voters to apply for a special voter ID document.
The provisional deadline to apply for this document will be  working days before the poll.
There is no work to be done on this just yet, as the plans aren't implemented. We will need to add this deadline to the library if / when it does happen.

Relates to https://github.com/DemocracyClub/EveryElection/issues/1729. Not all elections will require voter ID. This library shouldn't worry about that in the case of local elections, but shouldn't return voter ID deadlines for elections that never require voter ID

@pmk01 do we know the timetable for this yet? Something tells me it's 10 working days?

Ahead of a specific election, referendum, or recall petition, the deadline for application will be 5pm, 6 working days before either the date of the poll or the last day for signing the petition.
If you apply for a Voter Authority Certificate after this date, you will not be able to use your Voter Authority Certificate at that poll or recall petition.
Source: https://www.electoralcommission.org.uk/media/5535

Splendid, thanks!


emitter: invalid behavior deferring when the surrounding function has named result

Source code
package main

import (
        "fmt"
)

func f() (err error) {
        defer func() {
                _ = recover()
        }()
        var i int
        _ = 1 / i
        return nil
}

func main() {
        fmt.Println(f())
}

Scriggo output
runtime error: integer divide by zero

gc output
<nil>

Another version of this issue:
Source code
package main

import (
        "fmt"
)

func s() []int { return []int{} }

func f() (err error) {
        defer func() {
                _ = recover()
                _ = s()
        }()
        var i int
        _ = 1 / i
        return nil
}

func main() {
        fmt.Println(f())
}

Scriggo output
[]

gc output
<nil>

First problem
The problem of uninitialized registers may be solved by adding this code to prepareFunctionBodyParameters.
// Reserve space for the return parameters and eventually bind them.
for _, out := range fn.Type.Result {
	t := em.typ(out.Type)
	kind := t.Kind()
	reg := em.fb.newRegister(kind)
	if out.Ident != nil && !isBlankIdentifier(out.Ident) {
		em.fb.bindVarReg(out.Ident.Name, reg)
	}
	switch kindToType(kind) {
	case intRegister:
		index := em.fb.makeIntValue(0)
		em.fb.emitLoad(index, reg, kind)
	case floatRegister:
		index := em.fb.makeFloatValue(0)
		em.fb.emitLoad(index, reg, kind)
	case stringRegister:
		index := em.fb.makeStringValue("")
		em.fb.emitLoad(int(index), reg, kind)
	case generalRegister:
		index := em.fb.makeGeneralValue(reflect.Zero(t))
		em.fb.emitLoad(int(index), reg, kind)
	}
}

Second problem (just an optimization)
The code above should be executed only if the function has at least one defer statement in it; otherwise, it's useful. This information may be returned by the type checker.
Third problem
Even implementing the above changes, the problem continues to arise with some tests. This appears to be caused by something wrong in the emission of the statement defer; perhaps it is related to stack shift.

@gazerro
The linked PR fixes the problem of registers initialization, but still remains something related to the defer statement.
This code shows the invalid behaviour:
package main

import (
	"fmt"
)

func f() interface{} {
	defer func() {
		_ = []int{}
		recover()
	}()
	panic(0)
}

func main() {
	fmt.Println(f())
}

It should print <nil> but it prints [] instead; this is probably caused by the deferred function that writes the []int value on a register owned by the f function.


Antlr 4.10 upgrade

@hs-apotell, third_party/antlr contains your RTTI changes, the latest Antlr is supposed to fix the same + some other speedup
I tried to merge, but failed, I already updated alainmarcel/antlr and I put the new .jar file there.
Please update the third_party/antlr, once that is done I'll remove the fast_antlr and we can use the regular antlr.
We can also get rid of the indirection to alainmarcel/antlr and simply put antlr as a subsystem.
We can put the .ar  file under third_part/antlr_comp/

We can also get rid of the indirection to alainmarcel/antlr and simply put https://github.com/antlr/antlr4 as a subsystem.

We cannot have a clone of antlr within Surelog because we use antlr for other parsing in our tool and that creates a conflict. Locally in our fork of Surelog we don't use antlr_fast for that reason. We will have to use a forked version of antlr and that would be a submodule (not a subsystem).
Also, I would recommend transferring the ownership of alainmarcel/antlr to chipsalliance. It won't break anything at the moment since nobody is referencing it.
Ping me back when that's done (or if you don't wish to transfer) and I shall follow up with the merge.

The goal is to use upstream antlr, so any submodule will just point to there (and the submodule is just for the convenience of the people who don't want to install a local antlr)
We also don't use the Surelog antlr but just link against our local copy of upstream and then link Surelog against that which works well (which is why it is extra exciting to now use that upstream with is already faster than Alains' branch).
I think the alainmarcel/antlr was once considered to put to chipsalliance, but it is somewhat outside the scope of chipsalliance so was not accepted. If we all just use the upstream version of Antlr, things will get simpler (also, I am currently involved in getting some patches into Antlr, so there is more continued effort into getting things faster and even less RTTI'ed).

The goal is to use upstream antlr, so any submodule will just point to there (and the submodule is just for the convenience of the people who don't want to install a local antlr)

Using antlr/antlr4 with no modifications is even better. I interpreted @alaindargelas comment as going back to what used to be a local copy of antlr modified for use with Surelog only.
If the plan is to use pristine antlr/antlr4 then what's there to merge? We just need to update the entry in .gitmodule to pull the relevant repository and we should be done. What am I missing??

Exactly: changing .gitmodule to the upstream antlr and then have one directory with the pre-generated jar file (as that otherwise would require a whole lot more dependencies with maven and stuff).

@hs-apotell, please submit the PR with the updated .gitmodule, .jar saved under Surelog/third_party/antlr_comp/antlr4-4.10.1-complete.jar and the changes to the Cmake to point to that by default, also remove the antlr_fast directory.

Running into number of issues -

antlr4 binaries available for download require java11 runtime. Previous version needed java8. The two versions are vastly different and there is no jre11 installation available for Windows.
Cpp runtime on Windows has compile errors.
https://github.com/antlr/antlr4/blob/ae1bf405f0071ad06dc7fc3105d074aad1130135/runtime/Cpp/runtime/src/ANTLRFileStream.cpp#L17
There is no function antlrcpp::s2ws. It was deprecated.
Cpp runtime doesn't support multi-configuration builds because it copies the output to <root>/dist folder. User has to manually go and delete the old library for build to succeed every time configuration is changed. This was fixed in the forked repository.
Generated lib and pdb files are named differently and debugger doesn't find the symbol file when debugging.

The antlrcpp::s2ws should now be fixed at head.

@hs-apotell Java 11+ based apps no longer require a JRE installation. Java 11 based apps are supposed to bundle a java implementation into their binary
https://stackoverflow.com/questions/52584888/how-to-use-jdk-without-jre-in-java-11#:~:text=Oracle no longer intends for,bundle their own Java implementation.

The antlrcpp::s2ws should now be fixed at head.

Are we pulling in latest or staying with a release commit? I would recommend a release commit but that would mean waiting until the next release.
@hzeller @QuantamHD As for the Java releated concern - it seems that CMake picks Java 8 over Java 11, especially if there is no version specification required or only the Runtime is requested. Will need some time to test this and find a working solution.
There are still two other issues that are not even reported. I will open related bugs and possibly submit a PR too for antlr4 repository.

I would track head of antlr4. The development stuff happens in their dev branch, so head is essentially the stable release (including minor fixes they added now). So no need to wait for the next release.
Can we CMake tell to use Java11 ? It sounds like a thing that some CMAKE variable will fix.

Can we CMake tell to use Java11 ? It sounds like a thing that some CMAKE variable will fix.

Yes, that's what I was doing or at least I thought I was doing. I modified the CMakeLists.txt and set the recommended JAVA_HOME variable. CMake still wouldn't pick the correct Java version (I have multiple version installed on my system). As it turns out, JAVA_HOME needs to be set as environment variable only. Passing it to CMake as a variable assignment i.e. -D option doesn't work. With that resolved, the below is the only blocker.
https://github.com/antlr/antlr4/pull/3663
Hopefully, this will get merged soon.

Looks like https://github.com/antlr/antlr4/pull/3663 is merged.

Yes. I am off work this week. Will work on this following Monday.

https://github.com/antlr/antlr4/pull/3663 isn't merged into master yet. Do you want to track a specific commit for now??

Fixed by #2886


Parse Flex identifiers

Flex is a new type of document published by BSI, which is like a PAS but with faster production.
The identifier pattern has two differences:

Can include a version (edition) number
Can provide the month

BSI Flex 0 v2.0:2022-08
BSI Flex 1889 v1.0:2022-07
BSI Flex 8670 v3.0:2021-04
Flex 0:2022
Flex 1889
Flex 1890
Flex 5555
Flex 8670 v3.0:2021-04
Flex 8670:2021
Flex 8670:2021-04

@ronaldtse I see two patterns for prefix here:
"BSI Flex" and "Flex". Which one I should follow for the output?

I believe we should use "BSI Flex" and "BSI PAS". Can you also document this in the README? Thanks.

I believe we should use "BSI Flex" and "BSI PAS". The rest of the document types can be as they are, i.e. "BS", "PD", etc. Can you also document this in the README? Thanks.

@ronaldtse Do you mean:

BSI Flex 123
BSI PAS 123

But:

BS 123
PD 123

Did I get it right?

Yes that’s correct. Because outside of BSI documents, a “BS xxx” is still called a “BS xxx”, not a “BSI BS xxx”. But a Flex and PAS will have the prefix of “BSI” in front.


Updating website

Hi everyone. This is a thread where you can come with all your suggestions for updates to the website.
Maybe we can discuss the list at the planning meeting in December and hopefully assign some people to update different things or add new content to the website.
Also, please look at some of the other issues on under the tab "issues". There are already a lot of good ideas for the website.

Here are my notes:
Question: How are the common docs working thus far? Are people using the website?

Onboarding

Buddy system – is it working?
Update information in table with Maria – new stuff since moved to Forum
Could we have a whole section on going to conferences – what are the basic steps – tips for planning which conferences to go to, how to arrange the trip, how to do expenses, getting the most out of a conference, making a poster, giving a talk, printing the poster etc.? – could we make a calendar of the conferences we plan to go to during the year – things we plan during the yearly meeting?
Could we have like a year-wheel with central activities at SDCA for researchers?
Do we need to mention the typical setup by either being employed by the Region vs AU?
Update parking info
Journal clubs – could we have an epi methods journal club?
Need table for PhD students

Support
Data analysis tips and help

Put the figure about help in the top
Add more explanatory text
What about rules re data safety – at least put a link to relevant courses and rules we follow
Various data sources
Add UK Biobank

Organization

Research groups – are they still the same?
There could be more info about us – at least our different research areas

Lots have changed since this issue, will close for now.


Issues registering device over raw WebSocket

I was transferring some older Socket.io code over to the newer raw WS interface and hit some 401 errors when trying to register:

var ws = new WebSocket("wss://meshblu.octoblu.com/ws/v2");

ws.onopen = function() {
  ws.send(
      JSON.stringify(["register", {}])
      );
};

ws.onmessage = function(e) { console.dir(e.data); };

The following code snippet will return:
["error",{"message":"unauthorized","frame":["register",{}],"status":401}]

Did I do something wrong while registering or is this an internal issue? The code above is more or less a copy/paste job from the documentation, so I wasn't sure.
ADDITIONAL INFO: The snippet above does not appear to emit a "ready" event. Even if I just connect.

Fixed in 5a12501


Chart editor crash fix involving events.

This pull requests goal is to help save a few charts or annoying crashes by getting rid of a bug that may not be too hard to run into.
The bug in question is a Null Object Reference that causes the game to crash immediately due to a small oversight.
How to activate the bug:

Step 1: Open the latest version of Psych Engine.
Step 2: Hit 7 on the menu or enter a free play song.
Step 3: Enter the chart editor. (Option in menu, 7 in free play)
Step 4: Place an event randomly. It doesn't need any data, but you can add it if you wish.
Step 5: Place a note randomly. It doesn't matter what note, just anything but an event.
Step 6: Type inside of "Value 1" or "Value 2" in the event tab. This will cause the game to crash.

The cause:

A small oversight on this line and this other line of ChartingState.hx.

Changes in the pull request to fix the issue:

A bool that checks for nullified values of curSelectedNote[1] and curSelectedNote[1][curEventSelected].

happened to me once after charting a five minute song and forgot to save hope this gets merged

whoops, i tried to rename the branch

note to self, don't rename a branch

happened to me once after charting a five minute song and forgot to save hope this gets merged

Load Autosave is a thing.