Benchmarks

Added bazel run benchmark:time and bazel run benchmark:memory commands that profile the code with scalene and memory_profiler respectively. Example results from each:

Didn't manage to make Scalene report memory:

if running scalene directly in poetry env, C++ extensions aren't available
both if running through bazel run or inside bazel-bin/benchmarks/run.runfiles/temporian/benchmarks C++ extensions are built and available, but memory isn't reported

This is a first draft and only integrates the tools and commands to benchmark.
TODO:

[ ] Make this as easy to use as possible for new scripts
[ ] Enable easily specifying a size for the test (e.g. bazel run benchmark:time -- N=10000 to choose size of input events)
[ ] Swap example data for random generated data
[ ] Enable plotting memory consumption over time instead of line-by-line consumption

It seems the benchmark can run well with sh_binary (instead of py_binary). However, event in this case, scalene is not reporting memory usage. Maybe this is another issue?
See https://github.com/google/temporian/blob/gbm_benchmark/benchmarks/BUILD
Running: bazel run benchmarks:run in branch gbm_benchmark.

See https://github.com/google/temporian/blob/gbm_benchmark/benchmarks/BUILD

Thanks for the help @achoum! Merged your work into this branch.
Managed to do something similar by running scalene in bazel-bin/benchmarks/run.runfiles/temporian/benchmarks but memory isn't reported either, integrated a new tool.


i3-back: init at 0.3.2

Add i3-back, a i3/Sway utility to go back to the last focused window. Link: https://github.com/Cretezy/i3-back

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/2011


Nitro android 4.2.1

What to do if the build fails?
At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.
New Pull Request Checklist
Please mark the points which you did / accept.

[x] I will not move an already shared step version's tag to another commit
[x] I read the Step Development Guideline
[x] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[x] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[x] I read and accept the Abandoned Step policy

New Step
Thank you for the new Step share! The CI check might will fail due to our extended validation engine. Nothing to worry about yet, we will get back to you shortly.

@gaguirre this PR seems to contain two new versions. One steplib PR is supposed to contain only one, can you please recreate the PR to only contain one? It seems that the next version should be 4.2.0

Hi @ofalvai
Sure, I'll remove the 4.2.0 folder and keep the 4.2.1 version since I've made some changes and I'd prefer not to rollback them. Let me know if that's ok.

Also, I just noticed the icon is in the wrong folder. I'll fix that too and push again.
Thanks for reviewing.

This is not ideal, but it will be fine I think. There will be one skipped version number in the step library, but that's all.

I just pushed the changes. Let me know if there is anything else I should do.

Hi @ofalvai, is there anything else I should do from my side?
I've opened another PR for the iOS step. Since they have different inputs we decided to have separate steps, so we can be more explicit on which parameters are required and which ones optional.

Hi @ofalvai, I'm working on a tutorial on how to use Nitro with Bitrise and it would be great for me if this PR is merged, so I can finish and publish it.
Thanks in advance!


chore: convert APIs to TS

Describe your changes
Converts the files in the API directory into TS
Issue ticket number and link
N/A
Motivation and Context
Start using TS throughout the entire project.
How Has This Been Tested?
Locally ran tests.
Screenshots (if appropriate):
N/A

closing this because it's been addressed in another PR!


Use Indicators in Flow

Similar to #63 let's start with a simple Component for showing one Indicator in a Flow. Pass in the CMDT Name for the Indicator, and show one Indicator.

OK I've given up on this for now... I was able to create a simple indicator that was not record aware... that worked, but it defeats the purpose of the CMDT setup completely. I tried to make the Bundle Flow Aware but I could not work out how to get the recordId from the Flow into the Apex. So I'm not sure of the value of this at all now, so I'm putting it to future and discussion.

I would like to we explore use of APEX Invocable method for this approach.

An idea that has come to me is if we design a version that instead of using the component's record context, we can create a special version for a Flow that creates either:

Dynamic SOQL to retrieve the data it needs using just a record id to render the Indicators.
Accepts a record variable and can the render the Indicators.

It would of course need other inputs, such as the Bundle itself.

Note: Tim has done part of this and has produced a video showing where he got to.


Support Python 3

I ran 2to3 on the code, and this works for me using Python 3.4.

Python 3 support has been added in #43.


SystemStackError during destroy with ActiveStorage 5.2

When using both acts_as_paranoid and ActiveStorage on the same model, destroying the model causes a SystemStackError as the stack overflows with lots of nested callbacks around ActiveStorage::Attachment purging.
As a minimum this error shouldn't occur, but some fuller support for soft deletion with ActiveStorage would be great, allowing for the attachment+blob to remain until really deleted.
Here's a simple test application showing the error: https://github.com/domcleal/acts_as_paranoid_with_activestorage
With this model:
class Post < ApplicationRecord
  acts_as_paranoid
  has_one_attached :file
end

Example stack trace:
    activestorage (5.2.0) app/models/active_storage/attachment.rb:28:in `purge_later'
    activestorage (5.2.0) lib/active_storage/attached/one.rb:67:in `purge_later'
    activestorage (5.2.0) lib/active_storage/attached/macros.rb:47:in `block in has_one_attached'
    activesupport (5.2.0) lib/active_support/callbacks.rb:426:in `instance_exec'
    activesupport (5.2.0) lib/active_support/callbacks.rb:426:in `block in make_lambda'
    activesupport (5.2.0) lib/active_support/callbacks.rb:261:in `block in conditional'
    activesupport (5.2.0) lib/active_support/callbacks.rb:517:in `block in invoke_after'
    activesupport (5.2.0) lib/active_support/callbacks.rb:517:in `each'
    activesupport (5.2.0) lib/active_support/callbacks.rb:517:in `invoke_after'
    activesupport (5.2.0) lib/active_support/callbacks.rb:133:in `run_callbacks'
    activesupport (5.2.0) lib/active_support/callbacks.rb:816:in `_run_commit_callbacks'
    activerecord (5.2.0) lib/active_record/transactions.rb:345:in `committed!'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:119:in `commit_records'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:214:in `block in commit_transaction'
    /home/dominic/.rvm/rubies/ruby-2.5.0/lib/ruby/2.5.0/monitor.rb:226:in `mon_synchronize'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:204:in `commit_transaction'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:243:in `block in within_new_transaction'
    /home/dominic/.rvm/rubies/ruby-2.5.0/lib/ruby/2.5.0/monitor.rb:226:in `mon_synchronize'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:227:in `within_new_transaction'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/database_statements.rb:254:in `transaction'
    activerecord (5.2.0) lib/active_record/transactions.rb:212:in `transaction'
    activerecord (5.2.0) lib/active_record/transactions.rb:383:in `with_transaction_returning_status'
    activerecord (5.2.0) lib/active_record/transactions.rb:305:in `destroy'
    activestorage (5.2.0) app/models/active_storage/attachment.rb:28:in `purge_later'
    activestorage (5.2.0) lib/active_storage/attached/one.rb:67:in `purge_later'
    activestorage (5.2.0) lib/active_storage/attached/macros.rb:47:in `block in has_one_attached'
    activesupport (5.2.0) lib/active_support/callbacks.rb:426:in `instance_exec'
    activesupport (5.2.0) lib/active_support/callbacks.rb:426:in `block in make_lambda'
    activesupport (5.2.0) lib/active_support/callbacks.rb:261:in `block in conditional'
    activesupport (5.2.0) lib/active_support/callbacks.rb:517:in `block in invoke_after'
    activesupport (5.2.0) lib/active_support/callbacks.rb:517:in `each'
    activesupport (5.2.0) lib/active_support/callbacks.rb:517:in `invoke_after'
    activesupport (5.2.0) lib/active_support/callbacks.rb:133:in `run_callbacks'
    activesupport (5.2.0) lib/active_support/callbacks.rb:816:in `_run_commit_callbacks'
    activerecord (5.2.0) lib/active_record/transactions.rb:345:in `committed!'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:119:in `commit_records'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:214:in `block in commit_transaction'
    /home/dominic/.rvm/rubies/ruby-2.5.0/lib/ruby/2.5.0/monitor.rb:226:in `mon_synchronize'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:204:in `commit_transaction'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:243:in `block in within_new_transaction'
    /home/dominic/.rvm/rubies/ruby-2.5.0/lib/ruby/2.5.0/monitor.rb:226:in `mon_synchronize'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:227:in `within_new_transaction'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/database_statements.rb:254:in `transaction'
    activerecord (5.2.0) lib/active_record/transactions.rb:212:in `transaction'
    activerecord (5.2.0) lib/active_record/transactions.rb:383:in `with_transaction_returning_status'
    activerecord (5.2.0) lib/active_record/transactions.rb:305:in `destroy'
    activestorage (5.2.0) app/models/active_storage/attachment.rb:28:in `purge_later'
    activestorage (5.2.0) lib/active_storage/attached/one.rb:67:in `purge_later'
    activestorage (5.2.0) lib/active_storage/attached/macros.rb:47:in `block in has_one_attached'
    activesupport (5.2.0) lib/active_support/callbacks.rb:426:in `instance_exec'
    activesupport (5.2.0) lib/active_support/callbacks.rb:426:in `block in make_lambda'
    activesupport (5.2.0) lib/active_support/callbacks.rb:261:in `block in conditional'
    activesupport (5.2.0) lib/active_support/callbacks.rb:517:in `block in invoke_after'
    activesupport (5.2.0) lib/active_support/callbacks.rb:517:in `each'
    activesupport (5.2.0) lib/active_support/callbacks.rb:517:in `invoke_after'
    activesupport (5.2.0) lib/active_support/callbacks.rb:133:in `run_callbacks'
    activesupport (5.2.0) lib/active_support/callbacks.rb:816:in `_run_commit_callbacks'
    activerecord (5.2.0) lib/active_record/transactions.rb:345:in `committed!'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:119:in `commit_records'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:214:in `block in commit_transaction'
    /home/dominic/.rvm/rubies/ruby-2.5.0/lib/ruby/2.5.0/monitor.rb:226:in `mon_synchronize'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:204:in `commit_transaction'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:243:in `block in within_new_transaction'
    /home/dominic/.rvm/rubies/ruby-2.5.0/lib/ruby/2.5.0/monitor.rb:226:in `mon_synchronize'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/transaction.rb:227:in `within_new_transaction'
    activerecord (5.2.0) lib/active_record/connection_adapters/abstract/database_statements.rb:254:in `transaction'
    activerecord (5.2.0) lib/active_record/transactions.rb:212:in `transaction'
    activerecord (5.2.0) lib/active_record/transactions.rb:383:in `with_transaction_returning_status'
    /home/dominic/.rvm/gems/ruby-2.5.0/bundler/gems/acts_as_paranoid-a86ee2c5350b/lib/acts_as_paranoid/core.rb:122:in `destroy!'
    test/models/post_test.rb:9:in `block in <class:PostTest>'

What's the status of this issue? Is there any temporary fix? I'm having issues with it and unable to use acts_as_paranoid with active storage

I am facing the same issue. How to deal with it?

Any resolution on how to soft delete without performing the purge callback until it is fully destroyed?

Any updates on this?

Yeah, would love to use this gem, but don't want to purge the documents

Any updated on this?

So I've got a possible solution that seems to work. I would appreciate any feedback as it doesn't feel particularly solid.
In my app Employees have files and I want to be able to archive the employee, then get their files back when restoring the Employee record.
#/models/employee.rb
class Employee < ApplicationRecord
acts_as_paranoid

def destroy
    @employee = Employee.find(params[:id])

    #create a temporary employee to attach all files too.
    @temp_employee = Employee.new(name:"temp", position: "temp")

    #attach each of the original employee's files to the temp employee
    @employee.files.each do |f|
      @temp_employee.files.attach(f.blob)
    end

    #soft delete the employee
    @employee.destroy

    #re-attach all the files back
    @temp_employee.files.each do |n|
      @employee.files.attach(n.blob)
    end

    @employee.save!
   #employee is soft deleted, and the files are attached to the record
  end
end

Hello folks, is this issue got resolved or not yet ?

@navidemad as far as I know this is still a problem.

I have a test with ActiveStorage in my PR #108 and it seems that the crash is not there anymore. It looks like it got solved by itself with Rails 6.0. Maybe there is another way to trigger this problem but my test does not cover it.
However, the attachments and the blobs are still lost so this is not a soft deletion yet.

So I've got a possible solution that seems to work. I would appreciate any feedback as it doesn't feel particularly solid.
In my app Employees have files and I want to be able to archive the employee, then get their files back when restoring the Employee record.
#/models/employee.rb
class Employee < ApplicationRecord
acts_as_paranoid

def destroy
    @employee = Employee.find(params[:id])

    #create a temporary employee object to attach all files to.
    @temp_employee = Employee.new(name:"temp", position: "temp")

    #attach each of the original employee's files to the temp employee
    @employee.files.each do |f|
      @temp_employee.files.attach(f.blob)
    end

    #soft delete the employee
    @employee.destroy

    #re-attach all the files back
    @temp_employee.files.each do |n|
      @employee.files.attach(n.blob)
    end

    @employee.save!
   #employee is soft deleted, and the files are attached to the record
end
end

UPDATE: as I extended this it got increasingly complicated and I ended up switching to discard instead as it seems more suited to this use case.

@jonsinclair1 How did you manage to save employee? I get an error when I try to save the soft-deleted record.

It's a workaround, but you could consider moving the file upload to a separate model that is not soft-deleted. I haven't tested this, though.
class Employee
  has_one :file_upload   # don't use a `dependent` option

  has_many :tasks, dependent: :destroy
end

class FileUpload
  has_one_attached :file
  belongs_to :employee
end

employee.destroy #=> soft-deletes tasks, keeps file_upload around


Example involving uniform/storage buffers for compute shaders

How can Bevy's documentation be improved?
Especially since the ergonomics improvements around materials such as deriving AsBindGroup, it has become quite unclear how to create and use buffers in other cases. A very reasonable place to use them I think would be compute shaders. It would be great to add an example (or perhaps extent the game of life example, although not if that makes sense) that shows how to create, update, and bind buffers to a compute dispatch.
Opening this issue was also the idea of @superdump

#5843 was created to track this and there's already #5925 as the first example made for that. Feel free to add a comment on that issue if you think something is missing.

Closing to track this in #5843 :) Thanks though!


All Azure components should support Managed Identity auth

Currently all secret stores and by extension other components require some kind of in cluster secrets. It would be great if it would be possible to use Azure Manage Service Identity where possible.
Currently I see following possible places to use MSI:

keyvault secret store
cosmos db binding
blobstorage binding
eventhub binding
servicebus binding
azureservicebus pub/sub
cosmos db state store

Especially keyvault… is a MUST have. Otherwise this secret store makes no sense.

@mkosieradzki there's already a PR for it: https://github.com/dapr/components-contrib/pull/185

Managed Identity for authenticating with KeyVault is done. @skwasiborski can you describe the scenarios more for the other bindings?

All Azure components should support managed identities. The behavior should be a simple useManagedIdentity:true component spec option that tells the binding to init with the managed credential from the underlying platform instead of connectionStrings. This behavior should work on Azure Kubernetes Service using either cluster identity or pod identity.
For self-hosted Azure VM machines it should use https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/tutorial-windows-vm-ua-arm
Not sure if Go supports it, but in dotnet you can also prompt for user credentials and use that token if you're running locally and want to debug against an Azure Resource without a connection string.

I've been meaning to add this for Azure Service Bus PubSub - I will open a separate issue and PR next week.

@dapr/maintainers-components-contrib can you please triage this so it's not closed

I see this has been closed. For our project the ability to use MSI to access the Cosmos State (and Actor state) stores, and ServiceBus as critical to out continued use of Dapr. Would it help for me to split these out into separate issues or can this be reopened?

@dapr/maintainers-components-contrib can you please triage this so it's not closed

@dapr/maintainers-components-contrib

This issue is still closed but it is still applicable as far as I can tell. This is a much desired feature for my team & organization (azure servicebus & cosmosdb specifically). Please consider once more reopening this issue.

We will be doing this work as part of certifying Azure components as stable. In some cases we depend on the new Azure SDKs being ready.
There will be no specific work to resolve this issue, instead follow each Azure components certification tracking issue. You may also want to follow issues for the Azure SDK upgrades like #1532.
If we support any form of AAD like service principal we get support for Managed Identity automatically for free the way our code works.
In general we will support AAD auth for every Azure service that provides a way to authenticate with AAD. This is one of the criteria for the components to be considered stable.
If the Azure SDK we are using however does not support AAD we may proceed without this feature and will revisit at a later time as soon as the underlying SDK supports it.
cc @ItalyPaleAle who is leading our migration to the new Azure service SDKs.

@codesmon Cosmos DB state store supports authentication with AAD for several releases. The relevant code is here: https://github.com/dapr/components-contrib/blob/master/state/azure/cosmosdb/cosmosdb.go#L134
Looks like we forgot to document this here:
https://docs.dapr.io/reference/components-reference/supported-state-stores/setup-azure-cosmosdb/
You can follow these instructions:
https://docs.dapr.io/developing-applications/integrations/azure/authenticating-azure/
I don't think we need to keep this general issue open @AaronCrawfis @yaron2 because it really is part of the standard to certify as stable Azure components. Cosmos DB is a bit weird because it was grandfathered in, but it already does support it.

Are there any plans to support managed identity auth in the rest of the Azure components? Specifically, I'm looking for support in either the Event Hubs binding or the Storage Queues binding so I can port an existing application to Dapr

@rzyns as of release 1.8 Azure Storage Queues binding has AAD support. Apparently we forgot to update the docs - but it works the same way as with the other components supporting AAD - same metadata fields etc.

I believe all components which can support AAD now have AAD support implemented. At this time I will close this issue. We will always implement AAD support if this is possible with the official SDKs we are provided.


allow disabling default keymaps

In response to https://github.com/ggandor/lightspeed.nvim/issues/11
This PR allowing to NOT MAP AT ALL some of the mappings
It separates mapping to 3 categories and adding 3 options to the setup

override-s - default true overrides s
override-x- default true overrides x
override-motion - default true overrides fFtT...

Friendly ping @ggandor.

Hi! I'm a bit exhausted, and taking some time off for a couple of weeks, and I would especially not want to deal with API-related issues and breaking changes now. ;) Thanks for understanding.
That said, if such an option would ever be provided, it would be one flag, something like set_default_keymaps = true, this level of granularity is unnecessary. (On a side note, I don't understand the separate override_x option, AFAIK, x is not used in operator-pending mode by Vim. Is it?)

@ggandor oh I didn't expect your attention to the PR, I made it as response to someone above asking for it but saying they don't know fennel, so I figured since I need that change myself why wouldn't I make it public? :)
As per the separation of override_<thing> - it comes back again to this thread. Some people, like me, dont use the x binding but we do use the original x behaviour. Same goes for s and fFtT..., I personally want to keep motions in their original form, so the only thing I care about is the s binding. I also figured not binding fFtT... would be useful for those who heavily rely on macros...
Bottom line - go figure what people want, the more flexible it is - the better (in specific case of vim plugins), since we have all flavours of users.

the original x behaviour

What is e.g. yx... supposed to do?

I also figured not binding fFtT... would be useful for those who heavily rely on macros...

That is a typical XY problem, I even labeled #11 as such, because of this. Wouldn't it be more logical for those people to contribute to the conversation in #14 instead? The very point of the plugin is to enhance the native ft, lightspeed motions (f/t/s/x) together form a suite.

the more flexible it is - the better

It's not that simple. Flexibility is great while it comes for free, but that is rarely the case. Having one way of doing things, conventions people - including other plugin authors - can rely on, a small, non-cluttered API, etc. can be features too. Plugins like Lightspeed/Sneak/Surround/etc. are kinda special, as they provide new/enhanced basic motions (/text objects), and not just a bunch of special commands for, say, git stuff, window handling, code formatting, or anything else. They aim to integrate into the very core of Vim as a text editor.

I didn't expect your attention to the PR, I made it as response to someone in #11 asking for it but saying they don't know fennel, so I figured since I need that change myself why wouldn't I make it public? :)

Right, I suppose it's OK to close this then. (Sorry, but even if this is just a quick hack together, I cannot help mentioning the wtf factor of those 3 copy-pasted loops... DRY? :D)
Fennel note: (:foo bar) only works in Clojure. Semantically :foo is a normal Lua string in Fennel, mere syntax sugar for "foo". The only correct way is thus (. bar :foo).

Fennel note: (:foo bar) only works in Clojure. Semantically :foo is a normal Lua string in Fennel, mere syntax sugar for "foo". The only correct way is thus (. bar :foo).

Thanks for the info, I felt there's something off

What is e.g. yx... supposed to do?

Not even a slightest idea. x by itself removing character under the cursor. And my muscle memory of 22 years disagrees with such change

That is a typical XY problem, I even labeled #11 as such, because of this. Wouldn't it be more logical for those people to contribute to the conversation in #14 instead?

No, as I don't rely on macros much, because you took it a bit off the context. And I can't talk for 'those people'
The main context was that I personally don't like changed behaviour of motions. I don't like them highlighted, don't like them span on multiple lines and overall find them useless for myself. The s binding is answering all of my needs for fast navigation and it does it awesomely, everything else however (for me) is your subjective opinion.

Plugins like Lightspeed/Sneak/Surround/etc. are kinda special, as they provide new/enhanced basic motions (/text objects)
or

Here's another opinion for you: all this plugins are really doing (except being arguably useful) is not following the common path of giving the power to the end user and making opinionated decisions on user's behalf which, for some users at beginning and for most users as they advance those plugins become red flag. And in the end surround got removed from plugins list forever.

Right, and thanks - I suppose it's OK to close this then(?)

That's up to you, be it my repo and would I not want to implement such a change I would keep it open for those who seek.

yeah i don't think i ever used x in OP

Okay, I'm lost here. Why make an API flag if you don't even know whether it's used by Vim? (Why didn't you create an override_z flag then?)

making opinionated decisions on user's behalf which, for some users at beginning and for most users as they advance those plugins become red flag

https://github.com/ggandor/lightspeed.nvim#guiding-principles A balance has to be found between providing flexibility and tools that "just work". If every plugin would follow the "start from scratch and do whatever you want, I'm not making any assumptions, I'm just a DIY toolkit" approach, them most of us would go insane. But there's a difference in explicitly disallowing something and not making it easy. Lightspeed is designed as a suite of motions, and people who do not want the whole pack are not handled as first-class citizens, that's all. It is a design decision.

Closing in favor of 61b1afa4eb9105803b583e88cda53385f80ebca1.


Increase required version of node

You're using String.prototype.padEnd in various places and that is not supported at all in NodeJS v6. It needs to be at least v7 to use that function (with a flag).

This is actually coming from signale, please follow https://github.com/klauscfhq/signale/pull/53 for updates.
Node 6 can still be supported once the above PR is merged and the Object.entries method is replaced refactored from the source of taskbook. Thank you for taking the time to submit the pull request : )


Fixed: Added support for textarea and select elements with updated color settings

Textareas not working still... seems like this repo has been abandoned


Add string tokenization helper transforms

Initial skeleton of the advanced string tokenizer for latin character languages.
Modeled after the following:
https://github.com/redpony/cdec/blob/master/corpus/tokenize-anything.sh
https://github.com/redpony/cdec/tree/master/corpus/support
@asaluja feel free to make changes as you see fit

Don't you want the replacement maps to be configurable by the config file?

@hectorgon that's another possibility, if we go down that route, I think it would make more sense to just make a "ReplaceStringWithRegexTransform" (where you pass in all the replacements via the config file) and a "NormalizeStringToUtf8Transform" (where you pass in what UTF-8 standard is desired via the config file) and then those two could just be chained together with the DefaultStringTokenizer in whatever order is desired in order to simulate the advanced string tokenizer that @asaluja  is looking for. By generalizing the transforms, additional tokenizers for different languages could also be built more easily in the future by combining these three transforms together in any desired order.

@hectorgon @christhetree some thoughts on this PR.  Overall, breaking the overall tokenization transform into a series of smaller transforms and composing is the way to go.  That way, we can re-use code across different languages, and also create transforms on the fly for new languages (e.g., Chinese word segmentation).
Desiderata:

separate lower-case transform: some languages don't need this
transform to eliminate stop words (would need to rely on an external stop words list, which differs for different languages and domains)
transform should also be able to take in a list of tokens that should not be tokenized (e.g., I.B.M.)
re: UTF-8 normalization as in this link, we should probably stick to NFC, don't really see a need for the others so no need to provide flexibility on this front.
can ignore any mention of SGML/XML handling (not our use case),

Referring to the code in this tokenizer, the Stanford tokenizer seems to implement significantly the same functionality, but I am not as familiar with the codebase there, so if that's easier for you to follow we can do that. One thing to note is that the Stanford tokenizer is optimized towards English, while the cdec tokenizer is relatively more language-agnostic.
I also have a bunch of test cases in mind (particularly, testing the conditions on lines 460-520 in the cdec tokenizer ).  When this transform is done, please tag me on the PR for the test cases and I can help in developing them.  Hope this helps!

@hectorgon is there any way to get a map<String, String> as an input from the config file?
@asaluja added some of the helper transforms for an advanced tokenizer that we may need later; I'm still checking out the Stanford tokenizer, we'll have to discuss reproducing it with transforms vs. potentially integrating its source code in directly

Tests will be added later once the code is finalized
@hectorgon Feel free to take another look when you have a chance and let me know if there's a cleaner way to write the bigram logic / if you had something different in mind
@asaluja These three helper transforms should allow you to implement the Perl tokenizer you were referring to earlier by simply feeding in all the desired regexes in the config file and building a tokenizer pipeline using the list transform. However, the order of the tokens is unfortunately still not preserved due to the Map nature of the string features where order is arbitrary to begin with. We can discuss this more in person.

@christhetree I try to avoid external IO whevever possible because I don't want to suck in S3 dependencies or what not in serving. If the files are small enough you could embed them in a config like this https://github.com/airbnb/aerosolve/blob/master/core/src/main/java/com/airbnb/aerosolve/core/transforms/KDTreeTransform.java or if they are too large you can have them as a separate java resource that you point to in the config and the user supplies in the jar.

@deerzq and @askeys for PR comments

I have no idea how the tokenizing and regex will interact with UTF8 @asaluja do you know when UTF8 normalization happens and what will happen if the tokenizing happens after UTF8 normalization?

@hectorgon UTF8 normalization should happen first, tokenization should happen afterwards.

@hectorgon Bigram test has been added

:+1: assuming you are adding the tests for regex and normalize in the PR with the filter stopword transformer


Look at "progress" module on PyPI

pip git develop is vendoring progress==1.2 to display a download progress bar. Theirs is ASCII but it looks to have an IncrementalBar class that looks like it might be similar to pytest-sugar's.
https://pypi.python.org/pypi/progress
Wondering if it might simplify pytest-sugar or handle anything nicer.

Closing an old issue. Feel free to open a new issue if issue still relevant.


Compile sqlite against GNU readline when available.

Needs GNU readline installed; note, it is keg-only.
From the SQLite documentation (configure.ac):
#-------------------------------------------------------------------------
# Two options to enable readline compatible libraries:
#
#   --enable-editline
#   --enable-readline
#
# Both are enabled by default. If, after command line processing both are
# still enabled, the script searches for editline first and automatically
# disables readline if it is found. So, to use readline explicitly, the
# user must pass "--disable-editline". To disable command line editing
# support altogether, "--disable-editline --disable-readline".

SQLite's ./configure has helpful options:
  --enable-editline       enable BSD editline support
  --disable-readline      disable readline support

  --with-readline-lib     specify readline library
  --with-readline-inc     specify readline include paths

Hence, Homebrew should invoke:
./configure --disable-editline --enable-readline --with-readline-lib=$(brew --prefix readline)/lib --with-readline-inc=$(brew --prefix readline)/include
Try testing with:  brew install --interactive sqlite, then in the spawned shell:
export PATH=/usr/local/bin/${PATH} # Provide brew the command substitution sub-shell.

./configure --disable-editline --enable-readline --with-readline-lib=$(brew --prefix readline)/lib --with-readline-inc=$(brew --prefix readline)/include

Unfortunately, ./configure complains, hmm.. sqlite bug?
configure: WARNING: unrecognized options: --with-readline-lib, --with-readline-inc
Use CPPFLAGS and LDFLAGS instead:
LDFLAGS=-L/usr/local/opt/readline/lib CPPFLAGS=-I/usr/local/opt/readline/include ./configure --disable-editline --enable-readline && make

# ...time passes

otool -L ./sqlite3
./sqlite3:
        /usr/local/opt/readline/lib/libreadline.7.dylib (compatibility version 7.0.0, current version 7.0.0)
        /usr/lib/libncurses.5.4.dylib (compatibility version 5.4.0, current version 5.4.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1226.10.1)

[x] How to do this with ruby in the sqlite formula?
[ ] Output helpful message to homebrew user regarding compilation againstlibedit vs readline and their respective rc files.

Reference
BSD editline http://thrysoee.dk/editline/

How close is .editrc to .inputrc

Using refute foo.empty? in a homebrew test causes:
$ brew test sqlite3
Testing sqlite
==> Using the sandbox
==> otool -L /usr/local/Cellar/sqlite/3.16.1/bin/sqlite3
        /usr/local/opt/readline/lib/libreadline.7.dylib (compatibility version 7.0.0, current version 7.0.0)
Error: sqlite: failed
test returned false
/usr/local/Homebrew/Library/Homebrew/test.rb:28:in `block in <main>'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/timeout.rb:66:in `timeout'
/usr/local/Homebrew/Library/Homebrew/test.rb:27:in `<main>'

... while assert foo.any? works [and fails the test] correctly.

Need to test build when readline is not installed.


version 1.19.3  mod version 1.1.0

while  trying to do a key bind while still writing the comand and presing bound will crash minecraft ( tlauncher minecraft )

Can you attach a crash report?

I'm closing this issue as I'm unable to reproduce the bug


why pruning rate starts from 1.0 in main.py ?

Thanks for your nice implementation.
I have a question: the pruning_rate in main.py or ChannelPruning.rate decides how much filters will be pruned out, e.g. pruning_rate=0.8 means 80% of filters will be pruned out. So why pruning rate starts from 1.0 and decrease iteratively in main.py? In my opinion, for pruning_rate in [0., 0.2, 0.4, 0.6, 0.8] is more reasonable.

Sorry I made a mistake. I realize that the real pruning rate is 1 - self.rate.


Authentication enabled

Purpose

Adds authentication to the sample.  Gives a simple example of using EasyAuth authentication with either workforce identity (Entra ID) or customer identity (Entra External ID).

It extends the pre-/post- hook pattern from https://github.com/Azure-Samples/azure-search-openai-demo/pull/891 to also work with External ID via an additional script that is run before the azd up to set up an application in the External ID tenant that can create all the additional configuration (userflows, admin consent grant) that is needed in a External ID application.
Does this introduce a breaking change?

[ ] Yes
[X ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Follow instructions in README for enabling authentication with either Microsoft Entra ID or Microsoft Entra External ID

Thanks James! Now that I've updated this repo to OpenAI 1.0, I can look at this PR. Do you think there's any chance of modularizing this code so that there isn't so much in this repo? Or will that end up making it too difficult for developers to modify?

@jamesc @pamelafox This works for Entra ID for customers (Entra External ID for customers), right? Any plan of merging to the main? Thanks.

I have taken these changes, updated them to use the Graph SDK where possible, and added KeyVault support. I wasn't able to use the Graph Beta SDK for the new stuff (flows) due to some issues that I reported in their repo, so I left them os HTTP calls.
You can see my changes in this branch comparison view:
https://github.com/jamesc/chatgpt-quickstart/compare/auth-enabled...Azure-Samples:openai-chat-app-quickstart:pamelauth
I have put all the changes in a new repo:
https://github.com/Azure-Samples/openai-chat-app-entra-auth-builtin
After a chat with Arun, we've decided to have three separate repos to help developers find what they need:

https://github.com/Azure-Samples/openai-chat-app-quickstart/ for developers who just need an example of managed identity
https://github.com/Azure-Samples/openai-chat-app-entra-auth-builtin for developers who want to setup Auth with the built-in Auth functionlity
https://github.com/Azure-Samples/openai-chat-app-entra-auth-local for developers who need to be able to develop with Auth locally or a non-Azure platform, using MSAL SDK via the identity package

I will close this PR for now. Please let me know if you see any issue with my changes in the new repo and file any issues or new PRs there. The Entra External ID is quite neat, and I'll try to bring that into openai-chat-app-entra-auth-local as well when I have a chance. Thank you @jamesc !


Error: Cannot find module './dataType'

First Run get, the same on Local, RunKit and Rel.it
Error: Cannot find module './dataType'

First Run get, the same on Local, RunKit and Rel.it
Error: Cannot find module './dataType'

Yeah, thank you. Actually, I have already fixed it. Just follow the above suggestion. This is known bug. In future, I am going to release a new version with more features and excellent way for accessing the columns, rows etc.


Delete jobs in bulk

It would be nice to have the ability to delete multiple jobs at once, perhaps with checkboxes.

Finished.


[ wip ] Message Structures of the ROS-Industrial Simple Message Protocol

Progressed sufficiently to request an early review of this.
Note: this is a retrospective REP in that it documents the current state of simple_message and industrial_robot_client, nothing new here, but I got (and answered) enough questions about Simple Message and the entire infrastructure to write it down I believe.
Link to rendered file.

This is a really useful document, shame it took me quite long to find it! Would be great if it gets merged and linked from the wiki pages.
Just a small note, in the document tri-state values are documented as 0 = ON, 1 = OFF, but in the source code it appears to be the opposite way around:
https://github.com/ros-industrial/industrial_core/blob/kinetic-devel/simple_message/include/simple_message/robot_status.h#L79

This is a really useful document, shame it took me quite long to find it! Would be great if it gets merged and linked from the wiki pages.

Yes, that is the plan.
Unfortunately I just haven't had the time to finish this.
I might just link to the PR instead in the mean-time.

Just a small note, in the document tri-state values are documented as 0 = ON, 1 = OFF, but in the source code it appears to be the opposite way around:
https://github.com/ros-industrial/industrial_core/blob/kinetic-devel/simple_message/include/simple_message/robot_status.h#L79

Thanks. You're completely correct.
Not sure how that happened.

Finally finished this.
Addressed all outstanding comments by @shaun-edwards.
CI is green.
Merging, as this is a retrospective REP (essentially protocol documentation).
Further improvements can/will be made in follow-up PRs, if needed.

Rebased to use new GHA linter setup.


Mention Podman as a valid option in all Quickstarts

Most Quickstarts work with Podman, but not all (see https://github.com/dapr/quickstarts/issues/789). After #789, change all remaining quickstarts's text to have Podman as a supported option.
Depends on #789

Podman is still not working reliability in any server test.
Also I would like to understand which dapr community members want this.  I feel like Docker is still mainstream, and this just adds more options and conceptual overhead.
I could see a *doc like "Working with Podman as your desktop container engine"

I would like to consider a post 1.11 document, instead of this QS idea.  Thoughts @artursouza ?

Until Podman cannot be used reliably in automation, it will be hard. But as Docker Desktop has its own licensing issues, I think Quickstarts with a Podman option will be helpful for users that don't adopt Docker Desktop. Maybe we can collect some data on this?

What about colima? 😄
I think there are several docker alternatives but no clear winner, esp. not on all platforms. Until that time, I think it would be more appropriate to mention some alternatives in a footnote, but continue to focus the docs on docker.
Users of docker alternatives will translate in their head to whatever they are using.


AZ_EXPECT_SUCCESS

AZ_EXPECT_SUCCESS is better than ignore_result; Use it for cases when  writing a test consisting of complex steps, and things you use for preparations return az_spans, but yor test is not to test them. Use AZ_TEST_AZZERT(result == AZ_OK) when verifying the function that you are testing; but for all other functions returning az_result, use AZ_EXPECT_SUCCESS, so that your code is up to 2x shorter, you don't step on AZ_NODISCARD every other line, and the result is not ignored completely + it is easy to identify all the places where you use them. Plus it is only defined for tests.

Will go in as part of https://github.com/Azure/azure-sdk-for-c/pull/175


Feature request: *sync alternatives.

It would be great to have the synchronous alternatives as well, for all functions.

@oxygens Thanks for your suggestion, but synchronous is not the way I want this module to be. Since synchronous function has a lower performance, and it's better to use Promise.
Since there's already a lot of brilliant promise libs out there and promise in ES6, I am not going to involve it in this library, since it's very easy to wrap around it:
import ps from 'ps-node';

function lookup(...args) {
    return new Promise((resolve, reject) => {
        ps.lookup(...args, (err, result) => {
            if (err) return reject(err);
            return resolve(result);
        });
    });
}

All serious modules offer both. Just saying.


upgrade all HDP symlinks

Today we do hdp_select('zookeeper-server') but we do not update the zookeeper-client pointer today; we should though! Thanks to @leochen4891 for discovering this.

will be fixed in HDP itself


Two extensions: An extended context with a compile-time-defined number of pointers, and modules

Much like #1740 this also introduces infrastructure for multiple extensions, taking into account my comment. It also moves the user context deinit to the top of jerry_cleanup () because the context has to be functional when deinit the user context, since the user context may contain jerry_value_t variables and may need to make API calls.

CC @jiangzidong
He plans to implement import and this is definitely related.

jerry_module_load () could definitely be passed into whatever ends up handling import as a hook to external native modules, in a fashion similar to the function pointers passed into jerry_init_with_user_context ().

Maybe we should compile one jerry-ext lib instead of small ones. so that users only need to link one lib.

I highly agree. Creating multiple jerry-ext libs is a bad idea. It would be also hard to maintain and test the different combinations.

I don't think there's a difference between one jerry-ext lib or multiple, because the different parts are controlled by flags anyway, so you have to test just as many combinations either way. It's only a matter of how many .a files will you have. Everything's linked statically anyway, so if you start with one .a file or twelve, what difference does that make?

Wait, I see a benefit. You don't have to have twelve arguments in your target_link_libraries. OK. I'll change it to one library controlled by multiple flags. Still need to test the combinations though.

There seem to be two problems:

The extensions need to allocate/free stuff. There needs to be an API for that, otherwise we introduce all kinds of portability issues which will prevent jerryscript from being self-contained.

Making jerry-ext one target with multiple conditionally included parts is awkward because there is a case where the library is requested (say, a new flag JERRY_EXT is set to ON), but none of its pieces are requested (that is, both JERRYX_MODULE and JERRYX_CONTEXT are left OFF). What do you build then?
There's no big difference between having one library and having multiple, and in the multiple case, the individual flags are clear. If you turn on JERRYX_MODULE you will have the module extension, etc. The only inconvenience is that in your target you have to say
target_link_libraries(${MY_TARGET} jerry-core jerry-context jerry-module jerry-blah ...)

instead of simply
target_link_libraries(${MY_TARGET} jerry-core jerry-ext)

Actually, we already have that. The module definition is stored in a global static structure in each module which is passed to jerry_module_register () from a constructor. jerry_module_register () connects these structures into a linked list. This is part of the executable structure, so it's done without any allocation and, if you wish to make a module available to any context, then you have to link it in. You can't save space that way.
Now, per-context, a module instance is stored on the context in a separate linked list. An instance is not created unless the module is requested in that context. So, the size of the linked list in any given context depends on how many modules were requested.
When the context extension is present, the module manager takes up only a single slot in each context, because it does its own allocation when a module instance is created.
The reason for jerry-ext/context is not so each module can have a slot, but so the module manager can have one slot while possibly retaining a free slot for something other than the module manager.
I'll make a Google Drawing of the memory layout so we have something clear to look at.

... and I'm actually thinking about doing away with jerry_module_register () and using a special section for module definitions, just like I'll be using for module resolvers and context slots. That way, everything becomes part of the structure of the executable, and only module instances need to be cached on demand and per-context.

An instance is not created unless the module is requested in that context.

At the module layer, I guess my project could have some access control logic before it calls jerryx_module_resolve. So that's a way to solve that part.
However, if you have bindings that do not use the module system (and only the context muxing layer), the jerry_user_context_init_cbs of those bindings will be called unconditionally. There's currently no easy way to control that on a per-Jerry-instance basis (w/o modifying the util code).
See my point?

@martijnthe OK. I take this to mean that the problem is restricted to jerry-ext/context and that what we need is per-context variability in the amount of memory allocated by jerry-ext/context and probably the indices of the various slots.
I designed jerry-ext/context with the assumption that there won't be a need for too many slots, because, pretty much it's one slot per framework, because, just like modules, a framework uses one slot and then manages its own memory within that slot.
So, if we want per-context length and index variability, then we cannot go with indices stored in global static integers and assigned at boot time. We could use a string-keyed data structure like a linked list, the same way as modules use it but I suspect that's a lot of room wasted on meta-data, because there won't be a need for that many slots (again, my assumption).
I'm by no means an expert on data structures but I can't help thinking that, if JerryScript can accommodate JavaScript objects, then it must contain an efficient mechanism for creating string-keyed variable-length associative arrays. Can we not factor that mechanism out and have a string-keyed, pointer-valued associative array made available to extensions? (Disclosure: We may actually already have that, just like we have jmem, but I haven't checked :))

Oh, and my other assumption was that there won't be too many concurrent contexts, so the number of unused slots will not be multiplied by a large number of contexts.

In terms of market research, since this functionality has never before been available, and since we're not fully committed to semver, I think we might benefit from releasing jerry-ext/context with a fixed number of slots and if our users complain that it wastes too much memory, we can later improve it.
Of course, I'm also happy to wrangle the problem of per-context variation in length and indexing a priori :)

OK, I guess one solution to my problem: if you want per-Jerry-instance control over what bindings are usable & may take up resource, build everything on top of the module system, not the user context muxing layer.
Re. index variation: I think it's fine to keep the indices static and some have unused slots if the initializer wasn't called because it got filtered out.
Anyway, I'll just build everything on top of the module system instead of the user context muxing layer, that works too.

Yeah, that was my thinking too. The context muxing is there to answer the question How many different reasons do you have for attaching stuff to a context? for the case where you have more than one reason. Modules are one such reason, and modules alone already offer a lot of power.

Another thing to consider is that extensions, whether modules or not, can probably use jerry_set_object_native_handle () for per-context data.

Would it be an idea to split off the muxing layer into a separate PR? Just to keep the git history cleaner and have more concise commit messages with each piece.

@gabrielschulhof Please, update the PR to latest master. We already have jerry-ext in the tree, and a rebase would help (at least to me) to see better what's the addition of this PR and what was needed to set up jerry-ext until it hasn't landed.

@akosthekiss I'll do that ASAP.

@gabrielschulhof will you be putting up a PR for the module parts (on top of the context-items-link-list, #1833)?

@martijnthe Real Soon Now™


Update moduledoc for Ecto.Query: not is_nil

Tonight I was trying to write an Ecto query to find all resources where a given attribute is not nil. The Ecto.Query docs state that this is a valid query:
from p in query, where: p.published_at != nil

I kept getting this error, which I believe came from https://github.com/elixir-lang/ecto/pull/1057 .
This PR updates the moduledoc to use not/1 and is_nil/1

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


Correct postion for Fixed and Stretched mode

Moved the window to the right of the Relic Fragment window.
Added var SIDEBAR_X_ADJUSTMENT = 620 px.  Noob pull request.

Hm, this could work (though I'd prefer to use the right bound of the fragment window for the offset instead of needing to know how wide the fragment window is). Another solution I'm considering (especially for fixed-mode users) would be to have an optional RuneLite panel on the right bar that has the same functionality as this sidebar. Thanks for the PR, though! I'll take this idea into consideration.

would be to have an optional RuneLite panel on the right bar that has the same functionality as this sidebar.

First, thanks for making the plugin! It's awesome, I just wanted to contribute so it would work for me and others.
I really like that it's within the game window. Your current solution is more elegant. The window pops up, and is only visible when used, then disappears. Clicking a button to open the sidebar would add one extra click to the menu every time you used it, or require you to leave the sidebar open the entire time while playing, for one temporary plugin, or be done automatically by the plugin.
Plugins should try to avoid "automatically" opening up the side menu repeatedly, because it shifts the entire game window sideways if RL is on the right side of the screen or obscures windows behind it. We still have to move our mouse back to the vanilla Relic Fragment UI to select them, so the menu ends up split further away and the mouse has to travel further. There's no great place to put the menu in Fixed Mode, but RL correctly stops "click throughs" on objects behind a menu, so the overlapping is only visual, and it remains highly functional. For some plugins, it makes sense, because they are disconnected from what you're doing on screen. For this plugin, accompanying the original UI makes it intuitive.

Thanks for contributing! With #4 and 80271d3 this should be solved now.


QuickUnlock is not available for this database

I have followed the instructions: Created a "QuickUnlock" entry in the database, entered the password, kept everything else blank, restarted keepass, it does not autofill the key file and when i select it, it just says "QuickUnlock is not available for this database". Am i missing something here?

QuickUnlock is only available if you lock your database. If you restart KeePass, the quickunlock key is not available because you haven't unlocked the database before. QuickUnlock just helps you to quickly unlock an already opened database (in the same KeePass session). If it would allow to unlock a new database it would be just a weaker master password.

Ah, my bad, thank you for confirming this :)


[Tooltip] no possibility to create white tooltip arrows

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Not 100% sure if this is a feature/change request of bug report.
Current Behavior 😯
With the current styling approach of arrow it's not possible to create white on white tooltips with arrows without using a custom popper implementation.
Expected Behavior 🤔
As there's a "light" demo in the docs i would assume that it's somehow possible to have a white, but visible arrow without rewriting the complete arrow css.
https://material-ui.com/components/tooltips/#customized-tooltips
Steps to Reproduce 🕹
https://codesandbox.io/s/light-tooltip-q1t7e?file=/src/Demo.js
Context
The current tooltip arrow styling is based on a border trick.
This makes it impossible to have a "border only" kind of triangle like one would need for white on white. I was wondering if a rotation or svg based approach would be an accepted change to the current implementation.
Your Environment 🌎

Tech
Version

Material-UI
v4.9.11

@sakulstra The rotation idea sounds great. Did you try it out? It would also no likely be a breaking change considering we can still use the color (for users) -> currentColor (for implementation) trick.

@oliviertassinari yep i'm currently using a very hard coded version of the rotation based approach.
Wanted to know if there was perhaps a informed decision against this in the past before putting effort into abstracting it to a more general purpose pr :+1:

@sakulstra The initial design was influenced by Bootstrap. I think that they were influenced by the browser constraint, wish is no longer an issue.


"Submit a bug" should include the command line and remove extensions if launched with --disable-extensions

The "report a bug" button opens a window with all the extensions filled in, which is great. But if you open code with all extensions disabled there is no indication of this in the pregenerated text.
It seems reasonable to not include the list of extensions at all and just say "Code was launched with all extensions disabled".
In addition it'd make sense I think to include all the command line options passed.

What about adding another column to the table describing if each extension is enabled or not? Like this:

Extension
Author
Version
Enabled

e1
au1
1.0
Yes

e2
au2
1.1
No

Pushed the portion of https://github.com/Microsoft/vscode/pull/33225 that will not show the extensions if they are all disabled.

Improvements to Submit a bug are coming this milestone, closing this as a dupe.


Disconnect and send_timeout option

Hi,
Needed some new disconnect method and configurable send timeout.
Would it be possible to merge?

Thanks for your contribution!


RD2:  Extract schedule section into an LWC

Critical Changes
Changes
Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

**lurch: attach W-041485

Tracking W-041485


Assets library rendering got broken

Godot version
4.1.1 stable oficial
System information
Windows 11 - 4.1.1 stable oficial
Issue description
When I navigate to the second page of assets library the rendering got broken getting the IDE width larger than my notebook screen.
Display resolution: 2560 x 1440.

Steps to reproduce
1 - Open assets library
2 - Select page 2
3 - The IDE doesn't adapt to the screen size.
Minimal reproduction project
It doesn't apply, the issue occurs on any project

Thanks for the report! Consolidating in https://github.com/godotengine/godot/issues/80507.


Hint error when performing aggregation

The following error is raised when displaying the timeseries for the new Vigicrues job (see https://github.com/kalisio/k-vigicrues/issues/29):
planner returned error: bad hint
It seems to be related to the fact that the hint we provide does not match any index as the job creates compound indices instead.

Tried to remove the hint in https://github.com/kalisio/kdk/commit/f757c877b37df02f9c11c1b2a9c6f16ecb960bb8 as we cannot easily infer the available indices. Let's see if it affects performances.

It appears that the bug was due to the fact the DB was erased during development while kano was running and the job launched. But the hint index is created by kano when initializing so that if it is not restarted the index is missing. This should not appear in real-world use cases.


Add support for parsing index blocks

Thanks for this great library! This PR adds a function to parse IndexAllocation entries to, e.g., navigate through the directory strucuture.

Thanks for the contribution! It has been a while since I played around with NTFS & MFT and worked on this lib, so I need some time to read some docs again and understand what this is about exactly. 😄
In the mean time, I'm a big supporter of making sure every publicly accessible type and function has well-written documentation. So if that's something that you feel you could do, I would appreciate it if you added that to the pull request.
I'll make sure to come back to this PR soon, after I'm more up to date on the material.

Thanks for the reply; happy to see you are still maintaining this repository!

It has been a while since I played around with NTFS & MFT and worked on this lib, so I need some time to read some docs again and understand what this is about exactly.

Sure thing, NTFS is quite a beast and it takes some time to get that all into the internal RAM (=short term memory). Your library helped me with that quite a lot, though; well-written and clearly structured.

In the mean time, I'm a big supporter of making sure every publicly accessible type and function has well-written documentation. So if that's something that you feel you could do, I would appreciate it if you added that to the pull request.

That makes sense to me! I just added some comments to the new methods. I am looking forward to your review whenever you have time.

I'm glad that people, like you, are actually finding and using this project! 😆 I only made it for a hobby project a few years ago after which I didn't really spend any more time on it.
The added comments look really good, thanks for adding them. 👍 Also very nice that you added the link to documentation, so it was easy to find out more about it.
There's one superfluous empty line, would be neat to remove it, then I'll merge it.

Sure thing; thanks for the review! I just removed the extra empty line.

Great!


Server was forcefully closed before registration. Exiting....

When starting my server, it throws this error and then immediately closes with no other feedback. Debug log and server log are attached.
debug.log
server.log

Not an Astrolauncher issue. discord.gg/astroneer for support

Thanks for the note!


BGE uses dynamic fields for form and grid

Critical Changes
Changes

BGE Form and Grid fields both draw dynamically from Active_Fields__c on Batch record

Issues Closed
New Metadata
Deleted Metadata

**lurch: attach W-028587

Tracking W-028587

QA Approved, Merging.


WIP: Add existing walkthroughs to feature branch for own walkthroughs

@aidenkeating just messing around, and looks like there's decent markdown support

closed in favor of https://github.com/integr8ly/tutorial-web-app/pull/262


Show loading screen after delay (not needed in native / cached apps)

V3 will load quicker initially, so, no loading screen needed for startup anymore :-)


Utilize building footprints

Closes #2
Closes #34
Closes #41
Closes #42
Enables use of building footprint polygons to bypass loc inference. Also enables building damage weighting when input footprints are utilized.

This code is so hairy. Can we add in some comments for documentation?

Nope...well, maybe you or Jared can. haha

Changes made, save one (handler.py lines 159-166). All files formatted with black.


TLS package differences

Hi,
There is now a org.bouncycastle.tls package that contains all necessary classes to create a TlsClient or TlsServer and so one in addition to the already existing org.bouncycastle.crypto.tls
All files are duplicated but there is differences, what is the purpose and which one should we using ?
For example TlsExtensionsUtils class from org.bouncycastle.tls has some methods which are not available in the TlsExtensionsUtils class from org.bouncycastle.crypto.tls:
TlsExtensionsUtils#addClientCertificateTypeExtensionClient();
TlsExtensionsUtils#addServerCertificateTypeExtensionClient();

Also TlsProtocol#offerOutput() method is not available in package org.bouncycastle.tls but is defined in org.bouncycastle.crypto.tls package.

Use org.bouncycastle.tls the older crypto.tls package will eventually be deprecated.

Thanks.

FYI, TlsProtocol#offerOutput was renamed to writeApplicationData in the new API.


dot net core support

This adds a few commits to #12.
Added value is primarily cleanup, but I also integrated the nuspec into the project file.
I autoformatted a bunch of files to restore the 4-based indent.  Unfortunately, that also caused a few more spurious changes.  You'll have to judge if that's a problem, of course.
While autoformatting, I encountered ProcessResults, and I noticed it was manually creating get-only properties; there's syntax for than nowadays, so I used that.  I also made the class sealed, since it's IDisposable and the alternative is much messier and confusing (microsoft's virtual Dispose(bool) pattern).
This does not yet include multitargetting.  That may be a trivial change, but it might not be, so I didn't want to confuse matters.

The tests do not work on my machine; the RunProcessAsTask appears to work, but the dummy app can't be loaded, the dotnet command fails with the message that...
A fatal error was encountered. The library 'hostpolicy.dll' required to execute the application was not found in 'C:\VCS\external\RunProcessAsTask\src\RunProcessAsTask.Tests\bin\Debug\netcoreapp1.1'.
A little googling suggests this isn't a new error, but also that it should not be occurring anymore (I've got CLI 1.0.3, .net core 1.1.0).  It may just be my configuration; but the version from #12 doesn't work either.
running something like xcopy works fine.

@EamonNerbonne given you and @MaxCheetham both clearly know more about the core side of things, I think it makes more sense to let you guys just work in the repo directly instead of having to work through pull requests - I'll help out as I can, but at this point I'm more of a bottleneck and I'd rather unblock your collective efforts. 😄   I've added you both as collaborators.  If you can tell me how with the new tooling, I'm happy to build a nuget pkg to test with as a consumer (and/or push as a prerelease version up to nuget.org)

So the issue with testing before this PR was simply that I had a dirty build.  And that's actually informative, because this is failing because the PackageReference isn't taking along the .runtimeconfig.json files the .net core cli tool needs to run; this looks like a tooling bug to me.  Related: https://github.com/dotnet/sdk/pull/768 - but that bug is about .runtimeconfig.json files missing from nuget output, but apparently it's also missing in this scenario.
Since this is totally irrelevant to this project, a simple workaround here might be to use a shared output folder and be done with file-copy problems.

@jamesmanning if you want to pack and push any new-style projects (also works for net framwork targetting projects, incidentally):
    dotnet pack -c release --include-symbols --include-source
    dotnet nuget push -s https://www.nuget.org/api/v2/package .\bin\Release\<package-name>.<version>.nupkg

(Assumes you've already done nuget setApiKey <your-api-key-here>)
Such a push includes source to source servers, which works fine on push, but I've never managed to get VS to read those properly, so that part is still a theoretical advantage so far.

So coverage isn't checked now; but appveyor is green again.  Travis is reporting an error, but it looks like that might be a real error: is Process.StartTime actually supported on dotnet on ubuntu after process exit?  No idea.

As far as I'm concerned, this looks mergable now.  @jamesmanning or @MaxCheetham ?

@EamonNerbonne @jamesmanning Are we wanting the Travis build to be fixed for the integration before we merge? I'm out in the sun for most of today but i'm more than happy to pull your more recent changes down to my machine and run the local tests later on today?

@jamesmanning Also. Before we pack merge and pack this PR would you be ok with me and @EamonNerbonne naming ourselves as authors on the NuGet package?

Of course! Please do!
On Apr 23, 2017 6:45 AM, "Max Cheetham"<EMAIL_ADDRESS>wrote:

@jamesmanning https://github.com/jamesmanning Also. Before we pack
merge and pack this PR would you be ok with me and @EamonNerbonne
https://github.com/EamonNerbonne naming ourselves as authors on the
NuGet package?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jamesmanning/RunProcessAsTask/pull/13#issuecomment-296434431,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANxWuUIdD4GdUhVahj0uLGZdzPXh8RYks5ryyuvgaJpZM4NFNix
.

I'm also happy with the ProcessResults refactoring

Closing this now we can both Collab. I have opened a new PR baised off this repo.


Ditch Events mixin, make Evented base class instead

Currently we copy all Events functions into each Leaflet class. For some reason I initially thought standalone mixins are a great idea in Leaflet, but now I see that the includes property is only used to include Events, and most of the Leaflet classes are evented.
So it seems to me that it makes more sense to ditch the includes concept and make the event methods inherited instead of mixed in. This will improve memory footprint because the methods will be reused from the prototype chain, and will look cleaner in the code:
// proposed (or we could call it EventEmmiter)
L.Layer = L.Evented.extend({...});

// old
L.Layer = L.Class.extend({
    includes: L.Mixin.Events, ...});

People will still be able to to use the methods manually without inheriting if there's a need:
L.Evented.prototype.on.call(this, 'myevent', handleEvent);
L.Evented.prototype.fire.call(this, 'myevent');

cc @tmcw @danzel

Keeps backwards compatibility for now (includes: L.Mixin.Events syntax)

L.Mixin.Events now includes a constructor property meaning that if I use:
 myChildClass = myBaseClass.extend({includes: L.Mixin.Events});
then myChildClass.prototype.constructor is (unexpectedly) L.Evented

Hi @luiscamachopt,
use of L.Mixin.Events is actually deprecated in 1.0, although it hasn't been very clearly documented (it was just dropped out of the docs), see #5358 for some more information; next version will include a deprecation warning when you use it.

Hi @perliedman,
I have protected my code against this.
Something being deprecated, you would expect it to still behave as it used to. And this is a pretty strange thing to debug and figure out.
I would suggest replacing:
L.Mixin = {Events: L.Evented.prototype};
with:
var eventsMixin = L.extend({}, L.Evented.prototype);
delete eventsMixin.constructor;
L.Mixin = {Events: eventsMixin};

Or define eventsMixin first with all the methods, and then L.Evented = L.Class.extend(eventsMixin);. This avoids the weird deletion of constructor.
BTW, I have classes that I don't want them to inherit from L.Evented but I want them to have the Events behaviour, so I think removing L.Mixin.Events is a bad call. Same arguments as @jfirebaugh. Don't see a reason why you can't have L.Evented for simplicity and L.Mixin.Events for flexibility.

@luiscamachopt bad wording on my part: L.Mixin.Events wasn't officially deprecated, it's just dropped from 1.0.0 (not documented), but since it was a significant change, and also happened to continue to mostly work, we decided to put a warning to hint that you should probably stop using L.Mixin.Events.
While I can sympathize with your opinion, the time for reverting this change has passed long ago: note that this was merged in 2013 (!).
I like your suggestion of removing the constructor for the mixin; there is the potential problem if we would actually put code into Evented's constructor, but I don't think that is something we would need to do. A PR would be very welcome, or at least open a new issue to track this.


Error in paths

When utilizing the new paths functionality, anything other than  dist: './dist' seems to fail. For example when I run it correctly builds the following paths out as dist/somethingElse.
paths: {
    dist: './dist/somethingElse',
  },

However it then says it can't resolve the paths of the pages Module not found: Can't resolve '../src/pages/home/index'

In further investigation the dist/somethingElse/react-static-routes.js is outputting as import src_pages_home_index from '../src/pages/home/index'which would expect the src directory to be within the dist folder. It should output as../../src/pages/home/index`.

Hi @poorpaddy!
Great find! I think this way of importing templates has to be made dynamic, like this:
  const templateImports = templates
    .map(template => `import ${template.replace(/[^a-zA-Z]/g, '_')} from '${path.resolve(config.paths.ROOT, template)}'`)
    .join('\n')

That does the trick


Inheritance of optional URL parameters not working

Version
4.1.6
Reproduction link
codesandbox.io
Steps to reproduce

Go to /en/:

https://kotuh6-5173.preview.csb.app/en/

Explore Navigation Links:

https://kotuh6-5173.preview.csb.app/en/
https://kotuh6-5173.preview.csb.app/en/about

Select German language
Explore Navigation Links:

https://kotuh6-5173.preview.csb.app/de/
https://kotuh6-5173.preview.csb.app/de/about

Make the locale parameter optional:

"/:locale(de|en)" ---> "/:locale(de|en)?" (vite.config.js)

Go to /en/:

https://kotuh6-5173.preview.csb.app/en/

Explore Navigation Links:

https://kotuh6-5173.preview.csb.app/
https://kotuh6-5173.preview.csb.app/about

Select German language
Explore Navigation Links:

https://kotuh6-5173.preview.csb.app/
https://kotuh6-5173.preview.csb.app/about

What is expected?
I expect the locale parameter to be populated if passed in the URL
What is actually happening?
If the locale parameter is not required, it is not filled in even if passed in the URL

Perhaps I am doing something wrong? How can I fill in the locale parameter, automatically?
I understand that I can pass it manually:
<router-link
    :to="{
        name: 'index', params: { locale: $route.params.locale }
    }"
>
Home
</router-link>

Or use beforeEach to fetch the parameter from the previous route (in this case the locale will not be visible in the url and it doesn't make sense if I use SSR)
But, isn't there another way?

This is because the parameter is optional so not including it is the way to remove it. So yes, you have to manually pass it. Using a beforeEach() should also be a way to ensure the parameter is there:
router.beforeEach((to, from) => {
  if (!to.params.locale && from.params.locale) {
    return { ...to, params: { ...to.params, locale: from.params.locale }}
  }
})

Only required params are automatically preserved between navigations when the parameter matches but maybe this shouldn't be the default? I think the idea goes way beyond this though and has a big impact on the usage of vue router, so that should go in a proper RFC

@posva,

I think the idea goes way beyond this though and has a big impact on the usage of vue router, so that should go in a proper RFC

I opened a new Issue #1697 where I suggested a solution to this problem, but it was closed as a duplicate
What you suggest does not solve the SSR problem. The beforeEach hook will work after the user clicks on the link, and in the code there will be links like example.com/page instead of example.com/en/page
Once again, after rendering the HTML (renderToString), the page will have links regardless of the locale (if this is an optional parameter)
For example, the Google crawler will see that the links lead to example.com/page and not example.com/en/page
The locale example is just an example. I don't understand why you think this issue is outside the scope of Vue Router.


[23.05] mindustry: 143.1 -> 146

Description of changes
Backport mindustry updates to stable:

https://github.com/NixOS/nixpkgs/pull/233553
https://github.com/NixOS/nixpkgs/pull/238707
https://github.com/NixOS/nixpkgs/pull/235879
https://github.com/NixOS/nixpkgs/pull/253481

We want to keep the stable branch up to date because Mindustry has a multi-player mode that requires client and server have the same version in order to connect.  The public servers are running 146.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thanks for this! I forgot to backport the first one then I kinda gave up...

No worries!  Thanks for doing all the bumps!

Please use cherry-pick -x when backporting

Fixed.  Thanks.


Update Guide “README”

Automatically generated by Netlify CMS

👷 Deploy Preview for hotplate-docs processing.

Name
Link

🔨 Latest commit
da4564416cefb204376fd1a8b054e06338eb9a39

🔍 Latest deploy log
https://app.netlify.com/sites/hotplate-docs/deploys/62bd2f328181db0009215e8f


[SME] Add scalable fp16->fp32 dense schedule

This commit extends the functionality of the SME dense and matmul schedules to support operations with fp16 inputs and an fp32 output, where transpose_a=False and transpose_b=True.
For convenience, it also adds a utility called get_vscale_factor which creates the correct multiplier for vscale given a data type, reflecting ideas from an early design of the SVE RFC.
~Note: this commit depends on https://github.com/apache/tvm/pull/16921 so also contains the contents of https://github.com/apache/tvm/pull/16921.~

@tvm-bot rerun


🐞[Bug]: Issue in autocommenting on merged pr

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
I checked on the recent merged pr but we are not getting the autocomment feature and i looked more into it and i found this message
Expected behavior
message should be commented
Add ScreenShots

What browsers are you seeing the problem on?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Anshika14528 go ahead.


V1.2 Implement Delete Team

Fix merge conflicts

Codecov Report
Base: 63.80% // Head: 62.15% // Decreases project coverage by -1.64% :warning:

Coverage data is based on head (c5b1efd) compared to base (51ed06a).
Patch coverage: 15.38% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #98      +/-   ##
============================================
- Coverage     63.80%   62.15%   -1.65%
+ Complexity      413      406       -7
============================================
  Files            82       83       +1
  Lines          1456     1464       +8
  Branches        149      151       +2
============================================
- Hits            929      910      -19
- Misses          483      514      +31
+ Partials         44       40       -4

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...eedu/address/logic/commands/CreateTeamCommand.java
0.00% <ø> (ø)

...eedu/address/logic/commands/DeleteTeamCommand.java
0.00% <ø> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
80.00% <0.00%> (-4.22%)
:arrow_down:

...a/seedu/address/logic/parser/CreateTeamParser.java
0.00% <0.00%> (ø)

.../address/logic/parser/DeleteTeamCommandParser.java
0.00% <0.00%> (ø)

...eedu/address/logic/parser/DeleteCommandParser.java
100.00% <100.00%> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
76.56% <100.00%> (-0.72%)
:arrow_down:

src/main/java/seedu/address/model/team/Name.java
0.00% <0.00%> (-60.00%)
:arrow_down:

...c/main/java/seedu/address/model/task/TaskList.java
0.00% <0.00%> (-42.86%)
:arrow_down:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Propagate encodings in SA1412

In SA1412 (StoreFilesAsUtf8), file encodings are detected as part of the diagnostic. This change updates the reported diagnostics to propagate the name of the detected encoding so it doesn't have to be reevaluated as part of the code fix.
This change is not a perfect fix for #1169, but it improves upon the situation slightly. In order to fix all closed files, you can open a closed file which reported SA1412 and use the Fix All action before the IDE has the chance to recalculate diagnostics for the file. The encoding used for the code fix will be the one used by the analyzer while the file was closed, which will result in fixing all other closed files.

Disregard the code comments. I misread the closing parentheses.
:+1:  Looks good.


[Question] Padding/Size for title

Hi, I wanna know if there is a way to increase the size/spacing/padding of the leftTitle on the LineGraph. If there is non it would nice to have it added.

Nevermind found it, its under SlideTitles reservedSize. The documentation is so huge I missed it.


Load analysis results when checkbox is clicked

Right now, we have to select types of analyses and then click the "update results" button:

This has two issues:

It is one more click than required, and it is not immediately clear that I have to click on that button
It reloads all data for all selected analyses, even if I just select one additional analysis

It would be better to load/unload an analysis (and only this analysis) when the checkbox is clicked.

This feature is not possible with the current design of the code. It would be possible if we implemented each card as a Vue component.

Closed by #965


Can I map 'space' to a different field in the theme file?

I have a project with already spacings included in the theme
const theme = {
  spacing: [0,2,4,8]
}

Since styled-system uses spaces I have to basically duplicate it because there is a lot of code relied on the existing spacing
so currently I have
const mySpaces = [0,2,4,8],
const theme = {
  spacing: mySpaces,
  spaces: mySpaces
}

Is there a way to map 'spaces' to 'spacing' in the styled-system?

Styled System uses the theme specification, which uses spaces as the key, you can include other keys like you have in your example, but there is intentionally not a built-in mechanism to remap values in the object

@jxnblk okay got it!
Thanks for your reply

@alexandrzavalii in our project where we use styled-system we have spaces which is an array of values and then we have spacing which is aliased to xs, sm, md, etc seems to work well for us.


FPGA: upgrade OPAE to v.1.5.0-2

Upgraded OPAE to the latest release
Tested opae-nlb-demo image on the host with Arria10 hardware
Fixes: #383

Codecov Report

Merging #459 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #459   +/-   ##
=======================================
  Coverage   58.35%   58.35%
=======================================
  Files          28       28
  Lines        2341     2341
=======================================
  Hits         1366     1366
  Misses        917      917
  Partials       58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e4b9f...07d31b7. Read the comment docs.

@mythi @rojkov would you mind to merge this?


Use existing (3rd party) signaling server implementation

Checklist

[x] Are you reporting a bug? Use github issues for bug reports and feature requests. For general questions, please use https://discuss.yjs.dev/
[x] Try to report your issue in the correct repository. Yjs consists of many modules. When in doubt, report it to https://github.com/yjs/yjs/issues/

Is your feature request related to a problem? Please describe.
Currently y-webrtc uses a custom server for signaling. I think this is not ideal because it's a comparatively niche thing. Sometimes public servers go down (#43), creating a big headache for app developers that now have to set up a new server (that might go down as well). Having a custom server also adds maintenance costs.
Describe the solution you'd like
Rely on another existing server that can be used for signaling. For example, https://github.com/peers/peerjs-server. Or, I heard, you can use https://github.com/centrifugal/centrifugo for signaling (there is a concept of rooms (channels) as well).
Describe alternatives you've considered

None
Additional context
I'm not 100% sure this is a good idea, and I didn't look into details of how the current signaling server works, or how Centrifugo works. It's just a high-level idea that I think it makes sense to strive for.

I had the same concerns and went ahead by creating a Rust-based signaling server here. You can host it for free on fly.io.
I'm currently using it for my app and I expect to maintain it in the future.
Posting it here in case anyone is interested :)

It's also very easy to host the signaling server for free on deno deploy. Here is how I did that: https://github.com/glebbash/deno-yjs-signaling-server/tree/main.
But it's probably even easier than this now since Deno 2 support more of the Node APIs and you can probably just use the node version.


Enable redirecting http traffic to secured upstream servers

Currently only http upstream servers can be used. This will require to also change the external interface configuration form in MI's cloud views and atmosphere's REST API to convey the additional attribute saying if the upstream server is secured with https.

With @dharezlak we performed test where https->proxy->https->vm communication was established.
Redirus is ready for such change. Options capability can be used to distinguish if http or https should be used in proxy_pass directive. The only thing needed here is to change templates.
Atmosphere on the other hand need to be changed to support this feature. Boolean value should be added into Port Mapping Template (e.g. upstream_https) and this value should be converted into option while sending request into Redirus.

@nowakowski, @tbartynski this task priority should be increased. In plgrid we have a situation where https->https communication should be established.
Another solution of the problem would be to:

remove https/https PortMappingTemplate type, only http OR https
redirus will establish http->http or https->https communication.

What is your opinion?

Can we establish https->https without triggering a MIM-type situation?

Yeap, I was able to establish such connection before creating this issue. To be 100% sure we can recreate such situation on Monday :smile:

That's good news. I like the idea of removing HTTP and HTTPS; IMHO this option never made much sense. :)

I have mixed filings about it. On one hand you are right, for user it is quite strange that https->http connections are created. On the other hand https->http is much faster than https->https and we can treat inter tenant communication as "safe".

@mkasztelnik I fully agree; what I was trying to say is that it's weird to have both an HTTP and an HTTPS redirection to an application service (you'll typically want one or the other); hence this menu option is confusing and could be removed.


AmazonMQ to add support for vpcSecurityGroupRefs and subnetRefs fields spec subnetRefs

Is your feature request related to a problem?
I'm frustrated when [...] :-)
I'm trying to create a AmazonMQ with a security group and subnet.
The securityGroup and Subnet I'm creating with ACK EC2 controller https://aws-controllers-k8s.github.io/community/reference/ec2/v1alpha1/securitygroup/
I want to be able to reference the resources created with ACK when creating the Broker.
I'm able to do this with RDS controller via spec field vpcSecurityGroupRefs
Describe the solution you'd like
I would like to do the same with Amazon MQ for example
Create Security Group
apiVersion: ec2.services.k8s.aws/v1alpha1
kind: SecurityGroup
metadata:
  name: "mq-eks-workshop"
  namespace: default
spec:
  description: SecurityGroup mq-eks-workshop
  name: mq-eks-workshop
  vpcID: vpc-07488ff69b233a7c0
  ingressRules:
  - ipProtocol: tcp
    ipRanges:
    - cidrIP: "<IP_ADDRESS>/0"
    fromPort: 61616
    toPort: 61619
  - ipProtocol: tcp
    ipRanges:
    - cidrIP: "<IP_ADDRESS>/0"
    fromPort: 8162
    toPort: 8162

Then reference the Security Group in MQ Broker with vpcSecurityGroupRefs
apiVersion: mq.services.k8s.aws/v1alpha1
kind: Broker
metadata:
  name: "mq-eks-workshop"
spec:
  name: "mq-eks-workshop"
  deploymentMode: SINGLE_INSTANCE
  engineType: ActiveMQ
...
  subnetRefs:
   - from:
        name: "mq-eks-workshop"
  vpcSecurityGroupRefs:
    - from:
        name: "mq-eks-workshop"

Describe alternatives you've considered
The current way is to create the subnet and security group IDs manually or using another method, and then copy the IDs into the resource which begs the purpose of using ACK to compose a complete stack using one method.

Duplicate of https://github.com/aws-controllers-k8s/community/issues/1507


[network path] Add reverse_dns_hostname field

What does this PR do?
[network path] Add reverse_dns_hostname field
Naming: using reverse_dns_hostname field name for consistency with netflow https://github.com/DataDog/datadog-agent/blob/b6a59f4fb6e2ee418f4e18b58d75cd30093e42a5/comp/netflow/payload/payload.go#L27
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


Missing authN attributes in CAS validation payload

The authentication attributes are not passed back to the client, if there are no principal attributes. This is because the predicate that checks for the attribute collection size only looks at principal attributes and does not consider authentication attributes.

handled by #843


Add PCA-Kmeans-Workflow_v1.1_NM.ipynb

Main changes:

Streamlined saving figures + data
PCA plots and PC score plots now pull elements from column names (no manual entry)
User input overall minimized
Now calculates explained variance % for each PC

Thanks Nick for your help improving this workflow. Note that I've also continued working on this in parallel (for another manuscript), so it will be useful to merge the useful changes between the two workflows. For that, you might want to take a look to the notebook  "Rice etal Major Oxides PCA and kmeans clustering - Appendix C.ipynb" in my PythonCodes repository.


additional tests for redeem rewards

Issue Number

Overview

34f17f2237b562634ad3015eb03d9f1390382243
additional tests for redeem rewards

ef15832b62b3cd341356d9a45ca01dd768eaf658
Add more reward wallets

85a07e7042ae3c940366827907f879358de07391
Additional cases to cover not enough fee and not enough money on withdrawals

Comments
in progress...

after running only redeem test suits it happened to take 744 seconds to finish. I trimmed edge cases as they could be in the next PR put on unit test level. Also changed titles in some test to better convey message and nature of tests. After trimming the testsuites halved in time execution

bors r+


Add synonym 'Treg' for term CL:0000815

I believe "Treg" should be an EXACT synonym for CL:0000815 (regulatory T cell)

"Treg" is already an exact synonym of CL:0000815.  Closing now.


新注册的微信号不能登录Web有解吗？

实名认证、银行卡认证、消费记录、朋友圈之类的多搞搞，电脑端挂机，应该很快能登录。

一直用的老账号，新注册的太麻烦各种认证的没试过
On Fri, Oct 13, 2017 at 9:49 AM, mapleflow<EMAIL_ADDRESS>wrote:

实名认证、银行卡认证、消费记录、朋友圈之类的多搞搞，电脑端挂机，应该很快能登录。
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/trazyn/weweChat/issues/55#issuecomment-336327922, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABsVMlQm5zZvandTSoYbNqZ7DM07WUMHks5srsGsgaJpZM4P2ysK
.


Solution import with Canvas App fails with error 'CanvasApp import: FAILURE: No file with that name found'

We're using the Power Platform Github Actions for our ALM processes, which I understand are wrapper around the PAC CLI.
The 'import-solution' action is failing currently with the following error:
The reason given was: CanvasApp import: FAILURE: No file with that name found   Microsoft PowerPlatform CLI   Version: 1.28.3+g4ba7dfd
The command which fails via Github Actions is:
Calling pac cli inputs: solution import --path D:\a\....solution_managed.zip --async true --force-overwrite true --publish-changes false --skip-dependency-check false --convert-to-managed false --max-async-wait-time 60 --activate-plugins true --skip-lower-version false --import-as-holding true --settings-file .....\deploymentsettings.json
Our commit process involves invoking the following commands via Github Actions (all of which succeed and do not unpack Canvas Apps)
Calling pac cli inputs: solution export --name solution --path D:....\solution.zip --overwrite true --managed false --async true --max-async-wait-time 60
Calling pac cli inputs: solution export --name solution --path D:\.....\solution_managed.zip --overwrite true --managed true --async true --max-async-wait-time 60
Calling pac cli inputs: solution unpack --zipFile D:\....\solution.zip --folder D:.....\solution --packageType Both --errorlevel Info --singleComponent None --useLcid false --useUnmanagedFileForMissingManaged false --disablePluginRemap false --allowDelete true --allowWrite true --clobber true
Calling pac cli inputs: solution unpack --zipFile D:\.....\solution.zip --folder D:\.....\solution --packageType Both --errorlevel Info --singleComponent None --useLcid false --useUnmanagedFileForMissingManaged false --disablePluginRemap false --allowDelete true --allowWrite true --clobber true
Our build process involves invoking the following commands via Github Actions (all of which succeed and do not repack Canvas Apps)
Calling pac cli inputs: solution pack --zipFile /home/runner/work/....../solution.zip --folder /home/runner/work/...../solution --packageType Both --errorlevel Info --singleComponent None --useLcid false --useUnmanagedFileForMissingManaged false --disablePluginRemap false
All of this setup was working fine until yesterday
Looking at this response on a similar issue on the Community forum, it looks like someone resolved this by using version 2 of the corresponding Azure DevOps Power Platform Build Tools. I've verified that I'm using the latest available version of the corresponding Github Action but this hasn't resolved the issue.
Originally posted here but reposting in this repository as I'm using Github Actions

Same here !
Neither local pac cli is work or github action
I tried to zip the unpacked code locally via pac cli
pac solution pack --zipfile solution_unmanged.zip --folder solution

Microsoft PowerPlatform CLI
Version: 1.29.11+g9e2b163

Error: Cannot find required file AdditionalUris0_identity.json
Same meta.xml file as mentioned in the community forum.
  <AdditionalUris>
    <AdditionalUri>/CanvasApps/solution_AdditionalUris0_identity.json</AdditionalUri>
  </AdditionalUris>

I have been able to reproduce this issue and a bug has been filed for the engineering team.

can you try forcing the action to use 1.29.11 version of pac cli and try?

Thanks @gavenkat78. I hadn't even realised this was an option. Perhaps I ought to check the action definitions more closely! I'll give this a try now

Thanks @gavenkat78. Just to confirm that your suggestion has resolved the issue for us for now. We are using it as a temporary workaround until a new version of the Github Actions are available from Microsoft with the permanent fix.

Thank you @parvezghumra for confirming.


Add warning when dev dependencies are found

Idea got thanks to @jakzal: when a PHAR is being build with Box and a dev dependency is found, a warning should be given to the user. Indeed there is zero benefit to include them and on the contrary it's more dangerous than anything. Just to give a few reasons:

They are useless
It increases the PHAR size
This may have a performance impact when running the PHAR
It has a performance impact on the building time (as they are more files...)
You potentially open a vector of attack as dev dependencies are not always built with security in mind (and neither should they be: they are meant for dev not production)

Just exclude all of those during generation? https://github.com/MacFJA/PharBuilder does that successfully, but keeps files in "autoload": { "files": [...] }, so it doesn't have to modify the autoloader.

Yes I saw that and was thinking of something similar.
I'm still now entirely sure how to apply though. Unlike in PharBuilder you declare your own finders. Maybe making use of the blacklist?
Also reading the composer.json file is not a trivial decision either as it implies to know where the composer.json file is. But I think that can be ok as we'll kind of need that anyway for PHP-Scoper as after scoping the files it is required to dump the autoloader again.

Another thing to note is that there is a lot more possible locations for tests, for example codeception, phpspec or behat tests are not under tests.