Best-practice advice for threading

I'm looking for some advice about how to manage threading within a dynamic Filament application. A good example would be an app where objects are loaded progressively and displayed to the user as they become available with the minimum of judder.
I understand the general principle that calls to the Filament API must be done on a dedicated single thread and that the actual rendering is done on background threads that Filament manages and that clients of the API don't need to worry about.
This decoupling means that calls to the Filament "render" methods don't take very long, but it also means that this thread must be available promptly whenever a new frame is required. This implies that any load-related tasks that also need to run on the Filament thread must be shorter than the frame time or the app will judder.
With this in mind my app creates a single thread for Filament that is available to both the render loop and the loader (it's implemented using Kotlin coroutines and newSingleThreadContext, but the principles would be the same regardless). The load process is then a sequence of small, granular tasks submitted to the Filament thread: e.g. create a vertex buffer, create a material instance, etc...
Heavy things like bitmap loading are done on background threads and then the actual texture instantiation is done on the Filament thread. Obviously the more I can do on the background threads the better, so that brings me to my first actual question: Is it safe to call any Filament methods from other threads or is any cross-threaded intrinsically unsafe?
I would also welcome any general advice or observations about my approach. The highly granular tasks work, but I suspect the context switching incurs a significant overhead. In the past I've used a queue of pending jobs that are checked as part of the render loop, which eliminates the context switching, but is a bit indirect (coroutines are much neater) and still requires some sort of timer so it can bail if the frame time is exceeded.

You shouldn't worry about context switches, Filament uses more than 2 threads.
It is not safe to call Filament APIs from other threads, they just all be called from the same thread.
What you should do is load meshes, bitmaps, etc. on a background thread and using a work queue or coroutines (pinned to a single thread) pass the loaded data to the thread that will talk to the filament APIs.
Filament APIs are designed to return quickly (all they do is basically send commands to the render thread) so if you do it this way you shouldn't have to worry about missing frames.
render() is pretty much the only function that takes time but its execution is heavily multithreaded.

You can call filament APIs from different threads only if you provide the synchronization externally. We're not relying on thread-local storage for instance.
Only Renderer.render() must be called on the main filament thread (but that's only because we have an assert() trying to catch bad behaved apps).
I would not recommend going down that road though, I don't think there is much to gain.
The main reason filament APIs can't be called from multiple threads (for instance, you can't call APIs of say Texture and VertexBuffer on different threads) is because these APIs, under-the-hood write into a command queue which is not synchronized. So the mental model you need to have is that calling Filament APIs all write into an unsynchronized queue.
Hope this helps.

@romainguy @pixelflinger This info makes things much clearer for me - thank you.


Extend AbstractExtension instead of using Twig_Extension

Twig_Extension is deprecated and to remove twig/extensions this needs to go

Sonata admin officially migrated to runroom-packages/sortable-behavior-bundle, try it instead.
https://symfony.com/bundles/SonataAdminBundle/current/cookbook/recipe_sortable_listing.html

Thanks for letting me know @dmitryuk


Support the browser platform?

Hi i was wondering is it possible to support to Browser platform to have live HMR in the browser
The emulators are very slow on my machine and having this working in the browser would be perfect!

Hi @MichaelPeterJoyce ,this plugin does not support livereload in the browser.
I will work to support the browser platform as soon as possible!
I'll report here if there is any progress.

Hi @MichaelPeterJoyce !
I just committed to add support for LiveReload (HMR).
Please try the following.
Install the latest plugin for the develop branch.
$ cordova plugin add https://github.com/kotarella1110/cordova-plugin-webpack.git#develop
or
$ cordova plugin add git@github.com:kotarella1110/cordova-plugin-webpack.git#develop

Execute the commands.
$ cordova run browser -- --livereload
or
$ cordova run browser -- -l

If it works well, I would like to publish to npm.

Earlier, v0.4.0 was released.
Therefore, please install the plugin from npm.
$ cordova plugin add cordova-plugin-webpack

Hi thanks for the update! I have checked it out but unfortunately i can't get the live reload working in the browser.
I see when i run cordova run browser -- -l there are two servers running

webpack-dev-server on port 8080
cordova browser static file server running on port 8000

I can't access my application via 8080 because of its heavy use of cordova.js because webpack-dev-server doesn't inject the cordova dependency then my app won't load and the deviceready event is never fired because cordova is never loaded.
If i access the app via port 8000 on the local cordova browser server then everything works fine because cordova.js is injected and the deviceready event is fired but there is no hot module reloading working
Hopefully this makes sense
Thanks again

Nevermind the above i didn't realize i needed to update my <meta http-equiv="Content-Security-Policy" to allow the injection of the script.

How did you update your Content Security Policy?
For our reference, please let us know.

This seems to be working but it doesn't inject any of the plugins.
Is there anyway you can make it inject the plugins like the browser platform?

The cordova.js file is loaded by this plugin depending on the platform as follows:

Browser (Desktop): platforms/browser/platform_www/cordova.js
Android device (Browser and WebView): platforms/android/platform_www/cordova.js
iOS device (Browser and WebView): platforms/ios/platform_www/cordova.js

However, the mobile browsers needs to load the platforms/browser/platform_www/cordova.js file as follows:

Browser (Desktop and Mobile device): platforms/browser/platform_www/cordova.js
Android device (WebView only): platforms/android/platform_www/cordova.js
iOS device (WebView only): platforms/ios/platform_www/cordova.js

This fix needs to be able to detect mobile browser or WebView.
I confirm when this fix is possible or not.
Thanks.

Earlier, v0.4.1 was released.
Therefore, please install the plugin from npm.
$ cordova plugin add cordova-plugin-webpack

Hi
When I try this $ cordova run browser -- -l  I've got error:
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type object
    at validateString (internal/validators.js:125:11)
    at Object.basename (path.js:1149:5)
    at module.exports (/home/mehdi/Projects/MajdAb/Measurement/mobile_app/sanjesh_app/cordova/node_modules/rechoir/lib/extension.js:7:23)
    at Object.exports.prepare (/home/mehdi/Projects/MajdAb/Measurement/mobile_app/sanjesh_app/cordova/node_modules/rechoir/index.js:11:14)
    at Object.exports.webpackConfig (/home/mehdi/Projects/MajdAb/Measurement/mobile_app/sanjesh_app/cordova/plugins/cordova-plugin-webpack/src/utils/webpackHelpers.ts:32:11)
    at Object.<anonymous> (/home/mehdi/Projects/MajdAb/Measurement/mobile_app/sanjesh_app/cordova/plugins/cordova-plugin-webpack/src/webpackServe.ts:29:71)
    at step (/home/mehdi/Projects/MajdAb/Measurement/mobile_app/sanjesh_app/cordova/plugins/cordova-plugin-webpack/scripts/webpackServe.js:43:23)
    at Object.next (/home/mehdi/Projects/MajdAb/Measurement/mobile_app/sanjesh_app/cordova/plugins/cordova-plugin-webpack/scripts/webpackServe.js:24:53)
    at /home/mehdi/Projects/MajdAb/Measurement/mobile_app/sanjesh_app/cordova/plugins/cordova-plugin-webpack/scripts/webpackServe.js:18:71
    at new Promise (<anonymous>)

Hi @mese79 ! Did you create webpack configuration file (webpack.config.js)  in your project root folder (/home/mehdi/Projects/MajdAb/Measurement/mobile_app/sanjesh_app/cordova)?
You can also use --webpackConfig or -w option.
$ cordova run browser -- -w path/to/dir/webpack.config.js -l

If your problem persists, It seems that your problem has nothing to do with this issue, so please attach the code and  open a new issue.
Thanks.

Ok, I see.
I thought it would work without webpack.config.js.
Thanks.

@MichaelPeterJoyce Did you solve this problem?

Closing due to inactivity. Reopen as needed.

Sorry i was on Holidays.
This works now on the browser platform! YEY but CPU usage is crazy it sticks at 100% CPU usage and all my fans in 2019 iMac spin at 100% this doesn't happen if i run webpack-dev-server manually is there something that you can look at while running the browser platform for CPU usage?
In regards to the Content-Security-Policy above i needed

@MichaelPeterJoyce Sorry, I haven't noticed your post.

This works now on the browser platform! YEY but CPU usage is crazy it sticks at 100% CPU usage and all my fans in 2019 iMac spin at 100% this doesn't happen if i run webpack-dev-server manually is there something that you can look at while running the browser platform for CPU usage?

Please tell me the process that is running over 100% CPU usage.
Isn't the process Code Helper (VSCode)?
This problem occurs even if you are not using this plugin.

In regards to the Content-Security-Policy above i needed

Thanks!


Formatting and navigation

1. line 155: incorrect formatting for hour
print("[*] the share war will continue in {} minutes...current time: {}".format(int(random_loop_time/60), time.strftime('%l:%M%p %Z on %b %d, %Y')))

Should be:
print("[*] the share war will continue in {} minutes...current time: {}".format(int(random_loop_time/60), time.strftime('%I:%M%p %Z on %b %d, %Y')))

2. line 78: The users username should be used in place of poshmark_email in order to properly navigate to the sellers page
seller_page = "https://poshmark.com/closet/{}?availability=available".format(poshmark_email)

Hi @janellebakey, thanks for noting these issues! Both have now been resolved.


HOSTEDCP-1273: Added support for OLM Disable default sources on HC creation

manual backport of https://github.com/openshift/hypershift/pull/3320, Because Agent GA version is 4.14

/test e2e-kubevirt-aws-ovn

@LiangquanLi930 this needs a rebase now :(

/close


Error on python3.8

✖ python3.8 monthly-report.py
Traceback (most recent call last):
  File "/home/william/.local/lib/python3.8/site-packages/requests/models.py", line 971, in json
    return complexjson.loads(self.text, **kwargs)
  File "/home/william/.local/lib/python3.8/site-packages/simplejson/__init__.py", line 525, in loads
    return _default_decoder.decode(s)
  File "/home/william/.local/lib/python3.8/site-packages/simplejson/decoder.py", line 370, in decode
    obj, end = self.raw_decode(s)
  File "/home/william/.local/lib/python3.8/site-packages/simplejson/decoder.py", line 400, in raw_decode
    return self.scan_once(s, idx=_w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "monthly-report.py", line 137, in <module>
    main()
  File "monthly-report.py", line 41, in main
    categories = s.get(url).json()
  File "/home/william/.local/lib/python3.8/site-packages/requests/models.py", line 975, in json
    raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

The JSONDecodeError: Expecting value error suggests that this is an authentication issue, since firefly-iii is sending an empty response.


DROP SERIES on newly created series fails with "database not open"

DROP SERIES FROM measurement WHERE tag filters
gives error database not open in 0.9.0 stable
example:
curl -G http://localhost:8086/query --data-urlencode "q=CREATE DATABASE mydb"

curl -i -XPOST 'http://localhost:8086/write?db=mydb' -d 'cpu,host=server01 value=0.64'

curl -G 'http://localhost:8086/query' --data-urlencode "db=mydb" --data-urlencode "q=drop series from cpu where host='server01'"

gives error:
{"results":[{"error":"database not open"}]}

This appears to be related to it being a new database or a new series. I suspect there's a metadata race going on.
When I do the query against an established measurement it works fine:
name: slashy
------------
_key					tag
slashy,tag=123\ 456			123 456
slashy,tag=123\,456			123,456
slashy,tag=123\\456			123\\456

> drop series from slashy where "tag" = '123 456'
> show series
name: slashy
------------
_key					tag
slashy,tag=123\,456			123,456
slashy,tag=123\\456			123\\456

When I do it on a new measurement it fails:
> use mydb
Using database mydb
> insert cpu1,host=server01 value=0.64
> select * from cpu1
name: cpu1
tags: host=server01
time				value
----				-----
2015-06-22T19:53:28.009594867Z	0.64

> drop series from cpu1 where host = 'server01'
ERR: database not open

Noticed similar issue.
If you start a continuous query that writes into a measurement, but then drop that measurement you get the same database not open error.
CREATE CONTINUOUS QUERY "10m_cpu_count" ON telegraf BEGIN SELECT count(value) INTO "telegraf"."default".idk FROM "telegraf"."default".cpu_user GROUP BY time(10m) END

> show measurements
name: measurements
------------------
name
cpu_idle
cpu_nice
cpu_system
cpu_user
disk_free
disk_inodes_free
disk_inodes_total
disk_inodes_used
disk_total
disk_used
idk

then
> drop measurement idk
ERR: database not open

but the measurement is actually gone
> show measurements
name: measurements
------------------
name
cpu_idle
cpu_nice
cpu_system
cpu_user
disk_free
disk_inodes_free
disk_inodes_total
disk_inodes_used
disk_total
disk_used

I also experienced this when using influxdb 0.9.1 stable

I confirm that I incurred in the same problem by creating a new series and deleting it straight away.

I encountered the same issue in one of my projects while evaluating the influxdb.
Any idea when this could be fixed?

@mayudong07 it's currently scheduled for the upcoming release on August 13th, although it might not be in that release. If you are evaluating InfluxDB, please upgrade to the latest. 0.9.2 has substantial improvements over 0.9.1, and that will be true for each of the minor releases in the 0.9 line.

+1 for influx 0.9.2 - I tried to use to truncate database in my unit tests.

@jacekgrzybowski for unit test truncation, DROP MEASUREMENT should work quite well.

For me it doesn't work with not-so-new series too.
I have series created 5 days ago and I'm not able to delete them.

@AlexeyDmitriev can you provide the output from the CLI or curl? Otherwise there's nothing useful for us in the report.

@beckettsean the error in CLI is exactly the same as was mentioned above.
ERR: database not open

@AlexeyDmitriev can you provide the full CLI session, showing the DROP SERIES command? I want to make sure there are no syntax issues, although it doesn't sound like there are.
Have you previously dropped and recreated the series?

+1

use metrics
Using database metrics
drop series  where host='test_com'
ERR: database not open

influxdb version:0.9.3

Confirming that for any DROP SERIES command I now get ERR: database not open.
However, this appears to be fixed in 0.9.4:
> show series
name: "test"
------------
_key		foo
"test",foo=bar	bar

name: instance
--------------
_key					host		region
instance,host=server01,region=us-west	server01	us-west

> drop series where host='server01'
> show series
name: "test"
------------
_key		foo
"test",foo=bar	bar

>

thanks ,i will try influxdb 0.9.4

still not working on <IP_ADDRESS>
I have user:pass on my db. user have all the privileges.
/opt/influxdb/influx -username **** -password ****
Connected to http://localhost:8086 version <IP_ADDRESS>
InfluxDB shell <IP_ADDRESS>

show databases;
use dbname
Using database dbname
DROP SERIES FROM measureme WHERE data='testdata'
ERR: database not open

@kaoruu does the database drop the series or is the error output all that happens?

hi @beckettsean based on the result, in CLI, it does not drop the series. As for the API, it does drop the series, but still show the "database not open". These errors do not show if there is no authentication based on my tests.

Hi,
+1
I just made a unit/integration test for the InfluxData.Net library and tested it with v0.9.6 and I'm getting the "database not open" error (the library uses the line protocol). In my case the series also does not get dropped. If I go to the web administration and try to drop, the same thing happens (this is actually logical because as far as I can see the administration also uses the line protocol). After I restart the daemon I can execute the drop and it responds with success.

Hi @beckettsean I am also facing the same issue on version 0.9.4 while creating a measurement and then deleting it, even after waiting for a more than minute to drop the measurement  "database not open" error appears. Is this issue fixed in other versions?

The 0.9.x series is outdated. Please try this on the latest version and open a new issue if it still isn't working. Thanks!


Support return filtering of las files.

Liblas has some support for filtering returns in las files which may be useful in some situations.  We should get an example data set and experiment with this.

Liblas is no longer developed. We still use it though for point2las but hope to transition to PDAL one day.
PDAL has an entire filtering pipeline. https://pdal.io/stages/filters.html
It is probably best ASP clouds are converted to LAS with point2las, then filtered in PDAL. That toolset can create DEMs too, btw, or the las file can be brought back to ASP for further processing.


adding elastic search to preview

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-6916
Change description
Adding elastic search to preview
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Closing this PR while we figure out whether this will cause us to exceed our CPU/memory quota limit on the preview cluster. This PR would be very useful to reduce dependency on the demo environment, but we also need to be careful.
Closing while we hold further discussions.


mesh.plot error on Ansys Lab

Before submitting the issue

[X] I have checked for Compatibility issues
[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
mesh.plot(field) on Ansys Lab throws a
pv_pythreejs.py
--> 118 return pv.wrap(table.MapScalars(scalars, 0, 0))[:, :3]/255
"TypeError: ambiguous call, multiple overloaded methods match the arguments"
Steps To Reproduce
On Ansys Lab, create a field and use
mesh.plot(field)
Which Operating System are you using?
Windows
Which Python version are you using?
3.7
Installed packages
Unknown

Hi @jleonatti, creating an Issue here.
Would it be possible for you to list the packages installed, the Python version... etc?
I have yet to familiarize with the configuration of Ansys Lab.
I will also update the bug issue template to enable Ansys Lab-related choices in the form.

Thanks for this @PProfizi. The DPF packages installed on Ansys Lab from executing pip list show:
ansys-dpf-core                         0.5.1
ansys-dpf-gate                         0.1.0
ansys-dpf-post                         0.2.2
ansys.grpc.dpf                         0.5.0

Thank you @jleonatti.
I remember hearing you would prefer installing via pip?
One first thing we could try is installing the latest versions of each package. Is that possible?
The ansys-dpf-core 0.5.1 version dates back a little.
ansys-dpf-core 0.5.2
ansys-dpf-gate 0.1.2
ansys-dpf-post 0.2.3
ansys.grpc.dpf 0.5.2

@PProfizi I can try out upgrading the packages. I will let you know when I have tested it.

I upgraded all the dpf packages with the following:
pip install --upgrade ansys-dpf-core
pip install --upgrade ansys-dpf-gate
pip install --upgrade ansys-dpf-post
pip install --upgrade ansys-grpc-dpf

Now the packages have been updated (and one added):
ansys-dpf-core                         0.5.2
ansys-dpf-gate                         0.1.2
ansys-dpf-gatebin                      0.1.2
ansys-dpf-post                         0.2.3
ansys-grpc-dpf                         0.5.2

I am seeing a different issue now with the same Average Elemental Stress template:

Any ideas here?

Hi @jleonatti, I see your path is /mnt/ansys_inc/v212, are you using ANSYS R212?

Hi @jleonatti, we forgot to send you an update when we released our last version of python.
We changed our default configuration to in process (meaning that be default, when possible, we don't use gRPC to communicate between python and DPF), so when we try to locate a server or to load DPF in process, we first look for a local install of DPF, and it looks like you have either an AWP_ROOT variable on your client image or/and an install /mnt/ansys_inc/.
To fix this issue, you can either remove the 2 mentioned things above or set the environment variable DPF_SERVER_TYPE=GRPC on your client image

Hi @cbellot000, okay thanks for letting me know. I set the environment variable you specified. Thanks!

That fixed the issue. I will work to upgrade the DPF packages and add this environment variable to our Ansys Lab image. Thanks!

With a new image that contains upgraded dpf packages and the DPF_SERVER_TYPE=GRPC running on the cluster, I am see a new error in the notebook:
File /opt/conda/lib/python3.9/site-packages/ansys/dpf/gate/generated/scoping_capi.py:89, in ScopingCAPI.scoping_get_ids_for_dpf_vector(scoping, out, data, size)
     87 res = capi.dll.Scoping_GetIds_For_DpfVector(scoping._internal_obj, out._internal_obj, utils.to_int32_ptr_ptr(data), utils.to_int32_ptr(size), ctypes.byref(utils.to_int32(errorSize)), ctypes.byref(sError))
     88 if errorSize.value != 0:
---> 89 	raise errors.DPFServerException(sError.value)
     90 return res

DPFServerException: failed to GetIds for scoping

I am attaching the output of the notebook as html in the zip.
02-volume_averaged_stress_1.zip
You can try it out for yourselves on https://jupyter.dev.ansysapis.com/ and select the APOD dev image (dev2) image and then run the Average Elemental Stress example.


AF.upload(multipartFormData...,  responseSwiftyJSON can  success, but uploadProgress no callback

[x] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?
func uploadImage(_ image: UIImage,
compressionQuality: CGFloat? = nil,
callback: @escaping (_ urlDict: JSON?, _ error: NSError?) -> Void) {
    guard let url = URL(string: self.uploadURL), let scheme = url.scheme, let host = url.host else {
        fatalError("Invalid upload url")
    }

    let qualityParam = parameters?["quality"] as? CGFloat
    var compressRate: CGFloat = qualityParam ?? 0.9
    if let quality = compressionQuality {
        compressRate = quality
    }

    var data = image.jpegData(compressionQuality: compressRate)

    if data == nil {
        UIGraphicsBeginImageContext(image.size)
        image.draw(in: CGRect(x: 0, y: 0, width: image.size.width, height: image.size.height))
        let newImage = UIGraphicsGetImageFromCurrentImageContext()
        UIGraphicsEndImageContext()
        data = newImage!.pngData()
    }
    let createFormData = { (formData: MultipartFormData) in
        if let parameters = self.parameters {
            for (key, value) in parameters {
                formData.append(String(describing: value).data(using: .utf8)!, withName: key)
            }
        }

        formData.append(data!,
                        withName: self.serverCode == 3 ? "file" : "uploadFile",
                        fileName: "image.jpg",
                        mimeType: "image/jpeg")
    }

    var referer = URLComponents()
    referer.scheme = scheme
    referer.host = host

    var headers = ["Referer": referer.url!.absoluteString]
    if self.serverCode == 3 {
        headers["XXX-TOKEN"] = xxx
    }
    let uploadRequest = AF.upload(multipartFormData: createFormData,
                                  to: url,
                                  method: .post,
                                  headers: HTTPHeaders(headers))
        .uploadProgress(queue: .main) { progress in
            dPrint("progress=== \(progress)")
    }

    uploadRequest.responseSwiftyJSON {[weak self] json, error in
        dPrint("responseSwiftyJSON can success")
    }
}

What did you expect to happen?
uploadProgress can callback
What happened instead?
uploadProgress no callback
Alamofire Environment
**Alamofire Version: 5.5.0
Dependency Manager:
Xcode Version: 14.3
Swift Version: 5.0
Platform(s) Running Alamofire:
**macOS Version Running Xcode: macOS Ventura 13.3.1

Progress updates are provided by URLSession and are not guaranteed, especially for small or fast uploads. In addition to Alamofire's methods you could try using KVO on the underlying task's progress property, but that should give you the same values (or nearly so) as the delegate method Alamofire hooks into. Otherwise, you can investigate SessionDelegate and see whether open func urlSession(_ session: URLSession, task: URLSessionTask, didSendBodyData bytesSent: Int64, totalBytesSent: Int64, totalBytesExpectedToSend: Int64) is getting properly called without it being relayed to the correct Alamofire request.

おめでとう

@jshier did you get it fixed?

So far there's no evidence there's anything to fix. URLSession doesn't seem to guarantee any particular granularity to the upload progress and may skip it altogether for small files. I'll see if I can create an experiment with the test server though.

So far I've been able to confirm that, no matter how much data you're uploading, if it's uploaded fast enough there will be no progress callbacks except the last completion value (as long as your request meets the base criteria). I'm still looking for a way to control the rate at which the server accepts upload data in the first place to test what kind of speed is necessary to get upload progress, but for now Alamofire is operating exactly as expected.

@jshier  It used to work for a project but we have updated pods like a month ago.  But there have been no changes to this handling in quite a while.

@jshier I can't see any changes of Alamofire in the commit. It's so weird because everything works well with oldest commits :(

@jshier we can have a call if you would like and you can get some details you need

Sounds like a bug on your side. Please investigate on your side and report a changes in Alamofire behavior. There shouldn't be any. URLSession is opaque, so changes to iOS or SDK version may impact things in a way that's not otherwise visible.

I created a local test that streams bytes rather slowly and was able to confirm Alamofire processes upload progress correctly. At the same time it seems like URLSession on macOS 13.5.1 has a progress granularity of around 100ms, so anything that uploads faster than that won't have progress. There may be other heuristics it uses to determine whether or not to issue progress callbacks, but that seems to be the simplest one.
Upload sent: 570, total: 570 / 5700
Uploaded 10%
Upload sent: 513, total: 1083 / 5700
Uploaded 20%
Upload sent: 513, total: 1596 / 5700
Uploaded 30%
Upload sent: 513, total: 2109 / 5700
Uploaded 40%
Upload sent: 513, total: 2622 / 5700
Uploaded 50%
Upload sent: 513, total: 3135 / 5700
Uploaded 60%
Upload sent: 513, total: 3648 / 5700
Uploaded 70%
Upload sent: 513, total: 4161 / 5700
Uploaded 80%
Upload sent: 513, total: 4674 / 5700
Uploaded 90%
Upload sent: 513, total: 5187 / 5700
Upload sent: 513, total: 5700 / 5700
Uploaded 100%
(lldb) po uploadProgressValues
▿ 11 elements
  - 0 : 0.1
  - 1 : 0.19
  - 2 : 0.28
  - 3 : 0.37
  - 4 : 0.46
  - 5 : 0.55
  - 6 : 0.64
  - 7 : 0.73
  - 8 : 0.82
  - 9 : 0.91
  - 10 : 1.0

So I don't think there's anything for Alamofire to do here.


Download PDF with all reservations and other information

I think this is different from #502 when it comes to the time period. Maybe #502 was for the given day, but this was for a longer time period. Should probably ask more about this.
Lyche also wanted to be able to download a PDF with relevant information for the kitchen, mainly how many people/tables at given time.

See close reason for #502


File added for "Japan Digital Universtiy"

@NodirXakimov First stage of verification passed, official domain is jdu.uz as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

Thanks for attention!

@NodirXakimov Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Skyline/work/20210427 cp bug fixes

Cherry-pick Matt's bug fixes from master to the 21.1 branch before making a Skyline-daily release

I wanted the settings clearing fix in the Skyline-daily release I will use for the May Institute sessions next week, which I need to get out and get people installing today.


Exception on Start - Win 10 / Outlook 2016

Hi,
i really love you app, but since a few days I get the attached error Message.

I'm using Windows 10 Version 1607 (Build 14393.1198) and Office 2016 Version 1703 (Build 7967.2161).
Is there any log that i can deliver?
Thank you for your help!
Regards,
Manuel

Take a look at the FAQ:  https://outlookonthedesktop.com/faq
there's some suggestions to try to fix your Office installation.


8.x pre-release breaks plugins

The recent pre-release of 8.0.0a1 proved that it breaks at least https://github.com/click-contrib/click-help-colors/issues/12 as I had jobs testing pre-releases.
Expected Behavior

even pre-releases need release notes, https://github.com/pallets/click/releases has no description -- as a hint, you could make use of release-drafter which populates the description on merges building really useful release notes without extra human help

if breaking changes are made, you should better deprecate them first, or it will alienate most click users and plugin writers making much harder to upgrade.

Actual Behavior
Tell us what happens instead.
  File "/home/runner/work/molecule/molecule/.tox/eco/lib/python3.8/site-packages/click_help_colors/decorators.py", line 6, in <module>
    from click._compat import iteritems
ImportError: cannot import name 'iteritems' from 'click._compat' (/home/runner/work/molecule/molecule/.tox/eco/lib/python3.8/site-packages/click/_compat.py)
ERROR: InvocationError for command /home/runner/work/molecule/molecule/.tox/eco/bin/molecule --version (exited with code 1)```

### Environment

* Python version:
* Click version: 8.0.0a1

The changelog can always be found in the docs: https://click.palletsprojects.com/en/master/changelog/#version-8-0
It looks like that extension was relying on something in _compat. That module was never public and was never intended to be used by external code. It has been removed now that Python 2 support has been removed, as the code is no longer used. In general for Pallets projects, don't assume anything that isn't documented in the API docs to be public.


Replace the Upcoming Events BitHub embed with Google Calendar integration

The site now uses Google Calendar for the Upcoming Events section of the Community page. Any non-recurring events in the DoneJS calendar will be displayed.
I renamed the components/controls and changed the functionality, but I didn’t spend much time refactoring the code, adding tests, etc. If that’s required before merging this in, I can spend more time on it.
moment-timezone is required as a new dependency because the Google Calendar API provides the dateTime in the calendar’s default timezone (Chicago) and also includes the event timezone. Because there will be mismatches between the calendar’s default timezone and the events’ timezones, we need to calculate the event’s real time based on the difference between Chicago and the event’s timezone.
Fixes #681
Demo:

Why non-recurring events?  Is the only one the contributor meeting?  That might be nice to show up.  Maybe it should only be the "next" contributor meeting.

Coverage remained the same at 96.262% when pulling 73d5c0ec86806de8761729eaa11947384a1ae8f8 on 681-upcoming-events into 6f4fdaaeed80806f37d7dde0990ca7e929e6fd1a on master.

The contributors meeting is the only recurring event right now. Even if we made it so only one contributors meeting would show up, I don’t think it’s worth including because then that’s one less local event we can draw attention to.
To me, that blue section is all about meetups & conferences. If we were to include the contributors meeting anywhere, I think it would make more sense in the dark “Contribute to DoneJS” section below.

Coverage remained the same at 96.262% when pulling 8f9c88c7285eb435bec14ac023d03923cafd652f on 681-upcoming-events into 6f4fdaaeed80806f37d7dde0990ca7e929e6fd1a on master.

Coverage remained the same at 96.262% when pulling 8f9c88c7285eb435bec14ac023d03923cafd652f on 681-upcoming-events into 6f4fdaaeed80806f37d7dde0990ca7e929e6fd1a on master.

@phillipskevin, just FYI you should be able to build the docs locally to see that it works, although when this is deployed I’ll know real quick whether it’s actually working.


Login to signin.convergence-con.org with expired password broken

Signing in returns immediately to the login page.

This is because a whole slew if people had their authentication expire 9/1/2019  and our prompt to change your password is evidently broken.
Emergency averted (pushed expiration date out)
Editing this issue to reflect the bug that needs fixed.

#287


IndexedDB 2.0 features review

Hello TAG!
I'm requesting a TAG review of:

Name: the following IndexedDB 2.0 features

Support for binary keys

interaction with key generators
key extraction for binary keys

IDBObjectStore.prototype.name setter
IDBIndex.prototype.name setter
IDBObjectStore.prototype.getKey
IDBCursor.prototype.continuePrimaryKey previously discussed at http://lists.w3.org/Archives/Public/public-script-coord/2013JulSep/0490.html

Specification URL: IndexedDB 2.0 (Editor's Draft)
Explainer, Requirements Doc, or Example code:

Explainer and example for all IndexedDB 2.0 features
Support for binary keys - requirements
IDBObjectStore.prototype.name setter - requirements
IDBIndex.prototype.name setter - requirements
IDBObjectStore.prototype.getKey - requirements | example
IDBCursor.prototype.continuePrimaryKey - explainer | requirements | example

Primary contacts<EMAIL_ADDRESS><EMAIL_ADDRESS>
Further details (optional):

Relevant time constraints or deadlines: Feb 28 would be ideal, we'd like to ship in Chrome M58
[x] I have read and filled out the Self-Review Questionnare on Security and Privacy. The assessment is here and here.
[x] I have reviewed the TAG's API Design Principles

You should also know that...
We have submitted tests covering all the features above to web-platform-tests. Chrome (with the Experimental Web Platform Features flag) passes all the test cases (159/159). Firefox (nightly) passes over 98.7% (157/159) of the test cases, and Safari (Tech Preview 23) passes over 99.3% (158/159) of the test cases.
Firefox has already shipped all the IndexedDB 2.0 features mentioned above, based on the Editor's Draft specification, in Firefox 51. Safari is about to ship the features above
in Safari 10.1, which is included in the OS X 10.12.4 beta. We (Chrome) have implemented the features under the Experimental Web Platform Features flag, and plan to ship them following this TAG review.
We'd prefer the TAG provide feedback as (please select one):

[x] leave review feedback as a comment in this issue and @-notify @pwnall and @inexorabletash

Please preview the issue and check that the links work before submitting
For background, some decent explainers:
https://github.com/w3c/ServiceWorker/blob/master/explainer.md
https://github.com/zkoch/paymentrequest/blob/gh-pages/docs/explainer.md
https://github.com/WICG/IntersectionObserver/blob/gh-pages/explainer.md (although this one includes IDL, which an explainer should not)

Blunt first pass comments from someone without much background on the design...
Just out of plain curiosity: since binary keys expect the underlying type information to be discarded when stored, would it be a problem if two different array buffers containing the same data at binary level work as the same key?
I'm not sure what the real world implications of this side effect would be (I suspect minimal) but it could in theory be a problem in extreme corner cases.
I've looked at IndexedDB/issues/#22 and the use case behind allowing renaming wasn't noted - what is the use case for this?
I need a bit more time to look at key generators, will post an update soon.

...since binary keys expect the underlying type information to be discarded when stored...

There may be developer confusion that e.g. a Uint8Array and Float32Array consisting of the same backing bytes have the same value as a key. (This was touched on in the linked discussion). This pattern shows up in a few other places in the platform where APIs consume binary data; we eventually converged on the conventions specified in WebIDL's "get a copy of the bytes..." and the BufferSource abstract type. So the platform is consistent, but again there is the possibility of developer confusion.

...use case behind allowing renaming...

Most of the discussion around store/index renaming took place offline, and I failed to capture the intents there. (This also included guidance from @annevk on using setter rather than e.g. setName or anything awkard like that.)
This blog post by @bevis-tseng covers the use cases pretty well: https://hacks.mozilla.org/2016/10/whats-new-in-indexeddb-2-0/

...key generators...

Nothing (intentionally) new with key generators in 2.0 vs. 1.0, although we have identified a spec gap and interop issues with edge cases, discussed at https://github.com/w3c/IndexedDB/issues/147 - more eyes on everything welcome!

Here is a rationale for renaming.
Applications that use the active record pattern have a 1:1 matching between stores and class names, for example Widget instances are persisted in a "widgets" store. When performing a code refactoring that renames the class, it is desirable to be able to rename the store as well, in order to maintain the pattern. Naming is hard, so the engineers of a 2-3-year old app are likely to be able to find a better name for at least one class with persistent instances.
I authored homework submission software that has been used for for 9+ years, and I've renamed a couple of models.

Closed as LGTM as per discussed on 2/22 call.

Per today's discussion, closing this with an "LGTM".
Thanks again to @pwnall for the thoughtful and detailed review request. In future, we'd love to see these features much sooner in the design phase. We don't bite!

Thank you very much for the quick turnaround time!
@slightlyoff Point noted! I'll definitely get in touch sooner when designing features.


MenuItem children are vertically and horizontally centered with parent [2-preview6]

Describe the bug
Seems to be a regression from 2-preview5. Vertical centering issue is upstream in https://github.com/AvaloniaUI/Avalonia/issues/10765 but the horizontal centering may be a separate issue as it only occurs in FA. I get similar horizontal centering in the FluentAvaloniaSamples Menu page built on master (but not on 2-preview5).
<Grid RowDefinitions="auto,*">
    <Menu>
        <MenuItem Header="First">
            <MenuItem Header="First.A" />
            <MenuItem Header="First.B">
                <MenuItem Header="First.B.1" />
                <MenuItem Header="First.B.2" />
                <MenuItem Header="First.B.3">
                    <MenuItem Header="First.B.3.a" />
                    <MenuItem Header="First.B.3.b" />
                    <MenuItem Header="First.B.3.c" />
                </MenuItem>
                <MenuItem Header="First.B.4" />
                <MenuItem Header="First.B.5" />
            </MenuItem>
            <MenuItem Header="First.C" />
        </MenuItem>
        <MenuItem Header="Second">
            <MenuItem Header="Second.A" />
            <MenuItem Header="Second.B" />
        </MenuItem>
    </Menu>
</Grid>

Screenshots

Desktop/Platform (please complete the following information):

OS: Win10
2-preview6
11-preview6

Flyout default position was changed upstream. I had to fix Menu as well: https://github.com/AvaloniaUI/Avalonia/pull/10667


updated createAccount flow

Description

Added a route for verifying accounts that were created by the user without an invite
Updated password validation logic to ensure password and verified password are the same.

Clickup Ticket
CLICKUP_TICKET
Type of change
Delete those that don't apply.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Ran locally and created account

Took the link from email and used  the form locally to set password

Was able to login

Checked a number of password scenarios

password is too short
passwords don't match

Checklist:
Delete those that don't apply. Only apply the final commit message using the changelog when merging a feature to DEVELOPMENT that will be deployed to all users.

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added unit tests that prove my fix is effective or that my feature works
[ ] I have pushed the final commit message using the changelog format

Code looks good, although I'm unable to get to the proper page with the new form. The redirect link brings me to the login page instead of the profile creation form page.


fix selection shrink 🔨

"Shrink selection deselects all"
This commit fixes selection shrink, before the shrink simply deselected all

I probably won't be around, so if this gets approved I will appreciate a merge before the build will be made


1.3.0

Version bump

This change is

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Zabbix 6.4 pos upgrade issue

I recently upgrade our zabbix server to 6.4.1 and everything was running good but after a server reboot i'm now unable to connect to zabbix data source
I receive the error "Invalid params. Invalid parameter "/": unexpected parameter "user"." when a try to connect
Software versions

Grafana
Zabbix
Grafana-Zabbix Plugin

9.4.7
6.4.1
4.2.9

Same problem here.

Grafana
Zabbix
Grafana-Zabbix Plugin

9.4.3
6.4.0
4.3.1

Same problem here. After updating to 6.4.1 the API start returning that error.
"error": {         "code": -32602,         "data": "Invalid parameter \"/\": unexpected parameter \"user\".",         "message": "Invalid params."     },

Hi Guys,
After upgrade the zabbix plugin to version uninstall and install the zabbix plugin the issue is solved. i think for now this is the solution

Hi,
same issue here, version 4.4.0 should fix this issue but it isn't working for me.
@airesalonso do you mean you just uninstall/install the plugin to make it work ?


[Flink AI Flow] No state check before stopping a workflow execution

Describe the bug
When we submit a workflow whose any job contains a periodic config, then we call stop_workflow_execution to stop it. It will work. However, if we submit the workflow again and try to stop all workflow executions of this workflow, we will meet a such error:
Traceback (most recent call last):
  File "/Users/kenken/bella/lib/python3.7/site-packages/airflow/contrib/jobs/event_based_scheduler_job.py", line 624, in _execute
    self._run_scheduler_loop()
  File "/Users/kenken/bella/lib/python3.7/site-packages/airflow/contrib/jobs/event_based_scheduler_job.py", line 643, in _run_scheduler_loop
    should_continue = self.scheduler.schedule()
  File "/Users/kenken/bella/lib/python3.7/site-packages/airflow/contrib/jobs/event_based_scheduler_job.py", line 165, in schedule
    self._remove_periodic_events(event.run_id)
  File "/Users/kenken/bella/lib/python3.7/site-packages/airflow/utils/session.py", line 65, in wrapper
    return func(*args, session=session, **kwargs)
  File "/Users/kenken/bella/lib/python3.7/site-packages/airflow/contrib/jobs/event_based_scheduler_job.py", line 238, in _remove_periodic_events
    self.periodic_manager.remove_task(run_id, task.task_id)
  File "/Users/kenken/bella/lib/python3.7/site-packages/airflow/contrib/jobs/periodic_manager.py", line 109, in remove_task
    self.sc.remove_job(job_id=self._generate_job_id(run_id, task_id))
  File "/Users/kenken/bella/lib/python3.7/site-packages/apscheduler/schedulers/base.py", line 621, in remove_job
    raise JobLookupError(job_id)
apscheduler.jobstores.base.JobLookupError: 'No job by the id of manual__2021-08-04T07:27:52.741875+00:00:evaluate was found'

After diving into the codes, there are 2 reasons of this bug:

In ai_flow_plugins.scheduler_plugins.airflow.airflow_scheduler.AirFlowScheduler def stop_workflow_execution(self, workflow_execution_id: str) method, we do not check the state of the workflow executions during the query.
We do not handle exception correctly in airflow/contrib/jobs/periodic_manager.py:109

To fix the issue, I think we should take actions in above 2 places.
Your environment
Operating system
Macos
Database
MySQL
Python version
3.7.10
To Reproduce
See Describe the bug
Expected behavior
The stop operation should not be applied to stopped executions.
Actual behavior

Screenshots

Additional context

AIFlow has been moved to https://github.com/flink-extended/ai-flow.
Please reopen the issue there if necessary.


Exporting to PDF with repeated images results in very large file sizes

If you use the same image repeatedly (e.g. logo in top corner of every page) then that image is embedded multiple times causing the file size to get very large for long documents. Each image should only be embedded once no matter how many times it is used, is there a way to accomplish this with playwright?

Sorry, out PDF is a result of printing, it does not optimize or dedupe.


ci(master): support os  is linux and darwin and platforms is arm64 and amd64

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind feature
What this PR does / why we need it:
support os  is linux and darwin and platforms is arm64 and amd64
Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

in fact, I use yurtctl  binary more,not use docker image convert it. I think  more platform binary is very necessary.
my fact condition is at my MacBook  build binary is linux/amd64 and linux/arm64 and scp to linux server.
this feature can let user at person computer build the linux binary and scp to linux server.

other Note

@cuisongliu Thank you for raising pull request.
In fact, os=linux and arch=amd64/arm64/arm have been supported now.
@Congrool Would you like to take a look of this pull request?

@cuisongliu Thank you for raising pull request. In fact, os=linux and arch=amd64/arm64/arm have been supported now.
@Congrool Would you like to take a look of this pull request?

Sure.

@cuisongliu , Hi, I saw

this feature can let user at person computer build the linux binary and scp to linux server

I think this will cause some protential problems in golang. We know go build is based on glibc. The binary built based on glibc of Mac may not work on Linux platform. Even between two Linux hosts, it still has the problem for Glibc version incompatibility and other reasons. Maybe it's a typical pratice in Java, but we don't recommand it in Go.
And what do you think? @rambohe-ch
Maybe we can provide a way to build a binary on other platform, but it's not recommended.

I think we can support it . like kubernetes can cross compile.

I think we can support it . like kubernetes can cross compile.

@cuisongliu How does kubernetes solve the glibc incompatibility problem? Is it the responsibility users should take?

@cuisongliu Currently, openyurt support multi-arch cross compilation, and will copy the built binaries into docker images. And the docker image is based on linux. You can see the script here. So I think we should run the openyurt components into containers, and there's no need to support multi-platform.

we use CGO_ENABLED=0  can resolve cross compilation. we use yurtctl  binary better, same kubeadm is not container. because yurtctl binary  file is better.

@cuisongliu So, do you mean we should support cross compliation just for yurtctl?

So, do you mean we should support cross compliation just for yurtctl?

I think like kubernetes , support binary and container. but  we use container is more.

There is really no need to support macOS.

I think like kubernetes , support binary and container. but we use container is more.

How does kubernetes run barely on host OS? As far as I know, only kubeadm, kubectl and kubelet run on host os.
I agree with support multi-platform cross compilation of yurtctl, that will enable users built yurtctl of other platform, such as buildting yurtctl linux on Mac.

I think like kubernetes , support binary and container. but we use container is more.

How does kubernetes run barely on host OS? As far as I know, only kubeadm, kubectl and kubelet run on host os. I agree with support multi-platform cross compilation of yurtctl, that will enable users built yurtctl of other platform, such as buildting yurtctl for linux on Mac.

@cuisongliu @Congrool supoort multi-platform cross compilation of yurctl, agree +1.

I think like kubernetes , support binary and container. but we use container is more.

How does kubernetes run barely on host OS? As far as I know, only kubeadm, kubectl and kubelet run on host os. I agree with support multi-platform cross compilation of yurtctl, that will enable users built yurtctl of other platform, such as buildting yurtctl for linux on Mac.

@cuisongliu @Congrool supoort multi-platform cross compilation of yurctl, agree +1. but other components like yurthub, yurt-tunnel etc. we can keep the current state.

yurhub we running on host os 。 hhhh. so , we can support yurctl ,yurthub ,yurt-node-servant , agree it ?

I think like kubernetes , support binary and container. but we use container is more.

How does kubernetes run barely on host OS? As far as I know, only kubeadm, kubectl and kubelet run on host os. I agree with support multi-platform cross compilation of yurtctl, that will enable users built yurtctl of other platform, such as buildting yurtctl for linux on Mac.

@cuisongliu @Congrool supoort multi-platform cross compilation of yurctl, agree +1. but other components like yurthub, yurt-tunnel etc. we can keep the current state.

yurhub we running on host os 。 hhhh. so , we can support yurctl ,yurthub ,yurt-node-servant , agree it ?

@cuisongliu If you want to support other os like darwin, you can add an env(like YURT_BUILD_PLATFORM) so end user can  define the OS and ARCH. and you only need to modify func get_binary_dir_with_arch as following:
get_binary_dir_with_arch(){
     if [ ! -z ${YURT_BUILD_PLATFORM} ]; then
           echo $1/$(YURT_BUILD_PLATFORM)/
     else
          echo $1/$(go env GOOS)/$(go env GOARCH)/
     fi
}

and when you want build yurthub or yurtctl on darwin, you can use make build WHAT=cmd/yurtctl  YURT_BUILD_PLATFORM=linux/amd64 to make linux binary.

I think like kubernetes , support binary and container. but we use container is more.

How does kubernetes run barely on host OS? As far as I know, only kubeadm, kubectl and kubelet run on host os. I agree with support multi-platform cross compilation of yurtctl, that will enable users built yurtctl of other platform, such as buildting yurtctl for linux on Mac.

@cuisongliu @Congrool supoort multi-platform cross compilation of yurctl, agree +1. but other components like yurthub, yurt-tunnel etc. we can keep the current state.

yurhub we running on host os 。 hhhh. so , we can support yurctl ,yurthub ,yurt-node-servant , agree it ?

@cuisongliu If you want to support other os like darwin, you can add an env(like YURT_BUILD_PLATFORM) so end user can define the OS and ARCH. and you only need to modify func get_binary_dir_with_arch as following:
get_binary_dir_with_arch(){
     if [ ! -z ${YURT_BUILD_PLATFORM} ]; then
           echo $1/$(YURT_BUILD_PLATFORM)/
     else
          echo $1/$(go env GOOS)/$(go env GOARCH)/
     fi
}

and when you want build yurthub or yurtctl on darwin, you can use make build WHAT=cmd/yurtctl YURT_BUILD_PLATFORM=linux/amd64 to make linux binary.

fix ci error. approved it . this ci not auto ???

 So it needs approval of maintainers.

You can test your code locally to check if it's correct. Please see the tutorial. CI also runs in this way.

@cuisongliu Oh, sorry, it seems that original build.sh has already supportted cross compliation. See the developer-guide.md.
We can build yurtctl for linux on Mac with command:
GOOS=linux GOARCH=amd64 make build WHAT=cmd/yurtctl

Maybe we just need to add CGO_ENABLED=0 before go build.

/lgtm
/approve


Panic on shutdown in X11: EGL_BAD_DISPLAY in eglDestroyContext

Bevy version
dd15890c6ab415c32a63da0bc05c52abb8ec2f9e
[Optional] Relevant system information
If you cannot get Bevy to build or run on your machine, please include:
cargo 1.75.0
Linux 6.7.3-arch1-2
If your bug is rendering-related, copy the adapter info that appears when you run Bevy.
2024-02-06T12:38:40.591703Z  INFO bevy_render::renderer: AdapterInfo { name: "NVIDIA GeForce RTX 3080", vendor: 4318, device: 8726, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "545.29.06", backend: Vulkan }

You should also consider testing the examples of our upstream dependencies to help isolate any setup-specific issue:
The following does not have the same issue:
cargo run --bin wgpu-examples boids

I also tried running this winit example with no issue.
What you did
cd bevy/examples
cargo run --example animated_fox --features x11

What went wrong
The example runs fine, but on closing the window I see:
2024-02-06T12:40:59.051614Z ERROR log: EGL 'eglDestroyContext' code 0x3008: EGL_BAD_DISPLAY error: In eglDestroyContext: Invalid EGLDisplay (0x59e18f2fc450)

Additional information
I'm using the dwm window manager, and closing the window using a keyboard shortcut.
[rcorre@midgar examples]$ cargo run --example animated_fox --features x11
    Finished dev [unoptimized + debuginfo] target(s) in 0.15s
     Running `/home/rcorre/src/bevy/target/debug/examples/animated_fox`
2024-02-06T12:40:56.768568Z  INFO bevy_winit::system: Creating new window "App" (0v1)
2024-02-06T12:40:56.768814Z  INFO log: Guessed window scale factor: 1.5833333333333333
2024-02-06T12:40:56.912495Z  INFO bevy_render::renderer: AdapterInfo { name: "NVIDIA GeForce RTX 3080", vendor: 4318, device: 8726, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "545.29.06", backend: Vulkan }
Animation controls:
  - spacebar: play / pause
  - arrow up / down: speed up / slow down animation playback
  - arrow left / right: seek backward / forward
  - digit 1 / 3 / 5: play the animation <digit> times
  - L: loop the animation forever
  - return: change animation
2024-02-06T12:40:57.744098Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Linux rolling Arch Linux", kernel: "6.7.3-arch1-2", cpu: "", core_count: "6", memory: "31.3 GiB" }
2024-02-06T12:40:58.982950Z  INFO bevy_window::system: No windows are open, exiting
2024-02-06T12:40:58.984266Z  INFO bevy_winit::system: Closing window 0v1
2024-02-06T12:40:59.051614Z ERROR log: EGL 'eglDestroyContext' code 0x3008: EGL_BAD_DISPLAY error: In eglDestroyContext: Invalid EGLDisplay (0x59e18f2fc450)

From a brief Google search, it appears this is detected by eglGetError which describes EGL_BAD_DISPLAY as:

EGL_BAD_DISPLAY
An EGLDisplay argument does not name a valid EGL display connection.

I have no idea what that means and I couldn't find any more information online.

I am also experiencing this issue on Kubuntu 23.10.

This is caused by https://github.com/bevyengine/bevy/pull/11660.

May be related to https://github.com/gfx-rs/wgpu/issues/2165.

Looks like https://github.com/bevyengine/bevy/pull/11737 fixed this issue! I can no longer reproduce the issue after this PR.

Confirmed #11737 fixed it for me as well. Thanks for the quick fix!


Whether End user can able to modify ?

I am using asus vivobook 15 r542uq-dm153 with bios x542uq.307  .
I was trying to modify the bios with .307 format . Its more complicated to modify , Because  codes and other things are  beyond my knowledge .
Then how can oem can modify the bios firmware.
Is there any common tools to modify bios as per customer needs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 30b19d94-b32a-7358-0419-97e0ed285cbb
Version Independent ID: a7f0973e-6d35-b579-e8e8-682892a8037d
Content: System and device firmware updates via a firmware driver package - Windows drivers
Content Source: windows-driver-docs-pr/bringup/system-and-device-firmware-updates-via-a-firmware-driver-package.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @barrygolden
Microsoft Alias: bagold

Thanks for reaching out to the Windows Driver Developer Documentation team. Unfortunately, we don’t have the resources to offer individual technical advice to the broad array of customers who use the driver documentation.
You may have success posting your question in the following forums, where other driver developers and Microsoft engineers can be found. The community there is quite responsive.
MSDN Windows Hardware WDK and Driver Development forum
NTDEV forum at OSR Online


Feature Request: Abort after X minutes

Hi!
I would be awesome if it was possible to have a feature like -abort-after KB, but for time.
Something like -abort-after-minutes where we can set the amount, like 60 minutes, and after this, the recording is automatically stoped.
This would be an immense help for people like me is trying to record a schedule show, everyday, that has a duration of 60 minutes.
Thanks!

yes, that really would be great. Of course, you can write a wrapper script that terminates the recording after a certain time.

-abort-after-duration option is now in the source

https://github.com/sfuhrm/radiorecorder/releases/tag/v1.7.0


Add URL to the BAD url issue

The remote URL returned an error. Please verify your file is available at that URL.  Might be good to show the BAD url used so that can check it since right now they might not know what was used.

ping! as I don't understand exactly what this means about BAD urls

This was already done in: https://github.com/CartoDB/cartodb/issues/5778


Tab per player?

First, thanks for this excellent piece of work.  I especially appreciate the sleep timer showing up in the web GUI.
I have a feature request - I've long wondered why each player needs to be picked through the drop-down instead of having a tab per player.  Is this something you think would be straightforward to implement in the MUI skin?
Thank you

No, sorry. This would definitely not work for mobile - too cramped. For desktop, the volume, now-playing bar, and eve browse view (as different players can have different modes) would be different per-player.
So, just use different browser tabs.


Set the serviceCluster namespace based on env var, to also support sp…

…ecifying namespace on cli after kubeinject

As requested https://github.com/istio/istio/pull/11521#issuecomment-461148654, this change is being applied to 1.1 branch.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: objectiser, ymesika
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [ymesika]
pilot/OWNERS [ymesika]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ymesika Any idea why the tests are waiting? Do you need to indicate "oktotest"?

Sometimes they get stuck. Try pushing a rebase to reset them.

@objectiser: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests
/test istio-integ-k8s-tests

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio-pilot-multicluster-e2e

prow/e2e_pilotv2_auth_sds.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio-pilot-multicluster-e2e

prow/e2e_pilotv2_auth_sds.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio_auth_sds_e2e

prow/istio-unit-tests.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

/test istio-pilot-multicluster-e2e
/test istio_auth_sds_e2e

@ymesika All required tests now passing.

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-multicluster-e2e

cc @wenchenglu

@objectiser: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
fbbb1d6284f0c5384fca4115be89f1da59105a75
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Module was compiled with an incompatible version of Kotlin (previous fix didn't work)

Steps to reproduce
There is an existing issue #130412  for this, which has been closed. I wasn't able to make the suggested fix work for me.
To reproduce:

Create a minimal flutter project, importing url_launcher: ^6.2.5.  (Code example below)
Set the kotlin version and gradle version according to the fix suggested in the existing issue #130412
flutter clean
flutter pub get
flutter build apk

Expected results
I expect the app to be built without any errors.
Actual results
During the build process where it says Running Gradle task 'assembleRelease'... there is an error: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0.
Code sample
pubspec.yaml
name: url_launcher_example
description: "A new Flutter project."
publish_to: 'none' # Remove this line if you wish to publish to pub.dev
version: 1.0.0+1

environment:
  sdk: '>=3.3.1 <4.0.0'

dependencies:
  flutter:
    sdk: flutter

  cupertino_icons: ^1.0.6
  url_launcher: ^6.2.5

dev_dependencies:
  flutter_test:
    sdk: flutter

  flutter_lints: ^3.0.0

flutter:

  uses-material-design: true

android/build.gradle
buildscript {
    ext.kotlin_version = '1.8.22'
    repositories {
        google()
        mavenCentral()
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:8.0.0'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    }
}

allprojects {
    repositories {
        google()
        mavenCentral()
    }
}

rootProject.buildDir = '../build'
subprojects {
    project.buildDir = "${rootProject.buildDir}/${project.name}"
}
subprojects {
    project.evaluationDependsOn(':app')
}

tasks.register("clean", Delete) {
    delete rootProject.buildDir
}

android/gradle/wrapper/gradle-wrapper.properties
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.0-all.zip

main.dart
import 'package:flutter/material.dart';
import 'package:url_launcher/url_launcher.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          title: const Text('URL Launcher Example'),
        ),
        body: const Center(
          child: ElevatedButton(
            onPressed: _launchURL,
            child: Text('Launch URL'),
          ),
        ),
      ),
    );
  }

  static void _launchURL() async {
    final Uri url = Uri.parse('https://flutter.dev');
    if (await canLaunchUrl(url)) {
      await launchUrl(url);
    } else {
      throw 'Could not launch $url';
    }
  }
}

Screenshots or Video
No response
Logs
Logs
e: C:/Users/me/.gradle/caches/transforms-3/087801ec877798ebe030b5b8595f25c8/transformed/core-1.10.1/jars/classes.jar!/META-INF/core_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0.
e: C:/Users/me/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.8.22/636bf8b320e7627482771bbac9ed7246773c02bd/kotlin-stdlib-1.8.22.jar!/META-INF/kotlin-stdlib-jdk7.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0.
e: C:/Users/me/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.8.22/636bf8b320e7627482771bbac9ed7246773c02bd/kotlin-stdlib-1.8.22.jar!/META-INF/kotlin-stdlib.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0.
e: C:/Users/me/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.8.22/636bf8b320e7627482771bbac9ed7246773c02bd/kotlin-stdlib-1.8.22.jar!/META-INF/kotlin-stdlib-jdk8.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0.
e: C:/Users/me/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-common/1.8.22/1a8e3601703ae14bb58757ea6b2d8e8e5935a586/kotlin-stdlib-common-1.8.22.jar!/META-INF/kotlin-stdlib-common.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0.

Flutter Doctor output
Doctor output
[√] Flutter (Channel stable, 3.19.3, on Microsoft Windows [Version 10.0.19045.4170], locale en-GB)
    • Flutter version 3.19.3 on channel stable at D:\Software\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ba39319843 (10 days ago), 2024-03-07 15:22:21 -0600
    • Engine revision 2e4ba9c6fb
    • Dart version 3.3.1
    • DevTools version 2.31.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at D:\Software\Android\SDK
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = D:\Software\Android\SDK
    • ANDROID_SDK_ROOT = D:\Software\Android\SDK
    • Java binary at: D:\Software\Android\Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0--11185874)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 2023.2)
    • Android Studio at D:\Software\Android\Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0--11185874)

[√] VS Code, 64-bit edition (version unknown)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.84.0
    X Unable to determine VS Code version.

[√] Connected device (3 available)
    • moto g32 (mobile) • ZY22G3SNF8 • android-arm64  • Android 13 (API 33)
    • Chrome (web)      • chrome     • web-javascript • Google Chrome 122.0.6261.129
    • Edge (web)        • edge       • web-javascript • Microsoft Edge 121.0.2277.112

[√] Network resources
    • All expected network resources are available.

your may need this first :
https://docs.flutter.dev/deployment/android#reviewing-the-gradle-build-configuration
try updating android>settings.gradle file by replacing this line
id "org.jetbrains.kotlin.android" version "{kotlin.version_1}" apply false
with :
id "org.jetbrains.kotlin.android" version "{kotlin.version_2}" apply false
try this by making the kotlin compiler and api version and language version in setting>kotlin compiler inside android studio that could help as i have the same issue

@AbdeMohlbi Thanks for the suggestion. I actually don't have anything that looks like that in my settings.gradle file. But your hint got me looking in the right place, and I found that by upgrading the Android Gradle Plugin using Android Studio's "AGP upgrade assistant", this actually fixed the problem I was having. After running the upgrade assistant, the following line was changed within settings.gradle:
plugins {
    id "dev.flutter.flutter-plugin-loader" version "1.0.0"
    id "com.android.application" version '7.3.0' apply false
}

became
plugins {
    id "dev.flutter.flutter-plugin-loader" version "1.0.0"
    id "com.android.application" version '7.4.2' apply false
}

And after that I could build the project successfully.

@oldmankit Exactly brother what i was trying to say is that you can do that from settings also and it will configure the files by itself .
I think someone may find this issue in the near future helpfull .

i know this issue has been closed but for anyone in the near future who had stuck to open the AGP assistant like my case try this :
https://stackoverflow.com/questions/70880154/agp-upgrade-assistant-window-not-opening-in-android-studio


Bug | Squash em |2|

Line 6, 8, 17, 19 bug. To replicate, enter some data into Schedule B, then view summary page. Do not enter any values into Line 6, 8, 17, 19. Switch to another schedule, a "blank" validation error will then be thrown. Go back to the summary page and all of the summary values will be missing.

 Bug | Squash em |2|


UpNext support broke due to Addon Signals update

Bug report
Describe the bug
Just to inform you that a recent update of Addon Signals (changing from hex-encoding to base64-encoding) broke UpNext integration.
More information at: https://github.com/im85288/service.upnext/issues/91

Easiest solution for now is to go back to:
https://mirrors.kodi.tv/addons/leia/script.module.addon.signals/script.module.addon.signals-0.0.3.zip

this becouse upnext addon do not use addonsignal in right way
instead to use addonsignals as dependency
there is an own implementation, and this means that upnext will always break when changes are made to addonsignals...

Up Next is not using Addon Signals at all. This could have been communicated better.

does not use it because it has been preferred the custom implementation than using the dependency,
the code is clear...


It's trying to parse when @include commented out

{{--@include('template')--}}

The code above will try to include the commented template.

fixed


issue sberl/45: support two channels of the sound card

I'm probably not going to get a chance to look at this in the next few
days. Big family gathering, travel, etc.
But if there is some down time I might get around to it.
Steve
On Wed, Jan 5, 2022 at 1:18 PM fenrog @.***> wrote:

@fenrog https://github.com/fenrog requested your review on: #54
https://github.com/sberl/supersid/pull/54 issue sberl/45: support two
channels of the sound card.
—
Reply to this email directly, view it on GitHub
https://github.com/sberl/supersid/pull/54#event-5848933467, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHXLEP56YQN4GCWHJ7KSRLUUSYQTANCNFSM5LK3UB6Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because your review was requested.Message ID:
@.***>

--
-steve


Add support for error channel binding

Created a doc to discuss possible approaches/questions [here] (https://docs.google.com/a/pivotal.io/document/d/1HgJgP9qChxi1cwAZfOagsmyZEYrNkF7pMWOWhe3xYaI/edit?usp=sharing)


Adopt versioning system used in the User Guides to keep track of the translation status of the Moneropedia entries

Removed the 'untranslated.html' snippet (_includes/untranslated.html). Since now we are using 'disclaimer.html' everywhere
Replaced the old snippet with the new disclaimer (introduced with #966) in all Moneropedia entries
Updated instructions in the README

Add versioning snippet to all 'randomx' Moneropedia entries (except en)

Translators are currently working on these files. It's necessary to review this PR so can be merged, otherwise translators will be working on outdated files.

@00-matt I didn't add the disclaimer to any dutch entry. I don't remember if there was a reason behind that choice or i just missed it. Anyway. I'm double checking all languages and adding the snippet where it's missing.

So, there were some conflicts because some stuff got merged in the meantime, not sure why github's UI wasn't showing it. Also, i only edited the existing snippet when i opened the PR. Now i also added the new snippet where there wasn't any.
There are some open PRs which remove some moneropedia entries. I didn't edit these entries to avoid conflicts (they will be removed anyway).
Also, for some reason pt-br entry was in Italian. No idea of why that happened but i replaced the entry with the english version.
I took advantage of the fact that i was already touching the PR to add the snippet in the also in the english files, this will make things easier when adding new languages (the snipper will be already there). Let's keep in mind that, as i stated many times, the structure of the moneropedia is completely messed up and was left outside the localization plugin, so the entire section needs to be refactored anyway.
I also reorganized the commits, squashing the two original ones in only one.


use too much memory

Hi,
I just tested the code with a .kicad file, the circuit is simple, it contains 12 nets and 2 layers. It used a lot of memory (more than 60G) and my computer can not finish running on testcase because it has no enough memory and the program is killed. So is that normal?
Here is a screenshot of the results:

Hi - unfortunately the original authors of the routing algorithm have graduated several years ago. The router is memory intensive, but one possible remedy is to coarsen the grid size from the default. It should be the first top-level argument.


chore: add more pp_dot attributes

Strange, I have pushed a commit but it is not showing up here, or triggering a new CI run. :-(

Just github being slow!

bors merge

bors merge


Add a py.typed marker file

By default, mypy requires all imported packages to contains a py.typed marker file to tell it the package has type hints.

No problem, added in 1.2.1 :+1:


Add images feature to user guide

Fixes #102

Codecov Report

Merging #103 (c9ee0aa) into master (6136150) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #103   +/-   ##
=========================================
  Coverage     56.15%   56.15%
  Complexity      600      600
=========================================
  Files           131      131
  Lines          2470     2470
  Branches        275      275
=========================================
  Hits           1387     1387
  Misses         1006     1006
  Partials         77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6136150...c9ee0aa. Read the comment docs.


fix/android_device_picking

Description

When user has only 1 sim, rnv forgets to ask for sim when it should and just launches that one sim

Related issues

https://github.com/flexn-io/renative/issues/1372

Npm releases
n/a

App is installed and launched on active simulator If there is no target device on renative.json and at least one simulator is active. Same as it was here -> https://github.com/flexn-io/renative/issues/1375


Get-PnPSitePolicy returns empty on recent sites while synced Site policy is visible in UI

Seen in PnP PowerShell 1.7.0
On recent sites, when we execute Get-PnPSitePolicy, site policies synced from the contenttypehub are not retrieved. At the same time we do see the site policies in the SharePoint UI. Also from the UI the policy can be applied successfully.
We also see that the hidden contenttype which used to be created once the sync was done, is also not available.
We see the same behaviour on multiple tenants and it started a few weeks ago.
On older sites the policy is retrieved without any problem.

@advdberg - Please DO NOT delete the template when creating an issue. Can you please fill the following:
Reporting an Issue or Missing Feature
Please confirm what it is that your reporting
Expected behavior
Please describe what output you expect to see from the PnP PowerShell Cmdlets
Actual behavior
Please describe what you see instead. Please provide samples of output or screenshots.
Steps to reproduce behavior
Please include complete script or code samples in-line or linked from gists
What is the version of the Cmdlet module you are running?
(you can retrieve this by executing Get-Module -Name "PnP.PowerShell" -ListAvailable)
Which operating system/environment are you running PnP PowerShell on?

[ ] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

Closing. Please create a new issue by filling the template if still occurs.


use logging instead of print

@jean2262 Can you grep -r "print(" *  in the code to make sure we don't have remaining ones?

@jean2262 Can you grep -r "print(" * in the code to make sure we don't have remaining ones?

Normally there isn't anymore

closed with #36


Feature Request: Collection of vector fields

For our use case, we are ingesting long documents and audio transcripts.  The amount of text we're starting with exceeds the 8K limit of the Ada embedding model.
So we need to create multiple embeddings from each piece of content.
Since we can only store one vector per search document, I had to come up with a hacky solution to store 'n' search documents per content.  (Basically one parent search document, and 'n' child search documents, n == # of chunks).
If the Cog Search index could support a collection of complex types, each which included a vector, it would make this scenario much cleaner for these use cases.
Currently, it errors with "Only a top-level field of the index can be a vector field."

Thanks for the feedback, this feature is coming soon!

Excellent. We are also interested in the same.

Related to this, found these two fields in an index created by the Custom Answering service. My plan was to use embeddings and build a similar QnA service as suggested in a lot of Microsoft slides, but seeing those, I'm wondering if the pattern is being implemented on the Custom Answering service.

Any news? Seems like a quite simple use case


Update logo.png

update rendo logo

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

added by author: https://github.com/solana-labs/token-list/commits?author=rendo-sol&since=2021-11-01&until=2021-12-01


Added Celfocus, Euronext, Natixis, Prozis and Uniplaces

Sorry the truckload of companies!
First, Prozis. We all love their peanut butter.
Then, added two well known companies of the fintech sector: Natixis and Euronext.
For the Telco sector, added Celfocus -> basically Vodafone's main software development company, from what I've been told.
And then one of the most internationally well known companies for accommodation: Uniplaces.
Feel free to leave feedback if you think I should change something!

Thanks @pmiguel! : 🌟


[BEAM-44] Stop nesting Nullable coders

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace "<Jira issue #>" in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

A single layer of nullable coders is sufficient to safely encode
possibly-null values. This allows use of NullableCoder#of to wrap any
coder, without duplicating null-safety logic applied by NullableCoder.
Fixes BEAM-44

R: @dhalperi

I'll take this. LGTM. Merge in progress.

R: @davorbonaci


Is it possible to delete those older messages that don't show up anymore?

no unfortunately not. The API doesn't allow you to access them anymore.


Send linking updates and deletes to DCP

User story
As a data submitter
I want to submit linking updates to DCP
so that I can submit the correct model of my experiment
Acceptance criteria
Some are already supported with the current implementation but adding them again here so we can test them again as we're changing the design/implementation. Criteria 1, 3, 4  are already supported and functional as implemented from dcp-680.
I - has no new metadata, linking changed
no new assay

Given 2 donors and cell suspension and cell suspension input is donor 1
When the user changes the linking so that: cell suspension input to donor 2
Then the changes will be submitted to the staging area upon export

assay became non-assay (This was made out of scope scenario from ebi-ait/dcp-ingest-central#680 )

Given 2 cell suspensions and 6 files, when cell suspension 1 is linked to the first 3 files and cell suspension 2 is linked to the next 3 files
When the user changes the process linking cell suspension 2 to 3 files so that the 3 files will now link to 3 files of cell suspension 1
Then the changes will be submitted to the staging area upon export. (No links.json file should contain the previous linking)

II - has linked new metadata

Given 2 cell suspensions and 6 files, when cell suspension 1 is linked to 6 files
When the user adds a new process and changes the linking so that: cell suspension 1 linked to file 1,2,3 & cell suspension 2 linked to files 4,5,6
Then the changes will be submitted to the staging area upon export

Given 2 donors and cell suspension and cell suspension input is donor 1
When the user adds a new protocol and links the protocol to the process connecting cell suspension and donor 1
Then the changes will be submitted to the staging area upon export

IV - has unlinked a deleted entity

Given protocol and process, the protocol is linked to process
When the user removes the protocol
Then changes will be submitted to DCP, (The staging area shouldn't contain the protocol entity and the links.json should be updated and shouldn't refer to the removed protocol)

Implementation notes
Per the decision that during data import - delete everything for a project (all rows in terra) and reimport everything, for Ingest, this means we should make sure the staging area only contains entities and links needed for reimport. Any deleted entities and links.json should be removed. (See 8th March meeting details)

Ingest will also have to make sure that the links directory only contains all sets of links.json files containing the correct linking. Ingest could clear the links/ directory for the project before every export.

Ingest will also need to delete any entities from the original staging area when entities are deleted in Ingest We could also clear metadata/ directory   - they shouldn’t be reimported.

(Added 10th March) We need to make sure that the data/ directory should always have the complete set of data files in the Terra staging area.

See  Exporting updates - design doc for more context about updates

Some new messages on this thread: https://embl-ebi-ait.slack.com/archives/C01360XN04S/p1646834044480059?thread_ts=1646223040.031019&cid=C01360XN04S
It feels like we can't proceed yet with this. The problem with the decision we made from the meeting last 8th March is that we will need to always make that the data files should always be in the original Terra staging area

If the Data Import team deletes them, how would we reexport data files to that staging area if they are already deleted in Ingest?

I asked the Data Import team if they can guarantee that we'll keep the data files in the staging area and they commented they can. However, this is against the fact that the staging area should be a temporary location for files data import.

I'll have another discussion with @amnonkhen today to discuss this and see how to proceed.

Needs clarification with downstream components which will not happen until the post-demo meeting with the DCP. @aaclan-ebi will set up a meeting before then.

@aaclan-ebi posted the PR for review on slack, no reviews yet

Hannes and Nathan have suggested changes but other people in the DCP need to review

Alegria to add some additional DCP component reviewers.

@aaclan-ebi will involve @MightyAx/ @jacobwindsor  when doing these changes to have the knowledge

@amnonkhen @MightyAx @jacobwindsor PR for DCP spec changes https://github.com/HumanCellAtlas/dcp2/pull/60

An issue was discovered in the scenario when there are multiple submissions in a project.
Exporting only the submission will export the entities for that submission and probably some entities from the previous submissions if linked to them. The new “update” staging area will not contain everything about the project. To fix this, we agreed on exporting the whole project when a submission is exported.
The idea for implementation: Update ingest core so that it will try to find all assays of the project instead of trying to only find the assays in a submission.

Remind them in the DCP demo?

waiting

Waiting on people to review/approve PR 60 in DCP2 repo. Needs more research for now

Talk about this at the DCP2 demo. @idazucchi to put into the agenda.


VSphere: Split clone and reconfigure

What this PR does / why we need it:
This makes debugging of permission errors easier
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
NONE

/lgtm


Refactoring Controlled Vocabulary classes

Fixes DD-280
Description of changes
See: https://drivenbydata.atlassian.net/browse/DD-280
How to test

Check out pr
Run mvn clean install
Deploy in dd-dtap: ./deploy-module.sh dd-dans-deposit-to-dataverse
Add      <dcterms:format>application/pdf</dcterms:format>  <dcterms:type>Dataset</dcterms:type>  <dc:format>text/html</dc:format>  <dc:language xsi:type='dcterms:ISO639-2'>fre</dc:language>  <dcterms:temporal xsi:type="abr:ABRperiode">PALEOLA</dcterms:temporal>
to a test bags dataset.xml.
Disable bag validator in dtap (the xml won't validate but this is for testing only): systemctl stop easy-validate-dans-bag
Run: vagrant ssh
Copy test bag to inbox: sudo cp -r /vagrant/{testbagdir} /var/opt/dans.knaw.nl/tmp/deposits-inbox/
Run: dd-dans-deposit-to-dataverse import /var/opt/dans.knaw.nl/tmp/deposits-inbox/
Change CV values in xml and do step 7 and 8 aganin to see the error logging.

Related PRs
(Add links)
*
Notify
@DANS-KNAW/dataversedans

I have tested the changes, and the error messages are indeed logged when the input is erroneous. But I noticed that you have to have a <title> element on the root level with a valid lang attribute. Otherwise you get an error message "Invalid controlled vocabulary term for 'Language of Metadata'". This seems to me an unnecessary requirement.
See also my few comments for improvement.

It now uses the first 'lang' attribute it finds.

I have tested the changes, and the error messages are indeed logged when the input is erroneous. But I noticed that you have to have a <title> element on the root level with a valid lang attribute. Otherwise you get an error message "Invalid controlled vocabulary term for 'Language of Metadata'". This seems to me an unnecessary requirement.
See also my few comments for improvement.

It now uses the first 'lang' attribute it finds.


Undocumented dependency on Linux

Trying to follow the futures-rs tutorial I stumbled on that I was missing the system package libssl-devel.
I'm running a fresh install of Ubuntu for other flavors of Linux it might be openssl-devel.
Please add this to the usage instructions.

It's unlikely that devel versions of dependencies are necessary, since rust bindings will only need to link the libraries, and do not require the headers.

@Ralith if i understand this correctly, this crate depends on openssl crate which requires devel headers to build. The README for that create explicitly mentions this.

Thanks for the report! We now integrate with native-tls and essentially inherit dependencies from there. For OpenSSL yeah this requires the devel versions for the headers, but openssl's build script nowadays should be helpful in installing this.
In that sense I'm going to close this issue as the openssl-sys build script should cover most of these use cases, but if it's still confusing we can add more logic there!


[RFC] number typing for prop(), propEq() and friends

Hey, I noticed you had a few entries like this:
        // propEq<T>(name: number, val: T, obj: any): boolean;
        propEq<T>(name: string, val: T): (obj: any) => boolean;
        // propEq<T>(name: number, val: T): (obj: any) => boolean;

I use prop() and propEq() for array offsets pretty frequently, so I locally patched them to add number support. Obviously that's not ideal, so I'd be happy to push you a PR if you're interested.
Thanks for investing the time to maintain this.

I'm happy to receive a PR!

PR #83  probably solves your issue

Thanks! I'll take a crack at it and see how it goes.


added a note in README mentioning wepoll

This fixes the following item from issue #1041 :
ensure wepoll licensing requirements are met (copy license file).
Carl suggested to add a note in the README file, no need to copy license file.
Signed-off-by: Daniel Tacalau<EMAIL_ADDRESS>

@carllerche please review


Update test for large objects with a more reasonable hash function.

The HashObject uses the following code in the Hash() function:
size_t Hash() const {
  g_num_hashes++;
  int hashval = i_;
  for (size_t i = 0; i < Hashsize - sizeof(i_); ++i) {
     hashval += buffer_[i];
  }
  return SPARSEHASH_HASH<int>()(hashval);
}

As you can see, when Hashsize is specified as 256, the Hash() function
will iterate and sum 252 bytes.
This is a big contributor to the time spent in sparse, dense and
unordered_map tests, and I feel is unfair when comparing with the
std::map, because the HashObject comparison function compares only the
"i_" member:
bool operator==(const class_type& that) const { return this->i_ ==
that.i_; }
bool operator< (const class_type& that) const { return this->i_ <
that.i_; }
bool operator<=(const class_type& that) const { return this->i_ <=
that.i_; }

Also, it is not typical for hash functions to take a lot of time to compute everytime the object is inserted or a lookup is performed. If indeed the hash computation is complex and must refer to many members, it should be computed once on demand and stored in the object.

Looks good. Apologies for the previous discussion, I hadn't really taken in that the Hash() function was simply adding the bytes and then hashing that value. Seems odd when I look at it now :-)
Thanks again!

No problem, I appreciate that you manage this repository carefully and that you are willing to spend a lot of time managing an open source project. Just so you know, I am actually working on a derived version of the sparse hash (sparse only, not dense), very heavily modified, with much better performance, which I'll release in a month or so.

Hum, I've made the change in the HTML file, and commited them, but I don't know how to add the commit to the pull request.

To answer the specific question: If you have created a pull request on a branch of your fork of the code, then any commits and pushes to that specific branch will then automatically show up in the pull request.


Namespaced configuration not working half of the time

Hi,
Another issue here. The configuration for config("stream-laravel::XXX") is coming back null in our project. However ('stream-laravel.XXX') works fine. We have re-ran config:cache/clear etc many times to no avail. All of the stream-laravel stuff uses this special namespacing. Is it necessary?
Thanks

I started experiencing this.. any ideas?

Opened a PR for this issue:
https://github.com/GetStream/stream-laravel/pull/87