requests looping back through envoy repeatedly

@kyessenov commented on Tue Aug 01 2017
"GET /b HTTP/1.1" 431 - 0 0 67 67 "-" "Go-http-client/1.1" "55548f90-2a21-9840-80fb-9672123adad6" "b.istio-test-fb9t4:8080" "<IP_ADDRESS>:8080" indicates that the request may be looping back through envoy and exceed trace/xff header limits

@ldemailly commented on Tue Aug 15 2017
this is a super critical issue - at least to understand - if we have loops

@kyessenov commented on Tue Aug 15 2017
setting use_remote_addr (forcing XFF) is useful to trigger it sometimes, but I can't reproduce it reliably (even after sending 10k requests, and 5 installs)

@ldemailly commented on Wed Aug 16 2017
dup of #829 ?

@kyessenov commented on Thu Aug 17 2017
xref https://github.com/linkerd/linkerd/issues/1503

@sakshigoel12 commented on Fri Aug 18 2017
Please update assignees

@sakshigoel12 commented on Tue Sep 12 2017
@andraxylia
@kyessenov
can you or do you know who could potentially help here?

Hey, is this issue solved?
Recently, I try to integrate Istio with fission(A serverless framework on kubernetes).
The bug label was removed, but still can reproduce this problem with Istio 0.6.0 almost everytime.
https://github.com/fission/fission/blob/8a0abc59dbc00bd06a8ff655c852d980675be256/controller/functionApi.go#L119-L141
It's able to work now if we treat the traffic as TCP traffic, but we cannot see the HTTP related information on Grafana.
The http request flow likes following
Execuotr -> istio-porxy -----> svc(istio-h1-default.fission-function) ----> istio-proxy -> nodejs
                                                                                (endpoint1 POST /, port: 8000)
                                                                                (endpoint2 POST /specialize, port: 8888)

The execuotr sends http requests to endpoint1&2, and retires if request failed (non-200).
The requests send to endpoint 1 are replies with http 200 by nodejs container in short time without any problem.
But executor received 431 Request Header Fields Too Large error for the requests send to endpoint2 from envoy.
And can see serval 431 error log in istio-proxy.
[2018-03-12T14:20:26.454Z] "POST /specialize HTTP/1.1" 431 - 0 0 4 3 "-" "Go-http-client/1.1" "9ee4e46c-dd91-9ea2-a79b-c29b626850b3" "istio-h1-default.fission-function:8888" "<IP_ADDRESS>:8888"

Following is the log from istio-proxy.
[2018-03-12 14:20:26.995][13][warning][config] external/envoy/source/server/listener_manager_impl.cc:374] error adding listener: 'http_<IP_ADDRESS>_8000' has duplicate address '<IP_ADDRESS>:8000' as existing listener
[2018-03-12 14:20:26.996][13][warning][upstream] external/envoy/source/server/lds_subscription.cc:68] lds: fetch failure: error adding listener: 'http_<IP_ADDRESS>_8000' has duplicate address '<IP_ADDRESS>:8000' as existing listener

.... failed to add listener due to duplicate address

[2018-03-12 14:20:28.926][13][info][config] src/envoy/mixer/config.cc:53] V2 mixer client config: transport {
  check_cluster: "mixer_check_server"
  report_cluster: "mixer_report_server"
}
service_configs {
  key: "istio-h1-default.fission-function.svc.cluster.local"
  value {
    mixer_attributes {
      attributes {
        key: "destination.labels"
        value {
          string_map_value {
            entries {
              key: "executorInstanceId"
              value: "oazaep3z"
            }
            entries {
              key: "functionName"
              value: "h1"
            }
            entries {
              key: "functionUid"
              value: "7eb41d76-25ef-11e8-a7d9-42010af0015f"
            }
            entries {
              key: "unmanaged"
              value: "true"
            }
          }
        }
      }
      attributes {
        key: "destination.service"
        value {
          string_value: "istio-h1-default.fission-function.svc.cluster.local"
        }
      }
    }
  }
}
default_destination_service: "istio-h1-default.fission-function.svc.cluster.local"
mixer_attributes {
  attributes {
    key: "destination.ip"
    value {
      bytes_value: "\000\000\000\000\000\000\000\000\000\000\377\377\n$\000P"
    }
  }
  attributes {
    key: "destination.labels"
    value {
      string_map_value {
        entries {
          key: "executorInstanceId"
          value: "oazaep3z"
        }
        entries {
          key: "functionName"
          value: "h1"
        }
        entries {
          key: "functionUid"
          value: "7eb41d76-25ef-11e8-a7d9-42010af0015f"
        }
        entries {
          key: "unmanaged"
          value: "true"
        }
      }
    }
  }
  attributes {
    key: "destination.uid"
    value {
      string_value: "kubernetes://nodejs-79ebcfb3-25ef-11e8-a7d9-42010af0015f-8wqjj9v1-6b899j9czk.fission-function"
    }
  }
}

[2018-03-12 14:20:28.930][13][warning][config] external/envoy/source/server/listener_manager_impl.cc:374] error adding listener: 'http_<IP_ADDRESS>_8000' has duplicate address '<IP_ADDRESS>:8000' as existing listener
[2018-03-12 14:20:28.932][13][warning][upstream] external/envoy/source/server/lds_subscription.cc:68] lds: fetch failure: error adding listener: 'http_<IP_ADDRESS>_8000' has duplicate address '<IP_ADDRESS>:8000' as existing listener
[2018-03-12T14:20:26.456Z] "POST /specialize HTTP/1.1" 431 - 0 0 1 - "-" "Go-http-client/1.1" "9ee4e46c-dd91-9ea2-a79b-c29b626850b3" "istio-h1-default.fission-function:8888" "-"
[2018-03-12T14:20:26.455Z] "POST /specialize HTTP/1.1" 431 - 0 0 2 1 "-" "Go-http-client/1.1" "9ee4e46c-dd91-9ea2-a79b-c29b626850b3" "istio-h1-default.fission-function:8888" "<IP_ADDRESS>:8888"
[2018-03-12T14:20:26.455Z] "POST /specialize HTTP/1.1" 431 - 0 0 2 2 "-" "Go-http-client/1.1" "9ee4e46c-dd91-9ea2-a79b-c29b626850b3" "istio-h1-default.fission-function:8888" "<IP_ADDRESS>:8888"
[2018-03-12T14:20:26.454Z] "POST /specialize HTTP/1.1" 431 - 0 0 3 3 "-" "Go-http-client/1.1" "9ee4e46c-dd91-9ea2-a79b-c29b626850b3" "istio-h1-default.fission-function:8888" "<IP_ADDRESS>:8888"
[2018-03-12T14:20:26.454Z] "POST /specialize HTTP/1.1" 431 - 0 0 4 3 "-" "Go-http-client/1.1" "9ee4e46c-dd91-9ea2-a79b-c29b626850b3" "istio-h1-default.fission-function:8888" "<IP_ADDRESS>:8888"

.... tons of 431 error

[2018-03-12 14:20:30.960][13][warning][config] external/envoy/source/server/listener_manager_impl.cc:374] error adding listener: 'http_<IP_ADDRESS>_8000' has duplicate address '<IP_ADDRESS>:8000' as existing listener
[2018-03-12 14:20:30.963][13][warning][upstream] external/envoy/source/server/lds_subscription.cc:68] lds: fetch failure: error adding listener: 'http_<IP_ADDRESS>_8000' has duplicate address '<IP_ADDRESS>:8000' as existing listener
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] Caught Segmentation fault, suspect faulting address 0xffffffff00000026
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:90] Backtrace obj</usr/local/bin/envoy> thr<20> (use tools/stack_decode.py):
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:107] thr<20> #0 0x47136d
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:107] thr<20> #1 0x46b051
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:107] thr<20> #2 0x5f14d5
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:107] thr<20> #3 0x60a1b5
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:107] thr<20> #4 0x93a147
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:107] thr<20> #5 0x93a6ae
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:107] thr<20> #6 0x6069d8
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:107] thr<20> #7 0x943dfd
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:99] thr<20> obj</lib/x86_64-linux-gnu/libpthread.so.0>
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:107] thr<20> #8 0x7ff2e495b6b9
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:99] thr<20> obj</lib/x86_64-linux-gnu/libc.so.6>
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:107] thr<20> #9 0x7ff2e438841c
[2018-03-12 14:20:30.965][20][critical][backtrace] bazel-out/local-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:110] end backtrace thread 20
2018-03-12T14:20:31.003448Z	warn	Epoch 0 terminated with an error: signal: segmentation fault
2018-03-12T14:20:31.003545Z	warn	Aborted all epochs

.... segmentation fault

2018-03-12T14:20:31.003626Z	info	Epoch 0: set retry delay to 200ms, budget to 9
2018-03-12T14:20:31.204342Z	info	Reconciling configuration (budget 9)
2018-03-12T14:20:31.206728Z	info	Epoch 0 starting
2018-03-12T14:20:31.217455Z	info	Envoy command: [-c /etc/istio/proxy/envoy-rev0.json --restart-epoch 0 --drain-time-s 45 --parent-shutdown-time-s 60 --service-cluster istio-proxy --service-node sidecar~<IP_ADDRESS>~nodejs-79ebcfb3-25ef-11e8-a7d9-42010af0015f-8wqjj9v1-6b899j9czk.fission-function~fission-function.svc.cluster.local --max-obj-name-len 189 -l info]
[2018-03-12 14:20:31.240][25][info][main] external/envoy/source/server/server.cc:184] initializing epoch 0 (hot restart version=9.200.16384.256.options=capacity=16384, num_slots=8209 hash=228984379728933363)
[2018-03-12 14:20:31.245][25][info][config] external/envoy/source/server/configuration_impl.cc:52] loading 0 listener(s)
[2018-03-12 14:20:31.245][25][info][config] external/envoy/source/server/configuration_impl.cc:92] loading tracing configuration
[2018-03-12 14:20:31.245][25][info][config] external/envoy/source/server/configuration_impl.cc:106]   loading tracing driver: envoy.zipkin
[2018-03-12 14:20:31.245][25][info][config] external/envoy/source/server/configuration_impl.cc:119] loading stats sink configuration
[2018-03-12 14:20:31.245][25][info][main] external/envoy/source/server/server.cc:359] starting main dispatch loop
[2018-03-12 14:20:31.253][25][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:128] cm init: initializing cds
[2018-03-12 14:20:31.290][25][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:356] add/update cluster in.8000
[2018-03-12 14:20:31.293][25][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:356] add/update cluster in.8888

...

[2018-03-12 14:20:31.346][25][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:109] cm init: initializing secondary clusters
[2018-03-12 14:20:31.894][25][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:132] cm init: all clusters initialized
[2018-03-12 14:20:31.894][25][info][main] external/envoy/source/server/server.cc:343] all clusters initialized. initializing init manager
[2018-03-12 14:20:32.058][25][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'virtual'
[2018-03-12 14:20:32.065][25][info][config] src/envoy/mixer/config.cc:53] V2 mixer client config: transport {
  check_cluster: "mixer_check_server"

[2018-03-12 14:20:32.109][25][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'http_<IP_ADDRESS>_8000'

.... some mixer confs here

[2018-03-12 14:20:32.111][25][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'http_<IP_ADDRESS>_8888'
[2018-03-12 14:20:32.111][25][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'http_<IP_ADDRESS>_8888'
[2018-03-12 14:20:32.112][25][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'tcp_<IP_ADDRESS>_53'
[2018-03-12 14:20:32.116][25][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'tcp_<IP_ADDRESS>_443'
[2018-03-12 14:20:32.116][25][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'tcp_<IP_ADDRESS>_14267'
[2018-03-12 14:20:32.116][25][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'tcp_<IP_ADDRESS>_14268'
[2018-03-12 14:20:32.117][25][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'tcp_<IP_ADDRESS>_9411'
[2018-03-12 14:20:32.117][25][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'tcp_<IP_ADDRESS>_15004'

... keep adding listener

[2018-03-12 14:20:32.124][25][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'tcp_<IP_ADDRESS>_8086'
[2018-03-12 14:20:32.574][25][info][config] external/envoy/source/server/listener_manager_impl.cc:579] all dependencies initialized. starting workers
[libprotobuf INFO src/mixerclient/check_cache.cc:155] Add a new Referenced for check cache: Absence-keys: adapter_template_kubernetes.output.destination_service, adapter_template_kubernetes.output.source_labels, adapter_template_kubernetes.output.source_namespace, adapter_template_kubernetes.output.source_pod_ip, adapter_template_kubernetes.output.source_service, adapter_template_kubernetes.output.source_service_account_name, source.uid, Exact-keys: context.protocol, destination.ip, destination.service, destination.uid, source.ip,
[libprotobuf INFO src/mixerclient/check_cache.cc:155] Add a new Referenced for check cache: Absence-keys: adapter_template_kubernetes.output.destination_service, adapter_template_kubernetes.output.source_labels, adapter_template_kubernetes.output.source_namespace, adapter_template_kubernetes.output.source_pod_ip, adapter_template_kubernetes.output.source_service, adapter_template_kubernetes.output.source_service_account_name, source.uid, Exact-keys: context.protocol, destination.ip, destination.service, destination.uid, source.ip,
[libprotobuf INFO src/mixerclient/check_cache.cc:155] Add a new Referenced for check cache: Absence-keys: adapter_template_kubernetes.output.destination_service, adapter_template_kubernetes.output.source_service, Exact-keys: context.protocol, destination.ip, destination.service, destination.uid, source.ip, source.uid,
[libprotobuf INFO src/mixerclient/check_cache.cc:155] Add a new Referenced for check cache: Absence-keys: adapter_template_kubernetes.output.destination_service, adapter_template_kubernetes.output.source_service, Exact-keys: context.protocol, destination.ip, destination.service, destination.uid, source.ip, source.uid,

[2018-03-12T14:20:44.559Z] "POST /specialize HTTP/1.1" 202 - 0 0 59 55 "-" "Go-http-client/1.1" "bcf4c257-9553-969e-bad3-d7319da4c551" "istio-h1-default.fission-function:8888" "<IP_ADDRESS>:8888"

.... request is sent to the endpoint2 and return successfully

Looks like istio-proxy failed to add listener due to duplicate address cause this problem?
Once it's able to add new listener after segmentation fault, the HTTP requests are able to send to
endpoint2 without any problem.
If there is anything/logs I can help/provide, please let me know. Thanks.
Istio version: 0.6.0
K8S version: 1.9.2-gke.1

I'm getting the same error.
If I try to curl from a non istio-injected pod to a istio-injected one I get several HTTP 431 errors.
From the non istio-injected pod I run:
$ curl --verbose --header 'Host: my-service.my-namespace.svc.cluster.local' 'http://<IP_ADDRESS>:8080/hello-world'
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 8080 (#0)
> GET /hello-world HTTP/1.1
> Host: my-service.my-namespace.svc.cluster.local
> User-Agent: curl/7.58.0
> Accept: */*
>
< HTTP/1.1 431 Request Header Fields Too Large
< date: Tue, 20 Mar 2018 03:51:47 GMT
< server: envoy
< content-length: 0
< x-envoy-upstream-service-time: 172
<
* Connection #0 to host <IP_ADDRESS> left intact

On the istio-injected pod I get the following logs:
[2018-03-20T03:51:47.360Z] "GET /hello-world HTTP/1.1" 431 - 0 0 127 127 "-" "curl/7.58.0" "553f57d7-f7ad-9735-a6de-d272759a0f70" "my-service.my-namespace.svc.cluster.local" "<IP_ADDRESS>:8080"
[2018-03-20T03:51:47.360Z] "GET /hello-world HTTP/1.1" 431 - 0 0 127 127 "-" "curl/7.58.0" "553f57d7-f7ad-9735-a6de-d272759a0f70" "my-service.my-namespace.svc.cluster.local" "<IP_ADDRESS>:8080"
[2018-03-20T03:51:47.360Z] "GET /hello-world HTTP/1.1" 431 - 0 0 128 128 "-" "curl/7.58.0" "553f57d7-f7ad-9735-a6de-d272759a0f70" "my-service.my-namespace.svc.cluster.local" "<IP_ADDRESS>:8080"

...

[2018-03-20 03:54:58.067][17][info][upstream] external/envoy/source/server/lds_subscription.cc:70] lds: fetch failure: network error
[2018-03-20 03:54:59.108][17][info][upstream] external/envoy/source/server/lds_subscription.cc:70] lds: fetch failure: network error

$ istioctl version
Version: 0.6.0
GitRevision: 2cb09cdf040a8573330a127947b11e5082619895
User: root@a28f609ab931
Hub: docker.io/istio
GolangVersion: go1.9
BuildStatus: Clean

Can you try with 0.8 and confirm if the issue still exists?

I don't think this issue was actually resolved. Reopening this , as I still face this issue.  FYI @howardjohn @GregHanson @ramaraochavali @rshriram

Please open a new issue, this is from 3 years ago.
And do it in the istio security vulnerability private email if its potentionally a DOS vector

I don't see why a new issue is to be re-opened, when I am facing this very issue as filed by the OP. The fact that this was closed without any clarification or note of resolution warrants that this issue be revisited

People stumble into this issue via Google search, it's only fair that this issue be updated for the benefit of others who would be looking up similar problems

There is a near 0% chance the issue is the same, despite the same symptoms. Literally every part of the code has changed since 3 years ago. No maintainer will be looking at issues from 3 years ago.

Then this needs to be transferred to https://github.com/istio/old_issues_repo.
Just providing an outsider's perspective


Special overview strategy needed for vector.

CDB Overviews, as they are now, cannot be used to generalize data for vector tiles. Specific issue is that default strategy reduce number of points very little, so lower zooms still have too many points. If the aim is to remove completely overlapping pixels, then it is ok, but for vector we need to apply larger buffer.
Also just simple tuning of tolerance parameter in createoverviews does not help, as the default strategy "snaps" to pixel centers, so with e.g. 10-pixel tolerance produces not desired result like this

Instead we need smaller number of aggregated (or maybe not even aggregated, just filtered out - depending on case) points in their original location, not in snapped pixel grid. Better result example:

The best solution would be to take also point priority into account - in the sample of city points keep larger cities for general zooms, based on population as priority.

Duplicate of https://github.com/CartoDB/cartodb-postgresql/issues/286 , fixed


use strict; is not supported -  Attempted to assign to readonly property

When using "use strict"; there is an error " Attempted to assign to readonly property."
In https://github.com/web-animations/web-animations-js/blob/master/web-animations-next-lite.min.js
b["true"] = a;

Has strict mode compatibility be resolved for this library?

This is something to do with uglify's wrap option. Which produces
function(exports,global){global["true"]=exports;


Add helm chart

Describe your changes
Issue ticket number and link
Checklist before requesting a review

[x] I have performed a self-review of my code
I tested the changes with the following distributions:

[x] Kind

https://github.com/spinkube/runtime-class-manager/pull/204 incorporates this work and adds a handful of changes to get it all working and updated with the latest rcm code.

Thank you @vdice - closing this PR. We will proceed in #204 .


[BUG] Error while executing getText()

Getting following error while using getText() method in MatListOptionHarness:

[0-0] 2024-12-02T18:16:00.649Z WARN webdriver: WebDriverError: javascript error: Unexpected identifier 'as'
[0-0]   (Session info: chrome=131.0.6778.86) when running "execute/sync" with method "POST" and args "
[0-0]                 const clone = arguments[0].cloneNode(true) as Element;
[0-0]                 const exclusions = clone.querySelectorAll(arguments[1]);
[0-0]                 for (let i = 0; i < exclusions.length; i++) {
[0-0]                     exclusions[i].remove();
[0-0]                 }
[0-0]                 return (clone.textContent ?? '').trim();
[0-0]             "

I believe issue is due to Type Script code snippet not being translated to javascript. See following line:
https://github.com/Badisi/wdio-harness/blame/b43d9ae1b2ecc2cddb19450e0a8389a766e4ac31/projects/library/src/WebdriverIOTestElement.ts#L218C17-L218C17

Good catch, thanks!

🎉 Released in<EMAIL_ADDRESS>📦🚀


[WIP] High-DPI display clean-up

Issue: There is a lot of complexity today in how we handle high-dpi displays (ie, retina displays).
The challenge is there are really two 'coordinate systems' that appear. The first is screen space - if I ask GLFW for a window of size 800x600, these are screen space coordinates. The other coordinate system is pixel space. For a high-dpi display, like retina, there might be a multiple of 2-3 pixels per screen space.
So, for a window of screen space size 800x600, with a display with a pixel density of 3, the functions will return the following:

glfwGetWindowSize - 800x600
glfwGetFramebufferSize - 2400x1800

At the end of the day, when we're drawing, internally, we care about the framebuffer size - but we don't want the user to have to worry about this. Their app should look the same regardless of DPI - imagine how confusing it'd be if you ask for a window of width 800, and then create an element of 800 - and it only takes up a third of the screen 😨 The browser takes care of this for DOM elements, and we should do the same in revery.
We do have a scaling solution in place, however, we convert all the layout nodes / sizes to the pixel space. This leads to some confusion, and the DPI information leaking out - for example, if I create a 200x200 rectangle, grab a ref to it, and ask for the dimensions, in a high-dpi screen with pixel density 3, I'll get 600x600 for the rectangle. This complicates things like hit-testing and mouse events where you always need to be cognizant and converting between these coordinate systems.
To address this, and simplify the pipeline, we'll have all the UI rendering / layout / events happen in screen space. In addition, we'll set the projection matrix to be in screen space, so the coordinate system for vertices and positions is in screen space, even if the frame buffer is larger (the projection matrix will convert it for us).
There are still cases internally where you have to be cognizant of the DPI:

Rendering fonts - If the user asks for a font size 20 - freetype renders in pixel space, so we have to convert the font size, otherwise we'll get blurry text in a high-dpi display.
Images - it'd be nice to pick high-dpi images like iOS/Apple does, depending on DPI.

We also expose the Window.getDevicePixelRatio as an API, but hopefully the user doesn't have to worry about it too much. There are definitely cases where you'd want to render different UI based on the display density, so it makes sense to keep that around. But hopefully keeping the majority of our pipeline in screen space makes it simpler to reason about events / positions.
It's also perf boost - we save a lot of 'scaling' calculations we were doing when creating layout nodes from styles!
As an aside, I found that I'm able to simulate a high DPI display following the instructions here: https://stackoverflow.com/questions/12124576/how-to-simulate-a-retina-display-hidpi-mode-in-mac-os-x-10-8-mountain-lion-on
Tested in the following environments:

[x] Standard DPI - native
[x] Standard DPI - webgl
[x] High DPI (2x) - native
[x] High DPI (2x) - webgl

Was starting to look at implementing a very minimal overflow: hidden implementation using glScissorRect, but hit some complications with the coordinate systems here.
I also hit the ref-sizing issue mentioned when I was implementing a PoC slider control: https://github.com/revery-ui/revery/tree/bryphe/prototype/slider


Add base64 encoding and snap length support

sysdig-CLA-1.0-signed-off-by: Yue Feng<EMAIL_ADDRESS>falco-CLA-1.0-signed-off-by: Yue Feng<EMAIL_ADDRESS>

Have a look plz...
@mstemm

The changes look good, and thanks for the contribution! I wanted to double check on the use case, though. Normally, most/all of the events that have an %evt.buffer that would be a candidate for display as base64 are also events that falco ignores. So I guess you have your own rules where you do use those events, and then also run falco with the -A flag?

The changes look good, and thanks for the contribution! I wanted to double check on the use case, though. Normally, most/all of the events that have an %evt.buffer that would be a candidate for display as base64 are also events that falco ignores. So I guess you have your own rules where you do use those events, and then also run falco with the -A flag?

Yes, I use falco with -A and some custom rules to capture special system events. I'd like to use falco instead sysdig that's because rules in falco can be managed easily.  But some nice features in sysdig are missed in falco, like %evt.buffer (it can not display non ascii characters) and snaplen (can not custom %evt.buffer length).
There are other users has the same feature request please see https://github.com/draios/falco/issues/363

Ok, I just wanted to make sure you knew about the required configuration. Merging, and thanks again!


small typo fix

Contains
A small typo fix for a comment in the TerasologyEngine class.
How to test
Not applicable

First time doing this, let me know if I did something wrong.


meta-lxatac-software: bcu: prepare for upstreaming

According to the OpenEmbedded Layer Index there is not yet an upstream bcu recipe.
This means we should at least attempt to upstream it to e.g. meta-openembedded.
Do some cleanup, updating and improvements first.
Feel free to be extra strict with your review, so people do not have a reason to be mean to me on the mailing list later.

The current version of this recipe is now in meta-openembedded master:
https://github.com/openembedded/meta-openembedded/commit/1d47796fcf9613e4ca2f2c6beeb6f447d443fca0

Since meta-openembedded did not have any issues with this we will likely be fine.
I am going to merge it now.


Arbitrary length bits type supported?

Thanks for this awesome project. After read the documents, I have a question about arbitrary length bits type. I think now the current status about this kind of type is unsupoorted. Am I right? If I were right (hope not), is there any plan about it? Thanks very much! Have a nice day!

No it is not supported and there is no plans to support it. You have to emulate it in upper protocols using uint8/uint16/uint32/uint64 or fixed/dynamic bytes array. For this puprose use bytes, byte[10] or byte[] type definitions in structs.

Thanks for reply. Arbitrary length bits type is seldom used indeed.


Investigate creack/pty

https://github.com/kr/pty has moved to https://github.com/creack/pty and the former is now a shim that depends on the latter. We should investigate switching over.
Tangential to #1124 which drew my attention to this.

#1431 has addressed this

Thanks @ibuclaw :heart:


Fix sporadic build/test failures.

The default load timeout for AMD modules is 7 seconds, when running the tests so many modules get loaded at once that it can time out. This fixes the karma configuration under Node so that timeout is indefinite.
Because we've also seen sporadic build failures, I also added the timeout option to requirejs.optimize as well, I'm not sure if this has any effect, but if we stop seeing sporadic requirejs.optimize failures, we'll know it did.
CC @hpinkos @bagnell

I merged this into another branch and it seems to be working. The classification-primitive branch failed CI because of makeZipFile but the tests ran where they weren't before.

Welp, I checked the CI for this branch and thought that makeZipFile was causing the failure. I didn't notice that the tests also timed out.


Crash

I'm probably not going to go through a big song and dance over this to make a pull request, but if you open the .jar with something like 7-Zip, and edit the fabric.mod.json file, you can just insert a single "}" without the quotes at the end of the file, and it should resolve the problem.

Actually, maybe I will do a pull request, because this mod has tons of problems.

Here's the mod as I compiled it. It will work on 1.17+ servers without crashing.
https://github.com/SalvieMundi/bits-of-bark/releases/tag/release
Also, here is the contents of my wood-barks.json configuration file. I would take out anything you aren't using, but wanted to provide it as it can be extremely tedious making the mod work with better end in particular. I also have traverse, apple trees revived and blockus stuff in there.

{
"Hunger": 2,
"Saturation": 0.1,
"IsFuel": true,
"FuelTicks": 75,
"WoodTypes": {
"minecraft:stripped_warped_hyphae": "minecraft:warped_hyphae",
"minecraft:stripped_oak_wood": "minecraft:oak_wood",
"promenade:stripped_palm_log": "promenade:palm_log",
"promenade:stripped_dark_amaranth_stem": "promenade:dark_amaranth_stem",
"minecraft:stripped_dark_oak_log": "minecraft:dark_oak_log",
"promenade:stripped_palm_wood": "promenade:palm_wood",
"promenade:stripped_dark_amaranth_hyphae": "promenade:dark_amaranth_hyphae",
"minecraft:stripped_crimson_hyphae": "minecraft:crimson_hyphae",
"minecraft:stripped_birch_log": "minecraft:birch_log",
"minecraft:stripped_jungle_log": "minecraft:jungle_log",
"minecraft:stripped_crimson_stem": "minecraft:crimson_stem",
"minecraft:stripped_birch_wood": "minecraft:birch_wood",
"croptopia:stripped_cinnamon_wood": "croptopia:cinnamon_wood",
"woods_and_mires:stripped_pine_wood": "woods_and_mires:pine_wood",
"minecraft:stripped_oak_log": "minecraft:oak_log",
"croptopia:stripped_cinnamon_log": "croptopia:cinnamon_log",
"promenade:stripped_cherry_oak_wood": "promenade:cherry_oak_wood",
"minecraft:stripped_spruce_wood": "minecraft:spruce_wood",
"woods_and_mires:stripped_pine_log": "woods_and_mires:pine_log",
"minecraft:stripped_jungle_wood": "minecraft:jungle_wood",
"minecraft:stripped_acacia_log": "minecraft:acacia_log",
"minecraft:stripped_spruce_log": "minecraft:spruce_log",
"minecraft:stripped_dark_oak_wood": "minecraft:dark_oak_wood",
"promenade:stripped_cherry_oak_log": "promenade:cherry_oak_log",
"minecraft:stripped_warped_stem": "minecraft:warped_stem",
"minecraft:stripped_acacia_wood": "minecraft:acacia_wood",
"traverse:stripped_fir_log": "traverse:fir_log",
"traverse:stripped_fir_wood": "traverse:fir_wood",
"appletreesrev:stripped_apple_log": "appletreesrev:apple_log",
"appletreesrev:stripped_apple_wood": "appletreesrev:apple_wood",
"blockus:stripped_white_oak_log": "blockus:white_oak_log",
"blockus:stripped_white_oak_wood": "blockus:white_oak_wood",
"betterend:dragon_tree_stripped_bark": "betterend:dragon_tree_bark",
"betterend:dragon_tree_stripped_log": "betterend:dragon_tree_log",
"betterend:end_lotus_stripped_bark": "betterend:end_lotus_bark",
"betterend:end_lotus_stripped_log": "betterend:end_lotus_log",
"betterend:hexlix_tree_stripped_bark": "betterend:helix_tree_bark",
"betterend:helix_tree_stripped_log": "betterend:helix_tree_log",
"betterend:jellyshroom_stripped_bark": "betterend:jellyshroom_bark",
"betterend:jellyshroom_stripped_log": "betterend:jellyshroom_log",
"betterend:lacugrove_stripped_bark": "betterend:lacugrove_bark",
"betterend:lacugrove_stripped_log": "betterend:lacugrove_log",
"betterend:lucernia_stripped_bark": "betterend:lucernia_bark",
"betterend:lucernia_stripped_log": "betterend:lucernia_log",
"betterend:mossy_glowshroom_stripped_bark": "betterend:mossy_glowshroom_bark",
"betterend:mossy_glowshroom_stripped_log": "betterend:mossy_glowshroom_log",
"betterend:pythadendron_stripped_bark": "betterend:pythadendron_bark",
"betterend:pythadendron_stripped_log": "betterend:pythadendron_log",
"betterend:tenanea_stripped_bark": "betterend:tenanea_bark",
"betterend:tenanea_stripped_log": "betterend:tenanea_log",
"betterend:umbrella_tree_stripped_bark": "betterend:umbrella_tree_bark",
"betterend:umbrella_tree_stripped_log": "betterend:umbrella_tree_log"
},
"GiveBark": [
"#bitsofbark:give_bark",
"#moretags:dressed_wood",
"minecraft:birch_log",
"promenade:dark_amaranth_hyphae",
"minecraft:birch_wood",
"minecraft:spruce_log",
"promenade:dark_amaranth_stem",
"minecraft:warped_hyphae",
"minecraft:warped_stem",
"minecraft:crimson_stem",
"woods_and_mires:pine_wood",
"minecraft:crimson_hyphae",
"minecraft:jungle_log",
"minecraft:oak_log",
"minecraft:acacia_log",
"minecraft:jungle_wood",
"minecraft:oak_wood",
"promenade:cherry_oak_wood",
"woods_and_mires:pine_log",
"promenade:cherry_oak_log",
"minecraft:dark_oak_log",
"minecraft:dark_oak_wood",
"minecraft:acacia_wood",
"minecraft:spruce_wood",
"promenade:palm_wood",
"promenade:palm_log",
"croptopia:cinnamon_log",
"croptopia:cinnamon_wood",
"traverse:fir_log",
"traverse:fir_wood",
"appletreesrev:apple_log",
"appletreesrev:apple_wood",
"blockus:white_oak_log",
"blockus:white_oak_wood",
"betterend:dragon_tree_bark",
"betterend:dragon_tree_log",
"betterend:end_lotus_bark",
"betterend:end_lotus_log",
"betterend:helix_tree_bark",
"betterend:helix_tree_log",
"betterend:jellyshroom_bark",
"betterend:jellyshroom_log",
"betterend:lacugrove_bark",
"betterend:lacugrove_log",
"betterend:lucernia_bark",
"betterend:lucernia_log",
"betterend:mossy_glowshroom_bark",
"betterend:mossy_glowshroom_log",
"betterend:pythadendron_bark",
"betterend:pythadendron_log",
"betterend:tenanea_bark",
"betterend:tenanea_log",
"betterend:umbrella_tree_bark",
"betterend:umbrella_tree_log"
],
"IsFood": false
}


Fix Spotify not running and building

I could neither run the upstream Docker image nor could I build the Dockerfile.
Bug 1
Cannot run the upstream image:
docker pull jess/spotify
docker run -it --rm jess/spotify
spotify: error while loading shared libraries: libSM.so.6: cannot open shared object file: No such file or directory

Solution to bug 1
Install libsm6
Bug 2
Cannot build the Dockerfile:
cd dockerfiles/spotify
docker build . --pull
[...]
Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
Executing: /tmp/apt-key-gpghome.k3eQma7IzG/gpg.1.sh --keyserver keyserver.ubuntu.com --recv-keys 4773BD5E130D1D45
gpg: key 4773BD5E130D1D45: public key "Spotify Public Repository Signing Key<EMAIL_ADDRESS>imported
gpg: Total number processed: 1
gpg:               imported: 1
Hit:1 http://deb.debian.org/debian sid InRelease
Get:2 http://repository.spotify.com stable InRelease [3316 B]
Err:2 http://repository.spotify.com stable InRelease
  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY D1742AD60D811D58
Reading package lists...
W: GPG error: http://repository.spotify.com stable InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY D1742AD60D811D58
E: The repository 'http://repository.spotify.com stable InRelease' is not signed.
The command '/bin/sh -c apt-get update && apt-get install -y 	dirmngr 	gnupg 	--no-install-recommends 	 apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 4773BD5E130D1D45 	 echo "deb http://repository.spotify.com stable non-free" >> /etc/apt/sources.list.d/spotify.list 	    && apt-get update && apt-get install -y 	sa-utils 	  libgl1-mesa-dri 	  libgl1-mesa-glx 	  libpulse0 	  spotify-client 	utils 	    --no-install-recommends 	&& rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100

Solution to bug 2
Replaced instructions to retrieve the key with the official instructions from https://www.spotify.com/us/download/linux/

:+1:

@jessfraz friendly ping
Btw, what about adding a cronjob to the CI (https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#onschedule) that just tries to build the Docker images periodically? This way this issue could have been caught early.


Number-like sequence ID would generate invalid genbank files.

pharokka version: 1.7.0
Python version: Python 3.9.18
Operating System: Linux mBio 6.6.16-2-MANJARO  SMP PREEMPT_DYNAMIC Sat Feb 10 09:40:02 UTC 2024 x86_64 GNU/Linux

Description
Hi, all. This is a very interesting bug, I can reproduce this. Input fasta file contains a single sequence record, the ID is 01E2.
Command:
pharokka.py -d /home/shenwei/ws/db/pharokka/v1.4.0 \
    -i genomes.annotation.pharokka/01E2/01E2.fasta
    -o genomes.annotation.pharokka/01E2/01E2 \
    --force -t 20 -p 01E2

The genbank file looks like below. It's split into two records, one with only sequence , another one with only annotations, haha.
LOCUS       01E2                   43095 bp    DNA     linear   PHG 06-MAR-2024
DEFINITION  01E2.
ACCESSION   01E2
VERSION     01E2
KEYWORDS    .
SOURCE      .
  ORGANISM  .
            .
FEATURES             Location/Qualifiers
ORIGIN
        1 cccctttagt accatcgcgt acttctttga gtatcgccac gacacgaccc ataccgtcct
 ....

//
LOCUS       100.0                  43095 bp    DNA     linear   PHG 06-MAR-2024
DEFINITION  .
ACCESSION   100
VERSION     100.0
KEYWORDS    .
SOURCE      .
  ORGANISM  .
            .
FEATURES             Location/Qualifiers
     CDS             complement(2..1480)
                     /ID="RWRSYBXE_CDS_0001"
   ..
     CDS             complement(42274..43095)
                     /ID="RWRSYBXE_CDS_0074"
                     /transl_table=nan
                     /phrog="3228"
                     /top_hit="NC_023608_p43"
                     /locus_tag="RWRSYBXE_CDS_0074"
                     /function="DNA"
                     /function=" RNA and nucleotide metabolism"
                     /product="replicative helicase-primase"
                     /source="PHANOTATE_1.5.1"
                     /score="-632407.7737456377"
                     /phase="0"
                     /translation="LNQTFGNWIDKFNENSAGQDGMGRVVAILKEVRDGTKGAVGVVHH
                     TPKGGSKARGSGALYAGVDVELTLVRATEKQINVAHTKNKNGMQQKTIGMVLEPVQFRE
                     APPPKEFQAVEFVGGEGYGEIVNLDLPEPHKALVLMPWGFQPFETDEEKERNEGLDGKG
                     KDYVKDTVKRSKDASARESVMSALEDLQQADDTGRGFTQRQIVARAGDHSITNLVLEKM
                     LREGELMLGCDENGEVVTNTYRLPTGIDDRKRPKNRYEPNDNIKATEGDLE"
ORIGIN
//

OK, if I rename the FASTA ID with some string not starting with 0, everything is right.
Possible reason
01E2 might be parsed as a scientific notation (100), because the second genbank record is
LOCUS       100.0

If I change the ID to 0102,  it panics again, with the second genbank record as
LOCUS       102

So a note should be shown to users, do not use sequence IDs that look like a number, including scientific notation.

Hi @shenwei356 ,
Thanks for picking this bug up.
Pharokka needs a refactor now that I am a much better coder than I was when I first wrote it, I just need to find some time!
This bug seems to be caused by bad typing when parsing the gene prediction summary file.
I can reproduce the error in v1.7.0 for scientific notation and integers that have leading 0s - these were being parsed as Int not as str.
I've put in a fix in v1.7.1 that parses everything always as str and tested it locally - on the dev branch if you are keen, otherwise it should be available once all the CI checks have passed.
George


tensor flow version

Hi, do you have a recommendation of tensor flow version?
Further, if you tell us the version of CUDA and cuDNN, it is highly appreciated.

我是健翔，您的邮件我收到了。

我是健翔，您的邮件我收到了。

那个版本


Build failure: waybar

Steps To Reproduce
Steps to reproduce the behavior:

build waybar from nixpkgs

Build log
fails realising the context of path <...>/etc/xdg/waybar/style.css
/nix/store/isq9pykwvb2r569q5rkilhnc9ja29dyl-waybar-0.11.0+date=2024-09-16_9cfb1e3/etc/xdg/waybar/style.css
waybar> building '/nix/store/lvama4mn02qm4y3lsrx2l592ldsr9nqy-waybar-0.11.0+date=2024-09-16_9cfb1e3.drv'
waybar> Running phase: unpackPhase
waybar> unpacking source archive /nix/store/z35x0vk74m9qd4mcvd7y5l5azwzggfjb-source
waybar> source root is source
waybar> /build/source /build
waybar> patching script interpreter paths in .
waybar> /build
waybar> Running phase: patchPhase
waybar> applying patch /nix/store/4dh7h9pnzxfa0l74116cz0x3ssnkpac7-fix-tray
waybar> patching file src/modules/sni/item.cpp
waybar> Reversed (or previously applied) patch detected!  Assume -R? [n]
waybar> Apply anyway? [n]
waybar> Skipping patch.
waybar> 5 out of 5 hunks ignored -- saving rejects to file src/modules/sni/item.cpp.rej
waybar> patching file subprojects/fmt.wrap
waybar> Reversed (or previously applied) patch detected!  Assume -R? [n]
waybar> Apply anyway? [n]
waybar> Skipping patch.
waybar> 1 out of 1 hunk ignored -- saving rejects to file subprojects/fmt.wrap.rej
error:
...
┏━ 1 Errors:
 ⋮
┃        … while evaluating the option `home-manager.users.user.programs.waybar.style':
┃
┃        (10 duplicate frames omitted)
┃
┃        … while evaluating definitions from `/nix/store/0m6b3pl1f4qwp6a7pmvc4fpic8qbfdvd-source/flake.nix':
┃
┃        … from call site
┃          at /nix/store/0m6b3pl1f4qwp6a7pmvc4fpic8qbfdvd-source/lib/modules.nix:837:128:
┃           836|         defs' = concatMap (m:
┃           837|           map (value: { inherit (m) file; inherit value; }) (addErrorContext "while evaluating definitions from `${m.file}':" (dischargeProperties m.value))
┃              |                                                                                ^
┃           838|         ) defs;
┃
┃        … while calling 'dischargeProperties'
┃          at /nix/store/0m6b3pl1f4qwp6a7pmvc4fpic8qbfdvd-source/lib/modules.nix:908:25:
┃           907|   */
┃           908|   dischargeProperties = def:
┃              |                         ^
┃           909|     if def._type or "" == "merge" then
┃
┃        … while evaluating a branch condition
┃          at /nix/store/0m6b3pl1f4qwp6a7pmvc4fpic8qbfdvd-source/lib/modules.nix:909:5:
┃           908|   dischargeProperties = def:
┃           909|     if def._type or "" == "merge" then
┃              |     ^
┃           910|       concatMap dischargeProperties def.contents
┃
┃        … while evaluating the attribute 'value'
┃          at /nix/store/0m6b3pl1f4qwp6a7pmvc4fpic8qbfdvd-source/lib/modules.nix:619:53:
┃           618|                 (n: value:
┃           619|                   [{ inherit (module) file; inherit value; }]
┃              |                                                     ^
┃           620|                 )
┃
┃        … while calling the 'readFile' builtin
┃          at /nix/store/p2f0m89c93vk737fw4jhs677581vhnhj-source/home/common/programs/waybar.nix:9:7:
┃             8|   style = ''
┃             9|     ${builtins.readFile "${pkgs.waybar}/etc/xdg/waybar/style.css"}
┃              |       ^
┃            10|
┃
┃        … while realising the context of path '/nix/store/isq9pykwvb2r569q5rkilhnc9ja29dyl-waybar-0.11.0+date=2024-09-16_9cfb1e3/etc/xdg/waybar/style.css'
┃
┃        error: builder for '/nix/store/lvama4mn02qm4y3lsrx2l592ldsr9nqy-waybar-0.11.0+date=2024-09-16_9cfb1e3.drv' failed with exit code 1
┣━ Dependency Graph:
┃ ⏵ waybar-0.11.0+date=2024-09-16_9cfb1e3 (patchPhase)
┣━━━ Builds
┗━ ∑ ⏵ 1 │ ✔ 0 │ ⏸ 0 │ ⚠ Exited with 1 errors reported by nix at 23:19:13 after 5s

Additional context
I do have various differences between my nixpkgs and master but they are very close, nixos-rebuild build --flake . also fails while I have flake.nix set to master branch.
I think this is probably related to: #341520
Notify maintainers
@GaetanLepage hey, sorry to bother you, I recently pulled master and am having some issues.
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
osh-0.22.0$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.50, NixOS, 24.11 (Vicuna), 24.11.20240909.9f82045`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.23.3`
 - channels(root): `""`
 - nixpkgs: `/nix/store/jaqw76k581amcfpd164zd2vwzvvibm0n-source`

Add a :+1: reaction to issues you find important.

sorry, closing for now. i forgot i have the waybar overlay setup and technically this error comes from my home-manager program config:
...
  style = ''
    ${builtins.readFile "${pkgs.waybar}/etc/xdg/waybar/style.css"}
...

although still probably related to recent waybar code it's not because of a specific nixpkgs pr or anything.

Also had this error, but I too was not using nixpkgs waybar, this is just a current bug for waybar 0.11.4 in this flake I'm using:  https://github.com/Alexays/Waybar/tree/a3e7031fe25421c1f64d4b88ce2298bbd6dd2324


main.rs default alignment type

Right now we have to specify an alignment type to align 2 strings no matter what.
I'd like to make it so that this CLI arg is optional, and if it isn't set, it uses basic WFA.

Done in latest commit.


Bind 'load' event instead of using the ajax function

Everything is in the title :)
We don't need to load window but to know when it is loaded.

Ok the error doesn't come from my fix but from phantomjs :) I guess you can merge.

As I can see this issue is already addressed in #8923.
I guess we will go ahead with the other PR since it also fixes the deprecation in other components.

Closed with #8923.

Yes sure! Thx


npm webdriver is unable to find phantomjs

I really unsure if I can diagnose this correctly. But it looks like grunt-webdriver can not check if PhantomJS is installed to proper location to run it. It gives the following non-descriptive error.
RuntimeError: RuntimeError
     (UnknownError:13) An unknown server-side error occurred while processing the command.
     Problem: The path to the driver executable must be set by the phantomjs.binary.path capability/system property/PATH variable; for more information, see https://github.com/ariya/phantomjs/wiki. The latest version can be downloaded from http://phantomjs.org/download.html

     Callstack:
     -> init()

It is installed from here: https://github.com/gratipay/gratipay.com/blob/master/package.json
https://github.com/gratipay/gratipay.com/issues/3069
I am not programming in JavaScript at all. Just looking for a way to make tests green on my system.

WebdriverIO doesn't check of PhantomJS is properly installed. If you ste the binary path within your capabilities you should be fine


Request: Support for x86_64-alpine-linux-musl target

Compilation for a binary depending on this crate fails when attempting to compile on alpine linux, with the following error message:
error: cannot produce proc-macro for `async-attributes v1.1.1` as the target `x86_64-alpine-linux-musl` does not support these crate types

It'd be awesome for it to support:

x86_64-alpine-linux-musl
x86_64-unknown-linux-musl

My use case builds it for alpine in a Docker container:
docker build -f Dockerfile.alpine .

Dockerfile.alpine

FROM alpine:3 AS build

# Install rust
ENV RUSTFLAGS="-C target-feature=+crt-static"
RUN apk update
RUN apk add rust cargo openssl-dev

# Build the application
RUN mkdir -p /src/<PACKAGE_NAME>
COPY . /src/<PACKAGE_NAME>
WORKDIR /src/<PACKAGE_NAME>
RUN cargo build --release

Ah... I misread I didn't realize musl doesnt' support proc macro at all 🙈


sbJSON Citation Revision

Currently, translation to sbJSON (and publish to Science Base function in mdEditor) constructs a citation from the author list, title, and URI. There are two problems with this:

Author roles and date roles are being included within parenthesis, which are not appropriate in true citations.
The citation format does not meet USGS FSP policies for data citations.

The appropriate formatted citation exists in citation > otherCitationDetails { } for USGS records. Ex: Bender, A.M., Nolan, M., 2021, Fodar orthomosaic and digital elevation model of the Totatlanika River corridor (Alaska) acquired August 2021: U.S. Geological survey data release, https://doi.org/10.5066/P9K7CFRI
A few potential solutions:

Look for existence of otherCitationDetails content and use it first, use constructed citation if non-existent. Risk of otherCitationDetails containing information unrelated to citations.
Ask user for a preference, which could only be implemented in the Publish to Science Base interface.
Modify the citation construction to conform to USGS policies. Note, USGS citation policies are based on guidelines developed by ESIP.
Behind the scenes scripting in Science Base to overwrite the citation.

@dwalt Just to confirm, I am planning to do the following for this:

[ ] Remove dates
[ ] Filter parties to only authors

@jwaspin No, there are two use cases:

If the user provided Other Cit Details, then use that
If Other Cit Details is null, then provide a basic citation of: author(1), author(2)..., Citation Title
ex: Fred Flintstone, Barney Rubble, Geology of the Stone Age


replace step placeholders by dynamic parameters values

I already contributed the changes for that functionality https://github.com/getgauge/gauge-java/pull/160, but unfortunately it doesn't work as expected.
So, I decided to implement "replacer", which will update placeholders in text step on dynamic parameters values.

Hi @MolineroUA ,
Can you please tell us what was not working for you with #160 and what is expected in more detail ?
It will be better if you can create an issue for the same so that it will be easy to track and test once done.

Hi @NivedhaSenthil !
The main goal to have ability to get step text from StepDetails with parameters values.
In case of Static parameters everything is Okay, because step text already contains parameters values, they are specified directly.
In case of Dynamic parameters we have step text with placeholders. And when  actualStepText is set to StepDetails, the step text will contain placeholders but not a values, for example "User <username> logged-in from client <clientTypeName>".
When I tried to change actualStepText on parsedStepText the result was "User {} logged-in from client {}". It's not what I expected :) and it's my mistake because I didn't verify what exactly Messages.StepInfo contains.
So, in this PR I implemented functionality which will replace a placeholder on value of dynamic parameter in step text.

Yes, using actualStepText and having new field to hold dynamic parameters in StepDetails will be cleaner and easy to do approach. The dynamic parameter values are available in stepInfo within currentExecutionInfo which can be used to update the same. Let us know if you need any help with that.

@NivedhaSenthil please verify my pull request. I already implemented new class field dynamicText in StepDetails and functionality for replacing placeholders on dynamic parameters values.


37 | Sudoku Solver | Python

Title - Sudoku Solver
What will change - Add solution for problem 37 in Python.
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] Python

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Can I get assigned to this issue, please?


Find in core and search_dialog RPC command

This depends on https://github.com/google/xi-editor/pull/687
This pull request implements the search_dialog RPC command to signal to the core whether the search dialog is open or closed. This enables to store the search query only in the core.
I also added this to xi-mac for testing: https://github.com/scholtzan/xi-mac/tree/async-find

Bikeshed:
What exactly is the behaviour that changes based when this is sent? Is it entirely related to the rendering of inactive highlights, or are there other changes?
In general I have a preference for RPC names that communicate behaviour, rather than UI state. In other words, if this flag indicates whether a partial find match should be shown, we might want to call it highlight_partial_find.

In addition to that, the core responds with the find_status when this is sent.

But in general, I agree, showing/hiding the highlights for the find matches is the main thing that happens. Though, why not call it highlight_find?

Okay, I renamed it to highlight_find

@scholtzan okay this diff got a bit messy: it's really just adding the highlight_find RPC, correct? What's a good strategy for merging this? Do we want to do it all at once, along with the xi-mac PR, with the comments removed?

This should be merged after https://github.com/google/xi-editor/pull/687. I am currently trying to fix the stack overflow problem but after that find_status should be ready to go.


[Snyk] Security upgrade python from 3.7 to 3.12.3

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 2 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

base/saltstack/3002/Dockerfile

We recommend upgrading to python:3.12.3, as this image has only 205 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
  829

Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
  829

Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
  829

Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
  829

Resource Exhaustion SNYK-DEBIAN12-NGHTTP2-5953379
  829

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Resource Exhaustion

Checkmarx One – Scan Summary & Details – d8a55484-9082-4ae4-ba2d-e99146423b0f
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

Path_Traversal
/base/oracle-java/utils/list-versions.py: [57](https://github.com/TheRedHatter/vulhub/blob/snyk-fix-f6562c141eabb34b7ddb582d0c0a103f//base/oracle-java/utils/list-versions.py# L57)
Attack Vector

Fixed Issues

Severity
Issue
Source File / Package

Client_DOM_XSS
/electron/CVE-2018-15685/src/index.html: [17](https://github.com/TheRedHatter/vulhub/blob/snyk-fix-f6562c141eabb34b7ddb582d0c0a103f//electron/CVE-2018-15685/src/index.html# L17)

Client_Potential_XSS
/electron/CVE-2018-15685/src/index.html: [17](https://github.com/TheRedHatter/vulhub/blob/snyk-fix-f6562c141eabb34b7ddb582d0c0a103f//electron/CVE-2018-15685/src/index.html# L17)

Path_Traversal
/python/PIL-CVE-2017-8291/app.py: [37](https://github.com/TheRedHatter/vulhub/blob/snyk-fix-f6562c141eabb34b7ddb582d0c0a103f//python/PIL-CVE-2017-8291/app.py# L37)

Path_Traversal
/base/oracle-java/utils/list-versions.py: [57](https://github.com/TheRedHatter/vulhub/blob/snyk-fix-f6562c141eabb34b7ddb582d0c0a103f//base/oracle-java/utils/list-versions.py# L57)


Add Favicons

Currently our app doesn't have favicons. Kandra agreed to make them, poke her or make our own. Place in public directory and link in app.blade.php <head />

Hello ! Can I help you this issue ^^


On JS and Wasm (and maybe iOS), when depending a val storing the state value outside in a NavHost composable lambda, the updated state is not propagated

Describe the bug
See the code below:
val (count, setCount) = remember { mutableStateOf(0) }
val navController = rememberNavController()
val clickToIncCountModifier = Modifier.onClick {
    setCount(count + 1)
}

Column {
    BasicText("Count outside: $count", clickToIncCountModifier)
    NavHost(navController, "0") {
        repeat(4) { i ->
            composable(i.toString()) {
                Column {
                    BasicText("Screen $i")
                    BasicText("Count in `NavHost`: $count", clickToIncCountModifier)
                }
            }
        }
    }
}

Run the app on Wasm, and click the "count" texts to increment the text. If you click the text outside the NavHost, the value is correctly incremented; if you click the text inside, the value is always reset to 1 which is the original value 0 incremented. However, If I use MutableState.value directly in the lambda or use delegated properties for the state instead, it works. Also both texts increment and show the count correctly on JVM desktop.
After going through a bunch of Jetpack Compose docs and experimenting with the code myself, I suspect that this is a bug with the Compose compiler and the navigation library combined, firstly because it works on JVM desktop but not on JS and Wasm, and secondly because I see that lambdas are stable, so they are immutable and essentially closures wrapping val count and their recomposition is skipped, and while the compiler may have adopted some mechanism similar to rememberUpdatedState on desktop, it doesn't do it on JS or Wasm. However, LazyColumn has a similar style of adding composable lambdas in a non-composable lambda, but doesn't have this bug as I have tested. Nevertheless, These are merely my thoughts and of course you guys are the experts, so correct me if I am wrong.
I came across this problem when I was trying to port a small portion of Compose navigation to Compose HTML. And I spent quite some time debugging this. If you are interested in more details, see the commit messages of the latest 4 commits here.
Affected platforms

maybe iOS too (I didn't check)
Web (K/Wasm) - Canvas based API
Web (K/JS) - Canvas based API
Web (K/JS) - HTML library (NavHost is not available on this, I copied and adapted a NavHost myself and it still occurs. See https://github.com/huanshankeji/compose-multiplatform-material/commit/3c48921f8b89fd21c5f3227c463b62458c7df567 for details.)

Versions

Libraries:

Compose Multiplatform version: 1.6.10 & 1.6.11
Navigation Multiplatform version (for related issues): 2.7.0-alpha07

Kotlin version: 2.0.0
OS version(s) (required for Desktop and iOS issues): Ubuntu 22.04.4 LTS
OS architecture (x86 or arm64): x86
JDK (for desktop issues): OpenJDK Runtime Environment (build 21.0.3+9-Ubuntu-1ubuntu122.04.1) for Gradle, some JDK 8 for runtime because I set jvmToolchain(8)

To Reproduce
See the code and instructions above.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


bug:

Did you check docs and existing issues?

[X] I have read all the lazy docs
[X] I have searched the existing issues of lazy
[X] I have searched the exsiting issues of the plugin I have a problem with

Neovim version (nvim -v)
NVIM v0.9.0-dev-155+g771824128
Operating system/version
Ubuntu i3wm x11
Describe the bug
When i open nvim i see error message:

Checkhealth:

Steps To Reproduce

Expected Behavior

Repro
local lazypath = vim.fn.stdpath('data') .. '/lazy/lazy.nvim'

if not vim.loop.fs_stat(lazypath) then
  vim.fn.system {
    'git',
    'clone',
    '--filter=blob:none',
    'https://github.com/folke/lazy.nvim.git',
    lazypath,
  }
end

vim.opt.runtimepath:prepend(lazypath)

require("lazy").setup({
  "folke/which-key.nvim",
  { "folke/neoconf.nvim", cmd = "Neoconf" },
  "folke/neodev.nvim",
})

You can't name that file lazy.lua since you're hijacking the lazy module from lazy.nvim

Thank you:)


mavlink stop-all doesn't close all instances when called from SD card

I am running (almost) latest master branch.
I have on my SD
`echo STOPPING MAVLINK
mavlink stop-all
echo sleeping for 5 secs
usleep 5000000
echo Turning on nshterm on ACM0
nshterm /dev/ttyACM0 &
echo Startin mavLink
mavlink start -b 115200 -d /dev/ttyS1`
And I am left with 2 instances of mavlink running:
228 mavlink_if0                   195  2.948  2308/ 2792 100 (100)  READY
229 mavlink_rcv_if0                 0  0.000   796/ 2096 175 (175)  w:sem
170 mavlink_if2                    56  0.000  2284/ 2792 100 (100)  w:sig

Check rcS. Likely mavlink instances are being started after extras.txt  is run.

Nope, everything stock there, the only mavlink commands after extras.txt is run is 'mavlink boot_complete'.
Also, putting 'mavlink stop-all' one after another fixes the problem. Like this:
echo STOPPING MAVLINK
mavlink stop-all
echo sleeping for 5 secs
usleep 5000000
mavlink stop-all
...
I will try tomorrow with the latest master (if it compiles, becuase today's master had an error and I didn't have time to fix it).

@vvranjek still an issue?
mavlink stop-all seems to work for me.

No. I think the issue was that something else was using one of the serial ports, thus mavlink was unable to terminate the instance.


removing type ignores from views/generic.py

just a little cleanup removing some type ignores, and asserting where it is appropriate.

See 2 nits and format pls!

Codecov Report

Merging #1648 (f349d91) into main (1b84ebf) will increase coverage by 0.04%.
The diff coverage is 47.05%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #1648      +/-   ##
==========================================
+ Coverage   46.24%   46.29%   +0.04%
==========================================
  Files          47       47
  Lines        6904     6958      +54
==========================================
+ Hits         3193     3221      +28
- Misses       3711     3737      +26

Impacted Files
Coverage Δ

lnbits/core/views/generic.py
44.56% <47.05%> (-0.64%)
:arrow_down:

... and 5 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix debugedit build break

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[ ] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[ ] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

What does the PR accomplish, why was it needed?
Debugedit fails in the toolchain build since help2man package is not available. Since this package is only required for check tests, wrap it in a test for with_check
Toolchain error
 /usr/src/mariner/BUILD/debugedit-5.0/missing: line 81: help2man: command not found
WARNING: 'help2man' is missing on your system.

Not bumping the release number since this update package hasn't build/release yet
Change Log

Change debugedit to wrap help2man BR in with_check

Does this affect the toolchain?

YES
Test Methodology

Pipeline build id: preparebuild
Buddy build: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=434140&view=results

Abandoning this change as there is more investigation to be done to build without help2man (while also fixing the check tests). I am reverting the breaking change to debugedit in #6402

Abandoning this change as there is more investigation to be done to build without help2man (while also fixing the check tests). I am reverting the breaking change to debugedit in #6402


impl: exec sub command

The exec command is not listed in the runtime-spec, but I consider it one of the required features. For example, when I run docker exec -it [container id] bash, I currently get the following error.

@utamoku Can I have you assign me to solve this issue?

@minakawa-daiki
Thanks for your interest. Oh... That was definitely not implemented there.
I'd love to have it for you! I've assigned you to it.

@utam0k May I remove the assignment because there may be someone else who wants to work on this issue?

@minakawa-daiki
I understand. Please challenge this again whenever you have time.

@utam0k
I can take a look at this

@Furisto I'm looking forward to your PR.


Button smashing still works on Add Level button

Jenny's comment on #1331: I'm still having trouble with the "accidentally adding multiple levels" issue. I've done it numerous times just in the first few minutes of playing with it, without trying. (I'm able to intentionally replicate it as well.) If anything, it feels more sensitive than before. It happens when I lightly tap on the trackpad, even when I'm consciously trying to tap only once.
I think you mentioned putting in a fix for that, so wondering if it was merged, or if it's maybe just not doing the trick for some reason.

@sanjuroj Can you please describe the fix you already tried, so we don't go down the same path, and/or can build on whatever you did?

Also, I am sooooo NOT smashing those buttons! I swear!

@jennyhavah I'm referring to anything that results in two mouse clicks in quick succession as a SMASH, not just the frenzied mouse activity of a keyed-up QA tester.  I tried to come up with a pithy acronym for SMASH but don't have the brain power for it at the moment.
Aaaaannnnnyyyyway, l've removed the old SMASH protection and added a different one.  Because it's hard to tell if you've successfully SMASHed, I've set it so the following appears in the console if the protective measure was triggered:  'Avoided a problem.'.  So if you see that in the console, you successfully SMASHed and there shouldn't be an extra blank level field added.  We can remove that logging once QA is done.


Workspace destroy in GUI & danger style for dangerous ContextMenu actions

As @BenElgar mentioned to me, this invokes a job that might fail or take a while so the current implementation might be a little too optimistic.
I've tested it ~8 times and only 1 time did the home page still contain a button to the deleted workspace - still kinda bad. Perhaps should have some sort of loading thing. Other than that, this is good to go.

That being said, I think "execute then offer to undo" is better than "require multiple clicks and pop up an annoying confirmation dialogue to execute"

Alternatively, since this is a rare action, we should probably move it to a danger section on the workspace details page & leave it out of the context menu altogether.

That was my first consideration before putting it in the context menu, but I actually don't think it's that rare, which is why I decided to put it here - but yeah it would have a confirmation.

Added a rough modal but we will need a more sophisticated system to efficiently handle modals from within any component

Gonna merge this as-is and loop around when or before we need more modals in order to set up a global store-based modal system.


Upgrade to use patternlab core 3.x

Upgrade the edition to support https://github.com/pattern-lab/patternlab-node/releases latest release.
Which includes pattern-lab/patternlab-node#745

Should also include https://github.com/pattern-lab/patternlab-node/issues/745

Wouldn't it be better to separate the upgrade to Webpack 4 to a separate task? Sure these are both breaking changes but still, in case one or the other gets stuck, you're still open to create a release independently.
Also, I think I could more easily contribute to the Webpack part if needed, but not to the patternlab core one.

@renestalder Thank you, I've split it up, #16 is dedicated to that work. This is a great suggestion thank you. The more contributors the better.

Thank you @Josh68  I will take a look as soon as I can.

FWIW, I think my fork is not a good reference. I've been re-reading the upgrade docs for PL v3, and I'm now trying to wrap my head around what Webpack will handle, and how, and it's substantially different with v3 than with v2.
My own goal is to have the ability to use loaders, primarily for SASS/Postcss, and plugins. but with PL core handling file copying and potentially dev serving and watching, I've kind of lost a grasp on how to configure Webpack to do a more minimal set of tasks, at the right time and in the right order.
Would it make sense to define goals for a v3 conversion?

Let's connect on gitter @Josh68

Now with upgrading of Webpack to version 4, this prepares this edition to work better with the core 3.x release.


use std::u16; makes method resolution of inherent u16 methods fail

Example:
use std::u16;

fn f() {
    u16::from_le_bytes([0,0]);
}

Go to definition does not work on from_le_bytes, but will work if the use std::u16; is commented out.
I'm not actually sure how this works in rustc. You'd think the module would shadow the primitive type since they both occupy the type namespace, but apparently not? Maybe I've discovered another bonus namespace?

Yeah, we already have some custom logic for builtins:

https://github.com/rust-analyzer/rust-analyzer/blob/f7144dcd52c663cefc789445fe561771d935fbf0/crates/hir_def/src/item_scope.rs#L65-L73

This probably needs a test and some more special-casing around here:
https://github.com/rust-analyzer/rust-analyzer/blob/f7144dcd52c663cefc789445fe561771d935fbf0/crates/hir_def/src/nameres/path_resolution.rs#L142-L159

method_resolution.rs test case for this:
#[test]
fn assoc_fn_shadowed_by_use() {
    check_types(
        r#"
//- /lib.rs crate:lib deps:core
use core::u16;

fn f() {
    let x = u16::from_le_bytes();
      x
    //^ u16
}

//- /core.rs crate:core

pub mod u16 {}

#[lang = "u16"]
impl u16 {
    pub fn from_le_bytes() -> Self { 0 }
}
        "#,
    )
}

Related rustc code: https://github.com/rust-lang/rust/blob/f913a4fe901d6aeb84941fa06c17916d4e6d1dd7/compiler/rustc_resolve/src/late.rs#L2145-L2163

This appears to be harder to implement than I thought: we must make sure the fallback only happens once all parent DefMaps are checked, because otherwise you'd be unable to override primitive types with your own, if a block is present (shadowing_primitive_with_inner_items starts failing).
The good news is that I think it would be sufficient to implement this in resolver.rs, since this does not affect early name resolution (imports cannot refer to associated items).


Web browser on console

Browsh - Broken displaying at least 1.8.2 in nixpkgs
w3m - ipv6 hangs socket
Lynx - Looks not maintained
elinks - https://github.com/rkd77/elinks - similar problem like w3m, and cannot copy texts
Chawan - https://sr.ht/~bptato/chawan/
Edbrowse - https://edbrowse.org/

Using same package of chawan in WSL2 does not made any error, but in NixOS, it made following exception
> cha --dump https://www.rfc-editor.org/rfc/rfc3339.txt
STDERR: sandbox.nim(195)         :anonymous
STDERR: Error: unhandled exception: Sandbox violation in network process [Defect]

Without dump does not display anything.
I tried to downgrade and upgrade in several chawan versions as bisect, only NixOS24.05 works fine in NixOS... :roll_eyes:
https://github.com/kachick/chawan/blob/30920fe12cbc6ab72078a68e308931bf865ede26/src/utils/sandbox.nim#L193-L196
https://github.com/kachick/chawan/blob/30920fe12cbc6ab72078a68e308931bf865ede26/doc/hacking.md?plain=1#L213-L226
https://github.com/NixOS/nixpkgs/pull/327421
https://github.com/NixOS/nixpkgs/pull/332960
https://github.com/NixOS/nixpkgs/pull/336480


feat: update to latest influxdata/openapi.

Disable Redoc's autodisplay of Authentication so we can render it in a custom x-traitTag.
Effectively reopens https://github.com/influxdata/docs-v2/pull/3146 with merge of https://github.com/influxdata/openapi/pull/193

closing, per @jstirnaman, these changes were merged into 2.0.9 branch


Add default timeout to ShopifyAPI::Base

@maartenvg @celsodantas @peterjm
Closes #225
There is not default timeout on ShopifyAPI::Base (it's nil 😔). This introduces a 25 second default timeout for API requests.

25 seconds is too short for some Shopify API requests, although I guess it's configurable per app to make it longer.
There's also going to be a patch that allows separate open and read timeouts for ActiveResource (https://github.com/Shopify/shopify/pull/60047), but relying on that would assume that the project is using the most up-to-date ActiveResource.

If it's too short then we can increase it but leaving it blank is not a great idea.

Agreed that we shouldn't leave it blank, and I don't think there's going to be a single great timeout (I don't think we'd pick a timeout greater than a minute, and some API endpoints consistently take longer than a minute). So 25 seconds seems reasonable to me

:+1:
I agree that leaving it blank is not great.

Is it maybe better to default to be slightly under Shopify's normal timeout? It's really up to the app to define there best timeout for their queries, and I fear users of this gem will run into unexplained timeouts breaking their app when they upgrade. Other option is documenting the change well and making it a breaking version bump to 4.1.x.
When we have open & read, it's different of course.

Can we update the minor version to alert ppl that the gem update might break stuff?

In that case then we should set the timeout to whatever the timeout would have been from Shopify anyway. That way it's not a breaking change but it still does help because if the network is just messed up and Shopify doesn't timeout the request, then the API client will timeout, preventing requests that would otherwise go on way longer than they should.

@maartenvg @celsodantas @peterjm I've updated the timeout to be the same as in Shopify so that this will not change the behaviour (and, therefore, not be a breaking change). The upside to this change is that in the case that the timeout is not respected on the Shopify side, the client will instead fail with a timeout instead of being stuck for way longer than 90s.

I'm cool with that. :+1:
We would still need to bump the version to release a new version of the gem.

^ agreed

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

Version bumped. Any objections to merging?

@celsodantas ..... ?

:+1:

hehe that's a :+1:

Rebased to fix version number conflict. Merging on :green_apple:


Add ClassLoader Binding for ScopeModel

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #8766 (e93e6a8) into 3.0 (1dfb114) will decrease coverage by 0.05%.
The diff coverage is 76.22%.

@@             Coverage Diff              @@
##                3.0    #8766      +/-   ##
============================================
- Coverage     63.65%   63.59%   -0.06%
+ Complexity      313      310       -3
============================================
  Files          1149     1149
  Lines         48285    48325      +40
  Branches       7281     7266      -15
============================================
- Hits          30734    30732       -2
- Misses        14175    14202      +27
- Partials       3376     3391      +15

Impacted Files
Coverage Δ

...src/main/java/org/apache/dubbo/container/Main.java
0.00% <0.00%> (ø)

...e/dubbo/remoting/transport/netty4/NettyClient.java
71.01% <50.00%> (+1.44%)
:arrow_up:

...in/java/org/apache/dubbo/rpc/model/ScopeModel.java
59.09% <52.63%> (-6.30%)
:arrow_down:

.../apache/dubbo/config/bootstrap/DubboBootstrap.java
69.79% <66.66%> (-0.04%)
:arrow_down:

...apache/dubbo/common/extension/ExtensionLoader.java
80.89% <68.75%> (+0.18%)
:arrow_up:

...ava/org/apache/dubbo/common/utils/ConfigUtils.java
69.67% <71.87%> (-0.45%)
:arrow_down:

...a/org/apache/dubbo/rpc/model/ApplicationModel.java
78.81% <72.72%> (-1.01%)
:arrow_down:

...va/org/apache/dubbo/common/config/Environment.java
74.33% <100.00%> (+1.60%)
:arrow_up:

...e/dubbo/common/config/PropertiesConfiguration.java
96.29% <100.00%> (+1.85%)
:arrow_up:

...ache/dubbo/common/extension/ExtensionDirector.java
97.61% <100.00%> (+0.11%)
:arrow_up:

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dfb114...e93e6a8. Read the comment docs.


[EBPF] Add mock program for GPU tests

What does this PR do?
This PR adds a mock C program to test the eBPF probes introduced in https://github.com/DataDog/datadog-agent/pull/29646. It also introduces a bit of code in the tasks code to generate those helper binaries and send them to KMT VMs.
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


[1|About Page] Breadboard

 🍰 Appetite 🍰

Property
Value

Points
3 points

Difficulty rating
★★☆☆☆

Maximum Assignees
2 person

🤔 Problem Statement
Make a breadboard for each screen in the fat-marker sketch. Every place and affordance should be accounted for, but don't focus on making it look pretty. This should be essentially a bare HTML file, with no JS, and only CSS if required for basic layouts. Implement fake navigation and interactions using normal <a> tags. This purely for getting an interactive "skeleton" up, and seeing in real life whether this design would work, or has any major problems.
Please see this page for more info on what your breadboard should be like (and, if you want understand the fat-marker sketch and places affordances drawing better, please see this page).
🧪 Required Tests
None (but the Code Wizard will review whether or not your code warrants some tests! Review the Code & Testing Guidelines for more info)
⚠ Careful about:

Don't make a separate desktop design. There should be one design, that works both in landscape and portrait orientations.

🤖 Technologies focused on in this feature

React
Tailwind
Shadcn

I would like to work on this piece! @Iwaslazkis

I would like to be assigned to this @puma

I would like to take this one @puma

@Sneezy-w @manuelBuitizon you are assigned.

Sorry @Simonwmm, we have 2 assignees on this issue now but there are plenty of others you can pick!

I'm here @puma

@khnatiuk @ViniOkamoto @Sneezy-w
I have completed the pull request and assigned the points.


ngTable with  promise tracker

ngTable support busy indicator on http requests. can use promise tracker and intercept http request. why not having in build directive for busy indicator.

?????????????????????


Will the listener's address be nil in real use case?

Please provide an in-depth description of the question you have:
https://github.com/kmesh-net/kmesh/blob/e6f8c191b97293fa70d6a5ea00251622c21881d1/pkg/cache/v2/listener.go#L105-L129
Getaddress() method on line 112. Getaddress() method in line 112. Because it returns listener.Address, if listener.Address is nil, it will trigger panic.
	t.Run("test3: listener in rsp is nil", func(t *testing.T) {
		adsLoader := NewAdsLoader()
		adsLoader.routeNames = []string{
			"ut-route-to-client",
			"ut-route-to-service",
		}
		svc := &ServiceEvent{
			DynamicLoader: adsLoader,
		}
		listener := &config_listener_v3.Listener{}
		anyListener, err := anypb.New(listener)
		assert.NoError(t, err)
		rsp := &service_discovery_v3.DiscoveryResponse{
			Resources: []*anypb.Any{
				anyListener,
			},
		}
		err = svc.handleLdsResponse(rsp)
		assert.NoError(t, err)
		apiMethod := svc.DynamicLoader.ListenerCache.GetApiListener("ut-listener").ApiStatus
		assert.Equal(t, core_v2.ApiStatus_UPDATE, apiMethod)
		wantHash := hash.Sum64String(anyListener.String())
		actualHash := svc.DynamicLoader.ListenerCache.GetLdsHash(listener.GetName())
		assert.Equal(t, wantHash, actualHash)
	})

The above problem was discovered when I wrote the above test case for SeviceEnevt.handleLdsResponse.
The question I want to ask is: Will there be a situation where the listenerCache in adsLoader is nil and the listener in rsp is also empty?
What do you think about this question?:
I think we should add nil pointer check.
Environment:

Kmesh version: 0.2.0
Others:

https://github.com/kmesh-net/kmesh/blob/e6f8c191b97293fa70d6a5ea00251622c21881d1/pkg/controller/envoy/ads_event.go#L230-L234
Why is it update apicluster status here? Shouldn't it be update apiListener Status?

Will the listener's address be nil in real use case?

Please get to know more about listener configuration before asking here.  Super sure this is impossible

Why is it update apicluster status here? Shouldn't it be update apiListener Status?

good catch, looks this is a mistake, should be setting Listener status


Pass the --comment option to kdesudo to improve dialog

Otherwise, kdesudo also displays the command as the dialog title,
making it very ugly and unfriendly.
Before:

After:

Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

The ugliness is more visible when trying to run a larger command :)
Maybe we can also append a generic comment like " needs administrator privileges. Please enter your password." to be consistent with the original message?

Thanks @jviotti, also for the screenshots. I think we should append the reason for the prompt as you suggested, consistent with the original message.
Have you tested with instance.options.name containing spaces?

Hi @jorangreef ,
Done! I had to surround the message in double quotes as well, great catch!

Thanks @jviotti, would you also please keep the line length under 80 chars?

Hi @jorangreef , sure. Do you prefer an array + .join(' ' ), or splitting with + and move the lines below?

I can also escape the literal newline with \.

What about a reason variable which contains the reason text which you can then add after options.name?

Done!


Trying to join Slack Group, Invite System down

Description
Trying to join the Slack Group, unable to get an invite
Expected outcome
Click on the link https://ranviermud.signup.team/ and see a form to get a Slack invite
Actual outcome
Connection refused
Steps to reproduce
Click the link and try it. :)
Version of Ranvier

The "Get an invite" link on the main repo page or the website has the updated link. Where are you still seeing the ranviermud.signup.team link?

http://ranviermud.com/contributing/
Under "Talking with the team" the link "Get an invite" :)


Please fix failing tests

Description
Most recent passing test was 2 Oct 2022

Reproduction steps
N/A: just open "Commits" page on github and look for red "X"'s
Expected vs. actual results
N/A: just open "Commits" page on github and look for red "X"'s
Minimal code example
No response
Error messages
No response
Compiler and operating system
N/A: just open "Commits" page on github and look for red "X"'s
Library version
N/A: just open "Commits" page on github and look for red "X"'s
Validation

[ ] The bug also occurs if the latest version from the develop branch is used.
[ ] I can successfully compile and run the unit tests.

Duplicate of #3890.


Update new committee members role

Changed new committee members' role
Changed Krishnanjana's status as a Ph.D. student

👷 Deploy Preview for bsa-unr processing.

Name
Link

🔨 Latest commit
b039d6cd45b375ab0b4be5eb07e254a541605a55

🔍 Latest deploy log
https://app.netlify.com/sites/bsa-unr/deploys/63150cea6373ab0008e68ffd


Godot 3.4 beta 4 - room and portal postfixes not importing correctly

Godot version
3.4 beta 4
System information
Kubuntu 20.04
Issue description
When importing a .glb from blender that uses the postfixes -room, -portal, and -bound, the objects are not imported correctly and remain  Spatials with -room, and MeshInstances with -portal and - bound at the end of their name instead of being converted to the correct type of nodes.
Steps to reproduce
Create a Blender file with 2 empties, RoomA-room, and RoomB-room. parent some room geometry to them, some geometry for the bounds named RoomABounds-bound, and RoomBBounds-bound, and some geometry to one named RoomARoomBPortal-portal. Export the scene as a glb, and import it into Godot 3.4 beta 4.

Minimal reproduction project
3.4 beta test.zip

Yeah it was well worth bringing this up, I'll check the other functionality today, and update the docs to make this more clear that changing the node type only happens during the room conversion.
I'll have a look at the import options, but it may not be easy to do at the import stage, because changing the node types relies on information that is calculated during the whole conversion process. For instance portals decide which rooms to link to by looking up the names on an previously calculated list of rooms, etc, etc. In short the nodes may not be able to be converted independently of the other nodes in the system, which makes things considerably more complex than e.g. a collision mesh or something.


Another Release?

Just a question -- is there any timeline for putting out another release?
I'm asking mainly because one of my projects is stuck with v1.5.3 until the fix for https://github.com/flask-admin/flask-admin/issues/1927 makes its way into a release. The older version  of flask-admin doesn't support Werkzeug 1.0, and is blocking a whole bunch of other stuff in the mean time.

Yes, around this weekend - I'm finishing testing Bootstrap 4 branch and pulling a trigger.

Yes, around this weekend - I'm finishing testing Bootstrap 4 branch and pulling a trigger.

Please also review this #2036 PR

@mrjoes https://github.com/flask-admin/flask-admin/releases/tag/v1.5.7 Thank you!


Keep the SDC information in Yosys's design structures

This PR fixes #45 by modifying the current SDC plugin implementation to not keep the clock and generated clock information in a separate structure, but in Yosys' internal design representation. For this purpose the clock related attributes from this list on the specified wires are set or updated using create_clocks or as a result of clock propagation.

@mithro Do you want to review this?

Nope, proceed without me!


Add highlight group in README

Language server
No response
Requested feature
It's really difficult to find the highlight groups of this plugin, so it's better to add them to the README file for customization.
Other clients which have this feature
No response

....what highlight groups.

....what highlight groups.

For example, the border of the floating window, the front and back color of the text... I think all the highlight groups used in this plugin should be clarified.

lspconfig only opens a single floating window, which is the exact same as every other floating window in neovim. There are no custom highlight groups.

lspconfig only opens a single floating window (for :LspInfo), which is the exact same as every other floating window in neovim. There are no custom highlight groups.

Got it, does the floating window has a border?

no


[DCOS-40457] Improve install failure detection

Thanks, @elezar for reviewing. I'll have a look at #2638.


Cannot import name 'PixArtAlphaTextProjection' from 'diffusers.models.embeddings'

File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateAnyone-Evolved\nodes.py", line 22, in
from .src.models.unet_2d_condition import UNet2DConditionModel
File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateAnyone-Evolved\src\models\unet_2d_condition.py", line 40, in
from .unet_2d_blocks import (
File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateAnyone-Evolved\src\models\unet_2d_blocks.py", line 15, in
from .transformer_2d import Transformer2DModel
File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateAnyone-Evolved\src\models\transformer_2d.py", line 7, in
from diffusers.models.embeddings import PixArtAlphaTextProjection
ImportError: cannot import name 'PixArtAlphaTextProjection' from 'diffusers.models.embeddings' (D:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\diffusers\models\embeddings.py)

You probably have installed another version of ANIMATE ANYONE: "ComfyUI-Moore-AnimateAnyone"
Delete the folder "ComfyUI-Moore-AnimateAnyone" and install "ComfyUI-AnimateAnyone-Evolved".

You need to update " diffusers " to 0.25.1 ,
Eg. `pip --install upgrade diffusers' will add the new embedding ..
—  I had the same issue yesterday ..

You need to update " diffusers " to 0.25.1 , Eg. pip install --upgrade diffusers==0.25.1 will add the new embedding .. Then " PixArtAlphaTextProjection " can be found !

I did it but this didn't solve the problem. When I send the command: "pip install --upgrade diffusers==0.25.1" Diffusers is installed in Python's "site-packages" folder (the one located in: C:\Users\USERNAME\AppData\Local\Programs\Python\Python310)
Maybe, Diffusers must be installed in the "site-packages" of the "python_embeded". If yes, how do I do it?
Thanks

You need to update " diffusers " to 0.25.1 , Eg. pip install --upgrade diffusers==0.25.1 will add the new embedding .. Then " PixArtAlphaTextProjection " can be found !

I did it but this didn't solve the problem. When I send the command: "pip install --upgrade diffusers==0.25.1" Diffusers is installed in Python's "site-packages" folder (the one located in: C:\Users\USERNAME\AppData\Local\Programs\Python\Python310) Maybe, Diffusers must be installed in the "site-packages" of the "python_embeded"?
If yes, how do I do it?
Thanks

Yes, this is the solution, but first, navigate to Python_Embeded and use the Python executable there. So, in that folder:
 python.exe -m pip install --upgrade diffusers==0.25.1
Important: After doing this, everything worked, however, I had to replace certain modules from the Impact pack with their newer variants that are roughly identical.

python.exe -m pip install --upgrade diffusers==0.25.1

DUUUUUDE!!!
Everything works perfectly, now. No error messages.
THANKS. I'm struggling since yesterday.

i think im facing simillar problems related to this fix but with comfyui, and the animate anyone addon/plugin. i ran the update diffusers in the pythong embeded forlder of comfyui install but didnt solve my issue and got this message when running the update:
DEPRECATION: torchsde 0.2.5 has a non-standard dependency specifier numpy>=1.19.*; python_version >= "3.7". pip 24.0 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of torchsde or contact the author to suggest that they release a version with a conforming dependency specifiers. Discussion can be found at https://github.com/pypa/pip/issues/12063
anythoughts how to fix ?

i think im facing simillar problems related to this fix but with comfyui, and the animate anyone addon/plugin. i ran the update diffusers in the pythong embeded forlder of comfyui install but didnt solve my issue and got this message when running the update:
DEPRECATION: torchsde 0.2.5 has a non-standard dependency specifier numpy>=1.19.*; python_version >= "3.7". pip 24.0 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of torchsde or contact the author to suggest that they release a version with a conforming dependency specifiers. Discussion can be found at pypa/pip#12063
anythoughts how to fix ?

It is written in Yellow, right. This also happens to me and I think you can ignore it.

Right ok but this still hasn't fixed my issue with the nodes in animate anyone to be able to use different samplers I know this isn't strictly the thread for that issue but seems similar programs/code have similar issues

Hi ,

DEPRECATION: torchsde 0.2.5 has a non-standard dependency specifier numpy>=1.19.*; python_version >= "3.7". pip 24.0 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of torchsde or contact the author to suggest that they release a version with a conforming dependency specifiers. Discussion can be found at pypa/pip#12063

This is just saying that torch 0.2.5 has a non standard version specifier that is throwing this " deprecation " warning
that you can ignore. The fault is because there is an asterisk  which won't be recognised once " pip " updates to the next major version and removes support for that and will throw an error.
The issue needs to be fixed in the torchsde repo and the meta data for that package. It's happening because the original maintainers from " google " moved on , and left " torchsde " as a community maintained project. There is a simple one line fix but nobody has merged the PR for it. You can fix it on your end to remove the warning though next time you install torchsde it will be there :
—  Remove the " .* " inside " torchsde-0.2.5.dist-info\METADATA " file :
Requires-Dist: numpy (>=1.19) ; python_version >= "3.7"
—  Issue #131 " Malformed Torch SDE package " :
[ torchsde-0.2.5.dist-info\METADATA ]

Hi ,

DEPRECATION: torchsde 0.2.5 has a non-standard dependency specifier numpy>=1.19.*; python_version >= "3.7". pip 24.0 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of torchsde or contact the author to suggest that they release a version with a conforming dependency specifiers. Discussion can be found at pypa/pip#12063

This is just saying that torchsde 0.2.5 has a non standard version specifier that is throwing this " deprecation " warning that you can ignore. The fault is because there is an asterisk which won't be recognised once " pip " updates to the next major version and removes support for that and will throw an error.
The issue needs to be fixed in the torchsde repo and the metadata for that package. It's happening because the original maintainers from " google " moved on , and left it as a community maintained project. There is a simple one line fix that has been merged months ago but no new updated version released. You can fix it on your end to remove the warning though next time you install torchsde 0.2.5 it will be there :
— Remove the " .* " inside torchsde-0.2.5.dist-info\METADATA : Requires-Dist: numpy (>=1.19) ; python_version >= "3.7"
— Issue #131 " Malformed Torch SDE package " : [google-research/torchsde#131]

In my METADATA there's also this: Requires-Dist: scipy (==1.5.*) ; python_version < "3.7"
Should I also correct it deleting .*, there?


add a gitignore command

Suggestion
🔍 Search Terms
gitignore typescript command
✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code

[x] This wouldn't change the runtime behavior of existing JavaScript code

[x] This could be implemented without emitting different JS based on the types of the expressions

[x] This isn't a runtime feature (e.g., library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)

[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
I'd like to see a gitignore option that will auto-create a gitignore file tailored to Typescript. This is like .NET's dotnet new gitignore. This could include standard node.js options, like /tmp or /dist, but also maybe even .js files entirely or at least source map files.
📃 Motivating Example
"TypeScript has, in many ways, made the lives of JavaScript developers easier. By adding a simple, easy, gitigore creation command, this should make it even easier to integrate your project into a git-based version management software."
💻 Use Cases
I'm creating a new project and want to push it to GitHub, but I don't want to push the built js files, only the typescript files. While I'm in the process of doing that, I may as well add more files to the .gitignore file. Simply adding a tsc gitignore or tsc gitignore --ignore-js, for example, would be so much easier than going online to copy/paste a gitignore, then add a *.js to the end of the file.

Why not just use gitignore?

Someone* should send a PR to https://github.com/github/gitignore/pulls
* Other than a TypeScript engineer who should be spending their time fixing bugs that only we or a small number of other people have the expertise to fix