Trend Micro Potentially unwanted application?

Well I really like Process Hacker. However Trend Micro seems to think its a "unwanted application"

Well I want Process Hacker.

https://www.trendmicro.com/vinfo/us/threat-encyclopedia/malware/PUA.Win32.ProcHack.A
It seems like it has been the trend lately to demonize PH.

arrives on a system as a file dropped by other malware or as a file downloaded unknowingly by users when visiting malicious sites. http://processhacker.{BLOCKED}forge.net/

What malware or websites are 'dropping' Process Hacker? It's interesting they consider Sourceforge malicious.

Before doing any scans, Windows 7, Windows 8, Windows 8.1, and Windows 10 users must disable System Restore to allow full scanning of their computers.

System restore can block TrendMicro...... so you should disable it?  🤔

It seems like it has been the trend lately to demonize PH.

It does a lot more damage to their brand and product since its showing the incompetence of these companies and employees more than anything. These pages have so many errors and lack any references and information that you would get a failing grade at school.
They might mislead some unsuspecting customers into thinking their 'security' products are protecting them from some type of threat but they don't mislead security experts and software developers who are using Process Hacker or have reviewed our source-code.
If they were able to show malicious usage of Process Hacker then we could do something about it but not even one company has been able to produce anything to the development team or anywhere else.

arrives on a system as a file dropped by other malware or as a file downloaded unknowingly by users when visiting malicious sites

Oh, I think I know what happened.
They found Process Hacker when they checked their customers' compromised computers.
Some hackers(script kiddie) use Process Hacker as their tool.
Years ago, my friend had a computer exposing remote desktop in the wild and got hacked. I checked his computer and found the hacker mining Bitcoin and see the portable version of Process Hacker stored in the hacker's working directory.
So Trend Micro thought they need to clean up this file.
But I don't think this is a good way to do this.

So Trend Micro thought they need to clean up this file. But I don't think this is a good way to do this.

They've classified the project (and by extension the owner and developer) as Malware/Spyware on their "Threat Encyclopedia" and state this multiple times on those webpages and in their desktop UI shown to users.

my friend had a computer exposing remote desktop in the wild and got hacked. They found Process Hacker when they checked their customers' compromised computers.

If that was true then why are they claiming the project is malware/spyware and how was Process Hacker able to compomise RDP?
How are we supposed to fix whatever security issue when these companies don't contact the development team?

They only claim the project is PUA.

arrives on a system as a file dropped by other malware or as a file downloaded unknowingly by users when visiting malicious sites

Process Hacker was not going to be used to compromise RDP. I think the hacker use Process Hacker for the following two purposes.

Terminate or suspend antivirus service
Check if the miner process is running properly (They create a script to determinate if the built-in task manager is running, once it finds the task manager is running, the miner was terminated immediately to prevent the user finding anything abnormal. So they need another tool to check if the miner is running normally.)

I think Trend Micro should detect and roll back the change the hacker made instead of create a signature to detect Process Hacker as PUA.

Here are some screenshots

I found Process Hacker running in another account they created.
The interesting thing is that the first letter is different.

It seems that some notable ransomware attacks utilized Process Hacker.

They only claim the project is PUA.

The classification is Malware in their 'threat' directory and they terminate/remove PH using the same dialogs and messages for actual malware.

It seems that some notable ransomware attacks utilized Process Hacker.

How exactly did they utilize Process Hacker?
These vendors are not sharing information with the development team so how are we supposed to fix security issues?

It's crazy but there're numerous of another "security" apps that treat PH as unwanted/risky/hacking tool:

DrWeb
Kaspersky
Yandex
Sophos AV
many others

I've seen malware in the past using PH to terminate AVs and do their "stuff" while the service is restarted (ProcessHacker.exe -c -ctype process -cobject ekrn.exe -caction terminate -s).  It seems that AV companies think that if PH ends up in the systems of their customers, it's most likely through a malware and want to play it safe by marking the tool as a treat (instead of the script that's using it). The same problem has Nir Sofer with his password recovery tools (http://nirsoft.net/). They might as well classify Powershell as PUA because alot of malware use it to compromise systems.

I've seen malware in the past using PH to terminate AVs

You need physical access to the machine with administrative level access? You could just as easily install windbg or livekd and modify the live kernel during runtime but Trend Micro doesn't block actual kernel debuggers? So why are they targeting Process Hacker that doesn't have those same privileges?
You could even execute this powershell script and render the entire machine and operating system permanently unusable and Trend Micro doesn't even block this: https://gist.github.com/dmex/5885ec528b8231fb75d5a591845b96e6
Trend Micro also hasn't reported any security issues to the development team so I think their classification of Process Hacker is clearly unwarranted and likely aimed at targeting open-source applications capable of detecting and removing malware/rootkits their products are unable to detect.

I totally agree that the trend (pun intended) of security companies to mark legitimate programs as threats is totally unjustified.


Performance optimization of put_all required

Currently put_all is single threaded. This results in very low data input performance.
Advise implementing a parallel mechanism, e.g. input a multi-thread or multi-process put_all.

Closing as codes are merged.


Consider directives_ordering for inclusion

Documentation: directives_ordering
I find it very useful, especially in a team of a few people. Is there any particular reason not to include it?
I know this goes beyond Dart, but flutter_lints doesn't have a separate repo and doesn't accept issues.

For some reason this doesn't throw any warnings locally but do throws them in CI.
linter:
  rules:
    directives_ordering: true

Maybe it's a SDK thing.
Anyway, it won't allow me to split directives into additional sections:
import 'package:flutter/services.dart';
import 'package:path_provider/path_provider.dart';

import 'package:my_app/app.dart'; // info • Sort directive sections alphabetically • lib/app.dart:4:1 • directives_ordering
import 'package:my_app/models/index.dart';

so I will have to politely decline this rule.


feat(ci): check changes after yarn build

Q
A

Bug fix?
yes/no

New feature?
yes/no

Tickets
Fix #...

License
MIT

This is a first iteration for https://github.com/symfony/ux/pull/20#issuecomment-740803858.
We used a similar thing at work and it was enough for us, but maybe we should be more friendly/precise, like posting a comment on the PR with the list of files that have not been built.
WDYT @tgalopin?

Hi @Kocal !
Can you avoid creating Draft PR please? It notifies everyone watching the repo for unnecessary reasons :) .
Once your PR is ready we would be happy to review it though!

After discussing with @weaverryan I think the best course of action in the short term is to have a release script that includes building the dist file. I'll add it to the script we use? Thanks for the PR anway!

Alright!


'NSWorkspace' is unavailable in Mac Catalyst

The new File.open() is only defined if AppKit can be imported. However, in a Mac Catalyst app, AppKit is available but NSWorkspace is not. This result in a compilation when adding Files.swift to a Mac Catalyst project.

@andreweades Do you mind submitting a fix for this? I'm not on Catalina myself yet, so won't be able to work on this right now (since I won't be able to test that any patch I'd make actually worked), but would love to see it fixed.
It should just be a matter of adding targetEnvironment(macCatalyst) to the existing #if canImport(AppKit) compiler condition on line 460.

Sure. I’ll have a go.
Sent from my iPhone

On 6 Jan 2020, at 17:17, John Sundell<EMAIL_ADDRESS>wrote:

@andreweades Do you mind submitting a fix for this? I'm not on Catalina myself yet, so won't be able to work on this right now (since I won't be able to test that any patch I'd make actually worked), but would love to see it fixed.
It should just be a matter of adding targetEnvironment(macCatalyst) to the existing #if canImport(AppKit) compiler condition on line 460.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Fix merged 👍


access: Gerrit Approver Access ("approvers")

See https://golang.org/wiki/GerritAccess
Want: https://go-review.googlesource.com/#/admin/groups/1005,members
My gerrit name: Kunpei Sakai
My gerrit email<EMAIL_ADDRESS>All my gardening issues: https://github.com/golang/go/issues?utf8=✓&q=is%3Aissue+commenter%3Anamusyaka+
All my participating CLs: https://go-review.googlesource.com/q/namusyaka%2540gmail.com

At first, @spf13  thank you for showing clear policy at #24850 . I was just thinking about requesting an approver in gerrit for maintenance of the x/net/html package. Of course I am going to continue committing about other packages such as cmd/compile and net/http.
I have improved the parser implementation of the x/net/html package based on the implementation of chromium (blink) and webkit for a while, but I thought that we need to tackle this in the medium to long term.
If necessary, we will need to develop it while communicating with the chromium team. I'm going to do that.
/cc @andybons @bradfitz  @nigeltao

Disclaimer: I don't have experience with @namusyaka's contributions outside of x/net/html.
As for x/net/html, please correct me if https://go-review.googlesource.com/q/owner:namusyaka%2540gmail.com+project:net+html is missing any of your contributions.
How will gaining the approver bit change things, in practice? Code changes (in the Go main repo and under x) still need to be reviewed before being committed. Currently, those reviewers (i.e. me for substantial changes, @bradfitz and maybe others for small changes or rollbacks) can approve and submit as soon as they're happy from a code review perspective. Conversely, even if you had the approver bit, you'd still have to wait for a code reviewer to sign off.
Also, the approval bit generally implies familiarity with the code they're approving for. On the other hand, https://go-review.googlesource.com/c/net/+/94838 is a recent change of yours, which had lots of review comments.  Even good programmers miss some things when modifying unfamiliar code. Not every nuance is captured in the code itself, its nearby comments and the test suite, and sometimes you just need to know what far-away documentation is relevant (or missing!). I'm just saying that you're not yet completely familiar with the subtleties of the x/net/html package. That familiarity will surely grow over time, the more you work with it, but I don't think you're there yet, now.
Sorry to sound negative. I appreciate the work you're doing in x/net/html, and I would like to see it continue. I'm just concious of the risk, in terms of operational security or otherwise, of handing out approver bits, and we don't have the technical capability to limit the approval bit to subsets of the repos, e.g. "just x/net/html".
I'll repeat that I'm not familiar with your other work, such as in cmd/compile and net/http, which may very well be in favor of us granting you the approval bit. I'm only just one opinion on this issue, specifically for you and generally in terms of policy, and am happy for other people to have different opinions.

@nigeltao I appreciate your comment.
Please let me supplement some.

How will gaining the approver bit change things, in practice?

Currently, the parser of the x/net/html package contains a lot of code (after reviewing, of course) that I implemented. On the contrary, it was a statement that I am willing to sustainably maintain.
However, as you say, I am not a familiar with all of the x/net/html package.
And I have been doing continuous contributions (probably go 20+ commits + other packages => 40+ commits) from last year on other packages and gardening some issues, but it is hard to say that we are perfectly familiar with cmd/compile or net/http.
Even if I get the bit, I understand that reviewing my own patch is obviously essential.
If there is one merit, it will be able to smoothly perform bug fixes from others on the code that I created.
I don't know the clear criteria to get the bit (or unexistence?).
But anyway, I will continue to commit to go and its subpackages.
Thanks.


Feature: Auto Select Camera Image

It would be great if there was a configuration to auto select an image taken with the camera when showing both the image picker and the camera option.

@simon-the-canadian Sure, always thought i already implement this.

@esafirm do you have any update regarding this?

It looks like an issue with Samsung device? https://stackoverflow.com/questions/28589509/android-e-parcel-class-not-found-when-unmarshalling-only-on-samsung-tab3


grpc gateway get error:  grpc: the connection is unavailable

do:
curl -L http://localhost:2379/v3alpha/kv/range -X POST -d '{"key": "Zm9v"}'
get:
{"error":"grpc: the connection is unavailable","code":14}
log:
May 29 19:40:30 platform1.vm bash[14858]: proto: no coders for int
May 29 19:45:20 platform1.vm bash[14858]: proto: no coders for int
May 29 19:58:41 platform1.vm bash[14858]: proto: no coders for int
May 29 20:00:43 platform1.vm bash[14858]: proto: no coders for int

my version:
etcd Version: 3.1.7
Git SHA: 43b7507
Go Version: go1.7.4
Go OS/Arch: linux/amd64

FWIW I can not replicate this with 3.1.7 only difference being the go version
#!/bin/bash

ETCD_VER=v3.1.7

# choose either URL
GOOGLE_URL=https://storage.googleapis.com/etcd
GITHUB_URL=https://github.com/coreos/etcd/releases/download
DOWNLOAD_URL=${GOOGLE_URL}

rm -f /tmp/etcd-${ETCD_VER}-linux-amd64.tar.gz
rm -rf /tmp/test-etcd && mkdir -p /tmp/test-etcd

curl -L ${DOWNLOAD_URL}/${ETCD_VER}/etcd-${ETCD_VER}-linux-amd64.tar.gz -o /tmp/etcd-${ETCD_VER}-linux-amd64.tar.gz
tar xzvf /tmp/etcd-${ETCD_VER}-linux-amd64.tar.gz -C /tmp/test-etcd --strip-components=1

 /tmp/test-etcd/etcd --debug=true &

curl -L http://localhost:2379/v3alpha/kv/range -X POST -d '{"key": "Zm9v"}'

{"header":{"cluster_id":"14841639068965178418","member_id":"10276657743932975437","revision":"1","raft_term":"2"}}

etcd Version: 3.1.7
Git SHA: 43b7507
Go Version: go1.7.5
Go OS/Arch: linux/amd64

@hexfusion  I follow your step, it works, but if I add  --listen-client-urls=http://<IP_ADDRESS>:2379,
The question appear:
curl -L http://localhost:2379/v3alpha/kv/range -X POST -d '{"key": "Zm9v"}'
{"error":"grpc: the connection is unavailable","code":14}

@ffffproton Seems related to https://github.com/coreos/etcd/issues/7961 have you tested any of the 3.2 releases?

can't reproduce either.
@ffffproton full etcd server logs? what linux distribution / version?

@hexfusion  Yes, Now I change http://<IP_ADDRESS>:2379 to http://<IP_ADDRESS>:2379, It works.
My linux distribution is centos-7.3.

@ffffproton do you have the full server logs from when etcd is giving grpc: the connection is unavailable?
I can get proto: no coders for int from malformed inputs in 3.1.7 but not 3.2.0. I can't seem to reproduce {"error":"grpc: the connection is unavailable","code":14}, even on a centos 7.3 vm.

I could verify this.

@dopykuh OK, how can I reliably reproduce this?

I am closing this out due to low activity.


Customize Error Page

I am wondering if there is a way to use self error pages like network failure things.
Thanks.

The red box error screen is only for development purposes, and won't show up in a real app.
There's nothing to stop you presenting an error alert using AlertIOS, or building a custom error screen to display in the event of catching a JS exception, but I'd advise against it, as it's not a great user experience.
Users don't expect to see 404-style error pages in a native app - the ideal scenario is that you should ship your app without any showstopping crashes, but in the event that a React Native app does throw an uncaught exception in a release build, it will quit to the home screen lust like a normal app.
Network failures, and other "expected" errors should always be sent back to your JS code in the form of error callbacks, so you can handle these gracefully and appropriately to the context in which they arise, rather than needing to resort to exception handlers and red/blue/pink screens of death :-)


Update wiki

Now that the repo is public, its wiki is available again, but it has not been updated for a while.
The documentation folder in the repo evolved from the wiki, so we can move that content back into the wiki. (Or we can keep the documentation in the source code like this and turn off the wiki.)

I've turned off the wiki since it is outdated. It can be turned back on if we want to move /documentation there.


Automator: update istio/client-go@master dependency in istio/istio@master

Generated by Automator - 2022-02-11T17:49:33+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
f8e109a66299f9293ea020fb237a3061a1eebaf5
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster_istio

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
b92501ab990fbd1d338baf6c3762756849bc9383
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Apartheid South Africa led by ANC

Playing as South Africa (1945 startdate) I have run into another annoying bug.When choosing the Apartheid regime,the African National Congress comes to power instead of the Nasionale Party.

Think this is addressed with #438. Will verify.


Can 'end' event fire if the 'error' event has already fired when streaming?

Hi! I have a simple Claude Sonnet streaming setup with Anthropic NodeJS SDK with this code:
  /** @type {Anthropic.Messages.MessageStreamParams} */
  const payload = {
    max_tokens,
    system,
    messages,
    model: 'claude-3-5-sonnet-20240620',
    metadata: { user_id, },
  };

  const stream = anthropicClient.messages
    .stream(payload)
    .on('streamEvent', (event, snapshot) => {
      // code D
    })
    .on('text', (text) => {
      // code A
    })
    .on('end', () => {
      // code B
    })
    .on('error', (error) => {
      // code C
    });

  try {
    await stream.finalMessage();
  } catch (e) {
    // we already handled potential errors in the on('error') handler above
  }

As per our server logs, it seems code B fires after code C has fired. I checked the SDK code and looks like either 'end' or 'error' can fire but not both, see below:
https://github.com/anthropics/anthropic-sdk-typescript/blob/75c57e10e4545aa873c0d538069fc483e0cacc84/src/lib/MessageStream.ts#L111-114
I want to make sure that is the case: that exactly one of code B or code C will run. Is that true?
Apologies if there's existing documentation on this, would appreciate if you could link me to it. Thanks!

Thanks for your clear and detailed response!


Tokenizer class LlamaTokenizer does not exist or is not currently imported

hey i am trying to use TheBloke/Llama-2-7b-chat-fp16 instead of EleutherAI/pythia-2.8b-deduped but is showing this ValueError: Tokenizer class LlamaTokenizer does not exist or is not currently imported.  please somebody help

Llama-2 works fine.
You are probably on a real old transformer version.
Did you make sure to follow the guidelines in README and also run make setup?

if you share your notebook maybe someone could help

if you share your notebook maybe someone could help

hello I'm arkodeep l. I'm working on the same project with farhan.
we are using the same notebook given in the official readme. we have just changed the dataset and the model.
i did some digging and I think that by default when the virtual environment is being created at the beginning with the "!make setup > /dev/null" command, the dependencies required for the EleutherAI/pythia-2.8b-deduped model are being downloaded. and after that when I try to change the model to TheBloke/Llama-2-7b-chat-fp16 it is giving the error.
i tried experimenting with the Llama model on another notebook without a virtual environment and it works fine. so I think it is the problem with the virtual environment.
here is the exact error for your reference:
File "/kaggle/working/cfg_notebook.py", line 3, in
tokenizer = AutoTokenizer.from_pretrained('TheBloke/Llama-2-7b-chat-fp16')
File "/root/.local/share/virtualenvs/working-MLRu3Pvq/lib/python3.10/site-packages/transformers/models/auto/tokenization_auto.py", line 676, in from_pretrained
raise ValueError(
ValueError: Tokenizer class LlamaTokenizer does not exist or is not currently imported.
the tokenizer can be correctly loaded in the base environment but when it works in the virtual environment it causes the error.

Ah okay, I know why.
In this notebook it is using a very old version of LLM Studio with a fixed git checkpoint:
!cd h2o-llmstudio && git checkout ce10af57ff118a2bbb81b5b3eae12273e290299a -q
You would need to pull the most recent LLM Studio there and adjust accordingly.


Cannot upload to S3

I'm almost there but it fails at my last step...when doing the actual upload. Here's the error:
I20151115-12:26:21.031(2) (android:http://meteor.local/#/tab/settings:0) The provided value 'undefined' is not a valid enum value of type XMLHttpRequestResponseType.
I20151115-12:26:21.386(2)? I/chromium(21516): [INFO:CONSOLE(523)] "Error: "Queue" failed [503] Error in method "/cfs/files/:value/:value/", Error: Error: FS.TempStore.Storage is not set: Install cfs:filesystem or cfs:gridfs or set it manually     at mount... [undefined], Error: failed [503] Error in method "/cfs/files/:value/:value/", Error: Error: FS.TempStore.Storage is not set: Install cfs:filesystem or cfs:gridfs or set it manually     at mount... [undefined]
I20151115-12:26:21.386(2)? I/chromium(21516):     at http://meteor.local/packages/cfs_upload-http.js?40a85d8630caaae705a0a84cc6989fc98fda8487:380:16
I20151115-12:26:21.387(2)? I/chromium(21516):     at http://meteor.local/packages/cfs_upload-http.js?40a85d8630caaae705a0a84cc6989fc98fda8487:106:7
I20151115-12:26:21.387(2)? I/chromium(21516):     at http://meteor.local/packages/underscore.js?46eaedbdeb6e71c82af1b16f51c7da4127d6f285:794:19
I20151115-12:26:21.387(2)? I/chromium(21516):     at XMLHttpRequest.xhr.onreadystatechange (http://meteor.local/packages/cfs_upload-http.js?40a85d8630caaae705a0a84cc6989fc98fda8487:229:11)", source: http://meteor.local/packages/cfs_power-queue.js?c62bc29a130805fdc29f80982e4cb5ebc5467dea (523)

I have the cfs:filesystem, cfs:s3 and cfs:standard-packages installed. I tried even with swapping cfs:filesystem with cfs:gridfs and also installing them both without any luck.

@ciokan
Did you find the solution? I have the same problem.

Same here

Getting the same here.


List Content Types available to Edit

We need to be able to choose which content type we want to edit.

work done


haskellPackages.debian: Fix test failures for ghc 9

Description of changes
haskellPackages.debian: Fix test failures for ghc 9
See https://github.com/clinty/debian-haskell/pull/3
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Thanks!
I've confirmed this builds.


Editing do_alloc for reducing LLVM IR

I think this will speed up compilation, since one way or another everything will come down to this code (but I didn’t compare performance).

I don’t know if the compiler was able to optimize that old code, but it literally checked the same thing twice (due to map and map_err in a row, and roughly speaking it came down to:
pub fn do_alloc<A: Allocator>(alloc: &A, layout: Layout) -> Result<NonNull<u8>, ()> {
    match match alloc.allocate(layout) {
        Ok(ptr) => Ok(ptr.as_non_null_ptr()),
        Err(e) => Err(e),
    } {
        Ok(ptr) => Ok(ptr),
        Err(_) => Err(()),
    }
}

And when the code is written explicitly, it is immediately clear that it looks strange. And why force the compiler to think beyond the need?

And finally, in my opinion, the readability of the code has not only not decreased, but even increased.

@bors r+

@bors r+

:pushpin: Commit 9d23b422c8e6e232c1731e3a2bcda2732c1c32e1 has been approved by Amanieu

:hourglass: Testing commit 9d23b422c8e6e232c1731e3a2bcda2732c1c32e1 with merge 67e3f87970a27a2d46f4340c788029a4ebd76f06...

:sunny: Test successful - checks-actions
Approved by: Amanieu
Pushing 67e3f87970a27a2d46f4340c788029a4ebd76f06 to master...


Error when compiling the tcp_client/server example

I see a new pull_requests for the socket_api so i want to comile the example and test. But when I use cmake to complie the code, there is an error
/wasm-micro-runtime/samples/network/wasm-src/tcp_client.c:14:10: fatal error: 'wasi_socket_ext.h' file not found #include <wasi_socket_ext.h>
how can i fix it?

I compile the sample use the command
cmake -DWASI_SDK_PREFIX=/opt/wasi-sdk -DCMAKE_TOOLCHAIN_FILE=/home/yxz/wasm_tools/wasm-pr/wasm-micro-runtime/wamr-sdk/app/wasi_toolchain.cmake -DCMAKE_SYSROOT=/opt/wasi-sdk/share/wasi-sysroot ..
make

And the result shows wasi_socket_ext.h file not found

Cannot repeat it locally. Only some general suggestions:

please checkout to the latest commit d0a5ce739cfee3d6d5553e9c7d21fe91d9845b6f and the branch dev/socket_api. It is still an experiment feature.
a shorter command like $cmake -DWASI_SDK_DIR=/opt/wasi-sdk ..  or even $cmake .. is fine.

It can work now. I rebuild it.
But some eror happens when i try to run the wasm file.
If i run the executable file tcp_server and tcp_client, it works and can receive the massage.
But when I want to run tcp_server.wasm use
../../../product-mini/platforms/linux/build/iwasm tcp_server.wasm

It comes to an error
WASM module load failed: invalid section id

@qmyyxtl please build iwasm with libc-wasi and lib-pthread enabled: cmake .. -DWAMR_BUILD_LIB_PTHREAD=1, thanks.
We also uploaded PR #1040 to refine to sample and document, the user experience should be better after it is merged.

@wenyongh thanks a lot, I follow the PR README and build it. It seems that building still has some problems, but the tcp_server.wasm and tcp_client.wasm can be run now.
The cmake result:
[ 98%] Performing install step for 'wasm-app'
Error copying file "tcp_client.wasm.dump" to "/home/yxz/wasm_tools/wasm-pr/wasm-micro-runtime/samples/socket-api/build".
Error copying file "tcp_server.wasm.dump" to "/home/yxz/wasm_tools/wasm-pr/wasm-micro-runtime/samples/socket-api/build".
make[2]: *** [CMakeFiles/wasm-app.dir/build.make:102: wasm-app-prefix/src/wasm-app-stamp/wasm-app-install] Error 1
make[1]: *** [CMakeFiles/Makefile2:195: CMakeFiles/wasm-app.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

I notice that wabt is required but I havn't downloaded it yet. Is it the reason for the error or not? Although I think it doesn't matter for running

WABT is used to examine that the socket APIs are all bridged to imported ones. Please feel free to skip that by changing CMakeLists.txt.


The foreground color does not adapt to the background color

Describe the bug
Enabling lsp.color with background = true does not change the guifg of the text to black or white as in the README screenshot.
To Reproduce
Steps to reproduce the behavior:

Create a flutter project
open the main.dart file
Define const white = Color(0xFFFFFFFF);

Expected behavior
guifg for Color(0xFFFFFFFF) is black.
Screenshots

System information

OS: Arch Linux 5.16.8-arch1-1
Flutter version: 2.10.1
Is flutter in $PATH: Yes
neovim version: NVIM v0.7.0-dev+1076-gf378df846

@fitrh I wouldn't describe this as a bug since the behaviour of making the colour black or white is not specifically advertised functionality. FWIW this functionality was copied from a PR in nvim without much tweaking tbh I'm not really likely to go wild with trying to derive specific colour behaviours based on the background etc. essentially it is taken as is and only here until the functionality is officially supported in nvim core. In the screenshot above the text to my mind is visible which is good enough, i.e. this is the most that this plugin will try to do.

I just skimmed the diff and found this function, if I understand it correctly, it set the foreground to black or white based on the result of perceived_lightness right ?

@akinsho how you can get black or white foreground as in the README ?

The text is visible because I zoomed it, using my daily font size will make it hard to read.

@fitrh I didn't write this logic, and so I don't know a great deal about how it works, if you're willing to dig in and raise a PR to make this change then I'm happy to review but as I mentioned I only implemented this because another user requested it and there was some code lying around in nvim core that added this functionality. I don't want to go down the rabbit hole of basically building a mini colour presentation plugin within this plugin and I don't personally intend to massively tweak the logic I borrowed from nvim core since I hope eventually it will be available natively.

To workaround this issue maybe use one of the other options e.g. foreground or virtual_text

The cause is treesitter, if I disable treesitter highlight, the color foreground highlighted correctly, also because of this, set foreground = true does not work.

Okay I've looked into this a bit more, and it was because Treesitter's highlighting overrides the highlights set by this plugin, so I've increased the priority of the highlights for this plugin, so the foreground should always be black or white


Add compressed RingCT video

Adds a compressed RingCT video.
Resolves #435.

I think you'd want to squash the commits into one.
If you've commited in the uncompressed video and the compressed video, they'll both be in the history taking up space.

@mattcode55 is correct - makes the git history huge, plz squash

@SamsungGalaxyPlayer ping

I need to learn how to do this. I will do it though.

@luigi1111 I finally squashed these :)

I think the video needs embedding too :)
Should it go in a new carousel slide in get-started/what-is-monero/index.md?

@mattcode55 yes, it needs to be embedded too. Can you open a new PR for that please?

@SamsungGalaxyPlayer Does the thumbnail in #521 look okay?


Can't return generic deserialized data

#[derive(Debug, Serialize, Deserialize)]
pub struct File (std::path::PathBuf);

impl File {
    pub fn json_get<'de, T: serde::Deserialize<'de>>(&self) -> errors::Result<T> {
        let mut buf = Vec::new();
        std::fs::File::open(&self.0)?.read_to_end(&mut buf)?;
        let res: T = serde_json::de::from_slice(&buf).chain_err(||format!("Can't deserialize file {:?}", self.0))?;
        Ok(res)
    }
}

Output:
error: `buf` does not live long enough
  --> src/lib.rs:52:50
   |
52 |         let res: T = serde_json::de::from_slice(&buf).chain_err(||format!("Can't deserialize file {:?}", self.0))?;
   |                                                  ^^^ does not live long enough
53 |         Ok(res)
54 |     }
   |     - borrowed value only lives until here
   |
note: borrowed value must be valid for the lifetime 'de as defined on the body at 49:89...
  --> src/lib.rs:49:90
   |
49 |       pub fn json_get<'de, T: serde::Deserialize<'de> + Clone>(&self) -> errors::Result<T> {
   |  __________________________________________________________________________________________^ starting here...
50 | |         let mut buf = Vec::new();
51 | |         std::fs::File::open(&self.0)?.read_to_end(&mut buf)?;
52 | |         let res: T = serde_json::de::from_slice(&buf).chain_err(||format!("Can't deserialize file {:?}", self.0))?;
53 | |         Ok(res)
54 | |     }
   | |_____^ ...ending here

error: aborting due to previous error

Serde 1.0.0

Never mind, should have used a HRTB for the Deserialize binding

Yep. As you found, <'de, T: Deserialize<'de>> means that T can be deserialized from some lifetime (the caller gets to decide) while <T: for<'de> Deserialize<'de>> means T can be deserialized from any lifetime. There is a shorthand for the latter - <T: serde::de::DeserializeOwned> which is more intuitive to read. It means T can be deserialized without borrowing any data. That trait is automatically implemented for any types that satisfy the HRTB.

Thanks for pointing me to the shorthand.


time-consuming and total data statistics for tsm files

Time-consuming to print filegroups after migration
The amount of data to print, how many tags, how many fields, and how many rows.

I will support this.


Sort ascending with server-side pagination.

Laravel: v6.10.1
Voyager: v1.3.1
PHP: 7.2.25
Database: mariadb 10.3.20

Description
Sort ascending doesn't work it always defaults to descending.
Steps To Reproduce
Steps to reproduce the behavior:

Go to BREAD
Click on Server-side Pagination
Sort via column in ascending order.
Default sort is descending order.

Screenshots

Additional context
Problem is because the order_direction is never used.
$sortOrder = $request->get('sort_order', $dataType->order_direction);
https://github.com/the-control-group/voyager/pull/4690/commits/ae8f0f1819d8331ef33e3a29c160d51384a5d605

Fixed in #4557 needs to be merged.
That fix you posted is not going to work for both server and client side ordering.


docs: HTML and JSX examples in some pages are empty

On which page do you see this issue?
https://daisyui.com/components/menu/
Describe the issue

it looks like that only some v3 examples are empty. Clean my cache does not help.
What browsers are you seeing the problem on?
Chrome, Safari

Will be fixed in 5 min...

Fixed. Let me know if you found other issues 🙏


Text inputs - Further improve the text inputs design

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to any page in the app that has a text input (or several, for example: staging.new.expensify.com/bank-account/new)

Expected Result:
Text inputs should have a proper size and alignment.
Actual Result:
Adding comment from @shawnborton here

All inputs (text/selects) have too much horizontal padding by just 1px.
The position of the small gray label is slightly too high when the input has a value
Select inputs are too tall, they should be 52px tall but they are 54px which makes them taller than other inputs

Workaround:
None needed, visual issue.
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.1-0
Reproducible in staging?: yes
**Reproducible in production?:**yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1632330334042400
View all open jobs on GitHub

Triggered auto assignment to @Dal-Papa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Triggered auto assignment to @michelle-thompson (Design), see these Stack Overflow questions for more details.

Select the input to have two outer and inner borders and I disabled the Inner one but the outer border is causing the extra height. So we should enable inner and disable outer.
Input has this box model

This seems to be correct except the border is 0.8px.

So I think this is almost like a box-sizing mixup - 12px for horizontal padding is technically correct, but the border should be included in that. What should be happening is that you have a 1px border on the left edge, and then 11px of padding after that, and then the content. I agree, it is strange that the border is .8px and not 1px.
Figma screenshot for reference:

I don't think Box-model include a border in padding on the Web, we are already using box-sizing:border-box.
What you said would be box-sizing:padding-box but that is not supported in any browser https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing#browser_compatibility

Ah yeah, I think what I am saying is we just need to reduce the hard-coded horizontal padding value by 1px on each side 😄

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Throwing the External label for contributors to grab.

Proposal (based on the discussion above).

Select the input to have two outer and inner borders and I disabled the Inner one but the outer border is causing the extra height. So we should enable inner and disable outer.

I will reduce the horizontal padding to 11px so that it is 1px less on both sides.

Doing point 1, should correctly place the labels as well. Otherwise, I can adjust that in the PR review.

Upwork job

Problem Statement: -

All inputs (text/selects) have too much horizontal padding by just 1px.
The position of the small gray label is slightly too high when the input has a value
Select inputs are too tall, they should be 52px tall but they are 54px which makes them taller than other inputs.

I have done deeply look at your issue. So, it can be solved by using react-native CSS properties in the following way.
Proposed Solution: -
-We should minimize the Top padding then it will be fixed. And another thing that I will try is by doing just padding-Left it can also be a good solution. By disable the border, it will not be fixed. Error in the padding and the border height is not too much that can be a problem here.

Grey label can also be fixed by minimizing the horizontal padding .
And the third issue is always proposed I can do it by reviewing that.

Thanks

Problem Statement: -

All inputs (text/selects) have too much horizontal padding by just 1px.
The position of the small gray label is slightly too high when the input has a value
Select inputs are too tall, they should be 52px tall but they are 54px which makes them taller than other inputs.

I have done deeply look at your issue. So, it can be solved by using react-native CSS properties in the following way.
Proposed Solution: -

We should minimize the Top padding then it will be fixed. And another thing that I will try is by doing just padding-Left it can also be a good solution. By disable the border, it will not be fixed. Error in the padding and the border height is not too much that can be a problem here.
Grey label can also be fixed by minimizing the horizontal padding.
The third and final issue is already proposed I can do it by reviewing that.

Thanks

Triggered auto assignment to @pecanoro (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Hey Rehan! Happy to! Could you please request this in a quick email to<EMAIL_ADDRESS>so I can grab your email address and get you added? 😊

Please review the proposal https://github.com/Expensify/App/issues/5462#issuecomment-927869687

For future reference, there is a follow-up PR https://github.com/Expensify/App/pull/5805

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.8-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/5742

If no regressions arise, payment will be issued on 2021-10-30. :confetti_ball:

Hey @parasharrajat ! If you could accept the invite to the new Upwork posting that would be great https://www.upwork.com/jobs/~01bf778387677c2274
The OG post closed because of the n6 hold

I will accept the job but I am still working on a follow up PR so let's just not release the payment for now and until that PR is deployed we can hold the payment.

Ok thanks for the heads up! Offer sent

Removed [HOLD for payment 2021-10-30]  from the title

This issue has not been updated in over 15 days. @pecanoro, @parasharrajat, @MitchExpensify, @michelle-thompson eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

In progress... Not monthly

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.18-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/5805

If no regressions arise, payment will be issued on 2021-12-15. :confetti_ball:

Requesting price increase for this job. Originally
Why

Scope of the issue increased drastically, from Actual results and proposal.
I had to create two PR's to cover the changes.
Eventually plan changed from adjusting the input styles to refactoring them. I had to refactor(redesign) the existing BaseExpensiInput(which was not part of this issue) to fix the root cause which was not mentioned in the issue but will save us further issues like this one.
I had to refactor the uses of ExpensiInput throughout the app. Thus testing them all for regressions. It could have been a separate issue and PR. but that did not make sense without this PR so I decided to do it in one.

Based on the above and the Actual time spent is way more than anticipated, I request the price increase for the job. The fact that the payment of one-liner issues is greater than this does not justify it.
cc: @MitchExpensify

I think that is a fair assessment Rajat, I agree with you.

@pecanoro can you review this internal SO to determine the price increase?

@parasharrajat what do you think it's a fair price?

@pecanoro Sorry, which price?

Oh sorry, maybe I didn't explain myself properly haha How much would you like it increased?

Well, that would be hard for me to tell. I can't arbitrarily tell a value. What does the internal SO say? I would say at least $500.

$500 sounds reasonable. I don't want to arbitrarily increase prices without your input, you are more aware of the time you invested in the issue than me and we want it to be fair.

Ok. $500 is fine. Anyways, there is a hold bonus so that should cover it.  Thanks, @pecanoro.

@parasharrajat so it should be

$250 original issue
$250 n6 hold bonus
$500 scope increase.
Total - $1000

is that accurate?   cc @MitchExpensify since you're CM

Looks good to me. Thanks.

Paid (cuz I was already in this issue).  Thanks @parasharrajat


Tutorial to run MSS in Docker.

It is an excellent practice to create a docker container for MSS to run on devices with less hassle to set up and hassle-free development.

We can create a docker file by which we can mention in the docs, the steps to run it, what you thinks @ReimarBauer .

We had this in the past in this repo, and moved it to an own repository.
it is documted on:
https://mss.readthedocs.io/en/stable/installation.html#use-docker

https://github.com/Open-MSS/dockerhub
https://github.com/Open-MSS/singularity

Seems something changed, the last version on dockerhub is 5 month old :(

the stable image is updated, but that needs to become improved. We should not have this on any commit, only when I set a release tag. Do you know @Mr-Sunglasses how this could be done? The stable image is for users, or none developers.
For the developer indeed it is a good idea to describe, how to use the same image we use for the testing setup here :)
With the regular rebuild  of these images this is pretty save that we catch new build issues early.
We have to use as developers for stable and develop branch a different image.

when its done, we can rename it to "Tutorial for developers to reuse testing Docker containers" a better name in the release history list.

Yup will do it 👍🏻.

we could easily without a dependency to releases add better practises to the pages, e.g.
https://open-mss.github.io/develop/docker_images
pages cannot and should not try to cover the release related documentations. It is more like a supplement.

related https://github.com/Open-MSS/MSS/issues/1684

Hi, is this issue still open? I'm a beginner on open source contribution. I would be really grateful if someone could guide me or at least source me to basic issues I can help with.

Hi @CipJusCodin
at the moment I can merge the PR linked to this, the issue gets closed.
Do you want to join us in slack? see https://open-mss.github.io/contributing/

Yes sure. I have sent a mail request to join the slack workspace


IPC control of ffplay

Create a way to remotely control ffplay during playback. This will be used in #9

It would be really nice. Radio-active project is using ffplay and currently there is no way to play/pause.


move the docs page

This change should move https://huggingface.co/docs/datasets-server to https://huggingface.co/docs/dataset-viewer.
cc @mishig25: we also need to redirect https://huggingface.co/docs/datasets-server to https://huggingface.co/docs/dataset-viewer. Where do we do it?

this file need to be changed too https://github.com/huggingface/dataset-viewer/blob/main/.github/workflows/doc-pr-build.yml

to changes these lines as well https://github.com/huggingface-internal/moon-landing/blob/94daef6d9d6c77c70b23de6a0612dd1d93ea0978/server/views/pages/DocsPage/consts.ts#L256-L258

OK, let's go!


Web

TestProject.zip

request  rejected. changes on ws project files detected. please fetch updates from master branch.


Remove dependency of charset-parser. fix #305

Remove dependency of the deprecated charset-parser module. fix #305

Because we use eslint rather than jshint, so pls remove the head line of the source file.

Sorry for that. I have removed it.


map operator in word_count example pipeline fails

What happened?
Running the map pipeline fails (see log below).
In the code (map.go), the first argument is used as inputDir. The first parameter is /pfs/scraper. Then, in line 43, a filepath.Walk(...) is started. As you can see in the log below, the first processed "file" is /pfs/scraper. The check if the file is a directory doesn't work as one would expect. Maybe this is due to the fact that /pfs/scraper is a symlink and therefore treated as a file?
The following stackoverflow question might offer a workaround: https://stackoverflow.com/a/32912648
starting to download data
finished downloading data after 19.009868ms
beginning to run user code
2018/12/21 11:35:57 scanning /pfs/scraper
2018/12/21 11:35:57 read /pfs/scraper: is a directory
errored running user code after 7.573763ms: error cmd.WaitIO: exit status 1
failed processing datum: error runUserCode: error cmd.WaitIO: exit status 1, retrying in 0s

How to reproduce it?
cd examples/word_count/
pachctl create-repo urls
pachctl put-file urls master -f Wikipedia
pachctl create-pipeline -f scraper.json
pachctl create-pipeline -f map.json

Anything else we need to know?:
Environment?:

Kubernetes version (use kubectl version):

Rancher v2.0.8 (using RKE)
Kubernetes Version: v1.11.2

Pachyderm CLI version (use pachctl version):COMPONENT           VERSION
pachctl             1.8.0
pachd               1.8.0

On-Premise installation using RKE (Rancher)

Thanks for the report @David-Development. We'll test this ourselves and make any needed fixes.


Apger - adding Wiz Collector.  adding RiskAndMorty Collector.

README.md files also included.

Prefaced the collector template files with collector- for the Wiz collector files


[do not merge] 4.9.1 debug geometry

Don't merge! PR only so travis builds this branch for enabling debug geometry output.
@TheMarex also looks like develop should be rebased against 4.9.1?

Moved this over to https://github.com/Project-OSRM/node-osrm/pull/135


Resolve conflicts and fix failing tests

Purpose

Resolve conflicts and fix failing tests

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

:exclamation: No coverage uploaded for pull request base (remove-impl@ff5837a). Click here to learn what that means.
The diff coverage is 50%.

@@              Coverage Diff               @@
##             remove-impl   #21504   +/-   ##
==============================================
  Coverage               ?   19.17%
==============================================
  Files                  ?       56
  Lines                  ?     1528
  Branches               ?      233
==============================================
  Hits                   ?      293
  Misses                 ?     1219
  Partials               ?       16

Impacted Files
Coverage Δ

tool-plugins/vscode/src/extension.ts
0% <0%> (ø)

tool-plugins/vscode/src/core/extension.ts
28.37% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff5837a...7baf6a0. Read the comment docs.


Fix isReservedName method

I think the line check if(!this.options.reservedStrings.length) should be change to if (!this.options.reservedNames || !this.options.reservedNames.length)

Coverage remained the same at 97.991% when pulling ca97ebbda76d06491f1812f170dd52dd3ae22a7e on kida7:patch-2 into dfbb41bf35e482f72815fcc8e179063f6c81a06c on javascript-obfuscator:master.

Hi.
this.options.reservedNames should be always as array here, because of this preset:
https://github.com/javascript-obfuscator/javascript-obfuscator/blob/master/src/options/presets/Default.ts
If no reservedNames options were added to the obfuscator options, then the value from this will be added to the options object instead.

Oh. Thank you, i was wrong. Fixed it on my side with tests


Vim response time on windows 7

I'm using windows 7.
I usually use cmd, and hitting esc while in insert mode in vim is instant. When using alacritty there's a delay of ~3 secs after I hit escape until it exits insert mode. If I happen to press an arrow key in that interval vim actually inserts a weird cross shaped character in the text document. I've tried changing the default shell to cmd instead of powershell, but same thing (I also checked if powershell had any noticeable delay - it didn't).
As an aside alacritty uses about 35+kb of ram after I open it without doing anything, and after printing a few "DIR"'s it can easily reach 45+ (While cmd stays at around 1kb), but I'm not too worried about that and it's probably to be expected.
Also unrelated, but I think https://github.com/jwilm/alacritty/issues/1748 is no longer an issue.
As a third unrelated thing, I could not figure out a way to copy the cross shaped character to share here. Is there one (Or are there plans to add one?)? (On windows)

I usually use cmd, and hitting esc while in insert mode in vim is instant. When using alacritty there's a delay of ~3 secs after I hit escape until it exits insert mode

Use ConPTY, this is a Windows bug and there's nothing Alacritty can do (see https://github.com/jwilm/alacritty/issues/1680).

As an aside alacritty uses about 35+kb of ram after I open it without doing anything

That's just the cost of loading the graphics drivers, after that Alacritty should be fairly conservative on memory usage.

As a third unrelated thing, I could not figure out a way to copy the cross shaped character to share here. Is there one (Or are there plans to add one?)? (On windows)

If you're asking for a way to copy/paste, it's bound to ctrl+shift+c/v by default, similar to what most other terminal emulators do.


Render function called whenever a computed value's dependency is updated, though the value didn't change

Version
2.5.13
Reproduction link
https://jsfiddle.net/72gzmayL/
Steps to reproduce
Open the jsfiddle link, see console output.
What is expected?
Render function isn't called.
What is actually happening?
Render function is called even when nothing is changed.

This creates unnecessary render function calls, which leads to performance issues when the component is complex and render function calls aren't cheap.

#featureNotBug 😅
the value of computed calculate is called after getter has been accessed (in render function)

Ouch, I was debugging for half a day why suddenly I've got some stuttering animations lately. :smile:


Fix for URL bar sometimes fails to select URL on tap

Task/Issue URL: https://app.asana.com/0/414709148257752/1201408131067984/f
Tech Design URL:
CC:
Description:
Change to url selection behaviour so that cursor no longer moves to end of the url when address bar tapped, as this impacted the selection of the URL.

Steps to test this PR:

Visit URLs with long and short addressed and confirm that when tapping the address bar the cursor does not move to the end of the address and that the full address is selected every time

Copy Testing:

[ ] Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

[ ] Portrait
[ ] Landscape

Device Testing:

[ ] iPhone SE (1st Gen)
[ ] iPhone 8
[ ] iPhone X
[ ] iPhone 14 Pro
[ ] iPad

OS Testing:

[ ] iOS 14
[ ] iOS 15
[ ] iOS 16

Theme Testing:

[ ] Light theme
[ ] Dark theme

Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

Created the follow up task since it was already in my brain :)
https://app.asana.com/0/414709148257752/1203132885003287/f

Thanks @brindy! Nice catch with the edge cases (literally!) + thanks for creating the follow up task 🙂


Should we need to add QoS policy in Egress feature?

Describe what you are trying to solve
Egress feature is a CRD API that manages external access from the Pods in a cluster, and centralized redirects the SNAT packets to Egress Nodes. It may happen that some Pods occupy too much Egress SNAT bandwidth, such as third-party data copy, and there may cause network congestion on Egress Nodes. Although the current k8s has  Pods bandwidth limitation function, but only unified set ingress and egress traffic, the Egress SNAT traffic cannot set QoS separately.
Maybe we can add QoS function for Egress feature, we can add bandwidth or pps limitation for it.
Describe the solution you have in mind
1.Maybe we can use ovs meter to implement k8s QoS feature, such as Pods Ingress/Egress bandwidth/pps limitation, Pod to Services bandwidth/pps limitation.
But I have compared between ovs meter and tc, ovs meter is not as good as tc, the jitter for ovs meter is bigger than tc.
2.Use ovs meter to implement Egress QoS, only add bandwidth or pps limitation for Egress SNAT packets.

@Jexf can you clarify the difference between solutions 1. and 2.? They both mention using OVS meters for the implementation.
@tnqn / @wenqiq any thoughts on this? That sounds like a good differentiating feature to me (and maybe the Egress Status could even report some information about bandwidth usage if this is technically possible based on the implementation method?).

@antoninbas Thanks for the reply.
Solutions 1:
Now the k8s community uses annotation to add QoS configuration information. Not only need to create an independent ifb device for each pod, but also need to restart the pod to make the configuration take effect after modifying the QoS configuration.
Maybe we can use crd to save QoS configuration and use meter to implement QoS function:

use crd to save QoS configuration, flexible setting the namespace and pod label for pods, which need to configure QoS Policy, maybe we can implement namespace-level QoS function.  the crd example:

apiVersion: crd.antrea.io/v1alpha1
kind: Qos
metadata:
  name: qos-sample-1
spec:
  appliedTo:
    - podSelector:
        matchLabels:
          app: qospolicy
      namespaceSelector:
        matchLabels:
          namespace: qospolicy
  ingress:
    rate: 10000
    burst: 2000
    type: mbps
  egress:
    rate: 10000
    burst: 2000
    type: mpps

use meter to implement QoS function, not need to an independent ifb device for each pod(redirecting traffic to the ifb device may cause performance loss), the meter also can implement pps limit function.
We can also reuse the  meter qos pipeline to implement Egress SNAT QoS function.

Solutions 2:
Only use meter to implement Egress SNAT QoS function, only add bandwidth or pps limitation for Egress SNAT packets

Good idea.About solution 1, I think a more appropriate name of CRD kind is bandwidth instead of kind: Qos?
IMO, I perfer solution 1, however the more conventional way to limit the bandwidth on pods is througth annotation in k8s community.
If we want to add QoS function for Egress feature, I think solution 2 should be more appropriate now.

The idea sounds good to me.

Will the QoS apply to off-cluster egress traffic of all Pods selected by the Egress (or the QoS if it's another CRD), or it's per Pod?
Given Kubernetes has provided a way to specify total ingress and egress bandwidth of a Pod, I feel we could just add a QoS applying to off-cluster Egress traffic only. It could be an optional field of the Egress CRD.
For @antoninbas's idea about reporting bandwidth usage to Egress Status, I think the answer of 1 may matter. If it's per Pod QoS, it may be more difficult to report. But I feel generally etcd may be not suitable to store frequently updated data, for which reason metrics-server and antrea networkpolicystats use aggregated apiserver to serve metric data.

Good idea.About solution 1, I think a more appropriate name of CRD kind is Bandwidth instead of kind: Qos?
IMO, I perfer solution 1, however the more conventional way to limit the bandwidth on pods is througth annotation in k8s community.
If we want to add QoS function for Egress feature, I think solution 2 should be more appropriate now.

Thanks for your reply,  Now the Kubernetes community qos function is so simple, if we use a new CRD to define and save bandwidth limitation info, we can implement a series of functions：

namespace-level bandwidth limitation, we can add scope field in  Bandwidth CRD,  the sharedvalue means the applied pods share the sampe  meter qos rule,  and the standalone value means  each pod using a meter qos rule. So we can usescope sharedvalue for  namespace-level bandwidth limitation, the crd exmaple :

apiVersion: crd.antrea.io/v1alpha1
kind: Bandwidth
metadata:
  name: bandwidth-sample-for-namespace
spec:
  appliedTo:
    - podSelector:
        matchLabels:
          app: qospolicy
      namespaceSelector:
        matchLabels:
          namespace: qospolicy
  ingress:
    rate: 100Mbps
    burst: 100Mbps
    scope: shared
  egress:
    rate: 100Mbps
    burst: 100Mbps
    scope: shared

pps limitation, the crd exmaple :

apiVersion: crd.antrea.io/v1alpha1
kind: Bandwidth
metadata:
  name: bandwidth-sample-for-namespace
spec:
  appliedTo:
    - podSelector:
        matchLabels:
          app: qospolicy
      namespaceSelector:
        matchLabels:
          namespace: qospolicy
  ingress:
    rate: 100Mpps
    burst: 100Mpps
    scope: standalone
  egress:
    rate: 100Mpps
    burst: 100Mpps
    scope: standalone

Solve a series of problems forannotation  and redirecting traffic to the ifb device.

@tnqn Thanks for your reply. Yes, we can just add an optional field in the Egress CRD for Egress bandwidth limitation, and it not conflict with the Bandwidth limitation CRD. Maybe we don`t need to add meter qos rule for each pod,  just sharing a meter qos rule for applied pods may be more simple.

Hi @Jexf,
Sorry to see this excellent feature proposed by you was blocked by some technical issues before. The existing implementation allowed different Egress to share the EgressIP, making it challenging to identify which exact Egress the packets belong to on the EgressIP Node.
However, we recently had another round of review and discussion on it, and we basically reached an agreement that typically, users want different EgressIPs to differentiate Pods when creating different Egress objects. We could assume/ensure that Egress with QoS has its dedicated EgressIP, making things much more manageable.
I am reaching out to you to inquire about any updates you may have on this item. Specifically, what is your opinion about the new agreement? Are you still interested in or have the bandwidth to work on this item? Or have you already implemented a similar feature on your own fork/project?
Please let me know if you have any questions or ideas to share. Thank you so much for your time and consideration.
BTW, I also sent an email to you via<EMAIL_ADDRESS>which is reported as undeliverable lol.

Good idea.About solution 1, I think a more appropriate name of CRD kind is Bandwidth instead of kind: Qos?
IMO, I perfer solution 1, however the more conventional way to limit the bandwidth on pods is througth annotation in k8s community.
If we want to add QoS function for Egress feature, I think solution 2 should be more appropriate now.

Thanks for your reply, Now the Kubernetes community qos function is so simple, if we use a new CRD to define and save bandwidth limitation info, we can implement a series of functions：

namespace-level bandwidth limitation, we can add scope field in  Bandwidth CRD,  the sharedvalue means the applied pods share the sampe  meter qos rule,  and the standalone value means  each pod using a meter qos rule. So we can usescope sharedvalue for  namespace-level bandwidth limitation, the crd exmaple :

apiVersion: crd.antrea.io/v1alpha1
kind: Bandwidth
metadata:
  name: bandwidth-sample-for-namespace
spec:
  appliedTo:
    - podSelector:
        matchLabels:
          app: qospolicy
      namespaceSelector:
        matchLabels:
          namespace: qospolicy
  ingress:
    rate: 100Mbps
    burst: 100Mbps
    scope: shared
  egress:
    rate: 100Mbps
    burst: 100Mbps
    scope: shared

pps limitation, the crd exmaple :

apiVersion: crd.antrea.io/v1alpha1
kind: Bandwidth
metadata:
  name: bandwidth-sample-for-namespace
spec:
  appliedTo:
    - podSelector:
        matchLabels:
          app: qospolicy
      namespaceSelector:
        matchLabels:
          namespace: qospolicy
  ingress:
    rate: 100Mpps
    burst: 100Mpps
    scope: standalone
  egress:
    rate: 100Mpps
    burst: 100Mpps
    scope: standalone

Solve a series of problems forannotation  and redirecting traffic to the ifb device.

I like this example. However, wouldn't it be better to follow the same standard of ACNP and ANP ? namely a separate crd for namespaced and cluster scoped.
Also would this limit bandwidth within the namespace or just for traffic originating from outside the namespace? Personally I would love to be able to specify both, there are scenarios where you may or may not have a fast private link between your nodes and limiting each namespace to something sensible would be great. In the cases where that's not a problem it would be great to only limit public traffic.
To expand even further, imagine the scenario where you host services outside of the current cluster but may or may not wish to impose limits to/from those services then a cidr selector to exclude/include ips from the limiter would also fit nicely.

The PR https://github.com/antrea-io/antrea/pull/5425 is for this issue.


Add additional properties key

Schema has a strict interpretation of the schema, and is explicit about
what it accepts. A conforming JSONSchema document should set
"additionalProperties" to false to document this behavior.
This documents the existing behavior of schema, which is do not accept
parameters which have not been specified.
@see http://json-schema.org/latest/json-schema-validation.html#anchor64

@smyrman one of my co-workers pointed out it would probably be best to set this value, as it's basically the behavior of schema.

I thought it defaultet to false, but I see now that it does not http://json-schema.org/latest/json-schema-validation.html#anchor64
Thanks

Looks good to me!

@rs can you take a look? thanks

thank you!


RA doesn't seem to respect cfg on fields

pub struct ZlibByteIter<'s> {
  pub(crate) current: &'s [u8],
  pub(crate) idat_iter: IdatIter<'s>,
  #[cfg(not(feature = "png_skip_adler_checks"))]
  pub(crate) adler: u32,
}

impl<'s> ZlibByteIter<'s> {
  fn from_current_and_iter(current: &'s [u8], idat_iter: IdatIter<'s>) -> Self {
    #[cfg(not(feature = "png_skip_adler_checks"))]
    {
      Self { current, idat_iter, adler: 1 }
    }
    #[cfg(feature = "png_skip_adler_checks")]
    {
      Self { current, idat_iter }
    }
  }
}

This will report the second cfg variant as missing the adler field, which doesn't exist under that configuration.

I think this should have been fixed by https://github.com/rust-analyzer/rust-analyzer/pull/3880, but that PR was merged 11 days ago.

It seems I have, rust-analyzer version: 2020-04-13 (c388130), which is newer than 11 days ago if my math is right

which doesn't exist under that configuration.

What's your rust-analyzer.cargo.features settings ?

I think the problem might rather be that we don't support cfg on blocks (or do we?) :thinking:

For now cfg is partially supported on struct fields, and function as far as I remember. And when I say partially it's mainly because it just check the default features in your cargo.toml. I think it should work with this kind of syntax:
pub struct ZlibByteIter<'s> {
  pub(crate) current: &'s [u8],
  pub(crate) idat_iter: IdatIter<'s>,
  #[cfg(not(feature = "png_skip_adler_checks"))]
  pub(crate) adler: u32,
}

impl<'s> ZlibByteIter<'s> {
  fn from_current_and_iter(current: &'s [u8], idat_iter: IdatIter<'s>) -> Self {
      Self {
          current,
          idat_iter,
          #[cfg(not(feature = "png_skip_adler_checks"))]
          adler: 1
     }
  }
}

Or you can also have 2 methods fn from_current_and_iter(current: &'s [u8], idat_iter: IdatIter<'s>) -> Self on with the feature flag enabled and another one without. Because for now we don't support cfg attributes on block.
I will try to implement it in the next days :)

Closed by #4063.


Can't open folder from breadcrumbs in secondary view

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:

code-insiders --version
1.93.0-insider
39d98602020ddefe53ed217a8c50b9040673a737
arm64

OS Version:

14.5 (23F79)

Steps to Reproduce:

Click on a foldername in the breadcrumb, or double click it, or right click it
No way for me to open the folder in the secondary sidebar in my folder/file explorer

That is great! I wonder if we can combine the upvotes already on:

https://github.com/microsoft/vscode/issues/67711

Yes, this is the same requirement. Please combine the upvotes. 🙏

Say, are you supposed to upvote the original issue or the first bot comment where it asks for votes?

Say, are you supposed to upvote the original issue or the first bot comment where it asks for votes?

lol, I'm hoping it is the original issue! 🤞


State importance of favoring algorithms

Lesson 5, question 1:

Which of the following would you apply Deep Learning to?
[...]
2. Calculating the median and interquartile range of a dataset.

Answer:

no, even though it is a regression problem, you'd need tons of training data and still be off by quite a bit

The answer misses one of the most important points: there are existing, super efficient and 100 %-accurate algorithms for this. :)

Ok, I guess I have to reformulate this. What I mean was to try to learn arithmetic operations using Deep Learning.

I'd say the point still stands – there are already algorithms for arithmetic operations which don't require

the whole bother of training a neural network, and
an expensive neural network evaluation that
only returns approximate results.

I think there is a misunderstanding here ... that is the sole point, that learners discover that quite some tasks (like arithmetic operations) do not make sense to solve with a neural network. ;-)

Yes, but the answer only explains that the problem may be hard with a neural network. It doesn't mention that it's simply not the right tool for the job. :D
That's what I'm getting at; the question is great to get people thinking, but the answer smudges the more important lesson (the task being one that ML should not be applied to) by arguing that neural network training is hard.
At least, that's the impression I get when reading the answer. Could also be that you want the students to think about this and come to the conclusion on their own; in that case, disregard everything I said. :)

I take that point. Could you please send a PR to fix that? ;-)


Improved breaking for ExpressionBody in Parenthesized Lambda

I feel like we could clean up how this breaks
entity.HasKey(
    e =>
        new
        {
            e.BusinessEntityID,
            e.PersonID,
            e.ContactTypeID
        }
);
// could instead be something like
entity.HasKey(e => new
    {
        e.BusinessEntityID,
        e.PersonID,
        e.ContactTypeID
    }
);

Lambda in method formatting should probably be a separate issue than lambda formatting.
So, it should probably be something closer to:
entity.HasKey(
    e => new
    {
        e.BusinessEntityID,
        e.PersonID,
        e.ContactTypeID
    }
);

and work the same way as:
var e => new
    {
        e.BusinessEntityID,
        e.PersonID,
        e.ContactTypeID
    }
);

This will most likely require conditional groups somewhere. At least prettier uses them.
These are the related cases with desired formatting.
        entity.HasKey(e => new
        {
            e.BusinessEntityID,
            e.PersonID,
            e.ContactTypeID________________________________________________
        });

        entity.HasKey((e) =>
        {
            return new
            {
                One = e.BusinessEntityID,
                Two = e.PersonID,
                Three = e.ContactTypeID________________________________________________
            };
        });

        var variableDeclarator = conditionalAccessExpression?.invocationExpression(
            o => someLongValue___________________________________
        );

        var y = someList.Where(
            o =>
                someLongValue_______________________
                && theseShouldNotIndent_________________
                && theseShouldNotIndent_________________
                    > butThisOneShould_________________________________________
        );


It would be really nice to be able to set Heap sizes for Java in Cantaloupe

I think it would go here:
https://github.com/Islandora-Devops/isle-buildkit/blob/main/cantaloupe/rootfs/etc/s6-overlay/s6-rc.d/cantaloupe/run
Having CANTALOUPE_HEAP_MIN and CANTALOUPE_HEAP_MAX variables that passed into Xms and Xmx parameters in that command would do the trick.

Hello everyone,
Today I was able to:

create a new MR based on the changes suggested in this ticket - https://github.com/Islandora-Devops/isle-buildkit/pull/310/files

run make bake cantaloupe on isle-buildkit without failure resulting in a new Docker image.

test an isle-dc based project using this new image (local) by

using a different tag for cantaloupe -     image: ${REPOSITORY}/cantaloupe:local
adding the following to the cantaloupe environment section of the docker-compose.yml

      CANTALOUPE_HEAP_MIN: "3G"
      CANTALOUPE_HEAP_MAX: "5G"

increase and decrease the heap values dynamically. I increased to 4 GB min and 6 GB max.

Reviewed change in values by docker-compose exec cantaloupe bash -lc "printenv | grep HEAP"

Test 1
CANTALOUPE_HEAP_MAX=5G
CANTALOUPE_HEAPCACHE_PERSIST=false
CANTALOUPE_HEAPCACHE_PERSIST_FILESYSTEM_PATHNAME=/data/heap.cache
CANTALOUPE_HEAPCACHE_TARGET_SIZE=2G
CANTALOUPE_HEAP_MIN=3G

Test 2
CANTALOUPE_HEAP_MAX=6G
CANTALOUPE_HEAPCACHE_PERSIST=false
CANTALOUPE_HEAPCACHE_PERSIST_FILESYSTEM_PATHNAME=/data/heap.cache
CANTALOUPE_HEAPCACHE_TARGET_SIZE=2G
CANTALOUPE_HEAP_MIN=4G

@noahwsmith and @nigelgbanks Anything else I should do to test or consider?

Possibly add these values to the isle-dc sample.env once this MR is merged?

That sounds good. We'll test this out on a real project and report back...

Okay coming back to this for some changes, further testing.
When I ran make bake cantaloupe on my local, everything passed however when I use the built image: islandora/cantaloupe:307-set-heap-sizes-for-java-in-cantaloupe from Dockerhub, cantaloupe & s6 crash with
bd-base-i8-staging-cantaloupe-1  | s6-rc: info: service legacy-services: starting
bd-base-i8-staging-cantaloupe-1  | s6-rc: info: service legacy-services successfully started
bd-base-i8-staging-cantaloupe-1  | Invalid initial heap size: -Xms
bd-base-i8-staging-cantaloupe-1  | Error: Could not create the Java Virtual Machine.
bd-base-i8-staging-cantaloupe-1  | Error: A fatal exception has occurred. Program will exit.
bd-base-i8-staging-cantaloupe-1  | s6-rc: info: service cantaloupe finish: executing...

I also tried removing the curly braces, quotes etc.
-Xms$CANTALOUPE_HEAP_MIN} -Xmx$CANTALOUPE_HEAP_MAX
-Xms${CANTALOUPE_HEAP_MIN} -Xmx${CANTALOUPE_HEAP_MAX}
-Xms"${CANTALOUPE_HEAP_MIN}" -Xmx"${CANTALOUPE_HEAP_MAX}"
All don't work. :(
Feel like I'm missing something simple here.

So changing this to
#!/usr/bin/with-contenv sh
set -e

# When bind mounting we need to ensure that we
# actually can write to the folder.
chown cantaloupe:cantaloupe /data

#exec with-contenv s6-setuidgid cantaloupe java -Dcantaloupe.config=/opt/cantaloupe/cantaloupe.properties -Xms"${CANTALOUPE_HEAP_MIN}" -Xmx"${CANTALOUPE_HEAP_MAX}" -jar /opt/cantaloupe/cantaloupe.jar

echo "CANTALOUPE_HEAP_MIN: ${CANTALOUPE_HEAP_MIN}"
echo "CANTALOUPE_HEAP_MAX: ${CANTALOUPE_HEAP_MAX}"

exec with-contenv s6-setuidgid cantaloupe java -Dcantaloupe.config=/opt/cantaloupe/cantaloupe.properties -Xms${CANTALOUPE_HEAP_MIN} -Xmx${CANTALOUPE_HEAP_MAX} -jar /opt/cantaloupe/cantaloupe.jar

Works for about 10-30 seconds but then crashes. What am I missing here?

So Cantaloupe can start but then from somewhere is told to stop?

I would push these changes for others to test but am prevented from doing so.

Okay thanks to @dannylamb I'm unstuck here.
For starters my test project had a health check on cantaloupe that was crashing things.
I got around the linter by correctly using this instead
#!/command/with-contenv bash
# shellcheck shell=bash
set -e

Now I'm seeing running containers that don't crash with successful Cantaloupe starts.
docker-compose exec cantaloupe bash -lc "ps aux | grep java"
cantalo+    1502  4.3  1.0 7097412 352492 ?      Ssl  18:33   0:12 java -Dcantaloupe.config=/opt/cantaloupe/cantaloupe.properties -Xms3G -Xmx5G -jar /opt/cantaloupe/cantaloupe.jar
root        1569 14.2  0.0   2400  1664 pts/0    Ss+  18:38   0:00 bash -lc ps aux | grep java
root        1577  0.0  0.0   1596   640 pts/0    S+   18:38   0:00 grep java

I think we just need some folks to review and test when they can. Thanks!


Changing the default querying operator from OR to AND

It is easier to do this and https://github.com/wellcometrust/platform/issues/4017 simultaneously than to do each separately

Because of the above this is kind of blocked by https://github.com/wellcometrust/platform/issues/4019

Required changes:

[x] API changes
[ ] wellcomecollection.org Lambda changes

Looks like the switch to AND is increasing the skew towards clicks at the top end of results, without reducing the overall number of clicks further down, which is exactly what we wanted to see. This tracks across both 'discerning' and 'non-discerning' users. Happy to make the switch to AND as default and begin another test.

Nice.


echarts line chart smooth instead of with breaks when no data is present

Hello,
We are using the series data line chart. Is there an option where the line can be smoothed rather than showing a break ? See screen grabs below as an example in jqplot there is no breakpoint visible when data is missing
Using Echarts :-

Using Jqplot http://www.jqplot.com/

If there is no option is it possible to guide me on a possible approach ?

Why closed?

@guimingfu - No idea it wasn't implemented, I'll message @pissang

Yeah, I find a solution.
series: [
       { },
       { },
       {
         ...
         data:[-2, 2.2, 3.3, '', 6.3, 10.2, 20.3, 23.4, 23.0, 16.5, 12.0, -6.2],
          **connectNulls:true**
       }
   ],

Nice, Is this in git master or do you have a separate fork ?


Chrome version 62+

The following error frequently appears in the terminal across all platforms:
error: unhandled page event *page.EventLifecycleEvent
The settings tab also opens for every single key stroke on Mac. Very, very annoying.
I've noticed this on all versions of Chrome 62 and above.

Is this resolved ? @kenshaw

This is what I had to do with my local copy of this repo:
   kb/kb.go //Edit this file

   keyDown := input.DispatchKeyEventParams {
	Key:                   v.Key,
	Code:                  v.Code,
 	NativeVirtualKeyCode:  v.Native, //Comment out this line
	WindowsVirtualKeyCode: v.Windows,
}

I'm on a Mac and this fixed the issue with the error message as well as the settings tab repeatedly opening. Hope this helps.
Cheers


Create poligran.txt

@kmolano-dot I am sorry, the domain poligran.edu.co is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


update/add reddit socials

Thank you @JustinMKY for adding Reddit to the list of community resources! Are you the person who started the subReddit and will be moderating the space?
I'll leave a few suggestions before we can merge your PR:

Please revert changes made to the docusaurus.config.js as the links there are only official Subspace-moderated community resources
Please add a link to Reddit to the versioned version of docs/community/index.md, you can find it in /versioned_docs/version-latest/community/index.md

Looking forward to the updates, thanks!

Correct, I am moderating the community subreddit


Fix Ackermann plugin zero linVel turningRadius bug

🦟 Bug fix
Fixes #1848
Summary
Fix for handling Ackermann wheel steering angle bug where wheel always points same direction when linVel is zero and abs(angVel) > 0.001. This results in an always positive evaluated turningRadius. This solution fixes it by handling linVel zero properly. Allowing it to get past the first conditional that it is otherwise stuck on.
Now the wheels can rotate both directions when the vehicle has no linVel:
https://user-images.githubusercontent.com/10233412/209774462-ac17dd19-f537-4075-a1e4-c3b313a310fc.mp4
Checklist

[x] Signed all commits for DCO
[x] Added tests
[x] Updated documentation (as needed)
[x] Updated migration guide (as needed)
[x] Consider updating Python bindings (if the library has them)
[x] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

We need to wait for CI before this can be merged and a new release made. If I can't get to it tonight, it will be finished tomorrow

Thanks @jennuine! Really appreciate it!

@ahcorde @jennuine @mjcarroll thank you all for the expediency on getting this bug fixed, does anyone know when the next forward port to gz-sim7? looks like the last was: https://github.com/gazebosim/gz-sim/pull/1832. Also I think that there has not been a new point release for garden in a while (https://github.com/gazebosim/gz-sim/commit/39520a12b11c88d11160b0b58c5d59bb6985dde3), looks like the motor plugin update wasn't included as well in last point release: https://github.com/gazebosim/gz-sim/pull/1794.

I'm going to try to get a forward port and point release out today for you.


Update to v1.12

 v<IP_ADDRESS>  2023-04-18
    - Update steward name from Mitchell Gordon to Matthew Tiscareno
    - Improved definitions of epoch_reprojection_basis_utc, corotating_ring_longitude, minimum_corotating_ring_longitude,
      and maximum_corotating_ring_longitude.
    - Fixed typo in corotating_flag enumerated value definition.
    - Regularized spelling of "corotation"
    - Add inertial_ring_longitude, minimum_inertial_ring_longitude, and maximum_inertial_ring_longitude.  These replace
      ring_longitude, minimum_ring_longitude, and maximum_ring_longitude, which should be deprecated.
    - Also, classes that are copied here from the Geometry and Display dictionaries should be deprecated, as of now.
      These include Body_Ident_Base, Reference_Frame_Ident, Central_Body_Ident, and Display_Direction.
    - Actual deprecation not yet implemented.

@jordanpadams:  If it is too late for this pull request to be included in the current build, then I understand.

@jordanpadams:  We want to deprecate several classes and attributes, and I do not know the best practice for deprecating.  See PR description for details.  The need for advice on this point is the reason for my delay that is causing me to possibly miss the deadline.  If you are able to offer guidance, that would be great.

The current version adds the new things we want to add, without deprecating the old things.  There are few enough data providers using this LDD that we can probably live with this for six months, if needed.

Fixes #241, #243, #244, and #245.
Does not fix #242, because deprecation not implemented.

@matthewtiscareno we are working on updating the script to tag the releases in by end of day. if this looks good, you can go ahead with a merge and we will make sure it is included

@jordanpadams: We want to deprecate several classes and attributes, and I do not know the best practice for deprecating. See PR description for details. The need for advice on this point is the reason for my delay that is causing me to possibly miss the deadline. If you are able to offer guidance, that would be great.

@matthewtiscareno per this, at this time, I do not believe we have a way to "deprecate" classes or attributes other than just removing them and major versioning your LDD (since it is not backwards compatible). I will ping @jshughes to see if there is a way to do this.

@jordanpadams: We want to deprecate several classes and attributes, and I do not know the best practice for deprecating. See PR description for details. The need for advice on this point is the reason for my delay that is causing me to possibly miss the deadline. If you are able to offer guidance, that would be great.

@matthewtiscareno per this, at this time, I do not believe we have a way to "deprecate" classes or attributes other than just removing them and major versioning your LDD (since it is not backwards compatible). I will ping @jshughes to see if there is a way to do this.

In that case, I think it's best to go with the current version for this build.  We'll consider removing items and incrementing to v2.0 in the next build.

@jordanpadams @matthewtiscareno Currently there is no capability to deprecate classes or attributes in LDDs as there is for the Common dictionary. The assumption was made early on that the definitions would simply be removed. A kludge would be to hard code the deprecated item identifiers into LDDTool. I only mention this in case a temp solution is necessary. Adding deprecation to LDDs is probably a DDWG discussion topic.

@jordanpadams @matthewtiscareno Currently there is no capability to deprecate classes or attributes in LDDs as there is for the Common dictionary. The assumption was made early on that the definitions would simply be removed. A kludge would be to hard code the deprecated item identifiers into LDDTool. I only mention this in case a temp solution is necessary. Adding deprecation to LDDs is probably a DDWG discussion topic.

Thank you for the helpful perspective, @jshughes.  It seems everyone agrees that deprecated material should simply be removed and a major version number incremented.  We'll consider this for next build.

Fixes #241, #243, #244, and #245.
Does not fix #242, because deprecation not implemented.

I was over-enthusiastic in saying this.  Some of these are still to do.


Replace role management via environment variable with the support interface UI

Context
We currently manage roles via checks on role codes stored in environment variables. This means developer support is necessary for role management.

Changes proposed in this pull request
Checks user access to the service via roles stored in the database.

Guidance to review
Role codes have been populated on all environments, this is good to merge once approved.

Link to Trello card
https://trello.com/c/CdLVoxt3/1842-replace-role-management-via-environment-variable-with-the-support-interface-ui

Checklist

[x] Attach to Trello card
[x] Rebased main
[x] Cleaned commit history
[ ] Tested by running locally

 Replace role management via environment variable with the support interface UI


how to Detect  leader changed？

How to check whether the leader has changed? How to register an observer and perform certain operations when the leader sends a change

config.NodeHostConfig.RaftEventListener
<EMAIL_ADDRESS>

this method is very good。How to check whether the raft node Breakdowns? How to register an observer and perform certain operations when the node Breakdowns

this method is very good。How to check whether the raft node Breakdowns? How to register an observer and perform certain operations when the node Breakdowns

your new question is being addressed in #301.

I've got a use case where I have a scheduler.  It only needs to be run on one node.  However I'm using dragonboat to provide HA.
What would be the best mechanism to only ensure the scheduler runs in 1 node only?
Thanks


Add @mixin support

With @method support and modern php having traits this is probably unnecessary.

Well, there still are some libraries relying on @mixin support for autocompletion. Eloquent, for example. I think having @mixin support would be useful.

I think the same than @DuMOHsmol. It would be great because when I'm using Laravel, I have to manually add functions like find, firdOrFail, firstOrNew, firstOrCreate, updateOrCreate, etc, because even if I have @mixin added, the extension doens't recognize them. However, this is a great extension and thank you very much.
Vehicle.php
<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\SoftDeletes;

/**
 * App\Models\Vehicle
 *
 * @property int $id
 * @property \Illuminate\Support\Carbon|null $created_at
 * @property \Illuminate\Support\Carbon|null $updated_at
 * @property \Illuminate\Support\Carbon|null $deleted_at
 * @property string $number_plate
 * @method static bool|null forceDelete()
 * @method static \Illuminate\Database\Query\Builder|\App\Models\Vehicle onlyTrashed()
 * @method static bool|null restore()
 * @method static \Illuminate\Database\Eloquent\Builder|\App\Models\Vehicle whereCreatedAt($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\App\Models\Vehicle whereDeletedAt($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\App\Models\Vehicle whereId($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\App\Models\Vehicle whereNumberPlate($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\App\Models\Vehicle whereUpdatedAt($value)
 * @method static \Illuminate\Database\Query\Builder|\App\Models\Vehicle withTrashed()
 * @method static \Illuminate\Database\Query\Builder|\App\Models\Vehicle withoutTrashed()
 * @mixin \Eloquent
 * @method static \App\Models\Vehicle updateOrCreate(array $attributes, array $values)
 */
class Vehicle extends Model
{
    use SoftDeletes;

    protected $table = 'vehicles';

    public $timestamps = true;

    protected $dates = ['deleted_at'];

    protected $fillable = array('number_plate');
}


generate a confirmation_token over an empty string

Fixes #5071

@mracos Any thoughts here? This should probably be considered a security issue, as it allows anyone to access the system with an empty token.

Sorry @ajsharp, I've been really busy with work lately, so I didn't have much time to take a deeper look at this but will try to give you some feedback in the next days.
Thanks!

Would it be possible to add a validation to prevent the model from being saved when confirmation_token is an empty string?

@ajsharp Thanks for your contribution!
I was digging into this, and a better approach for us is to ensure it's not possible to confirm a user with a blank confirmation_token parameter - i.e. to return a validation error inside the ConfirmationsController#show action.
That should be enough to ensure no "invalid" records will be confirmed by mistake.
As for the confirmation_token being set to blank, that doesn't seem to be possible with the current code we have. I'm assuming something else could've happened in the system to let the records in that state. Unless we find a real case where Devise is setting the token to a blank string, I think it's not worth it to include more code to handle this.
@amangano-privy I thought about adding the validation, but we can't always require this field, so we would need a context validation. That would only protect the model against the known use cases. Another thing to take into account is that a bunch of places inside Devise uses validate: false.
So I think the validation wouldn't add that much value. The current code is already generating the token in a before_create callback, so I'm guessing it would require some external action to leave the field with a blank string - instead of nil.
WDYT you think? Thoughts?

Closed in favor of https://github.com/plataformatec/devise/pull/5132


Unclear behavior when having two changes, one inside a comment and one outside

Testing #6160
I did two change, one inside a comment and one outside and then ran the action from the SCM viewlet. Here is what happend:

got the dialog.
the one inside the comment got converted but the diff didn't revert. I would have expected to see that happening since the suggestion got created.
the other diff stayed, which is IMO correct.

I only show the option to revert the change if all the conversions succeeded. I'll add an option to revert even if not everything succeeded.

Actually, I can only revert entire files, not just select changes. I think the current behavior is less confusing than only reverting the files for which ever suggestion conversion succeeded.


onSuccess and onError are not called

When I call MusicControls.create the controls are shown in the lock screen, however neither onSuccess nor onError are called. I have tried the example code from the README as well as from issue #45 but no callback is called.
Using the latest version from npm. I'm running on iOS physical device.
Is this a bug or am I missing something?

Same here :)) any alternative @kirschem @ljudbane @Richie765 ?


Server HMR error messages only flashing

After altering our existing Vite project to Vituum the HMR error message overlay only flashes briefly in the browser before disappearing.
Restarting vite will render the error message once, after a browser refresh or a refresh because of a file change the error message will only flash briefly again.
Any ideas what could cause this behaviour?
Cheers

could you send a repro? or vite.config.js atleast?

I hope the vite.config.js helps.
import { defineConfig } from 'vituum'
import twig from '@vituum/twig'

// POSTCSS
import autoprefixer from 'autoprefixer'
import postcssImport from 'postcss-import'
import postcssNested from 'postcss-nested'
import postcssCustomMedia from 'postcss-custom-media'
import postcssImportExtGlob from 'postcss-import-ext-glob'

export default defineConfig({
  integrations: [twig()],
  templates: {
    format: 'twig',
  },
  output: 'dist',
  vite: {
    css: {
      postcss: {
        plugins: [
          autoprefixer,
          postcssImportExtGlob,
          postcssImport,
          postcssNested,
          postcssCustomMedia,
        ],
      },
    },
  },
})

Thanks, I've been able to reproduce this in Chrome, works in Firefox though. Should be fixed in plugin now -> https://github.com/vituum/vite-plugin-twig/commit/3c33dd5a248f3764b3c37a6386210e9ab626e46a
Update your deps in project, eg. with npm update and should be fixed now.


Don't use colors to exclusively delineate changes

Money uses red-coloured text to signify expenses and green-coloured text to signify income. This is a pretty significant accessibility issue as it makes it difficult to see the difference between them with certain types of color blindness:

(simulated image)
Amounts should have + or - appended to them for clarity.

Fixed with https://github.com/nlogozzo/NickvisionMoney/commit/79f7d5a2187aa7960fb333b988959c11355d9f1d