[AKS]az aks create: Add optional parameter --revision to set revision for the Azure Service Mesh addon while creating AKS cluster.

Related command
az aks create --enable-azure-service-mesh
Description
Add optional parameter --revision to set revision for the Azure Service Mesh addon while creating AKS cluster.
Implicitly enable istio when ingress gateway is enabled for Azure Service Mesh.
Testing Guide
az aks create -g MyResourceGroup -n MyManagedCluster --enable-azure-service-mesh --revision asm-1-18
az aks mesh enable-ingress-gateway -g MyResourceGroup -n MyManagedCluster
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

AKS


Add missing test case and fix typo in tests

This PR adds a missing assertion in the TestGetOrgUsersByOrgID function. It also incidentally fixes a small typo.

CI failure is related.


tests to ensure cli parsing code is correct

so we can catch bug like https://github.com/AcalaNetwork/chopsticks/pull/603

I saw that we already have an options.test.ts, do we need more tests?

it doesn't catch the bug I introduced here https://github.com/AcalaNetwork/chopsticks/pull/636 so we need more


Caused by Rack::QueryParser::InvalidParameterError: Invalid encoding for parameter: �

Visit Airbrake error to view the full backtrace.

Comment from Airbrake: Resolved error reoccurred.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1108

Questions ?
Please refer to the Backport tool documentation


修改文字错误

1.message前20字节截断
2.massage->message
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[] Bugfix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] Documentation Update (if none of the other choices apply)
[] Code refactor (Modify the code structure, format the code, etc...)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
[] Compiling and unit tests pass locally with my changes
[] I have added tests that prove my fix is effective or that my feature works
[] If this change need a document change, I have updated the document
[] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

Thanks for your PR. But I am not sure this is correct. I need to check the code


docs(release): generate 3.8.1 changelog

Summary
Updating changelog for 3.8.1
Checklist

[ ] The Pull Request has tests
[X] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Kevin Williams seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Kevin Williams seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


HBASE-22609 [Docs] More detail documentation about...

HBASE-22609 [Docs] More detail documentation about 'hbase.server.thread.wakefrequency'

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
72
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

+1
mvninstall
336
master passed

0
refguide
792
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1
mvninstall
319
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

0
refguide
514
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1
asflicense
15
The patch does not generate ASF License warnings.

2125

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense refguide

uname
Linux f6b55298b607 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / 373c2dc13f

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/1/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/1/artifact/out/patch-site/book.html

Max. process+thread count
86 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
40
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

+1
mvninstall
295
master passed

0
refguide
446
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1
mvninstall
287
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

0
refguide
437
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1
asflicense
14
The patch does not generate ASF License warnings.

1594

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense refguide

uname
Linux a888362130f0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / 586e177ded

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/2/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/2/artifact/out/patch-site/book.html

Max. process+thread count
76 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
83
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

+1
mvninstall
344
master passed

0
refguide
517
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1
mvninstall
326
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

0
refguide
528
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1
asflicense
17
The patch does not generate ASF License warnings.

1897

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense refguide

uname
Linux 54b13ba76a02 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / 9a4a8ef274

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/3/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/3/artifact/out/patch-site/book.html

Max. process+thread count
86 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

+1
mvninstall
312
master passed

0
refguide
486
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1
mvninstall
318
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

0
refguide
476
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1
asflicense
15
The patch does not generate ASF License warnings.

1713

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense refguide

uname
Linux 4c3b5e36246c 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / caa05356a1

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/4/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/4/artifact/out/patch-site/book.html

Max. process+thread count
96 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
62
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

+1
mvninstall
307
master passed

0
refguide
454
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1
mvninstall
287
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

0
refguide
441
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1
asflicense
15
The patch does not generate ASF License warnings.

1644

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense refguide

uname
Linux<PHONE_NUMBER>2d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / 24b970ec51

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/5/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/5/artifact/out/patch-site/book.html

Max. process+thread count
96 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

-1
mvninstall
81
root in master failed.

-1
refguide
296
branch has 21 errors when building the reference guide.

_ Patch Compile Tests _

-1
mvninstall
82
root in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

-1
refguide
294
patch has 21 errors when building the reference guide.

_ Other Tests _

+1
asflicense
14
The patch does not generate ASF License warnings.

856

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense refguide

uname
Linux 88cb66fd996c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / 4829c18251

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/6/artifact/out/branch-mvninstall-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/6/artifact/out/branch-refguide.log

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/6/artifact/out/patch-mvninstall-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/6/artifact/out/patch-refguide.log

Max. process+thread count
76 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/6/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

+1
mvninstall
301
master passed

0
refguide
323
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1
mvninstall
306
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

0
refguide
326
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1
asflicense
15
The patch does not generate ASF License warnings.

1370

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense refguide

uname
Linux 937764e82cef 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / 35acf3cb78

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/7/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/7/artifact/out/patch-site/book.html

Max. process+thread count
96 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/7/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
78
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

+1
mvninstall
340
master passed

0
refguide
384
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1
mvninstall
328
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

0
refguide
368
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1
asflicense
15
The patch does not generate ASF License warnings.

1571

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense refguide

uname
Linux cc7b2da79e58 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / 8cfc46d8d0

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/8/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/8/artifact/out/patch-site/book.html

Max. process+thread count
86 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/8/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
45
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

-1
mvninstall
86
root in master failed.

-1
refguide
298
branch has 21 errors when building the reference guide.

_ Patch Compile Tests _

-1
mvninstall
82
root in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

-1
refguide
310
patch has 21 errors when building the reference guide.

_ Other Tests _

+1
asflicense
12
The patch does not generate ASF License warnings.

891

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense refguide

uname
Linux f5f00196d92b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / 237229cade

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/9/artifact/out/branch-mvninstall-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/9/artifact/out/branch-refguide.log

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/9/artifact/out/patch-mvninstall-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/9/artifact/out/patch-refguide.log

Max. process+thread count
55 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/9/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
123
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

+1
mvninstall
430
master passed

0
refguide
405
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1
mvninstall
423
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

0
refguide
396
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1
asflicense
19
The patch does not generate ASF License warnings.

1870

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense refguide

uname
Linux d6495e0e6608 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / 7e6684b1f4

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/10/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/10/artifact/out/patch-site/book.html

Max. process+thread count
55 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/10/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
66
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

+1
mvninstall
422
master passed

0
refguide
404
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1
mvninstall
399
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

0
refguide
410
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1
asflicense
20
The patch does not generate ASF License warnings.

1786

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense refguide

uname
Linux 90db2942d8c7 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / a6f065396a

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/11/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/11/artifact/out/patch-site/book.html

Max. process+thread count
96 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/11/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

+1
mvninstall
317
master passed

0
refguide
352
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1
mvninstall
303
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

0
refguide
329
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1
asflicense
17
The patch does not generate ASF License warnings.

1419

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense refguide

uname
Linux 0b827a729391 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / abb60faa6c

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/12/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/12/artifact/out/patch-site/book.html

Max. process+thread count
96 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/12/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
69
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

+1
mvninstall
275
master passed

0
refguide
299
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1
mvninstall
281
the patch passed

+1
whitespace
1
The patch has no whitespace issues.

0
refguide
295
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1
asflicense
15
The patch does not generate ASF License warnings.

1290

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense refguide

uname
Linux e77be2d2c7e1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / d0e5ea1b87

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/13/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/13/artifact/out/patch-site/book.html

Max. process+thread count
78 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/13/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

I thought this section was generated from the default hbase-default.xml file?

Hmm, I'll check again. If that so, i should just update hbase-default.xml

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
92
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

_ master Compile Tests _

+1
mvninstall
333
master passed

0
refguide
380
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1
mvninstall
342
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

0
refguide
376
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1
asflicense
15
The patch does not generate ASF License warnings.

1599

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/14/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense refguide

uname
Linux 205054bd5291 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / ff96485396

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/14/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/14/artifact/out/patch-site/book.html

Max. process+thread count
69 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/14/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Confirmed sir @saintstack , as you said.
The new commit modifies the hbase-default.xml instead of doc file.
Thanks for the review.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
60
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
291
master passed

0
refguide
326
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1
javadoc
19
master passed

_ Patch Compile Tests _

+1
mvninstall
287
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
1
The patch has no ill-formed XML file.

0
refguide
308
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1
javadoc
19
the patch passed

_ Other Tests _

+1
unit
167
hbase-common in the patch passed.

+1
asflicense
11
The patch does not generate ASF License warnings.

1560

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/15/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/434

Optional Tests
dupname asflicense javac javadoc unit refguide xml

uname
Linux 559707adeed7 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-434/out/precommit/personality/provided.sh

git revision
master / ff96485396

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/15/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/15/artifact/out/patch-site/book.html

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/15/testReport/

Max. process+thread count
290 (vs. ulimit of 10000)

modules
C: hbase-common U: hbase-common

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-434/15/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Question on bulk queries

Hello!
(not sure if this is the right place to ask questions - feel free to close if not)
Going over some online resources on Scylla performance, there's a recurring theme, which is:

it may be beneficial to do bulk queries (using SELECT ... IN on reads and BATCH on writes) instead of doing more parallel queries.
when doing bulk queries, it is better to avoid requiring coordination across multiple nodes (= avoid bulk queries that require data from different nodes)

Example resources that touch on this:

On SELECT ... IN queries: https://www.scylladb.com/tech-talk/planning-queries-maximum-performance-scylla-summit-2017/  (a bit old, but I think it is still relevant?)
On BATCH insert queries: https://www.scylladb.com/2019/03/27/best-practices-for-scylla-applications/

Now, the application I'm working on needs to do large bulk reads and writes, so I want to make sure I'm not adding artificial bottlenecks.
With that in mind, I'm a bit puzzled about how to implement the above recommendations with gocql. Ideally the driver would let me split my bulk queries by node, but there does not seem to be a way to do so (?)
It seems the closest I can do using gocql is to have my application split bulk queries by partition key. But if I'm trying to read, let's say, 200K rows with all different partition keys, this basically means bulk queries will all be split into 200K single-row queries - which basically means I can't use bulk queries in practice - which may be detrimental to my application performance.
Given that the driver has access to the information that would be required to split queries intelligently, I was wondering why there is no such facility? I'm not sure whether I am misunderstanding how to best use the driver, or if the driver is currently lacking the feature. It would surely require the driver to expose a rather odd-looking API (as the current gocql API seems pretty abstracted away from such concerns) - but that seems required in order to make bulk queries as efficient as they can be.
I'm completely new to the Scylla ecosystem so apologies if my question seems odd. Advice welcome, and sorry if I missed something obvious :)
Thanks!

Yep, I'm not aware of any public API to determine which node (resp. in case of Scylla you would group by shard) the partition key maps to.
We just split our queries by partition key, although in our case we don't need to read 200K specific partition keys at once and we read more than one row from partition.
One advantage of splitting by partition key is that each partition can return error separately (e.g. in case some partition takes long to process, but that might be irrelevant if you only have one row per partition).
It would definitely be interesting to see a benchmark comparing the options.

I too would like to have the ability to batch my data according to which node/shard my data is going. Any new information regarding this?

The same problem. I extend gocql driver with this function, which helps me to split keys into shard aware batches.
May be it would be helpful
type ShardAwareRoutingInfo struct {
	// RoutingKey - is bytes of primary key
	RoutingKey []byte
	// Host - is node to connect
	Host *HostInfo
	// Shard - is shard ID of node to connect
	Shard int
}

// GetShardAwareRoutingInfo - определения ноды/шарда по PK ключу.
// Драйвер может не всегда получить информацию о маршрутизации и это нормально.
// В этом случае функция вернет ошибку и в вашем приложении требуется обработать ее штатно
//
// Пример использования для SELECT WHERE IN:
/*
	const shardsAbout = 100 // число node * (cpu-1)

	// Разбиваем []T на батчи (pk ключи)
	var (
		queryBatches = make(map[string][]T, shardsAbout) // сгруппированные ключи по батчам
		routingKeys  = make(map[string][]byte, shardsAbout) // routing key для маршрутизации запроса
	)

	for _, pk := range pks {
		var (
			shardID string
			routingKey []byte
		)
		// Получаем информацию о маршрутизации наших ключе.
		// В данном примере PRIMARY KEY состоит из одной колонки pk_column_name.
		info, err := session.GetShardAwareRoutingInfo(keyspaceName, tableName, []string{"pk_column_name"}, pk)
		if err != nil || info.Host == nil {
			// Мы можем не получить информацию о маршрутизации по разным причинам.
			// Важно при тестировании понять причину (например, вы не используете tokenAwarePolicy)
			log.Printf("can't get shard id of pk '%d': %v", pk, err)
		} else {
			// формурум уникальный ключ шарда: host+/+vShard (<IP_ADDRESS>/1)
			shardID = info.Host.Hostname() + "/" + strconv.Itoa(info.Shard)
			routingKey = info.RoutingKe
		}

		// добавляем наш ключ в соответсвующий батч
		batch := queryBatches[shardID]
		if batch == nil {
			batch = make([]int64, 0, len(pks)/shardsAbout)
		}
		batch = append(batch, pk)

		queryBatches[shardID] = batch
		routingKeys[shardID] = rk
	}

	const query = "SELECT * FROM table_name WHERE pk IN (?)"

	var wg sync.WaitGroup
	// пробегаемся по всем батчам для параллельного выполнения запросов
	for shard, batch := range batches {
		// большие батчи разделяем на чанки поменьше, так как большие батчи плохо влияют на RT scylla)
		for _, chunk := range slices.ChunkSlice(batch, 10) { // разделяем
			wg.Add(1)
			go func(shard string, chunk []int64) {
				defer wg.Done()

				rk := keys[shard] // достаем наш ключ маршрутизаци

				scanner := r.session.Query(query, chunk).RoutingKey(rk).Iter().Scanner() // используем RoutingKey

				for scanner.Next() {
					// ...
				}

				if err := scanner.Err(); err != nil {
					// ...
				}
			}(shard, chunk)
		}
	}
	// ждем отработки всех запросов
	wg.Wait()
*/
func (s *Session) GetShardAwareRoutingInfo(table string, primaryKeyColumnNames []string, args ...interface{}) (ShardAwareRoutingInfo, error) {
	keyspace := s.cfg.Keyspace

	// fail fast
	if len(keyspace) == 0 || len(table) == 0 {
		return ShardAwareRoutingInfo{}, errors.New("missing keyspace or table")
	}

	if len(primaryKeyColumnNames) == 0 {
		// missing a routing key column
		// no routing key
		return ShardAwareRoutingInfo{}, errors.New("missing a routing key column")
	}

	// check policy is TokenAwareHostPolicy
	tokenAwarePolicy, ok := s.policy.(*tokenAwareHostPolicy)
	if !ok {
		return ShardAwareRoutingInfo{}, fmt.Errorf("unsupported host policy type %T, must be tokenAwareHostPolicy", s.policy)
	}

	// get keyspace metadata
	md, err := s.KeyspaceMetadata(keyspace)
	if err != nil {
		return ShardAwareRoutingInfo{}, err
	}

	// get routing key from colums

	tableMd, ok := md.Tables[table]
	if !ok {
		return ShardAwareRoutingInfo{}, fmt.Errorf("table %v metadata not found", table)
	}

	var (
		pk      = tableMd.PartitionKey
		indexes = make([]int, len(pk))
		types   = make([]TypeInfo, len(pk))
	)
	for keyIndex, keyColumn := range pk {
		// set an indicator for checking if the mapping is missing
		indexes[keyIndex] = -1

		// find the column in the query info
		for argIndex, boundColumnName := range primaryKeyColumnNames {
			if keyColumn.Name == boundColumnName {
				// there may be many such bound columns, pick the first
				indexes[keyIndex] = argIndex
				types[keyIndex] = getCassandraTypeWithVersion(keyColumn.Type, s.logger, byte(s.connCfg.ProtoVersion))
				break
			}
		}

		if indexes[keyIndex] == -1 {
			// missing a routing key column mapping
			// no routing key
			return ShardAwareRoutingInfo{}, errors.New("missing a routing key column")
		}
	}

	// create routing key
	routingKey, err := createRoutingKey(&routingKeyInfo{
		indexes: indexes,
		types:   types,
	}, args)
	if err != nil {
		return ShardAwareRoutingInfo{}, err
	}

	// get token ring metadata
	cm := tokenAwarePolicy.getMetadataReadOnly()
	if cm == nil || cm.tokenRing == nil {
		return ShardAwareRoutingInfo{}, errors.New("can't get token ring metadata")
	}

	// get host by partition key
	host, token, _ := cm.tokenRing.GetHostForPartitionKey(routingKey)
	mmt, ok := token.(int64Token)
	if !ok { // check if that's murmur3 token
		return ShardAwareRoutingInfo{}, fmt.Errorf("unsupported token type %T, must be int64Token", token)
	}

	// get host connection pool
	pool, ok := s.pool.getPool(host)
	if !ok {
		return ShardAwareRoutingInfo{}, fmt.Errorf("can't get connection pool of host %s", host.Hostname())
	}

	// check that connection pool is scylla pool
	cp, ok := pool.connPicker.(*scyllaConnPicker)
	if !ok {
		return ShardAwareRoutingInfo{}, fmt.Errorf("unsupported connection picker type %T, must be scyllaConnPicker", pool.connPicker)
	}

	return ShardAwareRoutingInfo{
		RoutingKey: routingKey,      // routing key
		Host:       host,            // host by key
		Shard:      cp.shardOf(mmt), // calculate shard
	}, nil
}

Did you benchmark your approach? For what it's worth, I did test my application and found that in my case it didn't help. ScyllaDB is so good at handling concurrent queries that I found no compelling reason to extend the driver code and have to maintain that. I suspect that ScyllaDB is less efficient at load balancing queries that can vary in size than it is at handling many many concurrent queries. That was 3 years ago though.

It really depends on kind of load. ScyllaDB is really good at handling concurrent queries but when we have 1,5M/rps with 100-500 different keys (from different partitions) per one query on one insert or read, concurrent queries with single keys is not efficient.
We did several experiments and  found that ScyllaDB can insert big BATCHes efficiently if all keys in batch are corresponded to one host (so strategy is Host Aware). And SELECT IN queries is efficiently when it has less or equal 10 keys corresponded to one shard (so strategy is Shard Aware). That's why I wrote this extension API and uses in our application.
You should also understand that ScyllaDB is really good at parallelism, so it's important to have a threaded approach to handling queries in your application in order to ensure maximum utilization of ScyllaDB.

@moguchev - how do you handle individual query failures?

In insert queries we have a background retry queue, so we are hope that some failed queries will retried with success (of course we monitore such queries)
In read queries in real time we can nothing to do with some individual failed queries, so we degrade functionality and notify clients, that they can re-request some values. This is trade off. In some applications it cannot be done. We are lucky so we can afford this strategy.

i would suggest to close this issue in favor of https://github.com/scylladb/gocql/issues/200


Can't Create New WinUI Project

Describe the bug
In Visual Studio 17.1.0, WinUI does not appear in the drop down menu of new project templates. I suspect this is because some tool, workload, component, or feature needs to be installed that is not documented here.
Steps to reproduce the bug

Completely uninstall all versions of Visual Studio and associated tools, components, etc.
Install Visual Studio 17.1.0.
Install all of the workloads documented here:

On the Workloads tab of the installation dialog, select:

Universal Windows Platform development

Then in the Installation details pane of the installation dialog for that workload, make sure C++ (v143) Universal Windows Platform tools is selected.

.NET Desktop Development for C# app development

Then in the Installation details pane of the installation dialog, select Windows App SDK C# Templates (at the bottom of the list).

Desktop development with C++ for C++ app development

Then in the Installation details pane of the installation dialog, select Windows App SDK C++ Templates (at the bottom of the list).

On the Individual components tab of the installation dialog, in the SDKs, libraries, and frameworks section, make sure Windows 10 SDK (10.0.19041.0) is selected.

Follow the steps documented here:

In Visual Studio, select File > New > Project.

In the New Project dialog's drop-down filters, select C#/C++, Windows, and WinUI, respectively.

Expected behavior
I expected WinUI to appear in the drop down menu of project types and Blank App, Packaged (WinUI 3 in Desktop) to appear in the list of project templates, but both are absent.
Screenshots
No response
NuGet package version
No response
Windows app type

[ ] UWP
[ ] Win32

Device form factor
No response
Windows version
No response
Additional context
I installed Microsoft Visual C++ Redistributable packages for Visual Studio 2015, 2017, 2019, and 2022 for x64 from here as suggested by Microsoft customer support and rebooted. There was no change in symptoms.

Did you install the VSIX ?
Current releases

They are neither required nor able to be installed on Visual Studio 17.1.0, but I did attempt to install the Windows App SDK (1.0 Stable) C# Visual Studio 2022 extension to no avail. The error message given stated it was already installed.

When I do a trace, the WinUI templates that I installed are read from my VS 2020 installation directory + \COMMON7\IDE\EXTENSIONS...\ProjectTemplates\VC\1033
=>
WinUI.Desktop.CppWinRT.PackagedApp
WinUI.Desktop.CppWinRT.SingleProjectPackagedApp
WinUI.Neutral.CppWinRT.RuntimeComponent
WinUI.Desktop.Cs.ClassLibrary
WinUI.Desktop.Cs.PackagedApp
WinUI.Desktop.Cs.SingleProjectPackagedApp

Are you also on Visual Studio 17.1.0? The documentation explicitly states that the extension only needs to be installed on earlier versions, which leads me to suspect that this issue is related to the release of 17.1.0.

If you followed the instructions in Required workloads and components above, then the templates are already installed.

I also wonder whether you had already installed the extension prior to upgrading and, if so, at which version of Visual Studio, and what version of the extension?

I also wonder whether you had already installed the extension prior to upgrading and, if so, at which version of Visual Studio, and what version of the extension?

Yes, you're right. I have 17.1.0, but I had installed the 2 VSIX before upgrading (they have been updated with 17.1.0, which I can see in "Manage Extensions", <IP_ADDRESS>203563 for C++, <IP_ADDRESS>203525 for C#)

When I open the C# VS 2022 VSIX Installer with Microsoft Visual Studio Version Selector, I see the following error message:

This extension is already installed to all applicable products.

I also see the same versions listed in "Manage Extensions" for both of those extensions, and WinUI appears in the new project templates now, but none of these were listed previously even though I had already tried installing WindowsAppSDK.Cs.Extension.Dev17.Standalone.vsix and performed all of the steps described above followed by a reboot. I changed nothing and tried nothing I hadn't already tried. Maybe a second reboot was required? I'm certain there is a bug here, but I don't know how to help uncover it at this point. I'm guessing we should close this issue, and someone can open a new one linking to it if they encounter the same problem?

For VS 17.1, you can install the template via VS installer. You can try to install or uninstall and see if there's still problem.

This issue is about that process not working as intended.

@evelynwu-msft FYI

Same issue. clean windows 11 & vs 17.1 install

Same issue with Windows 11 & VS 17.2.1. Installing the VSIX manually fails stating a newer version of the product is already installed.


Raise CC error alert threshold

What
This is triggered during almost every deploy due to what appears to be a bug in cloud controller. This raises it to require around 5% of the requests-per-minute to be errors.
How to review
Code review.

Is this still needed now that we've updated the metrics collector app?

@alext After checking the logs probably not, will close.


[3362] Validate that date of birth is not too long ago

Context
https://trello.com/c/rjoQD1ep/3362-add-date-of-birth-validation
Changes proposed in this pull request
We've had an issue whereby a trainee was entered with a Medieval birthday - unsurprisingly the TRN request was rejected.
This PR adds an extra past-date validation.
Guidance to review
Try to create a trainee with a birthdate more than 100 years ago. It should fail.

 Add date of birth validation


random order of data for each annotator & not showing other annotators' decisions to annotators

Hi,
I am creating a project and multiple annotators can sign up and check my project to annotate some data.
I would like to show the data to each annotator in different order. And when an annotator opens a sample to annotate, he/she has to click on the "new annotation" button to create his/her own annotation for that sample and he/she can see the previous annotations of other annotators so their decision can be biased.
How can I show data to each annotator in different order and prevent them to see other annotators decisions?

@fatihbeyhan Hi, it looks like different role mechanics, but LS supports only one admin role for all users.
You can deep into codes and modify them to show limited annotations: https://github.com/heartexlabs/label-studio/blob/master/label_studio/tasks/serializers.py#L117
Also we have an advanced roles & permissions in our enterprise solution.

@fatihbeyhan

data to each annotator in different order
Do you mean order on Label button click? (Label stream)

Hi, @fatihbeyhan !
Currently, if you want to randomize show order for your annotators, you can tweak the project settings parameter via project API PATCH /api/projects/<pk> with the data payload like this {"sampling": "Uniform sampling"}. We will make it handier in the near future

That is not exactly "random" actually. I tried it. First annotator will see the samples in a random order however second annotator will see the samples in the same order first annotator did. Therefore, I forked and changed the code a bit and achieved the random order for each annotator, with the help of one of your devs in Slack group (Thank you Nikolai Liubimov!).
I would like to suggest to put this as a feature. I would also suggest to put another feature. Annotators should label the data totally independent of each other. In this version, annotators can see the annotations of others. I am using your platform for academic purposes and we hire some undergrad students for labelling. I would like them to annotate the same data without being biased with others' annotations. If they use the Label button on the top right corner, they will not see any annotation of previous annotators, yet, this could be an optional feature, too.
Thank you for your help!

@fatihbeyhan I'd suggest you to split your tasks into different tabs based on non-intersected task ids. One tab per annotator. In this case they will be strongly separated among annotators.


Transfer Validation Improvements: Partitioned Upload

PartitionedUploader now calculates checksums on its non-oneshot code paths.

API change check
API changes are not detected in this pull request.


When you click a menu, such as creating a new file, the atom application sometimes exits unexpectedly

Versions
Atom: 1.44.0
MacOs: 10.15.3
Installed plugin
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

Im seeing the same issue with the same version of Atom. 1.44.0
Fresh install and here are the only packages i have installed...
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>I typically see this when I right click on New File, New Folder, Copy File Path.
Actually as i typed that I right clicked in the menu to see the sub menu items that I typically click...without even clicking on the submenu, I clicked in my browser to get focus here and Atom crashed.

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:

@Brolly0204 and @sethfloydjr thanks for the report folks, just something very important to point out, following the steps on the template can be very helpful and you definitely need to run Atom in the safe mode with all plugins/packages disabled, in case one of the community packages are causing this then it's up to the developer to resolve it or reach out to us if there is a conflict.

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way 😀
@Brolly0204 and @sethfloydjr thanks for the report folks, just something very important to point out, following the steps on the template can be very helpful and you definitely need to run Atom in the safe mode with all plugins/packages disabled, in case one of the community packages are causing this then it's up to the developer to resolve it or reach out to us if there is a conflict.

I think it's time to upgrade the electronic and node versions, which vscode team did well, but I also like atom

Keep happening to me to

@lkashef  link to template ?

The application of atom is not stable enough, and the application starts slowly taking up CPU. I hope it can be improved

@lkashef link to template ?

@orchidfire when you report a new issue, the body will have the template by default


Make PandA hdf resource_path relative to root

Fixes #379

Tagging @mrakitin to make sure this won't impact NA-side PandA filewriting expectations?

Abandoning to prevent merge conflicts with #397 which should resolve this issue


typo: unmouted -> unmounted

@nschonni : Thanks for your contribution! The author, @mestew, has been notified to review your proposed change.


Documentation: Terminology

Validate the terminology used in the app and the wiki:

Packages are mixed up with Project Manifest
TBC...

Closing.


Integration test for Kyma metrics collector

Description

Right now there are no integration tests for Kyma metrics collector which will ensure that it can scrape a running Kyma cluster and send metrics to some test namespace of event data platform. The aim of this issue to have such tests whenever there is a change in the charts for Kyma metrics collector.
Reasons

Ensure quality standards.
Scenario

[ ] skr (A)  registered to KEB
[ ] kmc scrapes A
[ ] metrics sent to edp dev

Acceptance

[ ] Integration with spinnaker

My idea is to add another step in pre-main-control-plane-gke-integration to test the functionality of KMC.
WIP PRs:
https://github.com/kyma-project/test-infra/pull/4534
https://github.com/kyma-project/control-plane/pull/1176
I discarded the original plan of "Integration with spinnaker" cause the feedback will be too late for a developer(as Spinnaker jobs are executed once a PR is merged to main) whereas having it in "pre-main-control-plane-gke-integration" will make sure we test KMC along with other components of the control-plane on every change in "resources" folder.

Current state:
There is a skeleton in test-infra to execute the job.
Todo:

[ ] Implement integration test for KMC

@FriedrichWilken would you please share you findings ?


Create Google Group

User group created :
http://groups.google.com/group/gatling

Developer grup created :
http://groups.google.com/group/gatling-dev


fix(bazel): ensure jsr250 is on the classpath for JDK9+ java_proto_toolchain extraction

Jay, is this still relevant?


net/http: Client.Do documentation is incorrect about *url.Error.Timeout

What version of Go are you using (go version)?

$ go version
go version go1.16.4 linux/amd64

Does this issue reproduce with the latest release?
Yes.
It also reproduces with go1.17 devel.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/home/manlio/.local/bin"
GOCACHE="/home/manlio/.cache/go-build"
GOENV="/home/manlio/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE="*.local"
GOMODCACHE="/home/manlio/.local/lib/go/pkg/mod"
GONOPROXY=""
GONOSUMDB="*.local"
GOOS="linux"
GOPATH="/home/manlio/.local/lib/go:/home/manlio/src/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.4"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1653706074=/tmp/go-build -gno-record-gcc-switches"
GOROOT/bin/go version: go version go1.16.4 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.16.4
uname -sr: Linux 5.12.5-arch1-1
/usr/lib/libc.so.6: GNU C Library (GNU libc) release release version 2.33.
gdb --version: GNU gdb (GDB) 10.2

What did you do?
https://play.golang.org/p/YQH5oWtQWjC
What did you expect to see?
timed out: true
As documented by https://golang.org/pkg/net/http/#Client.Do:
Any returned error will be of type *url.Error. The url.Error value's Timeout method will report true if request timed out or was canceled.

What did you see instead?
timed out: false

If this is just a documentation fix, this can land any time. I haven't read deeply into this, but maybe you're up for contributing the doc fix? :) See https://golang.org/doc/contribute.
CC @neild

Looking at the source code, the implementation does not check if Client.send returns context.Canceled.  So it is either the documentation incorrect or the implementation incorrect.
Also, I think that the TODO in https://go.googlesource.com/go/+/refs/heads/master/src/net/http/client.go#732 is wrong.  The send function seems  to returns err == context.Canceled and didTimeout() == false when the context is canceled.

I was going to say that we should drop the mention of the Timeout method in favor of errors.Is(err, context.DeadlineExceeded) or errors.Is(err, os.DeadlineExceeded), but those are apparently different errors and I'm not 100% certain that net/http consistently returns one or the other.
We should make sure that it's possible to test for timeouts with a single sentinel error and document that.

According to #33545, the problem is with the documentation.  https://golang.org/cl/200798 also locked-in the current behavior with a test.
The problem is that #33545 only fixed the documentation of the Client.Get method, forgetting(?) the Get function and Client.Do method.


RPC AIO deployments expose Elasticsearch service externally

On which version(s) do you encounter this issue?
I'm unsure of the version.
What type of issue is this? Please tick the appropriate box.

[x] bug - existing functionality that does not work for you as documented
[ ] feature - new functionality that you would like to see added

What is the expected behavior?
Elasticsearch ports should be restricted so that the service isn't exposed to the external network.
What is actually happening?
RPC AIO deployments expose the elasticsearch port to the external network. This is a security concern.
What were you attempting to do when you encountered this error (give as much detail as possible)?
An external reporter found an RPC AIO deployment on a public server and was able to access data in elasticsearch.
How can we reproduce this issue?
Build an RPC AIO deployment.
How can we verify your issue is addressed?
Verify that Elasticsearch isn't accessible from a network external to the AIO deployment.
If you are using or know of a workaround please describe the necessary steps?
Only available workaround is iptables.
What is your evaluation on the importance of this issue, and why?
Fairly important since this can be abused remotely.

This section is completed during the issue resolution process. If you are reporting an issue, please do not modify the section below.
Which branches are impacted by this issue?
Remove branches that are not impacted.
For each pull request, update the branch line to reference it.

[ ] master
[ ] mitaka-13.0
[ ] liberty-12.2
[ ] kilo

Upgrade impact. Consider the impact on moving between major, minor and patch releases.

[ ] This change does not impact upgrades
[ ] This change addresses a potential upgrade impact
[ ] The upgrade impact is being tracked by another issue.

The issue tracking the upgrade impact is:
Testing impact

[ ] An issue/pull-request has been create or exists to track the testing gap, and is referenced below
[ ] This change includes additional testing
[ ] This change is tested by the existing setup

Additional testing links:
Release note

[ ] This change includes a release note.
[ ] This change does not require a release note.

Doc Impact
Does your change require documentation?

[ ] Yes, and I submitted an issue to Docs issues
[ ] Yes, and I contributed a documentation patch to docs-rpc
[ ] No documentation required for this change

Additional documentation links (please add links if you have ticked yes):

Given that customers sit behind a firewall I've marked this as prio-2, we can discuss in this afternoon's meeting if we need to raise the priority.


duplicate type IDs in groupby query

A groupby query on a zqd-imported space results in duplicate groups due to spurious type IDs. (The same query run on a all.zng obtained by manually running  zq  ~/Downloads/sampledata/corelight19/zeek-logs/*.log > ./all.zng does not show this bug.)
#zenum=string
#0:record[proto:zenum,count:uint64]
0:[tcp;20968;]
0:[udp;35488;]
0:[icmp;1048;]
#zenum=string
#1:record[proto:zenum,count:uint64]
1:[tcp;22328;]
1:[udp;19736;]
1:[icmp;520;]
#zenum=string
#2:record[proto:zenum,count:uint64]
2:[tcp;256860;]
2:[udp;483354;]
2:[icmp;12120;]
#zenum=string
...

This is an issue with aliases and stream type resets. Here's a much simpler repro of the bug, followed by a minor variation where the bug is absent. The only difference between both cases is that order of the first two input records is inverted. The reason for the bug is that in the first case the alias types get different IDs in the different streams, and our translation scheme does not recognize that they are identical. The issue does not occur in the second example because the aliases happen to get the same IDs.
incorrect:
~/work/brim/zq(master)
$ cat bug.tzng
#0:record[ts:time]
0:[1425565512.963801;]
#zenum=string
#1:record[ts:time,proto:zenum]
1:[1425565514.419939;udp;]
#zenum=string
#2:record[ts:time,proto:zenum]
2:[1425565514.419939;udp;]
~/work/brim/zq(master)
$ zq -b 2 bug.tzng | zq -t "count() by proto" -
#zenum=string
#0:record[proto:zenum,count:uint64]
0:[udp;1;]
#zenum=string
#1:record[proto:zenum,count:uint64]
1:[udp;1;]

correct:
~/work/brim/zq(master)
$ cat bug.tzng
#zenum=string
#0:record[ts:time,proto:zenum]
0:[1425565514.419939;udp;]
#1:record[ts:time]
1:[1425565512.963801;]
#zenum=string
#2:record[ts:time,proto:zenum]
2:[1425565514.419939;udp;]
~/work/brim/zq(master)
$ zq -b 2 bug.tzng | zq -t "count() by proto" -
#zenum=string
#0:record[proto:zenum,count:uint64]
0:[udp;2;]

An even simpler repro without groupby:
$ echo "#0:record[ts:time]
0:[1425565512.963801;]
#zenum=string
#1:record[ts:time,proto:zenum]
1:[1425565514.419939;udp;]
1:[1425565514.419939;udp;]
" | zq -b 2 - | zq -t -
#0:record[ts:time]
0:[1425565512.963801;]
#zenum=string
#1:record[ts:time,proto:zenum]
1:[1425565514.419939;udp;]
#zenum=string
#2:record[ts:time,proto:zenum]
2:[1425565514.419939;udp;]

has duplicate types 1 and 2 in the output, vs the same without -b 2 which does not:
$ echo "#0:record[ts:time]
0:[1425565512.963801;]
#zenum=string
#1:record[ts:time,proto:zenum]
1:[1425565514.419939;udp;]
1:[1425565514.419939;udp;]
" | zq  - | zq -t -
#0:record[ts:time]
0:[1425565512.963801;]
#zenum=string
#1:record[ts:time,proto:zenum]
1:[1425565514.419939;udp;]
1:[1425565514.419939;udp;]

Verified in zq commit 276030d.
I first took a step back and did something like the original repro after importing the Zeek format zq-sample-data into GA Brim tagged v0.12.0 pointing at zqd commit v0.16.0. I'm then doing the querying against the all.zng using zq commit 4ac12dd, which still had the issue.
$ zq -t '_path=conn | every 1min count() by proto | sort ts' all.zng
#zenum=string
#0:record[ts:time,proto:zenum,count:uint64]
0:[1521911700;icmp;2840;]
#zenum=string
#1:record[ts:time,proto:zenum,count:uint64]
1:[1521911700;icmp;45;]
#zenum=string
#2:record[ts:time,proto:zenum,count:uint64]
2:[1521911700;tcp;3051;]
1:[1521911700;udp;33;]
0:[1521911700;udp;441;]
2:[1521911700;icmp;110;]
...

Then querying the same all.zng with zq commit 276030d:
$ zq -t '_path=conn | every 1min count() by proto | sort ts' all.zng | head -20
#zenum=string
#0:record[ts:time,proto:zenum,count:uint64]
0:[1521911700;udp;533;]
0:[1521911700;tcp;43771;]
0:[1521911700;icmp;3324;]
0:[1521911760;tcp;79586;]
0:[1521911760;udp;856;]
0:[1521911760;icmp;504;]
0:[1521911820;icmp;58;]
0:[1521911820;tcp;46524;]
0:[1521911820;udp;1062;]
...

Thanks @henridf!


Multiconcons fw

Can be optimized further. Can be done during handling of N-S case.

@rukansari @ashutosh-mishra

Ashutosh, Vikash, can we have the patch modified to have a single approach for both LB and Firewall sharing. Only difference I see is that in case of firewall we have to add new rules in case of create or remove rules for delete which is not required for LB.

Magesh there are other also, the major difference is in delete.
On Mon, Aug 24, 2015, 1:33 AM mageshgv-oc<EMAIL_ADDRESS>wrote:

Ashutosh, Vikash, can we have the patch modified to have a single approach
for both LB and Firewall sharing. Only difference I see is that in case of
firewall we have to add new rules in case of create or remove rules for
delete which is not required for LB.
—
Reply to this email directly or view it on GitHub
https://github.com/oneconvergence/group-based-policy/pull/32#issuecomment-133911349
.

For LB we can use the validation used for firewall, which is smaller.
On Mon, Aug 24, 2015, 7:43 AM Vikash Kumar<EMAIL_ADDRESS>wrote:

Magesh there are other also, the major difference is in delete.
On Mon, Aug 24, 2015, 1:33 AM mageshgv-oc<EMAIL_ADDRESS>wrote:

Ashutosh, Vikash, can we have the patch modified to have a single
approach for both LB and Firewall sharing. Only difference I see is that in
case of firewall we have to add new rules in case of create or remove rules
for delete which is not required for LB.
—
Reply to this email directly or view it on GitHub
https://github.com/oneconvergence/group-based-policy/pull/32#issuecomment-133911349
.

Merging for devops testing. branch open for review comments


908: Set distribution to gardenlinux in os-release

How to categorize this PR?
/kind enhancement
/area os
/os garden-linux
What this PR does / why we need it:
Make GardenLinux a Debian Derivative
Which issue(s) this PR fixes:
Fixes #908
Special notes for your reviewer:
Release note:
NONE

During a recent weekly we spoke about outsourcing that file into a 'base-files' package. I would recommend not doing it in base-files directly, as this would override the existing and constantly patching it. We maybe should think about a base-files-gardenlinux package.


gimp-dev: add version 2.99.8

Closes #361

Based on https://github.com/ScoopInstaller/Extras/blob/master/bucket/gimp.json

Commented out the section for pygimp.env in installer because no longer present in v2.99+

[x] I have read the Contributing Guide.

/verify


why multi_label=True?

model.compile(loss=loss_fn, optimizer=optimizer,
metrics=[tf.keras.metrics.AUC(curve='ROC', multi_label=True),
tf.keras.metrics.AUC(curve='PR', multi_label=True)])
I would like to ask if multi_label=True is used in the optimization of the model, which is equivalent to calculating AUC per cell and optimizing it? And then calculated the per peak and per cell AUC of the test dataset directly with the optimized model? And the subsequent analysis is using this per cell AUC optimized model? (Why not set multi_label=False to optimize, that is, calculate the overall AUC of all samples, or optimize with the AUC of per peak?)

Hi,
The model is optimizing on cross-entropy loss. multi-label AUC is the metric we used to track performance and used as the criteria for early-stop. multi-label AUC is calculating AUC per cell, and taking an unweighted average. We give each cell equal weight in this way. Since cells have different depth, and different ratio of pos/neg, I chose to track multilabel AUC.

Hi,
Thanks for your response！it has been very helpful to me~
And I have another question: Why, when evaluating a model's generalization performance, do we calculate AUC separately for "per cell" and "per peak" rather than using a single overall AUC? Is this a common practice? I have noticed this approach in other articles as well.
Wish you all the best！

Hi,
Sorry for missing this comment. Per cell AUC quantifies whether the model can distinguish accessibility across different genomic regions. Per peak AUC quantifies whether the model can distinguish accessibility across different cell types. They quantify different properties of the model.


Possibility for Square Root in Kind 2 on Variables of Type Real

Hello,
is there a possibility to express the (square) root operator in Kind2 so that SMT-Solvers get along with it? I tried implementing the square root operator using Heron algorithm with inductive array defintion and old fashioned simple variables. But SMT-Solvers do not get along with that. As far as i know Z3 supports root operators. Am i missing a operator for square root or is that not part of Kind2 like it is in Lustre?
Thanks for help.

The square root is not a built-in operator in Kind 2. However, you can easily define it using an imported function as follows:
function imported sqrt(n: real) returns (r: real);
(*@contract
  assume n >= 0.0;
  guarantee r >= 0.0 and r * r = n;
*)

If your model contains polynomial non-linearities, I recommend you to use Yices 2 as the back-end solver. In our experience Kind 2 with Yices 2 succeeds more often with these kind of problems. To use Yices 2 as the back-end solver, pass this argument --smt_solver Yices2. If the yices-smt2 binary is not in your PATH, you can provide the path with --yices2_bin /path/to/yices-smt2

Hello Mr. Larraz,
thanks for your fast support. This is a really nice feature I have never thought about, because I am a bit new in this tool. This saved the day. Maybe the hole week. In the documentation this feature is introduced, but I have not understood the full power of this feature. This could be a nice example for future versions of the documentation, so that more people get familar with this feature.
Best regards
Andreas Vorwald


no click on dblclick

double click on link in edit mode didn't open the edit form, since the click event took over and users got redirected

LGTM

:+1:

Coverage remained the same at 90.131% when pulling e292d8e0e132e219facb9dde40ca3ac45d7b47d1 on dhorelik:bugfix/link-single-click into ada7b700494fa17ed0998c8316cec43c23b14a51 on divio:develop.


kubeadm: start using v1beta4 in all docs

make some updates to --config on upgrade, as now it supports an v1beta4,UpgradeConfiguration and there is no possibility to reconfigure using --config on upgrade anymore.
start using v1beta4 in all examples, the v1beta4 API page is already generated but needs update for 1.31.

xref https://github.com/kubernetes/kubeadm/issues/2890

/approve


Add virtual scrolling to tables

Replaces most mat-tables with tables using the NGrid library, supporting
extremly performant virtual scrolling.
The ListViewBaseComponent have been extremly simplified.
All list-view code is now mich shorter and way less repitative
The group list and the workflow list have not been altered.
Works:

Fast virtual Scrolling without pagination
Click Filter
Search Filter
Sorting
Export filtered values (using click filters)
Export sorted values in correct order
Right-Click-new-tab
Hiding/showing columns by permission and screen size
Multi select
Auto Updates in MultiSelectMode keep the correct items selected
OsHeadBar shows the correct amount of data
Restore scroll position after navigation
Shared-Table Component
Clean-Up base-list-view
Motion List
Motion Block List
Motion Block Detail
User List
Agnnda List
Assignment List
MediaFile List
HistoryList (Also sorts using the repo as it should)

TODO:

Formulate filter predicates
Horrizontal Scrolling, if the screen get's too small.
Firefox has issues in the change detection

BUG:

Using the seach filter prevents the sorting from working.
NGrid currently has no way to get the filtered list
using search filter. Thus, search-filtered list cannot
be exported.

That should work. Layout can probably be enhanced in some views.
Current bugs, besides firefox, are mainly in the search filter behavior.
https://github.com/shlomiassaf/ngrid/issues/6

@emanuelschuetze can be tested. I updated the description of this PR.

"File to import not found or unreadable<EMAIL_ADDRESS>
that's odd. Perhaps some new updates I did not apply yet.

Travis currently reports, that the heap size is maxed out.
https://github.com/angular/angular-cli/issues/13734

I had this issue before. Maybe this helps: Look into our package.json from ng-high-memory. Usage:
npm run ng-high-memory -- build --prod.

Travis fixed by changing command in .travis.yml


Mini issue on update

Hi Guys,
Just as a note (maybe for reference, and documentation updates).
I've updated grav, from rc4 to rc7, but i didn't update the plugins initially.
Doing that took me in the following funny situation
-bash-4.1$ php bin/grav newuser

DEPRECATED COMMAND
  `bin/grav new-user` has been deprecated in favor of the new `bin/plugin login new-user`
-bash-4.1$ php bin/plugin login new-user
No Console Commands for 'login' where found in 'plugins://login/cli'

Updating the plugins obviously fixed the issue, since the user management is in the admin plugin.

Where did you see this reference to bin/grav newuser ? I thought I had updated all the references?

@rhukster https://github.com/getgrav/grav-plugin-admin . Want me to do a pull request ? Or just a quick fix away ?

This is not something for Grav, this is something you should do in your plugin's CLI command.

@rhukster what do you mean ? Was this related to the other issue ? At the moment it's just a documentation line change on the grav-plugin-admin .

Ugg sorry, i was replying to another issue and got my tabs confused!  Please submit a PR yes.

No problem. https://github.com/getgrav/grav-plugin-admin/pull/324


update supported versions

Codecov Report

Merging #5 (d708a83) into master (3d398fe) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           17        17
=========================================
  Hits            17        17

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


bug: cube validation failing in prod

Need

update 7/8 failing due to low rankit value for ACTB. Working with @pablo-gar to determine if its a change in the data or an issue with the underlying code

link to https://github.com/chanzuckerberg/single-cell-data-portal/pull/2845

@MDunitz closing


[breakpoints] Add ultra-wide breakpoint

This PR was created due to a failing build in my Material-UI PR regarding the same topic: Add an ultra-wide breakpoint.
It was failing to build due to its Pigment components failing to get the uw breakpoint from this package so added uw to this package as well.

[x] I have followed (at least) the PR section of the contributing guide.

Hi @siriwatknp & @zannager ,
I wanted to follow up on this PR to see if you had a chance to review it. Is there anything I can do to help move it forward? Any feedback or suggestions are welcome.
Thanks for your time and assistance!


Download m3u8 with local ts location url

i have m3u8 file, and parsed it all good, but on download it's error, because ts file names - local.
I know how resolve this error, but it'll be great if lemondeer can detect this case.
example:
#EXTM3U\n#EXT-X-TARGETDURATION:16\n#EXT-X-ALLOW-CACHE:YES\n#EXT-X-PLAYLIST-TYPE:VOD\n#EXT-X-VERSION:3\n#EXT-X-MEDIA-SEQUENCE:1\n#EXTINF:3.000,\n143.240p.1.ts?s=tmaRGviiU5bYDojIpV6VWA&e=1530909205\n#EXTINF:13.000,\n143.240p.2.ts?s=tmaRGviiU5bYDojIpV6VWA&e=1530909205\n#EXTINF:16.000,\n143.240p.3.ts?s=tmaRGviiU5bYDojIpV6VWA&e=1530909205\n#EXTINF:16.000,\n143.240p.4.ts?s=tmaRGviiU5bYDojIpV6VWA&e=1530909205\n

@vfumin Thanks for reporting this. Yes there are file name cases need to deal with. I'll fix it as soon as I can.


Paginated Query at storage level

Query uses an iterator to fetch from the storage. This means that ask one-by-one all the records. For each call to the storage this means a READ LOCK at storage level + READ LOCK at record level.
On concurrent environment a query could disrupt performance of other read/writes for the huge contention on storage+record lock mgr.
My proposal is to allow to fetch X records per call, so we could create a new method like:
  public List<OStorageOperationResult<ORawBuffer>> readRecord(
     OCluster iCluster, long iBegin, long iEnd,
     String iFetchPlan, boolean iIgnoreCache, ORecordCallback<ORawBuffer> iCallback, boolean loadTombstones, LOCKING_STRATEGY iLockingStrategy);

Already implemented in 2.2


Exception (or error reporting) system

EVM1 provides no option to convey why an executed was stopped.  We should think about ways supporting different exceptions, perhaps even with messages.
This isn't only a change for the VM, but the protocol: transaction receipts should also include the execution outcome.

The following transaction outcomes are possible:

successful, no data returned
successful, data returned
out of gas
explicit user throw (with message)
mark for deletion (selfdestruct), data returned
mark for deletion (selfdestruct), no data returned


Replace Mask-RCNN with SSD for object detection

From our experience with customers, most prefer SSD/YOLO based models for object detection, since they run at faster FPS. Also, most companies do not have detailed instance-based segmentation annotations for their data. Recommend this change to make the benchmarks for relevant to the  industry. As far as image input size, it would be good to explicitly state higher resolution (i.e. 4K or HD)
Supporting orgs: Intel, dividiti, NVIDIA

5/17 meeting resolved to add instead of replace, provided that TF and possibly pytorch is complete by 7/1.


Set custom timeout limit per describe block

The issue was that the binding to the suite object inside of describe blocks was being lost because of the Meteor.bindEnvironment wrapping. Mocha binds the suite to the describe function block here: https://github.com/mochajs/mocha/blob/master/mocha.js#L1001.
I made a workaround so Mocha's binding could get through Meteor.bindEnvironment.
Not sure about how the function should be called, so I went with wrapRunnable.
With this fix, we will no longer get the global object as this value inside of describe blocks.
Fixes https://github.com/mad-eye/meteor-mocha-web/issues/82.

Timeout is really needed. How can I help to speed this up?

@rissem is it possible to merge this?

Congrats! Let's just hope nothing breaks. :)

Thanks @rissem. I'm using this on my own fork and it appears to work well.

Just a note, I think a similar fix will be needed to provide the mocha context for it() if we wanted test specific timeouts.

@taromero You sure this fixes the problem? I still get the global context in my describe's...

@marcodejongh I haven't tried it since I made the fix almost 4 months ago (it worked then).
What version of meteor-mocha are you using? The latest release I can see on Atmosphere is 0.5.2 which is prior to merging this.

@taromero Version 0.5.2. According to atmosphere 0.5.2 was published on feb 20 2015.
Meteor packaging should really enforce tagging of versions because if there was a tagged version there would be now confusion.

@marcodejongh right, and since this PR was merge some point after feb 20 2015, it isn't included on 0.5.2.
Latest version (on master) declared on package.js is 0.5.3-rc.1. That version bump was after this PR merge, so maybe you can try using 0.5.3-rc.1.

Sorry to comment on an old thread, but does it work in the latest version? In my tests, neither this.timeout(number) in describe, nor in it blocks work. The this object doesn't have a method called timeout.

@Slava I've been using my own fork, but I suspect the changes may not have been published as a new version yet? Might need to check out the package as a submodule.

@aramk what do you mean? I am using the published version of this package depending on mike:mocha-package

I'm not too sure - Atmosphere has different versioning to this repo which seems to be updating the smart.json file. We should have some tests which use the timeout just to check.

@Slava could you confirm the mike:mocha's version number that you are using?


Trim trailing spaces from post titles

This avoids errors when trying to open a file in the post directory, since creating a folder with a trailing space on Windows will result in it being trimmed. For example:

Thank you for your contribution! This is released in v0.9.2.


library not working with my local server.

Hi there!
we're following instructions for setting up a learning environment for my child to learn to code Python with Minecraft following the book "Learn to Program with Minecraft: Transform Your World with the Power of Python"
https://www.amazon.com/Learn-Program-Minecraft-Transform-Python/dp/1593276702
We're new to Minecraft, but I can understand some Python.
Our setup:

Mac Sonoma 14.2.1
Python 3.9
Minecraft server 1.21
mcpi 1.2.1

With this setup, we're able to do a Minecraft.create but when doing other operations, it seems like the API and the server can't talk to each other properly.
For example, executing mc.player.getPos() throws an Exception, stacktrace below.
Can someone please help us?
All the best.
Javier
 mc.player.getPos()
^C---------------------------------------------------------------------------
KeyboardInterrupt                         Traceback (most recent call last)
Cell In[3], line 1
----> 1 mc.player.getPos()

File /Library/Python/3.9/site-packages/mcpi/minecraft.py:153, in CmdPlayer.getPos(self)
    152 def getPos(self):
--> 153     return CmdPositioner.getPos(self, [])

File /Library/Python/3.9/site-packages/mcpi/minecraft.py:46, in CmdPositioner.getPos(self, id)
     44 def getPos(self, id):
     45     """Get entity position (entityId:int) => Vec3"""
---> 46     s = self.conn.sendReceive(self.pkg + b".getPos", id)
     47     return Vec3(*list(map(float, s.split(","))))

File /Library/Python/3.9/site-packages/mcpi/connection.py:62, in Connection.sendReceive(self, *data)
     60 """Sends and receive data"""
     61 self.send(*data)
---> 62 return self.receive()

File /Library/Python/3.9/site-packages/mcpi/connection.py:54, in Connection.receive(self)
     52 def receive(self):
     53     """Receives data. Note that the trailing newline '\n' is trimmed"""
---> 54     s = self.socket.makefile("r").readline().rstrip("\n")
     55     if s == Connection.RequestFailed:
     56         raise RequestError("%s failed"%self.lastSent.strip())

File /Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/socket.py:704, in SocketIO.readinto(self, b)
    702 while True:
    703     try:
--> 704         return self._sock.recv_into(b)
    705     except timeout:
    706         self._timeout_occurred = True

KeyboardInterrupt:

In [4]: mc.player.getPos()
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In[4], line 1
----> 1 mc.player.getPos()

File /Library/Python/3.9/site-packages/mcpi/minecraft.py:153, in CmdPlayer.getPos(self)
    152 def getPos(self):
--> 153     return CmdPositioner.getPos(self, [])

File /Library/Python/3.9/site-packages/mcpi/minecraft.py:47, in CmdPositioner.getPos(self, id)
     45 """Get entity position (entityId:int) => Vec3"""
     46 s = self.conn.sendReceive(self.pkg + b".getPos", id)
---> 47 return Vec3(*list(map(float, s.split(","))))

ValueError: could not convert string to float: ''

Also, in ipython, when I do that, I see a lot of these messages:
Last Message: <b'world.setBlock(10,10,10,1,0)'>
Drained Data: <b''>
Last Message: <b'world.setBlock(10,10,10,1,0)'>
Drained Data: <b''>
Last Message: <b'world.setBlock(10,10,10,1,0)'>
Drained Data: <b''>
Last Message: <b'world.setBlock(10,10,10,1,0)'>
Drained Data: <b''>
Last Message: <b'world.setBlock(10,10,10,1,0)'>
Drained Data: <b''>
Last Message: <b'world.setBlock(10,10,10,1,0)'>
Drained Data: <b''>
Last Message: <b'world.setBlock(10,10,10,1,0)'>
Drained Data: <b''>
Last Message: <b'world.setBlock(10,10,10,1,0)'>
Drained Data: <b''>
Last Message: <b'world.setBlock(10,10,10,1,0)'>
Drained Data: <b''>
Last Message: <b'world.setBlock(10,10,10,1,0)'>
Drained Data: <b''>

MCJE doesn't know these commands by itself, it needs a mod to translate it into something it understands. The book should go over which mod you need and how to install it, but in case it doesn't, RaspberryJuice is the most commonly used. Unfortunately none of these mods have been updated to 1.21 to my knowledge.

Thank you very much!
wondering if there are big changes in the newer versions of the server
(1.21)... if not, I might contribute with a PR.
Do you know where I can find information on the different versions of the
protocol?
El mar, 9 jul 2024 a las 19:29, Bigjango13 @.***>)
escribió:

MCJE doesn't know these commands by itself, it needs a mod to translate it
into something it understands. The book should go over which mod you need
and how to install it, but in case it doesn't, RaspberryJuice is the most
commonly used. Unfortunately none of these mods have been updated to 1.21
to my knowledge.
—
Reply to this email directly, view it on GitHub
https://github.com/martinohanlon/mcpi/issues/38#issuecomment-2218285232,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALJ6WHVP5GLWXJRLS6YNELZLQMYFAVCNFSM6AAAAABKSTQDASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJYGI4DKMRTGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'm a little confused, the protocol isn't in MCJE, and as far as I know never has been. The protocol was invented in Minecraft Pi Edition[^1]. this library is a python frontend to it[^2]. To use it with MCJE, you need a mod that implements this protocol, if you wanted to use it in modern Java Edition, you would have to make a mod that implenents this protocol.
[^1]: Unofficially documented here: https://www.stuffaboutcode.com/p/minecraft-api-reference.html
[^2]: For different languages, there are different frontends: https://mcpirevival.miraheze.org/wiki/Minecraft:_Pi_Edition_Scripting_API

There are no future planned releases of RaspberryJuice - https://github.com/zhuowei/RaspberryJuice - it maybe that someone picks ups the project and makes a v2 but so far that hasnt happened.
Fyi - You can run RaspberryJuice with later versions of Minecraft, but not all features of the later versions will be available through the API - you can get the plugin at - https://www.spigotmc.org/resources/raspberryjuice.22724/
Im going to close the issue as it isnt a problem with mcpi


Introduce primal_cost for quadratic/fused problems

Following #184, introduce primal_cost for quad problems.
Originally posted by @marcocuturi in https://github.com/ott-jax/ott/issues/184#issuecomment-1328361925

closed by #286


ci(binding/java): Enable release when OPENDAL_RELEASE is on

Let me prepare a patch for this issue. We can use an argument over env var, which is how we currently work.

You can push to this branch directly.

I will split the php related logic to a new PR.

Ok, I know the root cause: we are building rocksdb.

If so, perhaps --release or not doesn't make too many changes?

If so, perhaps --release or not doesn't make too many changes?

Maybe not as good as I expected, but will be faster.

OK. Ping me when you factor out the PHP changes. I'll push my solution on this branch then.

OK. Ping me when you factor out the PHP changes. I'll push my solution on this branch then.

https://github.com/apache/incubator-opendal/issues/3055


How to track down and fix circular dependency detected error?

I have a project that is broken into two parts - a "core" package and a CLI that uses the core. Both are authored in Typescript.
While trying to install the core typings for use in the CLI with typings install npm:lede I have been battling a circular dependency error:
typings ERR! message Circular dependency detected using "/Users/emurray/projects/lede-cli/node_modules/babel-register/package.json"

typings ERR! cwd /Users/emurray/projects/lede-cli
typings ERR! system Darwin 14.5.0
typings ERR! command "/Users/emurray/.nvm/versions/node/v6.3.0/bin/node" "/Users/emurray/.nvm/versions/node/v6.3.0/bin/typings" "install" "npm:lede"
typings ERR! node -v v6.3.0
typings ERR! typings -v 1.3.2

My "core" package is dependent on the following:
"dependencies": {
    "archieml": "^0.3.1",
    "aws-sdk": "^2.4.11",
    "babel-preset-es2015": "^6.9.0",
    "babelify": "^7.3.0",
    "browserify": "^13.0.1",
    "fs-extra": "^0.30.0",
    "glob": "^7.0.3",
    "livereload": "^0.4.1",
    "lodash": "^4.4.0",
    "node-sass": "^3.7.0",
    "nunjucks": "^2.4.2",
    "rimraf": "^2.5.2"
  },
  "devDependencies": {
    "ava": "^0.15.2",
    "coveralls": "^2.11.11",
    "nyc": "^7.0.0",
    "typescript": "^1.8.10",
    "typings": "^1.3.2"
  }

In my best effort to figure out what was going on, I added the high-tech debug statements
console.log("Source: " + src)
console.log("Parent: " + JSON.stringify(parent, null, 2))

just above this line in the typings-core source and then reran the command and piped stdout to a file.
The majority of that file is unimportant but the important bit is here at the end:
Source: /Users/emurray/projects/lede-cli/node_modules/babel-core/package.json
Parent: {
  "src": "/Users/emurray/projects/lede-cli/node_modules/babel-register/package.json",
  "raw": "npm:babel-register",
  "main": "lib/node.js",
  "browser": "lib/browser.js",
  "version": "6.11.6",
  "global": false,
  "dependencies": {},
  "devDependencies": {},
  "peerDependencies": {},
  "globalDependencies": {},
  "globalDevDependencies": {},
  "name": "babel-register",
  "parent": {
    "src": "/Users/emurray/projects/lede-cli/node_modules/babel-core/package.json",
    "raw": "npm:babel-core",
    "version": "6.13.2",
    "global": false,
    "dependencies": {},
    "devDependencies": {},
    "peerDependencies": {},
    "globalDependencies": {},
    "globalDevDependencies": {},
    "name": "babel-core",
    "parent": {
      "src": "/Users/emurray/projects/lede-cli/node_modules/babelify/package.json",
      "raw": "npm:babelify",
      "version": "7.3.0",
      "global": false,
      "dependencies": {},
      "devDependencies": {},
      "peerDependencies": {},
      "globalDependencies": {},
      "globalDevDependencies": {},
      "name": "babelify",
      "parent": {
        "src": "/Users/emurray/projects/lede-cli/node_modules/lede/package.json",
        "raw": "npm:lede",
        "main": "dist/index.js",
        "typings": "dist/index.d.ts",
        "version": "0.0.13",
        "global": false,
        "dependencies": {},
        "devDependencies": {},
        "peerDependencies": {},
        "globalDependencies": {},
        "globalDevDependencies": {},
        "name": "lede"
      }
    }
  }
}

So it seems to me that I am depending on a package (babelify) that depends on babel-core which depends on babel-register, which in turn depends on babel-core - thus the circular dependency!  However I find it curious that this circular dependency isn't thrown by npm itself and it has me wondering if typings isn't resolving this as it should be or if I have just royally messed something up.

I think this might be fixed in NPM v3 with flattening, but might not work in v2. That said, this behaviour may be able to be improved so that during resolution it can reference the parent type and during compilation it re-uses previous paths.

I get the same issue on with<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Anyone is welcome to submit a PR, I haven't had time to fix it. It's be a matter of re-using the pointer during dependencies.ts and then checking for pointers during compile.ts in typings-core.


Allow users to opt out of optimize calls on liquid-clustering/zordering

Describe the feature
Users want to capability to schedule their own optimize runs.
Describe alternatives you've considered
Currently dbt-databricks runs it after every call to merge in data, but some users would rather schedule out of band
Who will this benefit?
Users than update incremental tables frequently and want to batch optimize

Isn't this handled by --vars '{DATABRICKS_SKIP_OPTIMIZE: true}'? If we create another way to do it I'd be all for it, as the current vars argument is a pain, especially if a databricks workflow with a dbt task, but functionality-wise I thought we had this already.

Oh yeah!  I had forgotten that existed, but I do think it would be better to opt out on the config level.

I support this being on the config level especially as databricks now offers predictive optimization which runs optimize automatically as needed.


HardTabs should omit Makefiles

Makefiles need to have hard tabs in them.

Hey @dividedmind,
Overcommit used to add special cases for a number of different file types, but this quickly got out of hand and unrealistic for this project to manage.
Instead, we encourage developers to add exclusions as they see fit. You can easily exclude Makefiles from the HardTabs hook by adding the following to your .overcommit.yml:
PreCommit:
  HardTabs:
    exclude:
      - '**/Makefile'

Hope that helps.

Sweet, thanks! I didn't know that option, sorry to bother you instead of rereading the docs carefully.
(I still believe this should be a default: I can see how managing a ton of those can get out of hand, but Makefile is pretty much a weird one out in this regard and I think this can even be hardcoded in the hook.)