How to mark a library as supporting WP80 and WPA81?

I have a framework library that supports both WP80 and WPA81 profiles.  NuProj always detects it as WP80 which means that it will not install on projects that are based on WPA81.  Is there a way to tell NuProj to generate the target framework for both?

Is it a portable library? If so, and your targets include both platforms, NuProj should pick up on that automatically.
If it isn't a portable library -- it won't (reliably) work on wpa81, and so NuProj would be correctly excluding that.

Wouldn't that be dependent on what the library is doing?  There are a fair number things that are supported by both platforms (granted -- there are even more that are not)

If it is doing common things, it can be a portable library, no?
The wpa81 platform does not guarantee that it will even load a wp80 assembly from what I hear from my wpa81 owner friends. If it does, you're getting lucky. Anyway, I don't think we'll have NuProj support it as MSFT themselves don't support it on their platform.


Update dependency org.junit.jupiter:junit-jupiter to v5.9.3

This PR contains the following updates:

Package
Type
Update
Change

org.junit.jupiter:junit-jupiter (source)
test
minor
5.7.1 -> 5.9.3

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: pom.xml
Command failed: mvn dev.logchange:logchange-maven-plugin:add --non-recursive -DbatchMode -DfileName=renovate-org.junit.jupiter:junit-jupiter-5.9.3.yml -Dtitle="Upgraded  from 5.7.1 to 5.9.3" -Dauthor=marwin1991 -Dtype=dependency_update -Dlink.name=notes -Dlink.url=
/bin/sh: 1: mvn: not found

Renovate Ignore Notification
Because you closed this PR without merging, Renovate will ignore this update (5.9.3). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


Starlark builder

Complete the functionality that would allow bramble to use starlark as a build script. Once this issue is complete we should be able to build this derivation:
def run_busybox():
    bb = busybox()
    # whoami is now available to run
    bb.cmd("whoami").print()

def busybox():
    # download the executable, this is the only way you are allowed
    # to use the network during builds
    download = derivation(
        name="busybox_download",
        builder="fetch_url",
        env={
            "url": "https://brmbl.s3.amazonaws.com/busybox-x86_64.tar.gz",
            "hash": "2ae410370b8e9113968ffa6e52f38eea7f17df5f436bd6a69cc41c6ca01541a1",
        },
    )

    return derivation(
        name="busybox",
        builder=build_busybox,
        deps=[download],
    )

def build_busybox():
    os.mkdir("$out/bin") # using the builtin os module

    # move the busybox executable into the output for this build
    cmd("$busybox_download/busybox-x86_64",
        "cp",
        "$busybox-x86_64 $out/bin/busybox").wait()
    commands = []
    commands_started = False

    # run the busybox help text to extract supported commands
    for line in cmd("$out/bin/busybox").output:
        if commands_started:
            for name in line.strip().split(","):
                commands.push(name.strip())
        if "Currently defined functions" in line:# the builtin os module
            commands_started = True

    # move into the output directory so that symlinks are relative
    os.cd("$out/bin")

    cmd("./busybox ln -s busybox ln").wait()
    # link each command
    for cmd in commands:
        cmd("./ln -s busybox %s" % cmd).wait()

Completed, the script above runs. Still needs quite a bit of cleanup/stability work.


Truthiness test

More followon from interpretation of small nonempty zeros.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
17 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.05%) to 82.801%

Files with Coverage Reduction
New Missed Lines
%

src/compiler/clvm.rs
17
86.42%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
14958

Relevant Lines:
18065

💛  - Coveralls


ValueError: 'to_matrix' will return an exponentially large matrix

Environment

Qiskit Optimization version: 0.4.0
Python version: 3.8
Operating system:  Windows 10

What is happening?
I guess it is more a question than a real issue.
I have an optimization problem, with 5 variables.
Each variable is a matrix of size 2x2 containing integer variables.
I am using IntegerToBinary to convert the problem, as below:
def _solve_qp(self, qp):
        conv = IntegerToBinary()
        qubo = conv.convert(qp)
        backend = BasicAer.get_backend('statevector_simulator')
        quantum_instance = QuantumInstance(backend)
        qaoa_mes = QAOA(quantum_instance=quantum_instance,
                        initial_point=[0., 0.])
        qaoa = MinimumEigenOptimizer(qaoa_mes)
        return conv.interpret(qaoa.solve(qubo))

When I run the code above, I am getting this error:
 ValueError: 'to_matrix' will return an exponentially large matrix, in this case '7588550360256754183279148073529370729071901715047420004889892225542594864082845696x7588550360256754183279148073529370729071901715047420004889892225542594864082845696' elements. Set algorithm_globals.massive=True or the method argument massive=True if you want to proceed.

I am not sure whether my reasoning is wrong or if this is a limitation of Qiskit.
Could you help me, please?
How can we reproduce the issue?
N/A
What should happen?
N/A
Any suggestions?
No response

Could you paste the entire script to gist to reproduce the error?

Sure. Please find the gist here.

@t-imamichi were you able to reproduce the error with the gist?

Because you use unbound integer variables (no lower bound and no upper bound), they are converted into a large set of binary variables to generate a qubo. I printed out your problem and the result is as follows. The number of variables (272) is too much, which corresponds to the number of qubits.
input problem Problem name: docplex_model1

Minimize
  5*fro_mean_0_0^2 + 5*fro_mean_0_1^2 + 5*fro_mean_1_0^2 + 5*fro_mean_1_1^2

Subject to
  No constraints

  Integer variables (4)
    fro_mean_0_0   # no lower bound and no upper bound displayed.
    fro_mean_0_1
    fro_mean_1_0
    fro_mean_1_1

num variables of qubo: 272

Ok, I understand, thank you for your answer.


custom checks: allow submatch in map/object attributes

currently, subMatches are only allowed for blocks, but it'll also be useful to be able to perform subMatches in attributes that are maps or objects.

looks like this has been done


Task map validation

While drawing a new connection:

tasks that can not be connected to are grayed out
handles that can accept the connection are highlighted

While dragging task from synergy group to another, unavailable groups are grayed out.
On the server side, the graph is validated each time new relations are added.
Deleting relations will never invalidate the graph.

You can currently drag relations to tasks that are in the same group

The backend correctly rejects this for me, so I couldn't reproduce this.
But sure the frontend shouldn't even try sending that request, I'll fix that.

The backend correctly rejects this for me

Ah, I probably had old server up from some other branch

Should be fixed now.
The state was clearing between the connection ending and validation, which would suggest that there are some unnecessary rendering happening. But that should no longer affect the correctness.


Performance testing for add_method_tracer changes

Run performance tests on the changes in add_method_tracer and track changes and improve as we can.

Here are the benchmark results for a performance test relevant to the method tracers rework. The test itself adds a method tracer to an empty method, then calls that method an arbitrarily large number of times (10k in this case). These are the results over 1k iterations of that test.
# dev

% script/runner -T TransactionTracingPerfTests#test_long_transactions -N 1000
1 tests, 0 failures, 759.035805 s total

TransactionTracingPerfTests#test_long_transactions: 1.781 ips (561.42 ms / iteration)
    cpu_time_user: 542.711 (0.54 / iter)
  cpu_time_system: 16.6043 (0.02 / iter)
       iterations:    1000

# method_tracer_prepend

% script/runner -T TransactionTracingPerfTests#test_long_transactions -N 1000
1 tests, 0 failures, 30508.917091 s total

TransactionTracingPerfTests#test_long_transactions: 1.211 ips (825.77 ms / iteration)
    cpu_time_user: 797.335 (0.80 / iter)
  cpu_time_system: 25.1792 (0.03 / iter)
       iterations:    1000

The difference in each iteration is roughly 0.25 seconds. That accounts for 10k invocations of the traced method, so the actual overhead of calling the method is much smaller. Of course this is important if a customer’s traced method is being called many times.
Also bear in mind that our test methods here don’t actually do anything, so these numbers reflect only the overhead of calling the traced method. It’s arguably reasonable to assume that traced methods in the wild are not computationally trivial.


[REFRACTOR] Why keep 2 cuda kernels?

We need to investigate if there it makes sense to keep 2 cuda kernels, old vs new.

We will remove both cuda kernels. They are way slower than exllama in 4bit. This will result in only 4bit support in quantization in exllama/v2 but this is by far 99.9% of the usage case.


A client can easily overwhelm the servers memory by constantly sending to a broadcast hub method

We currently fire-and-forget hub invocations
https://github.com/aspnet/SignalR/blob/9a0c190f487b9f48eaaa83fb4f3c1675ee21bdc0/src/Microsoft.AspNetCore.SignalR.Core/HubConnectionHandler.cs#L187
This can cause high lock contention and quickly grow the servers memory when many invocations are trying to write to the same connection. A quick test where we await the invocations shows stable low memory without affecting RPS in the load test that found this.
Server Hub
public class BroadcastHub : Hub
{
    public Task Broadcast(string message)
    {
        return Clients.All.SendAsync(message);
    }
}

Client
while (true)
{
    hubConnection.SendAsync("Broadcast", "flood server");
}

Approved.


Side-effecting parameterless methods should have parentheses.

Priority: LOW
There are parameterless methods that are defined (and called) without parentheses. While having non-parenthesis accessory methods is fine, it's considered good style to include empty parentheses for side-effecting function.
Example of side-effecting but parameterless method is CasperSdk.getStatus  - it's performing a blocking call to node's RPC.

parenthesis added


All properties even thus that are not selected are including when building or saveing an index in version 14

When building an index against version 14 all properties are included, even thus that have select = false. Have found out that it's due to the changes in the datamodel. One solution is to add check if selected are true when calling ContentRecordBuilder
var contentRecordBuilder = new ContentRecordBuilder(
		userService,
		urlProvider,
		algoliaSearchPropertyIndexValueFactory,
		recordBuilderFactory,
		umbracoContextFactory,
		algoliaGeolocationProvider)
	.BuildFromContent(contentItem, (p) => contentDataItem.Properties.Any(q => q.Alias == p.Alias && q.Selected));

If I try to index a property of type BlockGrid or BlockList, I get system error.

This item has been added to our backlog AB#45267

Hi @evaHopNltg ,
Thank you for bringing this to our attention. I have fixed the issue in the latest minor release of Algolia - 3.2.0
Regards,
Adrian


Vue is not bundled when required by UMD lib on the client side.

Version
v2.8.1
Reproduction link
https://github.com/Fnxxxxo/nuxt-client-import-issue.git
Steps to reproduce
yarn install && yarn start

Then check console logs.
What is expected ?
Component is rendered with no errors.
What is actually happening?
Server-side renders correctly. Client-side fails with calling extend of undefined.
Additional comments?
The same demo works in the raw Vue-cli project.

This bug report is available on Nuxt community (#c9536)

@Fnxxxxo Could you provide me the vue-cli repo which works fine ?

@clarkdo Hi. I update the reproduction repo with a successful Vue-cli demo. Just yarn install and yarn serve

Please try, webpack resolves symlinks as relative path instead of node_module path:
  build: {
    /*
    ** You can extend webpack config here
    */
    extend(config) {
      config.resolve.symlinks = false;
    }
  }


feat: fixes logos for use-cases

Preview

@xmulligan Hello! Please take a look and merge.

Thanks!


Toyota Camry XLE switching from TSS to OP Longitudinal and back

Running C2 in a Toyota Camry Hybrid XLE.  Tested Openpilot versions 0.7.10 - 0.8.1.
On fresh boot of the C2, Openpilot runs great, everything stable.  However, if I park the vehicle and turn off the engine for a short stop (to fill up on gas, buy coffee, etc), Once I start the engine (C2 wakes up) the following happens:

Openpilot displays an arrow on the screen pointing to the lead car
The car subtly accelerates and decelerates in quick cycles.  It sort of feels like I’m towing something.
If lead car slows / stops, Openpilot is slow to see it and slow/stop.  I've had close calls where I've had to slam on brakes.
If I force reboot the C2, it resumes normal operation.  Everything is perfect again.
Alternatively, if I make a second short stop where I turn off the engine for a few minutes, when I turn the engine back on, the arrow indicating lead car is gone and all is normal

I've tried checking all connections, tried a new usb cable, and tried multiple versions 0.7.10 - 0.8.1.
Dongle ID: e396297189f42a29
Car Make/Model: Toyota Camry Hybrid XLE 2018

Is your DSU unplugged or do you have a smartDSU installed?

Is your DSU unplugged or do you have a smartDSU installed?

Camry Hybrid (until 2021) is only stock ACC, openpilot can't control gas and brake in that car. This is why you're experiencing 2-3.
Any feelings of different ACC performance is placebo. ( I know how wildly different it can react, had stock ACC in my parents 2018 Rav4 for a while! )
Depending on the version, openpilot would show a lead car indicator when we didn't do ACC but this should be fixed in newer releases. I'd recommend reporting that bug separately if you still see it happen.

Camry Hybrid (until 2021) is only stock ACC, openpilot can't control gas and brake in that car. This is why you're experiencing 2-3.
Any feelings of different ACC performance is placebo. ( I know how wildly different it can react, had stock ACC in my parents 2018 Rav4 for a while! )
Depending on the version, openpilot would show a lead car indicator when we didn't do ACC but this should be fixed in newer releases. I'd recommend reporting that bug separately if you still see it happen.

Reopening as the logs show that it is switching between openpilot and stock longitudinal control.

Reopening as the logs show that it is switching between openpilot and stock longitudinal control.

Is your DSU unplugged or do you have a smartDSU installed?

I have the DSU which came with my Comma2.  I also had it replaced with a new one as part of a panda failure.  Commaai sent me replacement parts for everything except the device itself.

Is your DSU unplugged or do you have a smartDSU installed?

I have the DSU which came with my Comma2.  I also had it replaced with a new one as part of a panda failure.  Commaai sent me replacement parts for everything except the device itself.

Sorry, I missed that this was a Camry, which has its DSU functionality integrated with the radar. The DSU is an ECU inside the car, not comma hardware. Do you have any other hardware (like community hardware) installed besides the comma two and included accessories?

Sorry, I missed that this was a Camry, which has its DSU functionality integrated with the radar. The DSU is an ECU inside the car, not comma hardware. Do you have any other hardware (like community hardware) installed besides the comma two and included accessories?

Sorry, I got DSU confused with OBD2.   Not sure what community hardware means.  I only have a USB cable plugged into the dash to charge my phone.

Sorry, I got DSU confused with OBD2.   Not sure what community hardware means.  I only have a USB cable plugged into the dash to charge my phone.

Should be fixed by a0a5abc7ad907f1d928f7aac9eba1d8e45154484 which will be included in the 0.8.2 release.


Support to save default value to expression

depends on vesoft-inc/nebula-common#211

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[TRI-1170] Ensure @trigger.dev/openai background tasks have retry configuration

These backgroundFetch tasks need to have their retry configuration set:

backgroundCreateCompletion
backgroundCreateChatCompletion

View the docs on backgroundFetch retry here: https://trigger.dev/docs/sdk/io/backgroundfetch
And the OpenAI error codes here: https://platform.openai.com/docs/guides/error-codes
TRI-1170

Hi @ericallam I am interested to work in this issue. can you please explain more about this?
We already passing
{         "500-599": {           strategy: "backoff",           limit: 5,           minTimeoutInMs: 1000,           maxTimeoutInMs: 30000,           factor: 1.8,           randomize: true,         },         "429": {           strategy: "backoff",           limit: 10,           minTimeoutInMs: 1000,           maxTimeoutInMs: 60000,           factor: 2,           randomize: true,         }, in  backgroundCreateChatCompletion method but not in backgroundCreateCompletion .
If you could provide some clarification, it would be more helpful !!

Oh yea I think we just need to copy that retry config over to backgroundCreateCompletion then 👍

OK thanks, I will work on it.

@ericallam I have added the retry config in backgroundCreateCompletion method. Before raising PR I tried to test this. but facing an issue because of my openAPI API key expiration.
our web platform is encountering an issue where the correct error message is not being displayed as expected. To address this concern, I have delved deeper into the matter and am actively working on resolving it.
discussion regarding this issue in help forum https://discord.com/channels/1066956501299777596/1147568642389721159
Need your guidance, on how to proceed further !!


Add macro to define enum/JSON mapping

closes #1208

Coverage remained the same at 100.0% when pulling ad639ad5e6f0fef6ad358a7f35f5793b0baabeed on feature/enum_json_mapping into f102df3cba1036d81ef5f344ebabe5cefa797cc9 on develop.

Thanks everyone!


Disqus module show the wrong language

Hi! I use your module in my project. It nicely show the disqus comment, however the interface is always in Portugal (pretty weird), although I set the Language in my admin page is "English" and I don't bind anything to attribute [lang]. I also see your code but can not find any hard code.
Do you have any idea? Thanks and look forward to your reply!

Hello I looked at your code, it's fine! It seems to be a big bug of Disqus because the shortname they gave me link to different account. I'm trying to create a new one and use your module again. Anyway, thank you for the module!

Is it rerouting you to an account called "NaN" in Portuguese? Because then you simply have to set single quotes in your double quotes: "'shortname'" instead of "shortname"


Is this project open to contribution by outside developers (non UIUC faculty/students)?

Yes, we are open to external contributors. Please note that contributions are
subject to our license agreement, as specified in the LICENSE file.
We are currently working on a formal Contributor License Agreement (CLA) and
will inform external contributors when this will be required.
Please let us know if you have any questions.

Closing this issue. Please feel free to reopen if there are additional questions.


Modal closes instantly if open button is on the same spot as close button

It seems like there is a small input block delay missing.
I also couldnt find any options for that.
Is there any solution to this problem?

For bug reports, please include:

a jsfiddle in order for us to be able to reproduce the issue.
expected behavior of the plugin
actual behavior

JSFiddle template: https://jsfiddle.net/limon/ad3quksn/

See Contributing.md


feat(docs): Search for docs

Feature Description
Search which runs all documentation and content to find desired input
Use Case
Many times I need to use google with site param to search trought material docs and still results are not satisfying.
As an example bootstrap docs search serves lookup in titles at pages content
https://getbootstrap.com/docs/

I just noticed that this is a duplicate of https://github.com/angular/components/issues/12446. Closing.


Feature request: Automatic Conversion of Argo YAML Files to Hera Code

Is your feature request related to a problem? Please describe.
Yes, the problem is that currently, there is no straightforward way to convert Argo yaml files to Hera code. This can be a time-consuming process, especially for large or complex workflows and for those more familiar with yaml but would like to start using Hera.
Describe the solution you'd like
I would like a feature that can automatically convert Argo yaml files into equivalent Hera code. This would involve parsing the yaml file, interpreting its structure and contents, and generating corresponding Hera code that represents the same workflow.
Describe alternatives you've considered
The current alternative to this feature is to manually convert Argo yaml files to Hera code. This involves going through examples, understanding the mapping between yaml and Hera syntax, and spending hours rewriting and testing the code. However, this process is time-consuming, labor-intensive, and prone to human error. It also requires a deep understanding of both yaml and Hera, which might be a barrier for some users.
Additional context
Adding this feature would not only simplify the process of creating and managing Argo workflows but also provide the following benefits:

It would make it easier for users to transition from using pure yaml to Hera. By providing a way to automatically convert their existing Argo yaml files into Hera code, we can lower the barrier to entry and encourage more users to adopt Hera.
It would increase the speed of understanding Hera for those coming from a pure yaml implementation. By seeing how their familiar YAML workflows translate into Hera code, users can more quickly grasp the structure and syntax of Hera, accelerating their learning process.

This feature would serve as a valuable tool for onboarding new users to Hera.

Hi hera Team,
How is this ticket tracking in your priority order?
We are looking at potentially migrating to hera for describing our workflows and having a way to convert our YAML instead of implementing them from scratch would be a huge bonus.
Many thanks for giving a quick update.
Cheers & have a happy festive season :-)


Payload not working with DNS

I tried No-ip DNS too, but it didn't work.

is this working with no-ip?


synchronously get the data or null?

Did you consider providing a get(key) which would do like load(key) but instead would just pull the data out OR returns null if it's not loaded yet.
With current API we can do this
class Foo extends Component {
  state = {
    foo: null,
  };
  componentWillMount () {
    FooStore.load(1).then(foo => this.setState({ foo }));
  }
  render () {
    const {foo} = this.state;
    return !foo ?
loading...
 :
{JSON.stringify(foo)}
;
  }
}

the only downside is that there is a slight time where the component first renders "loading..." even if the data is already loaded because of the nature of Promise (always run in next tick).
Here is how we could rewrite with a get() API:
class Foo extends Component {
  state = {
    foo: FooStore.get(1),
  };
  componentWillMount () {
    FooStore.load(1).then(foo => {
      if (foo !== this.state.foo) this.setState({ foo });
    });
  }
  render () {
    const {foo} = this.state;
    return !foo ?
loading...
 :
{JSON.stringify(foo)}
;
  }
}

Yes this was considered, but decided against since it would require a dual cache: caching both the promise for a value and the value itself, and since DataLoader's primary target usage is in batching Promise-based APIs that this would be unnecessary complication and overhead.

ok yeah, I definitely understand this choice! I used to wrote some loader libs with the 2 different paradigm too (some using get. some avoiding it because the overhead you talk about).
What I experienced though is Promise only APIs tends to force you to always stay in the Promise paradigm and sometimes it's not easy to do it. especially when you want to make another other "core" libraries on top of it, if it's a promise only API, you might miss some control to do what you want (anytime you want to check things in sync, basically).
in the React example shown above, if you absolutely want to avoid the
loading...
 step, I guess you could say that the component have to be more "dump" and the data props is the already resolved/loaded one. So it means you would have to push up in the tree the responsability to load the thing, so the parent would have to wait the state for you. One problem is this breaks a bit the modularity/isolation idea (parent needs to know a bit more, than just "i give you an id prop"), but maybe that's ok in some use-cases.
I guess the ultimate solution then is to build a decorator that do this for you, a bit like Relay createContainer. It works but it's a bit more opinionated and you have to make your tree using it (like you have in Relay, to make a "Root Container" and propagate relay everywhere).

I remember one use-cases I had is to make my "super lib" that use the micro-loader-lib to exposes a isReady(): boolean predicate function – which is basically pretty useful to call from a React render().
I can't do it (easily) if the micro-loader-lib don't exposes a way to check synchronously too, it will only be able to expose a something like ready(): Promise

I guess this concern is now fixed with upcoming createFetcher :) can't wait https://youtu.be/D-h3bhzauKo?t=1h16m40s

A way to synchronously check if data is loaded or not for a particular ID is really import when testing a function and then afterwards asserting that it primed data loaders with the right data for specific IDs. In my case, I am testing that a GraphQL mutation didn't just mutate data correctly in the DB, but that it also primed data loaders correctly with the relevant data.
Right now we're doing these complicated workarounds:
import type { CacheMap } from "dataloader";
import DataLoader from "dataloader";

/**
 * Gets a {@linkcode DataLoader} instance cache map. Useful for asserting data
 * loader behavior in tests.
 */
export default function dataLoaderGetCacheMap<K, V>(
  dataLoader: DataLoader<K, V>
) {
  if (!(dataLoader instanceof DataLoader))
    throw new TypeError(
      "Argument 1 `dataLoader` must be a `DataLoader` instance."
    );

  const cacheMap =
    // Read a private instance property as there is no public API for this.
    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-explicit-any
    (dataLoader as any)._cacheMap as CacheMap<K, Promise<V>> | null;

  if (!cacheMap) throw new TypeError("Cache map missing.");

  return cacheMap;
}

Then in tests, it's used like this:
const dataLoaderCacheMap = dataLoaderGetCacheMap(theDataLoaderInstance);

deepEqual(
  await dataLoaderCacheMapComparison.get(theIdToCheck),
  {
    // Whatever…
  }
);

The problem is, because the .get call returns a promise, the test can't tell the difference between data that is currently loading or data that was correctly primed and is already cached, ready to go.

Complicated workaround to the above dilemma:
import DataLoader from "dataloader";

import dataLoaderGetCacheMap from "./dataLoaderGetCacheMap.mjs";

/**
 * Gets a {@linkcode DataLoader} instance cached value by key, without causing
 * loading.
 * @see https://github.com/graphql/dataloader/issues/28#issuecomment-1459497184
 * @returns Resolves the data loader value for the specified key if it’s cached,
 *   or else rejects with an error that the entry is missing or loading.
 */
export default async function dataLoaderGetValue<K, V>(
  dataLoader: DataLoader<K, V>,
  key: K
): Promise<V | void> {
  if (!(dataLoader instanceof DataLoader))
    throw new TypeError(
      "Argument 1 `dataLoader` must be a `DataLoader` instance."
    );

  const dataLoaderCacheMap = dataLoaderGetCacheMap(dataLoader);
  const value = dataLoaderCacheMap.get(key);

  if (!(value instanceof Promise))
    throw new TypeError(
      `Data loader key \`${String(key)}\` value isn’t cached.`
    );

  return await Promise.race([
    // This must be first in the array because when multiple racing promises are
    // settled, the earliest one in the input array wins.
    value,
    Promise.reject(
      new TypeError(`Data loader key \`${String(key)}\` value is loading.`)
    ),
  ]);
}

You use it like this in tests:
deepEqual(
  await dataLoaderGetValue(theDataLoaderInstance, theIdToCheck),
  {
    // Whatever…
  }
);

It's not sync though, and all of this complexity is something that should really be handled by the dataloader package.


Sweep: Replace first name and last name with name (✓ Sandbox Passed)

Description
This pull request replaces the firstName and lastName fields with a single name field in the Person class. It also updates the database schema and data.sql files to reflect this change. Additionally, it updates the HTML templates to use the new name field instead of firstName and lastName.
Summary

Updated Person.java:

Replaced firstName and lastName with name

Updated Owner.java:

Updated toString() method to use name instead of firstName and lastName

Updated data.sql and schema.sql:

Updated SQL queries to use name instead of firstName and lastName

Updated createOrUpdateOwnerForm.html and createOrUpdateVisitForm.html:

Updated HTML templates to use name instead of firstName and lastName

Fixes #3.

🎉 Latest improvements to Sweep:

New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To get Sweep to edit this pull request, you can:

Comment below, and Sweep can edit the entire PR
Comment on a file, Sweep will only modify the commented file
Edit the original issue to get Sweep to recreate the PR from scratch

Rollback Files For Sweep

[ ] Rollback changes to  src/main/resources/db/postgres/data.sql
[ ] Rollback changes to  src/main/java/org/springframework/samples/petclinic/model/Person.java
[ ] Rollback changes to  src/main/java/org/springframework/samples/petclinic/owner/Owner.java
[ ] Rollback changes to  src/main/resources/templates/pets/createOrUpdateVisitForm.html
[ ] Rollback changes to  src/main/resources/db/h2/data.sql
[ ] Rollback changes to  src/main/resources/templates/owners/createOrUpdateOwnerForm.html
[ ] Rollback changes to  src/main/resources/db/h2/schema.sql

This is an automated message generated by Sweep AI.

Apply Sweep Rules to your PR?

[ ] Apply:  All new business logic should have corresponding unit tests.
[ ] Apply:  Refactor large functions to be more modular.
[ ] Apply:  Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

not needed


Editor 6 OS X — Table Headers Not Working

If I create a table in either of the following formats:
[cols="2*", options="header"]
|===
|Name of Column 1
|Name of Column 2

|Cell in column 1, row 1
|Cell in column 2, row 1

|Cell in column 1, row 2
|Cell in column 2, row 2
|===

|===
|Name of Column 1 |Name of Column 2

|Cell in column 1, row 1
|Cell in column 2, row 1

|Cell in column 1, row 2
|Cell in column 2, row 2

|===

(from the asciidoctor documentation), the table header is incorrectly drawn:

Same as #80, it'll be fixed in the upcoming release.


frederik-usecases-and-homeview

This is a large pull request. The HomeView for Students has been finished, and the functionalities to log out, change to the profile view, as well as like/ dislike posts has been added.
By Frederik Brecht

Good work Fred! I like the new views with the entire main page scrolling. One thing, I have migrated over the data structures from the old code over to a custom DataStore type we will need to work on making those changes to use the new data structures instead.

One more comment Fred, we might need another navigator button that brings us to a view that holds all the clubs so the user can scan through them one by one, similar to like an "explore" page that show cases all the clubs.


feat : Create Custom modal and Stepper

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

@Rexford74  the modal header and footer background , icon , text colors need proper tokens .

I'm scheduled to have a meeting with @sudhanshutech later today. We'll sort this out then. Thanks for your patience.


JSON attributes with non-primative values are not de-serialized properly

This is an issue affecting <google-map>
In the following example, additionalMapOptions will not be de-serialized into a JSON object because of the value google.maps.ControlPosition.TOP_RIGHT. If you substitute a Number val (e.g. 3). It works.
<google-map additional-map-options='{"zoomControlOptions": {"position": google.maps.ControlPosition.TOP_RIGHT}}'>

Technically, JSON.parse('{"zoomControlOptions":{"position":google.maps.ControlPosition.TOP_RIGHT}}') throws an error in JSON.parse. Not sure what we want to do about this.

Feel free to close if there's nothing we can do.

Does it not work if it's quoted? To be valid JSON it'd have to be:
"position": "google.maps.ControlPosition.TOP_RIGHT"

In the maps api, google.maps.ControlPosition.TOP_RIGHT resolves to an enum value. A string is valid JSON  but wouldn't set position correctly.

Wouldn't the provided JSON have to use the enum's value? If we have to look up variable values from the runtime, that isn't JSON anymore, but something that needs to use eval.

I do encounter this a lot using polymer and in nodejs and have to comply with valid json and store the dotted path to an object reference as a string. For most cases, using a common behavior function (similar to the below) in a computed property function works out well for me.
pathToReference: function (obj, dottedPath) {
                try {
                    return dottedPath.split(".").reduce(function (o, x) {
                        return o[x]
                    }, obj);
                } catch (excep) {
                    return null;
                }
}

Be interested to know alternatives.


WebSocket server accept handshake without Subprotocols

Expected behavior
When client sends a WebSocket handshake request with subprotocols to negotiate, if server does not support any subprotocol (subprotocols = null) server should close the connection since even though client asks for subprotocols server does not have any subprocol to negotiate. Please check RFC6455 Section 1.9. If server support subprotocols then after selecting a subprotocol server should send that subprotcol with |Sec-WebSocket-Protocol| header.
Actual behavior
If the server has subprotocols to negotiate it sends the selected subprotocol with |Sec-WebSocket-Protocol| header. But if server subprotocols are null server accept the handshake anyway and send the response without |Sec-WebSocket-Protocol| header.
Steps to reproduce

Use netty WebSocket server example.
Use netty WebSocket client sample and change the handshaker subprotocols to some string (without making it null).
Try to connect and check request and response headers.

Minimal yet complete reproducer code
In WebSocketClient.class
change the code
final WebSocketClientHandler handler =                     new WebSocketClientHandler(                             WebSocketClientHandshakerFactory.newHandshaker(                                     uri, WebSocketVersion.V13, "xml, json", true, new DefaultHttpHeaders()));
Netty version
4.1.7.Final
JVM version
java -version - 1.8
OS version
Ubuntu 16.0

Your decision is correct. Sorry for interrupting. That is how the Server should work.


[BUG] Saving repeat prefs in FinWin27

I don't know if this is a PDK Framework bug or a Finale bug. I'm running Finale 27.3.

Open a new default document
Run the following Lua scriptlocal prefs = finale.FCRepeatPrefs()
prefs:Load(1)
prefs:SetDotAfterNumber(false)
prefs:Save()

Select the SmartShape tool
Go to SmartShape Options
In the Symbols dropdown, select Trill
Click the "Select..." button
CRASH

Using "Save Document Options as JSON" (after step 2), I can see that the values for several of the SmartShape symbols have been changed to impossible values, even though the code that was run didn't touch those preferences (in FCMusicCharacterPrefs).
# These two are okay
"SymbolOctave": 58641,
"SymbolOctaveBass": 58642,
# These four are not
"SymbolTrill":<PHONE_NUMBER>,
"SymbolTwoOctaves":<PHONE_NUMBER>,
"SymbolTwoOctavesBass":<PHONE_NUMBER>,
"SymbolWiggle":<PHONE_NUMBER>,

I have no idea whether there are other PDK settings that trigger unintended effects; I happened to notice this while importing my house style into a default doc with my "Import Document Options from JSON" script, and then I narrowed the issue down (in my case) to this single setting. Based on the particular values, I feel like this might have something to do with a uint32 overflow, but I have no idea why this repeat setting would affect these four music character settings.
@rpatters1 Are you able to see what's going on here, and to determine whether it's a PDK issue or a Finale issue?

Note: This doesn't happen in Fin26, and I haven't tested yet in Fin27 with a non-SMuFL template.

I have a strong suspicion what's going on. It's difficult to assign blame, but it is certain that if it is going to be fixed it will be fixed in the PDK. I fixed several of these that Jan Angermüller found, but apparently that one slipped by.
If it's what I think it is, you need a minimum of F26.3 and SMuFL (which effectively means F27). If you discover any others, let me know.

For background:
Finale 26.2 included a complete rewrite of document preferences, including how they are accessed through the PDK. This introduced two major breaking changes in Finale:

All plugins that referenced document settings would have to be recompiled (and rewritten) to use the new data structures.
All library files of document settings (think house style libraries) would no longer be usable. They would have to be re-created in F26.2.

This impacted JW plugins in a major way, because by then they had gone out of support by Jari. The other 3rd party plugins made the switch. That's why I create 2 binaries for my plugins: one for F26.2+ and one for F25.4-F26.1. (Let's forget about F25-F25.3: that was another issue.)
Late in the dev cycle they apparently realized these breaking changes were not acceptable. They came up with a compatibility layer for pre-F26.2 libraries that was able to be extended to plugins. The problem is that it is not 100% compatible, especially if your code changes the settings.
Because RGP Lua is a single binary that supports all 64-bit versions, I have only converted it to the new access as needed. (It's a significant job even for one class.) So I will be converting FCRepeatPrefs to the new way as part of 0.67.
FWIW: Jan alerted me to a similar problem with FCTupletPrefs that trashed exactly the same character settings as this one does.
Finally, I encourage you to try out the Enigma Text Dump plugin. It dumps the raw Enigma data into a text file and lets you do A/B comparisons before and after changes. It also includes hints into the PDK Framework where possible. You might have found it useful in debugging this issue. For using the PDK, it is absolutely indispensable. The format is similar the old portable enigma format that existed before F2006.

Thanks very much, Robert!

This will be fixed in 0.67, so I'm closing it now.

I also added ShowOnTopStaffOnly and ShowOnStaffListID properties to FCRepeatPrefs. I'm not sure if these were available elsewhere, but they will be available on FCRepeatPrefs starting with 0.67.


Deploy hooks don't inform of failed deploys

From @mhulscher on January 19, 2017 15:1
The controller posts a callback as soon as a request comes in. However, a failed deploy, which does a rollback to the previous release, is not posted. This can cause confusion. Is this something that would be within the scope of the deployment hooks?
Copied from original issue: deis/controller#1209

From @bacongobbler on January 19, 2017 15:10
Sure! If you feel like taking a crack at this, the code lives here.


docs: added shell flag description to readme

Added documentation line in readme about the shell flag that allows defining the shell binary to use.

Thanks again!


Poincare plot crashes engine

Describe the bug

Open globe.silo (it has a vector field vel in it which circulates around z axis)
Put up Pseudocolor->Operators->Poinecare-vel
Set Poincare attributes to...

Source: Line type
Start Point: -10 0 0
End Point: 10 0 0
Point density: 5 (I have know idea what density means here 5 points per what, unit,

hit Draw

It never completes and eventually crashes engine.
I an naive to Poincare plots and could easily be allowing parameters that don't make sense. That said, it would be best if we didn't have plots with mostly default settings crash the engine.
Expected behavior
I think we should be able to avoid ever crashing the engine.
Desktop

OS and version: macOS 10.14
VisIt Version: 3.2.1

The engine_ser process seems to slowly grow in memory, maybe 1Mb every 5-10 seconds (that is really, really, really slow!!! memory growth). But I suspect it never stops.

I am attaching a spindump from macOS activity monitor if it is helpful.  @ARSanderson would you have any insight here?
Spindump.txt.gz

@ARSanderson I tried some plot attributes that better match the dataset...

Start: -5 -1.5 7
End: 5 -1.5 7
Source: LineType
Point density: 10
Integration: 0.1 and 0.01  (second option took way longer but both yield empty plot...not what I expected)

Also, I tried changing integrator to first option (Forward Euler (Single-step)) and when I selected that, it blew away all my previous settings. I was expecting it to be able to change integrator but perform essentially the same operation with the new integrator. This is a GUI issue and not as important but its just something I happened to notice.

I did some investigation but just tried to create an integral curve. I get a hard crash in the avtCellLocator::CopyCell. The cellPtr vtkCellArrayIterator seems bad but I am not sure why. I have rewritten it so to use vtkCellArray and it now works as expected. The Poincare plot now "works" but does produce anything as the data is truly periodic (uninteresting case). Was slightly surprised that doing the punctures only did not produce a series of points.


Grafana dashboards

/azp run

@rafzei I ran into issues while testing offline mode. Installation fails on task repository : Create epirepo repository.
Ubuntu:
ubuntu@ip-10-1-11-94:~$ sudo /tmp/epi-repository-setup-scripts/create-repository.sh /var/www/html/epirepo true
Package libdpkg-perl not found, installing...
dpkg: error: cannot access archive '/var/www/html/epirepo/packages/libdpkg-perl*.deb': No such file or directory

ubuntu@ip-10-1-11-94:~$ ls -lah /var/www/html/epirepo/packages/libdpkg-perl*.deb
-rw-r--r-- 1 root root 207K Jun 24 19:51 /var/www/html/epirepo/packages/libdpkg-perl_<IP_ADDRESS>ubuntu2.3_all.deb

RHEL:
[ec2-user@ip-10-1-11-146 ~]$ sudo /tmp/epi-repository-setup-scripts/create-repository.sh /var/www/html/epirepo true
Failed to set locale, defaulting to C
Loaded plugins: amazon-id, search-disabled-repos
Cannot open: /var/www/html/epirepo/packages/repo-prereqs/apr-1.4.8-7.el7.x86_64.rpm
/var/www/html/epirepo/packages/repo-prereqs/apr-util-1.5.2-6.el7.x86_64.rpm
/var/www/html/epirepo/packages/repo-prereqs/createrepo-0.9.9-28.el7.noarch.rpm
/var/www/html/epirepo/packages/repo-prereqs/deltarpm-3.6-3.el7.x86_64.rpm
/var/www/html/epirepo/packages/repo-prereqs/httpd-2.4.6-97.el7_9.x86_64.rpm
/var/www/html/epirepo/packages/repo-prereqs/httpd-tools-2.4.6-97.el7_9.x86_64.rpm
/var/www/html/epirepo/packages/repo-prereqs/mailcap-2.1.41-2.el7.noarch.rpm
/var/www/html/epirepo/packages/repo-prereqs/mod_ssl-2.4.6-97.el7_9.x86_64.rpm
/var/www/html/epirepo/packages/repo-prereqs/python-chardet-2.2.1-3.el7.noarch.rpm
/var/www/html/epirepo/packages/repo-prereqs/python-deltarpm-3.6-3.el7.x86_64.rpm
/var/www/html/epirepo/packages/repo-prereqs/python-kitchen-1.1.1-5.el7.noarch.rpm
/var/www/html/epirepo/packages/repo-prereqs/redhat-logos-70.7.0-1.el7.noarch.rpm
/var/www/html/epirepo/packages/repo-prereqs/yum-utils-1.1.31-54.el7_8.noarch.rpm. Skipping.
Nothing to do
Failed to start httpd.service: Unit not found.

Seems to be something related to this PR as I tested offline mode on another PR before and there was no problem.

/azp run

/azp run


Make the ABY class two hosts

ABY is a two party protocol, but protocols.ABY was taking a set of hosts. We never check that these sets have size 2, and indeed, there were incorrect selections. I made ABY a two party protocol, and added a bogus MPC protocol so some of the benchmarks that have three hosts would compile.
Note, this slows down tests by 27% since selection gets more complicated. I made it so that MPC is only selected with three or more hosts, but the slowdown didn't completely go away. This doesn't make sense to me since MPC should be irrelevant for most of our examples.

Why not just change the benchmarks so they only have two hosts instead of adding a fake MPC protocol

Why not just change the benchmarks so they only have two hosts instead of adding a fake MPC protocol

Some of these have multiple parties pretty ingrained in them. E.g.,
https://github.com/apl-cornell/viaduct/blob/master/compiler/examples/benchmarks/filtered_sum.via
https://github.com/apl-cornell/viaduct/blob/master/compiler/examples/benchmarks/four_square_sum.via
https://github.com/apl-cornell/viaduct/blob/master/compiler/examples/benchmarks/purchase.via
What should I do with these?

just move them to the docs folder for now


bump mstpd version to 0.1.0+bisdn2 (dropped python2 for debian build)

Signed-off-by: Jan Klare<EMAIL_ADDRESS>

Looks mostly good, but please change the commit subject to "mstpd: bump ..."


@W-11102262: grpc stream support

Please make sure all new dependencies added are apache licensed and no vulnerabilities.

Please add unit tests


Add support for Iterable

The Collection interface is already supported. Similar support needed for the Itarable interface as well.

Thank you for fixing the javadoc :)

I will trigger a minor release now

And thanks for moving some code to java 8 :)
It's still something i need to do

@tobiasstamann By the way, do you/the project have/has any code style preference?  I usually use IDEA, so getting a code-style XML to apply would be beautiful.

I am using IDEA as well, even if it doesn't work with those annotation processor projects that well.
Mostly using the default code style scheme, but could explicitly add one to the project.
Your change has been released now with version 0.23.0.


1.2.2 Dependency problem - BLEDevice.h

Hey, are all dependencies included in the last release? I am not able to compile the application.
I am using esphome integration in hassio.
Error:
INFO Reading configuration /config/esphome/desk.yaml...
INFO Generating C++ source...
INFO Compiling app...
Processing desk (board: esp32dev; framework: arduino; platform: platformio/espressif32 @ 3.3.2)
--------------------------------------------------------------------------------
HARDWARE: ESP32 240MHz, 320KB RAM, 4MB Flash
Dependency Graph
|-- <AsyncTCP-esphome> 1.2.2
|-- <WiFi> 1.0
|-- <FS> 1.0
|-- <Update> 1.0
|-- <ESPAsyncWebServer-esphome> 2.1.0
|   |-- <AsyncTCP-esphome> 1.2.2
|-- <DNSServer> 1.1.0
|-- <ESPmDNS> 1.0
Compiling /data/desk/.pioenvs/desk/src/esphome/components/idasen_desk_controller/idasen_desk_controller.cpp.o
In file included from src/esphome/components/idasen_desk_controller/idasen_desk_controller.cpp:1:0:
src/esphome/components/idasen_desk_controller/idasen_desk_controller.h:7:23: fatal error: BLEDevice.h: No such file or directory

*******************************************************************
* Looking for BLEDevice.h dependency? Check our library registry!
*
* CLI  > platformio lib search "header:BLEDevice.h"
* Web  > https://platformio.org/lib/search?query=header:BLEDevice.h
*
*******************************************************************

compilation terminated.
*** [/data/desk/.pioenvs/desk/src/esphome/components/idasen_desk_controller/idasen_desk_controller.cpp.o] Error 1
========================== [FAILED] Took 2.66 seconds ==========================

my config:
esphome:
  name: desk
  platform: ESP32
  board: esp32dev

# Enable logging
logger:

# Enable Home Assistant API
api:

ota:
  password: ""

wifi:
  ssid: ""
  password: ""

  # Enable fallback hotspot (captive portal) in case wifi connection fails
  ap:
    ssid: "Desk Fallback Hotspot"
    password: ""

captive_portal:

external_components:
  - source<EMAIL_ADDRESS>
idasen_desk_controller:
    # Desk controller bluetooth mac address
    # -----------
    # Required
    mac_address: "C8:2C:49:BC:C0:57"
    # Use bluetooth callback to update sensors and cover entities
    # Deactivate this option when data are not correctly updated when using the cover entity
    # -----------
    # Optionnal (default true)
    bluetooth_callback: false

cover:
  - platform: idasen_desk_controller
    name: "Desk"

Hi @darkkatarsis
I had the same problem and found an important information in the history of the README file. You have to add the missing library in the esphome section of the configuration file. So in your case it should look like this:
esphome:
  name: desk
  platform: ESP32
  board: esp32dev
  libraries:
    - "ESP32 BLE Arduino"

[...]

I hope this helps you.

Works now, thank you


nvme_ctrlr: make configure_aer failing a warning.

The spec generally requires this feature, but some emulated hardware (e.g. QEMU) does not support it. SPDK seems to just ignore the error and continue on with a warning, so let's do the same here.
This fix comes originally from Haiku (commit: https://github.com/haiku/haiku/commit/8bb337b5fe7269387cd381652c9cbf254fcfdda5), where we've made libnvme the basis for our kernel-space NVMe driver.
There are some other fixes I'd like to upstream after this (e.g. making the main header includeable as C++) as well as some other changes you may be less amenable too (e.g. moving PCI device detection into a sort of abstraction layer, to hook into our kernel APIs instead of libpciaccess), and some other changes I've not yet started (e.g. doing more locking inside libnvme so all calls are threadsafe).

Applied. Thanks !


i see % on terminal after instlling zsh

I cannot see the theme getting reflected on my terminal even after installing zsh on mac.
I have also added ZSH_THEME to ~/.zshrc file. I see % symbol on terminal. Below is the screen shot. I have followed the document and followed the procedure.

It's probable ZSH_THEME is defined after OMZ sourced. Post your zshrc file please.

You didn't install ohmyzsh or you're not using it in your zshrc file. Read the installation guide from the README.


Datapath_tcp Flags Bug Fix Test

Just a single test case with random tcp flags

Codecov Report

Merging #295 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   52.96%   52.88%   -0.08%
==========================================
  Files          40       41       +1
  Lines        4407     4604     +197
==========================================
+ Hits         2334     2435     +101
- Misses       1878     1973      +95
- Partials      195      196       +1

Impacted Files
Coverage Δ

enforcer/utils/packetgen/packet_templates.go
100% <ø> (ø)

enforcer/utils/packetgen/packet_gen.go
0% <0%> (ø)
:arrow_up:

enforcer/datapath.go
71.03% <0%> (+2.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62947b3...292f6ae. Read the comment docs.

Can we retest this one so that we can merge. These are valuable tests.


Add repo dispatch script

Adds a PowerShell and *nix shell script to easily send a repo dispatch event to trigger azops-pull

Infers github repo details from cwd
Gets creds from ~/.git-credentials if it exists, else can supply using parameters

PowerShell script now added

@matt-FFFFFF  - we have renamed  trigger to make it more explicit. Please update accordingly.
We also have GH CLI as preferred option, do we need this and want to maintain on long term basis?

Personally I think these scripts belong in the Enterprise-Scale repo, that way they are available to customers when they use the template. However I was told to put them here when I raised the original PR on E-S.
Using gh cli is ok, but you need to have it installed, etc. Also, the command is still more complex IMHO.
I really wrote these to make it easier for customers to perform the repo dispatch.

@matt-FFFFFF we just added support for the new github actions workflow_dispatch feature with https://github.com/Azure/Enterprise-Scale/pull/60. Does this fulfill the 'easy to trigger' criteria or do you still see that we need to maintain a script in addition to the GH CLI option?

The workflow dispatch looks perfect. No need for a script any more :)
Thanks for the great work!
Matt

From: Johan Dahlbom<EMAIL_ADDRESS>Sent: Tuesday, July 7, 2020 6:32:02 PM
To: Azure/AzOps<EMAIL_ADDRESS>Cc: Matt White<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/AzOps] Add repo dispatch script (#5)
@matt-FFFFFFhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmatt-FFFFFF&data=02|01|matt.white%40microsoft.com|1f6379d2eb6a4e529a9308d8229ba977|72f988bf86f141af91ab2d7cd011db47|1|0|637297399244501195&sdata=fnNJayK6Fhc0KN5y5nh9Q%2FRlQOmVr6FTx4T7%2FAIMGpc%3D&reserved=0 we just added support for the new github actions workflow_dispatch feature with Azure/Enterprise-Scale#60https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FEnterprise-Scale%2Fpull%2F60&data=02|01|matt.white%40microsoft.com|1f6379d2eb6a4e529a9308d8229ba977|72f988bf86f141af91ab2d7cd011db47|1|0|637297399244511139&sdata=j%2FelA5sMMUe3Z5vc3WaVcneKjxSdVIr%2FryO0jJtcunk%3D&reserved=0. Does this fulfill the 'easy to trigger' criteria or do you still see that we need to maintain a script in addition to the GH CLI option?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FAzOps%2Fpull%2F5%23issuecomment-655014406&data=02|01|matt.white%40microsoft.com|1f6379d2eb6a4e529a9308d8229ba977|72f988bf86f141af91ab2d7cd011db47|1|0|637297399244511139&sdata=noshrSwPDZlXk3tzfszlk6RGBX6I7ZXj9%2FvdQt1fXQI%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD4QREFWX4HIU33BU5FRI5TR2NLZFANCNFSM4N65PIUQ&data=02|01|matt.white%40microsoft.com|1f6379d2eb6a4e529a9308d8229ba977|72f988bf86f141af91ab2d7cd011db47|1|0|637297399244511139&sdata=4o8ZmWn%2FUlP%2Bs%2FlciEn8ArF2moOtwxOk3Qhw5QXdJPw%3D&reserved=0.

Awesome! Thanks!


[Typo] 廣拼 equivalent of 粵拼 s should be s / x instead of c / x

在./content/zh-yue-hant/blog/table.md的表格中，对应粤拼s的广拼应当是s / x，而不是c / x。请更正。

你開個PR？

Sorry I don't have time.

@ngchinghung 噉要麻煩你嚟改

I just found thiis repo and am interested in Jyutping. Can you assign this to me? I am available recently. @laubonghaudoi

搞掂


Images don't show on PDF export when using "local_secure" option

BookStack Version: 0.20.3
PHP Version: 7.1.10
MySQL Version: 5.7.20

Hi let me congratule for this excellent software.
I'm not being able to export pdf with images when using local_secure setting for images is this possible?
I seems to be working as expected if images are public, is there anything there anything i can do to enable this for secure images?
thank you

Have updated the export system to enable this, Fix will be in the next release.

Awesome, i'm happy to help.
Thank you


Update datatables per reload

save Post ID to get posts between post ID and now timestamp, to not have to update the entire table


Removing graph breaks in transforms

This issue tracks progress on graph breaks removal for the v2 transforms.
Restricting to pure tensors input (images) for now, we can figure out the TVTensors and arbitrary structures later.
Kernels
The low-levels kernels are almost all fine. Only 4 kernels are problematic.
import torch
from torchvision.transforms import v2
import torchvision.transforms.v2.functional as F

img = torch.rand(3, 256, 256)

# These kernels don't have graph breaks
# -------------------------------------
# torch.compile(F.get_dimensions_image, fullgraph=True)(img)
# torch.compile(F.get_num_channels_image, fullgraph=True)(img)
# torch.compile(F.get_size_image, fullgraph=True)(img)
# torch.compile(F.erase_image, fullgraph=True)(img, 0, 0, 10, 10, v=torch.tensor(0.5))
# torch.compile(F.adjust_brightness_image, fullgraph=True)(img, .5)
# torch.compile(F.adjust_contrast_image, fullgraph=True)(img, .5)
# torch.compile(F.adjust_gamma_image, fullgraph=True)(img, .5)
# torch.compile(F.adjust_hue_image, fullgraph=True)(img, .5)
# torch.compile(F.adjust_saturation_image, fullgraph=True)(img, .5)
# torch.compile(F.adjust_sharpness_image, fullgraph=True)(img, .5)
# torch.compile(F.autocontrast_image, fullgraph=True)(img)
# torch.compile(F.invert_image, fullgraph=True)(img)
# torch.compile(F.permute_channels_image, fullgraph=True)(img, [2, 1, 0])
# torch.compile(F.posterize_image, fullgraph=True)(img, bits=3)
# torch.compile(F.rgb_to_grayscale_image, fullgraph=True)(img)
# torch.compile(F.solarize_image, fullgraph=True)(img, .4)
# torch.compile(F.affine_image, fullgraph=True)(img, angle=20, translate=[1, 4], scale=1.3, shear=[0, 0])
# torch.compile(F.center_crop_image, fullgraph=True)(img, output_size=(223, 223))
# torch.compile(F.crop_image, fullgraph=True)(img, 0, 10, 10, 10)
# torch.compile(F.elastic_image, fullgraph=True)(img, displacement=torch.randn(1, *img.shape[-2:], 2))
# torch.compile(F.five_crop_image, fullgraph=True)(img, size=(223, 224))
# torch.compile(F.horizontal_flip_image, fullgraph=True)(img)
# torch.compile(F.pad_image, fullgraph=True)(img, [2, 2, 2, 2])
# torch.compile(F.rotate_image, fullgraph=True)(img, angle=30)
# torch.compile(F.ten_crop_image, fullgraph=True)(img, size=(223, 224))
# torch.compile(F.vertical_flip_image, fullgraph=True)(img)
# torch.compile(F.gaussian_blur_image, fullgraph=True)(img, kernel_size=3)
# torch.compile(F.normalize_image, fullgraph=True)(img, mean=0, std=1)
# torch.compile(to_dtype_image, fullgraph=True)(img, dtype=torch.uint8, scale=True)

# These ones have breaks

# torch.compile(F.perspective_image, fullgraph=False)(img, None, None, coefficients=torch.rand(8))
# torch.compile(F.resize_image, fullgraph=False)(img, size=(223, 223))
# torch.compile(F.resized_crop_image, fullgraph=False)(img, 0, 12, 10, 34, (223, 223))

# This one doesn't even compile
# torch.compile(F.equalize_image, fullgraph=False)(img)

Weird thing: resize_image and resized_crop_image both break on https://github.com/pytorch/vision/blob/68161e98aaeaeca02166063d19de92e81ea00c3b/torchvision/transforms/v2/functional/_geometry.py#L228, but when calling them both consecutively, one of them starts breaking on https://github.com/pytorch/vision/blob/68161e98aaeaeca02166063d19de92e81ea00c3b/torchvision/transforms/v2/functional/_geometry.py#L234 as well. I have no idea why.
Functionals
As @pmeier noted offline the functionals break on
https://github.com/pytorch/vision/blob/68161e98aaeaeca02166063d19de92e81ea00c3b/torchvision/transforms/v2/functional/_utils.py#L99
which, technically, can probably be avoided since the dict entry should be constant across one execution (we still need to make sure it won't affect custom kernels that users register, or whether it changes something if we eventually want to allow users to override our default kernels)
TODO: figure out whether the call to log_api_usage_once() introduces a break.
Transforms
The transforms also break where the functionals break.
On top of that the random transforms seem to break on the call to if rand() < self.p although I don't see those breaks when using TORCH_LOGS="graph_breaks", I only see them when using _dynamo.explain(). And _dynamo.explain() in turn doesn't show the graph breaks that happens on the _KERNEL_REGISTRY. :man_shrugging:
TODO: figure out which one we should trust, and also assess the rest of the transforms more systematically with a script similar to the one above.
CC @pmeier  @vfdev-5

I've run a few quick benchmarks whether or not it is useful to compile kernels in the first place. I've used a simple classification pipeline (random_resized_crop, horizontal_flip, to_dtype, normalize) and pure tensor input:
[------------------  -----------------]
                  |  eager  |  compiled
1 threads: ----------------------------
      kernel      |   279   |    225
      functional  |   280   |    328

Times are in microseconds (us).

Compiling the kernels works without graph breaks (iff we include a fix for the AVX2 graph break in resize as reported in https://github.com/pytorch/vision/issues/8056#issue-1955064062) leads to a ~20% speedup
Compiling the functionals leads to ~20% slowdown

The slowdown in the functionals stems from the graph break mentioned of _get_kernels that is the heart of our dispatch mechanism and thus present in every functional. If we hardcode the kernel, e.g.
    kernel = _get_kernel(horizontal_flip, type(inpt))
    # kernel = horizontal_flip_image

we get the following results
[------------------  -----------------]
                  |  eager  |  compiled
1 threads: ----------------------------
      kernel      |   270   |    228
      functional  |   270   |    225

Times are in microseconds (us).

Meaning, if we can somehow resolve the graph break, compiling the functionals will net us the same speedup as compiling the kernels directly. Note that this for now only applies to pure tensors and thus image only pipelines.

I'll be working on this item:

This one doesn't even compile
torch.compile(F.equalize_image, fullgraph=False)(img)

torch.compile doesn't yet handle tensor subclasses. From this error message
Argument displacement shape should be (1, 1, 4, 2), but given torch.Size([1, 17, 11, 2])

you can see that likely a tensor image made its way into a bounding box kernel.
What exactly are you testing there? That bounding box / mask inputs work properly on a compiled functional?

Well, I was running tests from https://github.com/pytorch/vision/pull/8092/ and it is partially my fault as I was running dispatched functions on tensors instead of subclasses... Now, the problem is with recursive error due tv_tensors.wrap which we can temporarily decorate to skip from compilation

There are two sources of graph breaks in the way we currently dispatch:

We use the dispatcher and the input type directly as dictionary keys:
https://github.com/pytorch/vision/blob/15c166ac127db5c8d1541b3485ef5730d34bb68a/torchvision/transforms/v2/functional/_utils.py#L15-L16
This is currently not supported by dynamo. However, there is pytorch/pytorch#111196 that opens up dictionary keys to other types than primitives as well. If that is merged, we should be able to send a small fix to allow our use case as well.

Inlining functions that use types, which is what happens when dynamo hits _get_kernel the first time, is not properly supported. I have pytorch/pytorch#113340 to address this.

Apart from that, nothing needs to change on our side. Dynamo is fine with all the other things we worried about, i.e. global dicts, MRO traversal, ... :tada:
I've reran my benchmark with fixes for the points above and this is what I got out:
[------------------  -----------------]
                  |  eager  |  compiled
1 threads: ----------------------------
      kernel      |   265   |    230
      functional  |   270   |    240

Times are in microseconds (us).

I've re-run it a couple of times and the 10µs gap between compiled kernels and functionals is reproducable. Meaning the compiled functionals don't fully get to the same level as the kernels, but they still outperform their eager counterpart.

One thing that I noticed while playing around with the benchmarks is that dynamo does not give us a strict improvement for individual ops.
random_resized_crop
[------------------  -----------------]
                  |  eager  |  compiled
1 threads: ----------------------------
      kernel      |   178   |    206
      functional  |   178   |    207

Times are in microseconds (us).

horizontal_flip
[------------------  -----------------]
                  |  eager  |  compiled
1 threads: ----------------------------
      kernel      |    22   |    36.4
      functional  |    24   |    41.7

Times are in microseconds (us).

to_dtype
[------------------  -----------------]
                  |  eager  |  compiled
1 threads: ----------------------------
      kernel      |   65.2  |    54.6
      functional  |   67.0  |    59.3

to_type and normalize
[------------------  -----------------]
                  |  eager  |  compiled
1 threads: ----------------------------
      kernel      |   170   |    61.4
      functional  |   180   |    67.5

resizing and horizontal_flip is slower in the compiled version that in eager
to_dtype is marginally faster
normalize (with prefixed to_dtype since normalize requires floating point input) is massively faster. IIUC, the high values in eager come from the fact that we are inputting an image with CHW memory layout and that hurts normalize. In the full pipeline this is mitigated by having the resize before that produces artificial HWC layout. The compiled version seems to have this natively.

Note that what's going to be great for torchvision is that I expect pretty much any combination of transformation to be fused into one kernel. There is where the main speed-ups will be coming from.
To this end, it'd be useful to try to benchmark through a list of transformation applied one after the other. As I told victor, I expect these wins to heavily overweight the slight regression in resize and flips.
On a different note, I'd expect the flip issue to be fixable.

Thanks a lot for this great investigation Philip.
@lezcano I tend to have a different intuition from yours: if resize is much faster than compiled(resize), then perhaps the speed-up gained with not compiling resize will outweight the speed-up coming from fusing resize with the op coming just before and the one coming just after (keeping the rest of the transforms compiled / fused as well). But we'll see with benchmarks. Regardless, we probably don't need to worry too much about benchmarks for now, the main goal of this issue is to remove graph breaks as a first step.

Few other findings on failing tests when ops are compiled: https://gist.github.com/vfdev-5/5b2733b5641d08c6889a17eda6267aba  (logs contain 32k lines totally, so browser may stuck for few seconds on loading...)


Adding cloud options to scan_parquet

Adding cloud features
Adding cloud options to scan_parquet
Changing scan_parquet options to match Python Polars

I have not added a S3 cloud test, b/c I am getting polars.exceptions.ComputeError: Generic S3 error: Error after 2 retries in 3.225558459s and not sure of the correct options to get it working ATM.


Validate hostedDomain when using Google OAuth2

I'm using Raneto with Google OAuth 2 authentication but I want to limit access to users from our company domain.
So, I created the config.oauth2.validateHostedDomain to define this behavior. I not sure if this is the best way to do that but solved for us.
Also, hostedDomain is not working today, as stated by #198. I changed to use the config as is in the example config and to pass on authenticate method because the strategy options are not passed to authorizationParams by passport.

👍 this works great for us.

Thank you @dettoni :)
Accepted as submitted and congratulations on your first Pull Request!


cannot extract anything useful from mesh

I'm trying to replay the raw behavior hdf5 file with demo replay script, but when running there are lots of warning messages like:
iGibson/igibson/data/ig_dataset/scene_instances/20220125-102157_1714404359879452993_83744/: cannot extract anything useful from mesh
arning[examples/SharedMemory/plugins/tinyRendererPlugin/TinyRendererVisualShapeConverter.cpp,558]: issue extracting mesh from COLLADA/STL file
I'm not sure if this is normal or there is something wrong.
btw, the demo task will eventually fail to replay.
Thanks for any help you can offer!

This happens when trying to use encrypted assets without decrypting them or vice versa.
Could you get the latest ig_dataset and check that the license is in the right folder?
Thanks


Fixes the link to the documentation current location

The documentation is currently on github.io and no longer on jboss.org. It seams that this updating the link here, has been forgotten.

Can one of the admins verify this patch?


DotNet: doc the "domain" property

Support was added in https://github.com/Esri/resource-proxy/pull/118 to allow for Windows authentication.

Both the https://github.com/Esri/resource-proxy/blob/master/DotNet/README.md and  https://github.com/Esri/resource-proxy/blob/master/DotNet/proxy.xsd needs updating as part of this issue.

protip™
it'll close issues like these automatically if you include a keyword in the initial comment of your Pull Request


hot fix - in btc actions - config not defined

Pull request template
Checklist

[ ] I have read the CONTRIBUTING guide
[ ] branch rebased on master
[ ] styleguide check npm run validate
[ ] good naming
[ ] keep simple
[ ] video or screenshot attached
[ ] testing instruction attached
[ ] check your PR once again

Description

Video or screenshot

What and how to test

После отправки бтц показывало белый экран


No Edge support

Fails with the following error
Could not complete the operation due to error c004e001.

Fixed by removing ?transport=udp from STUN server URLs, however I'm closing this as Edge doesn't support data channels over WebRTC just yet.


AVX256 instead of AVX512

I did a source build on a machine that supports AVX512. The vTune report highlights that the vectorization is good, but it still using 256 instead of 512. How to make use of AVX512 instead of AVX256 to speed up?

I usually add this piece of code to the CMakeLists.txt to make sure all optimizations are activated:
# Enable all optimization flags supported by the processor
include(CheckCXXCompilerFlag)
CHECK_CXX_COMPILER_FLAG("-march=native" COMPILER_SUPPORTS_MARCH_NATIVE)
if(COMPILER_SUPPORTS_MARCH_NATIVE)
	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=native")
endif()

I tried adding the above code snippet to CMakeLists.txt prior to source build. Still there is no change. It still using 256 bit instead of 512. I am not sure if code change will have to be made to take advantage of it.

Does this command output support for  AVX512?
gcc -march=native -v -Q --help=target

-mavx5124fmaps                        [disabled]
-mavx5124vnniw                        [disabled]
-mavx512bw                               [enabled]
-mavx512cd                               [enabled]
-mavx512dq                               [enabled]
-mavx512er                                [disabled]
-mavx512f                                  [enabled]
-mavx512ifma                            [disabled]
-mavx512pf                                [disabled]
-mavx512vbmi                           [disabled]
-mavx512vl                                [enabled]
-mavx512vpopcntdq                 [disabled]


Bug in auto correcting an exercise if the storage account is not in the same region - still present

In https://docs.microsoft.com/en-gb/learn/modules/monitor-azure-vm-using-diagnostic-data/3-exercise-create-virtual-machine
you spin up a sandbox and in it it creates a storage account in the region closest to you. But in the exercise you are tasked to spin up resources in eastus2 and after that you try to do a completion check with the built in check and it wont pass. This because the storage account with the check is not in eastus2 but in a storage account closer to you created by the sandbox. But the check is situated from eastus2.
Current: Can't complete check if not everything is in eastus2 including storage account for the cli/power shell.
Workaround: Delete storage account in the sandbox that created it for you and create a new in eastus2 and do the check then.
Expected: Change the auto check to include other regions, or make sure that the storage account is created in the expected region (in this case eastus2).
same as #87195 that got closed before it got fixed

Thanks for the feedback! We are currently investigating and will update you shortly.

@Karishma-Tiwari-MSFT How is it going with this bug?

The scope for these doc issues is to help identify gaps and issues with the Azure docs repository documentation.
For this particular issue that you have reported with the Learn module exercise, we would need to report the issue with the Learn Team here.
Please fill out this form and this will be directed to the internal team responsible for the Learn module and resolving bugs related to it.

@Karishma-Tiwari-MSFT Still not the sandbox that is the problem. Why do you guys close issues without looking at them? I told you the problem, it's stated and the test case is also stated in the description. Sending in to that adress is like sending to a blackhole that you never get any replies back from. But this is not a case of the SANDBOX but with the FUNCTION in you testing/correcting of the exercise that reside in this "document".

@zipon When you say 'this document', my understanding is you are talking about this learn exercise - https://docs.microsoft.com/en-gb/learn/modules/monitor-azure-vm-using-diagnostic-data/3-exercise-create-virtual-machine
Let me know if my understanding is incorrect. If it is correct, then the right way of getting that document updated is by filling the form I shared above.
If you think it is the learning content that needs an update, then you can select the other option as shown below and report this issue.


Update bot_support.py

Fix the extract_urls def, to extract all the URL instead of the first URL string
Example:
string: "Test this https://google.com/test/"
before: URL=https://google.com
after: URL=https://google.com/test/

Thank you for a pull request, but your decision doesn't work with Cyrillic symbols. Something like "https://мвд.рф" won't be extracted with your regular expression.

And thank you for an issue. I found my mistake in a regular expression and fix that.
https://github.com/instagrambot/instabot/commit/3a1adbce8c5def8ac21d50f1cf504089bb161aa4

Thanks bro :)


Fix intermittent failures in Configuration integration tests

Configuration integration tests have been failing intermittently. Look into why, and fix them.

After investigating, it looks like all the failures originate from our initExtensionsAndWait() timing out. I have not been able to reproduce this locally and so it is very difficult to know why it is taking so long to register the extensions. Leaving open for now until we can reproduce locally.

Reopen with a link to Circle CI failure, if the issue still happens.


target="_blank" attr unusable

Vue.js / vue-router versions
2.1.9 / 2.1.1
Reproduction Link
https://jsfiddle.net/q46wrr7x/
Steps to reproduce
Specify the target attribute on any an a or a router-link. After the app is mounted, the attributes are missing. In the Fiddle, links with the target attribute present have a green background, all other links have a red background.
What is more, the issue also affects links that are outside the actual application mounting node (see Fiddle).
As covered in #827, using the target attribute should be fixed, at least on a tags. It seems it is completely unusable at the moment.

It's working fine here.. Can you tell us about the OS/browser you're using?

@fnlctrl It seems to be an issue only when I have uBlock Origin enabled. I've closed this issue as the actual problem seems to lie somewhere else entirely.

This still occurs with uBlock Origin. Just disabled it on my localhost and target="_blank" started working.


Use ready! rustc 1.64 macro

rustc 1.64 had brought ready! macro: https://doc.rust-lang.org/stable/std/task/macro.ready.html
Use it to shorten the code slightly.

I was thinking at first the failure looked like a port already in use, but this seems new for me: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-3315/release/3903582277/index.html#suites/0fbaeb107ef328d03993d44a1fb15690/d7e5d24ebc8f1c75/
pg says:
2023-01-12 15:34:55.341 GMT [13873] LOG:  starting with zenith basebackup at LSN 0/AA31D80, prev 0/0
2023-01-12 15:34:55.341 GMT [13873] FATAL:  cannot start in read-write mode from this base backup

Haven't seen this one yet.

FATAL:  cannot start in read-write mode from this base backup

We had this issue (or better say the same symptom) before https://github.com/neondatabase/neon/issues/1351. And that time it was a problem with safekeepers

Hmm but the issue is already closed. Looking through the other log files I cannot find anything notable... Maybe I'll just create a new issue and the workflow can be retried?

Ah, should had searched, better one was found quickly: https://github.com/neondatabase/neon/issues/2963


some questions of model details

Hi，thank you for your released code，the  “HERO” is a very interesting and amazing work.
There are some questions about the model and hope for your response.

For the cross-transformer initializated by 6 layers of the pretrained roberta, why not use all the 12 layers. As far as I know, most current models are based on  pretrained bert-base or roberta-base model.
Why did you use the order of [img, txt] instead of [txt, img]?
Why did you pretrain the MLM task on the cross-transformer and mfm on the temporal-transformer？
Due to the alignment data is hard to collect, so how much influence will it have if the local alignment is removed？

Thank you very much and looking forward to your reply!

Thank you for your interests in our project and sorry about the late reply.
Please check my answers to your questions below:

For the cross-transformer initializated by 6 layers of the pretrained roberta, why not use all the 12 layers. As far as I know, most current models are based on  pretrained bert-base or roberta-base model.

We designed the model to be 6-layer to reduce GPU memory consumption during pre-training. You can modify our architecture to 12 layers for your experiments.

Why did you use the order of [img, txt] instead of [txt, img]?

We design it to be [img,txt] to make it easier for gathering img representations for Temporal Transformer inputs.  Besides, Transformers are known to be non-directional, meaning that the order of the input tokens do not matter.

Why did you pretrain the MLM task on the cross-transformer and mfm on the temporal-transformer？

As we only use contextualized image representations as inputs to temporal transformer, MLM cannot be directly applied. Therefore, we apply MLM to cross-modal transformer.

Due to the alignment data is hard to collect, so how much influence will it have if the local alignment is removed？

We did not perform ablation studies on the local alignment part. My conjecture is that it depends on the downstream task that you want to apply to. For the two VCMR tasks considered in HERO, local alignment learned during pre-training is beneficial for the moment retrieval sub-task in finetuning, and also the question localization sub-task in the two videoQA tasks.
Let me know if you have any further questions.

Closed due to inactivity.

Hi linjie,
Another quesiton:
I am interesting in the FOM task, in your code,  the "binary_targets" seems not used in this work?
Thanks,
Jinming

@linjieli222


Update Nebari logo in README

What does this implement/fix?
Small fix to how the logo is displayed in the README -- to have the black text in light mode and vice-versa. :)
How it looks with this change:

Put an x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features to not work as expected)
[x] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[ ] Did you test the pull request locally?
[ ] Did you add new tests?

Documentation

Access-centered content checklist
Text styling

[ ] The content is written with plain language (where relevant).
[ ] If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
[ ] All links describe where they link to (for example, check the Nebari website).
[ ] This content adheres to the Nebari style guides.

Non-text content

[ ] All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
[ ] If there are emojis, there are not more than three in a row.
[ ] Don't use flashing GIFs or videos.
[ ] If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Thank you @pavithraes 🌻


"Share all files" on, but still need to add a "share: true" property

Discussed in https://github.com/orgs/ObsidianPublisher/discussions/270

Originally posted by WolfieKnee January  8, 2024
Hi - I'm getting inconsistency behaviour when using the "share all files" settings in the plugin:

If I add new file to my vault and run a sync it doesn't work
if I add a share: true property it syncs fine

Am I expecting the correct behaviour or is there potentially something wrong here?
thanks*
Dave

and thanks for a great tool!

obsidian 1.5.3 on ubuntu 22.X with plugin 6.11.5

FIXED in 6.13.0
→ Version added a file stack for debugging (allow mobile debugging)
→ Bug caused by empty frontmatter and obsidian returning "undefined".

Happy to confirm this fixed issue - thanks!


Yank the URL from Function Manage tab

Unlike the one in the Develop tab, it's missing the one-click select, and the Copy button.

@christopheranderson - what should we do here?

We're going to yank the url from manage.


Nether team wins a round.

In this case as shown below both teams won flag is set to false, with no win condition. Where in the case of this round team 0 won by KilledOpponents is the expected output.
   "teams": [         {             "name": "BLUE TEAM",             "score": 3,             "won": false,             "role": "Attack"         },         {             "name": "ORANGE TEAM",             "score": 3,             "won": false,             "role": "Defense"         }
To Reproduce
Steps to reproduce the behaviour:

Get the rec files for EUL2023 stage 1 play day 6 Chalet VP vs secret round 6.
The JSON output for this round shows the above.

Expected behaviour
According to seige GG this round should be a win for secret by elimination:
https://siege.gg/matches/9109-eul-eu-team-secret-vs-virtuspro

It looks like VP won on attack by elimination. VP planted defuser after 4 kills.
Are are talking about the same file? I'm using "Match-2023-03-28_18-02-30-75-R06.rec"
The roundEnd function that calculates the winning team was never called. Currently, r6-dissect relies on the end of round replay to run the winning team logic. This should be moved to the end of the read. I can fix this today.
2:23PM DBG match_update={"message":"Friendly Fire is now active","time":"2:59","timeInSeconds":179,"type":{"id":10,"name":"Other"}}
2:23PM DBG match_update={"headshot":true,"target":"Slebben.SECRET","time":"1:49","timeInSeconds":109,"type":{"id":0,"name":"Kill"},"username":"JoyStiCK.VP"}
2:23PM DBG match_update={"headshot":true,"target":"p4sh4.VP","time":"1:47","timeInSeconds":107,"type":{"id":0,"name":"Kill"},"username":"yzn.SECRET"}
2:23PM DBG match_update={"headshot":true,"target":"Savage.SECRET","time":"1:24","timeInSeconds":84,"type":{"id":0,"name":"Kill"},"username":"dan-_-.VP"}
2:23PM DBG match_update={"headshot":false,"target":"dan-_-.VP","time":"1:19","timeInSeconds":79,"type":{"id":0,"name":"Kill"},"username":"Astro.SECRET"}
2:23PM DBG match_update={"headshot":true,"target":"Gruby.SECRET","time":"1:13","timeInSeconds":73,"type":{"id":0,"name":"Kill"},"username":"JoyStiCK.VP"}
2:23PM DBG match_update={"headshot":false,"target":"JoyStiCK.VP","time":"0:44","timeInSeconds":44,"type":{"id":0,"name":"Kill"},"username":"Astro.SECRET"}
2:23PM DBG match_update={"headshot":false,"target":"Astro.SECRET","time":"0:12","timeInSeconds":12,"type":{"id":0,"name":"Kill"},"username":"Always.VP"}
2:23PM DBG match_update={"time":"0:10","timeInSeconds":10,"type":{"id":2,"name":"DefuserPlantStart"},"username":"ShepparD.VP"}
2:23PM DBG match_update={"time":"0:03","timeInSeconds":3,"type":{"id":3,"name":"DefuserPlantComplete"},"username":"ShepparD.VP"}
2:23PM DBG match_update={"headshot":false,"target":"yzn.SECRET","time":"0:00","timeInSeconds":0,"type":{"id":0,"name":"Kill"},"username":"ShepparD.VP"}

I have not had time to test recently, but potential fixes are on the dev branch!

do you still see occurrences of this bug @James-Sergeant

one of the tests had this issue- the problem is fixed. let me know if you encounter this again


Citizen gets 'Not qualified to Vouch!'

To Reproduce
Possible steps to reproduce the behavior (TBD):

Login as a CItizen account without any 'Vouched for' accounts (or simulate the response in code)
Go to 'Explore > Vouch'

Current behavior
Observe the 'Not qualified to Vouch!' message.
Expected behavior
User is expected to see the blank state for the 'Vouched for' list
Screenshots

Platform & App Version

TBD
2.6.0 (65)

What is the status of this bug?

@RaulUrtecho Here is the source thread where the issue was reported. I was unable to reproduce and @gguijarro-c-chwy suggested this:

it should be easy to fake the return and make it empty for any account


multiline textinput view not wrapping in multiline on ios

It's because the view doesn't update itself after setText.

@facebook-github-bot shipit


Why does it act like this? The color of data-toggle, data-target and aria-expanded is not the same as for class and id in the button tag. its in black color. how to change this

Sorry, this isn't support for Bootstrap; you should ask on their repo for help.

then how can i use this data toggle in notpad++


Add support for Rails 7

add support for rails 7
bump ruby version

Thanks for this PR, @neumayr 👍
I’ve just released v0.7.0.


[feature] Allow opting out of the yarnPath for the yarn package manager

Is your feature request related to a problem? Please describe.
If our project's package manager version is managed by proto, the yarnPath config is completely useless.
In yarn 4.0, if corepack is enabled globally, yarn set version will not attempt to insert the yarnPath field into .yarnrc.yml. I believe we should do the same thing with proto managed yarn.
Describe the solution you'd like

Describe alternatives you've considered

Additional context

@latin-1 I'm not sure if we can handle this on our end? We don't explicitly set that yarnPath field. We just call yarn commands that in turn do it.

@milesj I'm not sure why moon does not use proto to manage yarn versions.
For yarn 4, yarn set version will generate yarnPath if 1. corepack is not global enabled, or 2. --no-yarn-path is specified. Yarn 2/3 will always write it.
Using yarn set verion programmingly might not be a good idea IMHO.

yarn is managed by proto via moon, but the yarn set version stuff predates it. Probably best to just remove it at this point.

Will be in 1.27


chore(main): release 0.0.10

:robot: I have created a release beep boop
0.0.10 (2024-07-12)
Features

Pull in layer related messages. (ac886e9)

Miscellaneous Chores

Prep 0.0.10 release (113e0ef)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.0.10
:sunflower:


New version: FluxCD.Flux version 2.3.0

Pull request has been created with komac v2.2.1 :rocket:

Resolves: #157331

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Add a Retina size to the favicon.

Alternatively, there's my SVG trace of the current favicon, but SVG favicons are not well supported
If you don't want to use .ico, then sending a 32px version to all clients would probably work.

In 345104b40ae41dfc031d69e74ae00bd9bad46f0a, I added a 32x32 size image. Thank you for making the SVG one. I hope to switch to SVG once that is better supported, since it's obviously the right way to handle these resolution issues.


⚠ TiendaEnLinea has degraded performance

In ec31e7b, TiendaEnLinea (https://www.fahorro.com/) experienced degraded performance:

HTTP code: 200
Response time: 6496 ms

Resolved: TiendaEnLinea performance has improved in 9f8a881.


Update CI_LINUX.yml

This is for the issue #51, don't sure if it's going to work though.

Thanks for your work.


Support "wide" characters in Input

Fix #18, fix #19.

Hi, thanks for the PR! There were a few other places which required this correction and I would like to use the pre-existing textwrap dependency (which itself uses unicode-width) rather than directly linking to it which may cause version conflict issues down the line.
Once again, thanks for taking time to contribute, but I have already written the code to fix these issues, so I will be closing this PR.


Symfony 4.1 issues

BraincraftedBootstrapBundle isn't supported in symfony 4, i tried MopaBootstrapBundle instead.
TetranzSelect2EntityBundle:Form:fields.html.twig can't be found (I just copied it then into the project)
'remote_route' seems to be ignored - ajax requests always go to the current url

I'm using https://cdnjs.cloudflare.com/ajax/libs/select2/4.0.6-rc.0/js/select2.min.js and asset('bundles/tetranzselect2entity/js/select2entity.js')

Try Webpack Encore. https://symfony.com/doc/current/frontend.html . There is no need to install this bundles at all. Just run "yarn add bootstrap" and include it in your project.
For symfony 4 correct path is @TetranzSelect2Entity/Form/fields.html.twig. But...
'remote_route' and 'remote_path' still ignored. I checked the select2 source and found that comment:
"Select2: The data-ajax-url attribute has been changed to data-ajax--url and support for the old attribute will be removed in future versions of Select2.". Themplate fields.html.twig has "'data-ajax--url':remote_path, ", but it seems that this correct part is not working. The solution was to copy fields.html.twig in project, and change "data-ajax--url" back to "data-ajax-url". Now remote_route works fine.
I'm using symfony 4.1, bootstrap 4.1.3, select2 4.0.6-rc.1 and select2-bootstrap4-theme 1.0.0

@mvjuravlev can you tell me please, which steps are necessary to get this bundle working in symfony 4 with encore? Just fighting with that for hours :(
Thank you!

Just found the problem :)
    {% block stylesheets %}
        <link href="https://cdnjs.cloudflare.com/ajax/libs/select2/4.0.2/css/select2.min.css" rel="stylesheet" />
    {% endblock %}

I missed to link the select2.css


Unexpected token; when import phaser-navmesh

Hi, I'm can't import package phaser-navmesh. I not cool expert, more information then error text from console I cannot offer.
ERROR in ./src/js/phaser-navmesh-plugin.js 1:16670
Module parse failed: Unexpected token (1:16670)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders ...FILE CODE...
Trying work with just navmesh, not for phaser, it work correcntly.

Hi @wristork, can you share a link to a minimal project setup where this error occurs?

@wristork the link does not work.
I am having similar issues and have reproduced the problem here:
https://github.com/hendrikras/phaser3-typescript-starter-kit
any help would be greatly appreciated.

I'm also running into this issue and couldn't find any solutions. I'm not used to managing my project via npm, but I compared my packages to the examples and it doesn't appear I'm missing any dependencies or anything. I haven't actually included any code yet. I've also created a temporary repository for this, but I don't want to keep it up too long.
https://github.com/kirabook/temporary-1

(Also, though this is probably a different issue, I'm also running into an error when trying to use the non-npm version.)

Hi,
The 3 libraries are built using TS "ESNext" output and the built files contain class properties declarations.
It looks like this relativly recent ES feature  is not supported on some webpack/babel setups.
I tried to add @babel/plugin-proposal-class-properties to my project without success. I'm not sure node_modules's files are processed by babel in my case.
Anyway, i solved the issue by rebuilding the library from sources, replacing tsconfig's output by "ES2021".
Hope it helps

I'm having the problem @hendrikras  mentioned as well.
@plepers Can you describe, how you built the libaries yourself?

Hi,
I am also having this issue with the latest version.
error - ./node_modules/phaser-navmesh/dist/phaser-navmesh-plugin.js 1:4581
Module parse failed: Unexpected token (1:4581)
I have tried installing a typescript and javascript project. Any help would be much appreciated.
Thanks,
BN

@brodynelson
This is what I did to build it locally:

cone navmesh repo and npm install
go to /packages and find the library you need to build. For me I want to use the phaser 3 package so it would be phaser-navmesh
inside the folder, find tsconfig.json and changed the target to ES6
go back to root and run npm run build:libs
once its done, go back to the library folder and you should find a dist folder in it. You can now import whatever is in it into your phaser project


fatal error: 'stdlib.h' file not found

I am trying to compile this project but I get this error fatal error: 'stdlib.h' file not found Can someone help me figure this out?
I am following the instructions in the readme and when I get to the step make install that is when I get the error.
I should note that I skipped the part about qcow because I don't need that.
Also I am on macOS Sierra Version 10.12.3 and go 1.8
Thanks

I figured it out. I had to run xcode-select --install

In my case IOS simulator wasn't installed.
Go to Xcode -> Preferences -> Components
Download the latest IOS Simulator.


Tooltip component final fix

Requested fixes implemented:

move example theme styles to example scss file
move tooltip target element inside Tooltip component instead of using id's

Accepted. Merging. Thanks for the hard work @Colinh84


KNX Scene component not installed in 0.63

Home Assistant release (hass --version):
0.63.0
Python release (python3 --version):
Python 3.5.3
Component/platform:
KNX Scene
Description of problem:
KNX Scene is introduced in 0.63.0 according to https://home-assistant.io/components/#version/0.63 however it wasn't installed. Looks like the scene/knx.py is missing and xknx dependencies not updated to latest version of xknx.
Expected:
KNX Scene component installed
Problem-relevant configuration.yaml entries and steps to reproduce:

Traceback (if applicable):

Additional info:

This is a documentation bug, due to a docs PR merged before the parent PR in the main repo was merged. That's still open btw.

/move to home-assistant.github.io