[operational] add a tool to validate the status of all validator set endpoints

This makes it easy to see if all nodes are actively listening on public
addresses. Add a convenience factor so that folks that don't have
storage can provide a key for validators -- it isn't super flexible but
its a solid hack.
Output:
Running `/Users/davidiw/libra/target/debug/diem-operational-tool check-validator-set-endpoints --json-server 'https://...' --role validator --key ... -- version 0'
Trying address: ...
_ -- good
Trying address: ...
_ -- good
Trying address: ...
_ -- good
Trying address: ...
_ -- good
Trying address: ...
_ -- good
Trying address: ...
_ -- good

why not support storage too? great question, I had about 1 - 2 hour(s) to write this and test it, so there were certain decisions.
Actually I think we need to re-evaluate all of our commands and if storage is optional, we should make it optional -- validator set is another good example... we only want storage so we can decrypt the validator addresses.

why not support storage too? great question, I had about 1 - 2 hour(s) to write this and test it, so there were certain decisions.
Actually I think we need to re-evaluate all of our commands and if storage is optional, we should make it optional -- validator set is another good example... we only want storage so we can decrypt the validator addresses.

wrt to testing, this is a composition of existing well tested functions, so not keen on adding an expensive smoke test.
/land

wrt to testing, this is a composition of existing well tested functions, so not keen on adding an expensive smoke test.
/land

:exclamation: Land has been canceled due to this PR being updated with new commits. Please issue another Land command if you want to requeue this PR.

:exclamation: Land has been canceled due to this PR being updated with new commits. Please issue another Land command if you want to requeue this PR.

/land

/land


Json report

Added new option json for --func_cov_report argument. Which will give a JSON file with function coverage report

If a relevant issue is there in the parent repo, tag this project there.


angular ng-click triigered 3 times, why this happens?

Environment:
Windows 7
Angular 1.3.15
Firefox 37.0.2
After I click the "Click Me" button the getMessage() is call three times, why this happens?
Here is the complete html:
<!DOCTYPE html>

    <meta charset="utf-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1" />
    <meta name="description" content="" />
    <title>Angular Sandbox</title>

{{ getMessage() }}

      <button ng-click="clickMe()" >Click Me</button>

guessing, but I'm pretty sure getMessage() is called once on startup during the first digest, and twice when the button is clicked (ng-click causes the digest, so it's called once, and then called again to make sure the value is stabilized).
It might actually be called 4 times, that would make more sense

I'm wrong, it's actually called 3 times during your initial bootstrap to make sure the model stabilizes

Your question is asking why ng-click is clicked 3 times... it's actually not... as caitp pointed out, that is the digest loop going through and checking on the return value of getMessage(). Take a look at this jsfiddle to which I added a console.log when the ng-click is actually called. It is only called once.
http://jsfiddle.net/vzd06xyq/

anyways, this is pretty much working as expected, dirtychecking will check the expression (getMessage()) multiple times to make sure the value stays the same. If that's a problem for you, consider storing the message in a value and updating the message entirely on ng-click() instead of just the count.

Thanks.


This updates Anaplan to use the latest Devkit version and allows compiling in Java 1.8

The previous devkit required compiling in Java 1.7 which is EOL.  This version updates the devkit version and other dependencies to allow compiling in Java 1.8

Looks like the Travis CI fails because it's attempting to compile in Java 1.7 which is EOL, and this connector update specifically compiles in Java 1.8


custom data training.

While training the model on custom dataset I get the following error:
Starting training
Epoch 1/100
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.5/threading.py", line 862, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/lib/python3.5/dist-packages/keras/engine/training.py", line 606, in data_generator_task
    generator_output = next(self._generator)
  File "/mnt/md0/igor/noaasl/keras-frcnn/keras_frcnn/data_generators.py", line 601, in get_anchor_gt
    all_img_data = sorted(all_img_data)
TypeError: unorderable types: dict() < dict()

Traceback (most recent call last):
  File "train_frcnn.py", line 114, in <module>
    max_q_size=1, workers=1)
  File "/usr/local/lib/python3.5/dist-packages/keras/legacy/interfaces.py", line 88, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/keras/engine/training.py", line 1852, in fit_generator
    str(generator_output))
ValueError: output of generator should be a tuple `(x, y, sample_weight)` or `(x, y)`. Found: None

>>> k.__version__
'2.0.3'
>>> tf.__version__
'1.1.0-rc2'

Thank You,
Igor

This is a python3 issue - could you try using python2?

Thank you! It did the trick.

burnmyletters,how did you solve the problem??I got the same probelm with you.

try to perform the training with python2.7

I cannot understand the effect of the function of all_img_data = sorted(all_img_data),could you solve it for me?Thank you

It ensures that data is iterated over in a deterministic manner, which is
useful for reproducible results. Feel free to change the line on your side.
On Apr 25, 2017 10:32 PM, "wanjinchang"<EMAIL_ADDRESS>wrote:

I cannot understand the effect of the function of all_img_data =
sorted(all_img_data),could you solve it for me?Thank you
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/yhenon/keras-frcnn/issues/20#issuecomment-297220219,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJe4yoH6XBjOdzyM8fHTmwb5fGYiAD8eks5rzqzJgaJpZM4NCukD
.

Thank you for your reply!!Because my environment is bulid on python3.5,which integrate keras2.0 and tensorflow,so I donnot want to used to python2.x.I try to comment the code all_img_data = sorted(all_img_data),but when I train the model,it stop at Epoch 1/100,and didnot continue!


Replace bare tilde with formula macro

This copies over the definition of @formula from StatsModels and deprecates @~ for Julia versions where ~ parses as an infix macro rather than a regular call.

Looks good! Failures due to sub -> view deprecation? https://travis-ci.org/JuliaStats/DataFrames.jl/jobs/209917401#L1184

Failures due to everything fixed by #1164.


This is messing up folder permissions.

I was unable to download Minecraft Pi (modded)'s AppImage to the ~/.local/bin folder because that folder was owned by root. Why was it owned by root? Well this folder gives a clue: ~/.local/bin/pikiss-gui It's also owned by root.
To reproduce:

First uninstall PiKISS-GUI
Remove the ~/.local/bin folder. This is important because a fresh image of RPiOS does not have this folder.
Install PiKISS-GUI and notice that it has created the ~/.local/bin/pikiss-gui folder, and the parent folder, ~/.local/bin, both being owned by root, rather than by the current $USER.

Please fix this.

Quick look revealed it's because ninja -C build install is called with sudo (https://github.com/Jai-JAP/pikiss-gui/blob/b189ad0c233604c0749301716c2be257009c594a/build.sh#L4).

@Botspot this should be fixed now. Can you try again...

Now when installing PiKISS-GUI it gives me this error:
Syncing Apps with PiKISS...

su: user /home/pi/.local/share/pikiss-gui/getapps.sh does not exist or the user entry does not contain all the required fields
while executing ['/home/pi/pikiss-gui/post_install.sh']
FAILED: meson-postinst
/usr/local/bin/meson --internal exe --unpickle /home/pi/pikiss-gui/build/meson-private/meson_exe_post_install.sh_62e6f25bcfa1881bca3f8ac30100fe386b73c23d.dat
ninja: build stopped: subcommand failed.
Failed to build PiKISS GUI

Oh.. you need to chown -R $USER:$USER ~/.local/ and then start the build

@Botspot

Same error after trying your suggestion, @Jai-JAP.
Can you try to reproduce this?

@Botspot I got a different fixed that and now no errors. tested

It works now. Thank you.


Upgrade to Windows 2016 AD with separated roles keeping IP and Name

I am studying to update my active directory from Windows 2012 to Windows 2016.
After reading articles and tech notes I have several doubts.
The FSMO roles are distributed among the 3 DCs. For migration, are the 3 new servers installed and are the corresponding roles transferred to each one?
On the DNS, if the 3 new servers have different names and IPs when transferring the DNS service, all the PCs and servers would stop responding correctly since they have the DNS manually configured to the old DCs.
What would be the correct procedure to minimize the impact of migration? Is it possible and is there a procedure to change the name and IP of the new DCs to the old ones?
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e2a85898-01c1-47ac-a186-b40237462d71
Version Independent ID: 7004b4de-2679-c668-6968-d0580e9c518e
Content: Server Role Upgrade and Migration Matrix for Windows Server 2016
Content Source: WindowsServerDocs/get-started/Server-Role-Upgradeability-Table.md
Product: windows-server-threshold
GitHub Login: @jaimeo
Microsoft Alias: jaimeo

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


Update readme file screenshots

Update the screenshots of the readme file according to the new activity bar color (see #37)

Fixes #40


[GLUTEN-6016] Allow overflow when converting decimal to int like spark

Changelog category (leave one):

Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Allow overflow when converting decimal to int like spark

LGTM


Disabled data_library when offline

Hides the data library from the interface when it is disabled (offline installations).

Mostly frontend changes, please CR (or redirect) @xavijam

👍  🎊  🎉


[Question] PDF to XML conversion timed out while timeout is set to a large number and lots of RAM is available

Experiment setup:

30,5 RAM available on ubuntu-based EC2 instance
latest GROBID dev version
memory.limit and timeout.sec are set to large values

grobid.3rdparty.pdf2xml.memory.limit.mb=29000
grobid.3rdparty.pdf2xml.timeout.sec=600

Test document.

Results:
Error encountered while requesting the server.
[TIMEOUT] PDF to XML conversion timed out

Logs are available:
grobid.log
Discussion:
It is well known that GROBID is currently designed for independent articles, chapters, short reports and this kind of short documents, not books, full proceedings or phd thesis. Even so, it stil resonable to check GROBID on  such a document while having  memory.limit and timeout.sec set to large values.
Related discussions:
https://github.com/kermitt2/grobid/issues/642
Question:
I would appreciate an idea why I am getting an error while having memory.limit and timeout.sec to be set to large values. Thank you in advance for any thoughts!

Hi @andrei-volkau !
Thank you for the very detailed issue (as always!).
Running pdfalto directly with the same parameter gives a valid conversion on my 16GB memory machine (Ubuntu 16.04) in around 16s:
lopez@work:~$ time /home/lopez/grobid/grobid-home/pdf2xml/lin-64/pdfalto_server -noImageInline -fullFontName -noLineNumbers -noImage -annotation -filesLimit  2000 ~/Downloads/test_ebook.pdf

real	0m16.935s
user	0m15.868s
sys	0m0.908s

Could you maybe run this command on the EC2 instance to see how the time/result is changing?
For me, using the GROBID service as it is and not touching the memory.limit and timeout.sec config, the conversion is complete, but then we have another "circuit breaker" (grobid.pdf.tokens.max=1000000) that stops the process due to the document size:

I am using the latest master version as you. So it seems related to the EC2 instance.

Hi @andrei-volkau !
Thank you for the very detailed issue (as always!).
Running pdfalto directly with the same parameter gives a valid conversion on my 16GB memory machine (Ubuntu 16.04) in around 16s:
lopez@work:~$ time /home/lopez/grobid/grobid-home/pdf2xml/lin-64/pdfalto_server -noImageInline -fullFontName -noLineNumbers -noImage -annotation -filesLimit  2000 ~/Downloads/test_ebook.pdf

real	0m16.935s
user	0m15.868s
sys	0m0.908s

Could you maybe run this command on the EC2 instance to see how the time/result is changing?
For me, using the GROBID service as it is and not touching the memory.limit and timeout.sec config, the conversion is complete, but then we have another "circuit breaker" (grobid.pdf.tokens.max=1000000) that stops the process due to the document size:

I am using the latest master version as you. So it seems related to the EC2 instance.

Hi Patrice! @kermitt2
Many thanks for those comments!
I am sending you the results of my evaluation.

The termination happens when at the point while 3.48 RAM used.
The termination happens in case of default settings used. It happens in exactly yhe same way in case of the following settings as well. [memory.limit and timeout.sec set to large values.]

Hi Patrice! @kermitt2
Many thanks for those comments!
I am sending you the results of my evaluation.

The termination happens when at the point while 3.48 RAM used.
The termination happens in case of default settings used. It happens in exactly yhe same way in case of the following settings as well. [memory.limit and timeout.sec set to large values.]


Mongoose Objects returning invalid json

Not sure if this is irrelevant b/c future plans to support mongoose objects https://github.com/RisingStack/graffiti-mongoose/issues/4.
But currently the string type returned is invalid json. It appears the json returned has single quotes instead of doubles.
This (invalid JSON)
{"name':'search_term','description':'Company Name: Whole Foods','_id':'564d1f91f5e4c16a32d69376'}"

Compared to this (valid):
"{"name":"search_term","description":"Company Name: Whole Foods","_id":"564d1f91f5e4c16a32d69376"}"

If you point me to the right file, I can make a PR. Also, maybe I'm being silly, but wouldn't https://github.com/RisingStack/graffiti-mongoose/issues/4. be solved just by throwing this string into a JSON.parse() function?
I can do that as well if you would like.
Best,
Jon

@jontonsoup
We use single quotes by design. Take a look at the generic type. If it were using double quotes the JSON would be broken. As far as we can trust the error messages. :)

@tothandras ah, I was unclear in my original issue. I have an array of objects as defined like this in my schema:
...
  query_arguments:
    [{name: String, description: String }],
...

The result ends up like this:
      {
        "query_arguments": [
          "{'name':'search_term','description':'Search term name','_id':'564df276b4ec3e9540b3f140'}",
          "{'name':'page','description':'Page number','_id':'564df276b4ec3e9540b3f13f'}"
        ]
      },

Which is returning invalid json.
Best,
Jon

@jontonsoup Currently graffiti-mongoose is not creating GraphQLObjectTypes for sub documents, instead it handles it as it would be a generic type. If it were using double quotes it would break the JSON ("key": "{"subkey": 1}" the 4th quote closes the value). The solution would be to create new types for objects like this.

Ah okay -- to clarify. Do you mean a new mongoose schema or a new graphql type / is there an example online somewhere?
Thanks!
Jon

The library should handle it with defining new GraphQL type. :) In the meantime you can define new mongoose schema and use object references.

@tothandras awesome! Thanks.

@tothandras would a better solution be to escape the json? This problem is giving me a huge headache in properly parsing the nested json.

@jontonsoup you can open a PR if you find a nice solution:
https://github.com/RisingStack/graffiti-mongoose/blob/master/src/type/custom/generic.js
// what you an do
const json = invalidJson.replace(/\'/g, '"');
const parsed = JSON.parse(json);

@tothandras
That has actually held me up since November, but I've been running it to silly corner cases. For example, right now the database can't have any 's because that would produce invalid json.
I'm running into a use case where I need to save ' now.

Here is an example.
{'name':'Queen Anne's Lace','value':'QUEE'}

if we escaped the values before it was sent over the wire, this could be decoded properly I think.

@jontonsoup I am really sorry! I haven't had much time for thinking about this. Can you check the linked file and the tests, you might be able to find a good solution.

@tothandras No worries! I looked into it more, and it doesn't look like that file is getting hit specifically.
model_file
 stores: [{
    options: [{
      name: {
        type: String
      },
      value: {
        type: String,
        required: true
      }
    }],
    }]

Right now the name field has the quote in it.


Add support path in tmt repository with metadata.

Default is ".", root directory

[test]

@zmiklank Can we merge it?

[test]

[test]


Minecraft Insta Crashing

When using the newest Version 2.3.2, the game starts, but insta crashes without even showing the loading screen on 1.16.1. The Version 2.3.1 works perfectly fine tho

Same for me, disabled all other mods to check if i am just stupid but it still crashes the instance with something about "fabric" in the Log

Same here, can't launch with version 2.3.2 so still dealing with the memory leak problems from previous versions.

I got the same thing, any fix yet?

the same to plentyyyy of speedrunners in CN


Hover run error

i cant run the app it produce an error .

hover: Using engine from cache
hover: Cleaning the build directory
hover: ⚠ The go-flutter project tries to stay compatible with the beta channel of Flutter.
hover: ⚠     It's advised to use the beta channel: flutter channel beta
hover: Bundling flutter app
hover: Compiling 'go-flutter' and plugins
github.com/go-gl/glfw/v3.2/glfw
In file included from ../../../go/pkg/mod/github.com/go-gl/glfw@v0.0.0-20190409004039-e6da0acd62b1/v3.2/glfw/c_glfw_linbsd.go:24:0:
<EMAIL_ADDRESS>In function ‘_glfwInitJoysticksLinux’:
../../../go/pkg/mod/github.com/go-gl/glfw@v0.0.0-20190409004039-e6da0acd62b1/v3.2/glfw/glfw/src/linux_joystick.c:224:42: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 9 [-Wformat-truncation=]
snprintf(path, sizeof(path), "%s/%s", dirname, entry->d_name);
^~~~~~~
In file included from /usr/include/stdio.h:862:0,
from /usr/include/X11/Xcursor/Xcursor.h:26,
from ../../../go/pkg/mod/github.com/go-gl/glfw@v0.0.0-20190409004039-e6da0acd62b1/v3.2/glfw/glfw/src/x11_platform.h:39,
from ../../../go/pkg/mod/github.com/go-gl/glfw@v0.0.0-20190409004039-e6da0acd62b1/v3.2/glfw/glfw/src/internal.h:169,
from ../../../go/pkg/mod/github.com/go-gl/glfw@v0.0.0-20190409004039-e6da0acd62b1/v3.2/glfw/glfw/src/x11_init.c:28,
from ../../../go/pkg/mod/github.com/go-gl/glfw@v0.0.0-20190409004039-e6da0acd62b1/v3.2/glfw/c_glfw_linbsd.go:19:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: note: ‘__builtin___snprintf_chk’ output between 12 and 267 bytes into a destination of size 20
return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
__bos (__s), __fmt, __va_arg_pack ());
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
xxxxx/xxxx/desktop-test/go/cmd
hover: Successfully compiled
hover: Build finished, starting app...
hover: Running xxxxx_xxxx in debug mode
creating glfw window: VersionUnavailable: GLX: Failed to create context: GLXBadFBConfig
hover: App 'xxxxx_xxxx' exited with error: exit status 1

#290


Difference in output given identical chain file and coordinates with pyliftover

Hi @jeremymcrae ,
Thank you for releasing this quicker version of pyliftOver.
I noticed that using the T2T -> CHR38 chain file, two different positions are given with the same chain files between liftover and pyliftover.
from liftover import ChainFile
from pyliftover import LiftOver

converter = ChainFile('chm13v2-grch38.chain.gz', 't2t', 'hg38')
print(converter['chr1'][1000000])  # outputs: [('chr1', 1573376, '+')]

converter_pyliftover = LiftOver('chm13v2-grch38.chain.gz')
print(converter_pyliftover.convert_coordinate('chr1', 1000000, '+')) # outputs: [('chr1', 1565496, '+', 255)]

What's the reason behind this behaviour, and which output is correct based on the chain file?

My code expected the alignment data lines to be tab-separated (the lines with three fields). I've updated my code to allow using spaces as the field separator, which now gives the same result as pyliftover when using your chain file. I've pushed a new version to pypi, installing that should fix the problem.
Thanks for pointing this out!


Make GetSupportedContentTypes on InputFormatter virtual

Spoke with @rynowak this was just an oversight during the previous implementation

:shipit:


Use full file path in the MztabWriter run map instead of just the file name.

The current implementation of MztabWriter on the dev_latest_depthcharge branch only uses the file name to index peak files instead of the full path. This will lead to incorrect behavior when sequencing spectra from two peak files that have different paths but have the same filename, e.g. foo/spectra.mgf and bar/spectra.mgf. This should be implemented after the depthcharge spectrum datasets are updated to include the full file path for each spectrum. This can be implemented by simply changing the following line in MztabWriter.set_ms_run:
self._run_map[Path(filename).name] = i

Related to https://github.com/wfondrie/depthcharge/issues/65


Feature signature refactor

Still doing some cleanup, but here are the basics.
Fixes https://github.com/DualSpark/rust-aws/issues/65 .

Ready for review/merge.


testsuite: Print haddock stdout/stderr on failure

This greatly helps when there are problems running haddock tests on GHC's CI because otherwise we get the very unhelpful error message:
Failed to run Haddock on test package ''

Now instead we also get the actual problem in the log:
haddock: internal error: /private/var/lib/gitlab-runner/builds/7KQsmDei/0/ghc/ghc/_build/install/lib/ghc-9.7.20230404/lib/../../../share/doc/ghc-9.7.20230404/html/libraries/array-<IP_ADDRESS>-inplace/array-<IP_ADDRESS>-inplace.conf.haddock: withBinaryFile: does not exist (No such file or directory)

Let me know if you feel it is still needed, and I'll migrate it. :)


Can't open developer tools

Does this issue occur when all extensions are disabled?: Yes/No
Yes

VS Code Version: 1.62.2
OS Version: Windows 10 Enterprise LTSB

Steps to Reproduce:

Use a portable version of vscode (Download zip file of VSCode > Create "data" directory in vscode directory)
Attempt to open developer tools
nothing happens
Same goes for process explorer, but nothing shows in the window.

I can't open developer tools too. I am using Debian. I have installed VS code from the official .deb package. But I can open process explorer.

Merging to https://github.com/microsoft/vscode/issues/122951


Add --color option with support 'always', 'never' and 'auto' values

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[x] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Description of your pull request and other information
Keeps existing --no-color option as an alias for backward compatibility.
closes #3643
TODO:

[x] add and document option
[x] add documentation to YoutubeDL
[x] add logic to set _allow_colors
[x] add depreciated warning to --no-color (only in api)
[x] add recommendation against --no-color
[x] minor changes (remove British spelling variant of option, rename use_color parameter key to color_mode)
[x] update readme

Test
test_never_color.py

[x] python test_never_color.py no warning
[x] python -m test_never_color has warning

Please feel free to review and provide suggestions even when this is a draft :grinning:

Nothing is actually implemented yes?
Document --no-color in https://github.com/yt-dlp/yt-dlp#not-recommended
The alias is unnecessary
Add stdout/stderr options to only colorize the specified stream

add depreciated warning to --no-color?

In the CLI, make --no-color set color_mode instead. In API, show deprecation warning only if both color_mode and no_color are used simultaneously

It' might require to rethink logic when setting _allow_colors, but that's ok.

I meant the colours alias

I meant the colours alias

Well, if you insist. I'll won't die defending it.
So --no-color alias of --color never can stay?

Yes

In the CLI, make --no-color set color_mode instead. In API, show deprecation warning only if both color_mode and no_color are used simultaneously

Yes

Ok, renaming use_color to color_mode won't cause issue.

Good stuff!

I agree, the British spell alias is not necessary (the computing world has settled on American spelling)
Personally, I would prefer to just name it color in contrast to color_mode, because that's what other Unix programs already engraved into peoples heads  (but I'm not making the decision)
Is both an equals sign and a space as separator between flag and value supported?
The PR contains inconsistencies, sometimes the help message recommends color='something', sometimes color_mode='something'

name it color in contrast to color_mode

Tbc, color_mode is the names of the field in params, not the option. Option is named --color (or --colour, which is to be removed).
Since other fields in api that has cli equivalent are named the same as their option, this should be considered.

Is both an equals sign and a space as separator between flag and value supported?

I'm not sure about argparse, but in optparse option value arguments are supported only with space between, afaik.

The PR contains inconsistencies, sometimes the help message recommends color='something', sometimes color_mode='something'

color_mode='something' is correct, but color='something' either needs to be --color 'something' or color_mode='something'. I'll look into it.

What's the status of this PR?


Adds try_from_json/yml_str()

Adds the the possibility of parsing a report definition by receiving the file contents directly.

Support for reading report definitions
Currently a report definition is read by providing the file path. This allows to provide the file contests directly.


Missing package dependencies for build

At least on my Ubuntu setup, I also needed to install 'automake'

You mean in the doc right?
For the package build we use autotools-dev which I guess does the trick:
https://github.com/NVIDIA/enroot/blob/102be94bbe9b93a4cd310a1b11b2a1443594b625/pkg/debbuild#L17

Yes, doc update.  I'll get around to a PR


Update to jupyter_vdi.py script

I've updated the jupyter_vdi.py script to scrape the actual port used, as jupyter will hop onto another port if the specified port was in use.
As a result I've reorganised the way the script interacted with the jupyter process. I've also suppressed some of the output as it was wrong on some instances (seems the URL had two copies of the token, dunno why).
I've also added command line parsing so I could pass in a verbose flag. Fairly minimal at this stage, but thought it was worth putting in the infrastructure. Created a main routine and separate argument parsing as it makes it easier to add testing in the future.

I'm happy to merge this as is as long as there are no objections. Haven't tested on linux though ...

Scratch that, tested ok on linux
$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04 LTS"


Some cleanup to verbose names of core models

This PR makes the wagtailcore model names easier to translate

Added verbose name to Page
All models now have verbose_name_plural
Made all verbose names lowercase

I originally started this to address https://github.com/torchbox/wagtail/pull/1613 but since that required a migration, I thought it would be worth throwing in a couple of other cleanups as well.

Pushed to Transifex


add ITDC Training

it's a training center in Tbilisi, Georgia
you can see our website here http://training.itdc.ge/

@thecotne Please email your request to<EMAIL_ADDRESS>We do not include training centers to this repository, it is for colleges and universities only. Classroom licenses are also free for students, but they receive them on the base of invitations from teachers, not on the base of having an email in a university domain. Thank you for your understanding.


Some implementations dating to OT 1.8 use a different method to resolve collisions

Suggestion -
Axis value table, format 2
Axis value table format 2 has the following structure.
AxisValueFormat2
...
The range specification of a format 2 table is inclusive: both the minimum and maximum values are included within the range. Two tables for a given axis can have ranges that touch (the rangeMaxValue of one range is the rangeMinValue of the other), but ranges should not overlap more than that.  [remove text here]
…
Remarks
Some font instances have axis values matching multiple Axis value tables.  It is outside the scope of the specification to specify axis value table matching resolution in such cases.  While implementations are free to determine how to react to such a font, it is recommended that the conflict be handled in the following manner - …[original recommendations]
Microsoft Specific Implementation
GDI and DWrite resolve competing Axis value tables in the following manner –
clampedAxisValue = max(min(instanceValue, axisMaxValue), axisMinValue)
delta = clampedAxisValue – instanceAxisValue
deltaSquare = delta * delta

// favoring cases where delta is positive.
if delta  < 0
    adjust = 1
else
    adjust = 0

// += for format 4 records, otherwise distance is just =
distance += (deltaSquare * 2) + adjust

The axis value table that has the lowest distance from the instance value is chosen.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6dac86fb-3792-6630-ade2-32bfc4bba93a
Version Independent ID: 9de5c023-f363-3e42-43c9-eac7793c8eaa
Content: STAT — Style Attributes Table (OpenType 1.9) - Typography
Content Source: typographydocs/opentype/spec/stat.md
Product: typography
GitHub Login: @PeterCon
Microsoft Alias: alib

This is a bit tricky. Apps could store font facenames in document markup. If the facenames are derived by processing STAT AVTs and the implementation changes how AVT ties are resolved, that could create doc compat problems.
At the same time, if implementations resolve ties (in part) based on the order in which AVTs are stored (e.g., in the above if two AVTs have the same distance), then font updates could result in the same problem if AVTs in a new build are not in the same order. Also, there's a potential interop issue if two implementations don't resolve ties in the same way: doc viewed in one context may display different in a different context even if the same font is available.
The STAT spec in OT 1.8 did not anticipate fonts having conflicting / competing AVTs. This gap was identified very soon, and OT 1.8.1 added specs to resolve format 2 AVTs having overlapping ranges, but it didn't go far enough—it didn't cover the case of two format 2 tables with ranges that touch (max of one is min of the other), and it didn't cover the case of a font having a format 2 AVT and also a format 1 or format 3 AVT for a point that falls within the range of the format 2 AVT. Also, it wasn't clear for some implementers whether format 2 defined ranges inclusively or exclusively (see #466). That led to revisions in OT 1.8.4 intended to resolve these issues. Of course, by then, it was over four years since OT 1.8 was released and there were multiple implementations in the marketplace.
It would have been best if the OT 1.8.4 wording had been incorporated in OT 1.8 or 1.8.1. At this point, wording could be relaxed to allow for the current situation, that there are different implementations handling these cases differently, though that would leave the door open for lack of complete interoperability between apps, fonts and documents.


Auto Trigger Buy isn't working

Version
v0.0.78 (60a464a)
raspberry pi 4
Description
Old buy orders still shows and bot not execute a new trades after sell
Expected Behaviours
Clear previews buy grids after 30 minutes
Screenshots

With the provided information, I won't be able to guess what really happened.

Have you have configured "Remove last buy price under"? Then how much you configured?
After the bot sold the coin, how much worth was left?
Have you configured 2nd sell grid trade?

From the first screenshot, I can see the last buy price is not removed after being sold.
The only reason it is not clearing the last buy price is

when the owned coin is worth more than "Remove last buy price under": https://github.com/chrisleekr/binance-trading-bot/blob/master/app/cronjob/trailingTrade/step/remove-last-buy-price.js#L275
when the owned coin is less than the minimum quantity to order: https://github.com/chrisleekr/binance-trading-bot/blob/v0.0.78/app/cronjob/trailingTrade/step/remove-last-buy-price.js#L238

i will show a different example in pictures
yes , 10USD
its wroth 0.72USD
no i don't have a second sell grid trade

Please show all configurations of that coin.
It is very hard to figure out with fragment information.
And please get the log from the bot.
Refer https://github.com/chrisleekr/binance-trading-bot/wiki/Troubleshooting#how-to-get-the-error-message
Especially, in your case, run this command:
docker logs binance-bot -f --tail=1000 | bunyan -c 'this.symbol === "AVAXUSDT"'  > error.log

Sorry, I reset the bot and am waiting for it to buy coins, I will post the results as soon as the problem recurs

didn't managed with the logs, posting new screenshots..

any idea , anyone?

Hey @eth-man
Please get the log when it happened. It will help to find out the reason.
In addition, in your slack, it should've sent many messages.
Please paste the messages that you received when it happened.

hey @chrisleekr
i'm getting a lot of this when trying to pull the logs:
at /srv/node_modules/redlock/redlock.js:431:20
at tryCatcher (/srv/node_modules/bluebird/js/release/util.js:16:23)
at Promise.errorAdapter [as _rejectionHandler0] (/srv/node_modules/bluebird/js/release/nodeify.js:35:34)
at Promise._settlePromise (/srv/node_modules/bluebird/js/release/promise.js:601:21)
at Promise._settlePromise0 (/srv/node_modules/bluebird/js/release/promise.js:649:10)
at Promise._settlePromises (/srv/node_modules/bluebird/js/release/promise.js:725:18)
at _drainQueueStep (/srv/node_modules/bluebird/js/release/async.js:93:12)
at _drainQueue (/srv/node_modules/bluebird/js/release/async.js:86:9)
at Async._drainQueues (/srv/node_modules/bluebird/js/release/async.js:102:5)
at Immediate.Async.drainQueues [as _onImmediate] (/srv/node_modules/bluebird/js/release/async.js:15:14)
at processImmediate (internal/timers.js:464:21)

(node:46) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 26871)
(node:46) UnhandledPromiseRejectionWarning: LockError: Exceeded 1 attempts to lock the resource "redlock:trailing-trade-common:exchange-symbols".
i realized that my slack isn't getting more messages ,removing it from .env file solved the issue for me so will give up slack feature for now
sorry didn't manage finding the exact problem.

That is not the log I am looking for.
Since you are using RPi, most likely you have log level set to Error, hence you may see that error only.
Please update docker-compose.rpi.yml and remove BINANCE_LOG_LEVEL in the environment parameter.
environment:
      # - BINANCE_MODE=test
      - BINANCE_MODE=live
      - BINANCE_LOG_LEVEL=ERROR <--- this line
      - BINANCE_REDIS_HOST=binance-redis

And restart  docker by the following command:
$ docker-compose -f docker-compose.rpi.yml up -d

Once you restart, you will see very detailed log.
Then you get the log
$ docker logs binance-bot -f --tail=1000 | bunyan -c 'this.symbol === "LUNAUSDT"' > error.log

Then put in the https://gist.github.com/ because the log is large.
Refer: https://github.com/chrisleekr/binance-trading-bot/wiki/Troubleshooting#how-to-get-the-error-message
Also, make sure Slack is working as it gives you an insight into what is happening with the bot.

It works thank you !
Do you mind if I send you the logs directly, I'm not sure I'm interested in sending all this information to the world

Hey @eth-man
I don't have any direct contact.
You can quickly upload to gist and once I get it, you can delete it.
Are you still experience the last buy price is not cleared issue?

You can test your slack configuration with the following steps:
$ docker exec -it binance-bot /bin/ash                                                                                /srv # node ./app/scripts/slack-test.js

It will tell whether your configuration is correct or not.

by using the script you suggested looking at the output it seems like there is a double quotes on the URL , i changed the env and everything seems be fine regarding to slack
will update if this helps with the trigger price as well
thank you :)

If the issue does not happen anymore, close the issue. You can open a new issue with more detail.


Add clan-member-list-sort plugin

This plugin adds a sort button to the clan member list.

The 2nd plugin change doesn't diff because you are both changing commit and repo at once, can you change just the repo?

There are no changes to the skilling-notifications plugin. I’m not sure why it’s showing up in this pull request.
Both plugins are in the same repo but on different branches.

If the commit is changing then there are by definition changes

My apologies, I've realized my mistake and will open a new pull request once I've fixed my fork of plugin-hub.


docs(plugins) add xml-protection + json-protection docs

I used a wrong branch and PR now documentation for both XML and JSON threat protection plugins

I just notice that the icons are not the correct once. Maybe I was little to fast to request PR. Do you want me to commit new ones, or will you use something matching the actual icons (looks nicer :-))

thanks @michallis we'll probably have our design team look into the icon, once the actual plugin PR is reviewed and merged! good job.

Will be closing this for now considering we're reluctant to adding new plugins to the core as we want to take them out. Thanks.


fixes couldn't set selectedTextBackgroundColor

Very small change, not necessary at all, but it was bothering me to have that error, so I decided to fix it.
Fixes Electron Helper[14028:538660] Couldn't set selectedTextBackgroundColor from default ()
error that you get at startup

@ckhatri how do i recreate this issue? I'm not able to see the Helper message you're referring to.

@alexbarnsley true, this is displayed in the terminal
but the message still appears with this PR

I was getting this bug whenever I highlighted something for the first time in the app. So I would just do npm start -> highlight the price. When I was testing I didn't try opening up dev-tools. So it seems like that still causes the issue, I'll look into seeing if there's a fix for that!

Hm I never get that issue. Would you mind doing a screen recording so I can see your steps / see if resolved? I'm happy to ignore the chromium bug

Sure thing here: https://gfycat.com/YoungLazyKitten

Seems to have fixed message on console for reload for me too.
Nice +5 👍


Synapse Deployment Workflow Failing

Two different error messages received from executing the workflow. When managedIdentity is set to true, we get the message below. The workflow completes successfully but none of the resources show up in the target Synapse workspace.

When managedIdentity is set to false, this message appears and the workflow has "Failed":

Please suggest. Thanks

Here is the yaml file in question that is causing the errors above:
name: Azure Synapse Prod Deployment

on:
  workflow_dispatch:
    inputs:
      logLevel:
        description: 'Log level'
        required: true
        default: 'warning'
        type: choice
        options:
        - info
        - warning
        - debug
  push:
    branches: [ workspace_publish ]

jobs:
  release:
    runs-on: [self-hosted, x64, windows, enterprise, azure]
    steps:
      - uses: actions/checkout@v3
        with:
          ref: 'workspace_publish'
      - uses<EMAIL_ADDRESS>        with:
          TargetWorkspaceName: 'my-synapse-workspace'
          TemplateFile: './ghr-dev-syn/TemplateForWorkspace.json'
          ParametersFile: './ghr-dev-syn/TemplateParametersForWorkspace.json'
          environment: 'Azure Public'
          resourceGroup: 'my-resource-group'
          clientId: ${{ secrets.CLIENTID }}
          subscriptionId: ${{ secrets.SUBCRIPTIONID }}
          tenantId: ${{ secrets.TENANTID }}
          clientSecret: ${{ secrets.CLIENTSECRET }}
          operation: 'deploy'
          managedIdentity: false

Please raise a support ticket on the Azure portal.


[Python]: Bind self in inspector snippets

As illustrated in the following screencast, you can reference a Smalltalk array in a Python snippet, but apparently not the object currently being inspected
https://user-images.githubusercontent.com/184176/152816761-2cbe6a59-05bd-4ebf-9103-ba215dd13b2c.mov
Although self is a Pharo concept, it seems to make sense to have it available for just this sort of case. Currently, it's difficult to do the common GT exploratory dive from one inspector to another.
Python and JS use GtSourceCoderViewModel, but Pharo snippets store self in a subclass via GtPharoSourceCoderViewModel>>selfObject:. The most obvious thing to do would be to pull up selfObject and its accessors into GtSourceCoderViewModel. LePythonSnippetElement>>#onSnippetViewModelChanged could then be amended to set selfObject in addition to the Pharo bindings.
I'm going to submit a PR for this, but I'm going to take a seemingly less optimal approach until this is discussed more deeply. The reason is that presently, there is a design inconsistency between the way Pharo snippets and Python snippets handle bindings.
Pharo snippets use the coder view model:
LePharoSnippetViewModel>>#sharedSnippetContext: aLeSharedSnippetContext
	"..."
	coderViewModel
		sharedBindings: aLeSharedSnippetContext sharedBindings;
		selfObject: aLeSharedSnippetContext selfObject.
	"..."

But Python snippets use the coder itself:
LePythonSnippetElement>>#onSnippetViewModelChanged
	"..."
	self coder
		pythonApplicationStrategy: self serverStrategy;
		pharoBindings: self snippetViewModel snippetBindings.

My guess is that the Python side could/should standardize on the Pharo approach, which seems easily possible by overriding #sharedSnippetContext: in LePythonSnippetViewModel, but I'd like input from the experts before doing this more significant refactor.
Originally proposed in #2408

I couldn't figure out how Python snippets work, but this does not. I finally realized that Python snippets define the variable names on the Python side where here we're trying to recreate/reference Python objects from the Pharo side.
For example, after:
frame = pandas.read_csv('file.csv')

frame is a Python variable of the application instance. A surprising/interesting side effect of this is that these variables are global across the whole image. Unlike Pharo snippets, where variables are local to the page, you can reference a Python snippet variable in any Python snippet on any page in the image. I wonder if this is intended? It certainly doesn't seem well documented...

Hi Sean,
I arrived here from discord while looking how to know which are the objects defined in the variables of a page. The only other person that have variables and pages was you and in your Discord message you pointed to this issue.
There is any way I can use what you have described over here to access the values/objects stored in the variables defined on a page?
TIA

There is any way I can use what you have described over here to access the values/objects stored in the variables defined on a page?

I answered on GT Discord since it's tangential to this issue

#3493 seems to have fixed this and was merged in GT release v1.0.183

The fix from #3493 does not seem to be working in GT v1.0.233:

Also, the example in that issue is no longer illustrative because dictionaries are autoconverted to Smalltalk types. I tried a few different Python types until I found a way to test this again: range(1, 11) and then self.index(4)
@j-brant

I built an image this morning and it works for me:

Great! I’ll try again in a new image


Frontend should forbids user to create folders and resources with . at the end

EPAM AI DIAL chat version
0.6.8
What happened?
Frontend should forbids user to create folders and resources with . at the end
Confidential information

[X] I confirm that do not share any confidential information

Now dot disappears if to use it at the end of any name


Sounds on W10 doesn't work :(

Hi,
I think all is in the title :p
Maybe can someone help me ?
Best,
Aewil

Windows 10 Notifications API don't allow for custom sounds to be played.
Alternatively, if you're using something like Electron with your app, you can play the sound from within the browser window using JavaScript.


Add beaglebone play support clean

Clean Pull request (with a lot fewer intermediate commits). The new beagleplay device support has been tested (after building on a local machine, and spoofing as a beaglebone-black device). TODO: Fix an open issue with the hardware watchdog - this is currently disabled in the build.

@resin-jenkins ok to test


pre-commit: PR118932

Link: https://github.com/llvm/llvm-project/pull/118932
Requested by: @dtcxzyw

/add-label reviewed
/close


⚠ Empornium has degraded performance

In 0b3eb1c, Empornium ($EMP) experienced degraded performance:

HTTP code: 500
Response time: 1067 ms

Resolved: Empornium performance has improved in ab5fd82 after 12 minutes.


v0.2.2

New features that will be added in this PR:

[x] Upgrade option
[x] Updated documentation
[x] Add custom tests

Commit 764d232 restricts the names of test cases to be [0-9].
Will be worked upon (to increase limit) in future commits

Documentation examples (mostly through gif's) need to be added.


PPOOffpolicy _forward_learn method uses only 1-step value instead of n-step value

Hello,
I noticed that in the _forward_learn method of the PPOOffpolicy implementation, only a 1-step value is used as the target value. However, I was expecting it to calculate an n-step value instead. The relevant line of code can be found here:
https://github.com/opendilab/DI-engine/blob/e873d9e8e2f9b59e4f5130fa7db59e946d130f02/ding/policy/ppo.py#L807
Could you please provide some clarification on why the n-step value calculation is not used in this implementation?
Thank you!

Hello,
Thanks for you question. In PPO, we use GAE to compute advantage instead of n-step. In the _forward_learn method, the return is value+adv, and the adv is already calculated through GAE in collector. Therefore, the n-step value is no longer needed.
Thank you!


Cannot build sample

root@portal:/opt# git clone https://github.com/danocmx/passport-steam-openid.git
Cloning into 'passport-steam-openid'...
remote: Enumerating objects: 173, done.
remote: Counting objects: 100% (173/173), done.
remote: Compressing objects: 100% (115/115), done.
remote: Total 173 (delta 87), reused 121 (delta 48), pack-reused 0
Receiving objects: 100% (173/173), 176.31 KiB | 6.08 MiB/s, done.
Resolving deltas: 100% (87/87), done.
root@portal:/opt# cd passport-steam-openid/
root@portal:/opt/passport-steam-openid# pnpm i
 WARN  deprecated<EMAIL_ADDRESS>16.1.1
Packages: +771
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 772, reused 771, downloaded 0, added 771, done

><EMAIL_ADDRESS>prepare /opt/passport-steam-openid
> npx husky install

husky - Git hooks installed

dependencies:
+ axios 1.6.2
+ passport 0.6.0 (0.7.0 is available)

devDependencies:
+ @semantic-release/changelog 6.0.3
+ @semantic-release/git 10.0.1
+ @types/chai 4.3.11
+ @types/chai-as-promised 7.1.8
+ @types/express 4.17.21
+ @types/express-session 1.17.10
+ @types/mocha 10.0.6
+ @types/node 20.10.4
+ @types/passport 1.0.16
+ @types/sinon 10.0.20 (17.0.2 is available)
+ @typescript-eslint/eslint-plugin 5.62.0 (6.13.2 is available)
+ @typescript-eslint/parser 5.62.0 (6.13.2 is available)
+ chai 4.3.10
+ chai-as-promised 7.1.1
+ chai-http 4.4.0
+ cz-conventional-changelog 3.3.0
+ eslint 8.55.0
+ eslint-config-prettier 8.10.0 (9.1.0 is available)
+ eslint-plugin-prettier 4.2.1 (5.0.1 is available)
+ eslint-plugin-sonarjs 0.19.0 (0.23.0 is available)
+ express 4.18.2
+ express-session 1.17.3
+ husky 8.0.3
+ lint-staged 13.3.0 (15.2.0 is available)
+ mocha 10.2.0
+ nock 13.4.0
+ nyc 15.1.0
+ prettier 2.8.8 (3.1.0 is available)
+ semantic-release 21.1.2 (22.0.10 is available)
+ sinon 15.2.0 (17.0.1 is available) deprecated
+ ts-node 10.9.2
+ typescript 5.3.3

The dependency was already listed in devDependencies.
If you want to make it a prod dependency, then move it manually.

Done in 9.4s
root@portal:/opt/passport-steam-openid# cd sample/
root@portal:/opt/passport-steam-openid/sample# pnpm i
Packages: +231
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 231, reused 231, downloaded 0, added 231, done

dependencies:
+ dotenv 16.3.1
+ express 4.18.2
+ express-session 1.17.3
+ passport 0.6.0 (0.7.0 is available)
+ passport-steam-openid 1.0.2

devDependencies:
+ @types/express 4.17.21
+ @types/express-session 1.17.10
+ @types/node 20.10.4
+ @types/passport 1.0.16
+ @typescript-eslint/eslint-plugin 5.62.0 (6.13.2 is available)
+ @typescript-eslint/parser 5.62.0 (6.13.2 is available)
+ eslint 8.55.0
+ eslint-config-prettier 8.10.0 (9.1.0 is available)
+ eslint-plugin-prettier 4.2.1 (5.0.1 is available)
+ eslint-plugin-sonarjs 0.19.0 (0.23.0 is available)
+ typescript 5.3.3

The dependency was already listed in devDependencies.
If you want to make it a prod dependency, then move it manually.

Done in 4s
root@portal:/opt/passport-steam-openid/sample# ls
README.md  node_modules  package-lock.json  package.json  pnpm-lock.yaml  src  tsconfig.json
root@portal:/opt/passport-steam-openid/sample# nano .env.example
root@portal:/opt/passport-steam-openid/sample# mv .env.example .env
root@portal:/opt/passport-steam-openid/sample# pnpm run build

><EMAIL_ADDRESS>build /opt/passport-steam-openid/sample
> npx tsc

src/app.ts:49:54 - error TS2339: Property 'steamid' does not exist on type 'User'.

49   res.status(200).send(`Authenticated as ${req.user?.steamid}`);
                                                        ~~~~~~~

Found 1 error in src/app.ts:49

 ELIFECYCLE  Command failed with exit code 2.
root@portal:/opt/passport-steam-openid/sample#

I can't seem to be able to reproduce this, even on a clean install. Regardless, the problem doesn't seem to be related to the library itself, but to the sample project which tries to overwrite ENV type in order to gain better type safety. Closing.


Platform exception: Can only use lower 16 bits for requestCode

Hi,
I am getting following error when I try to select any file:
I/FilePicker(13338): Checking permission: android.permission.WRITE_EXTERNAL_STORAGE
I/FilePicker(13338): Requesting permission: android.permission.WRITE_EXTERNAL_STORAGE
E/MethodChannel#file_picker(13338): Failed to handle method call
E/MethodChannel#file_picker(13338): java.lang.IllegalArgumentException: Can only use lower 16 bits for requestCode
E/MethodChannel#file_picker(13338): 	at androidx.fragment.app.FragmentActivity.checkForValidRequestCode(FragmentActivity.java:696)
E/MethodChannel#file_picker(13338): 	at androidx.fragment.app.FragmentActivity.validateRequestPermissionsRequestCode(FragmentActivity.java:711)
E/MethodChannel#file_picker(13338): 	at androidx.core.app.ActivityCompat.requestPermissions(ActivityCompat.java:500)
E/MethodChannel#file_picker(13338): 	at com.mr.flutter.plugin.filepicker.FilePickerPlugin.requestPermission(FilePickerPlugin.java:130)
E/MethodChannel#file_picker(13338): 	at com.mr.flutter.plugin.filepicker.FilePickerPlugin.startFileExplorer(FilePickerPlugin.java:180)
E/MethodChannel#file_picker(13338): 	at com.mr.flutter.plugin.filepicker.FilePickerPlugin.onMethodCall(FilePickerPlugin.java:115)
E/MethodChannel#file_picker(13338): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:201)
E/MethodChannel#file_picker(13338): 	at io.flutter.view.FlutterNativeView$PlatformMessageHandlerImpl.handleMessageFromDart(FlutterNativeView.java:188)
E/MethodChannel#file_picker(13338): 	at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:202)
E/MethodChannel#file_picker(13338): 	at android.os.MessageQueue.nativePollOnce(Native Method)
E/MethodChannel#file_picker(13338): 	at android.os.MessageQueue.next(MessageQueue.java:326)
E/MethodChannel#file_picker(13338): 	at android.os.Looper.loop(Looper.java:160)
E/MethodChannel#file_picker(13338): 	at android.app.ActivityThread.main(ActivityThread.java:6669)
E/MethodChannel#file_picker(13338): 	at java.lang.reflect.Method.invoke(Native Method)
E/MethodChannel#file_picker(13338): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
E/MethodChannel#file_picker(13338): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
I/flutter (13338): [FilePicker] Platform exception: PlatformException(error, Can only use lower 16 bits for requestCode, null)
W/ManagedChannelImpl(13338): [{0}] Failed to resolve name. status={1}
Here is the report from flutter doctor -v:
[✓] Flutter (Channel stable, v1.2.1, on Mac OS X 10.14.3 18D109, locale en-GB)
• Flutter version 1.2.1 at /Applications/flutter
• Framework revision 8661d8aecd (5 weeks ago), 2019-02-14 19:19:53 -0800
• Engine revision 3757390fa4
• Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Applications/android-sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• ANDROID_HOME = /Applications/android-sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
• All Android licenses accepted.
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 10.1, Build version 10B61
• ios-deploy 1.9.4
• CocoaPods version 1.5.3
[✓] Android Studio
• Android Studio at /Applications/Android Studio 3.5.app/Contents
• Flutter plugin version 33.4.2
• Dart plugin version 183.5901
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[✓] Android Studio (version 3.4)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 33.4.2
• Dart plugin version 183.5901
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[✓] IntelliJ IDEA Community Edition (version 2018.3.5)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin version 33.4.2
• Dart plugin version 183.5912.23
[✓] VS Code (version 1.32.3)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 2.24.0
[✓] Connected device (1 available)
• Android SDK built for x86 • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)
• No issues found!

What is the file_picker version that you are using?

1.3.2

Does this happen always? Can you give it a try in the Android 8 (API 27) and let me know if it is working? Thank you.

I am trying all file types, with or without giving storage permissions. Same is happening on API 27, here is the details of my emulator:
[✓] Connected device (1 available)
• Android SDK built for x86 • emulator-5556 • android-x86 • Android 8.1.0 (API 27) (emulator)

@TheHemantKaushik thank you for the insight. Is this happening if you use FileType.IMAGE?

Yes, it is happening with FileType.IMAGE as well as FileType.AUDIO and FileType.VIDEO.

Ok. I may take a look into it later today, if I have some time.

@TheHemantKaushik I'm looking into it to understand what is actually happening. Can you tell me what is your targetSdk of your main app?
Thank you.

Also @TheHemantKaushik, can you post your app’s build.gradle? This looks like a very version related issue. Thank you.

This is fixed in 1.3.3. However I would still like to have the info I've asked for so I could further investigate what was causing the issue.


[embedded] Start building embedded support on Linux/ELF, expand archs of the embedded stdlib to cover common embedded targets

There is nothing Apple / Mach-O specific in the Embedded Swift setup, let's enable the Embedded Swift support in the Linux toolchains and start building the embedded stdlib for ELF, too.

@swift-ci please test

@swift-ci please test

Nice, any plans to set up a CI that runs the compiler tests on actual hardware? At least, it would be nice to have a 32-bit non-embedded CI set up, that could run all the native executable tests too. I don't think anybody is doing that right now, unless there's still a 32-bit watchOS CI running internally right now somewhere.
I think it wouldn't be hard to set up a linux armv7 CI on one of the existing linux AArch64 images, since 64-bit distros usually support building and running 32-bit binaries also.

@swift-ci please test

I think this is causing failures on the incremental bots, which look like:
<unknown>:0: error: fatal error encountered during compilation; please submit a bug report (https://swift.org/contributing/#reporting-bugs)
<unknown>:0: note: No available targets are compatible with triple "riscv32-none-none-eabi"

I put up what I think is a fix at https://github.com/apple/swift/pull/70057, and am going to kick off testing of a revert PR in case that isn't right.


Ability to flush and rebuild styles in the browser on demand

Hi,
We're trying to use styled-components in our big-scale production web-app that helps create dashboards, so there arose a question of allowing users change color-scheme and see changes in the view as they type in colors. One of the issues is that whenever a value changes (for instance primaryColor in theme) every of the hundreds or React components on the page that used it have styles swapped and the styles are added to the HEAD. If the user keeps playing with the values that makes the STYLE tag grow to immense size and having 20-ish properties to change in colors multiplied by a number of iterations makes Chrome tab consume >300Mb of memory (from a benchmark we created by randomly generating property value n times). Can you provide an opt-in way to .flush() the style tag programmatically and re-render the styles for the whole app (as it's done for the first paint)?

Signed! This is the first way I tried to play with styled-components tonight ( connected to a redux store w. some user-defined styles). I ended up with an enormous amount of styles.
Loving styled-components otherwise.

This seems reasonable, what do you think @geelen? Why don't we do this already?

No reason! Never considered this as a use-case, tbh—was always happy for the theme to have control over properties but if someone is grabbing a slider then yeah that's going to be an issue.
With v2 you can make it so certain properties target the style attribute instead of generating classes. Do you think that would be sufficient?
Not documented yet but if you look at #365 and try styled-components@next you might be able to solve the issue straight away.
But yeah, I see no problem adding a hook to clear out the existing styles and re-render from scratch, if it's needed.

Well, the general reason of this accumulation is basically lack of separation between static styles and dynamically defined (props/theme dependent) styles. As I'd see it, there has to be a mechanism that takes the array produced by the template string broken by variables and does a search in each item to the previous semicolon and pushes the chunk into the static styles of the class. The second part of the string after the semicolon belongs to the dynamic style property. In the end of the day each class that has inclusions of dynamically defined properties has to assign two classNames to an element: the static styles class and the dynamic styles class. Thus when properties change and you decide to generate new classNames you don't copy the static styles over and over again. From my experience the style that is dynamic due to theming or properties amounts to 10-20% of styles, but we do manage to copy the other 80-90% along to the new className. I can't see a reason for that. from first paint performance standpoint that might be not the best ever solution but for the second and following generation that is a browser performance issue. To avoid the overhead we need to keep our static styles in PostCSS or SASS and dynamic in styled components to generate themes on the hoof. But that is the worst imaginable trade-off from developer's experience standpoint

Hey, is there any news? Maybe it is already possible to do in the latest styled-components?
I have exactly the same use case as @jahglow.

This isn't supported and likely won't be accepted. This issue is pretty stale and inactive. That said, with the StyleSheetManager and by creating sheets manually this is kind of supported now, if some extra code isn't an issue. https://github.com/styled-components/styled-components/blob/d96101a102b59a8f9ac4b6f278594674897282bb/packages/styled-components/src/sheet/Sheet.ts#L72-L74


opt-in fns behind feature flags should be documented as such

Compare

https://docs.rs/tokio/1.15.0/tokio/time/fn.timeout.html
https://gtk-rs.org/gtk-rs-core/git/docs/cairo/struct.ImageSurface.html#method.write_to_png

Both of these are behind feature flags. In the first one which feature flag you need is documented. In the second one you need to search rest of the documentation for tips.
It would be helpful if gtk-rs packages documented required feature flags for function in the function documentation.

That's because here the #[cfg] is on the whole module imported in lib.rs instead of per function: https://gtk-rs.org/gtk-rs-core/git/docs/src/cairo/lib.rs.html#145
Fixing that would require moving it down on each function (exclusively or additionally).


Rubocops compatible with Ruby 2.4+

Overview
Our agent's previous support of Ruby 2.2 and 2.3 prevented some Rubocop linters from being enabled. This PR enables the following:

Performance/RegexpMatch
Performance/Sum
Performance/UnfreezeString
Style/RedundantStringEscape
Style/SafeNavigation

It disables Style/FetchEnvVar. When ENV.fetch fails, a KeyError or the explicitly specified default
value is returned. We don't want to raise an unexpected error in a customer's environment. Also, fetch is slightly less performant than ENV[] when there is not a non-nil replacement value.
Resolves: https://github.com/newrelic/newrelic-ruby-agent/issues/1787
Resolves: https://github.com/newrelic/newrelic-ruby-agent/issues/1246

@kaylareopelle perhaps it's an issue best left for a separate PR, but my preference would be that for everywhere we now plan to align with the defaults, we would simply remove the Enabled: false based override from .rubocop_todo.yml without actually redundantly adding a new Enabled: true section to .rubocop.yml.

@kaylareopelle perhaps it's an issue best left for a separate PR, but my preference would be that for everywhere we now plan to align with the defaults, we would simply remove the Enabled: false based override from .rubocop_todo.yml without actually redundantly adding a new Enabled: true section to .rubocop.yml.

I'm comfortable with that change. I'm not sure if all of these are on by default. I'll check Rubocop and adjust accordingly. I think makes sense to add another issue to adjust the other cops, since some of the enabled cops may be disabled by default.

@fallwith  - RedundantStringEscape and Sum are pending, so I left those references in to make sure they get applied. The others were removed in 03d82e65a3a5b281165b0d7fe2b45c7875693d5c


auto create imported asset folder if needed

Objective

Since #11218, example asset_processing fails:

thread 'main' panicked at crates/bevy_asset/src/io/source.rs:489:18:
Failed to create file watcher: Error { kind: PathNotFound, paths: ["examples/asset/processing/imported_assets/Default"] }

start from a fresh git clone or delete the folder before running to reproduce, it is in gitignore and should not be present on a fresh run
https://github.com/bevyengine/bevy/blob/a6574786757c0a0a7ddffb99fdc40ce90980fc82/.gitignore#L18
Solution

Auto create the imported_assets folder if it is configured

Would it be better if the AssetWriter always created the path when it didn't exist, regardless of if it's a processed asset? I feel like if a writer had nothing to write on, it would create the thing to write on, unless there's a reason I'm missing for why specifically the basic writer doesn't create the path.
In other words, instead of what was done previously, where  file system control was given to the reader, should it be given to the writer instead?

In other words, instead of what was done previously, where file system control was given to the reader, should it be given to the writer instead?

That would result in the same situation as before #11218, and the assets folder created when not needed

Ahhh yeah of course, somehow misunderstood FileAssetWriter::new to be the file initializer, instead of it setting the base path of the writer, so it would end up creating the assets folder. I'll delete the question


Blood DK Expertise is adding 180 from talents that doesn't exist.

Describe the bug
When using the Blood DK SIM tool it shows a +180 from talents to expertise that doesn't exist.
To Reproduce
Steps to reproduce the behavior:

Go to Blood DK sim
Edit gear, talent, etc to match wow character.
Hover over expertise to show values.
Check character values and they will not match actual in game values.

Expected behavior
Expect values in sim should match real values in game when configured to match.

Sim Links and Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Firefox
Version 132

Did this get removed from the game? @SoDelirius

Nope it did not. You can clearly see in your screenshot that 687 rating gives you 22 expertise rating but your character sheet shows 28


Unable to run on Windows

Describe the bug
I get this error on adding it to my project. Any intuition on why?

Reproduction: follow the installation guide, then run nuxt dev.
I currently am not providing a sandboxed reproduction as I'm not aware of any online sandbox for Windows. Although I'll happily work on one if considered relevant!
Reproduction

System Info
System:
    OS: Windows 10 10.0.22621
    CPU: (4) x64 Intel(R) Core(TM) i3-8350K CPU @ 4.00GHz
    Memory: 3.37 GB / 15.96 GB
  Binaries:
    Node: 16.13.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 3.4.1 - C:\Program Files\nodejs\yarn.CMD
    npm: 8.5.5 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 110.0.5481.177
    Edge: Spartan (44.22621.1265.0), Chromium (110.0.1587.57)
    Internet Explorer: 11.0.22621.1

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Hey @ennioVisco ! Thanks for the issue, could you try the latest version 1.3.2 and let me know how that goes

Thanks! Fixed in https://github.com/harlan-zw/nuxt-seo-kit/commit/fbd25a924df3e1ae7d81b35f3b44d48d5082a966


[JAMES-3193] Updates to the Developer Guide

I have created this as a draft PR for this first iteration as per the recent email thread.
Please let me know if this is on the right track or not before I continue further.
Thanks!

Folded into #199, so closing.


Fix percent encoded URLs causing the program to crash

I specifically had an issue where a request of "/?test={encoded}" due to { being an invalid URL character. AWS Lambda Proxy Integration automatically decodes percent encodings and these needs to be re-encoded before creating the request. I've added a test for this specific case, it will crash without my change.

Sorry for late reply🙇
I'd like to merge this PR! So, Could you resolve conflicts?
(Recently I updated HexavilleFramework to adopt swift-nio instead of Prorsum)

Done! Thanks @noppoMan


Guidance in how to use this app

Hi!
The description of the app looks promising, but I'm finding hard to know how to use it.
Maybe a little readme with an example will help other people to use this app.
Thanks!

Hey! I've added a tiny README to this project. It's now available at https://github.com/variantdev/chartify#chartify
I don't know if the standalone CLI of chartify is complete for your use-case right now. But it would be great if you could give it a shot and try contributing patches if you found something lacking. Thanks.


Issue #2075 still not working

Hi,
After upgrading to version 4.2.0. The bug from issue #2075 is still there.
Please see previous issue for an example.
BR,
Cees

Please post error stacktrace (there were some fixes in SQL formatting, this error can't be exactly the same as in #2075).

You right. The new trace:
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
at java.lang.String.substring(String.java:1967)
at org.jkiss.dbeaver.model.sql.SQLUtils.splitFullIdentifier(SQLUtils.java:782)
at org.jkiss.dbeaver.ui.editors.sql.syntax.SQLCompletionAnalyzer.getTableFromAlias(SQLCompletionAnalyzer.java:326)
at org.jkiss.dbeaver.ui.editors.sql.syntax.SQLCompletionAnalyzer.runAnalyzer(SQLCompletionAnalyzer.java:120)
at org.jkiss.dbeaver.ui.editors.sql.syntax.SQLCompletionProcessor$ProposalSearchJob.run(SQLCompletionProcessor.java:363)
at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:95)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
at org.jkiss.dbeaver.model.sql.SQLUtils.splitFullIdentifier(SQLUtils.java:782) is 2 rows further from 780.

Thanks for details.
It was fixed in #2169.


GitHub Task

After completion of this task add a comment below with your repository link.

Kashika Akhouri- Task Completed. Link- https://github.com/kashika0112/IntroductionToGit

Kashika Akhouri- Task Completed. Link- https://github.com/kashika0112/IntroductionToGit

Apoorva Tiwari (Repository): https://github.com/apoorvatiwaree/Lean-In-ML-Circle

Apoorva Tiwari (Repository): https://github.com/apoorvatiwaree/Lean-In-ML-Circle

Priyanka Saini (Assigned Task): https://github.com/priyankasaini69/demo_repoo

Priyanka Saini (Assigned Task): https://github.com/priyankasaini69/demo_repoo

Priyanka Saini (Assigned Task): https://github.com/priyankasaini69/demo_repoo

@priyankasaini69 Great to see you were able to push changes to the main branch of the repository but the purpose of this task is for you to learn how to create a branch, work on it and push it instead of directly pushing to main. Try to do it as directed in the task.

Priyanka Saini (Assigned Task): https://github.com/priyankasaini69/demo_repoo

@priyankasaini69 Great to see you were able to push changes to the main branch of the repository but the purpose of this task is for you to learn how to create a branch, work on it and push it instead of directly pushing to main. Try to do it as directed in the task.

https://github.com/mehakagg1313/task

https://github.com/mehakagg1313/task

Task Completed. Link: https://github.com/Surbhi2607/Introduction-to-git.git

Task Completed. Link: https://github.com/Surbhi2607/Introduction-to-git.git

https://github.com/Shriya0202/intro-to-git.git

https://github.com/Shriya0202/intro-to-git.git

https://github.com/Shriya0202/intro-to-git.git

@Shriya0202 Please check if you created a public repository. And add the correct link to it.

https://github.com/Shriya0202/intro-to-git.git

@Shriya0202 Please check if you created a public repository. And add the correct link to it.

https://github.com/Shriya0202/intro-to-git.git

https://github.com/Shriya0202/intro-to-git.git

https://github.com/Shweta2512/LeanIn.git

https://github.com/Radhasingh95/first-repo.git

https://github.com/Nishali2908/LeanIn_ML

@Nishali2908, You had to create branch add then make changes to it and push it.

https://github.com/priyanshigarg24/MLcircle

https://github.com/ahanavish/test-repo

muskan gupta
link- https://github.com/1218muskan/Demo_repo


copyright holder mismatch between LICENSE and comment in smtpd.go

Compare:
https://github.com/bradfitz/go-smtpd/blob/deb6d623762522f8ad4a55b952001e4215a76cf4/LICENSE#L1
https://github.com/bradfitz/go-smtpd/blob/deb6d623762522f8ad4a55b952001e4215a76cf4/smtpd/smtpd.go#L1
Is it intentional that they don't match?

It should probably have an AUTHORS file with "Google, Inc" in it, then change LICENSE to say "The go-smptd AUTHORS", to be more explicit.


change password

Implement new feature of changing password.
Change password link/button should be in "account" view (separate module for this functionality).
May be it make sense  to separate some functions into modules.

implemented


Need Docs About Troubleshooting ASP.NET Core SignalR Common Issues

Describe the new topic
Please provide doc about troubleshooting ASP.NET Core SignalR common issues, this doc could provide information on common SignalR connection related errors and provide troubleshooting advice.
Explain why this topic is needed.
Some Docs, such as "Troubleshoot ASP.NET Core on Azure App Service and IIS", provide common errors and instructions on how to diagnose errors under specific scenarios, which would help us quickly find root cause of error and fix it.
For ASP.NET Core SignalR topic, many developers often have SignalR connection related issues.
Example links:

https://stackoverflow.com/questions/63437471/websocket-connection-to-ws-localhost5000-notificationhub-failed-error-duri
https://stackoverflow.com/questions/62510544/signalr-hub-not-found-after-website-is-published

If possible, please provide a doc about troubleshooting common SignalR connection related errors.
Suggest a location in the Table of Contents.
Provide the doc about troubleshooting common SignalR connection related errors under Real-time apps section in ASP.NET Core Docs site.
Write an abstract. In one short paragraph, describe what this topic will cover.
Error during WebSocket handshake
1) WebSocket connection to 'ws://localhost:port/HubName' failed: Error during WebSocket handshake: Unexpected response code: 307
The most common cause for this error is that SignalR hub server listen to and respond over both HTTP and HTTPS, and configured enforce HTTPS  by calling UseHttpsRedirection in the Startup class. If specifying the URL on client side using .withUrl("http://localhost:port/HubName") , which would cause this error.
2) WebSocket connection to 'wss://localhost:port/HubName' failed: Error during WebSocket handshake: Unexpected response code: 404
If hosting the ASP.NET Core SignalR app as an sub-application but not set URL with the sub-app's pathbase on SignalR JavaScript client side, which would cause this error.
Include other common errors and causes:  Error during WebSocket handshake: Unexpected response code: 400  and Error during WebSocket handshake: Unexpected response code: 503 etc, when WebSockets not enabled.

I find the doc-idea tag is added, I'd like to know if Docs team have any plan to write and publish document covering this topic.
Besides, if detailed scenarios with samples that could cause above common issues, I can share it.


Update entering name when deleting

This issue is imported from pivotal
When we\'ve added formal and self-chosen names, the \'Are you sure you want to delete your account\' dialog wasn;t updated, and still asks for a `full name`.

Discussion:
Is it needed to enter your name? Should it be the formal name, or the self-chosen name? Is Entering 'Delete' also enough?

In the use case where the user was verified and he delete this verification, the 'validated' surname and given name are still 'visible' even though they are no longer recognised as 'validated'. However it might lead to a confusing situation for an end user, which name should she type to delete here account.
Also think about the iDIN given name, which will be 'I' in my case, not Ines. Which also might lead to confusion if I want to delete my account and type 'my name'  (inesduits - Aug 29, 2024)

Besloten 5 sept 2024: Typen 'Delete' of 'Verwijder' als bevestiging. (Peter Havekes - Sep 5, 2024)

Related to https://www.pivotaltracker.com/story/show/187955753
(Peter Havekes - Sep 5, 2024)

It looks like there is "just" a big red delete button. It does not have the "type delete" field. Overlooked? @oharsta

@Tyskai This is not the screen referenced in this story. It entails the Account section where you can delete your entire account (not just en eduID).

You are right, I am sorry!


[SPARK-11572] Process outstanding requests after seeing stop flag

This is to address the regression Josh discovered.

Test build #45961 has started for PR 9723 at commit e208c5f.

Test build #45961 has finished for PR 9723 at commit e208c5f.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45961/
Test FAILed.

Test build #45962 has started for PR 9723 at commit cb4132d.

Test build #45966 has started for PR 9723 at commit 3df8051.

Test build #45966 has finished for PR 9723 at commit 3df8051.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45966/
Test FAILed.

Merged build finished. Test FAILed.

I'd like @zsxwing to help take a look at this and figure out whether this is a sufficient fix or whether we should revert your original patch and go back to the drawing board.

It's possible that there's a cleaner way to fix the original bug that motivated the incorrect patch vs. trying to patch up the problems introduced by the fix by layering more fixes on top. Let's see.

Test build #45962 has finished for PR 9723 at commit cb4132d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45962/
Test PASSed.

Test build #45968 has started for PR 9723 at commit 8be6a7c.

Test build #45968 has finished for PR 9723 at commit 8be6a7c.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45968/
Test FAILed.

Merged build finished. Test FAILed.

Test build #45973 has started for PR 9723 at commit cd9b2f2.

Test build #45973 has finished for PR 9723 at commit cd9b2f2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45973/
Test FAILed.

Merged build finished. Test FAILed.

sbt.ForkMain$ForkError: Test failed with compression using codec org.apache.spark.io.LZ4CompressionCodec:

assertion failed: expected groupByKey to spill, but did not
	at scala.Predef$.assert(Predef.scala:179)
	at org.apache.spark.TestUtils$.assertSpilled(TestUtils.scala:169)
	at org.apache.spark.util.collection.ExternalAppendOnlyMapSuite.org$apache$spark$util$collection$ExternalAppendOnlyMapSuite$$testSimpleSpilling(ExternalAppendOnlyMapSuite.scala:254)
	at org.apache.spark.util.collection.ExternalAppendOnlyMapSuite$$anonfun$10$$anonfun$apply$mcV$sp$8.apply(ExternalAppendOnlyMapSuite.scala:218)
	at org.apache.spark.util.collection.ExternalAppendOnlyMapSuite$$anonfun$10$$anonfun$apply$mcV$sp$8.apply(ExternalAppendOnlyMapSuite.scala:216)
	at scala.collection.immutable.Stream.foreach(Stream.scala:547)

I think the above was not related to change in AsynchronousListenerBus

IMO, we should revert https://github.com/apache/spark/commit/3e0a6cf1e02a19b37c68d3026415d53bb57a576b
The user should not call stop or other long-time work in a listener since it will block the listener thread, and prevent from stopping SparkContext/StreamingContext.
I cannot see an approach since we need to stop the listener bus's thread before stopping  SparkContext/StreamingContext totally.

I'm going to revert those commits now to try to unbreak the SBT builds.

Sounds like we should prevent the call to StreamingContext#stop() in the listener bus's thread.
How about setting a ThreadLocal Boolean to indicate to StreamingContext that the stop() call should not be honored ?

Sounds like we should prevent the call to StreamingContext#stop() in the listener bus's thread.
How about setting a ThreadLocal Boolean to indicate to StreamingContext that the stop() call should not be honored ?

Sound like a good idea. Ping @tdas, what do you think?


Custom line-number range

An enhancement I'd love to see in the future is the ability to set where the line-numbering starts. Sometimes I'll take a snippet from a larger file and would like the numbering to start where that snippet was taken from or a custom one to be set.
Thanks for all your work on Carbon, it's a great tool!

Hey @WeaverOfTheWeb great idea! This would be super easy to add: https://codemirror.net/doc/manual.html#option_firstLineNumber
If you want, feel free to take a stab at it, otherwise I will get to this feature eventually 👍


Lifecycle hook overhaul

There are some issues with way the hooks currently work (#71, #81 #94, #112).
The hooks are somewhat counter intuitive because of the way objection.js works. Objection.js is not a full ORM in the sense that you don't always work with model instances. Sometimes (most of the time) you just write queries that result in models, but before the query you don't actually have the model instances that get modified. For example:
Person
  .query()
  .patch({a: 10})
  .where('b', '<', 100)

It would be intuitive to call the $beforeUpdate and $afterUpdate hook for all rows that get updated, but we don't have them and I certainly think we shouldn't fetch them implicitly just so that we can call the hooks for them. In this example objection simply calls the hooks for the patch object {a:10}. This allows you to do common stuff like
$beforeUpdate(options, context) {
  this.updatedAt = Date.now();
}

and it just works, since all the updated rows now get the new updatedAt value.
Confusion comes from the instance query methods (ones started with $query()). For example:
somePerson
  .$query()
  .patch({a: 10})

Now it would be intuitive that this would point to the model being updated in the hooks, but then the hook would work different from the non-instance query hooks. The $beforeUpdate example above would not work.
Currently there is no way to get the model being updated in the hooks. What I propose is that we pass in the model being updated in the options object like this:
$beforeUpdate(options, context) {
  if (options.old) {
    // Do stuff with the old instance.
    this.fullName = (this.firstName || options.old.firstName) + ' '
      + (this.lastName || options.old.lastName);
  }
  this.updatedAt = Date.now();
}

This way the hooks would work for with both query types.
Here is a list of how the hooks would work in each case. The new stuff (not currently implemented) is marked with NEW.
$beforeUpdate

arguments (options, context)

this points to the update object.

NEW for instance queries ($query()) the old values are passed in through options.old

$afterUpdate

arguments (options, context)

this points to the update object.

NEW for instance queries ($query()) the old values are passed in through options.old

$beforeValidate

arguments (jsonSchema, json, options)

This hook is different form all the other in the way that this always points
to an empty model instance. $beforeValidate is called before the model instance
is populated with fields. This is because the the object is validated before it is created.
The object to be validated is passed in as the json argument.

jsonSchema can be modified in this hook and it should be returned from the hook.

NEW for instance queries ($query()) the old values are passed in through options.old

$afterValidate

arguments (json, options)

This hook is different form all the other in the way that this always points
to an empty model instance. $afterValidate is called before the model instance
is populated with fields. This is because the the object is validated before it is created.
The validated object is passed in as the json argument.

NEW for instance queries ($query()) the old values are passed in through options.old

$beforeInsert

arguments (context)

this points to the model about to be inserted.

$afterInsert

arguments (context)

*this points to the model that was inserted.
NEW $beforeDelete

arguments (context)

this points to the model being deleted.

Only called for instance queries started with $query()!. Hooks are called for model instances.
In a query().delete().where('id', 'foo') query there is no object to call it for unless we first fetch
the objects to be deleted, but that is not something we should do automatically. You can use
$query().delete() instead.

NEW $afterDelete

arguments (context)

this points to the model being deleted.

Only called for instance queries started with $query()!. Hooks are called for model instances.
In a query().delete().where('id', 'foo') query there is no object to call it for unless we first fetch
the objects to be deleted, but that is not something we should do automatically. You can use
$query().delete() instead.

$afterGet

arguments (context)

this points to the fetched model instance.

Called for each fetched model.

What do you think? Please add any comments/changes/points you might think of! @purepear @drew-r @getvega @gerhardsletten

Or would you prefer the old values to be passed as the last argument?


Current user - always anonymus

I am looking for a solution to confirm the id of the logged in user and add it to the field in the forms.
class CreateLink(graphene.Mutation):
    id = graphene.Int()
    url = graphene.String()
    description = graphene.String()
    posted_by = graphene.Field(UserType)

    class Arguments:
        url = graphene.String()
        description = graphene.String()

    def mutate(self, info, url, description):
        user = info.context.user
        if user.is_anonymous:
            raise GraphQLError('Authentication credentials were not provided')

        link = Link(
            url=url,
            description=description,
            posted_by=user,
        )
        link.save()

        return CreateLink(
            id=link.id,
            url=link.url,
            description=link.description,
            posted_by=link.posted_by,
        )

But I still have information that the user is anonymous

Hi @maltitco,
If the user is authenticated, this exception should not be thrown:
if user.is_anonymous:
    raise GraphQLError('Authentication credentials were not provided')

If you have this error it could be for several reasons.

The middleware/backend are not configured

MIDDLEWARE = [
    ...
    'django.contrib.auth.middleware.AuthenticationMiddleware',
    'graphql_jwt.middleware.JSONWebTokenMiddleware',
    ...
]

AUTHENTICATION_BACKENDS = [
    'graphql_jwt.backends.JSONWebTokenBackend',
    'django.contrib.auth.backends.ModelBackend',
]

You are not sending the authentication header
Authorization: JWT -token-

This is a howtographql fork that includes this library and authenticates correctly.
https://github.com/mongkok/graphql-python/tree/json-web-token

@mongkok thanks for the fast response.
The middleware/backend are configured correct - checked twice with your fork of howtographql.
You were right that it was missing: Authorization: JWT -token-
Thanks for your help.

I'm glad it helped :)


Qt 6 is unable to pick up plugins on non-NixOS

Describe the bug
Doing nix profile install nixpkgs#qt6ct doesn't make Qt 6 to use qt6ct despite QT_QPA_PLATFORMTHEME=qt6ct is set. Perhaps that's because https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/qt-5/5.15/qtbase.patch.d/0009-qtbase-qtpluginpath.patch is not ported to Qt 6.
Steps To Reproduce
Steps to reproduce the behavior:

QT_QPA_PLATFORMTHEME=qt6ct
nix profile install nixpkgs#qt6ct
Install & run any Qt 6 application

Expected behavior
Application follows qt6ct settings
Notify maintainers
@milahu @NIckCao
Metadata

 - system: `"x86_64-linux"`
 - host os: `Linux 6.5.9-lqx1, NixOS, 23.11 (Tapir), 23.11.19700101.dirty`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.17.1`
 - nixpkgs: `/etc/static/nixpkgs`

(I'm reporting this for other person)
Priorities
Add a :+1: reaction to issues you find important.

I'm aware of this issue but finding qt plugins from PATH is not really a good idea. Shall we just add some document around adding profile paths to QT_PLUGIN_PATH for working around this, just like what the nixos module does.

I'm not sure how would this work on non-NixOS given that

The path includes Qt version and there's nothing to manage that on non-NixOS
Setting it globally is likely to break non-nix software

2. Setting it globally is likely to break non-nix software

Good point, I would be porting this patch to qt6 for consistency.

@NickCao hi, I have encountered a use-case where I have to use pkgs.replaceDependency. It correctly replaces paths in the wrapper which correctly prefixes QT_PLUGIN_PATH but sadly PATH has a preference so the globally installed plugin gets preferred over my changed one. Could the priority in the patch be changed?
PS: there's already an issue about that but for Qt 5 (#177558)

There are valid use cases for both ways: users might want to replace the wrapped plugins with the ones in their PATH. I think this is even a more wide spread use case than replaceDependency. Maybe we shall add another set of environment variables with even higher precedence?

There are valid use cases for both ways: users might want to replace the wrapped plugins with the ones in their PATH.

Yeah? The logic with environment variables is usually local ones overriding global ones... Isn't the only use-case of plugins from PATH to be the last resort when QT_PLUGIN_PATH doesn't contain needed plugins?

The logic with environment variables is usually local ones overriding global ones...

Well yes, but I feel the situation is a bit different here in nixpkgs, since environment variable is the primary means of locating plugins.

Isn't the only use-case of plugins from PATH to be the last resort when QT_PLUGIN_PATH doesn't contain needed plugins?

cc @NixOS/qt-kde

Opened a PR anyway: https://github.com/NixOS/nixpkgs/pull/292237.