[CELEBORN-89][REFACTOR] MapperEnd should enable set separated timeout configuration

What changes were proposed in this pull request?
MapperEnd should enable set separated timeout configuration
Why are the changes needed?
Previously MapperEnd requests from ShuffleClient use same timeout with CommitFiles request from LifeCycleManager, so if  commitFile timeout one time, the MapperEnd request must timeout. So we need to support customized timeout for MapperEnd to avoid it use same timeout with CommitFiles.
What are the items that need reviewer attention?
Related issues.
CELEBORN-89
Related pull requests.
How was this patch tested?
/cc @AngersZhuuuu
/assign @main-reviewer

I think we don't need to do change for MapperEnd


Invalid Observation search parameter returning results

The following query does not cause an error, and returns a set of 100 random Observation results:
https://syntheticmass.mitre.org/fhir/Observation?code:50050
This should cause an error, no?

I'm not sure.  Technically, I think it's an unknown parameter (code:50050) -- and leaders of the FHIR community have made it pretty clear that they think unknown parameters should be ignored.  I suspect that's what we're doing -- and the 100 "random" observations are the same (or at least similar) to what you would receive if you had no search parameter at all.

BTW-- I fought the fight against that idea, arguing that unknown parameters should return an error, but I lost that battle.

☹  Okay so this is not technically an issue then?

I don't think so...  But I suppose if we want to try to detect user errors like this (using : instead of =) we could do so.  But at the end of the day, I think the FHIR stance is that this type of mistake should never make it to a production client anyway and it is difficult to discern mistakes from intentional extra parameters (although I have no idea why someone would intentionally send extra parameters).


Support  Receivers

Description

Currently KMock generates Members for receivers normal members.
Acceptance Criteria:

Receiver member proxies are accessable like normal proxies
receiver members are generated as receivers not as normal members

Done with release 0.2.0-rc01


[scanner] scanning symbolic link source directory could lead to infinite loop and OOM eventually

Hi dear developer,
Thanks for developing this magnificent tools. This might be a potential bug regarding to source code scanning with scancode
version
OSS Review Toolkit, version 0.1.0-SNAPSHOT.
Running using Java 11.0.6 on Linux
ScanCode version 3.0.2
steps to reproduce
find a source file
it must have at least two symbolic links to directory, the symbolic link must link to the inside of source code directory
scan like this
/opt/ort/bin/ort --info --debug -c /var/proj/etc/ort.conf scan -p /var/proj/mnt/src/test -o /var/proj/mnt/src/scan_output
ort output is like
Save scan results...
Save scan results as: json-pp...
Scanning done.
Summary:        info, licenses, copyrights with 3 process(es)
Errors count:   0
Scan Speed:     1.04 files/sec. 7.13 KB/sec.
Initial counts: 5 resource(s): 3 file(s) and 2 directorie(s)
Final counts:   0 resource(s): 0 file(s) and 0 directorie(s)
Timings:
scan_start: 2020-06-19T074247.781296
scan_end:   2020-06-19T074253.331201
setup_scan:licenses: 2.59s
setup: 2.59s
scan: 2.87s
total: 5.56s
Removing temporary files...done.
it hangs at the above message
And memory consumption keeps growing slowly, OOM eventually.
 Could you maybe confirm that https://github.com/oss-review-toolkit/ort/pull/2748 fixes the issue for you?

@BennyThink the change is now in master for you to verify. If the original issues still appears, please reopen this ticket.

Thanks! It works!


Error in nginx: [emerg] socket() [::]:8000 failed (97: Address family not supported by protocol)

Support guidelines

[X] I've read the support guidelines

I've found a bug and checked that ...

[X] ... the documentation does not mention anything about my problem
[X] ... there are no open or closed issues that are related to my problem

Description
I'm getting an nginx error
Expected behaviour
working as it should
Actual behaviour
totalt breakdown
Steps to reproduce
update to latest version
Docker info
Client: Docker Engine - Community
 Version:    26.1.3
 Context:    default
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.14.0
    Path:     /usr/libexec/docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.27.0
    Path:     /usr/libexec/docker/cli-plugins/docker-compose

Server:
 Containers: 29
  Running: 28
  Paused: 0
  Stopped: 1
 Images: 39
 Server Version: 26.1.3
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: systemd
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: e377cd56a71523140ca6ae87e30244719194a521
 runc version: v1.1.12-0-g51d5e94
 init version: de40ad0
 Security Options:
  apparmor
  seccomp
   Profile: builtin
  cgroupns
 Kernel Version: 5.15.0-107-generic
 Operating System: Ubuntu 22.04.4 LTS
 OSType: linux
 Architecture: x86_64
 CPUs: 8
 Total Memory: 15.4GiB
 Name: homelab
 ID: 64034960-fb4a-4687-bb99-367046b6ef28
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 Experimental: false
 Insecure Registries:
  <IP_ADDRESS>/8
 Live Restore Enabled: false

Docker Compose config
services:
  geoip-updater:
    image: crazymax/geoip-updater:latest
    container_name: geoip-updater
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Europe/Rome
    networks:
      - rtorrent-rutorrent
    volumes:
      - "/home/mgrsys/rtorrent/geoip:/data"
    env_file:
      - "./geoip-updater.env"
    restart: unless-stopped

  rtorrent-rutorrent:
    image: crazymax/rtorrent-rutorrent:latest
    container_name: rtorrent-rutorrent
    environment:
      AUTH_DELAY: 0s
      LOG_ACCESS: "true"
      LOG_IP_VAR: remote_addr
      MAX_FILE_UPLOADS: "50"
      MEMORY_LIMIT: 256M
      OPCACHE_MEM_SIZE: "128"
      PGID: "1000"
      PUID: "1000"
      REAL_IP_FROM: <IP_ADDRESS>/32
      REAL_IP_HEADER: X-Forwarded-For
      RT_DHT_PORT: "51347"
      RT_INC_PORT: "51348"
      RT_LOG_EXECUTE: "false"
      RT_LOG_LEVEL: info
      RT_LOG_XMLRPC: "false"
      RU_DO_DIAGNOSTIC: "true"
      RU_FORBID_USER_SETTINGS: "false"
      RU_HTTP_TIME_OUT: "30"
      RU_HTTP_USE_GZIP: "true"
      RU_HTTP_USER_AGENT: Mozilla/5.0 (Windows NT 6.0; WOW64; rv:12.0) Gecko/20100101 Firefox/12.0
      RU_LOCALE: UTF8
      RU_LOG_FILE: /data/rutorrent/rutorrent.log
      RU_LOG_RPC_CALLS: "false"
      RU_LOG_RPC_FAULTS: "true"
      RU_OVERWRITE_UPLOADED_TORRENTS: "false"
      RU_PHP_GZIP_LEVEL: "2"
      RU_PHP_USE_GZIP: "false"
      RU_RPC_TIME_OUT: "5"
      RU_SAVE_UPLOADED_TORRENTS: "true"
      RU_SCHEDULE_RAND: "10"
      RUTORRENT_AUTHBASIC_STRING: ruTorrent restricted access
      RUTORRENT_PORT: "8080"
      TZ: Europe/Paris
      UPLOAD_MAX_SIZE: 16M
      WAN_IP_CMD: dig +short myip.opendns.com @resolver1.opendns.com
      WEBDAV_AUTHBASIC_STRING: WebDAV restricted access
      WEBDAV_PORT: "9000"
      XMLRPC_AUTHBASIC_STRING: rTorrent XMLRPC restricted access
      XMLRPC_PORT: "8000"
    networks:
      - rtorrent-rutorrent
    expose:
      - 51347/udp
      - "8000"
      - "8080"
      - "9000"
      - "51348"
    ports:
      - target: 51347
        published: "51347"
        protocol: udp
      - target: 8080
        published: "8080"
        protocol: tcp
      - target: 9000
        published: "9001"
        protocol: tcp
      - target: 51348
        published: "51348"
        protocol: tcp
    volumes:
      - "/home/mgrsys/rtorrent:/data"
      - "/home/mgrsys/download:/downloads"
      - "/home/mgrsys/rtorrent/passwd:/passwd"

    ulimits:
      nproc: 65535
      nofile:
        soft: 32000
        hard: 40000
    stop_grace_period: 300s
    restart: unless-stopped

  rtorrent-logs:
    image: bash
    container_name: rtorrent-rutorrent-logs
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Europe/Rome
    command: bash -c 'tail -f /log/*.log'
    network_mode: none
    depends_on:
      - rtorrent-rutorrent
    volumes:
      - "/home/mgrsys/rtorrent/rtorrent/log:/log"
    restart: unless-stopped

networks:
  rtorrent-rutorrent:
    name: rtorrent-rutorrent
    external: true

Logs
[s6-init] making user provided files available at /var/run/s6/etc...exited 0.

[s6-init] ensuring user provided files have correct perms...exited 0.

[fix-attrs.d] applying ownership & permissions fixes...

[fix-attrs.d] done.

[cont-init.d] executing container initialization scripts...

[cont-init.d] 00-fix-logs.sh: executing...

[cont-init.d] 00-fix-logs.sh: exited 0.

[cont-init.d] 01-fix-uidgid.sh: executing...

[cont-init.d] 01-fix-uidgid.sh: exited 0.

[cont-init.d] 02-fix-perms.sh: executing...

Fixing perms...

[cont-init.d] 02-fix-perms.sh: exited 0.

[cont-init.d] 03-config.sh: executing...

Setting timezone to Europe/Paris...

Setting PHP-FPM configuration...

Setting PHP INI configuration...

Setting OpCache configuration...

Setting Nginx configuration...

Setting Nginx XMLRPC over SCGI configuration...

Setting Nginx ruTorrent configuration...

Setting Nginx WebDAV configuration...

Update healthcheck script...

Initializing files and folders...

rpc.htpasswd is empty, removing authentication...

rutorrent.htpasswd is empty, removing authentication...

webdav.htpasswd is empty, removing authentication...

Checking rTorrent local configuration...

Checking rTorrent configuration...

Bootstrapping ruTorrent configuration...

Setting custom config for create plugin...

Checking ruTorrent custom plugins...

Checking ruTorrent plugins configuration...

Checking ruTorrent custom themes...

Setting GeoIP2 databases for geoip2 plugin...

Fixing perms...

[cont-init.d] 03-config.sh: exited 0.

[cont-init.d] 04-create-services.sh: executing...

[cont-init.d] 04-create-services.sh: exited 0.

[cont-init.d] ~-socklog: executing...

[cont-init.d] ~-socklog: exited 0.

[cont-init.d] done.

[services.d] starting services

[services.d] done.

2024/05/23 08:22:22 [emerg] 512#512: socket() [::]:8000 failed (97: Address family not supported by protocol)

nginx: [emerg] socket() [::]:8000 failed (97: Address family not supported by protocol)

[23-May-2024 08:22:22] NOTICE: fpm is running, pid 515

[23-May-2024 08:22:22] NOTICE: ready to handle connections

2024/05/23 08:22:23 [emerg] 573#573: socket() [::]:8000 failed (97: Address family not supported by protocol)

Additional info
No response

I found the problem. I had ipv6 disabled in GRUB, once reactivated it works. How can I make it work with ipv6 disabled?

I wonder if this is related to recent changes in Docker 26.1 with IPv6 (cc @robmry)

I wonder if this is related to recent changes in Docker 26.1 with IPv6 (cc @robmry)

One change we made is to not-disable IPv6 on the loopback interface just because a container isn't (yet) connected to an IPv6-enabled network. But, if the kernel hasn't added a ::1 to the loopback interface in the first place, we take that as a signal that IPv6 is disabled on the host, or for the container using --sysctl net.ipv6.conf.all.disable_ipv6=1, or similar. We shouldn't be doing anything to try to enable IPv6 at that point.
Is there anything in the nginx config that's explicitly enabling IPv6 or asking it to listen on ::? From a glance at the project's Dockerfile, I think this is nginx installed in an alpine container ... I just tried that with IPv6 disabled in the container, and nginx started, even with listen [::]:80 default_server; left in its default config - but perhaps disabling IPv6 in the kernel would be different.

This is related to the nginx software. I submitted a pull request to resolve the problem. There's no reason to support IPV6 on the  in the first place. IPV6 support was never properly tested and added to rTorrent. IPV4 is required to use the docker container.

Ah right that makes sense and indeed no need to enable IPv6 within the nginx conf explicitly.


[Backend] Implement Like/Dislike Functionality for Snippets

As a developer, I want to create an rpc to handle user interactions with snippets (like/dislike) and update data retrieval functions to reflect these interactions, so that the application can dynamically manage snippet visibility based on user feedback.
Tasks:

Create RPC Function:

Develop an RPC function like_snippet(snippet_id, value) in Supabase.

snippet_id is the identifier for the snippet.
value should be 1 for like, -1 for dislike, and 0 for neutral (removing like/dislike).

Update Data Retrieval Functions:

Modify get_snippets and get_snippet functions to include a user_like_status for each snippet.

user_like_status should reflect the current user's like/dislike status for each snippet.

Implement Snippet Visibility Logic:

Ensure that snippets disliked by at least 2 users are excluded from the feed.

Acceptance Criteria:

The like_snippet RPC function should correctly update the like status of a snippet for a user.
The get_snippets and get_snippet functions should return snippets with a user_like_status field that accurately reflects the logged-in user's interaction with each snippet.
Snippets that have been disliked by at least 2 users should not appear in the user's feed.
All database operations should be efficient and handle edge cases (e.g., multiple updates, concurrent requests).

Notes:

Ensure that changes are backward compatible with the existing feed logic.
Consider edge cases where users might like/dislike a snippet, then change their interaction.
Test thoroughly with various scenarios, including different user interactions and database states.

https://github.com/PublicDataWorks/verdad/commit/a5c0df05165317202e92861aaa3ab2acb6ebe345
https://github.com/PublicDataWorks/verdad/commit/7ab952d47a7ae42bda302f41aefc669ac4be2a36


Informational tooltips

Lack of documentation on the site is leading to confusion, need some tooltips to explain the purpose of toggles and other things.

some of these are now in #33 . Could use some feedback to see if they are worded well.


Add generate_bosh_manifest script

Right now we generate manifest and deploy BOSH director immediately.  In some cases, developer needs to do some customizations to the manifest prior to deployment.
Acceptance:

generate_bosh_manifest and save it to file
Apply bosh_deployment/local_bosh_release.yml ops-file with BOSH director release with version that differs from generated one (e.g. 262)
Deploy BOSH using bosh-cli create-env
bosh-cli env  should show that you are using provided BOSH release

@alejandrogoyen this repo should not have any scripts about generating director manifest. at the most i would say it should link to appropriate bosh.io docs or bosh-deployment.

we should also remove bosh-deployment sub directory out of this repo.

Closing, as there is no direct business need.


How often is file count updated?

I tried the following: I deleted an image and subsequently moved it back to the Pictures folder.
When the image was deleted, the image count was immediately reduced by one. When I added it back, it stayed at the lower number. Only when I hit e.g. "directories" in Home Assistant was updated to the correct number.

In Home Assistant all attributes are updated on image change. But from memory I can't tell, when it's internally updated.

Looking at the code, it looks like the image count is updated only when the "playlist" is rebuilt from the image_cache. That happens based on a number of different situations.
Related, what is the image counter intended to represent? On the surface, I'd expect it to be the count of images in the Pictures folder. However, it looks like it's a count of the items in the internal playlist. So, a set of paired portraits would only count as 1 it seems. So, if my Pictures folder consisted of only 12 portrait images and they were all paired together, I think the image counter would report 6.

It is indeed the count of the items in the internal playlist - which is great because when you set a filter in Home Assistant you can immediately see, how many images correspond to that query.

I only have landscape images, so in my case, the number is the same.

It is indeed the count of the items in the internal playlist - which is great because when you set a filter in Home Assistant you can immediately see, how many images correspond to that query.

My point is though, with paired portraits, it won't be as you describe above (at least I don't think so from looking at the code). If your filter returned 12 images that were all paired together into 6 displayed "frames", would you expect the image count to be 12 or 6? I think it'd be 6 in that case...
I guess either is arguably correct. You would see 6 individual frames displayed, but they'd be made up of 12 images. I'd think 12 would be the more expected result here.

I guess we would just have to make it clear what the playlist count is. One could argue that either way is "correct".

My preference would be that the image count be the number of images, not the number of display screens.  (With my photographer hat on, I think in terms of the images I've created, rather than how they might displayed on screen.)  So, 12 in @jgodfrey example above, not 6.  And I agree with Wolfgang that it's very handy to see how many images correspond to a given set of filters; it's a great feature.

Getting the number of images would be a simple alteration. However the deletion is a bit woolly when dealing with picture pairs, i.e. the left picture only is moved in the file system but the tuple with both db refs is removed from the list. Not sure if anything more intelligent is feasible.

I think it's fine as it is with all images in a playlist being counted. The question was just about the update frequency but I guess as soon as the filter is changed, a new image will be counted.

The function just needs changing like this
    def get_number_of_files(self):
        #return self.__number_of_files
        return sum(1 for pics in self.__file_list for pic in pics if pic is not None)
        # or, logical to my mind
        #return sum(sum(1 for pic in pics if pic is not None) for pics in self.__file_list)

The value this method returns will change the instant the image is deleted but, as Jeff says, there is no mechanism in Model now to check for changes to the db that are not reflected in the last selection (as I think used to happen in PictureFrame2020) Maybe this needs to be added?


DBZ-789 Expose more granular snapshot metrics via JMX

https://issues.jboss.org/browse/DBZ-789
Exposing new snapshot metric:
Map containing tableName -> Rows Scanned

@gunnarmorling Sure, I will add a PR for the docs!

Thanks, @pgoranss!
@jpechane I think there's no big risk associated to this change, so I'd vote for merging this now and releasing it as part of the Final, also if we are after CR1 at this point. WDYT?

@gunnarmorling It looks pretty non-invasive so I think it can go in

Rebased and applied. Thanks a lot, @pgoranss!


Please update the document for newer version like 1.19.11

Please update the document for newer version like 1.19.11
Different data is shown in newer and supported versions.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eee999c1-32dd-d014-40df-8027adee1258
Version Independent ID: 19a29c09-79f8-580a-841f-873e2801da56
Content: Integrate Azure Key Vault with Kubernetes
Content Source: articles/key-vault/general/key-vault-integrate-kubernetes.md
Service: key-vault
Sub-service: general
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@porrascarlos802018
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

@porrascarlos802018 AKS implemented new version of CSI driver with Azure Support. We deprecated old key vault tutorial, please check new guide provided by AKS team here:
https://docs.microsoft.com/en-us/azure/aks/azure-disk-csi
If there are any issues, please create item on their documentation.
#please-close


Setting the car current charge rate (with fleet mode) throws an exception

Is there an existing issue for this?

[X] I have searched both the existing open issues & recently closed issues and did not find a duplicate of this issue.

I have read about the Fleet API and understand I may need to use it

[X] I understand issues relating to read only commands will be auto closed if not using the Fleet API.

Version of the Tesla component
2024.5.5
Version of the Tesla car software
2024.8.9
Model
Model Y
Current Behavior
I have set up the fleet mode API. It was very painful!
Up until the most recent version I could happily set the charge current current using
service: number.set_value
metadata: {}
data:
    value: "14"
  target:
    entity_id: number.lightning_charging_amps

now I get a TeslaException thrown
Expected Behavior
Charge rate is set, exception isn’t throw
Debug logs
Logger: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/commands.py:239
integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 22:25:32 (2 occurrences)
Last logged: 22:25:36

[2607083368] Unexpected exception
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 239, in handle_call_service
    response = await hass.services.async_call(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2738, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2779, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 975, in entity_service_call
    single_response = await _handle_entity_call(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 1047, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/number/__init__.py", line 116, in async_set_value
    await entity.async_set_native_value(native_value)
  File "/config/custom_components/tesla_custom/number.py", line 49, in async_set_native_value
    await self._car.change_charge_limit(value)
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 820, in change_charge_limit
    data = await self._send_command(
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 775, in _send_command
    raise ex
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 760, in _send_command
    data = await self._controller.api(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1367, in api
    response = await self.__post_with_retries(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 142, in async_wrapped
    return await fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 58, in __call__
    do = await self.iter(retry_state=retry_state)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 110, in iter
    result = await action(retry_state)
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 78, in inner
    return fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/__init__.py", line 410, in exc_check
    raise retry_exc.reraise()
          ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/__init__.py", line 183, in reraise
    raise self.last_attempt.result()
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 449, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 61, in __call__
    result = await fn(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1390, in __post_with_retries
    return await self.__connection.post(command, method=method, data=data, url=url)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/connection.py", line 166, in post
    return await self.__open(url, method=method, headers=self.head, data=data)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/connection.py", line 218, in __open
    raise TeslaException(resp.status_code)
teslajsonpy.exceptions.TeslaException

Anything else?
No response

May be related
In the proxy logs I can see lots of logs for error 429 too many requests.
It looks like something is calling /api/1/product a lot, much more than the 11m I have set as my polling interval.

The proxy logs have a lot of messages, these seem like a retry and a failure
Retrying transmission after error: Post "https://fleet-api.prd.eu.vn.cloud.tesla.com/api/1/vehicles/MYCARiD/signed_command": context deadline exceeded
2024-05-26T21:47:22Z [error] Returning error Internal Server Error

Hi, saw the same error, which brought me to the quota limitations. See issue #961 ?

Anytime you get a generic teslajsonpy.exceptions.TeslaException in the log, there should be a more meaningful error message logged at debug level.  See #935.  But here it sounds like you've already identified it as a rate limit.
This integration polls the vehicle every 10 seconds.  See this comment and link: https://github.com/alandtse/tesla/issues/961#issuecomment-2125941275

Having the same issue. Is this using the old API https://github.com/alandtse/tesla/issues/231 or can it be a solution?


Fix sizing of breadcrumbs to make breadcrumbs size appropriate

Description
Spectrum-CSS uses an alias value that is undetected by Parliament UI library, which causes no height and width to be set for the chevron icons. This change enforces the chevrons to be a certain height and width.
Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Before

After

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

retest

Do you think this is an opportunity to actually switch to the RSP v3 Breadcrumbs component? It's a little bit cumbersome having to deal with SVG paths and stuff, I think.

@solimant I think this is a great idea! Will update the PR accordingly


Added basic tests for asset loaders (#6964)

Objective
Add basic tests for image / gltf asset loading. As a start for #6964.

Can you also add a final test that asserts that all of the images from each of the formats match?

I don't think this will work. Given that different image formats have different compression algorithms, the loaded images are not guaranteed to be equal.

This is cool! Rather than close this one, I'm nabbing it for myself to get it the rest of the way :laughing:


Test for ats version when building remap - switch cachekey/url

Currently when building the remap line we always use the cacheurl plugin and the generic cacheurl_qstring.config file if qstring_ignore=1.  This needs to be changed for ATS >=6 to use cachekey since starting with ATS 7 we no longer have the cacheurl plugin.
Tested this on my dev environment and could see the remap output changing based on my hardcoded default value when it was not assigned in the server info.  This will need more testing with a prod-type environment

Can one of the admins verify this patch?

Can one of the admins verify this patch?

this looks fine to me but you might want to have @dg4prez take a look at it as well.

The config generation side looks good.  I've spoken with Evan who will be taking point on the staging and lab testing to ensure that these settings do not cause problems with ATS in production.


JIRAError doesn't include message. .text will provide the content.

(resubmitting to dev)
Based on the JIRA docs there's no .message attribute on the JIRAError Exception. This was causing an error if the request failed. Changing this to .text will provide the content of the error.
https://jira.readthedocs.io/en/master/_modules/jira/exceptions.html

thanks, you seem to have included some semgrep changes by accident :-)
I remember we did some changes around this JIRAError recently to make it work. Not sure if we went from .text to .message or the other way around. Or that we messed up a merge and lost our earlier fix.

thanks, you seem to have included some semgrep changes by accident :-)
I remember we did some changes around this JIRAError recently to make it work. Not sure if we went from .text to .message or the other way around. Or that we messed up a merge and lost our earlier fix.

Yea, that's the only change in this MR. The Semgrep rules also have an issue when the CWE isn't supplied in the json output, I'm looking at a nice fix for that too, but I'll just close this MR so you don't have to pull in the other mistaken changes.

Yea, that's the only change in this MR. The Semgrep rules also have an issue when the CWE isn't supplied in the json output, I'm looking at a nice fix for that too, but I'll just close this MR so you don't have to pull in the other mistaken changes.


fix/15300: Report item remains hovered even when mouse is moved away from it

Details

The MiniReportActionContextMenu disappears as soon as we right-click, which causes the Hoverable's onMouseLeave to not trigger. Consequently, the Hoverable remains in the "hovered: true" state. To resolve this issue, we must eliminate the condition that checks whether the isContextMenuActive is present when opening MiniReportActionContextMenu.
Fixed Issues

$ https://github.com/Expensify/App/issues/15300
$ https://github.com/Expensify/App/issues/15300#issuecomment-1438471427
Tests

Hover over a message other than the first one in a group of messages in the chat history (i.e any message that does not have the author avatar alongside it).
Move the cursor to the mini context menu (top right corner).
Right-click on the mini context menu.
Close the big context menu by clicking anywhere outside the highlighted row.
Verify that the above mini context menu is disappeared

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Hover over a message other than the first one in a group of messages in the chat history (i.e any message that does not have the author avatar alongside it).
Move the cursor to the mini context menu (top right corner).
Right-click on the mini context menu.
Close the big context menu by clicking anywhere outside the highlighted row.
Verify that the above mini context menu is disappeared

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/113963320/221216993-728e9397-25cd-455d-8d6e-b24c01959aeb.mp4

Mobile Web - Chrome

https://user-images.githubusercontent.com/113963320/222327727-538ce797-af50-42ff-a27c-67327e0b4579.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/113963320/221216974-ee01252a-8130-4991-b027-3ec7efe8e48f.mp4

Desktop

https://user-images.githubusercontent.com/113963320/221216911-f2f1d358-7e88-40ca-9953-48ea386c4471.mp4

iOS

https://user-images.githubusercontent.com/113963320/221216899-3c419a13-0837-4ba6-8b94-d870ce513a2c.mp4

Android
https://user-images.githubusercontent.com/113963320/221216806-4c8e56e9-9833-48fa-9744-cd1f5797a110.mp4

@yuwenmemon @aimane-chnaif One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Hi @aimane-chnaif @yuwenmemon, the PR is ready for review. Please help me check it. Thank you!

@yuwenmemon It would be great if you can check the PR when you are available!

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.2.79-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.2.79-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Development walkthrough in CONTRIBUTING.md

Once again, thanks @davidjerleke for creating this wonderful and promising library ✨
My goal in this PR is to thoroughly detail this project in a way that makes it less intimidating for developers who want to contribute to the inner workings of this project. I will continue adding to it every time I get a chance and I will hopefully learn more about the inner workings of this project as I expand on this contribution guide.
@davidjerleke feel free to throw in a commit every now and then to fix things or add sections or even notes that I can tag-team and expand on.
The good thing about MDX is that if this contribution guide becomes too big we can always move it to embla-carouse-docs and break the guide down into multiple sub-pages.

I forgot to remove the commented part, I was separate the bullet-points by the categories of the packages but then realized it makes more sense to list them the same way they're grouped in the folders of this monorepo.
Now that I think about it I think it would be better to make them into a table with a badge next to each package that dynamically shows the size and version (same as the badges of each README.md inside each package)

I was thinking about a versioning section inspired from your comment here but on second thoughts I think that's something maybe contributors shouldn't touch since you might have a specific approach to putting together PRs and deciding when to publish.

This is the publishing process for the packages. Running any of these commands below:
https://github.com/davidjerleke/embla-carousel/blob/01036845655e843e21eac50f28c0e61dab06ed4c/package.json#L51-L53
...will automatically:

Bump the versions of all Embla packages in the entire repository.
Update the yarn.lock file if needed.
Add all file changes and a new tag with the new version to git.
Push the tag and commit to the remote repository.

The publishing part is the only thing that needs manual work. In order to publish I have to manually create a new release on GitHub with the new tag version and hit create release. After that the CD process takes over and automatically publishes all packages to the npm registry if build, test and lint pass.
But at the time of writing, I guess I'm the only one that have the access rights to creating a release.
Best,
David

Sounds great 👍
Although I was wondering more about when a contributor should bump a version. So for example if I make a PR fixing a few lines of codes in one of the packages, would you prefer/recommend I bump a patch version in my commit? Or would that disrupt your flow and you could do a bump as well (without noticing my bump) and we end up with one of the packages version not in-sync with the others?
I could be wrong, but you sometimes do 1 bump for multiple PR's you combine, right?
Overall, if you prefer contributors include do some versioning in PR's then I think we should include it in the CONTRIBUTING.md otherwise, we can just leave out the versioning section.

@zaaakher sorry I misunderstood your question:

I could be wrong, but you sometimes do 1 bump for multiple PR's you combine, right?

That's correct. A new version can include multiple bug fixes or features.

Overall, if you prefer contributors include do some versioning in PR's then I think we should include it in the CONTRIBUTING.md otherwise, we can just leave out the versioning section.

I would prefer not at this stage but very much appreciate you asking 🙂!

@zaaakher great work as always 🥳.


renaming logo file

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

my token logo not displaying properly - https://solscan.io/token/5XYRirwUYbeeMNmiBcw1cZYmMKpwofAt77BxaqLaKWPo
hence raised this pr to updated the logo file name to match the one in the uri - https://github.com/doyoubelieveit/sol/blob/main/token.png


ufbx: Update to 0.14.3

https://github.com/ufbx/ufbx/releases/tag/v0.14.3
Changes from version 0.14.0 to version 0.14.1:

Documentation: Specify result of ufbx_evaluate_transform()

Changes from version 0.14.1 to version 0.14.2:

Fix UFBX_VERSION not matching tagged version

Changes from version 0.14.2 to version 0.14.3:

Fix transform evaluation rotation fast path mirroring
Fixes some broken cases of baking animations when converting handedness

Note that @bqqbarbhg said the handedness fix doesn't affect godot engine.

Thanks!


[SHB] Add classes that extend BaseSchematic for drawing doors and smart devices

We should add a few more clases that extend BaseSchematic for rendering doors and smart devices.
For inspiration you can see class Wall in builder.dart
For now we should implement these two:

Door
SmartDevice

aici


more real .has method?

Before was using has-value(s), now is just typeof val !== undefined
also add hasOwn and union methods?

this approach passed all of the tests of the other .has method, since it was effectively doing the same thing (at least in non-edge-cases).

add hasOwn and union methods?

I was just thinking the same thing about union today - I just refactored base-data and could have used it. we can add union but let me think about .hasOwn. Honestly I almost always use .get because I can get the same answer and use the resulting value if I need it, instead of doing two lookups (.has then .get)

Honestly I almost always use .get

Mm yea, me too. But it's logical to have. I think it can be in help for some users that don't got the things as we got it.

@jonschlinkert ping about the hasOwn and has.


issue with "Do not use 'handle' and 'handlers' together. Your 'handle' value has been overridden with 'handlers'"

In a nutshell - this doesn't make sens(u)e to me -- why was it added to say that if you have handlers, you can't diable the handling of a check?    I think it was added on commit #a9b4089cb3ff7ae28a56b8d6d535478953c8f6b8 but i don't agree with it.    I should accept whatever i tell it to do, and not impose a logic block - at least remove the 'return' there, and issue the warning for 'style' points or something.
https://github.com/sensu/sensu-puppet/blob/master/lib/puppet/provider/sensu_check/json.rb#L179

@countryHick I think this is because the handle attribute used to be used for "handler", but I could be mistaken - it's been a while.  A PR is likely warranted with an update to fix this.

yeah - i'll make one later today methinks -- i've locally done this and works much better, cause now you can handle:false, aggregate:true - and your failed aggregates aren't alerting anymore :)

@countryHick I'm going to try to tag a 2.0 version of this module hopefully later this week.  Do you have a few minutes to do a PR for this?  I think a 2.0 version is the perfect time to correct this.

hopefully - i'll try for today/tonight...
On Mon, Aug 31, 2015 at 9:04 AM, Justin Lambert<EMAIL_ADDRESS>wrote:

@countryHick https://github.com/countryHick I'm going to try to tag a
2.0 version of this module hopefully later this week. Do you have a few
minutes to do a PR for this? I think a 2.0 version is the perfect time to
correct this.
—
Reply to this email directly or view it on GitHub
https://github.com/sensu/sensu-puppet/issues/391#issuecomment-136364852.

@countryHick Does #422 work for you?  I want to close this one out and then am going to tag a 2.0 release finally.

Yep - that's the one