Change OPENSSL_INIT_ATFORK to _NOFORK

Safer by default.

-1 - we should not be flip/flopping on this topic - you changed it back in June - that you had to specifically ask for at-fork handlers

I agree we shouldn't be flip flopping either.
Since this is a new thing, let's try to get it correct.
Given the current usage (reseeding after fork), I think that "best" is on by default (where possible).

FYI, a -1 means the OMC has to vote, unless it's withdrawn.
This is an active development branch, now is the time to make changes based on the public feedback.

Thanks for the info @richsalz
I'll go back into my hole

no don't.  we try to do things in public as much as possible :)

The -1 is just a marker to make sure we hold a discussion on this before moving forward.
When code flip/flops in two directions we need to make sure a broader decision has been made.
I'm not commenting on which is the right approach - just that the flip/flop should trigger a check to make sure we have a consensus on which way is "correct" for going forward.

And I'll say the discussion is happening, actually it has already happened, on openssl-dev

IMO, it seems like reseeding after fork by default is the way to go.

There are a whole range of issues with fork handlers - and registering them can fail - the current code has no checking. And we don't deal with resetting mutex values in the child - which is the purpose of the fork handler infrastructure.
What do we do for non-threaded applications (which can also fork) - we currently ignore those.
So what are we trying to achieve here and should we be doing this by-default?

If built with no-threads then the application will have to do its own fork-handling. If built with threads then the atfork call will be available.  This is all documented in the fork-prepare manpage.

I already suggested that the locks should be taken in the fork handling, but I was ignored.

The fork-prepare documentation is currently wrong - the sentence "Platforms
such as Linux that have both functions will normally not need to call these
functions as the OpenSSL library will do so automatically." does not match the current code - or the rest of the documentation in that file. Basically you got the documentation and the code out of sync.
And it states absolutely nothing about a no-threads build at all - leaving it up to the user who won't have read the documentation to guess at the difference.
Having code automatically activated that is not thread-safe (as noted by Kurt) and has no error handling (as I noted) seems like an unwise choice.
The other way (and cross-platform portable) is when returning output from the RNG to confirm if the thread-id is different and re-seed on-demand if not already re-seeded. There is more than one way to handle this context.
And I still don't see where/why we are dealing with this - what context are we trying to handle here which does a fork-without-exec and how do we expect the threading handling to handle it.
Take a walk through part of many conversations on the topic like https://groups.google.com/forum/#!topic/comp.programming.threads/MeO5Iv78uGg

@kroeckx you weren't ignored; I did it in a lock-free way.

Checking the PID is not cross-platform portable; we used to have "GETPID_IS_MEANINGLESS" for some special cases.
Discussion about this has happened on the mailing list.  Tim, I'd like you to post your reasoning there.

I read the discussion on the mailing list. It wasn't at all conclusive or covered the topics raised.

My point is you wanted a discussion and it's happening.  Please contribute there not here

As long as an other thread can hold a lock when fork() is called you have a problem. From the fork manpage:
The child process is created with a single thread--the one that called fork(). The entire virtual
address space of the parent is replicated in the child, including the states of mutexes, condition
variables, and other pthreads objects; the use of pthread_atfork(3) may be helpful for dealing
with problems that this can cause.

That is why the recommended way to deal with this is to take all global mutex in the prepare function and release them in both the parent and the child.
Please note that we are a library and have no idea how we're going to get used. One thread might just be calling a function that needs to take the lock when the other calls fork() and the child gets into undefined behaviour.

You might also want read: https://linux.die.net/man/3/pthread_atfork

Yes, I read that page and know about forks and locks.  Thanks.
Again, this discussion should happen on the mailing list.  PLEASE

Where do you think there is a relevant discussion occurring? I don't see it.

It's the largest thread on openssl-dev this month :)  Here's one message, https://mta.openssl.org/pipermail/openssl-dev/2017-August/009608.html

I don't remember seeing a resolution here.  I'm leaning in favour of this change, although I'd go further and handle the single threaded fork case as best as is possible (i.e. detect a PID change and reseed, assuming PIDs are meaningful).

I think @kroeckx is taking up the challenge for this issue, but am not positive -- can you reply here?


if statement doesn't work correct

You can use the if helper to conditionally render a block. If its argument returns false, undefined, null, "", 0, or [], Handlebars will not render the block.
JSON
{"A":[{"a":"1","f":"0"}]}
HB
{{#if a}}{{a}}{{/if} // output: 1
{{#if f}}{{f}}{{/if}  // output: 0 WHY?

"0" is not a falsy value, contrary to 0.
Try the following in your javascript-console: if ("0") { console.log("0") }. It will output 0 as well and so does Handlebars.
I expect that {"A":[{"a":1,"f":0}]} will give you the expected result (but I haven't tried)

thanks @nknapp


What icons can I use?

It seems, not all icons from font-awesome can be used (f.e. 'newspaper')

Currently, Font Awesome version 4.7 is included. You can view the icons you can use here. A quick search will show that you can use newspaper-o.


Continue to provide BaseQuery.getJPAQuery() method for backward compat

we provide this method temporarily to avoid sudden compatibility issues with existing clients
this is deprecated and will be removed in Infinispan 10.0

merged to master. Thanks


net/freeradius: add daily session limit feature to FreeRADIUS and GUI

The howto on accounting with FreeRADIUS shows how to setup accounting. The Max-Daily-Session attribute cannot be set, though, in the FreeRADIUS plugin on OPNsense (see section "Add test users" in the howto). This is probably a much sought for feature and I kindly ask to add it.

Sure, no problem. I'm waiting for a few changes to come, after this I'll add it.

Do you want to use the Max Daily attribute with CP? I will add this now but unsure if compatible with CP

Max-Daily-Session should be used with Captive Portal. To make this work as expected, Captive Portal needs to reauthenticate connected users every minute and the admin should set Idle Timeout in Zone to a reasonable value.

Yep, I already have the code, just needs some testing tomorrow :)

@borisneubert Were you able to setup the feature like in the howto described without the plugin?
I get an error when setting a manual attribute via dictionary.

I did not try this before but I did now. I get
Cannot find module "daily"
which seems to come from the daily entry in the instantiate section of radiusd.conf.
Actually, daily is not in mods-available.

Same to me, I think the howto is for a linux version, not the BSD package, but I already got this running.
If there would be a devel-package, would you install and test it, since I don't use CP?

Yes, I like to do so.

If you like to test update to 17.7.8, download a backup, and then via cli pkg remove os-freeradius and then pkg install os-freeradius-devel

remove should be automatic if you install the conflicting package :)

Not via make package and pkg install ...

Did this. freeradius refuses to start, even after reboot and adding time limits in the user management of the captive portal.
radius.log
Thu Nov 23 18:51:47 2017 : Warning: No 'ipaddr' or 'ipv4addr' or 'ipv6addr' field found in client <IP_ADDRESS>/24. Please fix your configuration
Thu Nov 23 18:51:47 2017 : Warning: Support for old-style clients will be removed in a future release
Thu Nov 23 18:51:47 2017 : Info: Debugger not attached
Thu Nov 23 18:51:47 2017 : Error: Cannot find module "daily"

Which version do you have installed?
# pkg info os-freeradius-devel

@mimugmail did you try "make upgrade" ?

root@opnsense:~ # pkg info os-freeradius-devel
os-freeradius-devel-1.3.0
Name           : os-freeradius-devel
Version        : 1.3.0
Installed on   : Thu Nov 23 18:40:25 2017 CET
Origin         : opnsense/os-freeradius-devel
Architecture   : FreeBSD:11:amd64
Prefix         : /usr/local
Categories     : net

Can you do a ls on mods-enabled please?

f*ck .. I forgot to add mods-enabled-counter to +TARGETS :(

opnsense-patch -c plugins d9e4428
Then it should start ...

This did the trick. It started.
Will test actual functionality tomorrow.

This did the trick. It started.
Will test actual functionality tomorrow.

Actual functionality does not work. Set the time limit to 120 (seconds) but have been online for hours now.
I think that is because the captive portal does not try to re-authenticate the user every minute against FreeRadius which is necessary for the portal to know that login is denied.

@AdSchellevis Any idea to this?
I add functionality to the package described like here: https://docs.opnsense.org/manual/how-tos/accounting.html
Were there some changed to the CP reauthenticating to Radius? Since I dont use it I have no idea :)

@mimugmail no time to read the whole thread, but accounting using radius normally works quite simple in CP.
When logged in it will check for restrictions and push them to the captive portal https://github.com/opnsense/core/blob/master/src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api/AccessController.php#L191-L201 then the accounting procedure will start sending accounting pages to radius back using https://github.com/opnsense/core/blob/master/src/opnsense/scripts/OPNsense/CaptivePortal/process_accounting_messages.php which is called from https://github.com/opnsense/core/blob/master/src/opnsense/scripts/OPNsense/CaptivePortal/cp-background-process.py
The main principe is that upfront you know how much time a user can spare, used to keep the session duration for the amount of time reported, then messages are send back to radius so it knows how much is actually spend.
First thing to check is if the session actually gets set with the right end time, if I'm not mistaken you will see this in the session overview, syslog should also have some details on the configd commands executed, including the set of restrictions.

@AdSchellevis thanks, seems I have to setup a test lab at work :)

This is system.log for a successful login to CP with a user with time limit:
Nov 25 13:31:29 opnsense configd.py: [4012472f-8a34-4d54-9bcf-9574f6c26cc6] list registered clients
Nov 25 13:31:48 opnsense configd.py: [1571ba86-771b-44b9-91f4-40f812eb33c5] list registered clients
Nov 25 13:31:48 opnsense configd.py: [4413cd22-97c1-4381-b732-d1018398fcd3] allow client access to captive portal

Session overview in UI shows only Username | MAC address | IP address | Connected since.
portalauth.log has
Nov 25 13:31:48 opnsense captiveportal[82743]: AUTH neubert (<IP_ADDRESS>) zone 0
Any place else where to look for session details?

I expect the radius session is missing a session timeout, which sets session_timeout in https://github.com/opnsense/core/blob/17.7.7/src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php#L397
A log line containing set extra restrictions for session (%s) %s is missing

@borisneubert please try opnsense-patch -c plugins 18e4e8d
It works in my test lab.
@AdSchellevis Max-Daily-Session has to be in the first line of the username, that's all :)

@mimugmail It works!
Wed Nov 29 13:34:13 2017 : Auth: (0) Login OK: [neubert/password] (from client Captive Portal port 0)
Wed Nov 29 13:38:04 2017 : Auth: (24) Invalid user (daily: Maximum daily usage time reached): [neubert/password] (from client Captive Portal port 0)
Wed Nov 29 13:38:04 2017 : Auth: (24) Login incorrect (daily: Maximum daily usage time reached): [neubert/password] (from client Captive Portal port 0)

The captive portal login shows "Authorization failed". Would it be possible to show the reason as well?

@borisneubert This is way over my skills, perhaps @AdSchellevis or @fichtner have an idea or a quick fix for this.
@fichtner So Freeradius 1.3.1 can go to next stable ..


feat(deps): upgrade compiler dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-compiler-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1631

Questions ?
Please refer to the Backport tool documentation


Remove the bytecode / interpreter machinery and use the serde API directly

First of all, thanks for this crate!
Secondly, sorry for opening an issue to ask a question - I couldn't find a "discussions" section.
Disclaimer: I don't know much about building arrow values but I do know serde very well - I'm considering using this crate for transcoding from avro to arrow but I'm wondering about the performance implications of the intermediate-event-stream representation.
Why the interpreter and event stream intermediate representation instead of just pushing in arrow vectors directly from your impl Serializers? (Isn't it possible to "just push to arrow vectors"?) Is that a performance improvement? If so, why does that improved performance (compared to the alternative below)? Doesn't that prevent e.g. copying the &strs provided by the Serialize implementor directly in their appropriate buffer and instead require extra allocation? (Event::Str("1970-01-01T00:00:00Z").to_owned(),)
Basically my question is: why not something along those lines:
struct Field {
	name: &str,
	serializer: FieldSerializer,
}
enum FieldSerializer {
	Int4(SerializeFieldToInt4Array),
	// ... other array types and/or handling - basically everything that's specific to this field
}
struct ArrowSerializer {
	fields: &mut [Field],
}
impl Serializer for ArrowSerializer {
	fn serialize_map(self, len: Option<usize>) -> Result<ArrowSerializeMap> {
		Ok(ArrowSerializeMap { fields: (&mut *self.fields).iter_mut() }) // reborrow might be necessary
	}
}
struct ArrowSerializeMap {
	fields: std::slice::IterMut<Field>,
}
impl SerializeMap for ArrowSerializeMap {
	fn serialize_entry(&mut self, key: impl Serialize, value: impl Serialize) -> Result<...> {
		let field: &mut ... = self.fields.next();
		// Possibly check field name based on key, or opt out as suggested in #92

		// Then pick the serializer for this type.
		// With a 0-based enum discriminant without holes on FieldArray this should
		// be compiled into a jump table by the compiler, so O(1).
		match field.serializer {
			Type::Int4(serializer) => {
				value.serialize(serializer) // reborrow
			}
			// ... other types
		}
	}
}
struct SerializeFieldToInt4Array {
	array: AvroMutableArrayOfInt4,
}
impl Serialize for &mut SerializeFieldToInt4Array { // Note the &mut here
	fn serialize_i32(value: i32) -> Result<...> {
		self.array.push(value);
	}

	// Most other input types are incorrect for this arrow output type
	serde_serializer_quick_unsupported::serializer_unsupported! {
		err = (<Self::Error as serde::ser::Error>::custom("Unsupported type for arrow Int4 array"));
		bool i8 i16 i64 u8 u16 u32 u64 f32 f64 char str bytes none some unit unit_struct
		unit_variant newtype_struct newtype_variant seq tuple tuple_struct tuple_variant map struct
		struct_variant i128 u128
	}
}

(I've achieved x10 performance on avro serialization compared to apache-avro implementation specifically by removing the intermediate representation they have which is why at first glance I'm surprised by this, but I don't know arrow well.)
Thanks a lot ❤

Thanks for raising this issue :). The reasons are mostly historic ones. I agree that replacing the event stream abstraction with direct serialization makes sense. I simply did not get around to actually implement it.
I don't think there is a factor 10x on the table table, though. At most 4x - 5x (see benchmarks). I believe arrow2-convert to be close to hand-rolled implementation. Due to the dynamic nature of serde-arrow, I would expect it be to closer to 2x.  The data is fully handled at runtime and there is a perfomance gap associated with that that simply cannot be closed.
To explain the history: this crate is my first exposure of interacting with the serde API and I found it easier to conceptualize the underlying data model mismatch by thinking of it in terms of a pseudo JSON format. The JSON format example of the serde docs makes it then really easy to get started down this road. Initially the events were properly matrialized (e.g., there were actual Event instances exchanged). However, currently most communication is handled via accept_XX methods and the events are not constructed as objecs (hence also there is no copying of Strings).
To handle the events I ended up with a depply nested state machines (e.g., for List > Struct > Struct > List > Struct) and performance was not great :D. The bytecode implementation is a way to flatten the state machine. Its introduction resulted in approximately a 3x - 4x performance gain.
By removing the underlying event model, I agree it would be possible to forgo the whole state machine and to use the call stack instead. Hopefully giving another performance boost.

I implemented everything required to execute benchmarks (90 % sure the resulting buffers are filled correctly :D). The results are a speed up of aprox. 2x. (1.81 for complex types, 2.12 for simple types):
complex_common_serialize(1000000)

label
time [ms]
arrow2_convert
serde_arrow_ng
serde_arrow
arrow

arrow2_convert
695.25
1.00
0.40
0.22
0.14

serde_arrow_ng
1745.76
2.51
1.00
0.55
0.36

serde_arrow
3152.74
4.53
1.81
1.00
0.65

arrow
4873.73
7.01
2.79
1.55
1.00

primitives_serialize(1000000)

label
time [ms]
arrow2_convert
serde_arrow_ng
serde_arrow
arrow

arrow2_convert
136.05
1.00
0.47
0.22
0.10

serde_arrow_ng
290.84
2.14
1.00
0.47
0.21

serde_arrow
617.97
4.54
2.12
1.00
0.45

arrow
1373.00
10.09
4.72
2.22
1.00

The next steps will be to switch the internal test suite to the new serializer and then squash test errors one by one. I would expect progress the next couple of weeks to be a bit slower though.

Amazing! Congratz!

Not sure how urgent this feature is for you. I defintely would like to touch up some more details before cutting a proper release. But I could do a pre-release for you to test, if that helps.

thanks again for pointing me into this direction. The result is now approx 2x performance, -3000 lines of code, and, I beliefe, a much easier to understand impl :)

Your open-mindedness and reactivity made that an absolute pleasure 😊

I defintely would like to touch up some more details before cutting a proper release. But I could do a pre-release for you to test, if that helps.

Don't mind me, I'll just point to github in the meantime. 😊

I cut a pre-release after all for my own package using serde_arrow :)
https://crates.io/crates/serde_arrow/0.10.0-rc.1


Added onError for claim and redeem/burn modals

What does this PR do and why?
Fixes - https://github.com/jbx-protocol/juice-interface/issues/1684
The initial problem was that when the user is trying to redeem tokens and if the transaction is canceled, spinner is loading infinitely.
This was also the case when the user is trying to claim tokens or burn tokens, so I applied the same logic in that modal as well.
Screenshots or screen recordings
For testing purposes, I have disabled validation checks so I can test them easily.
I have tested on Burn and Claim modal, Redeem is in the same file as Burn, they are using the same function to execute transactions so, therefore, the same behavior is going to be there.
https://user-images.githubusercontent.com/18723426/186086784-fc7dba2f-ed75-4021-acfd-b80b6123c80b.mov
Acceptance checklist

[x] I have evaluated the Approval Guidelines for this PR.
[x] I have tested this PR in all supported browsers.
[x] I have tested this PR in dark mode and light mode (if applicable).

I've applied the logic that we talked about above, feel free to review @wraeth-eth  or @johnnyd-eth

Hey @NakedFool,
This was a great catch.
We have this problem though out the app, I've been working on fixing a bunch of them. Definitely appreciate the 👀, additionally if you wanna help me fix a bunch of these UX bugs I could use the help.
We have a pattern now that's a little more straight forward, and doesn't involve changing too much code:
https://github.com/jbx-protocol/juice-interface/pull/1755/files -- what the pattern should look like moving forward.
Get out of the pending state: https://github.com/jbx-protocol/juice-interface/blob/cancelling-redeemTx-keeps-loading/src/components/Project/ProjectToolsDrawer/TransferOwnershipForm.tsx#L33 all you'd need to do is just set the state on the onError callback fn.

Hey @NakedFool,
This was a great catch.
We have this problem though out the app, I've been working on fixing a bunch of them. Definitely appreciate the 👀, additionally if you wanna help me fix a bunch of these UX bugs I could use the help.
We have a pattern now that's a little more straight forward, and doesn't involve changing too much code:
https://github.com/jbx-protocol/juice-interface/pull/1755/files -- what the pattern should look like moving forward.
Get out of the pending state: https://github.com/jbx-protocol/juice-interface/blob/cancelling-redeemTx-keeps-loading/src/components/Project/ProjectToolsDrawer/TransferOwnershipForm.tsx#L33 all you'd need to do is just set the state on the onError callback fn.

Yo @benschac
I wanted to go with a similar approach but @wraeth-eth said above to me that it is not good to change transactor logic for now since it is called in many places which makes sense.
However, since your PR tackle all places in which the transactor is being called, making those changes there makes sense and I'm more than happy to help you out with that. It looks to me like that PR is closed now. in any case I'd like to work with you on this stuff :)
Maybe this PR is in a good state to merge as it is now, then when we are finished with the PR you linked it will replace the current logic.

My bad, I sent you the wrong link of the pattern we use today.
This is the pattern that we use today: https://github.com/jbx-protocol/juice-interface/blob/1ee4f8db276c80610652ed919a55a385989672ab/src/hooks/v2/transactor/TransferProjectOwnershipTx.ts
Moving forward, I was going to use a try catch block. But, that doesn't really matter for this. The other link I sent yesterday you can ignore.
You don't need to change the transactor code, just the hook that's calling the transactor, like TransferProjectOwnershipTx
then add the on error callback in the hook call https://github.com/jbx-protocol/juice-interface/blob/cancelling-redeemTx-keeps-loading/src/components/Project/ProjectToolsDrawer/TransferOwnershipForm.tsx#L33

My bad! I sent you the wrong link of the pattern we use today.
This is the pattern that we use today: https://github.com/jbx-protocol/juice-interface/blob/1ee4f8db276c80610652ed919a55a385989672ab/src/hooks/v2/transactor/TransferProjectOwnershipTx.ts
Moving forward, I was going to use a try catch block. But, that doesn't really matter for this. The other link I sent yesterday you can ignore.
You don't need to change the transactor code, just the hook that's calling the transactor, like TransferProjectOwnershipTx
then add the on error callback in the hook call https://github.com/jbx-protocol/juice-interface/blob/cancelling-redeemTx-keeps-loading/src/components/Project/ProjectToolsDrawer/TransferOwnershipForm.tsx#L33

Gotcha, yeah I was a bit confused 😸
I'll apply it the way you are doing then and if you need a hand with other stuff just let me know and I'll be happy to help you 🤙

@benschac Hmm i think we have one problem here, it is because we are using TransactionModal in these files that I'm applying.
Thing is, but you may know this is that we need transactionPending to be true while it is in onDone callback, with the approach above I would need to set false in onDone in order for the modal to disappear since it is first going into onError and then into onDone but that's not nice since if we have successful transactions we wouldn't display pending modal then 😿
wdyt? am I missing something here? I think main difference between examples you provided from files and mine ones are that I'm having a transaction modal here and I need to follow that state.

we need transactionPending to be true while it is in onDone callback
I think that's a bug.

Made an example of what I'm talking about, handling both API and missing parameter errors and pending states.
https://github.com/jbx-protocol/juice-interface/pull/1845/files
What I'm suggesting is following the pattern of callback functions in the hooks to both trigger an error toast, and control pending states, like the claim button pending state in modal.

Following up from discord. Your implementation works as expected with the pending modal shown after the claim button is  fixed.
I think there's a bug in the transactor where the pending transaction modal is being dismissed.

Following up from discord. Your implementation works as expected with the pending modal shown after the claim button is fixed.
I think there's a bug in the transactor where the pending transaction modal is being dismissed.
Ignore my comments. Sorry about the back and forth.

Responded in discord but will add here too, so it looks like we need to adjust transactor in order to make things flow easily across many components.
I will take a look!

Cross post from discord: https://discord.com/channels/939317843059679252/1012735432515129446/1013077786031829082

Cross post from discord: https://discord.com/channels/939317843059679252/1012735432515129446/1013077786031829082

@benschac can you review this one more time when you have a chance ser? 🍻

I had to quick questions:

It looks like public/vendor/desmos/calculator.min.js was related to a different PR / might have got mixed into this PR accidently. Could you remove it? Additionally, not sure how big of a deal it is cc: @wraeth-eth @johnnyd-eth

For testing purposes, I have disabled validation checks so I can test them easily.
I have tested on Burn and Claim modal, Redeem is in the same file as Burn, they are using the same function to execute transactions so, therefore, the same behavior is going to be there.

Could you give Redeem a test too? / Screen Shot?
Also, @wraeth-eth, didn't mean to take over / step on toes. I was looking at the transactor code a bit and thought I could add some context 😅.

@NakedFool checking in on this one. Can I help with anything to get this merged?

@NakedFool checking in on this one. Can I help with anything to get this merged?

code-wise, everything is good; we only need to be sure we need this calculator.min.js merged with this PR, or we should delete it.

@NakedFool ah good catch, no, there shouldn't be a diff there. I've removed it and merged in the latest main. Will do a final review now and merge 💪

@NakedFool just one last comment!

@NakedFool just one last comment!

I've updated the branch with the latest changes, take a look when you have a chance! <3


Improve memory efficiency of TransformersTokenizer by buffering encodings

Description
Fixes #253
Did not add tests as the code runs as part of the tests
and the addition is an internal function to the class
Checklist

[x] Added link to Github issue or Trello card
[ ] Added tests

 Train CNN with TransformerTokenizer that will result in smaller vocabulary and thus smaller model

Codecov Report

Merging #255 (002027d) into main (5f31fac) will decrease coverage by 0.24%.
The diff coverage is 61.90%.

@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   85.65%   85.40%   -0.25%
==========================================
  Files          41       41
  Lines        2237     2254      +17
==========================================
+ Hits         1916     1925       +9
- Misses        321      329       +8

Impacted Files	Coverage Δ
wellcomeml/ml/transformers_tokenizer.py 83.75% <61.90%> (-8.32%)	⬇
Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f31fac...002027d. Read the comment docs.

at least codecov worked #251. Still not sure when it is being picked up and when not.

LGTM. So you are clearing texts_batch every 1000 iterations so it doesn't keep in memory. Good idea!

exactly, I have written that buffering logic so many times by now, maybe I should make it a package


remove mention of chrono 0.3.1, update UTC case

fixes #20

If you wouldn't mind, could you change the todomvc demo to also use the unyanked version of chrono? If you don't within a day or two I'll just merge this and do it myself, but if you feel like it, it would be great :)

Yup, I'll do that today.

I pushed up a commit but am having trouble building/running the todomvc example to test the changes.


Add PurlDB matching step to Java pipeline

When analyzing a whole Java application, an early step in the pipeline is to lookup all the .jar and .war files in the PurlDB with an exact match (like a SHA1)
The output should be to create DiscoveredPackage in the project.
When this takes in the context of the develop_to_deploy pipeline, this step should only occur on the "To" side of the codebase.
This does not replace the develop to deploy mapping.

Implemented in https://github.com/nexB/scancode.io/pull/666


TPM values do not add up to 1 million; coverage and TPM values do not add up.

3 transcripts were identified in a sample. Their TPM values add up to ~546,000 and not 1 million like I would expect.
stringtie -p 16 -j 10 -c 10 -s 10 -o output.stringtie.gtf input.Aligned.sortedByCoord.out.bam
StringTie version 2.0
gene_id "STRG.1"; transcript_id "STRG.1.1"; cov "417.328430"; FPKM "222464.998000"; TPM "376040.909959”;
gene_id "STRG.2"; transcript_id "STRG.2.1"; cov "129.827484"; FPKM "69207.053467"; TPM "116983.271955”;
gene_id "STRG.2"; transcript_id "STRG.2.2"; cov "59.716179"; FPKM "31832.865165"; TPM "53808.283060”;
The scaling factor given these coverages should be (417 + 130 + 60) / 1000000 = 0.000607, which means that TPM for first transcript should be 417 / 0.000607 = 686985?

StringTie does not print all the transcripts that are identified at very low levels, because it assumes they are coming from transcriptional noise, or that they are poorly assembled. We think it is wrong to include all the transcription going on into the printed transcripts, as many of the reads overlapping the bundle might not even be compatible with the isoforms that were assembled.

StringTie does not print all the transcripts that are identified at very low levels, because it assumes they are coming from transcriptional noise, or that they are poorly assembled. We think it is wrong to include all the transcription going on into the printed transcripts, as many of the reads overlapping the bundle might not even be compatible with the isoforms that were assembled.

StringTie does not print all the transcripts that are identified at very low levels, because it assumes they are coming from transcriptional noise, or that they are poorly assembled. We think it is wrong to include all the transcription going on into the printed transcripts, as many of the reads overlapping the bundle might not even be compatible with the isoforms that were assembled.

StringTie does not print all the transcripts that are identified at very low levels, because it assumes they are coming from transcriptional noise, or that they are poorly assembled. We think it is wrong to include all the transcription going on into the printed transcripts, as many of the reads overlapping the bundle might not even be compatible with the isoforms that were assembled.

StringTie does not print all the transcripts that are identified at very low levels, because it assumes they are coming from transcriptional noise, or that they are poorly assembled. We think it is wrong to include all the transcription going on into the printed transcripts, as many of the reads overlapping the bundle might not even be compatible with the isoforms that were assembled.

StringTie does not print all the transcripts that are identified at very low levels, because it assumes they are coming from transcriptional noise, or that they are poorly assembled. We think it is wrong to include all the transcription going on into the printed transcripts, as many of the reads overlapping the bundle might not even be compatible with the isoforms that were assembled.


Can we have some examples regarding how to differentiate where we need secure storage?

First of all, thank you for your work, your lib solves a real issue by balancing between the secure vs larger sized data storage in redux store.
After reading the Medium article, I am still not sure about how your lib knows where to use secure storage and where just normal AsyncStore is enough.
Do we have flags to explicitely tell the lib, this part is secure, please encrypt it or it works only based on the size of the blob?
If we could have a very short example, that would be a great help that would show a use case if we store normal, unencrypted data with a passport that should be encrypted.
Thank you for your help in advance!

@velykovits thanks for your interest.
The library uses AsyncStorage exclusively for data storage. However, the data in there isn't readable by humans, and can't be encrypted without the secure key. The secure key is stored via a separate, fully encrypted storage mechanism, the Keychain (iOS) and Keystore (Android) library.
Maybe that could have been made clearer in the blog post?


missing properties

const daxClient = new AmazonDaxClient({
client: DynamoDBDocumentClient.from(new DynamoDBClient({
endpoint: daxEndpoint,
region: Configs.REGION.MAIN
}))
});
Error: Type 'DynamoDBDocumentClient' is missing the following properties from type 'DynamoDBClient': getDefaultHttpAuthSchemeParametersProvider, getIdentityProviderConfigProviderts(2739)
AmazonDaxClient.d.ts(8, 5): The expected type comes from property 'client' which is declared here on type '{ client: DynamoDBClient; config: { skipHostnameVerification?: boolean | undefined; maxRetries?: number | undefined; writeRetries?: number | undefined; readRetries?: number | undefined; ... 8 more ...; threadKeepAlive?: number | undefined; }; }'

I have a code change locally that should fix this. I'll push it later tonight sorry about the inconvenience

hey dave, this should be fixed in the latest 1.0.5 release as part of https://github.com/kwojcicki/amazon-dax-client-v3/commit/f4cfda7d9335578b67882e36264b67ea6139ae98#diff-1d303347dc4638b4f5afae892c1832c797f99c033d5ca672aaf69201f30880f6

Bug squashed! Thank you!


Visiting file collections, take 1

It is a common pattern in Gradle to have file collections nested into each other. When iterating these collections in many cases we use getFiles(), which constructs an expensive Set of File objects on several levels. This adds a lot of avoidable allocations, and in some cases the expensive de-duping achieved by putting the resolved files in a Set is also unnecessary.
This PR uses a cancellable visitor to iterate file collections in some cases.

Performance results: https://builds.gradle.org/viewLog.html?buildId=21866447&tab=buildResultsDiv&buildTypeId=Gradle_Check_PerformanceTestCoordinator
Passing ready to merge build: https://builds.gradle.org/viewLog.html?buildId=21866610
(Had to rebase for cosmetic reasons)


lcore library dependency issue

godaemon uses lcore. lcore is open source (and the same license) however it is not available on GitHub but rather on an obscure server, so others cannot build godaemon.
lcore should either be bundled with godaemon, or I should add another repo for it here, and a script to pull down lcore if you are missing it during the build process.

I have now created a mirror repository for lcore - https://github.com/zipplet/lcore - and godaemon builds against it. Godaemon was built using a slightly older version of lcore, so I will build a new minor release of godaemon against the new library.


Docs: Some images of the Mac widgets

Hi! While I'm learning how to make the widgets, I thought I'd take screenshots and add them to the doc page for that widget. I tested them in read the docs and the builds have been passing so that should be all alright.
It might be a while before I have time to dive into this again so I thought I'd submit them even though I haven't got all the widgets. Hopefully I can get the rest done before too long.
( ^ - ^)_/'

Thanks @elanorigby!


bump the dockerfile base image to nixos/nix:2.11.0

Summary
The recommended base image in https://nixos.org/download.html#nix-install-docker
is nixos/nix:2.11.0. Can we bump to this? Are there any (hidden) dependencies
with some other pieces (like pinned nix packages version?)?
How was it tested?
sanity test:
> cd testdata/go/go-1.19
> devbox build
> docker run devbox

Current dependencies on/for this PR:

main

PR #114   👈

This comment was auto-generated by Graphite.


Ethan: Watch freecrack4u.net

Ethan requests the watch of the watch_keyword freecrack4u\.net. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

freecrack4u\.net has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


Implement CreateMapping for GithubSSOSql repository

Add uniqueness constraints to github_user_id and short_user_id.
One Github account should be mapped to only one Short account. Vise versa.

https://github.com/short-d/short/issues/192


Rellanas Twin Blades missing?

title

It's showing up for me

Make sure you have "Include DLC Weapons" checked, and it isn't hidden due to another filter (weapon type or attribute requirements)

I either must be blind or my filters were messed up. Found it though, thanks!


Adding class to ensure REST API can register itself during startup

+1, tested on master. (this PR is against dspace-5_x)

+1 via code inspection. However, as noted, this would need to be applied or cherry-picked over to master. At this time, there are no guarantees there will be another 5.x release.


SSH Key Creation

We need a UI that allows you to generate an SSH key for the FabricBolt user to connect to remote machines.

This has been merged (https://github.com/fabric-bolt/fabric-bolt/pull/168).


feature request Add JFLEG Dataset

Description
I am creating a chatbot for the purpose of grammatical error correction(GEC). I want to use this John Hopkins University dataset: https://github.com/keisks/jfleg
Thank you!

Please consider making a PR and add this dataset, it's really easy to do! Check out this tutorial:
https://cloud.google.com/blog/big-data/2018/02/cloud-poetry-training-and-hyperparameter-tuning-custom-text-models-on-cloud-ml-engine


carpel abaxial epidermis

Like sepal abaxial epidermis:
http://browser.planteome.org/amigo/term/PO:0006054
is_a carpel epidermis,     PO:0025096
A portion of carpel epidermis that covers the abaxial/lower surface of a sepal.
PMID:25788175

Just to clarification-
You are requesting a new term: 'carpel abaxial epidermis'
proposed def'n:  "A portion of carpel epidermis that covers the abaxial/lower surface of a sepal. "
is this a typo?
did you mean to say :
"A portion of carpel epidermis that covers the abaxial/lower surface of a carpel. "
I think in the case of a carpel, we would not use the word "lower" but just refer to it as the abaxial surface (away from the axis).

Yes, typo.  :)  Incomplete editing of copy/paste of the analogous sepal term.

Added 2 new terms- figured it made sense to add them both at once.
carpel abaxial epidermis (PO:0025617) - A portion of carpel epidermis (PO:0025096) that covers the abaxial surface of a carpel (PO:0009030)." [PMID:25788175, PO:cooperl]
comment: The abaxial surface is the one which is furthest from the plant axis.
xref: PO_GIT:639
is_a: PO:0025096 ! carpel epidermis
carpel adaxial epidermis (PO:0025618): A portion of carpel epidermis (PO:0025096) that covers the adaxial surface of a carpel (PO:0009030)." [PO:cooperl]
comment: The adaxial surface is the one which is closest to the plant axis.
xref: PO_GIT:639
is_a: PO:0025096 ! carpel epidermis

Thanks, Laurel!  When will this be live?

They are up on dev.planteome this morning.  The next full release will be in December.

Great!  Thanks.


[HOLD https://github.com/Expensify/App/pull/35004] [$500] Message does not show marked as unread

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.31-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706113206869959
Action Performed:

Have newDot in a tab that's not focused (not entirely sure this is necessary)
Switch to another window (not entirely sure this is necessary)
Receive a message and click on the browser notification window

Expected Result:
Message should be marked unread
Actual Result:
Message is marked as read
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/43996225/8e71a7c0-26f9-42db-b12d-23d23ea60cd9

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010cf8b94333ea6d61
Upwork Job ID:<PHONE_NUMBER>012480512
Last Price Increase: 2024-02-06

https://github.com/Expensify/App/pull/35004 would fix this

I'm not getting any browser notifications in new dot or locally, I've allowed the browser notification permission. Any setting that we have to enable?

Let's put this on Hold and see if the linked PR fixes this

Testing this on branch from https://github.com/Expensify/App/pull/35004
It will mark the LHN as unread where currently it will be read. ( half improvement )
However it does not place the unread marker on the message.
https://github.com/Expensify/App/issues/33680 seems like the same issue.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Messages that are unread do not show up as unread when the chat is already open and navigating to it from a notification.
This is only reproducable on chats that are already open. And it's not related to a notification.
What is the root cause of that problem?
When a chat is open, we do not mark the messages as unread if they get received because this check prevents that https://github.com/Expensify/App/blob/3ab4e6e12d9ff38e69493321f0d31f032481b373/src/pages/home/report/ReportActionsList.js#L233 as the last active time is when we opened the report, and all the messages after that are later and so it marks it all as read thinking you're active. Even when minimized and accessing from a notification deep link.
We don't have a way to reset that lastReadTimeRef yet, to compare against except for when we navigate away to another report.
What changes do you think we should make in order to solve the problem?
What we can do is use app focus information with this hook: https://github.com/Expensify/App/blob/3ab4e6e12d9ff38e69493321f0d31f032481b373/src/hooks/useAppFocusEvent/index.ts#L9
To reset that lastReadTimeRef when the user focuses on the chat again. That way it knows that the unread messages before that new timestamp, are actually new.
What alternative solutions did you explore? (Optional)

I'm not getting any browser notifications in new dot or locally, I've allowed the browser notification permission. Any setting that we have to enable?

The conditions for the browsers notification to trigger are:
Allow chrome notifications from OS
Allow expensify notifications from chrome
Send a message to a minimized chrome

OK so the linked PR is also being proposed to be held.

In which case, which issue should we pursue here? Can this issue be fixed independently of what you're suggesting here?
https://github.com/Expensify/App/issues/34829#issuecomment-1924443959

Taking off hold

In which case, which issue should we pursue here? Can this issue be fixed independently of what you're suggesting here?
#34829 (comment)

It looks like the final fix of the linked PR is going to only improve electron visibility. Making the fix independent of the issue mentioned here. Original fix of the linked PR would've also addressed this.
My latest proposal I posted here will address this issue seperately.

We can move forward with @jeremy-croff's proposal here.
🎀👀🎀 C+ reviewed.

We can move forward with @jeremy-croff's proposal here.
🎀👀🎀 C+ reviewed.

Thank you! While I really appreciate the assignment, this might be already fixed by this pending PR:
https://github.com/Expensify/App/pull/35948

Thank you! While I really appreciate the assignment, this might be already fixed by this pending PR:
https://github.com/Expensify/App/pull/35948

Thanks @jeremy-croff for pointing that out, I guess we should hold on that and check if the issue persists after it is merged

Still held on https://github.com/Expensify/App/pull/35948

Changing to Weekly while on hold

Still held

@muttmuure This is now fixed as per https://github.com/Expensify/App/issues/33680
No need to hold, and I retested to confirm.

@muttmuure This is now fixed as per #33680 No need to hold, and I retested to confirm.

Thanks!, I'll close it then


Fix for #278 Bug: Variables and ElementInstances not stored in DB

The root cause was a broken check for duplicates in the DB.
This solution favors creating new ID unique index fields for the two mentioned tables,
in order to feed all data (variables and element_instances) into the DB.
Assuming, there are no duplicate events exported, there's no need for a duplicate check.
Additionally, two indices are added, for performance reasons.
Unfortunately, because JPA requires an @id field, a new field was introduced
and there's an UPGRADE instruction documented, so people out there would be able to migrate their installations.
In other words, this PR contains a breaking change in DB structures.
Also, if you look at what files are changed, this PR contains two commits.
The first one is pure refactoring, in order to split the ZeebeImportService class into multiple importer-classes.
This is mainly for readability. I hope you find this useful.
The second commit is the bug fix itself.
Any feedback is welcome.

@nitram509 thank you for your contribution :tada:
Please have a look at my comment: https://github.com/camunda-community-hub/zeebe-simple-monitor/issues/278#issuecomment-894200353
Other comments to the PR,

splitting into different classes is okay for me
adding the indexes is a good idea but I would prefer a separate PR
I appreciate the update guide :+1:

I will close this PR and create separate ones, as recommended.

See #284 for part 1, the refactoring.


User reported error on deploy

I don't think it should be possible for a user to get here.
Also we shouldn't be using the term 'application default credentials'. that has a special meaning which is not what the credentials represent.
com.google.cloud.tools.appengine.api.AppEngineException: Failed to create application default credentials.
at com.google.cloud.tools.intellij.appengine.cloud.CloudSdkAppEngineHelper.createSdk(CloudSdkAppEngineHelper.java:208)
at com.google.cloud.tools.intellij.appengine.cloud.AppEngineDeploy.deploy(AppEngineDeploy.java:106)
at com.google.cloud.tools.intellij.appengine.cloud.AppEngineFlexibleDeployTask.execute(AppEngineFlexibleDeployTask.java:78)
at com.google.cloud.tools.intellij.appengine.cloud.AppEngineRunner.run(AppEngineRunner.java:39)
at com.intellij.openapi.application.TransactionGuardImpl$6.run(TransactionGuardImpl.java:291)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.runNextEvent(LaterInvocator.java:326)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:310)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756)
at java.awt.EventQueue.access$500(EventQueue.java:97)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.awt.EventQueue$3.run(EventQueue.java:703)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:726)
at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:863)
at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:699)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:385)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

Yea I would have expected staging to fail here first. I'll check it out

I think this is possible to reproduce if the user configures everything in the deployment correctly, then (somehow) logs out right before running it.
In this case the credentials will never have been staged and no exception would be thrown and caught, and deploy would continue.

Don't we stage the credentials at deploy time?
On Wed, Aug 24, 2016 at 11:17 AM, Etan Shaul<EMAIL_ADDRESS>wrote:

I think this is possible to reproduce if the user configures everything in
the deployment correctly, then (somehow) logs out right before running it.
In this case the credentials will never have been staged and no exception
would be thrown and caught, and deploy would continue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/issues/837#issuecomment-242101710,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHf5HbwSC3Mf7RcBoA4iDuhxkrhjUKyHks5qjGCIgaJpZM4JsHcH
.

Yes, you're right, my last theory is wrong. If you create a fully valid deployment config (log in, choose a project etc.) and save it and then log out and run the created config we have a check for this - the user will be prompted again to log in (and if login fails, then there is a good error message).
I'm currently not sure how to reproduce this.

I figured out how to reproduce this:

Create and save a fully filled out deployment config - log in, choose a project etc. But do not run it yet.
Log out, and log in with a different account.
Run the config create is step 1 and notice the same exception as reported

Expected outcome: The user will be shown some a better message indicating what went wrong and IDE should not explode and report an error.

Nice job!
On Wed, Aug 24, 2016 at 12:11 PM, Etan Shaul<EMAIL_ADDRESS>wrote:

I figured out how to reproduce this:

Create and save a fully filled out deployment config - log in, choose a
project etc. But do not run it yet.
Log out, and log in with a different account.
Run the config create is step 1 and notice the same exception as
reported

Expected outcome: The user will be shown some a better message indicating
what went wrong and IDE should not explode and report an error.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/issues/837#issuecomment-242122235,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHf5HW1TsKCCCrqxQkt9RfqI7pViPfVrks5qjG1LgaJpZM4JsHcH
.


M68000: SBCD instructions are decompiled incorrectly

Describe the bug
SBCD instructions are decompiled with swapped operands.
To Reproduce
Steps to reproduce the behavior:

Load the attached sbcd.bin file as a default M68000 binary; starting address does not matter
Mark the whole binary as code (creating a function out of this does not affect the decompilation result)
The decompiled output will show the incorrect bcdAdjust call

Expected behavior
The operation is D1b - 1 - XF, but decompilation shows 1 - D1b - XF instead.  Documentation says that SBCD is "Destination10 – Source10 – X → Destination"
Screenshots

Attachments
sbcd.bin.zip
Environment (please complete the following information):

OS: macOS 12.3.1
Java Version: 18.0.1
Ghidra Version: 10.1.3
Ghidra Origin: GitHub binary release

From manual:
SBCD Dx,Dy
Dx, Dy: source and destination data registers, respectively
From sleigh:
:sbcd Tyb,Txb
but the display is correct, so are the variables are named backwards?
Then it looks like they were used in the calculation as :sbcd DST,SRC instead of SRC,DST

@mumbel so for reference:

MOVEQ.L #$1, D0
MOVE.L #$20, D1
SBCD D0, D1

should produce #$19 in D1.  In this case, the calculation is the other way around then.


adding vanilla tweaks setup script

First time committing to this repo, still a little unsure about the testing process. Happy to setup different methods of testing or provide screenshots if needed.
Ticket:
https://github.com/itzg/docker-minecraft-server/issues/1240
Enables automation of Vanilla Tweaks packages.

I am using the following variables in the workflows now:

IMAGE_ORG and DISCORD_WEBHOOK were added. I can revert those if they are blockers.

Updated Discord bot to include a link back to the actions run.

Glad to have you help with automated testing, but for this PR I'm good with any manual testing you've done. Just a few minor things and I think this is good to merge.

Go ahead and revert the workflows changes. It's getting too complicated and I want to do some more research.

Alright, let me get this split up. I'm going to close this PR and open a new one.


Disallow user from removing or tombstone-ing Platform::Application

Closes the first issue in bullet_train-api
Details
Looking at config/models/roles.yml, I first tried changing the permissions on Platform::Application but realized it was simply Membership with a platform_agent_of_id that we need to handle.
Instead of editing the roles themselves, I just added a hook here which checks if the membership is a Platform::Application, combines that with if can? :destroy in the view, and removes/shows the button accordingly.
Tests
I'm not quite sure how to integrate the tests with the code here, but can make a new Bullet Train app with the following branch and test the code I pushed there:
$ git clone -b fixes/disable-application-membership-removal git@github.com:gazayas/bullet_train.git test_app

Use this branch in the Gemfile and $ bundle install:
gem "bullet_train", git: "git@github.com:gazayas/bullet_train-base.git", branch: "fixes/keep-platform-app-membership"

Run bin/dev once so the js files compile, then run the following two tests:
$ bin/dev
$ bundle exec rails test test/models/membership_test.rb test/system/membership_test.rb

Here's the commit for the test code itself: https://github.com/gazayas/bullet_train/commit/1a08c48219e4802cd230c6a556e8ceb1ce440ff2

@gazayas Can you push this up as a branch of the bullet-train-co/bullet_train-base so @adampal and I can collaborate on it? I was going to rebase it.

@andrewculver Done 👍

@gazayas Do you mind rebasing and seeing if we can get tests passing? I would do a merge expect it's an old branch so it's still under your repo. :-)

Ooh, I figured out how to do it myself! :-)

Continued in https://github.com/bullet-train-co/bullet_train-base/pull/85 .

Oh, cool! 🤙


nodejs builds failing due to unstable "semver.io/node/resolve" dependency

Used buildpack: gcr.io/buildpacks/builder:v1 (in Skaffold)
semver.io seems to be down at the time of this writing.
===> RESTORING
===> BUILDING
[builder] === Node.js - Runtime<EMAIL_ADDRESS>===
[builder] Resolving Node.js version based on semver "14.x.x"
[builder] --------------------------------------------------------------------------------
[builder] Running "curl --fail --show-error --silent --location --get --data-urlencode range=14.x.x http://semver.io/node/resolve"
[builder] curl: (22) The requested URL returned error: 503 Service Unavailable
[builder] Done "curl --fail --show-error --silent --location --get --data-ur..." (426.256181ms)
[builder] Failure: (ID: fd218884) curl: (22) The requested URL returned error: 503 Service Unavailable

Would that be possible to decouple buildpacks from this remote semver.io dependency?
Related from heroku NodeJS buildpack: https://github.com/heroku/heroku-buildpack-nodejs/pull/452

We are experiencing the same issue.

We no longer rely on semver.io. This is fixed.


rename command does not find application

Renaming an Empire application using emp rename <oldname> <newname> does not work in HEAD.
I wanted to rename a newly created application to match the name of the docker image that will be deployed, but emp throws a 404 Not Found error:
➜  ~  emp apps
foobar      Jun 22 16:28
➜  ~  emp rename foobar bazbat
error: Unexpected error: 404 Not Found

Tried before and after deploying to no avail.

Hey @rgabo! Currently, Empire doesn't support renaming an application, but we have plans of supporting it. There's some subtleties about renaming, like ensuring that the CNAME for the ELB is updated.
I think for the time being, the emp command should show an error, or we should return a 501 from known endpoints that aren't implemented yet.

Thanks for the quick answer @ejholmes, not a huge issue as it is fairly straightforward to recreate the app (env, domains, ssl). Just wanted to make sure it was noticed.


When working with glog,It gets flag provided but not defined: -alsologtostderr

Because of the flagSet.Parse(args) ignored the flags defined by glog,I added  flag.VisitAll before it.
Works fine.

    flag.VisitAll(func(ff *flag.Flag) {
        f.flagSet.Var(ff.Value, ff.Name, ff.Usage)
    })

same problem  in go test -v

Hi,
I ran also into this issue via "go test -v". A workaround for me is to add:
`import (
"flag" // <-- added
"testing"
)
func init() {
flag.Set("test.v", "true") // or false, if you don't want to have the verbose output per default
}
// rest of your testing stuff
`
Then run "go test" (w/o "-v").
But, it enables the verbose output per default.
If I run "go test -v", I will get the "flag provided but not defined: -test.v" error.
So, there is a kind of "race condition" parsing the flags.

@l0wm4x Could you share your code to show how do you setup your multiconfig.MultiLoader? I'm not quite sure why the original report mentions glog package.

Hi @rjeczalik,
here they are (the interesting parts):
my current test file:
package getdatapoints

import (
	"flag"
	"fmt"
	"reflect"
	"testing"
)

// workaround. Now verbose testing
// is default.
func init() {
	flag.Set("test.v", "true")
}

func Test_ParseTOML(t *testing.T) {
	type args struct {
		filename string
	}
	tests := []struct {
		name    string
		args    args
		want    Config
		wantErr bool
	}{
		{
			name: "positivTest",
			args: args{filename: "test_config.toml"},
			want: Config{
				Server{
					Hostname: "blah.com",
					Username: "user",
					Password: "12345678",
				},
			},
			wantErr: false,
		},
	}
	for index, tt := range tests {
		tt := tt
		t.Run(fmt.Sprint(index), func(t *testing.T) {
			c := Config{}
			err := c.ParseTOML(tt.args.filename)
			if (err != nil) != tt.wantErr {
				t.Errorf("ParseTOML() error = %v, wantErr %v", err, tt.wantErr)
				return
			}
			if !reflect.DeepEqual(c, tt.want) {
				t.Errorf("ParseTOML() = %v, want %v", c, tt.want)
			}
		})
	}
}

my code:
// file configuration.go

package getdatapoints

import (
	"github.com/koding/multiconfig"
)

type (
	Config struct {
		Server Server
	}
	Server struct {
		Username string
		Password string
		Hostname string
	}
)

func (c *Config) ParseTOML(filename string) error {
	m := multiconfig.NewWithPath(filename)
	err := m.Load(c)
	if err != nil {
		return err
	}
	return nil
}

And the config file
[Server]
Username = "user"
Password = "12345678"
Hostname = "blah.com"

I hope that helps.

@l0wm4x I haven't tried that code yet, but from the quick glance you probably do not want to mix os.Args with testing package, as it define it's own. Since NewWithPath uses FlagLoader (which reads os.Args), I'd either use TOMLLoader directly or set FlagLoader.Args to some fake values in your testing code.

@rjeczalik : Great!! Using TOMLLoader directly, works for me :-). Thank you.


Can't check out PRs while using WSL remote connection

Issue Type: Bug
With GitHub Pull Requests and Issues installed, on a system that uses WSL2 (Ubuntu) and VS Code:

View Pull Requests in the GitHub Pull Requests and Issues extension tab.
Right click on a PR.
Click "Checkout Pull Request."
Wait. The PR is never checked out, and "Switching to Review Mode" spins forever at the bottom of the screen.

Extension version: 0.20.0
VS Code version: Code 1.49.1 (58bb7b2331731bf72587010e943852e13e6fd3cf, 2020-09-16T23:27:51.792Z)
OS version: Windows_NT x64 10.0.19041
Remote OS version: Linux x64 4.19.128-microsoft-standard

System Info

Item
Value

CPUs
AMD Ryzen 5 2600 Six-Core Processor             (12 x 3394)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.93GB (5.37GB free)

Process Argv
--crash-reporter-id 1747b875-2fc6-454b-bfdc-572e0002d65e

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Ubuntu

OS
Linux x64 4.19.128-microsoft-standard

CPUs
AMD Ryzen 5 2600 Six-Core Processor (12 x 3393)

Memory (System)
12.43GB (10.68GB free)

VM
0%

I'm not able to reproduce this issue.

Could be related to VSCode / VSCode remote issues when using SSH keys with passphrases?
I had this issue, but realised I also could not sync / publish branches / ...,  whereas using the CLI worked fine.
Managed to fix this by adding keychain https://esc.sh/blog/ssh-agent-windows10-wsl2/


Crazy Enchantments | HELP!

Everytime anyone gets a high destroy rate, the enchant will always apply no matter wat the destroy rate or success rate is!

Are you using the older versions? Because in the older versions that always used to happen.

I tried it on the recent update tat came out last wednsday

Are you in creative? the books always apply in creative no matter the rates.

Also you might not have put the % sign in the lore.


Add Nim language

I would like to add Nim to the supported language, indeed it is a very good language and I think it has its place in codegolf

Bit more left to do, like syntax highlighting, but it works :-)

Amazing! :)

Thanks a lot for the support, it's crazy.

Hello, https://code-golf.io/about page lists a bit older Nim version (0.17.2), whereas the latest one is 0.19.6. Can that be updated please? Thanks.

@kaushalmodi absolutely, the reason why the commit "updates" and doesn't "fixes" this issue and while its still in progress.
In the commit I wrote:
Add initial Nim support

Still needs syntax highlighting and a new version build from source
but it works, which is a start :-)

So my plan is to followup with building Nim from the csources rather than just installing the version from alpine, this should give you the 0.19 version you want, I just need to find some tuits.

I haven't looked at the static builds but I tend to prefer building from source, especially since musl can complicate matters.
tl;dr; I have a plan :-)

I just need to find some tuits.

Assuming that you meant finding some "tutorials", here's the guide to compiling Nim from source: https://github.com/nim-lang/Nim#compiling

tl;dr; I have a plan :-)

👍

@kaushalmodi Ah no, tuits is short for round tuits, as in "round to it" https://en.wiktionary.org/wiki/round_tuit , a phrase I picked up the in Perl community, perhaps its not as widely known as I thought.
In terms of the actual change, building from source is working fine:
--- a/langs/nim/Dockerfile
+++ b/langs/nim/Dockerfile
@@ -1,6 +1,21 @@
 FROM alpine:edge

 RUN apk add -X http://dl-cdn.alpinelinux.org/alpine/edge/testing --no-cache \
-    musl-dev nim tcc
+    curl gcc musl-dev nim tcc
+
+RUN curl -L https://github.com/nim-lang/Nim/archive/v0.18.0.tar.gz | tar xzf - \
+ && curl -L https://github.com/nim-lang/csources/archive/v0.18.0.tar.gz | tar xzf -
+
+RUN cd Nim-0.18.0                     \
+ && mv ../csources-0.18.0 csources    \
+ && cd csources                       \
+ && ./build.sh                        \
+ && cd ..                             \
+ && ./bin/nim compile -d:release koch \
+ && ./koch boot -d:release            \
+ && ./koch install /usr/bin
+
+# TODO Use scratch instead.
+RUN apk del --no-cache curl gcc

 ENTRYPOINT ["/usr/bin/nim", "--cc:tcc", "--verbosity:0", "-r", "c", "-"]

However bumping to 0.19.0 or higher produces an interesting regression with reading from stdin with hyphen: command line(1, 2) Error: invalid command line option: '-'

However bumping to 0.19.0 or higher produces an interesting regression with reading from stdin with hyphen: command line(1, 2) Error: invalid command line option: '-'

I have never attempted reading code into nim via stdin. What would be a minimal example to explain this regression? Do you mean that this worked?: nim -r c - 'echo "hello"' ?

This works on 18, but fails on 19
$ echo echo NimVersion | /usr/bin/nim --cc:tcc -r c -
Hint: used config file '/etc/nim.cfg' [Conf]
Hint: system [Processing]
Hint: stdinfile [Processing]
Hint:  [Link]
Hint: operation successful (11717 lines compiled; 0.131 sec total; 21.867MiB peakmem; Debug Build) [SuccessX]
Hint: ./stdinfile  [Exec]
0.18.0

/me suddenly realises he's talking to a Nim contributor about a lang he doesn't himself know ;-)

heh, I am just a casual user; using the language just for what I need :) [never needed stdin]

I prefer using stdin for every lang as having the source on disk makes the Quine hole very trivial.

Bumped to 0.18.0, and added syntax highlighting, now to get a few more users ;-) https://www.reddit.com/r/nim/comments/brqfhu/code_golf_site_with_nim_support/

Latest devel seems to work (with tcc), thanks for filing the upstream issue @kaushalmodi


How to close bidirectional stream

Hi I just want to close BidirectionalStream in client side, I know that set param "eof" to True in function writeChain can achieve. Buf if there's any way to close stream? Here is what I have tried in client side:
void CloseStream(quic::StreamId streamId)
{
    const quic::QuicClientConnectionState& coonState = *dynamic_cast<const quic::QuicClientConnectionState*>(quicClient_->getState());
    quic::QuicStreamState* stream = coonState.streamManager->getStream(streamId);
    stream->sendState = quic::StreamSendState::Closed_E;
    stream->recvState = quic::StreamRecvState::Closed_E;
    coonState.streamManager->addClosed(streamId);
    auto itr = coonState.streamManager->closedStreams().begin();
    while (itr != coonState.streamManager->closedStreams().end())
    {
        coonState.streamManager->removeClosedStream(*itr);
        itr = coonState.streamManager->closedStreams().erase(itr);
    }
}

But it doesn't work at all, naturally after 1min the timeout occurs because there's no extra data to process:
QftClient failed read from stream=0, error=LocalError: Idle timeout, Idle timeout
I wonder if BidirectionalStream should be closed on both server & client side ?

You should never directly changing the sendState and recvState on a QuicStreamState. I think you should never directly change any member on a QuicStreamState. They are handled by stream state machine. I'm actually surprised directly changing them doesn't crash your code later on when the state machine finds the states are wrong.
You can resetStream via QuicSocket API.

Also let me add: reset is for when you don't want the stream any more before data are finished transferring. For normal graceful close, EOF is the way to go. The stream will be closed when all the send bytes, including EOF, are acked by peer, and when all the received bytes, including EOF, are received.

@Enjia -- hopefully that answered your question, let us know if there's more


Hscripting enhancement

What feature do you want to get added on the base engine?
for the hscripts, you could use the haxe library 'Compile Time' to get all the classes that exist in the game (including the functions etc etc) so that everything is accessible with hscripts
//looks like this
CompileTime.getAllClasses().map((classRef)->{
//in this case, classRef as a string looks like: openfl.stuff.lmao.crap.Object
classMap.set(Std.string(classRef), classRef);
//in this case though, it looks more accessible as :Object!
final classPath:Array = Std.string(classRef).split('.');
classMap.set(classPath[classPath.length-1], classRef);
//you could of course add some checks to see if multiple references of 'Object' exist but you get the point
});
//and of course some other classes that didnt get added through the CompileTime.getAllClasses().map method
//i have added all that on an engine i made sometime ago lol
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

Lol I tried to do something like this recently, they kinda ignored it.


Configure service monitor

This PR configures a ServiceMonitor so the component is scraped :D
Checklist

[x] Update changelog in CHANGELOG.md.

Tested on grizzly


AutoPipeline can't find a pipeline linked to FluxPipeline for None

System Info / 系統信息
transformers 4.41.2
torch 2.3.1+cu121
Running Xinference with Docker? / 是否使用 Docker 运行 Xinfernece？

[ ] docker / docker
[X] pip install / 通过 pip install 安装
[X] installation from source / 从源码安装

Version info / 版本信息
v0.14.1
The command used to start Xinference / 用以启动 xinference 的命令
xinference --host <IP_ADDRESS> --port 9997
/data/miniconda3/lib/python3.10/site-packages/xinference/deploy/cmdline.py:164: DeprecationWarning: Starting a local 'xinference' cluster via the 'xinference' command line is deprecated and will be removed in a future release. Please use the new 'xinference-local' command.
warnings.warn(
2024-08-11 01:56:18,110 xinference.core.supervisor 3263 INFO     Xinference supervisor <IP_ADDRESS>:36755 started
2024-08-11 01:56:18,527 xinference.core.worker 3263 INFO     Purge cache directory: /root/.xinference/cache
2024-08-11 01:56:18,531 xinference.core.worker 3263 INFO     Connected to supervisor as a fresh worker
2024-08-11 01:56:18,548 xinference.core.worker 3263 INFO     Xinference worker <IP_ADDRESS>:36755 started
2024-08-11 01:56:24,540 xinference.api.restful_api 3195 INFO     Starting Xinference at endpoint: http://<IP_ADDRESS>:9997
2024-08-11 01:56:24,696 uvicorn.error 3195 INFO     Uvicorn running on http://<IP_ADDRESS>:9997 (Press CTRL+C to quit)
Reproduction / 复现过程

```
2024-08-11 02:36:58,080 xinference.api.restful_api 3195 ERROR    [address=<IP_ADDRESS>:36435, pid=4196] AutoPipeline can't find a pipeline linked to FluxPipeline for None
Traceback (most recent call last):
  File "/data/miniconda3/lib/python3.10/site-packages/xinference/api/restful_api.py", line 878, in launch_model
    model_uid = await (await self._get_supervisor_ref()).launch_builtin_model(
  File "/data/miniconda3/lib/python3.10/site-packages/xoscar/backends/context.py", line 231, in send
    return self._process_result_message(result)
  File "/data/miniconda3/lib/python3.10/site-packages/xoscar/backends/context.py", line 102, in _process_result_message
    raise message.as_instanceof_cause()
  File "/data/miniconda3/lib/python3.10/site-packages/xoscar/backends/pool.py", line 656, in send
    result = await self._run_coro(message.message_id, coro)
  File "/data/miniconda3/lib/python3.10/site-packages/xoscar/backends/pool.py", line 367, in _run_coro
    return await coro
  File "/data/miniconda3/lib/python3.10/site-packages/xoscar/api.py", line 384, in __on_receive__
    return await super().__on_receive__(message)  # type: ignore
  File "xoscar/core.pyx", line 558, in __on_receive__
    raise ex
  File "xoscar/core.pyx", line 520, in xoscar.core._BaseActor.__on_receive__
    async with self._lock:
  File "xoscar/core.pyx", line 521, in xoscar.core._BaseActor.__on_receive__
    with debug_async_timeout('actor_lock_timeout',
  File "xoscar/core.pyx", line 526, in xoscar.core._BaseActor.__on_receive__
    result = await result
  File "/data/miniconda3/lib/python3.10/site-packages/xinference/core/supervisor.py", line 1027, in launch_builtin_model
    await _launch_model()
  File "/data/miniconda3/lib/python3.10/site-packages/xinference/core/supervisor.py", line 991, in _launch_model
    await _launch_one_model(rep_model_uid)
  File "/data/miniconda3/lib/python3.10/site-packages/xinference/core/supervisor.py", line 970, in _launch_one_model
    await worker_ref.launch_builtin_model(
  File "xoscar/core.pyx", line 284, in __pyx_actor_method_wrapper
    async with lock:
  File "xoscar/core.pyx", line 287, in xoscar.core.__pyx_actor_method_wrapper
    result = await result
  File "/data/miniconda3/lib/python3.10/site-packages/xinference/core/utils.py", line 45, in wrapped
    ret = await func(*args, **kwargs)
  File "/data/miniconda3/lib/python3.10/site-packages/xinference/core/worker.py", line 882, in launch_builtin_model
    await model_ref.load()
  File "/data/miniconda3/lib/python3.10/site-packages/xoscar/backends/context.py", line 231, in send
    return self._process_result_message(result)
  File "/data/miniconda3/lib/python3.10/site-packages/xoscar/backends/context.py", line 102, in _process_result_message
    raise message.as_instanceof_cause()
  File "/data/miniconda3/lib/python3.10/site-packages/xoscar/backends/pool.py", line 656, in send
    result = await self._run_coro(message.message_id, coro)
  File "/data/miniconda3/lib/python3.10/site-packages/xoscar/backends/pool.py", line 367, in _run_coro
    return await coro
  File "/data/miniconda3/lib/python3.10/site-packages/xoscar/api.py", line 384, in __on_receive__
    return await super().__on_receive__(message)  # type: ignore
  File "xoscar/core.pyx", line 558, in __on_receive__
    raise ex
  File "xoscar/core.pyx", line 520, in xoscar.core._BaseActor.__on_receive__
    async with self._lock:
  File "xoscar/core.pyx", line 521, in xoscar.core._BaseActor.__on_receive__
    with debug_async_timeout('actor_lock_timeout',
  File "xoscar/core.pyx", line 526, in xoscar.core._BaseActor.__on_receive__
    result = await result
  File "/data/miniconda3/lib/python3.10/site-packages/xinference/core/model.py", line 300, in load
    self._model.load()
  File "/data/miniconda3/lib/python3.10/site-packages/xinference/model/image/stable_diffusion/core.py", line 135, in load
    self._model = AutoPipelineModel.from_pretrained(
  File "/data/miniconda3/lib/python3.10/site-packages/huggingface_hub/utils/_validators.py", line 114, in _inner_fn
    return fn(*args, **kwargs)
  File "/data/miniconda3/lib/python3.10/site-packages/diffusers/pipelines/auto_pipeline.py", line 339, in from_pretrained
    text_2_image_cls = _get_task_class(AUTO_TEXT2IMAGE_PIPELINES_MAPPING, orig_class_name)
  File "/data/miniconda3/lib/python3.10/site-packages/diffusers/pipelines/auto_pipeline.py", line 162, in _get_task_class
    raise ValueError(f"AutoPipeline can't find a pipeline linked to {pipeline_class_name} for {model_name}")
ValueError: [address=<IP_ADDRESS>:36435, pid=4196] AutoPipeline can't find a pipeline linked to FluxPipeline for None
```
Expected behavior / 期待表现
希望正常启动FLUX.1.xxx

Upgrade diffusers to 0.30.0

Upgrade diffusers to 0.30.0

已更新，有个新问题，我有4块4090，启动的时候始终只用到第一块，报显存不足退出

参考 https://inference.readthedocs.io/zh-cn/latest/models/model_abilities/image.html#tips-for-large-image-models-including-sd3-medium-flux-1

参考 https://inference.readthedocs.io/zh-cn/latest/models/model_abilities/image.html#tips-for-large-image-models-including-sd3-medium-flux-1

请问类似xinference launch --model-name FLUX.1-dev --model-type image --quantize_text_encoder text_encoder_2 这样的方式运行，我用什么参数指定本地模型路径呢？  xinference launch --help 中似乎没有看到

目前需要指定 --model_path xxx，后面我们添加成内置的。

大坑，注意需要安装  pip install transformers[sentencepiece]


Raspberry pi4B: can't boot on usb+gpt with 4TB drive (all ok on 8G usbkey)

Description
On an rpi4 I broke 2 microsd due to (probably) too many writes.
I decided to go all usb and to try to make it a nas+other things, on it, so I have 2x4TB drives on usb3.
rpi4 has added support for usb boot on September, I have updated the eeprom and I can boot from a usb stick easily by flashing the latest successful unstable nixos build on hydra. No problems there apparently.
I can create a USB key (8Gb) with GPT and copy the installation media partitions there. It boots correctly.
I can not do the exact same steps on a 4TB disk, I get a lot of "gpt partition table header signature is wrong" and after a while of waiting for network boot I get sent to a u-boot prompt
I don't want to use MBR on the 4TB drives, since I would lose half the total space.
To Reproduce

get a 4TB drive (probably anything over 2TB?)
create empty GPT (I used gdisk from the latest nix hydra image)
create 2 partitions, first 3G type ef00, second full free space type 8300
mkfs.vfat -F 32 -n NIXOS_BOOT  on the first partition, copy there the contents of the first partition of the latest working hydra image ( just a dump is probably the same)
dump the second partition of the hydra image on the second partition on the drive

Expected behavior
Boots normally with a 8GB USB key, does not load the kernel on a 4TB drive
Additional Info
The errors "gpt partition table header signature is wrong" only appear on the nixos boot on the 4TB drive, so it might be a problem of the u-boot version.
Maybe the hydra image is using u-boot 32 bits and it can't handle disks bigger than 2TB? I don't know how to verify that.
I don't know how to debug/patch/update u-boot, suggestions?

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/rpi4-usb-boot-gpt/11440/3

Just for reference I tried:

checking out master nixpkgs
change uboot to 21.04
recompile uboot with LBA48 and SYS_64_BIT_LBA flags:

file: pkgs/misc/uboot/default.nix
   ubootRaspberryPi4_64bit = buildUBoot {
     defconfig = "rpi_4_defconfig";
     extraMeta.platforms = ["aarch64-linux"];
+    extraMakeFlags = [ "CONFIG_LBA48=1" "CONFIG_SYS_64BIT_LBA=1" ];
     filesToInstall = ["u-boot.bin"];
   };

With a couple more things to let master compile the whole image for raspberry.
The theory was that those two flags should enable usage of disks > 2.1TB in uboot.
I am still unable to make it boot, the message is always the same, complaining about invalid GPT header signature
Suggestions on what I could try?

I already commented on a related issue (https://github.com/NixOS/nixpkgs/issues/127814#issuecomment-873523810), as the errors that I am getting from U-Boot are the same as in the other issue (including the reported signature that, AFAICT, mysteriously doesn't appear in the partition table); however, my setup is more similar to yours (I'm trying to boot from a single 5TB USB drive).

I kind of gave up and I am using the SD for jsut the partitions for firmware + /boot
everything else is on my 4TB drives, seems to work.
Not the setup I wanted, and I have not tried again since the last report in May,
I need someone with u-boot experience, the current compiled one clearly does not support drives > 2TB

It's funny you say that, because I did the same thing (on July 4th or 5th :)).


Carousel control with bootstrap 4 card issue

When using card-columns and card in Bootstrap 4, and when you put a carousel inside a card:
If you give a css "fade-in" animation to the card (from opacity 0 to 1), the carousel-control and carousel-indicators elements will behave buggy. They will maybe be visible initially, then they will be visible only during slides animation, and they will be invisible on hover.
Also, if the carousel changes height, the entire card that contains it will fall into a different position in the cards grid.

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case via CodePen/JS Bin or Stackblitz and report back with your link, Bootstrap version, and specific browser and OS details.
This is an automated reply

Card columns are quite buggy. We're abandoning them in v5, so perhaps try another approach. Either way, can't help without a reproducible demo, so closing out.


qptiff format

Hello!
I was wondering if it is possible to use qptiff as an input format for steinbock ?  If not, what is the preferable way to transform it to appropriate tiff?
Thank you
Best regards
Alexey

@alexeykb Thank you for reaching out! External images need to be in a format supported by imageio (see External images in the relevant part of the documentation). I am not aware of the best practices for qptiff conversion. You would need to convert them into a iamgeio supported format and then convert them to steinbock-compatible TIFF files using steinbock preprocess external images.

Closing this due to inactivity

Hello, I have an update on current issue (still doesnt work):
I am facing the issue with segmenting the ome.tiff using steinbock.
I have original CODEX files in the format of qptiff. I have transformed qptiff to ome.tiff using  BioFormats:
https://docs.openmicroscopy.org/bio-formats/6.10.1/users/comlinetools/index.html
What increased my original file from 25 gb to 75gb and stored it to:
path/to/publication/steinbock/external
I further have tried to input it to the IMC pipline (starting with steinbock), by using this command:
steinbock preprocess external images --img /data/external --imgout /data/images --infoout /data/images/images.csv
Unfortunatelly , it doesnt work and return the error:
WARNING steinbock.preprocessing.external - Unsupported file format: /data/external/scanone.ome.tiff
However, originally, the channel names from the ome.tiff
I have extracted the channel names from the ome.tiff file and those are in the form
Channel:0:0
Channel:0:1 etc
Which is not acceptable for steinbock, so i changed it to the
0
1 etc
What should be my steps now ?  Should I open ome.tiff through qptiff and manually rename channels  or the problem is in ome.tiff file, and not in channels names. If it is ome.tiff fault, how can I overpass it ? I also tried to transform qptiff thorugh QPath and it didi not give any positive results either.
Thank you
Best
Alexey


Force string

When using autolink for user generated content the content may be nil. This returns an error:
Rinku.auto_link(nil) # => TypeError: wrong argument type nil (expected String)

Maybe the argument could be forced to string with to_s.

This could be getting dangerously close to garbage-in-garbage-out; it's preferable that you deal with nil in an application-specific manner rather than relying on Rinku to coerce it to the empty string for you.

Yeah... I don't know why i made this an issue 3 years ago...

Haha, I'm just cleaning out old issues :)


Significantly improve badge list

This is to be in-line with mdbadges-cli

completed in https://github.com/inttter/md-badges/commit/483868328f10c6d655720a118403a25e7d9d3ad5****


OCNE Info Command

In this PR, I add the ocne info command in order to display output about OCNE environmental variables.
./ocne info
The OCNE_DEFAULTS environment variable sets the location of the default configuration file.
The KUBECONFIG environment variable sets the location of the kubeconfig file. This behaves the same way as the --kubeconfig option for most ocne commands.
The EDITOR environment variable sets the default document editor.

I think you should display the values of those env vars

I think you should display the values of those env vars

Thanks! I just added this change. Do you think if the user doesn't have these set, the default value for those environment variables should display?


Treat missing Shopify data as a out of stock rather than 404

Review Shopify code to ensure that when Shopify data can't be found the product is treated as out of stock rather than as a 404.

Nvm, I don't like this idea actually.


Nothing displays when selecting Deploy an Application to AWS Code Deploy

Within my job configuration, when I select "Deploy and Application to AWS CodeDeploy" from the post-build action dropdown, nothing happens. I am not presented with the parameters to deploy my app. I looked in my javascript console and get the following error in my browser:
GET http://internal-awslbjenkinsed01-572120769.us-east-1.elb.amazonaws.com/job/…l-awslbjenkinsed01-572120769.us-east-1.elb.amazonaws.com%2F&credentialsId= 504 (GATEWAY_TIMEOUT)
I have confirmed this with multiple users and multiple browsers, with both 1.5 and 1.6 of aws-codedeploy-plugin. We are running Jenkins 1.596.2

Also confirmed on 1.609.1
Any updates on this?

I'm seeing this as well running Jenkins 1.617

HI,
Thanks for the feedback, we will look into this issue.
We will update this once we find the root cause.
Thanks!

This appears to have been the case when operating behind a proxy server. Once I added the proxy configuration to Manage Jenkins > Configure System and under the AWS CodeDeploy Credentials section, I was able to operate again. Closing for now.


[5.2] Bump runtime to load backward compatibility hacks from __swift52_hooks

@swift-ci Please test


drop class constrain in promise for linq support

#2522
Started with first place. If you fine checkin one by one, please let me know. Will sign agreement then. My research have shown that it is fine one by one, as all childs do drug constraint with them, so changes on parent has ZERO effect on existing code.

@dzmitry-lahoda I'm going to close this PR whilst discussion is still taking place on #2522; the changes required to drop the class constraint are much more pervasive than the changes in this PR.


🐛 Bug:  Union array only having an array on the last item

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Expected
  /** SDL: completionRecommendations: [CompletionRecommendationItem!]! */
  completionRecommendations: (
    args: undefined,
    obj: { root: GamePlayedAsParent<Extended>; context?: RedwoodGraphQLContext; info?: GraphQLResolveInfo }
  ) => Promise<RTCompletionPuzzleRecommendation | RTCompletionRecommendation | RTCompletionSeriesPuzzleRecommendation[]>

Should be
  /** SDL: completionRecommendations: [CompletionRecommendationItem!]! */
  completionRecommendations: (
    args: undefined,
    obj: { root: GamePlayedAsParent<Extended>; context?: RedwoodGraphQLContext; info?: GraphQLResolveInfo }
  ) => Promise<(RTCompletionPuzzleRecommendation | RTCompletionRecommendation | RTCompletionSeriesPuzzleRecommendation)[]>

Actual
-`
Additional Info

fixed by https://github.com/puzzmo-com/sdl-codegen/commit/ab7aa1e0514cc7aa4032f6b2fbe3f8e6d60215d4


Fix golint error

Fix https://github.com/PaddlePaddle/cloud/issues/609

@typhoonzero create an ISSUE and fix it yet.


warning: litfsi angle OB-SB-OB 4-2-5 102.57 removed

I have adopted the FF for ntf2 (TFSI) from fftool/examples/Trial/il.ff. I am receiving a warning while building the lammps file 'warning: litfsi angle OB-SB-OB 4-2-5 102.57 removed'. Are you aware of the cause for this. It is actually reducing one of the angle types i.e. O-S-O from the data.lmp file and probably due to which pressure fluctuations are high during npt.

Maybe in your input geometry the O-S-O angle is too far from 118.5 degrees (equilibrium angle in the force field).
I don't have that problem with ntf2 with geometry from ilff/ntf2.zmat

Thanks for the reply. I will check that.
Best wishes
Tribeni

I am using the ntf2 file and the warning disappeared. You were right. My initial geometry was not optimized perhaps.
Thanks
Tribeni Roy


ClaimList Broken

Claim list doesn't show anything its all blank

.

Closing as the command now works.