Setup documentation

Any plans to simplify the deployment?
I'm not a pro by any means but I'm no noobie either but the setup to deploy this app is very cumbersome and I'm not able to get it to work.
Why 2 compose files + .env? Why are there so many entries for domains and IPs and ports? There is literally no info about email setup. Why do I need to migrate db? What are fixtures and why do I want to load the setup.json? Why isn't in automatical?
What do I need to add to my Proxy manager? the app + api + static? no idea. I don't need anything else other then to be able to login through my snypy.domain.com and add snippets. I don't thing I need to work with rest api or anything else.
Sorry, I don't mean to sound ungrateful. I really dig the design and functionality. It's exactly und exactly what I'm looking for. And I (and 100% other users) would really love a simplified setup - or at least better documented to enjoy this really good looking app.

sadge

The setup process a a bit smoother now since https://github.com/snypy/snypy-docker/pull/33 and the 1.5.0 release.
We still need multiple compose files in order to extend the behavior, we may be able to also to this with environments.
The proxy is currently required to forward the traffic and manage ssl certificates. I'm thinking on adding an additional compose file that includes the proxy. This should make it easier to run the application on a local server.


Serialize attributes correctly & add serialization tests

Serializing TreeElement's attributes looses the data type encoded in it, causing problems with data storage, like xforrm dateTime types being treated as dates.
Attribute serialization has always been broken but I think some redundancy in trigger firing has masked that fact. The issue has probably arisen now that I've optimized trigger firing.
Has potential to increase size of serialized form instances by ~25%
http://manage.dimagi.com/default.asp?188492
cross-requested with https://github.com/dimagi/commcare/pull/215 and https://github.com/dimagi/commcare-odk/pull/894

Changed to target master https://github.com/dimagi/javarosa/pull/208


Feature Request: Indicate what has happened on the PR

Maybe add an icon or some extra text indicating if a comment/commit/merge happened?
Thoughts?

Fixed in #175 and live in v0.3.5 :)


Disable Zap for BSC:GUARD + FANTOM:TOMB

GUARD has 1% tax
https://wolf-den.gitbook.io/wolfies-crypto/protocol/overview/usdguard#tokenomics
TOMB has 1-26% tax
https://docs.tomb.finance/protocol/gatekeeper-fee-system

seems a lot of changes to disable TOMB only on withdrawals? deposits works fine


better error message when config is missing

Some of us don't read the directions.  So, when I just ran it after building:
$ yaib
Error: No such file or directory (os error 2)

Someone who typoed the filename of the config would be lost.

makes sense, I saw your PR and thanks for the report.


Winston logging failing at stdout logging

Below is my simple code to configure winston. But its failing at runtime when node.js server started,
var winston = require('winston');
winston.log('info', 'Hello distributed log files!');
winston.info('Hello again distributed logs');
winston.level = 'debug';
Exception:
Uncaught TypeError: Cannot read property 'write' of undefined
at exports.Console.Console.log (http://localhost:8080/public/bundle.js:110094:19)
at transportLog (http://localhost:8080/public/bundle.js:109429:15)
at http://localhost:8080/public/bundle.js:45186:13
at _each (http://localhost:8080/public/bundle.js:45086:9)
at Object.async.each (http://localhost:8080/public/bundle.js:45185:9)
at exports.Logger.Logger.log (http://localhost:8080/public/bundle.js:109441:9)
at Object.winston.(anonymous function) [as log] (http://localhost:8080/public/bundle.js:28305:34)
at Object.defineProperty.value (http://localhost:8080/public/bundle.js:57848:9)
at webpack_require (http://localhost:8080/public/bundle.js:20:30)
at Object. (http://localhost:8080/public/bundle.js:58069:23)
server.js file:
var path = require('path');
var express = require('express');
var webpack = require('webpack');
var config = require('./webpack.config.dev');
var app = express();
var compiler = webpack(config);
app.use(require('webpack-dev-middleware')(compiler, {
noInfo: true,
publicPath: config.output.publicPath
}));
app.use(express.static(__dirname))
app.get('*', function(req, res) {
res.sendFile(path.join(__dirname, '/index.html'));
});
app.listen(8080, 'localhost', function(err) {
if (err) {
console.log(err);
return;
}
console.log('Listening at http://localhost:8080');
});

Somehow I am able to solve this issue,  but its failing throwing
Uncaught TypeError: fs.stat is not a function
Can  anyone please help?

Can anyone please help?

@KalpanaPagariya Did you ever find a fix for this? I'm currently seeing it as well.

@KalpanaPagariya you wrote that you were somehow able to solve this issue - i just ran into the same issue - how did you solve it?

+1

Winston is not written for browser usage. http://localhost:8080/public/bundle.js:110094:19 shows that you are running in the browser and not on node process.
But there is a way to tweak the console transport for browser usage:
In my Gruntfile.js on string-replace task I have this configuration:
    winston: {
        files: [{
            src: "node_modules/winston/lib/winston.js",
            dest: joinPath(env.dir.build, "winston.js"),
        }],
        options: {
            replacements: [
                {
                    pattern: /process.stdout.write/g,
                    replacement: "console.log",
                },
                {
                    pattern: /process.stderr.write/g,
                    replacement: "console.error",
                },
            ],
        },
    },

Before bundling the sources, copy winston.js by string-replacing the node-process relevant process.stdout and process.stderr calls to the browser console relevant calls. Webpack now needs to pack this transformed winston.js file.
I know, this is not the cleanest way, but since the Winston staff denies to adapt Winston for browsers, this is the fastest way to have always the newest Winston version running in browsers, without the need to fork the project and maintain it afterwards for a long time.

This should be fixed by https://github.com/winstonjs/winston/pull/1279 – please consider upgrading to the next version of<EMAIL_ADDRESS>when it ships tomorrow.

TypeError: fs.stat is not a function


BDOG-391: Add filtering of service dependencies on repository archive…

…d status

Can we add archived to Dependency? That way we are filtering by a known field, rather than some mysterious one (makes the naming of it etc natural too).
It looks like it's not simple since the /api/teams/:team just returns a json object of a map of String -> Array[String] - rather than a resource.
Out of scope of this ticket, but the teams-and-repositories endpoints are all a bit random - e.g. /api/teams/:team doesn't return one of the resources returned by /api/teams - ideally we'd clean this all up and do something more RESTful.
An alternative is to leave service-dependencies as it is, and catalogue can request all the non-archived repositories from teams-and-repos directly, and then filter the results from service-dependencies with this extra meta.


Better error message when displaying a FlutterEngine that hasn't been run

The current behavior is Flutter crashing on an assertion.
-(void)viewDidAppear:(BOOL)animated {
  FlutterEngine* engine = [[FlutterEngine alloc] initWithName:@"" project:nil];
  // When the following `run` call is missing erroneously, Flutter just crashes in an assert.
  // We should provide better feedback.
  // [engine run];
  FlutterViewController* viewController = [[FlutterViewController alloc] initWithEngine:engine nibName:nil bundle:nil];
  [self presentViewController:viewController animated:NO completion:nil];
  [super viewDidAppear:animated];
}

@chinmaygarde I guess throwing NSException with proper message, will work. I am new here, if you guide me, I can take this up.


Xenium data

Hi,
Thanks for the great tools. I am wondering if Starfysh is also working for Xenium data analysis? It would be of great help if there is a tutorial to perform spatial analysis on Xenium data.
Thanks a lot.
Bo

Hi Bo,
Thanks for reaching out! Starfysh is compatible with multi-cell resolution ST datasets such as Visium, Slide-seq, etc.. While we notice the increasing interest in Xenium, the platform provides single-cell resolution and doesn't fit into the current Starfysh usage (deconvolution & downstream analysis).
We recommend checking 10X github repositories or reach out to Janesick et al., (2021). We'll also notify users if we decide to include Xenium integration in the future.
Best,
Yinuo


Failing tests for revised Client Credentials behavior

Changes
TBD
References
Closes #631
Testing
See commit list for failed tests added for new/fixed functionality.

[x] This change adds unit test coverage
[x] This change has been tested on the latest version of WP

Checklist

[x] I read Auth0's general contribution guidelines?
[x] I read Auth0's code of conduct guidelines
[ ] All existing and new tests complete without errors
[ ] All code quality tools/guidelines in the Contribution guide have been run/followed
[ ] All relevant assets have been compiled as directed in the Contribution guide, if applicable
[ ] All active GitHub CI checks have passed

Codecov Report

Merging #632 into master will decrease coverage by 0.11%.
The diff coverage is 69.23%.

@@             Coverage Diff              @@
##             master     #632      +/-   ##
============================================
- Coverage     37.83%   37.72%   -0.12%
+ Complexity     1243     1240       -3
============================================
  Files            51       51
  Lines          3840     3830      -10
============================================
- Hits           1453     1445       -8
+ Misses         2387     2385       -2

Impacted Files
Coverage Δ
Complexity Δ

lib/api/WP_Auth0_Api_Abstract.php
93.5% <58.33%> (+21.16%)
27 <0> (-6)
:arrow_down:

lib/api/WP_Auth0_Api_Client_Credentials.php
90.62% <78.57%> (-9.38%)
11 <4> (+3)

lib/WP_Auth0_Options.php
73.26% <0%> (-10.9%)
28% <0%> (ø)

lib/WP_Auth0_Api_Client.php
31.7% <0%> (-1.36%)
81% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bddec6...6153378. Read the comment docs.

Codecov Report

Merging #632 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #632      +/-   ##
============================================
+ Coverage     37.83%   37.96%   +0.13%
+ Complexity     1243     1240       -3
============================================
  Files            51       51
  Lines          3840     3832       -8
============================================
+ Hits           1453     1455       +2
+ Misses         2387     2377      -10

Impacted Files
Coverage Δ
Complexity Δ

lib/api/WP_Auth0_Api_Client_Credentials.php
100% <100%> (ø)
11 <4> (+3)
:arrow_up:

lib/api/WP_Auth0_Api_Abstract.php
100% <100%> (+27.65%)
27 <0> (-6)
:arrow_down:

lib/WP_Auth0_Options.php
73.26% <0%> (-10.9%)
28% <0%> (ø)

lib/WP_Auth0_Api_Client.php
31.7% <0%> (-1.36%)
81% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bddec6...c3ba87a. Read the comment docs.


README: deemphasize v1, add list of versions with import paths

This adds an overview of the version options to
https://github.com/tailscale/tailscale-client-go
It removes the v1 example (it's in the godoc if people want it), lists
v2 first, put provides godoc to both.
This is the information I look for first when looking at a GitHub
README for a Go project.

Thoughts on this, @oxtoacart?

Rendered: https://github.com/tailscale/tailscale-client-go/tree/bradfitz/readme_index


In app event collection

There are some conflict due to libraries upgrade to work with the latest AppsFlyer SDK

merge in-app_event_collection branch


Investigate Metadata network-config

There is some limited functionality to how MDS uses network config and we should investigate which features we may be missing from capi/cni/etc. if we solely rely on the MDS.

Do we need to disable network helpers?

Possible good reading: https://www.linode.com/docs/products/compute/compute-instances/guides/metadata/?tabs=linode-api

the default cluster template is now using metadata correctly, closing this out


ENH: add possibility to fix parameters in multivariate normal fit

What does this implement/fix?
This is a follow up from #18361: add the possibility to fix mean and covariance during fitting a multivariate normal to data. Such functionality is built in for univariate distributions. The math is pretty straight forward, the tricky parts are useful error messages.

@dschmitz89 I took another quick look but I wasn't sure that you were done addressing comments. Please ping me when you think this is ready for another look.

Could you point to the reference that the math is as simple as this when one shape is fixed?

You mean that the covariance matrix is fixed? That should be covered here. $\mu$ does not depend on $\Sigma$ but $\Sigma$ on $\mu$.

Thanks @mdhaber , I was about to fix the last errors now but you already went ahead, much appreciated.


Added public access to Tree in TreeSitterClient

There are two main issues here. The first is that you must use copy to maintain minimal thread safety. And, this method can only be safely called on the main thread.
But, the second issue is a little higher-level. This will return the current state of the tree, which may not match the current state of the text. My guess is almost every user would want a tree that represents the text as it exists at the time the function is invoked.
It may make more sense to create a function that works more like executeResolvingQuery(_:in:executionMode:completionHandler:). That way, you can guarantee that any pending edits have been processed by the time the tree is returned.

Thank you for your response, Matt.

I think we should return a tree when the user asks for a tree. If they want a copy they can invoke tree?.copy() function. Or we can convert the computed property to a function as seen below but it may not look intuitive.

func getTree(copy: Bool) {
}

Overall, I think copy should be more of an explicit operation so that users are aware that they will be getting a copy, even if copying is a low-cost operation in tree-sitter. Moreover, it's best to avoid side effects in computed properties. ( I believe invoking a copy() internally updates the reference count in the Nodes, instead of creating an actual copy)
Regarding thread safety, we can put a main-thread precondition.

Yes. I agree. Will update the PR soon for this. Also, if we have this function that guarantees integrity, then probably issues in point no.1 also will get addressed.

Let me know your thoughts.

The key issue is that "tree" represents internal, non-trivial state that the user cannot predict. When they ask for a "tree", what tree are they actually asking for? The state it currently happens to be in right now? TreeSitterClient might be only half-way through processing a document when you invoke it.
I see no way to guarantee predictable behavior without a little more context.

Ok. I am able to follow what you are saying.
Fetching a tree in a regular computed property is a bad idea. It is not as trivial as it looks.
I think it would be better to make an async function that will return the tree only when the pending process is complete.
On a different note, will it make any sense to expose the Tree type to the users? Could there be a more elegant way to expose all the nodes? Something like treeSitterClient.enumerateNodes(eachNode: (Node) -> Void)

@mattmassicotte I am trying to find a way where I should be able to determine if a tree is actively getting updated.
Should I use hasQueuedWork to check if there are any outstanding edits that are pending?
Can you help me with some pointers?

Access must follow a pattern like in executeResolvingQuery:
let startedVersion = version
queue.async {
    self.semaphore.wait()
    let state = self.parseState.copy()
    self.semaphore.signal()

    OperationQueue.main.addOperation {
        guard startedVersion == self.version else {
            completionHandler(.failure(.staleContent))
            return
        }

        // call a callback here
    }
}

I failed to understand the purpose of version.
As I can see, it's a private property and is initialized once to zero and never mutated again.
From what I can see startedVersion == self.version will always resolve to true.
Can you help me understand?

Gah, this is a bug! Version absolutely does need to be changed. Glad you found this!

I have added a method to fetch the tree based on your inputs.

Ok, I think this is really close, and a great thing to add.
I'd prefer the return type to have a non-nil tree though. In the case of nil, we can return .failure(.stateInvalid).

Done


Create drop down within code

https://forum.ghost.org/t/add-dropdowns-to-main-menu-through-the-site-admin-copy-paste-into-site-header-footer-injections/30551

Have you got a wireframe for this? What do you want to use it for, and where?

How come the drop down words don't reflect the page titles?

The titles are set in the navigation config - they don't automatically use what the page titles are, presumably because not everyone will want this. We can of course change them to match the titles.
I've had to make a bit of a guess what to use in some places, so if you think they should be changed it's probably simplest for you to adjust them in the config on ghost.dc.coop directly?

I've also had to make a bit of a guess about the styling for the drop-down.  The example above didn't work out of the box, I had to make various changes for it to work acceptably.  And some of these changes were aesthetic changes, but again these might not align with other people's aesthetics. You as the designer who should make the call there.  So let me know if you think we should change something, bearing in mind the relatively short time we have left.
There's also the menu at the bottom of the page.  Again I've made some guesses. I stopped short of making the options stack up vertically - basically because I want to check you want that for sure before I spend the time tweaking it around any more. We should probably discuss this?


Link data design

Coverage increased (+0.3%) to 97.793% when pulling c88578d4609960420b85435e7d401958732b642c on MrCreosote:link-data-design into eece2577355acb49713f9c6bb959efe332227b6e on kbaseIncubator:master.

@scanon and @psdehal approved out of band


good perfect job it's so FAST

first i say thanks for this good job.
i run the python and it's perfect
i've already locating for a similar tool becasue i always using manual decrypt
The Version 0.1 don't work (py also php)
thanks Bro

Thanks for the positive feedback! =)


Fix/greedy input selection only with active stake keys

Context
Currently, the greedy input selector is used whenever the user has more than 1 reward account and tries to delegate, even if delegating to a single stake pool.
Scenario:

User enables multi-delegation and delegates to 2 pools. 2 stake keys will be created.
User disables multi-delegation and delegates to a single pool.
User wants to change delegation to another pool. Unexpectedly, inputs would be selected by the Greedy algorithm instead of the round-robin one. This should not occur because the user has only one active stake key.

Proposed Solution
Use greedy input selection only when:

Multi delegating: distribute the funds to multiple addresses.
Reducing the number of pools to 1, which implies we have multiple registered stake keys. This is needed to concentrate the funds back into a single address and delegate its stake key.

Important Changes Introduced

Hey Folks! In case you haven't noticed, this PR actually does break CI/CD. Let's scramble to see what we can do.


update Rails version dependency

I intended to drop support for 3.2, but dependecy wasn't.

Thanks!


The win2016-standard templates use a template variable to define the "memory" user variable

List generated by the following...
$ packer --version
1.5.1
$ for name in *.json; do packer validate $name 1>/dev/null || printf '- [ ] %s\n' "$name"; done

[x] win2012r2-standard.json
[x] win2016-standard-cygwin.json
[x] win2016-standard-ssh.json
[ ] win7x64-enterprise-ssh.json
[ ] win7x64-pro-cygwin.json
[ ] win7x64-pro-ssh.json
[ ] win7x86-enterprise-cygwin.json
[ ] win7x86-enterprise-ssh.json
[ ] win7x86-pro-cygwin.json
[ ] win7x86-pro-ssh.json
[ ] win81x64-enterprise-cygwin.json
[ ] win81x64-enterprise-ssh.json
[ ] win81x64-pro-cygwin.json
[ ] win81x64-pro-ssh.json
[ ] win81x86-pro-cygwin.json

This issue is related to #196, and issue #194. I think this issue covers the rest of the templates that have a bad/outdated schema.

This is closed by PR #199.


Interpreter segfaults with recursion.

This code segfaults on my machine.
func recTill(n: Int) {
    if n <= 0 {
        return
    }

    recTill(n-1)
}

recTill(10000)

So, I don't quite know why it does this, if this just how Swift handles recursion?
I didn't even know Swift code can segfault, thats just such an ungraceful way.

I don't think we can solve this, all I could find on the internet is that this is just how stackoverflows are handled.


Util class design documentation

Description
Documentation on UtUtils class use cases.
Details
Rearrange design doc to be more strict and easy to understand.
Add it to the design docs in the project.

It is just a link to insert into a resulting doc:


Finishing up

Description
This issue describes the set of tasks to complete in order to finish up work on the library.
Tasks

[ ] Touch base with the @jobarratt and @pwalsh to notify that you consider the work complete
[ ] Provide a short description / link to code for how each action is implemented, with a link to unit tests that prove each action
[ ] Tag your candidate code as v0.1
[ ] Setup travis to auto deploy tagged versions to the package management solution for your language
[ ] Ensure that the OKI account on the package management platform is an administrator/maintainer of the package, along with yourself
[ ] Receive code review from @pwalsh and address any remaining issues
[ ] Publish final version

@georgeslabreche
Are we ok to close this one?


Clean up CLI

This gets rid of a bunch of CLI code that handles synchronization - there's no need to do it. This is mostly a leftover from when we had different types of interfaces, but it also took a few PRs (#748, #749, and #750) to prep for it.

@prbot approve


Action bars are not hiding properly

Actions bars are not getting hidden even though in Wow interface and the addon configuration, the Always show action bar check is unchecked
They hide once you press P and skill book opens...
They also disappear if you mouseover it

they also dissapear again if you hover the mouse cursor over the slots, but they reappear anytime

Please check "Always Show Action Bars" in the Blizzard Options, and let Dragonflight UI manage show/hiding. Set your prefered options, and "/reload" once to make everything work correctly.

That worked 👌🏻


Bug: Rllib evolution strategies

When trying ES in tensortrade i have this error
File "/home/andrea/anaconda3/envs/tensortrade_beta/lib/python3.6/site-packages/ray/rllib/agents/es/es.py", line 142, in do_rollouts
    rewards_pos, lengths_pos = self.rollout(timestep_limit)
  File "/home/andrea/anaconda3/envs/tensortrade_beta/lib/python3.6/site-packages/ray/rllib/agents/es/es.py", line 111, in rollout
    add_noise=add_noise)
  File "/home/andrea/anaconda3/envs/tensortrade_beta/lib/python3.6/site-packages/ray/rllib/agents/es/policies.py", line 23, in rollout
    env_timestep_limit = env.spec.max_episode_steps
AttributeError: 'NoneType' object has no attribute 'max_episode_steps'

Seems a problem on how Tradingenv inehirit env_timestep_limit from gym env

I have managed to do successful PBT with master branch (today). Re-open if still any issues and kindly provide an example notebook so we can help you. Thanks.


Feat/add news section

Summary (Please recap what you changed or fixed)

Checklist (If you won't pass this checklist please comment why)

[ ] I removed all commented or unnecessary code.
[ ] Provide the screenshots due to UI changed or bug fixed
[ ] My code has covered these test cases (please list down your tested cases):

LGTM


[BUG] Error on clicking on project.

Description of the bug
When we click on project then the error 404 occurs.
Please add screenshots (if applicable)

Add any other context about the problem here
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

This has been resolved, so closing the issue.


No 4.0.x branch

The readme says that Laravel 5 is in development on the 4.0.x branch, but such a branch does not exist.
Does this mean that a L5 version is not at all usable right now?

4.0.x is a branch alias or master.


Loki support through LEC

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Customer - Wasabi uses Granfana and would like to use Loki for logging
Describe the solution you'd like
A clear and concise description of what you want to happen.
Ability to connect to Loki for logging
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
They currently use Elastic but they are sunsetting it and moving forward with Loki
Additional context
Add any other context or screenshots about the feature request here.

i've been doing some work on this.
https://grafana.com/docs/loki/latest/clients/fluentd/
shows we can add the fluent-plugin-grafana-loki to the gem file it then needs the loki_url as an environment variable
The main issue is the labels and classification

Thank you for the update, @tonylokko. Please let me know if you need any more information, I think my customer would be willing to meet to share anything else you may need.


Self-check continues to run after removing all orders.

Hey, sorry, I tried Slack but I couldn't figure out how to get in.
I'm on Azure Kuberentes Service using the cert-manager helm chart version 0.13.0.
I have been using cert-manager for almost a year now and is has been great. For the last day or so my ingress (Nginx) has been receiving what I believe are self-check requests. I'm not totally sure what triggered them, but I am seeing them every 10 seconds and they are all getting 404 responses. I have read here that this 10-second retry interval is expected for self-checks that have failed and that one potential resolution is to delete the corresponding order resource. I have done that (there were a few order resources) but I am still getting the self check requests.

As you can see the challenge comes in, gets redirected to the HTTPS URL, comes in again on the new URL and gets a 404 error. That cycle repeats again 10 seconds later.
I see from the troubleshooting steps that I should check if my acmesolver pod is running, and it is not:
$ kubectl get pod --all-namespaces | grep -i acme
<nada>

There are also no order resources because I deleted them all:
$ kubectl get order --all-namespaces
No resources found

And no challenge resources (I couldn't find any challenges even before deleting the orders):
$ kubectl get challenge --all-namespaces
No resources found

When I request the challenge endpoint myself (http://mydomain.com/.well-known/acme-challenge/IGc1S2wee4NeCrVSgDHEr85Fc0YclNutI1AmWM6eL4A) I also get a 404 error.
Expected behaviour:
I would expect the self-checks to stop after deleting the order resources, as per the challenge lifecycle description.
Steps to reproduce the bug:
I'm not sure, unfortunately.
Environment details::

Kubernetes version: 1.19.7
Cloud-provider/provisioner: Azure
cert-manager version: 0.13.0
Install method: helm

Thanks!
/kind bug

Hi @MaxTaggart,
Thanks for opening the issue- could you please try upgrade to one of the newer versions of cert-manager and see if the error still occurs?
Current version is v1.3.1, but you should probably upgrade incrementally and check the release notes for all the versions in-between as there have been some breaking changes.
This might be some issue that has been fixed since v0.13.0.

I tried Slack but I couldn't figure out how to get in.

You should have been able to join #cert-manager Slack channel on Kubernetes Slack which you can join here

Hey,
It turned out that we had a mismatch between the host entry in our ingress and our actual hostname. Sorry for the false alarm!


README.md doesn't tell what to expect after server start

I followed the Getting Started, and after doing the aqueduct create -n my_project I followed the instructions in the README.md. All went well (on one of my Macs), but after starting my new server, I didn't know what to expect. When I tried just localhost:8000 in my browser, I got an empty page. If I tried localhost:8000/users, I got {"error":"No authorization header."}. At least some response. I think the README.md should give a hint about what one have to provide next.

Yes, good idea.
Add link to template tutorial (#114) in README.md for generated projects.

Addressed in 2.0 branch


Switch back to a single WebPack config

cf #728.
Fixes #715.  Fixes #699.

@ellisonbg, this also fixes syntax highlighting again ;)

Looks good to me, works for me, and passes tests. Thanks!


Examples for the alpha release

The read-me recommends using the alpha release for new projects. The API docs only target the stable release. Would it be possible to see an example for validating a form with custom input-groups as shown below? I'd like to have the styled input-group-addon spans in the group.

You can see the v1.0 API docs here: http://kaliber5.github.io/ember-bootstrap/api/v1.0/
You will have to use the "Custom controls" method: http://kaliber5.github.io/ember-bootstrap/api/v1.0/classes/Components.FormElement.html. Will try to put an example of this use case into the upcoming demo app!

Thanks @simonihmig. I've got this working, and the validation on my model (ember-cp-validations) halts the submission of the form, but all the elements are marked valid with the classes form-group has-success has-feedback. The form won't submit no matter how I fill it, and all the fields always show has-success. This gist shows my model and form template: https://gist.github.com/stephencarr/53c8c0e11f326de432cc543f69c12f4e

Looks good at first glance. Might be related to ember-bootstrap-cp-validations, which needs an update. The PR has just been merged a few hours ago, make sure to use this new release of it: https://github.com/offirgolan/ember-bootstrap-cp-validations/pull/9#event-907883291

This worked, thanks so much. Only comment is the icons are not lined up - I think I saw something in source that was supposed to deal with this, I may be wrong. I can fix this in my CSS though.


How to send some dynamic data to callback from ininlineKeyboardMarkup ?

I have case, when I build ininlineKeyboardMarkup with several buttons following way:
fun InlineKeyboardMarkupBuilder.gameMarkup(games: List<String>) {
    games.forEach {
        it callback DELETE_GAME
    }
}

And I have handler function:
@CommandHandler.CallbackQuery([DELETE_GAME])
    suspend fun handleDeleteGame(user: User, bot: TelegramBot, update: CallbackQueryUpdate) {
        // LOGIC
    }

I want to send name of the game (String) to handler fun. How can I do that?
I've read wiki and haven't found the answer :(

if I understand correctly you want to get a parameter from the callback to the handler function, right?
In this case you just need to add this parameter to the callback itself and declare the corresponding parameter in the target function :)
fun InlineKeyboardMarkupBuilder.gameMarkup(games: List<String>) {
    games.forEach {
        it callback "deleteGame?name=${it.name}"
    }
}

and in target function you just declare:
@CommandHandler.CallbackQuery([DELETE_GAME])
    suspend fun handleDeleteGame(name: String, user: User, bot: TelegramBot, update: CallbackQueryUpdate) {
        println(name)
    }

you can read more about there:
https://github.com/vendelieu/telegram-bot/wiki/Update-parsing
https://github.com/vendelieu/telegram-bot/wiki/Activity-invocation

It is definetly what I need! Thank you!


SingletonClass and MongoMapper

I dont know very much about MongoMapper, but... I try open one object and put more attributes and I had this problem:
My class arealy have the @keys hash then MongoMapper returns only on my class hash and dont look the hash of my SingletonClass... then attr_acessor created by MongoMapper, validates and etc dont work for attributes that I add for my object.
I overwrite the keys method like this:
def keys
@keys ||= {}
@keys = @keys.merge(self.singleton_class.keys) if self.singleton_class.respond_to? :keys
@keys
end
Works fine for me, but i dont know if this is the better solution.

@phiny Please post your question to the mailing list. You're more likely to get a response there, and we try to keep the GitHub Issues for known bugs and planned feature requests.


Can not load installed extension and recommend extension

VSCode Version:
Version: 1.50.1
Commit: d2e414d9e4239a252d1ab117bd7067f125afd80a
Date: 2020-10-13T14:53:05.704Z (2 wks ago)
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0
OS Version: 10.15.7

Steps to Reproduce:

When I open extension window vscode can not load any installed extension and recommend extension, I've already installed some extension but I cannot see them in the list. This happen recently

Does this issue occur when all extensions are disabled?: Yes/No

And when I search some extension there is no http request in developer tools

Please follow these steps

Help -> Toggle Developer Tools -> Console - Check if there are any errors
View -> Command Pallette... -> Toggle Shared Process -> Console - Check if there are any errors
View -> Open View… -> Log (Shared) - Check if there are any errors
View -> Open View… -> Log (Window) - Check if there are any errors

Help -> Toggle Developer Tools -> Console show this

There is no response when click View -> Command Pallette... -> Toggle Shared Process -> Console
And there is no Log (Shared) option

View -> Open View… -> Log (Window) - Check show this

This explains - there is no shared process.
Assigning to @deepak1556 / @joaomoreno - not sure who owns the shared process now.

@Bleichroder Can you reproduce with a branch new user data dir? --user-data-dir NEW_FOLDER

@Bleichroder Can you reproduce with a branch new user data dir? --user-data-dir NEW_FOLDER

Yes it reproduce when I open vscode with user data dir. I can use some of the extensions I have Installed, like gitlens, but cannot see installed or search extension in list

This might very well be a corrupted launch service state, @Bleichroder can you restart your system and this time open vscode  via the dock or finder or use open -a <path-to-app> for command line. Let me know if the issue still repros.

This might very well be a corrupted launch service state, @Bleichroder can you restart your system and this time open vscode via the dock or finder or use open -a <path-to-app> for command line. Let me know if the issue still repros.

I've restart the system several times and reinstall vscode with other version, but this still happen....

How are you launching the app ?

How are you launching the app ?

I have try launching vscode via finder and dock, both are same situation

Can you provide the output of code --verbose

verbose.log

Can you provide the output of code --verbose

Did you try to search for extensions in the above launch ? I don't see any error wrt shared process creation.

As a follow-up, see if you can get the following traces

xcrun xctrace record --template 'System Trace' --output <some-path>/code_system.trace --launch /Applications/Visual\ Studio\ Code.app/
Once the editor opens, click the extension tab and try to search for extensions
Quit the app
xcrun xctrace record --template 'File Activity' --output <some-path>/code_file.trace --launch /Applications/Visual\ Studio\ Code.app/
Repeat steps 2) and 3)
Attach the traces code_system.trace and code_file.trace either here or you can send them to<EMAIL_ADDRESS>since they contain sensitive data.

I have send you a email. Thanks

Thanks will look into them, today.

Is there any new development?

ping @deepak1556

ping @deepak1556

@Bleichroder can you try the latest insiders https://code.visualstudio.com/insiders that contains a refactor for spawning shared process.

@Bleichroder can you try the latest insiders https://code.visualstudio.com/insiders that contains a refactor for spawning shared process.

new version has resolve this problem, thanks all

new version has resolve this problem, thanks all


Make a high level roadmap

Let's put together a high level roadmap of what we want to do and in roughly what order we want to it in. We can document it and ROADMAP.md and refer to it from both the readme and contributing file.

Maybe use a board like: https://github.com/orgs/govdirectory/projects/2 ? We can use notes for high-level things and issues for more defined tasks.

I think a board will be very useful but this could be even more high level almost carving out what the idea means in practice. It should be of so low detail that we hopefully don't need to update it very often at all.

After discussion in today's meeting. Let's use the board, milestones alongside with the MVP we defined today. @Abbe98 is it enough by capturing "As an MVP we want to create an working website where people can search, filter and add data about Swedish public institutions and their social media accounts." as text somewhere (and then the other parts could become issues with the Demo day milestone)?

Yes Sounds good to me!


Failed to run Updater

This is what i get when i test your example application as is
Release notes link: "http://kineticwing.com/changelog"
Pub. date: "Wed,  20 August 2014 19:20:11 +0000"
Enclosure URL: "http://kineticwing.com/get/linux/KineticWing32.tar.gz"
Enclosure version: "2.0.2"
Enclosure platform: "Q_OS_MAC"
Enclosure length: 1618935
Enclosure type: "application/octet-stream"
Update found 11103
Failed to run Updater

Not developed yet. Couldn't find required time. If you are developer and would like to work let me know.


Enforce odd number of pixels in centroid refinement

Why this PR?
Brought up in the comments during review for #365

Actually, discovered that this is already enforced in the internal function call


slow startup typing performance when explorer contributions are expanded

Windows, Insiders build 1.18.0-insiders commit 4b0145 date 2017-10-19
I noticed that on startup, there is a delay to typing.  The editor comes up, but when I start typing it takes a few seconds for the letters to appear.
Here's all the extensions I have installed
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Profile with extensions:
CPU-20171019T092459.zip
5c2a_main.cpuprofile.txt
5c2a_renderer.cpuprofile.txt

VSCode Version: Code - Insiders 1.18.0-insider (4b01451cea60f32412098735709fddcac567b33d, 2017-10-19T08:29:07.096Z)
OS Version: Windows_NT x64 10.0.15063
CPUs: Intel(R) Core(TM) i5-2400S CPU @ 2.50GHz (4 x 2494)
Memory (System): 7.98GB (2.58GB free)
Memory (Process): 232.49MB working set (234.23MB peak, 200.54MB private, 40.71MB shared)
Load (avg): 0, 0, 0
VM: 0%
Initial Startup: yes
Screen Reader: no
Empty Workspace: no
Timings:

Component
Task
Time (ms)

main
start => app.isReady
37

main
app.isReady => window.loadUrl()
292

renderer
window.loadUrl() => begin to require(workbench.main.js)
442

renderer
require(workbench.main.js)
731

renderer
create extension host => extensions onReady()
612

renderer
restore viewlet
492

renderer
restore editor view state
1386

renderer
overall workbench load
1560

main + renderer
start => extensions ready
2271

main + renderer
start => workbench ready
3178

Here is a profile without extensions loaded, where the performance is ok. So, it has to be an extension.
Profile-no-extensions.zip

Ok, it's when there is an extension that has an explorer contribution, and the explorer contribution is expanded on startup.
To reproduce:

Make sure you have docker installed, and have a couple of images on the machine (e.g. just do a docker pull node:latest)
Install the Docker extension
Open VS code, expand the DOCKER sash so that you see the "Images", "Containers", and "Registries" nodes.
Open a file
Close VS Code
Restart VS Code
As soon as you have a cursor, start typing

Result: huge delay until the Docker Explorer is initialized/visible.
Expected: I don't expect to be delayed by an extension loading.
If you don't want to install Docker, you can install the Azure CosmosDB Extension instead and try the same steps. The key is to have the explorer expanded so that the next time you start VS code it is expanded.

Typing in the editor executes the type command through the command service (for the case of outsourcing typing to the extension host, e.g. the vim plugin).
The command service waits for the extension host to activate * extensions before invoking our built-in type command.
If there are many slow extensions, the extension host will take a while to be ready.

To double check if there is any correlation with the explorer tree besides that having that makes the extension host busy.

/cc @sandy081 for that

Custom views in explorer are lazily activated - When the user expands the view or if it was already expanded before. Initial state is always collapsed.
After activating the extension contributing the view, it will ask the extension for the first level elements and updates the view.. it will also react to the requests coming from the extension (like refresh). Otherwise, explorer view should not be making the main/renderer process busy.
Have to investigate to get more insights.

Some details I observed:
I see some key-strokes lagging with expanded docker view when compared with that of collapsed. For eg: In former, I see text after ~5-6 key strokes and in latter it is after ~2-3. The delta time could be spent in rendering the first level elements of the tree.
I do not see this delta with other custom view extensions like Gitlens and Github Issues and PRs. One difference I see between these and Docker extension is that, docker extension has static first level data and others fetch using git or github.
I am assuming that, since Docker is returning static first level elements, Tree rendering could be happening immediately after extension host is ready and hence the key strokes are lagging little.
Not sure if we can delay rendering of the view further.

@jrieken Maybe we can do the following change to the command service:
When a request comes in to run a command:

if the extension host is not ready yet and if the command is defined in the commands map
we kick off an activation event for that command, but don't wait for it and execute the defined command.

Otherwise, I'm going to have to take the editor's type command out of using the command service, but then I'm not sure what else to use such as to not break the vim case.

@alexandrudima didn't you already make that change? https://github.com/Microsoft/vscode/blob/master/src/vs/platform/commands/common/commandService.ts#L34

@jrieken You're right...
Perhaps what's happening here is that the extension host is ready, but running the activation event onCommand:type takes a long time on the extension host, presumably ... because the extension host is super busy doing tree/explorer stuff ?

Yeah, that's good guess. I have seen the extension host starting quickly but activation taking much longer often...

I'll look into avoiding going to the extension host for activation events which no extension has registered for. This should alleviate the problem with onCommand:type.

Ok this is bizzare. That optimization is already implemented. Activation events don't go to the extension host if there are no extensions registered for them
https://github.com/Microsoft/vscode/blob/fa4c5561c9485a3c4427ec3de5584b9334e3e3c4/src/vs/workbench/services/extensions/electron-browser/extensionService.ts#L222

Ok, not so bizzare. emmet listens to "onCommand:type" which forces that this activation event gets sent over to the extension host. So, effectively, since emmet is a built-in extension, you cannot type in the editor until emmet activates.

I have created PR #36876 for @ramya-rao-a to look into.
I consider my side of things working ok.

@alexandrudima Dies this PR fixes this issue or issue still remains?

@sandy081 The PR makes it that typing in the editor is not blocked by the extension host out-of-the-box. The PR does not change anything else. I leave it up to you if you want to investigate why expanding a tree in the explorer would make the extension host a noticeable number of seconds slower.

Closing this issue as the PR from @alexandrudima fixes the reported issue. Filed a new issue https://github.com/Microsoft/vscode/issues/37393 for investigating the point raised in above comment.

Verified in code and couldn't reproduce any delay.


Evaluate update to Nim 2.x

With gc:refc at first.

I will create subtasks to ensure clear tracking of comments, as I believe we will have many comments.

I updated constantine dependency to the last commit hash because there is a compilation error with Nim 2.X.
Additionally, I updated the PR created by Ben for GCC 14 on nim-poseidon2 to reflect this change.

There is a problem with the default SAT resolver of nimble; it fails when trying to install dependencies; see https://github.com/vacp2p/nim-libp2p/issues/1219.
I will use nimble --solver:legacy install until it is fixed.

With gc:refc at first.

It became mm:refc (https://nim-lang.org/docs/mm.html).

Contributions to sub-dependencies:

nim-poseidon2: https://github.com/codex-storage/nim-poseidon2/tree/bump-constantine-gcc14 (resume Ben's work)
nim-datatore: https://github.com/codex-storage/nim-datastore/tree/update-to-nim-2-x
nim-codex-dht: https://github.com/codex-storage/nim-codex-dht/tree/update-to-nim-2-x
nim-eth-versioned: https://github.com/codex-storage/nim-eth-versioned/tree/update-to-nim-2-x
nim-ethers: https://github.com/codex-storage/nim-ethers/tree/update-to-nim-2-x

Found issue in nim-results:
https://github.com/arnetheduck/nim-results/issues/50
Contribute to nim-testutils to fix case:
https://github.com/status-im/nim-testutils/pull/54

I disabled for now the thread analysis using --threadAnalysis:off


App with a ListView crashes on repeated orientation changes in iOS simulator

Steps to Reproduce

Take an app with a ListView (eg from the write your first flutter app)
add some text concatenation (I'm unsure if this is the problem or if this just speeds things along), eg make line 57 pair.asPascalCase + 'do some concatting',
run the app, rotate the hardware in the sim a few times this way & that, and... crash.

Logs
Terminal just says 'Lost connection to device' but if I run this in Xcode the app crashes with EXC_I386_GPFLT
May be related to #13300 and #6995

Seems like I started getting the same error today after I added some animations to my project. Symptoms are very similar except instead of rotation the app exits when keyboard pops up while there is an animation in progress (I was able to reproduce with scale animations).
Steps to Reproduce
1. Create "increment counter" app:
flutter create scale_bug

2. Update source code
Go to scale_bug/lib/main.dart and replace _MyHomePageState class with slightly adjusted version in this Gist: https://gist.github.com/pulyaevskiy/e266e70cbf71c31aaa6a14ecd7cf0a2a
(Adds a TextField to the Scaffold and when it gains focus forces FAB disappear with "scale down" animation).
3. Run the app (make sure to do clean as well)
open -a Simulator.app
flutter clean
flutter run

4. Tap on the TextField
So that it forces on screen keyboard to slide up.
Result: the app crashes with nothing in logs and "Lost connection to device" in the terminal. Running in Xcode shows error code EXC_I386_GPFLT.

Just got this issue again when using BottomAppBar with a docked FAB. Really annoying when working on a screen with a text input.

Tried to debug this by copy-pasting FAB animator and tweaking it. Looks like disabling rotation animation makes this issue go away, so main culprit at this point is RotationTransition widget.

Captured a stack trace of a zombie object in AccessibilityBridge::UpdateSemantics
@chinmaygarde
 	Malloc/Autorelease (2)	+1	 	00:57.692.599	Flutter	shell::AccessibilityBridge::UpdateSemantics(std::__1::unordered_map<int, blink::SemanticsNode, std::__1::hash<int>, std::__1::equal_to<int>, std::__1::allocator<std::__1::pair<int const, blink::SemanticsNode> > >)
0	 Malloc	+1	1	00:57.692.599	Flutter	shell::AccessibilityBridge::UpdateSemantics(std::__1::unordered_map<int, blink::SemanticsNode, std::__1::hash<int>, std::__1::equal_to<int>, std::__1::allocator<std::__1::pair<int const, blink::SemanticsNode> > >)
1	 Autorelease		 	00:57.692.600	Flutter	shell::PlatformViewIOS::UpdateSemantics(std::__1::unordered_map<int, blink::SemanticsNode, std::__1::hash<int>, std::__1::equal_to<int>, std::__1::allocator<std::__1::pair<int const, blink::SemanticsNode> > >)
2	Retain	+1	2	00:57.692.605	Flutter	shell::AccessibilityBridge::UpdateSemantics(std::__1::unordered_map<int, blink::SemanticsNode, std::__1::hash<int>, std::__1::equal_to<int>, std::__1::allocator<std::__1::pair<int const, blink::SemanticsNode> > >)
3	Zombie		-1	00:57.693.663	Flutter	fml::MessageLoopDarwin::OnTimerFire(__CFRunLoopTimer*, fml::MessageLoopDarwin*)

@goderbauer

Seeing same with just a CustomScrollView at the top level with a SliverAppBar inside. Rotate => Crash.

I am getting this issue using the code from the Flutter Udacity course here

FYI @jonahwilliams Looks like the crash is related to a11y (see @jason-simmons  comment).

I've managed to reproduce this once or twice out of hundreds of orientation changes. While I agree the cause should be found and fixed, I don't have any time to work on it right now

Is this reproducible on iOS physical devices?
Also, it has been a long time since the last update, does anyone still experience this bug?


Delete secrets.rb

Has been dead for a while.
Tick for https://github.com/caskroom/homebrew-cask/issues/17075.

Merged as 8cd83281332bf072174638cf2e8792d1388c0c82.


Added Linux support and support for accessing directories

Added support for Linux into AeroPy, for GUI as well as for headless mode. Added support for accessing airfoils in directories instead of being only able to load foils directly from the main directory for function find_coefficients().

Thank you for this contribution. Previous users had requested compatibility with UNIX, but I was unable to implement it. I am unable to verify the UNIX implementation, but the library still properly functions on a Windows OS.


Log more errors to node

There are some catch blocks that only contain commentedr messages.
My assumption is those are commented so the debug log is not spammed with messages if the device is sleeping.
It would be helpfull when debugging errors when other errors would still surface.
Ther error messages I saw when the device was sleeping contained all EHOSTUNREACH not sure how reliable that is throug.
But a possible filter could look like this:
catch (error) {
    if (!error?.toString().includes("EHOSTUNREACH") ?? false) {
        node.warn("Installing webhook failed " + error);
        node.status({ fill: "red", shape: "ring", text: "Installing webhook failed " }
    }
}

I would prefer a config flag where you can enable or disable verbose logging.

I have it the other way around, that to much is logged.
I have a Shelly that is far away from my wifi APs, so I get many "timeout of 5000ms exceeded".
So yea, agree with Windkh , some flag to control the logging would be nice. Or that it is possible to catch with the node-red catch node.

Another way between could be to only ignore connection errors, but not errors that happen in the logic.
So when API gets changed again (hopefully not) it will log errors, but not if a device is not reachable for whatever reason.

I will do that on a cold snowy winter evening


Update pretrained_word_embeddings example to use new API.

?

@fchollet I think we should use embeddings_initializer to initialize weights for embedding layer, rather than set weights, because in the current API, no explicit argument named as weights. And it will save one assignment/initialization, as if we set weights directly, we still need to do default initialization. If I have misunderstanding, please correct me. Thanks.

Thank you for the PR, @yanboliang. LGTM.


How to create a custom Navigation Observer?

Hey team,
I am planning to use auto_route and want to integrate new_relic for monitoring app metrics. How can I create my own custom navigation observer? I see that you guys have a direct dependency on go_router.

samee issue please some one fix this!

Hey team, I am planning to use auto_route and want to integrate new_relic for monitoring app metrics. How can I create my own custom navigation observer? I see that you guys have a direct dependency on go_router.

Hey team, I am planning to use auto_route and want to integrate new_relic for monitoring app metrics. How can I create my own custom navigation observer? I see that you guys have a direct dependency on go_router.
I think you can do this approach
`import 'package:auto_route/auto_route.dart';

import 'package:flutter/material.dart';
class RoutingObserver extends AutoRouterObserver {
@override
void didPush(Route targetRoute, Route? previousRoute) {
print('did push: ${targetRoute.settings.arguments}');
}
}`

Yeah I agree with your approach and that's how I am implementing right now. But if the package can build some abstraction and we can directly use without depending on a specific routing library. It would be great!

@SAGARSURI we will add support for auto_route in future releases.

@SAGARSURI
New Relic's agent for Flutter applications offers automatic route capture functionality when using the auto_route package. To enable this feature, you need to configure the navigation observer in your app's router setup. Here's how you can do it:
MaterialApp.router(
  routerConfig: AppRouter().config(
    navigatorObservers: () => [NewRelicNavigationObserver()],
  ),
),

By adding the NewRelicNavigationObserver() to the navigatorObservers list in your AppRouter configuration, you allow New Relic to automatically capture route information in your Flutter app.
This setup integrates New Relic's monitoring capabilities with your app's navigation system, providing insights into user journeys and app flow.


[JS] proper error handling

Most of our methods on the JS don't have proper method/exception handling and will simply abort and never return. This can lead to the following complications depending on the allowRepeat argument here: https://github.com/encointer/encointer-wallet-flutter/blob/535ad47adbba62ef2993c1985739650e977682b6/lib/service/substrateApi/api.dart#L147

If allowRepeat = false: subsequent calls to the same JS method will be dropped as only one message completer per JS method may exist.
If allowRepeat = true: there is a theoretical memory leak because we message completers  for failing JS-calls will not be cleaned up.

Current mitigations are simply:

Checking the arguments that are passed on the dart side for sane values as good as possible
#386 changes the allowRepeat value to true, as this is less bad than not being able to make a specific JS-call anymore.

Will close this as JS will be removed soon entirely.


feat: add linear hall position sensor driver

Not entirely sure where the driver files should go, or how exactly the includes are structured, but the basic functionality is here and superficially tested.

Hey @nanoparticle, how do you feel about this? There was a SimpleFOC release today, including the changes to the init() code that you wanted... how about this code? is it ready to merge to the drivers?

I haven't had time to do any real testing on this code beyond seeing if it is a feasible method of sensing. How much testing should it go through before being merged?

Hey @nanoparticle  do we want to merge this? It's still in draft status...
For the drivers repository, the bar is not set very high - you don't have to test much. If it runs in some of your own setups it is enough... each folder in the drivers repository has its own README, so we can add a warning note for users to let them know it isn't tested much...

Also, did you see this one: https://github.com/simplefoc/Arduino-FOC/pull/197
It's a similar implementation, I think...

Upon further investigation, it looks like ADC configuration is a major problem for this sensor approach. As it is, I'm getting about 250 microseconds per analogRead on STM32G031, which is too slow for real world use. Current sense apparently requires an elaborate HAL configuration sequence for every supported platform to get good ADC performance, and separate ones for each STM32 series. That would be a maintenance nightmare to add that many files just for this one sensor. What to do?

Hey @dekutree64 , you're absolutely right, and we're keenly aware of this problem. The ultimate plan looks like this:

the ADC drivers for the different hardwares will be refactored and abstracted by something called "ADCEngine". ADCEngine will have different capability levels on the different hardwares. On simpler hardwares it may only support the inline current sensing of one motor. But on complex hardware (like STM32, Renesas) the goal is to make it support multiple motors, multiple ADCs, current sensing, voltage sensing and other ADC use in parallel
So in future it should be possible for the LinearHallSensor to request some ADC channels from the ADCEngine, and either get them or get an err - not supported. Those ADC channels would be faster than using analogRead() so your use-case should be possible.
There's lots of other use cases like VBUS sensing, OC protection, Voltage sense, etc which would also need this functionality

Yes, ADC sampling is too slow, so this linear Hall angle feedback method is more suitable for use in lower-speed projects such as pan/tilts.
Only a 1-pole pair magnet and two linear Halls need to be installed to replace expensive magnetic encoders.

I have just merged deku's implementation to the drivers repository dev branch, it will be part of the next release... do you all agree we can close this PR (which is still in draft status) in favor of the merged implementation?

Thanks so much to everyone for pulling this over the finish line 👍


Animation SDK

The image_to_prompt function is not backwards compatible ( it takes different input variables ). Can we make it backward compatible?

The image_to_prompt function is not backwards compatible ( it takes different input variables ). Can we make it backward compatible? Should we make it backwards compatible?

I support not worrying about backwards compatibility and releasing this as a major version semver increment, which would then give us the opportunity to push out the stuff associated with the deprecation warnings in the CLI. That's out of scope of animation release though so maybe we could just not concern ourselves with backwards compatibility here and push out the new major version soon after merging the rest of the animation updates.
In any event: if we break backwards compatibility, we should warn API partners before publishing the release.


About dataset when train model

Hello, thank you for your excellent work.
I am curious about the identifiers <doc></doc>, <ocr></ocr>, <md></md> etc. introduced in the DocStruct4M dataset to unify various tasks. I did not see any special treatment for them in the training code, and they did not appear as special tokens.
I would like to ask, during training, are these introduced identifiers treated as normal text? Or are there other processing techniques?
Thank you.

Hi @SWHL, there is no special treatment for such identifiers. They are treated as normal text and just used to distinguish texts parsed from images with normal answers given by the LLM.

Thanks for your reponse. It's very clear.
I have another question about DocDownStream1.0, which does not appear in the paper.
Where is the dataset used?

Hi @SWHL, DocDownStream1.0 is used in 2nd-stage training~

Thanks for your reponse so fast.

Hello, when I read the DocOwl1.5 paper, I meet another question about the special token.
In the Table Parsing part of the paper, it writes you add special text tokens:

But I couldn't find the special token in the DocOwl 1.5 tokenizer's vocab:
{
  "bos_token": {
    "content": "<s>",
    "lstrip": false,
    "normalized": false,
    "rstrip": false,
    "single_word": false
  },
  "eos_token": {
    "content": "</s>",
    "lstrip": false,
    "normalized": false,
    "rstrip": false,
    "single_word": false
  },
  "pad_token": "<unk>",
  "unk_token": {
    "content": "<unk>",
    "lstrip": false,
    "normalized": false,
    "rstrip": false,
    "single_word": false
  }
}

And at the same time, I couldn't find related code in the repo source code.
So how do the colspan and rowspan server as special token?
Thank you very much.

Hello, when I read the DocOwl1.5 paper, I meet another question about the special token. In the Table Parsing part of the paper, it writes you add special text tokens:
But I couldn't find the special token in the DocOwl 1.5 tokenizer's vocab:
{
  "bos_token": {
    "content": "<s>",
    "lstrip": false,
    "normalized": false,
    "rstrip": false,
    "single_word": false
  },
  "eos_token": {
    "content": "</s>",
    "lstrip": false,
    "normalized": false,
    "rstrip": false,
    "single_word": false
  },
  "pad_token": "<unk>",
  "unk_token": {
    "content": "<unk>",
    "lstrip": false,
    "normalized": false,
    "rstrip": false,
    "single_word": false
  }
}

And at the same time, I couldn't find related code in the repo source code.
So how do the colspan and rowspan server as special token? Thank you very much.

Hi, the 'special token' doesn't mean adding to the token file, just ditinguishing tokens to indicate row/column span, they are treated as normal texts~

Thanks.


Unable to use join action due to incorrect IP address being fetched

I haven't been able to use the join action from Home Assistant using the native Linkplay integration. After debugging it, I noticed that it was sending <IP_ADDRESS> as the address for the main device.
The reason was that the correct address was being returned by eth0, with eth2 being <IP_ADDRESS>. The for loop was supposed to correct it and set the value of <IP_ADDRESS> addresses to None, but since strings are immutable it wasn't changing the string value referenced by eth2. I've simplified the code to use a sequence of if statements until one with a valid address is found.

@silamon can you please take a look? It builds on your previous change #64, the code to get eth addresses doesn't handle the case there eth0 has the address.


fix langdata (user words/patterns) file suffixes for LSTMs:

add another constructor for LSTMRecognizer
which takes the language_data_path_prefix configured/selected
at runtime and passes it to the internal CCUtil
use this in Tesseract::init_tesseract_lang_data when LSTMs
are available

(this was missing from 297d7d86ceb3b3365876b56f08a18cba066bf23f)

Fixes #2584

But maybe anyone has a better idea of how to make this work with LSTMs?
(The story is the same as for the configuration variables in #2328 – we have to get the prefix into the shallow CCUtil / Dict inside LSTMRecognizer. For the config variables I decided to pass the existing ParamsVectors via LSTMRecognizer::LoadDictionary(), resetting the defaults only for the specific variables to be shared, via Param::ResetFrom(). But here we are dealing with the combined runtime settings for tessdata prefix and language. We could alternatively use TessdataManager for this, maybe by giving it an additional member language_data_path_prefix_ to be set in the constructor. I even thought about using its existing member data_file_name_ and just truncate the .traineddata suffix, but I guess this is bound to fail under certain conditions I am unable to identify.)

thanks.


Document REASON_CONTEXT.Reason.SimpleReasonString as const safe

@oldnewthing told me it was safe; everybody should know :)

@juliekoubova : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Should have the power management team confirm. (I was just reading source code.)
Same remarks apply to ReasonStrings. Should probably move to Remarks.
Wording should be less jargony.

It is safe to pass read-only strings as the SimpleReasonString or ReasonStrings because the  PowerCreateRequest and SetWaitableTimerEx functions read from the strings and do not write to them.

@juliekoubova : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@juliekoubova : Thanks for your contribution! The author(s) have been notified to review your proposed change.


【powerbi】add readme.md

Coverage increased (+0.01%) to 53.324% when pulling 4a83b1972622a2f6ffc17bc24aecdc4095a193be on fenghj/powerbi into 8f76949022a811a225a593db2ee162fa5ffe6c8c on master.


ensure tenant set where needed; add not null constraint

Adds sql to set tenant_id on tm_user and deliveryservice table and then adds NOT NULL constraint to ensure it is set from here on.   This should allow us to move forward with eliminating dependency on the use_tenancy parameter.
Fixes #2520
Fixes #2521
partially addresses #2273

apply to existing data using ./db/admin.pl -env production patch

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2060/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2061/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2068/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2069/
Test PASSed.

added WIP label as we need to evaluate this approach.   Please do not merge.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2094/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2133/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2134/
Test PASSed.

To test,   set up kabletown data and upgrade the db:
cd /opt/traffic_ops/app
./bin/db/setup_kabletown.pl
./db/admin.pl -env production upgrade

then hit an endpoint that failed previously, e.g. /api/1.1/deliveryservices_regexes


feat: Debouncing added for saveFile events

#13
Added support for debouncing on file save events in the frontend

The delay can be configured via the .env file , defaults to 1000 if nothing is specified.

@ishaan1013 - Tagging you for review


Parse namespace as modules in node_modules/@types

Parse namespace as modules in node_modules/@types, if it was called as parseModule.
@types/lodash example

Already implemented.
But will not work with lodash as described in 1st message.
We can only detect commonjs module name, but not API.


Remove unneeded loop in get rates DRG

Should help with #48

Codecov Report

Merging #50 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   78.27%   78.26%   -0.02%
==========================================
  Files          17       17
  Lines        1947     1946       -1
  Branches      356      355       -1
==========================================
- Hits         1524     1523       -1
  Misses        371      371
  Partials       52       52

Impacted Files
Coverage Δ

pymars/drg.py
90.04% <100%> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c99a19...ac1bd59. Read the comment docs.

I ended up doing quite a bit of work on the DRG module, building on the work here by @xMestas but also what @arghdos suggested in #49 (moving to numpy is definitely smart).
Once I moved the calculation of the DRG coefficients numerator and denominator to numpy arrays, then it was trivial to calculate the whole adjacency matrix—and then networkx.DiGraph() allows creation directly from a numpy 2D array!

However, in the process I also cleaned things up and changed not only the DRG module, but also related modules, a lot. At this point, the work I did here starts to blend with the refactoring I am doing in the refactor branch, so I think it may be best to merge this branch into that one and continue there.


Is there a way to remove EXIF data from image

Having a problem while uploading images which contains EXIF data and the orientation of the image changes after uploading it

Closing the issue as .rotate() does this  thing


Add performance benchmark suite

Prior and related references: #104 , #398 , #407, #416 , #898 .
I was doing a bit of searching earlier for any links to benchmarks I could find in the issues, and here's the links I found:
https://github.com/jimbolla/react-redux-perf
https://github.com/mweststrate/redux-todomvc
https://github.com/jscriptcoder/stressing-redux
https://github.com/broadsw0rd/react-redux-perf
https://github.com/somebody32/high-performance-redux/tree/gh-pages/assets
https://github.com/coderitual/redux-performance
https://github.com/reduxjs/react-redux/issues/686#issuecomment-331261897
https://github.com/Kalkut/redux-data-frequency-benchmark
I think it would be very valuable if we were to swipe some of these somehow and set up some performance benchmarks.  This would be particularly valuable as we evaluate the changes in 5.1 (per #980 ), and the notional future 6.0 and 7.0 releases as laid out in #950 .

Interestingly, I'm working on a startup (though I haven't given it much attention lately) to provide this kind of tracking of metrics over time. Maybe I should get my ass in gear so we can hook this up and track progress 😄

Dumping some research notes:

Perf analysis and capture:

https://www.npmjs.com/package/tracealyzer
https://github.com/sitespeedio/chrome-trace
https://github.com/Rowno/react-benchmark
https://github.com/MicrosoftEdge/fps-emitter
https://www.npmjs.com/package/performance-mark-metadata
https://www.npmjs.com/package/marky

Performance API:

https://developer.mozilla.org/en-US/docs/Web/API/Performance
https://www.html5rocks.com/en/tutorials/webperformance/usertiming/
https://dev.to/azu/performancemark-with-medata-is-useful-for-real-user-monitoring-54p
https://dev.to/hom3chuk/performance-marks-the-missing-manual-part-1-b6

Other

React perf benchmark setup: https://github.com/facebook/react/tree/f0df495f9a97c0f24a3c20761244dab7da99bd77/scripts/bench
React PR for prod profiling: https://github.com/facebook/react/pull/12886/files

I've set up an initial standalone perf benchmark experiment repo here:
https://github.com/markerikson/benchmark-react-redux-perf
It builds a CRA version of Jim Bolla's stock ticker benchmark, which has been configured to log FPS changes as performance API events.  I can retrieve those from Puppeteer and log them out afterwards.
I have the CRA project modified to define React, Redux, and React-Redux as external libs in a prod build.  That lets me easily swap out the React-Redux version by overwriting a script tag and reloading the page (and is sorta similar to what React does in their benchmark setup).
Jim's benchmark is a stock ticker app, and originally had 330 connected stock listing components.  I've bumped that up to 1000 for stress testing, and run the test with four versions:

5.0.7 (current): steady at 58-60 FPS
4.4.9 (old, but still used in a few places): single-digits of 4-5 FPS
Greg's 5.1 PR branch in #980 : 35-40 FPS
My new context POC in #898 : 58-60 FPS

I haven't done any investigation into why #980 is slower.
My next step is to set up a way to build and run multiple benchmark apps with varying versions of React-Redux and capture the results.  Once I've got that figured out, I can move this setup into the React-Redux repo and automate things, then we can start adding more benchmark apps.
After that, we ought to look at instrumenting the codebase for perf timings, probably with a separate "profiling" build or something.

Pasting some comments between myself and Greg on Discord:
[8:07 PM] acemarke:oh, wow
[8:08 PM] acemarke: the commits I just pushed are way slower than the prior version
[8:08 PM] acemarke: I think a lot of this has to do with the forwardRef and stuff
[8:08 PM] acemarke: dropped from 24-26 to 17-19
[8:08 PM] acemarke: at 2500 components
[8:08 PM] acemarke: could also be that my implementation isn't very good

[8:10 PM] CelloG:dammit :/
[8:10 PM] CelloG: I'll try removing forwardRef and see what happens
[8:11 PM] CelloG: if that speeds it up we need to add back withRef
[8:20 PM] CelloG: you're right!
[8:20 PM] CelloG: after disabling forwardRef, mine is faster
[8:20 PM] CelloG: 2 fps
[8:21 PM] CelloG: than 995

Is there an issue open on the React repo?

We haven't opened one yet, and I didn't see one when I was looking earlier this evening.
The chat conversation is from Saturday.  I just pinged Dan on Twitter, and he said he might be able to take a look.

Aaaand opened up React issue 13456 referencing this issue.

@markerikson I didn't see speedracer in your list of links. :)

@sebinsua : oh, wow!  That looks like exactly what I was sorta trying to build myself :)  The biggest difference I immediately see is that my setup will re-run the same benchmark multiple times for multiple versions of React-Redux.
I'm currently using Puppeteer for the headless Chrome - can speedracer use that?
I'd really appreciate any advice you can offer on using speedracer for this scenario.

Okay, so for anyone visiting this thread who is interested in helping out, here's where things stand at the moment:

We currently have a passable start on a benchmark harness at https://github.com/markerikson/benchmark-react-redux-perf
That harness only has one app it can run (a "stock ticker"-type scenario), and really only captures one primary metric (Frames Per Second)
The harness is in a separate repo, and not part of the React-Redux repo
The harness currently prints out FPS and Chrome perf trace values for each version of React-Redux it tests against

What I really want is:

Multiple benchmark apps that represent different scenarios ("a shallow page full of single connected components", "a deep tree with connected components in different places", "an app that actually changes the UI structure over time")
Hopefully some more metrics captured
Ability to easily run all this against multiple builds/versions of React-Redux
Automatic +- change comparisons between versions
All this integrated into the React-Redux repo as a sub-folder called benchmarks, similar to our existing tests folder

As an immediate goal, I'd appreciate assistance in building out some more benchmark apps, based on both the list of examples I linked at the start of the issue, as well as any other good ideas people have for meaningful example apps.

I'll start with the single shallow page one, first thing tonight.
Do I need to setup anything or I can just make a react app with CRA?

@chirgjn : I think we actually have the "single shallow page" aspect covered already with the existing "stock ticker" app.  I think it would be better if we can come up with a few other app ideas for the other scenarios, maybe based on some of the other benchmark repos I linked in the first comment in the thread.
For now, go ahead and fork https://github.com/markerikson/benchmark-react-redux-perf , which has the perf benchmark tooling set up.  The application part of that has some code in there to capture Frames Per Second values and attach those to the window object, which the perf benchmark runner script can grab afterwards.
From there, you can rewrite the actual application part to be something different than the stock ticker example.

@markerikson I can help. I will have a look at the links you provided.

@markerikson i can start with creating readme of all the important points from all the links.

@Avi98 : sounds good.

@markerikson Happy to help out with building some more benchmark apps out. I had a start adapting react-todomvc (similarly to Michel's) into the benchmark framework but it quickly dawned on me that really it is just another single shallow page like the ticker example.
Do you have anything in mind for "a deep tree with connected components in different places" or "an app that actually changes the UI structure over time"? I am assuming we want to create apps that are realistic rather than simply creating a deep tree just for the sake of the benchmark?

@mattridley : no, I don't immediately have ideas for apps that fit those categories, although maybe there's something listed at https://github.com/markerikson/redux-ecosystem-links/blob/master/apps-and-examples.md that we could adapt or use as an example.
I can see points for both "realistic" apps and "unrealistic" stress tests.  It would also help if we can come up with more metrics to measure besides the current FPS meter, but it's at least something objective for now.
Actually, perhaps the "tree-view" example in the Redux repo would be an acceptable starting point for a "deep tree" benchmark: https://github.com/reduxjs/redux/tree/master/examples/tree-view .

I'm going to look into porting the tree-view example over, and @cellog is going to try to adapt the twitter-lite repro app.

@sebinsua : I just looked over the speedracer repo again.  It sounds like a lot of the planned features are things I would want (like https://github.com/speedracer/speedracer/issues/5 ), but the tool doesn't seem to have been updated in a while, and no indication that any of those roadmap items are being worked on.

Reversing course a bit - @timdorr feels the benchmarks shouldn't go in the repo directly, or at least not the way we were going, so he just backed out that commit.  I'm okay with that.
I'm inclined to set this up as a separate repo instead.

We've got a new repo set up at https://github.com/reduxjs/react-redux-benchmarks , and @cellog has ported over the existing benchmarks setup.


Document task parameter constraints

Describe the Change You Would Like
We don't clearly document the constraints on parameter names in the writing tasks page. We should document that https://puppet.com/docs/bolt/latest/writing_tasks.html#defining-parameters-in-tasks

would like to see how this progresses as it becomes crucial to adopting tasks at a wider level else it comes from trial and error


[ALLUXIO-3045] Add external minicluster

https://alluxio.atlassian.net/browse/ALLUXIO-3045
This PR adds the external minicluster and applies it to JournalShutdownIntegrationTest to replace a couple of our codebase's flakiest tests.
Features of the external cluster:

Can be configured with any number of masters and workers, as well as any Alluxio properties.
Cluster uses a temporary directory as its work directory. An alluxio-site.properties is written to workdir/conf, the underfs is workdir/underFSStorage, the worker ramdisks are workdir/ramdisk${worker_id}, and the journal folder is workdir/journal. Master logs are written to logs-master${master_id}, and worker logs are written to logs-worker${worker_id}
The cluster supports a saveWorkDir method which will create a tarball of worker state and store it in target/artifacts, where Jenkins will temporarily archive it. This will be invaluable for debugging failing tests.

Efforts taken to avoid leaking external processes:

Register a JVM shutdown hook to destroy the external processes on JVM exit
If a test uses the external cluster as a @Rule, the cluster will automatically get destroyed when the test ends.
Tests which use the external cluster directly should use try ... finally to ensure that they call cluster.destroy() when they are done.
External processes run in a wrapper which will cause them to terminate after 20 minutes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17267/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.master.JournalShutdownIntegrationTest.singleMasterJournalStopIntegration
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17269/
Test PASSed.

Merged build finished. Test PASSed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17270/
Test PASSed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17271/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17275/
Test PASSed.

@aaudiber Thanks for the update, had a question left about the api.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17277/Failed Tests: 1org.alluxio:alluxio-minicluster: 1alluxio.multi.process.MultiProcessClusterTest.zookeeper
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17280/Build result: FAILURE[...truncated 4518 lines...][JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-common/1.7.0-SNAPSHOT/alluxio-core-common-1.7.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-common/1.7.0-SNAPSHOT/alluxio-core-common-1.7.0-SNAPSHOT.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-common/1.7.0-SNAPSHOT/alluxio-core-common-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-common/1.7.0-SNAPSHOT/alluxio-core-common-1.7.0-SNAPSHOT-tests.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-server-worker/1.7.0-SNAPSHOT/alluxio-core-server-worker-1.7.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-server-worker/1.7.0-SNAPSHOT/alluxio-core-server-worker-1.7.0-SNAPSHOT.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-server-worker/1.7.0-SNAPSHOT/alluxio-core-server-worker-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-logserver/1.7.0-SNAPSHOT/alluxio-logserver-1.7.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-logserver/1.7.0-SNAPSHOT/alluxio-logserver-1.7.0-SNAPSHOT.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-logserver/1.7.0-SNAPSHOT/alluxio-logserver-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-client/1.7.0-SNAPSHOT/alluxio-core-client-1.7.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-examples/1.7.0-SNAPSHOT/alluxio-examples-1.7.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-examples/1.7.0-SNAPSHOT/alluxio-examples-1.7.0-SNAPSHOT.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-examples/1.7.0-SNAPSHOT/alluxio-examples-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core/1.7.0-SNAPSHOT/alluxio-core-1.7.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-server-proxy/1.7.0-SNAPSHOT/alluxio-core-server-proxy-1.7.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-server-proxy/1.7.0-SNAPSHOT/alluxio-core-server-proxy-1.7.0-SNAPSHOT.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-server-proxy/1.7.0-SNAPSHOT/alluxio-core-server-proxy-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-shell/1.7.0-SNAPSHOT/alluxio-shell-1.7.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-shell/1.7.0-SNAPSHOT/alluxio-shell-1.7.0-SNAPSHOT.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-shell/1.7.0-SNAPSHOT/alluxio-shell-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-tests/1.7.0-SNAPSHOT/alluxio-tests-1.7.0-SNAPSHOT.pomchannel stoppedArchiving artifacts
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17278/Failed Tests: 1org.alluxio:alluxio-minicluster: 1alluxio.multi.process.MultiProcessClusterTest.zookeeper
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17279/
Test PASSed.

jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17281/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17282/
Test PASSed.

Merged build finished. Test PASSed.

@apc999 All tests should be consistently passing now

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17284/
Test PASSed.

@apc999 Thanks for the careful review, I've updated the PR to reflect your comments

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17305/
Test PASSed.


Find better ways of guiding people from the project to the forum

We probably want to avoid messages that are too invasive (e.g. saying "do you want to discuss this playbill" after every submission) but something along those lines...perhaps just a similar message after every 10 tasks.
Could this also be linked to the "like" button? So if they click like then ask if they also want to discuss it.

Hmm, that might be weird. I think a 'discuss this on the forum' button is more obvious, but we'll still need to explain how to copy the exact URL for an item. Or if the 'share' function behaved more like UV, there'd be space for brief explanatory text. (I'm assuming that prep-populating forum posts with the link isn't possible.)

Yep, so another option would be to put a "Discuss this playbill" button above the current note button - although, we now seem to be getting back to our long standing discussion about what the purpose is of each of those functions!

So, I like the idea of a "Discuss this playbill" button and having the note button be more along the lines of "Noticed and issue? Add a note".

On the 'share' button, a bit to copy the link and a link to the 'spotted something interesting' thread.

So I think the current decision here is to start by building this into the Share button popup? So that will include an option to copy just the link, or copy the link and go to the forum.

Yep!

Ok great.
(Note to self - also close #365 when this is done)

@mialondon So I've started adding this as a modal the shows when the share URL is clicked (we already had the code and it's the same behaviour for other buttons on the toolbar). Before I go any further could you check out the demo page?
Note that it's only there in "select mode" (for the demo).
https://libcrowds.github.io/libcrowds-viewer/

There would then be a space at the top where a config variable can be used to fill in whatever text we like, as with the help modal.

@mialondon Ah, so we just need the text for this - as we're regenerating tasks anyway. Again, this can be created on a task-by-task basis, so we could potentially have different text for genre/title/person etc, but we probably don't need to go that far.

Can just go in here for the time being https://github.com/LibCrowds/project-playbills/blob/master/config/share/all_tasks.md
We can look at generating separate files for each task type later

The text gets updated when new tasks are generated but the functionality is there.


Nightly mandatory?

It's been two months since my last build; I just did a version bump to release a change I accepted a while back, and something that has happened between then and now has caused my tarpaulin step to suddenly fail. Here's the output from two months ago:
Run<EMAIL_ADDRESS>[tarpaulin] downloading cargo-tarpaulin from https://github.com/xd009642/tarpaulin/releases/download/0.13.2/cargo-tarpaulin-0.13.2-travis.tar.gz
/bin/tar xz --warning=no-unknown-keyword -C /home/runner/work/_temp/e13e7765-635b-4569-bb13-77459cfa3805 -f /home/runner/work/_temp/1b854705-6197-41dc-ad1a-3586ba3746b7
[tarpaulin] running tests with coverage tracking
/usr/share/rust/.cargo/bin/cargo tarpaulin --out Xml --run-types Doctests --run-types Tests
[INFO tarpaulin] Creating config
[INFO tarpaulin] Running Tarpaulin
[INFO tarpaulin] Building project
[INFO tarpaulin] Launching test
[INFO tarpaulin] running /home/runner/work/serde-tcod-config-parser/serde-tcod-config-parser/target/debug/serde_tcod_config_parser-f179f45497b1a7bb

running 3 tests
test lexer::tests::char_oct ... ok
test lexer::tests::char_hex ... ok
test lexer::tests::char_special ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

[INFO tarpaulin] Coverage Results:
|| Tested/Total Lines:
|| src/de/mod.rs: 0/122
|| src/de/primitive_sequence_access.rs: 0/14
|| src/de/struct_internal_access.rs: 0/42
|| src/de/struct_sequence_access.rs: 0/11
|| src/lexer.rs: 28/46
||
11.91% coverage, 28/235 lines covered

and here's the output from yesterday:
[tarpaulin] downloading cargo-tarpaulin from https://github.com/xd009642/tarpaulin/releases/download/0.14.2/cargo-tarpaulin-0.14.2-travis.tar.gz
/bin/tar xz --warning=no-unknown-keyword -C /home/runner/work/_temp/745ac693-1fb2-4f0b-b7a5-4bf3075cbcf3 -f /home/runner/work/_temp/0d9d8e01-001d-4fa4-be5c-c8c67e7f37e2
[tarpaulin] running tests with coverage tracking
/usr/share/rust/.cargo/bin/cargo tarpaulin --out Xml --run-types Doctests --run-types Tests
[INFO tarpaulin] Creating config
[INFO tarpaulin] Running Tarpaulin
[INFO tarpaulin] Building project
error: toolchain 'nightly-x86_64-unknown-linux-gnu' is not installed
[ERROR tarpaulin] Building doctests failed
[ERROR tarpaulin] Cargo failed to run! Error: Building doctest failed
Error: "Cargo failed to run! Error: Building doctest failed"
##[error]The process '/usr/share/rust/.cargo/bin/cargo' failed with exit code 1

on my end I've changed nothing but the version line in Cargo.toml between these two builds; but it looks like something between 0.13.2 and 0.14.2 broke the action.

You must have added your first doc test to the project. None are ran in the first run and doc test coverage is nightly only as it relies on an unstable flag to persist the doctests instead of just deleting them

I promise you, the only change I made was to Cargo.toml between these two runs. You can see the green checkmark on the second-to-last commit and the red X on the last commit here: https://github.com/alexschrod/serde-tcod-config-parser/commits/master

Ah I've got it. In 0.14.2 changelog Return an error if a doctest fails to compile yeah so previously if your doctests failed to compile (or couldn't be ran) because you tried to get coverage for them using a non-nightly compiler (or of course if there was an error in the doctests) it just silently ignored them.
So you can remove --run-types Doctests and get the same results as you were before. Or move to nightly and get doctest coverage as well.

I'm going to close this as it seems resolved but feel free to reopen if you have any follow up questions on this :slightly_smiling_face:

doc test coverage is nightly only as it relies on an unstable flag to persist the doctests instead of just deleting them

I think this is still the case, but it's not documented AFAIK. For me cargo tarpaulin --doc

works with cargo 1.82.0-nightly (8f40fc59f 2024-08-21), but
does not work with cargo 1.80.0 (376290515 2024-07-16)

Shouldn't this be documented, either in README.md or cargo tarpaulin --help? I can make a PR if desired!

This is documented in the TROUBLESHOOTING.md file. But also tarpaulin will see if you have rustup installed and add a +nightly if you do otherwise print out an error message that should be clear enough.
I've never had anyone raise an issue regarding confusion on this and generally my "what goes in the readme" is determined by what's causing people issues so I gather it's clear for most people and doesn't need a PR :man_shrugging:

Ah interesting! Thank you! I think the reason is that I was using cargo-tarpaulin through nix run:
nix run nixpkgs#cargo-tarpaulin -- --doc

Somehow this triggers the compilation failure, which I can no longer reproduce once installing cargo-tarpaulin in my profile. Sorry for the noise!


Screen freezing when swiping an amount that creates out of sync current page state

Issue
Swiping certain distances (gestureState.dx) can change the current page state but does not scroll the current screen and renders the current screen as frozen, perhaps because the internal functions are calling state on another story?
Video with console logs of bug
Notice the pages are out of sync. The
https://user-images.githubusercontent.com/62890543/204863994-5e5628a3-2f5b-4a5a-b4d6-f8ac32795f0e.mp4
Images of code showing where logs come from
PanResponder.create()

onDownSwiping()

Comments
Any idea how to fix this or what is going wrong?

Closing because issue was with my refactor to typescript


HDDS-2621. Enable OM HA acceptance tests.

What changes were proposed in this pull request?
OM HA robot tests were disable in HDDS-2533 as they were failing intermittently. HDDS-2454 fixes some issues in the HA tests. Creating this Jira so as to run re-enable the HA acceptance tests.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2621
How was this patch tested?
CI acceptance test suit.

OM ha test is failing in this patch:
OSError: [Errno 13] Permission denied: '/opt/hadoop/tmptWKCFH'

In github actions based runs the /opt/hadoop might not be writable. /tmp is a better choice for temporary data...

@hanishakoneru I tried to fix this, found the following two changes necessary:

use temp dir as @elek suggested: bf57d0e6f89b2434efb7e9dd59b5480ad1c80166
fix SSH keys: 9df5d0838ad402b79bcbece2c4831d82a55904c6

The test still doesn't pass completely, latest run failed with copyFromLocal: Allocate any more blocks for write failed.  If you have time, please feel free to pick these two changes and continue from there.

/pending acceptance tests are failing

/ready

/pending

Thanks @adoroszlai and @elek.
I have incorporated your suggestions. The tests are passing locally. I will let CI run once again to see whats happening.

Thanks @adoroszlai for verifying.
I set to "pending" so that someone does not merge this change by mistake as there is 1 approval already :)

OM ha test is failing in this patch:
OSError: [Errno 13] Permission denied: '/opt/hadoop/tmptWKCFH'

In github actions based runs the /opt/hadoop might not be writable. /tmp is a better choice for temporary data...

I'm seeing something similar on some of the PR runs but not all. Like #520 I mentioned. Can you confirm @hanishakoneru  if this is the same issue.
2019-11-16T12:01:24.9714368Z Test Multiple Failovers | FAIL |
2019-11-16T12:01:24.9715403Z OSError: [Errno 13] Permission denied: '/opt/hadoop/tmpLn9PKJ'

@xiaoyuyao, this is the same issue but I am surprised how the OM-HA tests are running when they are disabled. Can you please point to another PR where you observed this. I don't see HA tests in #520 .

Thank you all for the reviews and suggestions. I will merge this shortly.

Test is failed on the master after the merge: https://github.com/apache/hadoop-ozone/actions/runs/67591808

Test is failed on the master after the merge: https://github.com/apache/hadoop-ozone/actions/runs/67591808

And no OM logs are available: https://issues.apache.org/jira/browse/HDDS-3311

Two more failures:

https://github.com/apache/hadoop-ozone/actions/runs/68224789
https://github.com/apache/hadoop-ozone/actions/runs/68191219

I hate to be the bad guy (again), and I am very sorry, but I have to revert/reopen it as it's failed 3 times from the last 6 master build.

Ok. Instead of revert, I just excluded the tests from the pr / daily build. We can create an other pull request and start to test it (#ce6ad30a3)

I will create a separated github action to make it easier to run only one acceptance test multiple times...

If I didn't do any mistake, the om-ha tests (and only them) will be executed twice per hour here:
https://github.com/elek/hadoop-ozone/actions?query=workflow%3Aacceptance-single
https://github.com/elek/hadoop-ozone/commit/da01f32a21626a4c0851f5ca601c29a1b802a818

Thanks @elek for disabling this test. These OM HA failures are very elusive. I tested multiple times before merging and they didnt fail any of those times.
 Thanks for setting that up.

It seems to be flaky.  Got a lot of runs and 7 out of the last 25 are failed. (Yes, hard to detect this number, because you might have even 3 green builds without detecting them).
Examples:
https://github.com/elek/hadoop-ozone/runs/554176250
https://github.com/elek/hadoop-ozone/actions/runs/68771264
https://github.com/elek/hadoop-ozone/actions/runs/68745626
https://github.com/elek/hadoop-ozone/actions/runs/68694305