math equations not displaying properly in EPUB and MOBI

In my Mac OS X, equations are not converted to graphics for displays in EPUB and MOBI. All dependency checks are passed.
When I create a new book by sc new sctest, and sc build:epub, it still does not display equations properly: instead of graphics, I can only see the LaTeX source codes for the equations.
I guess this is an issue in my local system. Any guess?
FYI:
chkwon@MacBook:sctest$ sc check
Checking Softcover dependencies...
Checking for LaTeX...         Found
Checking for GhostScript...   Found
Checking for ImageMagick...   Found
Checking for Node.js...       Found
Checking for PhantomJS...     Found
Checking for Inkscape...      Found
Checking for Calibre...       Found
Checking for KindleGen...     Found
Checking for Java...          Found
Checking for zip...           Found
Checking for EpubCheck...     Found
All dependencies satisfied.

chkwon@MacBook:sctest$ sc build:epub
Building EPUB...
  adding: mimetype (stored 0%)
  adding: META-INF/com.apple.ibooks.display-options.xml (deflated 26%)
  adding: META-INF/container.xml (deflated 33%)
  adding: OEBPS/a_chapter_fragment.xhtml (deflated 77%)
  adding: OEBPS/another_chapter_fragment.xhtml (deflated 62%)
  adding: OEBPS/content.opf (deflated 68%)
  adding: OEBPS/cover.xhtml (deflated 26%)
  adding: OEBPS/frontmatter_fragment.xhtml (deflated 74%)
  adding: OEBPS/images/cover.jpg (deflated 15%)
  adding: OEBPS/images/figures/01_michael_hartl_headshot.jpg (deflated 28%)
  adding: OEBPS/nav.xhtml (deflated 56%)
  adding: OEBPS/styles/custom.css (deflated 29%)
  adding: OEBPS/styles/custom_epub.css (deflated 40%)
  adding: OEBPS/styles/epub.css (deflated 43%)
  adding: OEBPS/styles/page-template.xpgt (deflated 80%)
  adding: OEBPS/styles/pygments.css (deflated 79%)
  adding: OEBPS/styles/softcover.css (deflated 75%)
  adding: OEBPS/toc.ncx (deflated 64%)
  adding: OEBPS/yet_another_chapter_fragment.xhtml (deflated 60%)

Problems with raw LaTeX instead of images probably indicates an issue with
the PhantomJS dependency. Try double-checking the installation to see if
that helps.
On Sun, Mar 27, 2016 at 1:46 PM, Changhyun Kwon<EMAIL_ADDRESS>wrote:

In my Mac OS X, equations are not converted to graphics for displays in
EPUB and MOBI. All dependency checks are passed.
When I create a new book by sc new sctest, and sc build:epub, it still
does not display equations properly: instead of graphics, I can only see
the LaTeX source codes for the equations.
I guess this is an issue in my local system. Any guess?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/softcover/softcover/issues/154

--
Michael Hartl
michaelhartl.com

I've installed PhantomJS again:
chkwon@MacBook:sctest$ which phantomjs
/usr/local/bin/phantomjs
chkwon@MacBook:sctest$ phantomjs
phantomjs>

No good. Any test code to see if PhantomJS works good?

In lib/softcover/builders/epub.rb, I found the following codes:
# Sometimes in tests the phantomjs_source.html file is missing.
# It shouldn't ever happen, but it does no harm to skip it.
return nil unless File.exist?('phantomjs_source.html')
raw_source = File.read('phantomjs_source.html')

It seems like the file phantomjs_source.html does not exist in my system, and therefore just skip the rest of the epub building. How can I create or generate phantomjs_source.html?

That line only applies in tests. When the system is running normally, the PhantomJS file is created and then removed automatically.

Oh well, my version of phantomjs was 2.1.1, which actually produced the MathJax timeout error.
After changing it to version 1.9.8, it works. I'm in Mac OS X.

Great, thanks for the details and glad to hear you got it to work. I'll
look into updating the docs with a specific version number, and might also
investigate version 2 compatibility.
On Sun, Mar 27, 2016 at 4:45 PM, Changhyun Kwon<EMAIL_ADDRESS>wrote:

Oh well, my version of phantomjs was 2.1.1, which actually produced the
MathJax timeout error.
After changing it to version 1.9.8, it works. I'm in Mac OS X.
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/softcover/softcover/issues/154#issuecomment-202169518

--
Michael Hartl
michaelhartl.com

Update: After upgrading to Sierra, phantomjs 1.9.8 is no longer compatible. EPUB generation with math equations in Mac OS X is not possible.

Thanks for the heads up. This is awful news, as it's the kind of thing that could easily be impossible to fix, and of course it's a giant waste of time to have to fix something that was working fine for the past several years. I'll do my best to get it working.

It looks like PhantomJS 2.1.1 runs on macOS Sierra, but it doesn't appear to work with MathJax. I have no idea how to fix it offhand, but it's critical that I figure it out at some point. As I said before, it may just not be possible. Not sure what we'll do if that's the case.

Thanks. Hope for a good news. I've tested in Ubuntu and also found out that PhnatomJS 2.1.1 does not work well with softcover. I had to use 1.9.8.

OK, this was a nasty one. Not only did PhantomJS 1.9 break on Sierra, but (as you noted) changes to version 2.1.1 broke compatibility with the softcover gem. PhantomJS 2 is also incompatible with the older version of MathJax that came bundled with Softcover. Finally, the latest version of MathJax is compatible with PhantomJS but is (slightly) incompatible with the SVG-extraction algorithm used by Softcover's page.js script.
I believe I've tracked down all the issues and now have a working version. Try out the new 1.3.0 gem to see if it works for you:
$ gem update softcover -v 1.3.0

Thanks! I just confirmed the new softcover version works good in Ubuntu with PhantomJS 2.1.1. I'm testing now in macOS Sierra.

In macOS Sierra, it doe not work. sc build:epub runs well, but it actually produces all blank math images. As I check epub/OEBPS/images/texmath folder, there are PNG files with different pixel sizes but all blank.

I have the same issue. OSX Yosemite, PhantomJS 2.1.1. Softcover 1.3.0

It's working on both systems I have access to (Yosemite & Sierra). Unfortunately, there's not much I can do if I can't reproduce the issue, so any help would be appreciated.

On a fresh Sierra, I did the following:
xcode-select —install
Installing homebrew
brew install ruby
brew install node
brew cask install quartz
brew cask install Inkscape
brew cask install calibre
brew cask install kindlegen
brew install epubcheck
brew cask install java
brew install phantomjs
brew cask install basictex (then later open /usr/local/Caskroom/basictex/20161009/mactex-basictex-20161009.pkg)
brew install ghostscript
brew install imagemagick
sudo gem install —no-ri —no-rdoc softcover

It doesn't work. Do you think manual installation of dependencies will make any difference? @mhartl

Manual installation of (most) dependencies is a good idea, as described here. Not sure what to do if you can't get it to work; as noted before, it's working on all the systems I have access to.

It might be inkscape. After un-muting this line, I obtained the following warning:
** (inkscape-bin:8074): WARNING **: SPIStyle::readIfUnset(): Invalid style property id: 90 value: static
Background RRGGBBAA: ffffff00
Area -1:-1:0:0 exported to 83 x 83 pixels (7470 dpi)
Bitmap saved as: /Users/chkwon/Documents/Repositories/sctest/epub/OEBPS/images/texmath/e2293e769a19cf7cc131560e7d30a493cf399b8a.png

I checked with the SVG file, and it contained a correct math equation, while the converted PNG file is blank. Here is the generated SVG file.
The SVG file looks incompatible with Inkscape, at least my version (Inkscape 0.91 r13725 (Jan 28 2015). I tested inkscape file conversion with another SVG file downloaded from the web, and it went well.

I've tested the SVG file generated in macOS in my Ubuntu. It is converted well. So there is no problem with the SVG file itself.
It seems that the current Mac version of Inkscape has some issues for conversion. I tested a previous version of Inkscape (v0.48.5) and it works well.

@mhartl @axitdn Could you let me know your Inkscape version installed on your mac?

I reported this to Inkscape and someone is working on it.
https://bugs.launchpad.net/inkscape/+bug/1634571

OK, sounds like it's an Inkscape issue. I'll plan to keep an eye on it.

@chkwon My Inkscape version is 0.91. I will try the Inkscape (v0.48.5). For now, my workaround is building a Softcover Docker version.
// @mhartl Do you have an official docker version for Softcover?

There's no official Docker build.

I was able to get around this on sierra by using the 0.48.5 build of inkscape, which you can download from here:
https://inkscape.org/en/release/0.48.5/platforms/
Hope this helps someone... this was a big pain :).

@robconery thanx for the pointer.
(On Mac OS X 10.10.5, using Inkskape 0.91 produces blank .pngs for the math. Using the older 0.48.5 build makes math image generation work again. That's odd because I used 0.91 before and it worked fine).


Duplicate permissions not handled

Some devices are not good about being consistent with who is suppose to be defining a permission.  For example, on the Kindle Fire (FireOS), mulitple applications define the same permission, with completely different definitions. An example:
In package com.amazon.kindle.otter:
<permission android:name="com.amazon.CONTENT_PROVIDER_ACCESS"/>

But in com.amazon.kindle it's completely different:
<permission android:description="@string/content_permissions_description" android:label="@string/content_permissions_label" android:name="com.amazon.CONTENT_PROVIDER_ACCESS" android:permissionGroup="android.permission-group.PERSONAL_INFO" android:protectionLevel="signature"/>

I'm not 100% sure how the OS determins which one to use, but Android has picked one of them:
02:29:45 /DevTesting/Fire$ dtf_shell dumpsys package perm |grep CONTENT_PROVIDER_ACCESS -A 2
--
  Permission [com.amazon.CONTENT_PROVIDER_ACCESS] (41f1c2e0):
    sourcePackage=com.amazon.kindle.otter

I'm going to migrate the parse_permissions( .. ) method of the sysappdb module to use dumpsys to determine who the OS has picked for the true permission holder.

Tagging this for future.


Error when trying to crop:  "undefined is not an object" on iOS

Hi, I was attempting to extract regions from an image using crop().  I get the blow error from the bmp.insert line.   This works on an android device, but not on iphone...
JS ERROR TypeError: undefined is not an object (evaluating 'this._nativeObject.size.width')
let bmp = BitmapFactory.create(500, 500);
bmp.dispose(function() {
    bmp.drawLine("0,150", "300,75", '#0000ff');
    let leftTop = "0,0";
    let size = "50x50";
    let croppedImage = bmp.crop(leftTop,size);
    bmp.insert(croppedImage);
});

Many thanks!

Any luck with this? I am getting the same.

@jwall132 - I ended up doing this for IOS:
            let croppedImg: ImageSource;
            let nativeImg: UIImage = photo.ios;
            let widthInPoints = nativeImg.size.width;
            let widthInPixels = widthInPoints * nativeImg.scale;
            let heightInPoints = nativeImg.size.height;
            let heightInPixels = heightInPoints * nativeImg.scale;
            var imageRef = CGImageCreateWithImageInRect(nativeImg.CGImage, CGRectMake(coords.x, coords.y, coords.w, coords.h));
            let nativeCroppedImg = new UIImage(imageRef);
            let imageData: NSData = UIImagePNGRepresentation(nativeCroppedImg);
            croppedImg = ImageSourceFromData(imageData);

To flesh out @geoffbullen's answer, I got his code working by replacing ImageSourceFromData which doesn't seem to be a function I can find like so:
      const imageData: any = UIImagePNGRepresentation(nativeCroppedImg);
      croppedImg = UIImage.imageWithData(imageData);

      const mutable2 = BitmapFactory.makeMutable(croppedImg);
      const bmp2 = BitmapFactory.asBitmap(mutable2);


Javascript error occurs when using the Element.requestFullscreen() method

Based on https://stackoverflow.com/questions/54936376/cannot-toggle-fullscreen-in-testcafe
Test page
    <button id="btn">click me</button>

    <script>
        var button = document.getElementById('btn');

        button.addEventListener('click', function () {
            button.requestFullscreen();
        });
    </script>

Test code
    test(`test`, async t => {
        await t.click('#btn');
    });

It looks like we already have a similar issue https://github.com/DevExpress/testcafe/issues/2863
Since it's not implemented yet, I think we need to implement some kind of user-friendly error message in the context of this ticket.

Hi, stack overflow question poster here. Thanks for creating this! I had seen the other issue but thought it was specific to video elements. I ran into similar errors when testing media elements play() method but was able to work around it by initializing the element as muted which allows autoplay (testcafe clicking the button is identified as autoplay by the browser).
Somewhat related question: do you plan to expose media attributes (paused, currentTime, volume, muted, etc) for dom elements from selectors? Or will I need custom actions for that?

Thank you for using TestCafe. I think it's a good idea to expose media element properties through Selector properties. I've created a new suggestion for this feature: #3520.
In the meantime, you can use ClientFunctions or custom Selector properties to work with media element properties.

Hi, I am trying to test full screen button present on a video and on click of its element, I am facing same warning message on element.requestFullscreen().
Do you have any estimate when this issue will be fixed?
Also, how can I use  ClientFunctions or custom Selector properties as a work around ?

@vishakha-DAZN I can't give you an estimate of when this feature might be implemented. As a workaround, you can mock the requestFullscreen method on the target element. It will suppress the error, but won't bring your page to the fullscreen layout. Check the following code as a reference:
cons mockFullcreen = ClientFunction(element => element.requestFullscreen = () => {});

await mockFullcreen(target);

await t.click(target);


Host drive should expose hidden and system filesystem attributes to WSL instance

Windows Version
Microsoft Windows [10 Version 22H2 OS Build 19045.3758]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-microsoft-standard-WSL2
Distro Version
Ubuntu Lunar 23.04
Other Software
No response
Repro Steps
coreutils like ls have no awareness of hidden and system attributes on the host filesystem (e.g., under /mnt/c). This is inconsistent with user expectations (i.e. the normal Windows user expects these files to be hidden), but can also cause bigger problems. For example, some antivirus/antimalware system such as Palo Alto Traps creates hidden/system files to detect data exfiltration that can be tripped by unintentional access from a tool like ls in a WSL instance.
There should be some way to hide these files from WSL, whether by default or configuration.
There is an old issue along these lines but I thought it was worth opening a new one to make clearer what the issue is and hopefully get some attention to it.
I believe this problem would be universal to all releases of WSL and all Linux distros.
Expected Behavior
Windows hidden/system files should be hidden.
Actual Behavior
Windows hidden/system files are visible.
Diagnostic Logs
N/A

Unfortunately this is something that WSL can do since there's no mechanism for us to expose Win32 attributes on Linux mount point.
Is there nowhere a bug on this could be filed? What code needs to be modified to expose those attributes--Windows OS code? 9p filesystem? This is a systemic issue that really should be solved universally rather than with one-off hacks.
If you need to "hide" some files maybe an alias for ls with a custom filter is the easiest way for you.
I don't see a way to do this with files like the antimalware honeypots -- they don't have a predictable filename convention. If there were a way for ls to access the output of windows dir, I guess that could work, but seems awfully inefficient.


Chat Screen

I would try to make some changes in chat screen under Ggsoc'24

@Lucky-chelani assigned

please specify the level

@Lucky-chelani as per the change/contribution I'll level it.

I am adding a Fragment instead of Activity for the Chat Screen so wait  i will push it an hour then start working on it

please check it

@Lucky-chelani kindly create pull req.

yah i done and you merged it also


update GitHub feature enhancement template

Signed-off-by: Steve Kriss<EMAIL_ADDRESS>Update GitHub feature enhancement template to ask for the problem/limitation the user is facing in addition to the desired solution.
cc @VMmore

cc @carlisia @prydonius


[CS] Yoda less and greater

https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3083#discussion_r141382247

Closing after discussion, thanks all! :+1:  :)


Idea: pass in the elements

With single page apps, you may want to manage the lifecycle of the DOM more precisely.
What I would like would be for a way to provide a single element or list of elements that are used instead of having the library use the selector to find elements on the document. Otherwise, it feels like jQuery spaghetti by adding extra classes to HTML (FYI: I'm using React refs to find elements).

+1. I made a pull request #42

That's a valid use case, thanks for suggesting @kmalakoff.

Awesome...that was quick!

Came here looking for this. Using Mithril on a project. Great to see it's on the way!

Great. We're looking into that @codeclown ;)


Fix error emitting when double-clicking on JSON files in FileSystem tab

Fixes error thrown when clicking on a json file in the file dock
Bugsquad edit: Fix #66820

Is that not the desired effect of adding .tscn to the list of textfile_extensions? As I understood it, the list of textfile extensions existed for the purpose of causing those files to be editable in the script editor instead of being imported. That's why none of the default items in textfile_extensions are resource types.

Please squash the commits as required by our pipeline and amend the commit name to be correct (we don't accept names like "fixes [link]").

textfile_extensions do not prevent the Resource from being imported. They where designed as a catch all for editing (text) files that are not imported (non-resources), but are still needed as part of development.
There is nothing stopping users from adding .tscn to the list and nor should we prevent it, as the user may have an engine plugin to edit other filetypes. We cannot not know this, hence we need to give priority to the ResourceLoader. As the user shouldn't have to edit their settings every time they open different projects.
Opening items in the filesystem dock should always take you to the dedicated editor for that Resource, regardless of what's in textfile_extensions. As the dedicated editor will be specialised to edit the Resource, as such should be the preferred workflow.
However, there is no prevention stopping the user from opening up a .tscn file if they wish, directly via ScriptEditor menus which bypasses textfile_extensions checks. Though not recommended.

Superseded by #72259.


Cooler Write is able to write True Names

as discussed in discord this is probably not ideal

This isn't resolved, because the discussion in discord was for any true names, because otherwise it makes it too easy to steal them.

... Why? By giving people trinkets that write things?
I don't see how that's any more powerful than just an akashic record
Where is this discord conversation? I don't think I was a part of it

The difference is that a focus can bind a cleric circle.
https://discord.com/channels/936370934292549712/1011455473528098857/1037215257015369778

Ah right and then you have sentinels
OK good point


Document special collations

Our collation docs link to a list of languages that we support, but there's no mention of other modifiers. One useful modified locale is en_u_ks_level2, which is case-insensitive english (I think the _u_ks_level2 modifier can be added to other languages too to use their case-sensitivity rules). I'm not sure if there are other useful modifiers that are supported by our collation package. These modifiers are standardized, but the references I've found don't seem to agree with each other. Unicode TR 35 looks like the authority on this, although it doesn't define the level2 syntax. collate/option.go is where these modifiers get parsed.

@sploiselle, since you documented collations originally, I suspect this would be a very quick update for you. Feel free to unassign if you feel it's more involved and needs to wait until later.

Helpful supplementary thread on the forum: https://forum.cockroachlabs.com/t/case-insensitive-collations/926/4

This goes back to 1.1, but moving it to the 2.1 milestone.

PostgreSQL 12 just added support for these collations, which they call "non-deterministic collations": https://www.postgresql.org/docs/12/collation.html
Their syntax for this is different from ours and they just point out to the unicode docs for more detail. We should be sure to include the phrase "non-deterministic collations" when we document this for SEO purposes.

@bdarnell

Their syntax for this is different from ours and they just point out to the unicode docs for more detail. We should be sure to include the phrase "non-deterministic collations" when we document this for SEO purposes.

Do we support both deterministic and non-deterministic collations?

Yes, we have both deterministic and non-deterministic collations. But looking back at this, I think these terms are fairly obscure - users don't need to care whether a collation is deterministic or not. The only real reason to use these terms is for a user going from "postgres 12 introduces support for non-deterministic collations" to searching for whether cockroachdb supports non-deterministic collations.

The PG docs talk about nondeterministic collations in the context of CREATE COLLATION (deterministic=false), which I don't believe we support.
So I'm still a little confused about how best to document this. For now, I can go ahead and just add a generic note that we support both deterministic and nondeterministic collations. (see https://github.com/cockroachdb/docs/pull/8523)


IntelliSense not removing functions from completion list when require is commented out.

helpers/index.js
String.prototype.trimZeros = function () {
	return this.replace(/\u0000/g, '');
}

app.js
require('./helpers')
"".trimZeros // we expect completions for this function

However, when require('./helpers') is commented out, trimZeros incorrectly remains in the completions list even though analysis has completed.

In ES6 preview Intellisense, this case (extending the prototype) does not seem to be picked up at all.

Yeah.... I have a feeling that's going to happen a lot....

Closing since we have now fully moved to ES6 / Typescript backed editor. This specific IntelliSense use case is no longer supported


Create camk.txt

Courses (PhD studies): https://www.camk.edu.pl/en/phd/
Proof of e-mail... well, my page? https://www.camk.edu.pl/en/people/staff/mkalusz/ Other students, but one can add private e-mail or whatever. You may ask head of doctoral school<EMAIL_ADDRESS>

@majkelx First stage of verification passed, official domain is camk.edu.pl as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@majkelx Pull request merged. Thank you.
Please notice that the educational license is for educational use only. If the employees of the Institute, who are neither students nor teachers, need the license, please ask them to send a message to<EMAIL_ADDRESS>to get an academic discount for a paid license.


CSS line number formatting inconsistent

Describe the bug
CSS snippets have weird formatting of line numbers in 4.8.2
To Reproduce
https://chartscss.org/docs/usage/#custom-styling
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Fixed in v4.8.3


Dear ninoqq,
Have you tried run the command like this? (currently in this moment twitch.tv seems have some problems)
livestreamer --http-header Client-ID=jzkbprff40iqj646a697cyrvl0zt2m6 http://www.twitch.tv/underground_dv source
[cli][info] Available streams: audio, high, low, medium, mobile (worst), source (best)
[cli][info] Opening stream: source (hls)
[cli][info] Starting player: /usr/bin/vlc
My ones is okay and see if you can. ....BTW ...replace (underground_dv) to (broadcast id) you want to see

Try this: https://github.com/chrippa/livestreamer/pull/1483#issuecomment-247854848

hey c769  i tryed it man and still same hting. i entered exactyl what you said in the cmd bar, wih all the random letters and numbers, as im typing all these random letters i was thinking to my same am i getting trolled? how can the pc even read this lol, man i dont know wtf has happened, it just refuse to work

Add "-l debug" and paste output in here.

10mins, sorry for late reply. where to i add the dbug command?

livestreamer "https://www.twitch.tv/xxxxx" best -l debug

hey bro it still wont open anything, what do you think i should do?

@ninoqq you have a typo in your command line. Its l (uppercase: L) and not 1 (the number)
-l debug

thanks for the help , i just tryed it but still same thing

@ninoqq I'm really wondering what version of Python you're using. How did you setup livestreamer? Using the installer or manually?
Because according to the output, livestreamer treats the URL as an option switch and not as an argument to an option as it should. Looks like an parsing error (Python related) or some kind of logical error. Something somewhere went terrible wrong.
Try to reinstall livestreamer using the installer and try again. If that doesn't help. I recommend to download Python from the website, install it, then issue the following command in terminal: pip install livestreamer to install livestreamer again and afterwards run livestreamer to test. Uninstall/Remove your current livestreamer installation first.

GhettoGirl, thanks for your advice. I tried it. It does not, however, work. Livestreamer no longer works for Twitch on both my Windows 10 and Windows 7 machines. It inexplicably stopped working for me at the same time that the person who created this thread ran into trouble.

@richrichards Could you be a little bit more specific? Do you have the same issue as OP or is there any different output?

skulbakka: I was getting the same error output, but now the error output is different. This is the error output that I'm getting now:
C:\Users\Edward>livestreamer twitch.tv/pbogz1114 source
[cli][info] Found matching plugin twitch for URL twitch.tv/pbogz1114
error: Unable to open URL: https://api.twitch.tv/api/channels/pbogz1114/access_token.json (400 Client Error: Bad Request)

@richrichards This is a different issue with twitch's recent API change. See #1478.

@richrichards This is a different issue with twitch's recent API change. See #1478.

Thanks a lot for your help! I got it working again with this:
livestreamer --http-header Client-ID=jzkbprff40iqj646a697cyrvl0zt2m6 twitch.tv/pbogz1114 best


Replace resources in whole application

Have someone experience in replacing Resources in whole application, i need to intercept getDrawable method everywhere
Testing on Genymotion, Android 4.1.1
i need some ideas how to work around

Approach to wrap context when attachBaseContext method called, failed. When inflating views it doesn't works :(

I found really strange behavior that the original(android) views and custom views are getting different types of Context. Cause i made efforts to set background via XML on ImageButton and get Exception, but when i create custom view extended from ImageButton it worked
update on approach 2
hmm, looks like if i define background as an attribute it falls, if do it by code it works

i found what is going on after all, the views calls TypedArray#getDrawable method

    public Drawable getDrawable(int index) {
        if (mRecycled) {
            throw new RuntimeException("Cannot make calls to a recycled instance!");
        }

        final TypedValue value = mValue;
        if (getValueAt(index*AssetManager.STYLE_NUM_ENTRIES, value)) {
            if (value.type == TypedValue.TYPE_ATTRIBUTE) {
                throw new RuntimeException("Failed to resolve attribute at index " + index);
            }
            return mResources.loadDrawable(value, value.resourceId, mTheme);
        }
        return null;
    }

Now i need to think how to replace loadDrawable method :disappointed:
New plan, going to replace LayoutInflater with custom one and create custom attributes like Calligraphy did

OK, i think it is unnecessary, because there some new libraries like Decor


Add to list

Dropdown selection of lists added to the detail section that comes up when you press the + button next to a plant

Add button is next to this dropdown and will add the selected plant to the selected list

Add button will redirect users to the list that will now have the plant in it listed with the date (date when added), KewID, ListID, and a blank location

The Edit/Details/Delete buttons in the list do not currently do anything and will need functionality in the future

Known bugs:

Trying to add a duplicate of a plant to a list will crash the site
Trying to add a plant to the "Select List" part of the dropdown will crash the site

Closes #36

Looks good! Just a few more things, that could be addressed separately.

list pages display all plants associated with any list, as opposed to the plants associated with that specific list
should display similar info to search details page (plant taxon instead of IDs)

I think the ISG files can be removed from this pull request!

Recent commits fix these problems:

ISG files that were added in this push have been removed
Lists only display plants that are associated with that specific list
Plants display with their scientific name (Genus and specific epithet)
Lists no longer have a list column
Lists now are displayed with their names on top rather than "Index"
Edit/Detail/Delete buttons now work (Edit allows to change the date but not the locations because the database currently does not have locations, detail will redirect to the "Detail" page of the specific plant, Delete will take users to an "are you sure" page where you can confirm deleting the plant)
The confirm buttons on both the edit and delete pages will take users back to the list after making the changes
The "Back to List" buttons on the edit/details/delete buttons will take users back to the list
There are now proper error messages when adding a duplicate to a list or adding something to no list at all

This branch will now also...
Closes #44
Closes #43

There's something funky going on with the database, but I was able to fix that by merging main into your branch. I think we should try to get that fixed before merging, just in case.
Otherwise, looks good! Just a few things, which could be separate issues.

Clicking "items" button on list without any items causes crash
Clicking "back to list" from the details page of a list item does not return to the list

Right, I forgot about the Details thing. That's because Details goes into the Taxa folder to show details so it would be much harder for it to remember where it came from.
I wonder what's going on with the items thing... I can take one last look in a bit.
As for the funky database shenanigans... This is a thing that I had to mess around with quite a bit. In the .gitignore file, just putting in ISG.db-* broke the entire plant database... Which is why the .gitignore file specifically lists ISG.db-shm and ISG.db-wal but I guess it didn't work entirely right? I'm not sure though.

Database worked for me! Items link still crashes, but that and the details back-to-list functionality can be a later issue.


bug/partition.auto.partition raises ValueError: Invalid file (FileType.UNK) caused by semicolon including Content-Type

Describe the bug
unstructured.partition.auto.partition raises ValueError
>>> from unstructured.partition.auto import partition
>>> html_elements = partition(url="https://www.arxiv-vanity.com/papers/2305.14283/")
libmagic is unavailable but assists in filetype detection on file-like objects. Please consider installing libmagic for better results.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/.../venv/lib/python3.11/site-packages/unstructured/partition/auto.py", line 490, in partition
    raise ValueError(f"{msg}. The {filetype} file type is not supported in partition.")
ValueError: Invalid file. The FileType.UNK file type is not supported in partition.

partition_html works (but partition does not)
>>> from unstructured.partition.html import partition_html
>>> html_elements = partition_html(url="https://www.arxiv-vanity.com/papers/2305.14283/")

To Reproduce
(See above snippet)
Expected behavior
No error (same as partition_html example)
Environment Info
OS version:  macOS-12.6.6-arm64-arm-64bit
Python version:  3.11.4
unstructured version:  0.11.2
unstructured-inference version:  0.7.15
pytesseract version:  0.3.10
Torch version:  2.1.1
Detectron2 is not installed
PaddleOCR is not installed
Libmagic version: file-5.41
magic file from /usr/share/file/magic
Traceback (most recent call last):
  ...
  File "/.../collect_env.py", line 234, in main
    libreoffice_version = get_libreoffice_version()
                          ^^^^^^^^^^^^^^^^^^^^^^^^^
  ...
FileNotFoundError: [Errno 2] No such file or directory: 'libreoffice'

Additional context
Workaround: Specify content_type
>>> html_elements = partition(url="https://www.arxiv-vanity.com/papers/2305.14283/", content_type="text/html")

Cause:
Content-Type of the response header is 'text/html; charset=utf-8'
https://github.com/Unstructured-IO/unstructured/blob/039ae17fdd82176dcd18b014f6b4cd187f3f04a4/unstructured/partition/auto.py#L516
detect_filetype(content_type='text/html; charset=utf-8') returns FileType.UNK
https://github.com/Unstructured-IO/unstructured/blob/039ae17fdd82176dcd18b014f6b4cd187f3f04a4/unstructured/file_utils/filetype.py#L238-L242
Idea: Add semicolon parse logic
    content_type = content_type or response.headers.get("Content-Type")
+    if content_type:
+        content_type = content_type.split(";")[0]

What version of the unstructured library did you use? I tested both partition_html() and partition() with unstructured==0.11.5. It didn't get any errors and worked as expected.
from unstructured.partition.html import partition_html
html_elements = partition_html(url="https://www.arxiv-vanity.com/papers/2305.14283/")

from unstructured.partition.auto import partition
html_elements = partition(url="https://www.arxiv-vanity.com/papers/2305.14283/")

@christinestraub Thanks for your reply.

What version of the unstructured library did you use?

I used unstructured version:  0.11.2 (I mentioned above)
I also try unstructured==0.11.5
>>> from unstructured.partition.auto import partition
>>> html_elements2 = partition(url="https://www.arxiv-vanity.com/papers/2305.14283/")
libmagic is unavailable but assists in filetype detection on file-like objects. Please consider installing libmagic for better results.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/.../venv/lib/python3.11/site-packages/unstructured/partition/auto.py", line 490, in partition
    raise ValueError(f"{msg}. The {filetype} file type is not supported in partition.")
ValueError: Invalid file. The FileType.UNK file type is not supported in partition.

I noticed the message "libmagic is unavailable", so I ran brew install libmagic
>>> from unstructured.partition.auto import partition
>>> html_elements2 = partition(url="https://www.arxiv-vanity.com/papers/2305.14283/")

So it seems that partition.auto.partition raises ValueError: Invalid file (FileType.UNK) caused by semicolon including Content-Type without libmagic

I installed libmagic, and then the error disappeared.


Fix ptr annotation

I ran into this issue when I was implementing https://github.com/facebook/ent/pull/1142
when an Annotation value is a pointer, like *bool Incremental it was being written to ent/migate/schema.go as such, with by dumpFields with the string written being the address, which of course doesn't work.
this PR fixes that, I extract it from https://github.com/facebook/ent/pull/1142 because I think it should be merged regardless if #1142 gets accepted.
I went for boolPtr, strPtr, intPtr, but open to any other naming for those functions or we could include the pointer library if you don't mind including another dependency.

probably the cleanest solution would be to either use https://github.com/AlekSi/pointer or create the helpers I had before somewhere in the github.com/facebook/ent/...?
no need to rush it, let's do it right if you're not happy with this!

probably the cleanest solution would be to either use https://github.com/AlekSi/pointer or create the helpers I had before somewhere in the github.com/facebook/ent/...?
no need to rush it, let's do it right if you're not happy with this!

I'm going to test it locally on my template changes, and merge it to my branch if it works.

I'm going to test it locally on my template changes, and merge it to my branch if it works.

Merged to master with 76c5e48ef817c16c8e1e1b2c844881658c243b7f.
Thanks!

Merged to master with 76c5e48ef817c16c8e1e1b2c844881658c243b7f.
Thanks!


Gitleaks & OSSF Scorecard

Run Gitleaks in pre-commit
Run OpenSSF Scorecard action on push

The jsonify() commit is not security related, I just didn't want to create a separate PR for it :-)

recheck

pre-commit.ci run


(BKR-846) re-organized docs

[skip ci]

rebased due to outside changes.
@puppetlabs/beaker, @er0ck, @cowofevil, ready for a look!

overall: i like it!

feedback entered. @er0ck, @cowofevil, @puppetlabs/beaker, this is ready for another look!

@er0ck feedback entered, thanks for the quick 👀 !
I don't think we're ready for a standardized footer yet. I think that there's a story beginning to come out of the tutorials folder that will lend itself to that experience though. I'd like to wait for the conclusion of @pinkypie's BKR-860 work (internal-only link), and base it on that, however.

vagrant rake task. yes!  that works for me.
i think we should also ticket to remove all puppet specific stuff from the main parts of the tutorials and focus the tutorials on generic, multi-host interactions.  maybe leave the single howto on modules testing, and expand it.
thoughts?

@cowofevil? @tvpartytonight?

rebased to resolve conflicts. @tvpartytonight merge party?

LGTM! 👍


remove unused pkg.id module

Changes
pkg.id is not used anywhere, removing dead code.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#165  👈
#164
#163
#162
#161
#160
#159
#158
#157
#156
#155
#154
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @chrisaddy and the rest of your teammates on  Graphite


when use ssl_read()，get error DECRYPTION_FAILED_OR_BAD_RECORD_MAC

Read error: ssl=0x6f14c63008: Failure in SSL library, usually a protocol error
error:1e000065:Cipher functions:OPENSSL_internal:BAD_DECRYPT (external/boringssl/src/crypto/fipsmodule/cipher/e_aes.c:1307 0x6f21b021a7:0x00000000)
error:1000008b:SSL routines:OPENSSL_internal:DECRYPTION_FAILED_OR_BAD_RECORD_MAC (external/boringssl/src/ssl/tls_record.cc:298 0x6f21b021a7:0x00000000)
but, ssl_get_error return SSL_ERROR_SYSCALL, ERR_get_error return 0, this error appear occasionally

i download openssl3.0.10.tar.gz file，build for android libssl.so, libcrypto.so，when i use in android ndk, the errors happended as before.

Please show the exact error messages that you get from OpenSSL.

int ssl_error = SSL_get_error(serverSSL, recvLen);
if (ssl_error == SSL_ERROR_SYSCALL) {
unsigned long ssl_reason = ERR_GET_REASON(ERR_peek_last_error());
} else {
unsigned long errCode = ERR_get_error(); // 获取 SSL 错误码
char errBuf[256];
ERR_error_string_n(errCode, errBuf, sizeof(errBuf));
}
when ssl_error == SSL_ERROR_SYSCALL ,ssl_get_reason return 0 ;when not ERR_error_string(ssl_error,nullptr) return
error:00000000:lib(0)::reason(0);  errBuf return  error:0A000119:SSL routines::decryption failed or bad record mac，
but this is happed occasionally。
i found when i get error, my clicent send to tlsserver packet has a 31 length tcp packet, the flag is ACK PSH

This problem has been solved. It has nothing to do with SSL. The main reason is that other SSL links are accessed under multi-threading. The data channel read from it has been closed. But can this error message be optimized?

@imbaqqqq can you elaborate on how you solved this issue? I have this issue randomly on a couple of domains. Checked everything from hardware to software but unable to find out what causes this.


[ENH] Converter for FreeSurfer format mgh

Some differences from other converters:

needs to combine lh and rh data when --> hdf5; needs to separate lh and rh when --> .mgh
source filename (in column names of hdf5 file): something like lrh, instead of just lh or rh

Testing against: FreeSurfer has in-house qdec (link here) which does statistics; can compare this converter + ModelArray results versus that one.

See example scripts from Steven in issue #26
Currently what he does are:

FS output (e.g., lh.thickness*.mgh and rh.thickness*.mgh) --> harmonize --> convert np.array into HDF5 for ModelArray, with lh and rh combined [in python]
ModelArray output dataframe --> directly saves as FS format with lh and rh separated [in R]

Finally, probably also consider adding group-level mask and individual masks as inputs, just like those for voxel-wise data's converter ConVoxel.


0.0.955 burns through memory in Safari

I've been using 0.0.949 for about a month with no problems except having to use Safari because of the h264/h265 issue (I'm on HW3). I just upgraded to 0.0.955, however, and at first I thought it just wasn't working at all. I then realized (shortly after Safari gave me a pop up banner saying this tab is using too much memory) that it was working, it was just really really slow (and slowing my whole system to a crawl with it).
I tried reinstalling 0.0.949 and everything is back to normal now. I now have both versions installed so if you need any logs or anything just let me know.

Hmm it might be the "Combine clips" option?  Basically it preloads all clips in the folder so you can scrub through them with one slider.  Does it improve if you turn off the "Combine clips" switch at the top?

Turning off "combine clips" does help with the problem in 955, but I have that setting turned on it 949 as well and there it doesn't cause a problem.

@demonbane would you be comfortable using git-bisect (https://www.metaltoad.com/blog/beginners-guide-git-bisect-process-elimination is a good starter)? It could greatly help to track down exactly what commit caused the issue as there are a lot of changes between the two branches:
https://github.com/BobStrogg/teslacam-browser/compare/a8be684..84149e0
Inbetween you would need to compile and run it per the main instructions:
npm install electron .
note if you get odd results it may need to do a cleaning in between.   There are actually not that many commits between the two versions however so if git bisect seems intimidating then you could just try to download the releases in between which would help narrow down the reviews to look at.


based flow detection on time not ticks

You might kill me ....
But the whole concept of ticks is gone and you and I will never get those 2 hours of conversation time back.
Using both our ideas, its just checking if the lookback has any flow and then checking if the first observed flow time is greater than the triggerTime
I think for future-us this does make all the logic more clear.
I could not think of WHY a tick count would be useful at this stage, even using the concept of increase the tick on on NEW flow observation, but still continuing to identify overall flow based on the lookback window.
Adding it in would be 3 lines of code ... but I can not think of the reason why its important
No Water flow detected

Running Water

Flow detected during refreshInterval

Monitoring to watch lookback

Flow outside of refreshInterval but in lookback window

Closing, rebasing, starting clean


Improve process handling

Resolves https://github.com/pikapkg/snowpack/discussions/758 https://github.com/pikapkg/snowpack/discussions/772
Our current process handling is a find-and-replace which has broken on different packages over the years. We keep adding bandaids to it, but now there's interest now from the community in replacing this with something more stable.
We should add a new Rollup plugin which polyfills the actual process object via AST transformation, and not just find and replace. rollup-plugin-node-polyfills would be a good source of inspiration for this:

Their process polyfill: https://github.com/ionic-team/rollup-plugin-node-polyfills/blob/b8c039b41345e162dceef9176a7a896355ba695f/polyfills/process-es6.js
https://github.com/ionic-team/rollup-plugin-node-polyfills/blob/master/src/index.ts

They use the official "inject" plugin to replace the process global with an import process from 'process' import.
We can probably do the same

@fubhy would love your help on this!

I've submitted a pull request here: https://github.com/pikapkg/snowpack/pull/854
Can someone who is more familiar with the snowpack snapshot tests update those snapshots? I seem to see a lot of unrelated changes, including ones with my local file system paths written into the snapshots ;-)


drop BigInt related option from inmanta-ui

The latest version of the web-console no longer uses this option. Think about compatibility before removing it.

Hey team! Please add your planning poker estimate with Zenhub @arnaudsjs @FloLey @Hugo-Inmanta @sanderr


[REST API]: Duplicated "Required. Required. " in parameter description

What article on docs.github.com is affected?
https://docs.github.com/en/rest/reference/apps#create-a-scoped-access-token
What part(s) of the article would you like to see updated?

Thanks so much for letting us know @gr2m!
Anyone is welcome to open a PR to remove the extra "Required" from the access_token row ✨

I looked into the source of the page, but the description is not there. I assume that the **Required.**  needs to be removed from the OpenAPI description as the token parameter is marked as required by the schema, but I'm not 100% sure

Thanks @gr2m! I'll triage this for the team to take a look 👀

Thank you for bringing this to our attention! We will need to fix this internally, so I will close this issue out and open an internal issue.


Dcc ui update

Files can now be added under the sample heading in a separate table. Several samples can be added at once and modified and removed through the UI. The upload button then serves to upload all selected files and shows the same progress bars as before. A new table was also added to preview files currently sitting on the DCC but has not been fully implemented yet.

Run jshint or an alternative "linter" on all your .js files to catch common errors (like missing semicolons).

Also, go through and make sure all the indentation is consistent within each file.

$ jshint server/static/upload.js
server/static/upload.js: line 19, col 58, Use '===' to compare with '0'.
server/static/upload.js: line 22, col 65, Missing semicolon.
server/static/upload.js: line 25, col 61, Missing semicolon.
server/static/upload.js: line 29, col 9, Unnecessary semicolon.
server/static/upload.js: line 33, col 63, Missing semicolon.
server/static/upload.js: line 57, col 63, Missing semicolon.
server/static/upload.js: line 94, col 5, Unnecessary semicolon.
server/static/upload.js: line 101, col 5, Unnecessary semicolon.
server/static/upload.js: line 106, col 44, Missing semicolon.
server/static/upload.js: line 111, col 5, Unnecessary semicolon.
server/static/upload.js: line 128, col 110, Missing semicolon.
server/static/upload.js: line 138, col 40, Use '===' to compare with 'true'.
server/static/upload.js: line 163, col 63, Missing semicolon.
server/static/upload.js: line 171, col 63, Missing semicolon.
server/static/upload.js: line 183, col 27, Missing semicolon.
server/static/upload.js: line 185, col 78, Missing semicolon.
server/static/upload.js: line 187, col 63, Missing semicolon.
server/static/upload.js: line 190, col 46, Missing semicolon.
server/static/upload.js: line 192, col 9, Unnecessary semicolon.
server/static/upload.js: line 205, col 40, Missing semicolon.
server/static/upload.js: line 209, col 58, Missing semicolon.
server/static/upload.js: line 222, col 83, Use '===' to compare with 'true'.
server/static/upload.js: line 226, col 91, Use '===' to compare with 'true'.
server/static/upload.js: line 235, col 42, Use '===' to compare with 'false'.
24 errors

Always show Sample name form, and make the "edit same name" button instead be a proper submit button with text such as "Add sample".

Don't allow blank sample name.

The "Select Samples for Upload" section starts out collapsed for me.

The Edit Sample modal saves unexpected state between interactions.

Hey @ManaseD, I just pushed some commits that start refactoring the code to remove redundancy. Take a look and we can talk more in person.

Awesome! I'm merging this in and we can continue to work on things/bugfix in new branches.


duplicate key violation on autoincrement after loading fixture

If you load a fixture and then try to insert into a table, you can get a duplicate key value violates unique constraint error. After loading the fixture, bun doesn't resync the primary key sequence, so DEFAULT pkey inserts are impossible.

Oh! I have a sort of XY problem. The table wasn't being initialized correctly because I was loading the fixtures in table-driven tests and the loading wasn't playing nice with the concurrency. I guess I'm not sure if that's really a bug then, since I don't know that I expect fixtures to be able to load concurrently anyway.

I don't think it was a concurrent problem I am having the same issue. If you use fixtures with fixed ids and not _id: id1 the sequence is not automatically updated. This is really annoying for unit tests and needs a manual solution. It should definitely be a feature when calling fixture.Load. The struct tag autoincrement should be used to identify this is a sequence and make the appropriate sequence update.


FIX : for Django 2.x and 3.x if settings.USE_TZ is True, the tzinfo M…

Hi @lcd1232,
I faced the same kind of issue as described in #22.
The link between my issue and the database connection pool was not straightforward. It took me a while to figure out why a timezone aware timestamp stored in DB loses the TZ info when loaded into a DateTimeField attribute.
My app is running under Django 3.x and the current code of django-postgresqlpool2 is quite close to be compatible.
This PR should fix the issue.
I saw your PR #27 that was never merged, I hope this one will eventually be.
Thanx in advance.
Thierry

Hi @tramora. Thank you for your PR but I merged #27 because it has some tests and supports more versions


Fix/crash when deleting last line

This PR aims to fix the crashes that happens when you try to delete the last line in a file.

Should fix #47


Incorrect floppy drive IDs

From the Amiga Hardware Reference Manual, 2nd edition page 357, or 3rd edition page 371, the first few drive IDs are as follows:
  0000 0000 0000 0000 0000 0000 0000 0000  Reserved ($0000 0000)
  1111 1111 1111 1111 1111 1111 1111 1111  Amiga standard 3.25($FFFF FFFF)
  1010 1010 1010 1010 1010 1010 1010 1010  Reserved ($AAAA AAAA)
  0101 0101 0101 0101 0101 0101 0101 0101  48 TPI double-density,
                                           double-sided ($5555 5555)

Note how a standard Amiga drive, plugged into the external interface, should read as FFFFFFFF. This is because the /RDY signal is active low, so when the drive pulls /RDY low to signal its presence, the drive ID bits should read as all '1'. A missing drive, or DF0:, should therefore read as 00000000, which in the table above is reserved.
The code 55555555 is used for a 5.25" drive. This leaves AAAAAAAA as the high density 3.5" drive, which spins at half the usual speed.
ATK v1.3 correctly shows missing drives as 00000000, and standard drives as FFFFFFFF. However it shows HD 3.5" drives as 55555555, which indicates a shift-by-one issue in the ID reading algorithm.
ATK v1.18 is displaying 00000000 and FFFFFFFF interchanged, or in other words, the bits have been inverted. I'm guessing this was done to fix up the HD drive ID, but it's not correct. There are now two issues.

The drive IDs listed in the HRM do not agree with the definitions in the disk.resource header file, as used by the Amiga ROM:
DRT_AMIGA	EQU	$00000000
DRT_37422D2S	EQU	$55555555
DRT_EMPTY	EQU	$FFFFFFFF
DRT_150RPM	EQU	$AAAAAAAA

The drive-id reading algorithm in TestKit matches closely with that in a disassembly of disk.resource, which also agrees with the HRM. Just steps 2 and 3 as listed in HRM are merged into one in the disk.resource assembly code (MTRXD- and SELxD- are taken HIGH in one single write to CIABPRB)
FC491C not.b     D3                ; inverts select bit
FC491E lea       $BFD100,A0        ; CIA-B prb
FC4924 move.b    #$7F,D0           ; prepares motor on
FC4928 move.b    D0,(A0)
FC492A and.b     D3,D0             ; motor on for selected drive
FC492C move.b    D0,(A0)
FC492E move.b    #$FF,(A0)         ; deselect drive
FC4932 move.b    D3,(A0)           ; motor off
FC4934 move.b    #$FF,(A0)         ; deselect drive - this resets drive shift id port
FC4938 moveq     #$1F,D1           ; loop 32x
FC493A moveq     #0,D0
FC493C lsl.l     #1,D0
FC493E move.b    D3,(A0)           ; select drive
FC4940 btst      #5,$BFE001        ; check the /RDY bit
FC4948 beq.s     $FC494E
FC494A bset      #0,D0             ; if not set particular bit
FC494E move.b    #$FF,(A0)         ; deselect drive
FC4952 dbra      D1,$FC493C        ; process all 32 bits
FC4956 move.l    D0,(A3)+          ; store result in DR_UNITID
FC4958 not.b     D3                ; turn back select bit
FC495A rts

Note that this code is from a 1.2 ROM disassembly, but this exact same code is found in Kickstart 3.1 too (I just checked).

Kickstart 3.x trackdisk.device uses the DRT_ values directly on the IDs returned by above assembly code. No inversion. No shifting. Also note that above assembly code sets each ID bit (FC494A) iff /RDY is HIGH (FC4940 - FC4948). Hence the ID does not account for /RDY being active low.

In summary, TestKit was fixed to reflect the Amiga includes and how Kickstart behaves, whereas previously the ID was cooked (inverted) to fit the HRM Reserved and DD 3.5 values. I am confident it's now correct.

Fair enough! So the HRM is wrong, I can live with this.


Fix YouTube Embedding Optionality and Add Blog Form Enhancements

This PR addresses an issue with the YouTube video embedding feature and introduces new enhancements to the blog addition form for improved usability.
Features and Updates

YouTube Embedding Fix

Resolved the issue where YouTube embedding was incorrectly treated as mandatory.
Made the embedding feature truly optional, allowing blog creation without a video link.

Content Preview Feature

Added a preview functionality to the blog addition form.
Users can now see a real-time preview of their content before submission, ensuring accurate formatting and layout.

YouTube Embed Link Guide

Introduced an informational "i" button next to the YouTube video field.
Provides clear instructions on how to obtain a valid YouTube embed link, improving user clarity and reducing errors.

Additional Notes

Improved the user experience of the blog addition form by making it more intuitive and user-friendly.
Tested all new features to ensure seamless integration and functionality.

Preview

Blog creators can now easily preview their content before publishing.
The optional YouTube embedding feature works as expected, allowing flexibility in blog creation.
Users are guided with a clear explanation for embedding YouTube videos, enhancing ease of use.

Checklist

[x] Fixed the YouTube embedding optionality issue.
[x] Tested the preview feature for content accuracy and layout.
[x] Verified the informational guide functionality for YouTube links.
[x] Ensured the blog addition form enhancements are responsive and error-free.

lgtm


vulnerabilities

_npm install
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN<EMAIL_ADDRESS>No license field.
added 159 packages from 149 contributors and audited 295 packages in 5.263s
found 13 vulnerabilities (10 low, 3 high)
run npm audit fix to fix them, or npm audit for details_
Need to use npm audit fix --force to get rid of this

this will not be fixed as this repo is no longer maintained (its from the connector days ran, it shouldnt work with the latest pelion dms )

It actually still works - tested last week.
I think we should keep open - if this is ever resurrected, we need to know where we stood (but it's not that high on my priority list)


Fix test timeout failures

A few of ur tests occasionally fail with timeout errors.
One of our tests is failing:
  152 passing (8s)
  1 failing

  1) [CLI] deposit
       Should throw error if unable to connect to eth1 network:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/cayman/Code/lodestar/test/unit/cli/commands/deposit.test.ts)

 152 passing (9s)
  1 failing
  1) [CLI] deposit
       Should make a deposit for 10 accounts derived from mnemonic:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/travis/build/ChainSafe/lodestar/test/unit/cli/commands/deposit.test.ts)

We should either extend the timeout time alotted for these tests, or scale down the work done per test.

Maybe better to change this task to extract long running tests (more than 200ms) to e2e test directory?
Because waiting for all those integration tests slows development.


Simplifying importing AppInsights as module, adding TS interfaces for public types

Fixing #202
Improving readme
Compiling with ES5
Improving name and tags in package.json

Sync with Kamil's changes and :shipit:

Addressed online and offline comments, now exporting downloadAndSetup method, added unit tests


The cargo manifest has been overwritten

I review the code and found that the origin cargo manifest in {$PWD}/.cargo/config has been overwritten by fleet.

Yes！So you need to delete it when going back to cargo，which is confusing！
Jianshu

Hey @jianshu93 you don't exactly need to delete it if you want to use cargo, fleet configures the paths in the .cargo/config.toml, so it would work fine even if you go back (As cargo can process it), but when you clone repos you need to manually update the paths.
Also fleet applies the optimizations and runs cargo run/build after applying them, so we would have to overwrite the cargo config files in the current working directory!

see this： https://github.com/dimensionhq/fleet/issues/20
thanks
Jianshu


Printing []byte panics

Maybe I'm missing something, but when I try to print out my bson.D stuct, it works fine if there is no binary data in it, but if I put in []uint8, it barfs.  As a simple example, this will panic:
foo := []byte { byte(41) }
spew.Dump(foo)

which produces
panic: runtime error: invalid memory address or nil pointer dereference

Cannot reproduce locally. The snippet you've posted runs as expected for me. It's also covered by tests.
What does go version print? Try doing go get -u github.com/davecgh/go-spew/spew and see if it helps.

go version is
go version go1.4 linux/amd64

I tried the program again and it didn't work. I then did the go get -u and it fixed it.  Don't know why I didn't think to try that.  Thanks.

For what it's worth, I just upgraded to 1.4.1 from 1.3.  Wonder if that had something to do with it?

Yes, that would be why. The go runtime changed the memory layout of the reflect stucts that spew uses to perform some of its magic in between go1.3.3 and go1.4.  It was fixed in spew while it was still on go tip well before go1.4 shipped, but older versions of spew (before commit 128854244a4ac24b718da3d5f79cf5541c81ee56 to be precise) will panic on the go1.4+ runtime.


Logs has a lozenge with the number of logs by the title

Please remove the number by the title.

@lweitzman
Sure.

Removed!

looks like repos now have a number by them. this number is in the datagrid so it doesnt need to be by the title

@wknet123
Please remove the number label.


Bottom to Top Button

Sometimes we got tired of scrolling up so long so there is feature I want to add @smaranjitghose  sir i.e  bottom to top button.
Reference

Please assign me this issue under DWoC.

We would have a chatbot integration soon, hence this is not required for now


Normalize aligned attributes

We currently store all defined aligned attributes for types but only use the largest. I don't see why this couldn't be normalized when creating the attributed type.

I was thinking that we could existing and new attributes for the largest alignment and only store one alignment attribute with that value. This deduplication should also happen to most other attributes.


Passport verification

Is passport only means for verification and other Ids are not allowed?

Actually, what I heard from the competition admins is that passport works for sure. I am not sure about whether other IDs could work. I suggest you could try the other IDs first and see their feedback...


Monit does not update

Since update today to Monit 1.5 new or changed settings do not work as expected.
Also email notifications are not consistent. The 'Test Configuration' button does not work consistently.
Clicking the 'Reload Configuration' button does not reinitialize the status.
Monit also shows control issues on one of the boxes. Shows
'/usr/local/etc/monitrc:17: syntax error 'failed'' when testing the configuration. Tried to reinstall Monit with no success.
Non of these issues existed yesterday.

This should help for now:
# opnsense-revert -r 18.1.2 os-monit

Definitely an issue with 1.5. All works with 1.4.
One thing I noticed is the Apply button in the General Settings does not do anything with 1.5
With 1.4 the circle spins and changes are made to /etc/monitrc

/usr/local/etc/monitrc:17: syntax error 'failed'

@tpcr you have an error in your 'Service Test Settings' that probably wasn't detected before 1.5
Could you post the lines 15 to 19 from your monitrc?

One thing I noticed is the Apply button in the General Settings does not do anything in version 1.5

The behavior has changed slightly.
The Apply button does exactly what it's name say: "Apply the changes to the config" and not more.
In 1.4 it also reloads the service. This took some time and that's why you saw the spinner.
@fichtner I think we need a better feedback here. Maybe a status line "Your config has changed. Please click Apply and reload the service" which disappears after clicking Apply/Reload?

I'll import monit plugin to base and take a look this week. All pages apply + reload/restart, maybe if restart takes to long we can get away with a reload?

No, it already reloads. :smirk:
The problem was that the tables apply the config via dialog boxes. And the 'General Settings' via Apply button.
This was inconsistent since after editing tables you had to click on Reload.
Editing 'General Settings' only Apply was needed.

Here is the monitrc file
`# DO NOT EDIT THIS FILE -- OPNsense auto-generated file
set httpd unixsocket /var/run/monit.sock
allow localhost
set daemon 60 with start delay 30
set logfile syslog facility log_daemon
set mailserver <IP_ADDRESS> port 2525 username<EMAIL_ADDRESS>password "xxxxxxxx"
set alert<EMAIL_ADDRESS>{ action,resource,status } mail-format { from<EMAIL_ADDRESS>} reminder on 10 cycles
check system $HOST
if failed link then alert   # This is line 17 #
if memory usage is greater than 25% then alert
if cpu usage is greater than 25% then alert
check filesystem RootFs with path /
if space usage is greater than 50% then alert
check program CPUtemp with path /usr/local/bin/CheckCPUTemp.sh
if status notequal 0 then alert
`

Monit has been uninstalled from the box with the issue, but the /etc/monitrc file is still there.
Monit 1.5 has been downgraded on the other boxes to version 1.4. With 1.5 installed it did not send notifications.
It acts as though it is getting the wrong monitrc file in version 1.5.
Also, one other thing I noticed in Monit. When email 'Secure Connection' is enabled, it forces SSL and not STARTTLS, so when you import the configuration from notifications and STARTTLS was used, it does not use the same Secure Connection in Monit. Which is why I think I get no notifications in version 1.5. Once I Imported the config from notifications, it stored the info in the 'ghost' monitrc and uses that instead of the actual one. Making changes in Monit has no affect on /etc/monitrc in the box with the issue.

For more in depth info. When I first used monit 1.5, I made a change to the 'Service Tests Settings' condition on one of the entries to test. I changed the memory usage to invoke a trigger. I may have entered a wrong value which initially caused the error. But I was never able to correct it. The monitrc file made the change back, but monit would never start after that with the error I caused in the initial test.
So maybe a good test is to create a condition error on purpose and see if you can get rid of it.

check system $HOST
if failed link then alert # This is line 17 #
if memory usage is greater than 25% then alert
if cpu usage is greater than 25% then alert

'failed link' is a network interface test and you have it linked to the system test.
see Monit Network Interface Tests

Monit has been uninstalled from the box with the issue, but the /etc/monitrc file is still there.

Really /etc/monitrc ?
This could cause your trouble. Because:

Monit is configured and controlled via a control file called monitrc. The default location for this file is ~/.monitrc. If this file does not exist, Monit will try /etc/monitrc, then @sysconfdir@/monitrc and finally ./monitrc. ...

The plugin uses only /usr/local/etc/monitrc.

Also, one other thing I noticed in Monit. When email 'Secure Connection' is enabled, it forces SSL and not STARTTLS, so when you import the configuration from notifications and STARTTLS was used, it does not use the same Secure Connection in Monit. Which is why I think I get no notifications in version 1.5

As far as I know Monit doesn't support STARTTLS for alerts. The notification import enables the SSL instead because most mail servers which support STARTTLS support SSL too.

I believe that the service is pulling the data from somewhere other than /usr/local/etc/monitrc

I guess from /etc/monitrc. :smirk:

Thanks, the Network link was the issue. Error went away as soon as I removed it and reloaded it.
The lack of documentation for this plug-in is so sparse I had no way to know where the Network link should have gone.
Also the way that the Apply button works is different and is misleading as to what it really does now.
The Monit install does not create monitrc at ~/ on my systems. The only place it exists is in /usr/local/etc.
The only reason I bring up the STARTTLS issue is because when importing from notifications, SSL does not exist so if the email server is setup to receive only STARTTLS, for whatever reason, it will not work in Monit. The GUI should have a warning when importing the secure connection since notifications and Monit use different methods. Don't assume every email server accepts both.
Thanks for clearing this up. I will close this issue.

The lack of documentation for this plug-in is so sparse ...

A good starting point is the Monit Mini Howto
And then the Monit Documentation itself.

Read those, no explanation on what all the services tests are and how to use them. Which is what got me in trouble in the first place. Also no docs on setting up custom tests. What is the syntax for using conditions with a custom script? Docs are sparse and expect many issues if users like me dive into Monit.
For example, what conditions do I use for Network Saturation or Network link and do these only work with Type ' Network'? Do I need a specific name for a service or can I use anything?

Possible service tests are listed in the SERVICE TESTS section of the Monit documentation.
But you have to define conditions at which you want to have an alert or other actions like restart, unmonitor etc.
These conditions are service specific. The system cannot have a failed link. It can have an overloaded CPU for example.
But a network interface test can check the link.
The NETWORK SERVICE TEST section describes all tests you can do on a network interface.
Example step by step:
What to monitor? Network Link.
Which condition? Link is down, i.e. failed.
What to do? Try to bring it up again.
First create a test:
Name: NetworkLinkRestart   <- choose a name of your choice
Condition: failed link <- see Monit Documentation
Action: Restart
Now you can reuse this test on any network service check.
Then a service:
Name: Iface_OPT1 <- freely selectable, I add the interface name to see which one failed (see Interfaces->Assignments)
Type: Network
Address: <- leave it empty, we are not interested in addresses
Interface: OPT1 <- the interface to monitor
Start: /etc/rc.d/netif start vtnet1 <- vtnet1 is OPT1 see assignments
Stop: /etc/rc.d/netif stop vtnet1
Test: NetworkLinkRestart <- the test created above
Create a service for all your interfaces with the same test.
Same with saturation (your networkcard must support it):
Test:
Name: Saturation90
Condition: saturation greater 90%
Action: Alert
Service:
Name: Iface_OPT1_90
Type: Network
Interface: OPT1
Test: Saturation90
Start/Stop is not needed since the test creates only alerts.

That was a GREAT help. Thank you.
Now what about a custom test. I have created a script to check CPU temps.
How can I add a condition that has the temp value to check
ie. Condition -  "CPU temp greater than 60 degrees"
here is my script
`#!/bin/csh
set MaxCPUTemp = 60
set status = 0
set NumCPUs = sysctl -n kern.smp.cpus
set CurrentCPU = 0
while ( $CurrentCPU < $NumCPUs )
set CPUTemp = sysctl dev.cpu.$CurrentCPU.temperature | awk '{print $2}' | awk -F. '{print $1}'
echo "CPU $CurrentCPU temp: $CPUTemp"
if ( $CPUTemp >= $MaxCPUTemp ) then
exit 1
endif
@ CurrentCPU = $CurrentCPU + 1
end
exit 0`

What can I add to a script that passes a variable/value to the script?

Usually as parameter.
But now I see the plugin doesn't allow that. It's a bug. :worried:
Anyway the PROGRAM STATUS TEST section says that you can test the exit code only.
Therefore let the script exit with the CPU temperature and create a test with condition 'status greater 60'.
Then create a custom service for each CPU and a script for each CPU as workaround for the bug.
After the fix you can use a single script and provide the CPU number as parameter.
#!/bin/csh

#set CPU = $1
set CPU = 0
set CPUTemp = sysctl dev.cpu.$CPU.temperature | awk '{print $2}' | awk -F. '{print $1}'
echo "CPU$CPU temp: $CPUTemp"
exit $CPUTemp

Setting the Network Link action to restart, will that run the start/stop commands, or restart OPNsense?

it runs the Start/Stop commands

I simplified the script because I got an error. Getting the same error.
Here is the script I used
#!/bin/csh

set CPUTemp = sysctl dev.cpu.0.temperature | awk '{print $2}' | awk -F. '{print $1}'
echo "CPU0 temp: $CPUTemp"
exit $CPUTemp

Yes, was a quick hack, not tested.
But I see you got the idea :smiley:
And with the fix of #585 you need only one script with the CPU number as parameter.

Excellent. Let me know when fix is ready and I will test it.

@tpcr the bug was fixed in #587

I did make the changes and used the following script, which seems to work using a condition - "status greater 1. I could not use $CPUTemp as the exit code.
#!/bin/csh

set MaxCPUTemp = 60
set NumCPUs = `sysctl -n kern.smp.cpus`
set CurrentCPU = 0

while ( $CurrentCPU < $NumCPUs )
   set CPUTemp = `sysctl dev.cpu.$CurrentCPU.temperature | awk '{print $2}' | awk -F. '{print $1}'`
   echo "CPU $CurrentCPU temp: $CPUTemp"
   if ( $CPUTemp >= $MaxCPUTemp ) then
   exit 1
   endif
   @ CurrentCPU = $CurrentCPU + 1
end
exit 0

Why not?

I get a unrecognized variable as the Last Exit Value

And why do you changed the script? :confused:
You do not need more than these 6 lines.

I was just pointing out that I did not get a value returned when using
exit $CPUTemp as I did with the previous script that only checked CPU 0.
I am happy with the new script as it sends a notification with the temp of the failing CPU from the echo command. But I would prefer a script that was controlled by the condition statement instead of having to hard code the max temp value in the script as in - status greater than 60. I am sure it can be done, I am just a novice coder.

Sorry now you've lost me.
Is your problem solved now or not?

You still need a custom service for each CPU.
Add the CPU number as parameter to the Path and use the script above.

The script works if I hard code the MaxCPUTemp value in the script. Which I can live with for now.
The better approach would be to test all the CPU temps and pass the highest one to the exit code. Then have that temp checked by the condition - status greater 60. Or better yet - CPUtemp greater 60.
That way a default service test for CPU temps can be included with OPNsense.

The script above checks all the CPU temps and then exits with an exit code 1 on the first CPU that exceed MAXTemp. If all CPU's are good, then an exit code of zero is passed. One script for all CPU tests, except then I have to hard code the MAX Temp value. It's a trade off.

Ah ok. now i got you.
And the problem :smiley:
You should declare CPUTemp in a global context and provide MaxCPUTemp as parameter.
Try this script and add your max to the Path Path: /usr/script/path 60):
#!/bin/csh

set MaxCPUTemp = $1
set NumCPUs = `sysctl -n kern.smp.cpus`
set CurrentCPU = 0
set CPUTemp = 1000

while ( $CurrentCPU < $NumCPUs )
   set CPUTemp = `sysctl dev.cpu.$CurrentCPU.temperature | awk '{print $2}' | awk -F. '{print $1}'`
   echo "CPU $CurrentCPU temp: $CPUTemp"
   if ( $CPUTemp >= $MaxCPUTemp ) then
      exit $CPUTemp
   endif
   @ CurrentCPU = $CurrentCPU + 1
end
exit $CPUTemp

Bingo! Works like a champ.
Thanks!!

:sunglasses:

@tpcr would be fantastic if you could add this as an example to the Monit Mini Howto.
Please :smile:

I have it ready, but need the patch first to Monit 1.6. Commit e94878b
When I do # opnsense-patch e94878b cannot find in the repository

# opnsense-patch -c plugins e94878b

returns
fetch: transfer timed out
I just updated to OPNsense 18.1.4 then tried again with same response

sounds like dns or connectivity doesn't work (IPS?), it's a simple fetch

Yes was an issue with IDS.
I have added to the thread. Should be a sticky in the forum.


{Identity} Do not set logging_enable for Azure Identity credentials

Description
Do not set logging_enable for Azure Identity credentials.
Testing Guide
az login

Identity

Identity


Fix the error when user reorders an unsaved element in a service dialog

https://bugzilla.redhat.com/show_bug.cgi?id=1238721

@jzigmund please add specs

@h-kataria review please

@jzigmund the issue here is moving/reordering of elements/fields in the dialog that haven't been saved yet and do not have a record id yet, we should look at code block here to select correct element and move it around without forcing user to save the dialog first. https://github.com/ManageIQ/manageiq/blob/master/app/controllers/miq_ae_customization_controller/dialogs.rb#L394

@h-kataria I've done the simplest fix, according to BZ "Expected result" as the bugfix is requested (look at the comments). I think we could merge it, anyway it's in plan to rewrite that form to Angular in close term.

@jzigmund i agree that this is simple fix but it is changing existing functionality and forcing user to save all elements first and then go back to edit the record to move/reorder elements. @dclarizio please suggest how we should proceed with this.

@jzigmund This used to work in a single edit, so we should definitely fix it to work the same.  The new editor will be in the SSUI area, but for a while, they will both probably exist, so we can't count on this going away too soon.  Please try to get it fixed correctly and, if needed, set up a time to pair with @h-kataria and she can help you out.  Thx, Dan

@h-kataria please review

@jzigmund if i add 2 new elements to a box, and then try to reorder them around it blows up
***** MIQ(miq_ae_customization_controller-tree_select): Session object size of 56 KB exceeds threshold of 50 KB
[----] F, [2016-03-31T10:03:02.456774 #5972:3fc552e974f4] FATAL -- : Error caught: [NoMethodError] undefined method []' for nil:NilClass /home/hkataria/dev/manageiq/app/controllers/miq_ae_customization_controller/dialogs.rb:390:in dialog_res_reorder'

@h-kataria I cannot reproduce that error .. could you verify that error ? If so, please write me the steps 'how to reproduce'.

@jzigmund i tried to edit an existing Service Dialog, added a new box to an existing tab, then added 2 new elements to the new box, then when i try to reorder the new elements under the newly added box it blows up with the error above.

@h-kataria updated PR, fixed processing of the unsaved tabs/boxes also.

verified fix.

verified fix.

@h-kataria are you waiting on something or someone before merging this PR?

@chessbyte for some reason at the time when i verified fix, github didn't seem to respond and i was not seeing anything under Milestone pull down to set milestone and merge, it seems to be available now, i will merge now.


in snp is not allowed in MASH pipeline rds_to_vcf

There are some "*" (which means a deletion) in snp file will cause the error
Error in .Call2("new_XStringSet_from_CHARACTER", class(x0), elementType(x0), : key 42 (char '*') not in lookup table
That may be caused by Biostrings::DNAStringSet(nea), which only allow the input chr as "ACTG".

Well, other than a more technical solution on this, a general question is @hsun3163 when we "harmonize " deletion data, is there a way to harmonize it as eg
GC C

as opposed to:
G *

?

Well, other than a more technical solution on this, a general question is @hsun3163 when we "harmonize " deletion data, is there a way to harmonize it as eg
GC C

as opposed to:
G *

?

One immediate challenge for this is that, the C for GC C is not readily available when all we have is G *

As discussed with @rfeng2023 I think we are going to use the standard N symbol for "any basepair". ...

As discussed with @rfeng2023 I think we are going to use the standard N symbol for "any basepair". ...

should we replace it in the rds_to_vcf process or in the input file (which may need to be fixed in merged.sumstat.vcf)?

This is also a good question. @hsun3163 did you invent the G * convention or bcftools had it? If this is bcftools behavior then we better leave it as is. If it is @hsun3163 's choice then yes we may want to use GN N instead of G * because * is not a standard symbol for sequence data.

They were not introduced by me, instead, they were inherited from the raw vcf.gz file, as indicated below:
hs3163@node96:/mnt/vast/hpc/csg/xqtl_workflow_testing/finalizing/output/data_preprocessing/genotype$ zcat DEJ_11898_B01_GRM_WGS_2017-05-15_21.recalibrated_variants.xqtl_protocol_data.add_chr.add_chr.leftnorm.filtered.vcf.gz | grep "*"  | cut -f 1,2,3,4,5,6 | head
##FORMAT=<ID=RGQ,Number=1,Type=Integer,Description="Unconditional reference genotype confidence, encoded as a phred quality -10*log10 p(genotype call is wrong)">
##bcftools_filterCommand=filter -i 'GT="hom" | TYPE="snp" & GT="het" & (FORMAT/AD[*:1])/(FORMAT/AD[*:0] + FORMAT/AD[*:1]) >= 0.15 | TYPE="indel" & GT="het" & (FORMAT/AD[*:1])/(FORMAT/AD[*:0] + FORMAT/AD[*:1]) >= 0.2'; Date=Wed Oct 19 15:56:29 2022
chr21   9540614 chr21:9540614:G:*       G       *       3256.49
chr21   9550890 chr21:9550890:A:*       A       *       11424.9
chr21   9553296 chr21:9553296:G:*       G       *       3665.16


.NET 8 Preview Support

Is there going to be a preview version to support .NET 8?
For example on preview 7, there were multiple changes to the IMutableEntityType including the removal of the method FindProperty.
Thank you for this awesome library.

yeah I will get this out shortly

:tada: This issue has been resolved in version 6.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Can't create a cookie with a domain without a max age

I don't understand the order of the cases here, as this makes it difficult to add a domain to cookie. You have to pass a date in order to pass a domain. I would argue that case 4: and case 5: ought to be reversed. So that you can pass in "name", "value", "domain", "path" and only add "date" if you need it. Better yet, why not make it take an object like every other implementation of the cookie interface and pass the relevant properties to the webdriver class?

At the time I was trying to mimic selenium's interface.  Can you issue a PR?


Modal and Overlay generate findDOMnode warnings when using transitions

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Supply a CSSTransistion through Overlay.transition or Modal.transition within React.StrictMode generates the following console warning:

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Transition which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node

Reproducible Example
https://codesandbox.io/s/restart-ui-finddomnode-rvln6v
Expected behavior
No findDOMNode console warnings when running in StrictMode

I'm willing to contribute this. It seems the fix would be to pass nodeRef as a prop to transition and backdropTransition elements while continuing to supply the ref to the callback functions to maintain backwards compatibility.
 The package.json that is in source control has a different structure from what is downloaded from npm. That makes it challenging to package up changes made in @restart/ui and test them in an independent app.
We can use yarn start to run docusaurus, and all the demos can be found in ~/www/docs/*.mdx, however these demos are not using Typescript. And since demo files are in mdx, debugging would be limited in the browser.


Re-land 7e33575c with history

The empty final diff is on purpose - I accidentally merged https://github.com/apple/swift/pull/40173 by squashing and that's bad because the individual commit history is important.

@swift-ci please smoke test

Let's just hope the muscle memory doesn't kick in and I don't press 'squash' again 😄

@swift-ci please test Windows platform

The Windows test failure has been fixed in main now.

@swift-ci please test Windows platform


ref #373: delete CMSFieldMLT - not used anywhere

Q
A

Branch
master

Bug fix?
no

New feature?
no

BC breaks?
yes

Deprecations?
no

Tests pass?
yes

Fixed issues
chameleon-system/chameleon-system#373

License
MIT

The class is not used since 2009 says the internal GIT and it was marked for removal with a deleteme txt file. I know this is not the right practice, but this were other times. And the file is useless because the database structure changed. Would it be o.k. for you if we mark it deprecated in 6.3.1. I would not want to wait another year to get rid of this orphan.

OK let's do this. But there is a merge conflict - could you have a look?

merge conflict fixed.

Thanks @pixeljunkie


When handling the date in the API response, an error occurs. also we cant overwrite API response

//@code
var upcomingApp = [];
var pastApp = [];
//txtID.text= ensemble.formatter.now().getDate();
response.body.map(function(doc) {
if (doc.appointment_date.getDate() >=  ensemble.formatter.now().getDate())
{
upcomingApp.push(doc);
}
else
{
pastApp.push(doc);
}
});
   //response.body = null;

@vusters is this the same issue that you just fixed? Should this be closed as well?

@gaurikalp - the date comparison in your code is the part that is not working. Also note that when overwriting the API response, you have to add data to the response object:
API:
  myAPI:
     # uri and other params
    onResponse: |
      //@code
      var myNewData = ['some','data'];
      response.body.myNewData = myNewData;

Yes, I have also tried this, but it hasn't worked after I added some data to the response object.
response.body.upcomingApp = upcomingApp;

@vusters this has been open for 3 weeks and @gaurikalp responded to your question as well. Please review and assign if needed

The main issue was the date comparison. We will enhance the date options through this ticket:
https://github.com/EnsembleUI/ensemble/issues/328


fix the sql tag value is null when client using Statement.execute(sql) method

Coverage decreased (-0.01%) to 23.091% when pulling 798ea0b4328dcbdd465df23331016135845ef841 on ascrutae:fix/mysql-plugin-issue into ea37839950c58b77114fbfebffc13f051e1caeb7 on OpenSkywalking:master.

Coverage increased (+0.05%) to 23.091% when pulling b6d5276a356130f887ccc22817d5cff7a8135f84 on ascrutae:fix/mysql-plugin-issue into 03d4d31a8432515785735b399df227ceb6b85cf2 on OpenSkywalking:master.

Coverage increased (+0.05%) to 23.094% when pulling 1eff235b47c9abe4592642c364e1d922bd666c02 on ascrutae:fix/mysql-plugin-issue into 03d4d31a8432515785735b399df227ceb6b85cf2 on OpenSkywalking:master.


Normal README?

How to build it, screenshots, etc...

It is not yet ready for use. I'll add a proper README after all the essential features are implemented and somewhat polished (if that'll ever happen).
But if you want to build it you can do so by doing:
$ mkdir build
$ cd build
$ cmake ..
$ cmake --build .

And then you'd need to launch it from the project root like that:
$ build/noterr

because that's just how it is right now.
Also, keep in mind that I only ever tested it on linux, so I cannot guarantee you that you'll be able to build and run it on any other operating system.


Refactor the logic and fix typo

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

Nice catch
/lgtm

Yeah, it should report it no matter what the status is. Good catch.
/approve