tx hash can't be searched by history plugin,  but has contained by block？？

I think you should reopen the issue below, we all meet it, and it hasn't been fixed yet.
we enable filter-on=* and history plugin since the beginning, I doubt whether replay blockchain could sovle the problem
https://github.com/EOSIO/eos/issues/5334#issuecomment-415226222
@jgiszczak

I think because history plugin save data through applied_transaction signal. so when tx is failed, trace' s action_traces is empty. so get tx by tx_id will get null. but when we get tx by block_num, it will fetch tx from block.

You can use some public EOS block explorer to verify your transaction.

But if the exchange sync data by block, we will far behind the current block, because we can't handle one block within 0.5s.
The only way to sync is to get action/ get transaction by account, using history plugin.
It is obvioursly that the history plugin has bugs, why don't you want to support it ?

The transaction was confirmed by chain, not failed, but we can't search it by get action/get transaction, even if our node is full node.
We enabled filter-on=* and history plugin since the beginning, that would not miss any index.
@firesWu

For example, tx_hash: 95e752dabe0bafd4b93378ec170faf23165620ca3192bb2bbb21856d43446653
It can be searched by block, but can't be searched by get transaction/ get action.

tx: 95e752dabe0bafd4b93378ec170faf23165620ca3192bb2bbb21856d43446653

You can see tx json data from block. traces is null. If tx executed successfully, traces shoud have data. so that we cannot get tx by tx_id, because traces is null and history_plugin parse tx through traces
{
    "id": "95e752dabe0bafd4b93378ec170faf23165620ca3192bb2bbb21856d43446653",
    "trx": {
        "receipt": {
            "status": "executed",
            "cpu_usage_us": 1333,
            "net_usage_words": 17,
            "trx": [
                1,
                {
                    "signatures": [
                        "SIG_K1_KiUbAgztj1NySrpCo6MhzuPhXNp4gCsEJuDmwm4yA5P9BrZD5qnCP3xPdRmuuMniCvgJCLNaSzoikDemwD6SyLNWxszy5A"
                    ],
                    "compression": "none",
                    "packed_context_free_data": "",
                    "packed_trx": "fd4e625ba4ea99c5614e000000000100a6823403ea3055000000572d3ccdcd0170b4a29d6aefa6de00000000a8ed32322770b4a29d6aefa6de302995aa659a0fa4104a0f000000000004454f53000000000636393235313000"
                }
            ]
        },
        "trx": {
            "expiration": "2018-08-02T00:23:25",
            "ref_block_num": 60068,
            "ref_block_prefix":<PHONE_NUMBER>,
            "max_net_usage_words": 0,
            "max_cpu_usage_ms": 0,
            "delay_sec": 0,
            "context_free_actions": [],
            "actions": [
                {
                    "account": "eosio.token",
                    "name": "transfer",
                    "authorization": [
                        {
                            "actor": "vuniyuoxoeub",
                            "permission": "active"
                        }
                    ],
                    "data": {
                        "from": "vuniyuoxoeub",
                        "to": "okbtothemoon",
                        "quantity": "100.2000 EOS",
                        "memo": "692510"
                    },
                    "hex_data": "70b4a29d6aefa6de302995aa659a0fa4104a0f000000000004454f530000000006363932353130"
                }
            ],
            "transaction_extensions": [],
            "signatures": [
                "SIG_K1_KiUbAgztj1NySrpCo6MhzuPhXNp4gCsEJuDmwm4yA5P9BrZD5qnCP3xPdRmuuMniCvgJCLNaSzoikDemwD6SyLNWxszy5A"
            ],
            "context_free_data": []
        }
    },
    "block_time": "2018-08-01T23:52:57.500",
    "block_num": 8973302,
    "last_irreversible_block": 12740862,
    "traces": []
}

So you think the transaction did not executed successfully？But get balance shows the amount has been successfully transfer to our account. Furthermore, eosio has no type to define if the transaction has been executed successfully or not, you can't judge it by traces. @firesWu

transaction_trace is different from transaction_metadata.  trx is telling block that you need to execute these tx. traces  is the execution result of tx. so when tx failed in execution. we can see tx in trx, but we cannot see tx in traces and history_plugin store data through traces.  I show you a example. tx_id is 6d61113404e27ba26f13f67d447aed435f83b9e705d8f0ddabf953a078089701 , block_num is 511019
and traces result is
{
  "id": "6d61113404e27ba26f13f67d447aed435f83b9e705d8f0ddabf953a078089701",
  "receipt": {
    "status": "hard_fail",
    "cpu_usage_us": 0,
    "net_usage_words": 0
  },
  "elapsed": 521,
  "net_usage": 0,
  "scheduled": true,
  "action_traces": [
    {
      "receipt": {
        "receiver": "",
        "act_digest": "0000000000000000000000000000000000000000000000000000000000000000",
        "global_sequence": 0,
        "recv_sequence": 0,
        "auth_sequence": [

        ],
        "code_sequence": 0,
        "abi_sequence": 0
      },
      "act": {
        "account": "",
        "name": "",
        "authorization": [

        ],
        "data": ""
      },
      "elapsed": 0,
      "cpu_usage": 0,
      "console": "",
      "total_cpu_usage": 0,
      "trx_id": "0000000000000000000000000000000000000000000000000000000000000000",
      "inline_traces": [

      ]
    }
  ],
  "failed_dtrx_trace": null,
  "except": {
    "code": 3050003,
    "name": "eosio_assert_message_exception",
    "message": "eosio_assert_message assertion failure",
    "stack": [
      {
        "context": {
          "level": "error",
          "file": "wasm_interface.cpp",
          "line": 930,
          "method": "eosio_assert",
          "hostname": "",
          "thread_name": "thread-0",
          "timestamp": "2018-08-14T03:45:06.355"
        },
        "format": "assertion failure with message: ${s}",
        "data": {
          "s": "refund is not available yet"
        }
      },
      {
        "context": {
          "level": "warn",
          "file": "apply_context.cpp",
          "line": 61,
          "method": "exec_one",
          "hostname": "",
          "thread_name": "thread-0",
          "timestamp": "2018-08-14T03:45:06.356"
        },
        "format": "pending console output: ${console}",
        "data": {
          "console": ""
        }
      }
    ]
  }
}

But cleos get currency balance shows that the transaction has been executed successfully, we get the tokens, and the from account reduce tokens. It make us so confused. Which result should
I believe？I think this must be a bug that should be supported immediately
@firesWu

Besides, I doubt the way you judge whether the transaction has been executed successfully or not. We have already send some transactions which were not executed successfully, the tx_id wouldn't be found in blocks finally. @firesWu

should we not use the status in the transaction to judge whether an transaction success or failure ? @firesWu

@guaiguaihw The transaction is available here:
https://eospark.com/MainNet/tx/95e752dabe0bafd4b93378ec170faf23165620ca3192bb2bbb21856d43446653
I believe a replay with the current version of eos.io would show that transaction.
@firesWu I'm planning on adding action_trace for hard_fail so that it can be tracked via action_trace without having to look at the transaction_trace. This is useful for the mongo_db_plugin so that transaction_traces do not have to be stored, only action_traces because I think a common use case will be to store action_traces and block_states only.
In mongo_db_plugin for irreversible certainty you can check if trx_id of action_trace is in block_state with irreversible = true.

@guaiguaihw The transaction is in my local mongo database:
> db.action_traces.find({"trx_id":"95e752dabe0bafd4b93378ec170faf23165620ca3192bb2bbb21856d43446653"}).pretty()
{
	"_id" : ObjectId("5b7e9867f9a2f323e822f3a4"),
	"receipt" : {
		"receiver" : "eosio.token",
		"act_digest" : "8204055e1bdb36a685190cb8be16d106b0bbc5786175569d21a342bfa814af82",
		"global_sequence" : 144659376,
		"recv_sequence" : 2607016,
		"auth_sequence" : [
			[
				"vuniyuoxoeub",
				46056
			]
		],
		"code_sequence" : 2,
		"abi_sequence" : 2
	},
	"act" : {
		"account" : "eosio.token",
		"name" : "transfer",
		"authorization" : [
			{
				"actor" : "vuniyuoxoeub",
				"permission" : "active"
			}
		],
		"data" : {
			"from" : "vuniyuoxoeub",
			"to" : "okbtothemoon",
			"quantity" : "100.2000 EOS",
			"memo" : "692510"
		},
		"hex_data" : "70b4a29d6aefa6de302995aa659a0fa4104a0f000000000004454f530000000006363932353130"
	},
	"elapsed" : 267,
	"cpu_usage" : 0,
	"console" : "",
	"total_cpu_usage" : 0,
	"trx_id" : "95e752dabe0bafd4b93378ec170faf23165620ca3192bb2bbb21856d43446653",
	"block_num" : 8973302,
	"block_time" : "2018-08-01T23:52:57.500",
	"producer_block_id" : "0088ebf6687bfb7f1230d8d36d632f1f0ef6fc27a66af160c6c94449e1220b1c",
	"account_ram_delta" : [ ],
	"trx_status" : "executed",
	"createdAt" : ISODate("2018-08-23T11:20:07.972Z")
}
{
	"_id" : ObjectId("5b7e9867f9a2f323e822f3a5"),
	"receipt" : {
		"receiver" : "vuniyuoxoeub",
		"act_digest" : "8204055e1bdb36a685190cb8be16d106b0bbc5786175569d21a342bfa814af82",
		"global_sequence" : 144659377,
		"recv_sequence" : 23123,
		"auth_sequence" : [
			[
				"vuniyuoxoeub",
				46057
			]
		],
		"code_sequence" : 2,
		"abi_sequence" : 2
	},
	"act" : {
		"account" : "eosio.token",
		"name" : "transfer",
		"authorization" : [
			{
				"actor" : "vuniyuoxoeub",
				"permission" : "active"
			}
		],
		"data" : {
			"from" : "vuniyuoxoeub",
			"to" : "okbtothemoon",
			"quantity" : "100.2000 EOS",
			"memo" : "692510"
		},
		"hex_data" : "70b4a29d6aefa6de302995aa659a0fa4104a0f000000000004454f530000000006363932353130"
	},
	"elapsed" : 4,
	"cpu_usage" : 0,
	"console" : "",
	"total_cpu_usage" : 0,
	"trx_id" : "95e752dabe0bafd4b93378ec170faf23165620ca3192bb2bbb21856d43446653",
	"block_num" : 8973302,
	"block_time" : "2018-08-01T23:52:57.500",
	"producer_block_id" : "0088ebf6687bfb7f1230d8d36d632f1f0ef6fc27a66af160c6c94449e1220b1c",
	"account_ram_delta" : [ ],
	"trx_status" : "executed",
	"createdAt" : ISODate("2018-08-23T11:20:07.972Z")
}
{
	"_id" : ObjectId("5b7e9867f9a2f323e822f3a6"),
	"receipt" : {
		"receiver" : "okbtothemoon",
		"act_digest" : "8204055e1bdb36a685190cb8be16d106b0bbc5786175569d21a342bfa814af82",
		"global_sequence" : 144659378,
		"recv_sequence" : 9695,
		"auth_sequence" : [
			[
				"vuniyuoxoeub",
				46058
			]
		],
		"code_sequence" : 2,
		"abi_sequence" : 2
	},
	"act" : {
		"account" : "eosio.token",
		"name" : "transfer",
		"authorization" : [
			{
				"actor" : "vuniyuoxoeub",
				"permission" : "active"
			}
		],
		"data" : {
			"from" : "vuniyuoxoeub",
			"to" : "okbtothemoon",
			"quantity" : "100.2000 EOS",
			"memo" : "692510"
		},
		"hex_data" : "70b4a29d6aefa6de302995aa659a0fa4104a0f000000000004454f530000000006363932353130"
	},
	"elapsed" : 5,
	"cpu_usage" : 0,
	"console" : "",
	"total_cpu_usage" : 0,
	"trx_id" : "95e752dabe0bafd4b93378ec170faf23165620ca3192bb2bbb21856d43446653",
	"block_num" : 8973302,
	"block_time" : "2018-08-01T23:52:57.500",
	"producer_block_id" : "0088ebf6687bfb7f1230d8d36d632f1f0ef6fc27a66af160c6c94449e1220b1c",
	"account_ram_delta" : [ ],
	"trx_status" : "executed",
	"createdAt" : ISODate("2018-08-23T11:20:07.972Z")
}

Replay cost almost two day, if we enabled filter-on=*.

Defects in history_plugin were corrected with release v1.4.3.  See #6220 for details.  A replay with version 1.4.3 or later should resolve the discrepancies reported in this issue.


Weird Behavior Installing Templateflow

This is a cross-post from https://neurostars.org/t/weird-behavior-installing-templateflow/4458
My issue is that when I use the command pip install templateflow --user I'm expecting there to be a directory called templateflow in $HOME/.cache; however, this isn't the case. The output from my command is as follows:
Collecting templateflow
Requirement already satisfied: tqdm in ./.local/lib/python3.6/site-packages (from templateflow) (4.31.1)
Requirement already satisfied: pybids<0.8.0a0,>=0.7.0 in ./.local/lib/python3.6/site-packages (from templateflow) (0.7.1)
Requirement already satisfied: requests in ./.local/lib/python3.6/site-packages (from templateflow) (2.21.0)
Requirement already satisfied: num2words in ./.local/lib/python3.6/site-packages (from pybids<0.8.0a0,>=0.7.0->templateflow) (0.5.10)
Requirement already satisfied: nibabel>=2.1 in ./.local/lib/python3.6/site-packages (from pybids<0.8.0a0,>=0.7.0->templateflow) (2.4.0)
Requirement already satisfied: numpy in ./.local/lib/python3.6/site-packages (from pybids<0.8.0a0,>=0.7.0->templateflow) (1.16.4)
Requirement already satisfied: pandas>=0.23.0 in ./.local/lib/python3.6/site-packages (from pybids<0.8.0a0,>=0.7.0->templateflow) (0.24.2)
Requirement already satisfied: grabbit==0.2.6 in ./.local/lib/python3.6/site-packages (from pybids<0.8.0a0,>=0.7.0->templateflow) (0.2.6)
Requirement already satisfied: scipy in /gpfs/hps/soft/rhel7/python/3.6.8/lib/python3.6/site-packages (from pybids<0.8.0a0,>=0.7.0->templateflow) (1.2.1)
Requirement already satisfied: bids-validator in ./.local/lib/python3.6/site-packages (from pybids<0.8.0a0,>=0.7.0->templateflow) (1.2.4)
Requirement already satisfied: patsy in ./.local/lib/python3.6/site-packages (from pybids<0.8.0a0,>=0.7.0->templateflow) (0.5.1)
Requirement already satisfied: six in /gpfs/hps/soft/rhel7/python/3.6.8/lib/python3.6/site-packages (from pybids<0.8.0a0,>=0.7.0->templateflow) (1.11.0)
Requirement already satisfied: idna<2.9,>=2.5 in ./.local/lib/python3.6/site-packages (from requests->templateflow) (2.8)
Requirement already satisfied: certifi>=2017.4.17 in ./.local/lib/python3.6/site-packages (from requests->templateflow) (2019.3.9)
Requirement already satisfied: chardet<3.1.0,>=3.0.2 in ./.local/lib/python3.6/site-packages (from requests->templateflow) (3.0.4)
Requirement already satisfied: urllib3<1.25,>=1.21.1 in ./.local/lib/python3.6/site-packages (from requests->templateflow) (1.24.3)
Requirement already satisfied: docopt>=0.6.2 in ./.local/lib/python3.6/site-packages (from num2words->pybids<0.8.0a0,>=0.7.0->templateflow) (0.6.2)
Requirement already satisfied: python-dateutil>=2.5.0 in /gpfs/hps/soft/rhel7/python/3.6.8/lib/python3.6/site-packages (from pandas>=0.23.0->pybids<0.8.0a0,>=0.7.0->templateflow) (2.6.0)
Requirement already satisfied: pytz>=2011k in /gpfs/hps/soft/rhel7/python/3.6.8/lib/python3.6/site-packages (from pandas>=0.23.0->pybids<0.8.0a0,>=0.7.0->templateflow) (2018.4)
Installing collected packages: templateflow
Successfully installed templateflow-0.3.0

This isn't a terribly big issue for me, because I can just set things up on my end with:
	if [ ! -d $HOME/templateflow ]; then
		mkdir $HOME/templateflow
		pip install templateflow --user
		unzip $HOME/.local/lib/python3.6/site-packages/templateflow/conf/templateflow-skel.zip -d $HOME/templateflow
	fi

Let me know if I need to provide any additional information.
Dan

Hi @dlevitas, the directory is created the first time you import templateflow. However, I agree that installation is still very imperfect in this regard (see #11).


Use environment markers for typing version

Was packaging this for nixpkgs and noticed some odd import behaviors.
typing package is a backport and doesn't need to be imported for python>=3.5
see https://github.com/python/typing/issues/573

Thank you for the PR!
As for typing dependency, how about simply removing it?
We have already abandoned Python<3.5 support in master (v7 series) branch.
Although v6 series still continues to support Python 2 for some time, I don't think this change has to be backported to v6, because the next v6 release will coincide with v7.0.0 major release. A change of dependency in already-released-as-stable v6, which might cause unexpected problem for existing v6 users, is also a concern.

sure, sounds good

done

Thanks!
Jenkins, test this please

If active development on master no longer cares for python2.7/3.5 compatibility, you may as well disable the respective CI paths

Jenkins CI test (for commit de9500798f45b7310bcc0ae1f3fb1f92e4678e21, target branch master) failed with status FAILURE.

If active development on master no longer cares for python2.7/3.5 compatibility, you may as well disable the respective CI paths

We've already done that (Btw, Python 3.5 is still supported).
Thanks!
Jenkins failure is unrelated.


restructure the project

requires #3
remove scripts which will not be needed after restructuring the project. The only task of this project is to 1) analyze one or multiple APK files and 2) calculate the security scoring formula. The extraction tool for firmware images is open source at https://github.com/ernstleierzopf/AndScanner and it does not need a dockerfile to extract a single firmware image.  The mentioned files include:

run.sh (include instruction on how to run the software in readme.md - will be changed anyways)
dockerfile_*
data directory
move submodules/TestCasesScripts/* to root directory of the project and remove these directories

Done in forked repository.


vulkan-loader: make it work on 32-bit applications on 64-bit inode filesystems

Now with a proper upstream patch.
Upstream report: https://github.com/KhronosGroup/Vulkan-Loader/issues/1551
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Drafting until we know more

Replaced with a pending patch from upstream, should be good now.

Good catch, I was about to hit the merge button :o

Let's give it another couple days, upstream will probably merge the patch and then we can pull the final version.

Upstream merged, patch yoinked.


JSON parser for colors

Adds the ability to parse JSON color files rather than just txt, clr, or xml.

This looks promising, thanks a lot for the PR!
Could you add an entry in the CHANGELOG  to mention the change and credit yourself?

Awesome thanks :)
Added the entry in the changelog


Unable to update privacy url in App Store using deliver by fastlane 2.217.0

New Regression Checklist

[ ] Updated fastlane to the latest version
[ ] I read the Contribution Guidelines
[ ] I read docs.fastlane.tools
[ ] I searched for existing GitHub issues

Regression Information

Breaking version: 2.217.0
Last working version: 2.216.0

Regression Description
fastlane deliver on 2.217.0 fails to upload a privacy url for an iOS app from fastlane/metadata/en-GB/privacy_url. This works as expected on fastlane 2.216.0.

Also I am trying with update privacy_url with lane in Fastfile, but its fails.
My lane for deliver is:
deliver(
price_tier: 0,
precheck_include_in_app_purchases: false,
run_precheck_before_submit: false,
force: true,
skip_screenshots: true,
overwrite_screenshots: true,
skip_binary_upload: true,
skip_metadata: false,
app_rating_config_path: "fastlane/rating_config.json",
submit_for_review: true,
privacy_url:{
"en-US" => "https://test.com/page/privacy-policy"
}
)

Thanks for sharing this here, Waiting for the response of others.


Fix backward compatibility issue with Java17 migration

Description:

$subject

Completed with following PR:

https://github.com/ballerina-platform/module-ballerina-email/pull/717


Update partner profile for version 1.9

For version 1.9 - we added the possibility to have more links on the partner profile page

Document Details
⚠ Do not edit this section. It is required for docs.superOffice.com ➟ Docs Team processing.

Content Source: dp-update-partner-profile

Trust center info


Strange TypeScript behavior with resolvers unless wrapped in NonNullable

I was trying to figure out why I kept getting this error despite following the advice of the docs and issues to set useIndexSignature: true:
error TS2322: Type '{ Query: { bananas: ResolverFn<ResolverTypeWrapper<string>, {}, any, {}> | undefined; }; Mutation: {}; }' is not assignable to type 'IResolvers<any, any> | IResolvers<any, any>[] | undefined'.
  Type '{ Query: { bananas: ResolverFn<ResolverTypeWrapper<string>, {}, any, {}> | undefined; }; Mutation: {}; }' is not assignable to type 'IResolvers<any, any>'.
    Property 'Query' is incompatible with index signature.
      Type '{ bananas: ResolverFn<ResolverTypeWrapper<string>, {}, any, {}> | undefined; }' is not assignable to type '(() => any) | GraphQLScalarType | IEnumResolver | IResolverObject<any, any, any> | IResolverOptions<any, any, any>'.
        Type '{ bananas: ResolverFn<ResolverTypeWrapper<string>, {}, any, {}> | undefined; }' is not assignable to type 'IResolverObject<any, any, any>'.
          Property 'bananas' is incompatible with index signature.
            Type 'ResolverFn<ResolverTypeWrapper<string>, {}, any, {}> | undefined' is not assignable to type 'IResolverObject<any, any, any> | IResolverOptions<any, any, any> | IFieldResolver<any, any, any>'.
              Type 'undefined' is not assignable to type 'IResolverObject<any, any, any> | IResolverOptions<any, any, any> | IFieldResolver<any, any, any>'.

5 const apolloServer = new ApolloServer({typeDefs, resolvers});
                                                   ~~~~~~~~~

  node_modules/apollo-server-core/dist/types.d.ts:48:5
    48     resolvers?: IResolvers | Array<IResolvers>;
           ~~~~~~~~~
    The expected type comes from property 'resolvers' which is declared here on type 'Config'

I realized that when I had my resolvers in a different file like:
// resolvers.ts
import bananas from "./resolver/bananas";
import {Resolvers} from "./types-generated";

let resolvers: Resolvers;
export default resolvers = {
    Query: {
        bananas,
    },
};

// resolvers/bananas.ts
import {QueryResolvers} from "../types-generated";
const bananas: QueryResolvers["bananas"] = async () => "Hello, Banana!";
export default bananas;

two unexpected behaviors would happen:

The ApolloServer constructor would complain about the resolver possibly being undefined.
Type checking on the resolver's arguments and return value does not work.

When I wrapped my resolver's type in NonNullable like this:
// resolvers/bananas.ts
import {QueryResolvers} from "../types-generated";
const bananas: NonNullable<QueryResolvers["bananas"]> = async () => "Hello, Banana!";
export default bananas;

the above two issues are fixed. Also interesting is that ApolloServer doesn't complain even if I have useIndexSignature: false instead of true.
I'm not sure a fix for this would be in the form of documentation or code. The documentation route would be the easiest. If the fix was done via code, maybe you could generate a type for each resolver function, so instead of QueryResolver["bananas"] you would use BananasResolver, which would already be wrapped with NonNullable. I'm not familiar with the internals so perhaps there is a better approach than what I suggested.

My GraphQL schema:

type Query {
    bananas: String!
}

My codegen.yml config file:

overwrite: true
schema: src/graphql/type-defs.ts
generates:
    src/graphql/types-generated.d.ts:
        plugins:
            - typescript
            - typescript-resolvers
        config:
            noSchemaStitching: true
            useIndexSignature: true
require:
    - ts-node/register/transpile-only

Environment:

OS: MacOS Catalina
@graphql-codegen/...: 1.8.1
NodeJS: v12.12.0
TypeScript: 3.6.4
apollo-server-core: 2.9.6

@msheakoski
Can you please try to use Resolvers type, and not the child types? I think the index signature is being applied only for the root type and not for the child resolvers types.

@dotansimha Yes, you are correct that the main Resolvers type behaves as designed when working from a single file containing all resolvers.
What if I have, for example, 100 different resolvers? I would not want to inline all of that code into a single file because it would be thousands of lines long and hard to maintain.
Given this use case, what would be the best way to type my resolvers when they are in separate files?
I think adding a note to the docs or maybe even a generated comment above the Resolvers type to wrap the resolver in NonNullable would be helpful to anybody in a similar situation.
The other solution that comes to mind would be adding something like a useIndividualResolverTypes option that generates types like BananaQueryResolver, LogInMutationResolver, GetCommentsQueryResolver. However, I'm not sure if that is worth all of the extra work when simply wrapping the resolver type in NonNullable achieves the same effect.

The main Resolvers just points to sub-types of resolvers, you can use QueryResolvers as well and it will work the same, this way you can write it in different files (and those type doesn't enforce you to implement all fields in the same file, it just provides validation for field names and types)

I am currently using it as you suggested, with QueryResolvers and MutationResolvers. The problem is that QueryResolvers is generated like this:
export type QueryResolvers<
  ContextType = any,
  ParentType extends ResolversParentTypes["Query"] = ResolversParentTypes["Query"]
> = {
  bananas?: Resolver<
    ResolversTypes["String"],
    ParentType,
    ContextType
  >
}

Take special note of the ?: because this causes ApolloServer to complain only when using QueryResolvers in a different file. It does not happen when all of the resolvers are inlined together in a single file. It does not matter if useIndexSignature is true or false:
Error:(9, 3) TS2322: Type '{ Query: { bananas: ResolverFn<...> | undefined; }; }' is not assignable to type 'IResolvers<any, any> | IResolvers<any, any>[] | undefined'.
  Type '{ Query: { bananas: ResolverFn<...> | undefined; }; }' is not assignable to type 'IResolvers<any, any>'.
    Property 'Query' is incompatible with index signature.
      Type '{ bananas: ResolverFn<...> | undefined; }' is not assignable to type 'GraphQLScalarType | (() => any) | IEnumResolver | IResolverObject<any, any, any> | IResolverOptions<any, any, any>'.
        Type '{ bananas: ResolverFn<...> | undefined; }' is not assignable to type 'IResolverObject<any, any, any>'.
          Property 'bananas' is incompatible with index signature.
            Type 'ResolverFn<ResolverTypeWrapper<string>, {}, any, {}> | undefined' is not assignable to type 'IResolverObject<any, any, any> | IResolverOptions<any, any, any> | IFieldResolver<any, any, any>'.
              Type 'undefined' is not assignable to type 'IResolverObject<any, any, any> | IResolverOptions<any, any, any> | IFieldResolver<any, any, any>'.

The issue that I am trying to express is that any developer using a very common workflow of resolvers in separate files with the most popular GraphQL package will get an unexpected TypeScript error unless they wrap their resolvers with NonNullable<>. I am trying to help others avoid confusion and wasted time.

I see, and if you do:
const queryResolvers: QueryResolvers = { ... }
const resolvers: Resolvers = { queryResolvers };

// Then use `resolvers` in Apollo Server

Does it work? @msheakoski

@dotansimha I tried to reproduce the issue in a CodeSandbox example, but strangely I do not experience it there.
I am going to make a minimal example locally to see if I can pinpoint what might be causing it. So far, all of the projects that I have used graphql-code-generator with have been based on Next.js, so I want to rule out any side effects from using libraries or frameworks. I will report back with my results.

Thanks @msheakoski , waiting for your update :)

Closing.
@msheakoski feel free to update and we can open this again if it's still relevant.

The solution for the author's problem might be:
export const resolvers: QueryResolvers = {};

resolvers.a = async (_, args, context) => {
}

resolvers.b = async (_, args, context) => {
}

Such way, it is possible to distribute resolvers across different files, but having arguments be strictly implicitly typed

Unfortunately, this looks like it was never solved; it just popped up for me today, in May 2021. Typescript is throwing the same error as OP, when trying to define resolvers in separate files.
My file structure looks like this:
service
├─ src
|  ├─ context.ts       <- apollo context w/ prisma
|  |
|  ├─ resolvers
|  |  ├─ index.ts      <- where all of the partials are combined
|  |  └─ partials      <- individual groups of resolvers
|  |     ├─ users.ts
|  |     └─ organizations.ts
|  |
|  └─ typeDefs
|     ├─ index.ts
|     └─ partials
|        ├─ users.ts
|        └─ organizations.ts
|
└─ types
   └─ generated
      └─ graphql.ts    <- generated types

Files like service/src/resolvers/partials/users.ts look like this:
import {
  QueryResolvers,
  MutationResolvers,
} from "../../../types/generated/graphql";
import { Context } from "../../context";

export const queries: QueryResolvers = {
  // get a single user
  user: async (_, where, ctx: Context) => {
    const user = await ctx.prisma.user.findUnique({
      where,
    });
    return user;
  },
};

export const mutations: MutationResolvers = {
  // update a single user's info
  updateUserInfo: async (_, { id, data }, ctx: Context) => {
    const user = await ctx.prisma.user.update({
      where: { id },
      data,
    });
    return user;
  },
};

And all of those are being combined in src/resolvers/index.ts like this:
import scalarResolvers from "graphql-scalars";
import { Resolvers } from "../../types/generated/graphql";

import {
  queries as UserQuery,
  mutations as UserMutation,
} from "./partials/users";

export const resolvers: Resolvers = {
  ...scalarResolvers,

  Query: {
    ...UserQuery,
  },

  Mutation: {
    ...UserMutation,
  },
};

Typescript is throwing the errors on the objects within the queries and mutations inside the partials, for example on user and updateUserInfo above.
@msheakoski did you ever find a solution? I know it was a while ago.


type_min and type_max error

FYI http://bsonspec.org/spec.html

Thanks, can you add a test for it also? Seems like it's missing since this bug slipped through.

Ping?

I kinda fix those too in #47


tests: x86_mmu_api: Add description and doxygen groups

Add description, RTM links and doxygen groups for
x86_mmu_api test cases.
Signed-off-by: Spoorthi K<EMAIL_ADDRESS>

Codecov Report

Merging #9269 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9269   +/-   ##
=======================================
  Coverage   52.46%   52.46%
=======================================
  Files         201      201
  Lines       25290    25290
  Branches     5286     5286
=======================================
  Hits        13268    13268
  Misses       9938     9938
  Partials     2084     2084

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 504584a...adc9f42. Read the comment docs.


bug: Error when using sass $colors with nested map (base & contrast)

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Using a map with base and contrast now results in an error:
            The map color `secondary` is not defined. Please make sure the color exists in your `$colors` map. For
            example: $colors: ( secondary: #327eff );

     L109:    @error $error-msg;

Expected behavior:
To match this example:
https://github.com/driftyco/ionic/blob/eb0b05df88946f1c662c65a707f603aa46ff53cb/src/themes/ionic.functions.scss#L86-L91
  For example:
  $colors: (
    primary:    #327eff,
    secondary:  (base: #32db64, contrast: #000),
  );";

Steps to reproduce:
Change $colors to:
$colors: (
  primary:    #f1f1f1,
  secondary: (base: #f1f1f1, contrast: #f1f1f1),
  dark:  #f1f1f1,
  light:  #f1f1f1
);

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.4
Ionic CLI Version: 2.1.17
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 0.0.47
ios-deploy version: 1.9.0
ios-sim version: 5.0.11
OS: macOS Sierra
Node Version: v6.9.1
Xcode version: Xcode 8.2 Build version 8C38

Thanks for the issue! I'm not able to reproduce this using the conference app. Are you using the color function anywhere in your app or do you have a sample repo I can look at to try to pinpoint the problem?

Well glad you found it! Are your base and contrast colors the same for secondary or was that just for the example?

That was just for the example.


GCS authentication

Add deprecation notice for GCS (see Authentication - GCS section). Closes #9822.
General edits to the page for readability:

Added a header for the URL format table
Moved Example URLs to be a subsection under URL Format
Added Authentication section and moved relevant info for each cloud storage into subsections.  This info used to be provided in footnotes under the URL format table

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/36511b162058cf1fb878dc19494a51be70a550fe/
Edited pages:

v21.1/use-cloud-storage-for-bulk-operations.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/ead423a3412641c9cd28a337728b1945ac62fd79/
Edited pages:

v21.1/use-cloud-storage-for-bulk-operations.md

LGTM! thank you 🙂

@rmloveland - apologies, I did some layout changes in this PR along with content changes. Can you focus on the following content changes:

Deprecation notice added to the Google Cloud row of the URL Format table
GCS section

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/93f6f84a83a877c65be635e495b322f4c68ed2d3/
Edited pages:

v21.1/use-cloud-storage-for-bulk-operations.md

https://youtu.be/7qnd-hdmgfk
jk jk - looking now :-)

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/499fe46aa7aecc11061a91f6dbbe4369ec11edb4/
Edited pages:

v21.1/use-cloud-storage-for-bulk-operations.md


Allow to use ES 7.x as metrics store

With this commit we implement the changes necessary to talk to 7.x
metrics stores while retaining compatibility with older versions.
Relates #605

Thanks!


git.rebase: add --autostash parameter

Stack:

#54
#53 ⬅
#52
#51
#50

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

✓ Commit merged in pull request #54


ambari-funtest: Add jdeb support

This patch add debian package creation support for ambari-funtest
package.
Signed-off-by: Naresh Bhat<EMAIL_ADDRESS>What changes were proposed in this pull request?
Add jdeb support for ambari-funtest.
How was this patch tested?
I did a build (release-2.5.2) and test the package on AArch64 machine installed with Debian-9
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2366/
Test FAILed.
Test FAILured.


[BUG] using alias in response schema

Describe the bug
When using alias in response schema, the documentation uses the alias in the response but the returned response does not use the alias.
To Reproduce
Steps to reproduce the behavior:
class Test(BaseModel):
    test: int = Schema(..., alias=test2)

@router.get("/test", response_model=Test)
def test():
    return {"test": 1}

# in test.py
>> response = client.get("/test", …)
>> response.json()
{"test2": 1}

Expected behavior
I would expect the doc and the code to be consistent.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment:

OS: macOS
FastAPI Version 0.10.1:

import fastapi
print(fastapi.__version__)

Python version, get it with: 3.7.2

python --version

Additional context
N/A

I can use https://github.com/tiangolo/fastapi/issues/31 as a backup solution but still it seems like a bug to me.

I agree with you.
I just implemented it in PR #168, including tests.
It is now available in version 0.17.0 (just released).

Thanks !


Remove offset if its zero

Which issue does this PR close?
Closes #2584
Rationale for this change
If offset is 0, it should be a no-op and can be optimized out.
Questions to the reviewer?
Current proposed change adds this optimization to an existing slightly related optimizer. Does this require its own optimizer independent from eliminate_limit?

Codecov Report

Merging #3102 (f660acb) into master (85d5363) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3102      +/-   ##
==========================================
+ Coverage   85.93%   85.95%   +0.01%
==========================================
  Files         289      290       +1
  Lines       52101    52270     +169
==========================================
+ Hits        44774    44929     +155
- Misses       7327     7341      +14

Impacted Files
Coverage Δ

datafusion/optimizer/src/eliminate_limit.rs
100.00% <100.00%> (ø)

.../core/src/physical_plan/file_format/file_stream.rs
88.88% <0.00%> (-1.59%)
:arrow_down:

datafusion/expr/src/window_frame.rs
92.43% <0.00%> (-0.85%)
:arrow_down:

...tafusion/core/src/physical_plan/file_format/mod.rs
96.95% <0.00%> (-0.42%)
:arrow_down:

datafusion/expr/src/logical_plan/plan.rs
77.60% <0.00%> (-0.35%)
:arrow_down:

datafusion/core/src/dataframe.rs
88.86% <0.00%> (-0.20%)
:arrow_down:

...sion/core/src/physical_plan/file_format/parquet.rs
95.34% <0.00%> (-0.12%)
:arrow_down:

datafusion/optimizer/src/simplify_expressions.rs
83.94% <0.00%> (-0.09%)
:arrow_down:

datafusion/expr/src/binary_rule.rs
84.61% <0.00%> (-0.05%)
:arrow_down:

datafusion/expr/src/columnar_value.rs
100.00% <0.00%> (ø)

... and 17 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM @turbo1912. Could you update the rustdoc at the top of the file now that this optimizes both limits and offsets? I think it makes sense for these related optimizations to be in the same rule.

Nice -- thanks @turbo1912 !


Better handling of Dhall AST

Fix #158
Fix #162
Fix #163
This PR reworks how the config.dhall and packages.dhall files are handled when reading their unevaluated form (i.e. as Dhall AST).
A small summary of what's in it:

move from pattern matching on the shape of the AST to instead traversing the tree and searching for patterns (using e.g. Control.Lens.Combinators.transformOf), and this gives us less error conditions and more freedom for the user to edit the config as they wish
In fact, the shape of packages.dhall is now not constrained at all, while spago.dhall still needs to be a record containing the dependencies key (we need this for spago install $dep)
In case the packages file is not there Spago will not be happy (e.g. it wants to check that the upstream tag is compatible, and wants to check that the packages file is frozen, etc) but continue execution, emitting small 1-line warnings instead of the current 4-line warning
The only exception to the above is when doing spago package-set-upgrade, in which case Spago will error out if the file is not there

/cc @jmackie could you try this out and see if it behaves as you'd expect?

Looks good to me :) Thanks for your work on this, it's much appreciated!

You're welcome 🙂


Update dependencies

The gem hasn't been updated recently. It is up to a point where it can no longer be used by the new versions of rspec-rails and `rspec-core gems, so un update of its dependencies is required.

remove the BUNDLED WITH line from the Gemfile.lock to fix travis

@grosser, thank you for the tip!


Not very good at detecting nearby vehicles.

I am trying to use the PV-RCNN model trained on pandaset to test it on my private dataset,
1.I converted my dataset's coordinate system to Normative coordinates are:
# - x pointing forward
# - y pointings to the left
# - z pointing to the top
2. pv_rcnn.yaml from kitti pv_rcnn.yaml，modified
_BASE_CONFIG_: cfgs/dataset_configs/pandaset_dataset.yaml
3. In pandaset_dataset.yaml I modified
POINT_CLOUD_RANGE: [-70, -50, -2, 50, 70, 0]# xmin, ymin, zmin, xmax, ymax, zmax
 VOXEL_SIZE: [0.05, 0.05, 0.05]

followed
https://github.com/open-mmlab/OpenPCDet/issues/253#issuecomment-679190936
You can see that at close range, there are one car that are not detected, and some strange results are output (yellow and cyan)

As MartinHahner mentioned in this issue, LiDAR models do not transfer well from one dataset to another one.
https://github.com/open-mmlab/OpenPCDet/issues/599#issuecomment-886656943
But here also mentioned the paper Train in Germany, Test in The USA: Making 3D Object Detectors Generalize, I found that the accuracy should be quite good in the case of close range.
https://github.com/open-mmlab/OpenPCDet/issues/599#issuecomment-888231775
Do you have any suggestions to improve the problem of not being able to detect cars at close range?
1.Do I need to retrain the model with my dataset height?
The lidar of pandaset is close to 2m off the ground, and my data is almost around 2.052m
2.Or are there any parameters I need to adjust carefully?
Such as POINT_CLOUD_RANGE, VOXEL_SIZE

I think our work ST3D can partly help this issue, especially for the 1st problem, which can be solved by just shifting the point cloud on z-axis.

@jihanyang
Thank you for your reply.
I will test my data with ST3D
BTW,

which can be solved by just shifting the point cloud on z-axis.
Is there anything I need to pay attention to about adjusting the point cloud z-axis?
If the lidar point is based on the ground 0m, or based on the actual height of 2.052m, how to adjust it when adjusting?

You can do similar shifting as
https://github.com/CVMI-Lab/ST3D/blob/812b64491c3a67a1b578fe46c375fcd0ed2c4305/tools/cfgs/da-waymo-kitti_models/secondiou/secondiou_old_anchor.yaml#L13

Thank you jihanyang!

Can you highlight the car that you cannot detect?

Image

If the score value is 0.1, there will be a lot of FP.

If the score value is 0.7, there will be a lot of car cannot detect.

Could you provide how does adaptition model perform on this frame, such as pre-trained waymo?


[SPARK-44081] Simplify PartitionedFileUtil API a little

What changes were proposed in this pull request?
Utility methods in PartitionedFileUtil take both file: FileStatusWithMetadata and filePath: Path, even tho the latter can be obtained easily from the former.
This was originally done for performance reasons, so callers can pass a memoized Path and thus avoid the cost of an additional FileStatus.getPath call.
Now that we have FileStatusWithMetadata, the redundancy is no longer needed -- the new class can simply capture the path as a lazy val.
Why are the changes needed?
Simpler code (and eliminates risk of passing a mismatched path).
Does this PR introduce any user-facing change?
No. Internal API change.
How was this patch tested?
Small refactor, existing unit tests suffice.

Thanks, merging to master


Help

Hello, I purchased a new laptop and my older settings are gone and i'm having trouble installing the add on again :(
this is the problem I am facing
Error
An error occurred. Please start Anki while holding down the shift key, which will temporarily disable the add-ons you have installed.
If the issue only occurs when add-ons are enabled, please use the Tools > Add-ons menu item to disable some add-ons and restart Anki, repeating until you discover the add-on that is causing the problem.
When you've discovered the add-on that is causing the problem, please report the issue to the add-on author.
Debug info:
Anki 2.1.54 (b6a7760c) Python 3.9.7 Qt 5.14.1 PyQt 5.14.1
Platform: Mac 12.2.1
Flags: frz=True ao=True sv=2
Add-ons, last update check: 2022-08-22 10:31:13
Add-ons possibly involved: Mindmap from tag hierarchy
Caught exception:
Traceback (most recent call last):
File "/Users/anshika/Library/Application Support/Anki2/addons21/965278890/mindmap_creator_dialog.py", line 48, in _on_show_button_click
self._export_image_mindmap(f.name)
File "/Users/anshika/Library/Application Support/Anki2/addons21/965278890/mindmap_creator_dialog.py", line 151, in _export_image_mindmap
raise e
File "/Users/anshika/Library/Application Support/Anki2/addons21/965278890/mindmap_creator_dialog.py", line 134, in _export_image_mindmap
mindmap.save_as_img(
File "/Users/anshika/Library/Application Support/Anki2/addons21/965278890/mindmap.py", line 46, in save_as_img
raise e
File "/Users/anshika/Library/Application Support/Anki2/addons21/965278890/mindmap.py", line 35, in save_as_img
create_mindmap_img(
File "/Users/anshika/Library/Application Support/Anki2/addons21/965278890/_vendor/brain_dump/graphviz.py", line 112, in create_mindmap_img
pygraph.write_svg(output_file_path, prog=pydot_program, encoding='utf-8')
File "/Users/anshika/Library/Application Support/Anki2/addons21/965278890/_vendor/pydot/pydot.py", line 1609, in new_method
self.write(
File "/Users/anshika/Library/Application Support/Anki2/addons21/965278890/_vendor/pydot/pydot.py", line 1691, in write
s = self.create(prog, format, encoding=encoding)
File "/Users/anshika/Library/Application Support/Anki2/addons21/965278890/_vendor/pydot/pydot.py", line 1785, in create
stdout_data, stderr_data, process = call_graphviz(
File "/Users/anshika/Library/Application Support/Anki2/addons21/965278890/_vendor/pydot/pydot.py", line 129, in call_graphviz
process = subprocess.Popen(
File "subprocess", line 951, in init
File "subprocess", line 1821, in _execute_child
PermissionError: [Errno 13] Permission denied: '/opt/homebrew/opt/graphviz'
Please help me out with this.
Thankyou so much

I remembered how I did it before and solved the problem. I literally wasn't pointing to the dot file in the path. Extremely silly. But it's solved now and I can finally start using the add on again. It's incredible. Thank you so much!!

I remembered how I did it before and solved the problem. I literally wasn't pointing to the dot file in the path. Extremely silly. But it's solved now and I can finally start using the add on again. It's incredible. Thank you so much!!

could you please tell me what you did to solve the problem and how exactly you "pointed to the dot" file?
thank you


Rename NEW_COMMITMENTS_LENGTH to COMMITMENTS_PER_KERNEL

NEW_COMMITMENTS_LENGTH does not convey the meaning of what it actually is. It is the number of new commitments that are generated by one private/public function call. In solidity though, the same constant is called as COMMITMENTS_PER_KERNEL. We should be consistent with this naming and it makes more sense to call it COMMITMENTS_PER_KERNEL instead of NEW_COMMITMENTS_LENGTH.

This was resolved as part of pull request https://github.com/AztecProtocol/aztec-packages/pull/998
Naming was agreed to be MAX_NEW_COMMITMENTS_PER_TX resp. MAX_NEW_COMMITMENTS_PER_CALL.


Multiple dex files error // using other plugins with google-play-services

Hi,
first of all I'd like to say that this plugin is superb and works as supposed.
When digging deeper, I wanted to use push notification via firebase. I used phonegap-plugin-push. Unfortunately following error occurs.
transformDexArchiveWithDexMergerForDebug
Dex: Error converting bytecode to dex:

Cause: com.android.dex.DexException: Multiple dex files define Lcom/google/android/gms/internal/zzben;
    UNEXPECTED TOP-LEVEL EXCEPTION:
    com.android.dex.DexException: Multiple dex files define Lcom/google/android/gms/internal/zzben;

com.android.dex.DexException: Multiple dex files define Lcom/google/android/gms/internal/zzben;
        at com.android.dx.merge.DexMerger.readSortableTypes(DexMerger.java:661)

In the GitHub push plugins GitHub page following is stated.

https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/INSTALLATION.md#multidex

Seems I could narrow it down to this plugin causing this error. Using one of the plugins works fine. But both together give a problem.
Is there any possible solution?
P.S.: I already tried changing the play-services version as hinted in the readme.

Unfortunately, I don't have time to setup whole new project to testing it out.
If you could create a simple repo demonstrating the problem, I would clone and see if could find any fix.

@ratson I replace this code:
cordova.system.library.8=com.google.android.gms:play-services-base:11.0.4
cordova.system.library.9=com.google.android.gms:play-services-ads:11.0.4
in project.properties
With this:
cordova.system.library.8=com.google.android.gms:play-services-base:11.+
cordova.system.library.9=com.google.android.gms:play-services-ads:11.+
And:
BUILD SUCCESSFUL
Dear @ratson. Could you suggest me how to connect unity mediation (I need award video)?
I have links:
https://github.com/googleads/googleads-mobile-android-mediation/tree/master/ThirdPartyAdapters/unity
But I don't know steps how to build it. Could suggest any directions?
Thanks in advance.

You've got info about this in the README:

Customize Google Play Services versions (Android only)
The default PLAY_SERVICES_VERSION is set to 11.0.4.
If you need a different version, edit config.xml with following,
<plugin name="cordova-admob-sdk" spec="~0.13.1">
    <variable name="PLAY_SERVICES_VERSION" value="11.6.0" />
</plugin>

@rafaellop I already mentioned that I tried that and that it did not help. Setting the play-services handles another issue.
@ivanov84 is your post related to my issue? I'm not sure how to include your answer in my code.
@ratson basically it's just creating a simple cordova app, adding phonegap-plugin-push, adding this plugin and trying to build it on android (I use 6.4.0). The build process will not succeed.

oh, and my apologies. Thanks for your quick answers!

@eftas-apps Can you show me your platform/android/project.properties

Hi @tominou
thanks for your help. I pasted some files you might feel interesting.
config.xml (parts)
<plugin name="phonegap-plugin-push" spec="^2.1.3">
        <variable name="FCM_VERSION" value="11.6.2" />
</plugin>
<plugin name="cordova-admob-sdk" spec="^0.15.1">
        <variable name="PLAY_SERVICES_VERSION" value="11.6.2" />
</plugin>
<plugin name="cordova-plugin-admob-free" spec="^0.15.0" />
<engine name="android" spec="~6.4.0" />

project.properties
target=android-26
android.library.reference.1=CordovaLib
cordova.system.library.1=com.google.android.gms:play-services-base:11.0.4
cordova.system.library.2=com.google.android.gms:play-services-ads:11.0.4
cordova.system.library.3=com.android.support:support-v13:26.+
cordova.system.library.4=me.leolin:ShortcutBadger:1.1.17@aar
cordova.system.library.5=com.google.firebase:firebase-messaging:11.6.2
cordova.gradle.include.1=phonegap-plugin-push/duelmenerzeitung-push.gradle

duelmenerzeitung-push.gradle
import java.util.regex.Pattern

def doExtractStringFromManifest(name) {
    def manifestFile = file("AndroidManifest.xml")
    if (!manifestFile.exists()) {
      manifestFile = file("src/main/AndroidManifest.xml")
    }
    def pattern = Pattern.compile(name + "=\"(.*?)\"")
    def matcher = pattern.matcher(manifestFile.getText())
    matcher.find()
    return matcher.group(1)
}

android {
    defaultConfig {
        multiDexEnabled true
        applicationId = doExtractStringFromManifest("package")
    }
}

buildscript {
	repositories {
      jcenter()
			mavenLocal()
  }
  dependencies {
      classpath 'com.android.tools.build:gradle:+'
      classpath 'com.google.gms:google-services:3.0.0'
  }
}

// apply plugin: 'com.google.gms.google-services'
// class must be used instead of id(string) to be able to apply plugin from non-root gradle file
ext.postBuildExtras = {
    apply plugin: com.google.gms.googleservices.GoogleServicesPlugin
}

Thanks for your support!

Hi @eftas-apps
Edit your project.properties as follow:
target=android-26
android.library.reference.1=CordovaLib
cordova.system.library.1=com.google.android.gms:play-services-base:12.1.0
cordova.system.library.2=com.google.android.gms:play-services-ads:12.1.0
cordova.system.library.3=com.android.support:support-v13:26.+
cordova.system.library.4=me.leolin:ShortcutBadger:1.1.17@aar
cordova.system.library.5=com.google.firebase:firebase-messaging:12.1.0
cordova.gradle.include.1=phonegap-plugin-push/duelmenerzeitung-push.gradle

Then try to build.

Hi @tominou
seems gradle does not find the library. Do I need to add another repo?

Could not find com.google.android.gms:play-services-base:12.1.0
Could not find com.google.android.gms:play-services-ads:12.1.0
Could not find com.google.firebase:firebase-messaging:12.1.0.
Could not find com.google.firebase:firebase-core:12.1.0

Update: seems to work with 12.0.0 but gives me this error
BUILD FAILED in 18s
39 actionable tasks: 37 executed, 2 up-to-date
(node:1384) UnhandledPromiseRejectionWarning: Error: .../platforms/android/gradlew: Command failed with exit code 1 Error output:
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
/Users/cliffpereira/Documents/git/2852-DuelmenerZeitung-App/platforms/android/src/name/ratson/cordova/admob/rewardvideo/RewardVideoListener.java:13: error: RewardVideoListener is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener
class RewardVideoListener implements RewardedVideoAdListener {
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/cliffpereira/Documents/git/2852-DuelmenerZeitung-App/platforms/android/src/com/adobe/phonegap/push/PushPlugin.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error

Sorry for the wrong version. The latest is 12.0.1 indeed.
Please remove the plugin then add it back, a bug has been fixed recently.

@tominou
Thanks a lot! That did the trick.

Although this seems like a tiny hack, I'll close the issue. This might help others having the same issue.

Actually you can set the play service version in your config.xml
<plugin name="cordova-admob-sdk" spec="~0.13.1">     <variable name="PLAY_SERVICES_VERSION" value="11.6.0" /> </plugin>
But it also depends on other plugins so we can not help more about it

I did that already. See my post further up where I posted parts of my config.xml.
Unfortunately that did not help.

Yes because of the plugin using com.google.firebase:firebase-messaging you need to configure it to use the same version of play services (12.0.1), either in your config.xml or project.properties if there is not option to do it in config.xml.
However i am glad it is now working for you ^^

Use this plugin, it works for me:
https://www.npmjs.com/package/cordova-play-services-version-adapter


Updated Contact Form and resolved conflicts for issue  #223

Updated Contact Form and resolved conflicts for issue  #223

@gauravsingh1281 raised this PR to solve the conflict and deployment issues for the existing one #223 #188
@gauravsingh1281 sir, this time there are no issues and deploy preview was ready and checks were satisfied..You can merge it now,sir!!
Kindly assign me while merging and add labels too sir!!
Thank you..


TS Language server dies when using TS 3.7.2 on unsaved file in Code 1.40.0

VSCode Version: 1.40.0
OS Version: Linux Centos 8

Steps to Reproduce:

npm init
npm install typescript  (3.7.2)
code . --disable-extensions
ctrl-n
select language mode typescript
select use workspace version 3.7.2 node_modules/typescript/lib
start typing

result many error reports of The TypeScript language service died 5 times right after it got started. The service will not be restarted.

Does this issue occur when all extensions are disabled?: Yes
NOTE: This error reporoduced perfectly first time I tried it, and then it stopped giving errors when I restarted VS Code? I am having problems reproducing it now, interested to see what others find.

Please share the error text if possible. This should be visible in the dev tools console: Developer: Toggle Developer Tools or in the TypeScript section of the output window

@mjbvz I tried to wipe the directory and repeat the steps, but now Code somehow knows I want to use TS 3.7.2 and selects it automatically?
I can't find it in my user or workspace settings? Where is it stored when I manually select 3.7.2 using the VS Code interface? Sometimes it has created a new setting in my workspace settings, and sometimes not, and if I delete it then nothing changes... super weird.

Did you run Select TypeScript version again and set it back to use VS Code's version?

When I opened VS Code today in a newly created test directory as per the instructions above it had reset to VS Code's TS 3.6.3 internal version.
I have re-created the error following the same instructions I gave above. When I changed to 3.7.2 .vscode/settings.json was generated:
{
  "typescript.tsdk": "node_modules/typescript/lib"
}

I opened the developer tools as you instructed and copied the results for you here:
ts372-code-console-error.txt

After update, I get this error all the time, I don't think it's related only to this case. I did enable/disable it  but after a while it crashes again.

After using Code 1.40.0 for just ten minutes I am getting this error all over when creating new files and running QuokkaJS: new typescript file. Something is very wrong here.

Just got this in the main VS Code notification window after creating a new file, getting the original The TypeScript language service died 5 times and then going back to try and edit my original file.
Myself and @OogieBoogieInJSON seem to be getting the same Error: No Project, @mjbvz Any idea what is going on here?
<semantic> TypeScript Server Error (3.7.2) No Project. Error: No Project.     at Object.ThrowNoProject (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:133275:23)     at ProjectService.doEnsureDefaultProjectForFile (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:136545:131)     at ProjectService.ensureDefaultProjectForFile (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:136540:75)     at IOSession.Session.getFileAndProjectWorker (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140192:87)     at IOSession.Session.getFileAndProject (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140175:29)     at IOSession.Session.organizeImports (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140654:31)     at Session.handlers.ts.createMapFromTemplate._a.<computed> (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:139489:61)     at /home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140870:88     at IOSession.Session.executeWithRequestId (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140861:28)     at IOSession.Session.executeCommand (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140870:33)     at IOSession.Session.onMessage (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140893:35)     at Interface.<anonymous> (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:142208:27)     at Interface.emit (events.js:200:13)     at Interface._onLine (readline.js:314:10)     at Interface._normalWrite (readline.js:459:12)     at Socket.ondata (readline.js:170:10)     at Socket.emit (events.js:200:13)     at addChunk (_stream_readable.js:294:12)     at readableAddChunk (_stream_readable.js:275:11)     at Socket.Readable.push (_stream_readable.js:210:10)     at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)

If you can share an project, please dodo. Otherwise, please share the complete TS Server log:

Set "typescript.tsserver.log": "verbose",
Restart VS Code and reproduce the problem
In VS Code, run the TypeScript: Open TS Server log command
This should open a large log file called tsserver.log

If you can share the log, I can take a look to see if anything stands out

⚠Warning: The TypeScript log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on Github, just let me know and we can arrange something else. On our side, we only use these logs to investigate issues like this

@mjbvz I spent most of yesterday messing about with VS Code 1.40.0 regressions.
I did what you originally asked me to do and the results are https://github.com/microsoft/vscode/files/3823875/ts372-code-console-error.txt as I posted above. I have gone back to 1.39.2 now until at least the fonts are working again in 1.40.x.
There is no project to share, you literally just start typing anything and the error appears and keeps on coming. Did you try to reproduce it as my steps in the original post? I can't spend any more time debugging VS Code, I am going to stick with 1.39.2 for now, will come back to this thread if it happens again if I update in the future. Cheers.

Same issue but slightly different log from me on Windows 10.
tslog.txt
One thing I've noticed is that vs-code 1.4.0 seems to open up my terminal (powershell) in D:/code/blah, where the actual folder is D:/Code/blah, (note capitalisation of Code). I don't recall this happening in 1.39.x.
You can also see this in the logs, line 28 says "could not find file" and uses the lowercase code. The file definitely exists.

what's the status on this error?  I have it as well.  Downgraded to 1.3.9 and continue to have it.

have same error
Error: No Project.
    at Object.ThrowNoProject (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:128093:23)
    at IOSession.Session.getFileAndLanguageServiceForSyntacticOperation (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:134569:42)
    at IOSession.Session.getOutliningSpans (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:134582:31)
    at Session.handlers.ts.createMapFromTemplate._a.<computed> (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:133681:61)
    at /usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:135256:88
    at IOSession.Session.executeWithRequestId (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:135247:28)
    at IOSession.Session.executeCommand (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:135256:33)
    at IOSession.Session.onMessage (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:135279:35)
    at Interface.<anonymous> (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:136594:27)
    at Interface.emit (events.js:200:13)
    at Interface._onLine (readline.js:314:10)
    at Interface._normalWrite (readline.js:459:12)
    at Socket.ondata (readline.js:170:10)
    at Socket.emit (events.js:200:13)
    at addChunk (_stream_readable.js:294:12)
    at readableAddChunk (_stream_readable.js:275:11)
    at Socket.Readable.push (_stream_readable.js:210:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)

Same error, I Downgrade to 1.3.9.

I have tried use Typescript version 3.5.3 from project folder with vscode 1.40 but it didn't help. Had to downgrade

@David-Else I need the output from the TS Server (not just the dev tools console). Here's how the collect that

Set "typescript.tsserver.log": "verbose",
Restart VS Code and reproduce the problem
Back in VS Code, go to the TypeScript section of output panel
At the very top of this output, there should be a line that prints the path to the main server log. It look like this (note the <semantic> part) :

[Info  - 4:06:59 PM] <semantic> Log file: /Users/matb/Library/Application Support/Code - Insiders/logs/20191111T144045/exthost1/vscode.typescript-language-features/tsserver-log-F2rDlk/tsserver.log

Please look through that log file for errors or stack traces (they should be near the bottom). If you can share the log, I can also take a look to see if anything stands out

⚠Warning: The TypeScript log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on Github, just let me know and we can arrange something else. On our side, we only use these logs to investigate issues like this

Also please try using the latest VS Code insiders build to see if that fixes the issue for you. I've made a few potential fixes based on the logs already shared but can't repo this problem to verify them. I understand that this error is frustrating but we aren't seeing enough users effected to justify the risk of backporting these fixes to 1.40

@mjbvz OK, I reinstalled 1.40 and got the error instantly when opening an existing project (that was set to use TS 3.7.2) and creating a new file and switching it to TypeScript using the bottom right language selector. I followed your instructions and I think I have the info you need :) First here is the results for that error.
(see also the error on a clean project in the next section of this report)
Please let me know if this enables you to find the bug! Thanks!
Part 1 - On Existing Project
Info 0    [10:14:32.122] Starting TS Server
Info 1    [10:14:32.122] Version: 3.7.2
Info 2    [10:14:32.122] Arguments: /usr/share/code/code /home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/typescript/lib/tsserver.js --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName /tmp/vscode-typescript1000/dd2b944cf07f90d02b97/tscancellation-b2a0bd347c91a0ba7aa4.tmp* --logVerbosity verbose --logFile /home/david/.config/Code/logs/20191113T100248/exthost1/vscode.typescript-language-features/tsserver-log-5rQIyx/tsserver.log --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation
Info 3    [10:14:32.122] Platform: linux NodeVersion: 12 CaseSensitive: true
Info 4    [10:14:32.124] Binding...
Info 5    [10:14:32.131] request:
    {"seq":0,"type":"request","command":"configure","arguments":{"hostInfo":"vscode","preferences":{"providePrefixAndSuffixTextForRename":true,"allowRenameOfImportPath":true}}}
Info 6    [10:14:32.132] Host information vscode
Info 7    [10:14:32.132] response:
    {"seq":0,"type":"response","command":"configure","request_seq":0,"success":true}
Perf 8    [10:14:32.132] 0::configure: async elapsed time (in milliseconds) 1.0790
Info 9    [10:14:32.132] request:
    {"seq":1,"type":"request","command":"compilerOptionsForInferredProjects","arguments":{"options":{"module":"commonjs","target":"es2016","jsx":"preserve","allowJs":true,"allowSyntheticDefaultImports":true,"allowNonTsExtensions":true}}}
Info 10   [10:14:32.133] Scheduled: *ensureProjectForOpenFiles*
Perf 11   [10:14:32.133] 1::compilerOptionsForInferredProjects: elapsed time (in milliseconds) 0.5926
Info 12   [10:14:32.133] response:
    {"seq":0,"type":"response","command":"compilerOptionsForInferredProjects","request_seq":1,"success":true,"body":true}
Info 13   [10:14:32.133] request:
    {"seq":2,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"untitled:Untitled-1","fileContent":"le","projectRootPath":"/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB","scriptKindName":"TS"}]}}
Info 14   [10:14:32.134] Search path:
Info 15   [10:14:32.135] ConfigFilePresence:: Current Watches: :: File: tsconfig.json Currently impacted open files: RootsOfInferredProjects:  OtherOpenFiles: untitled:Untitled-1 Status: File added to open files impacted by this config file
Info 16   [10:14:32.135] For info: untitled:Untitled-1 :: Config file name: tsconfig.json
Info 17   [10:14:32.135] Opened configuration file tsconfig.json
Info 18   [10:14:32.136] FileWatcher:: Added:: WatchInfo: tsconfig.json 2000 Project: tsconfig.json WatchType: Config file
Info 19   [10:14:32.137] event:
    {"seq":0,"type":"event","event":"projectLoadingStart","body":{"projectName":"tsconfig.json","reason":"Creating possible configured project for untitled:Untitled-1 to open"}}
Info 20   [10:14:32.151] Config: tsconfig.json : {
 "rootNames": [
  "src/app.ts",
  "src/game-data-interface.ts",
  "src/entities/base-class.ts",
  "src/entities/bitmap-character.ts",
  "src/entities/bullet.ts",
  "src/entities/character.ts",
  "src/entities/factory.ts",
  "src/entities/graves.ts",
  "src/entities/hero.ts",
  "src/entities/text.ts",
  "src/entities/vector-character.ts",
  "src/entities/zombie.ts",
  "src/states/base-class.ts",
  "src/states/game-over.ts",
  "src/states/global-state.ts",
  "src/states/init.ts",
  "src/states/level-one.ts",
  "src/states/level-two.ts",
  "src/states/start-screen.ts",
  "src/utilities/assert.ts",
  "src/utilities/collision-detection.ts",
  "src/utilities/http-service.ts",
  "src/utilities/loader.ts",
  "src/utilities/new-collision-detection.ts",
  "src/utilities/random.ts",
  "src/utilities/tween.ts",
  "src/utilities/vector-example.ts",
  "src/utilities/vectors.ts",
  "test/app-test.ts"
 ],
 "options": {
  "target": 6,
  "module": 5,
  "sourceMap": true,
  "strict": true,
  "moduleResolution": 2,
  "esModuleInterop": true,
  "resolveJsonModule": true,
  "configFilePath": "tsconfig.json"
 }
}
Info 21   [10:14:32.151] DirectoryWatcher:: Added:: WatchInfo: src 1 Project: tsconfig.json WatchType: Wild card directory
Info 22   [10:14:32.153] Elapsed:: 2ms DirectoryWatcher:: Added:: WatchInfo: src 1 Project: tsconfig.json WatchType: Wild card directory
Info 23   [10:14:32.153] DirectoryWatcher:: Added:: WatchInfo: test 1 Project: tsconfig.json WatchType: Wild card directory
Info 24   [10:14:32.153] Elapsed:: 0ms DirectoryWatcher:: Added:: WatchInfo: test 1 Project: tsconfig.json WatchType: Wild card directory
Err 25    [10:14:32.165] Exception on executing command {"seq":2,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"untitled:Untitled-1","fileContent":"le","projectRootPath":"/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB","scriptKindName":"TS"}]}}:

    Cannot read property 'path' of undefined

    TypeError: Cannot read property 'path' of undefined
        at ProjectService.updateNonInferredProjectFiles (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:137385:43)
        at ProjectService.addFilesToNonInferredProject (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:137275:22)
        at ProjectService.updateRootAndOptionsOfNonInferredProject (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:137423:22)
        at ProjectService.loadConfiguredProject (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:137359:22)
        at ProjectService.createAndLoadConfiguredProject (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:137299:22)
        at ProjectService.createLoadAndUpdateConfiguredProject (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:137304:36)
        at ProjectService.assignProjectToOpenedScriptInfo (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:138127:44)
        at /home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:138358:107
        at Object.mapDefined (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:565:30)
        at ProjectService.applyChangesInOpenFiles (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:138358:48)
        at Session.handlers.ts.createMapFromTemplate._a.<computed> (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:139212:46)
        at /home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140870:88
        at IOSession.Session.executeWithRequestId (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140861:28)
        at IOSession.Session.executeCommand (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140870:33)
        at IOSession.Session.onMessage (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140893:35)
        at Interface.<anonymous> (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:142208:27)
        at Interface.emit (events.js:200:13)
        at Interface._onLine (readline.js:314:10)
        at Interface._normalWrite (readline.js:459:12)
        at Socket.ondata (readline.js:170:10)
        at Socket.emit (events.js:200:13)
        at addChunk (_stream_readable.js:294:12)
        at readableAddChunk (_stream_readable.js:275:11)
        at Socket.Readable.push (_stream_readable.js:210:10)
        at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)
Info 26   [10:14:32.165] response:
    {"seq":0,"type":"response","command":"updateOpen","request_seq":2,"success":false,"message":"Error processing request. Cannot read property 'path' of undefined\nTypeError: Cannot read property 'path' of undefined\n    at ProjectService.updateNonInferredProjectFiles (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:137385:43)\n    at ProjectService.addFilesToNonInferredProject (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:137275:22)\n    at ProjectService.updateRootAndOptionsOfNonInferredProject (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:137423:22)\n    at ProjectService.loadConfiguredProject (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:137359:22)\n    at ProjectService.createAndLoadConfiguredProject (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:137299:22)\n    at ProjectService.createLoadAndUpdateConfiguredProject (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:137304:36)\n    at ProjectService.assignProjectToOpenedScriptInfo (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:138127:44)\n    at /home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:138358:107\n    at Object.mapDefined (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:565:30)\n    at ProjectService.applyChangesInOpenFiles (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:138358:48)\n    at Session.handlers.ts.createMapFromTemplate._a.<computed> (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:139212:46)\n    at /home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140870:88\n    at IOSession.Session.executeWithRequestId (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140861:28)\n    at IOSession.Session.executeCommand (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140870:33)\n    at IOSession.Session.onMessage (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:140893:35)\n    at Interface.<anonymous> (/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB/node_modules/.pnpm/registry.npmjs.org/typescript/3.7.2/node_modules/typescript/lib/tsserver.js:142208:27)\n    at Interface.emit (events.js:200:13)\n    at Interface._onLine (readline.js:314:10)\n    at Interface._normalWrite (readline.js:459:12)\n    at Socket.ondata (readline.js:170:10)\n    at Socket.emit (events.js:200:13)\n    at addChunk (_stream_readable.js:294:12)\n    at readableAddChunk (_stream_readable.js:275:11)\n    at Socket.Readable.push (_stream_readable.js:210:10)\n    at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)"}
Info 27   [10:14:32.166] event:
    {"seq":0,"type":"event","event":"typingsInstallerPid","body":{"pid":6694}}
Info 28   [10:14:32.167] request:
    {"seq":3,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"untitled:^Untitled-1","fileContent":"","projectRootPath":"/home/david/sites/TypeScript/typescript-zombie-attack-GITHUB","scriptKindName":"TS"}]}}

Part 2 - On New Project
Next I repeated the same steps outlined at the start of this issue. As soon as I switched the TS 3.7.2 it happened, so that is involved I am sure. There were a lot of different logs generated (some empty), Here they are all in order after switching to 3.7.2 and the error:
Info 0    [10:20:52.172] Starting TS Server
Info 1    [10:20:52.173] Version: 3.7.2
Info 2    [10:20:52.173] Arguments: /usr/share/code/code /home/david/Downloads/finaltestdown/node_modules/typescript/lib/tsserver.js --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName /tmp/vscode-typescript1000/d9b8e96bf16494c50598/tscancellation-8d0448fe09b850983d86.tmp* --logVerbosity verbose --logFile /home/david/.config/Code/logs/20191113T101922/exthost1/vscode.typescript-language-features/tsserver-log-CObWP3/tsserver.log --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation
Info 3    [10:20:52.173] Platform: linux NodeVersion: 12 CaseSensitive: true
Info 4    [10:20:52.175] Binding...
Info 5    [10:20:52.181] request:
    {"seq":0,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"untitled:^Untitled-1","fileContent":"let x = 10;\nconst x = 11;\n","projectRootPath":"/home/david/Downloads/finaltestdown","scriptKindName":"TS"}]}}
Info 6    [10:20:52.183] Search path:
Info 7    [10:20:52.183] ConfigFilePresence:: Current Watches: :: File: tsconfig.json Currently impacted open files: RootsOfInferredProjects:  OtherOpenFiles: untitled:^Untitled-1 Status: File added to open files impacted by this config file
Info 8    [10:20:52.183] ConfigFilePresence:: Current Watches: :: File: jsconfig.json Currently impacted open files: RootsOfInferredProjects:  OtherOpenFiles: untitled:^Untitled-1 Status: File added to open files impacted by this config file
Info 9    [10:20:52.183] For info: untitled:^Untitled-1 :: No config files found.
Info 10   [10:20:52.185] ConfigFilePresence:: Current Watches: :: File: tsconfig.json Currently impacted open files: RootsOfInferredProjects: untitled:^Untitled-1 OtherOpenFiles:  Status: Open file was set as Inferred root
Info 11   [10:20:52.185] FileWatcher:: Added:: WatchInfo: tsconfig.json 2000 Project:  WatchType: Config file for the inferred project root
Info 12   [10:20:52.186] ConfigFilePresence:: Current Watches: Config file for the inferred project root:: File: tsconfig.json Currently impacted open files: RootsOfInferredProjects: untitled:^Untitled-1 OtherOpenFiles:  Status: Updated the callback
Info 13   [10:20:52.186] ConfigFilePresence:: Current Watches: :: File: jsconfig.json Currently impacted open files: RootsOfInferredProjects: untitled:^Untitled-1 OtherOpenFiles:  Status: Open file was set as Inferred root
Info 14   [10:20:52.186] FileWatcher:: Added:: WatchInfo: jsconfig.json 2000 Project:  WatchType: Config file for the inferred project root
Info 15   [10:20:52.186] ConfigFilePresence:: Current Watches: Config file for the inferred project root:: File: jsconfig.json Currently impacted open files: RootsOfInferredProjects: untitled:^Untitled-1 OtherOpenFiles:  Status: Updated the callback
Info 16   [10:20:52.186] Starting updateGraphWorker: Project: /dev/null/inferredProject1*
Info 17   [10:20:52.195] DirectoryWatcher:: Added:: WatchInfo: /home/david/Downloads/finaltestdown/node_modules 1 Project:  WatchType: node_modules for closed script infos in them

Info 0    [10:20:52.539] Starting TS Server
Info 1    [10:20:52.539] Version: 3.7.2
Info 2    [10:20:52.539] Arguments: /usr/share/code/code /home/david/Downloads/finaltestdown/node_modules/typescript/lib/tsserver.js --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName /tmp/vscode-typescript1000/d9b8e96bf16494c50598/tscancellation-4a72efcce5b9b5449b71.tmp* --logVerbosity verbose --logFile /home/david/.config/Code/logs/20191113T101922/exthost1/vscode.typescript-language-features/tsserver-log-bi3lUN/tsserver.log --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation
Info 3    [10:20:52.539] Platform: linux NodeVersion: 12 CaseSensitive: true
Info 4    [10:20:52.541] Binding...
Info 5    [10:20:52.549] request:
    {"seq":0,"type":"request","command":"configure","arguments":{"hostInfo":"vscode","preferences":{"providePrefixAndSuffixTextForRename":true,"allowRenameOfImportPath":true}}}
Info 6    [10:20:52.549] Host information vscode
Info 7    [10:20:52.549] response:
    {"seq":0,"type":"response","command":"configure","request_seq":0,"success":true}
Perf 8    [10:20:52.550] 0::configure: async elapsed time (in milliseconds) 1.1981
Info 9    [10:20:52.550] request:
    {"seq":1,"type":"request","command":"compilerOptionsForInferredProjects","arguments":{"options":{"module":"commonjs","target":"es2016","jsx":"preserve","allowJs":true,"allowSyntheticDefaultImports":true,"allowNonTsExtensions":true}}}
Info 10   [10:20:52.550] Scheduled: *ensureProjectForOpenFiles*
Perf 11   [10:20:52.551] 1::compilerOptionsForInferredProjects: elapsed time (in milliseconds) 0.7270
Info 12   [10:20:52.551] response:
    {"seq":0,"type":"response","command":"compilerOptionsForInferredProjects","request_seq":1,"success":true,"body":true}
Info 13   [10:20:52.551] request:
    {"seq":2,"type":"request","command":"open","arguments":{"file":"untitled:Untitled-1","fileContent":"let x = 10;\nconst x = 11;\n","projectRootPath":"/home/david/Downloads/finaltestdown","scriptKindName":"TS"}}
Info 14   [10:20:52.551] Search path:
Info 15   [10:20:52.552] ConfigFilePresence:: Current Watches: :: File: tsconfig.json Currently impacted open files: RootsOfInferredProjects:  OtherOpenFiles: untitled:Untitled-1 Status: File added to open files impacted by this config file
Info 16   [10:20:52.552] ConfigFilePresence:: Current Watches: :: File: jsconfig.json Currently impacted open files: RootsOfInferredProjects:  OtherOpenFiles: untitled:Untitled-1 Status: File added to open files impacted by this config file
Info 17   [10:20:52.552] For info: untitled:Untitled-1 :: No config files found.

Info 5    [10:20:55.103] request:
    {"seq":0,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"untitled:Untitled-1","fileContent":"let x = 10;\nconst x = 11;\nd","projectRootPath":"/home/david/Downloads/finaltestdown","scriptKindName":"TS"}]}}
Info 6    [10:20:55.104] Search path:
Info 7    [10:20:55.104] ConfigFilePresence:: Current Watches: :: File: tsconfig.json Currently impacted open files: RootsOfInferredProjects:  OtherOpenFiles: untitled:Untitled-1 Status: File added to open files impacted by this config file
Info 8    [10:20:55.104] ConfigFilePresence:: Current Watches: :: File: jsconfig.json Currently impacted open files: RootsOfInferredProjects:  OtherOpenFiles: untitled:Untitled-1 Status: File added to open files impacted by this config file
Info 9    [10:20:55.104] For info: untitled:Untitled-1 :: No config files found.
Info 10   [10:20:55.106] ConfigFilePresence:: Current Watches: :: File: tsconfig.json Currently impacted open files: RootsOfInferredProjects: untitled:Untitled-1 OtherOpenFiles:  Status: Open file was set as Inferred root
Info 11   [10:20:55.106] FileWatcher:: Added:: WatchInfo: tsconfig.json 2000 Project:  WatchType: Config file for the inferred project root
Info 12   [10:20:55.107] ConfigFilePresence:: Current Watches: Config file for the inferred project root:: File: tsconfig.json Currently impacted open files: RootsOfInferredProjects: untitled:Untitled-1 OtherOpenFiles:  Status: Updated the callback
Info 13   [10:20:55.107] ConfigFilePresence:: Current Watches: :: File: jsconfig.json Currently impacted open files: RootsOfInferredProjects: untitled:Untitled-1 OtherOpenFiles:  Status: Open file was set as Inferred root
Info 14   [10:20:55.107] FileWatcher:: Added:: WatchInfo: jsconfig.json 2000 Project:  WatchType: Config file for the inferred project root
Info 15   [10:20:55.107] ConfigFilePresence:: Current Watches: Config file for the inferred project root:: File: jsconfig.json Currently impacted open files: RootsOfInferredProjects: untitled:Untitled-1 OtherOpenFiles:  Status: Updated the callback
Info 16   [10:20:55.107] Starting updateGraphWorker: Project: /dev/null/inferredProject1*

Info 0    [10:20:55.411] Starting TS Server
Info 1    [10:20:55.411] Version: 3.7.2
Info 2    [10:20:55.411] Arguments: /usr/share/code/code /home/david/Downloads/finaltestdown/node_modules/typescript/lib/tsserver.js --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName /tmp/vscode-typescript1000/d9b8e96bf16494c50598/tscancellation-73491580b2cea792d63c.tmp* --logVerbosity verbose --logFile /home/david/.config/Code/logs/20191113T101922/exthost1/vscode.typescript-language-features/tsserver-log-w0fbrX/tsserver.log --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation
Info 3    [10:20:55.411] Platform: linux NodeVersion: 12 CaseSensitive: true
Info 4    [10:20:55.414] Binding...

Info 0    [10:20:55.889] Starting TS Server
Info 1    [10:20:55.889] Version: 3.7.2
Info 2    [10:20:55.889] Arguments: /usr/share/code/code /home/david/Downloads/finaltestdown/node_modules/typescript/lib/tsserver.js --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName /tmp/vscode-typescript1000/d9b8e96bf16494c50598/tscancellation-c4843371de3c16a664fd.tmp* --logVerbosity verbose --logFile /home/david/.config/Code/logs/20191113T101922/exthost1/vscode.typescript-language-features/tsserver-log-SrRno9/tsserver.log --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation
Info 3    [10:20:55.889] Platform: linux NodeVersion: 12 CaseSensitive: true
Info 4    [10:20:55.891] Binding...
Info 5    [10:20:55.898] request:
    {"seq":0,"type":"request","command":"configure","arguments":{"hostInfo":"vscode","preferences":{"providePrefixAndSuffixTextForRename":true,"allowRenameOfImportPath":true}}}
Info 6    [10:20:55.898] Host information vscode
Info 7    [10:20:55.899] response:
    {"seq":0,"type":"response","command":"configure","request_seq":0,"success":true}
Perf 8    [10:20:55.899] 0::configure: async elapsed time (in milliseconds) 1.1550
Info 9    [10:20:55.899] request:
    {"seq":1,"type":"request","command":"compilerOptionsForInferredProjects","arguments":{"options":{"module":"commonjs","target":"es2016","jsx":"preserve","allowJs":true,"allowSyntheticDefaultImports":true,"allowNonTsExtensions":true}}}
Info 10   [10:20:55.900] Scheduled: *ensureProjectForOpenFiles*
Perf 11   [10:20:55.900] 1::compilerOptionsForInferredProjects: elapsed time (in milliseconds) 0.6515
Info 12   [10:20:55.900] response:
    {"seq":0,"type":"response","command":"compilerOptionsForInferredProjects","request_seq":1,"success":true,"body":true}
Info 13   [10:20:55.900] request:
    {"seq":2,"type":"request","command":"geterr","arguments":{"delay":0,"files":["untitled:Untitled-1"]}}
Info 14   [10:20:55.901] event:
    {"seq":0,"type":"event","event":"requestCompleted","body":{"request_seq":2}}
Perf 15   [10:20:55.901] 2::geterr: async elapsed time (in milliseconds) 0.6548
Info 16   [10:20:55.901] event:
    {"seq":0,"type":"event","event":"typingsInstallerPid","body":{"pid":7488}}
Info 17   [10:20:56.151] Running: *ensureProjectForOpenFiles*
Info 18   [10:20:56.151] Structure before ensureProjectForOpenFiles:
Info 19   [10:20:56.151] Open files:
Info 19   [10:20:56.151] Structure after ensureProjectForOpenFiles:
Info 20   [10:20:56.151] Open files:
Info 20   [10:20:56.152] got projects updated in background, updating diagnostics for
Info 21   [10:21:9.747] request:
    {"seq":3,"type":"request","command":"geterr","arguments":{"delay":0,"files":["untitled:^Untitled-1"]}}
Info 22   [10:21:9.748] event:
    {"seq":0,"type":"event","event":"requestCompleted","body":{"request_seq":3}}
Perf 23   [10:21:9.748] 3::geterr: async elapsed time (in milliseconds) 0.4521
Info 24   [10:21:12.949] request:
    {"seq":4,"type":"request","command":"geterr","arguments":{"delay":0,"files":["untitled:^Untitled-1"]}}
Info 25   [10:21:12.950] event:
    {"seq":0,"type":"event","event":"requestCompleted","body":{"request_seq":4}}
Perf 26   [10:21:12.950] 4::geterr: async elapsed time (in milliseconds) 0.5811

@David-Else's error is now being tracked upstream by https://github.com/microsoft/TypeScript/issues/35091. We'll try to get this fixed in VS Code 1.41 which will bundle an updated version of TypeScript 3.7


ClusterIssuer incorrect DNS Resolution

Describe the bug:
I've defined a ClusterIssuer to collect ACME certs. The issuer fails due to an incorrect DNS response for the LetsEncrypt API endpoint. This occurs for all endpoints and returns my NAT'd public IP address. DNS works fine everywhere else in the cluster. This is on a self-hosted k3s cluster.

Address 1: 2606:4700:60:0:f53d:5624:85c7:3a2c
Address 2: <IP_ADDRESS>
pod "busybox" deleted

Hosts /etc/resolv.conf
nameserver <IP_ADDRESS>

My ClusterIssuer
apiVersion: cert-manager.io/v1
kind: ClusterIssuer
metadata:
  name: letsencrypt-prod
  namespace: kube-system
spec:
  acme:
    email<EMAIL_ADDRESS>    privateKeySecretRef:
      name: letsencrypt-prod
    server: https://acme-v02.api.letsencrypt.org/directory
    solvers:
    - http01:
        ingress:
          class: contour

Expected behaviour:
ClusterIssuer successfully establishes the session to an external HTTP endpoint
Steps to reproduce the bug:

Create k3s (stable) cluster behind NAT
Deploy cert-manager (by manifest or helm)
Deploy cluster issuer as above
...
no profit?

Anything else we need to know?:
Environment details::
Kernel Version:             5.4.0-66-generic
OS Image:                   Ubuntu 20.04.2 LTS
Operating System:           linux
Architecture:               amd64
Container Runtime Version:  containerd://1.4.3-k3s3
Kubelet Version:            v1.20.4+k3s1

/kind bug

Hi @alexanderturner ,
Sorry to hear you're having issues - have you also had a chance to look at cert-manager logs?
Maybe it's be worth to check what nameserver values it finds, one of the first log lines should be something like
I0314 17:58:54.447773       1 controller.go:169] cert-manager/controller/build-context "msg"="configured acme dns01 nameservers" "nameservers"=["<IP_ADDRESS>:53"]

^ that value nameservers isn't used when registering LetsEncrypt account, but could verify what it found in /etc/resolv.conf I think.

Hosts /etc/resolv.conf
nameserver <IP_ADDRESS>

Is this also on the debug pod that you spun up? I don't know too much about k3s unfortunately, but would you not have expected there to be the kube-dns address?

I was testing out cert-manager with microk8s and ran into what appears to be a variant of this same issue.
Status:
  Acme:
  Conditions:
    Last Transition Time:  2021-04-28T21:37:49Z
    Message:               Failed to verify ACME account: Get "https://acme-v02.api.letsencrypt.org/directory": x509: certificate is valid for runsafe.no, not acme-v02.api.letsencrypt.org
    Observed Generation:   1
    Reason:                ErrRegisterACMEAccount
    Status:                False
    Type:                  Ready

There is only one message in the cert-manager logs on my deployment:
pod: "cert-manager-7dd5854bb4-6t9b2_cert-manager(788cff2f-db49-45ff-ae6b-7e2526a29317)". kubelet does not have ClusterDNS IP configured and cannot create Pod using "ClusterFirst" policy. Falling back to "Default" policy.

I also tried disabling and enabling the dns addon and changed it to use my locally hosted DNS rather than the default Google DNSes, but nothing changed.

Logs from the cert-manager application after I restarted the deployment:
I0428 22:08:48.448015       1 start.go:74] cert-manager "msg"="starting controller"  "git-commit"="614438aed00e1060870b273f2238794ef69b60ab" "version"="v1.3.1"
W0428 22:08:48.448110       1 client_config.go:608] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I0428 22:08:48.449428       1 controller.go:171] cert-manager/controller/build-context "msg"="configured acme dns01 nameservers" "nameservers"=["<IP_ADDRESS>:53"]
I0428 22:08:48.449903       1 controller.go:72] cert-manager/controller "msg"="enabled controllers: [certificaterequests-approver certificaterequests-issuer-acme certificaterequests-issuer-ca certificaterequests-issuer-selfsigned certificaterequests-issuer-vault certificaterequests-issuer-venafi certificates-issuing certificates-key-manager certificates-metrics certificates-readiness certificates-request-manager certificates-revision-manager certificates-trigger challenges clusterissuers ingress-shim issuers orders]"
I0428 22:08:48.450198       1 controller.go:131] cert-manager/controller "msg"="starting leader election"
I0428 22:08:48.450392       1 metrics.go:166] cert-manager/controller/build-context/metrics "msg"="listening for connections on" "address"={"IP":"::","Port":9402,"Zone":""}
I0428 22:08:48.451033       1 leaderelection.go:243] attempting to acquire leader lease  kube-system/cert-manager-controller...
 Re-checking ACME account registration" "related_resource_kind"="Secret" "related_resource_name"="letsencrypt-cluster-issuer-key" "related_resource_namespace"="cert-manager" "resource_kind"="ClusterIssuer" "resource_name"="letsencrypt-cluster-issuer" "resource_namespace"="" "resource_version"="v1"
E0428 22:10:13.385640       1 setup.go:218] cert-manager/controller/clusterissuers "msg"="failed to verify ACME account" "error"="Get \"https://acme-v02.api.letsencrypt.org/directory\": x509: certificate is valid for runsafe.no, not acme-v02.api.letsencrypt.org" "related_resource_kind"="Secret" "related_resource_name"="letsencrypt-cluster-issuer-key" "related_resource_namespace"="cert-manager" "resource_kind"="ClusterIssuer" "resource_name"="letsencrypt-cluster-issuer" "resource_namespace"="" "resource_version"="v1"

/reopen as the issue remains in microk8s.
I noticed curl does not work, but nslookup does.

/reopen

It's not a solution but resolve my problem:
helm install
cert-manager jetstack/cert-manager
--namespace cert-manager
--create-namespace
--set 'installCRDs=true,extraArgs={--dns01-recursive-nameservers-only,--dns01-recursive-nameservers=<IP_ADDRESS>:53,<IP_ADDRESS>:53,<IP_ADDRESS>:53}'
--version v1.6.3


trigger pipeline, empty pr

triggering pr to test analyse-pull-request job on concourse

CI: No security warnings found


Allow setting numberOfLines on UILabel through NUI

Looks good thanks!

LGTM.
Any reason for naming this attribute text-line-clamp instead of number-of-lines though?

Reason for naming - to be similar with web-kit css style -webkit-line-clamp.