Fix: Remove invalid configuration from .editorconfig

This PR

[ ] removes an invalid configuration setting from .editorconfig

💁♂ For reference, see https://editorconfig-specification.readthedocs.io/en/latest/#supported-properties.

Thanks. I think we can remove the file entirely!

Thank you, @greysteil!


Allowing absolute and relative path for copy-from-controller

Right now the copy-from-controller setting for transfer_method looks for the archive in the current directory  of the controller machine from where the ansible is run, and hence the task
- name: Copy JBoss EAP
  copy:
    src: "{{ jboss_eap_artifact_name }}"
    dest: "{{ jboss_eap_artifact_dl_dest }}"
  tags:
    - jboss_eap
  when: transfer_method == 'copy-from-controller' and jboss_eap_exists.stat.exists == false

fails if we give a path like /mypath/softwares/jboss-eap-6.4.zip

@kameshsampath for now, I would recommend a symbolic think to solve this problem

@sherl0cks, that works for now - but when you put absolute path, the fact computed tries to create the same path in `/tmp'

yeap. This is driven by the jboss_eap_artifact_name param. We would need to do some fun regex parsing to make this problem go away. This is a good bounty for someone looking to contribute

👍

Also, agree that if you want to make this an enhancement over a bug that it's better label.


Fix double bundling on file change

Karma already triggers a deferredBundle() if it detects a file change to a main file. A rebuild should only happen if watchify sends an update for a file not handled by the karma watcher. Since it's all or nothing, we only have to check until we find the first file that is handled by karma. (fwiw tests pass in browserify-7.0.2 branch)

so what is the status on this? I'm running karma and it's being bundled twice

Checkout #67 if your are using Mac OS X. File a bug report with a reproducible test case otherwise.


Broaden python interface to ease automation

I gave a try to use mpbuild from octoprobe and I am very happy with the functionality of mpbuild!
In this PR are the changes I did:

Return the filename of the firmware after a build. Somehow hacky FIRMWARE_FILENAMES-dictionary.
Removed import typer  from find_boards.py: Rationale: I do not want generic methods to call type Exceptons.

This PR is just the current state of my work - feel free to reject it:-)

@mattytrentini Please close/reject this PR. I has been superseeded.


Fix KeyError caused by wrong key type. #450

Fix KeyError caused by wrong key type. #450

thanks for the fix, wouldn't this just surprises the issue not fix it?
mind adding a unit test and your name to the credits https://github.com/pinterest/pymemcache#credits


🍒 Cherry pick PR #18395 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/18395 to staging 🍒

🚀 Cherry-picked to staging by https://github.com/OSBotify in version: 1.3.9-20 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Fixes #3722 Use entityName type from basic.json for entity names

Describe your changes :

See #3722

Type of change :

[x] Improvement

Checklist:

[x] I have read the CONTRIBUTING document.
[x ] I have commented on my code, particularly in hard-to-understand areas.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

@pmbrull can you check if its affecting the python bindings as well

@pmbrull can you check if its affecting the python bindings as well

Yep, let us work on fixing the tests and we can see what breaks. Thanks

py-checkstyle is fixed in #3724

Hey @sureshms - so checked out this branch and tried ingesting sample data & sample usage
It fails giving us UnHashable TypeError on Python.
It expects FullyQualifiedEntityName to be a string - it gets the same value as Pydantic Model / Object - which causes an error.
Hardcoding the methods and typecasting those with str might be one way and adding __root__ to get str.
cc: @pmbrull @harshach

@pmbrull and @ayush-shah, is this okay to commit and Python code can handle this?

Yep we're already handling changes related to this PR and we should be good to go. e.g., https://github.com/open-metadata/OpenMetadata/pull/3748. Thanks!


Identical sequences not clustering unless -c == 1 or --min-seq-id == 1 or < 0.9

Expected Behavior
My colleagues and I have noticed an unexpected behavior with linclust (using the easy-linclust pipeline in particular), it appears to not be clustering identical sequences unless -c == 1 or --min-seq-id == 1 or < 0.9. We're not sure if we're misunderstanding the functionality of the linclust options or if there is a bug. Here are the FASTA contents for the sequences I have been testing with (note they are all identical):
>Dupe
MTEQEKTSAVVEETREAVDTTSQPVATEKKSKNNTALILSAVAIAIALAAGVGLYGWGKQ
QAVNQTATSDALANQLTALQKAQESQKAELEGIIKQQAAQLKQANRQQETLAKQLDEVQQ
KVATISGSDAKTWLLAQADFLVKLAGRKLWSDQDVTTAAALLKSADASLADMNDPSLITV
RRAITDDIASLSAVSQVDYDGIILKLAAANQLSNQVDNLRLADNDSDGSPMDSDGEELSSSIS
EWRINLQKSWQNFMDNFITIRRRDDTAVPLLAPNQDIYLRENIRSRLLVAAQAVPRHQEE
TYRQALENVSTWVRAYYDTDDATTKAFLDEVDQLSQQNISMDLPETLQSQAMLEKLMQTR
VRNLLAQPAAGTTEAKPAPAPAPAPAPAPAPAPAPAPAPQGDTPAAAPQGE
>Dupe2
MTEQEKTSAVVEETREAVDTTSQPVATEKKSKNNTALILSAVAIAIALAAGVGLYGWGKQ
QAVNQTATSDALANQLTALQKAQESQKAELEGIIKQQAAQLKQANRQQETLAKQLDEVQQ
KVATISGSDAKTWLLAQADFLVKLAGRKLWSDQDVTTAAALLKSADASLADMNDPSLITV
RRAITDDIASLSAVSQVDYDGIILKLAAANQLSNQVDNLRLADNDSDGSPMDSDGEELSSSIS
EWRINLQKSWQNFMDNFITIRRRDDTAVPLLAPNQDIYLRENIRSRLLVAAQAVPRHQEE
TYRQALENVSTWVRAYYDTDDATTKAFLDEVDQLSQQNISMDLPETLQSQAMLEKLMQTR
VRNLLAQPAAGTTEAKPAPAPAPAPAPAPAPAPAPAPAPQGDTPAAAPQGE
>Dupe3
MTEQEKTSAVVEETREAVDTTSQPVATEKKSKNNTALILSAVAIAIALAAGVGLYGWGKQ
QAVNQTATSDALANQLTALQKAQESQKAELEGIIKQQAAQLKQANRQQETLAKQLDEVQQ
KVATISGSDAKTWLLAQADFLVKLAGRKLWSDQDVTTAAALLKSADASLADMNDPSLITV
RRAITDDIASLSAVSQVDYDGIILKLAAANQLSNQVDNLRLADNDSDGSPMDSDGEELSSSIS
EWRINLQKSWQNFMDNFITIRRRDDTAVPLLAPNQDIYLRENIRSRLLVAAQAVPRHQEE
TYRQALENVSTWVRAYYDTDDATTKAFLDEVDQLSQQNISMDLPETLQSQAMLEKLMQTR
VRNLLAQPAAGTTEAKPAPAPAPAPAPAPAPAPAPAPAPQGDTPAAAPQGE

Current Behavior
Below are a set of commands we've tested. Note that defaults for alignment-mode and cov-modes were used in the example commands, however we have tried the other modes and the same results are exhibited. The -a flag is also being used since we noticed it was recommended in a previous issues post. Finally, we have been checking the output _cluster.tsv file to verify the clusters.
Commands 1 - 5 vary the --min-seq-id parameter.
Commands 6 - 10 vary the -c parameter.
Cmd1 (-c 0.95 --min-seq-id 0.7)
mmseqs easy-linclust duplicate_cluster_test.faa dupe_test tmp --add-self-matches -c 0.95 --min-seq-id 0.9 --max-iterations 1000 -a
Cmd2 (-c 0.95 --min-seq-id 0.8)
mmseqs easy-linclust duplicate_cluster_test.faa dupe_test tmp --add-self-matches -c 0.95 --min-seq-id 0.8 --max-iterations 1000 -a
Cmd3 (-c 0.95 --min-seq-id 0.9)
mmseqs easy-linclust duplicate_cluster_test.faa dupe_test tmp --add-self-matches -c 0.95 --min-seq-id 0.9 --max-iterations 1000 -a
Cmd4 (-c 0.95 --min-seq-id 0.99)
mmseqs easy-linclust duplicate_cluster_test.faa dupe_test tmp --add-self-matches -c 0.95 --min-seq-id 0.99 --max-iterations 1000 -a
Cmd5 (-c 0.95 --min-seq-id 1)
mmseqs easy-linclust duplicate_cluster_test.faa dupe_test tmp --add-self-matches -c 0.95 --min-seq-id 1 --max-iterations 1000 -a
Cmd6 (-c 0.5 --min-seq-id 0.9)
mmseqs easy-linclust duplicate_cluster_test.faa dupe_test tmp --add-self-matches -c 0.5 --min-seq-id 0.9 --max-iterations 1000 -a
Cmd7 (-c 0.9 --min-seq-id 0.9)
mmseqs easy-linclust duplicate_cluster_test.faa dupe_test tmp --add-self-matches -c 0.9 --min-seq-id 0.9 --max-iterations 1000 -a
Cmd8 (-c 0.99 --min-seq-id 0.9)
mmseqs easy-linclust duplicate_cluster_test.faa dupe_test tmp --add-self-matches -c 0.99 --min-seq-id 0.9 --max-iterations 1000 -a
Cmd9 (-c 1 --min-seq-id 0.9)
mmseqs easy-linclust duplicate_cluster_test.faa dupe_test tmp --add-self-matches -c 1 --min-seq-id 0.9 --max-iterations 1000 -a
MMseqs2 _cluster.tsv output
Cmd1 cluster.tsv output: (-c 0.95 --min-seq-id 0.7)
Dupe | Dupe
Dupe | Dupe2
Dupe | Dupe3
Cmd2 cluster.tsv output: (-c 0.95 --min-seq-id 0.8)
Dupe | Dupe
Dupe | Dupe2
Dupe | Dupe3
Cmd3 cluster.tsv output: (-c 0.95 --min-seq-id 0.9) (Issue)
Dupe | Dupe
Dupe2 | Dupe2
Dupe3 | Dupe3
Cmd4 cluster.tsv output: (-c 0.95 --min-seq-id 0.99) (Issue)
Dupe | Dupe
Dupe2 | Dupe2
Dupe3 | Dupe3
Cmd 5 cluster.tsv output: (-c 0.95 --min-seq-id 1)
Dupe | Dupe
Dupe | Dupe2
Dupe | Dupe3
Cmd 6 cluster.tsv output: (-c 0.5 --min-seq-id 0.9) (Issue)
Dupe | Dupe
Dupe2 | Dupe2
Dupe3 | Dupe3
Cmd7 cluster.tsv output: (-c 0.9 --min-seq-id 0.9) (Issue)
Dupe | Dupe
Dupe2 | Dupe2
Dupe3 | Dupe3
Cmd8 cluster.tsv output: (-c 0.99 --min-seq-id 0.9) (Issue)
Dupe | Dupe
Dupe2 | Dupe2
Dupe3 | Dupe3
Cmd9 cluster.tsv output: (-c 1 --min-seq-id 0.9)
Dupe | Dupe
Dupe | Dupe2
Dupe | Dupe3
Context
In the above commands only commands 1,2,5,9 yield the expected result. If I am understanding the parameters correctly shouldn't all the above commands yield the same result when 100% identical sequences are input? We have attempted playing with all of the different modes and parameters (they did yield different albeit incorrect results) but unless -c == 1 or --min-seq-id == 1 or < 0.9 then the identical sequences are not clustering.
Your Environment
mmseqs easy-linclust was used for the tests above
MMseqs2 Version: 8.fac81

Thank you for reporting this bug and this detailed analysis. This really helps me a lot.
I understand the issues now and I think I can fix the behavior the next days.
The issues occurs because we do not pick the best diagonal at the 'kmermatcher'. Since it is not the best diagonal the sequence will be filtered before the smith waterman alignment stage. The filtering criteria are less strict with decreasing sequence identity criteria, so there the sequence will be aligned and clustered.

I have pushed a fix for the issue https://github.com/soedinglab/MMseqs2/commit/4d62a0638e97deaef14402181c1091d7f66c1bef

Excellent, I will update and give it a shot.
Thanks so much for your response and extremely fast update.
Your program/code is really remarkable stuff, thank you so much for sharing it with the open source community.

@bfssi-nicholas-petronella the code just improves through issues like yours. thanks a lot for your help and your encouraging words :)

Is this issue the same as the issue #88 ?

@ggautreau it was a different issue. Do you still encounter issues?

No, it's seem to be ok for me (using the release 8-fac81 ) even without using the option --kmer-per-seq 80 and --max-seqs 300 (that you advised me to use one year ago)

Hi Martin, it looks like this fix has not been pushed to bioconda. When I install from source all is good and the bug is fixed. However, when I use the conda install the bug remains.
Would it be possible to push the latest version of Mmseqs2 to bioconda?
Thanks

We still have a bit of work to do until the next release. We are targeting next week for the next release, which will then also have a new bioconda release.
Until then please either use the statically compiled version or build MMseqs2 yourself.


Cfg changes so each feature works independently

Consumers of Ursa typically want only select features and up until now, these features were all tightly coupled.
This PR fixes the dependencies without changing the working code. This makes adjustments to the compile-time settings so each feature will work without any dependencies on others. For example, a consumer may only want ecdsa_secp256k1 and now can do so. Before, the compiler would barf if this feature was the only one enabled.

@mikelodder7 I just cloned this repo and tried a few things just to sanity check. I ran this:
$ cd libursa && cargo build --features="ecdsa_secp256k1"

I had to do that in libursa because cargo doesn't allow the specification of features on the command line in the root of a workspace? Seems weird but...OK? Anyway, I immediately got some warnings and the build failed. Here's the warnings:
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /home/user/Projects/ursa/libursa/Cargo.toml
workspace: /home/user/Projects/ursa/Cargo.toml

And the build failed with:
   Compiling ursa v0.3.1 (/home/user/Projects/ursa/libursa)
error[E0428]: the name `ecdsa_secp256k1` is defined multiple times
   --> libursa/src/signatures/secp256k1.rs:220:1
    |
113 | mod ecdsa_secp256k1 {
    | ------------------- previous definition of the module `ecdsa_secp256k1` here
...
220 | mod ecdsa_secp256k1 {
    | ^^^^^^^^^^^^^^^^^^^ `ecdsa_secp256k1` redefined here
    |
    = note: `ecdsa_secp256k1` must be defined only once in the type namespace of this module

error: aborting due to previous error

For more information about this error, try `rustc --explain E0428`.
error: could not compile `ursa`.

It looks like this isn't a clean patch just yet. I'll let you take another crack at it. Just for the record:
$ rustup show
Default host: x86_64-unknown-linux-gnu
rustup home:  /home/user/.rustup

nightly-x86_64-unknown-linux-gnu (default)
rustc 1.42.0-nightly (3a3f4a7cb 2019-12-28)

@dhuseby try using cargo build --no-default-features --features=ecdsa_secp256k1. The problem is you can't tell it to compile both ecdsa_secp256k1 and ecdsa_secp256k1_asm. That should work. However, I'll add compiler flags so you can't do both.

Pushed update to throw a compiler user friendly message now. Make sure you turn off default features


storybook-preview-iframe does not appear in Firefox Mobile v8.3 (5826)

The storybook-preview-iframe simply does not appear when Storybook is viewed in Firefox mobile v8.3 (5826). I have to select 'Request Desktop Site' from Firefox setting in order for Storybook to work correctly.

Can you attach a screenshot?

Definitely looks like a bug. If you'd like to look into it and submit a PR, you are more than welcome to. I personally don't have an iPad but I'm sure someone around here does.


Support asynchronously incrementally sync files to disk while they are being written

The idea is borrowed from  RocksDB bytes_per_sync. It allows asynchronously incrementally sync files to disk while they are being written.
It smoothes out write I/Os over time and reduce fdatasync latency spike as we saw in https://github.com/tikv/raft-engine/pull/346#issue-2059165690 .
Note: The feature proposed here is different from the deprecated bytes_per_sync feature which sync file synchronously.

A similar issue: https://github.com/GreptimeTeam/greptimedb/issues/3085
Currently we use periodical fsync to alleviate the problem.

THx for your advices. This problems might not be similar to yours. And we've met this problem on Cloud Env when rewriting and fixed it in #347, by introducing bytes_per_sync to limit the maximum flushing bytes. /cc @v0y4g3r
FYI, u can check whether there exists similar syncing problems when rewriting raft logs. And if does, u can check the latest version as your choice.

THx for your advices. This problems might not be similar to yours. And we've met this problem on Cloud Env when rewriting and fixed it in #347, by introducing bytes_per_sync to limit the maximum flushing bytes. /cc @v0y4g3r
FYI, u can check whether there exists similar syncing problems when rewriting raft logs. And if does, u can check the latest version as your choice.

Do you any plan to release a new version?

/cc @overvenus @tabokie PTAL, thx.
We'll do it recently. Before that, u can update your dependency to raft-engine with the latest commit-id.


add coverage

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: wugeshui:x: liwenjian-sensetimeYou have signed the CLA already but the status is still pending? Let us recheck it.


Component is re-rendered before leaving the page

Hi all :wave:
I'd love to use this library in my project but I'm having an issue with route changes. When I leave a page that is re-rendered. This throws an error in some cases because the route has changed in the meantime and the component can't find some route parameters.
Let me give you an example.

I'm in the index /
I navigate to /category?id=6 which renders category.js page
I navigate back to /
the URL changes from /category?id=6 to /
before leaving category.js the component is re-rendered. Since the category.js page relies on the id parameter an error is thrown

Am I doing something wrong here?

I haven't used this library with a page that uses route parameters. Can you put together a small app that reproduces the error you're seeing?

I can't reproduce it on a Next.js vanilla project. Could it be related to <ApolloProvider>? I pushed the changes with the problem on this branch.

That's certainly possible. I'm not familiar with Apollo. If you can put together a small self-contained example (Codesandbox would be great), I'd be happy to look into this more. Until then, I'm going to close this out for now. It's possible that this will be fixed in an upcoming v1.0.0 release as well.

I have the same problem, I'm using Apollo and a url with query params, every time I go back from a URL with query params, the animation doesn't work, it first load the page and then it does the animation, like re rendering the component first and then using the animation. But this only happens when you have URL params, which is weird. Any idea how to force the animation?

Same issue as well and also using Apollo.

This happened with simple example in the examples folder

@NamPNQ could you describe the exact error you saw and how to reproduce it? Which example was this with?

@nwalters512  You can test with #47

Anyone found a temporary fix or an alternative with next.js and apollo?

@h0gar you can try my fix in #47

@NamPNQ React.memo (I have func components) doesn't change anything in my case.. :/

@NamPNQ React.memo (I have func components) doesn't change anything in my case.. :/

I mean change the file src/PageTransition.js, not React.memo

Also happens with framer-motion. The problem seems to be that next router already changes the route and query parameters before the exit animation finished.
So the old page gets the query parameters of the new route it is transitioning to.
Example:
If you use something like this to get the query parameters:
  const router = useRouter()
  const { id } = router.query

the id parameter first is the id parameter passed to this page. But when you click on a link, next already changed the route and query parameters to the new page. So the id parameter becomes undefined, if the new route it is transitioning to does not have an id parameter. The old page which is fading out is now re-rendered with the new id parameter of the new route.
Somehow next router route and query changes have to be delayed until the exit animation is done.


Currency is always USD for all accounts

Hi, great work, I downloaded the API ran and all my accounts show the currency as USD, I know I have most in CAD. Can you please check.

Mint displays your transactions in the same amount as the bank account's/card's website shows but Mint has no way of identifying what currency it is and thus Mint always displays USD by default.
I suggest filing a feature request ticket to Mint.


Running the game logic on GPU

Is there a way to run the game logic on GPUs? Currently the games all run on the CPU because of the C++ bindings as far as I know. This results in a lot of data movement from GPU memory to CPU memory and back for an algorithm that trains better on a GPU.
I'm wondering if it would be possible to implement a game in such a way that all the data can be kept on the GPU.
I'm thinking maybe JAX might be a good library to use for that, but I'm not sure if it's designed for these use cases where there would be a lot of control flows.
Just mentioning @mattjj here, because you never know, he might know ...
If we wrote all the ifs as jax where clauses, could we even vmap it?
And would that be efficient for a GPU?

I'm afraid that won't be easy to do, is there something specific you have in mind, or just the ability to do state.apply_action() in parallel? (or something like that)

If you prebuild the game trees in advance, and then run algorithms on those trees on the GPU that can be done efficiently. For example, there is a GPU version of CFR that one student made but we didn't have time to integrate it into OpenSpiel. Would this be something of interest?

The main problem is that I have to have my exproration steps running on the CPU due to the C++ implementation. Don't get me wrong, I'm grateful for the open spiel environment, I'm just wondering if it would make sense to implement some games on a GPU to scale them up. I understand that the notion is a bit weird, but given that our facebook and google friends were able to do it, maybe @mattjj and the jax team can do better ;)


Import Kubernetes into Credhub

In order to get k8s credentials into Credhub, we want to replace the current manifest generation using spruce with bosh operations files.
Acceptance Criteria

[ ] Development Kubernetes manifest should be identical to existing manifest, but with variables pulled from Credhub.
[ ] Staging Kubernetes manifest should be identical to existing manifest, but with variables pulled from Credhub.
[ ] Production Kubernetes manifest should be identical to existing manifest, but with variables pulled from Credhub.

Reopening because this card is actually needed to track the progress.

This is currently blocked by https://github.com/cloudfoundry/bosh-deployment-resource/pull/65.

Moving into the backlog as I'm working on #1111 first. Still blocked, but not being actively worked.


Dropped node@4 and node@5 support

Coverage decreased (-0.02%) to 98.171% when pulling cbde177dc3cffbe46df875953d7ece06d2c97cbe on dropped-old-node-support into 378e55689eea82ca3f5c4542196685d9083859dc on master.

Coverage decreased (-0.02%) to 98.171% when pulling cbde177dc3cffbe46df875953d7ece06d2c97cbe on dropped-old-node-support into 378e55689eea82ca3f5c4542196685d9083859dc on master.

Coverage decreased (-0.02%) to 98.171% when pulling cbde177dc3cffbe46df875953d7ece06d2c97cbe on dropped-old-node-support into 378e55689eea82ca3f5c4542196685d9083859dc on master.


Reshape

Partially addresses the second half of #7.
Right now, only reshapes that can be implemented by independent reshapes on the keys and/or values are allowed.

@jwittenbach this looks close! I like the strategy of implementing the simple case initially. I left a bunch of minor comments, and it'd be great to merge in the latest changes from master, which will run the tests on Python 3.4 as well, so we can identify any potential issues there.

All of the comments make sense -- changes made!

Awesome, great job tracking down those glitches. LGTM! Merging in.


Fix Props.Copy implementation

The usage of default parameters in Props.Copy does not quite work. The previous implementation basically did _foo = foo ?? this._foo which obviously won't work if you want to set the value to null (as in the case of RouterConfig - although perhaps the choice to use null as an indicator of a non-router Actor could be reconsidered).
This PR reimplements the Copy method to make a full copy first, then apply a mutator Action in order to change the desired property to it's new value.

Good catch :-)


Cleanup: Just throw, rather than return Promise.reject

Promise.reject should not generally be used, and almost never returned. This PR replaces return Promise.reject(...) with throw ... which is semantically equivalent, but takes less code, and more accurately matches intent.

Just for reference, pointing out that there is one case where this would change behavior: if the argument to Promise.reject() was already a Promise itself (which would end up with a promise wrapped in another one).
In many cases in the PR that's evidently not possible, and TS typing seems to be protecting us in the rest. Plus, if we were actually doing that, it was probably a bug anyway.

you can pass anything you want to Promise.reject, and you can throw anything you want, but those are bad practices, and we have rules against throwing anything but errors. there really isn't anything special about the object being passed to either being a promise, other than its very confusing.


Introduce parAll

Fixes #119

Now the question is, should we abstract away the common bits in forkAll
as.foldLeft(point[E, Fiber[E, mutable.Builder[A, M[A]]]](Fiber.point(cbf(as)))) { (asFiberIO, aIO) =>
asFiberIO.par(aIO.fork).map {
case (asFiber, aFiber) => asFiber.zipWith(aFiber)(_ += _)
}
}
.map(_.map(_.result))
and parTraverse
as.foldLeft(point[E, mutable.Builder[B, M[B]]](cbf(as))) { (bsIO, a) =>
bsIO.par(fn(a)).map {
case (bs, b) => bs += b
}
}
.map(_.result)
?

@jdegoes but we're using IO.point not for side-effecty things, but for normal, referentially transparent, cbf(as)
just as the previous code did
or am I missing something?

ok, parAll it is

@sideeffffect cbf(as) has an effect (it allocates new mutable memory). It's possible the previous code was wrong and should have used IO.sync.

@jdegoes ok, IO.sync
thanks for the explanation

Although, I must admit that I don't feel that allocating a memory (mutable or not) is considered a side effect and that IO.point wouldn't break anything. The reason is that cbf(as) always returns "the same" object.
But I'm not 100 % sure, and having IO.sync can't do any harm.

@sideeffffect Yes, it's a side effect. You can verify it's not referentially transparent because if you feed the reference to 2 IO functions, it has a different effect than replicating the effect (cbf(as)) twice and feeding each one separately to each of the two IO functions.

Btw I'm also introducing sync for Fiber, so that it's
IO.sync[E, Fiber[E, mutable.Builder[A, M[A]]]](Fiber.sync(cbf(as)))

sync for Fiber is not necessary because you are putting the effectfully-built builder inside IO.
Honestly, code like this which uses mutable builder is not great. It's not trivial to mix mutable builders with FP-style safely. But unless Scala has an immutable builder, there's not much you can do.

@jdegoes would it be that horrible to just... make a parAll for List and Vector? I mean realistically, how many other data structures will you be folding on list this?

Fiber.sync removed

tests added :)

@sideeffffect Looks good! Thank you for your contribution! ❤


It should check if permissions are granted before using them

It does not check if HRM or activity permissions are granted.
Would be great to see what is a good way to handle permissions not being granted and fail gracefully

This is done now.


Creating PreIngestionLambda Interface

Summary
Following this design doc (Metadata Service 2.0), creating the interface for PreIngestionLambda routing.
Testing Done
./gradlew build
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[x] Links to related issues (if applicable)
[x] Docs related to the changes have been added/updated (if applicable)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.16%. Comparing base (be56ee0) to head (5a9b387).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #398   +/-   ##
=========================================
  Coverage     68.16%   68.16%
  Complexity     1440     1440
=========================================
  Files           136      136
  Lines          5614     5614
  Branches        615      615
=========================================
  Hits           3827     3827
  Misses         1534     1534
  Partials        253      253

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Hope to support SQL Server 2000

TDS Version option verTDS71, How can i use it.

Driver does not work with SQL Server 2000 or older.

I don't think any driver author wants to support that old of TDS. If you or someone wanted to add support and showed it was not complex to do so, I think we would merge it in, so long as we could figure out a testing method.


Custom editor input labels debt

The CustomEditorInput should appear like any other file editor or notebook editor because it is mainly a result of opening a file resource.
To be able to reuse more code I now added a new type AbstractResourceEditorInput that is used by all files, notebooks and untitled editors for consistent label handling.
Given the inheritance of CustomEditoInput, I was not able to adopt this type for it unfortunately.
This issue is to document this debt and report some issues:

ideally CustomEditorInput could extend AbstractResourceEditorInput somehow

there is a lot of code duplication for labels that could be reused (getName, getDescription, getTitle)

if not, there are issues in CustomEditorInput that are not addressed

the ILabelService is properly used, but the labels are not updating when the formatters change (here is how the abstract resource editor input does it)
the label is properly decorated for readonly, but I am not sure if this state can change dynamically or not (here is how the abstract resource editor input does it by listening on provider changes)

I don't think I can easily change the inheritance structure here. It does seems like the other points have been addressed  however


Create adapative sound

Summary

Changes

Closes:
Task list

[ ] For workflow changes, I have verified the Actions workflows function as expected.
[ ] For content changes, I have reviewed the style guide.

👋 We require an issue to be attached to all pull requests and a description of what it is you're changing and why. I'm going to close this out. If you'd like to reopen it, please provide a link to the issue being resolved and a description of your changes.


Tests for all-your-base look wrong

I just got the new all-your-base exercise for the first time. And as I was looking through the unit tests to see the spec I'm implementing against, I noticed that an empty list [] is considered to be invalid input, rather than 0. That's a debatable issue (and I would disagree), but that's a place where opinion can validly differ -- if you have a string with no digits in it at all, it's fair enough to consider that to be "not a number" rather than representing 0, so a list with no digits could also represent 0. It will make my code slightly less elegant than it could have been, but fair enough.
But then I saw the next test, where the input is [0] and the output is None. That one's not debatable; it's just wrong. An input of a single 0 digit should produce the number 0 in the output base, and should not be an error.
And the next two tests after that, where the input is either multiple zeroes ([0; 0; 0]) or contains a leading zero ([0; 6; 0]), also expect an output of None. And here also, I believe the tests are wrong, and the correct answer should be 0, and "60" in whatever the input base is (in that particular test it's 7, so 60 is 42 in decimal).
Looking at https://github.com/exercism/x-common/blob/master/all-your-base.json for a bit, I figured out that the tests were automatically converted to F#, and the null results in that JSON file were turned into None. But the comment at the top of that JSON file says that it's those are tests where the right behavior could vary by language, and it's up to each language track to determine what the right behavior should be. I.e., they say that the correct representation of zero might be an empty list, or a list with a single zero, or a list with multiple zeroes... and that's why all those tests have a defined result of null. But at least one of them should be possible; as it stands, the F# version of the all-your-base exercise does not allow zero to be represented at all.
Which, in a test that was named after Zero Wing, just seems... well, wrong somehow.
The tests should be fixed... for great justice.

Good point. What do you propose to be the correct handling of zeroes and such?

How are you gentlemen !!
I set up you the PR.

Couldn't resist. :-) But seriously, what I did in the PR is what I'd suggest: empty lists are considered errors (I changed my mind a bit after thinking about it, and decided that it should be like parsing a string. No digits in the string? Then you don't get a number at all. No digits in the list? Likewise, no number.) For any other leading zeroes, though, it should parse just like a string should: leading zeroes are ignored. (And leading zeroes should certainly NOT mean "parse this as octal"; that is C's second-biggest blunder. The biggest, of course, is getting involved in a land war in... no, wait, I mean nulls.)

Seems like very sensible fixes. I've commented on your PR.


Skip flaky stream tests

Description:
As suggested by @hunterjm

Builds keep failing so I will go ahead and merge this.


Database service structure

Add strategy for controller and maintenance data from database

@JuanDavidRod  i need that you create a project in vercel an create your database postgres for use in this project if we use a vercel/postgres
i am implemente it there

and share me at message direct your DATABASE_URL for create entities and dummy data

@mxtrar23 bd is created.


Update mqtt_homeassistant.go

Temperature related UnitOfMeasurement i.e. degree character seems to be coded as (U+00BA). I think correct one is (U+00B0). Using (U+00BA) as s degree character looked weird in Home Assistant:

..and it was not possible to move the sensor to Homekit without customizing the entity.

TIL those are actually different symbols :D thanks

No problem :)


Add tumblelog; both the Perl and Python version

If the name and repo are the same—does it make more sense to have one entry for these and add two languages under support?

If the name and repo are the same—does it make more sense to have one entry for these and add two languages under support?

Good question. I have given this some thought and was afraid that listing two languages would give the impression that the project requires both in order to run.

Ah, fair enough—thanks!

Thank you very much for the merge.


DOC: Apify integration missing

Issue with current documentation:
The Apify integration has been delete by @hwchase17 in commit aa0e69bc98fa9c77b01e5104f12b2b779f64fd33 and thus this documentation is not valid anymore:
https://python.langchain.com/docs/integrations/tools/apify
Idea or request for content:
It would be highly beneficial to have information on a suitable replacement for the Apify integration.

While it does indeed look like the docs are outdated, it appears the Apify integration has just been moved into langchain.document_loaders: #2215

Fixed in https://github.com/langchain-ai/langchain/pull/10067


Switch from Travis-CI to GitHub Actions

With the recent changes, we have to switch our macOS builds from travis-ci to somewhere else. GitHub Actions seems like a good choice.
Here are instructions on how everything up for GitHub Actions, from building to PyPI uploading: https://docs.github.com/en/free-pro-team@latest/actions/guides/building-and-testing-python

Closed by #505 and #506


Atom Crashes Every Time when I try to load a project folder.

Prerequisites

[ ] Can you reproduce the problem in safe mode?

Yes.

[ ] Are you running the latest version of Atom?

Yes. In fact, I uninstalled it and installed the latest download from the websit.

[ ] Did you check the debugging guide?

No.

[ ] Did you check the FAQs on Discuss?

No.

[ ] Are you reporting to the correct repository?

Yes.

[ ] Did you perform a cursory search to see if your bug or enhancement is already reported?

Yes. Many people are having trouble in Windows 10 Anniversary Edition and the reports are all summarily closed.
Description
[Description of the bug or feature]
I upgraded Atom based on the alert in the bottom left, and the problem started happening. Then I uninstalled it using the Windows add/remove programs and reinstalled the latest version from atom.io
https://atom.io/
The file version is <IP_ADDRESS>
Steps to Reproduce

Launch Atom
2.Select File -> add project folder

Expected behavior: [What you expected to happen]
Project folder gets loaded
Actual behavior: [What actually happened]
Boom!

<IP_ADDRESS>
Windows 10 version 1607 / 14393.51
You can get this information from executing atom --version and apm --version at the command line. Also, please include the OS and what version of the OS you're running.

I cannot reproduce this using Atom 1.11.0-dev-d47fd28, Windows Anniversary update.

I am able to reproduce this with Atom v1.10.2 and Windows 10 x64.
This is the dump from operation_log.txt
[2304:7260:0914/124030:VERBOSE1:crash_service.cc(394)] dump for pid = 5916 is C:\Users\nicol\AppData\Local\Temp\Atom Crashes\adc6964d-443f-466c-9ab1-f9c1692de148.dmp [2304:17696:0914/124030:VERBOSE1:crash_service.cc(442)] trying to send report for pid = 5916 [2304:15108:0914/124030:VERBOSE1:crash_service.cc(331)] client end. pid = 5916 [2304:7260:0914/124032:VERBOSE1:crash_service.cc(323)] client start. pid = 17124 [15296:19216:0914/124032:VERBOSE1:crash_service_main.cc(68)] Session start. cmdline is [--reporter-url=https://crashreporter.atom.io --application-name=Atom --v=1] [15296:19216:0914/124032:VERBOSE1:crash_service.cc(142)] window handle is 0098117C [15296:19216:0914/124032:VERBOSE1:crash_service.cc(290)] pipe name is \\.\pipe\Atom Crash Service dumps at C:\Users\nicol\AppData\Local\Temp\Atom Crashes [15296:19216:0914/124032:VERBOSE1:crash_service.cc(294)] checkpoint is C:\Users\nicol\AppData\Local\Temp\Atom Crashes\crash_checkpoint.txt server is https://crashreporter.atom.io maximum 128 reports/day reporter is electron-crash-service [15296:19216:0914/124032:ERROR:crash_service.cc(301)] could not start dumper
And I've uploaded my .dmp file.
adc6964d-443f-466c-9ab1-f9c1692de148.zip
This happens when I try to add a repo to Atom using "Add Project Folder" - but with certain folders only. For these certain folders, I cannot add them to Atom - it crashes every single time. For other folders, I can add them with no issues at all. I cannot find anything in common between the folders that cause Atom to crash when adding.

Thanks! But it's too late for me. I already switched to Visual Studio Code.
On Wed, Sep 14, 2016 at 1:08 PM, Nicole Furlan<EMAIL_ADDRESS>wrote:

I am able to reproduce this with Atom v1.10.2 and Windows 10 x64.
This is the dump from operation_log.txt
[2304:7260:0914/124030:VERBOSE1:crash_service.cc(394)] dump for pid =
5916 is C:\Users\nicol\AppData\Local\Temp\Atom Crashes\adc6964d-443f-466c-9ab1-f9c1692de148.dmp
[2304:17696:0914/124030:VERBOSE1:crash_service.cc(442)] trying to send
report for pid = 5916 [2304:15108:0914/124030:
VERBOSE1:crash_service.cc(331)] client end. pid = 5916
[2304:7260:0914/124032:VERBOSE1:crash_service.cc(323)] client start. pid
= 17124 [15296:19216:0914/124032:VERBOSE1:crash_service_main.cc(68)]
Session start. cmdline is [--reporter-url=https://crashreporter.atom.io
--application-name=Atom --v=1] [15296:19216:0914/124032:
VERBOSE1:crash_service.cc(142)] window handle is 0098117C
[15296:19216:0914/124032:VERBOSE1:crash_service.cc(290)] pipe name is
\.\pipe\Atom Crash Service dumps at C:\Users\nicol\AppData\Local\Temp\Atom
Crashes [15296:19216:0914/124032:VERBOSE1:crash_service.cc(294)]
checkpoint is C:\Users\nicol\AppData\Local\Temp\Atom
Crashes\crash_checkpoint.txt server is https://crashreporter.atom.io
maximum 128 reports/day reporter is electron-crash-service
[15296:19216:0914/124032:ERROR:crash_service.cc(301)] could not start
dumper
And I've uploaded my .dmp file.
adc6964d-443f-466c-9ab1-f9c1692de148.zip
https://github.com/atom/atom/files/473371/adc6964d-443f-466c-9ab1-f9c1692de148.zip
This happens when I try to add a repo to Atom using "Add Project Folder" -
but with certain folders only. For these certain folders, I cannot add them
to Atom - it crashes every single time. For other folders, I can add them
with no issues at all. I cannot find anything in common between the folders
that cause Atom to crash when adding.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/12422#issuecomment-247137400, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AMc7XHM2eWSeUS1o4UCuSkenkxVSjxxpks5qqFRWgaJpZM4JkBVQ
.

Closing as user has switched editors and presumably no longer has the dump files available.

Bummer.
@50Wliu why would we close this? I can reproduce it. Doesn't that mean it's a viable issue?

These types of crashes are very easy to garner :+1: comments that eventually bloat the issue into a generic "Atom crashes" type of issue with no specific focus.
Can you open your own issue please @nicolefmfa?

Will do - TY @50Wliu!


update solo-kit, do not register CRD's on client creation

The latest solo-kit lets you create clients without having to register the CRDs
This allows us to implement our secure-mode design, where users should not need permission to register CRDs.

@sanha this addresses the permissions issue you flagged on slack

👍

@mitchdraft
helloo mkitchdraft
do u have any plan or schedule to fix this issue? we are waiting for fix this issue :-)

Thanks for bumping this, I didn't realize it was blocking you @hgword
work in progress here: https://github.com/solo-io/squash/pull/166
please review the permissions given to the service accounts and let me know if this will meet your needs:
plank: https://github.com/solo-io/squash/pull/166/files#diff-3135f81fd585ae03a9477219dc9e3b4eR251
squash: https://github.com/solo-io/squash/pull/166/files#diff-f7ed3785f15d52d757d380b0d1dd6e87R72
I should be able to merge this update this week
fyi, the key change was: https://github.com/solo-io/squash/pull/166/files#diff-b734217cbcb93350b77bfd9e1f40f668R30 - that allows us to get a resource client without registering the crd along the way. This is possible since we updated solo-kit

@sanha @hgword this feature has been implemented
Now, when using secure-mode, squash will not try to register the DebugAttachment CRD
It will assume that you (or an admin with CRD registration permissions) had already registered it with squashctl utils register-resources
Let me know if this works for you or if you want registration to be disabled in non-secure mode as well

Hi @mitchdraft. Which version was this fixed in? I tried removing the permissions to create CRDs from both squash and plank to support secure mode. However, when I go to run squashctl, it looks like the squash and plank containers both try to register the CRDs anyway still.
failed to register crd: customresourcedefinitions.apiextensions.k8s.io is forbidden: User "system:serviceaccount:squash-debugger:squash-plank" cannot create resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope
{"level":"fatal","ts":1569351347.7799358,"caller":"plank/main.go:27","msg":"debug failed!","error":"failed to register crd: customresourcedefinitions.apiextensions.k8s.io is forbidden: User \"system:serviceaccount:squash-debugger:squash-plank\" cannot create resource \"customresourcedefinitions\" in API group \"apiextensions.k8s.io\" at the cluster scope","stacktrace":"main.main\n\t/Users/mitch/go/src/github.com/solo-io/squash/cmd/plank/main.go:27\nruntime.main\n\t/usr/local/Cellar/go/1.11.1/libexec/src/runtime/proc.go:201"}


Slow performance on mobile

I created a globe on this draft of a new SvelteKit homepage: https://kit-svelte-4iwujf16y-svelte.vercel.app/
When I pull it up on mobile, it makes the page laggy and temporarily locks up my phone. I confirmed with another maintainer who also has a high-end phone.
I think it should be possible as I noticed https://stripe.com/blog/globe works fine on my phone.
I'm not sure if I've done anything obviously wrong. You can see my code here: https://github.com/benmccann/kit/blob/2c2ff26d0c2765571977d46a54602f3b08dc130d/sites/kit.svelte.dev/src/routes/Grow.svelte

Yeah I noticed the same performance issue. I'm wondering if it's because the canvas dimension being too large? Currently it's 1800x400 with DPR=2 (3600x800) even on mobile. Could you try changing it to fit into window.innerWidth?

Ah, yeah, that could be. I'm trying to change it, but can't really make sense of the dimension settings. Why does the example set width and height twice? (once via width property and once via style property). It also seems like the library is updating the canvas element to change some of the dimensions I'm specifying. Can I use dimensions that change? Like 100% of the page width? Will the globe resize as I resize the page in that case?

This is the problem , Does anyone know how to disable the antialias?

@RoberOrz in latest version, you can pass context: { antialias: false } as per #47.
@benmccann

Why does the example set width and height twice?

Because the HTML canvas itself requires width and height to know how many pixels it should render. And then there is CSS width and height to let the browser show it on screen. So in your case style="width: 500px; height: 500px" makes it like a 500x500 picture on screen, and width="1000" makes the actual image computation base on the 1000x1000 canvas (2x), so the image is  clear on a high device pixel ratio screen (which is most screens have nowadays).
And then, because the viewport size can change any time and to always maintain a 2x ratio, you have to add event listeners to resize and then set width and height for the globe just like all the examples do.

I'm gonna close this for now as the performance issue is more related to the canvas and webgl itself, not specifically to this lib's code.


Update Header.js

Updating Header.js to add functionality to the Header component.
This change has been made after updating index.js to add functionality to the Header component.
Pull Request Template
Description
In in homepage of 'Code is Science' website , if we click on the 'Read and Sign the Manifesto' , it doesnot respond.
I have fixed this issue.
Fixes # (issue)
I have included the following changes to solve the issue:

React Router Navigation

Please delete options that are not relevant.

[ Yes] New feature (non-breaking change which adds functionality).

[ Yes] This change requires a documentation update.

How Has This Been Tested?
This has been tested in my local server  'localhost:3000'.
Checklist:

[ Yes] My code follows the style guidelines of this project.
[Yes ] I have performed a self-review of my own code.
[Yes ] I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

Hi, the description is similar to #137 . Can you elaborate on that? Also, please consider opening an issue prior to sending a pull request. Thanks for contributing!

Hi, the description is similar to #137 . Can you elaborate on that? Also, please consider opening an issue prior to sending a pull request. Thanks for contributing!

Both the contributions 137 and 138 are made by me for single issue as both
are required inorder to solve it.
On Wed, 13 Apr, 2022, 1:23 pm Padmaja Bhol, @.***>
wrote:

Hi, the description is similar to #137
https://github.com/codeisscience/journal-policy-tracker-frontend/pull/137
. Can you elaborate on that? Also, please consider opening an issue prior
to sending a pull request. Thanks for contributing!
—
Reply to this email directly, view it on GitHub
https://github.com/codeisscience/journal-policy-tracker-frontend/pull/138#issuecomment-1097673823,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXKCPIGUW3VHVGKNDS5OQ23VEZ4QNANCNFSM5THB34UA
.
You are receiving this because you authored the thread.Message ID:
@.***
.com>

Both the contributions 137 and 138 are made by me for single issue as both are required inorder to solve it.
…
On Wed, 13 Apr, 2022, 1:23 pm Padmaja Bhol, @.> wrote: Hi, the description is similar to #137 <#137> . Can you elaborate on that? Also, please consider opening an issue prior to sending a pull request. Thanks for contributing! — Reply to this email directly, view it on GitHub <#138 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXKCPIGUW3VHVGKNDS5OQ23VEZ4QNANCNFSM5THB34UA . You are receiving this because you authored the thread.Message ID: @. .com>

If both of them are resolving a particular issue, couldn't it be a better idea to have them in a single PR?

Please can you help me in suggesting a way in which both the PRs can be
merged into a single PR ..,i.e ,I want to make changes to both index.js and
header.js in a single PR.
On Thu, Apr 14, 2022 at 1:39 PM Padmaja Bhol @.***>
wrote:

Both the contributions 137 and 138 are made by me for single issue as both
are required inorder to solve it.
… <#m_-198268787832478219_>
On Wed, 13 Apr, 2022, 1:23 pm Padmaja Bhol, @.> wrote: Hi, the
description is similar to #137
https://github.com/codeisscience/journal-policy-tracker-frontend/pull/137
<#137
https://github.com/codeisscience/journal-policy-tracker-frontend/pull/137>
. Can you elaborate on that? Also, please consider opening an issue prior
to sending a pull request. Thanks for contributing! — Reply to this email
directly, view it on GitHub <#138 (comment)
https://github.com/codeisscience/journal-policy-tracker-frontend/pull/138#issuecomment-1097673823>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXKCPIGUW3VHVGKNDS5OQ23VEZ4QNANCNFSM5THB34UA
https://github.com/notifications/unsubscribe-auth/AXKCPIGUW3VHVGKNDS5OQ23VEZ4QNANCNFSM5THB34UA
. You are receiving this because you authored the thread.Message ID: @.
.com>
If both of them are resolving a particular issue, couldn't it be a better
idea to have them in a single PR?
—
Reply to this email directly, view it on GitHub
https://github.com/codeisscience/journal-policy-tracker-frontend/pull/138#issuecomment-1098828489,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXKCPIB22MBRNUJ4WQMJWCTVE7HEVANCNFSM5THB34UA
.
You are receiving this because you authored the thread.Message ID:
@.***
.com>

Now I have successfully resolved this issue in a single PR . The PR is #144 .
Please review it and close this PR #138 .


Rebuild v 3.4.0:

version set to 3.4.0
sha256 updated
run deps updated

Seems like pydantic v 1.9.2 is needed.


[FEAT] Switch torch asserts

We currently have custom assertion to check equal torch tensors
import utils # test utilities
assert utils.check_equal_torch(trans_02_hat, trans_02)

this can be replaced by:
from torch.testing import  assert_allclose
assert_allclose(rans_02_hat, trans_02)

Do we have to replace from all the places where it is used?

closing this since in the last commits this has been incrementally fixed


Callback for prev / next Element?

I want to call a trigger a prev / next function when mfp slides an element.
Therefore I tried to use the "change" callback - but the problem is that this callback also triggers when the popup gets opened, also the "direction" is set to "true". So this callback us useless for my purpose.
Any ideas how to get this working?
Background:
I start mfp via slider images and want the slider to slide the elements according to shown image in mfp (via next / prev triggers)

Got it working ...
you can set a variable within the open callback and then use this variable in an if condition.
In the close callback reset the variable.
var popup_open = 0;

$(slector).magnificPopup({
	callbacks: {
		open: function() {
			popup_open = 1;
		}

		change: function() {
			if(popup_open == 1) {
				// DO STUFF
			}
		}

		close: function() {
			popup_open = 0;
		}
	}
});

This just saved me! Had a popup with videos that auto-played when you clicked a thumbnail, but Magnific would trigger the auto-play code each time I swapped slides. So this code helped me stop that. Thank you!


review usage of relative URIs

In https://github.com/cboettig/contentid/issues/1#issuecomment-606098469 , it came to light that java's URI (and related, commonly used, RDF libraries) uses a URI spec from https://www.ietf.org/rfc/rfc2396.txt . However, this URI spec was deprecated by the introduction of a, more strict, rfc https://tools.ietf.org/html/rfc3986 .
Preston uses relative IRIs and no problems were encountered when using commonly used rdf libraries (https://commons.apache.org/proper/commons-rdf/) and triple stores (e.g., https://jena.apache.org/ ).

As discussed with @mielliott -

implement a check on creating nquads to make sure that IRIs are up to spec (feature)
patch existing provenance logs to ensure that uuid etc are up to spec (patch)

Proposed patch process:

create a new preston provenance graph
first version would only include reference to the first version of the provenance graph.
reprocess old provenance version one provenance log at a time

done.

For historical perspective, from https://cr.openjdk.java.net/~dfuchs/writeups/updating-uri/ -

Updating URI support for RFC 3986 and RFC 3987 in the JDK
Motivation
java.net.URI claims conformance to RFC 2396 (Uniform Resource Identifiers (URI): Generic Syntax) and RFC 2732 (Format for Literal IPv6 Addresses in URLs), with deviations. These two RFCs have been obsoleted by RFC 3986, which is now an Internet Standard. In addition, java.net.URI supports non US-ASCII characters in URIs, which has been later formalized by RFC 3987. Because java.net.URI predates both RFC 3986 and RFC 3987 the documentation makes no mention on how java.net.URI deviates from these two RFCs.
Many bugs and confusion could be avoided if java.net.URI could be upgraded to support the newer RFCs.
Historical consideration
An attempt was made in the past to upgrade java.net.URI to support RFC 3986 and RFC 3987. This caused many JCK tests failures and compatibility issues and the change had to be backed out (see JDK-6394131). To reduce the risk of incompatibilities arising again several roads have been explored.
[...]

@mielliott Please note that recent commits introduced urn:uuid: prefix whenever UUID are serialized to rdf/nquads
example, notice the activity/datagraph name uuid:
$ preston track "https://google.com"
...
<https://google.com> <http://purl.org/pav/hasVersion> <hash://sha256/3a8544e34c7a9df6fcd62c976eb9fe0011596c6c1913145fe8e8827cb14b67b9> <urn:uuid:1b368364-3939-4d2a-94e3-a87e0ef84eaf> .

Next up: have a way to detect relative IRIs generated by statement emitters.

Another example:
$ preston history
<urn:uuid:0659a54f-b713-4f86-a917-5be166a14110> <http://purl.org/pav/hasVersion> <hash://sha256/d8f72bd865686e99eac413b36d198fd15f305966d2864091320f1868279451ff> .
<hash://sha256/d7b73e3472d5a1989598f2a46116a4fc11dfb9ceacdf0a2b2f7f69737883c951> <http://purl.org/pav/previousVersion> <hash://sha256/d8f72bd865686e99eac413b36d198fd15f305966d2864091320f1868279451ff> .

Next up: have a way to detect relative IRIs generated by statement emitters.

Are you just thinking about having preston ls (the printing logger) automatically prefix relative UUID IRIs with urn:uuid? Or are you also considering adding a prefix fixing step to the archiving logger?

Thanks for your comments!
Prefixing the uuid when printing sounds like an idea. You can still to preston cat to get the original provenance log.
Note also, that some uuids come from parsed iDigBio/GBIF data. Also, I remember that some of the DataONE dataset identifiers are treated are URI while some do not qualify at a "new" >2005 (?) URI.
What does your gut tell you? Auto-fix or explicit fix with something like preston ls --strict-uris

I think I favor auto-fixing, since this would probably be our default option to keep old logs "compatible" with new logs. In case we need the original URIs (e.g. if those DataONE dataset identifiers need to be kept intact), we can have an option to use the verbatim URIs. I don't think there's any perfect solution here, we'll probably always need to be careful to handle formatting inconsistencies when using UUIDs shared by different datasets/provenance logs.

Ok, I am ok with opt-out fixing.
I was thinking that for non-compliant URI terms for things other than UUID, we can add the urn:example: prefix instead. See https://en.wikipedia.org/wiki/Uniform_Resource_Name#Experimental . Note that Apache Jena is using the now deprecated urn:x- prefix.

Apache's way of doing things got us into this mess ;)
urn:example sounds fine to me.

closing stale discussion re: relative URIs. Currently, as far as I know, preston logs are generating well formed URIs.


dev2: update resave

[x] include tensorstore metrics
[x] read/write shard sizes from/to file
[x] re-format with ruff
[x] introduce status bar for HCS case with tqdm
[x] optionally output ro-crate-metadata.json (requires #9)
[x] optionally output convert.sh using zarrs (requires #7)

cc: @will-moore @dominikl @sherwoodf @LDeakin

Merging after today's first challenge session. Next steps include:

deploy on pypi as "ome2024-ngff-challenge" (rather than "resave.py")
re-add the shard & chunk flags
parameterize ro-crate info (@sherwoodf)


[Lightbox media viewer] Web Component:  Change component to include a carousel

User Story

As a [user role below]:
Carbon for ibm.com developer

I need to:
create/change the LIghtbox media viewer

so that I can:
provide the ibm.com adopter developers components they can use to build ibm.com web pages

Additional information

Story within Storybook with corresponding knobs
Utilize Carbon
Create with Shadow DOM and Custom Elements standards
See the Epic for the Design and Functional specs information
Web Components Visual QA consulting issue (#6376 )
Designs were done by Kirby Evans.  DDS consulting designer should be included in the PR.  See the Visual QA consulting issue for DDS designer.
Design specs:  PDF and Sketch file
Web Components Prod QA testing issue (#6378 )

Acceptance criteria

[ ] Include README for the web component and corresponding styles
[ ] Create Web Components styles in styles package
[ ] Do not create knobs in Storybook that include JSON objects
[ ] Break out Storybook stories into multiple variation stories, if applicable
[ ] Create codesandbox example under /packages/web-components/examples/codesandbox and include in README
[ ] Minimum 80% unit test coverage
[ ] Update the Carbon for ibm.com website component data file to be sure the web site Component Status and Storybook links are correct
[ ] Use the Visual QA checklist to verify design quality
[ ] DDS design consultant is included as a Reviewer in the Pull Request
[ ] Provide a direct link to the deploy preview for the designer in the Pull Request description
[ ] A comment is posted in the Prod QA issue, tagging Praveen when development is finished

Func spec done.
@RobertaJHahn this is ready for Monday's engineering refinement. Looks like James is not feeling well the past few days, so I can present the specs.

currently trying to integrate the modal lightbox, carousel, and image/video viewers but finding potential discrepancies between spec and implementation esp when scrolling content is in the mix
https://user-images.githubusercontent.com/8265238/134738754-6b3fe560-f217-4b01-bf75-7403daef22e8.mov
may also run into positioning issues due to style conflicts related to previous changes to the component but still more exploration required
https://user-images.githubusercontent.com/8265238/134739215-b3a08af1-f92e-4e75-b9a1-ab2eeb4b2e6e.mov
also gets a bit tricky based on OS scroll bar settings


How to modify the distributed in config.yml?

Dear professor:
Thank you for your carefully guidence and I have successfully run the parallelwavegan.However,the distributed in config.yml is false and I want to modify it to true,can you tell me how to modify the distributed?

Please read README at first.

Install apex https://github.com/kan-bayashi/ParallelWaveGAN#b-make-virtualenv
https://github.com/kan-bayashi/ParallelWaveGAN/blob/master/egs/README.md#:~:text=If you want to accelerate,of gpus.
Please be careful.

I am so sorry, but I really do not find distributed, I have added "distributed: true" to the parallel_wavegan.v3.yaml,however in the config.yml it still "distributed: false".

Dear professor:
Do you mean if I do not install apex, I will not able to use distributed training,so the distributed will be false?

Are you read the document?
https://github.com/kan-bayashi/ParallelWaveGAN/blob/master/egs/README.md#how-to-run-the-recipe

Yes,I find it, I only use one gpu, so the distributed is false.

multi gpu case is also explained. please read carefully.


Is moment-timezone available in moment helper?

Is moment-timezone available in moment helper?
If, so can someone show me an example?
Thanks!
Z

I am looking for something like this
moment('2016-10-31T09:00:00-04:00').tz('US/Pacific').format('L LTS');
and output
"10/31/2016 6:00:00 AM"

The {{moment}} helper uses helper-date which does not include moment-timezone support.
A timezone helper (or some type of option) would be great to have if you'd like to submit a PR to add one.

Would this not be as easy as just doing
const moment = require('moment-timezone');
instead of
const moment = require('moment');
moment-timezone includes moment.....


Enhance Persistent Volumes details view

Description
Review and enhance the Persistent Volumes view. This includes ensuring adherence to design guidelines, completeness of required fields such as Resource Metadata and Status, attachment of Events, inclusion of Resource Graphs, Overview cards, and Monitoring and Health views where needed, to streamline development and operational tasks within the Kyma environment.

Acceptance Criteria

[x] status.phase should be displayed in Status panel
[x] VolumeMode should be added to Details panel
[x] source should be displayed in separate panel (for example csi/nfs)
Examples:

Source:
    Type:              CSI (a Container Storage Interface (CSI) volume source)
    Driver:            pd.csi.storage.gke.io
    FSType:            ext4
    VolumeHandle:      projects/sap-gcp-skr-stg-cust-00013/zones/europe-west3-a/disks/pv--38a741e3-22b9-4d8c-90f7-652f3c6f0d12
    ReadOnly:          false
    VolumeAttributes:      storage.kubernetes.io/csiProvisionerIdentity=1695017040031-8081-pd.csi.storage.gke.io

Source:
    Type:      NFS (an NFS mount that lasts the lifetime of a pod)
    Server:    <IP_ADDRESS>
    Path:      /tmp
    ReadOnly:  false

[ ] nodeAffinity should be displayed

Attachments
k describe PersistentVolume {PV_NAME}

https://kubernetes.io/docs/concepts/storage/persistent-volumes/#node-affinity
For most volume types, you do not need to set this field. You need to explicitly set this for [local](https://kubernetes.io/docs/concepts/storage/volumes/#local) volumes.
nodeAffinity is rare use case for us, so I suggest not to add it


no detect automatically lenguaje

if I have a php file, and I want to comment in an html, comment as php

Any updates on this? Especially for Javascript blocks within HTML files?

Same happens with inline javascript. "cmd + /" works as expected.


Prepare release

Take the opportunity of the next release to revisit a bit some files in the repo. As stated in CHANGES.md:

Upgrade to ocamlformat.0.26.2.
Fmt the code
Add CI badge to README
Upgrade GitHub workflow actions dependencies (checkout@v4, setup-ocaml@v3)
Add more validation steps in CI
Add ocamlformat as dev-setup dependency

@rgrinberg I have noticed the CI for the Dune project itself (workflow.yml) has a refined include section where you limit the various combinations of arch, os and ocaml versions. Given the CI failures here, I am inclined to add a similar section for the pp project as well. What do you think?
In particular, macos-latest, 4.08.x is not going to work due to the constraint: available: !(os = "macos" & arch = "arm64").
I wondered how that last couple of PRs in this project succeeded. The logs have expired so I wasn't able to look in details, but this target is green in for example #19. (?)

Yeah, that sounds fine. Dropping 4.08 altogether is also fine.

Dropping 4.08 altogether is also fine.

It wasn't exactly straight forward to do, as 4.09 has the same issue, and various other versions have other build failures.
I attempted to identify the exact set of CI combinations that do not fail at the moment. I did not expect to encounter that many failures, I am not sure if something unusual is happening. Aren't we going to encounter the same failures when ocaml-ci is going to run during the PR validation on opam-repository? Shall some additional constraints be added to the pp.opam file?
Beside these side questions, I think this PR is ready for review.

@mbarbin assigned @rgrinberg now

I meant to request a review, please disregard.

@rgrinberg I noticed creating 'Merge commit' isn't enabled for this repo. What's your preferred mode of operation between 'Squash and merge' and 'Rebase and merge' in general for this repo? For this PR I lean towards keeping the commit history (I cleaned it up a bit), so planning on merging with a 'Rebase and merge'. I'll try creating smaller PR next so 'Squash and merge' can feel more natural. Sounds OK?

If the commit history is useless (individual commits don't build/work), then I prefer squashing. Otherwise squash & merge is fine. I re-enabled it for this repo.


Write a Swift program to convert weeks to seconds

Description
Write a Swift program to convert weeks to seconds
1 week = 7 days = 168 hours = 10080 minutes = 604800 seconds
Input  : 5
Output : 3024000

How to contribute

Save the solution in program/ConvertWeeksToSeconds.swift file
Add ConvertWeeksToSeconds.swift file in convert-weeks-to-seconds folder

!assign


Example no longer compiles

Need to update the README example so that it reflects the latest version where callbacks return a bool.
Great wrapper. Keep up the good work!

Whoops. :) Thanks!


Setting: Woodfall Temple and Great Bay Temple access in Cleared Region states

Similar to the Adult and child access settings for Well/Fire Temple/Deku Tree, these settings would allow the player to access Woodfall Temple in cleared Southern Swamp without Sonata of Awakening with the dungeon already raised.
Likewise, for Great Bay Temple, if Great Bay is in its cleared state then the turtle is already raised and hookshottable without New Wave Bossa Nova.
Essentially creating similar logical similarities to spring time access for the Snowhead Temple dungeon without Goron Lullaby.

Done


[Excel] (Custom Functions) Clarify Range parameters article section (…

…#2371)

Update Range params section per Github issue

Update docs/excel/custom-functions-parameter-options.md

Co-authored-by: David Chesnut<EMAIL_ADDRESS>Co-authored-by: David Chesnut<EMAIL_ADDRESS>

Docs Build status updates of commit 9c5ab98:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/custom-functions-parameter-options.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Compile python requirements

Automated changes by create-pull-request GitHub action

Someone dealing with a gdal issue seems to think that there's relation to different versions of libarrow being installed
https://github.com/apache/arrow/issues/44696


FEAT: [EVERYTHING] Discuss and strategize and implement integration testing strategy

Our climate suite is very modular and can be fragile when making changes in one repo. We should devise a strategy wherein code updates in a single repo get automatically tested against existing climate code to ensure connection points do not break.

Michael and Zach to look at Mocha framework for testing of individual repos. Estimated around 2 weeks total.
Mocha could provide end to end testing that would test entire system from create org to retire token.

Test script:


Request: Simplify apollo-client middleware

Right now we have to do something like this:
networkInterface.use([{
  applyMiddleware(request, next) {
    if (!request.options.headers) {
      request.options.headers = new Headers();
    }
    request.options.headers.Authorization = token;
    next();
  }
}]);

It would be much nicer to be able to provide regular functions to networkInterface.use rather than having to use applyMIddleware. Thoughts?

I definitely agree.   Upon us figuring out how this works today, I feel like you should just be able to provide functions instead of using applyMiddleware, unless there's a specific reason for this design choice.

In the Express world it's like this:
var app = express();

app.use(function (req, res, next) {
  console.log('Time:', Date.now());
  next();
});

it works the same with router level and error middleware, except the arguments might be different.
So it makes sense to have it access straight functions as that what people are used to, coming from other worlds.

@zimme:  Exactly.  When I was trying to figure out middleware, since I needed it for authorization in my current project, I looked to the Express middleware docs for help, as it was undocumented here.
I was super confused when I realized that it wasn't the same, and that there was an applyMiddleware requirement that I was unaware of.

Is this issue something that people want to be fixed?
I just opened #547, which affects the same part of the code and would be convenient to fix at the same time (assuming my expectations on how to resolve this issue are correct).
I am also curious if there is any explanation to why middleware is required to be an object with an applyMiddleware property because, based on the code, it seems arbitrary.

If someone wants to come around and work on this that's great, but it's not a high priority right now, since people seem to be able to figure it out via the examples.

cc @DxCx @calebmer if we overhaul the network interface, we should keep this in mind. I'm closing it now since it's an ancient issue.


The golang runtime is 1.18 which has several CVE-2022 issues

Bug Report
What happened:
Black Duck Binary Analysis scan the binary and reports several CVE-2022 issues
https://github.com/drycc/service-catalog/blob/main/go.mod#L7
What you expected to happen:
It should be free to CVE and I suggest upgrade to 1.19.x (the latest)
How to reproduce it (as minimally and precisely as possible):
Compile to binary and run Black Duck scanning (it should have the same result by using the other CVE scanning tools)
Anything else we need to know?:
NA
Environment:

Kubernetes version (use kubectl version):
service-catalog version:
Cloud provider or hardware configuration:
Do you have api aggregation enabled?

Do you see the configmap in kube-system?
Does it have all the necessary fields?

kubectl get cm -n kube-system extension-apiserver-authentication -o yaml and look for requestheader-XXX fields

Install tools:

Did you use helm? What were the helm arguments? Did you --set any extra values?

Are you trying to use ALPHA features? Did you enable them?

OK, I'll fix it tomorrow.


Streamline Proofs

📚 Context
The output proofs in the Cartesi rollups are too complex to understand, so I'm proposing a significant simplification.
A single tree to rule them all
The Cartesi rollups should have a single Merkle tree that contains all the DApp outputs. The leaves of this tree will have 32 bytes and will be the output hash. This tree starts empty when the DApp starts. As the DApp advances, the rollups will add the outputs to the tree, one after another. There will be no separation per input or epoch. Instead, the tree will hold all outputs since genesis.
Inside the Cartesi machine, the Rollups C library will maintain an optimized version of this tree. This optimized version can compute the tree root hash as new outputs are added. It will only require log n space and time complexity over the size of the tree to compute the root hash. The Cartesi machine should provide a way to obtain the tree's root hash.
The rollups reader node will maintain a full version of the tree. The reader will update this tree alongside the one in the Cartesi Machine, which should yield the same root hash. Every time a new output is added to the tree, the root hash changes, so keeping the full tree to compute the proof of a given output is necessary. We can optimize this tree by assuming that all empty leaves are zero. However, storing the tree will take O(n) space if it is full.
No more epochs
The rollups claim should be the hash of the Cartesi Machine plus the hash of the outputs Merkle tree. The claim can be done at any input (I think?). Once a claim is accepted after the dispute period, the previous one can be discarded because validating any previous output with the latest claim is possible. Remember, the output Merkle tree contains all the outputs. The reader node should be aware of the current claim in the blockchain to provide the correct proof for the outputs. So, we need to identify the claim by the input index.

@diegonehab @GCdePaula @guidanoli

Nice writeup! I think I just disagree with the last part. In any case, I'll list all changes, let me know if I got anything wrong.
I believe there are four main changes compared with the current implementation:

The outputs tree accumulates forever, no longer being zeroed after each epoch. This means closing epochs has no side-effects, and that that claims are path-independent. This is a great property to have in general, making it easier to reason about the rollups. We can claim whenever we want. Furthermore, it simplifies parts of the node, server-manager, onchain (can keep just the latest claims).
As a consequence, we can move the outputs tree inside the machine. Rather than building this tree outside the emulator, it's now the responsibility of application code to build this tree. This is an amazing simplification for arbitration. It's also easier to reason about the rollups. We also gain the freedom to more easily change the tree structure (dynamic, Patricia, sideways...). This change means the application has to:

Store an auxiliary array of merkle "uncles", which grows logarithmically with the number of outputs.
After each input, compute the merkle root hash of these outputs, "completing" the tree with zeroes.
Store this merkle root hash at a specific known address in the machine.

As a consequence, the claim becomes just the machine state hash. There's no longer an external tree, just machine state.
Simplify the outputs tree to no longer be this nested, two-tiered structure. Instead it's a normal tree where the leaves are sequential outputs. Also, the leafs is just the hash of the output, and not the merkle hash of the output hash split into words.

@gligneul I think (3) is the only disagreement. Did I get the rest correctly?

@GCdePaula it is possible for the claim to be just the machine hash. However, if we do that, when proving an output, we also need the proof that the output tree root is inside the machine. I don't think this is a problem.

@gligneul Yeah, it would need an extra proof.
Like, I guess with the current epoch has you also kinda need a proof, which is just two hashes (output trees hash and machine state hash).
With this change, you'd need a much larger merkle proof. This would suffer of the "32-bytes hash split in four words and merkleized" thing. Suppose the location of the output hash is well aligned. The function would receive the output tree hash (TH) and a merkle proof of a memory range of four words. We first merkleize TH in the granularity of words (MTH), then use the merkle proof to prove that MTH is inside the machine.
As an optimization, since the proof and outputs tree is constant, when a claim is made we could pass the proof along with a claim and have the smart contract validate save the extracted outputs tree.

Great, @gligneul!
I think that this will indeed simplify a lot all the pieces of the architecture. From the nodes, to the disputes.

Great job! Super interesting proposal. This would significantly enhance the current system.
However, I'd like to offer a different perspective on the part where you mentioned, "Once a claim is accepted after the dispute period, the previous one can be discarded because validating any previous output with the latest claim is possible."
My main concern is that this approach would require users to continuously update their proofs for every output they wish to execute. For instance, if a user intends to execute an old output for which they already have a proof, they would need to resync their entire dapp to the most updated state. This could be cumbersome and might deter seamless interactions. Moreover, even if your node is already up to date, there's a potential risk of getting frontrunned by a fresh claim, leading to a transaction getting reverted.
A potential remedy I'd suggest is to retain all claims rather than overwriting them. In this way, proofs could target any valid historical claim, offering more flexibility and less dependency on the latest claims. The executeOutput function signature could be something like: executeOutput(claim, proof, output), where the system would merely verify if the claim exists within the storedall_claims.
This might seem like a slight optimization on the surface, but the added convenience of executing old outputs without necessitating a full dapp sync could be invaluable for end-users.
Again, great work on the proposal! I'm eager to see how this evolves.

I agree with @felipeargento in that we should allow users to prove the validity of outputs with any previously submitted claim.

By the way, for anyone who might be interested in the details of the discussion and wants to see more material.
The idea detailed by @gligneul has inspiration in one from @GCdePaula, described in this Research Meeting video:
https://drive.google.com/file/d/1jG-o8I8vwDw3ka6wYrISj4SuQIpX6Sbj/view?usp=sharing
More precisely at 26:40


Accessing with Apollo from localhost

Hello 👋
Is it possible to use the API from localhost?
I just bootstrapped an app which will consume the API via Apollo GraphQL, and I'm getting this:
Access to fetch at 'https://api.psychonautwiki.org/' from origin 'http://localhost:3000' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: The 'Access-Control-Allow-Origin' header has a value 'https://psychonautwiki.org' that is not equal to the supplied origin. Have the server send the header with a valid value, or, if an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

I tried following the no-cors suggestion and added the following into my Apollo configuration :
fetchOptions: {
  mode: 'no-cors',
}

This will get rid of the errors, but then the server will respond with 500.

Hello @dlbnco! I'm looking into this.

The respective access-control headers now accept wildcard requests. Let me know if this fixes your issue.

@KenanSulayman yes it does! I can now fetch from the API.
I'm still getting this warning, though:
Cross-Origin Read Blocking (CORB) blocked cross-origin response https://api.psychonautwiki.org/ with MIME type text/html. See https://www.chromestatus.com/feature/5629709824032768 for more details.

That's only true as long as you're trying to access the API through outside of the expected entrypoints:

via GET: https://api.psychonautwiki.org/?query=query{substances(query:"LSD"){addictionPotential}}
via POST: Content-type: application/json & {"query":"query{substances(query:"LSD"){addictionPotential}}"} sent as body of the request to https://api.psychonautwiki.org/.

@KenanSulayman
I realized that the warning just happens once loading Apollo's Dev Tools, so it must be something with the extension. Querying from the app itself won't return any warnings.
Thanks for sorting this out!


Reimplement Non-duplicative Checking (#142)

The changes in Pmat2 (#111) that prevented frequent re-checking of the Accomodation Matrix, were unintentionaly undone.  This commit re-implements them.

@ambah this PR is per your comment the other about the overwritten changes

AppVeyer build is still failing. The log seems to indicate that 'make' was not found.


The collection type 'Microsoft.Graph.IUserEventsCollectionPage' is abstract, an interface, or is read only, and could not be instantiated and populated.

The Calendar code returns the following error. Any pointers greatly appreciated :-)
Exception Details: System.NotSupportedException: The collection type 'Microsoft.Graph.IUserEventsCollectionPage' is abstract, an interface, or is read only, and could not be instantiated and populated.
The error is on line 58 of the CalendarController: -
Line 56:             var graphClient = GetAuthenticatedClient();
Line 57:
**Line 58:             var events = await graphClient.Me.Events.Request()**
Line 59:                 .Select("subject,organizer,start,end")
Line 60:                 .OrderBy("createdDateTime DESC")
--

Interesting...I do not reproduce this. Can you provide more details?

Did you clone this repository, download the code via https://developer.microsoft.com/en-us/graph/quick-start, or create the code yourself following https://docs.microsoft.com/en-us/learn/modules/msgraph-build-aspnetmvc-apps/?
What version of Visual Studio?
What version of the Microsoft.Graph library?
Is this error at compile time or when you are running the app?

Hi @jasonjoh and thanks for coming back to me on this :-)
The first time around I coded it myself following the tutorial. Second time, I cloned the completed code and just updated the clientID etc... Both instances result in this error.
The code, logs me in (against a business account) and displays my email but when I click Calendar this error is generated. I'm running latest versions of all packages incl. pre-release. It occurs whether or not I use the Microsoft Graph v1 or Beta SDKs.
I'm running Visual Studio v16.6.1.

Ok thanks. I've got VS 16.6.2, but I don't think that's important.
Using the project "as-is" from GitHub, I've got Microsoft.Graph 3.6.0 and Microsoft.Graph.Core 1.20.1 and do not reproduce. I updated to latest stable, which is M.G 3.7.0 (M.G.C doesn't change), and I still don't reproduce.
Since you said you did latest versions including pre-release, I ticked that box and see that M.G.C has a preview build 2.0.0-preview.3. I installed that, and I'm getting a similar error after logging in:
The collection type 'Microsoft.Graph.IUserAppRoleAssignmentsCollectionPage' on 'Microsoft.Graph.User.AppRoleAssignments' is not supported.

Are you using the preview Microsoft.Graph.Core library? If so, you should roll it back to 1.20.1.

@jasonjoh you've cracked it :-) Thank you so much.
I rolled back to Microsoft Graph Core 1.20.1 (I was on 2.0.0-preview.3) and everything now working.

FYI: It breaks in Microsoft.Graph.Core 2.0.0-preview-2. The last working MGC is 2.0.0-preview-1. No issues with that version.
thanks again @jasonjoh

No problem. You might leave an issue on the core library's repo: https://github.com/microsoftgraph/msgraph-sdk-dotnet

done


nix-1p documentation page is impure

Noted in https://github.com/tazjin/nixery/issues/155#issuecomment-1244040985, but this fetch is currently impure, which make it a hassle to build Nixery as a flake:
https://github.com/tazjin/nixery/blob/644521d767c2b98441f670d1e7fb03354894fcda/default.nix#L28-L33
Would we consider locking the nix-1p version to a tag or commit and including the hash for it there?
Alternatively, could we move nix-1p = depot.nix.nix-1p or nix-1p-git; up to the arguments for the top-level function, so that a caller could pass in a specific instance? Basically it would end up being like:
{ depot ? { nix.readTree.drvTargets = x: x; }
, pkgs ? import <nixpkgs> { }
, preLaunch ? ""
, extraPackages ? [ ]
, maxLayers ? 20
, commitHash ? null
, nix-1p ? depot.nix.nix-1p or builtins.fetchGit {
    url = "https://code.tvl.fyi/depot.git:/nix/nix-1p.git";
    ref = "canon";
  }
, ...
}@args:

I think what I'd actually like to do is drop the current page that Nixery serves completely (this mdbook stuff with nix-1p etc.), and just drop a simple HTML file in there with a landing page that users can override.

Cool cool— yeah, I don't have any particular attachment to a solution other than it being something that can be built in pure mode.

We're replacing the mdbook stuff and nix-1p inclusion with a simple static page here: https://cl.tvl.fyi/c/depot/+/6930
(Note: If you have any comments on that commit you can log in to our Gerrit using Github OAuth, but we've had a few reports from people logging in with Github that they get a strange error message on the first login and it works on the second one - we're just not able to prioritise looking into that right now. You don't need to do anything though, this will percolate through eventually)


HBASE-25507 Leak of ESTABLISHED sockets when compaction encountered "…

…java.io.IOException: Invalid HFile block magic"

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 50s
master passed

+1 :green_heart:
compile
3m  9s
master passed

+1 :green_heart:
checkstyle
1m  4s
master passed

+1 :green_heart:
spotbugs
2m  2s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 29s
the patch passed

+1 :green_heart:
compile
3m  1s
the patch passed

+1 :green_heart:
javac
3m  1s
the patch passed

-0 :warning:
checkstyle
1m  2s
hbase-server: The patch generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m  8s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

45m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2882/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2882

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 8f189debdc19 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3488c44a21

Default Java
AdoptOpenJDK-1.8.0_232-b09

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2882/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
95 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2882/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 27s
master passed

+1 :green_heart:
compile
3m  8s
master passed

+1 :green_heart:
checkstyle
1m  2s
master passed

+1 :green_heart:
spotbugs
1m 59s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 33s
the patch passed

+1 :green_heart:
compile
3m 21s
the patch passed

+1 :green_heart:
javac
3m 21s
the patch passed

-0 :warning:
checkstyle
1m 19s
hbase-server: The patch generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
20m 52s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 24s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

51m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2882/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2882

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux a8e40fa19710 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3cc2468300

Default Java
AdoptOpenJDK-1.8.0_232-b09

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2882/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2882/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 30s
master passed

+1 :green_heart:
compile
3m 34s
master passed

+1 :green_heart:
checkstyle
1m 16s
master passed

+1 :green_heart:
spotbugs
2m 21s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  4s
the patch passed

+1 :green_heart:
compile
3m 32s
the patch passed

+1 :green_heart:
javac
3m 32s
the patch passed

-0 :warning:
checkstyle
1m 13s
hbase-server: The patch generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 50s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

52m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2882/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2882

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux f4f8a001b8d1 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1474ebcc69

Default Java
AdoptOpenJDK-1.8.0_232-b09

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2882/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2882/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 33s
Docker mode activated.


v0.16 on pypi broken for Windows

pip install logentries breaks on Windows. v0.15 installed fine for me, but installing v0.16 results in:
(.venv) C:\Work\external\le_python>python setup.py install
running install
running bdist_egg
error: error in 'egg_base' option: '/tmp' does not exist or is not a directory

@Syeberman Hi. I've released 0.17, which includes @nicholjy 's fix. Let me know if there's any problems still

Thanks, it works!


cannot find module providing package: working directory is not part of a module

I'm trying to execute the Tutorial 1 code but I run into this error:
$ go run traffic.go
traffic.go:4:2: cannot find module providing package github.com/EngoEngine/ecs: working directory is not part of a module
traffic.go:5:2: cannot find module providing package github.com/EngoEngine/engo: working directory is not part of a module
traffic.go:6:2: cannot find module providing package github.com/EngoEngine/engo/common: working directory is not part of a module

I had to activate modules in order to solve this other error: https://github.com/EngoEngine/engo/issues/724

I added the proper go.mod file in this commit to the TrafficManager repository. Make sure you pull the latest changes and it should work for you. Let me know how it goes.

We’ll actually have to add that to all the branches as well. I can get around to it this evening when I’m home if it’s still needed ^_^

Great, thank you :). One thing though: in the Foreword, you recommend setting GOPATH and running go get -u github.com/EngoEngine/engo inside GOPATH. This should be fine because, even though modules are on by default, the GOPATH/src is excluded from module behavior.
However, due to issue #724, one must force module behavior by setting the environment variable GO111MODULE=on. This variable makes any folder inside GOPATH be module-aware.
Thus, once GO111MODULE is set, you can no longer use go get inside GOPATH (if you do, the packages are just cached), and the only way to download a package would be to use git clone.
So perhaps it would be better to indicate git clone from the beginning of the tutorial, instead of go get? I'm quite new to this, but at least that's how I understood it.

All branches now have go modules, but I haven't gotten to updating the tutorial yet so I'll leave this open


SAMZA-2626:  NoOp serde configured for a local table or a storage engine based table is skipped while generating store configs

Issues: JobNodeConfigurationGenerator assumes that a Table based on a StorageEngine API cannot have a NoOpSerde, and while generating store configs for tables NoOpSerde is treated equivalent to null (not present cast) for both key & msg serdes
If we want to add a new KeyValueStorageEngine for Samza which itself handles serialization/deserialization of KeyValue messages the type of Serde you want to use with it is No-Op. Since No-op is assumed the same as null while constructing the KYStorageEngine BaseKeyValueStorageEngineFactory throws a null / serde not found exception
Changes: Fixed the JobNodeConfigurationGenerator to not ignore a NoOpSerde configuration for store-based of local tables
Tests: Added a unit test
API Changes: None
Upgrade Instructions: None
Usage Instructions: None

Can you clarify the motivation on why you need to differentiate NoOpSerde and null within container? Please update the description so that its useful for later references.

Done added more description on why do I need a support for NoOp serde

@Sanil15 NoOpSerde is not a real serde (check its implementation). It's a marker to indicate to framework that a "no op / pass through" serde should be used instead. What that means depends on the context it's being used in. How will passing the NoOpSerde to the BaseKVStorageEngineFactory help here?
Do you instead need to modify ContainerStorageManager & BaseKVStorageEngineFactory etc to allow passing null as the key or msg serde?

Discarding this PR because of incorrect assumptions will follow up with another one to fix this

https://github.com/apache/samza/pull/1475 Pr fixes this correctly