undefined symbols mac linking

I would really appreciate some help. I built 6.1 from source with python 2.7
If Is Is a linking issue I have this in my cmakelists
set(OPENVDB_ROOT /usr/local)
find_package(OpenVDB REQUIRED)
include_directories(
$(OpenVDB_INCLUDE_DIRS)
)
and openvdb in my target_link_libraries
Undefined symbols for architecture x86_64:   "openvdb::v6_1::io::zipToStream(std::basic_ostream<char, std::char_traits<char> >&, char const*, unsigned long)", referenced from:       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&) const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&, bool) const in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>, 4u>, 5u> > > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&) const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>, 4u>, 5u> > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&, bool) const in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::math::Vec3<float>, 3u>, 4u>, 5u> > > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&) const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::math::Vec3<float>, 3u>, 4u>, 5u> > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&, bool) const in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<unsigned long, 3u>, 4u>, 5u> > > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&) const in SceneDensity.cpp.o       ...   "openvdb::v6_1::io::getHalfFloat(std::ios_base&)", referenced from:       openvdb::v6_1::tree::LeafBuffer<unsigned long, 3u>::doLoad() const in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafBuffer<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>::doLoad() const in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafBuffer<float, 3u>::doLoad() const in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafBuffer<int, 3u>::doLoad() const in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafBuffer<openvdb::v6_1::math::Vec3<float>, 3u>::doLoad() const in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafBuffer<unsigned int, 3u>::doLoad() const in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafBuffer<unsigned char, 3u>::doLoad() const in SceneDensity.cpp.o       ...   "openvdb::v6_1::io::bloscToStream(std::basic_ostream<char, std::char_traits<char> >&, char const*, unsigned long, unsigned long)", referenced from:       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&) const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&, bool) const in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>, 4u>, 5u> > > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&) const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>, 4u>, 5u> > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&, bool) const in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::math::Vec3<float>, 3u>, 4u>, 5u> > > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&) const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::math::Vec3<float>, 3u>, 4u>, 5u> > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&, bool) const in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<unsigned long, 3u>, 4u>, 5u> > > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&) const in SceneDensity.cpp.o       ...   "openvdb::v6_1::io::bloscFromStream(std::basic_istream<char, std::char_traits<char> >&, char*, unsigned long)", referenced from:       void openvdb::v6_1::io::readData<unsigned long>(std::basic_istream<char, std::char_traits<char> >&, unsigned long*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<float>(std::basic_istream<char, std::char_traits<char> >&, float*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long> >(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<half>(std::basic_istream<char, std::char_traits<char> >&, half*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<openvdb::v6_1::math::Vec3<float> >(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::math::Vec3<float>*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<int>(std::basic_istream<char, std::char_traits<char> >&, int*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<openvdb::v6_1::math::Vec3<half> >(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::math::Vec3<half>*, unsigned int, unsigned int) in SceneDensity.cpp.o       ...   "openvdb::v6_1::io::unzipFromStream(std::basic_istream<char, std::char_traits<char> >&, char*, unsigned long)", referenced from:       void openvdb::v6_1::io::readData<unsigned long>(std::basic_istream<char, std::char_traits<char> >&, unsigned long*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<float>(std::basic_istream<char, std::char_traits<char> >&, float*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long> >(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<half>(std::basic_istream<char, std::char_traits<char> >&, half*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<openvdb::v6_1::math::Vec3<float> >(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::math::Vec3<float>*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<int>(std::basic_istream<char, std::char_traits<char> >&, int*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<openvdb::v6_1::math::Vec3<half> >(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::math::Vec3<half>*, unsigned int, unsigned int) in SceneDensity.cpp.o       ...   "openvdb::v6_1::io::getFormatVersion(std::ios_base&)", referenced from:       void openvdb::v6_1::io::readCompressedValues<unsigned long, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, unsigned long*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       void openvdb::v6_1::io::readCompressedValues<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       void openvdb::v6_1::io::readCompressedValues<float, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, float*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       void openvdb::v6_1::io::readCompressedValues<int, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, int*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       void openvdb::v6_1::io::readCompressedValues<openvdb::v6_1::math::Vec3<float>, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::math::Vec3<float>*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<bool, 3u>, 4u>, 5u> > >::readBuffers(std::basic_istream<char, std::char_traits<char> >&, bool) in SceneDensity.cpp.o       void openvdb::v6_1::io::readCompressedValues<unsigned int, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, unsigned int*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       ...   "openvdb::v6_1::io::getMappedFilePtr(std::ios_base&)", referenced from:       openvdb::v6_1::tree::LeafNode<unsigned char, 3u>::readBuffers(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::math::CoordBBox const&, bool) in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafNode<int, 3u>::readBuffers(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::math::CoordBBox const&, bool) in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafNode<unsigned int, 3u>::readBuffers(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::math::CoordBBox const&, bool) in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafNode<short, 3u>::readBuffers(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::math::CoordBBox const&, bool) in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafNode<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>::readBuffers(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::math::CoordBBox const&, bool) in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafNode<unsigned long, 3u>::readBuffers(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::math::CoordBBox const&, bool) in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafNode<openvdb::v6_1::math::Vec3<float>, 3u>::readBuffers(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::math::CoordBBox const&, bool) in SceneDensity.cpp.o       ...   "openvdb::v6_1::io::getDataCompression(std::ios_base&)", referenced from:       void openvdb::v6_1::io::readCompressedValues<unsigned long, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, unsigned long*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       void openvdb::v6_1::io::readCompressedValues<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       void openvdb::v6_1::io::readCompressedValues<float, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, float*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       void openvdb::v6_1::io::readCompressedValues<int, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, int*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&) const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&, bool) const in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>, 4u>, 5u> > > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&) const in SceneDensity.cpp.o       ...   "openvdb::v6_1::io::getStreamMetadataPtr(std::ios_base&)", referenced from:       void openvdb::v6_1::io::readData<unsigned long>(std::basic_istream<char, std::char_traits<char> >&, unsigned long*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readCompressedValues<unsigned long, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, unsigned long*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<float>(std::basic_istream<char, std::char_traits<char> >&, float*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long> >(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readCompressedValues<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       void openvdb::v6_1::io::readData<half>(std::basic_istream<char, std::char_traits<char> >&, half*, unsigned int, unsigned int) in SceneDensity.cpp.o       void openvdb::v6_1::io::readCompressedValues<float, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, float*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       ...   "openvdb::v6_1::io::setStreamMetadataPtr(std::ios_base&, std::shared_ptr<openvdb::v6_1::io::StreamMetadata>&, bool)", referenced from:       openvdb::v6_1::tree::LeafBuffer<unsigned long, 3u>::doLoad() const in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafBuffer<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>::doLoad() const in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafBuffer<float, 3u>::doLoad() const in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafBuffer<int, 3u>::doLoad() const in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafBuffer<openvdb::v6_1::math::Vec3<float>, 3u>::doLoad() const in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafBuffer<unsigned int, 3u>::doLoad() const in SceneDensity.cpp.o       openvdb::v6_1::tree::LeafBuffer<unsigned char, 3u>::doLoad() const in SceneDensity.cpp.o       ...   "openvdb::v6_1::io::getGridBackgroundValuePtr(std::ios_base&)", referenced from:       void openvdb::v6_1::io::readCompressedValues<unsigned long, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, unsigned long*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       void openvdb::v6_1::io::readCompressedValues<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       void openvdb::v6_1::io::readCompressedValues<float, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, float*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       void openvdb::v6_1::io::readCompressedValues<int, openvdb::v6_1::util::NodeMask<3u> >(std::basic_istream<char, std::char_traits<char> >&, int*, unsigned int, openvdb::v6_1::util::NodeMask<3u> const&, bool) in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&) const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&, bool) const in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>, 4u>, 5u> > > >::writeBuffers(std::basic_ostream<char, std::char_traits<char> >&) const in SceneDensity.cpp.o       ...   "openvdb::v6_1::io::setGridBackgroundValuePtr(std::ios_base&, void const*)", referenced from:       openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<bool, 3u>, 4u>, 5u> >::readTopology(std::basic_istream<char, std::char_traits<char> >&, bool) in SceneDensity.cpp.o       openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<bool, 3u>, 4u>, 5u> >::writeTopology(std::basic_ostream<char, std::char_traits<char> >&, bool) const in SceneDensity.cpp.o       openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>, 4u>, 5u> >::readTopology(std::basic_istream<char, std::char_traits<char> >&, bool) in SceneDensity.cpp.o       openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>, 4u>, 5u> >::writeTopology(std::basic_ostream<char, std::char_traits<char> >&, bool) const in SceneDensity.cpp.o       openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<unsigned long, 3u>, 4u>, 5u> >::readTopology(std::basic_istream<char, std::char_traits<char> >&, bool) in SceneDensity.cpp.o       openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<unsigned long, 3u>, 4u>, 5u> >::writeTopology(std::basic_ostream<char, std::char_traits<char> >&, bool) const in SceneDensity.cpp.o       openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::math::Vec3<float>, 3u>, 4u>, 5u> >::readTopology(std::basic_istream<char, std::char_traits<char> >&, bool) in SceneDensity.cpp.o       ...   "openvdb::v6_1::io::File::open(bool, std::function<void (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)> const&)", referenced from:       Node::SmokeCache::Evaluate(void const*) in SceneDensity.cpp.o       S_Create(float, float, float, float, unsigned int, bool, char const*, std::shared_ptr<openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > > >*, Scene*) [clone .constprop.0] in scene.cpp.o   "openvdb::v6_1::io::File::readGrid(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)", referenced from:       Node::SmokeCache::Evaluate(void const*) in SceneDensity.cpp.o       S_ReadGridExcept(openvdb::v6_1::io::File&, char const*) in scene.cpp.o   "openvdb::v6_1::io::File::File(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)", referenced from:       Node::SmokeCache::Evaluate(void const*) in SceneDensity.cpp.o       S_Create(float, float, float, float, unsigned int, bool, char const*, std::shared_ptr<openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > > >*, Scene*) [clone .constprop.0] in scene.cpp.o   "openvdb::v6_1::math::MapRegistry::isRegistered(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)", referenced from:       openvdb::v6_1::math::NonlinearFrustumMap::read(std::basic_istream<char, std::char_traits<char> >&) in scene.cpp.o   "openvdb::v6_1::math::MapRegistry::createMap(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)", referenced from:       openvdb::v6_1::math::NonlinearFrustumMap::read(std::basic_istream<char, std::char_traits<char> >&) in scene.cpp.o   "openvdb::v6_1::math::simplify(std::shared_ptr<openvdb::v6_1::math::AffineMap>)", referenced from:       openvdb::v6_1::math::AffineMap::postShear(double, openvdb::v6_1::math::Axis, openvdb::v6_1::math::Axis) const in SceneDensity.cpp.o       openvdb::v6_1::math::ScaleTranslateMap::postShear(double, openvdb::v6_1::math::Axis, openvdb::v6_1::math::Axis) const in SceneDensity.cpp.o       openvdb::v6_1::math::TranslationMap::postShear(double, openvdb::v6_1::math::Axis, openvdb::v6_1::math::Axis) const in SceneDensity.cpp.o       openvdb::v6_1::math::ScaleMap::postShear(double, openvdb::v6_1::math::Axis, openvdb::v6_1::math::Axis) const in SceneDensity.cpp.o       openvdb::v6_1::math::AffineMap::postRotate(double, openvdb::v6_1::math::Axis) const in SceneDensity.cpp.o       openvdb::v6_1::math::ScaleTranslateMap::postRotate(double, openvdb::v6_1::math::Axis) const in SceneDensity.cpp.o       openvdb::v6_1::math::TranslationMap::postRotate(double, openvdb::v6_1::math::Axis) const in SceneDensity.cpp.o       ...   "openvdb::v6_1::math::Transform::Transform(std::shared_ptr<openvdb::v6_1::math::MapBase> const&)", referenced from:       openvdb::v6_1::math::Transform::copy() const in SceneDensity.cpp.o       openvdb::v6_1::math::Transform::copy() const in SceneSurface.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::math::Vec3<float>, 3u>, 4u>, 5u> > > >::copyGrid() in scene.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > >::copyGrid() in scene.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > >::copyGrid() const in scene.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::math::Vec3<float>, 3u>, 4u>, 5u> > > >::copyGrid() const in scene.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > >::deepCopy() const in scene.cpp.o       ...   "openvdb::v6_1::util::printBytes(std::basic_ostream<char, std::char_traits<char> >&, unsigned long long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool, int, int)", referenced from:       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > >::print(std::basic_ostream<char, std::char_traits<char> >&, int) const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>, 4u>, 5u> > >::print(std::basic_ostream<char, std::char_traits<char> >&, int) const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<unsigned long, 3u>, 4u>, 5u> > >::print(std::basic_ostream<char, std::char_traits<char> >&, int) const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::math::Vec3<float>, 3u>, 4u>, 5u> > >::print(std::basic_ostream<char, std::char_traits<char> >&, int) const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<unsigned char, 3u>, 4u>, 5u> > >::print(std::basic_ostream<char, std::char_traits<char> >&, int) const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<bool, 3u>, 4u>, 5u> > >::print(std::basic_ostream<char, std::char_traits<char> >&, int) const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<unsigned int, 3u>, 4u>, 5u> > >::print(std::basic_ostream<char, std::char_traits<char> >&, int) const in SceneDensity.cpp.o       ...   "openvdb::v6_1::GridBase::setName(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)", referenced from:       S_Create(float, float, float, float, unsigned int, bool, char const*, std::shared_ptr<openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > > >*, Scene*) [clone .constprop.0] [clone .cold] in scene.cpp.o   "openvdb::v6_1::Metadata::createMetadata(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)", referenced from:       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<bool, 3u>, 4u>, 5u> > >::getBackgroundValue() const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > >::getBackgroundValue() const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<short, 3u>, 4u>, 5u> > >::getBackgroundValue() const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<unsigned int, 3u>, 4u>, 5u> > >::getBackgroundValue() const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<int, 3u>, 4u>, 5u> > >::getBackgroundValue() const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<unsigned char, 3u>, 4u>, 5u> > >::getBackgroundValue() const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>, 4u>, 5u> > >::getBackgroundValue() const in SceneDensity.cpp.o       ...   "openvdb::v6_1::Metadata::isRegisteredType(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)", referenced from:       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<bool, 3u>, 4u>, 5u> > >::getBackgroundValue() const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > >::getBackgroundValue() const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<short, 3u>, 4u>, 5u> > >::getBackgroundValue() const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<unsigned int, 3u>, 4u>, 5u> > >::getBackgroundValue() const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<int, 3u>, 4u>, 5u> > >::getBackgroundValue() const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<unsigned char, 3u>, 4u>, 5u> > >::getBackgroundValue() const in SceneDensity.cpp.o       openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>, 4u>, 5u> > >::getBackgroundValue() const in SceneDensity.cpp.o       ...   "openvdb::v6_1::io::File::writeGrids(std::vector<std::shared_ptr<openvdb::v6_1::GridBase const>, std::allocator<std::shared_ptr<openvdb::v6_1::GridBase const> > > const&, openvdb::v6_1::MetaMap const&) const", referenced from:       S_Create(float, float, float, float, unsigned int, bool, char const*, std::shared_ptr<openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > > >*, Scene*) [clone .constprop.0] [clone .cold] in scene.cpp.o   "openvdb::v6_1::math::Transform::print(std::basic_ostream<char, std::char_traits<char> >&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const", referenced from:       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<int, 3u>, 4u>, 5u> > > >::print(std::basic_ostream<char, std::char_traits<char> >&, int) const in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::math::Vec3<float>, 3u>, 4u>, 5u> > > >::print(std::basic_ostream<char, std::char_traits<char> >&, int) const in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<unsigned long, 3u>, 4u>, 5u> > > >::print(std::basic_ostream<char, std::char_traits<char> >&, int) const in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > >::print(std::basic_ostream<char, std::char_traits<char> >&, int) const in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<openvdb::v6_1::tools::p2ls_internal::BlindData<float, unsigned long>, 3u>, 4u>, 5u> > > >::print(std::basic_ostream<char, std::char_traits<char> >&, int) const in SceneDensity.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > >::print(std::basic_ostream<char, std::char_traits<char> >&, int) const in SceneSurface.cpp.o       openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<int, 3u>, 4u>, 5u> > > >::print(std::basic_ostream<char, std::char_traits<char> >&, int) const in SceneSurface.cpp.o       ...   "openvdb::v6_1::GridBase::getName[abi:cxx11]() const", referenced from:       Node::SmokeCache::Evaluate(void const*) in SceneDensity.cpp.o   "_scalable_free", referenced from:       Octree::FreeRecursive()      in scene.cpp.o       S_Create(float, float, float, float, unsigned int, bool, char const*, std::shared_ptr<openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > > >*, Scene*) [clone .constprop.0] in scene.cpp.o   "_scalable_malloc", referenced from:       Octree::BuildPath(float4 const&, float4 const&, float4 const&, float4 const&, unsigned int, unsigned int, std::atomic<unsigned int>*, std::atomic<unsigned int>*, tbb::concurrent_vector<Octree, tbb::cache_aligned_allocator<Octree> >*, tbb::concurrent_vector<OctreeStructure, tbb::cache_aligned_allocator<OctreeStructure> >*, VOLUME_BUFFER) in scene.cpp.o       S_Create(float, float, float, float, unsigned int, bool, char const*, std::shared_ptr<openvdb::v6_1::Grid<openvdb::v6_1::tree::Tree<openvdb::v6_1::tree::RootNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::InternalNode<openvdb::v6_1::tree::LeafNode<float, 3u>, 4u>, 5u> > > > >*, Scene*) [clone .constprop.0] in scene.cpp.o ld: symbol(s) not found for architecture x86_64 collect2: error: ld returned 1 exit status

Hi @inkbk, can you please share your complete CMakeLists.txt from where you are calling find_package(OpenVDB) and ideally the cmake command your running and its console output on first run.
Do you have any other builds of OpenVDB installed on your system?

@Idclip
Here is my console log:
https://github.com/inkbk/log/blob/master/log.txt
Here is my cmakelists.txt:
https://github.com/inkbk/log/blob/master/CMakeLists.txt

Hi @inkbk, thanks for providing these. The "openvdb::v6_1::GridBase::getName[abi:cxx11]() const" error is interesting, some folks on the forums have come across this too and it seems to be to do with using different versions of GCC:
https://www.openvdb.org/forum/?place=topic%2Fopenvdb-forum%2FlqJTJ7UMkh4%2Fdiscussion
https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_dual_abi.html
Importantly:

If you get linker errors about undefined references to symbols that involve types in the std::__cxx11 namespace or the tag [abi:cxx11] then it probably indicates that you are trying to link together object files that were compiled with different values for the _GLIBCXX_USE_CXX11_ABI macro. This commonly happens when linking to a third-party library that was compiled with an older version of GCC.

Which version of GCC did you use to build OpenVDB 6.1? You can try adding the following to your CMake:
add_definitions(-D_GLIBCXX_USE_CXX11_ABI=0)
Lets give that a shot and go from there.

Hi @inkbk, can you confirm if the above resolved your issue?

Closing due to inactivity - @inkbk please feel free to re-open if the issue remains unresolved.


updates release workflow

addresses https://github.com/hypertrace/hypertrace/issues/19 & https://github.com/hypertrace/hypertrace/issues/22

@JBAhire are you planning to address @aaron-steinfeld's comments? I think a similar PR being merged in gateway is causing failures on publish.

@JBAhire are you planning to address @aaron-steinfeld's comments? I think a similar PR being merged in gateway is causing failures on publish.

I somehow missed this @buchi-busireddy.
@aaron-steinfeld , Thanks for the review. will address your comments. :)

@aaron-steinfeld , addressed your comments. Please review and let me know if any more changes are required. If this looks good, I will follow similar pattern across all repos as this will help us in our next important goal i.e. putting in proper release process.


Bump golangci-lint timeout from 2m to 5m

Sometimes golangci-lint timesout when running in CI. Bump the timeout from 2 minutes to 5 minutes to reduce flakey CI failures.
ref: https://golangci-lint.run/usage/configuration/#run-configurationhttps://golangci-lint.run/usage/configuration/#run-configuration

Here an example failed CI job, https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_descheduler/1569/pull-descheduler-verify-master/1865066701259804672
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./_output/bin v1.62.2
golangci/golangci-lint info checking GitHub for tag 'v1.62.2'
golangci/golangci-lint info found version: 1.62.2 for v1.62.2/linux/amd64
golangci/golangci-lint info installed ./_output/bin/golangci-lint
./_output/bin/golangci-lint run
level=error msg="Timeout exceeded: try increasing it by passing --timeout option"

/cc @jklaw90 @a7i

/kind cleanup

/approve

@jklaw90 please review when you have some time. Thanks!

/lgtm


Journal Page (Issn)

Journal Page's default design should be revised, we think as DergiPark.
For example; page should show the ISSN

Related issue: #949


It would help enormously with seeing the high level structure of a section as large as Fundamentals->Configuration if headings were hierarchically numbered. e.g. "2.3.1 Some Subsection" instead of trying to infer by looking at the styling applied to the (sub)header.

[Enter feedback here]

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0eb4d762-3910-2c57-8741-3306c15537b6
Version Independent ID: ba2254a0-ea8e-9b28-e94b-edd0fc58c043
Content: Configuration in ASP.NET Core
Content Source: aspnetcore/fundamentals/configuration/index.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hello @Sanda35 ... Thanks for the note, but we adhere to Microsoft's guidelines, which don't call for an approach like that. You can provide general docs feedback at ...
https://github.com/MicrosoftDocs/feedback/issues

btw tho ... passing note that might be a little bit helpful ... you can at least see the H2 headings in the topic's table of contents sidebar. It used to show the full H2 structure right out in the open, but they collapsed it recently much to my dismay. You now need to click it to show the full H2 structure of the doc.


Government reports

User story
As a Bron user,
I want to be able to track newly released government reports,
so that I can keep up to date on newsworthy findings from government agencies
Acceptance criteria

New government reports are imported into the Bron database on a daily basis
Government reports are available to be searched full-text using Bron
An option to deselect/select the new source is available in the Bron UI

Additional information

The reports can be found at https://open.overheid.nl/zoekresultaten?informatiesoort=c_3300f29a&sort=date-desc&page=1

Fixed in the following commits:

5f194aa7ca72be8ff578ae2d896da02f0a732ba2
09e4711d3f23c44a7087225fd735ce9e049ebc76
0170f030920effb16ede7a67ae3018f14fe0276e
bcbc3b89d01a60b89f3696c449a4433180bc0f8f
dbd96808301f6b0c426a6a22bd334ae41713a8a7
79d5810dcbeafd69fb4dab17a5894606141cad93
d57e5e522fb62028d73f88018c5b1a178ad10e3a


[silgen] When pushing an RValue through a scope, use dealloc_box on any boxes we create instead of destroy_value.

[silgen] When pushing an RValue through a scope, use dealloc_box on any boxes we create instead of destroy_value.
It is only safe to perform a destroy_value on an alloc_box that contains an
initialized value. We preserve the original cleanups for the value we are
pushing through the scope implying that the box will not contain an initialized
value when its lifetime ends (just like an alloc_stack). Thus we must use
dealloc_box here.
The surprising thing about tracking down this error is that I was not hitting
any memory issues at -Onone. Instead what was happening was that at -O, we were
miscompiling (creating non-dominating uses of SSA values) in the face of an
address being taken twice.
This does not seem to hit any SILGen tests today (I hit this when testing a
patch I am trying to land today).
rdar://31521023

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci smoke test and merge


Something went wrong with Demo projects in VS 2017 WPF solution

So, I've downloaded .zip from master branch, unpacked it, opened "MaterialDesignToolkit.WPF" solution in my Visual Studio 2017 (v 15.3.5) and got 25 errors like "The name does not exist in the namespace"
Is something wrong with VS or it could be fixed by downloading something?

What's the very first error?

The name "TabablzControl" does not exist in the namespace "clr-namespace:Dragablz;assembly=Dragablz".
In App.xaml

@JeffRockatansky i would suspect that dependencies are missing. After attempting to build the solution (packet and the dependencies should download as part of the build process), check and see if there packages directory in the same folder as the solution.
If it is missing try turning up your build output to at least Detailed and examine the output. I suspect some other error is actually what is causing the issue.

@Keboo
Packages folder is empty huh. But it's present in the same folder as solution :D
Output has a big scary wall of text. Didn't find anything useful yet.

If you expand the references in MapAppsDragablzDemo (the project showing the errors in your screenshot) does it show that all of the references have resolved?

How to fix "yellow triangles" of Dragablz and MahApps.Metro? (Is it actually Dragon Ball Z reference?)

If you are not wanting to use the MahApps/Dragablz stuff, no you don't need and can simply unload it.

Ok
TY and sorry :D

So, if I need Dragablz features to look at in demo, I need to clone Dragablz, compile it and add it's .dll in References of this Material wpf demo?

And what if I need them both in my own project, but not the Metro one?

Tried to add 3 different .DLL's for each of Dragablz and MahApps.Metro for Material + Dragablz Demo. Ones from "Package" folder, others - from masters of sources compiled on my PC. Tried 40 and 45 versions. "Build successful" every time, but it crashes with error or in debug enters Break point state.

You should never need to recompile anything.
Ideally you should start new projects and add any combination of Material Design, Dragablz, MahApps, via nuget.
As for the demo.  I have just retested.  Downloaded a clean .zip (normally I do a "git clone" from cmd line).  Opened in VS2017, compiled, ran.  All references were OK, project ran fine.  You will see some errors in the designer.  That is VS.  But ignore these for now; the project should run.

i downloaded the material design themes just now for my vs 2017 and on loading the project, i got
these errors
Severity	Code	Description	Project	File	Line	Suppression State
Error		The current .NET SDK does not support targeting .NET Core 3.1.  Either target .NET Core 1.1 or lower, or use a version of the .NET SDK that supports .NET Core 3.1.	MaterialDesignColors.Wpf.Tests	C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.TargetFrameworkInference.targets	112
Severity	Code	Description	Project	File	Line	Suppression State
Error	MSB3073	The command ""C:\kenny folder\Setups\MaterialDesignInXamlToolkit-master\MaterialDesignInXamlToolkit-master.paket\paket.exe" restore" exited with code 1.	MaterialDesignThemes.Wpf.Tests	C:\kenny folder\Setups\MaterialDesignInXamlToolkit-master\MaterialDesignInXamlToolkit-master.paket\Paket.Restore.targets	171
and  also, some material design themes choose not to load...always writting load failed
Am using VS 2017, .net core 2.1

@Aycom366 see https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/wiki/Compiling-From-Source
You will need VS2019 and .NET Core 3.1 to compile from source.

I can't run MahAppsDragablzDemo
it occurs System.Windows.Baml2006.TypeConverterMarkupExtension Exception


allow to manually edit resulted commit message

I think we could pass resulted commit message to git commit -m

I find sometimes the need to edit some typos in the message. When that happens, I cancel the commit at the last confirmation question, copy the commit and edit. As far as I remember, comittizen passes a function from gulp-git. Maybe we can call with params? I will look if we can pass params to gulp-git function.

I have added a pr to commitizen to support passing options to commit.
But seems gulp-git doesn't support editor. It displayed but you can not interact with it :(

I get an error when trying to edit the message:
?  Edit message
(node:17332) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.
events.js:137
      throw er; // Unhandled 'error' event
      ^

Error: spawn vim ENOENT
    at _errnoException (util.js:1003:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:201:19)
    at onErrorNT (internal/child_process.js:389:16)
    at process._tickCallback (internal/process/next_tick.js:152:19)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>


Allow using non-integer model IDs

Larastan Version: 0.5.5
--level used: max

Description
PR #499 allows only (!) integer type for model IDs.
But we are using UUID for some models IDs and static analysis failing.
I propose to rollback the PR.
Laravel code where the issue was found
/**
 * @property string $user
 */
class User extends Model
{
/...
}

function foo(string $foo): void
{
    echo $foo;
}

foo($user->id);

So you'd like to have int|string?

Hi,
This is fixed in the current master. You can specify a type for your id property in the annotation, and that will be used.
/**
 * @property string $id
 */
class User extends Model
{}

@canvural cool, thanks!


Document gpg keys

We use Dependency Verification and currently there is no documentation stating which keys are safe
Could you please document this?
For example, 2.1.23 was signed using 36D4E9618F3ADAB5
But 2.0.10  was signed with 637b8fb6cd0b57ca1e833e897f083a4ab2af5107

Here are some examples of other projects documenting what key they use to sign their artifacts.

https://github.com/qos-ch/slf4j/blob/master/SECURITY.md#verifying-contents
https://square.github.io/okhttp/security/security/#verifying-artifacts
https://downloads.apache.org/logging/KEYS

@oshai Could you please action this? We'd like to upgrade but this is blocking us

Ok, I will add such section.
How did you find out the keys each version is signed with?

you can use Gradle to verify the signing info:
See https://docs.gradle.org/current/userguide/dependency_verification.html
But you can also find the key like this.
gpg will give the key-id when you try to verify the .asc file.
$ wget https://repo1.maven.org/maven2/io/github/microutils/kotlin-logging-jvm/2.1.23/kotlin-logging-jvm-2.1.23.jar.asc
$ wget https://repo1.maven.org/maven2/io/github/microutils/kotlin-logging-jvm/2.1.23/kotlin-logging-jvm-2.1.23.jar
$ gpg --verify kotlin-logging-jvm-2.1.23.jar.asc
gpg: assuming signed data in 'kotlin-logging-jvm-2.1.23.jar'
gpg: Signature made Fri May 20 07:41:25 2022 MST
gpg:                using RSA key 36D4E9618F3ADAB5
gpg: Can't check signature: No public key

$ curl https://keys.openpgp.org/vks/v1/by-keyid/36D4E9618F3ADAB5

-----BEGIN PGP PUBLIC KEY BLOCK-----
Comment: 47EB 6836 245D 2D40 E89D  FB41 36D4 E961 8F3A DAB5

xsDNBGGiftwBDAC94Yhhh/5yO8jYFkg01MPnooXKZEPwxAbAg9wn5iM0tHxhEpkU
zJVYZ+JYq013+Ldp8Of7A/d6hKTtZ0xwSeY7S/WFykIk6tc0P5j0sfFS3pGPDk+W
D3DwUa+8m0PriF7iA57vCOE51znO/IUIA3PG2YAK6jv2/i8MDXOOq3qB7VrbvKGB
kIPubp5PbjvP+LFhLuUReU9m2y/3q9lNFXdd9kE2iScqGmu3FDhRJxBK/WQ2kqiv
sJZjAYeHEVNcc88Ah6vXI73uYrvWVGCErzswYy9UrxCAQ/x2OxUdLw7NTHwjZSYC
JvH5JPPTlDxMgfwTIsmaECtw4QgiVmvDp+RVa9zyrdI++RNr0InsXv9gWMv3p3yf
TF20ZL8znFYVUi6XkeQhZjT4fHwDqDVnxhSAFe3E0cwHFJBQe2EFLljwNy6VYnio
wBr7HrAxczRRqlUy4a3bH5KwiNwwvxgqfdMj9KTVpP9t98/TA36bIohwGFRWB7W4
i395S90NsTbCh/cAEQEAAc7AzQRhon7cAQwAtPmKcM1/z8sMJnt4sHe3ndXsOdSq
TJbRkAcdyDO1F4qgj5z9wkrlVVKGuVtmJS3qmR901Q+oH+JqM6UeGqhNig4IQvME
iQjjelvKXMX9PPVzlP+ga5Y1/2mnUmgmYXK406CU7aaQ3hs7++XDonnQUt5nWF9d
XT+xK/SDLYMk5i1TNqPVFZBPm44HpIjKGNJXD7Vv/5z62+hKswpLXgYt8Rz95ByG
ncjQ1Lo2M1T1Y/EuwlRoc9RTdyABavSQWVLKIz6kKM4LejajjRvLnybMUug0CJl5
mni4cHXx9t0pMlG5DE2O3mZLwTgWcJ8cu2CtPxA9iLfVvFAThxk3ZitkEhChBtG9
/V8D4DiTIht6bd49xkHP5pxtB/fuo9lNb0axSBaOAeant3KA6F6vki+chnGhOFqV
1KJHcxYG7VsG1hYhy5IbZsg4GdcXfTwwF1/mq8kvHfyTkBy6HMDGwpr0ATNnrxO7
tJTiVqDuxfviGQUjqJIQDns6fM9BI4OfpXyjABEBAAHCwPYEGAEIACAWIQRH62g2
JF0tQOid+0E21OlhjzratQUCYaJ+3AIbDAAKCRA21OlhjzratRBcDACCfhsaCFvM
JTls5lT/dcTqSCYJYZyDj95DlTiaRNkXnAGrTyE45PnmJLv6FFZzSZdu/eLE8ls2
MY/KWqnZYYV2Mct/pwDDLSjdAN/NSRe9HeAh2OS1kNeN2SIcoL55gEodKBNSMisY
9N3ylLMxHZPa5LNBo+j9wftEaVi2fTX8LDJFQvUOZ3f7cz3f6u42FeHUqaLm2alH
QSkfTB3yIu8Hmo2EXHh4UfwTmS55OBGLQ91d8neu7PcimqCeadeHW+qY5g5hr5NN
LxMA+n+vwPGcQNxg0lH2XBdlFBbAELEGxMcKbW51QL2h+EdwGzT/nK3Iia/qm3N5
0Z12j/hhzohlf7TQjhzB43Wbxef94JbKacvng8t/hG3+n8UASQzizCSn/oMkXQom
XdQe5JFgJCroU2CfrdFmZfbkkq9mAi80BLUEAGNTUQrg/W39VX1/klGiXiWtpU8g
q/tSGRQHXTwG53qejlUtKI315ZizOhJiniSDx4fZaK2zB9RlZkrnd1Y=
=1LSv
-----END PGP PUBLIC KEY BLOCK-----

Thanks!
I created this https://github.com/MicroUtils/kotlin-logging/pull/237
Please let me know if that looks good and I will merge.

Thanks for reporting an assistance!


ComposerCollector doesn't allow to check exclusion from one of the packages

deptrac:
  paths:
    - src/Shared/src
    - src/BoundedContext/Network/src
    - src/BoundedContext/Project/src
    - src/BoundedContext/System/src
  layers:
    - name: Domain
      collectors:
        - type: directory
          value: 'Domain/.*'
    - name: Application
      collectors:
        - type: directory
          value: 'Application/.*'
    - name: Infrastructure
      collectors:
        - type: directory
          value: 'Infrastructure/.*'
    - name: Presentation
      collectors:
        - type: directory
          value: 'Presentation/.*'
    - name: Vendor
      collectors:
        - type: composer
          composerPath: api/composer.json
          composerLockPath: api/composer.lock
          packages:
            - ramsey/uuid
            - symfony/serializer
            - php-ds/php-ds
            - psr/container
            - psr/log
            - psr/simple-cache
            - laravel/framework
            - sebastian/comparator
  ruleset:
    Domain:
    Application:
      - Domain
    Presentation:
      - Domain
      - Application
    Infrastructure:
      - Domain
      - Application
      - Presentation
      - Vendor

In the Vendor layer packages I have the sebastian/comparator package specified, which is ignored by ComposerCollector. My guess is that this package uses autoload/classmap in composer.json instead of psr-4.

Hello,
you are correct, it uses classmap to load the files. It not working is expected documented behavior. Straight from the composer collector documentation:
The composer collector allows you to define dependencies on composer require or require-dev packages that follow PSR-0 or PSR-4 autoloading convention.

I would suggest using DirectoryCollector over the package's src dir instead.


feat: SquashDictInnerContinueLoop hint

Resolves #299
This PR implements SquashDictInnerContinueLoop hint, which checks if the squashing loop should continue or not, depending on whether there are access indices remaining or not.
It writes 1 or 0 in should_continue field of loop_temps struct variable
Here is the LoopTemps struct :
   struct LoopTemps {
        index_delta_minus1: felt,
        index_delta: felt,
        ptr_delta: felt,
        should_continue: felt,
    }

I added offset of 4 to write on the 4th item of the struct, as we first store the number of items and then each item contiguously in memory

@har777  comments addressed. Its nice to use the WriteToNthStructField wrapper, it reduces code size. thanks


feat: add fix-copyrights.sh script

:tada: This PR is included in version 0.57.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


wasm version

I agree that the wasm version makes sense with wazero for backend.
would like to work on this. Perhaps it's already done ?
there is also https://github.com/automerge/automerge-go which is directly bound to the rust implementation, and so also not using wasm

this should already compile to wasm! not sure if it works with tinygo, but big go should work. what's the particular use case? btw, i don't actively work on this project any longer but if there's anything easy i can do, i will.


Websocket warmup

Hello
I'm integrating websockets into our application based on the official article https://www.serverless.com/framework/docs/providers/aws/events/websocket/
And I have a question about how the warmup plugin works with WebSocket lambdas.
Unfortunately I did not find any info yet

Do we need to warmup websocket lambdas to speed up the first connection ?
If we do, then how to warmup the websocket lambda that is placed behind the auth lambda?
Thank you

Hi @Travellerme ,
Tob e honest, I've never considered websockets in the plugin.
The plugin just use the AWS SDK invoke method to invoke the lambda. So, as long as your handler handles the warmup event as described in the docs it should work just fine.

Hi @Travellerme ,
Did you progress on this?


Fix 23132 - Avoid ranges copy when compared for equality

With this change, at least my code compiles again successfully.

With this change, at least my code compiles again successfully.

Regressions should target stable branch. Also, this seems to be rather a regression on the compiler. I can't confirm right now tho.

Ok, I've switched it (with a bit of a struggle) to the stable branch.
I also thing that the main problem is somewhere in the compiler, but at least this is some workaround as the bisected PR's refactor makes this come up?
Unfortunately I haven't found any simplified test case for this.

Can probably just be plain ref, since it's a private function that's only ever called with lvalue arguments.

Can probably just be plain ref, since it's a private function that's only ever called with lvalue arguments.

Right, changed


can't use new module

I can not use 'chart.js' .
I am install chart.js with bower and add it like this " angular.module('app.components', ['chart.js']) "
when refresh my site, show errors

angular.js:68Uncaught Error: [$injector:modulerr] Failed to instantiate module app due to:
Error: [$injector:modulerr] Failed to instantiate module app.components due to:
Error: [$injector:modulerr] Failed to instantiate module chart.js due to:
Error: [$injector:nomod] Module 'chart.js' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.

how can i fix this problem ?
thank you

Hi filmskiz, in the default package, chart is already included. It's also already in the index.modules.js file added like angular.module('app.components'),['chart.js', etc etc])
To add it into your component, add chart to your constructor.

When i want to import other module with bower ,What should I do ?
Now i'm add package name into angular.module('app.components') but can not working.

hi @filmsklz you're probably missing angular-chart.js in your bower.json see bower.json#L24. update your file and do a bower install

Thank you ,The problem is solved.

how can i enable select2 or datetimepicker on my project

may i know the steps to add new modules from bower_components


Liquid detection is too aggressive

The title says it all.
On my server, players die when hitting water or lava but some jumps are near impossible now.
For example, it is now impossible to jump on a lilypad in the middle of a lake because you'll get killed when landing. Jumping next to water is impossible, being on a block and sneaking above water kills you now.

Instead of setting water as a death block, set DieInLiquid to true in the config.yml.
OnCourse:
    DieInLiquid: true

After some testing, it turns out that it's the ParkourKit death block check that's causing the issue.
It works just fine when using DieInLiquid.
But we were looking forward to turning off DieInLiquid (and to move that to ParkourKits) to create aquatic parkours to use the newest swimming mechanics...

Yeah, it was just meant as a workaround for now. We've already tested a fix for this. It should be downloadable from the Releases tab some time soon.

@steve4744 Fixed this issue and is in the latest (v5.3) release.


Crashes in heroku

I am trying to deploy a rails app with rails_api_auth on Heroku, but it crashes almost immediately:
2017-05-25T21:04:13.898375+00:00 heroku[web.1]: Starting process with command `bundle exec rails server -p 3000`
2017-05-25T21:04:17.856945+00:00 heroku[web.1]: Process exited with status 1
2017-05-25T21:04:17.747061+00:00 app[web.1]: /app/vendor/bundle/ruby/2.2.0/gems/rails_api_auth-0.0.7/app/services/edx_authenticator.rb:9:in `+': no implicit conversion of nil into String (TypeError)

It woks fine locally in development. If anyone has any insights into this, I would appreciate it.

It turns out that the engine needs to be configured with empty strings, even if you are not using Edx or Facebook or Google, as specified here.


[Check-in] Migrate Production endpoints to Keycloak based OP

Summary
This PR introduces the following changes:

Update OIDC endpoints of the Production instance of Check-in OP
Update the example response of device code flow
Fix misspelled words and code style
Update guidelines for Protocol Specific options on OpenStack guide

@gwarf This PR depends on Enol's PR#463.
I will rebase my PR after merging PR#463 in order to fix the conflicts and the failed checks

Ready for fixing issues as #463 is now merged.

The errors on the links are apparently some false negative, tested locally and links are working well. Not sure what is failing here, but we can probably merge.

The errors on the links are apparently some false negative, also tested locally and links are working well, like on the preview. Not sure what is failing here, but we can probably merge.

I see that some links are in the form (../../cloud-compute/openstack/aai/#client-migration-to-keycloak )  instead of `(../../cloud-compute/openstack/aai#client-migration-to-keycloak), not sure if this would change the test.


Activating extension 'vscode.typescript-language-features' failed: Invalid Unicode escape sequence.

VSCode Version: 1.27.0-insider 00649474f2e43a84c61ddbbbc356060257328372
OS Version:

Steps to Reproduce:

Open a typescript project
🐛 No typescript language services

Does this issue occur when all extensions are disabled?: Yes/No

@jrieken Could be related to changes done to nls?

Hm, maybe... I see the errors but TypeScript works happily for me. Oh, this is windows...

Do we need a new insiders build for this?

It's on its way...


Command line script to list possibly outdated repos from README.md

I had some fun building a command line utility that can be used as an indicator to find repositories in README.md that are not maintained anymore.
The tool queries the Github API for the last commit date of the referenced repositories and prints the date, line and line number of the ones older than some threshold amount of months.
You need a Github token from https://github.com/settings/tokens and then call it like so:
./bin/list_outdated.js --threshold 18 --token your_personal_github_token

The output looks like the following:
outdated.txt
I'm not completely sure if this is something you guys would like to integrate into the repository, but thought it might be useful. Let me know what you think.

Thanks for your improvement pull request!
In Currently, we are making new curation site to resolve this issue.
For this reason, close. 🙇


Application insights package breaks GitLens + eslint

Hi... I wanted to let you know about an issue I ran into with Gitlens breaking other extensions.
You can read the details and fix here.
Thanks!
Jeremy

@GollyJer thanks for the info.  I'll see what can be done or I'll just have to nuke it.

@GollyJer can you try the GitLens beta here: v3.6.0-beta to see if it resolves the issue for you? You can find installation instructions here: Installing Beta Releases

@GollyJer awesome -- thanks!

Fixed in v3.6.0


Input view broken (again)

Can't find the previous issue, but you can't bold / italics / whatever again

What build/device?
Sent with GitHawk

Simulator on master
Sent with GitHawk

Testing bold italics code strikethrough
Sent with GitHawk

Seems to be working on device in the latest TF (1.12.0 (1106)), but on simulator it still seems to be broken. I'll lower the prio.


added a screancast of Data Modeling Course

What does this PR do?
Add Resource(s) | Remove Resource(s) | Add info | Improve Repo
For resources
Description
Curso em Vídeo - Banco de Dados MySQL (screencast)
Was  added a screancast of Data Modeling Course
Why is this valuable (or not)
because him show the easy way to modeling a data base
How do we know it's really free?
because this screencast stay on youtube
For book lists, is it a book?
no, it isn't a book
Checklist:

[X] Not a duplicate
[X] Included author(s) if appropriate
[X] Lists are in alphabetical order
[X] Needed indications added (PDF, access notes, under construction)

Thanks!


Unknown error: 1

So i can't make howdy work
howdy test is working, sudo -i isn't working and returning
sudo howdy version
Unknown error: 1

What i've done:

install from fusion
add /dev/video2 to sudo howdy config
add auth sufficient pam_python.so /lib64/security/howdy/pam.py to /etc/pam.d/sudo
chmod o-x /lib64/security/howdy/compare.py

Also tried (maybe the wrong way):

https://github.com/boltgolt/howdy/issues/233
https://github.com/boltgolt/howdy/issues/830
https://discussion.fedoraproject.org/t/anbinx-howdy/46321

Logs:
окт 30 10:20:00 MSI [8580]: Attempting facial authentication for user doccringol
окт 30 10:20:05 MSI python3[8582]: detected unhandled Python exception in '/lib64/security/howdy/compare.py'
окт 30 10:20:05 MSI [8580]: Failure, unknown error1
окт 30 10:20:05 MSI audit: BPF prog-id=100 op=LOAD
окт 30 10:20:05 MSI systemd[1]: Starting fprintd.service - Fingerprint Authentication Daemon...
окт 30 10:20:05 MSI abrt-server[8633]: Package 'howdy' isn't signed with proper key
окт 30 10:20:05 MSI abrt-server[8633]: 'post-create' on '/var/spool/abrt/Python3-2023-10-30-10:20:05-8582' exited with 1
окт 30 10:20:05 MSI abrt-server[8633]: Deleting problem directory '/var/spool/abrt/Python3-2023-10-30-10:20:05-8582'
окт 30 10:20:05 MSI systemd[1]: Started fprintd.service - Fingerprint Authentication Daemon.
окт 30 10:20:05 MSI audit[1]: SERVICE_START pid=1 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:init_t:s0 msg='unit=fprintd comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success'

Maybe it is posible to somehow get compare.py's traceback?
Howdy version: 2.6.1

have you configured SELinux and #801?

chmod o-x /lib64/security/howdy/compare.py

it should be o+x not o-x

it should be o+x not o-x
yeah, missclick

and yes, #801 helped, thanks a lot


chore: import repository https://github.com/jenkins-x-sampleproject/golangnew.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.


Restyled the site

Changed up the colors on the site, basically made it dark mode. Also made it so that the songs will appear next to each other.

Thank you @JakeCapra  !! This is fantastic


user-POST Route removed

POST request route for 'user' was removed.

Should I retain the comments regarding the Post Route or remove it ?


perf(prometheus) optimize proxy path long tail latency when scraping

Summary
Performance optimizations
Full changelog

perf(prometheus) optimize performance of export functions
perf(prometheus) store most of gauges to local tables and skip shdict
perf(prometheus) turn off high cardinality metrics by default

Issue reference

FTI-4083 FT-2956

@fffonion I guess this also needs to be documented inside the Prometheus Plugin page right? cc/ @ryanmoore @hfukada

@sichvoge Definitely, I will start docs once this PR is finalized.

i will address reviews next week, and add some Targets in performance test to validate local stored gauge's prerformance

@fffonion sorry to drag up such an old PR, but I wanted to check: can #8844 be closed out due to this PR, or is there still more work to be performed before that issue is ready to close?


Spike - Research librdkafka / Sarama Capabilities

It has been a long time since we performed the original comparison between the librdkafka/confluent and sarama libraries.  We have not yet upgraded librdkafka and before we invest in doing so we want to re-evaluate whether it is still the best option.  Specifically we need the resulting implementation to be the highest throughput solution with elastic scaling and per-partition ordering.  There are concerns in knative about this library choice and we need solid information to back our selection (whatever it may be).
Notes
Previously Sarama was split into two libraries (sarama and sarama-cluster) and they've now been integrated.  Sarama also had limitations regarding ordering that discounted it from consideration.  They do make it easy to read multiple partitions concurrently in the same consumer.  They don't yet support manual offset committing (though there are a number of issues open asking about it).
The librdkafka/confluent library is difficult to work with from a build/packaging perspective and there are concerns that crossing the Go/C barrier might be slow/inefficient.  Further, to move forward we'd need to support Go Modules which is what the confluent client is now based on.  It is also unclear whether they will support reading from specific partitions, but someone has created a PR to support reading from a specific partition https://github.com/confluentinc/confluent-kafka-go/pull/456 for it.

CloudEvents sdk-go V2 has protocol support for sarama but not confluent...
https://github.com/cloudevents/sdk-go/tree/master/v2/protocol

If it can help you, i have an "incomplete" benchmark of the different kafka clients out there: https://github.com/slinkydeveloper/kafka-go-clients-benchmarks
You can use it as basis for benchmarking, but you'll need to hack the librdkafka code (i have to upload it)
Tl;dr librdkafka performs well on producer side, but consuming is slow because it's one polling entrypoint for consumer, not one per partition as consumer group by sarama. There is an open issue about that: https://github.com/confluentinc/confluent-kafka-go/issues/440

Closing all issues as project is going to be archived. If it is still valid create a new issue in https://github.com/knative-sandbox/eventing-kafka


Adding support for Perl repo maps

Issue
Hi, what would be needed to add Perl5 support (repo maps, not just linting) to Aider?
Is it a matter of updating the tree-sitter grammar for Perl?
Version and model info
No response

Thanks for trying aider and filing this issue. This doc may be helpful:
https://aider.chat/docs/languages.html#how-to-add-support-for-another-language

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


An active mailing list

An active communication channel
I read the README, and in the end, has a mailing list to<EMAIL_ADDRESS>Is this still the main communication channel? There is another mailing list or IRC?

Yes, this is the main communication channel together with this repository.
Also, thanks for your input! I will review your PR in the next few days.


Routes not found after reload

Sorry I haven't a chance to look into this more. When I change my main routes file to trigger a reload, all routes return 404. Do you have any pointers? I'm using the latest master version. I think the Rubygem version still doesn't have the latest changes, specifically the relaxed dependency versioning for rack.

Hi @tombh. Yes, i've also faced with issue. Going to dig into it ASAP.

I'm having the same issue -- any headway on a resolution?

@tombh, @dphase
Hi, guys. Can you share with me your examples to help me reproduce it?

This is what I've been trying it on https://github.com/tombh/human-computer/blob/master/api/api.rb


Should LocalAuthStore use globalThis.localStorage instead of window.localStorage?

Right now, LocalAuthStore.js tests for window.localStorage before using localStorage.  This means it's not working with, for instance, the node-localstorage polyfill for node.js because that polyfill attaches localStorage to global.
Would it be better to use globalThis instead or is there a reason that the implementation requires an actual window object?

No. It is better to remain with window as it is safer in case the user uses the library for regular users auth in a server context, eg. JS SSR (see also the note about Deno since the last time I tested there was window global object):

NB! Deno also supports LocalStorage but keep in mind that, unlike in browsers where the client is the only user, by default Deno LocalStorage will be shared by all clients making requests to your server!


Vulnerability roundup 97: grocy-2.7.1: 1 advisory [5.4]

search, files

[ ] CVE-2020-25454 CVSSv3=5.4 (nixos-20.09, nixos-unstable)

Scanned versions: nixos-20.09: 50c8d1e0deb; nixos-unstable: 83cbad92d73.
Cc @ma27

See also: #102794

Can be closed along with #102794.

Can be closed along with #102794.


Terragrunt doesn't show messages when waiting for console input

Hello,
I found issue in terragrunt v0.33.2, when it waits for console input it waits, but does not show any messages before, take a look on log:
$ terragrunt run-all plan
INFO[0000] Stack at /infrastructure-reference/prod:
  => Module /infrastructure-reference/prod/_global/_global/monitoring/budget (excluded: false, dependencies: [])
  => Module /infrastructure-reference/prod/eu-west-1/prod/networking/vpc (excluded: false, dependencies: [])
WARN[0000] No double-slash (//) found in source URL /binbashar/cost-budget/aws. Relative paths in downloaded Terraform code may not work.  prefix=[/infrastructure-reference/prod/_global/_global/monitoring/budget]
WARN[0000] No double-slash (//) found in source URL /terraform-aws-modules/vpc/aws. Relative paths in downloaded Terraform code may not work.  prefix=[/infrastructure-reference/prod/eu-west-1/prod/networking/vpc]

At it waits and waits at this moment, until I will not press n or enter, then it shows a message it was waiting for any input:
ERRO[0080] Module /infrastructure-reference/prod/_global/_global/monitoring/budget has finished with an error: NoSuchBucket: The specified bucket does not exist
	status code: 404, request id: JJ7QFCP1NASSD9GA, host id: nMeUW1Fumhv4yK31cT8XREDaB3BPgUmzZ7jJh9C5yzpxlKQITlfz82tBDCJV9OGcMcc01sxfvzk=  prefix=[/infrastructure-reference/prod/_global/_global/monitoring/budget]

ERRO[0093] Module /infrastructure-reference/prod/eu-west-1/prod/networking/vpc has finished with an error: NoSuchBucket: The specified bucket does not exist
	status code: 404, request id: 4SE7QQJQZQHVVJ8G, host id: AlvIJUZ5+09xWF+bsGIeCHQ37pJC0pa77/xXrcw3WzY1z4XZlAKb8PnGpeVUaW5456Gv101R/50=  prefix=[/infrastructure-reference/prod/eu-west-1/prod/networking/vpc]
INFO[0093] Remote state S3 bucket terraform-state-cpanda does not exist or you don't have permissions to access it. Would you like Terragrunt to create it? (y/n)
INFO[0093] Remote state S3 bucket terraform-state-cpanda does not exist or you don't have permissions to access it. Would you like Terragrunt to create it? (y/n)

Ubuntu 20.04 amd64, shell: zsh (issue present also in bash)

Hello, can be shared any example code where this issue happens?
I tried on this repository:
https://github.com/denis256/terragrunt-test-1815
and it works fine:
$ terragrunt run-all plan

INFO[0000] Stack at /tmp/1842/terragrunt-test-1815:
  => Module /tmp/1842/terragrunt-test-1815/applications/gateway/app1 (excluded: false, dependencies: [/tmp/1842/terragrunt-test-1815/shared/service-discovery-core])
  => Module /tmp/1842/terragrunt-test-1815/applications/gateway/app2 (excluded: false, dependencies: [/tmp/1842/terragrunt-test-1815/shared/service-discovery-core])
  => Module /tmp/1842/terragrunt-test-1815/shared/service-discovery-core (excluded: false, dependencies: [/tmp/1842/terragrunt-test-1815/shared/vpc])
  => Module /tmp/1842/terragrunt-test-1815/shared/vpc (excluded: false, dependencies: [])

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # local_file.config_file will be created
  + resource "local_file" "config_file" {
      + content              = "vpc"
      + directory_permission = "0777"
      + file_permission      = "0777"
      + filename             = "./vpc.txt"
      + id                   = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.
....

https://github.com/dkossako/infra-ref

Yes, the same issue appears for me, will try to identify the root cause

This should now be fixed in https://github.com/gruntwork-io/terragrunt/releases/tag/v0.34.3

This bug is still present for me on 0.35.6

Hi @barrydobson, do you have an example repository where this issue appears?
On test repository confirmation dialogs are printed out:


should @agentic/core be a dependency (not a devDependency)?

I noticed that the @agentic/core package was declared in devDependencies instead of dependencies (https://github.com/transitive-bullshit/agentic/blob/main/packages/calculator/package.json#L42). I wonder if this is by design or just an oversight. Currently one has to install @agentic/core and @agenict/toolname to make things work.

If you're using a single tool, I agree it's annoying to have to install @agentic/core, @agentic/toolname, and zod just to use one tool.
This is working as currently intended, though, since I've found that most of the time I want to use multiple tools and not have @agentic/core be shared as transitive deps multiple-times (or possibly have multiple different versions).
So @agentic/core is a peer dep of all agentic packages and is included locally as a dev dep so they have access to types.
The import situation is a little more complex than I would like, so I'm definitely open to feedback, especially for GenAIScript's use case.

Fair enough. The fix is to always install @agentic/core and @agentic/tool alongside. Maybe the docs should mention that.

Fair enough. The fix is to always install @agentic/core and @agentic/tool alongside. Maybe the docs should mention that.

Will update the tool docs shortly; I agree it is def more confusing that I'd like.
Thanks!

[like]  Peli de Halleux reacted to your message:

From: Travis Fischer @.>
Sent: Monday, August 26, 2024 9:43:54 PM
To: transitive-bullshit/agentic @.>
Cc: Author @.>; Comment @.>
Subject: Re: [transitive-bullshit/agentic] should @agentic/core be a dependency (not a devDependency)? (Issue #663)
Fair enough. The fix is to always install @agentic/core and @agentic/tool alongside. Maybe the docs should mention that.
Will update the tool docs shortly; I agree it is def more confusing that I'd like.
Thanks!
—
Reply to this email directly, view it on GitHubhttps://github.com/transitive-bullshit/agentic/issues/663#issuecomment-2311152934 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA73QKLHBURYU6K5XS326ODZTOORVBFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOJIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVE2TOMZWGMYTENRRQKSHI6LQMWSWS43TOVS2K5TBNR2WLKRSGQ4DMOJYGEZDSMNHORZGSZ3HMVZKMY3SMVQXIZI.
You are receiving this email because you authored the thread.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I even wrote a blog post manually (i know, so 2010...) about the added support. https://microsoft.github.io/genaiscript/blog/support-for-agentic-tools/


Add blocking interface

Related issues and pull requests

Closes #82

Description
It'll be a slight pain to keep the blocking interface up-to-date with the non-blocking, but that's what we have to do I guess.
Checklist

[x] Add tests
[x] Add docs
[x] Update CHANGELOG

Codecov Report
Patch coverage: 95.00% and project coverage change: +0.74% :tada:

Comparison is base (e2b8415) 79.25% compared to head (f51e10c) 80.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   79.25%   80.00%   +0.74%
==========================================
  Files          15       16       +1
  Lines         863      885      +22
==========================================
+ Hits          684      708      +24
+ Misses        179      177       -2

Files Changed
Coverage Δ

src/stac_asset/types.py
75.00% <75.00%> (ø)

src/stac_asset/_cli.py
82.46% <88.88%> (+0.53%)
:arrow_up:

src/stac_asset/__init__.py
100.00% <100.00%> (ø)

src/stac_asset/_functions.py
91.11% <100.00%> (+0.80%)
:arrow_up:

src/stac_asset/blocking.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Added Kahns_topological_sort_algorithm.cpp

Kahn's algorithms work by choosing vertices in the same order as the eventual topological sort. First, find a list of "start nodes" which have no incoming edges and insert them into a set S; at least one such node must exist in a non-empty acyclic graph.
for example:

The above graph has many valid topological ordering of vertices like,
7   5   3   1   4   2   0   6
7   5   1   2   3   4   0   6
5   7   3   1   0   2   6   4
3   5   7   0   1   2   6   4
5   7   3   0   1   4   6   2
7   5   1   3   4   0   6   2
5   7   1   2   3   0   6   4
3   7   0   5   1   4   2   6

Hey thanks, i will work on it.


[CELEBORN-1507] Prevent invalid Filegroups from being used

What changes were proposed in this pull request?
Prevent invalid Filegroups from being used, eventually throwing FetchFailedException
Why are the changes needed?
#2531 introduced a new feature regarding Filegroups. For multiple tasks belonging to the same shuffleKey, only one of them will actively fetch, and the others will use the cached results in memory. If the Task that actively fetches the Filegroups is killed for some reason (such as another attempt succeeded), it will cause other tasks to obtain invalid Filegroups, eventually leading to stage retry.

Does this PR introduce any user-facing change?
NO
How was this patch tested?
Internal test.

This will happen because shuffle client implementation is singleton.

This will happen because shuffle client implementation is singleton.

The singleton pattern does not cause this problem. The core issue is that the task that fetches Filegroups was killed, and it placed invalid Filegroups in the reduceFileGroupsMap, which led to other tasks obtaining invalid Filegroups.

This will happen because shuffle client implementation is singleton.

The singleton pattern does not cause this problem. The core issue is that the task that fetches Filegroups was killed, and it placed invalid Filegroups in the reduceFileGroupsMap, which led to other tasks obtaining invalid Filegroups.

Your spark stage retried because of this config spark.task.maxFailures. The default value is 4, meaning the stage will retry if 4 tasks fail.

This will happen because shuffle client implementation is singleton.

The singleton pattern does not cause this problem. The core issue is that the task that fetches Filegroups was killed, and it placed invalid Filegroups in the reduceFileGroupsMap, which led to other tasks obtaining invalid Filegroups.

Your spark stage retried because of this config spark.task.maxFailures. The default value is 4, meaning the stage will retry if 4 tasks fail.

You're right.

PR #2531 did change the semanteme of ShuffleClientImpl. Thanks. I provided a better implementation.

@FMX There are a few minor modifications. Review it again. Thanks.

./dev/reformat can fix the style issues.

Merge to main(v0.6.0) and branch-0.5(v0.5.1) and branch-0.4(v0.4.3)


torch-directml : RuntimeError on torch.cumsum with bool input

I found a problem similar to #343.
torch.cumsum fails when <tensor>.dtype is torch.bool
Code
import torch
import torch_directml

def main():
    device = torch_directml.device()

    tensor = torch.tensor([0, 1, 0, 1], dtype=torch.bool, device=device)
    result = torch.cumsum(tensor, dim=0)
    print(f'{result=}')

if __name__ == '__main__':
    main()

Result
Traceback (most recent call last):
  File "path\to\cumsum_error.py", line 14, in <module>
    main()
  File "path\to\cumsum_error.py", line 8, in main
    result = torch.cumsum(tensor, dim=0)
RuntimeError

Testing Environments

OS: Windows11 22H2
Python: 3.10.8
PyTorch: 1.13.1
torch-directml: 0.1.13.dev221216
GPU: Radeon VII
Radeon Driver: 22.Q4

Hi @reid3333, thanks for bringing this up! cumsum currently doesn't support bool inputs, as you can see in our Operator Roadmap. We'll add support for bool to our backlog.

Thank you! I have confirmed that it worked fine.


I can not publish to IIS

In visual studio it works perfectly, but when I try to publish to IIS it does not work. Displays the following error: ASP.NET: HTTP Error 500.19 - Internal Server Error 0x8007000d
I researched in several places but I could not solve.

Was this with the base repo? Did you ever solve this? Haven't ran into this one before.

Unfortunately I could not get IIS to work with this project. I believe the problem may be some iss incopatibility with the server side redenring feature. Following this tutorial https://stu.ratcliffe.io/2017/07/20/vuejs-serverside-rendering-with-aspnet-core, everything worked out right up to the Session Server-Side Rendering session. If I configure it as it is in the tutorial to Server-Side Rendering, no iis does not work. I think it may be the same problem as your project.

https://github.com/MarkPieszak/aspnetcore-Vue-starter/commit/ef6ce477b5649695e45d41922925ba4d9e484f48
It could be the above asp-prerender-module tag that needs to be completely removed, as we're not doing SSR here. Can you give that a shot and see if it works?

This should be fine now, let me know if it's not working!


Update openshift-memory-example to work with tags query language

The included dashboard didn't work on newer versions of grafana.  These changes enable "tagsQl" for each target.  This made the dashboard work in grafana 4.3.2

Thanks @mjrsnyder


Flaky test TestZset ZRANGEBYSCORE_fuzzy_test

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
master
Minimal reproduce step
--- FAIL: TestZset (6.77s)
    --- FAIL: TestZset/ZRANGEBYSCORE_fuzzy_test,_100_ranges_in_100_element_sorted_set_-_skiplist (1.45s)
        assertions.go:37:
            	Error Trace:	/home/runner/work/kvrocks/kvrocks/tests/gocase/unit/type/zset/assertions.go:37
            	            				/home/runner/work/kvrocks/kvrocks/tests/gocase/unit/type/zset/zset_test.go:1330
            	Error:      	"0.8835915986346754" is not less than or equal to "0.88359158989[119](https://github.com/apache/kvrocks/actions/runs/5465748637/jobs/9950010260#step:12:120)87"
            	Test:       	TestZset/ZRANGEBYSCORE_fuzzy_test,_100_ranges_in_100_element_sorted_set_-_skiplist
FAIL

What did you expect to see?
Test passed.
What did you see instead?
Test failed.
Anything Else?
This seems a bug on float precision. I don't think it's about test suite precision but the server handling on precision.
cc @git-hulk @mwish
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

It may have caused this problem about double and float conversion  from initial observations if the client executes right.
https://github.com/apache/kvrocks/blob/7e23c0bea1eb3d9c561af2dc110ebb803e0f32fe/src/types/redis_zset.cc#L517-L534

@tisonkun Yes, it's a precision issue caused by the strtod which parsed the string "0.88359158989" as "0.88359158988999997". But Redis also has this issue, so I think it would be good to fix the test case only.
❯ redis-cli
<IP_ADDRESS>:6379> zadd z 0.88359158989 k1
(integer) 1
<IP_ADDRESS>:6379> zrange z 0 1 withscores
1) "k1"
2) "0.88359158988999997"


Use GCD instead of deprecated OS level atomic API

Adding concurrency handling was a good call in #341. However, opting for GCD is always better because speed is not always the factor to measure performance. Resource management such as memory and CPU is fine tuned with GCD. For example, OS level API's can use 1000+% CPU while GCD will make sure it doesn't go too far over 100%. In the GCD implementation provided here, concurrent reads are happening for fast performance while reading, but a barrier is placed around the writes so no reads or writes can occur during a write. Also OSAtomicTestAndSet seems to be deprecated.
I added a link in the Synchronized utility for reference in case anyone in the future has questions about it or plan to change it, but I can remove it if you like. I've also added unit tests around the synchronization itself, but will a low number to not hold up the unit tests.

@basememara Could you provide an example run of performance tests before & after this change?

Is it possible to keep the previous API?
isDispatching.value = false
// instead of
isDispatching.value { $0 = false }

As far as I know it is not possible because it needs to be in a closure so it gets passed into the queue.

@mjarvis good call, let me think of a way to hammer ReSwift in a unit test

@basememara There is a very basic dispatch performance test included in project in ReSwiftTests/PerformanceTests.swift that may be sufficient for at least the simple time-based comparison.

@basememara There is a very basic dispatch performance test included in project in ReSwiftTests/PerformanceTests.swift that may be sufficient for at least the simple time-based comparison.

Awesome thx for pointing that out.
The before and after performance is negligible.. I even watched the CPU and memory and they were identical. Both pegged at 100%; surprisingly the OSAtomicTestAndClear didn't go above 100% like its OS counterparts go all the way above 1000%. The GCD was slightly better at 0.792s and OSAtomicTestAndClear was at 0.826, but nothing worth changing for and I'm sure different conditions will be too close to call any a winner.
So the only thing this PR buys us is using GCD over low level OS API's.
Before with OSAtomicTestAndClear:

After with GCD:

If performance is equal or better I'm in favor of changing it for the higher level API. 👏

I agree as well. Lets get a changelog entry and then once CI is passing we can merge this.

@basememara I know dealing with all the swift + Xcode variations can be a bit awkward. Let us know if you'd prefer someone else handle clearing that up.

Oh phew that would be really amazing pls! I gave a few attempts and I think I'm polluting the commits.

Don't worry! We're squashing anyway :) The change to a higher-level API sounds great. Another cool thing to ship with the new release once Xcode 12 is finally out. 🎉


Plotly charts

Hello, this is not an issue per say, but more of suggestion to support Plotly graphs. I know recently you integrated graphs of type echarts. Since our backend app (LLM) produces Plotly graphs I was wondering if modelscope-studio can support plotly graphs.
In mean time, here is how I did it using custom_components :

app_plotly_bar.py
import gradio as gr
import modelscope_studio as mgr
import os

import plotly.express as px
import pandas as pd

# Sample data
df = pd.DataFrame(dict(
    group = ["A", "B", "C", "D", "E"],
    value = [14, 12, 8, 10, 16]))

fig = px.bar(df, x = 'group', y = 'value',
             color = 'group')
#fig.show()

#generate json of plotly Figure
json_plotly= fig.to_json()

with open(os.path.join(os.path.dirname(__file__), "./chart_plotly.js"), "r") as f:
    chart_js_plotly = f.read()

custom_components_plotly = {
    "chart-plotly": {
        "props": ["options"],
        "js": chart_js_plotly,
    }
}

conversation = [[
    None, {
        "text": f"""<chart-plotly options='{json_plotly}'></chart-plotly>"""
    }
]]

with gr.Blocks() as demo:
    chatbot = mgr.Chatbot(
        value=conversation,
        height=600,
        flushing=False,
        custom_components=custom_components_plotly)
demo.queue().launch()

chart_plotly.js
(props, cc, { el }) => {
    el.innerHTML = ''
    const render = () => {
      const options = JSON.parse(props.options)
      el.style.height = '500px'
      el.style.width = '700px'
      Plotly.newPlot(el, options.data, options.layout)
    }
    if (!document.querySelector('plotly-script')) {
      const script = document.createElement('script')
      script.src =
        'https://cdn.plot.ly/plotly-2.30.1.min.js'
      script.id = 'plotly-script'
      script.onload = render
      document.head.appendChild(script)
    } else {
      render()
    }
  }

@liwalayouni Thank you for your suggestion again! But for now we are not considering integrating more graph libraries, Instead we prefer developers to use custom_components to implement more custom features as you did.
By the way, I'm sorry I made a mistake before, the sample code document.querySelector('plotly-script') should be replaced with document.querySelector('#plotly-script') to capture the cache condition, hope this helps!

thanks @Col0ring for your reply and for flagging the error :)