Datetime displaying "March" as February

The bug
Shows "March" as February
Using this code in the interface:
<View style="display: grid; ">
        <Text name="fields"/>
        <Choices name="fields_choice" toName="fields" showInLine="true" choice="multiple">
            <Choice value="Date"/>
        </Choices>
    </View>

    <View style="display: grid; " whenTagName="fields_choice" whenChoiceValue="Date" visibleWhen="choice-selected">
        <Header value="Date"/>
        <DateTime name="date" only="month,year" min="2020" max="2030"/>

Screenshots

Environment:

Label Studio Version 1.6.0

Hi! Thanks, that's a good catch! This happens on the last days of every month except February, because it tries to combine current day (like 31) and every month (like 31th of February) which leads to switch month and date on February. Fixed in LSF and will be merged soon.


es-internal-lb was not found

Deploying to a new resource group using an existing Vnet fails
es-internal-lb was not found. Please make sure that the referenced resource exists, and that both resources are in the same region

Hey @MedAnd

How are you deploying? Azure Marketplace? From this repository (if so, which release tag)?
Is the new resource group in the same region as the VNet?
Is the es-internal-lb in the same region as the VNet?
Does the subnet on the VNet to which the deployed resources will be attached have sufficient addresses for all resources?
Can you provide the deployment log?

If you can provide a small succinct example that reproduces the issue, it will help to diagnose what the issue is much quicker.
Thanks!

Hi @russcam,

So I was deploying using the deploy button at the bottom of the page, which is a custom template from Elastic but still within the Azure portal experience. I assume the button uses the latest github release?
Yes
The es-internal-lb did not exist but I wanted it to be in the same region. Assume the json template creates it.
The subnet did not exist, I assumed the template would create it. Once I created the subnet though the deployment is now progressing.

So in summary the it seems the subnet must exist while the load balancer will be created, the template will not create it... wonder if the docs or template could be made a little more explicit, stating which resources get auto created & which must exist?

Yes, subnets for the cluster and for Application Gateway (if choosing gateway for load balancing) must exist already when deploying into an existing VNet. The template does not make any changes to an existing VNet.
For the resources in a resource group, they can be deployed to the same region as the resource group which is the default, or to another region where those resources are available for deployment.
I've updated the README to be more explicit 👍


Relocate TCP failure error code into TCP stats object

What does this PR do?

Moves retransmits into tcp_stats_t
Moves failure_reason into tcp_stats_t
Resizes failure_reason to u16 so it fits into the existing padding, thus not changing the overall size of tcp_stats_t and conn_t. Only three error codes are used, so no concerns about the reduced size.
Removes separate perf/ring buffer for failed connections because that information is now contained on the connection object
Reorders fields of conn_t so that conn_stats is aligned to a cacheline boundary.

Motivation

Simplify adding failure information to connections. This removes a race condition between failed and closed connection perf/ring buffers.
Maintain size of conn_t so that perf buffer batching (coming in future PR) can remain a configuration option.

Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


Added the older z13 to this location

Adding z13 workflow from the z/OS Downloads web page, to keep it more consolidated here.


EEI: Split u256 into bytes32+u256

Resolves https://github.com/ewasm/design/pull/105#discussion_r212810641

also needs a corresponding issue opened on Hera if this is merged.

Hera already does this.


ci: add matrix configuration to test on windows/macos/linux and different python versions

Closes #15
Original Proof of Concept Development made in https://github.com/JonasPammer/cookiecutter-pypackage-test/pull/11

LGTM;
cookiecutter ci matches actual cookie ci, even going one step further to test setuptools bdist-wheel creation on each matrix (next to tox already making a sdist/gz through setup.py currently) to ensure change in packaging does not break any pip
the cookiecutter ci does not have additional deadsnakes devel tests as it adds third party step thats also unecessary because the  source code examples included are basic 3.x
the cookiecutter ci does only test pypy for ubuntu as to not need to change basic cookiecutter ci template (with source and ### sections ettc) just for it


#33 Added a file on ComputerNetworks.md

I kindly request your formal review of the content contained within this file, with reference to issue #33 .
Thank You😊

Awesome Work @rishirajm007 ✅


NETOBSERV-1458: reduce loki streams, index FlowLayer

cc @msherif1234 @nathan-weinberg  : I would like to compare perf with this set of loki index, against the previous runs and also against this other PR https://github.com/netobserv/network-observability-operator/pull/552

Some frontend perf test --
I've been following the same steps that I ran previously and described here: https://github.com/netobserv/network-observability-operator/pull/409#issuecomment-1709875727
---------------------
1st RUN: main
---------------------
streams: ~2K
---------------------
min: 171ms
max: 393ms
avg: ~210ms
=====================
---------------------
2nd RUN: 88ec5d6
Remove some labels
---------------------
streams: ~1.2K
---------------------
min: 1321ms
max: 2784ms
avg: ~1800ms
=====================
---------------------
3rd RUN: 405439d
New indexes
---------------------
streams: ~1.3K
---------------------
min: 202ms
max: 399ms
avg: ~210ms
=====================
---------------------
4th RUN: local build
Only removing Duplicate
---------------------
streams: ~1.3K
---------------------
min: 253ms
max: 493ms
avg: ~300ms
=====================

To summarize: it's clear that the labels introduced in 1.5 caused an increased number of streams (RUN 1). We can remove some labels to reduce that number:

Removing both Duplicate and Src/DstType (RUN 2), like it was in 1.4, degrades too much the query performance (x10 slower)
Removing only Duplicate (RUN 4) makes us retrieve almost the same number of streams than previously, while keeping pretty good query performance
Removing Duplicate and Adding FlowLayer (RUN 3 / this PR) is comparable to RUN 4 for streams but with a slightly better query performance

@jotak ack will test this! see table in NETOBSERV-1470 for comparisons

/label qe-approved

/approve


Issue with flipDQI command

I am not able to get the flipDQI function to work for creating a batch file of DQI codes to enter into the database.  Is this functionality something that is still in progress or am I just doing something wrong?  An example and resulting error(s) are included for reference.  There are two error messages that I have received after trying the command on different occasions.
flipDQI('04043237','01300628_01','00608',"R",DSN = "NWISMI", env.db = "01", qa.db = "02", keepRecordNo = FALSE)
error #1
Error in flipDQI("04043237", "01300628_01", "00608", "R", DSN = "NWISMI",  :
unused arguments ("04043237", "01300628_01", "00608", "R", DSN = "NWISMI", env.db = "01", qa.db = "02", keepRecordNo = FALSE)
error #2
Error: could not find function "flipDQI"

Whoops! I did not mean for the function to be exported and made available. This is still a work in progress

Ah I see, it was not made available, but the documentation for it was. Thanks for the issue report

When I make it available, you also have some issues with how you are calling the function. It should be like this:
STAIDS <- c("04043237")
records <- c("01300628_01")
parameters <- c("00608")
dqiCodes <- c("R")

flipDQI(STAIDS = STAIDS,
        records = records,
        parameter = parameters,
        dqiCodes = dqiCodes,
        DSN = "NWISMI",
        env.db = "01",
        qa.db = "02",
        keepRecordNo = FALSE)

The STAIDS, records, parameters, and dqiCodes arguments need to be vectors

Cool thanks for clarifying and apologies for jumping the gun on that.  It looks pretty promising for saving some time in creating those batch files.  Thanks for the quick response and for all your work on this code. It is a real benefit to the review process.

Sorry didn't mean to close this.

@cjhoard
Checkout this new experimental version that allows for changing DQI codes via batch files
BE CAREFUL! This is in early testing, do not push in the files without verify they are OK
WQReview 2.0


New version: SAPIEN.PowerShellStudio version <IP_ADDRESS>

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.5 schema?

Microsoft Reviewers: Open in CodeFlow

Disk full: Out of disk space -- Volume: 'C:'; required space: 6,555,376 KB; available space: 3,602,048 KB.  Free some disk space and retry.

Automatic Validation ended with:

2023-12-14 23:37:18.342 [FAIL] D:\a\1\s\src\AppInstallerRepositoryCore\IconExtraction.cpp(113)\WinGetUtil.dll!00007FFFF3FC97A6: (caller: 00007FFFF3FCA1C2) Exception(1) tid(1114) 800700C1 %1 is not a valid Win32 application.
2023-12-14 23:37:18.369 [FAIL] D:\a\1\s\src\AppInstallerRepositoryCore\IconExtraction.cpp(212)\WinGetUtil.dll!00007FFFF41175F5: (caller: 00007FFFF3FCA1C2) LogHr(1) tid(1114) 800700C1 %1 is not a valid Win32 application.     Msg:[D:\a\1\s\src\AppInstallerRepositoryCore\IconExtraction.cpp(113)\WinGetUtil.dll!00007FFFF3FC97A6: (caller: 00007FFFF3FCA1C2) Exception(1) tid(1114) 800700C1 %1 is not a valid Win32 application.  Installation failed with exit code -1978335226
2023-12-14 23:37:17.062 [CLI ] ShellExecute installer failed: 1603 LookupUserGroupFromRid() FAILED LookupAccountSidW() FAILED LookupUserGroupFromRidSDDL() FAILED LookupAliasFromRid() FAILED Property(S): ErrorDialog = ErrorDlg MSI (s) (34:84) [23:37:11:671]: Product: PowerShell Studio 2023 -- Installation failed. MSI (s) (34:84) [23:37:11:671]: Windows Installer installed the product. Product Name: PowerShell Studio 2023. Product Version: <IP_ADDRESS>. Product Language: 1033. Manufacturer: SAPIEN Technologies, Inc.. Installation success or error status: 1603.

Manual Validation ended with:

12:55:07 PM:
2023-12-15 12:55:06.097 [CORE] Download request failed. Returned status: 403

(Automated response - build 485.) Manual Validation ended with:

12:55:07 PM:
2023-12-15 12:55:06.097 [CORE] Download request failed. Returned status: 403

Verify:

/AzurePipelines run

Automatic Validation ended with:

2023-12-21 04:30:16.620 [FAIL] D:\a\1\s\src\AppInstallerRepositoryCore\IconExtraction.cpp(113)\WinGetUtil.dll!00007FFEEA818BA0: (caller: 00007FFEEA8195BF) Exception(1) tid(60c) 800700C1 %1 is not a valid Win32 application.
2023-12-21 04:30:16.656 [FAIL] D:\a\1\s\src\AppInstallerRepositoryCore\IconExtraction.cpp(212)\WinGetUtil.dll!00007FFEEA963C65: (caller: 00007FFEEA8195BF) LogHr(1) tid(60c) 800700C1 %1 is not a valid Win32 application.     Msg:[D:\a\1\s\src\AppInstallerRepositoryCore\IconExtraction.cpp(113)\WinGetUtil.dll!00007FFEEA818BA0: (caller: 00007FFEEA8195BF) Exception(1) tid(60c) 800700C1 %1 is not a valid Win32 application.  Installation failed with exit code -1978335226
2023-12-21 04:30:14.385 [CLI ] ShellExecute installer failed:<PHONE_NUMBER> LookupUserGroupFromRid() FAILED LookupAccountSidW() FAILED LookupUserGroupFromRidSDDL() FAILED LookupAliasFromRid() FAILED Property(S): ErrorDialog = ErrorDlg MSI (s) (10:DC) [04:30:06:419]: Windows Installer installed the product. Product Name: PowerShell Studio 2023. Product Version: <IP_ADDRESS>. Product Language: 1033. Manufacturer: SAPIEN Technologies, Inc.. Installation success or error status: 0.

(Automated response - build 490.)

@wingetbot waivers Add Validation-Shell-Execute


Variables no "{money}"

Describe the bug
Do not have "(money)" Variables
Screenshots

Version

Minecraft: 1.15.2
Spigot/Bukkit: 1.15.2
BetterGUI: 1.9
addons:
BungeeLink: 1.0
CommandOverride: 1.1
NBT-Support: 1.1

Join my server and find the VaultBridge addon from the main-addon channel


docs(popover, progresscircle, radio, rating, sidenav): site docs to storybook

Description
This continues the migration work to move the documentation from the deprecated docs site to Storybook, covering the components Popover, Radio, Rating, and Sidenav. Variants shown on the docs site for these components have been added to Storybook as new stories if they did not already exist. No custom MDX files were needed for these components.
Component specific changes and notes:

Popover

Docs notes have been moved to relevant stories where possible, and many have been reworded to make them easier to understand. All positions are within one Docs story instead of being spread out amongst different examples.
Adds test coverage of dialog style popover found in docs (and SWC)

Radio

Separates disabled, read-only, and emphasized options out into their own Docs stories for the user's view, as single radios would not have those options mixed in a group of radios.
Also includes a connected fix for Field group, to include a missing role="radiogroup" and to make use of aria-readonly for radios.

Rating

Minor cleanup; adjusts some stories and controls to improve documentation and make sure that any docs site documentation is represented.
Fix: Disabled in Storybook was not showing filled stars

Sidenav

Migrates some of the story descriptions from the docs page, and adjusts story content to clarify what is being displayed
Adds additional description to document disabled and selected.
Fixes some logic for the display of icons and documents this better. Icons should now appear on all first level nav items when the associated control is true.

Other overall Storybook updates:

feat: maintain unique name and id args in Sizes() ArgGrid
Radios displayed with the Sizes() template were no longer grouped and showing a selected radio within in group, because they all had the same name. This addition to the ArgGrid() function makes sure that the id and name args used for attributes have a unique string appended when the template is rendered multiple times within the grid.

How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps

[x] Popover - includes all necessary information compared to the docs site
[x] Radio - includes all necessary information compared to the docs site
[x] Rating - includes all necessary information compared to the docs site
[ ] Rating fix - disabled shows filled stars
[ ] Sidenav - includes all necessary information compared to the docs site

Regression testing
Some expected VRT changes:

Additional first level icons appearing in sidenav
Fixed display of disabled stars in rating

Validate:

The documentation pages for at least two other components are still loading, including:

[x] The pages render correctly, are accessible, and are responsive.

If components have been modified, VRTs have been run on this branch:

[ ] VRTs have been run and looked at.
[ ] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

[x] I have read the contribution guidelines.
[x] I have updated relevant storybook stories and templates.
[ ] I have tested these changes in Windows High Contrast mode.
[x] If my change impacts other components, I have tested to make sure they don't break.
[x] If my change impacts documentation, I have updated the documentation accordingly.
[ ] ✨ This pull request is ready to merge. ✨

Thanks for the thorough reviews! I'm almost done resolving all of the comments here, after that big rebase. I'll re-request a review once they're finished.
To your comments Rise:

Popover
I occasionally saw a hairline/border on the tip within the tip story (not on Docs), but it wasn't consistent. It would disappear sometimes, and I only saw it on my monitor (not my laptop screen). I didn't notice this with the same story on prod. It might be worth investigating and maybe making a bug card for?

I'll make a bug card for that. I think it's reproducible if you resize the browser height; it happens on every other (odd?) pixel?

Popover Controls

There are no controls for nested - this is intentional, right? Would we want to remove controls for the “Positioning options” story too? Do we want to keep that story (with the grid view) in the sidebar? It looks ✨amazing✨ but it keeps crashing my browser tab if I open the story (however it works fine in the Docs page). Maybe keep it on the Docs page and for Chromatic?

I've removed it from the sidebar, since you were having that performance issue. It's probably a lot faster and less problematic now that it's only loading text content and not a Menu in each one, but I think keeping it off the sidebar is probably best.

Rating
This was probably just about the first time I’ve ever looked at this component, and I didn’t realize that if there is a rating selected, there’s an indicator only under the selected (and not disabled/read only) rating if the component is hovered. I think the way the docs site has the selected/not selected variants communicates in a useful way, and Storybook would benefit from having some of those selected/unselected variants, for example Default and Default selected, Disabled and Disabled selected.

I also just realized that the underline not appearing on the star you hover is a feature and not a bug (highlighting the currently selected star value).
This component definitely needs extra coverage for the hovered with underline state, and could have all its stories combined into one Chromatic-only template, though we were trying to exclude that refactoring from this work, which is why I kept this as a light touch. I've added a todo about condensing and increasing coverage. I don't think we need to show empty stars and some filled stars as separate stories as it's a bit duplicative, if you were suggesting that?
Looking at this did surface a bug in our template that I've fixed in the latest commit; disabled was not showing filled stars! Two classes were being excluded for disabled and readonly that shouldn't have been. Also of note, there is an existing bug related to the hovering in the backlog, CSS-735.

Side nav
"Make sure to use the appropriate variant for the context and user needs. Don’t mix behavior, styles, or variations together in a single navigation menu." --- Do you think this is important to retain from the docs site? I didn’t see it communicated in Storybook.

I left this out, as it doesn't seem very helpful and is somewhat inaccurate in our context. For example, it's saying not to mix variations, but you can show headings while also showing icons. Where this sentence originated is already covered with more explanation in the guidelines.

I've finished reworking these changes after the rebase with the changes to main. Popover required a bit of work with the stories and templates to get everything displaying again.

The sizing decorator is no longer used, and the Sizes() utility is used instead.
I included one small change to the Sizes ArgGrid to help fix the issue with radio buttons having the same name within the Sizing example. Previously this was causing only one radio to be selected at a time, instead of having one selected within each size group. This also makes sure label for attributes match up with unique IDs.
I found and fixed another issue with the Sidenav logic around icon. Icons should now appear on all first level nav items when the associated control is true.


AssertThatTypeDoesNotMatchTest.java:31: Improve test...

The puzzle 47-de66b5c3 from #47 has to be resolved:
https://github.com/pragmatic-objects/oo-atom/blob/25169c70a8b3079415f0a4e52c7c9933eff8448d/atom-basis/src/test/java/com/pragmaticobjects/oo/atom/codegen/bytebuddy/matchers/AssertThatTypeDoesNotMatchTest.java#L31-L31
The puzzle was created by Kapralov Sergey on 04-Jun-18.
Estimate: 15 minutes,
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@skapral please pay attention to this new issue.


Extending the keyboard usage to element selection and modification

I would like to expand upon @frantic's proposal on #3100 and also suggest that the keyboard usage could be extended to directly select and modify elements in the canvas as well. While we all use Excalidraw to precisely... draw, I think there is room for a great improvement if we are able to quickly point to elements we would like to work upon.
Evidently I'm in no position to say how you guys would implement this and neither if it is actually feasible, but if I'm allowed to give my two spoonfuls of ideas, you could try implementing it with a Alt key selector, similar to how Microsoft Office[obs] works. That way we don't mess with either existing tool shortcuts or the browser's, and we open a whole new space for creation.
An Amateur's Vision of a New Feature
Say we have some elements on our canvas:

By simply hitting the Alt key, the options for selection would show up (here I have cued your awesome approach to the colour shortcuts), from where the user would then press the corresponding key to select the element to change:

From there, the menu would also be entirely accessible with another key (and they would fit each element type accordingly):

So let's say I want to change the fill colour of the first rectangle to orange. In this configuration I would have to type sequentially Alt → 2 → b → g and voilà! We have even integrated the existing shortcut for colour change.
Dealing with how Users Arrange Their Canvases
Since Excalidraw drawings can become very messy to the point of not having enough keys for the existing elements, this feature could be further defined to take only visible elements into consideration. Let's say I have zoomed in and pressed the Alt key again:

Now only the elements which I'm supposedly interested in (since they are the only ones I'm looking at, after all!) make part of the possible selection.

Since this last element is a group of minor elements, Excalidraw could understand that I as a user would like to either select another individual element or modify the group as a whole, so let's allow for that:

This way I could either change all the stroke colours by sequencing Alt → 9 → e → s → w Or just the first bar through Alt → 9 → 4 → s → w. By not demanding a key to be pressed down to either initiate or execute the commands, the interface becomes simple to handle as if a user were just typing a document.

Evidently my mock-up does not take into considerations possible conflicts (such as when I want to change two characteristics of my element: should I strike a sequence and return to no element selected or allow for further key strokes in the lateral menu? What about Library elements?) that could deter users from experiencing a flow state. But I personally think it would be a neat feature to be added to Excalidraw which at first glance seems to blend in with the overall modus operandi of this excellent tool.
Hopefully this does not end up compromising the performance too much for you guys to consider adding it!
Obs: I so wish other software followed this design, it really speeds up operations without needing Alt, Ctrl, Shift or a combination of them held down on the keyboard. This makes it prone to user error when they are thinking what to actually press to activate the command.

Hi, we can leave it for now in case anyone will be up for it in the future. The backlog is lost as of now, we will likely do a big bulk cleanup at some point.


Wrong codeblocks font size

I'm not sure why. It seems that it's only on mobile phones.

https://stackoverflow.com/questions/5303263/fix-font-size-issue-on-mobile-safari-iphone-where-text-is-rendered-inconsisten


See if Shotcut can be opened via SSH

It appears that Shotcut can be run from the command line. If so, this would be a good extra step.

Turns out that it isn't as simple as running "shotcut" from the command line for me. This is because I installed a more recent Flatpak version that runs e.g. /usr/bin/flatpak --command=shotcut.
I might need to make this configurable.

Even that doesn't work. So, this will not be delivered.


Token-wise the same generalization?

Is Medusa1 model generalize token-wise the same as the base model w.o. medusa head?
I found change medusa choices will change the output.

We've figured out this problem by shrinking the medusa choices to only top-1 predictions, i.e., [(0), (0,0), (0,0,0), (0,0,0,0), (0,0,0,0,0)].
In such way, MHCA computation will get a bit-wise the same logits as the baseline wo medusa decoding.
Hope it helps for other people interested in bitwise the same decoding.

We've figured out this problem by shrinking the medusa choices to only top-1 predictions, i.e., [(0), (0,0), (0,0,0), (0,0,0,0), (0,0,0,0,0)].
In such way, MHCA computation will get a bit-wise the same logits as the baseline wo medusa decoding.
Hope it helps for other people interested in bitwise the same decoding.


enhancement request: Update the Violations list to look and feel like the Policy list

Is there an existing issue for this?

[X] I have searched the existing issues

Enhancement description
Update the look and feel of the Violations list to be as Policy list
🧑💻 Implementation
No response
Anything else?
No response

working on this


Add (optional) arbitrary region support with regionmask

Dear all,
If we allow people, as an optional dependency, to include the package "regionmask", we could easily allow for using arbitrary shapefiles, counties, etc.
https://regionmask.readthedocs.io/en/stable/
If you are interested, I should be able to add support for it.
Cheers
Pablo

Yes, sorry this got lost in my emails. Please proceed forward with this.
We do have filtering options already, so just make sure to consider these filtering options while you are coding this in.
https://melodies-monet.readthedocs.io/en/stable/appendix/yaml.html (search for filter_dict) which can be applied in the observations or in the data_proc section for plotting and statistical calculations.


AlwaysOnTop Appearance and Behavior options have no effect

Microsoft PowerToys version
0.60.1
Running as admin

[X] Yes

Area(s) with issue?
Always on Top
Steps to reproduce
Enable Always on Top
Change any option
Ctrl-Windows-T on a window

✔ Expected Behavior
Options are effective.
❌ Actual Behavior
Options are not effective.
Other Software
Windows 11

/reportbug

PowerToysReport_2022-07-25-22-46-29.zip

Issue still persists after a reboot?
/dup #19227


Update to Ra 2.0.7

Pull Request Test Coverage Report for Build 501

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 86.57%

Totals

Change from base Build 492:
-0.6%

Covered Lines:
1792

Relevant Lines:
2070

💛  - Coveralls

Pull Request Test Coverage Report for Build 501

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 86.57%

Totals

Change from base Build 492:
-0.6%

Covered Lines:
1792

Relevant Lines:
2070

💛  - Coveralls


Upgrade to django 4.2

According to the magnificant table of https://github.com/cookiecutter/cookiecutter-django/issues/4252 we are ready to update to Django 4.2.

We might want to waait for the next DRF version (3.15) which seems imminent now.

@browniebroke there is indeed a comment stating 4.2.1 is compatible. DRF is waiting for a release for several months now so hopefully it will be there soon.

@browniebroke It seems like DRF 3.14 supports Django 4.1, or at least definitely with 4.2 given auvipy's comment. I think it's safe to merge

Agree. I've since updated one of my projects using DRF and can confirm that it's fine!

We also need to update the config for django-upgrade:
https://github.com/cookiecutter/cookiecutter-django/blob/master/{{cookiecutter.project_slug}}/.pre-commit-config.yaml#L31

Thanks for your feedback @browniebroke


Add per-endpoint serializer selection via Content-Type Header

The new Xml/Json/Bson serializer adds a Content-Type header to the message. The old serializers now do as well. Make it so that the endpoint detects the serialization method used as the message is received, allowing it to be deserialized using the proper serializer. If a response is sent back to the source endpoint, use that same serializer to send it back so that it can be properly decoded by the originating system (which might support an older serializer).
NOTE: Assuming VersionOneXml if no content type is specified, and possibly do a check to see if it is binary as well.

Nice feature - did it make the cut?


Modus Table: emit row click event

Description
Emit a row click event when the user clicks a row (if the cell clicked is not editable)
References #2480
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?
Added a unit test, and added the event to storybook.
Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

@leosole-trimble I Aha! ticket was created for this item and a discussion has started in the comments.  https://modus.ideas.aha.io/ideas/MOD-I-95
It would be good to continue that discussion so they understand the full scope of the UX being considered here.


subtitles are hidden when player is resizing

Current Behavior:
If you change the player size (width or height) when subtitles are on by default, or when any other subtitles are on, subtitles are hidden.
Expected Behavior:
Is this behavior expected? If I want to display subtitles even after the size has been changed, is it possible and how can I achieve that?
Steps To Reproduce:

set player src
open captions
resize player

Environment:
@latest

i fix it by using memo(MyComponent)


this.skip(amount: number) or this.break()

new feature to allow advices to skip incoming advices and dispatch to the method directly
caching async request could have many operations, in order to separate concerns it would be nice that advices expose an api through control whole call stack like this.stop does but skipping some calls
@adviceThatChecksIfResourceAlreadyExistsInCache // this advice must skip incoming advices
@adviceThatPerformAnAjaxRequestToRetrieveSomeResource
@adviceThatStoresTheReceivedDataInCache
handleResponse(data) {
  // stuff
}

added in 032aa3f01bd372644d21416df8d704e63a73d3cc


Implementations using this library

Are there any implementations using this lib that you can use out of the box? I guess I'm looking for an implementation that would replace ./poly_pkt_fwd used in e.g. https://github.com/ttn-zh/ic880a-gateway.git

@kersing has one (almost) finished. Looping him in here!
Also see this repository https://github.com/kersing/packet_forwarder/tree/master/mp_pkt_fwd/src


Add prettier(code formatter) to the project

This project has refrained from adding and forcing a particular code formatter on the developers. But, I think it's time to change this. The main reason behind this being a significant amount of inconsistent code  (as far as the formatting is concerned ) has made its way into the codebase. Most of the time even simple lint errors, which can be removed by proper formatting, are pushed to the PR and we become aware of those only after the Github Actions give lint warnings. Some formatting differences are not picked up by the linter and therefore adding a code formatter seems necessary.
TL;DR: To make the developers not worry about the formatting and to make sure that the code formatting is consistent in the code.

A must for this project, will give a sense of relief for sure.


HTTP: when creating a resource, 200 or 201 should be returned (not 303)

Fixed in https://github.com/erocci/erocci/commit/ccdcf95dddf53e4d437193adffc0dfbb38969e68


appleseed.studio: Project is deleted before MasterRenderer

When rendering in appleseed.studio, and the currently opened scene is closed, the Project is deleted
but the MasterRenderer is not. MasterRenderer holds a reference to the Project that becomes invalid.

Fixed in<PHONE_NUMBER>696c1d21b442edfbd0b8e667e09b82.


Handle multiple domains

The CMS should let you serve pages on multiple domains. At present the assumption is that each server only serves one domain.
This would require:

Add domains resource with at minimum name, aliases
Change pages, posts, tags to be domain specific with a domain_id col
Not sure if users should be shared or independent, there are arguments for both
Handle https - see server issue on multiple https domains

On users, for the CMS, at present they're only used for admin, so this doesn't really come up. For more complex use-cases with custom code, that code would depend on the site. So I'm inclined to add the column but ignore it for now on the cms.

Thank you for adding this ticket. Multi-site support is really helpful for many use cases where you have to manage lots of small sites (like for my open source projects). From what I've seen I expect Fragmenta to follow a lean approach with high performance and not too many features. I guess the simplest implementation therefore would be to add a sites table that can be referenced in pages via site_id:
CREATE TABLE sites (
id SERIAL NOT NULL,
created_at timestamp,
updated_at timestamp,
title text,
description text,
canonical_name text,
domains text,
active bool,
https bool
);

Images should be sharable across sites so that you don't have to upload an image multiple times.

Yes, maybe. Did you try it? I actually figured that using GitHub pages and a static site generator is all I need since they started to support custom domains and SSL (all free).

It's probably easier to use caddy for this ?

The reason for adding multiple domains directly is that it's much easier to have one server running to serve multiple small domains than it is to maintain multiple CMS servers just to serve multiple domains. Running a proxy in front and lots of fragmenta servers behind is possible (and the best solution right now), but not really ideal if the sites are smaller and don't change much.


installation issue

Hi,
I really would like to try your driver. but when I install it

on a Debian 11
Java 11 is install (default-are)

I got this error:
pip install sqlalchemy-neo4j
Collecting sqlalchemy-neo4j
  Downloading sqlalchemy_neo4j-0.1.dev0-py3-none-any.whl (18 kB)
Collecting jaydebeapi
  Downloading JayDeBeApi-1.2.3-py3-none-any.whl (26 kB)
Collecting jpype
  Downloading jpype-0.0.tar.gz (541 bytes)
    ERROR: Command errored out with exit status 1:
     command: /usr/local/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-pk1meydh/jpype_1c8c781209824a1d83b7166a9cb83e90/setup.py'"'"'; __file__='"'"'/tmp/pip-install-pk1meydh/jpype_1c8c781209824a1d83b7166a9cb83e90/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-_63dpvjh
         cwd: /tmp/pip-install-pk1meydh/jpype_1c8c781209824a1d83b7166a9cb83e90/
    Complete output (8 lines):

    =========================================

    Please install the `JPype` with ``pip install jpype1``

    =========================================

    ----------------------------------------
WARNING: Discarding https://files.pythonhosted.org/packages/92/86/80f8af65d7a681c970914c4ed1cb98178bbd1f1ac7fdff0a2bab75c47708/jpype-0.0.tar.gz#sha256=db973cd5fc031b37bb8968139d4333836d9fb402ce660be9ce52d9f8d1c1cbdf (from https://pypi.org/simple/jpype/). Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
ERROR: Could not find a version that satisfies the requirement jpype (from sqlalchemy-neo4j) (from versions: 0.0)
ERROR: No matching distribution found for jpype

Do you know what I am missing?

Hi @nicolas-cyfix , sorry for not responding straight away. Should be OK now, released a new version to pip.
Please verify that you see 0.2.dev/0.2.dev0 as the version.
If you still see issues with the installation

Let me know 😀
If you're using poetry, poetry add should work

Closing this in the meantime

thank you!
It works better, I will try to use it now ;-)


Don't force immutability for string algorithms

When taking a string argument for validation, 'const(char)[]' should be used instead of 'string'.
That's because the former only promise the caller it won't modify the reference,
while the later ask for the strong promise (from the caller) that this argument shall never be modified.
In addition, some of those algorithm will either return a portion of the input string or a newly
allocated one.  This may result in a lot of otherwise avoidable allocations.  The runtime decision also
makes it impossible to use in @nogc code.
Ultimately, this code could be modified to take a buffer as parameter.
For the time being those functions were turned into templates.
Note: This is a rather shallow pass.

Right, the range based overloads are intended for allocation-free operation. Adding a more classical buffer based optimization shouldn't generally hurt, but it won't solve the @nogc issue, unless they are implemented as a separate overload and insufficient buffer space causes a failure instead of reallocating.

Okay, thanks! Merging in.


chore: clean up hermetic build script and test

Builds on https://github.com/googleapis/sdk-platform-java/pull/1916.
Allow running on OSX in addition to Linux.
Test execution improvement from 2m45s to 11s.

Test execution improvement from 2m45s to 11s.

What made the test execution so much faster? The sparse_clone and rsync?

Test execution improvement from 2m45s to 11s.

What made the test execution so much faster? The sparse_clone and rsync?

Yes.
Checking out googleapis-gen is the slowest part and using sparse-checkout can speed up this process.


Paste in Git Bash in terminal corrupts input if length is 90 characters or more.

VS Code: 1.82.1
OS: Windows_NT x64 10.0.19045
Git: 2.42.0.windows.2
I'm using VS Code 1.82.1 on Windows 10 with the latest updates. I installed Git for Windows 2.42.0, which comes with Git Bash.
I have long used Git Bash in the VS Code terminal, and noticed that sometimes what I paste is corrupted. Now with these current versions I have taking the time to investigate.
VS Code corrupts text input via Ctrl+V (or the Paste command generally) if the input string is 90 characters or more.
Steps to reproduce:

Open Git Bash in the VS Code terminal.
Paste xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

Expected: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Actual: [201~
The key issue is the length of the text being pasted. If the text is 90 characters or more, the text is corrupted in some one, as illustrated below. If the text is 89 characters or less, the text is pasted as expected. With 90 characters or more, note the additional characters including ~ appended, until finally with 93 characters the entire string is replaced with garbage.

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx (89 characters)

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx (90 characters)

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx~

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx (91 characters)

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx1~

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx (92 characters)

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx01~

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx (93 characters)

[201~

https://askubuntu.com/q/1396132 hints that this may be related to the Readline library, although its unclear why the length would have anything to do with it.
This does not happen with Git Bash standalone in a separate window, or in Git Bash in a Microsoft Terminal tab. The bug seems to be specific to VS Code.

See also the recent Stack Overflow question Pasting into VScode terminal adds "~" character at the end, which may refer to the same issue.

This is likely a long standing problem on Windows in node-pty https://github.com/microsoft/node-pty that truncates pastes text.

Not sure if this is related, but I get similar issues when pasting multiple lines of text in a node REPL session, including:

Missing pieces of text (typically a few dozen characters)
Out of order blocks of text
Same thing happening in both Git Bash and Powershell on Windows
This effectively prevents running larger pieces of code in terminal.
Any thoughts? I can open a separate issue if necessary.

Same here pasting (using Ctrl+V) in integrated git bash terminal has unexpected behaviour.
Sometimes it just removes random characters from the text, but when trying to get it on video it actually completely mess up the order of the characters in te text
In the video you can see that the first paste messed up, but the second and third one worked correctly as expected
screen-capture (37).webm


Fix description of bitwise operation XOR

The documentation says ^ would calculate the bitwise OR (same as |), but actually it calculates XOR.

Codecov Report

Merging #18 into master will increase coverage by 0.52%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #18      +/-   ##
========================================
+ Coverage   99.47%   100%   +0.52%
========================================
  Files          23     19       -4
  Lines        2294   1067    -1227
========================================
- Hits         2282   1067    -1215
+ Misses         12      0      -12

Good catch, thank you!


n-Handles: Edge drags out from bottom when position is set to right

Demo video:
https://user-images.githubusercontent.com/67014075/112704553-49b81880-8e58-11eb-81d7-dfe13f57610a.mov
Test repo (line# 25):
https://github.com/sarasfive/react-flow-custom-node/blob/main/src/CustomNode.js
{sourceHandles.map((sourceHandle, index) => (
  <>

Source Handle {index}

    <Handle
      key={index}
      type="source"
      position="right"
      id={index}
      style={{ top: 90 + 16 * index }}
    />
  </>
))}

Am I doing this correctly or is there a better way to handle this? :)

The id should be a string and you need to use the useUpdateNodeInternals hook when you programatically change the number of handles: https://reactflow.dev/docs/api/hooks/

The id should be a string and you need to use the useUpdateNodeInternals hook when you programatically change the number of handles: https://reactflow.dev/docs/api/hooks/

Awesome. Thank you. 👍
I've updated the test repo to reflect.

You only need to call the hook once for the node and not for every handle:
useEffect(() => updateNodeInternals(id), [sourceHandles]);

the id gets passed as a prop to the custom node.


Migrating the list-alerts script into managed-scripts

Migrating the list-alerts script into managed-scripts. Doing so, taking also the opportunity to allow CEE to proceed with the 'read-only' actions such as listing alerts and/or silences.

Can we maybe put this in a general SREP+CEE folder?

Can we maybe put this in a general SREP+CEE folder?

The whole CEE folder is SREP+CEE (any script that can be ran by CEE can as well be ran by SREP and we don't want to dupplicate it). So this is more a matter for the repo in general but not specific to this MR I believe.
Imho, in term of usage, you would list the available scripts with ocm backplane scripts list to get the scipts you can personally use and not scroll/browse in this repository, I don't think this would make a difference.

that's also ok.
if we remove the script from the SREP folder it's ok by me aswell

that's also ok. if we remove the script from the SREP folder it's ok by me aswell
as long as there are no duplicates i'm happy

The script added to SREP doesn't do the same actions :

CEE one is managing the read only actions (list alerts and silence)
SREP one is managing the write actions (create/delete silence).
The only dupplication is the list silence feature because it is useful to be able to trigger it right after delete/create ran to check for it.

/approve


Fully document the REST API using Swagger annotations

Our current REST API doc has some parts that are outdated or have always been inaccurate. We should fully document the REST API using the swagger annotations in the code. This would encourage/remind us to update the documentation when we make changes to the REST API.
We should also use defschema to get better JSON object names in the swagger data model descriptions. We're currently only doing this for the data on /info.link

@rjseymour66 - A pull request for this would be welcome. Are you familiar with Clojure and Swagger?
The changes described here would be made almost exclusively to the following source file:
https://github.com/twosigma/Cook/blob/master/scheduler/src/cook/mesos/api.clj
All new contributors also need to sign and submit the Contributor License Agreement before we can accept any changes or other contributions to this project:
https://github.com/twosigma/Cook/tree/master/cla


No output

I just tried the tool, but it gives no output, output folder is empty. Version installed is 1.0.1.
This is the command called:
/Users/apple/.dotnet/tools/extractpo '/Users/apple/Documents/Projects/Web/Skenit/Skenit.API/Controllers/V1' '/Users/apple/Documents/Projects/Web/Skenit/Skenit.API/generated_po'
Path to extractpo is done manually as dotnet command would not find it after installing globally for some reason.
If I miss the path, ie. input path is wrong, tool gives me output of instructions how to use it.

Hi, @vukasinpetrovic I need to know if the issue is in your path and if you want the tool gives you the output instructions on how to use it. Or is there something else?

The tool already shows the usage, have a look to the following snippet
https://github.com/OrchardCoreContrib/OrchardCoreContrib.PoExtractor/blob/354190e48f2d6edbce07b8e8e015d4c1c6a096e0/src/OrchardCoreContrib.PoExtractor/Program.cs#L171-L186

@hishamco If I set path that does not exist for input path argument, tool prints out usage text. See image below.

If I add correct paths as the arguments, command looks like it executes right, but it generates no output, folder is empty.

@hishamco Tool can extract string from Controllers (c# classes), or just razor views?

It should extract everything, FYI you can select the language & template to help the tool what should be extracted

"Controllers"

Try to point to your solution path, not the Controllers folder, also no need to provide the tool path, just use extractpo

@hishamco Ok, it had to be the root of the project and most importantly localizer has to be named "S" inside the code. Why is that mandatory as when I use Orchardcore I can name my variable whatever I want and it worked fine?

That option would be amazing as many of us are used to naming localizer object simply "_localizer". Regardless of that, tool works fine. Thank you!

Could you please file an issue suggesting that, also you can push a PR if you want to :)


Import manual 02 and how to listed at https://docs.egi.eu/providers/operations-manuals/

Work in progress

Import manual 02: https://wiki.egi.eu/wiki/MAN02_Service_intervention_management
Import howto 01: https://wiki.egi.eu/wiki/HOWTO01
Import howto 02: https://wiki.egi.eu/wiki/HOWTO02
Import how to 03: https://wiki.egi.eu/wiki/HOWTO03
Import how to 04: https://wiki.egi.eu/wiki/HOWTO04

@enolfc HOWTO 04 covers some part about cloud, but it's quite old, not sure what you all want to do with this.

thanks for fixing the mess I created. the pages look good.
We can check later on what to update in the single pages.

OK, we really need to clean them, there is a lot of outdated/useless information.
As I've been able to convert some content from mediawiki to markdown, I could also add other pages that should be imported, but I guess they are not all relevant. So if you give me a list I can add them.
And some strictly grid-specific content may be better pushed at some point to the high-throughput-compute section.


Feature request - performance metrics triggered auto-capture

Description
In complex scenes, the performance metrics may vary rapidly and it is quite difficult to capture the frame we are interested in manually.
It would be great if Renderdoc can capture automatically when a performance metric like draw call hits the user setted bar.

Hi there, your issue has been closed due to not correctly following the issue template. Please read the documentation about filing issues and open a new issue which does follow the issue template. Do not reply to this issue with more information or with a correctly formatted issue, as that will only lead to confusion.
I try to address all github issues and fix bugs quickly, but badly formatted issues or poorly described bug reports especially are a significant drain on project resources. Taking a few minutes to file a good issue makes a huge difference and will get it addressed faster - everybody wins!
In github when you first create a new issue the form is pre-populated with a template which you should read over and follow. As linked above there is documentation going into more detail about what makes a good issue.


TEA, e1s and e4s localize

<3

Thank you for this! Could you remove the tea timelineReplace section, as #793 has all of the languages, and so I'm planning to merge that instead.

Done!

It looks like this is still conflicting, sorry.  Can you merge in your tea changes as well?

ah I see! It should be ok now. sorry.

Thanks thanks! Sorry for the conflicts!


error: no acceptable grep could be found in

~/Downloads/gmp-6.3.0 $ ./configure
checking build system type... configfsf.guess: cannot create a temporary directory in /tmp
configure: error: cannot guess build type; you must specify one
~/Downloads/gmp-6.3.0 $ ./configure --build=x86_64
checking build system type... x86_64-pc-none
checking host system type... x86_64-pc-none
checking for a BSD-compatible install... ./install-sh -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... ./install-sh -c -d
checking for gawk... no
checking for mawk... no
checking for nawk... no
checking for awk... no
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking ABI=64
checking compiler gcc -O2 -pedantic -fomit-frame-pointer -m64 ... yes
checking compiler gcc -O2 -pedantic -fomit-frame-pointer -m64  -mtune=k8... yes
checking compiler gcc -O2 -pedantic -fomit-frame-pointer -m64 -mtune=k8  -march=k8... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.exe
checking for suffix of executables... .exe
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking for gcc option to accept ISO C99... none needed
checking how to run the C preprocessor... gcc -E
checking build system compiler gcc... yes
checking for build system preprocessor... gcc -E
checking for build system executable suffix... .exe
checking whether build system compiler is ANSI... yes
checking for build system compiler math library... -lm
checking for grep that handles long lines and -e... configure: error: no acceptable grep could be found in D:/w64devkit/bin;C:/Windows/system32;C:/Windows;C:/Windows/System32/Wbem;C:/Windows/System32/WindowsPowerShell/v1.0/;C:/Windows/System32/OpenSSH/;C:/Users/m.alipour/AppData/Local/Microsoft/WindowsApps;:/usr/xpg4/bin

See the discussion on #50. In particular you need PATH_SEPARATOR=";" and
ac_executable_extensions=".exe" to mitigate issues in configure. Then to
mitigate a libtool bug you'll need one of the "cmd //c" workarounds. After
that it successfully builds.

I actually couldn't get configure to work even with all the workarounds...sourcing scripts, fake cmd.exe, "bbconf"
without the workarounds it chokes at gcc, with them it chokes at grep -E
the configure script is from clustalo 1.2.4 which builds fine on msys2, I'm curious if I'm doing something wrong or if this script really has some other quirks to it
configure.txt

I retried on a fresh install to see if something in my normal environment
affected the results and it did: GMP normally requires m4 (!) during the
build. I had built and installed GNU m4 awhile back, and GMP had found and
used it. So one option is to do the same, which of course requires similar
configure script contortions. Alternatively you can disable assembly so
that m4 is no longer required. I'll cover that option here.
So first, set the environment variables:
$ export PATH_SEPARATOR=";"
$ export ac_executable_extensions=.exe
Next, build and install my fake cmd.exe in w64devkit:
$ cmd -nostartfiles -o "$W64DEVKIT_HOME"/bin/cmd.exe cmd.c
Then for GMP I came up with this:
./configure --build=$(gcc -dumpmachine)
--prefix="$W64DEVKIT_HOME"/$(gcc -dumpmachine)
--disable-assembly
M4=m4-not-needed
A build of "x86_64" is insufficient because GMP assumes LP64, which is
incorrect for x64. The actual string will be "x86_64-w64-mingw32", which
will not configure as LP64.
For the prefix I installed it inside w64devkit. That makes <gmp.h>, -lgmp,
and even "pkg-config gmp" work out of the box, just as though it came with
w64devkit. However, you can put this wherever you prefer. If you place its
"pkgconfig" directory in $PKG_CONFIG_PATH it will work with pkg-config no
matter where you put it.
I disabled assembly so that m4 isn't needed. However, there's a GMP bug
dating back to at least 2010 such that this does not actually disable the
m4 test. So the last part, m4-not-needed, is the conventional workaround.
If you have m4 on you path, you can skip these last two parts.
With that I could then "make -j$(nproc)" then "make install" and I had a
working GMP.
Though now I've just realized you're asking about an entirely different
configure script. That will require similar workarounds, but maybe this
could serve as a guide if you're really interested in making it work,
though it's probably not worth the trouble. It works on msys2 because, as
discussed on the other thread, Autotools hard codes hacks into configure
scripts to mitigate msys2 problems (e.g. its behavior converting "cmd /c"
into "cmd C:/"), and those hacks break the script for systems which don't
have those problems (native Windows). Despite its facade of adapting to
the host, in practice Autotools builds only support a handful of systems
that were popular at the time the configure script was generated.

Next, build and install my fake cmd.exe in w64devkit: $ cmd -nostartfiles -o "$W64DEVKIT_HOME"/bin/cmd.exe cmd.c

Are you referring to this? https://gist.github.com/skeeto/2e3ae0e8623f5ca8ef4adbae9f05449b
I don't think I see it in this repo or in the distribution.
Would it make sense to include it at the distribution, possisbly even precompiled inside bin/?
Would it make sense to export PATH_SEPARATOR, ac_executable_extensions, and build_alias automatically, like you suggested here? (and add a blurb to the readme for those who don't use the main launcher and instead only add bin to their path)
I did notice two things though, both relate to cmd //c ...:

The cmd.exe hack is not always required, e.g. with (pre-generated) configure script of gnu mtools 4.0.43.
The sed -i 's/func_convert_file_msys_to_w32/func_convert_file_noop/' configure  mentioned here does not work (and also not required) with the same mtools configure script, because these functions don't exist there.

But the 3 exports are required with the mtools configure. Though the build_alias export can be replaced with a --build=<same-value-as-build_alias> option for ./configure.

Yup, it's just sitting in that gist for now, mostly as a proof of concept,
and I haven't given it further attention. It must compile to cmd.exe,
but I wouldn't put this in $PATH in normal circumstances. This inclines me
towards a new command through which to run configure scripts that enables
workarounds which don't involve manipulating the script text. I don't have
name picked out, but imagine something like:
$ fixconf ./configure --prefix=... --enable-shared ...
I'd compile cmd.c to, say, lib/fixconf/cmd.exe, and fixconf would:

Add $W64DEVKIT_HOME/lib/fixconf to the front of $PATH
Set PATH_SEPARATOR, ac_executable_extensions, and (maybe) build_alias
Invoke sh.exe with the original command string and wait for it

Then using this configure prefix would fix most Autoconf script builds
invoked within that environment. That includes builds that don't require
the msys2 cmd.exe fix, like mtools, because the fix wouldn't affect it.

Add $W64DEVKIT_HOME/lib/fixconf to the front of $PATH

Well, preferably relative to fixconf itself, again, in case we're not running via the main launcher.
Otherwise sounds good.
However, I don't think we have enough stats with configure scripts to know the possible gotchas and workarounds other than the cmd.exe hack which is not always required.
I don't frequently run autotools configure in w64devkit, so I don't have such stats.
Also, I think the main issue with requiring build_alias or --build=... is that uname -s returns Windows_NT where config.guess looks for MINGW<not sure if 32/64/nothing matters>.
But because configure is executed as a (busybox) shell script, it means it can load a uname shell script which runs busybox uname "$@" and then modifies the result according to whatever, and that uname script can reside together with the fake cmd.exe in high PATH priority.
It probably wouldn't be very hard to address various issues, but collecting those issues might not be simple.

For future reference, the ugly cmd //c ... in expat comes, as far as I can tell, from libtool:
https://github.com/autotools-mirror/libtool/blob/7b0918310776395e1cbafe6a08b8df8f8a8a3e21/build-aux/ltmain.in#L958-L967
This is not exactly the form which the function appears at the expat configure script, but I think it's its source somehow.
(//C is also used here and here but these are only invoked when the compiler is ICC or MSVC CL, so not in w64devkit - I tested it)
Not 100% clear to me when it does or doesn't get into configure (e.g. yes in expat, no with mtools, maybe always when using libtool?), but it's still in libtool today, and can still be part of newly generated configure scripts.
So we can't shrug it off as "only expat".
As a possible fix, and because it's explicitly targetting msys[2], maybe the upstream solution is to replace all the cmd //C ... instances with MSYS2_ARG_CONV_EXCL=* cmd /C .... This would prevent the unix-path-to-dos-path arg conversion in msys2 so that cmd /c ... works, and it will work as epected also when such auto-conversion doesn't happen (busybox-w32 sh).
Just FYI.
As a side note, the cmd.c hack source seems to check //c (lower case), but as far as I can tell, it's always incoked with //C (upper case).


Permanent Flurry of Blows

Most of the monk features like Flurry of Blows and patient defense remain permanent until combat is over.
This also counts for action surge (for PC's and enemies) and maybe more things too.
Attached is my save file
FlurrySave.zip

I have the same issue with loads of timed features and buffs. Concentration spells won't stop (not manually, not through damage, not by casting another concentration spell, not by expiring), characters are continuously rolling for stench even though there are no enemies, the Inventor's Defensive Field is staying up, etc.
My save file is of the workshop campaign "The Forsaken Isle". The nearby Flame Wall and the other effects have persisted through concentration loss, unconsciousness and a short rest.
bugged.zip

One bad refactor unleashed hell in mod. Fixed in dev and waiting for Qa to give a go.


chore: upgrade sqlx package version

Upgrade sqlx dependency #32

Thanks for your contribution @f3r10

I have news about this, after I try to publish a new version with this change on crates.io I get this response:
cargo publish
    Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `sqlx-crud` does not specify a version
Note: The published dependency will use the version from crates.io,
the `git` specification will be removed from the dependency declaration.

We need to push the new fork as a new project on crates.io right?

I have news about this, after I try to publish a new version with this change on crates.io I get this response:
cargo publish
    Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `sqlx-crud` does not specify a version
Note: The published dependency will use the version from crates.io,
the `git` specification will be removed from the dependency declaration.

We need to push the new fork as a new project on crates.io right?

@f3r10 let me know what do you think about this

Sorry for the late response,
Yes, you are right @grunch it looks like it is necessary to push the fork to crates.io so that it will be possible to define a version on the Cargo.toml file

maybe this option could be better than publishing the fork project to creates.io: https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#working-with-an-unpublished-minor-version
Let me know what could be the best option

[dependencies]
sqlx-crud = { version = "0.4.0", features = [
  "runtime-tokio-rustls",
], optional = true }
...

[patch.crates-io]
sqlx-crud = { git = "https://github.com/f3r10/sqlx-crud" }

With this change, it looks like it works

[dependencies]
sqlx-crud = { version = "0.4.0", features = [
  "runtime-tokio-rustls",
], optional = true }
...

[patch.crates-io]
sqlx-crud = { git = "https://github.com/f3r10/sqlx-crud" }

With this change, it looks like it works

got this done and published on version 0.6.2

I am going to create a PR to Mostro updating the dependencies with the new version mostro-core an the patch of sqlx

unfortunately I have to revert this PR because it is not working properly with https://github.com/MostroP2P/mostro/pull/334
I will do this PR again but it's not going to be merged until we are sure the mostrod PR can work properly with it

@f3r10

sure, I understand. I am going to check https://github.com/MostroP2P/mostro/pull/334 to see what is missing


Don't initialize "public.resource", use "resource" instead

The KubeArchive init process creates the table "public.resource". "public" is the default namespace, but database admins may want to restrict user access to a certain namespace. To allow administrators to manage better the kubearchive user permissions, KubeArchive needs to drop the "public". This change will make KubeArchive compatible with PostgreSQL schemas if they administrators want to.
PostgreSQL schemas: https://www.postgresql.org/docs/current/ddl-schemas.html
Edit: changed the approach to drop "public" first.

I think that we should create a kubearchive database with the CREATE DATABASE SQL instruction and then include the table inside it.

I think that we should create a kubearchive database with the CREATE DATABASE SQL instruction and then include the table inside it.

Agreed. We're not doing that?  We should have our own database called kubearchive.  And our database should not be shared with anyone.
The server itself could be shared, but not the database.

We're not doing that?

No, we are running in whatever database the user provides us.

I think that we should create a kubearchive database with the CREATE DATABASE SQL instruction and then include the table inside it.

We may not have permissions to setup a database with the account the user provides to us.

We should have our own database called kubearchive. And our database should not be shared with anyone.

I agree that having isolation would be nice, as its fewer options for something to go wrong. The user providing a database for us its probably the most common scenario.
From this I get that we need to inform the user that we require our own database within the PostgreSQL instance. However we don't have any reasons for that and I think that database. I added a comment on another ticket related with that.
Anything related with the "public" part of this issue?

We may not have permissions to setup a database with the account the user provides to us.

You're right, this part should be done only for the development part as we create the db from scratch, but the user should provide the db with whatever schema they want us to use for kubearchive, so I agree with your latest comment.
I agree that we should drop the public part of the create table instruction

We're not doing that?

No, we are running in whatever database the user provides us.

I've misunderstood what we are doing, and we should not be doing this.
The user should provide use with a database server, and we should provide them with the SQL to create the kubearchive database. This SQL should also create a kubearchive user that has appropriate permissions to read/write to whatever tables it need. And then KubeArchive should connect using this user.

@ggallen what you suggest only makes sense IF we agree on delegating to the user executing the SQL (that is a decission that needs to be made yet) otherwise, if setting the schema in the database is going to be part of the installation process, we may face the problem that hector stated previously of not having enough credentials to create the database in the postgresql server

what you suggest only makes sense IF we agree on delegating to the user executing the SQL

I didn't think there was any debate over this.  We are not database administrators, and KubeArchive should never have nor request those permissions. Database creation is an administrator function. We provide the SQL as part of the installation process, and then an administrator applies that SQL to create the database and kubearchive user on their database server. The kubearchive user should be the owner of the database.
Then KubeArchive accesses the database using that kubearchive database user.

Something I was messing with is that I was considering DATABASE and SCHEMA synonims (they are in DBs like MySQL but not in PostgreSQL, see docs


Add package config

Needed for new version of bit-docs-generate-html.
Anticipates a new 2.0.0 release of bit-docs-donejs-theme with these breaking changes:
https://github.com/donejs/bit-docs-donejs-theme/pull/66

Coverage remained the same at 96.396% when pulling dd443f1a31b11866a055e29e2f4030169c3809e3 on add-package-config into 889edb57e4f852afb8e127a2450519db411c23e9 on master.

Coverage remained the same at 96.396% when pulling e26b64dd727d87ffcf05a3d53412d3e9b1a35733 on add-package-config into 889edb57e4f852afb8e127a2450519db411c23e9 on master.


custom validator keeping ref to instance variable

This is a failing test that demonstrate a possible bug. This is a failing test in response to this issue #1592.
I have tested both from code at version 0.16.2 and master with similar error.
Not sure if the issue is in custom validator or in the helper. I hope someone knowing better the source code can help on this.
Thanks

@dblock This one might be closed, the related issue was fixed.

@loicginoux Want to rebase and retest. Close or update if the test case is useful and I'll merge.


error[internal]: left behind trailing whitespace

Hi, I'm having a problem with cargo fmt , like this：
error[internal]: left behind trailing whitespace
 --> /playground/src/main.rs:5:5:1
  |
5 |
  | ^^^^^^^^
  |

warning: rustfmt has failed to format. See previous 1 errors.

code looks like this:
fn main() {
    let a = Some(1);
    let Some(a) = a else{
        panic!("none");

    };
    println!("{a}");
}

rustc 1.65.0
rustfmt 1.5.1-stable (897e3755 2022-11-02)

Thanks for reaching out. rustfmt doesn't handle let-else formatting because the rules for how it should be formatted are still being discussed in https://github.com/rust-dev-tools/fmt-rfcs/pull/165
Because rustfmt doesn't format let-else statements the code is left as is by rustfmt, which means the trailing whitespace that exists in the original snippet is also left alone, triggering the internal error that you're seeing. In this case the internal error is rustfmts way of letting you know that there's trailing whitespace in the text of your program that requires manual intervention to remove.
You might also want to follow  #4914 to keep track of the implementation on the rustfmt side once the rules have been codified in the fmt-rfc linked above.


Bonnie 264 test based

Adds back end fixtures for tested

can you move the measure exports you added into parallel files where you have the same measure information in the other test folders? e.g. base_example.

Looking at CMS68, it doesn't look like it's possible to have a patient pass in one version and fail in the other version without changing the patient. the versions look too static. I think this should be replaced with a measure where a patient might break between version uploads.

This got pulled in from a different branch: https://github.com/projecttacoma/bonnie/pull/624


Allow nested C++ names after a module name

Related to #3074
Allow code like the following to compile:
cimport m

def my_func():
    cdef m.CppClass.NestedClass c

where m is a module, CppClass is a C++ class and NestedClass is a nested class inside CppClass.

@garychia Can you test if your implementation also fixes #3132?
If yes, it would be nice to have it as a test

Thanks. I'm taking the judgement that this is a small enough change to go into 3.0 without much of a risk of breaking anything new.


Add DynamoDB support

Add AWS DynamoDB support.
Schedule a function to loop over the (Firehol blocklist-ipsets)[https://github.com/firehol/blocklist-ipsets], extract the ip addresses as we are already doing in the current ipcheck function. Then compare those IP addresses and their corresponding file as key:value pairs in DynamoDB.
Update ipcheck function to query DynamoDB to check if the IP exists there rather than the Firehol repository directly.

[ ] Create a function to write to DynamoDB

[ ] Function should be scheduled to run ever X hours.
[ ] Function should compare existing data so as not to duplicate entries.
[ ] Function should store ip address and ipset file as key:value pairs.

[ ] Create a function to read from DynamoDB

[ ]  Function should take an optional parameter as a query.
[ ]  If no query is passed, return all data.
[ ]  If an query parameter is passed (ip) find only that ip and its ipset.
[ ] If no match is found return null.


Updating Dynamics 365 Finance and Operations Tools Task IDs to versio…

…n 0.2.73

@Moutasema Thank you! You save my day!

@jorisdg merge this please

Unfortunately merging this will fix this maybe for you, but will break it for other people. The GUIDs shown in this sample are the ACTUAL guids of the tasks. The Azure DevOps team so far has been unable to explain why or what is happening that there are many accounts who get a different guid for some reason.

Thanks this fixed it for me as well!

@jorisdg these GUIDs are defined in Dynamics 365 Finance and Operations Tools DevOps Pipeline Extension and are equal for all users.
For example task for updating model version is defined in task.json and GUID is defined there and will not change until the publisher decides so.
{
    "id": "39fb981e-bf08-50cc-a6b1-57bd7d8024fd",
    "name": "XppUpdateModelVersion",
    "friendlyName": "Update Model Version"
}

I still can't explain why these GUIDs are off. Our internal source code for the extension (and all of our test AZDO accounts) have the GUIDs as you seem them here.
I downloaded the extension and extracted it and the GUIDs in there are what's proposed in this PR. I can't explain it, but I'll take this PR. Thanks for pushing this again.


Passing deployment information to the binary

There are more than one ways to deploy the application and knowledge of the approach used would be useful for making decisions inside the app. One way to get this information is through the use of flags in Go.
The health check application can be deployed either as a pod in the cluster or externally. To solve this case, the path to the kubeconfig file can be passed as an argument. Then the following code can be used to get the client.
func getClient(pathToCfg string) (*kubernetes.Clientset, error) {
	var config *rest.Config
	var err error
	if pathToCfg == "" {
		logrus.Info("Using in cluster config; deployed as a pod")
		config, err = rest.InClusterConfig()
	} else {
		logrus.Info("Using out of cluster config; deployed externally")
		config, err = clientcmd.BuildConfigFromFlags("", pathToCfg)
	}
	if err != nil {
		return nil, err
	}
	return kubernetes.NewForConfig(config)
}

In addition to that, the user can allow or disallow the creation of additional pods inside their cluster (when the health check application is deployed externally). For this a boolean flag can be passed while executing, say --allow-pods
Alternatives
We can use a config file to get the same settings. I did not make this the primary choice because:

There aren't a lot of fields that need to be set.
If the application is deployed in a container, command-line arguments would be much simpler than using config files, I believe.

Questions
Is this approach right? Have I missed any alternatives?

@yongtang @greenpau

@WJayesh Thanks, I will take a look. You can always explicitly ping me if you have any questions in the future (didn't receive you note until today).

@WJayesh Overall it looks good to me. I could see you already have quite some code in the repo. What might be missing, is the README.md for instructions on how to build and deploy. That can help others to give it a try.

@yongtang  Thanks for pointing that out! I will add the README.md file by tomorrow. Plus, I've added some comments on top of the functions to make them more comprehensible. After the README.md is done, please let me know if there's any ambiguity regarding any part of the code.

@WJayesh I could see you have added quite some content in the repo, though I haven't been able to find a guide to build or run the binary yet. Maybe you can add the instructions to README.md? / @greenpau

@yongtang I have added some instructions for Docker and Kubernetes in the deployment file here.
Let me know if any important detail is missing.

@WJayesh Ah it is in DEPLOYMENT.md. I will take a look, thanks!
By the way, you may want to add a link or a small section in README.md to link to DEPLOYMENT.md. I didn't realized the deployment instruction is in another file before.

@yongtang Sure, I'll put a link right away! Thanks

I'm closing this issue as we've moved passed passing info to the binary at this point.


MudText should use default Text Color as TextPrimary of the Palette

Feature request type
Enhance component
Component name
MudText
Is your feature request related to a problem?
There is TextPrimary defined for the Palette but I dont understand what is it for and why MudText is defined as "Color.Inherited" instead of using TextPrimary ? Does it even make sense to use Color.Inherited.
I would like to change between dark and light mode and text should be adjusted according to this but using Color.Inherited makes absolutely no sense as it takes the color of the parent.
Describe the solution you'd like
Use TextPrimary as default color
Have you seen this feature anywhere else?
No response
Describe alternatives you've considered
No response
Pull Request

[X] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I disagree.  The primary colour as a default would be onerous to use because often the primary colour, even by default, is exactly that, a COLOR. Pink, or Purple, or perhaps branding colours.  I wouldn't want my text to, by default, be a colour other than black or white if in dark mode. Otherwise, every single MudText element I put on, I'd have to add Color="Color.Default" or someth8ing like that.
It's bad enough having to do that on every single button to set the variant property. I wouldn't want to have to start adding that to all of my MudText elements as well.

You confused primary vs TextPrimary. There are 2 properties for a palette. If mudtext is using inherited, it means on a white layout text is color is also white which is senseless.

@EmilAlipiev I stand corrected. Thanks! And yeah, what you're saying makes more sense now. I'd like to retract my earlier comment.  :)


Added python2 and libpng-dev to both runtime Dockerfile contents

Description
This fixes two dependency issues which cause errors when running the command in Nova to create a new tool, eg:
sail artisan nova:tool acme/price-tracker
Python3 is installed by default in Ubuntu 20.04 (used by the Dockerfiles), but Python2 was required during the installation step of creating the Nova tool, as was libpng-dev, so these have been added to the Dockerfiles.
You might not want to accept this PR as it's very specific to Nova, but if not then maybe this info will help someone else who gets stuck like I did.
How to test

Install fresh Laravel project with Sail and Nova
Try to create a new Nova tool as above, which will result in an error without this PR

Screenshots
Python2 dependency error:

Libpng-dev dependency error:

Ubuntu 20.04, on which Sail is based, is not bionic?

Python 2 is sunsetted. Is there any way nova can be bumped to use python3?

Ubuntu 20.04, on which Sail is based, is not bionic? Did you test this?

Yeah, ran tests and it worked fine, but that was a silly oversight, sorry. Let me fix, run some tests and I'll commit that later today.

Realised that adding the focal universe repo was redundant as it's already listed within /etc/apt/sources.list (I hadn't run apt-get update before trying to apt-get install -y python2, so that's why the package couldn't be found previously). Very minor changes now - tested and working.


Add namespace to cluster resource.

Signed-off-by: cappyzawa<EMAIL_ADDRESS>
Changes

I expect this to reduce args passed to kubectl apply.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[x] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task and TaskRun to build and release this image

Reviewer Notes
If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.
Release Notes
Enable to use `namespace` in ClusterResource params.

/assign @sbwsg

/ok-to-test

/lgtm

/test tekton-pipeline-unit-tests

@sbwsg I also added namaspace param to some test cases.
Could you review again if you have time, please:pray:

/lgtm


fix(markdown/#2953): explicitly set code block font size in Markdown

For some reason, explicitly setting the code block font size fixes the code block issue in extension descriptions.
This should just be a temporary fix until I can figure out why this is happening, but it works well for now.
Fixes #2953

I'll merge this in so you don't have to deal with any merge conflicts from other changes - thanks for investigating this, @zbaylin !

I'll merge this in so you don't have to deal with any merge conflicts from other changes - thanks for investigating this, @zbaylin !


wiki: NixOS related repositories and work

https://nixos.org/wiki/NixOS_related_repositories_and_work

I believe that this page is completely out-of-date except for the link to Guix. Moreover, most of the referred overlays have specific pages on the wiki (which are probably out-of-date too but can be discussed on their own related issue).
So this specific issue could be closed.


Cilium fails to update status on CiliumNode resource, leading to Cilium never becoming ready

This issue seems to only be observable on EKS environments. Because the issue is failing to update the CiliumNode status, likely Azure environments are broken as well. GKE is not affected because this only bug exists only with IPAM modes that use the CiliumNode resource to hold IPAM information.
Cilium version: master
Steps to reproduce:

Follow EKS GSG guide
Deploy latest master.

I traced this down to this call here: https://github.com/cilium/cilium/blob/868feac8abcb70159f2a5709c5c36acbda14ac22/pkg/ipam/node.go#L716
I added an extra log statement:
diff --git a/pkg/ipam/node.go b/pkg/ipam/node.go
index ec000292a..0d96156cb 100644
--- a/pkg/ipam/node.go
+++ b/pkg/ipam/node.go
@@ -714,6 +714,9 @@ func (n *Node) syncToAPIServer() (err error) {

 		n.ops.PopulateStatusFields(node)
 		updatedNode, err = n.manager.k8sAPI.UpdateStatus(origNode, node)
+		if err != nil {
+			scopedLog.WithError(err).Warning("Failed to update status of node")
+		}
 		if updatedNode != nil && updatedNode.Name != "" {
 			node = updatedNode.DeepCopy()
 			if err == nil {

And that leads me to see the following log msgs:
[cilium-operator-58678745f4-nmftv] level=info msg="Synchronized ENI information" numInstances=4 numSecurityGroups=20 numSubnets=19 numVPCs=5 subsys=eni
[cilium-operator-58678745f4-nmftv] level=warning msg="Failed to update status of node" error="ciliumnodes.cilium.io \"ip-192-168-86-159.us-east-2.compute.internal\" not found" instanceID=i-0e986523decf7234c name=ip-192-168-86-159.us-east-2.compute.internal subsys=ipam
[cilium-operator-58678745f4-nmftv] level=warning msg="Failed to update status of node" error="ciliumnodes.cilium.io \"ip-192-168-5-163.us-east-2.compute.internal\" not found" instanceID=i-0b2545c92023c4eb8 name=ip-192-168-5-163.us-east-2.compute.internal subsys=ipam
[cilium-operator-58678745f4-nmftv] level=warning msg="Failed to update status of node" error="ciliumnodes.cilium.io \"ip-192-168-5-163.us-east-2.compute.internal\" not found" instanceID=i-0b2545c92023c4eb8 name=ip-192-168-5-163.us-east-2.compute.internal subsys=ipam
[cilium-operator-58678745f4-nmftv] level=warning msg="Failed to update status of node" error="ciliumnodes.cilium.io \"ip-192-168-86-159.us-east-2.compute.internal\" not found" instanceID=i-0e986523decf7234c name=ip-192-168-86-159.us-east-2.compute.internal subsys=ipam

Seems like we swallow the error a few lines down if a subsequent Get request for the CN resource succeeds.

Seems like we've missed adding a /status subresource to CiliumNode. It is there in < 1.8 (under spec):
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
...
  name: ciliumnodes.cilium.io
...
spec:
  conversion:
    strategy: None
  group: cilium.io
  names:
    kind: CiliumNode
    listKind: CiliumNodeList
    plural: ciliumnodes
    shortNames:
    - cn
    - ciliumn
    singular: ciliumnode
  preserveUnknownFields: true
  scope: Cluster
  versions:
  - name: v2
    schema:
      openAPIV3Schema:
        description: CiliumNode represents the k8s node from the view of Cilium.
        properties:
          spec:
            properties:
              ...
    served: true
    storage: true
    subresources:
      status: {}
status:
...
  - v2

A /status subresource MUST be provided to enable system components to update statuses of resources they manage.

https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#spec-and-status


Add missing EVP_MD documentation

While working on #7636 I noticed several missing functions from the EVP_MD documentation, in particular many available controls and flags were missing.
This is an attempt to improve this situation, though I don't really understand what the EVP_MD_CTRL_DIGALGID and EVP_MD_CTRL_MICALG controls do.
Signed-off-by: Antoine Salon<EMAIL_ADDRESS>
Checklist

[x] documentation is added or updated
[ ] tests are added or updated

The intended usage of these controls is not very clear, they are part of the public API but in the code base it seems like they are used as internal plumbing, not as a way to provide additional functionality to the user. As you mentioned, it might be better not to document them in that case.
If we were to deprecate them, what would we do instead?

Internal things can be deprecated in the sense they are removed from the public API.  This doesn't preclude them remaining for internal use.  I believe there are calls from libssl to libcrypto which aren't considered part of the public API.
E.g. EVP_MD_CTX_pkey_ctx() looks like it would be a good candidate for being internal, yet there is a setter for this that is exposed and documented.  I'd like some input from the rest of the @openssl/omc about what to do here -- document or deprecate?

Backported to 1.1.1 via #10094.


change "remove" => "delete" in update tests (403 and 404) to match current spec

https://micropub.net/draft/#remove

cc @aaronpk, only since i noticed you're not watching the repo. apologies if you already got the notif another way!

Totally missed this, thanks for the ping! I must not be set up to watch new repos by default.


Fixed : syntax error in "case"

Removed extra ";;" at end of line.

Duplicate of #345. Before submitting a pull request, check if a solution was not already proposed.

My bad, I checked earlier and Phil fixed it in the meantime.

No problem. Please close the PR.


Builds break after adding SNI for API HTTPS endpoint

#4423 introduced a bug when trying to access the API from the builder.
This is needed for our Azure migration, so we need to find a way to make it work. This is currently working under our Azure servers.
Traceback (most recent call last):
  File "/home/humitos/rtfd/code/readthedocs.org/readthedocs/projects/tasks.py", line 333, in run
    self.project = self.get_project(pk)
  File "/home/humitos/rtfd/code/readthedocs.org/readthedocs/projects/tasks.py", line 512, in get_project
    project_data = api_v2.project(project_pk).get()
  File "/home/humitos/.pyenv/versions/3.6.6/envs/readthedocs.org/lib/python3.6/site-packages/slumber/__init__.py", line 155, in get
    resp = self._request("GET", params=kwargs)
  File "/home/humitos/.pyenv/versions/3.6.6/envs/readthedocs.org/lib/python3.6/site-packages/slumber/__init__.py", line 97, in _request
    resp = self._store["session"].request(method, url, data=data, params=params, files=files, headers=headers)
  File "/home/humitos/.pyenv/versions/3.6.6/envs/readthedocs.org/lib/python3.6/site-packages/requests/sessions.py", line 512, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/humitos/.pyenv/versions/3.6.6/envs/readthedocs.org/lib/python3.6/site-packages/requests/sessions.py", line 622, in send
    r = adapter.send(request, **kwargs)
  File "/home/humitos/.pyenv/versions/3.6.6/envs/readthedocs.org/lib/python3.6/site-packages/requests_toolbelt/adapters/host_header_ssl.py", line 43, in send
    return super(HostHeaderSSLAdapter, self).send(request, **kwargs)
  File "/home/humitos/.pyenv/versions/3.6.6/envs/readthedocs.org/lib/python3.6/site-packages/requests/adapters.py", line 445, in send
    timeout=timeout
  File "/home/humitos/.pyenv/versions/3.6.6/envs/readthedocs.org/lib/python3.6/site-packages/urllib3/connectionpool.py", line 589, in urlopen
    conn = self._get_conn(timeout=pool_timeout)
  File "/home/humitos/.pyenv/versions/3.6.6/envs/readthedocs.org/lib/python3.6/site-packages/urllib3/connectionpool.py", line 251, in _get_conn
    return conn or self._new_conn()
  File "/home/humitos/.pyenv/versions/3.6.6/envs/readthedocs.org/lib/python3.6/site-packages/urllib3/connectionpool.py", line 212, in _new_conn
    strict=self.strict, **self.conn_kw)
  File "/home/humitos/.pyenv/versions/3.6.6/envs/readthedocs.org/lib/python3.6/site-packages/urllib3/connection.py", line 125, in __init__
    _HTTPConnection.__init__(self, *args, **kw)
TypeError: __init__() got an unexpected keyword argument 'assert_hostname'

I need to research a little more to understand why this is not working locally but it is on Azure VM.

The important code regarding the assert_hostname is at
https://github.com/requests/toolbelt/blob/master/requests_toolbelt/adapters/host_header_ssl.py#L37-L41
I put a log in my instance and I see that host_header is localhost:8000, which comes from PRODUCTION_DOMAIN
https://github.com/rtfd/readthedocs.org/blob/7511411e508b32022c2568e216c020b2a793494a/readthedocs/restapi/client.py#L46


Verilator generated executable didn't run far...

Using the following verilator commands:
verilator -Wno-lint -Wno-MULTIDRIVEN -trace --top-module picorv32_wrapper --cc testbench.v picorv32.v --exe testbench.cc cd obj_dir/ make -j -f Vpicorv32_wrapper.mk
Got these error message:
TRAP after 8428 clock cycles ERROR! %Error: testbench.v:268: Verilog $stop Aborting... Aborted (core dumped)

You likely built a test firmware using compressed ISA. But you did not pass -DCOMPRESSED_ISA to verilator, so you built a simulation model without compressed ISA support. Therefore the core hangs when it encounters the first compressed RISC-V instruction.
Solutions: Either build the simulation model with -DCOMPRESSED_ISA or build the firmware image with COMPRESSED_ISA= (instead of COMPRESSED_ISA=C).
I've now added a make test_verilator target in commits 247a19d and 3f55fb4 that builds and runs the verilator testbench.

Yeap, that's it. Thanks Clifford.  Just a typo in the Makefile:
diff --git a/Makefile b/Makefile
index 2c14263..715249e 100644
--- a/Makefile
+++ b/Makefile
@@ -74,7 +74,7 @@ testbench_verilator: testbench.v picorv32.v
        verilator --cc --exe -Wno-lint -trace --top-module picorv32_wrapper testbench.v picorv32.v testbench.cc \
                        $(subst C,-DCOMPRESSED_ISA,$(COMPRESSED_ISA)) --Mdir testbench_verilator_dir
        $(MAKE) -C testbench_verilator_dir -f Vpicorv32_wrapper.mk
-       cp obj_dir/Vpicorv32_wrapper testbench_verilator
+       cp testbench_verilator_dir/Vpicorv32_wrapper testbench_verilator

Another bug in the showtrace.py is probably also related to "compressed_isa".
0000ac44 <tdat>:

    ac44:	          	jal	t4,15c44 <end+0xaf90>

Traceback (most recent call last):
  File "showtrace.py", line 16, in <module>
    if match: insns[int(match.group(1), 16)] = (int(match.group(2), 16), match.group(3).replace("\t", " "))
ValueError: invalid literal for int() with base 16: 'jal'

Thanks! 1cc9784 fixes the makefile typo, 4fed27f fixes showtrace (had nothing to do with compressed_isa).


adds search

Context
Adds a search bar to the tech docs
Changes proposed in this pull request
Relevant changes to the config files, the rest should be picked up by the build/deploy
Guidance to review
Testable at https://registers-docs-testing-2.cloudapps.digital/

Bug: https://github.com/alphagov/tech-docs-template/issues/166

There's a few issues with the search right now which I've fed back to the developers. One is captured here:
https://github.com/alphagov/tech-docs-template/issues/166
☝ I've tested a fix for this locally and I'm satisfied it's been solved.
One more serious problem is that (and you can confirm this in the test environment at https://registers-docs-testing-2.cloudapps.digital/#gov-uk-registers-quick-start-guide) currently searching for certain things like 'Get' doesn't produce the intended outcome. The developers at Convivio are currently working on it and it's at least partly because of stop words, see https://github.com/alphagov/tech-docs-gem/pull/38
The test environment currently has a test fix though and whilst searching 'Get' (which was one of the stop words) no longer produces 0 results, it doesn't produce expected results in that it doesn't show any of the endpoints. Same goes for searching for e.g. 'Linked'.
For the purposes of this PR, I think we should hold off before merging. We could still go with it as it stands: I will leave it up to you guys @gidsg @michaelabenyohai @arnau @MatMoore

The fix to the first issue I mention above is also fixed in https://registers-docs-testing-2.cloudapps.digital/#gov-uk-registers-quick-start-guide

The results look a bit dodgy to me too. If I copy a description from one of them like "Get information about a register" or "Get all records from a register" that page doesn't show up in the results.
The snippet on the results page sometimes looks strange as well, for example if I search for country it shows me the quick start guide with "… //country … country … //country … //country … //country …"
Do you know if the queries are currently being sent to GA so we can monitor what users actually search for? We don't need it to be perfect to put something live, but we should be able to get some usage data so we can prioritise improvements.

I don't think we have any GA for the test environment(s) but we do for the live environment, though I guess @michaelabenyohai would need to set it up for this search specifically if we merge this PR?
Having spoken to Convivio it seems like lunr is not returning the API reference pages as results in at least some cases. If you try searching "Linked" though, for example, it does return some 🤔

Ah this is the PR that will add GA tracking: https://github.com/alphagov/tech-docs-gem/pull/39
so it's not there yet, but we'll have it eventually.

Not sure what can be done here but results like this one make me wonder if we would be better with a list of links (no excerpt) or with the first paragraph.

alphagov/tech-docs-template#166
☝ I've tested a fix for this locally and I'm satisfied it's been solved.

@bahmady it doesn't work for me in this branch. Do I have to do anything in particular?

One, more serious, problem is that (and you can confirm this in the test environment at https://registers-docs-testing-2.cloudapps.digital/) currently searching for certain things like 'Get' doesn't produce the intended outcome.

I'm not too bothered by this. A result list for the search “get” is not that useful. Even a search like “get entries” gives me lots of results for “get” which are not relevant to me.
That said, “get + entries” works as I would expect. I guess I want it all :D so probably I would like “get“ to be relevant only when it is in an AND operation. In any case, I rather not have results for “get”.

I guess that the best solution for the tech docs gem would be to allow stop-word customisation so we can tune it based on our needs.

Another surprising search is “json”. Do we truly only have two pages with “json” in it?

@arnau we can talk about the first comment you raised separately if that's OK? We should be able to have stop-word customisation, yes.
re. the "json" search, no; I would think it should show more than that.
The problem re. "Get" is with what user research I was able to do on the Pay docs specifically (i.e. not just user research on the format itself) both participants tried to search "Get" and were unsuccessful. I realise that's a limited sample and for the record neither were developers, but nevertheless it's a little concerning.
re. the other fix, I really don't know: it's fixed for me locally and on that test version ... what are you searching for/where are you when you initiate the search?

It seems that the term 'application/json' returns the results you'd also expect. It's not very clear why, but maybe I can add some additional tweaks here to include 'application/json' when searching for 'json'
I've found a fix for the 'get' issue. I've had to make some modifications to the middleman-search gem, once I can get them merged then you can test it.
Per-docs stop word customisation and other customisation options are possible. I'd rather we start trying to get a good default built into the gem first and then add custom options later.

I'd also rather we had good defaults in the gem. Any project specific customisations will be a pain to manage over time.

I've created an issue in the lunr.js repo to see if I can get any pointers: olivernn/lunr.js#365

We should try this again with the new version of the gem. There are still issues with it but I think it's working better than we first tested this.
If it's still not good enough to use, I can potentially do some work on it to make title matches appear higher in the ranking.


[!IMPORTANT] Shoutouts for first time contributors version 2.7.0

if you want a shoutout for your contributions when the next version releases, please drop me a quick message here or on linkedin at https://www.linkedin.com/in/bjoern-idrinth-buettner/ - I do not bite :)

LAST CALL FOR SHOUTOUTS!