Getting past event logs throws "ValueError: Expected 0 log topics.  Got 1" after adding indexed parameters to event

Version: 3.11.0
Python: 3.6.2
OS: osx
Provider: testrpc

Solidity contracts compiled and deployed using Truffle. I just used the compiled JSON files in my Django App. I was able to retrieve the logs before using the same code. But I encountered this problem after adding an indexed modifier to one of the parameters of the event.
Signature of Event:
EventCreated(uint256 indexed var1, string var2)
Code
# -*- coding: utf-8 -*-
from __future__ import unicode_literals
from __future__ import division

import json
import os
import myapp.settings as settings

from web3 import Web3, KeepAliveRPCProvider
from django_rq import job
from myapp.models import CrowdsaleAddress

web3 = Web3(KeepAliveRPCProvider(host='localhost', port='8545'))

# Setting up of crowdsale contract
crowdsale_address = CrowdsaleAddress.objects.get().deployed_address
crowdsale_json_path = os.path.join(settings.BASE_DIR, 'static', 'contracts', 'CrowdsaleContract.json')
crowdsale_json_file = open(crowdsale_json_path)
crowdsale_json = json.load(crowdsale_json_file)
crowdsale_abi = crowdsale_json['abi']

crowdsale_contract = web3.eth.contract(address=crowdsale_address, abi=crowdsale_abi)

# Setting up of token contract
token_address = crowdsale_contract.call().token()

token_json_path = os.path.join(settings.BASE_DIR, 'static', 'contracts', 'MyToken.json')
token_json_file = open(token_json_path)
token_json = json.load(token_json_file)
token_abi = token_json['abi']

# Brute-force fix for web3.py bug, where constructor does not have a name key
token_abi = [abi for abi in token_abi if abi['type'] != 'constructor']

token_contract = web3.eth.contract(address=token_address, abi=token_abi)

token_contract.pastEvents('EventCreated',
              {"topics": {}, "fromBlock": 0, "toBlock": 'latest'}).get(only_changes=False)

Stack Trace
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "/Users/jantristanmilan/.virtualenvs/myapp-py3/lib/python3.6/site-packages/web3/utils/filters.py", line 178, in get
    self.format_entry(log_entry) for log_entry in log_entries
  File "/Users/jantristanmilan/.virtualenvs/myapp-py3/lib/python3.6/site-packages/web3/utils/filters.py", line 178, in <listcomp>
    self.format_entry(log_entry) for log_entry in log_entries
  File "/Users/jantristanmilan/.virtualenvs/myapp-py3/lib/python3.6/site-packages/web3/utils/filters.py", line 184, in format_entry
    return self.log_entry_formatter(entry)
  File "/Users/jantristanmilan/.virtualenvs/myapp-py3/lib/python3.6/site-packages/eth_utils/string.py", line 85, in inner
    return force_obj_to_text(fn(*args, **kwargs))
  File "/Users/jantristanmilan/.virtualenvs/myapp-py3/lib/python3.6/site-packages/web3/utils/events.py", line 157, in get_event_data
    len(log_topics),
ValueError: Expected 0 log topics.  Got 1

Attempted Fix
I tried doing the following but all it does is return an empty list of logs
token_contract.pastEvents('EventCreated', {"topics":[['0x7ce5c16b5d5fc1f0e2e65d7ee6ffb66bda38387e0ebf566bec33091d5eb1bd85']], "fromBlock": 0, "toBlock": 'latest'}).get(only_changes=False)

token_contract.pastEvents('EventCreated', {"topics":[[web3.sha("EventCreated(uint256,string)")]], "fromBlock": 0, "toBlock": 'latest'}).get(only_changes=False)

Can you post the ABI for the EventCreated event?

It looks like your ABI that you are using with your contract doesn't match the ABI of the event that is being logged.  The error you are receiving is web3 detecting that the log entry it is trying to decode does not match the format that it expects based on the event ABI and so it throws an error.

Oh I just used EventCreated as a template name for a code that reproduces the bug. The sha3 in the first example was an ABI for another function.
But I tried pasting all the sha3 in the JSON and it didnt work either

I tried reproducing the bug again in and it no longer appeared after I recompiled the contracts and repasted the JSON files. I must have committed a blunder in pasting the updated contracts before. Thanks for assisting me!


Recommend using ko apply --strict

Expected Behavior
The docs under DEVELOPMENT.md would call for the user to run ko apply --strict -f config/ since the ko documentation calls that out as a better way to ensure the right thing happens when you are applying local changes to a cluster.
Actual Behavior
It doesn't recommend passing the strict flag.
Relevant section here: https://github.com/tektoncd/pipeline/blob/master/DEVELOPMENT.md#redeploy-controller

Agreed!
/kind feature

/kind documentation

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

/remove-lifecycle stale


Separate the humidity sensor from dehumidifier so I can use it as its own sensor when creating automations. Similar to how the temp sensor is

Is your feature request related to a problem? Please describe:

Describe alternatives you've considered:

Additional context:

I'd like to have a separate sensor for humidity so I can use my dehumidifier's sensor to create automations. Like this temp sensor that is built into my dehumidifier.

This is interesting... HomeKit dehumidifier has current humidity as a characteristic, but the Apple Home app cannot use that as a sensor from which to create an automation... it can only use the on/off state of the dehumidifier.
I think it would be easy to add a separate service for humidity sensor.  I would not separate it, but rather I would leave the current humidity characteristic as it is, but then create a humidity sensor in addition based on a config setting, just like the temperature sensor is created.

I've had issues like this before with other services (like an air purifier filter usage level couldn't be used in automation and such...), so it looks like this is common with accessories in the Home app.

I've published v1.1.0-beta.2 which contains the ability to toggle the humiditySensor config in the plugin configurations which should create the separated humidity sensor. Could you please try it out?

Not my request, but I can say it seems to be working great, I can use humidity level to trigger automations now.

Thanks for the feedback!

Thank you!!  Works perfectly

Great to hear it! I will close this issue as soon as I release v1.1.0.


How make the daterangepicker always visible

Hi, i want the daterangepicker is always visible, but when you press the botton apply update for the ng-model but dont close the picker. Thanks in advancement!.

This is outside the scope of angular-daterangepicker, the clickApply event handling resides in the bootstrap-daterangepicker plugin.


Show raw HTML

Is there any possibility to see the raw HTML that is getting stored when saving? I've seen this in a few editors - you could switch between WYSIWYG and the Sourcecode.

Hi there,
I am sorry, this is not possible at the moment with the tiptap editor.


Homepage link on PyPI points to bitbucket.

I'd file a PR, but it looks like PyPI isn't pulling from setup.py and has its own metadata.  The homepage link is pointing to http://bitbucket.org/cmcqueen1975/cobs-python/ rather then here.
https://pypi.org/project/cobs/

It's something I'd updated in setup.py a while ago. But I hadn't done a release since then that includes the updated metadata.
I've made a release of v1.2.0 today which updates the homepage link.


Add implementation for critical-section 1.0

Picking up #433 since it seems stalled. Changes from #433 are:

Update to critical-section 1.0.0-alpha.2
Use bool restore token
Name Cargo feature critical-section-single-core.

TODO before merging:

[ ] Wait for critical-section 1.0 release https://github.com/rust-embedded/critical-section/pull/19

Co-Authored-By: Markus Reiter @reitermarkus

r? @adamgreig
(rust-highfive has picked a reviewer for you, use r? to override)

Picking up #433 since it seems stalled.

It's not stalled. I was just waiting for another review, same as my other open PRs. Feel free to ping me next time if you want me to rebase a PR.
Thanks anyways for picking this up.
The workflow pull_request change was meant to be temporary so CI can run on my fork.

bors retry
should go after #450 merges...


DOMException on url with multiple trailing slashes

Current behavior
I open: https://demo.vuestorefront.io// (notice trailing //).
Page does not load properly.
https://demo.vuestorefront.io/////////////////////////// has the same behavior.
Expected behavior
I open: https://demo.vuestorefront.io// (notice trailing //).
Page load properly.
I do not know if it should display the same content as https://demo.vuestorefront.io or be a 404 error.
Steps to reproduce the issue
Open: https://demo.vuestorefront.io//
Repository
Can you handle fixing this bug by yourself?

[ ] YES
[x] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[x] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser: Chromium Version 73.0.3683.75
OS: Debian 9

Additional information
Error displayed in browser console tab:
vue-router.esm.js:1697 Uncaught (in promise) DOMException: Failed to execute 'replaceState' on 'History': A history state object with URL 'https:' cannot be created in a document with origin 'https://demo.vuestorefront.io' and URL 'https://demo.vuestorefront.io//'.
    at it (https://demo.vuestorefront.io/dist/vendor.e0b36c61b90a056a40d7.js:20:13257)
    at new e (https://demo.vuestorefront.io/dist/vendor.e0b36c61b90a056a40d7.js:20:19375)
    at new Dt (https://demo.vuestorefront.io/dist/vendor.e0b36c61b90a056a40d7.js:20:23038)
    at s (https://demo.vuestorefront.io/dist/app.e0b36c61b90a056a40d7.js:1:293169)
    at https://demo.vuestorefront.io/dist/app.e0b36c61b90a056a40d7.js:1:346891
    at https://demo.vuestorefront.io/dist/app.e0b36c61b90a056a40d7.js:1:346507
    at Object.next (https://demo.vuestorefront.io/dist/app.e0b36c61b90a056a40d7.js:1:346612)
    at https://demo.vuestorefront.io/dist/app.e0b36c61b90a056a40d7.js:1:345548
    at new Promise (<anonymous>)
    at j (https://demo.vuestorefront.io/dist/app.e0b36c61b90a056a40d7.js:1:345293)

@aloupfor thanks for reporting this issue. It is related with vsf-router https://github.com/vuejs/vue-router/issues/2593 As I see it is fixed in v4 so I think that best way is just wait for it


atlauncher: <IP_ADDRESS> -> <IP_ADDRESS>

Description of changes
### Fixes
- Duplicate libraries with different versions causing issues launching

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Looking at the diff, this could very well be related to #319632.


how to set "SetRedirect" with GetAsync?

I found that Session have member "SetRedirect". How to use cpr::GetAsync to set SetRedirect?
Can cpr::GetAsync use Session as parameter?

Try the following: cpr::AsyncResponse future = cpr::GetAsync(url, false); here the false will set the value for SetRedirect.
I have to say, this is not the most intuitive way to do this, but it works.

I guess this solved it.


Driver Problem

Hi!
I am trying to reproduce the code with only 1 location but I get 2 kind of errors :
ERROR: 'WebDriver' object has no attribute 'find_element_by_css_selector'
Exception has occurred: UnicodeEncodeError
'charmap' codec can't encode character '\u22c5' in position 305377: character maps to

What location are you having this problem with?

I already figured this one out, but now i'm having problem with this part
ERROR: Message: no such element: Unable to locate element: {"method":"css selector","selector":"[aria-label='Next page']"}████████████████████████████████████| 20/20 [00:47<00:00,  2.17s/it]
(Session info: headless chrome=105.0.5195.102)
I changed the code to a new version of Selenium cause of the new CSS Selector. The code run some adresses but then stop and show me this error, and below this one:
Traceback (most recent call last):
File "f:\Codigo Google Popular Times\populartimes-main\populartimes-main\scrape.py", line 26, in
if driver.find_element(By.CSS_SELECTOR, "[aria-label='Next page']").get_attribute("disabled"):
File "C:\Users\ppalb\anaconda3\lib\site-packages\selenium\webdriver\remote\webdriver.py", line 857, in find_element
return self.execute(Command.FIND_ELEMENT, {
File "C:\Users\ppalb\anaconda3\lib\site-packages\selenium\webdriver\remote\webdriver.py", line 435, in execute
self.error_handler.check_response(response)
File "C:\Users\ppalb\anaconda3\lib\site-packages\selenium\webdriver\remote\errorhandler.py", line 247, in check_response
raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.NoSuchElementException: Message: no such element: Unable to locate element: {"method":"css selector","selector":"[aria-label='Next page']"}
(Session info: headless chrome=105.0.5195.102)

It looks like Google Maps has been updated. There's no longer a "Next Page" button, it just scrolls until you get a "You've reached the end of the list." message

I think https://github.com/UoA-eResearch/populartimes/commit/3c516d38c073a6a05243ae8e5eb3d8d84e6e28f2 should fix this, give it a try and let me know how you go

Oh, and also https://github.com/UoA-eResearch/populartimes/commit/5493fc8ebf596f2abf9ab7c82292822bcfe2f100 for the compatibility issue with Selenium 4.3.0 you mentioned

That worked thanks. I just had to change the "pd.read_csv("locations.csv")" to the path of locations.csv, and add "utf-8".


usb: Make driver generic over max interfaces

It would be nice if a default value could be used so old code would mostly just work, but defaults are not used while determining types so adding a default does nothing here.
It would also be nice if we could calculate the number of interfaces needed at compile time, but I'll leave that as an exercise for later.
https://github.com/rust-lang/rust/issues/95486
https://github.com/rust-lang/rust/issues/99727
https://github.com/rust-lang/rust/issues/27336

I’m not a big fan on the generics/turbofish spam this generates. Could you use an associated const in the driver to define the max interfaces a driver supports and use that in the builder? The builder should be short lived and on the stack so a little extra memory usage shouldn’t be a big problem there. The build method could then be generic on the number of interfaces for the device with a default value.

I’m not a big fan on the generics/turbofish spam this generates. Could you use an associated const in the driver to define the max interfaces a driver supports and use that in the builder? The builder should be short lived and on the stack so a little extra memory usage shouldn’t be a big problem there. The build method could then be generic on the number of interfaces for the device with a default value.

I am also not happy with the noise this creates, though it should only require one annotation per device. It is amplified here due to the number of examples in this project that use USB. The only way I can think to decrease this noise in the typical case where a user doesn't need many interfaces and doesn't care about minimizing the number of interfaces is to set a default, but as stated in the top post this doesn't work at the moment as we would like.
As for your suggestion, the maximum number of interfaces isn't dependent on the device but rather how much memory you want to give to store descriptors and interface handlers.

As for your suggestion, the maximum number of interfaces isn't dependent on the device but rather how much memory you want to give to store descriptors and interface handlers.

Ah, right. I was thinking of endpoints not interfaces. Oh well. In that case I can't think of a good alternative to avoid the generic spam and still allow arbitrary numbers of interfaces without excess memory consumption. So this looks ok to me.

@Dirbaio suggested on matrix that we use features to allow for compile time configuration of the max interface value rather than const generics to avoid the generics spam. For example: smoltcp-rs/smoltcp#742

I'm going to close this PR in favor of #1202, which does that. Thanks anyway for the contribution! :)


xGov 106 - Algorand DAO management platform

Your PR number is #107
So the title should be xGov 107 - Algorand DAO management platform
Same issue exist with naming of the file and and also id of the proposal. Both should have the number as 107 instead of 106

Proposer, please post your algorand forum discussion thread link here. Thank you.


Add my name & info in the Contributors file

Pull Request
Proposed Changes

Give a summary of the changes made in the repository.
List the dependencies used.
Also mention the issue number [Fixes #(issue)].

Types of changes made

[ ] Fixed Bug
[ ] Added new Features
[x] Edited Documentations
[ ] Enhanced the working of code
[ ] Additional Changes
Mention any Additional Change here

Additional Info
Provide additional information(if any) you want to convey.
Viability of Code
Describe the tests that you ran to verify the changes made. Mention the tests for easy reproducibility.

Test 1
Test 2

Mention(if any) specific Test Configurations used:

Filmware version:
Hardware:
Toolchain:
SDK:

Screenshots or GIFs (if any)
Attach screenshots of the changes made for easy reference.

Original
Updated

Attach_Original_Screenshot
Attach_Updated_Screenshot

Checklist:

[x] My code follows the Mentioned Guidelines for the project
[x] I have self-reviewed the changes made
[x] I have made the changes easy to understand by adding comments
[x] My changes does not generate new warnings/errors
[ ] I have attached relevant screenshots to display the changes made
[x] I have made the required changes to the documentations

My bad, I will contribute in the next issue. I am getting used to Github and open source, actually

Hey @Elemento24 no problem :) we are all learning here :v: @uglyprincess has added a section for setting up Git and Github that might be useful in the readme.md :tada:


Running script multiple times

"scripts" : {
  "lint": "lint-staged",
  "lint-watch": "npm-watch"
},
"lint-staged": {
    "*.js": "eslint"
  },
"watch": {
   "lint": {
      "patterns": "*",
      "extensions": "js",
      "ignore": "node_modules"
   }
},

I have the above code written in package.json. When I run npm run lint-watch, it runs npm run lint three times each time.
I get the following output:
Sterics-MacBook-Pro:$ npm run lint-watch

>lint-watch /Users
> npm-watch

No task specified. Will go through all possible tasks
[lint] [nodemon] 1.11.0
[lint] [lint] [17:06:15] Running tasks for *.js [started]
[lint] [17:06:15] eslint [started]
[lint] [17:06:18] eslint [failed]
[lint] [17:06:18] → 🚫 eslint found some errors. Please fix them and try committing again.

/Users/tools/static.js
  36:19  error  Unexpected parentheses around single function argument  arrow-parens
  56:21  error  Unexpected parentheses around single function argument  arrow-parens
  58:19  error  Unexpected parentheses around single function argument  arrow-parens

✖ 3 problems (3 errors, 0 warnings)

[lint] [17:06:18] Running tasks for *.js [failed]
[lint] [17:06:18] → 🚫 eslint found some errors. Please fix them and try committing again.

/Users/tools/static.js
  36:19  error  Unexpected parentheses around single function argument  arrow-parens
  56:21  error  Unexpected parentheses around single function argument  arrow-parens
  58:19  error  Unexpected parentheses around single function argument  arrow-parens

✖ 3 problems (3 errors, 0 warnings)

[lint] [lint] 🚫 eslint found some errors. Please fix them and try committing again.

/Users/tools/static.js
  36:19  error  Unexpected parentheses around single function argument  arrow-parens
  56:21  error  Unexpected parentheses around single function argument  arrow-parens
  58:19  error  Unexpected parentheses around single function argument  arrow-parens

✖ 3 problems (3 errors, 0 warnings)

[lint] [lint] [nodemon] app crashed - waiting for file changes before starting...

Why is this happening?

Apologies for the late reply.
I am not sure why this happened. If you are still having this problem, please open a new issue and provide a sample that reproduces the problem


Fix SaintCoinach type cast exception when only one language is available.

In this situation, AvailableLanguages.Count() is 1, which is same count as Language.None.
The localized sheet is create as DataSheet insted of MultiSheet, then the language suffix(e.g. "item_chs") crashes the type casting.
Only tested on offical and chs client, so I leave cht and kor disabled.
Godbert's hardcoded to english on initialization, it will still crash in this situation.

I'm not sure why there is cht in the game files, it is CHS exported anyway and the client for Chinese is only simplified. I can test on KR client if you want to enable it.

I think this should work, as you can use allrawexd on KR client. The language flags and enums are same. So i just enabled all languages.
You can try whether exd command works on KR client, just in case.
e.g. :
lang 7 //switch to korean
exd item

How are you detecting game path? Chinese and Korean have different install paths?
This is how I did it: https://github.com/viion/SaintCoinach/commit/f8bf39c26fba5a5bb3cc72a1d649dca3de29a3d9#diff-41f93fcd2cbd5d1cfb6d2e9833cf82de

rawexd Works from there, is there a need for allrawexd on Korean when only 1 language?

Yes, no need for allrawexd. exd <content> works indicate this PR fix the type casting.
Personally, I wrote 2 batch file in two folders for offical and chinese clients.
e.g. :
@echo off
"X:\Projects\SaintCoinach\SaintCoinach.Cmd\bin\Debug\SaintCoinach.Cmd.exe" "X:\games\FFXIV\"

Then the file will be exported to the folder where the batch file is located.
Create a shortcut to SaintCoinach.Cmd.exe, adding arguments and changing "Start in" should work same.

exd <content> won't work for some stuff in Korean, especially Actions since they're pre 4.0 changes, but that is too be expected :)
Good PR! 👍

Sorry this took so long to merge!  I'll monitor this over the next few 4.2 patches.


A little change in the cheatsheet you provided.

Your cheatsheet's webpage: https://www.learnpytorch.io/pytorch_cheatsheet/
Your cheatsheet's path: https://github.com/mrdbourke/pytorch-deep-learning/blob/main/extras/pytorch_cheatsheet.ipynb
In codeblock 11 (In [11]):
# Setup device-agnostic code
if torch.cuda.is_available():
    device = "cuda" # NVIDIA GPU
elif torch.backends.mps_is_available():
    device = "mps" # Apple GPU
else:
    device = "cpu"

print(f"Using device: {device}")

Returns: AttributeError: module 'torch.backends' has no attribute 'mps_is_available'
Here's what ChatGPT has to say about this:
It looks like you are trying to use the mps_is_available attribute of the torch.backends module, but it is giving you an error saying that the attribute does not exist.
This attribute was used in older versions of PyTorch to check whether the Metal Performance Shaders (MPS) framework was available on the system. However, this attribute has been removed in newer versions of PyTorch.
Instead of using torch.backends.mps_is_available(), you can use torch.backends.mps.is_available()

Yes, I confirm it gives an error too.

Thank you for this!
I didn't know that! Looks like ChatGPT is an epic troubleshooter.
I will fix it this coming week!


feat(commander): Refactor commander code

Decouple commander component from dope.
Added Dockerfile and Makefile for commander component.

Signed-off-by: Rohan Kumar<EMAIL_ADDRESS>

:tada: This PR is included in version 1.11.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


get_tree() code completion does not work

Godot version: 3.0.6
OS/device including version: Windows 7
Steps to reproduce:
gif

I think that would be hard to code without code completion at all=)

You need to open a scene where this script is used for get_tree() to be able to resolve to anything. If no corresponding scene is open, there's no SceneTree to match against.

@akien-mga this is a global script that extends Node that in turn has get_tree() method (and it returns SceneTree). I expected that to be enough to at least suggest me some methods / fields that all SceneTree-s have. So I do not understand the reasons to match against an existing SceneTree

the autocomplete for get_tree() works for me,   when no scene is opened. i'm on 962c14278fafecf3d047fd070fc7ab8d4dcc21da though

@girng
the point is to try get_tree().<cursor here> in the script that has been created as resource and included in auto-load. Thus it is not attached to any node of any existing scene. Did you try with that in mind?

@akien-mga
@girng
I've updated the initial message with minimal reproduction project. Check it out and let me know if it works for you.

This should work on 3.1, since the auto-completion was extended to add types and inheritance into account. I don't see an easy way to fix in 3.0.

@vnen thanks, I'll check it out later on 3.1 and let you know the results

I've checked it out in Godot 3.1 and it works quite well! Thanks all for the help, I'm closing this issue.


[BUG] Search request with PIT + searchAfter and 2 sort fields loses some hits

Describe the bug
https://github.com/opensearch-project/OpenSearch/issues/15869
Executing a search request with a PIT + searchAfter and 2 sort fields (first one is not uniq, second one is uniq) returns less hits in total that for track_total_hits. The smaller the page size, the more data is lost,  if you use scrolling, there is no problem. if you change the sorting values (only 1 uniq or first one is uniq and second one is not uniq), the problem also disappears
Related component
Clients
To Reproduce
How can one reproduce the bug?
create a search request with a PIT and 2 sort fields like
 PointInTimeBuilder pointInTimeBuilder = new PointInTimeBuilder(pitId);
 SearchSourceBuilder searchSourceBuilder = new SearchSourceBuilder()
                .pointInTimeBuilder(pointInTimeBuilder);
        searchSourceBuilder.query(<query>);
        searchSourceBuilder.sort(SortBuilders
                .fieldSort(<not uniq field>)
                .order(SortOrder.ASC));
        searchSourceBuilder.sort(SortBuilders
                .fieldSort(<uniq fiel>)
                .order(SortOrder.ASC));
        searchSourceBuilder.size(10_000)

_____________

"sort": [
  {
      "<not uniq field>":{
        "order": "asc"
      }
    },
    {
      "<uniq fiels>": {
        "order": "asc"
      }
    }
  ]

run this query several times using searchAfter like:
searchSourceBuilder.searchAfter(prevSearch.getHits().getHits()[prevSearch.getHits().getHits().length - 1].getSortValues());
SearchRequest searchRequest = new SearchRequest();
searchRequest.source(searchSourceBuilder);
restHighLevelClient.search(searchRequest, RequestOptions.DEFAULT)

and notice that in total you have less hits that returns in track_total_hits:
total using PIT = 1999953
"total": {
"value": 2000000,
"relation": "eq"
}
Expected behavior
A search response in total returns the same number of hits as for track_total_hits
Additional Details
SpringBoot application

@Anastasiia186 Want to try and turn this into a failing YAML REST test?

@dblock we rechecked the second field and found some duplicates...we removed them and now it works fine
thank you!


[BUG] MEDIA_LICENSE error every 30 minutes

Hi
Describe the bug
Every 30 minutes I receive MEDIA_LICENSE error which stops playback. After that, I can't play any music. Only restarting the app fixes it. It happenes on 2.50 stable and 2.50 alpha 1. I have tried to reset settings but it did not work. It happens for at least a week.
To Reproduce
Steps to reproduce the behavior:

Play any music for around 30 minutes
See the error

Expected behavior
Uninterrupted music playback or possibility to at least resume it.
Screenshots

Desktop (please complete the following information):

OS: Windows 10 21H1 (build 19043)
Application Version 2.5.0 alpha 1

Log File
Check your log file for any errors or the last message to be sent and post them here.
Additional context
Add any other context about the problem here.
Have you followed the troubleshooting guide found here and checked for any outstanding/pinned issues that can help?
Yes
main.log
I dont know why log is so old. It happened again right before creating this thread.

Yeah, I get this issue a lot too, its an issue with AM's site.

Has this been happening to anyone else since this issue was made recently?

+1 for serpent#0815 in the Discord

2 days ago it was still happening. Music via iTunes works fine though.

This app will be sunseted very soon and we are NOT maintaining this app
unless of a security issue. We encourage you to try Cider, our new music app built from scratch. Issues filled on that repository will be seen and will be acted upon. Please join our discord and see the #nightly-builds channel for a current build.
Cider can be found here


Block discount rate whe no duration and update callout

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #2343

PR #2341

PR #2342

PR #2344

PR #2345

PR #2346   👈

This comment was auto-generated by Graphite.


Add support for modifying relationships between entities in odata v4

OpenUI5 version: 1.54.8
The OData V4 implementation does not support updating relational property of an entity as described in the OData specs.
E.g. I would like to update the navigational property named "RelatedEntity" alongside other primitive properties, which could be achieved by the following HTTP-Request:
PATCH [...]/Service.svc/MyEntitySet('XXX')
Content-Type: application/json
[...]

{
  "MyProp": "UpdatedValue",
<EMAIL_ADDRESS>"MyEntitySet('YYY')"
}

There is no API that would allow me to set<EMAIL_ADDRESS>"MyEntitySet('YYY')" and submit these changes. Trying to set/access a property named<EMAIL_ADDRESS>results in an error (Failed to drill-down into<EMAIL_ADDRESS>invalid segment: RelatedEntity@odata.bind).
Interestingly, you can include<EMAIL_ADDRESS>"MyEntitySet('YYY')" in the initial data of sap.ui.model.odata.v4.ODataListBinding#create and it will get sent to the backend correctly. Is there a similar workaround for updating an entity?
I am aware of the limited support of OData v4, but I would appreciate at least a workaround to be able to set these "special" properties in order to modify relationships. The SalesOrders Example seems to assume that the relation is set by the backend service by interpreting primitive properties (but doesn't actually, since it's just a mocked backend). However, this does not seem to be in line with the idea of OData and it's relationships.

Hi @tobias-- ,
there are two options for communicating the relationship between entities to the backend.

by using @odata.bind
by explicitly modelling the relationship with foreign keys and setting the foreign keys

Option 2. is working already.
Option 1. is on our backlog as CPOUI5UISERVICESV3-699. It seems unlikely that we will work on it in the next months.
Best regards
Mathias.


BucketAggregateBase is not a BucketBase

Nest version: 7.3.0
We have a quite simple aggregation that could be really straight or date histogram-based.
Here just example:
var result = bla bla bla.Aggregations(pPerformanceAgg => {
                       var mainAggregation = new AggregationContainerDescriptor<P>()
                                    .Sum("v", vTerm => vTerm.Field(p => p.v_count))
                                    .Terms("r", rTerm => rTerm.Field(p => p.r) ));

                       if(dateAggregation == DateAggregation.None)
                       {
                           return mainAggregation;
                       }

                       return pPerformanceAgg
                        .DateHistogram("date", b => b
                        .Field(p => p.date)
                        .CalendarInterval(dateInterval)
                        .Aggregations(rAgg => mainAggregation));
                   })
             )));

So basically we have as result a BucketBase (in case dateAggregation is DateAggregation.None) or DateHistogramBucket/SingleBucketAggregate (in case dateAggregation is Day/Week/Year)
What I have found is there is no relation between those two bucket class types. I have just to read values and terms using the same mapping method but it is impossible to cast correctly buckets.
In conclusion, now we have two identical methods just to overcome the casting problem:
 private void MapPStatistics(BucketBase aggregate)
        {
            var vAggregate = aggregate.Sum("v");
.......

and same but different method firm in case of DateHistogram
 private void MapPStatistics(SingleBucketAggregate aggregate)
        {
            var vAggregate = aggregate.Sum("v");
.......

My question here is ..why BucketAggregateBase is not also a BucketBase? Any correct approach to avoid code duplication without instantiate new object based on a common bucket class type?
Thanks.

Thanks for raising @meriturva.
You are correct, there is currently no relation between BucketAggregateBase and BucketBase. Looking at the code it seems like we could consider consolidating this type hierarchy, which would then allow you to simply your method overloading solution.
We are currently planning breaking changes work for 8.0, so I will add this item to the discussion.

We will address hierarchy of types in code-gen work for v8. Please let us know if this issue is still a relevant priority for your usage?

Thanks @stevedodson ...issue still relevant due to the fact that we just would like to remove few duplicated methods.


Keyboard: Save 240 bytes of flash.

Move definition to a table.
Set and read the pins all at once.
Drop extra delays.
Use existing I2C_Stop to generate proper stop condition.

Good work !
Thank you

Thank you for the fast response.


Finish up the console

Lower priority, but it would be nice if the console were more fully featured (pwd, mv, etc)

This would be even lower priority, but it would be cool if the console could support some basic Unix shell features (simple control flow like && and ||, pipes for stdin/stdout, aliases, etc).


backport #16786 and #16286

use CLUSTER_PROVIDED instead of ORIGINAL_DST_LB #16286
Pilot: only generate passthrough infra with ip versions provided by proxy #16786

@rlenglet To resolve cherry-pick conflict I cherry-pick PR 1 as well. I confirmed it is low-risk.
CC author of 1st PR @XanderStrike
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Why cherrypick the CLUSTER_PROVIDED one? It should be fine just wondering the motivation for it

@howardjohn
The feature CLUSTER_PROVIDED is not needed.
The intend PR #16786 relies on the interface updated by CLUSTER_PROVIDED pr.
I could extract the some change as partial of #16286. I would rather introduce the low-risk PR as a whole.


Include version number in module names

QuitarHero at 1/16/2020 5:19:15 AM +00:00

Suggestion:
Add version number to module names.

Conversation Reference:
https://discordapp.com/channels/531175899588984842/534492173362528287/667234287669477397

REF: https://discordapp.com/channels/531175899588984842/534490472224391169/667236404895547404

This is kind of outside of the scope of the project and just comes down to whatever naming convention developers use when sharing their modules.  Outside of that, it can become difficult to upgrade your modules in place as it is if the names are different as you'll have to manually remove the old versions while importing the new ones since they won't just replace them when copied to the modules directory.
This will all be unnecessary anyways once module management from the bhud-pkgs repo is supported.


Smaller pull request

Rename file keybind.go to key_input.go:
This is for future refactor with new engine.
Reorder functions in board, no other changes:
Pull the functions that call other function on top of the functions they call. Also move some of the functions that will be refactored (removed) to the bottom
Switched to "github.com/nsf/termbox-go" in vednor:
As commented
Added ProcessEvent:
ProcessEvent will be used for later refactor  with new engine. It also makes it easier to see the loop apart from the key commands. Additionally, later, it make for the use of if return style shortcut instead of if else style.
Reorder, no other changes
Pull the functions that call other function on top of the functions they call. (Missed some in first pass.)
Simplify isFullLine:
As commented
Refactor key_input.go, use switch:
As commented
Moved currentMino and nextMino into board.go:
As commented. Also moved const that are used in 2 or more files into tetris.go
Add bump for rotateRight and rotateLeft for one wall:
As commented. Also moved const that are used in 2 or more files into tetris.go.
Removed string Replace (More of a style change at this point.) After engine refactor is done, would like to see about changing these to slices.
After engine refactor would like to look at bump for other wall and make sure rotation is well and good. :)
http://tetris.wikia.com/wiki/SRS

Commit message can have multiple lines. Please write comments in description to commit message.

Rename file keybind.go to key_input.go:
This is for future refactor with new engine.

Don't include _ in filename. This is not preferred in Go. It has special meaning. Usually it is keyinput.go.

Reorder functions in board, no other changes:
Pull the functions that call other function on top of the functions they call. Also move some of the functions that will be refactored (removed) to the bottom

Not reasonable. The functions' orther don't have meaning in functionality. Just replacing positions makes it hard to read commit log or git blame. This commit is not acceptable at all.

Reorder, no other changes

Again, not acceptable. Just cosmetic changes are usually prohibited for other open source projects.

Fix key_input to keyinput without making another commit.  Edit old commit.
Remove commits for just moving from this branch.
Again and again, WRITE COMMENT IN THE SECOND LINE OF YOUR COMMIT MESSAGE.

I have no time. I'll ignore the PR sent from person who doesn't understand how to use git next time. Be careful to edit this PR.

Thank you for your comments. I am very sorry that my commits and use of GitHub are not to your likely. Just wanted to help improve upon the great work that you have done.
Please keep in mind that there is no one way that people use GitHub. Many people have different requirements that they do and do not want in there project. May I suggest writing up your guidelines and posting them somewhere, then linking them in your readme file?

It's okay. I hope you finally understand how to use git/GitHub during writing guidelines and send well-formatted PR next time!


Preset download cancelling

The "Faded" preset corrupts if you start the download and then press back. The download doesn't continue in the background it seems.

There will be an download notification or a back press fallback dialog

download notification not disappearing

the download actually continues on background, and added a download notification.


add support to handle custom resources

Please add support to handle custom resources.

@bluebrown I think you are looking for https://www.martin-helmich.de/en/blog/kubernetes-crd-client.html


doc: Move and reorganize all newly written docs for v0.8

This GitHub issue is for the reorganization of all newly written docs for v0.8, which we wrote as part of https://github.com/openservicemesh/osm/issues/2854

All docs that we plan to move to the osm-docs repo have been moved, and now all open issues we plan to move to this repo have also been moved. As we have https://github.com/openservicemesh/osm-docs/issues/84 which goes into more detail regarding reorganization, I'll close this issue now.


Added Merge Sort [Golang]

Fixes #356

By submitting this pull request I confirm I've read and complied with the below declarations.

[x] I have read the Contribution guidelines and I am confident that my PR reflects them.
[x] I have followed the coding guidelines for this project.
[x] My code follows the skeleton code structure.
[x] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[x] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

Why does it have euclidean_gcd/euclidean_gcd.go rebase please.


Interruptions not working with Twilio

I ran the sample code for Twilio examples/twilio-chatbot but noticed that the user cannot interrupt the AI. I even set the handle_sigint in the PipelineRunner parameter to False but it's still not working. My hunch is that the voice output is already sent to Twilio and therefore cannot be interrupted.

I am facing the same issue. Any luck?
I tried pushing different frames like CancelFrame etc when StartInterruptionFrame frame is broadcasted but no luck. How to fix it?

I try to use "clear" message to stop the twilio output audio and it work
if isinstance(frame, StartInterruptionFrame):
    answer = {"event": "clear", "streamSid": self.stream_sid}
    await self._websocket.send_text(json.dumps(answer))

ref: https://www.twilio.com/docs/voice/media-streams/websocket-messages#send-a-clear-message

answer = {"event": "clear", "streamSid": self.stream_sid}
    await self._websocket.send_text(json.dumps(answer))

@nulyang thank you so much. It worked for me as well like a breeze. Appreciate your support!

@nulyang Thanks a lot! This worked for me as well. Might be worth adding this to the library.

@nulyang @nisalr Where should the clear websocket call be made in the twilio example? Or is this fix applied inside the internal code of the package?

Hey @xypnox I added a interruption handler between the stt and tma_in
class InterruptionHandler(FrameProcessor):
    def __init__(self, websocket_client: WebSocket, stream_sid: str, call_id: str):
        super().__init__()
        self.websocket_client = websocket_client
        self.stream_sid = stream_sid
        self.call_id = call_id
        self.last_text_frame_time = time.time()
        self.time_since_last_text_frame = 0

    async def process_frame(self, frame: Frame, direction: FrameDirection):
        if isinstance(frame, StartInterruptionFrame):
            buffer_clear_message = {"event": "clear", "streamSid": self.stream_sid}
            await self.websocket_client.send_text(json.dumps(buffer_clear_message))
        await self.push_frame(frame, direction)

The interruption handler is instantiated
interruption_handler = InterruptionHandler(websocket_client, stream_sid, call_id)

and the Pipeline is defined as
pipeline = Pipeline([
    transport.input(),   # Websocket input from client
    stt,                 # Speech-To-Text
    interruption_handler, # Interruption handler
    tma_in,              # User responses
    llm,                 # LLM
    tts,                 # Text-To-Speech
    transport.output(),  # Websocket output to client
    tma_out              # LLM responses
])

Twilio interruptions support was added in Pipecat 0.0.42. Closing.


Training scripts for pre-trained models?

Hello,
Is there a way to access the training script with which the resnet models were trained?
Thank you!

Yes, they were all trained using the same script https://github.com/pytorch/examples/tree/master/imagenet

@fmassa  Would you mind providing some detailed hyper-parameters such as number of GPUs, LR, weight decay? Because the parameters for MobileNet and ShuffleNet are quite different from the family of ResNets.

Yes, they will all be present in https://github.com/pytorch/vision/tree/master/references/classification

Thanks. Look forward to the future references

Did you guys use seed

Yes, they were all trained using the same script https://github.com/pytorch/examples/tree/master/imagenet

Did you guys use —seed?

@RuiWang1998 for newer models, they have implemented using the training scripts from https://github.com/pytorch/vision/tree/master/references , and we do not fix the random seed by default.


new paltform = electron, or node.js

I recently posted a new project, electron-firebase, as a Web type platform, but that isn't quite right. It's an electron project that doesn't fit the current platform definitions. It could also be a node.js platform, or PC Client type.
Thanks for considering a new platform type!

@david-asher thanks for the feedback!  We don't have a ton of Electron/Node.js client projects on here so not sure that's deserving of its own top-level category but maybe something like "Desktop" would work?


ilm:0.1.0

I am submitting

[x] a new package
[ ] an update for a package

Description: 'Ilm A versatile, clean and minimal template for non-fiction writing. The template is ideal for
class notes, reports, and books. It contains a title page, a table of contents, and indices for different types of figures, and a dynamic running footer which contains the title of the chapter. See the example.pdf file on 'Ilm's repo to see how it looks.

I have read and followed the submission guidelines and, in particular, I

[x] selected a name that isn't the most obvious or canonical name for what the package does
[x] added a typst.toml file with all required keys
[x] added a README.md with documentation for my package
[x] have chosen a license and added a LICENSE file or linked one in my README.md
[x] tested my package locally on my system and it worked
[x] excluded PDFs or README images, if any, but not the LICENSE

[x] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

Very nice, thank you!


Problem opening container into VM

I am having troubles to opening the container into the virtual machine. this is that it "stops"( does not get to move any more)

Dear @joaco-valenverguen ,
Unfortunately there is not enough info to actually know what may be happenning to you.  I am closing this issue with the hope the issue goes awayt by itself in your laptop.
Thank you for posting.


e2e_inference: Update README

Update README.md:

Minor changes to content and grammar
Intel Data Center dGPU card to Intel® Data Center GPU Flex Series
word change dGPU to GPU
Signed-off-by: Veenadhari Bedida<EMAIL_ADDRESS>

@hershpa can you help review the PR.

@hershpa please help review

Will submit a new PR

Will submit a new PR


在官方环境，下载样例数据失败

https://mass-office.alipay.com/huamei_koqzbu/afts/file/pjilTbaCECgAAAAAAAAAABAADnV5AQBr/bank.nodes.xlsx
https://mass-office.alipay.com/huamei_koqzbu/afts/file/UOj4R7u2sRoAAAAAAAAAABAADnV5AQBr/bank.edges.xlsx

这是一个展示bug，下个迭代我们修复掉

https://mass-office.alipay.com/huamei_koqzbu/afts/file/pjilTbaCECgAAAAAAAAAABAADnV5AQBr/bank.nodes.xlsx
https://mass-office.alipay.com/huamei_koqzbu/afts/file/UOj4R7u2sRoAAAAAAAAAABAADnV5AQBr/bank.edges.xlsx

The URL you provide can not download also. So I wanna a description of how to create an upload file for my data, And I don't know the column name and the format.


Download kernel headers from linux repository instead of image-kernel

done https://github.com/cartesi/machine-emulator-tools/commit/24716ca573e7df82d8e626da0efa7e5aaa2d89fd


Add --argument-passthrough option

Fixes https://github.com/kimmobrunfeldt/concurrently/issues/33
Add --argument-passthrough option
Barebones example
concurrently --argument-passthrough "echo foo" "echo bar" -- --some-arg
->
echo foo --some-arg
echo bar --some-arg

With npm scripts
concurrently --argument-passthrough "npm run foo" "npm run bar" -- -- --some-arg
->
npm run foo -- --some-arg
npm run bar -- --some-arg

Todo

[ ] Figure out best way to test this (suggestions welcome)

@kimmobrunfeldt Friendly ping for thoughts and timeline

@gustavohenke Having no options seems fine. Any thoughts on how to test?

Codebase changed significantly and this PR has been inactive for a good time.
I'm closing it; feel free to open an issue to discuss the approach before starting over.


fix: using shared default export in mjs module

What kind of change does this PR introduce?

bugfix
Did you add tests for your changes?

yes
Does this PR introduce a breaking change?

no
What needs to be documented once your changes are merged?

When importing a shared module from .mjs, the default variable refers to the module object instead of the default exported value.
This codesandbox shows a minimal repro. The console shows that Vue points to the module object, which should have been Vue.default instead.

I don't think it is a valid fix, you need more complex logic, look at code the getExportsType in other places


Inflict Pain

https://www.d20pfsrd.com/magic/all-spells/i/inflict-pain/

Implemented in Expanded Content.


[FEA] Support accelerated write to Hive delimited text

The Spark RAPIDS plugin does not currently support writing Hive delimited text files. It would be good to add this, so as to support queries like:
CREATE TABLE my_text_table AS SELECT ...

This should accelerate the write to my_text_table. For the moment, the supported types can be kept identical to those that have read support. i.e. All types except:

STRUCT
ARRAY
MAP
BINARY

This will involve adding CUDF JNI support for writing CSV files, assuming that this follows the same convention as the read path in its implementation.

If we are not doing an escape I think we can do a lot of this without that.  We can cast the columns to strings, and then concat the strings with the separator in between them, then finally concat the lines with a line separator.
The biggest problem is going to be with how we write out things like decimal values and floats.

Specifically using the APIs at
https://github.com/rapidsai/cudf/blob/b14f1dcce526fae74b4b41b1a5e431bf493925ba/java/src/main/java/ai/rapids/cudf/ColumnVector.java#L583
and
https://github.com/rapidsai/cudf/blob/b14f1dcce526fae74b4b41b1a5e431bf493925ba/java/src/main/java/ai/rapids/cudf/ColumnView.java#L1841

Argh. This is a dupe of #6419. I'll update there.


Conversion from VN-100 frame to vehicle frame

Testing on the bench top we found the pitch and roll values must be multiplied by -1 coming out of the vector nav to correctly command mission PID values. Need to pick the right spot to do this. One option is in the pose_estimator.cpp when assigning the orientation values.

One option is in the pose_estimator.cpp when assigning the orientation values.

Either in there or in the vectornav driver node :+1:

I just want to make sure I don't mess up the automated tests. For example if changing pitch to - pitch on line 257 of pose_estimator.cpp do we also need to change line 270


new features: thread_rng, impl_rng_core, and versioned glam

thread_rng adds support for thread local random number generation.
impl_rng_core implements the RngCore and SeedableRng traits from rand.
You can now choose which version of glam. you wish to use by using the glam_02x feature.

This pr was created because I wanted to use frand in a bevy game I'm working on, but I needed the thread_rng support.
I was originally going to just fork the repo, but I thought I'd clean it up and open a PR to see what you thought.
I'm open to feedback or modifications, just thought you mind find this useful.

Do you need multiple versions of glam, or just the latest ones?

How about just making the glam version to 0, and then the version will be specified on the user side

I just wanted multi version compatibility because bevy often lags behind the latest by a few versions.
Re: version 0, that could work, I never thought of doing it that way. I'll give it a shot and update.

@engusmaze how does it look now?

I've made a few changes. I like the idea of ThreadRng, it's much faster to have a per-thread rng than to recreate the rng every time you want to use it from somewhere else. So I made it so that ThreadRand doesn't depend on rand_core, but only depends on std because it needs to use thread_local and Rc. I also took impl_rng_core but split it into a different file.
I also want to ask, which part of rand did you need that you decided to make an implementation of RngCore?

I  wanted to be able to use (https://docs.rs/rand/latest/rand/distributions/) if i remember correctly. If there's an alternate way to do so I'd be happy to try to simplify things. 😄


do not pass branch to job creation for github pull requests

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


remove chmgen (d.chm, dman)

see https://github.com/dlang/installer/pull/298
too much maintenance for too little gain

We need chmgen to lint the generated HTML, so we should not remove it. See https://github.com/dlang/installer/pull/298#issuecomment-366448221.

We need chmgen to lint the generated HTML, so we should not remove it. See dlang/installer#298 (comment).

Mmh OK, could you please turn it into a linter only tool then?
Stuff like this is really not helpful http://nightlies.dlang.org/dmd-master-2018-02-17/build.html.

Mmh OK, could you please turn it into a linter only tool then?

Well, from where I'm standing, that seems like an over-reaction at this point.

Stuff like this is really not helpful http://nightlies.dlang.org/dmd-master-2018-02-17/build.html.

Feel free to contact me directly when that happens. But that really should be caught by our CI.

Well, from where I'm standing, that seems like an over-reaction at this point.

It's not, I've asked for this several times, and it remains a common nuisance. Again 4 complex issues last year, and 39 nightly build failures (partly b/c I cannot jump onto every failure). I've prolly spent 10 hrs. debugging and trying to fix chmgen last year.

Having it as a linter in out CI path seems useful and works b/c issues are catched before being merged (and come with a html diff). Running into d.chm build issues in a release is way too late.

Again 4 complex issues last year, and 39 nightly build failures (partly b/c I cannot jump onto every failure).

What are they?
Please email me when something like this happens, I'll try to address it quickly. I would like to keep maintaining chmgen.

I've prolly spent 10 hrs. debugging and trying to fix chmgen last year.

I don't understand how that can be. Looking at the commit log, you have made 1 commit involving chmgen.d, and I made 18. Did I miss something?

Running into d.chm build issues in a release is way too late.

We don't test actual chm generation currently, because that can only be done on Windows.
We can test dman on any platform, though.
Do you think you could make it a soft failure, so that it doesn't block a release? Then, let me know and I'll try to fix it.

Do you think you could make it a soft failure, so that it doesn't block a release? Then, let me know and I'll try to fix it.

Either we ship a tool or we don't, a soft failure doesn't make sense for releases. It's not the nightlies, but more the delays this introduces in our release schedule.

I've prolly spent 10 hrs. debugging and trying to fix chmgen last year.

I don't understand how that can be. Looking at the commit log, you have made 1 commit involving chmgen.d, and I made 18. Did I miss something?

Yes bug reports and reproducing, hence search chmgen.
https://issues.dlang.org/show_bug.cgi?id=15864
https://issues.dlang.org/show_bug.cgi?id=16167
https://issues.dlang.org/show_bug.cgi?id=17731

The current issue again is caused by broken json generation which isn't CI covered.
https://issues.dlang.org/show_bug.cgi?id=16167

Changed this PR to only remove d.chm and dman from the release target.

https://issues.dlang.org/show_bug.cgi?id=15864

Not a bug in chmgen... looks like good dogfooding. But if it wasn't caught by CI, then that is a problem.

https://issues.dlang.org/show_bug.cgi?id=16167

That looks like the same as http://nightlies.dlang.org/dmd-master-2018-02-17/build.html. Yes, it looks like a regression in something surrounding chmgen. It should have been caught by CI.

https://issues.dlang.org/show_bug.cgi?id=17731

Not a bug in chmgen, but I fixed that on the same day it was filed. I would also file that under dogfooding.
Sorry, but right now this still seems like an overreaction.

https://github.com/dlang/dlang.org/pull/2213

Sorry, but right now this still seems like an overreaction.

Those tools (we're only talking about the d.chm and dman, not HTML linting), provide very little value. It's unreasonably that you and I spent so much effort on this. This is time that could go into improving/replacing Jenkins, improving code.dlang.org, reviewing&merging the MinGW toolchain, working on @safe @nogc.
But instead we work on obscure macro generators to output json files, that are used to index our website and an offline copy of it :o. If you feel like maintaining that, that's fine for me, but I cannot afford the time and certainly no longer want this to be in our release pipeline.

I'm totally with Martin here, I also had to waste time with chmgen and as Martin I don't enjoy it either:
https://github.com/dlang/dlang.org/pull/2200
FWIW I even tried to trackle the problem before. See e.g. the still open https://github.com/dlang/dlang.org/pull/2087 from January which shows that the interest in this is little.

Those tools (we're only talking about the d.chm and dman, not HTML linting),

Yeah the linter would very useful, but FWIW it's not active at the moment because last time I checked too many URLs were broken. (Until my hotfix in https://github.com/dlang/dlang.org/pull/2200 it wasn't even run on the CI).
Maybe we can tackle this with a blacklist, s.t. no one has to do the hard work of fixing all URLs at once, but dump the blacklist file somewhere which can then be reduced in individual PRs step by step?
At least this would prevent regressions.

FWIW dman and d.chm have now been removed from the 2.079 release - see https://issues.dlang.org/show_bug.cgi?id=18610
And there hasn't been a big outcry yet though there was a bit of discussion on the NG one month ago<EMAIL_ADDRESS>We should have just added the removal to the 2.079 changelog so that people are aware of this.


Generate and display blockies for wallets

Blockies like https://github.com/ethereum/blockies. Maybe there's a Swift version?
2 places:

Left of navigation bar in Wallet tab (screenshot below)
Rows in "Change Wallet" screen zpl.io/bWn60RP

@hboon i found pod JdenticonSwift for generation blockie icon, it generated icons like this
https://github.com/alejandro-isaza/jdenticon-swift
is it acceptable to use it?

also there is https://github.com/Boilertalk/BlockiesSwift, but it doesn't work for me (generates only gray squares)

also there is https://github.com/Boilertalk/BlockiesSwift, but it doesn't work for me (generates only gray squares)

i don't know how but it become to work


Fix some clippy warnings

Hey nice! I don't have CI set up on this currently, but I'll test it locally for now :)
Just curious, are you using this project for anything in particular?

Not this, I found out about https://github.com/tonarino/innernet and I am just playing with it "for fun". I just saw this repo in the same organization and such clippy fixes are one of lowest hanging fruits possible (maybe besides spelling fixes)

What do you mean you coudlnt get to set it up? It seems to work good in #12 and I think it should complete succesfully if you rebase on current master

Ah, because it builds the gui example, it depends on egui, which needs some extra OS dependencies to work. I probably just need to copy what egui installs in its CI scripts to get it working.

it seems to only mis libxcb


You should mention layout file name when changing SimpleExoPlayerView

step
https://codelabs.developers.google.com/codelabs/exoplayer-intro/#6
starts with:
The first simple customization is whether to not use the controller at all. This can be done easily by using the use_controller attribute on the SimpleExoPlayerView element. Set it to false and the control does not show up anymore:
would be good to remind the reader that this is in activity_player.xml
Further down other examples mention that. So maybe move that hint up or always have them.

Filename has been added to text


No beacons during the last week

I have a RAK V2 and for a couple of days it's not beaconing. I upgraded the antenna from standard to 5.8 dbi... still nothing. However, during discovery tests I get between 30-40 responses.
Any idea/help is much appreciate 🙏🏾

sorry, this isn't the right place to file this issue. please see discord #announcements for the latest updates on beacons.


MIPS: Fix two bugs

Commit ID 47b639c:
The swap test case will call sswap_msa.c and dswap_msa.c files in MIPS environmnet.
When inc_x or inc_y is equal to zero, the calculation result of the two functions will be wrong.
This patch adds the processing of inc_x or inc_y equal to zero, and the swap test case has passed.
Commit ID ad38bd0:
The cgemv and zgemv test case will call cgemv_n/t_msa.c zgemv_n/t_msa.c files in MIPS environment.
When the macro CONJ is defined, the calculation result will be wrong due to the wrong definition of OP2.
This patch updates the value of OP2 and passes the corresponding test.

@yinshiyou @gxw-loongson @jinboson, I'd like you to do a code review.

LGTM.


Jesse: Watch fenstoneofficefurniture.co.uk

Jesse requests the watch of the watch_keyword fenstoneofficefurniture\.co\.uk. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Jeff Schaller in Charcoal HQ


Cannot specify dependencies on package versions

I use a large number of Asset Store packages in my daily workflow across various projects, many of which reference different versions of common dependencies, particularly the Standard Assets.
I've been working on my own solution to try to isolate or 'sanitise' asset packages (to track versions and prevent conflicts between them), but would it be possible to add dependency versions into Projeny to allow two packages to depend upon different versions of the same dependency, and have both of those versions imported and correctly referenced, even if it meant refactoring code as part of the process?

In this first implementation, we decided to not use versions because that adds a lot of complexity and it's quite complex as it is - and also that potentially leads to the "diamond dependency" issue.  However, in theory it could work, we would just have to ensure that within a single project there is only one definitive version for a given package.  So if you tried to initialize a project that had different versions referenced in it then projeny would trigger errors.
We could migrate current projects by always assuming latest version when unspecified.  Then I suppose we'd have to add sub-folders under each package folder for each version.


Fedora packaging need license and readme file

Hi.
Fedora need to have access to the license and the readme file in the crate source.
A ``include = [ "README.markdown", "LICENSE-APACHE", "LICENSE-MIT"] should be sufficent for fedora.

So, these files are in the repo root, which is outside the directory of each package. I don't believe that include works for this.
Do you happen to know if symlinking them to the right place and then including that works when publishing?

Also, can you elaborate why you need the README? The license makes sense, but the readme is surprising.

https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation
Fedora want to package every bits of documentation concerning a package, Even the readme file.
You can look at: %license LICENSE-APACHE LICENSE-MIT %doc CHANGELOG.md CONTRIBUTING.md README.md src/doc
https://src.fedoraproject.org/rpms/rust-cargo/blob/rawhide/f/rust-cargo.spec
I am not sure for the symlink. @eclipseo should be able to answer that question.

It seems like maybe the include path is able to go outside of the package, even though this isn't documented.

Yeah, this should work: https://github.com/rust-lang/cargo/blob/cc75485f72a6aaf871d4368b4b8eb01046f3af28/tests/testsuite/package.rs#L1606-L1622

Thanks for your time. that should ease distro packaging.

Damn, I was mistaken. That test is testing the behavior of license-file = ... not include = [...] and I can confirm that include does not work when done locally. Ugh.


gifsicle: 1.93 -> 1.94

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/gifsicle/versions.
meta.description for gifsicle is: Command-line tool for creating, editing, and getting information about GIF images and animations
meta.homepage for gifsicle is: https://www.lcdf.org/gifsicle/
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.94 with grep in /nix/store/pj0i223w7fhpqkklhmkdjcshh3mhgw2i-gifsicle-1.94
found 1.94 in filename of file in /nix/store/pj0i223w7fhpqkklhmkdjcshh3mhgw2i-gifsicle-1.94

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
discourse
discourseAllPlugins
gifsicle
image_optim
mtpaint

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pj0i223w7fhpqkklhmkdjcshh3mhgw2i-gifsicle-1.94 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gifsicle https://github.com/r-ryantm/nixpkgs/archive/7ecd36fb2cb9069f7acadfb5079c8bcd5a9baab6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pj0i223w7fhpqkklhmkdjcshh3mhgw2i-gifsicle-1.94
ls -la /nix/store/pj0i223w7fhpqkklhmkdjcshh3mhgw2i-gifsicle-1.94/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

gifsicle
image_optim
mtpaint

Maintainer pings
cc @zimbatm for testing.

Marking as security related, this upgrade contains the fix for CVE-2023-36193 (https://github.com/kohler/gifsicle/issues/191)


[Cedar Doc Issue] Add link to sample application in the RBAC with groups guidance

Let's add a link to a blog and sample application that implements RBAC with groups https://docs.cedarpolicy.com/bestpractices/bp-implementing-roles-groups.html
Blog: https://aws.amazon.com/blogs/devops/manage-roles-and-entitlements-with-pbac-using-amazon-verified-permissions/
Sample App: https://github.com/aws-samples/avp-petstore-sample-v2/

Okay, will draft this up.

These links have been added.


Setting ip-address to Private causes an error

Setting below
    - name: 'Deploy'
      uses: azure/aci-deploy@v1
      with:
        resource-group: ${{ secrets.AZURE_RESOURCE_GROUP }}
        registry-login-server: ${{ secrets.AZURE_REGISTRY_LOGIN_SERVER }}
        registry-username: ${{ secrets.AZURE_REGISTRY_USERNAME }}
        registry-password: ${{ secrets.AZURE_REGISTRY_PASSWORD }}
        name: $DEPLOYMENT_NAME
        image: $IMAGE:$GITHUB_SHA
        location: 'south central us'
        os-type: Windows
        cpu: 4
        memory: 16
        environment-variables: DOTNET_ENVIRONMENT=Production
        restart-policy: OnFailure
        dns-name-label: $DEPLOYMENT_NAME
        ip-address: Private

throws the error below
Error: DNS name label for container group is only supported when IP Address type is public.

and removing dns-name-label throws the error below
Error: Input required and not supplied: dns-name-label

Hey @cilerler,
Thanks for pointing this out. As of now, this action only supports Public IP scenario. Updated : https://github.com/Azure/aci-deploy/blob/master/action.yml#L69
Supporting Private IP will be taken up as an enhancement.

Are you sure that you don't want to mark it as "Bug" since it allows you to set a value, but then it throws an error? I mean, it literally throws an error if you set Private; to me, it means a bug and not an enhancement.

Since we are calling out explicitly in the action ReadMe as well as action.yml that Private IP scenario is not supported, we'll be taking this as an enhancement.

I am also having this issue.  Is there some reason why Private IP addresses is not supported?  Any idea on the timeline on this?  Are y'all accepting PRs?

@zmckinnon We are accepting PRs. We will be glad to accept contributions.

Is there a reason for this restriction? In Azure Portal it's absolutely possible to create a container instance without a dns label name and a private IP address. I'm curious. :)

Tested it. There's no reason. Sent a PR. :)

any updates on this issue?


Use a code editor instead of text area.

https://github.com/securingsincity/react-ace looks like a good candidate.

Feel free to shoot a PR :)

Please assign this to me. I will start working on this once we close the discussion on #8 :)


Adds link to readme in homepage

Related with: https://github.com/MozillaFoundation/internet-health-report-2018-bugs/issues/32

I'm gonna make the change.


Notify social workers, coordinators, and admins of shift changes, with opt-out

Implements #189.
This PR includes the following:

The creation of a new join model, OfficeUser, which replaces the old habtm offices_users table. It has a boolean attribute, send_notifications.
A new multi-select is added to the Edit Profile page which allows users to choose which offices they want to receive shift notifications from.
When a shift is assigned or unassigned, notify social workers, coordinators, and admins via text message, so long as they have marked themselves as notifiable in this office. Unlike before, it will notify these users whether a shift is changed via a scheduler or the volunteer themselves.
The Rubocop config change found in #364
Rubocop updates to relevant spec files.

Note that by default, all users are opted-out (the boolean is set to false). We should consider a migration strategy here. We could either set it to true for everyone, or try to be consistent with current behavior (set all social workers to true).

I'm not really sure why CodeClimate is complaining about total coverage, I added a spec for OfficeUser and the Details there aren't clear.

Because this includes renaming a table, it will cause a brief downtime if deployed normally. We could either view that as acceptable, or create a new table and populate it from the contents of the old table.

Because this includes renaming a table, it will cause a brief downtime if deployed normally. We could either view that as acceptable, or create a new table and populate it from the contents of the old table.

I vote that we consider it acceptable as-is and roll it out all at once. Things will be screwy for a very brief amount of time.


first pass at working docker

remove commands that require input and create the db automatically, golly that's slow
do we need the super user command?
looks like it was missing enough to run celery?

Currently failing on elastic search
python manage.py reindex --wipe --force
Raven is not configured (logging is disabled). Please see the documentation for more information.
21:26:04 py.warnings:WARNING /opt/rh/python27/root/usr/lib/python2.7/site-packages/celery/task/sets.py:23: CDeprecationWarning:
    celery.task.sets and TaskSet is deprecated and scheduled for removal in
    version 4.0. Please use "group" instead (see the Canvas section in the userguide)

  """)
 :/opt/rh/python27/root/usr/lib/python2.7/site-packages/celery/utils/__init__.py:93
Starting the reindexation
Are you sure you want to wipe all AMO Elasticsearch indexes? (yes/no): Traceback (most recent call last):
  File "manage.py", line 13, in <module>
    execute_from_command_line(sys.argv)
  File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/django/core/management/__init__.py", line 399, in execute_from_command_line
    utility.execute()
  File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/django/core/management/__init__.py", line 392, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/django/core/management/base.py", line 242, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/django/core/management/base.py", line 285, in execute
    output = self.handle(*args, **options)
  File "/code/lib/es/management/commands/reindex.py", line 143, in handle
    confirm = raw_input('Are you sure you want to wipe all AMO '
EOFError
make[1]: *** [populate_data] Error 1

On requesting user input?

I have seen this without your patch:
@kmaglione's note to that:  "Looks like you're running it without a terminal."

Well I was running make initialize_docker from the terminal.

Ah so I guess, the thing that was confusing me is the initialize_docker command, I was kinda expecting after the build step to have a functioning AMO install, but it requires that before it works. I'll clean out and start again. It's documented that it requires initialize_docker, I just didn't find the docs till later.

After reading the docs, it does indeed work, sorry for the noise.

Ah so I guess, the thing that was confusing me is the initialize_docker command, I was kinda expecting after the build step to have a functioning AMO install, but it requires that before it works.

Yeah, I think you're right about that. I also tend to forget to run make initialize_docker when I create a new container, so it would definitely be good to have the container do it automatically on first run.
The only think I'm worried about, doing it this way, is that both the web server and the Celery workers use the same entrypoint script, so we need to make sure they don't both try to initialize the DB at the same time.

Are you going to submit an updated version of this? I pushed back my Docker PR yesterday to wait for this to land, but it might be easier if I roll some of these changes into that instead.


Support initial_state kwarg in HigherOrderComposite

Addresses the higher order composite as mentioned in #483 . Follows the pattern introduced in https://github.com/dwavesystems/dwave-system/pull/96. Creating a more general pattern is covered by #491.

Codecov Report

Merging #492 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
+ Coverage   93.36%   93.39%   +0.03%
==========================================
  Files          49       49
  Lines        3255     3270      +15
==========================================
+ Hits         3039     3054      +15
  Misses        216      216

Impacted Files
Coverage Δ

...imod/reference/composites/higherordercomposites.py
94.53% <100%> (+0.72%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c557198...ebbf9af. Read the comment docs.


prepare callback ignored in nested machines

Consider following example:
from transitions.extensions import HierarchicalMachine as Machine

class Model:
    def preparation(self):
        print "Preparing"

ms_model = Model()

ms = Machine(ms_model,states=["C","D"],
             transitions={"trigger":"go","source":"*",
                          "dest":"D","prepare":"preparation"},initial="C")
ms_model.go() # prints Preparing
m = Machine(ms_model,states=["A","B",{"name":"NEST","children":ms}])
ms_model.to_NEST_C()
ms_model.go() # doesn't print

It seems that the prepare callback is ignored when a machine is nested.

Another good minimal example, another good catch. Many thanks. 👍


Removed an unnecessary comma at line 62 of server.js

Not sure what purpose the comma was serving; for me, it was simply introducing compile errors.

As I mentioned in: https://github.com/fullstackreact/food-lookup-demo/issues/29

Thanks @reefloretto, my mistake - I hadn't pushed this commit which fixed this issue / ran the code through Prettier.
Sorry about the trouble!


Update package.json

This is a test, please don't merge

Summary

Ticket Link

Related Pull Requests

Has server changes (please link here)
Has mobile changes (please link here)

Screenshots

Release Note

Hello @security1test,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.


feat: caching improvements

Pull Request Type

[x] Feature addition
[ ] Bugfix
[ ] Documentation update
[ ] Code refactor
[ ] Tests improvement
[ ] CI/CD pipeline enhancement
[ ] Other: [Replace with a description]

Description

Allows users to force the cache fetch methods to pull from the api regardless of caching state.
Also allow the lib to infer if a user object has been fetched, and can be considered completely cached.
Changes

Add User._fetched flag
Add force kwarg to all relevant fetch methods in cache
Add a check in fetch_user to determine if a api request is required

Related Issues

Test Scenarios

Python Compatibility

[x] I've ensured my code works on Python 3.10.x
[ ] I've ensured my code works on Python 3.11.x

Checklist

[x] I've run the pre-commit code linter over all edited files
[x] I've tested my changes on supported Python versions
[ ] I've added tests for my code, if applicable
[ ] I've updated / added  documentation, where applicable

Codecov Report
Patch coverage: 45.45% and project coverage change: -0.02 :warning:

Comparison is base (cc6b2eb) 47.49% compared to head (a43d0eb) 47.47%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1350      +/-   ##
============================================
- Coverage     47.49%   47.47%   -0.02%
============================================
  Files           139      139
  Lines         14461    14466       +5
============================================
  Hits           6868     6868
- Misses         7593     7598       +5

Impacted Files
Coverage Δ

interactions/client/smart_cache.py
35.16% <38.88%> (-0.11%)
:arrow_down:

interactions/models/discord/user.py
53.50% <75.00%> (+0.32%)
:arrow_up:

... and 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Tested, working. ✅
Non-issue, but something that just caught my attention, was the fact that you used different phrases every so often for the force argument for docstrings.

Past me probably got bored. Either way I'm fine with that


update the pre-population data at any point

As a fisherman I would like to be able to update the pre-population data at any point https://github.com/StAResComp/sifids/issues/6

Must


Procedural mesh generation

https://pymesh.readthedocs.io/en/latest/api_procedural_mesh_generation.html

also, expand demos to include more nx graphs!

v22.11.0


Update README test badge

@danielrozenberg
Do you know if the previous merge created a new version of the jar? Otherwise, please update the pom.xml to 1.0.23 for this merge, from 1.0.22 to  1.0.23.

Do you know if the previous merge created a new version of the jar? Otherwise, please update the pom.xml to 1.0.23 for this merge, from 1.0.22 to 1.0.23.

The build failed due to credential issues, I messaged you on Slack so we can resolve this

Do you know if the previous merge created a new version of the jar? Otherwise, please update the pom.xml to 1.0.23 for this merge, from 1.0.22 to 1.0.23.

The build failed due to credential issues, I messaged you on Slack so we can resolve this

Do you know if the previous merge created a new version of the jar? Otherwise, please update the pom.xml to 1.0.23 for this merge, from 1.0.22 to 1.0.23.

The build failed due to credential issues, I messaged you on Slack so we can resolve this

@danielrozenberg I sent you in the slack.


cmake: kconfig: Minor command-line assignment improvements

Summary:

Preserve boolean (=n) assignments from command-line.
Discard invalid assignments from command-line.
Avoid writing a new .config when nothing changes.

Looking good, but before giving +1, I would like to take the opportunity to discuss if we should make the transition of # CONFIG_<var> is not set resulting in an undefined CMake variable, to instead be a defined variable with value n, as mentioned here #59915 (comment).

My take is that the most dangerous thing about this change is probably how it would affect things out of tree. That's where I see the most occurrences of this pattern: if([NOT] DEFINED CONFIG_...), which you already pointed out as problematic.

Having such change will also mean that we can differentiate between variables not set and those not even present in the .config, as setting not present will still be undefined.

Sounds interesting, but can you think of a good use case for this? I think in most cases, it's natural to simply infer that e.g., CONFIG_LOG_RUNTIME_FILTERING is undefined if it's guarded by CONFIG_LOG=n.

doing it as a prepare PR will allow us to run CI and check code and side-effect independent of other changes in this PR.

I'm not sure if CI will necessarily catch the more subtle side-effects, like unused code being compiled in.


Consolidated apps directories

Having two apps directories was confusing.  Merged them into one directory, at the top level.  The top level makes more sense semantically, so that one can choose between apps or notebooks to work with; apps don't need to have any relation to notebooks at all.  The only downside I can see is that notebook 13 had a link to edit a file from an app using Jupyter's internal editor, and I had to remove that link because it doesn't seem to allow editing files outside of the directory where Jupyter was launched.  If that can be worked around, please restore that line!  Or feel free to discard this PR and make a different one using notebooks/apps, if having that link seems very important.

Any idea what's up with the tests? Don't have permissions to see the output.

There isn't any output:

Why don't you have access to the anacondaviz tests?  You're an admin on the project.  Do you mean, access at appveyor?  I'm not even sure why only appveyor is in the list, and not Travis.  I don't think the tests are set up yet, maybe?

I guess I'll merge; this just seems untested rather than failing.

Tests were set up but I think they broke when I made the repo public.

Ah, could be!


Creating a folder from a contact for which there is no chat

I'm trying to create a folder and put there a contact with whom I don't have a chat. But tdlib says it's a mistake. What should I add to the CreateChatFolder request?

First, you need to create a chat with the user using createPrivateChat.

I tried to create a private chat for the user. It was created, then I put it in the included_chat_ids_ field. I make a createChatFolder request and get this message: Chat is not in the chat list.  As a result, the folder was not created(.

You must ensure that the chat in a chat list first. Private chats must be non-empty for this.

It turns out that it is impossible to create a folder for contacts that I have and for which there are no chats, as in ios?

If chat isn't in the main or archive chat lsit, then it is not supposed to be shown in other folders.

Yes, thank you, I understood that. When you create a folder for such a case in iOS, these contacts do not appear on the main folder. But when you go to the folder settings and open this folder, contacts for which there are no chats are displayed there. Is there any way to do this using stdlib?


Fix broken book publishing on Travis

The books were not published on https://docs.rust-embedded.org/ since March 16 2020. Last successful build here, first broken build here. Here you can see the long list of failures.
I took the changes from https://github.com/rust-embedded/discovery/blob/d42012eedb4216ae8b613c3fdfdb37f85f01656f/ci/install.sh .
For proof that the changes fix the issue see my fork in https://github.com/yerke/docs, which was successfully built with Travis in here. You can see built artifacts at https://github.com/yerke/yerke.github.io/tree/gh-pages and https://yerke.github.io .
Closes https://github.com/rust-embedded/docs/issues/8, https://github.com/rust-embedded/wg/issues/457, https://github.com/rust-embedded/discovery/issues/253

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

And of course after I spent the whole day chasing this, it turns out that this is the same as https://github.com/rust-embedded/docs/pull/21 :(

@yerke Not sure I follow. Does this PR fix the problem?

It does, yes, @therealprof. You can check https://travis-ci.com/github/yerke/docs/builds/174282136 for successful Travis build and https://yerke.github.io/ as example of built books, as I mentioned in the description.

Thank you, then let's go with this.

@therealprof Thank you for being so responsive.

Thank you for putting time into this. Much appreciated!


Vue warns incorrectly if component is surrounded by functional component

Version
3.0.5
Reproduction link
https://codesandbox.io/s/vue3-slot-invoked-outside-warning-demo-ezuud
Steps to reproduce
Please have a look at the minimal reproduction.
As soon as I create a component inside of a "functional component", it show's a warning.
What is expected?
It shouldn't warn.
What is actually happening?
[Vue warn]: Slot "default" invoked outside of the render function: this will not track dependencies used in the slot. Invoke the slot function inside the render function instead.

The warning is only shown if I create the watch in MyComponent.vue (or if I access isMandatoryOrSlotVisible.value directly.)
If I use the same code without the surrounding MyContainer component, it work's without any warning. Since there is no invokation of the slot function in the surrounding MyContainer component, the warning is misleading.

Is this really a bug? I do not think so. As long as you execute the slot functions in setup, you will get this warning, which has nothing to do with whether you use functional components to wrap it.
import { createApp, h, defineComponent } from 'vue'

const Comp = defineComponent({
  setup(props, { slots }) {
    // a warning raised, this is as expected
    const s = slots.default && slots.default()

    return () => s
  }
})

createApp({
  setup() {
    return () => h(Comp, () => 'sss')
  }
}).mount('#header')

@HcySunYang But then I should get the warning too when I execute the MyComponent directly in App.vue (instead of MyContainer), right? But then there is no warning. so something seems to be wrong there...
A little bit of context of the bigger picture what I try to accomblish: I want to tell the parent component if any of the child components are considered "empty" (based on their data AND slot content). In vue2 those slots where just empty when no element was rendered (with functional components), but since vue3 I can't tell if the component has a v-if="false" on the root element. I just see the an array with the components or in some cases an entry of type "Symbol(Comment)" ($el is not accessible).
So I guess I have to use provide and inject. But those need to be performed in setup (and not in render). So there seems to be no other way to invoke the slot function in setup, to determine if there is something to show.

Ok, I made a PR to make the warning consistent when calling the slot function outside the render function.
However, more and more users request similar capabilities. They hope to call the slot function in the setup function to determine whether the slot content exists or meets expectations. Maybe we don’t need to report that warning message, but instead, emphasize it in the document.


Structure config file

Description:
In the current implementation of the configuration file, the structure is following:
section.property.module.position = value
where the section and the property are mandatory and the rest is optional.

section -- defines the section of property.
property -- defines the property we set.
module -- an optional value indicating the software module (process) we refer, if missed, property refers to all modules.
position -- the field in the property we are interested. For example, a connection may have 2 fields: address and port number.

Since the module is optional value, if it does not exist, the position is understood as the module, which may often confuse.
Agenda:
To avoid future confusion, this should be changed in the following way:
section.property[module].position, so that

each entry has section and property.
If no [] is present, the property does not have a module and it refers to all processes (global setting)
If there is a field after [], it is a position in the property

The missing module, or empty module [] or all modules [*] should have same meaning -- global property for all processes. The target module, i.e. module with a name, always replaces the global module. For example, if there is a property:
router.tcp.address = localhost
router.tcp.port = 8282

which is global and refers to all processes and there is a property like
router.tcp[myapp].address = 123.456.789.012
router.tcp[myapp].address = 5656

then the router.tcp property of myapp module cannot be overwritten.

Fixed in PR #262


[BUG] Changing Year of existing note does not work

Describe the bug
Changing the year of the date editor for an existing note does not apply the changes.
To Reproduce
Steps to reproduce the behavior:

Create a new Calendar note
Edit the Note
Click on the Date of the Note
Change the Date using the Textbox depicting the year
Click anywhere else

Expected behavior
Either the year should be applied when the Dropdown closes or the month should update on change, so that you can select the desired day of said month

Foundry Information

Foundry Version: 11 Build 315
Game System: dnd53 2.4.0
Simple Calendar Version: 2.4.3
Simple Calendar Configuration: simple-calendar-export.json

Browser:

Chrome

This has been fixed in version 2.4.8!


Mac: Double clicking the title bar doesn't maximize the window anymore

VSCode Version: 1.8.0-insider 2016-11-08T07:53:03.250Z
OS Version: Mac Sierra

Since today's insider build the window cannot be maximized anymore by double clicking the window's title bar.
Steps to Reproduce:

Open vscode insider build
double click the title bar

@bpasero Wow, that was quick! Already fixed in the latest insider build that was published just now. You're awesome 👍

@bpasero The opposite doesn't yet. When a window is maximized it won't scale down to it's previous size. Should this issue be reopened or should I make a new one?

@marvinhagemeister does it work for you (new insiders are out already)? I noticed that I can get into a situation where the window no longer unmaximizes. But I also have some tools installed that hook into the window management and that might be related.

@bpasero It's already out. I noticed the same with spectacle (also hooks into the window management). Whenever I use a hotkey set by spectacle to maximize the window I can't unmaximize it anymore, same as you.
Perhaps vscode/electron isn't aware that the window is in an already maximized state and tries to maximize it again which won't have a visible effect at this point?

@marvinhagemeister I notice that I first need to resize the window to a smaller state before the double click turns the window from maximized into unmaximized mode. Not sure if that is something I do wrong in the window creation or general Mac behaviour...

Actually no, I see the same behaviour with the native window title 👍

@bpasero mh, I can reproduce this easily with spectacle:

Open vscode unmaximized
Maximize with spectacle (⌥⌘F)
Double-Click the title bar doesn't work anymore

This works fine with Finder. Not sure if this is an issue specific to spectacle though.

@marvinhagemeister you can see if this is caused by the custom title by setting
"window.titleBarStyle": "native"
And restarting and try again on the native title.

@bpasero you're right. With "window.titleBarStyle": "native" it doesn't work either.

I use BetterSnapTool with this settings:

"window.titleBarStyle": "native" / old version works for double click (maximize / unmaximize)
without 'native' - i can only double click to maximize. No unmaximizing

Yes, I would assume that external tools that hook into the native title bar are not supported in our custom title bar.

Same problem - no external tools installed. My system setting is for double click to 'zoom'


Create initial project structure (Backend)

Partly resolves the #1 issue

It would be good to introduce CHANGELOG.md in the initial commit and add a new line to it on every pull request. We also have GitHub workflow, that checks that changelog was updated (https://github.com/qoollo/bob/blob/master/.github/workflows/changelog-updated.yml). It would be good to use it here too


Add test to make sure Person's current name is same as most recent candidate_name

Assuming the name from the CAL-ACCESS website is better than the name on any of the Form501Filings linked to the Person.

Done


Fix scoping of context for mutations

In #1385 we introduced the ScopedContext interface. When implemented on the Context, it would clone the context down to it's children.
This works great for queries. But mutations are executed serially. I forgot to call maybeScopeContext there.
This fixes the problem, and adds a test to guard it.it would clone the context down to it's children.

@spawnia This one is ready for review, when you have time.

@spawnia You are probably busy. Do you have time for a review? Or is there anybody else that can do it?

Thanks, released with https://github.com/webonyx/graphql-php/releases/tag/v15.11.2.


Bug in animation speed

We have seen that in this example /debug/animation/multi-anim.html the animation interval is broken. This bug has appeared in 591530b47877b3f2df5ca9438427c600428724cf, so we need to add also a test to cover this case.

Fixed in https://github.com/CartoDB/carto-vl/pull/1367


dapp kube lint ignores global.env value

dapp kube lint --set global.env=production not working as expected.
It seems problem is here:
https://github.com/flant/dapp/blob/master/lib/dapp/kube/dapp/command/lint.rb#L61-L67
global key has only namespace string and dapp structure. If there was values with global key they are just lost.

Quick hack makes lint works:
              all_values['global'] = {
                'namespace' => kube_namespace,
                'dapp' => {
                  'repo' => repo,
                  'docker_tag' => docker_tag
-                }
+                },
+                'env' => 'production'
              }