FaroRoute (v5) is breaking all tests

Description
FaroRoute is breaking tests.
Steps to reproduce

Go to my sandbox
Hit the 'Test' tab on the right sidebar to run all tests
Observe the test failing

Expected behavior
The test should pass without breaking, when replacing Route with FaroRoute
Actual behavior
All tests with routing break.
This is what is displayed from the console when running tests which involve FaroRoute:
Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

Check the render method of `FaroRoute`.

Environment

SDK version: 1.0.0
SDK instrumentations:  React
Device type: desktop
Device name: MacBook Air M1 13"
**OS:**MacOS
**Browser:**Chrome

Demo
This can be reproduced here
Please note that on the project's package.json the specific versions of libs are the ones that I actually use on my project.

Hi @alioshr and thank you for trying out Faro.
In the example I can not find where Faro is initialized.
Did you maybe forgot to add it?
faro-react - installation
Cheers,
Marco

Hi @codecapitano. Thanks so much for replying back.
I did not initialize it on this Demo as I just wanted to reproduce an error on an unit test. Even if I initialize faro, the unit test will fail in the same way. At least this is the scenario on my real project.
Is there any additional step on tests setup, or on the unit tests, to make FaroRoute work on tests environment? Am I missing anything? I could not find nothing related to testing on the docs.
Thanks in advance for your help!

Hey @alioshr I can reproduce the issue.
It happens when FaroReact is not initialized.
Anyways, I will dive a bit deeper an see what's going on.

Even if I initialize faro, the unit test will fail in the same way. At least this is the scenario on my real project.

Would you mind to add an example how you configured it?
Thanks, Marco

Hi Marco. Thanks for replying back to me.
The initialization configuration of faro production code will have no influence over the unit tests unless something is needed to be done on test configuration setup / test file setup before running asserts.
Should we mock some faro internal code? I did not find documentation about this so far. My concern is that mocking things related to the Route itself could limit our testing capabilities.

Hi @alioshr
The Faro setup looks correct.
Regrading the testing issue:
This is a bug and we've evaluated the place in code where it happens and will fix it.
Regarding the other issue we also are not able to get route changes metrics.:
Would you open another issue for this? 🙏
Thanks you so much for reporting the issue(s).
Cheers,
Marco

Hi @codecapitano ! Thanks for replying back to me and sorry for my late reply back to you.
Thanks for updating us regarding the potential bug on the tests environment. I will open a ticket for the production part of the integration =)
Do you think that the production issue could be related to the bug you have identified on the tests environment?

Thank you @alioshr 🙏
At the moment I can't say yet if the prod issue is related to the bug.
I'll let you know as soon as I know more.
Cheers,
Marco

Hi @alioshr
I had a look into the bug you have in production.

While FaroRoute does not break the app on production code, we also are not able to get route changes metrics.

From the provided example I see you are using ReactRouter.V5 and assign a reference to the useHistory hook to the history property  in the router dependencies.
This will currently not work because we internally subscribe to history.listen and push route changes when the listener fires (it happens a bit more but this is roughly how it works).
The problem is that it is not possible to call React hooks outside React Components.|
At the moment you need to create and pass the history object to the Faro React instrumentation.
Note: For this to work you need to use the <Router /> component instead of <BrowserRouter />!
Example (stripped out things not related to the issue)
const history = createBrowserHistory();

initializeFaro({
  //... other options
  instrumentations: [
    //... other options
    new ReactIntegration({
      router: {
        version: ReactRouterVersion.V5,
        dependencies: {
          history: history,
          Route: Route,
        },
      },
    }),
  ],
});

//... other react init options

root.render(
    <Router history={history}>
      <App />
    </Router>
);

Cheers,
Marco

@codecapitano  thanks for the explanation!
I have managed to enable route changes metrics now. On the tests I still see everything breaking. My workaround was to have a dev fallback of using normal Routes (due to the fact the FaroRoute only works if faro is initialized), as we don't want to collect metrics in dev and our MicroFrontends use an external webapack version of @grafana/faro-react, so there is no initialization of faro in them, and mocking FaroRoute on tests.
So I have ended up adding up a layer of abstraction so I would have this mock only in one place and with the mentioned fallback in dev.
My suggestions would be:
Make FaroRoute fallback to a regularRoute with no api.push.... if no instance of faro is detected, as it would be good for dev experience and for using FaroRoute in test environment (we do not want to test faro, or stuff like this, but still want to assert on our route changes as usual)


Wallpapers and stickers are not displayed after downloading it

I Use Ubuntu 20.04.4 LTS x86_64 in a Docker Container and Every time I want to download stickers or Wallpapers nothing happened, I cleared the Cache and use the sudo commands, and reinstall so many times and even there nothing happened
https://user-images.githubusercontent.com/79216939/169813468-3b71061f-ab59-4952-ad6f-f48945c0e353.mp4

in a Docker Container

Are you running Visual Studio Code in a container?
I saw this:

Are you connected to something remote? If so could you disconnect, try to install. Might be related to this https://github.com/doki-theme/doki-theme-vscode/issues/32#issuecomment-727662939 (however that might be something .net related, I dunno, just trying to guess why the installation failure stuff isn't working)
If you are feeling extra explorative. You can use the Show Logs in the command palette or Help -> Toggle Developer tools, to investigate the issue more. Thanks!
https://user-images.githubusercontent.com/15972415/169917950-8a842e0d-1d9d-43fa-bfc8-5e6ea5326e91.mp4

The remote connection is from the remote server that runs the docker Container

and the logs show me only this messages

Ah so it looks like you are running VS Code from a Code Server. Your current VS Code is acting like a thin client (ui). The guts of the VS Code is running in the background. (Related comment https://github.com/doki-theme/doki-theme-vscode/issues/131#issuecomment-1048318341)
I've got code that should install things on a code-server, but it appears like it isn't working as expected. Let's try something.
Could you disconnect your VS Code, then try to install the assets?
You should be able to click this and choose disconnect from the command palette.

Nope, Nothing happened, and I don't have access to the server, only to the Container

Bummer, well could you attempt to install the asset(s) then could you please provide all the logs? Asset installation not working, and I don't know enough about your environment to reproduce the issue.

I only see the stickers on the Help asset tab and I only see this logs, and it doesn't change when I install an asset

and on my phone i see all from the doki theme

Now i see all and when i want to remove backround and sticker both remains

Ah, I think I understand your set up more.
You have a remote server that is running the code server.
You access your VS Code through the browser.
So, I think most of your issues (with it not showing up) might be stemming from the browser caching CSS (Since it shows up on your phone). Try clearing your caches for that site and reload.

Yes, thanks, the problem is fixed


Enable NPM dependency auto-update via Dependabot

We currently manually update NPM dependencies listed in package.json. This PR switches to daily check + auto-update of NPM dependencies courtesy of Dependabot. See here for more information.
I confirm I have signed the Contributor License Agreement.

Will it be able to combine updates of different dependencies into single PR, and perhaps not every day, but could be done before releases?

Will it be able to combine updates of different dependencies into single PR, and perhaps not every day, but could be done before releases?

When I enabled this, we were already out of date with several dependencies. And I've made some other related PRs to get this all working. I suspect the noise will seems a lot lower from now on. Let's see how it pans out.
I researched combining PRs. It seems this is a good article to read:
https://www.hrvey.com/blog/combine-dependabot-prs

When I enabled this, we were already out of date with several dependencies. And I've made some other related PRs to get this all working. I suspect the noise will seems a lot lower from now on. Let's see how it pans out.
I researched combining PRs. It seems this is a good article to read:
https://www.hrvey.com/blog/combine-dependabot-prs


Add a development section to the README

Thank you! Sure, I'll look into it, I didn't know that a maturin executable existed until I read the GitHub action workflow file.

@gi0baro I have updated the pull request and am now recommending using make (since you've added a nice Makefile in the meantime.

@matthiask thank you for the update. Can you clarify on the patchelf usage/recommendation?

I got warnings when it wasn't installed. It seems it's required to build manylinux wheels. I'm a bit confused if it's necessary for development or only for releases, but I sometimes try erring on the side of installing more optional dependencies when warned about them. What do you think?


Implement authentication

This shouldn't be public by default.

It looks like the /status endpoint is key for implementing authentication: https://tiddlywiki.com/#WebServer API%3A Get Server Status

The JSON data returned comprises the following properties:

username - the username of the currently authenticated user. If undefined, the WebServer Parameter: anon-username is returned instead
anonymous - true if the current user is anonymous
read_only - true if the current user is restricted to read only access to the server
space - always contains the object {recipe: "default"}
tiddlywiki_version - the current TiddlyWiki version

I could have an option for making the wiki read-only public to unauthenticated users - in which case I would return the read_only option here - and teach the PUT and DELETE endpoints to return errors.

Datasette Desktop signs the user in as root - https://github.com/simonw/datasette-app-support/blob/49078df0b6a038f8e0fe1bad5dfd42da4a6caff7/datasette_app_support/init.py#L273-L275
So I'm going to default to requiring root here.

So only one new permission:

read-tiddlywiki

Plus code that does a permission check for view-database against the tiddlywiki database.
And view-instance too.

Documentation: https://github.com/simonw/datasette-tiddlywiki/blob/84c06dcffcf63829c4097fb2ea36aaccbf9d222e/README.md#authentication-and-permissions


Trash Talk

[ ] Return Text to DOM
[ ] Return Audio to user
[ ] Libraries for .in_check() and .in_checkmate()


Doxygen documentation target to cmake

cmake variables:
PISTACHE_BUILD_DOCS=yes
package requirements:
doxygen
dot
to build:
make docs

Codecov Report

Merging #467 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
- Coverage   67.62%   67.49%   -0.14%
==========================================
  Files          49       49
  Lines        6827     6827
==========================================
- Hits         4617     4608       -9
- Misses       2210     2219       +9

Impacted Files
Coverage Δ

src/client/client.cc
80.16% <0%> (-1.62%)
:arrow_down:

src/common/reactor.cc
80.08% <0%> (-0.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e82fe5...97e24e8. Read the comment docs.


add puppet header to files

hello,
I would like to propose this simple change, just add a puppet header to file managed by the module.
this an be helpfull.

Merged, thanks!


clang::Cursor::specialized should return an Optionclang::Cursor

Right now, clang::Cursor::specialized returns a clang::Cursor regardless if that resulting cursor is_valid() or not. This is a footgun for callers, which have to remember to check resulting_cursor.is_valid(). Instead, specialized should check for them and return None if it is not a valid cursor, and Some if it is.
I can mentor someone who would like to pick up this bug.

Please make a comment here if you intend to work on this issue. Thank you!

This looks fun and I will give it a shot today!

Great! Don't hesitate to reach out if you run into any roadblocks :)

This might be a silly question, but why is it possible for a cursor to be invalid? Shouldn't the presence of a Cursor mean that it is valid and that you can use it? Shouldn't invalid cursors themselves be represented using None or something? I guess that's a larger issue than just changing this one method though..

Agreed! But we're using FFI to Clang and we don't get to decide how Clang represents its data structures :)
We do want to make it so that our wrapper Cursor type never contains a null or invalid Clang cursor, but this is a bit more work (or at least requires some more investigation and experimentation). See #119.
Fixing issues like this one will certainly help us get there, though!


Skip Pinned Tabs

Can you please add a feature to skip pinned tabs?
I don't want those to end up in the groups.

@nvdl accepted

Done in 0.0.5 version


Builder doctests

There are a few tests that I have left as "compile_fail" because I don't fully understand how contexts and signals are expected to work in 0.8. Search for FIXME in the diff, to find them. Any guidance that can be provided on these points would be greatly appreciated.

Hello there. Sorry for taking so long to get to this.
With the new v2 reactive primitives, the old builder API didn't really play well with it, mainly because I kind of just changed the function signatures to make it compile without any attention to ergonomics.
I actually completely overhauled the builder API in #373 which makes the old builder API obsolete, so unfortunately, I'll be closing this PR now. Sorry again for all the work you put into this.
Thanks for understanding.


Data preservation

Welcome, Dear Reviewer,

In this PR, our hardworking group created the data preservation methods, as per the instructions:
OOP school library: preserve data,

On exit, all our entered data is saved in the json files
On load, all our previously entered data is accessible
All our methods are in separate modules
All our modules/classes are responsible for only one functionality

P.S.: We got a new teammate on Tuesday, but we cannot reach him, I tried all the official channels, we do not have more time (we are already behind schedule), and he did not make a commit, but we cannot waste time waiting for him. I apologize for this, but please don't hold back our project because of that. Thanks!

Hi @Team
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not have commits from all partners, please make sure that all partners have balanced commits, this is a team of three, and I can only see   commits from two partners
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hi @MattGomb and @jfoyarzo,
While you made a great effort in this project, I cannot proceed to review your code.
Invalid Code Review Request
There are 3 members in this group but only 2 committed to this project. Kindly ensure the other member contributes to the project.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hello @prolajumokeoni and @DammyShittu , thank you for your feedback. I understand the reason of the invalid status but, as stated by Matt on the PR, we couldn't get a hold of our partner for him to contribute to the project... what are we supposed to do in this case? If our partner Is unresponsive, it will be impossible for him to make commits on this and the upcoming projects. Thanks in advance for your response 😃

@prolajumokeoni , @DammyShittu  Hey guys,  I wrote to student success, or I made a complaint, i am not sure if I did the right thing, because I never had to do it before, but it is in the works.... Meanwhile we will try to work on the next project

@thecodechaser Thanks!


How to set page programmatically?

How can I switch to a specific page programmatically when pagination is used?
The 'pageFirst()' is not public.
However, when

I load data into the table
the user navigates forward/backward
and I load new data

The table shows the current page, which might not exist because the new data is shorter.
'WithRows' doesn't reset the tables state, and there is no function to reset the tables' state.

Hello, I've implemented a fix for the problem as described above by automatically bounding the page to a valid number when WithRows is used.  I think programmatically setting the page number will also be useful, let me think a bit about if there's any potential gotchas.

Check v0.8.5 release for the above fix

I've added various pagination controls as well in v0.9.0.  If these changes are enough, please feel free to close the issue, or if there's something missing or working incorrectly please let me know!

Hey there, just checking if this solved the issue?  If there's no response within a few days I'll close this just for tidiness, but if you come back and think it's not closed you're welcome to reopen it.


cli: atom command not found, occasionally

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

I did not put an X, as I was unable to reproduce the problem in Safe Mode. How would I do that for this problem? I did check all of the other FAQs, and issues.
Description
Occasionally, I get an atom: command not found in Bash when I open a new tab or window in iTerm. This only happens for atom, as far as I can tell, and for no other programs. Running
   rm /usr/local/bin/atom
   ln -s /Applications/Atom.app/Contents/Resources/app/atom.sh /usr/local/bin/atom

Always fixes the issue. I am unable to figure out when this happens, or why, as my path or environment does not change in between sessions, at all.
Steps to Reproduce

Open your terminal.
Type atom.
Sometimes - but not at all times - it may fail appropriately.

Expected behavior: atom should always be found in my PATH.
Actual behavior: It isn't.
Reproduces how often: 5%~
Versions
Atom    : 1.19.2
Electron: 1.6.9
Chrome  : 56.0.2924.87
Node    : 7.4.0
OS: OS X 10.12 Sierra
Additional Information
I'm not sure how to diagnose this, at all. Any suggestions for more information would be great. Here are my dotfiles.

When you get this error, does /usr/local/bin/atom exist? If so, what is the output of readlink /usr/local/bin/atom?

It does exist.
13:46 ~ 🐕  ls /usr/local/bin/ | grep atom
atom
13:47 ~ 🐕  which atom
13:47 ~ 🐕  readlink /usr/local/bin/atom
/Users/richard/Library/Caches/com.github.atom.ShipIt/update.2kshvFo/Atom.app/Contents/Resources/app/atom.sh

Hail mary: maybe run hash -r?
From: https://unix.stackexchange.com/a/47370

Got this:
19:43 ~/src/nomad-as-fuck (gh-pages) 🐕  atom .
-bash: /usr/local/bin/atom: No such file or directory
19:43 ~/src/nomad-as-fuck (gh-pages) 🐕  hash -r
19:43 ~/src/nomad-as-fuck (gh-pages) 🐕  atom .
-bash: atom: command not found
19:43 ~/src/nomad-as-fuck (gh-pages) 🐕  atom
-bash: atom: command not found
19:44 ~/src/nomad-as-fuck (gh-pages) 🐕  which atom
19:44 ~/src/nomad-as-fuck (gh-pages) 🐕

I also see this ocassionally, I think it has something to do with the updater getting confused. For example, right now my atom is 1.19.2, when I click "Check for update" it says there are no updates, but as far as I can tell, the latest version of atom is 1.19.5.

I am using windows, on my case it pointing to the older version directory. I spawn it with git bash, but using cmd also fail:
$ atom .
/c/Users/enter/AppData/Local/atom/bin/atom: line 2: /c/Users/enter/AppData/Local
/atom/bin/../app-1.18.0/resources/cli/atom.sh: No such file or directory

lastest version installed on my machine is app-1.20.1

I am seeing this issue as well. For me the key seems to be that if the editor isn't running, the command isn't available in my shell. Once I start up an instance of atom the command becomes available again.

I tried this and it worked for me:
https://github.com/dwyl/start-here/issues/19

This might be conflating a bunch of "intermittents", but I too get this. My steps to reproduce:

Restart computer
Open a new terminal window
Atom is not yet running
type atom, which atom, etc. Nonexistant.

After I manually open Atom the terminal commands work fine.

I was unable to reproduce @robwierzbowski's issue by a restart.

Thanks for trying to repro. I'm finding this somewhat intermittent myself.

I have a brand new install and can consistently reproduce this issue every time. When atom is open the cli works fine but if atom is closed I get a No such file or directory error. After updates/reboots I have to reinstall the cli tools. Based on that I did some digging and I'm pretty sure it is Gatekeeper's app path randomization kicking in and so the actual path to atom.sh keeps changing. Opening Atom seems to restore the app translocation service path to where it was last (assuming you didn't reboot) allowing the cli to work.
If the path to atom looks like this then it's being randomized:
$ readlink /usr/local/bin/atom
/private/var/folders/3j/6kb0lxxx0_bgcrmlnsfcm0l40000gn/T/AppTranslocation/7AF75E9B-C77F-495D-9380-11C509FC06F1/d/Atom.app/Contents/Resources/app/atom.sh

I found this article that seems to indicate that the issue is how the app is distributed and a change in how Gatekeeper applies path randomization: http://krypted.com/mac-security/app-translocation-services-os-x-10-12/
You can remove the Gatekeeper quarantine on Atom by running
xattr -r -d com.apple.quarantine /Applications/Atom.app and then reinstalling the cli tools which will change the path back to the real path:
$ readlink /usr/local/bin/atom
/Applications/Atom.app/Contents/Resources/app/atom.sh

I will try this next time I see this bug; for now, here is my result for this command:
$  readlink /usr/local/bin/atom
/Applications/Atom.app/Contents/Resources/app/atom.sh

I had this exact same problem, and I was able to reproduce the error.
For me personally, none of the solutions mentioned above worked, however I was trying to run the command while the application was not running. After rebooting atom from the GUI and then trying the command again, it worked!

Had this issue happen today. Realized that yesterday I accidentally opened a file with an old version of Atom. I think that broke the symlink. Not sure why or how I have two versions installed. Hopefully this info helps someone.

I am seeing this issue as well. For me the key seems to be that if the editor isn't running, the command isn't available in my shell. Once I start up an instance of atom the command becomes available again.

This solution worked for me:

ln -s /Applications/Atom.app/Contents/Resources/app/atom.sh /usr/local/bin/atom
If you get "FIle exists" then rm -rf /usr/local/bin/atom
repeat step 1

from: https://stackoverflow.com/questions/22390709/how-to-open-atom-editor-from-command-line-in-os-x

I haven't had this issue in a long while.

I had an same issue.
ln -s /Applications/Atom.app/Contents/Resources/app/atom.sh /usr/local/bin/atom
This commands works well for me.

I was having the same issue on a new mac, granted it downloaded everything from the cloud on to my new machine. Attempted the solutions above trying to remove the Gatekeeper quarantine on Atom but would not work. atom command kept the same randomization path.
After removing atom and reinstalling using the homebrew formulae it fixed my problem.
brew cask install atom
installed shell commands from atom application and both apm and atom commands were changed back to a real path instead of the randomization from Gatekeeper and worked without having an instance of atom first even after rebooting a few times to make sure it was fixed. Hope this helps for some out there.

After one year of this problem found my solution:
Niche problem, niche solution: Make sure there is not a copy of Atom in your downloads folder.
This blocks a few different bits of functionality, and opening from the command line is one of them.

After one year of this problem found my solution: Niche problem, niche solution: Make sure there is not a copy of Atom in your downloads folder. This blocks a few different bits of functionality, and opening from the command line is one of them.

I can confirm that this was my problem. Atom was still being referred to from the downloads folder (using OSX) not the applications folder. Moving the folder permanently fixed the problem so that I no longer needed to install atom shell commands to fix the issue temporarily.


GH-33954: [C++][Parquet] Preserve field-id for nested type

Rationale for this change
Function below converts arrow schema to parquet schema and preserves field-id for primitive types but loses that information for nested types.
Status FieldToNode(const std::string& name, const std::shared_ptr<Field>& field,
                   const WriterProperties& properties,
                   const ArrowWriterProperties& arrow_properties, NodePtr* out);

In the Apache Iceberg, field-ids are assigned to all column types. We need to keep field-id of all columns.
What changes are included in this PR?
Fix FieldToNode to preserve field-id of STRUCT/MAP/LIST types.
Are these changes tested?
Added a test case in the cpp/src/parquet/arrow/arrow_schema_test.cc.
Are there any user-facing changes?
No.

Closes: #33954

@pitrou @wjones127 Could you please take a look? Thanks!

This looks good to me. @jorisvandenbossche Do you remember if there were any problems with Parquet field ids?

I remember that we had previous PRs where we wondered what to do with it. Your comment at this PR summarizes how we currently handle it (https://github.com/apache/arrow/pull/10289#issuecomment-839634828):

Based on my understanding, it seems that we should:

when reading from Parquet, reflect Parquet field_ids (if any) under the PARQUET:field_id metadata key
when writing to Parquet, generate Parquet field_ids from the PARQUET:field_id metadata key (if present)
not attempt to auto-generate any field_ids if they are not present in metadata

So correctly preserving the field-ids for nested types seems to follow that.
@wgtmac the current test does a full roundtrip of the arrow<->parquet schemas, so I assume this indirectly also covers that we correctly write them to Parquet if the information is present in the field metadata of an Arrow schema?

This looks good to me. @jorisvandenbossche Do you remember if there were any problems with Parquet field ids?

I remember that we had previous PRs where we wondered what to do with it. Your comment at this PR summarizes how we currently handle it (#10289 (comment)):

Based on my understanding, it seems that we should:

when reading from Parquet, reflect Parquet field_ids (if any) under the PARQUET:field_id metadata key
when writing to Parquet, generate Parquet field_ids from the PARQUET:field_id metadata key (if present)
not attempt to auto-generate any field_ids if they are not present in metadata

So correctly preserving the field-ids for nested types seems to follow that.
@wgtmac the current test does a full roundtrip of the arrow<->parquet schemas, so I assume this indirectly also covers that we correctly write them to Parquet if the information is present in the field metadata of an Arrow schema?

Yes, the current fix preserves all field-ids that exist in the PARQUET:field_id metadata key for all data types. This is required if we intend to write a parquet file which contains nested types to follow what the Apache Iceberg expects. @jorisvandenbossche


[1.18.2] Collector's Album "Persist album through death option" is incompatible with Forgotten Graves

Forgotten Graves doesn't spawn a grave if this option from Collector's Album is checked. Looks like it just causes Forgotten Graves to break and not work at all if Collector's Album forces an album to persist through death, even if you don't have an album in your inventory. The mod developer said there was nothing he could do about that on his side.

Howdy! I'm currently working on updating the project to 1.19 but once I'm done with that I'll look into this and see if I can't fix the issue. If you'd like to help me get a head-start into looking into the issue, any logs associated with the issue would be appreciated.
Happy holidays! :)

Didn't see anything that specific, but here's my log of me going into the world, having stuff in my inventory / on me and then dying. gravestone did not spawn!
Log

I'm going to close this for now as Toma and I discussed this here. For now, I've added instructions on making the two addons compatible on the CurseForge page.
Thanks for bringing this to our attention! 😄


GH1853: Adds using static directive support

fixes #1853
updates Microsoft.CodeAnalysis.CSharp.Scripting to 2.3.2

@devlead your changes have been merged, thanks for your contribution 👍


[9.x] Adds assertJsonIsArray and assertJsonIsObject for TestResponse

Hi team,
When interacting with Collection, after several actions (like sort or filter,...), the array won't be an indexed array like before (I think most of us here would probably encounter this at least once).
And if we return the Collection immediately, it will result in a JS Object { ... }. For listing endpoints, it would be wrong and result in an error from the API consumers (frontend, mobile,...)
So to ensure we won't return the wrong data structure to the consumers, I added 2 assert methods to validate the data:

assertJsonIsArray
assertJsonIsObject

FYA: from 10.x we can use array_is_list (PHP 8.1) to check against the data since it requires PHP 8.2 and above.
Usage
$this->json('GET', 'countries')
    ->assertOk()
    ->assertJsonIsArray(); // [ {..}, {...}, ....]

$this->json('GET', 'users')
    ->assertOk()
    ->assertJsonIsArray('data'); // {'data': [...]}

$this->json('GET', 'countries/US')
    ->assertOk()
    ->assertJsonIsObject(); // {id: '...', name: '..'}

$this->json('GET', 'users/1')
    ->assertOk()
    ->assertJsonIsObject('data'); // {'data': {id: '..', name: '...'}}

PR Information

Implemented the methods
Added tests and cover all cases
No breaking changes - only introduces new methods

Additional information
assertJsonStructure won't help us to validate that (check TestResponseTest@testAssertJsonStructure)
The wildcard * only validates the repeating structure. It doesn't care whether our data is a JS array or JS object.

assertJson or assertExactJson might be a good alternative, but for listing endpoints, preparing a big list of data to assert would not so fun, right?
Thanks all!

I don't think this would handle empty objects / arrays well. It would just assume they are all arrays.
If the payload was...
{ "users": {} }

When you json encode that in PHP it is going to have to cast it to an object or an array based on flags.vvfg

@timacdonald Not sure if I understand you correctly.
So for Laravel Response, by default, if you pass an empty array response()->json([]) or new JsonResponse([]) => [] will be rendered => assertJsonIsArray is working correctly?
But for some cases, you wanted the users to be an object, then in your controller, you would do something like response()->json(new YourObject()); (if the object is empty => {} => assertJsonIsObject is working correctly?

@sethsandaru I was concerned about how an empty hash in PHP is JSON encoded as an empty array, but I don't think that impacts this feature, and if anything this feature actually forces users to consider that.
Sorry for my rushed comment without further testing.


Add trait for chainspec parsing

we have
https://github.com/paradigmxyz/reth/blob/068bf57c06de0764b214e2f10c99e125825947c7/bin/reth/src/commands/p2p/mod.rs#L37-L40
which conflicts with eth and ethereum
https://github.com/paradigmxyz/reth/blob/068bf57c06de0764b214e2f10c99e125825947c7/crates/node/core/src/args/utils.rs#L23-L28
this should be abstracted via a helper trait that
a) defines the default supported traits as const
b) defines a valueparser for the chainspec type
something like:
trait ChainSpecParser: TypedValueParser< Value = ChainSpec> + Default  {
   const SUPPORTED_CHAINS : ...
}

should be defined in crates/cli/cli crate

Can I?


fix: blurred font

close #411
Eliminate the side effects of element transformations by calculating the offset of the element.
https://github.com/nuxt/devtools/assets/64941905/316e24b8-fa84-4b41-b1bf-156e4e790fa0

Nice, thanks!


"Lookup Symbol" goes to the correct line, but does not switch opened file

Godot version
4.0.dev (8c5e58ed74b9570059d23868eea97f8d8fad1727)
System information
Windows 10
Issue description
If the target of "Lookup Symbol" is in a .gd file, the editor should open that file and go to the symbol declaration.
Instead, when the symbol is found in some other file, the cursor moves to the line where the symbol is, but in the currently opened file.
This is true when the target has an opened tab (the editor does not switch tabs) or when it does not (the editor does not open any new tabs).
Seems to be applicable only to 4.0, as in 3.4.stable the Lookup Symbol does not appear to move the cursor at all.
https://user-images.githubusercontent.com/19916543/144759902-6438cc49-f92b-4be1-be55-6920539fdf82.mp4
Steps to reproduce
Open the attached project. Open Bar.gd in the Script tab. Click on 'Lookup Symbol' in the context menu.
Minimal reproduction project
reproduction.zip

Not sure why, but if you drop class_name Foo and replace Foo with preload("res://Foo.gd") in Bar.gd, clicking do_work works correctly.

I located the issue.
The editor asks for the symbol here:
https://github.com/godotengine/godot/blob/e8082003f19ad8d98b6b2f74f64f4eaa7fe86353/editor/plugins/script_text_editor.cpp#L766
Eventually, the information is returned here:
https://github.com/godotengine/godot/blob/188e08307ee79920815ad4e5df2a7d2a60c649a0/modules/gdscript/gdscript_editor.cpp#L2807-L2813
But the editor doesn't know about result.class_path, and only looks for a result.script, so it takes the fallback path:
https://github.com/godotengine/godot/blob/e8082003f19ad8d98b6b2f74f64f4eaa7fe86353/editor/plugins/script_text_editor.cpp#L769-L777


PostgresQL error no schema has been selected to create in

Description
I created a few tables in my database and let the sea-orm-cli generate Rust types from the tables.
Now I want to implement that the schema gets loaded when the tables do not exist in the database.
But now I get the following error:

Steps to Reproduce

set up postgresql docker container
create a few tables
let the cli generate rust types from them
delete all tables from the database
now let the orm create them (using: schema.create_table_from_entity(user::Entity))

Expected Behavior
That the database uses the standard schema (default public)
Actual Behavior
Getting an SQLx error.
Reproduces How Often
Yes always.
Even after deleting the data folder etc.
Workarounds
Adding this to the table: #[sea_orm(table_name = "user", schema_name = "public")]
Doesn't fix migrations tho!!!
Reproducible Example

Will do this tomorrow!!!
Versions

Database: PostgresQL version 16.1 (Docker)
OS on Docker: Alpine v3.18
Host Os: Fedora 39 Workstation

Tried giving the user all usage and create permissions on the schema and defining the schema to use in the database uri but both don't work.


Expose 8777 port as a parameter

Expose the 8777 port as a parameter to enable multiple astroneer servers running on the same box.
How will AstroLauncher handle multiple ports?  One instance of AstroLauncher per port?

#14 Fixed this


branch coverage

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.85%. Comparing base (1a2b118) to head (84d355f).
Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##              main       #6      +/-   ##
===========================================
- Coverage   100.00%   92.85%   -7.15%
===========================================
  Files            2        2
  Lines           14       14
  Branches         0        3       +3
===========================================
- Hits            14       13       -1
- Partials         0        1       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BOBA L2 for Alt-L1s] Fix typo and secret names

:clipboard: Add associated issues, tickets, docs URL here.
Overview
Fix a typo in l2geth and update the secret names for publishing packages
Changes
Describe your changes and implementation choices. More details make PRs easier to review.

Fix a type
Update the secret names

Codecov Report

Merging #245 (cb0ce16) into alt-l1 (3e0893d) will increase coverage by 32.39%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           alt-l1     #245       +/-   ##
===========================================
+ Coverage   47.52%   79.91%   +32.39%
===========================================
  Files          99       55       -44
  Lines        3859     1708     -2151
  Branches      763      272      -491
===========================================
- Hits         1834     1365      -469
+ Misses       2025      343     -1682

Flag
Coverage Δ

boba-contracts
?

contracts
77.95% <ø> (ø)

core-utils
86.80% <ø> (ø)

data-transport-layer
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...boba/contracts/contracts/libraries/SafeMathDAO.sol

...s/boba/contracts/contracts/oracle/FeedRegistry.sol

...es/boba/contracts/contracts/LP/L2LiquidityPool.sol

...contracts/contracts/standards/L2StandardERC721.sol

.../contracts/libraries/Lib_ResolvedDelegateProxy.sol

packages/data-transport-layer/src/utils/common.ts

...ges/boba/contracts/contracts/L2BillingContract.sol

...ba/contracts/contracts/DAO/governance/Timelock.sol

...contracts/DAO/governance/GovernorBravoDelegate.sol

packages/boba/contracts/contracts/ERC2470.sol

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0893d...cb0ce16. Read the comment docs.


Travis failure related to beta

======================================================================
FAIL: test_beta_0 (pyfolio.tests.test_timeseries.TestStats)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/miniconda/envs/testenv/lib/python2.7/site-packages/nose_parameterized/parameterized.py", line 392, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "/home/travis/build/quantopian/pyfolio/pyfolio/tests/test_timeseries.py", line 283, in test_beta
    expected)
AssertionError: -7.228014483236697e-16 != 8.024708101613483e-32
----------------------------------------------------------------------

CC @richafrank

Looks like the failure happens on newest empyrical, starting in 0.4.0. cc @llllllllll @ssanderson

So the thing we appear to be testing here is that the beta of a returns stream against a constant benchmark is 0. If I put a breakpoint in empyrical, the values being passed for the day that's failing this test are:
(Pdb++) returns
2000-01-05    0.1
2000-01-06    0.0
2000-01-07    0.0
Freq: D, Name: 0, dtype: float64
(Pdb++) factor_returns
2000-01-05    0.0
2000-01-06    0.0
2000-01-07    0.0
Freq: D, Name: 1, dtype: float64

The "mathematically correct" result for this beta calculation is 0, but due to floating point rounding it's unlikely that you'll get exactly 0 from any implementation (you'll only get zero if the sum of a sequence of floats that should add up to zero actually adds up to exactly zero, which is unlikely) The test is currently asserting that we emit a beta of exactly 8.024708101613483e-32, which appears to have been copied from the result that scipy.stats.linregress produces. The new vectorized beta fuinction in empyrical uses a different algorithm, and thus produces a different (also very small) value.
I think the right fix for this test is to change the assertion to use np.assert_almost_equal or a similar "tolerant equal" check to assert that the beta we get here is zero.
Separately, I see two issues with the current rolling_beta implementation that are probably worth investigating further:

The handling of rolling_window appears to be off by 1.  The test is calling rolling_beta with a window of 2, but stepping through the code we appear to be operating on windows of length 3.
rolling_beta is implemented by repeatedly calling empyrical.beta on hand-computed slices from its input arrays, but empyrical already has a roll_beta function, which is about 200x faster:

In [13]: %timeit pf.rolling_beta(returns, factor, 252)
1 loops, best of 3: 521 ms per loop

In [14]: %timeit ep.stats.roll_beta(returns, factor, 252)
100 loops, best of 3: 2.19 ms per loop


Fix formatting of C# code blocks

Fixes https://github.com/dotnet/aspnetcore/issues/19445
I haven't actually run this yet (gotta install node??) so I might have missed something really obvious.. but hey the tests pass ¯\_(ツ)_/¯

Mergin' dis.. hopefully thats okay ¯\_(ツ)_/¯

Mergin' dis.. hopefully thats okay ¯_(ツ)_/¯

Definitely! You got the green checkmarks, good to go!


work integration tests

#1783

Added unit tests

Create work
Created work basic parameters
Phases
Work start date == first phase start date
Mandatory milestones
Each phase start date according to the number of days in work phases
Work lead should be in team as team lead
Get work details
Update work
Delete work
Work Exists

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (develop@ad9ae69). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1863   +/-   ##
==========================================
  Coverage           ?   73.04%
==========================================
  Files              ?      267
  Lines              ?     8870
  Branches           ?        0
==========================================
  Hits               ?     6479
  Misses             ?     2391
  Partials           ?        0

Flag
Coverage Δ

epictrack-api
73.04% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Uncaught TypeError when object is used inside a template in Chrome 56 (Beta)

Description

Live Demo

https://jsbin.com/hufisac/edit?html,output
Steps to Reproduce

<dom-module id="someid">   <template>       <object data="/path/to/swf" type="application/x-shockwave-flash"></object>   </template> </dom-module>
Expected Results

Polymer should register an element correctly
Actual Results

Uncaught TypeError: Cannot set property 'parentNode' of undefined
at Object.saveChildNodes (polymer-mini.html:486)
at HTMLElement._createLocalRoot (polymer-mini.html:1720)
at HTMLElement._setupRoot (polymer-mini.html:1707)
at HTMLElement._ready (polymer-mini.html:69)
at HTMLElement._readyClients (polymer-mini.html:82)
at HTMLElement._ready (polymer-mini.html:70)
at HTMLElement._readyClients (polymer-mini.html:82)
at HTMLElement._ready (polymer-mini.html:70)
at HTMLElement._readyClients (polymer-mini.html:82)
at HTMLElement._ready (polymer-mini.html:70)
Browsers Affected

[x] Chrome 56 (Beta)
[ ] Firefox
[ ] Edge
[ ] Safari 9
[ ] Safari 8
[ ] IE 11

Versions

Polymer: v1.7.1
webcomponents: v0.7.22

@pbcomm This issue is resolved with Polymer 2. Although I get the following error in JSBin Failed to load 'https://polygit.org/path/to/swf' as a plugin, because the frame into which the plugin is loading is **sandboxed**. Running locally with the same index.html shows no errors.


#1216 - Add open prop to TS declaration

This is messing with my builds, and it's tough to work around because I don't know how (don't know if it's possible?) to assign a JSX prop to the any type. Hope I put this in the right spot in the file!

☝ Pretty confident that build error isn't the fault of this PR. Any way to re-run it?

@BrendanBerkley Done, thank you!


We should add documentation regarding widget configuration

I am using this project for a side project and I wanted to add maximumSelectionLength attribute to my Select2MultipleWidget, and I was scouring through the docs and found nothing. I tried to edit the django_select2.js static file in /static/django_select2/ (I know, hacky, but I was out of options 😛)
A complete reference of Select2's config is available here: https://select2.org/configuration/options-api
Though, I think a minor difference is the config we provide to django_select2 must begin with data- and the config name must be lowercase, with each word separated by a hyphen.
So maximumSelectionLength becomes data-maximum-selection-length
Then I found out I had to provide a dict of config like Select2MultipleWidget({'data-maximum-selection-length': 5}) to make it work.
I'd like to add a documentation page regarding configuring widget attributes so that it'll be a good reference for the future and help others, too.

@ArionMiles very good point! I would very much welcome a pull-request from you adding a couple lines on how to customize the JS behavior and pass configuration via data attributes.

Apart from the config reference I've linked in my initial message, are there other config properties I'm missing and should know about?
There are also no instructions on how to modify the Language (and Translation objects) of select2, like the JS libary supports here: https://select2.org/i18n#translation-objects
if you could tell me here, I'd love to add them in the docs

@ArionMiles I think it's a very good start. I guess we also need to document, how to overwrite the actual JavaScript code, like it's done here https://github.com/applegrew/django-select2/issues/561#issuecomment-514491099
But that would be part 2, I guess.

I recently made use of django-select2 and as a beginner I have to say I'm quite lost. It could be really helpful if the guide covered more aspects of the configuration, such as establishing the language of the widgets, or as @ArionMiles already stated, setting select2 configuration parameters. I'm trying to follow his advice but I'm getting no result. I have such a narrow Select2Widget and I'm trying to customize it in forms.py without success.

Oh man I forgot about this! I'll try making a draft PR ASAP.

Thanks @ArionMiles, in the meanwhile, could you lend me a hand on how to set the width of the Select2Widget (not the model one) via the python code? Is it possible or do I have to do it via css?
Also, where do I have to specify the language of the widgets?
Thanks again for your work!

Could you create a separate issue?

Sure thing!

This repo has moved, please address your issue at https://github.com/codingjoe/django-select2 Thanks!


Support an annotation that skips building techdocs

Feature Suggestion
We'd like it to be possible to define the following catalog-info.yaml
apiVersion: backstage.io/v1alpha1
kind: Component
metadata:
  name: my-component-with-docs
  description: My awesome component
  annotations:
    backstage.io/techdocs-ref: dir:.
    my-org.com/skip-techdocs-build: true
spec:
...

Adding the annotation my-org.com/skip-techdocs-build (potentially customizable in config) with the value true would cause the techdocs backend to not attempt to build techdocs for this component. However techdocs would still be fetched from whatever datastore is in use, and the docs for this component would still be displayed in the UI. This would allow users to place their own tech-docs in the correct place and have them served. See the context below for more info on the use case.
Possible Implementation
Can we add an additional condition to this line? https://github.com/backstage/backstage/blob/9c17a6cdb9be6ba85ef9bfab76b94e672902b9fe/plugins/techdocs-backend/src/service/router.ts#L203
Something like
if (config.getString('techdocs.builder') !== 'local' || entity?.metadata?.annotations?.[config.getString('techdocs.builder.ignoreAnnotation'))

I'm happy to have a go at implementing this, or an alternate solution.
Context
At our organisation, we'd like to support a 'hybrid' approach to handling the building of tech docs.
One path would be the 'default'/'out of the box' experience, where the Backstage backend builds the docs for you. The advantage here is that users need only populate their repository with their docs and an mkdocs.yaml, and we do the rest for them. For many users, this would work well. The limitation is that the user is bound by the plugins we choose to offer, and other things related to the execution of mkdocs.
We'd like users to have the option of opting out of us building docs for them, if they need added flexibility in how they build their docs, or to customize mkdocs plugins etc. We think a sensible way for them to signal this would be to add an annotation to their catalog-info.yaml that indicates that we should not build the docs for them. They would instead build the docs themselves, and write them to the appropriate place for Backstage to serve them from.
If there's a better/easier way to accomplish this, we'd love to hear!

related: https://github.com/backstage/backstage/issues/5905

I've started work on this and hope to have a PR ready shortly

I wanna bring up the option of adding a bit of indirection in the TechDocs backend rather than adding a new standardized annotation for this use-case. I think the annotation route is a bit scary because it can quickly become messy as these kind of customizations are needed by more orgs.
Gonna need @backstage/techdocs-core to chime in with details, but what I'm suggesting is some form of EntityTechDocsResolver interface or something of that sort. For example that something like this mockup, although this is hopefully inaccurate as I don't know the internals of the TechDocs backend :grin:
interface EntityTechDocsResolver {
  resolveEntityTechDocs(entity: Entity): Promise<{
    type: 'built',
    ...
  } | {
    type: 'published',
    ...
  }>
}

That kind of interface would allow for both a custom annotation to be added if you want to solve your use-case that way, but it would also allow for selection with other methods. Perhaps a more user-friendly custom spec or metadata field? This is also a bit more future-proof in case of additions to the options for how to make TechDocs available on the frontend, with things like MDX possibly on the horizon.
I suspect there's significant overlap here with the publisher interface too, and in that case I suggest to add this kind of things there instead.

Hey @Rugvip, I had a go at implementing a 'strategy' interface for this, see this draft PR: https://github.com/backstage/backstage/pull/9567. Is this more along the lines of what you were thinking? Note: that draft is still early, needs lots of doc updates and some renaming.

@Niksko yep looks good! 👍
I also don't have enough context do will wait for @backstage/techdocs-core to chime in x)

@Niksko With #9567 merged can this issue be closed?

@soapraj yep, closing!

Is there more example code than the tech-docs how-to-guide to show exactly how this is implemented?


Bosun: /api/tagk to get all current tags across all metrics (also support basic filtering)

We were trying to find if a current tag is used, but the API doesn't have a route to return all tags. We could use the /api/metric route to get all metrics and then call /api/tagk/{metric} but it would be better if there was a /api/tagk route that returned a list of all metrics and tags.
/api/metadata/get has the information, but also includes other metadata which makes it an expensive call. The /api/tagk route could use the same format but just exclude the extra data:
[{"Metric":"os.disk.fs.space_used","Tags":{"disk":"/opt/gitlab"}},{"Metric":"web.comment.edited","Tags":{"host":"ny-web04","role":"coreqa","site":"datascience.stackexchange.com"}},{"Metric":"elastic.indices.suggest.current","Tags":{"cluster":"StackExchangeNetwork","index_name":"careers-full-cv-candidate-search-635643440065754201"}}]
The /api/metadata/get route is also close to what we would need when you provide a query string, but ?tagk=tagname doesn't work by itself (error: "unpaired tagk/tagv") or allow globs. The ability to request /api/tagk?tagk=tagname to find all metrics using a specific tag would be very helpful.

I'm not entirely clear on the expected result. Do you want a list of all tag keys, all tag values, or all tagk/tagv pairs?

The goal would be to find where and how the site tag is used. Values would be nice, but just knowing where a tag is used is difficult right now without pulling down the entire thing via /api/metadata/get.

Ya, that is crazy slow due to the number of requests required. I think a route that returns all metrics and their associated tag keys makes sense. From there you can expand the values in additional requests, since the number of values is potentially quite large, whereas the metrics and their available keys will be big but I think at least sane.


Simplify ZipFileDownloadFlow

What is this PR trying to achieve?
Make the ZipFileDownloadFlow simpler to understand, by removing some Akka stream constructs.
Who is this change for?
@kenoir who wants to fix an issue with zip downloads in this object.

Replaced by https://github.com/wellcometrust/platform/pull/3186


Integrate the 'argparse' library; add -l command-line option

Implements the rest of https://github.com/hishamhm/tl/issues/35.
Note that running tl script.tl will now result in an error.
Also, it would be nice if we had tests for the CLI tool :)

Also, it would be nice if we had tests for the CLI tool :)

@pdesaulniers  Added them! :grin:

Awesome! I added some tests for the -l argument too.
We'll need some tests for tlconfig.lua as well. To do this, I think we'll need to add a -p <path to directory with tlconfig.lua> argument to the CLI. I'll do this in a later PR.

I think this is good to go — could you rebase this PR and fix the conflicts so it can be merged?

Like this? :)


Update GWT.gitignore

Ingnore de pastas

Thanks, but could you explain these additions, and preferably link to documentation?

Closing due to inactivity and pending feedback.


Combine NSF and NIH award JSON views

See sample labels on CUIT mockup.
Ensure labels have proper red/green contrast. Possibly use viridis palette

UI locations to remove NSF:

docroot/modules/custom/features/cu_nsf_award/templates/paragraph/paragraph--nsf-award-paragraph-hero.html.twig
docroot/modules/custom/features/cu_nsf_award/templates/paragraph/paragraph--nsf-awards-listing.html.twig remove directorate as in commit 1b35a346532ae49812430a5d30941c076e3e3244


Overview/Implement ParamGrid for the world

create  list of dictionaries where each dictionary equals one world. Take a deeper look at how to implement them in a practical way. Add useful weights for different food spawn rates. Maybe try adding different kinds of food.

food-energy should change with every food-spawning
// or //
food should spawn in different rates

Idea for different worlds:

One world could contain many toxic foods and thus favor intelligent creatures that ignore toxic foods.
A second world could contain hardly any poisonous food and thus give aggressive creatures an advantage

how about a world with designated spaces where food can spawn (and only there)?
could be interesting in world with aggresiv agents or overcrowded worlds =)


I can't open a MZML file on MZMINE 3

Basic information

My operating system and version: WINDOWS 11 64 bit

My MZmine version: 3.3.0

What happened

Please describe what happened and how it differs from what you expected to happen.
#I can't open MzML file on Mzmine 3.3.0. I have got the error message bellow :

Please upload screenshots of any errors and your log/mzmine.log file.

#If I try to import MzXML it's work, but no a MzML file. I think there is a problem of encoding but I can't find why/where.
#I have got this JAVA version :

Please upload a standalone MZmine project file (or a batch + raw files) that demonstrates the problem you are reporting. You can use Google Drive, Dropbox, or a similar repository to upload the project.
Issues opened without an example project are unlikely to be processed
#I don't have because I can't load data files
#Please find below a MzML file type which doesn't load on MZMINE 3
https://nuage.osupytheas.fr/apps/files/?dir=/marie_derrien/Sauvegardes/PAYSAGES%20CHIMIQUES/TEST%20mzml&fileid=85177618

#Thank you for your help

This is probably a duplicate of issue https://github.com/mzmine/mzmine3/issues/950, please take a look at it.

we are working on this. your mzml file might contain characters that we are not able to parse.
We have a solution soon. But still working on this.
Make sure to not use weird characters in the file path and file name when you convert

Hi,
Yes I found the problem, it was coming from the name of a folder containing a special (french) character. Thus, this name wasn't recognized by Java when I tried to export mzmine files through file path.
Thanks,

Hello,
I have a similar problem. When I want to put my mzML files on mzmine, I get the have :  "error parsing mzML Illegal base64 character 0x3e (MzMLMsScan.java:258)"
How can I resolve this, please ? The files are able to be transfer on mzmine on another computer.

Hello,
It easy to resolved, check that you don't have special character like
accent or other character relie to a language in your folder/pathway
directory/... from the data to Mzmine.
Cheers,
Marie
Le 2023-05-25 12:18, Shamsia a écrit :

Hello,
I have a similar problem. When I want to put my mzML files on mzmine,
I get the have : "error parsing mzML Illegal base64 character 0x3e
(MzMLMsScan.java:258)"
How can I resolve this, please ? The files are able to be transfer on
mzmine on another computer.
[1]
--
Reply to this email directly, view it on GitHub [2], or unsubscribe
[3].
You are receiving this because you authored the thread.Message ID:
@.***>
Links:
[1]
https://user-images.githubusercontent.com/134603532/240881851-3ad32903-45f3-42b9-b38b-a261cb0e23b0.PNG
[2]
https://github.com/mzmine/mzmine3/issues/1133#issuecomment-1562652441
[3]
https://github.com/notifications/unsubscribe-auth/A44MJXMXX47SJZ7XPQN6YIDXH4WYRANCNFSM6AAAAAAUUHJ5N4

--
MARIE DERRIEN
PhD Student in Marine Chemical Ecology
Equipe DFME: Diversité et Fonctionnement des Molécules aux Ecosystèmes
06 21 78 58 53
Institut Méditerranéen de Biodiversité et d'Ecologie marine et
continentale
IMBE UMR CNRS 7263 / IRD 237 / Aix Marseille Université
Station Marine d'Endoume
Chemin de la batterie des lions
13007 MARSEILLE

Hello, thank you for your reply. I've checked the names of my folders and files, none of them contain special characters and yet the file transfer still doesn't work :(
I even tried renaming all the folders/files.
Sincerely
Shamsia


Murder Mystery - Stuck on step

It seems that when we reach the step that says "Search Bob's barrel on the ground floor." it doesn't move past that. I've tried to drop the item that we get from the barrel and get a new one and it still does not proceed.
A "skip step" button would be greatly appreciated!

Ah - Although the message kept saying for me to search the barrel, when I continued on with the quest the message updated.


Support dynamically sized types

It supersedes #209 for supporting dynamically sized types (DST) in Crossbeam.  It's much cleaner and less intrusive than the previous attempts in that it doesn't introduce another Atomic type.  Atomic<T> is still there without significant changes.
The key idea is (1) instead of requiring the condition on T: Sized, (2) requiring T: Pointable that means an object of type T can be pointed to by a single word.  For instance, Atomic becomes: pub struct Atomic<T: ?Sized + Pointable> { ... }.
It is breaking the backward compatibility in that it (1) increases the minimum required Rust version to 1.36 (for MaybeUninit) and (2) now const fn Atomic::null() is Nightly only.

I think it's ready to be merged.  If everyone's happy with it, I'll merge it 3 days later.

bors r+


handling multiple required commands "on-open"

Hi,
currently the Dial procedure assumes a single disablePager command is required to prepare the session.
This seems a bit limiting. Some platforms do require several commands to prepare it for non-human driven CLI session. For example, to disable completion-on-space.
With that in mind it seems reasonable to pass a onOpen() function to the session preparation step where driver author can pack all that is needed to prepare the device.

Hm, I've viewed the establishConnection helper as a function for ios like devices and that it would be quite simple to implement something else in the Dial method for other drivers.
For your example I assume it would be enough to move from:
func establishConnection(ctx context.Context, p Platform, c connection, prompt *regexp.Regexp, disablePager string) error {
To the below and then just iterate over each preparationCommands and execute them one by one, or do you see anything more complex that's needed?
func establishConnection(ctx context.Context, p Platform, c connection, prompt *regexp.Regexp, preparationCommands ...string) error {

yes, a in my case a list of commands will suffice


Fix: shared public key

Companion of https://github.com/interlay/interbtc/pull/574 and https://github.com/interlay/interbtc/pull/571

Succeeded by #280


[Performance] Oak-D camera not able to reach desired publish rates

I have been trying to use the Oak-D Wide and Oak-D Lite in RGBD mode for use in vslam using the PR here
I have noticed that the camera is not able to publish at the requested rates with either the Depth or RGBD pipelines.
My RGBD yaml is:
/oak:
  ros__parameters:
    camera:
      i_calibration_dump: true
      i_enable_imu: true
      i_enable_ir: true
      i_pipeline_type: RGBD
      i_publish_tf_from_calibration: true
      i_tf_imu_from_descr: 'true'
      i_usb_speed: SUPER_PLUS
    stereo:
      i_publish_topic: true
      i_reverse_stereo_socket_order: true
      i_publish_synced_rect_pair: true
      i_publish_left_rect: true
      i_publish_right_rect: true
      i_update_ros_base_time_on_ros_msg: false
      i_align_depth: true
      i_resolution: '400P'
    left:
      i_resolution: '400P'
      i_fps: 120.0
    right:
      i_resolution: '400P'
      i_fps: 120.0
    rgb:
      i_resolution: '1080P'
      i_fps: 30.0
      i_publish_topic: true
    use_sim_time: false

All the topics, including the IMU are not able to reach the desired rates.
The USB is in SUPER mode.
Any help here would be appreciated.

Hi, I think this might be bandwidth related, by default in RGBD mode Stereo is scaled up for better alignment with RGB frame (and its FPS is based on left/right streams). This can be overridden with i_height/i_width params, or you can shrink down rgb frames using ISP scaling. If that does not improve things, you can also try using low_bandwidth mode for the sensor streams. More information on latency can be found here.

Hi, sorry for the delay, as mentioned this is probably related to bandwidth, for rectified stereo streams you need to set those parameters separately, for example i_right_rect_low_bandwidth_quality: 50 (full yaml file can be found here)


Keyboard shortcuts

Would it be possible to add keyboard shortcuts to Solution Explorer, such as:

Delete
Rename
Add new file
Copy
Paste
Others

Hi, I'm that person who have given 4 stars to your extension on its Visual Studio Code page. It doesn't work when context menu is visible either. This extension has a future and I appreciate all of your work on the issues.

Hi, even the context menu is visible, the keys are not working.
Extension version: 0.3.2
VSCode version:

Version: 1.33.1
Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8
Date: 2019-04-11T08:27:14.102Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 6.1.7601

This issue still persists on v0.4.3
Version: 1.55.2
Commit: 3c4e3df9e89829dce27b7b5c24508306b151f30d
Date: 2021-04-13T09:37:02.931Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.11.13-200.fc33.x86_64


HUB-63: Tear down AB test to remove performance management

Reverse changes made in HUB-52
c6e9d07862ff94a88a070b819a48729d6891ea64
Author: @CharlesIC

Nice work, looks good to me, don't forget the fed and app config updates too. In order not to break joint, this has to go first and then the other ones.

Pushing the configs now...


[multistage][bugfix] fix singleton exchange

singleton exchange was broken b/c of the worker assignment strategy.
This is a fix for instantiating singleton exchange, more to follow up properly
this change

only send data via the local exchange and doesn't send data over the network I/O
will still make broadcast of EOS block to all mailbox (regardless of whether they are local) for signaling an end of a stage)

follow up

make sure it work with multiple worker on the same host (partition strategy and worker assignment)
make mailbox assignment visitor to create proper list of send/receive based on exchange type instead of creating a fully-connected network and only send EOS over the wire for network I/O

CC @xiangfu0 and @ankitsultana

Codecov Report

Merging #10797 (ae9c7cd) into master (5577c38) will decrease coverage by 36.46%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #10797       +/-   ##
=============================================
- Coverage     68.58%   32.13%   -36.46%
+ Complexity     6477      462     -6015
=============================================
  Files          2159     2159
  Lines        116040   116032        -8
  Branches      17569    17564        -5
=============================================
- Hits          79586    37284    -42302
- Misses        30823    75444    +44621
+ Partials       5631     3304     -2327

Flag
Coverage Δ

integration1
?

integration2
23.78% <0.00%> (?)

unittests1
?

unittests2
13.67% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...y/runtime/operator/BaseMailboxReceiveOperator.java
0.00% <ø> (-93.34%)
:arrow_down:

...ot/query/runtime/operator/MailboxSendOperator.java
0.00% <ø> (-86.37%)
:arrow_down:

...y/runtime/operator/exchange/SingletonExchange.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 1441 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


series of endpoint builds queued in quick succession for same endpoint

From cilium endpoint log:
2018-04-17T20:51:08Z   OK        waiting-to-regenerate   Successfully regenerated endpoint program due to endpoint policy updated & changes were needed
2018-04-17T20:51:08Z   Warning   waiting-to-regenerate   Skipped invalid state transition to ready due to: Completed endpoint regeneration with no pending regeneration requests
2018-04-17T20:51:07Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:07Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:07Z   OK        waiting-to-regenerate   Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:07Z   OK        regenerating            Regenerating Endpoint BPF: endpoint policy updated & changes were needed
2018-04-17T20:51:07Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   Warning   waiting-to-regenerate   Skipped invalid state transition to waiting-to-regenerate due to: Triggering endpoint regeneration due to policy updates
2018-04-17T20:51:06Z   OK        waiting-to-regenerate   Triggering endpoint regeneration due to policy updates

We need to figure out what is causing these updates, and whether we can find some way to batch updates for the same endpoint in quick succession.

https://github.com/cilium/cilium/pull/5341 was added to indicate why policy updates are triggered.
https://github.com/cilium/cilium/pull/5077 is also being worked on to fold calls to TriggerPolicyUpdates.
This is also quite stale, so I am closing accordingly.


TP2000-647  Add suspension periods tab to Quota detail view

TP2000-647  Add suspension periods tab to Quota detail view
Why

Users are unable to view details of any suspension periods in place for a quota.

What

Adds suspension periods tab, showing active or upcoming suspension period.
Adds unit test for suspension periods tab.

Example:

Codecov Report
Base: 93.10% // Head: 93.11% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (90aadeb) compared to base (eaf8c03).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #775   +/-   ##
=======================================
  Coverage   93.10%   93.11%
=======================================
  Files         370      370
  Lines       23914    23926   +12
  Branches     1840     1839    -1
=======================================
+ Hits        22266    22278   +12
  Misses       1304     1304
  Partials      344      344

Impacted Files
Coverage Δ

quotas/tests/test_views.py
100.00% <100.00%> (ø)

quotas/views.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


The images on the sample projects - samplepr1.html

The file samplepr1.html have faulty images or maybe the images are not available in the main directory.

In any case, that needs to be sorted out.
Thank you!!

Since the sample projects folder is deleted, this issue is closed.


midterm done and dusted

https://www.youtube.com/watch?v=Iviz8cNECTg

Ah but do you know your curveballs from your googlys: https://en.wikipedia.org/wiki/Googly


java_requirement: Add newline to failure message

Signed-off-by: Bob W. Hogg<EMAIL_ADDRESS>
[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

The existing error output is kind of unattractive (Java#{version_string} is required to install this formula.JavaRequirement failed!); this just makes it a little nicer to read. You're not likely to see it since in most cases the Cask or the JDK formula will just get installed automatically, but no reason to leave it like this.

Thanks @rwhogg!