Floating label on textfield overlaps with input value

The floating lable in a text field overlaps with the input text when it's removed and reset with onblur:

Steps to reproduce
Create a text field with an onblur method that resets the value to something else:
import React, { Component } from 'react';
import TextField, {Input} from '@material/react-text-field';
import './App.css';

class App extends Component {
  constructor(props) {
    super(props);
    this.state = {value:"hello"};
  }

  render() {
    return (
      <div className="App">

        <TextField outlined label='Label'>
          <Input
            value={this.state.value}
            onBlur={()=>this.setState({value:"Noooo"})}
            onChange={(e)=>this.setState({value:e.target.value})}
          />
        </TextField>
      </div>
    );
  }
}

export default App;

Delete all content in the input field
Press anywhere outside the text field
Let the bug happen

Maybe a fix could be to reuse the code that checks if there's text in the input when the text field is mounted (this is done to prevent the lable from overlaping the input text when it's mounted in case a value is set from the beginning) to check every time it blurs or every time the class changed to --float-above ?

Oh yeah nice and quick fix, great work :+1:
Should this be closed now or when the PR gets merged ?

This seemed important and quick :)
We'll leave it open until it is merged into master - Thanks again

I've just run this this issue with some of the fields that I'm using. I'm a bit of a newbie and wondering what the best way is for me to resolve this. Are there any recent best practices?
Thanks in advance!
-Derek

@derektumulak are you still running into this? A codepen/stackblitz will help in helping you.


Bootstrap ReadTheDocs website

Most was copied from the plutus and plutus-apps repo.

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[ ] Commit sequence broadly makes sense and have useful messages
[ ] Important changes are reflected in changelog.d of the affected packages
[ ] Relevant tickets are mentioned in commit messages

PR

[ ] (For external contributions) Corresponding issue exists and is linked in the description
[x] Targeting main unless this is a cherry-pick backport
[x] Self-reviewed the diff
[ ] Useful pull request description
[ ] If relevant, reference the ADR in the PR and reference the PR in the ADR
[x] Reviewer requested

@kayvank Review please.

I noticed that I get a 404 for this link http://localhost:8000/haddock

Yes, that is expected as I haven't setup Haddocks. That will be a separate issue.
Did you see a link that points to that URL?


GetDOFValues() sometimes shows different joint values before you "Set DOF values"

If you do this in simulation:
print robot.left_arm.GetDOFValues()

and move the interactive marker on HERB's gripper, the DOF values will briefly change before going back to the current value.
.
Sample output:
Left arm:
[ 0.64 -1.76  0.26  1.96  1.16  0.87  1.43]
Left arm:
[ 0.64 -1.76  0.26  1.96  1.16  0.87  1.43]
Left arm:
[ 0.64 -1.76  0.26  1.96  1.16  0.87  1.43]
Left arm:
[ 1.52563504 -1.02107609  0.26        1.46940765 -0.09560255  0.72554407
1.79008285]
Left arm:
[ 0.64 -1.76  0.26  1.96  1.16  0.87  1.43]
Left arm:
[ 0.64 -1.76  0.26  1.96  1.16  0.87  1.43]
Left arm:
[ 0.64 -1.76  0.26  1.96  1.16  0.87  1.43]
Left arm:
[ 0.64 -1.76  0.26  1.96  1.16  0.87  1.43]
.
And sometimes the DOF values will change even if you don't move the interactive marker at all:
Left arm:
[ 0.68736719 -1.62339552  0.26        1.78412589  1.03275265  0.8791257
1.50576206]
Left arm:
[ 0.68736719 -1.62339552  0.26        1.78412589  1.03275265  0.8791257
1.50576206]
Left arm:
[ 0.68736719 -1.62339552 -2.74016693  1.78412589  1.03275265  0.8791257
1.50576206]
Left arm:
[ 0.68736719 -1.62339552  0.26        1.78412589  1.03275265  0.8791257
1.50576206]
Left arm:
[ 0.68736719 -1.62339552  0.26        1.78412589  1.03275265  0.8791257

Interesting. It sounds like we're missing a lock somewhere. Is this using the in-process viewer (rviz) or the out-of-process viewer (interactivemarker)?

I double-checked and it occurs with both the in-process and out-of-process viewers.


Refactor Code

start refactoring your code in CustomDropDown.swift.
You can use my layout for future documentation, I think it's pretty nice. Works fine for me :)
CustomDropDownPresenter.swift not complete?
Greetings!

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe on what device it is tested

Xcode:
Model name:

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

Reviewers:
Please tag relevant people requesting a review

Please add #Hacktoberfest Tag to your project.
Thanks 👍

Hey @iskandir thank you for your interest. I'm glad you are trying to contribute but there are other changes going on in this project. So, you need to wait for some more time for this to be merged and there might be changes as well. That you need to update your branch later and make the necessary description and changes accordingly. Thanks again! Feel free to create new issues and raise prs for other issues

Are you working on this @iskandir


Add option for gradients

Description of your Suggestion
Proof of concept progress bar gradient
Can be added to Volume bar and other Text/Buttons/Displays
Extra (if applicable)

#72


Update contributing doc to include instructions to set up Earthdata Login credentials on a fork so integration tests can run on PRs

Should probably be the first step we instruct contributors to do after forking.

@mfisher87 Would'nt this encompass just a block(having the username and password) with directions?

I'm thinking we can maybe make it a sub-bullet of the second bullet on the contributing document?

:bow: Thanks, Sherwin!

Is this one urgent or is it something we can hold for now?

I don't feel that it's urgent :)

Will be OBE by #811

OBE by #818

Thank you, Chuck! This work will also be useful to icepyx :)
cc  @JessicaS11


Is this project active?

Hi all.
I want to help, but I want to know if this project is active. Is this project active?
So... I would like to know the difference between lite-xl/lite-xl and rxi/lite.

the project isn't active, lite-xl/lite-xl is a text editor built on top of lite by a different lite loving community, lite-xl/lite-xl fixes many bugs & has introduced new features, you should look there.


Exported shared utility folder from component library

Fixes # https://github.com/etn-ccis/blui-react-native-showcase-demo/issues/143
BLUI-5004

Changes proposed in this Pull Request:

Added next button disabled color in Mobile stepper to be disabledContainer and onDisabledContainer

Screenshots / Screen Recording (if applicable)

To Test:

Checkout bug/5004-143-update-disabled-button-colors in showcase
yarn start

Any specific feedback you are looking for?

Why is AppTheme defined in React Native library? Should it be defined in the React Native themes package instead? Are we planning to move it out of the component library?

Why is AppTheme defined in React Native library? Should it be defined in the React Native themes package instead? Are we planning to move it out of the component library?

AppTheme as a type is defined here because it specifies the theme type required to work with our components. It's not a theme itself, it's just a type. Our component library can work with any theme that implements this type (not just our themes). Hence it is defined in the component library, since that's where the custom values are consumed.
We could defined the type in our theme and import it from our theme package. The only caveat to that is that if someone wanted to use a custom theme (that meets our extended type definition), they would have to include our theme as a dependency even though they aren't using it.

they would have to include our theme as a dependency even though they aren't using it.

Dragging the type package out of its freshly digged grave
Here's the thing: there are two flavors of theme types mentioned here, (1) what the theme actually looks like, and (2) theme tokens/variables required and actually used by our components. Standard RNP tokens, such as inverseSurface, and custom color tokens, such as primaryNonText, are NOT required to make our components work properly. I don't know if such a distinction is necessary.
I also want to mention that SANTAK is the only Eaton white labeled product that uses our theme and customize the basic color tokens. And all they were doing was taking our theme as it is but swapping the blue color for a red color. I am not aware of other Eaton product that uses only our component without our theme... And Joe your side project is the only one I am aware of outside Eaton.
So a perfectionist approach would be to define two types -- an exported version of a comprehensive theme structure and a separate type that contains only the types needed to make our component lib work? Idk...

We need to move the useAppTheme hook to the react-native-themes package. Closing this PR since these changes are not required.


FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version.

Problem description

What did you do?

la_county = ox.geocode_to_gdf("Los Angeles County, USA")

What did you expect to happen?

Geocoding response without FutureWarning

And what actually happened instead?

Correct geodataframe response with FutureWarning.

osmnx/geocoder.py:110 FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead. gdf = gdf.append(_geocode_query_to_gdf(q, wr, by_osmid))

Environment information

What operating system are you using?

Ubuntu 21

What Python version are you using?

Python 3.8

What OSMnx version are you using?

1.1.2

Provide a complete list of your environment's packages and their versions (for example, run conda list or pip list then paste the output between the two "details" tags below)

osmnx = "1.1.2"
jupyterlab = "3.2.5"

Minimal reproducible example
import osmnx as ox
la_county = ox.geocode_to_gdf("Los Angeles County, USA")

We should be able to fix this with a .concat() call, a la: https://pandas.pydata.org/pandas-docs/stable/whatsnew/v1.4.0.html#whatsnew-140-deprecations-frame-series-append


Add "Force Refresh Companion" menu item to "Connect"

Describe the desired feature

Add a menu item to the Connect menu called Force Refresh Companion that will resend all of the YAIL for the screen.
Give an example of how this feature would be used

On rare occasions we might not detect that the screen needs to be updated. In this case, the developer can use this option to force resending the entire screen (versus editing a designer property or switching projects).
Why doesn't the current App Inventor system address this use case?

It can, but doing so uses a workaround rather than a blessed feature. It's possible we might break these workarounds in the future so a dedicated function would be preferred.
Why is this feature beneficial to App Inventor's educational mission?

In instances where the companion becomes out of sync with the editor, students and teachers can use this to get things back into sync. It would also be useful to include some sort of analytics when this happens in order to understand why it happened.

@mit-cml/cornell-cs-5152-students-fall-2019 @bartmathijssen One of you might want to take a look at this.

Hey @ewpatton can you assign me to this? Also, can I get an idea of where I should look into for adding the menu item / the function for refreshing the companion app?

@kalsheikh The menus are constructed in TopToolbar#createConnectMenu and an example of how to send the screen to the device is shown in YaFormEditor#updatePhone. You'll want to add an entry to OdeMessages.java for internationalization of the menu text.


feat(tablekit-modal-dialog): add maxWidth and maxHeight props

completes #31

@irmir what's the status of this PR? I thought this would be ready to merge today

:rocket: PR was released in<EMAIL_ADDRESS>:rocket:


unexpected eof in qemu_cortex and mps2

Describe the bug
The tests/subsys/logging/log_backend_init falied on qemu_cortex and mps2.
Observed for

qemu_cortex_m0
qemu_cortex_m3
mps2_an385
mps3_an547
mps2_an521

To Reproduce
Steps to reproduce the behavior:

have qemu_cortex_m0 or mps2
go to your zephyr dir
use twister -p qemu_cortex_m0 -T tests/subsys/logging/log_backend_init -vv
see error:
tests/subsys/logging/log_backend_init/logging.log_backend_initialization FAILED unexpected eof (qemu 0.269s)

Logs and console output
INFO    - /__w/zephyr/zephyr/twister-out/qemu_cortex_m3/tests/subsys/logging/log_backend_init/logging.log_backend_initialization/handler.log
INFO    - 114/462 qemu_cortex_m0
tests/subsys/logging/log_backend_init/logging.log_backend_initialization FAILED unexpected eof (qemu 0.269s)
INFO    - /__w/zephyr/zephyr/twister-out/qemu_cortex_m0/tests/subsys/logging/log_backend_init/logging.log_backend_initialization/handler.log
ERROR   - *** Booting Zephyr OS build zephyr-v3.1.0-3289-g0066254f5650  ***
Running TESTSUITE log_backend_init
===================================================================
START - test_log_backends_initialization
 PASS - test_log_backends_initialization in 2.217 seconds
===================================================================
TESTSUITE log_backend_init succeeded
===================================================================
RunID: ca515[183](https://github.com/zephyrproject-rtos/zephyr/runs/7760052717?check_suite_focus=true#step:12:184)eafc8f3faad76f3742dcb209
PROJECT EXECUTION SUCCESSFUL

Advice
Comment out the LOG_PANIC() of 943 lines https://github.com/zephyrproject-rtos/zephyr/blob/f5378424f7f492a8ae0d173a015bc1186fcc7127/subsys/testsuite/ztest/src/ztest_new.c#L943
Environment (please complete the following information):

OS: Linux
Toolchain - SDK 14.1
Commit SHA  https://github.com/zephyrproject-rtos/zephyr/pull/48848

The log is showing a successful run, so I am not sure what the issue is.

The log is showing a successful run, so I am not sure what the issue is.

log error update

Not aware of why "LOG_PANIC()" in ztest_new.c, but that need all log_backend implement "panic" interface, if not, access to NULL pointer will cause crash,  "unexpected eof" will come up.

@1xlibiao @mengxianglinx  could you continue updating and working on this bug?

By implementing panic() interface for log_backend, the "unexpected eof" issue of some qemu platform disappears. close it.


Use the GenericJob interface by MPIJob

What type of PR is this?
/kind feature

What this PR does / why we need it:
This aligns the implementation of the MPIJob controller with Job controller. It also already drops some code that was duplicated.
Which issue(s) this PR fixes:

Part of #369
Special notes for your reviewer:
There will be follow ups:

commonize the Reconcile functions
commonize indexing
commonize webhooks

/assign @alculquicondor @kerthcet
Please review, there will be follow ups, but it seems a sensible step on the path to the library for frameworks.

cc @mwielgus


Did something break?

Clicking on the Save button stopped working after you fixed the Geolocation. 😢

Likely, Save button does not work

Mmmmh, have you the latest version with api?
I'll take a look and get back to you :)

You both right, I tried the api in the new url by dashboard, and forgot to remove the reference and get back with it at his natural state (via prisma client instead of bouncing to internal api). and mostly the api link was hardcoded for the test to the local area of development, hence its not working.
I'll put it back with the release i'm building now :)
it should work now, let me know and i'll close the issue :)

Demo works fine, thank you!
Just discovered that there is a limitation for 2nd level domain name length, try to shorten https://ya.ru. I believe you'll fix it in a cople of seconds ;)

you are absolutely right.
i'm uploading this version to ensure https and allow two letter tld

also closing the issue thank you very much!


Docs readthrough [WIP]

This is ready to be looked at.
I've tried to explain why I've done things when it isn't obvious. This is either done with github comments, or comments in the code prefixed with cbx_ or cbx_aph. There are also a couple of open question in the code. Please ping me if anything is unclear.
About 50% of the changes are straight docs changes. The rest are mostly function with unused arguments. In those cases I've remove the args (and made the related docs change!). There are a couple of places where things are a bit more complicated - i.e. the docs claim that something is optional when it is not, or I've noticed something wrong.
I've tried to only make these more complicated changes when 1) they are a bug, and 2) they are very small/easy to fix.
I'm sorry if any of these changes are pedantry :)
A crazy idea that I had: There are a ton of duplicated docs (such as the one for approx_cell1_size in all the pairfinders. You could define the somewhere and then include them in the docs with a format string. I was briefly excited by this but now think it is a bad idea - too much complexity for minimal gain.
I'm reasonably confident that test failures aren't related to what I've done.
Please feel free to keep/throw away parts of these changes. It's also a pretty spotty lookover - I mainly looked at the parts of HT that I use the most. The codebase is much larger that I thought before I tried to look at all of it :)

I rebased on ce9bf4ec, which passes on Travis. Everything passes with this PR except for the docs build, so there must have been a breaking change to the docs somewhere. Now trying to track it down.


How to tune tusimple_lanenet.yaml for better accuracy?

Hi, how can we learn more about what the config parameters are doing in?: config/tusimple_lanenet.yaml
Some are intuitive, but others I'm not sure what they might do. I'm experiencing accuracy issues where lanes are not always detected that I'd like to hopefully solve by tuning the sensitivity but I'm not sure which parameters to consider.
I am especially curious about these sections (I see some comments, but still not sure what impact on performance/accuracy some of these may have):
AUG:
    RESIZE_METHOD: 'stepscaling' # choice unpadding rangescaling and stepscaling
    FIX_RESIZE_SIZE: [720, 720] # (width, height), for unpadding
    INF_RESIZE_VALUE: 500  # for rangescaling
    MAX_RESIZE_VALUE: 600  # for rangescaling
    MIN_RESIZE_VALUE: 400  # for rangescaling
    MAX_SCALE_FACTOR: 2.0  # for stepscaling
    MIN_SCALE_FACTOR: 0.75  # for stepscaling
    SCALE_STEP_SIZE: 0.25  # for stepscaling
    TRAIN_CROP_SIZE: [512, 256]  # crop size for training
    EVAL_CROP_SIZE: [512, 256]  # crop size for evaluating
    CROP_PAD_SIZE: 32
    MIRROR: True
    FLIP: False
    FLIP_RATIO: 0.5
    RICH_CROP:
        ENABLE: False
        BLUR: True
        BLUR_RATIO: 0.2
        MAX_ROTATION: 15
        MIN_AREA_RATIO: 0.5
        ASPECT_RATIO: 0.5
        BRIGHTNESS_JITTER_RATIO: 0.5
        CONTRAST_JITTER_RATIO: 0.5
        SATURATION_JITTER_RATIO: 0.5
DATASET:
    NUM_CLASSES: 2
    PADDING_VALUE: [127.5, 127.5, 127.5]
    MEAN_VALUE: [0.5, 0.5, 0.5]
    STD_VALUE: [0.5, 0.5, 0.5]
    CPU_MULTI_PROCESS_NUMS: 8

In case it helps, here is example footage between 2:30 and 2:45 where only the right-most lanes are detected:
https://youtu.be/iBSfljfnE30?t=150

In case it helps, here is example footage between 2:30 and 2:45 where only the right-most lanes are detected:
https://youtu.be/iBSfljfnE30?t=150

@zoombinis 1.For details in params you'd better read the origin paper. 2.For practical application you'd better train your own model on your own dataset:）

@zoombinis 1.For details in params you'd better read the origin paper. 2.For practical application you'd better train your own model on your own dataset:）

@MaybeShewill-CV I read the paper but none of these parameters are discussed. Do you know what the parameters are for or are these copy and pasted from somewhere else?

@MaybeShewill-CV I read the paper but none of these parameters are discussed. Do you know what the parameters are for or are these copy and pasted from somewhere else?

@MaybeShewill-CV Thanks it's now clear besides clustering none of those params affect inference other than GPU memory fraction.
However, I've also noticed if I aim my web cam at the youtube video while it is playing, there are certain distances to the screen at which LaneNet accuracy improves for my camera recording.
Any thoughts on why that might be? Maybe because by distancing further from the screen I'm closer to the distance the tusimple camera was from the road?
Thanks in advance. Knowing how to maximize accuracy with a personal camera I think is useful for me and others like me that can't afford to retrain right now.

@MaybeShewill-CV Thanks it's now clear besides clustering none of those params affect inference other than GPU memory fraction.
However, I've also noticed if I aim my web cam at the youtube video while it is playing, there are certain distances to the screen at which LaneNet accuracy improves for my camera recording.
Any thoughts on why that might be? Maybe because by distancing further from the screen I'm closer to the distance the tusimple camera was from the road?
Thanks in advance. Knowing how to maximize accuracy with a personal camera I think is useful for me and others like me that can't afford to retrain right now.

@zoombinis How much time your lanenet.postprocess() i.e. dbscan clustering part is taking per sample?


[Deepak Foundation] User is able to record midline screening details

[x] Create a program encounter named "Midline screening"
[x] Schedule it 3 months after Baseline is done.
[x] Form requirements:
https://docs.google.com/spreadsheets/d/1h_eQJRhAN-SSWXoCfpN74o0RAqC0ajHTkrZUh8hPk_c/edit#gid=1846320309
[x] Schedule Endline after 3 months of Midline, when Midline is completed.
[x] If Blood sample collected is Yes in Midline screening, then schedule Record Blood sample result encounter after a week.

ETC :- 45 mins

[ ] Lymphocytes (%) missing the validation
[ ] Eosinophiles (%) missing the validation
[ ] Monocytes (%) missing the validation
[ ] Basophils (%) missing the validation

@dinesh2096 move this card to Deploy ready if QA is done successfully. We will only keep Epics in "Ready for review" lane, not the issues.


If collect_attention = False is always False, what's the role of ar and ar2

When collect_attention = False, we always run this line, ar and ar2 do not have any effects, is this a bug?

This is indeed a bug, thanks for the reminder!


why this icon can not show

emacs 29.1

Hi, sorry to bother you. I know this question may be simple, but I have been trying for a long time. Why can’t this character be displayed normally?

What font you are using?

i use this one
jb font

Maybe it doesn't support this Unicode glyph. Try to change the font to one of a Nerd Fonts patched font.

Which OS you are using?

Which OS you are using?

manjaro i3wm

i test the font ttf-iosevka-fixed-curly-slab  but still not work
emacs 29.1    /configure --with-native-compilation=aot --with-tree-sitter

I found the problem.

The unicode-font package was not successfully installed. The ensure t field may be required
+unicode-fonts-setup not executed correctly  when minemacs-after-startup
then i try  M-x  +unicode-fonts-setup   got some error

Hello @donneyluck ,
The unicode-fonts configuration is now obsolete, I'm not using it in my machine and the font shows fine. It can be interesting for non-latin languages, but in my daily use, I didn't find any usefulness for it.
I've changed the glyph used to replace the project- prefix, so it should display correctly now.

ok, it can be displayed normally now, but I want to find out why some characters cannot be displayed. Is it supported by my font?

I don't know the exact reason, some fonts do not support additional Unicode glyphs, and if you are using unicode-fonts, you need to install extra fonts for it to work correctly (as specified in the unicode-fonts project README).
I'm using Emacs 29.1 on a Manjaro Linux machine, with the "Iosevka Fixed Curly Slab" font and without the unicode-fonts package, and all is working fine.

ok I understand. There should still be some fonts missing. Thank you for your help.


chore(eslint): more opts for linting

I'm really eager to use this library, so my first step was to try to install it then
tinker with the examples.
However, npm install from source requires linting to pass. With a fresh
install, eslint will report a slew of errors.
$ npm install

><EMAIL_ADDRESS>prepublish /Users/kyle/code/src/github.com/blesh/redux-observable
> npm test

><EMAIL_ADDRESS>test /Users/kyle/code/src/github.com/blesh/redux-observable
> npm run build && npm run build_tests && mocha temp

><EMAIL_ADDRESS>build /Users/kyle/code/src/github.com/blesh/redux-observable
> npm run lint && rm -rf lib && babel src -d lib

><EMAIL_ADDRESS>lint /Users/kyle/code/src/github.com/blesh/redux-observable
> eslint src && eslint test

/Users/kyle/code/src/github.com/blesh/redux-observable/src/ActionsObservable.js
  1:1  error  Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

/Users/kyle/code/src/github.com/blesh/redux-observable/src/index.js
  1:1  error  Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

/Users/kyle/code/src/github.com/blesh/redux-observable/src/reduxObservable.js
  1:1  error  Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

✖ 3 problems (3 errors, 0 warnings)

By setting the parserOptions to have sourceType: 'module', the above errors are fixed. This
doesn't take us all the way because it's not having a good time with the ES7 (proposed) bind operator.
/Users/kyle/code/src/github.com/blesh/redux-observable/src/ActionsObservable.js
  17:16  error  Parsing error: Unexpected token :

I was hoping to figure out how to get eslint to recognize ::. You'd think that using babel-eslint as
the parser (as is done here) would resolve this. Nope.
Anyways, eager to use the project to get rid of the rx redux mashup we've been working with for a while.
Thanks!

This is totally passing locally on my machine and @blesh, but if I blow away node_modules and then install again, it fails just as you describe. Since eslint had a release today and we're only locking major versions, you picked up 2.10.0 instead of our local 2.9.0 and it appears to be having numerous issues with babel-related code https://github.com/eslint/eslint/issues/6158
I'm going to lock us on 2.9.0 until https://github.com/eslint/eslint/pull/6160 lands.

Okiedoke. Merged. Feel free to rechecking from master and remember to blow away the old eslint (or all node_modules).
Thanks for letting us know!

Cool, thanks @jayphelps.


A delimiter cannot be Nothing or an empty String.

System Information (please complete the following information):

Model Builder Version:  <IP_ADDRESS>6001
Visual Studio Version 16.9.2

Describe the bug

In the ML.NET Model Builder, I selected SQL Server as a data source.
I picked a table from my SQL Server database.
An exception is then thrown.

2021-03-16 23:01:17.3237 DEBUG Set log file path to C:\Users\phill\AppData\Local\Temp\MLVSTools\logs\70cbb47c-a22c-4bf2-a525-b3016bf002fd.txt (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2021-03-16 23:11:26.5269 TRACE Disposing AutoMLService Client (Microsoft.ML.ModelBuilder.AutoMLServiceFactory+AutoMLServiceProxy.Dispose)
2021-03-16 23:11:26.5269 DEBUG A delimiter cannot be Nothing or an empty String.
Parameter name: Delimiters
at Microsoft.VisualBasic.FileIO.TextFieldParser.ValidateDelimiters(String[] delimiterArray)
at Microsoft.VisualBasic.FileIO.TextFieldParser.set_Delimiters(String[] value)
at Microsoft.ML.ModelBuilder.AutoMLService.DataProcessingEngine.GetRichDataTypes(String fileName, Boolean hasHeader, String[] delimiter, List1 columnNames, Char& decimalSeparator) in /_/src/Microsoft.ML.ModelBuilder.AutoMLService/DataProcessingEngine.cs:line 60    at Microsoft.ML.ModelBuilder.AutoMLService.DataProcessingEngine.GetFileAttributes(String fileName) in /_/src/Microsoft.ML.ModelBuilder.AutoMLService/DataProcessingEngine.cs:line 35    at Microsoft.ML.ModelBuilder.AutoMLEngine.GetFileAttributesAsync(String fileName) in /_/src/Microsoft.ML.ModelBuilder.AutoMLService/AutoMLEngineService/AutoMLEngine.cs:line 195 (Microsoft.ML.ModelBuilder.Utils.Logger.Debug) 2021-03-16 23:11:44.6301 TRACE Disposing AutoMLService Client (Microsoft.ML.ModelBuilder.AutoMLServiceFactory+AutoMLServiceProxy.Dispose) 2021-03-16 23:11:57.2321 TRACE Disposing AutoMLService Client (Microsoft.ML.ModelBuilder.AutoMLServiceFactory+AutoMLServiceProxy.Dispose) 2021-03-16 23:11:57.2321 DEBUG A delimiter cannot be Nothing or an empty String. Parameter name: Delimiters    at Microsoft.VisualBasic.FileIO.TextFieldParser.ValidateDelimiters(String[] delimiterArray)    at Microsoft.VisualBasic.FileIO.TextFieldParser.set_Delimiters(String[] value)    at Microsoft.ML.ModelBuilder.AutoMLService.DataProcessingEngine.GetRichDataTypes(String fileName, Boolean hasHeader, String[] delimiter, List1 columnNames, Char& decimalSeparator) in //src/Microsoft.ML.ModelBuilder.AutoMLService/DataProcessingEngine.cs:line 60
at Microsoft.ML.ModelBuilder.AutoMLService.DataProcessingEngine.GetFileAttributes(String fileName) in //src/Microsoft.ML.ModelBuilder.AutoMLService/DataProcessingEngine.cs:line 35
at Microsoft.ML.ModelBuilder.AutoMLEngine.GetFileAttributesAsync(String fileName) in /_/src/Microsoft.ML.ModelBuilder.AutoMLService/AutoMLEngineService/AutoMLEngine.cs:line 195 (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)
2021-03-16 23:12:19.0873 DEBUG Open Log FileC:\Users\phill\AppData\Local\Temp\MLVSTools\logs\70cbb47c-a22c-4bf2-a525-b3016bf002fd.txt (Microsoft.ML.ModelBuilder.Utils.Logger.Debug)

@phillipmunn sorry you've run into this problem. My guess is your SQL data contains commas?
When you use a SQL datasource we read in a portion of your data (200 lines) and save it to a .csv file. We then use that .csv file for column type prediction, getting sample data, and the data preview. If your SQL data has commas, it could be that our parser is reading it incorrectly.
Can you get me a copy of that .csv file? Open Model Builder and open your SQL file again, and pick the table. Then go to the %temp% folder. There should be a recently created file .csv.  Can you open it and see if it looks correct? If you don't have sensitive data can you share it with me? Thanks!

Hi @phillipmunn! Any update here? Would love to see the generated .cvs file to help you out with this problem. Thanks!

Hello @beccamc
The information is sensitive - it's actually Invoice data, but so I can hopefully make the product better I've included a single row from the CSV file and manually redacted anything which I believe I cannot share.
One of the columns in our SQL database is named "SerializedObject" and is actually XML data stored in a text column.
It will therefore include comma's and other symbols which is where I suspect the issue is.
Appologies for not being able to share more of the data - but perhaps this is enough information you need to see if you can improve the parser?
24018c95-914a-409e-9897-5f05e57538b1.zip

@phillipmunn Yes I think you're exactly right! The problem is likely the XML data. In this sample it appears Model Builder can load it, but if there are commas in other rows it would break. Are you able to try this again without the "SeralizedObject" column?

Did this work without the SerlizedObject column?

@beccamc yes, excluding the column containing XML data (stored as VARCHAR) within the database solves the issue.

Great! Is that an acceptable solution?

Yes thanks.


Warning configuration DSL

Hi! I have defined this little DSL for warnings configuration and thought of sharing it. It's pretty hard to remember all available filters, their short names, which actions have configurable verbosity, etc. and then piece them correctly together into a single string. With a DSL it's much easier to discover what's available via auto-complete, see full names and have a clear, readable configuration definition.
sealed trait WarningAction

case object silent extends WarningAction
case object error extends WarningAction

sealed trait WarningActionWithVerbosity extends WarningAction { action =>

  def summary: WarningAction = new WarningAction {
    override def toString = s"${action}-summary"
  }

  def verbose: WarningAction = new WarningAction {
    override def toString = s"${action}-verbose"
  }

}

case object warning extends WarningActionWithVerbosity
case object info extends WarningActionWithVerbosity

sealed class WarningFilter(val asString: String) {
  override def toString = asString

  def &(that: WarningFilter): WarningFilter = new WarningFilter(
    Seq(this.asString, that.asString).mkString("&")
  )

}

case object any extends WarningFilter("any")
case class cat(cat: String) extends WarningFilter(s"cat=${cat}")
case class msg(regex: String) extends WarningFilter(s"msg=${regex}")
case class src(regex: String) extends WarningFilter(s"src=${regex}")

case class origin(segments: String*)
    extends WarningFilter(s"origin=${segments.mkString(raw"\.")}")

case class WarningConfig(val rules: (WarningFilter, WarningAction)*) {

  override def toString = {
    val conf = rules.toSeq
      .map { case (filter, action) => Seq(filter, action).mkString(":") }
      .mkString(",")
    s"-Wconf:${conf}"
  }

  def asScalacOption =
    ScalacOption(
      option = this.toString,
      isSupported = {
        case ScalaVersion(2, 12, x) => x >= 13
        case ScalaVersion(2, 13, x) => x >= 2
        case _                      => false
      },
    )

}

Example usage:
WarningConfig(
  src("src_managed/.*") -> silent,
  cat("unused-imports") -> warning,
  (cat("deprecation") & origin("scala", ".*")) -> error,
  cat("deprecation") -> warning.verbose,
  cat("unused") -> warning.summary,
  any -> error,
)

is transformed into -Wconf:src=src_managed/.*:silent,cat=unused-imports:warning,cat=deprecation&origin=scala\..*:error,cat=deprecation:warning-verbose,cat=unused:warning-summary,any:error or with line breaks for readability:
-Wconf:
src=src_managed/.*:silent,
cat=unused-imports:warning,
cat=deprecation&origin=scala\..*:error,
cat=deprecation:warning-verbose,
cat=unused:warning-summary,
any:error

Would you be open to a pull request adding such DSL here? Details of the design are open for discussion, of course.

@lrytz FYI


Improvement for k8s.io/docs/tasks/administer-cluster/encrypt-data/

I don't immediately understand what the encryption shall serve for:

protect against users of the K8s API service?
protect against access of secrets from other Pods?

What happens is a Pod is to be restarted? Can the pod read the secrets as required?
I suggest showing some scenarios or a risk matrix. Then, shortly, show why secrets at rest are a mitigation for it.

This issue is part support and part feature request
Encrypting secrets in etcd at-rest is a part of the security good practice guide: https://kubernetes.io/docs/concepts/security/security-checklist/ so I don't think we need a risk matrix as it's already stated to encrypt secrets at-rest for good security practice -- if you feel otherwise, feel free to reopen this issue with /reopen in a comment
Pods will still be able to read secrets as required.
/kind support
/close


Use react-native-community/react-native-netinfo

NetInfo is completely removed from the code module of react-native -> https://github.com/react-native-community/releases/blob/master/CHANGELOG.md#removed
casing the component to fail to load

PR is to import NetInfo from the community package -> https://github.com/react-native-community/react-native-netinfo

👍 this need to be merged, soon please. i think a lot of people having this issue already, Thanks!

@kfiroo thank you for your hard work. I can imagine how busy you must be. @nawartamawi thank you for this PR. If we could get this merged I'd be eternally greateful.


Test ERROR

https://github.com/stevengogogo/FindSteadyStates.jl/runs/2216694202?check_suite_focus=true

I dropped Julia v1.5 and the test passed.


Filter rankings by country

Add filter by the country option on rankings pages

Hi, Can you assign this to me?


Reclaim One-Pager

One-pager describing the functionality of reclaimPolicy in Crossplane.
Signed-off-by: hasheddan<EMAIL_ADDRESS>
Description of your changes
Fixes #550
Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[x] Updated any relevant documentation, examples, or release notes.
[x] Updated the RBAC permissions in clusterrole.yaml to include any new types.

@hasheddan This LGTM so far as a summary of the status quo. I'd like the one pager to go further and make a recommendation on how reclaim policies should work in Crossplane. This could be maintaining the status quo, more closely mirroring the PVC semantics, or some unknown third option.
It may be helpful to start by framing the problem(s) we are trying to solve via a reclaim policy.

Allowing cluster operators to remove an external resource from Crossplane management without removing the external resource itself.
Allowing developers to relinquish a managed resource for re-use by another developer.
Allowing developers to relinquish a managed resource for manual cleanup/reclamation by cluster operators.

Note that these problems should not be taken as gospel; there are subtleties to be worked through. For example in many cases there is little value in "reusing" a managed resource - why reuse a database instance when you could delete it and use a new one? I could also see it being confusing that deleting a managed resource orphans the external resource from Crossplane representation.

Thanks @negz @ichekrygin! Do we need any more reviewers before merging?

We do not - I forgot we haven’t given you merge rights just yet.


Upgraded to latest lsp-0.13 alpha for testing

@mholo65 This upgrade went pretty well things seem to working..  I dunno if might help with your other issue.

@david-driscoll I tried the alpha bits yesterday, with no success. Actually it didn’t even initialize using the C# LSP Client (version 0.12.1). Saw another exception too bubble up regarding converting ”empty json rpc response” to a ”initialized response”.. Or something like that. Can look again with this PR instead.

Seeing this with C# LSP Client when updating Omnisharp to use LSP libs 0.13.0-alpha*
Finding descriptor for initialized
Starting: Routing Notification initialized
Converting params for Notification initialized to OmniSharp.Extensions.LanguageServer.Protocol.Models.InitializedParams
Failed to handle request initialized - System.ArgumentException: Object of type 'OmniSharp.Extensions.JsonRpc.EmptyRequest' cannot be converted to type 'OmniSharp.Extensions.LanguageServer.Protocol.Models.InitializedParams'.
   at System.RuntimeType.TryChangeType(Object value, Binder binder, CultureInfo culture, Boolean needsSpecialCast)
   at System.Reflection.MethodBase.CheckArguments(Object[] parameters, Binder binder, BindingFlags invokeAttr, CultureInfo culture, Signature sig)
   at System.Reflection.RuntimeMethodInfo.InvokeArgumentsCheck(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at OmniSharp.Extensions.JsonRpc.RequestRouterBase`1.HandleNotification(IMediator mediator, IHandlerDescriptor handler, Object params, CancellationToken token)
   at OmniSharp.Extensions.JsonRpc.RequestRouterBase`1.<RouteNotification>d__5.MoveNext()

Initialized params is empty, so don't know what happened here. https://microsoft.github.io/language-server-protocol/specification#initialized
Will look into this, and also try to fix the issues seen in #1505 and #1525 as these are not fixed yet with updating LSP libs.

Fixes #1505
Fixes #1525

Eagerly awaiting this merge! Was also running into the didChange handler failures.

How's this coming along? Any blockers?

Surprised this wasn't included in the last release :(

I chatted with @mholo65 yesterday and we updated the test from #1583 from Linux since it's unstable on Azure DevOps with the LSP changes in. We can investigate that separately next and it shouldn't hold up this PR, the test still runs on Mac and Windows for now.
Should be good to go now.


Create documentations for Usage

prepare documentations for usage of this repo as README.md

add this procedure
https://github.com/NervesJP/nerves-devcontainer/issues/4#issuecomment-732794358


fix: update all deps and tests

BREAKING CHANGES: dropped node v6 and ember < 3.4

looks like the travis config might need updating to use yarn. That's my guess.

Looks like an issue with mocha.

:/

Might be worthwhile to move back to qunit, since ember-mocha is 4 major versions behind.
https://github.com/emberjs/ember-mocha/pull/334

@knownasilya Can I help with this?

I think we need to convert to qunit, if you have time feel free to submit agains this PR.

@knownasilya ERROR: Uncaught Error: Compile Error: state is not a helper at any idea what this might be about?

I have bandwidth to fix it now. What is going on with this?


Negative rotate not working

Hi,
Thanks for this plugin but It seems that classes with "-" prefix for rotate is not working.
It is working for you ?

Hello @LouisCuvelier, can you please share your config?

Here's the extract concerned :
module.exports = {
  theme: {
    rotate: {
      "90": "90deg",
      "180": "180deg",
      "225": "225deg",
      "270": "270deg"
    },
  },
  variants: {
    borderWidth: ["responsive", "hover", "focus", "active", "last", "first"],
    borderRadius: ["responsive", "hover", "focus", "active", "last", "first"],
    cursor: ["responsive"],
    backgroundColor: ["even", "odd"],
    margin: ["last", "responsive", "hover", "focus"],
    padding: ["responsive", "hover", "focus", "active"],
    textColor: ["group-hover", "hover", "focus", "responsive", "active"]
  },
  plugins: [
    require("tailwindcss-aspect-ratio")(),
    require("tailwindcss-transforms")()
  ]
};

@LouisCuvelier I don't see any negative rotate value in that config. Try the following:
module.exports = {
  theme: {
    rotate: {
      "90": "90deg",
      "180": "180deg",
      "225": "225deg",
      "270": "270deg",
      "-90": "-90deg",
      "-180": "-180deg",
      "-225": "-225deg",
      "-270": "-270deg"
    },
  },
  variants: {
    borderWidth: ["responsive", "hover", "focus", "active", "last", "first"],
    borderRadius: ["responsive", "hover", "focus", "active", "last", "first"],
    cursor: ["responsive"],
    backgroundColor: ["even", "odd"],
    margin: ["last", "responsive", "hover", "focus"],
    padding: ["responsive", "hover", "focus", "active"],
    textColor: ["group-hover", "hover", "focus", "responsive", "active"]
  },
  plugins: [
    require("tailwindcss-aspect-ratio")(),
    require("tailwindcss-transforms")()
  ]
};

Oh ok, I thinked it generates positive and negative values without providing negative keys.
Thanks for your help 🙂

I plan on improving the documentation at some point, but yeah, it works like Tailwind's margin in that regard. :)


Traffic run

PR Description 📜
Traffic Run is an engaging and addictive mobile game that tests your reflexes and strategic thinking as you navigate through bustling city streets filled with traffic!
Fixes #629

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Click Here To See the Demo Of The Project!

Thank you soo much for contributing to our repository 💗

Thank you @jshobhit11 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@jshobhit11 LGTM

Thank you  @jshobhit11 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


NO_ERROR; received from peer

What version of Go are you using (go version)?
go version go1.15.14 linux/amd64
What operating system and processor architecture are you using (go env)?
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/root/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/root/go"
GOPRIVATE=""
GOPROXY="https://goproxy.cn,direct"
GOROOT="/usr/lib/golang"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build836394113=/tmp/go-build -gno-record-gcc-switches"
What did you do?
when I post with 500 goroutine use http2，it have this error accidental.
What did you expect to see?
I expect to see post success.
What did you see instead?
NO_ERROR; received from peer

Go 1.15 is not longer being actively developed. If this issue occurs with version 1.16 and above, please fill out the issue template and could you provide an example of the code that produced the error, preferably as a Go playground link?

Please always send plain text as plain text, not as an image.  Images hard to read and hard to cut and paste from.  Thanks.

thanks


[Javadoc] The search bar takes the user to an incorrect url, resulting in 404 error

Steps to replicate:

Open https://odftoolkit.org/api/odfdom in the browser
Search for OdfElement in the Search bar
Click the search result for OdfElement
Expected result: The user is taken to the Javadoc page for the selected item
Actual result: The user is taken to https://odftoolkit.org/api/odfdom/undefined/org/odftoolkit/odfdom/pkg/OdfElement.html, and sees 404 Not Found on the page.

The user is able to navigate to the page by removing the undefined/ from the url.

Thanks for the pointer, others got this working with the help of the following option in the java doc maven plugin configuration
<additionalJOption>--no-module-directories</additionalJOption>
https://stackoverflow.com/a/52603413/7919834

Thanks for the quick response, but I was referring to the live website at https://odftoolkit.org/api/odfdom rather than a local build.

Yes, indeed, I have not fixed it, yet. Just pointed out the problem. But will do the patch today and ask Michael to review and upload the JavaDoc to the site. Thanks again. :-)

I found out that the problem is just a JDK 11 bug currently: https://bugs.openjdk.java.net/browse/JDK-8244171
referenced from https://bugs.openjdk.java.net/browse/JDK-8215291
Indeed, when building with LTS JDK 17 (Linux) the JavaDoc issue does no longer occur.
I will fix it for the latest version: https://tdf.github.io/odftoolkit/javadoc.html
@mistmist Could you please rebuild the 0.9.0 and 0.10.0 release java doc and copy it to odftoolkit.org?

fixed by commit c844b27dd9c08be2963acfe22c2d4af258225d24 and copied to odftoolkit.org


lorri: 1.7.0 -> 1.7.1

Motivated by transition to Rust 1.8.0 and issues with the old time crate
Description of changes
Updates lorri to 1.7.1, which is comprised of an update to time
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@GrahamcOfBorg build lorri.tests


CameraRoll returns photos if assetType is equal to "Videos"

[ x] Review the documentation: https://facebook.github.io/react-native
[ x] Search for existing issues: https://github.com/facebook/react-native/issues
[ x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
React Native Environment Info:
System:
OS: macOS High Sierra 10.13.6
CPU: (4) x64 Intel(R) Core(TM) i5-4288U CPU @ 2.60GHz
Memory: 29.58 MB / 8.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 8.12.0 - ~/.nvm/versions/node/v8.12.0/bin/node
Yarn: 1.12.3 - /usr/local/bin/yarn
npm: 6.4.1 - ~/.nvm/versions/node/v8.12.0/bin/npm
SDKs:
iOS SDK:
Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
Android SDK:
API Levels: 23, 25, 26, 27, 28
Build Tools: 27.0.3, 28.0.3
System Images: android-27 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.2 AI-181.55<IP_ADDRESS>56338
Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
npmPackages:
react: 16.6.1 => 16.6.1
react-native: 0.57.5 => 0.57.5
npmGlobalPackages:
react-native-cli: 2.0.1
Description
I receive photos in iOS app, despite the fact that I set assetType: 'Videos'
Reproducible Demo
const defaultParams: GetPhotosParamType = {
    first: 6,
    groupTypes: 'All',
    after: undefined,
};
Promise.all([
    CameraRoll.getPhotos({
    ...defaultParams,
    assetType: 'Photos',
    }),
    CameraRoll.getPhotos({
    ...defaultParams,
    assetType: 'Videos',
    })
]).then(results => {
    console.warn(results[0]);
    console.warn(results[1]);
    console.warn(results[0].edges[0].node.image.uri === results[1].edges[0].node.image.uri);
});

@indapublic have you been able to find a fix, currently experiencing same issue.

@linux08 As I said before, I moved to https://github.com/pentarex/react-native-gallery-manager

This issue has been moved to react-native-community/react-native-cameraroll#15.


sort method doesn't work on Node.js 11.0.0

After upgrading to Node.js 11 function
R.sort(R.gt, ["Applications/B/1.0","Applications/A/2.0"]) returns back
["Applications/B/1.0","Applications/A/2.0"] without applying a sorting.

If something like that ever worked, it's mostly a coincidence.  R.sort requires a comparator, a function that returns a negative number, zero, or a positive number when the first number is, respectively, less than, equal to, or greater than the second one.  It's really only a thin gloss on Array.prototype.sort, simply cloning before sorting to preserve immutability.
R.gt returns a boolean, not a number.  Because of the way Booleans are translated to numbers, this will end up with a sort of reverse sort:
R.sort(R.gt, [8, 6, 7, 5, 3, 0, 9]) //=>[0, 3, 5, 6, 7, 8, 9]
R.sort(R.lt, [8, 6, 7, 5, 3, 0, 9]) //=>[9, 8, 7, 6, 5, 3, 0]

But I would not want to count on this for anything essential.
If sorting has changed from earlier Node versions, I think it's that sort is now stable.  But that shouldn't matter at all if your data are strings.
You could write R.sort(R.comparator(R.gt), yourData) for code that should always work.

Thanks! Yes it was really working up to Node 10.x.
Indeed make sense why actually it shouldn't work ;)

Again, this is because of how booleans are cast to numbers.
Think about a bubblesort function:   We repeatedly compare the first value with each of the subsequent ones, swapping when the other one is smaller than the first.  By the time we get through the whole list, we have the smallest one in the first position.  Then we do it again starting with the second one.  Then the third...
So if we try this:
bubblesort((a, b) => a < b, [8, 6, 7, 5, 3, 0, 9])

the first thing our bubblesort would do is to call (a, b) => a < b with the values 8 and 6.  That returns false.  But since bubblesort needs to use this as a number, it casts it to 0, which bubblesort treats as meaning that neither a nor b is smaller than the other.  So in this case, we would perform no swap.  We would proceed this way with 8 and 7, with 8 and 5, with 8 and 3, and with 8 and 0, making no swaps.  When we hit 8 and 9, (a, b) => a < b is true.  That gets cast to 1, which is interpreted as meaning that the second number is larger, and so it would swap them, leading to [9, 6, 7, 5, 3, 0, 8], and we would proceed to compare the second value with each of the others, until we reach [9, 8, 7, 5, 3, 0, 6].  And so on.
Now you could replace (a, b) => a < b with R.lt and have the same effect.
You could replace bubblesort with other sorting algorithms; the behavior might vary a bit, but it's quite possible that it would have this somewhat strange behavior.  But again, this is mostly a coincidence, based upon how JS converts booleans to numbers.  It's not something I would ever want to count on.
And it looks as though the latest Node has demonstrated why.


Addresses security vulnerability in cryptography<2.3

Closes #1839

Coverage decreased (-0.6%) to 91.859% when pulling 8bdcc6244d118ab58d8eb50ceb0a15dfbeeecdf6 on justineyster:fix/crypto_vulnerability into 57f9691a52245ffd9d7c0317e90953d054070c65 on spulec:master.


broken with Symbol keys

HAMT does not work correctly with keys of type Symbol. Here's a test case:
julia> VERSION
v"1.10.3"

(@v1.10) pkg> st HashArrayMappedTries
Status `~/.julia/environments/v1.10/Project.toml`
  [076d061b] HashArrayMappedTries v0.2.0

julia> using HashArrayMappedTries

julia> hamt = HAMT{Symbol, Nothing}();

julia> for sym in [:a, :b, :c, :d, :e, :f]; hamt = insert(hamt, sym, nothing); end

julia> hamt[:a]
ERROR: KeyError: key :a not found
Stacktrace:
 [1] getindex(trie::HAMT{Symbol, Nothing}, key::Symbol)
   @ HashArrayMappedTries ~/.julia/packages/HashArrayMappedTries/CozZ8/src/HashArrayMappedTries.jl:182
 [2] top-level scope
   @ REPL[6]:1

This seems to be caused by the code assuming hash(key) == hash(key, UInt(0)), which is not true for Symbols.

I think I fixed this upstream in https://github.com/JuliaLang/julia/commit/9ea29d9b8f41509ea2609ce012cea69dfc4285e8
If you have time I would appreciate a PR that does the same here.


New blog post: A detailed walkthrough the installation of the metal3-dev-env

Hello,
As shown in the summary this blog post is about:
"In this post a deep dive into the metal3-dev-env scripts were shown. It has been deeply detailed the process of creating a Metal³ emulated environment from a set of virtual machines (VMs) to manage as if they were bare metal hosts.
After this post, the reader should have acquired a basic understanding of all the pieces involved in the Metal³ project. Also, and more important, how these scripts can be adapted to your specific needs. Remember that this can be achieved in multiple ways: replacing values in the global variables, replacing Ansible default variables or even modifying playbooks or the scripts themselves."
Several videos come along with the blog post detailed explanation. They have been uploaded to my Youtube channel expecting to be moved to the official Metal³ Youtube channel.
Regards,
Preview at: https://deploy-preview-135--metal3.netlify.com/blog/2020/02/04/metal3-dev-env-install-deep-dive.html

Hi team,
In the videos, I have used a diagram from @maelk presentation at Nordics meetup and a network diagram taken from @fmuyassarov. Let me know if there are any problems using them.
I would like that you or any of your team review the content and receive feedback. cc/ @codificat @stbenjam @maelk
Rendered blog post can be found at https://deploy-preview-135--metal3.netlify.com/blog/2020/02/04/metal3-dev-env-install-deep-dive.html

/cc @fmuyassarov Can you please have a look too ?

Well done @alosadagrande ! I think it can also be included in the book (or some parts IMO) and maybe we should also add the reference to this blog in thetry-it.md because it explains the environment deeply and clearly.

Thanks for reviewing @fmuyassarov. Feel free to add a reference to the try-it tutorial, hopefully this blog post will be merged this week.
A couple of questions:

What is the book of metal³?
Would it be possible to move the Metal³ videos created in my personal channel to the official Metal³ youtube channel? IMO they should be there. I am also planning to add more videos, similar to the ones we shown at FOSDEM last weekend, but this time along with a blog post explaining the steps to create a cluster and add/remove workers from it.

Regards,

Thanks for reviewing @fmuyassarov. Feel free to add a reference in the try-it tutorial, hopefully this blog post will be merged this week.
A couple of questions:

What is the book of metal³?
Would it be possible to move the Metal³ videos created in my personal channel to the official Metal³ youtube channel? IMO they should be there. I am also planning to add more videos, similar to the ones we shown at FOSDEM last weekend, but this time along with a blog post explaining the steps to create a cluster and add/remove workers from it.

Regards,

First regarding the videos, I think it is better to have it in official Metal³ YouTube channel, but maybe @maelk can give more info on that?
For the Metal³ book, there was an idea to create a book for both users/developers of Metal³ that describes CAPBM, Metal³ dev-env...etc. We have started writing some docs (.md files) & some diagrams and it is still in progress. And for now we are collecting then in  /docs folder. Later, the idea is to merge all of those .md  files.

Thanks for clarifying @fmuyassarov. Yes, sure, feel free as well to include the content of the blog post you consider into the "book" or let me know if I can help with that (I can't see any issues opened).

@stbenjam @russellb @hardys  or @maelk content has been reviewed by a couple of members already. Do you think the blog post can be published?

looks good to me ! amazing work

Can you /lgtm if you're ok?

/approve
/lgtm
Thanks!  Some of this may be good documentation in to the metal3-dev-env repository.


Installing Problem

I like the demo of your website please help i want to install this on my vps

Hello, shure i will update this repo with documentation today :)

I have edited the README with a guide.


Throttle rate of output messages

Building a large project with ninja output going to an emacs compilation buffer is painful b/c emacs doesn't do so well with 10k-line-buffers.
IWBN to have a rate-limit on progress messages, such as "don't emit a progress message more often than once per  seconds".  Could be done with an env var or a cmd-line option to ninja (I weakly prefer env var).
WDYT, worth writing a patch for?

I've been out of the ninja game for years so unsubscribing from this.  Feel free to close if no longer useful, or @ me if you want me to see a followup.

I recently started using cmake with ninja in emacs and encountered this same problem. Built-in support for this would be much nicer, but I took the approach of creating a quick-and-dirty "throttling" script in python here: https://gist.github.com/bradneuman/3f2bcb3b3a31f00129f69fead4d94c5f
YMMV and you may have to change the (very simple) regex I used there, but for now it did the trick for me. It just throttles to one-per-second for lines matching a certain regex and prints everything else

Here's one way that this could be implemented: https://github.com/ninja-build/ninja/pull/1631
(Personally, I think librari-fying ninja is a better approach, so that the lib can be loaded by an application that offers customized output as desired)


Problem with check URLs

I am getting a recurring error upon pull request at the check broken urls step. This is affecting both course repos I am currently working on:
https://github.com/griffithlab/CIVIC_SVI_Course/
https://github.com/griffithlab/pVACtools_Intro_Course/
Examples of workflow run errors here:
https://github.com/griffithlab/CIVIC_SVI_Course/actions/runs/5092245413/jobs/9153355914
https://github.com/griffithlab/pVACtools_Intro_Course/actions/runs/5092194299/jobs/9153237036
I don't think there are any problematic urls...

There's another weird URL check: https://github.com/jhudsl/Ethical_Data_Handling_for_Cancer_Research/actions/runs/5535825669/jobs/10102656082
So apparently the bug fix didn't fix everything. @howardbaek Do you want to add this to your list? Would be good for getting more familiar with OTTR.


Update DrawPrimitivesTest.cpp

THIS PROJECT IS IN DEVELOPMENT MODE. Any pull requests should merge to branch dev, otherwise will be rejected immediately.
Describe your changes
fix #137 and try to "explain" the behavior of setLineWidth() om DrawNode object
Issue ticket number and link
fix #137
Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[x] I have checked readme and add important infos to this PR (if it needed).
[] An improved cpp-test/lua-test is not needed (explain why not, thanks).

only a suggestion: how about changing it to draw a circle with a thickness of 1 a little bit of improved english in documentations :)


abandoned/outdated k8s manifests

per the readme, i ran kubectl create -f ./k8s after git cloning the repo.. the result:
NAMESPACE                     NAME                                   READY     STATUS             RESTARTS   AGE       IP              NODE
default                       alertmanager-cbf7cf875-qrfzx           0/1       ImagePullBackOff   0          4m        <IP_ADDRESS>      k8lab1bs
default                       configs-d9474b5bd-bvf2p                0/1       ImagePullBackOff   0          4m        <IP_ADDRESS>      k8lab1bs
default                       configs-db-75c6b4df96-n46l6            1/1       Running            0          4m        <IP_ADDRESS>      k8lab3bs
default                       consul-744475fd58-mw6lz                1/1       Running            0          4m        <IP_ADDRESS>       k8lab2bs
default                       distributor-885c5c85c-csd98            0/1       ImagePullBackOff   0          4m        <IP_ADDRESS>      k8lab1bs
default                       dynamodb-868489b88c-tbrgz              1/1       Running            0          4m        <IP_ADDRESS>      k8lab2bs
default                       ingester-84fc6c7947-vb2dv              0/1       ImagePullBackOff   0          4m        <IP_ADDRESS>      k8lab1bs
default                       memcached-cf8545f6d-rqdvd              1/1       Running            0          4m        <IP_ADDRESS>      k8lab2bs
default                       nginx-55b9f744d5-mhjml                 0/1       CrashLoopBackOff   4          4m        <IP_ADDRESS>      k8lab2bs
default                       querier-6d484876c8-8v2fc               0/1       ErrImagePull       0          4m        <IP_ADDRESS>      k8lab1bs
default                       retrieval-6d849ccb59-slplc             1/1       Running            0          4m        <IP_ADDRESS>      k8lab3bs
default                       ruler-795f8c59c7-xh55m                 0/1       ImagePullBackOff   0          4m        <IP_ADDRESS>      k8lab2bs
default                       s3-79655d5455-9q5xl                    1/1       Running            0          4m        <IP_ADDRESS>      k8lab1bs
default                       table-manager-797c5df74b-snwc5         0/1       ImagePullBackOff   0          4m        <IP_ADDRESS>      k8lab3bs

seems most of these manifests weren't updated in a year or two, they have gone out of date resulting in a lot of errors even pulling the images, and one of them, the nginx container has the following error:
$ kubectl logs nginx-55b9f744d5-mhjml
2018/07/31 09:59:27 [emerg] 1#1: open() "/etc/nginx/nginx.pid" failed (30: Read-only file system)
nginx: [emerg] open() "/etc/nginx/nginx.pid" failed (30: Read-only file system)

seems these have been abandoned ? i'm using k8s v1.11.1 and pulling from the master branch of weaveworks/cortex

Did you build the images?

ok so i tried to build this myself and ran into this now:
time docker run --rm --tty -i \
        -v /home/username/k/cortex/.cache:/go/cache \
        -v /home/username/k/cortex/.pkg:/go/pkg \
        -v /home/username/k/cortex:/go/src/github.com/weaveworks/cortex \
        quay.io/weaveworks/cortex-build-image pkg/ingester/client/cortex.pb.go;
make: Entering directory '/go/src/github.com/weaveworks/cortex'
make: *** No rule to make target 'pkg/ingester/client/cortex.pb.go'.  Stop.
make: Leaving directory '/go/src/github.com/weaveworks/cortex'

real    0m0.422s
user    0m0.000s
sys     0m0.016s
make: *** [pkg/ingester/client/cortex.pb.go] Error 2

The first thing the Makefile should do is build the build image.
Can you post the full output of make please?  Try make clean first.

The point where your build fails is:
...
Successfully built 46e9db8f3f77
docker tag quay.io/weaveworks/cortex-build-image quay.io/weaveworks/cortex-build-image:master-6f0118a
touch build-image/.uptodate
time docker run --rm --tty -i \
        -v /home/username/k/cortex/.cache:/go/cache \
        -v /home/username/k/cortex/.pkg:/go/pkg \
        -v /home/username/k/cortex:/go/src/github.com/weaveworks/cortex \
        quay.io/weaveworks/cortex-build-image pkg/ingester/client/cortex.pb.go;
make: Entering directory '/go/src/github.com/weaveworks/cortex'
make: *** No rule to make target 'pkg/ingester/client/cortex.pb.go'.  Stop.

when I run it, it executes the protobufs compiler:
...

I don't understand why the error is "No rule to make" - the rule %.pb.go: is on line 114.
Can you give some more details of your environment - Linux version, Docker version, etc.?

on the docker-client side (where i am running make), i am using CentOS 7.5 under WSL (Windows 10 Enterprise, Version 1803), on the docker-server side, it's also CentOS 7.5 on bare-metal.  Here's the output of docker version:
Client:
 Version:         1.13.1
 API version:     1.26
 Package version: docker-1.13.1-68.gitdded712.el7.centos.x86_64
 Go version:      go1.9.4
 Git commit:      dded712/1.13.1
 Built:           Tue Jul 17 18:34:48 2018
 OS/Arch:         linux/amd64

Server:
 Version:         1.13.1
 API version:     1.26 (minimum version 1.12)
 Package version: docker-1.13.1-68.gitdded712.el7.centos.x86_64
 Go version:      go1.9.4
 Git commit:      dded712/1.13.1
 Built:           Tue Jul 17 18:34:48 2018
 OS/Arch:         linux/amd64
 Experimental:    false

The build process assumes that -v will mount files from where make is running to where Docker is running.  That assumption probably falls down if you run them on two different machines.

makes sense, to give a try what you mentioned, i moved to build the images onto a system where the docker client and server is the same (so no longer WSL).  this succeeded fine, so it was using docker client on a system different than where the docker service ran that caused the issue as you said.  as a note, i only use a remote docker service because the kernel under wsl doesn't have enough syscalls yet implemented to actually have a docker server running there :-/
so that solves the build issue component of this issue, and coupled with my one-liner from https://github.com/weaveworks/cortex/issues/911#issuecomment-409880324 this case can be closed


A very long logging outputs scroll in the human_rl notebook

The run the loop section in the human_rl notebook produces a very large piece of output, making the rest of the notebook difficult to reach due to the scrolling.
Either discarding the outputs or setting the n_episodes=10 would resolve the issue (it's in the second line of the cell below the section title).

fixed by adding IPython.display clear_output call before the last print. Pushing, merging, and closing the issue. Changes will be reflected in the book after 30 mins.


[MB-3599] Home screen design

Description
Adds layout and styling for home screen with stub data
Reviewer Notes

For now, I have placed the screen behind the hhg feature flag and in the route /home-2

Setup
make storybook
It is under Home
To access in app
make server_run
make client_run
Log in
Visit route /home-2
Code Review Verification Steps

[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots

Messages

:book:
:link: MB-3599

  Generated by :no_entry_sign: dangerJS against e0b8d10335844ef68e1eb2da2116e16e8d9413a9

@mariaclaratgolfo Made those changes, the Edit link is disabled just to show that the way we structured the component in the code can support disabling it. It won't be disabled once we start integrating it into the real workflow! Yup, all the individual components are in storybook. Currently, all of them are on one page under Home and each individual component are under Helper, Contact, ShipmentList, Step and DocsUploaded
@suzubara Made most of the changes, just had a question on one of the proposed changes


keys do not work reliably from command line

If you run MFEM example 1 and then try to visualize the solution like so:
glvis -m refined.mesh -g sol.gf -k cS

The saved figure does not have the colorbar, as you would expect from the c key.
If you run it and enter the same keys by hand, the saved figure does have the colorbar.
I would like to use GLVis in scripts to automatically generate pictures with colorbars but so far am unable to do so.

You should be able to use a GLVis script -- see https://glvis.org/options-and-use/#glvis-scripts.
The script commands are not documented but they are easy to see in this function:
https://github.com/GLVis/glvis/blob/20aeb2c03ce70f445232dba74179e03c94de0c2c/glvis.cpp#L641

Thanks for the response.
My issue with GLVis scripts is they run interactively. Pressing the space bar (or any other keys) is exactly what I am trying to avoid.
In any case, this is a minor issue.

You can generate the data for all screenshots and then create and run one GLVis script -- then you need to press space bar only once. Also, you can probably generate the GLVis script from your script.
That said, it is probably not too hard to update the way the S key is handled when given at the command line -- we just need to force an update of the GLVis window before we actually take the screenshot. Do you want me to try to add this?

Looking at the code, it seems like you may be able to force a redraw before the 'S' key is processed by adding the "key" '~e' -- e.g. glvis -m refined.mesh -g sol.gf -k "c~eS". Can you try this?

Yes, the ~e trick works fine. Thanks!


WIP: CFDP Handler Init

Fixes for documentation
Internal simplifications, a lot number of globals reduced by grouping related configuration
CFDP Handler added

Codecov Report

Merging #45 (ec1a049) into develop (75fda59) will increase coverage by 1.16%.
The diff coverage is 59.35%.

@@             Coverage Diff             @@
##           develop      #45      +/-   ##
===========================================
+ Coverage    45.57%   46.74%   +1.16%
===========================================
  Files           54       58       +4
  Lines         3945     4300     +355
===========================================
+ Hits          1798     2010     +212
- Misses        2147     2290     +143

Flag
Coverage Δ

unittests
46.74% <59.35%> (+1.16%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/tmtccmd/config/args.py
14.48% <0.00%> (-0.63%)
:arrow_down:

src/tmtccmd/config/com_if.py
24.79% <0.00%> (-0.42%)
:arrow_down:

.../tmtccmd/sendreceive/sequential_sender_receiver.py
23.68% <ø> (ø)

src/tmtccmd/sendreceive/tm_listener.py
28.03% <0.00%> (-0.12%)
:arrow_down:

src/tmtccmd/sendreceive/cmd_sender_receiver.py
16.52% <33.33%> (+0.52%)
:arrow_up:

src/tmtccmd/config/globals.py
40.50% <36.00%> (-1.27%)
:arrow_down:

src/tmtccmd/core/backend.py
41.08% <38.09%> (-1.09%)
:arrow_down:

src/tmtccmd/core/globals_manager.py
69.56% <40.00%> (ø)

src/tmtccmd/cfdp/filestore.py
53.28% <53.28%> (ø)

src/tmtccmd/config/hook.py
70.12% <60.00%> (+0.26%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75fda59...ec1a049. Read the comment docs.


VM: improve supports for using marketplace images

2 things:

Through the new command of az vm image accept-term, users can accept the term to use some market-place images with its own billing. Before, they have to do it through portal. This fixes #3411.
Update az vm image show to support --urn, so users can supply the urn returned from az vm image list and get the billing plan information easily

The flow looks like
urn = $(az vm image list --all --publisher kemptech --offer vlm-azure --sku basic-byol --query '[0].urn')
az vm image accept-term --urn $urn
az vm create -g rg -n vm1 --image $urn

General Guidelines

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

Command Guidelines

[x] Each command and parameter has a meaningful description.
[x] Each new command has a test.

(see Authoring Command Modules)

Do you know by any chance when this will land on the master branch rather than then dev? Great work @yugangw-msft, this is a very helpful feature indeed!

Actually, the main reason why I cannot see it is that when doing brew upgrade az, the version it provided to me is this:
$ az -v
\azure-cli (2.0.12)

acr (2.0.9)
acs (2.0.11)
appservice (0.1.11)
batch (3.0.3)
billing (0.1.3)
cdn (0.0.6)
cloud (2.0.7)
cognitiveservices (0.1.6)
command-modules-nspkg (2.0.1)
component (2.0.6)
configure (2.0.10)
consumption (0.1.3)
container (0.1.7)
core (2.0.12)
cosmosdb (0.1.11)
dla (0.0.10)
dls (0.0.11)
feedback (2.0.6)
find (0.2.6)
interactive (0.3.7)
iot (0.1.10)
keyvault (2.0.8)
lab (0.0.9)
monitor (0.0.8)
network (2.0.11)
nspkg (3.0.1)
profile (2.0.9)
rdbms (0.0.5)
redis (0.2.7)
resource (2.0.11)
role (2.0.9)
sf (1.0.5)
sql (2.0.8)
storage (2.0.11)
vm (2.0.11)

Python (Darwin) 2.7.10 (default, Jul 15 2017, 17:16:57)
[GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.31)]

Python location '/Users/mbernadin/lib/azure-cli/bin/python'

I would imagine that this commit resides in a more recent version. I'll go pull it from docker directly.
Thanks!


Cannot open source file “nuitrack/Nuitrack.h”

I am using VisualStudio 2017 and trying to run this sample project
http://download.3divi.com/Nuitrack/doc/nuitrack_console_sample_2src_2main_8cpp-example.html.
I successfully CMAKE the project, however when I run it on Visual Studio I get the error cannot open source file “nuitrack/Nuitrack.h”
I followed the installation step and the sample executables work for me, its just my Visual Studio projects are unable to import nuitrack.h
My environment variables look like this

Please post your question to NuiTrack team, because that sample is not my sample.
BTW, Are you installed NuiTrack SDK? I think those paths are NuiTrack Runtime path.
My FindNuiTrack.cmake requres NuiTrack SDK, and NuiTrack_DIR is path to NuiTrack SDK path.

My mistake I installed it incorrectly, I installed the run time not the sdk. Thanks you.


Enable no-floating-promises for data-workspace

No issues found

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 18 (33.33%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.006%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/data-workspace/src/common/dataWorkspaceExtension.ts
0
1
0.0%

extensions/data-workspace/src/common/workspaceTreeDataProvider.ts
1
3
33.33%

extensions/data-workspace/src/dialogs/newProjectDialog.ts
0
3
0.0%

extensions/data-workspace/src/dialogs/openExistingDialog.ts
3
6
50.0%

extensions/data-workspace/src/services/workspaceService.ts
2
5
40.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26507

Relevant Lines:
57181

💛  - Coveralls


release: add ability to publish manifest and helm chart fixes independent of container

Summary
The current release process ties the releasing of the emissary image to the release of the charts and manifests. We should have the ability release these two independently so that we can do z patches when we find bugs rather than having to wait for an Emissary-ingress image release.
Goals

allow chart/manifest changes to be released independently from container image release
no manual steps should be required beyond tagging a branch or something similar

So one challenge is the potential for drift between manifests and the chart. i.e we make updates in the chart but not in the raw manifests. Currently manifests are tied to the emissary version and generated when promoting to RC or GA. Furthermore the download link uses the Emissary version:
https://app.getambassador.io/yaml/edge-stack/3.2.0/aes.yaml

The way I see it we have two options:

Accept that the raw manifests are tied to the Emissary version and Chart is versioned separately. This means we have to accept the potential for drift and that chart changes won't make it into the raw manifests until the next Emissary Release

Publish new manifests when we publish a new chart. We should NOT overwrite the manifests pushed when an Emissary version was released. Therefore for this, I propose we modify the url to be:

https://app.getambassador.io/yaml/edge-stack/[Emissary X.Y.Z]-[Chart X.Y.Z]/aes.yaml

This would require update getambassador.io to refer to the new url format

As for how to do chart versioning I propose the following guidlines:

minor chart version bump require an Emissary version bump. so 8.3.0 -> 3.3.0 etc.
chart patch versions can be independent so 8.3.1 could still use Emissary 3.3.0.

With this in mind, I propose the following workflow when doing an independent chart release :

checkout a new branch rel/chart/vx.y.z from master or release/vx.y.z

update chart Changelog as necessary and commit. This step might not be needed depending if changelogs get autogenerated.

Wait for CI to pass. Ideally we shouldn't run the full gauntlet of tests. chart updates shouldn't require running KAT tests. The only tests need running should be the generate check, build check, and helm check. This should cut down on CI time significantly.

If changelogs are autogenerated then steps 1-3 becomes unnecessary. Just make sure the latest commit has CI green.

tag with new chart version chart/vx.y.z and push that up. this should trigger the publish-chart GH actions workflow to publish the new chart using the latest tagged emissary version (can include RCs). i.e if I push up charts/v8.3.1 it will use Emissary v3.3.0. If I did tag v3.3.1-rc.0 to mark a new Emissary RC, then it will use that instead etc. There could be a check here to make sure minor versions match i.e charts/v8.4.0 should find v3.4.0 if it finds v3.3.z that's no bueno.

There is a question whether we should prepare chart RC candidates. That would be only useful for smoke testing but the only smokes tests we would run is the helm install check and manual install check. helm changes already are tested using the helm-check in CI so not sure if this is entirely necessary.
[5.] If we did do chart RC releases and assuming those look good, then tag for chart GA and push that up. This would trigger the publish chart workflow again to push the GA chart.

We should NOT overwrite the manifests pushed when an Emissary version was released. Therefore for this, I propose we modify the url to be

Playing devil's advocate...what is the risk to a 3rd option that is overwriting the manifest for a version? It simplifies things that need to change and would accomplish what we want. I guess the downside his missing history, no way for users or us to know if they have the right versions...Not necessarily advocating but more or less thinking out loud.

If change log are autogenerated then steps 1-3 becomes unnecessary. Just make sure the latest commit has CI green.

I don't think we need to complicate processes with automating the generation of this change log. It rarely changes and only small changes are typically made so I don't think it is going to be a source of merge conflicts like the overall change log.
But, I do think the statement is true that these steps in most cases are not necessary because the current process is make your change and include a change log so once that is merged and CI is green then is already free to be released.

publish the new chart using the latest tagged emissary version (can include RCs)

I'm not sure I agree with the "include RC's". I think we should keep it simple at first and only add additional features if we find ourselves wanting these. The rule should be:

chart/vx.y.z looks for vx.y.z tags
chart/vx.y.z-rc.n looks for vx.y.z-rc.n tags

This ensures we do not accidentally ship a GA version with an rc tag. We can also add more advanced checks as you mentioned to ensure that the matrix of versions match correctly 8->3 and 7->2, etc...

I'm not sure I agree with the "include RC's". I think we should keep it simple at first and only add additional features if we find ourselves wanting these. The rule should be:

chart/vx.y.z looks for vx.y.z tags
chart/vx.y.z-rc.n looks for vx.y.z-rc.n tags
I mention that only if we don't bother creating chart rcs. if we do then yea chart GA versions should only reference Emissary GA versions.

One other question I thought of...is manually pushing of tags the appropriate mechanism. I mean it is
easy and I really like it because it is easy but the big downside is there is no review process.

Counter argument why should creating an RC require a review process?

I don't think a review should necessarily be required either, and I like the idea of just pushing a tag and then perhaps having a workflow that required manual approval for the final publishing steps.

Going through this now.

https://app.getambassador.io/yaml/edge-stack/[Emissary X.Y.Z]-[Chart X.Y.Z]/emissaryns.yaml

Not sure how I feel about this. As a user, if I am not using helm I don't really find much used to have the chart name included there and might consider it noise and/or confusing.

checkout a new branch rel/chart/vx.y.z from master or release/vx.y.z

Would we then merge re/chart/Vx.y.z back into master or release/Vx.y.z?
Bit of a side note. I think we should always have release/Vx.y.z branches even for v3 that is a different topic/discussion but just wanted to drop a line about it.

As for how to do chart versioning I propose the following guidelines:
minor chart version bump require an Emissary version bump. so 8.3.0 -> 3.3.0 etc.
chart patch versions can be independent so 8.3.1 could still use Emissary 3.3.0.

Agreed, this is the standard I had followed in the past. Then if we had emissry 3.3.1 I would bump helm to 8.3.2 (if it was on 8.3.1)

There is a question whether we should prepare chart RC candidates.

I think for this initial setup we should keep it simple. As we use it, we'll quickly discover what is missing and add it in. This is the approach I am taking with the subtree changes (which I have to write up in the GH issue). Just make it "bare bones" and iterate over it.

One other question I thought of...is manually pushing of tags the appropriate mechanism.

It works, however, I am always triple checking myself right before I push the tag. In the past, I automated the tag process based on PR releases. Once a "release PR" became approved and merged, that would have triggered the tag creation and push. We already have "release PRs" so it would extend that behavior of those.

Going through this now.

https://app.getambassador.io/yaml/edge-stack/[Emissary X.Y.Z]-[Chart X.Y.Z]/emissaryns.yaml

Not sure how I feel about this. As a user, if I am not using helm I don't really find much used to have the chart name included there and might consider it noise and/or confusing.

checkout a new branch rel/chart/vx.y.z from master or release/vx.y.z

Would we then merge re/chart/Vx.y.z back into master or release/Vx.y.z?
Bit of a side note. I think we should always have release/Vx.y.z branches even for v3 that is a different topic/discussion but just wanted to drop a line about it.

As for how to do chart versioning I propose the following guidelines:
minor chart version bump require an Emissary version bump. so 8.3.0 -> 3.3.0 etc.
chart patch versions can be independent so 8.3.1 could still use Emissary 3.3.0.

Agreed, this is the standard I had followed in the past. Then if we had emissry 3.3.1 I would bump helm to 8.3.2 (if it was on 8.3.1)

There is a question whether we should prepare chart RC candidates.

I think for this initial setup we should keep it simple. As we use it, we'll quickly discover what is missing and add it in. This is the approach I am taking with the subtree changes (which I have to write up in the GH issue). Just make it "bare bones" and iterate over it.

One other question I thought of...is manually pushing of tags the appropriate mechanism.

It works, however, I am always triple checking myself right before I push the tag. In the past, I automated the tag process based on PR releases. Once a "release PR" became approved and merged, that would have triggered the tag creation and push. We already have "release PRs" so it would extend that behavior of those.

Not sure how I feel about this. As a user, if I am not using helm I don't really find much used to have the chart name included there and might consider it noise and/or confusing.

@ddymko Yeah, I think that is fair. Would you say then that you are in-favor of option 1 which is to allow helm releases independent but manifests should stay tied to emissary releases?
I guess a third option, that I was just thinking about is that the release process is smooth already on Emissary with a few PR friction items and the discussion about release branches but overall it is smooth. So, does it hurt to just do a z patch release across all three even if it is just to incorporate a simple helm fix?
The whole reason for proposing the goal of making them independent is to improve our responsiveness in providing fixes. If the normal release process is already fast (which it is excluding smoke testing and doc updates) then I don't think hurts to just cut a release across the board. This would accomplish our goal of being able to be responsive, would address the drift question and would have no impact to the naming convention.
That would mean no changes on emissary side for this but instead would mean spending time on reducing the smoke testing time and also addressing our velocity problem on the Edge Stack side so that it can adopt these changes faster as well.

After some discussion it was decided to keep chart releases in lockstep with emissary releases to maintain operational simplicity.

After some discussion it was decided to keep chart releases in lockstep with emissary releases to maintain operational simplicity.

Adding a little additional context.
The raw YAML manifest are tied to the container release version. Where as the Helm Chart is only partially dependent on the container release version. I say partially because CRD's are tied to the container version but exposing another field within the values.yaml is only specific to the helm chart. Therefore, we are left with two main options:

Keep as-is which means cutting a full release so that chart, raw manifest, and container release are in lock-step
Allow charts to be released independently but accept that there is the potential for Skew between the raw yamls tied to the container release and the Helm releases

Although, we have seen other projects follow the latter approach, we felt that at this time the team has other bigger ticket items that they could spend their time on and that the current process is sufficient for number of releases we do. We may revisit it in the future if it becomes a major friction point.


Objectron for new classes other than the ones in ModelName (shoes, cup, etc)

Have I written custom code (as opposed to using a stock example script provided in MediaPipe)
No
OS Platform and Distribution
Ubuntu 22.04
MediaPipe Tasks SDK version
Objectron
Task name (e.g. Image classification, Gesture recognition etc.)
6D Pose Estimation
Programming Language and version (e.g. C++, Python, Java)
Python (open to other languages)
Describe the actual behavior
currently inference only works on a limited number of classes, shoes, cup, camera, chair.
https://codepen.io/mediapipe/pen/BaWvzdY

Describe the expected behaviour
I want to get inference on custom model. Want to get access to training code, documentation for capture or dataset creation for custom object, and finally be able to get real-time 6D inference on custom object of interest.

Standalone code/steps you may have used to try to get what you need
I haven't tried.

Other info / Complete Logs
No response

@monajalal,
We have ended the support of Objectron Solution as guided here. However, the libraries, documentation, and source code for all the MediapPipe Legacy Solutions will continue to be available in our GitHub repository and through library distribution services, such as Maven and NPM.
You can continue to use those legacy solutions in your applications if you choose But We are not providing support on it.
Thank you!!


Use a LevelDB instance as the node cache in StateDownloader

Closes: #1154

This is faster because the DB is much smaller as it contains only the hashes of the state trie nodes we already have in the actual chain DB: https://github.com/ethereum/py-evm/issues/1154#issuecomment-411746777


New version: MillerPuckette.PureData version 0.54-0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

The installer window is behind the pipeline automation window.

Manual Validation ended with:

@stephengillie If the pipeline still failed. Run /? to find the silent switch

I think the silent switch can be somewhere found.

Deleting
Entry

@stephengillie New link might come out right over here.


Removing Devices from Eval Lab

Hello, under the Request for more devices it references ..When all existing devices are used and deleted, you can request for more devices. The current documentation doesn't precisely specify how to delete devices.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 302ee74c-812a-51b2-13e5-7b5daaa411f7
Version Independent ID: 37fca1db-b257-588f-db65-4d5c6d7fd53f
Content: Microsoft Defender for Endpoint evaluation lab
Content Source: microsoft-365/security/defender-endpoint/evaluation-lab.md
Service: microsoft-365-security
Sub-service: mde
GitHub Login: @mjcaparas
Microsoft Alias: macapara

Any updates on this issue ?

Devices are deleted when they expire.


Request: C4F8 Chroma variant

Would you consider making one?

The chroma variant needs to output 2 distinct channels, and C4F8 is simply not good enough to do this without blocking/aliasing. I'd rather work on making C4F16 faster than waste time on a model that's intrinsically too small for the task.

That would work too, C4F16 Chroma on a native res 1080 24p video gets me into the low 50s (My display is 60hz)
btw thanks for all of the effort you put into your shaders !!


Incomplete documentation for TF module

Improved by #5 , still wip

Improved by lambda env var example, no further issues are reported, so I'm closing this.


🔧 remove nuxt-property-decorator

240 results in 233 files
Context

related with #4750
vue/multi-word-component-names rule (for like Avatar component name)
/_prefix/collection/_id & /_prefix/u/_id
Vue 3 composition API
remove westend & westmint for now
Nuxt 3 auto imported components

That is huge 😅

@roiLeo maybe create a separate PR for pages/collection/_id.vue?

Yes please!
I Would love to do that first

time to break things? 🫠

let's see

Looks like deploy is failing?