vs.
 rerendering

Describe the bug
Using <Show ...> ...  from leptos leads to re-rendering vs. using <div class = Some("hidden"). The rerendering is bad as it collapses all my 'manually expanded' info boxes and resets a radio selector to "no" selection.
It took me a few hours to figure out why the elements had collapsed when signal based updates occured.
I encountered this problem when going from the div with hidden to using :
41bd190e6f7761d975f73647f587edba13afb390
Here is an example of my rewrite:

into
<Show when= move || current_section.get() == Some(PageSection::DataCollection)>

          { set_views.clone() } // input fields for data collection

Note: I'm doing client side rendering using WASM in browser.
Leptos Dependencies
Please copy and paste the Leptos dependencies and features from your Cargo.toml.
For example:
leptos = { version = "0.6.5"}

To Reproduce
If you want an example I'll build one of course.
Expected behavior
I'm not sure.

Maybe we should add a notice to https://docs.rs/leptos/latest/leptos/fn.Show.html that rerendering occures.
Maybe the <Show implementation is wrong and needs fixing.

I'm curious what others think of this.

That is the expected behavior of <Show/>, yes. It's described more explicitly in the description in the book.
The Show component is extremely straightforward: here's the complete body of the function
    let memoized_when = create_memo(move |_| when());

    move || match memoized_when.get() {
        true => children().into_view(),
        false => fallback.run(),
    }

The reason it is designed this way is that if you were to cache the rendered children, they could never be cleaned up but would leak forever; no on_cleanup would run, etc.
Your class:hidden approach is the correct way to keep something alive in the DOM but not shown.
I'm open to expanding the docs.rs docs for Show to clarify this.

@gbj thanks for the explanation. i'd love a short note in https://docs.rs/leptos/latest/leptos/fn.Show.html about the rerendering. other than that we can close this.
should i do a PR?

@qknight Sure, it'd be lovely to have a PR for that


Lab03 - Letter frequency

Fixes #207
Review of colleague's PR #200
Changes proposed in this PR:
- implement solution for lab03

letterFrequency
tests

Codecov Report

Merging #209 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #209   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      3    +1
  Lines          18     42   +24
=====================================
+ Hits           18     42   +24

Impacted Files
Coverage Δ

03_letters/n0npax/main.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9605cdc...713734b. Read the comment docs.


How can I edit font-size... of content control

I got that element
doc_elm = document._element
contentControls = doc_elm.xpath('.//w:sdt')
for contentControl in contentControls:
print(contentControl)
Now, how can I edit font-size or line spacing?

Please ask support questions on StackOverflow using the "python-docx" tag. This issues
list is for suspected bugs and new feature requests.


[AutoPR compute/resource-manager] Swagger change for listing virtual machines in a subscription by location

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3984

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3383


HL-389, HL-500: Messenger improvements

Description :sparkles:
Applicant:
Showing new messages in the header of the application view
Handler:
Showing text message bubble icon in the application list, if the application has new messages
Issues :bug:
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #929 (51e8e3e) into develop (effd72a) will decrease coverage by 46.19%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           develop     #929       +/-   ##
============================================
- Coverage    68.94%   22.75%   -46.20%
============================================
  Files          701      102      -599
  Lines        20724     2501    -18223
  Branches      1765      643     -1122
============================================
- Hits         14289      569    -13720
+ Misses        6144     1862     -4282
+ Partials       291       70      -221

Impacted Files
Coverage Δ

...benefit/applicant/src/components/header/Header.tsx
0.00% <0.00%> (ø)

...nefit/applicant/src/components/header/useHeader.ts
0.00% <0.00%> (ø)

...t/applicant/src/components/messenger/Messenger.tsx
0.00% <0.00%> (ø)

...applicant/src/components/messenger/useMessenger.ts
0.00% <0.00%> (ø)

...nd/benefit/applicant/src/hooks/useMessagesQuery.ts
0.00% <0.00%> (ø)

...c/components/applicationList/ApplicationList.sc.ts

...src/components/applicationList/ApplicationList.tsx

...c/components/applicationList/useApplicationList.ts

...handler/src/components/mainIngress/MainIngress.tsx

...tet/admin/src/components/editor/SelectionGroup.tsx

... and 594 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update effd72a...51e8e3e. Read the comment docs.


refactor hyperscheduler

Codecov Report

Merging #345 (1ed697b) into master (6b9fe85) will decrease coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

:exclamation: Current head 1ed697b differs from pull request most recent head 3ccd85e. Consider uploading reports for the commit 3ccd85e to get more accurate results

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage   95.21%   95.21%   -0.01%
==========================================
  Files         129      129
  Lines        4449     4447       -2
==========================================
- Hits         4236     4234       -2
  Misses        213      213

Flag
Coverage Δ

unittests
95.21% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

domainlab/algos/builder_api_model.py
100.00% <100.00%> (ø)

domainlab/algos/builder_dann.py
100.00% <100.00%> (ø)

domainlab/algos/builder_diva.py
100.00% <100.00%> (ø)

domainlab/algos/builder_hduva.py
100.00% <100.00%> (ø)

domainlab/algos/builder_jigen1.py
100.00% <100.00%> (ø)

domainlab/algos/trainers/train_hyper_scheduler.py
93.33% <100.00%> (ø)

domainlab/algos/trainers/zoo_trainer.py
90.90% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Revert to using datasetList in jobParams

Revert to using the following inside jobParams:

datasetList: [
    {
        pid: 'someDatasetPid',
        files: [ 'file1', 'file2' ]
    }
]

Fix bug in src/app/datasets/archiving.service.ts that was not allowing job creation from the frontend.

Summary by Sourcery
Revert to using 'datasetList' in job parameters and fix a bug in the archiving service to allow job creation from the frontend.
Bug Fixes:

Fix a bug in the archiving service that prevented job creation from the frontend.

Enhancements:

Refactor job parameter structure to use 'datasetList' instead of 'datasetIds' across multiple components and services.

Covered while rebasing release-jobs to master. See branch https://github.com/SciCatProject/frontend/tree/wip-rebase-release-jobs


Interpolation Search

Algorithm

[x] I have gone through the repository and made sure this algorithm has not been implemented

Information about my new algorithm

Algorithm Name: Interpolation Search

Programming Language: C++

Time complexity: O(log(logn))

Is this your first contribution to this repository?
Yes

I would like to contribute to this

I would like to contribute to this


CORS options

Hello there!
I'm trying to build a go backend and a nodejs react frontend with connect. I have generated the server stubs for go and I use connect-query to generate the client.
However I'm having difficulty following the tutorial to enable cors on the go backend. Is there an option for this? I've tried creating an interceptor but I'm still getting CORS missing allow origin error.
func CorsInterceptor() connect.UnaryInterceptorFunc {
	interceptor := func(next connect.UnaryFunc) connect.UnaryFunc {
		return func(ctx context.Context, req connect.AnyRequest) (connect.AnyResponse, error) {
			req.Header().Set("Access-Control-Allow-Origin", "*")
			req.Header().Set("Access-Control-Allow-Methods", "GET, POST, PUT, DELETE, OPTIONS")
			req.Header().Set("Access-Control-Allow-Headers", "Accept, Content-Type, Content-Length, Accept-Encoding, X-CSRF-Token, Authorization")
			return next(ctx, req)
		}
	}
	return interceptor
}

Here is my buf.gen.yaml:
version: v1
plugins:
  - plugin: go
    out: gen/
    opt: paths=source_relative
  - plugin: connect-go
    out: gen/
    opt: paths=source_relative
  - plugin: buf.build/bufbuild/connect-query
    out: ./../frontend/gen
    opt: target=ts
  - plugin: buf.build/bufbuild/es
    out: ./../frontend/gen
    opt: target=ts
    ```

@bumberboy use this to setup CORS https://github.com/bufbuild/connect-demo/blob/3a30d4de07d6ac42110acd4ebf64bb4bf8a62579/main.go#L88

@qulaz has it right - CORS has to be handled at the net/http level, not in an interceptor. That's good, because you don't need anything connect-specific - you can use the same code/packages/etc that you'd use for CORS with any other HTTP handler. In the demo service, we use github.com/rs/cors and haven't had any problems with it.
Eventually, we intend to export some APIs to make this a bit easier. For now, the best approach is to copy the setup we use in our demo app.

@akshayjshah I think it should be in the documentation because I spent a lot of time last time trying to figure it out.
First, like @bumberboy, I tried using an interceptor (similar to what I do with other frameworks). Then I tried reverse-engineering this Eliza demo on connect.build via the network tab in the browser.  Finally, I realized that this demo is available on GitHub and found how you manage CORS in it.

Thanks for the help team!
I agree with @qulaz on adding this into the docs for Go. For node.js, cors gets a special mention: https://connect.build/docs/node/server-plugins#cors.


Issue in training BERT base model, steps/sec very low

I am trying to train BERT base model using SQUAD 1.1 as:
python run_squad.py
--vocab_file=uncased_L-12_H-768_A-12/vocab.txt
--bert_config_file=uncased_L-12_H-768_A-12/bert_config.json
--init_checkpoint=uncased_L-12_H-768_A-12/bert_model.ckpt
--do_train=True
--train_file=squad/train-v1.1.json
--do_predict=True
--predict_file=squad/dev-v1.1.json
--train_batch_size=12
--learning_rate=3e-5
--num_train_epochs=2.0
--max_seq_length=384
--doc_stride=128
--output_dir=/tmp/squad_base/
It's been 22hrs training. Output stats produced in the terminal ->
INFO:tensorflow:global_step/sec: 0.0359769
INFO:tensorflow:examples/sec: 0.431723
I can't figure out the problem. Any leads would be appreciated.

This is similar to the rate for run_classifier.py I see on 2GHz CPU (no GPU) with 60GB RAM, using base model uncased, 512 max tokens. The process takes most of the RAM. It is not actively swapping, but seems much slower than the GPU numbers (like 1hr) that I had heard about.

what is the standard rate of global_step/sec  and examples/sec when fine-tuning BERT base uncased on SQuAD v1.1 dataset in colab with GPU?


Can not download weather data through the link

The response is a 404 error.

Sorry about this - linked it now fixed.


Alphabetical order

Didn't see a clear order before. Popularity perhaps?
Perhaps this has already been discussed and thought through, perhaps not. =)

Not sure about this, the list is relatively short so sorting by popularity makes more sense, I think.


Remove file extension restrictions.

There are various files, that can contain plain text (for example embedded documentation in source files).
In my opinion, this extension should be allowed to run on every file, regardless of its extension and it should be up to the users to decide whether they are ok with false errors.

@Jan-Karasinski Thank you!! Will give it a shot.

Found a cleaner way to remove this check - go to C:\Users\user\.vscode\extensions\znck.grammarly-0.14.0\dist\extension\index.js:46936 and remove !LANGUAGES.includes(languageId) ||

If it could at least check my comments, it would be great.

Where can I find this file on a mac computer?


OCR support to extract text from image content

Describe the bug
When running the library, I end up with a page that has no text on it when the PDF does have text.
Example pdf page - https://ecorp.azcc.gov/CommonHelper/GetFilingDocuments?barcode=20073012585383
    const axiosResponse = await axios.get('https://www.chministries.org/media/5043/needsprocessingpacketweb.pdf', {
        responseType: 'arraybuffer',
        headers: {
            'Accept': 'application/pdf'
        }
    });

    const data = await PdfData.extract(axiosResponse.data as any);

    console.log('data text', data);

Using this kind of code works fine with other PDF pages.
Are there certain types of PDF formats that need to be converted differently?
Describe the expected behavior
I would expect there to be text displayed in the text attributes.
What is your Node.js version?
14.x.x
What operating system are you seeing the problem on?
Windows
Operating system version (or if other, then please fill in complete name and version)
10
Relevant log output
PdfData {
  pages: 2,
  text: [ '', '' ],
  fingerprint: '6477b4bbd76f64e67cf1d9c14a5d27c6',
  info: [Object: null prototype] {
    PDFFormatVersion: '1.2',
    IsLinearized: false,
    IsAcroFormPresent: false,
    IsXFAPresent: false,
    IsCollectionPresent: false,
    IsSignaturesPresent: false,
    Producer: ''
  }
}

Results -

### PDF File

[GetFilingDocuments.pdf](https://github.com/lublak/pdfdataextract/files/7340719/GetFilingDocuments.pdf)

Hey @aarmora
thanks for the bug report.
Currently my image library only extracts embedded text from a PDF file.
But in your PDF the text is embedded as an image.
Therefore you need OCR for these pages. OCR recognizes the text from image files.
Basically the biliothek https://github.com/naptha/tesseract.js would be useful for this.
But Tesseract itself needs an image file, so the pages would have to be converted as an image first.
I myself am interested in this functionality and would like to add it to pdfdataextract. Unfortunately I can't say when I will be ready with it.
The first step that is currently in planning is to convert a PDF file into an image with https://github.com/Automattic/node-canvas.
When this step is done, the next step will be the OCR functionality, which recognizes the image as text.

Actually, you don't need that much to know to do it.
Here is a working piece of code that uses tesseract.js and pdf-to-img:
const { createWorker } = require('tesseract.js');
const { pdf } = require("pdf-to-img");

const worker = createWorker({
    logger: m => console.log(m)
});

(async () => {
    const doc = await pdf("YOUR FILE PATH HERE", {scale: 2.0});
    await worker.load();
    await worker.loadLanguage('eng');
    await worker.initialize('eng');

    for await (const page of doc) {
        let { data: { text } } = await worker.recognize(page);
        console.log(text);
    }

    await worker.terminate();
})();

@busybox11 pdf-to-iamge is currently the same function as I described. It also uses the canvas library to render an image.
However, I would like to provide this functionality myself in this library.
I would like to support pure-image in addition to canvas. Because in certain areas native image libraries can not be used.
For the ocr functionality, the image which comes from this canvas then "scanned" with tesseractjs.
But also there I currently have another idea.
PDF files consist not only of image information but of text information.
So I want to make my OCR function a bit more intelligent.
Instead of scanning the complete page I want to scan only the images.
This has the advantage that pages that contain both (images and text) can be read more optimized.

The current development I have now for the time being publicly pushed into an extra branch, to be found here: https://github.com/lublak/pdfdataextract/tree/contentinfoextractor


Refactor slice extensions into a ParallelSlice trait

I started with a simple refactoring, and kept going...

The former ToParallelChunks/Mut are now just part of ParallelSlice.
A new par_windows is a parallel version of the standard windows.
The slice iterator types are no longer part of the prelude.  We usually just want traits here.
The slice iterator types are now renamed to mirror those in std::slice

Iter, IterMut, Chunks, ChunksMut, Windows

The distinct producer types weren't necessary - just implement Producer on the iterators.

The slice iterator types are now renamed to mirror those in std::slice

Iter, IterMut, Chunks, ChunksMut, Windows

Now that I've tried this mirrored naming scheme, I really like it.  Having std::foo::Iter, then rayon::foo::Iter is the same thing in parallel.  I think we should do this elsewhere as much as possible.  So that would move vec::VecIter to vec::IntoIter, and all the string types would lose their Par and maybe rename that module to rayon::str.  OptionIter is a little weird in that we currently fold all three Into/Iter/Mut variations into this one.  Don't know what to about RangeIter either.

The distinct producer types weren't necessary - just implement Producer on the iterators.

This is the only that gives me pause. Since the producer traits are public, people can observe that the iterator implements it, and start doing "producer-like" things. That wasn't meant to be possible, there is supposed to be a "phase shift" when the producer begins (by calling drive()).

Having std::foo::Iter, then rayon::foo::Iter is the same thing in parallel.

Big 👍 to this though. Great idea.

OK, I'll back out the producer change, and just give those simpler names than they had before.
(e.g. Iter and IterProducer, Windows and WindowsProducer, etc.)
We should probably make sure producers are consistently hidden throughout the code base.  If we trust rustdoc's list of implementors, the only other one exposed right now is RangeIter.  I'll touch that one when I look at using this new mirrored naming there.

Ditto UnindexedProducer, for which rustdoc lists RangeIter and ParChars.

@cuviper maybe the name for RangeIter should just be Range? Unclear.

Right, the standard iterator is std::ops::Range.  Don't know that I like rayon::ops::Range, except that I like the idea of applying such symmetry everywhere.

@cuviper it seems misleading. I think range is a special case, in that the iterator is the type, and we should just call it RangeIter or something.

I'm OK with treating ranges as a special case.  Perhaps rayon::range::Iter is slightly more consistent with where we're going?
Pushed the slice producer fixups.

Rebased to resolve merge conflicts.


⚠ Bofrost.lu has degraded performance

In dd84137, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1830 ms

Resolved: Bofrost.lu performance has improved in 6830667 after 8 minutes.


Consider integrating cleanlab - cleans noisy labels (enhancement)

The Cleanlab project aims to clean up noisy labels.
From what I understand so far it prunes those examples it is confident are labelled erroneously.  More docs here.
This might help improve SOTA.
For those who like academic papers : https://arxiv.org/abs/1911.00068
Two things to note:

the lead author is CGNorthcutt who is already aware of AutoGluon and offering help on a separate issue, here,
the license is "GNU Affero General Public License" - I'm not sure if this presents a problem.

I think it could be solved by https://github.com/autogluon/autogluon/issues/1493

Hi @willsmithorg, @Innixma
I've implemented draft scikit-learn wrapper for autogluon that works with cleanlab, at least with wine toy-dataset:
class AutogluonClassifier(BaseEstimator, ClassifierMixin):
    def __init__(self, eval_metric=None, time_limit=60, hyperparameters=None, verbosity=2):
        self.eval_metric = eval_metric
        self.time_limit = time_limit
        self.hyperparameters = hyperparameters
        self.verbosity = verbosity
        self.tabular_predictor = None
        self.classes_ = None
        self.n_features_in_ = None
        self.n_classes_ = None
        self.feature_names_in_ = None

    def fit(self, X, y):
        self.n_features_in_ = X.shape[1]
        self.feature_names_in_ = X.columns.tolist()

        X = pd.DataFrame(X)
        X['target'] = y
        self.tabular_predictor = TabularPredictor(label='target', eval_metric=self.eval_metric)
        self.tabular_predictor.fit(train_data=X, time_limit=self.time_limit, hyperparameters=self.hyperparameters, verbosity=self.verbosity)

        self.classes_ = self.tabular_predictor._learner.label_cleaner.ordered_class_labels
        self.n_classes_ = len(self.classes_)

    def predict(self, X):
        if self.tabular_predictor is None:
            raise NotFittedError("Model has not been fitted. Call 'fit' before 'predict'.")
        return self.tabular_predictor.predict(X)

    def predict_proba(self, X):
        if self.tabular_predictor is None:
            raise NotFittedError("Model has not been fitted. Call 'fit' before 'predict_proba'.")
        return self.tabular_predictor.predict_proba(X)

cleanlab usage:
label_issues_info = CleanLearning(clf=AutogluonClassifier()).find_label_issues(X_train, y_train)

Please let me know, if this works for your usecase and be aware that I've checked it only with wine dataset.
Full code is here:
https://colab.research.google.com/drive/1tMVNbYhu9sLsUWdq1tPabid7-eb8ZPo3?usp=sharing

Closing this issue assuming that the sklearn-compatible API (#1493) fixed it. Please feel free to re-open if it's not the case.


[BUG] First Column Contains a Word "Test"

The first column contains a word test in it. Like for now, I have the header Full Name. It says test"Full Name" in it.
The version is latest. See date.

NVM. My bad. FYI in case this happens to others. If there's an echo anywhere in the code even if it's outside the class, that word gets concatenated into the exported file itself.


Page 4: update download to have multiple providers and explain

In the download for learner characteristics we currently only download one provider at a time. Suggested that we instead allow users to download all.
We should also add descriptive text that details what data will be downloaded for users

Fixed in #71


Upgrade PDBs to portable format

Blocked by https://github.com/OpenCover/opencover/issues/595
OpenCover does not yet support running coverage on the new portable and embedded PDB files. Once the support is released, we can upgrade Colore to use these new formats and look at getting SourceLink support in.

This was "fixed" at some point. Looking at the source we have both portable PDBs and SourceLink now. I guess we removed OpenCover at some point because I see no mention of it anywhere.


Add disclaimer to README

This adds a disclaimer to the Mixer README.
I will update after 1.5 ships (and deprecation happens).
[ ] Configuration Infrastructure
[X ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@oaktowner: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
1ea33608dc26cd2b1c9a901f01fb7a0743de8d14
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oaktowner: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
1ea33608dc26cd2b1c9a901f01fb7a0743de8d14
link
/test lint_istio

gencheck_istio
fa1d9202bcc3c41811cbba8e47516aa11103bd3a
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oaktowner: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
fa1d9202bcc3c41811cbba8e47516aa11103bd3a
link
/test gencheck_istio

unit-tests_istio
fa1d9202bcc3c41811cbba8e47516aa11103bd3a
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@oaktowner: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fa1d9202bcc3c41811cbba8e47516aa11103bd3a
link
/test unit-tests_istio

gencheck_istio
fa1d9202bcc3c41811cbba8e47516aa11103bd3a
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oaktowner: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
fa1d9202bcc3c41811cbba8e47516aa11103bd3a
link
/test gencheck_istio

unit-tests_istio
fa1d9202bcc3c41811cbba8e47516aa11103bd3a
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Hmmm. I'm not sure why tests would be failing because I changed a README...

Hmmm. I'm not sure why tests would be failing because I changed a README...

@oaktowner welcome to Istio development workflow. :) Some of these checks are just flaky and fail intermittently. Let me re-trigger and see if they work.

/test gencheck_istio

/test unit-tests_istio

@oaktowner: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fa1d9202bcc3c41811cbba8e47516aa11103bd3a
link
/test unit-tests_istio

gencheck_istio
fa1d9202bcc3c41811cbba8e47516aa11103bd3a
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Looks like these two checks are broken for all PRs afaict. May be @howardjohn knows more about it?

@oaktowner: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
fa1d9202bcc3c41811cbba8e47516aa11103bd3a
link
/test gencheck_istio

unit-tests_istio
fa1d9202bcc3c41811cbba8e47516aa11103bd3a
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test lint_istio

/test integ-galley-k8s-tests_istio

@oaktowner: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3bf3f7c7b64b6cc2a4a59df821b38bf973ff1f4b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio


Behavior of arrow keys in References in sidebar

I am a big fan of the References tab in the sidebar. I find that to show a reference in the code editor I have to either click on the reference or navigate to the reference using arrow keys and press enter.
Is it possible to change the behavior (or add a setting) to automatically show the reference in the code editor when the user navigates via arrow keys (without having to press enter/return).
Here is a gif of the current behavior:

Here are the detials of my application:
Version: 1.45.1
Commit: 5763d909d5f12fe19f215cbfdd29a91c0fa9208a
Date: 2020-05-14T08:33:47.663Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.5.0

The default is like this

arrow keys navigate but don't change focus
F4/Shift+F4 navigate and change focus (that's what you want)

These keybindings match the defaults, e.g how search works, but you can cutomize them as you like.

Appreciate you pointing me to the right place @jrieken!


App available on all subdomains (plus root)

I have a Rails app deployed to example.com (with namespaced subdomains defined for api.example.com and dashboard.example.com).
They all work fine .. but visiting foo.example.com displays the example.com site.
I tried the solution offered in #423 (shown below), and then reseting nginx - but that didn't resolve the problem:

Try creating a /etc/nginx/sites-available/default with the following contents:
server {
    listen [::]:80 default_server;
    listen 80 default_server;
    root /usr/share/nginx/html;
    index index.html;
    server_name _;
}

I have the following DNS entries:
A   example.com   <IP_ADDRESS>
A *.example.com   <IP_ADDRESS>

@josegonzalez should we include a default site with dokku that just routes to the welcome page?

Maybe, but that would require a bit of design work. Not sure of the nginx routing implications.

Yeah I don't think we should dictate this. Too many potential preferences to consider.

So just document this in the nginx documentation with steps on how to not route everything to the default app?
Isn't there a way to make nginx not route to a default and just null-terminate?


Update gdpr-arc-Office365.md

Removed duplicate row 7.2.3

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/3393

@JohanFreelancer9 Please copy review

@robmazz Please merge this PR. Thanks


Fix some text rendering and input issues

Fixes a Linux crash when trying to render emoji;
Fixes backspace deleting chars and not characters (chars are 16-bit and characters outside of the BMP consist of two chars, also characters like â can consist of two chars too);
Fixes paste pasting twice;
Changes SDL_GetClipboardText() to be interpreted as UTF-8, as by the docs.

.NET Core is needed for Marshal.PtrToStringUTF8()


New Package: realsast.FlyingCube version 1.0

[x] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Does your manifest conform to the 1.0 schema?

What is the expected installation location of the application?

What is the expected installation location of the application?

when i try to download it via the exe file it says D:/Flying Cube. Really weird cus i only had one disk when making this program
(btw the inno project for the installer is https://github.com/superofficial/Flying-Cube/blob/master/Flying Cube/Game/Installer/setup code.iss)

What is the expected installation location of the application?
When I run the PRTest script, in windows sandbox it installs to C:\Program Files (x86)\Flying Cube

Have you tried running this on an x86 system? I see the following error:
"The specified executable is not a valid application for this OS platform."
Is it possible that this is only able to run on x64 systems?

Have you tried running this on an x86 system? I see the following error:
"The specified executable is not a valid application for this OS platform."
Is it possible that this is only able to run on x64 systems?

I don't have an x86 vm to test on, but I'll see if switching to x64 makes a difference
As a side note, it would be really helpful if those error messages were printed to the pipeline output so that we can see them. Right now we only see that it had to go to manual review
https://dev.azure.com/ms/winget-pkgs/_build/results?buildId=253460&view=logs&j=871b4eed-22de-5cb6-c1c8-82f190de633f&t=58bdf892-4e45-5ba7-4782-31912f95e167


support newer java cookbook versions

The latest java cookbook is version 1.22.0 and does not satisfy the version constraint in the maven cookbook's metadata.rb. A 'berks install' fails when this combination of cookbooks is used.
Assuming the intent was only to prevent versions before 1.13, this change will support the latest version of the java cookbook.
I have tested and verified that this works with java cookbook 1.22.0

Since the CLA hasn't been signed in over 6 month for this PR I'm going to close it out at this point.  If the author would like to sign the CLA feel free to open up the PR again.

I actually signed the ICLA back in July 2014 when the above chef-supermarket comment was posted.
Is there something else I need to do to make it appear on this PR?
I just logged into supermarket and it does show that I have already signed the ICLA and my github account is linked.


ZEPPELIN-598 ] Dynamic loading for Interpreter

What is this PR for?
Use of external libraries that are included in the Roadmap,
The interpreter needs related to dynamic loading capabilities.
It has been re-written from the first newly created PR.
https://github.com/apache/incubator-zeppelin/pull/631
What type of PR is it?
Feature
Todos

[x] - Dynamic load
[x] - Modified according to feedback (https://github.com/apache/incubator-zeppelin/pull/631)

Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-598
How should this be tested?
By annotating the interpreter setting items below, try using the loadDynamicInterpreter method.
Or create a new interpreter loads created in the local Maven repository.
incubator-zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
    ZEPPELIN_INTERPRETERS("zeppelin.interpreters", "org.apache.zeppelin.spark.SparkInterpreter,"
        + "org.apache.zeppelin.spark.PySparkInterpreter,"
        + "org.apache.zeppelin.spark.SparkSqlInterpreter,"
        + "org.apache.zeppelin.spark.DepInterpreter,"
        + "org.apache.zeppelin.markdown.Markdown,"
...

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

Is it closed on purpose?


Pandas Support

I'm not sure if you're much of a pandas user, but I think it would be really nice if these classes could be used in Pandas. Would you be open to providing support via the extension array interface?

Hi @sterlinm, thanks for taking the time to open this issue 👋
I'm not a pandas user, but I know it's of course very popular. I'm open to providing this type of support, on the following conditions:

pandas does not become a dependency of whenever
the complexity of adding this is low. It risks becoming a maintenance burden otherwise. At the moment I don't have a clear picture of what the required work is.

If you're not an active pandas user, I'd hesitate to prioritize something like this. If I have some time, I'll experiment with it at some point to get a better sense of how involved it would be.
I think it could be built/packaged separately from the main whenever package to avoid introducing pandas as a dependency. Thanks!

@sterlinm you're welcome to experiment, and I'm curious for the result.
I expect that we can easily circumvent the pandas dependency.
I'll leave this issue open, but indicate that it's not currently a prio


Files uploaded to a server behind NPM fail when larger than 40kb

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?

Yes

Are you sure you're not using someone else's docker image?

Yes

Have you searched for similar issues (both open and closed)?

Yes

Describe the bug

File uploads over a certain size handled by PHP result in npm returning either a 502 or 504 error.
Nginx Proxy Manager Version

2.11.1
To Reproduce
Steps to reproduce the behavior:

Go to https://ss13.moe/uploadtest
upload an image larger than 40kb
wait 5 minutes and receive 504 or 502

Expected behavior

Upload the image
receive success message

Operating System

npm is on debian
upload test is hosted by apache on winserver2022 however the issue occurs regardless of OS the webserver is hosted on.
Additional context

uploads work fine if the reverse proxy is bypassed. configuration options for request timeouts and upload/body size are set higher than what was in production for debugging and resulted in no change.
example successful upload log from npm
[31/Jan/2024:11:20:25 +0000] - 200 200 - POST http ss13.moe "/uploadtest/" [Client [ip]] [Length 37] [Gzip -] [Sent-to <IP_ADDRESS>] "ShareX/15.0.0" "-"

example error log from npm
2024/01/31 11:25:39 [error] 312417#312417: *510967 upstream timed out (110: Connection timed out) while sending request to upstream, client: [ip], server: ss13.moe, request: "POST /uploadtest/ HTTP/1.1", upstream: "http://<IP_ADDRESS>:80/uploadtest/", host: "ss13.moe"
2024/01/31 11:30:40 [error] 312417#312417: *510967 upstream timed out (110: Connection timed out) while sending request to upstream, client: [ip], server:ss13.moe, request: "POST /uploadtest/ HTTP/1.1", upstream: "http://<IP_ADDRESS>:80/uploadtest/", host: "ss13.moe"

access log from npm
[31/Jan/2024:11:25:39 +0000] - 504 504 - POST http ss13.moe "/uploadtest/" [Client [ip]] [Length 164] [Gzip -] [Sent-to <IP_ADDRESS>] "ShareX/15.0.0" "-"
[31/Jan/2024:11:30:40 +0000] - 504 504 - POST http ss13.moe "/uploadtest/" [Client [ip]] [Length 164] [Gzip -] [Sent-to <IP_ADDRESS>] "ShareX/15.0.0" "-"

@d3athrow have you solved it ?

nope


New Default Depth Limit Breaks Things

Just installed some dependencies that include a lenient semver string for this package. The depth limit made my app break in strange ways, wasn't really expecting [...] to start showing up in my REST calls. The depth limit is a neat feature, but probably shouldn't have a default value.

You are likely right, sorry for the mishap! We will remove the default value.


reset-search-input=true resets input box but not button every second call

The ui-select is bound to a scope var with ng-model. I reset it so that when the input text box blurs, and it switches back to a button, it always shows the placeholder text of "Search..."
Yet, each second call it ignores the reset.

Create a ui-select with reset-search-input=true.
Click the select, it becomes an <input>
Type into the input
Select an item
The ui-select changes from input back to button, and is cleared
Repeat steps 2-5. This time, the button does not reset to the placeholder text.

I modified the original sample plunkr to show it, here: http://plnkr.co/edit/16DRYH8MbPJOy0GpogZz?p=preview
I have it call on-select to trigger the desired action and reset the ng-model, so it is cleared.
For some reason, resetting the scope variable tied to the model only clears it every second time. Is this a timing issue? If so, why would it consistently be every second time?

Any updates?

If it helps... it appears to have something to do with the order of calling in ngModelWatch in angular. When it fails, it calls it for the ctrl for the input and then for the ngModel; when it succeeds, the other way around.

Brutally painful, but I did figure it out. It has to do with when the various ng-model calls are made by watches.
I worked around it using a separate directive reset-search-model and then using on-select to capture the information. I can submit it, if anyone wants.

i'd like to see your code, im having the same problem, it will help me a lot.

Hey @sonicd300 , I didn't want to hack the original ui-select code, and risk making it incompatible with upgrades. So I wrote my own little directive to clear it appropriately. After enough headache, it turned out to be very simple to clear. But isn't that always the case? The biggest problem has the simplest solution... once you figure it out. :-)
Here is the gist https://gist.github.com/deitch/e4abbaeeaca7b0d66fcf
I also modified the plunkr to show it working.
http://plnkr.co/edit/58OgDXOaW12D38U2m381?p=preview
Personally, I think this should be added to the core as an option. But I might be biased...
Enjoy!

Thanks for the gist, i've modified a little bit, let me know what you think.
Basically removed the if so you just set reset-search-model, it's presence will be enough to make the directive work, no need to set the attribute to true/false
https://gist.github.com/sonicd300/3bf44e56a4bdb3eb8a0d

Like. Very much. Now.... can we get the angular-ui team to make this a standard part of ui-select?

Hope they include this or something to solve this bug, i've spent a lot of time trying to figure it out on my own (not as much as you) then decided to check the bug report and found you, many thanks bro.

I hope so too. But I am glad my hard work paid off for more than just me!
If you message with any of them, or can bump it, please do.

@sonicd300
if you're still searching for a solution, workarounds can be found here: http://stackoverflow.com/a/28318018/2938151

Hi @ulilicht thanks for the link, your time is much appreciated.
In my case I prefer the directive instead of having patch logic in a controller, so when library updates I can easily remove the directive and go back to normal with less effort.

Is there an answer for this one?

I updated the original plunker with last version of library and I don't see the problem anymore. Can you reconfirm this?
Updated plunker

@dimirc yes, it looks like this latest plunkr does not have the problem.
It looks like you are using 0.9.8 in this plunkr. Can you share the change, or point to a commit so we can see the diff?

Hmm, I am still seeing it when I remove my added directive. I am exploring further...

Yes, and definitely using 0.9.9, but I cannot yet reproduce it in the plunkr. Trying.

OK, I see it. You are using the on-select callback to reset the model. I guess that would work, but would you not just want to use the extended directive option reset-search-model that automatically does it? Isn't that both cleaner and more in line with the angular directive style?


No preview is loaded for a link to a tweet on Twitter

Using:
SwiftLinkPreview 3.3.0
Xcode 12.4
Example:
If you provide https://twitter.com/joshdholtz/status/1359219485543182337?s=20 as text to SwiftLinkPreview's preview(text:onSuccess:onFailure) method it responds in the success block with
Response(url: Optional(https://twitter.com/joshdholtz/status/1359219485543182337?s=20), finalUrl: Optional(https://twitter.com/joshdholtz/status/1359219485543182337?s=20), canonicalUrl: Optional("twitter.com"), title: nil, description: Optional("We’ve detected that JavaScript is disabled in this browser. Please enable JavaScript or switch to a supported browser to continue using twitter.com. You can see a list of supported browsers in our Help Center."), images: Optional(["https://abs.twimg.com/errors/logo46x38.png"]), image: Optional("https://abs.twimg.com/errors/logo46x38.png"), icon: Optional("https://abs.twimg.com/responsive-web/client-web-legacy/icon-ios.b1fc7275.png"), video: nil, price: nil)
The title is nil, and the images are generic Twitter icons not related to the Tweet.

Tested with some random Twitter link, the same error message of javascript is coming

Anyone have a workaround for this? Would love to be able to embed tweets

I actually figured a workaround using nitter.net (this site mirrors twitter.com and is non-javascript friendly). If I detect twitter.com, I swap out the domain to nitter.com for the unfurling, and then I switch it back before sending the data along:
if url.contains("/status/") && url.contains("twitter.com") {
  url = String(url).replacingOccurrences(of: "twitter.com", with: "nitter.net")
}

Just tested the twitter link using the patch I submitted in https://github.com/LeonardoCardoso/SwiftLinkPreview/pull/155 and it works.
Looks like the user agent might be the root issue of multiple issues.

@LeonardoCardoso Can you please check this issue, I believe you have done an amazing job on this module. Can you pleae fix some of the issues.


refactor(storybook|ino-popover): reformat stories

Part of #574
Proposed Changes

reformat stories of ino-popover to follow unified story format

Can you remove the blank line here?


Error when saving client and need together

When I create a client and a need together and hit save, it doesn't post

Made two different commits


Add qualifier to instr_error_i

Problem:
`d_error` signal in rv_core_ibex directly affects the Ibex IF stage.
And it affects prefetch, then it creates the loop.

Resolution:
Add `d_valid` qualifier at the `instr_error_i` and `data_error_i`.

If the request from the TL-UL hosts are not valid, the TL-UL creates
error responses and returns to the requesters with d_error as 1. The
error signal in TL-UL D channel is valid only when the d_valid is
asserted.
Ibex, however, sees the error signal always and it triggers the branch
if the error signal is asserted. And the prefetch sends a new request to
the crossbar. It creates a logical loop.
This fix is to add d_valid qualifier to the *_error_i in
rv_core_ibex. It may not be a perfect solution but would break the
loop.
This closes issue #1657

@eunchan, you probably know this better than i do...but when there is an invalid transaction on TLUL, (ie something during the a_valid cycle), doesn't the d_valid and d_error not get asserted until the next cycle?
Do we actually have same cycle (same as a_valid) error returns in our system?

The a_valid signal triggers the arbiter inside tlul_socker_1n. After it
passes the arbiter, then the response channel is chosen right away.
As the d_error is tied to 1 and the tlul_fifo_sync is set to bypass, the error
signal in the core point of view is changed right away even d_valid returns at
next cycle.
So that's a little bit tricky part as our fabric is all bypass.
On Tue, Mar 03, 2020 at 03:00:08PM -0800, tjaychen wrote:

@eunchan, you probably know this better than i do...but when there is an invalid transaction on TLUL, (ie something during the a_valid cycle), doesn't the d_valid and d_error not get asserted until the next cycle?
Do we actually have same cycle (same as a_valid) error returns in our system?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/lowRISC/opentitan/pull/1668#issuecomment-594215458

hmmm.... but if the response channel selection is delayed until the next
cycle (the same cycle d_valid asserts), that would technically be okay also
right, and also break the loop?
i may not be understanding correctly.
On Tue, Mar 3, 2020 at 3:35 PM Eunchan Kim<EMAIL_ADDRESS>wrote:

The a_valid signal triggers the arbiter inside tlul_socker_1n. After
it
passes the arbiter, then the response channel is chosen right away.
As the d_error is tied to 1 and the tlul_fifo_sync is set to bypass, the
error
signal in the core point of view is changed right away even d_valid
returns at
next cycle.
So that's a little bit tricky part as our fabric is all bypass.
On Tue, Mar 03, 2020 at 03:00:08PM -0800, tjaychen wrote:

@eunchan, you probably know this better than i do...but when there is an
invalid transaction on TLUL, (ie something during the a_valid cycle),
doesn't the d_valid and d_error not get asserted until the next cycle?
Do we actually have same cycle (same as a_valid) error returns in our
system?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/lowRISC/opentitan/pull/1668#issuecomment-594215458

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/1668?email_source=notifications&email_token=AAH2RSSYGCFBKBXXLVHKIEDRFWH3BA5CNFSM4LASJRL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENVS3KA#issuecomment-594226600,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSQGWBIHHHIPXJAFDCLRFWH3BANCNFSM4LASJRLQ
.

hmmm.... but if the response channel selection is delayed until the next cycle (the same cycle d_valid asserts), that would technically be okay also right, and also break the loop? i may not be understanding correctly.
…
On Tue, Mar 3, 2020 at 3:35 PM Eunchan Kim @.> wrote: The a_valid signal triggers the arbiter inside tlul_socker_1n. After it passes the arbiter, then the response channel is chosen right away. As the d_error is tied to 1 and the tlul_fifo_sync is set to bypass, the error signal in the core point of view is changed right away even d_valid returns at next cycle. So that's a little bit tricky part as our fabric is all bypass. On Tue, Mar 03, 2020 at 03:00:08PM -0800, tjaychen wrote: @., you probably know this better than i do...but when there is an invalid transaction on TLUL, (ie something during the a_valid cycle), doesn't the d_valid and d_error not get asserted until the next cycle? > >Do we actually have same cycle (same as a_valid) error returns in our system? > >-- >You are receiving this because you were mentioned. >Reply to this email directly or view it on GitHub: >#1668 (comment) — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#1668?email_source=notifications&email_token=AAH2RSSYGCFBKBXXLVHKIEDRFWH3BA5CNFSM4LASJRL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENVS3KA#issuecomment-594226600>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH2RSQGWBIHHHIPXJAFDCLRFWH3BANCNFSM4LASJRLQ .

the response channel (to the error response) is chosen right at the same cycle, as TL-UL response can be arrived in a cycle.

ah yeah i know tl-ul allows it, but our system is never going to do that :)
On Tue, Mar 3, 2020 at 3:42 PM Eunchan Kim<EMAIL_ADDRESS>wrote:

hmmm.... but if the response channel selection is delayed until the next
cycle (the same cycle d_valid asserts), that would technically be okay also
right, and also break the loop? i may not be understanding correctly.
… <#m_2328765662215077293_>
On Tue, Mar 3, 2020 at 3:35 PM Eunchan Kim @.> wrote: The a_valid
signal triggers the arbiter inside tlul_socker_1n. After it passes the
arbiter, then the response channel is chosen right away. As the d_error is
tied to 1 and the tlul_fifo_sync is set to bypass, the error signal in the
core point of view is changed right away even d_valid returns at next
cycle. So that's a little bit tricky part as our fabric is all bypass. On
Tue, Mar 03, 2020 at 03:00:08PM -0800, tjaychen wrote: @., you probably
know this better than i do...but when there is an invalid transaction on
TLUL, (ie something during the a_valid cycle), doesn't the d_valid and
d_error not get asserted until the next cycle? > >Do we actually have same
cycle (same as a_valid) error returns in our system? > >-- >You are
receiving this because you were mentioned. >Reply to this email directly or
view it on GitHub: >#1668 (comment)
https://github.com/lowRISC/opentitan/pull/1668#issuecomment-594215458 —
You are receiving this because your review was requested. Reply to this
email directly, view it on GitHub <#1668
https://github.com/lowRISC/opentitan/pull/1668?email_source=notifications&email_token=AAH2RSSYGCFBKBXXLVHKIEDRFWH3BA5CNFSM4LASJRL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENVS3KA#issuecomment-594226600>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSQGWBIHHHIPXJAFDCLRFWH3BANCNFSM4LASJRLQ
.
the response channel (to the error response) is chosen right at the same
cycle, as TL-UL response can be arrived in a cycle.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/1668?email_source=notifications&email_token=AAH2RSTDNQH7CREX6DDLNGTRFWIWVA5CNFSM4LASJRL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENVTMPQ#issuecomment-594228798,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSWOTN6PHRPAUTMBTQ3RFWIWVANCNFSM4LASJRLQ
.

Two observations:

I don't see how this actually breaks the loop, logically it may mean you don't have a loop (as from your descriptions it's only when error is set and valid isn't that you get the looping logic) but physically, in terms of what gates are connected to what, the loop remains with the attendant issues that causes. To break the physical loop at a connection that currently exists must be removed.

This may be more of an Ibex issue, certainly Ibex shouldn't be caring what error is set to when the valid isn't set, I don't think Ibex should have a path data_error_i to core_instr_req_o. I will take look at Ibex side of things.

Two observations:

I don't see how this actually breaks the loop, logically it may mean you don't have a loop (as from your descriptions it's only when error is set and valid isn't that you get the looping logic) but physically, in terms of what gates are connected to what, the loop remains with the attendant issues that causes. To break the physical loop at a connection that currently exists must be removed.

I agree. This doesn't break the loop, but only stop Ibex from seeing wrong error signal.

This may be more of an Ibex issue, certainly Ibex shouldn't be caring what error is set to when the valid isn't set, I don't think Ibex should have a path data_error_i to core_instr_req_o. I will take look at Ibex side of things.

Thanks!

@udinator Does Ibex environment has a test case that asserts error_i when valid_i is zero? Does Ibex take the signal and jump to error handling code?

@udinator Does Ibex environment has a test case that asserts error_i when valid_i is zero? Does Ibex take the signal and jump to error handling code?

@eunchan, I don't have a test case that asserts memory errors when the valid_i is deasserted, is this something you want tested?

@udinator I presume you currently drive X on error_i when valid_i is deasserted? That should be sufficient to catch cases where Ibex does something with error_i when valid_i isn't set.
Still perhaps a mix of driving X and driving random values on the memory bus when valid_i is deasserted would be better?


No length map is found. Please set -F.

Hello everyone, I am trying to create the index of the chain file but I am getting the following error: "[E::serialize_run] No length map is found. Please set -F.". The command I am using is docker run naechyun/leviosam2 leviosam2 index -c chm13v2-hg38.over.chain -p chm13v2-hg38 -F Homo_sapiens_GRCh38.p14.fasta.fai. I obtained the .fai file by using samtools faidx on my .fasta file downloaded from NCBI and previously modifying the chromosome names to chr1, chr2, etc to match the chain file. Both files are in the folder where I am running the command. I have also tried running "-F .", "-F /root/Resources/GRCh38/fasta/Homo_sapiens_GRCh38.p14.fasta.fai" and "./Homo_sapiens_GRCh38.p14.fasta.fai". Thank you in advance for your help.

Hi @alisonomica ,
I tried the following command but could not reproduce your issue. I tried v0.3.0 and v0.2.2.
wget https://genome-idx.s3.amazonaws.com/lev/chm13v2-grch38.tar.gz
tar xfzv chm13v2-grch38.tar.gz

wget https://hgdownload.soe.ucsc.edu/goldenPath/hg38/bigZips/p14/hg38.p14.fa.gz
gunzip hg38.p14.fa.gz

leviosam2 index -c chm13v2-grch38/chm13v2-grch38.chain -F hg38.p14.fa.fai -p test

Could you take a look at the command above and check if that work for you?

Close this issue for now. Please let me know if more discussion/help is needed.


Fix airline tabline icons and undefined or ugly symbols

Before:

After:

warning after install:
The variable g:airline_branch_prefix is deprecated and may not work in the future. It has been replaced with g:airline_symbols.branch. Please read the documentation....

@avelino , I fix this warning after read the airline documentation. Thanks.  ;)

Guys, this pull request broken some special chars for Terminal users.

Maybe airline.vim have some dependencies for fix this unicode error, vim-bootstrap must be easy to install, without config steps.
I prefer something generic that works for everyone instead of something beautiful that works for very few people.

If anyone have problem with this, please let me know.

@lerrua , thanks for report this. This problem happens because you don't have Powerline fonts installed in your terminal. If you to install Menslo Powerline Font, for example, and use this font in your terminal... This problem is solved.
I agree with you and I prefer an generic approach.


Use should before click in cypress testing

https://www.cypress.io/blog/2019/01/22/when-can-the-test-click/#Try-and-try-again
┆Issue is synchronized with this Jira Task
┆Issue Type: Task
┆Fix Versions: Dockstore 2.X
┆Issue Number: DOCK-592

@garyluu mentioned this is probably best practice, but doesn't quite solve test failures
can add to style doc for cypress testing


Use 'kubectl' to list taskrun for pipeline

Fix: #91

Codecov Report

Merging #281 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   69.86%   69.88%   +0.02%
==========================================
  Files          42       42
  Lines        3106     3105       -1
  Branches      570      568       -2
==========================================
  Hits         2170     2170
+ Misses        936      935       -1

Impacted Files
Coverage Δ

src/extension.ts
87.15% <100.00%> (ø)

src/tekton/taskrun.ts
100.00% <100.00%> (ø)

src/tkn.ts
69.27% <100.00%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f66b0...bce5b6a. Read the comment docs.


DOC: Add examples/graphs to max_len_seq

Travis error, use np.arange instead of arange

oops, fixed and force-pushed

argh fixed

Otherwise LGTM and Travis is finally happy :)

Ok changed that too

Thanks @endolith. Using MLS for something fun I hope?

Nah, just learning. :)


https://app.tikster.net/#/user/ellaqueenella

https://app.tikster.net/#/user/ellaqueenella

Pull Request Test Coverage Report for Build 200

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 197:
0.0%

Covered Lines:
128

Relevant Lines:
128

💛  - Coveralls

https://app.tikster.net/#/user/ellaqueenella

hey ryosuke66  how can use this api ?

Also i want to know that on which platform you create app.tikster.net

Please don't use this repository to advertise your services.


model.getData(); may return undefined if called too fast

I try to build a sap.m SplitApp application with routing support. My goal is to have copy & pastable URLs, that could be passad via E-Mail from user to another. Pasting the URLs into one browser should load one specific set entry of data, say something like www.mydomain/index.html#/data/id=4711
I think I got the routing done, but I have touble getting the model data when calling my app over an URL. After hours of debugging, it seems that model.getData() may return undefined, when called too fast. You can see my issue and some coding here:
http://stackoverflow.com/questions/30189831/routing-in-sapui5-how-to-implement-passing-of-url-model-is-not-initialy-loaded
I got the clue, that I have to "wait" for model.getData() to be loaded on time.
Read:
http://scn.sap.com/thread/3490430
Or:
"SAPUI5 Developer Guide for SAP HANA" on page 123 with some "crazy coding".
Am I right? If so, this should be changed to something more robust.

According to the stackoverflow question I guess you've found a solution, right?
The dataReceived event can be used to be notified once the data has been loaded.


P.S. Happy new year

Makefile+cookiecutter was adopted as a temporary proof-of-concept project aimed to show how much we can simplify work with neuro with a higher-level abstraction. This decision was a great finding as a temporary solution, but now it grew up to a solution that does not have any advantage (at least from my point of view).
Here's arguments for using Makefile+cookiecutter and my thoughts to them in sub-items:

We assume that the users know syntax of Makefile and thus they can take a look into it to see how it works.
1.1 Please take a look into current Makefile or especially to the hyper-parameter search implementation and tell me that this code is readable and maintainable).
Makefile doesn't work on Windows
2.1 Yes, technically one can install it via cygwin or something (have you tried?). But in order to have some basic logic (see for example the same hyper-parameter search implementation) we need to use grep, tee, tail, rev -- are they available on Windows?
Updating the project.
3.1 We don't separate targets written by us from custom user-defined targets.
3.2 So technically, we put the burden of writing Makefile targets on the user -- at the moment when they will be resolving git conflicts while upgrading their project, they will leave our platform.
3.3 At least what we should do is split Makefile into several ones to hide that over-over-overcomplicated code ("black magic code" according to @mariyadavydova) so that the users don't have conflicts.
Makefile was a quick-to-implement solution.
4.1 Ha-ha, not at all. I spent from 5 to 10 times more time on struggling with dumb make problems and limitations comparing to what I would have spent with Python.
4.2 As a result -- much poorer functionality rather than it could have been written on Python.

I see the good solution to be based on neuro aliases, which @asvetlov have been working on recently:

neuro has a command group project, which works only in a specific directory similarly to git (most of git commands don't work if there's no .git/ directory)
once the project have been initialized via cookiecutter (neuro project init), the user goes to the project directory and gets the neuro project commands unlocked:
neuro project upload-data, neuro project jupyter -- all the commands available on Makefile can be available with neuro project.
To avoid writing neuro project on every command, we shorten them with neuro aliases: neuro upload-data, neuro jupyter.

Technically, this can be implemented only on top of neuro aliases only if they support arguments.
@asvetlov if you agree on this concept, I would love to work on designing neuro project abstraction on top of argumentful neuro aliases starting from January 20, 2020.
cc @astaff @mariyadavydova @dalazx.
P.S. Happy new year.

Please don't rush.
Aliases don't exist yet; even when they exist I doubt if pushing complex multi-line code into an alias is a good idea.

@ayushkovskiy Thank you for putting your thoughts on this subject together. This is indeed a complex question, and I would like to comment come of your points.

Users and Makefile: I agree that the complexity of some of the targets is way more than the others (compare uploading code to hyper-parameter tuning). I also agree that our customers are probably able to read Python code. However, I'm not sure if hyper-parameter tuning implementation inside a Python script is much more readable and maintainable.

Makefile on Windows: This is a very valid point. We rely on Unix tools, which won't work on Windows. At the same time, our stats show that 37% of the website visitors in December come from Windows (with 25% from OS X, 12% from Linux, and everything else from mobile or other platforms). We may read this as "Half of our potential users can't use some parts of our template".

Upgrading the project: Yes, there is a problem, and I still don't understand why we can't solve it with our Makefile. However, I have an assumption that this problem is an internal one. We need the template to be easily upgraded to keep our recipes up-to-date. Our customers will hardly think about it, because we keep the CLI backwards compatible, and the template nature is to be a starting point, not a framework. This assumption can only be verified over the time.

Makefile development: I understand your pain here. A Makefile is not really simple to develop when it comes to something more complex than "Several constants and several one-line targets". However, will you disagree that the result is pretty simple to use, at least when starting the work on a project?

Now, speaking of possible solutions. I assume that we should keep our project template features in mind. I would say that the template should be:

Flexible (a user may easily add their tools in the workflow or change the current tools behaviour).
Easy to read (an average ML engineer can understand the code).
Cross-platform (Linux, OS X, Windows).
Easy to develop (for us).
Upgradable (to keep the recipes up-to-date).

I put these features in order of "Most important -> least important", meaning that the comfort of our users (1, 2, 3) is more important than our own comfort (4, 5).
Now, we can evaluate each possible solution against these features. I would prefer to do that accurately later, after vacations.
In short,

Makefile is very flexible, more or less easy to read, not cross-platform, hard to develop, and more or less upgradable.
Alias-based solution seems to be way less flexible. I'm not even sure if one can support all the same functionality through parameterised aliases, having it easy to read (user side), cross-platform, and easy to develop and maintain (our side).
Python script instead of Makefile seems to be flexible and cross-platform. As for the easiness of reading and developing it, I'm not sure.

CI on Windows partially solved cross-platform issues
so far, aliases offer much less functionality than makefile (no variables, syntax is more complicated than in Makefile)
we almost completely got rid of posix utilities like tee, ... (see --tag)

So far, Makefile works fine, closing issue.


Codegen issues in Docker context

Hello!
So I'm building a Docker container of a Nuxt 3 (rc 11) project, and here are the related commands of the Dockerfile:
RUN yarn install --frozen-lockfile --non-interactive && yarn cache clean --all
RUN yarn build

However, my build fails at the first line, and I get the following errors:

Logs
$ nuxt prepare
 Nuxi 3.0.0-rc.11

  ERROR  (node:68) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
 (Use `node --trace-warnings ...` to show where the warning was created)

  ERROR
         Failed to load schema from http://localhost:1337/graphql:

        fetch failed to http://localhost:1337/graphql
        TypeError: fetch failed
    at Object.fetch (node:internal/deps/undici/undici:11118:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async UrlLoader.load (file:///srv/node_modules/@graphql-tools/url-loader/esm/index.js:587:29)
    at async file:///srv/node_modules/@graphql-tools/load/esm/load-typedefs/load-file.js:11:39
    at async Promise.all (index 5)
    at async loadFile (file:///srv/node_modules/@graphql-tools/load/esm/load-typedefs/load-file.js:9:9)
    at async file:///srv/node_modules/@graphql-tools/load/esm/load-typedefs/collect-sources.js:144:25

        GraphQL Code Generator supports:
          - ES Modules and CommonJS exports (export as default or named export "schema")
          - Introspection JSON File
          - URL of GraphQL endpoint
          - Multiple files with type definitions (glob expression)
          - String in config file

        Try to use one of above options and run codegen again.

  Failed to load schema from http://localhost:1337/graphql:

  fetch failed to http://localhost:1337/graphql
  TypeError: fetch failed
  at Object.fetch (node:internal/deps/undici/undici:11118:11)
  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  at async UrlLoader.load (node_modules/@graphql-tools/url-loader/esm/index.js:587:29)
  at async node_modules/@graphql-tools/load/esm/load-typedefs/load-file.js:11:39
  at async Promise.all (index 5)
  at async loadFile (node_modules/@graphql-tools/load/esm/load-typedefs/load-file.js:9:9)
  at async node_modules/@graphql-tools/load/esm/load-typedefs/collect-sources.js:144:25

  GraphQL Code Generator supports:
  - ES Modules and CommonJS exports (export as default or named export "schema")
  - Introspection JSON File
  - URL of GraphQL endpoint
  - Multiple files with type definitions (glob expression)
  - String in config file

  Try to use one of above options and run codegen again.

  at executeCodegen (node_modules/@graphql-codegen/cli/esm/codegen.js:322:24)
  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  at async generate (node_modules/@graphql-codegen/cli/esm/generate-and-save.js:87:25)
  at async generate (node_modules/nuxt-graphql-client/dist/module.mjs:68:10)
  at async generateGqlTypes (node_modules/nuxt-graphql-client/dist/module.mjs:279:22)
  at async setup (node_modules/nuxt-graphql-client/dist/module.mjs:332:5)
  at async Object.normalizedModule (node_modules/@nuxt/kit/dist/index.mjs:637:5)
  at async installModule (node_modules/@nuxt/kit/dist/index.mjs:456:3)
  at async initNuxt (node_modules/nuxt/dist/index.mjs:1606:7)
  at async loadNuxt (node_modules/nuxt/dist/index.mjs:1635:5)
  at async loadNuxt (node_modules/@nuxt/kit/dist/index.mjs:732:19)
  at async Object.invoke (node_modules/nuxi/dist/chunks/prepare.mjs:30:18)
  at async _main (node_modules/nuxi/dist/cli.mjs:50:20)

  Error:
  Failed to load schema from http://localhost:1337/graphql:

  fetch failed to http://localhost:1337/graphql
  TypeError: fetch failed
  at Object.fetch (node:internal/deps/undici/undici:11118:11)
  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  at async UrlLoader.load (node_modules/@graphql-tools/url-loader/esm/index.js:587:29)
  at async node_modules/@graphql-tools/load/esm/load-typedefs/load-file.js:11:39
  at async Promise.all (index 5)
  at async loadFile (node_modules/@graphql-tools/load/esm/load-typedefs/load-file.js:9:9)
  at async node_modules/@graphql-tools/load/esm/load-typedefs/collect-sources.js:144:25

  GraphQL Code Generator supports:
  - ES Modules and CommonJS exports (export as default or named export "schema")
  - Introspection JSON File
  - URL of GraphQL endpoint
  - Multiple files with type definitions (glob expression)
  - String in config file

  Try to use one of above options and run codegen again.

  at loadSchema (node_modules/@graphql-codegen/cli/esm/load.js:42:15)
  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  at async node_modules/@graphql-codegen/cli/esm/codegen.js:191:69
  at async node_modules/@graphql-codegen/cli/esm/codegen.js:190:56
  at async node_modules/@graphql-codegen/cli/esm/codegen.js:63:21
  at async Task.run (node_modules/listr2/dist/index.js:960:11)
  at async node_modules/p-map/index.js:57:22

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

I don't know why i get the same error messages.
Please note that without a Docker context, everything works, but it somehow doesn't when I'm running my commands outside of it.
My nuxt.config.ts file looks like so:
import { defineNuxtConfig } from 'nuxt/config'

export default defineNuxtConfig({
    modules: [
        'nuxt-graphql-client',
    ],

    runtimeConfig: {
        public: {
            APP_ENV: process.env.APP_ENV,
            PATRIMOINE_API: process.env.PATRIMOINE_API,
            GQL_HOST: process.env.GRAPHQL,
            API: process.env.API,
            URL: process.env.URL,
        }
    },

    css<EMAIL_ADDRESS>})

and my .graphqlconfig looks like so:
{
  "name": "Untitled GraphQL Schema",
  "schemaPath": "gql/schema.graphql",
  "extensions": {
    "endpoints": {
      "Default GraphQL Endpoint": {
        "url": "http://api:1337/graphql",
        "headers": {
          "user-agent": "JS GraphQL"
        },
        "introspect": true
      }
    }
  }
}

api:1337/graphql should be available but I can't confirm since the Docker build fails before I can make sure of it is available, I managed to run a curl command with a graphql payload successfully. So I tried to give GraphQL an introspection schema (JSON and .graphql) but it seems it couldn't find it in gql and at the project's root.
Lastly, I tried to install nuxt-graphql-client@edge and to add the following line in the nuxt.config.ts as per #215:
'graphql-client'.codegen = false,

// Also tried with

'graphql-client': {
    codegen: false // type 'false' has no common property with the type GqlCodegen
},

What am doing wrong?
Thank you in advance

The error you provided indicates that codegen is unable to run the introspection query within the Docker container. Can you confirm that the docker container does infact have network access to your endpoint? You mentioned that you were able to run a query via curl, was that done within the docker container or your local machine?

Lastly, I tried to install nuxt-graphql-client@edge and to add the following line in the nuxt.config.ts as per https://github.com/Diizzayy/nuxt-graphql-client/issues/215:

As for this, I've recently released v0.2.0 which should allow codegen to be disabled completely.

Can you confirm that the docker container does infact have network access to your endpoint?

Yes, they need to share the same network anyway

You mentioned that you were able to run a query via curl, was that done within the docker container or your local machine

It was inside the container, my api has the service name "api" and is available at the port 1337, so I ran a curl command hitting http://api:1337 with a random GraphQL query, and I got a response, which is why I created an issue 🥲

As for this, I've recently released v0.2.0 which should allow codegen to be disabled completely.

I'll look into it, thanks!

Update
So, disabling the codegen works, however, it of course makes my GraphQL request not work at all afterwards (I should have guessed it haha).
However, I managed to generate a introspection schema, and told Nuxt to use it, so I could run my commands without trouble. I still have to find a way to automate it, but it's way better than nothing.
So there seems to be a problem with how the codegen fetchs the schema while running yarn install.
Huge thanks for your support and for this plugin in any case!

@Drillan767 Thanks for the update.

however, it of course makes my GraphQL request not work at all afterwards (I should have guessed it haha).

I find this to be even more strange. I'm currently taking the time to put together a docker reproduction, so hopefully I'll have some answers soon.


HTML Preview Error

So, I noticed that the HTML preview has stopped working, although having worked in previous updates. Here are a few screenshots showing this.

I could not reproduce it. Are the two files under the same directory? Did you try refreshing the browser?

Yes, they are, and I tried refreshing the browser.

Does this still occur on the latest release?

Does this still occur on the latest release?
As far as I can tell through testing, yes it is.

Does this still occur on the latest release?

I guess i did:
<link rel="stylesheet" type="text/css" ref="theme.css">

instead of:
<link rel="stylesheet" type="text/css" href="theme.css"

I will close this issue as my mistake. Sorry...


Error when launching demo.py

When I run demo.py, an error occurred as follows:
Traceback (most recent call last):
File "/media/iruma/Data/AIR/radar/OpenPCDet/test/demo.py", line 18, in
from pcdet.datasets import DatasetTemplate
File "/home/iruma/OpenPCDet/pcdet/datasets/init.py", line 15, in
from .argo2.argo2_dataset import Argo2Dataset
File "/home/iruma/OpenPCDet/pcdet/datasets/argo2/argo2_dataset.py", line 15, in
from .argo2_utils.so3 import yaw_to_quat, quat_to_yaw
File "/home/iruma/OpenPCDet/pcdet/datasets/argo2/argo2_utils/so3.py", line 10, in
def quat_to_mat(quat_wxyz: Tensor) -> Tensor:
File "/usr/local/lib/python3.10/dist-packages/torch/jit/_script.py", line 1381, in script
fn = torch._C._jit_script_compile(
File "/usr/local/lib/python3.10/dist-packages/torch/jit/_recursive.py", line 1010, in try_compile_fn
return torch.jit.script(fn, _rcb=rcb)
File "/usr/local/lib/python3.10/dist-packages/torch/jit/_script.py", line 1381, in script
fn = torch._C._jit_script_compile(
RuntimeError:
cannot statically infer the expected size of a list in this context:
File "/usr/local/lib/python3.10/dist-packages/kornia/geometry/conversions.py", line 553
# this slightly awkward construction of the output shape is to satisfy torchscript
output_shape = [*list(quaternion.shape[:-1]), 3, 3]
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
matrix = matrix_flat.reshape(output_shape)

'quaternion_to_rotation_matrix' is being compiled since it was called from 'quat_to_mat'
File "/home/iruma/OpenPCDet/pcdet/datasets/argo2/argo2_utils/so3.py", line 19
(...,3,3) 3D rotation matrices.
"""
return C.quaternion_to_rotation_matrix(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
quat_wxyz, order=C.QuaternionCoeffOrder.WXYZ
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
)
It seems that there is something wrong in module kornia. How to solve it?

change the kornia version down to 0.6.5 may works
pip install kornia==0.6.5

Hi @IrumaMegumi
As mentioned by thiesymon, you need to downgrade your kornia version.
For my case, I need to downgrade to pip install kornia==0.5.8 for it to work,
Issue 1470: Colab results #1470

can you help to solve my isusse submited todayFrom Thiesy〽在 2023年10月16日，17:53，Wong Yi Jie @.***> 写道：
Hi @IrumaMegumi
As mentioned by thiesymon, you need to downgrade your kornia version.
For my case, I need to downgrade to pip install kornia==0.5.8 for it to work,
Issue 1470: Colab results #1470
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

Thanks. Version 0.5.8 works!


Split out interface into Sosa.mli

At 2164 lines maybe it's time?

sosa.mli wouldn't really reduce size since most of it woudl have to be copied in sosa.ml (it's all module type definitions).
we need a sosa_{api,interface,module_types}.ml (or mli), and then maybe one file-pair per implmentation?
then we pack it all into Sosa ?

Agreed, that would be better. I'll try that out.


Unable to run flutter_markdown example

Steps to Reproduce
Run flutter run -v with flutter_markdown example (Nexus 7 (2013) Android 4.4.4)
https://github.com/flutter/flutter/blob/master/packages/flutter_markdown/example/demo.dart
It will show error

Flutter Doctor
[✓] Flutter (on Mac OS, channel unknown)
• Flutter at /usr/local/flutter/flutter
• Framework revision 8a823328ca (17 hours ago), 2016-09-29 08:59:43
• Engine revision 3551e7a48e
• Tools Dart version 1.20.0-dev.5.0
[✓] Android toolchain - develop for Android devices (Android SDK 24.0.2)
• Android SDK at /Users/jimmy/Library/Android/sdk
• Platform android-24, build-tools 24.0.2
• Java(TM) SE Runtime Environment (build 1.8.0_45-b14)
[✓] iOS toolchain - develop for iOS devices (Xcode 8.0)
• XCode at /Applications/Xcode.app/Contents/Developer
• Xcode 8.0, Build version 8A218a
[✓] Atom - a lightweight development environment for Flutter
• flutter plugin version 0.2.5
• dartlang plugin version 0.6.39
[✓] Connected devices
• Nexus 7 • 0874da9c • android-arm
Logs and Crash Reports
  29 ms • I/flutter : ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
   2 ms • I/flutter : The following assertion was thrown building RawGestureDetector([GlobalKey 587447520]; state:
   0 ms • I/flutter : RawGestureDetectorState(127753856; gestures: vertical drag; behavior: opaque)):
   0 ms • I/flutter : inheritFromWidgetOfExactType(Theme) was called before _MarkdownBodyRawState.initState() completed.
   0 ms • I/flutter : When an inherited widget changes, for example if the value of Theme.of() changes, its dependent
   0 ms • I/flutter : widgets are rebuilt. If the dependent widget's reference to the inherited widget is in a constructor
   0 ms • I/flutter : or an initState() method, then the rebuilt dependent widget will not reflect the changes in the
   0 ms • I/flutter : inherited widget.
   0 ms • I/flutter : Typically references to to inherited widgets should occur in widget build() methods. Alternatively,
   4 ms • I/flutter : initialization based on inherited widgets can be placed in the dependenciesChanged method, which is
2295 ms • I/flutter : called after initState and whenever the dependencies change thereafter.
  70 ms • I/flutter : When the exception was thrown, this was the stack:
   0 ms • I/flutter : #0      StatefulElement.inheritFromWidgetOfExactType.<anonymous closure> (package:flutter/src/widgets/framework.dart:2827:9)
   0 ms • I/flutter : #2      StatefulElement.inheritFromWidgetOfExactType (package:flutter/src/widgets/framework.dart:2825:12)
   0 ms • I/flutter : #3      Theme.of (package:flutter/src/material/theme.dart:43:27)
   0 ms • I/flutter : #4      MarkdownBody.createDefaultStyle (package:flutter_markdown/src/markdown.dart:90:53)
   0 ms • I/flutter : #5      _MarkdownBodyRawState._buildMarkdownCache (package:flutter_markdown/src/markdown_raw.dart:156:69)
   2 ms • I/flutter : #6      _MarkdownBodyRawState.initState (package:flutter_markdown/src/markdown_raw.dart:135:5)
   0 ms • I/flutter : #7      StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:2761:14)
   0 ms • I/flutter : #8      ComponentElement.mount (package:flutter/src/widgets/framework.dart:2647:5)
   0 ms • I/flutter : #9      Element.inflateWidget (package:flutter/src/widgets/framework.dart:2139:14)
   0 ms • I/flutter : #10     Element.updateChild (package:flutter/src/widgets/framework.dart:1970:12)
   0 ms • I/flutter : #11     SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:3436:14)
   0 ms • I/flutter : #12     Element.inflateWidget (package:flutter/src/widgets/framework.dart:2139:14)
   0 ms • I/flutter : #13     Element.updateChild (package:flutter/src/widgets/framework.dart:1970:12)
   0 ms • I/flutter : #14     SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:3436:14)
   0 ms • I/flutter : #15     Element.inflateWidget (package:flutter/src/widgets/framework.dart:2139:14)
   0 ms • I/flutter : #16     Element.updateChild (package:flutter/src/widgets/framework.dart:1970:12)
   0 ms • I/flutter : #17     SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:3436:14)

Thanks for the report!  We added this assert to catch bugs and it looks like the markdown example has an instance of this bug.
/cc @Hixie

also cc @HansMuller who added this assert.
My guess is that to fix this we just have to move the call to _buildMarkdownCache from initState to dependenciesChanged in this file:
https://github.com/flutter/flutter/blob/master/packages/flutter_markdown/lib/src/markdown_raw.dart

See also: https://github.com/flutter/flutter/issues/6166


Spike: validate CEL in (Cluster)AdmissionPolicy's spec.matchConditions

As it stands, instantiating one of our policies with matchConditions will succeed, but the underlying Webhook.configuration.matchConditions may fail. This would mean that the webhook would not be created and the policy would sit in pending forever.
We could use the same CEL validation from ValidatingAdmissionPolicies for our own usage of spec.matchConditions in (Cluster)AdmissionPolicies to move the CEL validation earlier in the process.
Acceptance criteria

Investigate  the Kubernetes codebase and understand how the controller performs CEL validation for VAPs (seems to be here).
If simple, implement such CEL validation for our own spec.matchConditions in (Cluster)AdmissionPolicies, including tests.
If not, specify the acceptance criteria needed.

Update: we could import and use this function. There's the equivalent for mutating configurations too

It seems that consuming that kubernetes package is not trivial, see https://github.com/kubernetes/kubernetes/issues/79384#issuecomment-505627280. Basically, we need to replace all the unversioned package dependencies.
For that, we can use https://github.com/kubernetes/kubernetes/issues/79384#issuecomment-521493597.

Current progress at https://github.com/viccuad/kubewarden-controller/commits/matchconds-verify/ .


Added 'runas' verb to the options

While reviewing KBs for archival, we came across - https://support.microsoft.com/en-us/help/981778/how-to-self-elevate-an-application-to-a-high-privilege-level-under-uac - this in turn refers to https://code.msdn.microsoft.com/windowsapps/CppUACSelfElevation-981c0160#content which is also being retired. I am submitting this change based on my discussion with Dave Anderson (Sr.EE in Windows Dev Support)

@ramakoni1 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Fixed for working with Ubuntu 22.04 in docker containers; cd Containe…

Fixed for working with Ubuntu 22.04 in docker containers;
cd Containers/;
cp -r docker-ubuntu-2{1,2}.04/
perl -pi -e 's/21.04/22.04/g' docker-ubunut-22.04/Dockerfile;
Voila, works to run docker container on Ubuntu 22.04;

bump

cc @brandon-rhodes

Thanks for the bump! You've caught me on a good day: with other obligations evening out, I'm sitting down this week to look over my open source projects.
I could quibble with the line NAME=xephem-ubuntu-21.04 in this PR, but given that I've kept you waiting since October, how about I go ahead and fix it myself!

I'm curious what data these containers include. I assume the text catalogs,
but what about the guide stars?
On Mon, Feb 5, 2024 at 11:49 AM Brandon Rhodes @.***>
wrote:

Merged #81 https://github.com/XEphem/XEphem/pull/81 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/XEphem/XEphem/pull/81#event-11708533611, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AC37YZDZZSBFVVDVW3A3U7DYSESSFAVCNFSM6AAAAAA5VASCJKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG4YDQNJTGM3DCMI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Figure out and document the thread-safety story

In cairo
Many objects in cairo are manipulated through pointer types like cairo_surface_t * and are reference-counted, with functions like cairo_surface_reference and cairo_surface_destroy. (Despite what the name suggests, the later does not free the object unless the refcount reaches zero.)
Unfortunately I couldn’t find any documentation about what is considered correct use of these objects or not, in a multi-threaded application.
I think we can conservatively assume that cairo should be thread-safe when any object created through the public API is only manipulated on the same thread it was created on. Some commit messages and entries in the NEWS file mention for example adding a mutex around the global font cache.
However it is not clear to me what objects can be shared across threads under what conditions, if at all. The NEWS file includes “Making reference counting thread safe” which I assume is similar to using Rust’s Arc instead of Rc, which would be relevant when objects are shared.
In cairo-rs, status quo
Cairo objects are exposed in the Rust API as wrapper structs that implement Clone and Drop by incrementing and decrementing the reference count.
As of cairo-rs 0.6.0 (since PR https://github.com/gtk-rs/cairo/pull/233) most methods take a shared &self rather than exclusive &mut self. This reflects the fact even with exclusive (&mut) access to a reference (copy of the pointer) to an object, there can be other references/pointers to the same object so access is effectively shared.
These structs wrapper are !Sync and !Send as a side-effect of containing a *mut raw pointer. I think it would be good to have explicit negative impls, to show intent to someone reading the code and to have rustc error messages mention e.g. cairo::Surface instead of *mut cairo_sys::cairo_surface_t. But negative impls are not stable yet: https://github.com/rust-lang/rust/issues/13231.
All of the above is not obvious, as shown by https://github.com/gtk-rs/cairo/issues/192. It would be good to have high-level documentation that explains it. (By the way, I’ve found https://github.com/gtk-rs/lgpl-docs but it’s not clear how it relates to this repo. Does the release script use whatever is the latest docs commit at the time? Are new docs written for Rust bindings also under LGPL?)
More flexibility in cairo-rs?
There’s desire to do more with threads: https://github.com/gtk-rs/cairo/issues/175, https://github.com/gtk-rs/cairo/issues/226. If we can get answers on what is considered correct use of cairo’s C API or not (and ideally have them documented upstream), maybe we can relax these !Send and !Sync negative impls to some extent?
Or, one might imagine a Send wrapper that checks if the reference count is 1. However some object might internally own references to other objects, and the latter could end up being incorrectly shared across threads. For example, the existence of cairo_get_target shows that a cairo_t context owns a reference to a cairo_surface_t.

https://developer.gnome.org/gdk3/stable/gdk3-Threads.html

GLib is completely thread safe (all global data is automatically locked), but individual data structure instances are not automatically locked for performance reasons. So e.g. you must coordinate accesses to the same GHashTable from multiple threads.

I'm confused. Doesn't this mean that it should be possible to implement a mechanism for sharing data across threads in a safe manner?

https://developer.gnome.org/gdk3/stable/gdk3-Threads.html

GLib is completely thread safe (all global data is automatically locked), but individual data structure instances are not automatically locked for performance reasons. So e.g. you must coordinate accesses to the same GHashTable from multiple threads.

I'm confused. Doesn't this mean that it should be possible to implement a mechanism for sharing data across threads in a safe manner?

You mean like channels? Which are also provided?

You mean like channels? Which are also provided?

Sorry, I was not specific enough. With "data", I meant objects like GdkPixbuf or PopplerDocument. As far as I understand it, channels are no help here because they require the data to be Send.

Sorry, I was not specific enough. With "data", I meant objects like GdkPixbuf or PopplerDocument. As far as I understand it, channels are no help here because they require the data to be Send.

To be exact, the objects aren't thread-safe, but I see no issue about sending their data though.

To be exact, the objects aren't thread-safe, but I see no issue about sending their data though.

GdkPixbuf values and others are neither Send nor Sync unfortunately. Only very few types are and a big problem here is reference counting. Almost all of the types would be Send if they were not reference counted, but for a reference counted value to be Send it must also be Sync at the same time.
What's the specific problem you're trying to solve @piegamesde ? Maybe worth discussing that on IRC or the GNOME discourse in more detail?

GdkPixbuf values and others are neither Send nor Sync unfortunately. Only very few types are and a big problem here is reference counting. Almost all of the types would be Send if they were not reference counted, but for a reference counted value to be Send it must also be Sync at the same time.
What's the specific problem you're trying to solve @piegamesde ? Maybe worth discussing that on IRC or the GNOME discourse in more detail?


Project Import is broken

In latest release the project import is broken

pushed fix and will be in next release


[BUG] Coloring does not work in PyCharm

Just checked - it seems to be a PyCharm problem, I will report it there, so this report is just FYI for rich users who use PyCharm.
It works in the PyCharm terminal (command line), but not inside the stdout pane of PyCharm.
Reproduction
Replace print() statement with console.print(string, style='bold red'). The string is printed, but no coloring.
from rich.console import Console
console = Console()
console.print('==> Mismatches were found in one or more platforms <==', style='bold red')

Windows 10, PyCharm Community (lastest), Python 3.8, Rich 5.0.0

It could be a problem with auto-detection.
What does the following print in PyCharm?
print(console.color_system)

In the PyCharm stdout window, as you've suspected, it prints 'None' (and no color).
In the PyCharm terminal, it prints 'windows' (and works)

Interesting. That suggest the stdout window is not an embedded console. Rich will disable color if it detects it is not connected to a real terminal.
You could try this:
console = Console(color_system="windows")

That will force Rich to write color, but if PyCharm can't handle it, you may end up with garbage.

Thanks - it works. Since I only use Windows for this project, this workaround is good enough. Should I submit a bug to PyCharm?

Might be worth filing a bug report. Tell them that isatty() is returning False.

@akrk1986 going to close this one, but let me know if you get a response from PyCharm devs...

Will let you know. Thanks a lot for the quick response and great package!

Just FYI, bug was accepted by PyCharm: Issue PY-43860

Hi Will,
Here is the answer I got from PyCharm:
"Hi, have you tried to enable emulate terminal in output console option in run/debug configuration? This should do the trick."
It seems that the non-terminal behavior is the default in PyCharm.
IMHO, it's worth mentioning in the rich documentation, perhaps under 'known issues'.
Unfortunately, I don't have time to submit a PR for that.
Keep up the good work!
Amir

@akrk1986 Thank you. I have used for the first time and was wondering why no progress bar was visible at all - setting the emulation fixes this. WOuld  be great if this is in the docs.

Hi Will,
Here is the answer I got from PyCharm:
"Hi, have you tried to enable emulate terminal in output console option in run/debug configuration? This should do the trick."
It seems that the non-terminal behavior is the default in PyCharm.
IMHO, it's worth mentioning in the rich documentation, perhaps under 'known issues'.
Unfortunately, I don't have time to submit a PR for that.
Keep up the good work!
Amir

You're right, please add this to the docs.

Hi Will,
Here is the answer I got from PyCharm:
"Hi, have you tried to enable emulate terminal in output console option in run/debug configuration? This should do the trick."
It seems that the non-terminal behavior is the default in PyCharm.
IMHO, it's worth mentioning in the rich documentation, perhaps under 'known issues'.
Unfortunately, I don't have time to submit a PR for that.
Keep up the good work!
Amir

You're right, please add this to the docs.

It's on the first page in a blue box. https://rich.readthedocs.io/en/latest/introduction.html

It's on the first page in a blue box. https://rich.readthedocs.io/en/latest/introduction.html

It's on the first page in a blue box. https://rich.readthedocs.io/en/latest/introduction.html

Thanks 👍🏻  I meant in github but I guess that'll do as well.
Out of curiosity, is there no easy way to make it work out of the box? The other libs I used before usually worked in PyCharm without the need for emulate in terminal.

It's on the first page in a blue box. https://rich.readthedocs.io/en/latest/introduction.html

Thanks 👍🏻  I meant in github but I guess that'll do as well.
Out of curiosity, is there no easy way to make it work out of the box? The other libs I used before usually worked in PyCharm without the need for emulate in terminal.

Not without breaking things for other users.

Not without breaking things for other users.

FYI, per https://youtrack.jetbrains.com/issue/PY-29204 IntelliJ removed this feature. There is no such option in version 2021.2.3 and no indication of when it will come back. Are there any other workarounds?

I'm also unable to make this work in PyCharm in Windows, and unsure how to apply Will's suggestion:
console = Console(color_system="windows")

Hi, In PyCharm 2022.1.3 seems there is no emulate terminal in output console for run configurations. Still have that problem with red logs in the console. Does anyone know how to solve this problem?

@AntonyMilneQB see https://stackoverflow.com/questions/20333674/pycharm-logging-output-colours. I think if you change your streamhandler to explicitly write to stdout it should get rid of the red logs.

This solved the problem for me too.
Note: Pycharm moved that option to "Modify option" in the Run Config menu with their UI rework.

Emulate terminal works so that we have colors, but it doesnt work as debug console anymore, which is quite annoying ):

Emulate terminal works so that we have colors, but it doesnt work as debug console anymore, which is quite annoying ):

@Liquidmasl unfortunately this is something PyCharm has to fix, not a Textualize issue.


fix: android hooks error

Based on https://github.com/OpenNative/open-native/issues/31#issue-2424587402 solution.
Fix: https://github.com/OpenNative/open-native/issues/31
CC: @wjchoi87

Hi @ammarahm-ed , this needs the same thing on the iOS side, it's exactly the same change

Hi @ammarahm-ed , this needs the same thing on the iOS side, it's exactly the same change

I will make the changes on iOS side too.