is there a way to use it in python script?

Hi:) I need to slice my images accordingly to some kind of algorithm, so terminal usage is cumbersome.
Is there a way to do it similar to this pseudocode?
from split-image import Slicer

list_of_slices = Slicer('myimage.jpg', rows_num, col_num)

Hey, thanks for the feedback.
I just pushed an update (v1.6.1) which should let you do this:
from split_image import split_image

split_image(image_path, rows, cols, should_square, should_cleanup, [output_dir])
# e.g. split_image("bridge.jpg", 2, 2, True, False)

Try it out and let me know!

Thanks, I installed 1.6.1, but when I try to import the package :

Import "split_image" could not be resolvedPylance[reportMissingImports]

That is probably an issue with your interpreter. Ignore the message and try to run the script. Does it work?
I also have seen the same error when I am using VS Code, and it's because I use the wrong Python interpreter. You can try:

Cmd+Shift+P > Python> Select Interpreter.
Select the proper interpreter. For me, it's in homebrew's installation, since pip was installed there.

You are right, my fault. It was installed in my anaconda interpreter path, I changed it and now it's visible, and works:)
But even when I set flag cleanup=True, there is still copy of my original image with name: '[image]_square.jpeg'. Is there a way to remove this automatically?

If you have set the squared flag, the tool also generates its squared version. The clean up flag only removes the original image, as the user may need the squared version.
If you feel like there should be an additional option for removing the squared image too, feel free to open a new issue!


Unwrapping multilevel list

Hi.
Currently, when I try to unwrap multilevel list
For example, a list like this:

a

b

c

d

plugin just unwrap the first one item. Please, watch the slideshow below:

What do you think, if plugin would unwrap the whole list structure? The same behavior you can find in Google Docs, Pages and Word.

@Soreine Could you write your feedback about that improvement? If it is ok, I could prepare pull for that.

I think we could expose a different transform than unwrapList to do that. It is good to keep unwrapList available for operation like Backspace at the beginning of an item.
If we want to match Google Docs behavior, we should call the new transform toggleList. Because on Google Docs, you go from
- 1
- 2
  - 2.1
  - 2.2
- 3

to
  1
  2
    2.1
    2.2
  3

No more bullets, but there is still some indentation. And toggling again goes back to the initial list.
I don't know how we could do that in Slate (we need to define "indent").
Would you like instead a transform that flatten all the blocks in a nested list ?

Hi, @Soreine.
Thank you for your answer and sorry that I didn't answer so long time.
As for me, your explanation and suggestion sounds good. Could you a little bit describe your question?
Do you mean, that list will be?
Before:
- 1
- 2
  - 2.1
  - 2.2
- 3

After toggling:
1
2
2.1
2.2
3


value cannot be null

im having an issue when i click on go its says value cannot be null and goes back into the menu after i click ok i have noticed i have no com ports i dont know if thats the issue but it might be

Seems like it would be related to that. The error message should be better though.

hello i figured out how to fix that all you do is add a com port i forgot
how but its in windows settings just look up how to add com ports on
windows or something similar that should help
On Sat, Aug 22, 2020 at 2:01 PM Zenshu<EMAIL_ADDRESS>wrote:

I am having the same issue, all com ports are empty and there is nothing
to select so I cannot set a com port and then get the value cannot be null
error because no com port was set.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jaburns/NintendoSpy/issues/74#issuecomment-678679048,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANZJLWT5YHYPOTTGX5SAJETSCAIZXANCNFSM4O7I7DHA
.


Hash Table: Roman to Integer in Javascript #394 added

roman_to_integer.js added with easy to understand comments.

Update time and space complexity, pr is good

Do I need to optimize time and space complexity?

Update time and space complexity, pr is good

Do I need to optimize time and space complexity? Or just make Time complexity and space complexity to O(1) becouse s.length is <=15 and no of Roman characters is constant? I guess you are talking about the second one . Please clarify 🙏.

Just update what your programs time nd space complexity is

updated @akgmage


Add manifest.json

So that it can be added to Home Screen, like a real game, and also used while offline.

manifest.json is not enough, a service worker has to be registered as well


Support pir

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: 0x3878f:white_check_mark: qzylalala:x: risemeup1You have signed the CLA already but the status is still pending? Let us recheck it.


Terminal sticky scroll can show up at the bottom of the terminal for tasks

I think this is related to sticky scroll updating its position when the terminal is in the background.
Repro:

Open vscode repo
Open a terminal
Ctrl/cmd+shift+b

Having trouble reproducing.


Template configuration fails with lazy.nvim

I tried porting your configuration to the lazy.nvim package manager. This is what I got:
return {
  "lmburns/lf.nvim",
  dependencies = {
    {
      "akinsho/toggleterm.nvim",
      version = "*",
      config = true, -- Runs require("toggleterm").setup()
    },
  },
  config = function()
    vim.g.lf_netrw = 1
    require("lf").setup()
    vim.api.nvim_create_autocmd({
      event = "User",
      pattern = "LfTermEnter",
      callback = function(a)
        vim.api.nvim_buf_set_keymap(a.buf, "t", "q", "q", { nowait = true })
      end,
    })
  end,
}

The one bit that seems to be having issues is the autocmd. Without it, nvim launches fine (but lf doesn't seem to work). With it, nvim gives me the following error at launch:
Failed to run `config` for lf.nvim

/home/master/.config/nvim/lua/ben/plugins/lf.lua:13: Expected 2 arguments

# stacktrace:
  - lua/ben/plugins/lf.lua:13 _in_ **config**
  - lua/ben/lazy.lua:13
  - init.lua:2
Press ENTER or type command to continue

I had the same. the event "User"  should be the first argument in the autocommand, and the rest of the array the second. In the default code the event is defined in the array, which causes the error. This code worked for me:
{
"lmburns/lf.nvim",
config = function()
-- This feature will not work if the plugin is lazy-loaded
vim.g.lf_netrw = 1
    require("lf").setup({
        escape_quit = false,
        border = "rounded",
     })
    vim.api.nvim_create_autocmd(
         "User",{
        pattern = "LfTermEnter",
        callback = function(a)
            vim.api.nvim_buf_set_keymap(a.buf, "t", "q", "q", {nowait = true})
        end,
    })
end,
requires = {"toggleterm.nvim"}

}


Spike - Page templates

Page template? include stepper? starter component for the layout of the page. How can we create full page template (demo page), thing also in design. (design and dev work together on the page template)
As a: Design system team
I want: Provide DDI service teams with good foundations to build their service on top of
so that: We have more adoption of and compliance to the design system
Dependant on the completion of #599
Acceptance criteria

[ ] Survey and categorize the page templates currently in use by DDI service teams

Determine how to select and prioritize the page templates to be worked on using one of the following methods

[ ] Reach out to team to understand the value of templates or other artifacts created by the design team
[ ] Create/determine the criteria for "value" (the value provided to teams)

Next steps

[ ] TBD depending on what comes out of the outreach session

Presentable outcomes
N/A
Sprint Ready Checklist

Acceptance criteria defined
Team has defined steps to satisfy acceptance criteria
Acceptance criteria is verifiable / testable
External / 3rd Party dependencies identified

Related issues:
Resources:
Design sharing board in Miro

I think there's a really nice opportunity to link this into better design documentation as well: better design documentation with more examples -> page templates made to show each component in a realistic, interactive context

I put some thoughts and notes together on this.
It would be great to have a discussion as a team once everyone has time to go through.
Templates and Pages

As discussed this story will be edited/updated and moved back to "in progress" to be finished in the next sprint.


Research spinbutton accessibility

Description
read this article and research spinbutton accessibility
modify component if necessary
Problem Statement/Justification
none
Proposed Solution or API
No response
Alternatives
No response
Are you willing to participate in implementing this feature and create a pull request include the implementation?
None
Additional Information
No response

Keyboard Interaction

[ ] Up Arrow: Increases the value.
[ ] Down Arrow: Decreases the value.
[ ] Home: If the spinbutton has a minimum value, sets the value to its minimum.
[ ] End: If the spinbutton has a maximum value, sets the value to its maximum.
[ ] Page Up (Optional): Increases the value by a larger step than Up Arrow.
[ ] Page Down (Optional): Decreases the value by a larger step than Down Arrow.
If the spinbutton text field allows directly editing the value, the following keys are supported:

Standard single line text editing keys appropriate for the device platform (see note below).
Printable Characters: Type characters in the textbox. Note that many implementations allow only certain characters as part of the value and prevent input of any other characters. For example, an hour-and-minute spinner would allow only integer values from 0 to 59, the colon ':', and the letters 'AM' and 'PM'. Any other character input does not change the contents of the text field nor the value of the spinbutton.

WAI-ARIA Roles, States, and Properties

The focusable element serving as the spinbutton has role spinbutton. This is typically an element that supports text input.
The spinbutton element has the aria-valuenow property set to a decimal value representing the current value of the spinbutton.
The spinbutton element has the aria-valuemin property set to a decimal value representing the minimum allowed value of the spinbutton if it has a known minimum value.
The spinbutton element has the aria-valuemax property set to a decimal value representing the maximum allowed value of the spinbutton if it has a known maximum value.
If the value of aria-valuenow is not user-friendly, e.g., the day of the week is represented by a number, the aria-valuetext property is set on the spinbutton element to a string that makes the spinbutton value understandable, e.g., "Monday".
If the spinbutton has a visible label, it is referenced by aria-labelledby on the spinbutton element. Otherwise, the spinbutton element has a label provided by aria-label.
The spinbutton element has aria-invalid set to true if the value is outside the allowed range. Note that most implementations prevent input of invalid values, but in some scenarios, blocking all invalid input may not be practical.

I think button in datepicker is applicable in @yamada-ui/calendar.

@setodeve
please double check

@koralle
above checklist should be fixed at https://github.com/yamada-ui/yamada-ui/issues/1734, https://github.com/yamada-ui/yamada-ui/issues/1919 and so on ?

@nakayan5 @illionillion
Spinbutton includes NumberInput in YamadaUI?
https://yamada-ui.github.io/yamada-ui/?path=/story/components-forms-numberinput--basic

@setodeve
good point

@setodeve
please double check


[bug] Common crashes w/ Exit code: 1 Details: write /dev/stdout: broken pipe

The service lnd has crashed with the following exit code: 1 Details: write /dev/stdout: broken pipe
Occurs several times per day
EOS v0.3.1
LND v<IP_ADDRESS>
Lightning Terminal seems to crash an hour after this occurs.  No further symptoms noticed at this time

@kn0wmad @dr-bonez is this still an issue? can we close?

@kn0wmad @dr-bonez  can we close this?

I've not run into it or heard of a support call.  I'm closing for now, can re-open if need be


Ability to Edit other people's messages, even though it doesn't stick, seems odd

Currently, if I long hold on the message of another user, an Edit option appears and you can make changes to the text. This kinda just feels real odd, as I wouldn't imagine I should ever be able to edit someone else's messages.
I can't actually edit their messages, and no changes I make are saved, which is what I would expect. But just feels weird the first time you try it and see it.
Additionally, I can't delete other people's messages from the chat, but I feel like i should be able to do that, if I don't want to see what they sent me in my stream any longer.

Cc: @chrisnojima

this was fixed https://github.com/keybase/client/pull/6694


Function to load covidexitstrategy

This appears to be working, for the most part. It will fail sporadically with some unclear reason, but it's worked for the past two days without me having changed anything. Let me know if anything in the code is unclear or needs updating.
Some notes (that I will probably stick in a README somewhere at some point).

The code will run every midnight EST.
Each region will have a timestamp node updated with the time it was last updated. Viewing this node will let you know if it ran properly.

To run manually, visit the cloud scheduler dashboard. Click RUN NOW.

You can also see information about the run by going to the Firebase console. Click Functions. Click Logs.

┆Issue is synchronized with this Trello card by Unito

Reminder to add note to README ✨ @reptile18

I tried an additional re-run of the workflows after Brock's attempt and still seeing
Path does not exist /home/runner/work/covidcanidoit/covidcanidoit/tests/e2e/screenshots/
Exit code 1 returned from process: file name '/home/runner/runners/2.274.2/bin/Runner.PluginHost', arguments 'action "GitHub.Runner.Plugins.Artifact.PublishArtifact, Runner.Plugins"'.
Path does not exist /home/runner/work/covidcanidoit/covidcanidoit/tests/e2e/videos/
Exit code 1 returned from process: file name '/home/runner/runners/2.274.2/bin/Runner.PluginHost', arguments 'action "GitHub.Runner.Plugins.Artifact.PublishArtifact, Runner.Plugins"'.

🤔 Not sure why it thinks tests/e2e/* doesn't exist..

Reminder to add notes to README ✨ @reptile18

Done!

I tried an additional re-run of the workflows after Brock's attempt and still seeing
Path does not exist /home/runner/work/covidcanidoit/covidcanidoit/tests/e2e/screenshots/
Exit code 1 returned from process: file name '/home/runner/runners/2.274.2/bin/Runner.PluginHost', arguments 'action "GitHub.Runner.Plugins.Artifact.PublishArtifact, Runner.Plugins"'.
Path does not exist /home/runner/work/covidcanidoit/covidcanidoit/tests/e2e/videos/
Exit code 1 returned from process: file name '/home/runner/runners/2.274.2/bin/Runner.PluginHost', arguments 'action "GitHub.Runner.Plugins.Artifact.PublishArtifact, Runner.Plugins"'.

🤔 Not sure why it thinks tests/e2e/* doesn't exist..

Can you try locally and let me know if it's working outside of Github Actions? I'm not seeing this locally so I don't know how to debug it...

Can you try locally and let me know if it's working outside of Github Actions? I'm not seeing this locally so I don't know how to debug it...

running e2e tests locally using the yarn script works fine for me and everything passes.
i tried running the action locally using act & the cypress docker container was getting errors
looks like there are similar errors starting from this push in the cypress-run job
http://localhost:8080 timed out
##[debug]60086ms undefined undefined ETIMEDOUT
##[debug]Timeout awaiting 'request' for 1000ms
##[debug]RequestError: Timeout awaiting 'request' for 1000ms
##[debug]    at ClientRequest.<anonymous> (/home/runner/work/_actions/cypress-io/github-action/v2/dist/index.js:3542:65)
##[debug]    at Object.onceWrapper (events.js:300:26)
##[debug]    at ClientRequest.emit (events.js:215:7)
##[debug]    at ClientRequest.origin.emit (/home/runner/work/_actions/cypress-io/github-action/v2/dist/index.js:59890:20)
##[debug]    at Socket.socketErrorListener (_http_client.js:406:9)
##[debug]    at Socket.emit (events.js:210:5)
##[debug]    at emitErrorNT (internal/streams/destroy.js:92:8)
##[debug]    at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
##[debug]    at processTicksAndRejections (internal/process/task_queues.js:80:21)
##[debug]    at Timeout.timeoutHandler [as _onTimeout] (/home/runner/work/_actions/cypress-io/github-action/v2/dist/index.js:77852:25)
##[debug]    at listOnTimeout (internal/timers.js:533:17)
##[debug]    at processTimers (internal/timers.js:475:7)
Error: Timeout awaiting 'request' for 1000ms

looks like there's an issue in the cypress action for this: https://github.com/cypress-io/github-action/issues/235
i tried explicitly using version 2.6.1 (which was supposed to have the fix) but it didn't work
using version 2.3.8 made the cypress run work at least
maybe we should downgrade to<EMAIL_ADDRESS>


Add more tests around secondary reload

Codecov Report

Merging #84 into master will increase coverage by 3.2%.
The diff coverage is 71.42%.

@@            Coverage Diff            @@
##           master      #84     +/-   ##
=========================================
+ Coverage   61.14%   64.34%   +3.2%
=========================================
  Files          11       11
  Lines         718      718
=========================================
+ Hits          439      462     +23
+ Misses        224      202     -22
+ Partials       55       54      -1

Impacted Files
Coverage Δ

main.go
55.42% <66.66%> (+1.14%)
:arrow_up:

secondary.go
61.11% <75%> (+25%)
:arrow_up:

bolt.go
79.13% <0%> (+2.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739a761...2988d4b. Read the comment docs.


chore: caching

Please answer these questions before submitting a pull request

Why submit this pull request?

[ ] Bugfix

[x] New feature provided

[ ] Improve performance

[ ] Backport patches

Related issues

Bugfix

Description

How to fix?

New feature or improvement

Describe the details and related test reports.

This PR optimized the caching use in ingress controller, the caching system is hidden inside the apisix.APISIX implementation, callers even don't know the existence of caching, so many statements like "first creating, then inserting to cache", "first deleting from APISIX, then deleting from cache" are removed.
The cacheing interface was designed as:
// Cache defines the necessary behaviors that the cache object should have.
// Note this interface is for APISIX, not for generic purpose, it supports
// standard APISIX resources, i.e. Route, Upstream, Service and SSL.
// Cache implementations should copy the target objects before/after read/write
// operations for the sake of avoiding data corrupted by other writers.
type Cache interface {
	// InsertRoute adds or updates route to cache.
	InsertRoute(*v1.Route) error
	// InsertService adds or updates service to cache.
	InsertService(*v1.Service) error
	// InsertSSL adds or updates ssl to cache.
	InsertSSL(*v1.Ssl) error
	// InsertUpstream adds or updates upstream to cache.
	InsertUpstream(*v1.Upstream) error

	// GetRoute finds the route from cache according to the primary index.
	GetRoute(string) (*v1.Route, error)
	// GetService finds the service from cache according to the primary index.
	GetService(string) (*v1.Service, error)
	// GetSSL finds the ssl from cache according to the primary index.
	GetSSL(string) (*v1.Ssl, error)
	// GetUpstream finds the upstream from cache according to the primary index.
	GetUpstream(string) (*v1.Upstream, error)

	// ListRoutes lists all routes in cache.
	ListRoutes() ([]*v1.Route, error)
	// ListServices lists all services in cache.
	ListServices() ([]*v1.Service, error)
	// ListSSL lists all ssl objects in cache.
	ListSSL() ([]*v1.Ssl, error)
	// ListUpstreams lists all upstreams in cache.
	ListUpstreams() ([]*v1.Upstream, error)

	// DeleteRoute deletes the specified route in cache.
	DeleteRoute(*v1.Route) error
	// DeleteService deletes the specified service in cache.
	DeleteService(*v1.Service) error
	// DeleteSSL deletes the specified ssl in cache.
	DeleteSSL(*v1.Ssl) error
	// DeleteUpstream deletes the specified upstream in cache.
	DeleteUpstream(*v1.Upstream) error
}

And we have an implementation with the help of go-memdb.
Also, controller will try to sync (with an exponential back off strategy) to the APISIX cluster when the cluster was just added. All operations will fail if the cluster is not ready (the initial sync is failure), we'll add a recover mechanism once the APISIX cluster recovered, the controller shall detect it.

Backport patches

Why need to backport?

Source branch

Related commits and pull requests

Target branch

Codecov Report

Merging #176 (0ec4927) into master (958a02b) will decrease coverage by 0.62%.
The diff coverage is 31.70%.

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   48.65%   48.02%   -0.63%
==========================================
  Files          30       31       +1
  Lines        1482     1720     +238
==========================================
+ Hits          721      826     +105
- Misses        675      756      +81
- Partials       86      138      +52

Impacted Files
Coverage Δ

cmd/ingress/ingress.go
70.76% <0.00%> (ø)

pkg/seven/state/builder.go
0.00% <0.00%> (ø)

pkg/seven/state/service_worker.go
0.00% <0.00%> (ø)

pkg/seven/state/solver.go
1.98% <0.00%> (+0.28%)
:arrow_up:

pkg/apisix/route.go
47.67% <18.51%> (-15.23%)
:arrow_down:

pkg/apisix/service.go
50.00% <18.51%> (-17.25%)
:arrow_down:

pkg/apisix/ssl.go
49.41% <18.51%> (-16.17%)
:arrow_down:

pkg/apisix/upstream.go
56.07% <21.42%> (-13.81%)
:arrow_down:

pkg/apisix/cluster.go
34.06% <27.02%> (-4.83%)
:arrow_down:

pkg/apisix/nonexistentclient.go
71.42% <36.36%> (-28.58%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 958a02b...0ec4927. Read the comment docs.

Codecov Report

Merging #176 (0ec4927) into master (958a02b) will decrease coverage by 0.62%.
The diff coverage is 31.70%.

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   48.65%   48.02%   -0.63%
==========================================
  Files          30       31       +1
  Lines        1482     1720     +238
==========================================
+ Hits          721      826     +105
- Misses        675      756      +81
- Partials       86      138      +52

Impacted Files
Coverage Δ

cmd/ingress/ingress.go
70.76% <0.00%> (ø)

pkg/seven/state/builder.go
0.00% <0.00%> (ø)

pkg/seven/state/service_worker.go
0.00% <0.00%> (ø)

pkg/seven/state/solver.go
1.98% <0.00%> (+0.28%)
:arrow_up:

pkg/apisix/route.go
47.67% <18.51%> (-15.23%)
:arrow_down:

pkg/apisix/service.go
50.00% <18.51%> (-17.25%)
:arrow_down:

pkg/apisix/ssl.go
49.41% <18.51%> (-16.17%)
:arrow_down:

pkg/apisix/upstream.go
56.07% <21.42%> (-13.81%)
:arrow_down:

pkg/apisix/cluster.go
34.06% <27.02%> (-4.83%)
:arrow_down:

pkg/apisix/nonexistentclient.go
71.42% <36.36%> (-28.58%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 958a02b...0ec4927. Read the comment docs.

@gxthrj Please take a look when you have time.

@gxthrj Please take a look when you have time.

Unit-test CI  failed @tokers Please have a look.

Unit-test CI  failed @tokers Please have a look.

Unit-test CI failed @tokers Please have a look.

Fixed.

Unit-test CI failed @tokers Please have a look.

Fixed.


Object#timeout is deprecated warning

I received the following warning when God starts up:
/usr/local/rvm/gems/ruby-2.3.0/gems/god-0.13.7/lib/god/system/slash_proc_poller.rb:64:in `readable?': Object#timeout is deprecated, use Timeout.timeout instead.
I realize this is just a warning, but I wanted to get it on the radar and I don't have time in the project to stop and try to address it myself.

I met this warning too.

I started getting the warning when upgrading from ruby 2.1.8 to 2.3.1.

I submitted #235 but there are issues with Travis CI and the old Rubies that god supports. IMO those should be dropped, I don't think it's worth the time to keep them supported.

Sand Rubies and cool and lady bugs - i concur.

#****

I don't think <1% usage of 1.8.7/REE are worth any extra effort for the future development of god. Can we drop support for those versions?

Ruby 1.8.7 is still the default ruby on CENTOS/RHEL 6 and will still be a supported distribution until 30 November 2020.
Having something to manage processes not work with the system ruby seems like a bad trade-off to me.

Ruby 1.8.7 and Ruby 1.9.2 were EOL as of July 31, 2014. It should be noted that Ruby 2.0 is also in EOL and  Ruby 2.1.X will only receive security updates. Waiting to drop it until 30 November 2020 will only make things harder and harder as new versions of Ruby are released and more go into EOL.
I understand trying to make things as easy as possible for users who still need support, but IMO it's just as feasible to bump the gem version and note that support will be dropped for 1.8.7. It's not optimal, but it should be understandable.

Are there things that are provided in newer rubies that would be a big win for the project? I definitely see value in getting rid of deprecation warnings (even if it's through small compatibility changes), but I'm not sure that (for instance) being able to use the new hash syntax in the project is worth the trade-off of no longer working with system rubies that are still in the wild.

I agree, the new hash syntax alone would not be worth it. However getting rid of deprecation warnings plus the new hash syntax exceeds the (IMO not very high) threshold of dropping support for a 9-year-old, EOL ruby - even if it's the system ruby on CENTOS/RHEL 6. I also work with RHEL 6 from time to time and the first thing I do is install rvm for that reason.
There might be even bigger wins with 1.9+, I don't know the internals of god well enough to assess that.
Also, we could add a note to the README to let ruby 1.8.7 users know which god version still supported it?


Brew gem breakup

Addresses issues in #16.
Also, the way the code is written now, it would be straightforward to add sha256 support using the Rubygems API to fetch gem information.

 I can do a more thorough review in a bit.

Great Idea making this a gem. I think it makes it way easier to develop.
I opened #24 to represent setting the sha in the download strategy great idea.

Yeah, I wasn't sure if we actually want to release and distribute as a gem, but it might make sense to do so?

we could. It for sure makes development of it way easier. Assuming it works the same as a gem as it does for homebrew I think it's fine. I wonder what would happen if you brew-gem brew-gem.

Ok, I'm ready to merge. Let me know and I can cut the release and push to rubygems. I also have updates to the Homebrew/homebrew-core recipe in flight.

:shipit: Nice work!


where are the log files for msbuild commands used in deployment?

i am trying to debug an issue in aws-toolkit-azure-devops and my deployment works fine here, so i'd like to mimic the msbuild parameters in azure devops.
where can i find the actual msbuild commands used during deployment?
i see the echo off output in the window, but i'm not seeing the actual commands used.

i can actually use either, that's a great tip! i'll check it out! thx a ton!


Take in final pom versions and bump version for release

What is says on the tin.
Picks up https://github.com/jenkinsci/pipeline-graph-analysis-plugin/pull/5
@reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Comment: will fail to build until block scoped stage is released fully to the public.

will fail to build until block scoped stage is released fully to the public

So this is not technically ready for review.
For things like this I think no PR is needed—you are just bumping up dependencies to public releases, and setting the next version.

@jglick Stage view and block-scoped stage should be released at the same time, to ensure compatibility for all users.

Merging since it's just a pom update and changes are already validated


New rule proposal: require named parameters

I have seen two style rules regarding named parameters when invoking a method/function:

Require named parameters for multiline argument lists
Require named parameters for all method/function invocations

The later has safety implications, as changing the ordering of arguments in a method definition when the arguments have the same type can lead to bugs.

Duplicate of #2220


Add initial setup for Swift in devcontainer

For #871
I finally got the tar.gz to download and extract. swift command is callable. But it doesn't run in Docker... I get this error:

error: failed to launch REPL process: 'A' packet returned an error: 8

Otherwise it alls seems to work fine. A quick search showed that you need to pass more parameters to Docker (notably: --privileged), but I don't know enough about Docker to do this on my own. Any help would be welcome!

@Amaras can we get hacktoberfest-accepted on this


Document consumergroup repo location

@Shopify/kafka
We've gotten a number of people confused by this "missing" functionality.

This is an easy one for me to review :-) LGTM

:shipit:


Follow Link header in tags/list responses

In the Docker registry API v2 specification, the response to a list tags call may be paginated by the server. It does this using an RFC5988 Link header, with rel=next; no header means no more pages.
At least quay.io uses this mechanism to return pages of 50 tags at a time, though it gets the format slightly wrong (by missing the < and > around the URL).
This PR makes the registry.Tags method deal with pagination, by following the Link header when it's present. I've used a regexp to parse the Link header; it's not exactly correct, but probably good enough in practice.

Now uses a sentinel error to indicate that there are no more pages to request.

Thank you. Two additional notes:

Could you add tests?
I merged repositories earlier today: d61a28e10b165df4b4b4331e7eef8e2fc4d6ed98. I'm thinking this endpoint should get the same pagination.

Could you add tests?

How do I say this .. there were no tests present, so I didn't add any. I'm happy to add tests, given some scaffolding, but I'm less enthused about creating the scaffolding. Is that fair?

I merged repositories earlier today: d61a28e. I'm thinking this endpoint should get the same pagination.

OK.

How do I say this .. there were no tests present, so I didn't add any. I'm happy to add tests, given some scaffolding, but I'm less enthused about creating the scaffolding. Is that fair?

Argh my bad. I didn't write this project, and assumed there were tests in other places. No, please don't setup any scaffolding.

Catalog responses also now follow the pagination.

.. and some basic tests.

I believe it'd be better to introduce this without tests

I'm not clear whether you want the tests or not, since you've reviewed them ...

Yes, I've reviewed the tests.
But to speed up merging this PR, and since there isn't any tests setup anywhere else in that project, I believe shipping this without tests is fine.

OKdokes. I think I've fixed the things pointed out in the review. This PR no longer includes the tests (they are in a branch squaremo/test-paginated-results; I've not acted on the review comments for that code).

Thank you! 🌷
I've just left a minor comment. I'm going to merge this and fix it.

Great! Thanks for your patient reviewing :)

Thank you for your contribution :)


new gpstrack app

This app displays tracks recorded by gpsrec together with duration and distance on the bangle.js screen. It uses equirectangular projection which is accurate for small distances and faster than Mercator.

Screen shot of app:

This looks great - thanks! Just before I merge, do you think this is something that might make sense being added to the GPS recorder app itself, since there is already a menu?
https://github.com/espruino/BangleApps/blob/master/apps/gpsrec/app.js
Up to you, but if you think it's a good idea then I'm happy to move your code over.

Yes, very happy for you to merge this with the GPS Recorder - please go ahead. It was easier to develop separately.
Jeff

On 14 Apr 2020, at 09:41, Gordon Williams<EMAIL_ADDRESS>wrote:
This looks great - thanks! Just before I merge, do you think this is something that might make sense being added to the GPS recorder app itself, since there is already a menu?
https://github.com/espruino/BangleApps/blob/master/apps/gpsrec/app.js https://github.com/espruino/BangleApps/blob/master/apps/gpsrec/app.js
Up to you, but if you think it's a good idea then I'm happy to move your code over.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/espruino/BangleApps/pull/273#issuecomment-613306832, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4KGVRGCBNEHGEHIN4G6XDRMQOSVANCNFSM4MFSFZVA.

Thanks! I just merged this in - it's really helpful!


.song_ids format?

When I make download of the playlsit, in the output folder I always find the .song_ids file with mysterious numbers in the first column
7fd3ufuESeBC8kyqo7Lzbs	2023-08-14 09:07:44	Proyal	1001 Nights - Original Mix	Proyal - 1001 Nights - Original Mix.mp3
1VpoazEusm1ki8hoSK49ua	2023-08-14 09:07:55	Paolo Pellegrino	'74 - '75 (feat. Susan Tyler) - Radio Edit	Paolo Pellegrino - '74 - '75 (feat. Susan Tyler) - Radio Edit.mp3
3leKR9bTU8RGm1VnwJV1CS	2023-08-14 09:08:20	Menno de Jong	Abhyasa	Menno de Jong - Abhyasa.mp3
3VWh4Gs34HeTBUvv9bnLQL	2023-08-14 09:08:31	BiXX	Above The Clouds	BiXX - Above The Clouds.mp3

This doesn't correspond to the ID of the song when I copy its link via Spotify app, not Youtube IDs.
Where the come from?

The IDs are Spotify track IDs.
Examples:
https://open.spotify.com/track/7fd3ufuESeBC8kyqo7Lzbs
https://open.spotify.com/track/1VpoazEusm1ki8hoSK49ua
https://open.spotify.com/track/3leKR9bTU8RGm1VnwJV1CS
https://open.spotify.com/track/3VWh4Gs34HeTBUvv9bnLQL

oh, you are right, I was checking through the last segment of track URL open.spotify.com/track/7fd3ufuESeBC8kyqo7Lzbs?si=a0352c14e33049ed, but the ID resides in the beginning. Thanks.


Revert change to "Finish the job" behavior on app.cvat.com

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Is your feature request related to a problem? Please describe.
When finishing a job it would previously change the job stage to acceptance instead of annotation. Today when you press "Finish the job" it will change the state to completed instead.
There is however still a dropdown where you can change the job state to e.g. completed, but now you will need a lot of clicks to change the stage of a video.

Describe the solution you'd like
|t would be nice to either revert how this behaves or to add a drop-down menu that allows you to easily change the stage of a job.
Describe alternatives you've considered
Drop-down menu to easily change the job stage

Additional context
I'm using the web interface app.cvat.com

Hi, could you describe your use case better? We'd like to know why this specific state (acceptance, completed) is important for you annotation pipeline, and why the updated version is worse.

Hi @zhiltsov-max ,
Thanks for taking the time!
Our current workflow is the following:

Supervisor adds a new job and assigns to an annotator (annotation new)
Annotator annotates job and changes state to completed (annotation new -> in progress -> completed)
Supervisor checks all jobs in annotation completed and if it needs correction moves it to validation new and else to acceptance completed

So the idea is to make it easier for the supervisor to change it to acceptance. The argument for this would be that our supervisor generally spends less time per job and thus it would be nice to minimize the clicks needed to change the stage.
However, I see that it makes sense that once someone presses finish is moves the state to completed within a given stage. So maybe a better solution would be a dropdown within the job to change the stage of the job and not only the state?
Again thanks for the great work!

Ok, so if I understand correctly, the problem is that if the supervisor / reviewer opens a job, they can't advance the job from the review stage to the acceptance directly, and instead they need to move back to the tasks page and do it there? In this case, I think, a temporary solution for you could be that the reviewer opens the job for review in a new tab, reviews the job, and then closes the opened tab and switches the stage on the task page. But it's an interesting use case, which we need to think about it. Thank you for sharing this information with us.
@bsekachev

+1 for this; we use job stage + state to know when to pull labels
in our previous use case, when using the "Finish the Job" function, it would set the stage to "acceptance" and the state to "completed"; now, it maintains the same stage (usually "validation"), and only updates the state--when (I manually switch the stage, it resets the state
for my use case, we run the CVAT server on a Google CloudSQL postgres instance; I use bigquery to scan for new jobs nightly that have a current "assigned to" status, an accepted stage, and a completed state; if all 3 are met, it then adds them into our data lake

"assigned to" status, an accepted stage, and a completed state

why not modify condition on your side? I do not see in your pipeline why stage is important at all.

I manually switch the stage, it resets the state

This is expected. When stage changed, state is reset, e.g. when job goes from annotation to validation, another person (responsible for validation process) has to see that he has a new job to review. "validation", "new" are indicators for that.

thanks for the prompt reply:

why not modify condition on your side? I do not see in your pipeline why stage is important at all.
we use the various stages for internal tracking of where things are; a few examples of common combinations we use:

stage annotation/state new are frames awaiting labeling
stage annotation/state in progress are frames...in progress
stage annotation/state completed are frames ready for initial QA
stage validation/state new are frames that we prepopulate with labels that solely need QA
stage validation/state accepted are frames that have made it past the initial cycle of QA
stage validation/state rejected are frames that I have rejected back to QA
stage acceptance/state completed are frames as I mentioned that are fully validated and ready
only using state is not feasible; only using stage opens the flood gates for errant labels to be submitted

the usage of the various conditions on my end are fail safes; it is better to not have labels enter our lake because a member of the labeling team (or I) accidentally set it to accepted. the accepted/completed combination + assigned to field ensures with no uncertainty that the frames are fully reviewed. as I'm sure you can imagine it becomes a bigger headache to back track and delete the frames in the event that they are submitted as complete before being fully complete

This is expected. When stage changed, state is reset, e.g. when job goes from annotation to validation, another person (responsible for validation process, usually task owner or assignee) has to see that he has a new job to review. "validation", "new" are indicators for that.
definitely, this makes total sense--my issue is more that previously I was able to click 1 button and have it automatically set the correct stage and state whereas now, when I fix the stage, the state resets. I understand why the state resets, but my issue is now I have to manually change it. this is a minor inconvenience, but when it used to just be a single button click, it's a bit of a pain to have to do manually

our process is centered around reducing pain points surrounding data labeling/QA/loading. we use voxel fiftyone for instance to send jobs automatically on a weekly basis and properly set up the job stage/state; similarly, and in this case, we use the various values as layers of checks to make sure that everything is in order before uploading
if I am missing something/if there is a better way to do this, please let me know. ideally, if I could just create macros to create the job state, that would be optimal

I do not think we are going to revert the behaviour of this button.
Regular annotators should not be able to update the job stage. It is task staff responsibility and there are other UI elements responsible on that on the task page.


Include SLO rules for connectors

Backporting https://github.com/bf2fc6cc711aee1a0c2a/cos-tools/pull/70

I.e. all the must gather commits, did you intend to include them? Or feat: migrate admin api to auth.redhat.com?


Swift 4.2 compatibility

I would happily fix the test project but it can't be compiled with Xcode 10 regardless of Swift version.
I'm getting this kind of Swift errors in Nimble:
ZSWTaggedString/Example/Pods/Nimble/Sources/Lib/CwlPreconditionTesting/CwlPreconditionTesting/CwlCatchBadInstruction.swift:105:20: Overlapping accesses to 'request', but modification requires exclusive access; consider copying to a local variable

Done in release 4.1.


Update aws-java-sdk-bundle to 1.12.491

About this PR
📦 Updates com.amazonaws:aws-java-sdk-bundle from 1.12.490 to 1.12.491
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-bundle" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-bundle" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #2739.


Create index.md to navigate notebooks while giving the course

We have more and more notebooks which makes it harder and harder to tell people open this notebook but not this one whose filename is almost the same. Also with long filenames in visioconference settings people don't see the full filename (in JupyterLab at least) and the filenames all start the same.
We should have a index.md file that allows to navigate between notebooks more easily. We would always come back to this index.md file at the end of each notebooks and say "OK we did this notebook and now we are going to do this one" click and off we go.
The binder link in the README could go to this index.
In an ideal world the index.md could be generated from the _toc.yml file but I think it would be OK to have it manually generated at first to test the idea.

I added a manual index for the starter course in https://github.com/INRIA/scikit-learn-mooc/commit/72a2bea23f559d7767831c66a9f0518390a2741e

I added a manual index for the starter course in https://github.com/INRIA/scikit-learn-mooc/commit/72a2bea23f559d7767831c66a9f0518390a2741e

I found one of the fork has a more complete index.md, might be worth looking at if we end up doing it manually: https://github.com/datagistips/scikit-learn-mooc/blob/master/index.md


Add formatting for luau files with StyLua

It's not uncommon for Luau files to also accompany roblox projects directly, so add support for StyLua (if possible).

Could we also just include luau highlighting if a user turns support on? This may not be possible, but something interesting to look into. Then a user could just use eslint for everything rather than needing ESLint, StyLua, and the Luau Language Server.
This wuld be out of scope for this project as it would probably be its own ESLint plugin, but we could pull that plugin into this repository.

Done 👍


collect intermediate results in collectResults

for long running estimation tasks that are carried out in parallel it would be great if collectResults also displays the current state of the optimization if opt.tempsave, opt.trace and opt.save are all true (so intermediate results are available).

fixed in 3b482e1


Community Partner Report - Remove partners without projects

Community partner report should filter out community partners with project number = 0

@caadler to get further clarification from client on this feedback request.

@EdemD I tested, and everything looks good.

https://drive.google.com/open?id=1bHaWer3L1IvraP9s-bTKQgt_svx3hBWEM0v7KtBD0OM


Lag when using layout editor attributes tab

There will be small delay or lag for 1-2 secs when inputting the sdp values on the layout editor attributes tab
I'm not entirely sure if the problem is on my pc but its fine and no lags if I'll put the values directly into the XML code

@Wise-394 thanks for letting me know. I don't have control over the layout editor but maybe it will be faster with higher memory allocation.


chore(.github): remove release-note block for kilt

Signed-off-by: Leonardo Di Donato<EMAIL_ADDRESS>What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
NONE
What this PR does / why we need it:
Remove the release-note block from the PR template since kilt uses goreleaser and the commit messages to generate the CHANGELOG.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
Pairs with https://github.com/falcosecurity/test-infra/pull/301
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 3034e856f8e8825e77642249528bcd0c6fa42eab

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: admiral0
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [admiral0]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


AllowingAllowing inherited styles to apply to Adaptive Cards by specifying nu… …  …ll or emptystring in the AdaptiveHostConfig inherited styles to apply to Adaptive Cards by specifying nu…

This change allows inherited styles (i.e. s defined in XAML) to apply to Adaptive Cards by letting the host app specify null or emptystring in the AdaptiveHostConfig.
Microsoft Reviewers: Open in CodeFlow

Thanks @Identifier for this PR. Because of the cross platform nature of host config, if we want to support null and empty string values for colors, we need to ensure that is is supported cross platform so that json host configs are portable between .NET and other platforms. Logged issue #3309 to track considering this for our next release.

closing out old PRs - feel free to revive this PR and resubmit for review


MF-1698 - Add Fatal in Mainflux logger

Signed-off-by: aryan<EMAIL_ADDRESS>Which issue(s) does this PR fix/relate to?
Resolves https://github.com/mainflux/mainflux/issues/1698
List any changes that modify/break current functionality
Nil
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes
Nil

Codecov Report

Merging #1721 (d1cbb3d) into master (d00d13d) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1721      +/-   ##
==========================================
- Coverage   70.38%   70.33%   -0.05%
==========================================
  Files         146      146
  Lines       11394    11399       +5
==========================================
- Hits         8020     8018       -2
- Misses       2724     2731       +7
  Partials      650      650

Impacted Files
Coverage Δ

logger/level.go
100.00% <ø> (ø)

logger/logger.go
75.00% <0.00%> (-15.00%)
:arrow_down:

logger/mock.go
0.00% <0.00%> (ø)

things/service.go
65.35% <0.00%> (-0.72%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


ravenjs.com detailed information

resolve issue #1201
adding some more information and details about Sentry and raven.js library

PR is updated with typo fix


Is meson support dead in the water?

I just started using meson and it doesn't I tried adding both 'glfw' and 'glfw3' as dependencies in my build file, both turned up as "not found" which is a bit of a drag. I see online a way of setting up glfw as a subproject after downloading the library manually, but this route disregards the reason I started using a packaging system.
I see in this post and in this pull request that meson support was a thing at some point, but alas doesn't seem to be working for me.
#glfw3.wrap
[wrap-git]
url = https://github.com/glfw/glfw.git
revision = head

project('src/main', 'cpp', default_options : ['cpp_std=c++2a'])
subproject('glfw3')

vulkan = dependency('vulkan')

exe = executable('Adventum', 'src/main.cpp', dependencies : [vulkan])

Building in: C:\Users\jkmca\Workspace\Adventum\build\default
[0/1] "C:\Program Files\Meson\meson.exe" --internal regenerate "C:\Users\jkmca\Workspace\Adventum" "C:\Users\jkmca\Workspace\Adventum\build\default" --backend ninja
Cloning into 'glfw3'...
The Meson build system
Version: 0.54.0
Source dir: C:\Users\jkmca\Workspace\Adventum
Build dir: C:\Users\jkmca\Workspace\Adventum\build\default
Build type: native build
Project name: src/main
Project version: undefined
C++ compiler for the host machine: c++ (gcc 8.1.0 "c++ (x86_64-win32-seh-rev0, Built by MinGW-W64 project) 8.1.0")
C++ linker for the host machine: c++ ld.bfd 2.30
Host machine cpu family: x86_64
Host machine cpu: x86_64
....\meson.build:2:0: ERROR: Subproject exists but has no meson.build file
A full log can be found at C:\Users\jkmca\Workspace\Adventum\build\default\meson-logs\meson-log.txt
FAILED: build.ninja
"C:\Program Files\Meson\meson.exe" --internal regenerate "C:\Users\jkmca\Workspace\Adventum" "C:\Users\jkmca\Workspace\Adventum\build\default" --backend ninja
ninja: error: rebuilding 'build.ninja': subcommand failed
Build complete: C:\Users\jkmca\Workspace\Adventum\build\default

I'm currently using this fork that supports meson integration

There are no plans to support Meson upstream. Nothing against Meson specifically, which I use for personal projects.


combineLatest Marble Diagram not correct

Describe the bug
The marble diagram in the combineLatest documentation is not correct. It does not seem to follow a specific pattern for how the output values are coloured and is confusing.

Expected behavior
The output values should always have the colour of the most recent step as in:
a1: red
b1: yellow
b2: yellow
b3: blue, ...
Or is there another pattern that I'm not seeing?
Reproduction code
No response
Reproduction URL
No response
Version
7.1.0
Environment
No response
Additional context
No response

I also find the colors confusing in the current diagram.
Taking the color of the last emitted value makes much more sense.


Use gulp.watch instead of 'update' event

I like to propose this recipe for watchify.
I think that is more aligned with other gulp recipes.
Using watchify 'update' method, you can not declare dependencies for the the bundle() function. With gulp.watch you can.
What do you think?
(Sorry for my English, I'm still learning!)

watchify.update works differently - it traces dependencies and updates when those change too, even outside of the src folder

Ok, then better to use the 'update' event.
One question: How I can declare a dependency on the bundle function?
gulp.start is deprecated (and is not part of the public API of gulp).
And an example:
In my proposed code: gulp.task('bundle-js', function () {
I can change it with: gulp.task('bundle-js', ['lint'], function () {
How I can do that?

I have been searching a bit and this is my conclusion.
Using run-sequence until Gulp 4.0 is released and punting bundler on update in the watch task.
Now I can define dependencies for the 'bundle-js' task.
var gulp = require('gulp');
var gutil = require('gulp-util');
var sourcemaps = require('gulp-sourcemaps');
var source = require('vinyl-source-stream');
var buffer = require('vinyl-buffer');
var watchify = require('watchify');
var browserify = require('browserify');
var runSequence = require('run-sequence'); //Hack waiting for gulp 4.0 https://www.npmjs.com/package/run-sequence

var bundler = watchify(browserify('./src/index.js', watchify.args));
// add any other browserify options or transforms here
bundler.transform('brfs');

gulp.task('bundle-js', function () {
    return bundler.bundle()
        .on('error', gutil.log.bind(gutil, 'Browserify Error'))
        .pipe(source('bundle.js'))
        // optional, remove if you dont want sourcemaps
          .pipe(buffer())
          .pipe(sourcemaps.init({loadMaps: true}))
          .pipe(sourcemaps.write('./'))
        //
        .pipe(gulp.dest('./dist'));
});

gulp.task('watchify', function () {
	bundler.on('update', function () {
		runSequence('bundle-js');
	});
});

Yep - gulp 4 is almost out. You can use it now, just use the 4.0 branch


Removed unncessary sigma in function elbo of gplvm.py (and save N^2+1 operations)

PR type: enhancement
Related issue(s)/PRs:
Summary
In function elbo of gplvm.py the calculation of sigma is unnecessary.
Proposed changes

In function elbo of gplvm.py sigma is only used to first divide A and then to divide c. As A is only used to calculate c, we can avoid dividing A by sigma by dividing c by sigma2. In this way we save N^2 divisions (assuming N is the dimension of A) and one square root operation.
Equations explaining this pull request appear here
I tested that the resulting elbo is equal with the current version of the code and with the modification proposed here.

What alternatives have you considered?

Minimal working example

# Put your example code in here

Release notes

Fully backwards compatible: yes
If not, why is it worth breaking backwards compatibility:

PR checklist

[ ] New features: code is well-documented

[ ] detailed docstrings (API documentation)
[ ] notebook examples (usage demonstration)

[ ] The bug case / new feature is covered by unit tests
[ ] Code has type annotations
[ ] Build checks

[ ] I ran the black+isort formatter (make format)
[ ] I locally tested that the tests pass (make check-all)

[ ] Release management

[ ] RELEASE.md updated with entry for this change
[ ] New contributors: I've added myself to CONTRIBUTORS.md

Hi @joacorapela, thanks for raising this PR. It looks like the unit test failure is nothing to do with your code. If you pull the in latest changes from develop all of the tests should pass.

@johnamcleod my pull request has not been incorporated into the develop branch. Is there any problem or do I need to be more patient? Thanks.

LGTM, can we do the same simplification in the predict_f?

@vdutor @st-- I was learning about predict_f and realised of, what I think is, an error in the prediction function. I open issue #1753  about this. I would appreciate your feedback on it. Thanks


Support resolving some values from AWS Secrets Manager

I have a customer using your integration and they love it!
They are have asked me how they might go about integrating this with AWS Secrets Manager for some parameters so they can support automated credential rolling with RDS for example. They like the ability to load all parameters under a prefix and Secrets Manager does not seem to support this.
They love the simplicity of your integration, but would like some parameters to be resolved via Secrets Manager.
Some suggested designs include:

Add a blessed tag to the SSM parameter which marks this as Secrets Manager resolved and the value of this tag is the ARN of the secret in Secrets Manager. The actual value of the parameter is junk.

Use a blessed prefix for values of the parameter and check these on load ie "SecretsManagerResolved:", if it matches, extract the Secrets Manager ARN from the remainder of the parameter value and load the value from Secrets Manager.

What do you think?
Josh

We might implement something for the Secret Manager eventually since we also use it. Although, this may not happen in the short term. If you use Spring Cloud, since this library was published, they have released something for both the parameter store and the secret manager. See their documentation. We still have other plans (like multi-region) for this small library so I'm not saying it wont happen here too 😄If you want to try and submit a PR, we are also open to reviewing it.

I'll close this issue since we won't do this for now.


How to actually load data into a shared directory

I know this is not specific to CVAT but how do I use docker to include a shared directory to contain images. Also how do I use docker to stop it including the shared directory. A final point. I assume that CVAT will resize images in the shared directory as required so I can put images of any size into the shared directory

@bogflap , could you please use our https://gitter.im/opencv-cvat/public channel four such questions? Information how to use docker together with shared directory you can find here: https://github.com/opencv/cvat#share-path. CVAT doesn't resign images on server. It scales images your browser. You can upload images of different size.
I will close the issue. As I said please use our gitter channel to submit new questions. We use issues only for bugs and feature requests.


Update client.py

Add 'STOP', 'STOP_MARKET', TAKE_PROFIT' and 'TAKE_PROFIT_MARKET' for futures.

thanks @TheSeacfr


Record sync peer status

Describe the bug
For debugging purposes it would be very useful to track the sync status of sync peers

Implemented here
https://github.com/ChainSafe/lodestar/blob/9f0c7a666a999d634dc55fd059575ff156f72f1b/packages/lodestar/src/sync/sync.ts#L224


Xamarin.Facebook.Android v.4.26.0: How to use AppLinkData.FetchDeferredAppLinkData()?

Can you give an example how to use the method AppLinkData.FetchDeferredAppLinkData(...) in Xamarin.Facebook.Android v.4.26.0?

Unfortunately we can't provide documentation or samples of all the third party API's we provide bindings for.  This blog article looks like it should be helpful: https://www.oodlestechnologies.com/blogs/Facebook-App-Invites-in-Android
The java code for any example of using these API's should be pretty similar and easy to translate to C#.  Good luck!


Srgb + alpha format shortcut

Fixes #885

@homu r+

:pushpin: Commit 1576647 has been approved by kvark

:zap: Test exempted - status


[Feature Req] Render RN View into VR/AR as Texture Source

I can't find any references in the documentation so asking here.
I want to use a webrtc stream as a video texture. Currently only file/url sources are supported it seems.
There's a RN webrtc lib I would like to use https://github.com/oney/react-native-webrtc ) It renders onto its own custom component which looks like it's a glview.
Would it be possible to use that as a texture?
Another way I'm thinking is to save images regularly and trigger the texture update. Would that be possible ? I'm assuming it would not be terribly fast and I'd have to clean up after myself somehow.
Any other ideas ?

Hey @shokimble, thanks for reaching out. Curious to ask - have you tried playing your video source through the ViroVideo component? It uses exoplayer that supports real time video encoding like HLS, but i'm not sure if in the case of webRTC.
Unfortunately we don't yet have a Viro component that renders React Views directly into VR / AR. This solution may work for the use case you've shared above, with some caveats in perf (duplicated rendering) and dimension sizing.
As such there are two solutions:

Encapsulate the component you wish to render in VR/AR in a "ViroCapture" like view, that in turns renders whatever views are encapsulated onto a texture.
Another alternative is to modify RN webrtc, such that you can provide it a opengl Texture ID (that we give you, that represents a Viro Texture material), so that RN webrtc can render on. That will be perf savings in this option.

I'll turn this into a Feature request and file a story on our backlog.
Are you actively working on shipping an application that will be blocked by this feature?

As it's webrtc you don't get a URL as such so there is nothing to pass into exoplayer. I did a bit of googling to confirm there weren't any examples of passing the buffer directly in somehow but it appears not to be something done before. Makes sense as it has its own player.
Is solution two something achievable today (i.e without modifying Viro React)? It's not something the rtc lib supports but there's a few options around and most are open source so I don't have a problem writing the code for it and submitting a pull request (whether it's accepted is something else).
I'm not actively working on an app but putting together a feasibility study on whether an AR chat app could be done in RN without having to go full Native. It would be great if it was possible.
I'm guessing number 1 is conceptual entirely as I can't find the element you mentioned. There's a few capture component for RN it could be based on but that component can't capture GL views last time I checked which is where cameras and video tend to be rendered.
https://github.com/gre/react-native-view-shot

Ah i see, yes that does make sense.
Yup, both options above are mainly conceptually potential solutions for supporting the rendering of a React View / WebRTC component.
As such, unfortunately neither of them are currently supported by the latest version of the ViroReact platform. Apologies for the inconvenience.
This issue will be updated once a solution has been decided upon, and then again once it has been deployed into release.

No problems. I'll put the idea on the backburner for now. Trying to implement it separately for arcore and arkit would be a lot of work hence why your platform is great 😀

Hello @dthian
I would like to ask if for now WebRTC get supported?
Thanks!

Hey @tuananhcwrs, currently Viro React does not support webRTC. Please file a separate github issue / feature request if this is something you would like. Much thanks!

looking for WebRTC support

yeah, It's will very great if support webrtc :)


Code question

// filter out diagonals that are unlikely to reach a better alignment than the current best. Only applicable to global alignment. This is not an approximation.
static inline void wf_prune_global(int32_t tl, int32_t ql, int32_t *st, int32_t *en, const wf_diag_t *b)

Looking at this function, this seems to be the approximation/reduction explained in section 4.2 if the WFA paper. However, your comment 'this is not an approximation' sounds like it preserves optimality of the alignment.
What am I missing?

this seems to be the approximation/reduction explained in section 4.2 if the WFA paper.

No, it is not. The WFA adaptive is a heuristic. This is an exact solution, though it often has no effect.

In that case, could you explain the filtering you do here? The comment says 'unlikely' but for this to be an exact filtering step it should be 'impossible' instead.

The comment says 'unlikely' but for this to be an exact filtering step it should be 'impossible' instead.

The comment already says this is an exact solution. Feel free to change "unlikely" to "impossible".

could you explain the filtering you do here?

I believe this is a very old strategy. For two strings of l1 and l2 in length respectively, the edit distance must be within [abs(l1-l2), max(l1,l2)]. In the middle of DP, you can estimate the max possible edit distance D without looking at substrings. Then you can discard cells that definitely can't reach the end within D in the best scenario.


Ema jhin virtuoso patch 1

created a branch, created a file and made a commit, and opened a pull request

No description provided

created a branch, created a file and made a commit, and opened a pull request


Development build instructions off in README

The instructions in the README for dev builds work fine if you haven't made any changes. But if you want to actually do development, there are missing pieces. I thought I could get away with just doing an npm run build in the top-level directory, but that doesn't seem to do it.
I dug around and found that python setup.py jsdeps does the trick. Is this the preferred approach? Do we want to add a top level npm command that does everything?

Sure, that would be great to have a top-level npm command that builds and then builds the extension subpackage. Submit a PR!

I have no idea how to get npm to do that and am going offline until next
Wed starting tomorrow after our JupyterLab meeting ;-)
On Thu, Jun 9, 2016 at 6:43 PM, Jason Grout<EMAIL_ADDRESS>wrote:

Sure, that would be great to have a top-level npm command that builds and
then builds the extension subpackage. Submit a PR!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/jupyterlab/issues/27#issuecomment-225074163,
or mute the thread
https://github.com/notifications/unsubscribe/AABr0M5RE6Yty1jSPJB8gw2OEnHvOPa0ks5qKMFPgaJpZM4Iygmb
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Workflow A: have npm run build build the jupyterlab code, then install it into the extension, then update the extension bundle. It would be great to have an npm run watch or something that could do this automatically when a file changed too.
Workflow B: have an npm run watch in the jupyterlab directory, so you first go into the jupyterlab directory and run npm run watch, then as you make changes to the jupyterlab ts source, and run npm run build, the extension updates itself.

Ping @ian-r-rose , @fperez

While having a run watch open is probably a good idea for dev work (and should be documented :), would it also help to have a git hook like we have for j/notebook?

Sidenote,
npm install run post_install and prepublish which end up running all the test ....etc which seem undesirable.

@Carreau - this is a problem with npm. See https://github.com/npm/npm/issues/3059.

This issue I think is fixed with #75 (when it is merged...)

Thanks ! And yes I was 1/2 aware it was a npm issue.


Added better error message when using Repeat with an exact count

When using Repeat with an exact count, you get error messages like:
Parsing failure: Unexpected ' '; expected 'digit' between 4 and 4 times, but found 2 (Line 1, Column 8);

This is when using Parse.Digit.Repeat(4).
So I fixed it when minimumCount and maximumCount are identical to say:
Parsing failure: Unexpected ' '; expected 'digit' 4 times, but found 2 (Line 1, Column 8);

This is my first contribution, and I couldn't find any contribution guidelines, hope it's ok. Let me know if I need to change anything.
Thanks.

Looks good! Just re-targeted to develop, which is where new work lands.

Sorry about that, didn't notice the develop branch. I'll keep that in mind for any future PRs.
Thanks for the merge.


Minor issue with code for bug bounty

Spelling mistake on line 71 of https://github.com/clemahieu/raiblocks/blob/master/CL/cl.hpp
"decriptions" should be 'descriptions'

Thanks.
Please submit a PR

Thanks androm3da!

We offer three tiers of bounties, based on the severity of the bug, vulnerability or issue, paid in either XRB or the BTC equivalent:
Minor (100 XRB bounty)
A typo counts as an issue right? My address:
xrb_31gy5piietf7zmezsxk6a4dd7i87wgwoerhi7pjcqpif9ywuqc8a3nm8qekx

Ha, ha, I fail to see how a typo can fall under any of the classes of severity ;d

@AyiSoli Maybe in some way I can understand them, the team did not define what "Minor", "moderate" and "critical" is.
This could be as minor since it is something you don't want.
Would love to have them set up some boundaries to what minor,moderate or critical is

A very minor typo in a comment in code typically wouldn't fall under any category of bug, in my opinion

I was going by Colin's reddit post where he said:
"We offer three tiers of bounties, based on the severity of the bug, vulnerability or issue, paid in either XRB or the BTC equivalent:
Minor (100 XRB bounty)"
A typo is an 'issue'  I believe. I hope they honor what they said in their announcement :)

independent observer here. I saw Colin’s reddit post also - I in no way interpreted it to mean that bounties would be paid for fixing simple spelling errors.
On Dec 28, 2017, 18:05 -0500, Jackoclypse<EMAIL_ADDRESS>wrote:

I was going by Colin's reddit post where he said:
"We offer three tiers of bounties, based on the severity of the bug, vulnerability or issue, paid in either XRB or the BTC equivalent:
Minor (100 XRB bounty)"
A typo is an 'issue' I believe. I hope they honor what they said in their announcement :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Sorry I am autistic and take things very literally to me a spelling mistake is an issue and colin specified issues I do not understand :(

Regardless of whether a typo in a comment header is a bug or not (it isn't), this is amusing enough to dig into.
Here are the reasons why there should be no bounty paid on this minor issue, ranked by importance:

This typo is not in RaiBlocks code, but in the included OpenCL module. The referenced comment clearly states,

 * Copyright (c) 2008-2015 The Khronos Group Inc.
 *   \brief C++ bindings for OpenCL 1.0 (rev 48), OpenCL 1.1 (rev 33) and
 *       OpenCL 1.2 (rev 15)
 *   \author Benedict R. Gaster, Laurent Morichetti and Lee Howes

The bug bounty offer clearly states, If you believe you have found a bug in RaiBlocks. This 'bug' isn't in RaiBlocks.
Submitter should try sending this issue over to the Khronos Group if they have a bug bounty program.

The submitter did not follow correct protocol as described in the  bug bounty offer:

Notify us that you have found a bug in the #bug_bounties channel on Discord at chat.raiblocks.net
The Core team will review the issue and if it is determined that the reported bug has merit, they will work with you to fix the bug and your bounty will be rewarded.

The submitter has leaked the crucial details of this bug -- namely, a missing 's' in the word 'descriptions' -- prior to contacting the core dev team and resolving it. The offer clearly states,

If the details of the bug leak ahead of the retrospective being published, whether accidentally or maliciously, the contract between RaiBlocks and the reporter is null-and-void and the bug bounty will not be rewarded.

Lastly, this is a typo in a comment.

I advise @Jackoclypse to follow the protocol very literally next time should he wish to claim a typo in a comment for a bug bounty.

But I followed the Discord link and they linked to here which is where I posted it?

That still leaves the most important point standing -- that this is a typo in a comment in code that isn't part of RaiBlocks.

But it is an issue in the RaiBlocks code which is what Colin said in his reddit post was eligible for a minor reward. I do not think it would be fair to penalize me when I submitted something which follows the official announcememt on the RaiBlocks subreddit and since the devs have changed how they want the issues reported 4 times in 24 hours. Check the #bug_bounties channel on the discord to see what I mean

But it is an issue in the RaiBlocks code
No. It is an issue in OpenCL  bindings. You can plainly tell by the copyright header that it isn't part of RaiBlocks code. The rest is immaterial.

Comments aren't code, that's oft the point.

Nice try, smartass.

Colin's post: https://www.reddit.com/r/RaiBlocks/comments/7makm7/announcing_the_raiblocks_bug_bounty_program/
"The RaiBlocks protocol is open-source; you can find the code here
and the white paper here."
I followed the link  where Colin found 'here'
https://github.com/clemahieu/raiblocks
I found an issue, I followed the instructions at the time to report it given how it is not a security related bug.

You've continued to ignore the most important point why this does not apply. Good bait though.

But it is an issue in the RaiBlocks code
No. It is an issue in OpenCL bindings. You can plainly tell by the copyright header that it isn't part of RaiBlocks code. The rest is immaterial.

But its in https://github.com/clemahieu/raiblocks which is what Colin linked to?

And it clearly says in that file,
/*******************************************************************************
 * Copyright (c) 2008-2015 The Khronos Group Inc.
 *

It's not part of the RaiBlocks codebase, but a file included from another project and mirrored in the git repo.

What does that matter? If someone found a security bug in that code it would not matter that it was included from another project?

 * Copyright (c) 2008-2015 The Khronos Group Inc.

Just because the mistake was included from something someone else made does not make it less of a mistake?

be me
browsing leddit
see bug bounty post, could get 100 RaiBlocks
install git, clone project, run spellcheck, find typo
post bounty issue. 100 XRB here we go!
some coding dweeb says it's not security related
another coding nerd says it's not part of raiblocks
another geek says it's copyrighted by someone else
teary_pepe.jpg
but my 100XRB reeeeeee

no specification saying the bugs had to be security related
literally in the RaiBlocks folder that was linked to
"copyrighted by someone else" is irrelevant for example what if a massive security bug was found in a part of RaiBlocks copyrighted by someone else

Otherwise the only part of your story that is wrong is that I copy and pasted the code into word rather than installing git :P

@Jackoclypse  dude, come get your xrb tip in discord

Wow. I told someone how to fix a wallet sync. That should be worth at least a million XRB by jackoclypse logic lol.

On Dec 28, 2017, 19:09 -0500, Leo P<EMAIL_ADDRESS>wrote:

@Jackoclypse dude, come get your xrb tip in discord
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@groach I gave the guy something like 1000 raw for effort .

damnn


Adds Ruby 3.1 and 3.2 to CI

Updates YAML loading to be compatible with recent versions of Psych.
Also updates checkout action version in CI, rspec development dependency version.

@semmons99 Any questions about this one?  It will enable compatibility with recent Rubies.

merged. ty


reimplement room_to_displaay_x / y

it's in the stanncam code it's just uncommented
this might work, but haven't tested it
	/// @function room_to_display_x
	/// @description returns the room x position as the position on the display relative to camera
	/// @param {Real} x_
	/// @returns {Real}
	/// @ignore
	static room_to_display_x = function(x_){
		return ((x_-get_y()-x_frac) / get_zoom_x()) * stanncam_get_res_scale_x();
	}

Duplicate of #51

Duplicate of #51


utils: vpr fixup: merge only top module port signals

This PR fixes problems described in https://github.com/QuickLogic-Corp/symbiflow-arch-defs/issues/766.
The problem was that the script was converting the names of all wires that have naming format like this: \name[id] even when the wire is not a top module port. With this PR I enabled simple filtration that will prevent this behaviour.
Signed-off-by: Paweł Czarnecki<EMAIL_ADDRESS>

Hi @tpagarani, @rakeshm75, please have a look at this.

@lpawelcz  could you please add the test provided into the CI as well. Ideally CI should have caught the compilation error for post verilog netlist.

There were some minor CI failures due to wrong CMake configuration for qlf_k4n8 tests, it should be OK now.


Feature/124 the space devs upcoming launches

Make sure every command has the help text set up as explained in the wiki

@leovdd could you put this PR in draft mode until you think it's ready for review? I'd like to review but given the recent commits I'm unsure if your done or not.


Will it be possible to relax the gettext version?

Because live_toast >= 0.7.0 depends on gettext ~> 0.24.0 and your app depends on gettext ~> 0.26, live_toast >= 0.7.0 is forbidden.

Is it necessary to only depend on 0.24?

Completed in 0983a4dde23528417c9ea33180d6873b620fd7a8. I will release a new version once I have some of the minor fixes/requests that have open issues done so if you'd like you can point to master for now. Thank you @wkirschbaum!


[Feature] Support Wide ResNet

Motivation
Based on #678
Modification
Add two wide resnet config files for ImageNet.

I've confirmed that the accuracy is almost same after model conversion.
The accuracy of torchvision is cited from https://pytorch.org/vision/stable/models.html

Model
Accs@1
Accs@1(torchvision)
Accs@5
Accs@5(torchvision)

Wide ResNet 50
77.7
78.47
93.79
94.09

Wide ResNet 101
78.18
78.85
93.98
94.28

ResNet 50
75.36
76.130
92.52
92.862

I would like to ask you about CLA.
The status of CLA is still pending after agreement the License.
This may be because I used wrong mail address in git.config when I pushed.
What I should do in this case?

I've confirmed that the accuracy is almost same after model conversion. The accuracy of torchvision is cited from https://pytorch.org/vision/stable/models.html

Actually, the accuracy should be the same. So there is something different with setting in torchvision. Maybe it causes by Resize backend, You can try:
dict(type='Resize', size=(256, -1), backend='pillow'),

This may be because I used wrong mail address in git.config when I pushed.

Did you mean that you have pushed your commits before config your email address, which caused the username unable to be tracked?  Maybe you need to use git rebase to modify your commit information. Or just close this PR and re-create a new one.

Actually, the accuracy should be the same. So there is something different with setting in torchvision. Maybe it causes by Resize backend, You can try:
dict(type='Resize', size=(256, -1), backend='pillow'),

I confirmed the accuracy is the same as torchvision by modifying resize backend.

Model
Accs@1
Accs@1(torchvision)
Accs@5
Accs@5(torchvision)

Wide ResNet 50
78.48
78.47
94.08
94.09

Wide ResNet 101
78.84
78.85
94.28
94.28

ResNet 50
76.14
76.13
92.87
92.86

Did you mean that you have pushed your commits before config your email address, which caused the username unable to be tracked? Maybe you need to use git rebase to modify your commit information. Or just close this PR and re-create a new one.

Yes, I modified commit message.

No support for 3 stage WRN? like WRN 16 to WRN 40?

@Davidgzx  Can you attach the code and weights link?

@Davidgzx In the official repo, the wrn16 or the wrn40 are trained by using cifra10 and cifra100. I think the ImagNet-1k dataset is more general.

Hi @yasu0001！First of all, we want to express our gratitude for your significant PR in the MMClassification project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA
If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤ @yasu0001


Check if db exists before init

My first run had an issue and npm crash but the db was created, any subsequent try to run npm resulted in:
Unhandled rejection ReqlOpFailedError: Database `passport_rethinkdb_tutorial` already exists in:
r.dbCreate("passport_rethinkdb_tutorial")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    at ReqlOpFailedError.ReqlError [as constructor] (/home/itzco/Tech/github/passport-rethinkdb-tutorial/node_modules/rethinkdb/errors.js:23:13)

This was the least invasive fix I could think of. Also application should be able to run with init only working on db not existing.

Introduced a bug, I'll send a new pull request.


Possible race condition for Task::m_state

It is possible, that Task::m_state requires some sort of syncronisation. Currently it's not even atomic. But may be it is not required even on more relaxed architecrures then x86. Need carefull investiagtion.

m_state currently changes only inside it's own Task execution context. Also it is atomic for reading.


Direct messaging and supabase refactor

Added support for direct messaging on multiple channels
Refactored supabase client functions into model file

Looks good, thanks for refactoring


The House in Fata Morgana [PCSE01305]

App summary

App name: The House in Fata Morgana
App serial: PCSE01305
App version: 1.02

Vita3K summary

Version: v0.1.5
Build number: 2658
Commit hash: https://github.com/vita3k/vita3k/commit/48f3e7ce
CPU backend: Dynarmic

Test environment summary

Tested by: gymzatan
OS: Windows 11
CPU: AMD Ryzen 7 5800H
GPU: AMD Radeon(TM) Graphics
RAM: 16 GB

Issues
Game soft-locks at the loading screen without reaching the menu.
Screenshots

Log
vita3k.log
Recommended labels

Intro
softlock bug

as of https://github.com/Vita3K/Vita3K/commit/9d45a5fc666122ab7f53cd3bf47edad6b3adcbae, the game can now go ingame (by adding libhttp to Core). The FMV ran slow and desyncing for me (although with mid-end/powerful PC's it could be full speed) and even ingame.
Screenshots|

Logs
vita3k.log
Recommended Labels

Ingame +
slow


'role' and 'isCloud' in different stores have the same function

Should delete one of them.

Fixed by #342


oceans are boring

While they look better than vanilla, there's nothing to explore apart from a bunch of rocks.
Shipwrecks, water zombie outposts, custom guardian temples, an old structure similar to the stronghold (but not the same, and clearly distinguishable), more loot, more things that people want to go out and find. Rare stuff. Exploring is what we want people to do!

ill add more 👍

imo they look better now. we can always add more, if someone dares complaining :)


More work on the proper zap single instance mode

Codecov Report

Merging #1205 (edf6bf5) into master (c83abb6) will decrease coverage by 0.53%.
The diff coverage is 33.96%.

@@            Coverage Diff             @@
##           master    #1205      +/-   ##
==========================================
- Coverage   65.43%   64.90%   -0.53%
==========================================
  Files         185      187       +2
  Lines       19104    19309     +205
  Branches     4092     4126      +34
==========================================
+ Hits        12501    12533      +32
- Misses       6603     6776     +173

Files
Coverage Δ

src-electron/client/ipc-client.js
90.69% <100.00%> (ø)

src-electron/server/ipc-server.js
69.51% <100.00%> (ø)

src-electron/util/env.js
80.60% <ø> (ø)

src-electron/util/studio-util.js
85.71% <100.00%> (+2.38%)
:arrow_up:

src-electron/util/util.js
78.14% <0.00%> (ø)

src-electron/ui/preload.js
0.00% <0.00%> (ø)

src-electron/main-process/session-timers.js
28.57% <27.27%> (-2.20%)
:arrow_down:

src-electron/ide-integration/studio-rest-api.js
15.50% <32.35%> (ø)


Please invite me to the community

Name
sweetdev108
Additional Context
I really want to be your member.

Invitation sent to join the GitHub Organization. Welcome to Infraform 🎉Please check your mail to accept the invitation sent by GitHub! 🤖About usInfraform is a remarkable open-source solution tailored for serverless platforms, aimed at empowering creators to craft their infrastructure solutions. 💻 We're thrilled to welcome you into our vibrant community! ✨ We eagerly anticipate your valuable contributions! 🤓 Don't forget to explore our community on Github and connect with us on LinkedIn 💜 Feel free to spread the word about our community to like-minded individuals interested in development, DevOps, technology, and collaborative contributions. 👉💜👈


No process description in docs

Description
The RtD process page is empty.

Dupe of https://github.com/Ouranosinc/pavics-sdi/issues/231 ?
If yes then I think we should just turn back on fail_on_warning: true and deal with all the annoying warnings religiously.
Otherwise there is probably no way to prevent this silent empty process description to come back.

Possibly, haven't looked in detail at what's going on.


No bronze

No current recipe for bronze. Cant build circuits

Fixed.

This still seems to be a problem in astromine-1.5.2+fabric-1.16.1.jar. If this was fixed for 1.16.2 would it be possible to back port it for 1.16.1?


Query: Test Include_empty_reference_sets_IsLoaded fails

After entity equality is implemented, test Include_empty_reference_sets_IsLoaded fails on the assertion although the relevant entities seem to be properly loaded.

Investigate?

I can look at some point - FYI it doesn't seem related to entity equality in any way.


#49 update emoji to v2.x

Local tests passed, so I'm going to merge and react to things if they come up.


Update gestures.md

OPS Build status updates of commit 6fffbb8:
:clock10: Preparing: average preparing time is 50 sec(s)

OPS Build status updates of commit 6fffbb8:
:clock10: Incremental building: average incremental building time is 25 sec(s)

OPS Build status updates of commit 6fffbb8:
:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/gestures.md
:warning:Warning
View
Details

mixed-reality-docs/gestures.md

Line 35: [Warning] Illegal link: coming soon -- missing bookmark. The file index.md doesn't contain a bookmark named news-and-notes.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Filesystem storage with proxy backend

This is not really an issue but a question. When we enable proxy backend, local filesystem will be used or not? Don't want to go through the code to find answer for such simple question.
PS - Is there a slack channel or a community page where such questions can be posted and people can answer those?

Please see: https://bazel.build/help.md

Please see: https://bazel.build/help.md

My question was specific to bazel-build . I couldn't find the answer to my question on bazel forum as well. Hence, posted here.

I'm not sure if you're asking about bazel-remote or about bazel...
bazel-remote uses a local disk cache, with an additional optional proxy backend- it always needs at least some disk cache (though it needs less if you use one of the proxy backends).
Bazel has its own disk cache, but I'm not sure how that works. You could try asking about Bazel on https://bazelbuild.slack.com/ or https://groups.google.com/g/bazel-discuss

(though it needs less if you use one of the proxy backends)

So this means all/some of the cache will be stored in the remote and not where bazel-remote is running?
Right now we use a local server as bazel-remote to which only our CI machines have access. Now, it we are to give access to all the developers, we will have to give them access to this local server. Solution for this could be replicate this cache to GCS or any bucket preferred and give developers access to this GCS bucket and not to the local server. Hence, my question, when we enable proxy backend, is the cache replicated to the enabled backend or all the cache will be stored to the backend and the machine where bazel-remote is actually running will just redirect the request?

So this means all/some of the cache will be stored in the remote and not where bazel-remote is running?
Right now we use a local server as bazel-remote to which only our CI machines have access. Now, it we are to give access to all the developers, we will have to give them access to this local server. Solution for this could be replicate this cache to GCS or any bucket preferred and give developers access to this GCS bucket and not to the local server. Hence, my question, when we enable proxy backend, is the cache replicated to the enabled backend or all the cache will be stored to the backend and the machine where bazel-remote is actually running will just redirect the request?

When using bazel-remote with a proxy-backend, for cache lookups:

Cool, that means it is a replication of some kind.

Sounds like you have the answer you're looking for now?
BTW, I created a #bazel-remote channel in buildteamworld.slack.com, but I'm the only one in there, and I'm not sure how closely I can watch it.

@mostynb

Otherwise try to return a value from the proxy backend, and store that in the disk cache

Is there a way to stop this? Say if the Cache URL is http://machine-ip-address look up only in the local disk cache, if not found stop it there. But write/upload should happen to both local disk as well as proxy backend.
Similarly, when the cache URL is gcs-buket-url just look up only in the GCS bucket, We would directly use GCS bucket URL only from developer machines and we will only read from the cache here.
The above flexibility would help us to avoid unnecessary lookups, i.e when something is not found in local disk cache most likely it won't be available in GCS bucket too, say when we set up the same LRU cleaning strategy on both. Also for our CI workers, we want to avoid GCS look-up as that happens over the Internet and can be slow to download from cache.

I don't think bazel-remote currently has a way to do what you're asking for, but I probably misunderstand your setup. Would it make sense for you to run two caches, one with only disk cache and one with disk cache + cloud storage backend? Then your clients could use whichever cache server has the behaviour they want.

Is there a way to stop this? Say if the Cache URL is http://machine-ip-address look up only in the local disk cache, if not found stop it there. But write/upload should happen to both local disk as well as proxy backend.

There is no flag or something which we can pass, but this can be stopped (We will have to run a forked version for this)

Similarly, when the cache URL is gcs-buket-url just look up only in the GCS bucket, We would directly use GCS bucket URL only from developer machines and we will only read from the cache here.

Yes, if the cache URL is gcs bucket, then the bazel-remote will never come in picture.

Cool, that means it is a replication of some kind.

@mostynb So, I was going through code and found https://github.com/buchgr/bazel-remote/blob/master/cache/disk/disk.go#L715 , CMIIW but this means this is replication but for newer blobs only?? Like whenever a blob is uploaded to bazel-remote is will be stored in both local-disk and proxy (asynchronously) but the blobs which were there before enabling the proxy-backend will remain in local-disk only?
I even checked our cache and its around 325GB in local disk and 2.56GB in GCS bucket

@mostynb So, I was going through code and found https://github.com/buchgr/bazel-remote/blob/master/cache/disk/disk.go#L715 , CMIIW but this means this is replication but for newer blobs only?? Like whenever a blob is uploaded to bazel-remote is will be stored in both local-disk and proxy (asynchronously) but the blobs which were there before enabling the proxy-backend will remain in local-disk only?

That is correct.
If you wanted to trigger a resync, you could experiment with a script that gets a directory listing of bazel-remote's cache dir, extracts the AC and CAS blob hashes, and downloads + uploads each of them using http://<IP_ADDRESS>/ URLs (but you'd want to try throttling it because the proxy backends upload asynchronously and they drop upload requests if there are too many waiting requests).
Is this a reasonable summary of your desired setup?

CI runners use a local bazel-remote instance with reasonably large cache. You want these to read and write from bazel-remote's disk cache, and for bazel-remote to asynchronously upload to a GCS backend, but you do not want CI runners to get cache hits from the GCS backend.
Developers use the GCS bucket for remote cache directly (either read/write or readonly). Cache entries are never synced from GCS to the bazel-remote instance.

IIRC if you use --storage_mode uncompressed then the blobs will be stored uncompressed in both bazel-remote's disk cache and in the proxy backend.

@mostynb bazel supports zstd compression. It's just by default bazel uses cas and not cas.v2 directory (same for other directories as well). So when we in case of GCS bucket when we bypass bazel-remote bazel doesn't pull anything because the directories in GCS are *.v2 and not the ones which bazel looks for. Any particular reason why we are using suffix .v2 in bazel-remote ?

The file format of bazel-remote blobs is considered an internal detail to bazel-remote. When using --storage_mode zstd the CAS blobs are stored in compressed form, with their uncompressed sha256 hash in the filename in the disk cache, and the proxy backends include "cas.v2" in the key (for cas blobs only), to distinguish them from CAS blobs stored in uncompressed form.
IIUC when you configure bazel to use GCS as remote cache directly then you need to use http instead of the REAPI gRPC protocol, and bazel then probably assumes that these blobs are stored uncompressed. So if bazel were to download a compressed blob from GCS, it would fail the sha256 check and be rejected.
On the other hand, if you use bazel-remote with --storage_mode uncompressed, then it will store uncompressed CAS blobs in the disk cache, and also uncompresed on the proxy backends without "cas.v2" in the path name. And bazel should be able to download and understand these when using GCS directly.

IIUC when you configure bazel to use GCS as remote cache directly then you need to use http instead of the REAPI gRPC protocol, and bazel then probably assumes that these blobs are stored uncompressed. So if bazel were to download a compressed blob from GCS, it would fail the sha256 check and be rejected.

We are using http only.

On the other hand, if you use bazel-remote with --storage_mode uncompressed, then it will store uncompressed CAS blobs in the disk cache, and also uncompresed on the proxy backends without "cas.v2" in the path name. And bazel should be able to download and understand these when using GCS directly.

I tried using --storage-mode uncompressed but it didn't make any difference. It still created directories with .v2 suffix.

I tried using --storage-mode uncompressed but it didn't make any difference. It still created directories with .v2 suffix.

The disk cache always uses directories with the .v2 suffix, but in uncompressed storage mode the proxy backends are supposed to upload CAS blobs without .v2 in the path. The gcsproxy package is a wrapper for httpproxy and here's where it does that:
https://github.com/buchgr/bazel-remote/blob/1975376ebb07c02af4f787a3380fcca4f4799d93/cache/httpproxy/httpproxy.go#L127

Tested with the above flag and it is working fine. Was able to use the cache from GCS as expected. Thanks @mostynb . Maybe I'll add a flag to disable additional lookup when the cache is not found locally but for now I guess we can close this.