Add more specific results to the Abstract

An alternative to #219, which focuses on giving specific examples of where best practices were useful.

I like this one a little better than #219, it gives more takeaways while also emphasizing the box bullet points in each one.

Cool. I'll close #219 and merge this. Thanks both.


New UI: Cypress integration is missing.

Environment information
Not relevant

Description
In the previous console UI, there was a 'TEST' step where Cypress tests were executed, and it generated comprehensive reports, including screenshots and videos, as detailed in this AWS blog post: https://aws.amazon.com/blogs/mobile/running-end-to-end-cypress-tests-for-your-fullstack-ci-cd-deployment-with-amplify-console/.
However, with the new UI, the process has changed significantly. While you can still run Cypress tests during the build stage, the reporting is not there. You only see whether the tests have passed or failed, even though the documentation states, "Amplify Hosting offers a deeper integration with Cypress that allows you to generate a UI report for your tests." The configurations for report generation are still present, as mentioned in the same AWS blog post: https://aws.amazon.com/blogs/mobile/running-end-to-end-cypress-tests-for-your-fullstack-ci-cd-deployment-with-amplify-console/.
This lack of detailed is not helpful. The documentation should be updated to reflect these changes, or the previous level of Cypress support should be reinstated.

Hi @hackmajoris 👋 , thanks for reaching out. We have identified this as a bug and are actively working on a fix for it. I'll keep the thread posted with any updates.

Hi @hackmajoris, thanks for your patience. We have released a fix for this feature and you should now be able to download the test artifacts and the Cypress results from the new Amplify console experience.

Hi @hackmajoris, thanks for your patience. We have released a fix for this feature and you should now be able to download the test artifacts and the Cypress results from the new Amplify console experience.

Hey @Jay2113, while testing your fix, I can see that you can download those artifacts only  for the successful builds. For the failing one I  have just this option:

This is not very helpful, since usually you need to see those artifacts when the build fails.
The build may fail for different reasons and it can fail before executing the Cypress tests. In that case, the download of artificers can be omitted. But, if the build fails because of Cypress failed tests, the option to download the Cypress results should be in place.

Having the same issue, is there is workout for us to fetch the artifacts right now?

Having the same issue, is there is workout for us to fetch the artifacts before we get another fix?

You can use this command: aws amplify get-job --region eu-central-1 --app-id APP_ID --branch-name BRANCH_NAME --job-id JOB_NUMBER  --profile  AWS_PROFILE

@hackmajoris @Tony-Donghua-Han thank you for verifying the fix and providing feedback on allowing test artifact downloads upon failure. We are investigating into how we can support this functionality to improve the experience.

@hackmajoris @Tony-Donghua-Han we have prioritized and are actively working on a fix to enable downloading artifacts upon test failures. I'll update the thread when the fix is released. Thanks for your continued patience.

@hackmajoris @Tony-Donghua-Han 👋 , we have deployed another fix and you should now be able to download the test artifacts even when the tests fail. Can you please verify and confirm the same? Thanks!

@Jay2113 Do I need to do anything to make use of both of these fixes?
On successful builds I still do not have access to the test artifacts
And on failed build I only see the option to download the logs.
App id dsj8xdikh9gco

Hi @richardwadsworth, I see that your app dsj8xdikh9gco has a couple of branches develop and feature/e2e. The tests are configured for the feature/e2e branch, are you unable to download the test artifacts for it? Can you share a screenshot?

Hi @richardwadsworth, I see that your app dsj8xdikh9gco has a couple of branches develop and feature/e2e. The tests are configured for the feature/e2e branch, are you unable to download the test artifacts for it? Can you share a screenshot?

Hi @Jay2113 , the tests are being run in the feature/e2e branch.  I can download the test artefacts zip using "aws amplify get-job" but the options to download the test artefacts via the UI (on a successful or failed build) are not available on the UI.  Refer to the screen shot.

Hi @richardwadsworth, thanks for your continued cooperation. To expedite the troubleshooting process, we would like to setup a call with you. Can you share your availability via a DM on our community discord server. My username is Jay Raval.

@Jay2113  I can now download the artifacts for the failed builds. @richardwadsworth Try to re-run the build again. The download of artifacts it's not possible for the historical builds.

Thank for this fix. Good job!


[Request] spek

Spek helps to analyse your audio files by showing their spectrogram. http://spek.cc/

very nice very thanks


Bang operator not working

There are two things fixed in this commit:

command ids didn't reflect the id in command definition
command must be associated with debug context
To explain the second it is enough to look at StepMessageOut class.
The first element of selection must be ScalaStackFrame and continue
action should run debugging further. In buggy solution the first element
of selection is AsyncStackFrame and action does not continue debugging.

LGTM

I fail to see what the location of the icon has to do with the underlying logic. If the underlying logic is broken it needs to be fixed.

I'm sure if would be possible to somehow get the correct selection, but the current solution works fine.
LGTM

well as I got it, you get selection from view you add your handler to its toolbar. I didn't delve into it.

Hm, I didn't try this locally, but the bang button should be on the same toolbar as the other "step" buttons, right? Conceptually is very similar. View-specific buttons should do something to that view (filter, show/hide elements, etc.)

On 09/07/2015 02:54 PM, Iulian Dragos wrote:

Hm, I didn't try this locally, but the bang button should be on the
same toolbar as the other "step" buttons, right? Conceptually is very
similar. View-specific buttons should do something to that view
(filter, show/hide elements, etc.)

Yes, this is how it is now implemented.


[#49] update Loading spinner

Resolves #49

Note, new svg animation approach requires https://github.com/lumihq/purescript-lumi-components/pull/82 to access SVG module

#82 has been merged

@kimispencer is this ready enough to include in the tooltip release?

@spicydonuts yes, sorry for the delay! Let me update with our SVG stuff and should be ready to go :)


Control Corsair Link Fans

This detects my Corsair Link fans and temp sensor, but there is no option to control the fan speeds of the fans on the controller

HWInfo has no control option.


Grid CRS vs. Computer Vision

While the equal area grids are good for statistical purposes, when utilizing computer vision, the distortion of the shapes due to the projection could hinder the computer vision work.
Thought-in-progress

Concluding this though in progress :-) I think it is good to consider that a non-conformal projection distort shapes. When used in a limited domain it might still be locally conformal and then it is a moot point. Otherwise, in case of computer vision DL, I would more focus on training on better generalisation, make sure that possible distortions are represented in the training data, and/or include data augmentations (e.g. skew) that mimic such distortions.


AS923-3 frequencies marked as incorrect_frequency after PoC_v11 upgrade.

After the POCv11, hotspots in the Philippines (AS923-3) suddenly got ALL invalid beacons and witnesses. There was no change in the frequency when the upgrade to POCv11 happened. It was still the the same AS923-3 uplink frequencies but those are now incorrect_frequency. Did we missed something in the config file or something related to that?
Here's the screenshot of the frequency and the invalid witnessing caused by incorrect_frequency.

I hope the helium team can have a look and make the fix soon.

any update on this?

Thanks for raising the issue, but it's the incorrect repository. Please raise your issue here: https://github.com/gradoj/hplans/issues


(FACT-1606) split fact_precedence test into 4 other tests

Split the 5 tests of fact_precedence.rb into 4 tests and dropped the 5th test as its covered by the options tests for external and custom facts
Applied code style, added risk tags, added TestRail numbers

Tested on:
arista4-32a, ciscoxr-64a%7Bhypervisor=vmpooler%7D, cisconx-64a%7Bhypervisor=vmpooler%7D, cumulus25-64a, debian8-64a, fedora25-64a, osx1012-64a, redhat7-64a, sles12-64a, solaris11-64a, ubuntu1604-64a, windows10ent-64a, windows2016-64a

@kurtwall Updated

CLA signed by all contributors.


Typo in a tutorial command

Bug Description
The docs page: https://charmhub.io/nginx-ingress-integrator/docs/secure-an-ingress-with-tls
This command should be in lowercase in order to work using copy/paste:
Current:
OpenSSL genrsa -out ca.key 2048

Expected:
openssl genrsa -out ca.key 2048

To Reproduce
N/A
Environment
N/A
Relevant log output
N/A

Additional context
No response

Thanks. Updated.


Language server no longer starts in debug when client is in debug mode

run the html extension in vscode as extension out of VSCode
the html language server can not be attached to, it is not started i debug mode.

Debugging this down I see that  typeof v8debug === 'object'  is evaluating to false.
Must have to do with the latest version of Electron we run on.
Thinking about it, maybe this check should be removed all together. To much magic here.
It should fully be controlled by the user (a setting, like css.trace.server) and/or the code that creates the client.

dup of #106?

@aeschli this is fixed in the 2.6.x version of the client library. On which version are you seeing this ?

It is also fixed in master. Any objection to close ?


Implicitly inserting null values for mutations

I have a services database table (Postgres) with a NOT NULL constraint on one field; created_at.
When I use the ctx.prisma.mutation.createService prisma binding, it automatically adds null for each value that I don't specify, which breaks the aforementioned not-null constraint.
So when I run this:
ctx.prisma.mutation.createService({
  service_name: "test",
  status: "On",
  user: "abc123"
}, info)

it throws this error:

The second to the last null is where the created_at column is

Issue moved to prismagraphql/prisma #2755 via ZenHub


Ignore Wikidata statements marked as deprecated

Not sure whether this is done right now.
Some items have wrong coordinates that come from a reference database. Since the coordinates come from a reference database, the wrong ones are not deleted but simply marked as deprecated.

Is this similar to #618 ?

#618 is about a place that used to be something. For instance, there was a battle here.
This issue is about patently false information. For instance, the GRID is a database of research institutions, they include the approximate location of each but it is not their main purpose so the location is often off. Anyway, the locations are imported into Wikidata regularly because it is better than nothing. If you fix the coordinates, they will be inserted again at the next batch update. So the solution is to mark them as "deprecated". But what it really means is that these coordinates are wrong.

Thanks @nicolas-raoul . Better to completely ignore them, then. I guess this will be a fairly straightforward modification of our query?

Yes, better ignore them completely.
The change to the request is not obvious to me. Deprecation is not standard SPARQL, I am not sure whether it is an extension or something else.
I believe I saw a discussion recently about making deprecated results not appear if another statement is available, but I am not sure what is the status on this.

SPARQL does this for us.


ARM64/PyTorch Fatal Python error: Illegal instruction

🐛 Bug Report

[X] 📁 I've Included a ZIP file containing my librephotos log files: podman_logs.zip
[X] ❌ I have looked for similar issues (including closed ones)

📝 Description of issue:
When starting a scan from Nextcloud, the workers are crashing with the error Fatal Python error: Illegal instruction, which is coming from PyTorch.
The backend is deployed using the docker-compose.yml and Podman (4.3), on a Raspberry Pi 4 8Go v1.
This is a duplicate of https://github.com/LibrePhotos/librephotos/issues/406, but the bug is still present in both latest and dev Docker images. It was working back in November 2022, but I couldn't make it work since.
It looks like every other functionalities (that does not involve scanning new images) are working as they usually do.
🔁 How can we reproduce it:
Start a scan on an ARM64 device running in Docker/Podman.
Please provide additional information:

💻 Operating system: Raspberry Pi OS 64bits (Debian 11, up to date), kernel 5.15.84-v8+.

⚙ Architecture (x86 or ARM): ARM64 (armv8)

🔢 Librephotos version: 2023-01-30T11:15:53.089771527Z

📸 Librephotos installation method (Docker, Kubernetes, .deb, etc.): Docker

🐋 If Docker or Kubernetes, provide docker-compose image tag: both latest and dev

📁 How is you picture library mounted (Local file system (Type), NFS, SMB, etc.): Local filesystem as Docker volume

Bellow is the slightly modified docker-compose.yml I’m using :
version: "3.8"

networks:
  proxy:
    external: true

services:
  proxy:
    image: docker://reallibrephotos/librephotos-proxy:${tag}
    container_name: librephotos-proxy
    restart: always
    volumes:
      - ${scanDirectory}:/data
      - ${data}/protected_media:/protected_media
    ports: # - ${httpPort}:80
    depends_on:
      - backend
      - frontend
    networks:
      - proxy
    labels:
      traefik.http.routers.photos.entrypoints: websecure
      traefik.http.routers.photos.rule: Host(`photos.domain`)
      traefik.http.services.photos.loadbalancer.server.port: 80
      traefik.enable: true

  db:
    image: docker://postgres:13
    container_name: librephotos-db
    restart: always
    environment:
      - POSTGRES_USER=${dbUser}
      - POSTGRES_PASSWORD=${dbPass}
      - POSTGRES_DB=${dbName}
    volumes:
      - ${data}/db:/var/lib/postgresql/data
    command: postgres -c fsync=off -c synchronous_commit=off -c full_page_writes=off -c random_page_cost=1.0
    #Checking health of Postgres db
    healthcheck:
      test: psql -U ${dbUser} -d ${dbName} -c "SELECT 1;"
      interval: 5s
      timeout: 5s
      retries: 5

  frontend:
    image: docker://reallibrephotos/librephotos-frontend:${tag}
    container_name: librephotos-frontend
    restart: always
    depends_on:
      - backend

  backend:
    image: docker://reallibrephotos/librephotos:${tag}
    container_name: librephotos-backend
    restart: always
    volumes:
      - ${scanDirectory}:/data
      - ${data}/protected_media:/protected_media
      - ${data}/logs:/logs
      - ${data}/cache:/root/.cache

    environment:
      - SECRET_KEY=${shhhhKey}
      - BACKEND_HOST=backend
      - ADMIN_EMAIL=${adminEmail}
      - ADMIN_USERNAME=${userName}
      - ADMIN_PASSWORD=${userPass}
      - DB_BACKEND=postgresql
      - DB_NAME=${dbName}
      - DB_USER=${dbUser}
      - DB_PASS=${dbPass}
      - DB_HOST=${dbHost}
      - DB_PORT=5432
      - REDIS_HOST=redis
      - REDIS_PORT=6379
      - MAPBOX_API_KEY=${mapApiKey}
      - WEB_CONCURRENCY=${gunniWorkers}
      - SKIP_PATTERNS=${skipPatterns}
      - ALLOW_UPLOAD=${allowUpload}
      - DEBUG=0
      - HEAVYWEIGHT_PROCESS=${HEAVYWEIGHT_PROCESS}

    # Wait for Postgres
    depends_on:
      db:
        condition: service_healthy

  redis:
    image: docker://redis:6
    container_name: librephotos-redis
    restart: always

I did a test and scanning Nextcloud photos on aarch64 machine, and it worked fine for me.
FYI, I am using Rock 4SE (4Gb) with NVMe drive. In general, it is almost the same as RPi. I run docker, not podman. My docker-compose.yml is not modified. I rebuilt all images yesterday from source, including base and dependencies.

For me, I also have the same problem, even after pulling the latest docker-files as described on the website (https://docs.librephotos.com/1/standard_install/). Attached is the log for the backend container, which is throwing the error. For me this happens when a scan of the filesystem is started.
_backend_logs.txt

I've read on other projects that PyTorch might be compiled for arm v8.2, which has a few more instructions than arm v8-A used by the Raspberry 4 CPU Cortex A72.
What has changed since November is the release of Pytorch 1.13, and this is the version currently shipped with the Docker image :
$ podman exec -it librephotos-backend pip show torch
Name: torch
Version: 1.13.0

There is an open issue on the PyTorch repository: https://github.com/pytorch/pytorch/issues/90535 .
I added the environment variable OPENBLAS_CORETYPE=ARMV8
I tried it, and now I have this issue which is probably unrelated :
[2023-02-06 13:21:34 +0000] [140] [CRITICAL] WORKER TIMEOUT (pid:143)
Exception ignored from cffi callback <function _log_handler_callback at 0x7f74b83ac0>:
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/pyvips/__init__.py", line 132, in _log_handler_callback
    @ffi.def_extern()
  File "/usr/local/lib/python3.10/dist-packages/gunicorn/workers/base.py", line 203, in handle_abort
    sys.exit(1)
SystemExit: 1

Downgrading to torch v1.12.0 by executing into the container also seems to work, so that might be a workaround in the meantime

Probably the same issue as in https://github.com/LibrePhotos/librephotos/issues/738
It could be that this dependency in this line here changed: https://github.com/LibrePhotos/librephotos-docker/blob/00d97785992b8417d82489614d187e38b481288c/backend/base/Dockerfile#L61
We need a custom pytorch dependency, because raspberry pis do not support the whole arm instruction set. We solved this issue by using this 3rd party pytorch dependency: https://github.com/KumaTea/pytorch-aarch64
Would be great if one of you could figure out, which version works correcty as my raspberry pi died a while ago.

I can help with this, however I am not very experienced in the development of Docker and pythonprojects. So if you have specific instructions, I would be happy to follow them :)

I've done it for multiple PyTorch versions on Jetson Xavier, sadly they are using arm v8.2 so I can't reuse the wheels (it took 1.5 hours to build PyTorch with CUDA bindings on AGX Xavier, which has 8 cores and 32Go of RAM).
It's not hard to build the wheels, you need to install recent versions of the compilation dependencies (like CMake and Ninja). The PyTorch build script is highly parametrized, so you also need to know which acceleration/compute libraries you want to work with and install them as system dependencies. The instructions to compile for Jetson devices can be found here (theoretically, you don't need to apply the patches since they are for CUDA).

I confirm that my second issue is unrelated, if I set the Gunicorn worker timeout from 30s (default value) to 300s in the entrypoint.sh, the workers are crashing arround 10 minutes latter. For now I deactivated the timeout by setting it to 0 (for people looking for the solution: you shouldn't do this in production) and the scan could finish.
The workers did successfully process all pictures without errors, so the fix for the initial problem is to add OPENBLAS_CORETYPE=ARMV8 in the environment variables.

I changed a couple of things in the base image and in the entrypoint file. It would be great, if you could test, if it works again.

Should work now in general, but the timeout issue still persists. Would be great if somebody else creates a separate issue for the timeout issue.

The current dev image doesn't run on my Raspberry, again with Illegal instruction error, this time coming from PyTorch 2.0.0 : https://github.com/pytorch/pytorch/issues/97226
I will try to downgrade to 1.13.1 and see what happen.

After the downgrade, I don't see any errors.


enable gocognit linter

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: #938
What is the new behavior?

Other information
First I load the files with the linter turned off to check the ci tests.
I have the linter enabled locally and with the last commit I enabled the linter in the remote repository.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c6e45cd) 68.48% compared to head (e39fb38) 38.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1037       +/-   ##
===========================================
- Coverage   68.48%   38.69%   -29.80%
===========================================
  Files         252      208       -44
  Lines       25155    22009     -3146
===========================================
- Hits        17228     8516     -8712
- Misses       7069    13139     +6070
+ Partials      858      354      -504

Flag
Coverage Δ

?

go-1.20.x
38.68% <100.00%> (-29.59%)
:arrow_down:

go-1.21.x
38.69% <100.00%> (-29.77%)
:arrow_down:

integration
?

macOS
?

ubuntu
38.69% <100.00%> (+0.01%)
:arrow_up:

unit
38.69% <100.00%> (-0.04%)
:arrow_down:

windows
?

ydb-22.5
?

ydb-23.1
?

ydb-23.2
?

ydb-23.3
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I noted the comment //nolint:gocognit  because if I rewrite a function internal/cmd/gtrace.findGtraceGen, the autotest breaks either tests / unit (1.21.x, windows)

Summary of review:

Need to rebase to master
Need to add exclude-rules into .golangci.yaml config for:

all tests
packages log and metrics

Need to add unit tests for newest funcs
Minor issues see in full review


fix: role permissions and add listGrants to the viewer and editor roles

Add listGrants permission to the viewer and editor roles

on hold for now, needs clarification

closed, the failure happens is in RoleFromOCSPermissions which currently has no knowledge if the role is for a project or personal space. Fix pending, cc.: @rhafer


Yealink 5x models EOL

Yealink 5x models are at EOL stage and discontinued https://www.yealink.com/en/product-detail/microsoft-teams-phone-t56a, please remove them from Teams certified phones, cause so far it is confusing. Thank you!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: aaaef9e1-8f1c-ebf0-7856-4c007342a2c3
Version Independent ID: 3eaf671f-375e-8787-9c66-3947c3606559
Content: Devices for Teams - Microsoft Teams
Content Source: Teams/devices/teams-ip-phones.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

Hi @mushmasha, thank you for your feedback.
Yealink T55A, T56A, and T58A phones are not included in the certified Teams phone table/section. They are only included in the Firmware versions table/section because they are still under extended support for software bug fixes.

Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


added quite a lot of images for bungalow, storey building and highrise

thank you @Samuel Bamgbola @.***>
On Tue, Oct 17, 2023 at 10:22 PM Samuel Bamgbola @.***>
wrote:

Merged #166 https://github.com/mlsanigeria/AI-Hacktober-MLSA/pull/166
into main.
—
Reply to this email directly, view it on GitHub
https://github.com/mlsanigeria/AI-Hacktober-MLSA/pull/166#event-10684005333,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOH2ISIAS6E6C76YIZZ4FKDX73ZIVAVCNFSM6AAAAAA5YYIE7OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGY4DIMBQGUZTGMY
.
You are receiving this because you were mentioned.Message ID:
@.***
com>


TreeMap.narrow() is not public

Are there other static methods in impl classes that are package private but should be public?

We could move the tests to a separate package to see these problems.
I tried, but HashArrayMappedTrie, RedBlackTree, Comparator is not public and used in tests.
Also, the following methods are not public:

CharSeq.unfold*, CharSer.(CharFunction|CharUnaryOperator)
Lazy.narrow
PriorityQueue.(collector|tabulate|fill)
Array.unfold*
Vector.unfold*
CharSeq.indexOfOption
Queue.unfold*
LinkedHashSet#ofAll(java.util.stream.Stream<? extends T>)
Try.NonFatalException#of

and shouldMatchCustomTypeWithUnapplyMethod and a few more from APITest aren't working.
I will commit the production code changes, without moving all the tests (let's do that when no PRs are pending).

regarding the unfold* they were meant to be public. I missed it because I first added them to List and that's an interface, no need for the public there. I should have added the public when implementing it in classes, but I missed it. So yes, it should be made public.

@paplorinc Thank you for providing the list of non-public methods!

I will commit the production code changes, without moving all the tests (let's do that when no PRs are pending).

Please let's keep the tests in the current packages. This is junit best practice and saves us from headaches when performing package-private test scenarios. We will keep an eye on the static methods in our code-reviews. In the worst case a new method is not visible for the end-user. This can be fixed.

when performing package-private test scenarios

We don't have many of those (nor should we do that often).

@paplorinc Ok, I'm open minded to the idea of moving the test classes. Let's put the tests for classes a.b.c/* in a package a.b.c/test/.


Store complete initialized data in metadata.yaml

Save full test metadata at the end of initialization.
Create metadata.yaml from the saved dictionary.
Include basic test coverage for the change.
Resolves #419.

Thanks for the review, @lukaszachy.


RC v2.6.3

Description
RC Update to develop
Type of change

[x] This change requires a documentation update

How Has This Been Tested?
Tested with dependent systems and CI
Test Configuration:

Operating system: OS X Big Sur
Version number: Python 3.9
Any details about your local setup that are relevant:

Checklist:

[x] Make sure you are merging into the develop (not main) branch
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] Add a note to Changelog.rst, summarising the changes
[x] Add yourself to AUTHORS.rst and .zenodo.json

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 92.276%

Files with Coverage Reduction
New Missed Lines
%

aacgmv2/wrapper.py
2
96.32%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
1121

Relevant Lines:
1200

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 92.276%

Files with Coverage Reduction
New Missed Lines
%

aacgmv2/wrapper.py
2
96.32%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
1121

Relevant Lines:
1200

💛  - Coveralls


Alphabetic and Numeric patterns added

Fixes Issues #395 #397 #437 #438 #441 #442 #443 #449 #450 #451 #452 #453 #454 #455 #456 #457
AND
#684 #685 #686 #781 #782 #783 #784 #785 #786 #787 #791 #792 #797 #798 #799 #801 #802 #806 #807 #808 #809 #810 #832 #833

@aryashah2k 40 patterns added


Save file is broken

For some reason, the save file is having issues. @DaVinci789, will you look at it because I'm stuck. It was working fine but it suddenly stopped working without me changing anything.

Fixed with #28e2c84


Copilot for Xcode GUI scrolling [BUG]

The current GUI app has a scrollable view for the entire window which causes content to scroll behind the app's Close/Minimise/Full-Screen buttons.  This is not usual behaviour for a macOS app.
To re-create the bug...

Resize the GUI height to be small enough for content to go beyond the bottom of the app window.
Scroll the view
Content at the top of the GUI goes behind the app Close/Minimise/Full-Screen buttons.

Released in 0.8.6


Incorrect this context for resolveConflict causing CRO to lose context to itself

During runtime, when attempting to access CRO methods within the scope of resolveConflict, this loses its context and no longer refers to the implemented CRO but rather points to the hashgraph (i.e. this === HashGraph). This is caused by passing cro.resolveConflicts during the hash graph construction in the TopologyObject.
Fixing this is crucial to allow implementors of the CRO interface to access their implementation methods and states.
The problematic line of code is located here: https://github.com/topology-foundation/ts-topology/blob/cda5dd5300be6656f0b53738fa9e1c1054835d80/packages/object/src/index.ts#L59

fixed with #243


ink! smart contract without events should have any type

Describe the bug
I have a smart contract that does not emit any events

https://github.com/swanky-dapps/marketplace/issues/9

the problem is when I do npx squid-ink-typegen (+ args ofc)
it generates content like:
export function decodeEvent(hex: string): Event {
    return _abi.decodeEvent(hex)
}

export type Event = never

Now it it impossible to build the squid
src/abi/marketplace.ts:1412:5 - error TS2322: Type 'any' is not assignable to type 'never'.

1412     return _abi.decodeEvent(hex)
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 1 error in src/abi/marketplace.ts:1412

FIX is to return any if there is no event present

export type Event = any

or
2. do not generate decodeEvent function

It looks correct to me. Why do you want to use this function if there are no events?

Maybe we should make it similar to evm-typegen, so there will be no such issues.
@tmcgroul what do you think?

Maybe we should make generated files similar to evm-typegen, so there will be no such issues. @tmcgroul what do you think?

Fixed just the type issue for now. I think there is no reason to make generated files similar to evm-typegen... but some features would be useful to implement


Add heroku-postbuild script to build app on Heroku

We might not want to merge this pull request: https://devcenter.heroku.com/changelog-items/1557


[Jackett] Fails to install

Which addon?

Addon name : Jackett NAS
Addon version : 0.20.371

Describe the bug

Fresh install of Jacket addon fails
To Reproduce

Full addon log

Can't install ghcr.io/alexbelgium/jackett-armv7:0.20.371: 500 Server Error for http+docker://localhost/v1.41/images/create?tag=0.20.371&fromImage=ghcr.io%2Falexbelgium%2Fjackett-armv7: Internal Server Error ("Head "https://ghcr.io/v2/alexbelgium/jackett-armv7/manifests/0.20.371": denied")
System

Supervisor version:  2021.12.2
Host system version:  Raspbian 11, HA 2021.12.10

I'm in the process of automating the builds it should arrive in around 30min and hopefully work :)

On its working now, just tested it

I deeply apologize. I enabled autobuild as recommended by the HA guidelines, and it brought 2 big issues :
Multi-arch base images are not supported (it needs a pull --platform tag that is not implemented yet, and the system is very complex to fork and customize)
Upgrade from a locally built addon to an autobuilt addon is not supported : the addon still tries to locally build and then provides a failure message as it doesn't find a local image...

I have decided to revert the changes. This means that everyone that has installed the new versions pushed since 2 days will have to restore a backup, or uninstall the app and reinstall it...
Thanks for your understanding.

Closed as the source of the issue changed - local builds is back


#29, #30 and #44 change the error catching and message consumption limit mechanism to topic-partition-based and apply topic-based parallel programming to optimize program running time

#29, #30 and #44 change the error catching and message consumption limit mechanism to topic-partition-based and apply topic-based parallel programming to optimize program running time

thank you Furkan <3


set log level on the fly

add dropdown to change logLevel from the info box ("Options")

will apply to latest


Allow creation of apps in empty mercurial repos

Currently create-react-app fails on newly created mercurial repos. This change fixes that.

Should we also permit .hgignore?

Good point, I added .hgignore

What about allowing .*?

Something like
function isSafeToCreateProjectIn(root) {
  const validFiles = [
    'Thumbs.db',
    'README.md',
    'LICENSE',
    'web.iml',
  ];
  return fs.readdirSync(root).every(file => /^\./.test(file) || validFiles.indexOf(file) >= 0);
}

I'm not sure if allowing all dotfiles is what we want to do.
/cc @gaearon

Looks good to me.

I'd like to avoid allowing more dotfiles than necessary. Can get confusing with .babelrc. This PR looks good.


MatsSockets: ITest: Make better Dummy Authorization plugin, including userId

String: "DummyAuth:{userId}:{TTL}"
UserId's beginning with "debug" has debug-allowed.
UserId's beginning with "invalid" are invalid.
Also test check when using timed-out tokens.

Closed by https://github.com/stolsvik/mats/commit/6f3ab608e82ce790835abcff5e0dfcc5a121458a


Fix SBD rate

Fixes #1788
Changes
Temporarily use open price instead of close since it is closer to the actual price for steem dollar

BTC price for SBD is still wrong. And open doesn't give us latest price. We can remove get ride if the chart and use Bittrex API instead of CryptoCompare unless they answered your email.

Is this PR supposed to change open instead of close or it just changes ticker?

@Sekhmet now just change the ticker

There is still an issue with estimated account but this fix SBD rate


IndexError when trying to print a list of routes

I have a small application divided into two files:
views.py and api.py, when developing I run a local server and I wanted to see a list of all routes.
      from app.views import app as home_app
      from app.api import app as api_app
      main_app = bottle.Bottle()

      @main_app.route('/static/<filepath:path>')
      def server_static(filepath):
          return bottle.static_file(filepath, root='static')

      main_app.merge(home_app.routes)
      main_app.mount("/api/", api_app)
      print("DEBUG %s:" % main_app.routes)

This results in the following error:
Traceback (most recent call last):
  File "./manage.py", line 93, in <module>
    args.func(args)
  File "./manage.py", line 62, in serve
    print("DEBUG %s:" % main_app.routes)
  File "/home/oznt/Software/tiny-cms/tiny/bottle.py", line 616, in __repr__
    cb = self.get_undecorated_callback()
  File "/home/oznt/Software/tiny-cms/tiny/bottle.py", line 598, in get_undecorated_callback
    func = func[0]
IndexError: list index out of range

If I exclude the API application (e.g. I don't mount it) I don't see the error.
The solution is pretty easy:
@@ -593,7 +593,9 @@ class Route(object):
                 # pick first FunctionType instance from multiple arguments
                 func = filter(lambda x: isinstance(x, FunctionType),
                               map(lambda x: x.cell_contents, attributes))
-                func = list(func)[0]  # py3 support
+                func = list(func)  # py3 support
+                if len(func) > 0:
+                    func = func[0]

Would you like to receive a PR for this?

I believe this issue is related to #1042 .


Don't show "copied to Clipboard"

See https://github.com/nichtich/wikidata-cli/commit/925cf7e05a5138b6802502fdc0b398b3a35beaa8 for an additional option to suppress such output - a cleaner solution would be to not show it in the first place

yep. The cleanest to do would probably be to rely on an opt-in option ( -cb, --clipboard?) to copy to the clipboard.
Then we might simply need a global config file to make it the default/preferred behavior for the clipboard addicts as myself ^^
A remarque on the current implementation: if the command is piped, the Copied to Clipboard will not come polluting as it is not written on stdout but directly on /dev/tty (see copy2cb's code). But it's hacky and quite counter-intuitive (just like those horrible progress stats when you pipe a curl command), so I wouldn't mind getting over it

The config file would be ~/.wdconfig, right? The --clipboard option seems to be a global option for all subcommands such as --language and --verbose.

hello @nichtich, I have been cleaning out all those fancy clipboard behaviors, could you give it a look before I make it a major release? 1071551

introduced a global config mechanism in 7c4a946


Remove webpack and merge

There are a couple of small hunks I'd leave (@goldhand line in contributors file), and the Postgresql line in cookiecutter.json, but I think that, otherwise, this does the job.
I'd like someone more familiar with the release procedure etc. to check this over, run tests etc. or let me know where to look for such a procedure.
ssteinerX

Aside from the failing tests, this looks pretty good.Hopefully I can help with that today. 😄
Yes, @goldhand needs to always remain in the contributors' file.

I didn't add myself either, now that I think about it.

Fixed two errors as noted in pull request and as pointed out by @jayfk.

Trying to figure out test running, accidentally generated cookiecutter_django..egg-info, wasn't excluded by .gitignore, made it so.

Can anyone more familiar with the test suite point me at the source of what appears to be an errant tag in one of the Jinja templates (from other errors, this one's particularly obtuse).
Full test failure output at: travis.
This a local one-off:
$ tox -e py -- -k test_default_configuration
____________________________________________________ test_default_configuration _______

cookies = <pytest_cookies.Cookies object at 0x104d0d510>
context = {'author_name': 'Test Author', 'description': 'A short description of the project.', 'domain_name': 'example.com', 'email'<EMAIL_ADDRESS>...}

    def test_default_configuration(cookies, context):
        result = cookies.bake(extra_context=context)
>       assert result.exit_code == 0
E       assert -1 == 0
E        +  where -1 = <Result TemplateSyntaxError("Encountered unknown tag 'endif'.",)>.exit_code

tests/test_cookiecutter_generation.py:53: AssertionError

Can anyone more familiar with the test suite point me at the source of what appears to be an errant tag in one of the Jinja templates (gleaned from other errors, this one's particularly obtuse).

That comes from {{cookiecutter.project_slug}}/{{cookiecutter.project_slug}}/templates/base.html. The template is pretty insane. It switches between the cookiecutter context and the django context back and forth. Keep fiddling :)

I think there is an lonely {% endif %} on line 86 in cookiecutter-django/{{cookiecutter.project_slug}}/README.rst that is causing the error.

I'm sorry, @ameistad, @jayfk there were no winners in our find the lonely endif contest.
It was Line 58 in README.rst and, fortunately, it was pretty unambiguous with only one % if % above line 5 (with its corresponding % endif % blessedly nearby).

This is part of the resolution for #774


Publish new NPM with latest changes

Hi, I just noticed that the latest changes, such as the implementation of observing the value and updated the number parameter accordingly, have not been published. Would you mind to release a new NPM with those changes?
Thanks

Hi, sorry for the delay @soeffing ,  I requested permission in npm for @thiagoc7, When he answers we publish.
For now, you use in your package.json as "ember-cli-maskmoney": "clairton/ember-cli-maskmoney#master".

@clairton, please test if you can npm publish

Thanks @thiagoc7.
@soeffing the new version is available at npm.
I close this issue!


words already colored during first use

I just built from source and used it for the first time and some words are already colored green/red/yellow even though I would like everything to be grey. idk if this is on purpose or not. I ran sed -i 's/1/0/g' words.json (repeat with 2,3) to make everything grey. Also I had this error while building 'Package alsa was not found in the pkg-config search path. Perhaps you should add the directory containing `alsa.pc'' which is fixed by installing libasound2-dev or alsa-lib-devel on most distros so maybe add a dependency list on the install page

Ok so I will address the two issues separately:
Issue #1 is completely normal; this is because in order to allow for immediate testing of new features I kept some example texts in the source code. Fixing this is very simple; all you have to do is go into the folder of the language you're studying and removing the file "words.json" as well as the file "dictionary.txt" (if it is there)
Issue #2: For issue #2 all you have to do is install alsa with this command:
sudo apt install libasound2-dev


Drag only in Horizontal direction prevent vertical direction dragging.

Problem:
JSBin/JSFiddle demonstrating the problem:
https://jsfiddle.net/riyamitra/xtsz58od/5/
https://stackoverflow.com/questions/59523965/sortable-js-swap-direction-horizontal-not-working
I am facing problem with draggable direction in horizontally scrollable divs. I have used swaped true in horizontal list. I am trying to prevent the vertical direction but it still dragging in vertical direction. how can i prevent its dragging. The dragging element is not revert back to its position if drag vertically. please see jsfiddle/ stackoverflow post for the issue.

This looks like an issue with the swap plugin.
When hovering over the same item it picked up, it should cancel the operation, as you've described.


Fix Japanese translation for JSONata editor

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

There are a few inaccurate translation in Japanese  JSONata editor message.
This PR fixes them.
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage remained the same at 68.341% when pulling 7bd7c99dd47ef9bfa2b747fbfe9372f88b1715b9 on node-red-hitachi:fix-Japanese-editor-message-for-JSONata into a5d7f7acceb4c77d1e91feca63a3619164d8b06b on node-red:master.

@HiroyasuNishiyama can you resolve the conflicts between this and the master branch?

Merged with current master branch.


Test failing only at adopt: java/net/SocketImpl/BadUsages.java

Test: https://github.com/ibmruntimes/openj9-openjdk-jdk13/blob/openj9/test/jdk/java/net/SocketImpl/BadUsages.java
Build: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_Advanced/91/

Test is failing at adopt jenkins on jdk13 openj9 and hotspot builds on linux and intermittently on p linux. Passes fine when recreated on our intranet's jenkins and locally with the same builds.
The failing test is called testConnect3() which creates a socket:
var remote = new InetSocketAddress("blah-blah.blah-blah", 80);
and then connects to it:  impl.connect(remote, 0)
expecting an IOException but does not throw one.

Error:
11:34:28  test BadUsages.testConnect3(): failure
11:34:28  java.lang.AssertionError: Expected IOException to be thrown, but nothing was thrown
11:34:28  	at org.testng.Assert.expectThrows(Assert.java:1018)
11:34:28  	at BadUsages.testConnect3(BadUsages.java:113)

I've been able to replicate this on my RHEL7 laptop. Are you certain it's an adoptopenjdk issue as opposed to a Linux distribution issue? Do you have a passing run from RHEL/CentOS elsewhere?

My linux distribution is ubuntu so could potentially be a CentOS/RHEL issue? But it was failing on ubuntu and debian machines at adopt

Suggest liaising with @Willsparker as he has an Ubuntu 16 VM on his laptop which I believes shows the failure, so should provide an opportunity to play "Spot The Difference" ;-)

@adam-thorpe
The output for the failing test on the Ubuntu1604:
vagrant@adoptopenjdkU16:/vagrant/openjdk-tests/TestConfig$ make _jdk_custom

Running make 4.1
set TEST_ROOT to /vagrant/openjdk-tests/TestConfig/..
set JDK_VERSION to 13
set JDK_IMPL to openj9
set JVM_VERSION to openjdk13-openj9
set JCL_VERSION to latest
set JAVA_HOME to /vagrant/jdk-13+30
set SPEC to linux_x86-64_cmprssptrs
Running jdk_custom ...
"/vagrant/jdk-13+30/bin/java" -version
openjdk version "13" 2019-09-17
OpenJDK Runtime Environment AdoptOpenJDK (build 13+30-201908140434)
Eclipse OpenJ9 VM AdoptOpenJDK (build master-81195db9c, JRE 13 Linux amd64-64-Bit Compressed References 20190814_37 (JIT enabled, AOT enabled)
OpenJ9   - 81195db9c
OMR      - 6e99760b
JCL      - 2337332cb3 based on jdk-13+30)
make[1]: Entering directory '/vagrant/openjdk-tests'
make[2]: Entering directory '/vagrant/openjdk-tests/openjdk'

===============================================
Running test jdk_custom_0 ...
===============================================
jdk_custom_0 Start Time: Thu Aug 15 01:23:40 2019 Epoch Time (ms):<PHONE_NUMBER>860
"/vagrant/jdk-13+30/bin/java" -Xshareclasses:destroyAll; "/vagrant/jdk-13+30/bin/java" -Xshareclasses:groupAccess,destroyAll; echo "cache cleanup done";

Attempting to destroy all caches in cacheDir /home/vagrant/javasharedresources/

JVMSHRC806I Compressed references persistent shared cache "sharedcc_vagrant" has been destroyed. Use option -Xnocompressedrefs if you want to destroy a non-compressed references cache.
JVMSHRC005I No shared class caches available
cache cleanup done
variation: NoOptions
JVM_OPTIONS: -Xcompressedrefs
{ itercnt=1; \
mkdir -p "/vagrant/openjdk-tests/TestConfig/scripts/testKitGen/../../../TestConfig/test_output_15658574208494/jdk_custom_0"; \
cd "/vagrant/openjdk-tests/TestConfig/scripts/testKitGen/../../../TestConfig/test_output_15658574208494/jdk_custom_0"; \
"/vagrant/jdk-13+30/bin/java" -Xmx512m -jar "/vagrant/openjdk-tests/TestConfig/scripts/testKitGen/../../../../jvmtest/openjdk/jtreg/lib/jtreg.jar" \
-agentvm -a -ea -esa -v:fail,error,time,nopass -retain:fail,error,*.dmp,javacore.*,heapdump.*,*.trc -ignore:quiet -timeoutFactor:8 -xml:verify -concurrency:2 -vmoptions:"-Xmx512m -Xcompressedrefs " \
-w ""/vagrant/openjdk-tests/TestConfig/scripts/testKitGen/../../../TestConfig/test_output_15658574208494/jdk_custom_0"/work" \
-r "/vagrant/openjdk-tests/TestConfig/scripts/testKitGen/../../../../jvmtest/openjdk/report" \
-jdk:"/vagrant/jdk-13+30" \
"/vagrant/openjdk-tests/TestConfig/scripts/testKitGen/../../../openjdk/openjdk-jdk/test/jdk/kava/net/SocketImpl/BadUsages.java"; \
if [ $? -eq 0 ] ; then echo ""; echo "jdk_custom_0""_PASSED"; echo ""; cd /vagrant/openjdk-tests/TestConfig/scripts/testKitGen/../../..;  else echo ""; echo "jdk_custom_0""_FAILED"; echo ""; fi; } 2>&1 | tee -a "/vagrant/openjdk-tests/TestConfig/scripts/testKitGen/../../../TestConfig/test_output_15658574208494/TestTargetResult";
Error: Cannot find file: /vagrant/openjdk-tests/TestConfig/scripts/testKitGen/../../../openjdk/openjdk-jdk/test/jdk/kava/net/SocketImpl/BadUsages.java

jdk_custom_0_FAILED

"/vagrant/jdk-13+30/bin/java" -Xshareclasses:destroyAll; "/vagrant/jdk-13+30/bin/java" -Xshareclasses:groupAccess,destroyAll; echo "cache cleanup done";

Attempting to destroy all caches in cacheDir /home/vagrant/javasharedresources/

JVMSHRC806I Compressed references persistent shared cache "sharedcc_vagrant" has been destroyed. Use option -Xnocompressedrefs if you want to destroy a non-compressed references cache.
JVMSHRC005I No shared class caches available
cache cleanup done
jdk_custom_0 Finish Time: Thu Aug 15 01:23:42 2019 Epoch Time (ms):<PHONE_NUMBER>065
make[2]: Leaving directory '/vagrant/openjdk-tests/openjdk'
make[1]: Leaving directory '/vagrant/openjdk-tests'

TEST TARGETS SUMMARY
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
FAILED test targets:
	jdk_custom_0

TOTAL: 1   EXECUTED: 1   PASSED: 0   FAILED: 1   DISABLED: 0   SKIPPED: 0
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

_jdk_custom done

Output of failing Test:
make _jdk_custom

Running make 4.1
set TEST_ROOT to /vagrant/openj9-openjdk-jdk13/openjdk-tests/TestConfig/..
set JDK_VERSION to 13
set JDK_IMPL to openj9
set JVM_VERSION to openjdk13-openj9
set JCL_VERSION to latest
set JAVA_HOME to /vagrant/jdk-13+30
set SPEC to linux_x86-64_cmprssptrs
Running jdk_custom ...
"/vagrant/jdk-13+30/bin/java" -version
openjdk version "13" 2019-09-17
OpenJDK Runtime Environment AdoptOpenJDK (build 13+30-201908140434)
Eclipse OpenJ9 VM AdoptOpenJDK (build master-81195db9c, JRE 13 Linux amd64-64-Bit Compressed References 20190814_37 (JIT enabled, AOT enabled)
OpenJ9   - 81195db9c
OMR      - 6e99760b
JCL      - 2337332cb3 based on jdk-13+30)

...

test BadUsages.testAccept1(): success
test BadUsages.testAccept2(): success
test BadUsages.testAccept3(): success
test BadUsages.testAccept4(): success
test BadUsages.testAccept5(): success
test BadUsages.testAccept6(): success
test BadUsages.testAvailable1(): success
test BadUsages.testAvailable2(): success
test BadUsages.testAvailable3(): success
test BadUsages.testBind1(): success
test BadUsages.testBind2(): success
test BadUsages.testBind3(): success
test BadUsages.testBind4(): success
test BadUsages.testConnect1(): success
test BadUsages.testConnect2(): success
test BadUsages.testConnect3(): failure
java.lang.AssertionError: Expected IOException to be thrown, but nothing was thrown
	at org.testng.Assert.expectThrows(Assert.java:1018)
	at BadUsages.testConnect3(BadUsages.java:113)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

...

===============================================
java/net/SocketImpl/BadUsages.java
Total tests run: 39, Failures: 1, Skips: 0
===============================================

...

TEST TARGETS SUMMARY
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
FAILED test targets:
	jdk_custom_0

TOTAL: 1   EXECUTED: 1   PASSED: 0   FAILED: 1   DISABLED: 0   SKIPPED: 0
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

I've found a difference, this is part of the output from my local machine:
ant -f ./src/build_envInfo.xml -DTEST_JDK_HOME=/root/documents/jdk-13+30_j9_08-15/
Buildfile: /root/documents/openj9-openjdk-jdk13/openjdk-tests/TestConfig/src/build_envInfo.xml

build:

clean:
   [delete] Deleting: /root/documents/openj9-openjdk-jdk13/openjdk-tests/TestConfig/autoGenEnv.mk
   [delete] Deleting directory /root/documents/openj9-openjdk-jdk13/openjdk-tests/TestConfig/src/bin
   [delete] Deleting: /root/documents/openj9-openjdk-jdk13/openjdk-tests/TestConfig/src/EnvDetector.jar

init:
    [mkdir] Created dir: /root/documents/openj9-openjdk-jdk13/openjdk-tests/TestConfig/src/bin

compile:
     [echo] Ant version is Apache Ant(TM) version 1.9.6 compiled on July 20 2018
     [echo] ============COMPILER SETTINGS============
     [echo] ===fork:                         yes
     [echo] ===debug:                        on
    [javac] Compiling 3 source files to /root/documents/openj9-openjdk-jdk13/openjdk-tests/TestConfig/src/bin

dist:
      [jar] Building jar: /root/documents/openj9-openjdk-jdk13/openjdk-tests/TestConfig/src/EnvDetector.jar

run:
     [java] System.getProperty('os.name')=Linux
     [java]
     [java] System.getProperty('os.arch')=amd64
     [java]
     [java] System.getProperty('java.fullversion')=13+30-201908150448
     [java] JRE 13 Linux amd64-64-Bit Compressed References 20190815_39 (JIT enabled, AOT enabled)
     [java] OpenJ9   - 41360de87
     [java] OMR      - 6e99760b
     [java] JCL      - 2337332cb3 based on jdk-13+30
     [java]
     [java] System.getProperty('sun.arch.data.model')=64
     [java]
     [java] System.getProperty('java.vm.name')=Eclipse OpenJ9 VM
     [java]

However on the failing adopt build:
[java] System.getProperty('java.fullversion')=null
Not sure if this is important or not, but on other passing adopt tests this property is filled as normal

Test passes on test-scaleway-ubuntu1604-x64-1 at adopt. Can't see any differences between this machine and any of the others

@adam-thorpe Using your steps, i'm unable to reproduce the error. The test passes on some of the adopt debian and ubuntu (softlayer and packet) machines. It also passes on a fyre RHEL 7 machine.
Im unable to view your original grinder job, but do you know of any specific adopt machines on which it fails?

This information may be outdated and fixed by the DNS configuration changes documented here https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/984. I'll run a quick grinder and have a look, it's strange that Stewart was able to recreate this problem locally as well if this is the case

Grinder passed

The test passed on my Ubuntu 16 Fyre machine

OK Let's close this and we can re-open if it shows up again.


Warnings when using /Za

DirectXMath.h header does not compile with /Za (disable language extensions).
1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10586.0\um\DirectXMath.h(630): error C2467: illegal declaration of anonymous 'struct'
1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10586.0\um\DirectXMath.h(658): error C2467: illegal declaration of anonymous 'struct'
1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.10586.0\um\DirectXMath.h(705): error C2467: illegal declaration of anonymous 'struct'

DirectXMath makes extensive use of anonymous unions and structs which are a Microsoft extension. Supporting /Za would require extensive changes to the library and client code, or extensive use of alternative codepaths or macros.

The problem here is actually /Za
anonymous unions are part of the C++ and C99 standard.
anonymous structs are part of the C11 standard.

Note that DirectXMath is compatible with the new VS 2017 /permissive- conformance switch.


please enable netty-epoll in addb-lettuce

lettuce provides event handling like epoll.(https://github.com/lettuce-io/lettuce-core/wiki/Native-Transports)
It seems that addb_lettuce does not currently use netty-epoll.
For better performance, please provide the ability to use netty-epoll.

I think this issue should be moved to 'addb-loader' repository.
https://github.com/addb-swstarlab/addb-loader/issues
Please move this issue to 'addb-loader' repository.


Line2D Curve for Width

This feature request shouldn't be too hard to finish.
it is about adding variable width to the line based on a curve, an example of this would be the LineRenderer in unity
https://docs.unity3d.com/Manual/class-LineRenderer.html
We already have the curve texture we can use for this and it would help immensely in making trails and the like.

Definitely would be a nice thing to have :D Right now we're using a draw_polyline call over a Curve2D, but this would allow us to taper it.

Isn't it what Line2D does? It might just need a simple option to follow a Curve2D instead of a fixed array of points.

@akien-mga What OP wants here is a way to adjust the width of the line over its course, which currently can't be done with Line2D or Path2D (to my knowledge).

Yes what I am looking for is functionality that allows us to draw something like this.

It is kinda possible to do by providing a texture, but it doesn't look very nice and doesn't support tiling unless you do it manually in the image editing software.

Here it comes

Is that what you want ?
If it's okay I can create a pull request.

Is that only for Line2D? What about Curve2D?

I have only done Line2D.
Curve2D is used internally by Path2D.  Path2D is not a node you should use for rendering but for logic processing.

Sorry, meant Path2D. But regardless, I see no other way to get a bezier curve drawn on-screen than drawing a line over said a dynamically populated Path2D.

It would be too cumbersome to add a Path2D/Curve2D to Line2D. It might be better to directly extend Path2D with GdScript

Well, that's sorta what we do, but how would I make it taper?

@CedNaru Exactly what I was looking for, if you could make a PR for it that would be great. Making a Path2D renderer would be a whole separate thing.

#28565

Fixed by #28565.


Upgrading number of PyLint jobs from 1 to 10.

Marked "don't merge" for now because I want to actually time the difference on the entire codebase. Working on it now.

LGTM

@tseaver May not be worth it.
At the current HEAD in master (or it was current until #2400 was merged)
$ git log -1 --pretty=%H
64353b5639a03ce9d2538eaf5fc112ea9019662e
$ rm -fr .tox/lint
$ time tox -e lint
...
real    3m17.283s
user    3m7.844s
sys     0m8.716s

at the HEAD in this PR
$ git log -1 --pretty=%H
dad810adf293f06dea50a459095a0e60924eb26f
$ rm -fr .tox/lint
$ tox -e lint --recreate --notest
$ time tox -e lint
...
real    3m26.578s
user    3m15.860s
sys     0m18.952s
$ time tox -e lint
...
real    3m21.792s
user    3m11.124s
sys     0m18.400s

So the extra jobs either

Add overhead without adding speed
Don't actually get set unless I do something else

https://github.com/PyCQA/pylint/issues/479

That PyCQA issue is supposed to be long-ago fixed.

@tseaver I'm pretty sure we don't get the speed-up because of the changes introduced in #1974 (I was on paternity leave at the time so didn't fully understand the change). In particular, the fact that we run Pylint on each file separately.

Will revisit this some other time.


Confused with solc version

I want to use mythirl to test a given contract with any solidity version.
I look at the doc and found that  --solv can change the specified solidity complier version，but then I find --solv is using py-solc which only can install following version to /root/.py-solc:
 v0.4.1, v0.4.11, v0.4.12, v0.4.13, v0.4.14, v0.4.15, v0.4.16, v0.4.17, v0.4.18, v0.4.19, v0.4.2, v0.4.20, v0.4.21, v0.4.22, v0.4.23, v0.4.24, v0.4.25, v0.4.6, v0.4.7, v0.4.8, v0.4.9
and the py-solc looks like not maintained.
So How do I use myth with specified solidity compiler，if I use myth directly
myth a call.sol

it will use the solc in system right?
So I need to check the contract version in the first line and change my system solc everytime(and I need to install all the version), is it the rightway or is there is a better practice. is there a easy way to chang my system solc(I found a package crytic/solc-select)?
I am very confused， thanks for your help!!

Hi @MountainTrap , I didn't check solc-select, but one way would be to have the latest version of solc installed and for analysis just change the pragma by adding a ^(don't forget to revert it after the analysis is done if it wasn't intended), In nearly all cases the analysis results wouldn't change with that difference at the moment. This only works for versions >= 0.5.0 , in other cases you can just use --solc arg,
Another easier way is to try out mythx truffle plugin https://docs.mythx.io/en/latest/tools/truffle/ , it detects more vulnerabilities than mythril(it also uses mythril) and doesn't have this problem.

This has been resolved, the --solc argument will now also work with compiler versions greater than 0.5.0.


NullReferenceException when loading plugin.

[Info   :   BepInEx] Loading [Crafting with Containers 1.0.5]
[Error  : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
ABearCodes.Valheim.CraftingWithContainers.CompatibilityFixer.RemoveAllPrefixesFrom_InventoryGui_SetupRequirement (HarmonyLib.Harmony harmony) (at <005461a4e2524f92b523dfcf0cfd2b69>:0)
ABearCodes.Valheim.CraftingWithContainers.CompatibilityFixer.Apply (HarmonyLib.Harmony harmony) (at <005461a4e2524f92b523dfcf0cfd2b69>:0)
ABearCodes.Valheim.CraftingWithContainers.Plugin.Awake () (at <005461a4e2524f92b523dfcf0cfd2b69>:0)
UnityEngine.GameObject:AddComponent(Type)
BepInEx.Bootstrap.Chainloader:Start()
UnityEngine.Application:.cctor()

Mod list:
[Info   :   BepInEx] Loading [Crafting with Containers 1.0.5]
[Info   :   BepInEx] Loading [Faster Teleportation <IP_ADDRESS>]
[Info   :   BepInEx] Loading [SkToolbox <IP_ADDRESS>]
[Info   :   BepInEx] Loading [Dream's Data Rate Modifier <IP_ADDRESS>]
[Info   :   BepInEx] Loading [BetterUI 1.3.1]
[Info   :   BepInEx] Loading [FirstPerson 1.0.2]
[Info   :   BepInEx] Loading [MapSyncPlugin <IP_ADDRESS>]
[Info   :   BepInEx] Loading [FortifySkills <IP_ADDRESS>]
[Info   :   BepInEx] Loading [Better Discord Presence 1.2.1]
[Info   :   BepInEx] Loading [InteractWhileBuilding 0.0.3]
[Info   :   BepInEx] Loading [Equipment and Quick Slots 1.0.3]
[Info   :   BepInEx] Loading [AutoRepair <IP_ADDRESS>]
[Info   :   BepInEx] Loading [PreWorkout 0.2]
[Info   :   BepInEx] Loading [RememberIPDamnit 0.2]
[Info   :   BepInEx] Loading [Skillful 0.3]

I have the same issue.
I've tried disabling all mods except this one and still same issue.

Yup, my bad. I rushed the workaround for Valheim Plus and didn't cover the case for when it's not present. v1.0.6 released to Thunderstore. Please reopen if this keeps happening.


Contact column for Mac crash reports isn't visible in App Center diagnostics

Describe the solution you'd like
App Center diagnostics doesn't show the contact column for Mac crash reports. We use this column to store the user's email so we can contact them to follow up on the crash.
Describe alternatives you've considered
We can use App Center's attachments API once we migrate to App Center, but we can't see this info from existing apps using the HockeyApp framework. Until this is added we need to keep using the HockeyApp UI to view this info, which prevents us from migrating the app to App Center.
Additional context
Screenshot of what the contact info looks like in HockeyApp:

Hey @ksuther - we recently added a column to display the user ID and to indicate if a report has an attachment.

Hope that helps!

That shows the user name from HockeyApp but it doesn't show the email address. Is there a way to show both columns in the User ID so we still have the same data available?

App Center doesn't have the concept of contact and username but you can set the user ID field to whatever string you'd like including an email address: https://docs.microsoft.com/en-us/appcenter/sdk/other-apis/macos#identify-users

That helps for the future, thanks. The problem is that our existing releases using the HockeyApp SDK don't show the user's contact info. This means we're unable to contact users to provide them with additional information if they submit a crash report to us.


Remove nonstandard ISCL short id from ISC license

Request to add a new Trove classifier (or more exactly, to update an existing one).
The name of the classifier(s) you would like to add:

License :: OSI Approved :: ISC License

Why do you want to add this classifier?
The canonical short identifier for the ISC License is simply ISC; see https://spdx.org/licenses/ISC.html.
This change aligns the ISC License classifier to match similar ones such as MIT License, BSD License, etc.

I think any change to the current license classifiers is blocked on https://github.com/pypa/trove-classifiers/issues/17 (or the implementation of a SPDX license classifier field).

Thanks for the pointer — I'll keep track of that discussion.


BPF host routing bypasses DNS resolution of dockerd on Kind clusters

While debugging https://github.com/cilium/cilium/pull/23171, I've discovered that the BPF masquerade is not properly working on > 5.4 kernels when running in the ci-datapath. The main symptom was failing requests to https://one.one.one.one. A closer look revealed that the DNS resolution for external FQDN was failing.
With the help of tcpdump running on the node of the CoreDNS pods (kind-control-plane), with the iptables masquerading I got the following trace:
eth0  In  IP <IP_ADDRESS>.39869 > <IP_ADDRESS>.53: 33504+ [1au] A? googlel.com. (52)
lxc61ce9e2c0db2 Out IP <IP_ADDRESS>.39869 > <IP_ADDRESS>.53: 33504+ [1au] A? googlel.com. (52)
lxc61ce9e2c0db2 In  IP <IP_ADDRESS>.40127 > <IP_ADDRESS>.53: 57830+ [1au] A? googlel.com. (52)
eth0  Out IP <IP_ADDRESS>.40235 > <IP_ADDRESS>.53: 57830+ [1au] A? googlel.com. (52)
eth0  In  IP <IP_ADDRESS>.53 > <IP_ADDRESS>.40235: 57830 0/1/1 (122)

While with the BPF masquerading - the following:
eth0  In  IP <IP_ADDRESS>.42393 > <IP_ADDRESS>.53: 6280+ [1au] A? googlel.com. (52)
lxc61ce9e2c0db2 In  IP <IP_ADDRESS>.57566 > <IP_ADDRESS>.53: 46622+ [1au] A? googlel.com. (52)
eth0  Out IP <IP_ADDRESS>.57566 > <IP_ADDRESS>.53: 46622+ [1au] A? googlel.com. (52)

<IP_ADDRESS> - the client pod.
<IP_ADDRESS> - the CoreDNS pod (lxc61ce9e2c0db2).
<IP_ADDRESS>  - the CoreDNS node IP (eth0).
<IP_ADDRESS> - the Docker bridge IP addr which connects Kind nodes.

From the traces diff it quickly became clear that in the end that it's not the BPF masq matter, but the BPF host routing (with the iptables masquerading it's automatically disabled), and that the following Docker's DNS xlation is bypassed with the BPF host routing:
lxc61ce9e2c0db2 In  IP <IP_ADDRESS>.40127 > <IP_ADDRESS>.53: 57830+ [1au] A? googlel.com. (52)
eth0  Out IP <IP_ADDRESS>.40235 > <IP_ADDRESS>.53: 57830+ [1au] A? googlel.com. (52)

I still don't have a clue how the translation above happens.

Looking at the filtered strace of dockerd running in the host netns (:exploding_head:):
1154  setsockopt(28<UDP:[3318259]>, SOL_SOCKET, SO_BROADCAST, [1], 4 <unfinished ...>
1154  <... setsockopt resumed>)         = 0
1154  connect(28<UDP:[3318259]>, {sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr("<IP_ADDRESS>")}, 16 <unfinished .
1154  <... connect resumed>)            = 0
1154  epoll_ctl(5<anon_inode:[eventpoll]>, EPOLL_CTL_ADD, 28<UDP:[3318259]>, {events=EPOLLIN|EPOLLOUT|EPOLLRDHUP|EPOLLET, data={u32=3036353360, u64=139898711118672}} <unfinished ...>
1081  <... nanosleep resumed>NULL)      = 0
1154  <... epoll_ctl resumed>)          = 0
1106  <... epoll_pwait resumed>[{events=EPOLLOUT, data={u32=3036353360, u64=139898711118672}}], 128, 8, NULL,<PHONE_NUMBER>0353) = 1
1081  nanosleep({tv_sec=0, tv_nsec=20000},  <unfinished ...>
1154  getsockname(28<UDP:[3318259]>,  <unfinished ...>
1106  epoll_pwait(5<anon_inode:[eventpoll]>,  <unfinished ...>
1081  <... nanosleep resumed>NULL)      = 0
1106  <... epoll_pwait resumed>[], 128, 0, NULL, 0) = 0
1154  <... getsockname resumed>{sa_family=AF_INET, sin_port=htons(37754), sin_addr=inet_addr("<IP_ADDRESS>")}, [112 => 16]) = 0
1081  nanosleep({tv_sec=0, tv_nsec=20000},  <unfinished ...>
1106  epoll_pwait(5<anon_inode:[eventpoll]>,  <unfinished ...>
1154  getpeername(28<UDP:[3318259]>,  <unfinished ...>
1081  <... nanosleep resumed>NULL)      = 0
1081  nanosleep({tv_sec=0, tv_nsec=20000},  <unfinished ...>
1154  <... getpeername resumed>{sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr("<IP_ADDRESS>")}, [112 => 16]) = 0
1081  <... nanosleep resumed>NULL)      = 0
1154  setns(14<net:[4026531840]>, CLONE_NEWNET <unfinished ...>
1081  nanosleep({tv_sec=0, tv_nsec=20000},  <unfinished ...>
1154  <... setns resumed>)              = 0
1081  <... nanosleep resumed>NULL)      = 0
1154  close(26</run/docker/netns/acf7be30eece> <unfinished ...>
1081  nanosleep({tv_sec=0, tv_nsec=20000},  <unfinished ...>
1154  <... close resumed>)              = 0
1081  <... nanosleep resumed>NULL)      = 0
1154  write(28<UDP:[3318259]>, "\261\252\1\0\0\1\0\0\0\0\0\1\7googlel\3com\0\0\34\0\1\0\0)"..., 40 <unfinished ...>

Looking into the filtered strace output of one of the dockerd threads which handles requests:
1154  recvmsg(69<UDP:[691492]>,  <unfinished ...>
1154  <... recvmsg resumed>{msg_name={sa_family=AF_INET, sin_port=htons(53969), sin_addr=inet_addr("<IP_ADDRESS>")}, msg_namelen=112 => 16, msg_iov=[{iov_base="\305\377\1\0\0\1\0\0\0\0\0\1\7googlel\3com\0\0\1\0\1\0\0)"..., iov_len=512}], msg_iovlen=1, msg_control=[{cmsg_len=28, cmsg_level=SOL_IP, cmsg_type=IP_PKTINFO, cmsg_data={ipi_ifindex=9, ipi_spec_dst=inet_addr("<IP_ADDRESS>"), ipi_addr=inet_addr("<IP_ADDRESS>")}}], msg_controllen=32, msg_flags=0}, 0) = 40
1154  futex(0xc0001a8948, FUTEX_WAKE_PRIVATE, 1) = 1
1154  recvmsg(69<UDP:[691492]>,  <unfinished ...>
1154  <... recvmsg resumed>{msg_namelen=112}, 0) = -1 EAGAIN (Resource temporarily unavailable)
1154  setns(14<net:[4026531840]>, CLONE_NEWNET <unfinished ...>
1154  <... setns resumed>)              = 0
1154  openat(AT_FDCWD</>, "/var/run/docker/netns/acf7be30eece", O_RDONLY|O_CLOEXEC <unfinished ...>
1154  <... openat resumed>)             = 26</run/docker/netns/acf7be30eece>
1154  setns(26</run/docker/netns/acf7be30eece>, CLONE_NEWNET) = 0
1154  socket(AF_INET, SOCK_DGRAM|SOCK_CLOEXEC|SOCK_NONBLOCK, IPPROTO_IP) = 28<UDP:[3313658]>
1154  setsockopt(28<UDP:[3313658]>, SOL_SOCKET, SO_BROADCAST, [1], 4 <unfinished ...>
1154  <... setsockopt resumed>)         = 0
1154  connect(28<UDP:[3313658]>, {sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr("<IP_ADDRESS>")}, 16 <unfinished ...>
1154  <... connect resumed>)            = 0
1154  epoll_ctl(5<anon_inode:[eventpoll]>, EPOLL_CTL_ADD, 28<UDP:[3313658]>, {events=EPOLLIN|EPOLLOUT|EPOLLRDHUP|EPOLLET, data={u32=3036353360, u64=139898711118672}} <unfinished ...>
1154  <... epoll_ctl resumed>)          = 0
1154  getsockname(28<UDP:[3313658]>,  <unfinished ...>
1154  <... getsockname resumed>{sa_family=AF_INET, sin_port=htons(39684), sin_addr=inet_addr("<IP_ADDRESS>")}, [112 => 16]) = 0
1154  getpeername(28<UDP:[3313658]>,  <unfinished ...>
1154  <... getpeername resumed>{sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr("<IP_ADDRESS>")}, [112 => 16]) = 0
1154  setns(14<net:[4026531840]>, CLONE_NEWNET) = 0
1154  close(26</run/docker/netns/acf7be30eece> <unfinished ...>
1154  <... close resumed>)              = 0
1154  write(28<UDP:[3313658]>, "\305\377\1\0\0\1\0\0\0\0\0\1\7googlel\3com\0\0\1\0\1\0\0)"..., 40 <unfinished ...>
1154  <... write resumed>)

It looks that the thread have entered the netns of the kind-control-plane, and then did the DNS resolution.
The missing bit in the puzzle is how the following got redirected to the dockerd socket w/o leaving the netns (dockerd runs in the host netns, while kind-control-plane in its own):
lxc61ce9e2c0db2 In  IP <IP_ADDRESS>.40127 > <IP_ADDRESS>.53: 57830+ [1au] A? googlel.com. (52)

There we go, the last missing puzzle with the help of pwru:
0xffff92c424982a00      2        [coredns]  nf_csum_update	[nf_nat] sec-arg=0 netns=4026533199 mark=0x10970f00 ifindex=7 proto=8 mtu=1500 len=68 <IP_ADDRESS>:60074-><IP_ADDRESS>:53(udp)
0xffff92c424982a00      2        [coredns] inet_proto_csum_replace4 sec-arg=18446623969858038272 netns=4026533199 mark=0x10970f00 ifindex=7 proto=8 mtu=1500 len=68 <IP_ADDRESS>:60074-><IP_ADDRESS>:53(udp)
0xffff92c424982a00      2        [coredns] inet_proto_csum_replace4 sec-arg=18446623969858038272 netns=4026533199 mark=0x10970f00 ifindex=7 proto=8 mtu=1500 len=68 <IP_ADDRESS>:60074-><IP_ADDRESS>:53(udp)
0xffff92c424982a00      2        [coredns]       udp_v4_early_demux sec-arg=18446623969858038272 netns=4026533199 mark=0x10970f00 ifindex=7 proto=8 mtu=1500 len=68 <IP_ADDRESS>:60074-><IP_ADDRESS>:38359(udp)

Which happens because of the following rule:
[222:12858] -A DOCKER_OUTPUT -d <IP_ADDRESS>/32 -p udp -j DNAT --to-destination <IP_ADDRESS>:38359

TL;DR because the BPF host makes the packet to bypass that iptables rule, the packet is actually sent to the host netns. As there is no UDP socket listening on :53, the packet gets dropped.

A note for people stumbling upon this issue like I have:
This has only been "fixed" when using our kind.sh script. If one uses plain kind or the helm/kind-action GitHub action (such as we do in some, but not all, GitHub workflows), then one still has to disable BPF host routing for the connectivity test to pass.


Add typing files

So I'm switching over to pylance in a project I'm working on that uses periphery and I've made a pyi file for the gpio file. I figured I'd share it here for anyone interested in making them for the rest of this library. If I have time I may come back around and do them, but I'm not sure when that would be.
I had to change the file extension in order to upload it: gpio.txt
12/12/2020 updated EdgeEvent properties

This would be nice to have. It should probably follow https://mypy.readthedocs.io/en/stable/installed_packages.html#making-pep-561-compatible-packages

This would be nice to have. It should probably follow https://mypy.readthedocs.io/en/stable/installed_packages.html#making-pep-561-compatible-packages

Which option do you prefer:

inline typing (can be done in a version agnostic way)
stubs (like in my original post)

distributed with periphery
added to the typeshed

I don't currently have time to go through the whole library and type it, but I can submit a PR with the GPIO file done in the format you want as a starting point.

Which option do you prefer:

inline typing (can be done in a version agnostic way)
stubs (like in my original post)

distributed with periphery
added to the typeshed

I don't currently have time to go through the whole library and type it, but I can submit a PR with the GPIO file done in the format you want as a starting point.

I'm a little suspicious of inline typing given the Python 2 support. There are a few union types throughout the library that would probably requiring the typing module. So I think stubs distributed with periphery would probably be a good starting point.
No worries about not doing the whole library. I can add to it over time.

I'm a little suspicious of inline typing given the Python 2 support. There are a few union types throughout the library that would probably requiring the typing module. So I think stubs distributed with periphery would probably be a good starting point.
No worries about not doing the whole library. I can add to it over time.

I'm using it without issue in Jython 2.7.2 like this:
try:
    import typing as t
except:
    pass

my_var = None  # type: t.Union[str, None]

The import gets skipped over if it's missing and to a language unaware of type hints the comments are just comments.

I'm using it without issue in Jython 2.7.2 like this:
try:
    import typing as t
except:
    pass

my_var = None  # type: t.Union[str, None]

The import gets skipped over if it's missing and to a language unaware of type hints the comments are just comments.

I'm using it without issue in Jython 2.7.2 like this:
try:
    import typing as t
except:
    pass

my_var = None  # type: t.Union[str, None]

The import gets skipped over if it's missing and to a language unaware of type hints the comments are just comments.

Does that work with arguments in methods though? e.g. def poll(self, timeout: Union[int, float, None] = ...) -> bool: in your stub file.

I'm using it without issue in Jython 2.7.2 like this:
try:
    import typing as t
except:
    pass

my_var = None  # type: t.Union[str, None]

The import gets skipped over if it's missing and to a language unaware of type hints the comments are just comments.

Does that work with arguments in methods though? e.g. def poll(self, timeout: Union[int, float, None] = ...) -> bool: in your stub file.

Methods you have 2 options
For shorter methods:
def poll(self, timeout):
    # type: (t.Optional[int, float] = ...) -> bool

For methods with more arguments or complex typings:
def poll(
    self,
    timeout,  # type: t.Optional[int, float]
):
    # type: (...) -> bool

I'll get a PR done this morning for GPIO so you can see and I'll look up the documents I learned all this from and get you links

Methods you have 2 options
For shorter methods:
def poll(self, timeout):
    # type: (t.Optional[int, float] = ...) -> bool

For methods with more arguments or complex typings:
def poll(
    self,
    timeout,  # type: t.Optional[int, float]
):
    # type: (...) -> bool

I'll get a PR done this morning for GPIO so you can see and I'll look up the documents I learned all this from and get you links

mypy Python 2 Reference a 'cheatsheet' like summary of the important parts of the below links.
PEP 484 type hints are introduced
PEP 484 Runtime or Type Checking trick to import only when type checking

Use to not import large packages not needed at runtime
Use to avoid circular imports at runtime

PEP 484 Type Comments
PEP 484 Suggested syntax for Python 2.7

mypy Python 2 Reference a 'cheatsheet' like summary of the important parts of the below links.
PEP 484 type hints are introduced
PEP 484 Runtime or Type Checking trick to import only when type checking

Use to not import large packages not needed at runtime
Use to avoid circular imports at runtime

PEP 484 Type Comments
PEP 484 Suggested syntax for Python 2.7

In the event that there are things that could only be done in a stub file, would you rather have everything in the stub or only what has to be and the rest inlined?
So far I think that just EdgeEvent and this method need to go in the stub in order to do this:
class GPIO(object):
    @t.overload
    def __new__(cls, line: int, direction: str) -> 'SysfsGPIO': ...
    @t.overload
    def __new__(
        path: str,
        line: t.Union[int, str],
        direction: str,
        edge: str = ...,
        bias: str = ...,
        drive: str = ...,
        inverted: bool = ...,
        label: t.Optional[str]
    ) -> CdevGPIO: ...

Because the best we can do inline is this and it is woefully ambiguous...
class GPIO(object):
    def __new__(cls, *args, **kwargs):
        # type: (...) -> t.Union[SysfsGPIO, CdevGPIO]

In the event that there are things that could only be done in a stub file, would you rather have everything in the stub or only what has to be and the rest inlined?
So far I think that just EdgeEvent and this method need to go in the stub in order to do this:
class GPIO(object):
    @t.overload
    def __new__(cls, line: int, direction: str) -> 'SysfsGPIO': ...
    @t.overload
    def __new__(
        path: str,
        line: t.Union[int, str],
        direction: str,
        edge: str = ...,
        bias: str = ...,
        drive: str = ...,
        inverted: bool = ...,
        label: t.Optional[str]
    ) -> CdevGPIO: ...

Because the best we can do inline is this and it is woefully ambiguous...
class GPIO(object):
    def __new__(cls, *args, **kwargs):
        # type: (...) -> t.Union[SysfsGPIO, CdevGPIO]

Well it's a bit of a moot point (my above example on the __new__ method) because Pylance doesn't see the specified return types and just says you get an instance of GPIO back when calling GPIO(...)

Well it's a bit of a moot point (my above example on the __new__ method) because Pylance doesn't see the specified return types and just says you get an instance of GPIO back when calling GPIO(...)


Valhalla tutorials need a brush-up

Referring to https://github.com/valhalla/valhalla/issues/2630.
@dimnioras in case you're getting somewhere on the host-native installation, feel free to PR an update:)

done over the holidays

done over the holidays


Active state doesn't work (inputs)

When the input is active, the border should be blue
Now it looks like

and should show:

@urbanphes this is working for me :(


Typo "XAML Island"→"XAML Islands"

https://docs.microsoft.com/en-us/windows/apps/desktop/modernize/desktop-to-uwp-extend

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks for your contribution to the docs. Please note that "XAML Islands" is both a general technology term but also a plural noun. In this case, the current text ("...by using a XAML Island") is grammatically accurate to specify the singular form of a XAML Island. Changing this text to "...by using a XAML Islands" would be grammatically incorrect. Therefore, I am closing this pull request.


Allow upgrading keptn to a newer version using the CLI

Similar to keptn install, introduce a new command (e.g. keptn upgrade) in the CLI, which allows upgrading the keptn version. By providing this command, we have a uniform experience (also regarding the prerequisites) how keptn can be installed or upgraded.

Currently, we solve this using k8s jobs, which is also reasonable.


Monkey cannot be nested in an array

When monkey is defined in an object's property, it works fine, but when defining monkey in an element of an array, then the monkey's value will not be evaluated.
Here is the Fiddle code to demonstrate this issue.
Is this a defect?

Hello @wBingwei. This is, for the time being, an expected behavior (an undocumented one though, my bad). I don't allow monkeys beneath array because it might get very heavy and trigger some nasty performance drops. But I am not opposed to implement it in a further minor version.
Can you elaborate on your use case so we can discuss this please?

Thanks for your explanation, I also think it might get heavy for our tree. And I don't think our case is a good one, we have done it without monkey.
Thank you again.


Add option to use bf16 in PT sdp (#5)

The new option --sdp_on_bf16 allows pyTorch to use reduced precision in sdp in the math backend.
The change affects the following examples:

contrastive-image-text/run_bridgetower.py
question-answering/run_qa.py
speech-recognition/run_speech_recognition_ctc.py
stable-diffusion//text_to_image_generation.py
text-classification/run_glue.py

@astachowiczhabana  which model and configuration are you running with this flag enabled? We'd like to do the same for the OH CI/PYTEST.

@astachowiczhabana  dont we need to update README for all the models with this option ?

@jiminha
Inference - 1 card:

question-answering/run_qa.py bert-large-uncased-whole-word-masking bs 8
text-classification/run_glue.py bert-large-uncased-whole-word-masking bs 8
stable-diffusion/text_to_image_generation.py stabilityai/stable-diffusion-2-base bs 4
speech-recognition/run_speech_recognition_ctc.pywav2vec2-librispeech-clean-100h-demo-dist bs 128
contrastive-image-text/run_bridgetower.py BridgeTower/bridgetower-large-itm-mlm-itc bs 16

Training - 8 cards:

audio-classification/run_audio_classification.py facebook/wav2vec2-base bs 16
image-classification/run_image_classification.py google/vit-base-patch16-224-in21k bs 64

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


oxygen binding has parent drug binding

can this inference be removed?
Thanks
Val

We've come up with a plan, so we should be fixing this soon now.

This was fixed in this ticket:
cessation of reasoning over ChEBI roles, i.e. stop inferring relationships like "ATP binding" is_a "drug binding" #19479


CLI: wrap URL in double quotes

CLI doesn't like URLs with &. Wrapping with double quotes solved the issue. Maybe it's just Windows. Thought this may help.

That has nothing to do with Pageres. You always have to quote CLI arguments if they contain shell special characters.


Deleted Collections Remain Visible

Description
Two collections I authored and later deleted are still visible, but lead to dead pages . 'Todo Medium' and 'Todo Hard' returning 'https://www.codewars.com/collections/todo-medium' and 'https://www.codewars.com/collections/todo-hard-2'. They can be seen in my authored collection list, when searching public collections via the kata tab (at least from my accounts POV) and also from any problems which used to be a member of either collection, for example:

Clicking remove greys out the buttons and requires the page to be refreshed to access the collections adding again:

Currently no collections can be deleted, and they behave as described above after attempting to delete.
To Reproduce
I cannot test easily on my end, but I believe the problem was triggered by my navagating to the collection page as it was in the process of being deleted.
Expected Behavior
Collections should disappear entirely when deleted and connected kata should be untied.
Contexts
Codewars Username: EmmanuelIsaac
OS: Windows 10 Pro (64-bit)
Browser: Google Chrome
Browser Version: 80.0.3987.132 (Official Build) (64-bit)

I think they will disappear over time and it's just some caching/stale read issue.

I think they will disappear over time

The collections are fundamentally broken, so that's highly unlikely.
I have a collection (https://www.codewars.com/collections/later-34) which I created 2 years ago and could not delete because it was throwing errors. If you follow the link above, you'll see that another user is it's author now - I think the deletion process partially(?) failed then, somebody created a collection with the same name, and the id of my collection got assigned to his one.
You never know what and how is going to break when using them...

To add, my own observation, deletion of collection which has more than 1 element works partially (for an empty or with 1 element works properly, same as reducing collection to this state by deleting each entry separately), meaning the visuals show that it disappears from users' collections tab, however after refreshing it's still there but the link gives 404 (I presume this is the cause of #2185). Moreover, it would be better if changes to order of elements were to be submitted manually (or maybe after some short time after last modification) rather than after every single one, also extending to the collections the whole private/public feature from kumites. Completely different approach could be removing collections altogether and moving things over to bookmarks (right now the former seems to be used in such manner most of the time) also with the option of publishing (it would be nice for groups or maybe it could be connected to clans?).

I think they will disappear over time and it's just some caching/stale read issue.

I've a collection (https://www.codewars.com/collections/compilers-and-interpreters-1) which I tried deleting 6 months ago, but I still can see it on my profile.

or with 1 element works properly

Doesn't seems to be the case, I've a collection with just one element : https://www.codewars.com/collections/will-approve, I tried deleting it couple of months ago and yesterday but it is still there.
However, another thing is I see from collections section on my profile page (https://www.codewars.com/users/XRFXLP/authored_collections) there are four collections, however in the contributions section, it is showing collections : 1

Let me know if this is still happening.


Cannot Connect TK200 with Traccar

Hi Sir,
I have sent command to point with my traccar server on ubuntu 16.04 port 8082
Command : adminip123456 myip 5006
and it replied "admin ok";
I think it successfully connected to that server.
But I cannot see the position update in my server tracer.
What was I wrong ?
Thank you !!! :)

Please follow this guide:
https://www.traccar.org/troubleshooting/

I have checked log already.
the device never connected to traccar server.
I think I may wrong some configuration such port ,
I have pointed to port 5002 and then tried with 5006 but still not work.
That is correct ?
thank you :) 👍

The full IMEI is<PHONE_NUMBER>69789 and I have adjusted it to<PHONE_NUMBER>89
depend on this instruction : https://www.traccar.org/ports-for-tk-gt-and-other-gps-devices

Where are the logs?


Jenkins 73817 Add a Configuration Parameter to Control Log Output Format (Text vs. HTML)

Currently, our logging system does not provide a direct way to switch between pure text and HTML-formatted log outputs. This limitation can be restrictive in scenarios where logs need to be rendered directly in web interfaces or where specific formatting requirements (e.g., for highlighting, linking, or styling) are desired.
To enhance the flexibility and usability of our logging capabilities, I propose the addition of a new configuration parameter that would allow users to specify the desired output format for logs. This parameter could be easily integrated into our existing logging framework, allowing for seamless transitions between text and HTML modes as needed.
Example:
http://{ip_host}/job/{optionalFolderPath}/job/{job_name}/{build_number}/execution/node/{nodeId}/wfapi/log?text=true

The HTTP endpoints in the REST plugin in this repo are intended solely for use by the stage view GUI, so unless there is some fix visible in the GUI that this allows, it should not be done.

You’re absolutely right, but this REST plugin has already become a standard part of Jenkins. In many integration scenarios, the use case is not based on a web GUI. Considering the above scenarios, that's why I modified these endpoints, so I hope you can take similar scenarios into account.

this REST plugin has already become a standard part of Jenkins

It is not standard and is not supported. If you have some other application for which you need a REST API rendering stage/step metadata, logs, etc., you will need to write your own REST API plugin.

this REST plugin has already become a standard part of Jenkins

It is not standard and is not supported. If you have some other application for which you need a REST API rendering stage/step metadata, logs, etc., you will need to write your own REST API plugin.

But I don't think that's reasonable. I integrated Jenkins and used the officially recommended java-rest library. This library uses this and the plugin API. Of course, BlueOcean also supports plain text log operations. But the whole integration process was frustrating, and not only did I need to install an extra plugin, but I also had to write and operate the Blue Ocean API myself.

The REST APIs from blueocean-plugin were designed for that visualization and also not supported for any other purpose.

jenkins-rest
The methods runHistory, workflow, pipelineNode, and pipelineNodeLog all utilize the APIs from the pipeline-stage-view-plugin. Therefore, I would like to write a method that is compatible with them. Currently, there is no relevant compatibility method available, but it's fine; I will improve and complete the content I need later. Thank you for your reply.


[hotfix][docs] Updated description of HOP and CUMULATE parameters

What is the purpose of the change

Description and markup update

Brief change log

Description and markup update

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@Airblader,  @tisonkun, @wuchong, @leonardBang - Can you please review this documentation PR and let me know your feedback ? Thanks

@flinkbot run azure

I'm guessing the PR needs to be rebased so that CI can pass.

@Airblader @leonardBang - Thanks for your review.   Please let me know if there is anything required from my side.   Thanks

@Airblader @leonardBang @wuchong @tisonkun - Please let me know if you have any recommendations on this PR.  Thanks.

@mans2singh The CI test is failed so we can not merge this one as the community discussed in mail list [DISCUSS] Do not merge PRs with "unrelated" test failures., I suggest you to re-trigger the CI test (command: @flinkbot run azure) or rebase your code to latest master which also can trigger the CI.

@leonardBang I've rebased the branch against master.  Please let me know if you have any additional recommendations.  Thanks again.

Thanks @mans2singh The build has passed, I‘ll find committer to help merge soon


Open app in separate window

Is there a way to open app in independent window? Currently it is opening new app as a nested part of old app. Also, if the app is opened in background, it should resume it in foreground.
One more thing, does this plugin allow to check if external app is installed or not?

Hi!

Is there a way to open app in independent window? Currently it is opening new app as a nested part of old app. Also, if the app is opened in background, it should resume it in foreground.

Hmm, i honestly do not know.

One more thing, does this plugin allow to check if external app is installed or not?

For check app is installed use this code:
var sApp = startApp.set({ /* params */
	"action":"ACTION_MAIN",
	"category":"CATEGORY_DEFAULT",
	"type":"text/css",
	"package":"com.lampa.startapp",
	"uri":"file://data/index.html",
	"flags":["FLAG_ACTIVITY_CLEAR_TOP","FLAG_ACTIVITY_CLEAR_TASK"],
	"component": ["com.app.name","com.app.name.Activity"],
	"intentstart":"startActivity",
}, { /* extras */
	"EXTRA_STREAM":"extraValue1",
	"extraKey2":"extraValue2"
});

sApp.check(function(values) { /* success */
	console.log(values);
}, function(error) { /* fail */
	alert(error);
});

Ok. Thanks for the info.

external

So now is still impossible to open a son application in a new window rather than covering the old one?


Remove the parent cache busting hash

This PR replaces #331 and adds related tests.
Please let me know what you think.
P.S. It should also fix https://github.com/symfony/assetic-bundle/issues/269

Desperately waiting for approval.. :)


Make SubprocessError as an error instance

How about make the SubprocessError as an error instance instead of a type?
Currently it's a bit anonying when writing the error handling code in TypeScript:
try {
	await spawn(/* ... */);
} catch (error} {
	if (error instanceof Error && (error as SubprocessError).signalName === "SIGKILL") {
		// ...
	}
}

The code can be cleaner if we make the SubprocessError as an error instnace:
try {
	await spawn(/* ... */);
} catch (error} {
	if (error instanceof SubprocessError && error.signalName === "SIGKILL") {
		// ...
	}
}

Please correct me if there is a better way to write the code.

Hi @LitoMore,
Thanks for the suggestion.
It makes sense. :+1:

Released with 0.2.0.


Set font-family: "Monospace" renders as serif

Challenge: http://www.freecodecamp.com/challenges/waypoint-set-the-font-family-of-an-element
Just for reference, I am using Firefox 38 and Windows 8.1, without additional fonts or MS Office installed. As such, the font Monospace does not render in the exercise. Instead, it produces Serif. Interestingly enough, the dev tools show the correct font family. (See attached screenshot)
In my Firefox settings, I have the default monospace font as "Lucida Console", so I am not sure why that font is not displaying, in place of "Monospace"

Which version of Firefox are you running? Have you tried just refreshing the page? I've seen a lot of issues caused by the browser that got "blamed" on FCC itself.

@onebree That's likely because you have the font-family surrounded in quotes.  Monospace isn't an actual font-family, it's a keyword that represents the OS's default monospaced font (in your case, Lucida Console, as you point out).
When you surround the font-family value in quotes, the browser is attempting to load a font actually called "Monospace" and failing since that doesn't exist on your system.
Try the following code and see if it's fixed:
font-family: monospace;

@vishalarora The instructions are as follows:

Make all of your p elements use the "Monospace" font.
You can set an element's font by using the "font-family" attribute.
For example, if you wanted to set your h2 element's font to "Sans-serif", you would use the following CSS: h2 { font-family: 'Sans-serif'; }

Maybe, the lesson should be changed to ask for the family monospace? Beause I see family as a type (monospace, sans-serif, etc), or a group of fonts ("Sans-Serif, Arial, Helvetica")

UPDATE - I am noticing that when you begin a new exercise, the code changes slightly to show best practices and ideal answer.  This is what FCC considered to be correct:
<style>
  p {
    font-size: 16px;
    font-family: Monospace;
  }
</style>

Notice the capitalized "Monospace", without quotes. In my opinion, when FCC refers to a phrase to enter, it should wrap it in a code tag, as I assumed the quotation marks to be included.

The issue seems to be that I originally put the example in quotes. I'm going to fix that. Thanks for catching this, @onebree.

Thank you for such a quick response!


Tests: add test for the -i flag of into subcommand

We don't have anything for such CLI tests currently.

We added a test for that


Proposal Monitoring by boost_dmg01

Proposal Monitoring by boost_dmg01

$PAC is using Gitian to make official releases, which ensures consistent builds and avoids problems as incompatibility with dependencies. No using it, could trigger possible compatibility problems for Mac and Linux  (including more than 5000 masternodes) users, so we have to be very careful when we push a new release.
The code on this pull requests works well when you create "dirty builds", but unfortunately is not compiling when using Gitian.
The Gitian  descriptors can be found here: https://github.com/PACCommunity/PAC/tree/master/contrib/gitian-descriptors
and I'm attaching the logs, so hopefully you can have a better idea of what could be causing the errors.
Gitian logs.zip


fix / feat: handle building gpkg crosswalk from flowpath-attributes

Newer HF versions now use:
flowlines instead of flowpaths
flowpath-attributes instead of flowpath_attributes
model-attributes instead of model_attributes
This just adds support for that.
Additions

Add support for hydrofabrics that use flowlines and flowpath-attributes

Which version uses which convention?

2.1.1 - https://www.lynker-spatial.com/data?path=hydrofabric%2Fv2.1.1%2Fnextgen%2F

Re-running jobs on master b.c. I don't think they are failing from what i've added here.

Opened #139 to track the test failures. Confirmed the additions made here.

Having chatted with @mikejohnson51 (correct me where i'm wrong), all HF releases >2.1 flowpaths -> flowlines and flowpath_attributes -> flowpath-attributes. Can you confirm that @mikejohnson51?

@robertbartel, just addressed your comment. Should be good to go now. Thanks!