[QUESTION] How to pass terraformModuleFolder to Terratest function without hardcoding in the code

Thanks for such a great test framework 👍🏼
I have a question for executing multiple examples by passing the terraformModuleFolder to Terratest function. Would it be possible to pass the terraformModuleFolder variable value to the Terratest main function without hardcoding the path in Terratest code?
My Github Workflow step as follows
      - name: Run E2E test
        working-directory: test
        run: go test -v -timeout 60m -run TestEksE2E

I have multiple examples which i would like to test by passing the terraformModuleFolder  from Github workflow as inline parameter to the Terratest instead of hardcoding the path in Terratest code. I know the main test function doesn't allow to pass additional parameter. Is there any other way i can achieve this?
Terraform folder structure for my examples as follows
examples
|-- eks-example-abc
|-- eks-example-xyz
|-- eks-example-123

Terratest function as follows. I would like to pass this exampleFolderPath as inline parameter so that i can use Github matrix workflow to run multiple examples at the same time
func TestEksE2E(t *testing.T) {
	t.Parallel()

	//rootFolder             = "../../"
	//exampleFolderPath      = "examples/eks-example-123".

	/*This allows running multiple tests in parallel against the same terraform module*/
	tempExampleFolder := test_structure.CopyTerraformFolderToTemp(t, rootFolder, exampleFolderPath)

	defer test_structure.RunTestStage(t, "destroy", func() {
		terraformOptions := test_structure.LoadTerraformOptions(t, tempExampleFolder)
		terraform.Destroy(t, terraformOptions)
	})
	test_structure.RunTestStage(t, "apply", func() {
          ...
         }
...
}

Thanks in advance

Hi,
I was thinking about a setup like:
	testCases := []struct {
		name   string
		values map[string]string
	}{
		{
			"eks-example-123",
			map[string]string{"rootFolder": "../..", "exampleFolderPath": "examples/eks-example-123"},
		},
		{
			"eks-example-666",
			map[string]string{"rootFolder": "../..", "exampleFolderPath": "examples/eks-example-666"},
		},
	}

	for _, testCase := range testCases {
		testCase := testCase
		t.Run(testCase.name, func(subT *testing.T) {
			subT.Parallel()

                        tempExampleFolder := test_structure.CopyTerraformFolderToTemp(t, testCase.values["rootFolder"], testCase.values["exampleFolderPath"])
                        defer test_structure.RunTestStage(t, "destroy", func() {...})
                        test_structure.RunTestStage(t, "apply", func() {...})

		})
	}

Thanks @denis256 ! I will give it a go.


Question: can I use this with other bootstrap package ?

I would like to use this nice package in my project, but I don't want to include twbs:bootstrap because I am already using nemo64:bootstrap less. What would be the best way to accomplish this?

I just pushed a version (0.6.6) that only uses weak dependencies, so you can choose which bootstrap package you'd like to use. Let me know if this works for you.

Yes, it works.
Thanks!!!


remove env variable allowing warnings

This variable can cause increased time in CI builds since a separate build step with not have this variable and the tests will rebuild from scratch. Also a user may not want to allow warnings at all.

That's a good point. Merged. Thanks

Do you plan to publish a new version to crates.io with this fix or should I just start pointing at git?

Sincerest apologies for the delay. @dgriffen, it's published now as cargo-junit 0.8.0


Ability to connect to another device

List of STUN and TURN servers taken from here. From this list removed servers that failed to ping.

This is a huge change. It's unlikely that a review will be adequate to ensure the quality for this PR. This really needs unit tests imo.


fix: fix connector start in risedev

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Documentation

[x] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

Hi, have you tested your modification? Because we don't have ci for risedev, modification should be careful.

Hi, have you tested your modification? Because we don't have ci for risedev, modification should be careful.

Yes & the change is trivial (changed to the same as playground) & I think breaking risedev isn't too serious 🤡

duplicate with #8590

may duplicate with #8590

Not duplicate, but orthogonal. It's still not good to sh a #!/bin/bash script..

may duplicate with #8590

Not duplicate, but orthogonal. It's still not good to sh a #!/bin/bash script..

The reason why I use sh is that I encountered an issue in the docker environment which seems it would not work if we simply run it by ./start-service.sh. But I forget the specific scenario, so maybe we should preserve the sh way.


Extend support for Postman random functions/dynamic variables

Currently the package supports 3 random Postman functions.
  /* Version 4 GUID */
  guid() {
    return guid();
  },

  /* Random integer [0,1000] */
  randomInt() {
    return Math.floor(Math.random() * 1001);
  },

  /* Current time as Unix timestamp */
  timestamp() {
    return Date.now();
  }

This PR is is to extend the support for all current Postman dynamic variables
https://learning.postman.com/docs/writing-scripts/script-references/variables-list/
https://github.com/k6io/postman-to-k6/issues/91

@simskij Can you guide me how to include/import/require the dynamicVariables.js file?
I struggle to find out how to get past this?

ERRO[0004] GoError: The moduleSpecifier "./libs/shim/dynamic-variables.js" couldn't be found on local disk. Make sure that you've specified the right path to the file.

hi @simskij
I think I solved it BUT I needed to manually add a "faker.js" file in the shim folder based on "https://raw.githubusercontent.com/Marak/faker.js/9c65e5dd4902dbdf12088c36c098a9d7958afe09/dist/faker.min.js" since I couldn't get it to work using the bundle.js script option and throught packages.json.
I reference the dynamic functions through an import in the "core.js" file, which might not be the desired convention.
Looking for forward to receive remarks or improvements or even rejection if you don't think the PR is suitable.
The goal of this PR was to provide support for all Postman dynamic variables.

@simskij did you had some time to review to PR? Don't be overwhelmed by the amount code this is mostly because the 2 files that were added:

faker.js
port of the Dynamic variable functions directly from Postman

@thim81 some update about this PR?

@dbacelar4i No news on the PR, still hoping from some feedback from the expert @simskij.
I have been using the PR branch beginning of May 2021 and it works BUT I'm not sure if it is implemented in the correct way.
What I'll do, is I'll prepare a 1.6.0 branch will combine this PR, together with the other open PR's and share it here, so that you can try it also yourself.

@dbacelar4i
I have bundled all the open functional PR in a branch.
You should be able to pull it in your packages.json and use the latest code in your node project.
Example:

PR is also linked to #90

@simskij with the acquisition by Grafana, what will happen with the postman-to-k6 package? And is there something we can help with?

Support for the usage of the replaceIn method was added, thanks to the contribution of @gfeun.

Thanks Thim !
I'll be watching this space in case changes are needed after review.

For those missing this functionality, I have provided a forked NPM package version that contains the Postman dynamic variables functionality:
Replace in your packages.json:
"dependencies": {
    "postman-to-k6": "^1.5.0"
  }

to
"dependencies": {
    "@apideck/postman-to-k6": "^1.7.0"
  }

This is a forked NPM package, to facilitate other users. The current maintainers are quite overloaded by the acquisition of K6 by Grafana. By forking the repo & package, users can keep using new PR's & (security) fixes. At a later stage the changes can potentially be merged back in the original postman-to-k6 repo.
The changelog contains the differences between the original package & the forked version.


Daily update

Automated changes by create-pull-request GitHub action

Build failed because of:
No cached entry, and QuantUniversity has issues with logo: quantuniversity.svg, SVG file embeds a png. Please use a pure svg file
No cached entry, and VES LLC has issues with logo: ves_llc.svg, SVG file embeds a png. Please use a pure svg file
No cached entry, and Sollers College has issues with twitter: https://twitter.com/SollersEdu, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
Empty twitter for Nanjing University: https://twitter.com/njuniversity
Empty twitter for CSIRO/DATA 61: https://twitter.com/CSIROnews
Empty twitter for TYNYBAY Inc: https://twitter.com/tynybayinc
Empty twitter for Blockchain Education Network: https://twitter.com/BEN_CRUTECH
Empty twitter for Truepic, Inc.: https://twitter.com/truepicinc
Empty twitter for Tectonic Labs Ltd.: https://twitter.com/cloud_ridge
Empty twitter for SVA System Vertrieb Alexander GmbH: https://twitter.com/SvaGmbh
Empty twitter for Surge: https://twitter.com/surgetech
Empty twitter for Rancher Federal: https://twitter.com/RancherFederal
No cached entry, and JVC KENWOOD Corporation has issues with twitter: https://twitter.com/JVCKENWOOD_SR, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Mellanox Technologies, Ltd has issues with twitter: https://twitter.com/mellanoxtech, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
Empty twitter for eBaoTech International Pte Ltd: https://twitter.com/Ebaotech
Empty twitter for China Telecommunications Corporation: https://twitter.com/chinatelecom1
Item VES LLC has no image_data
Item QuantUniversity has no image_data


Docs: Configure Google Search

Add documentation for configuring google search in this file. Refer to the old documentation and update it in new one.

Can you explain more about it? I have written some documentation with .md as given below:
Google API Key Configuration

Note: A Google API key is required to use the Web Research Retriever.

Follow these steps to obtain your Google API key:

Locate the .env-template file in the root directory of the repository. Rename this file to .env.

Visit the Google Cloud Console and create a new project.

If you do not have an account, you will be prompted to create one and sign in.
To create a new project, click on the Select a Project dropdown at the top of the page and select New Project.
Assign a name to your project and click Create.

Set up a custom search API.

Navigate to the API and Services page.
Click on Enable APIs and Services.
Search for Custom Search API, click on it, and then click Enable.
Click on Create Credentials and select API Key.
In the .env file, assign this key to GOOGLE_API_KEY.

Set up a custom search engine and add it to your .env file.

Visit the Custom Search Engine page.
Click on Add. Follow the provided instructions to set up the search engine. You can configure it to search the entire web or only specific sites, depending on your needs.
After creating the search engine, click on Control Panel and then Basics. Copy the Search engine ID and assign it to GOOGLE_CSE_ID in the .env file.

Warning: Do not commit your .env file to the repository, as it contains sensitive information.

You need to add as .mdx file

You need to add as .mdx file This feature is mainly use ful when using with the web retriever in order to fetch the latest data. I'm working on adding a full browser support allowing the LLM to search on internet whenever required

That's cool. By the way, do check out the PR for review.

Merged


[Question] boot2docker-experimental.iso creation? (v1.12.x)

https://github.com/boot2docker/boot2docker/releases/download/v1.12.1-rc1/boot2docker-experimental.iso seems actually containing the latest dockerd
However, Dockerfile.experimental does not seem to update dockerd:
https://github.com/boot2docker/boot2docker/blob/v1.12.1-rc1/Dockerfile.experimental#L6-L8
How do you build boot2docker-experimental.iso?

I checked the build server and it was using a custom Dockerfile similar to my new PR #1193.

Even more specifically, it's building via https://github.com/tianon/jenkins-groovy/blob/8f9a123a20e19367a1dcff9d9d7b491548b47454/dsl/tianon/boot2docker.groovy#L53-L79 currently (which after #1193 will be updated to use Dockerfile.experimental as-is instead of building it custom at build time).

ok, thank you


Rebrand to EF Core v1

For more context on the rename, see http://www.hanselman.com/blog/ASPNET5IsDeadIntroducingASPNETCore10AndNETCore10.aspx.
There are several folks working on the various parts of this. This is just a high level item to track everything that needs to happen in the EF repos.
Rename/reversion packages
Packages will move to v1.0.0, this (in addition to wanting a clear distinction between EF6.x and EF Core packages) means we will rename the packages too.
We are moving to a naming strategy that aligns with other packages from Microsoft (ASP.NET and .NET Framework). Our core package will be Microsoft.EntityFrameworkCore. Our providers will be Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.SQLite, and Microsoft.EntityFrameworkCore.InMemory.
Suggested naming of third party providers
Our initial suggestion to third party provider writer would be to use the following naming for packages - which is consistent with the names we are adopting. Totally open to feedback/discussion on this one though (cc @ErikEJ @roji).
<Optional project/company name>.EntityFrameworkCore.<Database engine name>

For example:

Npgsql.EntityFrameworkCore.PostgreSQL
EntityFrameworkCore.SqlServerCompact40

Update namespaces
Our packages have been somewhat unique in that the namespace does not align with the package name. We will take this opportunity to change that - and adopt Microsoft.EntityFrameworkCore instead of Microsoft.Data.Entity.
Update branding on docs.efproject.net

And update github Wiki pages, readme etc.

@rowanmiller
Since EF is a well known abbreviation, have you already though about using EFCore instead?
Ex:
using Microsoft.EFCore.ChangeTracking;
using Microsoft.EFCore.ChangeTracking.Internal;
using Microsoft.EFCore.Extensions.Internal;
is much shorter an clearer than:
using Microsoft.EntityFrameworkCore.ChangeTracking;
using Microsoft.EntityFrameworkCore.ChangeTracking.Internal;
using Microsoft.EntityFrameworkCore.Extensions.Internal;

What will be the future?
EF will remain as a "CORE"? Why?
If in two years I will use EF with a WPF project, I will use EntityFrameworkCore 3.x ? Why?!

@davidroth we did consider EFCore instead... whether it is cleaner or not is somewhat subjective and acronyms in namespaces are generally considered bad practice.

@YehudahA

EF will remain as a "CORE"? Why?

Yes, there will be EF 6.x and EF Core x.x. Because they are two different technologies. They have a lot in common - hence the shared "Entity Framework" branding - but EF Core is not v7 of the original stack... it is something new.
For a more detailed explanation see the post announcing the changes - http://www.hanselman.com/blog/ASPNET5IsDeadIntroducingASPNETCore10AndNETCore10.aspx. You could also take a read of a blog post we published a little over a year ago that talks about the options we had, and why we originally chose EF7 - http://blogs.msdn.com/b/adonet/archive/2014/10/27/ef7-v1-or-v7.aspx. We have received a LOT of feedback that calling it v7 is confusing - hence the change to a new name.

What "CORE" mean in context of EF?
@davidroth, AspNet namespaces also change to AspNetCore? I'm not sure.

@YehudahA it's a name being used to identify a set of technologies that follow the same set of "runs everywhere, lighter weight, modularized, etc." principles. It's not something that we chose on the EF team (though I like it).

I've done an initial pass of the Wiki pages. Our Wiki needs a more involved cleanup though, as much content has been moved to our proper docs site.

Npgsql.EntityFrameworkCore.PostgreSQL
EntityFrameworkCore.SqlServerCompact40

Is there some story for naming in case v2 changes the provider model? Doing EntityFrameworkCore2.SqlServerCompact40 does not seem smart.

@cincuranet for our provider packages we will use the same version as the core packages, so Microsoft.EntityFrameworkCore.SqlServer 2.0 will be compatible with Microsoft.EntityFrameworkCore 2.0 etc.

@rowanmiller am back to life and will slowly start working on Npgsql/EF Core again.
To follow up on @cincuranet's question, do you guys have more specific guidelines as to how to manage provider versions vis-à-vis core versions? In other words, I understand that the SqlServer provider compatible with EF Core 2.0.0 should have 2 as its major version (this makes sense). How about the minor version (should there be Microsoft.EntityFrameworkCore.SqlServer 2.1.0 once Microsoft.EntityFrameworkCore 2.1.0 comes out)? Patch version?

I agree with @davidroth that EFCore is neater than EntityFrameworkCore and everyone is using that acronym and it's well known for every EF(...) user what it's.


Move to JUnit5 #165

Updated archetype to use Junit 5

@rmcdouga, does this look ok to you?

@rmcdouga, thanks for the valuable feedback. I fixed the issue you highlighted.

Thank you @vladbailescu and @bpauli for making this change.  I'm looking forward to creating new projects with it. 😄


unable to download component catalog

Not sure if this is a temporary thing. But Github Action seems to a problem downloading files from graalvm.org. I can download the file in the browser:
Adding graalvm-ce-java17-linux 22.1.0 to tool-cache ...
/opt/hostedtoolcache/graalvm-ce-java17-linux/22.1.0/x64/graalvm-ce-java17-22.1.0/bin/gu --non-interactive install --no-progress native-image
Downloading: Component catalog from www.graalvm.org
Error: Error downloading component catalog from https://www.graalvm.org/component-catalog/v2/graal-updater-component-catalog-java17.properties: Connection reset.
Please check your connection and proxy settings. If your machine is behind a proxy, you must set your environment variables (http_proxy, https_proxy, ...) appropriately.
Error: The process '/opt/hostedtoolcache/graalvm-ce-java17-linux/22.1.0/x64/graalvm-ce-java17-22.1.0/bin/gu' failed with exit code 3

This appears to be a temporary thing. Could you please restart your builds? graalvm.org is hosted on GitHub pages to reduce network connectivity issues.


added Recursion-visualiser

Recursion-visualiser  and #4644

Close #4644

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

@MohitGupta121 @TusharKesarwani sir kindly review and merge this PR


Updated to work with Redmine 3.3

Redmine 3.3 adjusted their main-menu and added a drop down. These changes correct this issue.

@mrliptontea ,
It seems not worked in my environment.
click the plus(+)button there's nothing happened.
I checked html code it seems contains the elements but I cannot see and click it.. How to solve it? Thanks.

@archonwang try it now


Move parameter MinKForGSU from globalparameter to BenchmarkCommonParameter to support small matrix GEMM.

The parameter MinKForGSU is a global parameter whose default value is 256. This default value works fine for big matrix GEMM like HPL related GEMM. However, it doesn't work well for small matrix GEMM since it prevents GEMM from using larger GlobalSplitU. It checks the validation of a solution by the following statement in file Contractions.py.
value =  globalparameter['MinKForGSU'] * state['GlobalSplitU']
The parameter MinKForGSU is put into BenchmarkCommonParameter. The condition above is changed to
value =  state['MinKForGSU'] * state['GlobalSplitU']

What do you mean "to meter" in the title? Typo?

What do you mean "to meter" in the title? Typo?

I copied and pasted commit message. Some letters were missing.

I do not know what is wrong with StaticAnalysis check.
Please run "tox -e lint" on your local machine and make sure no error generated.

What do you mean "to meter" in the title? Typo?

I copied and pasted commit message. Some letters were missing.

OK. Please make sure the part is correct when doing "Squash and merge".
It might pick up the old version. Please manually change it if it is old.

I do not know what is wrong with StaticAnalysis check. Please run "tox -e lint" on your local machine and make sure no error generated.

According to the log file, globalParameters is imported but is never used in Contraction.py. That is the reason. It failed if I ran 'tox -e lint'. If I delete the line 'from .Common import globalParameters'. It worked fine.

By the way, are you pushing commits to your fork?

By the way, are you pushing commits to your fork?

Yes. I created a branch based on main repo and then push to my forked repo. I will follow others to create a branch based on forked repo instead of main repo.

By the way, are you pushing commits to your fork?

Yes. I created a branch based on main repo and then push to my forked repo. I will follow others to create a branch based on forked repo instead of main repo.

But, I still do not see your second and third commits separately. It is still single commit including everything....

By the way, are you pushing commits to your fork?

Yes. I created a branch based on main repo and then push to my forked repo. I will follow others to create a branch based on forked repo instead of main repo.

But, I still do not see your second and third commits separately. It is still single commit including everything....

I checked out the branch from the forked repo and push to the forked repo. Did you see the another commit separately?

Remaining items:

add reject condition for GSU=1
find this piece of code in SolutionStructs.py

# to eliminate identical/duplicate kernels when GSU=1
if state["GlobalSplitU"] == 1:
# GlobalSplitUAlgorithm is MultipleBuffer
if state["GlobalSplitUAlgorithm"] == 'MultipleBuffer':
reject(state, " GlobalSplitU=1 and GlobalSplitUAlgorithm='MultipleBuffer'. Rejecting GlobalSplitUAlgorithm='SingleBuffer' to avoid duplicate kernels.")
# GlobalSplitUAtomicAdd is True
if state["GlobalSplitUAtomicAdd"]:
reject(state, " GlobalSplitU=1 and GlobalSplitUAtomicAdd=True. Rejecting to avoid duplicate kernels.")
you need to add another condition like if MinKForGSU != default (=256), then reject it to avoid duplicated kernel.

improve the coverage of Test cases with more GSU values
(1)enable larger GSU with this change (covered by this scenario)
(2) try smallest MinKForGSU (use GSU = K / MinKForGSU)
(3) reject case (K / GSU < MinKForGSU)
(4) reject case 2 with GSU=1 (using not default MinKForGSU + GSU=1)

comment update in the test case
# sgemm NN
-> this is not sgemm

I suggest to add some reject conditions. At least, I suggest to use only default value for GSU=1 case to avoid generating duplicated kernels. I have not fully considered if we need further reject condition(s) for this parameter. We might not need such flexible values for this. Like only power of 2 (32,64,128,256,,,) might be easier to maintain.
Also, please add a test case for this parameter. You do not need to create completely new test file. Just add a scenario to enable this in some existing GSU test case. I am also OK to add a new file if you want.

The only purpose of MinKForGSU is to check if GSU is valid by comparing the value of MinKForGSU*GSU and K.
I set 256 as the default value of MinKForGSU which is the same as previous one.  If MinKForGSU is not set in an existing yaml
file, the default value (256) is used and existing GSU is still valid.  If both GSU=1 and MF are set in a yaml file, there is an existing reject condition to rule out this combination which has nothing to do with the value of MinKForGSU

Remaining items:

add reject condition for GSU=1
find this piece of code in SolutionStructs.py

to eliminate identical/duplicate kernels when GSU=1 if state["GlobalSplitU"] == 1: # GlobalSplitUAlgorithm is MultipleBuffer if state["GlobalSplitUAlgorithm"] == 'MultipleBuffer': reject(state, " GlobalSplitU=1 and GlobalSplitUAlgorithm='MultipleBuffer'. Rejecting GlobalSplitUAlgorithm='SingleBuffer' to avoid duplicate kernels.") # GlobalSplitUAtomicAdd is True if state["GlobalSplitUAtomicAdd"]: reject(state, " GlobalSplitU=1 and GlobalSplitUAtomicAdd=True. Rejecting to avoid duplicate kernels.")
you need to add another condition like if MinKForGSU != default (=256), then reject it to avoid duplicated kernel.

improve the coverage of Test cases with more GSU values
(1)enable larger GSU with this change (covered by this scenario)
(2) try smallest MinKForGSU (use GSU = K / MinKForGSU)
(3) reject case (K / GSU < MinKForGSU)
(4) reject case 2 with GSU=1 (using not default MinKForGSU + GSU=1)
comment update in the test case
sgemm NN
-> this is not sgemm

I don't think we need a rejection condition for GSU=1. I explained that in another comment.

I suggest to add some reject conditions. At least, I suggest to use only default value for GSU=1 case to avoid generating duplicated kernels. I have not fully considered if we need further reject condition(s) for this parameter. We might not need such flexible values for this. Like only power of 2 (32,64,128,256,,,) might be easier to maintain.
Also, please add a test case for this parameter. You do not need to create completely new test file. Just add a scenario to enable this in some existing GSU test case. I am also OK to add a new file if you want.

The only purpose of MinKForGSU is to check if GSU is valid by comparing the value of MinKForGSU*GSU and K. I set 256 as the default value of MinKForGSU which is the same as previous one. If MinKForGSU is not set in an existing yaml file, the default value (256) is used and existing GSU is still valid. If both GSU=1 and MF are set in a yaml file, there is an existing reject condition to rule out this combination which has nothing to do with the value of MinKForGSU

I am not talking about valid or invalid.
This is just to eliminate duplicated kernels.
We do not need any kernels with GSU1 and different MinKForGSU.
To make it easier, you can set MinKForGSU=256 if GSU=1.
It will not reduce the amount of Tensile test combinations, but at least, Tensile will not generate duplicated kernels with GSU1 and different MinKForGSU.

hgemm_gsu_default_minkforgsu.yaml is not necessary.
We already have GSU test cases. It uses default value.

Why so many CI tests are failing?

I think we need to ensure DepthU>=MinKForGSU.
Lets say, if DepthU=32, MinKForGSU=16, K=64, GSU=4.
K/GSU=64/4=16. This satisfies MinKForGSU=16, but I do not expect this works.
Would you please try this kind of extreme cases?

My comment:

please fix static analysis fail
(same as previous comment). hgemm_gsu_default_minkforgsu.yaml is not necessary. We already have GSU test cases which use default value
Would you add a scenario covering DepthU=32, MinKForGSU=16, some K,GSU which satisfies K/GSU=16?
I would like to make sure if this works with DepthU<MinKForGSU

It is always difficult to understand what you changed.
Please always provide comment about your change.
Plus, can't you really avoid using force merge? I cannot trace commit log if you keep using force merge.

Precheckin and extended tests also failed.
Please check why they failed.

Would you add a scenario covering DepthU=32, MinKForGSU=16, some K,GSU which satisfies K/GSU=16?
I would like to make sure if this works with DepthU<MinKForGSU

Your statements conflict. Do you mean DepthU=16, MinkForGSU=32?

Correction:
Would you add a scenario covering DepthU=32, MinKForGSU=16, some K,GSU which satisfies K/GSU=16?
I would like to make sure if this works with DepthU > MinKForGSU

(same as previous comment). hgemm_gsu_default_minkforgsu.yaml is not necessary. We already have GSU test cases which use default value

Remove it.

Did you really remove it?
I still see the file in "File Changed".

(same as previous comment). hgemm_gsu_default_minkforgsu.yaml is not necessary. We already have GSU test cases which use default value

Remove it.

Did you really remove it? I still see the file in "File Changed".

I haven't checked in my code yet.  :)

I do not know why precheckin and extended tests fail in this way.
Expected equality of these values:
oclProps.maxGridSize[1]
Which is:<PHONE_NUMBER>
hipProps.maxGridSize[1]
Which is: 65535
[  FAILED  ] OclSolutionAdapterTest.HardwareTest (0 ms)
Any idea?

I do not know why precheckin and extended tests fail in this way.
Expected equality of these values: oclProps.maxGridSize[1] Which is:<PHONE_NUMBER> hipProps.maxGridSize[1] Which is: 65535 �[0;31m[ FAILED ] �[mOclSolutionAdapterTest.HardwareTest (0 ms)
Any idea?

I have no idea. I could not find any clues from log. I launched rebuild yesterday and it is still running.

Please merge the latest develop branch.
CI test should pass with the latest develop code.

One thing I need to say is that I have added MinKForGSU in Tensile\Tests\extended\direct_to_vgpr\dtv_hgemm.yaml.
Please update this file.


Add Toggle support to Familiars

Closes #16175
No toggle:

toggle:

For this one, please put {{#if toggles.actions}} outside of the entire thing, so that there is no alteration of its vertical spacing or markup if no toggles exist.


Metadata placed in wrong folder when retrieving via manifest

Summary
When pulling some custom objects random files are placed in the wrong folder. It only happens on some objects and not others. Objects I've seen this happen on are User, Lead, Opportunity, and Account.

Steps To Reproduce:

Create a Manifest file that contains the above-mentioned objects.
Right-click on Manifest file and select `SFDX: Retrieve Source in Manifest from Org" -> Wait

Expected result
Files should be placed in their respective folders.
Actual result
Files are placed in random locations within the SObject Folder Structure.
Additional information

SFDX CLI Version(to find the version of the CLI engine run sfdx --version):
sfdx-cli/7.83.1 win32-x64 node-v14.4.0
SFDX plugin Version(to find the version of the CLI plugin run sfdx plugins --core)
@oclif/plugin-autocomplete 0.1.5 (core)
@oclif/plugin-commands 1.3.0 (core)
@oclif/plugin-not-found 1.2.4 (core)
@oclif/plugin-plugins 1.9.5 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/lwc-dev-server 2.10.0
├─ @oclif/plugin-help 2.2.3
└─ @oclif/plugin-update 1.3.10
@salesforce/sfdx-diff 0.0.6
@salesforce/sfdx-trust 3.6.0 (core)
alias 1.1.5 (core)
analytics 1.12.1 (core)
auth 1.4.6 (core)
config 1.2.3 (core)
generator 1.1.3 (core)
salesforcedx 50.12.0 (core)
├─ schema 1.0.3 (core)
├─ limits 1.0.2 (core)
├─ apex 0.1.4 (core)
├─ custom-metadata 1.0.11 (core)
├─ templates 50.1.0 (core)
├─ @salesforce/sfdx-plugin-lwc-test 0.1.7 (core)
└─ salesforce-alm 50.12.0 (core)
sfdx-affirm 2.1.2
sfdx-cli 7.83.1 (core)

OS and version:
OS Name:                   Microsoft Windows 10 Pro
OS Version:                10.0.18363 N/A Build 18363

Same being tracked in issue #714.
Closing this issue.


chore(main): release 1.3.2

:robot: I have created a release beep boop
1.3.2 (2024-01-28)
Miscellaneous Chores

release 1.3.2 (0049f00)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ryanhanks-bestow/__a_test/releases/tag/v1.3.2 :sunflower:


Guys when i open the generated file it open and than nothing happens i cant control it trugh discord someone help.

Guys when i open the generated file it open and than nothing happens i cant control it trugh discord someone help.

did you enabled the intents in the developer portal? If not, make sure to turn all three on. Also if you run it on a vm for testing etc, make sure to enable debug mode or otherwise it will not work cause of antivm

i have the same issue

Added you @monkeyrizz

Added you @monkeyrizz

yo add me on discord, i have the same issue, user: b61b

b61b

added

Added you @monkeyrizz

can you add me too i am having the same problem

Added you @monkeyrizz

can you add me too i am having the same problem

whats ur username

yo bro help me out aint working my user is yttium

b61b

added

add me pls i am m_hea


Update readme from branch example

I updated the readme file. Please review and accept

I probably shouldn't, but Okay 👍


feat: Add sendJson

What does this change?
Adds a way to safely send a JSON payload, using navigator.sendBeacon with a fetch fallback.
Why?
sendBeacon isn’t fully supported.

Coverage decreased (-1.2%) to 98.364% when pulling 6fdaf53dd987b3a2f47c16670d8c6a0d4d1430b9 on mxdvl/send-json into 3fc88e78b8b03a2aac5821f81f0a7424a528de8b on main.

Actually, I think it is better to polyfill sendBeacon


Report Editor - Do not store perf interval options in session

Do not store performance interval options in session
Calculate them in helper instead. As a side effect the options are calculated only when really needed (when form_filter_performance is rendered).
@miq-bot add_label technical debt, reporting, ui
@miq-bot assign @martinpovolny

I object against the Codeclimate verdict, I believe I have made the world better place with this.

@isimluk please rebase to remove the codeclimate check

Done. Ready to be merged @martinpovolny.

typo: "valialble" : Refactor: Avoid passing the same instance varialbe to a method

All looks good. The only small glitch is the typo. Please, fix it, then we can merge. Thx!

Typo fixed. :fried_shrimp:


swift_build_sdk_interfaces.py: create directory under dry-run mode

Users may install a different version of SDK from the one found in the
originally downloaded toolchain. Thus, we may need to create a new directory structure
instead of using the original one in the toolchain, especially if the SDK under use has a
different version number.
rdar://67951012

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test


Lab 03 Test Case 10

Having difficulties passing the last test case in Lab 03, what makes it different from the prev cases if anyone has any idea?

oh... i can see the problem now haha thanks a lot!


Add missing libkb file

this file was missing in the vendor package

Why isn't vendor.json updated with a new checksum?

these files are git ignored, the correct checksum was put into https://github.com/keybase/kbfs/pull/1789 but this file was mistakenly missing from the merge

I'm confused, msgpack.go is being gitignored?

$ git add vendor/github.com/keybase/client/go/libkb
The following paths are ignored by one of your .gitignore files:
vendor/github.com/keybase/client/go/libkb
Use -f if you really want to add them.

although i can't find any .gitignores in this repo or my global config that are causing this, i'm not sure the root cause

but we should get this in since it breaks CI for all

I'd guess the root cause is that this is a brand new file that got added to master while your client PR was in review, and when you squashed yours in and re-merged, you didn't git add --all vendor in kbfs afterwards.
No idea about the gitignore thing.
Let me try it locally.

yeah i didn't realize that the gitignore was in play and that i should be force adding those vendor dirs

Hmm you're right.  I don't get the gitignore error, but govendor doesn't update the checksum when I re-vendor it, so something's weird with your local gitignore config.

sorry about that! i'll try to figure out what is setting it locally so it doesn't happen again


Check for length in initStreamsWithData:port:

This fix mimics the solution provided in 1bd00e3c9ba451948bd7a6f101e484ea04e83a31, to also provide safety in initStreamsWithData:port:

I have also modified doWriteError to clean up the disconnection.

I like it, thanks :+1: .

No problem :smile: I'm loving Jetfire btw.


translation for Japanese

@terapyon @sneridagh we had the same problem with the German translations. It would be great if we could add a check for untranslated strings that at least warns us if there are missing translations. I would be more than happy to take care of the German translations and make sure that we always have 100% of all strings translated.
@robgietema is something like this possible with our current i18n setup?


WKO 4.0 AI Test: Verify the existing 3.0 Usecase in ItMiiAuxialiaryImage.java

Added tests Case 5, 6, 8 and 9, case 9 is failing, commented out.
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/8873/

as we discussed, I will convert to use image tool in separate PR

Case 9 is failing, will file a bug


Client Allocation Request for: Yahoo Taiwan holdings limited.

Client Allocation Questions
Core Information

Name: Yahoo Taiwan holdings limited.
Website / Social Media: https://tw.buy.yahoo.com/
Region: Asia excl. Greater China
DataCap Requested: 10TiB
Addresses to be Notarized: f1poxtmorxzj6kchi2twz42phmvvuszexaoegjwia
Notary Requested: rayshitou

@nickyh123 Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Hi @nickyh123, thanks for your application. Please answer the following questions to let me know you and your company.
1.What's your name and your position in your company?What's your company's business?
2.Could you show me your company's business license? And please show me your company searching consequence in the local business license searching website.
3.Have you/your company ever used cloud? Which platform do you use? What's your usage volume and frequency? Could you please show me your cloud usage evidence?

Name's John, I work in the administration management department. We are a branch company in Taiwan belongs to Yahoo, our business mode resembles other famous e-commerce companies like Amazon or Taobao.com. We provide convenient online shopping experience and offers commodities in many categories.
Will send you an email.
Yes we use google and have a growing usage volume of 400GB a month. Sorry can't provide any evidence because of company's guides.


How to configure domain and port for entity data service calls?

Using DefaultDataServiceConfig, I can specify the path for single and collection resource URLs.  However, for development environment or CORs, how do I specify the domain and port?

It looks like you can actually put the entire URL in the entityResourceUrl and collectionResourceUrl properties for DefaultDataServiceConfig.
Closing issue now.


Issue litmuschaos#2103 added validation for Username

Improved the username input field of Create New User
section(Settings Page)
Update regex
Username now include Aplhanumeric Chars
with @. (at, dot)allowed as Special charecter
Signed-off-by: AbhishekJ<EMAIL_ADDRESS>
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[ ] New feature (non-breaking change which adds functionality)
[X ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[X ] I have read the CONTRIBUTING doc
[ X] I have signed the commit for DCO to be passed.
[X ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[X ] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

This input field component is the process of getting scraped...but the validation is good.
@S-ayanide you can add this PR depending on the progress of litmus-ui integration with litmus-portal

Closing this PR as some of the users wants to keep the username field simple and don't want any validation for the same. We Will reconsider this if required in future :slightly_smiling_face:

Closing this PR as some of the users wants to keep the username field simple and don't want any validation for the same. We Will reconsider this if required in future slightly_smiling_face


fix ReadBuffer()

Revert changes introduced in 844f6937, fixes #1872 and #1974.
Holding one byte in advance would cause ReadFrom() blocks till timeout in case the remote server has just one byte to send, which is exactly how iperf3 server behaves.

@vcptr

For recording purpose:
The one-byte buffer was introduce at 0f63be63400b7284d9004c3ac660ca25c57c1ae7 and the function rename from readOne to ReadBuffer at f7abe353df088e958949f7dd2b405671dcff80bc during the integration of the quic protocol, but later the call to buf.ReadBuffer was removed at 6a0b3af4c603796928e69040135f711c30df49c8 , and buf.ReadBuffer is not called anywhere else other than inside buf package.
It's safe to get rid of the one-byte buffer mechanism.

maybe this commit needs to be reverted, for the commit cause multiple test cases failing.
I dug into one of the fail on http/proxy module,  the failing of
go test -timeout 300s v2ray.com/core/testing/scenarios -run ^(TestHttpPost)$

The core encountered the following problem and closes the client connection.
The ReadVReader some how writes incorrect number of the buffer size to the remote.
2019/11/20 18:41:27 [Warning] [1325493970] v2ray.com/core/app/proxyman/inbound: connection ends > v2ray.com/core/proxy/http: connection ends > v2ray.com/core/proxy/http: failed to write whole request > http: ContentLength=65536 with Body length 65337

I can't not find the root cause of the issue at the moment, but the code works fine before this commit.

I have created another PR #2041 to fix these issues.


Make the details panels update based on a push from the App, not a poll from the UI

So when you click start you immediately get a fresh set of controls.

Considering this for 0.14 metrics-on-canvas backend work.

This is especially obvious on metrics. All-combined the polling intervals of the probe spy (1s), and publish (3s), and the UI polling (30s), the details panel can be up to 34s out of date.

Looks to me like it's polling every 5 seconds now.


Pass region as config to minio client to support s3 bucket as storage

Hi, first of all thanks for providing these options to use custom cache storage providers!
I really would like to use this lib with a s3 bucket, but during testing, I got the following error:

I think this could be fixed by passing a region to the minio client constructor optionally, which could be retrieved from nx.json or env like the other options.
If I find time, I might open a pull-request in the next days to add this option.

Thanks for your contribution!
Now available in version<EMAIL_ADDRESS>🚀


Updated documentation for lifecycleState.

Related issue: https://github.com/flutter/flutter/issues/73978
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

(PR triage): Are there still plans for this PR or should we close it for now?

@goderbauer We can close this for now and see how the discussion progresses on the internal bug.  There is some debate about the right wording and there doesn't seem to be much pressure hammer it out right now.


Where can I find the mappings for current :EMOJICODE: systems (Slack, Discord, iOS, Android, etc.)?

Even the much referenced WEBFX Emoji Cheatsheet doesn't list its source or mappings. Github does, but I want to find out which code system is the most popular/used one - or rather which one's exist. I want to build an application that allows anyone to use emojicode in any application and any os and would appreciate any pointers in the right direction as to where I can find more information about the various mappings that exist already.

Not here. I am pretty positive that there is a bigger open source library on GitHub that does this mapping but not off the top of my head.


fix: Overlapping table name issue in Readers [AtlasProxy]

Summary of Changes
Add a coma to distincly separate table name end. Otherwise, table which names overlaps with beginning of another tables name (like table_name and table_name_test) will present also readers for table_name_test.
Tests
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes.
[x] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[x] PR passes make test

Codecov Report

Merging #154 into master will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   73.25%   73.35%   +0.10%
==========================================
  Files          26       26
  Lines        1249     1265      +16
  Branches      132      136       +4
==========================================
+ Hits          915      928      +13
- Misses        307      309       +2
- Partials       27       28       +1

Impacted Files
Coverage Δ

metadata_service/proxy/atlas_proxy.py
84.24% <ø> (-0.25%)
:arrow_down:

metadata_service/config.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48dfa05...7fdce8f. Read the comment docs.


Content System + Content Assembly Loading

You now can dynamically load file directories and content packs into the ContentManager. Each pack you load into the manager is relative to the root directory "./". So if you load a zip file with the file ./Assemblies/Content.Server.dll in it, you use that relative location in ContentManager.GetFile(). If two packs have the same file, the file from the first pack loaded will be used. Content packs can be loaded at any time into the ContentManager. I have set it up so that the executable directory is loaded before the content pack, so people can override anything in the content pack by dropping it in the relative location in the projects bin folder.
The Content assemblies are now loaded through the Content System. Before they are loaded, their referenced types are scanned through a whitelist. I also added an option to dump all referenced types to the log so that people can see how they are filtered through the whitelist. W = whitelisted, G = greylist, B = Blacklist. If anything ends up on the black list or grey list, the assembly will be prevented from loading. Feel free to modify the lists in SS14.Shared.ContentPack.AssemblyTypeChecker.cs. Remember that this is only a front-line defense against malicious assemblies, and we should be doing other things with OS security to prevent bad things happening to clients. The last thing we need is this project to be spreading malware to players.
I also started to switch over the old content cache system in SS14.Client.Resources.ResourceCache. The new system is built into the old class, and does work, but is unfinished. Fonts were converted to the new system, you can see how they are accessed. The idea was to use something like the code side of XNA's ContentManager system. When we switch over to RobustEngine we can decide if that is a good idea or not.
The embedded resources in the SS14.Client were moved to the EngineContentPack. This pack is required for the engine to function. It should include things like UI resources and data files for the splash screen/menu system.
Another random thing: Vsync is now enabled and the Thread.Sleep() was removed.

Could also add support for loading resources from directory outside of the resource.pak?
That way i can work on assets without having to pack them for testing.
Also would mean we can support clientside UI mods.

I don't think client side UI mods is something we should allow. It's just a gateway to cheating. Least we could do is not encourage it.

We can disable it in release builds if it becomes an issue, but for debug builds it should allow them.
Would mean we'd need to also allow servers to block debug clients

It does support loading resources from any directory, sorry I was not clear on that. Right now it is adding the exe's directory, so it can load anything in the ./space-station-14/bin/Client/ folder as if it was in a resource pack.


Input Lag with Xbox Wireless adapter and xbox one controller

After the update there is massive input lag while playing games wirelessly using the wire xbox adapter and xbox one controller. When using a wired controller this does not happen. I tried using PS4 controller wired and had no issue.
Another thing to note as an example, that in a game such as Elden Ring navigating through in game menus works fine and has no input lag but when trying to move your character around is when there is massive input lag.

You need to update your controller firmware. Unfortunately, this can only be done on Windows.

That worked, thank you for the help.

How did you make it? Does it work with a Windows vm?


Add GT

为确保 Token Profile 的顺利通过，务必逐一确保以下检查项并补充项目资料：
.json 及 .png 文件检查项

[x] logo 尺寸：120*120 px
[x] logo 背景：透明
[x] 代币有至少一笔成功的转账记录
[x] 此项对于 ERC-20 项目方：合约地址有大小写（做 checksum）
[x] .json 和 .png 文件名一致（包括大小写）

项目资料：
官方公告：GT (Grand Tourer) is a high-performance decentralized wallet based on Web3, which will be built into a global community autonomous wallet system.
团队背景：Blockchain technology management from Silicon Valley, Microsoft, and Google, committed to creating real Web3 projects
项目基本情况：GT (Grand Tourer) is a high-performance decentralized wallet based on Web3, which will be built into a global community autonomous wallet system.
媒体报道：None
收录的交易所：Uniswap
转账所需 Gas Limit（对 ERC-20 项目方）：60000（默认为 60000）

Please check the following to ensure a successful verification of Token Profile
.json and .png document checklists

[x] logo dimensions: 120*120 px
[x] logo background: Transparent
[x] At least one transaction on the token contract
[x] For ERC-20 project teams: Upper and lower capitalized alphabets in token address (For checksum purposes)
[x] Same document name for both .json and .png (Including capitalization)

Project background:
Official announcement:GT (Grand Tourer) is a high-performance decentralized wallet based on Web3, which will be built into a global community autonomous wallet system.
Project team background:Blockchain technology management from Silicon Valley, Microsoft, and Google, committed to creating real Web3 projects
Project basic information:GT (Grand Tourer) is a high-performance decentralized wallet based on Web3, which will be built into a global community autonomous wallet system.
Media publications:None
Tradeable exchanges:Uniswap
Recommended Gas Limit (For ERC-20 project teams) for transaction:60000 (Default is 60,000)

It will not be listed because of potential risks( no official website, no social media channels). @grandtourer


About Page Updates

This is a branch to work on updates to the about page, see #11. Some things to do off the top of my head:

[ ] Update language around "what is ml5.js", explain ml5.js next-gen and earlier version and where to find archived materials.
[ ] Since the documentation is new and doesn't necessarily reflect all of what we hope to include about data, models, and ethical use, the language should be updated to be more clear about our aspirations and current documentation.
[ ] Update language to explain and provide links to details about Code of Conduct and License.  cc @LiyanIbrahim
[x] Include credits for new website and keep credits for previous website.
[x] Update support from ITP/IMA, IMA Shanghai, DAIL (?), and past support from Google
[x] Link to all contributors? cc @ziyuan-linn

A quick list of updates that we need to do!

It'd be fantastic if we could acknowledge the DAIL grant - language could be something like: Development was supported in parts by a grant by the Shanghai Frontiers Science Center of Artificial Intelligence and Deep Learning.

Thank you @gohai for reminding us! I will make sure to include the text!

I'm slowly updating this page piecemeal. @MOQN could you add any key website credits and @ziyuan-linn could you add generic language about library contributors with a link to all contributors? See the placeholders with [ and ] I've put in for now. I can edit and synthesize!
@gohai please check the language about DAIL and anything related to NYU Shanghai!

Perfect - thanks @shiffman!

@shiffman It seems like I don't have write access to this repo. I will paste the change here since it is not too long.
The first paragraph in Acknowledgment:

  ml5.js is supported by the time and dedication of open source developers from all over the
  world. We are artists, designers, technologists, researchers, educators, students,
  scientists, developers, parents, children, and everything in-between. We are proud of our{' '}

    growing list of contributors

  .

I will merge what we have for now!

@shiffman, I apologize for closing this PR! I thought I might be able to reopen it after merging it. Is there any preferred way to reorganize this PR?

@shiffman, I apologize for closing this PR! I thought I might be able to reopen it after merging it. Is there any preferred way to reorganize this PR?

Not to worry, we can continue further updates to the about page in other branches and PRs!


Laravel 10.12.0 Shift

This pull request includes updates for the recent minor version release of Laravel as well as updates to your package dependencies. Feel free to commit any additional changes to the shift-ci-v10.12.0 branch.
Before merging, you need to:

Checkout the shift-ci-v10.12.0 branch
Review all pull request comments for additional changes
Run composer update
Thoroughly test your application (no tests?, no CI?)

:warning: The Shift build servers run PHP 8.1. If you are running a different version of PHP you should run composer update locally to ensure you have the proper versions of your dependencies to reflect your PHP environment.


chore: ensure local package private

Description
Ensure local packages have "private": true to prevent accidental publish. Also set for create-vite templates.
Additional context
There are two package.json in packages/vite/src/node/__tests__/packages that I didn't update since it could affect the tests, but the package.json themselves are already invalid so it prevents publishing.

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

👍 I think it will be safer for the user too so they don't accidentally publish their project to npm, even if it's with lib mode. In the past when setting up changesets, the default template without private: true has caught us a few times accidentally publishing them.

You are right. We should add private: true to create vite apps by default tgen


Fix: prevent receiving notification when logging out

Details

Prevent receiving notification when logging out
Fixed Issues

$ https://github.com/Expensify/App/issues/26247
PROPOSAL: https://github.com/Expensify/App/issues/26247#issuecomment-1698730404
Tests

Log in to Account A.
Turn OFF the network connection to enter OFFLINE mode.
LOG OUT
While the app is still in OFFLINE mode, send a message from another account to Account A (IMPORTANT STEP).
Turn ON the network connection.
Verify that notification doesn't appear.

[x] Verify that no errors appear in the JS console

Offline tests
Same as Tests.

QA Steps

Log in to Account A.
Turn OFF the network connection to enter OFFLINE mode.
LOG OUT
While the app is still in OFFLINE mode, send a message from another account to Account A (IMPORTANT STEP).
Turn ON the network connection.
Verify that notification doesn't appear.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/16502320/98854448-0b4e-47fe-b9e1-0252987b3425

Mobile Web - Chrome

https://github.com/Expensify/App/assets/16502320/f3b56d2e-8b95-415c-b560-5fed2b9f0ced

Mobile Web - Safari

https://github.com/Expensify/App/assets/16502320/ca4809ea-e99c-4bf5-9e14-312ee723a7af

Desktop

https://github.com/Expensify/App/assets/16502320/2c71982b-f312-4e17-9927-682f3a6816b0

iOS

https://github.com/Expensify/App/assets/16502320/fa2205cd-33ef-4ac3-8956-c7b7df8b99de

Android

https://github.com/Expensify/App/assets/16502320/0424ba8d-ddd1-4727-8105-c5b654dc6256

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.73-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.74-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


creationTimeUnix nested under cross references

If creationTimeUnix is requested under additional properties in a cross reference the value returns as null.
Example https://link.semi.technology/3SYwl9X
{
  Get {
    Article {
      title
      url
      wordCount
      inPublication {           # the reference
        ... on Publication {    # you always set the destination class
          name                  # the property related to target class
	  _additional { creationTimeUnix id }
        }
      }
    }
  }
}

Returns "creationTimeUnix": null,
While
{
  Get {
    Publication {
      name
      _additional {
        creationTimeUnix
        id
      }
    }
  }
}

Returns "creationTimeUnix": "1664504985062"

Just to add, if requesting vector, this also returns null.


Exception when opening a vistrail

Doesn't happen everytime, unfortunately. Might have to do with the order in which notifications are sent, when the new controller is loaded.
As far as I understand it, in response to the "controller changed" notification, the version view might emit a "version changed" notification. This is super-unsafe since not every observer has changed to the new controller yet.
!!!!!!!!!!
Got unexpected exception, starting debugger
Traceback (most recent call last):
  File "vistrails/run.py", line 160, in <module>
    main()
  File "vistrails/run.py", line 154, in main
    v = app.exec_()
  File "vistrails/gui/vistrails_window.py", line 1491, in new_vistrail
    self.open_vistrail(locator)
  File "vistrails/gui/vistrails_window.py", line 1628, in open_vistrail
    is_abstraction):
  File "vistrails/core/application.py", line 407, in open_vistrail
    *loaded_objs[1:])
  File "vistrails/gui/application.py", line 307, in add_vistrail
    return self.builderWindow.add_vistrail(*objs)
  File "vistrails/gui/vistrails_window.py", line 1588, in add_vistrail
    view = self.create_view(*objs)
  File "vistrails/gui/vistrails_window.py", line 947, in create_view
    thumbnail_files, mashups)
  File "vistrails/gui/vistrail_view.py", line 123, in __init__
    self.set_controller(self.controller)
  File "vistrails/gui/vistrail_view.py", line 202, in set_controller
    view.set_controller(controller)
  File "vistrails/gui/version_view.py", line 1282, in set_controller
    self.scene().setupScene(controller)
  File "vistrails/gui/version_view.py", line 1019, in setupScene
    self.selectionChanged()
  File "vistrails/gui/version_view.py", line 1137, in selectionChanged
    -1, self.select_by_click, True, False, False)
  File "vistrails/gui/vistrail_view.py", line 840, in version_selected
    _app.notify("pipeline_changed", self.controller.current_pipeline)
  File "vistrails/gui/vistrails_window.py", line 1271, in notify
    vt_app.send_notification(notification_id, *args)
--- Exception caught here ---
  File "vistrails/gui/application.py", line 404, in send_notification
    m(*args)
  File "vistrails/gui/paramexplore/param_view.py", line 122, in set_pipeline
    self.pipeline_view.scene().setupScene(pipeline)
  File "vistrails/gui/pipeline_view.py", line 2346, in setupScene
    self.update_connections()
  File "vistrails/gui/pipeline_view.py", line 2756, in update_connections
    if self.controller.current_pipeline.is_valid:
AttributeError: 'NoneType' object has no attribute 'is_valid'
!!!!!!!!!!
> vistrails/gui/pipeline_view.py(2756)update_connections()
-> if self.controller.current_pipeline.is_valid:
(Pdb) p self.controller.current_pipeline
None
(Pdb)

I'm not sure if this affects other versions, bisecting is hard since it doesn't happen all the time.
(also, note the traceback & debugger integration)

I still run into this

397af1a667e5848b5322d752f84801e1fed88dcc removes the error. But this is not the actual problem. It looks like setupScene is causing a signal that is setting current_pipeline to None. This is happening in the Parameter Exploration view. All the views are updated when the pipeline changes so there are a lot of signals being sent around. Most views are hardened by only updating when something have really changed. We should improve this, but it will be a major change.


Copying items between iPhone and Macbook stopped working

It seems that when Maccy is running copying items between iPhone and Macbook stopped working.
Ideal would be to insert item into Maccy when copying from iPhone with an option to enable/disable this feature.

Maccy doesn't do anything for copies between mac/iPhone - if it stopped working it's likely an iCloud Sync problem. Could also be just a temporary issue.


Creating the Initial Output/Design of Lazatech Educate Using Canva

Related to user story #12 and #13
Sign In DONE Coleen

Sign Up DONE Guillan

Lazatech Educate Courses DONE Gab

My Token Balance Guillan

Lazatech Store Guillan

Course page Guillan:

Quiz Page Gab:

Assigned Person: All members
Canva Link: https://www.canva.com/design/DAFGL0nxI1o/YxpciwsWUH3vbl3-YDa-AQ/view?utm_content=DAFGL0nxI1o&utm_campaign=designshare&utm_medium=link2&utm_source=sharebutton
Progress: 100%

Mock up designs for every page is now finished...


Order side panel

Hi @mgrenier
Sorry to disturb you but since this morning my Remote-FTP panel is fixed on Left, and after I have my tree-view... Impossible to switch them position. I want tree-view, and after Remote-FTP.
Please, can you tell me how can I change the position of them ?
Thank you in advance !

I was just about to post this also, I would rather if my FTP showed to the right of my working project @mgrenier

same issue, it also prevents me from uploading files on local machine to remote.
Could it be related to the recent Atom update that added the collapsible tab for the local tree view? i only noticed that last week for the first time.

Confirmed.
Also happening

From what I can tell, this is caused by the latest update in Atom, changing the Tree-view to use a dock, instead of a panel. What needs to be done in the plugin is to use a dock as well.
When I have time, i'll look into this deeper.

Same here!

Update Remote-FTP. 🔨


Jbpm 4703

Jbpm 4703 Can't create new project containing spaces in name via REST API

This PR contains way too many files; I suspect you need to resync your fork and resubmit.


[Forwardport 2.10] Managed RKE2 clusters are broken after upgrade to 2.9.1 when KDM is not updated to release-v2.9

Forwardport: https://github.com/rancher/rancher/issues/46855

Ticket #47086 - Test Results - ✅

Scenario
Test Case
Result

1.
Test upgrade with kdm change
PASS

Verified with HA Helm on Rancher v2.10-dae07ed09601506420c133a69d6e6d27bb7a53ec-head:
Permutations: rke2/k3s/custom/nodeDriver
Scenario 1: Test upgrade with kdm change

Create a 2.9.2 rancher instance
Change the kdm version
Deploy a cluster
Upgrade the rancher instance to 2.10-head
Verify that a kdm error is displayed due to the kdm branch being wrong

Results: The error is observed
Screenshots:


feat(general): Convert Python AWS CDK policies to V2

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Convert Python CDK policies to V0.2 syntax

@gruebel FYI


Please delete this issue.

Solved the issue.

Generally leave the issue contents here as it may help someone else having the same problem.


Why is it that the depth_image_proc point_cloud_xyz depth image converter is so much more efficient than built in realsense methods?

When I run the nodelet chain to get out a point cloud, it takes about 2% more CPU on the process. When I do so through the realsense ros camera, it adds more than 100% load.

@SteveMacenski depth_image_proc might be downsampling the images for generating the point_cloud.

[Please Ignore - RealSense system comment]

Close this issue for lack of activity. Please feel free to reopen if the issue is still relevant.

Still open needing a response....

Hi @SteveMacenski,
just wondering, does it make any difference if built with OPENMP=false?
cmake ../  -DBUILD_WITH_OPENMP=false -DCMAKE_BUILD_TYPE=release
nuc:~/catkin_ws$ roslaunch realsense2_camera rs_rgbd.launch
skip---

SUMMARY
========
PARAMETERS
skip---
 * /camera/realsense2_camera/base_frame_id: camera_link
 * /camera/realsense2_camera/clip_distance: -1.0
 * /camera/realsense2_camera/color_fps: 30
 * /camera/realsense2_camera/color_frame_id: camera_color_frame
 * /camera/realsense2_camera/color_height: 480
 * /camera/realsense2_camera/color_optical_frame_id: camera_color_opti...
 * /camera/realsense2_camera/color_width: 640
 * /camera/realsense2_camera/depth_fps: 30
 * /camera/realsense2_camera/depth_frame_id: camera_depth_frame
 * /camera/realsense2_camera/depth_height: 480
 * /camera/realsense2_camera/depth_optical_frame_id: camera_depth_opti...
 * /camera/realsense2_camera/depth_width: 640
skip--- * /rosdistro: kinetic
NODES
  /camera/
    color_rectify_color (nodelet/nodelet)
    points_xyzrgb_hw_registered (nodelet/nodelet)
    realsense2_camera (nodelet/nodelet)
    realsense2_camera_manager (nodelet/nodelet)

auto-starting new master
process[master]: started with pid [10484]
ROS_MASTER_URI=http://localhost:11311

setting /run_id to 7744057c-4f5b-11e9-ada9-f44d30674271
process[rosout-1]: started with pid [10497]
started core service [/rosout]
process[camera/realsense2_camera_manager-2]: started with pid [10514]
process[camera/realsense2_camera-3]: started with pid [10515]
process[camera/color_rectify_color-4]: started with pid [10516]
process[camera/points_xyzrgb_hw_registered-5]: started with pid [10523]
[INFO] [1553558987.819203063]: Initializing nodelet with 4 worker threads.
[INFO] [1553558987.915983968]: RealSense ROS v2.2.1
[INFO] [1553558987.916052966]: Running with LibRealSense v2.19.1
[INFO] [1553558988.072408994]: getParameters...
[INFO] [1553558988.147450091]: setupDevice...
[INFO] [1553558988.147480889]: JSON file is not provided
[INFO] [1553558988.147502754]: ROS Node Namespace: camera
[INFO] [1553558988.147525347]: Device Name: Intel RealSense D415
skip---
[INFO] [1553558988.147708502]: Align Depth: On
[INFO] [1553558988.147744987]: Sync Mode: On
[INFO] [1553558988.147821089]: Device Sensors:
[INFO] [1553558988.147873429]: Stereo Module was found.


Sfm 302 restart

@justinlittman I re-ran the /pr build, and it's still failing.  I don't have a complete enough understanding of the PR to determine whether this is an issue to ignore or not.  What's your take?


Isn't this a hard copy from https://github.com/izyumkin/MCEmojiPicker?

I know you said it was inspired from https://github.com/izyumkin/MCEmojiPicker, but it looks the same feature in the end.
Why not forking https://github.com/izyumkin/MCEmojiPicker? And contributing to its project. I really don't get it.
This looks like the same repo, but you changed some methods and names and removed the search field.

That's really nice then. Good work.


All MediaPipe solutions on Python do not work with Turkish locale

System information (Please provide as much relevant information as possible)

Have I written custom code (as opposed to using a stock example script provided in MediaPipe): No. I used examples here
OS Platform and Distribution: Ubuntu 22.04 LTS with Turkish locale (tr_TR.UTF8)
Programming Language and version: Python 3.10.4
MediaPipe version: <IP_ADDRESS> (Latest PyPI package)
Solution: All python solutions in here

Describe the current behavior:
All MediaPipe solutions in python fail when using Turkish locale (tr_TR.UTF8):
(mp) erena@Casper-PC:~/mp$ LC_ALL=tr_TR.UTF8 python3 hand.py
Traceback (most recent call last):
  File "/home/erena/mp/hand.py", line 10, in <module>
    with mp_hands.Hands(
  File "/home/erena/mp/lib/python3.10/site-packages/mediapipe/python/solutions/hands.py", line 114, in __init__
    super().__init__(
  File "/home/erena/mp/lib/python3.10/site-packages/mediapipe/python/solution_base.py", line 237, in __init__
    validated_graph.initialize(
ValueError: while processing the input streams of subgraph node InferenceCalculator: TAG:index:name is invalid, "TENSORS:palmdetectioncpu__Inferencecalculator__palmdetectioncpu__input_tensor" does not match "([A-Z_][A-Z0-9_]*:((0|[1-9][0-9]*):)?)?[a-z_][a-z0-9_]*" (examples: "TAG:name" "VIDEO:2:name_b", "longer_name").

Describe the expected behavior:
Solutions must work without any errors like in any other locale:
(mp) erena@Casper-PC:~/mp$ LC_ALL=en_US.UTF8 python3 hand.py
INFO: Created TensorFlow Lite XNNPACK delegate for CPU.
<example just works>

Standalone code to reproduce the issue:
All python solutions in here can be used to reproduce the error; for example this.
Other info / Complete Logs :
Since the error is something with regex, I think the issue is something about uppercase 'i' (which is 'İ', not 'I') and lowercase 'I' (which is 'ı', not 'i') in Turkish.
Also; #2306, #2603 and #1778 are related to this problem

Hi @insanolanbiri ,
Could you share code changes to investigate further on this issue.

Hi @insanolanbiri ,
Could you share code changes to investigate further on this issue.

Code changes? I tried every solutions' example in here without any changes and any of them worked.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you.

why

Hi @insanolanbiri ,
This could be a internationalization in mediapipe validation code on ValidfatedGraphConfig or a general bug in python internationalization.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you.

why

Closing as stale. Please reopen if you'd like to work on this further.

Why

Hi @insanolanbiri ,
Could you please check my above comments https://github.com/google/mediapipe/issues/3311#issuecomment-1125652702 and rever back still if you are facing any challenges.

changing locale fixed my problem: https://askubuntu.com/a/227513
then log-out and log in back.


The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner.  Replaced by revive.

#4


covers: alignment on frontsite search

Make the cover frame constant, fit the image in it while preserving the aspect ratio and avoiding overflow. The images are always centred.
Addresses #296 (TODO need to address the border suggestion)
Notes:

this does not apply on mobile, but it applies on the computer stacked view
I didn't find a way to inherit the height or make it relative to the width, so I hardcoded it (200px)
there is no left/right margins so the wide covers will match the overlay width (typically square or landscape images). I personally don't find it odd but it can be changed if necessary

A screenshot of the stacked view

You are right, I was also thinking about changing this cover image. In my opinion it should be something simple that suggests a book. Here is an example used by a book provider. It could also simply be a monochromatic rectangle with a border.
5/8 seems like a common book format.

You are right, I was also thinking about changing this cover image. In my opinion it should be something simple that suggests a book. Here is an example used by a book provider. It could also simply be a monochromatic rectangle with a border.
5/8 seems like a common book format.

You are right, I was also thinking about changing this cover image. In my opinion it should be something simple that suggests a book. Here is an example used by a book provider. It could also simply be a monochromatic rectangle with a border (like Google Books).
5/8 seems like a common book format.

Great idea! Go ahead!

You are right, I was also thinking about changing this cover image. In my opinion it should be something simple that suggests a book. Here is an example used by a book provider. It could also simply be a monochromatic rectangle with a border (like Google Books).
5/8 seems like a common book format.

Great idea! Go ahead!

Side by side comparison of the shadow effect (without / with):

On white covers it creates a nice contrast that helps locate the border. On other covers it's not really noticeable, but it makes the borders appear less sharp (obviously).
Same comparison, this time with a solid border:

I tend to prefer the border because it preserves the sharpness.
Now for the placeholder, after a few iterations I came up with the following design:

Thanks to its light color the eye is dragged towards the other covers first. The shapes are vector centred. This feature will have its dedicated PR on invenio-app-ils (because that's where it is defined).
Any comments welcome 🙂

Side by side comparison of the shadow effect (without / with):

On white covers it creates a nice contrast that helps locate the border. On other covers it's not really noticeable, but it makes the borders appear less sharp (obviously).
Same comparison, this time with a solid border:

I tend to prefer the border because it preserves the sharpness.
Now for the placeholder, after a few iterations I came up with the following design:

Thanks to its light color the eye is dragged towards the other covers first. The shapes are vector centred. This feature will have its dedicated PR on invenio-app-ils (because that's where it is defined).
Any comments welcome 🙂


feat：add log in build_domain.py

Checks

[ ] Your YAML file has required fields as listed in Specs
[ ] All checks have passed yaml-lint passed
[ ] You agree to contribute your work under MIT license

Reviewed, exceeding expectation, closing.


🌐 Add French translation for deployment/manually.md

🤗
Here is the PR to translate the manual deployment.
See the french translation tracking issue here.
Thanks for the reviews

Awesome, thank you @rjNemo! :rocket:
And thanks for the reviews @arthurio, @axel584 :bow: :cake:


Anyone used it with material ui?

Can I use http://material-ui.com with this without getting much trouble?

You can, but given that a large part of what reapp offers (outside the build system) is reapp-ui, you'll be missing out. :) Better if you were able to apply material styling to reapp components (as a new theme for example).

Incidentally, I've been working on a project with Material-UI and Meteor, and whilst I'm loving Meteor, Material-UI really made me appreciate just how strong reapp-ui is. The API for Material-UI components is all over the place - inconsistent, and brittle. And good luck trying to animate with even basic transitions, never mind the trying to reproduce the touch friendly animations that reapp provides.
Honestly, the experience has given me a whole new appreciation for reapp.

@thesabbir Yep latest version works just fine. The setup is very simple, I have it running by just adding these two lines to the app.js:
let injectTapEventPlugin = require('react-tap-event-plugin');
injectTapEventPlugin();

@thesabbir One think to keep in mind when using material-ui, is that Reapp uses display:flex globally, which brakes some of the layout of some material-ui components. But luckily you can pass custom style props to MUI components to fix it.

@timuric - which bits of reapp do you use with material & why? Views? Might have to rethink how much of the wheel I'm having to reinvent using Material-UI by itself...

@mbrookes Yep, from Reapp I mostly use views for transitions, and sometimes List component. Material-ui has quite rich selection of elements, and it is handy for both desktop and mobile apps. The tradeoff is of course the overall feel of the application, if you build something exclusively for iOS then Reapp components fit better. At the moment I am experimenting with the two at the same time, however in the future I would probably would use them separately or try to align them into one package :)

@timuric I've gone a slightly different route: I started with Reapp / Flux / PouchDB on the client synced with CouchDB on the server with Rails for the admin / web view, but the Reapp bug that breaks things on orientation change (#24) was a show-stopper, and with Reapp development on hold, couldn't risk that it might never get fixed.
So I switched to Material-UI on the client, and Meteor (GroundDB / Mondo) for client-server and build system.  The biggest challenge has been with nested views (and remembering view state) and transition animations (which is just CSS transitions like TouchstoneJS uses - no realtime interactivity).
Even getting the CSS for a fixed header / footer with scrollable content right took a weekend of head-scratching (CSS is not my speciality!). Stupid simple things that take a ton of time away from actually coding the app. It was that which made me appreciate how much Reapp takes care of for you.
If that bug was fixed, I'd be interested to try a Reapp Material-UI mashup. How have you got around it?

@mbrookes it works but the biggest problem though is that Reapp has display: flex set globally for elements on the page which brakes some material-ui components. One possible workaround is to create a css class like so :
.forceBlock > * {
  display: block;
}

and apply it to broken MUI components. It's quite ugly, but it is an easy workaround. Another concern is that you would end up having two themes in your project. It is definitely usable but not elegant. In any case I think that it would be a good idea to remove global flexbox from Reapp, to avoid conflicts with external libraries.

Hmm - I'm using MUI with flex containers, and I can't say I've had any significant problems, but I might just not be using the components you've had problems with. Anything in particular?
IMHO if there are any issues with flex, it should be up to MUI (or other component library) to fix, rather than devs have to avoid flex - it's a (draft) web standard after all, and supported by all modern browsers.

@mbrookes For example component Checkbox aligns weirdly because it's children use floats  http://d.pr/i/1c95Y
Flexbox is great but I am afraid there are many UI components on the web that are build with box model in order to support IE9 such as elemental, react-boostrap or other existing components. I guess it is not an easy choice which way to go :)

Ah, haven't needed that one. Building components that work in IE9 is fine, so long as they also play nice with flex. :wink:


Remove id from User model

We will use username as the primary key for this class instead since this layer is unnecessary.

Since flask-login requires User table to have column id we decided to remove username instead. All the usernames will be stored in the id column of the User table in our database


Write logs to stdout

Hi there, I was wondering if we can setup the logging environment to write logs to stdout.
After a bit of research it appears that cargo does not capture stderr of tests in the same ways as it captures stdout. I did not find a good answer why this is the case and how to circumvent it, so my idea is to configure the macro to write logs to stdout.
This is super helpful for debugging failed tests e.g. in automated pipelines.
This PR implements said functionality by using an optional feature that allows the user to opt in to write logs to stdout. Furthermore I think the default behavior should be changed to do exactly that, but as far as I think this is an API breaking change and would require a minor release.
Leave me a comment here whether you think these changes make sense; the default behavior should be changed to writing to stdout; we even need a feature flag; and I can update this MR accordingly.

Thanks for the pull request. Your proposal seems reasonable at a conceptual level, because tracing_subscriber seems to be logging to stdout by default (and as such, I think there is an argument to be made to make that default indeed), but I am not really sure I understand the workflow you are trying to paint a picture of or your reasoning specifically.

After a bit of research it appears that cargo does not capture stderr of tests in the same ways as it captures stdout. I did not find a good answer why this is the case and how to circumvent it, so my idea is to configure the macro to write logs to stdout.

Aren't existing logs being captured? And they go to stderr, right? So how is that not working in the same way for both output streams?
You can always use std::io::stderr directly and it will bypass capturing. The same goes for stdout, by the way. If I just add a eprintln the resulting output seems to be captured as any other, no?

I looked into the problem again and just now saw that in fact my setup captures also stderr output. The logs not appearing probably had to do with an incorrect setup of the RUST_LOG variable.
So I do not need that feature at the moment; thank you for taking your time here anyways!


NIFI-10828 Adding new REST API endpoint for exposing versioned flow details

Summary
I exposed the possibility to request for versioned flow details for a given flow. This is something already supported by the registry functionality but was not available on the REST API
NIFI-10828
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[x] JDK 8
[x] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

I might be doing something wrong, but the doc for that endpoint says I should get back

You are perfectly right, thanks for catching! The documentation annotation was incorrect. Fixed.

+1 LGTM, thanks for the new endpoint! Merging to main


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v5.13",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=a64b6a25dd9f984ed05fade603a00e2eae787d2f"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "a64b6a25dd9f984ed05fade603a00e2eae787d2f",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "cfg80211: call cfg80211_leave_ocb when switching away from OCB\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.13 by commit a64b6a25dd9f984ed05fade603a00e2eae787d2f. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001140


[DO NOT MERGE][cluster-test] write suite for reboot and reboot in place

Motivation
testing fullnode reboot
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

:umbrella: The latest upstream changes (presumably d682826966a8cd6cda02160ad07c38cac66ceab6) made this pull request unmergeable. Please resolve the merge conflicts.


dropdown keyboard fixes

BTW does it make sense to open the dropdown but not select the first/last element depending on the arrow key?
I feel like it's an extra key. But that's for later too. :)
Originally posted by @XhmikosR in https://github.com/twbs/bootstrap/pull/32750#issuecomment-770921055

I guess for v5 that's OK to do, for v4 not sure if it's a considered a breaking change. But the current situation does not make a lot of sense to me.

I would be working on this :-)

Thanks! See if you can deduplicate the code to get rid of the linting warning too :)

@XhmikosR I was able to fix the issue, but I couldn't find any alternate solution to remove the linting warning.


Make sure all examples work with test data links

What is the best way to have links in the setup for the mth5_test_data?

@kkappler fixed this by making mth5_test_data an importable module.

@kkappler fixed this by making mth5_test_data an importable module.


User updates to yum symlink are not preserved after tdnf update

The yum symlink is tracked in the tdnf package. So when tdnf package is upgraded, the yum symlink is replaced. This means if a user reconfigured the yum symlink to a different application (i.e., dnf), then a tdnf package update will overwrite the user's symlink

PR merged. Will be available in next monthly release


[WIP] crypto/rand/rand_lib.c: use `clock_gettime' if available [1.2]

This pull request restores the code which was removed from PR #5199, because clock_gettime is not available without adding the -lrt, which is not desirable for the 1.1.1 release. It will be held back until version 1.2.

OPENSSL_rdtsc becoming more wide spread in #5231

Closed in favor of #5231.


Page 9249 "Analysis by Dimensions Matrix".OnAfterSetDimFilters

Please change the parameter DimOption from Option to Enum "Analysis Dimension Option"

We do not have DimOption parameters for this event
local procedure OnAfterSetDimFilters(var TheGLAccBudgetBuffer: Record "G/L Acc. Budget Buffer")

Sorry wrong object, I have changed the title

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


WIP: add metrics

Expose counts for various OLM specific resources, which currently are:
CSVs
InstallPlans
Subscriptions
CatalogSources
And also a count for CSV upgrades.

@ecordell Is OLM and the catalog ever deployed separately? I'm wondering if metrics should be exposed from both containers. Also, see if this is closer to what you had in mind (while I debug CI meanwhile).

If you click the Details link, you can see the pipeline passed (didn't the first time). But I don't know how to update the status on the PR.


EC-Rest plugin

Error running POST Request to Hipchat API:
Curl command is able to post message into chat room

curl --header "content-type: application/json" --header "Authorization: Bearer " -X POST -d '{"message":"The message from build &_"}'
https://api.hipchat.com/v2/room/2352617/message

Here is the link to error in our EC instanse:
https://ec/commander/link/jobDetails/jobs/963def3e-c086-11e5-9deb-005056af66bd?tabGroup=parameterTableHeader&s=Jobs
Here is report in EC console:
Job: EC-Rest_runRest_4_20160121163318
Workspace File	/	createRestRequest.9649d627-c086-11e5-bebc-005056af66bd.log
More
Using plugin EC-Rest version <IP_ADDRESS>293
Loading config HipChatAPITest
Creating Request...

Request:
POST https://api.hipchat.com/v2/room/2352617/message
Authorization: [PROTECTED]
Content-Type: application/json

{"message":"The message from build &_"}
Sending Request to Server...
----------------------------------------------------------------------------------------------------
Response Received.
Checking for errors...
Status: 500 Connect failed: connect: Unknown error; Unknown error
ERROR! The server was unable to fulfil the request.
Please check your parameters.

This is not an EC-Support plugin issue
A ticket has been opened with Electric Cloud support


pre-compiling code

Is there a way to pre-compile code to be run over and over again for performance vs evaluating always at the golang bindings level?
as in:
/v8go.cc: 394
MaybeLocal

Hey @konethmelathil;
You can create a function in the context with either RunScript() or use a FunctionTemplate and you can just call that function again and again without having to complie the whole script.
At the moment there is no way to access the complied script directly (due to the RunScript abstraction); but this could possibly be added in the future as it's along the right lines of the project goals.

What about "cloning" a  preloaded context into a new isolated context ?
Would that work ?
One can use these cloned isolated contexts in goroutines concurrently, right ?

taken from manual:
 An *Isolate can be used as a v8go.ContextOption to create a new Context, rather than creating a new default Isolate.

@konethmelathil If this is still an issue for you, you may be able to use the new functionality from https://github.com/rogchap/v8go/pull/206

Closing since https://github.com/rogchap/v8go/releases/tag/v0.7.0 was released with the changes in #206