Tooltip not being clipped for Position.TOP

         mTimeToolTip
        .on(mStartTime)
        .clickToHide(true)
        .autoHide(false, 1000)
        .corner(30)
        .color(ContextCompat.getColor(mContext, R.color.datecart))
        .position(ViewTooltip.Position.TOP)
        .text("Chose a time for your date, \nwe'll also show you the weather")
        .show();

Oh yes, I forgot this
2017-06-16 8:43 GMT+02:00 Maloclm McFly<EMAIL_ADDRESS>
     mTimeToolTip
    .on(mStartTime)
    .clickToHide(true)
    .autoHide(false, 1000)
    .corner(30)
    .color(ContextCompat.getColor(mContext, R.color.datecart))
    .position(ViewTooltip.Position.TOP)
    .text("Chose a time for your date, \nwe'll also show you the weather")
    .show();

[image: clipping_error]
https://user-images.githubusercontent.com/15109016/27215042-b8f11138-5299-11e7-9e38-29a9aada5d61.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/florent37/ViewTooltip/issues/6, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFfQXNprqSbrk6qFltq2Mh4iXwb5tjiEks5sEiQRgaJpZM4N8FVw
.

It need some time to be refactored, can you try to use .right before I do that ? please

hi,
i have the same issue.
and another question, is it possible to move " img arrow down " to right or left or center of a view and also set margin for that?

can you try on a new version ?
1.0.6 ?

thank you
the alignment problem  is fixed
but the other problem is not fixed yet. i mean the position of "img arrow down".
i have attached 2 images below to clear the problem. the second image is the thing we need to be implemented.

But the text is not center vertically :(, if you see the picture, left and right margins its OK but margin bottom is 0.
https://user-images.githubusercontent.com/15226836/27768297-b86761bc-5f24-11e7-84aa-488111d26f26.png

you can use .padding(int, int) ;)


vkCreateGraphicsPipelines doesn't allow multiple pipelines

see: https://github.com/realitix/vulkan/blob/07285387092aaa61d2d71fa2913d60a73f022cbe/vulkan/_vulkan.py#L5697
this should receive an output array, not an output pointer. compute pipelines too.

Hello @weedgirl69.
Thanks for the report. I'm looking at it

Indeed good catch

I fixed in commit 8fc302d79987ffed92cb2de52f9e892e54c473f5.
I will upload a new version on pypi soon.

The version <IP_ADDRESS> fixes it.


Feature/tools data

I didn't know how to add icons to "Our Tools" section (#11). Is that possible directly in a YAML file?

I've added an icon via the .yml file. Could you please enhance the appearance of it?
I took the GitHub icon from here and is licensed under CC-BY-SA-3.0. So, it requires attribution. Do you have GitHub and ReadTheDocs icons that do not require attribution?

I took the GitHub icon from here and is licensed under CC-BY-SA-3.0. So, it requires attribution. Do you have GitHub and ReadTheDocs icons that do not require attribution?

For GitHub I simply used that one: https://github.com/logos
I can't see any mention of attribution requirements, do you?
About Read the Docs, I can see that attribution is mandatory. So I will have to find another solution...
If it's not possible to find any logo without attribution required, would you be okay with having just text instead?

Could you please
let the icons below each tool appear nicer
Take a look on the alignment of tools (they are all listed vertically)
Check if it still looks good for you after inserting real content

I changed a few things. Please have a look!

I took the GitHub icon from here and is licensed under CC-BY-SA-3.0. So, it requires attribution. Do you have GitHub and ReadTheDocs icons that do not require attribution?

For GitHub I simply used that one: https://github.com/logos
I can't see any mention of attribution requirements, do you?
About Read the Docs, I can see that attribution is mandatory. So I will have to find another solution...
If it's not possible to find any logo without attribution required, would you be okay with having just text instead?

I would like to use an icon too for RTD. I see two options

Use the official  RTD icon and reference to source and license, for example, in imprint (or newly to be created legal page)
Use an icon from the noun project, where the RLI has access, download and use rights without need for backreference (if Matthias downloads it with a special account). For example this icon here

I somehow prefer option 2, because it seems to involve less work. If you agree, I would ask Matthias to download the icon for us.

Could you please
let the icons below each tool appear nicer
Take a look on the alignment of tools (they are all listed vertically)
Check if it still looks good for you after inserting real content

I changed a few things. Please have a look!
Looks cool! I've noticed just one thing: the GitHub+RTD links for eGo appear on top of column 3 instead of at the bottom of column 2

We should add a text above "Our Tools" to separate a bit more. But that's up to us and we can use text formatting from the other paragraphs

I would like to use an icon too for RTD. I see two options
Use the official RTD icon and reference to source and license, for example, in imprint (or newly to be created legal page)
Use an icon from the noun project, where the RLI has access, download and use rights without need for backreference (if Matthias downloads it with a special account). For example this icon here

I also have access to the Noun Project with his account, so option 2 would be no problem.

the GitHub+RTD links for eGo appear on top of column 3 instead of at the bottom of column 2

Good that you saw it. On Chrome there was no bug.

We should add a text above "Our Tools" to separate a bit more.

You mean between the title "Our tools" and the tools below?

We should add a text above "Our Tools" to separate a bit more.
You mean between the title "Our tools" and the tools below?
Right.

We should add a text above "Our Tools" to separate a bit more.

I added dummy text

I'll merge it when #13 is merged


Update C/C++ guide

Just a second please, I'm adding some more :)

Ah, very good suggestions. I also like https://github.com/nlohmann/json, I'll add that as well. I'm currently looking into ZeroMQ, that would go in the same category as TBB, I guess.

Hm, I can't seem to find the hdf5-cpp source, do you have a link?

Hm, I can't seem to find the hdf5-cpp source, do you have a link?

https://support.hdfgroup.org/HDF5/doc/cpplus_RM/index.html

Funny library this Clara, how do we think about syntax abuse? ;)

Syntax abuse: anything that makes lines shorter is a win imho ;)

Thx for the review @jhidding!

Should have asked you for a review as well, apologies.

No worries, I'll try to remember to make a pull request. I'll be writing some C++ again hopefully soon, so I'll have a look at the guide and see what I can use and/or contribute then.


Change debian system

How could you switch to a full deb?
like google-chrome ?

What do you mean?

@eloston
release an universal debian file (for debian, ubuntu, mint)
like google chrome

Perhaps wrapping the static build in a .deb package could solve this.

@9Morello YES


Starting the interactive server resulted in an error

Discussed in https://github.com/alibaba/GraphScope/discussions/3413

Originally posted by pomelo-nwu December  9, 2023
Hi, Graphscope team, first of all, thank you for creating such a great project. I'm using Flex/interactive and encountered some issues while following the documentation at https://graphscope.io/docs/flex/interactive/getting_started:
There was an error when initializing gs_interactive, along with a warning.

It seems that the second step of starting the service also failed.

My environment is:
(py39) ➜  interactive uname -aDarwin U-2Q9KNH7F-2210.local 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:28:45 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6020 arm64
(py39) ➜  interactive python --versionPython 3.9.18
```</div>

There seems to be some problem running Interactive on mac, even in container.

Related seastar issue and PR:
https://github.com/scylladb/seastar/issues/1826
https://github.com/scylladb/seastar/pull/1974

It appears that due to a bug in QEMU, the Seastar that we rely on cannot be used normally on Macs (M1, M2).

This bug is marked wont fix, until QEMU fix it.

It seems that use image built on aarch64 can fix this problem.


Tree shaking

Describe the feature you'd like:
Tree shaking
Details:
If I do this import import { CarouselProvider, Slider, Slide } from 'pure-react-carousel'; webpack adds a lot to my bundle by adding the ImageWithZoom, DotGroup and other modules.
Only things which are actually needed should be inside the bundle. It should be tree shakes as far as webpack is capable of. Is it possible?

any ideas?


There is some PS 1.6 code in the module

/* Before <IP_ADDRESS> displayEnableLink() could not be overridden in Module class
           we declare another row action instead             */
        if (version_compare(_PS_VERSION_, '<IP_ADDRESS>', '<')) {
            unset($fields_list['subscribed']);
            $helper_list->actions = array_merge($helper_list->actions, array('unsubscribe'));
        }

And it's seems that the min version required is the 1.7 to install this one.

Nice catch.
Would you mind making a PR?
Thanks

Hi @maximebiloe ;
Maybe I can do it, yes, ;-)

Hi @maximebiloe
It was done here: #4

Thank you, I just merged it


Add debug mode

Enables more logging
Enables logs from all imported libraries
Runs event loop in "debug mode": https://docs.python.org/3/library/asyncio-eventloop.html#enabling-debug-mode
Python debugging? (remote debugger)

Closing this issue. Can be readded once we have a clearer need for this.


Downloading images from Google Map API at correct coordinates

Greetings Authors,
Thanks for sharing your code. As the README in the repository mentions the output of the candidate_download_locs.txt is in the form of [image_lat] [image_long] [cluster_lat] [cluster_long] and these coordinates generate locations meant to download 1x1 km RGB satellite images of size 400x400 pixels. In context to using Google Map API to download images, I am assuming that [image_lat], [image_long], [cluster_lat] and [cluster_long] were the rectangular coordinates of the Geometry object that were used to download the 400 x 400 image, i.e, top-left corner = {[image_lat], [image_long]} and bottom-left corner = {[cluster_lat], [cluster_long]}. To verify this assumption I used the haversine distance formula but I obtained areas greater that 25km in some cases. Now, I am assuming that you might have taken 1 km x 1km patches around the {[image_lat] , [image_long]} , i.e, considering {[image_lat] , [image_long]} as the center point. Is this what you had done or was some other method used?
Thank you,
Vinit

The cluster lat and long is the center coordinate, and the image lat and
longs are the coordinates for 1x1 patches around that center point. The
script should already generate multiple image lat and longs per cluster lat
and long.
On Sun, May 5, 2019 at 3:18 PM Vinit Singh<EMAIL_ADDRESS>wrote:

Greetings Authors,
Thanks for sharing your code. As the README in the repository mentions the
output of the candidate_download_locs.txt is in the form of [image_lat]
[image_long] [cluster_lat] [cluster_long] and these coordinates generate
locations meant to download 1x1 km RGB satellite images of size 400x400
pixels. In context to using Google Map API to download images, I am
assuming that [image_lat], [image_long], [cluster_lat] and [cluster_long]
were the rectangular coordinates of the Geometry object that were used to
download the 400 x 400 image, i.e, top-left corner = {[image_lat],
[image_long]} and bottom-left corner = {[cluster_lat], [cluster_long]}. To
verify this assumption I used the haversine distance formula but I obtained
areas greater that 25km in some cases. Now, I am assuming that you might
have taken 1 km x 1km patches around the {[image_lat] , [image_long]} ,
i.e, considering {[image_lat] , [image_long]} as the center point. Is this
what you had done or was some other method was used?
Thank you,
Vinit
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nealjean/predicting-poverty/issues/26, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AB4J2STPLI64TBF4SSQG4O3PT5MK3ANCNFSM4HK4JUQA
.

If I recall correctly, images are expected to be retrieved using zoom level = 16 using Google Static Image API, with the centerpoint given by candidate_download_locs.txt (as pointed out by @sangmichaelxie).

@sangmichaelxie @hans-ekbrand Thanks for both your replies. The confusion arose because I assumed the Google Static Image API and Google Earth Engine API worked the same way. I am not very familiar with Google Static Image API but after reading through the documentation and your comments I understand I just need to put in the [image_lat], [image_long] coordinates in their API at zoom level 16.  [cluster_lat], [cluster_long] play no part in the API itself but just aid in creating [image_lat], [image_long].

That's right. You will need cluster lat and long again when aggregating
features to cluster level though.
On Mon, May 6, 2019 at 12:44 PM Vinit Singh<EMAIL_ADDRESS>wrote:

@sangmichaelxie https://github.com/sangmichaelxie @hans-ekbrand
https://github.com/hans-ekbrand Thanks for both your replies. The
confusion arose because I assumed the Google Static Image API and Google
Earth Engine API worked the same way. I am not very familiar with Google
Static Image API but after reading through the documentation and your
comments I understand I just need to put in the [image_lat], [image_long]
coordinates in their API at zoom level 16. [cluster_lat], [cluster_long]
play no part in the API itself but just aid in creating [image_lat],
[image_long].
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nealjean/predicting-poverty/issues/26#issuecomment-489749768,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB4J2SSLI6M2KMAFCAOQRUDPUCDADANCNFSM4HK4JUQA
.


Need to update UUIDv4 regex

"pattern": "^[a-z][a-z-]+[a-z]--[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$"
Need to update above regular expression with below
"pattern": "^[a-z0-9][a-z0-9-]+[a-z0-9]--[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$"
path: cti-stix2-json-schemas/schemas/common/identifier.json

Hi @freecodecamp1, we've already updated it here: https://github.com/oasis-open/cti-stix2-json-schemas/commit/abe6d2bee255321adbfc272f24efbcd204c88eaf#diff-c8872e93048d8ae44e5b0a4effe33681R8. Sorry for the delay getting back to you.


docs(readme): add discord icon to chat badge

Suggested by #1069.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
26 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.07%) to 98.714%

Files with Coverage Reduction
New Missed Lines
%

core/src/executor/aggregate/mod.rs
7
82.99%

test-suite/src/tester/mod.rs
19
87.33%

Totals

Change from base Build<PHONE_NUMBER>:
-0.07%

Covered Lines:
40386

Relevant Lines:
40912

💛  - Coveralls

I like this change. Thanks :)
Before merging this, could we use white color for discord logo rather than blue one?


uwsgi failed to run properly on 10.11.6

brew install uwsgi --with-python
uwsgi --plugin python,http --http :9000 --wsgi-file myapp/wsgi.py
!!! UNABLE to load uWSGI plugin: dlopen(/usr/local/Cellar/uwsgi/2.0.14/libexec/uwsgi/http_plugin.so, 10): Symbol not found: _uwsgi_opt_corerouter
  Referenced from: /usr/local/Cellar/uwsgi/2.0.14/libexec/uwsgi/http_plugin.so
  Expected in: dynamic lookup
 !!!
uwsgi: option `--http' is ambiguous
getopt_long() error

config, doctor and gist-logs https://gist.github.com/achikin/2a2397fe4a251c39802fcfc2a70931e9

@achikin a note for future: please create formulae issues on homebrew/homebrew-core and please either edit or comment on existing issues rather than closing and reopening them. Leave this one as-is for now though, thanks.

→ brew gist-logs uwsgi
Error: Your HOMEBREW_GITHUB_API_TOKEN does not have sufficient scope!
Scopes it has: ["public_repo"]
Create a new personal access token: https://github.com/settings/tokens
and then set the new HOMEBREW_GITHUB_API_TOKEN as the authentication method instead.
Error: {
"message": "Not Found",
"documentation_url": "https://developer.github.com/v3/gists/#create-a-gist"
}

There's no logs here; can you follow the quoted instructions to upload them? Thanks.

@MikeMcQuaid It is not clear from docs what access the token should have. Could you please clarify?


[Improvement] Simply method listSchemas in interface SupportsSchemas

What would you like to be improved?
As any implementation of SupportsSchemas contains catalog entity informations, there is not need to pass name space information to method SupportsSchemas because catalog entity already holds it, so I propose if we can simplify this method signature.
How should we improve?
No response

@yuqi1129,  the  param namespace of listSchemas in interface SupportsSchemas is a sequence of levels separated by dots, what's do you mean there is not need to pass name space information?

@yuqi1129, the param namespace of listSchemas in interface SupportsSchemas is a sequence of levels separated by dots, what's do you mean there is not need to pass name space information?

I mean we do not need to pass the namespace information in the method listSchemas because the implementation has contains this information.
For example, the namespace implementation HiveCatalogOperations contains metalake_name.catalog_name, we also
holds the information needed for listing all the schemas in this catalog.

I'm working on this. Plan to change the method signature to:
  NameIdentifier[] listSchemas() throws NoSuchCatalogException;
Another option is:
  String[] listSchemas() throws NoSuchCatalogException;
What do you think? @yuqi1129

I'm working on this. Plan to change the method signature to:
 NameIdentifier[] listSchemas() throws NoSuchCatalogException;
Another option is:
 String[] listSchemas() throws NoSuchCatalogException;
What do you think? @yuqi1129

Agreed, the former seems to be better.

Close this issue as it has been finished.


Update Code Signing Certificates to use the Intersoft Data Labs certificate instead of a self signed certificate

Technical Debt
Update code signing certs used in the GitHub Action build and local manufacture build to use the Intersoft code signing cert instead of a self signed certificate for all modules Tools and Core.

Currently waiting on hardware token from Sectigo for this.

Got token.  Currently waiting on password.


Bug: derive_vars_merged_lookup / check_type

What happened?
@millerg23
So I recently had an issue where my updated SDTM data had duplicate tests in it, but with different units.  So msec or ms for the same tests.  While I was using derive_vars_merged_lookup I thought I could suppress the check until I got new data, but the check seems to fire off no matter what I do and prevent a merge.  Is this intentional or should I be able to suppress the check and have duplicates in my dataset?
If this is not intentiional, then I can make up a reproducible example  for us to look at.
Session Information
No response
Reproducible Example
No response

Hi Ben,
Could you post the function call, to see exactly what you are trying to merge. I think the functionality comes from the main derive_vars_merged() function. You can use order and mode I think to handle duplicates. The derive_vars_merged_lookup has the added functionality of printing out records where you didn't get a match.

I think this was a user error as I believe I fixed it in my script.  going to close out


feat(choices): support questionary checkbox for multiple choices using multiple: true

This PR is a sequel to https://github.com/copier-org/copier/pull/1049, taking into account review comments and https://github.com/copier-org/copier/issues/750 design proposal.
This PR only include the multiple: true form as the advanced form needs more specification and design I think, and it mostly relies on https://github.com/RhetTbull/questionary-superprompt#multiple-option which is not part of questionary.
However, it remains compatible as it is possible to add the advanced part later.
WDYT ?

I don't get why coverage on tests/test_tools.py changed:

it's a test
not related to the feature
it has not been skipped

BTW, POE coverage commands differ from the CI one.
Why not this in CI ?:
poetry run poe coverage --cov-report=xml

This way it would be the same as locally with poe with only the xml coverage report in addition (the -ra is already in the pyproject.toml tool.pytest.ini_options.addopts setting) and tests would not be included in coverage by tests.

https://github.com/copier-org/copier/pull/1388 should fix the unexpected coverage change


Please make a new release

It's been over a year since the last release. I depend on some newer changes, but AFAICT I cannot make a release on crates.io when having git dependencies.

Yes, that's a good point! Our last release was a little over six months ago, but we agree it's about time we put out a new release. Let me coordinate with my fellow maintainers, but hopefully we should be able to put something out soon!

Thank you


Don't set the user's timezone if it's empty

It seems like there are some cases where the user's local timezone can be empty. In those cases, if the user has "automatic" set for their timezone preferences, we will call the API with the empty timezone. We recently had an employee experience this while using airplane wifi. Coming from the internal issue:

Although, the ideal solution would be to figure out if automatic timezone selection can ever set the selected timezone to empty. I feel like the ideal experience should be no and it should continue to use the previous timezone until a new timezone is obtained. So with an example, if carlos was flying from iceland to new york, while in flight instead of automatic timezone clearing the timezone it should keep it as iceland throughout the flight instead of setting it empty.
So i believe the code change would be here i.e., to if (timezone?.automatic && timezone?.selected !== currentTimezone && currentTimezone !== '') {. I haven't tested nor do i know how to reproduce the issue (i can attempt to reproduce the issue during my flight to savannah 😛). Let me know your thoughts?

Let's try to:

understand what the scenarios are when the currentTimezone would be empty
not call the server to update the timezone in that scenario and instead leave it as-is

cc @rafecolton @chiragsalian
Issue OwnerCurrent Issue Owner: @abdulrahuman5196

Proposal
Please re-state the problem that we are trying to solve in this issue.
Don't set the user's timezone if it's empty
What is the root cause of that problem?
We updateAutomaticTimezone if there is a difference between the local timezone and user preferences and automatic is set without check if the local timezone is not empty
https://github.com/Expensify/App/blob/8b947e3d8d91af218e9d8532c171bd283ecd85f8/src/libs/Navigation/AppNavigator/AuthScreens.tsx#L142
What changes do you think we should make in order to solve the problem?

We need to add a check that currentTimezone is not empty
 if(timezone?.automatic && timezone?.selected !== currentTimezone && !!currentTimezone)

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Do not assign a timezone to the user if it is empty.
What is the root cause of that problem?
Intl.DateTimeFormat().resolvedOptions().timeZone can return empty timezone depending on each platform implementation, it might also specific browser bug e.g. this chrome issue.
What changes do you think we should make in order to solve the problem?
In updateAutomaticTimezone function, early return.
src/libs/actions/PersonalDetails.ts
function updateAutomaticTimezone(timezone: Timezone) {
    if (!currentUserAccountID) {
        return;
    }

    if(isEmpty(timezone) || isEmpty(timezone.selected)) {
        return;
    }

What alternative solutions did you explore? (Optional)
N/A

@abdulrahuman5196 thoughts on the proposals?

Checking now

Contributors, I don't see solid information on the first point in all the proposals.

understand what the scenarios are when the currentTimezone would be empty

Furthermore currentTimezone is not optional value and doesn't have empty options - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/resolvedOptions#timezone.
Could you folks kindly check and update the proposal on
Then why are we getting empty value?
Or is there some other issue?
And @puneetlath Do we have any way to repro this issue normally?

The person who experienced it was on airplane wifi when they experienced it. I don't know a way to reliably reproduce it.

Not overdue, waiting for proposals. Demoting to weekly.

That seems reasonable to me. What do you think @chiragsalian?

Yeah that makes sense to me. Lets do that.

Whose solution do you recommend @abdulrahuman5196?

Checking now

@daledah 's proposal here https://github.com/Expensify/App/issues/47452#issuecomment-2290356632 looks good. Though it was 2nd proposal here, it covered more cases and the core solution is already available as part of the issue OP so there is not much to copy from other proposals.
🎀 👀 🎀
C+ Reviewed

too many engineers assigned, i'll unassign 😅

@chiragsalian you're the CME here, so I'll let you decide whether to go forward with the recommended proposal.

Proposal LGTM, feel free to create the PR @daledah.

@chiragsalian / @puneetlath Seems the automation had failed here. The PR has been in production for more than a week.
The issue should be due for payment.

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Not a consistently reproducible bug, so regression test wont be useful here.

can you expand on this? We have an option to test monthly for edgecase bugs, which we might want to do here.

@mallenexpensify This would be fine. I think the test case would already be in regression test. Anyways added the test steps if required.

Go to Profile > Timezone
Switch to manual timezone
Select another timezone
Switch back to automatic timezone
Verify that: The timezone is updated, no error appears

Thanks for stepping in here @mallenexpensify. I've gone ahead and paid @daledah so we're good to go here. Thanks everyone!


React Native Support?

This is an awesome project! Was wondering if there will be plans to support React Native?

See https://github.com/shuding/react-wrap-balancer/discussions/11, it's limited by the platform API still.


[docs] Make linux installation instructions fail-safe

azk uses the Docker latest version. A lot of users are installing the wrong version for Ubuntu. We have to make clear on documentation what must be done to install the right docker version.

merged at https://github.com/azukiapp/azk/pull/255


Static filesystem registration (modular filesystems)

When using modular filesystems, the filesystem registration in core/platform/default/env.cc (and similar) is no longer valid. We expect filesystems to be loaded from DSOs.
However, we need a filesystem while building the pip package as the genrules for created the api_def files need to write to disk. Furthermore, there are a few tests around API generation that depend on having a filesystem around.
This PR only adds a method to statically register a filesystem if a Bazel target is added as a dependency to a cc_library/cc_binary. We recommend adding this target to cc_binary to prevent registering the same filesystem multiple times (multiple registrations result in error but the program can still continue safely) or potential ODR violations.
Tested in the following ways:

Applying this diff, we can run the modular filesystem tests while loading the filesystem plugin:
diff --git a/tensorflow/core/platform/default/env.cc b/tensorflow/core/platform/default/env.cc
index 5f7822f658..4bf331b607 100644
--- a/tensorflow/core/platform/default/env.cc
+++ b/tensorflow/core/platform/default/env.cc
@@ -212,8 +212,8 @@ class PosixEnv : public Env {
 }  // namespace

 #if defined(PLATFORM_POSIX) || defined(__APPLE__) || defined(__ANDROID__)
-REGISTER_FILE_SYSTEM("", PosixFileSystem);
-REGISTER_FILE_SYSTEM("file", LocalPosixFileSystem);
+//REGISTER_FILE_SYSTEM("", PosixFileSystem);
+//REGISTER_FILE_SYSTEM("file", LocalPosixFileSystem);
 Env* Env::Default() {
   static Env* default_env = new PosixEnv;
   return default_env;

where the test is done via
(tf) [tensorflow] λ bazel build //tensorflow/c/experimental/filesystem/plugins/posix:libposix_filesystem.so
...
(tf) [tensorflow] λ bazel build //tensorflow/c/experimental/filesystem:modular_filesystem_test
...
(tf) [tensorflow] λ bazel-bin/tensorflow/c/experimental/filesystem/modular_filesystem_test --scheme=file --dso=bazel-bin/tensorflow/c/experimental/filesystem/plugins/posix/libposix_filesystem.so
...
[----------] 104 tests from ModularFileSystem/ModularFileSystemTest (32 ms total)

[----------] Global test environment tear-down
[==========] 104 tests from 1 test suite ran. (32 ms total)
[  PASSED  ] 104 tests.

Without the above diff or with it, bazel test //tensorflow/cc:cc_op_gen_test fails with  Non-OK-status: env->NewWritableFile(dot_h_fname, &h) status: Unimplemented: File system scheme '[local]' not implemented. However, with this additional diff (to do static registration) the test passes
diff --git a/tensorflow/cc/BUILD b/tensorflow/cc/BUILD
index 5251ccdf1c..13b60f62fa 100644
--- a/tensorflow/cc/BUILD
+++ b/tensorflow/cc/BUILD
@@ -672,6 +672,7 @@ tf_cc_test(
         "framework/cc_op_gen_test.cc",
     ],
     deps = [
+        "//tensorflow/c/experimental/filesystem/plugins/posix:posix_filesystem_static",
         "//tensorflow/core:framework",
         "//tensorflow/core:lib",
         "//tensorflow/core:lib_internal",

(tf) [tensorflow] λ bazel test //tensorflow/cc:cc_op_gen_test
...
INFO: Build completed successfully, 9 total actions
//tensorflow/cc:cc_op_gen_test                                           PASSED in 0.0s

Executed 1 out of 1 test: 1 test passes.
INFO: Build completed successfully, 9 total actions

Adding the same static target to the cc_op_gen_main and to the xla_ops targets allows us to build the pip package successfully
diff --git a/tensorflow/cc/BUILD b/tensorflow/cc/BUILD
index 5251ccdf1c..7a7f7865d1 100644
--- a/tensorflow/cc/BUILD
+++ b/tensorflow/cc/BUILD
@@ -655,6 +655,7 @@ cc_library(
         "//tensorflow/core/api_def:base_api_def",
     ],
     deps = [
+        "//tensorflow/c/experimental/filesystem/plugins/posix:posix_filesystem_static",
         "//tensorflow/core:framework_headers_lib",
         "//tensorflow/core:lib",
         "//tensorflow/core:lib_internal",
diff --git a/tensorflow/compiler/tf2xla/ops/BUILD b/tensorflow/compiler/tf2xla/ops/BUILD
index b116a09dd0..16c43ead2d 100644
--- a/tensorflow/compiler/tf2xla/ops/BUILD
+++ b/tensorflow/compiler/tf2xla/ops/BUILD
@@ -13,6 +13,7 @@ cc_library(
     name = "xla_ops",
     srcs = ["xla_ops.cc"],
     deps = [
+        "//tensorflow/c/experimental/filesystem/plugins/posix:posix_filesystem_static",
         "//tensorflow/compiler/xla:xla_data_proto_cc",
         "//tensorflow/core:framework",
         "//tensorflow/core:lib",

(tf) [tensorflow] λ bazel build  //tensorflow/tools/pip_package:build_pip_package
...
Target //tensorflow/tools/pip_package:build_pip_package up-to-date:
  bazel-bin/tensorflow/tools/pip_package/build_pip_package
INFO: Elapsed time: 3904.842s, Critical Path: 539.10s
INFO: 1478 processes: 1478 local.
INFO: Build completed successfully, 1494 total actions

Note: the diffs mentioned in the testins section will need to be applied when all filesystems are converted to modular world, as the switch commit/PR. We cannot effectively apply them before unless we want to accept some divergence (some filesystem modular, some still static as in the old world).
See tensorflow/community#101 for the general modular filesystems design RFC.

I'm uploading this manually, was a proof of concept for GitHub contributions


refactor: Split components into different files (part 1)

Split components into individual files so index.js will be less messy
Add props to modify Flatlist style
Add missing proptypes for EmojiSelector

part 1

closing, included in part 2


Google Books API

🎯 Google Books API #185
Closes #185
🗒 Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x]  I have gone through rules of when PR will get merged.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have followed proper file structure.
[x] I have gone through CONTRIBUTING GUIDELINES.md.

Thank you for contributing!❤
Don't forget to show some love by ⭐ the repository!

Hey @MohanRamSridhar, Thank you for creating PR! We will review it super soon. 😇❣
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣

@MohanRamSridhar Nice use case☺!

@MohanRamSridhar We're thrilled to inform you that your pull request has been successfully merged into the APIverse🚀🎁
Your hard work, dedication, and expertise have made a significant impact on our project, and we couldn't be more grateful for your contributions.😇
Your code will now be a part of our growing ecosystem, helping developers worldwide to create exceptional APIs.❣🔥
Happy Coding! ✨
Will See you soon❣


In-App enable in produce

Hi,
Sorry, this is more of a question that I could not find an answer to it then an issue.
We've automated the complete app creation here in our company, but one thing that we want to do that I'm not sure how is to enable In-App purchase during produce enable_services. Note that I don't want to upload in-app purchase data to itunes, I just want to enable the service when creating the App Id in developer portal.
Is there a way to enable in-app using produce?
Thanks!

Unfortunately, I don't believe you can do it, see https://github.com/fastlane/fastlane/tree/master/produce#parameters

cc @vpolouchkine
Related to #5100

For reference, PR #6820 that allows produce to enable/disable In-App Purchase service has been merged.

@sogko Thanks!


Glossary entry for limitrange

Closing https://github.com/kubernetes/website/pull/13830 and refactoring in small PR for each subject.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Please delete this note before submitting the pull request.
For 1.15 Features: set Milestone to 1.15 and Base Branch to dev-1.15
For Chinese localization, base branch to release-1.12
For Korean Localization: set Base Branch to dev-1.14-ko.<latest team milestone>
Help editing and submitting pull requests:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.
Help choosing which branch to use:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

/assign

Great job. Very crisp definition and preview looks great.
/lgtm
/approve


NTR:  histone H3K4 trimethyltransferase activity

Please provide as much information as you can:

Suggested term label:

histone H3K4 trimethyltransferase activity

Definition (free text)
Catalysis of the reaction: L-lysyl4-[histone H3] + 3 S-adenosyl-L-methionine = 2 H+ + N6,N6-trimethyl-L-lysyl4-[histone H3] + 3 S-adenosyl-L-homocysteine. This reaction is the successive addition of three methyl groups to the unmethylated lysine residue at position 4 of histone H3, producing histone ~H3K4me2~. H3K4me3

Reference, in format PMID:#######
18375658

Gene product name and ID to be annotated to this term
Q9C5X4 ATX1 (plant)

Parent term(s)
GO:0042800

+[Term]
+id: GO:0140999
+name: histone H3K4 trimethyltransferase activity
+namespace: molecular_function
+def: "Catalysis of the reaction: L-lysyl4-[histone H3] + 3 S-adenosyl-L-methionine = 2 H+ + N6,N6-trimethyl-L-lysyl4-[histone H3] + 3 S-adenosyl-L-homocysteine. This reaction is the successive addition of three methyl groups to the unmethylated lysine residue at position 4 of histone H3, producing histone H3K4me3." [PMID:18375658, RHEA:60260]
+synonym: "histone H3-K4 trimethylation" BROAD []
+synonym: "histone H3K4 trimethylase activity" EXACT []
+synonym: "histone H3K4 trimethylation" BROAD []
+synonym: "histone lysine N-trimethyltransferase activity (H3-K4 specific)" EXACT []
+xref: EC:<IP_ADDRESS>4
+xref: RHEA:60260
+is_a: GO:0042800 ! histone H3K4 methyltransferase activity
+property_value: term_tracker_item https://github.com/geneontology/go-ontology/issues/22588 xsd:anyURI
+created_by: pg
+creation_date: 2023-02-28T12:52:48Z

Moved cross references
EC:<IP_ADDRESS>4 and  RHEA:60260 from parent term GO:0042800 histone H3K4 methyltransferase activity, which is the grouping term for the mono, di and trimethyl transferase. We didn't have a term for the trimethyl transferase.


NPE thrown when trying to use SQL IN operator

Description:
I have an SQL query that's using the IN operator. I'm getting the input for the in operator via an array. I tried creating a string and use that in a parameterized query like SELECT ... IN (${arrStr})
This throws the below error,
class io.ballerina.runtime.internal.types.BMapType cannot be cast to class io.ballerina.runtime.api.types.RecordType (io.ballerina.runtime.internal.types.BMapType and io.ballerina.runtime.api.types.RecordType are in unnamed module of loader \'app\')

Then I tried directly using the array like SELECT ... IN ${arr} and this throws an NPE,
Error while executing SQL query: select ... in ( ? ). java.lang.NullPointerException

I had to look at the test cases to figure out the correct form SQL statement that use arrayFlattenQuery. It would be helpful if the error message can be improved to point to the right direction
Affected Versions:
Ballerina 2201.3.2 (Swan Lake Update 3)
Language specification 2022R4
Update Tool 1.3.12

I have an SQL query that's using the IN operator. I'm getting the input for the in operator via an array. I tried creating a string and use that in a parameterized query like SELECT ... IN (${arrStr})

@wx-yz Could you give more information regarding the code you used? Is it similar to the following?
string[] arrStr = [];
sql:ParameterizedQuery query = `SELECT ... IN (${arrStr})`;

This seems to be a combination of 2 bugs,

https://github.com/ballerina-platform/ballerina-standard-library/issues/4200
https://github.com/ballerina-platform/ballerina-standard-library/issues/4201

We will be fixing this for Update 5.

Both fixes are merged and will be released in Update 5.
Thank you for reporting the issue.


Make deviceName propagate through and be usable

Currently only deviceDescription comes through, would be good to get deviceName to come through too.

@chackett I've updated the thrift file, the generated go thrift code, the generated python code, the broadcast code the serviceMessage data type, the WWserviceMessage data type, and the conversion funiongs, it's still not coming through, what am I missing. Any guidance would be appreciated.

So can start using deviceName along with deviceDescription, whoop !


Update unicode-compression-implementation.md

This topic needs to explain the use of Unicode compression in Columnstore objects.  It appears that Unicode compression (or something similar) is in effect for ColumStores.  eg
use tempdb
go
drop table if exists uctest
create table uctest(
id int ,
a varchar(100) default left(replicate(cast(newid() as varchar(100)),10),100),
b nvarchar(100) default left(replicate(cast(newid() as varchar(100)),10),100),
c Nvarchar(max) default left(replicate(cast(newid() as varchar(100)),10),100),
index cci_uctest clustered columnstore
)
go
with q as (
select top 1000000 row_number() over (order by (select null)) rn
from sys.objects o, sys.columns c, sys.columns c2
)
insert into uctest(id)
select rn from q
option (maxdop 1)
alter table uctest rebuild
select column_id,  sum(row_count) rows, sum(on_disk_size) dixe,
sum(row_count)/(sum(on_disk_size)/1024) rows_per_kb
from sys.column_store_segments cs
join sys.partitions p
on cs.partition_id = p.partition_id
where p.object_id = object_id('uctest')
group by column_id

@davidbaxterbrowne : Thanks for your contribution to the SQL documentation! The author, @BYHAM, has been notified to review your proposed change.

@MightyPen can you please review.

@jovanpop-msft @jodebrui Jos has asked Jovan to assess this Columnstore documentation change.
Jovan, please keep me (MightyPen = GeneMi) in the loop.  I can process the outcome of your assessment.


Suggesting custom font setting

Hi. First of all his is truly an excellent work, very helpful for me. Nice job. I've also pledged a little on patreon for my gratitude.
So here's the reason why I make this suggestion:
I'm currently using this tool to create materials of my game for my players to read. But since most of my players are not so good in reading English I made the content in Chinese. However the default font used by Homebrewery does not support Asian characters, making it using default font for Chinese which is very plain and unflavored. For now, I could change the fonts manually before printing by editing CSS in browser, but it is  inconvenient and sometimes mess up the layout since some fonts have slightly different sizes and I'll have to go back and readjusting layout.
And here's my suggestion:
Maybe there could be a button or something to open a font-setting panel, enabling the user to use custom fonts to replace the original ones, overriding the CSS.
Thanks for taking your time. Hope it get even better.

Thanks for the suggestion shadowevor. You can already easily add custom fonts to any brew. The Homebrewery allows you to embed custom CSS at the top of your brew and it will be included and used for rendering and printing. Find a flavourful font that supports the characters you need and include. You will probably have to tweak other things to make it look perfect, but I'm sure you can handle that.
As for creating a UI for uploading and using new fonts, I'm trying to avoid adding anymore UI or interaction as I can. I like to keep my products and simple and straight-to-the-point as possible. For example, I don't need to created an image uploader, parsing, and handler, because someone can use a service that is way better at that and just link it on here.
Let me know how your work goes, and if you find a good solution maybe we could include it as a snippet others could use :)

I hadn't noticed I could use embedded custom CSS. It's works perfectly well
for me, thanks for the help!
2016-09-07 21:27 GMT+08:00 Scott Tolksdorf<EMAIL_ADDRESS>
Thanks for the suggestion shadowevor. You can already easily add custom
fonts to any brew. The Homebrewery allows you to embed custom CSS at the
top of your brew and it will be included and used for rendering and
printing. Find a flavourful font that supports the characters you need and
include. You will probably have to tweak other things to make it look
perfect, but I'm sure you can handle that.
As for creating a UI for uploading and using new fonts, I'm trying to
avoid adding anymore UI or interaction as I can. I like to keep my products
and simple and straight-to-the-point as possible. For example, I don't need
to created an image uploader, parsing, and handler, because someone can use
a service that is way better at that and just link it on here.
Let me know how your work goes, and if you find a good solution maybe we
could include it as a snippet others could use :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stolksdorf/homebrewery/issues/188#issuecomment-245279831,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHHfXP6Josor7KR2IjSQOFRypOb8q7-Rks5qnru8gaJpZM4J1um3
.


fix: add Multilingual Hate Speech detection task

Checklist for adding MMTEB dataset

closes #395

[x] I have tested that the dataset runs with the mteb package.
[x] I have run the following models on the task (adding the results to the pr). These can be run using the mteb run -m {model_name} -t {task_name} command.

[x] sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
[x] intfloat/multilingual-e5-small

[x] I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
[x] I have considered the size of the dataset and reduced it if it is too big (2048 examples is typically large enough for most tasks)
[x] Run tests locally to make sure nothing is broken using make test.
[x] Run the formatter to format the code using make lint.
[x] I have added points for my submission to the POINTS.md file.

First stab at this, would love to have input on the following:

The dataset includes 10 languages. First release as part of a 2021 ACL paper, was a monolingual English dataset. Then the remaining 9 languages were released, expanding the original dataset. There is a separate paper for these additional datasets. Considering using the latter for reference and bibtex_citation, any input on this? Hope we are good license-wise if we do that?
All datasets are released separately on HF. I am passing a dictionary with language-specific revision tags for each dataset to revision. Feels a bit weird though, any better suggestion?
The name of the dataset passed to metadata is technically the name of one of the datasets, is that an issue?
n_samples and avg_character_length are computed across all languages. n_samples is 18250 in total. This seems high, but we are benchmarking separately on each monolingual dataset -- so size should be okay? Or do I need to downsample?

The dataset includes 10 languages. First release as part of a 2021 ACL paper, was a monolingual English dataset. Then the remaining 9 languages were released, expanding the original dataset. There is a separate 2022 workshop paper for these additional datasets. I am using the latter for reference and bibtex_citation, but any input on this?

Let use use both.

All datasets are released separately on HF. I am passing a dictionary with language-specific revision tags for each dataset to revision. Feels a bit weird though, any better suggestion?
The name of the dataset passed to metadata is technically the name of one of the datasets, is that an issue?

Given the license I would rehost it. Feel free to host it on the mteb, hf group (you can request to join and I will add you)

thanks @KennethEnevoldsen.
double-checking real quick:

making this a single dataset on HF, hosted on mteb -- not multiple dataset, correct?
when you say crediting both papers, how would i do that? reference and bibtex_citation metadata fields can only take strings -- i could of course reference those in the README of the new dataset, but we're still left with what these two metadata fields should look like in the new Task.

making this a single dataset on HF, hosted on mteb -- not multiple dataset, correct?

Yep!

when you say crediting both papers, how would i do that? reference and bibtex_citation metadata fields can only take strings -- i could of course reference those in the README of the new dataset, but we're still left with what these two metadata fields should look like in the new Task.

Let reference be the newest, but the BibTeX citation can be just two BibTeX citations.

awesome thanks! i'll most probably have to focus on other stuff rest of today, but hoping to wrap this up latest early next week.

@KennethEnevoldsen I have implemented requested changes, new dataset hosted here: https://huggingface.co/datasets/mteb/multi-hatecheck
I have kept all data from the original dataset in the HF dataset, as well as additional interesting columns one could focus on in the future (type of hate speech). I do subsampling and splitting here, easier to deal with if we want to later increase the number of samples.
Not sure how what the point system for this should be, is this 1 or 9 datasets? Also feels like repeated review should grant more than 2x points for you?
Also sorry for the Friday night PR, had to kill an hour of wait ;) Obviously not expecting review til next week.

@KennethEnevoldsen should be ready to merge

Ahh @rbroc sorry missed the question related to points:
You should get 2 points for the dataset and 4 bonus points pr. language that does not have a classification task.

no worries at all! it seems like all languages are covered in multilingual datasets, so the 2 I added is correct. :)


Kartaview partially fixed

Description
When enabling Kartaview, it used to report a bad 400 report instead of loading the frame. Now it loads the frame but as a still instead of a 360 photo.
Screenshots

Version
2.4.0-pre.0
What browser are you seeing the problem on? What version are you running?
Firefox v130.0
The OS you're using
mac
Steps to reproduce

Load

Try to pan 360 photo.

The browser URL at the time you encountered the bug
https://rapideditor.org/canary#map=19.00/41.91031/12.50307&background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&photo=kartaview/1391643985&photo_overlay=kartaview&poweruser=true
The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:130.0) Gecko/20100101 Firefox/130.0

Yes, switching the viewer code so it can pan around in 360° is #1510


Add user-defined compliance messages

Policy authors can now define go templates to be used for compliance messages, with .DefaultMessage and .Policy fields available for getting useful information. If an error occurs with the template, those details will be appended to the default message. See the CRD description for more details.
This also updates the default compliance message function to use a template, which provides an example of what is possible. The new tests also provide examples.
Refs:

https://issues.redhat.com/browse/ACM-12423

One thing potentially missing here is access to sprig functions like the other template fields provide. It might be helpful to export some of the information in https://github.com/stolostron/go-template-utils/blob/main/pkg/templates/sprig_wrapper.go for usage here.

One thing potentially missing here is access to sprig functions like the other template fields provide. It might be helpful to export some of the information in https://github.com/stolostron/go-template-utils/blob/main/pkg/templates/sprig_wrapper.go for usage here.

I don't think it's necessary but it'd be nice to have the same sprig template functions.

  KinD tests (latest) Flake?
  [FAIL] Test Object deletion Test status fields being set for object deletion [It] should update status fields properly for created objects
  /home/runner/work/config-policy-controller/config-policy-controller/test/e2e/case20_delete_objects_test.go:65

• [FAILED] [62.343 seconds]
Test Object deletion Test status fields being set for object deletion [It] should update status fields properly for created objects
/home/runner/work/config-policy-controller/config-policy-controller/test/e2e/case20_delete_objects_test.go:46

  Timeline >>
  STEP: Creating policy-pod-create-c20 on managed @ 07/31/24 20:34:29.462
  [FAILED] in [It] - /home/runner/work/config-policy-controller/config-policy-controller/test/e2e/case20_delete_objects_test.go:65 @ 07/31/24 20:35:30.822
  << Timeline

  [FAILED] Timed out after 60.001s.
  Expected
      <bool>: false
  to equal
      <bool>: true
  In [It] at: /home/runner/work/config-policy-controller/config-policy-controller/test/e2e/case20_delete_objects_test.go:65 @ 07/31/24 20:35:30.822

/lgtm /hold I like it! test cases are very detailed Thanks, Justin! I added hold for others

  KinD tests (minimum) Another (different) flake?
  [FAIL] Test results of namespace selection Checking results of different namespaceSelectors [It] No namespaceSelector specified
  /home/runner/work/config-policy-controller/config-policy-controller/test/e2e/case19_ns_selector_test.go:61

• [FAILED] [67.971 seconds]
Test results of namespace selection Checking results of different namespaceSelectors [It] No namespaceSelector specified
/home/runner/work/config-policy-controller/config-policy-controller/test/e2e/case19_ns_selector_test.go:63

  Timeline >>
  STEP: Applying prerequisites @ 08/01/24 17:23:57.141
  STEP: patching policy with the test selector @ 08/01/24 17:23:59.332
  [FAILED] in [It] - /home/runner/work/config-policy-controller/config-policy-controller/test/e2e/case19_ns_selector_test.go:61 @ 08/01/24 17:24:59.543
  << Timeline

  [FAILED] Timed out after 60.001s.
  Expected
      <string>: configmaps [configmap-selector-e2e] not found in namespaces: case19a-2-e2e, case19a-3-e2e, case19a-4-e2e, case19a-5-e2e, case19b-1-e2e, case19b-2-e2e, case19b-3-e2e, case19b-4-e2e, case9-test, default, innovafertanimvsmvtatasdicereformascorporinnovafertanimvsmvt10, innovafertanimvsmvtatasdicereformascorporinnovafertanimvsmvt11, innovafertanimvsmvtatasdicereformascorporinnovafertanimvsmvt12, innovafertanimvsmvtatasdicereformascorporinnovafertanimvsmvt13, innovafertanimvsmvtatasdicereformascorporinnovafertanimvsmvt14, innovafertanimvsmvtatasdicereformascorporinnovafertanimvsmvt15, kube-case19b-e2e, kube-node-lease, kube-public, kube-system, local-path-storage, managed, olm, open-cluster-management-agent-addon, operator-policy-testns, operators, range1, range2
  to equal
      <string>: namespaced object configmap-selector-e2e of kind ConfigMap has no namespace specified from the policy namespaceSelector nor the object metadata
  In [It] at: /home/runner/work/config-policy-controller/config-policy-controller/test/e2e/case19_ns_selector_test.go:61 @ 08/01/24 17:24:59.543

@mprahl @dhaiducek any more comments for this PR?


Newbranch validate 1.9

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@68429a8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   79.74%
=========================================
  Files             ?        6
  Lines             ?      622
  Branches          ?        0
=========================================
  Hits              ?      496
  Misses            ?       77
  Partials          ?       49

Flag
Coverage Δ

#cli
79.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

General comment: put description in PR for reviewer to better understand context, and what is added/changed in it. Provide example input/output can be helpful as well


Add ability to suppress errors.

I've thought about it for a while now. At first I thought that this would be very hard, as you would need to track exact line where the error should be suppressed across changes in the buffer and file, but I think that there is a nice heuristic you can use to make this much simpler.
How about for every suppressed error the error string and some context in the file. Something like that.
[
  {
    "path": "/some/path/to/file",
    "error": "E331 Missing docstring",
    "context": [
      "def some_name(bla, bla, bla):",
      "    pass"
    ]
  }
]

In fact I thought about saving more than one line for cases, when linter (I use python and pylint) reports syntax error when the error is actually on a previous line (like a forgotten : of , or ; in the other languages), but you probably shouldn't suppress syntax error in the first place. So one line would be enough for most cases.

Two easier options are fixing the warnings/errors, and configuring the linters themselves.

@w0rp Yeah totally, except sometimes you can't do that. Take for example pylint when used on pytest tests
@pytest.fixture
def some():
    return 'some'

def test_some(some):
    assert some == 'some'

pylint would complain that redefining  some from outer scope which I am clearly not. And I don't want to disable all such warnings, which are helpful most of the times.
Only option I have is quite stupid: add comment that indicates to pylint that this particular error should be ignored here. For me and many other people it's just not an option. I refuse to pollute codebase with stuff like that, just because my linter isn't good enough.

Where would your file live? In the project or a global directory somewhere? For the sake of collaboration, the comment option is something that's accepted across multiple languages (pylint, eslint) and, more importantly, works across different editors.

@delianides Where would I store ignore info? I'd prefer a global directory, because I don't like polluting the code folder with anything, but aside from that storing it in the hidden directory in inside a project root have benefits too.
For the sake of collaboration it would have been better to use approach like one that I'm suggesting with hidden file in project root. The more code I can see on the screen the better. When I look at the code I don't want to see linter related comments.

I've seen people writing docs like that
def copy_file(): """ Copies a file """


Generative Maze

Author name
Zeyu (Peter) Yao
About your game
This is a maze that generates new, increasingly complex mazes each time you reach the exit, and you control a player character navigating through the maze to find the exit before time runs out.
Each level increases in difficulty, and you have 30 seconds to complete each maze.
Press WASD to move.
Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[x] The image is in the /games/img directory.
[x] The name of the image matches the name of your file.

This is cool! Nice job with this. You'll see it in the gallery soon.
If you're a teenager, you can request a free Sprig console at this link and join our online Slack community to chat with other people making Sprig games.


fix gtest linkage weirdness

Previously, in #7966, there is an attempt to fix gtest crt linkage. It just don't work actually, it 'fixed' it simply by accident.

In those chainerx_cc/third_party/*.cmake files, the configure stage is disabled since the configure command is set to an empty string.
according to add_subdirectory doc

The CMakeLists.txt file in the specified source directory will be processed immediately by CMake before processing in the current input file continues beyond this command.

the ${CMAKE_CURRENT_BINARY_DIR}/googletest-src is added first and then followed with a set(gtest_force_shared_crt ON CACHE BOOL "" FORCE). So, on the first pass of configure-build (trigged by setup.py), crt error, on the second pass, it disappear. Which makes it seems like adding flags to chainerx_cc/third_party/*.cmake files have addressed the problem, but it is not.

Jenkins, test this please.

Jenkins CI test (for commit 10a6ba76b1a29e2001721c0ed791448f3e98233d, target branch master) succeeded!

LGTM! Jenkins, test this please.

Jenkins CI test (for commit 10a6ba76b1a29e2001721c0ed791448f3e98233d, target branch master) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit 10a6ba76b1a29e2001721c0ed791448f3e98233d, target branch master) succeeded!


i can not do make on caffe2_cpp_tutorial

first i mkdir build in folder of caffe2_cpp_tutorial/
and cd build anddo cmake ..
finally i got error message ,
../caffe2: warning: directory does not exist.
CMake Error at CMakeLists.txt:36 (message):
Caffe2 lib not found

You don't seem to have Caffe2 installed?
What is the output of sudo ldconfig -p | grep "libcaffe2*"

Hello, I'm running into this issue as well. Do you recommend building caffe2 from source?
I followed the installation directions given here: https://caffe2.ai/docs/getting-started.html?platform=ubuntu&configuration=compile
and I successfully tested my installation, but I am having building this project.
sudo ldconfig -p | grep "libcaffe2*" is also returning nothing

Hello, I'm running into this issue as well. Do you recommend building caffe2 from source?
I followed the installation directions given here: https://caffe2.ai/docs/getting-started.html?platform=ubuntu&configuration=compile
and I successfully tested my installation, but I am having building this project.
sudo ldconfig -p | grep "libcaffe2*" is also returning nothing

Nevermind, had to move libcaffe2.so

Same issue here. I am wondering do I need to install by build from source again? because my caffe2 was directly installed by
conda install pytroch

I find my libcaffe2.so is located in /usr/local/lib/python2.7/dist-packages/torch/lib. What should we do to make your project successfully?

Is there still anyone maintaining this project?

Hi @Mengjintao I don't know, but for our own purposes we did rewrite the C++ part for training and inference of Caffe2 models, including multiple flavors of Detectron, as well as new operators, see https://github.com/jolibrain/deepdetect/tree/master/src/backends/caffe2
It may not fit your purpose as it is not designed to be used outside of deepdetect, though you may build around the main code functionalities typically, and the nettools here: https://github.com/jolibrain/deepdetect/tree/master/src/backends/caffe2/nettools

Caffe2's Python API works fine, but the C++ API definitely not.
MACE's benchmark did not include Caffe2 into their benchmark, I guess they may failed to do so.

Caffe2's Python API works fine, but the C++ API definitely not.
MACE's benchmark did not include Caffe2 into their benchmark, I guess they may failed to do so.

Actually I am using the Caffe2 C++ API. The by far biggest problem for me is lack of documentation and example codes to get a better understanding of the API. For example, I am trying to implement a basic MNIST network with one hidden layer and have a hard time figuring out how to initialize a tensor as a vector with constant float values. Ones, zeros and random values are easy but a set of own values?

All you need is to fix CMakeLists.txt find_library entries (CAFFE2_LIB and maybe others) so that it is possible to find the available Caffe2 libraries like libCaffe2_CPU.so or libCaffe2_GPU.so. Read the find_library documentation here for how.  If you are not sure where is your Caffe2 installation, use tools like find to locate them. If you really cannot locate, most likely, Caffe2 is not present on your machine or maybe has not been built properly.

I get in the same trouble, even though I have already installed caffe2 successfully. I can find libCaffe2_CPU.so under caffe2/cmake-build-debug/caffe2, but when I type "sudo ldconfig | grep "libcaffe2*" ", it returns nothing. I added " message("${CAFFE2_LIB}") ", it also returns nothing, but glogs_lib can be found. I really want to know how to find the library "libCaffe2_CPU.so", what should I do?


[WIP] Convert switchview target to Android X

Summary:
Codemod by intellij_convert_to_ax.py affecting 1 targets:
fbsource//xplat/js/react-native-github/ReactAndroid/src/main/java/com/facebook/react/views/switchview:switchviewAndroid
Differential Revision: D14151899

This is going to be replaced by another PR


  This is a problem because the behavior has been
consolidated around the behavior of the production scripting container which is
to filter out variables like FOO_DEBUG.  This patch addresses the problem by
changing the test to assert the desired behavior.

:+1:

:+1:


Broken links in README.md

c'mon

Hello!
I'm terribly sorry, but this repository should have been archived years ago. The repo you are looking for is https://github.com/transumption/config_macro -- but I am unsure of how actively maintained that is either.
I'm sorry for the confusion, but thank you for reminding me to archive this repository.


Fix player color assignment

Currently, it is possible for 2 players to be the same color when they join a game. Move color assignment logic to server side.

87119cd


Problem with downloading pre-trained models

Description:
Hello everyone. I tried to launch REST server as in following tutorial: Link. However, in process of starting server some pre-trained models were downloaded, and seems like some model files contain only error. Starting server crashes with KeyError on trying to unpickle model_info.dat in ner_api.py. Contents of model_info.dat after download:
<Error>NoSuchKey<Message>The specified key does not exist.</Message><Key>NLP/NER/model_info.dat</Key><RequestId>7113734D2CFD0F64</RequestId><HostId>L8Szl6PSef3HNZ7nKMF20Ji2xjDfSpxPiAo6CnlBvrOJyffPYxHtMJTf+GWAwuw+mOlLO+vH6uw=</HostId></Error>
Steps to reproduce:

[x] Clone nlp-architect
[x] Make environment (make in root)
[x] Launch server (hug -p 8080 -f server/serve.py)

Hi @Plazmius, thanks for reporting this error.
We've fixed the model files and the above should work.


[image_picker] Migrate Image_picker_platform interface to Null Safety

Migrate Image_picker_platform interface to Null Safety
Related to #75162
All existing tests are passing
Pre-launch Checklist

[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
[x] I updated CHANGELOG.md to add a description of the change.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I signed the [CLA].
[x] All existing and new tests are passing.

test-exempt: refactoring with no logical change

@stuartmorgan  Any hints on the failing checks? is it the CI config?

@Sameerkash Thank you for the PR! This is being done in https://github.com/flutter/plugins/pull/3492 and we are almost landing the PR. I'm going to close this one :)

@Sameerkash If you'd like to work on the migration for the image_picker plugin after #3492, I'll be super happy to review it! :)

@Sameerkash Apologies for the duplicated work here; I tried to capture in-progress work when filing all of the bugs, but missed #3492 when filing that issue.

@Sameerkash If you'd like to work on the migration for the image_picker plugin after #3492, I'll be super happy to review it! :)

Yes. I would like to @cyanglaz
I'll start asap. Should be up in a day.

@Sameerkash Apologies for the duplicated work here; I tried to capture in-progress work when filing all of the bugs, but missed #3492 when filing that issue.

It's okay!

Yes. I would like to @cyanglaz
I'll start asap. Should be up in a day.

Please tag me on the PR! I'll be happy to review it!


Issue deserializing Node<> types with bolt client

We are having an issue migrating from the Http client to the Bolt client.
After swapping GraphClient out with BoltGraphClient a lot of our queries start running into a deserialization issue.
Versions:

Neo4jClient <IP_ADDRESS>
BoltGraphClient
.NET Version 4.6.2
Server Version 4 (Aura)

To Reproduce
var matchText = $"(rsn:{repositoryStartNodeName})";
var node = _GraphClient
                .Cypher
                .Match(matchText)
                .Return<Node<RepositoryStartNode>>("rsn")
                .Results
                .FirstOrDefault();

Expected behaviour
Node entity returned with both node reference and node data. Instead we receive an ArgumentException due to some deserialization issues.

The same code works perfectly with the Http client, and it works fine with bolt if we remove the Node<> wrapper.

The BOLT endpoints don't return the node references, so you can't return a Node<T> from a query using the BoltGraphClient - The only solution would be to so something like:
var matchText = $"(rsn:{repositoryStartNodeName})";
var node = _GraphClient
                .Cypher
                .Match(matchText)
                .Return(rsn => new {
                            Content = rsn.As<RepositoryStartNode>(),
                            Reference = Return.As<long>("id(rsn)")
                 })
                .Results
                .FirstOrDefault();

With Aura - that's the only thing you can do unfortunately.

Thanks @cskardon that example was super helpful and I was able to apply the principle across the board.
Unfortunately I have inherited a large codebase that uses Node syntax all over the place so this was looking like it would be a painful upgrade.

Yes, that's a painful process!
What I would question is whether you need the reference? It's very much frowned upon in Neo4j to use the ID of the node for anything, so you might be able to just drop it?


Pin annotation click and drag

@radpet
After I have clicked on an existing pin annotation and released my mouse, I can't re-select it.  Clicking on the pin again causes a new pin to be drawn.  I can cancel that new pin, and then I can select the pin again.  In effect, unless the user clicks and immediately drags the pin to move it, it is impossible to move it after it is created.  However, circles and rectangles behave differently since it is possible to release the mouse and then re-select the shape in order to move it or resize it.

Interesting UI quirk - what do you suggest as a solution?
From: Rashmi Singhal<EMAIL_ADDRESS>Sent: Monday, June 27, 2016 12:27 PM
To: IIIF/mirador<EMAIL_ADDRESS>Subject: [IIIF/mirador] Pin annotation click and drag (#982)
@radpethttps://github.com/radpet
After I have clicked on an existing pin annotation and released my mouse, I can't re-select it. Clicking on the pin again causes a new pin to be drawn. I can cancel that new pin, and then I can select the pin again. In effect, unless the user clicks and immediately drags the pin to move it, it is impossible to move it after it is created. However, circles and rectangles behave differently since it is possible to release the mouse and then re-select the shape in order to move it or resize it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/IIIF/mirador/issues/982, or mute the threadhttps://github.com/notifications/unsubscribe/AAEvg3tfFPneqRfqj9bzkXeBlRnJjUnQks5qP_nfgaJpZM4I_RVe.

Ideally it would behave the same was as the other shapes - namely until you hit save, the user is actively able to edit that shape.  The problem could just be about making the mouse click more sensitive and recognizing that the user is reselecting that pin, but I'm not sure.

@rsinghal Currently the pin has 5 point handlers that I cannot selectively disable. That is why I disabled all of them and made its stroke in another color when selected. I can check out why you are not able to drag it once you selected it. Actually I think that this bug will not be present after I implement the pointer tool because you will be able to draw shapes only after selecting the shape tool.

I can drag it if I don't release the mouse (upon first clicking it), but if I release the mouse, then I can't click on it again until I've clicked on the canvas, canceled the new pin that has been created, and then click on the old pin again (and of course, don't release the mouse).  I will try to make a gif of this if it isn't clear.

@rsinghal Yup I got it no need for gifs for now. I will spend some time on this issue, but I have no solution to display only one point handler and preserve the current shape of the pin

I will look into it as well

@rsinghal I checked it out and the code is implemented like that. I suggest changing it so it can handle multiple selections on pins, what do you think?

@rsinghal I fixed this in https://github.com/SirmaITT/mirador/tree/feature/delete-shape-action


Fix/added kbo tabs representative bodies

CONTEXT:
during testing a bug a reported that representative bodies had no working data tab for kbo.
Data tab is working and data is also shown if there is any
Merged into: https://github.com/lblod/frontend-organization-portal/pull/578

Merged into: https://github.com/lblod/frontend-organization-portal/pull/578


User Profile: Convert to lit mixin

I put this in components for now but perhaps we want some more organization with that? (e.g., hm-components).
This was mostly copy pasted from user-profile-behavior, pretty much worked as is, with the addition of an example consumer element for demoing/to make sure it worked. I also created helpers-hm and added d2l-organization-hm-behavior to that.

I'm probably confused, but it looks like this is not https://github.com/BrightspaceHypermediaComponents/users/tree/master/components?

This is https://github.com/Brightspace/user-profile-behavior. Was d2l-profile-image the expected conversion?

I was under the impression we were thinking of converting https://github.com/BrightspaceHypermediaComponents/users/blob/master/components/d2l-profile-image-base.js (UI) and seeing if that still worked in https://github.com/BrightspaceHypermediaComponents/users/blob/master/components/d2l-profile-image.js (HM), and then converting the HM one to test that, but I may have old info.  We've probably tested this all out now anyways, with the Lit + Polymer thing with subtle-button and icons, and HM now with this PR

Interesting, I must have missed that, sorry for the confusion! I can take a look at those conversions as well just to make sure. You're right though - based on what's been done so far I would expect it to be fine.

I was thinking the same as Stacey -- that we'd attempt the component Miles built. Sorry for the confusion Margaree!

Yeah, I'm also not sure what goes in this core repo... I think way back when we were thinking we'd own generic HM helpers, but not components.  Maya's working on Entity classes that would understand a certain HM route and live in the corresponding repo.  We may want a core repo in https://github.com/BrightspaceHypermediaComponents to hold the HM stuff we own.
But what about that https://github.com/BrightspaceHypermediaComponents/users/blob/master/components/d2l-profile-image-base.js component?  It was originally in BrightspaceUI, then moved to the HM users repo.  I kinda think that one should move back in here... we have all the core UI components that have a design on design.d2l that we could take back into the monolith, whether they are HM or not

I think I am leaning towards those HM components living elsewhere still.  I think testing all the "core" core elements will be a lot already.  I could be convinced otherwise though.  I definitely would like a clear distinction between those types of components.

Yeah, I'm leaning that way too Dave. We want the benefits of a monorepo (things that depend heavily on each other build together) without introducing the drawbacks (slow build times, hard to break stuff out). @margaree, would it make sense to just try to upgrade that component to Lit as a non-merging pull request in its existing repo? Then we can pull that into BSI and test it out.

@dlockhart yup that should work.


WIP: Update CircleCI to cache ccache

Change to closely follow the examples of how to use the cache.
addresses #236

This patch may clean up the style a little is is not resolving the reported issue. The second "Restoring Cache" as the following output:
No cache is found for key: ccache-arch1-linux-amd64-6_85-pull/242-
No cache is found for key: ccache-arch1-linux-amd64-6_85-master-


feat: improved query limit

The feature flag is now a boolean instead of int

You can set limit for query cells too (refactored code, so the composer and cell use the same function to transform query)

The query limit is now a dynamic scaling system with max 10^6 and default 10^3. This value can also be configured with plugins. Also updated the plugin documentation

Refactored code for detecting limit in queries

For queries that are limited, add a warning to let the users know

@baumandm hey Dave, since you are the original author for limit UI, do you know if this would work for your use case?

@czgu This looks amazing, no concerns here! 👍


remove unused functions

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/15434/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15434/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15434/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15434/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15434/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15434/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15434/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15434/merge#BCU1XR#0

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15434/merge/testResults/webgl2playwright/index.html

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15434/merge/testResults/webgpuplaywright/index.html


A11y_Fluent UI_Fluent UI React v9_Upgrade guide_AI4W: WCAG 1.3.1Ensures  elements are used semantically

Closing this bug as the bug logged in new ADO


Disabling TLS 1.0 not working

Describe the bug
I'm using the TLSContext CRD and I've set min_tls_version to v1.2
If I run the SSL test of SSLLabs, it mentions that TLS 1.1 is disabled, but TLS 1.0 is still available:
https://www.ssllabs.com/ssltest/analyze.html?d=example.engelbrink.dev
To Reproduce
Steps to reproduce the behavior:

Create TLSContext with min_tls_version: v1.2
Run test on SSLLabs
TLS 1.0 is still available

Expected behavior
Setting min_tls_version to v1.2 should disable any TLS version lower than 1.2
Versions (please complete the following information):

Ambassador Helm: v6.2.2
Ambassador: 1.3.1
Kubernetes environment: DigitalOcean
Version: 1.15.9-do.2

This was a caching problem at SSLLabs, the version is disabled now.


AttributeError: module 'nbconvert' has no attribute 'export_html'

@kikocorreoso , when I run the code as mentioned in the README, I get error AttributeError: module 'nbconvert' has no attribute 'export_html'.
I am using Python2.7, Anaconda Inc. in Windows.
I tried to search it on Google too but did not get any helpful.
Can you please suggest me any helpful?
Thanks.

ipy2wp is not maintained.
As it says in the README:
DEVELOPMENT CONTINUES HERE: https://github.com/Pybonacci/jupy2wp
Maybe you will be more lucky with jupy2wp as it is more modern
Warning: it is also semi-abandonware as I'm saying goodbye to wordpress as publishing platform.
Other options for you: https://github.com/choldgraf/jupyterblog


Toolbar bottom section opacity fix

Also sidebar full-width button should be hidden when sidebar is collapsed

@sneridagh Those Plone 6 test failures look fishy to me.
There is no way my opacity changes when the sidebar is collapsed would crash the plone rest API response

@sneridagh here is a gif with my changes demonstrating what this pull request fixes

@stevepiercy why Netlify is building this one? It has no docs changes.

@stevepiercy why Netlify is building this one? It has no docs changes.

I'm not sure. Netlify should honor this line in netlify.toml:
https://github.com/plone/volto/blob/a1230dc38579d7161333828ad1aca54c9f4354ff/netlify.toml#L5
Per: https://docs.netlify.com/configure-builds/ignore-builds/#mimic-default-behavior

Strange, the log indicates that it attempted to honor that command, but evidently it continued.
https://app.netlify.com/sites/volto/deploys/626fa8ee753aab00087830de#L14
Other recent deploy previews were canceled, including when this PR got merged to master.
https://app.netlify.com/sites/volto/deploys/626fb23578ceb100084897b7#L14
¯\_(ツ)_/¯


ISSUE-1102 Fix sampling status API to respond status 200 when topology is not running

Response will be changed to HTTP status 200 with success = "false" when topology is not running
Also refactor a bit based on suggestion (moving methods, API endpoint paths)

API endpoint path change:

/api/v1/sampling/topologies/:topologyId(/enable|disable) -> /api/v1/catalog/topologies/:topologyId/sampling(/enable|disable)
/api/v1/sampling/topologies/:topologyId/component/:componentId(/enable|disable) -> /api/v1/catalog/topologies/:topologyId/component/:componentId/sampling(/enable|disable)
/api/v1/sampling/topologies/:topologyId/events -> /api/v1/catalog/topologies/:topologyId/events

This closes #1102

@arunmahadevan @shahsank3t @sameer79
Please take a look. Given that this patch modifies the API endpoint paths which are related to #1101, this patch is effectively blocker for #1101.
@sameer79 I think this patch should be applied to #1101. Please take a look at the API endpoint paths.

@HeartSaVioR , the component sampling status returns the topology sampling status. I seem to have used the same client API at both places. Can you fix it?

@arunmahadevan Fixed and now building. I'll update the PR once build succeeds.

@arunmahadevan Addressed.

+1


Walk/pretty print comments

Summary

Walk comments in walkGherkinDocument
Pretty print comments in pretty

Details
Keep a stack of comments and pop/walk comments until the current AST node.
How Has This Been Tested?
I've just added a couple of unit tests - we need more thorough tests for this:

[ ] Add comments everywhere in walkGherkinDocumentTest
[ ] Add more edge case tests for pretty

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[ ] The change has been ported to Java.
[ ] The change has been ported to Ruby.
[x] The change has been ported to JavaScript.
[ ] The change has been ported to Go.
[ ] The change has been ported to .NET.
[ ] I've added tests for my code.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have updated the CHANGELOG accordingly.

@nddipiazza @jamietanna I'd welcome your feedback/review on this.

Yes, I'm aware it's still incomplete and buggy. But what do you think of the general approach of using a stack that we pop as we traverse?

Looks like the right idea. Sounds like just a matter of gathering a ton of feature files, running, and fixing what needs fixed.

Testing with a ton of files is useful, but I think we can get pretty good confidence/coverage by modifying this test:
https://github.com/cucumber/common/blob/main/gherkin-utils/javascript/test/walkGherkinDocumentTest.ts
I'd suggest adding comments like
# 1

# 2

# 3

etc around the file and modify the expected result at the end. That way we know we're traversing correctly (which is the basis for correct pretty formatting).

Using a stack that pops makes sense - that's how I've been doing it with my Java library, the difficulty right now is trying to make sure it pops in the right place :sweat_smile:

I took a stab at this. I had one more contraint though, namely whitespace retention. One thing I like about other "prettifiers" is the ability to truncate duplicate whitespace, but otherwise retain it. With that I mean that both the following gherkin documents would be "valid" and "prettified" to itself:
Feature: foo
  Scenario: bar
    Given some step

Feature: foo

  Scenario: bar
    Given some step

I was looking at the AST in connection with this. There's two things so far I've noticed missing, that I need in order to get perfect prettifying as described above.

Location of the dialect commet, EG. # language: no (it's not added to ast's comments section)
Location attribute of description blocks (they only exists as string of EG. scenarios)

Would you be open to extending messages to include location in descriptions, as well as appending dialect-comments to comments?
Aside from these things, I was able to prettify and retain whitespace and truncate duplicate. I did however not use walkGherkinDocument :scream_cat: . My implementation can be seen below.
import { AstBuilder, Parser, TokenMatcher, dialects } from "@cucumber/gherkin";

import { messages, IdGenerator } from "@cucumber/messages";

type PrettifyOptions =
  | { spaces: number; trailingNewLine: boolean }
  | { tabs: true; trailingNewLine: boolean };

function findIndex<T>(collection: T[], fn: (val: T) => boolean): number {
  for (let i = 0; i < collection.length; i++) {
    if (fn(collection[i])) {
      return i;
    }
  }

  return -1;
}

function isNumeric(content: string) {
  return !isNaN(parseFloat(content));
}

function minIndent(content: string) {
  const match = content.match(/^[ \t]*(?=\S)/gm);

  if (!match) {
    return 0;
  }

  return match.reduce((r, a) => Math.min(r, a.length), Infinity);
}

function stripIndent(content: string) {
  const indent = minIndent(content);

  if (indent === 0) {
    return content;
  }

  const regex = new RegExp(`^[ \\t]{${indent}}`, "gm");

  return content.replace(regex, "");
}

class State {
  private indent: number = 0;

  private pushed: {
    sourceLine: number;
    indent: number;
    content: string;
  }[] = [];

  constructor(private options: PrettifyOptions) {}

  withIncreasedIndent(fn: () => void) {
    this.indent++;
    fn();
    this.indent--;
  }

  push(content: string, sourceLine: number) {
    this.pushed.push({ content, sourceLine, indent: this.indent });
  }

  injectComment(content: string, sourceLine: number) {
    const insertAtIndex = findIndex(
      this.pushed,
      (line) => line.sourceLine > sourceLine
    );

    if (insertAtIndex === -1) {
      this.pushed.push({
        content,
        sourceLine,
        indent: 0,
      });
    } else {
      const indentOfCommentedLine = this.pushed[insertAtIndex]?.indent ?? 0;

      this.pushed.splice(insertAtIndex, 0, {
        content,
        sourceLine,
        indent: indentOfCommentedLine,
      });
    }
  }

  build() {
    if (this.pushed.length === 0) {
      return "";
    }

    const indent = (line: { content: string; indent: number }) => {
      if ("spaces" in this.options) {
        return " ".repeat(this.options.spaces * line.indent) + line.content;
      } else {
        return "\t".repeat(line.indent) + line.content;
      }
    };

    const lines: string[] = [];

    for (let i = 0; i < this.pushed.length; i++) {
      if (this.pushed[i].content === "") {
        lines.push("");
      } else {
        lines.push(indent(this.pushed[i]));
      }

      if (i !== this.pushed.length - 1) {
        const nextSourceLine = this.pushed[i + 1].sourceLine;

        if (this.pushed[i].sourceLine + 1 < nextSourceLine) {
          lines.push("");
        }
      }
    }

    if (this.options.trailingNewLine) {
      lines.push("");
    }

    return lines.join("\n");
  }
}

export function prettify(source: string, options: PrettifyOptions) {
  const document = new Parser(
    new AstBuilder(IdGenerator.uuid()),
    new TokenMatcher()
  ).parse(source);

  const state = new State(options);

  visitDocument(state, document);

  if (document.comments) {
    for (const comment of document.comments) {
      state.injectComment(comment.text!.trimStart(), comment.location!.line!);
    }
  }

  return state.build();
}

function visitDocument(state: State, document: messages.IGherkinDocument) {
  if (document.feature) {
    visitFeature(state, document.feature);
  }
}

function pushTitle(
  state: State,
  element:
    | messages.GherkinDocument.IFeature
    | messages.GherkinDocument.Feature.FeatureChild.IRule
    | messages.GherkinDocument.Feature.IScenario
    | messages.GherkinDocument.Feature.IBackground
    | messages.GherkinDocument.Feature.Scenario.IExamples
) {
  if (element.name) {
    state.push(
      element.keyword! + ": " + element.name!,
      element.location!.line!
    );
  } else {
    state.push(element.keyword! + ":", element.location!.line!);
  }
}

function visitFeature(
  state: State,
  feature: messages.GherkinDocument.IFeature
) {
  feature.tags?.map((tag) => visitTag(state, tag));

  pushTitle(state, feature);

  state.withIncreasedIndent(() => {
    if (feature.description) {
      const description = stripIndent(feature.description);

      const lines = description.split("\n");

      for (let i = 0; i < lines.length; i++) {
        state.push(lines[i], feature.location!.line! + i + 1);
      }
    }

    if (feature.children) {
      for (const child of feature.children) {
        visitChild(state, child);
      }
    }
  });
}

function visitChild(
  state: State,
  child: messages.GherkinDocument.Feature.IFeatureChild
) {
  if (child.rule) {
    visitRule(state, child.rule);
  } else if (child.background) {
    visitBackground(state, child.background);
  } else if (child.scenario) {
    visitScenario(state, child.scenario);
  }
}

function visitRule(
  state: State,
  rule: messages.GherkinDocument.Feature.FeatureChild.IRule
) {
  rule.tags?.map((tag) => visitTag(state, tag));

  pushTitle(state, rule);

  state.withIncreasedIndent(() => {
    if (rule.description) {
      const description = stripIndent(rule.description);

      const lines = description.split("\n");

      for (let i = 0; i < lines.length; i++) {
        state.push(lines[i], rule.location!.line! + i + 1);
      }
    }

    if (rule.children) {
      for (const child of rule.children) {
        visitChild(state, child);
      }
    }
  });
}

function visitBackground(
  state: State,
  background: messages.GherkinDocument.Feature.IBackground
) {
  pushTitle(state, background);

  state.withIncreasedIndent(() => {
    if (background.description) {
      const description = stripIndent(background.description);

      const lines = description.split("\n");

      for (let i = 0; i < lines.length; i++) {
        state.push(lines[i], background.location!.line! + i + 1);
      }
    }

    if (background.steps) {
      for (const step of background.steps) {
        visitStep(state, step);
      }
    }
  });
}

function visitScenario(
  state: State,
  scenario: messages.GherkinDocument.Feature.IScenario
) {
  scenario.tags?.map((tag) => visitTag(state, tag));

  pushTitle(state, scenario);

  state.withIncreasedIndent(() => {
    if (scenario.description) {
      const description = stripIndent(scenario.description);

      const lines = description.split("\n");

      for (let i = 0; i < lines.length; i++) {
        state.push(lines[i], scenario.location!.line! + i + 1);
      }
    }

    if (scenario.steps) {
      for (const step of scenario.steps) {
        visitStep(state, step);
      }
    }

    if (scenario.examples) {
      for (const example of scenario.examples) {
        visitExamples(state, example);
      }
    }
  });
}

function visitStep(state: State, step: messages.GherkinDocument.Feature.IStep) {
  state.push(step.keyword! + step.text!, step.location!.line!);

  state.withIncreasedIndent(() => {
    if (step.dataTable) {
      visitRows(state, step.dataTable.rows!);
    } else if (step.docString) {
      state.push(
        step.docString.delimiter! + step.docString.mediaType,
        step.docString.location!.line!
      );

      let docStringContent = step.docString.content!;

      if (step.docString.delimiter! === '"""') {
        docStringContent = docStringContent.replace(/"""/gm, '\\"\\"\\"');
      } else {
        docStringContent = docStringContent.replace(/```/gm, "\\`\\`\\`");
      }

      const lines = docStringContent.split("\n");

      for (let i = 0; i < lines.length; i++) {
        state.push(lines[i], step.docString.location!.line! + i + 1);
      }

      state.push(
        step.docString.delimiter!,
        step.docString.location!.line! + lines.length + 1
      );
    }
  });
}

function visitTag(
  state: State,
  tag: messages.GherkinDocument.Feature.ITag
): any {
  state.push(tag.name!, tag.location!.line!);
}

function visitExamples(
  state: State,
  example: messages.GherkinDocument.Feature.Scenario.IExamples
) {
  example.tags?.map((tag) => visitTag(state, tag));

  pushTitle(state, example);

  state.withIncreasedIndent(() => {
    visitRows(state, [example.tableHeader!, ...example.tableBody!]);
  });
}

function visitRows(
  state: State,
  rows: messages.GherkinDocument.Feature.ITableRow[]
) {
  const columnMaxWidths: number[] = [];

  for (let iRow = 0; iRow < rows.length; iRow++) {
    for (let iCell = 0; iCell < rows[iRow].cells!.length; iCell++) {
      columnMaxWidths[iCell] = Math.max(
        columnMaxWidths[iCell] ?? 0,
        rows[iRow].cells![iCell].value!.length
      );
    }
  }

  for (let iRow = 0; iRow < rows.length; iRow++) {
    const paddedValues = rows[iRow].cells!.map((cell, iCell) => {
      if (isNumeric(cell.value!)) {
        return cell.value!.padStart(columnMaxWidths[iCell], " ");
      } else {
        return cell.value!.padEnd(columnMaxWidths[iCell], " ");
      }
    });

    state.push(
      "| " + paddedValues.join(" | ") + " |",
      rows[iRow].location!.line!
    );
  }
}

@badeball thanks for contributing this and sorry for not reviewibg this yet. I hope I’ll find some time to move this along in November.

This PR needs to be re-applied to the new repo at https://github.com/cucumber/gherkin-utils

Thanks for the heads up, and for moving this out of the monorepo!


Created Home fragment for not logged in user

Company fragment is unfinished so I added it as it is and im waiting for services view.

Technology Stack looks at least average


Issue hosting Conductor + Redis in k8s

Describe the bug
We are facing a issue with hosting conductor in our kubernates cluster.
When Redis is enabled we are getting the below error:
conductor-container.txt
When i set the config to be in-memory, conductor runs fine.
Details
Conductor version:
Persistence implementation: Redis
Queue implementation: Redis
Lock: Redis
Workflow definition: non
Task definition: non
Event handler definition: non
Additional context
Add any other context about the problem here.
Config ->
conductor.db.type=redis_standalone
conductor.queue.type=redis_standalone

conductor.redis.hosts=<IP_ADDRESS>:6379
conductor.redis-lock.serverAddress=redis://<IP_ADDRESS>:6379
conductor.redis.taskDefCacheRefreshInterval=1
conductor.redis.workflowNamespacePrefix=conductor
conductor.redis.queueNamespacePrefix=conductor_queues

conductor.workflow-execution-lock.type=redis
conductor.app.workflowExecutionLockEnabled=true
conductor.app.lockTimeToTry=500

conductor.app.systemTaskWorkerThreadCount=20
conductor.app.systemTaskMaxPollCount=20

conductor.metrics-prometheus.enabled=true
management.endpoints.web.exposure.include=prometheus

loadSample=true

found my own error in the config:
conductor.redis.hosts=<IP_ADDRESS>:6379 i was missing :us-east1c


Add an integration test for Readiness controller

Add a simple integration test that checks that the certificate readiness controller starts and that in a standard scenario a Certificate's Ready condition is updated- similar to our existing integration tests for some of the other Certificate controllers .
/kind cleanup

/assign


Fix webauthn demo for new versions of the WebAuthn API

What this PR does
The WebAuthn API has since been updated and spec change has led to change to one of the parameter in order for the newer version of the API to work on this demo. The only change on the JS layer is the challenge is now encoded as UTF-8 string through the TextEncoderLite library, which is under Apache license.
Requirements

[x] My PR follows all applicable accessibility requirements (See .github/ACCESSIBILITY_REQS.md).

@AngeloKai can you wrap the library with the following:
/* eslint-disable */
// License and other comments
// library code
/* eslint-enable */

That way Travis will pass.

@AngeloKai is this ready to be merged? Otherwise please just open a PR when everything is ready. Also can you rebase your code with the latest version in master?

@molant It's ready to merge. There was a bug earlier in the code due to changes in the EDGEHTML codebase. I merge the latest change from master.