Smart image sizing and loading for key stories and footer

this is going to take over for #304
We have footer images and water use stories that are 1.3 MB (desktop story), 757 KB (mobile story right), 574 KB (mobile story), 117 KB (the previous WU viz's thumbnail in the footer), and 47.3 KB (Maria thumbnail in the footer).
For reference, D3 is 72.8 KB and county_boundaries_USA.json are 242 KB
The three WU story jpegs are the three biggest files the viz loads initially (high res counties are big too, but they aren't loaded until you zoom).
These three images seem to get loaded before we start loading the state data or the county centroids, and therefore they are likely slowing the "time to first paint". The implications are approximately a > 1.5s delay on network for a desktop machine and a much larger delay on mobile cell data.

[x] make it so either the single desktop image is used/loaded (wide) or two (narrow) for water use
[ ] shrink the two mobile files (they are likely higher resolution than is needed for the narrow view
[x] modify the way these resources are fetched by the browser so that they are queued later, either by implementing some lazy loading solution (there are many options including starting w/ a lower-res/blurry image and replacing w/ higher res when it is in viewport) or just making sure they are called for after the map is built.

Looking good as of #326. Now that we have a single "wide" image for mobile, we might want to do some work to shrink the size/resolution of that image. The one in right now https://beta-owi.usgs.gov/vizlab/water-use-15/images/WU_stories_static_mobile.jpg is 1747px wide, and it looks like we switch to using this image when the resolution of the device is 600px wide.
Also, since loading the footer images delays drawing the map, I think we should also use the lazy load for those images.

Are there supposed to be two (4)s in that image?

@lindsaycarr ☝
I think I remember you having a key for each of those numbers in the mobile version ("read more"). Is 4 supposed to repeat?

So the 4 is from the same blurb we broke up, so it's talking about the same thing, in two different areas of the country. We could do 4.1 and 4.2 if you guys find it confusing?  We do have keys expander and hider coming up that explains the numbers in greater detail.

So I see we fixed the issue with two 4's above by having 4a and 4b, and the footer images are indeed lazy-loading.
Looks like there one thing left: shrink width of that mobile image to 600px. @mwernimont do you see any reason not to do that, and if not, is that something you can do?

Is it just a file size issue?  Cause we already control how big the image is through CSS.  If this is cause it switches at 600px I would start to worry about resolution and text size.

Yes, this is a file size issue. I am assuming we can get a smaller file size and not lose quality for the < 600px devices. Is that not the case?

No, it is, I was blissfully unaware of the current 1700px+ image size for mobile.  It will be shrunk when I get the new and improved base map form Lindsay


Tweak Makefile to handle patch versions with reproducible revisions

This idea is very simple: instead of bumping manually the patch number of a
version - frequent and tedious - we calculate a reproducible revision number.
It will be the number of commits since the earliest X.Y.0 tag. The above
signals the starting of a new cycle.
ClojureScript implements this strategy and it is really effective so we are
going to try it in here as well since 0.2.0.
The major and minor numbers are in the Makefile but will be propagated to all
the necessary files (project.clj, package.json, pom.xml).
To check the next version:
make next-version

To prepare for release and deploy:
make prepare-release
make deploy

What is there not to love of this change? It is how it should be done on every project!

Wow nice feedback, I wonder what @mattbishop thinks as well ;)


[AXON-31] Unit testing setup + URI handler rework

What is this?
Refactoring URI handler to prepare for the next steps in auth work.

Extract individual routes into handler actions
Cover everything with tests
Put the new implementation under a feature flag

This turned from a small bit of refactoring into a bit of an example of unit test setup for the vscode API ;D
What's not in here?
A lot of the logic is deliberately left "as is", to track the changes a bit better in another PR:

Route lookup is suboptimal
URL handling is different across the actions (e.g. query parameters escaped or not)
Query handling in general could use some work
No new analytics events

However, I have included some small changes:

A more consistent (but still suboptimal) error handling across actions
Some common logic extracted into CheckoutHelper and JiraIssueFetcher

How was this tested?

All the standard CI stuff:

npm run lint # ok
npm run test # ok (and a lot more coverage now, lol)
npm run compile

Tested the feature flag working as expected
Tested some deep linking - but need to iterate a bit more exhaustively

Oops, looks like after merging the ui-testing change there's a conflict 😦


[WIP] CI config

Rebased on #3 to test it on Windows and macOS

/me starts crying while setting up a windows virtualbox

Rebased on master, going to merge this as it's a trivial commit.

Self ACK 8dcc2a56d2d436265ca057501508f343b944f755


NRE in OnAttackSequenceBegin

From RT #ticket-3267:
Playing Osmium Beta 1.1, had no issues with install at all
currently in an escort mission (1.5 skulls vs lance with .5 skulls) and stuck on turn 23, phase 12
my escort targets just lamented my missing mechs near their vicinity and now the game is stuck
it is still their (ally) turn
HarkonnenLast Saturday at 11:55 PM
cac_main_log from customammocategories
and cbt_behaviors_enhanced.log from CBTBehaviorsEnhanced
2020-03-21T22:44:03 FYLS [ERROR] CRITICAL ERROR, PLEASE REPORT:
Delegate OnAttackSequenceBegin - Standard for message type OnAttackSequenceBegin failed with exception
Value cannot be null.
Parameter name: OnAttackSequenceBegin received invalid sequenceID: 29602300
  at (wrapper dynamic-method) BattleTech.AttackDirector.OnAttackSequenceBegin_Patch1(object,MessageCenterMessage)
  at MessageCenter.SendMessagesForType (MessageCenterMessageType messageType, MessageCenterMessage message) [0x00037] in <4184af8dbeb4
4635831353f4d349631c>:0

output_log (4).txt
cleaned_output_log (4).txt

Many safeguards applied in 0.5.0 - should fix this error


PowerShell 7.2.11 fails to start on Alpine 3.18 using .NET SDK 6.0.408

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce

Create a Dockerfile with the following content:

FROM amd64/alpine:3.18

RUN apk add --no-cache \
        ca-certificates \
        bash \
        \
        # .NET dependencies
        krb5-libs \
        libgcc \
        libintl \
        libssl3 \
        libstdc++ \
        zlib \
        curl \
        icu-data-full \
        icu-libs \
        git

# Install .NET 6
RUN curl -sSL https://dot.net/v1/dotnet-install.sh | bash /dev/stdin -Quality preview -Channel 6.0 -InstallDir /usr/share/dotnet \
    && ln -s /usr/share/dotnet/dotnet /usr/bin/dotnet

# Install PowerShell global tool
RUN powershell_version=7.2.11 \
    && wget -O PowerShell.Linux.Alpine.$powershell_version.nupkg https://pwshtool.blob.core.windows.net/tool/$powershell_version/PowerShell.Linux.Alpine.$powershell_version.nupkg \
    && powershell_sha512='ce57a18d2b6bc98340eb34861bbd7552964dd6d5258f9af2b7cb22513ced655668df01ff8359fca03abf3bd8ffb8321e141e14bf955be167648296be36b8e0e1' \
    && echo "$powershell_sha512  PowerShell.Linux.Alpine.$powershell_version.nupkg" | sha512sum -c - \
    && mkdir -p /usr/share/powershell \
    && dotnet tool install --add-source / --tool-path /usr/share/powershell --version $powershell_version PowerShell.Linux.Alpine \
    && dotnet nuget locals all --clear \
    && rm PowerShell.Linux.Alpine.$powershell_version.nupkg \
    && ln -s /usr/share/powershell/pwsh /usr/bin/pwsh \
    && chmod 755 /usr/share/powershell/pwsh \
    # To reduce image size, remove the copy nupkg that nuget keeps.
    && find /usr/share/powershell -print | grep -i '.*[.]nupkg$' | xargs rm \
    # Add ncurses-terminfo-base to resolve psreadline dependency
    && apk add --no-cache ncurses-terminfo-base

Build the Dockerfile: > docker build -t repro -f .\Dockerfile .
Try to run PowerShell: > docker run --rm repro pwsh

Expected behavior
Powershell runs successfully and outputs

> docker run --rm repro pwsh
PowerShell 7.2.11
>

### Actual behavior

```console
PS C:\...> docker run --rm repro pwsh
PowerShell 7.2.11
Copyright (c) Microsoft Corporation.

https://aka.ms/powershell
Type 'help' to get help.

One or more errors occurred. (The type initializer for 'System.Management.Automation.TypeAccelerators' threw an exception.)
One or more errors occurred. (The type initializer for 'System.Management.Automation.TypeAccelerators' threw an exception.)
Cannot load PSReadline module.  Console is running without PSReadline.
Process terminated. The type initializer for 'System.Management.Automation.PSObject' threw an exception.
   at System.Environment.FailFast(System.String, System.Exception)
   at Microsoft.PowerShell.UnmanagedPSEntry.Start(System.String[], Int32)
   at Microsoft.PowerShell.ManagedPSEntry.Main(System.String[])
System.TypeInitializationException: The type initializer for 'System.Management.Automation.PSObject' threw an exception.
 ---> System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Management.Infrastructure, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.

File name: 'Microsoft.Management.Infrastructure, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
   --- End of inner exception stack trace ---
   at System.Management.Automation.PSObject.get_Properties()
   at System.Management.Automation.HostUtilities.GetDollarProfile(String allUsersAllHosts, String allUsersCurrentHost, String currentUserAllHosts, String currentUserCurrentHost)
   at Microsoft.PowerShell.ConsoleHost.DoRunspaceInitialization(Boolean skipProfiles, String initialCommand, String configurationName, Collection`1 initialCommandArgs)
   at Microsoft.PowerShell.ConsoleHost.DoCreateRunspace(String initialCommand, Boolean skipProfiles, Boolean staMode, String configurationName, Collection`1 initialCommandArgs)
   at Microsoft.PowerShell.ConsoleHost.CreateRunspace(Object runspaceCreationArgs)
   at Microsoft.PowerShell.ConsoleHost.DoRunspaceLoop(String initialCommand, Boolean skipProfiles, Collection`1 initialCommandArgs, Boolean staMode, String configurationName)
   at Microsoft.PowerShell.ConsoleHost.Run(CommandLineParameterParser cpp, Boolean isPrestartWarned)
   at Microsoft.PowerShell.ConsoleHost.Start(String bannerText, String helpText)
   at Microsoft.PowerShell.UnmanagedPSEntry.Start(String[] args, Int32 argc)

Error details
No response
Environment data
Cannot access $PSVersionTable because PowerShell will not start. The bash variable $PSVersionTable is empty.

Visuals
No response

I tried in an Alpine docker with the alpine 7.3.4 and 7.2.11 tar gz and they both worked
$ cat /etc/os-release
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.18.0
PRETTY_NAME="Alpine Linux v3.18"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://gitlab.alpinelinux.org/alpine/aports/-/issues"

With powershell-7.3.4-linux-alpine-x64.tar.gz
$ powershell-7.3.4/pwsh
PowerShell 7.3.4
PS> exit

With powershell-7.2.11-linux-alpine-x64.tar.gz
$ powershell-7.2.11/pwsh
PowerShell 7.2.11
Copyright (c) Microsoft Corporation.

https://aka.ms/powershell
Type 'help' to get help.

PS> exit

Alpine 3.18.0 has its own build of dotnet-sdk-6.0
alpine3:~$ sudo apk add dotnet-sdk-6.0
fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/community/x86_64/APKINDEX.tar.gz
fetch https://svn.rhubarb.geek.nz/pkg/alpine/3.18.0/x86_64/APKINDEX.tar.gz
(1/15) Installing dotnet-host (7.0.5-r3)
(2/15) Installing dotnet6-hostfxr (6.0.16-r3)
(3/15) Installing icu-data-full (73.1-r1)
(4/15) Installing lttng-ust (2.13.5-r2)
(5/15) Installing xz-libs (5.4.3-r0)
(6/15) Installing libunwind (1.6.2-r3)
(7/15) Installing dotnet6-runtime (6.0.16-r3)
(8/15) Installing aspnetcore6-runtime (6.0.16-r3)
(9/15) Installing aspnetcore6-targeting-pack (6.0.16-r3)
(10/15) Installing dotnet6-apphost-pack (6.0.16-r3)
(11/15) Installing dotnet6-targeting-pack (6.0.16-r3)
(12/15) Installing dotnet6-templates (6.0.116-r2)
(13/15) Installing netstandard21-targeting-pack (7.0.105-r3)
(14/15) Installing dotnet6-sdk (6.0.116-r2)
(15/15) Purging icu-data-en (73.1-r1)
Executing busybox-1.36.0-r9.trigger
OK: 746 MiB in 102 packages

and dotnet-sdk-7.0
alpine3:~$ sudo apk add dotnet-sdk-7.0
(1/9) Installing dotnet7-hostfxr (7.0.5-r3)
(2/9) Installing dotnet7-runtime (7.0.5-r3)
(3/9) Installing aspnetcore7-runtime (7.0.5-r3)
(4/9) Installing aspnetcore7-targeting-pack (7.0.5-r3)
(5/9) Installing dotnet7-apphost-pack (7.0.5-r3)
(6/9) Installing dotnet7-targeting-pack (7.0.5-r3)
(7/9) Installing dotnet7-templates (7.0.105-r3)
(8/9) Installing libucontext (1.2-r2)
(9/9) Installing dotnet7-sdk (7.0.105-r3)
OK: 1196 MiB in 111 packages

It also has powershell 7.3.4 as an apk
alpine3:~$ sudo apk add powershell
(1/2) Installing libpsl-native (7.3.1-r0)
(2/2) Installing powershell (7.3.4-r1)
Executing busybox-1.36.0-r9.trigger
OK: 1245 MiB in 113 packages
alpine3:~$ pwsh
PowerShell 7.3.4
PS> exit

I tried in an Alpine docker with the alpine 7.3.4 and 7.2.11 tar gz and they both worked

Those tar.gz's include the .NET Runtime. Since we want to keep our image size as small as possible, we want to use the .NET Runtime/SDK version from the base image, in this case it would be the official ASP.NET/SDK images. I didn't care about size in the repro Dockerfile above so I just installed the whole .NET SDK wholesale in the same image. The actual Dockerfile we're working on is here: https://github.com/dotnet/dotnet-docker/blob/nightly/src/sdk/6.0/alpine3.17/amd64/Dockerfile

Alpine 3.18.0 has its own build of dotnet-sdk-6.0
alpine3:~$ sudo apk add dotnet-sdk-6.0
...
OK: 746 MiB in 102 packages

For similar reasons, we can't have a 700+ MB installation of PowerShell or .NET in these images. The total image size here usually ends up around 200MB.

Just installing PowerShell APK depends just the dotnet7-runtime APK, not the entire SDK
alpine3:~$ sudo apk add powershell
(1/12) Installing libgcc (12.2.1_git20220924-r10)
(2/12) Installing libstdc++ (12.2.1_git20220924-r10)
(3/12) Installing dotnet-host (7.0.5-r3)
(4/12) Installing dotnet7-hostfxr (7.0.5-r3)
(5/12) Installing icu-data-full (73.1-r1)
(6/12) Installing icu-libs (73.1-r1)
(7/12) Installing lttng-ust (2.13.5-r2)
(8/12) Installing xz-libs (5.4.3-r0)
(9/12) Installing libunwind (1.6.2-r3)
(10/12) Installing dotnet7-runtime (7.0.5-r3)
(11/12) Installing libpsl-native (7.3.1-r0)
(12/12) Installing powershell (7.3.4-r1)
Executing busybox-1.36.0-r9.trigger
OK: 172 MiB in 45 packages

I am not seeing this issue any more with the latest image, mcr.microsoft.com/dotnet/sdk:6.0.417-alpine3.18.


--ignore '! www.google.com' does not work

Setup:
mitmproxy version: 0.12.1
Ubuntu 14.04.02 LTS
Problem description:
With command:
mitmproxy -I 'www.google.com'
(should ignores www.google.com, right ?)
For www.google.com/ncr URL mitmproxy ignores https as expected

For www.yahoo.com URL mitmproxy intercept https as expected

With command:
mitmproxy -I '!www.google.com'
(should ignores everything but www.google.com, If this regex is correct ?)
For www.google.com/ncr URL mitmproxy intercept https as expected

For www.yahoo.com URL mitmproxy intercept https, NOT as expected

Wrong regex or bug ?

The regex is wrong - check out https://mitmproxy.org/doc/features/passthrough.html, there's an example for ignoring everything but a selected set of domains.
Cheers,
Max


WIP: build with clang, link against Intel OpenMP runtime

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Some of the performance benefit from compiling this package with icc comes from Intel's OpenMP runtime, libiomp5. Clang supports targeting libiomp5.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The recipe must have some tests.
The build section contained an unexpected subsection name. error_overdepending is not a valid subsection name.
The build section contained an unexpected subsection name. error_overlinking is not a valid subsection name.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender


Missing event webhook url_offset

Expected content
The new event webhook page is missing a description and example of url_offset that existed in the old event webhook page.
Here's the info from the old page:
{% anchor h3 %}
Click
{% endanchor %}

         event
         email
         url
         category

         click
         Message recipient
         URL Clicked
         The category you assigned

{% info %}
`url_offset` gives you more information about the link that was clicked. Links are indexed beginning at 0. `index` indicates which link was clicked based on that index. The type of link can be either text, HTML, or a header. `type` indicates the type of the link that was clicked.
{% endinfo %}

{% codeblock lang:json %}
{
  "sg_event_id":"sendgrid_internal_event_id",
  "sg_message_id":"sendgrid_internal_message_id",
  "ip":"<IP_ADDRESS>",
  "useragent":"Mozilla/5.0 (iPhone; CPU iPhone OS 7_1_2 like Mac OS X) AppleWebKit/537.51.2 (KHTML, like Gecko) Version/7.0 Mobile/11D257 Safari/9537.53",
  "event":"click",
<EMAIL_ADDRESS>  "timestamp":1249948800,
  "url":"http://yourdomain.com/blog/news.html",
  "url_offset": {
    "index": 0,
    "type": "html"
  },
  "unique_arg_key":"unique_arg_value",
  "category":["category1", "category2"],
  "newsletter": {
    "newsletter_user_list_id": "10557865",
    "newsletter_id": "1943530",
    "newsletter_send_id": "2308608"
  },
  "asm_group_id": 1
}
{% endcodeblock %}

Actual content
Add the note and the example back in.
Link to page: https://sendgrid.com/docs/API_Reference/Event_Webhook/event.html

I want to take this issue
Can you tell me where it should be in the page ? because i see a heading named Click already


fix: updated blog slug to our-approach-to-curriculum

Description
Music year: 1988

List of changes

Issue(s)
Fixes #
How to test

Go to https://deploy-preview-2383--oak-web-application.netlify.thenational.academy
Click on ______
You should see ______

Screenshots
How it used to look (delete if n/a):
{screenshots}
How it should now look:
{screenshots}
Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

:tada: This PR is included in version 1.413.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add index.js files to subdirectories/namespace

This allows to streamline the import/export in the main file.
This PR incorporates the suggestions from https://github.com/Leaflet/Leaflet/pull/4989#pullrequestreview-18713630.

It's good to see this as a PR, but it seems that the unit tests are failing. Apparently the exports are not as they should be in the bundle :-(

Interesting. The exports in dist/leaflet-src.js are the same (modulo some reordering). When using the built file in karma.conf.js, the tests pass:
diff --git a/spec/karma.conf.js b/spec/karma.conf.js
index ad817795..259497e4 100644
--- a/spec/karma.conf.js
+++ b/spec/karma.conf.js
@@ -10,7 +10,7 @@ module.exports = function (config) {
                "spec/sinon.js",
                "spec/expect.js",

-               "src/Leaflet.js",
+               "dist/leaflet-src.js",

                "spec/after.js",
                "node_modules/happen/happen.js",

Using karma-rollup-plugin instead of karma-rollup-preprocessor fixes the tests, see ccb6573.

Using karma-rollup-plugin instead of karma-rollup-preprocessor fixes the tests

This kind of stuff never ceases to amaze me. :open_mouth:


Add files via upload

Added Sept 4 update of Page 1   pdf file of calendar

Sept. 4 2022 update of Page 1 of pdf file for 2022-23 calendar


WIP (Ignore me) - Quick integration demo

This is a minor demo we are building for our client. Please ignore this PR for now.

I understand you're implementing a tool for your client @quangIO, but I doubt you need to open a PR to this repo in order to do so. Please stop opening PRs, unless your aim is to contribute changes upstream and have us review it 🙂


Generated code different to tsc output using ES6 - for...of iterator issue

Issue

Iterators are not handled correctly when targetting ES6.
When using "target": "es6" in tsconfig.json, when you run tsc the generated Javascript does not do anything clever with for (x of y) loops (iterators) since these are supported natively in ES6.
When running using ts-jest, the cache output looks like this:
    for (var _i = 0, source_1 = source; _i < source_1.length; _i++) {
        var x = source_1[_i];
        ...
    }

Iterators do not have a length property, so this code does not work!

Expected behavior

Generated Javascript from pre-processor should be the same as tsc output.

Link to a minimal repo that reproduces this issue

Have added to test.spec.ts in the linked project:
https://github.com/jugglingcats/ts-jest-idea

Optional (but highly recommended) - Configure Travis (or your favorite system) with the minimal repo

https://travis-ci.org/jugglingcats/ts-jest-idea
Note that if you clone locally and run:
tsc
npm test

you can see that the tests pass in the tsc generated JS but not the pre-processor generated TS.

Arghh, this is due to TS_CONFIG added to package.json. Seems this overrules ts-config.json completely!

It would be nice if TS_CONFIG merged inline settings with tsconfig.json but it's clear enough what is happening. My mistake


Mobile Apps: Connect/Disconnect when connected to target wireless network

Is your feature request related to a problem? Please describe.
The VPN might not have to be always on. Mobile device might require to be connected to the VPN only when not in the office or when not at home.
Describe the solution you'd like
The idea is to have a feature that allows users to select a named network. When the device is connected to that network the VPN can be configured to automatically connect or disconnect.
Scenario:
A device is currently connected to the access point xyz, on which a VPN is not required to access corporate (or homelab) resources. Netbird is configured to say disconnected when the device is connected to the access point xyz. However, when the mobile device is disconnected from said access point, Netbird should automatically connect.

@e-renna, so that we can understand the request better, can you share your concerns on having the client always connected as well? What usually happens is that as the network changes, the peers will eventually renegotiate their connections and use the best path, so in cases you arrive home or to an office network, you should have a similar performance as a local connection, plus all the ALC and DNS features that comes with NetBird.

Perhaps I can add a possible justification for this feature.  Full disclosure, I'm currently using Tailscale and investigating a switch to Netbird as it uses hardware Wireguard and is self-hostable, among other reasons.  Anyway, my use case is such that I currently use Tailscale (and in the future Netbird) to connect to my workplace (for working remotely/RDP) when I'm at home, connecting to my homelab while I'm at work, and for all my family's mobile clients to connect back to the homelab when away from home for DNS for content filtering, adblocking, etc... via Adguard Home.  The Issue I face is that all of the machines on my home network don't connect to Tailscale.  Just one of them, and then that client is the nexthop for all the subnets on the home lab that get to the other services.  Hopefully I've worded that properly.  So when I'm connected to both the home wifi network and Tailscale, the Android clients prefer the VPN connection, and all of the traffic that would be local over just the wifi still has to traverse the one client connected to Tailscale.  If the VPN were disconnected, the traffic would be much more direct, having only to route via the router and not the Tailscale client node as well.  At the moment, I've kindof gotten around this by using Home Assistant and Android intents to try and disconnect Tailscale when the client's IP over the wifi is pingable.  The only reason I mention Tailscale so much (besides that it is what I'm currently using) is that Tailscale doesn't have this auto-on/off based on wifi SSID either.  If netbird were to have this feature built-in, it would be awesome.

I think it's worth adding that besides any niche network setups one may have, this feature should be available purely to extend the battery life of mobile devices. While I'm sure you guys are optimizing the mobile apps best you can, the battery drain is still significant especially on older devices. Adding this feature would make it easier for users who are concerned with battery life to auto disable the VPN when it isn't necessary to be connected.


WIP: Export / import RSA to / from provider

This lays the foundation for transferring RSA keys to / from providers.
It goes with the idea of using multiple OSSL_PARAM items with the same key to pass multiple primes, CRT exponents and CRT coefficients, and in doing so, simplifies it by making p and q part of the primes (they are the first two), dP and dQ part of the CRT exponents, and qInv part of the CRT coefficients.  Extra RSA functionality is added to support this.

[x] documentation is added or updated (for the extra RSA functionality)
[x] tests are added or updated (for the extra RSA functionality)

The reason I'm making this a separate PR is because the same kind of work exists both in an upcoming key generation branch I'm working on and in @mattcaswell's #10152, and that part of the work should be synchronised, at least with regards to export/import.

Keep in mind that in fips mode multiprimes are not supported.
see the #ifdef FIPS_MODE in rsa files.
e.g: rsa_builtin_keygen

Sure, but that will be for key generation in the provider, no?  Or should the import functions do some extra checks?  But in that case, shouldn't the RSA functionality simply refuse working with multi-primes when FIPS_MODE is defined, going so far as disabling RSA_set0_multi_prime_params() completely?  That's not what happens now.

Fixing the multiprime issue with FIPS is for another PR, methinks.

I added an internal keymgmt tester, test/keymgmt_internal_test.c, which tests that pushing around an RSA key through two providers (thereby exercising both import and export of key data) works as intended (it retrieves the numbers from the last provider instance and compares them to the original numbers).

Not WIP anymore

Let's see if a kick helps

Yup, it did

Most concerns answered, https://github.com/openssl/openssl/pull/10190#discussion_r335904628 unresolved, and rebased.

Rebased on a fresher master.  That's a moving target!

Merged.  Pfew!  Thanks for the thorough review!
c3a4fa4cb849ba300d4691154c0c12ac19d24710 Added internal functions for easy getting and setting all RSA parameters.
29be60235b9bf86bb38f28349b405bb112250d4b New RSA keymgmt implementation to handle import / export of RSA keys
5a02d13d3e274748c695bfe19238f885489e021e test/keymgmt_internal_test.c: New test of keymgmt internals
651101e18d66b2ae89851ce8906299e9d2a871e0 evp_keymgmt_export_to_provider(): adjust OSSL_PARAM array for transfer

To make sure I understand: in the non-multiprime case you have several stacks of one entry.
In the multi-prime case you have to iterate through all the stacks in parallel?

In the 2-prime case, the factors or primes stack has two numbers (commonly known as p and q), the exps stack has two numbers has two numbers (commonly known as dP or dmp1, and dQ or dmq1), and the coeffs stack has one number (commonly known as qInv or iqmp). Whether you are building a 2-prime or a n-prime key, processing them in parallel is more practical because of the way the RSA structure is constructed (which, BTW, is directly related to the ASN.1 spec)

thanks.  dees coeffs have to be a stack?

It's more practical that way, for where those functions are used.  For n-primes, there's more than one, and I see very little benefit in special-casing 2-prime keys.

I missed the "for n-primes" part.  Thanks again.


feat: add json data type

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#3686 #4515
What's changed and what's your intention?
As title. Currently the datatype can store json strings as jsonb format. Also I've added a simple udf to query json through a path.
e.g.

TODO:

Convert binary to string while query json directly. Currently the json data is presented just as binary data.
GRPC related work.

Checklist

[ ] I have written the necessary rustdoc comments.
[ ] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

The CI is failed, try make fmt-toml

@coderabbitai review

A great work!
I don't like the name get_by_path, it's too long. What about jq? just like the command line tool https://jqlang.github.io/jq/
And i found that databend is using this name too.

What about jq? just like the command line tool https://jqlang.github.io/jq/

Sure, it's a good name if there are already some conventions :)

@WenyXu @killme2008 Hi, I've resolved some bugs and made some changes, PTAL :)
Changes:

Added a type extension in proto to identify the json type from binary type in proto messages. See https://github.com/GreptimeTeam/greptime-proto/pull/188 for changes in proto.
Removed the unused Value(Json) and made use of current Value(Binary) as the underlying representation of values of json type.
Deleted the udf. Leave it with future PRs about udfs.
Prohibited to directly insert into json with hex strings e.g. X'abcd'. Now it should only accept plain strings.
Fixed and added some unit tests.

Rest LGTM

Hi @CookiePieWw, there are some conflicts

Nice job!


Minimum gpu memory to run evaluation?

Hi,
I'm trying to run the evaluation through run_evaluation.sh on a RTX 3070Ti GPU but the GPU ran out of memory during loading the models, can you share your evaluation setup? Do you have a brief sense about how much GPU memory is needed for running such experiments?
Thanks.

Hi!
I ran the evaluation on a 3090. I tested it just now and it needed 18567MB GPU memory. I suggest that you run the Carla on the local PC (with a screen) and run the model on the remote GPU server. They can communicate with each other through the network. You can find the related settings in the run_evaluation.sh

Thanks for your fast response. I have a quick follow-up question: Does the current script allow using multiple GPUs if a single GPU's memory is not sufficient (e.g. I have 4 GPUs with 8GP memory each but not one 3090 with ~20G memory)?

Sorry, the current script doesn’t support this feature. But the model (w/o
the Carla server) only consume about 14g memory, and 16G v100 is enough.
Maybe quantization can be applied to reduce the gpu memory requirement.
Ruiyang Zhu @.***>于2024年1月12日 周五14:03写道：

Thanks for your fast response. I have a quick follow-up question: Does the
current script allow using multiple GPUs if a single GPU's memory is not
sufficient (e.g. I have 4 GPUs with 8GP memory each but not one 3090 with
~20G memory)?
—
Reply to this email directly, view it on GitHub
https://github.com/opendilab/LMDrive/issues/12#issuecomment-1888485423,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFTRR6EPWK2SR5YIC4BZQDYODG4NAVCNFSM6AAAAABBXQ2X42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBYGQ4DKNBSGM
.
You are receiving this because you commented.Message ID:
@.***>

Thanks for your answer. For "running the Carla on the local PC (with a screen) and run the model on the remote GPU server", I tried to look at leaderboard/scripts/run_evaluation.sh but do not seem to find any related network settings to run the model on the remote GPU server. Can you give me some more pointers on where I can set the configurations to run the models and communicate the results through network? Thanks!

Can you give me some more pointers on where I can set the configurations to run the models a

You can add the parameter HOST in run_evaluation.sh and add --host=${HOST} when calling the python script.

Thanks for the instruction. Would that mean 'run the carla server (CarlaUE4.sh)' on a local PC and run the run_evluation.sh on a remote GPU server (by setting the HOST to be the IP of local PC)?
I tried that setup, but what about the pygame window that will pop up during the evaluation of run_evaluation.sh? I got some errors in that part:
========= Preparing RouteScenario_6 (repetition 0) =========
> Setting up the agent
ALSA lib confmisc.c:855:(parse_card) cannot find card '0'
ALSA lib conf.c:5178:(_snd_config_evaluate) function snd_func_card_inum returned error: No such file or directory
ALSA lib confmisc.c:422:(snd_func_concat) error evaluating strings
ALSA lib conf.c:5178:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1334:(snd_func_refer) error evaluating name
ALSA lib conf.c:5178:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5701:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2664:(snd_pcm_open_noupdate) Unknown PCM default

I had same doubt about pop up of pygame window ....How can we do so ?


Document xticks and yticks plot options

Hi,
Is it possible to rename the axes tick labels such as in Bokeh? Ex: p.xaxis.major_label_overrides = {0: "zero", 5: "five", 10: "ten"} would replace given x axis integer tick labels with strings.
I could not find anything in the documentation. Thanks,
Derek

If I remember right, you can use a similar format for the xticks plot option, but it might be a list of tuples to keep the order. One example of using xticks (without custom labels) can be found on this page.

There is at least one exception to this:
the matplotlib backend with projection=polar does not conform.

Thanks guys for the feedback!

Follow up question @philippjfr : are xticks controls compatible with Bars?
hv.Bars(range(10)).options(xticks=[(0, 'zero'), (5, 'five'), (8, 'eight')])
Gives me:
'Javascript error adding output!
TypeError: a.mids is undefined
See your browser Javascript console for more details.'

This is documented here: http://holoviews.org/user_guide/Customizing_Plots.html#Axis-ticks


Terminal doesn't start with non-informative error message "THE service had not been started"

Windows Terminal version (or Windows build number)
1.8.1444.0
Other Software
No response
Steps to reproduce
I guess; have a Microsoft Store that is unable to download apps for some reason (Error 0x800706d9), download the msixbundle and install via powershell
Expected Behavior
Normal start
Actual Behavior
Error message with path to WindowsTerminal.exe and "The service had not been started".
Please tell me what THE service is. -.-
Note: It isn't the touchscreen service and I can't find one with "terminal" in the name.

What version of Windows are you using? Did you already run dism and sfc as per the usual Windows repair guidelines?
The services Windows Terminal (WT) depends on are, what I would consider, "system critical". If they're stopped something's wrong with your Windows installation entirely and not just WT in particular.

According to https://github.com/microsoft/terminal/issues/7442#issuecomment-682342432, appxsvc or wlidsvc may be required.

appxsvc and wlidsvc

Oh my god. I can't believe it was this easy. I've had this issue for more than a year and even asked tier 2 Microsoft Support for help... WTH??!?! Why is nobody writing that the Store login stuff needs this service? I can't even... Thank you SO much ^^
BTW I deactivated this service myself at some point, so I myself am entirely responsible for my misery.
For Google'in ppl: Microsoft Store error 0x800706d9 when trying to log in or download app. MS store app error 0x800706d9 bla bla god I can't believe it

Interesting. If you go to the "All Apps" page, then select Terminal and click Repair, does it work?
If not: have you changed the permissions on C:\Program Files\WindowsApps?

Interesting. If you go to the "All Apps" page, then select Terminal and click Repair, does it work?
If not: have you changed the permissions on C:\Program Files\WindowsApps?

No :(
I uninstalled it and tried installing it via the Store, but I get Error 0x80072EE7 while it says "Aquiring license". What license? Just a general software license? How is this aquired? Maybe I blocked something somewhere. Apps update fine, but I can't install new ones. :(
Firewall is off, VPN is off, the troubleshooter can't find the issue... I don't know

@LtqxWYEG 0x80072EE7 means it failed to find the given server address. Basically something's off with your DNS, or your firewall.
There are probably people who know how to fix this issue. Maybe even in this thread!
But if no one comes up with anything later, I think it might be a good idea for you to consider to run "Refresh your PC". You can also use "Reset your PC" to be absolutely sure (it'll delete all your files though). But if you do any of those options you should backup all your files just in case.
Either way it's possible that someone has an idea how to fix it, but I personally consider it somewhat unlikely.
You can try waiting a bit until someone writes here, finding a solution using Google, or Refresh/Reset your PC.

I use either VPNs DNS, which never gave me issues, or <IP_ADDRESS>. That should not be the issue
Hosts file is empty.
I try a in-place upgrade first. I've got hundreds of programs installed...
I'll edit this or create a new comment when I'm done
However the current issue is still that I get the error "File system error (12007)" when i start terminal - if installed manually via msixbundle. I don't think both issues are connected

@LtqxWYEG It's unknown how complex the cause for your issue was. For all we know it could have even been an incredibly corrupt Windows installation for instance. Windows has a lot of moving parts and is a large OS; it's not unthinkable that diagnosing the issue takes much longer than reinstalling the OS.

I'm glad that your issue was resolved!


Add mobile developer options

Turn settings into a destination and add dev settings by clicking 8 times on the version.
Not much inside these settings yet but more will come.
Closes #374

nice!


New package: EEGToolkit v1.0.0-DEV

Registering package: EEGToolkit
Repository: https://github.com/slopezpereyra/EEGToolkit.jl
Created by: @slopezpereyra
Version: v1.0.0-DEV
Commit: 5d92e792fd1bc8c29ce9114bfe18f07ffe83a3d9
Git reference: HEAD
Description: A Julia package for computational EEG analysis ~ With special tools for sleep neuroscience!

I fail to comprehend what the meaning of

Version number is not allowed to contain prerelease data

and

The following dependencies do not have a [compat] entry that is upper-bounded and only includes a finite number of breaking releases: CSV, DSP, EDF, FFTW, Plots

How can I fix this?

Version number is not allowed to contain prerelease data

You have to set the version in the Project.toml of your package to 0.1.0 (or whatever version you want, but, 0.1.0 would be the usual choice for an initial registration). You cannot have -DEV in your version.

The following dependencies do not have a [compat] entry

In your Project.toml, for every package that is listed in the [deps] section, there must also be an entry in the [compat] section, e.g.,
[compat]
DSP = "0.7"
EDF = "0.7"
FFTW = "1.8"
Plots = "1.40"
julia = "1.6"

How can I fix this?

Modify your Project.toml, commit, and then re-register. Because the version number has to change, this will open a new registration pull request, and we'll close this one.

Thanks @goerz. This pull request can be closed - the new one is here


How to change the kismatic-cluster.yaml file and install again?

already installed kismatic，but i changed the file kismatic-cluster.yaml，and install again there is the error：
Running Smoke Test==================================================================
1/2....  Configure Cluster Prerequisites                                        [OK]
2/2....  Smoke test Master Nodes
- Running task: run smoke test checks using Kuberang
  master                                                                        [ERROR]
---- STDOUT ----
Configured kubectl exists                                                       [OK]
Nginx service does not already exist                                            [OK]
BusyBox service does not already exist                                          [OK]
Nginx service does not already exist                                            [OK]
Issued BusyBox start request                                                    [OK]
Issued Nginx start request                                                      [OK]
Both deployments completed successfully within timeout                          [OK]
Issued expose Nginx service request                                             [OK]
Grab nginx pod ip addresses                                                     [OK]
Grab nginx service ip address                                                   [OK]
Grab BusyBox pod name                                                           [OK]
Accessed Nginx service at <IP_ADDRESS> from BusyBox                            [ERROR]
Accessed Nginx service via DNS kuberang-nginx-1480391347229869713 from BusyBox  [ERROR]
Accessed Nginx pod at <IP_ADDRESS> from BusyBox                               [OK]
Accessed Nginx pod at <IP_ADDRESS> from BusyBox                               [OK]
Accessed Google.com from BusyBox                                                [ERROR IGNORED]
Accessed Nginx service via DNS kuberang-nginx-1480391347229869713 from this node[ERROR IGNORED]
Accessed Nginx pod at <IP_ADDRESS> from this node                             [ERROR IGNORED]
Accessed Nginx pod at <IP_ADDRESS> from this node                             [ERROR IGNORED]
Accessed Google.com from this node                                              [ERROR IGNORED]
Powered down Nginx service                                                      [OK]
Powered down Busybox deployment                                                 [OK]
Powered down Nginx deployment                                                   [OK]
---- STDERR ----
Error running command: One or more required steps failed
---------------
error during smoke test: error running smoketest: error running playbook: error running ansible: exit status 2

What kind of changes did you make in the plan, are you using new infrastructure or reusing the existing machines from a previous install?

@dkoshkin  i changed the "load_balanced_fqdn",and reused the existing machines from a previous install.

@pennpeng You might be able to re-run apply, but we do not optimize for this. You might have to use the --skip-preflight flag and also --restart-services. Keep in mind that this will restart services and will incur downtime. This is not recommended for a production cluster.


mbed update has unexpected behaviour with caching enabled

I have some config set:
$ mbed config -L
[mbed] Global config:
CACHE=/var/mbed
PROTOCOL=ssh

If I pick a project I have used before, that has had numerous commits since the last time I used it, and do mbed import, mbed correctly imports from the cache.
This means that when I do mbed update master, mbed does fetch the remotes correctly, but it doesn't update the local branches, so master is the master that was in use when the cache was populated.
If caching were turned off, this behaviour would be completely different, fetching the tip of master, from when I did the import.

@bremoran Thanks for the bug report. Can you please try PR #462?

@bremoran Bump :)

@bremoran could you please try to reproduce with mbed CLI v1.1 (latest) ?


Nothing happens

When I run electron-screen-recorder, the Electron icon appears in the dock, but there is no application window, no menubar icon... nothing is happening from what I can tell. Am I doing it wrong?
❯ uname -a
Darwin C02R41WSFVH8 16.3.0 Darwin Kernel Version 16.3.0: Thu Nov 17 20:23:58 PST 2016; root:xnu-3789.31.2~1/RELEASE_X86_64 x86_64

❯ node -v
v7.2.1

❯ npm -v
3.10.10

@zeke Thanks for the report, it should work now. You can install the latest version via npm install.


[runtime][hip][cuda] Failures don't propagate to semaphores that need to be signaled

I noticed that in the HIP and CUDA drivers when an execution operation fails, the list of semaphores that are to be signaled on completion are not failed. This will then cause downstream semaphores to hang. They will be waiting on the not properly failed semaphore, which will never signal.
I am preparing a patch for this.

See also https://github.com/iree-org/iree/issues/17834#issuecomment-2218494783 and this discussion on Discord for how we might write CTS tests for failure signaling.

#18095 fixes this. iree-run-runtime (the VM) would not give a good error message when a HAL fence await fails. It will not query the failed semaphore(s) for their errors and show them. At least we will not hang forever.


New build error

Hi @j-mie6
Sorry to be a pain but I've just tried setting up a fresh project to use Parsley and I'm running into a build error on this rangset dependency. Bashed my head against it for a while and I just can't fathom what is going wrong! Any help / ideas would be much appreciated.
Error log from cabal:
Preprocessing library for rangeset-<IP_ADDRESS>..
Building library for rangeset-<IP_ADDRESS>..

src\ghc\Data\RangeSet\Internal\Types.hs:1:7: error:
    lexical error in pragma at character '1'
  |
1 | {-# LANGUAGE DerivingStrategies, RoleAnnotations, CPP, Trustworthy #-}
  |       ^

src\ghc\Data\RangeSet\Internal\Heuristics.hs:1:7: error:
    lexical error in pragma at character '1'
  |
1 | {-# LANGUAGE BangPatterns, MagicHash, CPP #-}
  |       ^

src\ghc\Data\RangeSet\Internal.hs:1:7: error:
    lexical error in pragma at character '1'
  |
1 | {-# LANGUAGE MagicHash, UnboxedTuples, MultiWayIf, BangPatterns, CPP #-}
  |       ^

I'm guessing those error locations are garbage because they aren't accounting for whatever the preprocessor might be doing?
Platform: Windows, 64-bit, AMD
I installed GHC/etc. using GHCUp:
ghc: 9.2.7
base: <IP_ADDRESS>
cabal: <IP_ADDRESS>
Packages from Hackage:
parsley: <IP_ADDRESS>
rangeset: <IP_ADDRESS>
Please let me know what additional info would be useful.
Ed

My only guess would be that you need the cpphs build tool installed (which is in the cabal file): it replaces the normal GCC preprocessor, which might be causing this. But cabal should be doing that for you, given that it's in the cabal file. I've built rangeset itself with that configuration and it seems fine on my end (but with WSL2). I'll try and build parsley as well with the same config

Parsley also built under that configuration...

What I could do is remove the CPP from rangeset, if I split off the one source file that needs it into two source directories (like I do with parsley-core)... I'll do that now and cut a new release.

Huh, that gives me an idea, maybe this is a PATH issue..!

Thanks, I'll have a run at it on Monday with the split version and see if it works. I was able to reproduce the issue just trying to build the package (from the Hackage source tarball) so should be able to see if potential fixes work without having to go via my project/parsley.

rangeset-<IP_ADDRESS> released.

Yes that release fixed it for rangeset, but as you predicted, parsely-core results in the same issue!
Hmm, I wonder what in GHC 9.2 is broken on Windows (MinGW) but not on WSL2 / Linux native.
Is upgrading to a more recent GHC an option (if that would fix it)?

(Btw, I have just now switched to GHCUp on WSL2 and it compiled with no issue. So yes, this is definitely something odd with GHC 9.2.7 on Windows)

A downgrade may also be an option: 8.10.7 perhaps, or 9.0. I've fallen a bit behind with ensuring compat so I'm not sure if parsley-core is working on 9.4/9.6 yet. The garnish is still blocked hard on 9.0 iirc, because it needs to be entirely rewritten 🙄

Windows + GHC has always been rather shaky. I think people still say the value in 8.6.5 remaining supported is it's an actually good release on Windows


User name is not avaiable in the My Account

Describe the issue:
After login to the myaccount username is not visible.

How to reproduce:
Login to the My Account and click on profile

This issue is fixed in the latest identity-server hence closing the issue.


How can a task pass a value to next task

Hi there,
I am testing the tool, I like the simplicity very useful. Thank you.
I want to know if there is a way to store output from a task to use in the next task in the same recipe?
Hope you can help me.
Regards,
Julio

Hi, currently it's not possible but it's on the TODO list https://github.com/alajmo/sake/issues/16

If it's a non-secret value, could you echo it to a /tmp file at the end of task 1 and then cat that file into a variable at the start of task 2?

Well it's possible to do something like this:
tasks:
  pass-env:
    tasks:
      - cmd: echo hello > /tmp/some-env
      - cmd: cat /tmp/some-env

$ sake run pass-env

 Server   | Output | Output
----------+--------+--------
 server-1 |        | hello

But it's not pretty and I'm looking into something more user-friendly. With this solution, you would need to clear the tmp file after each run manually (so as not to have a stale state).

thanks! that was my first guess I was thinking more for having conditional tasks, this is also working.


is it possible to make conv_offset_mask conv shared when using groups != 1, i.e., when using group convolution.

@CharlesShang


docs: add other required fields to user setup for clustered

Hey team! A customer attempted to use azure docs during clustered set up and ran into an issue with the current code example for setting azure users in the appInstance. I've added the rest of the fields as required (similar to keycloak).
I see there is this PR out for reorganizing the clustered docs, so maybe it can be done there to avoid conflicts? Let me know the best way forward, thanks!

[ ] Signed the InfluxData CLA
(if necessary)
[ ] Rebased/mergeable

@sanderson Hey Scott, just a note on this that @eatondustin1 brought up to me. While it's true that the email can be arbitrary for auth purposes, for any auditing the customer wants to do - they should probably use a valid email/identifier so any actions that track the user who initiated it can be audited later.


Adding Google Tag Manager feature

Let's add Google Tag Manager to the main template.
I prepared account with ID GTM-WGQ7T9C.
Here's official documentation for installation - https://developers.google.com/tag-manager/quickstart.
Can anyone help me with this?

I've dive deep into this issue and searched something like this: https://github.com/mib200/vue-gtm Don't know if this plugin worth to implement but seems to do what we want. The question is which tags and events to trigger.
I've tried to add it on local (pushed one commit with an implement on my fork) but found one problem. In REAMDE author said we must copy/paste GTM tag in our index.html and it seems to be ok but how to call the google tag id from config here? Of course, it can be some other idea to deal with it but don't find anything

@kjugi thank you for the suggestion.
From my point of view the best would be creating an integration with already predefined GTM data layer for ehanced ecommerce for Google Analytics (then we could even skip #839 issue). The shape of the data layer is explained here https://developers.google.com/tag-manager/enhanced-ecommerce.
@pkarw @filrak WDYT about https://github.com/mib200/vue-gtm and what @kjugi and I suggested?

You should create a component for this I belive please take a look at analytics extension as a reference

Any update on this? Is it paused? I tried the code but it's failing for me. Something with the router that is passed that breaks i think. Would also be nice to get the correct DataLayer implemented on atleast products and category pages.

I’ll continue on this in the weekend, yes sure data layer will be implemented

@talalus thanks for that and thanks for the answer! :) 👍

This would be a much-appreciated function for us marketing people. Would be very exciting to see GTM working on Vue-storefront

merged with develop

Is there any documentation for tag manager ?

@jsxFardin

Google Enhanced Ecommerce docs: https://developers.google.com/tag-manager/enhanced-ecommerce
Vue-gtm docs https://github.com/mib200/vue-gtm
You can find current tracked events here

@talalus
I set the googleTagManager id in local.json. but still not working.
 "googleTagManager": {     "id": "GTM-NXN59JK",     "debug": true,     "product_attributes": [       "name",       "id",       "sku",       {         "priceInclTax": "price"       },       {         "qty": "quantity"       }     ]   },

@jsxFardin The GoogleTagManagerModule is not registered by default so you need to:

import it in https://github.com/DivanteLtd/vue-storefront/blob/master/src/modules/client.ts#L13
register it in https://github.com/DivanteLtd/vue-storefront/blob/master/src/modules/client.ts#L37


Documentation is off for import

Just a heads up, your documentation is showing a lowercase g
import { Ng2Validators } from 'angular2-validators';
when it should be uppercase
import { NG2Validators } from 'angular2-validators';
Thanks!

Thanks @alexrindone

Thanks @alexrindone


[$250] The ‘Multiple users are typing’ vertical text alignment is incorrect

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open group chat as user A
Type as User B on another device
Observe underlying "typing..." display as User A
Type as User B and User C on 2 different devices simultaneously
Observe underlying "typing..." display as User A

Expected Result:
Text should be aligned
Actual Result:
The ‘Multiple users are typing’ vertical text alignment is incorrect. When a single user is typing the text remains centered, but when multiple users are typing the text becomes uncentered:
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:

Where is this issue occurring?

Web
Desktop App

Version Number: 1.1.88-14
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/186073675-03975813-c8ee-42ad-a242-9d17e9a94583.mov
Expensify/Expensify Issue URL:
Issue reported by: @Julesssss
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1660833359041749
View all open jobs on GitHub

@robertjchen I'll take this as I'm on the C+ team, and reported the issue.

Upwork Job

Not overdue, the PR is being drafted. When do you think it will be ready for review @mdneyazahmad ?

This issue is no longer reproducible in the main @parasharrajat!

Should be resolved this PR https://github.com/Expensify/App/pull/10591

But still, the changes proposed here are worth doing as they are missed out while refactoring is done here.

The issue is resolved for me too:
https://user-images.githubusercontent.com/10736861/190142935-06a425d0-8537-4feb-a8b5-8b26db05fc99.mov

But still, the changes proposed here are worth doing as they are missed out while refactoring is done here.

@Santhosh-Sellavel would you mind reminding me why that is?

@Julesssss
Ah Sorry, I missed sending this earlier. The issue might still occur in mobile native  &  mWeb apps.
https://user-images.githubusercontent.com/85645967/190144467-1637a28c-c34f-44e0-a375-8cd0ccc4560a.mov

So will @mdneyazahmad 's PR fix all cases? If not, how should we move forward here?

@MitchExpensify yeah, I believe this is a full solution. Hey @mdneyazahmad, are you able to go ahead and submit the PR? Thanks!

It looks like there's an ongoing discussion in the PR review.

Hey @mdneyazahmad, there are some outstanding comments in the PR, are you able to take a look? Thanks!

Sorry for the delay. I will update it sometime today. Thanks!

Any update @mdneyazahmad ?

@MitchExpensify PR is deployed on staging https://github.com/Expensify/App/pull/10790#issuecomment-1289804155

Not overdue, awaiting payment

Oh cool, it's the second today. Is that why the label changed priority? 🤯

I had to repost the job and have sent you both offers @parasharrajat & @mdneyazahmad. Will pay and close this once accepted! Thank you

Paid! Thanks all


Line wrapping problem during using ssh under Windows.

Describe the bug
I've installed OMZ on my server, and it works well when I log in with ssh under Mac OS.
However, when I use any kind of command line tools under Windows to log in my server, the prompt always breaks into two lines, also, it usually messes up the type-in area.
To Reproduce

Use CMD or Powershell
Log in a server with ssh
The bug should be obvious

Expected behavior
The exact one-line prompt
Screenshots or recordings

System:

OS: Ubuntu 19.04
Zsh version 5.5.1
Terminal emulator Powershell, Fluent Terminal, CMD

Well, I didn't really "solve" this problem. Since I've tested a few terminal emulators I could find, I found that not all the Windows-based terminal emulators have the same situation, some of them actually work well(while there's no one can show prompt and glymphs correctly at the same time). So, obviously, it's not a "bug" made by OMZ or the theme I use on OMZ(Powerline9K). It seems to be a typical problem on Windows-based terminal emulators, most of which are unable to render double-width glymph and calculate the prompt width correctly, which's discussion could be found at the issues of Powerline9K.


rancher_max_version set for older versions of monitoring and istio is not being applied

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Deploy a cluster in a new Rancher setup of v2.3.0-rc3

Expected Result:
Monitoring and Istio should show only the valid chart versions.
Actual Result:
When you navigate to cluster --> Tools --> Monitoring or Istio, all the 4 (Monitoring) / 2 (Istio) chart versions are seen.
Note:
This does not happen always.
Leave the setup around for sometime. DO NOT do a hard refresh of the page. Then again navigate to cluster --> Tools --> Monitoring or Istio. All the charts versions will be displayed..
ON doing a hard refresh of the page, only 1 chart version is displayed for both monitoring and Istio.
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.3.0-rc3
Installation option (single install/HA): single

After discussing this with @vincent99 this should be a change in the UI to filter out the versions not compatible with that version of rancher.

The problem is there's no connection between asking for templates within this range in the initial list call and what comes down the socket.  So rather than having the server do that filtering (half the time) I suggested the UI just get them all and decide which to show on its own.
But that doesn't actually work, each templateVersion has a different valid range and the reason the server filters it is so that we can load just /v3/templates and get back the set of valid versionLinks for that range without having to load the entire (huge) set of /v3/templateVersions (or making n+1 calls to verify individual versions)
Soo... I think we need to go back to (stay on) server filtering:

/v3/templates should only return versionLinks for versions which are satisfied by the current Rancher version.  You can add a secret ?all flag if you want but I don't think there's any use case requiring it.

Drop/ignore the query param that the UI uses to pass in the server version.  You already know what version you are. (this is historical baggage from catalog being an independent microservice in 1.x)

Suppress change events for any templateVersion that does not satisfy the current server version.

/v3/templateVersions and /v3/templateVersions/:id should still return ALL the versions (so that if you have an App that already exists the UI can get info about the version and its upgrade links, even if it's now incompatible with the running Rancher version)

verified on rancher:v2.3.0-rc4.

Bring up an rke cluster.
After the cluster is Active state, go to Cluster --> Tools --> Monitoring/Istio.
Verified that only one version is seen, which is applicable for the rancher version.
Leave the setup around for sometime. (no hard refresh)
Navigate to Cluster --> Tools --> Monitoring/Istio.
Verified that only one version is seen, which is applicable for the rancher version.


Update CDVAssetLibraryFilesystem.m

Usage of malloc will lead to heap overflow attack due to insecure coding, Should be usage calloc!

Can you provide me the source of your information where it says that malloc will lead to a heap overflow attack and that calloc should be used instead to prevent this?
As far as I understand, both malloc and calloc can have a heap overflow attack if not used properly. It does not matter which one is used.
One of the main differences between malloc and calloc is that calloc will initialize the allocated memory to zero.
Using one over the other I believe is more an opinion I feel, or based on the type of use case. For example, if we do not need to read memory before writing, malloc is OK to use because it is expected to initialize it before reading.
I am trying to understand why you are saying that the original implementation (malloc) will have a heap overflow attack and that your single change to calloc will solve it.
Another source had also pointed out that:

calloc is automatically emptied after allocation, which is fatal for the exploitation of certain information disclosure vulnerabilities.

Which does not sound any better.

Hi @erisu, firstly thank you for your hard work for this plugin.
i not sure by what he mean but i do have a problem regarding malloc or calloc usage. after our security team do security checking they mention and ask us to use calloc instead of malloc. i did advise them that there is not much different between both but they still want us to change it to malloc to calloc. The reason they said its for better memory management.
Can i get any confirmation that changing like @a51095 suggested will not make the plugin crash or lead to another problem?


Add doc comment about potential of events to arrive out of order.

Motivation:
This has come as a surprise to at least one person and is easy to forget.
Modifications:
Doc commented added at the top of ChannelPipeline.
Result:
Docs are clearer.

Resolves https://github.com/apple/swift-nio/issues/1607

Interestingly commit comments seem to disappear when multiple people suggest changes to the same line.  I've corrected both typos though.
The multiple space thing comes from being old - it's what we used to do.  I was going to accept the changes but then I noticed that the comments above this area formatted the same way so I'll leave for now so at least the file is consistent with itself.


Adding hls-lfcd-lds2-driver to documentation index for distro

I'd like hls-lfcd-lds2-driver to be indexed and documented on ros.org.

I'd like hls-lfcd-lds2-driver to be indexed and documented on ros.org.

Replaced by: #17890


Add link to isaacbrodsky/h3measurements

Coverage remained the same at 100.0% when pulling db2236297834f70d748c8855d07b0ee6236dd80e on isaacbrodsky:add-h3measurements into 5a55394937466f6d8b50e2da62813db29f40bdd0 on uber:master.


Add wemux

https://github.com/zolrath/wemux

https://github.com/tmuxinator/tmuxinator

https://github.com/tmux-plugins/tmux-resurrect

Use one of the following (or pull code from them):

https://github.com/gpakosz/.tmux
https://github.com/tony/tmux-config
https://github.com/square/maximum-awesome

and let's not forget https://github.com/edkolev/tmuxline.vim

https://github.com/tmux-plugins/tmux-continuum


@apply issue with mx-auto

I just updated to v0.4.0, and am now getting an error on with @apply and .mx-auto
`@apply` cannot be used with `.mx-auto` because `.mx-auto` either cannot be found, or it's actual definition includes a pseudo-selector like :hover, :active, etc. If you're sure that `.mx-auto` exists, make sure that any `@import` statements are being properly processed *before* Tailwind CSS sees your CSS, as `@apply` can only be used for classes in the same CSS tree.

The class I'm using it on is as so
.page > * {
  @apply .max-w-md .mx-auto .px-9;
}

which is below both @tailwind preflight and @tailwind utilities
I've also tried just using the .mx-auto class in the html, yet that doesn't seem to be working either.

See the upgrade notes. You'll need to add auto to the tail windows config.


Exclude deleted files when running --staged

What
Excludes deleted files from being included when using --staged argument.

fixes: https://github.com/skryukov/rubocop-gradual/issues/26

Thanks! ❤


Update from base

@awadhesh22791 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


can the graphite version be updated again?

Hello, i see the current version of graphite is ~9 months old GRAPHITE_VERSION=7ebde4c60 . Can the graphite version be updated to the latest version again? There are some recent changes we would like to get.

definitely, that was on my list of things to do and I'll get to it soon

definitely, that was on my list of things to do and I'll get to it soon

hello, is there any timeline for this?

Hi, we have just pushed new images to https://hub.docker.com/r/raintank/graphite-mt/tags
the last one at this time is 9-cc00aa18ae-rebase-v2


File based config

Settings are now loaded using the data/settings.yml file.
This is a fix for this issue: https://github.com/scrapinghub/dateparser/issues/54

@MojoJolo please merge latest master, it has a new configuration SKIP_TOKENS.

@waqasshabbir merged it.

@waqasshabbir sorry, forgot to place it in settings.yaml

Thank you @MojoJolo!


Quarto render command launches before conda activate in terminal

When I click the Render button with a conda environment it launches a terminal then:
> C:/ProgramData/mambaforge/Scripts/activate

(base)> quarto preview "path/to/file.qmd" --no-browser --no-watch-inputs

So my conda env doesn't get selected. When I stop the command with ctrl+C:
> C:/ProgramData/mambaforge/Scripts/activate

(base)> quarto preview "path/to/file.qmd" --no-browser --no-watch-inputs

^C

(base)> conda activate MyEnv

So it wants to launch the correct conda environment but for some reason launches the quarto command before the conda activate command
System info:
Windows 10
Quarto cli: 1.2.269
Quarto VSCode: v1.54.0
VSCode: 1.73.0

We actually have code that attempts to wait for the terminal to go idle so that that conda activation occurs before we run the Quarto command. We are doing everything we can to wait so if the activation is somehow getting in front of us I'm not sure what the recourse is.   If C:/ProgramData/mambaforge/Scripts/activate is NOT what you need activated you may want to check your VS Code settings for the active Python interpreter (See the "Python: Select Interpreter" command and note that there are global and per-workspace settings that may be in play).

I think the problem is that VS Code first wants to 'activate' conda by running the command C:/ProgramData/mambaforge/Scripts/activate. Then quarto listens that the terminal is free but a second conda command needs to launch (the conda activate MyEnv).
I do not know why VS code wants to launch 2 separate commands for conda but I will check it out.

Okay, we have the ability to wait for one command but not for two (unless we just put the second on a timer -- not elegant but perhaps a brute force solution that world work?).

I will investigate further because I too do not quite understand why vs code launches 2 commands - might be possible that my conda setup is a bit non-standard (I use mamba variation)

Ok, I reinstalled standard miniconda and for some reason I have the same error. It tries to launch:
C:/ProgramData/miniconda3/Scripts/activate

then:
quarto preview "path/to/file"

and when it fails (because of the lack of jupyter kernel in the "base" conda env):
conda activate myenv

I don't know why it first "activates conda" and then "activates myenv" instead of running "activate myenv" in the first place. No other terminal does that, they all just run conda activate myenv

Ok, I reinstalled standard miniconda and for some reason I have the same error. It tries to launch:
C:/ProgramData/miniconda3/Scripts/activate

then:
quarto preview "path/to/file"

and when it fails (because of the lack of jupyter kernel in the "base" conda env):
conda activate myenv

I don't know why it first "activates conda" and then "activates myenv" instead of only running "activate myenv". No other terminal does that, they all just run conda activate myenv at startup.


Ensure lean releases

Excludes unnecessary files from releases/distributions.

Looks good but please add yourself to the list of contributors

And that's done how and where?

Oh I'm sorry I missed to tell you that the list of contributers is stored in README.md. Currently in develop branch.

Wondering why this is (or should be) required, as the list of contributors is available via GitHub's Graphs > Contributors tab.

I'm fine if you don't want to be on that list. It's just an offer.

Sorry wrong button


Anyone else can't view this video when YTC is enabled?

https://www.youtube.com/watch?v=kspUer5kTi4
YTC disabled, video loads fine.
YTC enabled, it switches to Flash Player, then Flash Player loads indefinitely.
When trying to download the video using YTC or Download Youube Videos as MP4, it says the video can't be read because of a network error. Complete YouTube Saver also fails.
If this can help, the download URL for 360p MP4 is:
https://r2---sn-4g57knze.googlevideo.com/videoplayback?source=youtube&initcwndbps=765000&dur=242.439&nh=IgpwcjAxLmZyYTAzKgkxMjcuMC4wLjE&fexp=9406006%2C9406715%2C9408710%2C9408863%2C9409069%2C9409208%2C9414875%2C9415365%2C9415435%2C9415485%2C9416023%2C9416126%2C9416729%2C9417689%2C9417701%2C9417707%2C9418153%2C9418918%2C9418959%2C9419290%2C9419306%2C9419404%2C9419446&expire=1439944057&mm=31&itag=18&signature=48B0D772B12A391442B95F239F97A643E3C78C75.1FD66D0761392BDF661D9512C620B9C19B4BF5AE&requiressl=yes&ms=au&mt=1439922322&sparams=dur%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cnh%2Cpl%2Cratebypass%2Crequiressl%2Csource%2Cupn%2Cexpire&mv=m&id=o-ADNNNbm1UOZ6cgOT4d4BY_UYMbPLTVSN1WNwy5-sNIyC&mime=video%2Fmp4&pl=17&sver=3&ip=<IP_ADDRESS>&key=yt5&mn=sn-4g57knze&ipbits=0&ratebypass=yes&lmt=1404580429524818&upn=kidZRt87ftQ&title=Speed%20Freaks%20-%20Track%206%20-%20City&cpn=DYfr5h90__I81H3d
Edit: saveyoutube.com worked...

With YTC enabled it loads into the HTML5 player without issues for me. The new player, specifically. Downloading also works normally.

It works but I set my player to "default", no html5, no flash.

Confimed this issue here too, but i can download the video (both webm and mp4)

Follow-up: #2024


Configure Shell/Terminal location

Summary
Fixes #4733

Technical notes summary

Please, feel free to suggest any visual/effect improvement of drag&pin animations
Areas or cases that should be tested

Terminal window
Areas which could experience regressions

Terminal window
Screenshot/Video

The solution it's actually not working on Firefox. I'am pretty sure I found a cross-browsers solution, It requires some changes on drag mechanism. It should be nice to have draggable mechanism in a Draggable component.

@aalves08 Just pushd another version.
I think it requires another quick review but now it is works fine in every browsers now. :partying_face:
I have created the Utils/DraggableZone component, so it is reusable.
Even if the new functionality is complete, there are some open points:

I should add some unit tests for DraggableZone component.
In Chrome, the dragged image is still not visible. I am contemplating if it is better to show a 'Shadow' shape (for example semi transparent) when the terminal is dragged, instead of the Terminal itself.

Please let me know what are your thoughts about, thanks.

Codecov Report
Base: 36.78% // Head: 36.86% // Increases project coverage by +0.07% :tada:

Coverage data is based on head (7fd0b01) compared to base (b77d5c7).
Patch coverage: 27.27% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7147      +/-   ##
==========================================
+ Coverage   36.78%   36.86%   +0.07%
==========================================
  Files         986      988       +2
  Lines       17647    17658      +11
  Branches     4544     4545       +1
==========================================
+ Hits         6492     6509      +17
+ Misses      11155    11149       -6

Flag
Coverage Δ

e2e
47.41% <60.00%> (+0.11%)
:arrow_up:

merged
36.86% <27.27%> (+0.07%)
:arrow_up:

unit
5.20% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...c/components/Utils/DraggableZone/DraggableZone.vue
0.00% <0.00%> (ø)

...onents/src/components/Utils/DraggableZone/index.ts
0.00% <0.00%> (ø)

...ll/components/nav/WindowManager/ContainerShell.vue
0.00% <ø> (ø)

shell/components/nav/WindowManager/index.vue
0.00% <ø> (ø)

shell/layouts/default.vue
0.00% <ø> (ø)

shell/store/wm.js
24.39% <50.00%> (+2.76%)
:arrow_up:

shell/utils/platform.js
77.41% <100.00%> (+0.75%)
:arrow_up:

shell/plugins/dashboard-store/resource-class.js
47.63% <0.00%> (-0.16%)
:arrow_down:

shell/store/index.js
66.89% <0.00%> (+0.45%)
:arrow_up:

shell/utils/socket.js
61.76% <0.00%> (+0.49%)
:arrow_up:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@aalves08 Just pushd another version. I think it requires another quick review but now it is works fine in every browsers now. 🥳 I have created the Utils/DraggableZone component, so it is reusable.
Even if the new functionality is complete, there are some open points:

I should add some unit tests for DraggableZone component.
~In Chrome, the dragged image is still not visible.~  It's fixed!

Congrats mate! tested on "all" browsers (Chrome, Brave, Edge, Firefox, Safari) and it works great. 💪 👏

Minor issues are fixed, thanks for the review @aalves08 .

All other comments i've resolved, but yesterday Neil had a good point with the dark mode (I always forget about that). Can you give a quick look at this on dark mode and make the necessary adjustments, please?
You can enable in user preferences (top-right corner) a shortcut (shift + T) to toggle the theme, which is very useful.

we use the variables specified in:
https://github.com/rancher/dashboard/blob/master/shell/assets/styles/themes/_light.scss
https://github.com/rancher/dashboard/blob/master/shell/assets/styles/themes/_dark.scss
Thanks! 🙏

Hi @aalves08 , theme variables are fixed, thanks!

@torchiaf I believe this can be merged to master now.


Publish the project in dotnet-foundation

Very good project, I liked it better than Scrutor.
It would be great if you create an issue in this repository for the .NET Foundation to promote this project. They will post the link to this repository on Twitter, Facebook and Linkedin.

Thanks for the comments, @MrDave1999. Glad you find the package useful.
I'll look into your suggestion of submitting it to the .NET Foundation!


chore - prevent notification of successful e2e tests

Prevents notifications in slack and email when fleet/agent/synthetics e2e tests are successful

:broken_heart: Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-01-09T23:35:23.556+0000

Duration: 9 min 19 sec

Commit: dc0236a6ae796fce1046778d4798bfca62e45a06

Test stats :test_tube:

Test
Results

Failed
1

Passed
139

Skipped
0

Total
140

Test errors
Expand to view the tests failures
Test / CLI support capability flag – CLI support capability flag

no error details
Expand to view the stacktrace
 SyntaxError: Unexpected token { in JSON at position 991
    at JSON.parse (<anonymous>)
    at Object.<anonymous> (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-439/src/github.com/elastic/synthetics/__tests__/cli.test.ts:252:25)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

Steps errors
Expand to view the steps failures

Runs the tests

Took 1 min 12 sec . View more details here
Description: ./node_modules/.bin/jest --ci --reporters=default --reporters=jest-junit

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

/test


Update for better module loading

Update for better module loading across JS Frameworks with Webpack or ES6.
In this way the module loading is un-changed as the Docs Suggest.
And there won't be a confusion to load separate files for different JS Frameworks.
I have tested it with following:

create-react-app
react-webpack-redux
angular-2 & 4
ionic-2

Sorry it took a little time to test with these.

@ganlanyuan Can you publish the npm package? Thanks again for all the great work on this slider!

Thanks @tzsk
@chadspencer , v1.5.2 was published to npm


Docs Changes Needed from dbt-core PR #8641

At a minimum, update body to include a link to the page on docs.getdbt.com requiring updates and what part(s) of the page you would like to see updated.

As this feature is already documented and does not include any version blocks or mention version limits, will consider this completed. dbt show page is already properly version limited to v1.5+


phosh: 0.39.0 -> 0.41.0, feedbackd: 0.2.0 -> 0.4.1, squeekboard: 1.38.0 -> 1.41.0, gmobile: init at 0.2.1

Description of changes
Adds support for Phosh 0.40.0 Phosh 0.41.0 in nixpkgs
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks. The changes so far look fine, but I haven't tried building and/or running this branch yet. What else needs to be done for Phosh 0.40.0?

Been daily driving 0.40.0 on a PinePhone and haven't had any issues. Should be good to go.

Running with the latest nixos-unstable https://github.com/NixOS/nixpkgs/commit/c3aa7b8938b17aebd2deecf7be0636000d62a2b9 and haven't had any issues. Will see if I can update this to 0.41.0 later.

Result of nixpkgs-review pr 329938 run on x86_64-linux 1

1 package marked as broken and skipped:

chatty

11 packages built:

calls
calls.devdoc
feedbackd
feedbackd.dev
feedbackd.devdoc
gmobile
megapixels
phoc
phosh
phosh-mobile-settings
squeekboard

No issues running 0.41.0 on the PinePhone

When I remove doCheck = true in pkgs/applications/misc/feedbackd/default.nix, it no longer compiles:
Run-time dependency umockdev-1.0 found: NO (tried pkgconfig)

tests/meson.build:3:15: ERROR: Dependency "umockdev-1.0" not found, tried pkgconfig

Is that expected?

Unexpected to me, sort of.
It is expected that the umockdev dependency gets removed when doCheck = false. But then it shouldn't need umockdev because it shouldn't be trying to build the tests subdirectory.
Try adding this @Luflosi:
  mesonFlags = [
    # ... snip ... already existing flags
    (lib.mesonEnable "tests" doCheck)  # NB: finalAttrs.doCheck would be better
  ];

Adding code similar to "-Dtests=${lib.boolToString finalAttrs.finalPackage.doCheck}" in  pkgs/applications/window-managers/phosh/default.nix works. @donovanglover could you please add the analogous code?
How about converting some of the rec to finalAttrs or is that outside the scope of this PR?

Added "-Dtests=${lib.boolToString finalAttrs.finalPackage.doCheck}" and seems to work. Prefer keeping the diff small here so no refactoring

ofborg test failure on aarch64 is unrelated to this PR:
phone # [   62.717030] .phosh-mobile-s[1459]: AdwNavigationSplitView 0x16b06b70 exceeds MobileSettingsWindow height: requested 438 px, 353 px available
phone # [   63.405256] .phosh-mobile-s[1459]: AdwNavigationSplitView 0x16b06b70 exceeds MobileSettingsWindow height: requested 438 px, 353 px available


[Parser] jsx fragment shouldn't be a fragment's child

Spec: https://facebook.github.io/jsx/
Grammar:
JSXFragment :
    < > JSXChildren < / >

JSXChildren :
    JSXChild JSXChildren

JSXChild :
    JSXText
    JSXElement
    { JSXChildExpression }

That's means is say this is not correct ?
<>
    <App2></App2>
    <> </>
</>

I postponed this issue because babel currently supports
<>
    <App2></App2>
    <> </>
</>

The syntax has been allowed in https://github.com/facebook/jsx/pull/97, but it hasn't been synced to the website yet. https://github.com/facebook/jsx/issues/128
I think it's fine swc allows the syntax, so this issue can be closed.

Thanks!


BUG: support non-ASCII island filename

When use non-ASCII for island filename, you get a 404 error:
island file: islands/a666/测试.tsx
> curl -v "http://localhost:8000/_frsh/js/40f967fead6ba6ab02099fe32910ecb1ec092735/island-a666%e6%b5%8b%e8%af%95.js"
*   Trying <IP_ADDRESS>:8000...
* Connected to localhost (<IP_ADDRESS>) port 8000 (#0)
> GET /_frsh/js/40f967fead6ba6ab02099fe32910ecb1ec092735/island-a666%e6%b5%8b%e8%af%95.js HTTP/1.1
> Host: localhost:8000
> User-Agent: curl/8.1.2
> Accept: */*
>
< HTTP/1.1 404 Not Found
< vary: Accept-Encoding
< content-length: 0
< date: Thu, 13 Jul 2023 08:06:45 GMT
<
* Connection #0 to host localhost left intact

To fix this BUG, a few lines of code has to change:
> git diff .
diff --git a/vendor/fresh-1.2.0/src/server/context.ts b/vendor/fresh-1.2.0/src/server/context.ts
index 16fead4..55ab56b 100644
--- a/vendor/fresh-1.2.0/src/server/context.ts
+++ b/vendor/fresh-1.2.0/src/server/context.ts
@@ -277,7 +277,7 @@ export class ServerContext {
       }
       const path = url.substring(baseUrl.length).substring("islands".length);
       const baseRoute = path.substring(1, path.length - extname(path).length);
-      const name = sanitizeIslandName(baseRoute);
+      const name = sanitizeIslandName(decodeURI(baseRoute));
       const id = name.toLowerCase();
       if (typeof module.default !== "function") {
         throw new TypeError(
@@ -770,7 +770,7 @@ export class ServerContext {
   #bundleAssetRoute = (): router.MatchHandler => {
     return async (_req, _ctx, params) => {
       const snapshot = await this.#buildSnapshot();
-      const contents = snapshot.read(params.path);
+      const contents = snapshot.read(encodeURI(params.path));
       if (!contents) return new Response(null, { status: 404 });

       const headers: Record<string, string> = {

After change, it works ok:
> curl -v "http://localhost:8000/_frsh/js/36058cca27170df8d00bda95964e9e72e9260280/island-a666%E6%B5%8B%E8%AF%95.js"
*   Trying <IP_ADDRESS>:8000...
* Connected to localhost (<IP_ADDRESS>) port 8000 (#0)
> GET /_frsh/js/36058cca27170df8d00bda95964e9e72e9260280/island-a666%E6%B5%8B%E8%AF%95.js HTTP/1.1
> Host: localhost:8000
> User-Agent: curl/8.1.2
> Accept: */*
>
< HTTP/1.1 200 OK
< cache-control: public, max-age=604800, immutable
< content-type: application/javascript
< vary: Accept-Encoding
< content-length: 210
< date: Thu, 13 Jul 2023 08:05:51 GMT
<

Duplicate of https://github.com/denoland/fresh/issues/1432 . The fix is already and main and will be included in the next release. The next release will likely go out today or tomorrow.


Seems to only works in certain areas

Hi
Thanks for making this extension. I'm on OS 11.6 and have noticed that it doesn't work on:

the non system volume of my Mac (It has 2 volumes, one with system on and one I use for storage only).
Also it doesn't seem to work inside folders that are being synced by the Sync utility.

Best wishes
Birdy

This is also the case for : https://github.com/samiyuru/custom-finder-right-click-menu
Which i believe uses some of this program as base-code
So a fix here would also help to provide a fix there.
Issue:
https://github.com/samiyuru/custom-finder-right-click-menu/issues/3

This may be the cause / solution :
https://stackoverflow.com/questions/38473610/os-x-findersync-fails-for-volumes