'è' added if using an stream different from io.StringIO

'è' was added in head of stream if using an stream different from io.StringIO in
class PDFConverter(PDFLayoutAnalyzer).__init__
https://github.com/pdfminer/pdfminer.six/blob/master/pdfminer/converter.py#L173
Is this neccesary? Is possible check the stream in another method?
Code for test the problem:
    from pdfminer.converter import TextConverter
    from pdfminer.layout import LAParams
    from pdfminer.pdfinterp import PDFResourceManager

    def testBuffer(self):
        rsrcmgr = PDFResourceManager()
        buffer = cStringIO.StringIO()
        retstr = codecs.getwriter("utf-8")(buffer)
        laparams = LAParams(detect_vertical=True, char_margin=3.0, line_margin=0.8, all_texts=True,
                            word_margin=0.6, line_overlap=0.3)
        device = TextConverter(rsrcmgr, retstr, codec="utf-8", laparams=laparams)
        print(buffer)

Hi @ZanonEdoardo! I tried testing this but it's hard to come up with a stream that does not have a mode (i.e. file handlers) or is StringIO or BytesIO. The cStringIO.StringIO does not exist anymore in Python 3. Do you know what other stream someone wants to use?
As a solution to this problem I wanted to write a backslash character to the stream. I guess that works fine, but I cannot test it since all of the streams I know do not end up in the else clause where this code is executed.

@pietermarsman I notice you moved this to in progress. Are you currently working on this? Any updated to your above comment, or are we really waiting for info/a solution?

It's more of a "needs solution".
The core of this issue is that we need to have a way to determine if the output stream supports unicode. If it is not any of the output streams we know, you can test this by printing a unicode character. That character appears on the output stream. This can be fixed by printing a backspace. This works when you print the output to a terminal or so, but it might be worse if you want to use the output for other cases. Because there are 2 characters in the output stream that are not in the original PDF. So I'm not sure if that is always an improvement.
Also, I think using python3 mitigates this problem almost completely. Since all the default python streams support unicode. So we can maybe remove the test (because it never triggers).
Anyway, if we want to continue with this issue, we need an example of an output stream that does not support unicode and has a valid usecase.

I would suggest we remove the try-except way of figuring out if the stream is binary. The check for the mode of the stream shoudl not actually write to the stream. If this leads to unexpected behavior for stream implementations, of which I do not yet know the existence, we can add specific checks for those.


removed snapped.rb

Can’t find a download link on the homepage (only one to download on the MAS) and it uses a download url from a different host than the homepage. Unless someone can point to where the download url lives, we should remove this.

Third-party URL is an anonymous Cloud app user. Removing.


feat: add reproducible build script

This PR adds a script to compile reproducible builds, by disabling CGO and hard-coding other environment-dependent build parameters.
Also adds a blurb in the readme for the curious.
Tested using go 1.20.4 compiler on the following platforms:

[x] Debian 11
[x] Ubuntu 20.04
[x] Mac OS Ventura 13.0.1

If anyone would like to give it a try, this the output I get on this branch:
Compiling reproducible builds.
  compiler version: go1.20.4
  git commit hash:  1bc34e4368c3c2fad1cef1eb2bbaea50e6e1f3ed

The same compiler and source files must be used when reproducing builds.

Building mnemonikey-linux-386...
Building mnemonikey-linux-amd64...
Building mnemonikey-linux-arm64...
Building mnemonikey-windows-386...
Building mnemonikey-windows-amd64...
Building mnemonikey-darwin-amd64...
Building mnemonikey-darwin-arm64...
Done. Artifacts compiled in ./build

6cd802d9c01dd8123e34baa73bbe2678cfb4ee9eade19ebefefa2af6e2bad61c  build/mnemonikey-darwin-amd64
e35d4db4522cf4984f50446bd22e69826f39d48bd2318180b96113cba05e0605  build/mnemonikey-darwin-arm64
1ef6ce7655de1866c95ef6a77e223d44ca79195c93282ac6b493a45d9709348e  build/mnemonikey-linux-386
47b61aec6bb431ff4ba6e209ee202ca2c84d38e23227bcfeec2dd2509cf8bb49  build/mnemonikey-linux-amd64
d6284ab4f480861374fd02ba7088ea2eb7374f16c3dd0ce1516e158cdac105f5  build/mnemonikey-linux-arm64
d4040954274356b5721ea95123c52d769a81ce85a7c47afcf14fea606bab83d6  build/mnemonikey-windows-386
28a435d84fabf182373d95c13fe693fbe5803de8b10ac6379ccd0a4407ec0487  build/mnemonikey-windows-amd64


[Docs] Update core docs index page to flag up Vizro-AI

Edit: Ready for a final review before submission!
Description
Also added a nav item for Vizro-AI to Vizro and vice versa. Check out the built docs for vizro-core and vizro-ai.
Have I used the best icons in the cards? I'm not sure about "Fast forward"!
Also made some tweaks to the example chart created in the vizro-ai docs and then used that in the vizro-core docs so there's a direct 1:1 mapping. It's not massively reinforced so people don't have to tune into Vizro-AI straightaway, but it does clarify how it could be used, and makes another connection to it. See what you think in the built docs!
Note: I still need to update the README in vizro-core to flag up Vizro-AI better but that's a separate ticket.
Screenshot
Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
I have not referenced individuals, products or companies in any commits, directly or indirectly.
I have not added data or restricted code in any commits, directly or indirectly.

@huong-li-nguyen This is now ready to be merged by a codeowner as everything is OK except for the mypy linter error.


vmdk admin cli  'ls' command errors with Python 3.5.1

The subprocess.checkoutput() returns an encoded byte output (unlike a string in 2.7). Needs to be decoded  before using.
python ./vmdkops_admin.py ls
b'Capacity bytes: 104857600 \nUsed bytes: 14680064 \nUnshared bytes: 14680064 \n'
Traceback (most recent call last):
File "./vmdkops_admin.py", line 606, in
main()
File "./vmdkops_admin.py", line 39, in main
args.func(args)
File "./vmdkops_admin.py", line 348, in ls
rows = generate_ls_rows()
File "./vmdkops_admin.py", line 384, in generate_ls_rows
size_info = get_vmdk_size_info(path)
File "./vmdkops_admin.py", line 443, in get_vmdk_size_info
lines = output.split('\n')
TypeError: a bytes-like object is required, not 'str'

Closed via #591


Types with TryParse must be set with type string

Fixes #3105
It's not a full rollback of #2980..  But almost, now it takes into account the Enum if the apiParameter.Type is Enum

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.50%. Comparing base (a42d8c9) to head (3c2802f).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3108   +/-   ##
=======================================
  Coverage   90.50%   90.50%
=======================================
  Files          76       76
  Lines        3116     3116
  Branches      515      516    +1
=======================================
  Hits         2820     2820
  Misses        296      296

Flag
Coverage Δ

Linux
90.50% <100.00%> (ø)

Windows
?

macOS
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Bug]: Widget's don't visually align with each other during certain conditions

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When a hug widget is placed with a fill widget, especially a widget with horizontal orientation, then the widgets do not align in a zone
Steps To Reproduce

Drop a button widget on a zone
Drop a switch group widget on a different zone and change it's orientation to horizontal
Not place the switch widget next to the button and notice the alignment

Public Sample App
No response
Environment
Deploy Preview
Severity
High (Blocker to building or releasing)
Issue video log
https://www.loom.com/share/8bb246103e114c2e861e6fa03a7ae667
Version
cloud

@ramsaptami  I set up Appsmith locally but can't find "zone" or "anvil" anywhere in the application. I can't able to reproduce the issue. Is this related to Anvil project?

@SaiCharanChetpelly31 that's correct, it's part of the Anvil which is still a work in progress.
Please look at issues marked 'good first issue' if you're looking to contribute

We will create a comprehensive algorithm for this to guide the default widget placement. This is an exercise in combinatorics that would require significant time investment.
As far as priorities go this is rather low for now: we have more foundational needs to address.
First, we need to have a bigger widget set so that we don't have to immediately overhaul this algo and polish the base of the experience.


Cameras: support multiple named cameras, refactor matrices, support FOV param

Support multiple cameras: cameras is a hash of camera configs
If only one camera is defined (singular camera: ... syntax, it will be set to the default camera, e.g. cameras.default will point to the value of camera).
An initial active camera can be designated with active: true.
An initial position and zoom can be specified by the camera, this override's the map's existing view on scene load.
Field-of-view (fov) is an alternative to focal_length. If the latter is present, it will take priority.
Matrices are closer to traditional model-view-projection division, but still not quite in alignment with that model due to precision limitations (the translation of camera + tile needs to happen in one step, or we don't have enough 32-bit precision for mercator).

cc @meetar


[WIP] Spark Watermarks

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@lukecwik  thanks for that ! I'll take a look
But before, as it is still a WIP, I'll look at your other spark PR https://github.com/apache/beam/pull/13061


blahhhh

demo of how big teams don't allow just anybody to edit their code

Hacktoberfest seems to start earlier every year

I was expecting to show my students that there would be a bunch of requirements and actions and reviews that had to be completed before the PR could be merged, maybe some Code Owners auto-reviewer-assigning, but the This PR doesn't have any linked issues. bot was 10x better.
Also though sorry for spamming real humans with my garbage here, I was caught up in what I was explaining and didn't think of that part as I should have 😬


Use of a vulnerable version of polished npm package

The package<EMAIL_ADDRESS>is used as the dependency. This version is vulnerable to the ReDoS described here: https://security.snyk.io/vuln/SNYK-JS-POLISHED-1298071
Vulnerability is fixed in versions 3.7.2, 4.1.3 or higher.

@piotr-kotara-ibm How critical is this item? Would there be an issue for you if this was fixed in January, rather than immediately?

@JordanWSmith15 The severity of this vulnerability is low, there is no need to deliver immediate fix. Fix in January wouldn't be a problem


MySQL query fails on NS records that are not FQDNs.

IF I have a NS record that isn't FQDN with a trailing period I get an error.
504	cloud.com.		3600	{"host":"infr-pdnsn-401"}	NS
dig @localhost NS cloud.com

; <<>> DiG 9.10.6 <<>> @localhost NS cloud.com
; (2 servers found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: SERVFAIL, id: 30356
;; flags: qr rd; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1
;; WARNING: recursion requested but not available

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;cloud.com.             IN      NS

;; Query time: 27 msec
;; SERVER: ::1#53(::1)
;; WHEN: Fri Feb 10 09:32:05 CST 2023
;; MSG SIZE  rcvd: 46

If I add the FQDN it works as expected.
504	cloud.com.		3600	{"host":"infr-pdnsn-401.cloud.com."}	NS

I think this is more of a documentation issue. As long as the behavior is predictable.


[backport][CWS] move all etw events in same goroutine as process events (#23316)

(cherry picked from commit 835f3bb785e1e7a9c5c0b2893e1dd0d1fde225ac)

What does this PR do?
manual backport of https://github.com/DataDog/datadog-agent/pull/23316

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Outlook now supported with centralized deployment

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/images/outlook-add-ins-admin-managed.png
:white_check_mark:Succeeded

docs/publish/centralized-deployment.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Writing tab-separated empty strings

Hi,
I've encountered a problem while writing a tab-separater CSV.
When the last column in a row of a DataFrame is an empty string, the preceding tab is trimmed.
From what I've seen, it happens in CSVFormat.format():
new CSVPrinter(out, this).printRecord(values);
return out.toString().trim();

This makes the row shorter than others and from what I understand goes agains RFC 4180.
An easy fix is to call the code contained in CSVFormat.format() manually.

Same issue for me.

I've also recently faced the same issue with exporting a tab-delimited file. I'm using pyspark version 1.6. Has this been addressed in a later version? Seems like a legit bug to me.

I've also recently faced the same issue with exporting a tab-delimited file. I'm using pyspark version 1.6. Seems like the caller doesn't address this issue with manual formatting.


chore: disabling dependabot version updates

Summary by CodeRabbit

Chores

Updated the schedule for dependency updates to run weekly on Fridays.
Adjusted the limit for open pull requests related to dependency updates.

Ref: https://github.com/FunctionX/fx-core/blob/main/.github/dependabot.yml

Ref: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuring-dependabot-version-updates

mg


5_prime_UTR_uORF_variant

What is this request referring to?
A variant that falls in a ORF in a 5' UTR. (This will be a parent term for the proposed 5_prime_UTR_uORF_stop_codon_variant & 5_prime_UTR_uORF_frameshift_variant)
What is the name you would like SO to give the term?
5_prime_UTR_uORF_variant
What is the definition that you would like for this term?
A 5’ UTR variant within an upstream open reading frame
Synonyms
N/A
Parent Term
5_prime_UTR_variant (SO:0001623)
Relevant Publications
MID: 32461616, Whiffin et al 2020
Characterising the loss-of-function impact of 5' untranslated region variants in 15,708 individuals. (Nature Communications)
PMID: 32926138, Zhang et al 2021
Annotating high-impact 5'untranslated region variants with the UTRannotator (Bioinformatics)

This is done. Changes should be reflected on sequenceontology.org in the next 24 hours. If you'd like to inspect the changes right away I'd recommend downloading Protégé and opening the ontology files with "File" > "Open from URL..." > and then entering this URL: https://raw.githubusercontent.com/The-Sequence-Ontology/SO-Ontologies/master/Ontology_Files/so.obo


⚠ ClamAV has degraded performance

In 12c944b, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 199 ms

Resolved: ClamAV performance has improved in 143872c.


ConfirmPrompt causing duplicated message when set Context.Activity.Locale to "pt-BR"

Version
4.10.2
Describe the bug
I have used the comfirm prompt to ask the user if he want to talk with a human agent. My code is work fine but the options are displayed in english and i need to translate to portuguese:

And if i click in "No" option, he give me another question:

But when i set the locale of the activity to pt-br:
stepContext.Context.Activity.Locale = "pt-BR";
The options are displayed ok in portuguese:

But if i click at "No" option, the bot send again the same confirmation message but with the options in english.

I have tried to set the defaultLocale of the ConfirmPrompt when add he to dialog too but this dont translate the ConfirmPrompt options:
AddDialog(new ConfirmPrompt(nameof(ConfirmPrompt), null, "pt-BR"));
To Reproduce

Create an bot applications using the bot framework SDK version 4.10.2 and add a Waterfall Dialog.

AddDialog(new WaterfallDialog(nameof(WaterfallDialog), new WaterfallStep[]
            {
                ConfirmationStepAsync
            }));

Inside a waterfall step, set the activity locale to "pt-BR" and return a ConfirmPrompt:

private async Task<DialogTurnResult> ConfirmationStepAsync(WaterfallStepContext stepContext, CancellationToken cancellationToken)
        {
            stepContext.Context.Activity.Locale = "pt-BR";
            return await stepContext.PromptAsync(nameof(ConfirmPrompt), new PromptOptions { Prompt = MessageFactory.Text("Confirm?") }, cancellationToken);
        }

Expected behavior
The bot send the confirmation message without duplicate when i translate the options.

Thank you for the report, @johseffer
The locale of the activity is always prioritized. The default locale of the prompt is only used if the activity has no locale. Therefore, if the activity locale is English then it won't matter if your prompt locale is Portuguese.
I think the problem of the prompt reprompting in English is because you only set the activity locale to Portuguese for the first turn of the prompt and not the second turn. That would mean the prompt prompts in Portuguese and then on the next turn the bot receives "Não" in an activity that has English as its locale, which means it tries to interpret "Não" as an English word and it can't do that so it reprompts. When it reprompts it does so in English because that's the locale in the incoming activity.
The best way to solve your problem is to make sure your client app always sends activities to the bot with the correct locale. If you really want to set the locale on the bot side then you'll need to make sure you do it on every turn.
Does this resolve your issue?

That's make sense @v-kydela. Thank you very much!
I can achieve that changing my code to set the Activity locale inside the OnTurnAsync event, so the locale is portuguese in my all steps and the bot dialog works fine now.
public override async Task OnTurnAsync(ITurnContext turnContext, CancellationToken cancellationToken = default)
        {
            turnContext.Activity.Locale = "pt-BR";

            await base.OnTurnAsync(turnContext, cancellationToken);

            // Save any state changes that might have occurred during the turn.
            await ConversationState.SaveChangesAsync(turnContext, false, cancellationToken);
            await UserState.SaveChangesAsync(turnContext, false, cancellationToken);
        }


[DOC] Move docs/configuration/flag_configuration.md to website

Change in the documentation

Move content of docs/configuration/flag_configuration.md to https://flagd.dev
Rewrite flag_configuration.md to point to website

Will be closed by #825

https://flagd.dev/reference/flag-definitions/


Error using build-in neovim diagnostics

As neovim/neovim#12655 was merged and using neovim with it, I get the following:

Error detected while processing function LspStatus:
line    2:
buf_diagnostics_count is deprecated. Use 'vim.lsp.diagnostic.get_count'

With my function to update the statusline being:
function! LspStatus() abort
  if luaeval('#vim.lsp.buf_get_clients() > 0')
    return luaeval("require('lsp-status').status()")
  endif
  return ''
endfunction

The error seems to be in lsp-status/diagnostics.lua:11 Changing it to:
result[k] = vim.lsp.diagnostic.get_count(level)

fixes my error.

#18 should resolve this

Thanks @tjdevries for the quick PR. @ner0-m, does this resolve your problem?

Hey there! I'm not OP but I am also getting a similar error. That is, after updating the plugin with the included merge #18
Error executing lua ...lsp-status.nvim/lua/lsp-status/diagnostics.lua:12: attempt to index field 'diagnostic' (a nil value)

Oops you're right, I took the easy way out (installed via appimage, 2 days old 😅) and didn't see that it was related to a recently updated nightly.
Let me make a build from source and report back...

@ner0-m, @rockerBOO
vim.lsp.diagnostic.get_count takes a buffer number before the severity.
Wouldn't it need to be changed to
result[k] = vim.lsp.diagnostic.get_count(0, level)

to get the count for the current buffer?

@jasonrhansen: Nice catch; you're correct. Addressed in 9750f45.

@wbthomason Thanks I just tried and it seems to work perfectly fine! Then this can be closed :smile:


[LLRP App] Update snaps for a Jakarta Release

Snaps need to be reworked to release the service for Jakarta

Now working on this


How do I get it to work (question/bug)?

What am I doing wrong? The expression filters does not seem to work.
namespace ConsoleApp1.A
{
    public class ClassA { }
}

namespace ConsoleApp1.B
{
    public class ClassB { }
}

namespace ConsoleApp1
{
    using Serilog;
    using Serilog.Events;
    using System;

    public static class Program
    {
        private const string FilterExpr1 = @"@Level < 'Warning' and StartsWith(SourceContext, 'ConsoleApp1.A.')";
        private const string FilterExpr2 = @"@Level < 'Warning' and StartsWith(@SourceContext, 'ConsoleApp1.A.')";
        private const string FilterExpr3 = @"@Level < 'Warning'";

        public static void Main()
        {
            Configure1(FilterExpr3);
            //Configure2(FilterExpr3);

            var loggerA = Log.Logger.ForContext<A.ClassA>();
            loggerA.Debug("Debug A");
            loggerA.Information("Info A");
            loggerA.Warning("Warn A");
            loggerA.Error("Error A");
            loggerA.Fatal("Fatal A");

            var loggerB = Log.Logger.ForContext<B.ClassB>();
            loggerB.Debug("Debug B");
            loggerB.Information("Info B");
            loggerB.Warning("Warn B");
            loggerB.Error("Error B");
            loggerB.Fatal("Fatal B");

            Log.CloseAndFlush();
            Console.ReadKey();
        }

        private static void Configure1(string exclude)
        {
            var logCfg = new LoggerConfiguration()
                .Enrich.FromLogContext();

            logCfg.WriteTo.Console(
                restrictedToMinimumLevel: LogEventLevel.Information,
                standardErrorFromLevel: LogEventLevel.Fatal,
                outputTemplate: @"[{Timestamp:HH:mm:ss} {Level:u3} {SourceContext}] {Message:lj}{NewLine}{Exception}");

            logCfg.Filter.ByExcluding(exclude);

            Log.Logger = logCfg.CreateLogger();
        }

        private static void Configure2(string exclude)
        {
            var logCfg = new LoggerConfiguration()
                .Enrich.FromLogContext();

            logCfg.WriteTo.Logger(lc => lc.Filter.ByExcluding(exclude))
                .WriteTo.Console(
                    restrictedToMinimumLevel: LogEventLevel.Information,
                    standardErrorFromLevel: LogEventLevel.Fatal,
                    outputTemplate: @"[{Timestamp:HH:mm:ss} {Level:u3} {SourceContext}] {Message:lj}{NewLine}{Exception}");

            Log.Logger = logCfg.CreateLogger();
        }
    }
}

Neither Configure1 (global filter) nor Configure2 (per-sink) with any combination of filter expressions (FilterExpr1, FilterExpr2, FilterExpr3) have any effect on logs written to the console.
restrictedToMinimumLevel does work.
netcoreapp3.1
Serilog.Enrichers.Thread 3.1.0
Serilog.Extensions.Logging 3.0.1
Serilog.Filters.Expressions 2.1.0
Serilog.Sinks.Console 3.1.1

Hi! SourceContext is a regular property, so the @ isn't required in expressions. The name of ConsoleApp1.A is just ConsoleApp1.A - there's no trailing dot, so StartsWith(SourceContext, 'ConsoleApp1.A.') won't match - you'll need:
@Level < 'Warning' and (SourceContext = 'ConsoleApp1.A' or StartsWith(SourceContext, 'ConsoleApp1.A.'))

Hi! SourceContext is a regular property, so the @ isn't required in expressions. The name of ConsoleApp1.A is just ConsoleApp1.A - there's no trailing dot, so StartsWith(SourceContext, 'ConsoleApp1.A.') won't match - you'll need:
@Level < 'Warning' and (SourceContext = 'ConsoleApp1.A' or StartsWith(SourceContext, 'ConsoleApp1.A.'))

I don't think that's correct - SourceContext property is ConsoleApp1.A.ClassA and ConsoleApp1.B.ClassB in this case; it's what's written to console stdout if SourceContext is in the output template. So why would you not use StartsWith(SourceContext, 'ConsoleApp1.A.') (dot included at the end)?
Also, it does not explain why exclusion FilterExpr3 (@Level < 'Warning') is not working either.
Anyways, I've tried your suggested expression as FilterExpr4 and it does not have any effect either - Info level logs for source ConsoleApp1.A.ClassA are not excluded.

Ah, sorry, my mistake skimming through. I must have missed my morning coffee before replying :-D

@Level < 'Warning'

This will be a problem, there's no ordering on warnings, you need to use @Level in ['Verbose', 'Debug', 'Information'].

The overloads of WriteTo.Conditional should enable per-sink filtering. HTH!


Replace static function names/globals to have _ instead of oe

Issue #948 /PR #1093 fixed global functions/symbols that had the _oe_ prefix. However, static functions/globals that have _oe_ prefix will need to be changed to only have the underscore (_) as prefix.
Additionally, the coding development guide should also be updated with the usage.

Will work on this next week...

Didn't start working on it but good to get into upcoming 0.5 release.

WIP

I think this should get into Release 0.5. It is benign change and also involves coding guidelines doc enhancement.

Fixed with #1619 which has been merged to master. Hence, closing...


RE7 lighting / shadow bug

https://www.youtube.com/watch?v=jhHDothVVXA

i have this on the latest version even without reframework installed
something tells me it's a bug in the game itself, trying to find a solution online rn

i have this on the latest version even without reframework installed something tells me it's a bug in the game itself, trying to find a solution online rn

Yeah since i discovered this i also tried without VR mod and the artifact is present there too


[Roadmap] User Login

Scope:
User logs in to UI (all supported login methods).
This includes some of the data loading into Redux, but other loading tasks are being split into a another epic.

Other tasks have been split into #2662


"POST" method support

While adding an additional method parameter to the casClientConfig in the webconfig a ConfigurationErrorException exception is thrown.
After looking into the source code I couldn't find the POST method support.
Is this something that is missing and is going to be delivered soon?
Is there another way rather than using the POST Login to get users extra info?
Thanks,
Daniel

This functionality is missing, but exists in the Java CAS Client.   I ran some rudimentary code in the debugger and a test project and it worked fine w/ POST method.  I will add the code to support this shortly.


Webpack hash

Description
Changes proposed in this pull request:

Add hash for luigi.js, luigi.css and luigiConfig.js
Add a script to clean hashed files before running busola locally. It prevents from having trash of multiple hashed files in the directory
Add library that injects hashed content to the HTML

How to test?
Deploy busola with the Docker image that has PR number
Related issue(s)
Closes #1050
Closes #1144

/retest

/test all

/retest

/test all

/test all


findalldev become a function and doc update

findalldev does not need to be a member method of PcapSession class.
due to the changes in the native HTTPParser http_trace no longer work in node v5

Hi there. Thanks for the contribution. I've added you as a collaborator on this project. Feel free to merge as you see fit.


More intuitive naming during conflict resolution

During conflict resolution, e.g. in the merge editor, Current and Incoming are not intuitive, it would be better to use the branch names or at least have the branch name in parenthesis after Current and Incoming

Can you share a screenshot? The branch names should be shown already.

Sorry my bad, the branch names are shown in the merge editor but not otherwise.  The attached screenshot is the result of a rebase from master while in another branch.  In the merge editor the branch names are shown above each code tab.  I think my point is that instead of 'Accept Current' it would be clearer if it said 'Accept Master', 'Accept <branch_name>' etc.


Adds rounding in preprocessing for earthstat and mapspam rasters

General description
Rounds the earthstat and mapspam crop rasters to 4 decimal places to avoid overflowing issues when operating with the values since the raw rasters contain incredible small values.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Provide minimal instructions on how to test this PR.

Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

[ ] Branch name / PR includes the related Jira ticket Id.
[ ] Tests to check core implementation / bug fix added.
[ ] All checks in Continuous Integration workflow pass.
[ ] Feature functionally tested by reviewer(s).
[ ] Code reviewed by reviewer(s).
[ ] Documentation updated (README, CHANGELOG...) (if required)

closing this because it is obsolete. Check the jira ticked for more context -> https://vizzuality.atlassian.net/browse/LANDGRIF-788


Chroma asimilarity_search NotImplementedError

Hello, currently facing exception trying to call ConversationalRetrievalChain with chroma as retriever in async mode.
 chain = ConversationalRetrievalChain.from_llm(
            self.llm,
            chain_type="stuff",
            retriever=conn.as_retriever(**kwargs),
            verbose=True,
            memory=memory,
            get_chat_history=get_chat_history,
        )

chain._acall({"question": query, "chat_history": memory})

I want to implement that method to allow to use chroma in async mode.
Could somebody assign me? =)

it seems that is already resolved by updates :P


[SPARK-28806] [DOCS] [FOLLOW-UP] Remove unneeded HTML from the MD file

What changes were proposed in this pull request?
This PR is to clean up the markdown file in SHOW COLUMNS page.

remove the unneeded embedded inline HTML markup by using the basic markdown syntax.
use the ``` sql for highlighting the SQL syntax.

Why are the changes needed?
Make the doc cleaner and easily editable by MD editors.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Before

After

cc @huaxingao Could you help fix all the other pages like this example?

Test build #122097 has started for PR 28414 at commit d21377b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26771/
Test PASSed.

Also cc @dilipbiswal

Test build #122099 has started for PR 28414 at commit 88fe8b3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26773/
Test PASSed.

Test build #122097 has finished for PR 28414 at commit d21377b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122097/
Test PASSed.

Test build #122099 has finished for PR 28414 at commit 88fe8b3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122099/
Test PASSed.

LGTM

Thanks! Merged to master/3.0


The question of shadowroot (close)

How do I use the module on shadowroot (close)?
I want to click on that button.
Using buster requires clicking on the recaptcha button.
But unfortunately it is not interactive.
I tried to manipulate it with the keyboard, but failed.
If there is any other way to click, welcome to let me know.

I've found a way to get over recaptha .Thanks!


Test

testing https://github.com/Expensify/Web-Expensify/pull/35165

another comment

a comment from me

It works!


feat(urllib3): filter blacklisted urls for http header injections

:tada: This PR is included in version 1.27.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


rpc: add support for unix sockets

This PR fixes #1224.
Thanks a lot to @Richard87 for his initial proposal, I was able to use quite a lot of that code.
As described in the issue, Unix sockets are only supported for the gRPC and REST listeners. It doesn't make sense for the p2p listener to listen on an Unix socket.
Currently, TLS cannot be disabled on any of the servers, not even for the loopback interface. So the same applies for Unix sockets, they still require a client certificate to connect.

This change was surprisingly big. Can you split into smaller commits if possible? :)
Also agree that the methods moved into lnrpc probably should not be. I think the change will work even though they are not moved? Makes sense to do the move in a seperate PR (or at least a seperate commit).

Right, sorry. I'm still getting used to the short lines... :sweat_smile:
I hope it's ok now.

Suggestion for how to structure the commits, to make it easier to review:

Make all changes to config.go, lnd.go and server.go without renaming/moving the existing methods
Move the methods into lncfg <-- to keep the diff minimal I would move only what's necessary (it is moved because it is used in lncli, right?)
Make changes to lncli
sample.conf changes

This is not a blocker though, but I found it a bit hard to review because it's not easy to see at a glance what is new code and what is just code moved 😄

In general, I think sockets belong in /var/run somewhere and not in /tmp. Would it be a good idea to change the examples?
This, imho, should be gone through for the whole of LND, I would prefer default config file location to be moved to /etc, the data dirs etc to be moved to /var/lib/lnd - and other Unixfying changes.

It took me a while but I think I was able to structure the commits as you suggested, @halseth.
@vegardengen: I updated the example. I think with the --configfile and --datadir options, lnd allows customization so the linux distribution package maintainers can put the files wherever their distro defaults to. In my opinion this isn't necessarily the tool's job since any chosen default will be 'wrong' in some distro's eye...

@guggero adding this to the 0.5 milestone, it's ready to go IMO. Will need a rebase and then can start the merge process once we cut 0.4.2 🎉

@guggero MERGING SEASON IS HERE. Should be good for a final rebase/review

Yeah :sunglasses:
I've rebased all my open PRs.

Needs a rebase, thanks!

Rebased :)

tests failing, looks like some minor compilation erros

Sorry, I made a mistake with the last rebase. The Tor support had more influence on this PR than I thought...

Latest travis run:
# github.com/lightningnetwork/lnd
./config.go:845:25: undefined: normalizeAddresses
./server.go:387:22: undefined: normalizeAddresses

Fixed and rebased

Will give this a spin locally, then merge if all seems well!


Vulnerabilities do not have "title", "published", "modified" fields

Similar to https://github.com/trustification/trustify/issues/280
For each Vulnerability obtained through GET /api/v1/vulnerability there should be metadata that help users to understand the context of each element. E.g. title, date published, date modified.

It looks like the reason for this is:
https://github.com/trustification/trustify/blob/181719dde1162cedae1847511587186bf9770868/modules/ingestor/src/graph/advisory/mod.rs#L230
When no "vulnerability" is found, then a new one will be created, but without any information.

Digging into this issue the situation seems as follows:

Ingesting any source, like CSAF, will result in "vulnerabilities in the context of an advisory" to have a title and additional information
If no "vulnerability" itself exists, it will create one, but leave the other information empty
When the "CVE" importer runs, that information is taken (creates or fills in) this information

So running the CSAF importer and the CVE importer is required. To my understanding, the order is not important.

IMO these are the problems:

I am sure I ran the "cve" importer and the "csaf" importer and yet I saw no new data available title|published|modified in the /api/v1/vulnerability endpoint. I do not have a reliable way (step1, step2, stepN) to make the required data appear
If So running the CSAF importer and the CVE importer is required is true. Then I strongly believe we should rethink/reformulate the definition of a importer. An importer should be self sufficient. I feel that this is a broader discussion than the title of this issue and can be discussed separately

I might be missing something but this is still an unsolved issue

Closing this in favor of https://github.com/trustification/trustify/issues/626


Several Commits to both fix bugs and add functionality

Thank you very much for writing the package!  I've found it much easier to write into this parser than other methods I was using for parsing.
I've made several updates below to fix issues, improve documentation, add features, and add some tests.
The issues were with the Unlist (and therefore with the %then%) function where it was losing attributes when I created an object that was more complex than a base object (just submitted as #6).
I found the need for a 0 or 1 function similar to some and many, so I added maybe.  I also sometimes wanted to have access to the parse tree, so I created %thentree% which does the same thing as %then%, but without the call to Unlist at the end.

Thanks for this.
I will go over this on the weekend (hopefully).
I might progressive merge your changes if that is okay, or split this into multiple PRs

Chapman

I've updated my repository to fix the tests with the assumption that list-based results are reasonable.

Thanks - @your response earlier - can you update the tests that align with your changes.
Then I'll probably accept the PR.

I updated my tests in my forked repository.  Can you try that?

Ill merge and fix the issues....

For future reference, please don't remove inline documentation code, cause it fails travis, if you want me to merge a req (and any request on github) make sure travis passes

Thanks for merging it.  To help me learn, can you tell me the inline comment that I dropped that caused problems.


title heading and ions

@Aqiry Hello, can you elaborate the issue, please?

I can't make the heading come in the centre and the size of the icon is not changing

@rexyagami

@Aqiry there are some hints hidden in CSS, and you have to write some rulesets too.


Fix defaultTo types

Purpose
Fix the types fo the defaultTo utility, which were allowing invalid default values.
Summary of Changes

adjust defaultTo types to not let invalid default values through
fix invalid defaultTo usage with default values

Side Effects / Testing Notes
Should not change behavior.
Ticket
n/a
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md

Coverage decreased (-0.07%) to 55.802% when pulling 2fe2bcbdbf311ad6135eb3bd34ffac378a816a3e on jamescdavis:fix_defaultTo_types into e85a91ff8408c8f5ce9433285421adc5dc938667 on CenterForOpenScience:develop.


error message.

Hi,
first of all thank you for BifrostEXR. I think it's exactly what i was looking for.
I was trying to write the point position data of bifrost particles into the rgb channels of a exr image file.
Would like to get that information into nuke to render it with a point renderer. i piped the xyz positions into
rgb(a) and defined "height" and "width" (1024x1024). i piped this "object" with all the data into the image input of write_exr but i get this error message:
"vnnConnect "|bifrostGraph1|bifrostGraphShape1" "/set_property2.out_object" "/Write_Exr.image";
// Error: Error: while compiling top level compound 'bifrostGraphShape1', around the port definition 'Image::Write_Exr.image':
Port 'image' has undefined type 'Object'. // "
could you send me some kind of example screenshot or file to find out what's wrong in my setup?
that would be super nice.
thx
jakob

Currently the write node isn't very robust and will only take a flat array of pixels named rgba as a float vector4,
width and height properties should be integers too.
It's not a geometric type so if you are setting properties make sure they are regular and not geo property.

Hey, thanks for replying this fast. Do i need a specific bifrost version? Because i get the same error by just doing this:

and is it possible to render sequences with write_exr?

Yes you can read and write sequences by plugging a Time node’s frame port into a string and formatting the output path. Which version of Bifrost are you using?

Oh dear. I am already being pulled out by the Read_Exr node. I justr tried the same structures as above and didn't get pass the error below...Also, what could be wrong with this little test? Am I loading the file correctly? Do you have a working sample.exr file I can use for testing, or any specific setup to build an exr?
Bifrost 2.7.1 Maya 2023.2
// Error: Error: while compiling top level compound 'bifrostGraphShape1', around <no specific location>:
//     JIT compilation used external symbol '?read_exr@io@@YAXAEAVObject@Bifrost@@AEBVString@Amino@@@Z' which could not be resolved


Bounty Account Refill Request - 22/05/2021 - Front End

Payment for JS SDK work:
Reference: https://docs.google.com/document/d/1Y-uO-bV6J5UBBWyre4azk9LC0gmXSBIZ0qXd_FBhgsk/edit
Amount Requested
109,800 + 10(tx fee) = 109,810
Bounty Account Number
1345375a4d25452ab0e702df2467b1fd575bcaae7d7fce49423dfce4811e1580

for ref: @zinoadidi

@zinoadidi paid to you

Thanks! seen

8de30226230c35bbc1ce4a63c62a7b9c86bf0ce21fc7bc1a984b7884a9f88782

@zinoadidi
My account number:
8928526805de48e4bf2ed2a9b4b839e6b2603018ecdfbf4cffdb2065e01a3ed1


Additions to 0.26 (Update actix-web dependency to 4.0)

@robjtede
@MarinPostma
update actix-web dependency to 4.0

From main to release-v0.26.0

bors merge


node search: environment attributes not available in helper methods

Adding this change to aid in debugging:
diff --git a/lib/cluster-def-gem/lib/cluster_def.rb b/lib/cluster-def-gem/lib/cluster_def.rb
index a37260d..991de0f 100644
--- a/lib/cluster-def-gem/lib/cluster_def.rb
+++ b/lib/cluster-def-gem/lib/cluster_def.rb
@@ -84,6 +84,7 @@ module BACH
         end
         # validate node ids
         if (cluster_def.select{ |row| validate_node_number?(row[:node_id]) == false }).length.positive?  then
+          puts cluster_def
           fail "Retreived cluster data appears to be invalid -- node IDs must be positive integers between 0 and 256 (1..255)"
         end
     end

Currently getting the following error:
d/75-persistent-net-generator.rules", "preferred_disk_drivers"=>["ahci"], "early_command"=>"  udevadm trigger; udevadm settle --timeout=30 ; \\\n  set -- $(vgs --rows --noheadings | head -n 1); \\\n  for vg in \"$@\"; do \\\n    echo Removing volume group $vg \\\n      >> /tmp/early_command.out; \\\n    lvm vgremove -f \"$vg\" \\\n      >> /tmp/early_command.out; \\\n  done; \\\n  for d in `ls /dev/sd[a-z]*`; do \\\n    echo Removing LVM PVs from $d \\\n      >> /tmp/early_command.out 2>&1; \\\n    lvm pvremove -f $d \\\n      >> /tmp/early_command.out 2>&1; \\\n    echo Erasing first blocks on $d \\\n      >> /tmp/early_command.out 2>&1; \\\n    dd if=/dev/zero of=$d bs=64M count=16 \\\n      >> /tmp/early_command.out 2>&1; \\\n  done\n"}, "admin_users"=>[], "interface"=>"eth0", "pxe_interface"=>"eth1", "server"=>"<IP_ADDRESS>", "vip"=>"<IP_ADDRESS>", "dhcp_range"=>"<IP_ADDRESS> <IP_ADDRESS>", "dhcp_subnet"=>"<IP_ADDRESS>", "proxy"=>"http://devproxy.bloomberg.com:82", "hostname"=>"bcpc-bootstrap"}
http://<IP_ADDRESS>
Retreived cluster data appears to be invalid -- node IDs must be positive integers between 0 and 256 (1..255)
/opt/chef/embedded/lib/ruby/gems/2.3.0/gems/cluster_def-0.1.0/lib/cluster_def.rb:88:in `validate_cluster_def'
/opt/chef/embedded/lib/ruby/gems/2.3.0/gems/cluster_def-0.1.0/lib/cluster_def.rb:112:in `parse_cluster_def'
/opt/chef/embedded/lib/ruby/gems/2.3.0/gems/cluster_def-0.1.0/lib/cluster_def.rb:140:in `fetch_cluster_def_http'
/opt/chef/embedded/lib/ruby/gems/2.3.0/gems/cluster_def-0.1.0/lib/cluster_def.rb:124:in `fetch_cluster_def'
/var/chef/cache/cookbooks/bcpc/libraries/utils.rb:193:in `fetch_all_nodes'
/var/chef/cache/cookbooks/bcpc/libraries/utils.rb:232:in `get_head_nodes'
/var/chef/cache/cookbooks/bcpc/recipes/mysql.rb:219:in `from_file'

node['bcpc']['boostrap']['cluster_def_path'] is not being populated when the URL for the cluster-definition is being generated from the ruby gem class BACH::ClusterDef
made sure the attribute is there in my environment:
knife environment show Test-Laptop
chef_type:           environment
...
json_class:          Chef::Environment
name:                Test-Laptop
override_attributes:
  bcpc:
    bootstrap:
      cluster_def_path: /cluster-def/

got it working. forgot to upload my environment.
oops


Blackhole Detection: stop accepting jobs if they are consumed at a rate higher than the configured limit

Sometimes even if the Glidein tests are successful, it fails quickly all the jobs running on it and asks for new ones.
This behavior is nicknamed blackhole.
By setting a maximum consumption rate and declaring unfit (and unable to accept/match new jobs) a Glidein consuming jobs faster than the configured rate, we can protect the system from undetected failures.
This is the mechanism to be implemented by this ticket.
A new HTCSS feature called STARTD_LATCH_EXPRS (https://opensciencegrid.atlassian.net/browse/HTCONDOR-171) should be useful to implement an irreversible condition triggering the blackhole status.
This feature request is being ported from Redmine ticket R#23253 to 3.10.x
Blackhole Detection Logs: Publishing Expression/ClassAd Attributes to the StartdLogs
Description:
The results of an expression evaluating if a node is a blackhole(R#19214) are published in the machine classAd. We would like to see them in the StartdLog. The logs about blackhole detection are covered in condor logs and glidein logs( client directory in the Factory).
We were discussing with HTCondor team about publishing an expression/classad to the StartdLog and/or an external file. Between the different ideas, it came up that we cannot use a hook that can be triggered each time an attribute changes the value as it would be impractical.
If we wanna use a startd_cron that periodically checks and publishes the value (a script accessing the machine classAd and writing out the interesting value), it could work. Although we wouldn't be able to write a message to the StartLog very easily.
TODO: Implement the periodically checking and writing in the startd logs with startd_cron.
NOTE to keep in mind from TJ: Check if there is something in the glidein mechanism that would give us a cron-like place to put a hook that would be better than using STARTD_CRON.
This feature request is related to Redmine Feature R#19214 - Add a configurable limit to the rate of jobs running and fail the glidein if the rate is passed. The notes/description of R#19214, carried over from Redmine, is attached: glideinwms-19214.pdf

From the discussion at the monthly HTCondor-Fermilab meetings:
3 - Allow history in startd attributes (Marco Mambelli) [In Progress]
Description: this was requested to complete a black hole protection mechanism using the jobs rate (https://cdcvs.fnal.gov/redmine/issues/19214). There are open HTCondor tickets
Not going to make it into 9.0.0, New feature for 9.1.X.
No progress apr-may
ZKM: This is now JIRA ticket: https://opensciencegrid.atlassian.net/browse/HTCONDOR-171
Action item on Marco/Gwms: Gather a concrete list of attributes to keep, add to ticket/document. ADDED.
Would like the ability to have history of an attribute that we set within the Glidein,
Currently we have an attribute per slot: BLACKHOLE_TRIGGERED_$(i) or one if a partitionable slot is used. We want history for these because we want the variable to behave like a trip switch, once set because the jobs went over a certain threshold we'd like this to remain set (also if the pilot stops accepting jobs and the threshold goes down (the pilot keeps running for a bit to avoid that a new one starts in its place.)
This is calculated using RecentJobBusyTimeAvg, RecentJobBusyTimeCount but it should not be relevant
Action Item on HTC (Dec 2021): Review the attributes listed and update the JIRA/document
AI: Follow up from HTC: [https://openscien cegrid.atlassian.net/browse/HTCONDOR-171](https://opensciencegrid.atlassian.net/browse/HTCONDOR-171)
July–no progress..
August - work in progress
September–work still in progress
October–marco can shift the original redmine issue to a github issue so it will be visible to Cole.. we already have access to the total number of jobs started but we don’t have the rate.  Schedd ads have history, startd jobs
December–Cole can now see the redmine issue–up until now there has mostly just been discussion.
Glide checks the machine classad with a periodic machine to advertise to the htcondor classad to have a history, to check previous value of the attribute to trigger the START attribute to go false or something like that.
MArco–problem with black holes they churn too many jobs, want to block it from receiving new jobs.  But if we disable the node the rate of consumption goes down and it will look ok
Cole–have discussed with TJ–he has some concerns with history in the startd.
New idea to propose:  build a couple knobs onto the startd cron that would allow a condition to add certain attributes to the machine ad until the lease time on the startd cron is up.
Marco–want next loop to be able to not change the value if it was set in the previous one.  Would it ignore updates during the lease?  Cole: Yes.
Should followup in an e-mail loop with TJ and Marco  to put more details down so we can look in more detail.
January –Cole sent a e-mail to Marco –haven’t followed up yet.  TJ mentioned something about a lighter weight startd cron that he was working on.  Goal is to implement an attribute that could set and not change in the future and using the past value you could see that there was a blackhole.  Todd–did you want the history to be able to set an attribute back?  Marco–want something that’s tripped and remains set.  If rate of starts goes above a certain value we want to trigger a blackhole flag and leave it set so that the rate of starts doesn’t go to zero.  Why  not have it living all the time.whatever it spits to stdout will go into the classads. Here is an example of a startd cron that lives all the time (loop with a sleep) and queries the startd directly without any collector access:
https://www-auth.cs.wisc.edu/lists/htcondor-users/2022-December/msg00049.shtml
February –no update
March–no update
April–Cole did make a bash script which can poll the startd as above, will send to Marco.
Also new STARTD configuration option called “latch expressions”.. Set a Latch name, when it evaluates to true it sets 2 different startd attributes.  Explore 10.4 docs it is in there.  Marco–interested in trying with the latch.
STARTD_LATCH_EXPRS
May - Cole to send out bash script
June– script was sent.. No update yet.
August 2023–nothing has moved on the JIRA ticket in more than a year
Marco–Namratha is working on a glideinwms ticket using the startd LATCH expressions now.
Sep 2023 still in progress…
Oct 2023 -  Still in progress
Nov 2023 - Still in progress - Current plan is to use the LATCH_EXPRS
Dec 2023 – anything move?  Still waiting.

Material about the topic:

Redmine ticket 19214: Add a configurable limit to the rate of jobs running and fail the glidein if the rate is passed (main goal)
Redmine ticket 23253: Blackhole detection logs: Publishing expression/classAd attributes to the StartdLogs
Condor ticket 6698: Provide the ability to identify black hole slots (use this to have the statistics to use in the classad)
Condor ticket 7328: Make knob for the startd to drop final machinead into log on shutdown (use this to publish the results in the StartdLog - so admin can know if the Glidein was a Black hole)
Condor ticket 171, was Condor ticket 7329: Keep history of updates to machine ads similar to how job ads work (this resulted in the latch expression which will block the black-hole status to revert back after stopping to process new jobs)
There is some work done in branch v35/19214. It is old (v3.5)

Plan of work:

Check the content of  v35/19214 (git checkout v35/19214; git difftool 33b28f7e2afccac394b7c1ad3717d00104deb32d)
Start from master and re-apply the changes (only the ones in the meaningful files - the rest can be a separate PR if desired and not already in the code):

creation/web_base/condor_startup.sh
creation/web_base/condor_vars.lst
doc/factory/custom_vars.html

A commit w/ these initial changes reapplied could be credited to Lorena
Test the feature
Add the latch expression so that GLIDEIN_BLACKHOLE is not changing back once jobs are paused


gha: Replace deprecated set-output commands

The changes are done by below command, thanks to @tklauser in cilium/cilium-cli#1296
sed -i \
  '/::set-output/ {
    s/::set-output name=//;
    s/::/=/;
    s/$/ >> $GITHUB_OUTPUT/;
  }' \
.github/workflows/*.yaml

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Relates: #22890
Signed-off-by: Tam Mach<EMAIL_ADDRESS>

changes are for GHA only, full CI is not required. As required review is in, marking this ready to merge.


ENH remove asserts in the SWIG interface

The asserts in the SWIG interface kill the python interpreter. This is bad form.
Closes #479

Pull Request Test Coverage Report for Build 2218

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.603%

Totals

Change from base Build 2210:
0.0%

Covered Lines:
556

Relevant Lines:
594

💛  - Coveralls

Pull Request Test Coverage Report for Build 2218

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.603%

Totals

Change from base Build 2210:
0.0%

Covered Lines:
556

Relevant Lines:
594

💛  - Coveralls

Pull Request Test Coverage Report for Build 2218

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.603%

Totals

Change from base Build 2210:
0.0%

Covered Lines:
556

Relevant Lines:
594

💛  - Coveralls

OK @rmjarvis. This PR is ready for some quick CR. I am honestly 50/50 on having the checks here. It is definitely safer, but CCL only ever calls ccllib via functions which always do the right thing. So technically these checks are not needed. /shrug