Parameter sidecar files

From #153:
SEQ files don't contain any information about the scan, so there was a question if we could read this from a "sidecar" file, like we do with other formats with their proprietary implementations. One idea would be to have a simple file, maybe in .ini format, or .yml, which contains that information. This idea could even be extended to other formats that need additional information, like raw. Something like this:
my_dataset.yml:
format: SEQ
path: something.seq
scan_size: [256, 256]
dark_frame: dark.tif

my_other_dataset.yml:
format: RAW
path: other.bin
dtype: u2
scan_size: [256, 256]
detector_size: [128, 128]
dark_frame: dark.tif

These yml files could then provide one-click opening in LiberTEM, even if the underlying raw dataset doesn't provide enough information.

Notes about the dark_frame parameter (and other corrections): in addition to the path to the file, there may be more parameters needed, for example when loading raw binary data, the dtype needs to be specified, or the array name when loading matlab files.

Ah, that resonates with the discussion about specifying bad pixels, gain map, dark frame and also other parameters for cases where the original format doesn't contain that.

I want revive the discussion here and gather some ideas what should be achieved and what open questions are still around.

Is there already something similar like parameter sidecar files for the cluster class - https://github.com/LiberTEM/LiberTEM/blob/master/src/libertem/io/dataset/cluster.py#L63-L75 ?
Which format do we prefer? YAML sounds suitable. If we don't need a specific feature from one specific configuration file format I think it's best to aim for consistency across the LiberTEM project and choose a format accordingly

Is there already something similar like parameter sidecar files for the cluster class - https://github.com/LiberTEM/LiberTEM/blob/master/src/libertem/io/dataset/cluster.py#L63-L75 ?

Yeah, those are very specific for that use case. I'm also not sure if the cluster dataset will survive - for caching, we are now using fscache instead, and the cluster ds was mostly meant to be used as a backend for caching...

Which format do we prefer? YAML sounds suitable. If we don't need a specific feature from one specific configuration file format I think it's best to aim for consistency across the LiberTEM project and choose a format accordingly

I think the main candidates are: YAML, JSON, TOML.
JSON
Pro:

very simple format, easy to read/write from Python and other languages
included in the Python stdlib

Con:

strict, users need to be aware of not having trailing commas etc.
https://www.arp242.net/json-config.html

YAML
Pro:

user-friendly format, not as strict as JSON

Con:

Some surprising behavior (classical example: in language: no, the literal no is de-serialized to a bool False value; whereas in language: de, de is de-serialized as a string)
Need to take care to use safe loading to not execute arbitrary code...
https://www.arp242.net/yaml-config.html for some examples

TOML
https://github.com/toml-lang/toml
Not sure about this one, as I haven't used it yet (other than writing some configuration files), but it may be a good candidate:
Pro:

user-friendly simple syntax (?), meant for writing configuration files

Con:

Not included in stdlib
Not meant for serializing arbitrary objects - but that should not be an issue for this use-case

Looking more into it, I kind of like TOML:

TOML shares traits with other file formats used for application configuration and data serialization, such as YAML and JSON. TOML and JSON both are simple and use ubiquitous data types, making them easy to code for or parse with machines. TOML and YAML both emphasize human readability features, like comments that make it easier to understand the purpose of a given line. TOML differs in combining these, allowing comments (unlike JSON) but preserving simplicity (unlike YAML).

Because TOML is explicitly intended as a configuration file format, parsing it is easy, but it is not intended for serializing arbitrary data structures. TOML always has a hash table at the top level of the file, which can easily have data nested inside its keys, but it doesn't permit top-level arrays or floats, so it cannot directly serialize some data. There is also no standard identifying the start or end of a TOML file, which can complicate sending it through a stream. These details must be negotiated on the application layer.

In [1]: import toml

In [2]: toml.loads("""
   ...: [dataset]
   ...: type = "tvips"
   ...: path = "/home/alex/Data/TVIPS/rec_20200623_080237_000.tvips"
   ...:
   ...: [corrections]
   ...: dark_frame = "/home/alex/Data/TVIPS/dark.tif"
   ...: excluded_pixels = [[0, 0], [128, 128]]
   ...: """)
Out[2]:
{'dataset': {'type': 'tvips',
  'path': '/home/alex/Data/TVIPS/rec_20200623_080237_000.tvips'},
 'corrections': {'dark_frame': '/home/alex/Data/TVIPS/dark.tif',
  'excluded_pixels': [[0, 0], [128, 128]]}}

The paths above could also be relative: if the path starts with './', it will be joined with the path of the directory that contains the sidecar file.
For the corrections, we could also think about accepting some parameters, like this:
In [4]: toml.loads("""
   ...: [dataset]
   ...: type = "tvips"
   ...: path = "/home/alex/Data/TVIPS/rec_20200623_080237_000.tvips"
   ...:
   ...: [corrections]
   ...: excluded_pixels = [[0, 0], [128, 128]]
   ...:
   ...: [corrections.dark_frame]
   ...: path = "/home/alex/Data/TVIPS/dark.tif"
   ...: format = "TIFF"
   ...:
   ...: [corrections.gain_map]
   ...: path = "/home/alex/Data/TVIPS/gain.bin"
   ...: format = "RAW"
   ...: dtype = "float32"
   ...: """)
Out[4]:
{'dataset': {'type': 'tvips',
  'path': '/home/alex/Data/TVIPS/rec_20200623_080237_000.tvips'},
 'corrections': {'excluded_pixels': [[0, 0], [128, 128]],
  'dark_frame': {'path': '/home/alex/Data/TVIPS/dark.tif', 'format': 'TIFF'},
  'gain_map': {'path': '/home/alex/Data/TVIPS/gain.bin',
   'format': 'RAW',
   'dtype': 'float32'}}}

(loading corrections directly in Context.load is not supported yet, but I guess with the sidecar format, it makes sense to support this - i.e. store a CorrectionSet on the DataSet as the default, which then will be used in Context.run_udf if nothing else is specified)

I'm adding this to the 0.10 milestone - @jhgee thank you for kick-starting this discussion again! If you'd like to help out on building this feature, it would be good to have a concrete specification for the sidecar file, and maybe have a go at implementing a prototype. If you encounter any difficulties, we are here to help!


Run time clip length

In this PR we've added All time of the clip fields in the top of the script section. we've made the changes in following files

Home.vue
Script.vue

this doesn't work for me - nothing happens

needs a test case

Please use font face and size as per design

@ArindamReact please address test failure

Please use font face and size as per design

Can you please let us know which font family and font size we need to apply

Bree Serif Regular - 24px


Added Scipy dependency in requirements.txt for mathematical operations in pose_solver.py

Scipy.spatial.transform is used in pose_solver to return the Rotation.

Looks good, thank you for adding this. One small request - can you add back the newline to the end of requirements.txt? It's probably not a huge issue, but it can't hurt to remain compliant with the POSIX standard of what defines a file. Background: https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

Perfect, thank you!


1317-parent-constructor

Fixes #1317
I have tried to add a test for this in tests/Propel/Tests/Generator/Behavior/ConcreteInheritance/ConcreteInheritanceBehaviorTest.php, but because of the on-the-fly generated classes I was not able to override the constructor of ConcreteContentSetPk.

Looks like CS is failing

Any additional reviews here so we can merge this?


move CI to GitHub Actions

GitHub actions now support CI.
This would allow us to unify our CI setup into a single file.
Also at the moment every other Travis build fails due to timeouts (unrelated to the code AFAICT) so we could avoid this.

Closed by #26


Add FHI norway COVID19 samples

@marcadella Norwegian samples, nice!
Thanks for this contribution :heart:

... and here are your results @marcadella

https://usegalaxy.eu/u/sars-cov2-requests-bot/h/gx-user-request-fhinorwaysamples
https://usegalaxy.eu/u/sars-cov2-requests-bot/h/gx-user-request-fhinorwaysamples---reporting
https://usegalaxy.eu/u/sars-cov2-requests-bot/h/gx-user-request-fhinorwaysamples---consensus

where the first Galaxy history covers QC, mapping and variant calling up to annotated VCFs,
the second has tabular reports of variants and a plot of variants and their allele-frequencies across the whole batch of samples
and the third ends in the consensus fasta sequences of all samples
export of bams, vcfs, and fastas to our public FTP server will happen next. Exported data should become available at ftp://xfer13.crg.eu within the next two days.


Add Sam's entry

@sctyner here's the PR with the details (from your website) as discussed in the e-mail - let me/us know if it works for you or if you'd love to have something changed ☺
@drmowinckels just an FYI, we'll need to wait for Sam's confirmation first ☺

Thank you for adding your blog to the list and for making free and open R content 😊 🥳 🎉

@drmowinckels if it looks good to you, we’re good to go ☺ Thank you!


Headers issue in application gateway

How to resolve the headers issues in application gateway
When a new deployment occurs the headers are missing

Hey there, can you provide some more detail here?


Components Package

Components will be the items that are used to make a game (As separated by the items that make the engine run.)
Components: Sprites and in game objects.
Utilities: View, Controller, Publisher and similar.

Add with PR #32


Fix customResourceDiscoverySet controller

What this PR does / why we need it:
This PR fixed the customResourceDiscoverySet Bug. The bug is as follows:

2 provides use the same-named CustomResourceDiscoverySet
The 	// Cleanup uncontrolled CRDiscoveries which was intended to clean up CRDiscoveries for deleted service clusters assassinates other providers CRDiscoveries. Why? Because the lookup isn't namespace bound but crosses the namespace boundary.

This PR fixes this in 2 ways, for extra safety:

the lookup is now namespace bound
the label value is now namespace aware

NONE

/retest

/retest

/retest

/lgtm


Add itertools.batched Support

Adds the itertools.batched function new in python 3.12
https://docs.python.org/3/library/itertools.html#itertools.batched

@youknowone

Thank you so much! Could you also update test_itertools from CPython 3.12 to ensure this patch is compliant its spec? The related issue is #5104

I went ahead and added the 3.12 itertools_test update to this PR.
Notes:

This caught an out-of-order exception throw in the batched implementation. Corrected now.
I had to mark a number of previously passing tests as ignored, since they now expect DepreciatedWarnings to be thrown.

Build failures seem unrelated?

Build failures seem unrelated?

The macOS failure in test_re seems unrelated. However, can you please run cargo fmt to see if that fixes the other failure? (And, for good measure, consider running cargo clippy?)

Build failures seem unrelated?

The macOS failure in test_re seems unrelated. However, can you please run cargo fmt to see if that fixes the other failure? (And, for good measure, consider running cargo clippy?)

Here's the results - no changes or issues generated


Adding logging

Every part of the application should be logged as it's easier to debug or monitor.

Closing in favour of https://github.com/fusioneng/gif2html5-app/pull/29


--nicks  Set nicknames file | Hot to use?

I'm afraid to sound silly, but what format should the file have as well as the content?
INFO | Loading nicknames from specified file
INFO | Loaded 0 valid nicknames
ERROR | No valid nicknames loaded

just a list of lines is not working,
array format like [nickname1, nickname2] or ["nickname1", "nickname2"]  doesn't work either.
what should it be?)
Thanks

Ok, I've found this one:
https://github.com/crpmax/mc-bots/blob/main/src/main/resources/files/nicks.txt
and it seems like my nicks are not valid. What are the validation requirements then?

update here
Proxy list file..
I'm not sure but I cannot figure out how to properly set that proxies list.


RFC: add BLAS Level 1 dswap routine

Checklist

Please ensure the following tasks are completed before submitting a feature request.

[X] Read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

Description

Description of the feature request.

This RFC proposes to add a routine to interchange two vectors as defined in BLAS Level 1 routines. Specifically adding @stdlib/blas/base/dswap is proposed.
Related Issues

Does this feature request have any related issues?

No.
Questions

Any questions for reviewers?

No.
Other

Any other information relevant to this feature request? This may include screenshots, references, sample output, and/or implementation notes.

No.

Resolved via fbaef2dbb2ca5f8624f673c5b888475c411c8c27.


Hopefully a parameter "end_number" will be added for the end number of the image sequence.

Just like avisynth's ImageReader, it can read any number of images.

Why do you need an end number? The end is automatically detected based on the image files

I want to use it for a slideshow script. But it can only read two pictures.

Here is my script:
from vapoursynth import core
video = core.bs.VideoSource(source=r'E:\002\001%02d.jpg')
video = core.std.AssumeFPS(video,fpsnum=1, fpsden=15)
video = haf.ChangeFPS(video, 24000, 1001)
audio = core.bas.Source(r'E:\Audio\xxx.mp3', track=-1)
audio.set_output(1)
video.set_output(0)

It's still automatically detected. This issue makes no sense.

Why it only read part of the pictures, it only read 25 pictures (00.jpg-43.jpg).
I am using the latest version.
from vapoursynth import core
from havsfunc import ChangeFPS
video = core.bs.VideoSource(source=r'E:\002\001%02d.jpg', start_number=0)
video = core.std.AssumeFPS(video,fpsnum=1, fpsden=6.0)
video = ChangeFPS(video, 24000, 1001)
video.set_output()

Couldn't reproduce


polybar: 3.5.7 -> 3.6.1

Motivation for this change
changelog: https://github.com/polybar/polybar/releases/tag/3.6.0
see also: https://github.com/polybar/polybar/issues/1971#issuecomment-1055754773
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

 Should it be added to the changelog?

This release introduces several breaking changes, right? Should it be added to the changelog?
Would be nice. Can you do that?

IMO we should rebase this after https://github.com/NixOS/nixpkgs/pull/168596 is merged, and we are good to go here!

@fortuneteller2k Could you rebase and re-generate docs again now that #168598 is merged?


Fill out 'Merge a Pull Request' section in CONTRIBUTING.md

There is a placeholder in CONTRIBUTING.md to instruct contributors on the steps they should follow to merge a pull request. Let's fill it!

Closing in favor of https://github.com/WeAllJS/weallcontribute/issues/6


Add support for RSA PRIVATE KEY in PemReader

We should probably also support RSA PRIVATE KEY as an alternative loading X509 certificates. This is encoded as PKCS#1 and just the base64-encoded private key.
Originally posted by @heaths in https://github.com/Azure/azure-sdk-for-net/pull/19018#discussion_r583277313

See https://github.com/dotnet/runtime/blob/6a80a380a1644d962137ad62bc16067bc0dbfb72/src/libraries/System.Security.Cryptography.X509Certificates/tests/X509Certificate2PemTests.cs#L223-L241 for some examples where X509Certificate2 does support PKCS#1 RSA and ECDsa private keys, though KV doesn't format keys it created that way. Will need to test import.

Actually, since lines ~74 through 102 assume RSA, that will have to be changed. The only way we could tell is to also download the key and check it's type before deciding which route to go down. ECDsa certificates have their own extension methods.

@heaths has this been recently asked by any customers? If not do you see us implementing in the near future?

No. It was more of a "we should do this in case" feature request, but we can close it for now and wait for user feedback.


Exception thrown while trying to create new component

Bug Report or Feature Request (mark with an x)
- [x] bug report
- [ ] feature request

Area
- [x] devkit
- [ ] schematics

Versions
Node 10.4.0
NPM 6.1.0
Repro steps
ng new xxx --routing
npm i -S bootstrap @nebular/theme
ng g c home

The log given by the failure

Unexpected token ] in JSON at position 950

Tried it again and works well


Convert Cadwyn to a middleware

Currently, FastAPI first validates a request in its correct version, and then we migrate request to latest. For responses, it goes in reverse: we migrate response from latest, and then FastAPI validates the response. This approach tightly binds our versioning logic to FastAPI and causes us to do a lot of hacks. Instead, we should use a middleware that will see each request first and convert it to latest. This will significantly simplify our code and make it easier for us to keep compatibility with future FastAPI versions.

Request comes
pick version (version picking middleware)
migration middleware

Get body for old version
solve_dependencies for old version
convert to latest
set api version header to latest version

run the endpoint

Alternatively, custom route classes might be a good fit.


feat: add useHistoryState()

Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3b060f6) 90.85% compared to head (65487db) 90.40%.
Report is 15 commits behind head on main.

Files
Patch %
Lines

packages/router/src/history/state.ts
40.00%
6 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2106      +/-   ##
==========================================
- Coverage   90.85%   90.40%   -0.46%
==========================================
  Files          24       25       +1
  Lines        1115     1125      +10
  Branches      347      348       +1
==========================================
+ Hits         1013     1017       +4
- Misses         63       69       +6
  Partials       39       39

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add backpackers

http://www.barmeister.com/drinks/recipe/2472/

Closed with 9f8a940cb50210c8467783702e62df2585f93495


Update README.md

Amazing contributions as always, Bill!

Don’t forget to put this one on your resume!


select element not updating on user interactions, ngshow uses its model

I have a non-dynamic select field in my view with several options, and a number of ng-show conditions later on in the view that use the value of said select field to determine if they should display or not.
The ng-show blocks toggle when they're suppose to meaning the model is updating as expected but the select field rendering the model value doesn't. There's no special controller code changing the model, just the user interacting with the field.
The code looks something like this:

	Selection

  <select ng-model="data.mySelection">
	<option>1</option>
	<option>2</option>
	<option>3</option>
  </select>

  <ion-toggle ng-model="data.extraOption" toggle-class="toggle-calm">Extra Option</ion-toggle>

I can't replicate the issue in Chrome (via ionic serve), it only seems to be an issue after a mobile build for Android (and I haven't tried iOS yet).
Am I doing something wrong here or is this an ionic/angular bug?

Greetings @alexkb!
We are now requiring all issues to be submitted through our custom issue form so that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
This issue will be closed if not resubmitted through the form. Please fill out the rest of the form so that we may assist you.
Thank you for allowing me to assist you.

I've just updated my ionic project from v1.0.0-beta.13 to v1.0.0-beta.14, which also updated some of the angularJS dependencies (1.2.something to 1.3.6), and it seems to have fixed the issue.
I can't see anything obvious in the ionic changelog so perhaps it was an angular thing. Looking through angular's changelog, there are several mentions of select being improved between 1.2 and 1.3.6, so I'd say it was angular.


Improve TAA

Objective

Improve TAA quality
Prevent smearing from motion vectors that point to pixels no longer on-screen
Use textureSampleLevel() which is probably faster than textureSample() (Thanks to @DGriffin91)

Followup

Apply FXAA when accumuluated_samples = 1 (#8847)

Changelog

Improve TAA quality
Fixed TAA smearing when reprojecting pixels that are no longer on screen
Made TemporalAntiAliasNode public

@JMS55 Just tested this PR with the anti_aliasing example from my PR (https://github.com/bevyengine/bevy/pull/8847) and it appears that it does not fix the smearing.

@DGriffin91 I can only get the smearing when running your example with the noise texture specifically. Using any other texture/material (I tested a few) works fine.
I think the reason it smears on your example is due to neighborhood color clamping. Reprojection succeeds, but it's not 100% perfectly accurate, and with such a high frequency, multi-colored texture, the color clamping (which is based on neighboring pixels) performs very poorly. I could be wrong though.
I'm guessing that the reason it works in #8847 is that in my previous TAA code (what's currently in main, and what that PR is based off of), I reset the accumulation/blend factor when any motion (non-zero motion vector) is detected. Which in hindsight, wasn't a great idea. However, that did mean you didn't get any ghosting even when neighborhood clamping failed. This PR tries to keep the history even under motion.
A possible solution would be to reset/reduce accumulation when color clips by a lot or is near clipping, which iirc is what Brian Karis/Unreal did. That can be very finicky and introduce more artifacts if we're not careful. Doesn't seem like the kind of thing we should do right before 0.11.

Removing this from 0.11 as theres too much controversy here.

Well, after doing some more search, I've come to the conclusion my Mitchell-Netravali calculations were wrong, but fixing that made 0 difference and still had the same issue. Not sure how to actually fix it. May just remove that part for this PR.

Could you explain the solutions to the objectives in the PR description? It's difficult to know what the PR is doing otherwise.

Code is overall cleaned up a lot
Instead of the weird history confidence thing I was doing, I'm now using the standard "keep a count of successful reprojections, blend at a rate of 1 / count, clamped between [1, 8]" (could arguably be 16, and increasing the jitter sequence length to 16).
Prevent blurring from motion vectors pointing off-screen: accumulated_samples *= f32(all(saturate(history_uv) == history_uv));
Mitchell–Netravali filter over the 3x3 neighborhood of the input pixel to TAA, which increases sharpness vs a straight average (box filter).

@cart thoughts on how we fix this issue: https://github.com/bevyengine/bevy/discussions/9719

Shadows are clipping as you move the camera :/. I hate messing with shadows, can someone else try and fix this? @DGriffin91 :)

 Shadows are clipping as you move the camera :/. I hate messing with shadows, can someone else try and fix this? @DGriffin91 :)

You just need to extend the maximum_distance of the cascade_shadow_config to be eg. 5m instead of 3m.

Thanks, that fixed it!

I've mentioned this in the discord but want to comment here so it doesn't get lost. I think the state of the TAA in the PR currently has much more smearing/blurring under motion than the current implementation in bevy main. And still does not address the edge smearing issue that https://github.com/bevyengine/bevy/pull/8847 fixes.
Main as of 5733d2403e9a8dc86e39757fad41db169764cc2e

https://github.com/bevyengine/bevy/pull/8847

https://github.com/bevyengine/bevy/pull/8974

Main | https://github.com/bevyengine/bevy/pull/8847 | https://github.com/bevyengine/bevy/pull/8974

I don't think this can be merged until the NaN issues are solved.

Potentially related is that the history texture has negative RGB values for some things for some reason.

Nor because of the ghosting/smearing that @DGriffin91 showed above.

In addition to ghosting/smearing things are just blurry in general:
https://github.com/bevyengine/bevy/pull/8847 | https://github.com/bevyengine/bevy/pull/8974 (this PR)

With some areas highlighted in case it's not initially obvious:

I just realized that I had done these tests with vsync at 165hz and high framerate minimizes the issue. Here's setting my monitor for vsync at 60hz:
https://github.com/bevyengine/bevy/pull/8847

https://github.com/bevyengine/bevy/pull/8974 (this PR)

@DGriffin91 what does that last example at 60Hz look like on main?
OK, so, we all want to make progress on TAA. None of what I am writing is intended to offend anyone, and all efforts and contributions are sincerely appreciated.
It looks to me like this PR causes significant regressions in visual quality in its current form. As this PR currently combines multiple changes into one PR, it makes it difficult to understand what part of the changes introduces what improvements and what problems.
I think we need better in-repo test cases for common problems, such as a moving / rotating camera, perhaps if heuristics for when disocclusions are detected are based on depth differences then we need to test disocclusions at different depths, etc. Then this PR could be split into multiple smaller steps to be able to verify that each in isolation is as good or better. That will also make reviewing much easier which increases the likelihood of faster merges. When situations with PRs become unclear, it is difficult to prioritise reviewing them over other PRs that have a clear state.
I looked through #8847 and aside from needing to check the FXAA code move line-by-line, it looks like it adds camera movement and a noise texture to stress test TAA functionality. That change to example code should probably be a separate PR so we can first see how it looks on main and then how it looks with the introduced changes from any of the PRs modifying TAA.

@DGriffin91 could you separate out the example changes from #8847 so we can review and merge those first?
@JMS55 could you then split this PR into separate PRs for each logical change, and then we can review them step by step to make sure we're consistently improving things?

@superdump I've created a PR with just the example from https://github.com/bevyengine/bevy/pull/8847: https://github.com/bevyengine/bevy/pull/10183
I've also updated it with a few things:

The noisiness of the noise texture was a bit excessive without mipmaps so it now generates those.
I used deterministic PRNG for the white noise so it's consistent (ported from some gpu code)
I made the UV scale follow the window height so the density of the noise on screen is consistent. (without this a small window would render solid grey, for example)
I added a screenshot mode that animates the camera based on the current frame instead of time delta and takes a screenshot at a specific frame. This allows the TAA response and camera motion to be consistent regardless of the frame rate. I tested this at 60hz and 165hz and the resulting image looked the same.
I added a second helmet to give a bit more context for seeing detail.
Here's the result (preferably view at full 1:1 resolution):

Bevy main:

This pr:

I've abandon https://github.com/bevyengine/bevy/pull/8847 in favor of using a 3rd party plugin: https://github.com/DGriffin91/bevy_mod_taa


Error with got decompressResponse is not a function

When I use any method that has some kind of http request, I get the following error:
Type Error: decompressResponse is not a function

Here is my code:
import { Installer } from "@xmcl/installer";
import path from "path";

(async () => {
	const temp = await Installer.getVersionList();
	const app = remote.app;
	await Installer.install("client", temp.versions[0], path.join(app.getPath("userData"), "./game/"));
})();

Edit
Auth module still seems to work because if I recall correctly, it uses window.fetch instead of got.

That's pretty strange... Just to confirm, is this code fragment run over the renderer process? I have no clue on top of my mind now... Maybe I can clone your project and check it locally. Does the master branch is up-to-date?

This is a problem of got and I've opened a PR to fix it. Currently, the workaround is manually removing the browser field in package.json of got in node_modules. This is described in the issue.

That's pretty strange...
The only related issue in got is this and it seems you don't have that config in package.json.
Just to confirm, is this code fragment run over the renderer process? I have no clue on top of my mind now... Maybe I can clone your project and check it locally. Does the master branch is up-to-date?

It should be on the refactor/instance-store branch and yes, the code fragment is run in the renderer process. I am also using webpack if that makes any difference. If you don't want to clone the repo locally, you can just use this (in fact, this should also have some changes I did for testing):

Actually, I have propose a PR to fix. It just a guide to migrate to new API. You don't need to merge it.
For the decompressResponse is not a Function, currently, you have to modify the package.json of got js... Or wait it publish new version.

What does the browser field in package.json do? This seems to fix the issue on Windows but I still have the issue on Linux.

What does the browser field in package.json do? This seems to fix the issue on Windows but I still have the issue on Linux.

In node_modules/got/package.json:
{
  "browser": { "module-name": true/false }
}

If the module-name is false, webpack will ignore it in bundle. It should work for all the platform, as it's the behavior of webpack...

What does the browser field in package.json do? This seems to fix the issue on Windows but I still have the issue on Linux.

In node_modules/got/package.json:
{
  "browser": { "module-name": true/false }
}

If the module-name is false, webpack will ignore it in bundle. It should work for all the platform, as it's the behavior of webpack...

So should I add "decompress-response": true to both my project's pakcage.json and to got's package.json?

You just need remove browser field in got package.json. Adding it in your package.json won't fix the webpack bundle, since the webpack bundle the got will follow the config of got's package json.

Fixed with PR #125


Also, it might be useful to people.

Confirmed!


Add support for singularity installation

Please provide description of the purpose of this pull request, as well as its
motivation and context.
Create a Singularity class responsible for installing singularity on
slurmd, using .deb (on Ubuntu) and .rpm (on Centos) packages retrieved
from GitHub Releases.
The .deb and .rpm files are slurmd charm resources.
The Singularity install method receives the path to the file from
slurm-charms/charm-slurmd/src/charm.py.
How was the code tested?
It works with a slurm-charms up to date version which supports singularity-install action.
Final checklist

[x] I am the author of these changes, or I have the rights to submit them.
[ ] I added the relevant changed to the README and/or documentation.
[x] I self reviewed my own code.
[ ] I updated the CHANGELOG according to the contributing
guide

This looks great- though I have one concern.
Does the Singularity class need to inherit from Object to use StoredState? If not, the inheritance should be removed and the signature of init should be changed.

+1 nice work!


[QA] Slight twitch on avatar

Explorer Alpha build version:
0.3.160-main-251ca6c
Issue Description:

When standing still, the right leg of the avatar is making a small twitch
Steps to reproduce:

Just load and stand still

Reproduction rate:

[ ] < 10%
[ ]  < = 25%
[ ]  50%
[ ]  < = 75%
[x]  100%

Severity:

[ ] Cosmetic
[x] Minor
[ ] Medium
[ ] High
[ ] Critical
[ ] Blocker

Priority:

[ ] High
[ ] Medium
[x] Low

Platforms / OS:

[ ] Windows 11
[x] Windows 10
[ ] Mac Sonoma
[ ] Mac (specify the version on Additional Notes)

Evidence:
https://github.com/decentraland/unity-explorer/assets/139157886/148440b3-9ba8-4a87-a5c2-62cee22b80d7
Additional Notes:

Unable to repro on latest versions (v0.10.0)


Pushing non-master branches

It seems like it's possible to push a non-master branch, contrary to the docs.

Deis builds are created automatically on the controller when a developer uses git push deis master.
When a new build is created, a new Release is created automatically.
Note:
Deis only supports git push to the master branch.

$ git push deis develop
Total 0 (delta 0), reused 0 (delta 0)
-----> Fetching custom buildpack
-----> Multipack app detected
       =====> Downloading Buildpack: https://github.com/heroku/heroku-buildpack-nodejs.git
       =====> Detected Framework: Node.js

-----> Creating runtime environment
...

Should the docs be updated?

ping @arschles

I recall that this is intentional after @technosophos rewrote the builder in Go, so yes the docs should be updated.

@bacongobbler is also correct for the current builder implementation - it allows pushes to all branches. I believe there was another issue or discussion about this, but its location escapes me right now.

when pushing repository from local branch to remote branch getting an error
git push test(local deis branch) test:master(remote)
when using this command docker file is building from remote branch
while building docker file it shows as below
fetch http://dl-cdn.alpinelinux.org/alpine/v3.9/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.9/community/x86_64/APKINDEX.tar.gz
ERROR: http://dl-cdn.alpinelinux.org/alpine/v3.9/main: temporary error (try again later)
WARNING: Ignoring http://dl-cdn.alpinelinux.org/alpine/v3.9/main: No such file or directory
ERROR: http://dl-cdn.alpinelinux.org/alpine/v3.9/community: temporary error (try again later)
WARNING: Ignoring http://dl-cdn.alpinelinux.org/alpine/v3.9/community: No such file or directory
ERROR: unable to select packages:
  bash (no such package):
    required by: world[bash]
The command '/bin/sh -c apk add --update bash && rm -rf /var/cache/apk/*' returned a non-zero code: 1

I searched and did many troubleshoot to resolve this error regarding docker.
but now I doubt that it may error from github or deis push.
we are installing deis workflow in eks cluster and deploying deis apps in eks cluster.
i don't have any idea why it happening. can anyone help me to resolve this error?thank you


calling another search within client.search and res.on("searchEntry")

Hi all,
Iam trying the following:
const getPhones = (callserver) => {
  const phones = [];
  const opts = {
    filter: `(objectClass=Phone)`,
    scope: 'sub',
  };
  return new Promise((resolve, reject) => {
    login(function () {
      client.search(`cn=${callserver === 'primary' ? primaryCS.cn : secondaryCS.cn},cn=Modules`, opts, function (err, res) {
        if (err) {
          console.log('Error in promise', err);
        }
        res.on('searchEntry', function (entry) {
          const opts = {
            filter: `(objectClass=*)`,
            scope: 'sub',
          };
          client.search(`${entry.object.dn}`, opts, function (err, res2) {
            res2.on('searchEntry', function (entry2) {
            phones.push({ ...entry.object, detail: entry2.object }); // this doesnt work, but if console entry2 just before this line it will console it correctly
});
          });
        });
        res.on('end', function () {
          resolve(phones);
        });
        res.on('err', function () {
          reject('Error');
        });
      });
    });
  });
};

but its not working correctly.
i have opened issue on stack too:
Here
could anyone help?

It looks like you are resolving the first search before the second search returns a value.

client.search(..., function (err, res) {
  res.on('searchEntry', function (entry) {
    console.log(1);
    client.search(..., function (err2, res2) {
      res2.on('searchEntry', function (entry2) {
      console.log(2);
    });
  });
  res.on('end', function () {
    console.log(3);
  });
});

The previoud code will log:
1
3
2

You have to find a way to wait to resolve the promise until all searches are complete.
Something like:
let searches = 0
client.search(..., function (err, res) {
	searches++
  res.on('searchEntry', function (entry) {
    client.search(..., function (err2, res2) {
      searches++
      res2.on('searchEntry', function (entry2) {
        ...
      });
	    res2.on('end', function () {
        searches--
	      if (searches === 0) resolve()
	    });
    });
  });
  res.on('end', function () {
    searches--
    if (searches === 0) resolve()
  });
});

👋
On February 22, 2023, we released version 3 of this library. As a result, we are closing this issue/pull request.
Please see issue #839 for more information, including how to proceed if you feel this closure is in error.


Make a front-end website to demonstrate the app

Make a website as demonstration for the API and the Chrome extension.

Resolved by #19


OP_REQUIRES failure in c++ LoadSavedModel with conv2d w/ bias into an Add

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Arch Linux, latest
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: n/a
TensorFlow installed from (source or binary): installed from arch community
TensorFlow version (use command below): tensorflow-opt-cuda 2.3.0rc2-2
Python version: 3.8.4
Bazel version (if compiling from source): n/a
GCC/Compiler version (if compiling from source): 10.1
CUDA/cuDNN version: cuda 11.0.2-1 cudnn <IP_ADDRESS>-2
GPU model and memory: nvidia Titan Xp (12GB)

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

2020-07-26 12:25:21.992520: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.11.0
unknown 2.3.0-rc2
Describe the current behavior
I have successfully trained a little custom keras resnet with skip connections using the python side of things, so (simplified) the portion of network that is erroring during c++ load looks like:
a
+------------+
|            |
conv2d       |
|            |
lrelu        |
|            |
conv2d       |
|            |
Add ---------+
|
out

when I save this keras model using model.save( 'foo' ), then attempt to load it in and execute it using the c++ layer, during execute, it is unable to run, reporting: Fusion is not implemented: [BiasAdd,Add]
[[{{node foo/test_residadd/add}}]]"
Describe the expected behavior
I would have expected it to load and optimize correctly so I could use it for inference in a c++ application
Standalone code to reproduce the issue
Files attached. you can see the steps in recreate.sh, but basically, run the python file, this will save a model, then compile / run the c++ program to load the model.
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
2020-07-26 13:21:36.941101: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.11.0
2020-07-26 13:21:36.960504: I tensorflow/cc/saved_model/reader.cc:31] Reading SavedModel from: /home/kimball/Development/bugreport/foo
2020-07-26 13:21:36.961289: I tensorflow/cc/saved_model/reader.cc:54] Reading meta graph with tags { serve }
2020-07-26 13:21:36.961304: I tensorflow/cc/saved_model/loader.cc:234] Reading SavedModel debug info (if present) from: /home/kimball/Development/bugreport/foo
2020-07-26 13:21:36.961385: I tensorflow/core/platform/cpu_feature_guard.cc:142] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN)to use the following CPU instructions in performance-critical operations:  FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2020-07-26 13:21:36.985670: I tensorflow/core/platform/profile_utils/cpu_utils.cc:104] CPU Frequency:<PHONE_NUMBER> Hz
2020-07-26 13:21:36.986383: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x55de6bc0eaa0 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2020-07-26 13:21:36.986394: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version
2020-07-26 13:21:36.987511: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcuda.so.1
2020-07-26 13:21:37.057104: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:982] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2020-07-26 13:21:37.057480: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x55de6bc0e030 initialized for platform CUDA (this does not guarantee that XLA will be used). Devices:
2020-07-26 13:21:37.057492: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): TITAN Xp, Compute Capability 6.1
2020-07-26 13:21:37.057594: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:982] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2020-07-26 13:21:37.057904: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1716] Found device 0 with properties:
pciBusID: 0000:01:00.0 name: TITAN Xp computeCapability: 6.1
coreClock: 1.582GHz coreCount: 30 deviceMemorySize: 11.88GiB deviceMemoryBandwidth: 510.07GiB/s
2020-07-26 13:21:37.057932: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.11.0
2020-07-26 13:21:37.059248: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcublas.so.11
2020-07-26 13:21:37.059806: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcufft.so.10
2020-07-26 13:21:37.059948: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcurand.so.10
2020-07-26 13:21:37.061270: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcusolver.so.10
2020-07-26 13:21:37.061599: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcusparse.so.11
2020-07-26 13:21:37.061666: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudnn.so.8
2020-07-26 13:21:37.061692: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:982] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2020-07-26 13:21:37.061985: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:982] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2020-07-26 13:21:37.062276: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1858] Adding visible gpu devices: 0
2020-07-26 13:21:37.062290: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.11.0
2020-07-26 13:21:37.268129: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1257] Device interconnect StreamExecutor with strength 1 edge matrix:
2020-07-26 13:21:37.268149: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1263]      0
2020-07-26 13:21:37.268154: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1276] 0:   N
2020-07-26 13:21:37.268252: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:982] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2020-07-26 13:21:37.268624: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:982] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2020-07-26 13:21:37.268930: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1402] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 10019 MB memory) -> physical GPU (device: 0, name: TITAN Xp, pci bus id: 0000:01:00.0, compute capability: 6.1)
2020-07-26 13:21:37.269287: I tensorflow/core/common_runtime/process_util.cc:146] Creating new thread pool with default inter op setting: 2. Tune using inter_op_parallelism_threads for best performance.
2020-07-26 13:21:37.275552: I tensorflow/cc/saved_model/loader.cc:199] Restoring SavedModel bundle.
2020-07-26 13:21:37.388514: I tensorflow/cc/saved_model/loader.cc:183] Running initialization op on SavedModel bundle at path: /home/kimball/Development/bugreport/foo
2020-07-26 13:21:37.391535: I tensorflow/cc/saved_model/loader.cc:303] SavedModel load for tags { serve }; Status: success: OK. Took 431036 microseconds.
Loaded model ok...
2020-07-26 13:21:37.422171: W tensorflow/core/framework/op_kernel.cc:1744] OP_REQUIRES failed at conv_ops_fused_impl.h:700 : Unimplemented: Fusion is not implemented: [BiasAdd,Add]
ERROR: Fusion is not implemented: [BiasAdd,Add]
[[{{node foo/testresid_add/add}}]]
bugreport.zip

@kthurston
Will it be possible for you to share code snippet to reproduce the issue.It helps us in localizing the issue faster.Thanks!

I did - it's all in bugreport.zip that is attached to the issue there at the end of it

Also faced the same issue while trying to port this paper to tf 2.x. Basically same system settings as Kimball, but on a 2060 Super.
If needed, I can try to build a notebook with my current attempt, although I'm not sure if it would be more useful than Kimball's one since the code I'm trying to reproduce seems to be way too complex.

fyi: retested with cudnn <IP_ADDRESS> and official tensorflow 2.3.0 and this is still not working, it still throws an error about not being able to fuse BiasAdd and Add.

This is still broken in tensorflow 2.5. However, if I disable MKL by running with the TF_DISABLE_MKL environment variable set, it works. Further, if I #if 0 out the code in tensorflow/core/grappler/optimizers/remapper.cc around line 1940 (where there is an #ifdef INTEL_MKL and it tests for the two BiasAdd + Add contractions), then this also works around this issue. It seems like MKL knows about that optimization, but other backends do not? How do I add that optimization to the other engines, or properly test if the graph is scheduled to run on the GPU vs letting MKL do something with it?

This is still broken in tensorflow 2.5. However, if I disable MKL by running with the TF_DISABLE_MKL environment variable set, it works. Further, if I #if 0 out the code in tensorflow/core/grappler/optimizers/remapper.cc around line 1940 (where there is an #ifdef INTEL_MKL and it tests for the two BiasAdd + Add contractions), then this also works around this issue. It seems like MKL knows about that optimization, but other backends do not? How do I add that optimization to the other engines, or properly test if the graph is scheduled to run on the GPU vs letting MKL do something with it?

@kdt3rd  nice find，it can solve my problem

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


istio-ingressgateway pods do not gracefully terminate for drain durations greater than 30 seconds

Bug description
Despite having env TERMINATION_DRAIN_DURATION_SECONDS=310 set, when an istio-ingressgateway pod's istio-proxy container enters "graceful termination", the istio-proxy only waits for ~30 seconds before being killed or shutdown.
As a result, clients encounter 504s for in-flight requests that take longer than 30 seconds.
End of istio-proxy logs:
istio-system/istio-ingressgateway-785f4c8f5d-xnrnn[istio-proxy]: 2020-07-15T21:11:14.591809Z	info	Agent draining Proxy
istio-system/istio-ingressgateway-785f4c8f5d-xnrnn[istio-proxy]: 2020-07-15T21:11:14.591871Z	info	Status server has successfully terminated
istio-system/istio-ingressgateway-785f4c8f5d-xnrnn[istio-proxy]: 2020-07-15T21:11:14.591925Z	error	accept tcp [::]:15020: use of closed network connection
istio-system/istio-ingressgateway-785f4c8f5d-xnrnn[istio-proxy]: 2020-07-15T21:11:14.593421Z	info	Graceful termination period is 5m10s, starting...
istio-system/istio-ingressgateway-785f4c8f5d-xnrnn[istio-proxy]: 2020-07-15T21:11:44.605749Z	warning	envoy main	[external/envoy/source/server/server.cc:527] caught SIGTERM
istio-system/istio-ingressgateway-785f4c8f5d-xnrnn[istio-proxy]: 2020-07-15T21:11:44.605779Z	warning	envoy main	[external/envoy/source/server/server.cc:527] caught SIGTERM

The istio-ingressgateway deployment and pod spec shows terminationGracePeriodSeconds: 30.
Although istio-proxy (envoy) warns that it "caught SIGTERM" after ~30 seconds, I suspect the it is actually being killed by SIGKILL.
I do not encounter this bug, after I manually edited the istio-ingressgateway deployment spec to have terminationGracePeriodSeconds: 310.
Affected product area (please put an X in all that apply)
[X] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Expected behavior
The istio-ingressgateway pod should have waited the full graceful termination period specified (5m10s) before being killed or shutdown.
Steps to reproduce the bug

Create a service/deployment that can take > 1min to respond to HTTP requests along with the virtualservice and gateway resources necessary to route requests from the istio-ingressgateway to this service.

Send a HTTP request with an expected response time > 1min through the istio-ingressgateway to the upstream service.

Immediately after step 2, delete the istio-ingressgateway pod. The pod is usually killed after ~30-40 seconds, and the HTTP client receives a 504 response from the ELB.

❯ time kubectl delete pods -n istio-system istio-ingressgateway-785f4c8f5d-xnrnn
pod "istio-ingressgateway-785f4c8f5d-xnrnn" deleted
kubectl delete pods -n istio-system istio-ingressgateway-785f4c8f5d-xnrnn  0.42s user 0.14s system 1% cpu 32.943 total

Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
❯ istioctl version --remote
client version: 1.6.5
cluster-local-gateway version:
cluster-local-gateway version:
pilot version: 1.6.5
pilot version: 1.6.5
data plane version: 1.6.5 (12 proxies)

❯ kubectl version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.5", GitCommit:"e6503f8d8f769ace2f338794c914a96fc335df0f", GitTreeState:"clean", BuildDate:"2020-07-04T15:01:15Z", GoVersion:"go1.14.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.11-eks-af3caf", GitCommit:"af3caf6136cd355f467083651cc1010a499f59b1", GitTreeState:"clean", BuildDate:"2020-03-27T21:51:36Z", GoVersion:"go1.12.17", Compiler:"gc", Platform:"linux/amd64"}

How was Istio installed?
istioctl upgrade -f <manifest_below>
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system
  name: istio-operator
spec:
  namespace: istio-system

  components:
    ingressGateways:
      - name: istio-ingressgateway
        enabled: true
        k8s:
          env:
            - name: 'ISTIO_DEFAULT_REQUEST_TIMEOUT'
              value: '300s'
            - name: 'TERMINATION_DRAIN_DURATION_SECONDS'
              value: '310'
          replicaCount: 1
          podDisruptionBudget:
            minAvailable: 1

  meshConfig:
    accessLogEncoding: JSON
    accessLogFile: /dev/stdout
    defaultConfig:
      drainDuration: "301s"
      parentShutdownDuration: "302s"
      proxyMetadata:
        TERMINATION_DRAIN_DURATION_SECONDS: "303"

Environment where bug was observed (cloud vendor, OS, etc)
AWS EKS
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

Here's a workaround:
    ingressGateways:
      - name: istio-ingressgateway
        enabled: true
        k8s:
          env:
            - name: 'TERMINATION_DRAIN_DURATION_SECONDS'
              value: '310'
          overlays:
            - kind: Deployment
              name: istio-ingressgateway
              patches:
                - path: spec.template.spec.terminationGracePeriodSeconds
                  value: 310


docs: typo in homepage

Summary
Correct typo in homepage.
Test plan
s/Flexbility/Flexibility

Thanks!


[New game]: Color Shifting

🎮 Game Request
The game tests the users reaction speeds.
1.Developing a game where a user is actively required to change color of object to traverse through the course and survive.
2.The obstacles come in different colors where the player needs to change color of ball to the obstacles color to pass through it.
Tech Stack Used: HTML, CSS, JS.
Point down the features
1.Obstacle generation where obstacles of various shapes and sizes will be spawned.
2.Color switching where the user needs to change colors of ball depending on the obstacles.
3.Scoring and progression, keeping track of the score of the player and improving difficulty of the game progressing by speeding up the games pace.
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @MrVisc !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @MrVisc ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Invalid values on y-axis ticks

Hi
I've created a chart with a category x-axis, but faced with two problems below. See the Attached image file please.

The values on the y-axis ticks are [2.6, 2.5, 2.4, 2.3, 2.2, 2.1, 2.0, 1.9, 1.8, 1.7, 1.6, 1.5000000000000002, 1.4000000000000001].
Number of categories is displayed on the right side of the x-axis category name.

Is there any workaround for above issues?
Any hints are appreciated.
Thanks in advance.

I've solved problem 1 shown above.
y: {
tick: {
format: function(d) {
return floatFormat(d, 2);
},
},
},
function floatFormat(d, n)
{
	var base = Math.pow(10 , n);
	return Math.round(d * base) / base;
}


GAMES_005B Tic-Tac-Toe: Collecting user points

Users should earn and lose points for games in Tic-Tac-Toe. They are tracked in the global user score.
Acceptance Criteria:

User gets one point for every Tic-Tac-Toe game he wins
User loses two points for every game he loses

Use application context for the ScoreTracker class.


Ruby group capstone - Catalog of my things -Group task

In this branch we have implemented the following changes:

Created Item class in a separate .rb file

All Item class properties visible in the diagram have been defined and set up in the constructor method.

Implement methods:

can_be_archived?() in the Item class
should return true if published_date is older than 10 years
otherwise, it should return false
move_to_archive() in the Item class
should reuse can_be_archived?() method
should change the archived property to true if the result of the can_be_archived?() method is true

Created a main.rb file that will serve as your console app entry-point

Implement startup actions:
Present the user with a list of options to perform.
Let users choose an option.
If needed, ask for parameters for the option.
Have a way to quit the app.Description to be added

This is approved! No linter errors and code is working well. :)


[#122117381] Set Bosh RDS backup window.

What
When this is not specified, RDS will pick a random window that's
appropriate for the region. There's therefore a chance that this will
conflict with the maintenance window that we're specifying here.
Specifying the backup window avoids the possibility of these
conflicting.
How to review
Deploy from this branch, and verify that it applies cleanly.
Who can review
Anyone but myself.

The docs say:

Note that if the backup requires more time than allotted to the backup window, the backup will continue to completion.

Although I think terraform will deploy OK, I wonder if there is any potential issue of having the maintenance window just after backup. I cannot find any reference about that, only that they cannot overlap.

That's a fair point.  I'll move it an hour earlier to be sure.

LGTM


onClick prop does not work

Description
Hi, I am learning to use Viro and I am trying to add a click event to a ViroText component. I have tried to add the onClick prop to the ViroText component but it does not seem to work.
Error is Exception thrown while executing UI block: -[VRTNodeContainer setOnClick:]: unrecognized selector sent to instance 0x12f310a50 after setting onClick prop to ViroText component.
I am curious to know if there is a way to add a click event to a ViroText component or any other Viro component. Prop onPinch is working fine but onClick is not working.
Device

physical device: iPhone 11
OS: iOS 17.2.1

Code
import {
  ViroARScene,
  ViroARSceneNavigator,
  ViroCamera,
  ViroText,
  ViroTrackingReason,
  ViroTrackingStateConstants,
} from '@viro-community/react-viro';
import React, {useState} from 'react';
import {StyleSheet} from 'react-native';

const HelloWorldSceneAR = () => {
  const [text, setText] = useState('Initializing AR...');

  function onInitialized(state: any, reason: ViroTrackingReason) {
    console.log('onInitialized', state, reason);
    if (state === ViroTrackingStateConstants.TRACKING_NORMAL) {
      setText('Hello World!');
    } else if (state === ViroTrackingStateConstants.TRACKING_UNAVAILABLE) {
      // Handle loss of tracking
    }
  }

  const handleClick = () => {
    console.log('clicked1');
  };
  return (
    <ViroARScene onTrackingUpdated={onInitialized}>
      <ViroCamera position={[0, 0, 0]} active={true} />
      <ViroText
        style={styles.helloWorldTextStyle}
        text={text}
        scale={[0.5, 0.5, 0.2]}
        position={[0, 0, -2]}
        onClick={handleClick}
      />
    </ViroARScene>
  );
};

const SecondScene = (props: any) => {
  return (
    <ViroARScene>
      <ViroText
        text="This is the second scene!"
        position={[0, 0, -2]}
        style={styles.helloWorldTextStyle}
      />
    </ViroARScene>
  );
};

export default () => {
  return (
    <ViroARSceneNavigator
      autofocus={true}
      initialScene={{
        scene: HelloWorldSceneAR,
      }}
      style={styles.f1}
    />
  );
};

var styles = StyleSheet.create({
  f1: {flex: 1},
  helloWorldTextStyle: {
    fontFamily: 'Arial',
    fontSize: 30,
    color: '#ffffff',
    textAlignVertical: 'center',
    textAlign: 'center',
  },
});

Hi! Can you make a new issue in https://github.com/NativeVision/viro/issues? The issues here are for the starter kit, and not issues with NativeVision.


[ZEPPELIN-4356] Zeppelin should stop/die/etc when can't create/access notebook repo

What is this PR for?
Currently when Zeppelin can't create/access the notebook repo, Zeppelin stays up but returns MultiException; Instead it would be better to stop/die/etc.
What type of PR is it?
[Bug Fix | Improvement]
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4356
How should this be tested?
CI Pass
Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

LGTM

Merging this if no more discussion.

@bhavikpatel9977 This PR cause NotebookSecurityRestApiTest fail, could you help take a look at it ?


Frontend text is same color as background

First off, thank you for submitting this project to the Incentivized xCall Testnet.
Onto the issue: I can't see the text unless I highlight it on https://testnet.xcallscan.xyz/ because the font color is too similar to the background. It would be helpful if it was black text or something that complies with the Web Content Accessibility Guidelines. You can use https://webaim.org/resources/contrastchecker/ to check if your text / background color schemes pass.
Example:

@CyrusVorwald  oh it's so weird! I've checked on chrome, firefox and edge but didn't see this issue. Could you provide more detail about your environment? Or might be a cache issue on your browser?

Same issue for me too. Tried hard refreshing multiple times as well. I'm on linux machine.
On firefox

On vivaldi

@izyak @CyrusVorwald The root cause is theme conflict on dark mode of OS. It should be fixed soon.


Unable to get the status of a group

Describe the bug
I was previously able to check a group status by passing the group ID via the topic into the hue group node, but this no longer works. Any hints on how I can get this functionality back? In particular I was using the groups node to test if lights were on when my flow received an input from a sensor.
Flow to Reproduce
[{"id":"621d2809.e8b788","type":"hue-group","z":"b25ef4d4.0a8048","name":"Check hue","bridge":"9ed1a05f.3466b","groupid":"","colornamer":true,"skipevents":false,"x":370,"y":320,"wires":[["aa35acf5.41fa7"]]},{"id":"aa35acf5.41fa7","type":"switch","z":"b25ef4d4.0a8048","name":"","property":"payload.anyOn","propertyType":"msg","rules":[{"t":"true"},{"t":"false"}],"checkall":"true","repair":false,"outputs":2,"x":570,"y":320,"wires":[["fc72ecfd.303a7"],["fc72ecfd.303a7"]]},{"id":"28d157c2.ca9ca8","type":"inject","z":"b25ef4d4.0a8048","name":"","topic":"1","payload":"","payloadType":"date","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":190,"y":320,"wires":[["621d2809.e8b788"]]},{"id":"fc72ecfd.303a7","type":"debug","z":"b25ef4d4.0a8048","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","x":770,"y":320,"wires":[]},{"id":"9ed1a05f.3466b","type":"hue-bridge","z":"","name":"Philips hue","bridge":"<IP_ADDRESS>","key":"qL6jtASLkGU1Ww3tOWLOzx8VBfgScwsZeYFmzaxB","interval":"3000"}]

Expected behavior
To receive the status on the payload of the group node, and to be able to route the payload on the value of anyOn
Please complete the following information:

NodeRED version: latest
NodeJS version: latest LTS
Device running NodeRED: Raspberry Pi

Additional context
This functionality was previously available, but seems to have been removed in a recent update.
I've tried to gather this information another way by utilising the Bridge node, and the JSON {"fetch": "groups"} however the Bridge node doesn't respect the existing payload, and overwrites my included topic, meaning I can't pass through the desired group I'm trying to poll for, to then filter the returned results from the bridge by.

This bothers me, too. In former versions I was able to retrieve the status of a group without the duty to make changes to the group. Please get this fixed soon.
Thanks,
Timo

Due to major adjustments in the previous versions, it is now necessary (and possible from v2.6.4+) to request the current status of lamps, groups and motion sensors via the new "status" property.
Sorry about the circumstances!

Unfortunately this hasn't been fixed. Please reopen the issue.

Did you tried it like this?
[{"id":"3f971186.23081e","type":"tab","label":"Example","disabled":false,"info":""},{"id":"75515524.f36b14","type":"inject","z":"3f971186.23081e","name":"","topic":"","payload":"{\"status\":true}","payloadType":"json","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":150,"y":60,"wires":[["412e92fc.f0734c"]]},{"id":"f5f6885.1d0a8f8","type":"debug","z":"3f971186.23081e","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","x":540,"y":60,"wires":[]},{"id":"412e92fc.f0734c","type":"hue-light","z":"3f971186.23081e","name":"","lightid":"","colornamer":true,"skipevents":false,"x":340,"y":60,"wires":[["f5f6885.1d0a8f8"]]}]

Did you tried it like this?
[{"id":"3f971186.23081e","type":"tab","label":"Example","disabled":false,"info":""},{"id":"75515524.f36b14","type":"inject","z":"3f971186.23081e","name":"","topic":"","payload":"{\"status\":true}","payloadType":"json","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":150,"y":60,"wires":[["412e92fc.f0734c"]]},{"id":"f5f6885.1d0a8f8","type":"debug","z":"3f971186.23081e","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","x":540,"y":60,"wires":[]},{"id":"412e92fc.f0734c","type":"hue-light","z":"3f971186.23081e","name":"","lightid":"","colornamer":true,"skipevents":false,"x":340,"y":60,"wires":[["f5f6885.1d0a8f8"]]}]

Yes, it does not work unfortunatley


fix(swift): rewrite networking layer

🧭 What and Why
🎟 JIRA Ticket: DI-1722
Changes included:

broader use of async/await instead of legacy queueing mechanism
similar transporter/requester pattern to the one used in the other APIC

Huuuuge work !


Missing header guards in a lot of files

Godot version:
master build https://github.com/godotengine/godot/commit/ae28c0fdb8f22dc26339e9f81b555e129f61b010
OS/device including version:
Any
Issue description:
As detected by LGTM, there are currently 55 files without header guards. Many of them seem to be register_types.h. A helpful list by Akein can be found here.
I think we should add missing #include guards in all files that are missing it.
Because missing both #pragma once and #include guard seems to be more concerning matter compared to choosing between them.
Also, if and when we do decide to change it, we can just guardonce tools to convert between them.
Related: #18143 (where I have mentioned this before).
Note: #36324 is also part of this. I created this issue as there wasn't an issue for all concerned files.
Steps to reproduce:
Visit https://lgtm.com/projects/g/godotengine/godot/alerts?mode=list&id=cpp%2Fmissing-header-guard.

Hey @Anutrix, I can take care of this. For the multiple instances of register_types.h files missing include guards, do you suggest prefixing the macro names with the name of the parent directory to maintain uniqueness? For example:
#ifndef WEBSOCKET_REGISTER_TYPES_H
#define WEBSOCKET_REGISTER_TYPES_H

for root/modules/websocket/register_types.h and
#ifndef ANDROID_EXPORT_H
#define ANDROID_EXPORT_H

for root/platform/android/export/export.h

@RajatGoswami That's seems like a good solution yes.

Thanks! I've created a PR here for the requested changes: https://github.com/godotengine/godot/pull/37219

Fixed by #37219.


Synthesis failed for memcache

Hello! Autosynth couldn't regenerate memcache. :broken_heart:
Here's the output from running synth.py:
erimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at e935c9e build(java): run linkage monitor as GitHub action (#933)
2021-02-03 03:09:33,789 autosynth [DEBUG] > Running: git checkout f694606e3e34d0e2a289d655864e225cab9ecb88
Note: checking out 'f694606e3e34d0e2a289d655864e225cab9ecb88'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at f694606e chore(profiler): Set proto namespace to google.cloud
2021-02-03 03:09:33,804 autosynth [DEBUG] > Running: git branch -f autosynth-memcache-43
2021-02-03 03:09:33,808 autosynth [DEBUG] > Running: git checkout autosynth-memcache-43
Switched to branch 'autosynth-memcache-43'
2021-02-03 03:09:33,836 autosynth [INFO] > Running synthtool
2021-02-03 03:09:33,836 autosynth [INFO] > ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']
2021-02-03 03:09:33,836 autosynth [DEBUG] > log_file_path: /tmpfs/src/logs/Memcache/43/sponge_log.log
2021-02-03 03:09:33,839 autosynth [DEBUG] > Running: /tmpfs/src/github/synthtool/env/bin/python3 -m synthtool --metadata synth.metadata synth.py --
2021-02-03 03:09:34,071 synthtool [DEBUG] > Executing /home/kbuilder/.cache/synthtool/google-cloud-php/Memcache/synth.py.
On branch autosynth-memcache-43
nothing to commit, working tree clean
2021-02-03 03:09:34,241 synthtool [DEBUG] > Ensuring dependencies.
DEBUG:synthtool:Ensuring dependencies.
2021-02-03 03:09:34,252 synthtool [DEBUG] > Using precloned repo /home/kbuilder/.cache/synthtool/synthtool
DEBUG:synthtool:Using precloned repo /home/kbuilder/.cache/synthtool/synthtool
2021-02-03 03:09:34,257 synthtool [DEBUG] > Cloning googleapis.
DEBUG:synthtool:Cloning googleapis.
2021-02-03 03:09:34,257 synthtool [DEBUG] > Using precloned repo /home/kbuilder/.cache/synthtool/googleapis
DEBUG:synthtool:Using precloned repo /home/kbuilder/.cache/synthtool/googleapis
2021-02-03 03:09:34,260 synthtool [DEBUG] > Which version of bazel will I run?
DEBUG:synthtool:Which version of bazel will I run?
bazel 3.0.0
2021-02-03 03:09:34,264 synthtool [DEBUG] > Generating code for: //google/cloud/memcache/v1beta2:google-cloud-memcache-v1beta2-php.
DEBUG:synthtool:Generating code for: //google/cloud/memcache/v1beta2:google-cloud-memcache-v1beta2-php.
2021-02-03 03:09:34,413 synthtool [ERROR] > Failed executing bazel --max_idle_secs=240 build //google/cloud/memcache/v1beta2:google-cloud-memcache-v1beta2-php:

Loading:
Loading: 0 packages loaded
INFO: Call stack for the definition of repository 'com_google_api_codegen' which is a http_archive (rule definition at /home/kbuilder/.cache/bazel/_bazel_kbuilder/a732f932c2cbeb7e37e1543f189a2a73/external/bazel_tools/tools/build_defs/repo/http.bzl:296:16):
 - <builtin>
 - /home/kbuilder/.cache/synthtool/googleapis/WORKSPACE:77:1
WARNING: Download from https://github.com/googleapis/gapic-generator/archive/v2.10.4.zip failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found
ERROR: An error occurred during the fetch of repository 'com_google_api_codegen':
   java.io.IOException: Error downloading [https://github.com/googleapis/gapic-generator/archive/v2.10.4.zip] to /home/kbuilder/.cache/bazel/_bazel_kbuilder/a732f932c2cbeb7e37e1543f189a2a73/external/com_google_api_codegen/v2.10.4.zip: GET returned 404 Not Found
ERROR: no such package '@com_google_api_codegen//': java.io.IOException: Error downloading [https://github.com/googleapis/gapic-generator/archive/v2.10.4.zip] to /home/kbuilder/.cache/bazel/_bazel_kbuilder/a732f932c2cbeb7e37e1543f189a2a73/external/com_google_api_codegen/v2.10.4.zip: GET returned 404 Not Found
INFO: Elapsed time: 0.140s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
FAILED: Build did NOT complete successfully (0 packages loaded)

ERROR:synthtool:Failed executing bazel --max_idle_secs=240 build //google/cloud/memcache/v1beta2:google-cloud-memcache-v1beta2-php:

Loading:
Loading: 0 packages loaded
INFO: Call stack for the definition of repository 'com_google_api_codegen' which is a http_archive (rule definition at /home/kbuilder/.cache/bazel/_bazel_kbuilder/a732f932c2cbeb7e37e1543f189a2a73/external/bazel_tools/tools/build_defs/repo/http.bzl:296:16):
 - <builtin>
 - /home/kbuilder/.cache/synthtool/googleapis/WORKSPACE:77:1
WARNING: Download from https://github.com/googleapis/gapic-generator/archive/v2.10.4.zip failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found
ERROR: An error occurred during the fetch of repository 'com_google_api_codegen':
   java.io.IOException: Error downloading [https://github.com/googleapis/gapic-generator/archive/v2.10.4.zip] to /home/kbuilder/.cache/bazel/_bazel_kbuilder/a732f932c2cbeb7e37e1543f189a2a73/external/com_google_api_codegen/v2.10.4.zip: GET returned 404 Not Found
ERROR: no such package '@com_google_api_codegen//': java.io.IOException: Error downloading [https://github.com/googleapis/gapic-generator/archive/v2.10.4.zip] to /home/kbuilder/.cache/bazel/_bazel_kbuilder/a732f932c2cbeb7e37e1543f189a2a73/external/com_google_api_codegen/v2.10.4.zip: GET returned 404 Not Found
INFO: Elapsed time: 0.140s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
FAILED: Build did NOT complete successfully (0 packages loaded)

Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/kbuilder/.cache/synthtool/google-cloud-php/Memcache/synth.py", line 31, in <module>
    bazel_target='//google/cloud/memcache/v1beta2:google-cloud-memcache-v1beta2-php',
  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_bazel.py", line 64, in php_library
    return self._generate_code(service, version, "php", **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/gcp/gapic_bazel.py", line 197, in _generate_code
    shell.run(bazel_run_args)
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['bazel', '--max_idle_secs=240', 'build', '//google/cloud/memcache/v1beta2:google-cloud-memcache-v1beta2-php']' returned non-zero exit status 1.
2021-02-03 03:09:34,471 autosynth [ERROR] > Synthesis failed
2021-02-03 03:09:34,471 autosynth [DEBUG] > Running: git reset --hard HEAD
HEAD is now at f7702e01 chore: update with latest version of protobuf (#3710)
2021-02-03 03:09:34,515 autosynth [DEBUG] > Running: git checkout autosynth-memcache
Switched to branch 'autosynth-memcache'
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 354, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 189, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 334, in _inner_main
    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 65, in synthesize_loop
    has_changes = toolbox.synthesize_version_in_new_branch(synthesizer, youngest)
  File "/tmpfs/src/github/synthtool/autosynth/synth_toolbox.py", line 259, in synthesize_version_in_new_branch
    synthesizer.synthesize(synth_log_path, self.environ)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 120, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:


Set hard requirement on python version for release.

Fails

:no_entry_sign:
The first line of each commit should ends with the issue number

  Generated by :no_entry_sign: dangerJS against 3b3a355ce84c3c1bacc10ced95cc86f80a7d9970

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

3.0.0
GitHub release

Your semantic-release bot :package::rocket:


pbsclient.sh script fails on a azhpc-resize if there are existing compute nodes

When resizing the cluster I see that the pbsclient script fails which causes the resize to report a failure. The issue is that the packages are installed and yum report that there is nothing to do to stderr which is interpreted as an error.

I've just pushed a fix here.  It was an bug where the install steps were being run again on existing nodes when a VMSS was resized to be made bigger


Assertion failed in load_type_section (wasm_loader.c:259)

Environment

Questions
Answers

Related Binary
./iwasm (linux build)

Commit
commit 9a02c49d7c2bb2012fe8d2bd2b9cb2bdaf88ba79

Vulnerability/issue
Assertion failed in load_type_section (wasm_loader.c:259)
Steps to reproduce the behavior

Download:
PoC.zip

Run:
./iwasm PoC.wasm

Additional Informations
Crash
iwasm: XYZ/wasm-micro-runtime/core/iwasm/runtime/vmcore-wasm/wasm_loader.c:259: load_type_section: Assertion `result_count <= 1' failed.
[1]    2373 abort      ./iwasm

Fixed with c47baf221fa8139ee45cd31e7dbf1a8310669d8e


Visual graph editor for breadboard?

Is there visual editor for composing breadboard graph?

ya without that I don't really see the point of breadboard. I am also interested in the question.

The initial release of Breadboard is just the graph execution engine, it doesn't currently ship with a visual scripting solution. Setting up a way to visually edit nodes and connections is one of my highest priorities at the moment because, I agree, without a visual editor the utility of Breadboard isn't that great.

Cool stuff. Looking forward to seeing what you guys come up with! :)


path matching anything but

I want to pattern that matches anything but some fiiles
is it possible?

its currently not supported. There is some a related PR with some discussions currently https://github.com/chronotc/monorepo-diff-buildkite-plugin/pull/88


Plugin architecture at runtime - keep the application running while adding functionality

I'm using the AssemblyLoaderContext in ASP.NET Core 1.1 to load a dll in my plugin folder in my MVC main application with the 'LoadAssemblyFromPath' function. However, I'd like to the attribute routing of my plugin dll's controller to work in my main application. For this I should be able to clear and rebuild the MVC routing. How is this possible to do? It used to be doable in MVC 4-5 using GlobalConfiguration, but as I read on some blogs, it was not a best practice and so the GlobalConfiguration is removed from ASP.NET Core.
So, how can I rebuild the MVC routes, not from the startup class, because I don't want to restart my web application? I'm aiming for an experience like Wordpress and Drupal, where you upload the dll in this case to the server and in the UI, press activate to load this plugin.

We added a feature to support reloading ActionDescriptors in 1.2 (our dev branch) to support RazorPages. You should be use most of the code \ pattern we have in a 1.1 application to make this work:

Write custom IActionDescriptorCollectionProvider that supports reloading. You can pretty much use the code from our dev branch as is:
a. https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Core/Internal/ActionDescriptorCollectionProvider.cs
b. https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Core/Infrastructure/IActionDescriptorChangeProvider.cs

In your startup, services.AddSingleton<IActionDescriptorCollectionProvider, MyReloadableActionDescriptorCollectionProvider>();. Additionally register one or more change providers that trigger a change event when you need to rebuild routes.

I'm aiming for an experience like Wordpress and Drupal

Have you considered using a CMS for this? For instance https://github.com/OrchardCMS/Orchard2?

@pranavkm I forgot to mention that I'm not using Razor. I'm making an API project to which endpoints can be added at runtime using a plugin architecture. For example, to the 'Main Application' that is running on a server, I want to add a project (by compiling it to a dll) that contains a controller like:
namespace MainApplication.Plugin.PluginTest.Controllers{     [Route("api/[controller]")]     public class TestController : Controller{         public IActionResult Get(){               return Ok(new {value = "Ok from Test!"});         }     } }
Then in a 'PluginManager' like class, I would install the dll using the Assembly.LoadAssemblyFromPath("path/to/dll") and here I would need some 'magic' to add this Route attribute to the MVC route, so rebuild the routes.
Is this even possible at runtime or should this be avoided?

Have you considered using a CMS for this? For instance https://github.com/OrchardCMS/Orchard2?

I don't want the bloat of a CMS, just giving those 2 as an example of what result is expected. Because PHP is not being compiled, the application does not have to be restarted. However I'm hoping the same functionality is possible with the new ASP.NET Core.

@pranavkm I forgot to mention that I'm not using Razor.

The changes I pointed to really don't have anything to do with Razor. I just pointed you to RazorPages as demonstration of what the pattern is for the route table to be reconstructed. You can do something similar to what we do in RazorPages in your PluginManager to reload ActionDescriptor instances which would in turn cause the routes to be reconstructed.

@pranavkm During RC, we can publish with controller.cs instead of having dll
On RTM, its all dll
Can we have an option during publish, publish as .cs instead of .dll?

@andrew-vandenbrink dynamic compilation of the application's sources (.cs files) is no longer supported.

@pranavkm thats too bad

cc @danroth27 @sebastienros due to the relationship to modules, but closing this issue as no further action is required here.

@nfdevil Orchard2 is actually more than a CMS. It's actually a well factored application framework. You can leverage the extensions support in Orchard2 without pulling in all the CMS functionality, so it's definitely worth a look. For example on how simple it can be see: https://github.com/OrchardCMS/Orchard2/blob/master/src/Orchard.Mvc.Web/Startup.cs


GH-35692: [C++][Parquet] Parquet: fixing FixedSizeListReader::AssembleArray when has null FixedSizeList

Rationale for this change

Parquet will regard FixedSizeList as regular list, and write rep-levels and def-levels if possible
When read from Parquet, if no null (or nested null, like FixedSizeList doesn't has null but it parent has) is contained, the file can be read correctly
However, when read from Parquet with nullable, the AssembleArray will not work well. It takes continuous "child array" and child offsets, and need to reserve extra padding space for "null". Previous reader doesn't implement it.

To be more clear:
for FixedSizeList(2): [[0, 0], null]

data to be Assemble Array:
null: [0 1]
data: [0 0]
offsets: [0, 2, 2]

required output:
null: [0 1]
data: [0, 0, undefined, undefined]

previous reader doesn't implement that required output
What changes are included in this PR?

Rebuild the FixedSizeList when having null member
Are these changes tested?

Yes
Are there any user-facing changes?
No

Closes: #35692

Reading https://arrow.apache.org/docs/format/Columnar.html#fixed-size-list-layout more closely, I'm not so sure that the zero-sized elements are correct:

A fixed size list type is specified like FixedSizeList[N], where T is any type (primitive or nested) and N is a 32-bit signed integer representing the length of the lists.
A fixed size list array is represented by a values array, which is a child array of type T. T may also be a nested type. The value in slot j of a fixed size list array is stored in an N-long slice of the values array, starting at an offset of j * N.

j * N makes it sound like offsets are always fixed size for fixed size lists. In fact, that document makes it sound like there shouldn't be an offsets buffer at all, since fixed-size lists use "slots".
Could this actually be a writer bug?

@spenczar Hi, I think it's just a reader bug. The written data is not corrupt.

Parquet will regard FixedSizeList as regular list, and write rep-levels and def-levels if possible
When read from Parquet, if no null (or nested null, like FixedSizeList doesn't has null but it parent has) is contained, the file can be read correctly
However, when read from Parquet with nullable, the AssembleArray will not work well. It takes continuous "child array" and child offsets, and need to reserve extra padding space for "null". Previous reader doesn't implement it.

I've submit a fixing, but I'm not familiar with FixedSizeListArrayBuilder and Array, so I may made some mistakes. Can @pitrou helps me review this patch?

@spenczar Would you mind have a try on this patch? The code might not be the final commit code, but I want to make sure that problem got fixed :-)

I've found another unrelated issue when writing unittests: https://github.com/apache/arrow/issues/35697

@emkornfield Can you take a look here? I'm not sure I understand the issue.

@mapleFU its not clear to me that this approach works for all level of nestings.  When I was thinking about the problem, I thought it would be better to populate and make use of null_slot_usage on reading each array back.

I've tested the nested case. But I can take a look at null_slot_usage, thanks a lot!

I got what you mean, I didn't know null_slot_usage previously, thanks a lot!

  if (valid_bits_writer.has_value()) {
    valid_bits_writer->Finish();
  }
  if (offsets != nullptr) {
    output->values_read = offsets - orig_pos;
  } else if (valid_bits_writer.has_value()) {
    output->values_read = valid_bits_writer->position();
  }
  if (output->null_count > 0 && level_info.null_slot_usage > 1) {
    throw ParquetException(
        "Null values with null_slot_usage > 1 not supported."
        "(i.e. FixedSizeLists with null values are not supported)");
  }

Seems that I should support the handling logic here?

I'll close this and submit another patch using null_slot_usage

If this code works (and we don't think null_slot_usage can be more efficient) it is ok to pursue this approach, so feel free to reopen

Emmm I'm sure it works, null_slot_usage will be more efficient because it doesn't copy more data, but my solution may "copy" the underlying leaf data. But I think my solution is right. Should you keep this as a quick fixing? I'm a bit busy this week, and may only have time for null_slot_usage fixing this weekend. @pitrou @emkornfield

https://github.com/apache/arrow/pull/35694#issuecomment-1596728191
@emkornfield @pitrou would you mind help for this? When we have:

FixedSizeList<FixedSizeList<int, 2>, 2>
2.FixedSizeList<List<FixedSizeList<int, 2>, 2>>

What should  null_slot_usage be? Should it be? Should them be:

(2) for FixedSizeList<int, 2>, and (4) for FixedSizeList<FixedSizeList<int, 2>, 2>?
(2) for FixedSizeList<int, 2>, and (4) for FixedSizeList<FixedSizeList<int, 2>, 2>, what would be for FixedSizeList<List<FixedSizeList<int, 2>, 2>>?

Is there any way I can help get some motion here? This remains a pretty nasty blocker for some applications of Arrow and Parquet for us.

I believe this patch will solve part of the problem. However, it might has some performance lost, since it need to copy the underlying data. Feel free to use this as a patch
Using null_slot might be better here. But I need some help to tell me how to implement it.


Curated content "Integrated Development Environments (IDEs) for Scientific Sofware Development"

Maybe this should be an article? I'm not sure.

It could be either or both.

Let's keep as curated content for now.


Clean up session scheduler

It’s a hack I wrote in the nights before Minnebar, all bare data structures and spaghetti code. This is a todo to myself to clean it up and regression test it.

Moved regression testing to separate issue #68.


Memory viewer

Type: Feature Request
I have not tried the extension yet, but one missing feature I do not see in the presentation is the Memory Viewer (and I don't know extension of VSCode proposing this).
This would be a great feature to permit viewing/editing the memory. IDEs from almost all MCU vendors proposes this feature since a long time.

Hello @benmcmorran
Thanks. Is it possible to read lock of memory?
I mean RAM area, this is so much useful when debugging!
Joel

It's possible to read blocks of memory in some cases. If the block you want to read starts at a register or RTOS address, you can simply click the link to start reading the block. For example, this a ThreadX thread control block followed by the thread's stack, which consists mostly of 0xEF fill bytes.

However, VS Code currently doesn't provide a way to read at arbitrary addresses. It's possible to set a watch at an arbitrary address, but there's no option to view the binary data for the address (unlike variables displayed in the Variables view).

Also notice that the memory view can be difficult to read because the display always starts at address zero, regardless of the real base address. We plan to address these issues in the future.

In addition to viewing memory, please also support editing memory. This is useful for debugging @benmcmorran

+1 for editing memory, this is a functionality available in other IDE since a long time and it is very very useful!

Noted. We plan to include support for editing in any memory experience we build.

Memview:
https://github.com/Marus/cortex-debug/issues/729
https://github.com/haneefdm/memview

Our new repo is https://github.com/mcu-debug/memview

We are leaving this request open as we expect to do something here eventually. For now we recommend people use the extension from the repo @haneefdm referenced above.


After manager Login/Logoff/Login, action qstatus i'm getting same events doubled

Hi,
asternet 1.3.0 (from branch) asterisk 16.30.1 and vb .net (vs2022)
I'm getting a weird behaviour when i'm:

Login to asterisk
Logoff from asterisk
Login to asterisk
and then send any action (e.g. qstatus or sip peers list) all the results are doubled or tripled (depends from how many times i had logon/logoff)

I'm using this to login
Public dmanager As New AsterNET.Manager.ManagerConnection(dSVHelperClass.ServerIP, dSVHelperClass.Port, dSVHelperClass.Username, dSVHelperClass.Password)

Private Sub Button1_Click(sender As Object, e As EventArgs) Handles Button1.Click
    Try
        dSVHelperClass.DefaultResponseTimeout = "30000"
        dSVHelperClass.DefaultEventTimeout = "30000"

        dmanager.Login()
        ' dmanager.UseASyncEvents = True

        ToolStripStatusLabel1.Text = "Asterisk Version: " + dmanager.Version
        StatusStrip1.Refresh()
        dSVHelperClass.clearGrid()
        Button1.Enabled = True

    Catch m As Exception
    End Try

    AddHandler dmanager.QueueParams, AddressOf qParams
    AddHandler dmanager.QueueMember, AddressOf qMember
    AddHandler dmanager.QueueEntry, AddressOf qEntry
    AddHandler dmanager.QueueStatusComplete, AddressOf qStatusComplete
    AddHandler dmanager.ExtensionStatus, AddressOf extStatus
    AddHandler dmanager.PeerEntry, AddressOf pEntry
    AddHandler dmanager.PeerlistComplete, AddressOf pListComplete
    AddHandler dmanager.Status, AddressOf dmStatus
    AddHandler dmanager.StatusComplete, AddressOf dmStatusComplete
    AddHandler dmanager.Agents, AddressOf agEvent
    AddHandler dmanager.AgentsComplete, AddressOf agEventComplete
    AddHandler dmanager.QueueCallerJoin, AddressOf qCallerJoin
    AddHandler dmanager.AgentConnect, AddressOf agConnect
    AddHandler dmanager.AgentComplete, AddressOf agComplete
    AddHandler dmanager.QueueCallerAbandon, AddressOf qCallerAbandon
    AddHandler dmanager.QueueCallerLeave, AddressOf qCallerLeave

End Sub

and this to logoff from manager
 Private Sub Button14_Click(sender As Object, e As EventArgs) Handles Button14.Click
     dmanager.Logoff()
 End Sub

Any help please!

It is a known issur that the AsterNET.Manager.ManagerConnection object breaks after logout. It should probably get fixed someday.
Just null the object and instantiate a new one during login.

thanks you saved my life...!!