[LLVM][GPU] Added CUDADriver to execute benchmark on GPU

Added CUDADriver to compile LLVM IR string generated from CodegenLLVMVisitor to PTX string and then exexcute it using CUDA API
Updated CMake required version to 3.18 to assist finding the NVVM root directory to include the needed files and libraries
Tested the CUDADriver with external example LLVM IR code and works fine
CUDA used to build NMODL should be the same version as the CUDA driver version installed on the machine the benchmark is executed otherwise there is CUDA_ERROR_INVALID_PTX error
Added linkage to libdevice library
To execute the benchmark with the libdevice we need to run the following:

./bin/nmodl ../test.mod --output "llvm_cuda" --verbose debug llvm --no-debug --ir --opt-level-ir 3 gpu --target-arch "sm_80" --name "nvptx64" --math-library libdevice benchmark --run --libs "${CUDA_ROOT}/nvvm/libdevice/libdevice.10.bc" --opt-level-codegen 3 --instance-size 10000000 --repeat 2 --grid-dim-x 4096 --block-dim-x 256

WIP:

[x] At the moment the generated LLVM IR from NMODL doesn't generate right PTX code due to the address spaces not being set properly Edit: Generated LLVM IR has instructions that convert pointers in generic address space to global pointers so generated LLVM IR code is now executable to GPU using this PR
[x] Kernel name in nvvm anotation should change to have the real name instead of "kernel"
[x] Handle compilation options
[x] Transform LLVM IR to bitcode to pass to nvvmAddModuleToProgram. Passing string is deprecated
[x] Find a way to set Triplet and DataLayout for GPUDriver in non-hardcoded way (?)
[x] Check why code cannot be compiled on GPU with kernel attributes
This is the output of NVVM when it tries to compile the kernel with the default attributes:

terminate called after throwing an instance of 'std::runtime_error'
  what():  Compilation Log:
 nmodl_kernel: parse Unknown attribute kind (62) (Producer: 'LLVM13.0.0' Reader: 'LLVM 7.0.1')

I am using CUDA 11.4.2.

[ ] Check why code cannot be compiled on GPU with debug flags. This is the output with debug flags:

[NMODL] [info] :: CUDA JIT ERROR LOG: ptxas application ptx input, line 264; fatal   : Parsing error near '-': syntax error
ptxas fatal   : Ptx assembly aborted due to errors

The related PTX code:
...
   .section	.debug_pubnames
   {
.b32 LpubNames_end0-LpubNames_start0
LpubNames_start0:
.b8 2
...
LpubNames_end0:
   }
   .section	.debug_pubtypes
   {
.b32 LpubTypes_end0-LpubTypes_start0
LpubTypes_start0:
.b8 2
.b8 0
.b32 .debug_info
.b32 182
.b32 0
LpubTypes_end0:
   }
   .section	.debug_loc	{	}

You can reproduce the issue if you remoce the --no-debug option in the command above

[x] Added GitLab CI test that executes benchmark in Cascade Lake CPU and V100 GPU node

@iomaganaris Regarding some points from your TODO list:

Transform LLVM IR to bitcode to pass to nvvmAddModuleToProgram. Passing string is deprecated
You can use WriteBitcodeToFile function that takes a llv,::Module and the file path.

Find a way to set Triplet and DataLayout for GPUDriver in non-hardcoded way (?)
Usually you can create target machine (llvm::TargetMachine) and get all this information automatically, like it is currently implemented for CPUs (see set_triple_and_data_layout in jit_driver.cpp). For GPUs it is not really possible, as we need to provide some device information. However, what we can do something like:
https://github.com/llvm/llvm-project/blob/main/polly/lib/CodeGen/PPCGCodeGeneration.cpp#L2301

@iomaganaris Regarding the errors: I think both of them are related to bitcode versions that we use.
terminate called after throwing an instance of 'std::runtime_error'
what():  Compilation Log:
nmodl_kernel: parse Unknown attribute kind (62) (Producer: 'LLVM13.0.0' Reader: 'LLVM 7.0.1')

Here, I suppose that we read bitcode with older LLVM version (7)? Looking at attributes' kinds 62 is nofree function attribute (added by optimization passes) which based on this RFC was added after 2018, hence it shouldn't exist in LLVM version < 7?
[NMODL] [info] :: Device Compute Capability: 8.6
terminate called after throwing an instance of 'std::runtime_error'
what():  Compilation Log:
nmodl_kernel: parse Invalid record

This one I am not sure, but the error is definitely related to parsing wrong (different version/older) bitcode.
I don't have access to CUDA so cannot check the errors myself :( Were you able to track which method in CUDADriver/GPUBenchmark throws it?

@georgemitenkov
Regarding the first error I think that the problem is that NVVM is based on LLVM 7.0.1 according to NVIDIA's documentation so it's not possible to parse these attributes https://docs.nvidia.com/cuda/nvvm-ir-spec/index.html.
The error regarding the debug attributes come from the same line where we compile the LLVM IR to PTX. I'm guessing that there is some similar issue there with the generated LLVM IR with debug attributes not being able to be parsed by LLVM 7.0.1 based NVVM.

With the latest changes in this PR and George's changes in https://github.com/BlueBrain/nmodl/pull/835 I managed to execute via the benchmark the test mod file with exp that has been added as a unit test in the mentioned PR.
The only thing still missing is support for debug flags. I need to investigate this a bit to see what LLVM does

Seems like addition of debug symbols for the GPU is not straightforward. I found this mail in the llvm mailing list that summarizes the reasons why debug information in the GPU code are not working out of the box.
By changing by hand the following line in the generated PTX code:
.b32 LpubTypes_end0-LpubTypes_start0

to calculate explicitly the sector sizes I managed to get the PTX compiled to a cubin however I didn't try to load it and execute it to see if the rest of the debug info are correct.
I've also tested running the CUDA JIT with nsys --profile and ncu and they both provide information for the kernels executed.
Instead of adding more stuff in this PR about the debug information on GPU code and making it even bigger I am wondering whether we should review and merge it and handle the addition of debug info in another PR.
cc: @georgemitenkov @pramodk

@iomaganaris I think reviewing & merging and dealing with debug information in separate PR sounds reasonable. Maybe we can then have a warning that debug information is not supported by nvptx backend?

I added a warning about this and automatically disabling the addition of debug symbols when there is a GPU platform selected. I have also created #844 to track this issue


Previewing markdown notifications does not honour custom theme

Laravel Version: 8.13.0
PHP Version: 7.4.0
Database Driver & Version: n/a

Description:
When trying to preview a markdown notification in browser (as per the docs), it appears that the inline custom theme as set using the theme()method is not being honoured - the default theme is used instead.
Steps To Reproduce:
New installation of Laravel 8.
Create a markdown notification using Artisan:
php artisan make:notification Testing --markdown testing

Publish mailable views and assets:
php artisan vendor:publish --tag=laravel-mail

Create custom theme in /resources/views/vendor/mail/html/themes (named testing.css).
Make a trivial but obvious changes to the theme - for example make all color references on .button-primary a bright pink: #ff00ff.
Update App\Notifications\Testing to use this custom theme:
public function toMail($notifiable)
{
    return (new MailMessage)->theme('testing')->markdown('testing');
}

Update routes/web.php to run example:
Route::get('/', function () {
    // Send the notification.
    // $send = Notification::route('mail', 'nathan@nathanpurcell.com')->notify(new \App\Notifications\Testing);

    // Preview the notification.
    $user = new \App\Models\User;
    $user->email =<EMAIL_ADDRESS>
    return (new App\Notifications\Testing)->toMail($user);
});

What's interesting is that if you uncomment the first line where the notification is sent and run the code, the subsequent render works as expected.
Otherwise the notification renders, but using the default theme.

Fixed in next patch release.

Great stuff, thank you!
On Thu, 5 Nov 2020 at 16:54, Taylor Otwell<EMAIL_ADDRESS>wrote:

Fixed in next patch release.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/laravel/framework/issues/35081#issuecomment-722503032,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7KMCYA4PILQ3Q3PDZB2J3SOLKGFANCNFSM4TJDT4VQ
.


Allow explicit Windows SDK version

Is your feature request related to a problem? Please describe.
For the sake of stability and reproducibility, my team prefers to build against an explicit version of the Windows SDK, e.g. 10.0.18362.0.
However, when loading its Visual Studio shell environment, vcpkg currently does not specify any particular version of the SDK. vcvarsall.bat will thus choose the latest available version. This limits our ability to control which version of the SDK is used when building vcpkg dependencies.
Proposed solution
Add a mechanism by which users may specify an explicit version of the Windows SDK to use. When calling vcvarsall.bat, vcpkg will pass the specified value using the -winsdk=<ver> argument.
I propose exposing this mechanism to the user by way of a new triplet variable, tentatively named VCPKG_PLATFORM_SDK_VERSION.
Describe alternatives you've considered
It is technically possible to build with a specific Windows SDK version by simply uninstalling any newer versions of the SDK before running vcpkg. This is obviously cumbersome, particularly for users who may jump between projects with different SDK requirements.
My team is currently applying a patch to vcpkg-tool and bootstrapping manually. This patch is a very trivial hack which reads from an env var and injects the desired -winsdk=<ver> argument within visualstudio.cpp. Definitely not something that would be accepted upstream.
Additional context
I'm more than happy to submit a PR for this proposal. Just wanted to open this issue first to hash out the details and get feedback.
Unless there are objections, I plan on largely copying from microsoft/vcpkg-tool#199 which introduced VCPKG_PLATFORM_TOOLSET_VERSION.

I think you can do this by setting the WindowsSDKVersion environment variable and passing it through by setting VCPKG_ENV_PASSTHROUGH to WindowsSDKVersion in your triplet.

@BillyONeal @vicroms @ras0219-msft Could you please help take a look this issue?

@Cheney-W I don't expect such a feature is going to make the cut line soon.


Finish Nimibook docs

This can only happen once there is a way that allows me to specify the pathway where the nimja templates are, otherwise the books won't be able to compile the examples.

Well, wrapped up doc comments for now and set up a CI for that, nimibook docs are still a big questionmark.

Nimibook docs are done! To believe I would live to see the day!


Direct including of template files

Initial PR
Issue #74

@jrfnl I have changed the Sniff to be a bit more general and check that the template functions are used instead of directly including the files. I have added a check for get_head(), get_footer() and get_sidebar(). The check is not sophisticated enough to check for variations of header.phpand sidebar.php but I think this check should be enough.
With the new changes to the sniff the extra tests that you mentioned are being passed.
I wonder if we should merge this sniff with WordPress_Sniffs_Theme_FileIncludeSniff
@justintadlock Could you just check that the sniff is complete?

Don't you mean get_header() and get_footer() instead of wp_head() and wp_footer() in this code?
protected $template_files = array(
	'searchform.php' => array(
		'alt' => 'get_search_form()',
	),
	'header.php' => array(
		'alt' => 'wp_head()',
	),
	'footer.php' => array(
		'alt' => 'wp_footer()',
	),
	'sidebar.php' => array(
		'alt' => 'get_sidebar()',
	),
);

Yes you are right, sorry, I will correct that.

I wonder if we should merge this sniff with WordPress_Sniffs_Theme_FileIncludeSniff

I'm in two minds about that. On the one hand, both sniffs look for the inclusion of files.
On the other hand, they have different error levels, different search patterns and different implications.
This sniff is searching for very specific filenames, will also catch them when used in combination with a variable name like $file = 'searchform.php'; include $file; and will suggest an directly implementable alternative.
The include/require sniff is a basic sweep of all such calls and needs manual inspection to determine whether the usage is valid, aka warning.
I'm leaning towards leaving them as separate sniffs as the intend of the sniffs is different.

I have changed the Sniff to be a bit more general and check that the template functions are used instead of directly including the files. I have added a check for get_head(), get_footer() and get_sidebar().

:+1:

The check is not sophisticated enough to check for variations of header.php and sidebar.php but I think this check should be enough.

That wouldn't be too hard to implement actually. Foreach loop combined with a regex pattern could solve that quite easily.
If you need a hand with the regex, let me know or add some examples of variations you'd be looking for to the test case file.

I have added the additional tests, could use help with the regex.

I have run the sniff on the some of the theme of the repo and got some false positives

from https://themes.trac.wordpress.org/browser/catalog-me/1.0.10/product-adder.php

$page_template           = get_page_template_slug( $page_id );
$id                                      = 'container_sidebar_wrap';
if ( $page_template == 'sidebar-page.php' ) {
        $id = 'no_sidebar_wrap';
}

I was surprised that this was caught. After looking at the code it is shows another issue. sidebar-page.php is a page template but could clash if get_sidebar( 'page' ) was used.

from https://github.com/justintadlock/hybrid-core/blob/4.0/inc/template.php#L102_L214

	if ( $name ) {
		$templates[] = "header-{$name}.php";
		$templates[] = "header/{$name}.php";
	}
	$templates[] = 'header.php';
	$templates[] = 'header/header.php';
	locate_template( $templates, true, false );

from https://themes.trac.wordpress.org/browser/attitude/3.0.8/functions.php

        require_once( ATTITUDE_STRUCTURE_DIR . '/header-extensions.php' );
        require_once( ATTITUDE_STRUCTURE_DIR . '/sidebar-extensions.php' );
        require_once( ATTITUDE_STRUCTURE_DIR . '/footer-extensions.php' );

from https://themes.trac.wordpress.org/browser/altitude-lite/1.1/cyberchimps/init.php

        require_once( $hooks_path . 'header-hooks.php' );
        require_once( $hooks_path . 'footer-hooks.php'

I think we can prevent these if we only check the files in the root of the theme and exclude any folder and exclude functions.php

I have run the sniff on the some of the theme of the repo and got some false positives

I don't think limiting the sniff to certain files is the way to go per se.
Let's take a step back and try to get a crystal clear definition of what this sniff should do and catch.
Let's write unit tests to match.
And only once that's done, let's look at the actual sniff again.

Closing this PR in favour of continuing the discussion in the original issue #74.
Once that discussion has run its course, we can always reopen.


Support WebAssembly

This PR port this project to WebAssembly by following changes:

Use SwiftPM's Clang module integration instead of XCFramework on non-darwin platforms
Make Combine, SwiftUI, os.log, and libdispatch optional dependencies since they are not available on WebAssembly and non-darwin platforms.

Demo
See https://github.com/kateinoigakukun/automerge-swift-wasm
Users need to build libuniffi_automerge.a by themselves by cargo build --manifest-path rust/Cargo.toml --target wasm32-wasi --release and link it by adding linker option.

This is very exciting! If I understand correctly the libuniffi_automerge.a is an archive containing WASM objects, which means it should be platform independent. Can we make things easier for people by compiling it and hosting it as part of a Github release so that users can just grab it from the release URL?

@alexjg Exactly yes! Users will be able to skip cargo build if we will host pre-compiled static archives.
Unfortunately, it's not as easy as XCFramework binaryTarget, but much better than nothing 👍

@kateinoigakukun Thank you - finally had a chance to really sit down with the PR this morning. I've updated it slightly to preserve the generated automergeFFI.h from UniFFI rather than using a completely static one - no idea if/when it will update, but I know I'd otherwise miss it and be deviled in debugging that missing link if I didn't.
I want to specifically add some CI work to compile this in WASM during builds to make sure we maintain the canImport() and related bits correctly for a WASM distribution down the road - do you have any suggestions (or examples to easily borrow from and replicate) to set something like that up with GithubActions? I'm guessing a Linux container build step might be easiest, but I just wasn't sure what the current "state of the art" was in setting up a CI with a swift-wasm compilation toolchain on it.

@heckj Thanks! I added wasm workflow here.

🎉


PersistentCollection doesn't have the matching method

Both https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/PersistentCollection.php#L861 and https://github.com/doctrine/collections/blob/master/lib/Doctrine/Common/Collections/ArrayCollection.php#L358 (which is the type one needs to use on a ReferenceMany field) have a "matching" method for searching (via a Criteria) a set of items in the collections.
However - https://github.com/doctrine/mongodb-odm/blob/master/lib/Doctrine/ODM/MongoDB/PersistentCollection.php (which is what returned on a ReferenceMany field) doesn't have that method.
How can I search in the ReferenceMany field ?

Hi guys, any update on this issue?

None besides what's written above. It's in the 1.x milestone, meaning we are willing to add it to one of the next 1.x releases, but nothing more than that. You could always help get things started by creating a pull request!

I thought the custom collections feature made this less important?
On 7 Dec 2016 5:23 pm, "Andreas"<EMAIL_ADDRESS>wrote:

None besides what's written above. It's in the 1.x milestone, meaning we
are willing to add it to one of the next 1.x releases, but nothing more
than that. You could always help get things started by creating a pull
request!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/doctrine/mongodb-odm/issues/929#issuecomment-265366258,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAu3mPs1jYpa0mXYL-04fi0AZZzgHvd_ks5rFlDRgaJpZM4Cahuy
.

+1 for having this feature
I checked the ArrayCollection::matching() implementation, it can be implemented in a similar way in PersistentCollection I believe. Ideally using PersistentCollection's methods instead of array_*. But then few more methods needs to be implemented, i.e. PersistentCollection::reverse.
What do you think?
@alcaeus

@svscorp I haven't taken a look in a while. Since you have an idea about how to implement it, could you create a pull request?

I took a bit of a look at this yesterday night (about how it was implemented in ORM too).
I'm a bit lost as I never really looked into the code before, but here what I saw for now, let me know if I'm completely wrong.
In ORM's matching method (in PersistentCollection) it call a persister->loadCriteria(Criteria) to query the referenced Entities.
The thing is, in ORM, there is a specific persisters for Relations (I remember a persister for Many relationship at least) to implement the loadCriteria differently while in ODM we only have a DocumentPersister.
I didn't take a proper look at how the persister is choosen yet.
I guess the best to do would the same and query the referenced Document (for ReferenceOne and ReferenceMany at least, as Embed Documents will be available without querying them when the "main Document" is fetched from DB), rather than query them all and then filter them like in an array ?
About the multiple persisters in ORM, Is there a need to add multiple persisters in ODM to differentiate the relations ?
If yes, how to determine which persister to instantiate ?
Do we have to change the mapping array (in persistentCollection) into a Class like in ORM ? (In ORM the mapping equivalent is called association)
Do we have to add new Collection class (like the LazyCriteriaCollection and others in ORM that doesn't seem to have equivalent in ODM) ?
I still need to look a LOT of things; how (and where) the query to referenced Documents is made, to be able to add the Criteria to it ans surely other things.
ps : Not related but there is a lot of methods with missing docBlock (return statement, param etc.), is that intentional ?
ps2 : I wrote that quickly during a break, I maybe forgot some things or it may be a bit confusing.

The implementation differs a lot from ORM. For one, we have a lot more flavours of associations than ORM. For example, for any owning-side collection, matching wouldn't really be a performance boost (be it references or embedded relationships): since the collection only keeps a list of documents (either raw embedded document data or references) that should be in it, we can't apply a custom query to the collection. So those will always have to be walked like any other generic ArrayCollection.
However, if we're dealing with a inverse reference-many that isn't loaded by a repositoryMethod (which also doesn't exist in ORM), we can return a new PersistentCollection instance that modifies the criteria property from the mapping, adding whatever criteria was received in the call to matching().
I've previously hacked this together but haven't found the time to polish it for inclusion in 2.0 - I can gladly hack it back in and push a WIP branch for others to pick up on.
As for your question regarding a new Collection class, in our case we duplicated it, but that was because we couldn't change the original implementation. For ODM, we'd have to change PersistentCollectionInterface to also extend Selectable, which is a BC break and won't happen in 2.0. Alternatively, this can be moved to PersistentCollection entirely. This is one of the reasons why I've shied away from implementing this in 2.0: it adds a lot of complexity that we're trying to avoid this late in 2.0 development (I'd like to get it done rather soon). I believe it's best to sit on this until 2.1 and 2.2 and then add this in a backward compatible fashion.

Hey.
I was in break for the past 2 weeks, and I couldn't really continue working on this.
If it's for 2.1 (or more) I guess it's not really urgent, then.
I think I'll take a better look of the sources, to know how it works, for now.
Once I know better about the sources, how it works etc, I could really help.

2.x is not very different except for coding standards and the low-level logic. Collections are very similar. As this feature won’t make it into 2.0 either way, there’s no need to hurry.


🌵 Support Responsive For iPhone SE [main]

🎫 Tickets

#79

👨🏼💻 What did you do?

I supported responsive for iPhone SE
I fixed the layout so SE users can enter the SignIn Page

👀 Images

🌋 TODOs

[x] nothing


Associate address records

When a Multicast DNS responder places an IPv4 or IPv6 address record
(rrtype "A" or "AAAA") into a response message, it SHOULD also place
any records of the other address type with the same name into the
additional section, if there is space in the message.

Need to change resolving/nameserver.cs in net-dns.

Fixed in Makaretu.Dns 0.13.2


Remove unused var

var templateFilesToInject is useless.

@sylvainlap looks like templateFilesToInject is being used here, so we shouldn't get rid of it.

I don't agree.
Here: https://github.com/balderdashy/sails-generate-frontend/blob/master/templates/tasks/config/jst.js#L39
You use templateFilesToInject from this file: sails-generate-frontend/templates/tasks/pipeline.js
So, templateFilesToInject from sails-generate-frontend/templates/tasks/jst.js is useless.
Regards,
Sylvain

@sylvainlap sorry, I missed that -- you were totally right.

You're welcome ;)


Submit Workflow: Bluetooth Device Battery

Preflight

[X] The Alfred team has invited me to submit this workflow.

The submitted workflow:

[X] Was authored by me. ⓘ
[X] Uses Workflow Configuration or has no user-facing settings. ⓘ
[X] Does not have an auto-updater. ⓘ
[X] Does not contain unsigned and non-notarised binaries. ⓘ
[X] Does not download extra software. ⓘ
[X] Uses keywords with more than one character. ⓘ
[X] Has a descriptive About section. ⓘ
[X] Has an icon of at least 256x256 px. ⓘ

Homepage
https://github.com/zeitlings/alfred-workflows#111-bluetooth-device-battery
Alfred Forum page
https://www.alfredforum.com/topic/20325-bluetooth-device-battery/
Gallery page content
Setup
Download Apple's SF Pro font to see the icons.
Usage
See the battery status of your connected Bluetooth devices via the keyword btb.

Tags
bluetooth, airpods, hardware
Test data
No response
Homebrew dependencies
No response
Bundled libraries
No response

Thank you. Looking good except for a small detail: the instructions and screenshot say to use btd (all good) but the workflow itself has db set as the default keyword.

Thanks for pointing out that oversight. It's fixed now: v1.1.2-btb

Live at https://alfred.app/workflows/zeitlings/bluetooth-device-battery/.


Plugin MultiUserClient Fails To Load When Launching A Project With The RenderStream Plugin

A plugin that MultiUserClient requires does not get enabled by default so this change forces that plugin (ConcertSyncClient) to be enabled in the plugin template so everything can load properly.

we don't depend on multi user client, right? this should only be enabled when the multi user client plugin is enabled... is there nowhere we can do that? I'd prefer not to bloat our dependencies for something optional.

It's a little bit strange that we have to manually load a plugin that the multi user plugin depend on and not manually load the multi user plugin directly, but I guess the multi user plugin isn't enabling its dependencies correctly.
LGTM

I have been told they are planning to fix this in 5.5

QA passed.


Add timeout to initial admin API connection attempt

As demonstrated by one of the user, sometimes the Kong container comes online just fine, even though the controller cannot reach it.
This is a weird edge case, but we should add this timeout regardless for independent controller Pods, who otherwise don't have a great readiness check.

Closing per #799


3.1 release checklist

[x] Parse UniProt 2015_12 (9 december)
[x] Load data on adler
[x] Calculate the proteome_caches
[x] Update UniProt version in the Unipept settings file
[x] Copy data dumps
[x] Load data dumps
[x] Index data dumps
[x] Add planned downtime message to the production website
[x] Update readme.md
[x] Put adler in production mode and test the production deployment
[x] Test in all browsers
[x] Create new release, update version numbers and push master
[x] Add Github release
[x] apt-get update and upgrade
[x] Switch databases
[x] Deploy production branch to website
[x] Deploy API branch to API server
[x] Add 3.1 + changelog news post
[x] Add tag to google analytics
[x] Create public branch and push to github.com
[x] Tweet
[x] Delete 3.1 feature branches
[x] Put adler back in dev mode

Original issue by @bmesuere on Sat Dec 05 2015 at 14:36.
Closed by @bmesuere on Fri Dec 11 2015 at 18:22.

Checked sample 7 on the 2015_12 release: looks good. As of this release, we don't match S. aureus anymore for sample 7. The only specific peptide that was left in the 2015_11 release is now found in twice the number of proteins including entries from other Staphylococcus species.
Original comment by @bmesuere on Fri Dec 11 2015 at 09:53.

The number of proteomes wen from 10564 to 13248. These are the number for a few key species:

species
# in UniProt 2015_11
# in UniProt 2015_12

A. Baumannii
31
33

E. Coli
151
349

S. Aureus
20
242

B. Cereus
107
108

L. Lactis
18
18

Original comment by @bmesuere on Fri Dec 11 2015 at 11:56.


Backup vault is n't supported by cloud nuke

Backup vault is n't supported by cloud nuke, need to enhance the tool

@abhishekmahajan0709222 thanks for the feedback.  We recently added the KMS resource, but haven't gotten around to adding backup vault.  I'll let you know when we get something scheduled. Until then PRs are welcome!


Improve Language Selection of Maschine Translation

Motivation

In future more automatic translation providers will be connected to our CMS system. It's time to improve and/or re-design "Language Selection" box in the machine translation settings, to make it clear for users which language is to be translated by which provider etc.
Proposed Solution

TBD with UI/UX team
Leave comments here if you have any opinion, idea, question or concern 😉
Alternatives

N/A
User Story

N/A
Additional Context

Introduction of new automatic translation providers #1436
The affected zone:

Design Requirements

Following points are subject to discussion and attention:

Whether the current listing style of languages pro provider is good enough, possibly how to improve it
How to handle languages that are supported by more than one provider (Should each language have only one provider assigned or make it possible to translate by multiple providers to, for example, compare the quality and chose the best one?) (How to display the check box etc in the box)

In my opinion only one provider should be assined for each language and users choose one (and change to another if they want) for each language in the setting. This lets users save translation credits, is easier to use (it will be too much work at some point to compare result translations of multiple providers or to choose one provider every time when machine translation is needed), and avoids much of possible errors and bad user experience.

My idea would be to have a list of all languages that are supported by at least one provider. Next to the language I would probably add a dropdown button where region managers can select the MT providers that should be used for each language. For the default values I think we can use some sort of provider hierarchy.
@hauf-toni What do you think about this and do you have some additional insight?

Yeah, I am with @JoeyStk. Dropdown to choose from the provdiers.

It probably makes sense to implement this either before or alternatively in parallel with #1436.

Just to add onto what's been said - I think if users want to compare quality they can do that outside the CMS by simply copying and pasting the text to both DeepL and Google and let native speakers check the translations. That way they do not need to use credits at all.

from ui/ux side it is a go for @JoeyStk 's idea (dropdown menu). would you like a design for this?

I think a design would be useful, if it is not a lot of work @hauf-toni

As discussed with @dkehne  @JoeyStk @osmers, we will proceed with johannes' suggestion & revise the design if necessary to optimize space after the gt connection has been completed 🪛


Large Types IRGen Pass: add support for transforming return of large types into indirect returns

radar rdar://problem/28680453
This PR improves the new IRGen pass by adding support for result types.
Result types that are Large loadable types are replaced by empty tuples.
At the call site, we add a new stack allocation and pass said allocated space as a new inout argument to the apply site. After the call is executed this new argument will contain a pointer to the previously returned result.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

Why a new inout argument instead of just changing the result to be an out argument?

Hmm that should work - I will look into modifying the implementation to use @out


Add Lowest Points Test Case

also a missed rename in FindLocalPeaksTestCase

@mfunk please review and merge

@jmccausland checking it out now.

@jmccausland So I've shot myself in the foot with this one when I moved to the daily build of Pro 1.3, which now uses a different Python setup and now I'm unable to run the Pro tests. Still working on this one.

Got a workaround to the propy issue and back testing this again...


Fix listing pagination off-by-one bug (and add tests to confirm)

Addresses #56 and #141

[X] This change addresses the issue in full

Description
This change corrects the off-by-one error in totalPages in the pagination metadata, and adds tests that confirm that the fix gives the intended result.
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Can This Be Tested/Reviewed?
$ cd backend/core
$ yarn test:e2e:local

Thanks!


Manually trigger nightly

Signed-off-by: Edward Z. Yang<EMAIL_ADDRESS>

@ezyang can this be closed?


Display readable duration times

Mind squashing to a single commit?

it('test', function(done) {
  this.timeout(3000);
  setTimeout(done, 1485);
});

// Before PR
$ ./bin/mocha --reporter spec test.js

  ✓ test (1489ms)

  1 passing (1s)

// After PR
$ ./bin/mocha --reporter spec test.js

  ✓ test (1s)

  1 passing (1s)

I think I'm more of a fan of the current behavior in master. It's more helpful when the test duration is under a few seconds, or close to the timeout. With this PR, the reporter will output that the test took 2 seconds, when it only took 1500ms:
it('test', function(done) {
  this.timeout(1500);
  setTimeout(done, 1500);
});

$ ./bin/mocha --reporter spec test.js

  1) test

  0 passing (2s)
  1 failing

  1)  test:
     Error: timeout of 1500ms exceeded. Ensure the done() callback is being called in this test.
      at null.<anonymous> (lib/runnable.js:189:19)

I vote to close this PR:

mainly because its ancient and no signs of demand to get it merged.
IMHO, if we want to change this behavior, it might be better to do it on the runner.js to affect all reporters.
I prefer the current behavior.
no CLA signed


/bb-admin folder is missing in the downloaded BoxBilling.zip file

I downloaded the BoxBilling.zip file from the https://www.boxbilling.org/ and downloaded file link is https://github.com/boxbilling/boxbilling/releases/download/<IP_ADDRESS>/BoxBilling.zip . I noticed that the /bb-admin folder directory file missing in this downloaded file. That's why I facing issues after installing the BoxBilling. I getting a 404 not found error.
Is there anybody who can help me soon?

Could you give us more information on your installation steps?

Thanks for your reply. I want to install boxbilling on CyberPanel..
I downloaded it and I installed it according to the instructions of
boxbilling..
Summary of my installation process:
I uploaded the boxbilling.zip file into my targeted root directory. After
that, I created a empty database. After that extracted the zip file.after
that I installed it. After completing the installations I set up the
cron-job accordingly and I changed the bb-config.php file's permission into
644.
But, I got the 404 error message only for the admin area. I got the client
area.
On Fri, 26 Aug 2022, 12:50 pm Shamshid, @.***> wrote:

Could you give us more information on your installation steps?
—
Reply to this email directly, view it on GitHub
https://github.com/boxbilling/boxbilling/issues/1388#issuecomment-1228121590,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARKJGZFFIUYDVK6LRTM63QTV3BSMRANCNFSM57H6NOUA
.
You are receiving this because you authored the thread.Message ID:
@.***>

That isn't why you're facing issues. Your web server should rewrite requests coming to bb-admin/* to the admin panel. The bb-admin folder doesn't exist as a regular folder.
If you're using Apache, make sure you've renamed .htaccess.txt to .htaccess (with the dot in the beginning). If you're using nginx, configure your web server according to this example configuration file.
Also we, the majority of the team behind BoxBilling for the last 2 years had to create a fork of the project and continue the development under a new organization called FOSSBilling. Any future contribution from us will be made to FOSSBilling and not BoxBilling.
We'll release a blog post clarifying everything in the future, but for now, you can join our Discord server here: fossbilling.org/discord
Here is the link to the new organization: fossbilling.org

Fossbilling is ready to use?
On Fri, 26 Aug 2022, 8:15 pm evrifaessa, @.***> wrote:

That isn't why you're facing issues. Your web server should rewrite
requests coming to bb-admin/* to the admin panel. The bb-admin folder
doesn't exist as a regular folder.
If you're using Apache, make sure you've renamed .htaccess.txt to
.htaccess (with the dot in the beginning). If you're using nginx, configure
your web server according to this example configuration file
https://github.com/boxbilling/boxbilling/blob/master/data/nginx.conf.
Also we, the majority of the team behind BoxBilling for the last 2 years
had to create a fork of the project and continue the development under a
new organization called FOSSBilling. Any future contribution from us will
be made to FOSSBilling and not BoxBilling.
We'll release a blog post clarifying everything in the future, but for
now, you can join our Discord server here: fossbilling.org/discord
Here is the link to the new organization: fossbilling.org
—
Reply to this email directly, view it on GitHub
https://github.com/boxbilling/boxbilling/issues/1388#issuecomment-1228544743,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARKJGZB3FUAX6QLE7R462JDV3DGPDANCNFSM57H6NOUA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Fossbilling is ready to use?

Well, it's the exact same codebase with BoxBilling with patchs applied. It's as stable as BoxBilling and has nearly all of its features. But I can't really say either of them are production-ready.

I would like to get the custom register adding option like the reseller
club. I got the ID & API key from my domain register.
On Sat, 27 Aug 2022, 9:42 am MRM IT Network, @.***> wrote:

Hi there,
I would like to connect my custom domain register here via API. How to I
can do it? Can you please give me an idea?
On Fri, 26 Aug 2022, 9:01 pm evrifaessa, @.***> wrote:

Fossbilling is ready to use?
Well, it's the exact same codebase with BoxBilling with patchs applied.
It's as stable as BoxBilling and has nearly all of its features. But I
can't really say either of them are production-ready.
—
Reply to this email directly, view it on GitHub
https://github.com/boxbilling/boxbilling/issues/1388#issuecomment-1228605463,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARKJGZGZTCMM6YG6IVMMB2LV3DL5DANCNFSM57H6NOUA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi there,
I would like to connect my custom domain register here via API. How to I
can do it? Can you please give me an idea?
On Fri, 26 Aug 2022, 9:01 pm evrifaessa, @.***> wrote:

Fossbilling is ready to use?
Well, it's the exact same codebase with BoxBilling with patchs applied.
It's as stable as BoxBilling and has nearly all of its features. But I
can't really say either of them are production-ready.
—
Reply to this email directly, view it on GitHub
https://github.com/boxbilling/boxbilling/issues/1388#issuecomment-1228605463,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARKJGZGZTCMM6YG6IVMMB2LV3DL5DANCNFSM57H6NOUA
.
You are receiving this because you authored the thread.Message ID:
@.***>


docs: made updates about security files and improving sentences

Why:
This would help users gain a better understanding about the SECURITY.md file and how to effectively use YAML when creating issue forms for their repositories.
Closes #32048

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

@CBID2 Thanks so much for opening a PR with these fixes! ✨ I made one small adjustment, and removed an unnecessary "on" on line 24 💛
I'll get this merged once tests are passing 🍏


[SDLe][Snyk]Upgrade to<EMAIL_ADDRESS>to fix vulnerability scanned by Snyk

Latest scanning on PMem-Spill, new vulnerabilities are found, so we need to keep on upgrading the Jetty version.


Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)""

Reverts flutter/flutter#61395 due to additional StateError exceptions being thrown.

TBR

LGTM


FATAL ERROR: v8::FromJust Maybe value is Nothing.

Hello, I get this "FATAL ERROR: v8::FromJust Maybe value is Nothing." error message related to nodejs worker threads with either the .mjs or .cjs webpack.config template when I run react-native webpack-start. I have tried installing other node versions (v16.10.0) and running yarn cache clean and npm cache clean --force as some google search results for "FATAL ERROR: v8::FromJust Maybe value is Nothing" suggested and I still get this error. Any insight as to what might be causing this or how I can troubleshoot this would be appreciated. Thank you!

Could you share a minimal reproduction repository with a list of steps to follow to see the behavior you described?

I am only experiencing it with a large monorepo of private code. The closest I have come to replicating it in a smaller example is hitting ctrl + c in the terminal of the webpack dev server of either a federated module or host after it has started bundling in response to first request and before it has completed. Sometimes I will see the same FATAL ERROR: v8::FromJust Maybe value is Nothing general message. So I think something is killing the webpack dev server process during the bundling of the larger monorepo app. I see nodejs memory and CPU usage spike in activity monitor on mac before it happens. I am not sure if it's related to the large amount of JS to process, the fact that it's a monorepo and symlinks could be causing confusion or cyclic dependencies causing CPU/memory to spike, or something else? I know it works for metro bundler and I am trying to compare the config from metro to webpack and see if there is something I need to set in webpack that metro already handles. I am able to get it to bundle in a smaller stripped down version of this app without as many of the monorepo packages so something related to the amount of JS and symlinks. Sorry I can't provide a better reproducible example. I will update this issue as I learn more in case others run into similar problem

A quick google search revealed that many packages are affected by the FATAL ERROR: v8::FromJust Maybe value is Nothing error, and it looks like a generic error that can happen for many reasons. There's even one in the node repository (https://github.com/nodejs/node/issues/6899). Without an environment where the issue can be easily reproduced most of the time, I won't be able to help here.
One quick fix might be to use a more up-to-date version of the node itself (in your error log, I can see you're using node v14, which is pretty old and will hit the end of life in two weeks – https://nodejs.dev/en/about/releases/), this was even suggested in the closing comment in the linked issue.
I'm closing this one for now, please feel free to comment/reopen it if you'd like to provide a repro repo.

Yeah, I did try several newer node versions back when I posted and no luck. Thanks!


Fix typo in history.rst

I know it's minor, but may as well submit it since I noticed.
Scott K

Thanks!


Remove recently added adult specificity to X lineage neuron terms [sf#8]

Reported by djs93 on 2013-06-11 14:07 UTC
In the last update (1306), terms of the form X lineage neuron, defined as "neuron that develops_from some <neuroblast X>" were given an additional restriction - to adult stages.  This was useful for the current VFB release, but in hindsight was a mistake.  As a result, a handfull of expression records for larval expression now have an officially adult specific term.  This should be fixed by broadening the meaning of these terms by removing the restriction to adult stage in both name and formal def. No retrofits will be required.

Commented by mmc46 on 2013-11-20 17:56 UTC
Hi David,
Do you mean to remove only the 'intersection_of: part_of FBbt:00003624 ! adult brain' from all 'adult X lineage neuron' (and change the name)?
And also remove the 'relationship: part_of FBbt:00050250 ! adult VPNp1 lineage clone'?
name: adult VPNp1 lineage neuron
def: "."

Browsing results of MATCH (a:Neuroblast)<-[develops_from]-(b) WHERE b:Neuron AND b:Class RETURN DISTINCT a.label, b.label, it looks like most NBs now have a stage-neutral class (often in addition to adult-specific) for their neuronal progeny (but some don't).
Rather than removing all adult-specific terms, shall I just add new neutral terms where needed?
We probably do want to change 'part of' some 'adult brain' to 'part of' some adult for the adult-specific terms. This is also an issue for the adult-specific clones.
Also noticed that some terms are using non-matching NB terms e.g.

neuroblast EBa1
DALv2 lineage neuron

so these neurons should probably be renamed too.

brain requirement removed in #1120 (now nervous system)
name mismatches now seem to be fixed
closing this as it is too late to broaden definitions (most lineages now already have a stage non-specific term and original issue is from 8 years ago)


python3Packages.mhcflurry: init at 2.0.6

Description of changes
Adds https://openvax.github.io/mhcflurry/index.html for MHC class I peptide presentation prediction.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I'll merge tomorrow unless anyone objects?


Simplify F.linear_interpolate test

Simplifies test_linear_interpolate using testing.FunctionTestCase
Refer to #6071

LGTM. Jenkins, test this please.

Jenkins CI test (for commit 1f55ec6ac6a82f80e9af24b2d2f5310b0db77ba8, target branch master) failed with status FAILURE.

pfnCI, please

Jenkins issue looks unrelated.


Revert to use specific destroy func

revert testacc

i am checking it now

@dmacvicar  feel fee to merge this one, works and tests locally

thanks a lot!


Stuck at : git: Checking Repo status

as soon as I activate the plugin it gets stuck at: git: Cecking Repo Status
Thats the error in the Dev Console:

I'm using SSH instead of https, might that be a problem?
My remote origin isn't named the default "origin", i named it "remote".
The branch is called mainVault.
(So i can do: git push remote mainVault)

Hello! The error says that it cannot find git executable. I've been just debugging very similar case yesterday, and what helped is going to your vault directory from the command line and re-initializing the git repo.
Please try it and let me know how it goes?
cd C:\path\to\your\vault
git init

After this, please restart the app.

Still the same error..
I am using Linux if that helps

I'm having the exact same error. Also in linux

Could you please verify that git is indeed installed and is in system's $PATH? There also might be a directory permission issue, when process cannot access the working directory, but provided that you can save/load your vault files from within Obsidian, this shouldn't be the case.
which git
echo $PATH

People who had similar issues report that reinitializing local repo (git init) helps. I will play around with that and push a patch version, we could try that and see if it helps.

it is indeed installed and I can use it normally
i will comment the outputs of both commands tomorrow

I get the same error in Windows. I tried the above steps. Right now, I'm pushing the files manually.

I've tried to reinitialize by running git init again and it makes no differente.
The output of the commands is:
❯ which git
/usr/bin/git

❯ echo $PATH
/home/genar/.rbenv/shims:/home/genar/.yarn/bin:/home/genar/.nvm/versions/node/v14.15.0/bin:/home/genar/.rbenv/plugins/ruby-build/bin:/home/genar/.rbenv/bin:/home/genar/.cargo/bin:/home/genar/.npm-global/bin:/home/genar/go/bin:/home/genar/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/home/genar/src/android-sdk-linux/tools:/home/genar/src/android-sdk-linux/platform-tools:/bin:/home/genar/go/bin:/home/genar/Android/Sdk/platform-tools:/home/genar/Android/Sdk/tools

I can use git with no problems in terminal.

@gtrias Yeah, your binary seems to be ok. Honestly, I am not sure why Obsidian process does not have access to git executable.
Could you double check directory persmissions? Is it read-only/write-only by any chance?

I get the same error in Windows. I tried the above steps. Right now, I'm pushing the files manually.

Same case with me. I tried re-initializing like given above. Still stuck on git: checking repo status..

Hi! I've got this problem too on Pop!_OS 20.04. Obsidian is installed via Flatpak.
First the error message was the same as @phibr0 has. I thought it might be a permission issue, so I used Flatseal to make a risky thing: give the Obsidian permission to all system files:

After that the error changed, and now it looks like this:

I'm not into JS, but I can perform some additoinal actions and post results here if needed.

hey @weiss-d, it looks like the same error to me - Error: spawn git ENOENT, which indicates that Obsidian process cannot access git executable. The official troubleshooting section of the underlying lib that talks to git for this kind of error indicates two possibilities:

git binary isn't available to the user running the Obsidian process
vault directory isn't read/write accessible by the user running the Obsidian process

GIven that directory permissions are fine and you can use git commands from command line, I am not sure what could be the problem :/ I will let you know if I stumble upon a solution for this.

Since it seems to be an issue with Obsidian (at least thats what i think) i contacted the Obsidian Team, maybe they can help

Good idea, even though it's probably not related to Obsidian itself, they might point out something obvious that we're missing.

Maybe it is not related to the issues above, but I was stuck at the "Checking repo status" as well.
My solution was to add .gitignore and manually pull it. Obviously the .gitignore is needed...

Maybe it is not related to the issues above, but I was stuck at the "Checking repo status" as well.
My solution was to add .gitignore and manually pull it. Obviously the .gitignore is needed...

I also have .gitignore file, but this make no difference in my case.

also have one
doesnt make a difference to me

I have the same issue "git: checking repo status" even after reinitializing the git repo in the folder.
If I change the automatic backup time to 1 min, it works. I then reset it to 60 and it continues to work until my computer goes to sleep.

What message do you get when you open the console (using ctrl+shift+i)? Maybe you are stuck somwhere with git and it throws back some issues.

I have the same issue "git: checking repo status" even after reinitializing the git repo in the folder.
If I change the automatic backup time to 1 min, it works. I then reset it to 60 and it continues to work until my computer goes to sleep.

@monishkumar7 and where are these options in your case? I didn't find any tab for this plugin in Obsidian settings window.

I have the same issue "git: checking repo status" even after reinitializing the git repo in the folder.
If I change the automatic backup time to 1 min, it works. I then reset it to 60 and it continues to work until my computer goes to sleep.

@monishkumar7 and where are these options in your case? I didn't find any tab for this plugin in Obsidian settings window.

Under the plugin options. It showed up for me only after I initialized a git repo in my vault.

Hey people, whoever is on Windows - please try installing official git for Windows, some people report that it solves their problems with the plugin.

Same issue here on Linux.
My suspicion is that this is somehow related to Obsidian being installed via flatpak. The plugin used to work just fine for me, and I recently switched from AppImage to flatpak.

Snap doesnt work either..

I'm on Pop_OS! and installed with Flatpak, I found that it does work if you start obsidian from the command line.
/home/$USER/.local/share/flatpak/app/md.obsidian.Obsidian/current/active/files/obsidian

I'm on Pop_OS! and installed with Flatpak, I found that it does work if you start obsidian from the command line.
/home/$USER/.local/share/flatpak/app/md.obsidian.Obsidian/current/active/files/obsidian

That's interesting. I started the Obsidian this way and it asked me to make or open a vault like there have never been one.
Then I selected 'Open' and pointed it to the repo dir. The vault opened, I enabled Git plugin and there a tab for its configuration appeared in configuration window.
No username or password fields were in settings. I set it to pull changes on startup and sync every minute after, and restarted Obsidian. After this restart the plugin configuration tab disappeared and the status hanged on git: pulling changes....
I restarted it once again, and configuration tab was there. I looked into the terminal from which it was started and saw a prompt to enter Github login and password.
After entering them, the status changed to git: last update 1 minute ago.... Then after a minute it asked for Github login in the terminal once again, and then every minute.

@weiss-d to permanently cache the credentials run:
git config --global credential.helper store

after that it should stop asking for credentials

@denolehov thanks, that makes sense! :)
As for successful work only after launching as a binary file, looks like it might be a Flatpak issue.
Maybe @joshua-stone, who's the main contributor to Obsidian Flatpak package, may help somehow?

@weiss-d @Ghost-Coffee @inputsh @phibr0 I've made a change to the Obsidian flatpak by bundling git. I think a more ideal solution would be to package git and other common binaries required by third-party plugins until a Plugins runtime extension, but for now this is a quick fix that'll hopefully address this issue.
Simply update and reset any permissions overrides you set before restarting Obsidian:
$ flatpak update md.obsidian.Obsidian
$ flatpak override --reset md.obsidian.Obsidian
$ flatpak run md.obsidian.Obsidian

Let me know if you still have issues with git!

Thank you!
it works fine

@joshua-stone, big thanks!

I'm having the same issue -- I tried git init in the directory, along with verifying git was on my path. I'm having this issue on Mac.
Strangely, I have this working fine on my other macbook. The only real difference between the two is that the MacBook that this is working on is on Catalina, and the one it is not working on is on Big Sur.

Strangely enough, opening obsidian via the command line with open -a obsidian made everything work. I'm no sure how to make this work when opening obsidian via the GUI though.

Hey people, whoever is on Windows - please try installing official git for Windows, some people report that it solves their problems with the plugin.

I am still facing this issue :/ hope it can be fixed somehow

Hey people, whoever is on Windows - please try installing official git for Windows, some people report that it solves their problems with the plugin.

I am still facing this issue :/ hope it can be fixed somehow

I manage to open and launch the plugin by having this option:

but when I tried to push it gave me this error, and the plugin does not launch:

I tried to git init but did not solve it. before it crashed I used the command in obsidian to push, after setting the time interval to sync.
Any ideas on what is going on here? Thank you

@lsilvam From that error message, it looks to me like you've cloned your repository using HTTPS instead of using SSH. Use SSH instead, since the plugin can't ask for your username/password.
Here's GitHub's docs on how to do that: https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/connecting-to-github-with-ssh

@lsilvam From that error message, it looks to me like you've cloned your repository using HTTPS instead of using SSH. Use SSH instead, since the plugin can't ask for your username/password.
Here's GitHub's docs on how to do that: https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/connecting-to-github-with-ssh

I tried but I am having an issue somewhere that I can't solve; it works with git/CMD but does not work with Obsidian Git nor with Github Desktop.
The ssh agent seems to have the keys, on the Web I can see that they were successfully used; but only when I use the CMD line.
Ah, and the 'git remote - v' shows the correct url...

Linux problems should be fixed by the flatpak changes. Snap versions should be working with --classic?? Windows problems should be fixed by installing git with 3rd-party software access enabled. Authentication issues are another problem. See #23

Strangely enough, opening obsidian via the command line with open -a obsidian made everything work. I'm no sure how to make this work when opening obsidian via the GUI though.

Is it still working on the obsidian v0.12.12 ?
I got this error from the DevTools
There is no tracking information for the current branch.
Please specify which branch you want to merge with.
See git-pull(1) for details.

@fahmifan Can you try running git push without extra arguments from the terminal in your vault? It should prompt you a command to set the tracking branch.

@Vinzent03 this is the output
➜ git push
fatal: The current branch master has no upstream branch.
To push the current branch and set the remote as upstream, use

    git push --set-upstream origin master

It should prompt you a command to set the tracking branch.
tracking branch is like upstream branch. Just run this command

@Vinzent03 thanks it works!

I had the similar problem in my Ubuntu 20. The error in the debug log said spawn git ENOENT. I was able to use git via terminal and verified git binary path was in $PATH.  I had installed obsidian using snap package. I uninstalled obsidian and installed it using deb file. After that it started working.


Can quick render contents to stdout in GUI window?

In my case, I expect to see the printed stuff rather than to stdout of terminal, but on the GUI window. Why? It is the output of the command which I need check carefully. As a stand alone GUI app, after launching it, I don't want to go to terminal again to check output. Does it make sense?
Maybe quick already done so, could you show me how to enable this if that is the case?

Thanks for your suggestion. Because at the very beginning, I just implemented something quick to wrap the command line parser. But I think it should not be that hard to add this feature.

Yeah, it would be great if it output a log to a large text field, and popped up a window if there was an error. Like in Gooey:

added in 6d0caf2c61f5afa79e09299d175161ae836b7d63


Networking: Dynamic interface MTU

Is your enhancement proposal related to a problem? Please describe.
The Zephyr network interface APIs' expose an MTU (maximum transmission unit), but this is a compile-time hardware MTU, not a runtime network MTU.
https://github.com/zephyrproject-rtos/zephyr/blob/d06e95c49b75dfc911f2ab77c2a934abe624c751/include/zephyr/net/net_if.h#L657-L658
https://github.com/zephyrproject-rtos/zephyr/blob/d06e95c49b75dfc911f2ab77c2a934abe624c751/include/zephyr/net/net_if.h#L1234-L1243
The compile-time value in insufficient to avoid fragmentation because while the hardware may support an MTU of X, the network the hardware is currently connected to may only support a MTU of Y. The MTU of LTE networks in particular is highly variable between different providers, with devices jumping between networks as they travel.
Describe the solution you'd like
A common pattern where upon the transition into NET_IF_OPER_UP, the MTU of the current network is provided to the stack and is queryable by end users in the appropriate networking event callback (e.g. NET_EVENT_L4_CONNECTED, NET_EVENT_WIFI_CONNECT_RESULT)

It looks that the MTU stored in iface->if_dev->mtu is already possible to override with net_if_set_mtu(), isn't that enough? Or do you propose that we store a separate value for the network MTU at the net_if level?


[Snyk] Security upgrade serve from 11.3.0 to 14.1.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `yarn` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

examples/v10/start-and-yarn-workspaces/workspace-2/package.json

⚠ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

479/1000  Why? Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-JS-MINIMATCH-3050818
Yes
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Will be included in https://github.com/cypress-io/github-action/pull/673


media-types: Replace Docker link with internal descriptor link

The Docker link landed in #55, but we've had a descriptor definition locally since #111.

LGTM

Oops, I accidentally bumped this branch and have since reset it to the original f4a7ea2.  I'm not sure what that does with PullApprove LGTMs, but @jonboulle's earlier LGTM may no longer count.

LGTM

LGTM


sumtype fails to match lambdas with anonymous arguments

crazymonkyyy reported this on 2024-05-31T21:48:13Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=24575
CC List

alphaglosined

Description
```d
import std;
struct tree(T){
	alias node=typeof(this)[2]*;
	SumType!(T,node) data;
	bool isleaf()=>
		data.match!(
			(T)=>true,
			(node)=>false);
}
unittest{
	tree!int foo;
}
```

adding names to the lamdas arguments cause it to compile

alphaglosined commented on 2024-05-31T22:02:20Z
This is expected behavior.

Those lambdas are templates, adding names stops that.


Add DeleteInstallation for GitHub Apps

Adds support for deleting a GitHub app installation (https://developer.github.com/v3/apps/#delete-an-installation).
Closes #1436.

Thank you, @wesleimp!
Resolving merge conflicts...

Merging.


GraalVM builds broken for x86_64-darwin on unstable

Describe the bug
On current nixpkgs unstable, GraalVM 11 and 17 both fail to build for darwin.
Since this is a build dependency of several other packages like babashka and clj-kondo, these are also broken.
We have bisected nixpkgs and found that the regression was likely introduced in https://github.com/NixOS/nixpkgs/pull/149731
Steps To Reproduce
Steps to reproduce the behavior:

Be a Mac
nix-build -A graalvm11-ce https://github.com/nixos/nixpkgs/tarball/12e48068a5aa63a3965d9a0c65409c875c5877c4

Expected behavior
The build should succeed
Screenshots
Error message from the build:
patching script interpreter paths in /nix/store/mh8g4k1azqa8xx6mnlcfknckdhaybx1i-graalvm11-ce-lib
Traceback (most recent call last):
  File "/nix/store/0jzc88szm7fsjrhzs7jbcj4ini24sj9f-auto-patchelf.py", line 322, in <module>
    with open_elf(interpreter_path) as interpreter:
  File "/nix/store/3j4k5ja8zpr7v5xiyfgjwjb8qnl4iycv-python3-3.9.10/lib/python3.9/contextlib.py", line 119, in __enter__
    return next(self.gen)
  File "/nix/store/0jzc88szm7fsjrhzs7jbcj4ini24sj9f-auto-patchelf.py", line 26, in open_elf
    yield ELFFile(stream)
  File "/nix/store/0qmwd1hj38nj7dsnyhn5pxbwqv6f52m1-python3-3.9.10-env/lib/python3.9/site-packages/elftools/elf/elffile.py", line 73, in __init__
    self._identify_file()
  File "/nix/store/0qmwd1hj38nj7dsnyhn5pxbwqv6f52m1-python3-3.9.10-env/lib/python3.9/site-packages/elftools/elf/elffile.py", line 482, in _identify_file
    elf_assert(magic == b'\x7fELF', 'Magic number does not match')
  File "/nix/store/0qmwd1hj38nj7dsnyhn5pxbwqv6f52m1-python3-3.9.10-env/lib/python3.9/site-packages/elftools/common/utils.py", line 77, in elf_assert
    _assert_with_exception(cond, msg, ELFError)
  File "/nix/store/0qmwd1hj38nj7dsnyhn5pxbwqv6f52m1-python3-3.9.10-env/lib/python3.9/site-packages/elftools/common/utils.py", line 114, in _assert_with_exception
    raise exception_type(msg)
elftools.common.exceptions.ELFError: Magic number does not match

Additional context
The builds are failing on Hydra too:
https://hydra.nixos.org/job/nixpkgs/trunk/graalvm11-ce.x86_64-darwin
https://hydra.nixos.org/job/nixpkgs/trunk/graalvm17-ce.x86_64-darwin
#163924 Looks like it may be related to this.
Notify maintainers
Author of #149731:
@layus
GraalVM package maintainers:
@bandresen
@volth
@hlolli
@glittershark
@babariviere
@ericdallo
@thiagokokada

However, strange that this seems to be affecting only M1 and not Intel Macs. I will take a look but can't promise anything since I only have access to a Intel one.

#163924 should already fix this, so I don't think we need to do anything.

However, strange that this seems to be affecting only M1 and not Intel Macs. I will take a look but can't promise anything since I only have access to a Intel one.

Wait, is that true?
The machine that we reproduced this on happened to be a M1 mac running Nix in x86_64 emulation, but nothing I've seen so far indicated that Intel macs wouldn't be affected.

However, strange that this seems to be affecting only M1 and not Intel Macs. I will take a look but can't promise anything since I only have access to a Intel one.

Wait, is that true?
The machine that we reproduced this on happened to be a M1 mac running Nix in x86_64 emulation, but nothing I've seen so far indicated that Intel macs wouldn't be affected.

I got the same error on my Intel Macbook.

However, strange that this seems to be affecting only M1 and not Intel Macs. I will take a look but can't promise anything since I only have access to a Intel one.

Wait, is that true?
The machine that we reproduced this on happened to be a M1 mac running Nix in x86_64 emulation, but nothing I've seen so far indicated that Intel macs wouldn't be affected.

I am completely sure that I read in the report that it was happening only on aarch64-darwin, but it seems I misread. It makes more sense to happens on both anyway, since as I said autoPatchElf shouldn't be used on darwin at all (macOS doesn't use ELF format for binaries).
Anyway, it doesn't seem to matter to much since there is a fix already.

Since #163924 was merged in staging, I am building babashka on staging right now to see if the issue is fixed. If not, I will try to investigate the issue.

Finished generating 'bb' in 5m 22s.
installing
post-installation fixup
strip is /nix/store/2dwp1nhk1zsv8fq9djqq4nmhih2abnj9-cctools-binutils-darwin-949.0.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/gvy48ay4d4rvmg4ww6933zqsd405k1gc-babashka-0.7.8/bin
patching script interpreter paths in /nix/store/gvy48ay4d4rvmg4ww6933zqsd405k1gc-babashka-0.7.8
/nix/store/gvy48ay4d4rvmg4ww6933zqsd405k1gc-babashka-0.7.8

~/Projects/nixpkgs staging 12h 40m 40s
❯ ./result/bin/bb -e '(+ 1 1)'
2

So it seems to be working fine in staging.

PowerShell seems broken too.

This has been solved for a while now in unstable, closing.


Start-DbaMigration using Ola hallengren backup structure

Bug Report
Hello, triying to use Start-DbaMigration using a network drive containing Ola hallengren  backup structure, but apparently is not possible using dbatools?
General Troubleshooting steps

[x ] Verified running the latest release of dbatools?
[ x] Verified errors are not related to permissions?
[ x] Can duplicate in new/clean PowerShell session (clean = powershell -NoProfile)?

Getting the following output VERBOSE: [Get-DbaDefaultPath][16:47:43] Attempting to connect to PVSQLDBS101
WARNING: [Restore-DbaDatabase][16:47:43] No backups passed through.
This could mean the SQL instance cannot see the referenced files, the file's headers could not be read or some other
issue

hey dan,
Start-DbaMigration is intended to be a live instance to instance migration. What you can do is use Restore-DbaDatabase and then Start-DbaMigration -NoDatabase

@danglade : closing this, feel free to reopen if you got any doubts (or hang out on our Slack channel ^_^)


Docker extension push notification if new issue discovered

After initial investigation, we can't highlight the docker desktop icon in the system toolbar.
Maybe we can show some "notification dot" next to the extension name. We can try it with the Toast API:
https://docs.docker.com/desktop/extensions-sdk/dev/api/reference/interfaces/Toast/


[Feature]Resources > File Manage should support category management

When have lots of files, it's difficult to manage, adding categories makes it easier to manage.

+1

Close this issue since file folder has supported in 1.3.x


Extensions don't load after upgrading to v1.27.2

VSCode Version: 1.27.2, also tried on Insiders 1.28.0
OS Version: Mac 10.13.6

Steps to Reproduce:
After upgrading to 1.27.2 extensions don't seem to load. For example, GitLens or VS Live Share don't show up in the sidebar, the Vim extension is not working anymore, etc. Here's an screenshot of those extensions being installed and enabled, but not appearing in the sidebar:

Does this issue occur when all extensions are disabled?: No (misses the point)
I don't know how to help debugging this. I tried searching the issues list and couldn't find anything related.
Thanks!

I tried downloading versions 1.27.0 and 1.27.1, but extensions still don't load.
This is the Developer Tools screen I'm getting:

@mrcasals Can you please right click on the activity bar (side bar) and let us know what you see?

@sandy081 this is what I see:

@mrcasals Can you please check if you configured Gitlens to be shown in SCM viewlet rather as separate viewlet?
Not sure if there is a similar setting for Live share?
Can you also try other extensions like Docker that contributes view to sider bar?

@sandy081 I didn't modify any settings related to this. On the first screenshot I posted you can see how the status bar is missing the "Share" button from VS Live Share. Other extensions have stopped working too, like the Vim one.
Also, it looks like VSCode is failing to detect Git for any given open folder, could this be related? Here are the steps I took:

Click on the File menu, and open a folder that is also a git project
Click on the Source Control button on the side bar
See this:

For the docker extension: I installed it and now I can see it on the sidebar:

If I try to uninstall and reinstall VS Live Share or GitLens, they don't appear...

Can you please run the command Show Running Extensions and let us know what you see?

@sandy081 I ran it and the screen was completely blank. I realized I have been using the laptop without restarting it for quite a few days now, I restarted the laptop... And extensions now magically work!

The "Source Control" tab works as expected, the status bar shows the extensions there... I think it's weird I had to restart the laptop to make this work, but hey, it works.
This issue can be closed, unless you want to keep it open to try to figure out what was happening 😄
Thanks for your time!

Sorry for not helpful to resolve the issue. Since you can no longer reproduce it is hard to diagnose the issue. Closing this.


fix README preview image

oh, actually it looks like https://butterchurnviz.com/static/img/preview.png is hosted fine.  it's just that Github is changing the URL to something like https://camo.githubusercontent.com/8d42eaf131414b1214ecbaf7310986cb630393c8a2bf0c741bf548f900a1c146/68747470733a2f2f627574746572636875726e76697a2e636f6d2f7374617469632f696d672f707265766965772e706e67 (which, when loaded stand alone, returns Non-Image content-type returned) when rendering the README on https://github.com/jberg/butterchurn.  weird.
not clear this PR would help that 😞


Add option to use LakeFormation in S3Glue data source.

Description
Enables OpenSearch users to use LakeFormation option when querying the S3Glue data source.
This is important because some Glue tables are managed by LakeFormation. The customer will need to pass in a property for LakeFormation in order to not break backwards compataibility.
Note that this feature is launching in EMR serverless next month, so an error is thrown. Adding it in now so it's in the next release which is in line with the launch of this feature on EMR serverless.
Testing
Built locally with 2.13 as version and then copied over to cluster running 2.13.
Validating that property is read and correct configuration is added to Spark config
curl --request POST  --url http://localhost:9200/_plugins/_query/_datasources   --header 'content-type: application/x-ndjson'   --data '{"name": "mygdc","description": "","connector": "S3GLUE","allowedRoles": [],"properties": {"glue.auth.type": "iam_role","glue.auth.role_arn": "arn:aws:iam::xxxxxxxxxxxx:role/flint-opensearch-execution-role","glue.indexstore.opensearch.uri": "http://ec2-xx-xx-xx-xx.compute-1.amazonaws.com:9200","glue.indexstore.opensearch.auth": "noauth", "glue.lakeformation.enabled": "true"}}'
curl --request  POST   --url http://localhost:9200/_plugins/_async_query   --header 'content-type: application/x-ndjson'   --data '{"datasource": "mygdc","lang": "sql","query": "SELECT * FROM mygdc.amazon_security_lake_glue_db_us_east_1.amazon_security_lake_table_us_east_1_vpc_flow_2_0 LIMIT 1"}'
{
  "status": 500,
  "error": {
    "type": "RuntimeException",
    "reason": "There was internal problem at backend",
    "details": "Internal Server Error."
  }
cat ~/tmp/opensearch.log
com.amazonaws.services.emrserverless.model.ValidationException: Lake Formation configuration can only be specified at the application level, not at job run level.
}

Check List

[X] New functionality includes testing.

[X] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@asuresh8  can you update the docs over here with the new property: https://github.com/opensearch-project/sql/blob/main/docs/user/ppl/admin/connectors/s3glue_connector.rst

As discussed earlier, we may need to disable covering index rewrite if LF enabled (until better solution): https://github.com/opensearch-project/opensearch-spark/pull/318/files#diff-cf86f425a16363ac48fd59d28648420bc5c961b1b472edfb54075360633be338R136

This new config is configurable for open source user, right? Could you update user manual if so, maybe here https://github.com/opensearch-project/sql/blob/main/docs/user/ppl/admin/datasources.rst?

Done

As discussed earlier, we may need to disable covering index rewrite if LF enabled (until better solution):

Done


dune build failed after opam monorepo pull

The dune seems to be confused by the (intentionally) broken dune-project files after opam monorepo pull pulls in all the dependencies.
File "duniverse/dune_/test/blackbox-tests/test-cases/dialects.t/bad1/dune-project", line 9, characters 1-74:
 9 |  (name d)
10 |  (implementation (extension foo2))
11 |  (interface (extension bar2)))
Error: dialect "d" is already defined

(I am not completely sure where to report this---but I suppose it is okay to report the issue here.)

Thanks for reporting this!
It is a known bug in dune, it has been reported here and fixed upstream but not released yet unfortunately.
The bug is in the host dune, i.e. the one installed locally. Once the fix is released, upgrading your local dune should solve this issue. In the meantime the workaround is either to remove the problematic test from the vendored dune_ folder by running:
rm -r duniverse/dune_/test/blackbox-tests/

or to make sure you vendor a version of the repo that doesn't contain this test by adding the following conflict to your opam file:
conflicts: [
  "dune-build-info" {= "2.7.0" | = "2.7.1"}
  "dune-configurator" {= "2.7.0" | = "2.7.1"}
]

and running opam monorepo lock and opam monorepo pull again.

Thanks for reporting this!
It is a known bug in dune, it has been reported here and fixed upstream but not released yet unfortunately.
The bug is in the host dune, i.e. the one installed locally. Once the fix is released, upgrading your local dune should solve this issue. In the meantime the workaround is either to remove the problematic test from the vendored dune_ folder by running:
rm -r duniverse/dune_/test/blackbox-tests/

or to make sure you vendor a version of the repo that doesn't contain this test by adding the following conflict to your opam file:
conflicts: [
  "dune-build-info" {= "2.7.0" | = "2.7.1"}
  "dune-configurator" {= "2.7.0" | = "2.7.1"}
]

and running opam monorepo lock and opam monorepo pull again.

I'm closing this but please don't hesitate to re-open or to reach out if the proposed workaround don't work for you for some reason!

I'm closing this but please don't hesitate to re-open or to reach out if the proposed workaround don't work for you for some reason!


Support new React Native Architecture

It would be great to support the New Architecture for Fabric/JSI. I think the easiest way to do this would be to use Expo's new Swift API. What do you think @dominicstop?

Also mentioned at #60

I am also waiting for new architecture support.
Any news @dominicstop ?

@dominicstop any news about New Architecture?

This is in progress now as the library is migrating to Expo Modules.


Feature Request: Include core-js and regenerator-runtime polyfills in sap.ui.core

OpenUI5 version: 1.86.3
Browser/version (+device/version): Any
Description:
As more and more developers want to use latest ECMAScript features when building their apps using UI5, there are more and more custom tasks and custom middlewares for the UI5 Tooling which focus on transpiling code, e.g. using babel such as:

ui5-middleware-livetranspile
ui5-task-transpile
ui5-middleware-babel
ui5-task-babel

As of babel 7.4.0 it is necessary to directly include core-js (to polyfill ECMAScript features) and regenerator-runtime (needed to use transpiled generator functions) (For details please see https://babeljs.io/docs/en/babel-polyfill).
The issue arises once one need to include these polyfills within the application.
Because of the way an UI5 app is loaded and instantiated compared to other frameworks and bundlers, this requires some additional boilerplate:
Prerequisite
Include project shims for the polyfills in ui5.yaml:
---
# Shims for thirdparty modules
specVersion: "2.3"
kind: extension
type: project-shim
metadata:
  name: thirdparty-shims
shims:
  configurations:
    # polyfill for ECMAScript features
    core-js-bundle:
      specVersion: "2.3"
      type: module
      metadata:
        name: core-js-bundle
      resources:
        configuration:
          paths:
            /resources/my/app/namespace/thirdparty/core-js-bundle/: ""
    # transpile generator functions (~ async await)
    regenerator-runtime:
      specVersion: "2.3"
      type: module
      metadata:
        name: regenerator-runtime
      resources:
        configuration:
          paths:
             /resources/my/app/namespace/thirdparty/regenerator-runtime/: ""

After the project shims have been created there are now two options for actually loading these polyfills as early as possible.
Option 1
Define them as js resources in the app's manifest.json:
{
  "sap.ui5": {
    "resources": {
      "css": [],
      "js": [
        {
          "uri": "/resources/my/app/namespace/thirdparty/core-js-bundle/minified.js"
        },
        {
          "uri": "/resources/my/app/namespace/thirdparty/regenerator-runtime/runtime.js"
        }
      ]
    }
  }
}

Option 2
Load them synchronously before defining the Component in Component.js:
(() => {
  sap.ui.requireSync('my/app/namespace/thirdparty/core-js-bundle/minified')
  sap.ui.requireSync('my/app/namespace/thirdparty/regenerator-runtime/runtime')
  sap.ui.define(['sap/ui/core/UIComponent'], UIComponent => UIComponent.extend("my.app.namespace.Component", {
    metadata: {
      manifest: "json"
    }
  }))
})()

However both approaches have the limitation that async await syntax will not be allowed in Component.js itself, as this file triggers the initial load of the polyfills.
To avoid this boilerplate and also to eliminate any further build issues both polyfills could simply be bundled and provided within the sap.ui.core as there are already other thirdparty polyfills included:
https://github.com/SAP/openui5/tree/master/src/sap.ui.core/src/sap/ui/thirdparty
One could simply omit any other es6 shims in favour of core-js and also include regenerator-runtime as well.
These would allow to use modern ECMAScript features when developing UI5 apps and also ensure backward compatibility with older browsers.
A full example project can be found here:
https://github.com/pwasem/bookshop-ui

I fully understand the pros of including core.js, but this is not the current direction of our thinking. We rather tend to limit UI5 itself (openui5 as well as SAPUI5, but not apps that are using it) to what all browser in our product availability matrix (PAM)*) support out-of-the-box.
Now, that IE11 support is history, this will allow a much broader range of Ecmascript features, but not everything that one can imagine.
@petermuessig I assigned you, maybe you want to comment on this.
*) the PAM has not yet been updated to reflect the end of support for IE11, so don't worry. With 1.88, IE11 support is history

Or, maybe, I misunderstood your request and you only want core.js to be packaged (but not bundled by default)? Maybe you can elaborate on that.
The request for including tasks rather goes to the ui5-tooling.

@codeworrior
My feature request would be to include and load core-js and regenerator-runtime within sap.ui.core itself, unless there is another way to load these or any other scripts or polyfills before loading Component.js despite my two options described above.
As of know this is quite a limitation compared to other frameworks.
Even if the ui5-tooling would include such tasks at some point the the script, polyfills, or resource would need to be loaded and requested by any application.
I am open to any other suggestions and solutions here.
But the overall target should be to enable modern JavaScript development for the UI5 ecosystem.

Hi @pwasem ,
I am not yet sure what the best solution for this is. Basically, including it in UI5 is too much "bottle-neck" style IMO. Also what @codeworrior  mentioned, with the latest version of UI5 we wanna get rid of most of our polyfills as we are de-supporting IE11. I think we need to have a better and future-proof solution for those kind of polyfills. It should be possible to integrate them easily on demand for applications and also for libraries.
The consumption of the polyfills from NPM packages and using the shims looks and feels good to me. The bigger problem is to find the right point in time / the place where those polyfills are integrated and executed at runtime. It somehow needs to be ensured to execute them even before and code from the application / library is excuted. The manifest.json doesn't look to be such a bad place. The main problem is when those resources will be included. With the manifest-first option for loading Components, we would ensure to load the manifest first and then the resources in the includes could be loaded. Unfortunately, as of today, the resources are included once the first component instance is being created.
@codeworrior - IMO, we may need to re-discuss whether we could have a special place to list polyfills in the manifest.json which could be loaded even before the first instance is being created or change the time when the resources includes are being added. Just food for thoughts right now.
Cheers,
Peter


housekeeping: Update cinephile

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Sample Update
What is the current behavior? (You can also link to an open issue here)
The sample is using ReactiveList, single project for Views and ViewModels and lacks in the unit tests for ViewModels
What is the new behavior (if this is a feature change)?
Cinephile now uses Dynamic data
The main project was split into: Views and ViewModels, it helps to keep it clean of errors (referencing Views on VMs and such. Also makes it easier to test)
Added some unit tests for the ViewModels
What might this PR break?
Cinephile sample
Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:

I've updated the project to use the analyzers we use for the main project, which enforces some rules around disposing, comments and culture awareness. This addresses a few of @alexmartinezm  comments.

Why is this closed?

Seems if you force push a branch it automatically closes pull requests.


Enrollment request make sure not enrolled

What are the relevant tickets?
Fix https://github.com/mitodl/hq/issues/3013
Description (What does it do?)
If you are already enrolled in this course run, and you go to product page and try to enroll again, it will not call create_run_enrollments
How can this be tested?
Enroll in a course run in certificate track. Make sure that PaidCourseRun is deleted.
Go to course product page try to enroll in the same run again. The enrollment post request should return duplicate error.
Repeat the same with the program product page. The program page enrolls you in the run it find convenient so make sure you are already enrolled for that run.
Question
I am not sure if we should should restrict re-enrollment only if the user is enrolled in verified track, or any type.

I think PaidCourseRun was deleted due to deferral procedure. But that is being corrected in this PR https://github.com/mitodl/mitxonline/pull/2146


Runnning Protractor with docker CodeceptJS

Running Protractor using Docker .
#Error: Cannot able to load codecept.conf.js
My docker-compose.yml
`version: '2'
services:
codeceptjs:
image: codeception/codeceptjs
volumes:
- "${HOST_PATH_SRC_TEST_SUITE}:/CodeceptJS-Test-Suite"
depends_on:
- selenium-chrome
selenium-chrome:
image: selenium/standalone-chrome:3.5.3
volumes:
- /dev/shm:/dev/shm
ports:
- "4444:4444"`
My Codecept.conf.js file
exports.config = {   tests: './tests/*_test.js',   output: './output',   helpers: {     Protractor: {       url: 'https://sbeta.com',       key:'asndksandkland',       driver: 'hosted',       browser: 'chrome',       angular: false,       host: chrome     },     REST: {       endpoint: ""     }   },   include: {     I: './steps_file.js',     loginPageObjectPage: './pages/LoginPageObject.js',     MidwareObject:'./support/MidwareFunctions.js'   },   bootstrap: null,   mocha: {     reporterOptions: {        reportDir: "output",        reportPageTitle: " E2E Test Reports",        reportTitle: "E2E Test Reports"     }   },   name: 'codeceptjs3' }

CodeceptJS version:
NodeJS Version:
Operating System: MAC OS
Protractor
Configuration file:

@lepadellec  As suggested I changed my volume , but when I am running using the command "docker-compose up" it cannot find any test cases in my tests folder .
Here is my docker-compose file
version: '2'
services:
codeceptjs:
image: codeception/codeceptjs
depends_on:
- selenium-chrome
environment:
- CODECEPT_ARGS=-c codecept.conf.js run
volumes:
- /Users/bjulaganti/dev/RMS-CodeceptJS-Test-Suite:/tests
dns:
- <IP_ADDRESS>
- <IP_ADDRESS>
selenium-chrome:
image: selenium/standalone-chrome:3.5.3
volumes:
- /dev/shm:/dev/shm
ports:
- "4444"
- '5900'
Here is the docker output screenshot

can you let me know what I am doing wrong here

@lepadellec As suggested I changed my volume , but when I am running using the command "docker-compose up" it cannot find any test cases in my tests folder .
Here is my docker-compose file
version: '2'
services:
codeceptjs:
image: codeception/codeceptjs
depends_on:

selenium-chrome
environment:
CODECEPT_ARGS=-c codecept.conf.js run
volumes:
/Users/bjulaganti/dev/RMS-CodeceptJS-Test-Suite:/tests
dns:
<IP_ADDRESS>
<IP_ADDRESS>
selenium-chrome:
image: selenium/standalone-chrome:3.5.3
volumes:
/dev/shm:/dev/shm
ports:
"4444"
'5900'

Here is the docker output screenshot

can you let me know what I am doing here wrong


Add "Write custom application logs" section.

@kaiyuezhou : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


[protobuf] Empty signature should behave the same as spreading Empty

The samples show that when you take no arguments, you spread the well-known empty type. I think this should be implicit when you provide no arguments, instead of the current behavior of creating an empty message type.

Is it safe to just check if the parameters model is empty? Can the parameters of an operation extend a model or be named?

It is not possible today. The oft-discussed syntax for just passing in the parameter model would make both of these a possibility but we can handle that when the time comes.


change prezto repo from zsh-users to sorin-ionescu

The previous repo of prezto has been alive, and the forked zsh-users repo was thus shuted down.

sorry, it's confusing to me but thank you for your contribution

It's a complicated story. See here


Checkpoint loader VS Load checkpoint (default) - an issue, maybe bug or data loss

I just noticed that upon loading checkpoint with these two loaders gives two different image results.
I used identical settings and generation data for the images, the only difference is that I loaded first checkpoint with Checkpoint loader from this project, and the second generation I used default ComfyUI loader Load Checkpoint.
I got deviations in image generation, even worse I noticed that default checkpoint had a bit less strange artefacts and/or deformations of prompts.
now I wonder why is it so?
I love Checkpoint loader with his functionality of drop down folder selection... but the image quality is still a key factor and default loader has the upper hand as of this moment, unfortunately

The checkpoint loader is exactly the same as the default ComfyUI one, just with a different selection, I don't have any model loading or generation code:
https://github.com/pythongosssss/ComfyUI-Custom-Scripts/blob/e597e7ef183ab8eb4ed0e062076ac6a48369c3d4/py/better_combos.py#L114
I think what you are seeing is something else unrelated to this.

Hmm, I see. Then the mystery deepens indeed but I don't see what else that could be. The only thing I changed in the workflow is the physical output of the loaders themselves and nothing more.
I will show you the example of the issue with these 2 pics, everything was the identical except as I described the loader used for  output.
I'm really don't not making thing up, trust me.