More descriptive: This contract does not implement all functions and thus cannot be created.

Error message:

This contract does not implement all functions and thus cannot be created.

At a minimum, it should give you the line number of one function that is not implemented.

Would be nice if automatically generated getters (e.g. of public state variables) in a contract implementing an interface, are recognised by that interface. Currently if the interface has:
function balance() external returns (address)
then a variable of:
address public balance
in the implementing contract still leads to this error.

duplicate of https://github.com/ethereum/remix-project/issues/138


[FEAT] Use this as default context

I take inspiration from https://emberobserver.com/addons/@ember-lux/id-helper.
I've created a small ast plugin that updates invocations of context-id helper.
If the helper is invocated without any parameters {{context-id}} the plugin will update the invocation and add this as parameter {{context-id this}}.
The plugin will do nothing if the helper already as a context provided, {{context something}} will not be modified.

I believe this will have a fairly significant failure mode when used in a template-only Glimmer component: this will always be null there.

Indeed! Thanks for pointing this @chriskrycho
I think this code should fix the problem
setupPreprocessorRegistry(type, registry) {
  if (type !== 'parent') {
    return;
  }
  let optionalFeatures = this.project.addons.find(a => a.name === '@ember/optional-features');
  if (optionalFeatures && optionalFeatures.isFeatureEnabled('template-only-glimmer-components') === false) {
    registry.add('htmlbars-ast-plugin', {
      name: 'inject-context',
      plugin: InjectContextTransform
    });
  }
}


feat: add immediate-drop recursion mode

This PR would add a new recursion mode called "immediate-drop"

"immediate-drop": Nested emission events immediately begin a deeper emission
loop, and the original emission loop is discontinued.  This can be useful
when callbacks update their own state in response to their own emissions,
and the original emission loop is no longer relevant.

The effect is best shown in the test_callback_order test:
    if recursion == "immediate":
        # nested emission events occur immediately,
        # before proceeding to the next callback
        assert a == [1, 2, 20, 3, 30, 300, 200, 10, 100]
    elif recursion == "immediate-drop":
        # nested emission events occur immediately,
        # before proceeding to the next callback
        # AND any remaining emissions in the current loop level are cancelled
        assert a == [1, 2, 20, 3, 30, 300]

@Czaki, I was thinking this might actually be the desired behavior for evented models, since it not only makes sure that the current value is always up to date, it also prevents emitting things that are just about to become irrelevant

side question:  Do you think you would probably use this mode over 'deferred'?

oh and also: do you like the name immediate-drop? or can you think of a better one?

side question: Do you think you would probably use this mode over 'deferred' for cases like EventedModel when the primary goal of the emitter is to emit the current value?

Yes. I think it will be better, as in most use cases I need to know only the last value.

oh and also: do you like the name immediate-drop? or can you think of a better one?

I do not have a better name, but I'm bad at naming. Maybe @jni could help.


[Question] How to render image with image picking from FilePicker()

Hi, I like the interactive features in PlutoUI.jl. I'm trying to render the image with FilePicker() but the data field is a vector so I don't know how to display the image.
How can I display image in this situation ?

Hey! Sorry for the late response, this will work:
# ╔═╡ d59d5f7c-887e-11ee-0fde-e1d5501026dd
using PlutoUI

# ╔═╡ 86b30519-56e1-483c-986d-f48508fb024b
@bind image_data FilePicker()

# ╔═╡ 51125f6a-48e2-4154-8d4a-271e808de083
image_data

# ╔═╡ 5f039984-2e73-40a4-9101-1c4ae16788c7
begin
	path = tempname() * image_data["name"]
	write(path, image_data["data"])
end

# ╔═╡ 1883ebae-9086-47ac-9dca-534010fc7885
LocalResource(path)


[Suggestion] Update the installation guide to pull ready-to-use config files in the version after 0.6.0

Note: This repository is ONLY used to solve issues related to DOCS.
For other issues, please move to other repositories.

Describe your suggestion
Update the installation guide to pull ready-to-use config files. Refer to https://github.com/milvus-io/milvus/issues/848 for more information.

We have one config file only and gpu is not enabled by default. We need to remind users to change gpu to enabled to use the GPU version.

Done.


Specified that the procedure must be in the dbo schema

Hello SQL Server Docs Team,
I was playing around with sp_procoption as for a blog post, and I've noticed that, if the stored procedure is in any other schema than dbo, sp_procoption errors out despite the procedure being in the master database.

Vlad

@markingmyname

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Got it, @rwestMSFT.
Does it help with anything if I leave the PR opened until the internal refresh or would it be better to close it?

Leave it open and let our automation handle it. I do a git fetch on your PR and work off that, so that you still get the credit for your commit.


[zh] fix debug-running-pod url

fix debug-running-pod url in page /zh/docs/tasks/debug-application-cluster/debug-application/

@chjtwork Pls sign the CLA in order for the PR to be reviewed.

I signed it

/lgtm
/approve
This is neat.


Failed to star FirstBoot

If it keeps failing, try running
journalctl -u firstboot.service

and it may give more details about why it failed
Originally posted by @CamDavidsonPilon in https://github.com/Pioreactor/pioreactorui/issues/86#issuecomment-1018660503
Journal file<EMAIL_ADDRESS>is truncated, ignoring file.
-- Journal begins at Sat 2021-10-30 08:29:41 -03, ends at Sat 2021-10-30 09:56:26 -03. --
Oct 30 08:30:03 pioreactor systemd[1]: Starting FirstBoot...
Oct 30 08:30:03 pioreactor firstboot.sh[446]: + set -e
Oct 30 08:30:03 pioreactor firstboot.sh[446]: + export LC_ALL=C
Oct 30 08:30:03 pioreactor firstboot.sh[446]: + LC_ALL=C
Oct 30 08:30:03 pioreactor firstboot.sh[446]: + PIO_DIR=/home/pi/.pioreactor
Oct 30 08:30:03 pioreactor firstboot.sh[446]: + sudo -u pi ssh-keygen -q -t rsa -N '' -f /home/pi/.ssh/id_rsa
Oct 30 08:30:06 pioreactor sudo[449]:     root : PWD=/ ; USER=pi ; COMMAND=/usr/bin/ssh-keygen -q -t rsa -N  -f /home/p>
Oct 30 08:30:06 pioreactor sudo[449]: pam_unix(sudo:session): session opened for user pi(uid=1000) by (uid=0)
Oct 30 08:30:18 pioreactor firstboot.sh[446]: + sudo -u pi cat /home/pi/.ssh/id_rsa.pub
Oct 30 08:30:18 pioreactor firstboot.sh[764]: ++ hostname
Oct 30 08:30:18 pioreactor firstboot.sh[446]: + sudo -u pi ssh-keyscan -H pioreactor
Oct 30 08:30:18 pioreactor sudo[765]:     root : PWD=/ ; USER=pi ; COMMAND=/usr/bin/ssh-keyscan -H pioreactor
Oct 30 08:30:18 pioreactor sudo[765]: pam_unix(sudo:session): session opened for user pi(uid=1000) by (uid=0)
Oct 30 08:30:19 pioreactor firstboot.sh[766]: write (pioreactor): Connection refused
Oct 30 08:30:19 pioreactor firstboot.sh[766]: write (pioreactor): Connection refused
Oct 30 08:30:19 pioreactor firstboot.sh[766]: write (pioreactor): Connection refused
Oct 30 08:30:19 pioreactor firstboot.sh[766]: write (pioreactor): Connection refused
Oct 30 08:30:19 pioreactor firstboot.sh[766]: write (pioreactor): Connection refused
Oct 30 08:30:19 pioreactor sudo[765]: pam_unix(sudo:session): session closed for user pi
Oct 30 08:30:20 pioreactor systemd[1]: firstboot.service: Main process exited, code=exited, status=1/FAILURE
Oct 30 08:30:20 pioreactor systemd[1]: firstboot.service: Failed with result 'exit-code'.
Oct 30 08:30:20 pioreactor systemd[1]: Failed to start FirstBoot.
Oct 30 08:30:20 pioreactor systemd[1]: firstboot.service: Consumed 11.494s CPU time.
-- Boot 536fc477a5414b0abb34557f68dc0968 --
Oct 30 09:17:06 pioreactor systemd[1]: Starting FirstBoot...
Oct 30 09:17:06 pioreactor firstboot.sh[423]: + set -e
Oct 30 09:17:06 pioreactor firstboot.sh[423]: + export LC_ALL=C
Oct 30 09:17:06 pioreactor firstboot.sh[423]: + LC_ALL=C
Oct 30 09:17:06 pioreactor firstboot.sh[423]: + PIO_DIR=/home/pi/.pioreactor
Oct 30 09:17:06 pioreactor firstboot.sh[423]: + sudo -u pi ssh-keygen -q -t rsa -N '' -f /home/pi/.ssh/id_rsa
Oct 30 09:17:06 pioreactor sudo[427]:     root : PWD=/ ; USER=pi ; COMMAND=/usr/bin/ssh-keygen -q -t rsa -N  -f /home/p>
Oct 30 09:17:06 pioreactor sudo[427]: pam_unix(sudo:session): session opened for user pi(uid=1000) by (uid=0)
Oct 30 09:17:12 pioreactor firstboot.sh[440]: /home/pi/.ssh/id_rsa already exists.
Oct 30 09:17:12 pioreactor firstboot.sh[440]: Overwrite (y/n)?
Oct 30 09:17:12 pioreactor systemd[1]: firstboot.service: Main process exited, code=exited, status=1/FAILURE
Oct 30 09:17:12 pioreactor systemd[1]: firstboot.service: Failed with result 'exit-code'.
Oct 30 09:17:12 pioreactor systemd[1]: Failed to start FirstBoot.
Oct 30 09:17:12 pioreactor systemd[1]: firstboot.service: Consumed 5.929s CPU time.
-- Boot a0330c8df3274bdd8404755ec35f4a17 --
Oct 30 09:36:11 pioreactor systemd[1]: Starting FirstBoot...
Oct 30 09:36:11 pioreactor firstboot.sh[416]: + set -e
Oct 30 09:36:11 pioreactor firstboot.sh[416]: + export LC_ALL=C
Oct 30 09:36:11 pioreactor firstboot.sh[416]: + LC_ALL=C
Oct 30 09:36:11 pioreactor firstboot.sh[416]: + PIO_DIR=/home/pi/.pioreactor
Oct 30 09:36:11 pioreactor firstboot.sh[416]: + sudo -u pi ssh-keygen -q -t rsa -N '' -f /home/pi/.ssh/id_rsa
Oct 30 09:36:11 pioreactor sudo[421]:     root : PWD=/ ; USER=pi ; COMMAND=/usr/bin/ssh-keygen -q -t rsa -N  -f /home/p>
Oct 30 09:36:11 pioreactor sudo[421]: pam_unix(sudo:session): session opened for user pi(uid=1000) by (uid=0)
Oct 30 09:36:32 pioreactor firstboot.sh[434]: /home/pi/.ssh/id_rsa already exists.
Oct 30 09:36:32 pioreactor sudo[421]: pam_unix(sudo:session): session closed for user pi
Oct 30 09:36:32 pioreactor firstboot.sh[434]: Overwrite (y/n)?
Oct 30 09:36:32 pioreactor systemd[1]: firstboot.service: Main process exited, code=exited, status=1/FAILURE
Oct 30 09:36:32 pioreactor systemd[1]: firstboot.service: Failed with result 'exit-code'.
Oct 30 09:36:32 pioreactor systemd[1]: Failed to start FirstBoot.
Oct 30 09:36:32 pioreactor systemd[1]: firstboot.service: Consumed 21.010s CPU time.
-- Boot 810c6a2f3e5c46bb82614297ce6ef768 --
Oct 30 09:49:59 pioreactor systemd[1]: Starting FirstBoot...
Oct 30 09:49:59 pioreactor firstboot.sh[423]: + set -e
Oct 30 09:49:59 pioreactor firstboot.sh[423]: + export LC_ALL=C
Oct 30 09:49:59 pioreactor firstboot.sh[423]: + LC_ALL=C
Oct 30 09:49:59 pioreactor firstboot.sh[423]: + PIO_DIR=/home/pi/.pioreactor
Oct 30 09:49:59 pioreactor firstboot.sh[423]: + sudo -u pi ssh-keygen -q -t rsa -N '' -f /home/pi/.ssh/id_rsa
Oct 30 09:49:59 pioreactor sudo[427]:     root : PWD=/ ; USER=pi ; COMMAND=/usr/bin/ssh-keygen -q -t rsa -N  -f /home/p>
Oct 30 09:49:59 pioreactor sudo[427]: pam_unix(sudo:session): session opened for user pi(uid=1000) by (uid=0)
Oct 30 09:50:03 pioreactor firstboot.sh[443]: /home/pi/.ssh/id_rsa already exists.
Oct 30 09:50:03 pioreactor firstboot.sh[443]: Overwrite (y/n)?
Oct 30 09:50:03 pioreactor systemd[1]: firstboot.service: Main process exited, code=exited, status=1/FAILURE
Oct 30 09:50:03 pioreactor sudo[427]: pam_unix(sudo:session): session closed for user pi
Oct 30 09:50:03 pioreactor systemd[1]: firstboot.service: Failed with result 'exit-code'.
Oct 30 09:50:03 pioreactor systemd[1]: Failed to start FirstBoot.
Oct 30 09:50:03 pioreactor systemd[1]: firstboot.service: Consumed 4.107s CPU time.

Great, this really helps.
While I get that sorted, you can run the rest of the commands here from the RPi's command line:
crudini --set $PIO_DIR/config.ini network.topology leader_hostname $(hostname)
crudini --set $PIO_DIR/config.ini network.topology leader_address $(hostname).local

mosquitto_pub -t "pioreactor/latest_experiment" -m "Demo experiment" -r

sudo systemctl restart avahi-alias.service

echo "0 0 */5 * * /usr/local/bin/pio run backup_database" | crontab -

I'll try to find a proper solution in the meantime

Some questions when you get a chance:

Are you on a university, work, or home network?
Does ssh-keyscan pioreactor give an error?
Does ssh-keyscan -4 pioreactor give an error?
Does ssh pioreactor give an error? (It may prompt you, select 'yes')

The UI may or may not be working 100%. If it's not working, try the following line:
sudo -u pi echo "StrictHostKeyChecking no" >> ~/.ssh/config

and try the UI again.

Some questions when you get a chance:
1. Are you on a university, work, or home network?

2. Does `ssh-keyscan pioreactor` give an error?

3. Does `ssh-keyscan -4 pioreactor` give an error?

4. Does `ssh pioreactor` give an error? (It may prompt you, select 'yes')

1: home
2: no
3: no
4: yes! (kind off)
got this on 4:
ssh pioreactor
The authenticity of host 'pioreactor (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:***************************************.
Are you sure you want to continue connecting (yes/no/[fingerprint])?

Also,

The UI may or may not be working 100%. If it's not working, try the following line:
sudo -u pi echo "StrictHostKeyChecking no" >> ~/.ssh/config

and try the UI again.

didn't fixed anything
But this did:

Great, this really helps.
While I get that sorted, you can run the rest of the commands here from the RPi's command line:
PIO_DIR=/home/pi/.pioreactor

crudini --set $PIO_DIR/config.ini network.topology leader_hostname $(hostname)
crudini --set $PIO_DIR/config.ini network.topology leader_address $(hostname).local

mosquitto_pub -t "pioreactor/latest_experiment" -m "Demo experiment" -r

sudo systemctl restart avahi-alias.service

echo "0 0 */5 * * /usr/local/bin/pio run backup_database" | crontab -

I'll try to find a proper solution in the meantime

Added more logging around this. It will be much more obvious if firstboot fails to run.


Use kubevirt.yaml

Since kubevirt v0.1.0 there is a manifest yaml part of the release which needs fewer hacks.
The playbook should use this.
https://github.com/kubevirt/kubevirt/releases/v0.1.0

We should actually support two flows:

The current repo based flow, which is pulling yamls from repo
The flow based on the release mnifest - linked in first comment


updated disk-drill to v2.4.437

Thank you for the contribution. It needed some fixes, so they were made in 77c293712c3f99061c1ed58f086fdef96f08e827. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Fiber.current isn't support in JRuby

If you run any tests using JRuby it fails on the Fiber.current calls, which don't appear to be in JRuby.

Okay isn't a bug, but might help someone out.
require 'fiber' in jruby 1.6.5 is broken. Need to go backward or forwards.


[SPARK-13860][SQL] Change CentralMomentAgg to return null instead of Double.NaN when divideByZero

What changes were proposed in this pull request?
As SPARK-13860 stated, TPCDS Query 39 returns wrong results using SparkSQL. The root cause is that when stddev_samp is applied to a single element set, with TPCDS answer, it return null; as in SparkSQL, it return Double.NaN which caused the wrong result.
Add an extra legacy config to fallback into the NaN logical, and return null by default to align with TPCDS standard.
Why are the changes needed?
SQL correctness issue.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Updated DataFrameAggregateSuite/WindowQuerySuite to test both default and legacy behavior.

Test build #129579 has started for PR 29983 at commit 1e7894d.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34184/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34184/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34184/
Test PASSed.

Test build #129579 has finished for PR 29983 at commit 1e7894d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129579/
Test FAILed.

Thank you for your contribution, @leanken .
BTW, could you check the UT failure? It looks like relevant.
org.apache.spark.sql.hive.execution.WindowQuerySuite.windowing.q -- 15. testExpressions

cc @maropu

Thanks for cc, @dongjoon-hyun !

Really, we need to return 0.0 in the case? Looks PostgreSQL/MySQL returns null instead;
mysql> create table t (v float8);
mysql> insert into t values (1.0);
mysql> SELECT stddev_samp(v) FROM t;
+----------------+
| stddev_samp(v) |
+----------------+
|           NULL |
+----------------+
1 row in set (0.00 sec)

postgres=# create table t (v float8);
postgres=# insert into t values (1.0);
INSERT 0 1
postgres=# \pset null 'null'
Null display is "null".
postgres=# SELECT stddev_samp(v) FROM t;
 stddev_samp
-------------
        null
(1 row)

Thank you for your contribution, @leanken .
BTW, could you check the UT failure? It looks like relevant.
org.apache.spark.sql.hive.execution.WindowQuerySuite.windowing.q -- 15. testExpressions

sure

Really, we need to return 0.0 in the case? Looks PostgreSQL/MySQL returns null instead;
mysql> create table t (v float8);
mysql> insert into t values (1.0);
mysql> SELECT stddev_samp(v) FROM t;
+----------------+
| stddev_samp(v) |
+----------------+
|           NULL |
+----------------+
1 row in set (0.00 sec)

postgres=# create table t (v float8);
postgres=# insert into t values (1.0);
INSERT 0 1
postgres=# \pset null 'null'
Null display is "null".
postgres=# SELECT stddev_samp(v) FROM t;
 stddev_samp
-------------
        null
(1 row)

let me find more doc and see if returning null meet the TPCDS answer Q39. reply you later.

Test build #129610 has started for PR 29983 at commit a853132.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34213/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34213/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34213/
Test FAILed.

Test build #129610 has finished for PR 29983 at commit a853132.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129610/
Test FAILed.

Test build #129622 has started for PR 29983 at commit 370cad1.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34226/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34226/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34226/
Test PASSed.

Test build #129622 has finished for PR 29983 at commit 370cad1.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129622/
Test FAILed.

Test build #129635 has started for PR 29983 at commit a7a6eac.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34239/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34239/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34239/
Test PASSed.

Test build #129635 has finished for PR 29983 at commit a7a6eac.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129635/
Test FAILed.

Test build #129651 has started for PR 29983 at commit 656a0ff.

@cloud-fan

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34255/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34255/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34255/
Test PASSed.

Test build #129658 has started for PR 29983 at commit 7292500.

Seems plausible to me.

case class CovSample(left: Expression, right: Expression) extends Covariance(left, right) {
  override val evaluateExpression: Expression = {
    If(n === 0.0, Literal.create(null, DoubleType),
      If(n === 1.0, Double.NaN, ck / (n - 1.0)))
  }

case class Corr(x: Expression, y: Expression)
  extends PearsonCorrelation(x, y) {

  override val evaluateExpression: Expression = {
    If(n === 0.0, Literal.create(null, DoubleType),
      If(n === 1.0, Double.NaN, ck / sqrt(xMk * yMk)))
  }

found two more place return Double.NaN with DivideByZero case. should I update these as well??

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34262/

found two more place return Double.NaN with DivideByZero case. should I update these as well??
and change ConfigName to spark.sql.legacy.divideByZeroEvaluation ??

Or, spark.sql.legacy.centralMomentAndCovarianceAgg?

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34262/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34262/
Test FAILed.

Seems plausible to me.

case class CovSample(left: Expression, right: Expression) extends Covariance(left, right) {
  override val evaluateExpression: Expression = {
    If(n === 0.0, Literal.create(null, DoubleType),
      If(n === 1.0, Double.NaN, ck / (n - 1.0)))
  }

case class Corr(x: Expression, y: Expression)
  extends PearsonCorrelation(x, y) {

  override val evaluateExpression: Expression = {
    If(n === 0.0, Literal.create(null, DoubleType),
      If(n === 1.0, Double.NaN, ck / sqrt(xMk * yMk)))
  }

found two more place return Double.NaN with DivideByZero case. should I update these as well??
and change ConfigName to spark.sql.legacy.divideByZeroEvaluation ??

@cloud-fan how about CovSample and Corr ?? should I update them as well in these patch?

Test build #129668 has started for PR 29983 at commit 16bc5d5.

found two more place return Double.NaN with DivideByZero case. should I update these as well??
and change ConfigName to spark.sql.legacy.divideByZeroEvaluation ??

Or, spark.sql.legacy.centralMomentAndCovarianceAgg?

change into spark.sql.legacy.statisticalAggregate

Test build #129658 has finished for PR 29983 at commit 7292500.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #129651 has finished for PR 29983 at commit 656a0ff.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #129668 has finished for PR 29983 at commit 16bc5d5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129668/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129651/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129658/
Test FAILed.

retest this please

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34272/

Test build #129674 has started for PR 29983 at commit 5095df4.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34272/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34272/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34278/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34278/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34278/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34279/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34279/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34279/
Test PASSed.

Test build #129674 has finished for PR 29983 at commit 5095df4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129674/
Test FAILed.

Test build #129681 has started for PR 29983 at commit e0769ca.

Test build #129674 has finished for PR 29983 at commit 5095df4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

need to update golden-file for corr and covar_samp behavior update.

Test build #129684 has started for PR 29983 at commit 811d248.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34287/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34287/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34287/
Test PASSed.

Test build #129681 has finished for PR 29983 at commit e0769ca.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class CentralMomentAgg(child: Expression, nullOnDivideByZero: Boolean)
case class StddevPop(
case class StddevSamp(
case class VariancePop(
case class VarianceSamp(
case class Skewness(
case class Kurtosis(
abstract class PearsonCorrelation(x: Expression, y: Expression, nullOnDivideByZero: Boolean)
case class Corr(
abstract class Covariance(x: Expression, y: Expression, nullOnDivideByZero: Boolean)
case class CovPopulation(
case class CovSample(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129681/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34290/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34290/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34290/
Test PASSed.

Test build #129689 has started for PR 29983 at commit c4ad6de.

Test build #129684 has finished for PR 29983 at commit 811d248.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129684/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34295/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34295/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34295/
Test PASSed.

Test build #129689 has finished for PR 29983 at commit c4ad6de.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129689/
Test FAILed.

Test build #129696 has started for PR 29983 at commit dc8efb6.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34302/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34302/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34302/
Test PASSed.

Test build #129697 has started for PR 29983 at commit 6eee3c9.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34303/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34303/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34303/
Test PASSed.

Test build #129696 has finished for PR 29983 at commit dc8efb6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129696/
Test FAILed.

Test build #129697 has finished for PR 29983 at commit 6eee3c9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129697/
Test PASSed.

Test build #129717 has started for PR 29983 at commit 084c3fb.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34323/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34323/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34323/
Test PASSed.

Test build #129717 has finished for PR 29983 at commit 084c3fb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129717/
Test PASSed.

@cloud-fan if no further comment, test was passed, ready to merge.

Test build #129734 has started for PR 29983 at commit ddc522c.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34340/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34340/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34340/
Test PASSed.

Test build #129734 has finished for PR 29983 at commit ddc522c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129734/
Test PASSed.

thanks, merging to master!


Setup an extensible framework for context highlighting

Setup an extensible framework for context highlighting

in place with 5e7f75dc677c34baae2bdb210a467fe1e167a423
still needs more work on it


MTL-1832

Description

MTL-1832
https://jira-pro.it.hpe.com:8443/browse/MTL-1832

Relates to:

https://github.com/Cray-HPE/cray-site-init/pull/423

https://github.com/Cray-HPE/node-images/pull/1157

[x] If I added any command snippets, the steps they belong to follow the prompt conventions (see [example][1])

[x] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in [Cray-HPE][2]

[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA

We should make a JIRA, one for each of these future TODOs:

Adding a flag to csi that can dump the meta-data and user-data for nodes so we can remove the duplication between this and https://github.com/Cray-HPE/cray-site-init/blob/bc2a8d569fd2a0c2a495c1f82e5f01c2ea9ea53e/pkg/cli/config/initialize/disks.go
A dependent JIRA for removing this in 1.6.1/1.7.0

The above suggestions / changes were added to cray-site-init here: https://github.com/Cray-HPE/cray-site-init/pull/426


throws-like does not work correctly a string for the exception name

The problem
Documentation is incorrect for throws-like.  If the eval code throws an exception, a string containing the name of that exception will not match.  Example:
raku -MTest -e "throws-like 'Exception.new.throw', 'Exception'"

This outputs:
# Subtest: did we throws-like Str?
    1..2
    ok 1 - 'Exception.new.throw' died
    not ok 2 - right exception type (Str)
    # Failed test 'right exception type (Str)'
    # at SETTING::src/core.c/Exception.pm6 line 64
Stub code executed
  in block  at /home/jmaslak/.rakubrew/versions/moar-2022.12/install/share/perl6/core/sources/60CBD62BA814F88B5840C355CCC73B21A03D70B9 (Test) line 658
  in any  at /home/jmaslak/.rakubrew/versions/moar-2022.12/install/share/perl6/core/sources/60CBD62BA814F88B5840C355CCC73B21A03D70B9 (Test) line 642
  in block <unit> at EVAL_0 line 1
  in block  at /home/jmaslak/.rakubrew/versions/moar-2022.12/install/share/perl6/core/sources/60CBD62BA814F88B5840C355CCC73B21A03D70B9 (Test) line 638
  in sub subtest at /home/jmaslak/.rakubrew/versions/moar-2022.12/install/share/perl6/core/sources/60CBD62BA814F88B5840C355CCC73B21A03D70B9 (Test) line 437
  in sub throws-like at /home/jmaslak/.rakubrew/versions/moar-2022.12/install/share/perl6/core/sources/60CBD62BA814F88B5840C355CCC73B21A03D70B9 (Test) line 630
  in block <unit> at -e line 1

However, the following works as expected:
raku -MTest -e "throws-like 'Exception.new.throw', Exception"

Solution provided
Solution is to remove the note that exception types can be specified by strings containing the exception name.

You are right, apparently this never worked (not since Christmas at the very least) the way the docs suggest, so probably the documentation is "more wrong" than the module itself.

Thanks!


Remove import dart:core

Since dart:core is automatically imported, I wonder why the import is used in the sdk code.

https://dart-review.googlesource.com/c/sdk/+/212298


Cleaning up some unused files, and consolidate PATH

In order to access the CRC provided oc and related tools, we have to
ensure ansible tasks know about the specific location.
We now expose a new cacheable fact that may be overridden by the
operator. We'll then be able to set the task or playbook environment
PATH value to that new fact in order to gain access to otherwise unknown
commands.
This patch also takes the opportunity to clean some unused files in the
operator_build role, and converts a shell call to command.
This PR has:

[X] Appropriate testing (molecule, python unit tests)
[X] Appropriate documentation (README in the role, main README is up-to-date)

recheck

/lgtm
thanks for that, I was missing it yesterday :)


Unknown state for pull request: 'behind'

Hi! I've been using this action for a while and it's been pretty helpful with my protected branches.
It appears that the action doesn't seem to recognize the state 'behind' which means that the pull request is not up to date with the target branch. Here's an example of the error: https://github.com/ZPTXDev/Quaver/actions/runs/2701520700
Is this intended?

Hi @zapteryx, no this is not intended.
Do you have the “Always suggest updating pull request branches” enabled on this repo? I assume this state was added when this feature was introduced.
Should be easy to just add this to https://github.com/reitermarkus/automerge/blob/787b521aaca9ba47b0d8132320958c06da33ad29/src/automerge-action.ts#L155-L160.

I have this branch protection rule:

I don't have that feature enabled though:

Thanks @zapteryx, I was able to reproduce the state. After adding it to the list it is working now:
https://github.com/reitermarkus/automerge/runs/7577285036?check_suite_focus=true#step:4:405

Fixed in v2.1.1.


Missing LICENSE.md

Hi @DRosemei,
thanks for sharing your work! I noticed that the LICENSE.md file is missing from the repository. Would it be possible for you to include such a file with a free-software license such as MIT?

@christianll9 Thanks for pointing it out and we have added MIT license here.


UG Update: Move “Deleting notes”, “Updating client notes” and “Filtering by country” sections

Fixes #25

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #62   +/-   ##
=========================================
  Coverage     72.31%   72.31%
  Complexity      400      400
=========================================
  Files            70       70
  Lines          1228     1228
  Branches        124      124
=========================================
  Hits            888      888
  Misses          308      308
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 140b8d6...aac559d. Read the comment docs.


vxworks osfileapi.c functions not using semaphore

Multiple functions in the VxWorks osfileapi.c are not taking the semaphore when accessing the shared table.
OS_close, OS_read, OS_write, OS_lseek, OS_remove, OS_rename, OS_cp, OS_mv, OS_ShellOutputToFile, OS_FDGetInfo.
Identified with #22 white-box coverage testing.

Imported from trac issue 83.  Created by abrown4 on 2015-07-17T14:18:52, last modified: 2015-12-01T14:19:51

Trac comment by abrown4 on 2015-07-28 15:34:49:
Investigation:
These functions do take a mutex for the shared OS_FDTable: OS_creat, OS_open, OS_close, OS_FileOpenCheck, OS_CloseFileByName, OS_CloseAllFiles.
These functions do not use a mutex for the shared OS_FDTable, but they DO alter that table's contents: OS_remove, OS_rename, OS_cp, OS_mv.
These functions do not use a mutex for the shared OS_FDTable, but merely access/read the table elements: OS_read, OS_write, OS_lseek, OS_ShellOutputToFile, OS_FDGetInfo.  Given the decision on #80, these functions that only use the table entries will not be altered.
These functions do not touch the shared OS_FDTable at all: **OS_chmod, OS_stat, OS_mkdir, OS_opendir, OS_closedir, OS_readdir, OS_rewinddir, OS_rmdir, OS_check_name_length. **  These will not be altered (obviously).

Trac comment by abrown4 on 2015-07-28 15:48:29:
Noted: OS_open and OS_creat give up the table mutex around the open().  OS_close takes the mutex after the close().  A good (safe) approach.
But OS_CloseFileByName and OS_CloseAllFiles peform the close() inside the mutex lock, unlike OS_close.  This is a difference in design & implementation - will change to match the (safer) OS_close.
OS_remove simply needs to check if the file is already not in the table, so no changes required.  Same with OS_cp & OS_mv.
OS_rename alters the shared table entry's path without locking and after the rename() is called.  There is no check for if the file is in use, like in OS_cp, OS_mv, or OS_remove.

Trac comment by abrown4 on 2015-07-28 16:48:56:
commit: [changeset:76b7d35]  Trac #83, Fixed some osfileapi.c global table accesses.
OS_CloseFileByName() and OS_CloseAllFiles() peform the syscall close()
inside the mutex lock.  Changed to be like OS_close(), where close() is
called outside the lock.

Trac comment by abrown4 on 2015-08-20 18:46:24:
From the above commits, as of #22 [changeset:6a9db70], the white-box unit test still shows that many functions don't safely access the OS_FDTable (31 test failures from osfile_wb test).

Trac comment by abrown4 on 2015-07-28 17:00:14:
Opened #93 for the OS_rename behavior.
No other changes expected on this issue (before review & discussion).

Trac comment by abrown4 on 2015-11-25 16:10:57:
Traceability: The above [changeset:76b7d35] is reflected in #115 [changeset:ab2d6d7].  Recommend closing this issue in favor of #115 for these improvements to be merged.
However, osfilesys.c is one of the most thread-unsafe parts of OSAL so recommend the CCB discuss paths forward with this issue providing a reference.


swipe-to-select doesn't work

Expected behavior
Swiping on a message in message-list view should select it with visible highlight and entering "select mode".
Actual behavior
Nothing happens.
Steps to reproduce

Try to select a message with swipe

Environment
K-9 Mail version: debug build of master branch: 3e1a8da32a7e2bbb55441acf6e5de26e707ac878
Android version: 9.0
Logs don't show anything, but I bisected the problem wit git-bisect and first bad commit is:
4fe8c417adb6037845232d026c863b12a733dc11 so this is probably conflict with navigation drawer which also listens for swipe movement.
bisect-log-swipe_to_select.txt

Hello @mruwek could I work on this bug?

Production from playstore works for me. Nokia 8, Android 9

Same issue after updating to latest beta today. Now I realise how important such basic functionality is in my workflow :)

Could stress that enough and now with the public release of 5.700 I got struck by this too and it drives me nuts. I really hope it doesn't take weeks or months to get this fixed in public version


Fixed documentation issue.

Changed renderAsDropdown for renderAsMultiple(). Fixes #49.

Hi @vaughany
Thank you for contribution.


ui: Update raw crossed-out-pencil to match output

I noticed while working on #1134 that icon-pencil-crossed-out.gts was changing when I ran pnpm rebuild:icons because the generated component had been updated but the raw SVG had not.
Is there a way we can protect against this, maybe a lint-esque CI task that checks whether running pnpm rebuild:icons results in any changes? 🤔

Your idea sounds like a good one. We could make it part of the boxel-ui workflow. i.e. only needs to run when something in boxel-ui has changed

Your idea sounds like a good one. We could make it part of the boxel-ui workflow. i.e. only needs to run when something in boxel-ui has changed

👍🏻 I’ve gotten started on that in #1136, will incorporate the check for changes, thanks.


Anyway to set DrawOrder?

DrawableGameComponent has DrawOrder, which let's you define the order inwhich the derived classes will be draw by the specified spritebatch.
How would i make the UserInterface.Active be rendered last?
I have a problem inwhich it's behin everything else.

You can try using this:
https://github.com/RonenNess/GeonBit.UI/blob/master/GeonBit.UI/Source/Entities/Entity.cs#L167
However its not yet in released version so you'll have to build yourself or wait for next release.
Hope that helps, if not please reopen issue :)
Thanks!

@RonenNess Nevermind, i had a weird issue when i inherited Label and passed "Nothing" into the mybase initiator, it crashed without given me a clear error.
"Exception thrown: 'System.NullReferenceException' in GeonBit.UI.dll"
but when i used "String.Empty" it worked without any problems.
It complained at the Userinterface but not at the initiator for the Label clone.
I thought it all was result of how the render ordering went but that wasn't the case.


Fix proptypes validation across the app

fix #279
I removed the required option because the proptypes were checked before receiving the props. Yes that' super weird, I don't know why.

LGTM. Good stuff.


Update collection ext

Updated collection extension to use a prefix in the field names it adds. Also adds a field so now there is:
cx:id
cx:name
cx:description
cc @cholmes @mojodna

Oh, the other thing that would be really nice to have, though I'm not exactly sure how to make it, is a json schema validator. Like ideally the main validator would have a way to 'add on' an extension's json, so you could have it check your cx: or eo: fields too. But definitely not required to get this PR in.

I realized somewhat belatedly that there's no reason it needs to be a 2-letter prefix. c: would work just as well and be slightly less baroque.


warnings when compiling against the latest nightly 1.85.0

Describe the bug
there are warnings when compiling with the latest rust nightly version 1.85.0:
warning: unexpected `cfg` condition name: `frb_expand`
 --> rust_lib/src/api/commons/commons_di.rs:4:1
  |
4 | #[frb(opaque)]
  | ^^^^^^^^^^^^^^
  |
  = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `fmt_debug`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows`
  = help: consider using a Cargo feature instead
  = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
           [lints.rust]
           unexpected_cfgs = { level = "warn", check-cfg = ['cfg(frb_expand)'] }
  = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(frb_expand)");` to the top of the `build.rs`
  = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
  = note: `#[warn(unexpected_cfgs)]` on by default
  = note: this warning originates in the attribute macro `frb` (in Nightly builds, run with -Z macro-backtrace for more info)

Steps to reproduce
Hint: A simple way to reproduce is to clone and modify the https://github.com/fzyzcjy/flutter_rust_bridge/tree/master/frb_example/dart_minimal example package according to your needs.

...
...
...

Logs
warning: unexpected `cfg` condition name: `frb_expand`
 --> rust_lib/src/api/commons/commons_di.rs:4:1
  |
4 | #[frb(opaque)]
  | ^^^^^^^^^^^^^^
  |
  = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `fmt_debug`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows`
  = help: consider using a Cargo feature instead
  = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
           [lints.rust]
           unexpected_cfgs = { level = "warn", check-cfg = ['cfg(frb_expand)'] }
  = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(frb_expand)");` to the top of the `build.rs`
  = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
  = note: `#[warn(unexpected_cfgs)]` on by default
  = note: this warning originates in the attribute macro `frb` (in Nightly builds, run with -Z macro-backtrace for more info)

### Expected behavior

_No response_

### Generated binding code

_No response_

### OS

_No response_

### Version of `flutter_rust_bridge_codegen`

_No response_

### Flutter info

_No response_

### Version of `clang++`

_No response_

### Additional context

_No response_

just normal frb structure :
#[frb(opaque)]
pub struct FrbCommonsDI(Arc<crate::commons::commons_di::CommonsDI>);

my workaround was to add the below to my Cargo.toml
[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(frb_expand)'] }

but the correct solution, i think, is to add "frb_expand" to the list of features of frb_rust.

but the correct solution, i think, is to add "frb_expand" to the list of features of frb_rust.

Looks reasonable and feel free to PR for this! (since this does not look to be super hard)

but the correct solution, i think, is to add "frb_expand" to the list of features of frb_rust.

Looks reasonable and feel free to PR for this! (since this does not look to be super hard)

I tried, but it appears to be more complicated than this

Then I will take a look at the next batch (may not be very fast since this is a linter warning instead of a real bug or error)


Return peer count

Motivation
Implements the endpoint to get the peer count which was not implemented before
Closes #3857
Steps to test or reproduce
curl localhost:9596/eth/v1/node/peer_count should not return just 0 for all values

Trying the same endpoint on lighthouse after running for about 5 minutes returns count for both connected and disconnected, while for lodestar, the endpoint only returns count for connected and nothing for disconnected or the other status. Still need to see if the current way is the most accurate way of getting the connection info from libp2p.

Trying the same endpoint on lighthouse after running for about 5 minutes returns count for both connected and disconnected, while for lodestar, the endpoint only returns count for connected and nothing for disconnected or the other status. Still need to see if the current way is the most accurate way of getting the connection info from libp2p.

Looked into trying to get disconnected peer by making a diff with the peers found in the peerstore and the one returned by the connection manager (reasoning is if it is found in the peerstore but not in the connection manager, then those are disconnected). The issue with that is the peerstore persists across restarts, meaning the result of the diff would keep on increasing.
Leaving the implementation for now to use the connection manager for all the counting. Open to other suggestions, if that is not fit enough


Linking recovery services vault to configuration profile

Is it possible to link an existing recovery services vault and backup profile to a configuration profile? Similar to how you would link an existing LA workspace?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 36e91b66-2b15-07ec-9e94-388e7355c3eb
Version Independent ID: 2e540fb7-028e-acaf-4f56-3997e21d3d8c
Content: Create a custom profile in Azure Automanage for VMs
Content Source: articles/automanage/virtual-machines-custom-profile.md
Service: automanage
GitHub Login: @ju-shim
Microsoft Alias: jushiman

@georgeollis
Thanks for your feedback! We will investigate and update as appropriate.

@georgeollis We haven't heard back from you. Appreciate if you could provide more details about your scenario.


Not compatible with webpack v5

Looks like a problem with deprecated hooks
[webpack-cli] Uncaught exception: Error: NormalModuleFactory.afterResolve is no longer a waterfall hook, but a bailing hook instead. Do not return the passed object, but modify it instead. Returning false will ignore the request and results in no module created.
[webpack-cli] Error: NormalModuleFactory.afterResolve is no longer a waterfall hook, but a bailing hook instead. Do not return the passed object, but modify it instead. Returning false will ignore the request and results in no module created.
    at /app/node_modules/webpack/lib/NormalModuleFactory.js:251:14
    at Hook.eval [as callAsync] (eval at create (/app/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/app/node_modules/webpack/node_modules/tapable/lib/Hook.js:18:14)
    at /app/node_modules/webpack/lib/NormalModuleFactory.js:247:30
    at eval (eval at create (/app/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
    at /app/node_modules/webpack/lib/NormalModuleFactory.js:481:7
    at /app/node_modules/webpack/lib/NormalModuleFactory.js:116:11
    at /app/node_modules/webpack/lib/NormalModuleFactory.js:513:8
    at NormalModuleFactory.resolveRequestArray (/app/node_modules/webpack/lib/NormalModuleFactory.js:734:34)
    at /app/node_modules/webpack/lib/NormalModuleFactory.js:505:11

No, please read the error message, maybe some plugin(s) use old API, you need to open an issue in plugin, but you don't provide more information, so I can'y help, sorry
If you want to found the problem please create reproducible test repo, stack trace don't help


Path / reference problem with equal types

Type of Issue
[ X] Bug Report
[ ] Feature Request

Description
When using two the same type(s) in different namespaces the resolving of the path is not correct.
To see te example I have made a repo so you can look at the code: example repo
The types are present in  addAdministrationItemCommand.ts and changeAdministrationItemCommand.ts
The problem can bee seen here
How To Reproduce

Clone the repo
Run npm run build

Expected Behaviour
A bug: please describe what behaviour or result you expected
A feature: do you have a first draft or an idea how to implement?
Version Information
$ node_modules/.bin/ng-packagr --version

ng-packagr:            2.4.5
@angular/compiler:     5.2.11
@angular/compiler-cli: 5.2.11
rollup:                0.55.5
tsickle:               0.27.5
typescript:            2.9.2

Hi, I have looked into this, and it seems that the bug is from TypeScript.
I have cloned your repo created a tsconfig.json
{
  "compilerOptions": {
    "baseUrl": "",
    "target": "es2015",
    "module": "es2015",
    "moduleResolution": "node",
    "outDir": "out-tmp",
    "declaration": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "lib": ["dom", "es2015"]
  },
  "files": ["index.ts"]
}

and ran
node_modules/.bin/tsc

And it still produced the same result.

Okay, thanks for the effort I will create a issue at typescript.


out variable seems supporting using var

You may want to specify the type of the out variable for clarity, as shown above. However, the language does support using an implicitly typed local variable:
if (int.TryParse(input, out var answer))
    WriteLine(answer);
else
    WriteLine("Could not parse input");

This example works fine for me.
Besides, Console.WriteLine would be better, or it needs to mention about using static

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc229b53-a548-4ef8-86b9-58670a81344a
Version Independent ID: aeb15230-e1cc-df50-7edb-fb50164e13be
Content: What's New in C# 7.0 - C# Guide
Content Source: docs/csharp/whats-new/csharp-7.md
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

@imba-tjd The article does say that using a var declaration works. This is one instance where it can be hard to determine the variable type, so an explicit declaration is a style consideration.
I did update the WriteLine statements to use the class name.

Oh, I read it wrong:joy:. I mistakenly thought it said does not...


feat: Allow scaling using redis stream length (#4277)

Make the redis stream scaler optionally dependent on the XLEN parameter
Checklist

[x] When introducing a new scaler, I agree with the scaling governance policy
[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements
[x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[x] A PR is opened to update the documentation on (repo) (if applicable)
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4277

Relates to #
https://github.com/kedacore/test-tools/pull/117
https://github.com/kedacore/keda-docs/pull/1094

/run-e2e redis*

Hey @JorTurFer , is there anything else I can do to help introduce that feature?

/run-e2e redis*

Hey @JorTurFer , is there anything else I can do to help introduce that feature?

I think that only the conflict is changelog is left here

/run-e2e redis*


[Bug] [seatunnel-spark-starter] SparkCommandArgs Will split the variable value with comma

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

I have a dynamic concatenated SQL，and one of the variables contains more than one comma。

I pass the value of the variable through -i. for example:
my sql as shown below:
sql="select " ${columns} " from table"
and my start command as shown below:
./bin/start-seatunnel-spark.sh \
--master local[4] \
--deploy-mode client \
--config ./config/my.conf
-i columns=id,name.age

the variable columns has been splitted as shown below:
-Dcolumns=id -Dname -Dage

SeaTunnel Version
2.1.1
SeaTunnel Config
...
transform {
  sql {
    sql="select " ${columns} " from table"
  }
}
...

Running Command
./bin/start-seatunnel-spark.sh \
--master local[4] \
--deploy-mode client \
--config ./config/my.conf
-i columns=id,name.age

Error Exception
the variable `columns` has been splitted as shown below:
-Dcolumns=id -Dname -Dage

Flink or Spark Version
Spark 2.4.0
Java or Scala Version
No response
Screenshots
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I submitted PR for this issue. Please see #2523


Parameter callback corrections

We currently use the add_on_set_parameter_callback API to create a parameter callback to update the values stored in the param_manager  when ROS2 parameters are changed.
However, according to the ROS2 docs regarding parameter changes, it seems that a on_parameter_event callback would be better. This is because our callbacks definitely have side effects, and therefore run the risk of desyncing the internal stored parameters with the ROS2 parameters. This would happen if a callback rejected the update.
I think our code works as intended now because we usually only change one parameter at a time (since launch files don't trigger the callback created with the add_on_set_parameters call). Furthermore, our code only rejects changes when a parameter doesn't exist. We also don't currently chain callbacks, so there is no risk of a future parameter callback called down the line rejecting the parameter change already accepted by the callback up the line.
Despite this, however, it would probably be better to implement the on_set_parameter callback to avoid potential issues.
@iandareid @bsutherland333 Is this how you understand the ROS2 documentation about parameter callbacks as well?

This is how my reading of it went, please let me know if you feel differently.
I think we are setting the parameters correctly, what I think the on_parameter_event does is allows us to change things like a timer or controller or something else, based on the parameter's success or failure.
I think that the syncing becomes a problem when that parameter does more than just change a value used in a calculation. For example, when we have to reset the timer if the frequency parameter changes, we create a new timer object. If that was not in the add_on_set_parameters callback, we could reset the timer even if the parameter was rejected. In our case I do not think this would be catastrophic, but if we had a parameter that would switch the control type to total_energy and also updated the timer in the same call, but the switch to total_energy was rejected for some reason then the timer would be changed but that would be out of sync with the actual total_energy parameter that would still be in its original configuration.
That was my understanding. I think that if the params make changes to the class then we should consider how to use the add_on_set_parameters, but as we have been using it I think it is correct.
Let me know what you think.

Essentially I think we only need to be concerned if we have conditional parameter changes, change parameter y if parameter x is changed.

Here are some examples of the 3 different types of parameter callbacks.
https://github.com/ros2/demos/blob/jazzy/demo_nodes_cpp/src/parameters/set_parameters_callback.cpp


Add timestamp to scope_info and target_info GMP metrics

Fixes https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/issues/584

I think it is reasonable to fix it this way for now, and we should try to make sure we get this fixed upstream ASAP, since it produces errors when using the GMP exporter.  We should make an issue to track a solution to the problems this creates below:
It is possible that the collector will be exporting a batch of metrics that are old (e.g. if metrics have been persisted to disk for an hour from on-prem before sending if there was a network outage).  In that case, the timestamp of the target_info metric would be now() but the timestamp on the metrics would be an hour ago, which is odd.  It could also cause the timestamps of multiple batches to be very close together if, for example, i'm backfilling historical data sequentially.  In that case, the timestamps of my regular metrics would be far apart (because they were collected at regular intervals), but if they are uploaded quickly, I would get a bunch of target_info and scope_info metrics that are really close together in time, and could cause write errors.
The solution adopted by the PRW exporter is to use the most recent timestamp in the metrics contained within the resource/scope.

@dashpole no I agree doing it right makes sense now. should we revert the broken release or just publish the new one asap?

feel free to merge with coverage checks failing.


Hunger damage issues

Description

There's no feedback that the person is dying of starvation, cold damage make it seem like they are freezing to death
Hunger damage kills people going afk, you want your character to be sleeping for a while in the round? Well they starved to death on their sleep
This doesn't fix any kitchen issues or people consuming junk food
Reproduction

Screenshots

Additional context

Hunger damage has been removed in #24790


Support a variable number of rows

Presently the card supports three energy inputs, but I was wondering if it's possible to allow a variable number of them, so you could have one or ten.
I'd anticipate that the changes would be to make the EnergyOverviewConfig type have an array of entity fields:
export interface EnergyOverviewConfig {
  type: string;

  entities: {
    current: string;
    power_factor: string;
    voltage: string;
    power: string;
  }[];
}

And then card render method would iterate over the config.entities array to read each entity set to build up the existing data array (there'd probably have to be something else done to make the colour of each row support more).

@aaronpowell thank you for your suggestion! I've been actively working on changing this for the next version.

@aaronpowell the change has been implemented in the newest release 2.0.0


assertDoesNotCompile does not detect missing implementation neither illegal overloading

None of these test cases should succeed, but:

Missing implementation: Succeeds
assertDoesNotCompile("""
  trait X { def x: Int }
  object Y extends X
""")

Return type overloading: Succeeds
assertDoesNotCompile("""
  trait X { def x: Int }
  object Y extends X { def x: Boolean = true }
""")

Although, ambiguous Return type overloading/Implementation with wrong type: Fails
assertDoesNotCompile("""
  trait X { def x: Int }
  object Y extends X { def x = true }
""")

@gabriel-bezerra Unfortunately typeCheck in the macro context is not catching that, we have an experimental branch that invoke the compiler directly here:
https://github.com/cheeseng/scalatest/tree/3.0-call-compiler-directly
It fixed the problem that you described, but it has different behavior than the macro typeCheck based approach, which allows the following to work:
val a = 1
assertCompile("val b = a + 1")

but in the new approach, it needs to be:
assertCompile(
  """val a = 1
     |val b = a + 1""".stripMargin
)

Thus we're thinking perhaps we should change that only in 3.1, not 3.0, your input will be highly appreciated too.

Hi @cheeseng, thanks for working on it.
It is OK to have more code within the assertion.
I see you fixed it by running an interpreter in the macro. I ended up writing an internal implementation at work that would run scalac within the macro and compile code snippets it to virtual files. It has a limitation that the code snippet has to be self contained as a whole file and can't depend on code surrounding the tests. On the other hand, it runs all the compiler phases. I don't know how to compare with your approach in terms of checking if the code compiles or not, and about usability.
One point I find to be bad in my implementation is the long compilation time of the tests. In case I get  back to it, I'll probably try to run scalac during the test run-time and have the macro just writing the library call and dumping the compiler configuration from the macro context. It needs some experiments to see the best approach.
That code should be in the process of being open-sourced. I can put a link here when I get to know it is published. It is a library that can be used with the current stable version of scalatest.


Training crashes with Python being out of memory

Hi, I tried to run the training
python run.py --adhoc --cfg conf/c02_selfplay/liars_sp.yaml \
    env.num_dice=1 \
    env.num_faces=4 \
    env.subgame_params.use_cfr=true \
    selfplay.cpu_gen_threads=60

but after approx 45 minutes python runs out of memory on a 32GB machine (with some swap enabled):
[Mon Sep 21 19:01:30 2020] Out of memory: Kill process 92038 (python) score 975 or sacrifice child
[Mon Sep 21 19:01:30 2020] Killed process 92038 (python) total-vm:59949656kB, anon-rss:31843680kB, file-rss:91564kB, shmem-rss:12292kB
I suspect there is some memory leak, since the game it is trained on is tiny. Any ideas?

The default buffer size is pretty big it takes ~300Gb. Try using smaller buffer: replay.capacity=20000


wireguard: 0.0.20170421 -> 0.0.20170517

With the release of https://lists.zx2c4.com/pipermail/wireguard/2017-May/001334.html this commit is ready to be merged.

@fpletz -- this is no longer WIP. It is ready to be merged.

Thanks!


Update chaos dashboard

Update chaos dashboard

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65c462d4917fdc31570ba0af--harness-developer.netlify.app


gtctl cloud commands

gtctl cloud is command line tool to manage Greptime Cloud resources. Possible commands:

gtctl cloud login login to Greptime Cloud and persist the token
gtctl cloud service list list existing services
gtctl cloud service create create new services
gtctl cloud service info <service-name> show details of service
gtctl cloud service mysql <service-name> connect using local mysql cli
gtctl cloud service psql <service-name> connect using local psql cli
gtctl cloud service dashboard <service-name> open dashboard for service

This issue will remain pending until the Greptime Cloud API is ready.


Request to add enum Target_Type of NETCONF_SSH 830

Request to add enum Target_Type of NETCONF_SSH = 830 to tunnel.proto

@googlebot I signed it!

@googlebot I signed it!


link in README.md to git-gradle-publish actually points to grgit

Thanks for pointing this out!

N.p. would have sent a fix but work is not that github friendly
On 25 Aug 2017 00:49, "Andrew Oberstar"<EMAIL_ADDRESS>wrote:

Thanks for pointing this out!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ajoberstar/gradle-git/issues/268#issuecomment-324787396,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGlLZFxFXUKYMzgjHhleSJxVgWC_alxCks5sbgvzgaJpZM4PBQsy
.


Handle zero-value expiry interval

The ParamExpiryInterval flag says that setting it to zero should disable the expiry interval for metrics, immediately expiring them. However, setting it to zero effectively makes it an infinite interval, sending a zero-valued metric on every flush interval indefinitely.
Current logic says an expiryInterval of zero is never expired. Added quick check to handle zero, which sends the metric once without repeating zero-value sends.

One failed test, but I'm not sure of the intent of the test.
ma := &MetricAggregator{expiryInterval: 0}
assrt.Equal(false, ma.isExpired(now, now))

If zero disables the expiry interval, the assert should expect true.

My opinion on this is that it should be possible to have both infinite and immediate.  As for what that should look like, I'm not certain.

Cleaned up the logic and changed that test to expect true, making it pass again.
As for an infinite expiry interval, it could be signified as a negative value for this config flag, though that's not entirely obvious and might be better as a separate config flag.

@jsvensson hey, sorry for the delay. Have you signed the CLA?

Signed it just now!
I was looking through related code the other day, and I'm not sure how this change would interact with the expiration of gauges -- it might do weird stuff to gauges, but I'm not familiar enough with the codebase to tell properly.

@tiedotguy I've checked the CLA - signed. Are you ok with merging this?

I had a bit of a play around with it, and found the following:
Original:
-1s - sends once
0s - sends forever
1s - sends twice
Change:
-1s - sends once
0s - sends once
1s - sends twice
I think the problem is the documentation is ambiguous on behavior.  When I read After how long do we expire metrics (0 to disable), I read it as 0 disables expiry (therefore living forever), whereas @jsvensson, you read it as 0 disables expiry interval checking (therefore always expire).
Because with the current logic, it is possible to get both behaviors, but not with the change, I would say the best approach is to clarify the documentation to be explicit.
What do you think,  @jsvensson ?

Yeah, with that clarification I can do what I want without needing any changes, so I say we scrap this MR and clarify the documentation instead. Didn't actually occur to me to try a negative value.

Shall update documentation to clarify things (which is way overdue anyway)


pass new props loading

Add the ability new props loading into loadable-components for show fallback component when data fetching. And callback example <AsyncComponent loading={true} onLoadComponent={({  component, loading }) => {
} /> loading === passed props loading. onLoadComponent handled => component load or loading chenged
if (loading) {
should be displayed fallback component
}

Just use Suspense boundaries.

@theKashey i am use ssr

If you are using SSR, then there is no "loading" state possible.
Consider using a "custom" Suspense boundaries, which are Suspense on the client, and nothing on the server, like here.