Keep empty lines?

JSON is lame enough that it doesn't support comments. The only thing that makes for a bit better readability are empty lines. So I often group properties in my configuration files – like this:
{ "name": "..."
, "version": "..."

, "devDependencies":
  { "cli": "..."
  , "dependencies": "..."

  , "build": "..."
  , "dependencies": "..."
  }
}

format-json swallows these empty lines. Is it possible/reasonable to keep them?

I'd love a cli json formatter doing this too, but it's sadly hard to do without replacing JSON.parse with a full-blown low-level tokenizer/parser that ercognizes the context of all newline tuples, and as such a bit beyond the scope of this package.
I'd probably accept a pull request from someone solving the problem, if there's some ingenious way of doing it that I can't think of, though. If you want a slightly less sucky JSON family format that does have comments and doesn't have the immense feature riches of yaml, I can recommend cson, and the cson-cli (its equivalent of format-json, converting/formatting in both directions to/from json).

Thanks for the response. Now that I think of it, it's not something I need that badly. After all, any JSON I write by hand is in diffy-formatted anyway, and contains grouping empty lines. I only really use format-json for automatically-generated JSON and data – and of course they don't contain any empty lines.


When will the code be released?

Congratulations on this work being accepted by CVPR 2024!  : )
I would like to know when the authors are planning to release the code and model?

Thank you for your attention.
We plan to release both the code and model in April.


decoder:stop some H.264 decoding progress

Driver layer can not decode the H.264 whose format profile is HIGH10, HIGH_422 or HIGH_444. In founction getH264VAProfile(), assign variable profile with value VAProfileNone to stop H.264 decoding while profile is HIGH10, HIGH_422 or HIGH_444.

+1


Add badges and fix coverage

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (d2efae9) to head (dc9b17c).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           master        #7      +/-   ##
===========================================
+ Coverage   98.94%   100.00%   +1.05%
===========================================
  Files           8         8
  Lines         190       187       -3
===========================================
- Hits          188       187       -1
+ Misses          2         0       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[FIX] CSS: remove duplicate scroll bars from outer containers

SplitContainer/TabBar adds additional scrollbar (placeholder):

Avoid overflow on ScrollContainer/TabBar children - the content is providing its own scrollbars.

Hi @SeeSharpSoft,
there is an bug in chrome https://code.google.com/p/chromium/issues/detail?id=568185 that will be fixed in v48.
Removing the  overflow will cause other bugs.

PS: in Chrome Canary there is no problem with the scrollbars

Hi,
thanks for pointing it out that the overlapping is a bug with Chrome. I also had the feeling that this behavior occured with some update of Chrome within the last 6 month.
However, I still believe that it is not correct to have overflow scrollbars on splitcontainer/tabbar elements and their content as well. This might lead to two scrollbars showing up at the same time. It might have been more obvious if I would changed all touched overflow properties to 'hidden', but 'visible' (default) should be fine as well.
Do you have a concrete example where this change causes problems?

HI @SeeSharpSoft ,
the default value of the overflow property is "visible" - which will lead to render the content outside of the html element(if the content is bigger). You can see that behavior at http://www.w3schools.com/cssref/playit.asp?filename=playcss_overflow
About the two scrollbars I don't think it is possible with the current implementation of the components. Оf course, some day we may see that, but it will most probably be cached in the development process.
Best regards

Hi Chariyski,
I am pretty well aware of the overflow behavior, that's why I pointed it out.
And here you go:

Done with just downloaded Chrome Canary and latest UI Inspector! Captured the whole window with address and selected element so you can reproduce it by yourself. Just shrink the width of the right property panel.

Yep, this contradicted me...
Tomorrow I will check for regressions with the removed properties.

I've disabled the overflow properties from the console, but the text is cropped and unreachable.
See the attached image:

I suggest to mark the two scroll-bars as a bug and I will think for other solution.

This is how it looks like when applying the pull request:

I've played a bit more and it seems okay :+1:

Hi Chariyski,
sorry for pushing after you reviewed it. I just changed the overflow to hidden instead of defaulting it to visible - IMO it is safer and the intention more obvious. And it is needed for the 'splitter > start' tag in my other pull request as well, so I hope to reduce confusion and conflicts.
The 'divider issue' pull request got bigger with some changes that are not directly related to what I consider the issue. Let me know whether (parts of) it makes sense to you.

:+1:

Hi, is this project still alive?

Hi @SeeSharpSoft,
It is alive again :). Is this pull request still relevant?
Best Regards,
Svetoslav

Hi @SeeSharpSoft,
I am closing the pull request as this issue is no longer reproducible.
Best Regards,
Svetoslav


Upgrade and clean up dependencies

PR to accompany Issue #91

Drop support for python versions less than 3.11
Upgrade hop-client from v0.8.0 to v0.9.0
Drop several dependencies that don't appear to be used
Upgrade all packages that can be upgraded
All tests in the suite are passing on my local machine

I'm going to resubmit this PR after squashing commits to keep the commit history clean.


Update troubleshooting-proxy.md

@shsagir can you review?

@ani6gup : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Merged in separate PR


Prompting simulator

We train by simulating an interactive setting, sampling 8-frame sequences and randomly selecting up to 2
frames (including the first) for corrective clicks. During training, we use ground-truth masklets and model
predictions to sample prompts, with initial prompts being the ground-truth mask (50% probability), a positive
click from the ground-truth mask (25%), or a bounding box input (25%).
We restrict the maximum number of masklets for each sequence of 8 frames to 3 randomly chosen ones. We
reverse the temporal order with a probability of 50% to help generalization to bi-directional propagation.
When we sample corrective clicks - with a small probability of 10%, we randomly sample clicks from the
ground truth mask, irrespective of the model prediction, to allow additional flexibility in mask refinement.

@ronghanghu Are you going to commit the promoting simulator?

Hi @bhack, we released the training code for SAM 2 (which includes how we simulate user prompts during training).


Adding test for product-apim/issues/11894

Adding test for product-apim/issues/11894

Closing the test


How to know device has been deregister ?

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

How to know device has been deregister ?
What behavior are you observing?

Case 1:
If do deregister when device is online, I only receive some debug msg(see attachment), is there have any function or flags can be identify ? So that I could let device go to setup mode immediately.
deregister.log
Case 2:
If do deregister when device in offline, once device goes to online, I can check AuthObserverInterface::State::UNRECOVERABLE_ERROR via onAuthStateChange function. Hence I can handle this case.
Thanks.
Tell us about your environment:

What version of the AVS Device SDK are you using?
  <1.6.0>

Tell us what hardware you're using:

[X] Other - tell us more:
Cross compile on embedded

Tell us about your OS (Type & version):

[x] Linux

Hi @melancholyhua,
That's a great question! We are still improving the device deregistration experience. For now, please check the answer provided in #339.
Thanks


Workaround for virtuozzo openstack systems #39

This is a workaround for virtuozzo openstack systems. As discussed in #39 it looks like querying volumes by metadata works differently in virtuozzo. When migratekit looks for existing volumes, no volumes are returned by the volume api query.
As a workaround this pull request adds a flag to only use the volume name to find the correct volume.

@jmussmann will this automatically merge to master?

Yes, please!

Yes, please!

Done: https://github.com/vexxhost/migratekit/pull/56


vela-core pod CrashLoopBackoff

Describe the bug
Installing vela 0.1.2 on a kinD cluster results in vela-core pod repeatedly crashing in vela-system namespace.
To Reproduce
Steps to reproduce the behavior:

Install k8s cluster using the latest kinD binary using config as per vela documentation
Install ingress-nginx as per vela documentation
install vela binary 0.12
install vela core using 'vela install' command (output from vela install does not report any errors)
4a. verified nginx pod is running
4b. monitoring namespace was created but it does not have any resources (empty namespace)
wait for vela-core pod to reach ready state
within few minutes vela-core pod reports the status of CrashLoopBackoff
waiting over 24hrs and 100+ restarts
see logs from vela-core pod below

Expected behavior
vela-core pod in running state
Logs from vela-core pod
I1204 17:31:23.336374       1 request.go:621] Throttling request took 1.040401888s, request: GET:https://<IP_ADDRESS>:443/apis/keda.sh/v1alpha1?timeout=32s
2020-12-04T17:31:23.555Z	INFO	dependency installer	installing helm chart	{"chart name": "flagger"}
2020-12-04T17:31:24.794Z	INFO	controller-runtime.metrics	metrics server is starting to listen	{"addr": ":8080"}
2020-12-04T17:31:24.795Z	INFO	kubevela	creating readiness/health check
2020-12-04T17:31:24.795Z	INFO	kubevela	vela webhook enabled, will serving at :9443
2020-12-04T17:31:24.795Z	INFO	controller-runtime.webhook	registering webhook	{"path": "/validating-core-oam-dev-v1alpha2-applications"}
2020-12-04T17:31:24.795Z	INFO	controller-runtime.webhook	registering webhook	{"path": "/validating-core-oam-dev-v1alpha2-applicationconfigurations"}
2020-12-04T17:31:24.795Z	INFO	controller-runtime.webhook	registering webhook	{"path": "/mutating-core-oam-dev-v1alpha2-applicationconfigurations"}
2020-12-04T17:31:24.795Z	INFO	controller-runtime.webhook	registering webhook	{"path": "/mutating-core-oam-dev-v1alpha2-components"}
2020-12-04T17:31:24.795Z	INFO	controller-runtime.webhook	registering webhook	{"path": "/validating-core-oam-dev-v1alpha2-components"}
2020-12-04T17:31:24.795Z	INFO	controller-runtime.webhook	registering webhook	{"path": "/validate-standard-oam-dev-v1alpha1-metricstrait"}
2020-12-04T17:31:24.796Z	INFO	controller-runtime.webhook	registering webhook	{"path": "/mutate-standard-oam-dev-v1alpha1-metricstrait"}
2020-12-04T17:31:24.796Z	INFO	controller-runtime.webhook	registering webhook	{"path": "/validate-standard-oam-dev-v1alpha1-podspecworkload"}
2020-12-04T17:31:24.796Z	INFO	controller-runtime.webhook	registering webhook	{"path": "/mutate-standard-oam-dev-v1alpha1-podspecworkload"}
2020-12-04T17:31:25.078Z	INFO	dependency installer	installing helm chart	{"chart name": "keda"}
2020-12-04T17:31:26.369Z	INFO	dependency installer	installing helm chart	{"chart name": "kube-prometheus-stack"}
2020-12-04T17:31:26.796Z	INFO	kubevela	waiting webhook secret, time consumed: 2/90 seconds ...
2020-12-04T17:31:26.796Z	INFO	kubevela	webhook secret is ready (time consumed: 2 seconds)
2020-12-04T17:31:26.798Z	INFO	kubevela	starting the vela controller manager
I1204 17:31:26.798533       1 leaderelection.go:242] attempting to acquire leader lease  vela-system/kubevela...
2020-12-04T17:31:26.799Z	INFO	controller-runtime.manager	starting metrics server	{"path": "/metrics"}
2020-12-04T17:31:26.800Z	INFO	controller-runtime.webhook.webhooks	starting webhook server
2020-12-04T17:31:26.801Z	INFO	controller-runtime.certwatcher	Updated current TLS certificate
2020-12-04T17:31:26.801Z	INFO	controller-runtime.webhook	serving webhook server	{"host": "", "port": 9443}
2020-12-04T17:31:26.801Z	INFO	controller-runtime.certwatcher	Starting certificate watcher
"prometheus-community" has been added to your repositories
2020-12-04T17:31:29.309Z	ERROR	dependency installer	failed to install helm chart for servicemonitors.monitoring.coreos.com	{"error": "cannot re-use a name that is still in use", "errorVerbose": "cannot re-use a name that is still in use\nhelm.sh/helm/v3/pkg/action.(*Install).availableName\n\t/go/pkg/mod/helm.sh/helm/v3@v3.2.4/pkg/action/install.go:428\nhelm.sh/helm/v3/pkg/action.(*Install).Run\n\t/go/pkg/mod/helm.sh/helm/v3@v3.2.4/pkg/action/install.go:179\ngithub.com/oam-dev/kubevela/pkg/utils/helm.Install\n\t/workspace/pkg/utils/helm/helm.go:77\ngithub.com/oam-dev/kubevela/pkg/utils/helm.InstallHelmChart\n\t/workspace/pkg/utils/helm/helm.go:255\ngithub.com/oam-dev/kubevela/pkg/controller/dependency.installHelmChart\n\t/workspace/pkg/controller/dependency/install.go:114\ngithub.com/oam-dev/kubevela/pkg/controller/dependency.Install\n\t/workspace/pkg/controller/dependency/install.go:68\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1373"}
github.com/go-logr/zapr.(*zapLogger).Error
/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128
github.com/oam-dev/kubevela/pkg/controller/dependency.Install
/workspace/pkg/controller/dependency/install.go:70
I1204 17:31:43.367891       1 leaderelection.go:252] successfully acquired lease vela-system/kubevela
2020-12-04T17:31:43.368Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "standard.oam.dev", "reconcilerKind": "Autoscaler", "controller": "autoscaler", "source": "kind source: /, Kind="}
2020-12-04T17:31:43.369Z	DEBUG	controller-runtime.manager.events	Normal	{"object": {"kind":"ConfigMap","namespace":"vela-system","name":"kubevela","uid":"e345e5c0-3dee-4c08-8a25-ebf8a6346414","apiVersion":"v1","resourceVersion":"11345"}, "reason": "LeaderElection", "message": "kubevela-vela-core-77f4494f8f-b6qzt_49060038-05fe-4417-8db5-44d846b67eaf became leader"}
2020-12-04T17:31:43.369Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "ApplicationConfiguration", "controller": "oam/applicationconfiguration.core.oam.dev", "source": "kind source: /, Kind="}
2020-12-04T17:31:43.369Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "ContainerizedWorkload", "controller": "oam/containerizedworkload", "source": "kind source: /, Kind="}
2020-12-04T17:31:43.369Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "ManualScalerTrait", "controller": "oam/manualscalertrait", "source": "kind source: /, Kind="}
2020-12-04T17:31:43.369Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "HealthScope", "controller": "oam/healthscope.core.oam.dev", "source": "kind source: /, Kind="}
2020-12-04T17:31:43.369Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "ApplicationDeployment", "controller": "applicationdeployment", "source": "kind source: /, Kind="}
2020-12-04T17:31:43.369Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "Application", "controller": "application", "source": "kind source: /, Kind="}
2020-12-04T17:31:43.370Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "standard.oam.dev", "reconcilerKind": "MetricsTrait", "controller": "metricstrait", "source": "kind source: /, Kind="}
2020-12-04T17:31:43.370Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "standard.oam.dev", "reconcilerKind": "PodSpecWorkload", "controller": "podspecworkload", "source": "kind source: /, Kind="}
2020-12-04T17:31:43.370Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "standard.oam.dev", "reconcilerKind": "Route", "controller": "route", "source": "kind source: /, Kind="}
2020-12-04T17:31:43.469Z	INFO	controller	Starting Controller	{"reconcilerGroup": "standard.oam.dev", "reconcilerKind": "Autoscaler", "controller": "autoscaler"}
2020-12-04T17:31:43.469Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "ApplicationConfiguration", "controller": "oam/applicationconfiguration.core.oam.dev", "source": "kind source: /, Kind="}
2020-12-04T17:31:43.469Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "ContainerizedWorkload", "controller": "oam/containerizedworkload", "source": "kind source: /, Kind="}
2020-12-04T17:31:43.470Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "ApplicationDeployment", "controller": "applicationdeployment", "source": "kind source: /, Kind="}
2020-12-04T17:31:43.469Z	INFO	controller	Starting Controller	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "HealthScope", "controller": "oam/healthscope.core.oam.dev"}
2020-12-04T17:31:43.469Z	INFO	controller	Starting Controller	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "ManualScalerTrait", "controller": "oam/manualscalertrait"}
I1204 17:31:44.420231       1 request.go:621] Throttling request took 1.041925481s, request: GET:https://<IP_ADDRESS>:443/apis/networking.k8s.io/v1?timeout=32s
2020-12-04T17:31:44.624Z	ERROR	controller-runtime.source	if kind is a CRD, it should be installed before calling Start 	{"kind": "Application.core.oam.dev", "error": "no matches for kind "Application" in version "core.oam.dev/v1alpha2""}
github.com/go-logr/zapr.(*zapLogger).Error
/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/source.(*Kind).Start
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.2/pkg/source/source.go:117
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:140
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:175
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startRunnable.func1
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.2/pkg/manager/internal.go:661
2020-12-04T17:31:44.624Z	INFO	controller	Starting workers	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "ManualScalerTrait", "controller": "oam/manualscalertrait", "worker count": 1}
2020-12-04T17:31:44.625Z	INFO	controller	Stopping workers	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "ManualScalerTrait", "controller": "oam/manualscalertrait"}
2020-12-04T17:31:44.625Z	INFO	controller-runtime.webhook	shutting down webhook server
2020-12-04T17:31:44.624Z	INFO	controller	Starting workers	{"reconcilerGroup": "standard.oam.dev", "reconcilerKind": "Autoscaler", "controller": "autoscaler", "worker count": 1}
2020-12-04T17:31:44.625Z	INFO	controller	Stopping workers	{"reconcilerGroup": "standard.oam.dev", "reconcilerKind": "Autoscaler", "controller": "autoscaler"}
2020-12-04T17:31:44.624Z	INFO	controller	Starting Controller	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "ApplicationDeployment", "controller": "applicationdeployment"}
2020-12-04T17:31:44.624Z	INFO	controller	Starting workers	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "HealthScope", "controller": "oam/healthscope.core.oam.dev", "worker count": 1}
2020-12-04T17:31:44.625Z	INFO	controller	Stopping workers	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "HealthScope", "controller": "oam/healthscope.core.oam.dev"}
2020-12-04T17:31:44.627Z	ERROR	controller	Could not wait for Cache to sync	{"reconcilerGroup": "core.oam.dev", "reconcilerKind": "ApplicationDeployment", "controller": "applicationdeployment", "error": "failed to wait for applicationdeployment caches to sync: cache did not sync"}
github.com/go-logr/zapr.(*zapLogger).Error
/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:157
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:175
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startRunnable.func1
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.2/pkg/manager/internal.go:661
2020-12-04T17:31:44.627Z	ERROR	controller-runtime.manager	error received after stop sequence was engaged	{"error": "failed to wait for applicationdeployment caches to sync: cache did not sync"}
github.com/go-logr/zapr.(*zapLogger).Error
/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).engageStopProcedure.func1
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.2/pkg/manager/internal.go:521
2020-12-04T17:32:14.625Z	ERROR	kubevela	problem running manager	{"error": "[no matches for kind "Application" in version "core.oam.dev/v1alpha2", failed waiting for all runnables to end within grace period of 30s: context deadline exceeded]", "errorCauses": [{"error": "no matches for kind "Application" in version "core.oam.dev/v1alpha2""}, {"error": "failed waiting for all runnables to end within grace period of 30s: context deadline exceeded"}]}
github.com/go-logr/zapr.(*zapLogger).Error
/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128
main.main
/workspace/main.go:195
runtime.main
/usr/local/go/src/runtime/proc.go:203
Cluster information
Describe your kubernetes cluster information.

Kubernetes Version 1.19
kubectl version 1.19

Additional context

About two weeks ago I was able to successfully deploy kubevela version 0.1.1 and run through the getting started guide.
I tried to use kubevela ver 0.1.1 but encountered the same issue as above. The logs were similar as well
I tried kubevela ver 0.0.9 and 0.0.8 but got the same results as above
Also switch from kinD to k3s (installed k3s without addons like trafik or servicelb) but same results
After each try, the test cluster was deleted and reinstalled to make sure I had a sanitized environment.

similiar to #710 And I'm fixing in #717

We released v0.2.0 I think it has been fixed.

The error is caused by initializing the controller.
Using the service installed in version v0.1.2, we can find that Vela install does not initialize the CRD of the Application.
This CRD has added it. Theoretically, v0.2.0 does not have this problem.
I found that the content of CRD changes more frequently. Support to check whether the CRD resources in the CRD and chart packages match when publishing?

@Cweiping  Now release will lock with the image, so it won't happen again.

@wonderflow v0.2.0 fixes this bug. I validated this release against kinD and k3s. thanks for the quick turnaround!
this bug is squashed! I will close the ticket.


InitWithConfig needs an explicit severity

Otherwise logger creation fails on severity parsing
And hence there are no logs whatsoever

Thanks a lot, this if fixed by  #232 as I believe

Cool, thanks.


Raise/assume status code to be 200 if status code is not specified?

I'm not sure where to post it - I encountered it when used pact + pact-mock_service, so, I've decided to post it here.
When you accidentaly forget to specify status response option you can get strange result with Net::HTTP:
Net::HTTPBadResponse:
       wrong status line: "HTTP/1.1 0  "

I see such possible solutions:

raise an exception if status is not specified - it would be nice because error message can explicitly say "you forgot the status code" instead of assuming it as 0
or assume it to be 200 - it's the most common expected response code IMO;

I think an error would be best, assumptions can be dangerous.

@bethesque I agree - it's better to explicitly point to this error instead of assuming anything (0 or 200), but I just wanted to present other possible solution I've thought about anyway.


Is there a roadmap?

Hi, thank you for your work!
Is there a future operation roadmap in long/short term  like adding  RNN... transformer...?

Hi @kit-high, thanks for your interest in CMSIS-NN.
In general we add optimizations for operators that are supported by TFLM as we are an optimization library and not a ML framework. You can expect new operators like transpose conv and new data types like int4.
Is there any particular operator you are interesting in?

@mansnils
I apologize for the delayed response.
I agree with you that it's not an ML framework.
However, since it already has implementations for somewhat complex ML methods like LSTM, I was expecting that it would also implement methods that are not yet included, such as RNNs or Transformers.
As an engineer, I feel that the advancement of Light Edge AI is closely tied to the development of this library. If the opportunity arises, I would like to contribute by making a pull request. Thank you.

Thanks @kit-high. Your contribution is welcome. Anyhow a potential new operator should have an equivalent reference kernel in TFL/TFLM.


for loop

There is a bug when you try to answer the question it didn't give me choices

by using for loop problem solved


Feat/removing saas import logic

Removing Saas component and logic
Replacing unit testing with calls to create bpns

closes #155


Improve HTML

This Pull Request aims to improve the HTML of the website. These improvements are based on this checklist by David Dias. This is currently an ongoing process, other suggestions regarding the HTML are welcome 🙂
Note: commit 2dbfbcf141402e31f484524c2da53c5006bfb74b should have been part of this Pull Request, it covers the Head section of the checklist.
Enhancements

Add role="button" to button-like <a> elements.

Bugfixes

Fix incorrect usage of aria-hidden, thanks @service-paradis (more about aria-hidden="true")

Performance

Remove unnecessary rel="noopener" if target="_blank" is not used (more about rel="noopener").
Remove unnecessary role attribute on <header> (based on w3 HTML checker scan).
Remove unnecessary role attribute on <main> (based on w3 HTML checker scan).
Remove unnecessary role attribute on ` (based on w3 HTML checker scan).

I would add another suggestion. For accessibility purpose, there are some SVGs without accessible text (buttons used to sort and to change scheme).
It would be a good idea to add aria-labelledby. Ex.

Good catch, fixed this in 1ee1c6cc07db437d2ec9bb66ea4d93caeac3d0e9 :+1:


Refreshing on /c/local/explorer/node throws a white page error

in dev this is a white page error with this.metricPoller.stop is not a function
on my dev system metrics isn't installed

This is a SSR-only thing, can't put a Poller instance into data because it won't serialize during state transfer to the client.
So QA won't really be able to test it, if you just want to confirm and close @richard-cox.

It was a SSR only thing. I thought it'd be a quick fix so gave it a go, but ended up needing a minor tidy instead - #2997


Snakebite cli ignores skiptrash (wrong docs) and use_trash (possible bug)

We have multiple DC with different HDFS. Basically if you want to work like that you have to provide name node as parameter to snakebite.
Recently we faced the issue when folder with important data was deleted without moving to .Trash.
I investigated code a little bit.
Issue 1: So, 'skiptrash' configuration is not used by code, I assume documentation wasn't updated on this.
Issue 2: It looks like if you specifying name node as cli parameter configuration file is not read at all. It would read standard locations for HDFS configuration, but in our case it wasn't there, and skiptrash become true.

I'm not sure what you mean with issue 1. Can you clarify?
On issue 2: skiptrash is a client setting. Snakebite should read the config that is on your client host (either hadoop xml config or .snakebiterc) and use those settings. If you happen to connect to a different namenode than is in your config (because you use hdfs://othernamenode/mypath), the initial settings are still true. In case your default cluster has skipTrash=false, a connection to another cluster will still use that setting. Is this what is happening?


Ag package term suggestion photosynt_activ MIXS:0001296

New term details
Term name - photosynthetic activity
Term ID - MIXS:0001296
Structured comment name - photosynt_activ
Definition - Measurement (i.e. leaf gas exchange / chlorophyll fluorescence emissions / reflectance / transpiration)
Expected value - measurement value
Value syntax - {float} {unit}
Example - μmol CO2 m-2 s-1
Package(s) - Agriculture

Additional context
Suggested as part of the Ag package
Points for discussion
Better definition required. is this measurement of the host plant being sampled for sequencing? is it meant to contain the method of measurement as well as the value?

How about two fields: one for measurement and one for method. Similar to those in soil package

As agreed above, I have created another term for the method and assigned a unique MIXS ID, the two terms listed below are now included in the Ag package, and added to the Changes log.
Term name - photosynthetic activity
Term ID - MIXS:0001296
Structured comment name - photosynt_activ
Definition - Measurement of photosythetic activity (i.e. leaf gas exchange / chlorophyll fluorescence emissions / reflectance / transpiration) Please also include the term method term detailing the method of activity measurement.
Expected value - measurement value
Value syntax - {float} {unit}
Example - μmol CO2 m-2 s-1
Package(s) - Agriculture

Term name - photosynthetic activity method
Term ID - MIXS:0001336
Structured comment name - photosynt_activ_meth
Definition - Reference or method used in measurement of photosythetic activity
Expected value - PMID,DOI or url
Value syntax - {PMID}|{DOI}|{URL}
Example -


Add @sbswg as an owner 😼

Changes
Scott has been provided super detailed helpful reviews for a while now
(58 reviews as of
https://tekton.devstats.cd.foundation/d/46/pr-reviews-by-contributor?orgId=1&var-period=d&var-repo_name=tektoncd%2Fpipeline&var-reviewers="sbwsg").
He has contributed useful and technically challenging features such as
https://github.com/tektoncd/pipeline/pull/905 (recreate pods in face of
ResourceQuota errors), drove completion of
https://github.com/tektoncd/pipeline/pull/936
(Graceful sidecar support) and also https://github.com/tektoncd/pipeline/pull/871
(enforcing default TaskRun timeouts).
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[n/a] Includes tests (if functionality changed/added)
[n/a] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task and TaskRun to build and release this image

Reviewer Notes
If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.

/hold
@dlorenc @ImJasonH @vdemeester @abayer @afrittoli @dibyom

/lgtm

/lgtm

/lgtm

/hold cancel
I think we have majority :angel: :clap:


When I try to start the server nothing happens.

When I run the command ./start.sh it send me all the messages about it start but when I try to access the console I get nothing. I can rub the command again but it still has the same issue. Not sure what the issue is.

I fixed this by editing the start file and changing the way it starts the server to use the same way as if you started any Minecraft server but still with the beginning part to make sure it still runs in the background.


EF6 to EF Core porting documentation outlines broken migration procedure

The guide for porting from EF6 to EF Core mentions the possibility of migrating by using the existing database and removing the actual migration code from a new initial migration. From my personal attempt at doing this I'm however running into the following issues:

Table names in EF6 are based on type, in EF Core on DbSet property name
Primary keys and foreign keys in EF6 include dbo. in the constraint names (EF6: PK_dbo.Users, EF Core: PK_Users)
Foreign keys without foreign key property in EF6 generate names with underscore prefixes before the referenced table key column name, in EF Core the additional underscore is not there
Index names in EF Core include the table or entity name in the name (IX_TeamMembers_UserId), EF 6 uses the property name only (IX_UserId)
EF6 might have generated boolean columns as [bit] NOT NULL DEFAULT 0, EF Core omits the DEFAULT 0 for new tables (initial migration, so all tables are new). The DEFAULT 0 causes a constraint to be generated, which on migration down is removed by EF6 by looking up the constraint in sys.default_constraints, because the name is partially randomized. A new migration in EF Core that would remove the property would probably fail because the constraint is referencing the property

These are definitely not all. I think it's bad advice to tell people to migrate to EF Core like this, it will cause a lot of frustration when continuing development on the project that was migrated. Some of these issues can definitely be remedied using additional configuration in EF Core, which permits generation of a schema that is much closer to the original EF6 schema. However, when someone would remove that configuration to make use of EF Core defaults you'll again run into issues because you can't rename primary keys if a foreign key is referencing the table.
I think the only feasible approach is to ensure the EF Core model matches table names and column names from the EF6 model, creating a new database using EF Core migrations and copying the data (possibly inserting data with keys) from the old (EF6) to the new (EF Core) database.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e1226698-6874-6f8f-f716-1974152243fa
Version Independent ID: 9e7bdb7a-d3dc-03a2-99f6-78aa46cc8357
Content: Porting from EF6 to EF Core - Porting a Code-Based Model - EF
Content Source: entity-framework/efcore-and-ef6/porting/port-code.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @ajcvickers
Microsoft Alias: avickers

There are indeed some sensible points in the post linked by @rmmcgr. I ended the original issue text with stating the only feasible approach would be to copy the data, but of course my desire is to have an approach that works on the existing database.
If the conventions from EF6 could all be applied to the EF Core modelbuilder it would be possible to create a migration package that one could use for the initial migration, after that dropping the migration package should yield a migration to a database model that resembles what EF Core would normally do.
While I still hope this will happen (and sooner rather than later), the migration page is still online with the utterly broken advice of removing the initial migration up/down code.


Using @solid-primitives/stream along with new MediaStream() causing chrome & chromium to load forever

This bug only affects Chrome & Chromium
Steps to reproduce the bug :
npx degit solidjs/templates/ts bug
cd bug
npm i @solid-primitives/stream
npm start

App.tsx :
import type { Component } from 'solid-js';

declare module "solid-js" {
  namespace JSX {
    interface ExplicitProperties {
      srcObject?: MediaStream
    }
  }
}

const App: Component = () => {
  let Stream = new MediaStream()
  return (
    <div>
      <video class="video" prop:srcObject={Stream} autoplay playsinline></video>
    </div>
  );
};

Chromium Version 104.0.5112.79 (Official Build) (64-bit)
just keeping the package installed causing this bug when using new MediaStream()
(I'm using new MediaStream() for remote streams and @solid-primitives/stream for local streams)
This bug also blocks some functionality. not sure what are things but for me it blocks createStream

I have reproduced the same behavior without even installing @solid-primitives/stream (or even without solid), thus I must conclude that this is indeed an issue of Chromium (if not intended behavior) and not an issue with our primitive:
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1" />
    <title>MediaStream bug test</title>
  </head>
  <body>
    <video autoplay playsinline></video>
    <script>document.querySelector('video').srcObject = new MediaStream()</script>
  </body>
</html>

On the other hand, this might work as intended, as the browser tries to load media stream tracks into the video tag, which are never arriving. However, if you refrain from setting srcObject, your page will not expose the described reaction. Thus, the correct usage would be to only set srcObject in the video tag if you have a media stream with tracks inside.


Allow json schema object as init parameter (TypeScript)

Instead of a yaml file I only have a json swagger document object. When digging into the code I figured out that I can pass the document to the init method as follows:
swaggerValidator.init(document as any)

Is it possible to change the init signature (TypeScript) to allow objects as well?

Hi @clemens-smartparking, thanks for your feedback!
This is an indeed requested feature so we'll try to find some time for it, but PRs are always welcome :)

I've prepared a fix in https://github.com/Zooz/api-schema-builder/pull/35 which awaits for review, to finally handle this issue.
After it's merged and release, i'll update express-ajv-swagger-validation as well.


Remove github.com/pkg/errors

This is #1278 again. No changes. Please re-approve.
I can't wait to be able to use git ship again to prevent these types of problems once #1280 ships!

How would the need to open a new PR be saved by 1280? I would think the issue is repointing PRs before merge.

Thanks for the re-approve. I can't use git ship right now because most of my repos automatically delete the head branch for PRs. I am too forgetful to update all dependent PRs manually. I'm working on this in my free time early mornings and evenings and need a more idiot-proof solution a la Git Town.


Rendering of boundary=protected_area

Style change requested
It seems to me that boundary=protected_area is not being rendered. I would appreciate if it was rendered on the map.
Example tagging for a boundary
boundary=protected_area
name=Mountain Pine Ridge Forest Reserve
protect_class=6
start_date=1959-05-09
type=boundary
The protect_class is used to indicate boundary relevance, as admin_level is for administrative boundaries.
Where this is visible
Overpass query on protected_area -> link
Here you can see how it is rendered on OSM.

Example of old map styles

I would ignore protect_class, that's related to iucn categories

Currently there is not rendering of boundary=protected_area but that could be included into the vector tiles,
cc. @vknoppkewetzel

I agree with  @ZeLonewolf
Design-wise, having it be a class that isn't styled for in the main/Historical style because it can cause a lot of visual "clutter/contrast" on the map at once, given the main style has a lot of other data, and because many land protections that have occurred in the US over time didn't just occur at a large level (like National Parks) but at a smallll level over time, by different entities and at different scales.
So, with different entities protecting different areas at once and/or over time, the visual clutter of the boundaries would be an issue for those, and if shown, would only be ideal at a high level. At some point in history (and today), many protected areas are aggregated up to a larger area/class, but that bit is dependent on the complexities of when there are decisions made on who becomes the manager of those areas (vs different managers for the dispersed and smaller protected areas).
I do think that seeing the change over time IS interesting, and it if is really useful and is of interest, maybe it's worth asking the community if a separate style should be created that is intentionally focused only on the "environment", "conservation", "green space" or some other higher level category such as those


Add new classes for find event name command

Fixes #38

Codecov Report
Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

...seedu/address/logic/commands/FindEventCommand.java
0.00%
16 Missing :warning:

...pes/common/EventNameContainsKeywordsPredicate.java
0.00%
12 Missing :warning:

...u/address/logic/parser/FindEventCommandParser.java
0.00%
7 Missing :warning:

Files with missing lines
Coverage Δ
Complexity Δ

src/main/java/seedu/address/logic/Messages.java
87.50% <ø> (ø)
3.00 <0.00> (ø)

...u/address/logic/parser/FindEventCommandParser.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...pes/common/EventNameContainsKeywordsPredicate.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...seedu/address/logic/commands/FindEventCommand.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

lgtm


Live web site with authentication

Is it possible to run mocha-phantomjs on a site which requires authentication (for example form based auth, or windows)?

I think you're misunderstanding what mocha-phantomjs does. it takes mocha tests that run in a browser on some site and pipes out the output. It's not running the tests from the outside, which is probably what you want. Try mocha-casperjs or Selenium for those cases.
Otherwise no, but you can specify query string parameters and cookies before you start, which might help you there.

May be I'm not good at explanation, sorry. Yes, I need to run tests in a browser on some site, but this site requires windows authentication.
Thanks for your advice, will take a look into different options.


Could not resolve all task dependencies for configuration ':app:developmentDebugRuntimeClasspath'.

Description
"react-native": "0.68.2"
[Description of the bug]
Steps to Reproduce

yarn add lottie-react-native<EMAIL_ADDRESS>react-native run-android

FAILURE: Build failed with an exception.

What went wrong:
Could not determine the dependencies of task ':app:preDevelopmentDebugBuild'.

Could not resolve all task dependencies for configuration ':app:developmentDebugRuntimeClasspath'.
Could not resolve com.airbnb.android:lottie:5.1.1.
Required by:
project :app > project :lottie-react-native
Could not resolve com.airbnb.android:lottie:5.1.1.
Could not get resource 'https://www.jitpack.io/com/airbnb/android/lottie/5.1.1/lottie-5.1.1.pom'.
Could not GET 'https://www.jitpack.io/com/airbnb/android/lottie/5.1.1/lottie-5.1.1.pom'.
Read timed out

"react-native": "0.68.2",
android/build.gradle
`buildscript {
ext {
buildToolsVersion = 30.0.0
minSdkVersion = 23
compileSdkVersion = 30
targetSdkVersion = 30
supportLibVersion = 29.0.0
kotlin_version = 1.4.10
}
repositories {
google()
jcenter()
}
dependencies {
classpath("com.android.tools.build:gradle:3.4.3")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version")
    classpath 'com.google.gms:google-services:4.3.8'
    classpath 'com.google.firebase:firebase-crashlytics-gradle:2.4.1'
}

}
allprojects {
repositories {
mavenLocal()
maven {
url("$rootDir/../node_modules/react-native/android")
}
maven {
url("$rootDir/../node_modules/jsc-android/dist")
}
    maven { url 'https://maven.google.com' }

    maven { url "https://www.jitpack.io" }

    maven {
        url "https://sdk.smartlook.com/android/release"
    }

    google()
    jcenter()
}

}
subprojects {
afterEvaluate {
project ->
if (project.hasProperty("android")) {
android {
compileSdkVersion = 29
buildToolsVersion = "29.0.3"
}
}
}
}
`

Please remove jcenter() from the list of repositories and put google() on top of maven { url "https://www.jitpack.io" }.
For example:
allprojects {
    repositories {
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url("$rootDir/../node_modules/react-native/android")
        }
        maven {
            // Android JSC is installed from npm
            url("$rootDir/../node_modules/jsc-android/dist")
        }
        google()
        maven { url 'https://jitpack.io' }
        mavenCentral {
            // We don't want to fetch react-native from Maven Central as there are
            // older versions over there.
            content {
                excludeGroup "com.facebook.react"
            }
        }
    }
}


OperationalError: (OperationalError) no such column: user.id u'SELECT user.id AS user_id, user.firstname AS user_firstname, user.lastname AS user_lastname, user.email AS user_email, user.mobile AS user_mobile, user.password AS user_password, user.dateofreg AS user_dateofreg \nFROM user \nWHERE user.email = ?' (u'kiran@hotmail.com',)

can any one help me on how to resolve this error?

Did you upgrade your database? The error suggests you haven't executed the database migrations.

I am having the same issue. It happens right after 9a in 10a. I did upgrade the database.
sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such column: users.name [SQL: 'SELECT users.id AS users_id, users.email AS users_email, users.username AS users_username, users.role_id AS users_role_id, users.password_hash AS users_password_hash, users.confirmed AS users_confirmed, users.name AS users_name, users.location AS users_location, users.about_me AS users_about_me, users.member_since AS users_member_since, users.last_seen AS users_last_seen \nFROM users \nWHERE users.email = ?\n LIMIT ? OFFSET ?'] [parameters<EMAIL_ADDRESS>1, 0)] (Background on this error at: http://sqlalche.me/e/e3q8)

@ravibilla your error indicates that your users table does not have a name column. Review your migrations to see if this column is being removed for some reason.

I had the same problem, I solved it by running python manage.py db migrate and then python manage.py db upgrade.

how to upgrade database? I have same problem


Fixed bug CON-693

Problem:
PVC creation should error out if filesystem type of child In storage class definition is different from parent PVC
Fix:
Added a logic to fetch the parent volume filesystem type and compare it with the requested pvc filesystem, error out if they are different.

Thank you Shiva for merging the changes !


Trusted Provider--CAVP

Today's requirements: CPU, chip set,  O/S, hypervisor or container
ID how variable the cloud platform could be for a live instance.
Containers--how would that work? Look at NIST guidance
How much control does the vendor have over what the platform looks like?

TOE vendor should ID what platforms are available?
https://csrc.nist.gov/csrc/media/Projects/cryptographic-algorithm-validation-program/documents/CAVPFAQ.pdf
GEN.17 Does CAVP allow algorithm tests to be performed on a target operating system running on top of a virtual machine? Or must the target OS be the machine’s native OS? What about containers?
The CAVP allows algorithm tests to be performed on a guest operating system running on a hypervisor; however, the full virtualization environment shall be specified in the OE listing as described below.
For a Type 1 (or native) hypervisor, where the hypervisor runs directly on the hardware, the OE listing shall include the guest OS, hypervisor, and processor using the following format: “Guest OS on hypervisor on Processor.” An example is “Microsoft Windows 11 on VMWare ESXi 7.0 on Intel Xeon W (Rocket Lake).”
For a Type 2 (or hosted) hypervisor, where the hypervisor runs on a host operating system (OS), the OE listing shall include the guest OS, hypervisor, host OS, and processor using the following format: “Guest OS on hypervisor on Host OS on Processor.” An example is “Microsoft Windows 11 on Parallels Desktop 17 on

https://csrc.nist.gov/csrc/media/Projects/cryptographic-algorithm-validation-program/documents/CAVPFAQ.pdf
GEN.17 Does CAVP allow algorithm tests to be performed on a target operating system running on top of a virtual machine? Or must the target OS be the machine’s native OS? What about containers?
The CAVP allows algorithm tests to be performed on a guest operating system running on a hypervisor; however, the full virtualization environment shall be specified in the OE listing as described below.
For a Type 1 (or native) hypervisor, where the hypervisor runs directly on the hardware, the OE listing shall include the guest OS, hypervisor, and processor using the following format: “Guest OS on hypervisor on Processor.” An example is “Microsoft Windows 11 on VMWare ESXi 7.0 on Intel Xeon W (Rocket Lake).”
For a Type 2 (or hosted) hypervisor, where the hypervisor runs on a host operating system (OS), the OE listing shall include the guest OS, hypervisor, host OS, and processor using the following format: “Guest OS on hypervisor on Host OS on Processor.” An example is “Microsoft Windows 11 on Parallels Desktop 17 on

he cryptographic module under test SHALL be confirmed to be running on an OE that is well-defined and has a specific OS version, hardware platform and version, and processor (including microprocessor version), as shown on the module’s certificate and security policy and where this can be confirmed during the test session. A 3rd party cloud system (e.g., Amazon Web Services, Microsoft Azure, and Google Cloud) may be used if these rules are met and the operating environment provides the same or additional level of security as the lab would provide for internal testing.” (Above appears after “… controlled by the vendor.”  and before “The tester SHALL have control (oversight)…”}

We have incorporated guidance for Algorithm testing and labeling in the CPU Equivalency section. As we are not using the trusted provider concept at this time I am closing this issue as resolved.


Implement auto registration hook

This PR Implement https://github.com/starlite-api/pydantic-factories/issues/115
Here I use init_subclass class method to auto-register created model factories.

@avihai-yosef  Looks great. Thanks a lot for your wok.
The only thing that is missing - docs. Would you please mention the new flag and its behaviour in the docs?

@avihai-yosef (cc @avihaiyosef ) sorry for bothering but do you still plan to update the docs?
If no I can take care of that and merge your code soon.

@avihai-yosef - implementation looks good. @jtraub is a maintainer, so his review is sufficent.

It will be hard to track which factory registers and where.

@avihai-yosef  I think we can move forward in short steps. Registering custom factories for models already covers a lot of cases.
If people will be using huge hierarchies or if they would want to use custom model factory only for parts of their hierarchies we can address that once we see actual use cases. Attempt to take care of such cases now might end up with over engineering on our side.
So my suggestion would be: merge this now, try to use in the real code and adjust internals + public API based on real feedback.

@jtraub good point, thanks for clarifying the advantages of short steps.
Can you please update the docs? if not I will try to get it by the end of the week.


ContentBlock auto generate CharacterList

Do you want to request a feature or report a bug?
Feature Request
What is the current behavior?
Currently when inserting a new ContentBlock into the ContentState, It appears that you need to generate the appropriate default CharacterList for the text set in the new block, otherwise the block text does not display. In order to work around this, I have used:
convertFromRaw(convertToRaw(contentState))

as the convert back from Raw generates the CharacterList.
Here is a jsfiddle highlighting the problem. there is one line of code commented out that is my convertToRaw and back again work around:
https://jsfiddle.net/v7o1h76d/
Let me know if there is something else i should be doing to insert the block that would get around this problem.
What is the expected behavior?
Preferably the default CharacterList would be auto generated when the ContentBlock instance is first created as part of its constructor.

Hi @camurai,
Thanks for this feature request. To give a bit more context, the way a ContentBlock is render it requires each character of the block text to have a matching CharacterMetadata.
On your above example you are providing an initial text to the ContentBlock creating without supplying a characterList. The default value for ContentBlock.characterList record is of Immutable.List(), so that means if you change your example to supply and empty string '' instead of "blargh" it will work as expected.
If you want to have blocks created with the string "blargh" you would have to build the characterList object, that could be done by creating an Immutable.List of CharacterMetadata.EMPTY that matches same length as initial string.
so for the object would look like:
new ContentBlock({
  key: newBlockKey,
  type: 'unstyled',
  type: 'unstyled',
  text: 'blargh',
  characterList: Immutable.List([
    CharacterMetadata.create(),
    CharacterMetadata.create(),
    CharacterMetadata.create(),
    CharacterMetadata.create(),
    CharacterMetadata.create(),
    CharacterMetadata.create(),
  ])
})

I have updated the your fiddle to show the above behaviour https://jsfiddle.net/v7o1h76d/2/

I also agree with you, we could do a better job on making easier to create ContentBlock, by  defaulting characterList to a List of CharacterMetadata.EMPTY that matches the size of the text passed.

Created a PR addressing this issue in here https://github.com/facebook/draft-js/pull/1472


Version 2 of Thoth.Json

Issue to track what will be done for v2.
Most of the works has been made into separate branch/PR. I am merging all the works and discussion into a single branch called v2 :)

[x] Improve message error by adding the jsonPath where the error failed feature/track_path
[x] Support Fable 2 #30
[x] Add auto encoder/decoder #30
[x] Remove pipeline style
[x] Add object builder pattern #34
[x] Reduce exception usage when possible and don't match all the exception #34
[ ] Rework the exposed API to the user Json.parse -> Result<'T, string> & Json.parseOrRaise -> 'T

Bonus

[ ] Explore, if we can use a record/tuple instead of passing 2 arguments to decoder for the path tracking. Because this generate a lot of curry/uncurry function
[ ] Try to reduce usage of unwrap, in the core library.

Both bonus point will not be implemented for Thoth.Json v2 release.
We are now focusing on releasing a stable version of the library. If this is needed we can still later deliver a new major/medium release.


fix: typo of queryBus

Fixed typo in FindUsers controller. They should be queryBus

already fixed in a new release


[NDS] Need for Speed - Most Wanted (Europe) car models are black

I suspect this is an issue with my highlight shading code


[Sugesstion] Ability to disable chat for unverifed users

I've added this functionaily here https://github.com/fais3000/nodebb-plugin-shoutbox/commit/f13605f4a29035abfe0db486a4ca065d8c606b5f


Missing Metric - kube_node_labels

Hello!
I am using version 0.7.3 of this helm chart.
There is a metric called kube_node_labels which should be published by the kube-state-metrics : https://github.com/kubernetes/kube-state-metrics/blob/main/docs/node-metrics.md .
This is my allowList for kube-state-metrics :
  kube-state-metrics:
    allowList:
    - kube_persistentvolumeclaim_status_phase
    - kube_persistentvolumeclaim_info
    - kube_pod_container_resource_requests
    - kube_pod_status_phase
    - kube_pod_status_reason
    - kube_job_status_succeeded
    - kube_job_status_active
    - kube_job_status_failed
    - kube_pod_container_resource_limits
    - kube_pod_container_resource_requests
    - kube_pod_container_status_waiting_reason
    - kube_pod_info
    - kube_deployment_metadata_generation
    - kube_statefulset_metadata_generation
    - kube_pod_annotations
    - kube_node.*

However, I don't seem to be receiving the metric kube_node_labels in Grafana. I am using Grafana Cloud* with the managed prometheus.
I have also tried adding the metric like this :
- kube_node_labels
But this doesn't seem to work either. Has anyone come across this before? I am sadly unsure how to go about resolving this currently.

@edas-smith to gather Kubernetes labels and annotations, in addition to adding the desired metrics to the KSM allow list as you have done, CLI arguments are also needed on the KSM deployment such as --metric-labels-allowlist.
The KSM helm chart has these values to support the above:

metricLabelsAllowlist
metricAnnotationsAllowList

You can see in this KSM helm deployment template that the CLI argument is added when these values are used here.
Those sub-chart values should be able to be used with the k8s-monitoring-helm chart like so:
# KSM labels and annotations example
metrics:
  kube-state-metrics:
    metricLabelsAllowlist:
      - namespaces=[k8s-label-1,k8s-label-n]

    metricAnnotationsAllowList:
      - pods=[k8s-annotation-1,k8s-annotation-n]

The nodes collector/resource is enabled by default, so you should be able to do something like:
metrics:
  kube-state-metrics:
    metricLabelsAllowlist:
      - nodes=[k8s-label-1,k8s-label-n]

I'd be interested to know how you get on - as it could be worth writing up an example about this use case.

@skl thanks so much for the quick response!
I have just looked into this ( if I understood the above correctly ).
I've added a couple labels seen here :
  kube-state-metrics:
    allowList:
    - kube_persistentvolumeclaim_status_phase
    - kube_persistentvolumeclaim_info
    - kube_pod_container_resource_requests
    - kube_pod_status_phase
    - kube_pod_status_reason
    - kube_job_status_succeeded
    - kube_job_status_active
    - kube_job_status_failed
    - kube_pod_container_resource_limits
    - kube_pod_container_resource_requests
    - kube_pod_container_status_waiting_reason
    - kube_pod_info
    - kube_deployment_metadata_generation
    - kube_statefulset_metadata_generation
    - kube_pod_annotations
    - kube_node.*
    metricLabelsAllowlist:
      - nodes=[workload-type, node.kubernetes.io/instance-type]

However, the metric still doesn't appear to be coming into Grafana. Am not entirely sure why this is.

@edas-smith Sorry, my fault. I've edited the example in my comment above to the correct helm values, it seems in this case kube-state-metrics: needs to be at the top level to pass values to the subchart. metrics.kube-state-metrics is used for the KSM scraping in this chart whereas the top level kube-state-metrics is the subchart itself.

Also, maybe remove the space after the comma? So:
metrics:
  kube-state-metrics:
    allowList:
    - kube_persistentvolumeclaim_status_phase
    - kube_persistentvolumeclaim_info
    - kube_pod_container_resource_requests
    - kube_pod_status_phase
    - kube_pod_status_reason
    - kube_job_status_succeeded
    - kube_job_status_active
    - kube_job_status_failed
    - kube_pod_container_resource_limits
    - kube_pod_container_resource_requests
    - kube_pod_container_status_waiting_reason
    - kube_pod_info
    - kube_deployment_metadata_generation
    - kube_statefulset_metadata_generation
    - kube_pod_annotations
    - kube_node.*

kube-state-metrics:
  metricLabelsAllowlist:
    - nodes=[workload-type,node.kubernetes.io/instance-type]

Apologies for the delay. @skl the above seems to have sorted this and now the metric is coming in! Thank you so much for your help on this, its greatly appreciated!

Great, glad to hear that you're seeing the node labels now! 🎉


Cleanup duplicate logic and refactor installations.js into InstallationsRouter.

Depends on #334.

Reuse duplicate logic instead of writing it twice
InstallationsRouter is a subclass of ClassesRouter and calls into super class methods

@drew-gross, what do you think about this approach over the custom function-based classes implementation that you have?
It's super clear what calls into what if we follow this approach.
Side-question - do we want/need to handle the same logic for body.keys/relations (redirectClassNameForKey) as for all other Classes?
Asking, 'for a friend', because we don't seem to do it right now.

This also works and is still pretty readable, although with no member variables the advantage having any type of classes, functional or not, seems pretty minimal. Calling super.handleFind doesn't seem any better than exporting a handleFind function from ClassRouter and calling 'ClassRouter.handleFind. I guess if you want to insert another subclass between ClassRouterandInstallationRouter` it could help, but an equivalent can also be arranged using standalone functions. As always I don't want to impose my personal style so even if this isn't the exact way I would write it, feel free to merge regardless :)


Internal Server Error on converting .docx to pdf

While converting attached file.docx Internal Server Error is returned by gotenberg.
Expected Behavior
the file should  be converted to pdf format, 1.pdf - is an example of converting this file using unoconv 0.7
Current Behavior
Internal Server Error is thrown
Steps to Reproduce (for bugs)
Send attached file on POST  '/convert/office' (waitTimeout is set to 30)
Logs (LOG_LEVEL="DEBUG")
{"level":"info","msg":"Gotenberg 6.3.1","op":"main","time":"2020-10-09T11:02:12Z","trace":"system"}
{"level":"debug","msg":"configuration: {maximumWaitTimeout:30 maximumWaitDelay:10 maximumWebhookURLTimeout:30 defaultWaitTimeout:10 defaultWebhookURLTimeout:10 defaultListenPort:3000 disableGoogleChrome:false disableUnoconv:false googleChromeIgnoreCertificateErrors:false logLevel:DEBUG rootPath:/ maximumGoogleChromeRpccBufferSize:104857600 defaultGoogleChromeRpccBufferSize:1048576}","op":"main","time":"2020-10-09T11:02:12Z","trace":"system"}
{"level":"debug","msg":"starting new Google Chrome headless process on port 9222...","op":"chrome.Start","time":"2020-10-09T11:02:12Z","trace":"system"}
{"level":"debug","msg":"executing command: google-chrome-stable --no-sandbox --headless --disable-dev-shm-usage --font-render-hinting=none --remote-debugging-port=9222 --disable-gpu --disable-translate --disable-extensions --disable-background-networking --safebrowsing-disable-auto-update --disable-sync --disable-default-apps --hide-scrollbars --metrics-recording-only --mute-audio --no-first-run","op":"xexec.LogBeforeExecute","time":"2020-10-09T11:02:12Z","trace":"system"}
{"level":"debug","msg":"waiting '500ms' for allowing Google Chrome to warmup","op":"chrome.warmup","time":"2020-10-09T11:02:12Z","trace":"system"}
{"level":"debug","msg":"[1009/110212.805581:ERROR:bus.cc(393)] Failed to connect to the bus: Failed to connect to socket /var/run/dbus/system_bus_socket: No such file or directory","op":"stderr.google-chrome-stable.--no-sandbox.--headless.--disable-dev-shm-usage.--font-render-hinting=none.--remote-debugging-port=9222.--disable-gpu.--disable-translate.--disable-extensions.--disable-background-networking.--safebrowsing-disable-auto-update.--disable-sync.--disable-default-apps.--hide-scrollbars.--metrics-recording-only.--mute-audio.--no-first-run","time":"2020-10-09T11:02:12Z","trace":"system"}
{"level":"debug","msg":"DevTools listening on ws://<IP_ADDRESS>:9222/devtools/browser/e9b86f68-ca2f-43ff-8ac4-c5e6a5633fc4","op":"stderr.google-chrome-stable.--no-sandbox.--headless.--disable-dev-shm-usage.--font-render-hinting=none.--remote-debugging-port=9222.--disable-gpu.--disable-translate.--disable-extensions.--disable-background-networking.--safebrowsing-disable-auto-update.--disable-sync.--disable-default-apps.--hide-scrollbars.--metrics-recording-only.--mute-audio.--no-first-run","time":"2020-10-09T11:02:12Z","trace":"system"}
{"level":"debug","msg":"checking Google Chrome headless process viability via endpoint 'http://localhost:9222/json/version'","op":"chrome.IsViable","time":"2020-10-09T11:02:13Z","trace":"system"}
{"level":"debug","msg":"Google Chrome headless is viable as endpoint returned '\u0026{HeadlessChrome/85.0.4183.102 1.3 Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/85.0.4183.102 Safari/537.36 <IP_ADDRESS> 537.36 (@ffe848af6a5df4fa127e2929331116b7f9f1cb30)  ws://localhost:9222/devtools/browser/e9b86f68-ca2f-43ff-8ac4-c5e6a5633fc4}'","op":"chrome.IsViable","time":"2020-10-09T11:02:13Z","trace":"system"}
{"level":"info","msg":"http server started on port '3000'","op":"main","time":"2020-10-09T11:02:13Z","trace":"system"}
{"level":"debug","msg":"resource directory 'ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8' created","op":"resource.New","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"skipping 'Content-Type' as it is not a custom HTTP header...","op":"resource.Resource.WithCustomHTTPHeader","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"skipping 'Connection' as it is not a custom HTTP header...","op":"resource.Resource.WithCustomHTTPHeader","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'resultFilename' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'waitTimeout' with value '30' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'webhookURL' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'webhookURLTimeout' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'remoteURL' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'waitDelay' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'paperWidth' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'paperHeight' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'marginTop' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'marginBottom' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'marginLeft' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'marginRight' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'landscape' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'pageRanges' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'googleChromeRpccBufferSize' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"added 'scale' with value '' to resource args","op":"resource.Resource.WithArg","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"resource file '50b489b0-d951-4f17-bdc5-c85d962df33b.docx' created","op":"resource.Resource.WithFile","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"handling Office request...","op":"xhttp.officeHandler","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"no 'webhookURL' found, converting synchronously","op":"xhttp.convert","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"options: {WaitTimeout:30 Landscape:false PageRanges:}","op":"printer.logOptions","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"creating context with '30.00s' of timeout...","op":"xcontext.WithTimeout","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"converting '/gotenberg/tmp/ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8/50b489b0-d951-4f17-bdc5-c85d962df33b.docx' to PDF...","op":"printer.officePrinter.Print","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"executing command: unoconv --user-profile ///tmp/NiUvdLHcBp13tWERmFosvKxhmvL5cSpI --port 43167 --format pdf --output /gotenberg/tmp/ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8/0HbElTySaj33322yxPyvOGaZdaKKkwZTw.pdf /gotenberg/tmp/ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8/50b489b0-d951-4f17-bdc5-c85d962df33b.docx","op":"xexec.LogBeforeExecute","time":"2020-10-09T11:02:17Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"unoconv: UnoException during import phase:","op":"stderr.unoconv.--user-profile.///tmp/NiUvdLHcBp13tWERmFosvKxhmvL5cSpI.--port.43167.--format.pdf.--output./gotenberg/tmp/ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8/0HbElTySaj33322yxPyvOGaZdaKKkwZTw.pdf./gotenberg/tmp/ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8/50b489b0-d951-4f17-bdc5-c85d962df33b.docx","time":"2020-10-09T11:02:22Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"The document 'file:///gotenberg/tmp/ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8/50b489b0-d951-4f17-bdc5-c85d962df33b.docx' could not be opened.","op":"stderr.unoconv.--user-profile.///tmp/NiUvdLHcBp13tWERmFosvKxhmvL5cSpI.--port.43167.--format.pdf.--output./gotenberg/tmp/ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8/0HbElTySaj33322yxPyvOGaZdaKKkwZTw.pdf./gotenberg/tmp/ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8/50b489b0-d951-4f17-bdc5-c85d962df33b.docx","time":"2020-10-09T11:02:22Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"command 'unoconv --user-profile ///tmp/NiUvdLHcBp13tWERmFosvKxhmvL5cSpI --port 43167 --format pdf --output /gotenberg/tmp/ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8/0HbElTySaj33322yxPyvOGaZdaKKkwZTw.pdf /gotenberg/tmp/ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8/50b489b0-d951-4f17-bdc5-c85d962df33b.docx' finished","op":"xexec.Run","time":"2020-10-09T11:02:22Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"error","msg":"exit status 5","op":"xhttp.officeHandler: xhttp.convertSync: printer.officePrinter.Print: printer.unoconv: xexec.Run","time":"2020-10-09T11:02:22Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"level":"debug","msg":"resource directory '/gotenberg/tmp/ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8' removed","op":"resource.Resource.Close","time":"2020-10-09T11:02:22Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8"}
{"bytes_in":"0","bytes_out":"79","host":"localhost:3000","latency":"4149971215","latency_human":"4.149971215s","level":"error","method":"POST","msg":"request failed","op":"context.Context.LogRequestResult","path":"/convert/office","referer":"","remote_ip":"<IP_ADDRESS>","status":500,"time":"2020-10-09T11:02:22Z","trace":"ILHwmsytMKyeRGNaZJvYNKurp4H6LUD8","uri":"/convert/office","user_agent":""}
Your Environment

Gotenberg 6.3.1
Ubuntu 16.04 (also reproduced in fargate cluster)
Looks like issue is related to comment in header.

I ran into the same issue, created a new docker image with LibreOffice 7.1 which solved the issue.


duplicating psk hint and psk key.

Duplicating string pointers. Or else this will result in double free crash. These pointers are freed later.

Will fix the CLA warning. I had already signed Eclipse CLA.

Closing for ip-validation error.


Condensed Viewer Setting

Closes #734

Coverage remained the same at 100.0% when pulling 61242cba47d655105c0527f401c17612937bc362 on condensed_viewer into 0a1c7d31713cdd585a75974839a8312175af00a7 on master.

screenshot?

@hackmastera I did, we don't send model or change set information to Pomegranate, and there's no way for it to tell what kind of viewing experience it's about to generate even. This seemed like an easy compromise. If we start wanting to display a different (condensed vs not) experience for material, that seems like maybe something we can configure in Figgy down the line?

New:

Old:


Merge branch 1.2.0 to develop

LGTM

LGTM

Please resolver conflicts in README.md

Please resolver conflicts in README.md

expect this version

expect this version


Breaks with eleventyComputed.js

Bit of a bizarre bug, but eleventy-sass seems to break whenever I have a global eleventyComputed.js file present. It can be the simplest export like:
module.exports = {
  test: {
    foobar: 'test',
  },
};

Then eleventy-sass will break with the following message after I run:
DEBUG=*EleventySass* npx @11ty/eleventy --watch --serve --port=8080

  Dev:EleventySass getCacheKey(contents, ./src/assets/css/styles.scss) -> src/assets/css/styles.scss2022-08-09T04:14:53.746Zinitial +0ms
  Dev:EleventySass getCacheKey(contents, ./src/assets/css/styles.scss) -> src/assets/css/styles.scss2022-08-09T04:14:53.746Zinitial +26ms
  Dev:EleventySass getCacheKey(contents, ./src/assets/css/styles.scss) -> src/assets/css/styles.scss2022-08-09T04:14:53.746Zinitial +0ms
  Dev:EleventySass getCacheKey(contents, ./src/assets/css/styles.scss) -> src/assets/css/styles.scss2022-08-09T04:14:53.746Zinitial +6ms
[11ty] Problem writing Eleventy templates:
[11ty] 1. Having trouble rendering scss template ./src/assets/css/styles.scss (via TemplateContentRenderError)
[11ty] 2. Having trouble compiling template ./src/assets/css/styles.scss (via TemplateContentCompileError)
[11ty] 3. expected "{".
[11ty]   ╷
[11ty] 1 │ test
[11ty]   │     ^
[11ty]   ╵
[11ty]   src/assets/css/styles.scss 1:5  root stylesheet (via Error)
[11ty] Wrote 0 files in 1.29 seconds (v1.0.1)

If I remove eleventy-sass by removing eleventyConfig.addPlugin(eleventySass);, then everything compiles fine again.
Using global data from json files, works fine.
I have it reproduced here: https://github.com/DannyJoris/eleventy-sass-bug

I can work around the issue easily by changing the format: _data/test.js:
module.exports = {
  foobar: 'test',
};

Perhaps it doesn't make sense to use eleventyComputed.js globally anyways? Either way I'll leave this issue open just in case.

Thank you very much for filing the issue and providing a minimal project.
I briefly investigated it and am guessing that it is a bug ( or a spec) in Eleventy.
If you have eleventyComputed.js file, Eleventy will get computed data before rendering templates.
And here is the source of this bug:
https://github.com/11ty/eleventy/blob/0bbc16dfc03eb773de33488dd1c7b1bb37f701be/src/Template.js#L532-L563
If you have the following eleventyComputed.js:
module.exports = {
  test: {
    foobar: () => 'test',
  },
};

Eleventy executes L535 and won't crash, because the value of test.foobar is a function.
https://github.com/11ty/eleventy/blob/0bbc16dfc03eb773de33488dd1c7b1bb37f701be/src/Template.js#L535
However, if you have the following eleventyComputed.js:
module.exports = {
  test: {
    foobar: 'test',
  },
};

Eleventy executes L551-L558, because the value of test.foobar is of type String.
https://github.com/11ty/eleventy/blob/0bbc16dfc03eb773de33488dd1c7b1bb37f701be/src/Template.js#L551-L558
In L551-L588, Eleventy calls this.renderComputedData(), and renderComputedData() calls _renderFunction() with 'test', the value of test.foobar, as its argument.
https://github.com/11ty/eleventy/blob/0bbc16dfc03eb773de33488dd1c7b1bb37f701be/src/TemplateContent.js#L356-L359
In short, eleventy-sass tried to compile 'test', the value of test.foobar, (and failed) as if it is a Sass/SCSS file content.
I'm not sure why Eleventy was implemented like that, but making properties in eleventyComputed.js have function values should work.

To be honest, Eleventy ought to fix the issue, but I fixed it in the plugin.
https://github.com/kentaroi/eleventy-sass/commit/93e3123e80092e95d18e5e6af30965956c480fd5
The fix was just published as v2.1.2.


Custom attributes don't work.

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions
2.0.1
Link to runnable example
No response
Steps to reproduce
Trying to set custom attributes on the element doesn't work
data.hName = 'div';
data.hProperties = {
  id: 'something',
  className: 'something',
  class: 'something',
  src: 'something',
};

Expected behavior

Actual behavior

Runtime
Node v14
Package manager
yarn v2
OS
macOS
Build and bundle tools
Rollup

There’s not enough information provided and, when asked, you did not provide more. Perhaps you’ve already solved it. Closing as this can’t be acted on.


Painless script error is being ignored and only an empty result is returned

I ran into an issue when upgrading from Elasticsearch 2.4 to 5.6. After converting my script to painless I thought I was good to go. No errors were being thrown. But then my tests failed.
When looking into it, calling model.__elasticsearch__.search(query).records.to_a (or results.to) would yield an empty result.
This didn't make much sense. If I ran the exact same query via curl, I was presented with the error:
{
   "took": 2,
   "timed_out": false,
   "_shards": {
      "total": 5,
      "successful": 3,
      "skipped": 0,
      "failed": 2,
      "failures": [
         {
            "shard": 2,
            "index": "test_items",
            "node": "pjJKI22DTySkXt8w0AzbgA",
            "reason": {
               "type": "script_exception",
               "reason": "runtime error",
               "script_stack": [
                  "org.elasticsearch.index.mapper.TextFieldMapper$TextFieldType.fielddataBuilder(TextFieldMapper.java:336)",
                  "org.elasticsearch.index.fielddata.IndexFieldDataService.getForField(IndexFieldDataService.java:111)",
                  "org.elasticsearch.search.lookup.LeafDocLookup$1.run(LeafDocLookup.java:84)",
                  "org.elasticsearch.search.lookup.LeafDocLookup$1.run(LeafDocLookup.java:81)",
                  "java.security.AccessController.doPrivileged(Native Method)",
                  "org.elasticsearch.search.lookup.LeafDocLookup.get(LeafDocLookup.java:81)",
                  "org.elasticsearch.search.lookup.LeafDocLookup.get(LeafDocLookup.java:36)",
                  "if (doc['aasm_state'].value != 'for_sale') {            ",
                  "        ^---- HERE"
               ],
               "script": "          double new_score = _score;          if (doc['aasm_state'].value != 'for_sale') {            new_score = new_score * 0.01;          }          if (doc['bids_count'].value == 1) {            new_score = new_score * 1.10;          }          return new_score;        ",
               "lang": "painless",
               "caused_by": {
                  "type": "illegal_argument_exception",
                  "reason": "Fielddata is disabled on text fields by default. Set fielddata=true on [aasm_state] in order to load fielddata in memory by uninverting the inverted index. Note that this can however use significant memory. Alternatively use a keyword field instead."
               }
            }
         }
      ]
   },

Why are errors no longer throwing exceptions in rails? Instead they're just ignored?

Hi, what is the HTTP status returned from Elasticsearch? If it's anything above 299 it should definitely raise a Ruby exception...

Closing this as it is out-of-date.


Error parsing non-alphanumeric property name

If returned object has non-alphanumeric character in the highest level property names, cannot parse property name correctly. E.g. if returned data is like:
{
	"bustime-response": {
		......

then {{bustime-response}} will return error, as it's not a valid JavaScript variable name.
Possible solution: wrap the returned context in a "data" property, then pass to handlebar as context.

Not a bug.


Add products to the order email

Add the details of the products to the email, for example

@erickcernarequejo - can i work on it? Please assign this issue to me

@erickcernarequejo - can i work on it? Please assign this issue to me

Create a new issue if you want to improve what is indicated to assign you


256 move hold note position

Closes #256

A note about the expected pipeline checks - my pending PR renamed some of the pipelines so you may have to merge those workflow changes into your branch.

A note about the expected pipeline checks - my pending PR renamed some of the pipelines so you may have to merge those workflow changes into your branch.

Oh ok

Can you take a look at why there's another branch with different casing? If the other branch isn't needed, you can delete it.

I'd say with how jank the selection is, we probably shouldn't merge this in right now until that's more polished. The IsFlaggedToToggleSelection seems a bit wack, and not working completely as intended. What do you think would be needed to refactor this more correctly?

Can you take a look at why there's another branch with different casing? If the other branch isn't needed, you can delete it.

Lol I think I made that on accident somehow. Deleted

I'd say with how jank the selection is, we probably shouldn't merge this in right now until that's more polished. The IsFlaggedToToggleSelection seems a bit wack, and not working completely as intended. What do you think would be needed to refactor this more correctly?

I think refactoring SelectToolState would be needed to make this more polished. Currently holdNote anchors are the only objects using onClick selection and handling its deselection with SelectToolState is kind of jank. The main problem right now is when user selects note, then tries to select tail anchor, SelectToolState deselects the note which makes the anchor disappear since it doesn't know it's trying to click on an anchor.

I'd say with how jank the selection is, we probably shouldn't merge this in right now until that's more polished. The IsFlaggedToToggleSelection seems a bit wack, and not working completely as intended. What do you think would be needed to refactor this more correctly?

I think refactoring SelectToolState would be needed to make this more polished. Currently holdNote anchors are the only objects using onClick selection and handling its deselection with SelectToolState is kind of jank. The main problem right now is when user selects note, then tries to select tail anchor, SelectToolState deselects the note which makes the anchor disappear since it doesn't know it's trying to click on an anchor.

I see. I'd rather have bug free behavior rather than feature completion. In this case, what about just keeping the hold anchors always visible for now?

I'd say with how jank the selection is, we probably shouldn't merge this in right now until that's more polished. The IsFlaggedToToggleSelection seems a bit wack, and not working completely as intended. What do you think would be needed to refactor this more correctly?

I think refactoring SelectToolState would be needed to make this more polished. Currently holdNote anchors are the only objects using onClick selection and handling its deselection with SelectToolState is kind of jank. The main problem right now is when user selects note, then tries to select tail anchor, SelectToolState deselects the note which makes the anchor disappear since it doesn't know it's trying to click on an anchor.

I see. I'd rather have bug free behavior rather than feature completion. In this case, what about just keeping the hold anchors always visible for now?

Yea that sounds good. I'll revert to commit b2dcc3e


💡 Bump DBSync versions to <IP_ADDRESS>

Area
Other
Is there new design needed?
No
What?
Bump all DBSync versions to <IP_ADDRESS> to align good with the 9.1.1 node hotfix
Why?
To make sure that the app stays healthy after the hot fix has been applied to the node
How?
Upgrade version
https://github.com/IntersectMBO/cardano-db-sync/releases/tag/<IP_ADDRESS>
(Optional) User Story with acceptance criteria
No response

We will bump SanchoNet instances first, check the utxo_view table to make sure it looks good


Broken link to JavaLite Repo

Hi, there is broken link to JavaLite Repo here:

http://javalite.io/activejdbc#getting-latest-snapshot-versions

If you are not using Maven, you can pull down the latest snapshots from here: JavaLite Repo

That is tiny detail but should be fixed :-D
Best regards,
Ondrej

@Typografikon  thanks for catching, fixed. By the way, site content is here: https://github.com/javalite/site-content
feel free to send pull requests.

site content is here: https://github.com/javalite/site-content

Thanks you fix it and also point me to site content repo.


plen可否设置范围

您好老师，软件非常好用，另外请问一下引物设计的长度能否设置成一个范围区间，并且F和R引物范围可以使用者自行设置，谢谢。

引物长度暂时不可以设置范围，但可以使用循环调用其中的引物设计命令，不过需要一点linux背景。
---- 回复的原邮件 ----
发件人  @.> 日期  2023年11月28日 00:12 收件人  @.> 抄送至  @.***> 主题  [joybio/multiPrime] plen可否设置范围 (Issue #7)
您好老师，软件非常好用，另外请问一下引物设计的长度能否设置成一个范围区间，并且F和R引物范围可以使用者自行设置，谢谢。
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

@Eager144000
Dear Eager144000,
"Plens" does not support range input, and I've received inquiries about this limitation via email. It's important to note that extending "Plen" might result in decreased coverage. Nevertheless, if you insist on using it, there's a workaround: you can utilize the script scripts/multiPrime-core.py to calculate each Plen output. Use the bash command cat to merge all the outputs and then run scripts/get_multiPrime.py independently.
Alternatively, for users with a limited cluster, consider using our new GUI-based multiPrime available at https://github.com/joybio/multiPrime2-GUI or the web-based version at https://multiprime.cn/. Both the web-based and GUI-based versions not only encompass the multiPrime primer design module but also house an enhanced version, multiPrime2, which is presently in the testing phase.Please be aware that the web-based version may have limitations due to high usage, so I recommend opting for the GUI-based multiPrime. You can explore the web-based version at a later time.
Thank you for your understanding and cooperation.
Best,
Junbo

您好老师，软件非常好用，另外请问一下引物设计的长度能否设置成一个范围区间，并且F和R引物范围可以使用者自行设置，谢谢。

I intend to enhance this function in the near future, and the updated version will be featured in the next version of multiPrime2.

引物长度暂时不可以设置范围，但可以使用循环调用其中的引物设计命令，不过需要一点linux背景。
…
---- 回复的原邮件 ---- 发件人 @.> 日期 2023年11月28日 00:12 收件人 @.> 抄送至 @.> 主题 [joybio/multiPrime] plen可否设置范围 (Issue #7) 您好老师，软件非常好用，另外请问一下引物设计的长度能否设置成一个范围区间，并且F和R引物范围可以使用者自行设置，谢谢。 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.>

感谢回复，考虑过循环的问题，但目前版本不能分别选择F和R的长度，会缺少很多选择。

您好老师，软件非常好用，另外请问一下引物设计的长度能否设置成一个范围区间，并且F和R引物范围可以使用者自行设置，谢谢。

I intend to enhance this function in the near future, and the updated version will be featured in the next version of multiPrime2.

I'm looking forward to it. Thank you. By the way,I'm doing PCR design for viral targets. If you are also interested in , can we have a  deep communication?


Update README.md

We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:

Follow the commit message conventions found here.
Provide a descriptive summary for your changes.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Add inline code comments to changes that might not be obvious.
Squash your commits as you keep adding changes.
Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

This PR  triggered this build in this execution, please merge to master only if this succeeds:  https://spin.prod..opsmx.com/#/applications/gitprtrigger/executions/details/01F99BPB6Q864MRP3ED1XK2X8H

RunTestJar RESULT: Total tests run: 314, Failures: 7, Skips: 0 Reviewers , please check that the changes in this PR did not cause the failures in  http://jenkins.opsmx.net:8181/jenkins/job/Dev-run-tests-on-gitpr-parallel/ws/emailable-report-480.html


Revamp client

This is a placeholder for what I expect to be a large PR with many interdependent aspects, effectively ripping the client apart and reassembling better.

[x] Remove vestigial path parameter. (This information is superseded by item).
[ ] Factor authenticaiton logic from Context into a separate httpx.Auth subclass.
[ ] Factor caching and offline ("airplane mode") logic into the transport layer, and rethink caching. More planning notes here: https://github.com/bluesky/tiled/issues/281
[ ] Make async varieties of the client objects. This is a good thing to have in general in 2022, but in particular there is evidence it may unlock better throughput on batch downloading.
[x] https://github.com/bluesky/tiled/issues/288
[ ] Simplify constructors, perhaps adding from_app as reusable intermediary.

Superseded by #346. Two items in the check list above still need to be addressed (#116 and #281) but they will be handled in separate PRs.