Lost file history

Version confirmation

[X] Confirm

Following prerequisites

[X] Confirm

Neovim version
NVIM v0.8.3
Operating system/version
Arch Linux
Terminal name/version
Alacritty
$TERM environment variable
No response
Branch info
main (Default/Latest)
Fetch Preferences
HTTPS (use_ssh = false)
How to reproduce the issue
Open and close some files
Expected behavior
Telescope oldfiles list all files just opened
Actual behavior
Only show the last one file
Additional information
No response

Cannot reproduce.
Can u provide a detailed repro? You may use a pseudonym instead of a real filename (e.g., use A.lua instead of init.lua)

Example:

Use Telescope to open ./A.lua
Then use nvim-tree to open ./A/B.txt
Close ./A/B.txt
Telescope oldfiles shows only one of the files (i.e., ./A.lua)

I just find it's not relevant to telescope since
:oldfiles

only list
1: /home/rok/Dashboard-1
2: /home/rok/[Wilder Float 0]
3: /home/rok/[Wilder Float 1]

So you mean Telescope oldfiles didn't list the files opened in previous nvim instances? Then this is exactly how it works - providing file access within the current process, which is often used to reopen previously opened files by scanning all available buffers.
But FYI, the implementation of :oldfiles is actually somewhat different from that of Telescope oldfiles:
						*:o* *:ol* *:oldfiles*
:o[ldfiles]		List the files that have marks stored in the ShaDa
			file.  This list is read on startup and only changes
			afterwards with `:rshada!`.  Also see |v:oldfiles|.
			The number can be used with |c_#<|.
			The output can be filtered with |:filter|, e.g.:
				filter /\.vim/ oldfiles
			The filtering happens on the file name.

:oldfiles uses the so-called ShaDa file (usually located under cd ~/.local/state/nvim/shada/) to read your file history. To make your changes available, please use the :rshada! command before invoking :oldfiles (but that is not recommended.) By default we write the ShaDa file only when leaving nvim to avoid unnecessary IO overheads:
https://github.com/ayamir/nvimdots/blob/7f1b6b04e0405dd63d60c79d222613820970a1ee/lua/core/event.lua#L109-L114
Using Telescope, frecency may be the actual command you are looking for:
https://github.com/ayamir/nvimdots/blob/7f1b6b04e0405dd63d60c79d222613820970a1ee/lua/keymap/tool.lua#L117-L122

So you mean Telescope oldfiles didn't list the files opened in previous nvim instances? Then this is exactly how it works - providing file access within the current process, which is often used to reopen previously opened files by scanning all available buffers.
But FYI, the implementation of :oldfiles is actually somewhat different from that of Telescope oldfiles:
						*:o* *:ol* *:oldfiles*
:o[ldfiles]		List the files that have marks stored in the ShaDa
			file.  This list is read on startup and only changes
			afterwards with `:rshada!`.  Also see |v:oldfiles|.
			The number can be used with |c_#<|.
			The output can be filtered with |:filter|, e.g.:
				filter /\.vim/ oldfiles
			The filtering happens on the file name.

:oldfiles uses the so-called ShaDa file (usually located under ~/.local/state/nvim/shada/) to read your file history. To make your changes available, please use the :rshada! command before invoking :oldfiles (but that is not recommended.) By default we write ShaDa file only when leaving nvim to avoid unnecessary IO overheads:
https://github.com/ayamir/nvimdots/blob/7f1b6b04e0405dd63d60c79d222613820970a1ee/lua/core/event.lua#L109-L114
Using Telescope, frecency may be the actual command you are looking for:
https://github.com/ayamir/nvimdots/blob/7f1b6b04e0405dd63d60c79d222613820970a1ee/lua/keymap/tool.lua#L117-L122

Thank you! I have found the code block that was causing my issue at https://github.com/ayamir/nvimdots/blob/7f1b6b04e0405dd63d60c79d222613820970a1ee/lua/core/event.lua#L109-L114. It was actually deleting my shada everytime(why ?), which I assume is the cause of the problem. After commenting out the block, the :oldfiles command worked correctly.
However, I am still facing issues with Telescope e frecency, which only shows one file. Additionally, the output of Telescope oldfiles is the same as :oldfiles. I am concerned that this indicates a problem with my shada or config. Can you suggest any solutions?

I have found the code block that was causing my issue at ...

What do you see when manually executing :wshada!?

... which only shows one file

Is your filepath in the ignore list?
https://github.com/ayamir/nvimdots/blob/7f1b6b04e0405dd63d60c79d222613820970a1ee/lua/modules/configs/tool/telescope.lua#L14
https://github.com/ayamir/nvimdots/blob/7f1b6b04e0405dd63d60c79d222613820970a1ee/lua/modules/configs/tool/telescope.lua#L41

:wshada show nothing while :shada! ruin my :oldfiles...

As for the telescope frequency, it does not know all the files we opened since it was may or may not load when we edit a file…
Do you think we should change this behavior?

It seems that it works as expected… Is there any reason to use ! version instead of without !?

That is intentional, as ShaDa file should be written only on exit. Otherwise, you also need :rshada! to retrieve the data.
But updating any ShaDa files while nvim is running is never the intended design pattern (ShaDa files enables you to continue where you left off, rather than to perform some operations while editing):
:h shada

If you exit Vim and later start it again, you would normally lose a lot of
information.  The ShaDa file can be used to remember that information, which
enables you to continue where you left off.

To be short, it's best not to use commands related to cache files (like ShaDas) while editing.

So the problem should be related to telescope. Can you provide a minimum repro(https://github.com/ayamir/nvimdots/issues/612#issuecomment-1494367647)? I cannot reproduce this issue on macOS.

As for the telescope frequency, it does not know all the files we opened since it was may or may not load when we edit a file…

I can't quite understand this, can you clarify this a bit?

In order to clarify any potential misunderstandings, when utilizing the ":wsh" command to save a file, the previous shada file is first read, thus causing it to operate akin to the ">>" function in a shell. Conversely, ":wsh!" does not read the old shada file and behaves more similarly to ">" in a shell. This has the consequence that the ":oldfiles" command does not contain files previously opened in other neovim instance, which appears somewhat counterintuitive and deviates from Neovim's default behavior.

Yep, but since file IO is performed during VimLeave, it will not have any impact on :oldfiles. The next time you open nvim, that file will be read correctly. What problem do you want to address?

In our setup, the telescope is lazily loaded. Therefore, if a file is opened without calling the telescope, it will not be recorded in the frequency. For example:

nvim a.py
Quit nvim and reopen it.
Call :Telescope and then use :e to open any file.
In this scenario, the later file will appear in the telescope frequency's record of opened files, while the first file will not.

Yep, but since file IO is performed during VimLeave, it will not have any impact on :oldfiles. The next time you open nvim, that file will be read correctly. What problem do you want to address?

You mean :oldfiles would still list all the files we opened since we install it?

If we use :wsh, then the ShaDa file will grow infinitely as we are always appending to that file. So an alternative,Telescope frecency was introduced to address the problem where file history cannot be recorded.

If we use :wsh, then the ShaDa file will grow infinitely as we are always appending to that file. So an alternative,Telescope frecency was introduced to address the problem where file history cannot be recorded.

Okay..now I get it

In our setup, the telescope is lazily loaded. Therefore, if a file is opened without calling the telescope, it will not be recorded in the frequency. For example:

nvim a.py
Quit nvim and reopen it.
Call :Telescope and then use :e to open any file.
In this scenario, the later file will appear in the telescope frequency's record of opened files, while the first file will not.

Yep, that's why:

This is exactly how it works - providing file access within the current process, which is often used to reopen previously opened files by scanning all available buffers.

Note that Telescope oldfiles only provides file access within the current process.

Yep, but this way, main.shada will grow very quickly. If your editing workload is significant, main.shada will increase by ~1GB in a very short period of time.
The claim "Telescope oldfiles only provides file access within the current process" is based entirely on this configuration, which assumes calling :wsh! when exiting 😄

And if we are expected to use telescope frequency as a better alternative to :oldfiles, wouldn't it be better to have it automatically record every time we open a file? So it won't miss any files.
And this is a bit uncessary to me since vim already offer an option to avoid
then the ShaDa file will grow infinitely

by
shada=1000,<50,s10,h

and we already set it?

Oh, I see what you're saying. Previously, these were two separate features. Telescope frecency focuses on searching the dedicated database (i.e., for files that have been opened in different nvim instances), while Telescope oldfiles focuses on managing files that were opened in the current session.
Yep IMO we can integrate these features before the next release. I will propose a draft PR perhaps later today 👍 This might require further discussion.


[Semver-Minor] Adds named exports for UNIT constants

Added exporting of the unit constants MINUTE, DAY, WEEK, etc. as named exports for re-use inside of client code, especially useful in custom formatters, or general re-use by dependent projects. (Otherwise these constants have to be redefined in each consuming project).
This could then be imported like so:
import TimeAgo, { HOUR, MINUTE, SECOND } from 'react-timeago';

Because these are constants, the values cannot be redefined and cause unintended behavior in the application. This is not a breaking change: existing consumers would notice no changes since there are currently no named exports. I am open to discussion on this pull request, because I think there ought to be some re-use provided to consumers in their custom formatters. Another option would be to export Unit or something like that so consumers don't have to specifically name each constant they want to export.

look good enough.


Build

Hi,
Technical Details:
XCode : 13.4.1
MacOS : 12.3 (Monterey)
Chipset: M1
I am referencing the package and getting following exception :
Begin Trace
Undefined symbols for architecture arm64:
"_iota_send_message", referenced from:
IOTAWallet.WalletEventsManager.sendCommand(id: Swift.String, cmd: Swift.String, payload: Any?, callback: (Swift.String) -> ()) -> () in IOTAWallet.o
"_iota_destroy", referenced from:
IOTAWallet.WalletEventsManager.stop() -> () in IOTAWallet.o
"_iota_initialize", referenced from:
IOTAWallet.WalletEventsManager.start(storagePath: Swift.String) -> () in IOTAWallet.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
End of Trace
Please note, this is M1 chipset based Macbook. Would really appreciate if somebody can provide some sort of clarity or point to some documentation with steps to reference it correctly and also confirm if M1 based Macbook supports this. I am also attaching a screenshot of the issue. We have tried following this post for resolving this linker exception (https://stackoverflow.com/questions/19213782/undefined-symbols-for-architecture-arm64)

Hi, thanks for your message.
As stated here, that architecture is not shipped into the xcframework yet.
A temporary workaround is to open Xcode using Rosetta, it will compile for x86-64 (iOS simulator) instead.
If my reply fixes the issue (and I think it does, please close the issue. Thanks.

Hi Pascal,
Thank you for the detail. It was helpful and we were able to build the app by launching Xcode using Rosetta. Appreciate your swift response and active feedback. I am closing the issue and for reference sharing a helpful link to launch Xcode using Rosetta for others that come upon this thread.
https://community.appdynamics.com/t5/Knowledge-Base/How-do-I-run-the-iOS-simulator-on-my-M1-based-Mac/ta-p/46825


Implement floats

Floating-point support must be implemented. This will imply:

a rule set for mixed-type expressions (integers auto promoted to floats?)
rewrite the INPUT statement to allow floats
rewrite PRINT and TEXTAT to support floats
type definition for built-in functions
procedures that accept parameters will be required to define parameter types

Must decide:

the actual floating point type (single, double, excess-128?)

Moved to Version 2.0


Making the graph/canvas fullscreen

Expected Behavior
When the graph parent container is made full screen the graph should expand to the new width and height set
Current Behavior
When the graph parent container is made full screen the graph retains its original width and height

    <div
       :style="{
                width: `${isFullscreen ? '100vw - 1px' : 'calc(100vw - 420px)'}`,
                height: `${isFullscreen ? '100vh - 1px' : 'calc(100vh - 150px)'}`,
            }"
        ref="graphContainer"
     >

// when the fullscreen button is clicked this function gets called ... the container ref is passed to it
const fullscreen = (targetEle) => {
       isFullscreen.value = !isFullscreen.value
        targetEle.value.requestFullscreen()
}

Or is there a better way to make the graph fullscreen .... can't find a fullscreen implementation anywhere
Awesome library by the way

A suggestion is to provide a method on the graph if there is no existing way to do it
const height: number = 800
const width: number = 800

graph.updateHeight(height)
graph.updateWidth(width)

A suggestion is to provide a method on the graph if there is no existing way to do it
const height: number = 800
const width: number = 800

graph.updateHeight(height)
graph.updateWidth(width)

graph.size(width, height)

try this?

@e6vk4 you can use graph.resize(width, height)


[GSProcessing] Re-use node mappings when edge is homogeneous.

Also remove re-partitions that might not be needed.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#3  👈
#2
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @thvasilo and the rest of your teammates on  Graphite


MAXIMUM PRODUCT SUBARRAY

Problem Link
https://leetcode.com/problems/maximum-product-subarray/
Coding platform
Leetcode
Programming language

[ ] C
[x] C++
[ ] Java
[ ] Python
[ ] JavaScript

Additional context (OPTIONAL)
This is a good problem that helps in building a foundation in DP.

proceed!


Extend Abracadabra Subgraph to use v2.0.1

This PR attempts to extend Abracadabra Subgraph to support schema version > 2.0.0
Currently: 2.0.1

Everything looks good other than above. After you are done with the changes, would you be able to rename this abracadabra-ext while maintaining the 1.3.0 version as abracadabra? We want to maintain both versions going forward


make transcript isoform IDs usable

Well, it looks like it's time to revive the issue of using transcript isoform IDs (not needed back when #236 was open). As noted in the Canto ticket and website ticket, we now have actual examples where either an annotation or an extension is specific for a transcript isoform.
On the website, info seems to appear only for one transcript; in the tco1 example, it's got the product for the longest transcript but qualitative expression for the shorter (maybe because the shorter one comes first in the contig file??).
In Canto I've stuck some notes about isoform specificity in comments for a few wtf annotations, because I can't add transcript-specific IDs to the gene list. For extensions, these warnings now crop up in the Canto log:
warning in fd7d19b1aed14f7c: in annotation extension for fd7d19b1aed14f7c-genotype-1, can't parse identifier: SPAC17G6.02c.2
warning in fd7d19b1aed14f7c: in annotation extension for PomBase-genotype-3269, can't parse identifier: SPAC17G6.02c.2
warning in fd7d19b1aed14f7c: in annotation extension for PomBase-genotype-3269, can't parse identifier: SPAC17G6.02c.1
warning in fd7d19b1aed14f7c: in annotation extension for fd7d19b1aed14f7c-genotype-3, can't parse identifier: SPAC17G6.02c.2
warning in fd7d19b1aed14f7c: in annotation extension for fd7d19b1aed14f7c-genotype-3, can't parse identifier: SPAC17G6.02c.1

(Note: there are also a bunch of copies of this warning for the same session, which appear to be spurious, as there's no "figure" entry: warning in fd7d19b1aed14f7c: some data from annotation isn't used: figure.)

We now have an extension relation to select the isoform ("transcript isoform ID", pombase/canto#2351).
The Canto->Chado loader needs changing to use the new relation.

The Canto->Chado loader needs changing to use the new relation.

I forgot that I had already done that last week.  I've tweaked it to use "transcript isoform ID" instead of "annotated transcript ID".
Let me know when you start using the "transcript isoform ID" in Canto so I can test that everything works.
The next task is:

pombase/website#1789

I think this is done.


⚠ Bofrost.lu has degraded performance

In d11ba7b, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1605 ms

Resolved: Bofrost.lu performance has improved in b09647a after 6 minutes.


ARROW-11465: [C++] Parquet file writer snapshot API and proper ColumnChunk.file_path utilization

8130

 Quality gate: Failed
13 Issues

 13 Code issues

Details


Fix JunOS template in the documentation

Fixes:
Add missing closing } for IPv6 sessions to generate valid configuration.

Coverage remained the same at 80.29% when pulling 22af2ca88368fc055ef9518821db89077be6427b on adamgent:patch-3 into b30ef42da5c7be4eded475f5f98e2159938ef340 on respawner:master.


My Android App netty-all-4.1.23.Final.jar change to 4.1.31.Final.jar  and show this wrong, just show this log

this is the log:::::::::::
I: Rejecting re-init on previously-failed class java.lang.Class<io.netty.util.internal.logging.Log4J2Logger>: java.lang.NoClassDefFoundError: Failed resolution of: Lorg/apache/logging/log4j/spi/ExtendedLoggerWrapper; I:     at io.netty.util.internal.logging.InternalLoggerFactory io.netty.util.internal.logging.InternalLoggerFactory.newDefaultFactory(java.lang.String) (InternalLoggerFactory.java:50) I:     at io.netty.util.internal.logging.InternalLoggerFactory io.netty.util.internal.logging.InternalLoggerFactory.getDefaultFactory() (InternalLoggerFactory.java:67) I:     at io.netty.util.internal.logging.InternalLogger io.netty.util.internal.logging.InternalLoggerFactory.getInstance(java.lang.String) (InternalLoggerFactory.java:93) I:     at io.netty.util.internal.logging.InternalLogger io.netty.util.internal.logging.InternalLoggerFactory.getInstance(java.lang.Class) (InternalLoggerFactory.java:86) I:     at void io.netty.channel.MultithreadEventLoopGroup.<clinit>() (MultithreadEventLoopGroup.java:35) I:     at void com.dlm.amazingcircle.net.netty.NettyClient.connectServer() (NettyClient.java:78) I:     at void com.dlm.amazingcircle.net.netty.NettyClient.access$200(com.dlm.amazingcircle.net.netty.NettyClient) (NettyClient.java:27) I:     at void com.dlm.amazingcircle.net.netty.NettyClient$1.run() (NettyClient.java:66) I: Caused by: java.lang.ClassNotFoundException: Didn't find class "org.apache.logging.log4j.spi.ExtendedLoggerWrapper" on path: DexPathList[[zip file "/data/app/com.dlm.amazingcircle-2/base.apk", zip file "/data/app/com.dlm.amazingcircle-2/split_lib_dependencies_apk.apk", zip file "/data/app/com.dlm
Expected behavior
Actual behavior
Steps to reproduce
Minimal yet complete reproducer code (or URL to code)
EventLoopGroup group = new NioEventLoopGroup();
Netty version
netty-4.1.31.Final
JVM version (e.g. java -version)
Java 1.8
OS version (e.g. uname -a)
macos 10.12.4

@jasonSuzhow are you sure you use the correct log4j2 version ?

@jasonSuzhow are you sure you use the correct log4j2 version ?

My peoject don't configure this log4j2, and i dont know how to change this.

i searched my project, just find this

So you say you don not include log4j at all ?

@jasonSuzhow Have you solved it yet?

@jasonSuzhow you can set it like this..
InternalLoggerFactory.setDefaultFactory(JdkLoggerFactory.INSTANCE);

https://static.javadoc.io/io.netty/netty-common/4.1.31.Final/io/netty/util/internal/logging/InternalLoggerFactory.html

@jasonSuzhow you can set it like this..
InternalLoggerFactory.setDefaultFactory(JdkLoggerFactory.INSTANCE);

Thanks, I solved it

@jasonSuzhow Have you solved it yet?
Yeah, The solution is @johnou's answer

@jasonSuzhow Have you solved it yet?

Yeah, The solution is @johnou's answer

@normanmaurer slf4j in Netty 5?


Webpack

Should we add webpack in this project ?

@Joxit , why not. I love webpack. If i will find some time to do it, I will ))

Ok, Don't worry, I'm on it :smile:

@Joxit , you are the best! ))

ha ha, it's my first time with webpack, I would certainly need your help :sweat_smile:


Fix "Save" button that deselected the action in AppSmith

When the save button is pressed the table is updated, which causes the action being edited to be deselected, is tedious when several actions are being edited.

I created the branch feature/save-button-deselected with a new function name refreshTable where they not update the Fetch_Actions.run(). Now, when pressed the save button, only is updated the integration information, so the action is not deselected. But this creates a new problem because this means that Run button is not updated with the new changes, the way we had found is to refresh the entire page.

We have three options:

Continue as it is currently, that is, with run button verify the data, everything is safe, but deselect the action.
Or not deselect the action by pressing the save button, but the Run button is disabled until refreshing the main table
Another option is to see if it is possible to refresh the execute button but not deselect the action from the main table.

Solved by saving the last selected row on the "Save" button, and making that value the default index of the APIs table.


epochs.apply_baseline does not return self

Epochs.apply_baseline claims it returns self, but it returns nothing:
https://github.com/mne-tools/mne-python/blob/4b93a7051f8ee5bc46b02f2acf5823900029f418/mne/epochs.py#L437
https://github.com/mne-tools/mne-python/blob/4b93a7051f8ee5bc46b02f2acf5823900029f418/mne/epochs.py#L455
Also, shouldn't it have a copy method?
I can PR once I have another one merged.

Also, shouldn't it have a copy method?

+1


Add image with graphs for the easing functions

I plotted the easing functions for use in my documentation and thought I would share it in case you think it is useful as an addition. I also would like to check with you that the plotting is correct. The image as displayed in GitHub is kind of awkward, being huge and always filling up the row, but the only way to align it nicely on the right of the table is to use HTML which I am not sure you want to use in the README.

Thanks, that's very useful! The plotting looks correct.


Reset Form

What's the best way to handle a standard form reset. i.e. I have both a span bound to rv-text="data.ContactVM.JobTitle" and a input filed bound to rv-value="data.ContactVM.JobTitle"
Hitting a reset button resets the the input fields but the values don't propagate to the spans.
Thanks
Stuart

The reset function on forms does not fire any event on inputs so rivets will not be aware that the input values have changed. DataBinding is not working here.
As a workaround you can listen to the reset on your form and reinit the values of your model
<form rv-on-reset="data.reset">
[...]
</form>

Where resetMyData will look like
data.reset = function() {
   this.ContactVM.JobTitle = null;
   [...]
}

Thanks!

Closing, please comment if your issue is not fixed.


RTD now gets ImportErrors for all local modules

Details

Project URL: https://readthedocs.org/projects/npplus/
Build URL (if applicable): https://readthedocs.org/projects/npplus/builds/4678370/
Read the Docs username (if applicable): dhmunro

Expected Result
Correct documentation, like I get when I do "sphinx-build -b html -d _build/doctrees . _build/html" on my machine.
Actual Result
Builds as of a month ago, for example https://readthedocs.org/projects/npplus/builds/4417653/ worked properly.  Starting a few days ago, all local modules in the project itself produce an ImportError.  I cannot reproduce this behavior running sphinx-build on my own machine.

I tinkered with this some more and resolved the issue.  I still do not understand exactly what changed between the two builds mentioned above, but I managed to create a virtualenv containing only sphinx and mock which reproduced the RTD ImportErrors.  The fix was to put
sys.path.insert(0, os.path.abspath('..'))
in my docs/conf.py file.  This line was not necessary two months ago, and it isn't necessary with the version of sphinx outside my new virtualenv; I didn't check the original sys.path, but apparently it does not include the parent of the docs/ directory now, but formerly it did.
Sorry for not being patient enough to figure this out before I posted the issue.


Prevent registration of strange users

hi to all
How can I keep my panel private and prevent other strangers from registering?
Every time I open the panel, people are re-registered and I don't like it

开启邮箱验证

Open stop register

Open stop register
i try and now i have this bug
https://github.com/v2board/v2board/issues/595


Update tetra-challenge-models.json

Request to add a single additional model as a test.

Closing this PR. It should have been submitted to the vZome repo from which this one was forked, not to this repo. Also, this change has already been incorporated into the vZome repo directly.


Find Command allows non-alphanumeric character keywords input

Decided that patients' names should have alphanumeric characters, so this issue is no longer relevant


CI/CD bug: Inconsistency in code format checking setting in dev mode vs CI/CD

Describe the bug
PR request failed the due to failing "Check formatting" stage in CI/CD job, because
/home/vsts/work/1/s/monai/deploy/operators/publisher_operator.py:12:1: F401 'shutil' imported but unused
/home/vsts/work/1/s/monai/deploy/operators/publisher_operator.py:18:1: F401 'monai.deploy.core.Image' imported but unused
2     F401 'shutil' imported but unused
2
flake8 check failed!
##[error]Bash exited with code '1'.
Finishing: Check formatting

The code in the PR, however, had gone through local dev env format fixing. Those two warnings were not fixed, but are treated as error in the CI/CP pipe,
mqin@mingq-dt:~/src/monai-app-sdk/monai/deploy/operators$ ../../../run check --autofix
DO_DRY_RUN: false
do_black_format: true
do_black_fix: true
do_isort_format: true
do_isort_fix: true
do_flake8_format: false
do_pytype_format: false
do_mypy_format: false
Checking import of module 'monai.deploy'...
2021-10-12 21:12:55 $ python3 -c import monai.deploy
Fixing import order...
2021-10-12 21:12:58 $ python3 -m isort --version

                 _                 _
                (_) ___  ___  _ __| |_
                | |/ _/ / _ \/ '__  _/
                | |\__ \/\_\/| |  | |_
                |_|\___/\___/\_/   \_/

      isort your imports, so you don't have to.

                    VERSION 5.9.3

2021-10-12 21:12:58 $ python3 -m isort /home/mqin/src/monai-app-sdk
Skipped 6 files
isort check passed!
Fixing styles using black...
2021-10-12 21:12:58 $ python3 -m black --version
python -m black, version 21.7b0
2021-10-12 21:12:58 $ python3 -m black /home/mqin/src/monai-app-sdk
All done! ✨ 🍰 ✨
120 files left unchanged.
black check passed!

It is good that the CI/CD picks up these warnings/errors, which by themselves are pure style/formatting issues. It would be nice to have them auto-fixed by run check --autpfix as one may expect the same rules being applied.
Steps/Code to reproduce bug
Create a PR with code change that contains an unused module/class in the import
Expected behavior
Good to have run check --autofix apply the same rules as in CI/CD
Environment details (please complete the following information)

OS/Platform: Ubutu 18.04 dev env.
Python Version: 3.7.5
Method of MONAI Deploy App SDK install: from source
SDK Version: main branch

Additional context
Not a SDK bug, and a dev can figure out the error after inspecting failures.

Closing the issue since the problem can be resolved by examining the build logs, finding the package versions, and then ensuring dev env is set up with the same versions.


Create Scheduled Task Error

Describe the bug
When running the "(Re)create scheduled task" command, wacs.exe fails to create the task and shows error "System.ArgumentException: Value does not fall within the expected range.".
To Reproduce

Run wacs.exe
Pick menu option O: More options...
Pick menu option T: (Re)create scheduled task
Press enter to skip entering a user the task will run as
See error message

Expected behavior
Scheduled task should create successfully.
Log
Win-Acme Log
2023-07-27 08:26:57.204 -04:00 [INF] Adding Task Scheduler entry with the following settings
2023-07-27 08:26:57.205 -04:00 [INF] - Name E:/Win-Acme/config renew (acme-v02.api.letsencrypt.org)
2023-07-27 08:26:57.205 -04:00 [INF] - Path E:\Win-Acme\application
2023-07-27 08:26:57.206 -04:00 [INF] - Command wacs.exe --renew --baseuri "https://acme-v02.api.letsencrypt.org/"
2023-07-27 08:26:57.206 -04:00 [INF] - Start at "09:00:00"
2023-07-27 08:26:57.207 -04:00 [INF] - Random delay "04:00:00"
2023-07-27 08:26:57.207 -04:00 [INF] - Time limit "02:00:00"
2023-07-27 08:26:58.735 -04:00 [DBG] Creating task to run as system user
2023-07-27 08:26:58.742 -04:00 [ERR] Failed to create task
System.ArgumentException: Value does not fall within the expected range.
   at Microsoft.Win32.TaskScheduler.V2Interop.ITaskFolder.RegisterTaskDefinition(String Path, ITaskDefinition pDefinition, Int32 flags, Object UserId, Object password, TaskLogonType LogonType, Object sddl)
   at Microsoft.Win32.TaskScheduler.TaskFolder.RegisterTaskDefinition(String path, TaskDefinition definition, TaskCreation createType, String userId, String password, TaskLogonType logonType, String sddl)
   at PKISharp.WACS.Services.TaskSchedulerService.CreateTaskScheduler(RunLevel runLevel)

Windows Event Viewer Error
Failed to create task
System.ArgumentException: Value does not fall within the expected range.
   at Microsoft.Win32.TaskScheduler.V2Interop.ITaskFolder.RegisterTaskDefinition(String Path, ITaskDefinition pDefinition, Int32 flags, Object UserId, Object password, TaskLogonType LogonType, Object sddl)
   at Microsoft.Win32.TaskScheduler.TaskFolder.RegisterTaskDefinition(String path, TaskDefinition definition, TaskCreation createType, String userId, String password, TaskLogonType logonType, String sddl)
   at PKISharp.WACS.Services.TaskSchedulerService.CreateTaskScheduler(RunLevel runLevel)

Platform:

OS: Windows Server 2019 Datacenter Version 1809
Version: <IP_ADDRESS>1 (release, pluggable, standalone, 64-bit)
Plugins: validation plugin Cloudflare

Additional context

Error occurs both when provided a specific user account to run the task as and when using the default "n" option
Error occurs with Carbon Black Defense (antivirus) enabled and disabled

Happy to provide additional context or details as needed. I'm a bit stumped on what I should try next.

The task name looks suspicious and might be illegal. Did you actually change the client name in setings.json to something with slashes?


Adapt to Plotly 4.0

🐞 Problem
There are a lot of new cool additions to plotly 4.0
(https://medium.com/@plotlygraphs/plotly-py-4-0-is-here-offline-only-express-first-displayable-anywhere-fc444e5659ee)
🎯 Goal
Use Figure instead of widgets. Maybe that will show plots in docs, and we will release a minor version.

💡 Possible solutions

📋  Steps to solve the problem

Comment below about what you've started working on.
Add, commit, push your changes
Submit a pull request and add this in comments - Addresses #<put issue number here>
Ask for a review in comments section of pull request
Celebrate your contribution to this project 🎉

The new version looks great. I'll start working on it after #304.

The new version looks great. I'll start working on it after #304.

Cool!


Task: Is the automatic publish_targets job is required?

What is the task about?

This task issue was created from https://github.com/vmware/repository-service-tuf/issues/188

Loading a huge amount of data will take a long time to process, and an automatic job in between will also try to update the existing/unpublished targets from the database. I will file an issue about it where we can discuss the best approach: do we need this job as each add/remove files its publish_target task? What happens if a failure occurs and it is not published?

Is the automatic publish_targets job required?
As mentioned above, every time targets are added/removed, after adding them to the RSTUF SQL DB, it triggers the publish_targets.
The publish_targets only helps if, for example, the targets were added/removed to the RSTUF SQL DB and, for some reason, the publish_targets is not triggered or started, it will guarantee that in about 60 seconds, a job will publish all unpublished targets.
However, we have task management, meaning that the requester can monitor the task and retrigger the add/remove targets.
Maybe even better to have an endpoint API to trigger the publish_targets and have the functionality even in the CLI admin.
Parent feature

https://github.com/vmware/repository-service-tuf/issues/188

References
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Feedback requested: @joshuagl, @MVrachev, @lukpueh, @KAUTH
Here is my suggestion about this issue in specific.
The requester to add/remove targets has complete control over the tasks (even async) once they receive back the task id, and they can control the execution flow.
The flow about adding targets:
sequenceDiagram
    participant Requester
    participant API
    participant Broker
    Requester->>API: add/remove target(s)
    API->>Broker: Submit Task
    API->>Requester: task id

Using this task id, the requester can follow the execution.
The execution in the Worker will keep updating this task id with the status and progress.
I would suggest removing the automatic publish_targets call that runs every minute.
https://github.com/vmware/repository-service-tuf-worker/blob/e75fec1e40d693caf181d8e069d490f3fe96dc8b/app.py#L143-L155
Some context on how it works for the Worker about adding/removing new targets
Note: Worker N, when N can be any Worker of multiples
sequenceDiagram
    participant Broker/Result Backend
    participant Worker N
    participant DB
    participant Storage Service
    Worker N-->>Broker/Result Backend: Get the Task to add/remove
    Worker N->>DB: Insert/update targets
    Worker N->>Broker/Result Backend: Update add/remove Task
    Worker N->>Broker/Result Backend: submit sub-task `publish_targets `
    Worker N-->>Broker/Result Backend: Get the task `publish_targets `
    critical sub-task `publish_targets`
      Worker N->> Storage Service: Update `bins-{hash}`, Update Snapshot, Update Timestamp
      Worker N->> DB: Update SQL DB
    end
    Worker N->>Broker/Result Backend: Update add/remove Task FINISH

With this, the user will reprocess the request in case of failure.
We also need an endpoint in the REST API to trigger a publish_targets.
It is required by Feature: data load for migrations
Because the CLI needs to do the following steps:

Insert all targets to SQL DB
Submit the Task to publish_targets

This could be used for other use cases (CLI command to 'force' publish_targets) but is not required there.
My suggestion is two actions:

Add endpoint to trigger publish_targets in the Rest API
Improve the task monitoring the sub-task, to have a better update for the user.

Just so you know – the issues above are required independently of the decision to remove the automatic publish targets.

Just so you know – the issues above are required independently of the decision to remove the automatic publish targets.

I think that the decision for this task and whether we need a publish_targets endpoint is connected.
We won't need an endpoint if we leave it as it is.
I agree that more control over the user when to publish the targets is great.
The user can decide to make a bigger batch of new targets before publishing or make sure that his server is ultra-responsive and publish the targets every 20 seconds for example.
So, yes, if we add a new publish targets endpoint as suggested in an issue above, then I am all for removing the automatic job.

Just so you know – the issues above are required independently of the decision to remove the automatic publish targets.

I think that the decision for this task and whether we need a publish_targets endpoint is connected. We won't need an endpoint if we leave it as it is.
I agree that more control over the user when to publish the targets is great. The user can decide to make a bigger batch of new targets before publishing or make sure that his server is ultra-responsive and publish the targets every 20 seconds for example. So, yes, if we add a new publish targets endpoint as suggested in an issue above, then I am all for removing the automatic job.

Awesome @MVrachev ! 🎉
I'm complementing what @MVrachev just said with another use case:
We don't know the user complexity flow about adding targets.
Imagine that he only makes the target available for the clients (publishing in some distribution platform or some release announcement) when they confirm that it is published in the TUF metadata.
The user loses control of when and by whom it was published as it was done by an automatic job that he cannot track.
We should let the user decide how re-process it: adding targets or triggering just the published targets.

I agree that more control over the user when to publish the targets is great. The user can decide to make a bigger batch of new targets before publishing or make sure that his server is ultra-responsive and publish the targets every 20 seconds for example. So, yes, if we add a new publish targets endpoint as suggested in an issue above, then I am all for removing the automatic job.

Rereading your comment, we could even create a new minor feature in the API/Worker.
It is not about the automatic job/routine but about publishing targets during the "add/remove targets" request.
Where we could have an option publish_targets as default True. It means, when you request "add/remove targets", it will publish it (after inserting it into RSTUF DB).
If you decide to move publish_targets as False it doesn't publish it in the TUF Metadata.
In that way, we could have the option you mentioned. Sending batches of targets and publishing them later.
WDYT @MVrachev

Maybe we can support both:

an option: to publish changes to the targets when adding/removing targets
an API endpoint

Even if we have the option to publish the targets I think it's worth adding an API call because how would you publish the targets if you have used publish_targes = False when you added/removed them?
Also, I start to think that the name of this option and API endpoint shouldn't be publish_targets, but the option could be called publish_changes and the call can still be /api/v1/targets/publish.

Maybe we can support both:

an option: to publish changes to the targets when adding/removing targets
an API endpoint

Even if we have the option to publish the targets I think it's worth adding an API call because how would you publish the targets if you have used publish_targes = False when you added/removed them?
Also, I start to think that the name of this option and API endpoint shouldn't be publish_targets, but the option could be called publish_changes and the call can still be /api/v1/targets/publish.

Yes, we will have both.
The endpoint is required due to the feature load/import data, the task issue is already opened:

https://github.com/vmware/repository-service-tuf-api/issues/242
The endpoint is defined as /api/v1/targets/publish as well.

I think we are well aligned.
I will file an issue with the optional parameter for add/remove.

Related tasks to close this issue:

https://github.com/vmware/repository-service-tuf-worker/pull/197
https://github.com/vmware/repository-service-tuf-worker/issues/198
https://github.com/vmware/repository-service-tuf-api/issues/248

Related tasks to close this issue:

[x]  Monitor publish tasks sub task and remove automatic job publishing targets #197
[x]  feature: skip the publish_targets when field is False in the payload #198
[x]  feature: add optional field publish_targets in add/remove payload repository-service-tuf-api#248

All tasks are completed and we can close this issue.
Closing.


Fix unit test segfault when running error.test.cpp

Error traces do not seem to work and at some point once there is a sufficient number of unit tests, this section seg faults. The test will have a skip /  marked on it to prevent it from running.

Failure occurs on
Using built-in specs.
COLLECT_GCC=g++-11
COLLECT_LTO_WRAPPER=/opt/homebrew/Cellar/gcc/11.2.0_3/libexec/gcc/aarch64-apple-darwin21/11/lto-wrapper
Target: aarch64-apple-darwin21
Configured with: ../configure --prefix=/opt/homebrew/Cellar/gcc/11.2.0_3 --libdir=/opt/homebrew/Cellar/gcc/11.2.0_3/lib/gcc/11 --disable-nls --enable-checking=release --with-gcc-major-version-only --enable-languages=c,c++,objc,obj-c++,fortran --program-suffix=-11 --with-gmp=/opt/homebrew/opt/gmp --with-mpfr=/opt/homebrew/opt/mpfr --with-mpc=/opt/homebrew/opt/libmpc --with-isl=/opt/homebrew/opt/isl --with-zstd=/opt/homebrew/opt/zstd --with-pkgversion='Homebrew GCC 11.2.0_3' --with-bugurl=https://github.com/Homebrew/homebrew-core/issues --build=aarch64-apple-darwin21 --with-system-zlib --disable-multilib --with-native-system-header-dir=/usr/include --with-sysroot=/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 11.2.0 (Homebrew GCC 11.2.0_3)

And only on Debug builds. Works fine on Release builds

error.test.cpp as well as much of the code in error.hpp has been removed in #266.


Add a privacy policy

Apple require us to provide one for submission to the App Store.

I think the privacy policy will need to be linked from the app. We also need to think whether there's any need to highlight to users whether fetches to third-party services (TfL, National Rail, ZenQuotes, etc) mean that their data is outside of our control and that they can / should review the privacy policy of those organisations. Perhaps we need to link the individual privacy policies for the third-party services in the data source settings views, or in the About view.

Done. See #679.


Firefox Support for either Tampermonkey or Violentmonkey?

So I used this while using Greasemonkey, but I'd like to move away from using Greasemonkey as it isn't e10s compatible. I'm currently using Violentmonkey, but as expected, the script doesn't function.
Is there a fix for this, will support be added later, as eventually with Firefox 57, e10s add-ons will be the only option.

Hi @crkellen!
We are providing a userscript which isn't browser specific. Once Violentmonkey and Tampermonkey start working in FF v57, then we hope the userscript will work. Except...
If you look at issue #13, you'll see there is an issue with Tampermonkey and GitHub's Content Security Policy (CSP). This appears to be the same problem with Violentmonkey:

Content Security Policy: The page’s settings blocked the loading of a resource at self (“script-src https://assets-cdn.github.com”). Source: (function s(t,n,e,r){t.initialize(n,e,r)....

There really isn't anything we can modify in this script to solve this issue. I think it is up to the browser.

Well dang. Thanks for letting me know! You can choose to close this if you want.


schema.errors include errors for optional fields

Steps to reproduce:
s = schema({
  '?optional': String
});
console.log(s.errors({}));

returns
{ optional: 'undefined is not a String' }

The expected result is no errors at all.

Thanks for reporting, I've just pushed the fix for this.

@molnarg I've tried version 1.0.0 but it looks like this is still an issue.

Sorry, it looks like you forgot to build before publishing the latest release.

Thanks, I've just released 1.0.1 with the built js files!


When loading an imodel in performance app wait for map location to initialize

Is this only a temporary fix? You talked about computing the ECEF transform in native code when opening the iModel and removing the need to asynchronously initialize it.

Yes - This is temporary.   Will be removed when I compute ECEF in backend.  It is just so I can get the reference images corrected for imageTest

Is this only a temporary fix? You talked about computing the ECEF transform in native code when opening the iModel and removing the need to asynchronously initialize it.

Yes - This is temporary.   Will be removed when I compute ECEF in backend.  It is just so I can get the reference images corrected for imageTest


New release

The theme was made compatible with Jekyll 4.0 a while ago, but no release has been made since then, so it's not available through RubyGems. Could that be rectified?

Hey @robinkunde , this might be related to #55
Nothing new there, pity.


Create contribution instructions for quickstarts github workflow

Create a guideline for contribution in quickstarts github workflow.

/assign


Include JavaScript + ES6 understanding Prerequisites

Because being proficient with React does not mean knowing ES6 thoroughly. (Some features such as destructing require some amount of knowledge from ES6)

thanks but i'm not keen on growing the prereqs list. lot of yaks to shave as it is.


Results not in specified sort order when using published or lastEdited sorts.

Results are nearly sorted correctly, but there are jitters.
% curl -s https://api-search.nuget.org/search/query\?sortBy\=published\&take\=3\&skip\=16 | jq '.data | map("Published: \(.Published) (Key: \(.Key))")'                                                               <<<
[
  "Published: 2014-10-02T01:13:40.737 (Key: 403393)",
  "Published: 2014-10-02T00:56:28.63 (Key: 403392)",
  "Published: 2014-10-02T02:02:22.427 (Key: 403394)"
]

or
 curl -s https://api-search.nuget.org/search/query\?sortBy\=published\&take\=3\&skip\=200008 | jq '.data | map("Published: \(.Published) (Key: \(.Key))")'
[
  "Published: 2013-06-07T09:13:59.1 (Key: 186821)",
  "Published: 2013-06-07T12:20:23.833 (Key: 186931)",
  "Published: 2013-06-07T06:08:30.693 (Key: 186747)"
]

We are not planning to keep sorting support long term.

Hi @yishaigalatzer , thanks for the update. Will there be an alternate API mechanism for walking through large search results?

We don't plan on having one at the moment. Can you share what is the scenario for this?


Memory consumption on pub/sub cache

Hi,
I'm using Events & Pub / Sub Messaging, as time goes by, the cache memory consumption grows in but it is not released. I am setting the expiration when creating the message and I also configured the expiration in the cache configuration file on the server. I believe that something is missing, as it is something very basic and there is no information available. Related issue in #45. I appreciate any help.
Publisher:
             _topic = _cache.MessagingService.GetTopic(eventName);
            if (_topic == null)
            {
                _topic = _cache.MessagingService.CreateTopic(eventName);
                _topic.ExpirationTime = TimeSpan.FromMinutes(10);
            }
            Message message = new Message(@event, TimeSpan.FromMinutes(10));
            _topic.Publish(message, DeliveryOption.Any, true);

Server cache config:
      <expiration-policy enabled="True">
          <absolute-expiration longer-enabled="False" longer-value="0" default-enabled="True" default-value="30"/>
          <sliding-expiration longer-enabled="False" longer-value="0" default-enabled="False" default-value="30"/>
      </expiration-policy>
      <cleanup interval="15sec"/>
      <storage type="heap" cache-size="128mb"/>
      <eviction-policy default-priority="normal" eviction-ratio="25%"/>
      <cache-topology topology="replicated">

Version: 5.0 SP3
Thanks for any help.

Hi @andrevoltolini ,
Please note that I’ve tried reproducing this issue on my end using the code snippet provided and was not able to do so, it is working fine for me without any issues.  I think we need more details to analyze this.
Please see if you can share a sample application which we can use in our environment to reproduce this issue. This will be really helpful in narrowing down the root cause.
If that’s not doable, then please share the memory dumps of your “Alachisoft NCache Cache Host Process” from your NCache servers. Please take the memory dumps when:
•	Cache host processes are consuming normal memory.
•	Cache host processes are consuming high memory.
Moreover, please send us the following DLLs and the cache config file along with the memory dumps
•	C:\Windows\Microsoft.NET\Framework64<v4.0 framework version>\sos.dll
•	C:\Windows\Microsoft.NET\Framework64<v4.0 framework version\mscordacwks.dll
•	C:\Windows\Microsoft.NET\Framework64<v4.0 framework version \clr.dll
•	C:\Windows\Microsoft.NET\Framework<v4.0 framework version>\sos.dll
•	C:\Windows\Microsoft.NET\Framework<v4.0 framework version\mscordacwks.dll
•	C:\Windows\Microsoft.NET\Framework<v4.0 framework version \clr.dll
•	Config files from the Cache Servers hosting the clustered cache located at “C:\Program Files\NCache\config\config.ncconf”
Please let me know if there are any questions.

Hi @Mark-NCache,
Below is the link to download the requested files. I appreciate the help.
Files.zip

Hi @andrevoltolini,
Thanks for providing us with the requested information. I've sent the memory dumps to our engineering team for analysis and I'll get back to you once I have an update.
Please let me know if there are any questions.

Hi @andrevoltolini ,
We have conducted a complete memory dump analysis that you had shared with us and we have also done code review based on this analysis. During analysis, we found some issues where the "ClientManager" data structures were not getting disposed and are kept in memory. It seems that your client applications connect and dispose the cache very frequently and there are a few situations where these connection handles are not being disposed. There were 2600+ such instances were found which seem to be the main cause of over utilization of memory.
We then created an environment and an application based on our dump analysis to reproduce this issue in our environment.  We saw several instances of disposed but pinned "ClientManager" data structures in the memory but in our case it was not increasing memory too much as the number of connection handles seen in our environment was very low compared to your environment.
Issue Fix: Engineering is currently reviewing this more and plan to provide a fix of this issue. It is expected to be releases as part of our upcoming NCache version 5.0 SP4 released expected in next 2-3 weeks.
I hope this will fix will resolve your issue.

Hi @Dan-Ahmed, thank you very much for the answer. This demonstrates the seriousness with which Alachisoft takes the product and the community. I will be waiting for the new version and thanks again.

Hi @andrevoltolini ,
I trust you're in good health. I wanted to update you in regards to the PUB/SUB memory consumption issue that was raised a couple of months ago. Our engineering team has fixed this issue in the NCache v5.0 SP4 release and you can download the NCache 5.0 SP4 OSS Edition using the following link.
www.alachisoft.com/downloads/ncache.oss.x64.msi
Please let us know if this resolves your issue and feel free to reach out in case of any questions.

Hi @Dan-Ahmed, thanks for the reply. I will plan to upgrade SP3 to SP4 next weekend. As soon as I have the results, I'll let you know. Thanks again.

Hi @andrevoltolini ,
Thanks for your response, I want to add a few more details on my previous comment.
The fix is provided in NCache v5.0 SP4 and is entirely based on the memory dumps analysis as well as NCache code review done by our engineering team as mentioned in my comments above. We were unable to reproduce your exact case on our side and this is released as a tentative fix.
It is highly recommended that you try NCache v5.0 SP4 in your test environment and let us know if this resolves your issue. This will help us validate that the issue is indeed fixed.
I hope this helps and we will wait for your feedback here.

Hi @Dan-Ahmed,
The fix worked perfectly. Please extend my thanks to everyone involved and especially engineering. Another point to be highlighted is that this version is much faster. Thank you.


Handle multiple pull request templates correctly

Is your feature request related to a problem? Please describe.
Having multiple pull request templates or, a single no

Done the best that's possible using query params.


Error generating custom background color

Sorry if this is user error but Everytime I try and set a custom background color I get this error:
wal -b "#ffffff"
Traceback (most recent call last):
File "/usr/bin/wal", line 11, in
load_entry_point('pywal==1.3.2', 'console_scripts', 'wal')(File "/usr/lib/python3.6/site-packages/pywal/main.py", line 159,
process_args(args)
File "/usr/lib/python3.6/site-packages/pywal/main.py", line 133,
colors_plain["special"]["background"] = args.b
UnboundLocalError: local variable 'colors_plain' referenced before assi
I hope this helps.

You still need to specify an image or file input for colors. (-i or -f)


Black halo/shadow from lamps

Just having a strange black halo emaning from the lights/lamps in SH3 game with the sh3proxy...
I already set on default or deactivate all the nvidia control panel options since I read that having msaa make halo to appear on objects...
Anyways thanks for the fixes! Just waiting for the Pixelation fix to be added and would be great to have the fog customization too...
I was attempt to use in SH2 and SH3 the Aero Widescreenfix but in both games I get the menus in 4:3 and have ugly borders with maps...

bump

Yeah sure, and thanks in advance!
Look at the lamps in the ceiling, as you move it brings a "shadow/halo" that moves with me and the camera...
http://imgur.com/a/3qgL3

Is it still visible if you lower the FOV? It might be that the camera is clipping the ceiling.

I tried even at 60 FOV but still have the same issue as we can see here: http://imgur.com/a/F18E2
I will put here my sh3proxy setting, maybe something is wrong...
[Patches]
// Disable safe mode warning
DisableSM = 1
// Absolute path to an existing savedata
// directory, e.g. "Z:\sh3saves". Replaces the path
// used by the game. Set this to "" to use the default path.
SavepathOverride = ""
// Unlock Silent Hill 2 references. Requires starting a
// new game
SH2Refs = 1
// Fix Windows 10 white border
Win10WhiteBorderFix = 1
// Borderless mode (if game is windowed)
Borderless = 0
// Engine's debug logging. Only enable this if you know
// what you are doing. Might slow the game down.
DebugLog = 0
[Video]
// Enable video patches
Enable = 1
// Do not change the "Resolution" option in game
// settings. It will be overriden by following two
// options:
// Horizontal video resolution
SizeX = 3840// Vertical video resolution
SizeY = 2160// Set to 1 for auto-detection of screen resolution (SizeX/SizeY are ignored in this case) (default 0)
AutoDetectRes = 0
// Match rendering resolution with video resolution.
// If enabled, do not change the "Rendering Resolution" option in game.
MatchRes = 1
// The actual renderbuffer resolution still has to be
// configured in game settings as "Rendering Resolution"
// Shadow map resolution, power of two up to 4096
ShadowRes = 4096
// Fullscreen mode
Fullscreen = 1
// Horizontal FOV, degrees
FovX = 90
// Correct fog density coefficients according
// to aspect ratio
CorrectFog = 1
// Depth of Field effect resolution, power of two up to 4096
DOFRes = 4096
// Status screen preview resolution, power of two up to 4096
PreviewRes = 4096
// Disable Depth of Field effect
DisableDOF = 0
// Disable black border during cutscenes
DisableCutscenesBorder = 0
[FixJitter]
// Options in this section are mutually exclusive
// i.e. only one should be set to 1
// Currently, these fixes are experimental,
// and will hopefully be obsoleted in next release
// Attempt to fix framerate jitter by capping FPS to 30.
CapFPS = 0
// Use alternative fix. Only enable this if you can
// maintain 60 FPS stably, otherwise this will break
// the engine's clock
AltFix = 1
[Cheats]
// Infinity ammo & items (default 0)
UnlimitedAmmo = 0
// God Mode (default 0)
GodMode = 0

Funny thing: I have similar issue even with vanilla game and my halo/shadow has different effects depending on game options and on using flashlight.
The strongest effect occurs when "brightness level" is set on "3" or more, "display mode" is set on "normal", "noise effect" is on and the flashlight is on:
http://funkyimg.com/i/2vUtE.jpg
http://funkyimg.com/i/2vUtF.jpg
http://funkyimg.com/i/2vUtG.jpg
And setting "display mode" on "sharp" completely removes this halo/shadow effect regardless of other options.

OMG thats even worse... Mines even its a black shadow, but this doesn't happen to everyone, so I think this could be a Nvidia thing or something? Don't know...

Yeah) Maybe it's nvidia - I've got 1 Gb 250GTS card. And I've seen different let's plays and people also have this problem.

@KindratKnysh thanks for the clues.
I'll have a look at what display modes actually determine and why they affect haloing, but since this is not introduced by sh3proxy, it won't be a high priority issue.

Ok, thank you! I will continue tweaking to see if I can fix it... I have an Asus Nvidia 980Ti, I will see

was attempt to use in SH2 and SH3 the Aero Widescreenfix but in both games I get the menus in 4:3 and have ugly borders with maps...

Just FYI, you can leave all of the menus stretched by using FixMenu = 0. It's currently only available in SH3, but it will be added in the next update for SH2.
Anyway, I've noticed this strange ghosting effect that KindratKnysh took screenshots of a long time ago, but I thought it was an intentional effect. If it's disabled with "sharp" display mode then maybe it's another bug. I'll try to help with this too if I can.

Hi @Aero52! Thanks for your work in first place =)
I've installed your widescreen fix and I configured it like this:
[MAIN]
ResX = 3840
ResY = 2160
RenderResX = 3840
RenderResY = 2160
FixMenu = 1
FixFMV = 1
[MISC]
SingleCoreAffinity = 1
FMVWidescreenMode = 1
DisableCutsceneBorders = 1
DisableSafeMode = 1
PixelationFix = 1
StatusScreenRes = 4096
ShadowsRes = 4096
DOFRes = 4096
FrameRateFluctuationFix = 1
But The menus and screens outside gameplay looks with borders for me, even with the fixmenu thing turned on... Would be great to have it fixed on SH2 and SH3 too, thanks!

EDIT 2: Is it me or the FOV is lower (more near Heather) in the Widescreen Fix vs the sh3proxy?

We use hor+ scaling, which means the vertical FOV remains same as it is in 4:3, but the horizontal FOV is increased for widescreen.
Anyway, let's not derail this. If you have anymore questions or issues with the widescreen fix then report them here: https://github.com/ThirteenAG/WidescreenFixesPack/issues

Ok, thank you again! Waiting for your SH2 Widescreen Fix for the menus/maps =)

I don't know if it because of the last update but now the lamps doesn't do that strange halo thing...
As you said, the game has an intentional blurry halo, but just a tiny and artistical one now!
The only thing that is bothering me in SH3 is the realtime shadows, they look like monsters to me x'D
Now seriously, this is an example, sometimes it looks weird, showing strange shapes... Look at her left elbow or the right hand/arm...
http://imgur.com/QUVcjGd
PD: With the SH2 references activated I can see the posters, but the letter in her inbox at the apartments doesn't show to me... Thanks as always for all your work so far!

It seems that letter reference has some kind of additional requirement. I've completed game 5 or 6 times and got this reference only once or twice. Also on one of the forums someone wrote about playing PS2 version and not getting this reference while other 3 references were available.

It seems that letter reference has some kind of additional requirement. I've completed game 5 or 6 times and got this reference only once or twice. Also on one of the forums someone wrote about playing PS2 version and not getting this reference while other 3 references were available.

Oh, great to know that then, thanks!

Anyone? =(
http://imgur.com/QUVcjGd


typography field doesn't list standard font-families (Arial, Verdana ...)

Issue description:
I noticed this a few months ago, that the font-families in the typography field, don't display any of the standard font-families, such as Arial, Verdana, Helvetica etc. Those are without a doubt a must have.
Here is a list of all those fonts: http://www.w3schools.com/cssref/css_websafe_fonts.asp
Also, I noticed that in the drop down menu for the font-families, there is "serif", "sans serif" and "monospace" listed. I would suggest to remove them, since those are generic families used as fallbacks by browsers.
Version used:
Latest github
Using theme_mods or options?
theme_mods
Code to reproduce the issue (config + field(s))

Actually standard fonts are like this:
Serif
'Georgia,Times,"Times New Roman",serif'
Sans-Serif
'Helvetica,Arial,sans-serif'
Monospace
'Monaco,"Lucida Sans Typewriter","Lucida Typewriter","Courier New",Courier,monospace'
You can see the stack here: 'Monaco,"Lucida Sans Typewriter","Lucida Typewriter","Courier New",Courier,monospace'
The reason they are displayed in the dropdown as simply serif/sans-serif/monospace is space-saving and nothing more. If you select Serif, then 'Georgia,Times,"Times New Roman",serif' will be used as per the link you posted above.

Hello aristath,
Sorry for opening this up again. I'm only just now continuing the typography on my theme.
I am very confused on why you would group the standard fonts together by "style".
Serif is not a font (typeface) by itself. Serif refers to if a font has a stroke a in their symbols or not. https://en.wikipedia.org/wiki/Serif - Respectively sans serif is without the stroke.
Grouping them all together doesn't really make sense to me, since they are all completely different looking fonts.
In css using font-family, if you have multiple fonts listed, they work as backups.
Example: font-family: "Times New Roman", Times, serif;
The browser first looks if the font Times New Romand is available, if nothing is found, then it looks for Times (which is similar), if again nothing is found, then it looks for all fonts styles that use serif.
The way the typography field currently is in kirki, is that if I select sans serif it outputs 'Monaco,"Lucida Sans Typewriter","Lucida Typewriter","Courier New",Courier,monospace', which are a group of completely different looking fonts, and since only the first one is being used by the browser, because they rest acts as backups, I have no way of selecting for example Courier New.
I really think all the standard web fonts as listed here: http://www.w3schools.com/cssref/css_websafe_fonts.asp should have their own selection field in the drop down. This current way of grouping them together is not really the way the fonts should be used.

The reason they are grouped is because not all operating systems have all fonts.
Since you're using Courier New I'll assume you're on windows.
If you use that, then OSX & Linux machines will not be able to properly render the font, simply because it doesn't exist there.
If you want, you can use the kirki/fonts/standard_fonts filter to change the standard fonts and use whatever you wish. You can see the filter here: https://github.com/aristath/kirki/blob/2.4.0-beta.1/core/class-kirki-fonts.php#L84-L100
Example:
add_filter( 'kirki/fonts/standard_fonts', function( $fonts ) {
	$fonts['sans-serif'] = array(
		'label'  => 'Sans Serif',
		'stack'  => 'Arial,Helvetica,sans-serif',
	);
	return $fonts;
} );

Yes that is true that they are not all supported, however that is why these fonts along with the fallback fonts are listed as web safe fonts, since they are the most cross-platform supported fonts, along with the closest fallback fonts. So whatever a user chooses, it will be the most cross-platform compatible solution out there. These combinations of web safe have been used since the late 90s, and is common practice for web developers.
I would honestly recommend to include it the way it's listed at http://www.w3schools.com/cssref/css_websafe_fonts.asp
In the selection field, only display the first Font, and in the actual css, include the suggested fallbacks.
I am using this array.
websafefonts = array(
		/* Web Safe Fonts */
		'Arial, Helvetica, sans-serif' => esc_attr__( 'Arial', 'my_textdomain' ),
		'"Arial Black", Gadget, sans-serif' => esc_attr__( 'Arial Black', 'my_textdomain' ),
		'"Comic Sans MS", cursive, sans-serif' => esc_attr__( 'Comic Sans MS', 'my_textdomain' ),
		'Impact, Charcoal, sans-serif' => esc_attr__( 'Impact', 'my_textdomain' ),
		'"Lucida Sans Unicode", "Lucida Grande", sans-serif' => esc_attr__( 'Lucida Sans Unicode', 'my_textdomain' ),
		'Tahoma, Geneva, sans-serif' => esc_attr__( 'Tahoma', 'my_textdomain' ),
		'"Trebuchet MS", Helvetica, sans-serif' => esc_attr__( 'Trebuchet MS', 'my_textdomain' ),
		'Verdana, Geneva, sans-serif' => esc_attr__( 'Verdana', 'my_textdomain' ),
		'Georgia, serif' => esc_attr__( 'Georgia', 'my_textdomain' ),
		'"Palatino Linotype", "Book Antiqua", Palatino, serif' => esc_attr__( 'Palatino Linotype', 'my_textdomain' ),
		'"Times New Roman", Times, serif' => esc_attr__( 'Times New Roman', 'my_textdomain' ),
		'"Courier New", Courier, monospace' => esc_attr__( 'Courier New', 'my_textdomain' ),
		'"Lucida Console", Monaco, monospace' => esc_attr__( 'Lucida Console"', 'my_textdomain' )
};


[Enhancement]: enhance the searchBar

Do you want to have the enhancement of existing game ? 😀 Describe yourself..
Game enhancement
Describe the solution you'd like
Solution steps i want to take some good css in the search bar
Select program in which you are contributing
No response
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @PAPIYA-DUTTA , You can't have another issue before completing the previous one 😀
you already have the following 1 open issues 👀 ! :
#4354

Hey @PAPIYA-DUTTA ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

Hey @PAPIYA-DUTTA !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹


go.mod: update dependencies

This commit updates the k8s dependencies from 0.17.3 to 0.19.3. This
is required for another PR which will need to import a package from
ci-tools, which uses k8s 0.19.3. Process was as follows:

Change go.mod k8s replaces to 0.19.3
Add go.mod replaces for openshift client-go and library-go, matching the replaces in ci-tools
Run go get -u k8s.io/test-infra to get a test infra using k8s 0.19.3
Fix broken function calls due to updated signatures. These include:

All functions that interact with k8s resources on a server requiring a context. For now I just used context.TODO()
Create and Update requiring CreateOptions and UpdateOptions respectively
Delete using DeleteOptions instead of *DeleteOptions

/hold cancel

Part of DPTP-1650


External IP can't be open outside

I have follow the guide and get a external-ip like below:
![image](https://user-images.githubusercontent.com/22910206/54504916-b3031800-4970-11e9-9e69-2104a6fba94b.png

and my azure-vote-front is not on,can you figure why?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 65f634bf-2280-a093-5897-724310dafa2d
Version Independent ID: f11c0af7-bfaf-6d64-2c75-9015b0eb1f30
Content: Kubernetes on Azure tutorial  - Prepare an application
Content Source: articles/aks/tutorial-kubernetes-prepare-app.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

@difanyi Thank you for your feedback . We will have this investigated and update the thread accordingly .

@difanyi Could you please check whether port 30543 was listed under your NSG. If not please add this to the list.

@difanyi , Checking whether you were able to resolve the issue by listing the ports in NSGs. Please let us know whether you need more help on this.

@difanyi , Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly reopen the issue and continue the discussion.


Turn decor brackets in index into their own class.

I think it's a good idea to decorate the brackets on the home screen using class instead of span. This frees up span. The new class is decorBrackets.

Doesn't seem like community is interested - this pull request is STALE and has been closed


Laravel-echo-server running in docker, resolve the local address as IP !

here are my laravel-echo-server.json
{
	"appKey": "o7gq6d4m56rkm3ipaphd1cqagj2lsacogbo25bgfhra05n847jcu5li68jbc",
	"authHost": "http://app.local",
	"authEndpoint": "/broadcasting/auth",
	"database": "redis",
	"databaseConfig": {
		"redis": {
			"host": "redis",
			"port": "6379",
			"db": "0"
		},
		"sqlite": {
			"databasePath": "/database/laravel-echo-server.sqlite"
		}
	},
	"devMode": true,
	"host": "<IP_ADDRESS>",
	"port": "6001",
	"referrers": [],
	"socketio": {},
	"sslCertPath": "",
	"sslKeyPath": ""
}

It says ECONNREFUSED. It's lookup DNS from app.local from /etc/hosts.  And it uses <IP_ADDRESS> as the DNS lookup result for authHost. That's the problem !
I've change the authHost to http://www.google.com, that's the result:

So I change the authHost to my LAN IP like http://<IP_ADDRESS>, and bind all my project entrance to http://<IP_ADDRESS>,  problem solved.

https://github.com/tlaverdure/laravel-echo-server/issues/11

https://github.com/tlaverdure/laravel-echo-server/issues/11

https://github.com/tlaverdure/laravel-echo-server/issues/11

https://github.com/tlaverdure/laravel-echo-server/issues/11

https://github.com/tlaverdure/laravel-echo-server/issues/11

why does the client left the channel after join with nothing output ?


UHF-6356 enable global nav json api

UHF-6356

[X] Combine global nav backend and frontend by using JSON api.
[X] Add support for whitelisted internal vs external links (and mailto and tel-links too)
[ ] Fallback to html menu when JSON api is not available
[ ] Get frontpage api and link url from JSON api
[ ] Fix sorting of the items in menu (0-weight issue)

What was done

Started using JSON api instead of selfhosted json file
Changed variable keys to match JSON api content
Removed mock data file
Added support for non-whitelisted external links with plain, mailto and tel variants

How to install

Make sure your instance is up and running on latest dev branch.

git pull origin dev
make fresh

Update the HDBT theme

composer require drupal/hdbt:dev-UHF-6356_enable_global_nav_json_api

Run make drush-cr
Run npm i && npm run build in theme folder
In your etusivu-instance, run this: composer require drupal/helfi_proxy:dev-UHF-X-cors to allow other instance to access the api (cors)
Add external links, mailto and tel links to menu

How to test

[ ] Check that mobile js-menu works as it should and gets data from API
[ ] Check that external, mailto and tel links get properly tagged with icons and translated screen reader texts in mobile js menu
[ ] Check that code follows our standards

Designers review

[X] This PR does not need designers review
[ ] This PR has been visually reviewed by a designer (Name of the designer)

This was handled in other branch


feat(tests-integration): add test rpc state reader binary

Stack:

#1383
#1364
#1363 ⬅

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is

✓ Commit merged in pull request #1383


Disable touchscreen?

Is it possible to disable the onscreen menu?
What i mean that nothing happens if the screen gets touched?
I need some kind of kiosk mode.

AFAIK this is not a feature.
Feel free to add it, PR's are accepted.

just disable the controls


consider having .train() and .customized_train()

.train() will just call .customized_train() with a series of defaults in place.
it'll have a much simpler interface, which would be nice.

ok, this is definitely happening. this interface is getting complicated already. it's worth having all these options, but i want to keep the basic .train() function call easy and unintimidating.


Scroll-able along with other items, outside it's container

Hello,
Thank you for the swift reply to my question. I've opened it as a new issue as you advised.
I tried the syntax as you requested. It works well, though a small bit still bugs me. So I enclosed it in a scrollview but it still scrolls inside itself.
The structure of my layout file
`
ScrollView  xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent" android:layout_height="match_parent">
<LinearLayout>  header views like instructions, etc </LinearLayout>

    <de.codecrafters.tableview.TableView
        xmlns:table="http://schemas.android.com/apk/res-auto"
        android:id="@+id/instTableView"
        android:orientation="vertical"
        android:layout_marginTop="10dip"
        android:layout_width="fill_parent"
        android:layout_height="fill_parent"
        android:divider="@color/list_divider"
        android:dividerHeight="1dip"
        android:textSize="10sp"
        android:layout_marginBottom="50dp"
        android:background="@drawable/flat_border_set"
        android:gravity="center_horizontal"/>
//Long list of item views {table rows}

<LinearLayout> - footer views eg share buttons etc </LinearLayout>

</ScrollView`
As it is, when I scroll down the rows scroll within the table container. This becomes a challenge for smaller screens.
So, I'd like to have the whole page to scroll so that if a user scrolls down, the table view scrolls along with everything else. Am I doing it wrong?
Joe

Hi Joe,
first I would like to be sure, that I understood you correctly. You want to use the TableView together with other views in a LinearLayout. (Some views before the TableView and some views after.) You don't want the TableView to scroll, but to show it's full content.  Is this all correct?
Best regards,
Ingo

Yes, that's correct. Spot on. More like a Listview that scrolls along with other elements of the page. I have placed other views in the header LinearLayout and some footer views in another Layout at the bottom. If I give the TableView a fixed height then it performs well and scrolls along with other items. But fixed height is definitely not the right approach.

Hi Joe,
as you said fixed size is working for this approach. As the TableView is using an ListView internally you have the known issues for WRAP_CONTENT so you should not do this.
So if you really want to have the described UI (also if I would recommend to re-think this, as it is not optimal for small screens) I would calculate the table height using the number of rows in the TableView and set this value as fixed size.
Hope this helps you.


Feature Request: Generate alternate feed types.

Is it (I'm a n00b who is expecting a no.) possible to add the ability for this to generate an iCal feed so users can subscribe to the entire calendar and not just single events?
Long shot I know but worth the try.
Cheers.
DM

Unfortunately this isn't possible because of the nature of how iCal and client-side JavaScript works.  This plugin (sqs-event-list) transforms existing data to display on an HTML page.  It can't put that transformed data at a URL, which is what you'd want for an iCal feed to work.

sorry, duh. Of course. The pages need to be actually loaded to run the javascript.

Cherrs anyway.
DM

On 03 Mar 2015, at 17:06, Geoffrey Hing<EMAIL_ADDRESS>wrote:
Unfortunately this isn't possible because of the nature of how iCal and client-side JavaScript works. This plugin (sqs-event-list) transforms existing data to display on an HTML page. It can't put that transformed data at a URL, which is what you'd want for an iCal feed to work.
—
Reply to this email directly or view it on GitHub https://github.com/ghing/sqs-event-list/issues/1#issuecomment-76974646.


Add a changelog

It would be useful to have a changelog for a high level overview of what has changed in each release of futures. This could either be a file in the source or notes on the GitHub releases page for each tagged release. Right now it's necessary to look through the commit log which can be hard to decipher for meaningful changes at times.

FWIW the git tags should all have detailed notes, but if someone wanted to assemble that into a CHANGELOG.md that'd be awesome! Would be easy to duplicate the info between there and the tag in the future!


Add option to specify chunks in iris.util.broadcast_to_shape

🚀 Pull Request
Description

Make it possible to specify the target chunks in iris.util.broadcast_to_shape.
This function is often used to broadcast auxiliary coordinate or cell measure data or weights to the same shape as the data from a cube. If the chunks of the broadcasted data do not match that of the cube, this leads to poor computational performance. Rechunking after broadcasting is less efficient, therefore it is really useful to be able to specify the chunks directly as part of the broadcast.
Closes #5456

Consult Iris pull request check list

It looks like the link check is failing because of the use of http:// instead of https://. I opened #5621 to see if I can fix this.

@pp-mo any update on this?

@pp-mo any update on this?

Sorry yes I am reviewing this, I have some queries + suggestions pending .
I has taken me quite a while to get my head around it -- should finally get to posting later today I think !


docs(aws): updates per single-node/multi-node scenarios

Some AWS-related docs updates/re-org following https://github.com/fermyon/installer/pull/100 cc @FrankYang0529

Re-introduce top-level AWS readme
Remove some duplication from the single/multi-node readmes
minor updates

@michelleN I believe I've addressed all comments -- let me know if there are any others to look at.  Thank you!


Add more detailed docs to CONTRIBUTING

The CONTRIBUTING.md docs don't really explain how to pull down, build, and test Ionic 2. Would be helpful to current and future contributors to work through the local gulp commands, etc.

We should also add a note about the Help Wanted label, incase contributors are looking for some issues to help out with.

Closing this, let me know if there's anything I need to add/change!


fix: Value "[object Object]" is set to css variable when using WithDefault/ToSwatch

🐛 Bug Report
When using .WithDefault on a color value Design Token, the related css variable is set with an invalid value [object Object]

💻 Repro or Code Sample
<FluentCard>
    Test
</FluentCard>
<FluentDivider />
<FluentButton OnClick="ChangeUsingCsharp">
    WithDefault (C#)
</FluentButton>
<FluentButton OnClick="ChangeUsingJs">
    WithDefault (JS)
</FluentButton>
@code {
    [Inject]
    public NeutralStrokeLayerRest NeutralStrokeLayerRest { get; set; } = default!;
    [Inject]
    public IJSRuntime JSRuntime { get; set; } = default!;

    // This produces invalid css variable value
    private async Task ChangeUsingCsharp()
    {
        await NeutralStrokeLayerRest.WithDefault("red".ToSwatch());
    }

    // This one works correctly
    private async Task ChangeUsingJs()
    {
        var module = await JSRuntime.InvokeAsync<IJSObjectReference>("import", "./_content/Microsoft.FluentUI.AspNetCore.Components/Microsoft.FluentUI.AspNetCore.Components.lib.module.js");
        await module.InvokeVoidAsync("neutralStrokeLayerRest.withDefault", "red");
    }
}

🤔 Expected Behavior
When clicking "WithDefault (C#)" the --neutral-stroke-layer-rest should be set to red:

😯 Current Behavior
--neutral-stroke-layer-rest is set to [object Object]

💁 Possible Solution
I currently don't have a  suggestion for the fix.
But as a warkaround it is possible to load the JS module and call the design token .withDefault directly:
var module = await JSRuntime.InvokeAsync<IJSObjectReference>("import", "./_content/Microsoft.FluentUI.AspNetCore.Components/Microsoft.FluentUI.AspNetCore.Components.lib.module.js");
await module.InvokeVoidAsync("neutralStrokeLayerRest.withDefault", "red");

🔦 Context

🌍 Your Environment

OS & Device: Windows on PC
Browser: Microsoft Edge
.NET 8.0.x and Fluent UI Blazor 4.7.2

As described on https://fluentui-blazor.net/DesignTokens:

For Design Tokens that work with a color value, you must call the ToSwatch() extension method on a string value or use one of the Swatch constructors. This makes sure the color is using a format that Design Tokens can handle. A Swatch has a lot of commonality with the System.Drawing.Color struct. Instead of the values of the components being between 0 and 255, in a Swatch the components are expressed as a value between 0 and 1.

What it does not mention but should bee clear, is that this won't work on a 'named' color. So instead of "red" use "#ff0000" and it should work.

Apparently, there is an issue when passing a Swatch to WithDefault. I addded an overload that takes a string value (see PR #2159). Your code will work once this addition is released.


Fix STOMP header escaping when using WebSocket.

Use wire format class to marshal frames, because method
StompFrame.format() does not escape disallowed characters in STOMP
headers and can cause invalid STOMP messages to be sent, as newline and
colon characters in headers are sent as is.

I see no tests to validate, and you'd need to create a JIRA issue to cover this case.

JIRA issue created: AMQ-6699
Test added.
ByteArrayOutputStream usage removed.


Support exponential backoff for istio-agent fetch wasm

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any changes that may affect Istio users.

@wzshiming: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
b353b7276928cfaecab9191e6ce588d38df3bbb9
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
b353b7276928cfaecab9191e6ce588d38df3bbb9
link
/test integ-pilot-multicluster-tests_istio

integ-multicluster-k8s-tests_istio
9e78b7e17bb69a4548d90656b2aeaf98801a2b0c
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wzshiming: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
9e78b7e17bb69a4548d90656b2aeaf98801a2b0c
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
9e78b7e17bb69a4548d90656b2aeaf98801a2b0c
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@wzshiming: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
9e78b7e17bb69a4548d90656b2aeaf98801a2b0c
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Creating reproducible k8s-openebs environment using kargo

https://github.com/kubernetes-incubator/kargo

Can be tracked under https://github.com/openebs/openebs/issues/28

As of 0.5.x release, k8s clusters are being created using kubeadm/kops. Also openebs doesn't mandate a certain way of creating the k8s clusters.
Closing this issue in favor of tracking the requirement under openebs/openebs#28


Player can continue controlling a ship when not seated

I somehow got off my ship while still able to control it. I wish I could say how to replicate it, but there should be a check in place to ensure the player is on the helm when controlling it.
Tested on Fabric.

Addendum: Relogged into the world and found that the game still believed me to be seated, far away from my ship. May have something to do with going at high velocities causing a client/server desync.


Sub project - Testing: Mocking sensor data.

A sub project that would be useful for automatic testing of the software would be to have mock versions of the hardware sensors. This way we can pull in fake data from the mock versions of the sensors.. which allows testing without having the physical hardware setup.

Hi @ethanwillis,
Do you have a possible PR on this issue?


Add size when minified to README

It would be great to add a rough guide (2KB? 10KB? 100KB) of the library gzipped and ungzipped to the README. Without digging it's hard to know quickly whether the network cost is worth it.

I was specifically wondering between using this vs objectDB, which weighs in around 5KB when minified, and figured localForage is probably better in a number of ways, but it might not be worth the additional weight.

Right on.
Not opposed to adding it at all; I should localForage is 27kb minified including the Promises library; 21kb without. It’s not that lightweight a library, though I always say 21kb is still nothing compared to most people’s hero images ;-)
Anyway, If someone can grab the gzipped numbers that’d be cool, but even writing “27kb minified” is probably good.

I would like some help to solve this.


QR code support

any way to add QR scan?

I am also interested in this, but looking through the history of question and request, this is an old one:
https://github.com/serratus/quaggaJS/issues/2
https://github.com/serratus/quaggaJS/issues/120
Are there plans to add this, and are there any workaround or wrapper to do this?

It is likely that the qr reader could be extracted from here : https://github.com/cozmo/jsQR

I have been able to get this working with the https://github.com/zxing-js/library

Seems we have a few people who have managed to get this to work in the various Issues that request it.  Anyone care to take a stab at figuring out a good and proper way to include it into the project?

@memic84 But you dumped quagga or extracted the qr reader ?

@siemiatj I didn't use Quagga, but used zxing-js completely, and implemented my own component. Quagga has ofcourse better support for 1D codes, while the latter has only EAN-13. But i only needed EAN-13 barcode format.

Found a solution on a fork of this project:
https://github.com/ericblade/quagga2-reader-qr/blob/master/example/src/App.tsx

fwiw, my fork does have an experimental support for attaching external readers, it's not 100%, though.  Seems to work in node and browser, as long as you set workers to 0, haven't tested it with live decoding yet, though, trying to get a bunch of maintenance tasks done, and figure out a way to automated test live decode to some degree... probably need to simulate the media devices interface with provided images somehow.. hmm.


[Bug] Fix the chatbot close button

Description
When attempting to use the AI feature on the website, users encounter a problem where the "close" button is obscured by the header, making it impossible to close the AI window. This issue severely hampers the user experience and functionality of the AI feature.
Navigate to the website.
Open the AI feature.
Observe that the "close" button is hidden behind the header.
Attempt to interact with the "close" button to close the AI window...!
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[ ] I am a IWOC'24 contributor.
[X] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

JWOC program is already over @TusharNaugain


RESEARCH - Supporting Multiple LiveConnect Initializations On The Same Page

Current State
There is the LiveConnect module (in the following text the term module will be used) that we distribute and that is used by third parties like Prebid. There is the LiveConnect version that we  distribute via our CDN (in the following text the term builder will be used).
The module accepts a configuration in its constructor functions. The builder expects a configuration either being provided via window.liQ.push or by setting the global property window.LI.
Currently, when LiveConnect (LC) is initialized multiple times on a page, the configuration that was used for the first initialization will prevail, the other ones will be ignored:

if the module is initialized using config A and then there is an attempt to initialize it with config B, the module will check if there is an already initialized LC and if so, just return it; it will also check if the config of the initialized LC deviates from the provided config in appId, collector URL or wrapper name and emit an error if so

if LC is initialized (either via module or builder) and a config is published via window.liQ.push({config: …}), this config will be ignored and an error message emitted

Problem
We have customers that have LC installed on their websites and have a partnership with ad tech companies that also place LC on these websites. This results, depending on the order in which the scripts are loaded, in a LC being initialized with a configuration that belongs to the ad tech company and not to our customer itself.
The assumption for this work is that the partners do not provide an appId in their configurations. This leads to losing information in the data sent to LivePixel - e.g. not having the appId or not starting the SyncContainer.
Goal
When LC is loaded multiple times with different configurations on the same page, the resulting LC must have the configuration that has an appId, if such a configuration was provided on the page.
Proposal
In this proposal the following changes have been made:
The module was adjusted as follows:

current window.liQ is overwritten when the provided config has higher priority than the current one (the presence of appId is the discriminator for now)
adjusted the module to collect and expose configs a config that have been submitted via window.liQ push when a LC instance was already running

The builder was adjusted as follows:

the builder uses a local bus for initialization
the builder evaluates all available configurations upon its initialization and selects one with the highest priority (the one with the highest priority from the ones known to the currently running LC + window.LI + window.liQ - in that order; if no config with appId is present, select the first one or wait for one to appear)
the builder provides a callback when calling the module; this callback is called whenever the module overwrites the current window.liQ; it publishes events into privacy topics and starts the SyncContainer if the applied config permits it

Notes
With this proposal, the global event bus remains untouched when window.liQ is overwritten. That allows to keep all subscribers and does not overcomplicates the code. However, if the old LC is not garbage collected after the new one has been initialized, we will see one error reported to LivePixel twice. After thinking more about it, it is not a big deal. We can, if we see that it is an issue, identify and remove "internal" topic listeners if required when we overwrite window.liQ.
Also, the SyncContainer may be executed multiple times if there are multiple configs with appId and enabled sync (and no gdpr). This will cause no harm. In case the first initialized LC does not have an appId or has the sync disabled or has gdpr enabled, but the second one has an appId, enabled sync and no gdpr, the sync container will work based on the config of the first LC. In either case, if the sync would be executed according to one of the used configs, it will be executed.
TODOs:

[ ] define scenarios with combinations of old/new module and builder, SyncContainer, configurations as well as the times these configurations become available and execute thorough manual tests
[ ] thorough automated testing

Related PRs:

https://github.com/LiveIntent/liveconnectbuilder/pull/61
https://github.com/LiveIntent/synccontainer/pull/31

Author Todo List:

[ ] Add/adjust tests (if applicable)
[ ] Build in CI passes
[ ] Latest master revision is merged into the branch
[ ] Self-Review
[ ] Set Ready For Review status

Unless I'm blind, this doesn't solve the problem of reconfiguring / creating a new liveconnect instance with the new configuration.

Prioritization of configuration is not the way to go. This is the approach we agreed upon: https://github.com/LiveIntent/live-connect/pull/74


When ReousceError happens, sheduler should try to pick_task

Assume we have 3 programs in pending_programs, we successfully start the 1st and 2nd programs, but fail to start_program 3rd, the logic should be continue to pick_task, right?
Please correct me if I was wrong.

Assume we have 3 programs in pending_programs, we successfully start the 1st and 2nd programs, but fail to start_program 3rd, the logic should be continue to pick_task, right?

No, I think.
There are two things here:

The original pending_programs queue has been cloned. Every element in it should be processed.
In the middle of the cloned pending_programs queue, there can be programs that have very high resource requirements, that don't fit the node at the moment, but later in the queue there might be less resource intensive programs that do fit - those should be scheduled to run, before moving to next new task.

The scheduling policy here is ultimately a decision on priority vs. utilization. Currently we don't have proper real world experience from all different kinds of workloads, so we don't know what's the best approach in terms of throughput vs. fairness.
The current implementation does have a negative property in terms of favoring small tasks and possibly discriminating very large tasks, but currently I'm not sure if this is a bad thing. The thing is that given the circumstances in devnet, this reduces chances for annoying or malicious behavior.


COMPAT: GH11769 Fix msgpack ExtType unpack errors on Windows in Python 3.5

closes #11769

thanks! this fixed the issues (still 1 remaining on windows 3.5), but unrelated


Issues with certain blocks not being available for collections

I am having certain problems with my docker bedrock 1.21 server on my lan. Some of my clients will mine in certain patches and not have the ability to grab the items they mined even if they hover over like you would to normally grab things. I have also found that it seems to be a certain radius of blocks that can’t be picked up but once you travel a little bit you can mine. I noticed this is in patches and in most spots you can grab what you mine. I have also found that mobs in the glitched radius cannot move or attack you and seem as though they are stuck by invisible blocks. I have reviewed the docker logs by issuing docker log  yet there isn’t any apparent issues. I just wanted to bring this up as it a glitch in looking to find a soloution for. It has happened with gravel and iron so far. If there is any information and or solutions that could be provided towards this issue that would be greatly appreciated.

This doesn't sounds like a problem specific to this docker image. I would suggest looking in the Mojang bug tracker.

Thank you for the quick response. I’m going to close this issue and do some more research on if this is a current ongoing issue with 1.21 bedrock. I’m going to see if I can find a solution that route.


Improve standard_room.py

Some of the rationale behind the changes I made:

content.lower() instead of content makes the command case-insensitive.
at_mention handles nicknames with spaces (including Unicode spaces) properly.
and makes the conditionals more concise and also allows the conditionals to fall-through to the bot's own handle_message handler if self.short_help_text or self.help_text is not defined, allowing bots to use custom dynamic help texts.

As-is, this commit actually fails :o
...you forgot to import re ;p
(also, regex may be a bit excessive here)

(also, regex may be a bit excessive here)

Not if one wants to handle all sorts of whitespace properly.

Well regex isn't used anywhere else in this file/module/whatever. Mostly I'm wondering about processor/whatever usage, but maybe importing re doesn't really affect that? (idk how that works)
I am curious as to who would (attempt to) embed tabs & linebreaks within their nicknames... ;P

Well regex isn't used anywhere else in this file/module/whatever. Mostly I'm wondering about processor/whatever usage, but maybe importing re doesn't really affect that? (idk how that works)

One could of course enumerate all Unicode characters of the whitespace class and then str.translate() those out, but that makes for messier code and requires regular updates along with Unicode. Substituting a regular expression looks more favorable compared to that.

I am curious as to who would (attempt to) embed tabs & linebreaks within their nicknames... ;P

Bots.


Backport v2.4.0 features

Back-ports https://github.com/RIPAGlobal/scimitar/pull/45 (addresses https://github.com/RIPAGlobal/scimitar/issues/43).

CI green, version looks good & change log spell check is OK 👍 -> self-merging.