Cannot get device list in HA

Configured as indicated with username and pw, want to use only through ewelink cloud
Log does not show errors.
Sonoff.json created with all device inside
But I cannot views any sonoff device in HA .....
config.zip

Having same problem... migrated from HA .99 to .109 and sonoff device not showing in HA .109 states... using v1.10.3 of SonoffLAN.

Having same problem... HA version 0.109.2 and v1.10.3 of SonoffLAN.

having same issue. anyone able to figure out fix?

Hi. I tested version 0.109.2 in two servers. All works fine.
Did my component work for you before?
Maybe you have problems with multicast? They are described in readme.

Hi. I tested version 0.109.2 in two servers. All works fine.
Did my component work for you before?
Mine is a new installation of devices.

Maybe you have problems with multicast? They are described in readme.
The Sonoff.json is created with all device inside. Could there be the same multicast problems?

Hi. I tested version 0.109.2 in two servers. All works fine.
Did my component work for you before?
Maybe you have problems with multicast? They are described in readme.

I installed from new in 0.109.xx.
Perhaps I didn't understand how plugin works, but working only with sonoff cloud, how could be a multicast problem ?

First thanks a lot Alex for thus brand new wonderful component. As pointed out for Dr Zzs willing to see it as a native component. I am using it via HACS now.
I had an issue with my connection to the cloud to download my info devices which disappear when I moved the sonoff component entries in the configuration file from the bottom of it to an earlier position on it. Sounds strange bu it made it work, connect t cloud and give m all the nfo of my devices.
спасибо

@fudu component ONLY controls devices via LAN. The cloud is used to automatically obtain device encryption keys.

I plan to add cloud control in future updates.
This will help users with multicast problems and users of 2nd firmware.
It's a lot of work, I don’t know when I will have time.

@AlexxIT I'm having the same issue. I think the problem started after the update to Release 0.109.2 - May 1 of HA. Thanks man ! Thanks a lot !

Works for me in 0.109.2 on:

Windows
Ubuntu x64 + hassio

What is your environment?

Works for me in 0.109.2 on:

Windows + ha (not venv)
Ubuntu x64 + hassio

What is your environment?

running Ubuntu x64 + hassion on VirtualBox 6.1 (win10).

Even setting devices manually, they still unavailable.

I restored a backup with previous version and the sonoff devices were still unavailable then I tried restarting all systems (rebooting the physical server) and now it works !

Hi. I tested version 0.109.2 in two servers. All works fine.
Did my component work for you before?
Mine is a new installation of devices.

Maybe you have problems with multicast? They are described in readme.
The Sonoff.json is created with all device inside. Could there be the same multicast problems?

I also tried to manually configure the 'configuration.yaml' file, but i cannot views any sonoff device in HA.

thanks Alex.
I solved. The problem was actually a multicast error.
I have moved the server to the same ip class and everything works.

@AlexxIT I was running .99 on a RPi with HASSIO and it was working.  I wanted to test out .109 on a Linux box running Debian and docker.  Thank you for mentioning about Multicast and possible problems with docker.  I did not use --net=host but just forwarded port 8123 with the -p option .... so I'm going to investigate further.
If anyone has .109 running in docker with SonoffLAN working... if you don't mind sharing your docker run statement or docker-compose file... that may help me out..

@fudu component ONLY controls devices via LAN. The cloud is used to automatically obtain device encryption keys.

Ah, ok, so now I understand because it doesn't work: my sonoff devices are on different vlan/subnet  ....

@michelsc75 I heard about problems with multicast in virtualbox. Write about it in readme.

@tkotz8105 https://docs.docker.com/network/network-tutorial-host/

my problem was with being on different subnets. Bridged the two routers and seems to be working now.

Hi, i'm runing hass.io on windows with vmdk file(vmware). Sorry for my bad english but i dont understand, how can i fix multicast error? Thank You.

@enes123 Usually you should configure the virtual network on the bridge. Not on NAT!

@enes123 Usually you should configure the virtual network on the bridge. Not on NAT!

OMG, thank you so much. It Worked.

hello done everything as it says, json file is there. restarted HA few times, done a couple of switches on lan mode with ewelink but can't get them to appear in the device list of HA. no clue about the multicast networks. What shall I try next? I'm very new to HA probably I'll have to give up :)

Same issue here.  Only device is a Micro (firmware 3.4.0) which I see in the json but does not show up in my devices.  hassio 0.109.5 running on Ubuntu Server 20.04. Installed through hacs.  No errors in logs.

@Nerijus1984 what does two networks mean? The second case is not a "guest" with disabled communication between devices?

@brandon-page try turning on / off the device through the mobile application

@Nerijus1984 what does two networks mean? The second case is not a "guest" with disabled communication between devices?

@AlexxIT just recently I've upgraded to new isp and obviously I'll have the new router. Didn't wanted to reconnect couple of my iot devices to the new ssid (because some people having issues rexonectig them to the new SSID) so I've logged in to the router and setup new ssid with the old isp credentials though I'll have a separate network for Iot. My laptop with HA virtual machine is connected to the same network as sonoff devices so it should pick up as per instructions on YouTube I suppose.

@Nerijus1984 do not forget to enable bridge mode in the network settings of the virtual machine.
I heard VirtualBox has problems with multicast traffic anyway

Try new version #99

After switching to master cloud setup works, so overall success.  However, when I try to use devicekey (with or without cloud) I get the following error:

Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/setup.py", line 171, in _async_setup_component
hass, processed_config
File "/config/custom_components/sonoff/init.py", line 134, in async_setup
v['params']['connection'] = 'cloud'
KeyError: 'params'

@brandon-page please show config for this error (hide private data)

@brandon-page fixed in latest master version

I installed the new master release, now it runs only in cloud. If I force local mode all devices disappear

@Tkthsride don't understand. Whats mean force local mode?

@AlexxIT sweet all my sonoff devices finally are here in HA. Thanks for a great job @AlexxIT. Just can't get my TH and POW to show the measurements on the main screen (probably is my lack of skills) but eventually I'll find that as well. Great job @AlexxIT really appreciate what you do.

@Nerijus1984 TH and POW don't show automatically. You need to create template sensors as it described in readme.

@Tkthsride don't understand. Whats mean force local mode?

Sorry I try to be more clear. I used this code in config:
sonoff:
username<EMAIL_ADDRESS>password: mypassword
mode: local
reload: always
With this configuration I see J.son including devices but I don't find them as entities.
If I put the row "mode: local" after # and restart I find them and can configure them in the interface, they run and are indicated as connected in cloud.
If I 'de-comment" the row "mode: local" I go back to original configuration, the entities result "disconnected".
It seems that I cannot connect to them in local mode.
Anyway thanks for your great job

@Tkthsride one of the reasons why I added cloud mode. I wrote possible problems with local connection in the readme. But not all users manage to defeat them.
There is no problem with a cloud connection :)

I have a Sonoff 4CH Pro R2, like others here I did everything in the instructions:
added the config in YAML, HA recognizes the sonoff component, creates the JSON file with the correct info inside, but HA never creates the entity. My HA is on a VLAN that can access the IoT VLAN where the Sonoff device is.

@arahag try new beta version #99

Thanks @AlexxIT , jus switched to Master in HACS and works like a charm!!


python310Packages.html5-parser: 0.4.10 -> 0.4.11

Description of changes
Diff: https://github.com/kovidgoyal/html5-parser/compare/v0.4.10...v0.4.11

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build calibre

Result of nixpkgs-review pr 226383 run on x86_64-linux 1

3 packages built:

calibre
python310Packages.html5-parser
python311Packages.html5-parser


[Question]: About the GOT-OCR2_0 model of Xinference

Describe your problem

Error message:
Fail to access model(GOT-OCR2_0).HTTPSConnectionPool(host='upload.wikimedia.org', port=443): Max retries exceeded with url: /wikipedia/commons/thumb/d/dd/Gfp-wisconsin-madison-the-nature-boardwalk.jpg/2560px-Gfp-wisconsin-madison-the-nature-boardwalk.jpg (Caused by SSLError(SSLEOFError(8, '[SSL: UNEXPECTED_EOF_WHILE_READING] EOF occurred in violation of protocol (_ssl.c:1000)')))

However, there is no problem importing the TTS model, which can be successfully imported. What is the reason for this?

In addition, I found an error when importing the OCR model in Xinference, but the model works fine：

Xinference seems upload something to upload.wikimedia.org.
So, it's network issue.

However, using a Python client of Xinference to try the OCR API is no problem and returns text successfully. If the TTS model where ragflow is deploying Xinference is not in this situation, an error is reported only when OCR is deployed. After I ask the ragflow communication group, I find that someone in the RagFlow communication group is in the same situation.

upload.wikimedia.org cannot be accessed using a domain name due to the DNS of the server. Can I download Upload.wikimedia.org locally and upload it to ragflow?

But I ping upload.wikimedia.org is successful, so far only the OCR model is failed and the TTS model is successfully added. The OCR model is downloaded locally, and a Python client using Xinference can also export text. How can I load it into ragflow successfully? Looking forward to your reply！

What about ping it in xinference docker container?

I deployed xinference locally and ragflow deployed with docker.

@ZxnSnowy  Same problem, has it been solved?

@ZxnSnowy Same problem, has it been solved?

not yet

@ben-8878 Do you have any idea about this：

已经解决了，谢谢。

@ben-8878 Can you share your solution？

容器内解析不了你的域名，需要把你的域名和ip对应起来，
extra_hosts:

域名：ip

咱两的情况可能有点区别，我的基础url是一个域名，通过extra_hosts 指定域名对应的ip,就可以了，你的是ip+port，你需要确认你的服务的访问权限是否放开了，像ollama服务默认是<IP_ADDRESS>，如果是ollama，http：ip+port方式，容器内无法访问，

目前内网其他电脑可以实现服务器的IP地址访问，您的意思是在容器内的/etc/hosts 把upload.wikimedia.org域名和对应的 IP 地址写进去吗？比如 <IP_ADDRESS> upload.wikimedia.org

你可以试试这样，我报upload.wikimedia.org错的时候好像开了VPN，关了VPN报另一个错：Fail to access model ERROR: Connection error.

我是离线环境，添加qwen2vl时也遇到了这个问题

@ZxnSnowy Same problem, has it been solved?

not yet

解决了吗

@DankerMu Should be the server side can not access the reason for this URL, has not yet found a solution。


Add FotoJet app

FotoJet makes it easy to make graphic design and edit image.

Update description

How about "Free online designer and image editing tool"?

Any suggestion？

@henrywong that was my suggestion for description

That's ok


Accessing Ethereum user's account from non-view React modules  (e.g Redux sagas)

✅ Prerequisites

[x] Did you perform a cursory search of open issues? Is this question already asked elsewhere?
[x] Are you reporting to the correct repository (magic-sdk)?

❓ Question
Hi there,
I was wondering if there's any way to access user's ephemeral private keys from React components that are not presentational and thus do not include the <m.relayer>. An example could be a redux saga that executes asynchronous code.  In a saga, after the user is successfully authenticated,  the following code snippet hangs:
const signer = provider.getSigner();

// Get user's Ethereum public address
const address = await signer.getAddress(); // This never resolves

Same would happen to logic components and middlewares.
As per the documentation, "After encryption of the keys with the HSM, the encrypted key is then stored on the client-side iframe as well as uploaded to the Magic auth relayer for redundancy, in case the encrypted key on the client-side is accidentally removed."
Does this mean that every interaction with the blockchain that requires a signer has to performed inside presentational components that include the iframe <m.relayer>?
🌎 Environment

Software
Version(s)

"@magic-sdk/react-native"
"^2.7.1"

Browser
React-Native

yarn
1.22.4

Operating System
MacOs Catalina 10.15.6

You can invoke your Magic instance from anywhere in your React Native app, but for the response to process, you'll need to be rendering <m.Relayer> somewhere (anywhere). I recommend adding <m.Relayer> in the root component of your app!

Thanks for your response @smithki , unfortunately that doesn't seem to work.. have you guys tried it before? Curious to see if there might be something wrong on my end.

@JavierTrujilloG Sorry for the late reply. I'll take a look using redux saga


Methods summary column width in API reference

The Methods summary table in API reference seems to have fixed relative column widths, which makes it look bad in some cases.
For example on Microsoft.CSharp.RuntimeBinder.Binder, it looks like this for me:

I think this table would look better with the first column wider, relatively to the second column.
As far as I can tell, this is caused by the following CSS rules:
table.nameValue td:nth-child(1) {
    width: 30%;
}
table.nameValue td:nth-child(2) {
    width: 70%;
}

I expect there is some way to use CSS to make it look for example like this, while also ensuring other tables still look good:

Screenshots taken using Firefox 49 on Windows 10.

@DuncanmaMSFT can your team look at this issue? Thanks.

@svick can this be closed? The behavior seems better now.


Include declustered entities in cluster callback

Requested on the Forum here: https://groups.google.com/forum/#!topic/cesium-dev/hUrOxJQjjzg
They would like a way to access the entities that have been unclustered in the cluster callback function when the event is fired.

Requested again: https://groups.google.com/forum/#!topic/cesium-dev/fxr0jP5pB7c

This would be useful to fix an issue I'm dealing with. Though there may be better fixes for the issue, perhaps someone can point me in the right direction if this could be the fix or if I should open a new issue:
I have some buttons which allow to show only certain categories of entities. So clicking on one of these buttons will hide all entities except those in the specific category; in case the entities are in that category they will be set to show. However I am finding when "activating" a category of entities, the entities that are clustered are correctly hiding the single billboards (only the cluster billboard is showing), whereas the single labels are not hiding (I'm seeing strange behaviour, such as empty labels showing, or a few characters of the labels showing!).
I thought a way to fix this might be to check whether each entity is in a cluster or not; if it's in a cluster I will explicitly hide it's label, if not I will explicitly show it's label. However I don't seem to have any way of telling whether an entity is currently in a cluster, since there is no "decluster" event...

@volski There hasn't been any activity on this item recently.
If you'd like to add more information about your use case, that may help us prioritize.
If you are interesting in contributing, please let us know and we'd be happy to discuss implementation or review a PR.
Thanks!

Hello,
We would love some kind of way to detect when a cluster has been de-clustered. Or, at the very least, get access to the previousClusters field in the EntityCluster class. It seems like it is a property but it is not exposed. This would allow us to dynamically add boundaries around our clusters so we can identify their outer limits. Any assistance would be greatly appreciated.


Can't initiate the integration

Hi, when I try to configure it in configuration.yaml I obtain and error message:
Invalid config for 'securitas' at configuration.yaml, line 298: expected str for dictionary value 'securitas->username', got 12345678
My login is a number, (of course is not 12345678 but the number of my identity document).
Is there any problem because of the format of my login or it is a mistake from a noob? I am from Spain and it's the login that I have. Thx

Put your username in double quote like this "1234567890"

OMG what a noob mistake. Solved. Thank you so much


multiple changes to munin

option to query valhalla for keywords and for the results, fetch the hash info (needs valhallaAPI)
bumped version number
add display of VT quota
bugfix: limit written CSV to top10 AV-vendors, even if all are queried
README: updates and munin-host had munin-py usage info

does fin7-1.txt have a use?


serialPort.list only shows single most recently connected port

Using ubuntu 14.04 LTS
serialPort.list(
    function (err, ports) {
        console.log(ports); //this is only logging the single most recently connected serial port.
    }
);

any ideas?

Closing as no follow up information, but were working on linux listing here.
Perhaps these were identical devices? Weve seen that before and are working on it https://github.com/voodootikigod/node-serialport/issues/610


Join convex hulls

Is it somehow feasible to join the resulted set of convex hulls into one solid object without intersecting geometry? I am more than satisfied with outer shape that this addon does, however, there is bunch of separate objects in the resulting output that cannot be actually merged together due to intersecting faces. That feature can be used by many people who are doing any sort of gamedev production for getting object collision shapes.

I'm not certain why this is something you would want?  The entire purpose of the convex decomposition process is to produce a set of compound geometries appropriate for real-time collision detection.  This is how it works in UE4 when you create collision volumes using V-HACD.
If all you want is a simplified mesh, maybe a mesh simplification tool is more what you are looking for?

I'm not certain why this is something you would want? The entire purpose of the convex decomposition process is to produce a set of compound geometries appropriate for real-time collision detection. This is how it works in UE4 when you create collision volumes using V-HACD.
If all you want is a simplified mesh, maybe a mesh simplification tool is more what you are looking for?

The problem with mesh simplification is that it does not gurantee that the shape of the result is gonna be convex and will be able to wrap the actual geometry. V-HACD produces the perfect shapes I need for collision, the only problem is that they contain some geometry inside which add extra overhead on my collision system. I am not working in UE, but in a custom engine, and the collision detection system is very different here it seems.

you can play with minVolumePerCHas described here http://kmamou.blogspot.com/2014/12/v-hacd-adaptive-convex-hulls-sampling.html

It seems you got me wrong. I am absolutely fine with the number of vertices in the resulted hull. The problem is that the resulted hull is basically a bunch of separate convex shapes. I need to find a way to run a sorto of boolean operation to make these pieces of geometry merge into one without any faces inside. Would that be possible to do somehow?

I think you, in detail, need to explain what you plan to use the end result for, and why the initial mesh you are giving to V-HACD, is not good enough for that purpose.
As mentioned by @jratcliff63367 the point of decomposing objects is to get multiple convex shapes so that you can use them for physics simulations. Most physics simulations are quite bad with concave shapes as collision shapes, but good with convex shapes and can often simulate multiple rigidly joint convex shapes.
At least I have a hard time understanding why you would want to rejoin the meshes as this would once again produce a concave mesh and thus usually not improve the physics simulation.
p.s.
Your input mesh (concave, single) -> Result from V-HACD (convex, multiple) -> Boolean join remove internal faces (concave, single)

I think you, in detail, need to explain what you plan to use the end result for, and why the initial mesh you are giving to V-HACD, is not good enough for that purpose.
As mentioned by @jratcliff63367 the point of decomposing objects is to get multiple convex shapes so that you can use them for physics simulations. Most physics simulations are quite bad with concave shapes as collision shapes, but good with convex shapes and can often simulate multiple rigidly joint convex shapes.
At least I have a hard time understanding why you would want to rejoin the meshes as this would once again produce a concave mesh and thus usually not improve the physics simulation.
p.s.
Your input mesh (concave, single) -> Result from V-HACD (convex, multiple) -> Boolean join remove internal faces (concave, single)

The engine I work with does collision detection through some BSP Tree algorithm, I don't know how it exactly works. But when I use these shapes it becomes laggy. The joined result of what V-HACD does basically produces a simplifed mesh that wraps the entire original mesh, yet ignores small details. The mesh simplification and decimation algorithms that I know do not preserve the original shape which is not something that I need.

I would suggest you test this in something like Blender. I am still quite unsure that this will help your performance in the end.
(https://blender.stackexchange.com/questions/71687/removing-internal-geometry)
Also, am I right to assume that when you say preserve original shape you mean that it encapsulate (i.e. all original data-points lie withing the new hull), as opposed to preserve as in being the exact same, which V-HACD and mesh-simplification methods in general doesn't do.
For the Physics Engines I've used in the past the experience has been something like the following:

Using the full mesh for collision -> Horrible Performance
Using a convex hull for collision -> Good performance but too inaccurate collisions
Decompose to multiple convex hulls. Create a compound shape, add each child object disable collision between object within the same  shape. -> Decent performance, quite accurate collisions.

Yeah, that would be accurate for physics engines system. Our collision works through binary space partitioning. It is not horrible with full mesh for collision, but sinplified geometry is prefered. Intersecting geometry in collision leads to very long export process (tons of recursive calculations) and worse performance in the game.
I am sure about what I need, since we already have assets with that collison but do not currently have access to software that was able to produce them.
The boolean operations in Blender do not work, because geoemetry does not intersect precisely.


New version: PolyChaos v0.1.3

Registering package: PolyChaos
Repository: https://github.com/timueh/PolyChaos.jl
Created by: @timueh
Version: v0.1.3
Commit: 5c79a5afbd11f3fce9879262758d74dc5eafc0a7
Reviewed by: @timueh
Reference: https://github.com/timueh/PolyChaos.jl/commit/5c79a5afbd11f3fce9879262758d74dc5eafc0a7#commitcomment-34067552

The main commit this new version refers to is this: timueh/PolyChaos.jl@0f49651

Please add (at least)
[compat]
julia = "1"

to your project file and retrigger the bot.


Adds support for automatic retry on 502, 503, and 500 errors + refactoring of duplicated code

Hi, I've had some problems with Spotify API returning 502 errors randomly on all types of requests so I thought that adding an automatic retry support into the library might be a good idea.
It's off by default and it's fully configurable. You can specify the maximum number of tries and the time between individual attempts.
It's implemented for all requests both in synchronous and async variants.

So far the configuration support has not yet been implemented into WebAPI factory as I'm not sure how to do it properly (-> in a way it doesn't clash with your design ideas).

Hi,
Thanks for the PR, good idea!
I'm personaly not a fan of Auto-Retry, especially for 5XX error codes, since these shouldn't happen and spotify should take care of it. (Did you tell them btw.?) But I guess nothing is wrong with implementing it while it's disabled by default.
I left some comments, maybe you can take a look @petrroll

Thanks again! :)


Image URL field broken

Hi,
I have a trivial problem with open exchange.
You can see on this page https://openexchange.intersystems.com/package/JSON-Web-Token-Generator the image is not shown.
When I edit the application, image url field contain /mp/img/packages/621/icon.svg.
I attempt to update the image URL by https://jwt.io/img/icon.svg and save, but when I edit again the image URL is reset to /mp/img/packages/621/icon.svg.
Thank you.
Lorenzo.

Now we use only image uploading before send for approval. You can choose "Upload image" option in "Settings" menu.


Drivetrain cleanup and command changes

Wrote preliminary auto 3b (AutoDriveLimlightShoot) and LimelightSanityCheck method
Removed unused include files in group commands
Removed unused ShooterRunTImeout command
Cleaned up button assignments in RobotContainer

Looks good to me! I'm fine leaving the extra comments in DriveLimelight for the time being


Retrieving spacing values

Is there anyway I can get spacing value at runtime? Something like:
import { spacing } from 'nativewind'
import { Dimensions } from 'react-native';

const { width } = Dimensions.get('screen');

const ASPECT_RATIO = 9 / 16;
const PADDING = spacing(4) // 16

<View
  style={{
     height: (width - (PADDING * 2)) * ASPECT_RATIO}
  }}
>
</View>

No. But you should be using a combination of  React Natives aspectRatio and padding styles https://reactnative.dev/docs/layout-props#aspectratio
Then you can use the aspect- and p- classNames.

No. But you should be using a combination of  React Natives aspectRatio and padding styles https://reactnative.dev/docs/layout-props#aspectratio
Then you can use the aspect- and p- classNames.

Hey, I think you misunderstood what I meant. I'm using react-native-youtube-iframe and it is required to pass a height props.
In other case where I have to create a 2 column grid. I can't use className props as I need to calculate the style myself.
const WIDTH = Dimensions.get("screen").width;

const PADDING = spacing(2);
const SPACE_BETWEEN = spacing(4);

<View className="flex flex-row flex-wrap justify-between">
          {episodes.map((episode, index) => (
            <View
              style={{
                width: WIDTH / 2 - PADDING - SPACE_BETWEEN,
                marginBottom:
                  index < episodes.length - 2 ? SPACE_BETWEEN * 2 : 0,
              }}
              key={episode.id}
            >
              <EpisodeCard episode={episode} />
            </View>
          ))}
        </View>

Does react-native-youtube-iframe need a height? It looks like it will accept aspectRatio though the viewContainerStyle
prop and width/height are only used for shortcuts for styles. You could also ignore the viewContainerStyle and just map to webViewStyle
I don't understand your second point about 2 column grids. You can use flexbox styles to create 2 column grid with margin and you can use aspectRatio to have a responsive height.

Does react-native-youtube-iframe need a height? It looks like it will accept aspectRatio though the viewContainerStyle prop and width/height are only used for shortcuts for styles. You could also ignore the viewContainerStyle and just map to webViewStyle
I don't understand your second point about 2 column grids. You can use flexbox styles to create 2 column grid with margin and you can use aspectRatio to have a responsive height.

It does require a height as it mention in the docs here:


Cause NotifyMigrateRepository to emit a repo create webhook

This PR simply makes NotifyMigrateRepository emit a Create Repo webhook.
The reason for no new payload is that the information sent to
NotifyMigrateRepository is only essentially the same as
NotifyCreateRepository
Fix #13996
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Codecov Report

Merging #14004 (6004547) into master (b8c58ed) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master   #14004      +/-   ##
==========================================
- Coverage   42.23%   42.21%   -0.02%
==========================================
  Files         710      710
  Lines       77261    77269       +8
==========================================
- Hits        32629    32618      -11
- Misses      39266    39274       +8
- Partials     5366     5377      +11

Impacted Files
Coverage Δ

modules/notification/webhook/webhook.go
49.65% <75.00%> (+0.35%)
:arrow_up:

models/repo_mirror.go
2.38% <0.00%> (-11.91%)
:arrow_down:

modules/cron/tasks_basic.go
87.35% <0.00%> (-3.45%)
:arrow_down:

services/pull/check.go
48.90% <0.00%> (-2.92%)
:arrow_down:

modules/notification/ui/ui.go
93.05% <0.00%> (-2.78%)
:arrow_down:

modules/process/manager.go
72.50% <0.00%> (-2.50%)
:arrow_down:

modules/queue/unique_queue_disk_channel.go
53.84% <0.00%> (-1.54%)
:arrow_down:

services/mirror/mirror.go
15.78% <0.00%> (-1.11%)
:arrow_down:

models/notification.go
66.25% <0.00%> (-0.99%)
:arrow_down:

services/pull/pull.go
40.68% <0.00%> (-0.50%)
:arrow_down:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c58ed...6004547. Read the comment docs.


PP-6297: Use digital marketplace's cookie banner code

This commit demonstrates the use of DM's cookie banner code.
How we made this work:

Add data-module="dm-cookie-banner" in the div with id
global-cookie-message in the layout.erb file.
Added code from
https://github.com/alphagov/digitalmarketplace-govuk-frontend/blob/5b8a9003877432d650f8d965c6c5f0f4886127f2/src/digitalmarketplace/components/cookie-banner/cookie-banner.js
into cookies.js with the caveats:

using import { getCookie, setConsentCookie } from '../../helpers/cookie/cookie-functions' doesn't work here. To get round
this, we copied code from
https://github.com/alphagov/digitalmarketplace-govuk-frontend/blob/5b8a9003877432d650f8d965c6c5f0f4886127f2/src/digitalmarketplace/helpers/cookie/cookie-functions.js
and put it in cookies.js too
we didn't add import InitialiseAnalytics from '../analytics/init' as
this story isn't about getting Google Analytics to work

Upon clicking Yes or No in the cookie banner, manual testing shows that the
cookies get set correctly.

Superseded by https://github.com/alphagov/pay-product-page/pull/213


mandiantadvantagethreatintelligence: Bugfix - Fixed issue causing bearer token error for NEW installs

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist
Please check if your PR fulfills the following requirements:

[ x] Testing of all the changes has been performed (for bug fixes / features)
[ ] The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
[ ] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[ ] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[ ] Verify all checks are passing.
[ ] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[ ] Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type
Please check the type of change your PR introduces:

[ ] New App
[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Security Considerations (REQUIRED)

[ ] If you are exposing any endpoints using a REST handler,
please document them in the manual_readme_content.md.
[ ] If this is a new connector or you are adding new actions

[ ] Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
with the service that the connector is integrating with.
[ ] If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.

[ ] Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
[ ] Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
the Vault API.
[ ] Are you are marking code to be ignored by Semgrep with nosemgrep?
If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

Describe the current behavior that you are modifying.

This will never work for a new installation. There is a code error that tries to add a header with the bearer token from the state file. However, there will never be a bearer token for a new install, so the _make_rest_call function will exception out because the bearer token doesn't exist, and thus never make the rest call to actually get the bearer token
What is the new behavior? (OPTIONAL)

Describe the behavior or changes that are being added by this PR.
Does a _state.get("bearer_token") rather than an _state['bearer_token'], the former will not cause an exception, the existing code (latter) will.

Other information (OPTIONAL)

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

changes are incorporated in "Jang lookup indicator exception bugfix #5"


Dead url reference

Url: https://azure.microsoft.com/resources/templates/app-service-docs-windows for Azure Quickstart Templates in the Review the template section leads to an error page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2943267d-0c8a-ad06-5a6c-f5c27b1fc16f
Version Independent ID: 48721b9e-5b4c-9cdc-fa38-6bd1edbbbc69
Content: Create an App Service app using an Azure Resource Manager template - Azure App Service
Content Source: articles/app-service/quickstart-arm-template.md
Service: app-service
GitHub Login: @msangapu-msft
Microsoft Alias: msangapu

Hi @mrochon, thanks for bringing this to our attention we will update this doc shortly

@mrochon, Apologies for the delay! The URL must be fixed now. Thanks for reporting this issue.

If you have further questions on this, please tag (@Grace-MacJones-MSFT) in your reply. We will follow-up further.
We appreciate your valuable feedback. Thank you.


Update README to reflect new key generation service

https://github.com/Fornoth/spotify-connect-web/issues/104

Thank you!


Crash when returning generator from function with option argument

This is a:

[x] Bug Report
[ ] Feature Request
[ ] Question
[ ] Other

Which concerns:

[ ] flow-runtime
[x] babel-plugin-flow-runtime
[ ] flow-runtime-validators
[ ] flow-runtime-mobx
[ ] flow-config-parser
[ ] The documentation website

What is the current behaviour?
This snippet:
type Options = {};

export const makeApiCallSaga = (opts: Options) => {
  return function* apiCallWatcherSaga (): Generator<*, void, *> {
  };
};

Causes the following crash:
ERROR in ./src/sagas/api.js
Module build failed: TypeError: /Users/da_petcu21/Work/portal-frontend/src/sagas/api.js: Property id of VariableDeclarator expected node to be of a type ["LVal"] but instead got null
    at Object.validate (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-types/lib/definitions/index.js:109:13)
    at validate (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-types/lib/index.js:505:9)
    at Object.builder (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-types/lib/index.js:466:7)
    at Function (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-plugin-flow-runtime/lib/transformVisitors.js:427:64)
    at NodePath._call (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-traverse/lib/path/context.js:76:18)
    at NodePath.call (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-traverse/lib/path/context.js:48:17)
    at NodePath.visit (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-traverse/lib/path/context.js:105:12)
    at TraversalContext.visitQueue (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitSingle (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-traverse/lib/context.js:108:19)
    at TraversalContext.visit (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-traverse/lib/context.js:192:19)
    at Function.traverse.node (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-traverse/lib/index.js:114:17)
    at NodePath.visit (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-traverse/lib/path/context.js:115:19)
    at TraversalContext.visitQueue (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitMultiple (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-traverse/lib/context.js:103:17)
    at TraversalContext.visit (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-traverse/lib/context.js:190:19)
    at Function.traverse.node (/Users/da_petcu21/Work/portal-frontend/node_modules/babel-traverse/lib/index.js:114:17)
 @ ./src/sagas/login.js 12:11-27
 @ ./src/sagas/index.js
 @ ./src/store/configureStore.dev.js
 @ ./src/store/configureStore.js
 @ ./src/index.js
 @ multi ./tools/webpack-public-path webpack-hot-middleware/client?reload=true babel-polyfill ./src

What is the expected behaviour?
It should not crash

Which package versions are you using?
├─<EMAIL_ADDRESS>│  └─<EMAIL_ADDRESS>

released in v0.10.0

Cool! Thanks! There were actually some more bugs I think I found, just didn't get to find the MRE and then report them. I'll report them tomorrow.
Marius Petcu,
Web, Mobile (https://petcu.me) and Game Developer (https://critique-gaming.com)
On 17 Mar 2017, 01:06 +0200, Charles Pick<EMAIL_ADDRESS>wrote:

released in v0.10.0
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (https://github.com/codemix/flow-runtime/issues/72#issuecomment-287219174), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAaIHOIBV5Y0vTp379c-ZRs4AOhdzWF1ks5rmcB3gaJpZM4MfbN6).


How can I react to the stories?

How can I react to UserStories?
Should I configureMediaShare with text or what?
P.S.
No good documentation, that's sad. I wanted to help with docs, but library is moving to TS and I just can't find any good reason for this. JS library is pretty cool and beautiful, should we fork? 😄

Not implemented as I think.
This library can do it easily:
https://github.com/mgp25/Instagram-API/blob/519aae6091b0cd8960e42a5942d16834cc526bf3/src/Request/Direct.php#L833


What is stored in the feeds folder?

What is the feeds directory for OpenBazaar? What is stored there?

Nothing at the moment. It's for a potential future feature.

What is that potential future feature? Why is it called "feeds"?


Improve Roll and Pitch estimation in Localization

We can see that there is a wobbling of ego vehicle points as the vehicle drives through speed bumps. We would like to make sure that these are estimated correctly in Localization (perhaps in EKF).
example scene: https://www.youtube.com/watch?v=jd_HBTl_Gtw

Progress:
To understand the source of the problem, I performed the following tests one by one:

To make sure that EKF is the source of the problem:
I ran the localization completely with NDT. I gave NDT output as initial pose to NDT and published the map to baselink transform with NDT poses. In this way, I completely removed EKF from the system. I compared these results with the default autoware results.
You can see the results in the video here

Test Results: As seen in this video, the point cloud shakes up and down in the default autoware (NDT + EKF) when passing through the speed bump. This error does not occur when run with NDT only.

Simulation Environment Test: Ensuring that EKF inputs, sensor calibrations or any other vehicle specific problems are not causing the error.
I created the same scenario in a simulation environment and reproduced the same problem with awsim_labs_sensor_kit and sample_vehicle.
You can see the results in the video here
Test Results: In the simulation environment, I also saw that errors occurred when passing over bumps. From here I came to the conclusion that any vehicle specific problem (calibration, input twist data ) is not the source of the problem.
At the same time, I visualized the changes in pitch angle when it passed through the speed bump, both in the simulation environment and with real life data.I observed similar behavior in both. You can see these results below:

Next Steps:
After making sure that EKF is only the source of the problem, I will try to solve the problem by debugging EKF in the simulation environment.

I tried to use the Roll and Pitch values from the IMU directly in EKF.

Simulation Test :
The problem was completely solved with this method in the simulation environment:
Test video is here

NDT and EKF roll and pitch values gave very similar results in simulation environment:

Real World Test
In tests performed on the real vehicle, I saw that the results improved, but the problem was not completely solved.
Test video is here

I tested EKF which is IMU added with 3D Distortion Corrector PR
I've seen the results get better as a result. I achieved very good results when IMU added to EKF and 3D Distortion Corrector were used together. However, the problem is not completely solved yet. So I'll keep working on it
The test video link is here

I will create a PR for this issue using the results below as reference.

Simulation Test:
In the tests carried out in the simulation environment, you can see below that using imu directly solves the roll, pitch, and position z in EKF instead of calculating them with the 1D Filter:

Buna ek olarak aşağıdaki videoları inceleyebilirsiniz:
Default Autoware test video is here
EKF with IMU Integration test video is here
Real World Test:
Although the same level of performance cannot be achieved in real-world tests due to different factors, there is an improvement. It also seems that the results are further improved by using the 3D Distortion Corrector, which has been newly merged into Autoware.You can find the results below:

Real World Test Video is here

I created new PR for solving this problem . Tested with adding delay compensation to roll and pitch.
https://github.com/autowarefoundation/autoware.universe/pull/8095

Related PR is merged. I will close the issue


Enable Auto High Beams and more

A reflash of panda is required.
kill OP
exceute make in /panda/board while in main OBD2 port
This will forward all signals and therefore a 120ohm resistor is required between pins 12 and 13

ECU.CAM values not needed
With forwarding enabled and the giraffe on "proxy stock adas w/ panda" 0101

yeah, I wanted to do this for a while. Only issue is the missing 120Ohm resistor on old Toyota giraffe (and the need of changing the giraffe switches). Probably solvable by issuing an alert if camera is not connected to panda bus 2.

Good then do that. So you did forget the 120 ohm resistor. Took me months to figure out why the forwarding was not working. You could of just told us who bought defective giraffes

How do we check if camera is not connected to panda bus 2?

@rbiasini, @arne182 asked me to test this on my 2017 Toyota RAV4 XLE (non-hybrid). It appears to forward the 0x414 message for AHB just fine. My only concern is that shoving the 120ohm resistor into the giraffe obd connector for parallel pins 12-13 is not always reliable. My solution was to make an opening on the front of giraffe and solder directly to the pin 12 and 13 pads.

Ok, made this change internally and it will be in next release, without breaking OP for users without the 120Ohm resistor on giraffe CAN3

Working for me on Prius Prime with 120 ohm resistor.

Tested on Prius Prime with 120 ohm resistor.

With much patience and assistance from Arne, I have finally got the 120-ohm resistor soldered in and installed, I have flashed the Panda before sticking it to the giraffe. We have one happy zoo here and the AHB work beautifully. HINT: Tou can't really test the AHB in the daytime. WHo would have thought?
Excellent work by Arne on this and other parts of his branch. Thanks a million for your dedication to the cause.
2017 Toyota Rav-4, LeEon, grey panda, a toryta giarafffe and two pesky parrots.


Implement Merge method

It would be nice to implement a merge method, like system.data.dataset has.
Right now if I need to roll up many smaller parquet files I need to open each file and iterate through it row by row.  An optimized approach would be great.

@we7313 as DataSet implements IList<Row> you can simply do ds1.AddRange(ds2) - that will do merge if schemas match. Or would you expect merge method to also merge schemas?

AddRange is exactly what I was looking for thanks!

@we7313 you're welcome. I think a method which can also merge schemas would be extremely useful so I'll keep this open.

@aloneguid picking this up. Spark does this seamlessly would be good to do this too.

Adding a merge method to DataSet but will talk through with you. Spark does seamlessly looking at directory of parquet files. Longer term this might be better. Worth discussing whether parquet-dotnet is the right place for this.

It seems that the AddRange functionality has been removed in the more recent builds.  I know this was last available in the 1.4 builds, but is no longer available in the 1.5 builds.  I use this to take smaller parquet files and roll them up into a bigger file (with the same schema).

@we7313 1.5 is still in preview, there are a few breaking changes, can you open a new issue please ;)


Upgraded flume-ng-core version to 1.6.0-cdh5.5.0

Backported to Cloudera Flume 1.6

Thanks for the pull!


StatefulSet AutoDelete blog post

Blog post for statefulset autodelete.
KEP 1847
Implementation PR #99728

Nice!
One nit though. Please change all the site links to relative links If you have a hyperlink that starts https://kubernetes.io/docs/, that should be /docs/…

thx, done.

I checked this with a local server and it seems to look good.

From a docs (and blog team) point of view, this informally LGTM.

/milestone v1.23
/cc @jlbutler

Take two:
/milestone 1.23

@karenhchu is the date (2021-12-16) right for this one?

@karenhchu is the date (2021-12-16) right for this one?

It's correct. The path also needs to be updated: (content/en/blog/_posts/2021-12-16-StatefulSet-PVC-Auto-Deletion.md)

This could use a technical review from SIG Storage (I hope: just a formality).
For SIG Docs: /lgtm

/assign @smarterclayton

This could use a technical review from ~SIG Storage~ a relevant SIG (I hope: just a formality). For SIG Docs: /lgtm

We had sig-apps review the documentation, @smarterclayton from that sig was kind enough to do that and hopefully his graciousness will continue :)

/approve

/lgtm
I can't see anything wrong with this article, it's due to publish today, and nobody has raised a serious objection.

@mattcary if you want to do post-publication tweaks based on https://github.com/kubernetes/website/pull/30596#pullrequestreview-834238441 (in a new PR) then please do; if you're happy with it as it is, that's fine also.

@mattcary if you want to do post-publication tweaks based on #30596 (review) (in a new PR) then please do; if you're happy with it as it is, that's fine also.

Thanks Tim. I don't disagree with any of the suggestions, but given bandwidth & review cycles I think I'm happy with the blog post as-is. I appreciate your help with this!


Seed Coat anatomical part request

Seed anatomy and morphology trait.  Title: "Seed coat" Def:"The outer cellular layer(s) of a seed that enclose the embryo." Comment="The number of cellular layers vary among taxa."  Synonym="testa"
Note: you have Seed coat color and Seed coat color:Seed coat spots but no parent term of Seed coat.
Reported by: maxglycine
Original Ticket: obo/plant-trait-ontology-to-requests/75

There is an existing term in the PO for seed coat (PO:0009088): A portion of plant tissue that is the covering of a seed derived from ovular - mainly integumentary - tissue.
seed coat length (TO:0000880), seed coat hardness (TO:0000889), and seed coat luster (TO:0000888) all exist under the parent- seed coat anatomy and morphology trait (TO:0000838).


fix(inpainting model): blank areas to be repainted in the masked image

Otherwise the model seems too reluctant to change these areas, even though the mask channel should allow it to.
This makes the solid infill method proposed by #2441 less necessary, though I think there's still a place for an infill method that is faster than patchmatch and more predictable than tiles.
Even with #2441, this PR is still useful because it influences all areas to be painted, not just the infill area.
Fixes #2417

Note I've only tested it with the runwayml inpainting model for SD 1.x. We should check out how things behave in the Stable Diffusion 2.0 inpainting model as well.

Looks like this can make for some very pronounced seams for irregularly shaped masks. I suspect it's from places where the edge doesn't line up with the 8-pixel latent cell.
I think I need to look for reference material on this again. How were the masks and masked images prepared for training in the first place?

This code from runwayml does zero out those parts of masked_image before VAE encoding: https://github.com/runwayml/stable-diffusion/blob/main/scripts/inpaint_st.py#L86
The only preparation it does to the mask is thresholding before resizing. Resizing is then standard interpolation.

ah-hah, mask was blurry when submitted from canvas with scaled bounding box.

I've now also tried it with repo_id: stabilityai/stable-diffusion-2-inpainting. Seems to work okay, technically speaking.
(That model received neither the 768px training nor the updates that 2.1 got, so it's maybe not the best model we've seen.)


pythonPackages.pyglet: 1.1.2 -> 1.2.4

The download URL now points to PyPI instead of Google Code.

Looks good. Thanks!


Memory leak when using MatrixSolve with direct matrix input

We seen a constant increasing memory usage when used MatrixSolve from our code. The below example show how we used the library which  cause an extra Matrix allocated and never freed (Ea in the evaluate method as that got a copy of A which never freed).
int n = 400;
matrix ax = new matrix(n, n);
matrix b = new matrix(n, 1);
for (int i = 0; i < 10000; i++)
{
      MatrixSolve solve = new MatrixSolve(ax, b);
      matrix result = solve.Evaluate();
      result.Dispose();
}
ax.Dispose();
b.Dispose();

After this point we have 10000 extra 400*400 double array in the pool which never returned.
Is there a better way to use this method with direct matrix input?

I can see the bug. Bug fix release coming in the next couple of days.

This has been release in MKL.NET.Matrix 1.1.1. Let me know if there is still an issue.


[DOC] Correct typo in contributing guidelines

Small typo correction.

I think I need a second approval :)

Now merged @juanitorduz - thanks again :)


Feature request: target stage in docker_build_with_restart

Hi,
For multistage builds it would be helpful if docker_build_with_restart could target a specific stage similar to the normal docker_build https://docs.tilt.dev/api.html#api.docker_build

Hi @lhotrifork ! I think it already supports this?
https://github.com/tilt-dev/tilt-extensions/tree/master/restart_process#api
Note the part: **kwargs: will be passed to the underlying custom_build call
were you having trouble using it?

Maybe I miss-read it but doesn't KWARGS_BLACKLIST block it?
https://github.com/tilt-dev/tilt-extensions/blob/master/restart_process/Tiltfile#L4

i think that just applies to the 2nd Dockerfile we use to inject 'entr', not the Dockerfile you're passing in. I can double-check in a bit though.

Hi @nicks ,
I just checked it myself. It does work! <3

wooo! :tada:


sqlite ForeignKeysInfo pub access struct fields

Description
I want to generate a relationship graph from an sqlite database using the following code
use std::collections::HashMap;
use sea_schema::sqlite::Schema;

let schema: Schema = ...;

let tables_relations_hash_map: HashMap<String, Vec<String>> = schema
    .tables
    .iter()
    .fold(HashMap::new(), |mut acc, table| {
        if !acc.contains_key(&table.name) {
            acc.insert(table.name, Vec::new()).unwrap();
        }
        for fk in table.foreign_keys.iter() {
            if !acc.contains_key(&fk.table) {
                acc.insert(fk.table, Vec::new()).unwrap();
            }
            acc.get_mut(&fk.table).insert(table.name);
        }
        acc
    });

but fields in sqlite ForeignKeysInfo are pub (crate) and I cannot access them.
Does this serve a purpose ? Can I make an MR that fixes the issue ?
Steps to Reproduce
Run code snippet using a generated schema
Expected Behavior
Be able to access ForeignKeysInfo struct fields
Actual Behavior
ForeignKeysInfo struct fields are pub (crate) access
Versions
version = "0.7.1"

Hey @karatakis, feel free to make SQLite struct fields public by submitting a PR :)
Thanks!!

@tyt2y3 nice insight, I will add getter methods

To be more forward compatible, I'd prefer adding getter methods

I think to be consistent we should

Add getter to MySQL's and PostgreSQL's structs
Make SQLite struct fields public

Btw... why don't we parse the SeaQuery create table statement that was constructed by SeaSchema writer? Just like what we did at https://github.com/SeaQL/sea-orm/blob/master/sea-orm-codegen/src/entity/transformer.rs

@billy1624 I will go with the create table statement to solve my problem thanks.
I believe adding getters on all foreign key constrain structs is the way to go in order to be consistent. Should I continue on creating a merge request ?

I guess this is no longer needed?

Yeah. It was reasonable for the demo but not anymore


Tables faultily rendered at "Move and draw commands syntax"

The tables in the "Elliptical arc command" explanation chapter are rendered faulty:

The description of the a draw command option is missing white-space.
The Term table isn't rendered as a table.
The subsequent "Close command" header isn't rendered as a heading.

While all of this is rendered correctly on GitHub, the Microsoft Docs parser seems to have difficulty recognizing the table.
I believe issues 2-3 exist because the final pipe character in the table isn't preceded by a white-space character.
For issue 1, the author simply forgot to type the white-spaces.
I suggest to apply the following changes to the corresponding Markdown file:

| Syntax |
|--------|
| `A` *size* *rotationAngle* *isLargeArcFlag* *sweepDirectionFlag* *endPoint*
 - or -

  `a` *size* *rotationAngle* *isLargeArcFlag* *sweepDirectionFlag* *endPoint* |

| Term | Description |
|------|-------------|
| *size* | [**Size**](/uwp/api/Windows.Foundation.Size)
The x-radius and y-radius of the arc. |
| *rotationAngle* | [**Double**](/dotnet/api/system.double)
 The rotation of the ellipse, in degrees. |
| *isLargeArcFlag* | Set to 1 if the angle of the arc should be 180 degrees or greater; otherwise, set to 0. |
| *sweepDirectionFlag* | Set to 1 if the arc is drawn in a positive-angle direction; otherwise, set to 0. |
| *endPoint* | [**Point**](/uwp/api/Windows.Foundation.Point)
 The point to which the arc is drawn. |

**Close command**

PS: I've seen this issue in other UPW doc pages before. Perhaps it makes sense to have a Find In Files search performed on the resulting build artefacts using this search term: "|--"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 176ffc17-d205-bfd5-e2fe-4bf483bf293b
Version Independent ID: 0679a6f6-aa43-2217-3aa4-e95375b78d8f
Content: Move and draw commands syntax - UWP applications
Content Source: windows-apps-src/xaml-platform/move-draw-commands-syntax.md
Product: uwp
Technology: platform
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

Thanks for letting us know about this. The doc is fixed now.


[Doc] Add signoff for commit and update delete

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[x] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[x] 2.5
[x] 2.4
[x] 2.3

@mergfift backport branch-3.0 branch-2.5 branch-2.4 branch-2.3

@mergify backport branch-3.0 branch-2.5 branch-2.4 branch-2.3


in/out "E" Edges  arent identified on SQL Result

Using OrientDB Community 2.0.12
1. Create Two V Vertexes
CREATE VERTEX V SET id = 1
CREATE VERTEX V SET id = 2

2. Join them with an edge E
CREATE EDGE FROM (SELECT FROM V WHERE id = 1) TO (SELECT FROM V WHERE id = 2)

3. Select them
SELECT FROM V

Result:
{
  "result": [{
    "@type": "d",
    "@rid": "#9:0",
    "@version": 2,
    "@class": "V",
    "id": "1",
    "out_": [
      "#10:0"
    ],
    "@fieldTypes": "out_=g"
  },
  {
    "@type": "d",
    "@rid": "#9:1",
    "@version": 2,
    "@class": "V",
    "id": "2",
    "in_": [
      "#10:0"
    ],
    "@fieldTypes": "in_=g"
  }],
  "notification": "Query executed in 0.048 sec. Returned 2 record(s)"
}

Notice that in/out keys are not identified as in_E/out_E. This only happens when the edge E class, when derived classes are used, the in/out keys are correctly showed.

E is a special case that means also "no edge class", because it's the default one.


Support pub impl syntax

This replaces the impl-level visibility syntax introduced in https://github.com/taiki-e/easy-ext/pull/25 (v0.2.6). It is more natural syntax and compatible with rustfmt.
#[ext(Ext)]
pub impl Type {
    fn method(&self) {}
}

pub impl Type {
^^^

The old impl-level visibility syntax (#[ext(pub)]) will still be supported, but it is deprecated and will be removed in the next major version.
Migration:
- #[ext(pub)]
- impl Type {
+ #[ext]
+ pub impl Type {
    fn method(&self) {}
}

FYI @Boscop

bors r+

But the way to specify pub before each method will continue to work, right?

Yeah. There are currently no plans to deprecate or remove associated-item-level visibility (pub before fn/type/const).

Released in v0.2.8.


Belongs to through many to many pivote

Is it possible to get to relation that is through a many to many relation ?

Provide an example.

for example:
a Teacher teaches many Subjects (belongsToMany)
a Subject belongsTo SchoolLevel
I want to get the SchoolLevels for a given Teacher through the Subject relationship which is a ManyToMany relation.

select school_levels.* from school_levels left join teachers on teachers.id = subjects.teacher_id left join subjects on subjects.id = school_levels.subject_id where teachers.id = ?

The relation translates to this query. If your tables have required fields then you can.


Contributed my part of the story

Looks pretty good! I am not sure if it matters, but Arushi and I have the madlibs_list.txt entries as something like "large" instead of "adjective : Large".
Also, to get full points, make sure to review and comment on Nikiles's pull request. After y'all have done that for each other, you can merge your own commits.

Nishchith your merge request was approved!

I just noticed, placeholder [16] never got updated in the story, just the madlibs_list.txt

I just noticed, placeholder [16] never got updated in the story, just the madlibs_list.txt

Can you check now. It was just updated.

Hey Y'all, just to confirm, none of us have any pending approvals, right? I am going by the announcement Professor shared a while back.
I cannot see any approval pending for me, but if there is any, please let me know.

Nothing pending approval, but I think I fall into who he was talking about. I don't think I ever "reviewed" a pull request, and we can only review active pull requests. I think you did though, so you are good.


Unable to access the below URL

Hi,
I am currently working on docker container migration. I followed the below tutorial blog
https://clusterhq.com/2015/03/25/migration-database-container-docker-swarm/
Upon giving 'vagrant up ' command after entering the power strip demo folder . I ran into the below errors. Please find below my error log
root@hamsini-virtual-machine:/home/hamsini/powerstrip-swarm-demo# vagrant up
Bringing machine 'node1' up with 'virtualbox' provider...
Bringing machine 'node2' up with 'virtualbox' provider...
Bringing machine 'master' up with 'virtualbox' provider...
==> node1: Box 'powerstrip-swarm-demo-v3' could not be found. Attempting to find and install...
node1: Box Provider: virtualbox
node1: Box Version: >= 0
==> node1: Box file was not detected as metadata. Adding it directly...
==> node1: Adding box 'powerstrip-swarm-demo-v3' (v0) for provider: virtualbox
node1: Downloading: http://storage.googleapis.com/experiments-clusterhq/orchestration-demos/powerstrip-swarm-demo-v3.box
An error occurred while downloading the remote file. The error
message, if any, is reproduced below. Please fix this error and try
again.
The requested URL returned error: 403 Forbidden
I tried logging into the below site to double check , if there was any fault in the URL  and I ran into the below errors
AccountProblemYour Google account is not currently enabled for this operation. Please check https://console.developers.google.com/billing to see if you have a past due balance or if the credit card (or other payment mechanism) on your account is expired. You can find additional information at https://developers.google.com/storage/docs/signupThe billing account for the requested project is disabled in state 'closed'
Puzzled by the errors, I received , I checked my google account and I had no balance to be settled in my account. I , enabled the google API option then raised a ticket in google support .This was the reply that I got from google support.
This API doesn't belong to google and that I need to contact the developer for permission
Could anyone please clarify as this is hampering my testing
Thanks in Advance


✏ Fix typo in projects.md

Summary
✏ Fix typo in projects.md

Test Plan

Thanks! I can fix the lint.


[core] regen tracing samples

Regenerates samples to fix any formatting issues as well as remove the type: module specifier as we are not generating ESM for our samples.
Resolves #29521

API change check
API changes are not detected in this pull request.


Update all dependencies

bors r+

bors r+

bors retry

bors r+

bors retry

bors retry

bors retry

bors retry


Extension UserFunctions 1.35 results Error 500

Tried everything. Fresh install, git clone, copy and paste, etc. but enabling UserFunctions 1.35 results in an error 500. There without the system runs fine.
The old UserFunctions 1.27 & require_once "$IP/extensions/UserFunctions/UserFunctions.php"; does work however.

What about the UserFunctions version included in Canasta (1.35), but with the require_once call? It looks like the issue might be that wfLoadExtension() support was not added to UserFunctions until after 1.35.

Okay, I just upgraded the version of UserFunctions being used - I believe this fixes the error. Feel free to re-open if not.


Bundle workflows in advance to improve sync-worker startup time

https://docs.temporal.io/application-development/foundations?lang=typescript#register-types

Migrated to internal project management tool.


gowin_pack.py: convert bits vector to int before sum

My python can't sum string bit vector.

Huh, I don't remember the type of this attribute, but if it's not an int or boolean, we have to be careful that the lines below that test for their truth value actually work correctly.
Looking at #9 I have a suspicion that maybe your fix resulted in no IOB being generated at all. Could you verify if attr["INPUT_USED"]: does the correct thing? I'll have a closer look at this PR over the weekend.

Yes it was wrong type for attr["INPUT_USED"] !
Trabucayre fixed it in his PR

Thank you! Looking forward to see any future cool projects and contributions!


Change Title style

Hi there,
I need change Tittle and Subtitle style to " Horizontal Align Left". How can I do this?
Tks

Hi Marco
When using the iTextSharp PDF writer you can do it like this:
report.RenderHints["TitleStyle"] = new ReportStyle {   Bold = true,   FontSize = 18,   HorizontalAlignment = HorizontalAlignment.Left };
report.RenderHints["SubTitleStyle"] = new ReportStyle {   Bold = true,   FontSize = 14,   HorizontalAlignment = HorizontalAlignment.Left };
This is implemented per report writer so the others might behave differently.
Hope this helps
Cheers
Cobus

Tks cob, but I´m makeing a report in Windows App, only client.
I´ll try your susggest and, if OK, will  post.


Cmake build system

Hi.
This pull will replace autotools-based build system with one using CMake, without any loss of functionality.
I've made a lot of renaming to make it look more structured (imho).
Python-related sources were tweaked to work on both python 2 and python 3.
Hope you'll find it useful.

After discussing with the other core developers we've decided to stick with the Autotools.  At one point we did use CMake, but I switched to the Autotools when I found myself spending too much time debugging incompatibilities between Debian, Ubuntu, and multiple versions of Fedora.  That being said, I understand the appeal of CMake, and will consider this pull request to be the start of a patchset maintaining a second build system for HyperDex.
I'm very interested in improving the Python portability.   I'll cherry pick the appropriate patches.  If they don't apply cleanly, would you be able to resubmit?  I ask because I want to maintain original authorship in the commit history.

Sure, I'll resubmit if anything goes wrong.


Add VBA functionality

Following the suggestions raised in #36 by @slumnitz.

How would this work exactly? Just opening the discussion.
My main concern is in making intuitive the classification of the vba variable given the classification of the main variable is obvious since this will be a method of a given classifier. For example given a continuous variable y:
classi = Quantiles (y)
classi.plot(geoms)

This would be a standard choropleth. Now, if I have another variable (e.g. confidence) that I want to use to modulate alpha values. How should this be passed in? More importantly, how should we allow the user to determine the classiffication scheme for that? A couple of ideas (totally brainstorming so might not make sense):

We use the style of choropleth_vba and allow the user to pass any classifier. This is consistent but a bit awkward in a way since they would pick the classifier for y in one way and for confidence in another)
We don't allow the user to pass classifiers for vba and use the same classifier and same parameters for confidence as used for y. This is consistent within the method and simpler to set up but arguably a bit too restrictive.
Something in the middle?

Another possibility:
class_a = Quantiles(a)
class_b = Quantiles(b)
vba.plot(class_a, class_b)

where vba is an instance of a new class.
I think loading up the plot method in the univariate classifiers is going to complicated things.

I really like that approach. I'd maybe call it choropleth instead of vba?

splot.vba_chorpleth actually does exactly this under the hood. For maintaining purposes we might want to consider to leverage functionality for both and just store it at one place.

Can this be closed since the plotting is in splot?

I think so. We can reopen if needed.


Add f(x)Core chain and FX token

What is the purpose of the change
To add the f(x)Core chain and FX token.
Brief Changelog
add fx.svg (token logo),
add f(x)Core chain and FX token to source-chain-config.ts
add FX token to ibc-assets.ts
Testing and Verifying
This change has been tested locally by rebuilding the website and verified content and links are expected
Pending

Pool ID for price definition
Validation

changed to direct channel between fxcore and osmosis

Replaced by https://github.com/osmosis-labs/osmosis-frontend/pull/2113


TechDebt - Unpin TF

Originally raised in https://github.com/hashicorp/terraform-provider-aws/issues/27049
Upgrading to the latest main-branch removes the need to pin Terraform to an older version.
The latest branch tests some functionality that's still not covered by Moto, so we had to remove some of the tests that previously passed.

Codecov Report

Merging #5590 (906a597) into master (14c6550) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5590   +/-   ##
=======================================
  Coverage   96.18%   96.18%
=======================================
  Files         742      742
  Lines       72612    72643   +31
=======================================
+ Hits        69839    69872   +33
+ Misses       2773     2771    -2

Flag
Coverage Δ

servertests
36.90% <15.00%> (-0.01%)
:arrow_down:

unittests
96.12% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/amp/urls.py
100.00% <ø> (ø)

moto/amp/models.py
100.00% <100.00%> (ø)

moto/amp/responses.py
93.63% <100.00%> (+1.24%)
:arrow_up:

moto/ec2/models/vpcs.py
96.45% <100.00%> (+<0.01%)
:arrow_up:

moto/s3/utils.py
97.19% <0.00%> (-1.87%)
:arrow_down:

moto/s3/models.py
96.86% <0.00%> (-0.01%)
:arrow_down:

moto/ses/models.py
96.95% <0.00%> (ø)

moto/appsync/models.py
97.36% <0.00%> (ø)

moto/awslambda/utils.py
100.00% <0.00%> (ø)

moto/awslambda/responses.py
93.88% <0.00%> (ø)

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

FYI @thrau


Incorrect error message for max length of resource group

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug

The az group create command returns a ValidateError inconsistent with behavior.
Attempting to create a resource group with a 91 character name complains: "ValidationError: Parameter 'resource_group_name' must have length less than 90."
However, creating a 90 char name works (and 90 is not "less than 90"). So the message should read something like: "ValidationError: Parameter 'resource_group_name' must have length no more than 90."
To Reproduce

90 char length SUCCEEDS
az group create -l eastus -n "123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890" # 90 chars
91 char length FAILS
az group create -l eastus -n "123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890x" # 91 chars
RETURNS ERROR: "ValidationError: Parameter 'resource_group_name' must have length less than 90."
Expected behavior

az group create -l eastus -n "123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890x" # 91 chars
Should RETURN ERROR: "ValidationError: Parameter 'resource_group_name' must have length no more than 90."
Environment summary

Azure Shell
Additional context

Azure CLI version 2.14.0
https://github.com/azure/azure-cli/issues/new?body=

%23%23%23+**This+is+autogenerated.+Please+review+and+update+as+needed.**

%23%23+Describe+the+bug

**Command+Name**
`az+group+create`

**Errors%3A**
```
ValidationError%3A+Parameter+'resource_group_name'+must+have+length+less+than+90.
```

%23%23+To+Reproduce%3A
Steps+to+reproduce+the+behavior.+Note+that+argument+values+have+been+redacted%2C+as+they+may+contain+sensitive+information.

-+_Put+any+pre-requisite+steps+here..._%0A-+%60az+group+create+-l+%7B%7D+-n+%7B%7D%60%0A%0A%23%23+Expected+Behavior%0A%0A%23%23+Environment+Summary%0A%60%60%60%0ALinux-4.15.0-1098-azure-x86_64-with-debian-stretch-sid+%28Cloud+Shell%29%0APython+3.6.10%0AInstaller%3A+DEB%0A%0Aazure-cli+2.14.0%0A%0AExtensions%3A%0Aai-examples+0.2.4%0A%0A%60%60%60%0A%23%23+Additional+Context%0A%0A%3C%21--Please+don%27t+remove+this%3A--%3E%0A%3C%21--auto-generated--%3E%0A%0A&template=Bug_report.md

cc @houk-ms for awareness

add to S178

This is a issue related to msrest, I have opend a issue on their repo: Azure/msrest-for-python#219

This is a issue related to msrest, I have opend a issue on their repo: Azure/msrest-for-python#219

@codingoutloud Error message updated
az group create -l eastus -n "123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890x"
(InvalidResourceGroup) The provided resource group name '123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890x' has a length of '91' which exceeds the maximum length of '90'.
Code: InvalidResourceGroup
Message: The provided resource group name '123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890x' has a length of '91' which exceeds the maximum length of '90'.


Implement the correct browser behavior for hash changes.

Fixes https://github.com/zeit/next.js/issues/2098
Now next/link should work exactly like browser's <a/> when handling hashes.

Thanks for that!


add Decoder interface to allow plugability of decoding properties to arb...

...itrary values.

archaius-pull-requests #139 FAILURE
Looks like there's a problem with this pull request

build failed because the gradle-wrapper.jar is not checked in.

Thanks for the PR!  Glad to see others getting involved.  Do you see this being extended to include parsing of all types, getLong, getInt, etc..  I'm currently doing that in AbstractConfig but feel it should be implemented elsewhere.

@elandau Yeah, wouldn't be hard to move to the long, int parsing to the decoder.  Spring has robust conversion framework that would get plugged in spring-cloud-netflix.


chore: add workflow to publish the website to gh-pages branch

depends on

[x] https://github.com/containers/podman-desktop-catalog/pull/98

it'll take the build/ output and put it to gh-pages branch
I took the file from podman-desktop (changing build folder)
related to https://github.com/containers/podman-desktop/issues/8972
Change-Id: I64585f718033ed5882916f9898768115825cd441

rebased


Typescript types

i'm using this package with nestjs on back-end side:
import youtubeDl, { Payload } from 'youtube-dl-exec';

the return of "youtubeDl" function is typed as Payload but the result is instead a string url

I'm not following – this is the expected result:
https://github.com/microlinkhq/youtube-dl-exec/blob/master/src/index.d.ts#L4
In which scenario the output is a string url?

as you can see in screenshot if you pass options {format: 'best', getUrl: true} the result is a string

Ops got it; can you make a PR updating the types? 🙏
https://github.com/microlinkhq/youtube-dl-exec/blob/master/src/index.d.ts

sure


crash on start

crashes with the error
connect(2) call to /dev/shm/jack-1000/default/jack_0 failed (err=No such file or directory)
attempt to connect to server failed
Error: main.lua:1: module 'lib.ammo' not found:
        no field package.preload['lib.ammo']
        no 'lib/ammo' in LOVE game directories.
        no file 'lib/ammo.so' in LOVE paths.
        no file './lib/ammo.lua'
        no file '/usr/share/luajit-2.0.4/lib/ammo.lua'
        no file '/usr/local/share/lua/5.1/lib/ammo.lua'
        no file '/usr/local/share/lua/5.1/lib/ammo/init.lua'
        no file '/usr/share/lua/5.1/lib/ammo.lua'
        no file '/usr/share/lua/5.1/lib/ammo/init.lua'
        no file './lib/ammo.so'
        no file '/usr/local/lib/lua/5.1/lib/ammo.so'
        no file '/usr/lib/lua/5.1/lib/ammo.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
        no file './lib.so'
        no file '/usr/local/lib/lua/5.1/lib.so'
        no file '/usr/lib/lua/5.1/lib.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
        [C]: in function 'require'
        main.lua:1: in main chunk
        [C]: in function 'require'
        [string "boot.lua"]:428: in function <[string "boot.lua"]:274>
        [C]: in function 'xpcall'

running on arch linux

Need to download the submodule. git submodule update --init.

ok now i get
connect(2) call to /dev/shm/jack-1000/default/jack_0 failed (err=No such file or directory)
attempt to connect to server failed
Error: lib/ammo/extensions.lua:67: attempt to call field 'getDimensions' (a nil value)
stack traceback:
        lib/ammo/extensions.lua:67: in function 'setWindowConstants'
        lib/ammo/extensions.lua:84: in main chunk
        [C]: in function 'require'
        lib/ammo/ammo.lua:7: in main chunk
        [C]: in function 'require'
        lib/ammo/init.lua:9: in main chunk
        [C]: in function 'require'
        main.lua:1: in main chunk
        [C]: in function 'require'
        [string "boot.lua"]:428: in function <[string "boot.lua"]:274>
        [C]: in function 'xpcall'

I believe that means your system's LÖVE binary is out of date. It needs 0.9.2 or higher.

i have LOVE 0.10.1 (Super Toast)
On Sat, Mar 19, 2016 at 7:23 PM, Michael Ebens<EMAIL_ADDRESS>wrote:

I believe that means your system's LÖVE binary is out of date. It needs
0.9.2 or higher.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/BlackBulletIV/super-space-invader/issues/5#issuecomment-198805859

Ah, I forgot about the update to getDimensions. This may mean SSI can't run on 0.10.x, but it could just be Ammo.
Go into the lib/ammo folder and update the library with git pull origin master. Hopefully that'll work.

looks like tween is not working now
connect(2) call to /dev/shm/jack-1000/default/jack_0 failed (err=No such file or directory)
attempt to connect to server failed
Error: lib/tweens/Tween.lua:37: attempt to call method 'enableAccessors' (a nil value)
stack traceback:
        lib/tweens/Tween.lua:37: in main chunk
        [C]: in function 'require'
        lib/tweens/init.lua:2: in main chunk
        [C]: in function 'require'
        main.lua:4: in main chunk
        [C]: in function 'require'
        [string "boot.lua"]:428: in function <[string "boot.lua"]:274>
        [C]: in function 'xpcall'

The fix for that is to edit main.lua and put "ammo." after the "lib." for lib.tweens (and maybe lib.assets and lib.input). Hope the game is worth the trouble if you do get it working. :P
I really should update this for 0.10.x sometime.

what can i say? I'm a sucker for bullet hell / space shooters
On Sat, Mar 19, 2016 at 9:47 PM, Michael Ebens<EMAIL_ADDRESS>wrote:

The fix for that is to edit main.lua and put "ammo." after the "lib." for
lib.tweens (and maybe lib.assets and lib.input). Hope the game is worth the
trouble if you do get it working. :P
I really should update this for 0.10.x sometime.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/BlackBulletIV/super-space-invader/issues/5#issuecomment-198825476


[5.4] Implements Model Instance "Unique" Validation

As discussed here: https://github.com/laravel/internals/issues/591#issuecomment-303684085 and followed up here: https://github.com/laravel/internals/issues/604
I'm unsure about class implementation at the moment as it could end up being a bit messy (checking for class existence and that it is indeed an extension of model), I'm also unsure if I should delegate this logic in the __construct method or not. I've done so in this PR.

For localised context here, this allows for:
Rule::unique($model);
Rule::unique($model, 'column');

etc etc – auto filling out the table, idColumn and ignore properties.

Off the back of our discussions, I think you'd want to be able to do a class OR an instance if this were to be added.
'email' => Rule::unique(User::class, 'email')

and I'm not real sure you would automatically want to ignore the instance...but then maybe you would?
'email' => Rule::unique(User::class, 'email')->ignore($user)

would probably be better...?
I also apply this to the unique rule which can make a good foreign key check...
'user_id' => Rule::exists(User::class)

@timacdonald I was just talking in Larachat, mentioning the exact same thing about exists – I feel like a few validation rules could definitely benefit from Eloquent integration for a few reasons.
It would be great for specific use-cases like:
Rule::exists('site_entries', 'id')->using(function ($query) use ($proposal) {
    $query->leftJoin('sites', function ($join) use ($proposal) {
        $join->where('sites.id', '=', 'site_entries.site_id')
            ->where('sites.proposal_id', '=', $proposal);
    });
});```

Which could easily be avoided with support for eloquent relations.

@timacdonald I decided to add support for Model::class and only add ignore if-and-when the primary key on the model instance (if provided) is not null. The check doesn't really need to be there though, to be honest, if it is null nothing would change anyway.

Re-reading my last comment made me decide not to have that daft bit of checking for absolutely no reason.
Rule::unique(User::class, 'email')->ignore($user) although this is valid (with my PR) – I'm unsure if it would actually ever be used... Thoughts?

No plans to add this to the core right now.

@taylorotwell I understand – any particular input on a good way to achieve this interoperability between validation and Eloquent?


Question about heroku postgres credential rotation

In the db setting of heroku, it states that
Please note that these credentials are not permanent.

Heroku rotates credentials periodically and updates applications where this database is attached.

I check the env vars, I think it is HEROKU_POSTGRESQL_NAVY_URL. So in order for umami to work, I have:

create DATABASE_URL var copying the HEROKU_POSTGRESQL_NAVY_URL
modify the value as it starts with postgres:// instead of postgresql://

Does that mean in case the credential rotates, I need to copy that again?

Not that familiar with heroku, but if the database credentials change, then yes you have to copy the new values to the DATABASE_URL and restart the app. However, the app can recognize either postgres or postgresql.

I found that it should be my mistake in the setting so when it install DB, it uses another env var rather than DATABASE_URL.


Next extends controller

It would be very cool if the next object were passed to the controller.
An example is worth a thousand words:
Instead of...
const Next = use('Adonis/Addons/Next');

Route.get('/b', ({ request, response }) => {
  const query = request.get();
  return Next.render(request.request, response.response, '/b', query);
});

This
Route.get('/b', ({ request, response, next }) => {
  const query = request.get();
  return next.render(request.request, response.response, '/b', query);
});

I will try to do it by my self and send you a pull request, but I have never done this before.

Hi @TheJltres
Thanks for your feedback. I just want to understand what is the purpose of using it this way ?
I mean usually you declare all routes in one file so defining next  in the old way it's not that bad.

Default view render with Adonis is sent to every method of the controller (https://adonisjs.com/docs/4.1/views)
Route.get('hello-world', ({ view }) => {
  return view.render('hello-world')
})

I don't know why they do it like this, I only thought to make the "default" way.
I'm will try to send data to view like Adonis views does (https://adonisjs.com/docs/4.1/views#_loggedin), but I don't promise anything 😛

@TheJltres
Thanks I will merge your PR.
Sending data to next is not going to work, because sometimes it's just client side rendered so no data will be from the server.
also Next team in some issues encourage people to make next independent and make the data comes through data fetching only.

I will keep it in mind.
I will try, if it works I will create a issue and a PR, if not no problem.
Thanks for the advice!

@TheJltres
So your PR did not works as expected
in Next routers sometime  you have to make a catch router * this router is using Next.getRequestHandler()

Route.get("*", ({ request, response, next }) => {
   const handler = next.getRequestHandler();
  return new Promise((resolve, reject) => {
    handler(request.request, response.response, (promise) => {
      promise.then(resolve).catch(reject);
    });
  });
});

in your case  we call this function every time we call this function, this would be consider a bad behaviour since we can defined it one  and use it many time as it state in Next examples.
const Next = use("Adonis/Addons/Next");
const handler = Next.getRequestHandler();

Route.get("*", ({ request, response, next }) => {

  return new Promise((resolve, reject) => {
    handler(request.request, response.response, (promise) => {
      promise.then(resolve).catch(reject);
    });
  });
});

I saw it but I thought it always does...
Is this for creating multiple times the object?
Any way this is Next problem, i will try to do some research and figure out how.
If I am using multiple Adonis Controllers, I need one Next object on each of them, does that do the same?

@TheJltres  usually next should be available in Adonis Controller, the main reason for this plugin was to make adonis and next to run on the same port, and use adonis as custom server for routing only.
Next is not being able to live inside or be used in Adonis Controller, it's not something like pug,jade or edge.

But if I use a Route resource (https://adonisjs.com/docs/4.1/routing#_route_resources) I will not be able to use multiple resources.
I know it is not something like edge, my idea was send Adonis functions or objects used in the controller to the view.
If I separate Adonis and Next I can ask Adonis for those objects.
The main problem here is that Next needs to handle an "error" every time you create a Next object.

@TheJltres  thats why i encourage you to use adonis as API only and Next as React app only and do not try to mix them.


Improve Ledger Replay Logic

This pull request implements smarter ledger replay logic, accurately preserving the actual execution order of transactions and the close time. This should permit a ledger to be perfectly reconstructed so long as the code understands the transaction execution rules in affect during the original close.
This is built on top of both the OpenView and missing node changes to avoid conflicts. It also contains a patch (the "[FOLD] change) to make those two changes compatible as they had an internal conflict.

Can we hold off perhaps on this until after those two changes are put in?  They're approved, I think we have a release build ready even...


Safari issues with non-0 CTS

When playing content where the CTS of the first frame of the first fragment is not 0, on Safari 9, the player gets "stuck".
It can be unstuck by fiddling with the seek bar (not a 100% guarantee, but by moving the seek bar a few times, the playback usually ends up working). Sometimes a seek back to 0 will show the little PacMan icon and stay there.
The same content works find in Chrome and Firefox.
It is definitely strange to have content for which the first frame CTS isn't 0, but I can't find a specific part of the spec that definitely forbids it.
So the question is: should this be supported by Shaka? Is this a bug in Safari? or is the content just non-compliant?
I've posted an example of such content here:
http://www.bok.net/tmp/dash/cts_offset/stream.mpd

I'm not sure if this is valid content or not, but it's common enough that I feel we should find a simple solution.
The behavior for this kind of thing varies between browsers.  In Chrome, for example, gaps of less than 250ms do not seem to stall the media pipeline.  I'm not aware of any standard requirements around this, though.
If you are willing to continue hosting that stream for a while, we will take a look in the next few weeks and see if there's a simple way to deal with it across browsers.

Thanks. I'll leave the stream on the server for a while.

Different browsers seem to treat the first video segment differently.  The test is to append the init segment and the first video segment to a SourceBuffer and then check SourceBuffer.buffered.start(0).  Here are the results:

Safari 8 & 9
Firefox 44 on Linux
Chrome 48 on Linux
IE11 & Edge13 on Win 10

83ms (CTS)
83ms (CTS)
0ms (DTS)
0ms (DTS)

I'm not sure which is implementations are correct in this, but it causes Shaka to behave differently since we use buffered.start(0) to calculate drift.  Ideally we could be resilient in all cases, but right now I think I need to do some digging into which (if any) is to-spec with MSE.

It looks like the problem for Safari is rounding from a floating point value (0.083333) to a rational time value (2/24). Represented as a double, the seek time ends up as 0.083333333333333329, which is ever so slightly less than 2/24 (or, 0.08333333333333333).
So Safari thinks that the media has seeked into an unbuffered range, and fails to re-enqueue upcoming samples correctly.

The latest Shaka v2 code in master does not error on this content.  The buffered range on Safari 9 starts at 83ms, but Safari refuses to jump the gap from 0.  Using Firefox on the same Mac, I also see that the buffered range starts at 83ms, but Firefox will automatically jump the gap from 0.
So I'm tempted to say that Shaka is doing everything it can now, and that the rest is a Safari issue.
Does anyone here know the right procedure to file bugs against Safari?  Googling "safari bug report" doesn't turn up an obviously correct result.  The closest seems to be "Apple - Safari - Feedback", but that is not so much a public bug report as a comments form.  "please note that we cannot respond to the comments you submit."
"Apple Bug Reporter" seems more appropriate, but if you search for "Safari" in the bug tracker, you get zero results.  Is that the wrong place?  Or are all the bug reports private?

@joeyparrish Actually, it's either a bug in Safari, Chrome, & Firefox, or it's a bug in Edge, depending on the outcome of https://github.com/w3c/media-source/issues/54.
Edge is using the decode timestamp to fill their .buffered ranges, and the other browsers are using the presentation timestamp.
You can file a bug against Safari at http://bugreport.apple.com, or against WebKit at http://bugs.webkit.org/. But I would argue that in light of the likely result of the media-source issue above, Safari and WebKit are unlikely to change their behavior here.

Yes, what I meant was that regardless of the outcome of w3c/media-source#54, Safari doesn't jump a tiny 83ms gap at the start like other browsers seem to do.
Firefox is using CTS and Chrome is using DTS, but both are willing to skip tiny gaps in the buffer during playback.  (Chrome doesn't do this for the content in question here, but I have seen it skip small gaps in other content.)
@barbibulle, I've mirror your content here for my bug report: https://storage.googleapis.com/shaka-demo-assets/_bugs/safari-non-zero-cts/stream.mpd
@jernoble, I've filed a bug against WebKit here: https://bugs.webkit.org/show_bug.cgi?id=156316
Thanks, everyone!

yesir let me think before i drank.

@KbdBrucd777 :beers:

hold  im nee at this  very new

this is how it went with my new computer day before yesterdat and the worthless punk im about to go find now got into my computer and all i have been trying to do is emaik a guy back for a job.  im 42, have a 1 month old baby and a pissed off wife cuz this pervert wants to watch me all day  2015-08-05.....

@KbdBrucd777, your comments are unrelated to this project.  I'm not sure why you are leaving them here.
I have locked this issue to prevent further comments and I am deleting the inappropriate comments you have left (strong language, violent threats, and the medical saga of a newborn).


Helm Chart: Remove encryption key volume

fixes #4351

Codecov Report

Merging #4355 into master will increase coverage by 2.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4355      +/-   ##
==========================================
+ Coverage   56.23%   58.75%   +2.52%
==========================================
  Files         891      891
  Lines       29151    29161      +10
  Branches     4216     4219       +3
==========================================
+ Hits        16394    17135     +741
+ Misses      12757    12026     -731


Add date

Description
Added date in holder.jsx for uniformity
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ /] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[ ] My code follows the style guidelines of this project
[/] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Your contribution matters, so we will merge this feat after merging of issue #131 .
@Harshchourasiya do send PR to development  for above issue.
THen @lancaster215 will update the development branch and again send a PR to us with updated changes.
Closing this PR for now.
@lancaster215 check the PR

@lancaster215 you can

I reviewed and solved the merge conflicts. Branch will be merged to development.
Thanks @lancaster215 for contributing.
After merging to development
You can see the result at : https://devtechphantoms.netlify.app/projects


Fix 2756

TBD
Overview
Fixes #2756.
Testing recommendations

Related Issues or Pull Requests

Checklist

[ ] Code is written and works correctly
[ ] Changes are covered by tests
[ ] Any new configurable parameters are documented in rel/overlay/etc/default.ini
[ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

@florianb You may want to see #2786 which has all of @davisp 's work in it on this, which includes both your and my feedback.
It's quite a bit of work!

This is obsolete due to #2786

Thanks @wohali - #2786 solves the issue. If i might lend a helping hand, let me know.


AsciiDoc migration, PR 1 of 3 (or 4)

all jbpm-docs docbook has been translated to asciidoc, to be found in jbpm-asciidocs
some docbook from the shared directory has been translated to asciidoc, to be found in shared-asciidoc

@psiroky, Would you mind merging?


[FEATURE] Add repository to "Pinned repositories"

This app is probably one of the most important to facilitate contribution to the TYPO3 ecosystem, so I would pin it prominently to the top of the profile page.

done


Wrong title on introduction page

It is not chapter 2

@ArianHamdi thank you for opening this issue! We have a PR fixing this 👍


Doesn't work on 1.19.3

I'm sure you're probably already working on an update, but in case you didn't know that 1.19.3 broke the mod, thought I'd let you know

Almost all mods broke on 1.19.3 :) but I am not sure when I will update my mods to this version

I have no plans to update my mods to 1.19.3 and 1.19.4.
Mainly out of time reasons.