monitoring data node_name not exists ,GPU power usage is not correct in Grafana Dashboard

Environment:

HAMi version: only know "imageTag=v1.23.10"
Kubernetes version: 1.23.10
Others: 2 amd architecture servers  on which Ubuntu20.04.3 LTS were installed, they are k8s nodes

Please provide an in-depth description of the question you have:
(1)I had installed HAMi successfully, and it works well when runing vGPU task.
from port 31993, I can get monitoring information as followed:

(2)I deployed dcgm-exporter  by runing “kubectl -n monitoring create -f https://raw.githubusercontent.com/NVIDIA/dcgm-exporter/master/dcgm-exporter.yaml”, and changed the type of svc/dcqm-exporter to NodePort from ClusterIP:

(3)I have deployed Prometheus 2.36.1 in binary mode and made the following configurations:

Targets page from Promethus proves prometheus has already collected monitoring data:

(4)I deployed Grafana v8.5.5 in k8s-1.23.10 cluster, A data source named ALL in Grafana was created:

(5)I imported a dashboard(https://github.com/Project-HAMi/HAMi/blob/master/docs/gpu-dashboard.json), but some of the data presented was inaccurate or was not existed.
for example, "nodename" in the upper left corner has no data, and the value of "GPU power usage" is not inaccurate(My GPU is a NVIDIA A10, whose GPU power usage is 150W)

What do you think about this question?:
(1)A friend name "凤" from Internet share me this dashboard "https://grafana.com/grafana/dashboards/21833-hami-vgpu-dashboard/", but the problems mentioned above still exist.
(2)I founded ${node_name} was used in the two dashboard mentioned above, but ${node_name} is NULL. I don't know what's going wrong, please help

After attempting to deploy this dashboard myself, I encountered similar issues. By comparing the original metrics, I noticed the following:

Missing node_name Label:
The issue with the missing node_name label appears to be related to the following configuration:
- source_labels: [__meta_kubernetes_pod_node_name]
  regex: (.*)
  target_label: node_name
  replacement: ${1}
  action: replace

I didn't include this part of the configuration because I used ServiceMonitor directly, which means the metrics don't have the node_name label in my setup. In my environment, the default label is Hostname. To resolve this, you can follow the Add Prometheus Custom Metric Configuration section in the dashboard documentation. Alternatively, after importing the dashboard, you can modify the Variables in the Settings to match your environment.

Panel Options Type Configuration:
The second issue is related to the panel's Options. The Type is set to Range, but it should be Instance. Setting it to Range aggregates all the data within the selected time frame, resulting in abnormally large values. Changing the Type to Instance should correct this and display the data as expected.

Hope this helps resolve the issues you're experiencing!

@jiangsanyin
Regarding the Add Prometheus Custom Metric Configuration section in the dashboard, I think there may be some problems with the configuration provided.
I am using ServiceMonitor directly, so there's no need to adjust the native Prometheus scrape configuration. If your Prometheus is created via the Operator, I highly recommend using ServiceMonitor as well. Additionally, I suggest installing dcgm-exporter using the Helm Chart. You can easily configure the node_name relabeling in the Helm values file at this location: values.yaml#L109.
Finally, if you're unable to use ServiceMonitor, you might consider asking GPT for guidance on how to configure the native Prometheus scrape configuration to scrape metrics from a specified IP:Port
and apply relabeling to obtain the node_name label : )

@jiangsanyin Regarding the Add Prometheus Custom Metric Configuration section in the dashboard, I think there may be some problems with the configuration provided.
I am using ServiceMonitor directly, so there's no need to adjust the native Prometheus scrape configuration. If your Prometheus is created via the Operator, I highly recommend using ServiceMonitor as well. Additionally, I suggest installing dcgm-exporter using the Helm Chart. You can easily configure the node_name relabeling in the Helm values file at this location: values.yaml#L109.
Finally, if you're unable to use ServiceMonitor, you might consider asking GPT for guidance on how to configure the native Prometheus scrape configuration to scrape metrics from a specified IP:Port and apply relabeling to obtain the node_name label : )

Thank you for your prompt reply! These problems within this issue happended to me in the course of work, I'll read your suggestion carefully next monday. ^_^

hami 31992 and 31993 metrics has no label related to node_name，so i added a label node_name for selecting gpu node  metrics. label node_name is replaced from __meta_kubernetes_pod_node_name.
As shown in the example, prometheus is configured using the kubernetes_sd_configs discovery mechanism (using Kubernetes "endpoints")

@Nimbus318
"I suggest installing dcgm-exporter using the Helm Chart. You can easily configure the node_name relabeling in the Helm values file at this location: values.yaml#L109."
this part helps me. Now ${Hostname} gives me the nodename of k8s cluster.
I imported the dashboard from page "https://grafana.com/grafana/dashboards/21833-hami-vgpu-dashboard/" and changed the nodename variable into Hostname, then most of charts have data.
However, there are problems in the four charts as following, because there is no entry reletaed to "Device_memory_desc_of_container" has been collected into my Prometheus, and other 3 charts don't have data because of the same reason.

@jiangsanyin

@jiangsanyin The reason you don't see Device_memory_desc_of_container in your Prometheus metrics is that this metric is exposed by the hami-device-plugin. However, Prometheus does not have a scrape rule configured to collect these metrics.
Based on your previous response, it looks like you can use the ServiceMonitor. You can try applying the following YAML configuration:
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: hami-device-plugin-svc-monitor
  namespace: kube-system
spec:
  selector:
    matchLabels:
      app.kubernetes.io/component: hami-device-plugin
  namespaceSelector:
    matchNames:
      - "kube-system"
  endpoints:
  - path: /metrics
    port: monitorport
    interval: "15s"
    honorLabels: false

Based on this requirement, I think we can add a configuration similar to the following in the Hami chart:
devicePlugin:
  serviceMonitor:
    enabled: true
    interval: 15s
    honorLabels: false
    additionalLabels:
    relabelings: []

This configuration will allow users to decide whether to enable the ServiceMonitor for the devicePlugin. I might discuss with the community whether this configuration is necessary.

@jiangsanyin The reason you don't see Device_memory_desc_of_container in your Prometheus metrics is that this metric is exposed by the hami-device-plugin. However, Prometheus does not have a scrape rule configured to collect these metrics.
Based on your previous response, it looks like you can use the ServiceMonitor. You can try applying the following YAML configuration:
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: hami-device-plugin-svc-monitor
  namespace: kube-system
spec:
  selector:
    matchLabels:
      app.kubernetes.io/component: hami-device-plugin
  namespaceSelector:
    matchNames:
      - "kube-system"
  endpoints:
  - path: /metrics
    port: monitorport
    interval: "15s"
    honorLabels: false

Based on this requirement, I think we can add a configuration similar to the following in the Hami chart:
devicePlugin:
  serviceMonitor:
    enabled: true
    interval: 15s
    honorLabels: false
    additionalLabels:
    relabelings: []

This configuration will allow users to decide whether to enable the ServiceMonitor for the devicePlugin. I might discuss with the community whether this configuration is necessary.

Thanks, your reply works for me. awsome!


Appstudio update test-component-pac-dpll

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-dpll-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
23 seconds
init

✅ Succeeded
25 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
19 seconds
deprecated-base-image-check

✅ Succeeded
20 seconds
sanity-inspect-image

✅ Succeeded
55 seconds
clamav-scan

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
16 seconds
sbom-json-check

✅ Succeeded
16 seconds
sanity-label-check

✅ Succeeded
16 seconds
sanity-optional-label-check

✅ Succeeded
9 seconds
show-summary

Pipelines as Code CI/test-component-pac-dpll-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
13 seconds
clone-repository

✅ Succeeded
39 seconds
build-container

✅ Succeeded
14 seconds
sanity-inspect-image

✅ Succeeded
11 seconds
deprecated-base-image-check

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
10 seconds
sbom-json-check

✅ Succeeded
33 seconds
clamav-scan

✅ Succeeded
10 seconds
sanity-optional-label-check

✅ Succeeded
10 seconds
sanity-label-check

✅ Succeeded
4 seconds
show-summary


Build cache configuration is ignored when applying a settings plugin that causes accessor generation

Current Behavior
Generating the accessors for settings.gradle.kts will trigger the creation of the build cache controller, which snapshots the cache settings that haven't been configured yet.
Therefore, the build cache configuration in settings is ignored, and when using the Develocity build cache the build will fail on a configuration cache hit.
Expected Behavior
Not trigger the snapshot of cache settings
Context (optional)
No response
Steps to Reproduce
https://github.com/sorin-florea/gradle-reproducers/tree/main/build-cache
Essentially, have this in your settings.gradle.kts:
plugins {
    id("com.gradle.develocity") version "3.17.2"
}

buildCache {
    local {
        isEnabled = false
        isPush = false
    }
    remote(develocity.buildCache) {
        isEnabled = true
        server = "https://ge.gradle.org/"
    }
}

Run gradle help --configuration-cache --build-cache
Run gradle help --configuration-cache --build-cache again
The second build fails with

Could not create service of type BuildCacheController using .createBuildCacheController().
> Extension of type 'StateAccess' does not exist. Currently registered extension types: [ExtraPropertiesExtension]

Gradle version
8.8+
Build scan URL (optional)
https://ge.gradle.org/s/jtc3sf3b2w6ea
Your Environment (optional)
No response

Fixed through

#28879


Change brightness without switching light on

Hi
I'm getting more and more into Huemagic and finding out what I can do.  Thanks for your work so far.
I've come across one thing I'd like to do but can't.  There's probably a workaround using variables but what would be useful is to be able to change the brightness of a light or a group without turning it on.  I don't always want the light to come on at the same settings it was at when it was switched off.
So, for example, if I have Light A with brightness at 100% and I turn it off, then the brightness parameter stays at 100% but the "on" parameter is set to false.  If I turn it back on  then it comes back on at 100%.
If the light is off and I change the brightness parameter to 50% then the light turns on at 50%
If the light is off and I send an "extended" object {on:false, brightness: 50} then the on:false is ignored and the light turns on at 50%
What I would like to do is be able to change the stored brightness level so that when the light is next turned on, it comes on at the new level, but do that without turning the light on.
Is it possible to change the node so that from a current state of {on:false, brightness:100%}, the following commands work in the following way:
payload: true -> turns on at 100% (as before)
payload:{brightness:50%} -> turns on at 50% (as before)
payload:{on:false, brightness:50%} -> light stays off but brightness parameter changes to 50%
An even better solution would be that the extended settings would follow the on parameter i.e
payload:{on:true, brightness:50%} turns on at 50% or stays on at 50%
payload:{on:false, brightness:50%} turns off or stays off  but brightness parameter changed to 50%
payload:{brightness:50%} brightness parameter changed to 50% and on/off state remains unchanged
... but that might break a few people's flows if they are relying on the brightness parameter alone to turn the light on.
A related question:
I'd also like to be able to change the colour temperature while the light is off.  At the moment if the light is off I get an input error "Error:  Philips Hue: 201, parameter, ct, is not modifiable.  Device is set to off."  Perhaps you can't do anything about that if it's a bridge issue.  Maybe I'll have to trap the on/off commands, recall what I want it to switch on at from a variable and send it as an extended command when I want to switch the light on with new settings.
Thanks again for your work
Simon

This works with 2.8.0+ :)!

Awesome!  I'll look forward to playing with the new version.
Many thanks

Hi
Just tried this with 2.8 and 2.8.1 and I'm not sure what has changed.  The functionality above doesn't seem to be working.
Ah OK the last bit has changed.  I no longer get an error if I change the colour temp when the light is off but I can't change the brightness, even if I send an {On : false} at the same time, without the light turning on
If I have a light at 100% and turn it off.  The brightness stays at 100% but the On property changes to false.   If I change the brightness to 50%, the light turns on.  I was hoping it would stay off but when I turn it back on later, it would come on with the brightness already at 50%.

Any update on this Foddy?
I still can't change the brightness of a group that's has the ON property set to false (i.e. the lights are off) without the ON property changing to true and the lights coming on at that brightness.  I'm using 2.8.6.
What I'm looking to do is have a timer-based controls that change the brightness and colour temperature settings irrespective of whether the lights are on or off.  Then when someone switches the lights on they come on at those settings without me having to do additional logic or have to keep track of separate variables for what the lights need to come on at next time.
Still finding your nodes super-useful though:^)


Update Building.md

removed a part of the apt command that would cause an error

The instructions edited here are replaced by newer instructions which no longer include libpng (because we don't use it)

This is fixed on the develop branch, thank you anyways.


add app-delegate

Summary
add app-delegate dependency

Closing in favor of https://github.com/cerner/terra-dev-site/pull/129


Fix del function in cacheStore.js, causes cache key not purged properly

Cache key in del function has no keysPrefix, it causes the cache key would never be purged.

@dinhkhanh @stafyniaksacha I have a similar issue but when using "routes -> path". Cache is saving well in Redis and is automatically deleted after chosen time but... cache is not purged when I update an entry OR click PURGE button in CMS. Everything works fine if I do not use "routes" option. Any thoughts?


[0.19] Backport: Adding global TLS/SASL for the consolidated KafkaChannel

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>Mix of a few PRs:

https://github.com/knative-sandbox/eventing-kafka/pull/192
https://github.com/knative-sandbox/eventing-kafka/pull/201
https://github.com/knative-sandbox/eventing-kafka/pull/205
https://github.com/knative-sandbox/eventing-kafka/pull/209

@googlebot I consent.

@google I consent.

@googlebot I consent.

/retest
On Fri 20. Nov 2020 at 14:33, Knative Prow Robot<EMAIL_ADDRESS>wrote:

@matzew https://github.com/matzew: The following test failed, say
/retest to rerun all failed tests:
Test name Commit Details Rerun command
pull-knative-sandbox-eventing-kafka-integration-test-channel-consolidated-tls
eb2cdc2
https://github.com/knative-sandbox/eventing-kafka/commit/eb2cdc2857de249f93680b5a49e5fcb3c506fb68
link
https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka/211/pull-knative-sandbox-eventing-kafka-integration-test-channel-consolidated-tls/1329772754764828672 /test
pull-knative-sandbox-eventing-kafka-integration-test-channel-consolidated-tls
Full PR test history
https://gubernator.knative.dev/pr/knative-sandbox_eventing-kafka/211. Your
PR dashboard https://gubernator.knative.dev/pr/matzew.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/knative-sandbox/eventing-kafka/pull/211#issuecomment-731171971,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABGPTVUG5X26YIN3UNJP6TSQZVWZANCNFSM4T4X3KTQ
.

--
Sent from Gmail Mobile

/lgtm

@matzew: Thanks a lot for all about SCRAM.
Linked to:

https://github.com/scram-xmpp/info/issues/1


[Snyk] Fix for 1 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

661/1000  Why? Recently disclosed, Has a fix available, CVSS 7.5
Denial of Service (DoS) SNYK-JAVA-ORGSPRINGFRAMEWORKBOOT-5564390
no.nav.security:token-validation-spring:  1.3.7 -> 3.1.0
Yes
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Vulnerabilities that could not be fixed

Upgrade:

Could not upgrade<EMAIL_ADDRESS>to<EMAIL_ADDRESS>Reason could not apply upgrade, dependency is managed externally ; Location: https://maven-central.storage-download.googleapis.com/maven2/org/springframework/boot/spring-boot-dependencies/2.5.12/spring-boot-dependencies-2.5.12.pom

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)

https://github.com/navikt/melosys-soknad-mottak/pull/252


1ESPT baselines required

Updated for https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_build?definitionId=494 by using baselines generated in https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_build/results?buildId=2403039

@dalehhirt , @ocallesp : Do we still need this PR?

Yes, we do
On Thu, May 9, 2024 at 1:52 PM Abhitej John @.***>
wrote:

@dalehhirt https://github.com/dalehhirt , @ocallesp
https://github.com/ocallesp : Do we still need this PR?
—
Reply to this email directly, view it on GitHub
https://github.com/dotnet/try/pull/1169#issuecomment-2103401796, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAREL32637UHXZD4BT5H5M3ZBPOXLAVCNFSM6AAAAABGVBXTLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGQYDCNZZGY
.
You are receiving this because you were mentioned.Message ID:
@.***>


feat(fetch): Support passing options object only

Codecov Report

Merging #5 into master will increase coverage by 0.25%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #5      +/-   ##
=======================================
+ Coverage   93.75%   94%   +0.25%
=======================================
  Files           4     4
  Lines          48    50       +2
  Branches       13    14       +1
=======================================
+ Hits           45    47       +2
  Misses          3     3

Impacted Files
Coverage Δ

packages/fetch/src/index.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3325342...4d1be4d. Read the comment docs.


Store full set of quarterly house prices

For future use just in case not available in future. (Store in Glacier Flexible Retrieval, files are very small (1.6MB for all of it approx))

In deep archive as we only need it if data.sa.gov doesn't have this anymore


add writable option to services.ttyd

addresses breaking change in ttyd 1.7.4, where the web terminal is now readonly by default, by providing a new option "writable"
see issue https://github.com/NixOS/nixpkgs/issues/268501

I think this should default to true as we run ${pkgs.shadow}/bin/login to basically allow shell over web. Or just better set to true without an additional parameter.
I ran into this when testing out 23.11 so we should back port this change.
For reference default behavior was changed in ttyd in https://github.com/tsl0922/ttyd/commit/f8efcddb0b615de7086fdb3c5f452d1ee42f32a3

We could make it writable true for stateVersion 23.05 and earlier but I'd be against purposefully being insecure and out of line with the upstream project for users who have no existing usages to regress/break

How about making it an error if it's not set, with an explanatory message about this situation

i continue the effort i #285314


Add nested support to elasticsearch connector

Add nested support and test cases.
Fix TimestampDecoder parsing avoid using fields.
Fixes #754

Seems like there was an error caused by vm crash perhaps? https://github.com/prestosql/presto/pull/2745/checks?check_run_id=431089886#step:5:1832
Can't reproduce locally so is there a way to try run the checks again?

@martint Should I add docs for nested type? There are currently no docs about regular object type so I wasn't sure.

That’d be great, but we can do it separately. Can you squash the commits in this PR. I’ll then go ahead and merge it.

Merged as 711b71751c80930506365393cffed2659be5b047. Thanks!

Merged as 711b717. Thanks!

Thanks for merging this! I can only do this on our non-work computer and my wife had it at her work all weekend.


Fix memory leaks in xla::BufferDonationTest

Leaks were detected by AddressSanitizer

Please wait for code owners approval.
On Sat, Dec 31, 2022 at 5:53 PM Mihai Maruseac @.***>
wrote:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/59033#pullrequestreview-1233367968,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACVGH3J6NIDKXOF3GLEIS3WQBXJ5ANCNFSM6AAAAAATLL3UWI
.
You are receiving this because your review was requested.Message ID:
@.***>

Could you post a leak description and a stacktrace? I'm having a somewhat hard time connecting the code changes to a leak, and we do run tests (at least internally) under asan - perhaps we have missed something?

Could you post a leak description and a stacktrace? I'm having a somewhat hard time connecting the code changes to a leak, and we do run tests (at least internally) under asan - perhaps we have missed something?

Sure, the summary from asan is
SUMMARY: AddressSanitizer: 40 byte(s) leaked in 7 allocation(s).
That goes from 3 tests, first one is BufferDonationTest_SimpleWhileTupleTestCopyProtection_Test
There's 3 buffers in ScopedShapedBuffer generated by AllocateScopedShapedBuffer in method RunAndCheck, sizes 16, 4 and 4 bytes, and they're all leaked.
Buffer 16 is not aliased, buffers 4 are aliased. Donation is not specified for this test.
In the end, inside ExecutionOutput object, buffer 16 is marked as aliased (in aliased_indices_ member), so when the object goes out of scope it's not deallocated inside its destructor. I've added a call to Commit method so aliased_indices_  would be cleared and these buffers would be deallocated. Same applies for another test (which I'll describe in a separate comment I think)
For buffers with the size 4, as they're aliased but not donated, it involves making copy buffers in CpuExecutable::CreateResultShapedBuffer method, and the references to the original buffers are lost, so they're not deallocated in the end. So I'm adding them to ownership_buffers so they would be deallocated when this variable goes out of scope (please see the comment 1. Aliasing is specified but the buffer is not donated )
Stacktrace for this case:
Direct leak of 24 byte(s) in 3 object(s) allocated from:
#0 0x5615d73cbce7 in __interceptor_posix_memalign (/tf/output_user_root/fbac33eb30dbfb6b11b15a7ff5ac830d/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/compiler/xla/tests/buffer_donation_test_cpu+0xbcce7) (BuildId: 93c31d7b9d14041de66592cfacf1cd32)
#1 0x7f2fa44a5c22 in tsl::port::AlignedMalloc(unsigned long, int) /proc/self/cwd/tensorflow/tsl/platform/default/port.cc:404:13
#2 0x7f2fa49ddc14 in stream_executor::host::HostExecutor::Allocate(unsigned long, long) /proc/self/cwd/tensorflow/compiler/xla/stream_executor/host/host_gpu_executor.cc:77:7
#3 0x7f2fa495b2d5 in stream_executor::StreamExecutor::Allocate(unsigned long, long) /proc/self/cwd/tensorflow/compiler/xla/stream_executor/stream_executor_pimpl.cc:536:43
#4 0x7f2fa4962b7f in stream_executor::DeviceMemory stream_executor::StreamExecutor::AllocateArray(unsigned long, long) /proc/self/cwd/./tensorflow/compiler/xla/stream_executor/stream_executor_pimpl.h:858:26
#5 0x7f2fa4962b7f in stream_executor::StreamExecutorMemoryAllocator::Allocate(int, unsigned long, bool, long) /proc/self/cwd/tensorflow/compiler/xla/stream_executor/stream_executor_pimpl.cc:947:17
#6 0x7f2fa81fb1d8 in xla::TransferManager::AllocateScopedShapedBuffer(xla::Shape const&, stream_executor::DeviceMemoryAllocator*, int, std::function<xla::Shape (xla::Shape const&)>) /proc/self/cwd/tensorflow/compiler/xla/service/transfer_manager.cc:341:5
#7 0x5615d7408d9d in xla::(anonymous namespace)::BufferDonationTest::RunAndCheck(std::unique_ptr<xla::HloModule, std::default_deletexla::HloModule>, absl::lts_20220623::Span<xla::Literal const>, absl::lts_20220623::Span, absl::lts_20220623::Span, xla::Literal const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator>) /proc/self/cwd/tensorflow/compiler/xla/tests/buffer_donation_test.cc:102:7
#8 0x5615d741eb69 in xla::(anonymous namespace)::BufferDonationTest_SimpleWhileTupleTestCopyProtection_Test::TestBody() /proc/self/cwd/tensorflow/compiler/xla/tests/buffer_donation_test.cc:282:3

Second test is BufferDonationTest_TestMustAliasNotDonated_Test
There's 2 buffers, 4 bytes each, both are leaked. For this test failure is expected, so the buffers are not deallocated when ExecutionOutput object goes out of scope. So I'm adding them to ownership_buffers so they would be deallocated when this variable goes out of scope (that's 2. Failure is expected, so ExecutionOutput won't be committed )
Stacktrace:
Direct leak of 8 byte(s) in 2 object(s) allocated from:
#0 0x5615d73cbce7 in __interceptor_posix_memalign (/tf/output_user_root/fbac33eb30dbfb6b11b15a7ff5ac830d/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/compiler/xla/tests/buffer_donation_test_cpu+0xbcce7) (BuildId: 93c31d7b9d14041de66592cfacf1cd32)
#1 0x7f2fa44a5c22 in tsl::port::AlignedMalloc(unsigned long, int) /proc/self/cwd/tensorflow/tsl/platform/default/port.cc:404:13
#2 0x7f2fa49ddc14 in stream_executor::host::HostExecutor::Allocate(unsigned long, long) /proc/self/cwd/tensorflow/compiler/xla/stream_executor/host/host_gpu_executor.cc:77:7
#3 0x7f2fa495b2d5 in stream_executor::StreamExecutor::Allocate(unsigned long, long) /proc/self/cwd/tensorflow/compiler/xla/stream_executor/stream_executor_pimpl.cc:536:43
#4 0x7f2fa4962b7f in stream_executor::DeviceMemory stream_executor::StreamExecutor::AllocateArray(unsigned long, long) /proc/self/cwd/./tensorflow/compiler/xla/stream_executor/stream_executor_pimpl.h:858:26
#5 0x7f2fa4962b7f in stream_executor::StreamExecutorMemoryAllocator::Allocate(int, unsigned long, bool, long) /proc/self/cwd/tensorflow/compiler/xla/stream_executor/stream_executor_pimpl.cc:947:17
#6 0x7f2fa81fb1d8 in xla::TransferManager::AllocateScopedShapedBuffer(xla::Shape const&, stream_executor::DeviceMemoryAllocator*, int, std::function<xla::Shape (xla::Shape const&)>) /proc/self/cwd/tensorflow/compiler/xla/service/transfer_manager.cc:341:5
#7 0x5615d7408d9d in xla::(anonymous namespace)::BufferDonationTest::RunAndCheck(std::unique_ptr<xla::HloModule, std::default_deletexla::HloModule>, absl::lts_20220623::Span<xla::Literal const>, absl::lts_20220623::Span, absl::lts_20220623::Span, xla::Literal const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator>) /proc/self/cwd/tensorflow/compiler/xla/tests/buffer_donation_test.cc:102:7
#8 0x5615d74235f8 in xla::(anonymous namespace)::BufferDonationTest_TestMustAliasNotDonated_Test::TestBody() /proc/self/cwd/tensorflow/compiler/xla/tests/buffer_donation_test.cc:342:3

And the third one is BufferDonationTest_SimpleWhileTupleTest_Test
There's 3 buffers, 16, 4 and 4 bytes. Buffer 16 is not aliased, buffers 4 are aliased. Donation is specified for this test.
Originally only buffers with the size 4 are leaked. It's the same as for the first test - they're in aliased_indices_, so it's cleared in Commit method, but then there's new error - buffer 16 is double-freed. The reason is that this buffer eventually ends up in two separate places inside ExecutionOutput object: in result_ member and in to_be_released_  member. To me it looks wrong, and my assumption is that donation can only be applicable for aliased buffers, i.e. one should not donate a buffer that is not aliased. That's why I've modified the condition to be if (donate_argument && aliased) not just if (donate_argument)
Stacktrace:
Direct leak of 8 byte(s) in 2 object(s) allocated from:
#0 0x5615d73cbce7 in __interceptor_posix_memalign (/tf/output_user_root/fbac33eb30dbfb6b11b15a7ff5ac830d/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/compiler/xla/tests/buffer_donation_test_cpu+0xbcce7) (BuildId: 93c31d7b9d14041de66592cfacf1cd32)
#1 0x7f2fa44a5c22 in tsl::port::AlignedMalloc(unsigned long, int) /proc/self/cwd/tensorflow/tsl/platform/default/port.cc:404:13
#2 0x7f2fa49ddc14 in stream_executor::host::HostExecutor::Allocate(unsigned long, long) /proc/self/cwd/tensorflow/compiler/xla/stream_executor/host/host_gpu_executor.cc:77:7
#3 0x7f2fa495b2d5 in stream_executor::StreamExecutor::Allocate(unsigned long, long) /proc/self/cwd/tensorflow/compiler/xla/stream_executor/stream_executor_pimpl.cc:536:43
#4 0x7f2fa4962b7f in stream_executor::DeviceMemory stream_executor::StreamExecutor::AllocateArray(unsigned long, long) /proc/self/cwd/./tensorflow/compiler/xla/stream_executor/stream_executor_pimpl.h:858:26
#5 0x7f2fa4962b7f in stream_executor::StreamExecutorMemoryAllocator::Allocate(int, unsigned long, bool, long) /proc/self/cwd/tensorflow/compiler/xla/stream_executor/stream_executor_pimpl.cc:947:17
#6 0x7f2fa81fb1d8 in xla::TransferManager::AllocateScopedShapedBuffer(xla::Shape const&, stream_executor::DeviceMemoryAllocator*, int, std::function<xla::Shape (xla::Shape const&)>) /proc/self/cwd/tensorflow/compiler/xla/service/transfer_manager.cc:341:5
#7 0x5615d7408d9d in xla::(anonymous namespace)::BufferDonationTest::RunAndCheck(std::unique_ptr<xla::HloModule, std::default_deletexla::HloModule>, absl::lts_20220623::Span<xla::Literal const>, absl::lts_20220623::Span, absl::lts_20220623::Span, xla::Literal const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator>) /proc/self/cwd/tensorflow/compiler/xla/tests/buffer_donation_test.cc:102:7
#8 0x5615d7401619 in xla::(anonymous namespace)::BufferDonationTest_SimpleWhileTupleTest_Test::TestBody() /proc/self/cwd/tensorflow/compiler/xla/tests/buffer_donation_test.cc:265:3

And the last change ShapeTree<se::DeviceMemoryBase> &input_buffers = shaped_buffer.buffers(); is kinda for optimization, it doesn't relate to leaks. buffers method returns a reference, there's no real need to make a separate ShapeTree object there

@reedwm Could you take a look?

And the last change ShapeTreese::DeviceMemoryBase &input_buffers = shaped_buffer.buffers(); is kinda for optimization, it doesn't relate to leaks

Could we remove it from this PR then? Overall the PR looks way too large for something addressing a leak inside a test.

And the last change ShapeTreese::DeviceMemoryBase &input_buffers = shaped_buffer.buffers(); is kinda for optimization, it doesn't relate to leaks

Could we remove it from this PR then? Overall the PR looks way too large for something addressing a leak inside a test.

Sure, this change's been reverted

Hi @cheshire Can you please review this PR ? Thank you!

Hi @cheshire Can you please review this PR ? Thank you!

Hi @cheshire Can you please review this PR ? Thank you!

Hi @rbaranchuk-capgemini Can you please resolve conflicts? Thank you!

Hi @rbaranchuk-capgemini Any update on this PR? Please. Thank you!


Mac6 is quarantined with No device is available

Filed http://fxbug.dev/73672 to track.

Came back online.


Added Tutorial Section for Mongodb-tutorialspoint

Added Tutorial link for Mongodb from tutorialspoint

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

LGTM


FInished adding typing match ups to typechart.py

Added typing match ups to typechart.py. Please review

Looks good to me, good catch on the steel weakness on the fire typechart


[FEATURE] init unit test

Related Issue: #2

[x] Banner
[x] Button
[x] Support Button
[x] Floating Button
[ ] Drawer
[ ] Circle Loading
[ ] Infinite Scroll Loading
[ ] Dropdown
[ ] Dropdown Item
[ ] Dropdown menu
[ ] Dropdown Selector
[ ] Dropdown Toggle
[ ] Modal
[ ] Pagination
[ ] Split Button
[ ] Tooltip

I propose, what if we coupled testing spec with component, so instead place all test in folder test, we could place it next to Banner.tsx
my reference https://medium.com/@8f3a6795aaa1/2fd3ea1920f1 section "What could be a better approach to organize your application?"

good idea! after some thought and research, I think we can move all tests to its respective component


Owners of leased cars without owner credentials cannot add third-party apps

It is quite usual in EU/UK for people not to have access to owner credentials when they lease a car. This makes it impossible for them to add a 3rd-party app. They get a message like this from Tesla app (translated): "You are not authorized to share this vehicle. Contact the owner of the vehicle to grant third-party access."
Specifically, this happens after the 3rd-party app launches Tesla app to have it install the public key associated with the app on the car.
Is this going to change?

I can confirm the same restriction applies to a DRIVER (not OWNER) account for an Australian vehicle.

I hope this will be changed. A person with DRIVER access is able to perform most (all?) commands using the Tesla app, so it makes sense to me that they can also perform commands via a third-party app.

I hope this will be changed. A person with DRIVER access is able to perform most (all?) commands using the Tesla app, so it makes sense to me that they can also perform commands via a third-party app.

Especially since a Driver can send commands to the car using the Tesla app.

How can someone have an owner access from Tesla for Business management website?
From my T4B account I can only assign drivers access... And my T4B admin account isn't not even an owner...
That said, It seems that any car linked to a T4B account can't use third-party apps (commands)

Any update here? It appears there is no solution for fleet vehicles (tesla for business), ie there is no way to install a virtual key on those vehicles.

So for clarification, you're saying that anyone with a leased vehicle currently can't enroll a 3rd party public key?

So for clarification, you're saying that anyone with a leased vehicle currently can't enroll a 3rd party public key?

Depends on the car owner/dealer. In Europe more dealers that lease the car, do not give the Owner Credentials for people who lease the car. So, this because a problem if the person who leases a car wants to use a 3rd party app.

We received this statement from Tesla<EMAIL_ADDRESS>which suggests that a fix is coming for this:

The ability for lessees/drivers to grant permissions to third party applications and services will be available with an upcoming Tesla App update. Once released the driver will be able to confirm permission sharing using their Tesla vehicle touchscreen and keycard.

Has anyone received the app update yet or know of an ETA? Kinda blocked from charging using intelligent tariffs at cheap rates until this is fixed.

Appears that app version 4.29.5 (iOS) has fixed this. I've just downloaded it but not actually gone through the whole process yet. After trying to add a virtual key it says you need to use your keycard so presumably need to be in the car.

I can confirm this works on ios now. Still broken on android though

What would be needed to make it work on android phones?

I can also confirm it works on iOS and not yet on Android. Perhaps this ticket could be re-opened until Android is working.

Today I noticed a new version of the Tesla app on android. This new version fixed this!
You need to be in the car with your keycard and confirm the access on the screen of the Tesla.

is anyone having issues with the actual in car steps?
We are experiencing when the keycard is placed on the center console as prompted to by app, clicking approve on the screen, nothing happens. No success message on the Tesla screen, or anyting in the Tesla App.

Hello. I'm not sure if i did the right thing or not. Here is what I have:
1- Model 3 Not leasing. it is working fine with the command API "Tesla Vehicule Command Proxy"
2- model Y 2023 leasing: does not work with the "Tesla Vehicule Commad Proxy" but works with the REST-API.
3- model X 2023 leasing: does not work with the "Tesla Vehicule Commad Proxy" but works with the REST-API.
Is that the way it is supposed to work or am I missing some setting so I can get the "Tesla Vehicule Command Proxy" to work?

I just followed the procedure after my tesla app on my android was updated to 29.5 and initially I got the same error, but then used the button to do it with the key card and it worked. Tested from my teslafi account.

Hi there,
I'm driving a leased 2023 Model Y and I'm trying to setup teslemetry for Solar charging. Unfortunately with latest IOS Tesla App I'm not able to setup access rights for Teslemetry correctly. I can read car data, but not send any command to the car. On the teslemetry console, "Access Type: DRIVER and Command Sign: REQUIRED" is displayed, however in the tesla APP Teslemetry is setup with full access rights in the Security menü. Anyone having a hint whats wrong? I really would love to use Teslemery
best regards
Michael

I want to use Teslemetry with a leased Model Y. I was able to setup the access for Teslemetry, both in the car an also in the Tesla App Teslemetry is configured and listed as accessible. However, in the Teslemetry console, the status is still
Access Type:DRIVER
Command Sign:REQUIRED

Does anyone know how to solve this?

Model Y - Leased Car
Android app version 4.33.5-2673
Car software: 2024.20.1
Not able to add public key

Model Y - Leased Car Android app version 4.33.5-2673 Car software: 2024.20.1
Not able to add public key

Were you able to fix this issue? I have same situation.

Yes, with the new app version, you follow the process in the car. At a certain moment you need to present your key card to proceed.

On 16 jul 2024 at 01:28, ViNYLeq  @.***>  wrote:

Model Y - Leased Car Android app version 4.33.5-2673 Car software: 2024.20.1
Not able to add public key

Were you able to fix this issue? I have same situation.
—
Reply to this email directly,   view it on GitHub, or   unsubscribe.
You are receiving this because you commented.Message ID:  @.***>

This is not required, I have finished my config late night without a need to go and use the card.


Don't force minlines in syntax/html.vim

Because it doesn't sync? I have to :syn sync fromstart all the time when editing HTML...

Because it doesn't sync? I have to :syn sync fromstart all the time when editing HTML...

Sounds more like you want a configuration variable that you can set for your specific use case.

How is 10 "not particularly bad" when the average HTML file is hundreds of lines?

I thought  you wanted to disable it for performance reasons. Guess what: there is a reason, why a PR contains a big field where you can and should enter comments :)
Also, I fail to see, how minlines has any thing to do with hundreds of lines. It may still work to sync within 10 lines, right?

How is it OK to not respect g:vimsyn_minlines

Because that is for vim syntax files?
As mentioned, we probably want to make this variable configurable rather than remove it

So make it configurable using g:vimsyn_minlines? Since that's a vim syntax file?

Before:

After:

The only thing I did between the two is remove the offending line, then :e to re-edit my file.

If anything what I want to do locally is increase it, not decrease it. But the static 10 in the syntax file prevents that... so clearly it has to go, I don't even know why it's forced that way instead of relying on user settings?

No, add a new variable, let's say: g:htmlsyn_minlines , mention it in the documentation at :h ft-html-syntax  and refernce it then in the html syntax file, similar to how it is done in the  vim syntax script

OK but then a follow-up question arises - why isn't there a way to globally set syntax sync minlines for all syntaxes? Related question, what makes you think 10 is a reasonable default (when it's clearly not, see my screenshots above)?

OK but then a follow-up question arises - why isn't there a way to globally set syntax sync minlines for all syntaxes?

Is there such a global thing? Where?

Related question, what makes you think 10 is a reasonable default (when it's clearly not, see my screenshots above)?

Just because it failed for your html files, doesn't mean it fails for anybody else. I don't work a lot with html files but whenever I did, it worked for me. And I guess nobody has complained until now ?

It looks to me like if I do exactly what vim.syntax is doing, it will be functionally equivalent to removing the line for most users (having g:htmlsyn_minlines unset). Is this what we want?

I'm literally asking why it doesn't exist.

Why should it? It clearly depends on the syntax you are using.

That's the part that genuinely surprises me - clearly when writing SFCs you're gonna have a relatively large script block and a relatively large style block, both of which are gonna be incorrectly synced 90% of the time, which is why (after frustratingly and frantically using :syn sync fromstart for years) I made this PR.

And thanks for that.

I'm working on the g:htmlsyn_minlines right now, but still I feel like it would be a good idea for users to have a global way to deal with syntax sync minlines, don't you think? Since the main issue with sync minlines is performance, scaling it up depends largely on how fast one's machine is, not really per-language

Ideally it should really be the responsibility of each syntax script maintainer to find reasonable good defaults, so that not each user has to fiddle with a global variable that does not always work for all kinds of languages. But it seems it doesn't always work well enough.

It looks to me like if I do exactly what vim.syntax is doing, it will be functionally equivalent to removing the line for most users (having g:htmlsyn_minlines unset). Is this what we want?

@dkearns what's your preference?

There's an extra issue for the latter point (documenting it in ft-html-syntax) - it looks to me like this documentation isn't representative of what we observe when editing HTML files (eg the part about <> and </> being colored differently), so perhaps this entire documentation page is out of date?


Js error in execution on google chrome

Hello.
I created a script using your plugin to animate the radar images to Rio de Janeiro. When I run this script in Mozilla all goes well, but the Chrome don't understand that the dates of the images are already in UTC and decreases 3 hours date I step to him . You know a way to solve this? The link to the page : http://<IP_ADDRESS>/alertadecheias/radar_animation/
Thank you

Are you modifying your script ?
I had different error each time I visited the page
Using momentjs
this works
function(url, time){
  var date = moment(time);
  return 'js/mac_s_04_'+date.format('YYYY-MM-DD-HH-mm')+'.png';
}

Yes. As i dont have a MapServer, i created a script in python to download
the radar imagens and mount the JS.
I'm gonna try your solution.
Thanks
2016-03-04 16:12 GMT-03:00 Ram<EMAIL_ADDRESS>
Are you modifying your script ?
I had different error each time I visited the page
Using momentjs http://momentjs.com/docs/#/displaying/format/
this works
function(url, time){
var date = moment(time);
return 'js/mac_s_04_'+date.format('YYYY-MM-DD-HH-mm')+'.png';
}
—
Reply to this email directly or view it on GitHub
https://github.com/socib/Leaflet.TimeDimension/issues/55#issuecomment-192420471
.


Allow automatic disposals of objects

Currently, IDisposable objects added to GraphicsDevice.DisposeWhenIdle will not be disposed until an explicit call to GraphicsDevice.WaitForIdle has been made.
This may cause high memory usage when it's not desired to call WaitForIdle too many times (since it will block), or in other cases, it "leaks memory" if people forget to call WaitForIdle.
This pull request doesn't change the behavior of DisposeWhenIdle (objects are not disposed, so guarenteed to be valid, until a WaitForIdle()), since there might be people that relies upon that behavior.
Instead, this pull request will add some new methods, in particular GraphicsDevice.AutoDisposeWhenIdle.
This new method behaves simiarly to DisposeWhenIdle, excepts that it might "decide" by itself to block the device until idle, and then automatically release resources.
We also had some discussion about it in the Veldrid Discord channel: https://discord.com/channels/757148685321895936/757148685321895939/801575253373222912

Just noticed that DisposeWhenIdle maybe should get a null check.

Just noticed that DisposeWhenIdle maybe should get a null check.


Positioning but how?

How can I move the button to the x=200, y= 300 of the screen. offsetX and offsetY don't seem to be working the way I want them.
I'm on react-native 0.24.0

offsetX and offsetY is added as paddingHorizontal and paddingBottom respectively to an object that is positioned by flex at the bottom of the screen.
Currently there doesn't seem to be a way of achieving what you want, that is positioning the action button at arbitrary coordinates.

I see thank you.


Add safety check for deleting real-time index (safety check)

Description
Add safety check for deleting real-time index (safety check)
Solution Approach
N/A
Documentation
N/A
Related PRs
List related PRs against other branches / repositories:

branch
PR

SymphonyElectron
link

QA Checklist

[x] Unit-Tests

Published<EMAIL_ADDRESS>


test-branch/execute-job/comment-from-wrong-user-on-pr/d0fb8b81-e4bf-4e6b-8e51-82a0790fbd10

PR for testing b888d20b3f6cb49bbbbdca48e43760716ab9ddca

/canonical/self-hosted-runners/run-workflows b888d20b3f6cb49bbbbdca48e43760716ab9ddca


adding China regions

https://github.com/powdahound/ec2instances.info/issues/330
similar to previous https://github.com/powdahound/ec2instances.info/pull/395
git clone https://github.com/patmyron/ec2instances.info
cd ec2instances.info
git remote add upstream https://github.com/powdahound/ec2instances.info
gh pr checkout 403
git fetch upstream
git rebase upstream/master
docker build -t ec2instances.info .
docker run -d --name some-container -p 8080:8080 ec2instances.info
open http://localhost:8080

I'm a bit reluctant to merge this until we have the data available. It will just create confusion for people who expect to see the data but instead won't get anything.

@cristim agreed

@cristim https://github.com/powdahound/ec2instances.info/issues/330#issuecomment-448306433

cfn-lint started picking up EC2/RDS/DAX instance type information from pricing for AWS China regions this month:
https://github.com/aws-cloudformation/cfn-python-lint/pull/1635#discussion_r471975612
so I think it's worth reconsidering this now

@PatMyron do you happen to know the latest on this? I think it would be cool to add pricing for China and can merge this in.


Support Storage vMotion while vDVS volumes are attached

I'm aware that currently Storage vMotion isn't supported by this plugin and results in strange behaviour, but it would be nice if this could be supported somehow?
I'm not sure how it would work with volumes created on specific datastores (e.g MyVolume@datastore1 - datastore1 would be available on one host but not another) but for those with no datastore constraint (e.g just MyVolume) this currently resolves to the same datastore where the current VM resides, so it could theoretically be migrated to the same target datastore for the VM during Storage vMotion?
At the moment my workflow for executing a Storage vMotion is to stop all running containers on the host so that the vDVS disks are detached from the VM, run Storage vMotion on the VM, manually move the VMDKs for the vDVS disks from within the vSphere Client and then start the containers again, but it would be nice if the containers could stay running somehow.
Thanks for the great work on this project :smile:

@madjam002, thanks for letting us know of your requirement, I'm curious why the VDVS volumes would need to be migrated. Storage vmotion applies to VMs where the VM's VMDKs (dependent disks) are migrated to a target datastore. The VDVS volumes are completely separate from VM disks and are managed wholly by the plugin and via the admin CLI on the ESX host. The datastores where the VDVS volumes get placed is also related but not limited to the datastore where the VM is located (although that's the default location).
I'd like to know the use case that requires migrating the VDVS volumes to a different location. The VDVS volumes are all tracked in a config database (if initialized) and that data would go stale if the volumes are migrated using the vSphere client.

@govint When I attempted a Storage vMotion earlier I noticed that the vDVS VMDKs were migrated but to the VM folder on the target datastore, not the dockvols directory.
My use case is being able to vMotion VMs off a host when it needs to be taken down for maintenance and currently it doesn't seem to be possible to migrate VMs with running Docker Containers with 100% uptime to another host.
Maybe there's another way to do this that I'm missing?

@madjam002, at this point in time VM migration scenarios aren't supported with VDVS disks attached. One option is to stop the workload and then migrate the VM. Assuming a docker swarm, another option is to drain services (containers) deployed to the VM first (via docker node command) and then migrate the VM. Post migrate, the VM would be made active to redeploy services.

Closing this as presently we don't support  migration scenarios for container volumes, plus, should also rethink if migration really makes sense with container workloads. The VM is very much part of the infrastructure and the workload (container) migrates across VMs. Balancing of volumes across (not supported yet) is something that can be addressed as also being able to migrate container volumes over datastores. Migration of VMs really doesn't apply, if anything

Simply drain the node (VM) of container workloads.
Perform maintenance of the VM (migrate).
Resume scheduling workloads to the node (VM).

@govint Can this not stay open? One of the benefits of vMotion is that you can reschedule a VM without downtime, and currently there isn't a way to migrate a VM with associated containers without downtime? The solution you proposed involves stopping the container on the VM.

@madjam002, this is an enhancement to how migration of VMs handle virtual disks and I already had an internal issue to address that on the ESX platform. But that will be addressed in subsequent releases of the ESX software. This issue need not be kept open as such. That said, draining containers off a VM only implies that those will now be scheduled on other VMs on the ESX hosts.or the same ESX host as the case may be. The containers shouldn't have to be stopped.

@govint Ah that's great so a future version of ESX will migrate attached virtual disks to the right location when doing vMotion?
And by draining containers off a VM still means that the container will be stopped and started on a different VM. With some container workloads which require persistent storage will result in downtime when doing this.

@madjam002, yes, thats the current idea to be able to address the needs of container workloads during migration.

FWIW, opened https://github.com/moby/moby/issues/35715 to allow an app to shutdown gracefully on container stop/pause so the app gets a chance to bring its data to a sane state before exiting or pausing. Can even allow the app to implement a hand-off to another instance if needed. Helps when instances are drained off a docker host for example.


feat(dataframe): support delete rows in DataFrame and ColumnSeries

Task linked: CU-2bpm5uq [parent] SDK 实现 Sheet 删除行的功能


Implement Model and column documentation flow

The basic flow for the doc command should be as follows:

dbt-sugar doc -m my_model
User would be shown the model-level description and asked a [y/n] question of whether they want to alter the current documentation.
Columns. We should start with the undocumented columns:

Users are told "There are n undocumented columns" and presented with a summary of the columns that are up for documentation.
Users are asked to choose which columns out of these the want to document. They would select them.
From that list we would ask them in order to document the column via a text prompt.
Once all the selected columns have been documented the list of columns + descriptions is passed back to the "back-end" and they are physically populated in the yaml files.

Columns. Already documented columns:

Users should also then be asked whether they want to amend or reword any already documented columns.
If yes, we should show them the list (we'll have to think about how to make it visually appealing and all that.
The flow from there is similar to the undocumented columns flow outlined above. Users select, document and we submit that back to the back end which goes and modifies the yaml files.

I think the next steps from there that we can build upon would be the ability to propagate the definitions across all models. @virvirlopez do you think that makes sense to follow this issue with that extension or do you think maybe we should leave that for later and move on to test enforcement next so we cover more feature ground? I'm open to suggestions and to your feeling on prioritisation.

Closed by #46  and #50

Closed by #46  and #50


How to have a transparent background?

On the v2, I was able to have a transparent background on my scene, but now with the v3 I'm not able to do this anymore.
How can I set my Router/Scene to have a transparent background?
Thanks

The problem in NavigationCard of React Native package:
      <Animated.View
        {...panHandlers}
        style={[styles.main, animatedStyle]}>
        {this.props.renderScene(sceneProps)}
      </Animated.View>

So the component can't pass own style to NavigationCard and it is weird. Please create issue there if you want it to be fixed:
https://github.com/ericvicenti/navigation-rfc

The NavigationCard in the last React Native 0.22rc-4 has the following:
     <Animated.View
        {...panHandlers}
        style={[styles.main, style]}>
        {this.props.renderScene(sceneProps)}
      </Animated.View>

style is a prop and I'm not sure how to access it via Scene/Router @aksonov ?

Looks like rc4 doesn't have this code, only latest master branch, and i was not able to run our Example with latest branch (it just shows white screen), so you have to wait. Maybe this component needs some changes like passing style to NavigationCard or AnimatedNavigationView but i can't test it now.

Looks like rc4 doesn't have this change, but master does. Anyway i've added this feature to the component (once NavigationCard will have style support, it should work), release 3.0.14

How to override this value here: https://github.com/aksonov/react-native-router-flux/blob/master/src/DefaultRenderer.js#L88

Check code above:
             style={[styles.animatedView, navigationState.style]}
``

@aksonov saw that, but where and how should I pass the style? in the Router? In each Scene? What if I want to set it globally? could you give me an example?
Thanks

For each scene.  If you want to set globally you can wrap View around Router, but current Navigation API doesn't support it, you have to wait until current master  will be published as i said above.

ok, which parameter should I use for each scene?

Read my answer again. i said 'master', not rc-4...

@zelphir You may use new feature #356 with 3.1.0 - you can pass some property to all scenes from Route. So you could pass sceneStyle, for example, and then use props.sceneStyle within your Scene...

@aksonov thanks!

Im still having this problem, cant make the scene transparent with 3.26.1. I cant see the background Image. Please can somebody help me? Thanks
            <View style={styles.container}>                 <Image source={require('Correos/imgs/bg-photo.jpg')} style={styles.background} />                 <Router style={styles.overbox} sceneStyle={styles.routerScene}>                     <Scene key="home" component={LoginView} title="Home" />                 </Router>             </View>
    container:{         flex:1,         backgroundColor: "black"     },     routerScene:{         backgroundColor: "transparent"     },     background:{         flex:1,         resizeMode: 'cover',         width: null,     },     overbox: {         position: "absolute",         left:0,         top:40,         backgroundColor: "transparent",         width: width,         height: height     },

this works but the previous scene is visible underneath. Should be an easy fix to animate it further off screen. Is there an api for that?


Allow configuring https port for monitoring

When certs are present, we should allow enabling the HTTPS port to monitor the cluster securely:
https://github.com/nats-io/nats-operator/blob/master/pkg/util/kubernetes/kubernetes.go#L421

Fixed via #131


Adding example of cross modal search

Update example of cross modal search, our objective is:

[x] Clean up current cross-modal search example
[x] Add evaluation to the cross modal search example, to evaluate search performance
[x] Integrate CLIP model into cross modal search with evaluation
[x] Compare the current implementation (VSE++ model) with CLIP model to see the performance gain
[ ] Some leftovers, such as Readme. Dockerfile.
[ ]  Write blog @davidbp

For evaluation:
Image to text  -> use BLEUEvaluator to measure the difference between generated text and labeled sentences.
text to image -> use precision/recall/f1 and MRR to measure the ranking result

Hey @bwanglzu , I would just use precision/recall for both, at the end we know the expected groundtruth. Does that make sense?

make sense to me!

evaluation mode:
text2image: Query image by text and compute mRR. CLIP 0.4710, VSE++ 0.4527, 8000 images CLIP takes 13 minutes, VSE++ 32 minutes.
image2text: PLACEHOLDER

MeanReciprocalRank is: 0.36691655362180126
python evaluate.py -e text2image -i 16000 -n 4000 -m vse -s 32

MeanReciprocalRank is: 0.4018869057074189
python evaluate.py -e text2image -i 16000 -n 4000 -m clip -s 32

MeanReciprocalRank is: 0.40887093350663783
python evaluate.py -e image2text -i 16000 -n 4000 -m clip -s 32

MeanReciprocalRank is: 0.37910317568853497
python evaluate.py -e image2text -i 16000 -n 4000 -m vse -s 32


Fix TSAN

Codecov Report
Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 49.78%. Comparing base (583c04f) to head (ea4d34b).

Files
Patch %
Lines

amlip_cpp/src/cpp/types/status/StatusDataType.cpp
75.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   51.04%   49.78%   -1.27%
==========================================
  Files          64       64
  Lines        3013     3013
  Branches     1112     1112
==========================================
- Hits         1538     1500      -38
- Misses        653      685      +32
- Partials      822      828       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Homepage is not responsive on mobile

It's currently showing horizontal scroll.

[ ] Identify offending html tag
[ ] Fix width of such tag

Looks like it might the Quote block.
cc: @jose-correia

Fixed by: https://github.com/adobe-basel/summit-emea-team-2/pull/60


Local Compilers

There is error messages, while starting node.js server with compiler explorer.

Unable to get version for compiler '/usr/bin/g++' - Error: spawn /usr/bin/g++ ENOENT
etc.
Need to fix this. Because explorer has no local compilers to work with.

Add wontfix label.
It's compiler-explorer bug.
Right now it works & information about usage under Windows OS is described in readme.md file.


re-export RLIM_INFINITY from libc

Fixes #1803

PR #1830 was accidentally closed, but I didn't click that close button at all, seems to be a GitHub bug, so weird:(

Test timed out, could we give it a retry?

bors retry

This is kinda weird, the test has been running for an hour. Perhaps there is something wrong with the CI?

We'll see if it was a transient issue.
bors retry


[Query]File explorer not opening upon clicking

Hey @ChrisAnd1998 Chris, hope all well at your end.
Just recently I observed that clicking on the file explorer icon in TaskbarX is not launching my win explorer as it did earlier :( is it just me?

I think it's just you XD. Maybe a bug in Windows... TaskbarX only knows the size of the first and last icon in the taskbar nothing else.
Everything is ok :) I have been working so much on TaskbarX lately that i just need a break for a couple days...

yeh, a restart of the windows seemed to fix it...lol..you know how Windows is and how reboot helps most of the times :) even in life if you ask, so yes go for that well deserved break and stay safe mate.


Back Button Doesn't Cause PageModel events

Pushing a PageModel using the CoreMethods.PushPageModel<>(object, true); interface does not result in any events being raised if the Android Back button is pushed.

I'm finding the same thing. In my case I have a secondary page of comments. After a user adds a comment to the initial object, I'd like to pass that back to the initial page in the ReverseInit method. Is this the proper way to do this or should my secondary screen be modal with a close toolbar item that I could use to pop it?

This needs fixed.

@mathewgrabau @robertbaker @redwards1966 What would you like to happen when the Android back button is pressed?

Hi Michael,
I'd like to see it call the ReverseInit function on the previous model.

Has anyone picked this issue up? As a note, I think this issue will likely be tied to the result of this issue: https://github.com/rid00z/FreshMvvm/issues/24

I haven't picked this up. If you're already there feel free to take a look.

@redwards1966, In order to make ReverseInit work we need to pass some data to PopPageModel. When user tap on hardware back button we just have no information which data should be passed. The most obvious (and dirty) solution would be to override OnBackPressed in your secondary page and call ReverseInit by hand the same way it is called in the framework source code.
As an alternative (if you don’t want to mess with Pages) you may use ViewIsDisappearing method from FreshBasePageModel, but in that case ReverseInit will be invoked twice in case if user tap on non-hardware back.
@rid00z, not a solution of the current problem, but just to simplify such scenarios I propose to create a FreshBasePage that will fire OnBackPressed and Appearing/Disappearing events to its FreshBasePageModel. Honestly current WireEvents method makes me think about memory leaks. Maybe I’m wrong and everything is fine there, but when I see event subscriptions and do not see unsubscriptions I feel not comfortable.
Those changes should not break backward compatibility with current framework. Will you approve that?

Is someone working on this? I ran into this today. :)

ReverseInit was designed to collect data when returning pushed page. It's seems it's being used for more purposes than intended. We can definately add the ability.
On the FreshBasePageModel there's appearing and disappearing events, why wouldn't those events work?

The problem is, that pressing the hardware backbutton does not fire these Events but the virtual Method Page.OnBackButtonPressed is called.

Couldn't it be good to know, in the ViewModel when the Page is dissappearing (could be removed, or Another page could be put on top of it), AND when the page is really popped from the stack?Perhaps some kind of Clean-up should be done when popped from the stack. And it really doesn't matter if it's popped because of some code saying Pop()… or if the user presses a hardware back button.
Or am I missing something here? Is there an easy way to know, in ReverseInit, if the page is still on the stack?


Add NuGet package

NativeMethods.cs: Added automatic loading of either x86 or x64 native dlls at runtime.  This assumes that the native dlls are in subdirectories called x64 and x86, as is the case when using the NuGet package.  If these directories are not present, then falls back on the existing behaviour where the appropriate native dll is assumed to be in the same directory as the managed assembly.
Add upscaledb-dotnet.nuspec: Contains NuGet config to create package. The package is created in the bin\Release directory for a release build - see post build step in upscaledb-dotnet.csproj.
Add upscaledb-dotnet.targets: This file is included in the NuGet package, and is automatically added to the .csproj file using the pacakge by NuGet. It is responsible for copying over the native dlls to the project output directory.
Sample project files: added post build step to copy native dlls into output directory

Note: to update version number of NuGet package, update the -Version command line argument passed to nuget.exe in the post-build step in upscaledb-dotnet.csproj.

Hi Matthew,
since this patch is not trivial I require a contributor's agreement. I sent you an email with the details.
Thanks
Christoph


Add possibility to configure additional labels and annotations for the deployment

For many kubernetes tools we need to set additional annotations and labels on the deployment entity.
This PR introduces new values to configure custom annotations and labels, similar to what we already have on pod level.

Thanks @tessig !


feature: split telescope integration into a separate plugin

Did you check the docs?

[X] I have read all the todo-comments.nvim docs

Is your feature request related to a problem? Please describe.
Yes, but a small problem. I like lazy-loading plugins with mappings (telescope for example). And I like loading some plugins at startup or with events (highlighting TODO comments for example).
I currently use event = "VimEnter" for this plugin (todo-comment.nvim) when lazy loading. This allows me to view the TODOs in the status col and have highlighting for TODOs immediately when I open a file. But, I also like using TodoTelescope to view all of the project TODOs.
With the current state of this plugin, I must have telescope (and its dependecies) as a dependency on the VimEnter event. The difference in startup-time is negligible to be honest. But this is the only plugin that prevents me from lazy-loading telescope with a keybinding.
To summarize the problem: this plugin has features that one may want at startup, and some that one may want lazy-loaded. But the lazy-loaded features can't be lazy loaded in an effective way.
Describe the solution you'd like
Separate the telescope integration into a separate plugin (telescope-todo-comments.nvim) for example. This is an opinionated suggestion, but it separates concerns in a more clear way.
Describe alternatives you've considered
I have a work-around where I add todo-comments as a dependency for telescope, and then add the binding for :TodoTelescope to my telescope config. This works, but then my config for separate plugins is tightly coupled and it makes it difficult to "turn off" plugins if I no longer wish to use them.
Additional context
I can do the work for this new plugin since this is a specific request. It may cause some confusion in the "folke ecosystem", so it may have value if folke creates the repo and then I make PRs to it. But I don't feel strongly about this.

While at it, I wonder why we have :TodoTelescope instead of :Telescope todo or similar.

todo-comments doesn't need telesope.nvim when you run it's setup, so you must be loading it wrong.
If you're using lazy.nvim, then you don't need to specify "telescope.nvim" as a depenency. Lua code deps are resolved automatically and lua requires are automatically lazy-loaded.


Downgrade to STAR 2.6.1d for now

As mentioned in #172, we should probably wait at least until all iGenomes resources have been updated with compatible 2.7X indices ...?

Just done 👍


Multiple objects in one buffer

Hi!
When using glz::write_binary_untagged it looks like glaze always overwrites the contents of the input buffer. Is there any way to have the new data appended instead?
Thanks
Br/ Christoffer

Glaze supports NDJSON, and the intention was to add matching support for delineated binary, so that multiple objects occur beside one another in the same buffer. I'll keep this issue active until support has been added. Appending to the buffer in these contexts makes a lot of sense.

Sounds good. Thinking about it a read deserialise function from a buffer possibly containing multiple elements would also need to tell the user how many bytes were read, in case they want to remove those bytes from the vector (or similar).


Create functional ReMirror editor

From https://github.com/CDLUC3/dmsp_frontend_prototype/issues/6, we are going to go with ReMirror, unless we find it cannot work for us and need to change.  First step is to get a full demo working with the features we need.

@briri & @jupiter007 ; Do we know yet how we are going to store annotations in the database/backend? I'm assuming this is not yet well planned out because we might want to connect those comments with specific fields and users, some of which are not yet finalized.

That's a good question @andrewebdev. We haven't put any thought into where we're going to store annotations, and how we will store it. I would think we would need the following fields:
commentId
planId
userId
content
position
timestamp
parent comment id
Also, if we're expecting real-time editing, would mysql work for that? We would probably need to use a websocket, like what would be used for a chat?

I normally use a message queue like RabbitMQ, and then I have a backend task that later sync the messages into the DB.
That said, I'm starting to wonder if comments should be done at a later phase when other technologies are more fixed in place? Might be worth a 5 minute chat tomorrow?

Yes, we can discuss tomorrow in the meeting. I hadn't given it a lot of thought since we met in Edinburgh.
Originally I was think we could use a table that uses a polymorphic association pattern. I think though that it will depend a lot on how the comments are referenced within ReMirror. How does it markup the editor's HTML to embed or link the comment to a particular part of the text?
At minimum we will want this for the MVP for answers to questions on the DMP editing screens. The polymorphic pattern will still work with that and allow us to grow. So maybe something like:

textFieldId (the id of the thing the comment is associated with answerId in our initial case)
textFieldType (to start, we will just have Answer here)
commentorId (user's id)
comment
any markup ReMirror needs to contextualize the comment within the answer

In the richtext fields, remirror saves the "marks" for annotations in a separate JSON structure. But we can serialize this into the HTML when saving it. So In theory we can save it in the HTML. Since it's a separate JSON structure, we could also save this to the database separately. (hopefully I understood your question correctly ;) )

Ahh ok. If it can be easily serialized/deserialized from the HTML then maybe the most efficient thing to do would be to store it inline with the text. We could then just make sure we strip it out when needed like when generating a PDF export.

@bofstein we need to define what is necessary for the MVP to support commenting. We are finding that commenting can get very complicated quickly

@briri Ok I will try to put some notes in by end of week, but as a quick response I think it can be minimal.  E.g. at a minimum, I think we could have just plain text comments, who the comment is from, and a point within text where that comment goes, more like a footnote. (if that's super hard, maybe we could even just associate a comment with a whole question, but it would be a lot better to have it inline).  Other things like highlighting text (as opposed to inserting at one point), having overlapping highlights, rich text in comments, etc, I think can be nice to haves.

Adding comments to the field itself for now.

@andrewebdev here is how TinyMCE is storing font sizes and colors chosen by the user. (Not suggesting we need to do it the same with reMirror, this is just for reference):

One fish two fish red fish blue fish.

Bigger size

smaller size

@bofstein I ran some queries against the current DMPTool production system. Over the past 2 1/2 years (since Jan. 1, 2022) we have had:

Out of 228,357 DMP answers

600 that have a specific color specified
1,159 that have a font size specification

Out of 12,238 Template questions

46 that have a specific color specified
54 that have a font size specification

Of those, it looks like the majority are artifacts from copy/paste from other systems like MS Word. I base that assumption on the fact that they have a lot of HTML markup including line-height, colors as RGB values, etc.

@briri That's some interesting stats. SO more answers use the font colours and size, and not that many in the templates. Interesting observation that it may be due to copy/paste from word/other.
What do you guys think we should take from this going forward? I feel like I'm not well-placed to make this decision, but if this is indeed the case, then it feels like we can remove these options from the editor without affecting users much?

Ok thanks for the update @andrewebdev

@jupiter007 I just did a rebased my editor branch on development and I'm getting the following error:
 ⨯ ./components/TypeAheadWithOther/index.tsx:14:1
Module not found: Can't resolve './typeaheadWithOther.module.scss'
  12 | import Spinner from '@/components/Spinner';
  13 | import classNames from 'classnames';
> 14 | import styles from './typeaheadWithOther.module.scss';
     | ^
  15 | import logECS from '@/utils/clientLogger';
  16 |
  17 | type TypeAheadInputProps = {

https://nextjs.org/docs/messages/module-not-found

Is everything committed to that branch or are there changes pending?

@andrewebdev the development branch should be working. I just tested it and ran it both using npm run dev and docker-compose up and both are working for me. Maybe try and delete your .next directory and rebuild it to see if something is corrupted?

@jupiter007 not sure why it's working for you because I just found the issue ;)
The import is for typeaheadWithOther- With an uppercase 'W', but the filename is with a lowercase 'w'. The import fails due to this. I'm not sure why it's working for you in this case. Maybe something cached.
Either way, I could add the fix to my branch if you want?

@andrewebdev that's very interesting. Not sure how it's working for me either :)

@andrewebdev glad you figured it out. You can also bring up questions to me directly in Slack if you are having issues with the app.

@andrewebdev feel free to fix bugs when you come across them in your branch.

@jupiter007 not sure why it's working for you because I just found the issue ;)
The import is for typeaheadWithOther- With an uppercase 'W', but the filename is with a lowercase 'w'. The import fails due to this. I'm not sure why it's working for you in this case. Maybe something cached.
Either way, I could add the fix to my branch if you want?

Hi @andrewebdev I did some reading, and it could be that it was working for me because my file system on the mac is case insensitive.


Ensure stdio handles are never null when converting to HandleRef

This fixes this test case, which means env_logger will no longer panic on stable. I'm not totally happy with this change because it's a workaround rather than a real fix. But I think something like this is the best the can be done without changing the API or how people use it.

Could you comment on how this fits into the big picture? The linked testcase is now fixed with a patch that is now in Rust nightly, and we expect to backport it to beta and possibly stable. Are you expecting to revert this patch when that fix reaches Rust stable, or are you expecting to keep it?
The issues around NULL and INVALID_HANDLE_VALUE in the Windows API are confusing as it is, and I'm a little nervous about this patch silently translating from NULL to INVALID_HANDLE_VALUE, introducing another potential moving part into that system.

Sure. As I said in the OP I'm unhappy with this PR so I'll start by explaining why before explaining my reasoning for doing it. This is likely not anything new to you but I want to be clear to everyone.
A File is a "reference to an open file on the filesystem" and from_raw_handle states its contract is that "they are the sole owner of the file descriptor they are wrapping". winapi-util breaks this by directly converting a raw stdio handle value into a &File without checks. The I/O unsafety is somewhat mitigated by not dropping the resulting File but it's still not particularly good. A panic in this situation is arguably a good thing.
Ultimately the fix for this is to make a breaking change to the API of winapi-util so that it can return an error at some point. Maybe it should use DuplicateHandle to create an owned handle? This would also ensure the handle is valid. Whatever the case, if this PR is merged I do not intend it to outlive any future API changes.
So given all that, why did I submit this PR? Because this appears to be affecting numerous applications right now. And this comment indicated that the upstream patch may not be backported to stable. I'd also note that neither this PR nor the upstream patch prevents the I/O unsafety in this specific case, it just removes the panic.
The point about translating null to INVALID_HANDLE_VALUE is a good one. I chose that value because:

It's already a value people should expect for stdio.
Rust itself currently does something very similar when spawning processes (see here and here).

Brainstorming a little here: if it makes sense for winapi-util to translate NULL to INVALID_HANDLE_VALUE here, would it make sense to go even further and make io::Stdout::as_raw_handle etc. translate NULL into INVALID_HANDLE_VALUE? That way, it'd help other libraries besides winapi-util here. And, as you note, it is what Rust already does when spawning processes. And that also might allow us to go back to using NonNull inside OwnedHandle and BorrowedHandle, and eliminate HandleOrNull in favor of Option<OwnedHandle> again.
A downside might be backwards compatibility. Any code expecting to be able to detect "windows" mode or detached consoles by checking for NULL would no longer be able to distinguish that case.

A File is a "reference to an open file on the filesystem" and from_raw_handle states its contract is that "they are the sole owner of the file descriptor they are wrapping". winapi-util breaks this by directly converting a raw stdio handle value into a &File without checks. The I/O unsafety is somewhat mitigated by not dropping the resulting File but it's still not particularly good. A panic in this situation is arguably a good thing.

It's my impression that this kind of "temporary File" idiom isn't specific to winapi-util. As such, I'm expecting we'll revise the contract for from_raw_handle to make this idiom valid. It'll still be unsafe, and require the programmer take responsibility for not closing the handle twice, but there would be a way to do it. I'm curious what you think about this approach.

if it makes sense for winapi-util to translate NULL to INVALID_HANDLE_VALUE here, would it make sense to go even further and make io::Stdout::as_raw_handle etc. translate NULL into INVALID_HANDLE_VALUE

Perhaps! To be honest though I'm not totally on board with Rust's process spawning behaviour either. I do think it should pass on NULL values because that can have a different meaning to INVALID_HANDLE_VALUE (the first is presumably intentional whereas the latter is likely the result of an error somewhere). Admittedly, I'm not sure if the difference matters too much to the subprocess. Another gotcha (which has be brought up a few times before) is that INVALID_HANDLE_VALUE just so happens to share a value with the current process pseudo handle. In the context of stdio it should be obvious what was meant but when used from a generic as_raw_handle method I could see how it might potentially be misused.
Hm, I think in general a generic as_raw_handle is a bit of a footgun because it's so reliant on context for meaning. Maybe fn try_as_io_handle() -> io::Result<IoHandle> might be better for general purpose use? That makes it clear that, if successful, you've actually got a file-like handle and not some pseudo handle or null result.

It's my impression that this kind of "temporary File" idiom isn't specific to winapi-util. As such, I'm expecting we'll revise the contract for from_raw_handle to make this idiom valid.

I would be on board with that in principle. And, yeah, I suspect it's a common enough pattern. Of course there might be something I'm not thinking of here so I don't want to say "yes definitely" until I'm more certain there are no hidden gotchas.
As mentioned, a safer way to share handles is using DuplicateHandle. The kernel does reference counting for file objects so it should be safe to create duplicate Files this way. Admittedly this is slightly more heavy weight then just copying a handle around but I could imagine a safe clone_file_handle would be useful.

So to avoid going too far off the topic of winapi-util, I imagine the lowest level of the API might look something like this:
pub trait AsIoHandle {
    /// Returns a raw handle to an I/O object such as a [`File`] or pipe.
    ///
    /// For types like `File` that are always valid file-like objects, this
    /// is simply a wrapper for [`AsRawHandle`]. However stdio types (such as
    /// [`io::Stdout`]) may fail if there is no handle or the handle is invalid.
    /// Most commonly this will occur when an application is using the Windows
    /// GUI subsystem.
    fn as_io_handle(&self) -> io::Result<RawHandle>;
}

impl AsIoHandle for io::Stdout {
    fn as_io_handle(&self) -> io::Result<RawHandle> {
        validate_raw_handle(self.as_stdio_handle())
    }
}

fn validate_stdio_handle(handle: RawHandle) -> io::Result<RawHandle> {
    // Handle values with the high bit set (i.e. `< 0`) are pseudo handles.
    // These are magic values whose meaning is highly context dependent; each
    // function may interpret them differently or not at all. It doesn't make
    // sense to own, borrow or use these handles in a generic I/O context.
    if (handle as isize) < 0 {
        Err(io::Error::new(io::ErrorKind::Other, "the handle is invalid"))
    } else {
        Ok(handle)
    }
}

Where AsIoHandle can be implemented for File, the stdio types and the pipe types used with Command. Other types could build on this.

@ChrisDenton The original bug here was fixed on Rust stable in Rust 1.57, so I believe we can close this issue now.
And the discussion of NULL handles moved here https://github.com/rust-lang/rust/issues/90964, which led to https://github.com/rust-lang/rust/pull/93263.


xml:lang is not supported

What happened?

lib
pic

svg

ink1.1dev

resvg

rsvg

Inkscape 1.1dev supports it inkscape 0.92 not

What should have happened?

should render german or englisch not both

Copyright
source https://commons.wikimedia.org/wiki/File:Organon-Modell.svg
author
SVG: User:Quiethoo PNG: User:Hermy, User:Rorkhete
Original: Karl Bühler (†1963)
license https://creativecommons.org/licenses/by-sa/4.0/deed.de
Version and Operating System:

Inkscape Version: 0.92.4 or 1.1dev
resvg version: 0.9.0
rsvg Version: 2.40.21
Operating System: Ubuntu 18.04

Yes, it's not.

should render german or english not both

Isn't this behavior specific to switch + systemLanguage?  I don't see anything similar in the docs for xml:lang

I think we can close this ticket (as invalid)?

The image is still broken in resvg, so we still have to investigate the cause.


Update workflow to use opensearch and opensearchdashboard artifacts 1.2.0

Description
Update workflow to use opensearch and opensearchdashboard artifacts version 1.2.0
Issues Resolved
#55
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Small tip: Under "Issues Resolved", instead of #55, you can use resolves #55 to automatically resolve the issue mentioned.

Got it, add it now


fixed typos

Fixed typos

Nice work. I'm going to close this PR so other's can complete the assignment.


Show Asset Status in Table

[ ] add outcome labels for disputed, reported, and resolved

I don't think we're going ahead with this design, have you seen this issue? https://github.com/zeitgeistpm/ui/issues/960


Multiple calendars with overlapping events not displaying correctly

Thank you for wanting to take the time to report a problem. In order to increase the chances of the issue being
resolved,
please take a moment to give as much relevant information as possible.
Context:

Browser 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36'

Browser-version

Schedule-X version  "@schedule-x/vue": "^1.14.0"

Describe the bug
When multiple calendars are displayed at the same time, events overlap do not display correctly.
Specifically if multiple events from calendar A overlap one long event on calendar B, and event B is in the events array first, events of calendar A increase the margin left for each overlapping event.

If long event B is added in the events array last, events of calendar A are all aligned to the left but the layering of events is messed up

To Reproduce
Steps to reproduce the behavior:
const createEvents = () => {
  const events = []
  for (let i = 0; i < 6; i++) {
    events.push({
      id: i,
      title: `Available Slot ${i + 1}`,
      calendarId: 'appointments',
      start: moment().hour(9).minute(0).add(i * 70, 'minutes').format('YYYY-MM-DD HH:mm'),
      end: moment().hour(9).minute(0).add(i * 70 + 60, 'minutes').format('YYYY-MM-DD HH:mm'),
    })
  }
  events.push({
    id: 8989,
    title: 'Working Hours',
    calendarId: 'workschedule',
    start: moment().hour(9).minute(0).format('YYYY-MM-DD HH:mm'),
    end: moment().hour(14).minute(0).format('YYYY-MM-DD HH:mm'),
  })
  return events
}

const calendar = createCalendar({
  selectedDate: moment().format('YYYY-MM-DD'),
  views: [viewDay, viewWeek, viewMonthGrid, viewMonthAgenda],
  defaultView: sessionModel.user?.app_preferences?.counselling?.default_calendar_view || viewDay.name,
  locale: 'en-AU',
  isDark: false,
  dayBoundaries: {
    start: '00:00',
    end: '00:00'
  },
  callbacks: {
    onEventClick(event) {
      alert('Event clicked: ' + event.title)

    },
  },
  calendars: {
    'workschedule': {
      colorName: 'workschedule',
      lightColors: {
        main: '#f9d71c',
        container: 'transparent',
        onContainer: '#594800',
      },
      darkColors: {
        main: '#fff5c0',
        onContainer: '#fff5de',
        container: '#a29742',
      }
    },
    appointments: {
      colorName: 'appointments',
      lightColors: {
        main: '#f91c45',
        container: 'aliceblue',
        onContainer: '#59000d',
      },
      darkColors: {
        main: '#ffc0cc',
        onContainer: '#ffdee6',
        container: '#a24258',
      },
    }
  },
  events: [
    ...createEvents()
  ],
})

Expected behavior
Overlapping events should use horizontal space and layering so that the user can clearly see the various calendars.
Screenshots
Apple Calendar behaviour in the same scenario. Only the first overlapping event is shifted to the right so that the long event header is visible

That's nasty one. Thanks for reporting it

Thanks for the quick action.
On a side note, probably the "working hours" use case is highlighting a missing feature that is present, for instance on vue-cal (https://antoniandre.github.io/vue-cal/#ex--special-hours)
Special hours aren't events as such but reference areas in the timeline that are shown in the background.
Just saying.

Fixed this in @schedule-x/calendar v.1.21.0. Will be available for the Vue component in a bit too :)


Update of native libraries

Hi! Soon i will try to update native libraries, cuz they both have new versions. And will send PR @baronha

Any news? I cannot even get it working on Android react-native 0.69


Rollout #24a0ab6eed0afb5204423cae009f30417ca6ba5d

canary - Pending (run after)
uswest - Pending (run after canary)
useast - Pending (run after canary)


Pause camera

Hi ,
Could pass a example to pause camera????

Hello, @giorgiootto.
I guess, you just need to follow instructions https://github.com/ekreutz/react-native-barcode-scanner-google#utility-functions-resumescanner-and-pausescanner-function
Just include pauseScanner() functions from 'react-native-barcode-scanner-google' module and use it in your component method.

Thanks.