granite: 5.1.0 -> 5.2.0

Motivation for this change
An update.
Release Notes
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build regextester notejot taxi hashit spice-up bookworm tootle transporter aesop deepin-wm vocal quilter nasc sequeler

Failure on x86_64-linux (full log)
Attempted: regextester, notejot, taxi, hashit, spice-up, bookworm, tootle, transporter, aesop, vocal, quilter, nasc, sequeler
The following builds were skipped because they don't evaluate on x86_64-linux: deepin-wm
Partial log (click to expand)
glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/9ic95iyg07maq0naw1dlf20fy1bpcqiz-vocal-2.2.0/bin/com.github.needle-and-thread.vocal
shrinking RPATHs of ELF executables and libraries in /nix/store/9ic95iyg07maq0naw1dlf20fy1bpcqiz-vocal-2.2.0
shrinking /nix/store/9ic95iyg07maq0naw1dlf20fy1bpcqiz-vocal-2.2.0/bin/.com.github.needle-and-thread.vocal-wrapped
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9ic95iyg07maq0naw1dlf20fy1bpcqiz-vocal-2.2.0/bin
patching script interpreter paths in /nix/store/9ic95iyg07maq0naw1dlf20fy1bpcqiz-vocal-2.2.0
checking for references to /build in /nix/store/9ic95iyg07maq0naw1dlf20fy1bpcqiz-vocal-2.2.0...
error: build of '/nix/store/l510iwrli60lkj3zcdznp8i2g9709h2v-Transporter-1.3.3.drv' failed

@GrahamcOfBorg build deepin.deepin-wm

Success on x86_64-linux (full log)
Attempted: deepin.deepin-wm
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7v0cwqhahz3kxrrizv62lwngbscq0hgl-deepin-wm-1.9.32
shrinking /nix/store/7v0cwqhahz3kxrrizv62lwngbscq0hgl-deepin-wm-1.9.32/bin/deepin-wm
shrinking /nix/store/7v0cwqhahz3kxrrizv62lwngbscq0hgl-deepin-wm-1.9.32/lib/libdeepin-wm.so.0.0.0
shrinking /nix/store/7v0cwqhahz3kxrrizv62lwngbscq0hgl-deepin-wm-1.9.32/lib/deepin-wm/plugins/libgala-zoom.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7v0cwqhahz3kxrrizv62lwngbscq0hgl-deepin-wm-1.9.32/lib  /nix/store/7v0cwqhahz3kxrrizv62lwngbscq0hgl-deepin-wm-1.9.32/bin
patching script interpreter paths in /nix/store/7v0cwqhahz3kxrrizv62lwngbscq0hgl-deepin-wm-1.9.32
checking for references to /build in /nix/store/7v0cwqhahz3kxrrizv62lwngbscq0hgl-deepin-wm-1.9.32...
/nix/store/7v0cwqhahz3kxrrizv62lwngbscq0hgl-deepin-wm-1.9.32

We can ignore the transporter build failure due to magic-wormhole not building. autobahn needs a newer txaio. They've been updated in staging - https://github.com/NixOS/nixpkgs/pull/48626#issuecomment-433706880

Timed out, unknown build status on aarch64-linux (full log)
Attempted: regextester, notejot, taxi, hashit, spice-up, bookworm, tootle, transporter, aesop, vocal, quilter, nasc, sequeler
The following builds were skipped because they don't evaluate on aarch64-linux: deepin-wm
Partial log (click to expand)
cannot build derivation '/nix/store/kbkry5pblf2vy47g20xqr9m8l0kwlyxb-sequeler-0.6.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sq03rcgxas4gwwqif6915jsgf9ryvq5b-spice-up-1.3.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mkvvv2jp5hgxcl6lh52q46c0nnbygzs2-taxi-0.0.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6ryh4r8nk4a4jwrwbb8c8wimkqhpi1pr-tootle-0.1.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/rd9bjkjd51ffn5kbpdi09i9h93y23d0b-Transporter-1.3.3.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/9ayx7qr2d5k816pmh1kx6gkhr8hfsli3-webkitgtk-2.20.5.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/f38p2g6la7gg8gwyd0c4nspjkvvsi3ha-bookworm-1.0.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/zc9zccvfl9v3m3pfi5k4l00619k03j8k-quilter-1.6.3.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/hvp8mw4yasp58vpvrbgziznyr9qpjrzs-vocal-2.2.0.drv': 2 dependencies couldn't be built
error: build of '/nix/store/0y0iii8a2b29clknbvg01z4a1d9ixd5w-notejot-1.4.5.drv', '/nix/store/6ryh4r8nk4a4jwrwbb8c8wimkqhpi1pr-tootle-0.1.5.drv', '/nix/store/abk1xja6hhcxsiajlfxl2529086lyn1z-nasc-0.4.7.drv', '/nix/store/bjbxvy97vm3c9mjydla2cpc8mxkn1l0d-regextester-0.1.7.drv', '/nix/store/f38p2g6la7gg8gwyd0c4nspjkvvsi3ha-bookworm-1.0.0.drv', '/nix/store/hvp8mw4yasp58vpvrbgziznyr9qpjrzs-vocal-2.2.0.drv', '/nix/store/kbkry5pblf2vy47g20xqr9m8l0kwlyxb-sequeler-0.6.3.drv', '/nix/store/kpdw7r7424668f32rgpz3imqw89d6sqf-hashit-0.2.0.drv', '/nix/store/mkvvv2jp5hgxcl6lh52q46c0nnbygzs2-taxi-0.0.1.drv', '/nix/store/rd9bjkjd51ffn5kbpdi09i9h93y23d0b-Transporter-1.3.3.drv', '/nix/store/sq03rcgxas4gwwqif6915jsgf9ryvq5b-spice-up-1.3.2.drv', '/nix/store/zc9zccvfl9v3m3pfi5k4l00619k03j8k-quilter-1.6.3.drv', '/nix/store/zr0nxm3a4ga7wpdm27k00qc5waxi5axw-aesop-1.0.5.drv' failed

@jtojnar There's https://github.com/NixOS/nixpkgs/pull/49560 too :wink:

Success on aarch64-linux (full log)
Attempted: deepin.deepin-wm
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8pgnwb62893vfg96cmypkrmrnd9rq49j-deepin-wm-1.9.32
shrinking /nix/store/8pgnwb62893vfg96cmypkrmrnd9rq49j-deepin-wm-1.9.32/bin/deepin-wm
shrinking /nix/store/8pgnwb62893vfg96cmypkrmrnd9rq49j-deepin-wm-1.9.32/lib/deepin-wm/plugins/libgala-zoom.so
shrinking /nix/store/8pgnwb62893vfg96cmypkrmrnd9rq49j-deepin-wm-1.9.32/lib/libdeepin-wm.so.0.0.0
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8pgnwb62893vfg96cmypkrmrnd9rq49j-deepin-wm-1.9.32/lib  /nix/store/8pgnwb62893vfg96cmypkrmrnd9rq49j-deepin-wm-1.9.32/bin
patching script interpreter paths in /nix/store/8pgnwb62893vfg96cmypkrmrnd9rq49j-deepin-wm-1.9.32
checking for references to /build in /nix/store/8pgnwb62893vfg96cmypkrmrnd9rq49j-deepin-wm-1.9.32...
/nix/store/8pgnwb62893vfg96cmypkrmrnd9rq49j-deepin-wm-1.9.32


Lexer fixes

Fix toml lexer
Fixes for rust lexer
Tool for comparison against rustc lexer

Just wow!
I am a bit worried that lexer comparison is not made during the tests.
Executing rustc_lexer for the whole CTRS is impractical (there is no cargo on CI, and it may be quite long, given O(N^2) edit distance calculation).
What is possible is to take several complex Rust files, put them in testData/lexer/rustc directory along with json generated by rustc_lexer and move some part of LexerDiff to a test. A README explaining how to generate more tests will also be helpful.
@winger what do you think?
Hm, another idea: what about pushing rustc_lexer to crates.io as a binary, useful for any Rust IDE, and keeping only reference json files in tree?

@winger we'd love to cargo install rustc_lexer :)
Thanks for the PR!
:+1:


Game Client Layout setting not remembered between different profiles

Type
Incorrect behavior
Operating System
Windows
OS Version
Windows 10
Bug description
Game Client Layout setting not remembered between different profiles.
Playing on my main Runelite profile through the Jagex Launcher. I recently started an alt while using a secondary profile in Runelite without the Jagex Launcher.
When changing my Game Client Layout in Display Settings between Fixed (Classic) and Resizable (Classic) the change transfers to other profiles. This doesn't happen for the control settings.
All plugin settings differences act as they should. The only setting I know of is Game Client Layout.
Using this feature to setup a profile -> https://github.com/runelite/runelite/wiki/General-Features#playing-with-multiple-accounts
Each of my accounts have separate emails and runelite accounts.
The "Target" field for my shortcut is "S:\Users\MYNAME\AppData\Local\RuneLite\RuneLite.exe --clientargs "--config=settings2.properties --sessionfile=session2"
The directory of my original client and the shortcut is "S:\Users\MYNAME\AppData\Local\RuneLite"
Screenshots or videos
No response
RuneLite version
Runelite Version: 1.8.29
Oldschool revision: Rev 207
Launcher Version: 2.2.0
Logs
No response

The game client layout, along with all other Jagex settings, have nothing to do with RuneLite or its settings, as it is a feature of the vanilla game.


Monitoring : Pipeline metrics are not generated.

Problem
Metrics for the pipeline "measurement":"events" are missing. (tremor version: 0.9.3)
My Yaml file has onramp and offramp. I have a trickle file for pipeline.
In the metrics, I am able to see {"measurement":"ramp_events"}  ==> This ones specified in the yaml file.
However, the metric for the pipeline is missing ==> The ones specified in a Trickle file.
simple.trickle
#!config metrics_interval_s = 5
select event from in into out;

main.yaml
binding:
  - id: example                                     # The unique name of this binding template
    links:
      '/onramp/metronome/{instance}/out':            # Connect the inpunt to the pipeline
       - '/pipeline/simple/{instance}/in'
      '/pipeline/simple/{instance}/out':           # Connect the pipeline to the output
       - '/offramp/stdout-output/{instance}/in'
      '/pipeline/system::metrics/system/out':
       - '/offramp/stdout-output/{instance}/in'

onramp:
  - id: metronome
    metrics_interval_s: 5
    type: metronome
    config:
      interval: 1000

mapping:
  /binding/example/passthrough:
    instance: "passthrough"

offramp:
  - id: stdout-output
    type: stdout

Log
Dec 10 18:36:36 MyHost tremor[3234]: tremor version: 0.9.3
Dec 10 18:36:36 MyHost tremor[3234]: tremor instance: tremor
Dec 10 18:36:36 MyHost tremor[3234]: rd_kafka version: 0x000000ff, 1.5.0
Dec 10 18:36:36 MyHost tremor[3234]: allocator: snmalloc
Dec 10 18:36:36 MyHost tremor[3234]: Listening at: http://<IP_ADDRESS>:9898
Dec 10 18:36:37 MyHost tremor[3234]: {"measurement":"ramp_events","tags":{"ramp":"tremor://localhost/onramp/metronome/passthrough/out","port":"in"},"fields":{"count":0},"timestamp":1607643397487725499}
Dec 10 18:36:37 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643397487722637,"id":0}
Dec 10 18:36:37 MyHost tremor[3234]: {"measurement":"ramp_events","tags":{"ramp":"tremor://localhost/onramp/metronome/passthrough/out","port":"out"},"fields":{"count":0},"timestamp":1607643397487725499}
Dec 10 18:36:37 MyHost tremor[3234]: {"measurement":"ramp_events","tags":{"ramp":"tremor://localhost/onramp/metronome/passthrough/out","port":"error"},"fields":{"count":0},"timestamp":1607643397487725499}
Dec 10 18:36:38 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643398487936747,"id":1}
Dec 10 18:36:39 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643399488079566,"id":2}
Dec 10 18:36:40 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643400488220781,"id":3}
Dec 10 18:36:41 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643401488329222,"id":4}
Dec 10 18:36:42 MyHost tremor[3234]: {"measurement":"ramp_events","tags":{"ramp":"tremor://localhost/onramp/metronome/passthrough/out","port":"in"},"fields":{"count":0},"timestamp":1607643402488608149}
Dec 10 18:36:42 MyHost tremor[3234]: {"measurement":"ramp_events","tags":{"ramp":"tremor://localhost/onramp/metronome/passthrough/out","port":"out"},"fields":{"count":5},"timestamp":1607643402488608149}
Dec 10 18:36:42 MyHost tremor[3234]: {"measurement":"ramp_events","tags":{"ramp":"tremor://localhost/onramp/metronome/passthrough/out","port":"error"},"fields":{"count":0},"timestamp":1607643402488608149}
Dec 10 18:36:42 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643402488604743,"id":5}
Dec 10 18:36:43 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643403488775734,"id":6}
Dec 10 18:36:44 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643404488910850,"id":7}
Dec 10 18:36:45 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643405489120321,"id":8}
Dec 10 18:36:46 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643406489357015,"id":9}
Dec 10 18:36:47 MyHost tremor[3234]: {"measurement":"ramp_events","tags":{"ramp":"tremor://localhost/onramp/metronome/passthrough/out","port":"in"},"fields":{"count":0},"timestamp":1607643407489620944}
Dec 10 18:36:47 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643407489617233,"id":10}
Dec 10 18:36:47 MyHost tremor[3234]: {"measurement":"ramp_events","tags":{"ramp":"tremor://localhost/onramp/metronome/passthrough/out","port":"out"},"fields":{"count":10},"timestamp":1607643407489620944}
Dec 10 18:36:47 MyHost tremor[3234]: {"measurement":"ramp_events","tags":{"ramp":"tremor://localhost/onramp/metronome/passthrough/out","port":"error"},"fields":{"count":0},"timestamp":1607643407489620944}
Dec 10 18:36:48 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643408489830014,"id":11}
Dec 10 18:36:49 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643409490063369,"id":12}
Dec 10 18:36:50 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643410490285042,"id":13}
Dec 10 18:36:51 MyHost tremor[3234]: {"onramp":"metronome","ingest_ns":1607643411490503464,"id":14}

Possible Solution(s)

Adding more detail to the issue here: for the simple.trickle case above, the in/out nodes of the pipeline actually don't exist since it's a passthrough pipeline so not seeing the pipeline metrics there is expected. There was a similar ask in https://github.com/tremor-rs/tremor-runtime/issues/211 -- we can document this behavior as part of the monitoring docs so that it does not trip up our users.
However, the issue is real: even for non-passthrough pipelines, we don't see the metrics. An example pipeline that will reproduce it:
define script process
script
  event
end;

create script process;

select event from in into process;
select event from process into out;

It will be fixed as part of https://github.com/tremor-rs/tremor-runtime/pull/648. Thanks @nagaprabhu for bringing this to our attention!


Update Docs for new Builds of MDT/ADK/OS Versions etc

Please update the Docs for the new Builds and Versions

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cffaa4a7-f102-e9a1-bf37-ba43d4d12225
Version Independent ID: 14bb9ea7-e9bf-c8b6-92b7-bc4b9502eab9
Content: What’s new in MDT 2013 Guide - Microsoft Deployment Toolkit
Content Source: sccm/mdt/whats-new-in-mdt.md
Service: unspecified
Product: configuration-manager
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

Thanks @excelsi84, I'm already working with the feature team on some initial updated content for MDT.

I worked with the feature PM to make a few revisions to the MDT content. We decided to remove the "what's new" article altogether, and focus the updated content in the Release Notes. I also tweaked the MDT landing page, most notably adding a link to the download. I'm closing this issue.


Redux store to save input from input type literal

Currently, input are stored in the global redux store and are displayed when entered in the input:

Clicking the ❌  currently does not do anything, but working on #245

added a commit that removes default value from value constraint in order to get redux working
closes #243
closes #233

Let me know if you would like me to break this into separate PR's
but here is a break down of the commits:
Commit 1: Installing redux and react-redux
Commit 2: Implement Redux actions, reducers and store.
Commit 3: Adding items to the Global redux store
Commit 4:  Reformat location of actions, reducers into folders (more conventional)
Commit 5: Remove Default Literal Value #243
Commit 6: Update inputLiteral component tests to use redux
Commit 7: Update ESLINT  See https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-unsupported-features/es-syntax.md
Commit 8: Fix Resourcetemplateform test to use new Connect(InputLiteral)
Commit 9: Reducers Test
Commit 10: Action Test

Coverage decreased (-0.5%) to 83.777% when pulling c3c7c14ef1f2090ec43b10607218b0937d81330a on literal-redux into 7d1160c6a865542019cbc0ced6ea0eae44db7a66 on master.

LGTM except for minor request. I think @ndushay and @jgreben should review, just to see how we're using Redux.


Apparently duplicate documentation search results are in other languages

Search for something at https://jest-bot.github.io/jest/ and notice the apparently duplicate results. There's no way to tell that they're actually translations, or what language they're translated in. Which one do I click if I want English? (Not that English is my native language, but I believe that translating software library documentation is misguided, so I always use English.)

@dandv please use https://jestjs.io/.
@rickhanlonii do you know what the jest-bot site is? Can we remove it? It's super dated (see e.g https://jest-bot.github.io/jest/blog/)

No idea

jest-bot is what ranked higher in Google search results.

@JoelMarcey do you know if we can make it redirect?

@SimenB to clarify - you mean make https://jest-bot.github.io/ redirect to https://jestjs.io/ ?

Or remove it - is it possible to either delete the fork?


Feature - [Linux] Webview support

This adds webview support for Linux. Nothing more than filling up the gaps in the webview API for this platform.

Will open a single PR for all this Webview work.


Grid is changing defined layout width and hight

Hi,
I have some issue which I need assistance with.
I have an empty layout and I want to add a component to the grid. I do it as follows:
        currentLayout.lg.push({
            i: widgetCount.toString(),
            h: 2,
            w: 4,
            x: 0,
            y: 0
        });

        currentLayout.md.push({
            i: widgetCount.toString(),
            h: 2,
            w: 4,
            x: 0,
            y: 0
        });

        currentLayout.sm.push({
            i: widgetCount.toString(),
            h: 2,
            w: 2,
            x: 0,
            y: 0
        });

after the grid is rerendered the onLayoutChange callback is immediately called with:
layout: {
         lg: {
            i: "id",
            h: 1,
            w: 1,
            x: 0,
            y: 0
        }
    }

Why does that happen. If I resize my window and get to the md or sm breakpoint the component has correct size. Only for lg i have a problem.

Any update on this?

@stewartduffy do you have the same problem?

Can you check the status of this in 0.13.7?

yepp, this seems to work now :)

Experiencing this exact issue with GridLayout using the newest version


V1.32.43

Added a note to the source code.
Added CONFIG_*_DISABLE to allow overriding compilation settings from the CLI or Makefile.
Added CONFIG_SYS_SW0_ALT_14P option to change the position of SW0 and nRST when DTR is not used.
Similarly, HAL_BAREMETAL_20P changes the pin position when RS232C is not used. Originally intended for FTDI series compatibility, it is not needed if used only as a pure programmer.
Remove pending timeout on EP_CDI in VCP-RxD as it is highly unlikely to be executed. If the transfer is not complete at that time, the accumulated character buffer will be discarded.

Currently SW0 generates edge interrupts directly, but using the unused CCL might eliminate the chattering noise. It's worth a try, so I'll play around with this branch for a while.

SW0 is split into two interrupts using CCL, one for falling edge and one for rising edge. Each is a small, fast routine that just sets a flag. The falling edge is filtered by CCL to remove chatter noise.
Improved unlocking of LOCKed devices and USERROW writes. A global timeout could cause subsequent UPDI-ACC state machines to enter the wrong state, especially in an interrupted status check loop.


keep track of which recordings were processed how

Is your feature request related to a problem? Please describe.
Datasets can be incremental -- for instance, for longitudinal datasets, and it would make sense that recordings get processed at different time points. We already provide code to "--skip-existing" (files that are in raw & have already been processed) and to select "--recordings" (which allows eg re-processing of audio that was faulty or addition of other files. Processing files is accompanied by the creation of a time-stamped yaml file, and addition of rows to a recordings.csv file, which can be improved.
Describe the solution you'd like

recordings.csv should include, for each row, which yaml was used
in the case of --skip-existing, we don't want to change recordings.csv, but when using the --recordings switch, we may want to remove rows corresponding to recordings that are being reprocessed?
this one is tricky: it looks like we changed something about the variables that are stored in that file, because the cells don't match up here (other yaml dated 20210717):

converted_filename,original_filename,success,error
...
child40/child40_6.wav,child40/child40_6.wav,True,
,child9/REC001.WAV ,False,b'./recordings/raw/child9/REC001.WAV : No such file or directory\n'

Is your feature request related to a problem? Please describe.
Datasets can be incremental -- for instance, for longitudinal datasets, and it would make sense that recordings get processed at different time points. We already provide code to "--skip-existing" (files that are in raw & have already been processed) and to select "--recordings" (which allows eg re-processing of audio that was faulty or addition of other files. Processing files is accompanied by the creation of a time-stamped yaml file, and addition of rows to a recordings.csv file, which can be improved.
Describe the solution you'd like

recordings.csv should include, for each row, which yaml was used
in the case of --skip-existing, we don't want to change recordings.csv, but when using the --recordings switch, we may want to remove rows corresponding to recordings that are being reprocessed?
this one is tricky: it looks like we changed something about the variables that are stored in that file, because the cells don't match up here (other yaml dated 20210717):

converted_filename,original_filename,success,error
...
child40/child40_6.wav,child40/child40_6.wav,True,
,child9/REC001.WAV ,False,b'./recordings/raw/child9/REC001.WAV : No such file or directory\n'

Good idea, will do!
This is supposed to be the case (if a file is re-processed, this should update the entry in recordings.csv)
This example seems normal to me: converted_filename is empty, because the conversion failed. The reason is that the file does not exist. The extra space character at the end of child9/REC001.WAV  seems suspicious. Does it also appear in the metadata?

This is supposed to be the case (if a file is re-processed, this should update the entry in recordings.csv)

confirmed, this is what happens!
it occurred to me, however, that perhaps if a file is reprocessed, and the reprocessing leads to an error, whereas the original was NOT an error, we may be want to be nice with the human, and (a) avoid deleting the audio file as well as (b) avoid deleting the row but still (c) let them know something went wrong? I'm not totally sure about this -- it may create more problems than it solves.
the space issue... good point! YES that's it, the metadata/recordings.csv has a space -- which is a human error, so nothing to worry about on your end.

https://github.com/LAAC-LSCP/ChildProject/commit/996dd19fed0c116dba322635f049f68aadf120fb

This is supposed to be the case (if a file is re-processed, this should update the entry in recordings.csv)

confirmed, this is what happens!
it occurred to me, however, that perhaps if a file is reprocessed, and the reprocessing leads to an error, whereas the original was NOT an error, we may be want to be nice with the human, and (a) avoid deleting the audio file as well as (b) avoid deleting the row but still (c) let them know something went wrong? I'm not totally sure about this -- it may create more problems than it solves.
the space issue... good point! YES that's it, the metadata/recordings.csv has a space -- which is a human error, so nothing to worry about on your end.

I think an error should not overwrite anything but instead display meaningful error messages. The commit I just posted should do that.


Add Numbers by Omocat

Song Name
Numbers
Artist Name
Omocat
Source
Youtube
Youtube Link
_6wjMiCVVn9If0oB
Direct File Link
No response
Song ID
15
Start Offset [ms]
No response
Extra
Created from Auto Nong.
Created for level: 95568679

reject
invalid YouTube link


fix(navbar): hamburger menu in mobile view had wrong border radius (8px)

changed it to 0px, it has to explicitly say 0px otherwise inherits 8px border radius from Button component

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Gabor Halasz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

:tada: This PR is included in version 4.43.16 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


No longer working

I last successfully used the downloader on the 12 & 13th September. Since then, I am afraid I can't pin down the date exactly, the downloader is failing to function. It doesn't even fill in the automatically generated filename based on the Patreon creator and the image set name.
This is really frustrating for me as I have recently signed up to a new creator and have masses of image setd to download.
I am using Chrome (Version 117.0.5938.132) on my MacBook Pro (2019) running MacOS Ventura (13.5.2)

Double check that you've got v1.1.2 installed - Patreon and Chrome changed the way they work enough to break the previous version.
If you're on v1.1.2 then ping me on discord (server link in the readme) and we can dig into it further.


Test group ldap

The ldap spec for miq_group spanned multiple lines so it wasn't testing what we thought it was.

moved into a single line and changed the expectation to reflect reality (first commit)
removed duplication

/cc @gmcculloug do we care that this is raising a different expectation than expected?

@abellotti @gtanzillo Please review

:+1: LGTM


file_get_contents(/var/task/vendor/spatie/browsershot/bin/browser.js): Failed to open stream: No such file or directory

I just upgraded to the latest version and get this error when deploying on Vapor
Hook: sidecar:deploy --activate
[Sidecar] Deploying App\Sidecar\Functions\BrowsershotFunction to Lambda as `SC-Project-production-browsershot`.
          ↳ Environment: production
          ↳ Architecture: x86_64
          ↳ Package Type: Zip
          ↳ Runtime: nodejs14.x
          ↳ Function already exists, potentially updating code and configuration.

In BrowsershotFunction.php line 45:

  file_get_contents(/var/task/vendor/spatie/browsershot/bin/browser.js): Failed to open stream: No such file or directory

@phuclh both browsershot and sidecar-browsershot are on the latest version? Or can you provide the exact version numbers?
In #78 we've updated the package, as browser.js was renamed in the Spatie package in https://github.com/spatie/browsershot/pull/740.

I already found out the issue, you replied so fast, haha.
For some reason my composer locked the package at the old version, I just fixed it and it's working now. Again, thank you for the quick response.


Regex pattern for props that include ClassName

Hi, I was wondering on a regex patter that works for props, variables etc that include className. An example of this would be how react-skeleton-loader users a containerClassName prop.

Can you check if this works for you?
  "tailwindCSS.experimental.classRegex": [
    "[a-zA-Z]*(?:c|C)lass(?:n|N)ame(?:)?=\\s*(?:\"|'|{`)([^(?:\"|'|`})]*)",
  ]

Hey, this doesn't seem to work for me

How about this
  "tailwindCSS.experimental.classRegex": [
    "[a-zA-Z]*(?:c|C)lass(?:n|N)ame(?:)?={?(?:\"|'|`)([^(?:\"|'|`})]*)}?"
  ]

This seems to be working now, thank you very much for this

Can we add this regex in the repo ? It is very useful ❤

Can we add this regex in the repo ? It is very useful ❤

I'll work on adding it!


Fix Sonatype Lift scans

In reviewing the scans we have on Sonatype Lift  ( see https://lift.sonatype.com/odpi ) (on a per PR basis) I noticed the following:

Tools are no longer able to analyze

[loading ZipFileIndexFileObject[/usr/lib/jvm/java-8-openjdk-amd64/lib/ct.sym(META-INF/sym/rt.jar/java/lang/Object.class)]]
[loading ZipFileIndexFileObject[/usr/lib/jvm/java-8-openjdk-amd64/lib/ct.sym(META-INF/sym/rt.jar/java/lang/Comparable.class)]]
[loading ZipFileIndexFileObject[/tmp/analyzing-c707a7793ce47c1e/open-metadata-test/open-metadata-fvt/open-types-fvt/open-types-test-generator/target/open-types-test-generator-3.3-SNAPSHOT.jar(org/odpi/openmetadata/fvt/opentypes/common/Reference.class)]]
/tmp/analyzing-c707a7793ce47c1e/open-metadata-test/open-metadata-fvt/open-types-fvt/open-types-test/src/main/java/org/odpi/openmetadata/fvt/opentypes/references/VirtualConnectionToConnection/EmbeddedConnectionsReference.java:45: error: cannot access Reference
public class EmbeddedConnectionsReference extends Reference implements Serializable {
                                                  ^
  bad class file: /tmp/analyzing-c707a7793ce47c1e/open-metadata-test/open-metadata-fvt/open-types-fvt/open-types-test-generator/target/open-types-test-generator-3.3-SNAPSHOT.jar(org/odpi/openmetadata/fvt/opentypes/common/Reference.class)
    class file has wrong version 55.0, should be 52.0
    Please remove or make sure it appears in the correct subdirectory of the classpath.
[loading ZipFileIndexFileObject[/usr/lib/jvm/java-8-openjdk-amd64/lib/ct.sym(META-INF/sym/rt.jar/java/lang/annotation/Target.class)]]
[loading ZipFileIndexFileObject[/usr/lib/jvm/java-8-openjdk-amd64/lib/ct.sym(META-INF/sym/rt.jar/java/lang/annotation/ElementType.class)]]
[loading ZipFileIndexFileObject[/usr/lib/jvm/java-8-openjdk-amd64/lib/ct.sym(META-INF/sym/rt.jar/java/lang/annotation/Retention.class)]]
[loading ZipFileIndexFileObject[/usr/lib/jvm/java-8-openjdk-amd64/lib/ct.sym(META-INF/sym/rt.jar/java/lang/annotation/RetentionPolicy.class)]]
[loading ZipFileIndexFileObject[/root/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.13.0/jackson-annotations-2.13.0.jar(com/fasterxml/jackson/annotation/JsonInclude$Include.class)]]
[loading ZipFileIndexFileObject[/root/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.13.0/jackson-databind-2.13.0.jar(com/fasterxml/jackson/databind/annotation/JsonSerialize$Typing.class)]]
[loading ZipFileIndexFileObject[/root/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.13.0/jackson-databind-2.13.0.jar(com/fasterxml/jackson/databind/annotation/JsonSerialize$Inclusion.class)]]
*** Infer needs a working compilation command to run.

This needs to be forced to java 11 to work
Also the dependency analyzer is failing:

Running V1 API (bulk) tools
Running Open Source Vulnerabilities
Sanitizing repository
Analysis failed in 8 seconds

and

Running V4 API tools
Running Bill Of Materials
Sanitizing repository
Analysis failed in 2 seconds

Investigating and will create custom config to try and resolve

Note that similar issues (slf4J & java11) affect the egeria-data-connectors repo, so changes are being made there also

cc: @lpalashevski

See https://community.sonatype.com/t/pull-request-annotations/7856/2

sonatype build is failing with gradle
remains very slow

Will apply further updates as/when recommended

Lift is regularly failing on egeria. The build appears too complex to be reliable. Closing this issue and will persue as part of our overall security reviews


Fix: Update node modules

Package versions were updated, so node modules need updating. Tested this works in a fork

Sorry, had to include a fix for the test as well https://github.com/efcloud/gh-actions-kind-env/pull/1/files#diff-9ccfc6831832281d3954ef7726f4e6f48623922b4054660913b9970a47774558L12-R12, this test is triggered as a github actions workflow on push


Programs with list of alternatives do not appear

version: 1.0.3 Beta
Linux Mint 20 Ulyana
In my Favourites bouquet I have mixed "normal" channels and several channels with a list of alternatives. These channels with alternatives do not appear in DemonEditor and additionally the numbering for these channels is not considered, so that the numbers of the "normal" channels are incorrect.
Here is my (shortened) "userbouquet.favourites.tv":
#NAME Favoriten
#SERVICE 1:64:1:0:0:0:0:0:0:0::Hauptprogramme
#DESCRIPTION Hauptprogramme
#SERVICE 1:134:1:0:0:0:0:0:0:0:FROM BOUQUET "alternatives.das_erste_hd.tv" ORDER BY bouquet
#SERVICE 1:134:1:0:0:0:0:0:0:0:FROM BOUQUET "alternatives.zdf_hd.tv" ORDER BY bouquet
#SERVICE 1:64:2:0:0:0:0:0:0:0::Dritte
#DESCRIPTION Dritte
#SERVICE 1:134:1:0:0:0:0:0:0:0:FROM BOUQUET "alternatives.swr_bw_hd.tv" ORDER BY bouquet
#SERVICE 1:134:1:0:0:0:0:0:0:0:FROM BOUQUET "alternatives.rbb_berlin_hd.tv" ORDER BY bouquet
#SERVICE 1:64:3:0:0:0:0:0:0:0::Spartenprogramme
#DESCRIPTION Spartenprogramme
#SERVICE 1:134:1:0:0:0:0:0:0:0:FROM BOUQUET "alternatives.kika_hd.tv" ORDER BY bouquet
#SERVICE 1:64:4:0:0:0:0:0:0:0::Privatsender
#DESCRIPTION Privatsender
#SERVICE 1:0:1:445C:453:1:C00000:0:0:0:
#SERVICE 1:0:1:4460:453:1:C00000:0:0:0:
Here is one of the alternative channel lists ("alternatives.das_erste_hd.tv")
#NAME Das Erste HD
#SERVICE 1:0:19:283D:3FB:1:C00000:0:0:0:
#SERVICE 1:0:1:6DCA:44D:1:C00000:0:0:0:
#SERVICE 1:0:1F:301:3003:2114:EEEE0000:0:0:0:
In DemonEditor it appears like this:
Num Service                     Model           Pos.
Hauptprogramme     MARKER
Dritte                        MARKER
Spartenprogramme MARKER
Privatsender            MARKER
1       SAT.1                       TV               19.2
2       SAT.1 Gold              TV                19.2
etc.
And this is what it should be:
Num Service                 Model          Pos.
Hauptprogramme      MARKER
1   Das Erste HD           TV              19.2
2   ZDF                          TV              19.2
Dritte                         MARKER
3   SWR BW HD           TV               19.2
4   RBB Berlin HD        TV                19.2
Spartenprogramme  MARKER
5   KIKA HD                  TV               19.2
Privatsender        MARKER
6   SAT.1                       TV              19.2
7   SAT.1 Gold               TV             19.2
etc.
Did I miss a setting or is handling of alternative channel lists not implemented(yet)?

Hi,

handling of alternative channel lists not implemented(yet)?

Yes you are right! At the moment, only alternative names of services in the bouquet lists have been implemented!
You are the first who asked about such an feature. I'm not even sure if this option works on my image. :)
But if you really need this feature, then I can implement it. I just need a complete set of your working settings and a desire to test!
Best

Hi,

handling of alternative channel lists not implemented(yet)?

Yes you are right! At the moment, only alternative names of services in the bouquet lists have been implemented!
You are the first who asked about such an feature. I'm not even sure if this option works on my image. :)
But if you really need this feature, then I can implement it. I just need a complete set of your working settings and a desire to test!
Best

Hmmm. You are right, maybe this feature is actually not needed anymore. I had been using this method on my older receiver, which only had 2 tuners. Now with unicable and FBC (8 virtual tuners), I do not really need this any more and I will remove it :-)
But since Dreamboxedit has this feature, you may want to implement it anyway. So if I can help, let me know what data you need. I am also willing to do some testing :-)

Hmmm. You are right, maybe this feature is actually not needed anymore. I had been using this method on my older receiver, which only had 2 tuners. Now with unicable and FBC (8 virtual tuners), I do not really need this any more and I will remove it :-)
But since Dreamboxedit has this feature, you may want to implement it anyway. So if I can help, let me know what data you need. I am also willing to do some testing :-)

I also have 2x DVB-S2 + DVB-T2/C. :)
As for the function, I'll try to implement it all the same. Please send me your full set of the settings(with lamedb and all bouquet files) for a sample on email from my profile. Thank you!
Best

I also have 2x DVB-S2 + DVB-T2/C. :)
As for the function, I'll try to implement it all the same. Please send me your full set of the settings(with lamedb and all bouquet files) for a sample on email from my profile. Thank you!
Best


GH-763: Add DlqPartitionFunction

Resolves https://github.com/spring-cloud/spring-cloud-stream-binder-kafka/issues/763
Allow users to select the DLQ partition based on

consumer group
consumer record (which includes the original topic/partition)
exception

LGTM - Merged upstream.


[WIP] Rustfmt

This is not designed to be merged as-is but is here for discussion over whether this is a good idea/what options should be used. This covers most of @msiglreith's concerns on #1427 apart from the fact that the whitespace in the Backend trait gets removed. I've made comments on the few config options that it might make sense to tweak.

Sounds like my concerns are addressed for the most part :+1:

bors retry


Extension crashing

Hello. My lambda is deployed with the datadog lambda extension.
My lambda intermittently crashes here and there and I believe its because of the extension crashing.
The logs are available here:

Hi, which version of the extension are you running?
Would it be possible to share full debug log by setting the DD_LOG_LEVEL environment variable to DEBUG


Implement crawl for COGs

It's like a bar crawl, but better

Not doing this after all -- it's boring and there are plenty of STAC browsers already. Value here is elsewhere.


make lib as objects

I did this merge request by mistake from local forked repository, do not wont bother anybody. close


Feature Request: Episode Based view and combined view

Be cool if instead of whole seasons it could just show the most current episodes. Or even just the most current combined library content. I like the idea of almost replicating the plex home screen on a tab in home assistant like this where it can then control a player device on the network. Then I'd just have to find a way to sneak in some basic player controls for play/pause and next, I'd have the perfect tab for friday night!

Is this similar to https://github.com/JurajNyiri/PlexMeetsHomeAssistant/issues/10 ? How is it different?

It is a bit similar, on Deck is probably the most important feature, that also has to tie in with a specific user, idk if plex tokens are user based or just plex account based. But it's a little different because what I was asking was for:

Where it shows you individual episodes, as they come out, where currently all I could get out of plexmeetshome was to show me the newest "shows" added, not episodes. So just to clue into my behavior, I use on deck, or recently added tv (which shows episodes) to click on the next thing to watch. I don't typically browse to a show and then to an episode. The combined view I was asking for is not something that exists anywhere (as far as I know) where both new movies and new episodes are all on 1 feed. as far as I know plex doesn't have a native way to combine libraries like that. But since i'm a user who typically is looking for "something new to watch" my focus is sort content by date, nevermind what library it's apart of.
Hope that makes sense. for what it's worth I think "On Deck" should be higher priority, but considering that's a "per user" based info it might be more difficult to implement then just showing "newest episodes" vs "newest shows"

On Deck and Recently Added are now available in the newest version.
libraryName: Deck
libraryName: Recently Added
I will leave this open for combined view.


Queries with CTEs (WITH clause) that have column aliases cause syntax error

The following query is valid in Postgres
WITH random_nums(n) AS (
  SELECT random()
  FROM generate_series(1, 10)
),
nums_sum AS (
  SELECT sum(n)
  FROM random_nums
)
SELECT * FROM nums_sum;

+-------------------+
| sum               |
|-------------------|
| 5.382207567694241 |
+-------------------+

However, when I try to parse and deparse this query...
import { parse, deparse } from "pgsql-parser"

const query = `
WITH random_nums(n) AS (
  SELECT random()
  FROM generate_series(1, 10)
),
nums_sum AS (
  SELECT sum(n)
  FROM random_nums
)
SELECT * FROM nums_sum;
`

const parsed = parse(query)
console.log(deparse(parsed))

WITH random_nums ([ 'n' ]) AS (SELECT random() FROM generate_series(1, 10)), nums_sum AS (SELECT sum(n) FROM random_nums) SELECT * FROM nums_sum;

It changes the query to become invalid. Trying to run this deparsed query now gives the following error message from Postgres 14.3:
docker run --name cte-deparse-error -p 5432:5432 -e POSTGRES_PASSWORD=secret -d postgres:14.3
docker exec -it cte-deparse-error psql -h localhost -d postgres -U postgres -c "WITH random_nums ([ 'n' ]) AS (SELECT random() FROM generate_series(1, 10)), nums_sum AS (SELECT sum(n) FROM random_nums) SELECT * FROM nums_sum;"

ERROR:  syntax error at or near "["
LINE 1: WITH random_nums ([ 'n' ]) AS (SELECT random() FROM generate...

The square brackets are extraneous.

Working on a PR

I made some progress in #80 , but there is more to do before the whole test file upstream/with.sql will pass...

#84 is the new candidate to close this.

Hi @pyramation sorry to pester. Can we get these changes publish to NPM?

@acarl005 sorry I forgot! Thanks for the reminder :)
Successfully published:
 -<EMAIL_ADDRESS> -<EMAIL_ADDRESS> -<EMAIL_ADDRESS>


Tests: moved tests from testTsv.fs to unit tests

Reorganized tests from testTsv.fs file as unit tests in Fsdk.Tests project.

@webwarrior-ws good work; I might leave this open for a bit until I double-check if other tests need to be moved or not.
In the meantime, if you finish the NOnion&geewallet PRs to adopt Fsdk's FSharpUtil, next thing to do would be to create a PR in this fsx repo to remove all Async.RunSynchronously calls from Fsdk (the consequence of this is that some functions will start returning Async<Foo> instead of Foo, and the side-effect is that you might need to change some scripts that make use of this functions to call Async.RunSynchronously in them.
Thanks

@webwarrior-ws let's move the AsyncCancellation tests from geewallet to this PR too please. I think I created them when I was working on some AsyncExtensions functions, so they should belong here.

New changes since you last viewed
Merge branch 'nblockchain:master' into move-tsv-test

What is this? Please don't push merge commits to PRs.

What is this? Please don't push merge commits to PRs.

Rebasing PRs needs to be done with git rebase or git cherry-pick, not git merge.

Rebasing PRs needs to be done with git rebase or git cherry-pick, not git merge.

On top of that, I never asked you to rebase this PR, so please don't rebase when it's not necessary.

Reverted that merge. I think merge occurred because I clicked "sync fork" on github.


Gap character parameter

Instead of the NoGap bool, it would be more useful to have a gap character property. By default, it would be a space but could be an empty string or a colon or whatever separator is needed.

Hey @cdhunt!  Do you have an example/scenario for the gap character need?

Terraform uses =. The 1password op cli also uses = for a particular flavor of argument. I'm pretty sure I've seen a : used, but I don't remember what binary that was.

We agree that it should be configurable and are considering this for preview 3.

We agree that it should be configurable and are considering this for preview 3.

@cdhunt I think this is possible today by simply having the original parameter include the gap character. So you can define the originalparameter as foo= or bar: and set nogap. Is this sufficient?

@cdhunt I think this is possible today by simply having the original parameter include the gap character. So you can define the originalparameter as foo= or bar: and set nogap. Is this sufficient?

That works.

That works.

thanks @cdhunt


Adding integration tests

Run with npm run integration
Code coverage disabled for now so tests work on Windows

@Elesant please look

LGTM!


Rnpm : new ReactSnackbarPackage(this)

The command rnpm link for the package adds the line new ReactSnackbarPackage() but it doesn't compile.
I have to manually change the line to new ReactSnackbarPackage(this) everytime so it can compile.

Feel free to submit a pull-request!

I've been looking for a solution and I couldn't find any.
I think only you can fix it. It has to do with your rnpm configuration itself.

Fixed in master, release 0.1.0


Cannot install SonoffLAN

Hi,
I'm hoping to install SonoffLAN so I can compare my Tasmota flashed Sonoff switches with my unflashed. However, I cannot get it to install and don't know if I'm doing something wrong or if it is my particular setup.
I'm running on an Intel NUC.
Home Assistant 0.115.3 (from Configuration/Info)
Home Assistant version: 3.5.0
Operating system: Ubuntu 20.04.1 LTS
Docker version: 19.03.13
When I add the repository in HACS it doesn't look like it installs properly because I get the screen shown below with a couple of "unknowns".
I've also tried to install it manually by placing the files from the zip into:
/home/user/docker/hassio/homeassistant/custom_components/sonoff
No matter what I try I don't see SonoffLAN or any of my unflashed modules showing up anywhere. Does anyone have some kind advice? Thanks!

You install hassio add-on, not HACS custom content.

Like this in my installation:

Sorry Alex, I must be thick. I'm following the section in the README.md titled Install with HACS.
I more correctly should have said I'm adding the repository in the Add-on store (not HACS).
In Home Assistant I'm going to Supervisor / Add-on store. Then I click on the three vertical dots and then Repositories. There in Manage add-on repositories I click on Add repository. I enter https://github.com/AlexxIT/SonoffLAN then ADD. That screen will not take AlexxIT/SonoffLAN because it throws an error "expected a URL @ data['addons_repositories'][2]. Got 'AlexxIT/SonoffLAN'".
But I've also tried the "manually copy sonoff folder from latest release to custom_components folder in your config folder" method (as below) and get nothing that way either.
Appreciate your help and comments already!

@AndyZaa having the same trouble. From what I can tell you need to install HACS into your Home Assistant installation, then you can install this add on via HACS.

Yep, that's what I have been trying to do. I installed HACS quite a while ago, and now I've just been trying to add SonoffLAN through the Add a custom repository feature. I haven't been able to figure out what version of HACS I have, or if HACS updates itself. But the rest of HACS works fine.

Turned out that my HACS installation must have been outdated - I reinstalled HACS and then was able to install SonoffLAN.


Backward Sync should remember recent finalized blocks.

When syncing using BWS we now consider finalized blocks reported by consensus layer.
When no finalized block is specified, nothing strange will go on. When finalized block is specified
But Besu is not aware of any finalized block yet, we will sync as usual until the finalized block is about to get imported.
A new invariant is introduced when importing blocks using BWS.
All imported blocks have to descent from latest finalized block or a TTD block if we did not finalize yet.

Importing a finalized block updates the information in Besu Mutable Blockchain.
It is no longer possible to import blocks into the blockchain below a previously finalized block when using BWS
When a new finalized block gets announced while BWS is in progress and Besu already has it imported the Mutable Blockchain gets updated, and the chain gets checked for possible pruning
When trying to import blocks of equal height as newly announced finalized block, then only the new announced finalized block will be possible to import using BWS
When importing a new block using BWS after finalized, we can now guarantee that the block descends from latest finalized block

Signed-off-by: Jiri Peinlich<EMAIL_ADDRESS>

Changelog

[ ] I thought about the changelog and included a changelog update if required.

Please add a CHANGELOG entry for this.


Unable to connect-pnponline using kudu or azure webjobs

I am unable to connect pnponline in azure environment.
I installed modules folder and referenced it using import statement but still getting error
The Win32 internal error "The handle is invalid" 0x6
PS C:\home\Modules> occurred while setting character attributes for the console output buffer.
Contact Microsoft Customer Support Services.

As this is related on the PnP PowerShell and not on SharePoint dev topics directly, please open the issue at following location so that the right team can provide assistance for your question. Thx - https://github.com/pnp/powershell


ObligationScope should use references in Rails 4 when it uses includes.

Before Rails 4, includes would also outer join tables if query conditions referenced those tables.  Rails 4 has dropped this behavior in favor of making the developer explicitly identify includes that must also be joined with an additional references() method on the scope.  @zeiv modified tests to use references(), but it seems better to me to incorporate this directly into the scope() method of ObligationScope.  This PR reverts the Rails 4-specific tests and instead sets references in Rails >= 4.

This is great and useful!

+1   Trying to upgrade from rails 3 and running into this all over the place

To elaborate further - The tables to include in the references depends completely upon the rules set.   One role may need to reference one table, and another role may need to reference another.   The knowledge of this should be handled within declarative_authorization, not in the calling code...

I believe this will fix my rails 4.1 problems.  Thanks @aepstein


Use userActions when widget is added from data view

We were not using userActions within data-view panel and if you create a new map with one layer, and try to add a widget from that panel, map instantiation fails due to node is not saved before saving the widget.
CR: @viddo
cc @saleiva @nobuti

👍

Tests failing already fixed in local, urgent, merging.


Issues with upcoming 1.18 (extended build height)

If an area is saved in a world running 21w39a or up, the area won't render properly in the viewer. The biome will show up as either unknown or ocean, and the blocks will show up as minecraft:air. This is best illustrated if the player loads in far away from world spawn:

This might have to do with the new negative y coordinates.

Mojang did change the storage format again . . .

Now Biomes are not stored anymore per Chunk, put per Section. They also have a Palette that has to be decoded.
BlockState is still stored in the same manner as before (with Palette), but the NBT keys have changed name and structure.

@AndrewIsOffline did you check, that the version number you provided is exactly the very first snapshot showing this behavior?

The change notes for 21w39a indicate the modified Biomes, so it should be ok for the moment.

Some intermediate status:

I'm able to render latest snapshot again, will publish the changes soon
more Biome data (now per Section) and more Sections will lead to about double of memory usage, so we will only be able to show half sized maps compared to now

Everything is working for 1.18, the release is out and finally also Minecraft released 1.18 today.
@BlaCoiso: As I did extended build height implementation twice during the this year, the second time I prepared everything to render arbitrary world height. So in principle it will work with your strange dimensions. The only step missing is to detect the availability of custom dimensions.
Could you please provide some test worlds with your custom dimensions?

I do not have the time to prepare these custom worlds.
But I need them to figure out how to detect a custom dimension and how to detect build height for that dimension.

I've found an issue with the search for block feature where it ignores blocks at Y=0; about the custom dimensions, I'll look at the current format for specifying them and try to generate them again, I'll send the new world with those dimensions once I have them ready

continue in #269


Upgrade to 19.11

I think patch 11 is available for some time now, let's see if it works!
Checklist

[X] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[X] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.

For the record, ./update_amber --check-updates --verbose=4 prints out the changelog associated with each update. The 19.10 -> 19.11 changelog is:

update.11 (modifies sander, rism3d.snglpnt, nab)
Released on December 17, 2019 (written by Tyler Luchko)
Description:
Add a cluster size check for cluster-particle interaction in RISM treecode
Additional changes include

Modifying cluster size check for TCF
Adding more robust check for TCF and DCF treecode asymptotics
modified syntax for passing writeVolume subroutine
workarounds for PGI compiler
fix for corner case in determining the k-space cutoff


Reenable test_move_new when the repo is public

Currently the test fails as it can't fetch the dependency
--- TRY 1 STDERR:        iota::cli_tests test_move_new ---
FETCHING GIT DEPENDENCY https://github.com/iotaledger/iota.git
Error: Failed to build Move modules: Failed to resolve dependencies for package 'test_move_new'

not worth it to do something with SSH now if it will be public soon

Closed by https://github.com/iotaledger/iota/pull/4108


DSL: Add error message to service rpc notation

My proposal is - change signature of service functions like that or make mix
service MyLogic {
   rpc CalculateBill(stream Bill) returns (Calc,MyError)
}

message Bill {
  int64 id = 1;
  int64 price = 2;
  int64 date = 3;
}

message Calc {
  int64 sum = 1;
}

enum SpecError {
    NULL = 0;
    MINUS = 1;
    SO_MUCH = 2;
}
message MyError {
  int64 SpecCode = 1;
  int64 WhenID = 2;
}

Of course we can write some common response message, but it is not usability for all cases. And look like frame in frame...
Maybe do you have better proposal or solve?

If you want the "error" cases to look like failures, you can have the server respond with a non-OK status. The status codes are detailed in this file. It looks like you would want to use INVALID_ARGUMENT in this case. You can provide extra details in the status string, and if that's insufficient, you can also send custom trailing metadata with additional error information.

Closing this because the solution was provided and no further questions are added for 9 months.


Add multi-cluster label to github labels

Signed-off-by: abhiraut<EMAIL_ADDRESS>

/skip-all

Codecov Report

Merging #2820 (38efcaa) into main (1399ddf) will decrease coverage by 18.14%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2820       +/-   ##
===========================================
- Coverage   59.23%   41.08%   -18.15%
===========================================
  Files         284      157      -127
  Lines       23549    19558     -3991
===========================================
- Hits        13949     8036     -5913
- Misses       8117    10758     +2641
+ Partials     1483      764      -719

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
41.08% <ø> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


feat(snippets): add Always show forward button

@theRealPadster Is the image correct here?

@theRealPadster Is the image correct here?

The path looks fine, or do you mean does it match the rest visually?

@theRealPadster Is the image correct here?

The path looks fine, or do you mean does it match the rest visually?

Yes

Feel free to change ofc! :) Just went with a quick screenie

Yeah it would be better if there was a bit of whitespace around it, so that it shows up centred in the snippet preview instead of being stretched to fill it end-to-end.
e.g. It would be good if it was kinda like how this one does it

Feel free to change ofc! :) Just went with a quick screenie

I added some whitespace around it. Not sure how to replace the file in a PR.


Add "Show" (in Explorer) button to project explorer

I don't get the use case. Being able to do that once you're in the editor makes sense, but in the project list I don't get it.

The use case is having several projects you cannot differentiate by name alone (like version v1, v2, v3, v4 of the same project); you need to look inside them (and the asset files) to differentiate which one you want to open.

Well, no. They'll have different paths. So you just have to look at their path.

Yes, but for me project names are often not that explanatory, in the worst case something like "TestProjectA", "TestProjectXYZ", ... I need to see what's inside to know which project I'm actually dealing with.

Well at a given point you have to help yourself for that... I think the project manager has already too much buttons and we sould avoid adding more for a really corner case situation. But I wouldn't be against it if we moved that to a dropdown menu or something like that.
But anyway, IMHO the project manager UI definitely needs a rework to be more user friendly.

I agree on that. It's a bit confusing.

I think "Show" is a bit confusing, since you had to mention in this PR that it's "(in Explorer)", but this info is missing from the project manager. As is, I'd expect it to give me a preview of the project somehow in Godot.
If the intent is to disambiguate, I think the path shown below the name handles most of it already - if you created your projects with both confusing names and confusing paths on the filesystem, you're not helping yourself :P
Eventually, there could be a RMB menu with a "Show in Filesystem" option.
But yeah we really need to rethink the whole project manager, currently it's quite limited and limiting.

Based on the comments above, changed to an unnamed filesystem button with a redesign of button locations:

Changed again to a minimal file explorer button in front of the path:

The button appears in front of the path for selected item only. Clicking on it will "open in explorer".
No other changes.

Thanks a lot, merged manually as 1d2d08da5 to fix the merge conflict.


sbt -mem 1024 on the v1.8.222 tag mentions java 9?

build manual states java 1.8+, but here an error is reported related to java 9?
[warn] There may be incompatibilities among your library dependencies; run 'evicted' to see detailed eviction warnings.
[info] Compiling 21 Scala sources to /home/software/marathon2/type-generator/target/scala-2.12/sbt-1.0/classes ...
[error] -release is only supported on Java 9 and higher
[warn] /home/software/marathon2/type-generator/src/main/scala/mesosphere/raml/backend/liquid/Filters.scala:14:26: non-variable type argument String in type pattern Iterable[String] is unchecked since it is eliminated by erasure
[warn]       case it: java.lang.Iterable[String] => it.asScala.map(.toUpperCase).asJava
[warn]                          ^
[warn] /home/software/marathon2/type-generator/src/main/scala/mesosphere/raml/backend/liquid/Filters.scala:25:26: non-variable type argument String in type pattern Iterable[String] is unchecked since it is eliminated by erasure
[warn]       case it: java.lang.Iterable[String] => it.asScala.map(.toLowerCase).asJava
[warn]                          ^
[warn] two warnings found
...
...
[info] Compiling 611 Scala sources and 9 Java sources to /home/software/marathon2/target/scala-2.12/classes ...
[warn] /home/software/marathon2/src/main/scala/mesosphere/marathon/MarathonSchedulerActor.scala:408:12: a pure expression does nothing in statement posit
ion; multiline expressions might require enclosing parentheses
[warn]       await(Future.sequence(changeGoalsFuture))
[warn]            ^
[warn] /home/software/marathon2/src/main/scala/mesosphere/marathon/MarathonSchedulerActor.scala:409:12: a pure expression does nothing in statement posit
ion; multiline expressions might require enclosing parentheses
[warn]       await(instancesAreTerminal)
[warn]            ^
[warn] /home/software/marathon2/src/main/scala/mesosphere/marathon/api/v2/AppTasksResource.scala:49:11: [AssigningOptionToNull] You probably meant None,
not null.
[warn]     async {
[warn]           ^
[warn] /home/software/marathon2/src/main/scala/mesosphere/marathon/api/v2/LeaderResource.scala:65:14: a pure expression does nothing in statement positio
n; multiline expressions might require enclosing parentheses
[warn]         await(runtimeConfigRepo.store(RuntimeConfiguration(backup, restore)))
[warn]              ^
[warn] /home/software/marathon2/src/main/scala/mesosphere/marathon/api/v2/PodsResource.scala:89:20: local val identity in method apply is never used
[warn]       implicit val identity = await(authenticatedAsync(req))
[warn]                    ^
[warn] /home/software/marathon2/src/main/scala/mesosphere/marathon/core/health/impl/HealthCheckWorker.scala:33:18: local val system in method run is neve
r used
[warn]     implicit val system = mat.system
[warn]                  ^
[warn] /home/software/marathon2/src/main/scala/mesosphere/marathon/core/health/impl/HealthCheckWorker.scala:112:25: parameter value mat in method tcp is never used
[warn]     port: Int)(implicit mat: ActorMaterializer): Future[HealthResult] = {
[warn]                         ^
[warn] /home/software/marathon2/src/main/scala/mesosphere/marathon/core/task/tracker/impl/InstanceTrackerActor.scala:172:24: This catches all Throwables. If this is really intended, use case ex : Throwable to clear this warning.
[warn]         } catch { case ex => InstanceUpdateEffect.Failure(ex) }
[warn]                        ^
[warn] /home/software/marathon2/src/main/scala/mesosphere/marathon/raml/CheckConversion.scala:116:70: [PassPartialFunctionDirectly] You can pass the partial function in directly. (Remove check => check match {).
[warn]   implicit val checkRamlWriter: Writes[CoreCheck, AppCheck] = Writes { check =>
[warn]                                                                      ^
[warn] /home/software/marathon2/src/main/scala/mesosphere/marathon/raml/VolumeConversion.scala:144:95: [UseOptionFlatMapNotPatMatch] ... match { Some(x) => definedType match {
[warn]   case PersistentVolumeType.Root => scala.Some.applymesosphere.marathon.state.DiskType.Root.type
[warn]   case PersistentVolumeType.Mount => scala.Some.applymesosphere.marathon.state.DiskType.Mount.type
[warn]   case PersistentVolumeType.Path => scala.Some.applymesosphere.marathon.state.DiskType.Path.type
[warn] }; None => None} can be replaced with .flatMap(definedType match {
[warn]   case PersistentVolumeType.Root => scala.Some.applymesosphere.marathon.state.DiskType.Root.type
[warn]   case PersistentVolumeType.Mount => scala.Some.applymesosphere.marathon.state.DiskType.Mount.type

Most of the logs you've posted ware warnings. What's the error message at the end of sbt clean compile?


Create flexible VMSS fail, expected string or bytes-like object

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug

az vmss create -g vmssflex -n vmss --orchestration-mode flexible --image ubuntults --instance-count 2

I get
cli.azure.cli.core.azclierror: expected string or bytes-like object
az_command_data_logger: expected string or bytes-like object

Don't understand the error. Can you have a look? Thanks!
To Reproduce

az vmss create -g vmssflex -n vmss --orchestration-mode flexible --image ubuntults --instance-count 2

Expected behavior

Environment summary

Additional context

Thank you for reporting this issue. We will take a look. Please expect some delay due to the holiday season.

The error disappears after a reboot👍

@qwordy OK, if this issue can be reproduced in the feature, please send me the debug log


Final Copy (language)

Replace placeholder text with actual content.

Wikipedia Playlist Builder
Put together a thematic set of Wikipedia pages. Share it. Knowledge is joy!


Fix typo

What I did

Fixed the extra ‘for’

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks!


DefinitionManager code cleanup

eliminate QVariant -> QString conversions (not breaking change, compatible with existing data)
do not create unnecessary QDir and QFile objects to perform one operation

don't have Windows, so tested on Linux - just replaced human-readable comma separated list with some binary data (serialized list of ints - @Variant(\0\0\0\x7f\0\0\0\vQList<int>\0)). in such case just an empty list is returned (and some warning is produced in terminal). so, at least this doesn't cause the crash and there is the way to detect such case - empty list is returned (this can be considered as "missing key")


[DISCUSS] Declaring event handlers globally or per policy

Failsafe currently allows most event handlers to be declared globally. Ex:
RetryPolicy retryPolicy = new RetryPolicy();
CircuitBreaker circuitBreaker = new CircuitBreaker();
Failsafe
  .with(retryPolicy)
  .with(circuitBreaker)
  .onRetry(f -> refreshContext())
  .get(this::connect);

Rather than per policy:
RetryPolicy retryPolicy = new RetryPolicy()
  .onRetry(f -> refreshContext());
CircuitBreaker circuitBreaker = new CircuitBreaker();
Failsafe
  .with(retryPolicy)
  .with(circuitBreaker)
  .get(this::connect);

One obvious problem with the current approach is that some events don't apply to all policies (ex: onRetry does nothing for a CircuitBreaker). So why the current approach? It was mostly based on the idea that policy configuration (RetryPolicy) should be separate from execution logic (Failsafe...) which presumably includes event handling. A common RetryPolicy might be reused for lots of different types of executions, but the thinking was that if you start to embed event handling logic into it then maybe it wouldn't be.
Option 1
The first option is to leave things as they are based on the idea that separating event handling from policy config is a good thing and that it will give us some policy reuse.
Option 2
Another option is to move the policy specific event handling to the policies. So the retry related event handling would be moved to RetryPolicy. This would leave just the completion related events at the global level. Ex:
RetryPolicy retryPolicy = new RetryPolicy()
  .onRetry(f -> refreshContext());
CircuitBreaker circuitBreaker = new CircuitBreaker();
Failsafe
  .with(retryPolicy)
  .with(circuitBreaker)
  .onSuccess(cxn -> log.info("Connected to {}", cxn))
  .get(this::connect);

Option 3
Another option is to move all event handling to the policy level, including (some) completion events:
RetryPolicy retryPolicy = new RetryPolicy()
  .onRetry(f -> refreshContext())
  .onSuccess(cxn -> log.info("Connected to {}", cxn))
CircuitBreaker circuitBreaker = new CircuitBreaker()
  .onFailure(f ->log.warn("The CircuitBreaker logged a failure"))

Failsafe
  .with(retryPolicy)
  .with(circuitBreaker)
  .get(this::connect);

In practice, each policy makes its own decision about whether an execution was a success or failure, and different Exceptions/results may be failures for different policies (ex: a CircuitBreaker might handle TimeoutExceptions whereas a RetryPolicy might handle ConnectExceptions). In that sense, having a global onSuccess event handler might not make sense, since it can only be called if all of the policies were successful and loses some detail.
That said, the onComplete event handler may still need to be global, since it provides a completion callback for async executions, similar to CompletableFuture.whenComplete, and while success/failure is a policy-specific decision, completion is a global event.
Thoughts?

Shamelessly tagging a few people who dropped by previously. Please weigh in on this topic if interested :)
/cc @ben-manes @Tembrel @malpi @axelfontaine @whiskeysierra @chhsiao90

Option 1 would require to redesign the current approach of circuit breaker callbacks which are bound to a circuit breaker, rather than per execution. Right?
Option 2 and 3 require that those policies are either created whenever Failsafe is invoked (non-shared) and once when a shared policy is created. Creating them whenever needed kind of defeats the idea of having something that I can easily pass like a RetryPolicy object. Having a singleton policy that I can share including event handlers defeats the purpose of having event dedicated handlers per execution.
Someone who wants a) a policy given/shared and b) it's own event handlers won't work with option 2/3.
I'd propose the following:

Make policies immutable (not sure if/how that would work with CircuitBreaker), so they can be shared freely without the risk of someone modifying it afterwards
Extend the scope of policies from basic parameters (max number of retries, delays, jitter, etc.) to include default event handlers/callbacks.
Allow users to either override or add event handlers on each execution/invocation.

Option 1 would require to redesign the current approach of circuit breaker callbacks which are bound to a circuit breaker, rather than per execution. Right?

Option 1 would just be to leave things as they are today.

Having a singleton policy that I can share including event handlers defeats the purpose of having event dedicated handlers per execution.

Do you think something like onRetry should not be shared?

Option 1 would just be to leave things as they are today.

But today the location of event handlers is already inconsistent. Retry event handlers are per execution, circuit breaker callbacks are per circuit breaker.

Do you think something like onRetry should not be shared?

I could imagine use cases for both. Counting retries across the board for metrics and monitoring would be a common use case that would be easier with a shared event handler on a per-policy basis. On the other hand, one might want to log or persist the retry counter for one particular execution but not for all of them, something that would be done way easier within a per-execution event handler.

@whiskeysierra How about the onSuccess and onFailure events? Success/failure is really specific to a policy and doesn't make as much sense globally since one policy might succeed and one might fail.

Thinking more about this... current thinking is for Failsafe 2.0, it would make sense to move basically all event handling out of the Failsafe... flow and into separate policies. My thinking is:

onComplete is not necessary for sync
onComplete for async could be accomplished by returning something like a CompletableFuture
onSuccess/onFailure are more closely aligned with Policies, where the notion of success/failure are defined, rather than globally.
onRetry/onFailedAttempt/etc are specific to RetryPolicy

Thoughts? /cc @Tembrel (since I see you're active atm :) )

From my experience it totally makes sense to have globally assigned listeners and maybe even provide some default ones. For example we use by default LoggingListener in each of our projects which do write logs for onFailure and the other cases. Some of them are written in debug only (for example onSuccess, some of them in warn or info for example onFailure.
Having this assignment on each usage of Failsafe creates boilerplate. Additionally for policies, we mostly re-use the RetryPolicy per project but have to assign it each time as well. Having means to assign certain policies and listeners globally would make life easier.
Also it would make life for maintainers of extensions easier, for example there could be provided a library for metrics exposure of Failsafe by using Micrometer.
Last but not least, I'd like to thank you for your work, but it would be great if you could share your ideas and thoughts for the project in a structured way so that others can contribute. I would be more than happy to support the project by contributing to it. Currently it's rather hard as it's not visible to me what your plans and thoughts are.

From my experience it totally makes sense to have globally assigned listeners and maybe even provide some default ones. For example we use by default LoggingListener in each of our projects which do write logs for onFailure and the other cases. Some of them are written in debug only (for example onSuccess, some of them in warn or info for example onFailure

Could you, alternatively, use a base RetryPolicy that has your default logging for onSuccess and onFailure? Or are you logging those things for CircuitBreaker executions as well?
Related to this, do you have any thoughts on how onSuccess or onFailure should react if multiple policies are specified and one succeeds while the other fails? We can either base a global event handler off the last policy to be executed, or we could only consider it a success if all policies were successful.

Having means to assign certain policies and listeners globally would make life easier.

Indeed - I'd like to make it more clear in the API that Failsafe instances can be saved and re-used for multiple executions (see "Saving Failsafe Instances" in #160). I'm not sure if this is what you were thinking?

Also it would make life for maintainers of extensions easier, for example there could be provided a library for metrics exposure of Failsafe by using Micrometer.

Any thoughts on specific metrics or events we'd like to collect metrics for? Metrics has come up in #140, but feel free to open a dedicated issue for this.

Last but not least, I'd like to thank you for your work, but it would be great if you could share your ideas and thoughts for the project in a structured way so that others can contribute. I would be more than happy to support the project by contributing to it. Currently it's rather hard as it's not visible to me what your plans and thoughts are.

Indeed. I opened #159 to serve as a starting point for discussing future ideas and roadmap items. Specific issues, such as this one, are included in the things I'd like to get done for 2.0.


Feature - add a picker for template files in the settings

This would be nice, and prevent errors when providing template path, which are case sensitive

added this in 1.1.8


[Snyk] Security upgrade graphql from 16.7.1 to 16.8.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json
package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

658/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 5.3
Denial of Service (DoS) SNYK-JS-GRAPHQL-5905181
No
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: graphql
    The new version differs by 4 commits.

8a95335 16.8.1
8f4c64e OverlappingFieldsCanBeMergedRule: Fix performance degradation (#3967)
e4f759d 16.8.0
bec1b49 Support fourfold nested lists (#3950)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)

Dependency update solved in #64


Remove cluster limits & runtime protection

This is only c384c45 but it contains #1414 because I needed those types
But I believe this fixes LD-350
#trivial

Fails

:no_entry_sign:

Missing Test Files:

src/lib/Scenes/City/__tests__/cities-tests.ts
src/lib/utils/__tests__/convertCityToGeoJSON-tests.ts

If these files are supposed to not exist, please update your PR body to include "#skip_new_tests".

:no_entry_sign:

This PR includes changes to the Emission Pod's native code but does not have a package.json
change for the update to the "native-code-version". If this is fine, add #native_no_changes to your PR message.

  Generated by :no_entry_sign: dangerJS


Provide missing property validation for required expressions

Please describe the feature that you want to propose
For instance, for setBody, the expression is required, there is no validation error when there are none (whicbh is the case when we are adding a new setBody node)
https://github.com/apache/camel/blob/1bcab0700cd94057fec3f42ae77cfb4f17670abc/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/models/setBody.json#L18

expression validation requires a bit more work - #712


fix: resolves issue #15

I have resolved issue #15 by breaking the title and URL line for an issue, please review it and provide feedback if any.
Thank you.

@asuzukosi thank you for the PR I did a little refactoring of the code base, can you please update this PR accordingly? :slightly_smiling_face:


Calling rm(path, recursive=true) on an empty bucket causes a FileNotFound error

What happened:
Upgrading to version 0.7.1 from 0.6.2 i found behaviour had changed where calling remove on a bucket with recursive = true with the below parameters now throws a FileNotFoundError if the bucket is empty, if the bucket contains a file it successfully deletes it, however it also deletes the bucket as well.
path = "bucket_name//"
file_system.rm(path, recursive=true)
What you expected to happen:
In 0.6.2 this did not throw exceptions on empty buckets, and when the bucket contained files it just removed all the files from the bucket but did not delete the bucket.
Minimal Complete Verifiable Example:
# Put your MCVE code here
        import gcsfs
        path = "bucket_name//"
        file_system = gcsfs.GCSFileSystem()
        file_system.rm(path, recursive=True)

Anything else we need to know?:
Realise this might be an intentional change, but i couldn't find anything mentioning it so thought i would check.
Environment:
Exception is not thrown in:

Dask version: 0.6.2
Python version: 3.6
Operating System: docker container
Install method (conda, pip, source): pip

Behaviour Changed in:

Dask version: 0.7.1
Python version: 3.8
Operating System: docker container
Install method (conda, pip, source): pip

if the bucket contains a file it successfully deletes it, however it also deletes the bucket as well.

This seems to me like correct behaviour (like rm -r for posix shells)

FileNotFoundError if the bucket is empty

This seems correct only if bucket does not exist at all. An existing but empty bucket should be deleted with rm(recursive=True) or rmdir.

if the bucket contains a file it successfully deletes it, however it also deletes the bucket as well.

This seems to me like correct behaviour (like rm -r for posix shells)

FileNotFoundError if the bucket is empty

This seems correct only if bucket does not exist at all. An existing but empty bucket should be deleted with rm(recursive=True) or rmdir.

@NickScottKortical , do you have any interest in fixing the second point? It would amount to try/excepting FileNotFound in rm for the case that the path requested is a bucket.

@NickScottKortical , do you have any interest in fixing the second point? It would amount to try/excepting FileNotFound in rm for the case that the path requested is a bucket.


Taz Wanted title screen doesn't render any assets only the ui textures.

Describe the bug

On the title screen no 3D world space assets will render just the UI but i can select them with the model selection in Remix.
remix-0.4.1-release
RTX 4090
GPU driver version: 551.61
Game version 1.0 installed off an official retail CD using Elishacloud's directx wrapper: https://github.com/elishacloud/dxwrapper

Attach files!
Log and Config FIles.zip
To Reproduce
Steps to reproduce the behavior:

Open the game and skip all the intro video's and cutscenes
On the title screen the issue is present immediately

Expected behavior

There is a scene on the title screen (present in the rasterized screenshots i have provided) that should display in the background.

Screenshots

Remixed:

Rasterized:

Thanks for posting. For bring up of RTX Remix with a particular game I would recommend reaching out to the community discord server https://discord.gg/rtxremix


Added 'RUN' before the mkdir command

This solves https://github.com/AKSW/RDFUnit/issues/95

I have no idea why the checks are failing. I looked at travis and they appear to pass.


HfssSimulationSetup doc missing

🔍 Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

🐞 Description of the bug
Doc is missing
📝 Steps to reproduce
doc is missing
💻 Which operating system are you using?
Windows
📀 Which ANSYS version are you using?
No response
🐍 Which Python version are you using?
3.10
📦 Installed packages
pyedb-core

Closed by #378


Verify in place migration of inbound listener is zero-downtime

If not, we need to make it GE10 version

Manually confirmed


proxy qeustion

hi, thanks for this project~~wow.
when I use the way of proxy(shadowsocks)  to request
   proxies = {
    'http' : 'socks5://<IP_ADDRESS>:1080',
    'https': 'socks5://<IP_ADDRESS>:1080'
   }
   self.session.proxies = proxies;
   req = self.session.get(LOGIN_URL)

.it is show me erro:
 Traceback (most recent call last):
File "/Users/wangwei/xingxing/scrape_instagram/instagram-scraper/venv/bin/instagram-
scraper", line 11, in <module>
load_entry_point('instagram-scraper', 'console_scripts', 'instagram-scraper')()
File "/Users/wangwei/xingxing/scrape_instagram/instagram-scraper/instagram_scraper/app.py",
line 738, in main
scraper.scrape()
File "/Users/wangwei/xingxing/scrape_instagram/instagram-scraper/instagram_scraper/app.py",
line 334, in scrape
user = self.fetch_user(username)
File "/Users/wangwei/xingxing/scrape_instagram/instagram-scraper/instagram_scraper/app.py",
line 419, in fetch_user
resp = self.session.get(BASE_URL + username)
File "/Users/wangwei/xingxing/scrape_instagram/instagram-scraper/venv/lib/python2.7/site-
packages/requests-2.18.4-py2.7.egg/requests/sessions.py", line 521, in get
return self.request('GET', url, **kwargs)
File "/Users/wangwei/xingxing/scrape_instagram/instagram-scraper/venv/lib/python2.7/site-
packages/requests-2.18.4-py2.7.egg/requests/sessions.py", line 508, in request
resp = self.send(prep, **send_kwargs)
File "/Users/wangwei/xingxing/scrape_instagram/instagram-scraper/venv/lib/python2.7/site-
packages/requests-2.18.4-py2.7.egg/requests/sessions.py", line 618, in send
r = adapter.send(request, **kwargs)
File "/Users/wangwei/xingxing/scrape_instagram/instagram-scraper/venv/lib/python2.7/site-
packages/requests-2.18.4-py2.7.egg/requests/adapters.py", line 506, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: SOCKSHTTPSConnectionPool(host='www.instagram.com', port=443): Max retries exceeded with url: /maryinbeijing (Caused by SSLError(SSLError("bad handshake: SysCallError(-1, 'Unexpected EOF')",),))

The SSLError("badhandshake"):SysCallError  makes me confused.Can  you helo me  thanks very much !!  Best wishes for you ~

The proxy support has been added now. Run the commands with the option of proxies like this
$ instagram-scraper <username> -u <your username> -p <your password> --proxies '{"http": "http://<ip>:<port>", "https": "https://<ip>:<port>" }'


Added anchoring and bricking external providers.

Added tests for testing external providers.

Since it's dealing with anchoring and bricking APIs, I thought it's better to have a double check before merging on master since there are the most used APIs.


Turn experiment activation into button

I suppose this might be problematic in terms of AMP validity, but it would be super nice if the experiment instructions on https://ampbyexample.com/components/amp-fx-flying-carpet/ would just run the code instead of asking to paste it into the console. Maybe the button could use an iframe :)
Something like <button onclick="AMP.toggleExperiment('amp-fx-flying-carpet')">Activate experiment</button>

That'd be nice indeed. Does it work via iframe if it is on a subdomain? Otherwise, experimental examples usually don't validate anyway...

Good point that they don't validate. Just do it inline then. I think it is a god trade off.


[AVM Module Issue]: Feature - Ability to place dependancy on higher archetypes

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Module specific issue

[X] I confirm that this issue is about this AVM module and not about the resource itself, or how to use Terraform.

Issue Type?
Feature Request
(Optional) Module Version
0.6.0
(Optional) Correlation Id
No response
Description
When deploying Greenfield with a typical ALZ policy set, I've found that the root archetype doesn't finish deploying before the lower archetypes start.
I'm in a position where I can re-produce a Policy Assignment on the Landing Zone archetype failing due to the Policy (Set) Definition not having been completed on the Root archetype yet.
On a subsequent run, the the Apply suceeds.
Having the ability to provide a dependancy on an previous module archetype would be great. At the moment I am not able to specify a Depends On based on any of the outputs from the module as the data sources within the modules are not refreshed with an explict dependancy - this causes (I believet the alz or alzlib provider) to fail a for_each lookup.
Error: Invalid for_each argument
│
│   on .terraform\modules\alz_archetype_platform\main.tf line 156, in resource "azurerm_role_definition" "this":
│  156:   for_each = local.alz_role_definitions_decoded
│     ├────────────────
│     │ local.alz_role_definitions_decoded will be known only after apply
│
│ The "for_each" map includes keys derived from resource attributes that cannot be determined until apply, and so Terraform cannot determine the full set of keys that will identify the instances of this resource.
│
│ When working with unknown values in for_each, it's better to define the map keys statically in your configuration and place apply-time results only in the map values.
│
│ Alternatively, you could use the -target planning option to first apply only the resources that the for_each value depends on, and then apply a second time to fully converge.

A workaround would be to specify a large delay on lower archetypes - but that would impede subsequent operations.
I have circumvented the issue by adding the following to the module to specifically force a wait for Policy Definitions to complete (basically creates a null resource output of the module that is created once policy assignments in the root have completed, therefor inferring policy definitions and sets have been completed)
main.tf
resource "null_resource" "policy_assignment_dependency" {
  triggers = {
    dependancy_id = var.policy_assignment_dependency
  }
}

resource "azurerm_management_group_policy_assignment" "this" {
....

  depends_on = [
    time_sleep.before_policy_assignments,
    null_resource.policy_assignment_dependency
  ]

variables.tf
variable "policy_assignment_dependency" {
  type    = string
  default = ""
}

outputs.tf
output "after_policy_creation" {
  value = time_sleep.after_policy_creation.id
}

Root.tf
module "alz_archetype_platform" {
  //Having to adjust current version of module to circumvent issues with dependancy and alz provider changes 07/03/24
  source  = "Azure/avm-ptn-alz/azurerm"
  version = "0.6.0"
  //source                             = "../../../../modules/avm-pln-alz/0.5.0"
  id                                 = var.deploy_abbreviation == "" ? "${var.org_abbreviation}-platform" : "${var.org_abbreviation}-platform-${var.deploy_abbreviation}"
  display_name                       = var.deploy_abbreviation == "" ? "${var.org_abbreviation}-platform" : "${var.org_abbreviation}-platform-${var.deploy_abbreviation}"
  parent_resource_id                 = module.alz_archetype_root.management_group_resource_id
  base_archetype                     = "platform_override"
  default_location                   = var.default_location
  default_log_analytics_workspace_id = module.alz_management_resources.log_analytics_workspace.id
  delays                             = local.default_delays
  policy_assignment_dependency       = module.alz_archetype_root.after_policy_creation

  providers = {
    alz = alz
  }
}

Hi! Interesting feedback, we will look into a solution that has module outputs that indicate when policy  (set) definitions have been deployed

I am hoping the depends_on issue will disappear soon when the language experiment unknown_instances is fully released

We are making significant changes to the provider so will close this for now. Once the next version is released please open a new issue if still relevant.


page size correction

there are references to pages of 17 x 17 (which is not a standard size of paper), and then it states Legal size, which is actually 8.5 x14. I think that the 17 x17 may be a typo and it should be 11x17 (which is typically referred to as Tabloid size), please review and correct if necessary.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a4be1aa4-860c-6480-502f-08f610f0b9b2
Version Independent ID: a4be1aa4-860c-6480-502f-08f610f0b9b2
Content: Requirements and limitations for models in Microsoft Syntex
Content Source: microsoft-365/syntex/requirements-and-limitations.md
Service: microsoft-syntex
GitHub Login: @chuckedmonson
Microsoft Alias: chucked

@DeanGross Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/10711
Once the author approves, the changes will be live.
Thanks
Sri

@DeanGross, @msbemba -- Thank you for catching and fixing. Merged these changes as part of PR #18485. Updates will be live 1/17/23 after 3:30 PM PT. Thanks again.


feat: ISchemaBuilder should allow applying multiple schema transformation lambdas

Product
Hot Chocolate
Is your feature request related to a problem?
As a library author, I'd like to be able to create convenient IRequestExecutorBuilder/ISchemaBuilder extensions that encapsulate lambas to easily set schema directives. Currently it is not possible to apply multiple schema transformations when using lambdas as the last specified transformation overwrites all the previous ones, i.e.
var builder = WebApplication.CreateBuilder(args);

builder.Services
    .AddGraphQLServer()
    .ConfigureSchema(b => b.SetSchema(s => s.Directive("foo")))
    .ConfigureSchema(b => b.SetSchema(s => s.Directive("bar")))
// other config

This generates
schema @bar { ... }

While we would expect to have both @foo and @bar directives applied
schema @foo @bar { ... }

The solution you'd like
Applying multiple schema transformation lambdas results in cumulative changes to the underlying schema.

As mentioned before, we are removing schema builder at the moment. We slowly hid schema builder behind our schema configuration API and finally towards the end of the year will completely pull it.

I am closing this issue as we are heavy at work on the type system at the moment.


codecov: log static HTML coverage reports

NOTE: This patch hasn't been tested.
This patch attempts to collect and log the static HTML coverage reports
that are generated via make code-coverage-capture, such that they can
be easily downloaded using the Buildbot UI, and viewed on a developer's
local workstation.

@prakashsurya Out of curiosity, how big is the tarballs?

@behlendorf I'm not sure I made the changes to the master.cfg file correctly; can you check my update?

@dinatale2 I ran zloop for an hour, and then ZTS and generated a coverage report for userspace only.. using the HTML files for that report, here's what I saw on my VM:
$ time sh -c 'tar -cf - zfs-0.7.0-coverage | xz -9e > zfs-0.7.0-coverage.tar.xz'

real    0m44.717s
user    0m44.540s
sys     0m0.230s

$ du -sh zfs-0.7.0-coverage.tar.xz
2.2M    zfs-0.7.0-coverage.tar.xz

so that's 2.2 MB; I'd expect the kernel report to be similar in size.

--- a/master/master.cfg
+++ b/master/master.cfg
@@ -437,8 +437,8 @@ test_factory.addStep(ShellCommand(
     command=["runurl", bb_url + "bb-test-cleanup.sh"],
     haltOnFailure=False, maxTime=1800, sigtermTime=30, logEnviron=False,
     lazylogfiles=True,
-    logfiles={"coverage-user"   : { "filename" : "coverage-user.tar.xz",   "follow" : False },
-              "coverage-kernel" : { "filename" : "coverage-kernel.tar.xz", "follow" : False }},
+    logfiles={"coverage-user"   : "coverage-user.tar.xz"   },
+              "coverage-kernel" : "coverage-kernel.tar.xz" }},
     decodeRC={0 : SUCCESS, 1 : FAILURE, 2 : WARNINGS, 3 : SKIPPED },
     description=["analysis"], descriptionDone=["analysis"],
     hideStepIf=lambda results, s: results==SKIPPED))

would it be preferable to simply state the filename? looking at the linked documentation, the default for "follow" is "False".. so I think the above simplification would be equivalent.. but maybe being explicit and not relying on defaults is better?

@prakashsurya My vote is to stay consistent with the rest of master.cfg.

If we're going to start keeping larger logs on the server we should consider setting a log horizon to age out old logs.  Keeping say the last 200 or so builds would likely be fine.

Merged! Thanks @prakashsurya!


Fix API compatibility on email filtering

Coverage increased (+0.01%) to 90.669% when pulling 7a06fc84275ed2ee00641405947e61ee6421eb09 on johngian:fix-filter-idp-api-compatibility into 400f78f566e4bc9712d66e32be249fff27aba1cb on mozilla:master.


feat: adds query search [FE-131]

adds a searchOptions to the query collection (to be used for sorting later too)
triggers search on input change and on keydown

Scope & Purpose

[x] :pizza: New feature

Checklist

[x] Tests

[x] Manually tested

[x] :book: CHANGELOG entry made

Related Information

[x] GitHub issue / Jira ticket: https://arangodb.atlassian.net/browse/FE-131

Screenshots:

Code LGTM.
Two minor things: 1.)
Search box height does not align to the height of the button.
2.) restrictToSearchPhraseKey and restrictToSearchPhrase (search mechanism) looks familiar. Somewhen - must not be this PR - we should move this code (as we do have it on multiple places) to a single dedicated location where it can be reused. Every view does have it's own added logic. This logic we could pass via. callbacks. Reason: In cases we do have issues here, we might need to adjust multiple views. With a single place, we will improve maintainability. But as I said already - very minor right now. Something for later. If we start the transition from backbone js related views to react based - we should not implement my suggestion at all.

Noted, good suggestions. I'd refrain from doing this right now and wait for a transition to React! But will keep this in mind in case we touch these files again


Avoid fake superhero usernames

@mike-gusev-ae I think to open an issue about that to discuss.
As far as I can see, we can add such checks:

regexp.test(username) regexp we already have in utils
and next if we have such username so check if state['features/aeternity'].hasWallet is true or at least if state['features/base/jwt'].jwt present.

I'm not sure that we need it.
I wanted to implement it only because of chat (#213 ), but it should work well right now. We found good solution.
And in other cases, fake users wont have avatars. So, we can easily find a fake among them.

@mike-gusev-ae I suggest that It's good to avoid fake superhero accounts.

Yes, of course, it won't be superfluous for sure

And in other cases, fake users wont have avatars. So, we can easily find a fake among them.

Not really all, users are able to set some from options.

Also I think that in future we need to block any kind of account options for the superhero JWT users. So if user use JWT in this case avatar change must be blocked. But it's about other thing.

Also I think that in future we need to block any kind of account options for the superhero JWT users. So if user use JWT in this case avatar change must be blocked. But it's about other thing.

you can't change avatar if you have jwt, you can add gravatar email but it will be ignored in the frontend (it will be used in mobile app tough, as it does not support anything else)


twitter is working?

Hi, I have some suggestions to help solving this issue!
Here is a list of similar issues:

1. [Grab user's Email during authentication with Twitter](https://github.com/omab/python-social-auth/issues/825)

2. [access token secret is required when register_by_access_token](https://github.com/omab/python-social-auth/issues/647)

3. [Authication using acees token works for facebook but not twitter and VK](https://github.com/omab/python-social-auth/issues/238)

4. [Security issue with Twitter backend - state parameter](https://github.com/omab/python-social-auth/issues/338)

5. [StravaOAuth - Strava authentication backend not working.](https://github.com/omab/python-social-auth/issues/455)

Also, below are some developers who made PRs to close similar issues:

halfstrik

hellvix

Hope this is useful!
Cheers,
Cinnabot.