pks create-cluster fails with worker is not running after upgrade

PKS versions tested: 1.0 and 1.0.1
PCF Ops Manager: v2.0-build.255
pks create-cluster k10-test-0 --external-hostname k10-test-0 --plan small

Name:                     k10-test-0
Plan Name:                small
UUID:                     1b9fd033-f131-4030-8312-f1219297d9a0
Last Action:              CREATE
Last Action State:        in progress
Last Action Description:  Creating cluster
Kubernetes Master Host:   k10-test-0
Kubernetes Master Port:   8443
Worker Instances:         3
Kubernetes Master IP(s):  In Progress

pks cluster k10-test-0

Name:                     k10-test-0
Plan Name:                small
UUID:                     1b9fd033-f131-4030-8312-f1219297d9a0
Last Action:              CREATE
Last Action State:        in progress
Last Action Description:  Instance provisioning in progress
Kubernetes Master Host:   k10-test-0
Kubernetes Master Port:   8443
Worker Instances:         3
Kubernetes Master IP(s):  In Progress

errors in logs:
[on-demand-service-broker] 2018/03/12 20:34:56.959979 Started GET /v2/service_instances/1b9fd033-f131-4030-8312-f1219297d9a0/last_operation
[on-demand-service-broker] [8eeabcb5-58d5-453d-857b-5bf8985ddb8c] 2018/03/12 20:34:56.960181 getting tasks for deployment service-instance_1b9fd033-f131-4030-8312-f1219297d9a0 with context cef2086d-1e65-43a9-8ba7-7f2e3bccd374 from bosh
[on-demand-service-broker] [8eeabcb5-58d5-453d-857b-5bf8985ddb8c] 2018/03/12 20:34:56.982214 BOSH task ID 175 status: error create deployment for instance 1b9fd033-f131-4030-8312-f1219297d9a0: Description: create deployment Result: 'worker/7e08bf8f-70bf-416d-b299-63ab8162eabf (0)' is not running after update. Review logs for failed jobs: kubelet
[on-demand-service-broker] 2018/03/12 20:34:56.982292 Comp

error from node kubelet.stderr.log
I0312 21:55:12.355029    3767 kubelet_node_status.go:82] Attempting to register node vm-665f6975-e5cb-4b97-7a66-2e623c405105
E0312 21:55:13.263950    3767 container_manager_linux.go:583] [ContainerManager]: Fail to get rootfs information unable to find data for container /
I0312 21:55:13.365268    3767 kubelet_node_status.go:85] Successfully registered node vm-665f6975-e5cb-4b97-7a66-2e623c405105

@vchrisb Have you seen this error with the pks module?

@depohmel This may be an issue with the pks deployment and not the terraform used to create it. Have you resolved this issue? @vchrisb have you seen this issue?

@genevieve it's definitely PKS issue. Could you please file to a proper repo. because my attempt to find the right one isn't successful.

This might be an issue for: https://github.com/cloudfoundry-incubator/kubo-deployment


Type 'undefined' is not assignable to type 'never'.

I'm trying to deploy this on lambda but when im running tsc of the lambda function (this pr) it fails with this error:
node_modules/@webtoon/psd/dist/classes/Psd.d.ts(18,14): error TS2416: Property 'parent' in type 'Psd' is not assignable to the same property in base type 'NodeBase<never, NodeChild>'.
  Type 'undefined' is not assignable to type 'never'.

https://github.com/opendesigndev/design-processing/pull/9/checks
I had to enable skipLibCheck in tsconfig to be able to compile the lambda function, but it looks like there is a bug? Is this some change you made @alexspevak or is that an upstream issue? cc @scoiatael

looks like an upstream issue https://github.com/webtoon/psd/blob/main/packages/psd/src/classes/Psd.ts#L32
not sure how to fix this, i can just make an issue in webtoon i guess

Maybe this is due to newer version of TypeScript? Since I don't recall having this problem when building library on my side.


Is it possible to revert watermarks from images?

As title says.

Hey hoshi!
You mean after they are already put onto the image? I'm afraid not via this package.
Removal of watermarks is an entirely different beast. You might have more luck googling for "removal watermark machine learning". I remember there was some work on that front.

If this was helpful, please close the isuse :-)


🧰 Improve Lint

Description

I'm trying to improve linting on pull requests.
References

None
Checklist

[ ] I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (5993b09) 3.15% compared to head (d1cf6ea) 3.15%.
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #238   +/-   ##
=====================================
  Coverage   3.15%   3.15%
=====================================
  Files        100     100
  Lines       2976    2976
=====================================
  Hits          94      94
  Misses      2882    2882

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How long will the sample progress end?

How long will the sample progress end?

It maybe so slowly,why?
@Flash-321

@pokameng Hi, it is too slow. In our original implementation, sample each story takes around 30-40 secounds. I am wondering if the time cost for the first batch contains the prefetch time and hdf5 loading time, what about the time cost for the other batch?
Also, in the sample mode, you could using ddp and also increase the batch size. For acceptable sample quality, you could try to set the guidance scale to 7.5, and the steps to 50, using a pndm scheduler, it can greatly reduce the sample time.

@Flash-321
Can I train and sample at the same time?

@pokameng Sure, you can simply modify the code in
https://github.com/Flash-321/ARLDM/blob/eb907e3717ac20f82dfba8e67fd55d95127de098/main.py#L309-L311
def validation_step(self, batch, batch_idx):
     original_images, images = self.sample(batch)
     grid = torchvision.utils.make_grid(sample_imgs)
     self.logger.experiment.add_image('generated_images', grid, 0)

also make sure to enable this module during training
https://github.com/Flash-321/ARLDM/blob/eb907e3717ac20f82dfba8e67fd55d95127de098/main.py#L82-L97
but it will slow the training process, we recommend manually run a job to sample images.

What I mean is that I have now saved a ckpt and the training process is still executing, I have reopened another job to sample the saved ckpt, but I am worried that the ckpt will be overwritten by the new training process saved ckpt
@Flash-321

What I mean is that I have now saved a ckpt and the training process is still executing, I have reopened another job to sample the saved ckpt, but I am worried that the ckpt will be overwritten by the new training process saved ckpt @Flash-321

@pokameng It doesn't matter, once your ckpt is loaded, the sample job do not rely on it anymore. You can also copy it to another folder to avoid this situation.

ok thanks!!!

what is the test_model_file ?

@rehammsalah here, https://github.com/xichenpan/ARLDM/blob/main/config.yaml#L25


Added support for Hetzner Cloud (hcloud) provider.

I am using this to generate Ansible inventory files for servers provisioned in Hetzner Cloud using the HCloud plugin for Terraform.
I am not familiar with development in GoLang, so please review this with all your scrutiny :)

Sorry about the delay getting to this. It looks fine to me-- could you please rebase against master?

@adammck I rebased it and changed everything to twenty or <IP_ADDRESS> to account for the other integrations that have been added in the meantime. Can you have another look?

Is there anything we can do to move this forward?

In my understanding, this can be closed due to #151. @b-m-f is this correct ?

@DanielMSchmidt  I can give it a try today

I believe it can be closed, yeah


Demo 148 - Error in Model Update

@choper725 lets continue here with:
https://github.com/abap2UI5/abap2UI5/pull/778#issuecomment-1890745772

the demo 148 is big, which makes finding the error difficult. i created a separated minimal example to check the binding:
https://github.com/abap2UI5/abap2UI5-samples/blob/main/src/z2ui5_cl_demo_app_153.clas.abap
i think i fixed the issue:
https://github.com/abap2UI5/abap2UI5/pull/783
but if not can you change the structure here to reproduce your error case:
https://github.com/abap2UI5/abap2UI5-samples/blob/031f56d4a1466479d63a918df3a5bc0eab27fbc8/src/z2ui5_cl_demo_app_153.clas.abap#L20
i fixed this position, but i am sure we need this somewhere else so i believe i created a new error now:
https://github.com/abap2UI5/abap2UI5/blob/83393c3fcf8a256073c5855f88172c91b5ddeb60/src/00/z2ui5_cl_util_func.clas.abap#L649
these binding issues are always complicated to identify but step by step we can will make it.

hi @oblomov-dev
i still dont get the border_width and border_radius on update model.. :\

Hi @choper725,
For me this still looks like a problem at the frontend, in the request body the attributes are written without underscore:

But when you check the ms_db-t_attri table of abap2UI5 you see that the framework expects the attributes with underscore:

I added a demo 153 (z2ui5_cl_demo_app_153) where i make the binding with nested structures and tables, there you can see that it works:

Demo 148 is very big, t_attri with a lot of entries and the payload of the body has a lot of entries too, if possible try to reproduce your problem with demo 153 which makes it a lot easier to debug and to identify the root cause.
Let me know if this works for you or you need more assistance.
Best regards.

with latest PR in samples repository i updated demo 153 with the logic i use in the chartjs demo 148..
updated the chiled table with new property (new_type), and binded the table with pretty_name = 'X'.

Added now additional logic fore binding in pretty mode. The demo 153 works now, you can try again, and please just extend demo 153 if you run into further problems.

hi @oblomov-dev
it was still not working on chartjs,
so what i saw that its another level down the nested route,
so i made another nest on top of the new_type field in demo 153,
no the demo is getting an abap error..

thank you for updating the demo. made a fix https://github.com/abap2UI5/abap2UI5/pull/788
demo works now again on my side

well its still not working on chartjs...
i know its hard to debug demo148, but im out of ideas and maybe you can point me to where should i look,
the break is on the setConfig method, before any frontend logic,,
on first load:

see borderWidth and borderRadius are there,
on update, they are gone,

Thank you for the update of 153. Fixed the binding again with https://github.com/abap2UI5/abap2UI5/pull/791
Works now on my side.

yes! now its working..! thanks for the quick fixes @oblomov-dev !
ill continue working on implementing chartjs library, ill leave this for a bit to see if i encounter any more binding issues

hi @oblomov-dev
after latest pull, nothing is working on my side.. not really sure what it is exacly,
just getting this: (4 times on each chart)

yes already saw it here:
https://github.com/abap2UI5/abap2UI5/pull/796#issuecomment-1902038676
But popus work on my side, only chart.js is not working...

EDIT: there was only a change in the compress functionality, so maybe you test again with client->_bind_edit( ... compress = abap_false) in case you use this. but no other changes were made.

EDIT: there was only a change in the compress functionality, so maybe you test again with client->_bind_edit( ... compress = abap_false) in case you use this. but no other changes were made.

yes i do used it as true, not false

yes every variable typed with abap_bool is now not compressed anymore and values are with "false" send to the frontend.
If you still get problems after deactivating compress it might be because your data model does now contain initial values and the position of arrays etc might be changed now.

means that every type abap book is being sent to frontend with value false unless its set to true ??

yes abap_bool becomes true or false at the frontend but is not initial anymore, otherwise certain UI5 controls are not working properly, when compress is activated.
you also have the option to deactivate compress or is this not working?
another option can be that we extend the framework with another parameter like "compress_without_booleans".
or last option: you can test with using type "xflag" instead of "abap_bool". i deactivated compress for this with the last PR:
https://github.com/abap2UI5/abap2UI5/blob/4a57ef5ef7b2da15edce925c880ec179845778fe/src/00/z2ui5_cl_util_func.clas.abap#L327

yes abap_bool becomes true or false at the frontend but is not initial anymore, otherwise certain UI5 controls are not working properly, when compress is activated.
you also have the option to deactivate compress or is this not working?
another option can be that we extend the framework with another parameter like "compress_without_booleans".
or last option: you can test with using type "XFELD" instead of "abap_bool". i deactivated compress for this with the last PR:
https://github.com/abap2UI5/abap2UI5/blob/4a57ef5ef7b2da15edce925c880ec179845778fe/src/00/z2ui5_cl_util_func.clas.abap#L327

thx for the quick reply,
XFELD is acting wierd, some boolean values i change not getting sent to frontend...
i think the most elegant solution to this i do create another parameter like full_compress which make it act full compress with all types

ok great that this works for you, looks very nice:

yes the weird behaviour is the behauviour of /ui2/cl_json, when a structure is completely empty even with false, it is not created. i mean i could extend the /ui2/cl_json class again but i think for now it is fine like this.
the XFELD approach was just for testing, when this works for you i would recommend the following. we use a new constant and set this as an importing parameter for the _bind methods:
constants:
    begin of cs_compress_mode,
          full type string value `FULL`,                     "the way you need it for chart.js
          full_w_booleans type string value `FULL_W_BOOLEANS`,   "default value
          non type string value `NONE`,                    "old way in case the others are not working
     end of cs_compress_mode.

Do you think this will work for you?

seems good idea,
please check demo 153, i think there is an issue with the binds and compress

153 looks correct to me. The new compress logic is used which sends values typed with boolean to the frontend in any case.
specifically abap_bool = 'X' (abap_true) means true at the frontend and everything else becomes false, means '-' is false here at the frontend.
Normally I would not use abap_bool with values except abap_true or abap_false or why are you doing this?

abap2UI5 updated now with https://github.com/abap2UI5/abap2UI5/pull/799

looking good,
native in class /ui2cl_/json, in case compress in activd:
when sending abap_false it not creating the structure,
but when sending ‘-‘ it create the struc with false as a value.
you overcome this in the framework checking the types explicitly.
but knowing that ‘-‘ creates a false value for a key in json with compress can solve the checking problem

(1) yes '-' becomes 'false', its done here:
https://github.com/abap2UI5/abap2UI5/blob/70da7816d89cd0e0e55b5a823a1f29954e73e502/src/00/z2ui5_cl_util_func.clas.abap#L302
(2) yes it is the default behaviour of /ui2/cl_json, when it is abap_false and the rest of the structure is also initial it gets not created and then it also does not matter if which comress mode you choose.

ui2/cl_json ignores initial values in compress, hence when the type is abap_bool and the value sent is ‘-‘ then its mapped to false.
thats why in demo 153 i used ‘-‘ to show that the value is created in the json.
and when its set to abap_false it doesnt (what you changed in the demo)

ah ok i think i got your point now, instead of using abap_false we can use '-' or something else except 'X' to make /ui2/json do what we need. mhh yes thats right!
but this is still a bug to me of the /ui2/cl_json class and i am not sure if its a good idea to make it work with a trick. additionally i do not see a way how to map abap_false to '-'. For example when someone binds a table having a column with abap_bool, abap2UI5 throws it directly into the /ui2/cl_json class, adding here an extra loop for boolean checks would cost a lot of extr runtime and seems not a got idea to me...
but still wondering, mhh maybe we will find a better way to solve this compression problem.

how do abap2ui5 handle abap_false binding? it doesnt check the types and values if each field??


CLDC-1618 Add cookie banner

Was previously making use of govuk_cookie_banner helper, but it didn't support wrapping the button group in a form, so have just added a partial with explicit HTML.
Have verified that the respective buttons on the banner behave, and that no (GA) cookies are set when the user refuses them.

I wonder if it's worth putting a test that GA cookies do/don't appear - is this something that could be broken in the future or do you think it's safe to assume it won't?

Yep, good shout on a test. I think given the branching cases it might be challenging to hit every possible failure mode, but I can definitely add something in.


change(verifier): Update Zebra's block hash checkpoints

Motivation
In #4155, we want to update Zebra's checkpoints, so the initial sync is faster.

Reviewer Checklist

[ ] Code implements Specs and Designs
[ ] Tests for Expected Behaviour
[ ] Tests for Errors

I'm running a full sync test here:

https://github.com/ZcashFoundation/zebra/actions/runs/2217609623

We should merge this PR regardless of the results, but hopefully it will be a bit shorter than 6 hours.

We should merge this PR regardless of the results, but hopefully it will be a bit shorter than 6 hours.

The new checkpoints finished the sync in 5h53m, before the checkpoints it was 5h58m.
But container name lookup and image creation pushed the GitHub job over 6 hours.


Create get_quad_ids.py

Get ids as a list for a specific quad of a CCD for a particular ZTF field.
Can be used later for getting features, and inferencing.

@AshishMahabal Can you please do this in a branch on your own fork and run pre-commit install to lint the file when running git? Then please retag me.


add favicon to project

Find a SAAS logo or another appropriate icon for a course planner.  Use a favicon web site to generate the icons an put in a directory img.  Then add the code to the index.html page to display the favicon.

I can do this

I would like to work on this

I can work on this

Done. What I did is I downloaded the SAAS logo off of the internet and put it in https://www.favicon.cc/ and turned it into a .ico file. Then I looked up how to add a favicon to a website an found this code:
I changed it to

Then I uploaded it to the server.
http://math.seattleacademy.org/maxcook/day19/index.html

Done. What I did is I downloaded the SAAS logo off the internet and put it in https://www.favicon.cc/ to change it to a .ico file. Then I looked up how to add a favicon to a website an found this code:

I changed it to

Then I uploaded it to the server
math.seattleacademy.org/maxcook/day19/index.html

Done. What I did is I downloaded the SAAS logo off the internet and put it in https://www.favicon.cc/ to change it to a .ico file. Then I looked up how to add a favicon to a website https://www.w3.org/2005/10/howto-favicon. I changed that code so it would work for my image and then I uploaded it to the server math.seattleacademy.org/maxcook/day19/index.html

commit bdf2ad68a8c43e25d14f6da85775e2d157306614 @maxcook2002


[BUG] CS per Min. and Gold Tab

Describe the bug
Both CS per Min and Gold shows some wierd numbers and have some wierd formatting.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'

Expected behavior
Material

Desktop (please complete the following information):

OS: [e.g. Windows 10]

Additional context
Riot games disabled [LiveEvent] as of yesterday, using port34243.

Hey, hm i tested  942039c, but i have still that bug. Best Regards


Replace minify callback with a promise

See https://github.com/jakubpawlowicz/clean-css/issues/842#issuecomment-267652497

@jakubpawlowicz web usage aside, do we know the usage statistics of synchronous new CleanCSS().minify() on Node.js?
I ask because html-minifier only has a synchronous API currently, and the use of Promise would conflict with that. Obviously I can just change everything to asynchronous and publish 4.0 as well 😎

I have no idea what's the usage or where to get it.
You'd need to use sth like:
var minified = new CleanCSS(options)
  .minify(input)
  .then(function (output) { return output.styles; });

instead of
var minified = new CleanCSS(options).minify(input).styles;

right?
I'm not sold to introducing Promise API yet as 4.0 already has a lot of changes.

@jakubpawlowicz in your example above, minified would be the (chained) Promise object as opposed to the desired output. So I can do minified.then(function(styles){...}), but it would still be asynchronous.

:man_facepalming: yeah, you are right, it's not that straightforward to switch to promises.

If helpful at all, I could envision an api change to the following. Here is the current implementation...
new CleanCSS().minify(source, function (error, minified) {
    //[...]
});

With native promises, this could be crafted as such...
CleanCSS.minify().then(function(minified) {
  // success handler
}, function(error) {
  // error handler
});

I like having the dedicated success and error handler, as oppoesd to differing return parameters. This becomes more interesting if you consider that CleanCSS.minify returns a promise. Imagine having the ability to have a few tasks queued up all that are promises. We can then leverage promise resolution flows in ways that are appealing. One possible example could be Promise.all. Imagine this scenario...
var p1 = CleanCSS(opt);
var p2 = SomeOtherLibrary();

Promise.all([p1, p2]).then(values => {
  console.log(values); // [minified, otherUsefulStuff]
});

Other libraries such as async offer some powerful flow solutions to all things "then-able." It's becoming more and more accepted that libraries are promised driven than using traditional callbacks to take advantage of these resolvable approaches that we've all beaten our minds up for when we eventually end up in callback hell.
I support either way and think the new changes coming are great - I am simply chiming here with a humble opinion on the matter 😸

Thanks @scniro, that's a very good point indeed!
@alexlamsl suggested we can use a flag saying if a promise should be returned or not (defaulting to false). I actually like the idea as we could 1) test how it works 2) allow both interfaces at the same time 3) flip the switch at some point if needed

@alexlamsl @scniro @ben-eb 23637f627b7ab1654a17fd6fe2633179e8cf89a1 should be it

@jakubpawlowicz you baller 💵

Cool, it's merged to master and due in 4.0.


feature: auto generate tag name to what is in the tag.txt list

Prerequisites

[yes ] Did you read FAQ section in readme.md?
[yes ] Did you test with the latest releases or commit ?
[yes ] Did you search for existing issues in Issues?

Description
[feature: auto generate tag title name to what is in the tag.txt list / change folder to auto rename to tag instead of author for "tags"]
feature
Steps to Reproduce
Expected behavior: [auto generate tag name to translate to what is in the tag.txt list for example:

]
Actual behavior: [n/a]
Versions
Latest
You can get this information from executing PixivUtil2.py --help.
Latest version available in https://github.com/Nandaka/PixivUtil2/releases

not quite understand what you want, but you can use %searchTags% in the filename formats so it will add the search tag into filename.

Thank you :)


Automatic snapshot publication from travis

We have to add a task in travis script to automate snapshots publication on oss.jfrog.
Snapshots are based on master branch.

[x] Add encrypted keys into .travis.yml
[x] add artifactoryPublish in .travis.yml
[x] restrict artifactoryPublish to master branch
[x] restrict artifactoryPublish to manual commits (not those from Gradle Release Plugin)

Snapshots are available here : https://oss.jfrog.org/artifactory/oss-snapshot-local/io/ethmobile/ethdroid/


[Bug]: A nullable struct property results in an invalid generated schema.

Describe the bug
Invalid schema has been generated in cases where a type has a nullable property of a custom struct.
Version 6.2.2 behaves in the expected way.
Expected behavior
A valid schema should be generated.
Actual behavior
An invalid (and recursive) schema has been generated.

Steps to reproduce
public class Program
{
    public static void Main(string[] args)
    {
        var builder = WebApplication.CreateBuilder(args);

        // Add services to the container.

        builder.Services.AddControllers();
        // Learn more about configuring Swagger/OpenAPI at https://aka.ms/aspnetcore/swashbuckle
        builder.Services.AddEndpointsApiExplorer();
        builder.Services.AddSwaggerGen();

        var app = builder.Build();

        // Configure the HTTP request pipeline.
        if (app.Environment.IsDevelopment())
        {
            app.UseSwagger();
            app.UseSwaggerUI();
        }

        app.UseAuthorization();

        app.MapControllers();

        app.Run();
    }
}

[ApiController]
[Route("[controller]/[action]")]
public class TestController : ControllerBase
{
    [HttpGet]
    public TestResponse Get()
    {
        return new()
        {
            Foo = new(1, 2),
        };
    }
}

public record TestResponse
{
    public TestStruct? Foo { get; init; }
}

public record struct TestStruct(int A, int B);

Exception(s) (if any)
No response
Swashbuckle.AspNetCore version
6.7.0
.NET Version
net8.0
Anything else?
No response

We are having the same issue.
+1

Looks like this was broken by #2941.

Sorry for the inconvenience!

This is doubly bad because object types as references that are properties of an object or request are not allowed to have descriptions. This makes 6.7.0 unusable for us as it results in most of our API docs being unusable with unhelpful descriptions of object properties/request parameters being the description of the schema itself (empty in the case of these "NullableInt32" etc. types).

Version 6.7.1 is now available from NuGet.org which resolves this issue.


Django 1.8 warnings and 1.9 pending incompatibilities

These errors get thrown when using django 1.8:
/autocomplete_light/widgets.py:19: RemovedInDjango19Warning: The django.forms.util module has been renamed. Use django.forms.utils instead from django.forms.util import flatatt

autocomplete_light/fields.py:8: RemovedInDjango19Warning: django.contrib.contenttypes.generic is deprecated and will be removed in Django 1.9. Its contents have been moved to the fields, forms, and admin submodules of django.contrib.contenttypes. from django.contrib.contenttypes.generic import GenericForeignKey

Thanks, 1.8 support is under active development in the dj18 branch.

Could you try with 2.2.0rc1 which was released yesterday ?
Thanks.


fail to connect websocket, Invalid frame header

Version
3.0.1
Reproduction link
https://github.com/liuhanqu/vuecli-demo
Node and OS info
npm: 6.2.0, os: mac
Steps to reproduce

cd client && npm i && npm run serve
cd server && npm i && npm start
open browser to 'http://localhost:8888/laboratory'

What is expected?
websocket connect success
What is actually happening?
websocket fail to connect
bug image

You are runing your app server in front of the dev-server, while the usual setup is the other way around. Why would you do that?
If you want to keep doing that, you will have to proxy websocket connections from your app server through to your devserver with a middle ware. That's not a problem for us to solve, though.

render a html, sometimes u would output some variable to html.
when use dev-server, it can not do that.
maybe my implementation is wrong.
thanks.

"Why would you do that?"
Server-Side-Rendering with PHP for example like in my case?
As far as I know is SSR part of the Vue project. Or am I wrong?


docs: vanilla

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
948

Relevant Lines:
948

💛  - Coveralls


Rename the In Progress tab into Request + Remove the Arrow Icon in all the Dashboards + Fix the Table Alignment for PO and TL Names

In Progress tab has both active and resolved requests so it doesn't make sense to call this tab In Progress as it doesn't cover the resolved requests.
The arrow icon in the tables beside the "copy license" icon doesn't have any useful functionality and confuses users.
Table is not aligned when there are different lengths of Product, PO and TL names. See the screenshot:

DoD:

The tab is renamed from In Progress to Request
The arrow icon is removed
The table stays aligned regardless of the length of Product, PO and TL names

All three fixed/implemented:


Decorators placed after withRouter are called twice

Consider this code sample
export default {
  title: 'Demo',
  component: Demo,
  decorators: [
    (Story) => {
      console.log('Provider');
      return (
        <Provider store={mockStore()}>
          <Story />
        </Provider>
      );
    },
    (...args) => {
      console.log('withRouter');
      return withRouter(...args);
    },
  ],
}

export const Default = {
  decorators: [
    (Story) => {
      console.log('story');
      return <Story />;
    },
  ],
};

Output:
withRouter
Provider
story
Provider
story

Is this how withRouter is supposed to work?

Have you try the same code outside of storybook to see if it behaves the same way ?

I'm closing this as no further information has been delivered and no actual issue has been identified. Feel free to re-open this if you have additional information.


[Feature]: typesafe assertions

🚀 Feature Proposal
this will always fail, but since typescript infers the type as unknown, there's no compile error:
expect('foo').toBe(1) // no error
expect<string>('foo').toBe(1) // no error

Motivation
it will allow you to identify errors in your tests much earlier, speeding up development 🚀🚀🚀
Example
// the new and improved expect 🚀:
declare const expect: <T>(actual: T) => { toBe: (expected: T) => void}

// usage:
expect('foo').toBe(1) // TS2345: Argument of type 'number' is not assignable to parameter of type 'string'.

Pitch
the current expect types make using typescript with jest pretty much useless. i think if jest is going to support typescript, it should support basic functionality like this

Fix it. Just open a PR (;

Would love toBe to work as type predicate 👍 Not sure how feasible it is, tho

Hi, can I try this?

Yeah, go for it!

Hey guys!
I'm facing a problem here.
I've made the following changes in /jest/packages/expect/src/types.ts:
export type Expect = {   <T = unknown>(actual: T): Matchers<void, T> &     Inverse<Matchers<void, T>> &     PromiseMatchers<T>; } & BaseExpect &   AsymmetricMatchers &   Inverse<Omit<AsymmetricMatchers, 'any' | 'anything'>>;
...
export interface Matchers<R extends void | Promise<void>, E = unknown>
...
toBe(expected: E): R;
and when I test in a local app using
import { type Expect } from '.../jest/packages/expect/build/index';
declare const expect:Expect;
...
expect(1).toBe('1');
it works fine and TypeScript gives me the error Argument of type 'string' is not assignable to parameter of type 'number'.ts(2345) as expected.
But when I add the same assertion to the /jest/examples/typescript/__tests__/calc.test.ts file, TypeScript keeps its current behavior and doesn't identify the type error. It keeps getting unkown as the type of Matchers:
(alias) expect<number>(actual: number): Matchers<void, unknown> & SnapshotMatchers<void, number> & Inverse<JestMatchers<void, number>> & PromiseMatchers<...>
Does anyone know what could be happening here?

here is git diff from the /jest/packages/expect/src/types.ts
index e2fc97916..d7d6f7cfd 100644
--- a/packages/expect/src/types.ts
+++ b/packages/expect/src/types.ts
@@ -94,9 +94,9 @@ export interface BaseExpect {
 }

 export type Expect = {
-  <T = unknown>(actual: T): Matchers<void> &
-    Inverse<Matchers<void>> &
-    PromiseMatchers;
+  <T = unknown>(actual: T): Matchers<void, T> &
+    Inverse<Matchers<void, T>> &
+    PromiseMatchers<T>;
 } & BaseExpect &
   AsymmetricMatchers &
   Inverse<Omit<AsymmetricMatchers, 'any' | 'anything'>>;
@@ -118,20 +118,20 @@ export interface AsymmetricMatchers {
   stringMatching(sample: string | RegExp): AsymmetricMatcher;
 }

-type PromiseMatchers = {
+type PromiseMatchers<E = unknown> = {
   /**
    * Unwraps the reason of a rejected promise so any other matcher can be chained.
    * If the promise is fulfilled the assertion fails.
    */
-  rejects: Matchers<Promise<void>> & Inverse<Matchers<Promise<void>>>;
+  rejects: Matchers<Promise<void>, E> & Inverse<Matchers<Promise<void>, E>>;
   /**
    * Unwraps the value of a fulfilled promise so any other matcher can be chained.
    * If the promise is rejected the assertion fails.
    */
-  resolves: Matchers<Promise<void>> & Inverse<Matchers<Promise<void>>>;
+  resolves: Matchers<Promise<void>, E> & Inverse<Matchers<Promise<void>, E>>;
 };

-export interface Matchers<R extends void | Promise<void>> {
+export interface Matchers<R extends void | Promise<void>, E = unknown> {
   /**
    * Ensures the last call to a mock function was provided specific args.
    */
@@ -152,7 +152,7 @@ export interface Matchers<R extends void | Promise<void>> {
    * Checks that a value is what you expect. It calls `Object.is` to compare values.
    * Don't use `toBe` with floating-point numbers.
    */
-  toBe(expected: unknown): R;
+  toBe(expected: E): R;
   /**
    * Ensures that a mock function is called.
    */

Most probably you should build the repo and all will work.
By the way, to test the change you should write type tests. The type tests for matchers live here: packages/jest-types/typetests/expect.test.ts
To run them, build the repo and run yarn test-types. Remember to rebuild after making changes.

One use case which looks problematic: expect('abc').not.toBe(123). I mean, the .not modifier is a problem. It would be possible to pass unknown to the inverse matchers as a type of received value. That solves the case, but why not to provide a mechanism of type safety for the inverse matchers as well?
For example, here is what @types/jest does: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/3fa56f312fa13d9546ba1745026ee009991bd3c8/types/jest/index.d.ts#L813
Usage example:
expect('abc').toBe<string>('abc');
expect('abc').not.toBe<number>(123);

This approach works for many other matchers too (just look through @types/jest code).
Is it really useful? Is it worth to spend time implementing? These are other questions.

Is it really useful? Is it worth to spend time implementing? These are other questions.

i can't really think of a use case where you'd want to explicitly specify the generics for non-matching types as i can't see how it provides any additional safety. imo in those cases using unknown is fine

not stale

Similar change was made in @types/jest some time ago and had to be reverted. For discussion see https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/62128

to address some of the points mentioned in that discussion:

i think many of the issues people have with it can be easily solved by explicitly widening/narrowing the type:expect("foo").toBe<number | string>(1)
// or you could just "as" easily cast it:
expect("foo").toBe(1 as number | string)

i'm convinced this is more of an edge case and that people who want to compare non-matching types should just do this. the benefits of having type safety for the other 90% of cases far outweighs it imo.
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47020 changed more than just the toBe method. it also changed toHaveBeenCalledWith and toHaveReturnedWith which caused issues with overloads due to limitations in typescript so i agree that those particular methods should probably stay as is until a better solution can be implemented

however if this really is too big of a breaking change, i would suggest making a new typesafe api while keeping the old one, like what dart is doing

Would you agree that vscode-jest satisfies both sides?

do you mean how it runs the tests on each change? idk, i often turn that off because it can be resource-intensive to be running tests constantly. i always think it's better to see type errors before having to run any code, which is kinda the point of using typescript in the first place
it also wouldn't pick up cases where for example a function that works properly at runtime could have the incorrect type at compiletime
// foo.d.ts
export declare const doThing: () => number // wrong type

// foo.js
export const doThing = () => 'asdf'

// foo.spec.ts
import { doThing } from './foo'
test('doThing', () => {
    expect(doThing()).toBe('asdf') // no compile error or runtime error
})

Usually I run slow e2e tests separately from unit tests. In this setup vscode-jest could be told to rerun only unit tests.

The other problem you talk about needs a type test. In Jest repo we run type tests via jest-runner-tsd and there are 1000+ assertion at the moment. These prevent type regression very effectively.
I understand that the line between TypeScript and JavaScript is very thin, but look at Jest website: "Jest is a delightful JavaScript Testing Framework". It does not sound like Jest promised to check your types. The point is that Jest should allow everything what JavaScript allows and test only the logic of your code. So seeing no error in your example is correct.

Perhaps a custom transformer is a solution? The TS Compiler API allows custom module resolution. It is pretty simply to make it load something else instead of import from @jest/globals. Add some option to ts-jest to toggle that and you have strict checks. (I talk about ts-jest, because it checks types and it uses the Compiler API already.)
@CreativeTechGuy ping. We had similar discussion in https://github.com/DefinitelyTyped/DefinitelyTyped/pull/63610

Actually, no need to have any option or to wrestle with the Compiler API:
import {expect} from 'ts-jest/strict-globals';

Not stale

Not stale

Not stale

i really think this issue needs to be addressed. jest's assertion library is used by many other testing tools, so this problem comes up in many different places.

Usually I run slow e2e tests separately from unit tests. In this setup vscode-jest could be told to rerun only unit tests.

https://github.com/microsoft/playwright/issues/22371
expect(page.locator('li').count()).toBe(2) //comparing Promise<number> to number

this is just one example where the error could easily be caught at compiletime, but it isn't. playwright isn't just used for e2e tests either (see https://playwright.dev/docs/test-components)

I understand that the line between TypeScript and JavaScript is very thin, but look at Jest website: "Jest is a delightful JavaScript Testing Framework". It does not sound like Jest promised to check your types.

times have changed since that was written. typescript is the standard now, and i can't think of any excuse to not be using it over javascript in the current year. so many "typescript-first" projects use jest's assertion library under the hood, so it seems a little counter-productive to not support it properly.

"Jest is a delightful JavaScript Testing Framework". It does not sound like Jest promised to check your types. The point is that Jest should allow everything what JavaScript allows and test only the logic of your code. So seeing no error in your example is correct.

@mrazauskas I feel that this comment is somewhat misguided, if an end user is using JavaScript, then they will not see any TypeScript type errors, if the user has opted into using TypeScript then they explicitly want to see type errors and expect the language to behave in the most useful way possible (showing type errors where available). To opt out of type correctness in this one example seems to go counter to the concepts of typing asnd type safety in general.
FYI, Kotlin uses this tight strictness for assertions: https://kotlinlang.org/api/latest/kotlin.test/kotlin.test/assert-equals.html
Dart uses this tight strictness for assertions: https://github.com/dart-lang/test/issues/1735#issuecomment-1168784434

Changes in this repo will have no effect on  Playwright’s .toBe() typings, because they keep a hard copy here:
https://github.com/microsoft/playwright/blob/da87a0af76d244b977a13702dff86a004890ba99/packages/playwright-test/types/test.d.ts#L3816

After #13848 it should be possible to redeclare matcher typings as strict as you like them. (Not sure if that will work for Playwright.)

Changes in this repo will have no effect on Playwright’s .toBe() typings, because they keep a hard copy here:

i mean it won't have an immediate effect but if they're copying jest's assertion library it's reasonable to assume they will eventually update it with upstream changes. otherwise they wouldn't close issues that suggest changes to it

Not stale

Not stale

Not stale

Just use typed-jest-expect. "Elegant jest.expect typings for a more civilized age", as they say. Currently 48 weekly downloads.


Unused/duplicate dependencies?

Hi,
Is this intentionally downloading a bunch of nvidia_* dependencies?
https://github.com/h2oai/h2ogpt/blob/0fec9b830caf4307d5263cc60fcfc83e5bc4e85c/README.md?plain=1#L144
Collecting nvidia-cuda-nvrtc-cu11==11.7.99 (from torch==2.0.1->-r requirements.txt (line 9))
  Downloading nvidia_cuda_nvrtc_cu11-11.7.99-2-py3-none-manylinux1_x86_64.whl (21.0 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 21.0/21.0 MB 6.0 MB/s eta 0:00:00
Collecting nvidia-cuda-runtime-cu11==11.7.99 (from torch==2.0.1->-r requirements.txt (line 9))
  Downloading nvidia_cuda_runtime_cu11-11.7.99-py3-none-manylinux1_x86_64.whl (849 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 849.3/849.3 kB 6.1 MB/s eta 0:00:00
Collecting nvidia-cuda-cupti-cu11==11.7.101 (from torch==2.0.1->-r requirements.txt (line 9))
  Downloading nvidia_cuda_cupti_cu11-11.7.101-py3-none-manylinux1_x86_64.whl (11.8 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 11.8/11.8 MB 6.1 MB/s eta 0:00:00
Collecting nvidia-cudnn-cu11==<IP_ADDRESS> (from torch==2.0.1->-r requirements.txt (line 9))
  Downloading nvidia_cudnn_cu11-<IP_ADDRESS>-2-py3-none-manylinux1_x86_64.whl (557.1 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 557.1/557.1 MB 3.9 MB/s eta 0:00:00
Collecting nvidia-cublas-cu11==<IP_ADDRESS> (from torch==2.0.1->-r requirements.txt (line 9))
  Downloading nvidia_cublas_cu11-<IP_ADDRESS>-py3-none-manylinux1_x86_64.whl (317.1 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 317.1/317.1 MB 4.6 MB/s eta 0:00:00
Collecting nvidia-cufft-cu11==<IP_ADDRESS> (from torch==2.0.1->-r requirements.txt (line 9))
  Downloading nvidia_cufft_cu11-<IP_ADDRESS>-py3-none-manylinux1_x86_64.whl (168.4 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 168.4/168.4 MB 5.1 MB/s eta 0:00:00
Collecting nvidia-curand-cu11==<IP_ADDRESS> (from torch==2.0.1->-r requirements.txt (line 9))
  Downloading nvidia_curand_cu11-<IP_ADDRESS>-py3-none-manylinux1_x86_64.whl (54.6 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 54.6/54.6 MB 5.7 MB/s eta 0:00:00
Collecting nvidia-cusolver-cu11==<IP_ADDRESS> (from torch==2.0.1->-r requirements.txt (line 9))
  Downloading nvidia_cusolver_cu11-<IP_ADDRESS>-2-py3-none-manylinux1_x86_64.whl (102.6 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 102.6/102.6 MB 5.4 MB/s eta 0:00:00
Collecting nvidia-cusparse-cu11==<IP_ADDRESS> (from torch==2.0.1->-r requirements.txt (line 9))
  Downloading nvidia_cusparse_cu11-<IP_ADDRESS>-py3-none-manylinux1_x86_64.whl (173.2 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 173.2/173.2 MB 5.3 MB/s eta 0:00:00
Collecting nvidia-nccl-cu11==2.14.3 (from torch==2.0.1->-r requirements.txt (line 9))
  Downloading nvidia_nccl_cu11-2.14.3-py3-none-manylinux1_x86_64.whl (177.1 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━╸━━━━━━━━━━━━━━━━ 105.1/177.1 MB 6.1 MB/s eta 0:00:12

It's a lot of wasted bandwidth and server capacity (and waiting) for someone with no Nvidia GPU or too little RAM. Are these dependencies required even on systems with no Nvidia GPU?
I also noticed for example Arxiv dependencies getting installed:
Collecting arxiv==1.4.7 (from -r reqs_optional/requirements_optional_langchain.gpllike.txt (line 1))
  Downloading arxiv-1.4.7-py3-none-any.whl (12 kB)

Even though instructions below explain how to install them separately:
https://github.com/h2oai/h2ogpt/blob/0fec9b830caf4307d5263cc60fcfc83e5bc4e85c/README.md?plain=1#L145-L146
Just wondering. :-)

As for the apt-get stuff, that's required system packages that support some pip packages for those optional aspects.  pip packages often don't contain everything they need.
I'll add the --index-url https://download.pytorch.org/whl/cpu to the readme.


Projs

add some more projects

👷 Deploy Preview for eesg processing.

Name
Link

🔨 Latest commit
b2f1a8140dfa6fa82f9acfdd583538f026918376

🔍 Latest deploy log
https://app.netlify.com/sites/eesg/deploys/6287187cca508e00093d25cb


Auto  default placements scenario for shared compute & BYO

Please ask your team peer to review your test case first. Once your team peer add /lgtm label for your PR, please ask the repo Maintainers to have a review and /approve it. Thanks!

Before asking others to review your code, please check if your code follows these rules

Your PR Description
Automate validating default placement creation using BYO & SharedCompute
Case: https://polarion.engineering.redhat.com/polarion/#/project/OSE/workitem?id=OCP-52823
If your run your cases in local, please paste logs here.

$ ./bin/extended-platform-tests run all --dry-run|grep |./bin/extended-platform-tests run -f -
[knarra@knarra kcp-tests]$ ./bin/kcp-tests run all --dry-run | grep "Verify default placements" | ./bin/kcp-tests run -f -
started: (0/1/1) "[area/transparent-multi-cluster] Author:knarra-Critical-[Regression] Verify default placements [Suite:kcp/smoke/parallel]"

INFO Oct  4 17:52:56.630: kube-apiserver version: v1.24.3+kcp-v0.8.2-7-g385ef4a7ef73fb
INFO Oct  4 17:52:56.631: Cluster IP family: ipv4
[BeforeEach] [Top Level]
  /home/knarra/automation/Openshift/kcp-tests/test/extended/util/test.go:53
[BeforeEach] [area/transparent-multi-cluster]
  /home/knarra/go/pkg/mod/github.com/!phaow/kubernetes@v0.6.2-kcp/test/e2e/framework/framework.go:154
STEP: Creating a kubernetes client
[BeforeEach] [area/transparent-multi-cluster]
  /home/knarra/automation/Openshift/kcp-tests/test/extended/util/client.go:223
INFO Oct  4 17:52:56.631: Creating workspace "e2e-test-kcp-placements-7tdkk"
INFO Oct  4 17:52:58.959: Workspace "e2e-test-kcp-placements-7tdkk" has been fully provisioned.
[It] Author:knarra-Critical-[Regression] Verify default placements [Suite:kcp/smoke/parallel]
  /home/knarra/automation/Openshift/kcp-tests/test/extended/placements/placements.go:21
STEP: # Validate apibinding creation is successful in user home workspace
STEP: # Verify that default placement has been created for shared compute
STEP: # Verify that APIBinding will be annotated with workload.kcp.dev/skip-default-object-creation
STEP: # Verify creating a namespace in the current workspace
namespace/test52823 created
STEP: # Verify that it randomly select a location and bind to all namespaces in this workspace
STEP: # verify default placement has been created for BYO clusters
INFO Oct  4 17:53:06.673: Creating workspace "e2e-test-kcp-placements-grlkp"
INFO Oct  4 17:53:08.971: Workspace "e2e-test-kcp-placements-grlkp" has been fully provisioned.
INFO Oct  4 17:53:08.971: Creating namespace "e2e-ns-kcp-placements-zs24r"
STEP: # Create workload sync and generate syncer resources manifests in current workspace
STEP: # Apply syncer resources on pcluster and wait for synctarget become ready
namespace/kcp-syncer-mysyncer-ob5jpakf-33gn0ehx created
serviceaccount/kcp-syncer-mysyncer-ob5jpakf-33gn0ehx created
secret/kcp-syncer-mysyncer-ob5jpakf-33gn0ehx-token created
clusterrole.rbac.authorization.k8s.io/kcp-syncer-mysyncer-ob5jpakf-33gn0ehx created
clusterrolebinding.rbac.authorization.k8s.io/kcp-syncer-mysyncer-ob5jpakf-33gn0ehx created
secret/kcp-syncer-mysyncer-ob5jpakf-33gn0ehx created
deployment.apps/kcp-syncer-mysyncer-ob5jpakf-33gn0ehx created
INFO Oct  4 17:53:27.991: SyncTarget/mysyncer-ob5jpakf ready condition is False
INFO Oct  4 17:53:31.392: SyncTarget/mysyncer-ob5jpakf ready condition is True
STEP: # Verify that default placement has been created for BYO cluster
STEP: # Verify that APIBinding will be annotated with workload.kcp.dev/skip-default-object-creation
STEP: # Verify creating a namespace in the current workspace
namespace/test528231 created
STEP: # Verify that it randomly select a location and bind to all namespaces in this workspace
INFO Oct  4 17:53:39.043: Error running /bin/kubectl delete -f /tmp/e2e-test-kcp-placements-grlkp.mysyncer-ob5jpakf.yaml --kubeconfig=/home/knarra/Downloads/kubeconfig_412:
namespace "kcp-syncer-mysyncer-ob5jpakf-33gn0ehx" deleted
serviceaccount "kcp-syncer-mysyncer-ob5jpakf-33gn0ehx" deleted
clusterrole.rbac.authorization.k8s.io "kcp-syncer-mysyncer-ob5jpakf-33gn0ehx" deleted
clusterrolebinding.rbac.authorization.k8s.io "kcp-syncer-mysyncer-ob5jpakf-33gn0ehx" deleted
secret "kcp-syncer-mysyncer-ob5jpakf-33gn0ehx" deleted
deployment.apps "kcp-syncer-mysyncer-ob5jpakf-33gn0ehx" deleted
Error from server (NotFound): error when deleting "/tmp/e2e-test-kcp-placements-grlkp.mysyncer-ob5jpakf.yaml": secrets "kcp-syncer-mysyncer-ob5jpakf-33gn0ehx-token" not found
namespace "kcp-syncer-mysyncer-ob5jpakf-33gn0ehx" deleted
serviceaccount "kcp-syncer-mysyncer-ob5jpakf-33gn0ehx" deleted
clusterrole.rbac.authorization.k8s.io "kcp-syncer-mysyncer-ob5jpakf-33gn0ehx" deleted
clusterrolebinding.rbac.authorization.k8s.io "kcp-syncer-mysyncer-ob5jpakf-33gn0ehx" deleted
secret "kcp-syncer-mysyncer-ob5jpakf-33gn0ehx" deleted
deployment.apps "kcp-syncer-mysyncer-ob5jpakf-33gn0ehx" deleted
Error from server (NotFound): error when deleting "/tmp/e2e-test-kcp-placements-grlkp.mysyncer-ob5jpakf.yaml": secrets "kcp-syncer-mysyncer-ob5jpakf-33gn0ehx-token" not found
synctarget.workload.kcp.dev "mysyncer-ob5jpakf" deleted
[AfterEach] [area/transparent-multi-cluster]
  /home/knarra/automation/Openshift/kcp-tests/test/extended/util/client.go:211
workspace.tenancy.kcp.dev "e2e-test-kcp-placements-7tdkk" deleted
INFO Oct  4 17:53:42.516: Deleted e2e-test-kcp-placements-7tdkk, err:
workspace.tenancy.kcp.dev "e2e-test-kcp-placements-grlkp" deleted
INFO Oct  4 17:53:44.242: Deleted e2e-test-kcp-placements-grlkp, err:
[AfterEach] [area/transparent-multi-cluster]
  /home/knarra/go/pkg/mod/github.com/!phaow/kubernetes@v0.6.2-kcp/test/e2e/framework/framework.go:155

passed: (51.8s) 2022-10-04T12:23:44 "[area/transparent-multi-cluster] Author:knarra-Critical-[Regression] Verify default placements [Suite:kcp/smoke/parallel]"

1 pass, 0 skip (51.8s)

If you used the Jenkins job ginkgo-test to test your case, please paste the job link here.

@Phaow @xingxingxia could you please help review ? thanks !!

BTW please update your case Status to not stay in "Draft".

BTW please update your case Status to not stay in "Draft".

Done, Now case has been moved to Proposed State.

Run logs:
https://privatebin.corp.redhat.com/?a94299b25f740d8d#Cwpadxo142a1pYQmDzepfR5b8i9GpYeX1yrsp6vL69UF

LGTM, thank you!


"New"/"Previous" swapped in Parquet writing error message?

I think the meaning of "New" and "Previous" are swapped in this error message:
https://github.com/dask/dask/blob/master/dask/dataframe/io/parquet.py#L412-L414
I would have expected the columns already on disk (pf.columns) to be labelled as "Previous", and the data about to be appended (list(df.columns)) to the Parquet file as "New".
Just wanted to sanity check my understanding before opening a PR to change the message.

cc @martindurant
On Sat, Jun 2, 2018 at 4:22 PM, Stan Seibert<EMAIL_ADDRESS>wrote:

I think the meaning of "New" and "Previous" are swapped in this error
message:
https://github.com/dask/dask/blob/master/dask/dataframe/io/
parquet.py#L412-L414
I would have expected the columns already on disk (pf.columns) to be
labelled as "Previous", and the data about to be appended (
list(df.columns)) to the Parquet file as "New".
Just wanted to sanity check my understanding before opening a PR to change
the message.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/3553, or mute the thread
https://github.com/notifications/unsubscribe-auth/AASszAKFKG_jRAVQSV459HBVbVrFfiOQks5t4vQTgaJpZM4UX1B0
.

I don't recall anything being done, but it's been a while. The relevant code does not seem to have changed since this issue.

If you get a chance can I ask you to make a small PR to solve this?  My hope is that this would take less than five minutes.

If I trust my statement above, I can just replace New and Previous, indeed quick. Should probably spend a few minutes making sure its true!


Check argument list is complete [1-25]

Closes #11 - provides basic Python-valid checking of task signatures in calls. Both directly, and within a nested task.
This also adds a series of minor CI fixes that arose during implementation, to ensure tests and static checking is thorough and passes.

Aside from a potentially missing test, this seems reasonable.

Given that call is going away in a stacked PR anyway, I'll take that as good to go?


voc-->coco format conversion bug(?)

I've tried converting the voc data to coco format like belows.
$ datum import -i /mnt/hdd1/voc/VOCdevkit/VOC2012_detection/ -o prj-voc -f voc
$ datum filter -p prj-voc/ -e '/item[subset="train"]' -o prj-voc-train
$ datum export -p prj-voc-train/ --format coco -o voc-coco-train -- --tasks instances --save-images
$ datum project import -i voc-coco-train/ -f coco -o prj-voc-coco-train

For your information, "VOC2012_detection" is the same as VOC2012 except "ImageSets" folder.
ImageSets/
└── Main
    ├── train.txt
    └── val.txt

I've compared the distribution of bbox labels using validator, and I found that they're not same.
$ cd prj-voc-train/
$ datum validate detection
$ cd ../prj-voc-coco-train/
$ datum validate detection

from prj-voc-train
        "label_distribution": {
            "defined_labels": {
                "aeroplane": 470,
                "background": 0,
                "bicycle": 410,
                "bird": 592,
                "boat": 508,
                "bottle": 749,
                "bus": 317,
                "car": 1191,
                "cat": 609,
                "chair": 1457,
                "cow": 355,
                "diningtable": 373,
                "dog": 768,
                "foot": 0,
                "hand": 0,
                "head": 0,
                "horse": 377,
                "ignored": 0,
                "motorbike": 375,
                "person": 5019,
                "pottedplant": 557,
                "sheep": 509,
                "sofa": 399,
                "train": 327,
                "tvmonitor": 412
            },
            "undefined_labels": {}
        },
        "total_bbox_count": 15774

from prj-voc-coco-train
"label_distribution": {
            "defined_labels": {
                "aeroplane": 0,
                "background": 0,
                "bicycle": 0,
                "bird": 5717,
                "boat": 0,
                "bottle": 59,
                "bus": 0,
                "car": 0,
                "cat": 0,
                "chair": 4022,
                "cow": 0,
                "diningtable": 150,
                "dog": 0,
                "foot": 0,
                "hand": 0,
                "head": 0,
                "horse": 0,
                "ignored": 0,
                "motorbike": 0,
                "person": 5808,
                "pottedplant": 0,
                "sheep": 18,
                "sofa": 0,
                "train": 0,
                "tvmonitor": 0
            },
            "undefined_labels": {}
        },
        "total_bbox_count": 15774

In my opinion, the labels shouldn't be changed while converting the format.
I've also checked bbox size distribution(histogram), and it's also quite different.

Hi, nice observation! Try to add --reindex 1 in coco export line to avoid confusing annotation ids in the output file.

Oh, it works! Thanks!


Angular Components - Number Input Invalid Flicker

The number-input component will show an invalid flicker in certain cases.
Steps to reproduce:

Click on the text input of the number input
Click on the increment button without entering any text in the input

You should see a flicker of invalid styling around the number input.

@cjam Do you have a fix for this?
Would this version in the new library work for you?
https://ui-components-ui-components-dev.os99.gov.ab.ca/?path=/docs/components-inputs--basic


how to export user emb and item emb

like the title,is there a script to export them

Sorry, we don't have this kind of script, you could try to save these tensors during inference.


godot 3.1.1 html5 export freeze and crash

Godot version:
3.1.1

OS/device including version:
exported on windows 10
chrome/firefox/pretty much every browser

Issue description:
exported my project to html, uploaded it to a live server, tried to load it up. browser freeze followed by browser crash(followed by browser burning)

Steps to reproduce:
seems to happen with even new empty projects, so i'm thinking its easy to reproduce.
Minimal reproduction project:

Again, you'll have to provide more information.
It's not easy to reproduce as other users aren't experiencing this same issue. Without more information it will be impossible to reproduce and so no one can help you.

No error messages in console, console won't open because the entire tab freezes on trying to load.
wait long enough and the browser will recommend killing the tab.

reloading doesnt work, nothing works since everything is frozen, but after awhile this shows up OpenGL ES 2.0 Renderer: WebKit WebGL, but still frozen. i can't even close the tab.

Hi there, I'm seeing similar issues with windows 10 3.1.1. Chrome will crash when trying to load, but firefox manages to stay alive. I've gotten different errors, depending on the game I've tried to export:
uncaught exception: abort(101). Build with -s ASSERTIONS=1 for more info. index.js:7:321101
    abort file:///C:/Users/justi/godot/exports/nineTenths/index.js:7
    b101 file:///C:/Users/justi/godot/exports/nineTenths/index.js line 96 > WebAssembly.instantiate:181195
    __ZN6Object12notificationEib file:///C:/Users/justi/godot/exports/nineTenths/index.js line 96 > WebAssembly.instantiate:272470
    _send_notification file:///C:/Users/justi/godot/exports/nineTenths/index.js line 96 > WebAssembly.instantiate:3896247
    _send_notification file:///C:/Users/justi/godot/exports/nineTenths/index.js:7
    <anonymous> self-hosted:1047

is an example error, along with:
   At: core/bind/core_bind.cpp:1755:get_as_text() - Condition ' !f ' is true. returned: String() Backromancy.js:7:32704
**SCRIPT ERROR**: Unable to iterate on object of type  Nil'. Backromancy.js:7:32704
   At: res://scripts/ItemManager.gd:19:parse() - Unable to iterate on object of type  Nil'. Backromancy.js:7:32704
**ERROR**: Condition ' !f ' is true. returned: String() Backromancy.js:7:32704
   At: core/bind/core_bind.cpp:1755:get_as_text() - Condition ' !f ' is true. returned: String() Backromancy.js:7:32704
**SCRIPT ERROR**: Unable to iterate on object of type  Nil'. Backromancy.js:7:32704
   At: res://scripts/ItemManager.gd:19:parse() - Unable to iterate on object of type  Nil'.```

I am able to successfully export to Windows (.exe) and Android. I am using the latest stable 3.1.1 export templates.

I also had the problem that the HTML5 export didn't work for me, for me this was due to the Physics Thread Model being set to Multi-Threaded (which I probably changed by accident when testing stuff) - so if your HTML export is not working you could also try checking that. (My situation also was that the console didn't log anything besides which Renderer was used)

Looks like my Physics threads and rendering threads are both set to single-safe. Thanks for chiming in!

Hey, ignore my errors. It turns out I wasn't including *.json in my HTML5 export (but of course was for android and windows). Everything seems to be working swimmingly. Sorry for highjacking this thread.

@NetroScript
This was exactly my issue, thank you for the fix!

Moving discussion to #29641 then , I'll work on a fix for it, shouldn't be too hard.


fix logic mistake in optimization commit

https://github.com/octolab/Cleaner/commit/0c5bc8011d9393e3df33ffb6f5fb99416a08fee0#commitcomment-17695325

reverted by cbd28778f40a04abcf804a38ff703f6c1146f40c


Weapons without hold fire only shoot once.

As the title says, weapons that do not continuously fire when you hold the attack button only fire once and won't hit multiple targets. I made a little clip showing what I mean here: https://www.youtube.com/watch?v=IGdSJu5Pyq4
The weapon I was using was from the Breen's Private Reserve mod, and most of the automatic weapons from that mod seem to work well enough (most).

first of all disable sv_tfa_soundscale
second i'll check it out


Superfluous horizontal scrollbar is shown for hover dialog boxes

monaco-editor npm version: 0.7.0
Browser: IE11/Edge 14
OS: Windows 10 Version 1607
Hi,
I noticed that after updating the Monaco Editor to Version 0.7.0, IE11 and Edge sometimes show a horizontal scroll bar when hovering over variables in TypeScript Mode.

Open https://microsoft.github.io/monaco-editor/index.html with IE11 or Edge 14
In the Monaco Editor, scroll down to line 111
Hover on canvas
Notice that the dialog box has a horizontal scrollbar with which you can scroll 1 pixel:

This does not occur on Chrome or Firefox.
Thanks!

fyi @joaomoreno

Moved to Microsoft/vscode#14541


HPC-9030: Upgrade to Typescript 5

Blocked on #365

I thought this was blocked on Nx upgrade happening in #365, but it turns out that Typescript got updated to latest v5 in that PR too.


Libraries nonfunctional buttons

The Libraries list, grid, and GitHub buttons are non-functional.

This was a duplicate of another issue that's been closed so closing this one.


[New Feature]:  Would u like to add preloader?

🎮 feature Request
feature logic and basic description
A preloader is an essential interface element that appears on a web page while its content is being loaded. It serves as a visual cue to users, letting them know that the website is actively processing data and hasn’t crashed.
Point down the features
feature points
1.User Experience Enhancement
2.Visual Feedback
3.Customization
4.Responsive Interaction
Feature:
https://github.com/GameSphere-MultiPlayer/Physi-c-Tech/assets/154777864/7ef2cd29-dc32-44db-9225-81f4d28bdc45
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hi @Anjaliavv51,
Pre loader is nice just can we have the chrome gaming gif in it, It will look cool.
Thank You

If you have any doubt you can directly send message on our discord (https://discord.gg/rZb46cCMmK), we have created seprate chennals for all projects...
Thank you :)

issue is done please check PR #169
Added Code!


File system prep for web variable view

This PR tries to provide a web version of the FileSystem class, and to move the platform/common/constants.node.ts to a file I'm calling namespaces.ts which is platform agnostic.
I'm thinking I could write this in several ways, so instead of leaning towards a direction, I want your feedback:
Now that you have this PR, how would you approach the changes being referenced? would you do something else?

Got some awesome feedback over Slack as well. Sharing here to keep it on record:
Rich:

Don’t use fsPath or path at all. Just use URIs by themselves and the uri path manipulation functions to add/remove stuff from them. Then you don’t have to worry about separators.
Or about creating Uri.file items. Because everything starts from some other root URI.

Ian:

Basically any time you see raw string paths, string path comparisons, manipulations, ect… then you probably need to replace that with Uris. Rich already did a big pass on this previously, it’s big part of the web work.

Thank you both! That really simplifies things

Closing this. I'll be able to re-construct it in a cleaner way afterwards.


Add cancellationToken to Subscribe in "Code First"

Product
Hot Chocolate
Is your feature request related to a problem?
Heya!
It seems there is no extension to have a cancellationToken with .Subscribe' on "code first". Like we do for .Resolve` for example.
It could look something like that:
        descriptor
            .Field("somethingCreated")
            .Subscribe(async (context, ct) =>
            { ...

Am i missing something?
Should this be added as well? It would be useful especially to send that cancellationToken to pass it to ISourceStream down the line.
Thanks!
The solution you'd like
        descriptor
            .Field("somethingCreated")
            .Subscribe(async (context, ct) =>
            { ...

context.RequestAborted


fix(TFD-4863/TFD-4864): PubSub credentials/topic operation issues

What is the current behavior? (You can also link to an open issue here)
PubSub run on dataflow still finding service account for credential
create_if_not_exists: PubSub throw exception when create table but table exists
drop_if_exists_and_create: PubSub throw exception when drop table but table not exists
What is the new behavior?
any PubSub client run dataflow use default credential
correct create/drop operation
Please check if the PR fulfills these requirements

[ ] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: success :star:
Sonar results


Chip scope isn't accessible from template if model is instantiated as empty array (Angular 1.5+)

I'm unsure if this is an Angular issue or if this is something on angular-chips' side. I noticed when you instantiate the model to be used by angular-chips as an empty array, any new chips won't actually show their values. See http://codepen.io/anon/pen/ONBxPX. Instant update: after checking to verify, I noticed this is also the case when not assigning a model to be used at all, probably because you also substitute the model with an empty array.
I've personally worked around this by instantiating the array with values in it, and using timeout to wait one digest cycle before clearing the array again, like so:
    Archive.filterTypes = [''];
    $timeout(function() {
        Archive.filterTypes = [];
    });

It isn't pretty, but it works.
Hope this can get fixed!

Hi Mark,
I am happy to see the first bug. thanks for creating this bug. I'll check and let you know very soon.

Hi Mark,
I am happy to see the first bug. thanks for creating this bug. I'll check and let you know very soon.

Same issue here

Fixed. Please check the latest release v1.0.3
http://codepen.io/mohbasheer/pen/NNEaWr

Only just got around to checking it out, works perfectly! Thanks for the effort.


Reserved

This issues/PR id has been reserved for the following reason(s):

Actions think's we're using it.

fixed with merging 6-9-6-9#1

fixed with merging 6-9-6-9#1


⚠ Spryr has degraded performance

In 53921d7, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3731 ms

Resolved: Spryr performance has improved in 6e5147a after 35 minutes.


add notice to check out carpentries blog

@libcce please review and merge

Looks good, merging. Thanks!

Actually, @fmichonneau @kariljordan @serahrono, this statement takes up a lot of real estate:


Strict mode?

Node v9.9.0 introduced some changes into the assert package. Most notably the introduction of strict mode.
Would you accept a PR introducing this new functionality and bringing this module up to date?

If it simplifies the maintenance burden on your end @defunctzombie  - how would you feel about moving this repo to the browserify org?

@jprichardson I'd be open to that (clearly I have let this module go by the wayside) - what would that require logistically?

I think you'd have to grant ownership of the project to somebody who is an admin in the browserify org, which would include both me and @jprichardson

@calvinmetcalf you are already listed as a collaborator on the repo - is there some other action that "grants ownership" ?

i just invited you into the browserify org

@calvinmetcalf Should I see a notification somewhere for that? I received no email about it.

I tried to invite you again @defunctzombie. Looks like you were invited by Substack awhile ago. See if you can visit this link: https://github.com/organizations/browserify/settings/profile and if there is something about accepting the invite.

@jprichardson I get a 404 when I visit that link.

@defunctzombie I canceled the invite, and then invited you again. Any email now...?

@jprichardson @calvinmetcalf repository transferred. Feel free to remove me from the browserify organization.

Any updates on this issue?


Feat/language resolution

Server side language resolution
Pull Request Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

PR Checklist

[ ] The commit message follows our guidelines included in the CONTRIBUTING.md
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Relevant CHANGELOG is updated

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

57 of 69 (82.61%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.2%) to 81.42%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/lib/extract-language-context.ts
13
17
76.47%

src/config.ts
6
14
42.86%

Totals

Change from base Build<PHONE_NUMBER>:
-1.2%

Covered Lines:
465

Relevant Lines:
539

💛  - Coveralls


Support clone filter

Feature Description
When trying to execute following command receive error:
git clone --filter=blob:none --no-checkout https://XXXXX
Error: filtering not recognized by server, ignoring
Running Gitea 1.15.6
Git: 2.33.1
Screenshots
No response

you can enable this git feature by run git config --global uploadpack.allowFilter true on the server.

That worked, thank you


feat(common): add tag! macro

What does this PR do?
This does a few things:

Creates a tag! macro which does compile-time checking for some invariants.
Changes a Tag to use Cow<'static, str> instead of a String.
Makes Tag::from_value private. Use tag! if the key and value are known at compile-time. If not, use Tag::new.

Motivation
As libdatadog usage has grown, we have more Rust users of the lib and therefore more static Rust strs we can trust at compile-time and avoid runtime allocations.
Additional Notes
This was previously stacked on another PR, but not anymore.
How to test the change?
Everything should run as normal. It's recommended to use tag! over Tag::new if the key and value are both static strs.

This is cool.


README.md: use open source Travis link and badge

thanks @nickmerwin - for the patch. Can you please fill out the CLA agreement
http://twitter.github.io/heron/docs/contributors/community/
for submitting the patch? It is pretty straight forward.

@kramasamy done! Thanks.


Add auto path completion to the command line and the address bar

https://github.com/VioletGiraffe/file-commander/pull/229

@sclown: great work, thanks! :)

Sorry about missing changes in the project file


[Feature-1620][admin] Integrate Casdoor for SSO

add casdoor login support SSO

This closes #1620
Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

@aiwenmo Excuse me, what is this question

@aiwenmo Excuse me, what is this question

this is github action's problem, wait for a moment, fixing it.

@aiwenmo Excuse me, what is this question

hi,  @gaopeng666  ,thank you very much for your pr, please add postgre's ddl/dml and h2's ddl/dml

@aiwenmo Excuse me, what is this question

hi, @gaopeng666 ,thank you very much for your pr, please add postgre's ddl/dml and h2's ddl/dml

Then please provide the design of the front-end page

@aiwenmo Excuse me, what is this question

hi, @gaopeng666 ,thank you very much for your pr, please add postgre's ddl/dml and h2's ddl/dml

Then please provide the design of the front-end page

ok, i will add


Reset velocity and constraint jAcc when body type changes to DYNAMIC

A fix for https://github.com/slembcke/Chipmunk2D/issues/238

Another minor issue to point out with this is that if you are adding constraints between non-dynamic bodies, they don't do anything except consume CPU time generating unused NaNs. The client code already needs to be adding and tracking a list of constraints somewhere, all they need to do to fix this is to remove the constraints when making the body static.
I don't doubt that this patch works, but I think I need some more convincing that adding this workaround is worth it as, again this is the first time in 15 years I've heard of someone wanting this.


Skip iterations without nodes when looking for next node in repeated sections - #2234

This looks for the next iteration after the target index that actually has a node.


Online resize memory for VM

Author Name: Stefan Kooman (Stefan Kooman)
Original Redmine Issue: 3954, https://dev.opennebula.org/issues/3954
Original Date: 2015-08-28

QEMU/KVM/LIBVIRT offer the possibility to resize the amount of memory when in the libvirt XML specification the  is specified besides the "" for a running VM. For example:
1048576
4194304
This Would set the amount of available memory for a VM to 1 GB, with a max of 4GB. If OpenNebula would generate deployment files with both memory specifications VM's can be resized online (without) downtime as far as memory is concerned.

Original Redmine Comment
Author Name: Stefan Kooman (Stefan Kooman)
Original Date: 2015-08-28T08:00:58Z

related to [[http://dev.opennebula.org/issues/3395]] VM capacity resize for running VMs

Original Redmine Comment
Author Name: Roy Keene (Roy Keene)
Original Date: 2017-06-27T15:36:53Z

Perhaps a better approach:  https://medium.com/@juergen_thomann/memory-hotplug-with-qemu-kvm-and-libvirt-558f1c635972
This is similar to what VMware does with ESXi, though libvirt makes you do more work to figure out how to manage your DIMMs.

Currently working on it for next version on #1660 Closing this one


[bug]: "The component was not found. It may not exist at the registry. Please make sure it is a valid component."

Describe the bug
I was putting my v0 code in to cursor AI and it gave me this error after doing the whole procedure thing. I have searched for how to fix this, but all of them are not helping. Please if someone could give me a few minutes of their time, I would be really thankfull.

Affected component/components
styles
How to reproduce
npx shadcn@latest and add the v0 codebase
Codesandbox/StackBlitz link
No response
Logs
No response
System Info
windows 10? idk what to put here

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

Same issue and i can't go to https://ui.shadcn.com/

Same issue when i try to add a component and i can't go to https://ui.shadcn.com/ website

Yes, this issue persists every time I attempt to execute the command for adding any of component. It appears that the problem arises consistently with each and every component.

same issue

Same issue when i try to add a component and i can't go to https://ui.shadcn.com/ website

Yes, this issue persists every time I attempt to execute the command for adding any of component. It appears that the problem arises consistently with each and every component.

Oh! After try a lot of ways so i saw that some location hardly to access this website or fail when add more a components. Then try to use vpn then i was fix this


Adds HikariCP (#639)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


recap.email: Get pacer_case_id from case URL when there is no attached document

In https://github.com/freelawproject/courtlistener/issues/2571 we're adding minutes entries that don't contain an attached document URL.
So in this PR  when no document URL is available the pacer_case_id is retrieved from the Case URL instead.

This works for NEFs and NDA's minute entries.
There are NEFs with multiple minute entries. In these cases, the pacer_case_id is retrieved from the Case URL corresponding to every case mentioned in the notification.

LGTM, thank you!


Style/AccessModifierDeclarations wrong offense detected

Expected behavior
No offense detected.
Actual behavior
Offence detected.
Steps to reproduce the problem
code
class Hoge
  attr_reader :size
  attr_reader :density
  attr_reader :public

  def initialize(size:, density:, public:)
    @size = size
    @density = density
    @public = public
  end

  def perform(users)
    ::ActiveRecord::Associations::Preloader.new.preload(users, :avatar_photo, Attachment.all)

    users.each do |user|
      fulfill(user, user.decorate.avatar_image(size: size, density: density, public: public))

    end
  end
end

rubocop log
> bundle exec rubocop
hoge.rb:18:86: C: Style/AccessModifierDeclarations: public should be inlined in method definitions.
      fulfill(user, user.decorate.avatar_image(size: size, density: density, public: public))
                                                                                ^^^^^^

rubocop setting
〜
Style/AccessModifierDeclarations:
  EnforcedStyle: inline

RuboCop version
> bundle exec rubocop -V
0.74.0 (using Parser <IP_ADDRESS>, running on ruby 2.5.1 x86_64-darwin18)

Thanks for the feedback. I opened a PR #7327.

Cool! 🆒  Thanks! 👍


Removing ending dequeuing spinloop?

From reddit:

I see you use a spin loop in dequeuing. This reminds me of this conversation about Flume using a spinlock, and how that fights with the system scheduler...

Quick benchmark shows no performance difference without this spinloop, so it may be removed. By the way, there are additional backoff in synchronized implementation (which should explain why there is no difference with or without this particular spinloop)

Spin loops has been kept for performance, see #9


Does it support a complete satis.json?

Hey,
in the README you say "like satis".
I ask myself if synopsis support a complete satis.json inkl. all settings like dist support?
It is possible to list the supported features or limitations?

@andygrunwald I use only some of them, this is my config.json:
{
"name": "My Repository",
"homepage": "http://packages.example.org",
"archive": {
"directory": "dist",
"skip-dev": false
},
"repositories": []
}
This is all supported params for now. I used this params before, even when i used satis. But if you use something else, i can add them, just tell me.

My current statis.json looks like:
{
    "name": "My Repository",
    "homepage": "http://packages.example.org",
    "require-all": true,
    "require-dependencies": true,
    "archive": {
        "directory": "dist",
        "format": "tar",
        "skip-dev": true
    },
    "repositories": [
        {
            "type": "git",
            ....

So archive.format, require-all and require-dependencies support seems to be missing.

No, unfortunately, this not supported yet. Archive format only zip and require-* not supported in full. As soon as possible i'll add this and another main configuration params. I have to update РЕАДМЕ so as not confuse people, sorry.

Just updated README and fix some satis config params.


Multi Rotor SUTD (MRS) 5th row Intro Session

Session Name
Multi Rotor SUTD (MRS) 5th row Intro Session
Abstract
Learn more about MRS and drones, and design your own over 3 days!
Student Organisation organising this session
Multi Rotor SUTD
Event Format
Physical
Session intent (what to expect)
Participants will get to know about the club and what we do
Participants will learn more about drone design and how drones work
Participants will learn soldering, CAD and drone flying
Session details
Number of participants: 10
Location: Arms VI / MRS Discord
Timing: 14,21,28 sept 4-6pm, 7-9pm (5 per session due to SMM)
Let us know the number of participants you can handle and where you intend to hold it.. If you have any constraints on the timing or any other matters, do specify as well (We are only able to help with booking of common rooms such as Thinktanks, no guarantee that these rooms will be available too, do indicate if you would like us to book for you! )
Speakers/Workshop facilitators
Sean Yeo, President

2nd runner up in SAFMC D2 (Fully Autonomous) and AAVC 2020
Ramen connoisseur

Tham Jit, Vice-President

2nd runner up in SAFMC D1 (Semi Autonomous), 11st place in SAFMC C2 (FPV)
can drive car and fly drone

Kristabel Lim, Treasurer

2nd runner up in SAFMC D1 (Semi Autonomous) and AAVC 2020
Dedicated night owl

Sign up link(if any)
https://forms.office.com/Pages/ResponsePage.aspx?id=drd2NJDpck-5UGJImDFiPRw41Mm-SPpJoCNctLlRifZUM1lXQkhLSUhaTkkxSDFQRjFSQk5DUzhSTi4u
Logistical details / Budget Needed
4x Plywood 960mm x 610mm (~50) - Ban Heng Leong Trading
Fablab laser access
M3x6 Screw x100pc (2x$23.02) - https://sg.rs-online.com/web/p/socket-screws/0280981/
M2x6 Screw x50pc ($48.51) - https://sg.rs-online.com/web/p/socket-screws/0293280/
email<EMAIL_ADDRESS>

Hey @asdfash thanks for the submission of event proposal, we will get back to you regarding the fablab access.

Hi @asdfash  ,
Note that you are expecting 10 pax including facilitators for the event. May I know what is the estimated number of facilitators?
Would be great if you could let me know soon.
Thank you xx

Dear @asdfash    Your event has been approved by the school admin.
Additionally, your budget request of $121.53 has been allocated $60.77 as half of your sessions are within lesson timings.
Wishing you a smooth and successful event!


Middle-button mouse paste doesn't work on the console

From<EMAIL_ADDRESS>on 2011-05-13T03:13:37Z
Middle-button mouse paste (X-windows on Linux) does not work on the console pane.  It does work on the editor pane.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=653

From ccordoba12 on 2011-05-15T19:40:47Z
Labels: Cat-Console

From ccordoba12 on 2011-05-15T08:17:47Z
Thanks for the report Dallas!
Summary: Middle-button mouse paste doesn't work on the console

From<EMAIL_ADDRESS>on 2011-10-04T10:40:04Z
Confirmed that double middle mouse click does paste into console.  Thanks.

From<EMAIL_ADDRESS>on 2011-10-04T10:19:21Z
Did you try double clicking the middle-mouse button? Works for me on ubuntu 10.4, Spyder 2.0.12.
However, in the editor it works with a single click (which I would prefer for the console too).

From<EMAIL_ADDRESS>on 2013-02-06T00:30:06Z
If you comment out the following lines in "widgets/shell.py", it works...
# Simulating left mouse button:
#event = QMouseEvent(QMouseEvent.MouseButtonPress, event.pos(),
#                    Qt.LeftButton, Qt.LeftButton, Qt.NoModifier)

From<EMAIL_ADDRESS>on 2012-11-19T10:39:19Z
Any news on a fix to this?  Faster pasting by a single middle click will improve console productivity.  Many KVM devices have double-middle-click mapped to the switch device function, so this isn't a valid workaround.  Many thanks.

From pierre.raybaut on 2013-02-10T05:37:45Z
This issue was updated by revision 98d8d110bfab .
Status: Fixed

From<EMAIL_ADDRESS>on 2013-11-25T09:05:44Z
Silly question - but I have the opposite wish - now that this 'issue' has been fixed, I seem to end up breaking code accidentally all the time by it pasting garbage in when I don't want it to.  For a AHEM windows user (don't kill me) this is not standard - and took me a while to even work out what was going on.  Any chance this can be an option in the preference window?


Minpro

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/limingu/azure-cli-extensions.git@minpro#subdirectory=src/$EXT&egg=$EXT"

@tjprescott, can you have a look?


Map center changed switching to raster scene

I've been updating my test app to the latest version and noticed when the scene is toggled between Vector and Raster the center point for the raster scene is offset.
The scenes both point to the same assets/common/globals.yaml with the camera definition in so I expect the view to be the same.
Here is the difference pressing the button to toggle the scene makes.

The map controller center point has moved down ~10%, all mapController.setPositionEased calls go to this offset center point too.
I'm sure this didn't happen when I first created this app. This is on a Samsung S7 with Android 7.0.

User error
Removing the cameras vanishing_point: [0, -500] fixes the offset, the global was actually commented out in the Vector variants imports.


Updated integration test to use in-memory sql lite db

Looks good! I have two questions for my own understanding.

the third acceptance criteria for the issue linked to this PR states: 'Performance of the test suite improves.' Is this a measurable metric that we can confirm? or is it a consqequence of using in memory testing? hope that makes sense

When we use this factory webapplication class i can see that we open a connection to the db.context.database at line: 26, but we never explicitly close or dispose of this connection. Is it handled under the hood so to speak, or should we do it manually ?

Once again, great job

Okay, cool thanks for the extensive answer.
So just in a very practical sense for our project, the way i would be able to confirm that perfomance has indeed enhanced for our test suite would be to track how much time it takes to execute our tests when running 'dotnet test' ,for example, and then compare  it to how long it took before we switched to in-memory database
correct ?

Yes basically :)

Yeah i figured :) I was just wondering about how it would relate to our project, in a practical sense, but thanks for the answers! i will close the pull request and merge it:)


SDKMAN truncates the version number on list output

We require a conversation to take place in the appropriate Gitter Room before raising a new Github Issue. Please note that issues will be closed immediately if prior discussion did not take place. We need to do this to help manage the quality and validity of Issues raised on this project.
Please tick one:

[ ] this is a new Feature Request, a conversation was started in the Gitter CLI Development Room.
[X] this is a new Bug Report or Issue, a conversation was started in Gitter User Issues Room.

Please explain the Issue / Feature Request here:
I can reproduce this issue mentioned by @johnnybaloney in the Gitter User Issues Room chat with the actual version of SDKMAN. As you can see in the directory listing, there is a version kop-jdk1.8.0_151. In the sdk list java outout the version number is truncated, the last character is missing: kop-jdk1.8.0_151 -> kop-jdk1.8.0_15
$ sdk version
SDKMAN 5.5.15+284

$ ls -l ~/.sdkman/candidates/java/
total 0
drwxr-xr-x  18 mcpringle  staff  576 18 Okt 17:39 8u152-zulu
drwxr-xr-x  14 mcpringle  staff  448  4 Nov 16:12 9.0.1-zulu
lrwxr-xr-x   1 mcpringle  staff   51 12 Dez 18:56 current -> /Users/mcpringle/.sdkman/candidates/java/8u152-zulu
drwxr-xr-x   2 mcpringle  staff   64 31 Dez 11:29 kop-jdk1.8.0_151

$ sdk list java
================================================================================
Available Java Versions
================================================================================
   + kop-jdk1.8.0_15
   * 9.0.1-zulu
     9.0.1-oracle
     9.0.0-zulu
 > * 8u152-zulu
     8u151-oracle
     8u144-zulu
     8u131-zulu
     7u141-zulu
     6u65-apple
================================================================================
+ - local version
* - installed
> - currently in use
================================================================================

@McPringle @johnnybaloney The reason why you are seeing this long version name truncated is that the table actually holds 4 columns of versions, each column with a max width of 15 chars. An example of this would be the listing for Groovy:
================================================================================
Available Groovy Versions
================================================================================
     3.0.0-alpha-1      * 2.4.12               2.3.1                2.0.8
     2.6.0-alpha-2        2.4.11               2.3.0                2.0.7
     2.6.0-alpha-1        2.4.10               2.2.2                2.0.6
     2.5.0-beta-2         2.4.1                2.2.1                2.0.5
     2.5.0-beta-1         2.4.0                2.2.0                2.0.4
     2.5.0-alpha-1        2.3.9                2.1.9                2.0.3
     2.4.9                2.3.8                2.1.8                2.0.2
     2.4.8                2.3.7                2.1.7                2.0.1
     2.4.7                2.3.6                2.1.6                2.0.0
     2.4.6                2.3.5                2.1.5                1.8.9
     2.4.5                2.3.4                2.1.4                1.8.8
     2.4.4                2.3.3                2.1.3                1.8.7
     2.4.3                2.3.2                2.1.2                1.8.6
     2.4.2                2.3.11               2.1.1                1.8.5
 > * 2.4.13               2.3.10               2.1.0                1.8.4

================================================================================
+ - local version
* - installed
> - currently in use
================================================================================

The publish API actually does not allow publishing of versions longer than 15 characters, so perhaps we should enforce this restrictions too when adding local versions to sdkman. Either way, I don't think that this is a bug, but rather enforcement of a constraint. WDYT?

I ran into this while adding custom builds of jdk 11, I think the solution to add a constraint on the add command is best as the list view truncates but the version is still actually there.

I am currently rewriting the new (long awaited) list view. So far I've implemented it with 4 columns again, but can easily change it to have 3 columns. This will yield 5 characters for status and 21 for the version. Does it sound better?
Anyway @beckje01, I think putting a validation in place is a great idea.

I'm actually fine with any length as long as we have the validation.

Cool, I'll keep it at 14 chars across 4 columns then.


Misleading error for failed/refused XFR

It seems that the library does not evaluate the return code of the messages received during XFR transfers. When the server returns a REFUSED or SERVAIL code for an XFR query, instead of passing through the error code, an ominous "No SOA" error is returned.
dig
; <<>> DiG 9.8.3-P1 <<>> @yadifa.sidnlabs.nl types.wb.sidnlabs.nl axfr +all
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: SERVFAIL, id: 5274
;; flags: qr; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0

;; QUESTION SECTION:
;types.wb.sidnlabs.nl.		IN	AXFR

; Transfer failed.

miekg/dns

dns: no SOA

[ Quoting<EMAIL_ADDRESS>in "[miekg/dns] Misleading error for fa..." ]

It seems that the library does not evaluate the return code of the messages received during XFR transfers. When the server returns a REFUSED or SERVAIL code for an XFR query, instead of passing through the error code, an ominous "No SOA" error is returned.

Ack. That could indeed be done better. PR(s) welcome.


Default values with dots break regular expression

Default values with dots don't resolve due to a wrong regular expression:
bind: !ENV ${BIND_HOST:<IP_ADDRESS>}:${BIND_PORT:8000}

Pull request #5 solved this issue for me, please check whether this fits your needs.

Awesome, thanks! I added a few tests for such cases and created v1.0.2


when switching workspace that skip worksapces in between, add option for animations to not skip workspaces in between's window animation

Description
for example (you have windows open in between worksapce 1-10) then the animation should be sth like this:
for i in {1..10}; do hyprctl dispatch workspace $i; done

wdym?

it's dumb

if you really want that, script it yourself


[NXP] Integrating code updates for RW61X and K32W platforms

Integrating code updates for K32W0 & K32W1 platforms
Integrating code updates for RW61X & SDK 2.13.3 support
Enabling CI workflows for RW61X platform for all-clusters, thermostat, and laundry-washer applications

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.5 out of 6 committers have signed the CLA.:white_check_mark: marius-alex-tache:white_check_mark: dinabenamar:white_check_mark: marian-chereji-nxp:white_check_mark: andrei-menzopol:white_check_mark: doru91:x: chapongatienYou have signed the CLA already but the status is still pending? Let us recheck it.

This should be the last PR with a lot of changes, since we've switched to a new dev process. The upcoming updates should avoid this kind of major changes and should be easier to review. The aim is to synchronize the upstream/downstream once, such that we can enable upcoming granular updates.


operator [N] [CI] sap-data-intelligence-observer-operator (0.0.3)

Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[x] Are you familiar with our contribution guidelines?
[x] Have you packaged and deployed your Operator for Operator Framework?

[x] Have you considered whether you want to use semantic versioning order?
[x] Is your submission signed?
[x] Is operator icon set?

Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description of the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

/merge possible

/merge possible

/retest-required

/merge possible

/merge possible

/retest-required

/merge possible

/merge possible

/retest

/merge possible

/merge possible

/merge possible

@J0zi @mvalarh  Could you please review the code and merge for my recent pull request?

/retest

/merge possible

/merge possible

/merge possible


Feat/foundry checkpoint manager

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.4%) to 89.012%

Files with Coverage Reduction
New Missed Lines
%

contracts/child/ChildValidatorSet.sol
1
98.9%

contracts/libs/ValidatorStorage.sol
4
70.76%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
854

Relevant Lines:
933

💛  - Coveralls