LemonUI Menu isn't updating real-time when conditions are met.

NativeItem.Enabled has an issue where if bool checks are executed, the menu isn't updating real-time in-game.
(e.g.) if (RandomNumber == 1) { GiveSpeedToPed.Enabled = true; } else if (RandomNumber == 0) { GiveSpeedToPed.Enabled = false; }

Can you trigger the item as normal? I want to know if is a visual bug or not.


BUG when combined with Magic Items module

When this module is combined with the "Magic Items" module and a limited number of charges is put on the spell attached to the item, and the item is set to destroy itself, an error message pops up that says the following:
Uncaught (in promise) Error: The key XgBGASnpUdEGFzOT does not exist in the EmbeddedCollection Collection
[No packages detected]
at Map.get (/G:/FoundryVTT/resources/app/common/utils/collection.mjs:106)
at ServerDatabaseBackend._updateEmbeddedDocuments (/G:/FoundryVTT/resources/app/dist/database/backend/server-backend.mjs:1)
at ServerDatabaseBackend.update (/G:/FoundryVTT/resources/app/common/abstract/backend.mjs:153)
at async Socket.handleEvent (/G:/FoundryVTT/resources/app/dist/server/sockets.mjs:1)
Disabling your mod fixes the issue.

Can't replicate the error, can you pass me the actor you are using?

I'm having the same issue.

The charges setting inside the Magic Item config doesn't seem to matter.

Can you export the json of the actor (and rename with txt extension so you can upload on github) ?It's more easy for me to replicate the use case.

Weird. Things seem to be working now... Not sure if restarting the server or something fixed things? Either way, here's the actor data.
fvtt-Actor-cloevir.txt


Ability to login

Summary
I want to be able to login
Basic example
self explanatory
Motivation
I'm really trying to figure out if this is planned or not.

I can log in with a browser extension at getalby.com. It keeps you private key and allows log-in.

Right now the only way to log in is with a direct nsec private key, which I was able to get from the Android mobile app to mirror that account on the web version. For accounts that are established via metadata.nostr.com, that key doesn't seem to be available. So being able to log in through that other nostr profile seems to be impossible.

I can't seem to login in using my nsec app credentials. Do you support nsec bunker login?


RNG-177: Add stream methods to the sampler API

Coverage increased (+0.0003%) to 99.785% when pulling dc779b4a919ae88b6094ec2c8f7811e38070c3bf on aherbert:feature-RNG-177 into 0ead6fdd5ff4fc49325af9cf30b0558bde4aae6e on apache:master.


Is this repository still been maintained?

Hi team,
Can you let me know if this repository still been maintained?
Regards

Hello @pradorodriguez - yes @vladborys and I are making some updates


nginx: tls1.3 support

I'm assuming since you are running a modern enough version of ubuntu and openssl this should be fine and justwork™.
Upon further investigation it looks like testing is 18.04 and prod is only 16.04 based on other issues so consider merging this after prod moves to 18.04. Unless I am mistaken here.
Thanks!

@pushcx If running on 18.04 yet, I think this is probably an useful change as TLS1.3 is faster and less resource intensive.
If this can be tested in the test environment, that's a nice one.

Thank you for taking this on, I’m sorry I neglected it. I rolled your changes and more into 1f29bce to improve our ssl config.


[Pre-SVE] User label writing too long label

SHA: 1e3f12041013dd71a53d035dbf2f6d142fc06c4e
platform: nRF52840
all clusters app
When doing test TC-ULABEL-2.2 i wrote this command to see what happens:
./chip-tool userlabel write label-list '[{"label":"roomName", "value":"master bedroom 1"}, {"label":"orientationorientation", "value":"east"}, {"label":"floor", "value":"2"}, {"label":"roomType", "value":"bedroom"}]' 1 0
So one of labels is longer than limit (16 bytes)
I got SUCCESS and when used
./chip-tool userlabel read label-list 1 0
I got:
[1655903432.210268][17776:17781] CHIP:TOO:   label list: 4 entries
[1655903432.210275][17776:17781] CHIP:TOO:     [1]: {
[1655903432.210278][17776:17781] CHIP:TOO:       Label: roomName
[1655903432.210281][17776:17781] CHIP:TOO:       Value: master bedroom 1
[1655903432.210284][17776:17781] CHIP:TOO:      }
[1655903432.210288][17776:17781] CHIP:TOO:     [2]: {
[1655903432.210291][17776:17781] CHIP:TOO:       Label: orientationorien
[1655903432.210295][17776:17781] CHIP:TOO:       Value: east
[1655903432.210297][17776:17781] CHIP:TOO:      }
[1655903432.210302][17776:17781] CHIP:TOO:     [3]: {
[1655903432.210304][17776:17781] CHIP:TOO:       Label: floor
[1655903432.210306][17776:17781] CHIP:TOO:       Value: 2
[1655903432.210309][17776:17781] CHIP:TOO:      }
[1655903432.210312][17776:17781] CHIP:TOO:     [4]: {
[1655903432.210315][17776:17781] CHIP:TOO:       Label: roomType
[1655903432.210317][17776:17781] CHIP:TOO:       Value: bedroom
[1655903432.210319][17776:17781] CHIP:TOO:      }

So the label was just cropped. Shouldn't I get some kind of error while writing instead?

Later I found Test TC-ULABEL 2.3 tries to test it but does not handle it properly. From what I found it let's you assign Label and Value that are combined not longer than 34 characters. No matter the length read displays first 16 characters from both.

In examples/providers/DeviceInfoProviderImpl.cpp we have DeviceInfoProviderImpl::SetUserLabelAt which will happily store over-size values as long as they fit in the total space it has for the TLV.  But on read we go through DeviceInfoProviderImpl::UserLabelIteratorImpl::Next which does:
    Platform::CopyString(mUserLabelNameBuf, label);
    Platform::CopyString(mUserLabelValueBuf, value);

which will silently truncate lengths.
This needs to be fixed to be spec-compliant and reject over-long things on write.

@yufengwangca @andy31415

Per Rajashree, this TC TC-ULABEL 2.3 passes on raspi , all-cluster-app. Looks like issue specific to nordic platform

I don't think it is.  I reproduced the problem on the "linux" version of all-clusters-app locally...  @cjandhyala can you please double-check with Rajashree exactly what was tested?

Sorry @cjandhyala @bzbarsky-apple my bad, As per test plan while verifying i given less than 16 byte for label attribute ...If try more than 16 to till 30 getting success response instead failure, but <30 if  I try to write getting failure response.

SDK Review: @bzbarsky-apple are you able to take a look at this when you're back? Thanks!

Note #20552 - we now fail the write, however the error code is not fully correct.


Notification error: APN invalid token

Hello, when I try to use APN Production SSL Certificate to do Push Notifications it failed and got "Notification error: APN invalid token". But if I use Development SSL Certificate it work fine!!
Did any one know what is the problem in it?
thanks a lot!!

I am facing the same issue. I get problem when I use Development SSL Certificate.

Same problem with development certificate.

Just to be sure: Are you using separate device tokens for production and development? The same device has different device tokens for different certificates. This is often a source of confusion, see https://github.com/noodlewerk/NWPusher#troubleshooting.

I'm closing the issue for now. If anyone finds this issue persists, please let me know.

I just had this happen to me. Interestingly enough, I was trying with the development certificate and I was consistently getting Invalid APN Token errors. I re-created the certificate and then exported, and it didn't work.
What I did to solve it was go and turn on Project > Capabilities > Push Notification. When I turned it on, my app wouldn't run because of entitlements so I deleted the app from the device, cleaned, relaunched and I stopped getting the errors. No idea why, but that did the trick. Hope it helps anyone that finds this thread!

same issue here

I am having the same issue, but the posts above fail to help.
I have enabled the Push Notification capability, cleaned and rebuilt, but it's not working "APN invalid token".  Could it be due to that fact that I am using

Sorry for the cliffhanger :)
I'm using VOIP and with iOS9, PushKit has now been integrated into the old remote notifications.  Could this be the sources of my issues?

I solved this by regenerate the certificate of push notification for my app id again.
(I used the wrong .p12 for another app id)


Confusing option BASE_LOGINPW

From the following: https://github.com/digitalbitbox/bitbox-base/blob/d2d75f06f7fcde655209bbb11a01faafa3fb26c1/armbian/base/build.conf#L26-L28
it would seem like this is setting the root password. However, it appears to be doing more than that. What it actually does is locking the user base if the root password wasn't set to a custom string in https://github.com/digitalbitbox/bitbox-base/blob/d2d75f06f7fcde655209bbb11a01faafa3fb26c1/armbian/base/customize-armbian-rockpro64.sh#L219-L223
When building the image, I set BASE_ADD_SSH_KEYS=true in armbian/base/build-local.conf and update armbian/base/config/ssh/authorized_keys to contain my ssh key.
I didn't assign any password to BASE_LOGINPW because all I want is to ssh with my key as base user, and this essentially locked me out.
So, it forces me to do the "unsafe" option, setting BASE_LOGINPW to a non-empty string, even though I won't use it.
Additionally, a message during the build is also confusing:
CONFIGURATION:
    USER / PASSWORD:    base / some-password
...

which would appear as if it was the base user password but in reality what it actually does later is:
+ BASE_LOGINPW_FINAL=some-password
+ echo root:some-password
+ chpasswd

I would suggest being more explicit and rename BASE_LOGINPW to something like BASE_ROOT_PASSWORD and don't conflate that option with the base user at all.

This is not an easy topic and I won't claim we have the best solution yet, so thanks already for taking the time and going through with it.
For you to use all the features of the BitBoxBase image, you'll always need to use the free open-source BitBoxApp. The build options are mostly meant for development purposes, all advanced settings can later be set in the App.
When building a production image, we don't want to know any password (be it user root or base) at all. This is why we are setting it to a random string. This is not enought, however, as we could easily learn it during the build process. Therefore, we also lock these users. This prevents anybody from logging in locally by connecting a keyboard and screen.

The BitBoxApp is required to configure all advanced settings for production images.
Users that want to gain local password login (with keyboard/screen) can "Set system password" in the App (equal to BASE_LOGINPW). The passwords for root and base are kept in sync, but the root user always stays locked. --> Local login with user base is possible.
Users that want to gain SSH access can enable "SSH password login" in the App (equals SSHPWLOGIN), configuring the sshd to accept a password (PermitRootLogin is still disabled) --> Remote ssh login with user base is possible.
Instead of using the password, when adding a SSH key (that will also be possible with the App), you can login with SSH from the start, but you still need to set the "system password" in the App to execute sudo.
To allow root ssh login (e.g. for development), you can run bbb-config.sh enable rootlogin on the command line. This is not an option we want to expose in the App. But here it's useful to already have the (locked) root password set to the "system password" and not have a separate configuration.

If I understand correctly, you'd like to build a development image and add SSH keys from the start, and already setting the "system password" for running sudo. You can do that by setting the BASE_LOGINPW:

SSH keys are added
User base password is set for sudo use
User root password is set as well, but the user is locked

The only difference to the production image is that the user base is not locked.
One thing I think that we can add quite easily is to not set the root password together with the base password (and, e.g. ask the cli user to change it when running the bbb-config.sh enable rootlogin command). Could separate the users more clearly, but is not a real security improvement in my opinion. Do you think that would be worthwile?
Having layed out our thoughts, how would you improve the build options and where do you think the documentation needs improvement?

Oh, I think I see now. So, the logic goes like this:
"BASE_LOGINPW is non-empty" -> it's a development build
"BASE_LOGINPW is empty" -> it's a production build
Essentially, BASE_LOGINPW defines the build mode? If so, it's error prone making it easier to introduce build logic mistakes, twistiing together unrelated options imho.
If the above is how it actually works, I'd suggest creating an explicit option like BASE_BUILD=dev|prod and then branching build logic off of that option, i.e. locking useres, generating passwords, stripping binaries, etc.

In other words, a related question would be: how do I know if I'm doing development or production build?

Cleaned up build configuration and added binary option BASE_PRODUCTION_IMAGE.


feat(dfdaemon): add redirect to proxy rule

Signed-off-by: inoc603<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Allow dfdaemon to redirect proxy request to another host.
Ⅱ. Does this pull request fix one issue?

fixes #1046
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Start dfdaemon with the following config:
proxies:
  - regx: google.com
    redirect: github.com

Use curl to verify that the redirect
http_proxy=<IP_ADDRESS>:65001 curl -v http://google.com

Ⅴ. Special notes for reviews

Codecov Report

Merging #1071 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1071      +/-   ##
==========================================
+ Coverage   47.15%   47.17%   +0.01%
==========================================
  Files         117      117
  Lines        7170     7174       +4
==========================================
+ Hits         3381     3384       +3
  Misses       3526     3526
- Partials      263      264       +1

Impacted Files
Coverage Δ

dfdaemon/config/config.go
100% <100%> (ø)
:arrow_up:

dfdaemon/proxy/proxy.go
12.5% <100%> (+1.28%)
:arrow_up:

supernode/daemon/mgr/scheduler/manager.go
21.91% <0%> (-0.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43953d5...8f18a26. Read the comment docs.

LGTM.


FR: code-folding

Lite XL and Pragtical seem to not support code-folding. So, none of the Lite-based code editors currently support code-folding. It seems existing lexers will need to be modified to include code-folding rules (like what of scintillua).

Code folding has been implemented, commit here plus the implementation of soft-wrap should close all the pending "basic" functionalities for a code-editor. Both features will be available in the next ecode release.


Exponential price decay contract

Adds a new Price Oracle contract that reduces the price by 50% per day for 28 days. Price starts at ~$100m USD and decays to 0.

Uses a look up table to compute the correct fractional exponent
Look up table has 16 bit resolution so there is a small error margin. 16 bit resolution gives us 1/65536 of a day, so just over 1 second per day as there are 86400 seconds per day.
Uses bit shifting to do the non-fractional exponent. E.g. 2 days will shiftRight() by 2
Negates $.37... from the starting value so we have a smooth transition to $0 after 28 days

Please expose the abi at https://github.com/ensdomains/ens-contracts/blob/master/index.js

Please expose the abi at https://github.com/ensdomains/ens-contracts/blob/master/index.js

This is done


What to expect of require within a module?

Hello folks,
Lurking around some code in some projects I found cases where require is being used inside a module/class.
In theory, that works similar to Ruby's load with an anonymous module:
# b1.cr

module B
  VERSION = "1.0.0"
end

# b2.cr

module B
  VERSION = "2.0.0"
end

# main.cr

module V1
  require "./b1"
end

module V2
  require "./b2"
end

pp V1::B::VERSION
pp V2::B::VERSION

$ crystal main.cr

V1::B::VERSION = "1.0.0"
V2::B::VERSION = "2.0.0"

This is great if you want to sandbox two versions of the same library, however, it becomes a problem when you require a common file between the two that is relative to the location of those:
# z.cr

module Z
  VERSION = "1.0.0"
end

# b1.cr

require "./z"

module B
  VERSION = "1.0.0"
end

pp Z::VERSION

# b2.cr

require "./z"

module B
  VERSION = "2.0.0"
end

pp Z::VERSION

$ crystal main.cr
Error in macro 'pp' /usr/local/Cellar/crystal-lang/0.7.5/src/macros.cr:16, line 2:

  1.
  2.     ::puts "#{ "Z::VERSION" } = #{ (Z::VERSION).inspect }"
  3.

    ::puts "#{ "Z::VERSION" } = #{ (Z::VERSION).inspect }"
                                    ^~~~~~~~~~

undefined constant Z::VERSION (did you mean 'B'?)

This is not triggered by the require, but actually by the attempt to access Z. Leaving just the require works.
Of course, if only version of B required z, it worked as expected but attempt to access Z from main results also in error (undefined constant Z::VERSION)
This problem goes away when b1.cr and b2.cr are on their own directories, each with their own copy of z.cr, and everything works:
$ crystal main.cr
Z::VERSION = "1.0.0-b1"
Z::VERSION = "1.0.0-b2"
V1::B::VERSION = "1.0.0"
V2::B::VERSION = "2.0.0"

This indicates the problem is not with require within a module/class, but actually a require of a shared file that has been already required.
Either way, since there is no documentation about this behavior, wanted to check first :smile:
Looking forward your comments.
Thank you.

Related #140 #265
I still dislike that module level require and thought we decided to drop it but can't find the discussion right now.

Thank you @jhass for the comment. Definitely this indicates there are still issues with require.
Removing that functionality will also break things like Amethyst, which is -- ahem -- abusing of this approach.
I was not able to find any prior conversation about this specific require (perhaps was on IRC?) so decided to create this issue.
Cheers.

I'd make require be an error unless used at the top-level. I have to talk about this with @waj, but I think he'll agree.

Given that require remembers the absolute path of the file, it doesn't make sense to use it inside types, defs or other expressions. This will lead to less confusion and a simpler language :-)


Added max and avg pool, alongside tests and docs

I currently use einops.rearrange so that the pooling layers and conv layers take the same tensor format as input, BCHW. For some reason lax.conv_general_dilated and lax.reduce_window are BCHW and BHWC respectively. Can do this not using einops if you would prefer to not have the extra dependency.

Also: I think the new pooling documentation needs to be added to mkdocs.yml.

Fixed the remaining typesetting mistake

I think it was actually 3.10 where they introduced using | instead of Union. Think I have squashed all the commits together, let me know if it hasn't worked.


Dropdown item onClick not firing when clicked

I'm passing down an array of items to a Dropdown component and for each I'm defining the value as a function. However, the onClick event doesn't get called when I click the item. I found that if I made a small adjustment to line 105 of Dropdown Component it works:
Current implementation:
{ className: 'Dropdown-menu__action', onClick: self.onClick.bind(self, item.value) },
Working Implementation:
{ className: 'Dropdown-menu__action', onClick: item.value },
Thanks for this nice looking UI kit!

@jonathanwmaddison thanks for raising the issue. Is it related to #191?

Can you paste a snippet of your component usage/implementation? This sounds like a props mix-up to me.

@jossmac I don't think so. I think this is related to either how I'm passing in the props or an issue with how the prop is being bound to the onClick event.
@clschnei Here you go:
    const downloadDropdown =[{         title: 'download-resume',         class: 'dropdown',         text: 'Word .doc',         value: ()=> this.toggleResumeModal(),         label: ['Microsoft Word']       },       {         title: 'download-html',         class: 'dropdown',         text: 'HTML Resume',         value: ()=>downloadInnerHtml('resume.html','resume-container','text/html'),         label: ['HTML']       },       {         title: 'download-json',         class: 'dropdown',         label: ['JSON'],         value: ()=>saveJson(this.props.user),       }     ]      ....    <Dropdown      key='dropdown'      buttonType='hollow-primary'      buttonLabel={['Download  ',<Glyph icon='desktop-download' />]}      items={downloadDropdown}      />

This definitely not a bug. So we can probably close this ticket.
But to resolve your issue @jonathanwmaddison, you have two problems:

You need to add an onSelect prop to alert the parent component that a value has been selected.
Now you can either:

call the function in your parent callback handler

handleSelect(value) {
  value() // will map to your items array "value"
}

<Dropdown onSelect={this.handleSelect} />

OR build those functions into your parent component class and use string values to direct your logic flow

Should fix your problem.

@clschnei Thank you for the suggestions and for looking at my code. Hopefully this will help other coders with the same problem, and missed how to do this.


Create balancer.js

jQuery "balancing" for block grid odd numbered blocks. This plugin will manipulate the orphans to either "center" up based off the siblings width, or span the full with in a balanced manor. This can be accomplished via setting respectSiblingWidth = false in initialization.
Example of respecting siblings. http://www.tangerineindustries.com/download/foundation-balancer/respect.html
Example of disrespecting siblings. http://www.tangerineindustries.com/download/foundation-balancer/disrespect.html

:+1:


Release V1

Issue tracking V1 release. Milestone: https://github.com/Fizzadar/pyinfra/milestone/6
Changes:

Change default value of create_remote_dir to True
Change default value of interpolate_values to False
Remove all legacy compat code (will print warning in 0.x versions)

🎉 🎉 🎉

Congratulations and thanks for your hard work!


validation add in signup page

i added validation in signup page according to signup page you can change in login page also

The latest updates on your projects. Learn more about Vercel for Git ↗
Name	Status	Preview	Comments	Updated (UTC)
gyanaguru	❌ Failed (Inspect)			Apr 10, 2023 7:40am

Please resolve the errors


Thread safety of param_constrain

Forking this issue off some discussion in #90 and something @justindomke asked me about when using JAX:
Because of the presence of an RNG in the bs_model class, it is difficult to treat it as fully thread safe.
This is only there because it is required for write_array in the Stan model class, and we furthermore know it is only really used by said function if the generated quantities block calls _rng functions in the Stan code.
Thread-safe options for this which would be relatively small changes:

Take in an int seed to each call to param_constrain, which initializes a boost:ecuyer1988 RNG, uses it once, and throws it away. This can get kind of sketchy, see recent changes in Stan: https://github.com/stan-dev/stan/pull/3168. BUT, this plays nicely with the JAX idea of vmap/pmap, etc.
Expose the ability to create an RNG object to the interface, and require that param_constrain is passed one of these if include_gq == true. Thread safety then comes from each thread having its own unique RNG object they pass in.

I think option 1 is the easiest to use, since it doesn't require you juggling this other object, but obviously has the potential to be less performant and requires some outside source of entropy to produce fresh seeds.

In fact, the argument for the RNG could accept a seed and just construct one, but then that's more branching we don't necessarily want.

You bring up a good point here which is that these are not necessarily contradictory solutions. You could have two different functions, one which accepts a pre-made RNG, and one which accepts a seed, and they both call the same underlying code with the later just creating the RNG, using it once, and throwing it away.
Unless we're opposed to having multiple ways of doing the same thing, having both seems like it would be good to cater to different kinds of users

Working through an implementation now, and I'm realizing there isn't really any reason for the Python bindings to not keep both a model and an RNG around, since the default assumption in Python is that everything is essentially in serial.
So we could keep backwards compatibility at the Python level by just storing two pointers, one to the model and one to an RNG we create at initialization time. This will look pretty transparent to the Python user, just now param_constrain will have extra arguments they can use if they were in a case where they did want to do some kind of parallel map over different seeds a-la JAX.
There's in principle no reason we couldn't do this in R as well. Julia this might not be the best idea, since threading is much more likely to occur.
I'm torn on this because it seems like something that would be very nice for users who aren't deeply concerned with threading and just want to use Bridgestan as you currently can, but the explanation of what is actually happening seems so much more difficult in that setup as opposed to the one where the source of randomness is always required.

but the explanation of what is actually happening seems so much more difficult

Is that required for the user-facing Python doc?  If not, I'm OK with some complication under the hood if it allows simpler API calls in typical use cases.

I think it would be required to explain in order to communicate what the seed and rng arguments are/why you might use them


go: Apply package exclusion equally

Description of changes
Applies package exclusion logic to directory discovery instead of afterwards.
Fixes #167717
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Needs to go to staging instead of master.

@zowoq updated the target branch

@ofborg build vim-go
https://github.com/NixOS/nixpkgs/issues/167780
i think we'll need to fast track this staging iteration because there's quite a lot of issues on master

@ofborg build vimPlugins.vim-go

Kinda pointless trying to build on staging, it's fine on master.


feat: add network to gateway app method

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.50%. Comparing base (e54426e) to head (1ff53ed).

Additional details and impacted files
@@                               Coverage Diff                               @@
##           mohammad/gateway/move-app-to-gateway-method     #123      +/-   ##
===============================================================================
+ Coverage                                        46.40%   46.50%   +0.09%
===============================================================================
  Files                                               16       16
  Lines                                              571      572       +1
  Branches                                           571      572       +1
===============================================================================
+ Hits                                               265      266       +1
  Misses                                             297      297
  Partials                                             9        9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


#448 User should get an "invite friends" card in feed

#448 User should get an "invite friends" card in feed

New template for invitation card added
Added condition to add this card
Added popup to this card

@StanislavShevchenko wrong header text in popup component.

@yaroslav-fedyshyn-nordwhale Done

@LiavGut

@sirpy Was the header text fixed?

@sirpy Was the header text fixed?

Yes

Сhecked on the Dev environment.
Looks and works as per requirements.


UI freeze part 473

Lens: 2024.3.271133-latest
Extension API: 6.10.35
Electron: 27.2.4
Chrome: 118.0.5993.159
Node: 18.17.1
© 2023 Mirantis, Inc.
(check for update says that I'm up to date)
https://github.com/lensapp/lens/assets/3893/c6b38c64-9cb2-42da-9a2a-bfcf7092c86f

(I did open the devtools after the freeze)

So can not open console log from devtools, nothing in the UI reacts

Does this still reproduce with the current latest?

Hello @matti,
I wanted to check in and see if you've had a chance to try out the latest version of Lens. We're particularly interested in hearing if the UI freeze issue has been resolved.
Thank you for your time and support.


ENH: Start of adding slicing

Hi Tom!
Nice project you started here.  What are you plans with it?  This fits in nicely with a project I'm working on.
I'm curious if you would be inclined to add a slicing layer to the framework?  This PR, is just to illustrate what it might look like.  I haven't even tried to run this code.  Want to bounce it off you, ask if you're even interested in contributors, etc, before I spent too much time on it.
It would enable checking "recent" data, against the values in the "pre-recent", and it would also be a massive speed boost, for those kinds of checks (as opposed to checking the entire thing.) I've prepared a second PR, before I had this idea, with a few one off examples where it might be appropriate.

Obviously, I haven't integrated the logic into the decorators.

Hi Jeffrey, thanks for the PR.
The project is very much alpha at the moment. It seemed like a good test case for the new pipe method in pandas.
Re this PR, something like this would absolutely be useful. I'm going to think a bit about the API, since I can see it being applied to pretty much every function. I think your suggestion is the right way to go though.

I started trying to use a few of the functions, using my first implementation method, and it started to feel akward, using parameters for passing the slice object.
within_range(df, slice(-1), items) or something akin to within_range(df, items, sl=slice(-1))
...so, I created an OO approach.  Both 1bc608b and 30ef13d pass test_within_range, and both have strengths/weaknesses.
I'm going to sleep on it...let me know if you have any better ideas, for the API.

...thinking more about the API...
I think we can break the checks into bins based on the slicing input required, and then toggle the various output settings globally-esque using an instance of CheckSet or something.
Inputs
Each of the following could optionally come with args, kwargs.

Data (+ implied slice to check) (+ implied slice to derive check)
Data + explicit slice to check (+ implied slice to derive check) [+ indexing method]
Data + explicit slice to derive check (+ implied slice to check) [+ indexing method]
Data + explicit slice to check + explicit slice to derive check [+ indexing method]

Outputs

AssertionException / Original Data (Implied Verified)
CustomException / Original Data (Implied Verified)
(Original Data, Bool) (Explicit Verified)
(Original Data, ND-indexed Bools) (via Series/DataFrame/Panel)
Bool
Bool, Obj

SO...
I'm wondering if we couldn't create something clever along the lines of...
acheck(df, slc, slc_d, *args, ix=None, iloc=None, ix_d=None, iloc_d=None, *kwargs): where...

we always type-check slc and slc_d, handle accordingly
assume that Input number 3 is unlikely, and therefore people could use the appropriate *_d kwarg, for that case.
assume that people will use these in factory methods, that remove the need for the slicing ugliness

Ok, @TomAugspurger you're going to want to have a look at the API I've got started here.
The checks are slightly harder to write/read, but everything else is, IMO pretty slick.

[X] Framework for user-defined exceptions
[X] ix/iloc/loc slicing implemented with extremly low amounts of typing
[X] Framework for alternating between Exception/Bool/NDFrame/Custom Object
[X] Decorator creation generalized, minimizing DRY logic

TODO: Upgrade all the existing checks, tweak docs.
Take a look at my "examples.py"...a tad sloppy, it's right in the module folder for now.

Oh, and included is a way to slice the frame for the check, and the way to slice for the derive.
"Derive" is the slice of the frame to use for calculating relative constants.
So, one could pass a frame with 3 years of history, calculate a standard deviation using the "derive" slice of say, year 1, 2, and 11 months, then check only the trailing month.

...it'll be less confusing, if all checks use the same function signature.

Sorry it took me a bit longer to get back to this, although I have had time to stew things over.
I'm going to propose something a bit different than what you've got started (thanks for that btw, it really is helpful to your examples). My PR would look something like...
def check_slice(df=None, check=None, loc=None):
    subset = df.loc[loc]
    check(subset)
    return df

So using your example
In [2]: ind = pd.date_range('2010', '2015', freq='A')

In [3]: adf = pd.DataFrame({'one' : range(5), 'two' : [ i ** 2 for i in range(5)]}, index=ind)

In [4]: adf.ix[4,'two'] = pd.np.NaN

In [5]: adf
Out[5]:
            one  two
2010-12-31    0    0
2011-12-31    1    1
2012-12-31    2    4
2013-12-31    3    9
2014-12-31    4  NaN

In [12]: check_slice(adf, none_missing, (slice(None), ['one']))
Out[12]:
            one  two
2010-12-31    0    0
2011-12-31    1    1
2012-12-31    2    4
2013-12-31    3    9
2014-12-31    4  NaN

For use in pipelines, I'd suggest the user partially apply the function
In [18]: from engarde import checks

In [19]: from functools import partial
In [20]: even_monotonic = partial(check_slice, check=checks.is_monotonic,
     loc=(slice(None, None, 2), slice(None)))

It looks like your PR has a bit more functionality that my simple attempt here may not cover. I really want to keep this library simple since as you've seen I'm not the most responsive steward ;)
Anyway I'm going to play with each of this for a bit and see how they feel. I'd be curious to hear your thoughts.

The check_slice idea, won't work as elegantly with the framework I need to integrate this with.
none_missing, is an example where the "check_slice" doesn't require data from the rest of the dataframe, but for the rest of the checks (eg, check_slice(df, within_std_dev, n=2)) ...you end up needing to inject the results of the calculation via arguments.  Blah.
...yah, my PR as is, does build out a bit more functionality that you touched on.  Actually, quite a bit.
Despite me not demoing it, the pipe functionality should still work, with everything I had built.
This might be where we fork, cause I need this functionality I built ASAP.  Glad we chatted, don't think it was a waste for either of us.  I'll give the hat-tip to your project, in my eventual docs, and will be watching what you do.  Maybe we merge one day.
Amazingly, if you exclude our slicing implementation, our users could swap out our libraries interchangeably. With just an import statement change.

It's likely buggy, and it's late...but this is where I'm taking my fork:
https://github.com/jnmclarty/validada
Hope it's okay with you.  Let me know if there is any licensing issues.  Don't know exactly what I need to do.

Cool. I'll keep my eye on that!
Licenses should be compatible. If you do need me to re-liscense it as something other than MIT let me know.


Finish Line Detection #27

Added collision detection, mqtt integration, changed spawn position and vehicle mod  #27
:ballot_box_with_check: Definition of Done checklist

[ ] Meaningful title and valuable description in pull request
[ ] Code change tested manually if not covered by automated tests
[ ] Pull request linked to one or more issues/stories
[ ] Acceptance criteria of the linked stories satisfied
[ ] Code change comprehended by those who approved it
[ ] State of target branch maintained or improved after the code change

Check the Modding instructions here cause you need to add a json file to Arduino folder as explained.

I am closing this pull request and starting a different one to add more changes


Cannot Bond

I own LPT
I have MetaMask, and Livepeer open with MyEther Wallet
When trying to Update my Transfer Allowance I enter my LPT total
I try to BOND
pop up screen says "Alert, not enough funds!!"

Describe the bug (required)
A clear and concise description of what the bug is.
Expected behavior (required)
A clear and concise description of what you expected to happen.
To Reproduce (required)
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Device (required):

Device: [e.g. MacBook Pro, iPhone6]
OS: [e.g. iOS, Linux]
Browser [e.g. Chrome, Safari]
Version [e.g. 22]

Screenshots (optional)
If applicable, add screenshots to help explain your problem.
Console logs (optional)
Paste related logs and/or error messages from the console here.
Network issues, such as the cURL output from failing requests, can also be pasted here.

Additional context (optional)
Add any other context about the problem here.

I own LPT
I have MetaMask, and Livepeer open with MyEther Wallet
When trying to Update my Transfer Allowance I enter my LPT total
I try to BOND
pop up screen says "Alert, not enough funds!!"
I have MAC OS
Brave browser

You need some ETH so you have enough gas. I had the same issue before.

Thanks
Sent from my iPod
Madison Sample Jr MD

On May 14, 2019, at 8:56 PM, jvanlan<EMAIL_ADDRESS>wrote:
You need some ETH so you have enough gas. I had the same issue before.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Closing the issue


Changed General options page from custom to property grid layout

Changed General options page from custom to property grid layout according to issue #863

@xperiandri The PR is non-mergeable. Could you rebase to current master?

It does not compile in VS 2013

VS 2015 is buggy as hell. We should not use any F# 4 / C# 6 features yet. We may consider this after Update 1 releases.

Does settings application work only after closing, and reopening code file?

Most settings work after reopening files. Task List comments, Folder organization and Generate references for FSI settings require restarting Visual Studio to take effects.

In Visual Studio 2015 with Update 5 nameof works
But I will change that
@vasily-kirichenko, I agree that 2015 is very buggy but benefits worse.
It crushes for dozens times a day. I don't used to use so much foul language as after RTM

Why GeneralOptionsPage opens on Visual Studio lunch but not when F# Power Tools in Options dialog is selected?

@dungpa, try to merge now
Everything have to work.
By the way, how to run tests?

@vasily-kirichenko, looks like I have managed to fix VS2015 and now it works stable

Check out the Contributing guide https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/CONTRIBUTING.md
In short, you can run 'build.cmd' from command line to run tests.

Will not work running them within Test Explore in Visual Studio?

Yes, it does work if NUnit Test Adapter is installed https://visualstudiogallery.msdn.microsoft.com/6ab922d0-21c0-4f06-ab5f-4ecd1fe7175d

Quick comments:

Please don't rename FSharpVSPowerTools.sln. It breaks our build on AppVeyor CI https://ci.appveyor.com/project/dungpa/visualfsharppowertools/build/2.1.0-a1507292342
Please don't rearrange FSharpVSPowerTools.csproj; it's not the purpose of this PR.

Initially we didn't use the property grid supported in VS for General Options dialog because it has rigid structures. For example, we want to preseve the 'You must restart Visual Studio for the changes to take effects' label. How do we do it with this property grid?
From current version of GeneralOptionsControl, I think it would be even simpler to use PropertyGrid controls from ToolBox and bind data ourselves.

I can't see any purpose to do it so complex.
We have only 1 option that require restart as far as I know.
I implemented logic to gray it out if Visual Studio is not running with admin privileges. There is a *** sign on that property and a description.

I insist that this label about required restart used to be completely redundant unless there are other options that require restart.

@dungpa, are you sure that you will not rearrange FSharpVSPowerTools.csproj?
Because it will take additional hour to bring it back.

We can change
let solutionFile  = "FSharpVSPowerTools"

to
let solutionFile  = "FSharpVSPowerTools.v12"

in build.fsx
It is not as confusing for new contributors as existence of some sln files with suffixes and one without

This PR should have been split into three different ones.
The first one deals with formatting changes. We could easily review formatting changes in isolation.
The second PR rearranges FSharpVSPowerTools.csproj. Your folder grouping is inconsistent and confusing. I suggest:

We have PowerToolsCommandPackage.cs is an entry point in the top level folder.
A Settings folders for all *OptionsControl.cs and *OptionsPage.cs files.
A Features folders for the remaining facades to the available features

The third PR changes GeneralOptions dialog to use a property grid.

I insist that this label about required restart used to be completely redundant unless there are other options that require restart.

The three options that requires restarting Visual Studio are:

Folder organization
Task List comments
Generate references for FSI

If we count 'Navigation Bar', it's going to be four features doing so.
It's not only about keeping the label as is. The current dialog allows flexible changes to the UI. My opposition is that we can move it to a property grid in a simple way without losing flexibility.

As you wish

•We have  PowerToolsCommandPackage.cs  is an entry point in the top level folder.
•A  Settings  folders for all  *OptionsControl.cs  and  *OptionsPage.cs  files.
•A  Features  folders for the remaining facades to the available features
What is the benefit?

I thought reorganization to increase seeking speed.
If I want to change something about General page I go to General folder
If I want to change something about Formatting page I go to formatting
etc
What is your idea?

If I want to change something about General page I go to General folder
If I want to change something about Formatting page I go to formatting
etc

Your idea is right. But you initially push https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/src/FSharpVSPowerTools/SyntaxConstructClassifierProvider.cs to General folder, which is not quite consistent. These facade files for specific features should be a separate folder.

OK, it was a mistake

How this property grid is better than the current check boxes? It's very difficult to see at a first glance what features are enabled in that grid. Words "True" and "False" vs [ ] and [x].

I can agree with your point
Other extensions use their own windows:

CodeMaid - modal windows
vsCommands - tool window
But I don't think that this is a good idea. I prefer to be along with standard ways of doing things.

As I said earlier the other option is to use a control like in Debugging. But it is quite ugly.

@dungpa, do you have any remarks about code in current pull request?

The code is fine.
Some problems:

DefaultValue attributes seem problematic. XML comments generation is always persisted as False in the next VS session no matter I change it. Perhaps we should assign values for properties in constructors as before?

Typo: 'Enables or disables' --> 'Enable/disable'

Typo: 'Refactorings' --> 'Refactoring'

Typo: 'requires restart' --> 'Require restart'

5.Typo: 'requires admin' --> 'Require admin'

I thought that it is implied option at the beginning of the sentence that is why I spelt
"Option requires restart"
"Option requires admin privileges"
Isn't it correct?
I will check about XML comments.
Default attribute just allows to specify that true or false won't be bold.

About default values you are right.
I will bring that back.
Could you explain
If I type /// and press space on top of function that has parameters it must added necessary XML comments to describe parameters, mustn't it?

Fixed properties initialization

I thought that it is implied option at the beginning of the sentence that is why I spelt it from the third person in singular

A sentence starting with a verb assumes that the subject is neutral. You can check other options in Visual Studio to be sure.

Could you explain
If I type /// and press space on top of function that has parameters it must added necessary XML comments to describe parameters, mustn't it?

In F#, one can use /// comments as the short-form comments. To activate the feature, type ///< http://fsprojects.github.io/VisualFSharpPowerTools/xmldoc.html
Btw, you can push more commits. No need to force push every time.

I still think this PR makes the option page worse. Why this PR at all?

@vasily-kirichenko Do you have a better way to find spaces for new options?
We use a fairly standard way (similar to Productivity Power Tools) here. It's not too bad given that we have very constrained spaces in the option dialog.

What new options? I don't have any issues with options page at the moment. When (if) we add few new features (in a year or two), we could consider reorganizing the page. Doing it now is a waste of time, especially considering the result.

Btw, you can push more commits. No need to force push every time.

Why to keep irrelevant commits?

A sentence starting with a verb assumes that the subject is neutral. You can check other options in Visual Studio to be sure.

No, have a look at Windows Forms Designer options page

Toggles ...
Controls ...

VC++ Project Settings: Show Environment In Log

Specifies whether ...

Meaning that "This option" text is omitted at the beginning of the sentence.

Meaning that "This option" text is omitted at the beginning of the sentence.

Fair point. I would say VS is not entirely consistent in this regard. Most of their options don't use that form though. If you don't want to change this, it's fine.

Why to keep irrelevant commits?

You update the PR based on feedback. If you added more comments, we can see the delta changes to understand the progress. As it is, we have to look through all the code again.

@vasily-kirichenko We ran out of spaces long ago. To be honest, not everyone has high DPI screens or large monitors. The options look so dense and they lack spaces on my poor laptop. I feel uncomfortable with squeezing spaces of the check boxes everytime we add a new feature.
If we should do this sooner or later. Why don't we do it now?

If you added more comments, we could see the delta changes to understand the progress. As it is, we have to look through all the code again.

Agree.
My intent was to revert everything back in case of splitting that big pull request. And to keep commit consistent (as again I reverted some part of code).
 It has been persisted correctly to registry at HKCU\Software\Microsoft\VisualStudio\12.0\DialogPage\FSharpVSPowerTools.GeneralOptionsPage\XMLDocEnabled, however, its value isn't displayed correctly on the property grid.
Somehow, the dynamic way of passing attributes to GeneralOptionsControl screwed up reading registry values.
@xperiandri Did you check whether it works locally on your machine?

Yes
I did settings reset:
Deleted 14.0Exp folders from Local and Roaming
And performed settings import, C# profile.
After this everything worked well

I don't think we should go down this route anymore.
It means a subtle bug for users. If they don't reset settings by themselves, the real stored settings and displayed values on the property grid are out of sync.
I'm terribly sorry. I didn't know that it is this tricky.
At best, we can add a scrollable Panel to have more spaces for new options.

The is already a scrollable control with adaptive layout.
Why do you care so much?

We need to test in clean environment.
At first install current version and change some settings.
At second update to this version with my changes and check.
Even though it will require to reset settings it is not so big deal. We just need to specify it in extensions description on Visual Studio Gallery and set to open this page after update.

I tested it by bumping version and installed this version on top of v2.0.0. It has weird behaviours if users update from some old VFPT version.
This is a small improvement on top of something that has been working OK. The downside is breakage to current users. I don't think the benefit outweighs the cost of adding the improvement.

Why do you care so much?

If I didn't care, I wouldn't put so much effort into this project.
Again I'm really sorry that you have made a lot of effort in order that we figured out that it didn't work as anticipated.
We still have a lot of pending issues where we hope for community's contributions, especially up-for-grabs ones https://github.com/fsprojects/VisualFSharpPowerTools/labels/up-for-grabs. We would love to have your contributions on those.

It is not only about effort, it is about usability.

If I didn't care, I wouldn't put so much effort into this project.

Any way there is no alternative to this project. You can do whatever you think is better.

Again I'm really sorry that you have made a lot of effort in order that we figured out that it didn't work as anticipated.

I will double check later.

The downside is breakage to current users.

So what? It is not a big deal. Adding "Known issues" paragraph to release notes will fix the problem.


Missing icons

There are SettingsApplication and lots of others, but plain "Settings" and variations are missing (it is listed on https://material.io/tools/icons/?icon=settings&style=baseline)

The problem is that the source icon is 20px instead of 24px. You can use SettingsOutline or SettingsSharp which is the same icon at the correct size.
We could perhaps add a workaround to duplicate one of those paths to generate the "Filled" icon from.

by the way it is SettingsOutlined

@henrylearn2rock Yes, it's gone.

FileUpload is gone as well^

FileUpload is gone

@sakulstra I can only find CloudUpload.

and FileDownload too

There is no FileDownload icon: https://material.io/tools/icons/?search=download&style=baseline

@henrylearn2rock FWIW, the lightbulb icon is published in the @material-ui/docs package:
import LightbulbOutlineIcon from '@material-ui/docs/svgIcons/LightbulbOutline';
import LightbulbFullIcon from '@material-ui/docs/svgIcons/LightbulbFull';

But you might prefer to copy them locally.

@mbrookes thanks, I'll stay with 1.1.0.  Hmmm... why would Google do that to screw us up.

I realize they made it a full semver major release so things are expected to break but they could have at least pointed to a list of changed icons that were already existing. I too ran into issues with the FileUpload and while it was a very easy fix it's still slightly annoying.

@JJeffBaumgardt I wish we could have make a complete changelog, but with more than 1,000 icons, it's more efficient to offload the effort to our users with issues like this one. Thank you for reporting the pain point.

v1 icons not included in v2:

ContentCopy
ContentCut
ContentPaste
DoNotDisturb
DoNotDisturbAlt
DoNotDisturbOff
DoNotDisturbOn
FileDownload (available in @material-ui/docs/svgIcons)
InfoOutline
LabelOutline
LightbulbOutline (available in @material-ui/docs/svgIcons)
LockOutline
ModeEdit
SentimentNeutral
SimCardAlert
SystemUpdateAlt

v1 icons not included in v2 due to incorrect size (Use other styles):

Domain (filled)
Settings (filled)
Weekend (filled)

v2 icons not included due to incorrect size (Use other styles except for StarRate - use Star / StarBorder / StarHalf):

CastForEducation (filled)
Domain (filled)
PlayCircleFilledWhite (filled)
StarRate (filled)
StarRateOutlined
StarRateRound
StarRateTwotone
StarRateSharp

That would have been important to put in a changelog...

@meetbryce I have added the list to the main PR, and updated the release notes & changelog.

Just did my first PR (#12356) on Material-UI. I am not sure if I did it right or not. Please let me know if I need to adjust some things.

BTW, as those are SVGs, we don't really care about the announced size, right?
If so, the size could be "hardcoded" to 24px in the saved file name as every one virtually is any size.

@the-question It's very brave from you to work on improve the fetch logic. Unfortunately, it won't help with #12251. The SvgIcon set the viewbox to 0 0 24 24. We need the source path to follow this same convention. Right now, I see 3 options:

We wait for the material team to clean their svg images
We find a tool to change the svg path bounding box
We override the SvgIcon view box

I have sorted the options by my order of preference.

I did a quick test with the Settings icon (baseline one, which is 20x20).
As SvgIcon sets the viewbox to [0, 0, 24, 24], and this case, where the original viewbox is [0, 0, 20, 20], we would need to move (translate) items in the SVG by 2px, so that they would be centered when the viewbox is set to [0, 0, 24, 24].
I applied the following transformation to the SVG (temp0 is the svg HTML node):
for(i = 0; i < temp0.children.length; i++) {
    temp0.children.item(i).setAttribute("transform", "translate(2, 2)")
}

This goes through every child of the parent svg element and moves them by 2px in each direction.
Therefore, when setting the viewbox to [0, 0, 24, 24], width and height to 24 afterward, the icon appears centered, but not zoomed, so the original look is preserved. (Using other width/height still works as expected)
You can try it with:
temp0.setAttribute("viewBox", [0, 0, 24, 24]);
temp0.setAttribute("height", 24);
temp0.setAttribute("width", 24);

Ideally, this (the first part, translating childrens) should be applied to the downloaded SVG, before saving it as a file.
P.S: I totally agree with your order of preference, but judging by the fact that they still link to a repository which is 3 years out of date, I'd say we may prefer taking the lead on this one.

@mbrookes Could you mention that FileUpload is missing as well ?

@bperel thanks - must have somehow missed that in the diff.

Thanks for that list @mbrookes !
I ran into problems with a missing FileDownload icon when upgrading @material-ui/icons version. I found that the icon was renamed to GetAppSharp.
I wonder, where is the changelog located? When upgrading, I checked https://github.com/mui-org/material-ui/releases , but there is nothing mentioned there about a v2 release or about missing icons.

@material-ui/icons 1.0.0 + @material-ui/core 3.1.0 seems to work...

Looked through https://github.com/mui-org/material-ui/issues/12251#issuecomment-407856100 and checked if the icons not included due to size are now included. The following icons are included now:

PlayCircleFilledWhite (filled)
StarRateOutlined
StarRateRound
StarRateTwotone
StarRateSharp

The eco icons is missing, https://material.io/resources/icons/?search=eco&style=baseline, as reported in ##17251. We should be able to manually patch this one.

Another point of discrepancy here seems to be that google's data.json icon file isn't up to date with material.io's list of icons.

@oliviertassinari Regarding the manual patch -- currently if the icons script were to be ran it would remove the patch (because it references the out of date json).
Should some kind of note be made or can we assume the script will be altered in the future before it is ran again?

@colemars Here you go: https://fonts.google.com/metadata/icons
The json structure has changed though, so you'll have to tweak the script a bit.
Also the download URLs are now of the form:
https://fonts.gstatic.com/s/i/materialicons/3d_rotation/v1/24px.svg
https://fonts.gstatic.com/s/i/materialiconsoutlined/3d_rotation/v1/24px.svg
https://fonts.gstatic.com/s/i/materialiconsround/3d_rotation/v1/24px.svg
https://fonts.gstatic.com/s/i/materialiconstwotone/3d_rotation/v1/24px.svg
https://fonts.gstatic.com/s/i/materialiconssharp/3d_rotation/v1/24px.svg

(Note "round" not "rounded")

Missing icon.
import StorefrontIcon from '@material-ui/icons/Storefront';

Storefront will be in the next release.

Also missing EmojiEvents. Nice....

I found one here https://iconify.design/icon-sets/mdi/google.html


posix_spawn(3) support on OpenBSD

OpenBSD has supported posix_spawn(3) since version 5.2
It appears that support is already plumbed up for NetBSD, so I'll try to set up a pull request later today.

OpenBSD defines posix_spawnattr_t and posix_spawn_file_actions_t opaquely, so I'm not sure how to define those symbols.
Right now I have it set up as
pub type posix_spawnattr_t = *mut __posix_spawnattr;
pub type posix_spawn_file_actions_t = *mut __posix_spawn_file_actions;

but I can't get a definition for __posix_spawnattr and __posix_spawn_file_actions that will pass the either the compiler or the test suite.
If I define the types exactly as they actually are, the test suite fails because it tries to instantiate them directly. Defining an empty type (pub struct __posix_spawnattr {}) runs into the missing copy implementations lint.
Is there something obvious I'm missing here?

opaque type could be implemented using:
pub type posix_spawnattr_t = *mut ::c_void;
pub type posix_spawn_file_actions_t = *mut ::c_void;

it means there are "pointer on something".
this strategy is already used for pthread_attr_t for example (which is also opaque type on OpenBSD).

That worked! Thanks for the suggestion.

Implemented in #3502


Volumes not torn down on pod delete

Volumes are not getting teared down on pod delete. I see the following error in kubelet log.
Couldn't sync containers: remove /var/lib/kubelet/pods/f936e991-abed-11e4-96a8-00266cf650e0/volumes/kubernetes.io~dw-vol/redisvol2: device or resource busy
We are trying to clean up pod directory before cleaning up volumes. Reversing 'kubelet.cleanOrphanedPods' & 'kubelet.cleanupOrphanedVolumes' in kubelet.go fixes the issue.
I have the patch available, if we are ok to commit.

What is dw-vol - is it a new kind of plugin?  Can you explain what exactly
is happening?
I think flipping the order is probably correct.
On Tue, Feb 3, 2015 at 3:21 PM, Chakri Nelluri<EMAIL_ADDRESS>wrote:

Volumes are not getting teared down on pod delete. I see the following
error in kubelet log.
Couldn't sync containers: remove
/var/lib/kubelet/pods/f936e991-abed-11e4-96a8-00266cf650e0/volumes/
kubernetes.io~dw-vol/redisvol2: device or resource busy
We are trying to clean up pod directory before cleaning up volumes.
Reversing 'kubelet.cleanOrphanedPods' & 'kubelet.cleanupOrphanedVolumes' in
kubelet.go fixes the issue.
I have the patch available, if we are ok to commit.
--
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/4086.

I saw this as well in our PD testing. I'm also adding in: https://github.com/GoogleCloudPlatform/kubernetes/pull/4076 which makes sure that the containers are down before attempting to unmount.
But yes, your PR sounds reasonable, please send it along (and you'll need to sign our CLA if you haven't already.)
Many thanks!
--brendan

Thanks Thockin & Brendan.
I am just trying out the plugin infra. It is actually bind mount in the backend as of now.

Yeah, the real problem is that we try to tear down the pod but don't rcurse
that into the pod's volumes.  Oops.
On Tue, Feb 3, 2015 at 4:18 PM, Chakri Nelluri<EMAIL_ADDRESS>wrote:

Thanks Thockin & Brendan.
I am just trying out the plugin infra. It is actually bind mount in the
backend as of now.
--
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/4086#issuecomment-72765483
.

Thanks Brendan. Signed and sent out the corporate CLA.

I believe this is now fixed (though pd.sh is still somewhat flaky sigh)


[5.0] Don't map Bool back to ObjCBool for SIL types in unbridged contexts

When the Clang importer imports the components of a C function pointer type, it generally translates foreign types into their native equivalents, just for the convenience of Swift code working with those functions.  However, this translation must be unambiguously reversible, so (among other things) it cannot do this when the native type is also a valid foreign type.  Specifically, this means that the Clang importer cannot import ObjCBool as Swift.Bool in these positions because Swift.Bool corresponds directly to the C type _Bool.
SIL type lowering manually reverses the type-import process using a combination of duplicated logic and an abstraction pattern which includes information about the original Clang type that was imported. This abstraction pattern is generally able to tell SIL type lowering exactly what type to reverse to.  However, @convention(c) function types may appear in positions from which it is impossible to recover the original Clang function type; therefore the reversal must be faithful to the proper rules.  To do this we must propagate bridgeability just as the imported would.
This reversal system is absolutely crazy, and we should really just

record an unbridged function type for imported declarations and
record an unbridged function type and Clang function type for @convention (c) function types whenever we create them.
But for now, it's what we've got.

rdar://43656704
This is the 5.0 equivalent of #20905.  It is not ABI-affecting, but it would be nice to get into early convergence because it affects some fairly core code.

@swift-ci Please test.

@swift-ci Please test source compatibility.

@swift-ci Please test.

Build failed
Swift Test Linux Platform
Git Sha - ab5a0d25cd2472d6826146788474b89bf69f2c10

@swift-ci Please test Linux.

@AnnaZaks Should this be merged?


SHA-256 hash for Linux From Source Download

I downloaded five different versions of the platform and the SHA-256 hash matches for all save the Linux From Source download. To be more specific, the download of
https://haskell.org/platform/download/7.10.2/haskell-platform-7.10.2-a.tar.gz
does not produce a matching hash using shasum -a 256. (I even tried with -b, -p and -t options and all produce the same hash which disagrees with the published one.)

closing as resolved with the new platform


IO-543-ReversedLinesFileReader-with-RandowFileAccess-API

pull request for ticket: https://issues.apache.org/jira/browse/IO-543

Added getFilePointer and seek API to ReversedLinesFileReader
Added new JUnit tests (ReversedLinesFileReaderTestRandomAccess)

Coverage increased (+0.09%) to 90.086% when pulling a5bc2f8ade9ac5a13e929bf329b8056afecc1124 on JeanPierrePortier:IO-543-ReversedLinesFileReader-with-RandowFileAccess-API into acceb62960971477744f6731bbbc06abbabfe4f3 on apache:master.

Hi @garydgregory
This is a very old PR and I did not work onto it for a long time now.
Let me sync with sources; please.

Hello @garydgregory ,
sorry for the delay; tried to sync my mind with current master state (more than 1500 commits behind....)
So just pushed a rebased branch with improved unit tests

Hello @JeanPierrePortier
Thank you for the update.
You'll want to run a local command line build with just mvn which runs the default Maven goal. This will make sure you do not cause your branch build here to fail by fixing issues before you push your branch. ATM, you have failures.

Yes just seen this (I just launched mvn verify command) before pushing and it is not enough...

Yes just seen this (I just launched mvn verify command) before pushing and it is not enough...

Just run 'mvn'

Last CI run failed for windows env for files not related to this PR.
No idea why and failures should not be related to this PR (I do not have windows host for validation)


Event Hub Track2 Library Migration

Description
Migrate to Event Hub track2 library.

Codecov Report

Merging #636 into master will decrease coverage by 0.75%.
The diff coverage is 41.56%.

@@             Coverage Diff              @@
##             master     #636      +/-   ##
============================================
- Coverage     56.19%   55.43%   -0.76%
+ Complexity      748      743       -5
============================================
  Files           179      180       +1
  Lines          3132     3144      +12
  Branches        229      226       -3
============================================
- Hits           1760     1743      -17
- Misses         1237     1269      +32
+ Partials        135      132       -3

Impacted Files
Coverage Δ
Complexity Δ

...ub/stream/binder/EventHubMessageChannelBinder.java
65.71% <ø> (ø)
4 <0> (ø)
:arrow_down:

...gration/eventhub/checkpoint/CheckpointManager.java
36% <0%> (-9.46%)
7 <0> (-1)

...thub/factory/EventHubConnectionStringProvider.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ion/eventhub/checkpoint/TimeCheckpointManager.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...utoconfigure/eventhub/AzureEventHubProperties.java
73.68% <0%> (-13.82%)
11 <0> (ø)

...igure/eventhub/AzureEventHubAutoConfiguration.java
16% <0%> (-0.67%)
3 <0> (ø)

...eventhub/factory/DefaultEventHubClientFactory.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ing/integration/eventhub/util/EventDataHelper.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../integration/eventhub/impl/EventHubRxTemplate.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ub/checkpoint/PartitionCountCheckpointManager.java
84.21% <100%> (+11.98%)
6 <2> (ø)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 425ef4e...c65f52f. Read the comment docs.


[BUG]: does colossalai only support full layers training?

🐛 Describe the bug
i'm using the colossalai to train the animate anyone. and the training need to freeze some layers in model. but that would lead to assert error in colossalai whichever plugin i'm using. so i want to that can colossalai support training part of layers in model?
Environment
none

Hi zhangvia, could you please provide a detailed description of this bug? e.g. which layers you want to freeze and why? Maybe you can create an repo for that and our tech team will help you to analysis the problem in their spare time.
If you are referring to lazy init, Colossal-AI do allow some layers to be initialized lazily and use.
If you are using GeminiPlugin, please see this for more information #5290
Thank you very much for using Colossal-AI~

Hi zhangvia, could you please provide a detailed description of this bug? e.g. which layers you want to freeze and why? Maybe you can create an repo for that and our tech team will help you to analysis the problem in their spare time.
If you are referring to lazy init, Colossal-AI do allow some layers to be initialized lazily and use. If you are using GeminiPlugin, please see this for more information #5290
Thank you very much for using Colossal-AI~

i see that issue. i wonder know if colossalai support part of layers training exactly because i see that issue. i open a issue #5226, but no one anwser that. when i using deepspeed to traing the animate anyone, it cost more memory in single gpu than single gpu training. and using cpu offload doesn't help. so i want to use colossalai gemini strategy to train animate anyone. but it seems colossalai also can't deal with this situation

You can use TorchFSDP plugin(it can freeze layers), and maybe you also need this:
model.gradient_checkpointing_enable(gradient_checkpointing_kwargs={"use_reentrant": False})


Added leave mission action

Added leave mission action
For this milestone we added the following:

Leave mission action
Initial conditional rendering for join and leave mission

Thank you for your review 👍


Finger protocol links bug ... maybe

While testing some links I also tried the finger protocol
When a link is poiting finger://domain.tld/user it works well .. it goes to show finger info<EMAIL_ADDRESS>If link is<EMAIL_ADDRESS>lagrange goes to @domain.ltd (no user)
Hope you understand what I said 😀
Thanks for LaGrange🥃

While there is no official URI specification for Finger, I believe the de facto correct format is finger://domain.tld/request. In other words, the userinfo component of the URI is not meant to be used, although I suppose the lack of spec means that one could just go ahead and support that as well.
I don't plan to make changes here any time soon, though. If anyone wants to submit a pull request, I'll merge it.


schematic_trace not getting added in circuit-json

For this simple circuit, I can't see the schematic_trace getting added to the json
project.add(
    <board width="10mm" height="10mm">
      <resistor
        name="R1"
        resistance="10k"
        footprint="0402"
        schX={0}
        schY={0}
        symbolName="boxresistor_horz"
      />
      <capacitor
        name="C1"
        capacitance="100n"
        footprint="0603"
        schX={2}
        schY={0}
        symbolName="capacitor_horz"
      />
      <trace from={".R1 pin.2"} to={".C1 pin.1"} />
    </board>
  );

  project.render();

  const circuitJson = project.getCircuitJson();

@seveibar I have been on it to figure out this issue. Will need some help in this


Update cost-logs.md

Provided query does not include variables referenced.

Learn Build status updates of commit 58014ec:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/azure-monitor/logs/cost-logs.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@guywi-ms
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@DaleKoetke Please approve.
Thanks!

@guywi-ms  Approved!

#sign-off


Add WatchGuard HTTP Proxy vendor id

References:

https://explorer.ooni.torproject.org/measurement/20170825T124715Z_AS6471_xEE1vddMfSEcjRD8XyJeEHVGUczPXnGwbx1vZ5uvA7pzgILJzj
https://explorer.ooni.torproject.org/measurement/20170913T205948Z_AS8167_bCSzXOsg4EtXuVNVfZEh2XlMjikkIaH4SpqM4rQ1tIRl2MnEIr

Maybe it's better to file an issue and attach the fingerprint_db label to it, as sql_tasks.py is now deprecated.

Thanks. Closing.


Deliberate HLZ Analysis Tool Error

Executing (Optionally Union Features): OptionallyUnionFeatureClasses C:\Templates\MilitaryAspectsOfTerrain\ArcMap10.4\Military_Aspects_of_Terrain_for_ArcGIS_10_1\Maps\Toolbox\scratch\scratch.gdb\HLZDissolve_Erase CombinedLinearObstacleFeature C:\Templates\MilitaryAspectsOfTerrain\ArcMap10.4\Military_Aspects_of_Terrain_for_ArcGIS_10_1\Maps\Toolbox\scratch\scratch.gdb\tempScriptFC
Start Time: Thu Dec 10 14:33:22 2015
Running script OptionallyUnionFeatureClasses...
1 feature class(es) provided
unionedFeatureClass: C:\Templates\MilitaryAspectsOfTerrain\ArcMap10.4\Military_Aspects_of_Terrain_for_ArcGIS_10_1\Maps\Toolbox\scratch\scratch.gdb\tempunion
Failed script OptionallyUnionFeatureClasses...
Traceback (most recent call last):
File "C:\Users\jame7507\Documents\GitHub\solutions-geoprocessing-toolbox\suitability\toolboxes\scripts\CheckForFeatureClasses.py", line 30, in
arcpy.Union_analysis(vtab, unionedFeatureClass)
File "c:\program files (x86)\arcgis\desktop10.4\arcpy\arcpy\analysis.py", line 564, in Union
raise e
ExecuteError: Failed to execute. Parameters are not valid.
ERROR 000366: Invalid geometry type
Failed to execute (Union).
Failed to execute (Optionally Union Features).
Failed at Thu Dec 10 14:33:23 2015 (Elapsed Time: 1.22 seconds)
Failed to execute (DeliberateHLZAnalysis).
Failed at Thu Dec 10 14:33:35 2015 (Elapsed Time: 1 hours 52 minutes 5 seconds)

I retested this tool today, and it completed without error. The second time I ran the tool I did not use the ObstructionFeatureClass (optional) option. This might be the origin of the error.

Hey @jrweakland this one still and issue?

The Military Aspects of Terrain tools will not be enhanced. Last supported version was 10.1. These tools are retired as of the April 2018 release. Future work is planned for environmental impacts on operations, release date TBD.


Composer : package not found

Can't install gogokit with Composer. Here's the error:
# composer require 'viagogo/gogokit'
Using version ^0.1.1 for viagogo/gogokit
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package viagogo/gogokit No version set (parsed as 1.0.0) could not be found.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion> for more details.

Read <https://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

Installation failed, reverting ./composer.json to its original content.

Any idea? It's pretty urgent. Thanks.

How are you trying to install the package?

I followed the steps, see my first post... "composer require
'viagogo/gogokit'"
On Jul 1, 2015 12:27 PM, "Maxime Nanouche"<EMAIL_ADDRESS>wrote:

How are you trying to install the package?
—
Reply to this email directly or view it on GitHub
https://github.com/viagogo/gogokit.php/issues/4#issuecomment-117584907.

Do you have other requirements in you composer.json? because I am not seeing any error when I run
composer require viagogo/gogokit

in an empty folder

Weird! I had guzzle but since viagogo required it I thought it was no big deal. It's working fine in a completely empty folder! Thanks so much!


Pinning TLS Min Version to 1.0 for LDAP

Go 1.17 defaulted to tls version 1.0 for new tls.Config objects. Go 1.18 and 1.19 default to tls 1.2. This PR pins the min version supported by the client to tls 1.0 to ensure that this continues to work for the 2.6 release line.

Related to #40671


Installation using pkg install

Hi,
Your readme says you can install with "pkg install", is dotnet available as a set of binary packages?
I couldn't find any so I have repackaged the current release consistent with the linux package naming.
Well done on the good work, with your sdk I have successfully built and tested a dotnet Interop driver for SQLLite.
Thanks,

Hi,
Yes, for some time we have a port done and also pkg binaries are available.

It is not obvious how to install them.
root@generic:~ # pkg install dotnet
Updating FreeBSD repository catalogue...
FreeBSD repository is up to date.
All repositories are up to date.
pkg: No packages available to install matching 'dotnet' have been found in the repositories
root@generic:~ # pkg install lang/dotnet
Updating FreeBSD repository catalogue...
FreeBSD repository is up to date.
All repositories are up to date.
pkg: No packages available to install matching 'lang/dotnet' have been found in the repositories

Do I have to add a package repository, and is lang/dotnet the entire SDK or just the runtime?

That's weird. Are you on aarch64 by any chance? There were pkg available, but I saw @arrowd marked them as broken, becuase of the build issues that sometime occur. But on x64 you should be able to install.

The table at the https://www.freshports.org/lang/dotnet/ page show that packages are available for amd64 only. The aarch64 package is indeed missing due to crossgen issues.

Thanks for the quick response. Yes I am on aarch64, I will try amd64 tonight.
Is this a monolithic single package SDK for 8.0 only?
The standard packaging permits installing the runtime only, and having multiple different SDKs and runtimes, eg 6.0, 7.0,8.0 and soon 9.0 all on the same machine.
Likewise, a PowerShell 7.4 package should only need to depend on the dotnet-runtime-8.0, and a PowerShell 7.2 would depend on dotnet-runtime-6.0
In much the same manner as you can have multiple Java JRE and JDK for different versions installed side by side.
The difference with dotnet is that dotnet-host matches the appropriate dotnet-hostfxr-X.Y to execute programs.

This makes sense, but I don't have much time for the .NET port. The split you're talking about can be easily implemented with the new feature called "subpackages", but unfortunately it stalled at the very end of its developement and can't be used right away. So for now we'll have to live with a single .NET megapackage.

Thanks, the x64 installation worked first time!


Enhance CI to perform end-to-end tests based on RPM-built code

Based on the errors reported in #644 and #645, we need better coverage in our CI tests that test a more complete end-to-end solution.
This should include running a client on a system with SELinux enabled and the packaged FDO bits installed as a customer would have them installed.
We also need to test both the sqlite and Postgres paths

we should build and install the RPMs to catch all the issues that any client may face
gitlab for runners to use VMs (maybe?)
reuse our existing CI whenever it is possible
for the postgres test we could reuse existing scripts from https://github.com/fdo-rs/fido-device-onboard-rs/blob/main/test/fdo-postgres.sh

enable c9s builds in copr for FDO

I think the Testing farm + TMT would be the best choice to drive the test.


Have to press the keys twice to change Workspace (1/3rd or 1/4th of the time)

Environment
Windows build number: Microsoft Windows [version 10.0.18362.900]
PowerToys version: 0.19 and 0.18.2
PowerToy module for which you are reporting the bug (if applicable): Key Remapping

Steps to reproduce
I remapped (the correct way this time):
(old behavior)
CTRL-WIN-Left Arrow
CTRL-WIN-Right Arrow
to
(new behavior)
ALT-WIN-Left Arrow
ALT-WIN-Right Arrow
Expected behavior
When pressing ALT-WIN-Left or Right Arrow (once), should go to Left or Right Workspace
Actual behavior

At time (like 1/4 of the time, depending on the number of workspaces), I have to press the key combination twice. That is, WIN-ALT-Left-Left or WIN-ALT-Right-Right
the old keys keep working (CTRL-WIN-Left or Right) (without the issue above)

Screenshots

Seems 0.19.2 has solved the issue


deploy template

Change LISTEN_PORT from string to int
Revert "Change LISTEN_PORT from string to int"

/lgtm


Code coverage file view does not show code

When viewing files in the code coverage view, the file contents should be displayed along with line numbers and highlighting. Currently just a blank page with highlighted row numbers is displayed. No code is rendered. Now if I refresh the page and try to view the file contents, everything works as expected.
Expected Behavior
When viewing a file in code coverage I expect to see the lines of code with the coverage highlights
Actual Behavior
Blank page with line numbers is displayed
Steps to Reproduce
generate code coverage report
upload report to backstage
navigate to the component that has the coverage report
select a file in the file explorer
pop-up shows page with only line numbers
Context

Unable to view the code
Nothing in jsconsole or backend logs
Your Environment
OSX 12.3.1
able to reproduce in chrome Version 101.0.4951.41 (Official Build) (x86_64) and in safari Version 15.4 (176<IP_ADDRESS>.13)

Output of yarn backstage-cli info:

$ yarn backstage-cli info
yarn run v1.22.1
$ /Users/jguarini/code/backstage_github_clone/node_modules/.bin/backstage-cli info
OS:   Darwin 21.4.0 - darwin/x64
node: v16.13.0
yarn: 1.22.1
cli:  0.17.1-next.0 (local)

Dependencies:
  @backstage/catalog-client           0.7.2
  @backstage/catalog-model            0.10.1, 0.11.0
  @backstage/cli                      0.15.3, 0.17.0
  @backstage/config-loader            0.9.7, 1.1.0
  @backstage/config                   0.1.15
  @backstage/core-components          0.8.10
  @backstage/core-plugin-api          0.6.1, 0.7.0
  @backstage/dev-utils                1.0.1
  @backstage/errors                   0.2.2
  @backstage/integration-react        1.0.1
  @backstage/integration              0.7.5, 1.1.0
  @backstage/plugin-catalog-react     0.6.15, 1.0.1
  @backstage/plugin-permission-common 0.5.3
  @backstage/plugin-permission-react  0.3.4
  @backstage/test-utils               1.0.1
  @backstage/types                    0.1.3
  @backstage/version-bridge           0.1.2
✨  Done in 1.92s.

Thanks for your report. I don't use this plugin myself and don't have test data readily available - hopefully the plugin owners/contributors could pitch in. @alde any ideas?

And of course - if you can get even more insights by inspecting the page and checking the HTML/react contents etc, it would of course help

yeh the page contents is empty on that initial load

Looking at the network request
.../api/code-coverage/file-content?entity=component%3Adefault%2Fbackstage&path=plugins/permission-common/src/PermissionClient.ts
the response payload does in fact have the file contents. So there's a disconnect somewhere between the response and the render.
I also see some deprecation notices in the js console, though I'm not sure they are related.
Deprecated as of 10.7.0. highlight(lang, code, ...args) has been deprecated.
core.js:1490 Deprecated as of 10.7.0. Please use highlight(code, options) instead.