Add a CHANGELOG.md file to the project

https://keepachangelog.com/en/1.1.0/
In the GitHub release descriptions, only links should then be included that point to the appropriate version number section in the CHANGELOG.md file.
This makes the changelog readable offline and the project is not so dependent on GitHub services.

I decided to use my own design for the changelog.


Resolve issues in light-mode

Icon that toggle mode is not visible properly in light mode.
Testimonial slider is not properly visible in light mode.
Here is video for reference :
https://www.awesomescreenshot.com/video/24256916?key=e788bf5f723f2f32904e0a979c5fe512

i would like to work on this issue
under JWOC

I have read the issue and I would like to work on this issue .
please assign it to me under JWOC'2024.

@daksh1210jain , go for it.

@vishal2005025 , you can choose or create different issue.


Dropping stackable items on map does not work

What is the current behavior?
Drop a set of 10 coins on map. You will see ONE coin graphic and when you pick it up... no quantity.
If the current behavior is a bug, please provide the exact steps to reproduce.

Go to bank.
Withdraw 10 coins.
Drop on map
Observe map drop graphic is incorrect
Pick up coins. Observe no quantity anymore.

What is the expected behavior?
Show the correct graphic for quantity stated and when you pick up, have that same quantity on the item.
Additional context
This really isn't a bug... more of like: I didn't get time to add this in but if you wanna take a stab! :P

Really interesting bug.  The bug is very easy to spot mainly because we don't take into account quantities of dropped items and thus it looks like 1 coin.
Should be an easy fix.

I'd be happy to try to take a look into this


Question about spot instances and cost

I would like to explore the costs incurred by the auto scaled nodes. According to AWS ec2 the describe-spot-fleet-request-history can help with that but I need spot-fleet-request-id. Does Karpenter create a spot fleet request? Is it possible to get the spot-fleet-request-id from karpenter's logs?
Or is there any other way how to report out how many instances were started at what price?
Thanks
Is an existing page relevant?

What karpenter features are relevant?
Logging
How should the docs be improved?

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Metric being added here https://github.com/aws/karpenter/pull/3613. I'll close this, feel free to re-open if you want other specific metrics.


Remove surface parameter

An option discussed in #613

I've had some more time to think about this, and in that time I've leaned even more towards removing surface rather than making it even more present (the associated types PR). I think this PR is the one to merge, and if / when surface is desired in the future it can be re-introduced.

I agree, just gotta figure out how to juggle the release stuff for it now. It's kinda similar to the event-rather-than-EventSource PR, in that it's a breaking change for the current material that's out there for H5.

Perhaps there could be a Halogen 6 branch, where these various PRs can be merged? I could work from that branch to add support for portals, too.

Yeah, good thinking. I'll get that going 🙂.


Cross-compilation with pkgs.pkgsCross fails to find shared objects

Using the following flake:
{
  description = "A very basic flake";
  inputs = {
    nixpkgs.url = "nixpkgs/nixos-21.11";
    utils.url = "github:numtide/flake-utils";
    rust-overlay.url = "github:oxalica/rust-overlay";
    rust-overlay.inputs.nixpkgs.follows = "nixpkgs";
    rust-overlay.inputs.flake-utils.follows = "utils";
  };
  outputs = inputs@{ ... }:
    with inputs;
    with utils.lib;
    eachSystem [ system.x86_64-linux ] (system:
      let
        pkgs = import nixpkgs { inherit system; overlays = [ rust-overlay.overlay ]; };
      in
      {
        devShell = pkgs.mkShell {
          nativeBuildInputs = with pkgs.pkgsCross.aarch64-multiplatform; [
            rust-bin.stable.latest.default
          ];
        };
      }
    );
}

results in this error:
shrinking RPATHs of ELF executables and libraries in /nix/store/9yx88fhv5qp60j63sb4792s06qpd20fl-rustfmt-preview-1.60.0-aarch64-unknown-linux-gnu
shrinking /nix/store/9yx88fhv5qp60j63sb4792s06qpd20fl-rustfmt-preview-1.60.0-aarch64-unknown-linux-gnu/bin/rustfmt
shrinking /nix/store/9yx88fhv5qp60j63sb4792s06qpd20fl-rustfmt-preview-1.60.0-aarch64-unknown-linux-gnu/bin/cargo-fmt
patching script interpreter paths in /nix/store/9yx88fhv5qp60j63sb4792s06qpd20fl-rustfmt-preview-1.60.0-aarch64-unknown-linux-gnu
checking for references to /build/ in /nix/store/9yx88fhv5qp60j63sb4792s06qpd20fl-rustfmt-preview-1.60.0-aarch64-unknown-linux-gnu...
automatically fixing dependencies for ELF files
searching for dependencies of /nix/store/9yx88fhv5qp60j63sb4792s06qpd20fl-rustfmt-preview-1.60.0-aarch64-unknown-linux-gnu/bin/rustfmt
  libgcc_s.so.1 -> not found!
searching for dependencies of /nix/store/9yx88fhv5qp60j63sb4792s06qpd20fl-rustfmt-preview-1.60.0-aarch64-unknown-linux-gnu/bin/cargo-fmt
  libgcc_s.so.1 -> not found!
autoPatchelfHook could not satisfy dependency libgcc_s.so.1 wanted by /nix/store/9yx88fhv5qp60j63sb4792s06qpd20fl-rustfmt-preview-1.60.0-aarch64-unknown-linux-gnu/bin/cargo-fmt
Add the missing dependencies to the build inputs or set autoPatchelfIgnoreMissingDeps=true

I know there are other ways to cross-compile, however, since rust-overlay is used as an overlay, should this not also work?

Seems to be a dup of #83

        devShell = pkgs.mkShell {
          nativeBuildInputs = with pkgs.pkgsCross.aarch64-multiplatform; [
            rust-bin.stable.latest.default
          ];
        };

Oops, since you are not using callPackage, nativeBuildInputs doesn't trigger package-splicing. If you want to select the cross compiler from x86_64 to aarch64, you should use with pkgs.pkgsCross.aarch64-multiplatform.buildPackages.
Check the cross compilation docs for more info about the callPackages and package-splicing things.

Oh, TIL. I think actual problem is that naersk doesn't use buildPackage, and I just managed to reproduce the error.
Thanks for looking into this!


Cpp API to connect to a Jet member

I was directed to hazelcast cpp client by Vladimir Schreiner with his following reply to one of my questions on the hazelcast github issues feed:
"Jet cluster has multiple APIs. The Pipeline API and DAG API (used to define and execute streaming jobs) can be used just via Java client.
You can use the C++ client for the data storage APIs. The data insertion stage can use C++ client to push the data to Jet cluster. The streaming job picks it from the storage."
So I think this reply means I can connect to a jet member with the cpp api. Now when I use the default configuration to connect to a jet member, I am getting an authentication error altough I set no credentials for client setup. I am actually using the very basic code sample that defines a client and gets a map out of it.
Instead, when I setup an IMDG member, the code sample seems to work. Am I doing something wrong, or did I misunderstand Vladimir's message?
Kind Regards

this basically solved my problem, thank you !

Closing the issue.


Update to "Lesson 4-4: Add a Flat File destination"

Issue moved from MicrosoftDocs/feedback#3263

Please respond to @Joseph-McFadden.

From @Joseph-McFadden on Thursday, November 12, 2020 4:25:26 PM
Describe the bug
https://docs.microsoft.com/en-us/sql/integration-services/lesson-4-4-adding-a-flat-file-destination?view=sql-server-ver15
Visual Studio 2019.  In "Add and configure a Flat File destination" step 14, the mappings for "Flat File Destination Editor" the default mappings for DO NOT include arrows mapping for ErrorCode, ErrorColumn, and ErrorDescription.  As a result, of the non-mappings, the output file ErrorOutput.txt has blank values for ErrorCode, ErrorColumn, and ErrorDescription.
Requesting of revising of step 14 to tell user to map ErrorCode, ErrorColumn, and ErrorDescription between "Available Input Columns" to "Available Destination Columns".  Doing such results in the values being populated in ErrorOutput.txt.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
As is, default result:

Requesting change to tell user to make mappings for error columns:

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Issue moved from MicrosoftDocs/feedback#3263

Please respond to @welcome[bot].

From @welcome[bot] on Thursday, November 12, 2020 4:25:27 PM
Thank you for creating the issue! One of our team members will get back to you shortly with additional information. If this is a product issue, please close this and contact the particular product's support instead (see https://support.microsoft.com/allproducts for the list of support websites).


Added ltrace, strace and Krita

Could you fix the merge conflict? If you have never done so, you may want to read https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

Conflict is now resolved. Thank you for you help :)

Thank you for the contribution!


LateInitUsage: Ignore this rule in tests

I'd like a way to let this rule be inactive when having test code since all of the times I end up initializing those properties in the setUp() method of JUnit4.
Feedback is welcome.

Use a second profile in your gradle config.
detekt {
  ...
  profile("main") {
    ....
  }
  profile("test") {
    config = "override LateInitUsage in second config"
  }
}

Hmm, extending the gradle-plugin to always run all profiles could be an idea for later ...

Hmm I don't like the idea that much of having multiple configurations, that way I end up using more and more configurations file. Would it be possible to have an extra property in the LateInitUsage like ignoreOnClasses that gets a regex and does not run on certain files. I'd then set it to [\w]+Test

Sorry for forgetting to answer on this. Maybe we should add a property on top level of the configuration which just handles test classes. Like the class pattern you implemented for LateinitUsage, we could do the check when running a rule ?
I think tests are so common that it makes sense to integrate the 'knownledge of tests' into detekt? @vanniktech , @Mauin

So there's active and activeInTests? That would apply to every rule?

I see the general point. But how many rules would we actually want to turn off/modify in test source sets?

LateInit for sure and maybe the SpreadOperator.

Hmm yeah maybe not that many rules. Better to start small just in this rule and maybe later adopt for more ^^
NamingConventionsViolation comes into my mind that some ppl wanted to turn it off in test cases
deactivateInTestsWithpattern=*Test sounds strange and yes could be used in BaseRule when the isActive check is done (we already have the ktFile and can easily check the name)

Well, I think using the profiles is a much better way to override certain properties in the config instead of inventing new properties for each rule which is considered subjective.

I agree that the LateinitUsage rule (and probably also others) will be annoying/unnecessary in tests.
Do Checkstyle/PMD/whatever have some "Tests" mode that alter the behavior of rules?

For LateinitUsage I think it is ok to have this class pattern, we can make an exception as lateinit is common in Android

Checkstyle suppressions work like this:
<?xml version="1.0"?>
<!DOCTYPE suppressions PUBLIC
  "-//Puppy Crawl//DTD Suppressions 1.1//EN"
  "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
<suppressions>
  <suppress files="[\w]*Test.java" checks="MagicNumberCheck"/>
  <suppress files="[\w]*Test.java" checks="MultipleStringLiterals"/>
</suppressions>

With PMD you'd use // NOPMD or @SuppressWarning("PMD.Name").

Just to be sure:
I did not mean to introduce a second property for each rule! Just one 'excludedRulesForTests=LateinitUsage` on config top level

Sounds good to me. Should it then be one property to define a regex for test classnames and a second property to suppress certain rules for those files?

I did it a bit differently in #226 I've basically got a regex.

Yes a test classnames regex like in #226 + a comma separated list of rules (yaml supports lists oO)


Update Deps

Despite the name of this branch, we expressly avoid updating discord.js for now, for the same reason that #75 currently fails CI. There's an odd issue that seems to have to do with mixing CommonJS and WASM. A lot of Undici is WASM. Not sure if that's new, but that is the case, and for some reason, Jest doesn't like WASM one bit as presently configured. Will need to port to ESM in order to fix that.
For now, let's just update some other deps.

Gonna fix those red arrows before I mark this as ready.


Status bar

This should be togglable between visible and hidden in the view menu and in preferences.

Current state. Just dummy elements at the moment.

https://user-images.githubusercontent.com/9460130/159144609-1d1eca14-be9f-4e46-a902-462b8035ee42.mov

Update on current state:

https://user-images.githubusercontent.com/9460130/159165442-03a4da93-cd80-419a-80d6-a49cff7bb42f.mov

Padding, spacing, font-sizes and dimensions are slightly off, please refer to the figma concept for exact specifications.

Todo:

[ ] fix padding/spacing
[ ] fix font-size
[ ] animate open behavior


a link within a page for each year in the top of the publication page?

The publication page is too long...

I agree. I was thinking about that, but it seems a bit tricky to achieve the function from the template. I will seek some ways to do that

Oh! That could be an option. Internal links are working. But I was thinking about adding filters to the page directly (so that we could also filter publications with their categories and conferences).

I see, but I think the internal links would be easier.
I like your filter idea, which can also filter the publications by topic or venue as a query.
If it is easy, we can do it, but otherwise, we may not have to do it.


ROX-18473: Add search input to listening endpoints table.

Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

Current dependencies on/for this PR:

master

PR #7021

PR #7024   👈

This comment was auto-generated by Graphite.


add comments to values.yaml, documentation about HA to README.md.gotmpl

added documentation

Thanks @fibbs for your contribution.


Feature: Allow developer to specify the name of the exported file in export method of SolutionSerializer

I would be really interested in rename the file given as a parameter in the method:
@Override
    public void export(File f, S solution) {
}

when extending SolutionSerializer class.

Solution exporter refactor in progress see #44 too.


update v2.4

What model of system are you using?

[ ] Old 3DS
[x] Old 3DS XL
[ ] 2DS (non-XL)
[ ] New 3DS
[ ] New 3DS XL
[ ] New 2DS XL

What is your current Luma3DS version?
If you are running an hourly version of Luma3DS, please manually update to a stable version as I will no longer deal with people who are using hourlies.

[ ] Luma3DS v7.1 + boot9strap v1.0/v1.1
[ ] Luma3DS v8.0 + boot9strap v1.2+
[ ] Luma3DS v8.1 + boot9strap v1.2+
[ ] Luma3DS v8.1.1 + boot9strap v1.2+
[ ] Luma3DS v9.0 + boot9strap v1.2+
[ ] Luma3DS v9.1 + boot9strap v1.2+
[x] Luma3DS v10.0+ + boot9strap v1.2+

What version of Luma Updater are you using?

[ ] v2.0
[ ] v2.1
[ ] v2.1.1
[ ] v2.1.2
[ ] v2.2
[ ] v2.3
[x] v2.4
[ ] v2.5

How are you running Luma Updater?

[x] .cia
[ ] .3dsx + HBL/Rosalina

What problems are you experiencing?
Please tell us what problems you are facing.
I am unable to update from v2.4 to v2.5 through the app
"Could not get Location header for 3xx reply"
What is the exact error code you are receiving?
Please give the exact error code the app gives you.
ded92
Steps to reproduce
I understand I need to update manually however im not very sure how to do so

#53


Thanos Ruler - SHA in tmp filename generates high cardinality metrics.

Hey Thanos team 👋 ,
I'd like to start off by saying that I'm loving this ecosystem. Fabulous work 🎉 . That being said, I noticed something strange while reviewing thanos-ruler metrics:
prometheus_rule_evaluation_failures_total{rule_group="/data/.tmp-rules/eng_ops_demo.alert.yaml.b05953802ce19734934a474645132658d2551b745f65c8e5eaaba4dc24bbefa6.ABORT;poe",strategy="abort"} 1
prometheus_rule_evaluations_total{rule_group="/data/.tmp-rules/eng_ops_demo.alert.yaml.b05953802ce19734934a474645132658d2551b745f65c8e5eaaba4dc24bbefa6.ABORT;poe",strategy="abort"} 11290
prometheus_rule_group_interval_seconds{rule_group="/data/.tmp-rules/eng_ops_demo.alert.yaml.b05953802ce19734934a474645132658d2551b745f65c8e5eaaba4dc24bbefa6.ABORT;poe",strategy="abort"} 30
prometheus_rule_group_last_duration_seconds{rule_group="/data/.tmp-rules/eng_ops_demo.alert.yaml.b05953802ce19734934a474645132658d2551b745f65c8e5eaaba4dc24bbefa6.ABORT;poe",strategy="abort"} 0.009306785
prometheus_rule_group_last_evaluation_timestamp_seconds{rule_group="/data/.tmp-rules/eng_ops_demo.alert.yaml.b05953802ce19734934a474645132658d2551b745f65c8e5eaaba4dc24bbefa6.ABORT;poe",strategy="abort"} 1.598387407251624e+09
prometheus_rule_group_rules{rule_group="/data/.tmp-rules/eng_ops_demo.alert.yaml.b05953802ce19734934a474645132658d2551b745f65c8e5eaaba4dc24bbefa6.ABORT;poe",strategy="abort"} 1

I noticed that the values of rule_group label were a little unexpected. At first I didn't understand why new tmp file were begin generated. After digesting this section of the manager.Update method, it's clear that the need to generate tmp files under /$dataDir/.tmp-rules is to extract the partial response strategy field to be able to leverage upstream prometheus' rule manager.
What I'm struggling to justify is the use of SHA256 to create the new filename:
https://github.com/thanos-io/thanos/blob/master/pkg/rules/manager.go#L351
Problems
I presume this is a quick way of handling collisions in the base filename across different paths. The downstream impact of this is likely unintended, but unfavourable nonetheless. There are two problems that I've identified with the use of SHA256 to ensure file uniqueness:
1.) SHA's in label values in metrics generated by the prometheus ruleManager.
Prometheus' metric and relabeling best practices specifically call out that ID's in labels are not a good idea due to the potential for high cardinality:

Do not use labels to store dimensions with high cardinality (many different label values), such as user IDs, email addresses, or other unbounded sets of values.

Though the argument could be made that the cardinality will scale linearly with number of rule files, which even in large organization would be in the order of thousands/ tens of thousands.
2.) Difficulty in correlating metrics with rule groups.
There is a high possibility that rule files may share names across directories. Moreover they may also share a group. For example there could be two files /rules/team1/deadman_rules.yml and /rules/team2/deadman_rules.yml. Both rule files would have metrics associated with them, but since the file names match the only way of identifying which metrics corresponds to which file would be the SHA. Having to calculate the SHA of the file path to correlate metrics to rule files is an unpleasant experience.
Potential Solutions
One possible way to address this issue would be to use os.MkdirAll) and mirror the directory structure to ensure file uniqeness. Though mirroring changes in the directory structure could get a little complex (cleaning up empty directories for example).
Another possibile solution could be to have the entire path in the file name. This would be fairly easy to implement and would address both the cardinalirty issue as well as the metrics identification issue. A caveat of this would be potentially long label values in the case of several nested directories of rule files. Though prometheus has decided not to restrict the length of labels as discussed in this issue:
https://github.com/prometheus/prometheus/issues/1235
Would love to get your thoughts on this and potentially tackle this issue once a solution is agreed upon.

This is definitely a valid bug, kind of bad those IDs leaked to our metrics ): Thanks for spotting this!

What I'm struggling to justify is the use of SHA256 to create the new filename:
https://github.com/thanos-io/thanos/blob/master/pkg/rules/manager.go#L351

Looks like the ID is only to have a quick way to know if the rule should be reloaded or not (if it changed). This avoids rereading those file content and calculating hash sum all the time.
I think instead of this hash we could just store those in memory and I think that would be the fix

The hash is to differentiate between file dirs, will add comment

More: Hashes does not introduce any cardinality problem because this is just encoded full path. However it's bug because it's not really verbose

Fix: https://github.com/thanos-io/thanos/pull/3102 Please PTAL

@bwplotka  @kakkoyun  Thank you for the quick turn around! Y'all are rockstars!


[21.05] tor: <IP_ADDRESS> -> <IP_ADDRESS>

Motivation for this change
https://security-tracker.debian.org/tracker/CVE-2021-38385
https://blog.torproject.org/node/2062
Fetched with the updateScript and signature verified.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 135466 at 2bafc080 run on aarch64-linux 1

1 package marked as broken and skipped:

torchat

3 packages built successfully:

onionshare
onionshare-gui
tor


config to show/hide motion sequential numbers

Sequential numbers display is now toggled by a config (instead of can_manage rights) in list and detail view. Other sequential number stuff (export; sorting) is not affected
@emanuelschuetze feel free to change/adapt config placement and wording

@emanuelschuetze I rebased it on the newly merged master; I'm not sure why the build failed


[MODEL EVALUATION REQUEST] NbAiLab/nb-sbert-base

Model ID
NbAiLab/nb-sbert-base
Model type
Encoder model (e.g., BERT)
Model languages

[X] Danish
[X] Swedish
[X] Norwegian (Bokmål or Nynorsk)
[X] Icelandic
[X] Faroese
[ ] German
[ ] Dutch
[ ] English

Merged model
Not a merged model

Results are live now!


Class not found : haxe.io.Float32Array

Hi
I cloned the Empty project
git clone --recursive https://github.com/KTXSoftware/Empty.git

executed khamake for html5
node Kha/make -t html5

and while when I execute the khamake server
node Kha/make --server

I can see the project running fine (black canvas)
if I want to use the generated hxml
haxe project-html5.hxml

I get the following error:
..\Kha\Backends\HTML5/kha/graphics4/VertexBuffer.hx:3: characters 7-27 : Class not found : haxe.io.Float32Array

Any ideas?

Forgot that Kha use its own haxe. I tried the following
cd build
..\Kha\Tools\haxe\haxe.exe project-html5.hxml

and it returned without error
My problem though with this setup is I cannot easily use my editor.
is the error outputed using the installed haxe (which is haxe 3.2.0 by the way) expected ?
If so what is the best way to integrate the Kha haxe setup in my editor (I am currently using atom but I often use several others)

Kha can be compiled using regular Haxe 3.2. But the haxe on your path doesn't seem to be 3.2. (haxe.io.Float32Array was introduced with 3.2). What does haxe -version return?

it returned 3.2.0  (I am on another machine now)

And does it work on that machine?

sorry I mean that on the other machine it return 3.2.0. On the current one, i did not try it yet

Ah. Hm. There is something weird going on then. Maybe create a small non-Kha test project that uses Float32Array?

I ll try that and report

just tried on my current machine and it works. so it might indeed be something weird with my installed haxe on the other machine. sorry for the false alert


#Enhancement - Implement run code via webgui

I'm not into typescript and don't really know where to get started if I was to help with this.
But thought it would be cool if you could test your developments directly from VS code instead of opening the GUI. You could add a flag in the settings on how you want it to be executed if the webgui isn't enabled on the abap system.
But you can call SE38 in the webgui for example by
https://localhost:50001/sap/bc/gui/sap/its/webgui?~transaction=*SE38 RS38M-PROGRAMM=ZTEST;DYNP_OKCODE=STRT#...
This executes the program automatically.

@uxkjaer
In theory this should be pretty simple, except maybe for logging in the gui.
function showInGui in file sapgui.ts should check a new parameter in the configuration (which you ser in package.json in the main folder and in interface RemoteConfig of config.ts), and when requested open a webview with retainContextWhenHidden set to true.
But the browser in vscode has some limitations, I'm not sure this would work. In case I would definitely start replacing the code in showInGui with something that opens a fixed webgui url and lets me log in manually.
If we can get that to work the rest is plumbing (well, except maybe skipping the login screen)
If we can't no reason to waste our time on other stuff.
Let me know if you need more help.
If it works for you we could start together over zoom or similar

I've figured out how to do the webview and also just calling a browser, however in the webview it complains I think because of the self signed certificate. So that might not be an option.
Currerntly I've just got in another "dummy" extension. I would be happy to get on a zoom with you. I'll reach out via twitter and we can arrange a time. I'm not sure how I can use the local developer version that I've forked instead of the extension from marketplace, when I run in debug and have the extension disabled it doesn't seem to pick it up still.

You need to build it first.
Open it as a workspace, and in its root folder run first
npm i
```
and then
```bash
npm run watch
```

Then select the client run configuration and hit F5

It crashed on me. But possibly because I'm running in wsl. Then I tried in Windows, but I don't have npm installed. I'll get that sorted.

Always worked on linux, wouldn't be surpried if needs some tweaking in windows

I had some success today. If you add sap-user and sap-password to the url, then you can at least open a browser gui with
commands.executeCommand('vscode.open', Uri.parse('https://localhost:50001/sap/bc/gui/sap/its/webgui?sap-user=developer&sap-password=Ldtf5432&language=EN&~transaction=*SE38 RS38M-PROGRAMM=ZTEST;DYNP_OKCODE=STRT#...'));
It does require the Login XSRF Protection to be turned off though.

But it's really fast!
https://user-images.githubusercontent.com/8186370/109790461-2a650b80-7c5d-11eb-8560-aa8c99c277a7.mp4

Indeed, much quicker than starting a real sapgui!
If we figure out how fiori apps pass the login token to the gui we might be able to skip the user/pass in URL, which is a terrible security flaw
Afraid they just share the same session.
BTW, I thought you wanted the GUI embedded inside vscode, not the html version

Yeah that is the plan. However I am struggling with the webview as I get this error. I think it's because it's a self signed certificate. I'm just working on getting my certificate signed.

I don't think the webview can do as we want. However this seems interesting.
https://github.com/auchenberg/vscode-browser-preview
I had some success here using this.

commands.executeCommand('browser-preview.openPreview', 'https://localhost:50001/sap/bc/gui/sap/its/webgui?sap-user=developer&sap-password=Ldtf5432&language=EN&~transaction=*SE38 RS38M-PROGRAMM=ZTEST;DYNP_OKCODE=STRT#...');

it's built on a webview, so if taht works so can the webview. Might needwork
https://github.com/auchenberg/vscode-browser-preview/blob/master/ext-src/BrowserViewWindow.ts

It could be because I've tried to load the webgui in an iframe. But couldn't find any other way.

I've forked your repo and added some code. I can now launch the webgui via config. However I can't get it to build as it complains about
Property 'useWebguiEmbedded' does not exist on type 'RemoteConfig'.ts(2339)
I've added the useWebguiEmbedded to the ClientConfiguration and also in the package.json file as default false. But that didn't help.

Interesting I like this let me read how enable this

On Mar 3, 2021 at 7:58 AM,  <Jakob Marius Kjaer (mailto:notifications@github.com)>  wrote:
I've forked your repo and added some code. I can now launch the webgui via config. However I can't get it to build as it complains about
Property 'useWebguiEmbedded' does not exist on type 'RemoteConfig'.ts(2339)
I've added the useWebguiEmbedded to the ClientConfiguration and also in the package.json file as default false. But that didn't help.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly,   view it on GitHub (https://github.com/marcellourbani/vscode_abap_remote_fs/issues/144#issuecomment-789696182), or   unsubscribe (https://github.com/notifications/unsubscribe-auth/AAEFMPZJNMHF6UNC5YEP4CTTBYW7DANCNFSM4YMLIHZA).

Interesting I like this let me read how enable this

On Mar 3, 2021 at 7:58 AM,  <Jakob Marius Kjaer (mailto:notifications@github.com)>  wrote:
I've forked your repo and added some code. I can now launch the webgui via config. However I can't get it to build as it complains about
Property 'useWebguiEmbedded' does not exist on type 'RemoteConfig'.ts(2339)
I've added the useWebguiEmbedded to the ClientConfiguration and also in the package.json file as default false. But that didn't help.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly,   view it on GitHub (https://github.com/marcellourbani/vscode_abap_remote_fs/issues/144#issuecomment-789696182), or   unsubscribe (https://github.com/notifications/unsubscribe-auth/AAEFMPZJNMHF6UNC5YEP4CTTBYW7DANCNFSM4YMLIHZA).

Hi. So far it's still in development. Still a bit to go before this will be working. Currently I've done some changes in my repo. You can clone that and compile it. If you want it in the extension, then you will have to wait for the new version when and if @marcellourbani decides to merge my pr.

Someone help me try this exactly what i need to know

@soydepr this is a work in progress, no yet included in the main codebase.
To test this you need to

clone Jacob's fork
open the workspace in vscode
switch to the branch he's working on
in the main folder run npm i
and then npm run watch
run the client debug configuration

Be prepared to hack around to get it working

i wait until you release   thanks

@uxkjaer
with today's commit autologin works in chrome, but is a heavyweight solution based on puppeteer.
Plan to replace with an HTTP server which should work with any browser

Awesome. I'll pull your changes and have a look today.

@uxkjaer I gave up getting this to work without puppeteer: the alternatives require either setting up a local proxy server or relying on selenium API, which requires to download drivers.
Needs cleanup and a 'browser path' option before releasing, maybe this evening or maybe tomorrow

Maybe consider using playwright. That works based on puppeteer, but can run on Firefox, Chrome and Web kit

As I understand that's headless, we want to connect and hand over to the
user
On Mon, Mar 22, 2021 at 1:27 PM Jakob Marius Kjaer @.***>
wrote:

Maybe consider using playwright. That works based on puppeteer, but can
run on Firefox, Chrome and Web kit
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/marcellourbani/vscode_abap_remote_fs/issues/144#issuecomment-804060089,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASW6HL62453FWE7F6IZDGDTE5ATXANCNFSM4YMLIHZA
.

published :)
On Mon, Mar 22, 2021 at 2:02 PM Marcello Urbani @.***>
wrote:

As I understand that's headless, we want to connect and hand over to the
user
On Mon, Mar 22, 2021 at 1:27 PM Jakob Marius Kjaer <
@.***> wrote:

Maybe consider using playwright. That works based on puppeteer, but can
run on Firefox, Chrome and Web kit
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/marcellourbani/vscode_abap_remote_fs/issues/144#issuecomment-804060089,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASW6HL62453FWE7F6IZDGDTE5ATXANCNFSM4YMLIHZA
.


How to generate TREC COVID?

I want to generate TREC COID file, e.g.  run.covid-r1.fusion1.txt, I have tried to run
./bm25_retriever/bin/IndexCollection -collection JsonCollection -input {your collection} -index {index path} -generator LuceneDocumentGenerator -threads 8 -storePositions -storeDocvectors -storeRawDocs >& {log file path}
Search by BM25:

./bm25_retriever/bin/SearchCollection -index {index path} -topicreader {topic format} -topics {topic path} -bm25 -output {result file path}
But there is gap betweendownloaded  dataset e.g.  cord-19_2020-05-01.tar.gz  and index input {your collection}.
Could you help me?  Thanks a lot.

We followed anserini to generate these data, here's the links:

https://github.com/castorini/anserini/blob/master/docs/experiments-cord19.md
https://github.com/castorini/anserini/blob/master/docs/experiments-covid.md

Thanks a lot.


Bug fixes and new game feature

I have added the mentioned fixes as per issue #23.
Changes I have implemented:

[x] Fixed the double highlighting issue.
[x] Added the new game feature.
[x] Fixed regex to accept capital letter input as well.

Before:

After:

There have been some changes done by the formatting tool automatically, which makes the code more compliant to best practices.

Also add your code snippet.

The changes have been implemented like this:

Double highlighting issue has been resolved by making a different function to mark it as correct/wrong-location.

New game feature has been implemented by using the startNewGame() function.

RegEx fix is as follows.


本地部署的minio S3报错

Describe the bug
ERROR server error method=/memos.api.v1.ResourceService/CreateResource error="rpc error: code = Internal desc = failed to save resource blob: Failed to upload via s3 client: operation error S3: PutObject, exceeded maximum number of attempts, 3, https response error StatusCode: 0, RequestID: , HostID: , request send failed, Put "https://memos.xxxxx.xxxxxx.xxx/assets/1716288308_hfdghgfhj.png?x-id=PutObject\": remote error: tls: unrecognized name"

Steps to reproduce
.
The version of Memos you're using
0.22.0
Screenshots or additional context
No response

Bucket自动添加到前边了

Bucket自动添加到前边了

这个是新版的bug吗

https://github.com/usememos/memos/issues/3397

您发来的邮件我已经收到...


error message master

Hi All,
After a successful deployment of a mysql cluster, which is doing ok from front user perspective I see in the log of the master POD constantly this warning:
2018-11-14T00:13:05.066125Z 3540 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:05.833254Z 3541 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:06.577661Z 3543 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:07.371096Z 3545 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:08.062420Z 3547 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:08.794016Z 3549 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:09.576521Z 3553 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:10.320451Z 3554 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:11.054265Z 3556 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:11.836449Z 3557 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:12.607582Z 3558 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:13.352802Z 3561 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:14.115581Z 3564 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:14.859339Z 3566 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:15.596738Z 3568 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:17.034794Z 3570 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:17.823525Z 3572 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:18.519085Z 3573 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:19.288416Z 3577 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:20.001649Z 3579 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:20.773202Z 3580 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)
2018-11-14T00:13:21.517423Z 3582 [Note] Access denied for user<EMAIL_ADDRESS>(using password: YES)

any idea what is going on?
thx

Hi,
The operator does not use root user to connect to the MySQL server. Did some apps try to connect to the cluster with the root user?
Thanks!

HI @AMecea
Only Adminer, which I use from within the cluster, but not that frequently. And the PHP app (api for front) is using root. But if this should fail the API will not work and that's not the case. the API is working like expected.


Fix audit revision query for enum column mapping

Subject

I am targeting this branch, because it's a bug fix.
After https://github.com/doctrine/orm/pull/10088 we get an enum object back in the DEL revision saveRevisionEntityData code path instead of an integer or string value which then blows up on the $conn->executeStatement() call with the following exception:
Error: Object of class Sonata\EntityAuditBundle\Tests\Fixtures\Issue\Status could not be converted to string

vendor/doctrine/dbal/src/Driver/PDO/Statement.php:56

Changelog

### Fixed
- Audit query for Doctrine ORM >= 2.14.1 for entities with enumType column mapping

Even though the test I've added is marked as requiring PHP 8.1 to run, the PHP 7.4 and PHP 8.0 pipelines are still failing as the entity with the enum mapping class metadata is still being registered (so it blows up in Doctrine/ORM/Mapping/ClassMetadataFactory). Does anybody have a suggestion how we can solve this?

Filtering here maybe https://github.com/sonata-project/EntityAuditBundle/blob/1.x/tests/BaseTest.php#L98-L102

Even though the test I've added is marked as requiring PHP 8.1 to run, the PHP 7.4 and PHP 8.0 pipelines are still failing as the entity with the enum mapping class metadata is still being registered (so it blows up in Doctrine/ORM/Mapping/ClassMetadataFactory). Does anybody have a suggestion how we can solve this?

Filtering here maybe https://github.com/sonata-project/EntityAuditBundle/blob/1.x/tests/BaseTest.php#L98-L102

@VincentLanglet Thanks - all CI pipelines have now passed :tada:

Thanks


Refundable post delivery crowdsale

Fixes https://github.com/OpenZeppelin/openzeppelin-solidity/issues/877
Since this is a PostDeliveryCrowdsale, tokens will only be granted after it ends, and only if the crowdsale is successful (i.e. the goal is met): therefore, the tokens being issued and purchases being refunded become mutually exclusive scenarios, preventing the issue described.
I made the new crowdsale inherit from RefundableCrowdsale, but if we chose to deprecate it (i.e. pragma deprecated or something along those lines) we will probably want to copy the logic into this new contract.

In this PR we should also add the warning (the "deprecation warning") in RefundableCrowdsale.


ajax? related exception in log when starting LightTable 0.8-alpha on windows 7

Downloaded zip, unpacked and started the exe. (in parallells on a mac)
LT starts but noticed an error message in the console:
    SyntaxError: Unexpected end of input
    at Object.parse (native)
    at file:///C:/apps/lighttable-0.8.0-alpha-windows/resources/app/core/node_modules/lighttable/bootstrap.js:35374:223
    at file:///C:/apps/lighttable-0.8.0-alpha-windows/resources/app/core/node_modules/lighttable/bootstrap.js:23187:14
    at null.<anonymous> (file:///C:/apps/lighttable-0.8.0-alpha-windows/resources/app/core/node_modules/lighttable/bootstrap.js:23199:16)
    at goog.events.Listener.handleEvent (file:///C:/apps/lighttable-0.8.0-alpha-windows/resources/app/core/node_modules/lighttable/bootstrap.js:14143:51)
    at Object.goog.events.fireListener (file:///C:/apps/lighttable-0.8.0-alpha-windows/resources/app/core/node_modules/lighttable/bootstrap.js:14378:12)
    at Object.goog.events.fireListeners_ (file:///C:/apps/lighttable-0.8.0-alpha-windows/resources/app/core/node_modules/lighttable/bootstrap.js:14368:53)
    at Object.goog.events.dispatchEvent (file:///C:/apps/lighttable-0.8.0-alpha-windows/resources/app/core/node_modules/lighttable/bootstrap.js:14421:47)
    at goog.events.EventTarget.dispatchEvent (file:///C:/apps/lighttable-0.8.0-alpha-windows/resources/app/core/node_modules/lighttable/bootstrap.js:14542:22)
    at goog.net.XhrIo.dispatchErrors_ (file:///C:/apps/lighttable-0.8.0-alpha-windows/resources/app/core/node_modules/lighttable/bootstrap.js:16377:62)```

not having much luck connecting to clojure projects on windows 7. maybe unrelated.

I had a little trouble connecting a Clojure project on one of my Windows 7 computers, but not on the Windows 7 computer I use most of the time.

I haven't seen this error on the Windows 7 computer I use most of the time.

Maybe it's just my parallells/windows setup or somehow some old metadata lying around. I'll try to clean all traces of Light Table and give it another go.

I'm getting a very similar exception quite often on my mac. I think I've tracked it down to LT eagerly checking for a new version. And when doing a xhr request to the lighttable github repo it fails for some reason (missing/sketchy connection might be one).
I think some error handling around here would be in order:
https://github.com/LightTable/LightTable/blob/master/src/lt/objs/deploy.cljs#L134
SyntaxError: Unexpected end of input
    at Object.parse (native)
    at lt.objs.deploy.__GT_latest_version (file:///Users/mrundberget/projects/LightTable-Projects/LightTable/builds/lighttable-0.8.0-alpha-mac/LightTable.app/Contents/Resources/app/core/node_modules/lighttable/bootstrap.js:29037:11)
.....
Failed to load resource: net::ERR_NAME_NOT_RESOLVED: https://api.github.com/repos/LightTable/LightTable/tags

That's similar to (or the same as?) the errors I still get accessing some of the GitHub-hosted LT subdomains on my (Windows 7) computer at work – the DNS lookup fails for some reason I couldn't figure out. I don't think anyone else had the same problem so I gave up looking into it.

I have the same problem. Just downloaded Light Table and opened it in El Capitan.

I realized this only happened when I used the table CLI command to open the app. If I open it normally, it works fine.


Close message box

Hi,
I am failing to see a method that can close the message box. I want to close it through code, not waiting for the user interaction.

Check new version, it's should be work ok, if no reopen issue


Won't start ("No permission to fork process")

I cloned this repo, installed the deps. When running swipl -s main.pl -- --port=8080, I get this:
Running in development mode!
% 2019-06-09 17:38:31.150 type post preview URL /post/<slug> registered
No permission to fork process `main' (running_threads([<thread>(3,0x559515090e50),<thread>(4,0x559515133650),<thread>(5,0x5595151d92d0)]))

Using SWI-Prolog version 8.0.2 for x86_64-linux.
(Your own blog looks really nice, and was surprised to see that it was built in SWI Prolog. I'm curious about trying it out!)

Hey @hjek, you need to run with --interactive=true option, otherwise it tries to fork and daemonize the process. It uses http://www.swi-prolog.org/pldoc/man?section=httpunixdaemon.
I will update the README.


Fix error in nightly spark: add env PYSPARK

Description

Fix the error in the nightly build in the benchmark notebook for Spark
Related Issues

Fix https://github.com/microsoft/recommenders/issues/1898
References

Checklist:

[ ] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[ ] This PR is being made to staging branch and not to main branch.

Nightly working: https://github.com/microsoft/recommenders/actions/runs/4563686982/jobs/8052496808
Kudos to @loomlike


DynamincSelectModel prefix

I can't add prefix to Dynamic select model it should be possible

@stemyke Ok, I'll have to check how this supported in Bootstrap and Foundation.

Closed as this is not supported by Bootstrap or Foundation. Use <template> instead.

I don't know how Foundation works, but I managed to do that in Bootstrap just by copying this two file to my src:
@ng2-dynamic-forms\ui-bootstrap\src\dynamic-form-bootstrap.component.html
@ng2-dynamic-forms\ui-bootstrap\src\dynamic-form-bootstrap.component.ts
and put the select field into a container div like you did with the normal input field.
I also copied
@ng2-dynamic-forms\core\src\model\select\dynamic-select.model.ts
and added, this two lines:
@serializable() prefix: string | null;
@serializable() suffix: string | null;

to DynamicSelectModelConfig and this two lines:
    this.prefix = getValue(config, "prefix", null);
    this.suffix = getValue(config, "suffix", null);

to DynamicSelectModel constructor.
With this I have a nice icon (now it is wrong) before the Country select field, but it is not a nice solution to copy your code to my project.

I can't do the same thing with template, because with it, I can't position my prefix icons to the same line.


bundler works

This allows bundle, bundle install, bundle exec ..., etc.

:cool: thanks for the patch!


add queryz unit test

move registerQueryzHandler to queryctl.go
move newTestSchemaInfo from schema_info_test.go to testutils_test.go

lgtm


Increment versions for datafactory releases

Increment package versions for datafactory releases

API change check
API changes are not detected in this pull request.


KEDA joining the Phippy and Friends family

As @zroubalik pointed out, we can propose to introduce a new character in the Phippy and Friends family that represents KEDA.
This issue is to brainstorm names and animals after which we can cast a vote.
The criteria is listed here but basically comes down to:

Characters can be any animal you choose, and the animal does not necessarily need to be alive today (who doesn’t love dinosaurs?!)
The first letter of your character’s name should match the first letter of your project and the first letter of your chosen animal (e.g Goldie the Go Gopher).
Characters should ideally be a specific animal, and not a collective noun for a species (for example, the Prometheus Puppy is not specific enough, but you could have the Prometheus Pug).
Characters should also be child-friendly, as Phippy and Friends are often used to help younger folx learn about cloud native computing.

What a coincidence - https://www.cncf.io/blog/2024/03/11/istio-joins-phippy-and-friends-welcome-izzy/

The Istio Steering Committee is excited to unveil Izzy Dolphin, the Istio Indo-Pacific Bottlenose, who today dives into the family of “Phippy and Friends”.

I need to think about name of our character but I like these animals:

Bears - Because we do the heavy lifting to make sure everyone survives the load

Kermode bear (aka the spirit bear)

Kodiak bear

Birds - Because we oversee the application landscape and make sure things are as they should

Kookaburra

Kingfisher

King penguin because they live in large herdes, similar to the large amount of replicas we schedule

Let's suggest other "cute" animals xD:

Kangaroo

Kiwi

Koala

My vote is for "Kedy Koala" xD

I've thought about Koala, but those are lazy and we are not :D

If we want dinosaurs: https://www.extinctanimals.org/dinosaurs/dinosaurs-that-start-with-k

Ok I gave this some more thought and think my preference goes to Kermode bear because:

KEDA does the heavy lifting of scaling all the apps for end-users; and bears are strong as well
KEDA is a crucial asset in reducing carbon emission to save our planet; and this bear subspecies is nearly extinct as there are only 400/1600 left (based on google)
KEDA helps app operators sleep at night; and I like that this bear is called spirit bear

But I may be thinking about this too much =)
You can say the same for King penguin though:

Lives in artic circle which we need to protect by reducing our environmental footprint
They live in large groups, similar to KEDA scaling out

But who doesn't love a bear?!
In terms of names, I  don't think it has to start with Ke so here are some ideas:

Kaws - Kubernetes Application Workload Scaling (I wanted Klaws to pronounce as 'Claus' but could not find meaning for L :))
Koli
Kobi
Kamo

I might have gone down the rabbit hole on this and been thinking about this too much =)

Puffer fish.. they grow and shrink when needed:

Bet they could have fun with it in its puffy state at times

Puffer fish.. they grow and shrink when needed:

The animal must start with the project name ( "K" in this case)

Kpuffer fish then!

I like the sound of "Keddy".
Make me think of "Keddy the Teddy" (bear), but if we need a "K" for the animal... "Keddy the Kuala" ?

What about: "Keddy the Kangaroo."
If kangaroos have something, it is that they attract a lot of attention in any image or, in this case, artwork.

I like the sound of "Keddy".
Makes me think of "Keddy the Teddy" (bear), but if we need a "K" for the animal... "Keddy the Kuala" ?

That was the joke that @zroubalik and @JorTurFer came up with! So I suggested Keddy the Kermode bear (see why I like this bear)

I don't have any preference for the animal tbh, but I think that nobody will think about why that specific animal but everyone will think if it's cute and pretty or not, so I'd go with the most cute. Kanguro, Kuala, Kiwi, etc...

I don't have any preference for the animal tbh, but I think that nobody will think about why that specific animal but everyone will think if it's cute and pretty or not, so I'd go with the most cute. Kanguro, Kuala, Kiwi, etc...

I think that's up to us to decide, though. Istio's animal also is not named with I, but they chose a specified breed.
Anyway, just sharing :) I don't want to force things, but bears are cute too! (don't try to hug them though)

Good with any of these 😂

"Keddy the Kanguroo" is becoming stronger! 💪 xD

So shall we go with "Keddy the Kangaroo" then, @JorTurFer/@zroubalik?

It's sounds good!

I prefer bear of Kangaroo, but I think I can live with either option :)

Keddy the Kodiak Bear
Keddy the Kermode Bear
Keddy the Kangaroo

I also prefer bears but I was trying to find a consensus - I don't have a preference on the flavor of bear though

I prefer Kangaroo over bear, but we can go with bear if you have it clear xD

We have discussed this offline and decided to go with Keddy the Kodiak Bear.
Servicedesk ticket is open: https://cncfservicedesk.atlassian.net/servicedesk/customer/portal/1/CNCFSD-2233?created=true


Fixing a comment to reflect correct command

AFAIK, there is no 'docker image inspect' but rather 'docker inspect '

- What I did
Fixing what seems to be a typo in a comment
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:harche/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Harshal Patil<EMAIL_ADDRESS>

Actually, there is; https://docs.docker.com/engine/reference/commandline/image/
Docker 1.13 and 17.03 introduced top level commands, group by "object type" (e.g., docker container inspect, docker volume inspect, docker secret inspect, etc.)
I'll close this PR, because the original comment was correct, but thanks for contributing

@harche thanks for the contribution, but the comment is correct, this code is for docker image inspect command (and not docker inspect command). I'll close, but thanks 🤗

$ docker image inspect
docker: 'image' is not a docker command.
See 'docker --help'.
$

$ docker image --help
docker: 'image' is not a docker command.
See 'docker --help'.
$

What am I missing here?
$ docker info
Containers: 98
 Running: 0
 Paused: 0
 Stopped: 98
Images: 17
Server Version: 1.12.6
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 230
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null bridge host overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: apparmor seccomp
Kernel Version: 4.4.0-70-generic
Operating System: Ubuntu 16.04.2 LTS
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 7.504 GiB
Name: harshal-ThinkPad-T450
ID: CHWO:C47J:VEGI:PGXN:GCBC:QLSW:5KMX:NWZ4:NDNF:NMSP:C7AC:BX7O
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Insecure Registries:
 <IP_ADDRESS>/8

I just realized I am running a slightly older version. :)

Yes, that's an older version of docker, which does not yet have those commands :smile:

BTW, I was running some comments through grammerly and it complained about line https://github.com/docker/docker/blob/master/image/image.go#L50
Not sure if it's intended, but grammerly tells me it should be 'Architecture is the hardware that the image is built and runs on'

Yes, looks like that's a typo


Move @server.upstream to @upstream

Before
schema @server(port: 8080, upstream: {userAgent: "graphql/tailcall"}) {
  query: Query
}

After
schema @server(port: 8080) @upstream(userAgent: "graphql/tailcall") {
  query: Query
}

This restructure makes the DSL look a lot cleaner and keeps the upstream configurations out of the general server configurations.

I'd like to give it a shot!

seems there is another issue that even if, in server directive, the upstream field cannot be parsed correctly into Server Object.

Thanks, fixed the example


Added Academy Of Technology Domain

College Website: https://aot.edu.in/
Courses Link: http://aot.edu.in/academics/

@debdutgoswami Pull request merged. Thank you!


Control center fails to connect to brokers

I'm using a default configuration with the PLAINTEXT template, changing nothing but the host IP addresses in the inventory. After installing, Kafka and Zookeeper work fine, able to create topics. Control center, however, fails miserably, showing the following error in control-center.log:
 ERROR [main] Broker check failed. Ensure that Kafka is running on any of the hosts: [<IP_ADDRESS>:9092, <IP_ADDRESS>:9092, <IP_ADDRESS>:9092] (io.confluent.controlcenter.KafkaHelper)

And the following error in control-center-kafka.log:
[2019-08-21 21:17:38,252] WARN [kafka-admin-client-thread | adminclient-1] [AdminClient clientId=adminclient-1] Connection to node 1 (CENTOS-7/<IP_ADDRESS>:9092) could not be established. Broker may not be available. (org.apache.kafka.clients.NetworkClient)

[2019-08-21 21:17:38,453] WARN [kafka-admin-client-thread | adminclient-1] [AdminClient clientId=adminclient-1] Connection to node 3 (CENTOS-7/<IP_ADDRESS>:9092) could not be established. Broker may not be available. (org.apache.kafka.clients.NetworkClient)

[2019-08-21 21:17:38,854] WARN [kafka-admin-client-thread | adminclient-1] [AdminClient clientId=adminclient-1] Connection to node 2 (CENTOS-7/<IP_ADDRESS>:9092) could not be established. Broker may not be available. (org.apache.kafka.clients.NetworkClient)

What's really weird here, is it's seems to be trying to connect to all three brokers at <IP_ADDRESS>? But, that IP is not specified in the list of Kafka broker hosts, and it certainly shouldn't be the same for all three brokers.
Installing on CentOS 7, firewalls all disabled. I cannot figure out why control center can't connect to the brokers.
This is the hosts file:
all:
  vars:
    ansible_connection: ssh
    ansible_become: true
    security_mode: plaintext
    ansible_ssh_user: myusername
preflight:
  hosts:
    <IP_ADDRESS>:
    <IP_ADDRESS>:
    <IP_ADDRESS>:
    <IP_ADDRESS>:
ssl_CA:
  hosts:
    <IP_ADDRESS>:
zookeeper:
  hosts:
    <IP_ADDRESS>:
    <IP_ADDRESS>:
    <IP_ADDRESS>:
broker:
  hosts:
    <IP_ADDRESS>:
      kafka:
        broker:
          id: 1
    <IP_ADDRESS>:
      kafka:
        broker:
          id: 2
    <IP_ADDRESS>:
      kafka:
        broker:
          id: 3
schema-registry:
  hosts:
    <IP_ADDRESS>:
control-center:
  hosts:
    <IP_ADDRESS>:
      confluent:
        control:
          center:
            config:
              confluent.controlcenter.connect.cluster: <IP_ADDRESS>:8083
connect-distributed:
  hosts:
    <IP_ADDRESS>:
kafka-rest:
  hosts:
    <IP_ADDRESS>:
ksql:
  hosts:
    <IP_ADDRESS>:

@kkotowick What version of the playbooks are you running?  Based on having the 'pre-flight' role, I suspect this is an older unsupported version.  Do you see the same issue with the 5.3.0-post branch?

@kkotowick because I haven't heard back from you in some time on this, I am going to go ahead and close it out.


Routes on index page and contributions

I fixed the dead routes on the index and contributions page! Im still kinda new how do i push for you to verify and merge?

remote: Permission to lingonsaft/hacktoberfest.git denied to ryanlsmith4. << this is my error

@ryanlsmith4 https://youtu.be/DIj2q02gvKs

Closing this for now


Hotfix auth

checkin.py
auth=None
if checkin_client_secret:
    auth=(checkin_client_id, checkin_client_secret)
    refresh_data.update({"client_secret": checkin_client_secret})
r = requests.post(token_url, auth=None, data=refresh_data)
r.raise_for_status()
return r.json()

r = requests.post(token_url, auth=None, data=refresh_data)
should be like this:
r = requests.post(token_url, auth, data=refresh_data)

good catch!
Can you submit a PR? I will approve it right away

checkin.py
auth=None
if checkin_client_secret:
    auth=(checkin_client_id, checkin_client_secret)
    refresh_data.update({"client_secret": checkin_client_secret})
r = requests.post(token_url, auth=None, data=refresh_data)
r.raise_for_status()
return r.json()

r = requests.post(token_url, auth=None, data=refresh_data)
should be like this:
r = requests.post(token_url, auth, data=refresh_data)

ERROR: Permission to EGI-Federation/egicli.git denied to UkrainskyiRostyslav.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

you need to fork and submit the PR from there. If too much of a hassle I can create the patch myself.

Hello @enolfc
I've created the PR, so feel free to review it. If there are any additional actions required from me (e.g. additional notes in PR's description or commits' style), please leave me a comment.


all bot can't be started when there is error in bot project

Describe the bug

I have a bot project which includes three bots, one is echo, one is luis and the other is qna, I didn't assign luis and qna keys in this bot project so, I got error for luis and qna bot.
I can start the echo bot here, but I can't expand the bot menu on the right side, so I can't try the echo bot in emulator.

And click the error, the error page doesn't direct me to the location of the error.

Expected behavior:
I can test my bot without errors through emulator.
Version

Browser

[ ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Screenshots

Additional context

Describing the issue in a different way:

If you have a bot project and one of the bots has an error, the "Start all bots" control is disabled.
You can still start individual bots via the project tree, but the controls to test in Web Chat or in Emulator are only available in the "Local bot runtime manager":
When the "Start all bots" control is disabled, the button for opening the "Local bot runtime manager" dropdown is also disabled.
The "Local bot runtime manager" dropdown opens when a bot is run successfully, but if the "Start all bots" button is still disabled, when you close the drawer you cannot open it again.

https://user-images.githubusercontent.com/39317542/124308184-bdd01f80-db1d-11eb-9f93-fedd7c40ec81.mov
Possible fixes (independent of each other):

Do not disable the "Start all bots" control when there is an error in one of your bots?
Enable the "Start all bots" when one bot is run successfully?
De-couple the "Start all bots" state from the button to open the runtime manager, so disabling the "Start all bots" button does not disable the "Local bot runtime manager" dropdown, and therefore does not prohibit access to the testing buttons


http 400 when downloading some emoji

stickpackage:
https://t.me/addstickers/Bocchi_the_Rock_sticker
https://t.me/addstickers/Bocchi_the_Rock_sticker_pack2
download fail;
but https://t.me/addstickers/Spy_Family success

the same stickpackage, the same issue

the same stickpackage, the same issue

Error 400 when sticker have GIF.

GIF is now supported.


⚠ Bofrost.fr has degraded performance

In 8a30993, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1389 ms

Resolved: Bofrost.fr performance has improved in 16511c0 after 6 minutes.


Fix safe CmdBuildAccelerationStructuresIndirect signature and add extra length validation

Came across the original PR introducing headers 1.2.162 with the official KHR RayTracing spec, and found a slightly related comment (https://github.com/MaikKlein/ash/pull/341#discussion_r541967759) about unfortunate casts that could have been safe transmutes because references to PODs have the same size as raw pointers. Turns out these shouldn't be normal pointers but slices (fat pointers) :anguished:
In addition this PR introduces extra asserts: we're exposing a "safe" (still marked unsafe though, just type reinterpretation) layer that should at the very least validate the length of this and other nested arrays.

@MaikKlein That has actually been slightly alleviated not to require a potential secondary allocation with https://github.com/MaikKlein/ash/issues/380#issuecomment-787103648 / https://github.com/Traverse-Research/ash/commit/a94b018b4101b97cd04fd42fa0e5d67f23a72e8d. Perhaps we should purse such solutions, or otherwise add functions that accept raw pointers like &[*const u32]?


Can't consume kslides

adding kslides as maven dependency to a project succeeds but downloads an empty jar with just manifest.
It is either you are publishing an empty jar, or jitpack is serving an empty jar.

That is not cool. Let me try it with Maven.

I created a Maven version of a slideshow, and it works. However, Maven requires 2 additional dependencies to be included (which I guess gradle imports automatically). Try adding these two and see what happens:
        <dependency>
            <groupId>org.jetbrains.kotlinx</groupId>
            <artifactId>kotlinx-html-jvm</artifactId>
            <version>0.7.5</version>
        </dependency>

and
        <dependency>
            <groupId>org.jetbrains.kotlin-wrappers</groupId>
            <artifactId>kotlin-css</artifactId>
            <version>1.0.0-pre.343</version>
        </dependency>

This is the pom.xml I used: https://gist.github.com/pambrose/ecf7021f5e3abc785a81bed3241a2b2b

Adding kotlin-css and kotlinx-html as gradle dependencies only resolves them. I am still failing to use kslides. Even importing from com.kslides.* fails. Have you tried consuming with gradle? or does this just work with maven?

This repo uses gradle with kslides: https://github.com/kslides/kslides-template
I updated the gist above, which has the pom.xml  you need to use maven.
Clone the repo above and it should work fine.

Looking at the template I see where I had it wrong. jitpack instructs to the wrong coordinates. following the link to jitpack, it directs one to include kslides as com.github.kslides.kslides:kslides:<VERSION> instead of com.github.kslides.kslides:kslides-core:<VERSION>. Maybe these coordinates should be somewhere in the README.md to avoid future confusions?


Support iASP

Closing as iASP is being removed from iproj.json

OK, but does Project Explorer work with iASPs?
Has this  been validated?

I have not yet tested this scenario. Will reopen this issue.

Tested and validated


URL Unsupported for Tuckbot.tv, possibly due to hash/pound (#) ?

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2<IP_ADDRESS>
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

% youtube-dl -v 'https://tuckbot.tv/#/watch/lat4hb'
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://tuckbot.tv/#/watch/lat4hb']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 3.9.1 (CPython) - macOS-11.1-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.3.1, ffprobe 4.3.1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] lat4hb: Requesting header
WARNING: Falling back on generic information extractor.
[generic] lat4hb: Downloading webpage
[generic] lat4hb: Extracting information
ERROR: Unsupported URL: https://tuckbot.tv/#/watch/lat4hb
Traceback (most recent call last):
  File "/usr/local/Cellar/youtube-dl/2<IP_ADDRESS>/libexec/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 806, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/Cellar/youtube-dl/2<IP_ADDRESS>/libexec/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 827, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/local/Cellar/youtube-dl/2<IP_ADDRESS>/libexec/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 532, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/Cellar/youtube-dl/2<IP_ADDRESS>/libexec/lib/python3.9/site-packages/youtube_dl/extractor/generic.py", line 3467, in _real_extract
    raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: https://tuckbot.tv/#/watch/lat4hb

Description

I believe I escaped the URL properly after viewing instructions for escaping.
Turns out is was easily downloadable, so posting in case it is a real error and can help future URL error cases.

I think tuckbot.tv is just not supported yet.

Correct. It does have a pretty simple pattern. A URL like
https://tuckbot.tv/#/watch/lanc5v
has a download link of
https://cdn.tuckbot.tv/lanc5v.mp4


fix(DTFS2-6526): focus user to the table header button if it was clicked just now

Introduction :pencil2:
Activating any table header button will cause the table column to become filtered by ascending or descending. Keyboard-only users will be repositioned to the beginning of the main content, and this includes screen reader users. This could be problematic for the user as the user will need to re-navigate to the table content.
Resolution :heavy_check_mark:

Added hidden form input formId to detect what form was just activated. Was it sorting, search or pagination. If formId is deals-table-sorting then we know that sorting event just happened and we can autofocus sort column button.
Added sortButtonWasClicked NJK variable to know if this is new sorting event happened.
Ensured that autofocus doesn't happen for default sort and other navigations, like pagination and search.

Miscellaneous :heavy_plus_sign:
Simplified how we get active order direction, asc or desc. This allows to have more form inputs controllers/deals/index.js line 61

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6da84ce) 21.88% compared to head (fe4661c) 22.38%.
Report is 147 commits behind head on main.

Files
Patch %
Lines

dtfs-central-api/src/drivers/db-client.js
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2491      +/-   ##
==========================================
+ Coverage   21.88%   22.38%   +0.50%
==========================================
  Files        1132     1134       +2
  Lines       27048    27172     +124
  Branches     4447     4463      +16
==========================================
+ Hits         5920     6083     +163
+ Misses      18403    18375      -28
+ Partials     2725     2714      -11

Flag
Coverage Δ

api-test
0.48% <ø> (ø)

ui-test
65.56% <ø> (+0.42%)
:arrow_up:

unit-test
4.28% <0.00%> (+0.50%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Uncaught Error: Protocol version not supported

Trying to connect to my host which supports both FTP and SFTP (but I can't connect using this plugin with SFTP anyway)
Typed port 21
After connection attempt, the error appears

Atom Version: 1.0.5
System: Mac OS X 10.10.4
Thrown From: remote-edit package, v1.8.15
Stack Trace
Uncaught Error: Protocol version not supported
At events.js:141

Error: Protocol version not supported
  at SSH2Stream._transform (/Users/bzx/.atom/packages/remote-edit/node_modules/ssh2/node_modules/ssh2-streams/lib/ssh.js:376:25)
  at SSH2Stream.Transform._read [as __read] (_stream_transform.js:167:10)
  at SSH2Stream._read (/Users/bzx/.atom/packages/remote-edit/node_modules/ssh2/node_modules/ssh2-streams/lib/ssh.js:213:15)
  at SSH2Stream.Transform._write (_stream_transform.js:155:12)
  at doWrite (_stream_writable.js:295:12)
  at writeOrBuffer (_stream_writable.js:282:5)
  at SSH2Stream.Writable.write (_stream_writable.js:210:11)
  at Socket.ondata (_stream_readable.js:524:20)
  at emitOne (events.js:77:13)
  at Socket.emit (events.js:166:7)
  at readableAddChunk (_stream_readable.js:146:16)
  at Socket.Readable.push (_stream_readable.js:109:10)
  at TCP.onread (net.js:517:20)

Commands
     -3:12 hostview:edit (atom-text-editor.editor.mini.is-focused)
     -3:10.5.0 editor:move-to-first-character-of-line (atom-text-editor.editor.mini.is-focused)
     -3:10.2.0 editor:move-to-end-of-word (atom-text-editor.editor.mini.is-focused)
  3x -3:09.9.0 core:move-right (atom-text-editor.editor.mini.is-focused)
     -3:09.2.0 editor:delete-to-beginning-of-line (atom-text-editor.editor.mini.is-focused)
     -0:52.7.0 remote-edit:browse (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-chester-atom-syntax.theme-one-light-ui)
     -0:50.6.0 hostview:edit (atom-text-editor.editor.mini.is-focused)
  2x -0:47.6.0 remote-edit:browse (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-chester-atom-syntax.theme-one-light-ui)
     -0:30.9.0 hostview:edit (atom-text-editor.editor.mini.is-focused)
     -0:23.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
  2x -0:22.3.0 remote-edit:browse (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-chester-atom-syntax.theme-one-light-ui)
     -0:11.1.0 hostview:edit (atom-text-editor.editor.mini.is-focused)
     -0:09.0 editor:delete-to-beginning-of-line (atom-text-editor.editor.mini.is-focused)
  2x -0:08.1.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -0:03.6.0 remote-edit:browse (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-chester-atom-syntax.theme-one-light-ui)
     -0:02.5.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config
{
  "core": {
    "useReactEditor": true,
    "themes": [
      "one-light-ui",
      "chester-atom-syntax"
    ]
  },
  "remote-edit": {
    "showHiddenFiles": true
  }
}

Installed Packages
# User
atom-beautify, v0.28.10
autocomplete-sass, v0.1.0
bezier-curve-editor, v0.7.2
chester-atom-syntax, v0.1.1
emmet, v2.3.12
file-icons, v1.6.3
pigments, v0.9.3
project-manager, v1.15.11
react, v0.12.6
remote-edit, v1.8.15
save-session, v0.15.7
vim-mode, v0.57.0

# Dev
No dev packages

Is your SSH server running on port 21? Thats usually used for FTP. SSH normally uses port 22.

It wasn't SSH, I was trying to connect using FTP protocol, so port is 21. But now it does connect with no errors. Thanks


File encryption/decryption

Changes:

Added section for encrypting/decrypting files

Next changes:

Create JS code for encrypting files
Create JS code for decrypting files
Implement JS code into HTML file

Changes:

Created function to decrypt .txt files
Implemented JS code into HTML file

Next changes:

Create JS code for encrypting files
Implement JS code into HTML file

Closing issue as enhancement would require backend functionality


test-branch/execute-job/wrong-commit-sha-on-pr/e39708fe-1801-4059-937f-c94808caaffc

PR for testing 160d30e9340eca63da09159bfa85d953056b9c11

/canonical/self-hosted-runners/run-workflows 931ad21dd9ace68aaa0a7d341e94de96ad93fa6b


remove proxy dependency in cluster builder

Removes proxy dependency in cluster builder

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[X] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
0a56ba414f441835e070d10a330d97589c62da21
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-ipv6-k8s-tests_istio

integ-istiodremote-k8s-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-istiodremote-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-ipv6-k8s-tests_istio

integ-istiodremote-k8s-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-istiodremote-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-ipv6-k8s-tests_istio

integ-istiodremote-k8s-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-istiodremote-k8s-tests_istio

integ-distroless-k8s-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-distroless-k8s-tests_istio

integ-helm-tests_istio
3f82b0f6720aae016d242566e33ea5445f677fda
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

#34604 - Refer to the conversation in the PR. The short answer is having a dependency on proxy is too wide and it is difficult to confidently build cache key.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
1503ce6585308d23e7d5ff3ce9898661136510ca
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-k8s-tests_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
1503ce6585308d23e7d5ff3ce9898661136510ca
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-k8s-tests_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
1503ce6585308d23e7d5ff3ce9898661136510ca
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I donot think this is a good idea to change a lot of other not correlated funtions

Can you point me to which functions? I think I have changed relevant functions only which are needed to remove the proxy dependency.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
54e4e83aa9a01bb394ea3eea4f1e8d9083546d10
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster-tests_istio


feat: add new API endpoints

Pull Request Test Coverage Report for Build 85

7 of 11 (63.64%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.6%) to 97.119%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/securitytrails/clients/domain.rb
1
3
33.33%

lib/securitytrails/clients/ips.rb
2
4
50.0%

Totals

Change from base Build 82:
-1.6%

Covered Lines:
236

Relevant Lines:
243

💛  - Coveralls


feat: configurable title fields for content types

Ticket
None, reported by mail.
500 on GET Navigation (tree) and lack of possibility to setup titles for content types
Summary
What does this PR do/solve?
Fixes issue with 500 error on GET Navigation (tree) and provided additional configuration for content types and their title fields. Also solves couple intermediate issues recognized during development.
First tests has been introduced.
Test Plan
Run it and check.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@531d5ea). Click here to learn what that means.
The diff coverage is 84.61%.

@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   17.39%
=========================================
  Files             ?        5
  Lines             ?      230
  Branches          ?       77
=========================================
  Hits              ?       40
  Misses            ?      156
  Partials          ?       34

Flag
Coverage Δ

unittest
17.39% <84.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

services/navigation.js
15.17% <84.61%> (ø)

models/navigationItem.js
100.00% <0.00%> (ø)

admin/src/pluginId.js
100.00% <0.00%> (ø)

models/navigation.js
100.00% <0.00%> (ø)

services/constant.js
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 531d5ea...efcb46b. Read the comment docs.


Send an email to pycon staff when presentation is updated

Since a presentation can only be updated in the admin we intercept the admin save method to send the email.

Let's add a timestamp and the user who made the change to the message.

updated

While reviewing this, #502 occurred to me. We could get a start on it in this pull by adding a PYCON_STAFF_ADDRESS setting, pointing it to nobody or our dev email in the base settings, and setting it to the official address in the production settings.

I've merged #502 now.  You can merge the latest develop into this branch and make the appropriate tweaks to this new feature.  Let me know when it's ready to re-re-review :-)

Looking good, now all we need are tests.

One minor comment then :shipit:


[PLUGIN/PROVIDER REQUEST] strapi-provider-upload-yandex-cloud

Name
strapi-provider-upload-yandex-cloud
Link
https://github.com/teinett/strapi-provider-upload-yandex-cloud
Status
Unknown
Type
Provider
Author
@teinett

It's ready for Strapi v4 and is in use in production.


fix(video-editor-react): update hotkey popover

:tada: This PR is included in version 1.0.0-alpha.13 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.2.0-alpha.19 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.8 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.11 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.1.1-alpha.2 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:


CustomScrollView crashes when user flings then immediately drags

Steps to Reproduce

Run flutter create bug.
Replace the code in main.dart with the following code:

import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

void main() async {
  runApp(
    MaterialApp(
      home: Scaffold(
        body: CustomScrollView(
          slivers: <Widget>[
            SliverPersistentHeader(
              delegate: MyDelegate(),
            ),
            SliverList(
              delegate: SliverChildBuilderDelegate(
                (_, i) => Text('$i'),
              ),
            ),
          ],
        ),
      ),
    ),
  );
}

class MyDelegate implements SliverPersistentHeaderDelegate {
  double get minExtent => 0;
  double get maxExtent => 200;
  bool shouldRebuild(SliverPersistentHeaderDelegate other) => true;
  FloatingHeaderSnapConfiguration get snapConfiguration => null;
  OverScrollHeaderStretchConfiguration get stretchConfiguration => null;

  Widget build(
    BuildContext context,
    double shrinkOffset,
    bool overlapsContent,
  ) =>
      SnapListener(
        child: Center(
          child: Text('header'),
        ),
      );
}

class SnapListener extends StatefulWidget {
  final Widget child;

  SnapListener({this.child});

  @override
  _SnapListenerState createState() => _SnapListenerState();
}

class _SnapListenerState extends State<SnapListener> {
  ScrollPosition _position;

  @override
  Widget build(BuildContext context) => widget.child;

  @override
  void didChangeDependencies() {
    super.didChangeDependencies();
    _position = Scrollable.of(context)?.position;
    _position.isScrollingNotifier.addListener(_isScrollingListener);
  }

  void _isScrollingListener() {
    if (!_position.isScrollingNotifier.value) {
      if (0 < _position.extentBefore && _position.extentBefore < 200) {
        if (_position.userScrollDirection == ScrollDirection.reverse) {
          _position.jumpTo(200);
        } else if (_position.userScrollDirection == ScrollDirection.forward) {
          _position.jumpTo(0);
        }
      }
    }
  }
}

Fling the ScrollView up and then immediately drag it down. Can use testWidgets to do this automatically with the following test:

testWidgets("doesn't crash if user flings then drags", (WidgetTester tester) async {
  await tester.pumpWidget(/* place widget here */);
  await tester.flingFrom(Offset(400,300), Offset.fromDirection(-math.pi / 2, 100), 500);
  await t.pump(); // this is optional
  await t.dragFrom(Offset(400,300), Offset.fromDirection(math.pi / 2, 100));
});

This occurs in DartPad as well (although the error information is absent)

Expected results: No assertion is thrown
Actual results: An assertion is thrown and the app crashes
══╡ EXCEPTION CAUGHT BY GESTURE ╞═══════════════════════════════════════════════════════════════════
The following assertion was thrown while handling a gesture:
'package:flutter/src/widgets/scrollable.dart': Failed assertion: line 537 pos 12: '_hold == null':
is not true.
Either the assertion indicates an error in the framework itself, or we should provide substantially
more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
https://github.com/flutter/flutter/issues/new?template=BUG.md
When the exception was thrown, this was the stack:
#2      ScrollableState._handleDragStart (package:flutter/src/widgets/scrollable.dart:537:12)
#3      DragGestureRecognizer._checkStart. (package:flutter/src/gestures/monodrag.dart:384:52)
#4      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:182:24)
#5      DragGestureRecognizer._checkStart (package:flutter/src/gestures/monodrag.dart:384:7)
#6      DragGestureRecognizer.acceptGesture (package:flutter/src/gestures/monodrag.dart:308:7)
#7      GestureArenaManager._resolveByDefault (package:flutter/src/gestures/arena.dart:250:25)
#8      GestureArenaManager._tryToResolveArena. (package:flutter/src/gestures/arena.dart:231:31)
#17     AutomatedTestWidgetsFlutterBinding.runTest. (package:flutter_test/src/binding.dart:1099:17)
#18     AutomatedTestWidgetsFlutterBinding.runTest. (package:flutter_test/src/binding.dart:1087:35)
(elided 25 frames from class _AssertionError, class _FakeAsync, dart:async, and package:stack_trace)
Handler: "onStart"
Recognizer:
VerticalDragGestureRecognizer#8de00
════════════════════════════════════════════════════════════════════════════════════════════════════

Reproduces with current master 1.20.0-8.0.pre.102.
To hit the exception manually, not with test, the gesture should be very short and fast

flutter doctor -v
[✓] Flutter (Channel master, 1.20.0-8.0.pre.102, on Mac OS X 10.15.5 19F101, locale en-GB)
    • Flutter version 1.20.0-8.0.pre.102 at /Users/nevercode/dev/flutter
    • Framework revision f95f46e910 (4 hours ago), 2020-07-15 01:46:01 -0400
    • Engine revision be7595bafb
    • Dart version 2.9.0 (build 2.9.0-21.0.dev 20bf2fcf56)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (5 available)
    • Redmi Note 7 (mobile)      • 6345c469                             • android-arm64  • Android 9 (API 28)
    • iPhone 11 Pro Max (mobile) • 9F9AFD9B-7F22-468E-8096-B47E993E0619 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-13-5
      (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • Mac OS X 10.15.5 19F101
    • Web Server (web)           • web-server                           • web-javascript • Flutter Tools
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 83.0.4103.116

• No issues found!

I believe this is a duplicate of #14452. The root cause it that by triggering driven scrolling activities (i.e jumpTo, animateTo) based on scrolling notifiers, you can end up in a situation where one scrolling activity fires before another has completed.
I have seen some folks work around this by checking what kind of scroll activity it is in the notification handler in order to prevent activity clashing.
I'm going to close this as a dupe, if you feel this in't the same issue, let us know and we can re-open it! Thanks! :)


Dev

Add InfiniteArrays dependency so we can use \infty
Add NestedTuples dependency for schema
Add StrideArrays dependency for fast intermediate arrays (e.g. generate iid normals, then transform to get MvNormal)
Add CountingMeasure
Add Bernoulli measure
Add support for integer range domains, using notation ℤ[a:b]

Codecov Report

Merging #60 (e33a60c) into master (9d38378) will decrease coverage by 0.37%.
The diff coverage is 4.04%.

@@            Coverage Diff            @@
##           master     #60      +/-   ##
=========================================
- Coverage   10.00%   9.62%   -0.38%
=========================================
  Files          28      33       +5
  Lines         300     405     +105
=========================================
+ Hits           30      39       +9
- Misses        270     366      +96

Impacted Files
Coverage Δ

src/MeasureTheory.jl
50.00% <0.00%> (-50.00%)
:arrow_down:

src/absolutecontinuity.jl
0.00% <0.00%> (ø)

src/basemeasures.jl
0.00% <ø> (ø)

src/basemeasures/counting.jl
0.00% <0.00%> (ø)

src/basemeasures/lebesgue.jl
0.00% <0.00%> (ø)

src/combinators/for.jl
0.00% <0.00%> (ø)

src/combinators/power.jl
0.00% <0.00%> (ø)

src/combinators/product.jl
0.00% <0.00%> (ø)

src/density.jl
0.00% <0.00%> (ø)

src/parameterized.jl
0.00% <0.00%> (ø)

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29153ff...a304704. Read the comment docs.