[$250] Split bill / Group chat - When selecting the user search input should clear query and search input should be focused

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.66-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714064614847909
Action Performed:

Click Fab > Split Expenses
Enter amount and click next
Search for any user and select the user
Clear the search field and search for another user
Notice you don't see the users you've already selected
Select a user
Clear the search field and search for another user
Notice you don't see the users you've already selected
Select a user
Notice you only see the list of users in the group once there is no name in the search field

Expected Result:
Search term clears and search input is focussed - details here- https://github.com/Expensify/App/issues/41049#issuecomment-2088154813
Actual Result:
The search input doesn't clear, so even after you select someone, you have no context in terms of how many other people were selected or who else is available to be selected
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/51066321/b07f6d8b-d763-48b0-8fe1-0660a70b2ab9
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012a1b93a6a141243d
Upwork Job ID:<PHONE_NUMBER>031696896
Last Price Increase: 2024-04-26

Issue OwnerCurrent Issue Owner: @alitoshmatov

I can reproduce but I'm a little unsure what is expected here... asking in Slack. https://expensify.slack.com/archives/C049HHMV9SM/p1714112524451069?thread_ts=1714064614.847909&cid=C049HHMV9SM
I think this might be external

Proposal
Please re-state the problem that we are trying to solve in this issue.
The search input doesn't clear, so even after you select someone, you have no context in terms of how many other people were selected or who else is available to be selected
What is the root cause of that problem?
When we select an option, we don't have the logic to clear the search.
What changes do you think we should make in order to solve the problem?
If we apply this logic, we should apply it for all search page that can select multiple options like RoomInvitePage, NewChatPage, MoneyTemporaryForRefactorRequestParticipantsSelector, .... So in SelectionList we can add an extra prop like shouldClearInputOnSelect with default is false.
If it's true we will clear the text input when we select an option by adding this logic in selectRow function here
if (shouldShowTextInput && shouldClearInputOnSelect && canSelectMultiple) {
    onChangeText?.('');
}

https://github.com/Expensify/App/blob/951c7b38e0ec83a876c5e1d24af81e9e6543fc5d/src/components/SelectionList/BaseSelectionList.tsx#L245
And then we can add shouldClearInputOnSelect prop true into SelectionList in any page that we want to clear the search input after selecting an option.
What alternative solutions did you explore? (Optional)
If we want to always clear the search input when we can select multiple option, we can add the logic like this to selectRow function here. With this we don't need to add a new prop.
if (shouldShowTextInput && canSelectMultiple) {
    onChangeText?.('');
}

https://github.com/Expensify/App/blob/951c7b38e0ec83a876c5e1d24af81e9e6543fc5d/src/components/SelectionList/BaseSelectionList.tsx#L245

Proposal:
Problem: Missing information regarding the total number of users selected and/or which users are already selected.
Root Cause: Search input doesn't clear itself after user selection. No information about the total number of users selected.
Solution:

One thing required from a UI/UX perspective is to have a single line text in between the search input and the users list which would say something like "2 users selected". This would be a light and small font probably gray or something so that it is not that much in focus. This should be updated on every user selection/deselection.
A clear search field icon should be present on the right side of the input field. When clicked, it should clear the search and refresh the users list below.
On selection of the user, I do not think it is a good idea to clear the search field as there is a possibility that one might need to select two users with similar first names or last names or even have some common substring in the emails. In that case, if we clear the search on the first selection, user would have to enter the search input again to select the other user from the list.
The reason we don't see the already selected users is because the search input also filters the selected users. To avoid this, we can have the selected users to be always displayed at the top of the list and only filter the users which are not selected based on the search input.

The above measures should solve the all issues in terms of logic as well as positive feedback on the UI for the user to understand what is going on.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~010ec655f2a9846693

We should clarify expected behavior. I think clearing search query is not a right choice, In my opinion search query should stay and not be cleared when user is selected but we should just show all selected users

I think clearing search query is not a right choice, In my opinion search query should stay and not be cleared when user is selected but we should just show all selected users

I think after discussing it in Slack we came to a different conclusion. Most of the time when searching in these invite/add people flows, you are just searching for the next contact you want to select, not multiple. I think we should try it out with clearing the search input after you select someone and see how it feels from there.

Thanks @shawnborton! Just asked in our Slack thread (so not to clutter here if I'm wrong) of what this should look like, can you take a peek and confirm and I'll add the expected behaviour here.

Confirmed over there!

thank you! @alitoshmatov the expected behaviour is:

Click Fab > Split Expenses
Enter amount and click Next
Search for any user and select the user
Verify the search bar clears and the cursor remains in the search field
Verify the user you selected has a green checkmark and is anchored at the top of the search list

Here's a sloppy video of what we're looking for:
https://github.com/Expensify/App/assets/51066321/df6ca97b-e399-4b0e-9f13-d2158176f60b
Let me know if that helps!

@Krishna2323 Thank you for your proposal. But I think this feature is not only for split bill. It should be handled on all places where you select multiple users as stated in original slack post:

Go through a flow where you can select multiple users, for instance Splitting an expense, or inviting members to a workspace

@nkdengineer Thank you for your proposal. Your RCA is correct and your solution does work. I think we should implement this to everywhere where you can select multiple users.
We can go with @nkdengineer 's proposal
C+ reviewed 🎀 👀 🎀

Agree 👍 We should find and update all of them

To fix for all cases, we can create a useEffect to clear the text input when the selectedOptions length is changed. we already have prevSelectedOptionsLength in BaseSelectionList so we don't need to define a new prop.
useEffect(() => {
    if (prevSelectedOptionsLength === flattenedSections.selectedOptions.length || !texInputValue) {
        return;
    }

    onChangeText?.('');
}, [prevSelectedOptionsLength, flattenedSections.selectedOptions.length, onChangeText, texInputValue])

@shawnborton I have another question here:
Should we only clear the input if we only have one option to select when searching?
For example in this case, when I search and have many contacts here and select one of them. It will not make sense if we clear the input here because maybe we want to select some users of them. So I think it makes sense if we only clear the input when we only have one option to select.
https://github.com/Expensify/App/assets/161821005/8d905c17-f2d3-494e-9a9f-f7372be4a984

We want to clear it even if there are multiple search results. The case we are optimizing for is that you are selecting likely different individuals each time, not multiple people with a similar email address.

I made a similar clarifying comment above for reference.

Working through proposals

hi @MonilBhavsar @alitoshmatov do you have an update on this? TY!

I think listening to list items length is a workaround and might be confusing in the future. I think we should clearing input inside selectRow and implement separate solution for new page. What do you think
cc: @Krishna2323 @MonilBhavsar @nkdengineer

Agree, these both solutions seems like a workaround - https://github.com/Expensify/App/issues/41049#issuecomment-2091033092 and https://github.com/Expensify/App/issues/41049#issuecomment-2078487320
Listening to options length and adding a new prop and comparing options with it.
The workflow we want here is user typing user's login and then selecting. Once selected, we want to clear the input.
Why not add a event when user is selected and clear the input. I see those in the proposals. What are we missing in those proposals?

The workflow we want here is user typing user's login and then selecting. Once selected, we want to clear the input.
Why not add a event when user is selected and clear the input. I see those in the proposals. What are we missing in those proposals?

@MonilBhavsar As my alternative solution here https://github.com/Expensify/App/issues/41049#issuecomment-2078764528, We will clear the input in selectRow function which is called when a user is selected and that will work for all multiple selection list. But the problem is in NewChatPage, the Add to group button is rendered as rightHandComponent and it has a separate onPress event that doesn't call selectRow function.
Do you agree with my alternative solution and implement separate solution for new page as suggestion from @alitoshmatov here https://github.com/Expensify/App/issues/41049#issuecomment-2101217776?

@MonilBhavsar and @alitoshmatov can you check out this question? https://github.com/Expensify/App/issues/41049#issuecomment-2106953342
Are we looking for additional proposals?

@MonilBhavsar and @alitoshmatov can you check out this question? https://github.com/Expensify/App/issues/41049#issuecomment-2106953342
Are we looking for additional proposals?

@nkdengineer @alitoshmatov
I agree with this comment https://github.com/Expensify/App/issues/41049#issuecomment-2106890729
I am thinking of defining a callback function that clears the input when passed from the button/handler.
We define it once and call it from selectable item in selection list and from "Add to group button" and achieve the expected functionality. Can we do that? Are there only two places inside the App where we need to implement this?

could you please explain why you feel that passing the length of selected options and clearing the search input when the length changes seems like a workaround to you? I believe that passing selected options length isn't a workaround, we will clear the input whenever the prop changes.

We're triggering a function on an indirect change of events(change in options length) rather than a direct user action(clicking on option row or button). I think that makes code less easy to read and walkthrough.

@MonilBhavsar We can define a function like clearInputAfterSelect and share this via the ref.
const clearInputAfterSelect = useCallback(() => {
    onChangeText?.('');
}, [onChangeText])
useImperativeHandle(ref, () => ({scrollAndHighlightItem, clearInputAfterSelect}), [scrollAndHighlightItem, clearInputAfterSelect]);

https://github.com/Expensify/App/blob/951c7b38e0ec83a876c5e1d24af81e9e6543fc5d/src/components/SelectionList/BaseSelectionList.tsx#L486
And then we will call this function when we select a row here
if (canSelectMultiple && shouldShowTextInput) {
    clearInputAfterSelect();
}

https://github.com/Expensify/App/blob/951c7b38e0ec83a876c5e1d24af81e9e6543fc5d/src/components/SelectionList/BaseSelectionList.tsx#L245
For the case of NewChatPage, we will create a ref for selection list and call clearInputAfterSelect when we toggle Add to group button
const selectionListRef = useRef<SelectionListHandle>(null);
ref={selectionListRef}

https://github.com/Expensify/App/blob/951c7b38e0ec83a876c5e1d24af81e9e6543fc5d/src/pages/NewChatPage.tsx#L306
onPress={() => {
    selectionListRef.current?.clearInputAfterSelect?.();
    toggleOption(item);
}}

https://github.com/Expensify/App/blob/951c7b38e0ec83a876c5e1d24af81e9e6543fc5d/src/pages/NewChatPage.tsx#L235
What do you think about this? cc @alitoshmatov

Looks good! @alitoshmatov could you please take a close look if I am missing anything

Thanks for checking. Let's move forward!

@alitoshmatov The PR is here.

watching PR - https://github.com/Expensify/App/pull/42336

watching PR - https://github.com/Expensify/App/pull/42336

PR https://github.com/Expensify/App/pull/42336 is merged.
Testing the steps in the OP again, I think this is still an issue.
@nkdengineer and @alitoshmatov can you check again?

@Christinadobrzyn I checked on the latest main and the issue is fixed. Waiting the PR for deploying to staging. Correct me if I missed st.
cc @alitoshmatov.

Payouts due:

[ ] Contributor: $250 @nkdengineer (upwork offer - https://www.upwork.com/nx/wm/workroom/37320044/overview)
[ ] Contributor+: $250 @alitoshmatov (upwork offer - https://www.upwork.com/nx/wm/workroom/37289240/overview)

Upwork job is here.

@alitoshmatov do we need a regression test?

Just a heads up - I'm going to be ooo until June 24th so going to assign a teammate to pay this out and submit the regression test (if needed)

@alexpensify would you mind paying out based on this payment summary and submitting a regression test if we need one? TY!
cc @alitoshmatov

The PR that introduced the bug has been identified. Link to the PR: Feature request
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: No needed
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No needed
Determine if we should create a regression test for this bug.
Yes, using the same steps as PR listed since it suits well

Regression test steps
Note: There are two places to check this feature:

Go to FAB > Start chat

Enter a user to search

Click on Add to group button

Verify that the search input is cleared

Go to FAB > Split expense

Enter a valid amount and go to the next step

Search for a user

Select the user and verify that the search input is cleared

Everyone here https://github.com/Expensify/App/issues/41049#issuecomment-2162477972 has been paid via Upwork. I'll work on the test GH tomorrow.

Latest update ^

There were other higher-priority GHs; I'll get to the test soon.

Closing - I created the regression test request.


None of these instructions on this page currently works at all

There seems to be a few steps here to use a file from sharepoint with the QNA maker portal and none of the steps are working as I am continuting to get a an error saying the following:
Unsupported/Invalid URLs: "https://rccl.sharepoint.com/:x:/s/VCMessaging/EYiOZnTNJHZFtbSvTk91K_4Bqr59hl3aeua_1TXq9MIBVg?e=gKjLfr"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aba3bee4-2f22-8a1f-b392-83133ab6a622
Version Independent ID: 82b94b6d-5777-6ccb-eabe-1038f5e07ba2
Content: SharePoint files - QnA Maker - Azure Cognitive Services
Content Source: articles/cognitive-services/QnAMaker/How-To/add-sharepoint-datasources.md
Service: cognitive-services
Sub-service: qna-maker
GitHub Login: @diberry
Microsoft Alias: diberry

@xtianus79 we will review your feedback and get back to you shortly. Thanks.

@xtianus79 Hi! Can you please provide more info? What result did you get at each step? This is a fairly tricky connection between QnA Maker and share point so please provide as much information in chronological order as possible. #in-progress

Receiving the same error. By following the instructions straight through we are getting an invalid URL.
No issues with permissions granted and all actions taken being done via an admin account.

@RohitMungi-MSFT Can you help with this?

@Koxzi95 did you already enable QnA Maker to access your SharePoint resource?

Hey there,
We used the link to add the QnA Maker Enteprise App, provides this with admin consent and then auth’d using the QnA maker prompt also. Is there something further which needs to happen?

From: GiftA-MSFT<EMAIL_ADDRESS>Sent: Friday, February 7, 2020 4:59:44 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Tom Cox<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] None of these instructions on this page currently works at all (#47516)
@Koxzi95https://github.com/Koxzi95 did you already enable QnA Maker to access your SharePoint resource?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/47516?email_source=notifications&email_token=ABPTJJ2TJPSJJZG2QAD2NEDRBWHQBA5CNFSM4KQQITBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELDYD4Q#issuecomment-583500274, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABPTJJYRVFPCKNOL5IL4WGTRBWHQBANCNFSM4KQQITBA.

@Koxzi95 Seems like you have taken the necessary steps here. I will need to provide this feedback to the product team to determine if this is a bug and get back to you.

Thanks :). Let me know if I can be of any assistance.

@Koxzi95 just to confirm, are you using the url to a supported file type in your SharePoint documents as shown in the tutorial?

The file type being used was an .xlsx

@Koxzi95 It seems to be working for me now. Can you upload this sample document to your SharePoint document library and try using the file's url to create a new KB or import to existing KB? Please try to import your file and let me know if you have any more issues. Thanks

@Koxzi95 please let us know if you are still experiencing errors when importing your document otherwise we'll proceed to close this thread. Thanks.

Hi, Can some please give some clarify on "QnA Maker Portal SharePoint" Enterprise App,  are we giving this app permission to read all the SharePoint Content? from the documentation it appears so;
Is there an option we can grant the permission to app to read on selective resources/site collections etc.?


Added missing master timeout

Removes validation errors in https://github.com/elastic/elasticsearch-specification/pull/3251

the problem with pushing directly is that at some point during the night it reloads the changes and I lose the commits


next: document or improve handling of master disconnections

Right now the httpsched doesn't deal with disconnections from the master particularly well. Future attempts to re-subscribe on the same httpsched return errAlreadySubscribed. Currently my answer is to detect the error then mark the Context as Done and create a new httpsched. Is this the right approach?
https://github.com/mesos/mesos-go/blob/next/httpcli/httpsched/state.go#L123

That's probably the best way to handle it for now. Need to carefully consider how much additional intelligence should be built into the httpsched client vs. delegating to frameworks.

fixed by #286


Can't delete group "PBot Leaf Anatomy Working Group" due to blocking relationships

Trying to delete this but appears to be linked to something. We can't figure out what it is linked to because all of the old data it could have been linked to was deleted. Double checked the things just entered and no links there.

That Group still has five members. MEMBER_OF is a blocking relationship. This in itself is by design and not a bug. It can also be changed.
There is a bug, however. You can only remove four of the members via Group edit. The fifth, the person doing the editing, cannot be removed. Thus, the Group, or any Group really, can not be deleted.
Any fix for this will be too hairy to tackle until after Hackathon

Yes we tried removing all the members allowed and deleting it, but as you
said we can’t delete the creator so it failed. I don’t think it will cause
issues next week. Hopefully people will only create one or two truly needed
groups each.
On Wed, Aug 2, 2023 at 6:32 PM NoisyFlowers @.***>
wrote:

That Group still has five members. MEMBER_OF is a blocking relationship.
This in itself is by design and not a bug. It can also be changed.
There is a bug, however. You can only remove four of the members via Group
edit. The fifth, the person doing the editing, cannot be removed. Thus, the
Group, or any Group really, can not be deleted.
Any fix for this will be too hairy to tackle until after Hackathon
—
Reply to this email directly, view it on GitHub
https://github.com/paleobot/pbot-dev/issues/177#issuecomment-1663056399,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLULEC7CCU7GUU3WYFYESDXTLIOHANCNFSM6AAAAAA3BXR2JU
.
You are receiving this because you were assigned.Message ID:
@.***>

This was fixed in paleobot/pbot-api@6245cf053b26ef12ccbc69d4c13b83b6cdf40228, back in late August.
Please verify that you can delete that group and I'll close this


SetReadDeadline causes nil pointer dereference

Your environment.

Version: v4.0.0-beta.29
Browser: include version
Stacktrace

/vendor/github.com/pion/webrtc/v4/srtp_writer_future.go:108
/vendor/github.com/pion/webrtc/v4/rtpsender.go:435

What did you do?
Call rtpSender.SetReadDeadline(t)
What did you expect?
Don't panic
What happened?
Panic
This line causes the panic
https://github.com/pion/webrtc/blob/master/srtp_writer_future.go#L108
I dont familiar with the project source code, but shouldn't you must call Store before call Load ?

Hi @thanhpk
How can I reproduce this? We have some simple tests, but I wasn't able to make it happen again.


Document SimpleDiscoveryClient

This will show how to use SimpleDiscoveryClient (properties driven discovery client). in conjunction with spring cloud loadbalancer

See here for sample https://github.com/spring-cloud/spring-cloud-commons/blob/e1c570af07839951276ec6df2c0ac90588fcc151/spring-cloud-commons/src/test/java/org/springframework/cloud/client/discovery/composite/CompositeDiscoveryClientTests.java#L42-L45

Already done here.

tahks

thanks

Hi,
I am running into an the following issue:
I have a microservice serviceA and I use feign client to access it from other microservice.
During development, I want to rely on SimpleDiscoveryClient to get an instance of the service running in my docker daemon.
if I configure spring.cloud.discovery.client.simple.instances.serviceA[0].uri=http://localhost:8081 then SimpleDiscoveryClient recognizes the service and feign client works.
If I try to configure  SimpleDiscoveryClient using yaml as bellow it doesn't recognize the service:
spring:
    discovery:
      client:
        simple:
          instances:
            serviceA:
              - uri: "http://localhost:9595"

This doesnt make sense to me. Am I missing something?
I dont want to have a application.propertiesandapplication.yml` just for that.
Am I missing something?


add ensmm

Website:
ensmm-annaba.dz

@abbasmohanned I have to close this request without merging, because you requested to add a non-existent domain to this repository: `` Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Enhancement: Integrating gradio for RAG

Contact Details
<EMAIL_ADDRESS>What features would you like to see added?
I am a python developer and one of the major additions could be  adding an API integration for gradio API for RAG integration. This way an AI backend can be created separately and support adding documents to it and adding a multi layer LLM support.
More details
Not the best at node js but can definitely provide example APIs which are both gradio and fastapi.
Which components are impacted by your request?
Endpoints, Plugins
Pictures
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'm not that familiar with gradio but file/vectorization support is coming, using it or not. Any examples would  be helpful as I've been outweighing all of the options/methods available

Usually,  for production we create a large repo of documents and allow them to be vectorized offline and available for RAG. If it works, we can do a quick connect

I came to Libre via Reddit and Youtube looking for local LLM apps, but I specifically want RAG. I am hoping to find a good app that has RAG customisation (embedded model selection, chunking, etc) all configurable via the GUI.
Looking forward to a future release where LibreChat has RAG. For now, this is the biggest "missing" feature!
Keep up the great work.

@danny-avila @ewebgh33 @hamzafarooq any update on this. To connect custom RAG api connect.

A general RAG solution is now available for the project and will be improved over time. Use of gradio for RAG, which I'm not sure I understood the integration much to begin with, is not planned.


Test the MandVEnergyChangepointEstimator Class

In EnergyChangepointEstimator from cunybpl/changepointmodel, the fit method uses a CurvefitEstimator instance which has a model_func parameter set to self.model.f and a bounds parameter set to self.model.bounds. p0 is not set to any value, which means that within EnergyChangepointEstimator, initial guesses can not be set by the user. Therefore, to circumvent this, MandVEnergyChangepointEstimator uses the initial guesses set by the user which are embedded in the MandVParameterModelFunction instance.
The relevant tests for EnergyChangepointEstimator are found in the test_estimator.py file in cunybpl/changepointmodel. Therefore, we should reuse these tests but use MandVEnergyChangepointEstimator instead of EnergyChangepointEstimator and ensure that initial guesses are being applied.

Added test_estimator_integration_daily.py and test_estimator.py for MandVEnergyChangepointEstimator.
Refer to the following commit hash:
eb80db1674a7b451f2257480bbcfc17eb77db0e3

Adding test_savings_integration_daily.py to further test the MandVEnergyChangepointEstimator class. In cunybpl/changepointmodel, the savings calculations rely on EnergyChangepointEstimator instances, which is why test_savings_integration.py exists in that repo. Therefore, we should have the same unit test module but for the daily fixtures.


Define semantics for dataset IDs

User Story
As an API consumer, I need stable dataset IDs that I can easily cross reference with what's already in my system, so I add and update the right ones.
Acceptance Criteria
A proposed design for dataset IDs that

can scale to accommodate 100,000+ datasets

Considerations and Materials
Possible relevant information to include in a dataset ID

Feed ID
Upload date

Other dataset IDs approaches from

Transit.Land: hash
TransitFeeds: timestamp (e.g https://transitfeeds.com/p/128-business-council/763/20170829/download)
Transport Data Gouv: hash

Final Decision: Dataset ID has an automatic-increasing ID; dataset doesn't have a stable ID, but has a reference to the Feed ID


Refactor relations for use in computation of the perturbation and combiner polynomials

Closed by https://github.com/AztecProtocol/aztec-packages/pull/1897


drivers: sensor: bme680: add pm_device support

This patch introduces support for suspending and resuming the device using power management APIs.

Please implement runtime PM, CONFIG_PM_DEVICE is useless

done

Please address the failed checks


Add beagleplay support take 4 build branch

This PR is a mirror of https://github.com/balena-os/balena-beaglebone/pull/679 and is used for triggering Jenkins builds and autokit tests

Can one of the admins verify this patch?

@resin-jenkins test this please

@resin-jenkins ok to test

@resin-jenkins retest this please

closing this one as a new branch with fixes will be pushed by @delhiryder directly to this repository and a new PR will be opened


Remove unnecessary immediately invoked closures

For the tests, they where likely added before tests could return Result.
For the code, likely got easier to handle with thiserror crate

bors r+

@matthiasbeyer I think bors is not enabled for this repo now.

I requested it to be installed. :+1:

bors try

bors merge


logging ressource globalFilters into globalFiltersPre and globalFiltersPost

Is your feature request related to a problem? Please describe.
the CRD Logging has the globalFilters entries.
But some filters want to be run, after the ClusterFlow/Flow has run.
e.g.:

geoip if ip.field
adding records with environames
dedot but that filter could be better placed direct infront of a ClusterOutput/Output

For safe (that a Flow-Author could not overwrite fields)
Describe the solution you'd like
has globalFilterPost: []
Describe alternatives you've considered
ClusterOutput/Output has (also) globalFilters

that is sad, that this issue was closed without an comment.
ping @pepov

I beleive that should already be possible by using the relabel output

https://kube-logging.dev/docs/configuration/plugins/outputs/relabel/

@genofire can you check if relabel can used for this?


Cyclone objects crash PD while running on Raspberry Pi

Hi,
First of all, I'd like to say that Cyclone is amazing and it's really breathing some new (and much needed) life into the PureData community.
For the last few weeks I've been writing a sequencer for one of my midi controllers on 64bit Linux Manjaro and now I'm trying to get it up and running on a Raspberry Pi Zero W running Raspbian Stretch (March 2018 - Kernel Version 4.9)
I've installed the latest release of Cyclone ( cyclone03beta3_RaspberryPi), I see that it's up and running (due to the startup log message) but every object I've tried so far crashes PureData almost instantly.
Counter seems to be the exception, as it only crashes when it sometimes reaches the end of it's count.
Zexy works fine, there is ample free memory so the problem seems to be with this release of Cyclone.
What can I do to help debug this issue? Cheers.

It might end up just being user error, as the PD version that is available in the Raspbian repository is 0.47.1 and not the required 0.48.1
I will post back after I test it all out though this most likely was a non-issue.

Tested it out on 0.48.1 with the same results. Cyclone crashes PD every time.

Tried the one you highlighted and I get the "can't load library" message even with all of the paths set correctly (tried dumping it in the same place as a patch and still nothing) but it just hit me that the Raspberry Pi Zero W is armv6 and the release binaries are for armv7 so maybe that is the problem?
I tried compiling from source on my machine (thinking that it'd compile for armv6 in place of armv7) but I couldn't get it to compile properly.

Commands I ran:
git clone https://github.com/porres/pd-cyclone.git
cd pd-cyclone
git submodule update --init
make pdincludepath=~/pd-0.48-1/src//home/pi/Desktop/pd-0.48-1-armv6/src

Error output:
++++ info: making shared/magicbit.o in lib cyclone
cc -DPD -I "/root/pd-0.48-1/src//home/pi/Desktop/pd-0.48-1-armv6/src" -DUNIX  -fPIC -Ishared -DHAVE_STRUCT_TIMESPEC -Wall -Wextra -Wshadow -Winline -Wstrict-aliasing -O3 -ffast-math -funroll-loops -fomit-frame-pointer -march=armv6 -mfpu=vfp -mfloat-abi=hard -o shared/magicbit.o -c shared/magicbit.c
shared/magicbit.c:6:22: fatal error: g_canvas.h: No such file or directory
#include "g_canvas.h"
^
compilation terminated.
pd-lib-builder/Makefile.pdlibbuilder:899: recipe for target 'shared/magicbit.o' failed
make: *** [shared/magicbit.o] Error 1
Cheers.

My PD path was wrong. I had a "~" in front of the path that was adding a "/root/" at the beginning of the path.
make pdincludepath=/home/pi/Desktop/pd-0.48-1-armv6/src got it compiling instantly (weird that I didn't get an error about this upfront before)
It seems to be stable and working properly now, so mismatch between armv6 / armv7 was the problem.
Cheers.

great, I can close this issue then. But note that you have to do "make install -objectsdir=../" so it'll create a cyclone folder in the parent directory with all you need in it. Can you do that and send us the compressed file? We can then include it in deken and also in here for download

Sure. I'll re-compile and send them over tomorrow.


bug: ctrl+p ctrl+p goes to last file in the list, instead of most-recent file

Check the following:

[X] I have checked the behavior after setting "vscode-neovim.neovimClean" in VSCode settings.
[X] I have read the vscode-neovim docs.
[X] I have searched existing issues.

Neovim version (nvim -v)
0.9.5
Operating system/version
debian 12 (stable)
Describe the bug
Ctrl+p and then p again should go to the last edited file. Instead it goes the end of the list with no apparent logic.
Steps To Reproduce

edit multiple files
type Ctrl+p and then p again on the keyboard

Expected Behavior
It should go to the previously edited file.

Ctrl+p and then p again

Do you mean "p again" while holding ctrl ? This is because vscode-neovim defines ctrl+n / ctrl+p keybindings which act like Nvim, for the vscode quickfix menus.
Read https://github.com/vscode-neovim/vscode-neovim?tab=readme-ov-file#disable-keybindings

Thanks. I added this to ~/.config/Code/User/keybindings.json. And it works fine now.
 {
    "key": "ctrl+p",
    "command": "-workbench.action.quickOpenSelectPrevious",
    "when": "inQuickOpen && neovim.wildMenuVisible || inQuickOpen && neovim.mode != 'cmdline'"
  }


At what point are the ZIM files executed on a tty?

zimfw version: 1.1.1 (previous commit is 6129062)
ZIM_HOME:      /Users/jon.eguiluz/.zim
Zsh version:   5.7.1
System info:   Darwin Jons-MacBook-Pro.local 19.4.0 Darwin Kernel Version 19.4.0: Wed Mar 4 22:28:40 PST 2020; root:xnu-6153.101.6~15/RELEASE_X86_64 x86_64

Description
Probably not a bug, I just don't know the modules loading logic.
In order to use GPG in my shell, I need to export GPG_TTY=$(tty) I have try to put that line in  .zshenv and in .zshrc in both cases if I get
~ > echo $GPG_TTY
not a tty

At what point is the code executed in a tty? so I can make the export?
Steps to reproduce

put export GPG_TTY=$(tty) on  .zshenv
start a new shell
echo $GPG_TTY tells not a tty

After I while I discovered that was an issue with powerlevel10K, sorry to bother you.
If this can be useful to someone, I will leave it here.
Just replace export GPG_TTY=$(tty) by export GPG_TTY=$TTY
https://unix.stackexchange.com/a/608921

Hi @Viroide. Thanks for the heads up.
If you're using something like a "instant prompt", know that Zim is generally so fast that you don't even need something like that. It's even faster than zinit with "turbo" mode (which is similar, but maybe not exactly the same as p10k's "instant prompt"). See our latest benchmark runs.

This benchmark uses Zim's default installation modules. Of course the times will greatly vary depending on your configuration.

Since it seems relatively recent, I am curious wheter zi's turbo mode is similar to zinit's turbo?


Any sense of when envisalink_new will be “ready” to replace the existing integration?

Hello,
First, thank you for all of your hard work on this!
I recently installed an EL4 and the classic envisalink integration and am running into this same issue of alarm/disarm working fine from the Envisalink website but not working at all from Home Assistant.
It seems like the classic envisalink integration is just broken in this regard, but that envisalink_new fixes that particular problem.
That said, I'm wary to upgrade given that envisalink_new is still WIP.
Is there an expected timeframe during which development on envisalink_new will complete? That would help me make a more informed decision as to how to proceed here.
If it's still going to be a while, is there any chance that the bug in the traditional envisalink integration could be looked at?
Thank you!

I no longer consider this version to be a work in progress but I've just failed up update the main page to reflect that.  :smile:  While it's unlikely these version will make it back into HA core to replace the the existing one, I do believe it is in a solid state to be used.  There are a fair number of people who have switched over to it.
Regarding the issue in the core envisalink integration,  I don't think it is broadly broken as I just tried it against by own DSC panel and it worked fine.  It may be something specific to some setups that is causing trouble (e.g. maybe longer/shorter alarm code length, certain panel types, specific firmware versions, etc.).  If you turn on debug logging and capture the issue, I can have a look.  Please note though that the envisalink version will log your EVL password and alarm code with debugging logging turned on so please either redact those values from the logs before you post them or change your password and code to something temporary before testing.
I also recall some people having troubles with a new firmware version that EyezOn pushed to some devices.  That issue was causing different issues but I think it happened around the time some people started having troubles with the issue you mention so it's possible it could be related.
To turn on debug logging, add to your configuration.yaml:
logger:
  default: info
  logs:
    homeassistant.components.envisalink: debug
    pyenvisalink: debug

and then restart HA.

@ufodone Thanks a ton for responding. Last time I enabled debug logging, I didn't see anything that jumped out as remotely interesting but I will try again sometime this week when I have a chance.

it's unlikely these version will make it back into HA core to replace the the existing one

That's surprising/disappointing to hear. Would you mind elaborating on this? It seems suboptimal for the new/ostensibly “better” version to forever be a lesser-known fork.

Would you mind elaborating on this?

I starting these changes just planning to add config flow support and it sort of spiralled into much more significant changes.  By the time I was done, a lot had been upgraded and the scope of the changes were too large for HA to accept them back as a single PR.  In order to get the changes back, I would need to take it all apart and put it back together in small PRs with localized changes.  I just don't have the time to do that.

Makes total sense, thanks for clarifying.
I'm a bit new here but that suggests that, over time, envisalink and envisalink_new will likely continue to drift further apart, which puts new adopters like myself in an interesting position.
Hopefully I can get some helpful logs to you and we can figure out how to fix this particular issue in the core envisalink integration to at least give me a choice :)


Fix NPM warnings wherever possible

As part of testing for #193, I did a clean install of the npm packages for this project and got the following output:
npm WARN deprecated<EMAIL_ADDRESS>gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
npm WARN deprecated<EMAIL_ADDRESS>This package is no longer maintained
npm WARN deprecated<EMAIL_ADDRESS>gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported. Contact<EMAIL_ADDRESS>for more info.
npm WARN deprecated<EMAIL_ADDRESS>please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
npm WARN deprecated<EMAIL_ADDRESS>please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>This module relies on Node.js's internals and will break at some point. Do not use it, and update to<EMAIL_ADDRESS>npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN<EMAIL_ADDRESS>No license field.

added 469 packages in 21.973s

We should be able to ideally fix a number of these warnings (use something besides swig as it is no longer maintained, replace gulp-util?, add repository/license fields, etc.)

I've never really used node but I've got experience working with a number of things. So this seems like it could be something somewhat simple. However, I need a little assistance.
How would I do a clean install of the packages for the project to get the output? I can run npm install once to get the output but I can't seem to find out how to get the warning output again without removing the entire justdelete.me folder and redoing a clone.

Just remove your node_modules directory and re-run npm install. That's where all the packages are installed, so clearing them out forces npm to re-install them all.

Aha. Splendid.

I started working on this. Managed to code away from the dependency on gulp-swig by replacing it with gulp-nunjuck. However, it created two more warnings focusing on an optional dependency that only works for macOS. Largely it can probably be ignored.
Started working on another dependency and I found a few problems.
https://pastebin.com/raw/Qq9MP78f
That's a log file of doing a check on all of the dependencies. It seems that it's a rabbit hole of depreciations. The two biggest culprits being gulp, and gulp-swig.
I can do my pull request replacing gulp-swig but I'm not sure about how to proceed otherwise.

That's fine for now, I appreciate the help. Ultimately, we'll need to upgrade gulp to v^4.0.0, which I plan to work on after merging #193. (I'll do that this weekend assuming nobody reviews it by then) If you think your branch is worth PRing, I'd be happy to take a look at it. Even if not, it might be of use to reference when working on addressing the other warnings.


Document fails to metion that this doesn't work from sub-workflows dispatched via workflow_call

This webpage is missing a relevant and important detail:
The sample code works fine from a top-level workflow, but if it's called from a child workflow (via the uses clause) then it fails to login with no information on why.
Example:
CI/CD.yml
    uses: ./.github/workflows/Build.yml
    with:
      platform: ${{ matrix.platform }}
      configuration: ${{ matrix.configuration }}
      option: ${{ matrix.option }}

Build.yml
    - name: 'Az CLI login'
      uses: azure/login@v1
      with:
          client-id: ${{ secrets.AZURE_CLIENT_ID }}
          tenant-id: ${{ secrets.AZURE_TENANT_ID }}
          subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}

This pattern is fairly common as it makes it easier to maintain workflows, so having this silently break will cause developers to waste hours of time until they try it from the top-level workflow.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 081be8c9-7871-db69-977c-9304daa6c870
Version Independent ID: aa3e5074-a630-3756-be86-295d1a2d101f
Content: Connect GitHub and Azure
Content Source: articles/github/connect-from-azure.md
Service: azure
GitHub Login: @MoChilia
Microsoft Alias: shiyingchen

Hi @Alan-Jowett,
It's perplexing that azure/login will fail without any error, even if it is triggered from a child workflow. Could you please review the error information for the step where the azure/login is executed and share it with me? Additionally, I observed that you didn't seem to pass the secret from the caller workflow to the child workflow. In this scenario, azure/login may fail due to the absence of input credentials.

Hi @Alan-Jowett,
It's not a doc-bug; it appears to be caused by improper usage. This may not be suitable for tracking in the docs' repo. If you're still experiencing this issue, could you kindly create a new issue in https://github.com/Azure/login for better tracking?

Closing as this is not a documentation issue.
#please-close


Support ranged download

Would be great!
Example: http://www.coneural.org/florian/papers/04_byteserving.php

Nice idea, will try to work on that. Thanks!


nlink incorrect when dump with --skip-trash

What happened:

./juicefs format tikv://localhost:2379/test myjfs --trash-days $trash_days --enable-acl
./juicefs mount -d tikv://localhost:2379/test /jfs --enable-xattr
 SEED=$SEED LOG_LEVEL=WARNING MAX_EXAMPLE=30 STEP_COUNT=20 PROFILE=generate ROOT_DIR1=/jfs/fsrand
ROOT_DIR2=/tmp/fsrand python3 .github/scripts/hypo/fsrand2.py || true
./juicefs dump  tikv://localhost:2379/test dump.json --skip-trash
rm -rf test2.db
./juicefs load sqlite3://test2.db dump.json
./juicefs dump sqlite3://test2.db dump2.json --skip-trash

diff dump.json dump2.json
--- dump.json.bak	2024-04-01 15:03:43.232752299 +0800
+++ dump2.json.bak	2024-04-01 15:03:43.232752299 +0800
@@ -152,7 +152,7 @@
             }
           },
           "fnnw": {
-            "attr": {"inode":0,"type":"regular","mode":440,"uid":0,"gid":0,"atime":1711954992,"mtime":1711954992,"ctime":1711954997,"atimensec":743978721,"mtimensec":746723565,"ctimensec":474743498,"nlink":5,"length":4},
+            "attr": {"inode":0,"type":"regular","mode":440,"uid":0,"gid":0,"atime":1711954992,"mtime":1711954992,"ctime":1711954997,"atimensec":743978721,"mtimensec":746723565,"ctimensec":474743498,"nlink":3,"length":4},
             "posix_acl_access": {"owner":6,"group":0,"other":0,"mask":7,"users":[{"id":0,"perm":2},{"id":1005,"perm":7},{"id":1006,"perm":0},{"id":1007,"perm":7}],"groups":[{"id":0,"perm":6},{"id":1005,"perm":7},{"id":1006,"perm":0},{"id":1007,"perm":7},{"id":1009,"perm":2},{"id":1010,"perm":1},{"id":1011,"perm":1}]},
             "chunks": [{"index":0,"slices":[{"id":54,"size":4,"len":4}]}]
           },
@@ -216,7 +216,7 @@
             "chunks": [{"index":0,"slices":[{"id":48,"size":5,"len":5}]}]
           },
           "inla": {
-            "attr": {"inode":0,"type":"regular","mode":440,"uid":0,"gid":0,"atime":1711954993,"mtime":1711954993,"ctime":1711954997,"atimensec":490562418,"mtimensec":493838365,"ctimensec":499122371,"nlink":2,"length":8},
+            "attr": {"inode":0,"type":"regular","mode":440,"uid":0,"gid":0,"atime":1711954993,"mtime":1711954993,"ctime":1711954997,"atimensec":490562418,"mtimensec":493838365,"ctimensec":499122371,"nlink":1,"length":8},
             "posix_acl_access": {"owner":6,"group":0,"other":0,"mask":7,"users":[{"id":0,"perm":2},{"id":1005,"perm":7},{"id":1006,"perm":0},{"id":1007,"perm":7}],"groups":[{"id":0,"perm":6},{"id":1005,"perm":7},{"id":1006,"perm":0},{"id":1007,"perm":7},{"id":1009,"perm":2},{"id":1010,"perm":1},{"id":1011,"perm":1}]},
             "chunks": [{"index":0,"slices":[{"id":55,"size":8,"len":8}]}]
           },
@@ -385,7 +385,7 @@
             }
           },
           "pjad": {
-            "attr": {"inode":0,"type":"regular","mode":440,"uid":0,"gid":0,"atime":1711954992,"mtime":1711954992,"ctime":1711954997,"atimensec":743978721,"mtimensec":746723565,"ctimensec":474743498,"nlink":5,"length":4},
+            "attr": {"inode":0,"type":"regular","mode":440,"uid":0,"gid":0,"atime":1711954992,"mtime":1711954992,"ctime":1711954997,"atimensec":743978721,"mtimensec":746723565,"ctimensec":474743498,"nlink":3,"length":4},
             "posix_acl_access": {"owner":6,"group":0,"other":0,"mask":7,"users":[{"id":0,"perm":2},{"id":1005,"perm":7},{"id":1006,"perm":0},{"id":1007,"perm":7}],"groups":[{"id":0,"perm":6},{"id":1005,"perm":7},{"id":1006,"perm":0},{"id":1007,"perm":7},{"id":1009,"perm":2},{"id":1010,"perm":1},{"id":1011,"perm":1}]},
             "chunks": [{"index":0,"slices":[{"id":54,"size":4,"len":4}]}]
           },
@@ -749,7 +749,7 @@
             }
           },
           "ynyc": {
-            "attr": {"inode":0,"type":"regular","mode":440,"uid":0,"gid":0,"atime":1711954992,"mtime":1711954992,"ctime":1711954997,"atimensec":743978721,"mtimensec":746723565,"ctimensec":474743498,"nlink":5,"length":4},
+            "attr": {"inode":0,"type":"regular","mode":440,"uid":0,"gid":0,"atime":1711954992,"mtime":1711954992,"ctime":1711954997,"atimensec":743978721,"mtimensec":746723565,"ctimensec":474743498,"nlink":3,"length":4},
             "posix_acl_access": {"owner":6,"group":0,"other":0,"mask":7,"users":[{"id":0,"perm":2},{"id":1005,"perm":7},{"id":1006,"perm":0},{"id":1007,"perm":7}],"groups":[{"id":0,"perm":6},{"id":1005,"perm":7},{"id":1006,"perm":0},{"id":1007,"perm":7},{"id":1009,"perm":2},{"id":1010,"perm":1},{"id":1011,"perm":1}]},
             "chunks": [{"index":0,"slices":[{"id":54,"size":4,"len":4}]}]
           },

What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?
Environment:

JuiceFS version (use juicefs --version) or Hadoop Java SDK version:
Cloud provider or hardware configuration running JuiceFS:
OS (e.g cat /etc/os-release):
Kernel (e.g. uname -a):
Object storage (cloud provider and region, or self maintained):
Metadata engine info (version, cloud provider managed or self maintained):
Network connectivity (JuiceFS to metadata engine, JuiceFS to object storage):
Others:

A certain file has 4 hard links, of which 2 have been deleted and moved to the trash. At this time, its nlink is 5. When using dump --skip-trash, the nlink in the resulting JSON file is also 5. However, during loading, the nlink was recalculated and after loading it became 3.


pretty doesn't respect method String() string

type Int int

func (r Int) String() string {
    return fmt.Sprintf("Int(%d)", int(r))
}

type Box struct{ I Int }

func main() {
    i := Int(73)
    fmt.Printf("%+v\t%s\n", i, pretty.Sprint(i))

    b := Box{i}
    fmt.Printf("%+v\t%s\n", b, pretty.Sprint(b))
}

Expected result:
Int(73) Int(73)
{I:Int(73)} {I: Int(73)}

Actual result:
Int(73) 73
{I:Int(73)} {I: 73}

Can you try setting PrintStringers in the Config (change pretty.DefaultConfig if that's your whim)?  It's not supposed to call String() at all unless you explicitly ask it to.

Setting PrintStringers makes a difference indeed, but the result is a little unexpected:
Int(73)	"Int(73)"
{I:Int(73)}	{I: "Int(73)"}

The values are printed as if they were strings from the beginning, which can be misleading: the original value is neither 73 nor "Int(73)", but Int(73).
Nevertheless, even if the quotes are removed in the future, having to set an option explicitly to get the String() method to be invoked is unintuitive and unfortunate, because the point of using this pretty is getting a prettier and more readable representation than what you get by a mere fmt.Printf, which already takes advantage of the String() method if available. For example, I have a Rate type on top of int64 that represents the data rate in bps and that has a String() method that formats<PHONE_NUMBER>0 as "40 Gbps", and when a failed test prints out the diff using pretty.Compare, the output is very hard to read as the earlier value is not formatted as 40 Gbps but as<PHONE_NUMBER>0.

@musiphil I'd have to evaluate the change against the (at this point, fairly considerable) existing users (a distressing number of whom have hard-coded outputs that I'd have to update).  The reason PrintStringers is not on by default is that there are a significant number of types that have String representations for humans that don't include all of the state that a unit test cares about comparing (many structs) or which does include everything but not in a format that is amenable to diffing (e.g. protobuf), and this library was designed primarily around the pretty.Compare method for unit tests.  go-spew is a library that, I believe, was more designed around the "pretty printing for debugging," so take a look at them to see if it works better in your use case.  I have added a whitelist in 397d9a06b6442f58c63fa75896608473fe21bbb1 that you might be able to use if you want to get pretty-printing only for a few things, and it will also allow you to adjust the output to e.g. not include quotes.


Does it support SD-Inpaint model?

I changed the UNet2DConditionModel, ImageProjection and DiffusionPipeline functions in the pipeline_stable_diffusion_inpaint.py file. The code is fast but the output is terrible. What can I do to improve this?

Code:
outputv0 = pipe(
    prompt,
    image=image,
    mask_image=mask,
    num_inference_steps=35,
    guidance_scale=5.0,
    strength=1.0,
    num_images_per_prompt=1,
    cache_interval=5,
    cache_layer_id=0,
    cache_block_id=0,
    uniform=True,
    output_type='pil',
    return_dict=True
).images

Hi @kadirnar, please tune the cache_interval, cache_layer_id & cache_block_id. Caching in a deeper layer can improve the quality yet reduce the speedup.

Hi @kadirnar, please tune the cache_interval, cache_layer_id & cache_block_id. Caching in a deeper layer can improve the quality yet reduce the speedup.

Can you suggest sample values? I don't know what values I should give.

May we can use a smaller cache_interval like 3 or 4, and choose a deeper layer for caching by increasing the cache_block_id & cache_layer_id.


lazy gen in foreground and parallel gen in background

Let's say I want to have parallel gen in the background at say O3, and while that heavy jitting runs I would love to start running code let's say at O1 with the lazy gen. That way I can have the best of both lazy for faster startups but also parallel in the background for better code gen in the long run.
Is something like this possible with the current code? Or would I need to setup my own jit interface?

I guess it is possible.  The way I look at possible solution is to have two ctx and an additional thread for background compilation and then when background generation is done, move the generated module to main thread where lazy code generation is done.
Although I did not check will it work.
There is no big difference in code generation time when -O1, -O2, and -O3 are used.  Although the difference can be bigger if/when new optimizations will be added  to MIR-generator.
FYI work of more one generator in one context is currently buggy.  There are races in code working with context string (name) table when different generators create temporary registers (they have names) in parallel.  I don't know yet how to fix it the best way (w/o losing generation speed).


Incremental object search

This PR implements #106.  It also adds tests for both new and old-style object searches, and changes find_objects to use this new API internally.
As it is, find_next(0) returns Some(vec![]), which is I think the least surprising thing to do?  It shouldn't return None, since there may be more objects remaining.  I think it would also make sense if it panicked.  Let me know what you think.

On Thu, 2022-12-01 at 00:48 -0800, Wiktor Kwapisiewicz wrote:

LGTM. It kind of bothers me that None and Some(vec![]) are basically
the same state but using Option has the advantage of nice while let
Some(...) loops on the client side 🤔

I agree that it's not so nice.  I thought about it a bit more, and I
think we can just return a vector, and the user can use slice patterns
to get a nice-ish syntax in most cases:
while let ref chunk @ [_, ..] = search.find_next(SIZE)?[..] {
    // now chunk is a &[ObjectHandle], and is non-empty
}

However, if the user needs to take the vector and own it, they're left
with either:
loop {
    let chunk = search.find_next(SIZE)?;
    if
chunk.is_empty() { break; }
    // use chunk here...
}

or
let mut chunk = vec![];
while { chunk = search.find_next(SIZE)?; !chunk.is_empty() } {
    // use chunk here...
}

With all this in mind, I don't think the strangeness of Option<Vec<_>>
is really worth it.
As for find_objects(0), I think we can just return vec![], in order to
be consistent with how read works.

Updated to return just a vector, rather than an option of vector.

Thanks for the updates! I did take some time to add the iterator API on top of it: https://github.com/wiktor-k/rust-cryptoki/commit/1c00f377a10e45260375fcd811ab566209498d00
I'm still thinking about the API ease of use from the perspective of the API clients :thinking:
For the time being maybe let's wait until @ionut-arm voices his opinion (since he's the most senior here along with @hug-dev)? Sorry that this takes a little bit of time but it's the end of year and everyone is super busy...

On Tue, 2022-12-06 at 02:57 -0800, Ionuț Mihalcea wrote:

+// Search 10 elements at a time
+const MAX_OBJECT_COUNT: usize = 10;
Any reason for this choice? Just curious

That wasn't my addition.  Look at the old implementation for
find_objects.

On Tue, 2022-12-06 at 02:57 -0800, Ionuț Mihalcea wrote:

Hmmmmm... Would it be possible to add a method to FindObjects,
something like finalize, that just takes ownership of the value and
lets it drop? It seems suboptimal to have to drop the object manually
to achieve this, and an empty method isn't too bad.

Sure, then we can also get the benefit of a place to return errors from
C_FindObjectsFinal.  I'd call it final to be consistent with init.
Either way, I don't think manual dropping is that strange.  The docs
for MutexGuard from std have an example.  The same could also be
acheived by just adding some curly braces around the search.

Either way, I don't think manual dropping is that strange.  The docs
for MutexGuard from std have an example.  The same could also be
acheived by just adding some curly braces around the search.

Sure, we've had cases before where dropping something was the way to go, but since we know this is a potential use-case, it seems quite straight-forward to add something to do it "natively". But I get your point!
One question I wanted to raise is: how much time do you have/are you willing to put into resolving comments on these PRs? Because if you only want to get them in as is, we could review the changes here, raise issues for what's left (like this new method), and fix those afterwards in separate PRs. Asking only because I don't want to pressure you into putting in more effort.

On Thu, 2022-12-08 at 02:43 -0800, Ionuț Mihalcea wrote:

One question I wanted to raise is: how much time do you have/are you
willing to put into resolving comments on these PRs? Because if you
only want to get them in as is, we could review the changes here,
raise issues for what's left (like this new method), and fix those
afterwards in separate PRs. Asking only because I don't want to
pressure you into putting in more effort.

I'd like to resolve everything before we get them in.  I've had other
things on my plate the past few days, but I can definately get these
updated within a day or two.

#223 fixed the upstream issue, so this could probably be closed if you agree!

Closing, as this has already been implemented. Thanks for your time! 👋


ShapeFile plugin should parse .prj instead of assuming EPSG:4326

See https://github.com/ngageoint/opensphere/blob/master/src/plugin/file/shp/shpparser.js#L172

Even if we did (which is extraordinarily annoying on individual import; less so on zip import), we'd still only be able to parse the projections defined in the application, which are currently limited to EPSG:3857 and EPSG:4326 out of the box.
We could include the proj4 defs for other major ones, which would suffice for vector conversion. However, to properly support the projection in the application, we need extra information such as the projection's valid extent.

As a minimum, we should be warning the user that the projection can't be handled, rather than assuming EPSG:4326 and plotting it anyway.

I think for vector support you can just dump in all the proj4 defs.
for (var code in proj4defs) {
  proj4.defs(code, proj4defs[code]);
}

Those are all listed out in a couple of different libraries. I think the geopackage-js library may be the most exhaustive I've seen.
After that, you should be able to load a GeoJSON file defined in a projection other than EPSG:4326 or EPSG:3857. Once that is working properly, then do the .prj parsing for shapefile and have its parser make a similar call to transform the vectors.


Updated CONTRIBUTING

I'd prefer to keep it in its original form. I don't expect potential contributors to read the whole document. Many might only read one of the sections.

Hi @pchaigno , I considered the redundancy and the fact that a note draws attention to reading.
But I also agree with your point of view. Maybe just add it as note then?

I'm :-1: on this PR. It is best to keep the message in the appropriate section. As it's the first sentence in the section, I don't think it needs more in the way of highlighting either.


change repository owner

Codecov Report

Merging #217 (09389f0) into main (862b106) will increase coverage by 0.00%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   86.86%   86.87%
=======================================
  Files         102      102
  Lines       10713    10713
=======================================
+ Hits         9306     9307    +1
+ Misses       1084     1083    -1
  Partials      323      323

see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Improve the ghd argument usage

redundant definition under root/pykg2vec and root/examples.
should supports users to specify custom definitions of optimizing search space. like -ghd my_search_space.yaml.

PR #166 allows the user to pass in a single hyperparameter file and the files in the example folder are reduced.
python train.py -exp True -mn TransE -ds fb15k -hpf ./examples/hyperparams/custom.yaml
I can see another ongoing PR is targeting separating out the configuration on search space so please consider rebasing.

rebased finished. close issue.


"_notify" method problem

Hello. I'm sumin of the KHU IRLAB software developing team.
I sended this issue via email too.
I'm currently using araviscam module to make lvmcam actor. it will work with lvmagp actor to make guide and positioning image.
I confronted with some problems using araviscam module and basecam module.I have some questions about these errors.
1. my test expose command is
exptime instance "expflir" works fine before "await blc._expose_grabFrame(~~)" at that line an error occurs
I checked the API reference of  the Basecam module but there was no "_notify" function.
`@expose.command()
@click.argument("EXPT", type=float)#
async def exp(command: Command, expt: float):
try:
    print("before : ", blc)#BlackflyCamera
    await blc._connect_internal(self=blc)
    print("after : ",blc)

    print(blc.device)
    expflir=Exposure(blc)
    expflir.exptime=expt
    print(expflir)
    print(expflir.exptime)
    await blc._expose_grabFrame(self=blc, exposure=expflir)
    command.info("FLIR exposing...")
    print(expflir.data)

    await blc._disconnect_internal(self=blc)`

I'm using an internal function(_expose_grabFrame, _connect_internal) in the araviscam module instead of the base function(expose,connect) in the basecam currently. Although this difference with the basecam standard exists, I can't find the reason why the internal function _expose_grabFrame is currently not working.
After that, I downgraded the araviscam module version into 0.5.0 and tested again but the same error occurs. And I tested the "singleFrame" function again which i succeed to run before. This also presented the same "_notify" problem.
`from araviscam import BlackflyCam as blc
import asyncio
asyncio.run(blc.singleFrame(0.5,-1.0,False))`

i found the suspected reason of error. in Feb 22, Basecam has been changed "_notify" into "notify" (make notify as a public method) https://github.com/sdss/basecam/commit/928a856f114d19b9e2e649c5d85aa0e53887030b#diff-022bce101bbe4d2c127a874b94d510122e2f37aadc2b68c845655cf9fd8d69d1

I think new release of araviscam is needed to continue develop of lvmcam actor.
Please check these problem and reply to us.  Thank you!

That's probably the cause of the problem. Depending on whether the current version of araviscam uses features from basecam 0.5+, you can just downgrade the dependency on sdss-basecam to 0.4.2 for now.

Richard is working on it.


Custom partition

not sure whether here is the right place to post questions
Let's say the message in Kafka is in json format, I use timestamp to be first layer of partition (dt=yyyy-MM-dd), and I also want to add sub-partition based on one of the fields within json.
Does Secor support that? Thanks!

Hi Richardxin,
You can extend MessageParser class and override extractPartitions method
according to your use case.
-Lovenish
On Thu, Oct 26, 2017 at 9:39 PM, richardxin<EMAIL_ADDRESS>wrote:

not sure whether here is the right place to post questions
Let's say the message in Kafka is in json format, I use timestamp to be
first layer of partition (dt=yyyy-MM-dd), and I also want to add
sub-partition based on one of the fields within json.
Does Secor support that? Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pinterest/secor/issues/372, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHcVM8njOgZzKfRtDjI6OrPxcAJlG-Ixks5swK6lgaJpZM4QH1BJ
.

--
Regards,
Lovenish Goyal
M: +91<PHONE_NUMBER>* | Skype:  lovenishgoyal*


add grafana-server manage state

Add support to manage state of grafana services trhough BB.

@oxedions everything okay to sync this to the main ?

Dear @santos-lucas
Thanks a lot for this PR, and my apologies for being so late... 😊
Ok for me, merging !!
Ox


[ENHANCEMENT] Suggestion for multiple parameters

Please confirm these before moving forward

[X] I have searched for my feature proposal and not found a work-in-progress/duplicate/resolved/discarded issue.
[X] This improvements refers to an existing feature. If you want to suggest a new feature, please use this template
[X] This improvements is not a bug. If you want to report a bug, please use this template

Describe the improvement

Make this menu able to use multiple parameters.
Describe how this improvement could help users.
Sometimes, use multiple parameters is necessary, such as hash failure and installation error.
If I can use both ignore hash and have interactive installation, it will be helpful.

Hello,
You can achieve this from the installation options pane on the Package Details


Add initial infratographer urn lib

Initial library that allows for building and parsing URNs in a format that we expect to use within infratographer

just here to party


readme file

create professional readme for repo group 10

I’ve prepared the draft for the README.md file, which you can view under the add-me branch. However, the updates in the pull request are currently paused, so we are waiting for the process to continue.
Please review the draft and ensure any pending issues in the pull request are resolved for it to progress smoothly. 🚀


cmd/pkg: Add flag to make profiling duration configurable

Fixes #81
Signed-off-by: Jayapriya Pai<EMAIL_ADDRESS>

Thank you :) . I updated README

@slashpai This looks good to me, if you could address the format issues we can merge this.


Builder Docker image

Hey!
I guess simple Docker image will help new contributors. I have one. If you want we could merge it.

PR merged. Issue closed.
https://github.com/yandex/ClickHouse/pull/268


What's up with lightening

Reported that lightening does not occur.  Need to investigate.

To have lightening occur there are several things that need to happen:
It has to be raining. There is a timer for this.
It has to be thundering. There is a timer for this, too.
Rain strength has to be > 90.
So the rain and thunder intervals must overlap, and the rain strength has to be > 90. Storms at the upper end of the scale are more rare because the strength of a storm is based on a bell distribution, with 0 and 100 at either end.
With the current releases (and the unofficial port) you can influence this by setting the minimum rain strength in the dimension to 91. This will result in storms being on the strong end, but it will cause lightening when the thunder is active. I should also point out that this puts the rain at more the vanilla intensity (which is always 100).

Added a new setting for the dimension that allows a player to set the rain intensity level where thunder can occur.  By default it is set to 50 meaning that rain with an intensity > 50 can have thunder when the thunder time kicks in.

Was this added to any of the updated 1.7 versions?

Currently that change has not been backported.  It's on my list of things to look at.  The 1.10.2/1.11.2 versions are drastically different internally so it's not a matter of simply copying code over.

I should also add that this particular option was removed in the 1.10.2/1.11.2 versions as well.  Main reason is that the fundamental way of how Dynamic Surroundings interacts with Minecraft RE: rain/thunder changed so that it was not needed.  Lightning behavior should be normal.


nixos/restic-rest-server: prometheusNoAuth flag

Description of changes
Expose the --prometheus-no-auth flag to the module.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I think extraFlags is good enough.

I think extraFlags is good enough.

@dotlambda Is there a recommendation when to expose as a module option vs requiering the use of extraFlags?

I think extraFlags is good enough.

Wouldn't this be true for like every flag? Imho, this results in an ugly mixed configuration between "nixified" options and a list of extraFlags. I'd second @bachp's question when which should be used.

The proper solution would be following https://github.com/NixOS/rfcs/pull/42 but that seems a little hard in the case of command line flags.
We could have an option flags that replaces all existing options and translate e.g.
flags = {
  path = "/foo/bar";
  tls = true;
};

to --path "/foo/bar" --tls.


CLI: cannot read 'extraneous'

Cannot install latest
Replicate with a simple  npm install @graphql-hive/cli -g
npm ERR! Cannot read properties of undefined (reading 'extraneous')

https://github.com/npm/cli/issues/4290

It's super weird it happens during installation and only on NPM, works perfectly fine with Yarn.

Fixed in 0.19.8


Fix wrong variable-Name in Changelog

I signed it!

@Maikell84, thank you!

@Maikell84, sorry this PR take so long, now zone.js is moved to angular repo https://github.com/angular/angular/tree/master/packages/zone.js, could you re-create this PR there? Thank you.


cog not working on hardknott

Describe the issue
Wich branch is working with Yocto Hardknott release ?
I built fsl-imx-wayland for imx8mp and i have the folowing error in terminal from  Weston.
cog -P fdo https://www.google.com
(cog:1979): Cog-Core-WARNING **: 16:51:34.882: Platform module name 'fdo' is deprecated, please use 'wl' instead.
(cog:1979): Cog-Core-WARNING **: 16:51:34.884: cog_modules_get_preferred: cannot find module 'wl'
(cog:1979): Cog-Core-WARNING **: 16:51:34.884: cog_modules_get_preferred: preferred module 'wl' not supported
(cog:1979): Cog-WARNING **: 16:51:34.884: Cannot create platform: Could not find an usable platform module
wpe: could not load the impl library. Is there any backend installed?: libWPEBackend-default.so: cannot open shared object file: No such file or directory
Aborted

I suppose that cog was compiled with drm instead. it launch something when i run cog -P drm  from local console but can't read nothing as drm not supported for Vivante driver .
I already build and run cog with Yocto (Zeus) before but with meta-webkit from Dunfelll. Perhaps I need to change branch.
Can you help me with this
To Reproduce
Fikes to reproduce the behavior:
Local.conf
MACHINE ??= 'lec-imx8mp'
DISTRO ?= 'fsl-imx-wayland'
PACKAGE_CLASSES ?= 'package_rpm'
EXTRA_IMAGE_FEATURES ?= "debug-tweaks"
USER_CLASSES ?= "buildstats image-mklibs image-prelink"
PATCHRESOLVE = "noop"
BB_DISKMON_DIRS ??= "\
    STOPTASKS,${TMPDIR},1G,100K \
    STOPTASKS,${DL_DIR},1G,100K \
    STOPTASKS,${SSTATE_DIR},1G,100K \
    STOPTASKS,/tmp,100M,100K \
    ABORT,${TMPDIR},100M,1K \
    ABORT,${DL_DIR},100M,1K \
    ABORT,${SSTATE_DIR},100M,1K \
    ABORT,/tmp,10M,1K"
PACKAGECONFIG_append_pn-qemu-system-native = " sdl"
CONF_VERSION = "1"

DL_DIR ?= "${BSPDIR}/downloads/"
ACCEPT_FSL_EULA = "1"

# Switch to Debian packaging and include package-management in the image
PACKAGE_CLASSES = "package_deb"
EXTRA_IMAGE_FEATURES += "package-management"

CONNECTIVITY_CHECK_URIS = "https://www.google.com"

CORE_IMAGE_EXTRA_INSTALL += "packagegroup-adlink"

PACKAGECONFIG_append_pn-opencv_mx8 += " test"
TOOLCHAIN_TARGET_TASK_append += " onnxruntime-dev"

DISTRO_FEATURES_append = " sensors benchmarks adlink utils"
MACHINE_FEATURES_append = " wifi bluetooth"
IMAGE_FEATURES_append = " ssh-server-openssh"

OVERRIDES_append = ":wifibt"

INHERIT += "image-buildinfo"
IMAGE_BUILDINFO_VARS = "DISTRO DISTRO_VERSION MACHINE DEVICE_MODEL DEVICE_TYPE IMX_GPU_VERSION RELEASE_VERSION"

#BUILDTAG ??= "LEC-iMX8MP-1v2"
RELEASE_VERSION ?= "LEC-iMX8MP-${@'PREBUILD-%s' % (lambda dt: (dt.date.today().__str__()))(__import__('datetime')) if (d.getVar('BUILDTAG', True) is None) else '%s' % d.getVar('BUILDTAG')}"

KERNEL_MODULE_AUTOLOAD += "mlan moal"
PA_USER ?= "adlink-guest"
PA_TOKEN ?= ""

MACHINE_EXTRA_RDEPENDS += "kernel-module-lon"
BB_NUMBER_THREADS = "12"
INHERIT += "ccache"

bblayers.conf

LCONF_VERSION = "7"

BBPATH = "${TOPDIR}"
BSPDIR := "${@os.path.abspath(os.path.dirname(d.getVar('FILE', True)) + '/../..')}"

BBFILES ?= ""
BBLAYERS = " \
  ${BSPDIR}/sources/poky/meta \
  ${BSPDIR}/sources/poky/meta-poky \
  \
  ${BSPDIR}/sources/meta-openembedded/meta-oe \
  ${BSPDIR}/sources/meta-openembedded/meta-multimedia \
  ${BSPDIR}/sources/meta-openembedded/meta-python \
  \
  ${BSPDIR}/sources/meta-freescale \
  ${BSPDIR}/sources/meta-freescale-3rdparty \
  ${BSPDIR}/sources/meta-freescale-distro \
"

# i.MX Yocto Project Release layers
BBLAYERS += "${BSPDIR}/sources/meta-imx/meta-bsp"
BBLAYERS += "${BSPDIR}/sources/meta-imx/meta-sdk"
BBLAYERS += "${BSPDIR}/sources/meta-imx/meta-ml"
BBLAYERS += "${BSPDIR}/sources/meta-imx/meta-v2x"
BBLAYERS += "${BSPDIR}/sources/meta-nxp-demo-experience"

BBLAYERS += "${BSPDIR}/sources/meta-browser/meta-chromium"
BBLAYERS += "${BSPDIR}/sources/meta-clang"
BBLAYERS += "${BSPDIR}/sources/meta-openembedded/meta-gnome"
BBLAYERS += "${BSPDIR}/sources/meta-openembedded/meta-networking"
BBLAYERS += "${BSPDIR}/sources/meta-openembedded/meta-filesystems"
BBLAYERS += "${BSPDIR}/sources/meta-openembedded/meta-webserver"
BBLAYERS += "${BSPDIR}/sources/meta-qt5"
BBLAYERS += "${BSPDIR}/sources/meta-python2"

# ADLINK Yocto Project Release layers
BBLAYERS += "${BSPDIR}/sources/meta-adlink-nxp"
BBLAYERS += "${BSPDIR}/sources/meta-adlink-sema"
BBLAYERS += "${BSPDIR}/sources/meta-adlink-demo"

# Additional from open-embedded for meta-adlink-demo xfce recipes
BBLAYERS += "${BSPDIR}/sources/meta-openembedded/meta-xfce"
BBLAYERS += "${BSPDIR}/sources/meta-fnd"
BBLAYERS += "${BSPDIR}/sources/meta-webkit"

hash references of each repository of each used layer

BB_VERSION           = "1.50.0"
BUILD_SYS            = "x86_64-linux"
NATIVELSBSTRING      = "debian-10"
TARGET_SYS           = "aarch64-poky-linux"
MACHINE              = "lec-imx8mp"
DISTRO               = "fsl-imx-xwayland"
DISTRO_VERSION       = "5.10-hardknott"
TUNE_FEATURES        = "aarch64 armv8a crc cortexa53 crypto"
TARGET_FPU           = ""
meta
meta-poky            = "HEAD:58cbdaecf75b0248f96780b6882e8d4f232d038a"
meta-oe
meta-multimedia
meta-python          = "HEAD:c3a36263f91e42302ad7c347e051cf1cd83e39f6"
meta-freescale       = "HEAD:80dbe4bd63bd537fc9cfda2e009f8543464b4698"
meta-freescale-3rdparty = "HEAD:7f23af99cb97a12134a46b5b9d497f05b758bf0c"
meta-freescale-distro = "HEAD:916df6d24c0a33a3b1533bde70b6a2724ec77af4"
meta-bsp
meta-sdk
meta-ml
meta-v2x             = "HEAD:15fddd76b460fb56d9de121eb2d16a1e22cbe900"
meta-nxp-demo-experience = "HEAD:46107357abd2d2da9ffd702c87fce3984a422435"
meta-chromium        = "HEAD:cb3278e31340c7f081e8deb0683df2145da515c9"
meta-clang           = "HEAD:d797409435d3b0e9f2859992439989ff1d81e66d"
meta-gnome
meta-networking
meta-filesystems
meta-webserver       = "HEAD:c3a36263f91e42302ad7c347e051cf1cd83e39f6"
meta-qt5             = "HEAD:a00af3eae082b772469d9dd21b2371dd4d237684"
meta-python2         = "HEAD:810d6d842f103eb59f18b06426106462b15de7e2"
meta-adlink-nxp      = "HEAD:6b9083d42e5f1a26f3a75b4157b56d49c2ed6c94"
meta-adlink-sema     = "HEAD:19a9da10bc0846597fd1df1319807133f7267296"
meta-adlink-demo     = "HEAD:618ce30ebfc7756ba50277560a497ef292c5426d"
meta-xfce            = "HEAD:c3a36263f91e42302ad7c347e051cf1cd83e39f6"
meta-fnd             = "<unknown>:<unknown>"
meta-webkit          = "hardknott:93adadbd06fa802e480ae72f834cb27f5ed850dd"

local changes applied in the build environment

PREFERRED_PROVIDER_virtual/wpebackend = "wpebackend-fdo"
PREFERRED_RPROVIDER_virtual/wpebackend = "wpebackend-fdo"
PACKAGECONFIG_pn-wpebackend-fdo = "wayland"
PACKAGECONFIG_pn-cog = "fdo"
PACKAGECONFIG_append_pn-wpewebkit = " deviceorientation encryptedmedia fetchapi gamepad gst_gl indexeddb mediasource video webaudio webcrypto woff2 2dcanvas remote-inspector webrtc"
PACKAGECONFIG_append_pn-gstreamer1.0-plugins-ugly = " mpeg2dec x264"
PACKAGECONFIG_append_pn-gstreamer1.0-plugins-good = " cairo jpeg libpng libv4l2 soup v4l2"
PACKAGECONFIG_append_pn-gstreamer1.0-plugins-bad = " webrtc egl gles2 opengl openjpeg"
PACKAGECONFIG[webrtc] = "-DENABLE_WEB_RTC=ON -DENABLE_EXPERIMENTAL_FEATURES=ON,-DENABLE_WEB_RTC=OFF -DENABLE_EXPERIMENTAL_FEATURES=OFF,libvpx libevent libopus"

bitbake command causing the error

bitbake build works well

Error output

cog -P fdo https://www.google.com
(cog:1979): Cog-Core-WARNING **: 16:51:34.882: Platform module name 'fdo' is deprecated, please use 'wl' instead.
(cog:1979): Cog-Core-WARNING **: 16:51:34.884: cog_modules_get_preferred: cannot find module 'wl'
(cog:1979): Cog-Core-WARNING **: 16:51:34.884: cog_modules_get_preferred: preferred module 'wl' not supported
(cog:1979): Cog-WARNING **: 16:51:34.884: Cannot create platform: Could not find an usable platform module
wpe: could not load the impl library. Is there any backend installed?: libWPEBackend-default.so: cannot open shared object file: No such file or directory
Aborted

Expected behavior
expect to have cog browser on Weston compositor
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

yocto release: harknott
hardware targe: IMX8MP / Wayland

This can be related to the environment.
You should start cog from inside a weston shell, this is the safe-proof method.
But if you are trying to start it from ssh then you have to at least set first the environment variables WAYLAND_DISPLAY and XDG_RUNTIME_DIR to the right values.
Example:

Open a weston-terminal and get the pid of it

# pidof weston-terminal
14881

Examine the environment variables of that pid

# strings /proc/14881/environ
LANG=C
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
NOTIFY_SOCKET=/run/systemd/notify
HOME=/home/weston
LOGNAME=weston
USER=weston
SHELL=/bin/sh
INVOCATION_ID=b04467b8cdf149db8c44741a928227fe
TERM=linux
JOURNAL_STREAM=8:193511
SYSTEMD_EXEC_PID=14862
XDG_SESSION_ID=c7
XDG_RUNTIME_DIR=/run/user/1000
DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus
XDG_SESSION_TYPE=wayland
XDG_SESSION_CLASS=user
XDG_SESSION_DESKTOP=weston
XDG_SEAT=seat0
XDG_VTNR=7
WESTON_CONFIG_FILE=/etc/xdg/weston/weston.ini
WAYLAND_DISPLAY=wayland-1

Export the relevant ones on the ssh session

# export WAYLAND_DISPLAY=wayland-1
# export XDG_RUNTIME_DIR=/run/user/1000

Finally execute cog

# cog -P fdo https://google.it

(cog:15036): Cog-Core-WARNING **: 03:27:59.678: Platform module name 'fdo' is deprecated, please use 'wl' instead.

(cog:15036): GLib-GIO-WARNING **: 03:27:59.836: Your application does not implement g_application_activate() and has no handlers connected to the 'activate' signal.  It should do one of these.
Cog-Core-Message: 03:28:00.750: <https://google.it/> Load started.
Cog-Core-Message: 03:28:00.833: <https://www.google.it/> Redirected.
Cog-Core-Message: 03:28:01.233: <https://www.google.it/> Loading...
Cog-Core-Message: 03:28:02.548: <https://www.google.it/> Loaded successfully.

It works to me now, but it was giving the error you get before exporting the environment variables

Hi @clopez
root@lec-imx8mp:~# pidof weston-terminal
1183

root@lec-imx8mp:~# strings /proc/1183/environ
LANG=C
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
NOTIFY_SOCKET=/run/systemd/notify
WATCHDOG_PID=1177
WATCHDOG_USEC=40000000
HOME=/root
LOGNAME=root
USER=root
SHELL=/bin/sh
INVOCATION_ID=0403115648c140a2be019f16238336c5
TERM=linux
JOURNAL_STREAM=8:11664
XDG_SESSION_ID=c3
XDG_RUNTIME_DIR=/run/user/0
DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/0/bus
XDG_SESSION_TYPE=wayland
XDG_SESSION_CLASS=user
XDG_SESSION_DESKTOP=weston
XDG_SEAT=seat0
XDG_VTNR=7
WESTON_CONFIG_FILE=/etc/xdg/weston/weston.ini
XWAYLAND_NO_GLAMOR=1
WAYLAND_DISPLAY=wayland-0

The 2 variables are already set but i defined thenm again.
cog -P fdo http://google.it  still gives me the prevoius error:
(cog:1275): Cog-Core-WARNING **: 16:05:25.302: Platform module name 'fdo' is deprecated, please use 'wl' instead.

(cog:1275): Cog-Core-WARNING **: 16:05:25.304: cog_modules_get_preferred: cannot find module 'wl'

(cog:1275): Cog-Core-WARNING **: 16:05:25.304: cog_modules_get_preferred: preferred module 'wl' not supported

(cog:1275): Cog-WARNING **: 16:05:25.304: Cannot create platform: Could not find an usable platform module
wpe: could not load the impl library. Is there any backend installed?: libWPEBackend-default.so: cannot open shared object file: No such file or directory

Can you try exporting this environment variable :
export G_MESSAGES_DEBUG=all

... and run cog again (inside the weston environment) ?
It will print lot of debug messages, paste them here.

Hi
I have only this with G_MESSAGES_DEBUG=all set .
(cog:1207): Cog-Core-DEBUG: 09:39:02.269: ensure_extension_points: Extension points registered.
(cog:1207): Cog-Core-DEBUG: 09:39:02.276: cog_modules_add_directory: Scanning '/usr/lib/cog/modules'
Cog-INFO: 09:39:02.285: com.igalia.Cog.Platform:
Cog-INFO: 09:39:02.285:   drm - 200/CogDrmPlatform
(cog:1207): Cog-DEBUG: 09:39:02.314: platform_setup: Platform name: fdo

(cog:1207): Cog-Core-WARNING **: 09:39:02.314: Platform module name 'fdo' is deprecated, please use 'wl' instead.

(cog:1207): Cog-Core-WARNING **: 09:39:02.314: cog_modules_get_preferred: cannot find module 'wl'

(cog:1207): Cog-Core-WARNING **: 09:39:02.314: cog_modules_get_preferred: preferred module 'wl' not supported

(cog:1207): Cog-WARNING **: 09:39:02.314: Cannot create platform: Could not find an usable platform module
(cog:1207): Cog-DEBUG: 09:39:02.314: Instantiating default WPE backend as fall-back.
wpe: could not load the impl library. Is there any backend installed?: libWPEBackend-default.so: cannot open shared object file: No such file or directory
(process:1213): GLib-GIO-DEBUG: 09:39:02.425: Failed to initialize portal (GNetworkMonitorPortal) for gio-network-monitor: Not using portals
(process:1213): GLib-GIO-DEBUG: 09:39:02.442: Failed to initialize networkmanager (GNetworkMonitorNM) for gio-network-monitor: NetworkManager not running
(process:1213): GLib-GIO-DEBUG: 09:39:02.443: _g_io_module_get_default: Found default implementation netlink (GNetworkMonitorNetlink) for ?gio-network-monitor?

I added waylandeglinfo , it gives :
EGL_VERSION = 1.5
EGL_VENDOR = Vivante Corporation
EGL_EXTENSIONS = EGL_KHR_fence_sync EGL_KHR_reusable_sync EGL_KHR_wait_sync EGL_KHR_image EGL_KHR_image_base EGL_KHR_image_pixmap EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_EXT_image_dma_buf_import EGL_EXT_image_dma_buf_import_modifiers EGL_KHR_lock_surface EGL_KHR_create_context EGL_KHR_no_config_context EGL_KHR_surfaceless_context EGL_KHR_get_all_proc_addresses EGL_EXT_create_context_robustness EGL_EXT_protected_surface EGL_EXT_protected_content EGL_EXT_buffer_age EGL_ANDROID_native_fence_sync EGL_WL_bind_wayland_display EGL_WL_create_wayland_buffer_from_image EGL_KHR_partial_update EGL_EXT_swap_buffers_with_damage EGL_KHR_swap_buffers_with_damage EGL_EXT_pixel_format_float
EGL_CLIENT_APIS = OpenGL_ES OpenVG
GL_VERSION: OpenGL ES 1.1
GL_RENDERER:
GL_EXTENSIONS:

What do you have inside the directory /usr/lib/cog/modules ?
Do you have a file named libcogplatform-wl.so ?

Yes i do
root@lec-imx8mp:/usr/lib/cog/modules# ls
libcogplatform-drm.so
root@lec-imx8mp:/usr/lib/cog/modules#

Ok.. there is the problem.
You are missing libcogplatform-wl.so in that directory
Can you try to rebuild after setting this in your local.conf:
PACKAGECONFIG_pn-cog = "wl"

(so use wl instead of fdo)
Questions:

Do you have a libcogplatform-wl.so after that in /usr/lib/cog/modules ?
Does that make any difference? Does cog now work?

Ok , I rebuilt only cog and installed the deb package and it works now .
Thanks a lot.

Great! :+1:
Happy to know that it works! :tada:


Adding global rotation parameter to the ScaleStartDetails class

Hello! I would like to add a parameter to the ScaleStartDetails class to hold info about which axis the scale is happening on. I'm building a calendar widget and I want to be able to tell if the user is scaling vertically or horizontally, so I can either make the hours longer or the days wider.
The current rotation parameter starts at 0 and then tracks rotation from that baseline. My globalRotation parameter will just report what angle the pointers are scaling on, between 0 and 180 (0 if vertical scroll, 90 if horizontal, 180 if vertical in the "other direction").
Does this make sense? Would this PR be accepted?

Also, while testing this I found that the onScaleStart and onScaleUpdate callbacks are triggered even if just one finger is placed or dragged. Is this the intended behavior? It seems you would only want scale callbacks to be triggered if two fingers are placed, since you can't scale with one. If I'm right, I'll also address this in my PR.

Closed with https://github.com/flutter/flutter/pull/27752


Bug detecting datatype in VALUES tuples

Describe the bug
When executing an INSERT INTO table VALUES (value1), (value2); statement, the auto type detection on the plan created for the values tuples breaks valid inputs due to how the data type detection works.
I'm pretty sure the bug is here:
https://github.com/apache/datafusion/blob/b2ac83ff821b8434cfcc9b3391d7039120c7b259/datafusion/expr/src/logical_plan/builder.rs#L187-L219
This logic coerces all value tuples to cast to the type of the value in the first row. In the case of an insert into a UInt64 column, this can end up needlessly attempting to cast a valid UInt64 to a Int64 before being casted back to a UInt64 during plan execution.
To Reproduce
Can be verified easily via cli:
> CREATE TABLE test(a BIGINT UNSIGNED);
0 row(s) fetched.
Elapsed 0.026 seconds.

> INSERT INTO test(a) VALUES<PHONE_NUMBER>458185744),<PHONE_NUMBER>9315690233);
Arrow error: Cast error: Can't cast value<PHONE_NUMBER>9315690233 to type Int64

Expected behavior
I would have expected two rows to be inserted rather than receiving an error.
Additional context
No response

I think the issue is because i64 and u64 are not coericible

This logic coerces all value tuples to cast to the type of the value in the first row.

it would be better to coerce all values to their common super type (order insensitive, nor biased to the first row)

In the case of an insert into a UInt64 column, this can end up needlessly attempting to cast a valid UInt64 to a Int64 before being casted back to a UInt64 during plan execution.

That's a good point. In INSERT's case one could want each value to independently get coerced to the target type.
However, this would be INSERT-specific special behavior which could lead to hard-to-understand inconsistencies later.
INSERT INTO <table> VALUES ... is just a case of INSERT INTO <table <select-query>.
INSERT INTO <table> VALUES ... should behave exactly same as INSERT INTO <table> SELECT * FROM (VALUES ...) or INSERT INTO <table> SELECT * FROM (VALUES ...) WHERE true. In those more elaborate cases it's obvious that VALUES need to coerce to their common type.

I agree with @findepi  that a more general solution to this problem is to extend the VALUES coercion to pick the widest super type that works for all values in a column
While using the available types for insert does seem a reasonable idea, I think following the pattern of other coercions would be better


fix(signal_processing): unit test bug

Signed-off-by: Takayuki Murooka<EMAIL_ADDRESS>Description
Fix https://github.com/autowarefoundation/autoware.universe/issues/1959

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Thank you for your fixing.
Could I test CI before merging this PR?

@kenji-miyake Of course. I'm not in a hurry.

LGTM, tested locally on arm

@ambroise-arm Could you review https://github.com/autowarefoundation/autoware-github-actions/pull/185 before merging this PR, please? :pray:

@kenji-miyake I tested locally with RelWithDebInfo, the issue did not occur.

@takayuki5168 Since this PR won't fix any feature, I've changed the title from fix to test.

@kenji-miyake
In my understanding, this PR resolved the issue that unit test failed on Arm. But should we set test instead of fix?
https://github.com/autowarefoundation/autoware.universe/issues/1959

@takayuki5168 Uh, sorry. I overlooked the first file. :pleading_face:


Fix sf3.4 command autoregistration deprecation

Fixes:

Auto-registration of the command "Lexik\Bundle\JWTAuthenticationBundle\Command\CheckConfigCommand" is deprecated since Symfony 3.4 and won't be supported in 4.0. Use PSR-4 based service discovery instead

Thank you @ogizanagi.


Dockerize the application for future push to hub.docker.com

Create a Dockerfile to be able to share your images to the Docker Hub
Create a docker-compose.yml for run the containers in local machines.
Add the Portainer to manage the containers.
Add Nginx for simple load-balancing and easy scalability.

Hey @hpbonfim, thank you for creating this pull request! Have a wonderful day...

@Niweera I'll be grad to help coding this awesome project. Happy Hacktoberfest!


How do I use Trello API with Qbot, plus is it Possible?

If you code it yourself it's technically possible..
However it's not supported, so no.

Alright, I don't know how to code it, but do you know how I can learn how to use Discord API and Trello API?

Do you already have a good knowledge of JavaScript?

No, I just learned how to make Qbot by a Friend.

A good knowledge of JS is required first.

Okay, I can learn..

It's possible alright, we have the tools available

Okay, thanks.

Why is this Happening?
;deny-join  - Denies a user's join request.;membercount Shows all of the Current Members`;getinfo  Get's the Users ID, and username

 +`${process.env.prefix}deny-join ` - Denies a user's join request.`
    + `\`${process.env.prefix}membercount Shows all of the Current Members`

    + `\`${process.env.prefix}getinfo <username> Get's the Users ID, and username.`,

    author: {
        name: message.author.tag,
        icon_url: message.author.displayAvatarURL()
    }
}});

}`

@IeuanGol

Use \n for new lines,

What's wrong with this line?
[+ \${process.env.prefix}membercount Shows all of the Current Members.
    + `\`${process.env.prefix}getinfo <username> Get's the Users ID, and username.`,
    ](

Use \n for new lines,

I did, it says this: ;deny-join  - Denies a user's join request. /n

Also, why does my bot not respond to this?
equire('dotenv').config(); exports.run = async (client, message, args) => {     return message.channel.send({embed: {         color: 7948427,         description: Here are my commands:\n        +`${process.env.prefix}help` - Shows this list of commands.\n        +`${process.env.prefix}setrank  <rank name/number>` - Ranks the user in the Roblox group to the specified rank number or name.\n        +`${process.env.prefix}promote ` - Moves the user 1 rank up in the Roblox group.\n        +`${process.env.prefix}demote ` - Moves the user 1 rank down in the Roblox group.\n        +`${process.env.prefix}fire ` - Moves a user to the lowest rank possible besides Guest.\n        +`${process.env.prefix}shout ` - Posts a group shout.\n        +`${process.env.prefix}clearshout` - Clears the group shout.\n        +`${process.env.prefix}currentshout` - Shows the current group shout.\n        +`${process.env.prefix}accept-join ` - Accepts a user's join request.\n`

\${process.env.prefix}membercount Shows all of the Current members, it's the same as Serverinfo.\n      +`${process.env.prefix}getinfo Get's the Users ID, and username.\n`
\${process.env.prefix}deny-join ` - Denies a user's join request.,       author: {           name: message.author.tag,           icon_url: message.author.displayAvatarURL()       }   }});

equire('dotenv').config();
exports.run = async (client, message, args) => {
return message.channel.send({embed: {
color: 7948427,
description: **Here are my commands:**\n
+ \${process.env.prefix}help` - Shows this list of commands.\n        +`${process.env.prefix}setrank  <rank name/number>` - Ranks the user in the Roblox group to the specified rank number or name.\n        +`${process.env.prefix}promote ` - Moves the user 1 rank up in the Roblox group.\n        +`${process.env.prefix}demote ` - Moves the user 1 rank down in the Roblox group.\n        +`${process.env.prefix}fire ` - Moves a user to the lowest rank possible besides Guest.\n        +`${process.env.prefix}shout ` - Posts a group shout.\n        +`${process.env.prefix}clearshout` - Clears the group shout.\n        +`${process.env.prefix}currentshout` - Shows the current group shout.\n        +`${process.env.prefix}accept-join ` - Accepts a user's join request.\n`

\${process.env.prefix}membercount Shows all of the Current members, it's the same as Serverinfo.\n      +`${process.env.prefix}getinfo Get's the Users ID, and username.\n`
\${process.env.prefix}deny-join ` - Denies a user's join request.`,
author: {
name: message.author.tag,
icon_url: message.author.displayAvatarURL()
}
}});

@IeuanGol

@TypicallyShad Can you help?

Hello?

What's the issue?

Please could you close this issue if you've solved it now.


Reduce payload logging to potentially improve response times

I suspect that logging the response payloads, especially in large requests like a fully-slotted mission adds quite a delay to responses. It should thus be tried to remove the extra output that does not add much information anyways to try and speed up response times.

Tasks

[x] Remove payload logging

responsePayload and requestPayload has been removed from the logs. This should hopefully reduce the delay caused by logging and thus speed up responses.


Notepad (1.50.1)

hey
for the visuals would be cool if we have the option for no background (transparent) / white / black ..
also while removing a note and i hold the button to long i got these... minor thing... but yeah wanted to show it ^^

Yeah sure, I can add some form of customization in the near future.

Ah, I see what you did. You dragged a tab out and immediately removed it before letting go of the left mouse-button. That's an oversight I can easily fix. Thanks for reporting.


v1.10 docs UI issue

This is a...

[x] Bug Report

Problem:

Proposed Solution:
Removing linear-gradient from body > #wrapper in CSS
Page to Update:
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.10/

1.10

Happy to put in a PR if the old docs page is still updated

@JakeRowsell89 If you are interested in fixing this, please consider a PR to the https://github.com/pwittrock/brodocs/blob/master/stylesheet.css file, and then push a docker image to docker hub. The doc generator tool (kubernetes-incubator/reference-docs) will use the latest version of the docker image for doc generation.

Okay to close now. Problem fixed.
/close