Error causing an indexing pipeline crash

Cluster is running on k8s with a 1 metastore, 1 janitor, 1 indexer and 1 searcher.
I'm particularly worried about this log quickwit-indexer-0 quickwit thread 'non-blocking-0' panicked at 'Cannot start a runtime from within a runtime.
On the index, I have these logs:
quickwit-indexer-0 quickwit 2022-11-03T18:21:03.007Z ERROR quickwit_actors::spawn_builder: actor-failure cause=Failed to receive command from uploader.
quickwit-indexer-0 quickwit
quickwit-indexer-0 quickwit Caused by:
quickwit-indexer-0 quickwit     channel closed exit_status=Failure(Failed to receive command from uploader.
quickwit-indexer-0 quickwit
quickwit-indexer-0 quickwit Caused by:
quickwit-indexer-0 quickwit     channel closed)
quickwit-indexer-0 quickwit 2022-11-03T18:21:03.007Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=quickwit_indexing::actors::sequencer::Sequencer<quickwit_indexing::actors::publisher::Publisher>-blue-LT9X exit_status=Failure(cause=Failed to receive command from uploader.
quickwit-indexer-0 quickwit
quickwit-indexer-0 quickwit Caused by:
quickwit-indexer-0 quickwit     channel closed)
quickwit-indexer-0 quickwit 2022-11-03T18:21:03.007Z ERROR quickwit_actors::actor: actor-failure actor_name="quickwit_indexing::actors::sequencer::Sequencer<quickwit_indexing::actors::publisher::Publisher>-blue-LT9X" actor_exit_status=Failure(Failed to receive command from uploader.
quickwit-indexer-0 quickwit
quickwit-indexer-0 quickwit Caused by:
quickwit-indexer-0 quickwit     channel closed)
quickwit-indexer-0 quickwit 2022-11-03T18:21:03.007Z ERROR quickwit_actors::actor: exit activating-kill-switch actor=quickwit_indexing::actors::sequencer::Sequencer<quickwit_indexing::actors::publisher::Publisher>-blue-LT9X exit_status=Failure(Failed to receive command from uploader.
quickwit-indexer-0 quickwit
quickwit-indexer-0 quickwit Caused by:
quickwit-indexer-0 quickwit     channel closed)
quickwit-indexer-0 quickwit 2022-11-03T18:21:03.007Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=Publisher-frosty-99K3 exit_status=Killed
quickwit-indexer-0 quickwit 2022-11-03T18:21:03.007Z ERROR quickwit_actors::actor: actor-failure actor_name="Publisher-frosty-99K3" actor_exit_status=Killed
quickwit-indexer-0 quickwit 2022-11-03T18:21:03.102Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=Indexer-throbbing-Hk4a exit_status=Killed
quickwit-indexer-0 quickwit 2022-11-03T18:21:03.102Z ERROR quickwit_actors::actor: actor-failure actor_name="Indexer-throbbing-Hk4a" actor_exit_status=Killed
quickwit-indexer-0 quickwit 2022-11-03T18:21:03.102Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=quickwit_indexing::actors::doc_processor::DocProcessor-falling-9ci3 exit_status=Killed
quickwit-indexer-0 quickwit 2022-11-03T18:21:03.102Z ERROR quickwit_actors::actor: actor-failure actor_name="quickwit_indexing::actors::doc_processor::DocProcessor-falling-9ci3" actor_exit_status=Killed
quickwit-indexer-0 quickwit 2022-11-03T18:21:03.102Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=SourceActor-little-SHF6 exit_status=Downstream actor exited.
quickwit-indexer-0 quickwit 2022-11-03T18:21:03.102Z ERROR quickwit_actors::actor: actor-failure actor_name="SourceActor-little-SHF6" actor_exit_status=DownstreamClosed
quickwit-indexer-0 quickwit 2022-11-03T18:21:03.102Z ERROR quickwit_actors::actor: exit activating-kill-switch actor=SourceActor-little-SHF6 exit_status=DownstreamClosed
quickwit-indexer-0 quickwit thread 'non-blocking-0' panicked at 'Cannot start a runtime from within a runtime.  Can you give earlier logs? The error suggests your uploader had a problem.

By pipeline crash, you mean the indexing did not resume  after this, correct?

@guilload let's just use flume for that channel.

yes the indexing pipeline is not resumed, the only log you can see after is coming from the ingest API garbage collector.
It's not the same logs as above but same issue triggered this time by an Azure storage misconfiguration (I copy/paste some logs directly from logz and wasn't able to download the real logs).

Nov 3, 2022 @ 20:08:32.881 | 2022-11-03T19:08:32.881Z  INFO quickwit_indexing::actors::ingest_api_garbage_collector: ingest-api-garbage-collect-operation
-- | --

  | Nov 3, 2022 @ 20:02:08.038 | 2022-11-03T19:02:08.037Z ERROR quickwit_indexing::actors::indexing_service: Indexing pipeline failed. index_id=quickwit-fts-staging source_id=kafka-source pipeline_ord=0

  | Nov 3, 2022 @ 20:02:08.038 | 2022-11-03T19:02:08.037Z ERROR quickwit_actors::actor_handle: actor-timeout actor="IndexingPipeline-empty-RG5g"

  | Nov 3, 2022 @ 20:02:04.089 | 2022-11-03T19:02:04.088Z ERROR quickwit_actors::actor: actor-failure actor_name="Publisher-blue-JbqQ" actor_exit_status=Killed

  | Nov 3, 2022 @ 20:02:04.089 | channel closed)

  | Nov 3, 2022 @ 20:02:04.089 | Caused by:

  | Nov 3, 2022 @ 20:02:04.089 | (empty)

  | Nov 3, 2022 @ 20:02:04.089 | 2022-11-03T19:02:04.088Z ERROR quickwit_actors::actor: actor-failure actor_name="quickwit_indexing::actors::sequencer::Sequencer<quickwit_indexing::actors::publisher::Publisher>-spring-WefF" actor_exit_status=Failure(Failed to receive command from uploader.

  | Nov 3, 2022 @ 20:02:04.089 | 2022-11-03T19:02:04.088Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=Publisher-blue-JbqQ exit_status=Killed

  | Nov 3, 2022 @ 20:02:04.089 | (empty)

  | Nov 3, 2022 @ 20:02:04.089 | 2022-11-03T19:02:04.088Z ERROR quickwit_actors::actor: exit activating-kill-switch actor=quickwit_indexing::actors::sequencer::Sequencer<quickwit_indexing::actors::publisher::Publisher>-spring-WefF exit_status=Failure(Failed to receive command from uploader.

  | Nov 3, 2022 @ 20:02:04.089 | channel closed)

  | Nov 3, 2022 @ 20:02:04.089 | Caused by:

  | Nov 3, 2022 @ 20:02:04.088 | Caused by:

  | Nov 3, 2022 @ 20:02:04.088 | (empty)

  | Nov 3, 2022 @ 20:02:04.088 | 2022-11-03T19:02:04.088Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=quickwit_indexing::actors::sequencer::Sequencer<quickwit_indexing::actors::publisher::Publisher>-spring-WefF exit_status=Failure(cause=Failed to receive command from uploader.

  | Nov 3, 2022 @ 20:02:04.088 | (empty)

  | Nov 3, 2022 @ 20:02:04.088 | Caused by:

  | Nov 3, 2022 @ 20:02:04.088 | (empty)

  | Nov 3, 2022 @ 20:02:04.088 | channel closed)

  | Nov 3, 2022 @ 20:02:04.088 | channel closed)

  | Nov 3, 2022 @ 20:02:04.088 | Caused by:

  | Nov 3, 2022 @ 20:02:04.088 | channel closed exit_status=Failure(Failed to receive command from uploader.

  | Nov 3, 2022 @ 20:02:04.088 | 2022-11-03T19:02:04.088Z ERROR quickwit_actors::spawn_builder: actor-failure cause=Failed to receive command from uploader.

  | Nov 3, 2022 @ 20:02:04.066 | 2022-11-03T19:02:04.066Z ERROR quickwit_actors::actor: actor-failure actor_name="IndexUploader-floral-tIcY" actor_exit_status=Killed

  | Nov 3, 2022 @ 20:02:04.066 | 2022-11-03T19:02:04.066Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=IndexUploader-floral-tIcY exit_status=Killed

  | Nov 3, 2022 @ 20:02:04.066 | 2022-11-03T19:02:04.066Z ERROR quickwit_actors::actor: actor-failure actor_name="Packager-divine-6iRj" actor_exit_status=Killed

  | Nov 3, 2022 @ 20:02:04.066 | 2022-11-03T19:02:04.065Z ERROR quickwit_actors::actor: actor-failure actor_name="quickwit_indexing::actors::index_serializer::IndexSerializer-holy-lF84" actor_exit_status=Killed

  | Nov 3, 2022 @ 20:02:04.066 | 2022-11-03T19:02:04.065Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=quickwit_indexing::actors::index_serializer::IndexSerializer-holy-lF84 exit_status=Killed

  | Nov 3, 2022 @ 20:02:04.066 | 2022-11-03T19:02:04.066Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=Packager-divine-6iRj exit_status=Killed

  | Nov 3, 2022 @ 20:02:04.021 | note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  | Nov 3, 2022 @ 20:02:04.021 | thread 'non-blocking-0' panicked at 'Cannot start a runtime from within a runtime. This happens because a function (like `block_on`) attempted to block the current thread while the thread is being used to drive asynchronous tasks.', quickwit-indexing/src/source/kafka_source.rs:153:22

  | Nov 3, 2022 @ 20:02:04.012 | 2022-11-03T19:02:04.012Z ERROR quickwit_actors::actor: actor-failure actor_name="quickwit_indexing::actors::doc_processor::DocProcessor-bold-rN0W" actor_exit_status=Killed

  | Nov 3, 2022 @ 20:02:04.012 | 2022-11-03T19:02:04.012Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=quickwit_indexing::actors::doc_processor::DocProcessor-bold-rN0W exit_status=Killed

  | Nov 3, 2022 @ 20:02:04.011 | 2022-11-03T19:02:04.011Z ERROR quickwit_actors::actor: actor-failure actor_name="SourceActor-fragrant-ZEPr" actor_exit_status=Killed

  | Nov 3, 2022 @ 20:02:04.011 | 2022-11-03T19:02:04.011Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=SourceActor-fragrant-ZEPr exit_status=Killed

  | Nov 3, 2022 @ 20:02:04.011 | 2022-11-03T19:02:04.011Z ERROR quickwit_actors::actor: actor-failure actor_name="Indexer-floral-bsRk" actor_exit_status=Killed

  | Nov 3, 2022 @ 20:02:04.011 | 2022-11-03T19:02:04.011Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id=Indexer-floral-bsRk exit_status=Killed

  | Nov 3, 2022 @ 20:02:04.002 | 1: AzureErrorWrapper(inner=server returned error status which will not be retried: 400) split_id="01GGZDWAXM6JY1WHMYP1SDJK9Y"

  | Nov 3, 2022 @ 20:02:04.002 | Caused by:

  | Nov 3, 2022 @ 20:02:04.002 | (empty)

  | Nov 3, 2022 @ 20:02:04.002 | 2022-11-03T19:02:04.002Z  WARN index_batch{index_id=quickwit-fts-staging source_id=kafka-source pipeline_ord=0}:uploader: quickwit_indexing::actors::uploader: Failed to upload split. Killing! cause=Failed uploading key 01GGZDWAXM6JY1WHMYP1SDJK9Y.split in bucket azure://quickwit-eastus-staging@quickwit-account/quickwit/quickwit-fts-staging

  | Nov 3, 2022 @ 20:02:04.002 | 0: StorageError(kind=Service, source=AzureErrorWrapper(inner=server returned error status which will not be retried: 400))

@guilload Can we use a Mailbox, Inbox for that channel maybe?
Then we can use the unbounded high priority channel for rebalances.

Answering myself: This may not be a panacea.
I actually don't answer why unti test / rebalancing works usually but here it didn't.
I first assumed that it was some logic that made it so that the local runtime was only started when try_send failed, but apparently not. Adrien, do you know something about this function is called outside of tokio usually but in some corner case, can be called from an async function?

@fmassot Ah ok. So the uploader bug is nothing to worry about. It is just a misconfiguration. Understood.

subscribe is called in the constructor, that's the issue:
 * @remark subscribe() is an asynchronous method which returns immediately:
 *         background threads will (re)join the group, wait for group rebalance,
 *         issue any registered rebalance_cb, assign() the assigned partitions,
 *         and then start fetching messages. This cycle may take up to
 *         \c session.timeout.ms * 2 or more to complete.

I'm going to move the subscribing logic in the blocking consumer poll loop.

Closed via #2248.


[Great idea] fail-2fa-execution

Hey! I really like your plugin, works great!
Could be possible, you could add fail-commands?
For example if a player execute the 2fa 10 times wrong,  it would ban?  (Once the player already has the 2fa enabled)

Hey msmanui!
That's possible to do with the API.
I might do that myself if I have some free time in the next few days, but there's a pretty good explanation on how to do that (here)[https://github.com/LielAmar/2FA/wiki/Using-the-API#spigot-examples]

Can be done with the API.
Closed.


Add dr460nf1r3's Dashy

Category:

Documentation

Overview

Adding my Dashy homepage to the showcase section

Thanks for the work you do on Dashy, its awesome as well! :)

Hi dr460nf1r3,
Could you maybe share the config of your dashboard? Looks very neat!


Build script improvements

The build script may well be worth a full refactoring at some point, but for now this deals with issues discovered by @galbramc (and incorporates his fixes and suggestions).
Confirmed on my linux computer, will test on my windows computer.
Please test on Macs!

@whoburg Could you merge this asap. All other testing on reynolds will fail until this is merged.

Testing now on my mac

Install script appeared to run successfully, but there's a mosek_bin_dir issue:
======================================================================
ERROR: test_simpleflight (t_geometric_program.t_GP_mosek_cli)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/whoburg/MIT/dev/gpkit/gpkit/tests/t_geometric_program.py", line 76, in test_simpleflight
    self.simpleflight_test_core(sf.gp())
  File "/Users/whoburg/MIT/dev/gpkit/gpkit/tests/t_geometric_program.py", line 43, in simpleflight_test_core
    sol = gp.solve(printing=False)
  File "gpkit/geometric_program.py", line 330, in solve
    return self._solve(*args, **kwargs)
  File "gpkit/geometric_program.py", line 353, in _solve
    solverfn = cli_expopt.imize_fn(filename)
  File "gpkit/_mosek/cli_expopt.py", line 18, in imize_fn
    os.environ['PATH'] = os.environ['PATH']+':%s' % settings["mosek_bin_dir"][0]
KeyError: 'mosek_bin_dir'

======================================================================
ERROR: test_trivial_gp (t_geometric_program.t_GP_mosek_cli)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/whoburg/MIT/dev/gpkit/gpkit/tests/t_geometric_program.py", line 21, in test_trivial_gp
    sol = prob.solve(printing=False)["variables"]
  File "gpkit/geometric_program.py", line 330, in solve
    return self._solve(*args, **kwargs)
  File "gpkit/geometric_program.py", line 353, in _solve
    solverfn = cli_expopt.imize_fn(filename)
  File "gpkit/_mosek/cli_expopt.py", line 18, in imize_fn
    os.environ['PATH'] = os.environ['PATH']+':%s' % settings["mosek_bin_dir"][0]
KeyError: 'mosek_bin_dir'

======================================================================
ERROR: test_trivial_vector_gp (t_geometric_program.t_GP_mosek_cli)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/whoburg/MIT/dev/gpkit/gpkit/tests/t_geometric_program.py", line 34, in test_trivial_vector_gp
    sol = prob.solve(printing=False)['variables']
  File "gpkit/geometric_program.py", line 330, in solve
    return self._solve(*args, **kwargs)
  File "gpkit/geometric_program.py", line 353, in _solve
    solverfn = cli_expopt.imize_fn(filename)
  File "gpkit/_mosek/cli_expopt.py", line 18, in imize_fn
    os.environ['PATH'] = os.environ['PATH']+':%s' % settings["mosek_bin_dir"][0]
KeyError: 'mosek_bin_dir'

======================================================================
ERROR: test_zeroing (t_geometric_program.t_GP_mosek_cli)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/whoburg/MIT/dev/gpkit/gpkit/tests/t_geometric_program.py", line 105, in test_zeroing
    sol = GP(1/L, [L-5*k <= 10]).solve(printing=False, solver=self.solver)
  File "gpkit/geometric_program.py", line 330, in solve
    return self._solve(*args, **kwargs)
  File "gpkit/geometric_program.py", line 353, in _solve
    solverfn = cli_expopt.imize_fn(filename)
  File "gpkit/_mosek/cli_expopt.py", line 18, in imize_fn
    os.environ['PATH'] = os.environ['PATH']+':%s' % settings["mosek_bin_dir"][0]
KeyError: 'mosek_bin_dir'

======================================================================
ERROR: test_trivial_sp (t_geometric_program.t_SP_mosek_cli)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/whoburg/MIT/dev/gpkit/gpkit/tests/t_geometric_program.py", line 129, in test_trivial_sp
    sol = sp.localsolve(printing=False, solver=self.solver)
  File "gpkit/signomial_program.py", line 149, in localsolve
    sol = self._solve(printing=printing, *args, **kwargs)
  File "gpkit/geometric_program.py", line 353, in _solve
    solverfn = cli_expopt.imize_fn(filename)
  File "gpkit/_mosek/cli_expopt.py", line 18, in imize_fn
    os.environ['PATH'] = os.environ['PATH']+':%s' % settings["mosek_bin_dir"][0]
KeyError: 'mosek_bin_dir'

----------------------------------------------------------------------
Ran 59 tests in 0.918s

FAILED (errors=5)

wait, this might be my fault for forgetting to install ctypesgen. standby.

You should be able to use mosek_cli without ctypesgen. Pushing a small fix.

Ok, on my mac I confirmed that small update makes the tests run (via mosek_cli) even without ctypesgen installed, and that with ctypesgen installed, the gpkit build works and all tests pass.

You didn't get the Jenkins issues? Check if there's a line in your bashrc
that's adding to the DYLD library path; with that commented out do the
tests still work?

Hmm, there are many such lines in my bashrc. After deleting the extra ones and commenting the last, the tests indeed fail.
Was I too quick on the draw with merging?

Well, merging fixed the linux issues.

New PR: https://github.com/convexopt/gpkit/pull/199


Add reverseY to options in Readme

Hi Olivier and thank you for your PR. Unfortunately I have trouble logging in to GitHub due to 2FA and a stolen phone. It will take a bit longer to merge it into master. Sry.
Best
Stephan

You can view, comment on, or merge this pull request online at:
https://github.com/StephanGeorg/staticmaps/pull/28 https://github.com/StephanGeorg/staticmaps/pull/28
Commit Summary
Add reverseY to options in Readme
File Changes
M README.md https://github.com/StephanGeorg/staticmaps/pull/28/files#diff-0 (1)
Patch Links:
https://github.com/StephanGeorg/staticmaps/pull/28.patch https://github.com/StephanGeorg/staticmaps/pull/28.patch
https://github.com/StephanGeorg/staticmaps/pull/28.diff https://github.com/StephanGeorg/staticmaps/pull/28.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/StephanGeorg/staticmaps/pull/28?email_source=notifications&email_token=AB37LHENXVG7KDPOV2SFTQLQCFE7JA5CNFSM4IIEFKB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HCQBYZA, or mute the thread https://github.com/notifications/unsubscribe-auth/AB37LHDTNBALWUBCGA6LJN3QCFE7JANCNFSM4IIEFKBQ.


Tangent are not exported

I'm trying to export a model and the tangent are not exported even if I check the "Tangents" check box under the mesh tab.
The tangent exports works if I export a simple sphere for example. So maybe I'm doing something wrong?
I've included a example as attachment. The "bunny" is the one that do not export correctly and sphere is the one that works.
dev.zip

Ok after some digging I found the warning message "WARNING: Could not calculate tangents. Please try to triangulate the mesh first." hidden in the console.
Rather than silently outputing an error, shoudn't the export just fails if it cannot match the requested export parameters?

I can reproduce this in Blender latest master (2.82), glTF 2.0 addon version 1.1.11.

This might be a feature request but related to this bug, it would be nice if there was an option to triangulate the mesh when exporting.

I'm still having this issue with Blender 2.83.0 and "Import-Export as glTF 2.0" version 1.2.75.
In my case, there isn't a warning about mesh triangulation even though I'm exporting a mesh consisting mostly of quads. This behavior is likely more correct than emitting a warning given what @donmccurdy wrote in #145.

Meshes are triangulated automatically when they're exported, because the glTF format disallows n-gons.

Since there doesn't seem to be much activity on this issue, I've decided to try various combinations of actions in Blender to see which ones make the exporter happy and which ones don't.
Exporting tangents works on:

@gabdube's sphere (which is a UV Sphere)
The default cube in a "General" project
A newly created Plane
A newly created Cube
A newly created UV Sphere
A newly created Icosphere
A newly created Torus
Any of the above after being deformed by any Sculpt Mode brush.

Exporting tangents doesn't work:

On @gabdube's "bunny"
On a newly created Cylinder (remesh is also broken)
On a newly created Cone (remesh is also broken)
On anything after a remesh (I've tried remeshing all of the things which worked and some of the things which didn't work)
With a new "Sculpting" project

It seems like certain topologies break the exporter in some way, but I have no idea what exactly the criteria for breaking the exporter are. I'd also like to note that I didn't try triangulating any of the meshes after remeshing, but I suspect that the outcome would be the same.

I have no idea what exactly the criteria for breaking the exporter are

For calc_tangents to work, the mesh needs be all tris/quads, and there has to be a UVMap.

there has to be a UVMap

That explains a lot, actually. I think I've got reasonable explanations now for why the stuff that broke, broke.

@gabdube's "bunny" needed triangulation (by applying the "Triangulation" modifier) to successfully export tangents.
Selecting "Triangle Fan" as the "Cap Fill Type" when creating a Cyllinder makes the exporter happy.
The Cone has the same solution as the Cyllinder, except for the parameter being called "Base Fill Type".
Remeshes completely destroy UV Maps, selecting all of the vertices and using the built-in unwrap functionality seems to fix the export.
The "Sculpting" template doesn't give you a UV Map, creating one fixes the export.

I guess the warning that can be emitted here ought to be shown more prominently to the user. Ideally, you should be able to see that the export will fail before you run it, but I'm not sure how feasible such a check would be. This conditional should also show the user a prominent error message if it fails, since this is probably the check for whether or not a UV Map exists.
I'm more than willing to try implementing proper warnings, but I'd probably need a little help since I'm unfamiliar with both Blender add-on development and this code-base.

We can show a warning

We could copy what the FBX exporter does and show that little warning popup (but go on with the export):

Patch
diff --git a/addons/io_scene_gltf2/__init__.py b/addons/io_scene_gltf2/__init__.py
index 3ea1ce1..ce82553 100644
--- a/addons/io_scene_gltf2/__init__.py
+++ b/addons/io_scene_gltf2/__init__.py
@@ -404,6 +404,7 @@ class ExportGLTF2_Base:
         # All custom export settings are stored in this container.
         export_settings = {}

+        export_settings['exporter'] = self
         export_settings['timestamp'] = datetime.datetime.now()

         export_settings['gltf_filepath'] = bpy.path.ensure_ext(self.filepath, self.filename_ext)
diff --git a/addons/io_scene_gltf2/blender/exp/gltf2_blender_extract.py b/addons/io_scene_gltf2/blender/exp/gltf2_blender_extract.py
index e2d224c..9197f10 100644
--- a/addons/io_scene_gltf2/blender/exp/gltf2_blender_extract.py
+++ b/addons/io_scene_gltf2/blender/exp/gltf2_blender_extract.py
@@ -167,7 +167,11 @@ def extract_primitives(glTF, blender_mesh, library, blender_object, blender_vert
             blender_mesh.calc_tangents()
             use_tangents = True
         except Exception:
-            print_console('WARNING', 'Could not calculate tangents. Please try to triangulate the mesh first.')
+            export_settings['exporter'].report(
+                {'WARNING'},
+                "Mesh '%s' has polygons with more than 4 vertices, "
+                "cannot compute/export tangent space for it" % blender_mesh.name
+            )

     #

The description in the tooltip here could also be better. FBX points out (will only work correctly with tris/quads only meshes!) in its tooltip.

This conditional should also show the user a prominent error message if it fails, since this is probably the check for whether or not a UV Map exists.

I'm not sure. It doesn't show a warning if eg. "UVs" is selected and a mesh doesn't have UVs, it just don't export any UVs. I think the case of selecting "Tangents" and not having UVs is similar. The FBX exporter also doesn't show a warning for this. The tooltip could point out UVs are necessary though.

I didn't realize we could report warnings in the export process! That would actually be helpful for any number of things, like unsupported materials...

@donmccurdy You need the top-level ExportGLTF2_Base object. I just stuffed it into export_settings.

@scurest

We could copy what the FBX exporter does and show that little warning popup (but go on with the export):

That warning popup seems reasonable.

I'm not sure. It doesn't show a warning if eg. "UVs" is selected and a mesh doesn't have UVs, it just doesn't export any UVs. I think the case of selecting "Tangents" and not having UVs is similar. The FBX exporter also doesn't show a warning for this. The tooltip could point out UVs are necessary though.

I'm not sure what you're advocating for here (other than better tooltips), but I think showing a warning whenever the exporter can't meet the users' demands should be reasonable.  If I select some option which requires me to have UVs, then the exporter should warn me if I don't have UVs when I run it.

Let's be consistent with other exporter. (like FBX for example)

If the glTF exporter triangulates the mesh, why can't it calculate tangents after triangulation?
If I triangulate the mesh myself before exporting, the exporter will export tangents correctly. Is there any difference between those two processes?

There's a difference.
Any quads or n-gons in a mesh are really drawn as triangles. For example, if you bend a quad its easy to see the two tris that make it up.

So every mesh has a "soft" triangulation that always exists even if the mesh has quads and n-gons. The exporter really just reuses this "soft" triangulation. This means the tris that get exported always match the tris Blender draws in the viewer.
But to calculate tangents this "soft" triangulation isn't good enough. You need a "hard" triangulation: the kind you get from applying a Triangulate modifier. However there doesn't seem to be a way to apply a Triangulate modifier that will give you the same triangulation as the "soft" triangulation. For example, the above quad might get triangulated this way instead

So basically the two kinds of triangulations are different things.
There might be a good way to do this but I don't know what it is.

Is this eventually going to get fixed? Otherwise it may be interesting to add some kind of warning in the documentation, as the error is very hard to spot.

I've been intending to implement in-editor warnings, but I've been a bit busy with other things.

Filing a separate feature request for in-export warnings: https://github.com/KhronosGroup/glTF-Blender-IO/issues/1273

Seems the original issue is a Blender limitation, and better warning displayed is manage in a separate ticket.
So closing this ticket.


Lab02 -> Task #7: Close browser and test -> 'SitePhotos' out put variable empty.

Module: Instructions
Lab/Demo: Lab02
Task: Task #7: Close browser and test
Step: 01
Description of issue
'SitePhotos' variable empty after run flow.
Repro steps:

Go to Lab02 -> 'Task #7: Close browser and test' in this repo 'https://github.com/MicrosoftLearning/PL-500T00-Microsoft-Power-Automate-RPA-Developer'
after execute flow observe 'SitePhotos' out put variable empty.

Can you please add a screenshot of your Run JavaScript function step?

Please reopen if you have further info on the problem so we can help diagnose what happened.


Tracking issue for trimmable SRS

Motivation
This PR would consist of implementations toward making SRS trimmable.
There are many things involved. We are currently at the first stage.

make PolyCommit support SRS that is trimmable.
It is not finished yet.

This seems to already involve much changes, since SRS is not only about powers of g, but also:

powers of gamma_g which in Marlin you only need 2 elements.
negative powers of g in G2 which is not needed in Marlin but used in Sonic PC.
powers of g but with degree max_degree - i which is used for degree bounds. In Marlin, all it needs has the shape of 2^t - 2.

Currently the setup is too long: it generates, up to the max_degree, of all of these.
And the SRS is too long: it contains all of these.
If we look at Marlin specifically, the actual effort of setup should be only 1/3, and the SRS would also be 1/3.
Then, you can trim it further if you know that you only index and prove circuits of a specific level of complication.
Test Plan
Will need several tests to ensure that the PC proof generated from the trimmed SRS matches those from the old, full SRS. Especially, pay attention to the hiding bounds.

Adding that we also need infrastructure for proving key.
Why? Since the majority of the proving key is the PC committer key, which is circuit-independent. So, indeed, pk would be also succinct.

I started browsing the PR, but it seems like it's still a work in progress, right?

Yes, it is halfway.

@weikengchen Please mark it as a draft if you're still able to, that way we'll know not to jump and start reviewing

This has been partially done in #317. So I closed this issue.


How to share same attributes in styled components?

I am using "useWindowDimensions" from react native:
import { useWindowDimensions } from 'react-native';

I am getting the width and height like this:
const dimensions = useWindowDimensions();

...and passing it as a prop:
return (
	<Component dimensions={dimensions}>
       ...
	</Component>
);

Using styled components I use attributes:
const Component = styledNative(View).attrs((props) => ({
	dimensions: props.dimensions,
}))`
	${(props) => (console.log(props.dimensions))}
`;

In console log above I am getting what I need.
I want to reuse the same component like this:
const Copy = styledNative(Component)`
	${(props) => (console.log(props.children[0].props.dimensions))}
`;

I am getting dimensions using 'props.children[0].props.dimensions'.
Is there a better way how to reuse styled component and share same attributes?
I do not want to repeat the dimensions prop like this:
return (
	<Component dimensions={dimensions}>
       <Component1 dimensions={dimensions}>
           <Component2 dimensions={dimensions}>
              ...
	       </Component2>
	   </Component1>
	</Component>
);

I want to use it like this:
return (
	<Component dimensions={dimensions}>
       <Copy>
          ...
	   </Copy>
	</Component>
);

Thanks for help.

Hy! @marek8623, The best possible way to perform this task is by nesting the child tag in the parent tag. This will make the parent attributes available for a child too
const Copy = styled.View``

const Component  = styled.View`
  ${(props) => {
    console.log(props.dimensions);
  }}

  ${Child} {
    ${(props) => {
      console.log(props.dimensions);
    }}
  }
`

Just remember that you have to initialize the child class before the parent class. I hope this solution will help. You can see it live working in SandBox. And please do post a sandbox link from next time onward, so that it is easier to debug the code and find the solution.

Hi @imran-prog,
thank you very much for answer.
Basically what I want to achieve is that I need to get dimensions for every screen in React Native using
import { useWindowDimensions } from 'react-native';
and have access to them in every component like this:
const Container = styledNative(View)`
${(props) => (props.dimensions.width <= 820 ? css`height: auto;` : css`height: 100vh;`)}
`;

Is there something similar to React create context in styled components so that I will declare dimensions one time and have access to them in every component?
Thanks

hi @marek8623
I'm not a 100% sure this is what you want, but you can have a look at Theming
All styled-components under the ThemeProvider will have access to the provided theme

@ubeid I am already using Theming in app. But I want to somehow include "useWindowDimensions" result from react native in theme provider.
From "useWindowDimensions" I am getting, for example, this object:
{
    "fontScale": 1,
    "height": 768,
    "scale": 2,
    "width": 1024
}

And this object I want to include in ThemeProvider and have access to these data. Is it possible?
The outcome will be something like this:
${(props) => (props.theme.dimensions.width <= 1024 ...

@marek8623 If you are specifically trying to implement styling on the base of screen width and height then the best solution is to use a media query from CSS. It would be a much better way of implementing this functionality. Or you can even try storing these values in the redux state and then access them in any component. But if you want to know the best solution to implement styling on the base of width and height then I would recommend using media Query instead of props
const Container = styled.View`
  height: 100vh;

  @media screen and (max-width: 820px) {
    height: auto;
  }
`

For this code implementation
const Container = styledNative(View)`
${(props) => (props.dimensions.width <= 820 ? css`height: auto;` : css`height: 100vh;`)}
`;

@imran-prog But when I try to use it with attributes, it is not working:
const NativeTextInputWrapper = styledNative(View).attrs(
	(props: {
		customVar?: number }) => ({
		customVar: props.marginTop,
	}),
)`
	max-width: 1120px;
	max-height: 184px;
	${(props) => (props.customVar ? css`margin-top: 20px;` : null)};

       // this is not working:
       @media screen and (max-width: 820px) {
                height: auto;
       }
`;

@marek8623  To the best of my knowledge, media queries is not supported in styled-components for react native - else @imran-prog solution makes more sense.
You are not limited to one ThemeProvider in your app.
You can have default values for the dimension object in your root theme element.
e.g.:
{
  ...,
  dimensions: {
      fontScale: 1,
      height: 768,
      scale: 2,
      width: 1024
  }
}

You can also leave the dimensions object empty - but do make sure you have null check when using it.
Then, whenever you are using the useWindowDimensions hook, you can just wrap whatever you are rendering with a ThemeProvider overriding the dimensions object.
const dimensions= useWindowDimensions();
return <ThemeProvider theme={(theme) => ({ ...theme, dimensions })}>
  {...}
</ThemeProvider>;

Oh sorry, @marek8623 and @ubeid, I forgot that they don't support media queries for React Native, my bad. But I have tried using a theme provider as you said and it isn't quite working for me as intended. I have even read the documentation of Styled-Components and the problem is we have to define the default theme for every specific Component/Tag.
Button.defaultProps = {
  theme: {
    main: "palevioletred"
  }
}

Going to close this as its a usage question, which should go in Discussions or elsewhere. Thanks for using styled-components!

In style file I'd like to create constant with props, it is possible to this?
Say I need something like this in myComponent.style.jsx (don't mind how this styles is correctly, main purpose create a constant I can use in few styled Views):
const DIVIDER = props.insets ? 16 : 0;

export const Container  = styled.View`
  ${(props) => {
    flex: 1;
    height: props.height - DIVIDER;
  }}

export const Header  = styled.View`
  ${(props) => {
    min-height: DIVIDER;
  }}

if I try use props in const, I got error (


Dailymotion

@arapurayil
can you make for live streaming from Dailymotion ?
I and many others really need it.
If you can, please make it
Thank you

@arapurayil
can you make for live streaming from Dailymotion ?
I and many others really need it.
If you can, please make it
Thank you

Hi! I did make one for dailymotion. Check it out here
You can try out with this link https://dmo.arapurayil.workers.dev/?url=video_url
You can deploy your own worker by copying the worker.js file.
You might have some trouble with some videos though. Depending on the routing the cloudflare worker might not be serving links for your country and this might make some videos unplayable.
So, the best option would be for you to run the script locally. I've included scripts for local nodejs usage in the repo.
You need the index.js and routes.js files and install the dependencies.
Have fun :)

@arapurayil
Thnks bro
I'll try it first


Are Ghost Editor exports compatible with Behavior3js loading and processing?

Hello Renato P P.
Great work here and the BT explanations were very helpful too. Thanks. Interesting topic too.
It looks like Ghost Editor is a much expanded version of Behaviour3 Editor (http://editor.behavior3.com/) with extra modulators, inputs etc.
My queries are:
Can I load and traverse trees created in Ghost using the Behavior3js client library?
(https://github.com/behavior3/behavior3js)
Or am I misunderstanding?

Hey @tebb , thank you for the feedback.
Ghost editor is a specific version for Hanson robotics, they have their own implementation of BTs, thus it is not compatible with b3js client.
It has been some time since I made the last changes on the b3 project, so I recommend that you take a look on the forked version. There is a big pull request to the editor at
https://github.com/behavior3/behavior3editor/pull/28
It may have some good improvements on it.


Filtering

Add an opportunity to filter tree.

Here scenario number 1

Agree with you. I'm working on it already.
About the last one... We will have a function which checks by condition. Something like this:
{
  filter: function(term, node) {
    return node.data.number > term
  }
}

Working on the 2th scenario

U could use https://github.com/bevacqua/fuzzysearch
It is Fast and Fourious )))

I'm trying to do the library as easy as it possible. We have an opportunity to override the matcher function.
...
options: {
  filter: {
    matcher(query, node) {

    }
  }
}
...

Maybe in the future we will be able to switch some option to highlight the matched text. I hope at an early future :)

Early future ))))
Please look at  https://vue-treeselect.js.org/  his got good functional!

Okay :)  I will check.

Could u include this new functional in documentation ?

And how to use it !

Yes. I'm planning to do it today and add more demos

What do u think about drag n drop functionalyti ?

I have created a new issue

you can clone the repository and run commands:
npm install
npm run dev

https://jsfiddle.net/amsik/o7v4a2nL/

Ahhhh it's awesome good. It's very Awesome, Dude u Make my day )))))))))

I very happy to help you :)

Hi! Thank U for the awesome lib.
But where I can add filter options with emptyText in the tree stucture in order to change "Nothing found!" to my other message?


Does not work with Kingdom Come: Deliverance

Extracted all the files to the .exe location (C:\Program Files (x86)\Kingdom Come Deliverance\Bin\Win64)

Tried both 32 and 64 bit versions.

Made sure to run as administrator and have used this tool for other games (I know what I'm doing)

Does not work, no matter what I do the program is not hooking into Kingdom Come Deliverance.

My controller is currently broken, the analog stick drifts to the right. So this is really big issue for me.

I suggest you try with XInput Plus and see if it works.

It seems I have to use the force injector to get Xinput Plus to work, but it works none the less. Thanks.

No problem, thanks for reporting back. It would seem the game requires hooking magic while Durazno is a simple wrapper as I know nothing about hooks.

Hi, just in case it helps making this tool work with KCD, I tried to use XInput Plus too, and at first didn't succeed. Forcing the injector works, but then you can't launch it with GoG Galaxy. Then I tried adding other xinput DLLs (by default, only the XInput1_3.dll is used), and when using the XInput9_1_0.dll, it works without the injector. So maybe this issue is more of a DLL files problem rather than hooks ?
Hoping it can help,
Cheers


Specify load-balancing behavior for each service that is being proxied

What would you like to be added:
For any service that is exposed via service-apis, a service owner should be able to specify the load-balancing behavior that should be used. This can include a common set of algorithms like round-robin, weighted, hash based routing, cookie/session based routing.
Why is this needed:
Most services in Kubernetes are designed to scale horizontally. A lot of legacy services that are ported to run on Kubernetes have the requirement of stick sessions. Most proxies and load balancers support load-balancing as well and this is a widely adopted feature in most of current ingress implementations.

There is certainly an overlap with kube-proxy and the corev1.Service resource here.

Yes, this API would give us an opportunity to add better load balancing knobs without adding more to the core.Service bucket

@robscott Seems like there is already an issue open for load-balancing.

/kind user-story

/remove-lifecycle stale
/lifecycle frozen

In search for a solution, we were unsuccessful in coming up with a portable way to support this feature.
As a compromise, we came up with an easy and portable way to support such implementation-specific features in a consistent manner. The solution is documented in #713.
If there are more portable ways to tackle this, we would love to hear about them.
For now, I'll close this issue.
/close


[SYSTEMDS-314] Python Federated Matrices

This commit contains:

Easy start of federated worker in /bin/systemds.sh
Setup of tests for the Python language bindings federated matrices
Initial tutorial on Python federated matrices
Minor :bug: fix in federated matrix, not allowing multiple sources
Github workflow action for automated federated tests

It would be good to have a minor release with at least the federated worker startup part of this commit.

Also containing documentation update such that it is using relative paths to documentation.
This makes the references work in different forks, pointing to the forks docs.

Note, some tests are failing in python federated.
This is intentionally left in, so that we at some point can go back and fix the underlying functionality.

bug is if you create a federated matrix that is not 100% filled in by federated workers.
bug is if you create a federated matrix that is larger than the input size, it crashes, while expected behavior is to pad the matrix with 0's for consistent behavior.
feature/bug, currently if a single federated matrix is having overlapping sub matrices, see tests "federated basic test" for examples, the system does not complain, and in some cases even works by overwriting the matrix values of the first selected federated matrix with the later matrices.

LGTM except for the failing tests. In your comment, you mention that the failing tests are left in as a reminder to fix some bugs. Why not create a separate PR marked WIP or an issue in the tracker for that?

it makes sense to have tests fail showing the bugs, especially because it is functionality that we 'claim' to support in master.
i also think that @kev-inn would be suited for the fixing the bug. Therefore there i see two ways of going forward, either wait for that fix while being a pull request, or allow the pull request in that shows a bug in the system now. (i vote for the later (not that i have a vote) :smile: ).

it makes sense to have tests fail showing the bugs, especially because it is functionality that we 'claim' to support in master.

Yes, failing tests should show bugs (in the code, not in the tests ;-) ) Since the bugs are already in master, we can merge the tests to point that out. But we should make an exception in situations like this one and not have new code merged with failing tests.

@mboehm7
I have commented out the "advanced" federated matrix tests.
This means it now verifies that the python federated basics work, and we can extend from that.

Fixed pull request to use the brand new SystemDSContext !! Thanks @kev-inn !

Ok, so currently we have the bugs:

bug is if you create a federated matrix that is not 100% filled in by federated workers, then operations does not take into account the remaining cells. This should be fixed, I committed the fix to your sb_fed_python branch, seems like the change didn't make it in to this PR. Should we do a separate one?
bug is if you create a federated matrix that is larger than the input size, it crashes, while expected behavior is to pad the matrix with 0's for consistent behavior, with other functionality.
feature/bug, currently if a single federated matrix is having overlapping sub matrices, see tests "federated basic test" for examples, the system does not complain, and in some cases even works by overwriting the matrix values of the first selected federated matrix with the later matrices.

I am not sure if the second bug is actually a bug or a problem of our function definition. Our definition (the way I implemented it) expects the ranges to match the actual sizes of the matrices on the workers. And the actual size of the federated matrix goes from (0,0) to (max row, max col) given in the ranges, making it therefore not possible to get 0 rows and 0 cols after our ranges are finished. It is also bad that I forgot some very important checks to actually throw errors if the function definition is used wrong (3. could be regarded as fixed if we just check for overlaps).

1. ~bug is if you create a federated matrix that is not 100% filled in by federated workers, then operations does not take into account the remaining cells.~ This should be fixed, I committed the fix to your sb_fed_python branch, seems like the change didn't make it in to this PR. Should we do a separate one?

I don't see the change, did you commit to an old repo?

1. ~bug is if you create a federated matrix that is not 100% filled in by federated workers, then operations does not take into account the remaining cells.~ This should be fixed, I committed the fix to your sb_fed_python branch, seems like the change didn't make it in to this PR. Should we do a separate one?

I don't see the change, did you commit to an old repo?

I committed to git@github.com:Baunsgaard/systemml.git on the branch sb_fed_python.

1. ~bug is if you create a federated matrix that is not 100% filled in by federated workers, then operations does not take into account the remaining cells.~ This should be fixed, I committed the fix to your sb_fed_python branch, seems like the change didn't make it in to this PR. Should we do a separate one?

I don't see the change, did you commit to an old repo?

I committed to git@github.com:Baunsgaard/systemml.git on the branch sb_fed_python.

This pull request is linked to  fedPython branch , I made the other branch because i wanted a branch containing all the tests, (including the ones that shows the bugs), while this one in this pull request only have the minimum requirements parsing.

LGTM - that's awesome. Thanks for the thoughtful addition of tests, docs, and scripts.
Minor things for future modifications: First, maybe it make sense to add a badge for the federated python tests to our readme as well. Second, the docker examples currently refer to 'sebaba' - maybe we can make this more generic.


fix learning for DSK rate

When I did the initial commit for DSK rate, I had only tested against the master branch of companion and not beta. After doing some other work, I realized I had not tested the learn part of rate since that's not currently on master.
This time, I switched to beta and watched the changes live in ATEM software control. 🤦

haha oops.. that shows how closely I read the changes :facepalm:


Azure AI Studio Insights

PR Checklist

[ ] Explain your changes, so people looking at the PR know what and why, the code changes are the how.
[ ] Validate your changes using one or more of the testing methods.

If adding or updating templates:

[ ] post a screenshot of templates and/or gallery changes
[ ] ensure your template has a corresponding gallery entry in the gallery folder
[ ] If you are adding a new template, add your team and template/gallery file(s) to the CODEOWNERS file. CODEOWNERS entries should be teams, not individuals
[ ] ensure all steps have meaningful names
[ ] ensure all parameters and grid columns have display names set so they can be localized
[ ] ensure that parameters id values are unique or they will fail PR validation (parameter ids are used for localization)
[ ] ensure that steps names are unique or they will fail PR validation (step names are used for localization)
[ ] grep /subscription/ and ensure that your parameters don't have any hardcoded resourceIds or they will fail PR validation
[ ] remove fallbackResourceIds and fromTemplateId fields from your template workbook or they will fail PR validation

This PR is ported to https://github.com/microsoft/Application-Insights-Workbooks/pull/2806


alias_method :the_summary, :the_excerpt

the word summary occurrence frequency bigger than excerpt in the cms

should be get_meta("summary")


Website:  [Lightbox media viewer] consolidated updates to the website content

Lightbox media viewer is receiving a few feature upgrades. These additional features need documentation:

updated layout, means some images should be updated #6328
adding carousel #6314
Allow for isolated image view on mobile #6329

Moving to icebox.  See comments in the epic (#6329 )


[Android Termux] Fix missing Z_VCPKG_TARGET_TRIPLET_PLAT. Fixes #32079

Fixes #32079.

Thank you for mentioning this PR, our ci does not have a corresponding machine to test this change, so please make sure that the local test is ok.

Yes, it works with my simple example. https://github.com/funsafe-ptr/vcpkg-test-termux. Without this patch, VCPKG_TARGET_TRIPLET is missing Z_VCPKG_TARGET_TRIPLET_PLAT.


Revert "miniupnpc: 2.2.7 -> 2.2.8 , support static build"

Reverts NixOS/nixpkgs#325273
See https://github.com/miniupnp/miniupnp/issues/758

https://github.com/NixOS/nixpkgs/pull/326402 reverts this.


support tag

Creating a /tag api is overkilled. Integrating tag info into /project api info should be fine. https://github.com/machinefi/w3bstream/blob/main/cmd/srv-applet-mgr/apis/project/pos.go#L14


Fix a number of warnings when building on Windows

This PR fixes a number of warnings when building on Windows.
A common one involves the use of dispatch_assert() and related macros. Passing a pointer to these macros produces a narrowing conversion on Windows because long is 32 bits. This change uses intptr_t instead.
The following warnings are also resolved:
S:\SourceCache\swift-corelibs-libdispatch\src/shims/time.h(266,24): warning: comparison of integers of different signs: 'dispatch_time_t' (aka 'unsigned long long') and 'int' [-Wsign-compare]
                        actual_value = time == DISPATCH_WALLTIME_NOW ?
                                       ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
S:\SourceCache\swift-corelibs-libdispatch\src\init.c(1153,11): warning: comparison of integers of different signs: 'int' and 'unsigned long long' [-Wsign-compare]
                                len = MIN(len, sizeof(szMessage) - 1);
                                      ^   ~~~  ~~~~~~~~~~~~~~~~~~~~~
S:\SourceCache\swift-corelibs-libdispatch\src\source.c(1405,4): warning: format specifies type 'unsigned int' but the argument has type 'dispatch_unote_ident_t' (aka 'unsigned long long') [-Wformat]
                        dr->du_ident, dr->du_fflags, (unsigned long long)dr->ds_pending_data,
                        ^~~~~~~~~~~~
S:\SourceCache\swift-corelibs-libdispatch\src\queue.c(776,39): warning: cast to smaller integer type 'dispatch_invoke_flags_t' from 'void *' [-Wvoid-pointer-to-enum-cast]
        dispatch_invoke_flags_t ctxt_flags = (dispatch_invoke_flags_t)dc->dc_ctxt;
                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
S:\SourceCache\swift-corelibs-libdispatch\src\queue.c(7019,1): warning: function declared 'noreturn' should not return [-Winvalid-noreturn]
}
^
                                            ^~~~~~~~~
S:\SourceCache\swift-corelibs-libdispatch\src\event\event.c(801,2): warning: format specifies type 'unsigned int' but the argument has type 'dispatch_unote_ident_t' (aka 'unsigned long long') [-Wformat]
        _dispatch_timer_du_debug("disarmed", dt);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
S:\SourceCache\swift-corelibs-libdispatch\src\event\workqueue.c(229,59): warning: format specifies type 'unsigned int' but the argument has type 'dispatch_tid' (aka 'unsigned long') [-Wformat]
                        _dispatch_debug("workq: unable to open thread %u: %u", tid, GetLastError());
                                                                      ~~       ^~~
                                                                      %lu

@swift-ci please test

@swift-ci please test windows

This all builds locally on Windows but it doesn't appear that @swift-ci knows how to kick off a Windows build to verify.

@swift-ci please test

@swift-ci please test


Shallow cloning skia deps

I'm not sure but it seems esy-skia is deep cloning its git dependencies.
I think it's possible to improve its behvaiour by cloning specific needed commit. (init, remote add, fetch --depth 1, checkout)

https://github.com/esy/esy/pull/1089 seems to imply that we'd need to swap the commit hash we use to a long one to use the shallow clone.
For some repos (like esy-skia) we should probably test/make that change.

I think this can be done about skia's deps (being fetched by a python script) too

Sounds reasonable! Would be open to a PR on esy-skia to do the shallow-cloning: https://github.com/revery-ui/esy-skia
I'll close this here since it's not an issue with Onivim 2, per se, but a dependency-


attr_encrypted version 3.x is incompatible with rails 7

I tested the tool with the old attr_encrypted 3.x which is incompatible version with rails 7 of  and the result was full compatibility.
I don't know if this behaviour applies to other gems, but with this one, it was clear that it gave the wrong answer.

What RailsBump does is attempt to install attr_encrypted 3.x alongside Rails 7, and if it works, it's marked as compatible.
Since attr_encrypted 3.x only has the "encryptor" gem as a runtime dependency, and not "rails", the installation works.


Added Transcript request form

Transcript form added to the application. Review and approve to be merged to main. Working on the submit function next to enable app create a record of the request in the database.

Thank you @cayeronwi for your consistent reviews. Much appreciated.


Showing user roles

Status
TASK
Checklist
Add checklist if this is a task

[x] Display user roles list
[x] Display user role by Id

Steps
Expected behaviour
Actual behaviour

Closed by #95


Chapter 24 appears blank

Chapter 24 of module Ocean101 appears blank after completion of the previous 23 chapters.

Fixed with https://github.com/learn-ocean/ocean-academy/commit/1330978080f7be3517503a4e58eb218ffaa205cc


FIC 0.1.9 Release

Description:  FIC 0.1.9 Release
General Checklist

[ ] Updated Added functionality/ bug fix in release notes

/azp run


use bootloader option from jsons

IMO lets refactor this more holistically
Also ENUMs please or specify options as constants
These should be their own object in the board file, more cases will go into it not just BL.
And 3 levels of options

defaults (some default specified in test_ui.py)
overriden by options specified in device
overriden by options of a specific variant

Sync with @njezersek

applied the changes @themarpe please review


hubble: fix metrics configuration parsing

Before this patch, the --hubble-metrics flag was declared as a StringSlice which caused split on comma. Since the Hubble Metrics configuration are whitespace separared values that can contain comma, the StringSlice split caused parsing issue for valid configuration.
This patch fix the issue by declaring the flag as a String, and handling the whitespace split manually.
Fix #35619

@chancez The Helm changed I proposed doesn't work. Then I tried to battle with StringArray but still ended up splitted on comma. After too much time, I reverted to the String + manual splitting you proposed in the issue.

/test

/test

/test

/test

Seems like e2e and ipsec upgrade tests is reliably failing due to timeouts. Might need to rebase.


New package: ByteDance.TikTokLIVEStudio version 0.67.2

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot run

Manual Validation ended with:

The process C:\Users\user\AppData\Local\Temp\WinGet\ByteDance.TikTokLIVEStudio.0.67.2\tiktok_live_studio-v0.67.2-win32-x64.exe (DESKTOP-RDM15LU) has initiated the restart of computer DESKTOP-RDM15LU on behalf of user DESKTOP-RDM15LU\user for the following reason: Application: Installation (Planned)  Reason Code: 0x80040002  Shutdown Type: restart  Comment:

(Automated response - build 896.)


Speaker Diarization

Hi,
Is speaker diarization planned (espec. in realtime)?
Thx!

For now we're mainly focused on running the core whisper models, which don't support diarization by default, but if you're up for building a library for this we'd be happy to point to your project.
Seems like there's a few models that have this capability at the moment, here is the most popular thread in the openai/whisper repo on the subject: https://github.com/openai/whisper/discussions/264. We will do our best to stay in parity with them if they pick a specific approach to diarization, but in the meantime there is an open opportunity for another project to bring it to swift. Will keep this issue open until then.


com.microsoft.azure:azure-mobile-android:3.4.0 should not set android:allowBackup to true

The library cordova-plugin-ms-azure-mobile-apps is setting android:allowbackup=true and this is not a correct behavior for a library manifest. I need to have, for a release cordova build, android:allowBackup=false and for this reason I also tried to set it via edit-config command also adding the attribute tools:replace="android:allowBackup" and tools:node="replace".
Below an example:
<platform name="android">
	[...]
	<edit-config file="app/build/intermediates/manifests/full/release/AndroidManifest.xml" mode="merge" target="/manifest/application">
		<activity android:allowBackup="false" tools:node="replace" tools:replace="android:allowBackup" />
	</edit-config>
</platform>

The result is:
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:processReleaseManifest'.
> Manifest merger failed : Attribute application@allowBackup value=(false) from AndroidManifest.xml:5:18-45
        is also present at [com.microsoft.azure:azure-mobile-android:3.4.0] AndroidManifest.xml:11:18-44 value=(true).
        Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:5:5-25:19 to override.

Thanks for getting in touch with us!
It looks like a bug. I mark this issue as a bug on our board.

Updated the AndroidManifest to allow replacement, implemented in PR #156.  Will have to wait on release to bintray for the Cordova client update.

HI all, sorry for the delay in my response.
Thank you all for the clarification.


[REEF-453]  Race condition in GroupCommunication Client initialization

In GroupCommClient constructor, we register the task node to Name Server first, then instantiate CommunicationGroupClient, which will instantiate Operators and register handlers. In Operator constructors, we check if its parents and children are all registered based on the topology. There is a chance that a parent or a child was registered, but haven't completed the initialization, resulting a race condition.
This PR moves the registration in GroupCommClient as the last line in the constructor. And movs the initialize checking out of the Operator constructors. Initialize will be called when client gets Operator from CommunicationGroupClient. This would ensure all the registration happens after constructors. And registration checking happens after all the constructors.
JIRA: REEF-453(https://issues.apache.org/jira/browse/REEF-453)
This closes #
Author: Julia Wang  Email<EMAIL_ADDRESS>

@jwang98052 I left some questions.

Thanks for review. All review comments have been addressed and checked in.
@dkm2110 : could you please build and rerun the tests in cluster with my change?

ok..I will pull you request and do it by tonight.
Dhruv
On Tue, Jul 7, 2015 at 1:46 PM, Julia Wang<EMAIL_ADDRESS>wrote:

Thanks for review. All review comments have been addressed and checked in.
@dkm2110 https://github.com/dkm2110 : could you please build and rerun
the tests in cluster with my change?
—
Reply to this email directly or view it on GitHub
https://github.com/apache/incubator-reef/pull/278#issuecomment-119332639
.

@markusweimer  @jwang98052  I looked at the pull request. Looks good to me. I also was able to build release version by doing some hacks suggested by Julia and the code works fine on cluster.

@jwang98052 I did another pass. One trivial change (a space), but also a question regarding the visibility of the WaitForRegistration() method introduced here.

addressed review comments and pushed in.

@jwang98052 Thanks, I left some more comments :)

Review  comments addressed and pushed in.

I'll do another pass.

@jwang98052 I've done another pass. Minor typos and some C# questions for my education :-)

review comments addressed and pushed in.

@jwang98052 Did another pass, two minor typos.

Updated and rebased and force pushed into REEF-453. Please pull to a fresh local branch when merging.

This looks good, I'll test

After rebase, the build is broken as the issue described in REEF-466. You have to merge REEF-466 first, then merge to REEF-453 and testing.
Debug build in master is broken now until REEF-466 is in.

@jwang98052 Yes, I noticed. REEF-466 is in now and I'll test this.

tests pass, I will merge


pending reserve-excess-capacity pods cause seed as notReady

How to categorize this issue?
/area ops-productivity
/kind bug
What happened:
When there is no enough capacity in seed cluster which enables excessCapacityReservation feature,  reserve-excess-capacity pod can't be scheduled and in pending state,  in this case,  the status of seed is notReady and all shoots created in this seed can't be reconciled anymore
What you expected to happen:
Status of reserve-excess-capacity shouldn't affect seed's status
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Gardener version:
Kubernetes version (use kubectl version):
Cloud provider or hardware configuration:
Others:

/assign

I'm not sure whether this is indeed a bug or whether it's intended behavior. When you enable the excess capacity reservation then the desired state of the seed cluster is that the reserve-excess-capacity pods are deployed and running. If they are pending instead, the cluster should scale up within a few minutes and the seed should be come ready again. Newly created shoots might take a while until they become scheduled again, however this should be within a few minutes (typical duration for scale-up).
Excess capacity reservation does only work well with proper auto-scaling, hence it's the responsible of the operator to properly enable this for the seed cluster. If this cannot be guaranteed, it can also be disabled, see https://github.com/gardener/gardener/blob/master/docs/usage/seed_settings.md#reserve-excess-capacity.

Just saying that with reserve-excess-capacity disabled and fully utilized seed clusters, newly shoots would get scheduled but their creation would fail until the seed gets scaled up.
Now with reverse-excess-capacity enabled and fully utilized seed clusters, newly shoots won't get scheduled in the first place and have to wait until the seed gets scaled up (and becomes "ready" again for shoots).
You can probably find pro and con arguments for both behaviours 🤷🏻
So I don't think that we necessarily have to change this to "fix" it for newly created shoots (they have to wait one way or the other), but I guess non-ready seeds also influence the reconciliation of already existing shoots, and this is probably something we would want to avoid. In this case, we would need to either move the reserve-excess-capacity resources into a dedicated ManagedResource and do not consider its health status when computing the seed's health, or we introduce a new annotation for gardener-resource-manager which makes it skipping health checks for resources with such annotation (similar to "ignore" annotation).
Opinions?

second option seems more flexible.  Meanwhile, we can also setup a Prometheus  alert for reserve-excess-capacity pod, then ops will got informed when capacity is in shortage.

I also think annotation would be better, removing this MR alone from health check feels like a change which is easy to miss later on, Using annotation would be more explicit. And do we want to annotate the MR by default, or only when it is causing problems?

We don't want to annotate the ManagedResource but rather the DaemonSet/reserve-excess-capacity. By default, yes.

we introduce a new annotation for gardener-resource-manager which makes it skipping health checks for resources with such annotation (similar to "ignore" annotation).

sounds good to me

I would rather vote to move the reserve-excess-capacity resources to a separate ManagedResource and to exclude this ManagedResource from the healthchecks (instead of introducing a new annotation and coding about it).

This could be a nice to have feature in resource manager although we don't have any other use case right now. I have already made the changes, please take a look at the PR.


MINOR: Add comment for round robin partitioner with different subscriptions

@hachikuji @ewencp Found it a bit unclear when reading KIP-54. Adds some more comments to clarify the assignment result when the subscriptions are different across consumers in a group.

@ewencp Thanks for the suggestion.

LGTM, and thanks for docs cleanup, these patches are really valuable!


Try to fix macOS hang when building Python 2

Don't open multiple handles to the same file when looking for absolute paths.
Don't use std::future.

I kicked off 3 copies of the osx-x64 build to see if this helps:

https://dev.azure.com/vcpkg/public/_build/results?buildId=99494&view=results
https://dev.azure.com/vcpkg/public/_build/results?buildId=99495&view=results
https://dev.azure.com/vcpkg/public/_build/results?buildId=99495&view=results

I kicked off 3 copies of the osx-x64 build to see if this helps:

https://dev.azure.com/vcpkg/public/_build/results?buildId=99494&view=results
https://dev.azure.com/vcpkg/public/_build/results?buildId=99495&view=results
https://dev.azure.com/vcpkg/public/_build/results?buildId=99495&view=results

Initial results are promising since all 3 of these got past Python2 without issues but without a full understanding of the cause of the problem it is difficult to be sure.


Web Editor and Large Dataset Enumeration

Enumerating Large datasets is very sluggish (# rxns 5760). I am unable to view the result file and get the attached error.

Thanks Mike, sorry it times out for you. We had increased the timeout to try to avoid this but I think we need to look into parallelism in the backend.
It's actually not clear to me whether this is CPU- or IO-bound since it takes a long time to write the final pbtxt Dataset. Our planned shift to binary encoding on the editor backend could fix this without requiring parallel execution.


Update Readme to Include Discord Server Link

https://discord.gg/qx8yME4Dcd

@Joelgranados is the link to join the discord server you added permanent.

It is my understanding that the discord link is permanent.


esri hive JSON serde not found

Following along in spark at https://github.com/geoHeil/spatial-heatmaps/tree/master/esri
the JSON serde is not found
ClassNotFoundException: Class com.esri.hadoop.hive.serde.JsonSerde not found
even though:
"com.esri.hadoop" % "spatial-sdk-hive" % esriVersion,
 "com.esri.hadoop" % "spatial-sdk-json" % esriVersion,

i.e. the current master branch (2.1.0-SNAPSHOT) are on the class path. Am I missing a dependency? The base JSON Serde would be available but is not called.

With Spatial Framework for Hadoop v2, use EsriJsonSerDe rather than the obsolete old name JsonSerde.

Thanks.


get_selected_data() not working

Describe the bug
I am trying to get all of the selected rows of a table using the self.tabulator.get_selected_data() attribute. I have also trying self.tabulator.get_selected() as that is the auto-complete suggestion.
I get the following error:
'tabulator' object has no attribute 'get_selected_data'
for both instances.
To Reproduce
I create a table setting selectable option to True. I know it was recognized because I also change the layout successfully and the row does highlight on selection.
On the row selected method I call the self.tabulator.get_selected_data() method, but it does not return the selected row.
This is on the Tabulator-5 development code.

When do you call this method?
Methods can only be called after the table is built.
I use that in the example app for the delete button click and it's working there.
I think it points to a separate issue about maybe throwing a RuntimeError if trying to access a method before the table is ready.
Note this is new behaviour because I used to be able to create the tabulator component before the form show
Now it has to be created after form show

It is used after the table is create. I'll look at the example and report back.
Thanks!

this might be related to the accidental push earlier
get_selected would only have been in the autocomplete for the current published branch

Assuming this is fixed - if not please re-open


Why does update() return a Result in the latest update?

Hello,
Thank you for your hard work on "kdam". It is my favourite progress crate. As proof that it is my favourite, I count 186 calls on update(1) across my various projects. But in the latest update, update() returns a Result, which it didn't before. (To make my confusion even worse, Result here is an alias of std::io::Result rather than std::result::Result. But that's another subject...) Because, by principle or by religion, I never call unwrap() and always handle Results manually through conditional trees, now I have to handle 186 possible errors. I wonder if there is a big reason for this change, and what would an Err Result even mean. Your docs say:
"Returns whether an update was triggered or not depending on constraints."
but this only explains an Ok Result, not an Err Result.

Thanks for using kdam and counting your 186 update calls. I forgot to write docs about, why some methods return std::io::Result type. Here is an explanation for that.
By default kdam uses std::io::Stderr handle for writing and printing things in terminal. Stderr handle implements std::io::Write trait and it's write method returns Err variant when writing to the handle fails. In previous versions this result type was not returned and unwrap was called instead.
In simple terms, Err variant (very rare) should only be returned when writing to handle fails.
I have done this to make kdam more panic proof. You can also see that println! macro also panics if writing to handle fails.
You can use  Result<(), Box<dyn Error>> (maybe anyhow crate) on your functions and use ? handle error cases. Or you can call unwrap, it should not panic in most of the cases.

@valentina-ka You have great knowledge of Sanskrit.


Switch feature resolver to version 2

Because of the heavy use of features and complicated interactions between them, switching to feature resolver 2 will help alleviate some common pain points.

It seems that that issue is closed now. Will we update to resolve v2 some day?

The workspace TOML now uses resolver = "2".


add license to package.json.

Hey 👋
The library is listed as license: none on npmjs.com.

Nice – thanks!

Published in<EMAIL_ADDRESS>


mod dont work

thanks for you work. while the mod dont work now. do you have some plans to update it ? thanks

Wish I knew how to mod games.

Works for me, it just spews errors (see #21 )

Mod seems to be dead, gg.

This can temporarily be worked around via json files:
https://github.com/v-rising/ModernCamera/issues/24#issuecomment-2143506937

Rip vrising for me, i cant play it without this mod. :(

Hey, if you watch console while playing it goes in NullPointerException, maybe that is causing the mod to not work properly. Here is the fix in the file mentioned by the error log:
`using HarmonyLib;
using Il2CppSystem;
using ProjectM.UI;
namespace ModernCamera.Patches;
[HarmonyPatch]
internal static class ActionWheelSystem_Patch
{
private static bool WheelVisible;
[HarmonyPostfix]
[HarmonyPatch(typeof(ActionWheelSystem), nameof(ActionWheelSystem.OnUpdate))]
private static void OnUpdate(ActionWheelSystem __instance)
{
    if (__instance != null)
    {
        if (!WheelVisible && (__instance._CurrentActiveWheel.IsVisible() || __instance._EmotesWheel.IsVisible()))
        {
            ModernCameraState.IsMenuOpen = true;
            WheelVisible = true;
        }
        else if (WheelVisible && !__instance._CurrentActiveWheel.IsVisible() &&
                 !__instance._EmotesWheel.IsVisible())
        {
            ModernCameraState.IsMenuOpen = false;
            WheelVisible = false;
        }
    }
    else
    {
        Console.WriteLine("Parameter __instance is null.");
    }
}

}`


[Bug]: Performance The vector addition operation takes a long time to complete as the number of records increases.

What happened?
Performance The vector addition operation takes a long time to complete as the number of records increases.
I use chromadb in client/server mode on my kubernates cluster
I encountered that the time of indexing my data increases. When the collection has 1000 records, the speed of adding about 20 or more records in 10 seconds. Now I have 100 000 vectors and the speed of adding is already 4 records in 10 seconds. I suspect that the time to save the index to disk after each insert operation chromadb.db.index.hnswlib Index saved to .chroma/index/index.bin as the index increases in size. Are you aware of this problem ?
This is critical for me as I am now planning to index 100,000 vectors monthly.
Versions
Chroma v0.3.26 Python 3.7.2
Relevant log output
No response

@IvankoPo 0.4.2 fixes this! More explanation here: https://www.trychroma.com/blog/chroma_0.4.0

@jeffchuber Thank you! I've put version 0.4.3, there's still room to grow. I'm adding records in batches of 32. At 50k records, the speed of adding 7 seconds per batch. At 120k records, the speed of adding a batches is already 20 seconds

@HammadB any ideas on speeding things up with the current version?

Yes, there are many low hanging fruit performance wins.


Dialog box hasn't opened since 56.2 release

Ever since 56.2 the dialog box does not show, the plugin is now working

Works as expected with v1.0.10 of the plugin, closing


Kernel Panic when opening Camera app after 4 days of uptime

I've been noticing kernel panics on iPhone 6 when opening the Camera app after about 3-4 days of uptime. Opening the Camera app causes random kernel panics, but it seem to happen more often after about 3-4 days of uptime.
Kernel Panic log is attached.
panic-2017-03-12-034617.ips.zip

Maybe a Substrate bug, noticed that also with Pangu933, try NoSub (PalBreak w/ options) from skylerk99.github.io and disable Substrate for Camera app


Change maintaining team

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Even rust-highfive seems to agreed on this one :-P

bors r+


fix the timePickerContest.updateValue DateTimeParseException

Java get default locale for JVM from windows preference.
My default locale for JVM was korean and It thorws an exception even I
set LocalTimeStringConverter to English.
We can set the locale for jvm in several ways.
(http://www.oracle.com/technetwork/articles/javase/locale-140624.html#using)
But the best way is change some code.
I use DateTimeFormatter not localTiemStringConverter.

Thanks for the fix 👍


Is it possible to use my own "board" UI, or even none at all?

I like the board UI a lot and have been using it from the beginning. (useBoard) Now that our UI has grown in complexity we need to have full control over the UI.
For example, I'm in a dialog or two already and the useBoard call presents behind my dialogs.
Question: is there a way to call the same function that selecting "metamask" or "coinbase" would call on the board, thereby letting us programmatically specify the connector to use? (including just auto choosing a wallet for the user without giving them a choice)
Thanks for a great library!

Here's an example with a visual. Figured you'll like to see a project really using your library! The user is asked to choose a warrior by connecting a wallet. The board is actually displayed behind this quasar (vue3 lib) dialog (the problem). I'm unsure how to make your UI and quasar dialog system aware of each other and would prefer to just have full control over the UI from here on out.

Hey, I think you can write your own custom Board.vue component like this:
https://github.com/chnejohnson/vue-dapp/blob/main/src/components/Board.vue

All you need is use the method connectWith(connector)
const { connectWith } = useWallet()

cost connector = new MetaMaskConnector({
    appUrl: window.location.href,
}

connectWith(connector)


Add dotnet-template tag

I have created a "dotnet-template" tag in github, can you add the tag to this repository so it shows up in the dotnet-template search result?

Done. If you want to double check

Thanks, I see it closing


Add a  'type' field to Entity?

Seems like the `type' property should be applicable to any Entity subtype?
At present, it is added separately to most (but not all) subtypes of this class.  Was this by design?  If so, what is rationale? If not, can we move this property to live in the Entity class, rather than define separately to specific subclasses?
Related: In the core-im-source yaml file, I noted that some classes have a type property with a hard coded value (e.g. "Document", "DataItem"), and others do not have a hard-coded type (e.g. "DataSet", "Statement") – by design, or should we fix/make consistent.  I will make a PR to add missing hard-coded types.

@ahwagner I think it is reasonable and pragmatic to move type to the top level Entity as a required field and remove any subclasses that should not have type (i.e. Mapping).
NOTE: currently MappableEntity does not have type but I believe it should.

PR #36


Fix call to deprecated logInWithReadPermissions

Fixes https://github.com/firebase/FirebaseUI-iOS/issues/684.

Thanks for this PR. This should be released in master soon as well.


Make marks to contain subpages and add geoshape docs

This PR extent the marks in the user guide to contain subpages.
One subpage with documentation related to the mark_geoshape is included.
ps. I forgot to add geopandas as dependency in the requirements.txt for the docs.

I went through this briefly and it looks great to me! I can do a more full review after https://github.com/altair-viz/altair/pull/2566 is merged. I agree with your comment there and think it would be easier to review small PRs instead of extending the same one, but let's hear what Jake prefers.

I have wanted to experiment with deploy previews of documentation related PRs for a while so I setup one here on my fork to test. It seems to work well for this PR. Maybe we can add it to the real altair repo at a later stage so that it is easier to review how the documentation changes with a PR without the need to build locally. The changes you made show up nicely on the link above (https://deploy-preview-1--spontaneous-sorbet-49ed10.netlify.app/).

Thats a nice approach of deploying previews. Locally it is a bit of a struggle with making changes and viewing them.

Add a section on classifications:

And an example how to use an expression for rotation:

The page is becoming a bit slower for loading all the embedded charts..

Wow I love it! That section on classifications is really neat. Altair is going from the lacking geo-docs to having the best ones out there =D

@mattijn Now that the original docs revamp that I was working on is merged, could you open up this PR towards the main altair repo instead of my fork? I think the material here is amazing and I want to make sure we don't lose it. I know there is connection to https://github.com/altair-viz/altair/pull/2607 which I have been meaning to get to for some time, and for me it doesn't matter which one we review/merge first, whatever is easier for you.


relative links starting with ~/ are shows as broken

Hi Bill, thanks for the absolutely brill extension. Loving it.
I use VS2019 for the dev and the file is in index.cshtml in my dev folder.
I use VS Code for awesome extensions like this one for checking broken links etc. But the links that are perfectly valid in Visual Studio for asp.net are shown as broken in vs code using this extension.
so when I hover over the "~/assets/vendor/bootstrap-select/css/bootstrap-select.min.css"
it doesnt go to application root dir to check for it and marks as broken.
obv, I could change ~/ links to just start with / but that would not be advisable in case there are more than one applications in the same root dir.
could you please advise.

Well, the extension is intended for an HTML page that will go on a web server, not an app server.  So it doesn't know any syntax that would work only locally or only in an app server.  A web server wouldn't be able to handle an URL that starts with "~".

Many thanks for your work around, this helped a lot.


fix(certifications): Update text on cert

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.

Description
Addresses a widely-upvoted concern about the wording of the text on the certification. I agree with this sentiment and think this will make the certifications more attractive to hiring managers while conveying the same basic information.
Note that I fixed a minor typo in the Full Stack Development cert, but that needs to be fixed on a subsequent pull request. That cert will be available to anyone who completes all 6 of the new certs.

@raisedadead Thanks for QA'ing!


Mononoki font

https://madmalik.github.io/mononoki/

Created a (sort of sloppy) PR #580

Closing in favour of #580.


Addition of hide/view password on both login and signup page

The password should not be visible and be in hidden format, so i wanted to add functionality to hide and show password

pls assign this to me under hactober and gssoc-extd

@Sourabh782 go ahead.
Add the eye icon on the right of password field to view or hide password

Thanks for assiging,
sure i'll add eye icon


Action is using deprecated "set-output" command

Hello @tchupp & @ebachle! Thanks for a good plugin for posting the Terraform state changes. I started using it today, but as you see in the logs here, https://github.com/mblomdahl/tfc-vs4345-k8s/actions/runs/3796399942/jobs/6456457736, I keep getting this deprecation warning about its use of set-output:

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

If you guys would have some time/effort to address this, I would be very happy! Or, if you want some help/collaboration on resolving it, I can maybe try helping out.

Hey @mblomdahl, both @tchupp and I are aware of that deprecation and it's something we've been meaning to look at.
I can actually take a look at potentially doing it today and see if it works.  I'll double check it against one of our larger projects, because we've run into max size issues with envvars (you can see it in how we transfer the plan outputs via file here: https://github.com/tchupp/actions-terraform-pr/blob/main/action.yml#L118
So that's the one thing I'll check before converting it over.  It should be a pretty easy update if that's not an issue.

I'm going to do this in two steps, because one is us changing our code, and the other is us having to update a dependency.
The first PR #26 is going to fix ours and that tested cleanly.
The other is going to be to update to the most recent copy of https://github.com/actions/github-script, because in a recent patch, the maintainers updated that.  https://github.com/actions/github-script/releases/tag/v6.3.2.  But that's two major version hops, so I want to test that separately.

@mblomdahl this should all be resolved in https://github.com/tchupp/actions-terraform-pr/releases/tag/v1.0.22, or if you're using just the v1 tag, it should be set there as well!
Thanks for brining it up!

@ebachle Thanks for looking into this so swiftly! I tried pulling in the new changes and verifying in my project, but it does not seem that the release is fully published...? I noticed an error in this "Release Tagger" workflow run here, https://github.com/tchupp/actions-terraform-pr/actions/runs/3796828973/jobs/6457272468

When I ran my first PR with "@v1", then I noticed that many deprecation warnings were still there as if nothing had been updated (see GHA output from mblomdahl/tfc-vs4345-k8s#12). Then, when I updated my other PR to use<EMAIL_ADDRESS>specifically in mblomdahl/tfc-vs4345-k8s#11, I get the following error message:

Error: Unable to resolve action<EMAIL_ADDRESS>unable to find version v1.0.22

Does this make any sense to you?

Sorry, false alarm. It was "skit bakom spakarna" as we say in 🇸🇪... I added<EMAIL_ADDRESS>to the wrong GHA dependency. Now it resolves! I added #28 however to track the publishing issue.
I think there might be a few less set-output deprecation warnings in the end, but at the early stages of the run, we still have a bunch to go! 🙃

Heya @mblomdahl, I did a bit of digging and I think I know what's going on there and what the difference is between the test pipeline I ran it on and yours.
What it boils down to is the version of hashicorp/setup-terraform that you're using higher up your pipeline:
The reason I needed to upgrade the actions/github-script to v5+ in one of my PRs is because it update the version of the NPM package @actions/core to 1.10.0.
In the v1 line of the setup-terraform they're still using @actions/core that's a bit older.  https://github.com/hashicorp/setup-terraform/blob/v1/package.json#L22
If you bump to the v2 version of hashicorp/setup-terraform, then that should clean up as it's ultimately what's hiding behind that terraform-bin wrapper that's being executed in your pipeline.
I'll make sure that our examples for using this though don't reference v1, so that nobody picks it up from us.

@mblomdahl #29 should update all the examples to represent the most current versions of the dependencies to use, including the setup-terraform one that was causing this issue for you.


Generation of KeyTable keys off-ledger

At present, we rely on the following code to generate keys:
https://github.com/digital-asset/daml-finance/blob/484dcab2b66a5366636353bae351deae23b0b6f8/src/main/daml/Daml/Finance/Interface/Util/KeyTable.daml#L67C33-L67C33
The use of show particularly is problematic; it relies on the internal representation of Show, which is often derived i.e. deriving (Eq, Show), and to provide a keyTable off-ledger, we need to generate this manually.
We haven't run into this problem yet as our tests are run using Daml script, which provides access to the show instance.
One workaround would be to provide a manual instance of show e.g.
show = DA.Text.intercalate "|" $ show <$> [hodling.id, holding.registrar, holding.depository]
-- "Account 1|GS123|JPM234"

But this is also quite clunky (what happens if a customer uses | in their account keys?)
A less problematic issue is also the use of a hash here. What happens if we have a clash? (e.g. two keys that have the same string such as "1" (numbered accounts and clients)).
cc @johan-da

A suggestion is to add a constraint to the HasSyntheticKey class HasField "id" Id t, i.e. that the type has a field called id of type Id (which is itself a newtype Text). This would make things much easier off-ledger, and keys would be more meaningful. On the other hand, this would make key clashes more likely (two users with Savings).


fix(actions): Wasn't actually emitting the correct actions to the actions Subject

Was instead accidentally emitting only async actions, which is useless.
if (typeof action === 'function') {
    let obs = from(action(actions, store));
    let sub = obs.subscribe(next);
-   actions.next(action);
    return sub;
  } else {
+   actions.next(action);
    return next(action);
  }

Merged with a1cf32e


Fixed Prettier using plugins

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#556  👈
#555
#554
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatChen and the rest of your teammates on  Graphite


Cleaning up empty namespaces

I wonder if anyone could offer any advice here:
My application creates namespaces dynamically. The load on the database server steadily increases as more and more change streams are opened, one per node per namespace. After a few days, the majority of the DB capacity is spent servicing change streams for namespaces that no one is listening to.
I've attempted to clean up manually, with the code below. This appears to cause errors, as some nodes believe the namespaces exists while others do not.  How can I close out the change streams and destroy the namespace properly, and how would I know when that is?
 function clearEmptyNamespaces() {
            for (const nsp of io._nsps) {
                if (nsp[0] !== '/' && nsp[0] !== '/launch' && nsp[0] !== '/system' && nsp[0] !== '/admin') {
                    const namespace = nsp[1];
                    if (namespace.sockets.size == 0) {
                        console.log('Removing namespace' + nsp[0]);
                        io._nsps.delete(nsp);
                        namespace.adapter.close();
                    }
                }
            }
        }

You are right, the current implementation is not well suited for dynamic namespaces. I think that we could instead have a single change stream, which sends each change to the right adapter.
In you example, namespace.adapter.close() should indeed close the change stream, but it does not notify the other nodes (here), so there might be some errors during the heartbeatTimeout delay.

I had no trouble replacing the call to collection.watch with a global singleton changestream, and doing the little bit of matching logic in Node instead of Mongo. I can't really think of any downsides to this approach, but I'll run it in production for a while and see.

That seemed to make a huge difference! Check out how the load on the DB plummets. Are there any downsides here? I guess a small amount of compute is transferred to Node (evaluating if the namespace == this.nsp and uid !== this.uid)

Awesome, thanks for the update!
I don't think there are any security implications. Would you have time to open a pull request with your changes?

Implemented in https://github.com/socketio/socket.io-mongo-adapter/commit/9b5f4c83038cc212b898b7fb7ff0ccec3124447c, and included in<EMAIL_ADDRESS>Thanks!


module5:Display food

Display food
Requirements

Should display a list of food added by the logged-in user as in the wireframe (display also quantity of a given food).
Should lead to a form that allows users to add new food.

Hey @derrick1451 i. There is nothing else to say. Your project section is complete, And it looks amazaing if I say so myself. Great job 👏🏾


app-db changes lost with SharedPreferences interceptor

See repro in repository: https://github.com/valerauko/re-dash-repro
Main issue around http/handle-success and session/update-ssid

Can you try with branch
https://github.com/htihospitality/re-dash/tree/interceptor-await
I removed all the await calls as a test and that got your repro working with / without the persist interceptor, (along with the intended update-server event)
I suspect after the new events queue that got implemented a while ago, the need for async /await everywhere became superfluous, and this might have in turn led again to unordered event + interceptor execution as a consequence.
I still need to go through all the samples and tests to see if all is still working though, will continue again tomorrow.

Don't bother with the branch mentioned above, it resurfaced the coeffects-as-future bug.
I'm redesigning the events queue on top of Queue - Initial testing looks promising

A better events queue implementation based on Queue :
https://github.com/htihospitality/re-dash/tree/better-events-queue
All tests pass, all samples work, and this repro work


RHINENG-8218 dependencies upgrade: react 18, patternfly V5 and more

React 18 & Patternfly V5 upgrade :boom:
RHINENG-8218 dependencies upgrade: react 18, patternfly V5 and more
Jira:
https://issues.redhat.com/browse/RHINENG-8218
https://issues.redhat.com/browse/RHINENG-8219
Why do we need this change? :thought_balloon:
Please include the context of this change here.
Documentation requires update? :memo:

[ ] Yes
[ ] No

Security Checklist :lock:
Upon raising this PR please go through RedHatInsights/secure-coding-checklist
:guardsman: Checklist :dart:

[ ] Bugfix
[ ] New Feature
[ ] Refactor
[ ] Unittests Added
[ ] DRY code
[ ] Dependency Added

Additional :mega:
Feel free to add any other relevant details such as links, notes, screenshots, here.

Codecov Report
Attention: Patch coverage is 0% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 8.11%.  Consider uploading reports for the commit 037c1a6 to get more accurate results

Files
Patch %
Lines

...rc/Components/SystemDetail/RecommendationsTable.js
0.00%
15 Missing :warning:

...ponents/HistoricalDataChart/HistoricalDataChart.js
0.00%
8 Missing :warning:

src/bootstrap-dev.js
0.00%
3 Missing :warning:

src/bootstrap.js
0.00%
3 Missing :warning:

.../Components/EmptyStateDisplay/EmptyStateDisplay.js
0.00%
1 Missing and 1 partial :warning:

...nents/InstanceTypes/SuggestedInstanceTypesTable.js
0.00%
1 Missing :warning:

...nents/RecommendationRating/RecommendationRating.js
0.00%
1 Missing :warning:

src/store/entitiesReducer.js
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #322       +/-   ##
==========================================
- Coverage   19.93%   8.11%   -11.83%
==========================================
  Files          47      47
  Lines         973     974        +1
  Branches      185     183        -2
==========================================
- Hits          194      79      -115
- Misses        728     837      +109
- Partials       51      58        +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I'm going through the changes, line-by-line, but I wanted to bring up a couple of things:

Is there an account I can log into to test the system detail table? you can DM me
This may be a good time to convert your class components to functional components. It's up to you, and you can do it here or in another PR. I won't hold up approving this PR on that though. But, I will say that in other PRs where class components were used, I noticed strange behavior until I converted the components.

I'm going through the changes, line-by-line, but I wanted to bring up a couple of things:

Is there an account I can log into to test the system detail table? you can DM me
This may be a good time to convert your class components to functional components. It's up to you, and you can do it here or in another PR. I won't hold up approving this PR on that though. But, I will say that in other PRs where class components were used, I noticed strange behavior until I converted the components.

@johnsonm325

I have shared the login cred in DM
Thank you for sharing, I didn't face any issues yet with code changes. There is plan to do refactoring as a part of separate card.

@PreetiW I have noticed you removed tests for some components (like RecommendationRating.test.js) Are you planning on re-implementing them using React Testing Library ?
I am not talking about ones that only test snapshots, though it would be wise to implement a small unit test for each component to see that it's components are being rendered correctly, maybe check a small functionality like the expected modal is being opened

@LiorKGOW yes I have created a seperate card to add the tests using RTL and currently working on the same. I will raise seperate MR for it 🙌🏻  https://issues.redhat.com/browse/RHINENG-9113

On the system details page, the gap between the "Delete" button and the "Actions" dropdown is gone.
Also, if you look at the comparison of these two (your changes are on the left and stage is on the right) it appears that your changes have removed the blue highlight on the expanded which (which I know it should have).

@johnsonm325 the delete and action button is handled by inventory component.

@PreetiW You can bypass Lior's review here. He's passed off the review to me.

Thank you @johnsonm325 & @LiorKGOW for the review 🙌🏻 Merging this one!