Extend transaction logic tests

Explain your changes:

Add a few more unit tests for the transaction logic.

The ongoing audit of the transaction logic revealed a couple so far untested properties that the transaction logic should satisfy.
Explain how you tested your changes:

dune runtest src/lib/transaction_logic,

Checklist:

[x] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[x] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[x] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[x] All tests pass (CI will check this if you didn't)
[x] Serialized types are in stable-versioned modules

!ci-build-me

I've got a function creating a payment of a random amount from one random account to another (without the fee, though). Sadly, there are nuances in most tests which make it difficult. For example sometimes ti's the receiver who pays for the transaction. Or there are no money transfers at all, just account updates. One thing, which bothers me, though, is repeated arithmetic operations on Mina returning options. This is cluttery and annoying. Perhaps we should have a saturated arithmetic module to facilitate and make it look nicer…

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!approved-for-mainnet

!ci-build-me

!approved-for-mainnet


Question: Is there any way to compress snapshots ?

No, we are unlikely to add this. Snapshots are text files and should be treated as such.


need to install GO to build Rye-fyne?

The combination Rye & Fyne looks very nice. But your instruction to get the examples running seem to mis some steps. Doing .build on Windows just gives an error "command not found". Some steps to build fyne-rye seem to be missiing. Do I need to install also GO itself?
Is it not possible to create an easy to  install rye-fyne executable for Windows/Linux/Mac? It would make experimenting with those GUI-examples for non-techs a lot easier.

You are correct. Rye-fyne's readme hasn't yet been updated and we should also add workflows that would make builds available. We have all that at main Rye repository, but Rye-fyne is just starting to work, and this is not there yet. Since I made the Cookbook page and published it it only makes sense to hurry up and add this also. I will try to do both in next few days. Thanks for the interest!

This was the first time I tried to use Rye or Rye-fyne on Windows. I saw that ansi codes (colors / etc) don't work in Windows commandline at all. I fixed that and re-uploaded here:
https://github.com/refaktor/rye-fyne/releases/tag/testbuild3
Besides the console I didn't get to test it yet. You can try it and please report if there are any problems.

I am tryning to install rye en fyne on my old mac. I have installed Go. That works. I have also installed Rye. Works also.
But how to build rye-fyne?
Is the first instruction below about 'build' correct?  Where does that Rye-fyne directory come from? Should I make an empty folder named rye-fyne in the rye-folder?

Ah, I thought you were on Windows. We now have Windows, Linux and MacOS rye-fyne binaries. I tested Linux and Windows and a colleague tested in to MacOS and it worked:
.
You can get the latest build here, but there will be new ones soon: https://github.com/refaktor/rye-fyne/releases/tag/23
In this case you don't need Go, you just download and unpack the binary and run rye-fyne and you will enter console where you can run for example this code: cc fyne , app .window "Hello" |set-content label "world" |show-and-run
About your question. If you have Go installed and you want to run ./build ... you have to download this repository we're currently in (rye-fyne): https://github.com/refaktor/rye-fyne/
You can do so by downloading Zip on the top-right of the page or if you use Git you can
git clone https://github.com/refaktor/rye-fyne.git
git clone git@github.com:refaktor/rye-fyne.git
In this folder that you download or git clone (rye-fyne), you can then run ./build . You basically don't need to have regular rye for this.

Hi Refactor,
Thanks for your nice work.
I actually have gathered lots of laptops in the last 30 years; running   windows, Mac and Linux .
Hobby programming with Rebol, Red, Arturo and lately Rye-fyne.
TypeApp voor Android downloaden
Op 3 okt. 2024 12:01, om 12:01, Refaktor @.***> schreef:

Ah, I thought you were on Windows. We now have Windows, Linux and MacOS
rye-fyne binaries. I tested Linux and Windows and a colleague tested in
to MacOS and it worked:
.
You can get the latest build here, but there will be new ones soon:
https://github.com/refaktor/rye-fyne/releases/tag/23
In this case you don't need Go, you just download and unpack the binary
and run rye-fyne and you will enter console where you can run for
example this code: cc fyne , app .window "Hello" |set-content label "world" |show-and-run
About your question. If you have Go installed and you want to run
./build ... you have to download this repository we're currently in
(rye-fyne): https://github.com/refaktor/rye-fyne/
You can do so by downloading Zip on the top-right of the page or if you
use Git you can
git clone https://github.com/refaktor/rye-fyne.git
git clone ***@***.***:refaktor/rye-fyne.git
In this folder that you download or git clone (rye-fyne), you can then
run ./build . You basically don't need to have regular rye for this.
--
Reply to this email directly or view it on GitHub:
https://github.com/refaktor/rye-fyne/issues/31#issuecomment-2391009059
You are receiving this because you were mentioned.
Message ID: @.***>

You are welcome. Thanks for the interest. The build process seems to work at least in general on all 3 OS-es, so I will close this Issue. I will be adding rye-fyne download links to this repo README and to ryeang.org front page.


feat: FieldMerkleTree tree with arbitrary hasher

This PR allows FieldMerkleTree to have a digest word that is different than a field element, while keeping the packing API in place by introducing PackedValue trait as a super trait to PackedField.
This saves the need to convert to field elements in each level of the tree.

Replaced with updated version #23


Add metadata about the sticker pack that a sticker image belongs to.

We need to add information about the sticker pack that sticker images belong so that users can discover integrations (and add / use them themselves).

@rxl881 plz can haz an explanation of how the stickerpack_url is meant to work?

Thanks for clarifying what the URL is supposed to be.
Having the URL be a link to the integration manager introduces a compatibility problem between managers. For instance, if someone were to have a 3rd party sticker picker then there's a good chance that Scalar (for example) wouldn't be able to add the sticker pack. Likewise, a 3rd party integration manager won't know how to add a Scalar sticker pack.
Solving purchasing is a harder problem to solve, but for the ability to share sticker packs a consistent and predictable format is needed. As part of the user-curated sticker pack work I've been experimenting with I've come up with a very arbitrary JSON format that a given URL could spit out so the sticker picker can self-add the pack. That format looks something like this:
{
  "version": 1,
  "type": "m.stickerpack",
  "name": "Huskies",
  "id": "arbitrary_id_for_tracking",
  "author": {
    "type": "mx-user",    // Note: this could also be a company, email, or some other source
    "id": "@travis:t2l.io"
  },
  "license": "CC", // or something
  "stickers": [{
    "id": "arbitrary_id_for_tracking",
    "description": "This is a happy husky",
    "contentUri": "mxc://t2bot.io/b4636e93388542f3cad8fcbb825adf36"
  }]
}

As mentioned, there hasn't been much work on my part to further refine this format as it's all experimental. Having sticker packs being compatible between managers (and sticker pickers) is very much needed in my opinion, although solving the paywall problem needs more thought.

@turt2live - Thanks for your suggestions on the format for widget "auto-addition". I think that this looks like a really good starting point for self-adding stickerpacks / widgets (and is definitely something that we should build on in due course). However, I think that this is  probably a bit more than what I am trying to achieve here.
The intent of the stickerpack URL as it is at the moment (in this PR) is simply to direct a user clicking on it to a (modal) web-UI for manual addition of the stickerpack (or other asset).
This should work for any Integration Manager (IM) that is currently configured to work with the user's Matrix client. E.g. if the sticker pack is from Scalar, the link should open the right page of the scalar web-store, and similarly if it is from Dimension (or other 3rd party IM) the correct page should be opened there. This allows for the correct purchasing & payment flow etc. to be handled by the IM before adding the widget & updating asset records.
Links to integration managers that are not enabled for use by the matrix-client should redirect to an integration manager configuration flow (to add the integration manager in the settings of the client) or a warning that the integration manager is not supported, depending upon the configuration, restrictions or capabilities of the client in use.
It sounds likely that the auto-adding widget/asset link that you propose will be useful as an additional mechanism to this one, probably for cases where no purchasing is required, or once we've established other flows for that, a bit further down the line. In future we might even want to try the auto-adding approach in the first case and then redirect to this endpoint as a fallback, if payment details or manual intervention is required. Does that sound like a plan to you?

@richvdh - I've taken another crack at clarifying the URL format and that the aspects (rendering and tracking query parameters) that matrix clients should be responsible for. Can you please take another look when you have a sec?

@turt2live :

The behaviour you've described doesn't appeal to me in the sense that it's not inter-operable between different managers.

We need to do more work to support multiple simultaneous integration managers, but I don't see why this isn't inter-operable. Far from it, this allows users to discover stickerpacks and integrations from other integration managers based upon the message content that they see.

I may be misunderstanding something, but I'm not seeing how Scalar can add/edit sticker packs on a Dimension sticker picker (and the other way around)? In your earlier post, it was suggested that the URL open the appropriate integration manager, falling back to a warning if the client can't coordinate the effort. The falling back could easily end up leading to someone purchasing a sticker pack and being unable to use it (or having to make a choice between which picker to use).

We definitely want to get to the point where users can seamlessly have multiple IMs enabled, simultaneously, but there is still some work that needs to be done to get there. This proposed solution allows arbitrary IMs to be used as a stepping-stone in that direction.

I'm not seeing how Scalar can add/edit sticker packs on a Dimension sticker picker (and the other way around)?

We wouldn't be trying to do this.

... The falling back could easily end up leading to someone purchasing a sticker pack and being unable to use it (or having to make a choice between which picker to use).

This should not be the case. The intention at the moment is for matrix clients to be able to support multiple stickerpicker widgets embedded within the same UI component for the case where users wish to use multiple integration managers simultaneously.
See the comment at - https://github.com/matrix-org/matrix-react-sdk/blob/master/src/components/views/rooms/Stickerpicker.js#L186-L189:

// Stickers
// TODO - Add support for Stickerpickers from multiple app stores.
// Render content from multiple stickerpack sources, each within their
// own iframe, within the stickerpicker UI element.

From the user's point of view they would still open the sticker selector in the same way, but the AppTile element would load multiple child iframes, each containing a stickerpicker widget (one from scalar and one from Dimension, for example). This should be transparent to the user, other than there being two filter boxes, one at the bottom of each widget, at the moment. We could get round this (to make it more seamless) by having the filter part of the matrix client and extending the postMessage API to send filter update events to the (multiple) sticker pickers, for them to filter and display the correct content.

I still have concerns that this isn't going through the (now formal) proposal process because it's not getting the review it needs. It seems as though client developers, at the least, aren't involved in the discussion here and that can cause problems if this lands in the spec.
Some clients may not want to implement their sticker picker as multiple iframes. There's already clients out there (Fractal) which are in the early stages of adding stickers, and they don't use iframes at all. Instead, they opt to provide a more native-feeling UI for picking stickers, calling into the API as required (which happens to break when Dimension is used because the API is completely different and not specced for this kind of thing).
tldr: I feel we need to have a larger discussion about how this integration manager stuff is supposed to work and what the use cases are. Adding temporary things to the spec will only make them permanent and hard to remove or replace in the future. Instead, the planning should be put in ahead of time to ensure that use cases aren't missed, and that everyone is on the same page.
(I also have strong feelings, as demonstrated, about how this particular functionality should be addressed)

so the situation here is that we simply haven’t had time to sort the spec here, and rushing it through now outside the proper spec process is well-intended but not going to help. i suggest we shelve it until we have bandwidth again with anyone working on stickers (ie after other priorities are on track on the NV side). in future we’ll try to catch it at the proposal stage (ie before impl).

I actually thought this was an attempt to document the status quo, but it looks as though existing m.sticker events lack the stickerpack property, so perhaps that's not true?
(the text now looks clear to me, though...)

I'm going to close this while we're waiting for an MSC - the changes now conflict with the current spec and having bitrotted PRs open is not super helpful to us :(
MSC1951 lays some foundational work in this area.


Remove npmlog

We're not using it, so let it go!

True, if think all was moved to rnpm link?

yep, I'll clean it up

Closed by https://github.com/rnpm/rnpm/pull/86


Error#2

We are trying to execute the example_poison_attack.ipynb  code, and we faced this error:
FileNotFoundError                         Traceback (most recent call last)
 in ()
----> 1 X_train = np.load("data/X_train.npy", allow_pickle=True)
2 y_train = np.load("data/y_train.npy", allow_pickle=True)
3 X_valid = np.load("data/X_valid.npy", allow_pickle=True)
4 y_valid = np.load("data/y_valid.npy", allow_pickle=True)
/usr/local/lib/python3.7/dist-packages/numpy/lib/npyio.py in load(file, mmap_mode, allow_pickle, fix_imports, encoding)
415             own_fid = False
416         else:
--> 417             fid = stack.enter_context(open(os_fspath(file), "rb"))
418             own_fid = True
419
FileNotFoundError: [Errno 2] No such file or directory: 'data/X_train.npy'

@Roua512
Sorry for the late reply. I have updated the notebook. Could you check it works in your environment?

yes it works, thank you.


PackageDeployment: add ability to configure calls to mutator functions

Closing this here and tracking in https://github.com/nephio-project/nephio-controller-poc/issues/22


Spurious trailing arguments in jshint.js

The following invocations of function statement pass a Boolean argument, although statement does not take any arguments at all:

https://github.com/jshint/jshint/blob/master/src/jshint.js#L1748
Note that this is the only use of parameter startLine of function statements, so this parameter is effectively ignored as well.

https://github.com/jshint/jshint/blob/master/src/jshint.js#L3672

The following invocations of bitwiseassignop pass two extra arguments that are ignored:

https://github.com/jshint/jshint/blob/master/src/jshint.js#L2205
https://github.com/jshint/jshint/blob/master/src/jshint.js#L2206
https://github.com/jshint/jshint/blob/master/src/jshint.js#L2207
https://github.com/jshint/jshint/blob/master/src/jshint.js#L2208
https://github.com/jshint/jshint/blob/master/src/jshint.js#L2209
https://github.com/jshint/jshint/blob/master/src/jshint.js#L2210

Similarly, these two calls to suffix pass an extra argument that is ignored:

https://github.com/jshint/jshint/blob/master/src/jshint.js#L2361
https://github.com/jshint/jshint/blob/master/src/jshint.js#L2365

This call to prefix passes a precedence as its third argument, which is ignored. Interestingly, it passes a precedence value of 160, while prefix uses precedence 150:

https://github.com/jshint/jshint/blob/master/src/jshint.js#L2717

And finally, this call to lookupBlockType passes an argument true, which lookupBlockType ignores:

https://github.com/jshint/jshint/blob/master/src/jshint.js#L2718

Thanks for following up with gh-1801! Closing this as it's no longer relevant.


⚠ Processors has degraded performance

In 2faf831, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 73 ms

Resolved: Processors performance has improved in 9f40727.


UART IRQ broken

@Jason2866  (master of the cores)
Hi ,
wanted to inform you that this PR broke Hardwareserial in some situations.
https://github.com/espressif/arduino-esp32/pull/6134
i had some users complaining about SML stopped working and investigated the issue
this is by the way a stupid modification. it creates a new task which uses 2k of RAM to monitor the UART IRQ.
it also causes unnecessary cpu cycles.
it adds the call uartOnReceive
which may be of interest for some applications but definitely should be optional and not default.
why not enable this feature only when requested ?
reverting this pr brings things up to normal.

@gemu2015  Servus, greetings from South Germany.
Could you open a issue in Arduino Github too?
I will revert in our build.  Place in platformio override file
[env:tasmota32_base]
; *** Uncomment next lines ";" to enable development Tasmota Arduino version ESP32
platform                = https://github.com/Jason2866/platform-espressif32.git#IDF44/ESP32-S3
platform_packages       = framework-arduinoespressif32 @ https://github.com/Jason2866/esp32-arduino-lib-builder/releases/download/664/framework-arduinoespressif32-v4.4_dev-73c0f44528.tar.gz
build_unflags           = ${esp32_defaults.build_unflags}
build_flags             = ${esp32_defaults.build_flags}

Needs https://github.com/arendst/Tasmota/pull/14861 for fixing onewire
which i have just merged now

@Jason2866 - tht PR #6134 must be applied with PR #6201 to fix it.


add javadoc for storage queue and messaging

As subject, to resolve API review issues.

API changes have been detected in com.azure.spring:spring-messaging-azure-servicebus. You can review API changes here

API changes have been detected in com.azure.spring:spring-messaging-azure-storage-queue. You can review API changes here


Fix array conversion during validation

I noticed this bug while testing a swagger.yaml that included minItems and maxItems properties on an array parameter.
It is quite obvious and self-explanatory.

Coverage remained the same at 100.0% when pulling 704ad95536064eaf7fe5cc4b3ff7af79cd1f9805 on gredin:fix_array_conversion into 4ab9625d2a3e5b0a720ba4859c084fc3d62fa33a on zalando:master.

:+1:

Thanks for the PR.

Thanks for the release. Any idea when a release will include this fix?

@gredin we should get a new version later today.

@gredin @rafaelcaricio released here: https://github.com/zalando/connexion/releases/tag/1.0.95

Faster than I thought. 👍


[Document][model] Connect to model serving of DB-GPT cluster in AWEL?

Search before asking

[X] I had searched in the issues and found no similar issues.

Operating system information
Linux
Python version information
3.10
DB-GPT version
main
Related scenes

[X] Chat Data
[ ] Chat Excel
[X] Chat DB
[ ] Chat Knowledge
[ ] Model Management
[ ] Dashboard
[ ] Plugins

Installation Information

[X] Installation From Source

[ ] Docker Installation

[ ] Docker Compose Installation

[ ] Cluster Installation

[ ] AutoDL Image

[ ] Other

Device information
GPU 32G
Models information
LLM：Qwen1.5-14B-Chat
Embedding: text2vec-large-chinese
What happened
我已经成功在本地linux系统上启动了以下服务（llm，text2vec）

现在我想在AWEL的示例代码里使用这两项服务实现文本向量化和大模型调用，但是失败了，代码和错误如下：

requests.exceptions.HTTPError: 404 Client Error: Not Found for url: http://<IP_ADDRESS>:8001/api/v1/embeddings
What you expected to happen
请问如何修改AWEL脚本里的设置才能正确使用cluster中提供的服务？
How to reproduce

Additional context
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Hi, @lastshogunshin.
I suggest you deploy a API Server for the model serving, here is simple command to deploy a API Server:
dbgpt start apiserver \
--controller_addr http://<IP_ADDRESS>:8000 \
--api_keys EMPTY \
--port 8100

Note: The controller_addr is the address of the Model Controller,  please replace it with the real address of the Model Controller.
API Server will provide a HTTP API which is compatible with OpenAI's API.
Then you can use the DefaultEmbeddingFactory and OpenAILLMClient to connect to the remote DB-GPT model serving.
from dbgpt.core import Embeddings
from dbgpt.model.proxy import OpenAILLMClient
from dbgpt.rag.embedding import DefaultEmbeddingFactory

llm_client = OpenAILLMClient(
    api_key="EMPTY",
    api_base="http://<IP_ADDRESS>:8100/api/v1",
    model_alias="Qwen1.5-14B-Chat"
)

embeddings: Embeddings = DefaultEmbeddingFactory.remote(
    api_url="http://<IP_ADDRESS>:8100/api/v1/embeddings",
    api_key="EMPTY",
    model_name="text2vec"
)

Thank for your help! I was just thinking of setting up a API server may help, and this answer came up.
I will try this out and see if it works for this issue, thanks again.

Hi, just try the API server method. But only embedding model works when I call the API in python script. As for LLM model, it didn't work.
Can you tell me how to call the API to use LLM model? Since embedding & LLM workers are both contained in the dbgpt controller, there should be someway to use LLM model too.

Thank for your help! I was just thinking of setting up a API server may help, and this answer came up. I will try this out and see if it works for this issue, thanks again.

Sorry just tried it out, the embedding model works just fine, but LLM came up with this error:
ValueError: Model server error!code=1, error msg is **LLMServer Generate Error, Please CheckErrorInfo.**: Error code: 400 - {'object': 'error', 'message': 'Only Qwen1.5-14B-Chat allowed now, your model gpt-3.5-turbo', 'code': 40301}
I check the source code and not sure if gpt-3.5-turbo is the default LLM for OpenAILLMClient(), is there a way to also use  Qwen1.5-14B-Chat here without causing any error? Or should I change another client to use?

Thank for your help! I was just thinking of setting up a API server may help, and this answer came up. I will try this out and see if it works for this issue, thanks again.

Sorry just tried it out, the embedding model works just fine, but LLM came up with this error:
ValueError: Model server error!code=1, error msg is **LLMServer Generate Error, Please CheckErrorInfo.**: Error code: 400 - {'object': 'error', 'message': 'Only Qwen1.5-14B-Chat allowed now, your model gpt-3.5-turbo', 'code': 40301}
I check the source code and not sure if gpt-3.5-turbo is the default LLM for OpenAILLMClient(), is there a way to also use Qwen1.5-14B-Chat here without causing any error? Or should I change another client to use?

Please provide some code or trace logs.

Please provide some code or trace logs.

Sure, here is the code with error.

This is the full log for this error.
`/home/feida/anaconda3/envs/DBGPT/lib/python3.10/site-packages/pydantic/_internal/fields.py:160: UserWarning: Field "model_name" has conflict with protected namespace "model".
You may be able to resolve this warning by setting model_config['protected_namespaces'] = ().
warnings.warn(
[Chunk(content='user(id, name, age)', metadata={'source': 'database'}, chunk_id='6ca35ceb-acc9-4dd0-a730-34cfcfd1f7de', score=0.0, summary='', separator='\n')]
Traceback (most recent call last):
File "/storage/DBGPT/DB-GPT/examples/sdk/chat_data_with_awel.py", line 278, in
final_result = asyncio.run(
File "/home/feida/anaconda3/envs/DBGPT/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/home/feida/anaconda3/envs/DBGPT/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
return future.result()
File "/storage/DBGPT/DB-GPT/dbgpt/core/awel/operators/base.py", line 218, in call
out_ctx = await self._runner.execute_workflow(
File "/storage/DBGPT/DB-GPT/dbgpt/core/awel/runner/local_runner.py", line 92, in execute_workflow
await self._execute_node(
File "/storage/DBGPT/DB-GPT/dbgpt/core/awel/runner/local_runner.py", line 121, in _execute_node
await self._execute_node(
File "/storage/DBGPT/DB-GPT/dbgpt/core/awel/runner/local_runner.py", line 121, in _execute_node
await self._execute_node(
File "/storage/DBGPT/DB-GPT/dbgpt/core/awel/runner/local_runner.py", line 121, in _execute_node
await self._execute_node(
[Previous line repeated 3 more times]
File "/storage/DBGPT/DB-GPT/dbgpt/core/awel/runner/local_runner.py", line 177, in _execute_node
raise e
File "/storage/DBGPT/DB-GPT/dbgpt/core/awel/runner/local_runner.py", line 160, in _execute_node
await node._run(dag_ctx, task_ctx.log_id)
File "/storage/DBGPT/DB-GPT/dbgpt/core/awel/operators/base.py", line 186, in _run
return await self._do_run(dag_ctx)
File "/storage/DBGPT/DB-GPT/dbgpt/core/awel/operators/common_operator.py", line 162, in _do_run
input_ctx: InputContext = await curr_task_ctx.task_input.map(map_function)
File "/storage/DBGPT/DB-GPT/dbgpt/core/awel/task/task_impl.py", line 538, in map
new_outputs, results = await self._apply_func(map_func)
File "/storage/DBGPT/DB-GPT/dbgpt/core/awel/task/task_impl.py", line 533, in _apply_func
results = await asyncio.gather(*map_tasks)
File "/storage/DBGPT/DB-GPT/dbgpt/core/awel/task/task_impl.py", line 126, in map
out = await self._apply_func(map_func)
File "/storage/DBGPT/DB-GPT/dbgpt/core/awel/task/task_impl.py", line 112, in _apply_func
out = await func(self._data)
File "/storage/DBGPT/DB-GPT/dbgpt/core/interface/output_parser.py", line 274, in map
return self.parse_model_nostream_resp(input_value, "###")
File "/storage/DBGPT/DB-GPT/dbgpt/core/interface/output_parser.py", line 302, in parse_model_nostream_resp
model_out_text = super().parse_model_nostream_resp(response, sep)
File "/storage/DBGPT/DB-GPT/dbgpt/core/interface/output_parser.py", line 138, in parse_model_nostream_resp
raise ValueError(
ValueError: Model server error!code=1, error msg is LLMServer Generate Error, Please CheckErrorInfo.: Error code: 400 - {'object': 'error', 'message': 'Only Qwen1.5-14B-Chat allowed now, your model gpt-3.5-turbo', 'code': 40301}
`

This issue happened when I try to run "Write Your Own Chat Data With AWEL" tutorial locally:
https://docs.dbgpt.site/docs/latest/awel/cookbook/write_your_chat_database

Fixed it, just need to modify the model config here to local model. Thanks for looking into it！


Avoid reusing filters from previous requests on the same client connection

This is a fix for issue #277.

Verified the fix. Works fine.

Sorry, I disagree to @MediumOne . At this point you never can't return a non operational FiltersSourceAdapter, I think. Only the implementation can decide what kind of filter has to be used.

@ganskef: The FiltersSourceAdapter is operational, the problem is that we are not resetting the currentFilters when reusing the ClientToProxyConnection. This causes filters from previous requests to the same server to be used on this request, even when the FiltersSourceAdapter returns null (indicating there should not be any filtering for this request).
@angiarao gives a pretty good explanation of the problem in #277 .

@jekh I've no concerns anymore. Now I've seen the new FiltersSourceAdapter(null) is a reset to the initial value. It's stateless and used twice, maybe it could be a constant.
@angiarao Thank you for this catch, and sorry for confusion.

It's stateless and used twice, maybe it could be a constant.

@ganskef - good point! I've extracted it into a static final in HttpFiltersAdapter. If that looks good to you, I'll go ahead and merge.

I would prefer why before what in naming like INITIAL_STATE, but no veto. Please merge.


Removing unused code

Removing several pieces of unused code.
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)

@arschles can you please update this branch with master so it can be merged? :D


Profile MRC Code

aferritto created the following on Apr 01:
Profile MRC Code to look for speedup opportunities.
Some potential ideas before looking:
Extractive Postprocessor:

replace argsort with argpartition
replace sorted(){slice] with heapq.topk

Original issue: https://github.ibm.com/ai-foundation/PrimeQA/issues/84

@bhavani105 : please update the status and the pipeline label for this issue

This will be done as part of creating primeqa services


Fix dynamic lib path patch so it doesn't fail in certain cases.

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

I stumbled upon an issue where the dynamic lib path patch was not working, and I tracked it down to an extra "./" appearing in the discovered path for libuhd that resulted in the path manipulation to get the package path to fail. This would happen when libuhd was loaded through, e.g. GNU Radio, but not when loaded through UHD's own tools like uhd_config_info. The updated patch does path normalization of the libuhd path before anything else so that path manipulation is more reliable.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


CMake GLOB source files: CMake Tools' is unable to provide IntelliSense configuration information

CMake GLOB source files: CMake Tools' is unable to provide IntelliSense configuration information
Use FILE (GLOB ) to collect C++ source files, instead of manually adding everyone of them. CMake tools cannot provide IntelliSense configuration information on new created .hpp or .cpp files.
Expected:

CMakeLists.txt with following partial definitionfile (GLOB SRC_FILES
    ${PROJECT_SOURCE_DIR}/*.h
    ${PROJECT_SOURCE_DIR}/**/*.h
    ${PROJECT_SOURCE_DIR}/*.hpp
    ${PROJECT_SOURCE_DIR}/**/*.hpp
    ${PROJECT_SOURCE_DIR}/*.c
    ${PROJECT_SOURCE_DIR}/**/*.c
    ${PROJECT_SOURCE_DIR}/*.cpp
    ${PROJECT_SOURCE_DIR}/**/*.cpp
)
add_executable(${PROJECT_NAME} ${SRC_FILES})

Create new .hpp or .cpp file under projects.
C/C++ extension call CMake Tools to generate intellisense configuration information, and CMake Tools runs CMake: Configure to update compile_commands.json file.

Apparent Behavior:

CMakeLists.txt with following partial definitionfile (GLOB SRC_FILES
    ${PROJECT_SOURCE_DIR}/*.h
    ${PROJECT_SOURCE_DIR}/**/*.h
    ${PROJECT_SOURCE_DIR}/*.hpp
    ${PROJECT_SOURCE_DIR}/**/*.hpp
    ${PROJECT_SOURCE_DIR}/*.c
    ${PROJECT_SOURCE_DIR}/**/*.c
    ${PROJECT_SOURCE_DIR}/*.cpp
    ${PROJECT_SOURCE_DIR}/**/*.cpp
)
add_executable(${PROJECT_NAME} ${SRC_FILES})

Create new .hpp or .cpp file under projects.
C/C++ extension reports 'CMake Tools' is unable to provide IntelliSense configuration information
Have to manully run CMake: Configure command to fix this issue.

CMake Tools Log

Developer Tools Log

workbench.main.js:sourcemap:240 [Extension Host] provideCustomConfiguration
workbench.main.js:sourcemap:240 [Extension Host] failed to provide configuration

Platform and Versions

Operating System: Ubuntu 18.04.2 LTS
CMake Version: 3.14.5
VSCode Version: 1.36.1
CMake Tools Extension Version: 1.1.3
Compiler/Toolchain: GCC 7.4.0

Other Notes/Information
C/C++ Extension Version: 0.24.1

The necessity to reconfigure CMake when using file(GLOB is a known limitation of CMake itself (and not the CMake Tools extension).
Therefor it's recommended to not use GLOB, but hardcode file names.
See also:
https://stackoverflow.com/questions/32411963/why-is-cmake-file-glob-evil/32412044
https://stackoverflow.com/questions/1027247/is-it-better-to-specify-source-files-with-glob-or-each-file-individually-in-cmak/1060061#1060061

You can use the CONFIGURE_DEPENDS option and it will do what you want:
# GLOB_RECURSE also simplifies your glob expressions
file (GLOB_RECURSE SRC_FILES CONFIGURE_DEPENDS
    ${PROJECT_SOURCE_DIR}/*.h
    ${PROJECT_SOURCE_DIR}/*.hpp
    ${PROJECT_SOURCE_DIR}/*.c
    ${PROJECT_SOURCE_DIR}/*.cpp
    # Alternative: *.[hc] and *.[hc]pp
)
add_executable(${PROJECT_NAME} ${SRC_FILES})

CONFIGURE_DEPENDS will cause CMake to reconfigure if the glob result changes. There are disadvantages to it (I've heard that it can cause issues when merging branches, and not all generators support it), but IMO it's worth using.

Thank you for the question. Based on the discussion above, we do not plan to implement this support at this time.  If we receive more votes on this request, we can revisit the decision.


feat: add persistent 2d viewer properties

Made 2 quality of life changes for the 2d demo viewer:
In the first commit I added a new redux reducer to save the focused player & speed states. This makes it so those properties do not need to be reset every time a new round loads. The saved values are cleared when a new match is opened.
In the second commit I flipped the direction of the speed slider so that pulling it up increases the value. This is a more standard user experience for sliders.
Old Behavior:

New Behavior:

Nice!
I plan (it's an old bullet point on my todo list) to move the 2D settings into the global app settings to have them restored when the app is launched and add more options (hide/show chickens for example).
Would you like to try to move the 2D settings into the global settings?
No problem if you can't, I will merge this PR as it's a nice improvement 👍

Would you like to try to move the 2D settings into the global settings?

I can give it a shot, however I think the 2 settings I've worked on so far (speed and focused player) should probably remain as session specific and wouldn't belong in a global menu.
To start I'll try implementing the following global 2D viewer settings:

Hide/show Chickens
Round end behavior

Load next round (paused) - Default
Load next round (autoplay)
Loop current round
Pause current round

Thank you!


UML-774 - Updated title copy

Purpose
Title copy update
Fixes UML-774
Checklist

[ ] I have performed a self-review of my own code
[ ] I have added relevant logging with appropriate levels to my code
[ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
[ ] I have added tests to prove my work
[ ] The product team have tested these changes

Coverage remained the same at 81.132% when pulling 36cf27c442143ba9638169fe8b61e808af481665 on UML-774-update-dashboard-title into 0097147c073dd89e4627ca09e656d136381be60f on master.


Update manifest to follow distributed more closely

Codecov Report

Merging #16 (bd79227) into main (5f13223) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   79.42%   79.42%
=======================================
  Files           9        9
  Lines         345      345
=======================================
  Hits          274      274
  Misses         71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f13223...bd79227. Read the comment docs.


Fix ShardedStateLoader for vllm fp8 quantization

FILL IN THE PR DESCRIPTION HERE
FIX #xxxx (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

/ready

@mgoin the steps to reproduce the issue is:

Use https://github.com/neuralmagic/AutoFP8 to prequantize the model and save it to /model/quantized;
Use below command to shard the model and save it

python vllm/examples/save_sharded_state.py \
--trust-remote-code \
--model /models/quantized \
--tensor-parallel-size 8 \
--output /models/sharded

Load the model from /models/sharded, and it will complain a few tensors' misshape.

@sfc-gh-zhwang do you mind sharing the model you used as well?

@dsikka i think this is reproducible with any model - i am using llama3-70b-instruct in particular.

Verified the issue is present on main and fixed with this PR using:
huggingface-cli download neuralmagic/Meta-Llama-3-8B-Instruct-FP8 --local-dir Meta-Llama-3-8B-Instruct-FP8

python examples/save_sharded_state.py --model Meta-Llama-3-8B-Instruct-FP8 --tensor-parallel-size 2 --output Meta-Llama-3-8B-Instruct-FP8-SHARDED

vllm serve Meta-Llama-3-8B-Instruct-FP8-SHARDED --tensor-parallel-size 2 --load-format sharded_state

Through this testing I found that the CLI --load-format argument choices need to be updated, so I made https://github.com/vllm-project/vllm/pull/7784 to correct this. Thank you @sfc-gh-zhwang for the fix!!


Fix code analysis warnings

Fix code analysis issues/warnings found while developing #48.

Pass exception through to LogError().
Add calls to `ConfigureAwait(false).
Add missing XML documentation.
Suppress CA1032 on SSMParameterToLongException (sic).
Suppress CA1031.
Remove redundant assignment and namespace.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for the cleanup effort @martincostello


FIX warn if benchopt version in env differ from running one

closes #416

Codecov Report

Merging #419 (cbaaee7) into main (899967d) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
- Coverage   53.99%   53.98%   -0.01%
==========================================
  Files          44       44
  Lines        2667     2671       +4
  Branches      506      507       +1
==========================================
+ Hits         1440     1442       +2
- Misses       1120     1121       +1
- Partials      107      108       +1


Dev salvian dark mode

This PR add button in navbar that can change to dark mode using inverted filter CSS
resolve #6124. This PR is a continuation of #7155.

Hi @Gby56 @Maffooch @mtesauro, this is my new PR. Please review it. Thanks.

Hi everyone, sorry for the delay. This PR is hard to accept, because we offer this feature in the commercial version of DefectDojo. In our contributing guidelines, we do recommend reaching out for new features so that people don’t waste effort. I am very open to your feedback on how we can handle this better as I truly don’t want to discourage any member of our community, but the commercial version is what makes the OS version possible.
Please let me know your thoughts and feedback.

Hello,
I've been thinking about that feature for a while and couldn't explain to myself how it was not already in the community DefectDojo... now I know haha
I really think these kinds of features are nowadays a bare minimum for accessibility and quality of life improvements, sorry if I'm being a bit blunt... I don't think this should be a commercial-grade feature tbh.
To be fair, the PR is only setting the mode client side and not saving that in user preferences so it's a tiny bit less "fancy", but not by much.

FWIW, I don' t really think this is PR-worthy, especially when the UI could use a general overhaul and I'd prefer to spend time on that over adding dark mode to the existing UI.
<matt's 2 cents>
I use this extension to 'dark-ify' many sites that don't include a dark mode and it has generally worked great for me.  TBH, that's a primary reason why I'd not work on a dark mode for DefectDojo's current UI.
https://chrome.google.com/webstore/detail/dark-mode/dmghijelimhndkbmpgbldicpogfkceaj/related
Here's what the demo site looks like:

If that one doesn't work well for you, there's loads of dark mode plugins to try.
<\matt's 2 cents>

I don't see it as an accessibility feature, but I do see it as quality of life feature. Both when we open sourced Dojo and now, our goal is for Dojo to be a force for good to make security easier and accessible to all. The app, the algorithms, and even the integrations (SSO, JIRA, etc.) all open sourced. We appreciate all contributions and the community that's developed around Dojo. The tool wouldn't be where it is today without the Dojo Community. @Gby56, you have submitted some phenomenal PRs and I truly appreciate your involvement. We've tried to be very careful to make sure there aren't any barriers to a person or organization achieving their goals with the open source version. Where we think it makes sense to draw the line is quality-of-life features and out-of-the-box automation because these features aren't essential for achieving one's goals with Dojo, but provide a means to sustain and improve the platform for both open source and commercial users.

I understand your point of view much better, I had the impression that the paid DefectDojo's version was mainly attractive for customers because of the support and the deployment / maintenance taken care of, and also supporting the community, which is also an attractive choice.
But also, now that I think about it, this is a tool that handles sensitive data, and therefore, it will be deployed on-prem most of the time.
This makes it difficult to have a sustainable commercial version, and the licensed on-prem version is the best way to satisfy customer requirements, if they can't be in someone else's cloud.
So, the fine line between a community and a commercial on-prem version is super hard to navigate, because on-prem is the most used deployment model, both having the burden of running and maintenance of the system.
Therefore you really need to at least convince with features, or a cheap licensing that would mostly say "to support the project".


blue border for button or input and so on

I found that buttons or inputs on chrome have a blue border, I use edge to see the demo page again. there is no blue border for buttons.

Was this issue resolved? I haven't had a chance to test on Edge yet.

I think it is the default focus style for some browsers. So, but I still think it is better to remove it.
.button: {
    outline: none
}

You should never remove outline without replacing it with another visual affordance.

@jxnblk this issue still persists only in chrome. What's the best way to fix it?


Does not fetch automatically - Errors in Event log

I found two errors in Windows Event Viewer:
Faulting application name: RepoZ.exe, version: <IP_ADDRESS>, time stamp: 0x5e35ee72
Faulting module name: KERNELBASE.dll, version: 10.0.18362.239, time stamp: 0xe665f337
Exception code: 0xe0434352
Fault offset: 0x00113442
Faulting process id: 0x4834
Faulting application start time: 0x01d5ed9a31aa8522
Faulting application path: C:\Program Files\RepoZ\RepoZ.exe
Faulting module path: C:\WINDOWS\System32\KERNELBASE.dll
Report Id: 75f7f6ea-2d29-44ac-9944-c9596a001d65
Faulting package full name:
Faulting package-relative application ID:
Application: RepoZ.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.IO.PathTooLongException
at System.IO.Path.LegacyNormalizePath(System.String, Boolean, Int32, Boolean)
at System.IO.Path.NormalizePath(System.String, Boolean, Int32, Boolean)
at System.IO.Path.GetPathRoot(System.String)
at System.IO.RenamedEventArgs.get_OldFullPath()
at RepoZ.Api.Common.Git.DefaultRepositoryDetector._watcher_Renamed(System.Object, System.IO.RenamedEventArgs)
at System.IO.FileSystemWatcher.OnRenamed(System.IO.RenamedEventArgs)
at System.IO.FileSystemWatcher.NotifyRenameEventArgs(System.IO.WatcherChangeTypes, System.String, System.String)
at System.IO.FileSystemWatcher.CompletionStatusChanged(UInt32, UInt32, System.Threading.NativeOverlapped*)
at System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32, UInt32, System.Threading.NativeOverlapped*)
Notes:
Maximum length of the path of my local repos is: K:\XXXXXX70_Projects_Other\CBS_TafficManager
Remotes are on Microsoft DevOps: https://devops.xxxxxxxxx.it/x70_collection/RnD_Products/_git/DataCollector

Closing this because of inactivity.


How to use usersSpaceUsage function

I want to get the individual space usage using this function.
In the documentation, it is shown to set the .tag to 'individual'.
I don't know what to do after this.

You can call usersGetSpaceUsage like this to get the account's space usage and check the allocation type:
dbx.usersGetSpaceUsage()
  .then(function(response) {
    console.log("The usage for the account is: " + response.used + " bytes.");
    if (response.allocation[".tag"] == "team") {
      console.log("The user has a team allocation: " + response.allocation.allocated);
    } else if (response.allocation[".tag"] == "individual") {
      console.log("The user has an individual allocation: " + response.allocation.allocated);
    } else {
      console.log("Unknown allocation type.")
    }
  })
  .catch(function(error) {
    console.log(error);
  });

You can find the documentation for the all of the information in UsersSpaceUsage here.


Take up a lot of CPU   rp.exe

VSCode Version: 1.17
OS Version:    windows 15063.608

CPU: i5-4460 3.20GHz
RAM: 8G
Steps to Reproduce:

打开项目

打开一个.js文件

打开任务管理器：rg.exe  占用大量CPU

Reproduces without extensions: Yes/No

You can open the project
https://github.com/zoeDylan/zoeDylan.github.io

是的，把三个进程杀掉然后把最高占cpu的那个vscode也杀了就回到正常了。准备回退版本，等更新。

我更新成最新的版本后也出现了这个问题，杀进程没有用，每次打开一个新窗口照样弹出这些进程。已经向官方提出来了，希望早点解决吧。

hi @zoeDylan  do you get the ms-vscode.csharp extension installed?
Maybe Duplicate of #35659

@newbienewbie   yes, But it's already uninstalled. Still not solve the problem

@zoeDylan I don't know the reason.
I can't even reproduce the bug on the desktop computer in my office (win7 x64 ; CPU i7-4790 3.60GHz ; RAM 8.00GB) .  With CSharp extension installed , the rg.exe only takes up about 20% CPU usage.
On my personal Surface Pro3 , however , openning a npm package containing a node_modules subfolder  will cause the usage of CPU growing quickly up to 100% and last for about one or two minutes . If I disable the csharp extension , the rg.exe will only live about 8 seconds and then exit . At last the CPU usage will fall back to a normal level.

My friend also appeared the same problem，I temporarily use 'sublime  text', waiting for repair。

Thanks. Could you run the following command in Powershell from your workspace folder and let me know what the output is?
(Measure-Command { & 'C:\Program Files\Microsoft VS Code\resources\app\node_modules\vscode-ripgrep\bin\rg.exe' --files --no-ignore --follow --hidden -- . | Measure-Object –Line | O
ut-Default }).TotalSeconds

Also, what is the output of the following when run in Powershell while the rg.exe are running?
(Get-WmiObject Win32_Process -Filter "name = 'rg.exe'").CommandLine

@chrmarti   I can find the reason,
I run this command

But I have a lot of 'node_modules'.  so,

rg. exe spent a lot of time to cycle
at  vsCode

When  rg.exe himself ended, everything is all right
@newbienewbie  Thanks,I think I found the problem.
English is not good, forgive me。
@linxiangjun @zhoudailincser  目前测试出来的是，npm包过多,导致rg.exe一直在循环查找npm包,所以很卡，rg.exe跑结束后就正常了。

@zoeDylan  Maybe the real reason is symlink , dependencies or sth else insead of too much npm subpackages，because the rg.exe complains that File system loop found.

@newbienewbie   YES，I am thinking how to solve, now only let it run over to start work。

@zoeDylan Could you rerun the command without --follow? That will tell us how long it takes when it does not follow symlinks.

@zoeDylan Also: Which version of npm were you using to install the node modules? I'm trying to reproduce the problem.

Marking as duplicate of #35659. Both show loops around es5-ext. Let's continue the discussion there.


Could not find match for ^/w+/W

Evening,
I just tried to run your docker container. It seemed really awesome. However I am getting this error. See below.
During handling of the above exception, another exception occurred: Traceback (most recent call last):   File "/app/grabber.py", line 104, in <module>     scanLibrary()   File "/app/grabber.py", line 29, in scanLibrary     grabMusic(name)   File "/app/grabber.py", line 61, in grabMusic     hiStream = yt.streams.get_audio_only("mp4")   File "/usr/local/lib/python3.9/site-packages/pytube/__main__.py", line 296, in streams     return StreamQuery(self.fmt_streams)   File "/usr/local/lib/python3.9/site-packages/pytube/__main__.py", line 188, in fmt_streams     extract.apply_signature(stream_manifest, self.vid_info, self.js)   File "/usr/local/lib/python3.9/site-packages/pytube/extract.py", line 409, in apply_signature     cipher = Cipher(js=js)   File "/usr/local/lib/python3.9/site-packages/pytube/cipher.py", line 33, in __init__     raise RegexMatchError( pytube.exceptions.RegexMatchError: __init__: could not find match for ^\w+\W

Hey thanks for the feedback!
Can you see in the logs on which tv-show it crashes?

Yes. Star wars rebels. I put a .themeignore file in that directory and than It went to another show, same error. That show is The end of the f*cking world.

Allright, sounds like the YouTube download security is updated again.
I suppose updating the dependencies (pytube) will just fix the issue. I will look into it

Nice. I look forward to using your container.

Seems like another pytube bug: https://github.com/pytube/pytube/issues/1199
Will look into it tomorrow.

Thanks

Moved away from the pytube library.
Fixed in version 1.1.0

Great! The error is gone. I am getting a permission denied error right now. Any ideas?

What kind of error?

I fixed it. I changed folder permissions. It's downloading theme songs right now. Thanks!!!


fix: zookeeper dependency conflict

Codecov Report

Merging #12670 (8bb427c) into 3.2 (02ba6b9) will decrease coverage by 1.77%.
The diff coverage is n/a.

:exclamation: Current head 8bb427c differs from pull request most recent head d6b8a98. Consider uploading reports for the commit d6b8a98 to get more accurate results

@@             Coverage Diff              @@
##                3.2   #12670      +/-   ##
============================================
- Coverage     68.68%   66.91%   -1.77%
+ Complexity      341        2     -339
============================================
  Files          3615     1763    -1852
  Lines        168637    70855   -97782
  Branches      28030    10158   -17872
============================================
- Hits         115820    47414   -68406
+ Misses        42759    18865   -23894
+ Partials      10058     4576    -5482

see 1878 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

What is the purpose?

  <groupId>org.apache.curator</groupId>
  <artifactId>curator-x-discovery</artifactId>

include zookeeper conflict with the pom dubbo-dependencies/dubbo-dependencies-zookeeper-curator5/pom.xml include

What is the purpose?

zookeeper version of
  <groupId>org.apache.curator</groupId>
  <artifactId>curator-x-discovery</artifactId>

conflict with the pom dubbo-dependencies/dubbo-dependencies-zookeeper-curator5/pom.xml include

Maven will use the version defined in dubbo-dependencies/dubbo-dependencies-zookeeper-curator5/pom.xml instead of curator's version due to the shortest path.


Permission tab missing in Firefox

I'm not sure, if this bug but i could not find any related issue here. Permission tab in Firefox (50.0.2) is missing, therefore i can't configure Toggl button for custom domain.

It's not a bug. Currently permissions managements is not supported in Firefox as in Firefox this API is not available. This will be added in the future.

I understand, it would be nice mention this somewhere in Readme or so. Thanks!

What about some quick hack that would allow us to write custom domains in about:config for instance? This is blocking issue for our team (we use Phabricator on our domain). We cannot force people to use Chrome.


Add files via upload

Node id: e4cd9b592e9d064b
Tests done on : Huawei Mate 10 Software version: <IP_ADDRESS>
Test1 account addres : 31E5Ps9p4e4fgzv3rFDsv5xnJDhgdTdoEcRdRtuBCFJH1uS7Lk
Test2 Account address: 3QJcccuUJWbhPrqw4VuXh6VWuTkTPFi4KyiRS46CtYbcnrCdR2

pending:ID1
account1:screenshot-TBC
account2:screenshot-TBC
We cannot fully verify this submission. Please assist us typing out the account addresses for ID1 in full as text in a comment on this PR. Thank you!
@keremyapar

@cryptovoyagr haven't I already, please check:
Node id: e4cd9b592e9d064b
Tests done on : Huawei Mate 10 Software version: <IP_ADDRESS>
Test1 account addres : 31E5Ps9p4e4fgzv3rFDsv5xnJDhgdTdoEcRdRtuBCFJH1uS7Lk
Test2 Account address: 3QJcccuUJWbhPrqw4VuXh6VWuTkTPFi4KyiRS46CtYbcnrCdR2

confirmed:ID1
account1:31E5Ps9p4e4fgzv3rFDsv5xnJDhgdTdoEcRdRtuBCFJH1uS7Lk
account2:3QJcccuUJWbhPrqw4VuXh6VWuTkTPFi4KyiRS46CtYbcnrCdR2

confirmed:ID4
AccountAddress:38h1hricRuKhkGy7oXFhiBTcSieqaiXv27hQHUG8jKrJjvEAtg
DeviceDetails:verified

confirmed:ID4
AccountAddress:38h1hricRuKhkGy7oXFhiBTcSieqaiXv27hQHUG8jKrJjvEAtg
DeviceDetails:verified


Can't create session when the connection is closing

While receiving events using Event Processor Host, from time to time, I'm getting partition receiver exceptions:
System.InvalidOperationException: Can't create session when the connection is closing.    at Microsoft.Azure.Amqp.AmqpConnection.AddSession(AmqpSession session, Nullable1 channel)    at Microsoft.Azure.Amqp.AmqpCbsLink.OpenCbsRequestResponseLinkAsyncResult.GetAsyncSteps()+MoveNext() --- End of stack trace from previous location where exception was thrown ---    at Microsoft.Azure.Amqp.AsyncResult.End[TAsyncResult](IAsyncResult result)    at Microsoft.Azure.Amqp.AmqpCbsLink.EndCreateCbsLink(IAsyncResult result)    at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean requiresSynchronization) --- End of stack trace from previous location where exception was thrown ---    at Microsoft.Azure.Amqp.FaultTolerantAmqpObject1.OnCreateAsync(TimeSpan timeout)    at Microsoft.Azure.Amqp.Singleton1.GetOrCreateAsync(TimeSpan timeout)    at Microsoft.Azure.Amqp.Singleton1.GetOrCreateAsync(TimeSpan timeout)    at Microsoft.Azure.Amqp.TaskHelpers.EndAsyncResult(IAsyncResult asyncResult)    at Microsoft.Azure.Amqp.IteratorAsyncResult1.StepCallback(IAsyncResult result) --- End of stack trace from previous location where exception was thrown ---    at Microsoft.Azure.Amqp.AsyncResult.End[TAsyncResult](IAsyncResult result)    at Microsoft.Azure.Amqp.AmqpCbsLink.<>c__DisplayClass4_0.b__1(IAsyncResult a)    at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean requiresSynchronization) --- End of stack trace from previous location where exception was thrown ---    at Microsoft.Azure.EventHubs.Amqp.AmqpPartitionReceiver.CreateLinkAsync(TimeSpan timeout)    at Microsoft.Azure.Amqp.FaultTolerantAmqpObject1.OnCreateAsync(TimeSpan timeout)    at Microsoft.Azure.Amqp.Singleton1.GetOrCreateAsync(TimeSpan timeout)    at Microsoft.Azure.Amqp.Singleton1.GetOrCreateAsync(TimeSpan timeout)    at Microsoft.Azure.EventHubs.Amqp.AmqpPartitionReceiver.OnReceiveAsync(Int32 maxMessageCount, TimeSpan waitTime)    at Microsoft.Azure.EventHubs.Amqp.AmqpPartitionReceiver.OnReceiveAsync(Int32 maxMessageCount, TimeSpan waitTime)    at Microsoft.Azure.EventHubs.PartitionReceiver.ReceiveAsync(Int32 maxMessageCount, TimeSpan waitTime)    at Microsoft.Azure.EventHubs.Amqp.AmqpPartitionReceiver.ReceivePumpAsync(CancellationToken cancellationToken, Boolean invokeWhenNoEvents)
There is an open issue related to this in azure-amqp sdk github repo https://github.com/Azure/azure-amqp/issues/140), but one of the team members is suggesting that:

This exception is expected when a session is to be created but the connection is closing. Typically the session creation is a result of an API call from the upper SDK and should be handled by the SDK as a communication error. Please report the error to the SDKs you are using so it can be handled correctly by the retry policy in the SDKs.

So sorry that I missed to notice this issue. Is it still happening? If so, how often are you seeing the failures? Can you also check your code that you are not unregistering host at some place. Receivers are only closed during unregister call.

I had the same error last night happening in multiple microservices running in k8s.
Two errors to be precise:
fail: ConfirmService[0]
      Message handler encountered an exception.Exception context for troubleshooting:
      - Endpoint: some-app-test.servicebus.windows.net
      - Entity Path: test-confirm
      - Executing Action: Receive

System.InvalidOperationException: Can't create session when the connection is closing.
   at Microsoft.Azure.ServiceBus.Core.MessageReceiver.OnReceiveAsync(Int32 maxMessageCount, TimeSpan serverWaitTime)
   at Microsoft.Azure.ServiceBus.Core.MessageReceiver.<>c__DisplayClass64_0.<<ReceiveAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.Azure.ServiceBus.RetryPolicy.RunOperation(Func`1 operation, TimeSpan operationTimeout)
   at Microsoft.Azure.ServiceBus.RetryPolicy.RunOperation(Func`1 operation, TimeSpan operationTimeout)
   at Microsoft.Azure.ServiceBus.Core.MessageReceiver.ReceiveAsync(Int32 maxMessageCount, TimeSpan operationTimeout)
   at Microsoft.Azure.ServiceBus.Core.MessageReceiver.ReceiveAsync(TimeSpan operationTimeout)
   at Microsoft.Azure.ServiceBus.MessageReceivePump.<MessagePumpTaskAsync>b__11_0()

And:
fail: CacheInvalidateHostedService[0]
      Message handler encountered an exception.Exception context for troubleshooting:
      - Endpoint: some-app-test.servicebus.windows.net
      - Entity Path: test-cache-invalidate/Subscriptions/CacheInvalidateHostedService
      - Executing Action: Receive

System.ObjectDisposedException: Cannot access a disposed object.
Object name: '$cbs'.
   at Microsoft.Azure.ServiceBus.Core.MessageReceiver.OnReceiveAsync(Int32 maxMessageCount, TimeSpan serverWaitTime)
   at Microsoft.Azure.ServiceBus.Core.MessageReceiver.<>c__DisplayClass64_0.<<ReceiveAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.Azure.ServiceBus.RetryPolicy.RunOperation(Func`1 operation, TimeSpan operationTimeout)
   at Microsoft.Azure.ServiceBus.RetryPolicy.RunOperation(Func`1 operation, TimeSpan operationTimeout)
   at Microsoft.Azure.ServiceBus.Core.MessageReceiver.ReceiveAsync(Int32 maxMessageCount, TimeSpan operationTimeout)
   at Microsoft.Azure.ServiceBus.Core.MessageReceiver.ReceiveAsync(TimeSpan operationTimeout)
   at Microsoft.Azure.ServiceBus.MessageReceivePump.<MessagePumpTaskAsync>b__11_0()

They happened from 5:00 AM to 7:30 AM.
Been working with the service bus for a few days, so I can't tell if this is happening all of a sudden or will happen every week for example.

So sorry that I missed to notice this issue. Is it still happening? If so, how often are you seeing the failures? Can you also check your code that you are not unregistering host at some place. Receivers are only closed during unregister call.

No I'm not unregistering a host in any place of the code.
It's happeing very rarely, I haven't seen this error since I reported this issue.

We experienced the same issue from time to time.
Microsoft.Azure.EventHubs.ServiceFabricProcessor, Version=<IP_ADDRESS>, Microsoft.Azure.EventHubs.ServiceFabricProcessor.ServiceFabricProcessor+d__32.MoveNext - Can't create session when the connection is closing.
Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Microsoft.Azure.Amqp.AmqpConnection.AddSession - Can't create session when the connection is closing.

Thank you @serkantkaraca for the feedback. I am sure option 1 is not my case.

We observed the same exception on multiple IoTHub connections between 2020-02-20T01:36:54 UTC and 2020-02-20T01:56:55 UTC all instances of IoT Hub run in the EU West region.
Multiple but not all partitions of the same IoT Hub are affected.

IoTHub A

Partition 0 failed at 1:44:54 UTC
Partition 1 failed at 1:56:55 UTC
Partition 2 ok
Partition 3 ok

IoTHub B

Partition 0 failed at 1:52:51 UTC
Partition 1 failed at 1:40:49 UTC
Partition 2 ok
Partition 3 failed at 1:48:52 UTC

IoTHub C

Partition 0 ok
Partition 1 failed at 1:44:54 UTC
Partition 2 ok
Partition 3 failed at 1:36:54 UTC

There was no shutdown request for the services at that time, even so i would expect that if we handle the cancellation token in the EventProcessor class,  that the SDK should gracefully handle option 1 mentioned by @serkantkaraca. We only receive events on this way and do not use any other receive or send mechanism in parallel.
Following package versions are used:
Microsoft.Azure.EventHubs.ServiceFabricProcessor 0.5.4
which uses
Microsoft.Azure.EventHubs 4.1.0
were we think the error should be handled.
Exception Stacktrace:
System.InvalidOperationException: Can't create session when the connection is closing.
   at Microsoft.Azure.Amqp.AmqpConnection.AddSession (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at Microsoft.Azure.Amqp.AmqpCbsLink+OpenCbsRequestResponseLinkAsyncResult+<GetAsyncSteps>d__7.MoveNext (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.Amqp.AsyncResult.End (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at Microsoft.Azure.Amqp.AmqpCbsLink.EndCreateCbsLink (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Threading.Tasks.TaskFactory`1.FromAsyncCoreLogic (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.Amqp.FaultTolerantAmqpObject`1+<OnCreateAsync>d__6.MoveNext (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.Amqp.Singleton`1+<GetOrCreateAsync>d__13.MoveNext (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.Amqp.Singleton`1+<GetOrCreateAsync>d__13.MoveNext (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.Amqp.TaskHelpers.EndAsyncResult (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at Microsoft.Azure.Amqp.IteratorAsyncResult`1.StepCallback (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.Amqp.AsyncResult.End (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at Microsoft.Azure.Amqp.AmqpCbsLink+<>c__DisplayClass4_0.<SendTokenAsync>b__1 (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Threading.Tasks.TaskFactory`1.FromAsyncCoreLogic (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.EventHubs.Amqp.AmqpPartitionReceiver+<CreateLinkAsync>d__15.MoveNext (Microsoft.Azure.EventHubs, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7e34167dcc6d6d8c)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.Amqp.FaultTolerantAmqpObject`1+<OnCreateAsync>d__6.MoveNext (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.Amqp.Singleton`1+<GetOrCreateAsync>d__13.MoveNext (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.Amqp.Singleton`1+<GetOrCreateAsync>d__13.MoveNext (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.EventHubs.Amqp.AmqpPartitionReceiver+<OnReceiveAsync>d__13.MoveNext (Microsoft.Azure.EventHubs, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7e34167dcc6d6d8c)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.EventHubs.Amqp.AmqpPartitionReceiver+<OnReceiveAsync>d__13.MoveNext (Microsoft.Azure.EventHubs, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7e34167dcc6d6d8c)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.EventHubs.PartitionReceiver+<ReceiveAsync>d__30.MoveNext (Microsoft.Azure.EventHubs, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7e34167dcc6d6d8c)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.EventHubs.Amqp.AmqpPartitionReceiver+<ReceivePumpAsync>d__18.MoveNext (Microsoft.Azure.EventHubs, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7e34167dcc6d6d8c)

I hope this information helps you solve the issue. We only observed the issue once but it blocked all our production instances as we got no more events from our sensors.

I will improve exception contract to distinguish between case 1 from case 2 as the first step.

any update on this?

The fix didn't make into 4.2.0.
4.2.1 will include it and will be released 3-4 weeks later.

Same problem here in NorthEurope.
Can't create session when the connection is closing at Microsoft.Azure.ServiceBus.Core.MessageReceiver.<OnReceiveAsync>d__86.MoveNext()
on 13th April between 22h15 and 22h50 CET
on 23rd April between 05h20 and 07h25 CET
Microsoft.Azure.ServiceBus 3.3.0
Microsoft.Azure.Management.ServiceBus 2.0.1

Still seeing this from time to time any idea ?

I'm seeing a callstack similar to the original description of this issue.
What seems like is happening in our case is we get a timeout exception which is not unusual since we have some aggressive timeouts, but then the next call on the partition receiver will fail with this error. My hunch is that as the result of the timeout exception, there is some cleanup happening, but it doesn't complete before the exception surfaces to the caller. When the caller then retries, this exception is thrown.
MSFT FTE here. Ping me and I can provide more details. I have a fairly consistent repro in our service.
Here is the abridged version of what I see from my logging breakpoints.
We call ReceiveAsync for Partition ID 20 with PartitionReceiver120 but we don't see this call return return. (there would be a log line after the one below saying the call completed).
Receiving messages... ClientId: "PartitionReceiver120(***,$Default,20)" hash: 403058 ThreadId: 26004

Exception is thrown for Partition ID 20 on thread ID 17120
System.TimeoutException: The operation did not complete within the allocated time 00:00:02.7197845 for object receiver691.
   at Microsoft.Azure.Amqp.AsyncResult.End[TAsyncResult](IAsyncResult result)
   at Microsoft.Azure.Amqp.AmqpObject.OpenAsyncResult.End(IAsyncResult result)
   at Microsoft.Azure.Amqp.AmqpObject.EndOpen(IAsyncResult result)
   at System.Threading.Tasks.TaskFactory`1.FromAsyncCoreLogic(IAsyncResult iar, Func`2 endFunction, Action`1 endAction, Task`1 promise, Boolean requiresSynchronization)
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.Azure.EventHubs.Amqp.AmqpPartitionReceiver.CreateLinkAsync(TimeSpan timeout)
   at Microsoft.Azure.Amqp.FaultTolerantAmqpObject`1.OnCreateAsync(TimeSpan timeout)
   at Microsoft.Azure.Amqp.Singleton`1.GetOrCreateAsync(TimeSpan timeout)
   at Microsoft.Azure.Amqp.Singleton`1.GetOrCreateAsync(TimeSpan timeout)
   at Microsoft.Azure.EventHubs.Amqp.AmqpPartitionReceiver.OnReceiveAsync(Int32 maxMessageCount, TimeSpan waitTime)
   at Microsoft.Azure.EventHubs.Amqp.AmqpPartitionReceiver.OnReceiveAsync(Int32 maxMessageCount, TimeSpan waitTime)
   at Microsoft.Azure.EventHubs.PartitionReceiver.ReceiveAsync(Int32 maxMessageCount, TimeSpan waitTime)

The next time we call into PartitionReceiver120 ReceiveAsync, we get the InvalidOperationException for PartitionReceiver120.
Receiving messages... ClientId: "PartitionReceiver120(***,$Default,20)" hash: 403058 ThreadId: 21748
System.InvalidOperationException: Can't create session when the connection is closing.
   at Microsoft.Azure.Amqp.AmqpConnection.AddSession(AmqpSession session, Nullable`1 channel)
   at Microsoft.Azure.Amqp.AmqpConnection.CreateSession(AmqpSessionSettings sessionSettings)
   at Microsoft.Azure.EventHubs.Amqp.AmqpPartitionReceiver.CreateLinkAsync(TimeSpan timeout)
   at Microsoft.Azure.Amqp.FaultTolerantAmqpObject`1.OnCreateAsync(TimeSpan timeout)
   at Microsoft.Azure.Amqp.Singleton`1.GetOrCreateAsync(TimeSpan timeout)
   at Microsoft.Azure.Amqp.Singleton`1.GetOrCreateAsync(TimeSpan timeout)
   at Microsoft.Azure.EventHubs.Amqp.AmqpPartitionReceiver.OnReceiveAsync(Int32 maxMessageCount, TimeSpan waitTime)
   at Microsoft.Azure.EventHubs.Amqp.AmqpPartitionReceiver.OnReceiveAsync(Int32 maxMessageCount, TimeSpan waitTime)
   at Microsoft.Azure.EventHubs.PartitionReceiver.ReceiveAsync(Int32 maxMessageCount, TimeSpan waitTime)

This seems to happen consistently for any PartitionReceiver that gets a timeout exception.
Hope this helps. Again, feel free to ping me for more details.

PR under review. Please reactivate if you still hit the issue with 4.3.0 release. https://github.com/Azure/azure-sdk-for-net/pull/14030

@serkantkaraca
I still facing this issue when our API in high load
Failed to send event due to System.InvalidOperationException. Details: Can't create session when the connection is closing..    at Microsoft.Azure.Amqp.AmqpConnection.AddSession(AmqpSession session, Nullable`1 channel)
   at Microsoft.Azure.Amqp.AmqpConnection.CreateSession(AmqpSessionSettings sessionSettings)
   at Microsoft.Azure.EventHubs.Amqp.AmqpEventDataSender.CreateLinkAsync(TimeSpan timeout)
   at Microsoft.Azure.Amqp.FaultTolerantAmqpObject`1.OnCreateAsync(TimeSpan timeout)
   at Microsoft.Azure.Amqp.Singleton`1.GetOrCreateAsync(TimeSpan timeout)
   at Microsoft.Azure.Amqp.Singleton`1.GetOrCreateAsync(TimeSpan timeout)
   at Microsoft.Azure.EventHubs.Amqp.AmqpEventDataSender.OnSendAsync(IEnumerable`1 eventDatas, String partitionKey)
   at Microsoft.Azure.EventHubs.Amqp.AmqpEventDataSender.OnSendAsync(IEnumerable`1 eventDatas, String partitionKey)
   at Microsoft.Azure.EventHubs.EventDataSender.SendAsync(IEnumerable`1 eventDatas, String partitionKey)
   at Microsoft.Azure.EventHubs.EventHubClient.SendAsync(IEnumerable`1 eventDatas, String partitionKey)

Fix was to handle error cases better when client is closed. If you are still getting this failure with 4.3.0 repeatedly, then apparently underlying network channel is failing. Two questions:

How often do you see the failures with 4.3.0?
Does it recover on its own?

Hello @serkantkaraca

From what I see, the frequent will base on the load in our API. Currently, we have an api that received the request and enqueues it to event hub
I don't think it can recover when this exception throws for that specific event when enqueue. In addition, currently, we only implement retry logic for EventHubsException and this exception will throw with InvalidOperationException so that event will be lost. For us, in this case, it will be a critical issue because we don't want to lose any customer data. That's why I ask should I also implement retry logic for this or should I ignore it when it happens

https://github.com/Azure/azure-sdk-for-net/issues/15514#issuecomment-700409400

You won't lose any data as long as you retry. This should be a transient failure and should recover if retried.
Are you able to build a standalone repro like a console app that you can share? If we can reproduce the failures in a controlled manned, things will get easier to pinpoint the root cause.

As I said currently in our API we only implement retry logic for EventHubsException and not InvalidOperationException
Do you suggest us also retry when that exception InvalidOperationException occurs?
I could try to reproduce it using a console application then but of course, it will require some time to do

try
    {
        await _queueSender.SendAsync(eventData, partitionKey);
    }
    catch (EventHubsException ex)
    {
        if (ex.IsTransient)
        {
            throw ex;
        }
        else
        {
            _logger.LogError($"MessagingException occured but is not transient.{ex.Message}");
            return;
        }
    }
    catch (Exception ex)
    {
        if (ex is TimeoutException || ex is UnauthorizedAccessException)
        {
            throw ex;
        }
        else
        {
            var trace = string.IsNullOrEmpty(ex.StackTrace) ? "No stack trace" : ex.StackTrace;
            _logger.LogError($"Failed to send event due to {ex.GetType()}. Details: {ex.Message}. {trace}");
            return;
        }
    }

@serkantkaraca here is our code path that enqueues events to event hub

From my perspective, it will be better if you could throw EventHubsException rather than InvalidOperationException in this case. Please add more information if I miss-understand about any things

I will find out if that is possible.

Great thanks then I will implement retry for that specific error msg as a workaround for now
Please notify me if there is any new information

Any updates on the results? How did change work?

You are right, the client's behavior doesn't match the MS document because in this case InvalidOperationException is client side generated. Service side generated InvalidOperationExceptions are not retry-able. Unfortunately, this exception alone doesn't tell where exception is generated, so this is becoming a challenging issue. I still want to fix the API experience so I will send a PR to convert "cannot create a session" into a retry-able error.
Do you see errors are recovering after retry?

Yes, I can see the error recover after retry

I have sent a PR to convert this exception to retriable error.

Great thanks

Hi, I am having this issue as well, we are using Microsoft.Azure.EventHubs.Processor version 4.3.0.
Which version is that PR (https://github.com/Azure/azure-sdk-for-net/pull/15984#issue-503663997) will be available?

Fix will ship in 4.3.1 release soon.


Fix links due to repo rename

Description
This PR does the following:

Fix links that are broken by the rename of the repo from Samples to Quickstarts
Removes numbering of quickstarts

Issue reference
https://github.com/dapr/quickstarts/issues/280
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[X] The sample code compiles correctly
[X] You've tested new builds of the sample if you changed sample code
[X] You've updated the sample's README if necessary

Needs changes in build.yaml for the build to pass

Needs changes in build.yaml for the build to pass

Thanks! missed that one! just add those changes

Needs changes in this section.

Needs changes in this section.
Edit:
Here as well
functions-and-keda
hello-dapr-slim

Both hello-dapr-slim and functions-and-keda will soon move to a new repo to be named Samples so this will be fixed by that


Added missing airports

All airports have at least one daily commercial service and at least one paved runway.

LGTM many thanks1


Refactor history and create  component

Description of changes
Adds a component structure and responsive styling to the /history page

I did my best to avoid issues - I didn't notice anything 👍


jest-haste-map: watchman crawler: normalize paths

See the inline comment. New versions of Watchman on Window are now returning paths using forward slashes, but consumers of jest-haste-map use to work and assume backslashes would be used (because they rely on path.sep, that is backslash on win32, along the other path functions).
This changeset make it so we path.normalize the paths we read from watchman. On POSIX systems this should not make any difference, but on Window this will have the effect of replacing forward slashes by the usual backslashes.

Can you rebase this?

Codecov Report

Merging #3887 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3887      +/-   ##
==========================================
+ Coverage   58.09%   58.12%   +0.03%
==========================================
  Files         195      196       +1
  Lines        6751     6756       +5
  Branches        6        6
==========================================
+ Hits         3922     3927       +5
  Misses       2826     2826
  Partials        3        3

Impacted Files
Coverage Δ

...kages/jest-haste-map/src/lib/normalize_path_sep.js
100% <100%> (ø)

packages/jest-haste-map/src/index.js
92.8% <100%> (ø)
:arrow_up:

packages/jest-haste-map/src/crawlers/watchman.js
90.74% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8a5135...27c749b. Read the comment docs.

@cpojer when can we see this released in a new npm version?

In my testing of the hack, I had to replace slashes in multiple places, not just the name variable.
In my case, I wasn't even getting to the name part of the code. My details are in https://github.com/facebook/watchman/issues/479#issuecomment-312959124

@patroza do you know which location needs additional transformation of the code? You referred some lines in the comment, but I'm not sure in which file it is. Would you be able to test with the new version of code from this PR, and if it misses some stuff, send a new PR? :)  I have limited ability to reproduce unfortunately because I don't have a Windows machine to test with at the moment.
Thank you so much!

@jeanlauliac posted at https://github.com/facebook/jest/pull/4018


Release Maven packages [DEVOPS-1295]

https://celtra.atlassian.net/browse/DEVOPS-1295

@miharugelj one test is failing: https://github.com/celtra/finagle/actions/runs/6233342981/job/16918402750?pr=5
Is this the issue from the upstream repo or did we break something?

@miharugelj one test is failing: https://github.com/celtra/finagle/actions/runs/6233342981/job/16918402750?pr=5
Is this the issue from the upstream repo or did we break something?

Almost impossible that we broke anything in this PR related to app code.

@miharugelj fyi you will need to allow GHA access to files.celtra.com/maven/ here: https://github.com/celtra/mab-prod-infra/blob/9da55f335452fd8b0542cce534cc9866f595d84a/modules/files_bucket/main.tf#L48

@dejanceltra Looks like release job works.
aws-vault exec <profile> -- aws s3 ls <host>/maven/com/twitter/finagle-http_2.12/22.12.1/
2023-09-21 09:20:30     491308 finagle-http_2.12-22.12.1.jar
2023-09-21 09:20:32         41 finagle-http_2.12-22.12.1.jar.sha1
2023-09-21 09:20:34      13125 finagle-http_2.12-22.12.1.pom
2023-09-21 09:20:36         41 finagle-http_2.12-22.12.1.pom.sha1

@miharugelj Uncomment if and merge.

@dejanceltra Sounds like it is is working
services/ads/bin/build
Launching sbt from /app/build/shared/scala/sbt1/sbt-launch-1.8.0/sbt/bin/sbt-launch.jar
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8 -XX:ErrorFile=/app-var/tmp/java_error_%p.log -Djava.net.preferIPv4Stack=true -Dsun.net.inetaddr.ttl=0 -Dnet.snowflake.jdbc.ocspResponseCacheDir=/app-var/tmp/snowflake -Dnet.snowflake.jdbc.temporaryCredentialCacheDir=/app-var/tmp/snowflake -Dio.netty.native.workdir=/app-var
[info] welcome to sbt 1.8.0 (Ubuntu Java <IP_ADDRESS>)
[info] loading settings for project app-build from build.sbt,plugins.sbt ...
[info] loading project definition from /app/project
[info] loading settings for project root from build.sbt ...
[info] resolving key references (24115 settings) ...
[info] set current project to mab (in build file:/app/)
[info] Updating
https://nexus.celtra.com/repository/maven/com/twitter/finagle-http_2.12/22.12.1/finagle-http_2.12-22.12.1.pom
  100.0% [##########] 12.8 KiB (13.9 KiB / s)
https://nexus.celtra.com/repository/maven/com/twitter/finagle-base-http_2.12/22.12.1/finagle-base-http_2.12-22.12.1.pom
  100.0% [##########] 15.9 KiB (26.4 KiB / s)
https://nexus.celtra.com/repository/maven/com/twitter/finagle-netty4-http_2.12/22.12.1/finagle-netty4-http_2.12-22.12.1.pom
  100.0% [##########] 14.9 KiB (22.5 KiB / s)
https://nexus.celtra.com/repository/maven/com/twitter/finagle-netty4_2.12/22.12.1/finagle-netty4_2.12-22.12.1.pom
  100.0% [##########] 21.7 KiB (52.5 KiB / s)
https://nexus.celtra.com/repository/maven/com/twitter/finagle-core_2.12/22.12.1/finagle-core_2.12-22.12.1.pom
  100.0% [##########] 32.6 KiB (58.9 KiB / s)
https://nexus.celtra.com/repository/maven/io/netty/netty-codec-haproxy/4.1.78.Final/netty-codec-haproxy-4.1.78.Final.pom
  100.0% [##########] 1.8 KiB (4.3 KiB / s)
[info] Resolved  dependencies
[info] Fetching artifacts of
https://nexus.celtra.com/repository/maven/io/netty/netty-codec-haproxy/4.1.78.Final/netty-codec-haproxy-4.1.78.Final.jar
  100.0% [##########] 35.3 KiB (72.3 KiB / s)
https://nexus.celtra.com/repository/maven/com/twitter/finagle-netty4-http_2.12/22.12.1/finagle-netty4-http_2.12-22.12.1.jar
  100.0% [##########] 80.2 KiB (99.3 KiB / s)
https://nexus.celtra.com/repository/maven/com/twitter/finagle-base-http_2.12/22.12.1/finagle-base-http_2.12-22.12.1.jar
  100.0% [##########] 538.4 KiB (594.2 KiB / s)
https://nexus.celtra.com/repository/maven/com/twitter/finagle-netty4_2.12/22.12.1/finagle-netty4_2.12-22.12.1.jar
  100.0% [##########] 410.9 KiB (392.8 KiB / s)
https://nexus.celtra.com/repository/maven/com/twitter/finagle-core_2.12/22.12.1/finagle-core_2.12-22.12.1.jar
  100.0% [##########] 3.1 MiB (2.8 MiB / s)
https://nexus.celtra.com/repository/maven/com/twitter/finagle-http_2.12/22.12.1/finagle-http_2.12-22.12.1.jar
  100.0% [##########] 479.8 KiB (404.5 KiB / s)
[info] Fetched artifacts of


chore(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/base-ocp-vpc/ibm (source)
module
minor
3.24.2 -> 3.25.0

terraform-ibm-modules/landing-zone-vpc/ibm (source)
module
patch
7.18.1 -> 7.18.2

Release Notes

terraform-ibm-modules/terraform-ibm-base-ocp-vpc (terraform-ibm-modules/base-ocp-vpc/ibm)
v3.25.0
Compare Source
Features

added support to specify the worker node operating system using new input variable operating_system (#436) (cb1b819)

terraform-ibm-modules/terraform-ibm-landing-zone-vpc (terraform-ibm-modules/landing-zone-vpc/ibm)
v7.18.2
Compare Source
Bug Fixes

vpc data lookup (#798) (fe27e6f)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.2.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


OSX support

I have tested in OSX Chrome and just doesn't work.

Hi @luisfgfurtado, I built this extension on OSX. All I have is a MacBook Pro :).
Have you tried restarting chrome after enabling the extension? Are you running any other extensions (they might conflict)? What version of Chrome?
What behaviour are you experiencing?

Hi @jamesandres, actually I reinstall the extension and it's working perfectly now.
I don't know why didn't work before.
Thank you, this extension will be very useful to me. :+1:


adds no image variants

What 🕵 🔍

Adds 4 no_image variants
Removes the old one

Codecov Report

Merging #107 (2e20f1a) into main (656e562) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   47.12%   47.03%   -0.10%
==========================================
  Files          56       56
  Lines        2088     2092       +4
==========================================
  Hits          984      984
- Misses       1104     1108       +4

Impacted Files
Coverage Δ

lib/src/linden/xassets.dart
4.27% <ø> (ø)

lib/src/linden/xcolors.dart
29.55% <0.00%> (-0.77%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 656e562...2e20f1a. Read the comment docs.


CTL0491 missing from wikidata

But it is in NCBI https://www.ncbi.nlm.nih.gov/gene/?term=CTL0491

Also missing: CTL0231B, pL2-04, pL2-05, pL2-03


MaxListenersExceededWarning: Possible EventEmitter memory leak detected

How to reproduce:

3 connected clients
Sending events to all of them
Warning appears at the begining
I have no other EventEmitter in my code

Node: 10.0.0
Npm: 5.6.0
tsc: 2.7.2
azure-event-hubs: 0.1.2
Here's the stack trace using node --trace-warnings
(node:15668) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 released listeners added. Use emitter.setMaxListeners() to increase limit
    at _addListener (events.js:244:19)
    at Sender.addListener (events.js:261:10)
    at Promise (C:\...\node_modules\azure-event-hubs\dist\lib\eventHubSender.js:231:30)
    at new Promise (<anonymous>)
    at EventHubSender._trySend (C:\...\node_modules\azure-event-hubs\dist\lib\eventHubSender.js:175:34)
    at EventHubSender.<anonymous> (C:\...\node_modules\azure-event-hubs\dist\lib\eventHubSender.js:68:35)
    at Generator.next (<anonymous>)
    at C:\...\node_modules\azure-event-hubs\dist\lib\eventHubSender.js:9:71
    at new Promise (<anonymous>)
    at __awaiter (C:\...\node_modules\azure-event-hubs\dist\lib\eventHubSender.js:5:12)

Can you share the code snippet? If you are running the sends in a loop, it looks like you did not await on sending the messages.

Right now I'm subscribing to a websocket and sending wathever I receive from it without waiting for the promise to resolve (client.send)
What happens when I wait for the client.send() ? Is it waiting for the response from EventHubs or something else ? Because if it's the first case, then it is sending events synchronously and this would be very slow for use cases where you need to send hundreds of events per second.

If you are using an async function then you can await inside a for loop. Take a look at an example over here.

The promisified send is wrapping the event handler underneath where it adds a listener for every attempt to send and removes it once it gets the accepted, rejected, modified or released event. Since you are not waiting on the promise to complete, too many event handlers are being attached and they are removed at a slower rate. If an error is received that is retryable then it will attempt to retry the send.

Yeah you were right, I wasn't waiting on purpose to get the max throughput, now I do and no more warnings.
I will edit my issue and include the answer.
But I still have a question: Is the sending process synchronous or async ? Is it waiting for a message to deliver before sending the next one ?
The C# library has two modes: sync and async. But here I don't know if waiting on the client.send() makes it wait on message delivery or not.
This is very important because it can drastically change the throughput.
Thanks !


Autotiling: non-rectangular collision shapes do not work as expected for corner tiles

Godot version: 3.0.2 stable

OS/device including version: Windows 10 Home

Issue description:
When using the autotile feature, collision shapes you draw seem to automatically be converted to square shapes behind the scenes. In other words, if I draw a non-rectangular collision shape along the border of a tile, the character will still collide with the entire tile and not just the border I drew.

Steps to reproduce:
Create a Tilemap with an autotiled tileset. Give one of the tiles a non-rectangular collision shape.
Minimal reproduction project:

autotile.zip
(Turn on visible collision shapes and try moving to the top left or bottom left corner of the map)

Duplicate #18197

Closing as duplicate of #18197 then.


Feature/rate limiting

This PR implements server rate limiting via express-rate-limit as per the decision reached in the rate limiting spike story.
The custom configuration allows up to 60 requests to any Linkta server endpoint(s) from a given IP address within a 15-minute window. It also provides a simple error log to the server.

Fixes #165 #235
Type of change

[x] ✨  New feature (non-breaking change which adds functionality)

How Can this be tested? Testing Plan to review this PR

[x] Where in the app does this change take place? | server.ts - express-rate-limit middleware applies to all incoming requests
[x] What are the steps to test this change? | Exceed the rate limit. Consider changing "60" to a small number like "5" and submit 6 requests via Postman.
[x] What is the expected output? | An error message and code 429 are returned if the rate limit is exceeded.

Checklist:

[x] I have performed a self-review of my own code.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[x] I have ensured that my pull request title is descriptive.

Response message

Server log

Response headers

@colinvandergraaf @ejwoods It looks like I've stumbled on another way to bypass the lint and format rules. After resolving merge conflicts via the GitHub UI, I was presented with the "Merge When Ready" button and no indication that the workflow would run again.


Compile Error Fix

root@wattos:~/Desktop/ss7MAPer# rebar co
==> pkt (compile)
==> epcap (compile)
Compiling /home/pen/Desktop/ss7MAPer/deps/epcap/c_src/epcap.c
In file included from /home/pen/Desktop/ss7MAPer/deps/epcap/c_src/epcap.c:34:0:
c_src/epcap.h:42:18: fatal error: pcap.h: No such file or directory
compilation terminated.
ERROR: compile failed while processing /home/pen/Desktop/ss7MAPer/deps/epcap: rebar_abort
if users are not use pentest distro like kali or backbox then need pcap.h ( Header File )
So I suggest you add readme. like this

sudo apt-get install libpcap-dev
Or download this url
http://packages.ubuntu.com/hardy/libpcap-dev

Thanks.

Hi,
I don't think it is necessary to mention that one needs the pcap header files to build the erlang pcap bindings (; Also the error message is quite clear.
Then your suggested addition is only correct for Ubuntu and I really don't want to add any distribution specific stuff to the README.
Thanks for mentioning, google will find it in this issue.
cheers

in brand new Kali, i had this problem, i suggest adding to readme as well. took me over an hour to figure out, and only figured it by seeing this post.
also9, rebar3 is out, should all stuff be updated for that?


controller: retry connection errors when getting extension-apiserver-authentication

Add retry to prevent being fatal:
Get https://<IP_ADDRESS>:443/api/v1/namespaces/kube-system/configmaps/extension-apiserver-authentication: dial tcp <IP_ADDRESS>:443: connect: connection refused
Best I can think of to address https://bugzilla.redhat.com/show_bug.cgi?id=1702104 (but I suspect there might be other components failing due to races).
/cc @deads2k

/lgtm