[bug]: Diffusers conversion error

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Windows
GPU vendor
Nvidia (CUDA)
GPU model
2080Ti
GPU VRAM
12
Version number
4.0.4
Browser
Edge
Python dependencies
No response
What happened
When converting ckpt to diffusers got error:
No such file or directory: 'E:\Data\AI\INVOKE3\configs\stable-diffusion\stable-diffusion\sd_xl_base.yaml'
error is that "\stable-diffusion\stable-diffusion" should just be "\stable-diffusion"
What you expected to happen
ckpt to be converted to diffusers format
How to reproduce the problem
attempt to convert a ckpt model
Additional context
No response
Discord username
No response

Did you get this when clicking the Convert button in the model manager?

yes, this is the only way I know how to convert models in the new gui

Thanks. We can fix this bug, but I'm curious if you actually want to convert the model permanently or just use the model. If you want to use the model, the model manager handles on-the-fly conversion for you.

I want to convert the model permanently - I download models as ckpt, and convert them then delete the original model to save disk space, thanks for addressing it!

I think I had the same issue right after converting Invoke. In my case the issue persisted due to the legacy_conf_dir parameter with value configs\stable-diffusion remaining in my invokeai.yaml. You can correct the path by removing the bonus \stable-diffusion from each configuration path, but removing the parameter from invokeai.yaml all together, assuming you did not use any custom path for configurations, solves that problem permanently.

Thank you @psychobyte-nl, yes, that could definitely cause this problem. @izumikon123 please let us know if that solves the issue for you. It's possible there is way this could happen.

This works, thank you!


updates to documentation and variable naming

remove offensive wording in variables where possible
update parameter documentation

okay, auto merge was faster than i thought, i edited the rules and not reviews are mandatory


update _maybe_get_column

so that it can be used for more general cases. Use swapcase. Change the error message.
https://github.com/mathause/regionmask/blob/35da3e463b8f04a7197a8ec059a8aeb37ab990c2/regionmask/defined_regions/natural_earth.py#L7

Closed by #119


Fix re-render use case

When remote frames provider was updated with a new targetDomElement reference, it didn't work, cause:

The queue was being deleted
It was missing componentDidUpdate necessary steps to re-render the global target into the new reference

Fixes:

Keep queue
Add compoennt did update rerendering global target into new reference


log settings ignored for "handle_always" and "handle_data_dir_query_path"

"handle_always" and "handle_data_dir_query_path" are processed, and return, before the invocation of log(..), and therefore nothing is logged.

@jayvdb
Improved logging. Thank you !


tex files open with text.tex.latex.beamer grammar

Just noticed that spell check stopped working. I took a look why and noticed that tex files intended for inclusion (i.e. without \documentclass) are opened with text.tex.latex.beamer grammar by default.
Don't know why exactly beamer documents have their own grammar at all, but maybe this isn't intended behavior?! If it is, then maybe add to the relevant section in README that text.tex.latex.beamer is also a reasonable grammar when enabling spell check for LaTeX.

Sorry, this is an artefact of https://github.com/James-Yu/Atom-LaTeX/commit/788796b8985e27ad5e3985c722e009253cb496db
There are some workaround on how to fix it, but if nothing comes up, shall revert that commit for now.

@ashthespy So I think it was you on Slack... anyway, I've made a PR to first-mate that should give a way to resolve the issue. I don't know if it will get accepted (stability seems very important to nowadays), but it seems harmless enough.

@Aerijo Indeed was me, thanks!

I note that "Latex Memoir.cson" grammar is also missing fileTypes "tex".
Would it be reasonable to add a contentRegex along the lines of "^%[ ]-\-[ ][bB]eamer[ ]-\-" to "Latex Memoir.cson", (mutatis mutants "Latex Beamer.cson") so that a comment of the form
% -- memoir -*-
would select the desired grammar (or, if absent entirely, fall-back to the latex grammar)?
I've been trying to make this work; however, I'm not sufficiently adept at all the escaping needed to correctly specify the regular expression .

I am also here for this bug. I am new atom user, and this was really confusing and almost turned me away.

@lsfinn contentRegex needs https://github.com/atom/first-mate/pull/109 to be merged for it work, hopefully it gets merged soon!

Sorry, this is an artefact of 788796b
There are some workaround on how to fix it, but if nothing comes up, shall revert that commit for now.

Is there any progress on this? Is there indeed a workaround you suggest to use in the meantime?

Hey guys, this was fixed right away when I moved \documentclass to the top of the .tex file. For me, I'm using the IEEE template you can find online and it has comments before the \documentclass, which was messing with how the grammar was being categorized.
I know its not a great fix, but its a decent workaround. If not, just add text.tex.latex.beamer to your grammar.

With the package file-types you can set up that all .tex files are in text.tex.latex grammar .
For me, who is only use latex and no latex.beamer, this is perfect.
https://atom.io/packages/file-types
My config looks like this and works fine:
core: "file-types":     "*.tex": "text.tex.latex"
I personally think this is an easy and pleasant workaround.

Should be fixed with d53027c50a5daf618ee3999fad6f27003e3ae105 that lands in v0.8.6


[SR-2869] Can't use Date in NSPredicate

Previous ID
SR-2869

Radar
None

Original Reporter
@bjhomer

Type
Bug

Environment
Xcode 8.0 b2
macOS Sierra 10.12
Apple Swift version 3.0.1 (swiftlang-800.0.56 clang-800.0.42)
Target: x86_64-apple-macosx10.9

Additional Detail from JIRA

Votes
0

Component/s
Foundation

Labels
Bug

Assignee
None

Priority
Medium

md5: 3db2af26dc72ef6e8288d176973521e2

Issue Description:
The Swift 3 migrator maps most uses of NSDate to Date. When used with NSPredicate, this proves to be somewhat of a pain.
import Foundation

let date = Date()
let predicate = NSPredicate("date < %@", date)
// error: argument type 'Date' does not conform to expected type 'CVarArg'

The compiler suggests NSPredicate("date < %@", date as CVarArg) as a fix-it, which does indeed work, but seems awkward. NSPredicate("date < %@", date as NSDate) is more natural, but still makes Date a second-class citizen here.
Is there a better option?

The newer Predicate type should better support this kind of thing.


pulls ConnectivityTable out of storage

Is this pull request associated with an issue(s)?
Fixes #370
Description
I needed the ConnectivityTable class in GhostFragment. This PR pulls it out of experimental.
TODOs

[x] Rough design notes.

r2g

🚀 [bumpr] Bumped! New version:v1.2.4 Changes:v1.2.3...v1.2.4


update testcases due to blueprint upgrade

Tried to upgrade blueprint, and re-generated the testcases.

Pull Request Test Coverage Report for Build 3991

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 37.04%

Totals

Change from base Build 3975:
0.0%

Covered Lines:
2713

Relevant Lines:
6554

💛  - Coveralls


Add option to specify what Kernel to start

Right now, thebe starts a python kernel by default.  But, it would be nice to be able to also start other kinds of kernels, like R or Julia (or even a specific version of Python, like python2 or python3).
curl -d '{"name":"julia"}' http://<IP_ADDRESS>:8888/api/kernels

In Atlas, you might specify the kernel in the data-code-language attribute, like this:
<pre data-executable="true" data-code-language="julia">

You can specify this now in the thebe options, though of course it's only what the notebook server container has, i.e. python2 or python3.
Moving forward though, how important/likely is it going to be for one page to contain multiple kernels? Jupyter can do this, with those %magic commands, but I worry about how this is going to work with dependencies and multiple containers.

I'm guessing one page would only have a single kernel. Just ran into this, I'll dig into the options now.

kernel_name option works and is in master now so closing this

Oh right, and I've been using it for > 3 months now.


netdata: fix darwin; cleanup; 1.47.0 -> 1.47.1

Description of changes
Resolves https://github.com/NixOS/nixpkgs/issues/341362
Not very familiar with netdata usage, so would like someone to test it that is.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 341472 run on x86_64-linux 1

1 package failed to build:

netdataCloud

1 package built:

netdata

Result of nixpkgs-review pr 341472 run on x86_64-linux 1
1 package failed to build:
* netdataCloud

1 package built:
* netdata

Doh, forgot to check the cloud version...

Result of nixpkgs-review pr 341472 run on aarch64-darwin 1

2 packages built:

netdata
netdataCloud

oh but, that's on linux. Which shouldn't have changed from this. Is that failing on master atm?

It's the typo in the version number. Couldn't pull version 1.4.7}
Same on Darwin x86. Puzzled it's not happening on Darwin-aarch64.

Result of nixpkgs-review pr 341472 run on aarch64-darwin 1

2 packages built:

netdata
netdataCloud

Two requests:
1. Consider bumping to 1.47.1 (just released)

2. Please squash your commits per [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md)

I would like to keep the logical units of operations separate, as I do it most PRs so that no-ops don't need to be reverted if a breaking change happens in the main commit with logical changes.

LGTM, but I'd like an opinion from someone more senior. CC: @NixOS/darwin-maintainers

Result of nixpkgs-review pr 341472 run on x86_64-darwin 1

2 packages failed to build:

netdata
netdataCloud

Result of nixpkgs-review pr 341472 run on x86_64-darwin 1
2 packages failed to build:

Hmm.. I'll run x86 locally to see what's up.

Result of nixpkgs-review pr 341472 run on x86_64-darwin 1

2 packages built:

netdata
netdataCloud

Unfortunately, my x86 Darwin nix install has suddenly stopped working. It may be a bit while I'm troubleshooting.

1. Consider bumping to 1.47.1 (just released)

alright, just bumped it after making sure x86 built for me on the last version

Result of nixpkgs-review pr 341472 run on x86_64-darwin 1

2 packages built:

netdata
netdataCloud

Result of nixpkgs-review pr 341472 run on aarch64-darwin 1

2 packages built:

netdata
netdataCloud

Result of nixpkgs-review pr 341472 run on x86_64-linux 1

2 packages built:

netdata
netdataCloud

Result of nixpkgs-review pr 341472 run on x86_64-darwin 1

1 package failed to build:

netdataCloud

1 package built:

netdata

Result of nixpkgs-review pr 341472 run on x86_64-darwin 1

2 packages built:

netdata
netdataCloud

Ah, my build on Darwin had a package failure probably because I have sandbox enabled.

nixpkgs-review is good on x86_64-Linux, x86_64-Darwin, and aarch64-Darwin


AbstractMain

As Bill suggested here, we can remove some duplicate code/patterns in SubmitterMain and RuntimeManageMain by letting them extend a common abstract class called AbstractMain.

actually, will finish this PR after @billonahill's work on refactoring configs is merged


Lower Flatten to Krnl

Flatten Op is intended to change the shape of the input tensor into a 2D output tensor, with first axis() dimensions for the first dimension and the rest for the second dimension.
A loop nested is generated with the shape of the input() of Flatten Op. The index of the output tensor is calculated with the index and dimension size of the input tensor.
test cases are added to check-onnx-lit and all the node tests for Flatten Op are enable.

@jenkins-droid test this please.


Feature/mapl3 port to ifort 2021.10.0

Tested unit tests with

gfortran 12.3
ifort 2021.10.0
nag 7.1.40

on OS X.
Note that the pfio tests do not reliably pass on os x with any of these.    Not entirely reproducible from what I have seen.  Also some evidence that at least one ExtData test is not always reproducible.   These issues must be investigated as unreliable unit tests are worse than useless.

I'm going to comment here to see if @tclune wants to keep this around. The conflict list is impressive enough I don't think I could solve it.

I'm closing it for now.   Can always look for it again when I'm ready.


Can't work。V1.12

I don't know...Why?Setting wrong?

This is out put of the first log. 'Log.e("KingGGG", "123321"). It seems settings are OK


Enhance sqlpath.Glob to actually support glob wildcard

This PR enhances the Glob function in the internal/sqlpath package to support glob patterns in the input paths. It also adds comprehensive tests for the Glob function, ensuring its correct behavior and in various scenarios, as well as protects it from regressions.
Problem
I want sqlc to be able to collect queries from different modules of my applications:
...
sql:
  - engine: "postgresql"
    queries: "modules/*/sql"
...

Epected:
Normal execution.
Actual:
error parsing queries: path /home/masked/project/internal/modules/*/sql does not exist

internal/sql/sqlpath/read_test.go: Introduced a new test file with multiple test cases for the Glob function. These tests cover various scenarios like handling of SQL files, non-SQL files, hidden files, non-existent paths, unreadable directories, and symlinks.

internal/sql/sqlpath/read.go: Added a new function expandGlob s to expand glob patterns in the input paths. The Glob function now calls expandGlob s before processing the paths. Also, added error handling for cases where the path does not exist or is not a file.

internal/sql/sqlpath/testdata/: Dummy directory of files and symlinks to test various scenarios.

@sqlc-dev please take a look

@iamwavecut I made a few changes to the PR. I remove the nolint comment, as we don't use those anywhere in the codebase. I only call filepath.Glob if the path contains ?*[]. It's easier to preserve existing behavior this way.
I also changed the error messages to include the info from os.Stat. This information isn't as useful as the results from lstat, but it is more consistent across platforms.

@kyleconroy Sure! Thanks for the improvements.


kbpki_client: add id->username cache

folderBranchOps.GetNodeMetadata gets the normalized username given an ID on every call, which results in a service RPC.  However, this mapping can be easily cached since it basically never changes. So this adds a small LRU cache for those mappings.
Issue: HOTPOT-877

What about in SBS case? Does normalized username still not change?

What about in SBS case? Does normalized username still not change?

This is only looking up normalized usernames from UIDs.  In this SBS case, there is no UID, so this function (and cache) won't be used.

@songgao when I answered your question above, I was thinking about users (since that is the performance problem I'm solving here).  But it is true that team names can change, both because of SBS resolutions and subteam renames.  I don't think this particular cache would get hit much in those cases, but I just added a new commit (354e812) to invalidate the cache on team renames.  Thanks for the reminder.  Please take another look!

NP! Is team name change by SBS resolutions is because of implicit team name?

NP! Is team name change by SBS resolutions is because of implicit team name?

Both implicit teams containing SBS assertions, and subteam renames, can cause team name changes.


Misc bugfixes with sharding ranges code

Some forgotten conversions of get_shard_pivots to ranges
Issue with determining shard entry from object entry in convert
to items.

fixed by: 67db13ea847f651df22c1e52b2a36645578bbc25
fixed by: 1188251c3a37cf27f8e894f7c027e7a5224ba58e


SNTWREC-27: Set up CICD for backend microservices

add CICD for backend services

@grusc thx for your comments - I redesigned the approach to accommodate builds on changes only - makes sense to me.

LGTM
very nice!


Graphite disk usage

In addition to deleting whisper files that have not been updated in $retention_time also get rid of logs.  This approach turned out to be easier then log rotate because it eliminated the need to introspect configuration for the number of relay and cache instances and any customization that it would entail

Yes, sadly DRQS 70769016 showed we were generating around 15k entries per second so too many to delete on a rotation.

Aside from fixing the problem that caused excessive logging, we still want to remove older files

Thanks for updating LOG_DIR in carbon.conf.


authentication support

Hi,
it would be nice if you can add authentication to the node-red ui. Maybe it's possible to use the pimatic users directly for that.

See #22


Ghidra Download Automation

Added an automation script for Ghidra to get the installation done hassle free!!

Thanks for your submission, but this is a bit too platform-specific for us to include in our repository.
If you wrote this script for your own use, you might want to check out this link.  It has an example of how the GitHub REST API can be used to automatically get the latest release, so you don't have to change your script in the future:
https://gist.github.com/maxim/6e15aa45ba010ab030c4

Ryan Kurtz,
Thanks
On Fri, Jul 23, 2021 at 3:37 AM Ryan Kurtz @.***> wrote:

Closed #3257 https://github.com/NationalSecurityAgency/ghidra/pull/3257.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NationalSecurityAgency/ghidra/pull/3257#event-5058330959,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQT2M2QPTSEICWED7ADUABLTZCJB3ANCNFSM5A2XYNHA
.


syntax hilite readme

This adds GitHub style syntax highlighting to the README file. You can see what it looks like when rendered on GitHub at: https://github.com/eklitzke/nvParse/tree/syntax
The existing README mixed tabs/spaces for the code examples, which I converted to all spaces. Also my editor stripped out trailing whitespace. :man_shrugging:

Thanks !


Can I use bittorrent-dht to connect to a peer?

First of all: this project is awesome. I am testing a sketch of a new cryptocurrency protocol, and I would like to use bittorrent-dht to connect my nodes in a peer to peer fashion. I know I can use dht.announce and dht.lookup to setup rendezvous and let nodes know about each others' ip and port. I also know that when I omit the port in dht.announce, the external port I am communicating from is used, which is nice in the case where I am behind some NAT that changes my external ports.
Now, when I get a callback from dht.on('peer', ...), I obviously only get an ip and a port. Now, I would like to actually connect to that peer. How can I achieve this? If I omitted the port, the socket behind the port I received is going to be already used by the dht object. By going through it I found out I can technically hijack dht._rpc.socket.socket, which looks like an UDP socket from which I can send and receive packets. But I wouldn't want to interfere with the protocol.
So is there a nice way to get an actual connection between two peers, once they have discovered each other and are willing to connect?

The DHT listens on UDP. You can have your peers also listen on TCP on the same port, and connect on that. That's what WebTorrent does :)


FR: Volvo Trucks Compound Calculator Modal

Agile Requirement
As a user, I want to be able to calculate how much money I would be saving on gas depending on the characteristics of the truck I select and its motor so that I can buy the truck that best suits my needs.
https://www.figma.com/file/yv0VtHTvMoGPqkv0RAYcVp/PDP?type=design&node-id=8465-51236&mode=design&t=ZPrXUdQRUIIO3ABZ-4

Per discussion with @williebender, this item can be placed on hold for now. Awaiting information.

Kamino cloned this issue to hlxsites/vg-volvotrucks-us


Add web socket reconnect timer

When the frontent looses the connection to the lamp, it tries
to establish a new connection every 5 seconds.
During the reconnect it shows an informational message to
the user.

This has been on my TODO list for quite a while now. Its really been bugging me, so thank you for implementing it.


Feature: A new RemoteChildOwned struct to avoid self-ref issue

From https://github.com/openssh-rust/openssh-sftp-client/pull/65#issuecomment-1533280291 :

If it possible for Sftp to hold a session and spawn command (which means hold on RemoteChild) internally? So that users don't need to hold session, remote_child and Sftp at the same time. To avoid RemoteChild been dropped earlier than Sftp, users like opendal have to use owning_ref tricks.

openssh_sftp_client::Sftp now has a new method new_with_auxiliary to hold any data and @Xuanwo & @silver-ymz is currently using a workaround I proposed by using a Boxed future.
But I think it's still better to have a RemoteChildOwned to avoid the self-ref issue, it's pretty bad for anybody using it with openssh_sftp_client.
Alternatively, we can wait for the new proxy-mode to openssh-mux-client https://github.com/openssh-rust/openssh-mux-client/issues/6 , which will enable you to use stdin/stdout/stderr while dropping Session and RemoteChild.
It will also support windows.
Unfortunately, it was blocking on tokio_util::sync::WaitForCancellationFutureOwned, so I switched to other projects and I kind of forgot it.
I will restart working on it, but it will takes quite some time before it's ready to use.

I think this makes a lot of sense! The way to go about it is probably to start carrying around Arc<Session> instead of just Session, and then have a variant of RemoteChild that clones that Arc<Session> instead of keeping a &'s Session inside. Should be a pretty trivial change I think beyond having to duplicate a bunch of the RemoteChild code. If you can think of a clever way in which we can avoid duplication much of the code, that'd be nice, but not a requirement.
Do you think we should also deprecate RemoteChild with the plan to make RemoteChildOwned the only RemoteChild in the future? My main concern would be that people end up unexpectedly leaving sessions open because they're still storing a RemoteChild somewhere, when in reality they might want the borrow checker to tell them that that is the case.

I think this makes a lot of sense! The way to go about it is probably to start carrying around Arc<Session> instead of just Session, and then have a variant of RemoteChild that clones that Arc<Session> instead of keeping a &'s Session inside. Should be a pretty trivial change I think beyond having to duplicate a bunch of the RemoteChild code. If you can think of a clever way in which we can avoid duplication much of the code, that'd be nice, but not a requirement.

That's definitely doable!
Our underlying process-impl and native-mux-impl does not hold any reference to Session and most of the method (except for RemoteChild::{new, session} does not use the session reference at all.

Do you think we should also deprecate RemoteChild with the plan to make RemoteChildOwned the only RemoteChild in the future? My main concern would be that people end up unexpectedly leaving sessions open because they're still storing a RemoteChild somewhere, when in reality they might want the borrow checker to tell them that that is the case.

I think keeping both is doable, there is no need to deprecate them.

Though it will indeed add some overhead, since we now need to store SessionImp in an Arc.

Should be a pretty trivial change I think beyond having to duplicate a bunch of the RemoteChild code. If you can think of a clever way in which we can avoid duplication much of the code, that'd be nice, but not a requirement.

I assume I'm missing something obvious but couldn't RemoteChild store a T: AsRef<Session> (or T: Deref<Target=Session> I'm never quite sure which is the correct one)? And that would really only even be for the session method.
Although it would change the signature of RemoteChild itself so maybe the concrete struct should be something else and RemoteChild<'a> would become be an alias for ???Child<&'a Session>.

Thanks @masklinn !
I think that's feasible and would require less code.
I will have a try of this and I also welcome any PR for this!


Allow option to only trace if there is an exception

Feature request
Allow conditional tracing, only if an exception has been thrown.
Motivation
For some LLM applications, there may be hundreds of API calls being made per single use case, due to the rising popularity of agentic workflows that focus on small, specific tasks. It would be great to trace only errors being thrown, and this would work great for other functions too.

That would add a lot of complexity if we implemented this client-side.
Right now, you can edit TTLs of traces in langsmith and then make it so errored runs have longer TTLs. This server-side handling is more reliable.
Handling client side would mean we'd have to keep an entire long trace in memory until it completes and then only send if there's an error. When the application is distributed, this because pretty fraught (the called process wouldn't be responding likely.

Going to move to discussions since this isn't a bug.


Updating README with proper grammar

In addition to embracing Swift 3, you should also embrace good grammar! ;)

I can't compete with Shiro's intelligence level :) Thanks

Senpai approves :)


Fix a couple memory leaks in C++ FPGA properties wrapper

Found this when checking the wsid hash code.


Metadata: Add ability to use erb or other templates

For multi-target apps, often the metadata differences are small (e.g., adding "Pro" to a name). It would be very useful to be able to use templates (erb, etc.) to customize metadata. For example, instead of name.txt, use name.erb:
MyApp <% ENV['IS_PRO'] ? 'Pro' : 'Free' %>

Discussions are for feature requests. If you'll like to directly add this to Fastlane, we're completely open source, feel free to open a pull request!


Logging in monitor and user profile should use same log levels as broker

Logging has common code between monitor, user profile and broker. Extract it out into a common library.

Basic information, no need for it to be controlled by the VS/Broker options.


Translation fails for parameterized records

Running the ECDSA proof from the saw-script repository results in the following error from saw:
saw: user error (proveProp: Cmp (ec_point_ops::JacobianPoint a`2540))

The proveProp function appears to implement a translation for Cmp on records, but perhaps doesn't handle the case where the type is parameterized?

Fixed in 841931ffe8bbbf733ba25b52c2507a7a0768a95a.


[v5] firstPageParam from getPreviousPageParam is always same

Describe the bug
firstPageParam is always returning same value.
const {
    isPending,
    error,
    data,
    fetchNextPage,
    hasNextPage,
    hasPreviousPage,
} = useInfiniteQuery({
    queryKey: ['notifications'],
    queryFn: ({ pageParam }) => getNotifications(pageParam),
    initialPageParam: 1,
    staleTime: Infinity,
    getNextPageParam: (lastPage, allPages, lastPageParam) => {
        console.log(lastPageParam)                                          // logs: // 1 // 2 // 3 // 4
        return Number(lastPage?.meta?.next?._page) || undefined
    },
    getPreviousPageParam: (firstPage, allPages, firstPageParam) => {
        console.log(firstPageParam)                                          // logs: // 1 // 1 // 1 // 1
        return Number(firstPage?.meta?.first?._page) || undefined
    },
})

based on this example from the docs I think it should return current page number
(if this is the case, I would also suggest changing both lastPageParam and lastPageParam to currentPageParam in the docs):
https://tanstack.com/query/v5/docs/react/guides/infinite-queries#what-if-my-api-doesnt-return-a-cursor
Your minimal, reproducible example
https://codesandbox.io/p/sandbox/empty-sea-w2fnqx?embed=1&file=%2Fsrc%2Fpages%2Findex.js%3A41%2C7-42%2C12
Steps to reproduce

create basic example with useInfiniteQuery
log firstPageParam from getPreviousPageParam: (firstPage, allPages, firstPageParam)

Expected behavior
firstPageParam from getPreviousPageParam should return current pageParam instead of initialPageParam
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform

OS: MacOS (m1)
Browser: Chrome 117.0.5938.92

Tanstack Query adapter
react-query
TanStack Query version
5.0.0-rc.4
TypeScript version
No response
Additional context
No response

I would also suggest changing both lastPageParam and lastPageParam to currentPageParam in the docs

lastPageParam is the page param of the last page in the cache
firstPageParam is the page param of the first page in the cache

Your minimal, reproducible example

The sandbox you're showing is made with v4. I've forked it and upgraded the syntax to v5, and it works as expected for me:
https://codesandbox.io/p/sandbox/sad-boyd-2cvk59
initially I have {firstPageParam: 0}. Then, if I click load older, I see {firstPageParam: -5}. Clicking once more, I see {firstPageParam: -10}

@TkDodo Thank you and sorry for the wrong version in the example.
I added the 'Load Newer' button to your example:
https://codesandbox.io/p/sandbox/crazy-danny-fx4gq3?file=%2Fsrc%2Fpages%2Findex.js%3A88%2C8
Now, when "Load Older" is clicked two times in a row, and there is nothing to load more ("Load Older" button is disabled) and when 'Load Newer' is clicked,  "Load Older" remains disabled.
Same problem happens vice versa for 'Load Newer' button in the opposite direction.
video: screen-capture.webm

why is this a problem? Why would you expect the buttons to be enabled again?
Our backend ("database") has the following project ids:
-10
-9
-8
-7
-6
-5
-4
-3
-2
-1
0
1
2
3
4
5
6
7
8
9
10
11
12
13
14

those are junked into pages. we start with loading the first page, which is:
[0,1,2,3,4]
now we can go two times into the "previous" direction to get:
[-10, -9, -8, -7, -6, -5, -4, -3, -2, -1, 0, 1, 2, 3, 4]
and then, we can go into the forward direction to get projects with id 5 and upwards. But getting "newer projects" doesn't give us more projects to load in the previous direction - we've literally loaded everything that is in the database already ...
unless of course you use the maxPages option, which you don't....


License Question

If I want to use an emoji as my favicon, what kind of attribution is required for that?

IANAL but I believe it's CC-BY 4.0 that applies.

With two license on this project. Can we use twemoji for our web, if our web like twitter or facebook ?


Local transcription does not work on mac

I think it can't find the path to the ffmpeg binary. It also may be an issue with how the python executable is built.

Running the command mentioned in this article seems to stop the dmg is damaged error from occurring. This probably has to do with code signing, so this command is really a temporary solution.

After using the xattr -cr <filepath> command, I can run the app on another mac. However, local transcription will not get past the preprocessing stage. After digging into the app contents, and running local_whisper directly from the command line, I get the following error:
File "urilib/request.py", line 1348, in do_open File "http/client.py", line 1283, in request
File "http/client.py", line 1329, in _send_request
ioL
let
File "http/client.py", line 1278, in endheaders File "http/client.py", line 1038, in _send_output
File "http/client-py", line 976, in send
File "http/client.py", line 1455, in connect
File "ssl.py", line 517, in wrap_socket
riot
File "ssl.py", line 1075, in _create
son
File "ssl.py", line 1346, in do_handshake
ssI.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY FAILED] certificate verify failed: unable to get local issuer certificate son s1.c: 1002)
Pa During handling of the above exception, another exception occurred:
spa Traceback (most recent call last);
File "local_whisper.py", line 24, in <module>
nto
ch:
gP:
File "whisper/ init_ _•py", line 131, in load_ model File "whisper/__init_py", line 67, in _download File "urilib/request.py", line 216, in urlopen
File
"urilib/request.py", line 519, in open
File "urllib/request.py", line 536, in _open
File "urllib/request.py", line 496, in _call_chain
ans
File "urIlib/request.py", line 1391, in https_open File "urllib/request.py", line 1351, in do_open
urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certifi cate (_ss1. c: 1002)>
(25524] Failed to execute script 'local_whisper' due to unhandled exception!```

This seems to be a code signing error, so I will need to better understand this.


Pictures not showing up on profiles

Although I upload pictures systematically for all users, they are no longer showing up on profiles. They only show up if I add the secondary picture that is not readily accessible by other people. The picture people upload has to be visible. Please reconcile the two image fields to ensure the maximum number of users have images.

For instance, I uploaded this picture:

But it doesn't appear on her profile:

I have to go back and edit the profile and upload another copy of the picture in a different place:

This creates a duplicate of the picture that is already online:

This has got to be fixed, it is affecting many, many profiles.

this is all re-done and cleaned. Visible on stage and will be pulled into production this morning.


Add Windows 11 Widgets to cations

I find Windows 11 Widgets quite useful recently, would be great if you add Widgets action to the action list!
It's quite hard for me to custom this Widgets action, I could not find the corresponding shell command :-(

add Widgets action

I'm not (yet) a Windows 11 user, could you explain WDYM by that? Show the Widgets panel, I guess?

added


Transliterate selected text to devanAgarI - add optitrans option

Just introduced my father to the proofing interface - the transliteration tools are very convenient! The transliterate selected text to devanAgarI ought to include optitrans as a from-script option. Simpler and intuitive to type "shankara" than "sha~Nkara" etc.. sanscript.js  has this option and it should be easy to add. Will try submitting a cl.

Following up on https://github.com/ambuda-org/ambuda/pull/252 -
          <option value="optitrans">OPTI (ank→अङ्क्)</option>

should be added to editor-components.html above ITRANS.

Fixing in #327.


doc(README): remove typo

Description:
This Pull Request fixes a typographical error in the README.md file.
Changes Made:

Corrected "modals" to "models" in the README.md file.

Additional Information:
This fix is not related to any existing issue. It's a minor typo that I noticed while reviewing the README.
Thank you for considering this contribution.

This is not a typo.


Memory-related JVM crash on Linux

Issue Description

expected behavior - when memory allocation is not possible (insufficient RAM available), an exception in JVM itself is thrown. Previously it worked this way by checking first if the allocation is possible based on the requested array's length
encountered behavior - JVM is crashed, which makes gracious clean-up, emergency save etc. impossible

Version Information

Deeplearning4j version - M2
Platform information (OS, etc) - Linux (Buster 10)
CUDA version, if used - N/A
NVIDIA driver version, if in use - N/A

Additional Information
The error log is attached here
The assumption that this crash is being caused by insufficient RAM availability has been concluded by running the model training with different batch sizes and keeping track of available physical memory. After increasing the batch size I've managed to reproduce the issue almost instantly, with smaller batch it happened after 10-15 iterations.

@partarstu
did you start to get such problems with the new one? Just for confirmation, was M1 working as expected?
Thanks.

@quickwritereader yes - in M1 I simply got different errors/exceptions based on which component detected that another chunk of ByteArray can't be allocated inside native memory. But all of them happened inside JVM and could be intercepted.
One more thing, I guess it's important. I use the following lines of code in order to configure memory-related options:
System.setProperty("org.bytedeco.javacpp.logger.debug", "false");
        System.setProperty("org.bytedeco.javacpp.maxphysicalbytes", MAX_JVM_MEMORY);
        if (USE_CACHING) {
            System.setProperty("org.bytedeco.javacpp.maxbytes", MAX_NATIVE_MEMORY);
        } else {
            System.setProperty("org.bytedeco.javacpp.maxbytes", "0");
        }

@partarstu I thought about this a bit and generally I would recommend not trying to manually control this kind of thing yourself. I would focus on using workspaces more or if you really need to, we have a way of automatically triggering gc on a fixed interval already.  Take a look more at this here: https://deeplearning4j.konduit.ai/v/en-1.0.0-m1.1/multi-project/explanation/configuration/memory#memory-management-for-nd4j-dl4j-how-does-it-work
Nothing really changed in M2 from M1.1 that would cause anything new to happen here. You can see what changed here: https://deeplearning4j.konduit.ai/release-notes/1.0.0-m2 you'll basically just see java 9, samediff training changes (one that introduced the regression that's been fixed) and some scala related changed.

@agibsonccc this manual control was done after I read about those settings in a couple of threads. Without those settings I had some other issues. Without explicitly setting "org.bytedeco.javacpp.maxphysicalbytes" I think I saw similar issue to the one for which this ticket is created. I need to double-check that. Setting "org.bytedeco.javacpp.maxbytes" to zero was previously recommended in order to avoid some issues in Linux (there were one or two threads regarding this one on https://community.konduit.ai/ forum).
What I'm sure of is that after rolling back to M1.1 using the same source code and config, too huge batch size started causing again exceptions being thrown during allocation whereas in M2 there was simply a JVM crash. I'll try to remove those properties and re-run the model on M1.1 without them having a too huge batch size and see what happens.

@partarstu appreciated if you could help narrow this down to something a bit more concrete!

@agibsonccc I've done a couple of testing rounds. The findings:

org.bytedeco.javacpp.maxphysicalbytes must be set up in my case because by default its value is being initialized to ~ 20% of available RAM which is definitely not what I want (and I guess in any PROD environment MLOps would be willing to have this configurable)
If  org.bytedeco.javacpp.maxphysicalbytes is not approaching available RAM limits, in both M2 and M1.1 OOM error is thrown, an example: ```
Caused by: java.lang.OutOfMemoryError: Physical memory usage is too high: physicalBytes (12460M) > maxPhysicalBytes (12288M)
at org.bytedeco.javacpp.Pointer.deallocator(Pointer.java:733)
at org.bytedeco.javacpp.Pointer.init(Pointer.java:126)

3. If  **org.bytedeco.javacpp.maxphysicalbytes** approaches the available RAM limits, the behavior depends on **org.bytedeco.javacpp.maxbytes** property. If this prop is not initialized, in both **M1.1** and **M2** JVM crash happens (in Windows only one error message line is written, in Linux there's a full error stack trace). If however this prop is set to **0**, in **M2** JVM still crashes but in **M1.1** the following exception is thrown: ```
java.lang.RuntimeException: Allocation failed: [std::bad_alloc]
	at org.nd4j.nativeblas.OpaqueDataBuffer.allocateDataBuffer(OpaqueDataBuffer.java:76)
	at org.nd4j.linalg.cpu.nativecpu.buffer.BaseCpuDataBuffer.<init>(BaseCpuDataBuffer.java:284)
	at org.nd4j.linalg.cpu.nativecpu.buffer.FloatBuffer.<init>(FloatBuffer.java:64)
	at org.nd4j.linalg.cpu.nativecpu.buffer.DefaultDataBufferFactory.create(DefaultDataBufferFactory.java:293)
	at org.nd4j.linalg.factory.Nd4j.createBuffer(Nd4j.java:1455)
	at org.nd4j.linalg.api.ndarray.BaseNDArray.<init>(BaseNDArray.java:320)
	at org.nd4j.linalg.cpu.nativecpu.NDArray.<init>(NDArray.java:187)
	at org.nd4j.linalg.cpu.nativecpu.CpuNDArrayFactory.createUninitializedDetached(CpuNDArrayFactory.java:233)
	at org.nd4j.linalg.factory.Nd4j.createUninitializedDetached(Nd4j.java:4428)
	at org.nd4j.linalg.factory.Nd4j.createUninitializedDetached(Nd4j.java:4435)
	at org.nd4j.autodiff.samediff.internal.memory.ArrayCacheMemoryMgr.allocate(ArrayCacheMemoryMgr.java:135)

So the summary is the following : initializing org.bytedeco.javacpp.maxbytes with 0 helps avoiding JVM crash if the available RAM is lower than the limit set in org.bytedeco.javacpp.maxphysicalbytes property. And this is really good. But in M2 this "feature" is either gone or modified. Anyway, what used to throw an exception in all previous releases incl. M1.1 allowing to handle graceful termination including emergency saves etc. doesn't do it anymore in M2.
I don't know if it's a regression or an expected behavior, but in my opinion having an exception instead of a JVM crash is of a really good use.


How does NLog deal with orphaned log files

Hello,
I am programmer in C# and a new user of NLog. I really like the log file auto archive and auto rotation feature! Currently I have a question:
I used NLog in my app to log some information and save the log file into local disk, to save space, I enabled auto file archive and file deletion. I am wondering, say, if my app crushed for some reason and then restarted, how would NLog deal with the old orphaned log files? Would they still got deleted/rotated?
This is my inline logger config:
var fileTarget = new NLog.Targets.FileTarget
            {
                FileName = @"var/output/logs/${date:format=yyyy-MM-dd-HH}.log",
                ArchiveFileName = @"var/output/logs/archived/${date:format=yyyy-MM-dd-HH}.log",
                ArchiveNumbering = NLog.Targets.ArchiveNumberingMode.Sequence,
                ArchiveEvery = NLog.Targets.FileArchivePeriod.Day,
                MaxArchiveDays = 7,
                ArchiveAboveSize = 40960,
                Layout = "${longdate}|${level:uppercase=true}|${logger}|${message}",
                Encoding = Encoding.UTF8,
            };

Suggestions appreciated,
Thanks!

You have correctly identified that NLog does not support mixing dynamic- and static-archive-logic.
You should avoid mixing dynamic FileName = @"var/output/logs/${date:format=yyyy-MM-dd-HH}.log", with ArchiveFileName = "...",. Also never specify ${date} / ${shortdate} / etc. in the ArchiveFileName = "...",
Instead you should use dynamic-configuration:
var fileTarget = new NLog.Targets.FileTarget
            {
                FileName = @"var/output/logs/app.${date:format=yyyy-MM-dd-HH}.log",
                MaxArchiveDays = 7,
                ArchiveAboveSize = 40960,
                Layout = "${longdate}|${level:uppercase=true}|${logger}|${message}",
                Encoding = Encoding.UTF8,
            };

Or static-configuration:
var fileTarget = new NLog.Targets.FileTarget
            {
                FileName = @"var/output/logs/app.log",
                ArchiveFileName = @"var/output/logs/archived/app.{#}.log",
                ArchiveNumbering = NLog.Targets.ArchiveNumberingMode.DateAndSequence,
                ArchiveEvery = NLog.Targets.FileArchivePeriod.Day,
                MaxArchiveDays = 7,
                ArchiveAboveSize = 40960,
                Layout = "${longdate}|${level:uppercase=true}|${logger}|${message}",
                Encoding = Encoding.UTF8,
            };

You have correctly identified that NLog does not support mixing dynamic- and static-archive-logic.
You should avoid mixing dynamic FileName = @"var/output/logs/${date:format=yyyy-MM-dd-HH}.log", with ArchiveFileName = "...",. Also never specify ${date} / ${shortdate} / etc. in the ArchiveFileName = "...",
Instead you should use dynamic-configuration:
var fileTarget = new NLog.Targets.FileTarget
            {
                FileName = @"var/output/logs/app.${date:format=yyyy-MM-dd-HH}.log",
                MaxArchiveDays = 7,
                ArchiveAboveSize = 40960,
                Layout = "${longdate}|${level:uppercase=true}|${logger}|${message}",
                Encoding = Encoding.UTF8,
            };

Or static-configuration:
var fileTarget = new NLog.Targets.FileTarget
            {
                FileName = @"var/output/logs/app.log",
                ArchiveFileName = @"var/output/logs/archived/app.{#}.log",
                ArchiveNumbering = NLog.Targets.ArchiveNumberingMode.DateAndSequence,
                ArchiveEvery = NLog.Targets.FileArchivePeriod.Day,
                MaxArchiveDays = 7,
                ArchiveAboveSize = 40960,
                Layout = "${longdate}|${level:uppercase=true}|${logger}|${message}",
                Encoding = Encoding.UTF8,
            };

Thanks for mentioning that @snakefoot , very informative. However, this seems not answering my question, if my app crushed, would NLog clean up the orphaned logs on next app restart?
Thank you

Yes. If you use the 2 examples that I provided. But not if you use the example that you provided initially.

Thanks, @snakefoot , I will change to use the example you provided.

Closing question as answered.


Fixing missing FS in kernel defconfig

Missing btrfs in default kernel config. General cleanup of unneeded settings

@fedepell we should be ready. I made separated commits to make it easier to check and, eventually, discuss, on what can be readded or removed


Why the generated code doesn't generates TS enums?

Is there's a way to generate TS enum instead of string literals unions?
Looks like there's not, is there a specific reason behind it?

Genql uses literal enums because Typescript enums rely on runtime code and are considered harmful
To use an enum value at runtime you can import the value enumX where X is the enum type


Image tags compiling on index page, not on post pages

I am using {% image hero-image.jpg %} in a post.
The tag correctly converts to <img src="/assets/hero-image.jpg"/> when the post is rendered on the site's index page (which loops through and displays all posts), but the tag does not render when clicking through to the post.
How can I fix this?

Define: 'not being processed' because so far from my deductions this is an upstream problem because we process through Jekyll via Liquid.  Which means that if Jekyll doesn't tell liquid to process the post, then nothing will happen.  Can you provide replication steps as a repo I can pull to test it?
/cc @jekyll/core

@envygeeks Got it — the upstream template was using {{ page.content }} instead of {{ content }}, which meant it wasn't processing the Liquid variables when rendering.
Thanks for the help.


Broaden dependency version ranges

Is there any reason we have to have the narrow ranges in pubspec.yaml? It's going to keep causing problems like we just had with intl, where it was preventing flutter from rolling to a newer version (e.g. right now we're pinned to <0.20, which means as soon as intl upgrades to 0.20, we'll be blocked again).
Is there any reason we can't just use any or just a really broad >0.18 range or some similar thing, and rely on testing in the client packages to catch problems?

FWIW, this package is published - https://pub.dev/packages/unified_analytics - but is unlisted (it doesn't show up in pub search results).
For published packages we do want to follow semver for dependency constraints. It adds a level of predictability for user's CI breakages and such.
If we don't expect usage outside of the dart sdk and flutter sdk (devtools? other published packages?) there may be ways to distribute other then publishing.
(context on the pubspec in question: https://github.com/dart-lang/tools/blob/main/pkgs/unified_analytics/pubspec.yaml#L17)


"[DEP0040] The punycode module is deprecated" with Node.js 22.4.0

Link to reproduction
No response
Describe the Bug
  [nodemon] starting `ts-node src/server.ts -- -I`
  (node:53079) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
  (Use `node --trace-deprecation ...` to show where the warning was created)
  [20:32:27] INFO (payload): Connected to MongoDB server successfully!

To Reproduce
"dependencies": {
    "@payloadcms/bundler-webpack": "^1.0.0",
    "@payloadcms/db-mongodb": "^1.0.0",
    "@payloadcms/plugin-cloud": "^3.0.0",
    "@payloadcms/richtext-slate": "^1.0.0",
    "cross-env": "^7.0.3",
    "dotenv": "^8.2.0",
    "express": "^4.19.2",
    "payload": "^2.0.0"
  },
  "devDependencies": {
    "@types/express": "^4.17.9",
    "copyfiles": "^2.4.1",
    "nodemon": "^2.0.6",
    "ts-node": "^9.1.1",
    "typescript": "^4.8.4"
  }

npm run dev
Payload Version
2.0.0
Adapters and Plugins
db-mongodb

You can prepend cross-env NODE_OPTIONS=--no-deprecation (or just NODE_OPTIONS=--no-deprecation if you don't care about Windows users) to your package.json scripts to fix this.
This is currently an issue with the node ecosystem, not payload, so we cannot fix this. Too many critical dependencies still depend on punycode like that


How to get a docker container's name or id from marathon rest api ?

Why the two api "GET /v2/apps/{app_id}" and "GET /v2/apps/{app_id}/tasks " don't provide docker container's name ?

See also #4692 - this is an often requested addition.


Add max available resolution and /or modes list as info property to camera class

I was just trying to programmatically find out the maximum resolution of the attached camera, but I didn't find any property with this information.
So I'd like to suggest an extra property like native_resolution or some such.
Also a list of available modes and their resolution/binning values would be nice so one could programmatically select the correct mode.

1- Maximum resolution depends on the camera module and GPU's capabilities. You can get it by :
from picamera import PiCamera
# this returns the MAX_RESOLUTION tuple
max_res = PiCamera.MAX_RESOLUTION

2 - Sensor modes are listed here.

@yalcinbar: I must have overlooked the "constant" for max resolution. I was looking for an attribute. My bad.
It is also not mentioned anywhere in the camera class api, only in one FAQ about preview flickers with the V2 camera, and of course the source code. Maybe this could be added to the documentation of the camera class.
for the sensor modes: I did find the mode tables, but it might be useful to have them accessible programmatically via the camera api.

Hmmm, that's a good suggestion. Probably needs similar logic to PiCamera.MAX_RESOLUTION (changes according to attached hardware) but I like the idea of a simple dict containing sensor modes mapped to resolutions and framerates (and perhaps other details).

In my opinion the resolution in the sensor mode should be a tuple containing width and height, not a string.


updated install guide

I have been trying to install koel on many platforms but always fail to do so
So, hereby I ask, if there is updated install guide, because I don't think that what is advertised on koel's page is up to date
Install guide should be from pretty much clean machine (I have no idea, why it says that PSR-3 logger does not exist). I couldn't install it despite fact being PHP developer who constantly uses composer and bower

@mikk150, can you please provide a little more info....

OS and version of Koel
At what point exactly does the installation fail?
and if possible, the full error message.

Cloning into '.'...
remote: Counting objects: 6723, done.
remote: Compressing objects: 100% (150/150), done.
remote: Total 6723 (delta 70), reused 0 (delta 0), pack-reused 6573
Receiving objects: 100% (6723/6723), 2.16 MiB | 1.25 MiB/s, done.
Resolving deltas: 100% (4312/4312), done.
Checking connectivity... done.
✔ /var/www/html/koel [master|✔]
$ git checkout v3.1.1
Note: checking out 'v3.1.1'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 3445a0a... Bump version
✔ /var/www/html/koel [v3.1.1|✔]
$ cp .env.example .env
✔ /var/www/html/koel [v3.1.1|✔]
$ nano .env
✔ /var/www/html/koel [v3.1.1|✔]
$ php artisan koel:init
PHP Warning:  require(/home/mikk/.www/html/koel/bootstrap/../vendor/autoload.php): failed to open stream: No such file or directory in /home/mikk/.www/html/koel/bootstrap/autoload.php on line 17
PHP Fatal error:  require(): Failed opening required '/home/mikk/.www/html/koel/bootstrap/../vendor/autoload.php' (include_path='.:/usr/share/php') in /home/mikk/.www/html/koel/bootstrap/autoload.php on line 17

This doesn't work of course because there is no autoloader
Let's try to fix it
$ git clone https://github.com/phanan/koel.git .
Cloning into '.'...
remote: Counting objects: 6723, done.
remote: Compressing objects: 100% (150/150), done.
remote: Total 6723 (delta 70), reused 0 (delta 0), pack-reused 6573
Receiving objects: 100% (6723/6723), 2.16 MiB | 1.31 MiB/s, done.
Resolving deltas: 100% (4312/4312), done.
Checking connectivity... done.
✔ /var/www/html/koel [master|✔]
$ git checkout v3.1.1
Note: checking out 'v3.1.1'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 3445a0a... Bump version
✔ /var/www/html/koel [v3.1.1|✔]
$ cp .env.example .env
✔ /var/www/html/koel [v3.1.1|✔]
$ nano .env
✔ /var/www/html/koel [v3.1.1|✔]
$ composer install
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. Run update to update them.

----
deleted whole bunch of lines
----

Generating autoload files
> php artisan clear-compiled
PHP Fatal error:  Uncaught exception 'ReflectionException' with message 'Class log does not exist' in /home/mikk/.www/html/koel/vendor/laravel/framework/src/Illuminate/Container/Container.php:738
Stack trace:
#0 /home/mikk/.www/html/koel/vendor/laravel/framework/src/Illuminate/Container/Container.php(738): ReflectionClass->__construct('log')
#1 /home/mikk/.www/html/koel/vendor/laravel/framework/src/Illuminate/Container/Container.php(633): Illuminate\Container\Container->build('log', Array)
#2 /home/mikk/.www/html/koel/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(674): Illuminate\Container\Container->make('log', Array)
#3 /home/mikk/.www/html/koel/vendor/laravel/framework/src/Illuminate/Container/Container.php(853): Illuminate\Foundation\Application->make('Psr\\Log\\LoggerI...')
#4 /home/mikk/.www/html/koel/vendor/laravel/framework/src/Illuminate/Container/Container.php(808): Illuminate\Container\Container->resolveClass(Object(ReflectionParameter))
#5 /home/mikk/.www/html/koel/vendor/laravel/framework/src/ in /home/mikk/.www/html/koel/vendor/laravel/framework/src/Illuminate/Container/Container.php on line 738
Script php artisan clear-compiled handling the post-install-cmd event returned with an error

  [RuntimeException]
  Error Output: PHP Fatal error:  Uncaught exception 'ReflectionException' with message 'Class log does not exist' in /home/mikk/.www/html/koel/vendor/laravel/framework/src/Illuminate/Container/Containe
  r.php:738
  Stack trace:
  #0 /home/mikk/.www/html/koel/vendor/laravel/framework/src/Illuminate/Container/Container.php(738): ReflectionClass->__construct('log')
  #1 /home/mikk/.www/html/koel/vendor/laravel/framework/src/Illuminate/Container/Container.php(633): Illuminate\Container\Container->build('log', Array)
  #2 /home/mikk/.www/html/koel/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(674): Illuminate\Container\Container->make('log', Array)
  #3 /home/mikk/.www/html/koel/vendor/laravel/framework/src/Illuminate/Container/Container.php(853): Illuminate\Foundation\Application->make('Psr\\Log\\LoggerI...')
  #4 /home/mikk/.www/html/koel/vendor/laravel/framework/src/Illuminate/Container/Container.php(808): Illuminate\Container\Container->resolveClass(Object(ReflectionParameter))
  #5 /home/mikk/.www/html/koel/vendor/laravel/framework/src/ in /home/mikk/.www/html/koel/vendor/laravel/framework/src/Illuminate/Container/Container.php on line 738

install [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--ignore-platform-reqs] [--] [<packages>]...

it never actually says to do npm install but I think it is required
so
$ git clone https://github.com/phanan/koel.git .
Cloning into '.'...
remote: Counting objects: 6723, done.
remote: Compressing objects: 100% (150/150), done.
remote: Total 6723 (delta 70), reused 0 (delta 0), pack-reused 6573
Receiving objects: 100% (6723/6723), 2.16 MiB | 1.31 MiB/s, done.
Resolving deltas: 100% (4312/4312), done.
Checking connectivity... done.
✔ /var/www/html/koel [master|✔]
$ git checkout v3.1.1
Note: checking out 'v3.1.1'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 3445a0a... Bump version
✔ /var/www/html/koel [v3.1.1|✔]
$ cp .env.example .env
✔ /var/www/html/koel [v3.1.1|✔]
$ nano .env
✔ /var/www/html/koel [v3.1.1|✔]
$ npm install
----
deleted whole bunch of lines
----
✔ /var/www/html/koel [v3.1.1|✔]
18:05 $ composer install
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. Run update to update them.
----
deleted whole bunch of lines
----
Generating autoload files
> php artisan clear-compiled
> php artisan optimize
Generating optimized class loader
Compiling common classes
> php artisan cache:clear
Application cache cleared!
> php -r "if (!file_exists('.env')) copy('.env.example', '.env');"
✔ /var/www/html/koel [v3.1.1|✔]
18:09 $ php artisan koel:init
PHP Fatal error:  Uncaught exception 'ReflectionException' with message 'Class log does not exist' in /home/mikk/.www/html/koel/bootstrap/cache/compiled.php:1333
Stack trace:
#0 /home/mikk/.www/html/koel/bootstrap/cache/compiled.php(1333): ReflectionClass->__construct('log')
#1 /home/mikk/.www/html/koel/bootstrap/cache/compiled.php(1287): Illuminate\Container\Container->build('log', Array)
#2 /home/mikk/.www/html/koel/bootstrap/cache/compiled.php(1837): Illuminate\Container\Container->make('log', Array)
#3 /home/mikk/.www/html/koel/bootstrap/cache/compiled.php(1388): Illuminate\Foundation\Application->make('Psr\\Log\\LoggerI...')
#4 /home/mikk/.www/html/koel/bootstrap/cache/compiled.php(1365): Illuminate\Container\Container->resolveClass(Object(ReflectionParameter))
#5 /home/mikk/.www/html/koel/bootstrap/cache/compiled.php(1351): Illuminate\Container\Container->getDependencies(Array, Array)
#6 /home/mikk/.www/html/koel/bootstrap/cache/compiled.php(1287): Illuminate\Container\Container->build('App\\Exceptions\\...', Array)
#7 / in /home/mikk/.www/html/koel/bootstrap/cache/compiled.php on line 1333

At this point, I am stuck, appearently it want's PSR-3 logger?
I have never used Laravel or any other PSR compatible framework (Yii2 isn't PSR)

I believe that this might be caused when there is something mis-configured in your .env file.
@phanan, composer install & npm install are indeed missing from the WIKI, on the website as well it only lists composer install as part of the install process.

only thing I can see is APP_DEBUG=true
May it be because your composer.lock file is somehow older than composer.json(this should never happen??)!

only thing I can see is APP_DEBUG=true

That should be fine.
the composer.lock should be used not the composer.json.
Can you paste a copy of your .env file? replace any sensitive data with example data.

@phanan, composer install & npm install are indeed missing from the WIKI, on the website as well it only lists composer install as part of the install process.

npm install is part of koel:init command. So only composer install is missing, if that is the case.

here is my .env
APP_ENV=production
APP_DEBUG=true
APP_URL=http://localhost/koel

# If you want to use Amazon S3 with Koel, fill the info here and follow the
# installation guide at https://github.com/phanan/koel-aws.
AWS_ACCESS_KEY_ID=
AWS_SECRET_ACCESS_KEY=
AWS_REGION=

# Database connection name, which corresponds to the database driver.
# Possible values are:
#   mysql (MySQL/MariaDB - default)
#   pgsql (PostgreSQL)
#   sqlsrv (Microsoft SQL Server)
DB_CONNECTION=mysql
DB_HOST=localhost
DB_DATABASE=koel
DB_USERNAME=koel
DB_PASSWORD=koel

# A random 32-char string
APP_KEY=KbbXdjgYsTL3syHskuB63eHmeKfLXhPX

# Another random 32-char string
JWT_SECRET=HWUXdMjQXeSqMXnnFszfHuBw9Zfk6WVZ

# Username and password for the initial admin account
# This info will be populated into the database during `php artisan db:seed`
# After that, it can (and should) be removed from this .env file
<EMAIL_ADDRESS>ADMIN_NAME=Mikk Tendermann
ADMIN_PASSWORD=lèpassword

# The maximum scan time, in seconds. Increase this if you have a huge library.
# Note: This setting doesn't have effect when scanning via koel:sync.
APP_MAX_SCAN_TIME=600

# The streaming method.
# Can be either 'php' (default), 'x-sendfile', or 'x-accel-redirect'
# See https://github.com/phanan/koel/wiki#streaming-music for more information.
# Note: This setting doesn't have effect if the media needs transcoding (e.g. FLAC).
STREAMING_METHOD=php

# If you want Koel to integrate with Last.fm, set the API details here.
LASTFM_API_KEY=
LASTFM_API_SECRET=

# You can also configure Koel to use a CDN to serve the media files.
# This url must be mapped to the home URL of your Koel's installation.
# No trailing slash, please.
CDN_URL=

# If you want to transcode FLAC to MP3 and stream it on the fly, make sure the
# following settings are sane.

# The full path of ffmpeg binary.
FFMPEG_PATH=/usr/local/bin/ffmpeg

# The bit rate of the output mp3 stream. Higher value results in better quality,
# but slower streaming and more bandwidth.
OUTPUT_BIT_RATE=128

# Whether to allow song downloading.
# Note that if you're downloading more than one song, Koel will zip them up
# using PHP's ZipArchive. So if the module isn't available in the current
# environment, such a download will (silently) fail.
ALLOW_DOWNLOAD=true

# The variables below are Laravel-specific.
# You can change them if you know what you're doing. Otherwise, just leave them as-is.

CACHE_DRIVER=file
SESSION_DRIVER=file
QUEUE_DRIVER=sync

MAIL_DRIVER=smtp
MAIL_HOST=mailtrap.io
MAIL_PORT=2525
MAIL_USERNAME=null
MAIL_PASSWORD=null
MAIL_ENCRYPTION=null

ADMIN_NAME=Mikk Tendermann

The ADMIN NAME should not have a space in it.

That's correct. Or, just wrap it inside quotes ;) Thanks @bdgold.

Hi @phanan, is there an updated guide?
I am working on a Chef cookbook for this just to make it simple and truth be told still struggling with "ErrorException in Application.php line 50:
file_get_contents(/home/rhauteki/koel/public/build/rev-manifest.json): failed to open stream: No such file or directory (View: /home/rhauteki/koel/resources/views/index.blade.php)"
Right now trying it with node 6.0.0 in case it doesn't work with the newer version.
Thanks,

Please see https://github.com/phanan/koel/wiki/Troubleshooting.

Locking to avoid digging up old, closed, issue. If you believe there's a different bug, please open a new issue instead.


Update/Add JEWEL logo

This PR:

Updates the existing logo for the old, deprecated version of the JEWEL token (0x4f60a160D8C2DDdaAfe16FCC57566dB84D674BD6)
Adds the logo for the new version of the JEWEL token (0x997Ddaa07d716995DE90577C123Db411584E5E46)

After merging #945, this has a merge conflict now - please resolve.

After merging #945, this has a merge conflict now - please resolve.

Will do. We'd gotten a request via TG to add a greyscale logo for the old token, but it looks like #945 removed the old version entirely. What's the preference? Have both and use greyscale on the old, or only include the new?

Didn't realise that. Preference would be to have greyscale of the old one please!

@cryptofish7 Should be good now. Thought the force would only impact my fork, but if this approach creates even more conflicts, I can just re-do it from scratch. Thanks!


Support Download remote file to local with Vscode remote extension

Please give more details and file this in the vscode-remote-release repo.


[theme] Can't override palette mode in a nested theme

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Extending a nested ThemeProvider theme from the outer (inital) theme and passing a different palette mode doesn't get picked up by it's children components
<ThemeProvider
  theme={(theme) => ({
    ...theme,
    palette: {
      ...theme.palette,
      mode: 'dark'
    }
  })}
>
  // INFO: children don't switch to **dark** mode
  {children}
</ThemeProvider>

Expected behavior 🤔
Components tree nested inside an inner (nested inside a different ThemeProvider) ThemeProvider with a different theme from the outer (initial) one should pick up the closest parent theme Context.
Steps to reproduce 🕹
Steps:

Open this CSB
Notice the whole app is wrapped with a ThemeProvider with the default theme mode set to "light"
Notice the Drawer element in the Content component wrapped in a ThemeProvider with the nested theme extended from the outer one and the palette mode is set to "dark"
In the app, see the Drawer children elements are barely visible as they're displayed in the "light" mode.

Context 🔦
I'm trying to display a hybrid theme while the app palette mode is set to "light", so that the Drawer element and it's children are displayed correctly in the "dark" palette mode so provide an accessible UI.
Here's a basic unrelated example for a hybrid dashboard theme:

Your environment 🌎

`npx @mui/envinfo`
  System:
    OS: macOS 12.3
  Binaries:
    Node: 17.5.0 - ~/.nvm/versions/node/v17.5.0/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v17.5.0/bin/yarn
    npm: 8.4.1 - ~/.nvm/versions/node/v17.5.0/bin/npm
  Browsers:
    Chrome: 98.0.4758.102 (Official Build, ungoogled-chromium) (arm64)
    Edge: Not Found
    Firefox: 100.0b3 (64-bit)
    Safari: 15.4
  npmPackages:
    @emotion/react: latest => 11.9.0
    @emotion/styled: latest => 11.8.1
    @mui/base:  5.0.0-alpha.75
    @mui/icons-material: 5.6.0 => 5.6.0
    @mui/material: latest => 5.6.0
    @mui/private-theming:  5.6.0
    @mui/styled-engine:  5.6.0
    @mui/system:  5.6.0
    @mui/types:  7.1.3
    @mui/utils:  5.6.0
    @types/react:  18.0.1
    react: latest => 18.0.0
    react-dom: latest => 18.0.0
    typescript: latest => 4.6.3

This is not a bug from Material UI but rather a misuse of the ThemeProvider. It does not work because the whole palette has been calculated at the top ThemeProvider.
<ThemeProvider theme={createTheme({
  palette: {
    mode: paletteMode,
    primary: {
      main: "#f06522"
    },
    secondary: {
      main: "#202a38"
    }
  }
})}>
  ...
  <ThemeProvider
    // this theme contains all `light` palettes from the above createTheme()
    // the code below does not generate `dark` palettes, but just passing the `light` palette down the tree.
    // that's why it does not work.
    theme={(theme) => ({
      ...theme,
      palette: {
        ...theme.palette,
        mode: 'dark'
      }
    })}
  >
    // INFO: children don't switch to **dark** mode
    {children}
  </ThemeProvider>
  ...
</ThemeProvider>

To fix it, you have to recreate the theme. It can be something like this:
<ThemeProvider
  theme={(theme) => createTheme({
    ...theme,
    palette: {
      // DO NOT spread the theme.palette like this:
      // ...theme.palette, because all the light palette will be used instead.
      mode: 'dark',
      primary: {
        main: "#f06522"
      },
      secondary: {
        main: "#202a38"
      }
    }
  })}
>
  // INFO: children don't switch to **dark** mode
  {children}
</ThemeProvider>

Here is the fix > https://codesandbox.io/s/unruffled-platform-7x1yuh?file=/src/Demo.tsx

Alright, makes sense, thank you!
I guess, I got confused by the fact that your receive the outer theme as a callback argument of the ThemeProvider theme prop.
theme={theme => ({ ... })}

I think it is worth adding to this page. https://mui.com/material-ui/customization/dark-mode/#main-content

Yea, sounds good! Some example of actually merging the 2 themes and the overrides


Host box in git LFS

I'm unsure if this is feasible, but perhaps the box could be committed and hosted using git LFS (Large File Store).
It could provide a more available location to host the box.

Github LFS is a paid feature, all box versions is about 45 Gb in size and they consume around 1 000 Gb in traffic.

I hadn't realized it was paid; understandable but seems prohibitive.


Question/feature: How to change default styling?

Hello,
I really like your component.
I wonder how we can change the default styling (color, button styling etc)
thx,
Filip.

In fact I would like to let it match with the look and feel of quasar

You should try v4 (beta) then modify the scss, and then include your own.


Loosen ice_cube version dependency

Any reason why the gemspec pins ice_cube to ~> 0.13.0? Can this perhaps be changed to <1 to ensure minor upgrades? Ice_cube 0.15.0 is now available https://github.com/seejohnrun/ice_cube/blob/master/CHANGELOG.md

With https://github.com/icalendar/icalendar-recurrence/pull/16, you should now be able to use the latest version of ice_cube.


$ZERO is polluted

I was trying to follow your https://zdharma.org/Zsh-100-Commits-Club/Zsh-Plugin-Standard.html, and I used:
MYDIR="${${ZERO:-${0:#$ZSH_ARGZERO}}:-${(%):-%N}}"
MYDIR="${${(M)MYDIR:#/*}:-$PWD/$MYDIR}"

However, your own plugins pollute $ZERO with their own directory, and so this fails (using the antibody plugin manager):
echo 1 $0
echo 2 ${0:#$ZSH_ARGZERO}
echo 3 ${(%):-%N}
echo 4 $ZERO
echo 5 $PWD

❯ antibody bundle https://github.com/NightMachinary/core.zsh
1 /Users/evar/Library/Caches/antibody/https-COLON--SLASH--SLASH-github.com-SLASH-NightMachinary-SLASH-core.zsh/core.plugin.zsh
2 /Users/evar/Library/Caches/antibody/https-COLON--SLASH--SLASH-github.com-SLASH-NightMachinary-SLASH-core.zsh/core.plugin.zsh
3 /Users/evar/Library/Caches/antibody/https-COLON--SLASH--SLASH-github.com-SLASH-NightMachinary-SLASH-core.zsh/core.plugin.zsh
4 /Users/evar/Library/Caches/antibody/https-COLON--SLASH--SLASH-github.com-SLASH-zdharma-SLASH-zbrowse/zbrowse.plugin.zsh
5 /Users/evar/Base/_Code/zsh/plugins/core.zsh

I also had to get the basename to get this to work:
MYDIR="${${0:#$ZSH_ARGZERO}:-${(%):-%N}}"
MYDIR="${${(M)MYDIR:#/*}:-$PWD/$MYDIR}"
if ! test -d "$MYDIR" ; then
    MYDIR="${MYDIR:h}"
fi

Hi.
I've fixed the Zbrowse plugin. Thanks.


color against my eye!!!!!!

Your Windows build number:

Microsoft Windows [版本 10.0.18362.116]

What you're doing and what's happening:

just use wsl shell in jetbrain IDE(Idea pycharm goland..)

What's wrong / what should be happening instead:

after upgrade win10 to current version. then
strange color config when typed bash in the console.

can you see what I typed in the bash console?????????
but is works well in win+r -> cmd -> bash orwin+r -> bash
what I can do , or where I can restore the config?
ide just conf like this ,and no more conf can be set.

If this is a console issue (a problem with layout, rendering, colors, etc.), please post to the console issue tracker.


fix/multiple classnames

Description
In some cases, we want to be able to pass multiple class names like so 'list first second'. However, this is making an error because classList.add doesn't support space.
This PR attempts to implement allowing multi-class configs for all elements across the board by allowing to pass an array of strings for classNames.
It takes into account feedbacks from PR#907 submitted by @mikebronner
Fix #832 #889
Types of changes

[ ] Chore (tooling change or documentation change)
[ ] Refactor (non-breaking change which maintains existing functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] My code follows the code style of this project.
[ ] I have added new tests for the bug I fixed/the new feature I added.
[x] I have modified existing tests for the bug I fixed/the new feature I added.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Thanks for this! Can you merge the latest version of master into this branch? After that I will review it.

Thanks for this! Can you merge the latest version of master into this branch? After that I will review it.

Done ;-)

I have a feeling that when @mtriff will get back to this, @gaetan-hexadog will need to merge latest master once again 🤣

@mtriff let me know when you'll be able to merge this PR so I can merge the latest version of master before (don't want to do it if you're not going to merge it quickly) ;-)

Hey, does anyone know when this PR will be merged?

+1

+1

+1

Please come  back, we need the multiple class override, thx

We need this

@gaetan-hexadog Whats with this?

@gaetan-hexadog Whats with this?

No news from the repo'd owner. I won't work on it for the third time if I don't have the insurance it will be merged quickly.
Feel free to use my PR if you want.

There should be a protocol for when the owner stops responding for more than a year...

Thanks! Implemented as part of #1166


Update homebridge-lib

Hello,
Just a simple question.
I have this on my log :
Warning: latest version: homebridge-lib v5.3.2.
Do you know how I can update it ?
Thanks a lot

Usually: update the plugin that uses homebridge-lib.

I have no plugin available for update. That’s why I was asking.
The plugin that said homebridge-lib has an update is homebridge-deconz.

Hm, I did update the dependencies, but haven’t yet cut a new version.  Will have a look later this week.

I have the same problem with homebridge-rpi plugin installed, no update in the plugin and I am getting:
[RPi] warning: latest version: homebridge-lib v5.4.0
I guess can be ignored until the next rpi plugin update


pull request for e2e test at 01/11/2017 09:15:15

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Function calls with scalar literals do not work

It seems that passing literal constants to functions does not work, e.g.
@gtscript.function
def max(x,y):
    if x > y:
        return x
    else:
        return y
...
    with computation(PARALLEL), interval(...):
          out_field = max(5., 10.)

It is unclear to me, from all I know @gtscript.function subroutines are meant for working on fields. They can take scalar constants but in the documentation they only occur as optional arguments (with a default value). Possibly that could work, but there should be a way to use purely scalar functions without having to make them gtscrip.functions.

This comes from a code which uses the same function once for a scalar and once for a field. It would be awkward to have to implement the same function twice, no?

yes, however thinking about performance, you don't want to repeat the same scalar operation for every grid point. So it might make more sense to calculate this outside the stencil and stick it into the externals. Unless the example is simplified and what you really want to do is more dynamic?

To me it looks like the function call with constant arguments makes sense and it should be allowed. In terms of performance, I think an advanced analysis pipeline should be able to detect that this is a constant operation and thus optimize the code without the user caring about it.

Agreed. If called with scalar arguments compiler with -O3 can detect this and evaluate compile time and store the result. Similar to...
const float pi = 2. * math::asin(1.);

Note: This is probably related to https://github.com/GridTools/gt4py/issues/103, if the literal arguments are interpreted as temporaries the call would be legal and it would be up to the optimizer to make them scalars.

The following code compiles and generates code that looks correct with the GTC backends, so I'll close this. Let us know if you still have issues and we can re-open.
from gt4py import gtscript
import numpy as np

@gtscript.function
def func(a, b):
    return a + b

@gtscript.stencil(backend="gtc:gt:cpu_ifirst")
def stencil(
    input_field: gtscript.Field[gtscript.IJK, np.int32],
    output_field: gtscript.Field[gtscript.IJK, np.int32],
):
    with computation(PARALLEL), interval(...):
        if input_field > 0.0:
            output_field = func(input_field, 1)
        else:
            output_field = input_field


Go Packages issues are not resolving in RHEL 9.4

Go version
<EMAIL_ADDRESS>Output of go env in your module/workspace:
Successfully installed and built image.
What did you do?

Type: dockerImage
ImageID: sha256:ea32b10fdeade0ab4cfb3caeacc876616a50b5b5b2618bca3ef3b5b6c6866625
Digest: localhost/mariadb_ops_image@sha256:67483b8d99cb10e1cde702a68a57d1edda38ec965baf79f5ff715b4f2c06708a
BaseOS: redhat 9.4
PullString: ea32b10fdead
1492 vulnerabilities found
0 Critical (0 fixable)
20 High (15 fixable)
570 Medium (8 fixable)
891 Low (14 fixable)
11 Negligible (0 fixable)
                  PACKAGE                        TYPE     VERSION       SUGGESTED FIX     CRITICAL  HIGH  MEDIUM  LOW  NEGLIGIBLE  EXPLOIT

golang.org/x/net                                  golang    v0.20.0          v0.23.0           0       1      0      0       0          0
github.com/Azure/azure-sdk-for-go/sdk/azidentity  golang     v1.4.0           v1.6.0           0       0      1      0       0          0
                                                            POLICIES EVALUATION
Policy: Vzsec - Image Scanning Policy (Criticals and Highs with fix > 30 days) FAILED (1 failures - 0 risks accepted)

Policies evaluation FAILED at 2024-07-03T03:36:29Z
What did you expect to see?
I don't want to see the Golang package's vulnerabilities in scan results after installing via Dockerfile.

This doesn't sound like an issue with the Go project.
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions


[Feature Request] Add Master Frame/Template functionality similar to PowerPoint master slides

Problem Description
When creating multiple frames in Excalidraw+, there's currently no way to maintain consistent elements (like logos, headers, footers) across all frames. Each element needs to be manually copied and placed in each frame individually.
Proposed Solution
Implement a master frame/template feature similar to PowerPoint's master slides, where:

Users can define a master frame with common elements
All new frames automatically inherit these elements
Updates to master elements reflect across all frames
Option to override master elements in specific frames if needed

Use Cases

Adding company logos to all frames in a presentation
Maintaining consistent header/footer information
Applying common background elements or watermarks
Ensuring brand consistency across multiple frames

Benefits

Saves time in creating consistent multi-frame documents
Reduces manual work when updating common elements
Ensures consistency across all frames
Makes it easier to maintain brand guidelines

Makes sense to consider adding an "automatic" template.

Each element needs to be manually copied and placed in each frame individually.

Copying the whole frame automatically copies all the child elements inside. Hence for now, you can create a "master frame" manually and copy/paste the whole frame as many times as you want (without copying and placing each child element into each frame manually).

Thanks for the info! In my specific case, when I finish all my slides, I might want to update the logo or other elements across all slides. Currently, I have to make the edits for each frame individually. It would be great if I could just make the change in the "master frame," which would then sync to all other frames.

Yeah, agreed
cc @barnabasmolnar @maielo


Fix/197 mute camera div always displayed

lgtm, maybe just remove the yarn.lock & add it to gitignore?

done @HugoGresse  :)


Incremental search does not work

Godot version:
Latest master built from source. SHA: 42569f566

OS/device including version:
macOS Mojave (10.14), MacBook Air from mid 2012

Issue description:
Incremental search does not work. However, it has never worked on my machine so it's not a regression. I've tried in the file tree, the scene tree and the tree for adding new nodes. Pressing any key (a-zA-Z) does nothing.
Expected: That the first item starting with the corresponding character was selected when pressing a key.

Steps to reproduce:
Open the project manager and click "Scan". Focus the file dialog tree. Press the key corresponding to the first character of a file or directory shown.
Minimal reproduction project:
N/A

Observations:
If I change the existing code (https://github.com/godotengine/godot/blob/master/scene/gui/tree.cpp#L2385-L2394) to the following code, I get functional incremental search (although it seems bit quirky but I guess that's how it's implemented).
if (k->get_unicode() > 0) {

    _do_incr_search(String::chr(k->get_unicode()));
    accept_event();

    return;
} else if (k->get_scancode() > 0) { // this part is new

    _do_incr_search(String::chr(k->get_scancode()));
    accept_event();

    return;
} else {
    if (k->get_scancode() != KEY_SHIFT)
        last_keypress = 0;
}

This is probably not the right fix (I also get a crash after doing incremental searches in a few different directories) but may give some clue. When I press 'p', unicode is 0 in k while scancode is 80.

I reported the crash in https://github.com/godotengine/godot/issues/29441.

Related to #28224, get_unicode() always return zero unless IME input node is activated.

My issue is fixed by #29464.
Thanks @bruvzg! 🥇


GlobalErrorPlugin: throttle firing of generic notification

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

16 of 16 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.587%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
12053

Relevant Lines:
12057

💛  - Coveralls


sntp: fix the handling of the rtc counter wrapping

This reworks the accounting of the time to address the wrapping of the
rtc counter. It currently assumes that the time is accessed more
frequently than the counter would wrap. It also adds a semaphore to
synchronize access to the time storage.

Thank you for the feedback. Changed the semaphore to be static.
I have since tried other ways to improve this code and think more could be done, but this PR fixes some significant issues. Fwiw I found the RTC and/or the calibrations to be rather unstable and gave up on using sntp for obtaining times for a data logging application and will log the rtc count and the calibration and have the time estimated when analysing the data.

Just add a bit more. I also tried to use the sntp times to estimate the calibration, and only using the internal calibration to reset this if the time step was large. The corrections to the calibration were filtered and it did converge to give a lot better time than just using the internal calibration. However, it still received impulse errors larger than a second and then took time to settle. When there was a network outage it drifted significantly - the error had typically not settled so it had little chance.
I guess it needed to also take into account the jitter etc. Also resetting the time with each sntp response causes jumps in the time, and these can be backwards, so I think that is the wrong approach. When the time difference is within a small bounds it should probably just be making small periodic adjustments to avoid jumps and to avoid going backwards. Surely there is a lot of state-of-the-art NTP code that could be followed.
For my application at hand it seemed to be less demanding on the node to just log the times when the node interacts with the server etc, and it might even have GPS events logged with a time etc in some deployments. A smooth time line might then be fitted to the events during analysis.

Thanks for this fix and the comments. I think the suggestions you make sound sensible, although I agree that for a lot of purposes this is good enough.
I'm keen to merge this, but I just want to check first if @doragasu - who contributed the original SNTP implementation - has any comments.

I had a quick look and it looks good, thanks for the work! I already knew that synchronizing access to time keeping structures was needed, but wasn't brave enought to try because I don't know newlib internals, and I thought that it provided a built-in synchronization mechanism (instead of having to use semaphores). But after reading your patch, I suppose that's not the case.
Other than that, I'd like to throw a comment. Inside sntp_update_rtc() you are reading the timer value after xSemaphoreTake(). I think the order should be reversed, so the instant you read the timer is as close as possible to the instant the SNTP server sends you the updated time. Have in mind that as the semaphore might block, reading the timer after taking the semaphore might introduce very big differences.
If I get some time I'll try reviewing the code more in-depth and testing it.

Thank you for the feedback. @doragasu the mutex protects the state that handles the counter wrapping to, so if the RTC counter were read before taking the mutex then another task might win a race to update the tim_ref in sntp_get_rtc_time() in which case the time difference in sntp_update_rtc would be negative which is not handled there. It might need some more design work.

@iosen I understand, thanks for explaining. If I read the timer inside sntp_update_rtc(), then after I enter the critical section, the timer wraps and sntp_get_rtc_time() gets executed, tim_ref will be updated and when finally sntp_update_rtc() enters the critical section, things will go nuts.
OK, having that cleared, I have absolutely no problem with the changes, they look good to me.
BTW, when I did some tests of the implementation accuracy, I saw that it is heavily dependent on the network you use. When I did tests at my worplace, I got much lower correction values each time SNTP was updated that when I did the same tests at home (my home network is slower and has greater ping). As SNTP does not take RTT into account, I suppose this is expected.
I don't think it makes too much sense trying to improve this implementation accuracy: if you want better accuracy maybe the correct thing would be implementing a full blown NTP client.

@doragasu See https://github.com/SuperHouse/esp-open-rtos/pull/157 for an alternative design which seems to be more stable. The results of sdk_system_rtc_clock_cali_proc() seem so noisy here that it is not great for calibration.

About the accuracy of the algorithm, I was looking at the relevant RFC4430 and in section5 there is a simple algorithm that compensates for the round trip time of the packets.
I've hacked together a proof of concept and it seems to work well here: I converted every timestamp to int64_t and changed sntp_update_rtc() to take an int64_t offset instead.
However I deeply changed also the source of sntp.c because it's a mess of #ifdefs and I wanted to understand the code before doing anything, so I'm afraid the changed I made are not directly appliable.

After a lot of experiments this is how it converges with an update interval of 15 sec (Delay and Offset are in usecs):
Delay: 33945, Offset:<PHONE_NUMBER>, Cali: 25804
Delay: 33737, Offset: 13475, Cali: 25827
Delay: 36122, Offset: 9730, Cali: 25843
Delay: 14981, Offset: 186, Cali: 25843
Delay: 17382, Offset: 5573, Cali: 25852
Delay: 15722, Offset: 3952, Cali: 25858
Delay: 15534, Offset: 167, Cali: 25858
Delay: 15403, Offset: 6756, Cali: 25869
Delay: 15337, Offset: 1585, Cali: 25871
Delay: 16062, Offset: -417, Cali: 25871

While the offsets become very small it seems to me that the embedded RTC is quite unstable. The calibration value keeps increasing and still cannot compensate the offsets; and then suddenly the same calibration value is too big.
With longer update intervals the situation gets worse.
Besides my code updates the RTC.SCRATCH[0..1] locations directly so the clock is not monotonic. I tried to adjust gradually but with those fluctuations it doesn't really work.
For the record this is how the sntp_update_rtc() function looks right now:
void sntp_update_rtc(int64_t offset)
{
	static uint32_t last_cal_tim = 0;

	xSemaphoreTake(sntp_sem, portMAX_DELAY);
	uint32_t tim = RTC.COUNTER;
	uint32_t diff = tim - tim_ref;
	tim_ref = tim;

	uint64_t diff_us = ((uint64_t)diff * sntp_cali) >> 12;
	sntp_base = sntp_base + diff_us + offset;
	if (-100000 < offset && offset <= 100000) {
		sntp_cali += offset * 4096 / (tim - last_cal_tim);
	}
	last_cal_tim = tim;

	xSemaphoreGive(sntp_sem);
}

I see there is a fix for the race conditions in the sntp_fun, but nobody merged them?
is the SuperHouse/esp-open-rtos EndOfLife or could you please merge this?


Web Crawler

Decide on how corpus will be generated and how web crawler will act.

Today we talked about using curl, grep, and awk/sed in the shell to build a simple crawler.
Here's a snippet we came up with.
curl -i https://www.cnn.com | grep -Eo '*\/[0-9]{4}\/[0-9]{2}\/[0-9]{2}\/[a-z/-]+.html' |  awk '$0="https://www.cnn.com"$0'
I recommend you build a shell script that uses this logic, in a recursive manner, to go to n depth into each root level link. The final output should be a text file that we can eventually feed into the crawler.

Also, remember that you were using a different regular expression than I was. It might be a good idea to post it here.

(((http|https)://www.cnn.com/[0-9]{4}/[0-9]{2}/[0-9]{2}/[a-z/-]+.html)|(/[0-9]{4}/[0-9]{2}/[0-9]{2}/[a-z/-]+.html))

solved in #21 merged in #22.


Fix Pick type

Current version of pick works incorretly for interfaces with symbols
TypeScript Version:  3.5.1
type Arr = [1, 2];

type CorrectPick<T, K extends keyof T> = {[P in keyof T]: P extends K ? T[P] : never};
const p1: Arr = [] as any as Pick<Arr, keyof Arr>; // error
const p2: Arr = [] as any as CorrectPick<Arr, keyof Arr>; //ok

type CorrectOmit<T, K extends keyof T>= CorrectPick<T, Exclude<keyof T, K>>;
const o1: Arr = [] as any as Omit<Arr, never>; // error
const o2: Arr = [] as any as CorrectOmit<Arr, never>; //ok

playground

But this would fail when mixing number/string keys

but this example could be handled with modified version:
type CorrectPick<T, K extends keyof T> = {[P in keyof T]: Record<P, any> extends Record<K, any>  ? T[P] : never};

const a1: Pick<[1], 0> = [1];
const a2: CorrectPick<[1], 0> = [1];

const a3: Pick<[1], "0"> = [1];
const a4: CorrectPick<[1], "0"> = [1];

I wouldn't call what you're doing Pick anymore. If you try to assign a value to a type with required never-valued properties, you're gonna have a bad time:
interface A { a: string, b: number };
const a: Pick<A, "a"> = { a: "hey" }; // okay
const b: CorrectPick<A, "a"> = { a: "hey" }; // error?

There might be some merit in your CorrectPick type, but it would absolutely break all kinds of everything if we were to replace Pick with it.

But what are you trying to do here?  You mention symbols, but I don't think there's a problem with mapping symbols.  The problem I think you're having here is that mapping arrays/tuples to arrays/tuples is brittle when you map over a subset of the keys.  I don't know if that's fixable, though.

+2 for “you’re gonna have a bad time” and “break all kinds of everything”.

We can't touch these definitions with a feather without breaking tons of code. Pick is Pick; use your own if you want behavior other than what the existing definition provides.


Reduce BDD test running time by selectively starting containers as needed

The BDD tests run three times - one for each supported storage solution. Each time starts up CouchDB and MongoDB and restarts all containers. This should be refactored so that containers are only started as needed and the whole flow isn't repeated unnecessarily.

Wrong repo - I meant to open this in https://github.com/trustbloc/edv


MM-28362 : Implement Progressive Image Loading in Webapp

Summary
Implement Progressive Image Loading
I didn't use any transition animation as there wasn't any for placeholder to image one.
Ticket Link

Fixes  https://github.com/mattermost/mattermost-server/issues/15641
Fixes https://mattermost.atlassian.net/browse/MM-28362
Screenshots

https://user-images.githubusercontent.com/60970/194752364-64704b8a-8296-4148-a6d7-2ce82b1f4ee8.mov
Release Note

Implemented Progressive Image Loading in Webapp

Hello @KuSh,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/250111

Thanks @KuSh
Some e2es are failing, see full report here
Town Square is not accessible after posting this https://cdn.pixabay.com/photo/2017/10/10/22/24/wide-format-2839089_960_720.jpg

Thanks @KuSh Some e2es are failing, see full report
Town Square is not accessible after posting this https://cdn.pixabay.com/photo/2017/10/10/22/24/wide-format-2839089_960_720.jpg

Hi and thanks @jgilliam17
I've pushed a fix for the inaccessible one. I also did check e2e failing tests but I don't think any one is related to my PR.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Hi @KuSh apologies for the delay, I missed the mention
I'll update, re-test and re-run the e2es

Error trying to update the PR.
Please do it manually.

@KuSh can you please update; update failed on my end - thanks

Hi @KuSh apologies for the delay, I missed the mention I'll update, re-test and re-run the e2es
No problem at all!

@KuSh can you please update; update failed on my end - thanks
Sure!

Thanks @KuSh
Tested, looks good to merge.
E2E report - no PR related failures.

Hi @KuSh
You were selected as one of our Top Contributors for Hacktoberfest!
Please fill out this form to select your swag as thanks!
Thank you for all you do and for making Mattermost even better!


Use individual temp dir for each build task on dl_srcpkg

Purpose of pull request
Enhance function of source package install into SDK.

Modify to use individual temporary directory for each build task.
Cleanup temporary directory
Optimize resolv.conf manipulation in SDK chroot

Test
How to test
To install source packages into SDK, add following line into the local.conf.
INHERIT += "dl-srcpkg"

And then type following build command.
$ bitbake emlinux-image-base -c populate_sdk

Test result

Confirm /tmp/srcdirhome* directory is not exist after build.

$ ls /tmp/srcdirhome*
ls: cannot access '/tmp/srcdirhome*': No such file or directory

@Seongook-CHOI-ML thank you.


Unable to run a single .bal file from inside a project root dir

Description:
Consider the following project dir tree.
 .
├── Ballerina.toml
├── test
   └── foo
       ├── ballerina.conf
       └── test.bal

When trying to run the test.bal file from the project dir the following error is given.
ballerina: cannot find file 'test/foo/test.bal'

However, if I try to run it from inside the /test dir, it runs fine.
Is this the expected behaviour? If not, shall we improve the error message given in this case, since it's not actually a file not found error.

This is the expected behavior AFAIK since test is considered as a package.

But if I really want to just run a single file, then I can't do it from the project root dir. Doesn't that seem a bit restrictive?
However, if that is the expected behaviour, then we should not be saying cannot find file. WDYT?

It seems bit restrictive, but the other alternative is to place the file directly in the root directory.
We definitely need to change the error message. It is misleading.