fix: Make toJson and fromJson always compatible

Closes: #2149
Pre-launch Checklist

[x] I read the Contribute page and followed the process outlined there for submitting PRs.
[ ] This update contains only one single feature or bug fix and nothing else. (If you are submitting multiple fixes, please make multiple PRs.)
[x] I read and followed the Dart Style Guide and formatted the code with dart format.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///), and made sure that the documentation follows the same style as other Serverpod documentation. I checked spelling and grammar.
[ ] I added new tests to check the change I am making.
[x] All existing and new tests are passing.
[ ] Any breaking changes are documented below.

Key changes in this PR:

Renamed the toJson method to toJsonForProtocol. This method serializes fields specifically suited for protocol communication.
Renamed the allToJson method to toJson. This new toJson method serializes all fields, including those not serialized by the toJsonForProtocol method.
Removed toJsonForProtocol from the SerializableEntity. It is now part of the ProtocolSerialization interface and will only be implemented by models that require the toJsonForProtocol method.

It's important to note that the old toJson method only serialized fields for protocol communication, whereas the new toJson method will serialize all fields.

Key changes in this PR:

Renamed the toJson method to toJsonForProtocol. This method serializes fields specifically suited for protocol communication.
Renamed the allToJson method to toJson. This new toJson method serializes all fields, including those not serialized by the toJsonForProtocol method.
Removed toJsonForProtocol from the SerializableEntity. It is now part of the ProtocolSerialization interface and will only be implemented by models that require the toJsonForProtocol method.

It's important to note that the old toJson method only serialized fields for protocol communication, whereas the new toJson method will serialize all fields.


Add generation number to data and queries

Description
Add generation number to data and queries, so when we do comp test during rolling update, we can ingest data with different generation and query against that generation.
A good description should include pointers to an issue or design document, etc.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release.
If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text
Documentation
If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document

Codecov Report

Merging #6638 (aa5e940) into master (1beaab5) will decrease coverage by 0.63%.
The diff coverage is 62.64%.

@@            Coverage Diff             @@
##           master    #6638      +/-   ##
==========================================
- Coverage   66.44%   65.81%   -0.64%
==========================================
  Files        1075     1360     +285
  Lines       54773    66535   +11762
  Branches     8168     9698    +1530
==========================================
+ Hits        36396    43787    +7391
- Misses      15700    19622    +3922
- Partials     2677     3126     +449

Flag
Coverage Δ

unittests
65.81% <62.64%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/broker/api/resources/PinotBrokerDebug.java
0.00% <0.00%> (-79.32%)
:arrow_down:

...pinot/broker/api/resources/PinotClientRequest.java
0.00% <0.00%> (-27.28%)
:arrow_down:

...ot/broker/broker/AllowAllAccessControlFactory.java
71.42% <ø> (-28.58%)
:arrow_down:

.../helix/BrokerUserDefinedMessageHandlerFactory.java
33.96% <0.00%> (-32.71%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ava/org/apache/pinot/client/AbstractResultSet.java
66.66% <ø> (+9.52%)
:arrow_up:

...n/java/org/apache/pinot/client/BrokerResponse.java
100.00% <ø> (ø)

.../main/java/org/apache/pinot/client/Connection.java
35.55% <ø> (-13.29%)
:arrow_down:

...org/apache/pinot/client/DynamicBrokerSelector.java
82.85% <ø> (+10.12%)
:arrow_up:

...n/java/org/apache/pinot/client/ExecutionStats.java
68.88% <ø> (ø)

... and 1243 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6bb2c9...aa5e940. Read the comment docs.


Fix remove team member

Notion card
https://www.notion.so/saeloun/After-removing-a-team-member-from-an-organization-the-user-is-stil-able-to-login-54138da1e64540298474ca5eb2b4e04d
Summary
Currently, if we remove team member then also that member is able to do login to a broken site.
Fixed this as per following

If user is part of only one company then he should not be allowed to to login
If user is part of multiple companies, then his current workspace should be updated to some other company
On time tracking page, removed user should not be visible if he is removed from that company
If user is part of multiple companies, in organization switcher, he should not see the companies from which he is removed

Preview

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactor (non-breaking and retains same functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to
not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Checklist:

[ ] I have manually tested all workflows
[ ] I have performed a self-review of my own code
[ ] I have annotated changes in the PR that are relevant to the reviewer
[ ] I have added automated tests for my code

@apoorv1316 Test this too.

@shalapatil Did you check the tests that are failing on this PR ?


Wyscout v3 events sometimes have 10 player formations for (opponent) team

I noticed that the team / opponent team object in the events of Wyscout v3 event data, doesn't always have a formation where the total amount of players summed up equals to 11. For example, I've seen occurrences of events with a "4-4-1" (opponent) team formation. Currently, our serializer crashes when this is the case, as it does not recognize this formation.
When analysing the event data of a match where we have the 'troublesome' formations, I saw that this was the result of a team getting a red card booking and in the events that followed the formation of that team was described by a 10 player formation.
The team originally had a "4-4-1-1" formation, but after the red card this shifted to "4-4-1".
How do we want to handle this?
Option A:

Description: We create new generic kloppy formation types for all possible 10 player formations present in Wyscout and use those to describe the formation of the (opponent) team in the data.
Pro: This keeps the kloppy output close to the raw data input.
Con: The behaviour of how we describe 10 player formations is different for Wyscout vs other providers. Where for other providers, we still use a 11 player formation after a red card. Resulting in a non-standardized approach for different providers.

Option B:

Description: When we recognize a 10 player formation in the event data, we keep using the last valid 11 player formation observed in the data of that team for all future events of that team.
Pro: This keeps the behaviour standard over different providers, where after a red card we still use 11 player formations to describe team formations.
Con: We lose a level of detail of describing the formations of a team.

I think my preference would go to option B, to have standard behaviour across different providers.

In my personal opinion, it is always better for the data to reflect reality as accurately as possible.
In our case, it is important to know our own and our opponent's formation, as we analyze "behavior" with different schemes and clearly when there is one or more players less on the field, that changes.
Likewise, it would have to be seen what most users use Kloppy for, since these "own" issues can be solved, as until now, by performing our own processing on eventing data, in this case.

@koenvo @JanVanHaaren @probberechts  thoughts?

@dvilches thanks for sharing your take on option A vs B. I understand your need of having an accurate description of a team's behaviour to perform qualitative performance analysis.
Since I'm using kloppy for reading in data from different providers, the aspect that we have a standardized output for different input vendors is more importantly for my use case than the level of detail that we get extra. Therefore, my preference for option B.
In the future, however, I think we should elaborate the possible Enum values of FormationType to also include formations for when there are 10/9/8 players on the pitch and use these for all providers if there are < 11 players on the pitch of a given team.
For Wyscout, we can get the X player formation directly from the team or opponentTeam properties.
For other providers, where the formation data is not included in each event, we would need to do it in an alternative way. We would need to recognize when a team starts playing with < 11 players (due to a red card or sub off without a sub on) and based on the position (defender / midfielder / attacker) of the player that gets sent off, adapt the formation accordingly.
For example, if team A was playing in a 4-5-1 and their CM gets sent off, we would assume they now play in a 4-4-1 until they change formation again.

Hi @DriesDeprest, I agree with your perspective. That's why we're clarifying that we can resolve this issue "outside" of Kloppy, and that a quick solution for most users is more important than the "best solution" for us.
Thank you for your continued contributions to the project.

I would probably do these formations differently. Either you standardize them and you create a very limited list of standard formations (including 4-4-2, 4-3-3, etc.) and anything that does not fit into it is a PositionType.NON_STANDARD; or we stick to the data provider's formation string. Currently, we are in limbo and basically have added a FormationType for every possible formation string that has been used by any of the providers. For example, I am not sure what a "3-1-2-1-1-2" looks like. Isn't that about the same as a "3-4-3" with a diamond on the midfield?
This needs a lot of refinement, but I would do something like this.
class TeamFormation:
    def __init__(self, formation):
        self.formation = formation
        self.lines, self.formation_type = self._parse_formation(formation)

    def _parse_formation(self, formation):
        try:
            lines = [int(number) for number in formation.split("-")]
            formation_type = FormationType.NON_STANDARD # if you want an attempt to standardize it can still be made here
            return lines, formation_type
        except ValueError:
            raise ValueError("Invalid formation string. Use a format like '4-4-2'.")

# Create a 4-4-2 formation
formation = TeamFormation("4-4-2")

@probberechts I like your approach and agree that this would be a better way to handle formations in general.
Do you think it would make sense to first finish merge the PR which uses option B to handle <11 players formations in Wyscout V3, so that at least the code does not break?
And that after that we create a separate issue for introducing a TeamFormation and reworking our FormationType?

Do you think it would make sense to first finish merge the PR which uses option B to handle <11 players formations in Wyscout V3, so that at least the code does not break?

For a quick fix, I strongly prefer Option C.
Option C:

Description: When a 10-player formation is detected in the event data, we set the formation to something like FormationType.NON_STANDARD, FormationType.NOT_SET, or a similar placeholder.
Pro: Consider a scenario where a team transitions from a 4-4-2 formation to a 5-2-1 formation after receiving a red card. It wouldn’t make sense to record that the team continued playing in the 4-4-2 formation. In such cases, it’s far better to leave the formation unset or indicate that it’s non-standard rather than inaccurately assigning a formation.

Okay, I've implemented option C in https://github.com/PySport/kloppy/pull/330. Let me know what you think.


Some clarifications in the mod list

In the list of affected mods, I am left confused as to what is affected, what is not affected, and where it has been patch.
For example, Reborn Core; the parameter of affected version is a bit hard to read, mainly due to the use of equality symbols. In addition, in my rudimentary research, it appeared that the 1.12 version has been patched, at least a while ago, but that falls within the written parameter of affected mod versions.
Also, a semantic correction for Thaumic Tinkerer's fixed version - the MC version is encapsulated with the mod version when it shouldn't have been. In addition, with the affected versions "Mod Minecraft" can be simplified to "Minecraft".

I will see if I can make things a bit clearer on that front. A lot of the list was copied from what we originally had. I will be making some tweaks later today hopefully


Node is out of sync

Node stays out of sync, gossip blocks received frequently, number of peers is 25. I see a lot of logs like this:
Ignoring gossip block blockRoot=0x6ca67ba20f940f25e5d6        64af590b0f50f7537c9e204c25253ab6204cec8806d1, blockSlot=148684 code=BLOCK_ERROR_PARENT_UNKNOWN, parentRoot={}
   5334 Error: BLOCK_ERROR_PARENT_UNKNOWN

Ideally the sync service should issue "beacon_blocks_by_root" request and node should be synced again, need to turn debug mode on to get more information.

not easy to reproduce as after I restart, node stays synced.
not sure if this is the root cause, but if there is a missing block root and we get network timeout for beacon_blocks_by_root request then the missing block root stays in cache forever and node will be out of sync due to that. We need to fix that anyway.

here's how it happened after I turned on some debugs

last processed block is 174071: 2020-12-25 16:14:41 [CHAIN]           ^[[34mdebug^[[39m: Block processed slot=174071, root=0x8e85d480980d6b633fb2cece5686457bb5293f872e291d217280709a2fc01d4d
gossip block 174072 came and failed with BLOCK_ERROR_FUTURE_SLOT error: 2020-12-25 16:14:46 [NETWORK]          ^[[33mwarn^[[39m: Ignoring gossip block blockRoot=0xa2fc72f28775abfee38fb32d101cecbdda1ad530dd7e2b15254f57c07632fac6, blockSlot=174072 code=BLOCK_ERROR_FUTURE_SLOT, currentSlot=174071, blockSlot=174072
eventHandlers handled that error and add to pending block pool using addBySlot
immediately after that, it's time for slot 174072 but surprisingly it showed no pending block for slot 174072

 2020-12-25 16:14:47 [CHAIN]         ^[[36mverbose^[[39m: Clock slot slot=174072
<PHONE_NUMBER>-12-25 16:14:47 [CHAIN]           ^[[34mdebug^[[39m: Block pools:  pendingBlocks=0, currentSlot=174072

from this time node keeps finding missing block root which is 174071 and it found that block quickly but then it failed with BLOCK_ERROR_BLOCK_IS_ALREADY_KNOWN since that block was really processed
2020-12-26 07:26:59 [SYNC]          verbose: Finding block for unknown ancestor root blockRoot=0x8e85d480980d6b633fb2cece5686457bb5293f872e291d217280709a2fc01d4d
...
2020-12-26 07:28:15 [SYNC]          verbose: Found block for root slot=174071, blockRoot=0x8e85d480980d6b633fb2cece5686457bb5293f872e291d217280709a2fc01d4d
...
2020-12-26 07:31:02 [CHAIN]           debug: Block error code=BLOCK_ERROR_BLOCK_IS_ALREADY_KNOWN

the above logs have happened forever ...

as I see BLOCK_ERROR_FUTURE_SLOT quite frequently, I think we need to accept some deltas when determining that error due to time differences. This is part of the spec and was somehow removed after some code refactoring
when handling that error, we should add to the cache first then add to pendingBlock db
at onClockSlot we should get all pending blocks of past slots too and process all of them
minor point: improve Block error debug log to include block slot as well


New Theme: Business Frontpage

Theme submission
Please make sure that you have read the theme submission guidelines before submitting a theme. The guidelines provide all relevant information and requirements that have to be fulfilled before the submission. Please tick the relevant boxes for your theme in the checklist below:
Link to my theme repository: https://github.com/cowboysmall-tools/hugo-business-frontpage-theme
I made sure that...

[x] the repository contains a good README.md describing my theme
[x] an open source license has been added to LICENSE.md
[x] all metadata have been added to theme.toml
[x] screenshots have been added in the images/ folder with the required dimensions
[x] in case I'm using a customized demo via the exampleSite folder that

[x] https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
[x] I tested that my theme's demo works with the content directory of gohugoio/HugoBasicExample

[x] I tested my theme against the gohugoio/HugoBasicExample

[x] I've checked the developer tools' console in my browser for error messages

[x] in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo

N.B. By submitting a theme to the Hugo Themes Showcase you understand that you need to maintain your theme. You will need to keep an eye on whether your theme's demo generates on the Hugo website, whenever there is a new release. We are a very small team and we just cannot keep up opening issues in the various theme repositories to notify authors. Whenever a theme demo breaks and remains broken then at some point it will be removed from the list without prior warning. If you no longer wish to maintain a theme please let us know.
Feel free to ask questions. We're glad to help.

@cowboysmall
Thank you for porting this theme to Hugo.
Once the tests for #751 succeed, I will add the theme to the Hugo website

@digitalcraftsman
This theme is a port of Business Frontpage -  a basic HTML starter template for creating a Bootstrap based website for a small business or other organization

I've promoted your theme on Hugo's official Twitter account.


COSTA breaks cross-compilation

This cmake specification disables cross-compilation of COSTA, e.g. CP2K which depends on COSTA cannot be compiled for other targets like generic.

It is not really what I call cross compiling but I have a better understanding of the issue. The best for now is to patch the toolchain while I will change the costa CMakeLists.txt. It is easy but will require one day or so before a new release is out.

Thanks @mtaillefumier


click-events-have-key-events only applies to non-interactive elements

Re: https://github.com/reactjs/react-a11y/issues/167
It seems like this rule only makes sense for non-interactive elements, since the spacebar works just fine on button, a, etc elements and no keyboard event is needed.
This PR lets that rule pass for interactive elements. It also triggers the rule on onMouseDown and onMouseUp since those would seem to be just as inaccessible as onClick.

Thank you very much for the PR!  Unfortunately, since this library has been deprecated (notice here) in favor of react-axe I am going to close this PR.


fix for decorator coverage

As discussed in #454 there is a problem with coverage on decorators when emitDecoratorMetadata is enabled. This is kind of a hack to fix this until something better is implemented in tsc/jest/istanbul. There are two options. First you can set a configuration option ignoreCoverageForAllDecorators to true and it will ignore all decorators (and possible something else). The second option is to add /* istanbul ignore decorate */ right after the decorator like this
@Decorator /* istanbul ignore decorate */

Looks good to me. Can I get you to write a test to ensure we don't have any regressions later on?

Also I was just thinking this is a temporary solution. This should probably be solved in tsc and we could write it like this
/* istanbul ignore next */@Decorator
The problem now is that this comment gets removed by tsc even if removeComments is set to false.

Hm, maybe we don't actually have any tests for coverage - I couldn't find one at a quick glance. @kulshekhar ?

given that coverage is not handled by ts-jest at all (jest takes care of that), I'm not sure about this

That's true but the comment is copied by tsc and therefore kind of part of ts-jest. The other option would be to implement it in Typescript but I wouldn't count on that.

The problem now is that this comment gets removed by tsc even if removeComments is set to false.

Does this happen only in ts-jest or even with tsc from the command line?

I just tested this with tsc and tsc allows comments through with the default settings. This means that even ts-jest will not strip these comments out.
In this case, I'm wondering whether it wouldn't be better for the actual applications to add this comment in the code themselves. On the other hand, I can see how this can be a pain - particularly for apps with a lot of decorator usage

Adding this in would mean supporting it and any other edge cases this may cause. That this would be behind a flag doesn't change this.
The fact that this itself is somewhat of an edge case, related to a feature (coverage) that ts-jest has no control over makes it hard for me to justify adding this in.

Let's start at the beginning. @Decorator gets transformed into a __decorator call by tsc. If emitDecoratorMetadata is enabled the call cannot be covered by tests that's why the coverage cannot be 100%. This is described in #454.
To ignore this coverage we would have to prepend the __decorator call with /* istanbul ignore next / comment. Logically we would prepend the decorator with that comment (like this / istanbul ignore next /@Decorator) and tsc should output it before __decorator call. However this comment gets removed by tsc.
So there are two options as I see it. One is to change tsc to output the comment before the decorator. But I don't think this will happen soon. The other is to implement it in ts-jest which I did.
I don't see a harm in adding this since you don't have to use it. If you don't enable it by setting the config parameter or don't use the  / istanbul ignore decorator */ comment nothing changes.

I'm still not convinced that ts-jest is where this belongs.
However, as I probably won't have time to look at this again in the coming week(s), I also don't want to leave this hanging.
If you update the docs to indicate that this is experimental and could be removed later, I'll merge it in. If you also bump the version patch, I'll publish this change right after merging it.
But before doing this if you could please respond to my review question.

Did the version bump.

I've made the required changes and will take a look at this again and merge/publish it after work


How to obtain more top_non_dropout_de?

adata.uns["top_non_dropout_de_20"] stored top20 differential gene, how to get more?

modifying script of data_utils.py to get more top_non_dropout_de, but the result of top20 and top50 are inconsistent.
modify the script as follows：

top20 result:

top50 result:

There is an example notebook on their paper's GitHub.


refactor/fix(CL): add IDs to incentive record keys to avoid overwriting

Closes: #5492
What is the purpose of the change
Currently, there is a bug where creating an incentive record with the same key parameters, would completely overwrite the old one. This bug is reproduced by TestCreateIncentive_NewId in this PR.
To mitigate this, we introduce IDs for incentive records that get appended to the end of the incentive record key. This solution completely resolves the problem as shown by tests.
Additionally, since we are now creating CL incentives through the existing gauge infrastructure, incentive module address is always the creator of the incentive record. As a result, there is no need to store the creator in the key so it was removed.
Additionally, there was no reason to store denom in the key of the incentive records. Therefore it was moved into the body as part of the RemainigCoin field.
Now the full incentive recorded looks like the following:
type IncentiveRecordBody struct {
	RemainingCoin types1.DecCoin
	EmissionRate github_com_cosmos_cosmos_sdk_types.Dec
	StartTime time.Time
}

type IncentiveRecord struct {
	IncentiveId uint64
	PoolId      uint64
	IncentiveRecordBody IncentiveRecordBody
	MinUptime time.Duration
}

Testing and Verifying

TestCreateIncentive_NewId - reproduces the bug and fixes it
TestCreateIncentive is updated to validate that incentive id is incremented
TestIncentiveRecordsSetAndGet is updated to show that incentive records gets overwritten only when the same ID is used
various other test case updates

Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?
[ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[x] N/A

All comments are now addressed. Merging this once CI passes


Example not working

Describe the bug
I copied the example and these methods are not found

Steps to reproduce the bug
Download the dependencies (not prerelease)
Copy example code from Github home page
Compile
Expected behavior
Expect function to be found
Screenshots
No response
NuGet package version
15.0
Additional context
No response

add
using static LangChain.Chains.Chain;

@curlyfro that did the trick, thanks!


Select2 dropdown values are unable to set in ng-model scope

select2 based dorpdown values is unable to set in ng -model

Can you expand upon the issue you are facing by adding a few more pieces of information to your bug report?

What steps can be used to reproduce the issue?
What is the bug and what is the expected outcome?
What browser(s) and Operating System have you tested with?
Does the bug happen consistently across all tested browsers?
Can you reproduce this issue on any of the examples in the docs?
What version of jQuery are you using? And what version of Select2?
Are you using Select2 with other plugins?

The contributing guide contains a useful section with a few questions which can help us track down the bug and speed up the process of finding a fix for it.  The creation of an isolated test case would also be useful.

I have attached my sample in plunker for your reference for more clarity
https://plnkr.co/edit/uQM1lOAUJRO8aLnNyxNN?p=preview

angularjs 1.7.8

That's still a thing?
I remember AngularJS (not Angular) having issues with Select2 because it did dirty checking on the model state only instead of listening for the change event (which Select2 properly emits). I think there's a Select2 plugin for AngularJS that you might be able to use to make them work nicely together.
Because it's an issue with AngularJS and not Select2 when isolated, I'm going to have to treat this like a usage question.

This appears to be more of a usage question than a bug report or common feature request.  As we continue to keep the Select2 issue tracker geared towards these two areas, bug reports and common feature requests, we are redirecting usage questions to other communities such as the mailing list, IRC, or Stack Overflow.


PAM module minor improvements

This PR makes minor improvements to the PAM processing.
General

g_printf() calls for error conditions are replaced with LOG() calls.
PAM_USER is now set for (e.g.) pam_exec.so - this addresses part of #1882

Conversion function

More error logging/checking is added to the PAM conversion function
The PAM_ERROR_MSG style (see pam_conv(3) is now supported
The PAM_TEXT_INFO style now logs the message rather than ignoring it completely.
some potential memory leaks if the conv function fails have been removed.

The PAM_USER functionality was tested by adding this line to /etc/pam.d/xrdp-sesman:-
auth optional pam_exec.so log=/tmp/pam.log /usr/bin/env

After logging in, /tmp/pam.log contained:-
PAM_SERVICE=xrdp-sesman
PAM_USER=testuser
PAM_TTY=xrdp-sesman
PAM_TYPE=auth

Although the PAM_ERROR_MSG style could not easily be tested directly without writing a PAM module, the pam_echo.so was used to exercise the very similar PAM_TEXT_INFO style which now outputs to the sesman log.

Was about to merge this and a final eyeball check showed a call to snprintf() which was better made g_snprintf()
Will squash and merge tomorrow now unless I get any objections.

Overall, LGTM.


collecting idle-rate performance counters on multiple localities produces an error

collecting idle-rate performance counters (on hello_world) on multiple localities produces the error:
pool 1 (zero-based index) requested out of bounds. The partitioner owns only 1 pools: HPX(bad_parameter)
running this sbatch script on Rostam:
https://gist.github.com/zbyerly/b06bfd32567c677e15c4483f76819c89
produces this:
https://gist.github.com/zbyerly/8fed68788ff317590f242e46905d6f44

Thanks for reporting. This is a genuine bug introduced by the recent introduction of the resource-partitioner and the related changes to the performance counters


@ExceptionHandler is ignored

Hi!
Looking at https://github.com/graphql-java-kickstart/graphql-spring-boot/issues/166, I found that graphql.kickstart.spring.error.ReflectiveMethodValidator#isGraphQLExceptionHandler is only called for classes which are returned from org.springframework.beans.factory.ListableBeanFactory#getBeanDefinitionNames at the time of ContextRefreshedEvent.
So, at this time, my @Configuration class is not there, in fact, at this time there are about 20 entries there. After the application has started, this method returns 700+ entries including my thing. Could that be the issue? I tried declaring it in the @Componenet as well
The whole thing happens in graphql.kickstart.spring.error.GraphQLErrorStartupListener that calls GraphQLErrorHandlerFactory

Solved by #305


[promptflow-azure-ai-language] Update Package Example Flows for PF Gallery Contribution.

Description
Azure AI Language has developed a promptflow custom tool package promptflow-azure-ai-language to expose Language capabilities to users. This contribution request updates the package's example flows to prepare for PF Gallery Contribution per the contribution guidelines listed here.
See current issue here.
All Promptflow Contribution checklist:

[X] The pull request does not introduce [breaking changes].
[X] CHANGELOG is updated for new features, bug fixes or other significant changes.
[X] I have read the contribution guidelines.
[X] Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[X] Pull request includes test coverage for the included changes.

Hi, please double check the transcript wording. It is heavily alarmed by the compliance check. @murraysean

Hi, please double check the transcript wording. It is heavily alarmed by the compliance check. @murraysean

Updated transcript to fix compliance issue.


CB-10792 -Cannot install cordova-plugin-globalization with cordova-windows on Ubuntu

Make Windows lower-case in plugin.xml

Hi @dubeejw it would be good to go over all the cordova plugins plugin.xml and check which one have this bug of not using lower case for source files

@dubeejw  I meant not the file itself but the path, I think you know what I meant :laughing:


Outline implemented

outline.scm file added.
It handles declarations of

protocol,
actor,
class,
struct,
enum
extension
func (both global and methods)
type properties

In sake of performance and simplicity it captures the whole line from whatever keyword till *_body.
Verbosity in functions and types symbols made by purpose, in sake of simplicity and performance (every time i tried to make capture more precise in function especially ended up 60 sec warmup of zed on those grammars.

Thank you — very thorough!


RelayerFee sdk returned 0 (socket)

Describe the bug
RelayerFee displayed 0 to the user.  The SDK returned 0 to Socket. We should return an accurate estimate

But actually was 39 DAI
See https://connextscan.io/tx/0x2adae0c5e87e96d3e3bb57340494270c3523d3c51356e7b4669b9e8cf8cb401f?src=search

https://arbiscan.io/tx/0x2adae0c5e87e96d3e3bb57340494270c3523d3c51356e7b4669b9e8cf8cb401f

Need to bubble up errors and not catch/surface in SDK

Need to bubble up errors and not catch/surface in SDK


Show locators at pick up and drop off locations when the mission is in complete stage

Thank you for your help :heart:
What is this project?
DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.
The specific project you are looking at is Missions. Missions is the client facing side of the marketplace connecting DAV users looking to ship packages, with autonomous vehicles such as drones.
How you can help
When the mission ends the screen shows the map with some mission summary information.

Modify the code so that in the summary screen it will still continue showing the coordinates of the drop off and pick up locations.
Technically this means that in the MissionScreen - when mission is in complete state the locators needs to shown at both pick up and drop off coordinates.
Contributing to Missions

[ ] Make sure this issue is labeled up-for-grabs and not labeled claimed, to verify no one else is working on it.
[ ] Comment in this issue that you would like to do it.
[ ] Open the Missions GitHub page and click the ★ Star and then ⑂ Fork buttons.
[ ] Clone a copy to your local machine with $ git clone git@github.com:YOUR-GITHUB-USER-NAME/missions.git
[ ] Make changes in the LICENSE file
[ ] Once you've made sure all your changes work correctly and committed all your changes, push your local changes back to github with $ git push -u origin master
[ ] Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/missions) and create a pull request for your changes.
[ ] Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: #5)
[ ] Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.

Happy to take this one
code changes happen only here: /components/MissionScreen.jsx?
I don't see how to act on the map, though?

Hey @jonasgrilleres currently the terminal points(pickup and dropoff) are getting cleared on mission complete. This is the operation done is map.jsx here... https://github.com/DAVFoundation/missions/blob/master/src/components/Map.jsx#L26 You need to remote that. But, that will make the terminals present even after you click close in this screen.

So, you need to execute the clearPins on close and route the user to /
Hey @TalAter  and @liorshkoori Please correct me if am wrong 🙂

Hey @cg-cnu , not sure I understand what you described :) Anyway, to clear things up, on mission complete we need to show the route of the mission from pickup to drop off, with a line connecting them

Hey @liorshkoori that is worked on in a different issue here... https://github.com/DAVFoundation/missions/issues/99 This is to just display the pickup and dropoff markers. Please correct me if am wrong 🙂

@cg-cnu ok then yes, you're right

Okay it makes sense, I'll have a look today / this weekend.

Hey @jonasgrilleres Do you got any update on this one 🙂

Hi,
Sorry guys I didnt find the time before to work on this issue.
I have this error when searching for an available drone:
XMLHttpRequest.r.onerror      on mapbox-gl.js?d5ed:521
I have installed the mission-control and run it with

docker-compose build && docker-compose up

but it doesn't seem to work
Could you give me a hand there?

what is the best option to clear Pins?
I wanted to call it from MissionScreen.jsx in a method triggered on click on the close button (Link component), in this part of the render() method:

if (this.props.missionComplete) {
}

The handler would look like this:

onCloseMissionSummaryScreen(event) {
clearTerminals(this.map);
}

I need to import map.js into MissionScreen.jsx

import clearTerminals from '../lib/map';

and I don't know how to pass the map instance to clearTerminal()
Does this sound like a decent solution or am I completely thinking wrong?

guys, sorry for not being active recently, I'll have a bit more time this week to get tackle this issue.
If thats okay, I'll have a look today!

Closing this old issue for now.


[Suggestion] Programmed weather notification

It would be nice to be able to set a programmed notification to be sent with the current day's weather. In my case I would like to have the current day's weather summary for when I wake up, so I would set the notification to be sent at 7h30 so when I wake up no need to manually open the app.
Any comments on this?

Sounds like a pretty good idea :thinking:

I am not against the idea. But It is not what I need from that app. The reason I wrote it is to have an app which uses as less battery as possible and doesnt do any network request while not needed.
If someone wants to have a go at it I will gladly help.


Hipchat v1 deprecated

Is there any support for v2 API ?

@VAdamec Hi, I don't believe this adapter uses the HipChat REST API at all. I believe it only connects via XMPP. Are you experiencing some issues?


Remove deprecated fallback for dictionaries as headers.

Remove the fallback that was deprecated in #184.

Can anyone review this change please?

@LuRsT This change looks good to me: however, there's currently no roadmap for the 3.0.0 release (it'll be released when we have other breaking changes).
You're welcome to open a PR with this change but it won't get merged until we're ready to go, so it'll likely drift from the current master pretty painfully over time. So instead, I recommend posting that patch in this issue (the output from git diff) will be fine, so that the patch doesn't get lost. =)

Sure thing, also, part of what I did in that commit (changing the dict headers in the test) should be merged to avoid confusion right (if yes, I'll send a PR with just that change, if not, I'll keep it here with the rest)?

@LuRsT How about we go one step further. Can you make the dict headers change, but also add a new test that explicitly tests that dicts are accepted? That gives us a single targetted test that can also be removed along with this change.

@Lukasa Of course! Great idea, will do that!

@Lukasa done, could you check if that's what you wanted?

\o/ Fab!

This is happening in #500.


Some cards have different ability texts than on gatherer

While parsing new v4 of AllCards.json I found that several cards have ability texts that differ from the current gatherer text.
For example: Arclight Phoenix

At the beginning of combat on your turn, if you've cast three or more instant and sorcery spells this turn, return Arclight Phoenix from your graveyard to the battlefield.
At the beginning of combat on your turn, if you've cast three or more instant and sorcery spells this turn, you may return Arclight Phoenix from your graveyard to the battlefield.

Or: Arid Mesa

T, Pay 1 life, Sacrifice Arid Mesa: Search your library for a Mountain or Plains card, put it onto the battlefield, then shuffle your library.

T, Pay 1 life, Sacrifice Arid Mesa: Search your library for a Mountain or Plains card and put it onto the battlefield. Then shuffle your library.

Darkblade Agent:

As long as you've surveilled this turn, Darkblade Agent has deathtouch and "Whenever this creature deals combat damage to a player, you draw a card."
As long as you've surveilled this turn, Darkblade Agent has deathtouch and "Whenever this creature deals combat damage to a player, draw a card."

Maybe this comes from other editions that are not correctly updated?

I can't see originalText in the json file?
I parse the "text" key.
If it helps I attach the comparison of the gatherer version with the V4 version
Compare.zip

Since you closed the issue I can assume you were parsing the wrong field by accident? Either way, I’ll check the zip file tomorrow.

Sorry, I'm a Github noob and clicked the wrong button ;)

Just tested around with this. Seems some cards have their API and on-card mismatched with updated text.
cc: @csuhta

All three fixed

I have checked the json from 4.1.3 version and there are still the other inconsistencies. only the three examples are fixed. Now I extracted all cards with different ability texts:
Assure // Assemble (Assure)
Bad River
Blood Crypt
Breeding Pool
Demotion
Faith's Fetters
Fertilid
Flood Plain
Godless Shrine
Grasslands
Hallowed Fountain
Land Tax
Mnemonic Betrayal
Pir's Whim
Plots That Span Centuries
Skyshroud Claim
Stomping Ground
Undercity Uprising
Vigor

cc: @csuhta :)

These are all updated upstream, except: Plots That Span Centuries is not on Gatherer, it can't have different text.

Yes you are right with "Plots...". I always check against my current own database which also has a few non- gatherer cards. But on other sites with extracted rule text, I see "Plots..." only with the word 'would' inbetween - as it was printed. I don't see a hint, that this word was removed anywhere?


COMMENTARY: Update the commentary files now used in Equation Explorer

Remove some redundancy, incorporate some recent developments.

claim

propose #528


"Ciorăști" is listed in the drop down menu

Description:
"Ciorăști"  is listed in the drop-down menu alongside its corresponding county according to the law
Precondition:
The website is up an running.

Step 1
Type "Ciorăști" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Ciorăști , VRANCEA".


pkg/alertmanager: mergepatch alertmanager containers

Instead of just appending user defined containers to the alertmanager
pods, use k8sutil.MergePatchContainers so that the default containers
can be modified.
This is a backport of https://github.com/coreos/prometheus-operator/pull/3080
/cc @coreos/team-monitoring

(fixed the PR title but the commit title still needs fixing, then lgtm)


WIP: Implement history queue for existing store values

For #17, we need a history queue. Redux provides a standard convention for tracking history, which we leverage via the redux-undo library. Changes to getIn make the history state invisible to components if all they need to do is get the present value of a given property.
To test, apply this diff or replicate these lines in the store/index.js file:
diff --git a/src/js/store/index.js b/src/js/store/index.js
index d2458e2..ae356cd 100644
--- a/src/js/store/index.js
+++ b/src/js/store/index.js
@@ -8,3 +8,7 @@ var configureStore = require('./configureStore');
  * @type {Store}
  */
 module.exports = configureStore(require('./defaultState'));
+
+window.undo = require('redux-undo').ActionCreators.undo;
+window.redo = require('redux-undo').ActionCreators.redo;
+window.store = module.exports;

You can then make a change (such as toggling open several layers), then run store.dispatch(undo()) in the console several times to step backwards through time.
Remaining Issue:
This is what is happening at present when I toggle open the topmost group:

Events are stacking up, and we need to step through to identify why multiple actions are firing at once. This is why you need to undo() many times to see any change in the UI. Once this is resolved, each action should be granularly undoable and we can build a better interface for the history.
LYRA-267

This is still WIP because it depends on untangling the communication between the store and the view; #308 was pre-work for that cleanup, which is in progress

Superseded by #387.


Investigate: support content-type ndjson

Other Feature Request
Request from SQUIZ:
We have a request to support ndjson content-type header using the REST component. The use case is for bulk import data into the Datastore service via the importing API.  Here is the API spec: https://docs.squiz.net/datastore/latest/using/importing.html#adding-an-import-block
It requires Content-Type: application/x-ndjson
To reference something similar here.   Previously, there was one ticket related to the ability to overwrite the content-type header for the REST component : https://support.elastic.io/support/tickets/7116(ticket discussion is in the comments). But the requirement was too broad and we ended up working around the problem.
Can you please provide feedback on what's the viable option to support this integration?
for example:
option 1: adding support to content-type: application/x-ndjson
option 2: adding feature to override header content-type
option 3: if neither 1 or 2 is viable,  a new component?
Updates (bi-weekly call 19.01.23):
The content type in the component is not free-form.
Content type as a placeholder text in the header section but if you change to POST request and the user goes through it, then presenting a dropdown with pre-defined content types. Users are confused about why they can't use x-nd JSON.

Related old ticket #7116 in screenshots below:
Related GitHub task

If the platform team extends the UI view class RESTAPIView with the application/x-ndjson type this should do the trick. No extra work is required from us

Closing the task so far. There are workarounds we could do but they require creating a new component. The simplest solution is adding this content type tho the existing viewclass by the platform team


Add option to Slide Panel opt-in expand to Anchor point mode

An attribute has been added to SlidingUpPanel to just expand up to Anchor Point, not occupying the whole view height.
By default it works as usual.

It would be really awesome to see this pull request merged into the main branch. The fact that you can "override" an anchor point and expand past it kinda defeats the purpose of the anchor point for many uses cases (in my opinion, of course).

I just checked in https://github.com/umano/AndroidSlidingUpPanel/commit/81e3d5a3ed811cff86efa0680e9e49b2efa91a2b, which adds support for a layout_weight attribute for the sliding panel. I'm going to close this PR. Thank you for your contribution!


cmake?

Have you tried cmake for this? It looks like they are shipping the configure script now, so that's good, but cmake may be a better option for Windows.
of course, we can use it only on Windows, but I thought I'd ask if it's been tried at all.

yes I tried the cmake build at some point, but I had troubles because it did not install some files. See my issue here for details: https://github.com/conda/conda-recipes/issues/625.

thanks -- I found cmake painful as well....
We'll have to see how things go on Windows


[SourceKit] Record module loading errors when generating interfaces

Record up to two errors emitted when we fail to load a module for interface generation, and include these errors in the message we pass back to the editor. This should help us better pin down the reason why interface generation failed.
rdar://109511099

@swift-ci please test


created a logger struct

Signed-off-by: Shreyas220<EMAIL_ADDRESS>Description
Added a logger struct for model package
for issue #3468
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #3493 (5e40723) into master (1c0c895) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3493   +/-   ##
=======================================
  Coverage   12.30%   12.30%
=======================================
  Files          37       37
  Lines        3194     3194
=======================================
  Hits          393      393
  Misses       2718     2718
  Partials       83       83

Flag
Coverage Δ

gointegrationtests
3.28% <ø> (ø)

unittests
10.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0c895...5e40723. Read the comment docs.

@sayantan1413

Hey @kumarabd @dhruv0000 @DelusionalOptimist @mgfeller we created a logger struct in the models/adapter.go file so that we can log the error like l.log.Error(..). Please share your views on this.

We do not log in model
No need for this ; )

Oh okay so we can close this pull request @Shreyas220


Browser support?

I have searched the docs and previous issues and cannot find a browser compatibility table. What is the browser support? Is it documented?

It is not documented.  However, we intend to be compatible with all browsers that React 15 is compatible with.  If you find a bug, please file it and let us know.  We cannot support browsers beyond what React itself supports as this library is built on React.
https://reactjs.org/docs/react-dom.html#browser-support

Cool, so IE9+.


how upgrade RN to 0.56

upgrade RN with react-native-git-upgrade 0.56.0
then react-native run-ios as follow error:
undefined is not an object(evaluating '_reactNative.Text.defaultProps.allowFontScaling=_AppConfig.
default.allowTextFontScaling')

package.json modified
{
   "dependencies": {
        "react": "16.4.1",
        "react-native": "0.56.0"
  },
  "devDependencies": {
      "babel-core": "^6.26.3",
      "babel-eslint": "^9.0.0",
      "babel-preset-react-native": "^5",
  }
}

issue to ignite, how upgrade RN to 0.56

@gatspy Did you get this figured out?

I have same


Update links to clojure-doc.org articles

Some reorg at clojure-doc.org moved and renamed some articles, so this fixes those. I've double-checked that it's the same content by looking at archive.org.

Thanks a lot!


Twitch Test

Would be great to have your team test out DeepBackSub on Twitch, for many music artists looking for more tools for live streaming sets to their fans, and Twitch users who stumble across them. if this ever happens, please let us know :)

Thanks for the heads-up. I wanted to try Twitch anyway sometime, I'll let you know when I get around to test this.

Perfect 😊
*** Note that my email address changed to<EMAIL_ADDRESS>Josh East
Head of A&R | Label Mgr.  http://www.circulatemusic.com/ @CirculateMusic
Head of Mrkg.  https://musicom.bandcamp.com/ @Musicom (Merlin Network)
Co-Founder | Director  http://iliveyoutoo.com/ @iLiveYouToo
Sync Rep  http://www.leakysync.com/ @LeakySync
M:<PHONE_NUMBER>
From: Florian Echtler<EMAIL_ADDRESS>Sent: Monday, April 13, 2020 5:28 AM
To: floe/deepbacksub<EMAIL_ADDRESS>Cc: CirculateMusic<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [floe/deepbacksub] Twitch Test (#2)
Thanks for the heads-up. I wanted to try Twitch anyway sometime, I'll let you know when I get around to test this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/floe/deepbacksub/issues/2#issuecomment-612878207 , or unsubscribe https://github.com/notifications/unsubscribe-auth/APEXQMLDTRN6U7ESKPFHBFTRMMAMNANCNFSM4MGK2OEA .

Just had a look at Twitch broadcasting tools (https://dev.twitch.tv/docs/video-broadcast) that might be able to use our codebase: for now it seems OBS Studio is the most likely option, with Streamlabs OBS port close behind (both FOSS). Xsplit have their own closed solution (VCam) and consoles are closed devices entirely (but free to adopt OSS from here :smile:)
There is one OBS virtual background project here in Github: https://github.com/axiak/obs-virtual-background which looks like a nice starting point, and the developer is 'on the lookout for a suitable segmentation model in C/C++ to remove the need for the node service' - we may have a good fit if we can build a video-in -> mask-out loadable module.


Transitive embedding with composite FK

Consider a case of a weak entity
create table a  ( id int primary key, value text );
create table b  ( id int primary key );
create table a_b ( a int references a, b int references b, primary key (a,b) );
create table ab ( a int, b int, attribute text, foreign key (a,b) references a_b );

It is currently impossible to request transitive embedding
GET /ab?select=a(value)

It is possible to declare it explicitly
GET /ab?select=a_b(*,a(*))
GET /ab?select=a_b(a_id,b_id,a(a_id,value))

But it gets quickly out of hands if you add more levels, and you must at least specify the full FK in the intermediate table (i.e. a_b)
The easy workaround is to simply add a direct FK on the weak entity, which is definetly not a headache.

I think when you say "impossible" you actually mean you encountered an error
that is because ab is related to a in 2 diffrent ways, and where (was) no way to say which link to use, but that got added by this PR https://github.com/begriffs/postgrest/pull/918
which is in master but unreleased yet. i think this is what you are looking for.
I'll close, please reopen if that does not solve your case


g_cor term computation

Hi,
I have read your paper and it's very interesting.
Now, I'm trying to comprehend your MNIST example implementation.
I found this program take kl_divergence and BCEWithLogitsLoss in loss function.
So I think this program compute a gradient of KL divergence and g_rep term through backpropagation, but not g_cor term.
Why don't you put (log p(x|z) * log g/r) term into loss function for g_cor calculation?
Or can I ask you where g_cor term is computed?

Hi exp-3,
Thank you for your interest in our work! In our initial experiments, we wrote an implementation of the g_cor term, but found that in practice it did not significantly effect results.
In fact, as noted in Naesseth et al. (2017), the 'gradient correction' term, can often be omitted.
If you do wish to implement this yourself,  you could take a look at Appendix D.2, equation of our work to see the explicit form written out.
Good luck!


OpenGL 2.0 or higher with the FBO extension is required

Windows 10(64-bit)
Exception in thread "LWJGL Application" com.badlogic.gdx.utils.GdxRuntimeException: OpenGL 2.0 or higher with the FBO extension is required. OpenGL version: 1.1.0
Type: OpenGL
Version: 1:1:0
Vendor: Microsoft Corporation
Renderer: GDI Generic
    at com.badlogic.gdx.backends.lwjgl.LwjglGraphics.initiateGLInstances(LwjglGraphics.java:346)
    at com.badlogic.gdx.backends.lwjgl.LwjglGraphics.initiateGL(LwjglGraphics.java:225)
    at com.badlogic.gdx.backends.lwjgl.LwjglGraphics.setupDisplay(LwjglGraphics.java:216)
    at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:142)
    at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:124)

OpenGL version 4.0

Your OpenGL instance isn't 4.0, as the log shows it is 1.1.0, which is unsupported by LibGDX.  Make sure you have up to date drivers for your video card.

OpenGL Viewer shows that it is 4.0

@raderio Do you have an Intel graphics card?
If so, you are probably affected by https://github.com/LWJGL/lwjgl/issues/119 , which can unfortunately not be solved by libgdx.

yeap, I have Intel graphics card
Thanks

You can patch your java version. So you can at least develop on your. Instructions on how to patch it, can be found in the other issue.

Have you fixed this issue? I've got stuck for 1 week but can't figure out how to solve these stuff


Framebuffer doesn't actually resize under nouveau

I'm still fresh with GLFW but I believe that framebuffer should scale respectively to the window. Theoretically it does, because I've setup a callback which tells me size of framebuffer after resizing and it does change as I resize window, but in practice framebuffer's size doesn't change after window is created.
Basically it looks like this:

I'm using:
Kernel 4.0.4
Mesa 10.5.6
Nouveau as my GPU driver
Plasma 5.3.1 as my desktop environment
Xorg 1.17.1
Also I don't know if it's helpful, but in ancient mesa docs I have found that:
"Mesa can't determine when a window is resized. When the on-screen window is resized the ancillary (depth, stencil, accumulation) buffers should be resized. The work-around is for Mesa to query the window size whenever glViewport is called. This is usually sufficient since glViewport is usually called soon after a window has been resized. When this isn't sufficent the programmer can include a call to glResizeBuffersMESA() which forces Mesa to query the current window size and resize the ancillary buffers if needed." - from http://www.mesa3d.org/brianp/sig97/mesadoc.htm

Can you confirm that in response to the resize callback your application is calling both glViewport and glClear? Unless I'm mistaken, the result in your screenshot can be achieved by the application failing to clear the framebuffer after it has been resized.

Hm, if I glClear in a callback everything works just fine, but afaik I shouldn't need to clear the framebuffer on my own in a callback function, because if I remember correctly on Windows GLFW clears the framebuffer for you after it is being resized.

if I remember correctly on Windows GLFW clears the framebuffer for you after it is being resized

Perhaps @elmindreda can comment on this, but I don't recall anything in the docs saying that this is guaranteed behaviour.
You don't have to glClear in the callback function itself, just make sure your application redraws itself after the framebuffer is resized. http://www.glfw.org/docs/latest/window.html#window_refresh might be of use to you.

In fact, GLFW explicitly tells Windows never to erase the window contents in any circumstances. It's possible that the larger framebuffer is initially cleared by DWM when running Aero, as it would otherwise contain bits of other applications.


24 columns grid doesn't calculate columns width correctly

If you select 24 columns in custom.scss, when you use a col-sm-5 together with col-sm-19, the total width is bigger than 100%

Bootstrap only supports 12 columns.
The issue tracker is not a place to post How-to or personal questions. Thanks

That's exactly why there's a variable for the amount of columns. To configure it.
So @enrimr 's question is legit.

I was going on checking my issue, and the problem is when you mix a two cols where one of them includes a min-width attribute. So I'm going to close the issue because the problem is not the grid system. Thanks both of you!


IllegalStateException: Transaction is closed

Describe the bug
An exception when processing the vulnerability data, causing mojo to fail.
Version of dependency-check used
The problem occurs using version 5.2.4 of the the maven plugin
Log file
https://gist.github.com/OrangeDog/1a4b631306df81688665d6668a9622ac
To Reproduce
Unsure. It's only happening on one installation (a CI machine), but happens every time.
Expected behavior
No such exceptions.

Deleting the data directory (~/.m2/repository/org/owasp/dependency-check-data/4.0/) appears to have fixed it for the next run.

Somehow the database got corrupted.  Deleting the h2 database appears to have fixed the issue.

It happened again. Is the data directory (before I deleted it) of any use?

Unfortunately no.  We are looking at completely refactoring the data load which should resolve this.

I suspect my root cause was disk space exhaustion.


chore: drop support for Node.js 10

This is a prerequisite for shipping Puppeteer as JavaScript modules (#6753).
@jackfranklin I noticed that our tsconfig has target (and module) set at ESNext. Should we hardcode that at whatever our currently-supported Node.js versions support (in this case, that would be ES2019)?

Regarding the tsconfig target - yeah I reckon we should target whatever the lowest Node we support supports? WDYT?
Also not sure why there are so many Prettier related failures on CI; those shouldn't have made it through onto main :/

Apparently ES2019 is not a valid option for module specifically, so I went with the next best thing, which is ES2015.


用"文言"的古音"moonyeon"

大家的建议都在书面语上，我从读音上提个建议。"wenyan"是现代汉语读音，可不可以用古汉语读音类似"moonyeon"作为语言的名称。
(While everyone's suggestions are in written language,  I would make a suggestion from pronunciation: since "wenyan" is the pronunciation in modern Chinese, can you use ancient Chinese pronunciation like "moonyeon" as the language name. )

I think your suggestion is very good, however:

I wish I thought about this earlier. Now that everything in the repo is named wenyan, it is quite a pain to switch. Plus many people already know this project as wenyan-lang. I just think it's too late to change :(
moonyeon has a possibility to be read as moony-eon (dreamy years?). Kind of romantic haha.

But I'll definitely take these kind of things into consideration for the next project.
Thank you very much!

值得一提的是，“moonyeon”只是韩语读音，韩语读音不等于中古音，中古汉语中“言”是疑母字，声母应为/ng/，而不是韩语里面的零声母。

@Elysion-tcfa 谢谢指正。

文：微紐、三等、合口、文韻(平聲)。
言：疑紐、三等、開口、元韻(平聲)。
所謂 moon yeon 二字讀音俱誤。建議關閉問題。

@heangfat 我只是举个例子建议用古音，又没有说一定要用我举的这个发音。你是专家可以提你的建议。不要动不动建议删别人的问题。而且我也听取建议认为中古汉族拟音更好。

@guxd 抱歉，失言了。我意爲不贊成現階段用古音轉寫。

@heangfat 嗯，我也覺得慢慢過渡比較好。雖然古文+古音是最完美的，但是這可能會把不少沒接觸古漢語讀音的人拒之門外，曲高和寡，哈哈


Behavior of

Describe your problem
When I am using html tags inside the <code>..</code> tag the code doesn't display as it should after saving.
Expected behavior
It should be displayed like this:

Actual behavior
But after saving once it looks like this:

Whilest in the real blogpost it is still as it should:

After saving a second time, everything is messed up:

I did also get the issue with SimpleMDE.
Steps to reproduce the problem
Create a new post, create a code example and save twice.
Bludit version
3.9.0-beta, also tried 3.8.1 before

Try changing this line https://github.com/bludit/bludit/blob/master/bl-kernel/admin/views/edit-content.php#L338
<?php echo $page->contentRaw(false) ?>

to
<?php echo $page->contentRaw(true) ?>

Not sure if this is the fix.

Works now! Thx


src-cli: init at 4.3.0

Description of changes
Add src-cli the Sourcegraph CLI utility.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Thanks for the review, I squashed your changes into one commit.

@fabaff could you take another look at this? I just updated to the latest release.


Update kctrl usage docs to use a different namespace and not the default one

Describe the problem/challenge you have
From the docs Consuming Packages using CLI, when I copy the command to install the TCE repository and run it, I get an error saying Error: Creating sensitive resources in a shared namespace (default) which is expected but probably not a good experience for someone who is trying it out for the first time.
Describe the solution you'd like
The example usage should use the -n flag to specify a namespace to adhere to the new behaviour of kctrl.
Anything else you would like to add
The same should be done for other examples as well.

@praveenrewar is this issue still relevant? Is this problem related to TCE specifically or more how the code sample is written? I'd be interested to know how removing TCE references from this page would impact the code references.

@a-mccarthy This issue is not relevant to TCE.
@microwavables brought this up a couple of days back. I will be making some changes to this page to remove TCE references. We could just use some other package repository and that should be fine, but I want to ensure that we can use that same package repository for the end to end workflow described in this page. So I am planning to create a test package repository and use that here.

Thanks @praveenrewar! Is there a documentation label we can add to this issue?

@a-mccarthy Done!


Colour handling in Win11

Is your feature request related to a problem? Please describe.
App defaults to white. However this can be hard to see when on a light background.
Describe the solution you'd like
I'd like to see the option to either support the current OS colour scheme or to set the app colour for the system tray icon.

Also, would be good if there was an option to have it always show by the clock and not in the popup menu itself so it's always visible.

Hi again Oliver,
Icon colors cannot currently be changed in the lightweight version of WeekNumber (WeekNumber Lite). With development skills you could download the source code and compile it yourself after making modifications (ref. source code here), but I realize this might not be in your comfort zone or something you would like to, or have time to, try out.
When it comes to placement of the application icon this is easy for you to adjust yourself, just click and hold the mouse button down while you drag the icon down into the taskbar area closer to the clock. This is also described in the Help section for the full WeekNumber app.


Fix repo url

I'm looking into installing pulsar on GenOuest (exciting!), so here's a first little doc fix
(I'll continue tomorrow)

Wow, really, made my day!


Restore Library Evolution support for Xcode 16

Builds for Library Evolution support, and patches a small issue in this repository causing an issue for us, i.e. -

Adds Library Evolution support target replicating the issue to CI

Additional Notes
I noticed this comment; we're needing Library Evolution support for some beta apps we're working on using swift-dependencies.
Happy to assist with the maintenance, as far as it useful !

Thanks!


Add files via upload

IT High School in Turin. Site: https://www.istitutoprimolevi.edu.it/

@ProfCasellato The first verification stage is complete: the official domain for  IIS Primo Levi is www.istitutoprimolevi.edu.it, to the best of my knowledge. This is just an informational note. The pull request is still under review. The review may take some more time. I greatly appreciate your patience. Here is the proof of domain ownership: https://www.istitutoprimolevi.edu.it/info-generali/direttore-dei-servizi-generali-e-amministrativi-dsga/

Good morning.
I'm Happy to hear you.
For every question, I'm here.
Prof. Casellato Fabrizio
Il Mer 27 Mar 2024, 05:33 Philip Torchinsky @.***> ha
scritto:

@ProfCasellato https://github.com/ProfCasellato The first verification
stage is complete: the official domain for IIS Primo Levi is
www.istitutoprimolevi.edu.it, to the best of my knowledge. This is just
an informational note. The pull request is still under review. The review
may take some more time. I greatly appreciate your patience. Here is the
proof of domain ownership:
https://www.istitutoprimolevi.edu.it/info-generali/direttore-dei-servizi-generali-e-amministrativi-dsga/
—
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/20461#issuecomment-2021908865,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGOFW6E27CUULYXJ6FRBYBDY2I42HAVCNFSM6AAAAABFJIVDMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRRHEYDQOBWGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

@ProfCasellato The first verification stage is complete: the official domain for  IIS Primo Levi is www.istitutoprimolevi.edu.it, to the best of my knowledge. This is just an informational note. The pull request is still under review. The review may take some more time. I greatly appreciate your patience. Here is the proof of domain ownership: https://www.istitutoprimolevi.edu.it/info-generali/direttore-dei-servizi-generali-e-amministrativi-dsga/

@ProfCasellato Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Can't continue past Open Keychain dialog when recipient has more than one key

Expected behavior
When a recipient has more than one key in Open Keychain, the correct one can be selected and the message sent.
Actual behavior
Open Keychain opens and displays the list of keys. (All are pre-selected.) Tapping "OKAY" just redisplays the list, regardless of how many keys are selected or deselected.
Steps to reproduce

Configure a user in Open Keychain with more than one key.
Compose a message to that user.
Tap the send button.
Select zero or more keys for the user in Open Keychain and tap "OKAY".
Observe results.

Environment
K-9 Mail version: 5.201
Android version: Marshmallow
Account type (IMAP, POP3, WebDAV/Exchange):
IMAP

add your issue here:
https://github.com/open-keychain/open-keychain/issues/1942

Thanks. Wasn't sure if it was Open Keychain itself or K9 sending me back to it.


add prometheus library

Hey Zephyr Community! 🚀
I'm excited to announce the launch of our latest addition to the Zephyr ecosystem: the Zephyr Prometheus Library! 🎉
What is Zephyr Prometheus Library?
Zephyr Prometheus is a lightweight library designed to seamlessly integrate Prometheus metrics into your Zephyr projects. Whether you're developing for IoT, edge computing, or any other embedded application with Zephyr, monitoring and collecting metrics is now easier than ever.
Features:
📊 Effortless Integration: With just a few lines of code, you can start exposing custom metrics from your Zephyr applications.
🔍 Flexible Metrics Collection: Monitor crucial aspects of your application's performance, such as memory usage, task execution times, and custom-defined metrics.
🔒 Secure Communication: Ensure the integrity and confidentiality of your metrics data with secure communication protocols supported by Zephyr.
we'r talk about that pr following discussion: #72127
Metric Server

Grafana

Signed-off-by: Mustafa Abdullah Kus<EMAIL_ADDRESS>

Looks good, some notes:
* The `pm_` namespace is used for "power management", maybe update it to `net_pm`, or `pmts_`? or simply `prometheus_`

* I think prometheous may be better placed in `subsys/mgmt` alongside integrations like mcumgr, rather than `net`, where we have MQTT, IPV4 etc

i will change with prometheus instead of others, first of all i did think that name but give up that name because its too long. if that namespace conflict with power management, should be change. i guess best way change with prometheus namespace.
i dont sure about place. mr @jukkar (https://github.com/zephyrproject-rtos/zephyr/discussions/72127) did suggest to me that place. if best place, i can change with gladly :)

About the location, I initially thought the net for this but as @bjarki-trackunit mentioned, the mgmt is also possible. I do not have strong opinion about this, what people in the review list think?

About the location, I initially thought the net for this but as @bjarki-trackunit mentioned, the mgmt is also possible. I do not have strong opinion about this, what people in the review list think?

I waiting to opinion for re-place library components. For now i did solve @jukkar reviewed points.

Also we will need some tests for these, could be placed for example to tests/net/lib/prometheus

Also we will need some tests for these, could be placed for example to tests/net/lib/prometheus

We did decide about library place? Can i integrate to under net/lib for now ?

We did decide about library place? Can i integrate to under net/lib for now ?

I think there is no consensus yet, it should be trivial change if the location is changed, just some git mv

Hi @jukkar
I did add tests. Should i generate coverage report and expand test coverage? Is it enough?

Some tests are definitely malformed :) check collector/prj.conf for example.
Try building every test locally, I recommend building each test for native_sim and running it locally (from workspace dir):
~/workspace west build -p -b native_sim zephyr/tests/net/lib/prometheus/counter/
~/workspace ./build/zephyr/zephyr.exe

Then once all tests seem to build and run as expected, run twister locally to build and run the tests for all supported platforms:
~/workspace ./zephyr/scripts/twister -T zephyr/tests/net/lib/prometheus/

Counting on CI is way to slow (and wasteful)

I wonder, shall we add a new entry for the library/sample in MAINTAINERS.yml file?

How should i add maintainer section truthly?

I wonder, shall we add a new entry for the library/sample in MAINTAINERS.yml file?

How should i add maintainer section truthly?

Have it been settled whether the library will end up in subsys/mgmt or subsys/net? In any case though, it's just a matter of creating a new entry in the MAINTATINERS.yml file, like for example this one:
https://github.com/zephyrproject-rtos/zephyr/blob/main/MAINTAINERS.yml#L2655

@mustafaabdullahk there is some compliance issues reported by CI, could you check those?
Please ignore the der binary file report, we will ask exception to this when the PR is accepted and ready to be merged.
Error: No binary files allowed.

 Binary file not allowed: samples/net/prometheus/src/ca.der
 Binary file not allowed: samples/net/prometheus/src/https-server-cert.der
 Binary file not allowed: samples/net/prometheus/src/https-server-key.der
 Binary file not allowed: samples/net/prometheus/src/server.der
 Binary file not allowed: samples/net/prometheus/src/server_privkey.der
Compliance error, check for error messages in the "Run Compliance Tests" step
You can run this step locally with the ./scripts/ci/check_compliance.py script.
Error: Process completed with exit code 1.

Please ignore the der binary file report, we will ask exception to this when the PR is accepted and ready to be merged.

It would be really great if we could avoid adding binary files to the tree. Can't these be generated by the user?

It would be really great if we could avoid adding binary files to the tree. Can't these be generated by the user?

That is certainly possible but requires changes to the current workflow in the networking samples that need TLS support. For the user it is quite convenient if the certificates are already there when using the net sample.
One option could be to store only one set of certificates that all the networking samples could use, this way updating the certs could be done in one place.

It would be really great if we could avoid adding binary files to the tree. Can't these be generated by the user?

That is certainly possible but requires changes to the current workflow in the networking samples that need TLS support. For the user it is quite convenient if the certificates are already there when using the net sample. One option could be to store only one set of certificates that all the networking samples could use, this way updating the certs could be done in one place.

I don't think users can generate own certificates in all cases, various samples acting as TLS client often use official CA certificates to connect to public servers, which need to be somehow provided to the sample. And DER format (although considered binary) seems to be the most memory-efficient way to provide certs (it's not that we'll be "patching" those files anyway, typically they're replaced as a whole).
But for the TLS server cases, we could have common certificates for all samples (possibly under samples/net/common/). Not sure such a cleanup applies to this PR though.

@carlescufi could you force push this, the CI complains about binary certificate files so this needs higher powers.

@kartben you have -1 to this, could you recheck?

I think https://github.com/zephyrproject-rtos/zephyr/pull/72804#discussion_r1715839665 still applies but maybe it's not enough to justify a -1
btw, @mustafaabdullahk  in the future please don't mark comments as resolved until the original commenter had a chance to check for themselves.
I will trust that you indeed resolved all the comments for the sake of unblocking the PR, but I'd have much preferred being able to easily be able to check myself :) Please see https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers

btw, @mustafaabdullahk in the future please don't mark comments as resolved until the original commenter had a chance to check for themselves.
I will trust that you indeed resolved all the comments for the sake of unblocking the PR, but I'd have much preferred being able to easily be able to check myself :) Please see

I was really wondering 'mark as resolved' button who should mark. I will do your suggestion in future PRs :). Thank you

I was really wondering 'mark as resolved' button who should mark.

Indeed, even as I am a long time contributor, I have been wondering that myself too. I usually mark things resolved in order to keep track what I have fixed in my own PRs, but I suppose it can be useful info also for the reporter. Too bad there isn't two buttons, one for reporter and one for the developer, to track these things.

@mustafaabdullahk To be clear you might very well have done the right thing as per the document I linked, if you applied all my suggestions verbatim, so no worries. It's just that my recollection is that I made some suggestions that were not directly "suggested changes" that could just be applied "as-is" so was definitely expecting to have to come back to the associated comments to check how you applied the suggestions :) Anyhow, again, no worries, and thanks for the great PR!

The CI is complaining about the presence of binary files.

Error: No binary files allowed.
Binary file not allowed: samples/net/prometheus/src/ca.der
Binary file not allowed: samples/net/prometheus/src/https-server-cert.der
Binary file not allowed: samples/net/prometheus/src/https-server-key.der
Binary file not allowed: samples/net/prometheus/src/server.der
Binary file not allowed: samples/net/prometheus/src/server_privkey.der

Propositions:

include a PEM file and convert it into DER at build-time,
store DER as base64/hexdump
generate new certificates at build-time.
allow .der files

commit 7b57d3c5bbd151dfa4d94f3434488b4595f07022
Author: @fabiobaltieri
Date:   Mon Nov 21 13:43:55 2022 +0000
scripts: compliance: check for binary files

Add a compliance check that fails if the diff is adding any binary file
to prevent committing them by mistake.

Only check for added files and explicitly allow image files in doc/ and
boards/.

Signed-off-by: Fabio Baltieri<EMAIL_ADDRESS>

The CI is complaining about the presence of binary files.

Error: No binary files allowed.
Binary file not allowed: samples/net/prometheus/src/ca.der
Binary file not allowed: samples/net/prometheus/src/https-server-cert.der
Binary file not allowed: samples/net/prometheus/src/https-server-key.der
Binary file not allowed: samples/net/prometheus/src/server.der
Binary file not allowed: samples/net/prometheus/src/server_privkey.der

Propositions:
* include a PEM file and convert it into DER at build-time,

* store DER as base64/hexdump

* generate new certificates at build-time.

* allow `.der` files

It has been agreed that for the binary certificate files, we ask exception to merge. So no worries for this.

@nashif / @carlescufi please force push to override the binary file check issue

I am curious to know the answer for this comment .https://github.com/zephyrproject-rtos/zephyr/pull/72804#pullrequestreview-2138939367
Can this be a module inside the lib folder?

There is one compliance error that we could fix
 OPEN_BRACE: that open brace { should be on the previous line
File:samples/net/prometheus/src/main.c
Line:76
Compliance error, check for error messages in the "Run Compliance Tests" step
You can run this step locally with the ./scripts/ci/check_compliance.py script.
Error: Process completed with exit code 1.

There is one compliance error that we could fix
 OPEN_BRACE: that open brace { should be on the previous line
File:samples/net/prometheus/src/main.c
Line:76
Compliance error, check for error messages in the "Run Compliance Tests" step
You can run this step locally with the ./scripts/ci/check_compliance.py script.
Error: Process completed with exit code 1.

I just apply clang-format. Check complience pipeline give error following type.
struct http_resource_detail_dynamic dyn_resource_detail = {
	.common =
		{
			.type = HTTP_RESOURCE_TYPE_DYNAMIC,
			.bitmask_of_supported_http_methods = BIT(HTTP_GET),
			.content_type = "text/plain",
		},
	.cb = dyn_handler,
	.user_data = NULL,
};

but if i move to bracket previous line like following i give warning (https://github.com/zephyrproject-rtos/zephyr/actions/runs/11113829987). Which one is true?:
struct http_resource_detail_dynamic dyn_resource_detail = {
	.common = {
			.type = HTTP_RESOURCE_TYPE_DYNAMIC,
			.bitmask_of_supported_http_methods = BIT(HTTP_GET),
			.content_type = "text/plain",
		},
	.cb = dyn_handler,
	.user_data = NULL,
};

As Pieter said, just ignore the clang- format suggestions for now.

@josuah gentle ping :)

congratulations! :champagne:


Usecases other than WebAssembly

Hi, I've been reading this proposal and WebAssembly ESM integration, which seem to have quite an overlap in usecases it tries to cover.

I quite like what's described in WebAssembly ESM integration, however if we subtract WebAssembly from this proposal, I don't quite see many cases where "source phase imports" could be useful outside of WebAssembly. Do you have more examples to share where this proposal is useful outside of WebAssembly in practice?

If the focus for now is only for WebAssembly, and that this proposal tackles the specific "arbitrary WebAssembly instantiation and custom imports" problem, could we address this problem directly in WebAssembly ESM integration instead? For example, Vite's WASM support relies on ?init to return a WebAssembly instantiation function. Could we rely on a sort of type: "wasm-init" import attribute to cover this case?

I also noticed that the introduction of "phase" could make way for Assets References. However, it's unclear to me if that's set in stone and can be leveraged, e.g. why that proposal couldn't rely on import attributes instead?

Thanks! I have some concerns that this is "one more thing" users have to learn, and that it affects downstream JS tooling, so I hope to better understand the context here to judge the tradeoffs.

Hey @bluwy thanks for the great questions here. A lot of justification in the early stages of this proposal went into these topics, but I can try and share some more up to date thoughts on the topic here -

There is a follow-up proposal in https://github.com/tc39/proposal-esm-phase-imports to support phase imports for JS modules. It was easier to start with Wasm since it already defines a representation, but we do also want this representation for JS as it represents the virtualization primitive that gets us to module expressions, module declarations and finally full virtualization.
The reason we need a direct integration is because by tying the Wasm source directly to the origin, we are able to treat it not just like an arbitrary eval but as a capability for a module that can be passed around, since the module system can have script-src policies that must apply to where code is permitted from. Since import attributes form part of the cache key it is important that we share the cache key in the phasing model with the module instance, as this is a fundamental property required for module expressions. In addition this would have required a new import attributes capability for Wasm to load other Wasm in the instance phase of the ESM integration proposal.
I'd love to pick up on assets. Whether assets are actually a phase or not is an interesting question - I can see benefits to both sides. It could well be worth restarting these discussions. The other phase to be aware of is the defer phase - see https://github.com/tc39/proposal-defer-import-eval.

Happy to discuss further here.

Thanks for the links! I haven't found them before and I really helps paint the bigger picture now. I agree with your answers there too, they make sense to me.
I don't have any follow-up questions for now. I do still feel a bit that increases the surface area of imports, but I don't really have any solution to suggest, given how it's being relied upon by the other proposals too.
It would be nice though if the proposals have more backlinks to understand them better, but I'll leave it to you if you think it's ready to do so. I'll close this issue for now. Thanks again!

The best way to follow the history is probably reading through the old TC39 agenda presentations and notes, starting from being called evaluator attributes in https://github.com/tc39/agendas/blob/main/2021/10.md, then becoming import reflection in https://github.com/tc39/agendas/blob/main/2022/06.md, https://github.com/tc39/agendas/blob/main/2022/11.md and https://github.com/tc39/agendas/blob/main/2023/03.md, and then finally becoming source phase imports in https://github.com/tc39/agendas/blob/main/2023/05.md and reaching Stage 3 in https://github.com/tc39/agendas/blob/main/2023/07.md, I know that's a lot though!
I'd highly recommend following and sharing input in the upcoming proposals for ESM Source Phase, Module Expressions and Module Declarations as these continue to develop as part of what we call the "module harmony" effort.

That's indeed a lot 😄 but thanks for the links! I'll keep an eye for the other proposals for sure.
I was particularly interested in this one since it reached stage 3 and introduces a big change on import statements parsing and module cache keying that'll affect Vite and other ecosystems. For example, import attributes had affected Vite & Rollup where we're still in the process of specifically adapting the keying part, since we had always keyed by the module id/url (string) only.


Get rid of unused Collection.no_fail

What's the replacement ? We still need this

But... it is isn't in use in the codebase?
Is it used somewhere in BPA?  It should be better documented at least so it has some meaning... no_fail is pretty obscure... :-D

Does neither your IDE or your email have a search function?
We discussed this. It's used by RemoteControl to tell it to just return
None if the animation doesn't load so that it can just show a greyed out
button instead of bombing the whole thing.
This is required because otherwise a lot of demos will just fail if you are
missing depends for just one animation with is unacceptable. So yea, we
absolutely require this... you can change the name though, just update
RemoteControl to match.
On Thu, Aug 24, 2017 at 11:13 AM, Tom Swirly<EMAIL_ADDRESS>wrote:

But... it is isn't in use in the codebase?
Is it used somewhere in BPA? It should be better documented at least so it
has some meaning... no_fail is pretty obscure... :-D
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/403#issuecomment-324665210,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6rm60GSHnhCxnZ49TIj__TIFkTt_ks5sbZMVgaJpZM4PBTey
.

Ah, weirdness.
I did search this, but somehow my search environment is screwed up (seems to have a permanent -w in it!)
I realize that I have kept this emacs session up since April, so I rebooted it.
OOOOOOOPS!

Ohhhhhh...burn. You even said no fail was a great feature and should be
default ;)

class Collection(animation.BaseAnimation):

def init(self, layout, animations=None):

def init(self, layout, animations=None, no_fail=False):

This is a great feature, and to be honest, perhaps it should be the default?
From here:
https://github.com/ManiacalLabs/BiblioPixel/pull/308#discussion_r128911814
On Thu, Aug 24, 2017 at 11:17 AM, Adam Haile<EMAIL_ADDRESS>wrote:

Does neither your IDE or your email have a search function?
We discussed this. It's used by RemoteControl to tell it to just return
None if the animation doesn't load so that it can just show a greyed out
button instead of bombing the whole thing.
This is required because otherwise a lot of demos will just fail if you
are missing depends for just one animation with is unacceptable. So yea, we
absolutely require this... you can change the name though, just update
RemoteControl to match.
On Thu, Aug 24, 2017 at 11:13 AM, Tom Swirly<EMAIL_ADDRESS>wrote:

But... it is isn't in use in the codebase?
Is it used somewhere in BPA? It should be better documented at least so
it has some meaning... no_fail is pretty obscure... :-D
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/403#issuecomment-324665210,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6rm60GSHnhCxnZ49TIj__TIFkTt_ks5sbZMVgaJpZM4PBTey
.

Er, yeah, why isn't it the default?
:-D

let me change this to do that.

LOL... idk... because in a script I do want it to hard fail otherwise I'll
wonder where that animation went.
On Thu, Aug 24, 2017 at 11:33 AM, Tom Swirly<EMAIL_ADDRESS>wrote:

Er, yeah, why isn't it the default?
:-D
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/403#issuecomment-324671666,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6gY_Tt24gwgmPPV5C7Y24WbTnK8rks5sbZe4gaJpZM4PBTey
.

OK, so, I'm still not convinced that it does anything.  Can you point me to code where you use it?
https://github.com/ManiacalLabs/BiblioPixel/search?utf8=✓&q=no_fail&type=

https://github.com/ManiacalLabs/BiblioPixel/blob/master/bibliopixel/remote/control.py#L73
Ok, fair... it's positional.
On Thu, Aug 24, 2017 at 11:43 AM, Tom Swirly<EMAIL_ADDRESS>wrote:

OK, so, I'm still not convinced that it does anything. Can you point me to
code where you use it?
https://github.com/ManiacalLabs/BiblioPixel/search?utf8=✓&q=no_
fail&type=
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/403#issuecomment-324674854,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6odWrejudeznRsBOkmvVeuGf7rYOks5sbZo7gaJpZM4PBTey
.

OK, but then nothing happens when you set the parameter!

What? Examples Tom, examples.
On Thu, Aug 24, 2017 at 11:47 AM, Tom Swirly<EMAIL_ADDRESS>wrote:

OK, but then nothing happens when you set the parameter!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/403#issuecomment-324675877,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6mGNbOme4WrMCFbnr4X8dYu6HwVmks5sbZsJgaJpZM4PBTey
.

https://github.com/ManiacalLabs/BiblioPixel/blob/master/bibliopixel/animation/collection.py
This seems like the only place that no_fail is used.  But it appears to have no effect!
https://github.com/ManiacalLabs/BiblioPixel/blob/master/bibliopixel/animation/collection.py#L37-L59

Oh... Ha, that exception should check and fail of false. I didn't notice
cause where I use it I always want it to not fail
On Aug 24, 2017 12:19 PM, "Tom Swirly"<EMAIL_ADDRESS>wrote:

https://github.com/ManiacalLabs/BiblioPixel/blob/
master/bibliopixel/animation/collection.py
This seems like the only place that no_fail is used. But it appears to
have no effect!
https://github.com/ManiacalLabs/BiblioPixel/blob/
master/bibliopixel/animation/collection.py#L37-L59
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/403#issuecomment-324684750,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6if5D1KLWRSdxKHKn7aiBprbnfV2ks5sbaKcgaJpZM4PBTey
.

All right, try this!
It's now a constant on Collection, but one you can set from a command line
flag.
On Thu, Aug 24, 2017 at 6:21 PM, Adam Haile<EMAIL_ADDRESS>wrote:

Oh... Ha, that exception should check and fail of false. I didn't notice
cause where I use it I always want it to not fail
On Aug 24, 2017 12:19 PM, "Tom Swirly"<EMAIL_ADDRESS>wrote:

https://github.com/ManiacalLabs/BiblioPixel/blob/
master/bibliopixel/animation/collection.py
This seems like the only place that no_fail is used. But it appears to
have no effect!
https://github.com/ManiacalLabs/BiblioPixel/blob/
master/bibliopixel/animation/collection.py#L37-L59
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/ManiacalLabs/BiblioPixel/pull/
403#issuecomment-324684750>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AA6a6if5D1KLWRSdxKHKn7aiBprbnfV2ks5sbaKcgaJpZM4PBTey>

.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/403#issuecomment-324685223,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPdspdOdZKEG07t17t8ZlOQZUjUDeQqks5sbaMKgaJpZM4PBTey
.

--
/t
https://tom.ritchford.com https://tom.ritchford.com
https://tom.swirly.com https://tom.swirly.com


Continuous clicking on the top button will cause app deadlock

Click the button on the top right corner of home continuously, and the top right corner of the chat interface will cause app deadlock
Summary
Bug report in one concise sentence
Environment Information

Device Name:SANSUNG Huawei
OS Version:android 12 harmonuOS
Mattermost App Version:2.0.0

It seems that every function involving the bottom frame will be deadlocked, and the setting of online status will also be deadlocked

What version of the app are you running? As that was fixed with https://github.com/mattermost/mattermost-mobile/pull/7078

您运行的是什么版本的应用程序？因为这是用#7078修复的

C:\Users\Administrator>react-native --version
react-native-cli: 2.0.1
react-native: 0.71.0

I'm talking about the app not the version if react native...
It looks like you are running in developer mode, so fetching the latest main branch should resolve it or just cherry pick the PR I just linked

如果反应本机，我说的是应用程序而不是版本......
看起来你在开发者模式下运行，所以获取最新的主分支应该可以解决它或者只是挑选我刚刚链接的 PR

[Mobile Version 2.0.1]   It seems that your test machine will also appear

No

不

Excuse me, how does the APP change password appear

What is this issue about.. this seems to random. Closing

这个问题是关于什么的……这似乎是随机的。关闭

这个问题是关于什么的……这好像是随机的。关闭

Sorry to trouble U，   I downloaded the latest client code and found that as long as you quickly click the menu in the upper right corner, the deadlock will still occur. The frequency of clicking 20 times a second app screens navigation. ts export async function dispissModal() will not be triggered. Pay attention to whether the pop-up box at the bottom is closed.

Normal click will have "dismissionModal", and quick click will not trigger
function onCommandListener(name: string, params: any) {
switch (name) {
case 'setRoot':
NavigationStore.clearScreensFromStack();
NavigationStore.addScreenToStack(params.layout.root.children[0].id);
break;
case 'push':
NavigationStore.addScreenToStack(params.layout.id);
break;
case 'showModal':
NavigationStore.addModalToStack(params.layout.children[0].id);
break;
case 'popToRoot':
NavigationStore.clearScreensFromStack();
NavigationStore.addScreenToStack(Screens.HOME);
break;
case 'popTo':
NavigationStore.popTo(params.componentId);
break;
case 'dismissModal':
NavigationStore.removeModalFromStack(params.componentId);
break;
}

like this：
https://user-images.githubusercontent.com/10607980/219575852-c29472d0-4555-4d7b-a0c2-495ce18e5bc2.mp4
That mask will never be removed


Add MIT license

Closes #8

Could you make it say "Andrew Vos and contributors"? Otherwise it's good IMO.


[docs]  - new accepted metric -  purefa_array_object_limit

Documentation update for the accepted metric in #64

Should we not also be listing the limits for IQN, WWN, NQN, host as well?

This metric is in the Accepted status  - "The metric may not be currently available in the Purity API, but has been selected for development for the OME if or when available."
The exact data model of the exporter will be defined by the API when defined by Purity, the data model will include all the limit types that will be defined by the API.


I don't need your tests in my production.

see https://www.reddit.com/r/PHP/comments/2jzp6k/i_dont_need_your_tests_in_my_production

@Ocramius now leaving the README.md

@butonic thanks!


Add support for icingaweb2 monitoring module

Add support for both the monitoring module and the new icingadb module.

This is also already implemented. 😒

The documentation is missing for this part. (kinda)


Re-organize and add additional content to First Steps

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Yiren Lu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.