Use proper configurations for csv reading/writing (#427)

Codecov Report

Merging #458 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   85.12%   85.16%   +0.03%
==========================================
  Files          39       40       +1
  Lines        1829     1833       +4
==========================================
+ Hits         1557     1561       +4
  Misses        272      272

Impacted Files
Coverage Δ

hca/util/csv.py
100% <100%> (ø)

hca/dss/__init__.py
90.13% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d844f3...b8f0b31. Read the comment docs.

@GPelayo good point!
On Tue, Oct 15, 2019 at 1:32 PM Geryl Pelayo<EMAIL_ADDRESS>wrote:

Assigned #458 https://github.com/HumanCellAtlas/dcp-cli/pull/458 to
@jessebrennan https://github.com/jessebrennan.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/HumanCellAtlas/dcp-cli/pull/458?email_source=notifications&email_token=ACR4ZFFGYYXBZBSGDYGE6L3QOYSE5A5CNFSM4I7CPHEKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUHMSMEY#event-2715362835,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACR4ZFD4YKNQWGBE5EMZTULQOYSE5ANCNFSM4I7CPHEA
.

@hannes-ucsc conflicts are resolved. I'm assigning back to you for re-review, then I can autosquash / merge.


All vulnerabilities are not reported in one run

Using dependency-check 6.0.3 with Jenkins OWASP Dependency-Check Plugin v5.1.1.
Not sure whether the problem is with dependency-check or with Jenkins plugin, but when I run a scan I do not get to see ALL vulnerabilities in one run. In the initial run, scan reported around 10 vulns and when I added a suppression to them, it started showing more. And this continues..

If you look at the HTML report before adding the suppression file you would see a "related dependencies" section that is minimized. ODC attempts to bundle related JARs into a single entry to avoid duplication. For instance you might have several "spring" related jars that are all at version 3.5.1 - in general the fix would be to upgrade them all at the same time. As such, ODC bundles these together.
In most cases, the suppression rules can be modified to include all of the related JARs by modifying the regex to be a bit broader.

Thanks for that. I can see them under the section you mentioned. The important thing then is to always look at HTML report, not just what gets displayed under dependency check results in Jenkins build, that makes one believe these are the only vulns, which is not correct.
I think have a warning or information message on Jenkins report would help. Something like - There could be more vulnerabilities detected in related files, which are not displayed here. Check HTML report for complete list of vulnerabilities.


Windows + Omnisharp = [WinError 10061]

with latest version of Omnisharp on Windows, there is an issue with:
ConnectionRefusedError: [WinError 10061] No connection could be made because the target machine actively refused it

it looks like it's caused by omnisharp server who is executed but does not run in background. Sublime console is showing:
omnisharp plugin_loaded
project file %s found D:\_demo\editors\Calculator\calculator.sublime-project
solution_path:D:\_demo\editors\Calculator\Calculator.sln
omni_port:51921
D:/Tools/Sublime/Data/Packages/OmniSharp
"D:/Tools/Sublime/Data/Packages/OmniSharp/PrebuiltOmniSharpServer/omnisharp.cmd" -s "D:\_demo\editors\Calculator\Calculator.sln" -p 51921 -config "D:\Tools\Sublime\Data\Packages\config.json" --hostPID 6224

but when you try netstat -anb you will not find anything listening on port 51921.
executing same command from command line however starts server and it allows sublime omnisharp to communicate with it. Therefore solution for now is executing server manually with latest command from sublime console.
not sure why this is happening, but it is in ver 1.9.1 on my computer at least.

If you'd like to investigate note please feel free. At the mo I'm
concentrating on OS X really
On Sunday, 19 April 2015, Jakub Gutkowski<EMAIL_ADDRESS>wrote:

with latest version of Omnisharp on Windows, there is an issue with:
ConnectionRefusedError: [WinError 10061] No connection could be made because the target machine actively refused it
it looks like it's caused by omnisharp server who is executed but does not
run in background. Sublime console is showing:
omnisharp plugin_loaded
project file %s found D:_demo\editors\Calculator\calculator.sublime-project
solution_path:D:_demo\editors\Calculator\Calculator.sln
omni_port:51921
D:/Tools/Sublime/Data/Packages/OmniSharp
"D:/Tools/Sublime/Data/Packages/OmniSharp/PrebuiltOmniSharpServer/omnisharp.cmd" -s "D:_demo\editors\Calculator\Calculator.sln" -p 51921 -config "D:\Tools\Sublime\Data\Packages\config.json" --hostPID 6224
but when you try netstat -anb you will not find anything listening on
port 51921.
executing same command from command line however starts server and it
allows sublime omnisharp to communicate with it. Therefore solution for now
is executing server manually with latest command from sublime console.
not sure why this is happening, but it is in ver 1.9.1 on my computer at
least.
--
Reply to this email directly or view it on GitHub
https://github.com/OmniSharp/omnisharp-sublime/issues/167.

Having the same issue. Works fine until after a few commands
 Url: http://localhost:17899/autocomplete
 Data: {"column": "18", "WantMethodHeader": true, "filename": "C:\\projects\\customer\\src\\someproject\\Source\\MyProject\\customer.MyProject\\Persistence\\ResultPersister.cs", "buffer": "//...[redacted]", "line": "19", "WantSnippet": true, "wordToComplete": "_file", "WantReturnType": true}
project file %s found C:\projects\customer\src\someproject\Source\MyProject\MyProject.sublime-project
solution path: C:\projects\customer\src\someproject\Source\MyProject\MyProject.sln
======== request ========
 Url: http://localhost:17899/autocomplete
 Data: {"column": "18", "WantMethodHeader": true, "filename": "C:\\projects\\customer\\src\\someproject\\Source\\MyProject\\customer.MyProject\\Persistence\\ResultPersister.cs", "buffer": "//...[redacted]", "line": "19", "WantSnippet": true, "wordToComplete": "_file", "WantReturnType": true}
project file %s found C:\projects\customer\src\someproject\Source\MyProject\MyProject.sublime-project
solution path: C:\projects\customer\src\someproject\Source\MyProject\MyProject.sln
======== request ========
 Url: http://localhost:17899/autocomplete
 Data: {"column": "19", "WantMethodHeader": true, "filename": "C:\\projects\\customer\\src\\someproject\\Source\\MyProject\\customer.MyProject\\Persistence\\ResultPersister.cs", "buffer": "//...[redacted]", "line": "19", "WantSnippet": true, "wordToComplete": "_fileS", "WantReturnType": true}
HTTPConnectionPool(host='localhost', port=17899): Max retries exceeded with url: /autocomplete (Caused by ProtocolError('Connection aborted.', ConnectionRefusedError(10061, 'No connection could be made because the target machine actively refused it', None, 10061)))
HTTPConnectionPool(host='localhost', port=17899): Max retries exceeded with url: /autocomplete (Caused by ProtocolError('Connection aborted.', ConnectionRefusedError(10061, 'No connection could be made because the target machine actively refused it', None, 10061)))
HTTPConnectionPool(host='localhost', port=17899): Max retries exceeded with url: /autocomplete (Caused by ProtocolError('Connection aborted.', ConnectionRefusedError(10061, 'No connection could be made because the target machine actively refused it', None, 10061)))

What seems to be working for now, is to set the timeout higher in the settings.
"omnisharp_response_timeout": 500

Not sure if there's a causal connection, but so far it's working consistently. Server hasn't stopped in 30 mins, where usually it wouldn't last even a couple of minutes.

@koenmetsu Have you found out what's going on under there? I tried your solution to set the omnisharp_response_timeout longer, but it still won't working properly.

No, I haven't looked into this anymore due to other prios. Sorry I can't
help you :)
On Wed, Oct 14, 2015 at 9:11 AM, Ming Zhou<EMAIL_ADDRESS>wrote:

@koenmetsu https://github.com/koenmetsu Have you found out what's going
on under there? I tried your solution to set the
omnisharp_response_timeout longer, but it still won't working properly.
—
Reply to this email directly or view it on GitHub
https://github.com/OmniSharp/omnisharp-sublime/issues/167#issuecomment-147958511
.

@koenmetsu Nah, that's okay, I'd probably switch to atom if I could get all the packages I need works harmoniously. It's really slow though..

I've got the same issue.


WIP: overhaul task/executor story

This PR does most of the work toward clarifying our task/executor story.
Basic executors
The basic idea is that futures themselves do not know or control how/where they are executed. In order to run a future, you need to create a task, and at that point you bind the future/task to an executor. In this PR there are three executors:

futures::Inline: the "inline" executor just runs a future immediately whenever/wherever it is signaled for readiness. This is what we had as the default behavior previously. Requires Send + 'static

futures_mio::LoopHandle: executes the task on the event loop, to which it is pinned. In other words, all polling of the task happens on the event loop; signaling readiness to the task just enqueues a notification to the event loop. Requires the future to be Send (since we are moving it onto the loop). But not 'static -- see below.

futures_mio::LoopPin: like LoopHandle, but does not require the future to be Send, because the future is guaranteed to already be located on the event loop thread.

In terms of relaxing 'static, the event loop now takes a lifetime, tying it to a particular stack frame whose data you can access within loop futures. This will allow you to share & references among futures running within the event loop.
Unpark/Executor revamp
To make the above work, I've revamped the representation such that blocked tasks are represented by an Unpark trait. This is basically where the core executor code lives -- it says what to do when you want to continue executing a task.
Executors themselves only provide a way to spawn tasks, at which point they'll construct an Arc<Unpark> to be used to continue poking the task in the future.
Spawning
To actually use one of the executors, there are spawn methods on Future and Stream:

my_future.spawn(executor): spawns the future on the given executor, returning a new future that proxies its result. By default, the task is "daemonized": it will continue even if the proxy future is dropped. I believe this is the least surprising behavior. There's also a cancel method on the proxy, however.

my_stream.spawn(executor): spawns the stream on the given executor, returning a new stream that proxies its results. The subtask progresses only on demand: until more items are requested from the proxy stream, the subtask will idle.

Yielding
There's now a task::yield_now method which can be used to signal that you want to poll the current task again even on NotReady. Useful for cooperative execution.
Task-local data
I've renamed TaskData to TaskRc, to better reflect what it's doing. I'm planning to add a new TaskData that uses something like typemap to provide something more like thread-local storage.

A big TODO item is pushing this through curl, etc.

Thanks for this, I think that the executor has been much improved by this change. I do have one bike shed that I will raise for discussion.
While Future::spawn(executor) is a much better API than calling .forget(), I believe that it has a similar readability problem.
Take the following code:
my_future.map(…)
         .and_then(…)
	   .map_err(…)
	   .spawn(…)
         .select(…)
         .and_then(…)
         .map(…)

The spawn function has much heavier runtime implications than the other combinators in the chain, yet visually it blends in making it easy to read over. Reading the code snippet, it is not obvious (to me at least) that the implication of spawn is that all combinators defined above it will be executed on the specified executor where as all combinators below it get executed on the current executor.
Given the significant runtime implications of the spawn combinator, my proposal is to match something closer to thread::spawn, where the logic to be executed on the given executor is passed as an argument. Something like:
let fut = my_executor.spawn(
	my_future.map(…)
               .and_then(…)
	         .map_err(…));

fut.select(…)
   .and_then(…)
   .map(…)

This API pushes the user to split up the future chain according to where the futures end up being executed.

By default, the task is "daemonized": it will continue even if the proxy future is dropped. I believe this is the least surprising behavior.

I would advocate against "daemonizing" by default because it goes against several core Rust principals: it is neither explicit in its behavior, nor zero-cost (more like mail-in-rebate); resources are tied up, unless the programmer opts-out. It reminds me too much of Java-land, and of worrying about not doing the wrong thing by accident, instead of focusing on doing the right thing on purpose.
Here is a silly example to illustrate both points:
// Implicit footgun
fn do_stuff() {
	let burn_cpu = IntoFuture::into_future(|| { loop{} });
	let future = burn_cpu.spawn(executor);

	if i_forgot_to_get_milk {
		panic!("oh no!"); // Oops, future dropped... is it getting warm in here?
	}

	if i_am_warm {
		future.cancel(); // Whew, that was close!
	}
}

// Explicit opt-in
fn do_stuff() {
	let burn_cpu = IntoFuture::into_future(|| { loop{} });
	let future = burn_cpu.spawn(executor);

	if i_am_cold {
		future.daemonize(); // Feeling toasty!
 	} else {
 		// cpu free to do other work
 	}
}

Getting the explicit daemonization call wrong is easy to spot and fix (e.g. failing tests) because the behavior is wrong. Getting explicit opt-out of implicit behavior 100% correct everywhere is hard to spot and debug (e.g. why is so much CPU being consumed).

I'm worried that the out-of-band signalling that Task::yield() does is going to effectively disable loop optimisations.
To recap: Compilers mess about in various ways with loops -- they fuse them to do multiple passes over the same data in lockstep, but they also fission loops operating over multiple arrays to increase locality of reference. They also do things like replace "set state variable, jump to loop beginning, switch on state variable" with direct jumps, "spaghetting up trampolines". They (including LLVM) are very good at this kind of thing.
I'd be very surprised indeed if the compiler can still even detect that it is dealing with a loop through all those indirections: Signalling via TLS, getting the actual loop body out of (roughly)  Arc<UnsafeCell<Option<Box<_>>>>. If LoopTask sees that there should be a repoll, it should just do that and not jump through confusing (for the compiler) hoops, including invoking threading primitives.

As per the docs, poll() should finish very quickly. "Quickly" of course is relative, however "I did the minimum amount of work possible to make progress so now I should yield" is surely a valid interpretation. For a fold, that would be consuming one upstream element -- and what else should it do? Looping until upstream returns NotReady would not need cooperative yields in the first place, and anything in between is complete guesswork.
I'd argue that this "minimum amount of work possible" should be the actual design guideline: Both because it is not up to interpretation and scheduling should not be the concern of leaf poll()s. It should be the concern of the driver loop, at most special-purpose combinators... better yet, compiler magic, which is able to make these maximally-granular yields performant: If and only if we harness the loop optimiser, which means having a discernible top-level loop so the compiler has something to fission and spaghetti.
And that means using in-band signalling, to be precise: Poll::Yield (or whatever you want to call it). API-wise it wouldn't be a big change: Combinators should largely treat it just like Poll::NotReady, which is usually passing it on. The only code that actually needs to distinguish them is the top-level driver loop, though there probably should also be a driver combinator in case the loop optimiser needs some prodding, semantically it should be a no-op.
I'd also argue that it's the cleaner API as "I don't need to make progress right now" and "I can't make progress right now" are two fundamentally different things that should be clearly distinct in the enum, not smeared all over the place.

And, yes, I might be eyeing streams/futures as iterator replacements which explains my angle, here. If nothing else, it seems silly to use different libraries depending on whether you're interleaving arbitrary IO or just iterating over a random Vec.

Really liking @ksf's idea of having a Poll::Yield variant. I can think of situations where a Future can neither make progress nor know when it could make progress (i.e. can't or doesn't know when to unpark its Task): for example, waiting on a child process to exit or some external event that isn't directly/immediately observable.
In such situations we could have a nice distinction between Poll::NotReady ("I'm not yet done, please poll me as soon as you can") and Poll::Yield ("I'm not done, but I don't know when I might be. Feel free to prioritize some other work and check back with me when you can") so the top-level loop can optimize execution scheduling.

@ipetkov To be clear, this PR already contains such a mechanism, but it's communicated through a "side-channel": by setting a flag on the task itself, and then returning NotReady. The rationale is that this makes things significantly easier when working with the poll method, because the logic for NotReady and Yield is basically identical until you get back out to the task.

@aturon Thanks for pointing that out! Hadn't looked too closely at the changes, but it looks like you are referring to yield_now() and it covers the case I had in mind.
As a side note, no_std crates who depend on the core Future definitions may not have side-channels like Task to communicate this yield behavior. A Poll::Yield variant may be useful there, however, I'm not even sure if they will care about making this distinction themselves in a more limited environment.

Closed in favor of https://github.com/alexcrichton/futures-rs/pull/112


Sampling controlled sources with negative offsets is prone to discontinuities

For example, the current Speed control will skip back in time if the speed is increased, producing a pop. Even simpler controls like Gain cannot smoothly blend between states because they cannot reliably judge what the state was when previously sampled for a given stream (i.e. run of sample calls whose output will be played contiguously), since e.g. Spatial runs multiple sampling streams concurrently. Existing code assumes that transitions will occur immediately before sampling at offset 0, but e.g. propagation delay in Spatial undermines that.
Perfectly consistent behavior would require keeping a log of all control changes and looking up the effective control for each time period when sampling that period, but that is unacceptable due to unbounded memory requirements. However, we don't actually need perfect consistency, just a guarantee that no pops will occur and that the latest control states are used for current and future output. This could be accomplished by expanding the Signal interface to allow prior states to be tracked per stream. For example:
trait Signal {
    type Sampler: Sampler<Self>;
    fn sampler(&self) -> Self::Sampler;
    // ...
}
trait Sampler<T: Signal> {
    fn sample(&mut self, signal: &T, offset: f32, interval: f32, out: &mut [T::Frame]);
}

An alternative approach would be to abandon the principle that a signal can be directly sampled into multiple streams. Instead, structures like Spatial and friends would need to internally buffer each signal in a delay line. However, that increases memory use and requires someone to make a decision regarding a maximum supported delay, since on-the-fly dynamic memory allocation for delay lines is impractical.
The upside to this propsal is a much simpler Signal trait; we could do away with offset, advance, and avoid adding Sampler. The downside is internal complication, marginally increased overhead, and more complex user-facing API for Spatial and anything similar. Because most users should mostly not be interacting with the Signal trait directly, my inclination is to favor the original proposal for simplicity in the APIs that should be heavily used.

An alternative approach would be to abandon the principle that a signal can be directly sampled into multiple streams. Instead, structures like Spatial and friends would need to internally buffer each signal in a delay line. However, that increases memory use and requires someone to make a decision regarding a maximum supported delay, since on-the-fly dynamic memory allocation for delay lines is impractical.
The upside to this propsal is a much simpler Signal trait; we could do away with offset, advance, and avoid adding Sampler. The downside is internal complication, marginally increased overhead, and more complex user-facing API for Spatial and anything similar. Because most users should mostly not be interacting with the Signal trait directly, my inclination is to favor the original proposal for simplicity in the APIs that should be heavily used.

On review I think I've misjudged the complication/overhead, so maybe a simpler Signal wins out after all.

On review I think I've misjudged the complication/overhead, so maybe a simpler Signal wins out after all.


Closes: #1

Fixed 1 issue
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

@googlebot I signed it!


Figure out what to do with ci_setup.d and run_tests.d

These were used to test mysql-native prior to 3.0.2. For newer testing, we are now using github actions, but I need to make sure that the tests covered in these are being run correctly.

run_tests.d was deleted. I think I can delete setup_ci.d, but have to take a look.

ci_setup seemed geared towards making sure the environment had required dependencies (specifically, it used homebrew to install mysql), maybe something we can do in github actions for macos. Will leave it there for now.

Fixed in #269 thanks @kubo39!


Make Glossarie fields public

As a user, i want to be able to access these fields
Closes #23

LGTM. Thanks!


As a busy student, I want to have my own shortforms of commands

so that I can type more quickly and in my own style

#13 #28  #35

#2 #25 #30 #42 #47 #

#97


Create hmtl page for debugging main.js

Currently debugging the webview layout is quite challenging in the vscode rendering. It doesn't give access to console or debug view.
Making the same html with the main.js file run in plain html (with mockup data or drag'n drop) would make it easier to debug/develop

This works now with https://github.com/niivue/niivue-vscode/commit/ae781261fc4efb08653d186b46b77e9a14379c3a
TODO: test if moving the file picker from vscode to main.js works on remote

The main.js filepicker always runs locally in the webview. I think on remote we want a file picker that picks remote files. I cannot think of a reason when we want to pick local files.
It is probably best to use the vscode filepicker as default (with a bit more overhead for sending messages between main.js and vscode).
The main.js file can then distinguish between opened in vscode or web. When it is opened in web, it uses its own filepicker.


add a space.

before:

after:

Hi, thanks for contributing.
Is this change really necessary? Can you find a few other users to +1 this PR?


Electron rebuild error

I'm now trying on this module rebuild for electron. But some error occured when rebuiling or running modules. Any help would be greatly appreciated.
Please see this issue too. -> #17

I finally successfully rebuild the node-uwp by the npm way of rebuilding.
See this issue -> https://github.com/electron/electron/blob/master/docs/tutorial/using-native-node-modules.md
Also see this issue to build usb module in noble dependences -> https://github.com/sandeepmistry/noble/issues/235

For completeness I used this line to rebuild the modules for electron successfully
npm rebuild --runtime=electron --target=1.7.1 --arch=x64 --rebuild --disturl=https://atom.io/download/electron --build_from_source=true

Thanks for the info. This should probably be added to the README to help other people trying to use this library with electron.

Added a pull request #32 so this issue can be closed

The suggestion from itome works too, but since we're working in Windows beware to use 'set' instead of 'export' (or 'setx' to remember them between cmd sessions):
set npm_config_target=1.2.3
set npm_config_arch=x64
set npm_config_target_arch=x64
set npm_config_disturl=https://atom.io/download/electron
set npm_config_runtime=electron
set npm_config_build_from_source=true
npm install


Remove deprecated prometheus relabel config

How to categorize this PR?

/area monitoring
/kind cleanup
What this PR does / why we need it:
With https://github.com/gardener/gardener/pull/7180, we were using the kubernetes.io/instance label value to replace the job label for extensions.
The extensions are adapted now to use prometheus.io/name annotation, hence this relabel config can be cleaned up.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

Extensions that wish to be scraped by the `seed-prometheus` should annotate their pods with `prometheus.io/scrape=true` along with `prometheus.io/name=<name>`. See https://github.com/gardener/gardener/blob/master/docs/monitoring/README.md#seed-prometheus for more details.

/cc @istvanballok @rickardsjp

/test pull-gardener-e2e-kind


How to hang up a call programmatically?

Hi @JoshuaLai
I'd like to know if there are a feature about Hang up on a call by method on interface or static void.
I'm trying debug CallCompositeActivity's elements like button feature hang up call but it seems not possible. Any way?

Hi @AlexJTS. Thanks for the question.
Just want to understand your scenario a little bit more. You want to programatically hang up a call without the need for tapping the Leave Call button?
Is the idea you want to hang up the call for all participants in the call? Or just for the one specific participant (as if they tapped the Leave Call button themselves)

cc @iaulakh @garchiro7

Thanks for the answer, @JoshuaLai
In that case I need a method to hang up the call of a particular participant without pressing the leave call button. For example, I am trying to set a timer for a meeting session. When the timer reaches 0 seconds, I want the application to hang up automatically. I also trying stop call by dispose activity by following code but I know its no suitable.
Device.StartTimer(TimeSpan.FromMilliseconds(1000), () =>             {                 do                 {                     _countSeconds--;                     if (_countSeconds== 0)                     {                         StopSession();                         return false;                     }                     else                     {                         return true;                     }                 } while (_countSeconds > 0);             });             private async void StopSession()             {                 await ACServices.RemoveTokenUser(userIdentity);                 var currentContext = Android.App.Application.Context;                 currentContext.Dispose();             }

I see. I understand your workflow. For the time being we don't provide any APIs to hang up the calling like this unfortunately. I'm not sure if we have had any asks for this feature @garchiro7 can confirm.
We would first need to expose an API in our underlying native UI composites for the Xamarin binding to call to.
You can provide feedback here and we can have it added to our backlog. https://feedback.azure.com/d365community/forum/81ff6d2b-0c25-ec11-b6e6-000d3a4f0858

Hi, @AlexJTS I encourage you to open feedback here:  https://feedback.azure.com/d365community/forum/81ff6d2b-0c25-ec11-b6e6-000d3a4f0858,  We will add this to the backlog and continue with the effort to provide the tools that you need.
Currently as @JoshuaLai mentioned, we don't offer the capability in the UI Library, one alternative is creating your own implementation (fork the UI Library and bubble up the functionality from the Calling SDK); since the UI Library is opensource, you can expand the current functionality 👍

@JoshuaLai @garchiro7 Hi. Oh ok I get it, I'm very grateful by your answering.
I have post on feedback of Azure. It would be great to add these features on manage meeting calls.


Feat/improve progress radial

Linked Issue
Closes https://github.com/skeletonlabs/skeleton/issues/2092
Description
Introduces a new prop roundedLineCap that allows customization of the progress radial. Renaming the prop is welcome.
Changsets
Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:. - Done ✅
Checklist
Please read and apply all contribution requirements.

[x] This PR targets the dev branch (NEVER master)
[x] Documentation reflects all relevant changes
[x] Branch is prefixed with: docs/, feat/, chore/, bugfix/
[x] Ensure Svelte and Typescript linting is current - run pnpm check
[x] Ensure Prettier linting is current - run pnpm format
[x] All test cases are passing - run pnpm test
[x] Includes a changeset (if relevant; see above)

@edrichhans very cool - I'll do a proper review next week, but at a glance this looks like something we'll move forward with. Thanks!

@edrichhans, as expected this is a very cool change! I really dig this, and the simplicity is wonderful.
I went ahead and made a few changes as part of my review:

Make sure to only target /package projects when generating changesets, never /sites (we don't log changes for the doc site yet)
I've renamed the prop name to strokeLinecap to be closer to the attribute
I've replaced the boolean with a union type, which allows for all three possible options for 'butt' | 'round' | 'square'
I've kept butt as the default value though
Updated the documentation to match these changes

The general idea is we want props to be a pass through for any and all options when we can. Though I understand why you didn't opt for including square - it's a bit odd!
Thank you for this contribution, this will be merged and be a part of next week's new release!

Happy to contribute @endigo9740 , thanks for approving and merging


TypeError: Cannot read property 'getContext' of null

Lightweight Charts Version: 3.2.0
Steps/code to reproduce:
useEffect(() => {
  const c = createChart(chartRef.current, {
    // options
  });

  // other initialization

  return () => c.remove();
});

Actual behavior:
Exception is thrown:
TypeError: Cannot read property 'getContext' of null
  at vB(webpack://frontend/./node_modules/lightweight-charts/dist/lightweight-charts.esm.production.js:7:85788)
  at $c(webpack://frontend/./node_modules/lightweight-charts/dist/lightweight-charts.esm.production.js:7:112215)
  at $c(webpack://frontend/./node_modules/lightweight-charts/dist/lightweight-charts.esm.production.js:7:117214)
  at S_(webpack://frontend/./node_modules/lightweight-charts/dist/lightweight-charts.esm.production.js:7:119795)
  at apply(webpack://frontend/./node_modules/lightweight-charts/dist/lightweight-charts.esm.production.js:7:120143)
  at r(webpack://frontend/./node_modules/@sentry/browser/esm/helpers.js:72:23)

Note: I am aware of https://github.com/tradingview/lightweight-charts/issues/248, and .remove() is used.
Expected behavior:
Expected no exception.
Screenshots:
No screenshots to provide.
CodeSandbox/JSFiddle/etc link:
Was not able to reproduce myself. Only 1 user is experiencing this issue (Chrome 86.0.4240, Windows 10). About 30 times this month.

I'm afraid without a reproduction we can't even try to solve this issue - all I see in the code that getContext is called from canvas elements what means that perhaps document.createElement('canvas') returned null what is against the spec.

I'm going to close the issue. If you'll have any question or updates - feel free to re-open it.


SSR support

When using the plugin in SSR application there is window is not defined issue at dist/vue-form.js:46.
What about fixing it with changing this:
Promise: window.Promise

to:
Promise: (typeof window !== 'undefined' ? window.Promise : undefined)

Then, Server-Side Rendering would be work fine.
P.S. @fergaldoyle, if you prefer, I could submit PL for that.

Please do make a PL, I'm not set up for SSR so would be good if you can verify if it works. Setting Promise undefined, will this then cause issues for async validators?

Instead of using undefined, for node maybe you can use:
global.Promise

Environment global detected with ba774845d924eb2cecf0202e8aea16da312ac0dd

Now it's working fine


Spline Chart - Line goes under the minimum value

There's no value smaller than 0 and still the line goes under it. Any fixes for this ?

Sorry to comment on an closed issue but I was scratching my head over this as well.
I investigated the c3 code and saw that the method c3_chart_internal_fn.getInterpolate uses a cardinal interpolation option for splines. Would it make sense to use the monotone option instead or allow for customization to avoid forking the repo or overwriting the method?
See this for more information.
Thank you for an amazing library.

@mortenbo That's a good point; tbh, given spline doesn't have any configurable options, maybe it should be merged into the line chart and that chart style given a configurable interpolation option?
Reopening and renaming to better reflect issue.

A configurable interpolation option would suit me very well.

Hi,
I am also interested in adding a configuration option to set the interpolation type in a spline, and willing to do a PR with the required changes. Reading this issue I assume you would like to have that option in the library, but I'm asking anyway :)

Awesome. Much appreciated :-)


Breaks global editor.tab-length

This package breaks the global setting for editor.tab-length. It overrides the setting to 4, but it is impossible to set it locally in the Atom settings-view to the global value, due to an assumption by settings-view that anything set to the global default should be discarded. This makes it impossible, should you have a preferred tab length beside 4, to set the tab length used in Rust files to your global setting (without modifying the rust.cson file in the package source). Any other value can be used, but not the global value.

There's some talk about this in #93 as well. To me, this sounds like a bug in Atom (settings pages ignore package-level defaults). A known workaround is to add these settings manually to your config.cson until it gets fixed in Atom.


How you produce 'maskcoefficients'

Hi,Thanks a lot for your fantastic work!But,i found that in your paper ,you produce 'mask coefficients'
by using fc layers.but in your code, i found you produce  'mask coefficients' by using conv layer.Can you tell me which kind of layer you use for   producing  'mask coefficients'?Thanks for your reply!

A 1x1 kernel conv layer is just a fc layer applied individually to each pixel in the image. That's what I meant by saying "as the product of an fc layer". One conv layer is producing mask coefficient for every pixel in the conv out individually--doing it with a conv is just way more efficient.

@dbolya  from the paper it seems that the mask coefficients are linear , is their any way we can make the coefficients non linear . If so how could we approach .

@abhigoku10 It's not exactly linear depending on which place you look. The coefficients themselves go through a tanh, so they're all from -1 to 1. Then once they get multiplied with the prototypes (which are ReLU'd so they go from 0 to inf), that whole thing goes through a sigmoid. You could add some coefficients that get multiplied into a square prototype or something like that (similar to geometric [nonlinear] regression).

@dbolya  i wanted to improve the accuracy for person detection in mscoco and custom data for that when i visualisation the protomask i am getting the features but the mask coefficients is low so increase that

A 1x1 kernel conv layer is just a fc layer applied individually to each pixel in the image. That's what I meant by saying "as the product of an fc layer". One conv layer is producing mask coefficient for every pixel in the conv out individually--doing it with a conv is just way more efficient.

Hi, in the PredictionModule notes, you said 'this is slightly different to the module in the paper', is this meanings change the extra_head_net kernel size from 11 to 33,  and is this original 1*1 the fc layers mentioned in your paper? And now there is no fc layer in prediction of mask_coefficients?


Pancake Studio Down

Hi guys, has this project been taken down?
I'm not able to access the URL https://pancake.studio anymore.

Hey @zacbre, sorry about this 😞
I spent some time today getting access to our hosting, domain, DNS, and so on. The issue seems to be related to the Slack/Salesforce acquisition that caused some accounts to be merged/migrated. I'll keep ya updated! 🙏🏻

Good morning @zacbre 👋🏻
Good news - https://pancake.studio/ is online! Big thanks to @stevengill who had to work through some internal hosting requests 🙇🏻 The downtime was a result of the company transition and shouldn't happen again.
Sorry about that!

https://pancake.studio appears to be down again

Hi @mm-chrisspencer 👋🏻
Thanks for letting us know that the domain was down (again) 🙇🏻 We've had some transition pains while moving our accounts and it looks like our DNS record was dropped 🤔 I've now restored it and https://pancake.studio is online 🟢
If this happens again, we'll look into an alternative DNS provider. Sorry for the trouble! 🙏🏻


Typo

The example in readme
'' from skimage.transfrom import resize ''
transfrom should be transform

Thanks @NotSmall


add static pod

What type of PR is this?

What this PR does / why we need it:
Add support for static pod functionality in edge.
Which issue(s) this PR fixes:
Fixes https://github.com/kubeedge/kubeedge/issues/4778
@Shelley-BaoYue

DCO failed, please using git commit -s.

How about revert this history commit 'a4309c3#diff-f2e4d3632822fde7e6617f2729849074b6f9287c3ad86479f351f293558cb530'?

This seems to be only about mirror pod, and the content of static pod has some modifications based on the original K8S.

How about revert this history commit 'a4309c3#diff-f2e4d3632822fde7e6617f2729849074b6f9287c3ad86479f351f293558cb530'?

This seems to be only about mirror pod, and the content of static pod has some modifications based on the original K8S.

This commit also contains some modification about static pod. I compare these two commits and the content is not much different.
I think we can see if we can revert the this commit? If we have some necessart intrusive changes, we can create a separate commit.  This way, we can track Kubernetes updates in real time.

How about revert this history commit 'a4309c3#diff-f2e4d3632822fde7e6617f2729849074b6f9287c3ad86479f351f293558cb530'?

This seems to be only about mirror pod, and the content of static pod has some modifications based on the original K8S.

This commit also contains some modification about static pod. I compare these two commits and the content is not much different.
I think we can see if we can revert the this commit? If we have some necessart intrusive changes, we can create a separate commit. This way, we can track Kubernetes updates in real time.

Okay, let's restore it. Let me compare the changes I made and I'll bring up another PR.

Is this PR still working in progress?  If so, you can add WIP in your title.
I wish this pr split into two commits, one named Revert xxxx which is automatically generated by using git revert, another is used to add your modification for static pod.  So that we can clearly trace all modification for kubernetes in history commits.

Is this PR still working in progress? If so, you can add WIP in your title.
I wish this pr split into two commits, one named Revert xxxx which is automatically generated by using git revert, another is used to add your modification for static pod. So that we can clearly trace all modification for kubernetes in history commits.

ok!

/close
a new PR in #10


Make an Angular SDK for Casdoor like React and Vue

See: https://casdoor.org/docs/how-to-connect/sdk#:~:text=casdoor-ios-sdk-,React SDK,-For React websites

@Hykids


Sample Table does not match the example in tutorial

The Table 1 which is to be used in the first portion of the tutorial doesn't match the resulting table provided by the URL as a result the rest of the tutorial is not able to be properly followed.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f510cb29-4222-72f8-ff8e-58553c856234
Version Independent ID: cbde387d-8cbc-50ed-5665-54985b9ebcc1
Content: Tutorial: Shape and combine data in Power BI Desktop - Power BI
Content Source: powerbi-docs/connect-data/desktop-shape-and-combine-data.md
Service: powerbi
Sub-service: pbi-data-sources
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for your comment, @Mark-BerryS2. This issue has been assigned to the doc author for review.

Thanks for your feedback, looks like they've changed a handful of the names of columns in that table. We'll schedule an update for that article, to match the current experience. I'll leave this open while we get that into the queue.

I've added a note that clarifies column names and selections may vary as that site is updated. Thanks!


Swap limit capabilities failure while trying to set memory limit

Hi guys,
I'm trying to set memory limit on docker commit using the -run option, e.g.:
docker commit  -run='{"Memory": 128}' 0b5e63a76024 flaviamissi/test

This works as expected, but when I attempt to run a container using the obtained image I get the following:
$ docker run -t -i tsuru/test /bin/bash
WARNING:  Your kernel does not support memory swap capabilities. Limitation discarded.
lxc-start: Device or resource busy - write /sys/fs/cgroup/memory/lxc/5e29ddc69751e982fd1895e5d8b8f3159184ab9859c2bc3747b6c16d17a9e1ff/memory.limit_in_bytes : Device or resource busy
lxc-start: Error setting memory.limit_in_bytes to 128 for lxc/5e29ddc69751e982fd1895e5d8b8f3159184ab9859c2bc3747b6c16d17a9e1ff

lxc-start: failed to setup the cgroups for '5e29ddc69751e982fd1895e5d8b8f3159184ab9859c2bc3747b6c16d17a9e1ff'
lxc-start: failed to spawn '5e29ddc69751e982fd1895e5d8b8f3159184ab9859c2bc3747b6c16d17a9e1ff'
lxc-start: Device or resource busy - failed to remove cgroup '/sys/fs/cgroup/cpuset/lxc/5e29ddc69751e982fd1895e5d8b8f3159184ab9859c2bc3747b6c16d17a9e1ff'
lxc-start: Device or resource busy - failed to remove cgroup '/sys/fs/cgroup/cpu/lxc/5e29ddc69751e982fd1895e5d8b8f3159184ab9859c2bc3747b6c16d17a9e1ff'
lxc-start: Device or resource busy - failed to remove cgroup '/sys/fs/cgroup/cpuacct/lxc/5e29ddc69751e982fd1895e5d8b8f3159184ab9859c2bc3747b6c16d17a9e1ff'
lxc-start: Device or resource busy - failed to remove cgroup '/sys/fs/cgroup/memory/lxc/5e29ddc69751e982fd1895e5d8b8f3159184ab9859c2bc3747b6c16d17a9e1ff'
lxc-start: Device or resource busy - failed to remove cgroup '/sys/fs/cgroup/devices/lxc/5e29ddc69751e982fd1895e5d8b8f3159184ab9859c2bc3747b6c16d17a9e1ff'
lxc-start: Device or resource busy - failed to remove cgroup '/sys/fs/cgroup/freezer/lxc/5e29ddc69751e982fd1895e5d8b8f3159184ab9859c2bc3747b6c16d17a9e1ff'

What is puzzling me is the warning printed by docker:
WARNING:  Your kernel does not support memory swap capabilities. Limitation discarded.

If you pay attention, I'm not setting the MemorySwap option, but the Memory opt.
I've found the code that logs it, and it seems that the check is wrong, see:
if container.Config.Memory > 0 && !container.runtime.capabilities.SwapLimit {
...

What should be really checked here isn't the container.Config.MemorySwap attribute?
Would someone mind to clarify this to me?
Thanks!

Sorry for necroposting, but I think this still should go here.
So I'm on Ubuntu 14.04, I updated GRUB options with GRUB_CMDLINE_LINUX="cgroup_enable=memory swapaccount=1" and GRUB_CMDLINE_LINUX_DEFAULT="cgroup_enable=memory swapaccount=1", done update-grub, rebooted and still receive WARNING: Your kernel does not support swap limit capabilities. Limitation discarded.
By the way, I also can see these options in /boot/grub/grub.cfg.
I have no idea what I am missing

@scadgek : Did you got it fixed? I fail to enable it as well.

@shredding No, I didn't. The task became not important and I stopped looking for the ways to solve.

I tracked it down.  You'd need to use 15.05 or 15.10 then because 14.04 does not support internal kernel configuration from within a vps.

@shredding  No it wasn't Digital Ocean, it was my local machine - not even a virtual one


Address conversation

Is there any way to convert evmos address to evmosvaloper address?
In cli we use evmosd debug addr .... which gives us valoper address.
Can we do the same thing using evmosjs?
Any help will be appreciated.

Hi @aramakam3505, thanks for your question!
It is not supported at the moment, but we will consider adding it

@aramakam3505 you can try this code to conver
import { bech32 } from 'bech32';

export function bech32Encode(address: string, prefix = 'evmos') {
  const words = bech32.toWords(Buffer.from(address.replace('0x', ''), 'hex'));

  return bech32.encode(prefix, words);
}

export function bech32Decode(address: string) {
  const { words } = bech32.decode(address);
  const hex = Buffer.from(bech32.fromWords(words)).toString('hex');

  return `0x${hex}`.toLowerCase();
}


Cannot access a disposed object. Object name: 'FileBufferingReadStream'.

Describe the bug
When I tried to complete order, the following exception occurred: "System.ObjectDisposedException: Cannot access a disposed object. Object name: 'FileBufferingReadStream'"
Steps To Reproduce
Steps to reproduce the behavior:

Create order with one of payment providers (in my case it was umbraco.Commerce.PaymentProvider.PayPal)
Complete it
PayPal webhook callback triggered
In umbraco logs exception occurred

Expected behavior
There is no exception "System.ObjectDisposedException: Cannot access a disposed object. Object name: 'FileBufferingReadStream'"
Additional context
There is a stack trace of exception:

System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'FileBufferingReadStream'.
at Microsoft.AspNetCore.WebUtilities.FileBufferingReadStream.ThrowIfDisposed()
at Microsoft.AspNetCore.WebUtilities.FileBufferingReadStream.set_Position(Int64 value)
at Umbraco.Commerce.Web.Mvc.HttpRequestMessageFeature.CreateHttpRequestMessage(HttpContext httpContext)
at Umbraco.Commerce.Cms.Web.Controllers.UmbracoCommercePaymentController.get_RequestMessage()
at Umbraco.Commerce.Cms.Web.Controllers.UmbracoCommercePaymentController.HandleRequestWithoutOrder(String requestType, String paymentProviderAlias, Guid paymentMethodId, Func3 handler)    at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.TaskOfIActionResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeActionMethodAsync>g__Awaited|12_0(ControllerActionInvoker invoker, ValueTask1 actionResultValueTask)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.g__Awaited|10_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync()
--- End of stack trace from previous location ---
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|25_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeFilterPipelineAsync()
--- End of stack trace from previous location ---
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
at Microsoft.AspNetCore.Routing.EndpointMiddleware.g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)
at SEOChecker.Common.Middleware.UrlRedirectMiddleware.InvokeAsync(HttpContext context, IContextInfo contextInfo, INiceUrlHelper niceUrlHelper, IUrlRewriteProviderFactory urlRewriteProviderFactory, IPageNotFoundRepository pageNotFoundRepository, INotFoundHelper notFoundHelper, IIOHelper ioHelper, IUriResolverService uriResolverService, IUmbracoUrlHelper umbracoUrlHelper, IUmbracoContextFactory umbracoContextFactory, IRequestProviderService requestProviderService, IConfigService1 configurationService, IOptions1 contentOptions, ILogger1 logger)    at SEOChecker.Common.Middleware.UrlRewriteMiddleware.InvokeAsync(HttpContext context, IUrlRewriteProviderFactory urlRewriteProviderFactory, IUmbracoUrlHelper umbracoUrlHelper, IUmbracoContextFactory umbracoContextFactory, IConfigService1 configurationService, ILogger`1 logger)
at Microsoft.AspNetCore.Session.SessionMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Session.SessionMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
at SixLabors.ImageSharp.Web.Middleware.ImageSharpMiddleware.Invoke(HttpContext httpContext, Boolean retry)
at StackExchange.Profiling.MiniProfilerMiddleware.Invoke(HttpContext context) in C:\projects\dotnet\src\MiniProfiler.AspNetCore\MiniProfilerMiddleware.cs:line 121
at Umbraco.Cms.Web.Common.Middleware.UmbracoRequestMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
at Umbraco.Cms.Web.Common.Middleware.UmbracoRequestMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass6_1.<b__1>d.MoveNext()
--- End of stack trace from previous location ---
at Umbraco.Cms.Web.Common.Middleware.PreviewAuthenticationMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass6_1.<b__1>d.MoveNext()
--- End of stack trace from previous location ---
at Umbraco.Cms.Web.Common.Middleware.UmbracoRequestLoggingMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass6_1.<b__1>d.MoveNext()
--- End of stack trace from previous location ---
at Foo.CMS.Web.Core.Features.UmbracoCommerce.Features.Backoffice.Middlewares.DynamicBackofficeViewsMiddleware.InvokeAsync(HttpContext context, RequestDelegate next) in D:\Projects\Bar\Foo\git\src\Foo.CMS.Web.Core\Features\UmbracoCommerce\Features\Backoffice\Middlewares\DynamicBackofficeViewsMiddleware.cs:line 48
at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass6_1.<b__1>d.MoveNext()
--- End of stack trace from previous location ---
at Umbraco.Forms.Web.HttpModules.ProtectFormUploadRequestsMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass6_1.<b__1>d.MoveNext()
--- End of stack trace from previous location ---
at Umbraco.Commerce.Cms.Web.Mvc.UmbracoCommerceRequestBufferingMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass6_1.<b__1>d.MoveNext()
--- End of stack trace from previous location ---
at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

Umbraco Commerce version:
v10.0.10
Umbraco.Commerce.PaymentProviders.PayPal:
v10.0.0
Possible fix
It may caused by enabled request buffering, but umbraco commerce already has Umbraco.Commerce.Cms.Web.Mvc.UmbracoCommerceRequestBufferingMiddleware which enable it.
Another possible reason is storing HttpContext in field of Umbraco.Commerce.Web.Mvc.HttpRequestMessageFeature class.
Even though scoped services in ASP.NET Core have a lifetime that matches the request, there are still compelling reasons to avoid storing HttpContext directly in fields within those services. Here's why:

Potential for Inconsistent State
The HttpContext and its features like ISession are designed to be accessed per-request and are tied to the specific HTTP request lifecycle. Storing them in a field and accessing them later can lead to an inconsistent state if the service instance is reused in a different context within the same request or if the session state changes.
Disposal and Resource Management
ASP.NET Core manages the disposal of HttpContext and its components. If you store these components in fields, you risk accessing disposed objects, especially if any asynchronous operations are involved that might delay the service method execution.
Thread Safety
HttpContext and its features are not thread-safe. Storing them in a field increases the risk of concurrent access issues. Each access to HttpContext should be fresh and scoped to the current request processing pipeline to ensure thread safety.
Proper DI Pattern
ASP.NET Core's Dependency Injection (DI) pattern is designed for services to access their dependencies directly. This means services should use IHttpContextAccessor to access HttpContext or ISession on-demand. This ensures that you always get the current, correct instance without risking lifecycle or concurrency issues.

I think storing HttpContext in field of Umbraco.Commerce.Web.Mvc.HttpRequestMessageFeature leading this issue and insted storing HttpContext in field we should use IHttpContextAccessor.
Thanks for help)

@PeterKvayt i've just pushed a 10.0.12--preview.1 to our night feed which should no longer log the URL, rather instead it logs the payment provider name and the order number. This won't fix the overal issue, but it should prevent the second error masking the original exception.
Would you be in a position to give it a test and see if it sheds any further light on the real underlying issue?
See info here for how to use a nightly feed https://docs.umbraco.com/umbraco-cms/fundamentals/setup/install/installing-nightly-builds

Hi @mattbrailsford
I am glad to hear that you have been pushed 10.0.12--preview.1.
I can test the fix locally, but the main issue was discovered on our stand. So it can take a while to test this fix on stand and give you feedback (it can take from one to couple weeks, depends on our deliveries).
I will notice you about my local investigation results as soon as possible.
Btw what else was changed in 10.0.12--preview.1? Is there only one change (this fix) between 10.0.11 and 10.0.12--preview.1. It is important for me.
Thanks for suport

Hi @PeterKvayt yea, this is the only thing in there at the moment.
As I say, i don't think this is going to be the final solution, just I'm hoping this lets us skip the second issue you highlighted and then hopefully lets us see what the realy issue is (ie, what throws the first exception). Fingers crossed it's a different error we can resolve more easily 😁

Hi @mattbrailsford !
I have just reproduced error on my local environment with syntetic exception to see can I find the original exception in logs. I could find it, great😁.
The following step is to deliver your fixed version 10.0.12--preview.1.gaae1bd2 (10.0.12--preview.1) to stand and find out the original error on stand.
I will keep you updated.

@PeterKvayt fantastic. Fingers crossed we can get there 🤞

Hi!
Little update is here: I have just caught internal exception which probably cause to error.

I am going to investigate it more deeper. Just wanted to keep you up to dated.

Ooh, excellent that we are seeing the right exception now.
Do you have code in your solution using entity framework? Umbraco Commerce doesn’t but I know CMS have started to in areas. At least is narrowed down to an area to look in to.
I appreciate the update. Fingers crossed we’re getting closer to a resolution. 🤞🏻

@mattbrailsford
I have could reproduce this exception locally, it was caused by my code. I have two handlers for Order Finalized Notification which processed actions in parallel with one dbcontext instance.
My fix not on our testing stage yet, but I think it was the main exception which cause current issue.
So let's summarize:

fix in 10.12--preview.1.gaae1bd2 definitely is working like a charm.

We still need to do something with this behaviour :

The main reason here is that PayPal disposing request.Content, which is the HttpContext.Request.Body property in Umbraco.Commerce.PaymentProviders.PayPal.Api.PayPalClient.ParseWebhookEventAsync.

I think PayPal should not dispose request.Content.

Anyway thanks a lot for fast response and support!
I will write about results after my code deployed on our testing stage.

Sorry, forgot to reply but 10.0.12 is out now 👍🏻

@mattbrailsford
As I can see fix from 10.12--preview.1.gaae1bd2 is already applied in 10.0.13 (maybe in 10.0.12 too, but I didn't check it)


Username from URL is ignored

It looks QuestDB-Connect ignores the username parsed from the URL and always defaults to "admin".
This is caused by a wrong constant in our connect() function.
See the screenshot:

The line 94 should get() "user", not "username".
Reproducer

Open hello_world.py and change the URL ("questdb://user:quest@localhost:8812/main")
Run the Hello World example
Watch Connect to still use the admin username when connecting to QuestDB instead of user as specified in the URL.

Expected behaviour
The username from the URL should be used.
The fix is trivial, but I would send a PR with a fix, but I don't understand the test setup well enough to write a test for this.

release https://pypi.org/manage/project/questdb-connect/release/1.0.9/ should fix it.


Code editor must-have features

For some reason there's lack of must-have features all IDEs have. Here's the list of what I miss so much. I hope this one will be added to the tracker #2982. Let me know if you need a visual example of how this should work, I'll try to make a screencast from other IDEs

fuzzy search
search files, classes, lines, commands, etc
code snippets
refactoring tools (e.g. rename/extract method/variable)
navigation / go to definition
when Ctrl + Click on function (including user-defined) - go to that function (from ANY place, not just within the same script)
Alt + Left / Alt+ Right - navigate through places instead of just files
hierarchy
hierarchy of classes, list of all function in the class (already there and that's great!), call hierarchy
find all usages
quick docs (on hover / hotkey)
code completion
Sadly, current code completion is still weak in comparison with other products, but I think we need a bunch of examples how it should work or what does not work. Including intellisense
auto-format code

On code completion, the ability for this feature to work improves if you use the optional static typing (as the weaknesses in this otherwise is due to the very nature of a dynamically typed language).
As for the others, some useful ideas there, fortunately we have a history of devs. interested in providing patches.

As for code completion, VS Code does this in an interesting way. It can auto-complete even .txt files, just by suggesting different words you used in the file in case you need one. And it actually helps.

Please open one issue per bug/feature request, it's very difficult to keep track of what has been implemented otherwise. Make sure to search for potential duplicates too; many of the feature requests you mentioned already have their own issues in this repository.

@Ace-Dragon yeah, I use typing a lot and IMO code completion is still weak (compare with JetBrains IDEs - they have the most awesome completion I've ever seen)
@KoBeWi and that results in unnecessary garbage in suggestion list. More stuff is as bad as less stuff =)
@Calinou thanks, you're right, I'll open new issues later


Execute Python script from PHP

I made a python script which I want to execute from PHP via shell_exec(). I figured out that when I load the library (speech_recognition) in python, PHP is not able to execute the file. How can I fix this?

I had to run it with sudo and full path.


[DRAFT] EPIC: Explore Coulomb Filters For Joint Ruptures

We want to know if we can use Kevin's suggested Coulomb Filters to generate plausible joint ruptures. We also want to keep the momentum going while Kevin has time to work on it.
The main questions we want to answer are

How can we apply Coulomb stress to generate joint ruptures?
How can we validate and assess the result?

The question whether Coulomb stress is appropriate for generating joint ruptures is beyond the scope of this epic.
We don't yet need to fully answer the question if we can use these filters, and we don't need production reader filters yet.
The goal is to get an initial idea of the feasibility and to have tools in place to explore and validate the results.

[x] Write a framework to run the new filters
[x] Develop candidate coulomb filters
[x] Create new reports to understand the filters
[x] Use RSQSim rupture catalogue to validate filters

Bruce and I gave an SRM presentation recently on the progress.
Here's the opensha part of the code: https://github.com/GNS-Science/opensha/tree/oakley/WIP
And here is the nzshm part of the code: https://github.com/GNS-Science/nzshm-opensha/tree/feature/rsqsims
Once there's documentation on how to run this, we can close this epic


Spring cloud function with multiple event functions are not working properly

Hi,
Recently started working on spring cloud function with aws lambda. I saw lot examples on sigle function worh lambda. But I wants to implement with multiple function in single aws lambda. After gone through the document, I started looking routerFunction. Facing couple of issues and no proper document in YouTube , google...
My test case scenario:
I have 2 lambda functions<String, String> : even and odd.
in my local, I ran application and run below post method URL
Http://localhost:8080/even
Http://localhost:8080/odd
are working fine and getting proper response..
I ran with below url
http://localhost:8080/functionRouter
Header: spring.cloud.function.defenation:even
first time I’m getting response if I ran second time again - getting publisher can’t use spring.cloud.function.defenation as a arugument. Should be specified in the application.properties.
if I restart my application, it will work first time then it won’t work. Getting above error.
Can you please help me on this how to approach it?.
Is there anyway to setup spring.cloud.header.defenation dynamically to read from header?.
Please suggest me.. it will great help to me.

Can you please post a stack trace? Log snippet?

sorry for confuse you.. Please see below log trace is coming like this
Java.Lang.illegalArgumentException: Routing input of type publisher is not supported per individual values (e.g., message header or POJO). Instead you should use ‘spring.cloud.function.defenation’ or spring.cloud.function.routing-expression’ as applicationproperties.
Application.properties:
Spring.cloud.stream.function.routing.enabled=true
Spring.cloud.function.scan.packages: com.example.demo.functions
let me know if you need any more information.

Can you please provide any sample application which is Java spring cloud function handling multiple functions and deploy into AWS lambda?. I was looking for examples but not found any where.

Issue resolved after upgrade to spring cloud aws version to 3.1.0 above and spring cloud version is 2020.0.2 version.


Update request: Heroic 2.14.1 → 2.15.0

Package name: heroic
Latest released version: 2.15.0

Current version on the unstable channel: 2.14.1
Current version on the stable/release channel: 2.14.1

[x] Checked the nixpkgs pull requests

Notify maintainers
@aidalgol

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Need to wait for https://github.com/NixOS/nixpkgs/pull/333907 to be merged, because upstream depends on Electron 31, but the latest currently in nixpkgs is 30.

Need to wait for #333907 to be merged, because upstream depends on Electron 31, but the latest currently in nixpkgs is 30.

you can make draft PR and wait :D

Also does UMU need to be packaged for this release?

Actually, given that UMU provides a flake, and Heroic can download a working version, just without the latest fixes, I am opting to not package UMU in nixpkgs.


Bad parsing

Hi, my script has a couple of problematic lines which disrupt the script entirely on phpstorm.
var=${var##+([ '])}
var=${var%%+([ '])}
This two lines are for cleaning spaces and single quotes at the beginning and at the end of the var... but its syntax is marked as an error. Unexpected token.
Thank you!!

Which version of Bash are you using?
I can't find any reference for your pattern, filename patterns are supposed to be after the ## or %% operators, e.g. http://wiki.bash-hackers.org/syntax/pe or https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html .
Do you have any documentation for your version of Bash which explains the pattern?

Sorry, This issue is from time ago... I removed that code and I did in other way. Probably the syntax is not correct. Now I'm not sure if this is a real problem... but with the new update received today (<IP_ADDRESS>) I have new problems... I'll open a different issue for that. Closing this.

Thanks. Ok, let me know of the new issues (hoped, that there were none new :)
--
<>< Re: deemed

Am 30.12.2016 um 09:32 schrieb Oscar aka Elvis<EMAIL_ADDRESS>Sorry, This issue is from time ago... I removed that code and I did in other way. Probably the syntax is not correct. Now I'm not sure if this is a real problem... but with the new update received today (<IP_ADDRESS>) I have new problems... I'll open a different issue for that. Closing this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Yes, this is new... I opened it. You can see it here: https://github.com/jansorg/BashSupport/issues/391


⚠ Bofrost.be has degraded performance

In ed497bb, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1754 ms

Resolved: Bofrost.be performance has improved in e9032a2 after 7 minutes.


Unit test Microsoft.AspNet.Html.Abstractions.Test.HtmlContentBuilderExtensionsTest.Builder_AppendFormat_WithDifferentCurrentCulture fails on CoreCLR on Linux

Assert.Equal() Failure
                            ↓ (pos 12)
      Expected: HtmlEncode[[01 February 2015]]
      Actual:   HtmlEncode[[Sunday, 1 February 2015]]
                            ↑ (pos 12)
      Stack Trace:
           at Microsoft.AspNet.Html.Abstractions.Test.HtmlContentBuilderExtensionsTest.Builder_AppendFormat_WithDifferentCurrentCulture()
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
           at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
           at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

This affects https://github.com/aspnet/Universe/issues/304.

Opened CoreCLR issue https://github.com/dotnet/corefx/issues/3974


Start selection at initial value

When I open up the select box I start at the top of the options, even if the selected value is on the bottom. This is an issue when the list of options is very long.
Reproduction Link
https://jsfiddle.net/sadece/6vps23wn/25/
Steps to reproduce

Open reproduction link
See that 40 is selected
Open multiselect
See that selection begins at 0

Expected behaviour
I would expect that the selection starts from 40, else I have to scroll endless to get to my value, if I want to do a slightly change.
Actual behaviour
It starts at the beginning of the list except for the actual selected value.

For a single select you can do this as a work around for now.
in your component something like this:
    Multiselect(
      ref='select'
      @open='onOpen'
      ...
    )

and then handle it like this:
onOpen() {
    const select = this.$refs.select
    let position = select.filteredOptions.findIndex(
      option => option[select.trackBy] === select.value[select.trackBy]
    )
    select.pointerSet(position)
    this.$nextTick(() => {
      select.$refs.list.scrollTop = select.pointerPosition
    })
  }
}

Just make sure your optionHeight is correct. If for some reason it has been restyled and is not the default 40, you will need to pass whatever it is with the optionHeight prop.

That worked for me. Thanks @jaeming 😄


Improve the n and p shortcuts

The n and p shortcuts currently increment and decrement an integer. This integer is used as the index of the hunk to show on the screen.
This is a bad user experience as the integer can be incremented above the number of hunks, which has no visible effect except that the next n will also have no visible effect.
The p shortcuts should not set a value equal or above the number of hunks.
The n shortcuts should not set a negative value.

Let this issue and #6 be assigned to you!

Fixed by #26 !


I made some changes to the stuff you did for pull request

Please review and merge into your main branch, which should update the pull request so I can merge it into main branch of live project.

HI @ingted. Can you please have a look at the above and provide feedback.  If I don't get feedback in 7 days I intend to merge this into project main branch directly through a new pull request and close your pull request, but I would prefer to have your feedback

Let me check it today!!


Help! New to java, struggling with getting this into Eclipse

Hey, I'm new to java development (using it for speeding up my real-time game server, coming from python)
I downloaded the ZIP of this repository, but can't find out how to add this so that it can be used in eclipse.

There is a big folder of folders, and I don't know where to start:

There isn't much help online that I could find for this case, is there a way to compile this into a single .JAR to add to eclipse? (I've had this problem with other .GIT repositories) Here is my simple project right now:

Any help is greatly appreciated! (I'm on mac os X btw, not that it should be different)

You can find the JAR here. I suggest you use Gradle or even Maven to manage your dependencies for you. It could get tricky juggling all the JARs.
All the best~

Looks like problem is answered.
Greetings
marci4

I ended up figuring out that you can build the repository by callling 'ant' after cding to the root folder of the package. Also, ended up tweaking this lib for my own uses :)

@clickstan if you have anything to share feel free to open a pull request ;)


Add a work-record resource type

Creating this PR to match the work being done in PureFarming

Adds a Crop Work Record resource type

Required by the links > content-type field in the Resource-Type schema:
https://github.com/Datalinker-Org/Geospatial/blob/dc05222eba59beee7d743f9d31bbfe8819d3ed1c/types/ResourceType.json#L28-L33
https://github.com/Datalinker-Org/Geospatial/blob/dc05222eba59beee7d743f9d31bbfe8819d3ed1c/types/RelationType.json#L11-L14

I wasn't sure if I needed to add this to DataLinker or not (because the actual schema doesn't force us to use well-known/ResourceType records) so we can actually specify what we want from PureFarming

This makes sense - helps us keep the links between entities consistent. We should probably also add WorkOrder and WorkItem, as they are other resource types added recently.


Database url builder

Add support for mysql options file
Support reading the mysql options file, in case that is being used in
the Django configuration.
Resolves #25

Merging once tests pass, as approval was given over slack


Remove whitespaces from beginning of paths entered by "enter interpreter path" prompt

If you copy the path to the interpreter from somewhere and accidentally leave a space in it, interpreter selection fails. It'd be nice if we could remove whitespaces from the beginning of paths that are entered

This could be a valid path.


Fix documentation using the getHeader method

Add missing 0 index to documentation making use of the getHeader method.
The getHeader method always returns an array, but it may be empty.
For documentation purpose, we assume that the response object always contains the queried header, thus providing at least one element in the array at index 0.
Fixes #1972.

@tomzx maybe it's better to use getHeaderLine instead of getHeader()[0]. What do you think?

@gregurco Not entirely sure, since getHeaderLine will merge a multi-value arrays using semi-colons as separators.

@tomzx yep, but if there is only one value, then this value will be returned, if header doesn't exist then empty string will be returned. But in your case you will call inexistent index.

@gregurco True, but given some other parts of the documentation already used the zero indexing I thought it would be better to stay consistent.
Should then the other examples using getHeader with the 0 index also be replaced with getHeaderLine?

Thanks @tomzx for the fix and @gregurco for the comments. I think it would be better to discuss the getHeaderLine question in a separate issue/PR, so I will just merge this one.


How to make a simple GADT work?

module GadtTest

type expr (t: Type): Type =
    | C : t -> expr t
    | Add : expr int -> expr int -> expr int
    | Eq : expr int -> expr int -> expr bool

I've only just recently figured out how GADTs work in Haskell, tried to emulate them using phantom types in F# and then in Fstar once that failed. But I am not sure how to get the above example to type check. Am I doing something wrong here?

module GadtTest

noeq type expr : Type -> Type =
    | C   : #t:Type -> t -> expr t
    | Add : expr int -> expr int -> expr int
    | Eq  : expr int -> expr int -> expr bool

let mk_17 : expr int = Add (C 1) (C 16)

let rec eval (#a:Type) (e:expr a) : Tot a =
  match e with
  | C i -> i
  | Add e1 e2 -> eval e1 + eval e2
  | Eq e1 e2 -> eval e1 = eval e2

Ok, I see now, thanks. I am not sure what these implicits parameters are for or why they are needed there in the first place though.

Disregarding implicits for the moment, the type of C is t:Type -> t -> expr t. What this means is that for any type t, you can apply C to t and a value of that type. e.g., C int 0 or C bool true. Now, as you can see, explicitly writing int or bool is a bit painful. So, by marking the t argument implicit, you can just write C 0 or C true and the compiler will figure out what the missing t argument is. The same thing applies to eval. Hope that helps


Table lose formating when using fromHTML

Thank you for submitting an issue to jsPDF. Please read carefully.
Are you using the latest version of jsPDF?
I'm using the latest version of jsPDF
Have you tried using jspdf.debug.js?
yes
Steps to reproduce
Create simple html table, give it a little bit of formatting, then import it to the pdf using the fromHTML (If im not mistaking this is another library inside of jsPDF)
Ideally a link too. Try fork this http://jsbin.com/rilace/edit?html,js,output
What I saw
Tables lose the original format. I have read all over the place that jsPDF doesn't handle CSS. Has this been taking care of? I feel it's something very important and basic to able to understand css
What I expected
The table with the css and formatting

We are closing this issue, because we will not support any longer fromHTML and addHTML.
Explaination:
We are working on a new html2pdf plugin, which will be based on html2canvas and our context2d plugin. This should lead to more reliable results for your projects. And it will give us the time to focus on the core functionality of pdf-generation because we will not use our energy for writing/supporting/extending 2 html plugins. If you still want to use addHTML or fromHTML you can still use jsPDF 1.4.1.
Best Regards


KAFKA-13702: Connect RestClient overrides response status code on request failure

In case the submitted request status is >=400, the connect RestClient throws a ConnectRestException with the proper response code, but it gets intercepted and rethrown with 500 status code, effectively overriding the actual failure status.
Includes a new unit-test class for the RestClient
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@C0urante thanks for the review, I've addressed your comments

@C0urante addressed the comments, I think the only outstanding one is whether we should add junit-jupiter-params to dep. list and use that for parameterised tests

@C0urante thanks, addressed the comments. hopefully checkstyle is all good now - I wasn't able to run the gradle task locally for some reason, it kept getting stuck, but now it's working and reporting no issues


[Do not commit] Debug CI issues

Description of PR
I'm reverting the changes done till the last known successful run. I'll abandon this PR once my debugging is complete. Please don't merge this.
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

This was only for debugging. Abandoning this PR.


Ktlint precommit is not compatible with JDK 17

We use https://github.com/macisamuele/language-formatters-pre-commit-hooks with pre-commit to autoformat code during commit.
Our config is using revision v1.6.1 of this hook, which is failing with JDK 17 with the error
Exception in thread "main" java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: Could not initialize class org.jetbrains.kotlin.com.intellij.openapi.util.objectTree.ThrowableInterner

After updating macisamuele/language-formatters-pre-commit-hooks to available version (v2.3.0), the error become more clear:
openjdk version "17.0.3" 2022-04-19 LTS
OpenJDK Runtime Environment Corretto-<IP_ADDRESS>.1 (build 17.0.3+6-LTS)
OpenJDK 64-Bit Server VM Corretto-<IP_ADDRESS>.1 (build 17.0.3+6-LTS, mixed mode, sharing)

Traceback (most recent call last):
...
language_formatters_pre_commit_hooks.pre_conditions.ToolNotInstalled: JRE: version < 16.0 is required to run this pre-commit hook.
Make sure that you have it installed and available on your path.
Download/Install URL: https://www.java.com/en/download/

can we manually set the env of the pre-commit hook to be something like JAVA_HOME=<java 11> <run hook>?

Ktlint (version 0.46 at time of writing) technically works on JDK 16+ according to its own changelog, but it looks like it requires finicky JVM args in order to do so. For example, the Ktlint CLI automatically adds --add-opens java.base/java.lang=ALL-UNNAMED if it detects Java 16+.
The pre-commit hook has no way of adding JVM args, and even explicitly prohibits JDK 16+ in the most recent versions. I decided to play around with making pre-commit call into Gradle to run Ktlint instead of using the hook:
.pre-commit.config.yaml:
- repo: local
  hooks:
  # ...
  - id: ktlint
    name: Ktlint
    entry: ./.pre-commit-hooks/ktlint.py
    language: python
    files: ^.*\.kt$

.pre-commit-hooks/ktlint.py:
import os
import sys
import subprocess

# Runs a shell command
def run(command):
    subprocess.run(command, stdout=sys.stderr, stderr=sys.stderr, shell=False, check=True)

# Returns the output from a shell command. Bails if the command failed
def get_cmd_output(command):
    result = subprocess.run(command, capture_output=True, shell=False, check=True)
    return result.stdout.decode("utf-8").strip()

def main():
    repo_root = get_cmd_output(["git", "rev-parse", "--show-toplevel"])
    os.chdir(repo_root)

    file_list = ':'.join(sys.argv[1:])
    run(["./gradlew", "ktlintPreCommit", f"-Pktlint.filelist={file_list}"])

if __name__ == "__main__":
    main()

build.gradle.kts:
tasks.register<JavaExec>("ktlintPreCommit") {
    description = "Run by pre-commit to check files"
    group = "formatting"
    classpath = configurations.getByName("ktlint")
    main = "com.pinterest.ktlint.Main"
    // Fixes Ktlint for Java 16+: https://github.com/pinterest/ktlint/issues/1195#issuecomment-1009027802
    jvmArgs = listOf("--add-opens=java.base/java.lang=ALL-UNNAMED")
    args = listOf("-F") + project.property("ktlint.filelist")!!.toString().split(":")
}

This got me passed the NoClassDefFoundError, but ultimately I encountered something new:
Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field private transient java.lang.Object java.lang.Throwable.backtrace accessible: module java.base does not "opens java.lang" to unnamed module @d310a75

It seems Ktlint still doesn't actually work on JDK 17, even with the JVM args hack. When that gets fixed, then we can revisit this approach if the pre-commit hook is still not updated.

can we manually set the env of the pre-commit hook to be something like JAVA_HOME=<java 11> <run hook>?

The pre-commit hook documents how to work with multiple JDK versions to work around this, but I don't like the additional setup that is required for it. There's also a way to run it in Docker, but then installing Docker is required to run Ktlint.


Thrust when exported now automatically calls thrust_create_target

Description
Instead of having each consuming project inject a code block into the project-config.cmake we instead have rapids-cmake call thrust_create_target right after find_package(Thrust), only when thrust was found.
This fixes two existing issues:

It removes the need for rapids_cpm_thrust to remove the the custom Thrust target from the global target set. Now that target will exist when rapids-cmake tries to promote it to global
It removes issues when multiple calls to find_package(thrust) occur before any calls to thrust_create_target. This creates some vexing issues when the thrust find calls resolve to different major versions of thrust

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The cmake-format.json is up to date with these changes.
[x] I have added new files under rapids-cmake/

[x] I have added include guards (include_guard(GLOBAL))
[x] I have added the associated docs/ rst file and update the api.rst

/merge


llvmPackages_10: cross-compilation support

Motivation for this change
Cross compilation of clang 10. Ultimately to make bootstrap tools for platforms that use clang in their stdenv.
Tested building on x86_64-linux with
nix-build \
  --keep-going \
  --argstr crossSystem aarch64-linux \
  -A llvmPackages_10.llvm \
  -A llvmPackages_10.lld \
  -A llvmPackages_10.compiler-rt \
  -A llvmPackages_10.libcxx \
  -A llvmPackages_10.libcxxabi \
  -A llvmPackages_10.clang-unwrapped \
  -A pkgsCross.wasi32.hello

Note that presently I can't test the following due to a build cycle in gcc:
cycle detected in the references of '/nix/store/dkc8jicyd1pibg3hfgasbnvl6schw9da-gcc-debug-9.3.0-aarch64-unknown-linux-gnu-lib' from '/nix/store/nv8nb53m5ypywdgjh6b38pxi0klncgls-gcc-debug-9.3.0-aarch64-unknown-linux-gnu'

nix-build \
  --argstr crossSystem aarch64-linux \
  -A llvmPackages_10.clang \
  -A llvmPackages_10.libcxxClang

Note that while it's possible to build a wrapper, the wrapper uses the build platform's shell so I was unable to test it.
Some interesting points:

clang-tblgen doesn't seem to have an install rule within clang, which suggests it's never meant to be installed. To export it without altering the interface I added a tablegen output.
llvm-config is installed by llvm to work a bit like pkg-config and help locate components of llvm. Installing the native version to a different output didn't work, since it assumes it's installed alongside llvm. I made up the name llvm-config-native to avoid a conflict, but I'm hoping there's a nicer way to do this. The two versions here are:

the installed version, which runs on the host platform, installed by cmake as llvm-config. This tool is probably never used when building with nixpkgs.
the "NATIVE" version, which runs on the build platform, installed in postInstall as llvm-config-native. This is required for the lld and clang builds.

I don't see why lld would be required to build clang so I removed it. The build didn't fail, but I don't have a strong argument as for why it should or should not be included.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@thefloweringash Can you fix the merge conflict?

Rebased to fix the merge conflict, and updated to include current state of testing.

N.B. I started fixing conflicts and then got carried away; I'll try to open the patch to staging soon.

N.B. I started fixing conflicts and then got carried away; I'll try to open the patch to staging soon.

Going to close this in favor of #111487. There's a similar version of this in #105026 for llvm 11 for making bootstrap tools.

@thefloweringash well I just edited that one' descriptions to point out I didn't really end up fixing all the cross things :)

@thefloweringash well I just edited that one' descriptions to point out I didn't really end up fixing all the cross things :)

Testing the one use case I'm focused on right now (cross compiling unwrapped llvmPackages_11), it looks like it works as long as I remove lld from clang-unwrapped's buildInputs.

@thefloweringash do you know why it's deemed needed at all?

Also would you like to review https://github.com/NixOS/nixpkgs/pull/111487 ? We have quite little time before the 21.05 staging freeze.

Hmm it was db29857eb391ed002046090851a44c452b80bdbd. Fishy... I'll leave a comment there.


update to parameter tuning answers (grid search, random search, and bo)

Hopefully the explanations aren't too long but if so, just let me know and I could edit! Or if you'd like, feel free to make changes yourself as well! :)

Additionally, I plan to work on the computer vision answers next!

Thank you for your contribution!


exact version of python

I have looked through the readme but didn't find the exact version of python that I should use.
Would you introduce the exact version of python? I have tried some, but it didn't work.

I tested TikNib with Python 3.5.2.
If it is the issue in installing the packages with pip in the latest versions of Python, could you try to remove the package versions in requirement.txt?
Otherwise, could you paste the errors so that I can look into it?

I have tried Python 3.5.2; it occurs the following errors:
Could not find a version that satisfies the requirement capstone==4.0.0rc1 (from -r requirements.txt (line 2)) (from versions: 2.0, 2.1, 3.0, 3.0.1, 3.0.2, 3.0.3, 3.0.4, 3.0.5rc2, 3.0.5, 3.0.5.post1, 4.0.0, 4.0.1, 4.0.2)
No matching distribution found for capstone==4.0.0rc1 (from -r requirements.txt (line 2))
Removing package versions of the second line meet errors:
 Could not find a version that satisfies the requirement scikit_learn==0.23.2 (from -r requirements.txt (line 6)) (from versions: 0.9, 0.10, 0.11, 0.12, 0.12.1, 0.13, 0.13.1, 0.14, 0.14.1, 0.15.0b1, 0.15.0b2, 0.15.0, 0.15.1, 0.15.2, 0.16b1, 0.16.0, 0.16.1, 0.17b1, 0.17, 0.17.1, 0.18rc2, 0.18, 0.18.1, 0.18.2, 0.19b2, 0.19.0, 0.19.1, 0.19.2, 0.20rc1, 0.20.0, 0.20.1, 0.20.2, 0.20.3, 0.20.4, 0.21rc2, 0.21.0, 0.21.1, 0.21.2, 0.21.3, 0.22rc2.post1, 0.22rc3, 0.22, 0.22.1, 0.22.2.post1)
No matching distribution found for scikit_learn==0.23.2 (from -r requirements.txt (line 6))
Removing versions of all packages can install the packages successfully.

Thanks for the checking. I'll look into it and make it solidly support the versions.

For making the original requirements.txt, I ran pipreqs in the project root. However, it may have produced an incorrect one.
I fixed it and confirmed that it works with Python 3.8. Please check 200043a


[tracking] [insights-operator-ldapauth] #80

https://github.com/RedHatInsights/insights-operator-ldapauth/issues/80

Fixed in https://github.com/RedHatInsights/insights-operator-ldapauth/pull/87


Improve the designing of logo

The color palette of logo does not look perfectly linked with website theme.
I am interested to improve the logo design. So, kindly assign me this task.

I have designed two logo that align with website theme and motive, so please review them.
Figma file : https://www.figma.com/design/vxkJVqSvsy7FBGrMUfaIhU/30-Days-of-CPP?node-id=0-1&t=l00GZLENvlSR7p68-1


Build version 1.13 on the 1.13 branch

@conda-forge/routes, this is ready for review/merge

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ping @pmlandwehr, the build 1.13 of routes is ready to merge on its own branch.


Don't use ::class

I think, Don't use ::class, should use sring class name.
Why? because ::class will trigger auto load the class.sometimes we never no use it.

From the PHP Manual

The class name resolution using ::class is a compile time transformation. That means at the time the class name string is created no autoloading has happened yet. As a consequence, class names are expanded even if the class does not exist. No error is issued in that case.

http://php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class


problem with Require vue-router from bootstrap file

Bootstrap file

App file

Problem is

The solution add to app file this lines

Dependencies

@pixieaka change window.Vue = require('vue')
to
import Vue from 'vue' window.Vue = Vue;  instead
https://vuejs.org/v2/guide/typescript.html#Important-2-2-Change-Notice-for-TS-webpack-2-users

Thanks it work great now 👍


Mindgamesnl wanted me to do this

I got punished if I didn't create this pull request.
PLEASE DON'T HURT ME MINDGAMESNL!


In very restricted situations, Backend_impl.alloc_impl causes memory corruption

In particular, see hello_world_op.ml and run just:
let () =
  setup ();
  _Matrix_multiplication_dims_2x3 ();
  _Big_matrix ()

Then the crash will happen on malloc.c in the function libc_free, reporting double free or mem corruption. When there is more computation after the garbage collection, the crashes are unpredictable.
Currently we use Ndarray.create_array as a work-around. If we decide to stick to it, we can expose these arrays directly to the user.

Unfortunately this doesn't address the underlying reason. The full run:
let () =
  setup ();
  _Pointwise_multiplication_dims_1 ();
  _Matrix_multiplication_dims_1x1 ();
  _Print_constant_tensor ();
  _Matrix_multiplication_dims_2x3 ();
  _Big_matrix ();
  _Very_big_tensor ()

fails even with allocating bigarrays, while the smaller run above doesn't fail with bigarrays instead of ctypes arrays.


x/tools/gopls: Changes inside the vscode editor are not tracked

What version of Go are you using (go version)?

$ go version
go version go1.13.4 windows/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\ravenlli\AppData\Local\go-build
set GOENV=C:\Users\ravenlli\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\ravenlli\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=c:\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\ravenlli\AppData\Local\Temp\go-build991420482=/tmp/go-build -gno-record-gcc-switches

What did you do?

I was using vscode-go together with gopls and other go tools (all installed automatically), when I made some changes to the file inside the vscode editor, such as adding or deleting some lines, linting or auto-completion couldn't work correctly. I had to reload the window to get things right.

In the above example, when my mouse cursor stops above "splitDhash", it came out the description of "blockMasks" just because I inserted an empty line at line 122.
What did you expect to see?
Changes inside the vscode editor should be tracked.
What did you see instead?
Changes inside the vscode editor are not tracked.

Has this happened to you more than once or was it just in this instance? If it happens often, can you share a gopls log from when this happens (see how to capture logs here). What version of gopls are you using (gopls version)?

Has this happened to you more than once or was it just in this instance? If it happens often, can you share a gopls log from when this happens (see how to capture logs here)? What version of gopls are you using (gopls version)?

It happens often, and not only to me.

It happens often, and not only to me.
$ go version
go version go1.13.4 windows/amd64

It happens often(nearly every time), and not only to me.

$ gopls.exe version
golang.org/x/tools/gopls 0.2.0
<EMAIL_ADDRESS>h1:ddCHfScTYOG6auAcEKXCFN5iSeKSAnYcPv+7zVJBd+U=

some gopls log regarding the example func splitDhash:
Output

[Trace - 14:41:46.622 PM] Sending request 'textDocument/hover - (13)'.
Params: {"textDocument":{"uri":"file:///d%3A/code/goneat_video_content_sim_dhash_svr/src/streamsim/sim_handler.go"},"position":{"line":122,"character":10}}
[Trace - 14:41:46.665 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2019/11/13 14:41:46 38.0038ms for GOROOT=c:\go GOPATH=D:\code\goneat_video_content_sim_dhash_svr;C:\Users\ravenlli\go GO111MODULE= PWD=d:\code\goneat_video_content_sim_dhash_svr go "env" "GOMOD", stderr: \u003c\u003c\u003e\u003e stdout: \u003c\u003c\n\u003e\u003e\n"}
[Info  - 下午2:41:46] 2019/11/13 14:41:46 38.0038ms for GOROOT=c:\go GOPATH=D:\code\goneat_video_content_sim_dhash_svr;C:\Users\ravenlli\go GO111MODULE= PWD=d:\code\goneat_video_content_sim_dhash_svr go "env" "GOMOD", stderr: <<>> stdout: <<

[Trace - 14:41:46.707 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2019/11/13 14:41:46 80.219ms for GOROOT=c:\go GOPATH=D:\code\goneat_video_content_sim_dhash_svr;C:\Users\ravenlli\go GO111MODULE= PWD=d:\code\goneat_video_content_sim_dhash_svr go "list" "-m" "-json" "all", stderr: \u003c\u003cgo list -m: not using modules\n\u003e\u003e stdout: \u003c\u003c\u003e\u003e\n"}
[Info  - 下午2:41:46] 2019/11/13 14:41:46 80.219ms for GOROOT=c:\go GOPATH=D:\code\goneat_video_content_sim_dhash_svr;C:\Users\ravenlli\go GO111MODULE= PWD=d:\code\goneat_video_content_sim_dhash_svr go "list" "-m" "-json" "all", stderr: <<go list -m: not using modules

stdout: <<>>

[Trace - 14:41:46.754 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2019/11/13 14:41:46 44.8674ms for GOROOT=c:\go GOPATH=D:\code\goneat_video_content_sim_dhash_svr;C:\Users\ravenlli\go GO111MODULE= PWD=d:\code\goneat_video_content_sim_dhash_svr go "env" "GOPATH", stderr: \u003c\u003c\u003e\u003e stdout: \u003c\u003cD:\code\goneat_video_content_sim_dhash_svr;C:\Users\ravenlli\go\n\u003e\u003e\n"}
[Info  - 下午2:41:46] 2019/11/13 14:41:46 44.8674ms for GOROOT=c:\go GOPATH=D:\code\goneat_video_content_sim_dhash_svr;C:\Users\ravenlli\go GO111MODULE= PWD=d:\code\goneat_video_content_sim_dhash_svr go "env" "GOPATH", stderr: <<>> stdout: <<D:\code\goneat_video_content_sim_dhash_svr;C:\Users\ravenlli\go

Can you please share the full gopls log, even if it's very long? The excerpts here are not relevant to the issue you're seeing.

Here is the full gopls log.
issue35526.log

Based on your logs, it looks like gopls hasn't fully initialized by the time the change to the file comes in. We've recently made some changes to handle this - can you try installing gopls at master and reporting if you still see the same issues? To install at master, git clone https://go.googlesource.com/tools, cd into the tools/gopls directory, and run go install. If you still see the same issue at master, please attach the full logs.

Closing this issue as it's now almost 2 months old. @leerayven: Please open a new issue if you are still encountering problems.