Get Started

I would like to create a self-hosted runboat to have a CI/CD environment for Odoo (with GitLab).
I read the README.md and the wiki.
I don't have any experience on Kubernetes... and its seems to be my weakest link.
For the record, I first created a new Debian 11 VM, installed docker on it and k8s but it was looks like overkill.
After some reading, I discovered rancher with its webui so, I re-installed this VM with Ubuntu 20.04 server, installed docker and I ran rancher (with its self-hosted k3s) in a container with privileges.
But once again, I was not able to make the link with runboat.
Could you make a simple diagram to explain how everything is inter-connected ?
In the wiki, you talk about microk8s that is another kubernetes implementation by ubuntu, so I suppose that it could be the base for a detailed How-To.
It is not in my habits to claim help of this type, but could you record all console steps, starting from a fresh Ubuntu 20.04 server install, to run a self-hosted runboat with a single node kubernetes cluster ?

@ypapouin I have added a deployment diagram and some getting started instructions in the README. I hope this helps.
If you want a single node cluster that you manage yourself, microk8s is an easy solution (together with k9s to explore the cluster content).
I see you mention GitLab. Note that currently runboat supports GitHub only. It should not be too difficult to support GitLab, but some light refactoring is necessary to make it support multiple git providers.

Thank you @sbidoul.
Indeed microk8s is a lot simpler and I managed to run it and start a Runboat instance on docker.
The diagram make the whole architecture more clear.
I took a look on the runboat source code and I agree that making support for GitLab would not be very hard.
But before starting hacking on it, I would like to have a fully working infrastructure via Github.
Could you add some screenshots of the current GitHub Webhook settings for an sample repository (url, authentication, etc.) ?

Here is the GitHub webhook for OCA:

Payload URL: https://runboat.odoo-community.org/webhooks/github
Secret: the same as RUNBOAT_GITHUB_WEBHOOK_SECRET
Events: Pushes and Pull Requests


Crashes when i drag and drop a tab from split screen mode

Uncaught Error: Minified exception occurred; use the non-minified dev environment for the full error message and additional helpful warnings. /Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/invariant.js:56

I am still having trouble with this issue.  Atom locks up consistently when dnd'ing across split panes.  I generally have to click the "keep waiting" button a couple of times before the atom can resume.
OS: Windows 7 SP1
Atom: 0.199.0

@jayflo I'm really sorry to hear that. Can you reproduce the problem when Atom is launched in safe mode with atom --safe?

Gah, I apologize.  In safe mode neither the tabs, nor tree-view, appeared due to the fact that I previously installed the sublime-tabs package.  The problem is with that package.  The built-in tabs package is working just fine.
Thanks for the quick response.

No problem at all. Hope it gets resolved for you soon!


Issue with cyrillic named workspaces

One of my workspaces is Cyrillic named. Have this little issue in the Comedian Admin panel

@kalashnikovisme if you can please provide the workspace ID or real cyrillic name, I can look into it next week to see why it got messed up

@anatoliyfedorenko already provided it at this issue https://github.com/maddevsio/comedian/issues/261

@kalashnikovisme the issue was found & fixed. Two ways we can deal with the consequences. One is you just delete comedian from that workspace and install it again. Another is you tell me the exact name of the workspace and i can set it up for you.

@kalashnikovisme please, provide the name of the team


Delete debug mode flag

The debug mode flag has delete in https://github.com/julia-vscode/LanguageServer.jl/commit/34d5bc697c0ecf20ffef48a1ee04e72e71bef6fb

Sorry for the delay, thanks for your PR.


Blacklist support?

Do the packages that wrap bnlearn support blacklists?  While I can't find anything in the documentation about it, when I check the code for the BNlearnAlgorithm class, there are multiple mentions to a 'blacklist.csv' file, as well as a blacklist argument in _run_bnlearn.  However, I can't find any way to specify a blacklist when calling any bnlearn methods.  Is this a currently supported feature?

Hello!
The algorithms do support the blacklist feature, but the whitelist feature is not supported yet ( Soon I hope). To provide a blacklist, just provide a nx.Graph( ) (undirected graph) with the blacklisted edges not in the graph, in the predict graph= argument
Hope this helps,
DIviyan

Great, thanks for the information! Since you have to provide the blacklist
as an undirected graph, does that mean that it doesn't currently support
blacklisting only a single direction? For example, if I know that A comes
before B, is there anyway to encode that, or blacklist just the B -> A
direction?
Thanks,
Amanda
On Fri, Nov 12, 2021, 3:21 AM Diviyan Kalainathan @.***>
wrote:

Hello!
The algorithms do support the blacklist feature, but the whitelist feature
is not supported yet ( Soon I hope). To provide a blacklist, just provide a
nx.Graph( ) (undirected graph) with the blacklisted edges not in the graph,
in the predict graph= argument
Hope this helps,
DIviyan
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FenTechSolutions/CausalDiscoveryToolbox/issues/112#issuecomment-966911491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJE2RLV5MODPLPEKPANDY3ULTFAJANCNFSM5G72AH4Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hello,
After a quick check, it is better to use directly the _run_bnlearn() function (defined for all bnlearn algorithms :
You can obtain the networkx.DiGraph 's blacklist with :
        blacklist = DataFrame(list(nx.edges(nx.DiGraph(DataFrame(-nx.adj_matrix(graph2, weight=None).todense() + 1,
                                                                 columns=list(graph2.nodes()),
                                                                 index=list(graph2.nodes()))))), columns=["from", "to"])

Actually, the digraph is managed strangely (a mix of whitelist and blacklist)
Hope this helps,
Diviyan


Moved the formatter script to the formatter action path

Fix is working - https://github.com/tjgurwara99/scripts/actions/runs/3967396047/jobs/6799328093
I didn't see that you'd moved the filename_formatter.sh out of the action path.

Forgot to mention: do we need to do this for the directory workflow as well?

Yeah that one also needs to be changed 😅


cmake: empty string is not missing token

When CMAKE_CXX_COMPILER_ID isn't set, this line errors out because if(STREQUAL GNU) is a syntax error.

I noticed this when refactoring this code. For example the PNaCl compiler triggers this error. In the current code state, this code is never run with PNaCl, but once we start refactoring code in to be mutualized for usage with other NaCl compilers like Saigo, such error may surface.

LGTM


Clean binary search implementation in SlicedRowFilter

Rewrote SlicedRowFilter#findInsertionPoint for a cleaner version. Previous version had strange conditionals (same for if and else):
      if (left > right) {
        left = right;
      } else if (right < left) {
        right = left;
      }

and FIXME comments cast some doubts on the correctness of the code. In the end, the code was correct but not very readable.
Tested both previous and current implementation with
  public static void main(String[] args) {
    List<Pair<byte[], byte[]>> ranges = new ArrayList<>();
    ranges.add(new Pair<>(new byte[] {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24}, new byte[] {0, 2, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24}));
    ranges.add(new Pair<>(new byte[] {0, 3, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24}, new byte[] {0, 4, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24}));
    SlicedRowFilter srf = new SlicedRowFilter(new int[] {0, 24}, ranges, Long.MAX_VALUE);

    // -1
    System.out.println(srf.findInsertionPoint(new byte[] {0, 0, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24}));
    // 0
    System.out.println(srf.findInsertionPoint(new byte[] {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24}));
    // -2
    System.out.println(srf.findInsertionPoint(new byte[] {0, 1, 3, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24}));
    // 1
    System.out.println(srf.findInsertionPoint(new byte[] {0, 2, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24}));
    // -3
    System.out.println(srf.findInsertionPoint(new byte[] {0, 2, 3, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24}));
    // 2
    System.out.println(srf.findInsertionPoint(new byte[] {0, 3, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24}));
    // -4
    System.out.println(srf.findInsertionPoint(new byte[] {0, 3, 3, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24}));
    // 3
    System.out.println(srf.findInsertionPoint(new byte[] {0, 4, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24}));
    // -5
    System.out.println(srf.findInsertionPoint(new byte[] {0, 4, 3, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24}));
  }

and it gives the same result.
Also some minor changes.

Could you fix the conflict?


Visiting Jed's website results in 404 error

Hi,
when I try to visit the Homepage of Jed, I get a 404. Anyone noticing the same issue?
Sincerely,
yduman

We switched it to the messageformat organization for compliance with the js foundation. The github stuff 301s the repo but it doesn't 301 github pages
If anyone has ideas on how to 301 the page without overriding the repo 301s, I'd love that info.

It's here now though: http://messageformat.github.io/Jed/

Strangely, a couple of hourse before, the "new" link had a 404 too. But now it's working so nvm 👍 . Thanks!

It's broken on README.md:

For more info, please visit the docs site at http://messageformat.github.com/Jed.

You should change to the one @alex-stripe wrote.

For more info, please visit the docs site at https://messageformat.github.io/Jed/

You should also change the Repo URL displayed near the top of https://github.com/messageformat/Jed/.

Bumping this as a quick reminder - the repo URLon GitHub still reads http://slexaxton.github.com/Jed. The README URL on npm is also stuck at the wrong one - might be worth a new patch release. Thanks!


Confusion about gradients

The front readme says icons must have "No gradients or fades.", but the Firefox and JSON logos clearly have gradients in them. Should that rule be removed, as the size requirement will preclude many gradients, anyway?

Yup. Go ahead and remove it.


Checkbox not updating boolean value

I'm pretty new to this gem so this could just be a general user error.
I have a boolean checkbox in my cocoon form that seems to be stuck to false and no matter what I've tried and removed, I cannot get it to change. I am using this for categories and products creations.
In my categories controller params I have the products_attributes and in my categories model I have the accepts_nested_attributes_for :products, reject_if: :all_blank, allow_destroy: true.
I can update EVERYTHING else BUT my boolean checkbox.
I am using bootstrap_form_for and have my checkbox structured like this:
<%= f.form_group :tracking do %>
<%= f.check_box :tracking, as: :boolean, label: " Inventory Tracking", class: 'radio1', name: 'my-checkbox', inline: true  %>
<% end %>

removed "name" attribute and now it's working fine for anyone that might run into a similar problem. Smh...


MongoConfigProvider for shared config file

We were looking into the sharedconfig solution that you'll provide and wondering if having a MongoConfigProvider would fit the usecase. Want to get some opinion before I can dig into it to provide a solution or better if someone already has.

I think someone else already wrote one. Check on the Exhibitor email list.

i dont see anything in the users group: https://groups.google.com/forum/#!forum/exhibitor-users .
Is there a developers group as well?


Fix issue 203

🚀 Pull Request
Description
Change definitive form of calendar from gregorian to standard, instead of the other way around.
With first time attempt at [change of ] unit tests for this.

Thanks for submitting this @larsbarring! I was taking a look and I wondered if the changes to __init__ really would be that simple - I'm glad you think the same 🙂

Yeah, but it remains to be seen. The unit tests fails miserably (I am a complete rookie at these). And I have no insight regarding possible downstream dependencies

The unit tests fails miserably (I am a complete rookie at these). And I have no insight regarding possible downstream dependencies

The traceback is the same error we have been seeing recently during documentation builds, so we can definitely say it's not resulting in changes you have made. Unfortunately I am also clueless to the fix at the moment!

I've asked if @bjlittle could take a look at this - the problem was first observed at 5540e08ec88d0669bcc4071d931a7f96e9e026a9. But we're quite limited on time at the moment so there might be a wait.

Thanks, I have something for #185 in the pipeline, but it uses this change.

@trexfeathers @bjlittle Any chance the unit test problem might be fixed reasonably soon? That is, soon enough that the upcoming iris 3.2.0 will use cf-units with this fix implemented.

@trexfeathers @bjlittle Any chance the unit test problem might be fixed reasonably soon? That is, soon enough that the upcoming iris 3.2.0 will use cf-units with this fix implemented.

We've seen your message 🙂. We'll have a better idea of the answer in the next week.

Rebasing onto main should resolve the unit test problem @larsbarring

The linting failure I am not sure what to do about. And now two of the three initial test failures have been fixed. The third one is a bit more complicated. It seems that in Units.__num2date_to_nearest_second cftime returns an instance of cftime.DatetimeGregorian despite that the calendar specified in the call is "standard", cf. cftime issue #256 and PR #257. Maybe this could be an issue elsewhere where cftime is called?

The linting failure I am not sure what to do about

I think maybe we need to do for cf_units what https://github.com/SciTools/iris/pull/4235 did for Iris.  That's a bit outside my area of competency though!

The linting failure I am not sure what to do about

@larsbarring are you using pre-commit/black locally? I know we haven't made this expectation obvious.

@larsbarring if you install pre-commit in your development environment I think it should "just work" whenever you make a commit 🤞

Hm, this is becoming a bit too complex. The pre-commit black gives the same uninformative error, and seems to have reformatted lines that I have not touched L. 846-849, as well as L 1816-1819 where I changed the calendar.

I see what @rcomer is saying now. I've asked if anyone in the team has some time to look at this.
Thanks, as ever, for your patience @larsbarring 😬

The linting failure I am not sure what to do about

I think maybe we need to do for cf_units what SciTools/iris#4235 did for Iris. That's a bit outside my area of competency though!

Done, thanks to @wjbenfold ❤. @larsbarring if you bring in the latest main this ought to fix the linting trouble.

Linting failure solved -- thanks @wjbenfold, @trexfeathers, @rcomer !
The remaining test failure is because of Unit.num2date returns gregorian calendar:

in Units.__num2date_to_nearest_second cftime returns an instance of cftime.DatetimeGregorian despite that the calendar specified in the call is "standard",

Here is a quick hack to show the problem:
import cftime
import cf_units as unit
Unit = unit.Unit
u = Unit(
   "hours since 2010-11-02 12:00:00", calendar=unit.CALENDAR_GREGORIAN
)
print("repr(u)      =  ", repr(u))
res = u.num2date(1)
print("repr(res)    =  ", repr(res))
print("res.calendar =  ", res.calendar)

# repr(u)      =   Unit('hours since 2010-11-02 12:00:00', calendar='standard')
# repr(res)    =   cftime.DatetimeGregorian(2010, 11, 2, 13, 0, 0, 0, has_year_zero=False)
# res.calendar =   gregorian

And I do not know whether to wait for cftime to do something, or how fix this withn iris in a safe and general way.

As far as I can tell, it's impossible to create a standard calendar datetime instance with the current cftime release:
In [4]: cftime.datetime(2022, 1, 1, calendar="standard")
Out[4]: cftime.datetime(2022, 1, 1, 0, 0, 0, 0, calendar='gregorian', has_year_zero=False)

In [5]: test = _

In [6]: test.calendar = "standard"
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-6-fc68e10f067c> in <module>
----> 1 test.calendar = "standard"

AttributeError: attribute 'calendar' of 'cftime._cftime.datetime' objects is not writable

So I think the only way to get num2date to return a standard calendar object is to wait for the next cftime release, which will include the changes from https://github.com/Unidata/cftime/pull/257.  At that point I think it will change to "standard" regardless of what we do here.
Perhaps it doesn't matter.  Since you are looking at the CF Conventions, I guess your main concern is how NetCDF files are written?  I have an existing NetCDF file that was saved by a previous Iris version.  The time coordinate looks like this with ncdump:
	double time(forecast_reference_time) ;
		time:bounds = "time_bnds" ;
		time:units = "hours since 1970-01-01 00:00:00" ;
		time:standard_name = "time" ;
		time:calendar = "gregorian" ;

I made an environment with your branch and Iris v3.1.  I used this to load and re-save my file.  Now the ncdump shows me this:
	double time(forecast_reference_time) ;
		time:bounds = "time_bnds" ;
		time:units = "hours since 1970-01-01 00:00:00" ;
		time:standard_name = "time" ;
		time:calendar = "standard" ;

So for NetCDF saving, the change seems to be having the desired effect.  So one option may be to revert the expected value of the num2date test and bank the rest of the change.
There may be other considerations that I am missing.  What do others think?

My main reason for pushing this issue, except for the general argument that it is nice to follow  CF, is that we need to concatenate data from different sources that happens to have different calendars (#185). But in a PR to solve that issue I could include tests of both calendars (that later could compacted once a new version of cftime is available).

@SciTools/cf-units-devs I believe these tests should now pass with the latest version of cftime.  I tried re-running the py39 tests this morning but that didn't help.  Is there a way to make the tests start again with a fresh environment?

TBH not sure we can get this banked in time for iris 3.2 (which is our main focus at the moment), but we can swarm on it afterwards, as we need to make sure we get this right.
If banking this PR forces subsequent changes upstream within iris, then we can opt to release an iris 3.2.1 patch to align everything.
Sound like a reasonable plan?

I believe these tests should now pass with the latest version of cftime. I tried re-running the py39 tests this morning but that didn't help. Is there a way to make the tests start again with a fresh environment?

It looks like if a py3.9 lockfile already exists, it refuses to overwrite it even if the build number gets bumped, so I'm not sure @rcomer

Ok, I think if you rebase onto main then we can hopefully get the CI passing @larsbarring. Then we can move to reviewing with confidence that what's here passes the tests

I've also tried running the Iris tests with this and did get failures, so not sure what we're doing differently.  The good news is those failures were easy to fix with find-and-replace within Iris.


Use Pydantic v2 / dataclass models instead of untyped dictionaries in YChat Python API

Problem
The YChat API expects a dictionary in many areas of the code. For example, the YChat.get_users() and YChat.get_message() methods return dictionaries, but there's no indication to developers what the types of these dictionaries are, or what keys are available.
Proposed Solution
Use Pydantic v2 models instead of dictionaries for the YChat Python API. Pydantic v2 should be preferred over native dictionaries as much as possible on any developer API surface, but the YChat API should be prioritized.
Furthermore, the models & attributes within the models should be documented with docstrings. This will make it easier to develop extensions on top of jupyterlab-chat if IDE intellisense is available.
Additional context
At the time of writing (9 Dec 2024), Jupyter AI does not support Pydantic v2 on v3-dev. We will need to make those changes first before the PR for this issue can be merged & released.

Would TypedDict or dataclass instead work? Adding pydantic closer to core means more dependency conflicts and packaging issues.

@krassowski Thanks for calling this out. I agree; if we don't need the extra features provided by Pydantic, it seems preferable to use dataclass, as it offers a similar API and is native to Python.
I would also add that if we run into issues with dataclass, we should feel free to use Pydantic instead. Pydantic v2 is a very common dependency, and it should be safer than many of the dependencies already being pulled in by jupyterlab-chat.

I think dataclass is a reasonable approach for this case.

I've updated the title & description of this issue accordingly. Thanks folks!


Remove most of the unused warns

Hi @johnynek so I tracked down most of them. We still have some unused implicits and case classes that should have non-implicit param list. Both of them break binary compatibility however fixing case class should be less problematic.

@nevillelyh I didn't see a breaking change anywhere, and if we had one, I think mima should catch it. Can you comment on the line number you think is a breaking change?

It's the Ordering & Monoid implicits for SketchMapAggregator but I guess it's binary compatible despite the signature change.
https://github.com/twitter/algebird/pull/708/files#diff-9e23a301d88510f7cf5dae672bc3b9a3L243

@nevillelyh @johnynek yup, there are some implicit arg changes here but they translate to the same thing and should not break binary compatibility; My point was, and sorry if it led to confusion; that if we want to further remove the outstanding warnings we will break it. I can make another PR or an create an issue pointing them out.

yeah, I thought those implicit changes were okay because they are in the same order, same binary result.


Add unit tests for pipeline elements

Body
Our pipeline elements lack proper unit tests. This is something we should improve.
This issue collects pipeline elements that need (more) unit tests.
Dedicated sub-issues are created for the implementation of each pipeline element.
Pipeline elements to be improved:

[ ] #1885
[ ] #1886
[ ] #1887
[ ] #1888
[ ] #1889
[ ] #1890
[ ] #1891
[ ] #1892
[ ] #1893
[ ] #1894
[ ] #1895
[ ] #1896
[ ] #1897
[ ] #1898
[ ] #1899
[ ] #1900
[ ] #1901
[ ] #1902
[ ] #1903
[ ] #1904

...
StreamPipes Committer
I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.

hey @bossenti I'm really interested in contributing to these issues.

That's great to hear @aamirxshaikh
Simply pick one of the tasks and add a comment there so I can assign you to it


Unnecessary churn

I think we need a better implementation of cleanup_patch
We also seem to create un-nessicarry differences for changes in line numbers. See the changes in the patches/rust-cpython directory in DuckLogic/DuckLogic@f776c6025956bdc for an example.

Here's another example: DuckLogic@DuckLogic/29fbbf6fb617f37a64b8047389a80b7619ced1e2
The changes in git commit hashes and libgit2 versions are both unessicary. In this case libgit2 is downgraded.
I

Write a parse function that parses the patch-file before and after the changes, and see if there are any meaningful semantic changes.
Run a hypothetical patch, and see if the old file still manages to apply cleanly.

Option (1) seems less likely to trigger patch failures.
Option (2) seems more likely to avoid churn.


Create integration test with a database

Create a data model class and save it in a database (embedded) using junit.
The model class should have properties of all types:

String
Integer
Date
List
Embedded object (of the same type for example)

Implemented in #4


docs(postgres): document AWS IAM authentication for postgresql components

Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[X] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[X] Read the contribution guide
[ ] Commands include options for Linux, MacOS, and Windows within codetabs
[ ] New file and folder names are globally unique
[ ] Page references use shortcodes instead of markdown or URL links
[ ] Images use HTML style and have alternative text
[ ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description
For code in this PR that I'm hoping will be merged soon: https://github.com/dapr/components-contrib/pull/3324
Let's hold on this PR until the above gets merged please.
Issue reference
https://github.com/dapr/components-contrib/issues/3254

not stale. This has now been merged in components contrib. This docs PR is g2g for review


Expand clr-tree-node by clicking its text

[ ] bug
[x] feature request
[ ] enhancement

Expected behavior
I was wondering if it would be possible to expand a <clr-tree-node> by clicking/touching it's label in addition of the caret icon
Actual behavior
For now it's only possible to expand a <clr-tree-node> by clicking/touching its associated caret icon.

@MattMattV: We won't be able to provide that functionality because that wouldn't work for cases like routing with trees where users use a link in the tree-node to route to different components. But if you had to, you could simply use the clrTreeNodeExpanded input and toggle it when the node is clicked. Something like this: https://plnkr.co/edit/jX6JmHnEblzgqWRWYJN8?p=preview

Closing this issue based on the above comment.

Thank you for the workaround !

@adityarb88  Could you please reupload the Plunker? I don't know how to use the clrTreeNodeExpanded input.

@hubertkubiak - this is a very old issue. Can you ask your question on StackOverflow and label it with vmware-clarity? We can answer implementation questions there.


Bad signature error when updating setup files

$ apt-cyg install nano
Cache directory is /setup
Mirror is http://cygwin.mirror.constant.com
/tmp/tmp.NVpSEndUWV           100%[================================================>]   1.29K  --.-KB/s    in 0s
2017-09-29 12:37:15 URL:https://cygwin.com/key/pubring.asc [1324/1324] -> "/tmp/tmp.NVpSEndUWV" [1]
TRUSTEDKEY_CYGWIN: OK
/tmp/tmp.NVpSEndUWV           100%[================================================>]   1.66K  --.-KB/s    in 0s
2017-09-29 12:37:16 URL:http://cygwinports.org/ports.gpg [1702/1702] -> "/tmp/tmp.NVpSEndUWV" [1]
TRUSTEDKEY_CYGWINPORTS: OK
Updating setup.ini
setup.bz2                     100%[================================================>]   2.64M   384KB/s    in 7.0s
2017-09-29 12:37:23 URL:http://cygwin.mirror.constant.com/x86_64/setup.bz2 [2767026/2767026] -> "setup.bz2" [1]
setup.bz2.sig                 100%[================================================>]      72  --.-KB/s    in 0s
2017-09-29 12:37:24 URL:http://cygwin.mirror.constant.com/x86_64/setup.bz2.sig [72/72] -> setup.bz2.sig" [1]
Error: BAD signature: setup.bz2.sig
setup.ini                     100%[================================================>]  10.25M  1.07MB/s    in 8.7s
2017-09-29 12:37:33 URL:http://cygwin.mirror.constant.com/x86_64/setup.ini [10752852/10752852] -> "setup.ini" [1]
setup.ini.sig                 100%[================================================>]      72  --.-KB/s    in 0s
2017-09-29 12:37:33 URL:http://cygwin.mirror.constant.com/x86_64/setup.ini.sig [72/72] -> "setup.ini.sig" [1]
Error: BAD signature: setup.ini.sig
Error: updating setup.ini, reverting.

It used to work in the beginning and then it stopped after few usages.

Please try following commnands.
mkdir -p /tmp/issue25
cd /tmp/issue25
wget --no-verbose --show-progress https://cygwin.com/key/pubring.asc http://cygwin.mirror.constant.com/x86_64/{setup.bz2,setup.bz2.sig,setup.ini,setup.ini.sig}
gpg --homedir . --import pubring.asc
gpg --homedir . setup.bz2.sig && echo "Good signature" || echo "Bad signature"
gpg --homedir . setup.ini.sig && echo "Good signature" || echo "Bad signature"

My result is below:
$ mkdir -p /tmp/issue25
$ cd /tmp/issue25
$ wget --no-verbose --show-progress https://cygwin.com/key/pubring.asc http://cygwin.mirror.constant.com/x86_64/{setup.bz2,setup.bz2.sig,setup.ini,setup.ini.sig}
pubring.asc         100%[===================>]   1.29K  --.-KB/s    in 0s
2017-09-30 06:14:53 URL:https://cygwin.com/key/pubring.asc [1324/1324] -> "pubring.asc" [1]
setup.bz2           100%[===================>]   2.64M  1.62MB/s    in 1.6s
2017-09-30 06:14:55 URL:http://cygwin.mirror.constant.com/x86_64/setup.bz2 [2767026/2767026] -> "setup.bz2" [1]
setup.bz2.sig       100%[===================>]      72  --.-KB/s    in 0s
2017-09-30 06:14:56 URL:http://cygwin.mirror.constant.com/x86_64/setup.bz2.sig [72/72] -> "setup.bz2.sig" [1]
setup.ini           100%[===================>]  10.25M  14.4MB/s    in 0.7s
2017-09-30 06:14:57 URL:http://cygwin.mirror.constant.com/x86_64/setup.ini [10752852/10752852] -> "setup.ini" [1]
setup.ini.sig       100%[===================>]      72  --.-KB/s    in 0s
2017-09-30 06:14:57 URL:http://cygwin.mirror.constant.com/x86_64/setup.ini.sig [72/72] -> "setup.ini.sig" [1]
FINISHED --2017-09-30 06:14:57--
Total wall clock time: 4.0s
Downloaded: 5 files, 13M in 2.3s (5.50 MB/s)
$ gpg --homedir . --import pubring.asc
gpg: WARNING: unsafe permissions on homedir `.'
gpg: keyring `./secring.gpg' created
gpg: keyring `./pubring.gpg' created
gpg: ./trustdb.gpg: trustdb created
gpg: key 676041BA: public key "Cygwin<EMAIL_ADDRESS>imported
gpg: Total number processed: 1
gpg:               imported: 1
$ gpg --homedir . setup.bz2.sig && echo "Good signature" || echo "Bad signature"
gpg: WARNING: unsafe permissions on homedir `.'
gpg: assuming signed data in `setup.bz2'
gpg: Signature made Thu Sep 28 11:43:42 2017 JST using DSA key ID 676041BA
gpg: Good signature from "Cygwin<EMAIL_ADDRESS>gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 1169 DF9F 2273 4F74 3AA5  9232 A9A2 62FF 6760 41BA
Good signature
$ gpg --homedir . setup.ini.sig && echo "Good signature" || echo "Bad signature"
gpg: WARNING: unsafe permissions on homedir `.'
gpg: assuming signed data in `setup.ini'
gpg: Signature made Thu Sep 28 11:43:40 2017 JST using DSA key ID 676041BA
gpg: Good signature from "Cygwin<EMAIL_ADDRESS>gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 1169 DF9F 2273 4F74 3AA5  9232 A9A2 62FF 6760 41BA
Good signature

Currently, it seems to be nice.
When the mirror is under updating, sometimes signature is not synchronized temporary.
But please consider the worst case too.
Bad signature may mean that mirror is cracked.
Thanks.

I have 'Bad signature" each time. But it looks like it's because gpg is broken somehow - executing it has no effect whatsoever, it just exits instantly without any message. Tried the same commands with gpg2 and it works just fine. Reinstalled gpg using setup.exe, same thing. Not sure what this could be caused by.

Did you try my diagnostic commands above?
If the gpg does not work collectly, please try apt-cyg dist-upgrade command.

I did - had "Bad signature" returned for both commands. However, after reinstalling all packages (reinstalling gnupg only didn't help), gnupg started to work again, but installation of packages failed due to permission issue. I suppose this in turn was caused by ACL, so I installed cygwin from start. However, I now have different problem with apt-cyg. I'll create a new issue and close this one.


Crash in Handler_TextDocumentDefinition with NULL working_file

Reproduced with a debug build of aa74ae57.
I'm playing with some toy client code that calls the "textDocument/definition". Under most circumstances, query crashes when it attempts to handle my query. Here's the sequence of input requests:
Content-Length: 256
{"method":"initialize","params":{"processId":26035,"rootUri":"/Users/jpeach/src/mesos.git","initializationOptions":{"cacheDirectory":"/Users/jpeach/src/mesos.git/.cache"},"capabilities":{},"trace":"messages","workspaceFolders":null},"id":0,"jsonrpc":"2.0"}

Content-Length: 183
{"method":"textDocument/definition","params":{"textDocument":{"uri":"/Users/jpeach/src/mesos.git/src/master/master.cpp"},"position":{"line":94,"character":40}},"id":1,"jsonrpc":"2.0"}

Content-Length: 183
{"method":"textDocument/definition","params":{"textDocument":{"uri":"/Users/jpeach/src/mesos.git/src/master/master.cpp"},"position":{"line":94,"character":40}},"id":2,"jsonrpc":"2.0"}

Content-Length: 183
{"method":"textDocument/definition","params":{"textDocument":{"uri":"/Users/jpeach/src/mesos.git/src/master/master.cpp"},"position":{"line":94,"character":40}},"id":3,"jsonrpc":"2.0"}

Content-Length: 191
{"method":"textDocument/definition","params":{"textDocument":{"uri":"file:///Users/jpeach/src/mesos.git/src/master/master.cpp"},"position":{"line":439,"character":10}},"id":4,"jsonrpc":"2.0"}

Request ID 3 succeeds (it's a hard-coded test call), but request ID 4 crashes cquery.
(lldb) bt
* thread #1, name = 'querydb', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x20)
    frame #0: 0x00000001075aaf11 cquery`(anonymous namespace)::Handler_TextDocumentDefinition::Run((anonymous namespace)::In_TextDocumentDefinition*) [inlined] std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::__is_long(this="") const at string:1221
    frame #1: 0x00000001075aaf11 cquery`(anonymous namespace)::Handler_TextDocumentDefinition::Run((anonymous namespace)::In_TextDocumentDefinition*) [inlined] std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::__get_pointer(this="") const at string:1315
    frame #2: 0x00000001075aaf11 cquery`(anonymous namespace)::Handler_TextDocumentDefinition::Run((anonymous namespace)::In_TextDocumentDefinition*) [inlined] std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::data(this="") const at string:1129
    frame #3: 0x00000001075aaf11 cquery`(anonymous namespace)::Handler_TextDocumentDefinition::Run((anonymous namespace)::In_TextDocumentDefinition*) [inlined] std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::operator std::__1::basic_string_view<char, std::__1::char_traits<char> >(this="") const at string:816
  * frame #4: 0x00000001075aaf11 cquery`(anonymous namespace)::Handler_TextDocumentDefinition::Run(this=0x000000010794e508, request=0x00007f9756f09b30)::In_TextDocumentDefinition*) at text_document_definition.cc:121
    frame #5: 0x00000001075a9f84 cquery`BaseMessageHandler<(anonymous namespace)::In_TextDocumentDefinition>::Run(this=0x000000010794e508, message=<unavailable>) at message_handler.h:102
    frame #6: 0x0000000107361185 cquery`QueryDbMainLoop(db=0x00007ffee8976c30, project=0x00007ffee8977498, file_consumer_shared=0x00007ffee8977398, import_manager=0x00007ffee8976e80, status=0x00007ffee8976e70, timestamp_manager=0x00007ffee8976e08, semantic_cache=0x00007ffee8977468, working_files=0x00007ffee8977400, clang_complete=0x00007ffee89770a0, include_complete=0x00007ffee8976f28, global_code_complete_cache=0x00007f974ee00860, non_global_code_complete_cache=0x00007f974ee008f0, signature_cache=0x00007f974ee00980) at command_line.cc:189
    frame #7: 0x00000001073626b8 cquery`RunQueryDbThread(bin_name="/Users/jpeach/upstream/cquery/build/debug/bin/cquery") at command_line.cc:272
    frame #8: 0x00000001073636ca cquery`LanguageServerMain(bin_name="/Users/jpeach/upstream/cquery/build/debug/bin/cquery") at command_line.cc:388
    frame #9: 0x0000000107366869 cquery`main(argc=3, argv=0x00007ffee8979920, env=0x00007ffee8979940) at command_line.cc:515
    frame #10: 0x00007fff740f2015 libdyld.dylib`start + 1

The crash happens because working_file is NULL, and we dereference it here.
(lldb) p working_file
(WorkingFile *) $9 = 0x0000000000000000

I guess that working_file is NULL because working_files is empty:
(lldb) p *working_files
(WorkingFiles) $10 = {
  files = size=0 {}
  files_mutex = {
    __m_ = (__sig =<PHONE_NUMBER>, __opaque = char [56] @ 0x00007f8bfff58a30)
  }
}

I'm not really sure why working_files would be empty depending on the requested position, but it seems like cquery should emit a diagnostic in this case.
Here's the startup log in case that provides any clues:
( uptime  ) [ thread name/id]              file:line  |
(   0.000s) [main thread  ]        loguru.hpp:1887  | arguments: /Users/jpeach/upstream/cquery/build/debug/bin/cquery --log-all-to-stderr --record=/tmp/cquery
(   0.000s) [main thread  ]        loguru.hpp:1890  | Current dir: /Users/jpeach/src/mesos.git
(   0.000s) [main thread  ]        loguru.hpp:1892  | stderr verbosity: 0
(   0.000s) [main thread  ]        loguru.hpp:1893  | -----------------------------------
(   0.002s) [stdin        ]            lsp.cc:25    | RecordPath: client=/Users/jpeach/src/mesos.git, normalized=/Users/jpeach/src/mesos.git
(   0.002s) [querydb      ]     initialize.cc:507   | Init parameters: {"compilationDatabaseCommand":"","compilationDatabaseDirectory":"","cacheDirectory":"/Users/jpeach/src/mesos.git/.cache","cacheFormat":"json","resourceDirectory":"","discoverSystemIncludes":true,"extraClangArguments":[],"progressReportFrequencyMs":500,"emitQueryDbBlocked":false,"showDocumentLinksOnIncludes":true,"codeLens":{"localVariables":true},"completion":{"enableSnippets":true,"detailedLabel":false,"dropOldRequests":true,"filterAndSort":true,"includeMaxPathSize":30,"includeSuffixWhitelist":[".h",".hpp",".hh"],"includeBlacklist":[],"includeWhitelist":[]},"diagnostics":{"blacklist":[],"whitelist":[],"frequencyMs":0,"onParse":true,"onType":true},"highlight":{"blacklist":[],"whitelist":[]},"index":{"attributeMakeCallsToCtor":true,"blacklist":[],"whitelist":[],"comments":2,"enabled":true,"logSkippedPaths":false,"threads":0},"workspaceSymbol":{"maxNum":1000,"sort":true},"xref":{"maxNum":2000},"enableIndexOnDidChange":false}
(   0.002s) [querydb      ]     initialize.cc:512   | [querydb] Initialize in directory /Users/jpeach/src/mesos.git with uri /Users/jpeach/src/mesos.git
(   0.002s) [querydb      ]     initialize.cc:561   | Using -resource-dir=/Users/jpeach/upstream/cquery/build/debug/lib/clang+llvm-6.0.0-x86_64-apple-darwin/lib/clang/6.0.0
(   0.002s) [stdout       ]          timer.cc:35    | [e2e] Running initialize took 0.482ms
>> (   0.003s) [querydb      ]        project.cc:470   | Using .cquery arguments from /Users/jpeach/src/mesos.git/.cquery
(   0.043s) [querydb      ]        project.cc:482   | Using .cquery arguments %clang, %cpp -std=c++11, -working-directory=., -I3rdparty/stout/include, -I3rdparty/libprocess/include, -Iinclude, -Isrc
(   0.057s) [querydb      ]clang_system_include_extractor.cc:76    | Using compiler drivers /Users/jpeach/upstream/cquery/build/debug/bin/cquery-clang, clang++, g++
(   0.059s) [querydb      ]clang_system_include_extractor.cc:88    | Running /Users/jpeach/upstream/cquery/build/debug/bin/cquery-clang -E -x c++ - -v
(   0.060s) [querydb      ]clang_system_include_extractor.cc:93    | Output:
(   0.059s) [querydb      ]        loguru.hpp:1767  | atexit
(   0.060s) [querydb      ]clang_system_include_extractor.cc:88    | Running clang++ -E -x c++ - -v -working-directory=/Users/jpeach/src/mesos.git/
(   0.081s) [querydb      ]clang_system_include_extractor.cc:93    | Output:
Apple LLVM version 9.1.0 (clang-9<IP_ADDRESS>)
Target: x86_64-apple-darwin17.5.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
 "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang" -cc1 -triple x86_64-apple-macosx10.13.0 -Wdeprecated-objc-isa-usage -Werror=deprecated-objc-isa-usage -E -disable-free -disable-llvm-verifier -discard-value-names -main-file-name - -mrelocation-model pic -pic-level 2 -mthread-model posix -mdisable-fp-elim -fno-strict-return -masm-verbose -munwind-tables -target-cpu penryn -target-linker-version 351.8 -v -dwarf-column-info -debugger-tuning=lldb -resource-dir /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/9.1.0 -working-directory /Users/jpeach/src/mesos.git/ -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -I/usr/local/include -stdlib=libc++ -fdeprecated-macro -fdebug-compilation-dir /Users/jpeach/src/mesos.git -ferror-limit 19 -fmessage-length 0 -stack-protector 1 -fblocks -fobjc-runtime=macosx-10.13.0 -fencode-extended-block-signature -fcxx-exceptions -fexceptions -fmax-type-align=16 -fdiagnostics-show-option -o - -x c++ -
clang -cc1 version 9.1.0 (clang-9<IP_ADDRESS>) default target x86_64-apple-darwin17.5.0
ignoring nonexistent directory "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/c++/v1"
ignoring nonexistent directory "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/local/include"
ignoring nonexistent directory "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/Library/Frameworks"
#include "..." search starts here:
#include <...> search starts here:
 /usr/local/include
 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1
 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/9.1.0/include
 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include
 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include
 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks (framework directory)
End of search list.
# 1 "<stdin>"
# 1 "<built-in>" 1
# 1 "<built-in>" 3
# 353 "<built-in>" 3
# 1 "<command line>" 1
# 1 "<built-in>" 2
# 1 "<stdin>" 2
(   0.081s) [querydb      ]        project.cc:161   | Using system include directory flags
  -isystem/usr/local/include
  -isystem/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1
  -isystem/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/9.1.0/include
  -isystem/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include
  -isystem/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include
  -iframework/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks
(   0.081s) [querydb      ]        project.cc:165   | To disable this set the discoverSystemIncludes config option to false.
(   0.149s) [querydb      ]        project.cc:710   | angle_include_dir: /Users/jpeach/src/mesos.git/src/
(   0.149s) [querydb      ]        project.cc:710   | angle_include_dir: /Users/jpeach/src/mesos.git/include/
(   0.149s) [querydb      ]        project.cc:710   | angle_include_dir: /Users/jpeach/src/mesos.git/3rdparty/libprocess/include/
(   0.149s) [querydb      ]        project.cc:710   | angle_include_dir: /Users/jpeach/src/mesos.git/3rdparty/stout/include/
(   0.150s) [querydb      ]          timer.cc:35    | [perf] Loaded compilation entries (592 files) took 147.147097ms
(   0.150s) [querydb      ]     initialize.cc:613   | Starting 6 indexers
...

Thanks, should be fixed in 94a1a5c9d1911e919da3f5ab085fa3b938854505.

@jacobdufault I still reproduce the same crash after this commit:
(lldb) down
frame #4: 0x000000010f738151 cquery`(anonymous namespace)::Handler_TextDocumentDefinition::Run(this=0x000000010fae2758, request=0x00007fdc4441d3a0)::In_TextDocumentDefinition*) at text_document_definition.cc:121
   118 	      if (!has_symbol) {
   119 	        lsPosition position = request->params.position;
   120 	        const std::string& buffer = working_file->buffer_content;
-> 121 	        std::string_view query = LexIdentifierAroundPos(position, buffer);
   122 	        std::string_view short_query = query;
   123 	        {
   124 	          auto pos = query.rfind(':');
(lldb) p working_file
(WorkingFile *) $2 = 0x0000000000000000
(lldb) p *request
((anonymous namespace)::In_TextDocumentDefinition) $4 = {
  RequestInMessage = {
    id = (type = kInt, value = 8)
  }
  params = {
    textDocument = {
      uri = (raw_uri_ = "file:///Users/jpeach/src/mesos.git/src/master/master.cpp")
    }
    position = (line = 40, character = 40)
  }
}
(lldb) p *working_files
(WorkingFiles) $5 = {
  files = size=0 {}
  files_mutex = {
    __m_ = (__sig =<PHONE_NUMBER>, __opaque = char [56] @ 0x00007fc950fbb050)
  }
}

I don't think it is a race condition, since it seems related to the Position I send in the "textDocument/definition" request.
This request is OK:
Content-Length: 192

{"method":"textDocument/definition","params":{"textDocument":{"uri":"file:///Users/jpeach/src/mesos.git/src/master/master.cpp"},"position":{"line":400,"character":40}},"id":12,"jsonrpc":"2.0"}

This request crashes cquery:
Content-Length: 191

{"method":"textDocument/definition","params":{"textDocument":{"uri":"file:///Users/jpeach/src/mesos.git/src/master/master.cpp"},"position":{"line":439,"character":9}},"id":16,"jsonrpc":"2.0"}

Debugged some more. The reason some Positions don't crash is because, has_symbol in Handler_TextDocumentDefinition::Run ends up being true (the Position resolves as a header file). The reason that there are no files in WorkingFiles is that my client code never sends the "textDocument/didOpen" message.

Yea, I think cquery should emit an error if the working file fails to resolve, since it is a client error. Leaving open as a TODO for that

On May 24, 2018, at 8:55 PM, Jacob Dufault<EMAIL_ADDRESS>wrote:
Yea, I think cquery should emit an error if the working file fails to resolve, since it is a client error. Leaving open as a TODO for that

Yes, that behavior makes sense to me. Is this really a client error though? I didn't see anything in the LSP spec that requires a client to sent an open notification for a file that it wants to query.

I suppose you are right, didOpen/didClose is more about where the document content source of truth is.


[BUG][UI/UX] - Drop-down menu does not close when clicked

When clicking on the "Rename", "Duplicate All", "Duplicate Content" tabs, the drop-down menu remains open, which isn't very UX-friendly.
It should close when one of these tabs is clicked, as it does when the "delete" button is clicked.

Fixed!


browser.restart() opens browser one more time then number of test

I have tested by using protractor 3.2 and jasmine 2 with chrome browser having conf file
Conf.js
exports.config = {
seleniumServerJar:'../node_modules/protractor/selenium/selenium-server-standalone-2.53.0.jar',
chromeDriver: '../node_modules/protractor/selenium/chromedriver.exe',
allScriptsTimeout: 150000,
capabilities: {
browserName: 'chrome',
browser_version: '50.0',
},
restartBrowserBetweenTests: true,
framework: 'jasmine2',
specs:['../Specs/Spec.js'],
onPrepare: function() {
    },

jasmineNodeOpts: {
defaultTimeoutInterval: 300000,
onComplete: null,
showColors: true,
includeStackTrace: true,
}
}
when i try to run with spec having 2 it test case then restart browser open browser 3 times instead of 2 times.
Spec.js
describe('Testing', function() {
beforeEach(function() {
browser.get('http://juliemr.github.io/protractor-demo/');
});
fit('should have a title', function() {
expect(browser.getTitle()).toEqual('Super Calculator');
});
  fit('should add one and two', function() {
        element(by.model('first')).sendKeys(1);
        element(by.model('second')).sendKeys(2);
        element(by.id('gobutton')).click();
        expect(element(by.binding('latest')).getText()).
            toEqual('5'); // This is wrong!
      });

});

@Saurabh06 Let me just modify it so that people could understand the issue easily :
following is the config file:
exports.config = {
    directConnect: 'true'
    , allScriptsTimeout: 15000
    , capabilities: {
        browserName: 'chrome'

    }
    , restartBrowserBetweenTests: true
    , framework: 'jasmine2'
    , specs: ['./spec.js']
    , onPrepare: function () {
        browser.ignoreSynchronization = true;
        browser.manage().window().maximize();
    }
    , jasmineNodeOpts: {
        defaultTimeoutInterval: 30000
        , onComplete: null
        , showColors: true
        , includeStackTrace: true
    }
}

and the test spec is as follows :
describe('testing', function () {
    beforeEach(function () {
        browser.get('http://juliemr.github.io/protractor-demo/');
    })

    afterEach(function () {
        browser.close();
    })
    fit('shoould have a title', function () {
        expect(browser.getTitle()).toEqual('Super Calculator');
    });

    fit('shoould add one and two ', function () {
        element(by.model('first')).sendKeys(1);
        element(by.model('second')).sendKeys(2);
        element(by.id('gobutton')).click();

        var el = element(by.binding('latest'));
        expect(el.getText()).toEqual('3');
    });
});

The issue is when the "restartBrowserBetweenTests: true" and the spec.js has 1 describe and 2 it blocks ideally 2 times the browser should be restarted but in this case 3 times the browser is restarted!
I gave it a try and I able to reproduce this issue.
@cnishina @NickTomlin Any thoughts on this? What am I & @Saurabh06 missing here?

So when setting restartBrowserBetweenTests to true, it is calling restart at the end of the test, afterEach, and afterAll. In this case, it should restart the browser after calling afterEach. So if you have a single test, it will restart the regardless if there is an additional test after it.
describe('testing', function () {
  beforeEach(function () {
    console.log('beforeEach: browser.get');
    browser.get('http://juliemr.github.io/protractor-demo/');
  });
  afterEach(function() {
    console.log('afterEach: close browser');
    browser.close();
  });
  it('should have a title', function () {
    console.log('it: should have a title');
    expect(browser.getTitle()).toEqual('Super Calculator');
  });
});

editing runner.js at line 215 (to see when restart occurs):
        browser_.restart = function () {
          console.log('restarting!');
            // Note: because tests are not paused at this point, any async
            // calls here are not guaranteed to complete before the tests resume.
            _this.driverprovider_.quitDriver(browser_.driver);
            // Copy mock modules, but do not navigate to previous URL.
            browser_ = browser_.forkNewDriverInstance(false, true);
            _this.setupGlobals_(browser_);
        };

taking a look at the console output we can see where restart is actually happening:
onPrepare
Started
beforeEach: browser.get
it: should have a title
afterEach: close browser
restarting!

Since the browser is restarting, the afterEach is not needed since it already closes and opens the browser window.
If you are concerned about having this extra browser window restarting, consider the following instead. The following test does not use the restartBrowserBetweenTests in the config and will create a new driver instance from the original. This will launch a new browser window and should have as many browsers opened as you have tests.
describe('testing', function () {
  var firstTest = true;
  beforeEach(function () {
    console.log('beforeEach: browser.get');
    if (firstTest) {
      firstTest = !firstTest;
    } else {
      browser = browser.forkNewDriverInstance();
    }
    browser.get('http://juliemr.github.io/protractor-demo/');
  });
  afterEach(function() {
    console.log('afterEach: close browser');
    browser.close();
  });
  it('should have a title', function () {
    console.log('it: should have a title');
    expect(browser.getTitle()).toEqual('Super Calculator');
  });
  it('shoould add one and two ', function () {
    element(by.model('first')).sendKeys(1);
    element(by.model('second')).sendKeys(2);
    element(by.id('gobutton')).click();

    var el = element(by.binding('latest'));
    expect(el.getText()).toEqual('3');
  });
});

I believe this is as designed and will close this issue.

@cnishina , i am getting below error with changing the 'restartBrowserBetweenTests: true' with browser = browser.forkNewDriverInstance(); inside before each method

browser = browser.forkNewDriverInstance(); i
An error was thrown in an afterAll
AfterAll WebDriverError: no such session
(Driver info: chromedriver=2.29.461585 (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X 10.12.4 x86_64)
any solution ?

any solution for AfterAll WebDriverError: no such session
(Driver info: chromedriver=2.31.488774 (7e15618d1bf16df8bf0ecf2914ed1964a387ba0b),platform=Mac OS X 10.12.4 x86_64)

@poojagadekar89 : Instead of browser.forNewDriverInstance(), use browser.restart and remove browser.close from afterEach block.


Refactor classname splitting from ' ' to /\s+/

To fix this issue: https://discord.com/channels/953974421008293909/1180070470935117884/1180070470935117884

Doesn't this address the same issue?
https://github.com/facebook/lexical/pull/5649

@acywatson Looks like it's the same sort of solution as #5649, feel free to close that one if this approach chosen instead


Giving a minimum green duration.

Hello.
I have another question.
I want to give the traffic lights a minimum green duration.
How can I do it? Can you help me?

This is tricky. 1) the minimum green duration must be a multiple of step size, i.e., control_interval_sec. 2) the easiest way to ensure this is to inset post-RL logic in env:step() https://github.com/cts198859/deeprl_signal_control/blob/c3cadbd088a3f6946ecba667fd07cbd689947d32/envs/env.py#L566. You can use the enforced yellow time logic as reference, basically you need to memorize how many "green" steps have been observed so far.

I understood the explanation for #1.
But I'm not sure how to do #2.
Could you please explain in more detail?

basically you do not restrict what RL learns, instead enforce your constraint when you simulate the step, by adjusting RL decision if it violates the constraint. e.g., RL:GGR->Actual:GGG if you need a minimum green duration of 3 MDP steps.


av_libglesv2.dll and ibSkiaSharp.dll reference an outdayed zlib and libjpeg-turbo

Is your feature request related to a problem? Please describe.
Our security scan complains about two things:

runtimes/win-x64/native/av_libglesv2.dll uses zlib.dll of version 1.2.11, recommended is 1.3.1
runtimes/win-x64/native/libSkiaSharp.dll uses libjpeg-turbo.dll of version 2.1.5, recommended is 3.0.0.
Yes, you do not distribute these dlls :) But the security scan still complains.

Describe the solution you'd like
May I ask you to update av_libglesv2.dll and ibSkiaSharp.dll to the latest versions in one of your upcoming releases? Hopefully, their vendors have already addressed the issues and use the newest zlib and libjpeg-turbo.
Describe alternatives you've considered
No response
Additional context
No response

11.1 beta can be used with SkiaSharp 3, but we can only support it for 12.0 completely due to breaking changes.

SkiaSharp's update of libjpeg-turbo is blocked by a potential upstream bug: https://github.com/mono/SkiaSharp/issues/2667#issuecomment-1883754749 . The comment includes some details and how the vulnerable feature isn't actually part of the SkiaSharp build.
Avalonia does ship its own ANGLE lib which seems to be on zlib 1.2.13. The current main is on <IP_ADDRESS>, so even if it's updated on Avalonia's end, it won't be 1.3.1.


Unable to install manim, manimpango

Console gives me error that "pangocairo >= 1.30.0 is required."
i tried installing pango with "pkg install libpango1.0-dev" in termux and it said "Unable to find a repository with name libpango1.0-dev"

I tried it in Pydroid 3 and didnt work either

How can i download and install libpango1.0-dev from local file?

There was libpangomm-1.4 and libpangomm-2.48
I tried installing them but still pangocairo missing.

tried installing pycairo,
still not fixed

I'm not sure about termux, but Pango along with its development headers is a required dependency. Maybe you can try and compile Pango from source?

I'm not sure about termux, but Pango along with its development headers is a required dependency. Maybe you can try and compile Pango from source?

I may can do it, but how?

How can i download and install libpango1.0-dev from local file?
This would be helpful

I'm not sure about termux, but Pango along with its development headers is a required dependency. Maybe you can try and compile Pango from source?

I may can do it, but how?

Download the source code from https://download.gnome.org/sources/pango/1.51/pango-1.51.0.tar.xz and then extract it. You would need meson and ninja to compile and see https://mesonbuild.com/Quick-guide.html#compiling-a-meson-project on how to.

Since there's no reply, I'll consider this as fixed. Feel free to open a new issue or jump over at Discord to ask for help if you've any other issues.


Simplify code to make URLSession api backward compatible

This PR creates a backward compatible async func in URLSession extension with the same signature to the function in iOS 15. So that making it simpler to clean up code in future.
The code is inspired and borrowed from here: https://www.swiftbysundell.com/articles/making-async-system-apis-backward-compatible/

This is a nice technique — one downside of this technique though is that it prevents iOS 15 and macOS 12 clients from actually using the platform API we are essentially overriding.
Luckily the API signature in question is actually;
public func data(for request: URLRequest, delegate: URLSessionTaskDelegate) async throws -> (Data, URLResponse)

So we can actually provide a very close alternative to achieve what I think is best of both worlds here;
@available(iOS, deprecated: 15.0, message: "Use data(for: URLRequest) directly")
@available(macOS, deprecated: 12.0, message: "Use data(for: URLRequest) directly")
public extension URLSession {

    func data(for request: URLRequest) async throws -> (Data, URLResponse) {
        if #available(macOS 12.0, iOS 15.0, *) {
            return try await data(for: request, delegate: nil)
        }

I thought the compiler is smart enough to automatically call our override function below iOS 15 and call platform function on iOS 15. 😕


DEVEX-404: Part 2 - Removing redundant metrics.

I have discovered that 2 of the 3 exposed metrics here already exist and
are exported by Cluster Version Operator. This PR removes the code need
to export these two metrics and migrates the Alerts to use metrics
provided by the CVO instead.

/assign @dmage @adambkaplan

/test e2e-aws-image-registry

/test e2e-aws-image-registry

/test e2e-aws-operator

/test e2e-aws-upgrade

/test e2e-aws-operator

/lgtm


Create DotSwitch component

This PR adds a simple switch component that is needed for the Price Oracle functionality implementation.

The component has been moved to the Price Oracle PR.


Fixed #32986 -- Removed unneeded str.find() call in Lexer.create_token().

https://code.djangoproject.com/ticket/32986

@cjerdonek Thanks :+1:

I updated the PR. I don't feel strongly about the variable issue, but @pope1ni may, so I went with @felixxm's second option from here to accommodate that, as opposed to keeping it in its original location:

Theoretically yes, we should add a reverse import for backward compatibility, or at least a small release notes.

@cjerdonek Thanks :+1:

Thanks for your help, @felixxm.

Thanks! 🙂


Testing tools for Tekton Pipelines

I'm not exactly sure what this looks like but I wanted to start tracking this here if ppl have ideas.
Basically I think that we should have a great testing story around Tekton Pipelines, e.g.:

People should be able to write "unit tests" for their Tasks and Pipelines (I have no idea what these would actually look like!)
People should be able to have some level of confidence in their Tasks without having to plug them into an entire Pipeline, run them, and observe what happened
People should be able to express what the intent of their Tasks is, and verify it in some way that isn't manual

For inspiration, I really like the way that OPA polices can have tests written for them: https://www.openpolicyagent.org/docs/latest/how-do-i-test-policies/ Unfortunately Tekton Pipelines is totally different b/c it isn't a language (or is it????) and it's mostly side effect driven (the whole point is to execute stuff that causes changes in the state of the world) but I feel confident that if we really spend some time thinking about this we can make something cool!

This is a roadmap item: https://github.com/tektoncd/pipeline/blob/master/roadmap.md
/lifecycle frozen

People should be able to write "unit tests" for their Tasks and Pipelines (I have no idea what these would actually look like!)

Quick passing thought - now that we have both params and results (and also workspaces), we could provide tools / libs to write "tests" that exercise Tasks and Pipelines with certain inputs and check for expected outputs and workspace contents. Maybe not as much of  "unit test" as we'd like but probably a useful test for many cases 🤔
(Also wondering if there might be some overlap with the catalog tiers work @jerop )

It would be great to have some mechanism for testing tasks and pipelines. I think there are two scenarios worth considering:

testing against the task's or pipeline's results, maybe with a CR like TaskRunTest or PipelineRunTest that would take the TaskRun or PipelineRun definition and list of assertions to be tested and at the end indicate whether the assertions are satisfied.
testing tasks outside of tekton. I think having a mechanism that can evaluate a TaskRun and execute task without deploying it into tekton could be useful. Something that will interpolate parameters and run the image and script from each step. Perhaps incorporating some form of tests like bats.

It would be great to have some mechanism for testing tasks and pipelines. I think there are two scenarios worth considering:

testing against the task's or pipeline's results, maybe with a CR like TaskRunTest or PipelineRunTest that would take the TaskRun or PipelineRun definition and list of assertions to be tested and at the end indicate whether the assertions are satisfied.
testing tasks outside of tekton. I think having a mechanism that can evaluate a TaskRun and execute task without deploying it into tekton could be useful. Something that will interpolate parameters and run the image and script from each step. Perhaps incorporating some form of tests like bats.

For (2), something like buildkit-tekton could probably help 👼🏼

This would be really helpful when maintaining a catalog with a lot of Tasks and Pipelines.
It would be great to be able to actually test the following scenarios in isolation (without a cluster):

Tasks:

interpolated variables coming from params (which could be optional/required)
order of steps
produces results
general task validation

Pipelines:

order of tasks execution (sync/parallel/chained)
tasks are configured properly respecting required/optional params
all params referred in the task configurations are actually declared in the pipeline's spec-params section
workspaces required by the tasks are actually declared in the pipeline
general pipeline validation

I'm a bit puzzled whether this would be "configuration testing" or not but, something like this would really help automating checks/validations when maintaining a huge catalog of tasks/pipelines.
Also, we had a look at https://github.com/tektoncd/catlin and it might cover what I described above (not sure if that's what you are planning to do with that tool or if you'd like to enhance the testing tools separately).


Automatically add module name to 'tags' list of an operation

Expected behavior
Operations should have a tag that is the same as it's module name. E.g. 'correlation' for all operations in the correlation.py module.
See also #280
Actual behavior
When @op() is invoked, module name gets added to the tags list automatically. Only additional tags should be added by hand as required.
Specifications
Cate 0.9.0dev3

Deprecated idea


Thank you for adding the HAT-S code

Thank you for adding HAT-S, I was able to finetune my own HAT-S and HAT-L model :)
Examples can be seen here:
https://imgsli.com/MTg5MDY3
https://imgsli.com/MTg5MDYy
https://imgsli.com/MTg5MDY1
The HAT-S model files (pth and its 16fp onnx conversion) and the used training info (otf jpg compression and blur) can be found in my repo in this 4xNomos8kSCHAT-S folder. Just wanted to show these HAT models I recently trained/finetuned with your arch :)

@Phhofm Very nice work！


add unit test for stopping unwanted files

Unit test checks for files such as .DS_Store, .pyc etc.

Found this issue exciting and easy to fix. Raised PR #105 for this.


chore: Make kedro-datasets open-bound

Description

Add open-bound to kedro-datasets to unblock work on adding python 3.11 support to kedro-datasets, https://github.com/kedro-org/kedro-plugins/pull/297.
Development notes

Checklist

[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added a description of this change in the relevant RELEASE.md file
[ ] Added tests to cover my changes

Why do we need a separate PR to remove the bound? Can we do it in the same PR.

Why do we need a separate PR to remove the bound? Can we do it in the same PR.

It initially looked like the dependencies were failing because of the open-bound not being committed this has since been fixed in the PR so will close this.


FBX model exporting support

As we move toward supporting bone and animation exporting, being able to export to FBX is required.

In my opinion, I feel like we should go with COLLADA instead.
FBX is a proprietary Autodesk format and the use of FBX SDK would be required for binary format export. Its also only available in C++ or Python. I discussed with Marlamin previously about implementing FBX support with the old export tools based on C#, and he deemed the implementation of it through the FBX SDK too hacky.
Yes, it is possible to export FBX files in ASCII format, but that will break compatibility with Blender, as it cannot import ASCII FBX files and is the FBX SDK equivalent of version 7.4.0 (Current FBX SDK version is 2020),
COLLADA on the other hand is XML based, is widely supported due of the ISO/PAS 17506:2012 standard and would be easier to implement due of it being in ASCII/XML format.
Only issue is that 3DS Max/Maya users will most likely have to rely on the official plugins, as Autodesk is using its own implementation of COLLADA called FBX COLLADA, which breaks some stuff, so a notice would have to be put somewhere for Maya/3DS Max users to recommend them to use the plugin from KhronosGroup:
https://github.com/KhronosGroup/OpenCOLLADA

Maybe both are redundant to implement since GLTF is planned as a universal export format?

GLTF is too new of a format and currently only Blender supports import/export of GLTF with the official KhronosGroup plugin.
Autodesk/Maya/Motionbuilder has zero GLTF support and Cinema4D only supports GLTF as an experimental exporter. There are also no third-party plugins that allow import or export of GLTF.
The specific format needs to be picked correctly to keep compatibility with most tools, and going with GLTF would definitely break compatibility with other tools than Blender.

COLLADA may be an option going forward, however FBX is off the table due to the complexity of it. The development of it was already scrapped in favor of GLTF, so this issue will be closed.
The current goal is to get GLTF support finished, which is currently blocked by an issue with armature origin points that I haven't had the time to debug yet. Once GLTF support is done, thus giving us internal armature support, COLLADA seems like the logical next step, and given the modular structure of wow.export should be trivial to implement at that point.

FBX is a proprietary Autodesk format and the use of FBX SDK would be required for binary format export. Its also only available in C++ or Python. I discussed with Marlamin previously about implementing FBX support with the old export tools based on C#, and he deemed the implementation of it through the FBX SDK too hacky.

Also, to follow this up, using the FBX SDK is not the only approach available and was not the road-block that removed FBX support for us. The FBX branch on this repository has most of the FBX format implemented as a binary container without any SDK inclusion.
FBX was just scrapped because it's a crud format and in the end it was decided to support something more modern.


Replace home-grown create_dir_all with std::fs::create_dir_all

The old one is just the historical artifact, right?

@bors: r+
Correct!

:pushpin: Commit 5d0ce40 has been approved by alexcrichton

:hourglass: Testing commit 5d0ce40deb43a12aa15814ad6c92bf6f391cf1aa with merge 9bd7134fc5972d8582165ab8e3a6e7d685fc5cc4...


Wrap error

Codecov Report

Merging #1231 (f38a2e6) into master (e21e6eb) will decrease coverage by 8.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1231      +/-   ##
==========================================
- Coverage   36.92%   28.31%   -8.62%
==========================================
  Files         422      228     -194
  Lines        9795     6601    -3194
  Branches     1665     1283     -382
==========================================
- Hits         3617     1869    -1748
+ Misses       6165     4528    -1637
- Partials       13      204     +191

Impacted Files
Coverage Δ

src/index.ts
78.72% <0.00%> (-21.28%)
:arrow_down:

src/transaction/CreateTx/ToField/ToField.tsx
61.70% <0.00%> (-11.99%)
:arrow_down:

src/transactions/TxDetails/TxDetails.tsx
57.73% <0.00%> (-3.52%)
:arrow_down:

src/create-wallet/flow/createWalletFlow.ts
82.06% <0.00%> (-0.48%)
:arrow_down:

src/Asset.ts
38.88% <0.00%> (ø)

src/ethrpc.ts
0.00% <0.00%> (ø)

src/decoder.ts
82.66% <0.00%> (ø)

src/main/index.ts
0.00% <0.00%> (ø)

src/ChainListener.ts
0.00% <0.00%> (ø)

src/ServerConnect.ts
0.00% <0.00%> (ø)

... and 258 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fix #define_method with blocks converted from a Method

Blocks created from a method object (using #to_proc or the ampersand) do behave different than normal blocks passed to #define_method. When calling the newly defined method the "self" object should be the "self" object of the block rather than the current "self" object.
For example:
class MethodHolder
  class << self
    define_method(:new, &String.method(:new))
  end
end

p MethodHolder.new.class

This should not invoke the "new"-Method on the MethodHolder class but on the String class.
Closes #718

Yay!! 🎉


Script to collect the corresponding source is missing from the build

It would make sense to be able to build a source archive instead of only dealing with binaries.
It does not instill confidence to have an open source project without source code handy.

I think it's because they are using the prebuilt binaryies from Elastic. It just makes things easier, why rebuild the source?

I think it's because they are using the prebuilt binaryies from Elastic. It just makes things easier, why rebuild the source?

There are people who think this is important, for example the "reproducible builds" project.

As folks on the thread stated, Open Distro uses upstream binaries and the build scripts reflect that. You can build Open Distro plugins from source. For e.g. you can build the security plugin from source following these steps https://github.com/opendistro-for-elasticsearch/security-parent/blob/master/README.md Please feel free to enhance the current scripts. :-)


Dynex executables do not work on macos

My issue was closed as completed but it definitely was not.
I have boost installed but the packages the executable looks for have "-x64" appended to them. Brew does not install those packages. If I simply erase the "-x64" at the end of the packages so they match what brew installs then the output I get is "zsh: killed          sudo ./dynexd"

Which OS exactly are you using? Maybe M1 or M2? In this case you need to build on Rosetta

I tried on both an M1 running 12.6.3 and an intel i7 running macos 12.6.6

While the binaries don't work building from source does... kinda. I say kinda because of another issue I will open. However, building on source according to the instructions in the readme does the trick on an intel macbook. It fails on an M1 because of a clang error (The clang compiler does not support -march=native) and I'm not sure how to go in and fix this in the source code

While the binaries don't work building from source does... kinda. I say kinda because of another issue I will open. However, building on source according to the instructions in the readme does the trick on an intel macbook. It fails on an M1 because of a clang error (The clang compiler does not support -march=native) and I'm not sure how to go in and fix this in the source code


DoubleTap processing in sw

for #25 implementation need to change in interrupt processing

v1.7 realize functional

v1.7 realize functional


Add articleTypes URL param without UI

This PR adds a URL param, articleTypes, to rumors-site article list.

Currently we do not officially launch image support, so the UI of this filter is not implemented yet.

Users must manually specify articleTypes in URL, it is not accessible from UI.

articleTypes should be a comma separated list of ArticleTypeEnum (TEXT, IMAGE, VIDEO, AUDIO).
When not given, articleTypes is not specified in ListArticles.
If given, articleTypes is specified and thus would override MEDIA_ARTICLE_SUPPORT flag in rumors-api.

Screenshot
Only images

Only text

Not specified
The result depends on if the API has turned on MEDIA_ARTICLE_SUPPORT flag. On staging it is turned on, so it does not limit the article type to just text.

Coverage remained the same at 75.831% when pulling e0130121d06d74d2a5bf7c4bcc9667fad9048c93 on article-type into 1808d09f411c313454f4214748a9c2dba0627225 on master.


feat(auth): Add basic auth to the proto

This adds basic auth to secure the project before launch

:tada: This PR is included in version 1.1.0-rc.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix preview by id

When previewing documents by ID the locale is not being set.
(Fixes problem with promotion cards preview)

LGTM!

@meols can you test this on dev environment? =)

@meols can you test this on dev environment?

@fernandolucchesi - if the Norwegian versions of the promoted pages should show automatically in preview after duplicating to Norwegian without relinking to the Norwegian pages, I don't see them on the Norwegian page. Tested on this page.

@fernandolucchesi - if the Norwegian versions of the promoted pages should show automatically in the preview after duplicating to Norwegian without relinking to the Norwegian pages, I don't see them on the Norwegian page. Tested on this page.

When you asked during the meeting I misunderstood you. It should not show it in Norwegian because these are direct links to english pages:

This issues fixes this: https://equinor.slack.com/archives/C01MU3H6G0Y/p1669213390059189
It is currently happening for unpublished topic content and events


Introduce our variation of the fabric8 client Use Spring event publishing

rebased and merged via https://github.com/markfisher/sk8s/commit/5a5ffd29c8b5965f10cf42063621d2066ab54cb6


Enable-WriteCore-feature-for-machinelearningcompute

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.MachineLearningCompute


feat: bump version

Description:

Related issue(s):
Fixes #351
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.96%. Comparing base (ec0edf9) to head (2aed80d).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #856   +/-   ##
=======================================
  Coverage   62.96%   62.96%
=======================================
  Files          30       30
  Lines        1234     1234
  Branches      149      149
=======================================
  Hits          777      777
  Misses        436      436
  Partials       21       21

----
🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles


Background transparency can't be enabled

With the theme being installed, I don't know how to enable background transparency. Without the theme, transparency works well in both Konsole and Yakuake under Manjaro Linux, with and without tmux.
I have the following in my .tmux.conf (for true colour):
set-option -ga terminal-overrides ",xterm-256color:Tc"

@maxigaz Did you solve the issue? Would you care to share how to keep the background transparency?

@Shaxine I've just tackled this issue again, and finally I got some results!
I believe the problem is that the theme sets the whole background colour as completely solid, overriding the background setting of the terminal emulator.
So, the only solution that seems to be working for me is open ~/.tmux/plugins/tmux-onedark-theme/tmux-onedark-theme.tmux, find the lines with bg and #282c34 (the background colour set by the theme) in them, and replace the latter with the word default.
It takes some trial and error to see where #282c34 should and shouldn't be replaced for the desired effect. (I don't recommend overriding the variable onedark_black because it makes some messages illegible and powerline characters look funny.)
In addition, you may also want to set #282c34 as a background colour inside your terminal emulator settings unless the current one suits you. (I haven't tried it yet with Konsole.)
I'll finish making my own modifications later and maybe create a fork specifically for transparent background.

I've put in a pull request to fix this properly, but for now, you can work around the problem by putting this after at the end of tmux.conf:
# Just to show that the two new lines come after these:
set -g @plugin 'odedlaz/tmux-onedark-theme'
run '~/.tmux/plugins/tpm/tpm'

# These make tmux transparent again
set -g "window-style" "bg=default"
set -g "window-active-style" "bg=default"

I'm not sure why this was closed. What I can say is that while the above Konsole colorscheme was reported to maintain transparency with this theme, it did not do so after I used the following script to convert it to Alacritty:
https://github.com/jwilm/alacritty/issues/1093
There is no Alacritty color scheme that maintains transparency when used with this theme. Nor, at present, would I expect there to be.

I've just tried using the code you shared above, @duganchen (putting it at the bottom of .tmux.conf). It does enable background transparency in multiple Konsole themes, indeed.
I've also noticed that it has an effect on the text colour as well, following whatever is set in Konsole instead of what's in the tmux theme. (Weird, since you only defined the background here.)

That's interesting. Try this:
set -g "window-style" "fg=#5c6370,bg=default"
set -g "window-active-style" "fg=#aab2bf,bg=default"

That's what's in the pull request.

That works. Thank you!

This is how it looks like without the workaround:

Still doesn't work perfectly I still need the following lines set after run '~/.tmux/plugins/tpm/tpm'
set -g "window-style" "fg=#5c6370,bg=default"
set -g "window-active-style" "fg=#aab2bf,bg=default"

After those lines are set, this is now how it looks, which is what I want:

It seems like the theme is greying things out a little bit by default😕


Crash: Rendering screen

Name
Version

Minecraft
1.20.1

Minecraft Forge
47.3.12

Shield Expansion
1.1.7a

Crash Reports:
crash-2024-12-06_23.52.21-client.txt
crash-2024-12-06_23.54.22-client.txt
crash-2024-12-06_23.55.33-client.txt
For context, I'm playing on a server and it seems that I crash whenever entering a gui with a damaged shield on my hotbar - unsure whether the shield is broken somehow due to me taking it out of a Refined Storage system.
Offending code seems to be https://github.com/infernalstudios/Shield-Expansion/blob/029922574e272de62289198ff7752af4bf353adc/src/main/java/org/infernalstudios/shieldexp/events/ShieldExpansionEvents.java#L244-L247
So I'm assuming either SHIELD_STATS.get(key) or SHIELD_STATS.get("shieldexp:default") is returning null(?)

Fixed by #49


Support RxJava 2.0

See: https://github.com/ReactiveX/RxJava/wiki/What's-different-in-2.0

Similar to the main Rx naming convention, there should probably be an "rxrapidapi2" artifact.  This means the overall project needs to restructure slightly -

[ ] Support plain RxJava 1.1.6 (submodule: rxjava)
[ ] Support plain RxJava 2.0 (submodule: rxjava2)
[ ] Support plain RxAndroid / RxJava 1.1.6 (submodule: rxandroid)

Note: the main Readme needs to change to reflect these changes.


Fix Lint/ElseLayout when using multi-branch statements

Expected behavior
With the latest release of Rubocop, I'm noticing a behavioral change that I think is a bug or at least an oddity. This issue is related to this original issue. If I understand the intent of the original issue, I think it was intended for single if and else statement -- which makes sense -- but I think this breaks when used in an if..elsif..else statement?
Actual behavior
I'm seeing Lint/ElseLayout issues with single line else in a if statement that didn't get flagged before the change in the latest release. Below is the full output:

Debug Trace
For /Users/bkuhlmann/Engineering/OSS/git-lint: configuration from /Users/bkuhlmann/Engineering/OSS/git-lint/.rubocop.yml
configuration from /Users/bkuhlmann/Engineering/OSS/git-lint/.rubocop-https---raw-githubusercontent-com-bkuhlmann-code-quality-main-configurations-rubocop-ruby-yml
Default configuration from /Users/bkuhlmann/.cache/frum/versions/3.0.2/lib/ruby/gems/3.0.0/gems/rubocop-1.22.0/config/default.yml
configuration from /Users/bkuhlmann/Engineering/OSS/git-lint/.rubocop-https---raw-githubusercontent-com-bkuhlmann-code-quality-main-configurations-rubocop-rake-yml
configuration from /Users/bkuhlmann/.cache/frum/versions/3.0.2/lib/ruby/gems/3.0.0/gems/rubocop-rake-0.6.0/config/default.yml
configuration from /Users/bkuhlmann/.cache/frum/versions/3.0.2/lib/ruby/gems/3.0.0/gems/rubocop-rake-0.6.0/config/default.yml
configuration from /Users/bkuhlmann/Engineering/OSS/git-lint/.rubocop-https---raw-githubusercontent-com-bkuhlmann-code-quality-main-configurations-rubocop-performance-yml
configuration from /Users/bkuhlmann/.cache/frum/versions/3.0.2/lib/ruby/gems/3.0.0/gems/rubocop-performance-1.11.5/config/default.yml
configuration from /Users/bkuhlmann/.cache/frum/versions/3.0.2/lib/ruby/gems/3.0.0/gems/rubocop-performance-1.11.5/config/default.yml
configuration from /Users/bkuhlmann/Engineering/OSS/git-lint/.rubocop-https---raw-githubusercontent-com-bkuhlmann-code-quality-main-configurations-rubocop-rspec-yml
configuration from /Users/bkuhlmann/.cache/frum/versions/3.0.2/lib/ruby/gems/3.0.0/gems/rubocop-rspec-2.5.0/config/default.yml
configuration from /Users/bkuhlmann/.cache/frum/versions/3.0.2/lib/ruby/gems/3.0.0/gems/rubocop-rspec-2.5.0/config/default.yml
Running parallel inspection
For /Users/bkuhlmann/Engineering/Misc: configuration from /Users/bkuhlmann/.config/rubocop/config.yml
configuration from /Users/bkuhlmann/.config/rubocop/.rubocop-https---raw-githubusercontent-com-bkuhlmann-code-quality-main-configurations-rubocop-ruby-yml
configuration from /Users/bkuhlmann/.config/rubocop/.rubocop-https---raw-githubusercontent-com-bkuhlmann-code-quality-main-configurations-rubocop-rake-yml
configuration from /Users/bkuhlmann/.config/rubocop/.rubocop-https---raw-githubusercontent-com-bkuhlmann-code-quality-main-configurations-rubocop-performance-yml
configuration from /Users/bkuhlmann/.config/rubocop/.rubocop-https---raw-githubusercontent-com-bkuhlmann-code-quality-main-configurations-rubocop-rspec-yml
Loading cache from /Users/bkuhlmann/.cache/rubocop_cache/7cd34d310cda33d35ab370b487ae14bb76d5a73e/132c4e53bc39cc09f7d3f2461c2f48ebce8751d3/ac0019aa6070aba42163cf1bca85c5ed3bf19db3
Inspecting 1 file
Scanning /Users/bkuhlmann/Engineering/Misc/snippet.rb
For /Users/bkuhlmann/Engineering/Misc: configuration from /Users/bkuhlmann/.config/rubocop/config.yml
configuration from /Users/bkuhlmann/.config/rubocop/.rubocop-https---raw-githubusercontent-com-bkuhlmann-code-quality-main-configurations-rubocop-ruby-yml
configuration from /Users/bkuhlmann/.config/rubocop/.rubocop-https---raw-githubusercontent-com-bkuhlmann-code-quality-main-configurations-rubocop-rake-yml
configuration from /Users/bkuhlmann/.config/rubocop/.rubocop-https---raw-githubusercontent-com-bkuhlmann-code-quality-main-configurations-rubocop-performance-yml
configuration from /Users/bkuhlmann/.config/rubocop/.rubocop-https---raw-githubusercontent-com-bkuhlmann-code-quality-main-configurations-rubocop-rspec-yml
Loading cache from /Users/bkuhlmann/.cache/rubocop_cache/7cd34d310cda33d35ab370b487ae14bb76d5a73e/132c4e53bc39cc09f7d3f2461c2f48ebce8751d3/ac0019aa6070aba42163cf1bca85c5ed3bf19db3
W

Offenses:

/Users/bkuhlmann/Engineering/Misc/snippet.rb:21:1: C: [Correctable] Style/CaseLikeIf: Convert if-elsif to case-when. (https://rubystyle.guide#case-vs-if-else)
if number == 1 then puts "One" ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/Users/bkuhlmann/Engineering/Misc/snippet.rb:23:6: W: [Correctable] Lint/ElseLayout: Odd else layout detected. Did you mean to use elsif?
else "Unknown."
     ^^^^^^^^^^

1 file inspected, 2 offenses detected, 2 offenses auto-correctable
Finished in 0.22139099997002631 seconds

You can ignore the Style/CaseLikeIf issue as that's legit because I'm using a case statement for comparison purposes below.
Steps to reproduce the problem
Throw the following in snippet.rb and run Rubocop against it:
number = 1

case number
  when 1 then puts "One"
  when 2 then puts "Two"
  else "Unknown"
end

if number == 1 then puts "One"
elsif number == 2 then puts "Two"
else "Unknown"
end

The above code is silly but notice how the else in the case and if statements used to be allowed. However, with the latest version, you now have to write the if statement like this to fix the Lint/ElseLayout issue:
if number == 1 then puts "One"
elsif number == 2 then puts "Two"
else
  "Unknown"
end

This seems wrong to me because it's not consisent with case statements but, more importantly, if you have simple statements above the else all on one line, why can't else be a one liner as well in order to maintain symmetry?
RuboCop version
rubocop -V

1.22.0 (using Parser <IP_ADDRESS>, rubocop-ast 1.12.0, running on ruby 3.0.2 arm64-darwin20.5.0)
  - rubocop-performance 1.11.5
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.5.0

Thank you, this is a really well reasoned issue.
You are absolutely right, the inline style is going to be affected by this change, and it may in fact be the missing reason that else was explicitly ignored as I mentioned in the PR. That being said we now have a conundrum because we can't both flag this and not flag this at the same time, and it speaks to my confusion about this being a Lint cop vs a Layout cop.
As a Lint cop, it is consistent for else foo on a single line to be flagged, because it's plausible that it was in fact supposed to be an elsif instead. But for layout, your original code is also consistent.
I have a few thoughts that I need to think further on:

Occam's razor would suggest that Lint/ElseLayout is not a useful cop for codebases that predominately use a compact if style as you have demonstrated, so maybe just outright disabling the cop in your case is the easiest solution.
We could perhaps add a special case for else when the previous branches are all on a single line, or if all the other branches use then. This probably has some brittleness to it that would lead to more issues.
Similarly, maybe there could be a special case when the else "body" is a literal, but even that is probably a factor of simplification for this issue, given that the other branches call puts and your else probably would as well in reality.

:bow: Daniel. Ha, yeah, it is definitely confusing that layout is in the Lint/ElseLayout name. 🙃 A couple notes in reply (same sequence):

Yeah, I think I'm going to disable as a workaround. I can't seem to find much harm in doing that so seems fine.
Yeah, I'd like that a lot. So use compact style (i.e. multiple one-line then's) or switch to indented style (making up words here) when no thens are used. ...or even supported a mixed layout (more on that below).
So this one is a bit odd to me. I'm not sure if I see or understand the distinction between literal and command. In my mind it's either compact, indented, or possibly a mixed layout.

There is one other situation that might be worth pointing out. Take this mixed layout scenerio, for example (again, ignore the silly logic, just focus on the layout):
if number == 1 then puts "One"
elsif number == 2
  puts "Pellentque morbi-trist sentus et netus et malesuada fames ac turpis egestas."
else "Unknown"
end

Notice that the second logic branch needs to be indented because it's too long (assumption being that the line limit cop would flag this otherwise so you switch to indented style for this branch). Granted, and depending on the situation, if you had more complex logic you might extract a private method to be called for the second branch logic rather than make the whole condition itself bloated but sometimes there is value in have a mixed layout too, I think.
I think the above mixed layout scenerio is fine? Maybe? ...or would there need to be a configuration for indented, compact, mixed?

Lint cops almost never have configurable styles, because lints aren't generally meant to be configurable obviously. The configuration comes from whether you agree with the lint (keep the cop enabled) or disagree with the lint (disable it), although in general lints should be pretty universal. So I don't think we should be adding configuration to this cop to handle multiple styles (which as you have documented, has the potential to get into complex edge cases).
Maybe the best solution would be to revert Lint/ElseLayout to the previous version, because it is a more concrete issue when the else has multiple lines but one of them are on the same line as the keyword (this "should not" be an intentional style, but of course there's probably a codebase out there that does this on purpose...). Then we can perhaps introduce a new Layout cop to check for consistent if...else styling, or a Style cop to require or forbid then with if (which I'm surprised doesn't exist yet) for style consistency. I haven't landed on anything yet.
@bbatsov any thoughts?

Hi everyone, here with the same oddity

if number == 1 then puts "One"
elsif number == 2
  puts "Pellentque morbi-trist sentus et netus et malesuada fames ac turpis egestas."
else "Unknown"
end

I'm also getting Rubocop warnings regarding snippets like those, which... IMHO, seem perfectly fine (i.e. else being a one liner as the better layout approach).
Looking forward to see how this develops.
Cheers!

@cetinajero I get that this isn't real code, but there are three different styles in that if... 😄

That's true @dvandersluis!
As you mentioned, "... a new layout cop to check for consistent if...else styling..." sounds pretty good to enforce the preferred style!

:information_source: Closing this issue as I've verified this is fixed in Rubocop 1.24.0 by running Rubocop 124.0 against 30+ projects which use the one-line else style. I'm not exactly sure what changed but glad to see this is working again. Thanks all!

Apologies, everyone. I was able to prove this still occurs.
I believe the reason I didn't detect this sooner was due to running Rubocop against some projects which hadn't cleared their local Rubocop cache which initially gave me a false positive.

+1. Was just about to post the very same thing. What is the status on this one?
def cop
  _ =
    case foo
    when true then 'bar'
    else 'baz'
    end

  _ =
    if foo then 'bar'
    # elsif ...
    # elsif ...
    else 'baz' # Lint/ElseLayout
    end
end


Consider breaking to separate repos

While this isn't ideal for people finding the different styles (though this repo could be a guide to other styles instead), splitting into separate repos allows for the styles to support Vale server better, and for users to add individual styles as submodules to their projects.

@ChrisChinchilla I'm willing to assist with this if there's any good way to help?

Thanks! @dylan-k ! It's relatively easy, I'll create the repos, and then assign some tasks to you? Then there'll be some post-tasks…

That sounds great.

Note, for history preserving, I found this worked - https://medium.com/@ayushya/move-directory-from-one-repository-to-another-preserving-git-history-d210fa049d4b

@ChrisChinchilla there may be an additional way for, as you said "people finding the different styles." Vale's creators maintain a collection of styles and have mentioned in the docs: "Have a style you'd like to see implemented? Let us know! We're actively looking to expand our library of pre-made, open-source styles."
The requirements for inclusion seem pretty straightforward. "All styles in this library must (1) be maintained in their own (dedicated) repository, (2) publish releases following Semantic Versioning, and (3) include a meta.json ..."

Yup, exactly @dylan-k that's what we're working towards, and why we're separating them out first, then the next steps.

All styles in this library must (1) be maintained in their own (dedicated) repository

Being the first main requirement. I'll recap what we've both done and what still needs to be done asap, first week back at work…

@ChrisChinchilla The styles you made repos for, a while ago, have all been moved over. Did you want to move any of the others as well?

@dylan-k Yes I will, I get sporadic gaps of free time to work on things, I did all these during FOSSDEM ;)
I will also go through everything to create some tasks for the next steps, just testing the process with one or two repos first.


Canceling with multiple seeders doesn't work

Repro steps:

Run multiple leecher test locally.
Cancel one of the leechers part way through the download.
Observe existing channels finish, but new channels open up.

I am currently observing the following.

When the leecher hits cancel, there is 1 downloading wire with a payment channel and 4 downloading wires without a payment channel.
1 payment channel gets closed on cancel
for each of the other 4 a payment channel is created after cancel.

It doesn't seem like this line is ever called: https://github.com/statechannels/monorepo/blob/master/packages/web3torrent/src/library/web3torrent-lib.ts#L160

Also, doesn't seem like this line is ever called on cancel: https://github.com/statechannels/monorepo/blob/master/packages/web3torrent/src/library/web3torrent-lib.ts#L571

Take aways from today:

Promise returned in closeChannel in payment-channel-client never completed due to unsubscribe was throwing an error. I am not sure why the error is thrown. This issue is fixed in 08a438968.
As that promise was never completing, torrent.destroy was never called in web3torrent-lib cancel function.
Even with 08a438968, when the leecher cancels in the multiple leecher/seeder test, the cancel behavior seems broken.

Here's what I think might be going on:
https://github.com/statechannels/monorepo/blob/dd64cc2f0ccfb1193ae0e64fadd8121dfa054bc5/packages/web3torrent/src/library/web3torrent-lib.ts#L158-L173
Here we use pause to stop the torrent. Pause prevents the torrent from connecting to new incoming or outgoing peers:
https://github.com/webtorrent/webtorrent/blob/7ff77c3e95b2dddfa70dd49cf924073383dd565a/lib/torrent.js#L772-L776
However, it doesn't stop you downloading from a peer that you're already uploading to. So you could end up opening a new channel to download from someone you already have a connection with. (Which is what I witnessed in the multiple seeder test.)

Closing in favor of https://github.com/statechannels/monorepo/issues/2227


Fix for new BoneLib

New bonelib has different menu creation methods
Tested and works 👍

sweet, thanks
will update the thunderstore build too