@ID tag for each @Router

Is your feature request related to a problem? Please describe.
When there's a controller which handles two path/routes, it would be nice to specify an ID for each route.
// @ID get-user-me
// @Router /users/me [get]
// @ID get-user-param
// @Router /users/{param} [get]

Currently, an expected error arises:
duplicated @id annotation 'get-user-info' found in 'GET /users/1', previously declared in: 'GET /users/me'
Describe the solution you'd like
A possible annotation is seen above or perhaps more cleanly:
// @Router get-user-me /users/me [get]
// @Router get-user-param /users/{param} [get]

With ID optionally provided for backward compatibility.
Describe alternatives you've considered

Don't specify @ID, which works without error but for a route like /api/compat/v1/{param}/..., the autogenerated id can become quite messy
Duplicate the annotations

Additional context
N/A

It's not possible to describe 2 endpoints as you did in the example above.
On the other hand, your proposal conflicts with OAS 2 specs and the implementation allready done here #865.
operationId
Each operation may specify a unique operationId. Some code generators use this value to name the corresponding

It's not possible to describe 2 endpoints as you did in the example above.
On the other hand, your proposal conflicts with OAS 2 specs and the implementation allready done here #865.
operationId
Each operation may specify a unique operationId. Some code generators use this value to name the corresponding

Thanks for the quick response.
Currently, with the following example:
// GetStringByInt example
// @Summary Add a new pet to the store
// @Router /users/me [get]
// @Router /users/1 [get]
func GetStringByInt(w http.ResponseWriter, r *http.Request) {
	// write your code
}

swag produces:
info:
  contact: {}
  description: This is a sample server Petstore server.
  title: Swagger Example API
  version: "1.0"
paths:
  /users/1:
    get:
      responses: {}
      summary: Add a new pet to the store
  /users/me:
    get:
      responses: {}
      summary: Add a new pet to the store
swagger: "2.0"

This double @Router functionality can be found in the README.
Since swag produces 2 operations in the yaml/json, I believe there will be no conflict with the OpenID specifications or #865 in assigning an unique ID to each route/operation. e.g.:

info:
contact: {}
description: This is a sample server Petstore server.
title: Swagger Example API
version: "1.0"
paths:
/users/1:
get:
operationId: get-user-param
responses: {}
summary: Add a new pet to the store
/users/me:
get:
operationId: get-user-me
responses: {}
summary: Add a new pet to the store
swagger: "2.0"

Thanks for the quick response.
Currently, with the following example:
// GetStringByInt example
// @Summary Add a new pet to the store
// @Router /users/me [get]
// @Router /users/1 [get]
func GetStringByInt(w http.ResponseWriter, r *http.Request) {
	// write your code
}

swag produces:
info:
  contact: {}
  description: This is a sample server Petstore server.
  title: Swagger Example API
  version: "1.0"
paths:
  /users/1:
    get:
      responses: {}
      summary: Add a new pet to the store
  /users/me:
    get:
      responses: {}
      summary: Add a new pet to the store
swagger: "2.0"

This double @Router functionality can be found in the README.
Since swag produces 2 operations in the yaml/json, I believe there will be no conflict with the OpenID specifications or #865 in assigning an unique ID to each route/operation. e.g.:

info:
contact: {}
description: This is a sample server Petstore server.
title: Swagger Example API
version: "1.0"
paths:
/users/1:
get:
operationId: get-user-param
responses: {}
summary: Add a new pet to the store
/users/me:
get:
operationId: get-user-me
responses: {}
summary: Add a new pet to the store
swagger: "2.0"

Your last example is simple, and it can be reduced to :
// @Router /users/{id} [get]

Let's take the following example, which is complete CRUD:
// @Param        id   path      int  true  "User ID"
// @Param   user   body model.User true  "Some ID"
// @Success      200  {object}  model.User
// @Failure      400  {object}  httputil.HTTPError
// @Router /users [get]
// @Router /users [post]
// @Router /users/{id} [get]
// @Router /users/{id} [put]
// @Router /users/{id} [Delete]

Now, please answer the following questions, and if you think it's still a good idea, let us know.

on which routes the user param is required?
on which routes the about param id required
can you "assume" the delete method will return a user.Model response?
what if the routes are not related to the same entities (model.User, model.Account, model.Roles) ?

I hope this will make clear enough why we are avoiding this shortcuts.
Thanks
Bogdan

Similar request: #797

@ubogdan Many thanks for looking into my use case in detail.
Unfortunately, I wrote that example as a minimal way to explain this issue, but it didn't communicate across the point that it's not possible to merge the params.
In reality, there is one controller function for many routes, like /v1/users/{user}/heartbeats, /compat/wakatime/v1/users/{user}/heartbeats, /users/{user}/heartbeats etc. which all use the same controller, and I'd like to be able to specify a unique id for each of those @Router routes.
If you want to take a look, definitions are currently duplicated in empty functions in the current implementation.
I thought that wasn't ideal, so I tried to specify multiple @Router in the annotation of the controller. I then found that it's not possible to specify a unique @ID for each router, and hence raised this feature request.
To refer to your CRUD example above, I'd like to give each @Router a unique id, which I believe is not currently possible.
The rationale for wanting a unique id (@ID) is to have nicer links in swagger-ui (from operationId in the yaml/json).

@ubogdan @YC What there ever a resolution to this? I've got the same issue where have two routers with one controller. One has a path parameter and one doesn't. When the docs are generated each show the path parameter.
I'd also like to have a different summary/description for each of them if possible.

@jwschmidt Not that I'm aware of, unfortunately.

same issue too.
finally I did this:
// @Id Handler_route1
// @Route /route1/xxx
func router1Handler(...){return originalHandler(...)}
// @Id Handler_route2
// @Route /route2/xxx
func router2Handler(...){return originalHandler(...)}
// @Id Handler_route3
// @Route /route3/xxx
func router3Handler(...){return originalHandler(...)}

// swag annotations removed
func originalHandler(...){}

also, handlers changed at here: ctx.HTTPRouter().POST()
on the other hand, could we support multi annotations on one function?like this:
// @Id Handler_route1
// @Route /route1/xxx
// //param,success,failed ...
//
// @Id Handler_route2
// @Route /route2/xxx
// //param,success,failed ...
//
// @Id Handler_route3
// @Route /route3/xxx
// //param,success,failed ...
func originalHandler(...){}

I hope swag could generate three different documents within one function annotation...


KAFKA-2071: Replace Producer Request/Response with their org.apache.kafka.common.requests equivalents

This PR replaces all occurrences of kafka.api.ProducerRequest/ProducerResponse by their common equivalents.

@ijuma Ok, thanks. I'll update that.

I've rebased it and removed implicit conversion of collections.

Merged trunk and fixed conflicts.

Failure is not related:
kafka.consumer.MetricsTest > testMetricsLeak FAILED

Could someone review this one? May be @gwenshap or @ijuma?

@dajac Are you interested in rebasing this?

@granthenke Yes, I'll have some time next week to do it.

@granthenke I have rebased this PR. Note that this PR migrates the server and the producer.

Migration of the producer is quite straightforward as it mainly happens in SyncProducer and DefaultEventHandler but I'm wondering if SyncProducer is considered as a public API. Is it?

@dajac It looks like the client code changes are not backward compatible. I think this patch either needs to be server side only, or if the clients are going to be updated, they need to be done so in a backward compatible way.
I could be wrong, as we have not had the discussion yet on the mailing list, but I think the idea is to deprecate the older Scala producers and consumers. I am not sure if its worth the effort of updating the client code. (context can be found in the comments on KAFKA-2982)

Looking at the JIRA for this PR, it looks like @gwenshap suggested that the JIRA was about removing k.a.Producer{Request, Response} altogether and that is why @dajac did this. But the producer is indeed public API and it is not yet deprecated so I think we can't do that for the upcoming release.
My suggestion is to only update the server-side and leave the soon to be deprecated clients alone.

@granthenke @ijuma Indeed, the SyncProducer part is not backward compatible. Making it backward compatible requires to keep the old produce request so it doesn't make sense to upgrade it to the new one. As you both suggested, it is better to not upgrade it.
I'll update the PR to reflect this.

@granthenke @ijuma I have rebased and updated it. Could you review when you have time? All tests pass locally.

Thanks for the update. I did a quick visual check and will follow up with a more in depth review likely tomorrow.

I had a look and left some comments. Looks good generally.

@granthenke @ijuma I did a first pass and addressed all your reviews. Thanks for you input.

@dajac Just a minor update for the exceptionName method. Otherwise LGTM.

@granthenke I have rebased the PR and addressed your points.

@gwenshap @ewencp @junrao Could one of you take a look? @granthenke and @ijuma have reviewed.

@ewencp I have addressed your points. Now, version is explicitly handled and an exception is thrown if the version is not supported. I'm just wondering if throwing an exception is the best way especially when sendResponseCallback is called from the purgatory. Also, I have updated ProduceRequest.getErrorResponse to handle version 0 and 1.

I have rebased and addressed all the comments.

LGTM, thanks @dajac!


POC: programmatic miniflare

Just putting this up here for show-and-tell - the first two commits are from #611
Sadly by running Miniflare in the same process as Wrangler, we can't connect a DevTools (since the node process is not running with --inspect).
But other that that, this felt really quite nice - although I only got a basic worker up and running.
So it looks like we will need to build a separate script that will be run in its own node process. But at least we can then control exactly how the options are passed through to it.
And actually we might be able to get away with sending messages between the two processes rather than stopping and starting the process all the time, when a change occurs to the bundle or options.

Maybe a dumb question, but what if we always started the wrangler CLI with --inspect?

Maybe a dumb question, but what if we always started the wrangler CLI with --inspect?
I did actually think about that but it seemed too extreme.

In any case, I think that it is better for the time-being to keep the shape of this code as close as possible to what we have now. In other words, if we still spawn off a child of our own making, then most of the Wrangler useEffec() code will stay the same. Then the only concrete changes would be what config options are passed and how. (@JacobMGEvans and I were discussing the idea of simply serializing the miniflare options object into JSON and sending it as a command line arg.)

Maybe a dumb question, but what if we always started the wrangler CLI with --inspect?

This consideration also came up 😅


Airflow 6980 improve system tests

Issue link: WILL BE INSERTED BY boring-cyborg
Make sure to mark the boxes below before creating PR: [x]

[ ] Description above provides context of the change
[ ] Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
[ ] Unit tests coverage for changes (not needed for documentation changes)
[ ] Commits follow "How to write a good git commit message"
[ ] Relevant documentation is updated including usage instructions.
[ ] I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5be3b31). Click here to learn what that means.
The diff coverage is 76.66%.

@@            Coverage Diff            @@
##             master     #717   +/-   ##
=========================================
  Coverage          ?   63.96%
=========================================
  Files             ?      896
  Lines             ?    42806
  Branches          ?        0
=========================================
  Hits              ?    27380
  Misses            ?    15426
  Partials          ?        0

Impacted Files
Coverage Δ

...providers/google/cloud/example_dags/example_dlp.py
0% <0%> (ø)

...s/google/cloud/example_dags/example_stackdriver.py
0% <0%> (ø)

...oviders/google/cloud/example_dags/example_tasks.py
0% <0%> (ø)

airflow/providers/mysql/hooks/mysql.py
92.7% <95.83%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be3b31...84e2e2f. Read the comment docs.


issue/4651-improve-log-pip (#4869)

Pull request opened by the merge tool on behalf of #4869

Merged into branches iso5 in 85ef47f9d96f74c3fe384722b39bbd07b34c8133


How to implement authorization with django build auth module

This extension is pretty good. But how to implement authorization. Thanks.

Hello,
We are maintening: https://github.com/socotecio/django-socio-grpc/ that support django authentication


codelabs tutorial poets doesn't work

Your tutorial does not work on a variety of fronts. You cannot complete the tutorial from start to end just trying to use your instructions. I dare you to do so.
I tried this using Anaconda AND Pycharm
https://codelabs.developers.google.com/codelabs/tensorflow-for-poets/#0

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

@Jvalal I completed the tutorial just by following the instructions.  Refer this if you want. Where are you facing issue?

Answers INLINE
On Wed, Jun 27, 2018 at 5:44 AM Alfred Sorten Wolf<EMAIL_ADDRESS>wrote:

Thank you for your post. We noticed you have not filled out the following
field in the issue template. Could you update them if they are relevant in
your case, or leave them as N/A? Thanks.
Have I written custom code NO
OS Platform and Distribution - Mac High Sierra 10.13.4 (17E199)
TensorFlow installed from - Tried through Anaconda and PIP
TensorFlow version - 1.8.x
Bazel version - n/a
CUDA/cuDNN version n/a
GPU model and memory - AMD Radeon Pro 460 and Intel HD Graphics 530
Exact command to reproduce - *There are no commands. Just try and follow
the tutorial. It doesn't work. If you want to watch a 15 minute video of me
trying to go through it I'm more than happy to record so you can see the
isssues. *
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/20326#issuecomment-400657341,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADoHrc_9IFejUgwbwOLTLSxjNypAzoeiks5uA34YgaJpZM4U48Cb
.

@Jvalal I don't know what Answers *INLINE* means. Tell me at what step in tutorial are you facing issue?

If you look at the thread. It means I responded to you with answers inline
to your questions. did you look at my response?
On Wed, Jun 27, 2018 at 10:16 AM Sumanth<EMAIL_ADDRESS>wrote:

@Jvalal https://github.com/Jvalal I don't know what Answers INLINE
means. Tell me at what step in tutorial are you facing issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/20326#issuecomment-400760801,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADoHraaKW1Me32EVKxyAYSYV-BMuH2ePks5uA73hgaJpZM4U48Cb
.

I'm getting errors at Step 2. See attached. I tried installing via terminal AND Anaconda. Same error.

Hello???

Try in a virtual environment. Afaik, that output isn't an error. It's saying that an upgraded version of tf has already been installed. Also pip is pointing to your system python. Not anaconda python. Execute which pip to confirm this. Also, very less people use python2 now.

If none of these work, uninstall tf completely. Ignore that command to install tf in codelabs. Install the latest version of tf in anaconda preferably and you are good to go.

Still get those red errors when I install it in Anaconda.

Nagging Assignee @tatatodd: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@tatatodd BUMP

Nagging Assignee @tatatodd: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 74 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 89 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 104 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 119 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 134 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Hi @Jvalal!
We are checking to see whether you still need help in this issue . Please create a new issue if the issue is replicating in Latest version TF 2.6 . Have you checked this thread on Tensorflow for Poets yet?Thanks!


quickstart script error,does not accept parameters

I am trying to implement openbalena-admin but when I run the quickstart script I get an error passing all the parameters:

Is there something I'm doing wrong?
Regards
Matias

Understanding that the parameters in square brackets [ ] are optional, the script worked for me passing all the parameters:

Regards
Matias

Same issue here . quickstart ails witout error . bur displays help text

echo  $OPENBALENA_JWT_SECRET -v $OPENBALENA_API_VERSION_TAG -d $OPENBALENA_HOST_NAME -
will give me right output for each variable
have tried adding the lines need manualy allso .. and gettin same error

@CHHE-ledtec It is a bug, you have to pass all the parameters requested by the command, including the S3 keys

@CHHE-ledtec
open-balena-admin/scripts/quickstart -U <....> -P <....> -v latest -j <....> -d <....> -p 5432 -a <....> -s <....>

@matiasAS do you have a fix for this?  I use the helm scripts for deployment, not docker-compose - so those were put together rather quickly.  If you can submit a PR with a change that fixes this that would be great, it seems to be a common problem.

@dcaputo-harmoni I had started to implement the graphical interface also with helm but I did not continue. I have no experience with kubernetes, I'll stick with the terminal for now and consume the api for specific data I may need


deps: Removed ujson dependency

:tada: This PR is included in version 4.0.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


promote Michael to the Triage permission level

Background
The TSC Project Roles defines the main roles for the Zephyr Project, including
Maintainer, Collaborator, and Contributor.
By default anyone that contributes code or documentation is a Contributor, but
with the lowest GitHub Permission Level of Read. For example, Contributors
with Read permission do not have the permission to add reviewers to a pull
request.
Use this template to nominate a GitHub user for an elevated permission level in
the Contributor role.
Nomination
GitHub User
Provide the following information about the GitHub user:

Michael Schmidt
michael1schmidt
Intel Corporation

Supporting Documents
[Add links to 3-5 GitHub pull requests, in the Zephyr project, authored or
reviewed by the GitHub user that demonstrate the user's dedication to the
Zephyr project.
]
https://github.com/zephyrproject-rtos/zephyr/pull/44332
https://github.com/zephyrproject-rtos/zephyr/pull/38720
https://github.com/zephyrproject-rtos/zephyr/pull/40445

added


Loading Error

2022-02-02 10:37:53.828 +08:00 [INF] [PLUGINM] Loading plugin SkipCutscene
2022-02-02 10:37:53.887 +08:00 [INF] [LOCALPLUGIN] Loading SkipCutscene.dll
2022-02-02 10:37:53.937 +08:00 [ERR] [LOCALPLUGIN] Error while loading SkipCutscene
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
---> System.Exception: This assembly is protected by an unregistered version of Eziriz's ".NET Reactor"! This assembly won't further work.
at d0oL3xUjRpnql6f6hv.aClEk45vbUktVXJcIW.EIZDi5AbH4L2X()
at Plugins.a08381.SkipCutscene.SkipCutscene..ctor() in D:\a\Dalamud.SkipCutscene\Dalamud.SkipCutscene\SkipCutscene\SkipCutscene.cs:line 21
--- End of inner exception stack trace ---

updated to <IP_ADDRESS>.


Fix: .worker chunkFilename suffix will be inserted before query parameters.

Previous chunkFilename replacing was not worked when chunkFilename had query parameters.
So add query parameters aware regex.

Looks great - thanks!


Support IF NOT EXISTS and IF EXISTS for CREATE and DROP commands

Being able to create/drop tables/classes without errors is very helpful.

+1

+1

+1

+1

+1

+1

+1

+1

+2

+2

+1

+1

would be very helpful for create property to create migration scripts

+1

+1

+1

Hi guys,
This is one of the most voted issues in our issue tracker, so I'm happy to announce that this feature will be available in v 2.2.13 for

CREATE CLASS
DROP CLASS
CREATE PROPERTY
DROP PROPERTY

Thanks!
Luigi

See full syntax:
http://orientdb.com/docs/2.2.x/SQL-Create-Class.html
http://orientdb.com/docs/2.2.x/SQL-Drop-Class.html
http://orientdb.com/docs/2.2.x/SQL-Create-Property.html
http://orientdb.com/docs/2.2.x/SQL-Drop-Property.html

@luigidellaquila - Hey Luigi,
If you think about it, with a full NoSQL ODB, all this would be baked into ODB and the DDL wouldn't be needed. :stuck_out_tongue_winking_eye:
Thanks for the improvement though. For full SQL ODB, it is a nice addition.
Scott

Hi @luigidellaquila
Thanks to hear my voice :)
https://github.com/orientechnologies/orientdb/issues/6063 . so you can close(partially) this issue .
Is there any plan for implementing the  TTL feature on the next release ?
Thanks
Saeed Tabrizi

OrientDB Server v2.2.13 (build 2.2.x@r90d7caa1e4af3fad86594e592c64dc1202558ab1; 2016-11-15 12:04:05+0000)
OS: Windows
Command:
DROP CLASS NonExistentClass IF EXISTS
Result:
Error: java.lang.IllegalArgumentException: Class 'qwe' not found in database


Refactor error type to be a enum case

This makes error handling easier if you want to specifically catch the TemplateParseError
do {
    let t = try Template(path: templatePath)
    do {
        let body = try t.render(context, namespace: nil)
        print("Rendered template: \(body)")
    } catch StencilError.TemplateSyntaxError(let message) {
        print("Template parse error: \(message)")
    }
} catch {
    print("Could not load template \(templatePath)")
}

Further the StencilError enum could be expanded to send back more detailed error messages than just a generic parse error.
(I also added a Xcode project, feel free to skip that)

What's wrong with this exactly?
do {
  let body = try template.render(context)
} catch let error as TemplateSyntaxError {
  print("Template syntax error: \(error)")
}

Autocomplete is much more useful with enums, especially if there are a lot of errors. But since there's only one error, I'm not sure how necessary it is.

Yes, and also there are many downsides to using an enum for this particular API:

Any new parameters or information attached to errors require a new major release (otherwise it would break backwards compatibility), for example adding source maps to errors (#28).
Many errors could be surfaced by plugins or custom template tags, and filters. It's not possible for those to extend the enum case.
Any new errors require major version release.
There's only one item so being an enum doesn't make logical sense.


Do not close an open gtkwave automatically

I suggest not to close an open gtkwave automatically when running a new simulation.
There might be situations when parallel debug sessions are required (different VCD files, different rtl, etc.)

Closing and reopening is done to reload the vcd file. It is possible to manually reload the vcd without closing gtkwave, so both options are possible without thinking of other situations. If gtkwave is closed we must also be careful to manually save the current waveforms to display in the .gtkw file. So either option are possible.
As for other situations, they need to be clearly identified as we are not worried about potential scenarios but only about the scenarios that exist now.

Ok for the other comments.

All indicated options are interesting.
In addition, we might need to have parallel debug sessions, for example: analyze the waveforms of a given RTL while running a simulation of another RTL in parallel. The current settings will let the second simulation end by closing the first gtkwave session in order to open a new one. This might be challenging for a user who should not stop the ongoing debug.

What is there is good enough
What we really need is the readme and docs

Please settle in a mode and documented in the readme. Right now my only interest is that there's a way to visualize waveforms even if not the best

After that I will close the issue


Add ability to initialize library with a config

The key changes are:

A BaseConfig class that defines the core functionality of the Config class. This is now used for typehinting.
initialize_with_config allows you to initialize the library with an existing config instance.
Bumping the version from 0.13.1 -> 0.14.0

This PR also includes...

A lot of formatting changes, because my IDE is set up with black. I'm going to follow up with a PR that adds it (and reformats the other code); I can unwind the changes in this PR as well, if too it's distracting.
A small fix for the CLI (a default value was invalid; I'm assuming a later version of Click got stricter about this).

scratch that... I'm going to add black-formatting first, because this is messing up linting!


Enable -fno-full-laziness -funbox-strict-fields for the entire library?

These flags are currently enabled in Data.HashMap.Internal, Data.HashMap.Internal.Array and Data.HashMap.Internal.List. It would be good to figure why these flags are enabled for these modules and also whether there are specific reasons for not enabling them in the remaining modules.
If these flags are useful, I think it would be best to enable them in the ghc-options in u-c.cabal.

-fno-full-laziness was introduced in https://github.com/haskell-unordered-containers/unordered-containers/commit/fa4802ef57d3b58889a37fe075afcdf5c62edcdc. The custom runST implementation has since been removed. Maybe we can get rid of the flag too now?!

https://github.com/haskell-unordered-containers/unordered-containers/issues/229#issuecomment-645048903 gives some context for -funbox-strict-fields.


[WebToolsE2E][Aspire][Document]Some more updates are needed to "Build your first .NET Aspire app" instructions using VS with aspire

Describe the issue or suggestion
Issue description
In "Build your first .NET Aspire app" doc, we need to make some updates to the instructions for Preview 7.

[ ] In Prerequisites, VS version should be 17.10 or higher

[ ] Issue 1:
For Create the .NET Aspire template section, document show "Ensure that Use Redis for caching(requires Docker) is checked and select Create"

actual: It shows "requires a supported container runtime", so need update the screenshot.

[ ] Issue 2:
For Test the app locally section, document shows "redis:7.2.4" and "localhost:57500" for cache, show "http://..." for apiservice, show "http://localhost:5044" for webfrontend

actual: show "docker.io/library/redis:7.0.4" and "tcp://localhost:57759" for cache, show "https://....; http://..." for apiservice,
show "https://...,http://..."  for webfrontend.  so need update the screenshot.

For Explorer the .NET Aspire dashboard section,  the screenshot also need update as same as above issue.

[ ] Issue 3:
For .NET Aspire app host project section,  document show screenshot:

Actual: Have this line "75068497-9774-40c7-915d-eedd99473268", so document need update the screenshot.

[ ] Issue 4:
For .NET Aspire app host project section,  document show below screenshot:

Actual: Have this line " .WithExternalHttpEndpoints()" in line 8, so need update the screenshot.

[ ] Issue 5: Document show screenshot:

Actual: show as below, so need update the screenshots.

@bradygaster this is the issue I was showing you during the meeting today. I'll try to send a PR on Monday for preview-7 if the doc team doesn't get to it by then.

thanks @balachir !!!

Verify this document has been updated, thanks a lot.


PCIe: Introduce helper to look up devices based on VID/DID

Currently the only in-tree place that benefits from this is the ivshmem driver, but this is likely to be needed for more and more use cases whenever the BDF value isn't known up-front (e.g. in the case of removable PCIe devices).

I have a feeling that eventually we'll want to do centralised PCIe device enumeration and driver initialisation, so that these three-levels of for-loops don't have to be done for every device that needs looking up. I.e. drivers would instead register supported VID/DID values to a PCIe "bus driver" which would then go ahead and make callbacks to drivers whenever a matching device is found.
The one thing I'm wondering is would we still want to list such devices in DTS as well. The problem with using the new PCIE_BDF_NONE macro in DTS is that since we're using reg = <bdf, id>; the DTS parser requires the bdf to match the beginning of the node declaration, e.g. an UART with BDF 0xca00 is required to be delared as uart2: uart@ca00 { in DTS. So if we use PCIE_BDF_NONE the "header" would have identical values for multiple nodes, which is something I suspect isn't allowed.

Answering one of my concerns: I think we need to move away from reg = <...>; in DTS, at least for nodes that we don't know the BDF up-front. Instead, I'd suggest introducing a new optional pcie-id property that is mandatory if reg = .. isn't given for a node that sits under a PCIe bus.

Answering one of my concerns: I think we need to move away from reg = <...>; in DTS, at least for nodes that we don't know the BDF up-front. Instead, I'd suggest introducing a new optional pcie-id property that is mandatory if reg = .. isn't given for a node that sits under a PCIe bus.

So I think we should start trying to see if we can work towards encoding PCIe nodes according to devicetree spec:
Here's an example of what the dts should look like:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/x86/platform/ce4100/falconfalls.dts#n68
Can you possible work up a dts for one of the platforms you are interested in and we can try and see what tooling improvements we need to add for PCIe support.  I can help with questions on the node properties (the reg/range property for PCI can be confusing)


tensor.rename

🚀 🚀 Pull Request
Checklist:

[ ]  My code follows the style guidelines of this project and the Contributing document
[ ]  I have commented my code, particularly in hard-to-understand areas
[ ]  I have kept the coverage-rate up
[ ]  I have performed a self-review of my own code and resolved any problems
[ ]  I have checked to ensure there aren't any other open Pull Requests for the same change
[ ]  I have described and made corresponding changes to the relevant documentation
[ ]  New and existing unit tests pass locally with my changes

Changes
Added ds.rename_tensor and tensor.rename

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Moved to #1514


Checkbox label not clickable if name is not provided

Current Behavior
Omitting the name attribute when using <Checkbox> will result in the label next to the checkbox not toggling the value as one would expect.
Because there isn't any error message except the warning in the console telling me that "name" is missing, it took me quite a while to understand that one was linked to the other.
Expected Behavior
Maybe when omitting the name it could be auto-generated with a uuid or just a counter.
It seems to me that when using Svelte an input's name has very little relevance in most cases. What I like about Svelte is that it is very concise, so if I have to specify the name I expect that it must mean something in terms of my app's domain logic.
Steps To Reproduce

Use the  component with a label, omitting to provide the name attributelet checked = false;
<Checkbox bind:checked={checked }>
<Checkbox.Label slot="label">Checked</Checkbox.Label>
</Checkbox>

Click on the label next to the checkbox
Notice that the checkbox doesn't get toggled. Nothing happens.

Link to Reproduction / Stackblitz
No response
More Information
No response

The issue with this is that based on the structure the for property of the label needs to be linked to the id property of the input field and this is all directly tied to the name property provided to the Checkbox component. This just comes back to how html works unfortunately. As for generating an id and for property, if the name property is omitted I can auto generate this utilizing the nanoid package. If this is going to happen it should be expanded to all form elements not just the Checkbox in my opinion.

Indeed it's tied to basic HTML (as I remember from my days working with Rails :) but that doesn't mean this "implementation detail" should not be hidden from the developer. So auto-filling of the name attribute would make a lot of sense and doesn't seem to have any drawback as far as I know.
Thank you for mentioning nanoid, I've just switched to it instead of uuid in my current project :)

[ ] Autocomplete
[ ] Checkbox
[ ] DatePicker
[ ] FilePicker
[ ] Input
[ ] InputNumber
[ ] Radio
[ ] Rating
[ ] Select
[ ] Toggle

🎉  Thank you so much :)


[FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory

What is the purpose of the change
Currently RocksDBWriteBatchWrapper will flush the batch just based on item count, will consume too much memory for big kv.
This PR will add consumed memory sized based control policy, will flush the batch either item count or consumed memory size exceeds the configured value.
Brief change log

Add a configuration state.backend.rocksdb.write-batch-size in ROcksDBCOnfigurableOptions to set the batchSize, default 2mb
Add logic to flush write batch after consumed memory size exceeds the preconfiged value.

Verifying this change
This change added tests and can be verified as follows:

RocksDBWriteBatchWrapperTest#testWriteBatchWrapperFlushAfterMemorySizeExceed to test that the batch will flush after consumed memory exceeds the preconfigured value
RocksDBWriteBatchWrapperTest#testWriteBatchWrapperFlushAfterCountExceed to test that the batch will flush after item count exceeds the preconfigured value

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (docs)

cc @carp84

@carp84 @StephanEwen thanks for your review, updated the code

rebased master and addressed the comments

@carp84 @StephanEwen thanks for the review, update the code to use jni call directly.

rebased the master to resolve conflict

@flinkbot run travis

rebased master to fix conflict

kindly ping @StephanEwen

kindly ping @StephanEwen
hope we can have this in release 1.10, so that others will not encounter OOM when recovery from savepoint

Since all comments resolved and travis/azure builds are green, I'm planning to merge this PR. Please let me know if any concerns @StephanEwen , thanks.

@carp84 @StephanEwen thanks for review and merging


Fix builds

Added missing libraries
Fetching locale from upstream but generating icons locally before creating build.
Added contract to data_files included to pyinstaller.
@mit15 you should do something similar for icons and the contract in the windows build.
There's no way to pass the --testnet argument to pyinstaller so for Mac you need to run this from command line and for windows I think you can edit the .exe to pass this argument.

@mit15 contract change should be in build-wine/deterministic.spec and be exactly the same to this here. Unless you add this it will always crash.
Similarly in build-wine/build-electrum-git.sh icons should not be loaded from deterministic build but compiled to electrum (as I do here) and then the build automatically picks them up.


Skip bounded comments (parens)

Hi,
This PR adds the ability to skip bounded comments, ex:
: dup ( x -- x x ) sp@ @ ;
 ok

This will define the word dup and skip everything between ( and ). It's a bit naive and doesn't handle cases of nested parens.. so:
: dup ( x -- (x) x ) sp@ @ ;

... would fail, not that anybody does that...
On the plus side, this makes it possible to easily copy/paste Forth code from existing implementations and libraries without having to manually remove the (comments).
This adds 20 bytes to the binary, but can probably be optimized a bit.

hmm.. I tried but it fails:
line 285
  li t0, '('                           # bounded comments start with ( char
AssemblerError: invalid char literal in expr: "' ( '"

Interesting... That might be an assembler bug for me to look into. Either way, this PR is good to go!


updates status option in vm to only call ls if /dev/vmm exists

Updated vm_status() to only run ls if /dev/vmm exists.

Reworked the initial commit to more reliably display output of vm_status().  I also added output for when no VMs are running to be consistent (at least as I understand it) with other rc.d scripts.
There are also a couple of extra lines in the diff removing trailing white space.  This is just an artifact of my editor settings.  If those are a problem, I can re-work to remove the changes not specific to the subject change.

While at it, would you like to look up and add Xen's 'xl list' output?

I'll take a crack at it -- really a matter of just getting some time to work on it.  Translation:  give me a couple of days.


Add HF mixin

This PR enables to directly load AudioSep models from the 🤗 hub, rather than people having to download them first manually (by simply making the model inherit from the PyTorchModelHubMixin class). The additional benefit is that you'll see actual download numbers (similar to HF models) on the hub, you can add a model card to your model, etc. I've pushed a model here: https://huggingface.co/nielsr/audiosep-demo
Here's how to use it, using the familiar from_pretrained method:
from models.audiosep import AudioSep
from utils import get_ss_model

ss_model = get_ss_model('config/audiosep_base.yaml')
model = AudioSep.from_pretrained("nielsr/audiosep-demo", ss_model=ss_model)

Inference can then be done in the same way:
audio_file = 'exp31_water drops_mixture.wav'
text = 'water drops'
output_file='separated_audio.wav'

# AudioSep processes the audio at 32 kHz sampling rate
inference(model, audio_file, text, output_file, device)

One also directly inherits the from_pretrained and push_to_hub methods:
# save model locally
model.save_pretrained("my-awesome-audiosep-model")
model.push_to_hub("nielsr/my-audiosep-model")

It could be improved even more by defining attributes (similar to models in HF Transformers), such as input_channels, output_channels as part of the model's init such that those can be saved in a config.json on the hub, such that one can skip having to load the ss_model, allowing to just do:
from models.audiosep import AudioSep

model = AudioSep.from_pretrained("nielsr/audiosep-demo")

However the latter would require a breaking change, so if you don't want breaking changes you could just use solution 1. Let me know whether you are interested.
Kind regards,
Niels
ML @ HF

Hi @liuxubo717 thanks for merging my PR! However it might be better to host the AudioSep checkpoint as part of your organization, rather than my personal username (nielsr). Are you interested in moving the AudioSep checkpoint from nielsr to the Audio-AGI organization? Then I can also update the README


gogs backup failure

Gogs version (or commit ref): 0.10.18
Git version:
Operating system: alpine
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gogs.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist (usually found in log/gogs.log):

Description
Running /app/gogs/gogs backup inside a container fails with the following message:
2017/03/25 02:10:27 [ INFO] Backup root directory: /tmp/gogs-backup-766413534
2017/03/25 02:10:27 [ INFO] Packing backup files to: gogs-backup-1490407827.zip
2017/03/25 02:10:27 [FATAL] Fail to dump database: fail to dump table 'User': no such table: user

Steps to reproduce:

Create a gogs docker container with default config, selecting sqlite as the DB
Running backup inside the container fails docker exec gogs-backup-bug /bin/bash -c "export USER=git && /app/gogs/gogs backup"

Code to reproduce:
#!/bin/bash

# create a docker compose file
cat > ./docker-compose.yml <<-END
version: '3'

services:
  gogs:
    image: gogs/gogs:0.10.18
    container_name: gogs-backup-bug
    ports:
      - "10022:22"    # ssh for git
      - "10080:3000"  # http port
    volumes:
      - ./volumes/gogs:/data
    networks:
      default:
        aliases:
          - gogs
    restart: always
END

# run container described in docker-compose.yml
docker-compose up -d

# get container ip address
container_ip=$(docker inspect --format "{{.NetworkSettings.Networks.docker_default.IPAddress}}" gogs-backup-bug)
echo $container_ip

# wait for container to startup
sleep 5

# save cookies to gogs-cookies file
curl "http://${container_ip}:3000/install" \
    --cookie-jar gogs-cookies

# install selecting "sqlite3", using the container IP above for the domain and app_url
# admin user: gogs_admin, pass: test, email<EMAIL_ADDRESS># everything else default
curl "http://${container_ip}:3000/install" \
    --cookie gogs-cookies \
    -H 'Origin: null' \
    -H 'Accept-Encoding: gzip, deflate' \
    -H 'Accept-Language: en-US,en;q=0.8' \
    -H 'Upgrade-Insecure-Requests: 1' \
    -H 'User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/56.0.2924.76 Chrome/56.0.2924.76 Safari/537.36' \
    -H 'Content-Type: application/x-www-form-urlencoded' \
    -H 'Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8' \
    -H 'Cache-Control: max-age=0' \
    -H 'Connection: keep-alive' \
    -H 'DNT: 1' \
    --data "db_type=SQLite3&db_host=<IP_ADDRESS>%3A3306&db_user=root&db_passwd=&db_name=gogs&ssl_mode=disable&db_path=data%2Fgogs.db&app_name=Gogs&repo_root_path=%2Fdata%2Fgit%2Fgogs-repositories&run_user=git&domain=${container_ip}&ssh_port=22&http_port=3000&app_url=http%3A%2F%2F${container_ip}%3A3000%2F&log_root_path=%2Fapp%2Fgogs%2Flog&smtp_host=&smtp_from=&smtp_user=&smtp_passwd=&enable_federated_avatar=on&enable_captcha=on&admin_name=gogs_admin&admin_passwd=test&admin_confirm_passwd=test&admin_email=test%40nowhere.com" \
    --compressed

# backup fails
docker exec gogs-backup-bug /bin/bash -c "export USER=git && /app/gogs/gogs backup"

So after playing with this more, the issue is the default path for sqlite3 database:

Changing the default path to an absolute /data/gogs.db during docker installation seems to make everything work.
Perhaps the docker install instructions need to be updated to reflect this, or maybe a clarifying message under the box?

Hi,

on the documentation, it says on the first line:

Restore is not specifically designed for Docker container, invalid cross-device link is not something I understand, needs more investigation.

I can change to the directory first instead of running /app/gogs/gogs directly and the backup still succeeds:
$ sudo docker exec gogs-backup-bug /bin/bash -c "export USER=git && cd /app/gogs && ./gogs backup"
2017/03/25 17:24:36 [ INFO] Backup root directory: /tmp/gogs-backup-537097014
2017/03/25 17:24:36 [ INFO] Packing backup files to: gogs-backup-1490462676.zip
2017/03/25 17:24:36 [ INFO] Dumping repositories in '/data/git/gogs-repositories'
2017/03/25 17:24:36 [ INFO] Repositories dumped to: /tmp/gogs-backup-537097014/repositories.zip
2017/03/25 17:24:36 [ INFO] Backup succeed! Archive is located at: gogs-backup-1490462676.zip

Restore fails with the same reason:
$ sudo docker exec gogs-backup-bug /bin/bash -c "export USER=git && cd /app/gogs && ./gogs restore --from gogs-backup-1490462676.zip"
2017/03/25 17:25:24 [ INFO] Restore backup from: gogs-backup-1490462676.zip
2017/03/25 17:25:32 [FATAL] Fail to import 'custom': rename /tmp/gogs-backup/custom /data/gogs: invalid cross-device link

At this point I am going to chalk this up to running inside docker. I fiddled with different docker configurations for an entire day.
I have an existing process where I just backup the mounted volume on the host, which works, but if there is an official method available, I thought I would try it.

I don't think you read me comment:

Restore is not specifically designed for Docker container, invalid cross-device link is not something I understand, needs more investigation.

Changing the default path to an absolute /data/gogs.db during docker installation depicted above will make the backup process work, however the restore process will fail

I confirm that changing to absolute path makes the command
USER=git /app/gogs/gogs backup

exit with status 0, but the output file (e.g. gogs-backup-1493407935.zip) contains many files of size 0. Even the User.json is of size 0 and empty, while I have created 1 gogs user.
So it is gogs backup command that fails, even though it exits with status 0.

Possible solution is posted here: https://github.com/gogits/gogs/issues/4641#issuecomment-318011581

How does this refer to docker's backup to the host directory instead of the /tmp directory?

@xingxing9688; As long as during the restore you're not hitting a file or directory offered by docker volume and stay within the same filesystem, renaming a file works. In my opinion avoiding this problem by using the move command instead of rename would be a better solution.
So if you have this construction for example:
docker run .... -v /data/gogs:/data/gogs -v /myconfig/app.ini:/data/gogs/app.ini .....
Renaming app.ini during restore will likely fail, moving will succeed.


input will lose focus after change

When I use Form component as class I will lose focus when I try to change input. (I am using input as controlled component)
import { Component } from 'react';

class Form2 extends Component {
  render () {
    return (
      <form>
        {props.children}
      </form>
    );
  }
}

class Test extends Component {
   state = {};

    handleChange = (e) => {
    	this.setState({
      	  test: e.target.value
      });
    }

    render() {
        return (
          <Form2>
             <input value={this.state.test} type="text" onChange={this.handleChange} />
          </Form2>
         );
    }
}

Stateless component is working fine
import { Component } from 'react';

const Form2 = (props) => {
    return (
      <form>
        {props.children}
      </form>
    );
}

class Test extends Component {
   state = {};

    handleChange = (e) => {
    	this.setState({
      	  test: e.target.value
      });
    }

    render() {
        return (
          <Form2>
             <input value={this.state.test} type="text" onChange={this.handleChange} />
          </Form2>
         );
    }
}

<EMAIL_ADDRESS><EMAIL_ADDRESS>alias in webpack:
      react: 'preact-compat/dist/preact-compat',
      'react-dom/server': 'preact-compat/server',
      'react-dom': 'preact-compat/dist/preact-compat',

Hmm - I copied your example to a fiddle and it seems to work?
https://jsfiddle.net/developit/cxnzxc2a/

OK I am trying to isolate minimal example from my bigger project

this issue is caused by react-hot-loader.

Ahh good to know. That's already high on my list of things to figure out.


fix(price decimal places): added roundTo function

in order to round prices to two decimal places

fixes issue https://github.com/DivanteLtd/vsf-utilities/issues/1

looks awesome 👍


Record for nginx ingress contains local ip (AWS)

Hi
Using external-dns 0.4.4 on AWS, the A record created for nginx ingress controller is created using ingress LoadBalancer Service internal endpoints (eg 10.xx) (It is also failing for nginx-ingress with more than 1 port but this issue seems already tracked in #239 )
To work around that, I disabled ingress in external-dns and use external-dns.alpha.kubernetes.io/hostname annotation directly on the nginx-ingress Service. However this is much less dynamic as I need to edit the annotation for every host.
Thanks

This sounds like an issue with the nginx ingress controller rather than ExternalDNS.
ExternalDNS uses the address defined in the status field of the ingress object for creating the record. So the issue is with the nginx ingress controller setting the wrong address on the ingress object.

hi
thanks for your quick answer. I'm going to report the issue to the nginx ingress controller team then.
Best regards


website: fix osbuild-composer 8 news

It mentioned osbuild instead of osbuild-composer.

Fixed in f4e606fc5e1da62a23116c0f8c095eadd9d3a1c8, closing.


nixos: better tor config

Motivation for this change
SLNOS had a (IMHO) superior version of #28081 for half a year already. I rebased it onto NixOS master. Feel free to bikeshed and reject :)
Things done

[X] It works
[X] Fits CONTRIBUTING.md.

SLNOS had a (IMHO) superior version of #28081 for half a year already.

Where is the SLNOS code/fork? I don't see it on github.com nor from internet search.

Where is the SLNOS code/fork? I don't see it on github.com nor from internet search.

That's a good question. Currently we abuse BSD license by not sharing
the code anywhere except between members of our group.
It will probably go public on https://github.com/SLNOS after s6 init
becomes usable.

Travis error is a doc build error which is a ghc build error.
This patchset had ~6 months of testing, so lets proceed to the discussion.

I like the descriptive texts a lot.

Franz Pletz<EMAIL_ADDRESS>writes:

This should be unnecessary, right?

Yep, probably a leftover of another version or something.
Also fixed another tiny type bug I haven't noticed before.

I like this version and especially the docs but the duplicated effort on the hidden services implementation is a pity. I would welcome you open sourcing your fork even though the license doesn't dictate that.

Yeah, but the problem is that its ~200 patches over master ATM and most
of them depend on (or are pretty useless without) changes that were
rejected from master or our custom tooling (we don't support
nixos-rebuild). Splitting those patches into "this can go upstream"
and "this is only for our space-age technology" takes a lot of effort
nobody is willing to put in unless things start conflicting with master.
Also, many SLNOS patchsets are not beautiful, which is an (expected)
consequence of out "Is this an actual problem? Yes? Do you have a better
solution for it right now? No? Stop bikeshedding and merge this" policy.
Also note that we can't just publish all of the patches and have the
community fix them as public SLNOS members (currently only me) have to
fix code style and rewrite all the doc strings and comments as per our
stylometry policy. This takes lots of effort (and sometimes some
research as I can't document things I don't understand).
If something gets an equivalent or better implementation in master while
our patches ferment we just drop our patches or reimplement features we
want on top of whatever new master got. This happens quite regularly but
since SLNOS cares about features, not credit, we are ok with that. In
this instance I just loved the SLNOS version of options so much (and
finished doc strings awhile ago; but those patches got lost in the sea
of other stuff and I remembered about them only on merge conflict with
master) I felt it would be a loss to just drop them.
In short, I don't know a good way to solve the duplicated effort part.
If you have any suggestions I would welcome them.
At least in one instance other developer read my nix-dev announcement
and wrote an e-mail of "I want to implement X which is on SLNOS TODO
list. Does SLNOS have that already by any chance or should I proceed
implementing it myself?" nature. Which was very nice of him/her. I, too,
put all NixOS github notifications and nix-dev into notmuch and
search that and git log (sometimes the future is in the reverted past)
before doing or discussing any substantial changes to nixpkgs or
SLNOS. But how many other people do that on a regular basis? You can't
do that without using space-age technology (xapian) to handle your
e-mail and most people outsource their e-mail to people that use
space-age technology to make your e-mail easy to mine, not to make huge
streams of new e-mail and enormous e-mail archives you already have easy
to consume.
(If you're reading this and don't use notmuch go check it out,
seriously. This planet has two pieces of software that I don't regret
putting a ton of effort to learn to use and automate: Emacs (org-mode)
and notmuch. It also works perfectly with Emacs and, after some
org-capture magic, with org-mode. But if you think notmuch is a
little (not) too much for you then check mailpile out, it has most of
space-age technology of notmuch within a conventional UX your mom
could work with.)

Also dropped some dead code.

Tested the fixes myself. Travis is happy too.

Yay! Thanks.

I think this should have been in the release notes as a backwards incompatibility. When updating my Tor relay today from 17.03 I got
error: The option `services.tor.relay.role' is used but not defined.

Wasn't difficult to fix by adding a role = "relay" to my configuration but it took me by surprise.

I think this should have been in the release notes as a backwards incompatibility. When updating my Tor relay today from 17.03 I got
error: The option `services.tor.relay.role' is used but not defined.

Wasn't difficult to fix by adding a role = "relay" to my configuration but it took me by surprise.

 See the doc strings and Dmitry
Bogatov's case.


Update the Readme

Hi sir,
I use ubuntu 16.04, and I use python by anaconda. I repeatedly ran the command
 $ sudo apt-get install python-xlib
but for me the error : "no module named Xlib " satisfied after typing the following:
pip install python3_xlib
as the code in Clix couldnot access the Xlib module present in root.
I would like to update the readme for the same

@apezoidal Strange :confused:  Exactly the opposite worked for me.
Can you post more details about your error?

I was getting the following error:
clix Traceback (most recent call last):   File "/home/anika/anaconda2/bin/clix", line 7, in <module>     from clix.clix import main   File "/home/anika/anaconda2/lib/python2.7/site-packages/clix/__init__.py", line 1, in <module>     from .clix import *   File "/home/anika/anaconda2/lib/python2.7/site-packages/clix/clix.py", line 6, in <module>     from .pyxhook import HookManager   File "/home/anika/anaconda2/lib/python2.7/site-packages/clix/pyxhook.py", line 42, in <module>     from Xlib import X, XK, display ImportError: No module named Xlib

@apezoidal I just noticed. It seems you are using python 3, since pip install python3_xlib worked for you. So, instead of sudo apt-get install python-xlib , it should have been sudo apt-get install python3-xlib
Correct me If I'm wrong.

@dibyadas  the problem was that by sudo install the xlib was being downloaded in root and my clix code was not able to access it. While, pip install python3_xlib installed the module in the anaconda folder. Moreover, though I overcame "No module named Xlib" error, further errors came up. According to me the clix code is written in python-2.7 and thus the python-3 xlib library is not compatible to it ( its just a guess).
Advice me what to do.

@apezoidal The clix source code is compatible with both Python 3 and 2. I suggest you try this sudo apt-get install python3-xlib and see if you still get errors. Beyond this I cannot be of much help, because I'm never used  Anaconda. Maybe @nikhilkumarsingh will be able to help you out.
Thanks!

@dibyadas I have tried the sudo apt-get install python3-xlibbut its not troubleshooting the error.
Thanks !!

@apezoidal Oh wait. :thinking: Did you wait clix through pip or pip3 ?  If pip, then you might try to remove clix and reinstall it through pip. This might solve the error.
Thanks.

This issue still persists for me.
@apezoidal, Did you find a solution?

Did you guys tried this?
https://stackoverflow.com/a/33273728

@nikhilkumarsingh I don't use anaconda but okay, I'll install it, thanks.

@rish4bhn  Clix doesn't require anaconda. @apezoidal uses anaconda. So the stackoverflow answer was for her.  No need for you to install anaconda.

I am eagerly looking forward to contributing to this issue, please guide me with details of the error.


[ML] Fix race condition in updating lastMarkDeleteEntry field

Motivation

missed updates to lastMarkDeleteEntry can lead to the subscription and consuming getting stuck. This seems to impact both Key_shared and Shared subscriptions.

Modifications

when updating lastMarkDeleteEntry field, make sure that the new value is later than the previous value.

btw. The problem scenario looked like very similar as in #14261. However there was a difference.

I made a follow-up PR #15067 to improve the solution. Please review.

Why does this patch not add a test ?
@eolivelli @lhotari


Stub for generated Models

Unfortunately, there is a bunch of duplication involved in inserting and retrieving information from the DB.
You could get a grasp for this from a simple (official) example:
https://www.mongodb.com/developer/languages/python/python-quickstart-fastapi/
This led to #8 and the ReadModel and UpdateModel creation.
Unfortunately, being dynamically generated, they are pretty useless for the static analyzers and the intellisense.
For this reason, it would be useful to generate stub files (I won't generate code in Python files, especially in existing ones, to keep generated code separate from manually written one).
https://mypy.readthedocs.io/en/stable/stubs.html
This is something that should be pretty simple to do automatically, starting with the stubgen CLI.
The only thing I'm not sure about is whether I want to commit to the repo or not.
Contra: I don't like adding in Git and reviewing in GitHub generated files (even though they will look very close to the manually written ones)
Pro: they will be available in development as well.

Static analysis support and autocompletion :)
It is not required, but I'm planning to run mypy as well in the CI asap. Here it would not be a problem, because those types are only used to return, but using the results in the other packages would require exceptions (or just raise errors).

Fine, then go for it.


Add mantissa and exponent format to p-value and require value

In order to avoid issues with small p-values being rounded to zero (https://github.com/opentargets/platform/issues/434), they will also be accepted as mantissa and exponent. However, floating-point notation will be required until changes are made to the pipeline.

@mkarmona and @cmalangone:
Can you please review this PR by 16:00 on Thursday, 12 December? If possible, I would like to send out our 20.02 release schedule with a link to the updated version of the JSON schema proposed by @AsierGonzalez.
Thank you! :-)


Add klapkov as ARP Reviewer

[DIEGO-RELEASE] Add locket client keepalive time and timeout to jobs: https://github.com/cloudfoundry/diego-release/pull/722
[DIEGO-RELEASE] Make max_containers prop configurable: https://github.com/cloudfoundry/diego-release/pull/876
[BBS] Add request metrics for BBS - still open: https://github.com/cloudfoundry/bbs/pull/80
[BBS] Use scheduling info instead of the whole desiredLRP: https://github.com/cloudfoundry/bbs/pull/79
[BBS] Add routing info endpoint:
https://github.com/cloudfoundry/bbs/pull/66
[BBS] Remove cpu_weight limit:
https://github.com/cloudfoundry/bbs/pull/81
[EXECUTOR] Improve error handling on process start - still open: https://github.com/cloudfoundry/executor/pull/91
[LOCKET]  Add a keepalive timeout on the locket client: https://github.com/cloudfoundry/locket/pull/12
[GROOTFS] UsedVolumesSize and UsedStoreInBytes metrics: https://github.com/cloudfoundry/grootfs/pull/155
[ROUTE-EMITTER] Use routing info bbs endpoint when syncing: https://github.com/cloudfoundry/route-emitter/pull/23
[ROUTE-EMITTER]  Use routing_info for desired_lrp's when there are missing actual_lrp's:
https://github.com/cloudfoundry/route-emitter/pull/26
[SILK-RELEASE] Deduplicate Iptables Rules with Dynamic ASG's: https://github.com/cloudfoundry/silk-release/pull/101
[SILK-RELEASE] Make container_metadata_file_check_timeout on silk-shutdown configurable:
https://github.com/cloudfoundry/silk-release/pull/111

As stated in the Promotion to Reviewer or Approver two approvers of the Diego area needs to attest that @klapkov meets the criteria by reviewing this PR.

🎉 Congrats!


adds object/function filter to local plugin

Git fail. This all belongs to #747 to close #746.

I'll try to ship a point release with this yet today. Thanks @benoj and @arnimhanke!

This has been released with<EMAIL_ADDRESS>though not tagged as latest yet.
cc @waclock

Do you mean 1.13.0 (I cant find the changes in 1.3.0) ? :)

Do you mean 1.13.0?

That's what I said 😉


update URLs into upstream Misty API documentation

They changed their documentation website recently, breaking old URLs about the Misty REST API.
Update affected URLs that appear in the examples:

faceprint_misty1devel.ipynb
faceprint.ipynb

note that old URLs are not redirected, as reported upstream at https://github.com/MistyCommunity/Documentation/issues/33

following releases from Misty Robotics company that have occurred since this issue was opened, the tasks are:

[ ] delete faceprint_misty2devel.ipynb
[ ] change workspace type of faceprint.ipynb to be fixed_misty2
[ ] update URLs to upstream documentation (as in the OP)


CARBONDATA-64 data mismatch between the carbon Table and Hive Table for data having empty lines

…

LGTM


Fixed bug with transit time priors for more than one planet

Hello,
I came across the same error as in Issue #81 that occurs when fitting more than one planet with TTVs. In setting the lightcurve prior dict, when a transit time prior is detected, 'parametrization' is only set to 'T' for the last planet in the system. I changed the indexing in line 570 so 'parametrization' = 'T' is set for all planets with transit time priors. After doing this, fitting multi-planet systems with transit time priors seems to proceed as expected.
Best,
Sheila

Hi @nespinoza,
Independently found the same bug as @ssagear with the same fix. I would recommend and support this pull request.
Thanks,
Tom


correcting spelling of MfaAuthMethodsAnalysis.ps1

the MfaAuthMethodsAnalysis.ps1 given in the samples was misspelled, corrected.

Corrected before I saw this. Thanks, Tuna.


Support 1012, 1013 and 1014 WebSocket close status code

Motivation:
RFC 6455 doesn't define close status codes 1012, 1013 and 1014.
Yet, since then, IANA has defined them and web browsers support them.
From https://www.iana.org/assignments/websocket/websocket.xhtml:

1012: Service Restart
1013: Try Again Later
1014: The server was acting as a gateway or proxy and received an invalid response from the upstream server. This is similar to 502 HTTP Status Code.

Modification:
Make status codes 1012, 1013 and 1014 legit.
Result:
WebSocket status codes as defined by IANA are supported.

Investigating if autobahn test suite can support those new codes.

Great!
Please note that I did’t add 1015 as a valid code.
One the one side, I probably should to stick to the spec.
On the other side, I don’t get how one could get a websocket frame in case of a TLS handshake error. Sadly, the links on the IANA page to the related mailing list are dead.
WDYT?

@slandelle yeah... I think what you did is good enough for now...

@normanmaurer What's the command for triggering CI, please?

@netty-bot test this please
@slandelle

Thanks!

@slandelle thanks... merged!


Pass all artifact download options through to the wandb-core downloader

Description

Fixes WB-NNNNN
Fixes #NNNN

What does the PR do? Include a concise description of the PR contents.

[ ] I updated CHANGELOG.md, or it's not applicable

Testing
How was this PR tested?

#7353  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @moredatarequired and the rest of your teammates on  Graphite


[CXF-8535] Query missing from signature request-target AND also to add digest only if request has body

[CXF-8535] Query missing from signature request-target AND also to add digest only if request has body
The following fixes are incorporated in this PR

The issue was instead of using getRequestUri of URI info to consider the query parameters in the request-target , getAbsolutePath was used which truncates the query parameters in VerifySignatureFilter and results in Invalid Signature while verifying.

In addition to that, digest will be added to the required headers only if the request has payload/body.

Test cases are also been incorporated for the above fix

@coheigea PTAL

@coheigea from the implementation perspective - LGTM, but from the spec perspective would be great to hear your opinion, thank you.

The changes look fine to me, but it is causing a test failure in systests/rs-security (JAXRSHTTPSignatureTest) can you take a look?

The changes look fine to me, but it is causing a test failure in systests/rs-security (JAXRSHTTPSignatureTest) can you take a look?

Sure @coheigea will take a look why that particular case is failing and update accordingly

The changes look fine to me, but it is causing a test failure in systests/rs-security (JAXRSHTTPSignatureTest) can you take a look?
@coheigea , For the below particular test case which is failing , if the digest is not available in the header then body will be returned as null in DigestVerifier as digest header does not exists in the request which is stricter check, can this test case be removed ?

@Test
public void testMissingDigestHeader() throws Exception {
URL busFile = JAXRSHTTPSignatureTest.class.getResource("client.xml");
CreateSignatureInterceptor signatureFilter = new CreateSignatureInterceptor();
signatureFilter.setAddDigest(false);
KeyStore keyStore = KeyStore.getInstance("JKS");
keyStore.load(ClassLoaderUtils.getResourceAsStream("keys/alice.jks", this.getClass()),
"password".toCharArray());
PrivateKey privateKey = (PrivateKey)keyStore.getKey("alice", "password".toCharArray());
assertNotNull(privateKey);
List headerList = Arrays.asList("accept", "(request-target)");
MessageSigner messageSigner = new MessageSigner(keyId -> privateKey, "alice-key-id", headerList);
signatureFilter.setMessageSigner(messageSigner);
String address = "http://localhost:" + PORT + "/httpsigprops/bookstore/books";
WebClient client =
WebClient.create(address, Collections.singletonList(signatureFilter), busFile.toString());
client.type("application/xml").accept("application/xml");
Response response = client.post(new Book("CXF", 126L));
assertEquals(400, response.getStatus());
}
OR
to have additional check to add digest in the required headers for POST or PUT method in the below condition in MessageVerifier?
From ,
if (!signedHeaders.contains("digest") && messageBody != null && messageBody.length > 0) {
signedHeaders.add("digest");
}
To add POST or PUT check as below,
if (!signedHeaders.contains("digest") && ((messageBody != null && messageBody.length > 0)
|| ("POST".equalsIgnoreCase(method) || "PUT".equalsIgnoreCase(method)))) {
signedHeaders.add("digest");
}

I think the test-case is valid, so please instead consider adding POST/PUT as you suggested above.

I think the test-case is valid, so please instead consider adding POST/PUT as you suggested above.

@coheigea @reta I have fixed the test case failure that was happening in systests/rs-security (JAXRSHTTPSignatureTest) by adding the required checks as discussed in MessageVerifier


react-native-session-is-not-created-when-imbed-html-and-js-in-webview

Reporting Bugs
I have created WebView like below in react-native.
<WebView
source = { require('./web/index.html') }
javaScriptEnabled={ true }/>
which works fine. But WebView won't save the cookie and store it.
When I request to rest api that requires session id, It prints out that it is undefined.
When I test this locally in browser, it works fine but not in react-native WebView.
When I use use URI and call remote url, it works fine either.
https://stackoverflow.com/questions/44515828/react-native-session-is-not-created-when-imbed-html-and-js-in-webview

Hey, thanks for reporting this issue!
It looks like your description is missing some necessary information. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.
I am going to close this, but feel free to open a new issue with the additional information provided. Thanks!


Add migrations for lower_page and targetings columns in ads table

These two columns are referenced in backend/server/model.rs
Without the migrations, the server was throwing an error about these missing columns.

@imalsogreg: You'll want to check out https://github.com/propublica/fbpac-api -- that's where these migrations live. (That repo contains a Rails API that runs the "admin" portion of the dashboard as well as, soon, the English language homepage.)

@jeremybmerrill Thank you for the info. That appears to be a private repo (I get a 404). Are the migrations there intended to be needed to run facebook-political-ads locally?

My bad: https://github.com/propublica/fbpac-api-public
Yes, they are intended to be needed to run it locally.

Hm, after getting familiar with fbpac-api-public and running a rake db:migrate from there without error, the facebook-political-ads server responds to /facebook_ads/ads request (triggered by a "Policital Ad" button click in the extension) with a 400, while the server logs something sounding 500y to stderr:
2018-07-03T17:43:02.881525071-04:00 WARN server::server - Error(DataBase(DatabaseError(__Unknown, "column \"targetings\" of relation \"ads\" does not exist")), State { next_error: None, backtrace: None })

Mentioning here on the PR (rather than in an issue) because it sounds related to this PR - like a missing migration for targetings column in ads table. In fbpac-api-public I see a mention of "targeting" in db/schema.rb. And facebook-political-ads has "targeting" in backend/server/migrations, but no "targetings" there. "targetings" appears in the rust server's ORM code.
Have run the migrations incorrectly, or should I make a PR against fbpac-api-public for adding the targetings column?
My database (called fbpac):
fbpac=> \d
                   List of relations
 Schema |            Name            |   Type   | Owner
--------+----------------------------+----------+-------
 public | __diesel_schema_migrations | table    | fbpac
 public | ads                        | table    | fbpac
 public | candidates                 | table    | fbpac
 public | candidates_id_seq          | sequence | fbpac
 public | close_races                | table    | fbpac
 public | close_races_id_seq         | sequence | fbpac
 public | electoral_districts        | table    | fbpac
 public | electoral_districts_id_seq | sequence | fbpac
 public | parties                    | table    | fbpac
 public | parties_id_seq             | sequence | fbpac
 public | partners                   | table    | fbpac
 public | partners_id_seq            | sequence | fbpac
 public | schema_migrations          | table    | fbpac
 public | states                     | table    | fbpac
 public | states_id_seq              | sequence | fbpac
(15 rows)

fbpac=> \d ads
                            Table "public.ads"
        Column         |           Type           |       Modifiers
-----------------------+--------------------------+------------------------
 id                    | text                     | not null
 html                  | text                     | not null
 political             | integer                  | not null
 not_political         | integer                  | not null
 title                 | text                     | not null
 message               | text                     | not null
 thumbnail             | text                     | not null
 created_at            | timestamp with time zone | not null default now()
 updated_at            | timestamp with time zone | not null default now()
 lang                  | text                     | not null
 images                | text[]                   | not null
 impressions           | integer                  | not null default 1
 political_probability | double precision         | not null default 0
 targeting             | text                     |
 suppressed            | boolean                  | not null default false
 targets               | jsonb                    | default '[]'::jsonb
 advertiser            | text                     |
 entities              | jsonb                    | default '[]'::jsonb
 page                  | text                     |
 lower_page            | character varying        |
Indexes:
    "ads_pkey" PRIMARY KEY, btree (id)
    "ads_lower_page_idx" btree (lower_page)
    "index_ads_on_advertiser" btree (advertiser)
    "index_ads_on_browser_lang" btree (lang)
    "index_ads_on_english_html" gin (to_englishtsvector(html))
    "index_ads_on_entities" gin (entities)
    "index_ads_on_german_html" gin (to_germantsvector(html))
    "index_ads_on_lang" btree (lang)
    "index_ads_on_page" btree (page)
    "index_ads_on_political_probability" btree (political_probability)
    "index_ads_on_political_probability_lang_and_suppressed" btree (political_probability, lang, suppressed)
    "index_ads_on_suppressed" btree (suppressed)
    "index_ads_on_targets" gin (targets)
Triggers:
    notify_on_update AFTER UPDATE ON ads FOR EACH ROW WHEN (old.* IS DISTINCT FROM new.*) EXECUTE PROCEDURE notify_update()

thx!

hey @imalsogreg sorry about that, our internal version got out of sync with the public one. I just added that migration.


Helm: add PrometheusRule  in operator, agent and hubble

Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Thanks for contributing!

Fixes: #issue-number
<!-- Enter the release note text here if needed or remove this section! -->

I am not 100% sure why this change is required. Can you give some more details or reference to github issue or slack discussion ?

I'm looping @aanm to have the last word, but my instinct is to say that we won't merge this.
Cluster operators can easily create these types of rules outside of the installation of the Cilium. We won't merge this unless you can give us a compelling reason why these rules ought to be a part of the Cilium installation process. There are lots of other components (Grafana, etc) that we could potentially add as additional initialization parameters to the helm chart, but keeping the helm chart minimal helps us to maintain Cilium better (it's already unwieldy as it is :sweat_smile:).
If you're interested in making helm contributions take a look at the good-first-issue area/helm issues.

@nathanjsweet So many projects have this feature.
https://github.com/kubernetes/ingress-nginx/tree/main/charts/ingress-nginx
https://github.com/fluent/helm-charts
All bitnami charts have PrometheusRule yaml
Alerting is part of the monitoring system. Today cilium has part integration in monitoring.
I add optional params, default disabled. Backward Compatibility is not broken

While cilium is not supporting this in main chart, we do have a bunch of examples/addons in examples directory. Below is the sample chart with prometheus and grafana.
https://github.com/cilium/cilium/tree/master/examples/kubernetes/addons/prometheus

@gandro @aanm I think we should reconsider this, and considering writing some of our own as well, and including them in our main helm chart.


Refactor BWA pipeline (resolves #225, resolves #246)

Change sphinx type to tuple[str]
Add to logToMaster
Fix call to inputs in resource requirements
Fix call to reference error
Refactor input dict to Namespace
Remove unnecessary argument shortcuts
Change --lb to --library in launch scripts
Remove s3 information from example config
Revamp README
Change tense of logToMaster given display of message to screen
Add back in if name .... boilerplate
Add launch script for no_alt single machine
Add logToMaster to job functions
Remove --pre from pip install toil suggestion
Remove shebang and if name ... boilerplate
Fix CLI and input dict
Rewrite pipeline to use bwakit only
Use common lib for downloading url
Add sphinx docstrings
Fix imports
Fix top-level docstring
Fix launch script arguments
Remove unnecessary bwakit validation steps
Rename download_inputs to download_sample
Use map_job instead of iterating over samples
Clarify assert for input
Simplify sample download
Remove unnecessary static DAG fn and copy_or_upload fn
Remove unnecessary config check if not locally present
Remove functions to replace with common lib
Move parser above main()

@hannes-ucsc — I tested this on Openstack, working on the CI component now.


Bug: HHL algorithm is going to be deprecated in favor of textbook explanation which uses deprecated HHL

Where does the issue happen?
https://learn.qiskit.org/course/ch-applications/solving-linear-systems-of-equations-using-hhl-and-its-qiskit-implementation
What is the content issue?
Qiskit Terra decided to deprecate HHL (among other things) in https://github.com/Qiskit/qiskit-terra/pull/8617.
In a follow up PR https://github.com/Qiskit/qiskit-terra/pull/8699, the deprecation message points to the textbook as an alternative. However, the textbook imports deprecated (in #8617) classes to explain linear system. The chapter should be written in independent terms (a la Shor) without using HHL classes.
Screenshots
No response
Additional information
No response

I believe this was fixed in https://github.com/Qiskit/platypus/pull/1577 ? Or is this issue asking for an implementation that only uses Terra (i.e. not an external package)?

ups! my bad! Fixed by https://github.com/Qiskit/platypus/pull/1577


[Doc Improvement] [Update tab app]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-gs-javascript.yml
91
40
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 0ef9c40:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/teams-toolkit-v2/first-tab/preview-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-tab/select-folder.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-tab/tap-app-created1.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-gs-javascript.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
5
link
:white_check_mark:

msteams-platform/sbs-gs-javascript.yml
91
40
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit a0a895f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-tab/preview-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-tab/select-folder.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-tab/tap-app-created1.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-gs-javascript.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 0071564:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-tab/preview-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-tab/select-folder.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/first-tab/tap-app-created1.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-gs-javascript.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
5
link
:white_check_mark:

msteams-platform/sbs-gs-javascript.yml
91
40
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Provider produced inconsistent result after apply - additional_trust_bundle

When providing additional trusted certificates via the proxy.additional_trust_bundle attribute the provider attempts to store a different value in the state than what Terraform expects. Causing Terraform to exit with the error (I've replaced the certificate bodies with ...)
rhcs_cluster_rosa_classic.rosa_sts_cluster: Creating...

 Error: Provider produced inconsistent result after apply

 When applying changes to rhcs_cluster_rosa_classic.rosa_sts_cluster, provider "provider[\"registry.terraform.io/terraform-redhat/rhcs\"]" produced an unexpected new value: .proxy.additional_trust_bundle: was cty.StringVal("-----BEGIN CERTIFICATE-----\n...\n-----END CERTIFICATE-----\n-----BEGIN CERTIFICATE-----\n...\n-----END CERTIFICATE-----\n"), but now cty.StringVal("REDACTED").

 This is a bug in the provider, which should be reported in the provider's own issue tracker.

I'm using Terraform v1.5.3 with rhcs version 1.2.2.

Hi @am90670 ,
Thank you for the feedback
We will check this and will update you as soon as possible

Jira ticket: OCM-3124

Is there an ETA on when this issue will be resolved?

Please put the jira ticket as a prefix to the PR title

Is there an ETA on when this issue will be resolved?

Hi @am90670 , no estimation on that yet

I have exactly the same issue, which is suspiciously similar to the case in #223 (failure when creating or updating a cluster proxy.additional_trust_bundle attribute), just no crash. I've attached my TF for validation.
Validation steps

Install Terraform CLI 1.5.2

Extract TF files into new, empty directory

Set auth vars for OCM and AWS SDKs
export AWS_DEFAULT_REGION=us-east-1 AWS_ACCESS_KEY_ID='<SEKRET>' \
  AWS_SECRET_ACCESS_KEY='<SEKRET>' \
  TF_VAR_token='<SEKRET>'

Initialize Terraform
rm -rf .terraform* terraform.tfstate*
terraform init

Create cluster without trust bundle (note API will not accept proxy config without subnet IDs, hence the VPC creation TF code)
unset TF_VAR_proxy_trust_bundle
terraform apply

After cluster creation, add trust bundle and apply changes (I'm grabbing the first three CAs from the default trust bundle on Fedora here, but any source should do).
export TF_VAR_proxy_trust_bundle="$(awk '$0 ~ /-----END CERTIFICATE-----/ { nc+=1 }; {if (nc >= 3) {print ; exit}}; {print}' /etc/pki/tls/certs/ca-bundle.crt)"
terraform apply

Expected result: cluster-wide proxy configured as requested
Actual result:
rhcs_cluster_rosa_classic.rosa_sts_cluster: Modifying... [id=[rosa_test_vpc.tf.txt](https://github.com/terraform-redhat/terraform-provider-rhcs/files/12423845/rosa_test_vpc.tf.txt)]
╷
│ Error: Provider produced inconsistent result after apply
│
│ When applying changes to rhcs_cluster_rosa_classic.rosa_sts_cluster, provider "provider[\"registry.terraform.io/terraform-redhat/rhcs\"]" produced an unexpected new value: .proxy.additional_trust_bundle: was
│ cty.StringVal("<LONG_PEM_STRING_OF_3_CAS>"), but now cty.StringVal("REDACTED").
│
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.
╵

Note that the "REDACTED" new value is from Terraform, not me. I did change the original value to "LONG_PEM_STRING_OF_3_CAS" for readability, however.
Terraform configs:
rosa_test_vpc.tf
rosa_test.tf

@cbell-work , @am90670
It should be fixed in v1.2.4, published today.
Thanks for taking the time to submit this issue. I truly appreciate it 👏🏽


Update conversation template to use the unified schema

cc: @CharlieFRuan
Need to rebase after https://github.com/mlc-ai/web-llm/pull/321 is merged.

cc: @CharlieFRuan Just rebased to the new main branch. Should be ready for review. Thanks!!


Outlined rep movsd instruction that clobbers existing variable causes incorrect data flow

Version and Platform (required):

Binary Ninja Version: 4.0.4896-dev
OS: macOS
OS Version: 14.3.1
CPU Architecture: M3

Bug Description:
This binary writes a value to offset 0x20 on the stack, then memsets the entire region, including the variable just written, to zero using a rep movsd instruction. It then returns the value at offset 0x20 on the stack. This will return zero, but Binary Ninja loses track of the data flow and says the function returns 0x20.
This bug does not occur if an actual call to memset is emitted. In that case, Binary Ninja sees the alias and prevents the data flow system from assuming the variable hasn't been clobbered.

repmovsd.zip

Fixed in 4.1.4919-dev.


feat: Move std::net dependencies to sys::net.

mio provides this great architecture where mio::net defines
user-friendly wrappers to system backends, i.e. sys modules like
sys::unix, sys::windows and sys::shell.
At every step, it's assumed that std::net is available. However,
depending on the backend a user would like to implement, std::net
might not be present. For example, it's assumed that
std::net::{TcpListener, TcpStream} are always available.
That's not always true.
This patch moves the responsability to the backends to declare —or
basically to re-export!— some types from std::net, such as:

std::net::TcpListener,
std::net::TcpStream,
std::net::UdpSocket,
std::net::SocketAddr,
std::net::{SocketAddrV4,SocketAddrV6},
std::net::{Ipv4Addr, Ipv6Addr}.

To achieve that, all of those types above related to std::net are
now in sys::net, those related to TCP are now in sys::tcp, and
finally those related to UDP are now in sys::udp.
It's actually consistent with types that were previously implemented in
sys like sys::tcp::TcpSocket.
With this patch, mio::net has no more dependency to
std::net. Everything comes from sys.

Note: The src/sys/unix/net.rs file is easier to review with the ?w=1 to ignore indentation changes, https://github.com/tokio-rs/mio/pull/1481/files?w=1.

mio provides this great architecture where mio::net defines
user-friendly wrappers to system backends, i.e. sys modules like
sys::unix, sys::windows and sys::shell.
At every step, it's assumed that std::net is available.

This is not true, only when the tcp/udp (or net in v0.8) is enabled is std::net required. Otherwise mio::net is not available.
Also I'm not sure what this change actually accomplishes, could you elaborate on what use cases this helps?

This is not true, only when the tcp/udp (or net in v0.8) is enabled is std::net required. Otherwise mio::net is not available.

Yeah correct, I was too prompt in my explanation, sorry for that.

Also I'm not sure what this change actually accomplishes, could you elaborate on what use cases this helps?

Everytime mio::net uses TcpListener, TcpSocket, TcpStream etc., their definitions come from mio::sys. Then it's up to the “backends” (sys module) to expose them. For the actual code, it's just a matter of re-exporting them.
But I'm working on an experimental WASI support, and thus I need to implement custom TcpListener, TcpStream and so on, types.  With this patch, it's so much simple :-). The “backends” are responsible to expose all the types manipulated by the mio::net “facades”/wrappers.
Thoughts?

This is not true, only when the tcp/udp (or net in v0.8) is enabled is std::net required. Otherwise mio::net is not available.

Yeah correct, I was too prompt in my explanation, sorry for that.

Also I'm not sure what this change actually accomplishes, could you elaborate on what use cases this helps?

Everytime mio::net uses TcpListener, TcpSocket, TcpStream etc., their definitions come from mio::sys. Then it's up to the “backends” (sys module) to expose them. For the actual code, it's just a matter of re-exporting them.

But isn't that the same as having std::net be the "backend" in the current code.

But I'm working on an experimental WASI support, and thus I need to implement custom TcpListener, TcpStream and so on, types.  With this patch, it's so much simple :-). The “backends” are responsible to expose all the types manipulated by the mio::net “facades”/wrappers.

I know wasi doesn't support sockets currently (or at least last I checked), but can't you turn of the net feature(s)? I still don't know what this pr actually changes.

Thoughts?

Also I have an wip (and now outdated) port of Mio to wasm in pr #1395.

But isn't that the same as having std::net be the "backend" in the current code.

If std::net is missing the type we want to implement, then we are blocked. In the case of wasm32-wasi, let's take the example of TcpListener: this type exists in std::net but it's full of unsupported!() definitions. Then we are blocked, we can't implement WASI support except by waiting on libstd to implement it.
But by “moving the std::net types inside” the backend, we can create a new “backend”, like you did in #1395, and create our own implementation of TcpListener. It's really useful for wasm32-wasi but it might be also useful in other contexts where Rust doesn't provide a complete implementation for std::net.
Basically, this patch replaces the imports from std::net to sys::net (and sometimes sys::tcp or sys::udp or sys::uds depending of the requested type).
:-)

But isn't that the same as having std::net be the "backend" in the current code.

If std::net is missing the type we want to implement, then we are blocked. In the case of wasm32-wasi, let's take the example of TcpListener: this type exists in std::net but it's full of unsupported!() definitions. Then we are blocked, we can't implement WASI support except by waiting on libstd to implement it.
But by “moving the std::net types inside” the backend, we can create a new “backend”, like you did in #1395, and create our own implementation of TcpListener. It's really useful for wasm32-wasi but it might be also useful in other contexts where Rust doesn't provide a complete implementation for std::net.

But if std lib doesn't provide TcpListener for a target than neither is Mio. I'm not going to maintain an entire socket implementation in Mio. Socket2 (which I also maintain) is a better place for that, the best being std lib of course.

Basically, this patch replaces the imports from std::net to sys::net (and sometimes sys::tcp or sys::udp or sys::uds depending of the requested type).

I can read that from the code, but what I want to know is what benefit does this bring to Mio over the current situation?
As far as I can tell wasm doesn't have a way to create a socket currently, so even with this patch accept the net features still won't work for wasm do they?


How I can fine-tune a new dataset?

Hi, thanks for your attention to our work.
Typically, it is easy to make your own data loader and load the pre-trained weights (eg, as the pre-trained model we provided) as initial parameters.
Then, you can fine-tune it on the novel datasets.
Hope it helps!


fix bugs in order to use easily

because othre program update , this project have some error, and i change it to user python3, and fix iterm2 bugs in macos.

i already fixed


CocoaPods: No such module 'Usercentrics' [BUG]

Hi,
Describe the bug
If we use the latest version of CocoaPods, we get the following error:

Failed to build iOS app
Swift Compiler Error (Xcode): No such module 'Usercentrics'
/Users/ci/.pub-cache/hosted/pub.dev/usercentrics_sdk-2.10.0/ios/Classes/Bridge/AcceptAllBridge.swift:0:7

The error occurs with version 1.15.1 of CocoaPods. It still works with version 1.14.2.
Could you please assist us with this?
We were able to reset CocoaPods to the still working version with these commands if anyone else encounters this issue:
brew uninstall cocoapods
wget https://raw.githubusercontent.com/Homebrew/homebrew-core/e8e04dd35a5151d5fa1f094aacf404277f552c40/Formula/c/cocoapods.rb
brew install -s cocoapods.rb

To Reproduce
Steps to reproduce the behavior:

Build app with CocoaPods 1.14.2
The build process is successful
Update CocoaPods to 1.15.1
Now, the build fails with the previously mentioned error message

Expected behavior
The build shouldn't fail obviously.
Flutter doctor

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.13.1, on macOS 14.1.2 23B92 darwin-arm64, locale de-DE)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.1)
[✓] VS Code (version 1.86.0)
[✓] VS Code (version 1.73.1)
[✓] Connected device (3 available)
[✓] Network resources
• No issues found!

usercentrics-flutter-sdk branch/commit
Usercentrics 2.11.3

Hi,
same problem here.

Hey guys,
I'll have a look and let you know as soon as I have any updates.
Cheers,
Rui

Also, what happens if you try to install cocoapods using gem instead of brew, like
sudo gem install cocoapods.
This is actually a better way to manage your cocoapods versions, as you can simply do
sudo gem uninstall cocoapods to rollback a cocoapods upgrade to an older version.
I have tried the following:

Install cocoapods 1.14.2,
pod install
build/run app
upgrade cocoapods to 1.15.2
pod install
run app
This worked successfully, always managed to run app (in Xcode).

Can you please try that?
Cheers,
Rui

It seems to be fixed in 1.15.2. Thanks for your quick response. 👍