Maps don't appear when printing

This is a really odd bug, but when trying to print a page in chrome with this directive on, the map doesn't display. For example try and print the demo page and you'll see what I mean:
http://ngmap.github.io/basics.html#/map-simple#map-simple
However if you try with other GM directives it prints OK:
http://angular-ui.github.io/angular-google-maps/#!/
I had a look to see if I could work out what was causing it but I couldn't find anything that might be causing it. If you could work out a fix that would be great, thank you!

This is related to css of ngmap.github.io, especially media tag of css.
However, this is not related to this module. This module does not prevent browser from printing the map.
I have copy/pasted this issue to https://github.com/ngmap/ngmap.github.io/issues/1, and will make a fix in that repo.
Thanks for the reporting.

Odd, it's happening in our app as well and we don't have any media="screen" tags on our stylesheets - any ideas?

I believe that It is related to css.
If you can print out this page, https://rawgit.com/allenhwkim/angularjs-google-maps/master/testapp/map-simple.html., that means this module does not prevent printing.

OK thanks for the help!

I realised the issue was being caused by bootstrap, this was the fix for anyone else having the same problem:
@media print {
  img {
    max-width: none !important;
  }
}

If anyone happens to find their way here because they're missing tiles when printing (but not the whole map), I found another CSS solution that works:
ng-map div > img {
	position: absolute;
}


nim_lk: 20240210 -> 20240510

Description of changes
Update to fix bugs that created duplicate lockfile entries.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Okay, I'll try to fix that and update this PR when I do.

As Nim developers like to say, "works on my machine". Must be something about your local environment, maybe something your git tools are doing.

Actually it works on x86 linux after all, so either something with my env or macos.

https://github.com/NixOS/nixpkgs/issues/308593 seems I'm not the only one with this issue.


chore(docs): fix capitalization in docs/README.md

Library was spelt LIbrary with both L and I capitalized

Thank you for the fix @prabhupant!


Replaced blur and change bound actions as form props

No reason not to provide these.
Addresses #1579.

Published in v6.0.1.


Disabling the component

Is there a way to disable the view like button.setEnabled(false) (This one isn't working) ?

Well I resolved it meanwhile. If anyone cares this is what I have done:
private static void setViewAndChildrenEnabled(View view, boolean enabled) {     view.setEnabled(enabled);     if (view instanceof ViewGroup) {         ViewGroup viewGroup = (ViewGroup) view;         for (int i = 0; i < viewGroup.getChildCount(); i++) {             View child = viewGroup.getChildAt(i);             setViewAndChildrenEnabled(child, enabled);         }     } }
And then calling the method onto MultiStateToggleButton:
setViewAndChildrenEnabled(toggle,false);


State should be reset when React component unmounts

Seeing an issue where the previous state is recycled after tearing down the component and creating a new one.

Hitting this issue in the emulator as well.

Eric I'm assigning this to you because I think it likely has to do with your global state thingie, which I don't understand at all.

Happy to take it, but not certain it has to do with the global thingie. I think the issue may be that destruction of the Chat component doesn't reset the Redux store.

Right now Chat isn't a component, it's just a function. I suspect we'll need to turn it back into a component and have it be responsible for clearing your global thingie.

I wonder if we need a Redux store per Chat component (if it were a component), to support multiple instances of the component.

I wonder if we need a Redux store per Chat component (if it were a component), to support multiple instances of the component
Yeah I think this is what we get "for free" if we turn the Redux store into a private member of the component.

Oh yeah we probably do.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Eric Anderson<EMAIL_ADDRESS>Sent: Friday, October 28, 2016 12:24:25 PM
To: billba/botchat
Cc: Bill Barnes; Comment
Subject: Re: [billba/botchat] State should be reset when React component unmounts (#86)
I wonder if we need a Redux store per Chat component (if it were a component), to support multiple instances of the component.

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/billba/botchat/issues/86#issuecomment-256797713, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKiet9qN77XaR2oAaBr4gX-tvBRwgMWYks5q4TKpgaJpZM4Ki1aX.

Could be. Check with me before doing anything drastic.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Dan Marshall<EMAIL_ADDRESS>Sent: Friday, October 28, 2016 12:26:48 PM
To: billba/botchat
Cc: Bill Barnes; Comment
Subject: Re: [billba/botchat] State should be reset when React component unmounts (#86)
I wonder if we need a Redux store per Chat component (if it were a component), to support multiple instances of the component
Yeah I think this is what we get "for free" if we turn the Redux store into a private member of the component.

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/billba/botchat/issues/86#issuecomment-256798084, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKiet0XyKTzk2ygGWDlUb_M2jxiJgQZOks5q4TM4gaJpZM4Ki1aX.

I'm going to give it a try in my working branch.

Ok, I tried this and it works great for the Chat control itself; doesn't complicate things and also gets rid of a dread global. Problems arise with the DebugView. Because it is a peer component of Chat there isn't a clean way to get them to share Chat's Redux store. I was considering taking DebugView out of BotChat anyway, because it turns out to be less useful than what we could build directly in the emulator. In the emulator we participate in all sides of the conversation (chat<->directline<->botframework<->bot) and can therefore log all http requests and responses rather than just showing activity json.

I have a PR in the works for this, but even with this change, I had to do an additional thing in my app to get React to create new Chat instances. React caches and reuses components according to a heuristic that works for most use cases, but not in this one. To force a new instance to be created, I had to make sure the key prop changed each time:
return <BotChat.Chat key={ Math.random() } { ...props } />

In addition to that, I needed to implement a shouldComponentUpdate to ensure it only recreated the component when it really needed to (otherwise, it would recreate whenever anything in the store changed).
How React "diffs" component states:
https://facebook.github.io/react/docs/reconciliation.html

I’m a little surprised about the last part. Since the store is an internal part of the Chat, how could it make its parent be recreated?
From: Eric Anderson<EMAIL_ADDRESS>Reply-To: billba/botchat<EMAIL_ADDRESS>Date: Friday, October 28, 2016 at 7:35 PM
To: billba/botchat<EMAIL_ADDRESS>Cc: Bill Barnes<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [billba/botchat] State should be reset when React component unmounts (#86)
I have a PR in the works for this, but even with this change, I had to do an additional thing in my app to get React to create new Chat instances. React caches and reuses components according to a heuristic that works for most use cases, but not in this one. To force a new instance to be created, I had to make sure the key prop changed each time:
return <BotChat.Chat key={ Math.random() } { ...props } />
In addition to that, I needed to implement a shouldComponentUpdate to ensure it only recreated the component when it really needed to (otherwise, it would recreate whenever anything in the store changed).
How React "diffs" component states:
https://facebook.github.io/react/docs/reconciliation.html
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/billba/botchat/issues/86#issuecomment-256847104, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKiet1KGGa495JTTlZFRfNEeIL31KLUdks5q4Ze9gaJpZM4Ki1aX.

Oh, sorry I wasn't clear! My app has its own Redux store. shouldComponentUpdate runs on a component in my app, and determines whether it needs to recreate the Chat component.

Aha, got it.
From: Eric Anderson<EMAIL_ADDRESS>Reply-To: billba/botchat<EMAIL_ADDRESS>Date: Friday, October 28, 2016 at 7:46 PM
To: billba/botchat<EMAIL_ADDRESS>Cc: Bill Barnes<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [billba/botchat] State should be reset when React component unmounts (#86)
Oh, sorry I wasn't clear! My app has its own Redux store. shouldComponentUpdate runs on a component in my app, and determines whether it needs to recreate the Chat component.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/billba/botchat/issues/86#issuecomment-256848587, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKiet44Qg79qXCNWbD1ciE0nUwM9QHeLks5q4Zo6gaJpZM4Ki1aX.

@eanders-MS for the  key={ Math.random() } there is still a chance of collision (albeit small). Is there a more deterministic approach we can take? Perhaps getting this from props, or deriving it somehow from existing props?

key={ this.reuseKey++ }, or use a proper guid.

+1 for this.reuseKey++
From: Eric Anderson<EMAIL_ADDRESS>Reply-To: billba/botchat<EMAIL_ADDRESS>Date: Saturday, October 29, 2016 at 6:43 AM
To: billba/botchat<EMAIL_ADDRESS>Cc: Bill Barnes<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [billba/botchat] State should be reset when React component unmounts (#86)
key={ this.reuseKey++ }, or use a proper guid.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/billba/botchat/issues/86#issuecomment-256983144, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKietyzCrOYt2o8l71eq1EbAX2S_nX38ks5q4jQpgaJpZM4Ki1aX.

Fixed by Eric's checkin.


create and style navbar, insert in login component to test

Description
created navbar using fontawesome icons. It is currently nested in the login component for testing purposes.
How to test
upon running server and loading in simulator, login screen should appear with navbar at bottom of screen. click on respective icons for userprofile, friendslist, and dashboard to test navigation functionality.
Notes
note that I modified the styling of the styles.container to fit the navbar at the bottom of the screen, as well as added additional styling to the  containing the navbar in the login component. As other components get fleshed out, the Navbar component will have to be nested accordingly (note how props are currently passed into the Navbar from the Login component) and container styling adjusted.
Issue tracking
(https://trello.com/c/w8oYLqiw/31-create-navbar)

 Create navbar


booleans JS tutorial

Populate JS file with a tutorial and challenge.

May I work on this?

Sure @Raghav-Modani , assigned now

Hii @sabderemane! Opened a pull request -> #47  linked with this issue. Please review it.


Disable Ctrl-A shortcut to select all (conflicts with emacs keybindings)

Is your feature request related to a problem? Please describe.
I use emacs keybindings in GTK on Linux. The ctrl-a shortcut, which selects all text, conflicts with the emacs keybinding to jump to the beginning of the line. Strangely, the conflict does not exist for, eg, ctrl-e. This is through the gtk-key-theme "Emacs" setting.
Describe the solution you'd like
Ability to disable ctrl-a shortcut.

In fact, I hope I could just selectively disable some of the keyboard shortcuts in .tusk.json
I am on linux. Changes to ~/.tusk.json do not take effect, but changes to ~/snap/tusk/16/.tusk.json sort of take effect:
If I change a keybinding, eg, the final one becomes
"underline": "Ctrl+Shift+U"

then the new keybinding still works properly. But, the old keybinding (Ctrl+U) also works.
I would like to specify exactly the keybindings in .tusk.json...is it possible?
Thank you!


Can't save Drafts or Send e-mail issues

**RainLoop version, browser, OS: 1.17, Chrome and Firefox
**Expected behavior and actual behavior: To send e-mail and save drafts
**Steps to reproduce the problem: Typing e-mail, then try to save or send e-mail got error. If e-mail contain this string Data: I go the error, as you can see on the Screenshots
Logs or screenshots:

Hey Danzign, have you been able to solve the issue? I Have had the same for a while and I can´t decide what could have caused it. I would love to hear from you!


Inconsistent type inference on hover vs autocompletion

TS Template added by @mjbvz
TypeScript Version: 4.4.0-dev.20210713
Search Terms

react
prop-types
jsx

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.58.2 (was happening before this version as well)
OS Version: Mac OS 10.14

Steps to Reproduce:

Create a React functional component like this:

import React from "react";
import PropTypes from "prop-types";

//  vscode is able to infer the types correctly in autocomplete
// as this is a functional component, with prop types
// Please note that vscode still does not show the correct types
// when hovering on the component usage

function MyComponent({ prop1, prop2, prop3 }) {
  return (

      {prop1}
      {prop2}

  );
}

MyComponent.propTypes = {
  prop1: PropTypes.string.isRequired,
  prop2: PropTypes.bool,
  prop3: PropTypes.shape({
    p1: PropTypes.string
  })
};

MyComponent.defaultProps = {
  prop2: false
};

export default MyComponent;

At the point of usage, where you have imported this component, hover on the usage, you will see that vscode is able to identify the function signature, but not the types of the function arguments, and shows them as any

If you hovber over the specific prop though, you would see that vscode shows the correct type (inferred from prop types) and also provides autocompletion for the prop name. (Although there is still an issue that it shows all the props as optional)

Example:
https://codesandbox.io/s/vscode-intellisense-proptypes-fc-w-destructuring-w-proptypes-cngth?from-embed=&file=/src/MyComponent.js:0-655
Expectation:
I would have expected that

vscode would be able to infer the types on hovering as well, same as it can do while providing autocomplete suggestion for the prop
vscode would not show all the props as optional, since it seems that it can infer prop names and types from prop types, it should also be able to infer whether it is required or optional.

What’s being shown is correct. The types of prop1, prop2, and prop3 at/in the MyComponent declaration are all any, and that’s what quick info is showing. However, JSX support in TypeScript allows JSX environments (like React) to define a type called LibraryManagedAttributes which takes the type of the component being created in JSX and declared type of the props, and it can return a new type to be used for the type of the props that you actually pass in JSX, which is how React is able to use the .propTypes to infer actual types for JSX props. However, that has no effect on the props outside of JSX element creation. You can hover prop1 on the JSX element itself and it shows the JSX props type. Hovering MyComponent simply shows the parameter type of the MyComponent function, separate from any augmentation via JSX.

ok
so:

there is no easy way for vscode to use the LibraryManagedAttributes in quick info ?
the props are shown as optional because of how the JSX environment infers the prop types, and that cannot be fixed? if yes, can raise a issue for this in appropriate repo, if you can point me to it.

We could choose to make some sort of JSX-specific quick info while hovering JSX element components, but would need a proposal for what that should look like.
Not sure what the problem is with regard to optional props; looks like completions correctly shows prop1 as required and prop2 and prop3 as optional, which is what the PropTypes info says.

screenshot showing prop1 is required but also optional

That seems to be some sort of artifact of our looser JS checking for functions with untyped parameters. It might be something we can improve, but note that all these problems go away if you just add proper JSDoc parameter annotations on MyComponent.

yeah, we have been using jsdoc comments in some cases as well, but that just adds up one more point for documentation. We use proptypes for dynamic type checking, if we add jsdoc comments as well, that slightly duplicates the effort. Some of the tools that we use can read comments on the prop types and generate documentation, so we add comments there anyway, we would need to repeat that in jsdoc

I’ve moved that to #45223


session.get_candle() problem if market closed

The response status is 200 but, as expected, no data point is available. This causes the code in line 233 in the session.py to crash.
start_day = WEEKEND
session.get_candle(symbols=['VIXY'], interval='5m', start_time=start_day)
leads to:
KeyError: <EventType.CANDLE: 'Candle'>

Can you add more context? E.g. what date is WEEKEND?

It appears to be an edge case. The data from yesterday didn't work yesterday but is functioning today. The data from today isn't working at the moment. Regardless, if data = response.json()[EventType.CANDLE] in session.py line 233 doesn't contain candle data, the code crashes. This could be easily fixed by validating whether the key exists in the response dict().
from datetime import datetime, timezone
from tastytrade import ProductionSession
session = ProductionSession('USER', 'PW')
start_day = datetime(2023, 11, 12, tzinfo=timezone.utc) # THIS is TODAY
print(start_day)
data_history = session.get_candle(symbols=["VIXY"], interval="5m", start_time=start_day, end_time=None)

Ah, makes sense now. So the market is closed weekends, the data you're trying to fetch doesn't exist.
I'm going to close this, your fix would prevent the crash but since this is incorrect usage I think the error is appropriate.

I would agree if the behavior was consistent. Yesterday's date works today, but not yesterday. If I set extendet tradfing hours to True, the date no longer works. There are some combinations that work but not 100%.

Yesterday's date was also invalid though.
Since this is an SDK, it's not unexpected that an error would be thrown by illegal/nonsensical requests. If you for some reason need to cover those cases, you can use error handling in your application.


Multiple Languages(Japanese)

Could you publish the source? I want to make pull request to correspond to Japanese.

Sure, I'll push the language module soon, I just need to update English translation file.
Will let you know

Thanks English file update.
Japanese Nemster translate English to Japanese Now.
(sorry Poor English)


Graphene-spline example broken

The example is broken in 2 places:
The most important while running this:
python3 ../../relaxed_scan.py -k 0.5 -q -0.00 --tipspline TipRSpline.ini
it has this error:
Traceback (most recent call last):
  File "../../relaxed_scan.py", line 139, in <module>
    fzs,PPpos,PPdisp,lvecScan=PPH.perform_relaxation(lvec, FFLJ, FFel, FFboltz,options.tipspline)
  File "/m/home/home8/88/krejcio1/unix/Program_Files/PPAFM_main/ppafm/HighLevel.py", line 102, in perform_relaxation
    FF += FFboltz

The 2nd problem is connected with npy and #53 ; in Pull Request #73 commented out temporatily!

We will delete this functionality together with the example.


[GPT-23] Events: Replace Elfsight Widget

The Elfsight Widget we have been using has been quite buggy and may not be suitable for the technical MVP #140
It should ideally be replaced by another widget/ page
Ideally it should be a Card View (or other better view) of Events Sorted by Date (most recent one first).
We could add posts tagged #events, which would then be listed in the events page. Other technologies such as AlpineJS and more may help
GPT-23

Might be useful: https://ghost.org/docs/themes/routing/

Or Loxi, see https://loxi.io

Experiments with Loxi Widget

I think the Loxi Widget looks decent enough on the website

Filtering options look usable

Date filtering looks usable (at the very least, people can scroll through the months to identify events)

Some downsides may be the colour scheme of loxi, which is green, and that the widget may seem too wide? (at the very least, when viewing an event, it is a chore to scroll down, but may be solvable with custom CSS)


Notifications continue to disappear from notifications showing no notification present next to the bell

Describe the bug
I installed my HP printer with the HPLIP utility. I printed a test page. I got a notification toast that it was preparing to print. It went into the notification center for a few seconds, showed 1 notification next to the bell and then disappeared. I got another notification toast that I had successfully printed a page. Same thing toast disappears. The notification goes into the notification center, shows 1 notification then disappears. I also tried "notification send test" and that does work properly. I get the notification toast and then it goes into the notification center and stays there showing 1 notification until I dismiss it
To Reproduce
Try to get a system event to generate a notification other than notification send test.
Expected behavior
The notification should stay in the notification center and display the number of notification present until I dismiss them.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Distribution: Arch
Window Manager/Desktop Environment: Hyprland

There is a timeout setting I'll expose in the work for this issue. If a notification has a timeout, they automatically get dismissed after the timer runs out by Astal Notifd.

@onefish2 You can disable auto-dismissal of notifications with a timeout now in Configuration > Notifications > Automatically Dismiss and disable the setting.

Amazingly fast response. Thank you.


[Decompiler] 128-bit bitfield types

These are not properly supported. Consider the type res-tag:
(deftype res-tag (uint128)
  ((name        symbol  :offset 0)
   (key-frame   float   :offset 32)
   (elt-type    type    :offset 64)
   (data-offset uint16  :offset 96)
   (elt-count   uint32  :offset 112 :size 15)
   (inlined?    uint8   :offset 127 :size 1)
   )
  :flag-assert #x900000010
  )

A field located in the upper 64 bits is accessed through pcpyud dest src r0 followed by the usual bit shift operations.
A field located at bit 64 and with size 32 is accessed through pextuw dest r0 src
128-bit copy is done through por dest src r0

Examples of unsupported POR instructions can also be found in:

hud
settings

Fields in the lower 64 bits seem to be treated just like 64-bitfields.
In method 2 vec4s a field at bit 64 with size 32 is accessed with:
    pcpyud v1, gp, r0
    sllv t0, v1, r0

and not pextuw.  I am not sure what the difference here is.  In res it definitely used pextuw for accessing the elt-type field of res-tag.

I looked at all of the pextuws in the game, and it's only used with the r0 in res and actor-link, where it's also accessing a res-tag.  Maybe this was a macro?   The decompiler should support both pextuw and pcpyud/sllv for accessing a field like this.

It might be because type is a reference (32-bit value) and thus it makes sense to copy it using the operation that outputs a 32-bit vlue?

That's a good point.  Both examples are 32 bit values, but the pextuw one should be zero extended and the sllv one should be sign extended.  (The GOAL compiler sign extends 32-bit floats for some reason).

Most of the 128-bit bitfield stuff should work. POR is recognized as a move for 128-bit variables and bitfield extraction should work in all cases.  I'm leaving this open for now because there will probably be other tricks that we haven't encountered yet.

see res-lump method 15 for some settings stuff.

sound-name= isn't extracting upper 64 bit fields correctly.

There may be stuff we haven't seen yet, but for now res and gsound both pass the offline tests.  Setting bitfields is a bit ugly looking in the output (during a set, it copies the 128-bit bitfield to another variable, if it is valid to do so), but it at least works.


protoc-gen-tonic: 0.3.0 -> 0.4.0, protoc-gen-prost: 0.2.3 -> 0.3.1, protoc-gen-prost-serde: 0.2.3 -> 0.3.0, protoc-gen-prost-crate: 0.3.1 -> 0.4.0

Description of changes
Updates to protoc-gen-{tonic,prost{,-crate,-serde}}:

migrate packages to pkgs/by-name
add update scripts
update packages to latest versions

Supersedes #296892
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 321761 run on x86_64-linux 1

4 packages built:

protoc-gen-prost
protoc-gen-prost-crate
protoc-gen-prost-serde
protoc-gen-tonic

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/1016/149


Release on Flathub

A release on Flathub would be great.

Will target for 0.17

I have submitted to flathub and am awaiting approval.

We are on flathub!


Add and populate Zone.country_code field

I'm trying to build region polygons for nearly all of the countries in the world, but I need separate per-country output (i.e. easily group all zones of a given country).
I was originally doing this by having a list of country codes and indexing into the Geofabrik index to obtain the specific country's PBF extract. However, some country codes are entirely missing from the Geofabrik index, such as ae which I believe is in the catch-all GCC States extract.
That's something I can manually fix by adding my own index entries locally, but it makes me think that maybe I should just be running Cosmogony against the entire planet PBF. The only wrinkle in this is that in order to get per-country output, I would need to then analyze the output to construct the geographic hierarchy to know what zones belong to what countries. This is certainly doable, but seems like an unnecessary burden on the user of Cosmogony when Cosmogony seemingly already has this information.
This PR adds a new country_code field to the Zone struct.
I tested this on the aforementioned GCC States PBF extract and sure enough it populated the field as expected.

You certainly know this but you can output the cosmogony as json lines (with .jsonl extension), this way it's very easy (and memory efficient) to stream and split the file.

Thanks, I did find this out and was thankful for it!
I was actually initially looking to use Cosmogony as a library so that I can skip the JSON serialization step entirely and work directly with Zones, which I then want to pack into an sqlite db.
Using .jsonl.gz works fine enough, but I was curious if you all were against the use of Cosmogony as a library? I believe I'm talking about the cosmogony_builder crate which isn't pushed to crates.io (nor does it seem re-exported through cosmogony), and the function I'm thinking of in particular build_cosmogony() isn't exposed through the cosmogony crate either from what I could tell. Or am I thinking about it the wrong way?

I have no problem with publishing it as a crate, I think it's just that nobody had any use for it yet.
At one point we also considered the implementation of a postgis output (#24) but ultimatly the use case did not seem very important.

Should the country_code field be a String rather than an Option<String>? I just realized that if the country code isn't known, then the zone_type won't be set so the zone will be pruned away, so the country_code will always be set, AFAIK.
I guess one reason for not making it a direct String would be for backward-compatibility, where if we made it String, then new versions of Cosmogony wouldn't be able to read older versions.
Then again, I think that can be fixed with a serde directive to set it to "" by default if missing.

I was actually initially looking to use Cosmogony as a library so that I can skip the JSON serialization step entirely and work directly with Zones, which I then want to pack into an sqlite db.
Using .jsonl.gz works fine enough, but I was curious if you all were against the use of Cosmogony as a library? I believe I'm talking about the cosmogony_builder crate which isn't pushed to crates.io (nor does it seem re-exported through cosmogony), and the function I'm thinking of in particular build_cosmogony() isn't exposed through the cosmogony crate either from what I could tell. Or am I thinking about it the wrong way?

The cosmogony crate provides the deserialization functions to read the cosmogony output without the dependencies related to geometric operations. So it's intentional for it not to include the functions used to build the cosmogony. Also note that build_cosmogony will typically run for several hours on large inputs, so in our use case it simply made more sense to reuse the output file separately.
If you have a specific use case, or would be interested in an additional output format, I would be happy to discuss it in another issue.

Should the country_code field be a String rather than an Option<String>? I just realized that if the country code isn't known, then the zone_type won't be set so the zone will be pruned away, so the country_code will always be set, AFAIK.
I guess one reason for not making it a direct String would be for backward-compatibility, where if we made it String, then new versions of Cosmogony wouldn't be able to read older versions.
Then again, I think that can be fixed with a serde directive to set it to "" by default if missing.

I am ok with Option<String>, both for backward-compatibility and also because conceptually we could consider adding zones that are not within a single country (unions of countries, disputed areas, etc.).
This PR looks good to me to merge, if you don't have any more questions.

No more questions. Please feel free to merge, I don't appear to have the permission to do so.
Can we get a release out that includes this change as well?
Thank you for building cosmogony!


Quantization related issues

Fix #200 and #176

Yep, tested it both on GPTQ and bitsandbytes models


Y022 - Naming Conventions For Functions Inside IIFE

Are named functions used in this pattern solely for easier debugging?
/* recommended */
angular
    .module('app')
    .controller('SomeController', SomeController);

function SomeController() { }

I have been using an internal naming convention to easier isolate the controller name when fuzzy searching:
angular
    .module('app')
    .controller('SomeController', Internal);

Internal.$inject = [];

function Internal() { }

Same naming for injector and function name also help a lot when you want to rename something.


Suggestion for improving Publication Date

Hey! First, thanks for making this template. I'm using it to make my own personal template for static sites and I appreciate all the work you've done (especially for SEO).
In my readings online, I've read that Google has some suggestions around publication dates. They suggest using labels like "Published" or "Last Updated".
Would you accept a PR to change this to this:
function publishDateToMachineFriendlyDate(publishDate) {
  return new Date(publishDate).toISOString()
}

const machineFriendlyDate = publishDateToMachineFriendlyDate(publishDate)

---
    <p>Last updated: <time datetime={machineFriendlyDate}>{publishDate}</time></p

Although this is a good suggestion I think it might be too opinionated of a change to assume for everyone. I might take that suggestion for my own personal blog but I went through about 5 blogs I regularly read and none of them had "Last Updated" or "Published" in front of the date. Even Google's own blog doesn't follow this format surprisingly.

Fair point! Wow, that's ironic 😅 well thank you for hearing my idea and sharing your thoughts. I'll close this for now then.


Include gocritic, gosec and staticcheck versions

🗣 Description

This PR is to track the versions for GoCritic, GoSec and Staticcheck into this repo so it can be consumed/used in GitHub Actions workflows.
💭 Motivation and context

This change is based on current team practices.
🧪 Testing

Pre-commit verified syntactical accuracy.

✅ Pre-approval checklist

[X] This PR has an informative and human-readable title.
[X] Changes are limited to a single goal - eschew scope creep!
[X] All relevant type-of-change labels have been added.
[X] I have read the CONTRIBUTING document.
[X] These code changes follow cisagov code standards.
[X] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[x] All new and existing tests pass.

@jasonodoom - Please note that I added back into the PR description a checkbox that you deleted in what I assume was an accident of haste.

@jasonodoom - Please note that I added back into the PR description a checkbox that you deleted in what I assume was an accident of haste.

@jsf9k It definitely was. 😓 Thank you!

I don't think this PR should be merged until this conversation is resolved.

That conversation is now resolved.

I don't think this PR should be merged until this conversation is resolved.

@jsf9k but this has to be merged first to pull in the defined package versions no?

I don't think this PR should be merged until this conversation is resolved.

@jsf9k but doesn't this have to be merged first to pull in the defined package versions? I can actually test in a different branch but the builds from generic will fail if this isn't merged first.

@jasonodoom - Please see here.  I temporarily modified the GitHub Actions workflow in cisagov/skeleton-generic to use this branch to get around this very issue.


Build error installation

I'm trying to install mc_rtc release 1.4.0 on Ubuntu 18.04.5 LTS. However, building from the script provided in the tutorial results in an error, where it says tests 20-39 fail. I included the log-file and copied the error message below:
build_and_install_warnings-2020-09-23-11-39-07.log
The following tests FAILED:
20 - TestPostureController (SEGFAULT)
21 - TestPostureControllerLog (Failed)
22 - TestPostureControllerThreadedLogging (SEGFAULT)
23 - TestPostureControllerThreadedLog (Failed)
24 - TestPostureController2 (SEGFAULT)
25 - TestPostureControllerControllerSwitchThreadedLog (Failed)
26 - TestPostureController2ControllerSwitchThreadedLog (Failed)
27 - TestCoMTaskController (SEGFAULT)
28 - TestPositionTaskController (SEGFAULT)
29 - TestOrientationTaskController (SEGFAULT)
30 - TestEndEffectorTaskController (SEGFAULT)
31 - TestObserverController (SEGFAULT)
32 - TestSampleController_CoM (Failed)
33 - TestSampleController_Body6d (Failed)
34 - TestSampleController_Posture (Failed)
35 - TestSampleController_Text (Failed)
36 - TestSampleController_FSM (Failed)
37 - TestSampleController_LIPMStabilizer (Failed)
38 - TestPythonController (Failed)
39 - TestPythonLog (Failed)
Errors while running CTest
-- [ERROR] Testing is still failing for mc_rtc, please investigate deeper
Installation failed.
Installation log has been written to /tmp/build_and_install_warnings-2020-09-23-11-39-07.log
Please fix the issues and re-run the script.
I have no clue what the issue could be, so I would love to know what I could do to fix it. Thanks in advance!

Hi @jari-van-steen
Thanks for attaching the build log, it's very useful to pin down the issue.
Looking at TestPostureController, we have:
test 20
      Start 20: TestPostureController

20: Test command: /home/jarivansteen/mc_rtc/build/tests/test_controller_ticker "--run_test=RUN" "--" "/home/jarivansteen/mc_rtc/build/tests/controllers/TestPostureController/mc_rtc-TestPostureController.conf" "400"
20: Test timeout computed to be: 1500
20: Running 1 test case...
20: [info] Loading default global configuration /usr/local/etc/mc_rtc.yaml
20: [info] Loading additional global configuration "/home/jarivansteen/.config/mc_rtc/mc_rtc.yaml"
20: [info] Loading additional global configuration /home/jarivansteen/mc_rtc/build/tests/controllers/TestPostureController/mc_rtc-TestPostureController.conf
20: [info] Enabled plugins:
20: [info] GUI server enabled
20: [info] Will serve data on:
20: [info] - ipc:///tmp/mc_rtc_pub.ipc
20: [info] - tcp://*:4242
20: [info] Will handle requests on:
20: [info] - ipc:///tmp/mc_rtc_rep.ipc
20: [info] - tcp://*:4343
20: [info] Create controller TestPostureController
20: [warning] No calibration file /home/jarivansteen/catkin_data_ws/src/mc_rtc_data/jvrc_description/calib/jvrc1/calib_data.RightFootForceSensor found for force sensor RightFootForceSensor
20: [warning] No calibration file /home/jarivansteen/catkin_data_ws/src/mc_rtc_data/jvrc_description/calib/jvrc1/calib_data.LeftFootForceSensor found for force sensor LeftFootForceSensor
20: [warning] No calibration file /home/jarivansteen/catkin_data_ws/src/mc_rtc_data/jvrc_description/calib/jvrc1/calib_data.RightHandForceSensor found for force sensor RightHandForceSensor
20: [warning] No calibration file /home/jarivansteen/catkin_data_ws/src/mc_rtc_data/jvrc_description/calib/jvrc1/calib_data.LeftHandForceSensor found for force sensor LeftHandForceSensor
20: [warning] No calibration file /home/jarivansteen/catkin_data_ws/src/mc_rtc_data/jvrc_description/calib/jvrc1/calib_data.RightFootForceSensor found for force sensor RightFootForceSensor
20: [warning] No calibration file /home/jarivansteen/catkin_data_ws/src/mc_rtc_data/jvrc_description/calib/jvrc1/calib_data.LeftFootForceSensor found for force sensor LeftFootForceSensor
20: [warning] No calibration file /home/jarivansteen/catkin_data_ws/src/mc_rtc_data/jvrc_description/calib/jvrc1/calib_data.RightHandForceSensor found for force sensor RightHandForceSensor
20: [warning] No calibration file /home/jarivansteen/catkin_data_ws/src/mc_rtc_data/jvrc_description/calib/jvrc1/calib_data.LeftHandForceSensor found for force sensor LeftHandForceSensor
20: [info] MCController(base) ready
20: [info] Added task posture_jvrc1
20: [success] Created TestPostureController
20: [critical] [TestPostureController] The observer pipeline can no longer be configured by "EnabledObservers", "RunObservers" and "UpdateObservers".
20: Multiple pipelines are now supported, allowing for estimation of multiple robots and/or multiple observations of the same robot.
20: For details on upgrading, please refer to:
20: - The observer pipelines tutorial: https://jrl-umi3218.github.io/mc_rtc/tutorials/recipes/observers.html
20: - The JSON Schema documentation: https://jrl-umi3218.github.io/mc_rtc/json.html#Observers/ObserverPipelines
20/47 Test #20: TestPostureController ...............................***Exception: SegFault  0.35 sec

The two keys here are:
[info] Loading additional global configuration "/home/jarivansteen/.config/mc_rtc/mc_rtc.yaml"

so the controllers are loading local configuration (we should look at disabling this in the future)
and the actual failure:
20: [critical] [TestPostureController] The observer pipeline can no longer be configured by "EnabledObservers", "RunObservers" and "UpdateObservers".
20: Multiple pipelines are now supported, allowing for estimation of multiple robots and/or multiple observations of the same robot.
20: For details on upgrading, please refer to:
20: - The observer pipelines tutorial: https://jrl-umi3218.github.io/mc_rtc/tutorials/recipes/observers.html
20: - The JSON Schema documentation: https://jrl-umi3218.github.io/mc_rtc/json.html#Observers/ObserverPipelines

This indicates that you have some outdated pipeline configuration in your local configuration (~/.config/mc_rtc/mc_rtc.yaml). Once you remove those sections from your local configuration file the tests should run fine.

I'm trying to install mc_rtc release 1.4.0 on Ubuntu 18.04.5 LTS

Strictly speaking, the script also update mc_rtc so you will be on 1.5.1 afterwards :-)
Feel free to close if this works out.

Thanks @gergondet for the quick and useful response! I removed the local configuration file for the time being and tried building again, which did indeed resolve the issue!


Add benchmarking functionality

Need some way of consistently benchmarking, probably using criterion.
Requires #18 .
The stress_test example provides a challenging picking scenario. Need to find a way to supply user input for an integration test, or alternatively, decouple the benchmark from bevy. The raycast functions have been separated already, but that only represents a small part of the code that needs to be profiled.

This should now move to the actual raycasting plugin bevy_mod_raycast.

This should now move to the actual raycasting plugin bevy_mod_raycast.


[Question]: could i use my local embedding model ?

Steps to reproduce
i have my own embedding encoder, and just request the http url to get vectors,
then how to realize it
and i also have my own LLM , and also i ask it just through the URL with ChatOpenai or OpenAI func ,
then how to replace the default Openai ?
thx
Relevant log output
no

What did you expect to happen?
replace the embedding encoder and the LLM
Version
no
Docker Versions (if used)
No response
OS
Linux
On which CPU architecture did you run Pathway?
ARM64 (AArch64, Apple silicon)

@ucas010 please take a look at this guide: https://pathway.com/developers/templates/private-rag-ollama-mistral#_3-embedding-model-selection.
It describes both selection of local embeddings, and of a connection to a custom LLM via LiteLLM wrapper.
The code described comes from this template https://github.com/pathwaycom/llm-app/tree/main/examples/pipelines/private-rag but can be used with any template.
For relevant documentation, see:
https://pathway.com/developers/api-docs/pathway-xpacks-llm/llms
https://pathway.com/developers/api-docs/pathway-xpacks-llm/embedders

thx,
if i do not use pw vector store ,
how to deal with it ?
or i just use faiss ?
@dxtrous

I think there is no problem here: pw Vector Store is a built-in vector index in-memory (at similar performance levels as the FAISS implementation). You do not need any extra steps to set it up, it will work out of the box. Try running the code.
Setting up an external vector store or integrating with FAISS is significantly more work. We currently do not provide templates for this.

Hi @ucas010 did you give the built-in vector store a try?
If we should close the issue, let me know.


attempt to perform an insert and a move to the same index path

Hi. I've got a crash during animated batch updates. I'm able to reproduce it on my work project. But I can't reproduce it on test project with same changesets. Btw, RxCollectionViewSectionedReloadDataSource works as expected.
The changeset array consists of two updates:
Items:
deletedItems:
	[(0, 1), (0, 2), (0, 5), (0, 6), (0, 7)]

Items:
insertedItems:
	[(0, 0), (0, 1), (0, 2), (0, 3), (0, 4)]
movedItems:
	[(from: (0, 1), to: (0, 5)), (from: (0, 2), to: (0, 6))]

And the crash looks this way:

Fatal Exception: NSInternalInconsistencyException
attempt to perform an insert and a move to the same index path (<NSIndexPath: 0x283d99600> {length = 2, path = 0 - 1})

I've noticed that I'm moving from (0,1) but the crash log says that I'm moving to (0,1).
So, the first question, is there a way to fix it?
Since RxCollectionViewSectionedReloadDataSource and reloadData() are working fine, I'd love to catch such an exception and fall back to reloadData(). Your last suggestion was to catch exception in the project, not in framework. But I can't catch it...
I do it this way:
override func performBatchUpdates(_ updates: (() -> Void)?, completion: ((Bool) -> Void)? = nil) {
    do {
        try safely {
            super.performBatchUpdates(updates, completion: completion)
        }
    } catch {
        print("\(error)")
        self.reloadData()
    }
}

But I get another crash:

Thread 1: closure argument passed as @noescape to Objective-C has escaped: file /Users/iwheelbuy/Documents/Project/Pods/RxDataSources/Sources/RxDataSources/RxCollectionViewSectionedAnimatedDataSource.swift, line 86, column 64

Are there any tips how to fall back to reloadData()?

And again I've encountered this issue. I have created the sample project. Got the same changeset and it doesn't crash (same Xcode, same device, same iOS deployment target). What is it about my work project that makes it crash?

I have found the problem:
final class CollectionView: UICollectionView {

    override func moveItem(at indexPath: IndexPath, to newIndexPath: IndexPath) {
        super.moveItem(at: indexPath, to: newIndexPath)
    }
}

When overriding UICollectionView functions should be careful with indexPath and newIndexPath. Accidentally I used indexPath for at and to


paket 5.136.0 is not used in "magic" mode

Description
Paket 5.136.0 is not used in "magic" mode.
Repro steps

Download paket.bootstrapper.exe
Run paket.botstrapper.exe
Observe it downloads paket.exe 5.136.0
Delete paket.exe
Rename paket.bootstrapper.exe to paket.exe
Run paket.exe
Observe it runs paket.exe 5.135.0

Expected behavior
Expected running 5.136.0 in both cases.
Actual behavior
"Magic" mode still uses 5.135.0.
Known workarounds
Don't use "magic" mode.

I think this is because the 24h outdated check is not triggered for. I
assume you updated recently to 135./cc @vbfox
Am 12.02.2018 16:22 schrieb "Milosz Krajewski"<EMAIL_ADDRESS>Description
Paket 5.136.0 is not used in "magic" mode.
Repro steps

Download paket.bootstrapper.exe
Run paket.botstrapper.exe
Observe it downloads paket.exe 5.136.0
Delete paket.exe
Rename paket.bootstrapper.exe to paket.exe
Observe it runs paket.exe 5.135.0

Expected behavior
Expected running 5.136.0 in both cases.
Actual behavior
"Magic" mode still uses 5.135.0.
Known workarounds
Don't use "magic" mode.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/issues/3041, or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNJSIrDzjIk80xYdmo_XvSB6FT2N8ks5tUFczgaJpZM4SCVcZ
.

Essentially "It's not  a bug, it's a feature" 😉
Updating on the internet is slow, and paket can run dozen of times during a build so the magic mode bootstrapper must ensure that it's not slowing everything down. Also having the version change between 2 executions in the same build (or even manually) can wreck havok.
One of the way it does that is by forcing the --max-file-age= setting to 12 hours: If it finds a paket version that is more recent that 12 hours it will use it (And if it doesn't and the version didn't change it update the time so there is at most one check per 12 hours).
But there is also the weirdness of why the magic mode didn't take your 5.136.0 version that the non-magic mode downloaded and put in the nuget cache. And it's due to the magic mode having an additional cache specific to the magic mode (In windows Temp dir).
This cache is theoretically removable now that the bootstrapper is hardened against parallel invocations but well let's say I never really had the time  to do it :)
If you want it to always go to the network the following line can be added to paket.dependencies to force it to always check version:
version --max-file-age=0

Also for production deployments of paket I strongly suggest that you don't let the version float and manually maintain it in your paket.dependencies (Also for repeatable builds and keeping all devs and CI in sync, same reason why the paket.lock file exists)
version 5.136.0

I think this comment should go into docs in to FAQ section
Am 12.02.2018 17:35 schrieb "Julien Roncaglia"<EMAIL_ADDRESS>Essentially "It's not a bug, it's a feature" 😉
Updating on the internet is slow, and paket can run dozen of times during a
build so the magic mode bootstrapper must ensure that it's not slowing
everything down. Also having the version change between 2 executions in the
same build (or even manually) can wreck havok.
One of the way it does that is by forcing the --max-file-age= setting to 12
hours: If it finds a paket version that is more recent that 12 hours it
will use it (And if it doesn't and the version didn't change it update the
time so there is at most one check per 12 hours).
But there is also the weirdness of why the magic mode didn't take your
5.136.0 version that the non-magic mode downloaded and put in the nuget
cache. And it's due to the magic mode having an additional cache specific
to the magic mode (In windows Temp dir).
This cache is theoretically removable now that the bootstrapper is hardened
against parallel invocations but well let's say I never really had the time
to do it :)
If you want it to always go to the network the following line can be added
to paket.dependencies to force it to always check version:
version --max-file-age=0
Also for production deployments of paket I strongly suggest that you don't
let the version float and manually maintain it in your paket.dependencies
(Also for repeatable builds and keeping all devs and CI in sync, same
reason why the paket.lock file exists)
version 5.136.0
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/issues/3041#issuecomment-364980161,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNJBHE4FGuPj4hCmbHBjg9el-11mEks5tUGhDgaJpZM4SCVcZ
.

It definitely should go to FAQ! Thanks.

@MiloszKrajewski any chance you could send a PR?


assetData encoder and decoder don't match.

https://github.com/AugurProject/augur/blob/201c54b5e2c18e5e3d6bec2156b7afcf6eefde28/packages/augur-core/source/contracts/trading/ZeroXTrade.sol#L305-L312
https://github.com/AugurProject/augur/blob/201c54b5e2c18e5e3d6bec2156b7afcf6eefde28/packages/augur-core/source/contracts/trading/ZeroXTrade.sol#L363-L372
The encoder will encode 4 bytes of the selector, followed by 32 bytes for the address, followed by 32 bytes representing the offset into the data for the token ids, etc.
The decoder skips 36 bytes into the data and then reads the next 32 bytes as the address, but what it is actually reading is the 32 byte offset for the token IDs.
Recommended fix: Don't do manual decoding, use abi.decode(...).  You will need to strip off the selector first, since unfortunately there isn't an abi.decodeWithSelector, but you only need to skip 4 bytes into the data for that and then you can run the rest through abi.decode(_assetData, (address, uint256[], uint256[], bytes)) (I think that is the syntax, you may need to look it up).  I don't think there is a way to offset into _assetData past the selector without dropping to assembly, but you can reduce the assembly usage down to a single line for that.

My issue was that I wasn't accounting for the length prefix on the bytes that Solidity implicitly adds to any bytes memory variable.
New Recommended fix, change the comment to read:

Skip the length (of bytes variable) and the selector to get to the first parameter.

Note: I still think it is a good idea to use abi.decode, though I now recognize that is a bit trickier since the 4 leading bytes are after the bytes length.   😢


Log Requests

Add a {request} placeholder to the replacer.
Closes #858.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Thanks @gchaincl! Glad to have your contribution. :smile: I'll give you push rights to the repository so, in the future if you wish to contribute, you can create a branch and review other PRs, etc.


Optimizes GetSpan and GetBytes due to memory allocation

Status
Type
⚠ Core Change
Issue

Ready
Refactor
No
Closes #261

Problem
What problem are you trying to solve?
Memory allocation issues during deseralization using GetSpan and GetBytes
Solution
How did you solve the problem?
Refactored GetSpan to not allocate buffers and just rely on slicing
Refactored GetBytes for the same reason and just use .ToArray()

@murlokito I'm using some code out of https://github.com/MonkeDAO/observer/ which is build against 0.4.3
Yesterday, I updated the observer to use use 0.4.16 and I experienced that code that crawls collections did not work anymore.
In particular
var metadataAccounts = await GetMetadataAccounts(69, _name);
When iterating over the result of these metadataAccounts for an collection with
var metadata = MetadataAccount.Deserialize(Convert.FromBase64String(metadataAccount.Account.Data[0]));
I receive ArgumentOutOfRangeExceptions for https://github.com/bmresearch/Solnet/pull/262/commits/8d61d4925046f7c78bc3af111eea4f6422f813f6#diff-4bbbd5a885ee94a83d296fa7734815ddaed24d3d80d304f1c15ca9b3a179ef3fR137 Line 137.
I was only able to crawl collections again by reverting the commit from this pull request and compiling everything again. I didn't change anything else. I tried to debug for a couple of hours and was only able to trace it back to this commit.
Can you take a look if I'm going in the right direction or if this GetMetadataAccount might be affected by the change to ReadOnlySpan? I'm a little bit stuck at finding out why I'm having this problem after updating everything to 0.4.16
CC: @tiago18c

@Liebeck Was that issue coming up on all collections or did you just try scraping one collection? I find it hard to believe the problem was exactly that one change, by the looks of the structures it's probably blowing up reading the strings inside the Data structure, could you refactor these to use GetString(offset, out string ...) instead and see if this issue persists?

@murlokito  I tried 4 different collections and I was unable to crawl any of them. That also included collections that I was able to parse before upgrading.
Then length parameter was very long, like 1032041 values or something in that range.
I'll try to use GetString later today, thanks!


BUG: Dublicate Book Exchange Hub

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Dublicate Book Exchange Hub- Same text is repeated twice

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Assign me with this problem @huamanraj


Implementing Evaluators classes for safe dispatched model evaluation

Implements a new API for launching evaluators.

Evaluators can be better parallelized and provide a better control over seeding stochastic simulation on multiple workers.
Also better control over arguments forwarded from the simulation interface is possible

#7 is completed. Which was the main task of this PR

All linked issues are solved.
Documentation for inference and numpyro backend will be improved once config module is merged
further harmonization will be adressed in future releases


Update documentation or automation to check and alert required permission

If I run the code,I get some errors towards the end for permissions which I did not knew at the time of running the script.

Issue resolved


test(typescript): verify subextensions work

test for https://github.com/esbuild-kit/esm-loader/issues/20

:tada: This PR is included in version 3.4.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Nextcloud Daily Backup to other VM

Situation
Robert asked for a guide on how to set a daily Nextcloud Backup to other VM
Todo

Explain how to make a cron job with rsync on a different vm connected to the nextcloud vm

https://manual.grid.tf/documentation/system_administrators/computer_it_basics/file_transfer.html#automate-backup-with-rsync

We can close when #586 is merged.


[webapp] - App Service support high density per-app scaling

It doesn't seem that the az appservice plan create command offers support to enable the "high density" "PerSiteScaling" feature described here
It would be great if this support could be added. It would also necessary to support setting the number of workers on a web app basis (perhaps with az webapp config set)

Work around for now would be to use PowerShell command for this https://docs.microsoft.com/en-us/azure/app-service/manage-scale-per-app

For CLI we support --set on the Appservice plan update which takes the propertyname=Value, you can also pass it a path to a json object file as @myJson.json & we will update the ASP settings. We will work on exposing this parameter on ASP create
On the webapp config set you can follow the same pattern & use the  --generic-configurations CLI property to set the numbers of workers

Moving this out to the next sprint


Update README

Please install 'install.php' before do other things.

Hacktobefest was already ended. But never mind.
Thank.


Number of passed/failed rows should be captured

[x] Add ingestion logic to capture the number of failed rows
[ ] Display number of failed rows on the UI

Can you provide further details Please .

Hey @Kulkarniyash7 we have validations that runs against databases here. These validations will return a TestCaseResults object defined here which does not include the number of rows that met and did not met the condition defined in the validation (example here).
What we need is to capture these data and pass it to the TestCaseResults object

Hey @TeddyCr  Is someone working on this ?

@techrajdeep do you want to work on it? we can assign it to you

Thanks @harshach  . Yes , I want to work on this. Since this is my first contribution , need some guidance.

Hey @harshach , Could you please assign this to me?

@techrajdeep done. Please join https://slack.open-metadata.org for any questions you may have. Reach out to @TeddyCr

Hi, I'd like to work on this as well. If possible could I get assigned to this?

hi @techrajdeep, any updates on this? Let us know if you need any help. Thanks

@amymareemc let us know if you still interested in working on it. We are looking to ship this in our next minor release
cc @TeddyCr @ayush-shah
cc @devyani-kaushik @ShaileshParmar11 for the UI

cc @ShaileshParmar11

@ShaileshParmar11 can you paste the screenshot how are we going to show this on the UI?

@harshach


add Windows ARM64EC CI workflow

This PR adds an ARM64EC architecture CI build workflow to windows-vs17. See here for an example of a passing CI run. I had to switch the vs17-arm-ci builds to target the Windows 11 SDK because ARM64EC is Windows 11 only.
It's not currently possible (as far as I know) to actually run Windows ARM tests in CI, so - as before - the Windows ARM CI workflows are build-only.
Note that support for ARM64EC was added in CMake 3.20.0 and improved in 3.23.0. The minimum version of CMake declared in the CMakeLists.txt file is 3.15.0. I'm not sure if we need to do something about that minimum version.

Merging.


Missing Flavor Text

various flavor text descriptions are missing for post-border crossing heist content including outfits and gloves

Do the outfits normally have flavor text in vanilla? This might be a bug with how IreNFist overrides the entire blackmarket text description function. Will look into this.

Do the outfits normally have flavor text in vanilla? This might be a bug with how IreNFist overrides the entire blackmarket text description function. Will look into this.

Yes, outfits and gloves normally do have text as well as an indicator from which DLC the item is from.

I confirmed the issue and I am currently working on a fix. Thanks for your report!

Fixed in 5cc26fe8f6f7e5378d9a4cf26a16cfb7bf821360.


Landsat SLC-off still downloads masks

Removing SLC-off data should not be downloaded by mask function. Look at this.

Fixed.

Fixed


Translation Error for German at RESTORE MASTER KEY section

At https://docs.microsoft.com/de-de/sql/t-sql/statements/restore-master-key-transact-sql?view=sql-server-ver15
you have translated
ENCRYPTION BY PASSWORD ='password'
twice instead of DECRYPTION

This issue was moved to MicrosoftDocs/sql-docs.de-de#137


Invalid RegEx in DefinitionValidator

PHP Version
8.2.13
Shopware Version
<IP_ADDRESS>
Expected behaviour
I've created a plugin whose name ends with "s".
In there are several custom entities and their respective definitions.
Usually I run bin/console dal:validate and was quite surprised to see not a single issue with my blindly created definitions and their entities.
I then intentionally created some issues inside of those definitions (Missing fields in the entity, missing reverse-associations, etc.) and was expecting the validation to find ANY issue at all.
Actual behaviour
Having spent some time on debugging, I eventually figured that my definitions were fully skipped due to a wrong RegEx.
How to reproduce

Create a plugin whose namespace ends with an "s", e.g. "MyExamplePlugins"
Create custom entities and definitions and make sure to add some mistakes in there
Run the dal:validate command and see it not noticing a single issue.

Explanation:
Here is the validator and its respective RegEx: DefinitionValidator
The |s part in the RegEx matches and considers your definition to be in a "Test" namespace when your plugin ends with "s" (Or any other part of the namespace).
Here's an example Regex101 link to see the issue.
I would have created a PullRequest and tried fixing it myself if I knew why the |s was added in the first place, but I couldn't figure that out - sorry guys! 🥲
Drop me a hint what the intention was and I'll try to come up with a PR.
Lots of love 💙

Thanks for bringing this up @PaddyS, and nice to see you here 💙
I guess the intention of this regex is to check for plugin names ending with both "Test" and "Tests" to be excluded from the validation. The pipe |s makes it go "Test" OR "s" instead.
It should look something like Tests? instead (last token before ? is optional).

Hi,
thx for your issue we will put it into our new evaluation process and have a look at it again.

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-37900.
[created from NEXT-37900, comment 488758]


chore: bdd-sbhg-1593140433 to 0.0.1

chore: Promote bdd-sbhg-1593140433 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


run_discrimination

I have my dataset on fake news, but I have two concerns:

How the dataset should be structured, i.e. text and what is the label?
Can i use the model from https://colab.research.google.com/drive/1esbpDOorf7DQJV8GXWON24c-EQrSKOit#scrollTo=ip52YU9X5BwB

MODEL = "grover_mega_owt_fix"
NUMBER=800000

as pretrained model?

my data looks something like this: https://github.com/rowanz/grover/blob/master/realnews/realnews_tiny.jsonl
also nope, that model is GPT2 trained using a modified version of this repo (for whatever reason...) rather than Grover :)


Add a supported cloud providers documentation

Description of changes:

Add a supported cloud providers documentation which explains how to configure the credentials to stream the data from cloud storage to your local instance.

Issue #, if available:
CO-1580

Merge Checklist:
Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[x] I have read the contributor guidelines
[x] This is a documentation change or typo fix. If so, skip the rest of this checklist.
[ ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
[ ] I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

[x] I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate).
[x] I ran the tests locally to make sure it pass. (check out testing)
[ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

Nice!
I think I would call it "MosaicML Cloud" instead of "MCLOUD"

Changed it to MosaicML platform based on latest update.


Allow to use have_http_status on HTTP.rb responses too

I use http.rb and wanted to test some status codes. I have used have_status_code for a while and really enjoined it.
I haved used this patch for a litle while and think I could ask if you want it upstream
module RSpec::Rails::Matchers::HaveHttpStatus
  # Example
  # Failure/Error: expect(HTTP.get("https://www.nrk.no")).to have_http_status(:created)
  #   expected the response to have status code :created (201) but it was :ok (200)

  alias as_test_response_before_httprb_support as_test_response
  def as_test_response(obj)
    if defined?(::HTTP::Response) && ::HTTP::Response === obj
      obj = ActionDispatch::Response.new.tap do |resp|
        resp.status  = obj.status.code
        resp.headers.clear
        resp.headers.merge!(obj.headers.to_h)
        resp.body    = obj.body.to_s
        resp.request = ActionDispatch::Request.new({})
      end
      ::ActionDispatch::TestResponse.from_response(obj)
    else
      as_test_response_before_httprb_support(obj)
    end
  end
end

If you don't I am 100% in on that.

I'm on the fence about this, rspec-rails is for compatibility with Rails test helpers, and they wouldn't match these requests would they? If you want to implement matchers for http.rb you could always create rspec-http.rb

Yeah, I could make a small gem with just this but I don't know if I think cool to have a soo small gem. An alternative is to check if it would be appreciated in http.rb. I did a bit of testing and it seams like if you define two matchers with the same name the last one will overwrite the first one. Do you have some suggestion how to work around that?  If I want to include in into a separate gem or in http.rb I will not require rspec-rails. How do I overcome the name? the easiest is just to create a separate matcher like "httprb_have_status"

Well you could require rspec/rails before you define your matcher, then call super as a fallback to allow it to "override" our matcher but still support it, or give it a seperate name, I don't think theres a problem with small gems for focused purposes, or ask http.rb to include the matcher themselves?
Anyway closing this for rspec/rails

okay, thanks


Message View : Fix the unexpected behaviour of Youtube Thumbnail.

This is the pr for #11867
Testing Plan:
GIFs or Screenshots:

@vipulchhabra99 can you explain why this is required?  Also, did you look at using more declarative styling for ensuring the centering of the icon?  We're trying to move away from range pixel counts like 32px and -85px that would not do well with a change in size; at the very least, we should use SCSS to record the actual math in the CSS file.
  Use git log to see what everyone else writes, and check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

(Thanks for working on this by the way!)

Thanks @timabbott for reviewing my pr actually it is usually noticed that the Firefox has some padding or margin rendering issues than chrome so what is observed was that the margin in both the browsers were being considered from different sides of thumbnail due to which using a common margin values made one button in correct position and other out of thumbnail so i used special declarative statement for Firefox describing the margin specifically for the Firefox while others would simply use the previous margin values only.
Since i am a beginner and started contributing few days back only i forgot to read about commit messages detail sorry for the inconvenience i will keep this in mind from next time and fix for this pr soon .
It was my pleasure working here due to great support by you and your team .

Hi @vipulchhabra99, it looks like your commit message is a bit too long and runs into the body.  Looking at recently merged commits that are similar in scope to what you're working might be a good way to work on following up with Tim's reviews. :)

Hi @whoodes thanks for guidance I will have a look and fix this soon 🙂

@vipulchhabra99 Your commit message title (ie the summary) does match the style we use, if you run ./tools/lint you should get the corresponding error message. You'd want to format it as:
message view: Fix The unexpected behavior of Youtube Thumbnail.
Also, individual lines in the commit message should not exceed the max length (76).
You could go through the relevant part of the contribution guide for more details.
Thanks for sending this in! :)
(I'm surprised because I thought CI also made these checks, but I guess I was wrong)

@vipulchhabra99 can you show the math that determines those pixel values are correct as a function of the size of the thumbnail?  We'll want that to live in a comment or calc() or something here.

Hi @timabbott please have a look on these lines in files
https://github.com/zulip/zulip/blob/b5553e058ece884f7f8dfac27357263f87916996/static/styles/zulip.scss#L2266-L2275
actually, this is written for maintaining the play button over the thumbnail. In line  2268 margin specified from left was 45 px and other browsers consider from left side of the thumbnail while in case of Firefox it considered from right side of thumbnail  and since thumbnail has a width of 120 and padding of 8 so I used this value (-83 now sorry,  I thought padding of right to be 10) 45+83=(120+8) and allocating button at same positions in other browsers

Looks like the Firefox has some kind of invisible paddings etc. Setting left and top to 0 should fix this issue on all the browsers.
.youtube-video .fa-play:before {
    top: 0;
    left: 0;
}

@timabbott not sure if this is a good solution but surely bettter than dealing with margins on eacch and every browsers.

actually yes I think this is a better solution than the previous one thanks @akashnimare. @timabbott I have updated my pr for the same.

@vipulchhabra99 also, update the commit message.

Great, merged as 25d7cdfa513e1566c74e31802c0047567209d756 after fixing the commit message to auto-close the original issue.
Thanks for the contribution @vipulchhabra99!
(And thanks for the better solution proposal @akashnimare)


bumping Version for auto Updation

Bumping version so that Dacpac changes can be auto Updated.

@kmkumaran @Ajay-MS Please take a look and approve for merge into m105

Looks fine.


BUG: Unnecessary CSS code appearing in the footer section of the About Us page

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Observe the unwanted CSS code displayed in the footer of about us page.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Assigned!
Make sure to attach before & after screenshots in your PR and include the issue number.
Also, please star the repo before working on it.
I am the project mentor so you can always reach out to me for any help!
Happy open-source contributing!


Update AprilTagDetectionPipeline to be a frame processor

The WebCam component we've already built provides a FrameProcessor abstraction with common functionality (such as saving the last frame and updating exposure control) built around that.  This commit updates the sample AprilTag detector code to work within that abstraction.

@Masomy have a look at this change and merge it if it looks good to you.  That will make it a part of your other pull request to the main Entropic repo.


Is there a guarantee on the order of envelope points?

We noticed that the .envelope polygon seems to start from (minx, miny) then proceed counter clockwise to (maxx, maxy) and close.
Is this order guaranteed?
If so if should be mentioned in the docs.

No, the order is not guaranteed.

@adishavit use the .bounds method to return xmin, ymin, xmax, ymax, as is documented. You can use this with box to toggle ccw as required.


Overhaul README.md

Thank you @fzipi. I think I have covered all your comments.
I'm not a fan of rule ID 999999. But it's not necessary to start to change a lot of things all of a sudden.


Polish the Azure.ResourceManager.Marketplace and prepare for release

/azp run net - marketplace - mgmt

/azp run net - marketplace - mgmt

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.Marketplace


[WIP] [RFC] Implement Packagist-style module add process

Overview
Drop the current module add process (n+1 GitHub API requests to fetch all the repositories for your account and determine which are ZF2 modules) in favour of something closer to what Packagist does:

Enter the URL to your repository
In an AJAX request, pull the repository and determine if it's a ZF2 module

If it is a module, import it and return the new module's details + link to it's view page
If it isn't a module (or if something fails), return a suitable error message

If a module was successfully created, add a row for it below the add form so the user can see it has been added and either open it's view page in a new window or continue adding more modules.

There are two main upsides to this approach

Uses far fewer GitHub API requests, which is important as the Search API used to determine if a repository contains a ZF2 module is limited to 30 requests per minute.
Makes supporting multiple sources (eg: bitbucket) easier.

TODO list
TODO: needs more TODOs

[ ] Implement UI for triggering module add
[ ] Implement background handling of add requests
[ ] Packagist package names
[ ] GitHub repository slug

In an AJAX request, pull the repository and determine if it's a ZF2 module

Uhhh.... userland validation? :-\

the Search API used to determine if a repository contains a ZF2 module is limited to 30 requests per minute.

That's not really terrible from an API PoV: how many submissions/minute do we even hope to get?

Uhhh.... userland validation? :-\

That's not really terrible from an API PoV: how many submissions/minute do we even hope to get?

Not userland validation, bad wording on my part.  Right now the site makes one call to the Search API for each repository in your GitHub account, so if you have more than 30 repositories you bump against the limit.  What I propose is nearly identical to the method the site currently uses except it's executed on just one repository (the one you specify the URL for) and not for every repository on your account at once.
That also cures the 30-request-per-minute issue as the likelihood of being able to submit 30 modules to the site in under a minute is pretty slim IMO, so it becomes a non-issue.  Even if you do manage that extraordinary feat we can display a message saying "You've reached the rate limit, please wait X seconds and try again"

Not sure, but would this be related to #84?

Yes, that is pretty much what I had planned for the client side behaviour.

@adamlundrigan
Cool! :+1:

It's been a challenge locking down time to work on it, but I still hope to have a prototype out for feedback tomorrow.

Quick summary of the major work to date:

Moved existing login/logout functionality to /auth so I could introduce a new controller to handle rendering the user module listing page (4cd2096)
Moved rendering of the module list to it's own controller action - commit has more details on the why (ec27d0f)
ZfModule\Mapper\Module::findByOwner doesn't actually filter by owner.  Now it does when $owner is not empty.  There aren't any tests for the mapper, but there should be...

@adamlundrigan @ins0
Please let me know if I can help you guys - I don't want to make it extra-hard for you with me working on a bunch of things, leaving your PRs unmergable and whatnot.

@localheinz no worries, there's not much in here yet.  I've been yanked away to deal with some time-sensitive client work so I haven't had time recently to work on it.  It'll probably be late next month before I can get back to it, so if anyone else wants to pick it up in the meantime feel free...I can add them as a collaborator on my repo or they can start a new PR.

it need rebase

Please rebase this onto develop branch.

News? :)


[WIP] Add copy for IDP disconnect

Royal Mail and Citizensafe come to the end of their continued assurance period on March 1st. Therefore, we need to have the copy in place to explain to users why they can no longer use those IDPs to log in any more.
I've not done any testing of this PR, and we need to get the Welsh translation before merging.
See https://trello.com/c/vi7RV11M

We've got new copy:

The following companies are no longer part of GOV.UK Verify
If you had an identity account with one of these companies, you'll need to verify your identity with a different  company.

Oops - accidentally pushed a commit to the wrong branch. Have now backed out - this should be ready to go.


Error: Invalid function argument - var.module_version is null

Following the custom domain example, I get this error:
Error: Invalid function argument

  on .terraform/modules/tf_next.next_image.lambda_content/main.tf line 10, in locals:
  10:   cdn_module_version = length(var.module_version) > 0<EMAIL_ADDRESS>: ""
    |----------------
    | var.module_version is null

Invalid value for "value" parameter: argument must not be null.

The error doesn't appear on 0.7.0, only on 0.7.1

Yep, it is a regression from the v0.7.1 release. 🙈
Using v0.7.0 instead should fix it until we release a new version.

Just released v0.7.2 which contains a hotfix for this error.
This is just a temporary fix until we move the versioning of the image optimizer into a better shape.
Follow https://github.com/dealmore/terraform-aws-next-js-image-optimization/issues/14 for more information on this.

Thank you! Can confirm this fixed my issue.


docs(samples): Add Kafka to Dataflow snippet

Description
Add code snippets for reading from Kafka using the Dataflow managed I/O transform.
Doc bugs:

b/338063763: Managed I/O documentation [includes Kafka support]
b/342015050: Document best practices for using Kafka with Dataflow

Checklist

[ ] I have followed Sample Format Guide
[ ] pom.xml parent set to latest shared-configuration
[ ] Appropriate changes to README are included in PR
[ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
[ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
[ ] Tests pass:   mvn clean verify required
[ ] Lint  passes: mvn -P lint checkstyle:check required
[ ] Static Analysis:  mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
[ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
[ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
[x] Please merge this PR for me once it is approved

I found no explanation regarding these code samples or the usage of the dataflow_kafka_read tag. It seems that the use of the managed.managed.KAFKA isn't required to read from Kafka in Apache Beam or in Dataflow specifically. Can you provide more context for the decision to make the implementation "as is"? Will it work the same way in Python and Go code samples? I did not find the answer to these questions in the referenced issues.

This isn't a Managed Kafka sample, it's showing reading Kafka from Dataflow. It should be use-able with Managed Kafka but that's not a dependency.
The Java version specifically uses the Managed I/O transform which is new. For now the Python version will use an older version of the Kafka I/O, as there is currently no Managed I/O transform for Python. (Same for Go although a Go version isn't currently planned.)
Relevant doc bugs:

b/338063763: Managed IO GA documentation [includes Kafka support]
b/342015050: Document best practices for using Kafka with Dataflow

Thank you for your clarifications. Please, follow up my feedback in the lines comments above.


I think this breaks the rules of graphs

When going between Home and Dashboard, and extra loop is added to the graph.

Cheers for reporting!
Yes this is probably because right now the FitnessStore re-fetches the entire set of data-points when you view the page.  Should be a quick fix, I'm planning on porting this all to Redux anyway.

Hey,  this should have been fixed in 251abb25ed3334c4032dbdf2a9ad1a02cac8fd54.  Would you mind taking another look?

can confirm, it's fixed! closing issue.


make a useable docker image as the starting point for Shilpa's pipeline

see notes/NoteToShlipa.txt
and the diff to understand how to handle various setup for running the pipeline smoothly.

using the python code (pipeline.py) to call subprocess shell may messup shell environment, at least DV docker won't run proper in my test
As Shilpa code have many hard-coded relative paths to the excutables, please follow the following exactly

mkdir -p /wd/dipasm/
git clone https://github.com/shilpagarg/DipAsm.git
# swith to a proper brach in nessary
cd /wd/dipasm/DipAsm/docker
docker build -t dipasm .
cd /wd/dipasm/DipAsm
docker run -it --rm -v  /wd/dipasm/DipAsm:/wd/dipasm/DipAsm/ -v /var/run/docker.sock:/var/run/docker.sock dipasm:latest /bin/bash

note the mount point setting "-v  /wd/dipasm/DipAsm:/wd/dipasm/DipAsm/"
and "-v /var/run/docker.sock:/var/^Cn/docker.sock".
Both should be followed exactly as-is. The second one make it possible to call another docker container (in this case DV) inside
the docker container. The first is also important to DV. When one excutate docker container insider a docker container, the
new container actually see the host file system not the contatiner file system

test run with docker
In the container:

cd /wd/dipasm/DipAsm
bash test.sh | bash

Thanks so much, @cschin. I guess by -v /var/run/docker.sock:/var/^Cn/docker.sock you mean -v /var/run/docker.sock:/var/run/docker.sock.

Thanks so much, @cschin. I guess by -v /var/run/docker.sock:/var/^Cn/docker.sock you mean -v /var/run/docker.sock:/var/run/docker.sock.

yes, your right. working on different OS/keyboard... can't type it right


Make issuerFingerprintSubpacket critical only for v5 signatures

fixes #88

(I've gone ahead and applied the suggestion and merged it, thanks again for the PR!)


bevy_reflect: Add DynamicClosure and DynamicClosureMut

Objective
As mentioned in this comment, creating a function registry (see #14098) is a bit difficult due to the requirements of DynamicFunction. Internally, a DynamicFunction contains a Box<dyn FnMut> (the function that reifies reflected arguments and calls the actual function), which requires &mut self in order to be called.
This means that users would require a mutable reference to the function registry for it to be useful— which isn't great. And they can't clone the DynamicFunction either because cloning an FnMut isn't really feasible (wrapping it in an Arc would allow it to be cloned but we wouldn't be able to call the clone since we need a mutable reference to the FnMut, which we can't get with multiple Arcs still alive, requiring us to also slap in a Mutex, which adds additional overhead).
And we don't want to just replace the dyn FnMut with dyn Fn as that would prevent reflecting closures that mutate their environment.
Instead, we need to introduce a new type to split the requirements of DynamicFunction.
Solution
Introduce new types for representing closures.
Specifically, this PR introduces DynamicClosure and DynamicClosureMut. Similar to how IntoFunction exists for DynamicFunction, two new traits were introduced: IntoClosure and IntoClosureMut.
Now DynamicFunction stores a dyn Fn with a 'static lifetime. DynamicClosure also uses a dyn Fn but has a lifetime, 'env, tied to its environment. DynamicClosureMut is most like the old DynamicFunction, keeping the dyn FnMut and also typing its lifetime, 'env, to the environment
Here are some comparison tables:

DynamicFunction
DynamicClosure
DynamicClosureMut

Callable with &self
✅
✅
❌

Callable with &mut self
✅
✅
✅

Allows for non-'static lifetimes
❌
✅
✅

IntoFunction
IntoClosure
IntoClosureMut

Convert fn functions
✅
✅
✅

Convert fn methods
✅
✅
✅

Convert anonymous functions
✅
✅
✅

Convert closures that capture immutable references
❌
✅
✅

Convert closures that capture mutable references
❌
❌
✅

Convert closures that capture owned values
❌[^1]
✅
✅

[^1]: Due to limitations in Rust, IntoFunction can't be implemented for just functions (unless we forced users to manually coerce them to function pointers first). So closures that meet the trait requirements can technically be converted into a DynamicFunction as well. To both future-proof and reduce confusion, though, we'll just pretend like this isn't a thing.
let mut list: Vec<i32> = vec![1, 2, 3];

// `replace` is a closure that captures a mutable reference to `list`
let mut replace = |index: usize, value: i32| -> i32 {
  let old_value = list[index];
  list[index] = value;
  old_value
};

// Convert the closure into a dynamic closure using `IntoClosureMut::into_closure_mut`
let mut func: DynamicClosureMut = replace.into_closure_mut();

// Dynamically call the closure:
let args = ArgList::default().push_owned(1_usize).push_owned(-2_i32);
let value = func.call_once(args).unwrap().unwrap_owned();

// Check the result:
assert_eq!(value.take::<i32>().unwrap(), 2);
assert_eq!(list, vec![1, -2, 3]);

ReflectFn/ReflectFnMut
To make extending the function reflection system easier (the blanket impls for IntoFunction, IntoClosure, and IntoClosureMut are all incredibly short), this PR generalizes callables with two new traits: ReflectFn and ReflectFnMut.
These traits mimic Fn and FnMut but allow for being called via reflection. In fact, their blanket implementations are identical save for ReflectFn being implemented over Fn types and ReflectFnMut being implemented over FnMut types.
And just as Fn is a subtrait of FnMut, ReflectFn is a subtrait of ReflectFnMut. So anywhere that expects a ReflectFnMut can also be given a ReflectFn.
To reiterate, these traits aren't 100% necessary. They were added in purely for extensibility. If we decide to split things up differently or add new traits/types in the future, then those changes should be much simpler to implement.
TypedFunction
Because of the split into ReflectFn and ReflectFnMut, we needed a new way to access the function type information. This PR moves that concept over into TypedFunction.
Much like Typed, this provides a way to access a function's FunctionInfo.
By splitting this trait out, it helps to ensure the other traits are focused on a single responsibility.
Internal Macros
The original function PR (#13152) implemented IntoFunction using a macro which was passed into an all_tuples! macro invocation. Because we needed the same functionality for these new traits, this PR has copy+pasted that code for ReflectFn, ReflectFnMut, and TypedFunction— albeit with some differences between them.
Originally, I was going to try and macro-ify the impls and where clauses such that we wouldn't have to straight up duplicate a lot of this logic. However, aside from being more complex in general, autocomplete just does not play nice with such heavily nested macros (tried in both RustRover and VSCode). And both of those problems told me that it just wasn't worth it: we need to ensure the crate is easily maintainable, even at the cost of duplicating code.
So instead, I made sure to simplify the macro code by removing all fully-qualified syntax and cutting the where clauses down to the bare essentials, which helps to clean up a lot of the visual noise. I also tried my best to document the macro logic in certain areas (I may even add a bit more) to help with maintainability for future devs.
Documentation
Documentation for this module was a bit difficult for me. So many of these traits and types are very interconnected. And each trait/type has subtle differences that make documenting it in a single place, like at the module level, difficult to do cleanly. Describing the valid signatures is also challenging to do well.
Hopefully what I have here is okay. I think I did an okay job, but let me know if there any thoughts on ways to improve it. We can also move such a task to a followup PR for more focused discussion.
Testing
You can test locally by running:
cargo test --package bevy_reflect

Changelog

Added DynamicClosure struct
Added DynamicClosureMut struct
Added IntoClosure trait
Added IntoClosureMut trait
Added ReflectFn trait
Added ReflectFnMut trait
Added TypedFunction trait
IntoFunction now only works for standard Rust functions
IntoFunction no longer takes a lifetime parameter
DynamicFunction::call now only requires &self
Removed DynamicFunction::call_once
Changed the IntoReturn::into_return signature to include a where clause

Internal Migration Guide

[!important]
Function reflection was introduced as part of the 0.15 dev cycle. This migration guide was written for developers relying on main during this cycle, and is not a breaking change coming from 0.14.

IntoClosure
IntoFunction now only works for standard Rust functions. Calling IntoFunction::into_function on a closure that captures references to its environment (either mutable or immutable), will no longer compile.
Instead, you will need to use either IntoClosure::into_closure to create a DynamicClosure or IntoClosureMut::into_closure_mut to create a DynamicClosureMut, depending on your needs:
let punct = String::from("!");
let print = |value: String| {
    println!("{value}{punct}");
};

// BEFORE
let func: DynamicFunction = print.into_function();

// AFTER
let func: DynamicClosure = print.into_closure();

IntoFunction lifetime
Additionally, IntoFunction no longer takes a lifetime parameter as it always expects a 'static lifetime. Usages will need to remove any lifetime parameters:
// BEFORE
fn execute<'env, F: IntoFunction<'env, Marker>, Marker>(f: F) {/* ... */}

// AFTER
fn execute<F: IntoFunction<Marker>, Marker>(f: F) {/* ... */}

IntoReturn
IntoReturn::into_return now has a where clause. Any manual implementors will need to add this where clause to their implementation.

Updated the PR to further split DynamicClosure into DynamicClosure and DynamicClosureMut. This greatly simplifies the mental model for users as it now matches Rust definitions of functions and closures, at the cost of increasing the size of the API.


Use ContextCompat to fetch drawable resources

Change the use of getResources to ContextCompat in order to support svgs in older versions of android (<21)

Thanks for the contribution! In general, it's better to rebase on the target branch before making the Pull Request, but it doesn't really matter for a small project like this.


Greate app man.

Really It's a Greate app. when I record my youtube video I can't remove my keyboard sound. If  I record audio after screen recording, I cant add keyboard sound. But It's a great app for adding keyboard sound like a system sound in my videos. Thanks for this awesome application.
#One issue I found that with clicking Shift + (others Key), Sometimes It gives double sound.
My Gift
var x= 6.02 * 10**23;

for (let i = 0; i < 2*x; i++) {

document.write("Love <3"+"
");

};

thank you, man! I have been reported about that issue before but still dont know how to reproduce the issue, I will try my best to fix it soon

thank you, man! I have been reported about that issue before but still dont know how to reproduce the issue, I will try my best to fix it soon

Really It's a Greate app. when I record my youtube video I can't remove my keyboard sound. If I record audio after screen recording, I cant add keyboard sound. But It's a great app for adding keyboard sound like a system sound in my videos. Thanks for this awesome application.
#One issue I found that with clicking Shift + (others Key), Sometimes It gives double sound.
My Gift
var x= 6.02 * 10**23;

for (let i = 0; i < 2*x; i++) {

document.write("Love <3"+"
");

};

If your screen recorder also recording the system sound, then it will record the keyboard sound too

Really It's a Greate app. when I record my youtube video I can't remove my keyboard sound. If I record audio after screen recording, I cant add keyboard sound. But It's a great app for adding keyboard sound like a system sound in my videos. Thanks for this awesome application.
#One issue I found that with clicking Shift + (others Key), Sometimes It gives double sound.
My Gift
var x= 6.02 * 10**23;

for (let i = 0; i < 2*x; i++) {

document.write("Love <3"+"
");

};

If your screen recorder also recording the system sound, then it will record the keyboard sound too


Follow open files in the PR changes view

Requested by @digitarald:
When a file that's in the currently checked out PR is opened (even when it's not a diff) we should highlight the file in the "Changes" view if it's open.

This would be helpful for maintaining context when jumping between files via "go to definition".

We already do this.

@alexr00 Are you sure this already works? I'm on the pre-release version (v0.79.2023121409) and files are still only highlighted in the changes view if I open them by directly clicking in that view.

Here's what I see:

Can you share a gif of what you're seeing?

Ok looks like it works when I re-enable explorer.autoReveal. I believe I disabled that setting because I didn't like the explorer jumping around when I switched files, but I'll try out re-enabling it and see if it's still a problem. I wonder if it would make sense to have a separate version of this setting for this extension.

So I've tried re-enabling explorer.autoReveal and it's honestly pretty annoying. Would love to have a separate option for this extension.


What is $ASSIGNEE?

Article is not useful because it is missing information on how to obtain nescessary data to assign to $ASSIGNEE environment variable.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3af2f117-85b5-b53e-b9b8-58c43a0aac71
Version Independent ID: 0640e0e2-04d8-e056-78e8-977bb7a559dc
Content: AKS triage - container registry connectivity - Azure Architecture Center
Content Source: docs/operator-guides/aks/aks-triage-container-registry.md
Service: architecture-center
Sub-service: guide
GitHub Login: @kevingbb
Microsoft Alias: pnp

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 376296

Missed some critical context.


[7.x] Add ability to share auto-wired services where matches a prefix

see https://github.com/laravel/ideas/issues/2248

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


SIG Reviewer Nomination - Adam Dąbrowski (@adamdbrw)

Nomination Guidelines
Reviewer Nomination Requirements

6+ contributions successfully submitted to O3DE
100+ lines of code changed across all contributions submitted to O3DE
2+ O3DE Reviewers or Maintainers that support promotion from Contributor to Reviewer
Requirements to retain the Reviewer role: 4+ Pull Requests reviewed per month

I would like to nominate: Adam Dąbrowski (@adamdbrw), to become a Reviewer on behalf of  sig-simulation. I verify that they have fulfilled the prerequisites for this role (see above).
PRs

https://github.com/o3de/ROSConDemo/pulls/adamdbrw
https://github.com/o3de/o3de-extras/pulls/adamdbrw
https://github.com/o3de/o3de/pulls/adamdbrw

Details

Nominee's GitHub Profile: https://github.com/adamdbrw

Reviewers & Maintainers that support this nomination should comment in this issue.
Tagging @lgleim, @epsilon-delta, @moraaar, @greerdv, @SergeyAMZN for visibility.

I support this nomination.

+1, I support this nomination

I also support this nomination.

Approved in today's SIG Simulation governance meeting.

Invited to the SIG Simulation reviewer team