Fixing yellow warning for UIManager in ReactNative

When using this library with the latest version of ReactNative (e.g. 0.58) we get the following warning:
Accessing view manager configs directly off UIManager via UIManager['InteractableView'] is no longer supported.
This pull request applies the necessary modifications for fixing the problem.

+1

@tt-driver-apps Is it possible you make the requested changes? I hope it can then be merged into master 👍

+1

@tt-driver-apps any chance update PR to the comment, so we can have it merged?

@tt-driver-apps we need this merged, please


Scheduling a bulb

How can i schedule a bulb to open everyday at same hour like smart life app?Thanks if you can help.Thank you for this app it helped me a lot.

Great questions @bthxyzx .  The Tuya devices (bulbs) don't seem to contain a real time clock so the timer function is likely actually performed by the Tuya Cloud.
For me, I have a basic Raspberry Pi that is always on and performs the timer function.  It turns switches and lights on/off or changes colors at certain times.  I'm using simple cron scripts (see crontab) which is part of Raspberry Pi OS or Linux systems.
I recommend also looking at home-assistant.io as it provides an easy to use interface to do all of this without getting into the OS.

Thanks jasonacox.Looks like Smart life app scheduling is on the cloud.


circle-full build is broken due to upstream bugs

Here are the failing tests:
https://app.circleci.com/pipelines/github/mne-tools/mne-python/9551/workflows/19eba59d-484b-4bec-92e3-70c15b58b516/jobs/32524/tests
here are the upstream fixes:

https://github.com/nilearn/nilearn/pull/2916
https://github.com/python-quantities/python-quantities/pull/189

This issue is just for keeping track of the various pieces.

note that a workaround was added in #9665 to simply configure sphinx to ignore the two errors.  Once new versions of the 2 dependencies are fixed, we should remove those ignores


AnimatedCrossFade clips CircularProgressIndicator

Steps to Reproduce

Create a Text widget.
Create a CircularProgressIndicator widget, Increase strokeWidth to 10 to better see the issue.
Use AnimatedCrossFade widget to toggle between the two.
Check out the CircularProgressIndicator sides you will find that it's clipped

Note: Adding padding resulted in a skewed indicator, Which is even more strange.
Detailed issue demonstration

Code to reproduce
In a stateful widget
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatefulWidget {
  // This widget is the root of your application.
  @override
  MyAppState createState() {
    return new MyAppState();
  }
}

class MyAppState extends State<MyApp> {
  CrossFadeState xFadeState = CrossFadeState.showFirst;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Issue Demo',
      home: Scaffold(
        body: Center(
          child: Container(
            color: Colors.red,
            width: 50,
            height: 50,
            child: GestureDetector(
              onTap: () {
                setState(() {
                  xFadeState == CrossFadeState.showSecond ? xFadeState = CrossFadeState.showFirst : xFadeState = CrossFadeState.showSecond;
                });
              },
              child: Center(
                child: AnimatedCrossFade(
                  firstChild: Text('data'),
                  secondChild: SizedBox(
                    height: 20,
                    width: 20,
                    child: CircularProgressIndicator(),
                  ),
                  duration: Duration(milliseconds: 250),
                  crossFadeState: xFadeState,
                ),
              ),
            ),
          ),
        ),
      ),
    );
  }
}

Without the SizedBox

With padding around the CircularProgressIndicator, Issue seems to be fixed but during transition the indicator is skewed as demonstrated by this gif, Surrounding the padding with a SizedBox shows that the AnimatedCrossFade doesn't respect the SizedBox's Size and skews the indicator while animating the size transition anyway.

I hope this is enough detail to reproduce, I'll be glad to provide more if needed.
flutter doctor -v
[✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.13.6 17G4015, locale en-EG)
    • Flutter version 1.0.0 at /Users/pushqrdx/Library/Developer/Flutter
    • Framework revision 5391447fae (5 weeks ago), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.0)
    • Android SDK at
      /Users/pushqrdx/Library/Developer/Xamarin/android-sdk-macosx/
    • Android NDK at
      /Users/pushqrdx/Library/Developer/Xamarin/android-sdk-macosx/ndk-bundle
    • Platform android-28, build-tools 28.0.0
    • ANDROID_HOME =
      /Users/pushqrdx/Library/Developer/Xamarin/android-sdk-macosx/
    • Java binary at:
      /Users/pushqrdx/Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Ho
      me/bin/java
    • Java version OpenJDK Runtime Environment (build 9.0.4+11)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

To investigate we would need a minimal runnable reproduction
as a single file so that we can just copy your code into lib/main.dart of a new project and run to reproduce.
A screenshot that demonstrates the issue would be helpful as well.

@zoechi So sorry for not providing enough info at first... Here's a demo of the issue

Code to reproduce
In a stateful widget
class MyAppState extends State<MyApp> {
  CrossFadeState xFadeState = CrossFadeState.showFirst;

    return MaterialApp(
        title: 'Issue Demo',
        home: Scaffold(
          body: Center(
            child: Container(
              color: Colors.red,
              width: 50,
              height: 50,
              child: GestureDetector(
                onTap: () {
                  setState(() {
                    xFadeState == CrossFadeState.showSecond ? xFadeState = CrossFadeState.showFirst : xFadeState = CrossFadeState.showSecond;
                  });
                },
                child: Center(
                  child: AnimatedCrossFade(
                    firstChild: Text('data'),
                    secondChild: SizedBox(
                      height: 20,
                      width: 20,
                      child: CircularProgressIndicator(),
                    ),
                    duration: Duration(milliseconds: 250),
                    crossFadeState: xFadeState,
                  ),
                ),
              ),
            ),
          ),
        ),
    );
  }
}

Without the `SizedBox`

![2019-01-02 22 06 05](https://user-images.githubusercontent.com/25884937/50610179-b0009b80-0eda-11e9-8d76-c5c64c7dc065.gif)

With padding around the `CircularProgressIndicator`, Issue seems to be fixed but another 2 arise

minimal runnable reproduction

Can you please make it complete so that copying it as lib/main.dart allows to run without any additional steps?

@zoechi Updated

Reproducible on the latest master 1.21.0-6.0.pre.41.

flutter doctor -v
[√] Flutter (Channel master, 1.21.0-6.0.pre.41, on Microsoft Windows [Version 10.0.18362.959], locale et-EE)
   • Flutter version 1.21.0-6.0.pre.41 at C:\Development\flutter_master
   • Framework revision 39fa00201d (5 hours ago), 2020-07-27 21:11:43 -0700
   • Engine revision f27729e97b
   • Dart version 2.10.0 (build 2.10.0-0.0.dev 24c7666def)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
   • Android SDK at C:\Users\Isa\AppData\Local\Android\sdk
   • Platform android-30, build-tools 30.0.0
   • Java binary at: C:\Users\Isa\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763\jre\bin\java
   • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
   • All Android licenses accepted.

[√] Chrome - develop for the web
   • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.6.4)
   • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
   • Visual Studio Community 2019 version 16.6.30309.148
   • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.0)
   • Android Studio at C:\Users\Isa\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763
   • Flutter plugin version 47.1.2
   • Dart plugin version 193.7361
   • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.47.2)
   • VS Code at C:\Users\Isa\AppData\Local\Programs\Microsoft VS Code
   • Flutter extension version 3.12.2

[√] Connected device (5 available)
   • SM G950F (mobile)       • ce12171c51cc001c03 • android-arm64  • Android 9 (API 28)
   • sdk gphone x86 (mobile) • emulator-5554      • android-x86    • Android 11 (API 30) (emulator)
   • Windows (desktop)       • windows            • windows-x64    • Microsoft Windows [Version 10.0.18362.959]
   • Web Server (web)        • web-server         • web-javascript • Flutter Tools
   • Chrome (web)            • chrome             • web-javascript • Google Chrome 84.0.4147.89

• No issues found!

Padding workaround seems to work fine for now.

Workaround
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatefulWidget {
 // This widget is the root of your application.
 @override
 MyAppState createState() {
   return new MyAppState();
 }
}

class MyAppState extends State<MyApp> {
 CrossFadeState xFadeState = CrossFadeState.showFirst;

 @override
 Widget build(BuildContext context) {
   return MaterialApp(
     title: 'Issue Demo',
     home: Scaffold(
       body: Center(
         child: Container(
           color: Colors.red,
           width: 50,
           height: 50,
           child: GestureDetector(
             onTap: () {
               setState(() {
                 xFadeState == CrossFadeState.showSecond
                     ? xFadeState = CrossFadeState.showFirst
                     : xFadeState = CrossFadeState.showSecond;
               });
             },
             child: Center(
               child: AnimatedCrossFade(
                 firstChild: Text('data'),
                 secondChild: Padding(
                   padding: const EdgeInsets.all(8.0),
                   child: SizedBox(
                     height: 20,
                     width: 20,
                     child: CircularProgressIndicator(),
                   ),
                 ),
                 duration: Duration(milliseconds: 250),
                 crossFadeState: xFadeState,
               ),
             ),
           ),
         ),
       ),
     ),
   );
 }
}

Issue is reproducible on stable and master as reported above.
The padding workaround still works.

video
https://user-images.githubusercontent.com/88313112/198267073-3f0eb8c1-635a-499b-b04b-f7f5aeef5aa7.mov

updated sample
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatefulWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  MyAppState createState() {
    return MyAppState();
  }
}

class MyAppState extends State<MyApp> {
  CrossFadeState xFadeState = CrossFadeState.showFirst;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Issue Demo',
      home: Scaffold(
        body: Center(
          child: Container(
            color: Colors.red,
            width: 50,
            height: 50,
            child: GestureDetector(
              onTap: () {
                setState(() {
                  xFadeState == CrossFadeState.showSecond ? xFadeState = CrossFadeState.showFirst : xFadeState = CrossFadeState.showSecond;
                });
              },
              child: Center(
                child: AnimatedCrossFade(
                  firstChild: const Text('data'),
                  secondChild: const SizedBox(
                    height: 20,
                    width: 20,
                    child: CircularProgressIndicator(),
                  ),
                  duration: const Duration(milliseconds: 250),
                  crossFadeState: xFadeState,
                ),
              ),
            ),
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 3.3.6, on macOS 13.0 22A380 darwin-arm, locale en-GB)
    • Flutter version 3.3.6 on channel stable at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6928314d50 (2 days ago), 2022-10-25 16:34:41 -0400
    • Engine revision 3ad69d7be3
    • Dart version 2.18.2
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A309
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9014738/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.72.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.0 22A380 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 106.0.5249.119

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 2 categories.

[!] Flutter (Channel master, 3.5.0-10.0.pre.125, on macOS 13.0 22A380 darwin-arm64, locale en-GB)
    • Flutter version 3.5.0-10.0.pre.125 on channel master at /Users/nexus/dev/sdks/flutters
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d9a2229bab (6 hours ago), 2022-10-27 00:30:17 -0400
    • Engine revision 1ea6e5e2de
    • Dart version 2.19.0 (build 2.19.0-343.0.dev)
    • DevTools version 2.18.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A309
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9014738/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.72.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.0 22A380 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 106.0.5249.119

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 3 categories.

I have a similar issue with SizeTransition:

I see a bug in the SizeTransition code (hardcoded ClipRect):
https://github.com/flutter/flutter/blob/d927c9331005f81157fa39dff7b5dab415ad330b/packages/flutter/lib/src/widgets/transitions.dart#LL366C20-L366C20
If you remove ClipRect, then there are no problems. In the AnimatedCrossFade (AnimatedSize) widget, the situation is exactly the same, which is why the bug is observed.

any updates?

I'm also interested in this one, as the code below produces this:

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: Scaffold(
        appBar: AppBar(),
        body: Padding(
          padding: const EdgeInsets.all(32.0),
          child: Center(
            child: Column(
              children: [
                RichText(
                  text: const TextSpan(
                      text: 'Right-aligned bold italic underlined',
                      style: TextStyle(
                        color: Colors.black,
                        fontWeight: FontWeight.w600,
                        fontStyle: FontStyle.italic,
                      )),
                ),
                AnimatedCrossFade(
                  firstChild: RichText(
                    text: const TextSpan(
                        text: 'Right-aligned bold italic underlined',
                        style: TextStyle(
                          color: Colors.black,
                          fontWeight: FontWeight.w600,
                          fontStyle: FontStyle.italic,
                        )),
                  ),
                  secondChild: const SizedBox.shrink(),
                  crossFadeState: CrossFadeState.showFirst,
                  duration: const Duration(milliseconds: 500),
                )
              ],
              // child: Home(),
            ),
          ),
        ),
      ),
    );
  }
}


fix(nsis): prefill $INSTDIR with previous install path and respect /D flag, closes #6928

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x] No

Checklist

[x] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[x] I have added a convincing reason for adding this feature, if necessary

Other information

yeah that's what I intended, but I could change that it users wanted to.


How will you keep this up to date?

Hey, nice project, came from the Reddit post!
My concern is how will you keep this up to date? Your source: https://www.awsiamactions.io/changelog, already has some changes in actions that are not synced with this module.

Good question. Probably the easiest way would be to make a Github action that runs on a regular cron to pick up the changes and deploy them to the terraform registry.
In the meantime you can manually update the json file and run the script to generate the terraform file and put up a PR if there are some things missing.
Sorry I haven't had much time to maintain this since I put it up and don't need many of the newer actions in my own terraform.


Unexpected missing approvals_before_merge warnings

Describe the bug
After converting config file to new merge_requests_approval_rules format, I see multiple warnings, like this
Warning: 'approvals_before_merge' not found in the old 'merge_requests' configuration section - assuming that it is set to 2.

Unfortunately, gitlabform doesn't report, which section has issues and running it in debug mode didn't help either.
GitLabForm version
$ gitlabform -V
🏗 GitLabForm version: 3.4.3 = the latest stable 😊
GitLab version
15.6.8-ee

Hey!
Yes, I am aware of those deprecation messages deficiencies... Sadly I don't have the time to improve them to show the exact place in the config where the issue occurs.
But you can find those places with some regexp search within your config.
For example, I have tried this regexp merge_requests:((.|\n)*?)approvals_before_merge: and it has shown me the places where I have the issue - see the code pointed by the red arrow in the below screenshot:

I found them thank you, we can close this ticket
I will submit another one when I decide if that is a bug or a feature :)


feat: POC for linking issues and pull requests generically

Hi, @mdevilliers Thanks for putting the POC up.
Can you add some description to help others understand how it works and what is the limitation?
Thanks.


Bug - Filters included Callback DSLs

Resolved with https://github.com/Amber-Crystal/amber/pull/34


add mapping quality cutoff in callpeak subcommand for BAM and BAMPE

please consider add mapping quality cutoff for BAM and BAMPE format input during peak calling
thanks

Good point. But why not to polish BAM or BAMPE file first using Picard or Samtools? More manipulations on the raw files are out of the scope of MACS tool.

filtering out of read according to their mapping quality using Picard or samtools will output many files, this will take much disk space, especially when the original BAM file is large. but by setting a cutoff during MACS running time, this will be very helpful to evaluate the impact of mapping quality for peak calling if this feature is supported in the feature release,


feat: ✨ Tweet related widgets

Adds small components used in a parent Tweet component like metrics, username, display name, ..etc.

It looks like this build did not deploy on Widgetbook Cloud. Can you add an action that pushes feature branches on pull-requests?


Remove redundant test suites

Should not be needed now as we are parallelizing on testcase level.

This should make the report cleaner but we need to see its influence on the total build time.


Rename PAGE_SIZE to PAGE_SIZE_ because AppleClang

PAGE_SIZE is a macro in Apple Clang.
Proposed Changes

Rename the PAGE_SIZE constant in examples/quickstart/component_with_custom_heap.cpp to PAGE_SIZE_.

Any background context you want to provide?
...
CompileC cmake-build-debug/examples/quickstart/HPX.build/Debug/component_with_custom_heap.build/Objects-normal/x86_64/component_with_custom_heap.o examples/quickstart/component_with_custom_heap.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
    cd /Users/parsa/Repositories/hpx
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x c++ -arch x86_64 -fmessage-length=204 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -fcolor-diagnostics -Wno-trigraphs -fpascal-strings -O0 -Wno-missing-field-initializers -Wno-missing-prototypes -Wno-return-type -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -Wno-bool-conversion -Wno-enum-conversion -Wno-float-conversion -Wno-non-literal-null-conversion -Wno-objc-literal-conversion -Wno-shorten-64-to-32 -Wno-newline-eof -Wno-c++11-extensions -DCMAKE_INTDIR=\"Debug\" -DHPX_APPLICATION_NAME=component_with_custom_heap -DHPX_APPLICATION_STRING=\"component_with_custom_heap\" -DHPX_PREFIX=\"/Users/parsa/Repositories/hpx/cmake-install-debug\" -DHPX_APPLICATION_EXPORTS -D_GNU_SOURCE -D_DEBUG -DDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.14 -g -Wno-sign-conversion -Wno-infinite-recursion -Wno-move -Wno-comma -Wno-block-capture-autoreleasing -Wno-strict-prototypes -Wno-range-loop-analysis -Wno-semicolon-before-method-body -I/Users/parsa/Repositories/hpx/cmake-build-debug/bin/Debug/include -I/Users/parsa/Repositories/hpx -I/Users/parsa/Repositories/hpx/cmake-build-debug -I/Users/parsa/Repositories/hpx/tests -I/Users/parsa/Repositories/hpx/examples -isystem /usr/local/include -I/Users/parsa/Repositories/hpx/cmake-build-debug/examples/quickstart/HPX.build/Debug/component_with_custom_heap.build/DerivedSources-normal/x86_64 -I/Users/parsa/Repositories/hpx/cmake-build-debug/examples/quickstart/HPX.build/Debug/component_with_custom_heap.build/DerivedSources/x86_64 -I/Users/parsa/Repositories/hpx/cmake-build-debug/examples/quickstart/HPX.build/Debug/component_with_custom_heap.build/DerivedSources -Wmost -Wno-four-char-constants -Wno-unknown-pragmas -F/Users/parsa/Repositories/hpx/cmake-build-debug/bin/Debug -std=c++17 -pthread -ftemplate-depth=256 -Wall -Wextra -Wno-unused-local-typedefs -Wno-strict-aliasing -Wno-sign-promo -Wno-attributes -Wno-cast-align -Wno-unused-parameter -Wformat=2 -Wno-format-nonliteral -Winit-self -Wdouble-promotion -Wcast-qual -Wcast-align -Werror=parentheses -Werror=reorder -Werror=return-type -Werror=sequence-point -Werror=uninitialized -Werror=format -Werror=missing-braces -Werror=sign-compare -fdiagnostics-show-option -Werror=vla -MMD -MT dependencies -MF /Users/parsa/Repositories/hpx/cmake-build-debug/examples/quickstart/HPX.build/Debug/component_with_custom_heap.build/Objects-normal/x86_64/component_with_custom_heap.d --serialize-diagnostics /Users/parsa/Repositories/hpx/cmake-build-debug/examples/quickstart/HPX.build/Debug/component_with_custom_heap.build/Objects-normal/x86_64/component_with_custom_heap.dia -c /Users/parsa/Repositories/hpx/examples/quickstart/component_with_custom_heap.cpp -o /Users/parsa/Repositories/hpx/cmake-build-debug/examples/quickstart/HPX.build/Debug/component_with_custom_heap.build/Objects-normal/x86_64/component_with_custom_heap.o
/Users/parsa/Repositories/hpx/examples/quickstart/component_with_custom_heap.cpp:38:31: error: expected unqualified-id
    HPX_CONSTEXPR std::size_t PAGE_SIZE = 16384;
                              ^
In file included from /Users/parsa/Repositories/hpx/examples/quickstart/component_with_custom_heap.cpp:16:
In file included from /Users/parsa/Repositories/hpx/hpx/include/actions.hpp:14:
In file included from /Users/parsa/Repositories/hpx/hpx/runtime/actions/make_continuation.hpp:12:
In file included from /Users/parsa/Repositories/hpx/hpx/runtime/actions/continuation_impl.hpp:10:
In file included from /Users/parsa/Repositories/hpx/hpx/runtime/applier/apply.hpp:20:
In file included from /Users/parsa/Repositories/hpx/hpx/runtime/parcelset/put_parcel.hpp:9:
In file included from /Users/parsa/Repositories/hpx/hpx/runtime.hpp:26:
In file included from /Users/parsa/Repositories/hpx/hpx/util/runtime_configuration.hpp:16:
In file included from /Users/parsa/Repositories/hpx/hpx/util/plugin/dll.hpp:20:
In file included from /Users/parsa/Repositories/hpx/hpx/util/plugin/detail/dll_dlopen.hpp:37:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach-o/dyld.h:31:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach-o/loader.h:35:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/machine.h:67:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/machine/vm_types.h:33:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/i386/vm_types.h:73:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/i386/vm_param.h:98:33: note: expanded from macro 'PAGE_SIZE'
#define PAGE_SIZE               I386_PGBYTES
                                ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/i386/vm_param.h:95:33: note: expanded from macro 'I386_PGBYTES'
#define I386_PGBYTES            4096            /* bytes per 80386 page */
                                ^
1 error generated.

** BUILD FAILED **

No idea what tests.examples.transpose.transpose_block_numa is or why it fails. But this PR is definitely unrelated to it.

@parsa yep, definitely unrelated to this PR. I'll have a look. Could be related to #3566.


docs: Update managers.mdx

Fix small syntax
Definition of Ready

[ ] I am happy with the code
[ ] Short description of the feature/issue is added in the pr description
[ ] PR is linked to the corresponding user story
[ ] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[ ] No debug or dead code
[ ] My code has no repetitions
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[ ] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] Functionality of the acceptance criteria is checked manually on the dev system.

Hei @hnathehe2
Thanks for your contribution.
For the next time, please have a look that your pr title is compliant with the semantic release, so we can build a version automatically. (docs:)
If you like to get a gift for your contribution, please write an email to<EMAIL_ADDRESS>


fix(ipfs-coord): Bumping to v6.1.4

:tada: This PR is included in version 1.4.4 :tada:
Your semantic-release bot :package::rocket:


SyntaxError: Use of const in strict mode.

When executing in Ubuntu 14.04 LTS using legacy node js v0.10.25, it says:
$ gitp

/usr/local/lib/node_modules/git-pull-hook/node_modules/inquirer/node_modules/figures/index.js:2
const escapeStringRegexp = require('escape-string-regexp');
^^^^^
SyntaxError: Use of const in strict mode.
    at Module._compile (module.js:439:25)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/usr/local/lib/node_modules/git-pull-hook/node_modules/inquirer/lib/objects/separator.js:3:15)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)

Is there any patch available?

It seems to be a node issue

http://stackoverflow.com/questions/22603078/syntaxerror-use-of-const-in-strict-mode

And it seems to be a workaround:

http://stackoverflow.com/questions/8191459/how-do-i-update-node-js/19584407#19584407

Thank you for reporting. Will look into this next week!

So, this is caused by the fact that nodejs 0.10 doesn't support const. I have submitted issues at https://github.com/sindresorhus/figures/issues/22 . I am not sure whether other dependency packages have this problem though.
Meanwhile, why would you use nodejs 0.10? It's so old.

So, the issue I opened is closed. Basically, it's a won't fix there. I am considering to try packing tools like webpack (not sure whether it works for nodejs modules though). So that, all those upstream issues will be solved automatically.


After update to 0.60 Hass.IO doesn't load in iOS devices

Hello.
After update to 0.60 Hass.IO doesn't load in iOS devices. It doesn't work by Safari or APP.
It worked correctly in version 0.59.X before last update.
In others devices like Windows, MAC or Android works fine.
The problem is that it doesn't load the main screen, I attached screenshots.
No errors in the logs file about that
If more information is necessary, tell me
Thank you so much
Regards

UPDATE:
I have resolved it provisionally force to es5 version in configuration.yaml file, because with auto or latest opcions doesn't work

Add these lines to the file configuration.yaml
frontend:
  javascript_version: es5

Versions:
Hass.IO 0.60 (Raspberry 3)
iOS: 10.3.3
App Home Assistant 1.1.1  (latest version available)

I habe the same problem!

Hello.
I have tested some things and i think that is a javascript problem.
I have resolved it provisionally force to es5 version in configuration.yaml file, because with auto or latest opcions doesn't work
frontend:
  javascript_version: es5

I hope it helps to achieve a version compatible with all platforms
Regards

You add this code to the configuration.yaml i understand this right??
frontend:   javascript_version: es5

Right.
This is the link to the documentation of the frontend component:
https://home-assistant.io/components/frontend/
Regards

Ok thanks i test it when i at home

This might help too: https://home-assistant.io/faq/#after-upgrading-your-browser-login-gets-stuck

I not using chrome an the problem is in the app too and there is no option the clear the cookies

It works But now is the problem my 2 sensors show me nothing

😭😭😭

I not using chrome an the problem is in the app too and there is no option the clear the cookies

It can affect all browsers as mentioned.

If that's a Mi Flora then it a possible duplicate of #10790.

Yes its a miflora sensor but it works before the update to 0.60

@chillhahn do you have any errors in your log file?
There were no changes to the miflora component recently, so the problem must come from some other change...

No nothing errors it loads the data normaly in the log

The only thing what i change is  first i update the hass.io and the second is that i add this code
frontend:   javascript_version: es5
to the configuration file that i can see the ui and nothing else

Forcing the javascript version as mentioned by SirSheik fixed the issue for me as well.  As a note, I tried deleting all cookies prior to forcing the javascript and that did not work.

Maybe this issue went off-topic. I think the real issue here is that javascript_version: auto does not serve correctly the legacy Javascript to Safari on iOS 10.
Configuring the frontend to es5 will disable the new code forr all the devices, not only for the old ones.

Seems to only affect ios 10.  Ios 11 device loads hass ok. Unfortunately, 32bit ios devices are stuck at ios10 end of life.

#11201

I have added the javascript_version: es5 to my config, but still getting:
ERROR (MainThread) [homeassistant.core] Timer got out of sync. Resetting

I can confirm that javascript_version: es5 fixes the issue in Safari on my MBP and in the iOS app.  I had to kill the iOS app before history would load.

I did open up the developer console in Safari without the javascript_version: es5 setting.  Here's a screen cap of what I found.

Can confirm it affects iPhone 6 with iOS 11.2.1


Scroll is a bit janky if you go into a calendar day page

Describe the bug
When on mobile, going to calendar day page flickers.
To Reproduce
Steps to reproduce the behavior:

Open vaxx.nz on a phone
Scroll down a few screens
Click on a date
Observe a flicker between page changes

Screenshots

Additional context
The issue is here: https://github.com/CovidEngine/vaxxnz/blob/main/src/scroll.ts#L29 we useEffect with location.pathname dependency, but that only gets applied on the next render - thus rendering 1 frame with an old scroll position.

https://github.com/CovidEngine/vaxxnz/pull/252


Resilience against hacked clients on an anarchy server

Hello - as the title states, is this library resilient against hacked clients and other client modifications? Other than the fact that disguises probably won't move naturally for the entity, is there any network information that implies it's a player or not a real entity?
I ask because this doesn't seem to be documented anywhere. If no, it should probably be explicitly documented that the library is visual-only.

Aside from movement, there should be little to no differences most of the time. Only thing noticable would be higher amount of updates for some entities (paintings/etc), through it shouldn't be an issue

Alright, ty! Closing


Add a fix for new avif cli

coverage: 68.879% (-0.1%) from 68.989%
when pulling 1551a61ed96610885a065e052b84821c2ae22267 on fix-avif-cli
into a8c17d102ddd41414efaed3f876fcca7651abd6a on main.


Import/Export Configs for plugins

I would like to suggest a feature a friend brought to my mind that could be useful.
The ability to Import or Export your plugin configs, For example i made a perfect route in Rogues den using TILE MARKERS, where to click for the best way to go.
Friend asked me to show him all the tiles, and thats when i had an idea that it would be cool if i could somehow share my custom marked tiles to someone else :)
TL;DR - Sharing configs with friends easily

duplicate


Filter features using Geoserver instead of Fiona in shape_selection

Description
It's possible to use WFS services to filter features for polygons containing a point. This would possibly be faster than downloading the features on the server and making the filter operation locally.
See https://enterprise.arcgis.com/fr/server/10.3/publish-services/linux/communicating-with-a-wfs-service-in-a-web-browser.htm

@huard Short answer: Yes.
Longer answer: If we load the data into PostGIS database (converting it from shapefile to database via ogr2ogr) and the expose that on the GeoServer, we can access the service using SQLalchemy/GeoAlchemy using a really simple FROM * SELECT table.feature WHERE ST_CONTAINS(<point location>, table.geom, ...); query.
I've set up PostGIS database accessing local data before. If I can figure out how best to setup and access the database locally without much finagling, we'll absolutely see a performance boost.


Delete instance, But metadata still exists

when I add a new service and run the ingestion. The metadata of table will be displayed on the page where is located Tables of Explore. But I delete the Service, the metadata info still exists. The page shows 'table instance for hive2_231.dw.test.tb3 not found' frequently.

@win-shy please ask in our support before opening github issues. https://slack.open-metadata.org
your ES indexing might have failed, you can re-index to get a up-to-date data in ElasticSearch

@win-shy Hi, have you solved this problem yet?


Adding Name to Entity in Collapsible Group

I currently have a collapsible group that's working as expected, but I am wondering how I can go about changing the name displayed for each sensor? Something like:
collapse:
  - name: 'CR2032 (min: {min}%, count: {count})'
    secondary_info: Battery levels {range}%
    icon: mdi:leak
    entities:
      - entity: sensor.sensor_frontdoor_battery
        name: Front Door Contact

I currently display my entities like:
entities:
      - sensor.sensor_frontdoor_battery

From what I can tell from the docs, adding the name: option below an entity can only be done when the entity is prefixed with - entity:, but inside of a collapsible group it doesn't seem like that is an option.
Version
v3.1.5

The entities collection in the config root is the collection which is used to get entities data. You can specify there all of the entity props/config. The entities collection in the collapse section is just to tell which entities should go to the collapsed part and you cannot specify any properties there.


Fix skipped tests

[x]  quick add should be disable for flat view

[x] hideTree and create a work item then work item should be displayed when show tree is selected

[x] check show completed and create a work item then update status to closed and uncheck show completed then work item should not visible in list

[x] work item should show updated title when switching from flat to tree view

fixed with PR #2563 and #2582


Fix tandem verification trace for non-floating point configs

In configurations without floating point unit, the change from f1dcff8 does not compile.

Is now fixed with commit c7fa4ac


Process  will crash immediately

What version of Go are you using (go version)?
1.13

$ go version

Does this issue reproduce with the latest release?
YES
What operating system and processor architecture are you using (go env)?
Windows，CentOS
go env Output
$ go env

ed25519.go
line：173
if l := len(publicKey); l != PublicKeySize {
	panic("ed25519: bad public key length: " + strconv.Itoa(l))
}

What did you do?
I called the function func Verify , however, the process dies immediately.

What did you expect to see?
I just wanna see the False  judgement
What did you see instead?
Process  immediately crashed.

it is documented to panic:

Verify reports whether sig is a valid signature of message by publicKey. It will panic if len(publicKey) is not PublicKeySize.

Working as documented.


Allow standard Alexnet model for Torch to train on more than 2 GPUs

Any reason why this wasn't turned on earlier?

This is a remnant from the model I imported from there. Now this limitation does not apply anymore. I forgot to remove this as I had only tested up to 2 GPUs (my workstation has only 2).

Gotcha. LGTM!


fix:  If the starting or ending point is the same as the intersection…

… point, return
https://github.com/antvis/X6/issues/4042
https://github.com/antvis/X6/issues/3828
解决跳线异常问题

Description

Motivation and Context

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Enhancement (changes that improvement of current feature or performance)
[ ] Refactoring (changes that neither fixes a bug nor adds a feature)
[ ] Test Case (changes that add missing tests or correct existing tests)
[ ] Code style optimization (changes that do not affect the meaning of the code)
[ ] Docs (changes that only update documentation)
[ ] Chore (changes that don't modify src or test files)

Self Check before Merge

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 10.35%. Comparing base (48ce40b) to head (607905a).
Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4279   +/-   ##
=======================================
  Coverage   10.35%   10.35%
=======================================
  Files         180      180
  Lines       10572    10572
  Branches     2574     2574
=======================================
  Hits         1095     1095
  Misses       9388     9388
  Partials       89       89

Flag
Coverage Δ

x6
10.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

packages/x6/src/registry/connector/jumpover.ts
3.08% <0.00%> (ø)


UrlGenerator is not instantiable

I tried to implement this module in my LUMEN app following your installation guide but it fails on directive @extends('adminlte::page') with this error:
ErrorException
Target [Illuminate\Contracts\Routing\UrlGenerator] is not instantiable. (View: /<path_to_my_app>/vendor/jeroennoten/laravel-adminlte/resources/views/page.blade.php) (View: /<path_to_my_app>/vendor/jeroennoten/laravel-adminlte/resources/views/page.blade.php)
How can I solve this? I know that this is for laravel but maybe you know something that could help me..

This is due to you using Lumen. Lumen simply doesn't have the features of Laravel, some of which this package depends on.
You can try to hack around a little though, since there is a UrlGenerator in Lumen; it's just in another namespace.
However, as Lumen is marketed as a stateless API framework, I'd recommend just using Laravel as you're bound to run into error after error.


Unable to store ADC handles in a struct

Hello,
I would like to create a driver that should read an ADC channel. The idea is to create a struct storing the handles in a new function and then use it afterwards. With the legacy ADC driver this was possible due to the fact that there was no direct link between ADCDriver and ADCChannelDriver. However, the new ADCChannelDriver requires a reference to the ADCDriver. If storing this to a struct, the compiler complains that the reference is a local variable.
Do I understand something wrong? Is there a more obvious solution to achieve something similar?
pub struct WindDirection<'a> {
    adc_driver: AdcDriver<'a, esp_idf_hal::adc::ADC2>,
    adc_channel:
        AdcChannelDriver<'a, esp_idf_hal::gpio::Gpio12, &AdcDriver<'a, esp_idf_hal::adc::ADC2>>,
}

#[allow(dead_code)]
impl<'a> WindDirection<'a>
{
    pub fn new(/*pin: P, adc: impl Peripheral<P = P::Adc> + 'a*/) -> Result<Self, EspError> {
        let config = AdcChannelConfig {
            attenuation: DB_11,
            calibration: true,
            ..Default::default()
        };

        let peripherals = Peripherals::take()?;
        let adc_driver = AdcDriver::<'a>::new(peripherals.adc2)?;
        let adc_channel =
            AdcChannelDriver::<'a>::new(&adc_driver, peripherals.pins.gpio12, &config)?;

        Ok(WindDirection { <---- here the compiler complains
            adc_driver,
            adc_channel,
        })
    }

    pub fn measure(&mut self) -> Result<(), EspError> {
        self.adc_driver.read(&mut self.adc_channel)?;
        Ok(())
    }
}

The compiler error:

error[E0515]: cannot return value referencing local variable `adc_driver`
  --> src/windirection.rs:51:9
   |
49 |               AdcChannelDriver::<'a>::new(&adc_driver, peripherals.pins.gpio12, &config)?;
   |                                           ----------- `adc_driver` is borrowed here
50 |
51 | /         Ok(WindDirection {
52 | |             adc_driver,
53 | |             adc_channel,
54 | |         })
   | |__________^ returns a value referencing data owned by the current function

You are fighting a basic Rust problem, not something related to esp_idf_hal in that you are trying to create a self-referential struct, which cannot be expressed in safe Rust today. Rather than using a simple & borrow of the driver, y9u can instead wrap it in an Arc and then stored the armed driver, as well as pass the armed driver to the channel driver.

thanks a lot.  It worked even that I don't like to wrap everything in arc or refcells... but it seams that's the way rust handle these things.

but it seams that's the way rust handle these things.

Not necessarily. There are other ways, in that you can store in your struct a & reference to AdcDriver together with an owned intance of AdcChannelDriver but then you have to introduce a (covariant) lifetime in the struct and deal with that everywhere.


getSync references process variables instead of loaded environment variables

https://github.com/dkundel/twilio-run/blob/7bb5b6714d54012fcd58789d0a47767528af8ef1/src/internal/runtime.js#L53-L56

Thanks for flagging this @ShelbyZ. I addressed this in the latest version. It should work now and let me know if you find any other issues.
Cheers,
Dominik


Fixed memory leak in OP_TEST_HEAP, whereby the heap would g…

This change fixes the logic in the OP_TEST_HEAP operation, to shrink the heap if more space is being used than needed.  Without this fix, the heap will actually grow, instead of shrinking (because heap_size is added to the requested space).  This change removes the used size from the calculation.
Also added printf's to stderr to diagnose the file location of out of memory errors.  Could be helpful for debugging, and we may want to remove in the future, if it becomes an annoyance.
Signed-off-by: Fred Dushin<EMAIL_ADDRESS>These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

I added some trivial comments, however I need to think more about this fix.


Using iPad I cannot navigate your docs

Describe the bug
Using iPad I cannot navigate your docs.
Expected behavior
I can see the docs menu.
Screenshots

workaround: flip it to portrait:


Can't be used on Arbitrum and Optimism

My understanding is that the deployer address has been "retrodicted" with Nick's method, and the chosen gas price and the gas limit influence what value the deployer address has.
If that is correct, this deployment proxy cannot be used on optimistic rollup chains like Arbitrum or Optimism, because of the way gas is calculated there. E.g. a basic aETH transfer costs ~700k.

The gas limit for the transaction was intentionally chosen to be "significantly higher than necessary" to ensure that moderate changes to gas pricing shouldn't affect the ability to deploy this in the future.  However, very significant gas pricing changes may be too much for the excessive limit to handle.

FYI the contract has been deployed via admin functionality on Arbitrum at the same address

@gakonst oh, that's so cool. Do you know anyone who has the ability to set the deployment proxy at the same address on Optimism?

There are some existing deterministic deployment proxies on Optimism, see https://github.com/ethereum-optimism/optimism/issues/1883
EIP-1820: https://optimistic.etherscan.io/address/0x1820a4b7618bde71dce8cdc73aab6c95905fad24#code
EIP-2470: https://optimistic.etherscan.io/address/0xce0042b868300000d44a59004da54a005ffdcf9f#code
You should be able to deploy this proxy to Optimism as well

Should be deployable to Optimism, can use standard deploy flow

For future reference, "nicks method" deployments will always work on Optimism, sometimes just need to give the account a little extra ETH to pay for fees

Thanks @smartcontracts for deploying Micah's deployment proxy on Optimism!

For future reference, "nicks method" deployments will always work on Optimism, sometimes just need to give the account a little extra ETH to pay for fees

Gotcha.


Carbon Views not extending AppCompat views

Why are all the Carbon Views extending only the normal views? Like, TextView instead of AppCompatTextView? That makes it much harder to use these views with features like AutoResizeText, drawableEnd and more

Platform View classes are lighter and easier to extend. Carbon's goal was to provide correct, working implementations of Material ideas, and using plain View classes was a better option than dealing with existing, broken implementations in AppCompat. For example, AppCompat provides a method to set elevation on pre-Lollipop systems, but it doesn't do anything. I guess I could have kept both options by extending AppCompat classes, but at that point, that didn't seem necessary. I implemented only those features I needed for my project and I could implement them while keeping them working in exactly the same way on all supported API levels.
When it comes to your example, carbon.widget.TextView has a built-in auto-sizing (which was there earlier than for AppCompat) and drawableEnd is not 100% supported by AppCompat too since LTR layouts are missing on lower API levels. The differences in drawable* attributes' support seem to be tinting selected drawables only (which I don't like) and support for vectors, which Carbon replaces with SVG support.
Last but not least, since Carbon is open source, you're free to clone it, change the base classes you need, and use it this way for your projects.


Support larger EDH keys and small cleanups.

In the past we used only 512-bit EDH keys. To protect against the LOGJAM attack, OpenSSL 1.0.1n and later versions reject EDH keys that are less than 768 bits and a future version will increase the minimum to 1024.
We now have DH parameters for 1024-bit and 2048-bit EDH keys and will correctly return and use those, when asked. Note that at this time, OpenSSL will only ask for 512 or 1024 bit keys.
The reverted commit was a workaround for client-side functionality added to IE to protect against LOGJAM. By properly supporting larger keys we no longer need it.

:+1:

I'm not quite sure why the NodeIdentify commit moves the raw DH params code. Was that intentional?

Yes: the function is no longer needed and doesn't need to be exposed public, so I removed the public header and moved it inside the private namespace, just before its use.


Use full height for fullWidth box when left/right

Noticed when looked into https://github.com/chartjs/Chart.js/issues/7321#issuecomment-702569702
The box marked as fullWidth (legend/title), when placed left or right, received only chartArea.height as the maxHeight parameter to update.
The fullWidth property name is no longer optimal, but I'm not sure if its a good idea to change it.

on fullWidth if we want to change that, I think we can do it in a separate ticket. I don't know that any plugin would use it, but it is technically a breaking change


Add wikipedia as a supported attribution link source.

Currently hike.io only support Flickr links when automatically importing attribution metadata. Would be nice to also include Wikipedia since so many images come from there.

Fixed with https://github.com/zaknelson/hike.io/commit/053788c0e1d197f7b3de9c3883bcac1314453ed2
See panoramic photo on http://hike.io/hikes/black-butte


[EventHubs/ServiceBus] update network trace params to use empty strings not None

related to #32190
following #32215
As per the OpenTelemetry spec Attribute Validation, attribute values cannot be None but can be empty strings.

API change check
API changes are not detected in this pull request.

/azp run python - servicebus - tests

/azp run python - eventhub - tests


wezterm: 20210407-nightly -> 20210502-nightly

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Kinda dupe of #121898. We probably shouldn't stay on the nightly builds because they are very close to master.


Gogs custom template with LDAP Integration example

OpenShift template for Gogs with SSL support. LDAP integration is not yet part of the template parameters as can't be automated yet. There is an open issue right now, so this will be added as soon is closed.

Closing the PR to sanitize the README file


Add Lunch & Learn highlights to onboarding resources

Change
Added Lunch And Learn Highlights to onboarding resources.

Ace 👍

💯


fix(annotate): check for errors before attempting to add annotated scrip...

...ts
Thanks to @olov, see https://github.com/nickjanssen/angular-meteor/commit/29d4cf88894598db930e912ded6c3f0b8a88a5f0#commitcomment-10406291
When the annotator fails, it will now throw an error with helpful information:
=> Errors prevented startup:

   While building the application:
   packages/ngAnnotate/plugin/annotate.js:14:1: error: couldn't process source due to
   parse error: Unexpected token (19:2) (compiling client/router.ng.js) (at Package)

=> Your application has errors. Waiting for file change.

Instead of
=> Errors prevented startup:

   While building the application:

   /Users/nickjanssen/.meteor/packages/meteor-tool/.1.1.1.gi7rkz++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/compiler.js:704:17:
   'data' option to addJavaScript must be a string (compiling client/router.ng.js)
   at Object.compileStep.addJavaScript
   (/Users/nickjanssen/.meteor/packages/meteor-tool/.1.1.1.gi7rkz++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/compiler.js:704:17)
   at Package (packages/ngAnnotate/plugin/annotate.js:13:1)

@nickjanssen and @olov  , thanks guys!


Git Username

This change updates my git username.

@ctubbsii Thank you for reviewing this. I have emailed an updated ICLA off to the secretary today so I should regain access to the Apache account shortly and will link everything up. Thank you for continuing to help provide help.

@ctubbsii
I have successfully regained access to my Apache account and have updated my git username at id.apache.org. I also linked the ASF on this github account.

@ctubbsii
I have successfully regained access to my Apache account and have updated my git username at id.apache.org. I also linked the ASF on this github account.

I'm not sure I can merge because under the "This branch has no conflicts" it says "Only those with write access to this repository can merge pull requests".  If I've made another error I apologize in advance.

I'm not sure I can merge because under the "This branch has no conflicts" it says "Only those with write access to this repository can merge pull requests".  If I've made another error I apologize in advance.

I'm not sure I can merge because under the "This branch has no conflicts" it says "Only those with write access to this repository can merge pull requests". If I've made another error I apologize in advance.

Hmm, it seems that your GitHub account isn't fully sync'd in GitBox. Try going to https://gitbox.apache.org/setup/ and ensuring that everything is set up correctly there. If everything is set up correctly, you should see your GitHub user show up in https://github.com/orgs/apache/teams/fluo-committers/members
I could merge for you, but I think it's probably worth using this issue as an exercise to make sure everything is set up correctly. If you can't get it to work after a few days (it may take a few days to sync), I would contact INFRA.

I'm not sure I can merge because under the "This branch has no conflicts" it says "Only those with write access to this repository can merge pull requests". If I've made another error I apologize in advance.

Hmm, it seems that your GitHub account isn't fully sync'd in GitBox. Try going to https://gitbox.apache.org/setup/ and ensuring that everything is set up correctly there. If everything is set up correctly, you should see your GitHub user show up in https://github.com/orgs/apache/teams/fluo-committers/members
I could merge for you, but I think it's probably worth using this issue as an exercise to make sure everything is set up correctly. If you can't get it to work after a few days (it may take a few days to sync), I would contact INFRA.

@ctubbsii Thank you for continuing to be so helpful. I've updated the gitbox information and the LDAP listed the write access to the repositories so I think all I can do now is just wait for it to sync like you said. I also agree that I'd like to be able to merge this so that everything is working and its a good small little test to get things straightened out. Again, thank you for your help!

@ctubbsii Thank you for continuing to be so helpful. I've updated the gitbox information and the LDAP listed the write access to the repositories so I think all I can do now is just wait for it to sync like you said. I also agree that I'd like to be able to merge this so that everything is working and its a good small little test to get things straightened out. Again, thank you for your help!


Update List-HostnamesInContract.ps1

Hi, thanks for the work, but was failing (to me) using PS 7.2 till I added the @() as an array. Hope this helps.

Thanks for the info @pablolurquilopez . I am trying to narrow down the problem, but I suspect the issue is with Powershell's sometimes annoying habit of converting single-item arrays into just an object of that single item. It tends to confuse PS 5. Can you tell me the email address you use to log in to Akamai please? I can try it against your Akamai access to more easily narrow it down. Also these scripts are pretty old and I can make them way more efficient now, so will overhaul them shortly. If you want to list all hostnames in a given account, check out Get-AppSecHostnameCoverage. I think that would give you the whole list, though not which property, group and contract each hostname is associated with.


Add stream method for HuggingFacePipeline Objet

Probably use this
https://huggingface.co/docs/transformers/main/en/generation_strategies#streaming

We probably want to expose the raw generator objects so that people can create streaming APIs w/ SSE

Please don't keep this issue closed I'm facing the same problem: https://stackoverflow.com/questions/77197723/how-do-i-stream-huggingfacepipeline-output-to-a-langchain-dataframe-agent

@PyroGenesis @sam-h-bean I created a pull request which implements the streaming for the HuggingFacePipeline by implementing the _astream method. It is still a bit hacky I think but it works very well. Here is the link to the PR: https://github.com/langchain-ai/langchain/pull/14090
I am currently using the streaming in a chainlit app. It should work with other frontends but I haven't tested it. Below is my chainlit app:
from langchain.llms.huggingface_pipeline import HuggingFacePipeline
from transformers import AutoTokenizer, TextIteratorStreamer
from langchain.prompts import PromptTemplate
from langchain_core.output_parsers.string import StrOutputParser
from langchain_core.runnables.config import RunnableConfig
from langchain_core.runnables.base import Runnable

import transformers
import torch

import chainlit as cl
from chainlit.playground.config import add_llm_provider
from chainlit.playground.providers.langchain import LangchainGenericProvider

template = """
GPT4 Correct User: {question}<|end_of_turn|>GPT4 Correct Assistant:
"""

# Load model and tokenizer

@cl.cache
def load_llama():
    model_name = "berkeley-nest/Starling-LM-7B-alpha"
    model_path = "./model"
    tokenizer = AutoTokenizer.from_pretrained(model_name)
    streamer = TextIteratorStreamer(tokenizer, skip_prompt=True, skip_special_tokens=True)
    pipeline = transformers.pipeline(
        "text-generation",
        model=model_path,
        tokenizer=tokenizer,
        trust_remote_code=True,
        device_map="auto",
        max_length=10000,
        do_sample=True,
        num_return_sequences=1,
        pad_token_id=tokenizer.pad_token_id,
        eos_token_id=tokenizer.eos_token_id,
        streamer=streamer
    )

    llm = HuggingFacePipeline(
        pipeline=pipeline,
        model_kwargs={"temperature": 0.8}
    )
    return llm

llm = load_llama()

# add_llm_provider(
#     LangchainGenericProvider(
#         id=llm._llm_type, name="starling7b", llm=llm, is_chat=False
#     )
# )

@cl.on_chat_start
async def on_chat_start():
    model = load_llama()
    prompt = PromptTemplate(template=template, input_variables=["GPT4 Correct User"])
    runnable = prompt | model | StrOutputParser()
    cl.user_session.set("runnable", runnable)

@cl.on_message
async def on_message(message: cl.Message):
    runnable = cl.user_session.get("runnable")

    msg = cl.Message(content="")

    async for chunk in runnable.astream(
        {"question": message.content},
        config=RunnableConfig(callbacks=[cl.LangchainCallbackHandler()]),
    ):
        await msg.stream_token(chunk)

    await msg.send()

@PyroGenesis @sam-h-bean I created a pull request which implements the streaming for the HuggingFacePipeline by implementing the _astream method. It is still a bit hacky I think but it works very well. Here is the link to the PR: #14090
I am currently using the streaming in a chainlit app. It should work with other frontends but I haven't tested it. Below is my chainlit app:
from langchain.llms.huggingface_pipeline import HuggingFacePipeline
from transformers import AutoTokenizer, TextIteratorStreamer
from langchain.prompts import PromptTemplate
from langchain_core.output_parsers.string import StrOutputParser
from langchain_core.runnables.config import RunnableConfig
from langchain_core.runnables.base import Runnable

import transformers
import torch

import chainlit as cl
from chainlit.playground.config import add_llm_provider
from chainlit.playground.providers.langchain import LangchainGenericProvider

template = """
GPT4 Correct User: {question}<|end_of_turn|>GPT4 Correct Assistant:
"""

# Load model and tokenizer

@cl.cache
def load_llama():
    model_name = "berkeley-nest/Starling-LM-7B-alpha"
    model_path = "./model"
    tokenizer = AutoTokenizer.from_pretrained(model_name)
    streamer = TextIteratorStreamer(tokenizer, skip_prompt=True, skip_special_tokens=True)
    pipeline = transformers.pipeline(
        "text-generation",
        model=model_path,
        tokenizer=tokenizer,
        trust_remote_code=True,
        device_map="auto",
        max_length=10000,
        do_sample=True,
        num_return_sequences=1,
        pad_token_id=tokenizer.pad_token_id,
        eos_token_id=tokenizer.eos_token_id,
        streamer=streamer
    )

    llm = HuggingFacePipeline(
        pipeline=pipeline,
        model_kwargs={"temperature": 0.8}
    )
    return llm

llm = load_llama()

# add_llm_provider(
#     LangchainGenericProvider(
#         id=llm._llm_type, name="starling7b", llm=llm, is_chat=False
#     )
# )

@cl.on_chat_start
async def on_chat_start():
    model = load_llama()
    prompt = PromptTemplate(template=template, input_variables=["GPT4 Correct User"])
    runnable = prompt | model | StrOutputParser()
    cl.user_session.set("runnable", runnable)

@cl.on_message
async def on_message(message: cl.Message):
    runnable = cl.user_session.get("runnable")

    msg = cl.Message(content="")

    async for chunk in runnable.astream(
        {"question": message.content},
        config=RunnableConfig(callbacks=[cl.LangchainCallbackHandler()]),
    ):
        await msg.stream_token(chunk)

    await msg.send()

Thank you for your guidance. I've been experimenting with the code you provided, integrating it into a chainlit app. However, I was curious whether this refers to the output being streamed (word by word) as LangChain intermediate steps, or as the final answer streamed word by word.
In my trials, neither streaming scenario occurred in my Chainlit.


Added Serial number column to fix client link

Added serial column and adjusted existing links to reference correct columns.
Addresses https://github.com/munkireport/munkireport-php/issues/537

thnx!


Restructure TextFlowContainer to be backed by collection of ITextParts

This is the major change that is supposed to facilitate #4636.
Breaking changes
TextFlowContainer no longer returns raw SpriteTexts, returning ITextParts instead
In preparation for adding localisation support to TextFlowContainers, the various AddText()/AddLine() overloads will no longer return raw SpriteTexts. Instead, an ITextPart structure will be returned.
Via ITextPart, the consumer can both access all Drawables associated with a given piece of text, as well as react to any future changes in representation of the text by subscribing to DrawablePartsRecreated. In the future, with more localisation changes, this event will be invoked once a LocalisableString's displayable content changes, which will trigger a recreation of all parts' drawables, upon which any manual adjustments applied to Drawables can be re-applied again.
For consumers wanting to implement their own ITextParts to extend the functionality of TextFlowContainer, an abstract TextPart is also provided which implements the typical flow of handling Drawables and DrawablePartsRecreated. The only thing that a consumer has to do when inheriting that class is to implement CreateDrawablesFor(TextFlowContainer).

I have been sitting on this diff for a few reasons - other than the usual constant deficit of time, I have written this twice (the first attempt was swiftly defeated by existing game-side usage patterns), and feel like it could still use more testing (I have checked the weird usage patterns, as well as ran framework-side and game-side test suites against this change, but this is a change so far-reaching that that still feels too little). Therefore this pull is mostly intended as a request for comments as it comes to the structure.
Due to the size of this change, LocalisableStrings are not yet stored or used in any way by the text flow. But I hope that the breaking change notice explains the central idea behind these changes and the way that they will fit into the localisation structure is self-evident. I have successfully managed to get RomanisableStrings to work with the first iteration of this structure in a test scene.
An early draft of game-side changes to adapt to changes made in this PR can be previewed here.

I haven't gone through the internals for this, but the exposed interface and osu!-side changes look very sane 👍 .

so i was going to go and resolve conflicts here after the merge of #4729, but as it turns out my supposition that this would be easy to apply after that pull was completely wrong and the addition of the generic type arguments forces me to either add generic arguments to all ITextParts (which i don't like because it doesn't really fit with things like TextPartManual - if it wraps an arbitrary drawable, then why should it need a generic type only to be able to add to a TextFlowContainer<T>?), or partially revert that pull by removing the generic-typed TextFlowContainer and instead put the generic typing directly on Add{Text,Paragraph}(), yielding a signature of:
public ITextPart AddText<T>(string text, Action<T> creationParameters = null)
    where T : SpriteText

i doubt this is going to get many opinions seeing there hasn't been any reviews yet, but any opinions on which is better? especially interested in @LeNitrous's opinion since it was your use case in the first place.

i doubt this is going to get many opinions seeing there hasn't been any reviews yet, but any opinions on which is better? especially interested in @LeNitrous's opinion since it was your use case in the first place. i think i personally prefer the latter.

That method signature is better. I suppose making the entire container generic was a bit overkill to begin with.

I could also get behind that.
More-local generic specs should always be preferred as we have found time and time again that class level specs reduce flexibility and increase complexity.

the aforementioned method signature did most of the work, although i did hit yet another snag (the existence of CreateSpriteText() at a TextFlowContainer level). i managed to get past that by creating a DefaultTextChunk that defers to that method of the text flow to create the sprite, rather than using new TSpriteText() as specified by the generic argument.
due to the size of the conflict this all landed in the merge commit. if this is deemed unacceptable then i can rebase this change on top of master  and force-push, or close this PR and reopen again based on current master.
i have not tested very much aside from running framework unit tests and smoke-screening game, but the latest changes do not impact the game-side changes in any way when it comes to compiling at least (no further API breakage is expected than already declared in the OP).

so as it turns out my latest changes attempting to salvage this after #4729 got merged, broke markdown containers, in particular the wiki home page game-side. the reason is that in general text flow's API surface is uncontrollably large, and TextFlowContainer.CreateSpriteText() and TextChunk.CreateSpriteText() both try to control how the sprite text is created, and in this particular case the former takes priority incorrectly. this wasn't an issue before #4729 but is now that there are type arguments in play.
as a last ditch effort before either reverting #4729 or trying to reshape text flow more completely (probably with wider-ranging breaking changes), how unacceptable would you see deleting DefaultTextChunk and having something like this living in TextChunk?
        private TSpriteText createSpriteText(TextFlowContainer textFlowContainer)
        {
            var spriteText = textFlowContainer.CreateSpriteText() as TSpriteText ?? new TSpriteText();
            textFlowContainer.ApplyDefaultCreationParamters(spriteText);
            creationParameters?.Invoke(spriteText);
            return spriteText;
        }

yes, i know, it's a little magic with regards to typing, but as i said, it's a last ditch effort to keep changes minimal. (an alternative would be to pass Func<TSpriteText> delegates to the chunk from the text flow, but that sucks more in my opinion due to the delegate allocations involved, which will get more frequent as the drawables get recreated when the locale changes.)

@bdach ready to get this merged into a release, or still want more time for the osu-side changes?;

this can't be merged as is unfortunately, as CustomisableTextContainer is broken with the latest changes after merging in #4729 here. still haven't figured out a way to fix that i'd be happy with.

I've pushed 684eb43 as a fix for the customizable/markdown text container regression mentioned above. I still don't like it at all, due to introducing yet another delegate, but I don't have many other smart ideas how to simultaneously salvage most of the existing API surface, and apply this part-based direction for text flow.
If the aforementioned commit is deemed acceptable, I've also updated the game-side branch which is as far as I can tell ready to go and which I can PR tomorrow to go along with this. I've tested it both manually and via a full test suite and didn't find any breakage.

Pretty sure I already went through the new commits a while back, and am about as okay with them as I am with the rest of this PR. Maybe we should try and get this one in?


UX Bug: bad journey - add target _blank

Describe the bug
When joining a pool and clicking the 'Creator's address' link you are taken directly to the etherscan page rather than bringing it up in a new tab.. Because of this, when clicking back in the browser you will now have lost your page and be returned to the main page.
To Reproduce
Steps to reproduce the behavior:

Join any pool
Agree and continue
Click 'Creator's address'
Click back on browser window.

Expected behavior
Any external links should open in a new tab or window.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

MacOS 10.12.6
Chrome
87.0.4280.88 (Official Build) (x86_64)

Additional context
Connected via MetaMask using Rinkeby
Wallet address
0x1C69ac5509e5fac81e1636f03F9AAa3EB56CdbE6

Thanks for the report.

Thanks for the report.

todo: add target = "_blank"

todo: add target = "_blank"


[FEAT] Allow for custom URL path

Is your feature request related to a problem? Please describe.
It would be very useful to be able to change the URL path of Double Take so it can run alongside other applications. In my setup, I'm using Nginx to proxy to both Frigate (at /) and Double Take (at /double-take), but the issue is that putting DT in its own location block like below doesn't work.
location /double-take/ {
    auth_request /oauth2/auth;
    error_page 401 = /oauth2/sign_in;

    proxy_pass http://ip6-localhost:3000/;
    proxy_set_header Host $host;
    proxy_set_header X-Real-IP $remote_addr;
    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header X-Forwarded-Proto $scheme;
}

The page doesn't properly load, since DT assumes that it is being accessed at just /. The CSS and JS loads properly (since it uses relative paths), but then requests made to /api/... fail since the correct path would be /double-take/api/.

The URL bar also changes to just /login. The resulting page looks like this (note that I do not have authentication turned on in my config):

Describe the solution you'd like
Ideally, it would be possible to specify the path that Double Take will be available at, for example with the following in the config file:
ui:
  path: /double-take

If there is another solution/workaround please let me know.

Hey @dannytech, I pushed a new beta build that should include a config option just like you suggested. I use traefik as my reverse proxy and was able to test everything under local.domain.com/double-take
Let me know if it works for you.
ui:
  path: /double-take

Thanks, works great with my setup! Had to make sure Nginx requests /double-take/ from the backend, which might be good to document (since some setups simply change the path on the frontend but still serve internally from / which the proxy then rewrites).
location /double-take/ {
    proxy_pass http://ip6-localhost:3000/double-take/;
}


Fix broken link in docs

Moved CONTRIBUTIONS to the crate level

Using this might be better - https://doc.rust-lang.org/cargo/reference/manifest.html#the-exclude-and-include-fields - then its visible in the root in git :)


Fixes notification url in payload

Notification url was sent outside of payment object

This is the right place to put the URL, as we can see here:
https://github.com/ebanx/pay/blob/master/web/inc/bbp/directapi/directrequest.php#L590


Unsafe client access false positive

The following code produces a false positive in the unsafe client access check.
/proc/log_tgui(user_or_client, text)
	var/entry = ""
	if(!user_or_client)
		entry += "no user"
	else if(istype(user_or_client, /mob))
		var/mob/user = user_or_client
		entry += "[user.ckey] (as [user])"
	else if(istype(user_or_client, /client))
		var/client/client = user_or_client
		entry += "[client?.ckey]"
	entry += ":\n[text]"
	WRITE_LOG(GLOB.tgui_log, entry)

If we do istype(var, /client), then any client variables assigned from the checked variable should be considered safe.

Since I know C# well, I might as well take a look at this

#pragma UnsafeClientAccess disabled // NOTE: Only checks for unsafe accesses like "client.foobar" and doesn't consider if the client was already null-checked earlier in the proc

It claims that, but it does appear to be able to determine if (!client) return


Building for My Mac using Xcode 12

It seems when building for the my Mac target in Xcode 12 that the ARCHS is arm64 x86_64 instead of just x86_64, this causes the copy resources script to fail.
In your script I changed the following:
  def self.macos
    OSPlatform.new :macos, 'macosx*', ['x86_64']
  end

to
  def self.macos
    OSPlatform.new :macos, 'macosx*', ['arm64 x86_64']
  end

This fixes the issue when using Xcode 12 but breaks Xcode 11.
I’m also hesitant that changing it here is the right approach.

Hi @Brett-Best,
If anything, it should be:
  def self.macos
    OSPlatform.new :macos, 'macosx*', ['arm64', 'x86_64']
  end

as it is an array. What’s the error exactly? I assumed that pods would compile just fine as they do for iOS, that is, arm64 architecture.

I tried adding it as an array initially but that didn’t work.
The error is:
error: Resource "/Users/brettbest/Library/Developer/Xcode/DerivedData/Bowel_Prep-csirmtnlrczwlwbpugtqzkpfhhnp/Build/Intermediates.noindex/ArchiveIntermediates/Bowel Prep iOS - Development/BuildProductsPath/Release - Development-maccatalyst/AppCenter/AppCenterDistributeResources.bundle" not found. Run 'pod install' to update the copy resources script.```

After changing it to my example the script looks like this:
```bash
if [[ "$CONFIGURATION" == "Release" ]]; then
	if [ "$ARCHS" != "arm64 x86_64" ]; then
	  install_resource "${PODS_CONFIGURATION_BUILD_DIR}/AppCenter/AppCenterDistributeResources.bundle"
	fi
fi
if [[ "$CONFIGURATION" == "Release - Production" ]]; then
	if [ "$ARCHS" != "arm64 x86_64" ]; then
	  install_resource "${PODS_CONFIGURATION_BUILD_DIR}/AppCenter/AppCenterDistributeResources.bundle"
	fi
fi
if [[ "$CONFIGURATION" == "Release - Staging" ]]; then
	if [ "$ARCHS" != "arm64 x86_64" ]; then
	  install_resource "${PODS_CONFIGURATION_BUILD_DIR}/AppCenter/AppCenterDistributeResources.bundle"
	fi
fi
if [[ "$CONFIGURATION" == "Release - Development" ]]; then
	if [ "$ARCHS" != "arm64 x86_64" ]; then
	  install_resource "${PODS_CONFIGURATION_BUILD_DIR}/AppCenter/AppCenterDistributeResources.bundle"
	fi
fi```

The condition is wrong, there should be an OR operation there. This is what the array achieves but still it'd fail because arm64 is shared for iOS and macOS now. There might be another environment value $SDK that would be more suitable, but I’d have to check.
I’ll keep an eye on this, it shouldn’t be very difficult to fix.
Are you compiling with one of the new Silicones?

Compiling with a ‘normal’ machine using Xcode12b3.
if [[ "$CONFIGURATION" == "Release" ]]; then
	if [ "$ARCHS" != "x86_64" ] && [ "$ARCHS" != "arm64 x86_64" ]; then
	  install_resource "${PODS_CONFIGURATION_BUILD_DIR}/AppCenter/AppCenterDistributeResources.bundle"
	fi
fi
if [[ "$CONFIGURATION" == "Release - Production" ]]; then
	if [ "$ARCHS" != "x86_64" ] && [ "$ARCHS" != "arm64 x86_64" ]; then
	  install_resource "${PODS_CONFIGURATION_BUILD_DIR}/AppCenter/AppCenterDistributeResources.bundle"
	fi
fi
if [[ "$CONFIGURATION" == "Release - Staging" ]]; then
	if [ "$ARCHS" != "x86_64" ] && [ "$ARCHS" != "arm64 x86_64" ]; then
	  install_resource "${PODS_CONFIGURATION_BUILD_DIR}/AppCenter/AppCenterDistributeResources.bundle"
	fi
fi
if [[ "$CONFIGURATION" == "Release - Development" ]]; then
	if [ "$ARCHS" != "x86_64" ] && [ "$ARCHS" != "arm64 x86_64" ]; then
	  install_resource "${PODS_CONFIGURATION_BUILD_DIR}/AppCenter/AppCenterDistributeResources.bundle"
	fi
fi

The above seems to work for both Xcode 11 and 12.
  def self.macos
    OSPlatform.new :macos, 'macosx*', ['x86_64', 'arm64 x86_64']
  end

I had to manually change the || to && in the script after the pod installation

Hey @Brett-Best , I think you're not using the last version of the script, could it be possible? You should have something like this:
if [[ "$CONFIGURATION" == "Debug" ]]; then
	if [ test -f "\$${PODS_CONFIGURATION_BUILD_DIR}/AppCenter/AppCenterDistributeResources.bundle" ]; then
	  install_resource "${PODS_CONFIGURATION_BUILD_DIR}/AppCenter/AppCenterDistributeResources.bundle"
	fi
fi
if [[ "$CONFIGURATION" == "Release" ]]; then
	if [ "$ARCHS" != "x86_64" ]; then
	  install_resource "${PODS_CONFIGURATION_BUILD_DIR}/AppCenter/AppCenterDistributeResources.bundle"
	fi
fi

For me it's compiling well in both Xcode 11 and Xcode 12. I've tried archiving too. My dummy Podfile defines:
def catalyst_unsupported_pods
  [
    'AppCenter/Distribute',
    'Firebase/Analytics'
  ]
end

@fermoya
Checked that I’m using the latest version of the script. Debug works fine and I do have the code like what you’ve posted for the debug config.
For some reason $ARCHS is arm64 x86_64 for me when I try to archive with a target of My Mac.
Are you running on macOS 11.0 beta?

nope, I'm running this on macOS 10.15.5. So if you add echo $ARCHS in your *resource.sh file, what does it print?

It prints arm64 x86_64

@Brett-Best . I was wondering why I couldn't build for arm64, maybe it's that and you need to update to the beta first...
Can you try something for me? I rather use the SDKROOT instead of $ARCHS and have a bunch of conditions there. I've updated the script, could you try and let me know if it works on macOS 11 and Xcode 12, please?

Just checked and can confirm it works 🎉 thanks!


Don't Merge! PR real time test for webhook case

Docs Build status updates of commit 7892493:
:clock10: Pending: waiting for processors (25 builds ahead of you)
:warning: Docs Build is busy, currently there are 25 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 7892493:
:clock10: Full build: the average full build time is 5 min(s) 8 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 7892493:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/testing.md
:warning:Warning
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)
Details

docs-ref-conceptual/testing.md

[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.
[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.
[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Enable the evaluation of PHI annotators

The "PHI annotator" is a new NLP Sandbox tool that has a schemas that aggregates the endpoints of the date annotator, person name annotator, etc.
In the controller, instead of doing Tool.type == ToolType.DATE_ANNOTATOR, for example, we need to do Tool.type in [ToolType.DATE_ANNOTATOR, ToolType.PHI_ANNOTATOR].

See https://github.com/nlpsandbox/nlpsandbox/issues/82


Wrong Service creation suggestion

Description
When creating a Service using Monaco editor, we receive a warning, that the Service's targetPort has the wrong type (int) and suggests using a different one (string). That's not right, Service's targetPort might be an int, or might be a string but only if you add a letter to it.

If a user wants to have for example targetPort 9376 and try to change it to "9376", as warning suggests, the creation will fail.

According to the schema:
targetPort:
  description: "IntOrString is a type that can hold an int32 or a string.  When used in JSON or YAML marshalling and unmarshalling, it produces or consumes the inner type.  This allows you to have, for example, a JSON field that can accept a name or number."
  format: "int-or-string"
  type: "string"

Maybe we could use format instead of type, if it exists?

Expected result
Warnings should display the correct information.

Actual result
Warnings show missleading information.

Steps to reproduce
Go to the Service creation form.

Troubleshooting

it will be a feature, we will have to parse the json manually to add custom formats. I remember there are at least 4 custom formats:

int-or-string
date-time
int32
int64

Team decision: if we can come up with a solution not using the Ajv library, that's the way to go.


Fix tests

https://github.com/doctrine/cache/commit/dd47003641aa5425820c0ec8a6f4a85e7412ffcd removes the DoctrineNamespaceCacheKey[] entry from the cache. Thus, all tests counting cache entries were off by one.

@mpdude thanks!
I'll probably have to bump the dependency to doctrine/cache to ~1.5.0 once it's out (also in 2.5.x)

Backported into 2.5 in doctrine/doctrine2@2d1bc787498db7a4dad3925e8e3baf8b02ef79b0