Svelte "TypeError: Cannot read properties of undefined (reading 'from')" and 'Module "buffer" has been externalized for browser compatibility.'

Describe the bug
Hello. I'm trying to create an authentication flow on svelte/sveltekit with using sveltekit api's and server side load function.
This is my "/" route:

Necdetiye Ön Muhasebe Programına Hoş Geldiniz!

    <form on:submit={handleSubmit}>
        Kullanıcı Adı:
        <input type="text" name="nickname" id="nicknameInput" placeholder="Kullanıcı Adınız">
        Şifre:
        <input type="password" name="password" id="passwordInput" placeholder="Şifreniz">
        <input type="submit" value="Giriş Yap">

{statusMessage}

    </form>

this is my "/auth/logining" api route:

import { redirect, json } from "@sveltejs/kit";
import { fetchDatasWithFiltering } from "../../../lib/firebase";
import { decrypt4 } from "necdetiye-crypto";
import { sign } from "jsonwebtoken";

export async function POST(context){
    console.log("our context object: ", context);

    let body = await context.request.json();

    console.log("our body object: ", body);

    let getUserObject = await fetchDatasWithFiltering("users", "nickname", "==", body.nickname);

    console.log("our user object: ", getUserObject);

    if(!getUserObject || getUserObject.length === 0 || getUserObject[0].nickname !== body.nickname){
        return json({ status: false, message: "Hata: Bu kullanıcı ismine sahip hiçbir kullanıcı yok." });
    };

    if(decrypt4(getUserObject[0].password, "asdfsdasfasdsfd") !== body.password){
        return json({ status: false, message: "Hata: Kullanıcı şifresi yanlış." });
    };

    let userObj = {
        nickname: getUserObject[0].nickname,
        email: getUserObject[0].email,
        role: getUserObject[0].role
    }

    let jwtToken = sign({ "nickname": userObj.nickname,
                          "email": userObj.email,
                          "role": userObj.role }, "kfnlksdfhvnkjhsdfkgjs", { expiresIn: "100 days" });

    return new Response(JSON.stringify({
        status: 200,
        headers: {
            "Content-Type": "application/json"
        },
        body: { message: "successfull authentication", token: jwtToken }
    }));
};

When i take the positive response from that route, i redirect to the "/panel" route with a query parameter that contains jwt token that created.
This is the +page.js page of "/panel" route:

import { redirect } from '@sveltejs/kit';
import { decode, verify } from 'jsonwebtoken';

/** @type {import('./$types').PageLoad} */
export function load({url, request, cookies}) {
    console.log("url object: ", url);
    console.log("our cookie: ", url.searchParams.get("token"))

    let ourToken = url.searchParams.get("token");

    if(!ourToken){
        throw redirect(303, "/?error=unauthorized");
    };

    let verifyToken = verify(ourToken, "kfnlksdfhvnkjhsdfkgjs");

    if(!verifyToken){
        throw redirect(303, "/?error=malformedtoken");
    };

    let user = decode(ourToken);

    console.log("/panel server side user obj: ", user);

    return {
        props: {
            data: user
        }
    }
}

this is my +layout.svelte page:

<slot {data}></slot>

and this is +page.svelte file of "/panel" route/folder:

Reproduction
I'm trying to create an authentication flow with this steps:
1 - i'm fetching a server api using fetch api and get jwt token from that api.
2 - i'm using "location.assign()" method with redirecting user to "/panel" route with a query parameter named token that contains token value.
3 - i'm again using jsonwebtoken liblary to verify and decode my jwt token on +page.js pages load function.
4 - i'm taking that user object on +layout.svelte function and sending it to inner routes.
5 - i take that user object on +page.svelte page of "/panel" route and use setContext, hasContext and getContext functions on it.
Logs
My server logs like that:

url object:  URL {
  href: 'http://localhost:5173/panel?token=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJuaWNrbmFtZSI6ImFkbWluIiwiZW1haWwiOiJpbGtlcm1vYmlseWExMDlAZ21haWwuY29tIiwicm9sZSI6ImFkbWluIiwiaWF0IjoxNjk3Mzc0NDIxLCJleHAiOjE3MDYwMTQ0MjF9.PMYkl8Q9hGW9R1ztHFw8yeYdEsDmHTvyB-kNcGCrxW4',
  origin: 'http://localhost:5173',
  protocol: 'http:',
  username: '',
  password: '',
  host: 'localhost:5173',
  hostname: 'localhost',
  port: '5173',
  pathname: '/panel',
  search: '?token=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJuaWNrbmFtZSI6ImFkbWluIiwiZW1haWwiOiJpbGtlcm1vYmlseWExMDlAZ21haWwuY29tIiwicm9sZSI6ImFkbWluIiwiaWF0IjoxNjk3Mzc0NDIxLCJleHAiOjE3MDYwMTQ0MjF9.PMYkl8Q9hGW9R1ztHFw8yeYdEsDmHTvyB-kNcGCrxW4',
  searchParams: URLSearchParams {
    'token' => 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJuaWNrbmFtZSI6ImFkbWluIiwiZW1haWwiOiJpbGtlcm1vYmlseWExMDlAZ21haWwuY29tIiwicm9sZSI6ImFkbWluIiwiaWF0IjoxNjk3Mzc0NDIxLCJleHAiOjE3MDYwMTQ0MjF9.PMYkl8Q9hGW9R1ztHFw8yeYdEsDmHTvyB-kNcGCrxW4' },
  hash: ''
}
our cookie:  eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJuaWNrbmFtZSI6ImFkbWluIiwiZW1haWwiOiJpbGtlcm1vYmlseWExMDlAZ21haWwuY29tIiwicm9sZSI6ImFkbWluIiwiaWF0IjoxNjk3Mzc0NDIxLCJleHAiOjE3MDYwMTQ0MjF9.PMYkl8Q9hGW9R1ztHFw8yeYdEsDmHTvyB-kNcGCrxW4
/panel server side user obj:  {
  nickname: 'admin',
  email<EMAIL_ADDRESS>  role: 'admin',
  iat:<PHONE_NUMBER>,
  exp:<PHONE_NUMBER>
}
+layout.svelte page data:  {}
+page.svelte page data obj:  {
  props: {
    data: {
      nickname: 'admin',
      email<EMAIL_ADDRESS>      role: 'admin',
      iat:<PHONE_NUMBER>,
      exp:<PHONE_NUMBER>
    }
  }
}

but my browser outputs like that and on page it only wrotes "500 internal error":

client.js?v=de4db00a:2083 Module "buffer" has been externalized for browser compatibility. Cannot access "buffer.Buffer" in client code. See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
warn	@	client.js?v=de4db00a:2083
get	@	browser-external:buffer:9
node_modules/safe-buffer/index.js	@	index.js:4
__require	@	chunk-XNHBATJA.js?v=de4db00a:5
node_modules/jws/lib/sign-stream.js	@	sign-stream.js:2
__require	@	chunk-XNHBATJA.js?v=de4db00a:5
node_modules/jws/index.js	@	index.js:2
__require	@	chunk-XNHBATJA.js?v=de4db00a:5
node_modules/jsonwebtoken/decode.js	@	decode.js:1
__require	@	chunk-XNHBATJA.js?v=de4db00a:5
node_modules/jsonwebtoken/index.js	@	index.js:2
__require	@	chunk-XNHBATJA.js?v=de4db00a:5
(anonim)	@	index.js:8

client.js?v=de4db00a:2083 The next HMR update will cause the page to reload
warn	@	client.js?v=de4db00a:2083
handle_error	@	client.js?v=de4db00a:1328
_hydrate	@	client.js?v=de4db00a:1834
await in _hydrate (eş zamansız)
start	@	start.js:22
(anonim)	@	panel?token=eyJhbGci…mHTvyB-kNcGCrxW4:28
Promise.then (eş zamansız)
(anonim)	@	panel?token=eyJhbGci…mHTvyB-kNcGCrxW4:27

TypeError: Cannot read properties of undefined (reading 'from')
    at node_modules/safe-buffer/index.js (index.js:12:12)
    at __require (chunk-XNHBATJA.js?v=de4db00a:5:50)
    at node_modules/jws/lib/sign-stream.js (sign-stream.js:2:14)
    at __require (chunk-XNHBATJA.js?v=de4db00a:5:50)
    at node_modules/jws/index.js (index.js:2:18)
    at __require (chunk-XNHBATJA.js?v=de4db00a:5:50)
    at node_modules/jsonwebtoken/decode.js (decode.js:1:11)
    at __require (chunk-XNHBATJA.js?v=de4db00a:5:50)
    at node_modules/jsonwebtoken/index.js (index.js:2:11)
    at __require (chunk-XNHBATJA.js?v=de4db00a:5:50)

<Root> was created without expected prop 'form'
warn	@	client.js?v=de4db00a:2083
(anonim)	@	root.svelte:39
run	@	utils.js:41
(anonim)	@	Component.js:47
flush	@	scheduler.js:99
init	@	Component.js:164
Root	@	root.svelte:21
createProxiedComponent	@	svelte-hooks.js?v=de4db00a:341
ProxyComponent	@	proxy.js?v=de4db00a:242
Proxy<Root>	@	proxy.js?v=de4db00a:349
initialize	@	client.js?v=de4db00a:288
_hydrate	@	client.js?v=de4db00a:1840
await in _hydrate (eş zamansız)
start	@	start.js:22
(anonim)	@	panel?token=eyJhbGci…mHTvyB-kNcGCrxW4:28
Promise.then (eş zamansız)
(anonim)	@	panel?token=eyJhbGci…mHTvyB-kNcGCrxW4:27

I don't have any idea why this error happens. I run the "decode" function of jsonwebtoken liblary on +page.js file, which is suppose to be a server component. And how can i fix this weird error?

### System Info

```shell
System:
    OS: Windows 10 10.0.22621
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
    Memory: 9.12 GB / 23.70 GB
  Binaries:
    Node: 18.12.1 - D:\Node.js\node.EXE
    npm: 8.19.2 - D:\Node.js\npm.CMD
  Browsers:
    Edge: Chromium (118.0.2088.46)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    svelte: ^4.0.5 => 4.2.1

Severity
blocking all usage of svelte

please provide a link to a complete and minimal reproduction. this is required.
Note that it's very likely not an issue in kit but either the crypto library you use or your setup. We do not provide support on github issues and i recommend asking for help on https://svelte.dev/chat

please provide a link to a complete and minimal reproduction. this is required.
Note that it's very likely not an issue in kit but either the crypto library you use or your setup. We do not provide support on github issues and i recommend asking for help on https://svelte.dev/chat

Issue is quite easy: the "decode" function of node.js's famous most well known jsonwebtoken liblary is not working on +page.js page, which it suppose to be a server component. In node.js servers it works without any problem and because of that it should work on sveltekit's server components also, but i don't know why it doesn't. Issue is that, there is no need for me to sending a github repo for that.

from our new issue dialog:

A link to a repository, or a fork of https://node.new/sveltekit, that reproduces the issue. Reproductions must be short, self-contained and correct and must not contain files or code that aren't relevant to the issue — please do NOT just paste a link to your project. Explaining how to reproduce is generally not enough. It pushes the burden of creating a reproduction project onto a small set of volunteer maintainers and isn't scalable. If no reproduction is provided, the issue will be closed.

again, this is not the place to ask how to set up authentication with sveltekit, this is the place to report reproducible bugs. "i don't know" doesn't count

from our new issue dialog:

A link to a repository, or a fork of https://node.new/sveltekit, that reproduces the issue. Reproductions must be short, self-contained and correct and must not contain files or code that aren't relevant to the issue — please do NOT just paste a link to your project. Explaining how to reproduce is generally not enough. It pushes the burden of creating a reproduction project onto a small set of volunteer maintainers and isn't scalable. If no reproduction is provided, the issue will be closed.

again, this is not the place to ask how to set up authentication with sveltekit, this is the place to report reproducible bugs. "i don't know" doesn't count

Okey, that's fine. I try to create authentication flow with other ways, if i couldn't, if your framework is not stable yet or it's too nitty gritty i use next.js and you'll lose a developer. I don't want any solution from you anymore. I never deal with adding a github repo or minimal reproduction for that simple thing. I'm not your servant. Your +page.js components not exactly work like server component. Do whatever you want that report.

Sounds like you want +layout/page.server.js, not +layout/page.js, see https://kit.svelte.dev/docs/load#universal-vs-server

Sounds like you want +layout/page.server.js, not +layout/page.js, see https://kit.svelte.dev/docs/load#universal-vs-server

thanks, it helped me.


OpenStack not listing private images

Hi,
I've been trying to deploy cloudbreak on a public openstack cloud but it does not work since i'm unable to upload hdc-hdp--XXX.img as a "public" image.
From what i have seen it looks like this is using the V1 of the image API.
code in github : https://github.com/hortonworks/cloudbreak/blob/9705848c6a29e706b6d35b4df0dc10e58b459bc7/cloud-openstack/src/main/java/com/sequenceiq/cloudbreak/cloud/openstack/common/OpenStackSetup.java#L82
This is using image().listAll() and this method will only list public image meaning i will never find my hdc-hdp--XXX.img  image since i can only upload "private" image (src = http://www.openstack4j.com/javadoc/org/openstack4j/api/image/ImageService.html#listAll--)
My knowledge of this project is limited  but i did try to change line 82 to imageV2().list() (updating the import too ofc) and i can build the project without any issue. (src = http://www.openstack4j.com/javadoc/org/openstack4j/api/image/v2/ImageService.html#list--)
How can i know i haven't broke anything ? Should i create a branch with my modification and submit a merge request ?
ps : this could be linked to https://github.com/hortonworks/cloudbreak/issues/2649
Thanks for your help.

Hi @ValentinOdier ,
First of all thanks for the info and hopefully we should solve this error with your help.
"How can i know i haven't broke anything ?" Cross your fingers :D but apart of joke, what you can do is test your change on your environment with public and private images. If works you can execute ./gradlew build to be sure everything is formally ok. Than you can create a pull request. Our basic tests are executing on pull requests. Someone will approve, and we have nightly tests on our openstack environment. So please feel free to send merge/pull request.

Ok thanks for the info.
ATM i am able to do a clean build but i haven't tried to run it yet. I'm not on mac and i'm a bit lost with instructions.
I will have a closer look and see if i can make it work

We have a pull request for this: https://github.com/hortonworks/cloudbreak/pull/3068

Hi, i sow this was even merged to master. I don't fully understand your release process yet.
I would gladly try it but i seems i'm not getting a version with this fixed. Which cloudbreak-deployer should i be using to try it out ?

Hi @ValentinOdier ,
Deployer doesn't offer any unstable builds. You have to download manually by executing something like this:
curl -L s3.amazonaws.com/public-repo-1.hortonworks.com/HDP/cloudbreak/cloudbreak-deployer_snapshot_$(uname)_x86_64.tgz | tar -xz -C $(dirname $(which cbd))


Contribution of GPU Management Profile

Copied from OCP contribution database v0.9.1

Approved to merge.


Remove style.css from the repo

It's in the repo for the package JSON files (main) however I need to revisit the specs and see what other peeps are doing, it should be style.scss.

Covered in #108.


sw_engine: Fix for rendering short paths

I updated tvgSwStroke.cpp to ensure it does not terminate prematurely for paths with a step of 0 or exceptionally small values when a valid stroke-width is present.
As part of the examples, I introduced a program called ./StrokeShort, which demonstrates the correct rendering of lines in such cases with various stroke-cap settings.

I also added an SVG file (stroke-short.svg) to the resources, which can be viewed using the ./Svg program. It now renders correctly.
Issues: https://github.com/thorvg/thorvg/issues/3065

@baszczewski Thank you for your contribution. That would be nicer if you can send a PR with only engine fix in this case. The examples in ThorVG are not specifically designed for feature-testing but rather serve as a user guide, providing hints on how to use ThorVG through various samples.

@hermet  Of course, I have removed the unnecessary example. I hope this small commit can be helpful.

@baszczewski hello, many thanks. could you please check these? (otherwise, you can leave them to me.)

you can double-check my comments.
add yourself -> https://github.com/thorvg/thorvg/blob/main/AUTHORS
squash commits to one.

@hermet Thank you for your support on this matter. I have implemented your suggestions.


Networking issues with ubuntu provisioned image

Setup
docker-machine create --driver digitalocean --digitalocean-access-token $DO_PAT --digitalocean-region lon1 --digitalocean-size 1gb foo
eval "$(docker-machine env -u)"
eval "$(docker-machine env foo)"

Works fine on a virtualbox provisional
docker run --name some-mysql -e MYSQL_ROOT_PASSWORD=password -d mariadb:5.5
docker run --name wpldn --link some-mysql:mysql -p 80:80 -d wordpress:4.5-apache
docker logs wpldn
WordPress not found in /var/www/html - copying now...
Complete! WordPress has been successfully copied to /var/www/html

Warning: mysqli::mysqli(): (HY000/2002): Connection refused in - on line 10

MySQL Connection Error: (2002) Connection refused

diagnostics
docker version
Client:
 Version:      1.11.0
 API version:  1.23
 Go version:   go1.6.1
 Git commit:   4dc5990
 Built:        Thu Apr 14 00:24:28 UTC 2016
 OS/Arch:      darwin/amd64

Server:
 Version:      1.11.1
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   5604cbe
 Built:        Tue Apr 26 23:38:55 2016
 OS/Arch:      linux/amd64

docker-machine version 0.7.0, build a650a40 (machine is running OSX)

docker-machine ssh foo uname -a
Linux dddwa 4.2.0-27-generic #32-Ubuntu SMP Fri Jan 22 04:49:08 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 15.10
Release:	15.10
Codename:	wily

What's logs of mysql container?  Did it exit for any reason, e.g. OOM?

mysql container still running, looks like a normal log to me:
docker logs some-mysql
*snip*
160502 10:49:53 Percona XtraDB (http://www.percona.com) 5.5.48-MariaDB-37.8 started; log sequence number 0
160502 10:49:53 [Note] Plugin 'FEEDBACK' is disabled.
160502 10:49:53 [Warning] 'user' entry 'root@932994102df7' ignored in --skip-name-resolve mode.
160502 10:49:53 [Warning] 'proxies_priv' entry '@ root@932994102df7' ignored in --skip-name-resolve mode.
160502 10:49:53 [Note] Event Scheduler: Loaded 0 events
160502 10:49:53 [Note] mysqld: ready for connections.
Version: '5.5.49-MariaDB-1~wheezy'  socket: '/var/run/mysqld/mysqld.sock'  port: 0  mariadb.org binary distribution
160502 10:49:55 [Warning] 'proxies_priv' entry '@ root@932994102df7' ignored in --skip-name-resolve mode.

Also I've now upgraded to docker for mac beta (Version 1.11.0-beta9 (build: 6388)
965e3f981d73fe82857f3c1439ba3dc1acaecab6), same problem still happening. It's as if --link isn't working, any way I can provide more diagnostics?

Can you get it to work by putting them on the same docker network? --link is deprecated / legacy.  If there's a regression, best to just switch over to the new model.
docker network create wordpress

docker run \
    --net wordpress \
    --net-alias mysql \
    --name some-mysql \
    -e MYSQL_ROOT_PASSWORD=password \
    -d mariadb:5.5

docker run \
    --net wordpress \
    --name wpldn \
    -p 80:80 \
    -d wordpress:4.5-apache

IIRC

Unfortunately it doesn't work, one of the benefits of --link was to share the ENV variables with the linking container.
The WordPress container (specifically the entrypoint.sh script) is expecting to find, these environment variables
MYSQL_ENV_MYSQL_ROOT_PASSWORD=xxx
MYSQL_PORT_3306_TCP=tcp://<IP_ADDRESS>:3306

I think I've found a workaround by using --env-file and storing those variables in a file (replacing the ip address with the network alias mysql). It's a shame it was nice to have these secrets being passed around automatically. I'll do some proper testing to make sure it works.


Add support for refined Char (lowercase and uppercase)

Add Prism for refined Char

👍 Thanks @sindoudou


[XLA] Add support to specify boundary nodes in interactive_grahviz tool.

The enhanced command is <instr> [<width>] [/ <boundary_instr1> <boundary_instr2> ...].
The boundary nodes are optional. This is useful in cases where one wants to further prune
a graph when using a large width.

@rthadur Is there anything else I need to do? The CI seems to be failed. Maybe it requires a restart. Thanks.

I have no idea what's going on here. The changes in this pull request did land in TF's master branch already, but the pull request itself seems to be stuck in some weird state.

I think our system wants a 1:1 correspondence between PRs and CLs that eventually get submitted.  Because we've already submitted a CL here, I'd recommend closing this PR and opening a new one for any followups.

Please let me know what I need to do on my side.

It looks like there was a race -- viz_improve branch got updated while I've already been in the process of submitting the change. Once my copy landed, there was a minor conflict on this pull request that I've resolved, but there's still one tiny bit of difference left. I suspect internal review tracker ping-ponging on abandoning review was triggered by the pull request updates.
Overall I think we're good now and we can close this pull request as the changes are already in TF, despite the 'open' status.


Unexpected error when a split file has a bad format

See https://huggingface.co/datasets/severo/test-one-split-broken/viewer/default/works
https://datasets-server.huggingface.co/rows?dataset=severo/test-one-split-broken&config=default&split=works returns {"error":"Unexpected error."}.
The reason is that config-parquet-and-info fails because the other split ('broken') file is not in the right format: https://huggingface.co/datasets/severo/test-one-split-broken/blob/main/broken.json
Could we detect this and show a more meaningful error?
traceback
{
  "error": "An error occurred while generating the dataset",
  "cause_exception": "DatasetGenerationError",
  "cause_message": "An error occurred while generating the dataset",
  "cause_traceback": [
    "Traceback (most recent call last):\n",
    " File \"/src/services/worker/.venv/lib/python3.9/site-packages/datasets/packaged_modules/json/json.py\", line 144, in _generate_tables\n dataset = json.load(f)\n",
    " File \"/usr/local/lib/python3.9/json/__init__.py\", line 293, in load\n return loads(fp.read(),\n",
    " File \"/usr/local/lib/python3.9/json/__init__.py\", line 346, in loads\n return _default_decoder.decode(s)\n",
    " File \"/usr/local/lib/python3.9/json/decoder.py\", line 337, in decode\n obj, end = self.raw_decode(s, idx=_w(s, 0).end())\n",
    " File \"/usr/local/lib/python3.9/json/decoder.py\", line 355, in raw_decode\n raise JSONDecodeError(\"Expecting value\", s, err.value) from None\n",
    "json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)\n",
    "\nDuring handling of the above exception, another exception occurred:\n\n",
    "Traceback (most recent call last):\n",
    " File \"/src/services/worker/.venv/lib/python3.9/site-packages/datasets/builder.py\", line 1973, in _prepare_split_single\n for _, table in generator:\n",
    " File \"/src/services/worker/.venv/lib/python3.9/site-packages/datasets/packaged_modules/json/json.py\", line 147, in _generate_tables\n raise e\n",
    " File \"/src/services/worker/.venv/lib/python3.9/site-packages/datasets/packaged_modules/json/json.py\", line 121, in _generate_tables\n pa_table = paj.read_json(\n",
    " File \"pyarrow/_json.pyx\", line 308, in pyarrow._json.read_json\n",
    " File \"pyarrow/error.pxi\", line 154, in pyarrow.lib.pyarrow_internal_check_status\n",
    " File \"pyarrow/error.pxi\", line 91, in pyarrow.lib.check_status\n",
    "pyarrow.lib.ArrowInvalid: JSON parse error: Invalid value. in row 0\n",
    "\nThe above exception was the direct cause of the following exception:\n\n",
    "Traceback (most recent call last):\n",
    " File \"/src/services/worker/src/worker/job_manager.py\", line 154, in process\n job_result = self.job_runner.compute()\n",
    " File \"/src/services/worker/src/worker/job_runners/config/parquet_and_info.py\", line 1287, in compute\n compute_config_parquet_and_info_response(\n",
    " File \"/src/services/worker/src/worker/job_runners/config/parquet_and_info.py\", line 1202, in compute_config_parquet_and_info_response\n parquet_operations = convert_to_parquet(builder)\n",
    " File \"/src/services/worker/src/worker/job_runners/config/parquet_and_info.py\", line 828, in convert_to_parquet\n builder.download_and_prepare(\n",
    " File \"/src/services/worker/.venv/lib/python3.9/site-packages/datasets/builder.py\", line 1005, in download_and_prepare\n self._download_and_prepare(\n",
    " File \"/src/services/worker/.venv/lib/python3.9/site-packages/datasets/builder.py\", line 1100, in _download_and_prepare\n self._prepare_split(split_generator, **prepare_split_kwargs)\n",
    " File \"/src/services/worker/.venv/lib/python3.9/site-packages/datasets/builder.py\", line 1860, in _prepare_split\n for job_id, done, content in self._prepare_split_single(\n",
    " File \"/src/services/worker/.venv/lib/python3.9/site-packages/datasets/builder.py\", line 2016, in _prepare_split_single\n raise DatasetGenerationError(\"An error occurred while generating the dataset\") from e\n",
    "datasets.exceptions.DatasetGenerationError: An error occurred while generating the dataset\n"
  ]
}

related to #1443


Refactor Images

Summary
Refactoring Media (CVS-107626).
A following work of #911.

Refactored Image, RoIImage, MosaicImage
Deprecated ByteImage
Fixed PointCloud design mismatch
Added extra images save functionality in PointCloud
Fixed to compare contents in tests.utils.test_utils.compare_datasets_3d

We may require to split the medi.py into multiple files.
How to test
Checklist

[x] I have added unit tests to cover my changes.
[ ] I have added integration tests to cover my changes.
[x] I have added the description of my changes into CHANGELOG.
[ ] I have updated the documentation accordingly

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below).

# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Codecov Report
Patch coverage: 77.27% and project coverage change: -0.07 :warning:

Comparison is base (d122ab8) 78.88% compared to head (f3d58ff) 78.82%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #921      +/-   ##
===========================================
- Coverage    78.88%   78.82%   -0.07%
===========================================
  Files          215      215
  Lines        25220    25426     +206
  Branches      5046     5081      +35
===========================================
+ Hits         19895    20042     +147
- Misses        4191     4224      +33
- Partials      1134     1160      +26

Flag
Coverage Δ

macos-11_Python-3.8
?

ubuntu-20.04_Python-3.8
78.82% <77.27%> (-0.06%)
:arrow_down:

windows-2019_Python-3.8
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

datumaro/components/dataset_base.py
74.69% <0.00%> (ø)

datumaro/components/filter.py
91.34% <0.00%> (-0.93%)
:arrow_down:

datumaro/plugins/data_formats/ade20k2017.py
83.00% <ø> (ø)

datumaro/plugins/data_formats/ade20k2020.py
85.24% <ø> (ø)

datumaro/plugins/data_formats/ava/ava.py
84.00% <ø> (ø)

datumaro/plugins/data_formats/camvid.py
87.14% <ø> (ø)

datumaro/plugins/data_formats/coco/base.py
92.09% <ø> (ø)

...ugins/data_formats/datumaro_binary/mapper/media.py
86.66% <ø> (ø)

datumaro/plugins/data_formats/imagenet_txt.py
86.56% <ø> (ø)

datumaro/plugins/data_formats/kitti_raw/base.py
84.44% <ø> (ø)

... and 46 more

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Issue38 rules audit

Coverage decreased (-0.7%) to 94.602% when pulling 99949e20b8d9de0262fad4ed4aaf7b183733d0a5 on Issue38_RulesAudit into a043029f7b8542efa17f56965c162f21f4f29eb5 on develop.

Coverage decreased (-0.7%) to 94.602% when pulling a571b86c3d4cbd5c81804577bc184b380b20cff3 on Issue38_RulesAudit into a043029f7b8542efa17f56965c162f21f4f29eb5 on develop.

Coverage decreased (-0.7%) to 94.602% when pulling a571b86c3d4cbd5c81804577bc184b380b20cff3 on Issue38_RulesAudit into a043029f7b8542efa17f56965c162f21f4f29eb5 on develop.


"kubectl get pods" should return (possibly truncated) hostname

@bprashanth ran into a scenario where the scheduler was putting all the pods onto the same node. A user would be very unlikely to notice this kind of thing now that we took hostname out of the output of "kubectl get pods." I think we should put it back in. To keep the length under control, we can either truncate it to a fixed length or (clever idea from @lavalamp) have kubectl compute the part that is the same across all entries that would be returned, and only print the part of the other part of the hostname (the part that varies).
@dchen1107 @bgrant0607 @jlowdermilk

or maybe get nodes can show the count of pods

I've definitely had requests to have a kubectl way to list the pods (and resources consumed) for each node.
This is low risk, and easy to do, so I think it's legit for v1.0.

describe nodes should list the pods, or at least a count and resources reserved, as discussed in #9356

get nodes could show the pod count if we put that in PodStatus in the API.

I don't think "describe nodes" or even "describe pods" is adequate. Many users are probably going to use "get pods" and not think to try anything else. I don't think this will make "get pods" laughably wide as long as we truncate the node name in a sensible way.

Is node name the most important field that got cut?  I'm not sure of that.
On Tue, Jun 23, 2015 at 11:07 PM, David Oppenheimer <
<EMAIL_ADDRESS>wrote:

I don't think "describe nodes" or even "describe pods" is adequate. Many
users are probably going to use "get pods" and not think to try anything
else. I don't think this will make "get pods" laughably wide as long as we
truncate the node name in a sensible way.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/10262#issuecomment-114740193
.

By default, node name should not be in get pods output. That violates separation of concerns. We don't want users to think about the nodes, in general. That's a cluster admin concern. It can be in describe pods and we could list/count pods in describe nodes. Or, you could use -o template or -o json | jq to print whatever fields you like.
We could maybe add a verbose flag of some kind to print wide columnar output, but that would be a bigger change.

I've definitely had requests to have a kubectl way to list the pods (and resources consumed) for each node.

a describe nodes without any argument would be cool, one of my most used bash_rc functions shows pods/services per node and health.

Yeah, I really want get -o wide to give me the old view (or something like
it)
On Wed, Jun 24, 2015 at 10:27 AM, Brian Grant<EMAIL_ADDRESS>wrote:

By default, node name should not be in get pods output. That violates
separation of concerns. We don't want users to think about the nodes, in
general. That's a cluster admin concern. It can be in describe pods and we
could list/count pods in describe nodes. Or, you could use -o template or -o
json | jq to print whatever fields you like.
We could maybe add a verbose flag of some kind to print wide columnar
output, but that would be a bigger change.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/10262#issuecomment-114947697
.

cc @ghodss @andronat

We discussed and came up with a compromise (which apparently was the plan to do eventually anyway) of adding "-o wide" that would print hostname and perhaps other stuff as well. @bgrant0607 pointed out we should make "-o wide" work for all the commands/objects (even if it gives you an identical output to the default for most commands/objects). I'll re-title the issue appropriately. Also, @JanetKuo was interested in working on this.

make "-o wide" work for all the commands/objects

I just meant all objects. I think the idea was that we would only have -o wide for "get" not for things like "describe" (but if I misunderstood, I'm sure someone will correct me).

Past discussion was in #7843

Discussed with @bgrant0607 and decided to start with adding one more column for get pods -o wide, which is NODE (NodeName in API); get services -o wide will just show default columns.
We may add some more columns later, such as ClusterIP, SessionAffinity, etc.


'myproject.alembic.versions.5fd6d5c5385c_init' is not a valid module name

I receive this exception while cythoning an alembic file:
myproject/alembic/versions/5fd6d5c5385c_init.py:1:0: 'myproject.alembic.versions.5fd6d5c5385c_init' is not a valid module name

I tried to rename the file adding a character at the beginning (e.g. f5fd6d5c5385c_init.py) and the error disappeared. This means that the problem is related to the filename. More precisely the problem comes when the filename starts with a number.

This seems correct - module names can't start with a number? It's more likely to be a bug in alembic if it's generating names that start with a number.
It's possible they're only designed to be used as a script rather than imported in which case it might be OK. If that's the case you should probably be using Cython with the --embed option to generate something callable rather than importable.

they're only designed to be used as a script rather than imported

Yes. And I recommend against compiling them. That's way too much overhead and these scripts are extremely unlikely to be CPU bound themselves.


Add a dynamic sitemap

Context
Sitemaps are used by search engines to index your page.
Changes proposed in this pull request
This replaces the hardcoded sitemap with something that is generated on
the fly.
This also uses in-memory caching because sitemap generation is expensive.
Guidance to review
n/a

 Make Search sitemap dynamic


JSDoc : support @interface and @implements (and more)

I would like to re-open an issue: https://github.com/microsoft/TypeScript/issues/16142
As it is locked I am to open this new issue.
I personally do not like TypeScript as a language, I do however, like TypeScript as a tool for my JavaScript projects, hence why I would like more support for JSDoc.
Code
In a JavaScript file, with checkJs option :
/**
 * @interface Something
 */

/**
 * @function
 * @name Something#hello
 * @param {string} name
 */

/**
 * @implements {Something}
 */
const something = {};

Actual behavior:
No error.
Expected behavior:
An error should be raised. It's important in checkJs mode as JavaScript doesn't have native interfaces.

I also really need '@interface' support, I expect to use type federation in JS to support multiple type merges (based on JSDoc)

Potential Use Cases for Interfaces in JSDocs
Pinging @sandersn as request in #42877.
Extending Interfaces That an Application or Library Does Not Own
Currently, I'm working on a JS library that will work in all JS applications. Let's call it, @my-scope/core. For the sake of developer experience, I'm also releasing framework-specific integrations of this package. These packages make adoption of the core library easier by making the tool more ergonomic in the framework where it's used.  This means I have packages like @my-scope/svelte, @my-scope/react, etc.
All of these packages are intended to use regular JS Files. (There are no TypeScript files, except when .d.ts is necessary to get the features that are lacking in JSDocs.) All of the framework-integration packages build on top of the core. In part, this means that some of the types in the core get reused in a framework integration. Such reuse may look something like the following (if I was using TypeScript):
// Somewhere `@my-scope/core`
interface CoreInterface {
  common-prop: string;
  overridable-prop: HTMLElement;
}

// Somewhere in `@my-scope/react`
interface ReactInterface extends Pick<CoreInterface, "common-prop"> {
  overridable-prop: React.ReactElement;
}

The biggest benefit of interface + extends here is reuse. Currently, I have a core and 4 supported JS Frameworks. It would be difficult, tedious, and (worst of all) error prone to try to repeat + synchronize the common prop names, prop types, and especially the prop documentations across 5 different libraries. If @interface existed with support for @extends, I could reuse my types and documentation as desired.
Currently, my core package defines @typedefs, not interfaces. But since there's no way to extend these types with JSDocs, I have to create .d.ts files in the framework packages. This means I end up creating a separate file for an augmented type that will only be used in a single JS file in a given framework package. This is undesirable because the maintainer has to leave their context (the .js file or the .d.ts file) to get the "full story" for a certain piece of functionality. Users of .ts files do not have this problem.
Extensive Documentation for Methods on an Interface
Currently, it's possible to document all of the details of a method defined on an interface. This includes overloads.
interface MyInterface {
  /**
   * Does something really cool
   * @param a Some string that does some stuff
   * @param b Some number that isn't interesting
   * @returns `true` or `false`
   */
  method(a: string, b: number): boolean;

  /**
   * Does something that isn't as interesting as the first overload
   * @param a You can choose `true` or `false`
   * @param b Your coolest object
   * @returns Our opinion about your parameters
   */
  method(a: boolean, b: object): string;
}

Unfortunately, none of this is possible with @typedef (to my knowledge). You can certainly document a property that behaves like a function:
/**
 * @typedef {Object} MyInterface
 * @property {((a: string, b: number) => boolean) | ((a: boolean, b: object) => string)} Uh...
 * This does something depending on how you use it. Take your best guess?
 */

But you can't provide proper documentation for parameters, return values, overloads, and the like. You could try to write the documentation for everything on a single property. But it's obvious how that could get verbose, overwhelming, and unhelpful very quickly.
As you could guess, I also need this for the package that I mentioned earlier. Without it, I have to defer to .d.ts files again. But I don't want to reach for .d.ts files as a maintainer.
What's Wrong with .d.ts Files?
Nothing! I like them! But for projects where JSDocs are being used, I'd like to stay in JSDocs land as much as possible. I think that what's coming out in issues like these is that developers would like a "Consistent TypeScript Experience" whether they're using JSDocs or TypeScript files. Part of that consistent experience is being able to collocate types with logic. (If that isn't interesting to the team, that might be worth documenting somewhere for clarity -- though it would be unfortunate. :sob:) In TypeScript, I could write
export function myFunction(a: string, b: number): MyInterface { /* ... */ }
export interface MyInterface { /* ... */ }

This approach has two benefits. First, users can import my tools with their related types from the same place. This makes it clearer where everything is located.
import { myFunction } from "my-library";
import type { MyInterface } from "my-library";

Second,  developers/maintainers never have to change context to understand what's going on. There's no jumping to another file to understand a type that only relates to this single file. In other words, there's no need for something like this
import type { MyInterfaceOnlyRelatedToMyFunction } from "./filename-types.d.ts";
export function myFunction(a: string, b: number): MyInterfaceOnlyRelatedToMyFunction { /* ... */ }

Instead, everything is defined in the same place. So it's easier for the developer to know what's going on. This also saves users from having to search around to know where a type related to a specific file is located. The following is undesirable:
import { myFunction } from "my-library";
import type { MyInterfaceOnlyRelatedToMyFunction } from "my-library/where-do-i-go-for-this-type";

As a library maintainer using JSDocs, I would like for my users to have a consistent experience. That is, I want related function/class definitions and type definitions to be importable from the same location. I think that's natural, and React Components do this all the time; it would be weird if you had to import MyComponent from one place and MyComponentProps from another place. (If there are general types that are used across the project, I think .d.ts files make more sense than .js files. This creates a central place where common, reusable types exist, and it prevents library bundles from getting littered with useless export {} JS files. However, I'm not talking about general/common types right now.)
But here's the problem I run into... Let's saying I'm creating a JS file with types created via JSDocs:
// my-file.js

/**
 * @typedef {Object} MyType
 * @property {string} first-prop
 */

/**
 * Does something
 * @param {MyType} first A parameter that does stuff
 * @returns {void}
 */
function someFunction(first) { /* ... */ }

Then I realize some time later that my file needs an interface that adds good documentation for methods. Well, I can't add add that to my JS file. So I have to define it in a separate .d.ts file. Where do I place it? It's not a general type belonging to the entire application. It's a type that only belongs to the JS file, and a type that would only be exported from that file if I was using regular TS. So the type doesn't belong in a "General Library Types" .d.ts file. I can't place the type in my-file.d.ts because the compiler would get confused. And it's too much effort to try to join the types together manually post-build. So I create my-file-types.d.ts instead. But there are problems that come with this:
Inconsistent User Experience
Now, consumers of the project start seeing inconsistencies throughout it. There are some files that export all of their types and all of their logic from one place because the types are simple enough to be supported by JSDocs alone. Then, because JSDoc @typedefs will always be exported, there are other parts of the library where the JS file only exports a subset of the available types, and the remainder of them must be found in a separate file. Will this file be easy for consumers to find?
File Structure Bloat for Maintainers
For every JS file that can't be typed with JSDocs alone, a new file has to get added to the project.  So if a project is sufficiently sized, it won't take too long for the file structure of the project to become more and more bloated. Naming conventions could be created in the project to prevent this from causing chaos, but to me this shouldn't be necessary.
package.json Bloat for Maintainers
The project that I'm working on is mainly intended for the frontend. But the JS Framework integration packages require some server side rendering logic. Some SSR frameworks are used with CJS, so I need to support both ESM and CJS. Unfortunately, this means that for each JS file that requires an extra .d.ts file to compensate for JSDocs, the package.json file increases in bulk. What would ideally be the following
{
  "type": "module",
  "exports": {
    "./filename": {
      "require": {
        "types": "./filename.d.cts",
        "default": "./filename.cjs"
      },
      "types": "./filename.d.ts"
      "default": "./filename.js"
    }
}

is unpleasantly expanded to
{
  "type": "module",
  "exports": {
    "./filename": {
      "require": {
        "types": "./filename.d.cts",
        "default": "./filename.cjs"
      },
      "types": "./filename.d.ts"
      "default": "./filename.js"
    },
    "./filename-types": {
      "require": {
        "types": "./filename-types.d.cts"
      },
      "types": "./filename-types.d.ts"
    }
}

which is inconvenient for obvious reasons. Again, this happens for every JS file that can't be typed with JSDocs alone.
Additional Comments
In the issue that I referenced, I referred to struggles with the build step for maintainers. I don't know if that was the correct terminology, per se. The lack of interface support in JSDocs does cause difficulties for library authors, as described above. But there are no hiccups in the TypeScript compilation step.
Let me know if greater clarity is needed for what's been said or coded.

Some initial comments and questions.

Can you propose a syntax for @interface that allows detailed @param+@returns? Specifically, I don't like the OP syntax with separated @interface and @function tags because (1) they're hard to bind (2) Typescript-equivalent tags should have exactly the semantics of their Typescript constructs, and preferably similar syntax.
Your scenario also needs an @export tag for exporting types, right? At least it seems like it would make life a lot easier. Proposed in #48104 and #46011
What kind of compile step do you have (or want) in your project? Are you able to run, debug and test without compiling? Does compiling invoke tsc to emit .d.ts from .js files? Do you want it to?
Overall, I design JSDoc support with a pure-JS scenario in mind. There's a lot of design work needed, not just for individual tags, but also to make sure that the whole scenario can work smoothly end-to-end.

1) Potential Syntax for Interfaces
It depends on TypeScript's goal. I think the syntax suggested by the OP is based on what's currently acknowledged by JSDocs.
If TypeScript is willing to deviate from this, then I would agree that this syntax is not particularly pleasing. Perhaps a better syntax would be something similar to what @typedef does. From what I can tell, @typedef follow these rules: The description of a @typedef comes from the text before the Name or the text between the Name and the first "important tag". (If information is provided after the type Name, then the text before the Name seems to do nothing -- which is fine.) Spacing is irrelevant; only the location of tags matters. Once an "important tag" is introduced, all of the succeeding text belongs to that tag. And this pattern continues for the rest of the type definition.
/**
 * I describe `MyType` (if I'm the only description).
 * @typedef {Object} MyType I also describe `MyType`.
 * Yep. I describe `MyType` as well.
 *
 *
 * Hey! I describe `MyType` too! And because there's at least 1 line of space between me and the previous
 * comment, I create a newline in the IntelliSense bubble.
 * @property {string} propString I don't describe `MyType`. I describe `propString`.
 * I also describe `propString`.
 *
 *
 *
 * All the way down here, I am also a description for `propString`.
 * @property {number} propLast I describe `propLast`.
 *
 *
 *
 * From now on, `propLast` calls the shots.
 */

So @interface could probably have a similar rule. If I understand correctly, TypeScript interfaces really only describe properties and methods. The @typedef tag uses @property/@prop to indicate that all of the following comments belong to that new property name. So perhaps in a similar fashion, TS could use something like @function or @method to indicate that all of the following comments belong to the new method name.
One thing that I don't favor about @typedef is that just about any tag defines the "stopping point" for the previous property name. I don't think that has to be the case for @interface. Instead, only the "important tags" (like @property and @method) need to create new starting/finishing points. That way, things like @param and @returns can just be associated with the most recent "important tag".
/**
 * I describe `MyInterface` (if I'm the only description).
 * @interface MyInterface I also describe `MyInterface`.
 *
 * Indeed. I, too, describe `MyInterface`.
 * @property {string} propString I describe `propString`.
 *
 *
 *
 * I also describe `propString`.
 * @method myMethod I describe `myMethod`.
 * @param {number} firstArgument I describe `firstArgument`, within `myMethod`.
 *
 * I also describe `firstArgument`.
 * @returns {void} I am telling you what `myMethod` returns.
 *
 * @example I am an example belonging to `myMethod`.
 * const variableInExample = "5";
 *
 * @property {boolean} propBoolean I create a new "scope" for descriptions. So from now on, all
 * comments and "non-important tags" belong to me.
 *
 * For instance, even though a @see is here, it is still part of the description for `propBoolean`.
 */

I'm not sure how possible this is. But if it is possible, I think this would make sense. It's pretty similar to the @typedef syntax, making it familiar. But it's also more powerful -- allowing for the description of methods, and allowing for things like @example and @link to be associated with those methods as well (just like in a regular interface definition in a .ts file). This syntax is also pretty similar to the regular TS syntax for interfaces, I think. It's just slightly more verbose (as to be expected in JSDocs). As long as TS wouldn't have a problem scoping "non-important" tags (like @see, @param, and @returns) to the most recent "important tag" (like @property or @method), then I think this could work.
I'm sure alternatives are also possible. Thoughts?
2) Controlled Exposure of JSDoc Types
Something like an @export tag would be fantastic! I wasn't aware that the TS team was open to this idea. But it would certainly be helpful for concealing types that should not be exposed to end users (like internal, intermediate types).
3) Compilation or No Compilation?
Current Experience: Compilation Required for Production Release, but not during Development
Thankfully, no compilation step is required during development. Unfortunately, production release is a different story. When a user imports from a .js file in node_modules, TypeScript doesn't seem to recognize the JSDoc types provided in the .js file. All of the information is there, but it is ignored. So the maintainer still has to produce .d.ts files for the user to see/experience the desired types.
Consequently, my project has a build step. Because the .js files are the source of truth in my project, and because I don't want the .d.ts files confusing TypeScript during local development, my build process looks something like this:

Delete all the auto-generated files (.d.ts, .d.cts, .cjs)
Generate the .d.ts files for @my-scope/core via tsc. (This is so that the integration packages in the monorepo can use the types in core. Currently, it seems easier to do this than to use references.)
Generate the .d.ts files for @my-scope/<FRAMEWORK> via tsc.
Generate the CJS files. For the .js files, this means converting all imports and exports to be compatible with CJS (require/module.exports) in a copied file. Similarly, for the generated .d.ts files, this means converting all imports from .js/.d.ts to imports from .cjs/.d.cts in a copied file (since TS requires distinct types for modules and CJS).

Because the generated .d.ts files confuse TypeScript during development, Step 1 is its own script that I can run when I'm done with the release process.
Desired Experience: No Required Build Step at All
If a project is only using JS (and perhaps some accompanying, non-compiled .d.ts files that happen to be necessary/useful), then ideally no build step would be required at all. That's what I was hoping for when I rewrote the library that I'm currently working on to JSDocs. (I've kept the codebase in JSDocs land because it still seems beneficial to do so.)
Currently, as long as I'm writing code locally (in VS Code) or running tests, the type support is great! TypeScript throws errors when I break the types, and I get all the IntelliSense that I need to know what's going on. (There's also the bonus of avoiding type-related bugs that come from compilation, as in the case of generic constructors and method overloads.) It's the node_modules part that doesn't quite work as desired, as I described earlier.
It would be amazing if TypeScript could read the types from the .js files not only during development, but also when importing from node_modules. My build step would basically go away entirely (minus the generation of .cjs files, which isn't related to TS). So the maintenance of my project would get much easier.
4) TS Designs Supporting PureJS Scenarios
That's really helpful to know! That is indeed my ideal. :sweat_smile: Being able to use pure JS to skip the build step would be really helpful. It would also help with debugging when end users run into problems (because the source -- including types -- would be in node_modules, and people could test their own changes/fixes very easily).


fixing video autoplay issue #61

Just plays the first file in the list by default. Would this be enough?

I think it should auto-play the first acceptable-format video of the list. What if the first file isn't the video?

Yeah, @DiegoRBaquero is right. For now, I'd rather not merge this PR and we can just fix this another way, later.


Tetsts objectexit

@kspurgin

Please merge master branch into this and resolve any conflicts before submitting for final review. Thanks!

@ericsoi - up-to-date with master and ready to review with #28


Post a message to the webhook using PowerShell, not working

I have been using some internal webhooks with PowerShell and JSON and noticed sometime over the weekend they quit working.
I used the example on the docs page and am seeing issues there too. After about a 10 minute period, the following message is returned:
Invoke-RestMethod : Microsoft.Griffin.Connectors.Store.ExchangeInvalidGroupIdException: The request was aborted: The request was canceled. ErrorCode: ErrorCode:
At line:1 char:1

Invoke-RestMethod -Method post -ContentType 'Application/Json' -Body  ...

  + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-RestMethod], WebException
  + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeRestMethodCommand

Any ideas on what may have changed? I'm using the new webhook URL.
Thanks for any help.
Dave

I tested multiple times around 10:45 AM EST and everything appears to be working normally now.


Full source bootstrap

source-build project help a lot on building dotnet from source and simplify the packaging step on most distro.
But it still requires a binary seed as stage0, some distro(like Guix) has stricter rule, it requires a full source bootstrap.
So the question is: Is it possible to do a full source bootstrap? If there's a minimal dotnet compiler and runtime written in another language(e.g. C++ or Haskell) which enable us to build and run an old version of dotnet framework. Then we can use this dotnet sdk to bootstrap any newer version.

Unfortunately not. 😕 There are several tools in the .NET SDK that are self-hosting with very tight cycles, taking dependencies on essentially daily builds. For example, Roslyn takes dependencies on new C# features very quickly, so you can't build the 5.0.100 Roslyn using the 3.1.110 Roslyn. (5.0.100 is essentially the next version after 3.1.110 right now.) The sequence of commits you'd have to build to get from one to the the other might be prohibitively long, and AFAIK nobody is tracking this. Fortunately we avoid using floating versions in our repos, so it should be traceable. But I don't think we have tooling to do that tracing.
Building a .NET SDK using C++ would let you start at 5.0.100, and we do support building 5.0.100 -> 5.0.101 -> 5.0.102 using source-build. But setting up a bootstrap .NET SDK would be a lot of work. There's much more than the runtime libraries and Roslyn: a lot of build tooling is self-hosting, like MSBuild, NuGet, Arcade, etc. Also, this bootstrap .NET SDK would probably need to be individually maintained for every version (5.0, 6.0, 7.0, ...) because there's no nice pathway from one to the next.
Out of curiosity I looked at how Rust (self-hosting compiler) got in Guix, and yeah, there's a Rust built in C++ that was the initial version. That's pretty neat. 😄 I see that now there are ~28 versions in the chain. This is longer than I expected, so I guess length isn't necessarily a big problem. (Note that all of those versions appear to be stable versions, though, unlike a .NET SDK chain would be.)
For the current distros that use source-build and disallow prebuilts, they all have a bootstrap exception for self-hosting compilers that .NET fits into. (Sounds like you're aware, but mentioning for broader context. 🙂)
It would be great to be able to include .NET in stricter distros. Full source bootstrap does also help us get into other distros too--skip the prebuilt bootstrap exception. But it seems like it will be very difficult.

oh this would be nice, we could port dotnet to cygwin

@dagood someone adding a patch https://issues.guix.gnu.org/74609 this might be of interest to you


Check core components

We should check existing core components and move some logic from/to theme.
At the moment we have some empty files in core. It'll be nice to check each file and decide which logic should be placed in core and which in theme.
We can also clean up some code, remove unnecessary files etc.

@aekal Please remove {{ multistoreEnabled }} snippet from filter which causes displaying ... true

@pkarw I forgot to remove one line for debugging purposes :P

Good job!


upstreaming and porting 2018 Sienna dbc. file

https://community.comma.ai/cabana/?route=3b6e00dde85c3462|2018-12-20--00-35-11&max=5&url=https%3A%2F%2Fchffrprivate.blob.core.windows.net%2Fchffrprivate3%2Fv2%2F3b6e00dde85c3462%2Ff7b244e071e181247d50f587ed06ec60_2018-12-20--00-35-11

Looks like you guys have two PR's open for the Sienna. You will want to close one of them

Also better to have the DBC files in a separate PR in the opendbc repo. You will also want to add the sienna to the Readme chart

@hyperactive32 Add the Sienna to the README in the supported cars list, as well as fix the conflict in the values.py file and should be good

Also, I think @rbiasini will want the DBC portion of the port to be it's own PR in openDBC.

@rbiasini  did you get chance to look into static messages that it had?

@icmma, for us to verify the static messages I need:

cabana route with stock system running
cabana route with camera unplugged
cabana route with camera AND DSU unplugged

@icmma @hyperactive32
What's the state of this PR? Added few issues I could quickly spot in static messages.

not sure where adam is but there is new user with sienna will be able to get more data from him long as he doesn't go dark lol

@hyperactive32 , is there an updated Sienna port? Tnx.

@rbiasini  i did help couple of users one of them had 19. I do have the fingerprints but the statics messages issue still remains. Im not able to contact them any longer any who following are 2019.
    36: 8, 37: 8, 114: 5, 119: 6, 120: 4, 170: 8, 180: 8, 186: 4, 426: 6, 452: 8, 464: 8, 466: 8, 467: 8, 544: 4, 545: 5, 548: 8, 550: 8, 552: 4, 562: 4, 608: 8, 610: 5, 643: 7, 705: 8, 725: 2, 764: 8, 800: 8, 824: 8, 835: 8, 836: 8, 849: 4, 869: 7, 870: 7, 888: 8, 896: 8, 900: 6, 902: 6, 905: 8, 911: 8, 916: 1, 918: 7, 921: 8, 933: 8, 944: 6, 945: 8, 951: 8, 955: 8, 956: 8, 979: 2, 992: 8, 998: 5, 999: 7, 1000: 8, 1001: 8, 1002: 8, 1008: 2, 1014: 8, 1017: 8, 1041: 8, 1043: 8, 1056: 8, 1059: 1, 1076: 8, 1077: 8, 1114: 8, 1164: 8, 1165: 8, 1166: 8, 1167: 8, 1176: 8, 1177: 8, 1178: 8, 1179: 8, 1180: 8, 1181: 8, 1182: 8, 1183:8, 1191: 8, 1192: 8, 1196: 8, 1197: 8, 1198: 8, 1199: 8, 1200: 8, 1201: 8, 1202: 8, 1203: 8, 1212: 8, 1227: 8, 1228: 8, 1237: 8, 1279: 8, 1552: 8, 1553: 8, 1555: 8, 1556: 8, 1557: 8, 1561: 8, 1562: 8, 1568: 8, 1569: 8, 1570: 8, 1571: 8, 1572: 8, 1584: 8, 1589: 8, 1592: 8, 1593: 8, 1595: 8, 1656: 8, 1664: 8, 1666: 8, 1667: 8, 1728: 8, 1745: 8, 1779: 8

If you want i can merge it to latest.

That's up to you I just moved and have not found time to update mine as of
yet.
On Tue, May 21, 2019, 02:45 icmma<EMAIL_ADDRESS>wrote:

If you want i can merge it to latest.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/pull/477?email_source=notifications&email_token=AKN56OMCARZNCHOG2Q567KLPWOLBNA5CNFSM4GLOOO22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV25JRQ#issuecomment-494261446,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKN56OI5VHNSXSVEXZI2ERTPWOLBNANCNFSM4GLOOO2Q
.

Sienna is supported since 0.6.1


Add requirement for Argo, Hypershift and Hive CRDs

When these CRDs are missing, operator fails to start

fixed in https://github.com/stolostron/cluster-templates-operator/pull/18


tmt test import failing on some makefiles

If the makefile does not follow below structure for run entry it fails.
run: build
./runtest.sh
Attached are examples and hopefully all occurrences of this in /kernel repo.
kernel.txt
List was created using the following:
find . -name Makefile -exec grep -A 2 "run: build" {} ; -print > ~/kernel.txt
So every fourth line contains the location of the Makefile relative to /kernel.

Could you try with latest copr build? If it was about missing 'build' target it will be fixed.
If not, we have more bugs to fix in convert.

Some Makefiles fail to import due to a "run" target is more then two lines, ex
run: build
	@echo "============ Run Tests ============"
	LANG=C ./runtest.sh

The matching regex expects two lines:
        regex_test = r'^run:.*\n\t(.*)$'

@lukaszachy so is the expectation here that the automatic imported adds both build and run target scripts?
I would think in cases like this manual import is needed, not complicate our lives

@thrix Expectation is that if Makefile deviates from the simplest beaker-wizard produced Makefile (e.g. multiple lines in run target) then tmt warns user but leaves it up to them.
The linked PR just make import work when someone deleted 'build' target. At the second look it is a unused code (the only usage is to produce the warning when multiple lines are present in the target).


I encountered a warning when using it with server side rendering

[vue-server-renderer] Component VueProgress implemented serverCacheKey, but no cache was provided to the renderer.

This worked for me
<client-only>
    <vue-progress-bar></vue-progress-bar>
 </client-only>


Upgrade to SteamKit 1.7.

Awesome, this is long overdue.  This should fix a lot of the "bot doesn't connect/takes a long time to connect" issues.
Does anyone have time to test this?


Cancel button cannot exit dismiss current viewcontroller

I think what you are looking for is :
picker.didFinishPicking { [unowned picker] items, cancelled in
    picker.dismiss(animated: true, completion: nil)
}

In the latest releases, it's now the client's responsibility to dismiss the picker :)

@s4cha   The code is the same as yours, but clicking the cancel button dismiss the current viewcontroller takes a long delay to dimiss the current viewcontroller

So it does dismiss but takes a long time? This is weird to say the least :) I am unfortunately unable to reproduce on my end. Have you tried the Example project provided ? Does it happen there on your side?
Cheers,

@KBvsMJ have you had time to try the example project ? any updates on this?

I had the same issue, but this was caused by checking for cancelled too late, I had sth. like this:
picker.didFinishPicking { [unowned picker] items, cancelled in
            if let photo = items.singlePhoto, let img = photo.modifiedImage {
         .....
              if cancelled {
                 log.debug("PH: Did Cancel")
                 picker.dismiss(animated: true, completion: nil)
                 return
             }
         }

So the  code above checked for cancellation only after an image was chosen!
This worked for me:
picker.didFinishPicking { [unowned picker] items, cancelled in
            if cancelled {
                log.debug("PH: Did Cancel")
                picker.dismiss(animated: true, completion: nil)
                return
            }
            if let photo = items.singlePhoto, let img = photo.modifiedImage {
...

Hope that helps anyone.

@s4cha  it's ok

Thanks


fixed prototype data for full width text

Forgot to update full width text prototype data.
@jimmynotjim

LTGM


[GUI] Storage Module Tablet Button

The "Cycle to the next storage module" not visible on Storage Module Tablet.

Fixed for next release


`Fix page display for mobile user. - > Landscape horizontal orientation.

Please correct navbar sizeing in mobile landscape view /  horizontal orientation for mobile user.

Okay!

Issue resolved, please merge the code to master and close the ticket.


Add PonyLS

I'm developing this LSP and if you post it, maybe other people will work on it. Thanks.

@MahanBi, what happened to PonyLS? The link returns 404.


Monthly Basic Parcel Updates (2024-Q3)

Benefit
No response
Acceptance Criteria

[ ]

Notes
No response
Risks
No response
Issue Reference
refs #

Sprint 2 - January Updates
Parcels Updated:

Sprint 4 - February Updates
Parcels Updated:

Sprint 6 - March Updates
Parcels Updated:

That is all the updates for this quarter.


Update Compose to 1.5.10

Ezpz. Smoke tested both standalone and IDE samples.
Fixes #150
Fixes #182

@Walingar would appreciate a quick review since it's necessary for 0.9.0 and I'd like to stress test it for a couple days


⚠ GitLab Server has degraded performance

In c1c1332, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 14164 ms

Resolved: GitLab Server performance has improved in 44107ab.


Run Error

I meet this problems when I run python visualize_cam.py --cam-version gscorecam --image-folder data-coco/
Traceback (most recent call last):
File "/home/xiuyu/Weiran_MadSam/gScoreCAM-main/visualize_cam.py", line 32, in
class CLIPIntereactiveCAM:
File "/home/xiuyu/Weiran_MadSam/gScoreCAM-main/visualize_cam.py", line 200, in CLIPIntereactiveCAM
def get_gt_boxes(self, input_text: str, image_id: int) -> List[List[float, float, float, float]]:
File "/home/xiuyu/anaconda3/envs/gscorecam/lib/python3.9/typing.py", line 277, in inner
return func(*args, **kwds)
File "/home/xiuyu/anaconda3/envs/gscorecam/lib/python3.9/typing.py", line 838, in getitem
_check_generic(self, params, self._nparams)
File "/home/xiuyu/anaconda3/envs/gscorecam/lib/python3.9/site-packages/typing_extensions.py", line 113, in _check_generic
raise TypeError(f"Too {'many' if alen > elen else 'few'} parameters for {cls};"
TypeError: Too many parameters for typing.List; actual 4, expected 1
Is this because of the installation package version issue, or is it something else? Thanks

I was having the same issue.
Changing line 200 to def get_gt_boxes(self, input_text: str, image_id: int) -> List[List[float]]: worked for me


Refactor workspace middleware to a class

Right now, Launcher's middleware for handling workspaces consists of two function expression passed to Application.Use and a method WrapInWorkspace: https://github.com/StarcounterPrefabs/Launcher/blob/master/src/Launcher/Helper/LauncherHelper.cs#L26-L49
These handlers should be changed to a nice class (WorkspaceProvider or so...).
As a next step (not part of this issue) we can discuss putting this class into Starcounter.
cc @chrhol WDYT?
This will make https://github.com/StarcounterPrefabs/Launcher/issues/248 easier.

Wouldn't WebSections  fix it?

Wouldn't WebSections fix it?

This issue is not a bug report, so there is nothing to fix. It is only about refactor (changing the structure without changing the functionality).
It is few hours of work and it might make implementing WebSections easier.

If it's a step towards then great! :) I just wanted to avoid unnecessary refactoring of something that we plan to replace in future


Clarify Proof Selection Algorithm for Lambda's AlignedLayer Implementation

We need to gather detailed information about our proof selection algorithm to guide Lambda in their implementation for the AlignedLayer proving in the Mina-EVM bridge project.
Objective:
Provide Lambda with a clear understanding of how our proof selection algorithm works, particularly in the context of verifying the "best block" when checking N blocks (where N < k, the protocol constant).
Key Questions to Address:

How does our current proof selection algorithm verify the "best block" when checking N blocks?
Can the short fork rules be applied directly, or is a more nuanced approach required?
What are the implications and considerations of N being smaller than the protocol constant k?
Are there any specific edge cases or scenarios that Lambda should be aware of?
How does this algorithm interact with or impact the overall consensus mechanism in the bridge context?

As per discussion, this is not needed anymore due to a redesign.

Miscommunication, this is still needed and opening it up again.


Fix left-shift with vartabstop issue #14864

"Left shift is incorrect with vartabstop and shiftwidth=0"
The problem was that with 'vartabstop' set and 'shiftwidth' equal 0, left shifts using << were shifting the line to the wrong column.  The tabstop to the right of the first character in the line was being used as the shift amount instead of the tabstop to the left of that first character.
The reason was that the tabstop_at() function always returned the value of the tabstop to the right of the given column and was not accounting for the direction of the shift.
The solution was to make tabstop_at() aware of the direction of the shift and to choose the tabtop accordingly.
A test was added to check this behavior.

thanks Gary.


Release 1.0

I need more success stories than my own one to ensure everything works properly or close to it to release 1.0. Please, put :+1: into this thread if you have one and you agree 1.0 can be released.
Additional enhancements that I would like to see prior to 1.0:

Strong Parameters integration
CanCan integration (as a gem)
InheritedResources integration (as a gem)
Better tutorial on how to use Protector + StrongParameters + CanCan (or InheritedResources) with Rails 4
Mongoid integration?

This is the ony gem allowing me to restrict  the active-record reading acces on a per field basis. Thank you for all your work. :star2:
(Also tried Consul, Pundit)


C++/WinRT Visual Studio (VSIX) does not exist in the Visual Studio Marketplace

"For C++/WinRT project templates, as well as C++/WinRT MSBuild properties and targets, download and install the C++/WinRT Visual Studio Extension (VSIX) from the Visual Studio Marketplace."
The C++/WinRT Visual Studio Extension mentioned in the above paragraph on the "Introduction to C++/WinRT" docs page could not be found.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dcf7899f-689a-80c4-2c94-9575f8fc5055
Version Independent ID: b8873e37-f4cb-de98-46f2-f2eaf01e275d
Content: Introduction to C++/WinRT - UWP app developer | Microsoft Docs
Content Source: windows-apps-src/cpp-and-winrt-apis/intro-to-using-cpp-with-winrt.md
Service: unspecified
GitHub Login: @stevewhims
Microsoft Alias: stwhi

Hi, Gil! Yes, that's true, and in fact it's by design right at this moment but only because C++/WinRT (and the documentation for it) is still in a pre-release form. The documentation is marked pre-release, but we do understand that folks are keen to evaluate the technology and for that reason C++/WinRT is available in Windows Insider builds of the Windows SDK. Until the general availability of C++/WinRT when the VSIX is expected to be available, I would recommend the great info that you can find on https://kennykerr.ca/articles/ and https://moderncpp.com/.

I'll close this, since we're still in the pre-release phase. Thanks for looking at the C++/WinRT content!

Gil, the VSIX is now available here: https://aka.ms/cppwinrt/vsix. I've updated the topic.

I have installed C++/WinRT VSIX successfully today when I failed to find it in Visual Studio Installer.
And My partner has installed C++/WinRT as a individual component in Visual Studio Installer... Confusing

@zhangl1201, I'm sorry for the inconsistent UI you and your colleague are seeing. My advice is just to follow the info in Visual Studio support for C++/WinRT, and the VSIX. ~Steve


New cop to check for commented out debug calls

Is your feature request related to a problem? Please describe.
Sometimes, accidentally you can commit commented out debug calls like this:
def something
  something
  # debugger
  something2

  # debugger
end

I think these # debugger lines are ugly and they shouldn't get committed after a code review, but it's easy to miss them, so why not have Rubocop take care of them?
Describe the solution you'd like
At first I was thinking of adding this capability to RuboCop::Cop::Lint::Debugger, but it seems like a wrong place. Someone could accidentally disable the cop and commit a real debug call, even though they just wanted to disable it for commented out calls. Thus the idea for a new cop 🤔
Describe alternatives you've considered
No idea how else to tackle it
Additional context
Add any other context or screenshots about the feature request here.

I will close this proposal. Because AFAIK there is no general convention that this comment is for debugging.
You can create custom cop in your application:
https://docs.rubocop.org/rubocop/1.41/development.html
Thank you.


fix: remove obsolete replacement in owlbot.py

I manually checked that search string no longer exists in the file noxfile.py specified in the workaround. (Only one noxfile.py in the repo.)
A step towards resolving https://github.com/googleapis/google-cloud-python/issues/11020

This PR is incorrect


Rearranged the Newly added icons Alphabetically

Rearranged the newly added icons in alphabetical order!

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

This PR is in reference to your PR #1275 in EddieHubs main linkfree branch!


Line scatter source code not present in README.md

Hi, Congratulations for the plugin!
Can you put the source code for this example https://chrispahm.github.io/chartjs-plugin-dragdata/scatter.html?
In the  README.md the source code link at the demo
Thanks in advance

Founded in https://raw.githubusercontent.com/chrispahm/chartjs-plugin-dragdata/master/docs/scatter.html :)

Hey Francesco, Thanks for the ❤, and the hint about the wrong link in the readme! Will fix ASAP 😊 Merry Christmas 🎄
Christoph


[WIP] messages(errors: :full) returns an array, not a hash

The cleanest way I could get this to work was for MessageCompiler to forget
about full and just pass it straight into MessageSet#dump. But after writing
this, I realised that there's a problem: MessageCompiler, not MessageSet,
handles translations, and with my current approach there's no easy way to
translate the key.
I can't think of a way to fix this that doesn't require major changes to
the way MessageCompiler and MessageSet work, e.g. by making MessageSet rather
than MessageCompiler handle the translations.
I'm opening the unfinished PR just to get the discussion going again, but I
think my suggestion of keeping the API the same (messages(full: true)) might not be feasible. Maybe we could go back to my very first suggestion
from the discussion thread:
to keep the existing API the same, but to add a second option:
result.errors(full: true)
# => {age: ["must be present", "must be at least 18"], name: ["must be 20 characters or less"]}
result.errors(full: true)
# => {age: ["age must be present", "age must be at least 18"], name: ["name must be 20 characters or less"]}
result.errors(full: true, flat: true)
# => ["age must be present", "age must be at least 18", "name must be 20 characters or less"]

Although I can't think of a situation where you'd want flat to be true but full to be false, so maybe
this makes more sense:
result.errors(full: true)
# => {age: ["must be present", "must be at least 18"], name: ["must be 20 characters or less"]}
result.errors(full: true)
# => {age: ["age must be present", "age must be at least 18"], name: ["name must be 20 characters or less"]}
result.errors(flat: true)
# => ["age must be present", "age must be at least 18", "name must be 20 characters or less"]

# another idea; but I prefer the above one:
result.errors(full: :flat)
# => ["age must be present", "age must be at least 18", "name must be 20 characters or less"]

Just converted this issue to a PR (I didn't know you could do that!!! Although it is deprecated :( ), added some actual code, and updated my original comment. Please advise!

Closing as now all this code is in dry-schema. We could add this feature there and then update related code here to support it too.


Use envoy v2 bootstrap for sidecar

Add generation of the sidecar bootstrap.
Split from the larger PR dealing with SNI ingress, to unblock other people who need to test with v2.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
4d626757aa880885e4caf259ea81c12754dc9cf3
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
08608280c3f8507b9726992ef642be5a5f9ab044
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm why are we using pb.text encoding? Yaml is much more readable.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
fcac39bbd5230a9863b2d5839f7e7326dfd25df6
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
93cae945ccc3e1ba42385973eee9e39e8631fe98
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
2413399d2b886a7b553c52246483627f0931b1ed
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
db47a63ac0d99c92b9fe15afdf4055379e5f4590
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
1ed6e3bb68b12abda3372735ad3c4a270b724955
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
0e90e82d450b86ff99393e568b343b0b354b2cb9
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
0e90e82d450b86ff99393e568b343b0b354b2cb9
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
0e90e82d450b86ff99393e568b343b0b354b2cb9
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
0e90e82d450b86ff99393e568b343b0b354b2cb9
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
48fd343d39d9400a5fe4374f76ac16566025ddfa
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
10290d84e0aba706637dac8378a5a7f449b32fa8
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

I can rename the golden files in a separate PR if you don't mind - this has been going on for too long...
Re. package name - there is no envoy specific code, even if we're not planning other proxies. I'm trying to move away from the pilot organization, where agent code is mixed with server code.
Also I think we agreed that even LDS/etc are considered as generic APIs anyone can implement and use, so even in pilot it would make sense to stop using 'envoy' unless it's something very specific to
envoy.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
10290d84e0aba706637dac8378a5a7f449b32fa8
link
/test istio-pilot-e2e

prow/istio-presubmit.sh
10290d84e0aba706637dac8378a5a7f449b32fa8
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

/lgtm

/approve

If you feel useful to skip getting the logs - I don't mind a new flag.
My experience is that if logs are well organized, more is better. Android
'bugreport' system dump is huge and
has everything, and many times the problem is in an unexpected place.
If a test is passing - most developers will just ignore it, and we can skip
getting logs for passing tests.
Bug if a test fails - we should probably get more info - kubernetes events,
the actual config that
got applied, etc.
I'll look a bit if we can find a common way to get logs to files (and use
them in the 3-4 frameworks we have),
it may be something that can be used outside the test system.
On Mon, Feb 5, 2018 at 9:04 PM, Laurent Demailly<EMAIL_ADDRESS>wrote:

@ldemailly commented on this pull request.
In tests/e2e/framework/framework.go
https://github.com/istio/istio/pull/2561#discussion_r166188266:

@@ -185,10 +185,7 @@ func (t *testCleanup) cleanup() {
// Fetch and save cluster pod logs using kuebctl
// Logs are uploaded during test tear down
func (c *CommonConfig) saveLogs(r int) error {

if c.Cleanup.skipCleanup {

until recently none of the e2e ran with skip_cleanup which was a dev only
shortcut so it'd be nice to preserve the dev feature (short dev+test
cycles) and add some new stuff for ci as needed (and yes I agree it could
be 2 flags instead of 1, but as long as we don't lose a way to get into
that state)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/2561#discussion_r166188266, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6nWyCk0W6Mo_ZRFXvs-7dhSrQQqRks5tR91GgaJpZM4RbXnh
.


Implement support for disease prioritisation

We can currently benchmark the performance of gene/variant prioritisation tools and the corresponding results. Damian has asked me to set up a runner for L4CI - documentation here: https://thejacksonlaboratory.github.io/L4CI/index.html
Disease prioritisation can also be assessed for LIRICAL and Exomiser if it is of interest and should be quite easy to implement.

[ ] #134
[ ] Implement post-processing methods to create pheval disease result
[ ] Implement support within analysis methods for disease matching

I think in all generality it is a good idea to add "disease prioritisation" (a fancy term for diagnosis?) to results model etc! I would like to understand (no need to type) how that exactly differs from normal phenotype prioritisation. From a high level, single sentence perspective :D


Best fit

Is there a way to format using the best fit?
Show seconds only if there is no minutes/hours, seconds+minutes if there is not hours etc.

Oh, I didn't notice there is an option on the slides
6. Hide-upper-limit with zero-valued.
But probably points 6 and 7 can be replaced with the bestFit option all together

Okay, I will add this  point to the design doc: Link TBD

@klimashkin  We are discussing this issue in more details in this issue #32 , However, if you need more information or you think the other issue is not fulfilling your request. You can comment here or in the other issue.


Tests: Change dynamic column template update test to use less resources

The insert statement would sometimes run into a timeout causing the test
to fail.
Reducing the bulkSize & numCols still causes the test to fail without
the fix applied in bd4dba27cb6c1cdb659698dd37ce2bcf3f5c03e7

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0f3b1a8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5162   +/-   ##
=========================================
  Coverage          ?   82.39%
  Complexity        ?    11015
=========================================
  Files             ?     1331
  Lines             ?    45083
  Branches          ?     5667
=========================================
  Hits              ?    37148
  Misses            ?     5281
  Partials          ?     2654

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f3b1a8...95779ad. Read the comment docs.


Broken Brewfile icon

Example of repository: https://github.com/mislav/will_paginate

It should be show this icon

Thanks for reporting the issue, PR is very welcome

After I investigate for a while, the class name was correct but the icon wasn't shown.
I think maybe it's a problem with file-icons-js's fonts dependencies which is not updated for 3 years for now.


Earlgrey: bitstream doesn't work after parsing tlul_err_resp

Generated bitstream doesn't work on HW after parsing tlul_err_resp.sv using Surelog/UHDM.

Blocked by: https://github.com/alainmarcel/Surelog/issues/1113


[Space] - Fairdrop implementation: contract & server

tasks

Twitter / Discord API
Snapshot or Verification
Claiming website
Contract

Fairdrop API Spec
Get Nonce
URL: /api/fairdrop/nonce
Method: GET
Query Parameters

Name
Type
Description

account
String
Required. ETH address to claim the fairdrop.

Response Status: 200 OK
Response Body:

Name
Type
Description

account
String
ETH address to claim the fairdrop.

nonce
String
Unique ID for address (claimer sign message) and social (e.g. via tweet) verifications.

exipredAt
String
Timestamp in ISO 8601 format. Expiration date to claim the fairdrop.

signerSignature
String
A signature signed by backend signer.

Confirm Claim
URL: /api/fairdrop/confirm
Method: POST
Request Parameters

Name
Type
Description

account
String
Required. ETH address to claim the fairdrop.

nonce
String
Required. Unique ID from Get Nonce API.

expiredAt
String
Required. Expiration date from Get Nonce API.

signerSignature
String
Required. Signer's Signature from Get Nonce API.

claimerSignature
String
Required. A signature signed by claimer [1]

tweetURL
String
Required. Tweet link for social verification, tweet content must contains nonce.

Response Status: 200 OK
Response Body:

Name
Type
Description

account
String
ETH address to claim the fairdrop.

userId
String
Unique ID for address (claimer sign message) and social (e.g. via tweet) verifications.

expiredAt
String
Same value as from Get Nonce API.

signatureV
String
Signature Field v.

signatureR
String
Signature Field r.

signatureS
String
Signature Field s.


Data grid: Fix old FF headers

In versions 17 and 24 of FF, the headers are not aligned with the data. To fix this, add
-moz-box-sizing: content-box; to line 52 of datagrid.css.

Was failing in FF17

Passed on local branch

Passed on develop


Update systeminformation dependency

The systeminformation library we are using to get the network traffic speed for the Network plugin had a bug related with a function used to get the active network interface as it is documented in this issue #12.
The team behind the library already published a fix: 9980bfd for this bug.

Since we're using ^ in our imports, running npm install will download the latest major version (version with the same first number), so the version with the fix will be installed automatically the the command is next run. Using ^ is actually pretty bad practice, since we can't guarantee that our dependencies' minor version updates won't have breaking changes :P.  I'll definitely merge this in if you replace all ^ with ~ in our dependency list and it still works :D

Shouldn't be necessary then unless we change the way all the dependencies will be treated. I'll close the PR 😉


Adds VCN

Codecov Report

Merging #111 (bff4729) into main (46a2fc8) will increase coverage by 0.34%.
The diff coverage is 95.65%.

:exclamation: Current head bff4729 differs from pull request most recent head 2de9456. Consider uploading reports for the commit 2de9456 to get more accurate results

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   63.48%   63.82%   +0.34%
==========================================
  Files          81       83       +2
  Lines        2714     2737      +23
==========================================
+ Hits         1723     1747      +24
+ Misses        991      990       -1

Impacted Files
Coverage Δ

ezflow/models/VCN/vcn.py
95.23% <95.23%> (ø)

ezflow/models/VCN/__init__.py
100.00% <100.00%> (ø)

ezflow/models/__init__.py
100.00% <100.00%> (ø)

ezflow/functional/data_augmentation/operations.py
78.18% <0.00%> (ø)

ezflow/encoder/pspnet.py
95.62% <0.00%> (+1.45%)
:arrow_up:


Add Version Bump To Download Links on gis.utah.gov

It would be nice to have the deploy action automatically make a commit like this.

This is no longer relevant. gis.utah.gov now has a generic link to the releases page.

The website should be pulling the most recent release assets and falling back to a generic link if that fails.


Jeff Schaller: Watch amlouned.wordpress.com

Jeff Schaller requests the watch of the watch_keyword amlouned\.wordpress\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

amlouned\.wordpress\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Eliah Kagan in Charcoal HQ


refactor  error in java

VSCode Version:1.48
OS Version:win 10

Steps to Reproduce:
1.create a class like:
public Visitor{}
2.use the lombok annotation @Data
@Data
public Visitor{}

3.refactor the class name to VisitorRecord. it will be
VisitRecord class VisitRecord{}
i think it should be:
@Data
public VisitorRecord{}

but it isn't

Does this issue occur when all extensions are disabled?: Yes/No
occur when the lombok is disabled

/extJava


Closing the commissioning window should not expire fail-safe

Problem
With Max Cumulative Fail safe timer created we now should no longer expire the failsafe timer when the commission window closes either due to open window timeout or RevokeCommissioning command

Does the spec need to be updated. In section 5.5 I see:
A Commissionee that is ready to be commissioned SHALL accept the request to establish a PASE session with the first
Commissioner that initiates the request. When a Commissioner is either in the process of establishing a PASE session
with the Commissionee or has successfully established a session, the Commissionee SHALL NOT accept any more
requests for new PASE sessions until session establishment fails or the successfully established PASE session is
terminated on the commissioning channel (see CloseSession in Secure Channel Status Report Messages). In the
event a CloseSession status message is sent or received:

1. If the fail-safe timer is armed, the fail-safe timer SHALL be considered expired and the cleanup steps detailed
in Section <IP_ADDRESS>, “ArmFailSafe Command” SHALL be executed.

2. If the commissioning window is still open, the Commissionee SHALL continue listening for commissioning requests.

^^ @tcarmelveilleux @bzbarsky-apple

What is the spec update being proposed?
What the spec says right now is:

When the commissioning window opens, start listening for incoming PASE.
If a PASE session is established, arm a fail-safe.
If the fail-safe expires, close the PASE session.
If the PASE session is closed, expire the fail-safe.  Note that this means that the lifetime of the fail-safe exactly matches the lifetime of the PASE session.
If the fail-safe expires (aka PASE session is closed), if the commissioning window is still open go back to listening for incoming PASE.

And as of yesterday I believe the SDK implements all of those bits, by the way.

I don't have a proposed update, more so I am trying to understand the discussion around https://github.com/project-chip/connectedhomeip/pull/19636/files#r898314839 and how it relates to making sure we do not expire the fail-safe timer when the commission window closes either due to open window timeout or RevokeCommissioning command.
I was under the impression that is the open window times out, or RevokeCommissioning is called that and current PASE session would then be closed, which (based on spec today) means that we expire the fail-safe. So either I am missing something or that ExpireFailSafeIfArmed(); in CommissioningWindowManager::Cleanup() is actually reasonable

I see where I have a misunderstanding:
The CommissioningTimeout applies only to cessation of any announcements and to accepting of new commissioning sessions; it does not apply to abortion of connections, i.e., a commissioning session SHOULD NOT abort prematurely upon expiration of this timeout.
So closing of the window doesn't terminate the PASE connection

So closing of the window doesn't terminate the PASE connection.

Right, this is very important.  :)


custom ssl info- do not set custom domain enc

The doc’s look a bit ambiguous for setting up custom certs and a lot of users end up configuring APPSMITH_CUSTOM_DOMAIN after setting up custom certs.

@sum35h Just to make sure that I understand this correctly -  So we no longer want the users to use APPSMITH_CUSTOM_DOMAIN for custom certificates, which was used earlier for Let's encrypt? Meaning can users still configure it for Let's encrypt?  in which case we should be explaining this in this doc. in general, I feel the the callout is not clear, especially for new users.

@danciaclara My bad, this was a mistake on my end. It's fine as it is. Cloding the issue.


[Request] Chrome Beta, Dev, and Canary

I saw that Chrome was supported in https://github.com/lukesampson/scoop-extras/pull/1931.
Google Chrome has multiple channels : https://www.chromium.org/getting-involved/dev-channel
I'd like to request adding the channels Beta, Dev, and Canary.

There is no way how to get these work via scoop in proper way. Until google release some command line parameters / new installer (not that windows thing, which autodownload on run) / zipped application.


fix alt-ctrl-del interpreted as delete

I have accidentally deleted queues and topics by locking computers / bringing up the task manager with the application open.
(alt-ctrl-del and then enter)
This change will save my job. :)
I know you can use the Windows logo key + L to lock a machine but - "old dogs can't learn new tricks" and this habit is hard for me to break.

:white_check_mark: Build ServiceBusExplorer 5.1.0-keycombo.24.build.827 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/caeb0267bd by @)

I hope that you get to keep your job 😃

I hope this doesn't cost you the job... but this is good example of why in production environment you should always use the Service Bus Premium with Geo-DR enabled towards a second namespace in a paired region within the same geography 😄

I hope this doesn't cost you the job... but this is good example of why in production environment you should always use the Service Bus Premium with Geo-DR enabled towards a second namespace in a paired region within the same geography 😄

If only Geo-DR support data plane and not only meta plane... then it would be even useful 😀

@SeanFeldman maybe you didn't realize that in the meantime we released this guidance 😄
https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-federation-overview

I hope you are not worried about me :), I was only joking about losing my job.
We use the Service Bus for lightweight messaging and are able to re-play anything that's lost due to fat-fingers within a few minutes.
I have to admit, I'm a lot more comfortable about locking my computer when the rush is on to get lunch.
Thanks for accepting my PR.

Of course, we were just joking 😄

@SeanFeldman maybe you didn't realize that in the meantime we released this guidance 😄
docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-federation-overview

I did happen to see that a few months ago. But from a customer perspective, that's a workaround, not an SB feature. It's as if you were asking a car manufacturer to add a feature and the manufacturer would send you to the hardware store to "bolt it on" yourself 😃

@SeanFeldman you have to have this conversation with @clemensv not with me 😄