feat: support environment variables in server username and password

To avoid security problems when writing user/passwords in text plain in toolium.cfg, now it will support to set with environment variables, e.g:
username: $MY_USER
password: $MY_PASSWORD

Of course, it is also retro compatible and you can continue using it in text plain.

Unittests are failing when Server username is not configured, because os.path.expandvars method does not allow 'None' as input.
In any case, although it is not documented yet, username and password can be already configured using the environment variables named Server_username and Server_password.

Closed, as @rgonalo says, I will use the env vars Server username and Server_password


Fix incorrect redstone tint colors

Previously, RedstoneWireBlock used MathHelper.packRgb when generating redstone colors, which excluded the alpha channel. It's since been replaced by ColorHelper.fromFloats with an alpha of 1, resulting in incorrect tint colors.
https://github.com/PrismarineJS/minecraft-data/pull/936

Can you also open a PR to minecraft-data using this change?

Since 1.21.3 isn't merged yet i can add it to my pr

Done


Unable to run jupyter notebook

I tried to run the commant './run_docker.sh notebook' and I receive the error:
"docker: Error response from daemon: driver failed programming external connectivity on endpoint amazing_ishizaka (d09773292be872dd03643b5ffc152c7321396b140ead72a89d0ccbf829bf8b9f): Error starting userland proxy: listen tcp4 <IP_ADDRESS>:8081: bind: address already in use."

Hello Dear @arishsatheesan,
Could you try to restart your Ubuntu system?

Hi,
I tried, but still the same issue.

Fixed it! The error was stating that a port 8081 is already in use. What I did was:

Type: sudo lsof -i :8081
I got this:
COMMAND PID   USER   FD   TYPE DEVICE SIZE/OFF NODE NAME
motion  931 motion    5u  IPv4  21958      0t0  TCP localhost:tproxy (LISTEN)
So, I had to stop the command 'motion'. Either one of the following can be used:
sudo service stop motion (This didn't work for me.)
sudo systemctl stop motion (This worked.)

After this I ran './run-docker.sh notebook' and the notebook is opened.
Detailed discussion on this issue is here: https://stackoverflow.com/questions/69899466/error-starting-userland-proxy-listen-tcp4-0-0-0-080-bind-address-already-in


Why does this use python?

I love this project and I've been playing with the code locally. I'm thinking through ways to use this as part of the ford-mozilla open web fellowship. I think that activist groups could use this tool or something very similar. Just like journalistic organizations, activist orgs are frequently needing to quickly make shareable images for social media. In fact sometimes it's activist org--as opposed to the publications themselves--who are the ones who really catapult stories into popularity.
A question: why does this uses python? Seems like the essential parts are js, css, html. I don't mean this question to sound like a criticism, I just want to understand the reasoning behind using python. Is there a technical reason? Or was it because those of you who worked on this were already very familiar with python? Or something else?
:balloon: Anyway, thanks for your work on this! :balloon:

It's a good question. The main thing with something like this is having a good build process -- even though the output is js, css, and html, having templating, asset optimization, etc, makes development a lot easier. Since our team uses Python to build all our other projects, we used it here as well.


Unable to sort list of IP Addresses

I wanted to make various lists of the IP addresses, mac addresses/ etc... of the networks I'm on, i can create tables and the mac addresses and names listings will be able to be sorted, but the IP addresses won't sort either way no matter what.
I briefly got 192.168.001.XXX working to sort last week but when I came back to it wouldn't sort the IPs.
I've tried every number of combos, the IPs will sort (incorrectly) if I do not include the extra ZEROS (0) so it seems like it might be getting confused by the periods - but still, even if all the numbers are the same except for the last, it should sort in some way but doesn't unless all the final numbers in the address 192.168.1.xx if I put an adress ending in .1 as .001 it wouldn't sort at all, but when I put it as .1 it would incorrectly sort the IPs

Hello,
I am sorry for the inconvenience.
It says on the readme that, currently:

Sorting numerical and string data types. Custom comparator functions are part of the roadmap (see https://github.com/alexandru-dinu/obsidian-sortable/issues/12).


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/91615

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/92558

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/114431

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/119829

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/121531


questions

when i put command this in terminal:
./experiments/scripts/train_faster_rcnn.sh -cpu coco res101
errors happen:
/tools/../lib/datasets/coco.py", line 191, in append_flipped_images
boxes[:, 0] = widths[i] - oldx2 - 1
IndexError: list index out of range
this is command on MacBook without cpu
who can help me with my appreciate?thanks


fix: need to expand the asterisk here

cp tries to copy a file with an asterisk in the name otherwise

Double checking no other bootstrap issues are lurking in a new lab deploy before opening this PR.


Extra ? added to method in method signature completion for optional method

Bug Report

🔎 Search Terms

Method signature completions
suggest / suggestions
completions

🕗 Version & Regression Information
4.5.0-dev.20211029
💻 Code
For the code:
interface IFoo {
    barOpt?(x: number): void;
}

class Foo implements IFoo {
    |
 }

Complete barOpt inside Foo
🙁 Actual behavior
barOpt  gets added with a ?
interface IFoo {
    barOpt?(x: number): void;
}

class Foo implements IFoo {
    barOpt?(x: number): void {

    }
}

🙂 Expected behavior
Since we have implemented the method, I'd expect us the remove the ?

This is especially true under exactOptionalPropertyTypes

Thanks @a-tarasyuk!


mcap info shows incorrect start/end timestamps for my file

Description
When running mcap info on whattimeisit.mcap.zip, the following incorrect start/end/duration info is shown:
$ mcap info whattimeisit.mcap
library: python-mcap-ros1-support
profile: ros1
messages: 100
duration: -460947h7m35.322474798s
start: 2022-08-02T11:07:45.222474798+08:00<PHONE_NUMBER>.222474798)
end: 1970-01-01T08:00:09.9+08:00 (9.900000000)
compression:
	zstd: [1/1 chunks] (80.31%)
channels:
  	(1) /tf  100 msgs (0.00 Hz)   : tf2_msgs/TFMessage [ros1msg]
attachments: 0

Studio shows correct start/end timestamps for this file.

Version: v0.0.13
Platform: MacOS

The message start/end time in Statistics appear to be swapped from the chunk index:

I don't think this would be considered an issue with mcap info, unless we want to start adding error-detection features to it, but those belong in mcap doctor. I would consider it a bug that mcap doctor doesn't produce any errors when run on this file.

Studio and the Quick Look preview for whatever reason use the chunk start/end times instead of the one from Statistics:
https://github.com/foxglove/studio/blob/main/packages/studio-base/src/players/IterablePlayer/Mcap/McapIndexedIterableSource.ts#L37-L46
https://github.com/foxglove/studio/blob/main/desktop/quicklook/getIndexedMcapInfo.ts#L66-L77


Add TcpDnsQueryDecoder and TcpDnsResponseEncoder

Add TcpDnsQueryDecoder and TcpDnsResponseEncoder for TcpDnsServer
Motivation:
There is no TcpDnsServer codec, I need to create a TcpDnsServer.
Result:
TcpDnsQueryDecoder, like DatagramDnsQueryDecoder
TcpDnsResponseEncoder, like DatagramDnsResponseEncoder
thx.

@RockyLOMO as @normanmaurer also suggested plz add some unit tests for the newly added classes.

hi, I fixed the workflow CodeQL errors, and io.netty.example.dns.tcp.TcpDnsServer is the test.
thx. :)

@RockyLOMO the example is not a test-case... its an example ;) Please add some unit tests that can be run as part of the build

@RockyLOMO the example is not a test-case... its an example ;) Please add some unit tests that can be run as part of the build

Got it, added io.netty.handler.codec.dns.TcpDnsTest  :D

Fixed error Line is longer than 120 characters.

@RockyLOMO one more:
Error:  /home/runner/work/netty/netty/example/src/main/java/io/netty/example/dns/tcp/TcpDnsServer.java:69: Line is longer than 120 characters (found 123). [LineLength]

@RockyLOMO one more:
Error:  /home/runner/work/netty/netty/example/src/main/java/io/netty/example/dns/tcp/TcpDnsServer.java:69: Line is longer than 120 characters (found 123). [LineLength]

Done.

@RockyLOMO can you please sign our icla and let me know once done: https://netty.io/s/icla

Thanks for your great work!

My pleasure. :D

@RockyLOMO can you please sign our icla and let me know once done: https://netty.io/s/icla

I have singed this.


add webpack 4 to peerDependencies

Closes: https://github.com/plasticine/inject-loader/issues/53

This is an easy merge -- would appreciate you pushing it through, thanks!

@plasticine mind giving this a look? thanks in advance!

Hi all, I wanted to do a little more work here (adding a webpack 4.x example and tests) before adding support for 4.x.
Good news is that I’ve now done this and released inject-loader 4.x which adds Webpack 4.x support. :)


nixos/systemd-boot: Detect the installed version correctly

Motivation for this change
bootctl status now (I suspect since v249) reports the installed systemd-boot version as major.minor rather than just major. This broke the regex that attempted to parse the installed version in systemd-boot-builder.py, because it assumed that only the major version was reported (\d+). Change that to check for any non-zero-length combination of digits and dots ([0-9.]+).
Note that the parsed version is only used for logging, so it changing should not break anything.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Ref: https://www.reddit.com/r/NixOS/comments/pxz6nc/could_not_find_any_previously_installed/
Currently in the process of testing.

looks like a duplicate of #140046


Native JavaScript source maps

Here are two tests.

The first test a console.log("waht") is executed in app.controller.js. What I notice is a link instead to the concatenated Browserify'd file app.js.

I am forcing an undefined error, right underneath this console.log("waht") also in app.controller.js. Also being linked to app.js

Am I wrong to expect these should both link to app.controller.js?

On a side note, I was thinking about giving https://github.com/thlorenz/exorcist a try.
How would I integrate that into the Browserify solution that exists now?

Sorry, I can't replicate that issue. Source maps work fine with native js for me:

Source maps work for sure in Chrome devTools, and I think Firefox, but I'm not sure. Also, make sure devTools are open before the page loads (or hit refresh). Otherwise, it'll just link to the compiled files.


Wrap make generate with travis_wait

This should allow us to increase the timeout from 10 minutes to 30
Signed-off-by: Daniel Belenky<EMAIL_ADDRESS>NONE

/lgtm


fix: ensure events are only kept for a single update cycle

Events are transient, and should never last more than a single update cycle

@bdraco It looks like the release somehow failed.

Will sort it out shortly


Build command Typo on https://developers.cloudflare.com/pages/framework-guides/deploy-an-angular-site/

Which Cloudflare product does this pertain to?
Pages
Existing documentation URL(s)
https://developers.cloudflare.com/pages/framework-guides/deploy-an-angular-site/
What changes are you suggesting?
npx ng build --configuration production
instead of
npx ng build --prod
Additional information
The commond provided in the documentation is for older versions of Angular, if you use the new tool https://www.npmjs.com/package/create-cloudflare then the Build command needs to be updated to npx ng build --configuration production

@deadlypants1973  I also noticed that the Build output directory: needs to be /dist/browser/ and not just dist. Should I make a separate issue?


c2go: support template cmds

Codecov Report

Merging #106 (27e01bc) into main (5f50da4) will decrease coverage by 0.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   87.05%   86.45%   -0.60%
==========================================
  Files          10       10
  Lines        3190     3190
==========================================
- Hits         2777     2758      -19
- Misses        328      343      +15
- Partials       85       89       +4

Impacted Files
Coverage Δ

cl/pkginfo.go
76.13% <0.00%> (-13.64%)
:arrow_down:

cl/compile.go
92.57% <0.00%> (-2.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f50da4...27e01bc. Read the comment docs.


Nullable annotation not recognized on Android Context.getString()

BaseBundle.getString() can return null on Android, and is annotated as such, using android.support.annotation.Nullable. Unfortunately, neither the compiler nor the IDE seem to recognize this annotation, and assign a non-null type to getString().

https://github.com/android/platform_frameworks_base/blob/master/core/java/android/content/Context.java#L474 says it's actually the opposite ;)

My apologies. I'm actually looking at BaseBundle, not at Context.

No, you misunderstood me. I'm not apologizing for opening the issue. I'm apologizing because I told you the wrong class name!

This problem is real, sadly.

Oh, OK, lemme see.

Damnit, https://mvnrepository.com/artifact/com.google.android/android is not up-to-date enough to have that class :(

Does it have just Bundle at least?

No idea.

So Javac says it has no annotation for some reason.

It could be because the Nullable class is not found. Not sure.

Annotations are stripped entirely. I can't see them with javap either.

I don't understand it, but they're just not there.

Not much more I can do :(

Yeah, I guess not.

Closing then.

It turns out that it is a android.annotation.Nullable, which is Retention(SOURCE). (We were looking at android.support.annotation.Nullable.) @bjansen figured it out.

AHA. Damn confusing.


[Nitpick] Charging Booster level starts at lvl 0 instead of lvl 1

That's because you only get the effect of charging an item through the radar booster on the first ever purchase of the upgrade. It doesn't unlock by default.
Unless I'm confused about this issue entails?

I'm saying the first ever purchase is lvl 0 instead of 1 like everything else.


add missing cucim.skimage.segmentation.clear_border function

closes #266
This PR provides the missing clear_border function from the segmentation module. This is a straightforward adaption of the scikit-image function, mainly swapping numpy->cupy.
I put the v22.04.01 tag since this does fix a bug with the function having previously been listed in __all__ despite being missing, but waiting until 22.06 seems okay if that is preferred.

@alxndrkalinin Our next release would be v22.06.00 (around June 6th. We are skipping v22.04.01 release this time) and this PR is likely to be part of v22.06.00.
I just built a test package from this PR and you may be able to use it until we release v22.06.00.
Thank you!
pip install --force-reinstall --extra-index-url https://test.pypi.org/simple/ cucim==0.0.267

Thanks @gigony! This is great. Any chance #272 can also be reviewed in time for 22.06? Both issues came up within the same project I'm working on, so would be fantastic to have a build that includes both.

Yes, @grlee77 would help review your PR(#272) and we would like to include your PR as part of v22.06.00 release. Thank you so much for your contribution!
On top of #267, I have added changes in #272 to provide you PyPI package that you can use until we release v22.06.00.
pip install --force-reinstall --extra-index-url https://test.pypi.org/simple/ cucim==0.0.272

Awesome, thanks @gigony!

@gpucibot merge

@gpucibot merge

Thanks Greg! 🙏


The theme is not applied well.

Submit feature requests to http://www.mattermost.org/feature-requests/. File non-security related bugs here in the following format:
Summary
Changing the theme has problems rendering colors.
In dark mode, the background screen appears white.
After changing the theme, the color does not come out properly on the random screen.
Environment Information

Device Name: android device
OS Version:
Mattermost App Version: 1.32.0
Mattermost Server Version: 5.23.0

Steps to reproduce
Difficult to reproduce.
After changing the theme, the colors are not reflected properly on the screen.
The channel background looks white even though it is in dark mode
Here is what I tested:
Enter the theme change menu.
default : organization -> change : windows Dark
click the back button(left top button '<-')
Do nothing
Enter the theme menu again.
The background is white

If this bug occurs, the theme is not reflected properly on other screens.
I don't know how to reproduce.
Expected behavior
Normal colors should be reflected depending on the theme.
Observed behavior
attached
Possible fixes

@bitdessert Sorry for the delay in responding to you. Would you be open to let us know if this issue is still occurring for you?

Closing due to the age of the ticket. Feel free to reopen it if it still reproduces on V2.


Cannot update existing project: Resource access permission not configured & push not in stackUpdateComplete

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v14.18.3
Amplify CLI Version
10.6.0
What operating system are you using?
Mac OS 12.6
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made.
Describe the bug
My project deploys properly via the AWS Amplify console, but when I look at details from the amplify-cli it shows my Lambda functions as not having any resource access permissions, and when I try to add them, amplify push fails for all lambda functions with the ambiguous message:

AWS Amplify: Resource is not in the state stackUpdateComplete

And then when I run amplify diagnose --send-report it fails with no information other than:

✖ Sending zip

Expected behavior

I would expect that the CLI would know about the resource access permissions between my resources
I would expect that reapplying them from the CLI would work
I would expect that sending diagnostics would work or give an informative error message

Reproduction steps
My project was created in November 2018, along the way I connected it to the AWS Amplify console so it could build and deploy via CI on my dev and master branches. I have not used “Studio”.
Here are the relevant categories and resource names in my project:

Auth: fpcognito
Api: fpapi
Function: fpaccount, fpwebhooks
Storage: fpusers, fpabtest

I am trying to test adding a new DynamoDB table fporgs and giving it access to a the fpaccount Function. I did the following:

Reset everything locally to match my dev env with amplify pull dev
Created fporgs via amplify storage add
Pushed the change successfully via amplify push
Went to add resource access permissions via amplify function update
I selected the resource fpaccount (see the log output below to see what the CLI showed for that)
Under storage, I selected: fpusers, fpabtest, and the new fporgs tables
I set all perms for these tables
I ran a new amplify push
It failed with the “Resource is not in the state stackUpdateComplete” error

Project Identifier
This command errored out, but I think this is the project identifier: d32cgdvim65k7p
EDIT: another developer was able to generate one: 0b218acd3765ca818ae3151d0fe34855
Log output

# Put your logs below this line

## Output of running amplify function update

> amplify function update
? Select the Lambda function you want to update fpaccount
General information
- Name: fpaccount
- Runtime: nodejs

Resource access permission
- Not configured

Scheduled recurring invocation
- Not configured

Lambda layers
- Not configured

Environment variables:
- Not configured

Secrets configuration
- Not configured

# I excluded the rest of the output of this command…

############################################

## Output of running amplify push

> amplify push
✔ Successfully pulled backend environment dev from the cloud.

    Current Environment: dev

┌──────────┬────────────────┬───────────┬───────────────────┐
│ Category │ Resource name  │ Operation │ Provider plugin   │
├──────────┼────────────────┼───────────┼───────────────────┤
│ Function │ fpaccount      │ Update    │ awscloudformation │
├──────────┼────────────────┼───────────┼───────────────────┤
│ Auth     │ fpcognito      │ No Change │ awscloudformation │
├──────────┼────────────────┼───────────┼───────────────────┤
│ Function │ fppreauth      │ No Change │ awscloudformation │
├──────────┼────────────────┼───────────┼───────────────────┤
│ Function │ fpwebhooks     │ No Change │ awscloudformation │
├──────────┼────────────────┼───────────┼───────────────────┤
│ Storage  │ fpusers        │ No Change │ awscloudformation │
├──────────┼────────────────┼───────────┼───────────────────┤
│ Storage  │ fpabtest       │ No Change │ awscloudformation │
├──────────┼────────────────┼───────────┼───────────────────┤
│ Storage  │ fporgs         │ No Change │ awscloudformation │
├──────────┼────────────────┼───────────┼───────────────────┤
│ Api      │ fpapi          │ No Change │ awscloudformation │
└──────────┴────────────────┴───────────┴───────────────────┘
? Are you sure you want to continue? Yes

Deployment failed.
Deploying root stack fullpage [ ===========================------------- ] 8/12
	fullpage-20190114131120        AWS::CloudFormation::Stack     UPDATE_ROLLBACK_COMPLETE       Mon Jan 09
	storagefpusers                 AWS::CloudFormation::Stack     UPDATE_COMPLETE                Mon Jan 09
	storagefporgs                  AWS::CloudFormation::Stack     UPDATE_COMPLETE                Mon Jan 09
	authfpcognito                  AWS::CloudFormation::Stack     UPDATE_COMPLETE                Mon Jan 09
	functionfppreauth              AWS::CloudFormation::Stack     UPDATE_COMPLETE                Mon Jan 09
	storagefpabtest                AWS::CloudFormation::Stack     UPDATE_COMPLETE                Mon Jan 09
	functionfpaccount              AWS::CloudFormation::Stack     UPDATE_FAILED                  Mon Jan 09
Deployed function fppreauth [ ======================================== ] 3/3
Deployed function fpaccount [ ======================================== ] 4/4
Deploying function fpwebhooks [ ---------------------------------------- ] 0/4

🛑 The following resources failed to deploy:
🛑 Resource is not in the state stackUpdateComplete

Learn more at: https://docs.amplify.aws/cli/project/troubleshooting/

Session Identifier:

✅ Report saved: /var/folders/s8/2cc1_sx93dgdm20y08gnc2900000gn/T/fullpage/report-1673313358782.zip

⠧ Sending zip

✖ Sending zip

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

I encountered similar issue. Amplify deploy was working just fine before. But this week, I was updating my project which triggered Amplify CI/CD, deployment failed with AWS Amplify: Resource is not in the state stackUpdateComplete. I didn't make any change to amplify backend when this issue appear. I tried amplify push on my local, it ran successfully. However, when I deploy it on Amplify Hosting, I got AWS CloudFormation UPDATE_FAILED
Output 'LambdaExecutionRoleArn' not found in stack 'arn:aws:cloudformation:...'

@josefaidt thanks for checking on this! This was in my local terminal output—you can see in my “Reproduction steps” the commands that I executed. I also added more to the “Log output > details” section just now.

Any update on that issue? It's also blocking us.

Any update on that issue? It's also blocking us.

You have two options at the moment:

Downgrade to 10.5.1
Utilize this workaround https://github.com/aws-amplify/amplify-cli/issues/11714#issuecomment-1379709071

@maziarzamani that did not help. Downgraded to<EMAIL_ADDRESS>and reran amplify function update:

Same issue with amplify-cli seeing my function as having access to no resources (even though it’s live on 2 of them already)—so I added the 2 old DynamoDB tables and the 1 new one
Same error when I then ran amplify push
Same error “Sending zip” after “Report saved”

@maziarzamani that did not help. Downgraded to<EMAIL_ADDRESS>and reran amplify function update:

Same issue with amplify-cli seeing my function as having access to no resources (even though it’s live on 2 of them already)—so I added the 2 old DynamoDB tables and the 1 new one
Same error when I then ran amplify push
Same error “Sending zip” after “Report saved”

If you havent made any changes do a pull --restore which will replace all local changes and push again. This did the trick for me.

@maziarzamani same 3 issues I listed above after doing amplify pull --restore and amplify function update and amplify push. The error message itself is really generic, so possible we’re encountering different things.
Since the report failed to send every time, I emailed a copy to @kaustavghosh06 I’m not sure what the right path forward is here

@maziarzamani same 3 issues I listed above after doing amplify pull --restore and amplify function update and amplify push. The error message itself is really generic, so possible we’re encountering different things. I appreciate you trying to help though!
Since the report failed to send every time, I emailed a copy to @kaustavghosh06 I’m not sure what the right path forward is here

I am sorry to hear that, hope the problem gets resolved, seems to be in a different state than my project.

@josefaidt finally able to generate a project identifier:

Project Identifier: 0b218acd3765ca818ae3151d0fe34855

Would you mind sending the report zip and a zip of your amplify/ directory to<EMAIL_ADDRESS>We are actively looking into this issue now and those resources would be very helpful for us. @mrcoles

@mrcoles we just got your email. Thank you, we are looking into this.

Hi @mrcoles
There is one more thing. Can you also login to your AWS CFN console  and paste the error details whatever your are seeing on the console [redact any secret info like arns].
Steps:

login aws account -> cloudformation
Select the stack -> events

This will show the cfn error which will help us in debugging further.

Thanks! This looks like the relevant line in the AWS CFN console:

2023-01-20 11:39:49 UTC-0500
functionfpaccount
UPDATE_FAILED
Output 'StreamArn' not found in stack 'arn:aws:cloudformation:us-east-1:193603674864:stack/fullpage-20190114131120-storagefpabtest-1MAXO1NAOF0MD/0ab81010-3ead-11e9-a420-12a886f5f55e'

The problem was identified as the project needing to have the storage resources updated. I ran amplify storage update on both existing DynamoDB tables (just ran through everything without making any actual updates, but this generated new files, like cli-inputs.json, which didn’t exist, yet, because this project is quite old and the CLI doesn’t identify the need to update/migrate).
Thanks for your help @sdstolworthy and @akshbhu !


[MAT-6195] Display calculation results (QDM)

MADiE PR
Jira Ticket: MAT-6195
(Optional) Related Tickets:
Summary
Once calculation has been run, display a Result block containing the Calculation Result.
The result will contain the statement_result.[cqlLib].[definition].pretty value from cqm-execution's response.
All Submissions

[x] This PR has the JIRA linked.
[x] Required tests are included
[x] No extemporaneous files are included (i.e Complied files or testing results)
[x] This PR is into the correct branch.
[x] All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
[x] Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps
If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

[x] This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
[x] All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers
By Approving this PR you are attesting to the following:

Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
The tests appropriately test the new code, including edge cases
If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

I thought I approved it


sky: change

sky: 2.1.7369 -> 2.1.7520
Motivation for this change
Resolve 404 on .deb package.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

sky cannot find {{libcrypto}}:
{noformat}
sky: error while loading shared libraries: libcrypto.so.1.0.0: cannot open shared object file: No such file or directory
{noformat}

I can't seem to get this to work.

@jonringer  I missed your comments.
Next issue is sky: error while loading shared libraries: libavcodec-ffmpeg.so.56: cannot open shared object file: No such file or directory which I could not find the package for (tried ffmpeg-full, libav_12 and libav.
I'm giving up on sky. I'd rather have Microsoft support Skype in Firefox.

libavcodec-ffmpeg.so.56 should just be the libavcodec.so.56 that came from the ffmpeg package instead of the for libav


Does not render into jsdom

Describe the bug
This does not run in a test environment. Either get an error saying Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element' or it just doesn't render anything into jsdom.
To Reproduce
https://codesandbox.io/s/icy-tree-rr3dq

Hi, RTM relies on browser APIs to work. in this specific case (getComputedStyle) you're seeing this error because of its dependency (line-height package), but it's not only that, RTM relies on actually rendering the content to an HTML box and measurements. even if you mock line-height lib it'll probably won't have the same effect as in a real app. because of that I suggest you mock RTM itself for your unit tests. For E2E browser tests you won't have any issues, with real world results as well.


how to detect file is video or audio?

Hi How Can I Get Type of Media by PHP-ffmpeg?

Either using ffprobe, or you check the classname.


[BUG] NIP-09 kind=5 'Deletion' bug

Cameri advises for this to be raised as a bug.
kind=5 delete event issues
I have an event (1)
for which I've created a deletion event kind=5 (2)
then I query nostr (nostream) using the event_id from 1 (3)
yet I the nostream relay still returns the event (4)
My understanding is that the relay must refrain from disseminating the event in (4) given there is a deletion event for it.
=== (1) event I want to delete
we got the event we wanted: {
id: 'e79f31b545f006087f7bd27d9febeb71ae6945424d1f0b5db3958099da0d59a3',
kind: 1,
pubkey: '2b78a7d19a411e800cfa86fd0e72aaa0652981b1d5b33a0c445050d06ad8c1ee',
created_at:<PHONE_NUMBER>,
content: 'hi',
tags: [ [ 'y', '333' ], [ 'x', '333' ], [ 'tagTagTag' ] ],
...
...
}
=== (2) kind=5 deletion event
publish is being run
{
kind: 5,
pubkey: '2b78a7d19a411e800cfa86fd0e72aaa0652981b1d5b33a0c445050d06ad8c1ee',
created_at:<PHONE_NUMBER>,
tags: [
[
'e',
'e79f31b545f006087f7bd27d9febeb71ae6945424d1f0b5db3958099da0d59a3'
]
],
content: 'hi',
id: '8940ae287b86176b9214b3ef4e77c66d9d19d1a266445ca9f5ca71c2d4f17ad4',
...
...
=== (3) subsequent query for the event in (1)
let sub = relay.sub([
{
ids: ['e79f31b545f006087f7bd27d9febeb71ae6945424d1f0b5db3958099da0d59a3']
}
])
=== (4) and I still receive the event  :what-have-i-done-wrong-face
we got the event we wanted: {
id: 'e79f31b545f006087f7bd27d9febeb71ae6945424d1f0b5db3958099da0d59a3',
kind: 1,
pubkey: '2b78a7d19a411e800cfa86fd0e72aaa0652981b1d5b33a0c445050d06ad8c1ee',
created_at:<PHONE_NUMBER>,
content: 'hi',
tags: [ [ 'y', '333' ], [ 'x', '333' ], [ 'tagTagTag' ] ],
...
...
System (please complete the following information):

OS: Ubuntu client
Platform: railway relay
Version:  c439dc8

Looking into this now.


uninitialized constant Article::article

I'm trying to let people add articles that should be read before or can be read after the present article.
This is my _form.html.erb
<%= semantic_form_for @article do |f| %>
  <%= f.inputs do %>
    <%= f.input :before %>
  <% end %>
  <%= f.actions %>
<% end %>

This is my article.rb
class Article < ApplicationRecord
    has_many :before, through: connection, class_name: "article", source: :after
    has_many :after, through: connection, class_name: "article", source: :before
end

And this is my connection.rb
class Connection < ApplicationRecord
    belongs_to :before, class_name: "Article"
    belongs_to :after, class_name: "Article"
end

I get the error "uninitialized constant Article::article" when I visit articles/new.

@amadeuspagel I'd guess it is because of lowercase a in "article" instead of "Article". Also you'll get same error with plain rails by doing article.before.

Closing due to inactivity. Please reopen if you can prove the has_many association works.


Functionality of adding url instead of Code in local directory.

I am working on windows phone aesthetics using html/css but everytime I need to delete old code from phone and paste new code.
I am using GitHub pages to host the web version, it'll be very helpful if I could just add my GitHub pages link and with every push to my repo my launcher will get updated.

Great idea, added to my TODO list. Shouldn't be too hard to implement, though I've been incredibly busy recently.

I will add that for now I suggest doing the majority of your testing on desktop by exporting your app list and using it with the API mock, if you're not doing that already. You could also set up a script to copy your files to your phone as for example a build action in VSCode or another editor.

Thanks!! Mock API seems like the best way of development going forward.

Yup, the exact idea behind the app list + icons export and the API mock it is to allow development in a desktop environment without having to test every change on the actual device.
I will keep this issue open because loading from URL would make for a neat feature, be it to use your own projects and auto update, or to quickly try out someone else's project without having to download the files and point to the folder.


Use React.ReactNode type for TextInput icon property

Small fix for TextInput types:
In all places Icon passed as React.ReactNode, but only TextInput uses React.ReactElement which throws type error

Also fixed note about icon position, because it is actually on the left edge:

Any workaround to solve this problem until the minor release?

@Albert-Alvarez for now you can do following
<Input id="login" name="login" icon={Person as any} />


kwok managed pods do not respect finalizers and are deleted immediately

How to use it?

[X] kwok
[ ] kwokctl --runtime=docker (default runtime)
[ ] kwokctl --runtime=binary
[ ] kwokctl --runtime=nerdctl
[ ] kwokctl --runtime=kind

What happened?
After a pod with non-empty finalizers has be scheduled to a kwok managed node,  it will be deleted immediately even through no one external removes the finalizers.
If you watch  such a pod from client view (for example by kubectl get pod mypod -o yaml -w --output-watch-events=true) , you will find the pod resource seems first got all finalizers removed and then deleted by the apiserver.
like below (with irrelevant part dropped):
object:
  apiVersion: v1
  kind: Pod
  metadata:
    creationTimestamp: "2024-01-19T14:33:14Z"
    finalizers:
    - mytest/myfinalizer
  spec: ...
  status: ...
type: ADDED
---
object:
  apiVersion: v1
  kind: Pod
  metadata:
    deletionGracePeriodSeconds: 30
    deletionTimestamp: "2024-01-19T14:35:50Z"
    finalizers:
    - mytest/myfinalizer
  spec: ...
  status: ...
type: MODIFIED
---
object:
  apiVersion: v1
  kind: Pod
  metadata:
    deletionGracePeriodSeconds: 30
    deletionTimestamp: "2024-01-19T14:35:50Z"
  spec: ...
  status: ...
type: MODIFIED
---
object:
  apiVersion: v1
  kind: Pod
  metadata:
    deletionGracePeriodSeconds: 0
    deletionTimestamp: "2024-01-19T14:35:20Z"
  spec: ...
  status: ...
type: MODIFIED
---
object:
  apiVersion: v1
  kind: Pod
  metadata:
    deletionGracePeriodSeconds: 0
    deletionTimestamp: "2024-01-19T14:35:20Z"
  spec: ...
  status: ...
type: DELETED

What did you expect to happen?
The kwok managed pods respect the custom finalizers and do not clean them until their owner removes it, just like normal pod (or any k8s api resource).
How can we reproduce it (as minimally and precisely as possible)?

Create a pod and schedule it to a kwok fake node.

cat <<EOF | kubectl create -f -
apiVersion: v1
kind: Pod
metadata:
  name: nginx
spec:
  containers:
  - name: nginx
    image: nginx:1.14.2
    ports:
    - containerPort: 80
  nodeName: kwok-fake-node
EOF

Add the pod with some custom finalizers
kubectl patch pod nginx -p '{"metadata": {"finalizers": ["mytest/myfinalizer"]}}'
Delete the pod while the finalizers are still there, and you will find the pod is deleted immediately.
kubectl delete pod nginx

Anything else we need to know?
No response
Kwok version

$ kwok --version
kwok version v0.3.0 go1.20.3 (linux/amd64)

OS version

```console
On Linux:
$ cat /etc/os-release
paste output here
$ uname -a
paste output here
On Darwin:
$ uname -a
paste output here
Darwin C02F52S4ML85 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22 PDT 2022; root:xnu-8020.121.3~4/RELEASE_X86_64 x86_64
On Windows:
C:> wmic os get Caption, Version, BuildNumber, OSArchitecture
paste output here
</details>

apiVersion: kwok.x-k8s.io/v1alpha1
kind: Stage
metadata:
  name: pod-delete
spec:
  resourceRef:
    apiGroup: v1
    kind: Pod
  selector:
    matchExpressions:
    - key: '.metadata.deletionTimestamp'
      operator: 'Exists'
    - key: '.metadata.finalizers'
      operator: 'DoesNotExist'
  weight: 1
  delay:
    durationMilliseconds: 1000
    jitterDurationFrom:
      expressionFrom: '.metadata.deletionTimestamp'
  next:
    delete: true

Using this instead of the original should be the effect you want.
See more

/remove-kind bug
/kind support


Issue/fix increment interaction tests (#7103)

Pull request opened by the merge tool on behalf of #7103

Merged in 6c31c505c96998825d1a6e17587f6e5fc9505c04


style tag support?

I'm using inline styles for my app. it'd be nice if I could continue to just add style attributes to style the Tabs, etc. I tried doing this but doesn't seem they're allowed.

:+1:

I could't use styles for  and .  I tried: style={styles.tab}

This is now possible in 0.6


Make user lockout (due to max login attempts) time-based

Preflight Checklist

[X] I could not find a solution in the existing issues, docs, nor discussions
[X] I have joined the ZITADEL chat

Describe your problem
There's a lockout policy in settings, allowing to lock user after some unsuccessful login attempts. It would be useful if this lockout will be time-based, i.e. to unlock user automatically after predefined period of time (e.g. after 30 min from lockout).
This improvement will help prevent password guessing while still allowing for not involving the administrator for every forgotten password issue. This is particularly important if there are many users.
Describe your ideal solution
I can set up two options in Lockout settings:

maximum attempts count (as is in current settings)
lockout time in minutes (new option)
When the user reaches maximum attempts count, they get locked for a specified time period (if set) or until manual unlock (if time is not set).

Version
2.36.0
Environment
Self-hosted
Additional Context
No response

Thank you for sharing your idea.
If there is a significant demand from customers/community, we will carefully consider implementing the feature.
Currently, the issue will be added to our product backlog.
Meanwhile, if you're interested in implementing it yourself, we also welcome pull requests.

#8360


Make shaders more dynamic

Some parameters defined through macros could be uniform variables.
This way, the shaders would be more dynamic, avoiding recompiling them when reconfiguring the parameters.

Which parameters are you talking about? We explicitly used variants to optimize shaders for mobile usage and reduce register pressure, etc.

BRDF, BLEND_MODE, FILAMENT_QUALITY, etc.
Sure.
I mean there could be a dynamic option.
Macros continue for static cases targeting performance.

That's already the case.

It's not the case.
You will need to recompile the shaders.

Macros are already used for static cases targeting performance. We will not offer each macro with a uniform alternative. There is little benefit and it would add a lot of complexity.


How to write in a HTML CKEditor

i have in my Strategy Entity a HTML CKEditor and i would like to add a few lines.
My First step is:
xrmBrowser.Driver.SwitchTo().Frame("Webresource_example");   ////This works
IWebElement Text = xrmBrowser.Driver.FindElement(By.XPath("//*[@id="ckeditor"]"));
Text.SendKeys("...........");   ////////this doesn't work
System.InvalidOperationException : unknown error : cannot focus element
Does anyone have a Solution?

Closing - off topic as this isn’t EasyRepro functionality but more base Selenium code


Improve the heuristic for the camera projection distance

Base in on the latest known scene size.
Closes https://github.com/rerun-io/rerun/issues/681
I'm not super-happy with how we need to pipe the scene bbox around to accomplish this.
An alternative would be to computer it last, that is: populate the scene with a dummy distance, then compute the final distance after the scene is complete, like we do for point radii. The problem with this is that we also need the projection distance for the transform hieararchy for projecting 2D stuff onto the plane.
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[ ] I've included a screenshot or gif (if applicable)
[ ] I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

Closed by https://github.com/rerun-io/rerun/pull/1433


validate that new upgrade arch is required for 1.30

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?

Does this PR require documentation?

Yes, the new upgrade architecture will be required:
2024/09/30 15:50:13   Error: failed to upgrade: apply operator chart: patch clusterconfig with operator chart: patch clusterconfig: ClusterConfig.k0s.k0sproject.io "k0s" is invalid: [spec.extensions.helm.charts[0].timeout: Invalid value: "string": spec.extensions.helm.charts[0].timeout in body must be of type integer: "string", spec.extensions.helm.charts[1].timeout: Invalid value: "string": spec.extensions.helm.charts[1].timeout in body must be of type integer: "string", spec.extensions.helm.charts[2].timeout: Invalid value: "string": spec.extensions.helm.charts[2].timeout in body must be of type integer: "string", spec.extensions.helm.charts[3].timeout: Invalid value: "string": spec.extensions.helm.charts[3].timeout in body must be of type integer: "string", spec.extensions.helm.charts[4].timeout: Invalid value: "string": spec.extensions.helm.charts[4].timeout in body must be of type integer: "string", spec.extensions.helm.charts[5].timeout: Invalid value: "string": spec.extensions.helm.charts[5].timeout in body must be of type integer: "string", spec.extensions.helm.charts[6].timeout: Invalid value: "string": spec.extensions.helm.charts[6].timeout in body must be of type integer: "string"]

darn, I was hoping otherwise


Handle errors from the chrome/firefox command

See #1

Going to close as it has been a while and I'm not sure if this is relevant anymore.


Cover demo programs in primary README

A starting point for a section to add to the main README to let users know how to install and run the demo programs
Demo Programs
There are several demo programs that you can use as references for programming your own robot in python on ev3dev. To install these on your EV3, use git to clone the ev3dev-lang-python repository.
$ sudo apt-get install git
$ git clone https://github.com/rhempel/ev3dev-lang-python.git

To run one of the demo programs from the command line, cd to the directory and run the program via ./PROGRAM_NAME.py.  Example:
$ cd ev3dev-lang-python/demo/R3PTAR/
$ ./r3ptar.py

You can also run a demo program via Brickman by selecting the program in the File Browser.  Note that for both running from the command line and running from Brickman the program must be marked as an executable and the first line of the program must be #!/usr/bin/env python3.  To mark a program as executable run chmod +x PROGRAM_NAME.py.  All of the demo programs are already marked as executable and already have #!/usr/bin/env python3 so you should be fine, we only mention it so you know to do these things when writing your own programs.

I think that this should be two separate sections: one for demos specifically and one for your own programs. It would make sense if the former were in the README in the demo folder.

What if we take the text above and put it in demo/README but also add the following to the primary README
Running programs
When you write your own program there are two important steps you must take for the program to work:

The first line must be #!/usr/bin/env python3
The program must be executable. To mark a program as executable run chmod +x PROGRAM_NAME.py

You can then run PROGRAM_NAME.py via the Brickman File Browser or you can run it from the command line via $ ./PROGRAM_NAME.py.

I think we should just make sure that all demos have #!/usr/bin/env python3 and also that the have the execute bit set in git.

@ensonic the problem is that having it marked in git doesn't necessarily mean that it will keep it's state once a user transfers the file to the brick. Remember, many people will just download these files via the web interface.

Currently all of the demo programs have #!/usr/bin/env python3 and all except EV3RSTORM/ev3rstorm.py are executable.  I'll fix that via the pull request to update the READMEs.

What it we add a fix in brickman to make text files starting with a she-bang executable (if they aren't)?

ev3dev/ev3dev#737


Don't throw an error if sourceMap is null/undefined

fix iTwin/itwinjs-backlog#1123
sourceMap could be undefined/null in some cases. ignore it instead of throwing an error

Can you look at the tests added by the PR in the workitem, and add to those potentially making sure that the null gets persisted?


Set SVG viewBox size from canvas width and height without factoring by devicePixelDensity

There is currently an issue in the export of SVGs that causes data to be truncated off the right-hand and bottom.
The problem lies in the fact that stroke data is being recorded in terms of the overall size of the canvas and then the size of the viewBox is being reduced afterwards. It's not necessary to reduce the viewBox's size because the viewBox's width and height are unitless and only meaningful in relation to the stroke data. Reducing the maxX of the viewBox from 1000 to 500, for example, just invalidates coordinates with x > 500 because they no longer exist in the viewBox.
I think the intent of this originally must have been to preserve the dimensions of the image across devices of differing DPI, and for that we only need to adjust the width and height attributes.

This checks out. Please merge.

This works for me as well, will it be merged?

I need this PR to be merged and pushed to NPM as well.
I'm currently still using this library from my own fork. 😰

We'd need that fix released too. What's blocking it?

+1

Funny 😂
Because I had many troubles with this, too. I already fixed it by myself.
And now I wanted to make a PR and found your's 🤣
var svgStr = atob(signaturePad.toDataURL('image/svg+xml').replace(/^[^,]+,/, ''));
svgStr = svgStr.replace(/(viewBox)="[^"]+"/i, '$1="0 0 ' + canvas.width + ' ' + canvas.height + '"');
svgStr = svgStr.replace(/(<svg[^>]+width)="[^"]+"/i, '$1="' + canvas.width + '"');
svgStr = svgStr.replace(/(<svg[^>]+height)="[^"]+"/i, '$1="' + canvas.height + '"');
return 'data:image/svg+xml;base64,' + btoa(svgStr);

@szimek can this be merged soon?
Thanks in Advance 👍

@UziTech Would you have time to take a look at it? If not, I'll take a look at it myself next weekend.

I can look at it later this week I'll be gone the next few days with limited access to internet.

@szimek I think this should be merged. The viewBox is unitless so devicePixelRatio should not be considered.

Funny 😂 Because I had many troubles with this, too. I already fixed it by myself. And now I wanted to make a PR and found your's 🤣
var svgStr = atob(signaturePad.toDataURL('image/svg+xml').replace(/^[^,]+,/, ''));
svgStr = svgStr.replace(/(viewBox)="[^"]+"/i, '$1="0 0 ' + canvas.width + ' ' + canvas.height + '"');
svgStr = svgStr.replace(/(<svg[^>]+width)="[^"]+"/i, '$1="' + canvas.width + '"');
svgStr = svgStr.replace(/(<svg[^>]+height)="[^"]+"/i, '$1="' + canvas.height + '"');
return 'data:image/svg+xml;base64,' + btoa(svgStr);

@szimek can this be merged soon? Thanks in Advance 👍

Thank you very much, it is working.


LAST_VALUE syntax: rows_range_clause is optional

The syntax is incorrect, as rows_range_clause should be optional and therefore in square brackets:
LAST_VALUE ( [ scalar_expression ] )  [ IGNORE NULLS | RESPECT NULLS ]
    OVER ( [ partition_by_clause ] order_by_clause rows_range_clause )

should be
LAST_VALUE ( [ scalar_expression ] )  [ IGNORE NULLS | RESPECT NULLS ]
    OVER ( [ partition_by_clause ] order_by_clause [ rows_range_clause ] )

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43ffda42-ab8a-74df-0b14-92cc12cf39df
Version Independent ID: 1fd3836e-52fa-014c-67de-b73e0fd810ed
Content: LAST_VALUE (Transact-SQL) - SQL Server
Content Source: docs/t-sql/functions/last-value-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @markingmyname
Microsoft Alias: maghan

@peterbud -- Peter, thank you for catching that.  I am updating the article.

@peterbud -- Peter, thank you for your feedback.  I have updated the documentation and it should be live by tomorrow.


Add support for Shared VPC Architecture

1. Issue, if available:
https://github.com/aws/karpenter/issues/1368
2. Description of changes:
This provides a way to configure the VPC Subnets used by Karpenter for users who have clusters in environments where they do not have access to the VPC Subnet tags.
This can happen in environments which use a Shared VPC Architecture. To provide a workaround for this type of architecture, the magic keys subnet-arn and subnet-id are used to indicate that the user is specifying subnets explicitly.
In the implementation, the magic keys indicate that a different type of ec2.Filter object should be used in the call to the ec2.DescribeSubnetsWithContext method.
3. How was this change tested?
I tested with an AWS EKS Cluster running Server Version: v1.21.5-eks-bc4871b
Here is the Provisioner I used:
apiVersion: karpenter.sh/v1alpha5
kind: Provisioner
metadata:
  name: default
spec:
  limits:
    resources:
      cpu: "50"
  provider:
    amiFamily: AL2
    instanceProfile: KarpenterNodeInstanceProfile-irasnyd-test
    securityGroupSelector:
      kubernetes.io/cluster/irasnyd-test: "*"
    subnetSelector:
      subnet-id: subnet-0b8acc182f78e5773,subnet-04de6812b38fff67b,subnet-0ea54104b710f7bbc,subnet-0fa94757359cecbf5
    tags:
      Name: karpenter-default
  requirements:
    - key: karpenter.sh/capacity-type
      operator: In
      values:
        - spot
  ttlSecondsAfterEmpty: 120

4. Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened:
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for opening this! We're discussing this one a little bit just to make sure we're making the right decision on expanding the API. I agree that the use-case is valid and we need to solve for this!
We're currently considering:

your approach w/ the magic key strings
adding a separate field to the cloud provider spec that takes a list of strings where you could pass arn or id
expanding the selectors to allow for a tags section which would match what we have today and then an ids section

One option is to implement the magic using the reserved syntax like "aws:id" see: https://docs.aws.amazon.com/general/latest/gr/aws_tagging.html
This makes it clear that it's syntactic sugar and not something the user can specify while also not introducing a new field just to cover this edge case.
Whatever we do, we should do the same thing for subnets and security groups. This leads us to something like "id" instead of "subnet-id".

Looks like formatting might be off somewhere, can you run make verify and check-in any changes made with that command?

Looks like formatting might be off somewhere, can you run make verify and check-in any changes made with that command?

Thanks for helping me figure out what went wrong. I was pretty confused. 😄
I ran make verify and it altered the order of imports in provider_validation.go. I committed and force pushed to my branch with the fix. It passes make verify locally on my workstation now; I think it should pass the CI/CD. Thanks again for the help.

Looking forward to this feature, this is just what we are waiting for!
Thanks @irasnyd @bwagner5 - any release planned?

Should be next week!


Conditional properties through discriminated unions and intersections in TypeScript

What problem does this feature solve?
It would be very useful to explain component properties the following manner.
interface CommonProps {
    size?: 'xl' | 'l' | 'm' | 's' | 'xs';
}

type ConditionalProps = {
    color?: 'normal' | 'primary' | 'secondary';
    appearance?: 'normal' | 'outline' | 'text';
} | {
    color: 'white';
    appearance: 'outline';
};

type Props = CommonProps & ConditionalProps

What does the proposed API look like?
This issue is related to https://github.com/vuejs/core/issues/4294, but the use case is different.
Here is an article that goes into more information on this approach.

Supported in Vue Macros https://github.com/sxzz/unplugin-vue-macros/commit/37f4fd3637f40d1734a49f044a06bddc52cf9a07

@sxzz Do you know how this would be accomplished using .ts?
export default defineComponent({
  name: 'MyComponent',
  props: {
    // how can discriminated unions and intersections be used here?
  },
  setup() {
    return () => (
      // ...
    )
  }
})


filters on asg events

ie. this asg is spinning and failing instances. doesn't qualify as structurally invalid, but say the elb health check is failing, and the instances are being spun up continuously on a slow cycle.

there doesn't seem to a way to filter this down via query to events over the last day instead it takes an event count param (max).
http://boto3.readthedocs.io/en/latest/reference/services/autoscaling.html#AutoScaling.Client.describe_scaling_activities


https://datatracker.ietf.org/doc/draft-ietf-*/history/ contains hyperlinks links to drafts, but these links redirect to the final RFC

Describe the issue
I visit https://datatracker.ietf.org/doc/draft-ietf-sieve-managesieve/history/ and there I can click on the hyperlinks:

draft-ietf-sieve-managesieve-09.txt ↦ https://datatracker.ietf.org/doc/draft-ietf-sieve-managesieve/09/, or
draft-ietf-sieve-managesieve-06.txt ↦ https://datatracker.ietf.org/doc/draft-ietf-sieve-managesieve/06/

I expect after clicking on the link to read the respective version of the draft. Instead I am always redirected to the final RFC — https://datatracker.ietf.org/doc/rfc5804/.
I want to read the drafts.
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

For me, the first example you give (https://datatracker.ietf.org/doc/draft-ietf-sieve-managesieve/09/) goes to the expected document. Others do redirect to the RFC. Looking at the list of versions, it seems that not all the revisions are available. It only seems to have the last rev of each draft shown in the history. The others redirect to the RFC.
We seem to have the other versions in the archive so I'm not sure why it's only listing those versions as available.

See #4933. We don't have DocHistory (that is, we don't know things like who the shepherd was) for drafts that existed before the datatracker came into existance. We've been modifying things to show that we have old versions, and plan to change the UX to show all the old versions when we have them (not just those we have DocHistory for) with a disclaimer that we don't have the metadata for that version.

Looking at the list of versions, it seems that not all the revisions are available.

The same page offers to compare two revisions, e.g. by generating the hyperlink https://author-tools.ietf.org/iddiff?url1=draft-ietf-sieve-managesieve-08&url2=draft-ietf-sieve-managesieve-06&difftype=--html .  There both revisions are available.  So all revisions are available somewhere.

Yes, we have the bits (for almost all revisions of all drafts) - and the datatracker knows about them via Submission objects (see again the discussion in #4933) - but we don't have the metadata for many of the fields that would show on the front page - hence the planned change I describe above.

At the moment, you can view at all the known versions using the /html/ views. See https://datatracker.ietf.org/doc/html/draft-ietf-sieve-managesieve-09 for example.

Currently https://datatracker.ietf.org/doc/draft-ietf-sieve-managesieve/history/ generates as hyperlink
draft-ietf-sieve-managesieve-07.txt → https://datatracker.ietf.org/doc/draft-ietf-sieve-managesieve/07/
I am asking to change this to the /html/ view:
draft-ietf-sieve-managesieve-07.txt → https://datatracker.ietf.org/doc/html/draft-ietf-sieve-managesieve-07
This will solve the current case perfectly.


Pushing the code/adding spaces on save.

Hi, so every time I save in VScode the extension does this, is this normal? it wasn't like this before.
I tried uninstalling any other extensions that might be messing with it, I have format on saving enabled, every time I save my code the extension formats it sure, but it pushes the whole code to the right-hand side, any idea why?
Example image

I forgot this issue is open. I don't remember how I fixed that terrible issue but all I remember is that I uninstalled vscode entirely with all its extensions then reinstalled everything, I hope it never happens again to me or anyone.


Support specifying chart values for conformance test workflow

So we can test non default configurations.

I just realized that in the "latest" case (not a released Antrea version), you build the Antrea image with ./hack/build-antrea-linux-all.sh but you don't actually load it into the Kind cluster Nodes. My understanding is that the image will then be pulled from the Dockerhub registry, which may not have been what you intended. Don't you need a kind load docker-image command somewhere?

For jenkins pipeline we use "kind load docker-image antrea/antrea-ubuntu:latest" to load images into the cluster nodes.

I just realized that in the "latest" case (not a released Antrea version), you build the Antrea image with ./hack/build-antrea-linux-all.sh but you don't actually load it into the Kind cluster Nodes. My understanding is that the image will then be pulled from the Dockerhub registry, which may not have been what you intended. Don't you need a kind load docker-image command somewhere?

kind-setup.sh loads the image by default. I have added a comment to explain it.
https://github.com/antrea-io/antrea/blob/33a467700029fd8239c202e17a6291519a23b656/ci/kind/kind-setup.sh#L22-L23

/skip-all


Fix args in tasks.json

Hi there! :)
Problem
The VSCode setup as described in IDE and code editor configuration doesn't work. Specifically, using the provided tasks.json, the argument build gets lost from the go build command.
Context
According to the VS Code docs, "Properties defined in an operating system specific scope override properties defined in the task or global scope."
My Solution
Remove the global args and specify its content as part of the OS-specifc args.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9513638). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13116   +/-   ##
=========================================
  Coverage          ?   42.52%
=========================================
  Files             ?      673
  Lines             ?    74118
  Branches          ?        0
=========================================
  Hits              ?    31515
  Misses            ?    37484
  Partials          ?     5119

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9513638...b1d599d. Read the comment docs.

Yeah it changed some time ago, it was working with older VS Code versions :)


fix(chat): fix search, add feature flag for "Add App"

Description:

fix search
add feature flag

Issues:
Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review


Include auto flush

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.4 out of 5 committers have signed the CLA.:white_check_mark: amunra:white_check_mark: ideoma:white_check_mark: jerrinot:white_check_mark: bluestreak01:x: BrandonEscamillaYou have signed the CLA already but the status is still pending? Let us recheck it.


App crash at /namespaces

To Reproduce
Steps to reproduce the behavior:

Go to 'Namespaces'
Click on 'namespace'
App crashes. See error below:

instrument.js:109 TypeError: namespace.getStatus is not a function
Expected behavior
Should show the details of the namspace without any error.
Screenshots
Namespace-Crash-Error-Image-Reference
Environment (please complete the following information):

Lens Version: 5.x
OS: [e.g. OSX]: Mac OS, Catalina and Sur
Installation method (e.g. snap or AppImage in Linux): Updated Version

Logs:
When you run the application executable from command line you will see some logging output. Please paste them here:
instrument.js:109 TypeError: namespace.getStatus is not a function
    at NamespaceDetails.render (namespace-details.tsx:85)
    at allowStateChanges (mobx.esm.js:1204)
    at mobxreact.esm.js:300
    at trackDerivedFunction (mobx.esm.js:1785)
    at Reaction.track (mobx.esm.js:2329)
    at NamespaceDetails.reactiveRender [as render] (mobxreact.esm.js:298)
    at NamespaceDetails.makeComponentReactive (mobxreact.esm.js:313)
    at NamespaceDetails.target.render (mobxreact.esm.js:226)
    at qi (react-dom.production.min.js:187)
    at pi (react-dom.production.min.js:186)
    at ck (react-dom.production.min.js:269)
    at bk (react-dom.production.min.js:250)
    at ak (react-dom.production.min.js:250)
    at Tj (react-dom.production.min.js:250)
    at Lj (react-dom.production.min.js:243)
    at react-dom.production.min.js:123
    at exports.unstable_runWithPriority (scheduler.production.min.js:18)
    at gg (react-dom.production.min.js:122)
    at jg (react-dom.production.min.js:123)
    at ig (react-dom.production.min.js:122)
    at Hb (react-dom.production.min.js:292)
    at gd (react-dom.production.min.js:73)
    at HTMLDivElement.sentryWrapped (helpers.js:72)

Kubeconfig:
Quite often the problems are caused by malformed kubeconfig which the application tries to load. Please share your kubeconfig, remember to remove any secret and sensitive information.
your kubeconfig here

Additional context
Add any other context about the problem here.

By version 5.X do you mean that it consistently fails with 5.0, 5.1, and 5.2?
If you clean out your ~/Library/Application Support/Lens folder (and save it somewhere) does this still happen?

@Nokel81 - Did not find Lens folder inside Application Support

Any update on this, the latest Lens release also have no fix on this.
This is noticed in MacOS Big Sur - 11.6
Lens version: 5.2x

If you go to a terminal and type the following commands can you post a screenshot of the result?
cd ~/Library
ls

Or even better, can you open your devtools, trigger this error, then set a breakpoint at that line, then go back in history using the main menu View > Go Back and then navigate back to view namespaces.
Finally, go back to your devtools and look at the value of namespace and post a screenshot here.
Thanks

Library contents

If you clean out your ~/Library/Application Support/Lens folder (and save it somewhere) does this still happen?

Yes its happening.

I am seeing this in latest 5.2.4 version also

this is the namespace for your information:
{
  "apiVersion": "v1",
  "kind": "Namespace",
  "metadata": {
    "name": "default",
    "uid": "bbc8790c-e52f-4801-9f57-a43507f1ec09",
    "resourceVersion": "207",
    "creationTimestamp": "2021-08-27T01:26:32Z",
    "managedFields": [
      {
        "manager": "kube-apiserver",
        "operation": "Update",
        "apiVersion": "v1",
        "time": "2021-08-27T01:26:32Z",
        "fieldsType": "FieldsV1",
        "fieldsV1": {
          "f:status": {
            "f:phase": {}
          }
        }
      }
    ],
    "selfLink": "/api/v1/namespaces/default"
  },
  "status": {
    "phase": "Active"
  },
  "spec": {
    "finalizers": [
      "kubernetes"
    ]
  }
}

Error Image:

this is the namespace for your information:

can you provide the prototype hierarchy of that value?

Any update on this? Can this be re-opened?

No release has been made with the resolving PR. It will definitely be out as part of 5.3.0 (currently on alpha.8) but it might be out as part of 5.2.6 if the PR can be applied cleanly.

5.2.6 is released, no crash happening. But no data also displayed 😞

If you open up devtools you should see an error that starts with [NamespaceDetails]: passed object that is not an instanceof Namespace can you post a screenshot of that?

Would you mind sharing what the selfLink getter returns?

Do you have any extensions installed?

No more extensions apart from the one which we build

this is the selfLink details: /api/v1/namespaces/default? How do we get the return details?

if you start lens from the command line with DEBUG=true as a prefix you should be able to see the requests

Similar issue for different KubeObject

Cleaning up ~/Library/Application\ Support/Lens/lens-local-storage/e8d1...4fc1.json will fix that issue in the future.
@DanishKhakwani Thanks for the report but that is a slightly different bug, that has to do with something surrounding the logs saving bad data and we are not handling it very well.
Thanks for the report though.

No more extensions apart from the one which we build

Do you create any KubeApis?

@Nokel81 - yes we do have our own KubeApis

Do you mind sharing what your KubeApis are? Do you automatically add items to other stores from within your extension?

Weird observation is the same namespaces that we have works without extension enabled. Once extension is enabled, the app crashes by throwing errors as:
instrument.js:109 TypeError: namespace.getStatus is not a function
    at NamespaceDetails.render (namespace-details.tsx:85)

Weird observation is the same namespaces that we have works without extension enabled. Once extension is enabled, the app crashes by throwing errors as:
instrument.js:109 TypeError: namespace.getStatus is not a function
    at NamespaceDetails.render (namespace-details.tsx:85)

Any update on this?

So it sounds like a bug in your extension, are you registering KubeApis?

Can you brief me a little on API registering? We have done that for custom resources extension development. This namespace we have not done anywhere in our code. Where do we need to do it if suppose we have missed it?

This namespace we have not done anywhere in our code.

Does it crash for only one namespace or for all of them?

Sure, I can brief you on it.
So the only way for you to do this is if you either call Renderer.k8sApi.apiManager.registerApi or Renderer.k8sApi.forCluster or Renderer.k8sApi.forRemoteCluster.
Though now looking at the offending code, it seems that if your extension was to call Renderer.k8sApi.apiManager.registerStore with a class T extends KubeObjectStore which has a field api whose apiBase is "/api/v1/namespaces" then this problem would occur. And I think we probably should guard against that.

This issue was we have registered namespacestore once again from our codebase. After fetching this directly from lens k8sapi store, it seems to work absolutely fine. Thank you for your patience and sorry for the big chain of comments here.


HDDS-6516. Shade Kotlin for Ozone Filesystem

What changes were proposed in this pull request?
Relocate Kotlin in shaded Ozone Filesystem jar, to avoid possible version mismatch in downstream projects.
https://issues.apache.org/jira/browse/HDDS-6516
How was this patch tested?
$ unzip -t hadoop-ozone/dist/target/ozone-*/share/ozone/lib/ozone-filesystem-hadoop3-*.jar | grep kotlin | head
    testing: org/apache/hadoop/ozone/shaded/kotlin/   OK
    testing: org/apache/hadoop/ozone/shaded/kotlin/ranges/   OK
    testing: org/apache/hadoop/ozone/shaded/kotlin/experimental/   OK
    testing: org/apache/hadoop/ozone/shaded/kotlin/comparisons/   OK
    testing: org/apache/hadoop/ozone/shaded/kotlin/native/   OK
    testing: org/apache/hadoop/ozone/shaded/kotlin/native/concurrent/   OK
    testing: org/apache/hadoop/ozone/shaded/kotlin/js/   OK
    testing: org/apache/hadoop/ozone/shaded/kotlin/contracts/   OK
    testing: org/apache/hadoop/ozone/shaded/kotlin/reflect/   OK
    testing: org/apache/hadoop/ozone/shaded/kotlin/io/   OK

https://github.com/adoroszlai/hadoop-ozone/runs/5697432507

Thanks @ayushtkn for the review.


[BUG] Wrong instruction has a lower (better) score than the exact matching instruction

Describe the bug
I could be missing something obvious... I'm seeing a better match score for 40:    move    v0,zero than the actual matching instruction 40:    li      v0,1
To Reproduce
Steps to reproduce the behavior:

Go to https://decomp.me/scratch/y3vrf
Open the 3-way compare view
Change line 37 ("change me") from return 1 to return 0
See the issue

Expected behavior
Score decreases
Screenshots

Scratches
See repro steps above
Desktop (please complete the following information if applicable):

OS X
Chrome 129

Could be that the re-ordered version is better that the version with more lines matching. So maybe not a bug.

It would be an issue for asm-differ, but as you say, the lower score has more correct instructions


Handle static OSM extract URLs

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
[x] The description lists all applicable issues this PR seeks to resolve
[x] The description lists any configuration setting(s) that differ from the default settings
[ ] All tests and CI builds passing

Description
Fixes #349.

Codecov Report

Merging #350 into dev will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev     #350      +/-   ##
============================================
- Coverage     24.02%   23.99%   -0.04%
  Complexity      561      561
============================================
  Files           175      175
  Lines          9068     9080      +12
  Branches       1231     1234       +3
============================================
  Hits           2179     2179
- Misses         6681     6693      +12
  Partials        208      208

Flag
Coverage Δ
Complexity Δ

#unit_tests
23.99% <0.00%> (-0.04%)
561.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ
Complexity Δ

.../conveyal/datatools/manager/models/Deployment.java
3.12% <0.00%> (-0.18%)
5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f0adc...5eda326. Read the comment docs.

:tada: This PR is included in version 3.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Saving Datatable Problem

Hi,
first of all thank you for developing this plugin, everything seems to be alright except I'm having a problem with saving datatable (in dashboard).
When I hit 'Save Datatable' nothing happens.
Do you have any idea what is causing this problem?
thanks!
Marin

Hello Marin!
There are still more work to be done. Adore-Datatables settings page is still under construction. Which means you cannot create any new datatables yet. However, you can use the demo shortcode for testing the plugin.
Niraj Kumar

Hello
Thank for developing this plugin, but there is a way to pass variable through url ??

Hello! Apology for late reply! I was away.
Can you please elaborate more on your issue? Give some more information to understand the context?


IP allocation was seeded by different peers error when joining nodes

What you expected to happen?
When joining nodes to a cluster while weave is running as a Daemonset, the new weave pod should connect to other nodes.
What happened?

INFO: 2021/07/20 19:58:46.261622 ->[<IP_ADDRESS>:6783|a6:66:22:93:29:51(ip-172-31-5-186)]: connection shutting down due to error: IP allocation was seeded by different peers (received: [a6:66:22:93:29:51(ip-172-31-5-186)], ours: [8a:d2:32:87:dc:db(ip-172-31-6-167)])

How to reproduce it?

Use weave 2.7.1+ installed as a DaemonSet then join a new node with kubeadm. It happens sometimes but not always. It never happens on 2.6.5.
Anything else we need to know?

Versions:

$ weave version
2.8.1
$ containerd version
1.4.4
$ uname -a
Linux ip-172-31-5-186 5.4.0-1041-aws #43-Ubuntu SMP Fri Mar 19 22:06:16 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.10", GitCommit:"98d5dc5d36d34a7ee13368a7893dcb400ec4e566", GitTreeState:"clean", BuildDate:"2021-04-15T03:28:42Z", GoVersion:"go1.15.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.10", GitCommit:"98d5dc5d36d34a7ee13368a7893dcb400ec4e566", GitTreeState:"clean", BuildDate:"2021-04-15T03:20:25Z", GoVersion:"go1.15.10", Compiler:"gc", Platform:"linux/amd64"}

Logs:
$ docker logs weave

or, if using Kubernetes:
$ kubectl logs -n kube-system <weave-net-pod> weave
INFO: 2021/07/20 19:58:44.533248 Command line options: map[conn-limit:200 datapath:datapath db-prefix:/weavedb/weave-net docker-api: expect-npc:true http-addr:<IP_ADDRESS>:6784 ipalloc-init:consensus=1 ipalloc-range:<IP_ADDRESS>/20 log-level:info metrics-addr:<IP_ADDRESS>:6782 name:8a:d2:32:87:dc:db nickname:ip-172-31-6-167 no-dns:true no-masq-local:true port:6783]
INFO: 2021/07/20 19:58:44.533303 weave  2.8.1
INFO: 2021/07/20 19:58:45.716752 Bridge type is bridged_fastdp
INFO: 2021/07/20 19:58:45.716782 Communication between peers via untrusted networks is encrypted.
INFO: 2021/07/20 19:58:46.006785 Our name is 8a:d2:32:87:dc:db(ip-172-31-6-167)
INFO: 2021/07/20 19:58:46.006842 Launch detected - using supplied peer list: [<IP_ADDRESS>]
INFO: 2021/07/20 19:58:46.006867 Using "no-masq-local" LocalRangeTracker
INFO: 2021/07/20 19:58:46.006873 Checking for pre-existing addresses on weave bridge
INFO: 2021/07/20 19:58:46.007890 [allocator 8a:d2:32:87:dc:db] No valid persisted data
INFO: 2021/07/20 19:58:46.013141 [allocator 8a:d2:32:87:dc:db] Initialising via deferred consensus
INFO: 2021/07/20 19:58:46.013209 Sniffing traffic on datapath (via ODP)
INFO: 2021/07/20 19:58:46.013668 ->[<IP_ADDRESS>:6783] attempting connection
INFO: 2021/07/20 19:58:46.016169 Listening for HTTP control messages on <IP_ADDRESS>:6784
INFO: 2021/07/20 19:58:46.016204 Listening for metrics requests on <IP_ADDRESS>:6782
INFO: 2021/07/20 19:58:46.017452 ->[<IP_ADDRESS>:6783|a6:66:22:93:29:51(ip-172-31-5-186)]: connection ready; using protocol version 2
INFO: 2021/07/20 19:58:46.017648 overlay_switch ->[a6:66:22:93:29:51(ip-172-31-5-186)] using fastdp
INFO: 2021/07/20 19:58:46.017685 ->[<IP_ADDRESS>:6783|a6:66:22:93:29:51(ip-172-31-5-186)]: connection added (new peer)
INFO: 2021/07/20 19:58:46.017720 Setting up IPsec between 8a:d2:32:87:dc:db(ip-172-31-6-167) and a6:66:22:93:29:51(ip-172-31-5-186)
INFO: 2021/07/20 19:58:46.017804 ipsec: InitSALocal: <IP_ADDRESS> -> <IP_ADDRESS> :6784 0x7328eb30
INFO: 2021/07/20 19:58:46.244095 adding entry <IP_ADDRESS>/20 to weaver-no-masq-local of 0
INFO: 2021/07/20 19:58:46.244124 added entry <IP_ADDRESS>/20 to weaver-no-masq-local of 0
INFO: 2021/07/20 19:58:46.261622 ->[<IP_ADDRESS>:6783|a6:66:22:93:29:51(ip-172-31-5-186)]: connection shutting down due to error: IP allocation was seeded by different peers (received: [a6:66:22:93:29:51(ip-172-31-5-186)], ours: [8a:d2:32:87:dc:db(ip-172-31-6-167)])
INFO: 2021/07/20 19:58:46.261707 ->[<IP_ADDRESS>:6783|a6:66:22:93:29:51(ip-172-31-5-186)]: connection deleted

$ kubectl get events
22m         Normal    Scheduled           pod/weave-net-wpt77                 Successfully assigned kube-system/weave-net-wpt77 to ip-172-31-6-167
22m         Warning   FailedMount         pod/weave-net-wpt77                 MountVolume.SetUp failed for volume "weave-net-token-kt2w5" : failed to sync secret cache: timed out waiting for the condition

Adding logs from the first weave pod in the daemonset
$ kubectl -n kube-system get pods -l name=weave-net
NAME              READY   STATUS    RESTARTS   AGE
weave-net-wpt77   2/2     Running   0          37m
weave-net-zrcnp   2/2     Running   1          52m

$ kubectl -n kube-system logs weave-net-zrcnp -c weave
DEBU: 2021/07/20 19:42:59.239039 [kube-peers] Checking peer "a6:66:22:93:29:51" against list &{[]}
Peer not in list; removing persisted data
INFO: 2021/07/20 19:42:59.330218 Command line options: map[conn-limit:200 datapath:datapath db-prefix:/weavedb/weave-net docker-api: expect-npc:true http-addr:<IP_ADDRESS>:6784 ipalloc-init:consensus=0 ipalloc-range:<IP_ADDRESS>/20 log-level:info metrics-addr:<IP_ADDRESS>:6782 name:a6:66:22:93:29:51 nickname:ip-172-31-5-186 no-dns:true no-masq-local:true port:6783]
INFO: 2021/07/20 19:42:59.330256 weave  2.8.1
INFO: 2021/07/20 19:43:00.189071 Bridge type is bridged_fastdp
INFO: 2021/07/20 19:43:00.189094 Communication between peers via untrusted networks is encrypted.
INFO: 2021/07/20 19:43:00.412553 Our name is a6:66:22:93:29:51(ip-172-31-5-186)
INFO: 2021/07/20 19:43:00.412593 Launch detected - using supplied peer list: []
INFO: 2021/07/20 19:43:00.412617 Using "no-masq-local" LocalRangeTracker
INFO: 2021/07/20 19:43:00.412623 Checking for pre-existing addresses on weave bridge
INFO: 2021/07/20 19:43:00.413570 [allocator a6:66:22:93:29:51] No valid persisted data
INFO: 2021/07/20 19:43:00.430737 [allocator a6:66:22:93:29:51] Initialising via deferred consensus
INFO: 2021/07/20 19:43:00.430821 Sniffing traffic on datapath (via ODP)
INFO: 2021/07/20 19:43:00.434519 Listening for HTTP control messages on <IP_ADDRESS>:6784
INFO: 2021/07/20 19:43:00.434555 Listening for metrics requests on <IP_ADDRESS>:6782
INFO: 2021/07/20 19:43:01.403816 [kube-peers] Added myself to peer list &{[{a6:66:22:93:29:51 ip-172-31-5-186}]}
DEBU: 2021/07/20 19:43:01.412212 [kube-peers] Nodes that have disappeared: map[]
INFO: 2021/07/20 19:43:01.423916 Assuming quorum size of 1
INFO: 2021/07/20 19:43:01.424012 adding entry <IP_ADDRESS>/20 to weaver-no-masq-local of 0
INFO: 2021/07/20 19:43:01.424035 added entry <IP_ADDRESS>/20 to weaver-no-masq-local of 0
<IP_ADDRESS>
DEBU: 2021/07/20 19:43:01.548065 registering for updates for node delete events
WARN: 2021/07/20 19:43:17.002603 [allocator]: Delete: no addresses for 6228433a122cae07ecadcdd0c15a0d756647bee66df0280b163bca9fc9adede9
WARN: 2021/07/20 19:43:17.061381 [allocator]: Delete: no addresses for ade7f32d47e420177d611ccb26b64744e3258e8443452ce0ab2c5c0c33d4eb84
WARN: 2021/07/20 19:43:18.414037 [allocator]: Delete: no addresses for 6228433a122cae07ecadcdd0c15a0d756647bee66df0280b163bca9fc9adede9
WARN: 2021/07/20 19:43:18.429535 [allocator]: Delete: no addresses for ade7f32d47e420177d611ccb26b64744e3258e8443452ce0ab2c5c0c33d4eb84
WARN: 2021/07/20 19:43:30.178501 [allocator]: Delete: no addresses for ddc56d0ae7e2c549b8d8a75f0cf5033479510350868b2309eade68b4b39c261c
WARN: 2021/07/20 19:43:30.306579 [allocator]: Delete: no addresses for ddc56d0ae7e2c549b8d8a75f0cf5033479510350868b2309eade68b4b39c261c
WARN: 2021/07/20 19:43:46.149578 [allocator]: Delete: no addresses for 6228433a122cae07ecadcdd0c15a0d756647bee66df0280b163bca9fc9adede9
WARN: 2021/07/20 19:43:46.341428 [allocator]: Delete: no addresses for ddc56d0ae7e2c549b8d8a75f0cf5033479510350868b2309eade68b4b39c261c
WARN: 2021/07/20 19:43:46.522150 [allocator]: Delete: no addresses for ade7f32d47e420177d611ccb26b64744e3258e8443452ce0ab2c5c0c33d4eb84
WARN: 2021/07/20 19:44:20.223305 [allocator]: Delete: no addresses for d8391bd1ae52207565b5e7988076d67ebd987c8b3854f4ccae722dcfd027de37
WARN: 2021/07/20 19:44:58.455047 [allocator]: Delete: no addresses for c855331c281c9f384687f998fa97d2a8698d4fa8ebf0b8e79fd765fe1e6012b7
WARN: 2021/07/20 19:45:02.294243 [allocator]: Delete: no addresses for 06fcd42a50aa2996f68edd9f0f09a2aaf8c307fe05217db36779cee9fcc30529
WARN: 2021/07/20 19:45:02.310922 [allocator]: Delete: no addresses for 350becfc49098128281097bdb8e57608510380eb39dc3dba90535145603812bc
WARN: 2021/07/20 19:45:46.725664 [allocator]: Delete: no addresses for 06fcd42a50aa2996f68edd9f0f09a2aaf8c307fe05217db36779cee9fcc30529
WARN: 2021/07/20 19:45:46.939546 [allocator]: Delete: no addresses for 350becfc49098128281097bdb8e57608510380eb39dc3dba90535145603812bc
INFO: 2021/07/20 19:51:53.047391 ->[<IP_ADDRESS>:47596] connection accepted
INFO: 2021/07/20 19:51:53.048531 ->[<IP_ADDRESS>:47596] connection shutting down due to error during handshake: failed to receive remote protocol header: EOF
INFO: 2021/07/20 19:58:45.999242 ->[<IP_ADDRESS>:36989] connection accepted
INFO: 2021/07/20 19:58:46.001957 ->[<IP_ADDRESS>:36989|8a:d2:32:87:dc:db(ip-172-31-6-167)]: connection ready; using protocol version 2
INFO: 2021/07/20 19:58:46.003011 overlay_switch ->[8a:d2:32:87:dc:db(ip-172-31-6-167)] using fastdp
INFO: 2021/07/20 19:58:46.003061 ->[<IP_ADDRESS>:36989|8a:d2:32:87:dc:db(ip-172-31-6-167)]: connection added (new peer)
INFO: 2021/07/20 19:58:46.003426 Setting up IPsec between a6:66:22:93:29:51(ip-172-31-5-186) and 8a:d2:32:87:dc:db(ip-172-31-6-167)
INFO: 2021/07/20 19:58:46.003798 ipsec: InitSALocal: <IP_ADDRESS> -> <IP_ADDRESS> :6784 0x96066430
INFO: 2021/07/20 19:58:46.128415 fastdp ->[<IP_ADDRESS>:6784|8a:d2:32:87:dc:db(ip-172-31-6-167)]: IPSec init SA remote
INFO: 2021/07/20 19:58:46.128448 ipsec: InitSARemote: <IP_ADDRESS> -> <IP_ADDRESS> :6784 0x7328eb30
INFO: 2021/07/20 19:58:46.131741 overlay_switch ->[8a:d2:32:87:dc:db(ip-172-31-6-167)] using sleeve
INFO: 2021/07/20 19:58:46.131776 ->[<IP_ADDRESS>:36989|8a:d2:32:87:dc:db(ip-172-31-6-167)]: connection fully established
INFO: 2021/07/20 19:58:46.132637 sleeve ->[<IP_ADDRESS>:6783|8a:d2:32:87:dc:db(ip-172-31-6-167)]: Effective MTU verified at 8915
INFO: 2021/07/20 19:58:46.246786 ->[<IP_ADDRESS>:36989|8a:d2:32:87:dc:db(ip-172-31-6-167)]: connection shutting down due to error: read tcp <IP_ADDRESS>:6783-><IP_ADDRESS>:36989: read: connection reset by peer
INFO: 2021/07/20 19:58:46.246857 ->[<IP_ADDRESS>:36989|8a:d2:32:87:dc:db(ip-172-31-6-167)]: connection deleted
INFO: 2021/07/20 19:58:46.246899 Removed unreachable peer 8a:d2:32:87:dc:db(ip-172-31-6-167)
INFO: 2021/07/20 19:58:46.246961 Destroying IPsec between a6:66:22:93:29:51(ip-172-31-5-186) and 8a:d2:32:87:dc:db(ip-172-31-6-167)
INFO: 2021/07/20 19:58:46.246975 ipsec: destroy: in <IP_ADDRESS> -> <IP_ADDRESS> 0x96066430
INFO: 2021/07/20 19:58:46.320697 ipsec: destroy: out <IP_ADDRESS> -> <IP_ADDRESS> 0x7328eb30
INFO: 2021/07/20 19:58:48.548774 ->[<IP_ADDRESS>:45403] connection accepted
INFO: 2021/07/20 19:58:48.549796 ->[<IP_ADDRESS>:45403|8a:d2:32:87:dc:db(ip-172-31-6-167)]: connection ready; using protocol version 2
INFO: 2021/07/20 19:58:48.550343 overlay_switch ->[8a:d2:32:87:dc:db(ip-172-31-6-167)] using fastdp
INFO: 2021/07/20 19:58:48.550463 ->[<IP_ADDRESS>:45403|8a:d2:32:87:dc:db(ip-172-31-6-167)]: connection added (new peer)
INFO: 2021/07/20 19:58:48.550504 Setting up IPsec between a6:66:22:93:29:51(ip-172-31-5-186) and 8a:d2:32:87:dc:db(ip-172-31-6-167)
INFO: 2021/07/20 19:58:48.550579 ipsec: InitSALocal: <IP_ADDRESS> -> <IP_ADDRESS> :6784 0x3e355f40
INFO: 2021/07/20 19:58:48.650979 ->[<IP_ADDRESS>:45403|8a:d2:32:87:dc:db(ip-172-31-6-167)]: connection shutting down due to error: IP allocation was seeded by different peers (received: [8a:d2:32:87:dc:db(ip-172-31-6-167)], ours: [a6:66:22:93:29:51(ip-172-31-5-186)])
...

To add a little more color, this issue happens infrequently.
I've spent some time digging through the code and logs. it is difficult to tell what is going wrong as the logs are sparse and I am not too familiar with the project.
I've tried to reproduce this issue 4 more times since with debug logs enabled with no luck. I will continue to try.

Captured the error with debug logging enabled.
after_join_master2.txt
secondary_node.txt

Adding some more detail. Debug logs were captured from a server that was reused after weave reset. Rebooting the server after the reset and before re-installing fixes the issue. A restart is not required with weave 2.6.5.


fail gracefully when minification fails

This PR contains a fix for #36.
It simply wraps the minfication logic for JS, JSON, and XML into a try-catch block and then terminates with a grunt error message.
I found it difficult to add unit tests for this change with the way tests are currently written for the preload task. As this change doesn't really add or change features, I would take the fact that the existing tests still run as a good enough proof of the correctness of the change.
What do you think?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@mlenkeit ping 😉
Do you still have interest to get this PR merged?
I've provided some comments concerning your change.

I took your commit and added my suggestions in #42. Thanks for your work 👍


Hourglass model

Try to use hourglass model in here.

input_image_shape: [1, 192, 192, 3]
output_shape: [1, 48, 48, 14]
input_node_name: image
output_node_name: hourglass_out_3

I think it will speed up 3x than old model and the precision is acceptable.
Tomorrow I will update my repo.
Look forward to your replay ( ? FPS on ipx )

@edvardHua  AWESOME! I'll try that model 👍
Do you have a python script that converts to Core ML model?
I have some issue in converting my own model to Core ML now 😓

Yes, I will let you know when I update repo tomorrow.

@edvardHua I capture video comparing two models.
but It's little weird for accuracy.

model
cpm model
hourglass model

inference time
57(45~70)mm
33(30~35)mm

accuracy
more accurate(0.9)
less accurate(<0.5)

DEMO video

Indeed, the old one have precision is higher than the new one.
PCKh of cpm model is 94.18.
PCKh of hourglass model is 91.

But hourglass do not have too wide difference on android device.
You can test android demo here

@tucan9389 Here is the script I used to convert mlmodel.

Thanks a lot

Unfortunately I can’t open my models. If you want compare between cpm and hourglass model, you can download from here.

Close the issue now. You can reopen when you want. @edvardHua


add pagination support for flowbite

This PR adds support for Flowbite pagination styling.
Flowbite is an open-source library of UI components based on the utility-first Tailwind CSS framework featuring dark mode support, a Figma design system, templates, and more.
Preview darkmode:

Preview lightmode:

Flowbite: https://flowbite.com/
To use this styling throughout the application, you can edit file App\Providers\AppServiceProvider and add Paginator::useFlowbite(); to the boot method
use Illuminate\Pagination\Paginator;

/**
 * Bootstrap any application services.
 */
public function boot(): void
{
    Paginator::useFlowbite();
}

What about license? Flowbite is a paid stuff.
"Simple" variant is missing?
What the reason of another tailwind paginator? Bootstrap variations uses totally different classes that's why its two of them.

What about license? Flowbite is a paid stuff. "Simple" variant is missing? What the reason of another tailwind paginator? Bootstrap variations uses totally different classes that's why its two of them.

Flowbite has an optional paid plan but at its core it consists of open source components. Tailwind has paid plans as well but that does not mean it is "Paid stuff". The code used is available on github.
https://github.com/themesberg/flowbite/tree/main/content/components
https://flowbite.com/docs/components/pagination/
The License is MIT
It is not just another tailwind paginator. Using tailwind pagination styling whilst using Flowbite lacks important design details. For instance, the dark mode does not properly adapt to the tailwind paginator and the tailwind pagination styling does not fit that of the styling of most flowbite components

Wouldn't it be more helpful, when the flowbit

Mubeen142, Great. Do you want to say, that you:

Took a part of Flowbite library - paginator with great feature of dark mode supported, which is covered by MIT License. It's ok.
Made a derivative work, i.e. made blade adaptation of such a cool component. It's ok.
Violates the Flowbite's license by providing this PR - I can't see license file of Flowbite attached anywhere, which is a key part of the MIT license.
Wants to Laravel Framework itself and everyone who use it to also violate Flowbite's License.

Am I right?

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
https://flowbite.com/docs/getting-started/license/

So, as I can see, current PR can't be accepted without violation of Flowbite's License.

I strongly feel that this does not belong in the framework core, but should be a package.

I found myself struggling when trying to use the default pagination laravel provides and I can imagine that other developers faced the same struggles. The design of the default paginator is not properly adapted and makes the default pagination styling look alien compared to the other design features.
Flowbite has a huge community and it has only been growing. This simple change would be great for other developers. It would not be too practical to make a whole new package for something so small but ultimately I understand that you may not want to include support for it and make it a separate package.

I found myself struggling when trying to use the default pagination laravel provides and I can imagine that other developers faced the same struggles. The design of the default paginator is not properly adapted and makes the default pagination styling look alien compared to the other design features.

Which other design features? The few pagination options are the only "opinionated" html components in the framework besides some standard error pages and mail templates. The pagination components are probably something to be sent to laravel/ui as a whole but it will cause a lot of developers to require that package as well since pagination is so omnipresent. For code separation practices it would be a good solution though.


Support IPLD format multicodec IpfsClient::dag_put selection, or at least document the hardcoded defaullt.

The docs for [IpfsClient::dag_put aren't clear about which IPLD format multicodec is used.
For comparison, the js-ipfs API docs for ipfs.dag.put present an option for selecting the IPLD format.
Imagine a developer needs both a JS client and a rust ipfs_api client to interoperate. To do this, at minimum the ipfs_api needs to document which format is used, then the more flexible JS api would need to be modified to match. OTOH, if IpfsClient::dag_put allowed selection of the format, then either implementation could change to interoperate with the other.

Just for everyone that might need this: the IPFS HTTP API docs specify that that inputted data will be parsed as JSON, and committed to the DAG as CBOR encoded data. This seems to be the case upon further testing and inspecting this repo's source code, but it would be good if this behavior was documented!


[extractor/Smotrim] Add extractor (again)

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

This adds support for Smotrim, as a shortcut for RUTV
Closes #4789
Closes #4110
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[x] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

#4789
What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[x] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This adds support for Smotrim, as a shortcut for RUTV
Closes #4789 Closes #4110
Template
Before submitting a pull request make sure you have:

[x]  At least skimmed through contributing guidelines including yt-dlp coding conventions
[x]  Searched the bugtracker for similar pull requests
[x]  Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x]  I am the original author of this code and I am willing to release it under Unlicense
[x]  I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

#4789
What is the purpose of your pull request?

[ ]  Fix or improvement to an extractor (Make sure to add/update tests)
[x]  New extractor (Piracy websites will not be accepted)
[ ]  Core bug fix/improvement
[ ]  New feature (It is strongly recommended to open an issue first)

there are such links, yt-dlp does not find the video on them, again you need to update the extractor
https://smotrim.ru/brand/58339
maybe some more links

Open a new issue for that