change H3_INVALID_INDEX to H3_NULL

Following this issue: https://github.com/uber/h3/issues/378
Also, update the build instructions.

Coverage remained the same at 99.132% when pulling 573f131b56ccd62febe7ca8d2b34ae65e000f4ac on ajfriend:h3null into 5ecee884fdebd280b9e504df6a0a029c3eaffff7 on uber:master.

Should we add #define H3_NULL 0 to h3api.h.in? Remove it from h3index.h?

Sure? I'm not 100% sure this is clearer than the previous name, but I don't object to the change.

The summary might be: There are many possible invalid H3 indexes, but H3_NULL is specific and unique.

Should we add #define H3_NULL 0 to h3api.h.in? Remove it from h3index.h?

I guess we can stay conservative in this PR and not make these changes. Can always do it in the future if we think it would be valuable.

Oh, just saw this:
Mode 0 is reserved and indicates an invalid **H3** index.

Do we want to reserve a whole mode for "intentionally invalid" indices? That would make them non-unique, where uniqueness seems like the main benefit of defining H3_NULL.
If we go that route, should we revisit this constant, which is used in a few places:
https://github.com/uber/h3/blob/fd0f8af156df2f98649304ebbc080e974f708644/src/h3lib/include/h3Index.h#L85-L86

Oh, just saw this:
Mode 0 is reserved and indicates an invalid **H3** index.

Do we want to reserve a whole mode for "intentionally invalid" indices? That would make them non-unique, where uniqueness seems like the main benefit of defining H3_NULL.
If we go that route, should we revisit this constant, which is used in a few places:
https://github.com/uber/h3/blob/fd0f8af156df2f98649304ebbc080e974f708644/src/h3lib/include/h3Index.h#L85-L86

That was for distinguishing the H3 indexes that this OSS project produces versus the original version of H3 when we were first developing it and needed to make a breaking change to the bit format. There were systems that had mixed sets of these indices for a time.

That was for distinguishing the H3 indexes that this OSS project produces versus the original version of H3 when we were first developing it and needed to make a breaking change to the bit format. There were systems that had mixed sets of these indices for a time.

At this point, would it make sense to remove it?

That was for distinguishing the H3 indexes that this OSS project produces versus the original version of H3 when we were first developing it and needed to make a breaking change to the bit format. There were systems that had mixed sets of these indices for a time.

At this point, would it make sense to remove it?

I would argue no. Changes to the bit format of H3 are inherently backwards incompatible, so while it does make 1/16th of the address space inaccessible, adjusting that could cause other problems, particularly with a mixed set of systems that may be operating with different versions of the H3 library.

At this point, would it make sense to remove it?

I would argue no. Changes to the bit format of H3 are inherently backwards incompatible, so while it does make 1/16th of the address space inaccessible, adjusting that could cause other problems, particularly with a mixed set of systems that may be operating with different versions of the H3 library.

That makes sense for Mode 0 in general. I've updated the description in the diff above. Let me know if that jives with everyone.
Specifically, regarding H3_INIT, would it make sense to replace it with H3_NULL, and remove H3_INIT?

Specifically, regarding H3_INIT, would it make sense to replace it with H3_NULL, and remove H3_INIT?

H3_INIT seems to be fulfilling a different need, which is for an index initialized with all indexing digits set to 7.

https://github.com/uber/h3/pull/379#discussion_r472251275
True, but since Travis CI is going away, it won't be generated in the first place?

#379 (comment)
True, but since Travis CI is going away, it won't be generated in the first place?

This will still be the name of the build directory in Github Actions. It would also be created as part of the README instructions.

#379 (comment)
True, but since Travis CI is going away, it won't be generated in the first place?

This will still be the name of the build directory in Github Actions. It would also be created as part of the README instructions.

Ahh, then, yes @ajfriend can we undo the changes to .gitignore?


Use an static embeder for the web ui files.

Is your feature request related to a problem? Please describe.
This is a development side suggestion. I saw the way you embed the UI inside the code and unless I misunderstood the way you are doing it I think you should look into using a tool for that.
Describe the solution you'd like
Not sure which is currently the best but this are some examples, sorted by their stars in github:

https://github.com/gobuffalo/packr <- This one supports to use the locals files while developing.
https://github.com/rakyll/statik
https://github.com/mjibson/esc

Describe alternatives you've considered
You could leave it as it is. Maybe you have an script for this? But to be honest as files increase it becomes a pain.
It will make it simple to split files in smaller without having to deal with the mess of having to update the webUI.go. For example.... the menu_ts.ts file it's something that clearly should be split in smaller files, separating the classes, and so on.

I came up with the wild hack many years ago, at that time there were no frameworks to get local files into the Go Binary.
Packr has already been recommended to me. It would be a lot of effort to implement this in xTeVe (Maybe if I have a lot of time)
If you change this line, the local files are used:
xteve.go (Line 51)
const Dev = false

The file webUI.go is regenerated with every start to have changes in the later go binary.
The JS files are generated from the Type Script files (TS) with the script compileJS.sh.
Yes you are right, menu_ts.ts has grown a bit :)

Well it's nicer than I expected, I thought you manually generated the webUI.go file :P altought it sounded weird.  I already saw the compileJS.sh thing for compiling the typescript files but thanks for the info :)
This came up cause I wanted to do what I initially thought was an small change to the web UI,... but then I saw that it wasn't as simple change as I expected specially the way the web interface it's build.
That extra info will be helpful for that.
Feel free to close this or leave it open in case at some point you have a lot of time.


Limit the User.Read.All permission to certain attributes instead of all attributes.

[Enter feedback here]
The API permissions(Application Type) User.Read.All allows the application to read all the user's attributes from the portal. Is there any way we can restrict the access and allow very limited attributes such as Firstname, Lastname, email and object Id to be accessible using an API permission.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e056c00-a2a1-7019-fb36-0243819a7b99
Version Independent ID: a7a0b942-5e83-6e60-c9e8-32e0225de250
Content: Microsoft identity platform scopes, permissions, & consent
Content Source: articles/active-directory/develop/v2-permissions-and-consent.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@debashishgouda22 Thank you for your query . We will review this and update the thread.

@debashishgouda22 Currently this is not possible. You cannot customize the API with custom permission set with attribute level granularity on user accounts . This is not possible at the moment . You can upvote a similar ask about custom roles on the Feedback site https://feedback.azure.com/d365community/idea/d4c0186f-c725-ec11-b6e6-000d3a4f0789 if creating a custom directory role and assigning it to your app will help. However if you would like the ability to customize the API itself then I would suggest you to create a new Idea or the product group to review and update accordingly .
Thank you

Has this changed? We also need to restrict reading all attributes.
br: Meea


update vtk dependencies

Since pcl on noetic runs also with vtk7 we should change the default here to vtk7

I might not be the best person to review this, since I don't have enough context about PCL or VTK, but to push this along, I see that libvtk7* exists for bionic, but is that staying at 6 because PCL on Melodic runs on vtk6?
@jacobperron is there anything else that needs to be done when the default is changed? I'm not seeing extra things to be done as far as the REVIEW_GUIDELINES and CONTRIBUTING guides go.

but is that staying at 6 because PCL on Melodic runs on vtk6?

Yes, that's the reason. VTK6 and VTK7 can not be installed at the same time.

To second reviewer: I'm ready to approve if there's nothing else in the process I have to be aware of.

Like it is now, it breaks installations. vtk6 and vtk7 are not side by side installable due to the vtk-java installation. E.g. installing lvr2 and pcl worked in melodic. Now in noetic it does not.

Like it is now, it breaks installations. vtk6 and vtk7 are not side by side installable due to the vtk-java installation. E.g. installing lvr2 and pcl worked in melodic. Now in noetic it does not.

I'm misunderstanding something. I can successfully install both lvr2 and pcl (and pcl_ros) on Noetic:
sudo apt install ros-noetic-lvr2 libpcl-dev ros-noetic-pcl-ros

However, it's true that we can't install libvtk6-java since it is not available on focal. We should certainly update the rule for libvtk-java for focal (as done in this PR).
For the other rosdep keys, I think we shouldn't make the change to vtk7. If a key for vtk7 is desired, we could consider adding a new key (e.g. libvtk7).
Does that makes sense?

@tfoote Thank you for reviewing this PR and all bundled information. What is the change you are requesting here? I can't read it between the lines.

@tfoote Thank you for reviewing this PR and all bundled information. What is the change you are requesting here? I can't read it between the lines.

@tfoote Thank you for reviewing this PR and all bundled information. What is the change you are requesting here? I can't read it between the lines.

@spuetz I think @tfoote is requesting the libvtk* rosdep rules for Debian Buster to be changed to libvtk7-dev instead of libvtk6-dev to match the change in Ubuntu Focal.
https://github.com/ros/rosdistro/blob/0ed124c2d547c16ffab4d0fa52c992ad6dddb67f/rosdep/base.yaml#L4500-L4506
https://github.com/ros/rosdistro/blob/0ed124c2d547c16ffab4d0fa52c992ad6dddb67f/rosdep/base.yaml#L4531-L4537
https://github.com/ros/rosdistro/blob/0ed124c2d547c16ffab4d0fa52c992ad6dddb67f/rosdep/base.yaml#L4559-L4565

@tfoote Thank you for reviewing this PR and all bundled information. What is the change you are requesting here? I can't read it between the lines.

@spuetz I think @tfoote is requesting the libvtk* rosdep rules for Debian Buster to be changed to libvtk7-dev instead of libvtk6-dev to match the change in Ubuntu Focal.
https://github.com/ros/rosdistro/blob/0ed124c2d547c16ffab4d0fa52c992ad6dddb67f/rosdep/base.yaml#L4500-L4506
https://github.com/ros/rosdistro/blob/0ed124c2d547c16ffab4d0fa52c992ad6dddb67f/rosdep/base.yaml#L4531-L4537
https://github.com/ros/rosdistro/blob/0ed124c2d547c16ffab4d0fa52c992ad6dddb67f/rosdep/base.yaml#L4559-L4565

@spuetz Friendly ping. Can you update the rules for buster as well? Thanks!


Fix readfile() returns any, not list

readfile() returns any, but I think it should return list<string>.

Right, it can return a Blob, the type specifies the common type, which is "any".  The result is that the type needs to be checked at runtime.  The {type} argument can be a variable, thus we can't always detect what it contains at compile time.  Checking for a constant is making it too complicated.

OK, thank you.


Prometheus 2.0 - task fails "copy prometheus main config file from role's default, if necessary"

With prometheus 2.0 the options for promtool changed. Previously it was "check-config" now it is "check config" (space instead of collon). Same with "check-rules", which is now "check rules".
Therefore the task "copy prometheus main config file from role's default, if necessary" (if you use the default config and the analoguous step for non-default config failes.

thanks for that I was getting the same error, unfortunately it looks as though this role in not being actively maintained.

We have active maintained the ansible roles with support Prometheus 2.0 (release 0.6.1 support both 1.x.x and 2.0 version)
Right now this role is in early development and if you have any ideas what can be done there, we'll gladly hear them.
We would also like to add the role to Prometheus documentation (issue #3505)

did you try https://github.com/William-Yeh/ansible-prometheus/pull/57 ?

I fixed the problem by replacing the command "./promtool check-config" with the new syntax "./promtool check config" and respectively "check-rules" to "check rules".


Is this the server code?

Can I start this and connect locally or is this just client code?

Doesn't matter

For the record, Fleck is websocket server code.


Add products to research and modify result style

TODO :

html redirection for product (see if works for load more ...)
maybe hide product search at the moment or add some real products or make a demo country


Appstudio update test-component-pac-zusx

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-zusx-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
16 seconds
init

✅ Succeeded
47 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
29 seconds
sast-snyk-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
8 seconds
inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
25 seconds
sbom-json-check

✅ Succeeded
9 seconds
deprecated-base-image-check

✅ Succeeded
10 seconds
show-summary

✅ Succeeded
7 seconds
show-sbom

Pipelines as Code CI/test-component-pac-zusx-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
11 seconds
init

✅ Succeeded
34 seconds
clone-repository

✅ Succeeded
15 seconds
sast-snyk-check

✅ Succeeded
1 minute
build-container

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
11 seconds
inspect-image

✅ Succeeded
11 seconds
clair-scan

✅ Succeeded
11 seconds
deprecated-base-image-check

✅ Succeeded
52 seconds
clamav-scan

✅ Succeeded
9 seconds
show-summary

✅ Succeeded
8 seconds
show-sbom


Using Embedded Binaries giving build failed error in xcode 7 ?

I am using the framework for iOS 8 using swift 2.0 in Xcode 7 beta 4 but when in add Charts.framework in Embedded Binaries and build then it gives me build failed dialogue without prompting to any error window.

You need to update Xcode. In the beta versions of Xcode the language has change quite a bit version to version. Currently I believe that the library will work with beta 6 and gm.


Set an explicit order for "Run and Debug".

This allows extensions to register content to go right after this button by also specifying order 1. 1 was chosen because we want this to be the first piece of content in the debug view.
Addresses #172009.

Sorry about the assignment/reassignment. Looking at this myself as a part of https://github.com/microsoft/vscode/issues/172009

Hi Bhavya, does this change make sense to you? Do you need me to change anything?

It seems I lost approval when updating the branch? Can someone approve and merge before it gets out of date again?

@connor4312, can you reapprove as I updated to head? If possible, can you merge right away to avoid it getting out of sync again?

ping @roblourens

It does not move before the "Open file" link above because that is in a different group and the order is only within a group (groups themselves also have an ordering). It does not move after the other buttons because when order is not set, it defaults to order 5, which is after the order 1 that I set here explicitly.
Thanks for the approval and merging!


[dartpad_ui] Add splash screen

Added a simple splash screen so that when you open dartpad.dev you don't have to look at a white screen. 🙂
Implemented with mobile devices and theme change in mind.

Mobile Demo
https://github.com/user-attachments/assets/51df3198-c82e-4af7-9d49-9ff105914efc

Desktop Demo
https://github.com/user-attachments/assets/57b9a51c-d3ac-4d03-8547-cddfc5322718

[x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew Hi! I'm sorry if I'm tagging you. But could you please tell me how I should deal with this PR?

Thanks for the contribution! I like that you've moved the index.html styles into a new file - I think that helps with readability.
Wrt the white flash at startup, I do see it now myself; I expect that it's noticeable when using the dark theme. We probably don't need the dart icon as part of the splash screen, and, we may want to make the exit animation for the splash screen shorter as it would otherwise delay visibility by a 1/2 sec.
You may generally want to start with an issue instead of a PR for feature contributions - it would help save you time if we decide against the feature in general. But I'm probably not the right reviewer; I'll bump you over to @johnpryan and @parlough.

You're right, I was a bit rushed with the PR though. I'll start with issues next time.
These changes didn't take me long to make, so I could redo them if needed.


doc(README): add shriramcs as a contributor

Fixes #
Screenshot: (if applicable):
Description of the change:

aborting PR to create new one.


Diagnosing ADO.NET with ETW traces - logman query providers command fails

Your wordpress web blog Diagnosing ADO.NET with ETW traces says to use the following command to check one of the providers: logman query providers '{914ABDE2-171E-C600-3348-C514171DE148}', but when I try that I get
Error:
Element not found.

If I execute it without the quotes, it works.  Note that I am one Windows 10 Version 22H2.

I'm using PowerShell in the blog post (notice PS> prompt) and you need to add apostrophes to make this command work. As you noticed, they are not required in cmd.exe.

I did not realize, partially because it says PS reader> and partially because I don't use PowerShell often. To much overhead and it changes or complicates the commands I'm used to.

Do you have any thoughts as to why I can't get it to work?  The last comment on that page is mine. I was finally able to post one.

Try running process monitor and verify that the BidInterface registry key is getting accessed and the DLL is loaded into the .NET process.

OMFG. I could swear I tested this with a non-environment variable path, but today ProcMon showed me that it didn't understand it. I even used ProcMon before.
Perhaps I changed it after the app was running and it somehow cached the previous version..
I was simply doing what the MS article says. https://learn.microsoft.com/en-us/previous-versions/sql/sql-server-2008/cc765421(v=sql.100)#:~#:text=ADO.NET 2.0-,Value%3D"%25SYSTEMROOT%25
The download, still available for SQL 2012, has the same setup. Ugh.
It would be great if you could mention this.
Note that I will test this again. Also, the PerfView tool is great for this, if setup correctly...


Support iwyu and clang-tidy

Add support for clang-tidy 1 and iwyu 2 tools.
Overview
These tools allow to statically find potential programming issues and include
issues, respectively. They are able to find a lot of potential issues (both bugs
or style problems), so they are a useful addition for contributors. For now, no
specific configuration is included but it is possible to give a style file which
would control what we consider to be errors and what are not.
The use of the tools is controlled through the respective GINKGO_WITH_CLANG_TIDY
and GINKGO_WITH_IWYU variables. They are turned off by default, but their
availability is highlighted in the main README.md
Here is an example of what these tools bring in terms of analysis. Looking at what is outputted here, there are actual problems (such as not including memory header).
clang-tidy output for coo_kernels.cpp
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:95:53: warning: parameter 'exec' is unused [misc-unused-parameters]
void spmv2(std::shared_ptr<const ReferenceExecutor> exec,
                                                    ^~~~~
                                                     /*exec*/
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:95:53: warning: the parameter 'exec' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:105:19: warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
            c->at(coo_row[i], j) += coo_val[i] * b->at(coo_col[i], j);
                  ^
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:105:37: warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
            c->at(coo_row[i], j) += coo_val[i] * b->at(coo_col[i], j);
                                    ^
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:105:56: warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
            c->at(coo_row[i], j) += coo_val[i] * b->at(coo_col[i], j);
                                                       ^
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:114:62: warning: parameter 'exec' is unused [misc-unused-parameters]
void advanced_spmv2(std::shared_ptr<const ReferenceExecutor> exec,
                                                             ^~~~~
                                                              /*exec*/
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:114:62: warning: the parameter 'exec' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:127:19: warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
            c->at(coo_row[i], j) +=
                  ^
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:128:29: warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
                alpha_val * coo_val[i] * b->at(coo_col[i], j);
                            ^
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:128:48: warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
                alpha_val * coo_val[i] * b->at(coo_col[i], j);
                                               ^
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:138:72: warning: parameter 'exec' is unused [misc-unused-parameters]
void convert_row_idxs_to_ptrs(std::shared_ptr<const ReferenceExecutor> exec,
                                                                       ^~~~~
                                                                        /*exec*/
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:138:72: warning: the parameter 'exec' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void convert_row_idxs_to_ptrs(std::shared_ptr<const ReferenceExecutor> exec,
                              ~~~                                      ^
                              const                                   &
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:167:64: warning: parameter 'exec' is unused [misc-unused-parameters]
void convert_to_dense(std::shared_ptr<const ReferenceExecutor> exec,
                                                               ^~~~~
                                                                /*exec*/
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:167:64: warning: the parameter 'exec' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:182:20: warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
        result->at(coo_row[i], coo_col[i]) += coo_val[i];
                   ^
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:182:32: warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
        result->at(coo_row[i], coo_col[i]) += coo_val[i];
                               ^
/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:182:47: warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
        result->at(coo_row[i], coo_col[i]) += coo_val[i];

Include What You Use output with coo_kernels.cpp
Warning: include-what-you-use reported diagnostics:

/home/tcojean/Workspace/software/ginkgo-github/core/matrix/coo_kernels.hpp should add these lines:
#include <memory>                         // for shared_ptr
#include "ginkgo/core/base/executor.hpp"  // for DefaultExecutor

/home/tcojean/Workspace/software/ginkgo-github/core/matrix/coo_kernels.hpp should remove these lines:
- #include <ginkgo/core/base/types.hpp>  // lines 37-37
- #include <ginkgo/core/matrix/coo.hpp>  // lines 38-38
- #include <ginkgo/core/matrix/csr.hpp>  // lines 39-39

The full include-list for /home/tcojean/Workspace/software/ginkgo-github/core/matrix/coo_kernels.hpp:
#include <ginkgo/core/matrix/dense.hpp>   // for Dense, Coo, Csr
#include <memory>                         // for shared_ptr
#include "ginkgo/core/base/executor.hpp"  // for DefaultExecutor
---

/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp should add these lines:
#include "ginkgo/core/base/types.hpp"                  // for size_type, GKO...

/home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp should remove these lines:
- #include <ginkgo/core/base/exception_helpers.hpp>  // lines 36-36
- #include <ginkgo/core/base/math.hpp>  // lines 37-37
- #include <ginkgo/core/matrix/csr.hpp>  // lines 38-38

The full include-list for /home/tcojean/Workspace/software/ginkgo-github/reference/matrix/coo_kernels.cpp:
#include "core/matrix/coo_kernels.hpp"
#include <ginkgo/core/matrix/dense.hpp>                // for Dense, Coo, Csr
#include "ginkgo/core/base/types.hpp"                  // for size_type, GKO...
#include "reference/components/format_conversion.hpp"  // for convert_idxs_t...
---

Very useful tools. However, when I enable both on my system, it stops compiling and I get the following error:
/home/thomas/projects/ginkgo_github_2/omp/matrix/coo_kernels.cpp:36:10: error: 'omp.h' file not found **[clang-diagnostic-error]**

It seems like it does not find the omp.h file, and then just cancels the compilation.
I did this with a complete new cmake and make.

I tested it without the iwyu, and it still crashed with the same error, so the clang-tidy does not work properly on my system. Is there a way to forward the OpenMP information to clang-tidy, or to tell clang-tidy to ignore this header file?

Testing it with iwyu only works on my system, so it definitively looks like clang-tidy is the problem for me.
On a different topic: Is there a way for this to be run on the CI system? I think it would be very useful information when doing code review.

The behavior you have with clang-tidy is weird, by default I believe everything is treated as a warning. I will try to see whether I can reproduce this and if there is a way around this.

I have clang version clang 8.0.0-4 if that helps.

Did you install the openmp package? Maybe the problem is that you do not have OpenMP support with clang? In my case, I do not get this error.

Do I have to install an OpenMP package on Arch linux? I thought it always comes with the compiler.
I at least did not do that. Unfortunately, I cannot test that right now since it happened on my work laptop, which I did not bring with me. I am testing right now what happens on my Ubuntu.

Apparently, there is an openmp package for Arch that I did not know about, which is an optional requirement for clang...
That might actually be the problem, since I am pretty sure I did not install it myself. It works fine on my Ubuntu.
The remaining question I have is: Should we make this a step in the CI system for easier code review, or would that be too much?

I will add this to the CI system, I'm not sure how much it will help currently though as there is a lot of problems so it's hard to see if there is any new error or not.

I guess we would definitively have to search for the file that was edited, but I think that we can fix these issues for the future PRs one after the other.

The CI system apparently has a similar problem to my Arch Linux (does not find a particular header file):
/usr/lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/cxxabi_init_exception.h:38:10: fatal error: 'stddef.h' file not found

Taken from the CI output.

The problem is actually with iwyu though, clang-tidy worked fine. That is surprising at first I thought it would be the opposite due to the clang-version being low.

Looks like this is a known issue with iwyu. Depending how well the maintainers do the packaging, it may not properly find standard headers.
https://github.com/include-what-you-use/include-what-you-use/issues/679
I'll try to get around this.

Even in the clang-tidy step there seem to be similar errors.

You're both right. It did not fail for some reason so I thought all was well there.

@pratikvn is correct. There are multiple 'stddef.h' file not found [clang-diagnostic-error] errors, however, they do not lead to a compile termination (probably since they are in system header instead of in the project headers).
Examples for the errors:
/usr/lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/cxxabi_init_exception.h:38:10: error: 'stddef.h' file not found [clang-diagnostic-error]
/usr/include/limits.h:123:16: error: 'limits.h' file not found [clang-diagnostic-error]
/usr/include/wchar.h:39:11: error: 'stdarg.h' file not found [clang-diagnostic-error]

Taken from this CI output
It seems to be limited to stddef.h, stdarg.h and limits.h.

This is now fixed.


Added support for passing _GET variables upon login

Hello again. I'm still developing my project wich I've uploaded to GitHub (in case you wanted to check it out if you were interested. And don't worry, I'll credit you when it's done :P). This time I needed to pass variables to be retrieved after the user logs in, and the framework currently didn't have support for that. So, I've added it, and I've uploaded it to my fork, in case you wanted to consider merging it. Here's how it works.
The steamlogin() function works as usual. The only change is that you now have to put echo before calling it: the function itself won't echo the button anymore, you have to manually do it. Why? Felxibility. Sometimes you don't need the button to be echoed immediatly, but stored it in a variable to maybe pass it as a parameter to a method. For example, in my script I pass the button as a parameter to the method Modal::__construct(). The class will create a Bootstrap Modal later, and include the button on it. If steamlogin() did echo instead of return I'd need to modify my entire class; this way is much more convenient.
So, any app that ran
steamlogin();

should now run
echo steamlogin();

And now, the most important change. If you want to pass variables to be returned after the login, you'd do the following:
echo steamlogin("foo=1&bar=2");

Notice that you don't have to put any ?s and &s at the beginning.
In that case, you can use $_GET['foo'] and $_GET['bar'] on your login page (set on the settings), and they will be set to 1 and 2, respectively. Assuming that your return URL is http://website.com/index.php, the user will be redirected to http://website.com/index.php?foo=1&bar=2 after loging in successfully on Steam.
One last change: the line session_start() at line 37 on the old file was removed because it's already called at the beginning, so I believe that there's no point on calling it again (In fact, it gives you a warning)
Thanks for your time, and have a nice day!

You can actually use http_build_query(array arguments) to build your parameter list, so you can just provide an array for $additional_parameters.

That's true, and more convenient. I didn't think about that. So the way of doing this would be, then:
$vars = http_build_query(array('var1' => 'foo', 'var2' => 'bar'));
echo steamlogin($vars);

Do that inside your function

Okay, I've changed it. I've also updated the example file and the readme with the changes.

One last thing, then were done: Its additional, not aditional.
Could you fix that please?

Sure thing. English is nor my first language, sorry.


MemoryStore not valid for production usage

Welcome!
I've recently gotten an opportunity to do first pet project in rust and decided on using axum which gives an example of using async-session:
    // `MemoryStore` is just used as an example. Don't use this in production.
    let store = MemoryStore::new();

https://github.com/tokio-rs/axum/blob/main/examples/oauth/src/main.rs#L42
The same warning is memory store itself
https://github.com/http-rs/async-session/blob/93a11ae4042df127cb2465ea46106d59fee7f699/src/memory_store.rs#L10
Is there a reason why this should not be used in production if losing all sessions on application crash acceptable behavior and application is not clustered? If there is I would love to add it in documentation in pointed places for others to understand.
Also many kudos for your work! :1st_place_medal:

The primary concern is that someone new to web stuff would use the memory store because it takes the least configuration, but then be confused when everyone gets logged out on server restart (or similar). If the cleanup task is run intermittently, you don't mind losing sessions on restart, and there aren't too many active sessions to fit in memory there is no reason the memory store would be a poor choice. Docs PRs clarifying that would be welcome as long as someone new to web sessions wouldn't accidentally deploy it and be surprised about those constraints.

I've written down my thoughts using some terms that someone new to web stuff should easily google like load balancing or ssl termination. Also I've duplicated some of the links from main README.md as it leaves someone with actionable alternatives.


Getting an unauthorized_client error

I've searched for anyone getting the same error, and haven't been able to find similar circumstances.
GYB works great for all the backup and restore functions I use it for, but when I
When I run:
./gyb --email<EMAIL_ADDRESS>--service-account --use-admin<EMAIL_ADDRESS>--action restore-group --local-folder testgroup/
I receive the error "Error: unauthorized_client: Client is unauthorized to retrieve access tokens using this method."
The<EMAIL_ADDRESS>is a working g-suite group
The<EMAIL_ADDRESS>is a superadmin, and the service account has had domain wide delegation activated, the scopes for the user are also enabled.
The folder has a fresh backup of the email account in question, but not an mbox, its a folder/sqlite backup from gyb, I have also enabled the API for groups migration, as well as attempting to go to the https://console.developers.google.com/apis/api/groupsmigration.googleapis.com/overview?project="project#" location, but thats not actually the URI for my GYB project.
Expected outcome :
Messages restored to the group<EMAIL_ADDRESS>group.

RTFM. Sorry. I have resolved this issue on my own. Turns out you cannot use GAM oauth2service.json files for ALL of the functions of GYB.

I am not sure..I have the same error
Error: unauthorized_client: Client is unauthorized to retrieve access tokens using this method, or client not authorized for any of the scopes requested.
which client_id string needs to be parsed to the admin console?
the one with only numbers in it or the longer one with googleusercontent.com at the end?

works, it is the shorter one containing only numbers

works, it is the shorter one containing only numbers

As mentioned in the API_SCOPE_MAPPING dict (https://github.com/jay0lee/got-your-back/blob/13c6d8438a4e44baba0c3d37a4450d1e8e8b0696/gyb.py#L1174-L1177), GYB requires these 4 OAuth scopes below:

https://mail.google.com/
https://www.googleapis.com/auth/apps.groups.migration
https://www.googleapis.com/auth/drive.appdata
https://www.googleapis.com/auth/userinfo.email

To re-use a GAM's Service Account file oauth2service.json, you would need to ensure that domain-wide delegation includes GYB-specific scopes above.
Additionally, since GAM attempts to refresh the Service Account key periodically, you should try to set a hard-link (and not copy) oauth2service.json file between GAM & GYB to make sure a refreshed key would be available to both CLI tools.


Deploy streamlit app to hugging face

Deploy streamlit app to hugging face

This was done and the first draft of the app is online.


VEIOSS-656 | Clear user answers for self exclusion/reversals journey

I'd maybe add a test for the repository clear functionality.


enhancement support jdbc scan, jdbc sink, odbc scan and odbc sink node for pipeline.

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.45 seconds
load time: 462 seconds
storage size:<PHONE_NUMBER>2 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221210122845_clickbench_pr_61358.html


Correction for raw affiliation CS Capital Srl (Formerly Prothea Srl), Via Alessandro Manzoni 41, 20121 Milano, Italy; Canadian Rivers Institute, 10 Bailey Drive, P.O. Box 4400, Fredericton, NB E3B 5A3, Canada

Correction needed for raw affiliation CS Capital Srl (Formerly Prothea Srl), Via Alessandro Manzoni 41, 20121 Milano, Italy; Canadian Rivers Institute, 10 Bailey Drive, P.O. Box 4400, Fredericton, NB E3B 5A3, Canada
raw_affiliation_name: CS Capital Srl (Formerly Prothea Srl), Via Alessandro Manzoni 41, 20121 Milano, Italy; Canadian Rivers Institute, 10 Bailey Drive, P.O. Box 4400, Fredericton, NB E3B 5A3, Canada
new_rors: 05nkf0n29
previous_rors:
works_examples: W3042577309;W4400316496
contact: 031c054e3db78d75bf259492f9ba4d7d:35c57df6 @ ourresearch.org

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Fix nanodet_head onnx export to enable batch processing

The existing ONNX export reshapes all inputs to a batch size 1.
This is a problem when batches with length >n are fed into the model.

@RangiLyu mind reviewing this?


Add blank space at the bottom of code

Is it possible to make blank space at the bottom of code (like in sublime text)? So I don't have to see the bottom of the screen when i'm writing.

See Scroll Past End setting in Settings.
It allows the editor to be scrolled  past the end of the last line.

Thanks @albertosantini!

thank you :+1: @albertosantini

Thx @albertosantini


when front page is set ...url for tags and categories redirect to the same front page

when front page is set ...url for tags and categories redirect to the same front page

This issue does not make any sense since there are no categories and tags on a page set as front page


Fixing ndimage.watershed_ift tutorial's documentation

Hi,
I noticed a mistake on the ndimage.watershed_ift tutorial's documentation (Iterative Forest Transform ->  Image Foresting Transform) and I also updated the reference to the journal version of the article to match the function documentation.
Thanks in advance,
Reference issue
This is related to a very old PR #4496, that fixed only part of the documentation.
What does this implement/fix?
No implementation, it is only a documentation update.

I will let the CI run before merging as I am not sure about the tilde.

Failure is unrelated (again the timeout).


Updated Michael Baumli on Summer 2020 Big-Data-Developers ReadMe.MD

Updated Michael Baumli on Summer 2020 Big-Data-Developers ReadMe.MD

Updated Michael Baumli on Summer 2020 Big-Data-Developers ReadMe.MD


Refs #35361 -- Added test for Email line length checks when dealing with surrogate pairs.

Trac ticket number
ticket-35361
Branch description
This branch provides a test to cover for the fix added in b231bcd19e57267ce1fc21d42d46f0b65fdcfcf8 which needs backporting to 4.2 and 5.0 versions due to Python backporting the fix for this issue to 3.11 and 3.12:
Checklist

[X] This PR targets the main branch.
[X] The commit message is written in past tense, mentions the ticket number, and ends with a period.
[X] I have checked the "Has patch" ticket flag in the Trac system.
[X] I have added or updated relevant tests.
[X] I have added or updated relevant docs, including release notes if applicable.
[X] For UI changes, I have attached screenshots in both light and dark modes.

ToDo:

consider adding release notes for 5.0 and 4.2 for the soon to happen backports
refs the Python 3.11, 3.12 and 3.13 tickets? Those are ticket-33173, ticket-34118 and ticket-34900

consider adding release notes for 5.0 and 4.2 for the soon to happen backports

Yes, release notes are required.

refs the Python 3.11, 3.12 and 3.13 tickets?

I'd refer to the ticket-35361.


Cask request: Anaconda 4.3

Cask details
Please fill out as much as possible. Before you do, note we cannot support Mac App Store-only apps.
Name: Anaconda
Homepage: https://www.continuum.io/
Download URL: https://repo.continuum.io/archive/Anaconda3-4.3.0-MacOSX-x86_64.sh
Description: new version for anaconda, current version of anaconda on brew cask is outdated.

why is it requiring password to install anaconda? it shouldn't require sudo isn't it?
Password:


DEN calculation is extremly slow

(the cherry-picking SIMPLE in label-fusion-ng is a need of essentially the same task, and also efficient implementation)
C3DH-H157/01, 54 frames... took cca 11 hours! Check the code -- wasn't that bad previously (ScoreAnnotatedVideos src code).
Would it be possible to calculate it in one shot, i.e. for all objects at the same time? The DT-like iterations would be progressing only on empty background plus updating only own data. There would have to be extra map-image to tell whom the DT non-zero values belong to. If we run into values of somebody else, the distance is likely to be the sum of mine and his values (but wait for round to finish to see everything updated).

Original issue: https://github.com/CellTrackingChallenge/CTC-FijiPlugins/issues/7

this has been finally solved with commit 43b4d5c8bb4ce40
it detect surface voxels, coarsely finds nearest side where it re-searches accurately
despite, however, the used regime of the provided implementation is rather a "empirically proven" one and can make an error:

it internally uses lists for surface points, when close to one end of the list the system does not switch to the other end of the list (it doesn't work as a circular buffer, but it should....)
when the shape of the measures objects is highly irregular, the coarse search may end up in a wrong side of the object, and will not discover the true shortest distance


NetStandard20 Support (Experimental / Discussion Starter - Do Not Merge)

This was an initial attempt to add support for .net standard 2.0, so that a mac client can be developed. I started to create a mac client then saw the libraries were not supported. I saw your recent comments on other issues so decided to have a quick look at this.
The first contention point is the location for the submodule. As per the recent commits the .net standard changes were pushed and then removed from the main repo. See https://github.com/barrett777/Heroes.ReplayParser/commits/master� . I propose that you update your ReplayParser repo, and create a branch like "NetStandard20" that points to
@koliva8245 's latest commits on his fork. Then we can point the NetStandard20 branch of the uploader to that submodule branch so that development can continue while something is done about NetStandard 2.0 support in the replay library. Right now I changed the submodule to point to koliva8245's fork to get this to work, but it should be to a fork / branch under your ( @poma ) control, hence the do not merge.
Second, Nito.AsyncEx has only recently added .net standard 2.0 support, and as such we need to use the beta version of the library for now.
Third, NLog's commit for .net standard 2.0 support occurred 8 days ago, and not put an update to nuget. This causes a warning in the project, but continues to work as it uses the .net Framework 4.6 library ( and should not be an issue on Mac, but I can find that out soon enough).
I tested this locally using duplicate replays and it worked as expected. I will use this as a starting point to see the difficulty in creating a mac version, which I will play with over the next couple of days.

Updated to use the version of NLog that supports .net standard 2.0 (4.5 beta).
Side note: It looks like NLog is not supported with "Xamarin.Mac,Version=v2.0", so we would need to either (a) add Xamarin.Mac support to NLog (something I do not feel like doing), or (b) change logger for a Mac client :( .

Closing as it is already implemented


Support for Overlay

It would be nice to have a Overlay implementation, so a JTranscNativeName annotated class could also have some implementations visible only to java.
For classes, the non native and non abstract (static or instance) methods could be considered as Overlay methods. It would be nice to support overlay methods in pure java or annotated with JTranscMethodBody.
For interfaces, the non native static and default (defenders) methods should be considered as Overlay methods. It would be nice to support overlay methods in pure java or annotated with JTranscMethodBody.
It is also a nice to have, to implement Overlay fields.

I think I'm going to implement this as an integrated plugin so it will work for all targets, and not required extra work for any target.
The idea is to create a static class for static method and move there these methods and update all call-sites to those methods.
In the case of fields. I think it could work out of the box on JS since you can add fields. But definitely won't work on other targets.


PD-Timeline

I noticed a few things with :

--pd-timeline-width: default should probably be auto instead of 300? This leads to the overflow as shown in the screenshot
Furthermore the Dot of the timeline is neither horizontally nor vertically aligned :) (minor)

i did set the --pd-timeline-width to auto and made some adjustments for a better alignment of the dot.


Remove starred-symbolic.svg file from root directory

The starred-symbolic.svg file used by Sugarizer OS must not be at the root of the repository

Fixed in https://github.com/llaske/sugarizer/commit/d8077c03fb38e179d1799ed64ade25d7941b1ff9


[FEATURE] Display a message to the user when the link is copied to clipboard

Description
In the share feature when the user selects to copy the link to clipboard . It should notify the user that the link is copied.
Screenshots
No response
Additional information
No response

@avneesh maybe you should have a look at that :eyes:

It does in development but there’s an issue with copy to clipboard in production because the site is not on https which stops the copy api from working. It was raised in an issue the other day.

I’ll close this as a duplicate of #946

I’ll close this as a duplicate of #946

Sure


Deprecate neutralConfiguration in Python

neutralConfiguration is now deprecated in Python too. To achieve this, I exposed it as _neutralConfiguration and then I created a neutralConfiguration property raising the warning.

Seems good to me. I will merge it.


Error extracting .PAC file

What do I need to do to make it work?

Hi there, can you share the PAC file you're trying to extract?


Outdated Version von vscode-restclient

Why is an outdated version of vscode-restclient is used instead referencing the current version. You could simply reference the depenency in the extension manifest with key extensionDependencies

There is a bug in vscode-restclien, and the integration has been enhanced.


[20.03] rescuetime: <IP_ADDRESS> -> <IP_ADDRESS>

Motivation for this change
rescuetime currently fails to build in 20.03 due to an incorrect hash. This change fixes that by (1) pointing to a particular version, rather than the most recent version, (2) updating the hashes.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Builds and runs on NixOS. Did not test function (requires account).


logging clean up: remove model from our gscv params that get logged by sklearn

right now it makes our logs very long, and prevents us from seeing the actually useful stuff we want to see
to do this, we'll have to remove model from our gscv params, since it's sklearn who's doing this logging.

finished.


[SPARK-6657] [PYSPARK] Fix doc warnings

Fixed the following warnings in make clean html under python/docs:
/Users/meng/src/spark/python/pyspark/mllib/evaluation.py:docstring of pyspark.mllib.evaluation.RankingMetrics.ndcgAt:3: ERROR: Unexpected indentation.
/Users/meng/src/spark/python/pyspark/mllib/evaluation.py:docstring of pyspark.mllib.evaluation.RankingMetrics.ndcgAt:4: WARNING: Block quote ends without a blank line; unexpected unindent.
/Users/meng/src/spark/python/pyspark/mllib/fpm.py:docstring of pyspark.mllib.fpm.FPGrowth.train:3: ERROR: Unexpected indentation.
/Users/meng/src/spark/python/pyspark/mllib/fpm.py:docstring of pyspark.mllib.fpm.FPGrowth.train:4: WARNING: Block quote ends without a blank line; unexpected unindent.
/Users/meng/src/spark/python/pyspark/sql/__init__.py:docstring of pyspark.sql.DataFrame.replace:16: WARNING: Field list ends without a blank line; unexpected unindent.
/Users/meng/src/spark/python/pyspark/streaming/kafka.py:docstring of pyspark.streaming.kafka.KafkaUtils.createRDD:8: ERROR: Unexpected indentation.
/Users/meng/src/spark/python/pyspark/streaming/kafka.py:docstring of pyspark.streaming.kafka.KafkaUtils.createRDD:9: WARNING: Block quote ends without a blank line; unexpected unindent.

@davies

Merged build triggered.

Merged build started.

Test build #32948 has started for   PR 6221 at commit 606f9fa.

Test build #32948 has finished for   PR 6221 at commit 606f9fa.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32948/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #32950 has started for   PR 6221 at commit e3f83fe.

test this please

Merged build triggered.

Merged build started.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32965/
Test FAILed.

Merged build finished. Test FAILed.

test this please

Merged build triggered.

Merged build started.

Test build #32972 has started for   PR 6221 at commit e3f83fe.

Test build #32972 has finished for   PR 6221 at commit e3f83fe.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class JavaOneVsRestExample
      head("OneVsRest Example: multiclass to binary reduction using OneVsRest")
class DataTypeSingleton(type):
class NullType(DataType):
class AtomicType(DataType):
class NumericType(AtomicType):
class IntegralType(NumericType):
class FractionalType(NumericType):
class StringType(AtomicType):
class BinaryType(AtomicType):
class BooleanType(AtomicType):
class DateType(AtomicType):
class TimestampType(AtomicType):
class DecimalType(FractionalType):
class DoubleType(FractionalType):
class FloatType(FractionalType):
class ByteType(IntegralType):
class IntegerType(IntegralType):
class LongType(IntegralType):
class ShortType(IntegralType):
class Column(object):
class GroupedData(object):

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32972/
Test PASSed.

Merged build finished. Test PASSed.

Merged into master and branch-1.4.


[BUG] simple question on --model_type option

Describe the bug
In README under monomer folding, it says to use the following commmand (for example)
alphafold \
  --model_type = monomer \
  monomer.fasta

however, when looking at the following error log, monomer option doesn't seem to exist anymore.
absl.flags._exceptions.IllegalFlagValueError: flag --model_type=monomer: value should be one of <normal|ptm|multimer|casp14>

Bug on which cluster?
cluster3
Bug on which software versions?
This repository

Related software

Additional context

not really a huge issue (i just used the normal option instead)
but just issued this bug for others just in case..!

It's not actually a bug but a problem in the documentation. Thanks for the report!


Fix Vision Error Handling

Update ApiError to use the error format returned by the Vision service.
Add the missing check and raise and error when the API call is not successful.

Makes sense to me. Merging!


Fix 201420: 3.0.0: Button: Doesn't show proper hover

Add high contrast styles to button for proper hover color of text and border.

Approved 👍

Approve


ISPN-12250 Add exponential back-off for cross-site network failures

https://issues.redhat.com/browse/ISPN-12250

I'm disabling the exponential back-off for AsyncTimeBasedOfflineTest. It may cause delays.

Integrated into master, thanks @pruivo !


Missing of Favicons to the below pages

@khushi-joshi-05

please assign me this issue @sunny0625


Docs: Improve description on volume removal

A comment in https://github.com/docker/docker/issues/6354#issuecomment-74160215 brought to light that the "Managing Data in containers" section contained an incorrect (or confusing) line;
"Volumes persist until no containers use them"
Which implies that volumes are automatically removed if they are no longer referenced by a container.
This pull-request attempts to add some information explaining that volumes are never automatically removed by Docker and adds some extra hints on working with data volumes.
Thanks to @soupdiver for pointing this out.

NOTE: this does not resolve #6354 (just mentioning an issue in the PR shouldn't automatically close it, right?)

yup, LGTM - @fredlf @jamtur01

Are your comments addressed @SvenDowideit ?

@SvenDowideit @jamtur01 @fredlf
I updated the PR, and changed;
"Docker will therefore never automatically delete volumes if you delete a container,"
to this;
"Docker will therefore never automatically delete volumes when you remove a container,"
It's more 'lengthy', than the sentence you suggested, but I wanted to keep  the "therefore", "never" and "automatically" in there to take away any uncertainty about "why" and "what" docker will do.
If you still want me to go for the shorter version, or think my version isn't clear, let me know, then I'm happy to change it.

A couple of copy-edits, and a question. But otherwise LGTM. Thanks for this.
Not sure why tests are failing, however.

I think I forgot to rebase, was in a hurry preparing for work this morning. Apparently, docs-only PRs also trigger a complete build of docker, not sure if that is really needed?

I'm happy :) @cpuguy83 what do you think? i you're happy with the informational please merge, and we can update as things change :)

Added my nit... little more than a nit.

I rebased and replaced "orphaned" with "dangling". I personally think "orphaned" is easier to explain to people, but I agree that we should be consistent.
@SvenDowideit @fredlf I think it's good to merge now, we can always add more info in future.


'az monitor metrics list' doesn't accept multiple metrics names.

00:07 $ az monitor metrics list --resource /subscriptions/00977cdb-163f-435f-9c32-39ec8ae61f4d/resourceGroups/troy-permanent/providers/Microsoft.Storage/storageAccounts/trdaitest01 --time-grain PT1M --start-time 2017-10-17T07:58:00Z --end-time 2017-10-17T08:16:00Z --metric-names Egress Ingress
Overriding dimensionName AccountResourceId already in the query
Traceback (most recent call last):
  File "/home/troydai/code/azure-cli/src/azure-cli/azure/cli/main.py", line 36, in main
    cmd_result = APPLICATION.execute(args)
  File "/home/troydai/code/azure-cli/src/azure-cli-core/azure/cli/core/application.py", line 212, in execute
    result = expanded_arg.func(params)
  File "/home/troydai/code/azure-cli/src/azure-cli-core/azure/cli/core/commands/__init__.py", line 377, in __call__
    return self.handler(*args, **kwargs)
  File "/home/troydai/code/azure-cli/src/azure-cli-core/azure/cli/core/commands/__init__.py", line 630, in _execute_command
    raise client_exception
  File "/home/troydai/code/azure-cli/src/azure-cli-core/azure/cli/core/commands/__init__.py", line 618, in _execute_command
    exception_handler(ex)
  File "/home/troydai/code/azure-cli/src/command_modules/azure-cli-monitor/azure/cli/command_modules/monitor/_exception_handler.py", line 18, in monitor_exception_handler
    reraise(*sys.exc_info())
  File "/home/troydai/code/azure-cli/env/lib/python3.5/site-packages/six.py", line 693, in reraise
    raise value
  File "/home/troydai/code/azure-cli/src/azure-cli-core/azure/cli/core/commands/__init__.py", line 602, in _execute_command
    result = op(client, **kwargs) if client else op(**kwargs)
  File "/home/troydai/code/azure-cli/src/command_modules/azure-cli-monitor/azure/cli/command_modules/monitor/custom.py", line 176, in list_metrics
    return list(metrics)
  File "/home/troydai/code/azure-cli/env/lib/python3.5/site-packages/msrest/paging.py", line 109, in __next__
    self.advance_page()
  File "/home/troydai/code/azure-cli/env/lib/python3.5/site-packages/msrest/paging.py", line 95, in advance_page
    self._response = self._get_next(self.next_link)
  File "/home/troydai/code/azure-cli/env/lib/python3.5/site-packages/azure/monitor/operations/metrics_operations.py", line 110, in internal_paging
    raise models.ErrorResponseException(self._deserialize, response)
azure.monitor.models.error_response.ErrorResponseException: Overriding dimensionName AccountResourceId already in the query

Hi,
I think that's not a problem with the CLI but with the monitoring API (which I suppose that the CLI is using), because I'm getting the same error using the Java SDK.

@javimb, thank you for confirming this. We're in contact with monitoring team trying to address this issue. I will leave this issue open till the problem is fixed.

Getting the same error when using the LB api.
az monitor metrics list --resource {resource} --metric-names ByteCount DipAvailability PacketCount SnatConnectionCount VipAvailability --time-grain PT1M --start-time {date}

Moving forward the metrics list command will only accept one metric.

Fixed in https://github.com/Azure/azure-cli/pull/4974

So now 2017-05-01-preview api version accepts only one metric?

Yes.


How test autoform git branch package?

When clone autoform repo on test App local "package" folder always got error:
(STDERR) ReferenceError: Template is not defined
W20150528-23:41:37.665(2)? (STDERR)     at app/package/meteor-autoform/templates/bootstrap3-horizontal/components/afArrayField/afArrayField.js:1:36

How test autoform git branch??

Weird, is that in the server console? AutoForm is a client package and it should not be attempting to run that file on the server. I can't help much more unless you can provide specific reproduction steps starting from a new blank app.

Hello Eric.
Here we go, a test repo: https://github.com/bySabi/autoform-test

Is a bug!!!
In my eyes. I clone autoform on package than packages.
Work fine.
sorry for that :-(


[Minor] Incorrect repository headline

Currently, the repository headline is as follows "Transparency and Consent Framework Consent String SDK Javascript". This obviously can confuse somebody, because https://stackoverflow.com/a/245068. 😜

Looks like this was fixed


[8.x] Added reason phrase getter to Response class

I am interfacing with a very legacy XML API in my application, which sends back error hints in the reasonPhrase field of a response - not super kosher, but it works, i guess.
This simply adds a getter to Illuminate\Http\Client\Response to get the reason phrase from the underlying PSR response.

Thanks for contributing to Laravel! ❤


Don't ping people when reviewers are already assigned

Reducing comment spam.

Thanks for submitting a PR! Maybe @karlhto can review this?


Improve c-site-footer styles

Refactors the site-footer component in various ways:

Replaces lots of component-specific styles with helper classes
Makes the HTML example more generic (i.e. not specific to tt.org)
Also removes the margin that's baked into has-notch--* so that it can be applied via a helper class (including in the site footer)

@ashley-hebler This of course will require HTML updates in texastribune. So your call whether you want to hold off merging this for a bit, or if you want to merge this but just not update the commit hash in texastribune's yarn.lock.

I love this.
Most of these are examples of me just carrying over styles from old world, but I like that you're giving us the push we need to further trim down repeated declarations and superfluous styles.

Good thinking on the has-notch changes, those margins are def not needed with our new helpers
c-site-footer__header can almost get away with all helpers if we didn't deviate from our letter-spacing scale. The widest the t-uppercase t-uppercase--extra-wide modifier goes is $font-letter-spacing-lg. In any case that's fine, but I know Art has mentioned kerning inconsistencies so maybe we can chat about that down the road.
I can't tell if the social icons look too close the words or they're fine and current state is just too spaced out.

I would indeed like to hold off for now. It's starting to be a bottle neck I know, but I can do all the HTML changes the moment need 4 speed is out. At that point I'll remove the local footer styles and add this to our incremental new world base. Just chippin' away at it ⛏

There might be some duplicate logic with some of those helpers now that I think about it so let me think on that. Not sure if we're ready to phase those in completely.

Sure thing, this can certainly hold! Thanks for the feedback. Merge whenever you feel ready.

So I did one more crazy thing. Do you hate it?
My thinking is: 99 percent of the time (so far), we're sizing icons by putting a t-size-* on the SVG's parent span. And that's great! But in the rare times where we need a really big/small icon (like in the footer here), it seems kinda silly to create an in-component class just for setting a font size that the icon can inherit. So to me, this feels like a scenario where an inline style actually makes sense.


Added samples and more test cases to file service and resolved some issues.

closes https://github.com/Azure/azure-sdk-for-cpp/issues/522

please hold this until https://github.com/Azure/azure-sdk-for-cpp/pull/536 is merged. You're going to rebase.


Documentation question

I was just getting acquainted with the documentation and in the getting started section I see this example:
layer.setStyle({pmIgnore: false});
// layer.options.pmIgnore = false; // If the layer is a LayerGroup / FeatureGroup / GeoJSON this line is needed too
L.PM.reInitLayer(layer);

Problem is, I don't know how layer is initialized. Could you please explain?

With pmIgnore you can define if a layer is available for Geoman. pmIgnore: false is only needed if you set L.PM.setOptIn(true);, because by default all layers are "hidden" for Geoman.
So you don't need to use this code by default

Hi and thanks for the reply. I was wondering how the layer object is created. What type of layer is it. As a newcomer, I find the multitude of layer Leaflet offer a bit confusing and I don't know what type of layer the object in the example is.


Fixed some bugs about host based repliation

What this PR does / why we need it:
Fixed some bugs about host based repliation
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

Coverage remained the same at 45.099% when pulling a66781cf9d1acb3ea8337613d78b6454c5ddefb5 on xxwjj:replication_bug into 84850e5da41966e92bf43d1ac422e0f4dc0db107 on opensds:development.


john's-branch-for-dbchatuser

just update few functions which now can access to the database

I don't think we're allowed to connect databases directly to the interactors in clean architecture. I think you need to connect your database in the appbuilder file by replacing "private final InMemoryUserDataAccessObject userDataAccessObject = new InMemoryUserDataAccessObject();" with your own database?


Create volumes asynchronously

Closes concourse/concourse#1368. Needs updated BaggageClaim. (concourse/baggageclaim#9)

With the recent changes in the implementation, all work is now done inside the BaggageClaim client, so this pull request is no longer necessary.


This code is what meaning, don't understand, trouble to help me explain.

(window.windowLevel >= UIWindowLevelNormal && window.windowLevel <= self.maxSupportedWindowLevel)

Sorry, I do not understand your question.

You help me explain what is the meaning of this code

This code iterates over all UI windows and checks if the current one in iteration has the right window level. If so, the hud is added to this windows.
Please check the UIWindowLevel for more documentation.

Thank you very much!


[BUG] Live Preview —  Can't select texte before a list

Describe the bug
Live Preview : For a strange reason, I can't select the first sentence after a bullet number (as 1, 2..). See Loom video for concize bug.
The note need to have a admonition in it.
To Reproduce

Create a admonition
Create a numbered list
Try to select the first sentence after the list number.

Log
/
Screenshots
https://www.loom.com/share/a7454ea56cee4b10992fa455bfe4f5c2
Desktop:

OS: Windows 11
Obsidian Version : v.0.13.23
Plugin version : 6.10.1

Additional context

[x] Live Preview
[x] I already disabled every other plugin and css snippet.

I'm sorry, I can't tell a difference between with and without in your video.


Fix builds by locking dependency to version before breaking change

Goal of this PR
Fixes #28
Also fixes two links that were broken previously:
WARNING  -  Documentation file 'flare/architecture.md' contains a link to 'flare/flare.md' which is not found in the documentation files.
WARNING  -  Documentation file 'flow/cadence.md' contains a link to 'flow/glossary.md' which is not found in the documentation files.

Merging this since no one seems to want to review it 😄


Complete DRAFT 'Information for transcribers' page and make live

There is a DRAFT 'Information for transcribers' page that looks to have some updates for CSVProc, but no note of the issue or issues it addresses.
The current (live) page has links to pages and files that are related to CEN1, but the updated info for coords page tells coords that their volunteers should not be using CEN1. So, we need to publish an updated Info for transcribers page.
Is the DRAFT page ready to be made ready for publishing? If not, what else needs addressing first?

@AlOneill to check and remove mentions of replaced processes.

@PatReynolds I've tidied up the the DRAFT Info for transcribers page. There are two outstanding issues:

the highlighted sentence is very awkward — it does not make sense to me so I do not know how to fix it (other than by deleting it!) — please would you explain

the 'Image Server' sub-section seems out of place as part of 'Syndicates and Counties'. I suggest it is moved to 'Making a transcription', at least until we actually have an Image Server when it will probably justify a section of its own

Thanks!

Changes made and page made ready for publication, i.e. sync-ready.
Out of date child pages moved into own folder — status clear and old bookmarks will no longer find them.


feat(c/driver): support ingesting into temporary tables

If not specified, drivers will explicitly favor non-temporary tables.

Fixes https://github.com/apache/arrow-adbc/issues/1018.

On top of #1056.


Use PDB to protect Longhorn components from drains

longhorn/longhorn#3304

Test data:
This cluster has 1 share manager on node phan-v195-pool2-70af420b-5p7f5. There are one workload pod on each of worker nodes.
Result: the workload on the same node as share manager is evicted first. Only then the PDB was removed and allow the share manager to be evicted.
# e.g. kubectl get all
> kubectl drain phan-v195-pool2-70af420b-5p7f5 --force --ignore-daemonsets --delete-emptydir-data
node/phan-v195-pool2-70af420b-5p7f5 cordoned
WARNING: ignoring DaemonSet-managed Pods: calico-system/calico-node-srtjv, default/longhorn-nfs-installation-4cjj7, kube-system/rke2-ingress-nginx-controller-c979d, longhorn-system/engine-image-ei-b907910b-vvclk, longhorn-system/longhorn-csi-plugin-tj65h, longhorn-system/longhorn-manager-xxddc
evicting pod longhorn-system/share-manager-pvc-33bc8a7a-4f93-4adb-8f12-5eb4c82da610
evicting pod longhorn-system/csi-resizer-6bf6f6f584-9ll9f
evicting pod calico-system/calico-typha-57b6fcbbd7-6kx8n
evicting pod cattle-fleet-system/fleet-agent-d75c64848-m4p8w
evicting pod default/test-dep-2-854985969-29stn
evicting pod kube-system/rke2-metrics-server-74f878b999-t5wq6
evicting pod longhorn-system/csi-attacher-dcb85d774-n6jtl
evicting pod longhorn-system/csi-attacher-dcb85d774-ns5mg
evicting pod longhorn-system/csi-provisioner-5d8dd96b57-76rcd
evicting pod longhorn-system/csi-provisioner-5d8dd96b57-9vqz9
evicting pod longhorn-system/longhorn-admission-webhook-5cbf54d474-l7c9x
evicting pod longhorn-system/csi-resizer-6bf6f6f584-vg7jq
evicting pod longhorn-system/csi-snapshotter-7cb6bf8447-fch4l
evicting pod longhorn-system/instance-manager-e-65ea59ebe6da390dadefe44893e46efb
evicting pod longhorn-system/instance-manager-r-65ea59ebe6da390dadefe44893e46efb
evicting pod longhorn-system/longhorn-driver-deployer-68c55d54bc-jpvbr
evicting pod longhorn-system/longhorn-conversion-webhook-c96f9fffd-qvdsl
evicting pod longhorn-system/longhorn-recovery-backend-6887644467-vf28s
evicting pod longhorn-system/longhorn-ui-79658c9768-h69rx
error when evicting pods/"share-manager-pvc-33bc8a7a-4f93-4adb-8f12-5eb4c82da610" -n "longhorn-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
pod/calico-typha-57b6fcbbd7-6kx8n evicted
error when evicting pods/"instance-manager-e-65ea59ebe6da390dadefe44893e46efb" -n "longhorn-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
error when evicting pods/"instance-manager-r-65ea59ebe6da390dadefe44893e46efb" -n "longhorn-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
I0310 22:43:47.060188      57 request.go:668] Waited for 1.195663259s due to client-side throttling, not priority and fairness, request: POST:http://<IP_ADDRESS>:8001/api/v1/namespaces/longhorn-system/pods/longhorn-driver-deployer-68c55d54bc-jpvbr/eviction
evicting pod longhorn-system/share-manager-pvc-33bc8a7a-4f93-4adb-8f12-5eb4c82da610
error when evicting pods/"share-manager-pvc-33bc8a7a-4f93-4adb-8f12-5eb4c82da610" -n "longhorn-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
evicting pod longhorn-system/instance-manager-e-65ea59ebe6da390dadefe44893e46efb
error when evicting pods/"instance-manager-e-65ea59ebe6da390dadefe44893e46efb" -n "longhorn-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
pod/csi-provisioner-5d8dd96b57-9vqz9 evicted
evicting pod longhorn-system/instance-manager-r-65ea59ebe6da390dadefe44893e46efb
error when evicting pods/"instance-manager-r-65ea59ebe6da390dadefe44893e46efb" -n "longhorn-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
pod/fleet-agent-d75c64848-m4p8w evicted
pod/test-dep-2-854985969-29stn evicted
pod/csi-provisioner-5d8dd96b57-76rcd evicted
pod/csi-resizer-6bf6f6f584-vg7jq evicted
pod/csi-resizer-6bf6f6f584-9ll9f evicted
evicting pod longhorn-system/share-manager-pvc-33bc8a7a-4f93-4adb-8f12-5eb4c82da610
pod/csi-attacher-dcb85d774-ns5mg evicted
pod/longhorn-admission-webhook-5cbf54d474-l7c9x evicted
pod/longhorn-driver-deployer-68c55d54bc-jpvbr evicted
evicting pod longhorn-system/instance-manager-e-65ea59ebe6da390dadefe44893e46efb
pod/csi-snapshotter-7cb6bf8447-fch4l evicted
evicting pod longhorn-system/instance-manager-r-65ea59ebe6da390dadefe44893e46efb
error when evicting pods/"instance-manager-r-65ea59ebe6da390dadefe44893e46efb" -n "longhorn-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
I0310 22:43:57.109065      57 request.go:668] Waited for 1.194202674s due to client-side throttling, not priority and fairness, request: GET:http://<IP_ADDRESS>:8001/api/v1/namespaces/longhorn-system/pods/share-manager-pvc-33bc8a7a-4f93-4adb-8f12-5eb4c82da610
pod/rke2-metrics-server-74f878b999-t5wq6 evicted
pod/csi-attacher-dcb85d774-n6jtl evicted
pod/share-manager-pvc-33bc8a7a-4f93-4adb-8f12-5eb4c82da610 evicted
pod/longhorn-conversion-webhook-c96f9fffd-qvdsl evicted
pod/instance-manager-e-65ea59ebe6da390dadefe44893e46efb evicted
evicting pod longhorn-system/instance-manager-r-65ea59ebe6da390dadefe44893e46efb
pod/instance-manager-r-65ea59ebe6da390dadefe44893e46efb evicted
pod/longhorn-recovery-backend-6887644467-vf28s evicted
pod/longhorn-ui-79658c9768-h69rx evicted
node/phan-v195-pool2-70af420b-5p7f5 evicted

In general, LGTM. Just a few things to clarify.
We also need to create another ticket for non-node/owner-basaed controller for setting, pdb, etc via leader election to prevent unnecessary and duplicated reconsiling.

Thank you for the reminder, I created the ticket at https://github.com/longhorn/longhorn/issues/5571

@Mergifyio backport v1.4.x v1.3.x


fix(storybook): list story

Overview

Fixes breaking List story

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: [ABC-123]
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change
[x] This PR includes testing instructions tests for the code change
[x] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

PR Links and Envs
Storybook only change

📬Published Alpha Packages<EMAIL_ADDRESS>
📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://66143d015244aa1668b1c5cd--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://66145004d4b20708e118760d--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut@55.16.2-alpha.b5f59b.0@codecademy/gamut-kit@0.6.397-alpha.b5f59b.0<EMAIL_ADDRESS>
I would be curious why there was a need to remove colormode (i.e. replace it with background) but it works and looks good!

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://661801408b99842dd0016c88--gamut-preview.netlify.appDeploy Logs


4.11.0-0.okd-2022-12-02-145640  IPI on vSphere problem with resolved-systemd DNS

Hello,
i've successfully installed  multiple OKD versions on disconnected environment,  but this time i've an issue with  dns ..
bootstrap node refuse  to resolve the  registry's DNS for some obscure reason..
Describe the bug
Bootstrap node is unable to resolve  dns of private registry
the DNS is a .local (  cnam-dmz.local )  as far as I know we do not perfoms mDNS  query
Jan 05 08:37:44 localhost.localdomain release-image-download.sh[1925]: Error: initializing source docker://quay.io/openshift/okd@sha256:924958ed5ba93ea9d72e4b5a319d0d4df220edbb891816c106215cbf318a0a40: (Mirrors also failed: [harbor.cnam-dmz.local/quay/openshift/okd@sha256:924958ed5ba93ea9d72e4b5a319d0d4df220edbb891816c106215cbf318a0a40: pinging container registry harbor.cnam-dmz.local: Get "https://harbor.cnam-dmz.local/v2/": dial tcp: lookup harbor.cnam-dmz.local: Temporary failure in name resolution]): quay.io/openshift/okd@sha256:924958ed5ba93ea9d72e4b5a319d0d4df220edbb891816c106215cbf318a0a40: pinging container registry quay.io: Get "https://quay.io/v2/": dial tcp <IP_ADDRESS>:443: i/o timeout
resolvectl status show our dns, a dig on another server is working fine ( but not through resolved-systemd mecanism )
i've seen other issue and a /etc/nsswitch.conf fix, but as this is IPI i'd like to avoid any manual changes
Version
4.11.0-0.okd-2022-12-02-145640  IPI on vSphere
How reproducible
100%
Log bundle
log-bundle-20230105094859.tar.gz
Thanks,

Seems your DHCP server didn't set nameserver in options? As a result, we can't fetch machine-os-content to read network params from vsphere args?


Unity crashes the instant I press play if there's a Player prefab

This has happened to multiple different VR projects I've worked on using the SteamVR plugin, and every time I do, it works perfectly fine for a couple days, then randomly one day will instantly crash when I press play. It does not crash if I remove or disable the Player prefab in the scene, but does when it is enabled. I never altered the prefab, it's the base one that came with the plugin. What is going on, and what is causing this to happen?

I solved the issue, at least only for this one project. I had moved the StreamingAssets folder into the Steam VR folder. Moving it back to the Assets folder fixed the crashes for now.


Fix issue regarding rotating Canvas Items in editor

Fixes #34861
Canvas items will now rotate correctly no matter what their global scale happens to be.

Nice.  Thanks for looking into this so quickly.

Here is a test scene:
RotationIssue.zip
You can mess with variables in the root node to try different combinations of scale. There are 64 different possible combinations. I've tried about 1-20 so far and thankfully my fix appears to be working.

Looks good, thanks! Could you squash the two commits together? See PR workflow.


Breaks at decrypt - parsing SIWE message

It breaks here at decrypt:
	try { 		decryptedString = await LitJsSdk.decryptToString( 			{ 				authSig, 				accessControlConditions, 				ciphertext, 				dataToEncryptHash, 				chain: "ethereum", 			}, 			litNodeClient, 		); 	} catch (e) { 		console.log(e); 	}
With error:
[Lit-JS-SDK v3.0.27] [ERROR] [core] [id: 168cd37033d2a] Something went wrong, internal id for request: lit_168cd37033d2a. Please provide this identifier with any support requests. Error is Error parsing SIWE message - validation error: SIWE validation failed: parser error: Session key expiration time is not set,Session key expiration time is not set
[Lit-JS-SDK v3.0.27] [ERROR] [core] [id: 168cd37033d2a] most common error: {"errorKind":"Parser","errorCode":"NodeSIWEMessageError","status":400,"message":"Error parsing SIWE message","correlationId":"lit_168cd37033d2a","details":["validation error: SIWE validation failed: parser error: Session key expiration time is not set","Session key expiration time is not set"]}

Hey @aymenx17 sorry for the late reply. Is this still the case? would you be able to create a repo for me to re-produce this error? :)

you night have to add expirationTime in your SiweMessage arguments:
const msg = new SiweMessage({... expirationTime: [some future Date]})


Can't handle missing fields when deserializing into Vec

Problem description
When deserializing application/x-www-form-urlencoded values from a form where multiple inputs have the same name into a single Vec, it can't handle when none of the values are present. (Like when all checkboxes are optional)
Example
To give a concrete example, I'll rip off the <form> example from WHATWG. Say you have a form like this:
<form method="post" action="submit">
    <fieldset>
    <legend> Pizza Toppings </legend>

 <input type=checkbox name="topping" value="bacon"> Bacon

 <input type=checkbox name="topping" value="cheese"> Extra Cheese

 <input type=checkbox name="topping" value="onion"> Onion

 <input type=checkbox name="topping" value="mushroom"> Mushroom

    </fieldset>

<button>Submit order</button>

</form>

You can correctly deserialize it into the following struct if at least one of the checkboxes are checked when the form is submitted:
struct PizzaOrder {
    topping: Vec<String>,
}

But if you submit the form with none of the boxes checked, then we get this error:

Failed to deserialize form: missing field topping

If you change the struct to the following:
struct PizzaOrder {
    topping: Option<Vec<String>>,
}

Then you can deserialize it when the field is missing, but now you get this error when you select one item:

Failed to deserialize form: invalid type: string "bacon", expected a sequence

and this error when you select multiple items:

Failed to deserialize form: unsupported value

Minimal reproduction
use axum::{
    response::{Html, IntoResponse},
    routing::{get, post},
    Router,
};
use axum_extra::extract::Form;

#[tokio::main]
async fn main() {
    let app = Router::new()
        .route("/", get(form))
        .route("/submit", post(submit));

    axum::Server::bind(&"<IP_ADDRESS>:3000".parse().unwrap())
        .serve(app.into_make_service())
        .await
        .unwrap();
}

async fn form() -> Html<&'static str> {
    Html(
        r#"
        <form method="post" action="submit">
            <fieldset>
                <legend> Pizza Toppings </legend>

 <input type=checkbox name="topping" value="bacon"> Bacon

 <input type=checkbox name="topping" value="cheese"> Extra Cheese

 <input type=checkbox name="topping" value="onion"> Onion

 <input type=checkbox name="topping" value="mushroom"> Mushroom

            </fieldset>

<button>Submit order</button>

        </form>
    "#,
    )
}

#[derive(serde::Deserialize, Debug)]
struct PizzaOrder {
    topping: Vec<String>,
}

async fn submit(body: Form<PizzaOrder>) -> impl IntoResponse {
    dbg!(body);
}

Solution?
I really wish I was good enough with Rust to figure out how to contribute here. I would have loved to send a PR along with this, but I've been struggling. In my head, the "right answer" is to set topping to an empty Vec when the field is missing. It's what I tried to do first, and I don't see the benefit in wrapping it in an Option if that means replacing the "empty list" state with None.
Related
https://github.com/tokio-rs/axum/issues/1029
https://github.com/tokio-rs/axum/pull/1031
Posting here based on the last comment on that first issue. I can move this if another repo needs to handle this.

Damn, I feel really silly, I didn't consider this option until I was digging into your implementation some more:
#[derive(serde::Deserialize, Debug)]
struct PizzaOrder {
    #[serde(default = "empty_list")]
    topping: Vec<String>,
}

fn empty_list() -> Vec<String> {
    vec![]
}

That works

I just had the same problem and was lucky to find this issue. Option<Vec<_>> behaves really strange. I switched from the axum Query extractor (which requires the Option<_> part) to the one from axum_extra and it took me some time to realize that I don't need the Option<_> at all. Maybe just a warning in the documentation about this would help.
Thanks a lot for sharing the crate!

Maybe just a warning in the documentation about this would help.

Want to send a PR? :)

I guess this happens for the combination of deserialize_option and deserialize_seq. I'm unsure what would be a good place to add a note about this. Probably deserialize_option is the better place. If you agree I'll make a PR.

I thought we were talking about the toplevel documentation of the crate. I think it would make sense for that to contain a note.

I had the same issue - I am glad I found this. Adding  #[serde(default)] worked for me.

Closing in favor of #11 which has a much clearer description.


Simultaneous voice and keystroke recording to produce tutorials

It would be nice to have a "record/stop" button where advanced coders can record their voice and keystrokes while building basic apps. Then, there can be an online platform to upload these "videos" (combination of voice and keystrokes in files). While beginners watch these tutorials made by the advanced coders, beginners are able to directly highlight and obtain code snippets and code snapshots from the recordings.

Thanks for the feedback! Creating and hosting screen recordings is out of scope for the VS Code project, but we do offer Screencast Mode (F1 => Developer: Toggle Screencast Mode), which some developers use when posting videos to existing popular video hosting platforms. Hope that helps!


Spread operator fails when deeply overriding objects

Hi,
I am trying to override an object with an enriched version of it using the spread operator but flow does not seem to understand.
Am I doing something wrong?
Example here
As you can see, the A and B types are the same, but the key user of the type B has one more field.
When I create a new object of type B by copying my object of type A with a spread operation and adding the new value through it, Flow gives an error.
// @flow

type A = {|
  stuff: string,
  user: {|
    name: string,
  |}
|}

type B = {|
  stuff: string,
  user: {|
    name: string,
    address: string,
  |},
|}

function tester(a: A): B {
  const b = {
    ...a,
    user: {
      ...a.user,
      address: 'hello'
    }
  };

  return b;
}

gives
27:   return b;
             ^ Cannot return `b` because property `address` is missing in object type [1] but exists in object type [2] in property `user`.
References:
5:   user: {|           ^ [1]
12:   user: {|            ^ [2]

Might be related to this issue.
Thanks for your help :)

Duplicate of #6108.

Indeed. Didn't find it, sorry about that 😉

No problem.


⚠ ClamAV has degraded performance

In d175d58, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 492 ms

Resolved: ClamAV performance has improved in 7f4ef99 after 541 days, 21 hours, 37 minutes.


BigQuery: Use constant strings for job properties

Closes #4793

Could you also import them into https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/bigquery/google/cloud/bigquery/init.py ?

Also, the reason for #4793 is that we weren't using the constants in https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/docs/bigquery/snippets.py , which needs to be updated, too. For the snippets.py usages, it will be best to use the bigquery module (my previous comment)

Another reason this does not close #4833

The docs do not include the possible values. See: https://googlecloudplatform.github.io/google-cloud-python/latest/bigquery/reference.html#google.cloud.bigquery.job.WriteDisposition It defines the class, but none of the values are shown.

@tswast This is my fault.  I remembered this PR, but I have been trying to work with pubsub and ended up just not wanting to switch into this and left it hanging too long.


Incremental Refresh Policy not applied despite "Full" refresh

My understanding is that a "Full" refresh would give the same results as an On Demand refresh of the semantic model via the service. But I'm getting different results when it comes to Incremental Refresh.
When triggering the full refresh via VS Code, partitions are not created or dropped as expected.
This is following a VS Code Full refresh on 6/26, for a model that has an IR policy enabled for Monthly partitions:

I was surprised to not see a new partition created for 2024Q206.
Two days later (with no other changes) I triggered an On Demand refresh via the service and got the expected result:

I'm on v2.1.1 of the extension and I've experienced this with a few different models. Let me know if I have a misunderstanding of the expected functionality.
Thanks!

there was another issue https://github.com/gbrueckl/PowerBI-VSCode/issues/27 where we explicitly set the applyRefreshPolicy to false
guess I have to rework this and make it more granular
e.g. if you select a partition -> applyRefreshPolicy = false
if you select a table/whole dataset -> applyRefreshPolicy = true
will implement it in the next release

ok, was a quick fix I think - just released v2.1.2 where this should be fixed now (as described above)
could you please check @Lvanlaar26  and report back here if the issue still exists

Worked great - Thanks!


Refactor Query classes

Query classes currently aren't dry. Find a better implementation.

Fixed in #9


No longer rebase, instead merge master.

The original idea behind rebasing was that the diff of the branch stays
readable when further changes are needed after a merge attempt by the
bot. This proofed to be not necessary in practise. So we switch the
rollup strategy to using merge, since it creates less merge conflicts.

@wally-the-cartographer merge

Merge requested by authorized user SirVer. Merge queue now has a length of 1.


Add code formatter

As discussed in #310
This adds an npm script: npm fix, that will reformat the code using prettier
and a bit of eslint (mainly to fix use of const and => in tests). Eslint errors that can not be automatically fixed are currently printed but otherwise ignored (exit code is 0).
If you think it's a good idea it's best to merge all pending pull-requests first at which point I can rebase this and it can be merged and we will have more consistent code going forward.

Thanks for the review @bd82, I have added you as a collab on my fork so you can make suggested changes to this PR yourself if you want, otherwise I'll take another look once it's decided whether maintainers want this at all.
As far as I understand it, while your suggestions make sense, the effect on the actual source code would be the same. Maintainers can still look at the existing diff and decide if they want it, right?

Yes. the effect on the source code would be the same.
The suggestions would make it easier to maintain the changes over time by the maintainers of Nearley.

@kasbah I am sorry but the review is the limit of my collaboration here 😢

No problem, thanks for your suggestions. I'll definitely implement them if it is planned to be merged in general.

Closing in favour of #314. Thanks for looking into this! :)


The cross in the default theme has two colors

Hello,
Is it normal that the cross in the default theme has two colors like this:

I find its rendering is strange with these two colors.

This is the theme I have chosen, you are free to create your own themes, and/or modify the graphics used by using CSS overrides. Design is highly subjective.


Fix error in assert message

The assert message wrongly evaluated train_decoder_output.get_shape(), missing .rnn_output and causing an error instead of printing the assert failure message.

@digitalex Thanks!