Multi Spinner API Review

Currently the TTY::Spinner::Multi class supports registering spinners you can start later.

TTY::Spinner::Multi#initialize should take arguments in the same form as TTY::Spinner#initialize
Should users be able to register a spinner with a block? (Note: we'd have to manage a thread for the block to run in)
Multi doesn't currently have a spin method (but it does have auto_spin). Is there a use case for adding spin?
Are there other methods that would be useful to users?

My feelings are

Yes, this should be standardized
There are so many different ways to use threads, and so many data races that can come of it, by obfuscating the fact that their code is running in threads we increase the chance for people to have problems.
I'd be fine adding this, do people ever pause their spinners? Other than that I can't think of a concrete use case.
I think the ability to tweak or customize how the top-level spinner and the sub-spinners display would be useful.

maybe with inset options? (where defaults are the spaces currently in the code)

inset_opts = {
  insets: {
    top_level: "- "
    sub_spinners: "---- "
    last_spinner: "----> " # defaults to sub_spinners if not provided
  }
}

# This is not how they are currently initialized, but how they would be under #1
TTY::Spinner::Multi.new("[:spinner] top level", inset_opts)

Thank you for listing these. I've opened separate issues for each point:

Agree & opened new issue
I kind of feel that this would be one of the ways to create multiple spinners. It seems to me to be a more programmatic way of registering similar indeterminate tasks. For example, you could get enumerable of files and create spinners for each that start when multispinner is started(i guess we would need to add #start) that need to be downloaded in separate jobs and monitored when all are completed/errored. issue
Agree spin seems awkward for multi spinners, but having #pause and #resume may be an interesting addition. I can see these potentially being useful for single spinner and multi spinner. I'm not sure if people are dying to have this feature though :smile: issue
Agree, though my preference in naming would be to use indent & style in place of insets issue

What do you reckon?


Remove dependency to ngrok binary by using ngrok-api-go

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe
Ngrok is an optional dependency that must be installed as a separate package, even if it is included in the installer.
It is quite well included in ddev share but it's behavior does differ from other ddev commands. It's ui does differ much from the default ddev output, also it does not support the --json-output option.
Describe the solution you'd like
The ngrok binary is just an API Client. The same could be done in ddev itself by using https://github.com/ngrok/ngrok-api-go for example. This would allow a better integration of ngrok in ddev and would remove the dependency to the ngrok binary and related installation documentation.
I am aware of the challenges this would cause:

API Key must be manged by ddev itself
Common features of the ngrok binary must be implemented in ddev
Breaking changes to configuration and behavior

I see the following advantages:

The ngrok binary is closed source. Issues are hard to debug.
Ngrok is currently a standalone dependency and must be kept up to date along with ddev
A better integration in ddev
Better control over the ngrok client version

Describe alternatives you've considered
This is a proposal to improve the current state.
Additional context
An example of a problem that is difficult to debug because the binary is closed source:
https://github.com/php-perfect/ddev-intellij-plugin/issues/53
The updating UI output of Ngrok is also hard to integrate in the PHPStorm integration plugin. But the main reason for this proposal is to get rid of the additional external dependency.

Super interesting! Thanks.
Another thing that comes up regularly is the fact that ngrok is a fairly obnoxious closed-source system, and significant use usually requires paying money. A number of alternatives have come and gone, but ngrok seems to be the most long-lived and best maintained, even though they regularly break things.

This seems like it would be great, but I don't see it being a priority any time soon. Closing for now.


bug: use groupPaths query parameter in .../submissions.csv endpoints.

@ktuite, I think this can be reviewed async!

Just changed the commit message prefix from "fix" to "bug".


Provide more explicit guidance on which options are best for new projects

As someone who's adding bincode to a new project, I'm having a hard time figuring out from docs what the "right" way to use the crate is.
Most of the documentation uses the serialize and deserialize functions, as does the example. That works great.
My use-case involves writing serializing a list of things, then reading them out again later. Due to #387, I added a BincodeDevice<'a> struct that borrows from Device<'a> to do the actual serialization. I then have this:
impl<'a> Device<'a> {
    pub fn to_bincode(&'a self) -> BincodeDevice<'a> {
        // elided
    }
}

I then call devices.iter().map(Device::to_bincode), and rather than collecting that into a Vec, I decided to use serde::Serializer::collect_seq. That's when I found bincode::Serializer::new(...), which is when things started getting harder.
The docs do warn that the function form and the DefaultOptions form have different settings - thanks for being very explicit about that, and for providing clear guidance on how to get the function behavior with the struct. However, reading this sentence left me wondering which settings I should be using.

Due to historical reasons, the default options used by the serialize() and deserialize() family of functions are different than the default options created by the DefaultOptions struct

The phrase "historical reasons" makes me think the new way is better, but that's never actually stated. It would be helpful if the docs were slightly more opinionated, or provided some pros and cons on the different settings.

I personally would like more bincode/examples, I see there only 3yrs old basic example and it makes me think, that the crate is abandoned, because nearly all Rust crates have examples in them, that's what Rust philosofy is.


Fix error message formatting

Summary
This error message doesn't format correctly when outputted to the terminal.  It seems the 2nd line is missing
Changelog

[iOS] [Fixed] - bug with error message formatting when bundle is missing
Test Plan
Before:

After:

Hi @BenLorantfy Could you please rebase to get these circleci checks green and I'll get this merged?


addFont not working when text is right aligned.

I was trying to use the font Arial in my application by:
this.doc = new jsPDF("l", "pt", [this.width, this.height]);
this.doc.addFont('Arial', 'arial', 'normal');
......
this.doc.setFont('arial');
this.doc.text(x, y, text, null, null,'right');
When the code is run, an exception will be thrown from 'jspdf.plugin.split.text_to_size.js' as follows:
TypeError: Cannot read property 'widths' of undefined

The issue only occurred when right alignment was used. When the text is left-aligned, it is working fine.


feat: add supply pallet and token distribution to standalone runtime

Signed-off-by: Gregory Hill<EMAIL_ADDRESS>

Happy to generally merge it, but wondering if it would make more sense to move to a parachain setup across our entire stack to reduce maintenance overhead of different runtimes.

Happy to generally merge it, but wondering if it would make more sense to move to a parachain setup across our entire stack to reduce maintenance overhead of different runtimes.

Yea I suggested this as well. I think long-term it is definitely the way to go, partly because it allows us to test the integration logic (the logic in the runtime file that glues the pallets together).

We can of course share some of the glue code, but we need distinct runtimes and I would still prefer to have a standalone chain (pending #363) for ease of testing. What we should probably do is allow configurable runtimes for the integration tests, see Acala's testing setup for example.


Support pre-built binaries for Ruby 3.2

Is your feature request related to a problem? Please describe.
It seems grpc does not support pre-built binaries for Ruby 3.2.
Describe the solution you'd like
Add pre-built binaries for Ruby 3.2
Describe alternatives you've considered
N/A
Additional context

https://github.com/grpc/grpc/issues/28627
Ruby 3.1 release note: https://www.ruby-lang.org/en/news/2021/12/25/ruby-3-1-0-released/

This is coming in the upcoming 1.52.0 release
You can use it already in the 1.52.0.pre2 packages

Looks like the gem version 1.52.0 has not been released yet.
https://rubygems.org/gems/grpc/versions

Version 1.52.0 seems to have been pushed. 👍


⚠ Minecraft has degraded performance

In e1fda7e, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 1417 ms

Resolved: Minecraft performance has improved in c34c3f0.


Laravel 8.55.0 Shift

This pull request includes updates for the recent minor version release of Laravel as well as updates to your package dependencies. Feel free to commit any additional changes to the shift-ci-v8.55.0 branch.
Before merging, you need to:

Checkout the shift-ci-v8.55.0 branch
Review all pull request comments for additional changes
Run composer update
Test your application (no tests?)

:information_source: The following Laravel packages were updated as they are known to be compatible with Laravel 8.55. Nonetheless, you should review the CHANGELOG to ensure no additional changes are needed.

[ ] stevegrunwell/time-constants

:warning: You are running version 2.13.2 of doctrine/dbal. The latest version is 3.1.1. You should review this dependency to see if you can upgrade to the latest version.

:warning: The Shift build servers run PHP 8. If you are still running PHP 7.4 or lower you should run composer update locally to ensure you have the proper versions of your dependencies to reflect your PHP 7 environment.


[main] Update community files (#168)

Update community files
Signed-off-by: Knative Automation<EMAIL_ADDRESS>

/retest

/retest

OCF Webhook is merging this PR


Revert "ci: Fix use of parameter in conditionals (#4984)"

This reverts commit 557f5d57695dcda123218192e82f478e44387443.

Motivation
@tolbrino I'm reverting this because this broke releases.
the file names include the full sha tag when they should only be nightly
see https://github.com/foundry-rs/foundry/releases/tag/nightly-4f9369f876c70cefe53c9fea5919e078b50e29ae
vs https://github.com/foundry-rs/foundry/releases/tag/nightly-e15e33a07c0920189fc336391f538c3dad53da73
also one of these is wrong
IS_NIGHTLY: ${{ github.event_name == 'schedule' || ( github.event_name == 'workflow_dispatch' && github.ref_type != 'tag' ) }}
if: env.IS_NIGHTLY == true

as mentioned my bash skills are kinda limited, hence the revert.
feel free to reopen and we'll test this before merging again.

Solution

Sorry I did not see the issues and this revert. Only now that I wanted to tag a new release I got confused that it does not work anymore -.- I will investigate this.


Fix \underset

This PR modifies \underset and \overset so that they will behave like LaTeX when an exponent is applied after the \underset. Fixes issue #1275.
I also changed the spacing from KaTeX mop to KaTeX mrel. The result seems to be a better match to LaTeX.

Visual confirmation:

It looks like a few screenshots need to be updated.

I have never mastered Docker and so am unable to update screenshotter tests. In the past, @kevinbarabash  has been kind enough to update them for the PRs that I submit. In the most recent example, he ran the test; then pasted the two relevant screenshot files into a comment on the PR's comment thread.  I took the png files and copied them into the screenshotter folder in that branch.
That could work again if anyone would care to help me out.

I updated the screenshots for you (pushing directly to your branch).  Check out the https://github.com/Khan/KaTeX/pull/1277/files?short_path=da83f1e#diff-da83f1efcd086fe5f05c338688da3c18 to make sure it looks like the right new behavior.

@edemaine  The new screenshots look perfect to me. Feel free to proceed with final approval and a merge.


[MINOR][TEST] Re-enable some DS v2 char/varchar test

What changes were proposed in this pull request?

Some tests are skipped because some bug fixes were not backported. This PR re-enables some tests that are working fine now.
Why are the changes needed?

enable test
Does this PR introduce any user-facing change?

no
How was this patch tested?

N/A

@yaooqinn @maropu

Test build #134909 has started for PR 31481 at commit 7e9fbcd.

LGTM

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39492/

BTW, add [3.1] to the pr title

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39492/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39492/

Test build #134909 has finished for PR 31481 at commit 7e9fbcd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134909/

merging to 3.1!


fix(page): Page.createIsolatedWorld error catching has been added

What kind of change does this PR introduce?
Bug fix
Did you add tests for your changes?
No
If relevant, did you update the documentation?
Not relevant
Summary
When navigating, frames are destroyed and sending events leads to an error that crashes the whole process. This error was mentioned here. Error example:
ProtocolError: Protocol error (Page.createIsolatedWorld): No frame for given id found
at /.../node_modules/puppeteer/src/common/Connection.ts:300:16
at new Promise (<anonymous>)
at CDPSession.send (/.../node_modules/puppeteer/src/common/Connection.ts:296:12)
at /.../node_modules/puppeteer/src/common/FrameManager.ts:397:19
at Array.map (<anonymous>)
at FrameManager._ensureIsolatedWorld (/.../node_modules/puppeteer/src/common/FrameManager.ts:396:10)
at async Promise.all (index 1)
at async FrameManager.initialize (/.../node_modules/puppeteer/src/common/FrameManager.ts:143:7)
at async FrameManager._onAttachedToTarget (/.../node_modules/puppeteer/src/common/FrameManager.ts:262:5) {
originalMessage: 'No frame for given id found'
}

Does this PR introduce a breaking change?
As I can see there is no breaking change

LGTM
I tried the fix in my use case and it seemed to work as expected
Someone from Puppeteer team should give their blessing as well. I don't know all the implications of the change, and why it broke now. I believe the catch clause hasn't been there for a few puppeteer releases so some other change has made this issue surface again

Didn't mean to close :D

I will update PR tomorrow

When will this change make it into Puppeteer?


Buff Medical due to Shitmed Changes

About the PR

Buffed applicable medication heal values.
Buffed applicable medication stack sizes.
Slightly buffed dylovene, burn, and brute chems.
Buffed applicable medication doAfter delay from 3s to 2s.

Why / Balance

This change was made with the advent of the new Limb Damage system. This PR seeks to achieve making SS14 Medical more equivalent to SS13 Medical when it comes to healing damage values.
This was done as Bruise Packs and Ointment only heal 5 Brute or 5 Burn respectively when applied to a limb. When each limb has a 100 Crit threshold, this can make it extremely hard even with surgery to heal limbs in the absence of Chemicals.
Furthermore on higher pop, this will lead to people burning through applicable meds even faster than before Limb Damage was implemented.
Technical details

Mostly YML Value Changes and 2 float val changes for DoAfters. Commented old value and reason for change on each.

Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Should values be overtuned, they can be reduced in a future PR or before this PR is merged.
Changelog

:cl:

tweak: Increased applicable medication heal values.
tweak: Increased stack size of applicable medications.
tweak: Slightly increased dylovene, burn, and brute chemicals heal values.
tweak: Decreased Medical item application time from 3s to 2s

Summary by CodeRabbit
Release Notes

New Features

Enhanced healing items with increased effectiveness and new entities introduced.

Adjustments

Healing item damage values have been significantly increased for various items, improving their in-game utility.
Stack counts for several healing items have been increased from 10 to 15, and prices have been adjusted accordingly.

Rebalancing

Reagents have undergone a comprehensive rebalancing, with many damage values increased to enhance their impact in gameplay.

based and shitmedpilled

we're back


⚠ SceneTime has degraded performance

In b007f74, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 6987 ms

Resolved: SceneTime performance has improved in fa2001d.


Ways to Make a Fair Array

Problem Link
https://leetcode.com/problems/ways-to-make-a-fair-array/
Coding platform
Leetcode
Programming language

[ ] C
[ ] C++
[x] Java
[ ] Python

Additional context (OPTIONAL)
I want to solve it in Java

I would like to do this in c++


Add Minimum Cost Path in C++

Hello,
I would like to add the code for Minimum Cost Path under the DP section. Please assign this to me. I would do my best.

I am quite interested in learning , implementing and bettering algorithms .So please consider assigning this issue to me under GSSOC'21 .

I have been selected for GSSOC'21, and I am really interested in Algorithms , so I would like to contribute in this amazing repository.I can contribute for this ,I am 2 star codechef candidate and would be great to contribute to open source programs like this one.

I would love to contribute to solving the problem, I am a GSSOC'21 participant. Please assign it to me. I will try my best and provide proper comments and implement different test cases for better understanding. I will use traveling salesperson algorithm for the same and will compare it with other algorithms as well.

I am GSSOC'21 participant and l would like to work on this problem and would make sure to implement a neat and clean code ,and make it easy to understand using comments.


ISPN-11997 Remove jackson databind

https://issues.redhat.com/browse/ISPN-11997
NOTE: There is a single place that databind is still used: the JsonTranscoder conversion from user objects to JSON and back. We can either deprecate this conversion altogether and redirect users to protostream, or provide a way to plug custom JSON   serializers (https://issues.redhat.com/browse/ISPN-12121)

Merged. This is awesome.


First unit test and Github action

I added some improvements including a Github pipeline, see here:

https://github.com/simonbaird/ec-policies/actions/runs/2073384955

I might merge it soon if there's no objections.


add Azure Container Registry policies api and update OperationDefinition

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-node

Automation for azure-libraries-for-java

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

@mnltejaswini  @sajayantony  @msyihchen @djyou

@marstr The CI complains when adding values to enum. Can you please take a look?
INFO:swaggertosdk.autorest_tools:TypeError: metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases

@lmazuel, is adding enum properties categorically breaking, or is this something to do with the way that value was added?

@ravbhatnagar may be able to help shed some light here too.

Yes adding values to an enum is a breaking change. The reason being a strongly typed SDK will not be able to deserialize a value it doesnt understand. To avoid this, enums need to be categorized as modelAsString:true.

@ravbhatnagar We have set modelAsString: true for the enums.

Let me know when you're ready to merge

Looks good!

Ready for me to merge, @ankurkhemani ?

@marstr Let's wait for the ARM manifest change to be applied .. I will let you know. Thanks!

Any updates here, or an estimated time-line for when these changes should be applied?

Closing as stale. Feel free to ping this thread to have it re-opened.

Automation for azure-sdk-for-java

Automation for azure-sdk-for-ruby


Unable to use peer/orderer binaries from windows package

The first issue is that the binaries don't have the '.exe' extension so would be good to package them with the extension.
The other problem is the following code from internal/fileutil.go
// SyncDir fsyncs the given dir
func SyncDir(dirPath string) error {
	dir, err := os.Open(dirPath)
	if err != nil {
		return errors.Wrapf(err, "error while opening dir:%s", dirPath)
	}
	if err := dir.Sync(); err != nil {
		dir.Close()
		return errors.Wrapf(err, "error while synching dir:%s", dirPath)
	}
	if err := dir.Close(); err != nil {
		return errors.Wrapf(err, "error while closing dir:%s", dirPath)
	}
	return err
}

calling Sync on a dir fails with the error "The handle is invalid." on windows as it isn't valid to perform that action
As a workaround I used the following implementation
// SyncDir fsyncs the given dir
func SyncDir(dirPath string) error {
	dir, err := os.Open(dirPath)
	if err != nil {
		return errors.Wrapf(err, "error while opening dir:%s", dirPath)
	}
	if err := dir.Sync(); err != nil {
		if !strings.Contains(err.Error(), "The handle is invalid.") {
			dir.Close()
			return errors.Wrapf(err, "error while synching dir:%s", dirPath)
		}
	}
	if err := dir.Close(); err != nil {
		return errors.Wrapf(err, "error while closing dir:%s", dirPath)
	}
	return err
}

But this will only work on english versions of windows probably so a better soln should be done

detect if the platform is windows ?
remove this function into 2 separate files and use

//go:build linux
// +build linux

to embed the correct file for the correct platform

@davidkel Everything in the Go os package is platform agnostic, and I believe that would include File.Sync(). Do you have any idea why it fails?
This utility function has been in main code path for a long time and we haven't heard of issues on Windows from others (I assume somebody has tried Fabric on Windows but I could be wrong). We don't test or claim support for operating systems besides linux, but since the code uses OS agnostic functions everything should work, and if they don't, we'd accept PRs to fix.


Cycling calls GetCounterparts twice.

...which is a minor performance concern.

https://github.com/jpetrie/vim-counterpoint/commit/c0eac45ba6a041dd559230cdf41177b14fa5aa81 fixes this.


Editor: PinJoint2D does not remove warning

Godot version
v4.0.2.stable.official [7a0977ce2]
System information
Windows 10, compatibility renderer
Issue description
PinJoint2D still shows warning triangle even when nodes are assigned, must switch to different scene tab to remove triangle
Steps to reproduce
Make scene with rigidbody, add rigidbody child, add pinJoint2D, assign nodes to pinJoint2D
Minimal reproduction project
N/A

Cannot confirm this, in fact the warnings are broken when only one node is assign it looks like weirdly enough

I have experienced this exact things as well (Godot_v4.2.1-stable_mono_win64)... I created a Node2D base scene. A Pinjoint2D, StaticBody2D, and RigidBody2D were added to the base scene. Rectangular collision shapes and Sprite2Ds were then added as children to each of the PhysicsBody2Ds. Then, the PhysicsBody2Ds were assigned to Node A and B in the Pinjoint2D (StaticBody2D in Node A, RigidBody2D in B). The warning triangle for the pinjoint did not clear, until switching to a different scene tab.


Want to add security

Plaese assign me the issue
@aslams2020

Which security?

Added security of the website
On Sat, 2 Nov 2024, 10:00 am Sayyad Aslam, @.***> wrote:

Which security?
—
Reply to this email directly, view it on GitHub
https://github.com/aslams2020/Stark-Tech-Portfolio/issues/347#issuecomment-2452855494,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7SRZ6BDJ3WWC7H3OCGC4ILZ6RIM3AVCNFSM6AAAAABRANVHMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJSHA2TKNBZGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

please elaborate more

Add necessary security to protect the website against the harms
On Sat, 2 Nov 2024, 10:11 am Sayyad Aslam, @.***> wrote:

please elaborate more
—
Reply to this email directly, view it on GitHub
https://github.com/aslams2020/Stark-Tech-Portfolio/issues/347#issuecomment-2452858573,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7SRZ6DU2PEYVGL4GGUEPN3Z6RJYXAVCNFSM6AAAAABRANVHMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJSHA2TQNJXGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Please assign me the issue
On Sat, 2 Nov 2024, 12:38 pm Sayyad Aslam, @.***> wrote:

Closed #347
https://github.com/aslams2020/Stark-Tech-Portfolio/issues/347 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/aslams2020/Stark-Tech-Portfolio/issues/347#event-15076826091,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7SRZ6EIT6NS3NJOZQXYY6LZ6R3AFAVCNFSM6AAAAABRANVHMKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGA3TMOBSGYYDSMI
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

Please raise other issue in the repo.
As for our website we dont need security ig..
You can still find and raise new issues

Okay
On Sat, 2 Nov 2024, 12:51 pm Sayyad Aslam, @.***> wrote:

Please raise other issue in the repo.
As for our website we dont need security ig..
You can still find and raise new issues
—
Reply to this email directly, view it on GitHub
https://github.com/aslams2020/Stark-Tech-Portfolio/issues/347#issuecomment-2452904434,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7SRZ6E36WY7WICABNRFRK3Z6R4PPAVCNFSM6AAAAABRANVHMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJSHEYDINBTGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


utilize implicit undefined check to fix key size error not being thrown

Oh, good idea, but perhaps it should just be if (!rounds) { ... , to catch implementations that return undefined as well? (since nothing has zero rounds)

That is fine but just so you know, == does indeed catch undefined.
http://jsbin.com/susenumuge/edit?html,js,output


CAFV-281: Use same version methodology as other components

Description
Please provide a brief description of the changes proposed in this Pull Request

Change version to be in line with other components, so that the git-sha is also embedded in it

Checklist

[X] tested locally
[X] updated any relevant dependencies
[ ] updated any relevant documentation or examples

API Changes
Are there API changes?

[ ] Yes
[X] No

If yes, please fill in the below

Updated conversions?

[ ] Yes
[ ] No
[ ] N/A

Updated CRDs?

[ ] Yes
[ ] No
[ ] N/A

Updated infrastructure-components.yaml?

[ ] Yes
[ ] No
[ ] N/A

Updated ./examples/capi-quickstart.yaml?

[ ] Yes
[ ] No
[ ] N/A

Updated necessary files under ./infrastructure-vcd/v1.0.0/?

[ ] Yes
[ ] No
[ ] N/A

Issue
If applicable, please reference the relevant issue
Fixes #

This change is

release/version.go line 9 at r1 (raw file):
Previously, lzichong wrote…
Do we need a //go:embed here?

No, and that was the reason for the earlier issue. The go-embed gets things from a file and is static (will not add the git-sha), while we do need it coming in from the build command itself.


[SPARK-24918][Core] Executor Plugin API

What changes were proposed in this pull request?
A continuation of @squito's executor plugin task. By his request I took his code and added testing and moved the plugin initialization to a separate thread.
Executor plugins now run on one separate thread, so the executor does not wait on them. Added testing.
How was this patch tested?
Added test cases that test using a sample plugin.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Please remove all of the PR template text from the description.

Can one of the admins verify this patch?

Jenkins, ok to test

Test build #95136 has started for PR 22192 at commit 44454dd.

Test build #95136 has finished for PR 22192 at commit 44454dd.

This patch fails Java style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
      .doc(\"Comma-separated list of class names for \"plugins\" implementing \" +

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95136/
Test FAILed.

Merged build finished. Test FAILed.

Test build #95138 has started for PR 22192 at commit 7c86fc5.

Test build #95138 has finished for PR 22192 at commit 7c86fc5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95138/
Test FAILed.

retest this please

(to my understanding this issue isn't part of my change, I checked other pulls that had this error around the same time and those also had similar outputs and lack of specific errors)

retest this please

Test build #95182 has started for PR 22192 at commit 7c86fc5.

Test build #95182 has finished for PR 22192 at commit 7c86fc5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95182/
Test PASSed.

Test build #95376 has started for PR 22192 at commit 44aa634.

Test build #95376 has finished for PR 22192 at commit 44aa634.

This patch fails Java style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95376/
Test FAILed.

Test build #95377 has started for PR 22192 at commit 284beaf.

Test build #95377 has finished for PR 22192 at commit 284beaf.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95377/
Test FAILed.

Merged build finished. Test FAILed.

I don't think this test failure was caused by my changes, it failed a ML test in python due to a worker crashing. Couldn't find anything in the logs indicating that my changes led to this issue (also I don't think I changed any functionality from my previous commit, which passed all tests). Could someone retest this please?

I'm going to commit the fixes recommended by @vanzin soon. Then, I think the biggest remaining concern is the threads. I'm okay with adding a start and stop, but I'm curious as to whether those should potentially be in a separate Jira. This could potentially go into 2.4, and more methods could be added as we learn the use cases for plugins. My concern with adding them is that if it's decided they're obsolete or repetitive (in the case of init vs start), but people have already started using some plugins, it'd be annoying to take away the methods they expect to work. My best argument for adding the methods is we could try to ensure people conform to a similar structure if we have, say, the init function run in the same thread as the executor, and then once the executors have initialized we could create a thread that starts the plugins so really plugin writers wouldn't have to even worry about making their plugins async. Does anyone have strong opinions?

Test build #95503 has started for PR 22192 at commit 2907c6b.

Test build #95503 has finished for PR 22192 at commit 2907c6b.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95503/
Test FAILed.

Can one of the admins verify this patch?

ok to test

Test build #95544 has started for PR 22192 at commit 2907c6b.

Test build #95557 has started for PR 22192 at commit a968b0a.

Test build #95557 has finished for PR 22192 at commit a968b0a.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95557/
Test FAILed.

Test build #95559 has started for PR 22192 at commit fa19ea8.

Can't be a coincidence...it's failing two pyspark streaming tests, test_binary_records_stream and test_text_file_stream (same two earlier, I misanalyzed it when I said it was ML stuff). I'm running them locally to try to reproduce, though not sure how they relate to my changes. Nonetheless other PRs are building fine right now so it must be something in my changes.

retest this please

Test build #95565 has started for PR 22192 at commit fa19ea8.

Test build #95567 has started for PR 22192 at commit fa19ea8.

Test build #95559 has finished for PR 22192 at commit fa19ea8.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95559/
Test FAILed.

These tests are failing locally for me, both with my code and without on a clean pull of master

Test build #95565 has finished for PR 22192 at commit fa19ea8.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95565/
Test FAILed.

Test build #95567 has finished for PR 22192 at commit fa19ea8.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95567/
Test FAILed.

Tried on a different machine and those tests pass, here's hoping

Test build #95584 has finished for PR 22192 at commit 5a2852f.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95584/
Test FAILed.

I believe this is another glitch, not from my changes. Could someone retest this please?

retest this please.

Test build #95681 has started for PR 22192 at commit 5a2852f.

Test build #95681 has finished for PR 22192 at commit 5a2852f.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95681/
Test FAILed.

You're right, I ran in local-cluster and it exited very quickly citing executors shutting down after not being able to find my test plugin. Although, the logs say that it does use a CoarseGrainedExecutorBackend:
18/09/05 12:03:20 INFO CoarseGrainedExecutorBackend: Connecting to driver: spark://CoarseGrainedScheduler@nihar-xxx:45767
unless you mean Yarn only uses that one command line option. I'm looking into how it reacts in regular standalone mode with different thread counts. Thanks for pointing this out!
I'm looking up other spark-submit options that can be used to provide the jar to other nodes, but I'm not super hopeful it's going to work out. If it indeed doesn't, I'll start exploring other options once I figure out why the pyspark tests are failing

I'll change the config documentation to specify YARN only, hopefully it's not a huge issue.
It seems like the line Thread.currentThread().setContextClassLoader(replClassLoader) is causing the pyspark failures, they pass when I remove it. I'm looking at the test cases but I really don't see how this is affecting them...it seems that in both test cases, the DStreams monitor a directory but don't pick up the changes they're supposed to, and just time out. I checked that I can bypass this issue by changing back to having the plugins loaded on a separate thread (and setting that thread's contextClassLoader instead of the current thread) and it passes tests and continues to work. That said this issue does seem to be indicative of some problem in pyspark streaming

I'll change the config documentation to specify YARN only, hopefully it's not a huge issue.

I don't think you're really understanding what I'm saying above. I'm not saying this feature only works with YARN. I'm saying that distributing the plugins with --jars only works with YARN. And that if there was user-documentation for this feature - which there isn't - then it would have to explain how the jar is expected to be made available to the executors.

It seems like the line Thread.currentThread().setContextClassLoader(replClassLoader) is causing the pyspark failures

What if you restore the original class loader after initializing the plugins? I was a little worried about this call, but was waiting for tests... so if it's causing problems, better to not change the way things work there.

@vanzin @NiharS I am uncomfortable with that change as well - which is why I wanted the initialization to be pushed into a separate thread (and then join) - if we really need to set the context classloader.

@mridulm I'm inclined to agree. I was doing some extra testing on separate thread and it seems to be performing well. I'll push this shortly. I'm going to also test setting the class loader and then changing back, since I'll always be partial towards synchronous operations, but separate thread is certainly seeming like a good policy given the pyspark failures.

Test build #95772 has started for PR 22192 at commit b0be9e5.

Test build #95772 has finished for PR 22192 at commit b0be9e5.

This patch fails Java style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95772/
Test FAILed.

I tested @vanzin's suggestion of storing the classloader, changing it to replClassLoader, and changing back after init (and then changing again for shutdown). It's working well (and this time I made sure it doesn't just shut down immediately; I ran on a cluster and confirmed it runs the init code and creates a thread, the thread stays alive for the duration of the executor, and the shutdown code runs fully before exiting). While it looks a little weird, the code is synchronous and shouldn't run into an issue with the classloader being set to something it shouldn't be set to while executing the existing Spark code, and ensures the plugins initialize fully during executor initialization.

If I want to add more testing plugins (i.e. to test that a plugin failing to shut down doesn't affect other plugins), is it stylistically ok for me to keep throwing them at the bottom of ExecutorPluginSuite? Or should I make a separate file (or multiple) for them?

it's ok to keep them in the same suite where they are used.

Test build #95810 has started for PR 22192 at commit 10481f0.

Test build #95806 has finished for PR 22192 at commit c725a53.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95806/
Test PASSed.

Merged build finished. Test PASSed.

Test build #95814 has started for PR 22192 at commit cf30ed5.

Test build #95810 has finished for PR 22192 at commit 10481f0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95810/
Test FAILed.

Test build #95814 has finished for PR 22192 at commit cf30ed5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95814/
Test PASSed.

Test build #95862 has started for PR 22192 at commit 447c5e5.

Test build #95862 has finished for PR 22192 at commit 447c5e5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95862/
Test FAILed.

retest this please

Test build #95887 has started for PR 22192 at commit 447c5e5.

Test build #95887 has finished for PR 22192 at commit 447c5e5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95887/
Test FAILed.

retest this please.
I took a look at the failures, pretty certain its unrelated, and I filed https://issues.apache.org/jira/browse/SPARK-25400 to increase the timeouts in one of those failures.

Test build #4333 has started for PR 22192 at commit 447c5e5.

I feel like it should be unrelated as well. It's strange that I failed tests in the same suite twice in a row, and that no other recent build has failed that suite, but I tried running locally on a mac and a linux vm and couldn't reproduce it so...fingers crossed

retest this please.
It's that old "java.lang.reflect.InvocationTargetException: null" error we've seen many times.

Jenkins, retest this please

Test build #95915 has started for PR 22192 at commit 447c5e5.

Test build #95915 has finished for PR 22192 at commit 447c5e5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95915/
Test FAILed.

retest this please

Test build #95947 has started for PR 22192 at commit 447c5e5.

Test build #95947 has finished for PR 22192 at commit 447c5e5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95947/
Test PASSed.

Hi, just want to follow up on this and see if anyone has additional comments/questions/issues. Please feel free to ping me and I'll respond as soon as I can!

LGTM.

retest this please

Test build #96211 has started for PR 22192 at commit 447c5e5.

Test build #96212 has started for PR 22192 at commit 447c5e5.

Test build #96212 has finished for PR 22192 at commit 447c5e5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96212/
Test FAILed.

Test build #96211 has finished for PR 22192 at commit 447c5e5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96211/
Test PASSed.

Test build #96276 has finished for PR 22192 at commit f853fe5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96276/
Test PASSed.

Merged build finished. Test PASSed.

merging to master / 2.4.

why do we merge a new API to branch-2.4, when RC1 is already out?

This was discussed way before RC1 was cut. Not adding this to 2.4 makes the timeline for this API to be out way too long in the future, and we want people to try it out.


Project Integration Checkpoint

code to make Boss inflict damage (of random quantities) on the user
add player hp bar that decreases gradually throughout the 10 second timer
begin incorporating an inventory for the player
if the player defeats the boss, he is upgraded --> Matthew/Isabelle use put method to interact w/ data base

[ ] work on boss item --> if user defeats boss, the boss drops an item that they can add to their inventory
[ ] make edits/fix character selection
[ ] get character classes from backend data in character selection
[ ]


HEI-5 [FEATURE] Calc MDE

Description
This pull request introduces new functions to the statistical analysis module, specifically aimed at calculating the Minimum Detectable Effect (MDE) for unbalanced groups in both binomial and non-binomial contexts. The changes include the implementation of methods that handle the complexity of unbalanced sample sizes and provide a standardized output for easy interpretation.
Changes Made

Added __mde_unbalanced_non_binomial method for non-binomial data which calculates the MDE based on standard deviation and group sizes.
Added __mde_unbalanced_binomial method for binomial data which computes MDE using Cohen's d and fact conversion rates.
Created calc_mde_unbalanced_group as a public interface to calculate MDE depending on the data type (binomial or non-binomial).
Integrated detailed docstrings explaining each parameter and the method's purpose to aid in maintenance and future development.

Related Issues
No directly related issues, but this enhancement aligns with our ongoing efforts to expand the toolkit's capabilities in statistical analysis and experimental design.
Additional Notes
The implementation assumes that the input data is pre-validated and formatted appropriately for the type of analysis being conducted. Future updates may include more robust error handling and data validation.
Testing and Validation

Conducted unit tests covering both scenarios of binomial and non-binomial data.
Verified the correctness of the calculations against known benchmarks and case studies.
Ensured that the new methods do not adversely affect the performance of existing functionalities.

Performance Considerations

The new methods are computationally efficient, utilizing vectorized operations where possible.
Performance tests indicate minimal impact on overall processing time when integrating these functions into larger workflows.

Breaking Changes

There are no breaking changes in this update; the new functions are additions that do not modify existing interfaces or behavior.

Dependencies

This update does not introduce any new dependencies. It uses existing libraries already included in the project's requirements.

Merge Request Checklist

[x] Code follows project coding guidelines.
[x] Documentation reflects the changes made.
[x] Unit tests cover new or changed functionality.
[x] Performance and breaking changes have been considered.

Please check this function, integrate with old one. And we need one more tutorial for calc functions (idk maybe later)  @Dmatryus @VasilievaKA


Typo in Docs[Glossary]

Current State

enabled should be enables.
pesonal should be personal

i will like to work on fixing the issue :}

hey @captain-Akshay, can I work on this issue?

@ATREAY , thank you for your interest and enthusiasm. I appreciate that you didn't attempt to submit a pull request without asking first 😅 😂. However, I've already fixed this particular issue. I hope you find many other open issues to work on, and please feel free to ask about them!

Sure thing, @captain-Akshay! Just a quick request to close those issues you've already sorted out to keep things clear.

@ATREAY I'm currently awaiting the approval and merging of my pull request. Typically, once it's merged, the associated issue is promptly closed.


[AzureMonitorExporter] update unit test to inspect contents of sent telemetry

work in progress
Currently this test has a gap, it asserts that SOME telemetry was sent but not WHAT telemetry was sent.
This PR is to close that gap while we consider a better long term solution.

API change check
API changes are not detected in this pull request.

@rajkumar-rangaraj, renaming the file in this PR breaks the comparison. If needed, I can revert the rename and make that change in a follow up PR.


Human verification required.

Update, Captcha required.

Why username account always "NO NAME" and when i trying running bot not sending respon?

Why username account always "NO NAME" and when i trying running bot not sending respon?

You can find it in the register.py/e2ee.py.
Maybe it's because your config file or your bot.

How about human verification?

You can bypass human verification by using residential proxy for now.
We're trying to find a way to solve this problem ASAP.

Doneeeeee

Solved, Bypass captcha by using older version of line.

vertipikasi manusia di butuhkan
solusinya menggunakan line versi lama
tapi masalahnya sekarang line versi lama tidak bisa di gunakan apakah ada solusi lain..?


about tab

I think we should change the matching rule

I input 'echo xxx' then I press the Tab. we will find 'xxx' cleared.so I think it's unfriendly.

And I think the terminal will have more cue in the future, like: we can see some cue when press Tab after we input 'cd' in iTerm.

umm.. I'm not sure what you said ? Could you elaborate a bit further ? cc @jcgertig

###i mean i want to use TAB to get more infomation
like this:

when i press TAB, you can see many commands with 'l'

others:

i input 'echo hello', then i press TAB.  try it

Gotcha !! I will add this to my list (for V4). Thanks for the suggestion 😄

will be out in next release

new version is out 4.0.0


fix: Orchestrator worker crashes if accessing getLabelResolversAsync concurrently

Description
Remove promise.all when calling getLabelResolversAsync, it occasionally crashes the Orchestrator worker thread.
Exceptions were also not forwarded correctly, when exceptions occurred during build or warmup of Orchestrator, the process never ends since we never send a message back to the main thread. It's also not possible to send the error object in raw form, the process boundary prevents this.  So extract the message and stack property only and forward those.
Task Item
fixes #6666

Coverage increased (+0.03%) to 51.327% when pulling c0d9b4c3196845f309d804907e7329fe750c8c5f on tachou/fixOrchWorkerExceptionHandling into e5e5020bea3add62ad979ec19570a8e057d72495 on main.


marsyard terrain texture does not appear to load properly

Hi,
I was trying to look at using the marsyard2021 world for a project I am involved in, but I am having trouble getting the terrain to load properly. Everything seems to build fine, so all the deps are there, but when I launch marsyard2021 it results in the followings:

I am not too sure what the issue is, I've checked that the terrain is included in the world file - but it looks fine there. Any idea what might be causing this?

Did you get any errors?
You can try clearing the Gazebo heightmap cache files which often cause some weird bugs:
rm -rf ~/.gazebo/pagin

You can also try prebuild binaries from ROS distribution:
sudo apt install ros-noetic-leo-simulator

I did not get errors, but it looks like it was the heightmap cache files lol. Thanks for the help!


Expand explanation on how to use the interactive code editor

There lacks a clear set of instructions on how to open and use the code editor. A user might find their way into the editor if they have interacted with similar features before, but as stated on the Intro to C# index page:

These first lessons assume no prior knowledge of programming or the C# language.

The first mention of using the code editor is here: https://github.com/dotnet/docs/blob/master/docs/csharp/tutorials/intro-to-csharp/hello-world.yml#L21

Run the following code in the interactive window. To do that, type the following code block in the interactive window and click the Run button:

The interactive window is not visible at this point, and won't be until one presses a button labeled "Enter Focus Mode", which is not mentioned anywhere in this tutorial.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3d841900-8699-af9b-f879-c5cf9b54f21e
Version Independent ID: 2d85eae9-01e1-17af-b282-715ec3dc0dcb
Content: Hello World - Introduction to C# interactive C# tutorial
Content Source: docs/csharp/tutorials/intro-to-csharp/hello-world.yml
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for writing this up @thurstylark
I've added this to our October milestone to address.

This can be addressed in the same update as #13345

So the letter of the request was met... but the intent was to make things simpler for the new user.
Would something like this screenshot not be easier?  (matters of kerning and typography aside)

I just copied the code for the sidebar button and pasted it into the paragraph.  It works just like the first button - no js changes needed (good job on that, js dev!).
What about adding some minor narrative as well.. like:  Any time you see this button [green button here], clicking it will open the interactive window.
The current wording gives instruction/orders.  The proposed change teaches about the tools.


tsv-summarize, unique-count operator: avoid unnecessary string copies.

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   99.09%   99.09%
=======================================
  Files          16       16
  Lines        4440     4440
=======================================
  Hits         4400     4400
  Misses         40       40

Impacted Files
Coverage Δ

tsv-summarize/src/tsv-summarize.d
98.19% <100%> (ø)
:arrow_up:


watches the output directory and reloads on change

fixes #89

Works like a charm for me. I updated my psc-ide-vim plugin locally so the loading and refreshing etc is optimised, I'll publish it as soon as this is merged. Great work!

I still have to check if this notices new modules being added. We wouldn't want to require a restart on adding a module. Once that is confirmed I'll merge this in.

Sigh... So I've played around with this a bit. There are still 2 major issues left:

New Modules don't get added to the watcher.
So if you add a new file/module and make changes to it these changes don't get picked up by psc-ide

Adding an import to a module that has been loaded does not load the new dependency into the
server which means that you still have to manually import the new dependency/reload all
dependencies for the affected module

The first issue could be handled by restarting the filewatcher whenever a new module is loaded into the server.
For the second issue... We might want to just canonically load all modules that are not "dependencies" into the server.

I'll merge this in for now, because I believe I need to work on other parts of the codebase a bit to fix the remaining bugs. (Proper Logging, Threading System, Better error handling)
This still improves on the current situation and is a baseline which we can iterate on.


Migration Issue: Invariant violation: called markMigrationRolledBack on a database without migrations table.

1.37.0 has had it's migration script updated. Users will need to pull the latest version, then run the following commands to resolve the 02_migration failure.
yarn prisma migrate resolve --rolled-back "02_add_event_data"
yarn prisma migrate deploy
yarn check-db

If I run the first line, I get this error:
Error: Could not find a schema.prisma file that is required for this command.
You can either provide it with --schema, set it as `prisma.schema` in your package.json or put it into the default location ./prisma/schema.prisma https://pris.ly/d/prisma-schema-location

then I add the schema:
 yarn prisma migrate resolve --rolled-back "02_add_event_data" --schema=./db/postgresql/schema.prisma
then I get this error:
Prisma schema loaded from db/postgresql/schema.prisma
Datasource "db": PostgreSQL database "postgres", schema "public" at "db.smkoohqmotkuxozodbpt.supabase.co:5432"
Error: Invariant violation: called markMigrationRolledBack on a database without migrations table.
   0: migration_core::state::MarkMigrationRolledBack
           with migration_name="02_add_event_data"
             at migration-engine/core/src/state.rs:328

error Command failed with exit code 1.
Can you help me please?
Originally posted by @marc-on-github in https://github.com/umami-software/umami/issues/1393#issuecomment-1214698165

Can I ask what version of Umami you're upgrading from?  It looks like it might pre-date our prisma migration files as the error message is stating you have no migration history.
We tested this scenario and in your case, it might be as simple as running 1 commands.
yarn build-db
yarn check-db

thanks, now it works!


Add Symbol Clarification

The comment and note symbol on both the Unprivileged and Privileged manual are not correctly addressed. Looking at the Unprivileged version, in this image the "commentary" is explained in the introduction like this:

Whilst this is informative, it lacks context and appears somehow randomly in the middle of the introduction. In my opinion, even worse is the “note” symbol, which appears without any context and immediately explaining something right after the last picture.

Furthermore, I propose an approach on which there is a “Typographic convention” or “Notation convention” section that exists in all the other main ISA Manuals like ARM and Intel. I believe this section should be placed right between the end of the preface and the beginning of the introduction to enhance clarity for readers.

I'll await feedback on this proposal from @aswaterman before proceeding, as the current formatting matches the original LaTeX spec.

IMO, the only thing that's immediately actionable is that we are inconsistent about using TIP versus NOTE.  In the LaTeX spec, we only had one type of commentary section (as in, \begin{commentary}), but in the asciidoc spec, we use both, and the choice seems arbitrary.  It looks like we use TIP about 60 times and NOTE about 800 times, so I guess we should replace all of the TIPs with NOTEs.

Fwiw, I would agree with Andrew since there isn't a clear rhyme or reason to (or clear need for) this Tip vs. Note distinction.  Whatever semantic difference for any given Tip/Note shoudl be clearly expressed in the note itself.

We could really use three different kinds of categorization of the non-normative content:
NOTE: for non-normative clarifications
TIP: to convey hints for implementers
RATIONALE: to convey design rationale and why other options were discounted
And, ideally, in web form, display of these could be made optional.

I like Krste's suggestion.
But, as a first step, I recommend we change all of the TIPs to NOTEs, since my unscientific sampling indicates we are generally using TIP where we mean NOTE.  We can then recategorize NOTEs over time.

We'd have to add a custom admonition to get RATIONALE btw, AsciiDoc currently provides: NOTE, TIP, WARNING, IMPORTANT and CAUTION.

I like Krste's suggestion.
But, as a first step, I recommend we change all of the TIPs to NOTEs,
since my unscientific sampling indicates we are generally using TIP where
we mean NOTE. We can then recategorize NOTEs over time.

Sounds good all around.
And if we are going to have people making use of more than just NOTES, then
somewhere reasonably obvious there needs to be a definition or description
of when each classification is appropriate to use (especially if we are
also going to support and allow usage of WARNING, IMPORTANT and CAUTION).
Otherwise we're bound to have very inconsistent choices being made by
people between the available classifications.
Also, given this, do we want to provide such a relative plethora of choices
(i.e. NOTE, TIP, RATIONALE ,WARNING, IMPORTANT and CAUTION)?  I'd be fine
with just the first three.  (WARNING sounds like a form of NOTE; CAUTION
maybe sounds like a form of TIP, and IMPORTANT sounds like a form of NOTE.)
Greg

Thank you all so much for the feedback.
I definitely agree with @kasanovic that the terms "TIP" and "NOTE" can and should coexist, each with its distinct meaning. However, I believe @aswaterman's :

But, as a first step, I recommend we change all of the TIPs to NOTEs, since my unscientific sampling indicates we are generally using TIP where we mean NOTE. We can then recategorize NOTEs over time.

first approach gains even more traction when we also examine the privileged manual, Notably, the same "Introductory commentary" that appears as a "TIP" in the unprivileged manual is presented as a "NOTE" in the privileged version.

This observation further supports the idea of standardizing the terminology, at least initially, by converting all "TIP"s to "NOTE"s. This approach would bring consistency between the privileged and unprivileged manuals, while still allowing for future refinement and recategorization. Moreover, if it is decided to proceed with a review of all "TIP"s and "NOTE"s to ensure proper categorization, I would be more than happy to contribute to this effort.
Answering to @gfavor I totally agree with your opinion, I believe the description should be somewhere clear in the beggining of the manual, and I also tend to agree with the first three sounding better as you described them.

Adding these details to the dev guide - https://github.com/riscv/docs-dev-guide
After we agree on typographical conventions, then we definitely need to add them to intros of main docs!  I'll post in doc-sig mailing channel.


Optimize a bit, add README

In main(), an array of structures is declared, each worker thread is passed one element of that array, containing the specification of the work to be done and a "result" variable to store the result.
Initially each thread was using "result" from the passed struct during its sum of squares computations, reading and updating it every iteration of the computation loop. This seemed to create a bottleneck, such that it was taking about as long for two threads to do the same work vs a single thread (things got a bit better with more worker threads).
The bottleneck above was relieved by having each thread allocate a local "result" var to use when doing computations. With this change, it takes about half the time with two worker threads vs one.


Slice integration for DataFrame

This PR brings with it a way to retrieve data of DataFrame as Slice and assign a Slice back to DataFrame
cc/ @thewilsonator, sorry this PR came a little later than expected. Sorry about that :disappointed:

Looking very nice! No problem on the timing, your health is more important.


ComplMatchIns doesn't work after multibyte chars

Problem:  ComplMatchIns doesn't work after multibyte chars.
Solution: Use (ptr - line) instead of wlv.col.

thanks. I found this too. But I got COVID-19 again. So I came late.

thanks. Please watch out and get better soon!


Compatibility with Xiaomi (Xiaofang )cam?

This looks really great. I have a XiaoFang WiFi Camera..
Any idea if your firmware is compatible with this hardware?

I'm not sure, I don't have a xiaofang camera to try this out. Please try it and let me know if it works.

Actually, i don't think this will work with Xiaomi device as they use different software. This hack is based on Wyze firmware.


Could you use this optimized version of your GIF?

Hey @williamxu7 @deepaksidhu @nichowu @zmerpez  ! Would you mind using this optimized version of your gif? The dashboard is having some performance issues and I am thinking it might be related to all the gifs. It is still pretty good quality and 4 MB instead of 22 MB. I also made it quite a lot shorter (20s instead of 55s), so you can keep your original one in this repo if you want, just make sure to put this one ahead of it in alphabetical order (or in the repo root) Sorry for the trouble!

Hi @joelostblom, yes! I just uploaded this optimized version GIF and replaced the old one. Hopefully it works. Thank you very much for the master dashboard showcase :)

Hi @joelostblom thank you for the feedback. Appreciate you optimizing the GIF. So the previous GIF was impacting the dashboard's performance through the Heroku app? Thanks again.

Thank you! I noticed performance was a bit slow on chrome after several groups added gifs so I thought this might be. Not 100% that was the case but it seems better now that I sent out a few optimized gifs.


Retaining memoization when passing props to different component instances.

The docs state that in order to share a selector across multiple component instances while passing in props and retaining memoization, each instance of the component needs its own private copy of the selector. Does this apply to instances of different components using the same selector?
selectors.js
import {createSelector} from 'reselect';
getData = (state, props) => state.data[props.id];
// additional question: is reselect worth using for such a simple selector?
export const getDataForId = createSelector(getData, data => data);

foo.js
import {getDataForId} from './selectors';
const mapStateToProps = (state, props) => ({
  dataForId: getDataForId(state, props),
});
class Foo extends Component {...}
export default connect(mapStateToProps)(Foo);

bar.js
import {getDataForId} from './selectors';
const mapStateToProps = (state, props) => ({
  dataForId: getDataForId(state, props), // uses same selector as Foo
});
class Bar extends Component {...}
export default connect(mapStateToProps)(Bar);

index.js
...
<Foo />
<Bar />
...

Yes, it does - see my post Idiomatic Redux: Using Reselect Selectors for Encapsulation and Performance for examples.

I wish I found that article 💯  sooner! ⬆


[AVM Module Issue]: Deploy policy assignments to subription or resource group target scope

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
I'm not sure
Module Name
avm/ptn/authorization/policy-assignment
(Optional) Module Version
No response
Description
Hello,
as far as I see it´s not possible to deploy a policy assignment on sub or rg level if the targetscope for the deployment is set to "subcription" or "resourcegroup" because the target scope for the policy-assignment pattern modules are set to "managementgroup".
In the CARML project there were modules for deployment to specific targetscopes (https://github.com/Azure/ResourceModules/tree/main/modules/authorization/policy-assignment)
Is it planned to implement this in AVM too ?
(Optional) Correlation Id
No response

@jensdiedrich - Thanks for reaching out. You can still deploy at the Resource Group and subscription scopes. There is a directory called modules that contains the modules for the management group, subscription and resource group deployments. You can look at the deployment tests for examples on how to deploy to subscriptions and resource groups.

@arnoldna - Thanks for lighting me up, didn´t see the separate module because they´re not medntioned in the docs as far as I can see ?
Is it true that they can´t be referenced from the Public BRM registry ?

@arnoldna The solution you give is not good because the tests have targetScope = 'managementGroup'. I've try several time to make it work with a targetScope = 'subscription' and that dont work. Is there a way to call the module from the module directory from the public BRM registry ? If no it's a problem and the issue is not done.

@AntoVie  - See this existing issue for further information. https://github.com/Azure/bicep-registry-modules/issues/2688#issuecomment-2255459066


Corrected the email address in contributors list

Hello @waldekmastykarz , based on our discussion, submitting this PR to add the correct email address in the contributors list.

Awesome! We'll merge it right away 👍

Merged manually. Thank you! 👍


engine, driver and proposer always restart

Describe the bug
docker ps

docker logs simple-taiko-node-taiko_client_driver-1

docker logs simple-taiko-node-taiko_client_proposer-1

docker logs -f simple-taiko-node-l2_execution_engine-1

my vps system: centos7.9
Steps to reproduce
Steps to reproduce here.
Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

@huangsiyuan924 https://github.com/bnb-chain/bsc/issues/1521#issuecomment-1521025294 this seems like a similar thing, could you try this fix and retry?

docker logs -f simple-taiko-node-l2_execution_engine-1

Now the geth container is still restarting, and the error is: invalid value "shielded-expedition.88f17d1d14" for flag -networkid: parse error

@huangsiyuan924 bnb-chain/bsc#1521 (comment) this seems like a similar thing, could you try this fix and retry?

Now the geth container is still restarting, and the error is: invalid value "shielded-expedition.88f17d1d14" for flag -networkid: parse error


Alias Scopy.forAll to Scopy.for.all

The Scopy.forAll method should be aliased to Scopy.for.all as an alternative for those that prefer it. Not sure what I prefer yet, but we'll need to decide on the primary that will be documented in the API section of the README, although a reference to the alias should also be mentioned.

Going to go with Scopy.for.all as the primary method and support Scopy.forAll as an alias.


Patching home-manager modules?

I'd like to use modules provided by home-manager, but make some of my own tweaks.
For example, I'd like to not add kitty to home.packages when I have programs.kitty.enabled = true since I'm on macOS and I prefer to use kitty from Homebrew Cask.
I'd like to use patches to avoid vendoring the modules entirely. However my attempts so far have not worked. home-manager seems to somehow ignore the modified source code I've provided.
Am I doing something wrong here? I don't understand why home-manager isn't using my patched version of the modules. Or is there a better way of making these kinds of modifications to modules?

Overlay to modify the home-manager derivation from Nixpkgs to use patched source code
(If there's a better way of applying patches to source code and persisting that patched source code in the Nix store, I'd love to know)
self: super:

{
  home-manager =
    let
      originalSource =
        super.fetchFromGitHub {
          name = "home-manager-source";
          owner = "rycee";
          repo = "home-manager";
          rev = "7f7348b47049e8d25fb5b98db1d6215f8f643f0d";
          sha256 = "1s8j8h42k354xzwlqizbzxlqvsagx7yrxl20qfxgxmx522ajw63p";
        };
      patchedSource =
        super.stdenv.mkDerivation {
          name = "home-manager-source-patched";
          src = originalSource;
          phases = [ "unpackPhase" "patchPhase" "installPhase" ];
          installPhase = "cp -r . $out";
          patches = [
            ../patches/home-manager-kitty.patch
          ];
        };
    in
      super.home-manager.overrideAttrs (old: {
        version = "HEAD";
        src = patchedSource;
      });
}

Patch to remove kitty from home.packages
patches/home-manager-kitty.patch
diff --git a/modules/programs/kitty.nix b/modules/programs/kitty.nix
index 313a0bf..6bd651b 100644
--- a/modules/programs/kitty.nix
+++ b/modules/programs/kitty.nix
@@ -73,7 +73,7 @@ in {
   };

   config = mkIf cfg.enable {
-    home.packages = [ pkgs.kitty ] ++ optionalPackage cfg.font;
+    home.packages = optionalPackage cfg.font;

     xdg.configFile."kitty/kitty.conf".text = ''
       # Generated by Home Manager.

Nix shell made for running a pinned home-manager with specific settings
let
  pkgs = import ./nixpkgs.nix { overlays = import ./overlays; };

in
  pkgs.mkShell {
    buildInputs = with pkgs; [ home-manager ];

    shellHook = ''
      export NIX_PATH="nixpkgs=${pkgs.path}:nixpkgs-overlays=./overlays/default.nix:home-manager=${pkgs.home-manager.src}"
      export HOME_MANAGER_CONFIG="./home.nix"
    '';
  }

It'll be tricky to patch HM given the way the package in Nixpkgs is made. I think the easiest option you have available is to override the kitty package by an empty one. You can try putting
nixpkgs.overlays = [
  (self: super: { kitty = pkgs.runCommandLocal "no-kitty" {} "mkdir $out"; })
];

in your HM configuration.

There are some other modifications I'd like to make, which would definitely require patching; I just gave the kitty one as an example.
I'm also able to patch Nixpkgs in the same way I'm patching home-manager above, or I could or override home-manager in Nixpkgs with the home-manager from this repo?

I see what you mean now, how the way Nixpkgs packages home-manager makes overriding src tricky. The old path is already baked into their installPhase. Thanks for the pointer.
I was able to get my patches applied successfully by copy pasting the installPhase from Nixpkgs into my overlay, so that I could change what src it was using. Unless there's a better way of changing home-manager modules, I'm going to go with this solution.


ERROR: GLEW initalization error: Missing GL version

hello, I found that I could run python robosuite/scripts/collect_human_demonstrations.py but when I run python scripts/trainer.py --env stack .Error appeared as follows：

I had put export LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libGLEW.so in my .bashrc ,but It did not work.

Do you know why? I think my GLEW is ok,because I can run this code without any problem.
code:
import gym   // test for glew
env = gym.make('Ant-v2')
env.reset()
for _ in range(1000):
env.render()
a = env.action_space.sample()
s, r, d, _ = env.step(a) # take a random action
print(a,s,r,d)
env.close()

I'm not entirely sure why that export statement in your bashrc did not resolve the issue. Perhaps this thread provides more answers: https://github.com/openai/mujoco-py/issues/268
If not, maybe you can try running the experiments without any rendering at all. To do this:

Add a line in the env_kwargs to disable offscreen rendering: has_offscreen_renderer=False
Run the experiment with the --no_video flag: python scripts/trainer.py --env stack --no_video

I'm not entirely sure why that export statement in your bashrc did not resolve the issue. Perhaps this thread provides more answers: https://github.com/openai/mujoco-py/issues/268
If not, maybe you can try running the experiments without any rendering at all. To do this:

Add a line in the env_kwargs to disable offscreen rendering: has_offscreen_renderer=False
Run the experiment with the --no_video flag: python scripts/trainer.py --env stack --no_video

I encountered the same issue:
ERROR: GLEW initalization error: Missing GL version
when I run
python scripts/train.py
I would appreciate it if someone can point out the solution to it!

See https://github.com/ARISE-Initiative/robosuite/issues/114#issuecomment-811295554 and  https://github.com/openai/mujoco-py/issues/390#issuecomment-525385434
Adding the following lines after line 272 on the robosuite.environments.base.py (maple branch) solved my issue.
                from mujoco_py import GlfwContext
                GlfwContext(offscreen=True)

Nice find @aaa1234zzz! @1172534699 curious if this resolves the issue on your end?

Nice find @aaa1234zzz! @1172534699 curious if this resolves the issue on your end?

Thanks! I am very grateful! It works!

And could you tell me what is the version of your GPU and CUDA?

I'm using a Titan RTX gpu with the following specs:
NVIDIA-SMI 470.103.01   Driver Version: 470.103.01   CUDA Version: 11.4

I am using NVIDIA GeForce RTX 3080 Ti with
NVIDIA-SMI 470.103.01   Driver Version: 470.103.01   CUDA Version: 11.4

I encountered the same problem. I found ARISE-Initiative/robosuite#114 (comment) and openai/mujoco-py#390 (comment) are pretty helpful.
Adding the following lines after line 272 on the robosuite.environments.base.py (maple branch) solved my issue.
                from mujoco_py import GlfwContext
                GlfwContext(offscreen=True)

after doing this，i run "python maple/scripts/train.py --env=lift --label=lift1 --no_gpu ", but get the result with nothing in "progress.csv" as follow:


Spelling mistake

"You can access a ontrol on a form by..." should read:
"You can access a control on a form by..."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3ecdcb41-83bb-fce7-f3a4-049857ffcf40
Version Independent ID: b7958bf5-2821-e2f9-6f44-ab215253f013
Content: getControl (Client API reference) in Dynamics 365 Customer Engagement
Content Source: ce/developer/clientapi/reference/controls/getControl.md
Service: crm-online
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

@click-here thanks for notifying. It will be corrected.


jarsigner: Certificate chain not found for: ***.  *** must reference a valid KeyStore *** entry containing a private *** and corresponding public *** certificate chain.

Getting build failure. Any idea?
- name: Sign Release
        uses: ilharp/sign-android-release@v1
        with:
          releaseDir: build/app/outputs/bundle/release/
          signingKey: ${{ secrets.PIN_PASS_SIGNING_KEY }}
          keyAlias: ${{ secrets.PIN_PASS_ALIAS }}
          keyStorePassword: ${{ secrets.PIN_PASS_KEY_STORE_PASSWORD }}
          keyPassword: ${{ secrets.PIN_PASS_KEY_PASSWORD }}

Run ilharp/sign-android-release@v1
  with:
    releaseDir: build/app/outputs/bundle/release/
    signingKey: ***
    ***Alias: ***
    ***StorePassword: ***
    ***Password: ***
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Zulu_jdk/11.0.21-9/x64
    FLUTTER_ROOT: /opt/hostedtoolcache/flutter/stable-3.16.2-x64
    PUB_CACHE: /opt/hostedtoolcache/flutter/stable-3.16.2-x64/.pub-cache
Signing file(s) in build/app/outputs/bundle/release with *** ***...

Now sign 1 file(s):
- app-release.aab

[1/1] app-release.aab
  Signing AAB file.
  /opt/hostedtoolcache/Java_Zulu_jdk/11.0.21-9/x64/bin/jarsigner -***store *** -storepass *** -signedjar build/app/outputs/bundle/release/app-release-temp.aab -***pass *** build/app/outputs/bundle/release/app-release.aab ***
  jarsigner: Certificate chain not found for: ***.  *** must reference a valid KeyStore *** entry containing a private *** and corresponding public *** certificate chain.
Error: Error: The process '/opt/hostedtoolcache/Java_Zulu_jdk/11.0.21-9/x64/bin/jarsigner' failed with exit code 1
Error: Error: The process '/opt/hostedtoolcache/Java_Zulu_jdk/11.0.21-9/x64/bin/jarsigner' failed with exit code 1

The most likely cause of this problem is that the inputs you provided are incorrect. Please check all secrets again, especially keyAlias. If you don't know the keyAlias of your KeyStore, you can find it using the method mentioned here:
keytool -keystore formconnect.keystore -list -v

Thanks for quick reply. issue resolved!


Counts objects should have expectation value method

What is the expected enhancement?
There is no way that I can find to compute expectation values from sampled distributions in the core Qiskit library.
The StateVector and DensityMatrix states in quantum_info have expectation_value methods.  Counts objects, and other related distribution classes, should have the same to be consistent and fix the above gap.
Alternatively, or together, operators could have similar methods that take the distributions or states.

I may well be misunderstanding this issue, but what output would you expect to get from a counts dictionary of {0: 50, 1: 50} for an operator of X?  I'd get those counts from either |+> or |-> (or whatever combination), so I'm not sure how we return something meaningful.

I should be able to compute the expectation value of a string or operator of diagonal operators, eg IZZZ11Z.

There is a code for calculating expectation value and stddev from measurement probabilities here:
https://github.com/Qiskit/qiskit-terra/blob/c318725d679b0eb3aa8874fb9755fa0567c5e94b/qiskit/result/mitigation/utils.py#L35

I think that we didn't want to add this expectation value method to the results classes (Counts etc.) since it should be calculated more efficiently using the Estimator class.

@ShellyGarion I am not sure why one does not want this?  Count are an approximation of the diagonal of the corresponding density matrix for the state vector at the end of a circuit.  Already in Qiskit I can get the expectation value from these related objects, eg:

op = Pauli('ZZZZ')

state_vec = Statevector(qc
state_vec.expectation_value(op)

dm = DensityMatrix(qc)
dm.expectation_value(op)

both work.  The ability to do so from Counts is a natural (and important) extension of what is already there.
It is also curious as to why you think that it is more efficient to compute an expectation value in the Estimator?  The computational overhead is likely the same given that the computation is identical.  Also using the Estimator directly I cannot do things like compute expectation values and plot the corresponding distribution.

Hmm, I do not think I am advocating for the exact same, but rather a diagonal operator can be passed.  If it is not diagonal then raise.
The measure_x and the like are just applying post-rotations that diagonalize Pauli-strings that are not diagonal in the computational basis, eg XZX -> ZZZ.  This is required for executing on hardware.

The Counts type is not documented as specifically containing the results of Z measurements

By convention, the computational basis is the basis that defines the Z-direction (diagonalizes Z).

Counts wouldn't be able to tell that logically it's the X measurement on that qubit that's diagonal

Counts would not know.  You would have rotated the x-component of the qubit in question to the Z-direction and measured.  This makes sense only in combination with a given operator (which you also diagonalize X -> Z in this process)
What is being asked for here is really nothing groundbreaking, but rather basic functionality that we are missing.  It did exist for some item here: https://qiskit.org/documentation/stubs/qiskit.ignis.mitigation.expectation_value.html#qiskit.ignis.mitigation.expectation_value but now is deprecated (and was hard to find and not scalable)

There already exists in Terra a mitigated expectation value calculation (correlated and local readout mitigation):
https://qiskit.org/documentation/stubs/qiskit.result.CorrelatedReadoutMitigator.expectation_value.html
https://qiskit.org/documentation/stubs/qiskit.result.LocalReadoutMitigator.expectation_value.html
So, would you suggest to add a similar API to the Counts class?
Namely, transfer the following function from utils to the Counts, call it expectation_value and update its API:
https://github.com/Qiskit/qiskit-terra/blob/c318725d679b0eb3aa8874fb9755fa0567c5e94b/qiskit/result/mitigation/utils.py#L35

I was originally hesitant about this since it requires an assumption that Counts are generated from Z measurements. But thinking more about it, I think that is an underlying assumption in both Qiskit and OpenQASM? Maybe not documented as extensively as it should, but when we write "measure" in either Qiskit or OpenQASM, it means a measure-z. If that is the case, and Counts is generated from a bunch of measures, then I think it makes sense for it to compute diagonal expvals directly.
My only doubt is: what if a backend has a native measure-x instruction (so they don't use H to rotate into Z basis)? Don't they still want to represent their experiment result with Counts? In that case the extra assumption is broken. But I don't know how to represent a native measure-x in Qiskit anyway since (contrary to unitary gates) we cannot provide a definition for it. So I think de-facto assumption of Z-basis measurement stands.

Ok maybe we should keep open the possibility that in the future there will be other POVMs (measure-x and measure-y included) that would want to write to cbits. In that case, I think Counts should remain agnostic to basis, since it's just a tally of cbits. I think a utility function that does provide a "z-counts --> diagonal-expval" is the safest way to go for now. In the future if the POVMs that were used to populate Counts were somehow saved, then we can make this more generic and potentially calculate other observables as well.

So in this case should we write a special utility function for expectation value or enhance the Estimator class (which is more general)?

I am good where ever this ends up.  The current state of affairs is that I continuously have to show people how to compute this themselves or point to M3 that has a routine to do this.  Qiskit having its own routine would thus be most welcome regardless of how it is done.
It would be curious to see how Counts would be able to be agnostic to differing choices of computational basis per qubit without placing all of the burden on the user to remember.  I would think one would need to keep track of what representation is used in order for anything to make sense.

It is nice to make it as utility functions. In addition, it would be useful to take not only Counts but also ProbDistribution and QuasiDistribution.
It is a slightly closer issue: I also thought it might be useful to have a Mitigator that does not mitigate.

Closing in favor of #8465 8465


Include more info in $PSVersionTable, like .NET version

Summary of the new feature / enhancement
Would be great if $PSVersionTable could include some more relevant information to its' environment. For instance:
OS agnostic

[New key] .NET version built upon
[New key] OS Architecture (x64, x86, ARM, ARM64 etc.)
[New key] Process architecture (x64, x86, ARM, ARM64 etc.)

Windows

[Existing key] Update "OS" key to include build number (cumulative)
[Existing key] Update "OS" key to include edition (Home / Pro / Enterprise)

If someone can't get BitLocker cmdlets to work, but running Windows 10 Home.. :)

I'm thinking suggested additions in addition to being useful for end users, might be helpful when adding $PSVersionTable to issues on GitHub too, to give some more context out of the box.
Proposed technical implementation details (optional)
Add more keys and more info to existing keys, to the hashtable that is $PSVersionTable.

I've also wondered why GitCommitId doesn't actually have a real commit ID? Seems to just mirror PSVersion.

@ArmaanMcleod For the stable and preview versions, the commit id is the tag for the release, which happens to be the same as PSVersoin. If you are using a daily build, you will see the commit id as in hash code.

The WG discussed this and we're concerned that the $PSVersionTable could grow to be unwieldy (and we would like to keep PSVersionTable from trying to have everything).  However, we do see the need for diagnostic tools which collect this information (and perhaps more). We would be happy to entertain proposals for additional tools to provide that.


TS-4938: Avoid crashes due to NULL vc dereferences.

Potentially this could fix TS-5046 SEGV HttpSM::tunnel_handler_server(int event, HttpTunnelProducer *p)
cherry picked from commit 784e7cc8a91b48b93b57cad27ba403684880969f
Conflicts:
proxy/http/HttpSM.cc
proxy/http/HttpServerSession.h

[approve ci]
@shinrich can you give this a look over and check to see if you think it looks ok as a backport?
Thanks.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1221/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1114/ for details.

Looks good to me.  One minor comment, but it was an issue with the original change.  So I think the backport is good to go.


Consider ArduinoBLE for ESP32

Now ArduinoBLE supports esp32:
https://github.com/arduino-libraries/ArduinoBLE/releases/tag/1.3.2
Consider aligment

Done: https://github.com/vovagorodok/ArduinoBleOTA/commit/64f84c041362d3ba20a425f92b92eeca033a00ac


Site down?

The website https://cors.io appears to be down.

Yes, I believe it is because pierece made it possible for you to host your own proxy. Just follow the steps on the README and you should be ready to go.
@pierce403 do you plan to bring the website up again ?

Just came here to check the same. Looks like it's been a while now @pierce403 - https://twitter.com/nektro/status/1143950416062926848
Totally don't expect you to support this - but can you confirm there's no plans to keep this going?


Integers vs floats in categorical features in LGBMRegressor

Description
Hi there,
I'm having an issue with the LGBMRegressor model and its native usage of categorical features. The documentation suggests that categorical features should be encoded as integers. However, once the model has been trained, it produces the same predictions regardless of whether I pass a pandas dataframe with integers or a numpy array with floats.
I'm unsure if the model is treating the categorical features correctly since, in a categorical context, category 1.0 is different from category 1. Shouldn't the model recognize 1.0 as a separate category and produce different predictions based on this?
Thanks a lot for your help
Reproducible example
from lightgbm import LGBMRegressor
import pandas as pd
import numpy as np

# Data
# ======================================================================================
y = pd.Series(np.random.normal(size=50))
X = pd.DataFrame({
    'col_1': pd.Series(np.random.normal(size=50), dtype=float),
    'col_2': pd.Series(np.random.choice([1, 2, 3, 4], size=50), dtype='category')
})
X.head(2)

# Model
# ======================================================================================
model = LGBMRegressor(categorical_features='auto')
_ = model.fit(y=y, X=X)

# Predict using a pandas dataframe with category
# ======================================================================================
predictions_1 = model.predict(X=X)
print(predictions_1)

# Predict using a numpy array with float values
# ======================================================================================
X_float = X.to_numpy()
print(X_float.dtype)
predictions_2 = model.predict(X=X_float)
print(predictions_2)

# Check predictions are equal
# ======================================================================================
np.testing.assert_array_equal(predictions_1, predictions_2)

Environment info
lightgbm version: 3.3.5
Command(s) you used to install LightGBM
pip install lightgbm

Additional Comments

Hey @JoaquinAmatRodrigo, thanks for using LightGBM.

However, once the model has been trained, it produces the same predictions regardless of whether I pass a pandas dataframe with integers or a numpy array with floats.

If you trained the model with categorical features LightGBM stores which columns were categorical and tries to reapply their encodings https://github.com/microsoft/LightGBM/blob/1f1ed5b44fed607c45102188c804fd2b00eb8f0e/python-package/lightgbm/basic.py#L684
but the C API expects a single data type array to compute the predictions, so after the encodings have been applied everything is cast to either float32 or float64
https://github.com/microsoft/LightGBM/blob/1f1ed5b44fed607c45102188c804fd2b00eb8f0e/python-package/lightgbm/basic.py#L1064-L1067
So by passing it directly the array you're skipping that preprocessing. It's important to note that in order to get the exact same predictions the float array must be encoded correctly, e.g. if your possible values are [10, 20, 30] they'll be encoded as [0, 1, 2], and so if you pass [10.0, 20.0, 30.0] they'll be treated as missing categories (categories LightGBM didn't see during training) and will probably yield different predictions.
Please let us know if this helps.


Inconsistent use of rule + button

Just noticed something.
I was looking to add a rule. I kept looking for the + button in the middle of the screen which is where it is when there are no rules.
Once you have created a rule the button switches to lower right and loses the help tag.
It's cosmetic as I know it works - just frustrating when you are learning your way round and things do not appear where you expect them. You start thinking you have missed something !
Keeping things like a + button in the same place where possibly just helps consistency (I accept I could just be getting old !)

Hi John,
Can you please use our forum for discussions (https://forum.opnsense.org/ )? Too many questions in our issue tracker make it quite difficult to prioritize the actual work.
Through the rest of our interface all actions are at the bottom right of the grid, the note is only an extra (which some people find quite useful).
Cheers,
Ad

I'm not really asking a question but pointing out a flaw in the UI....
I can talk about it all you want in the forums but would it get changed (which personally I think it should be) ? I agree the note is useful, but the button position is inconsistent.

ok, what is your proposal here then?

Something like this for every rule on every page so you have the consistent + button to the right.
Don't make the + in the centre message a link - you always have to click the button at right to add a rule.

This is a very rough stab at hacking the code - I can't quite get the columns right but you will get the idea
root@OPNsense:/usr/local/www # diff -ruN firewall_rules.php.orig firewall_rules.php
--- firewall_rules.php.orig	2016-09-05 14:19:43.236704000 +0200
+++ firewall_rules.php	2016-09-05 14:35:31.777647000 +0200
@@ -625,17 +625,23 @@
                   if (!$interface_has_rules):
 ?>

-
+

                 <?php if ($selected_if == "FloatingRules"): ?>
                       <?=gettext("No floating rules are currently defined."); ?>

+		       <?=gettext("Click the + button to add a new rule");?>
+		        <a href="firewall_rules_edit.php?if=<?=$selected_if;?>" class="btn btn-default btn-xs" data-toggle="tooltip" title="<?=gettext("add new rule");?>">
+
+
                 <?php else: ?>
                       <?=gettext("No rules are currently defined for this interface"); ?>

                       <?=gettext("All incoming connections on this interface will be blocked until you add pass rules."); ?>

+		       <?=gettext("Click the + button to add a new rule");?>
+		        <a href="firewall_rules_edit.php?if=<?=$selected_if;?>" class="btn btn-default btn-xs" data-toggle="tooltip" title="<?=gettext("add new rule");?>">
+
+
                 <?php endif; ?>
-                      <?= sprintf(gettext("Click the %s button to add a new rule."),
-                                  '')
-                      ?>
+

               <?php else: ?>
@@ -656,7 +662,7 @@
                         endforeach;?>
                       </select>

-
+                    <?=gettext("Click the + button to add a new rule");?>

                       <a type="submit" id="move_<?=$i;?>" name="move_<?=$i;?>_x" data-toggle="tooltip" title="<?=gettext("move selected rules to end");?>" class="act_move btn btn-default btn-xs">

More like this

To be honest, we might as well ditch the "Click the +..." completely if we move it over to the same area.... We're not trying to explain other grids in the system either.
How about leaving it like it was and un-hide the bottom row?

Yup - does it for me if it is easier. Let me know if you have a patch to want me to try.

ok, here it is https://github.com/opnsense/core/commit/9503d722d95f6c697e43779d6a980b6bb737b008

Looks good :-) Personally I'd keep the nice little + icon as an indicator but lose the clickable URL.  You are trying to push people to use one button in the same place and be consistent.
But it looks more sensible now.

ok, I don't have a preference here, so let's stick to your plan and change it for " Click the [+] button to add a new rule. ". I will close the issue on commit.