spp_server example question/issue (IDFGH-9207)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
When running the example code for the spp_server under Nimbke BLE, I receive an error when a device is disconnected and a notification is sent.
Once a device disconnects, and I send a notification, I get error #7 for the disconnected device notification. (Other connected devices receive the notification OK)
I see an array is made to keep track of the connected devices
uint16_t connection_handle[CONFIG_BT_NIMBLE_MAX_CONNECTIONS];
and that array is populated when a device connects:
connection_handle[event->connect.conn_handle - 1] = event->connect.conn_handle;
The connection never gets deleted from the connect_handle array on disconnect.
What is the proper way to remove the particular connection_handle when a device disconnects so that error #7 is not thrown when sending notifications.
Thanks!

Hi @bheestandLMT ,
Can you tell me on which chip you are facing this issue?
After disconnecting with one device, the connection_handle array is not being updated and while sending notifications it's giving error as the connection is not present.
Can you try these two things:

In disconnect event, set connection_handle[event->connect.conn_handle - 1] as -1
Before sending notifications, add a check that if connection_handle[event->connect.conn_handle - 1] == -1 don't send the notification.

If the above doesn't work, can you please share the error logs with us?
Thank You.


Escuela da vinci added

@Ignaciomode First stage of verification passed, official domain for Escuela de arte multimedia Da vinci is davinci.edu.ar as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@Ignaciomode Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


NameError: name 'PerCharacter' is not defined

master のコードにて、 PerCharacter クラスが見えていないようです。
init.py には定義されていますが。。。？？
IkaLog は止まってはいませんが文字認識機能が全滅中。
Exception occured in Udemae recoginization.
Traceback (most recent call last):
  File "/Users/hasegaw/work/IkaLog_github/ikalog/scenes/result_detail.py", line 280, in analyze_entry
    'img_score']).upper()
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 164, in match
    samples = self.find_samples(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 127, in find_samples
    characters = self.extract_characters(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 109, in extract_characters
    x_cutter = PerCharacter()
NameError: name 'PerCharacter' is not defined

再現方法
Takeshis-MacBook-Pro:IkaLog_github hasegaw$ python3 test/ResultDetail.py screenshots/ikabattle_20150825_2112.png
start model.train 876
done model.train
Loaded weapons recoginization model.
Loaded number recoginization model.
Loaded udemae recoginization model.
Exception occured in K/D recoginization.
Traceback (most recent call last):
  File "/Users/hasegaw/work/IkaLog_github/ikalog/scenes/result_detail.py", line 288, in analyze_entry
    'img_rank'])
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 174, in match_digits
    return int(self.match(img))
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 164, in match
    samples = self.find_samples(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 127, in find_samples
    characters = self.extract_characters(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 109, in extract_characters
    x_cutter = PerCharacter()
NameError: name 'PerCharacter' is not defined

Exception occured in K/D recoginization.
Traceback (most recent call last):
  File "/Users/hasegaw/work/IkaLog_github/ikalog/scenes/result_detail.py", line 288, in analyze_entry
    'img_rank'])
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 174, in match_digits
    return int(self.match(img))
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 164, in match
    samples = self.find_samples(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 127, in find_samples
    characters = self.extract_characters(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 109, in extract_characters
    x_cutter = PerCharacter()
NameError: name 'PerCharacter' is not defined

Exception occured in K/D recoginization.
Traceback (most recent call last):
  File "/Users/hasegaw/work/IkaLog_github/ikalog/scenes/result_detail.py", line 288, in analyze_entry
    'img_rank'])
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 174, in match_digits
    return int(self.match(img))
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 164, in match
    samples = self.find_samples(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 127, in find_samples
    characters = self.extract_characters(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 109, in extract_characters
    x_cutter = PerCharacter()
NameError: name 'PerCharacter' is not defined

Exception occured in K/D recoginization.
Traceback (most recent call last):
  File "/Users/hasegaw/work/IkaLog_github/ikalog/scenes/result_detail.py", line 288, in analyze_entry
    'img_rank'])
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 174, in match_digits
    return int(self.match(img))
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 164, in match
    samples = self.find_samples(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 127, in find_samples
    characters = self.extract_characters(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 109, in extract_characters
    x_cutter = PerCharacter()
NameError: name 'PerCharacter' is not defined

Exception occured in K/D recoginization.
Traceback (most recent call last):
  File "/Users/hasegaw/work/IkaLog_github/ikalog/scenes/result_detail.py", line 288, in analyze_entry
    'img_rank'])
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 174, in match_digits
    return int(self.match(img))
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 164, in match
    samples = self.find_samples(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 127, in find_samples
    characters = self.extract_characters(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 109, in extract_characters
    x_cutter = PerCharacter()
NameError: name 'PerCharacter' is not defined

Exception occured in K/D recoginization.
Traceback (most recent call last):
  File "/Users/hasegaw/work/IkaLog_github/ikalog/scenes/result_detail.py", line 288, in analyze_entry
    'img_rank'])
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 174, in match_digits
    return int(self.match(img))
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 164, in match
    samples = self.find_samples(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 127, in find_samples
    characters = self.extract_characters(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 109, in extract_characters
    x_cutter = PerCharacter()
NameError: name 'PerCharacter' is not defined

Exception occured in K/D recoginization.
Traceback (most recent call last):
  File "/Users/hasegaw/work/IkaLog_github/ikalog/scenes/result_detail.py", line 288, in analyze_entry
    'img_rank'])
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 174, in match_digits
    return int(self.match(img))
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 164, in match
    samples = self.find_samples(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 127, in find_samples
    characters = self.extract_characters(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 109, in extract_characters
    x_cutter = PerCharacter()
NameError: name 'PerCharacter' is not defined

Exception occured in K/D recoginization.
Traceback (most recent call last):
  File "/Users/hasegaw/work/IkaLog_github/ikalog/scenes/result_detail.py", line 288, in analyze_entry
    'img_rank'])
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 174, in match_digits
    return int(self.match(img))
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 164, in match
    samples = self.find_samples(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 127, in find_samples
    characters = self.extract_characters(img)
  File "/Users/hasegaw/work/IkaLog_github/ikalog/utils/character_recoginizer/character.py", line 109, in extract_characters
    x_cutter = PerCharacter()
NameError: name 'PerCharacter' is not defined

{'players': [{'weapon': 'わかばシューター'},
             {'weapon': 'デュアルスイーパーカスタム'},
             {'weapon': 'ロングブラスター'},
             {'weapon': 'N-ZAP89'},
             {'weapon': 'スプラシューターコラボ'},
             {'weapon': 'N-ZAP89'},
             {'weapon': 'カーボンローラー'},
             {'weapon': 'スプラローラーコラボ'}],
 'won': True}
Takeshis-MacBook-Pro:IkaLog_github hasegaw$

init.py ではクラス定義してはいけないようなので、
やるなら init.py から他の .py ファイルに分割する。


Consumer groups

Hi,
librdkafka recently added support for the new consumer group api for brokers >= 0.9. Do you plan on implementing this functionality?
Regards,
Riaan

+1
It would be great !

@riaan53 : Sorry, but no: I don't currently have the time to work on it. Pull requests are welcome, of course. It should be straightforward to update the embedded librdkafka version as a first step, for example.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_03424ff1-5105-4470-85fb-a883a8a5bd49/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_03424ff1-5105-4470-85fb-a883a8a5bd49.git

Docs Build status updates of commit 8b612ba:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-UserAccountBuildPermissionInsufficientError] Owner v-alji no longer has Read permission of the repository https://github.com/opstest2/docs-archive-test-source. It might be due to recent GitHub changes on SSO. Please ask the owner v-alji to logon to Docs Portal https://ops.microsoft.com once again. If it is not the case, please ask anyone of Admin permission of the repo to assign a new owner via Docs Portal https://ops.microsoft.com

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Filter chain halted as :authenticate_user! rendered or redirected

I'm developing a json API with rails, using rails-api gem, devise_token_auth and angularjs. Using the standard configuration all seems to be ok until I active the line of:
before_action :authenticate_user!
From that point my app only show me the next error:
Filter chain halted as :authenticate_user! rendered or redirected
I was reading that this seem caused about a missing header on the request, but i couldn't figure out what i am doing wrong.
This is my configuration until now:
Gemfile
source 'https://rubygems.org'

gem 'rails', '4.2.6'

gem 'rails-api'

gem 'spring', :group => :development

gem 'mysql2'

gem 'devise'
gem 'devise_token_auth'
gem 'omniauth'

gem 'rack-cors', :require => 'rack/cors'

application.rb
require File.expand_path('../boot', __FILE__)

require 'rails/all'

# Require the gems listed in Gemfile, including any gems
# you've limited to :test, :development, or :production.
Bundler.require(*Rails.groups)

module SlsApiTest
  class Application < Rails::Application
    # Settings in config/environments/* take precedence over those specified here.
    # Application configuration should go into files in config/initializers
    # -- all .rb files in that directory are automatically loaded.

    # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
    # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
    # config.time_zone = 'Central Time (US & Canada)'

    # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
    # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
    # config.i18n.default_locale = :de

    # Do not swallow errors in after_commit/after_rollback callbacks.
    config.active_record.raise_in_transactional_callbacks = true
    config.middleware.use Rack::Cors do
      allow do
        origins '*'
        resource '*',
          :headers => :any,
          :expose  => ['access-token', 'expiry', 'token-type', 'uid', 'client'],
          :methods => [:get, :post, :options, :delete, :put, :patch]
      end
    end
  end
end

application_controller.rb
class ApplicationController < ActionController::API
  include DeviseTokenAuth::Concerns::SetUserByToken

  before_action :authenticate_user!
end

devise_token_auth.rb
DeviseTokenAuth.setup do |config|
  # By default the authorization headers will change after each request. The
  # client is responsible for keeping track of the changing tokens. Change
  # this to false to prevent the Authorization header from changing after
  # each request.
  # config.change_headers_on_each_request = true

  # By default, users will need to re-authenticate after 2 weeks. This setting
  # determines how long tokens will remain valid after they are issued.
  # config.token_lifespan = 2.weeks

  # Sets the max number of concurrent devices per user, which is 10 by default.
  # After this limit is reached, the oldest tokens will be removed.
  # config.max_number_of_devices = 10

  # Sometimes it's necessary to make several requests to the API at the same
  # time. In this case, each request in the batch will need to share the same
  # auth token. This setting determines how far apart the requests can be while
  # still using the same auth token.
  # config.batch_request_buffer_throttle = 5.seconds

  # This route will be the prefix for all oauth2 redirect callbacks. For
  # example, using the default '/omniauth', the github oauth2 provider will
  # redirect successful authentications to '/omniauth/github/callback'
  # config.omniauth_prefix = "/omniauth"

  # By default sending current password is not needed for the password update.
  # Uncomment to enforce current_password param to be checked before all
  # attribute updates. Set it to :password if you want it to be checked only if
  # password is updated.
  # config.check_current_password_before_update = :attributes

  # By default, only Bearer Token authentication is implemented out of the box.
  # If, however, you wish to integrate with legacy Devise authentication, you can
  # do so by enabling this flag. NOTE: This feature is highly experimental!
  # enable_standard_devise_support = false
end

devise.rb
Devise.setup do |config|
  # The e-mail address that mail will appear to be sent from
  # If absent, mail is sent from<EMAIL_ADDRESS>  config.mailer_sender =<EMAIL_ADDRESS>
  # If using rails-api, you may want to tell devise to not use ActionDispatch::Flash
  # middleware b/c rails-api does not include it.
  # See: http://stackoverflow.com/q/19600905/806956
  config.navigational_formats = [:json]
end

My angular app is literaly a copy and paste of the examples using in the repo for ng-token-auth, with index.html making registration of users and index2.html doing the login request.
This is the link for the application repo that i'm using for testing: APITest
Hope you can help me!
Thanks in advance =D

Having the same issue. Any progress?

I'm still doing some testing, but it seems to be resolved modifying
before_action :authenticate_user! to
before_filter :authenticate_user!, except: [:new, :create]
If something new comes to surface I'll let you know
Regards!

Having same problem, did you find a solution ?

I'm having the same problem. I can login fine and even replay a few 'validate_token' requests, but at some point it will fail and give me 401 unauthorized.

Can you post your configuration?
How are you handle the request headers and response headers?
Did you had any errors during those requests?

I'm using ng-token-auth to do all of the communication with the rails API. My configs are all default for now, following are the files I've changed:
application_controller.rb
class ApplicationController < ActionController::Base
  # Prevent CSRF attacks by using :null_session
  protect_from_forgery with: :null_session
  include DeviseTokenAuth::Concerns::SetUserByToken

...

user.rb
class User < ActiveRecord::Base
  # Include default devise modules.
  devise :database_authenticatable, :registerable,
          :recoverable, :rememberable, :trackable, :validatable,
          :confirmable, :omniauthable
  include DeviseTokenAuth::Concerns::User

...

Is there any other file that could be interfering with that?
Thank you for the impressively fast response 😃

Well i have a little time before i go to sleep...
Back to the point... I'm assuming you've have installed and configured rack/cors for crossite requests when you configure devise_token_auth?

Yes! This is what my application.rb looks like:
require File.expand_path('../boot', __FILE__)

require 'rails/all'

# Require the gems listed in Gemfile, including any gems
# you've limited to :test, :development, or :production.
Bundler.require(*Rails.groups)

module RailsSports2
  class Application < Rails::Application
    # Settings in config/environments/* take precedence over those specified here.
    # Application configuration should go into files in config/initializers
    # -- all .rb files in that directory are automatically loaded.

    # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
    # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
    # config.time_zone = 'Central Time (US & Canada)'

    # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
    # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
    # config.i18n.default_locale = :de

    # Do not swallow errors in after_commit/after_rollback callbacks.
    config.active_record.raise_in_transactional_callbacks = true

    config.middleware.use config.session_store, config.session_options
    config.middleware.use Rack::MethodOverride
    config.middleware.use ActionDispatch::Cookies
    config.middleware.use ActionDispatch::Session::CookieStore
    config.middleware.use ActionDispatch::Flash

    config.autoload_paths += %W( #{config.root}/lib )

    config.middleware.use Rack::Cors do
      allow do
        origins '*'
        resource '*',
                 :headers => :any,
                 :expose  => ['access-token', 'expiry', 'token-type', 'uid', 'client'],
                 :methods => [:get, :post, :options, :delete, :put]
      end
    end
  end
end

Try this in your application_controller.rb
  before_filter :add_allow_credentials_headers
  skip_before_filter :verify_authenticity_token
  before_filter :cors_preflight_check
  after_filter :cors_set_access_control_headers

  before_filter :authenticate_user!, except: [:new, :create]

  def cors_set_access_control_headers
    headers['Access-Control-Allow-Origin'] = '*'
    headers['Access-Control-Allow-Methods'] = 'POST, GET, PUT, DELETE, OPTIONS'
    headers['Access-Control-Allow-Headers'] = 'Origin, Content-Type, Accept, Authorization, Token'
    headers['Access-Control-Max-Age'] = '1728000'
  end

  def cors_preflight_check
    if request.method == 'OPTIONS'
      headers['Access-Control-Allow-Origin'] = '*'
      headers['Access-Control-Allow-Methods'] = 'POST, GET, PUT, DELETE, OPTIONS'
      headers['Access-Control-Allow-Headers'] = 'X-Requested-With, X-Prototype-Version, Token'
      headers['Access-Control-Max-Age'] = '1728000'

      render :text => '', :content_type => 'text/plain'
    end
  end

  def add_allow_credentials_headers
    # https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#section_5
    #
    # Because we want our front-end to send cookies to allow the API to be authenticated
    # (using 'withCredentials' in the XMLHttpRequest), we need to add some headers so
    # the browser will not reject the response
    response.headers['Access-Control-Allow-Origin'] = request.headers['Origin'] || '*'
    response.headers['Access-Control-Allow-Credentials'] = 'true'
  end

This seems to extend the span between login into the application and getting the 401, but doesn't seem to fix the problem yet 😢
Started POST "/api/v1/tips/byaddress" for ::1 at 2016-09-04 23:24:23 -0700
Processing by TipsController#list_by_address as HTML
  User Load (0.5ms)  SELECT  "users".* FROM "users" WHERE "users"."uid" = $1 LIMIT 1  [["uid", <user_id>]]
Filter chain halted as :authenticate_user! rendered or redirected
Completed 401 Unauthorized in 62ms (Views: 0.2ms | ActiveRecord: 0.5ms)

Looking at the query, seems to get the wrong param, or you changed it when you post it?
Seems to be received an user_id instead of the user id.
SELECT  "users".* FROM "users" WHERE "users"."uid" = $1 LIMIT 1  [["uid", <user_id>]]

My bad.
Adding "before_filter :authenticate_user!, except: [:new, :create]" to the application_controller.rb wouldn't let me login, returning me:
{"errors":["Authorized users only."]}

So I moved it to the only controller that I actually need it for now, but didn't add the "except: [:new, :create]" part, because I'm not using those methods there and didn't think it would make a difference. Adding that seems to have fixed the issue!
Thank you for your help @unDeveloper !! I really appreciate it 😃

So, that didn't seem to solve the problem. The token would get invalidated after a while and I'd be back to the same issue as before. What seems to have fixed it for now is changing my devise_token_auth.rb config as follows:
config.change_headers_on_each_request = false

you guys are so cute:
keep it up or check out my repo here devise token auth

The problem is before_action :authenticate_user! in ApplicationController.
Why?
See the devise_token_auth's inheritance structure.
DeviseTokenAuth::SessionsControlle < DeviseTokenAuth::ApplicationController
DeviseTokenAuth::ApplicationController < DeviseController
DeviseController < ApplicationController

Because of the inheritance structure, all actions like sessions#create in devise_token_auth call authenticate_user!. When we request sign_in, our rails app check access-token that is actually not exist in header and it returns Filter chain halted as :authenticate_user! rendered or redirected. The before action should not be called before sessions#create
Solutions

Use other class name not ApplicationController
Use before :authenticate_user! in only controller that you actually need


Feat (eos_cli_config_gen): Add support for BGP labeled-unicast

Enhancement summary
This is an extension of the existing BGP address family structures to support BGP-LU
Which component of AVD is impacted
eos_cli_config_gen
Use case example
Configuration of BGP LU
Describe the solution you would like
We already have address_family_ipv4_multicast and address_family_ipv4_sr_te. This solution would be to add another key, in the same structure for address_family_ipv4_labeled_unicast.
Describe alternatives you have considered
No response
Additional context
No response
Contributing Guide

[X] I agree to follow this project's Code of Conduct

colinmacgiolla self-assigned this Thank you!


Wait for nova api service after reboot

After a controller reboot, "nova list" fails with:
ERROR (ConnectionRefused): Unable to establish connection to
http://<IP_ADDRESS>:8774/v2/my-uuid/servers/detail
Wait for the nova api service before doing the "nova list"

Thanks, +1 in principle although please can you wait until #477 is merged and then change this to reference novacontrollersvc so that it works with HA too.

Thanks, +1 in principle although please can you wait until #477 is merged and then change this to reference novacontrollersvc so that it works with HA too.

This one is hopefully fixing the current jenkins failures we need for M2. So imo should be merged first...

This one is hopefully fixing the current jenkins failures we need for M2. So imo should be merged first...

They are both fixing jenkins failures, but if you merge this first, it will need to be changed immediately when #477 is merged ...

Seems that this "fix" is not needed anymore...


Add UI for graph creation

The general way is to merge master to the topic branch, fix conflicts, push, and re-review (which is exactly what I'll do here).


change title on README

What I've accomplished

[] Left reviews and line comments
[] Created a file and made a commit
[] Opened a pull request

Merging new readme.md file


Update mdlComponentHandler.js

JSDoc update so file can pass compiler

Which compiler is this PR meant to implement a fix for?

We've landed (afaict) the necessary changes to please google3 compilers in separate PRs over the last few months. Closing this as the patch set is no longer needed. If this isn't the case for any reason, feel free to ping and we'll happily reopen.


getting a decode error for the result response

Hi Team,
I tried integrating the package and facing a decoding error in the response. Could some one please guide me
my code
`func getData(text: String, completion: @escaping ((Result<String, Error>) -> Void)) {
    client?.sendCompletion(with: text) { result in
        switch result {
        case .success(let success):
            if let atleastOneReply = success.choices.first?.text {
                completion(.success(atleastOneReply))
            }
        case .failure(let failure):
            print(failure.localizedDescription)
        }
    }
}`

Hey, @chetan-diy-ios
Can you share the text you're sending, please?
Thank you,
Adam

I tried many questions.
"Hello how are you"
"Biggest animal on planet"
"when is iPhone will actually get a update"

I am getting the same issue.

@andrewcar which characters are you talking about? I am also facing same error. Maybe your solution can help.

Thank you @andrewcar for confirming. So let me share my sample code;
        openAI.sendCompletion(with: "Hello how are you", maxTokens: 100) { result in
            switch result {
            case .success(let success):
                print(success.choices.first?.text ?? "")
            case .failure(let failure):
                print(failure.localizedDescription)
            }
        }

Console output is:
I'm doing great, thank you! How are you?

@andrewcar which characters are you talking about? I am also facing same error. Maybe your solution can help.

If you go to your API keys, and if you have generated any secret keys, you'll see them there with the middle truncated.
So, when I visited there to double check mine, I noticed that the last characters didn't match up with what I was using to initialize the Swift library. I just created a new one and my issue was resolved.

Closing based on above discussion, please open new issue with the issue persists 😀

I am having the same issue today, I updated my API keys.


Speed up Setoid by optimistically test for strict Equality

When working on large data structure (like reducer states), this would help a lot.
@gcanti I may do a PR if you confirm interest beforehand.

Good idea, strict equality tests are cheap


[IOTDB-6353] replace cglib to byte-buddy

The cglib has stopped evolution, The cglib community suggests byte-buddy instead, so we'll do
https://github.com/cglib/cglib
IMPORTANT NOTE: cglib is unmaintained and does not work well (or possibly at all?) in newer JDKs, particularly JDK17+. If you need to support newer JDKs, we will accept well-tested well-thought-out patches... but you'll probably have better luck migrating to something like ByteBuddy.
_*https://github.com/raphw/byte-buddy.gi

@wangchao316 Thanks for this patch! Learned a lot


CJK chars aren't wrapped correctly

Check for existing issues

[X] Completed

Describe the bug / provide steps to reproduce it
Line wraps only happen in spaces now and do not break on CJK chars. See the screenshots below for comparison with Emacs.
Environment
Zed: v0.94.4 (stable)
OS: macOS 13.2.1
Memory: 32 GiB
Architecture: x86_64
If applicable, add mockups / screenshots to help explain present your vision of the feature
Zed: (Note how the paragraphs are wrapped at whitespaces after list bullets and English words.)

Emacs:

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.
If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.
No response

Is this a regression @liebkne? Did this not happen before a certain version?

@JosephTLyons Sorry, I'm not sure about that. I incidentally open a CJK markdown file and notice the issue today. I usually don't do markdown stuffs in Zed due to other existing CJK issues like } is inserted after backspacing.


InShaAllah

https://github.com/aboudyonduty/CPS493-Assignments/blob/70e0555cb570da4c0898a4fb829a33af386d4d6f/Final/client/src/components/WorkoutForm.vue#L1C10-L1C10
❤

❤


Suggestion - enable discussions in the repo

Hi,
great project!
README reffers to "Discussions" for the question and/or discussions, but the repo does not have discussions enabled.
Would be helpful for generic questions like "If flower is able to parse the arguments for tasks and celery-insights have arguments always as {args:[]kwargs:{}}, what can be the cause?".

Great suggestion! I've added Github Discussions to the repo, see you there? 🙂🚀

Great suggestion! I've added Github Discussions to the repo, see you there? 🙂🚀


HAPROXY_MODE option to be added

Based on the video demo for minecraft, as of 0.3.2, HAPROXY_MODE was going to be included in the configurations for haproxy. I noticed it was still not there.
Has the plan changed or is it no longer necessary?

After discussion, we didn't want to introduce a breaking change like that in a patch release. We should probably change it for 0.4.

closing this one since we are moving to traefik instead of haproxy-consul


Any way mocking @Transactional()

Problem
I got this message in my test codes
No CLS namespace defined in your app ... please call initializeTransactionalContext() before application start.
Question
Are there any ways to mock @Transactional() in my test codes?
My test codes are below.
describe('Approval', () => {
    test('Approve booking.', async () => {
      /**
       * Given
       * orderId
       */
      const orderId = '1234';

      const spy_OrderRepository_findOrder = jest.spyOn(orderRepository, 'findOrder');
      const spy_OrderRepository_saveOrder = jest.spyOn(orderRepository, 'saveOrder');

      /**
       * When
       * Host confirms booking request.
       */
     //confirmRequest is wrapped by @Transactional()
      await hostOrderService.confirmRequest(orderId');

     /**
     * Then
     *  Success
     */

Furthermore, is it possible to manage transactions in a service layer? Currently, NestJS integration is not possible to control typeorm transaction features among services, not repositories.
Great job! Thanks!

Oops.
I think calling ' initializeTransactionalContext()' works fine.
I will close this issue.
describe('Reservation Management', () => {
  let hostOrderService: HostOrderService;
  let orderRepository: OrderRepository;

  beforeAll(async () => {
    initializeTransactionalContext();

    const module = await Test.createTestingModule({
      providers: [HostOrderService, OrderRepositoryMock, PaymentServiceMock],
    }).compile();

    hostOrderService = module.get<HostOrderService>(HostOrderService);
    orderRepository = module.get<OrderRepository>(OrderRepository);
  });

Sorry. It didn't work.
Without DB connection I got this error.
 ConnectionNotFoundError: Connection "default" was not found.

I got it! Mock Transactional decorator


Show CPU usage, sorting and reverse sorting

I really like ptop but it lacks showing CPU usage (well, lacked...)
Now ptop is able to show processes' CPU usage and sort the list with ctrl + U shortcut where U stands for Usage, as C for CPU was taken 🙃.
Also, now it's possible to reverse-sort the list.

Thanks for your contribution, let me go through this change and get it merged :)


[SCB-464] Upgrade to Java Chassis 1.0.0-m1

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.2%) to 95.082% when pulling 691ba4e3a5dbdaf2328f85e2522a705ea644a7b1 on yangbor:master into 89485bc1ace9b65b01ccc1f57faa8f3b4ce7bd8a on apache:master.


IDVA3-572  - add test for companyNumberRouter

New tests added for the companyNumberRouter

CI: Security warnings found!


add support for ruby 2.6

Ruby 3 is not currently supported.  Created https://github.com/scribd/datadog_backup/issues/71 to track this


Embed SVG into appended content with CDN stylesheet

If my Grunticon produced stylesheet is served from a CDN, is it possible to embed SVG elements into DOM elements that have been appended via JavaScript? This is basically a combination of #217 and #212.
It is not working for me currently. The SVG's are successfully embedded the first time I call grunticon.svgLoadedCORSCallback(), but are not in an later calls. In other words, the first time my Backbone view renders, the icons are embedded. Any additional times the view is rendered, the icons are not successfully embedded. There are no console errors.
Grunticon config
grunticon:
  project:
    files: [
      expand: true,
      cwd: "app/assets/images/icons"
      src: ["**/*.svg", "**/*.png"]
      dest: "app/assets/stylesheets/base/icons"
    ]
    options:
      enhanceSVG: true
      corsEmbed: true

Load Grunticon
<script>/* [grunticon-loader] */</script>
<script>
grunticon([
    "http://cdn.com/icons.data.svg.css",
    "http://cdn.com/icons.data.png.css",
    "http://cdn.com/icons.fallback.css"
]);
</script>

Embed SVG
This is called each time the Backbone view is rendered.
// After Backbone view rendered...
grunticon.svgLoadedCORSCallback();

Network Requests
Seen below, the initial stylesheet request (on page load) and each additional request from the Backbone view being rendered. The first rendering successfully embeds the icons (second request), the second does fails to embed (third request).

Actually, there was a console an error.

After digging further, the ref variables found in the svgLoadedCORSCallback appears to be returning as null for each additional request.
Apologies for the variables in this screen shot, but I merely unminified the loader script that Grunticon generates. The first o and r are from the initial rendering of the Backbone View. The second set are from when I revisited the view.

I believe the r is the ref variable. Should this ref variable be null after the first time I call grunticon.svgLoadedCORSCallback()?

I think the culprit is here: https://github.com/filamentgroup/grunticon/blob/master/tasks/grunticon/static/grunticon.embed.js#L77 - when we embed icons, we remove the attribute that says "embed icons here" at that point. We originally did this for performance reasons and, mostly, because we hadn't thought that people would use Grunticon to re-embed multiple times over.
If there's any way to avoid re-embedding, that would likely be beneficial for you, but I'm looking into other options.

I'm not sure if the removal of the attribute is the culprit. The Backbone view template is removed and re-added to the DOM. So, the data-grunticon-embed is on the element for any additional embed calls.
For the time being I've stopped using my CDN and CORS. I'm serving the icon stylesheets from the local server.

So this is ONLY happening with repeat views when using the CORS setup?

Yes, the initial rendering of the Backbone view successfully embeds the SVG icons. Subsequent renderings of the view fail to embed the SVG icons. Since this only happens when using CORS, I figured it had something do with the additional requests for the same stylesheet.

Ah,
Then yes - https://github.com/filamentgroup/grunticon/blob/master/tasks/grunticon/static/grunticon.embed.cors.js#L33
So, in order to make CORS work, we take the stylesheet, and then embed it into the head. We then remove the stylesheet (to prevent conflicts, mostly) - this is once again, a case where we didn't intend on this being called multiple times. I'll see what I can do to further decouple the rendering part.


SSH session to guest disconnects randomly (and other host/guest socket connections)

Describe the issue
I have long running ssh sessions connected to my UTM session, after a while they can get disconnected and won't reconnect to the guest.
When that happens, I can't ssh back in.   The guest is still responsive by interacting with it directly.
Note:  I noticed that there may be a general thing where sockets between guest and host disconnect - it's especially noticable when I use pulseaudio on the host and connect to it from the guest, you can be playing music and then it stops working because it has become disconnected.
It seems like there is a general issue with the host/guest connection.
Other things that may be related, are the interface going down (which can be fixed in the guest by taking it down and back up), and maybe even the virtio issues.
Configuration

UTM Version: 4.4.4 (93)
macOS Version: Ventura (13.2.1)
Mac Chip (Intel, M1, ...): M2
Guest: Ubuntu 23.04, Linux stu-vm-ubuntu 6.6.4-060604-generic #202312030734 SMP PREEMPT_DYNAMIC Sun Dec  3 07:47:40 UTC 2023 aarch64 aarch64 aarch64 GNU/Linux

Debug log
debug-utm-20231221.log.zip
Note - debug log is a little long, I had been using the machine for a while before this occured, and then a bit afterwards until I had to kill it because of the bug where the guest is unresponsive except for the mouse pointer moving (it acts in exactly the same way as it does when you remove the PCI device the virtio GPU exposes in the guest).
Upload VM
config.plist.zip
If your issue is related to a specific VM, please upload the config.plist from your VM's .utm directory.

I noticed this has also started to happen with my Ubuntu VM as well after upgrading to 4.4.4.

UTM Version: 4.4.4 (93)
macOS Version: Sonoma 14.0
Mac Chip: M2 Pro
Guest: Ubuntu 22.04, Linux devbox 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:29:11 UTC 2023 aarch64 aarch64 aarch64 GNU/Linux

I recently also updated my Ubuntu OS using apt update && apt upgrade for the first time since setting up this guest.

Feel free to close this, I no longer use a Mac with UTM+Qemu, so won't be able to give any feedback or reproduce this.


Disconnect and reconnect loop

Hi,
in pade 5.0.1 on openfire 4.4.1 the application every 2/3 mins closed connection and reconnect. With spark 2.8.3 work fine.
Tks

Can you please do a factory reset and re-enter your password. If you still have an issue, then try to disable web-sockets.  If you still have an issue, the open chrome dev console (F12), download the console log and post it to me privately.

libsignal-protocol.js:136 pre-main prep time: 2 ms
index.js:234 doConverse <IP_ADDRESS>:7443 ma***.del*** false
index.js:473 converse.initialize Object
gateway.js:69 gateway plugin is ready
info.js:89 info plugin is ready
payments.js:139 payments plugin is ready
markdown.js:50 markdown plugin is ready
search.js:140 search plugin is ready
directory.js:131 directory plugin is ready
invite.js:107 invite plugin is ready
vmsg.js:75 vmsg plugin is ready
webmeet.js:638 webmeet plugin is ready
converse.js:63327  ERROR: Error while fetching bookmarks
./src/headless/converse-core.js._converse.log @ converse.js:63327
pade.js:402 pade plugin is ready
converse.js:63327  ERROR: <iq xmlns="jabber:client" type="error" id="4b7d67db-08ea-46d4-9030-39395019cf94:sendIQ" to=*********<EMAIL_ADDRESS><EMAIL_ADDRESS>./src/headless/converse-core.js._converse.log @ converse.js:63327

I don't think https://<IP_ADDRESS>:7443 is going to work as your server. Do you have a certificate for <IP_ADDRESS>? Try https://dominio.it:7443

Unable to reproduce this issue. I suspect it is certificate problem


Clean up artwork page

Add some captions and scale the page appropriately.

I added some media queries to adjust the slides based on screen size. This is pretty fiddly, so I'm not going to run through every possible screen size I can think of.


Missing lua.hpp error during build

Issue Summary
Latest commit results in missing lua.hpp error during build.
Behavior/Symptoms
[ 82%] Building CXX object Projects/CoX/Servers/MapServer/CMakeFiles/mapserver_lib.dir/ScriptingEngine.cpp.o
In file included from /SEGS/Segs/Projects/CoX/Servers/MapServer/ScriptingEngine.cpp:10:0:
/SEGS/build/3rd_party/built/include/sol2/sol.hpp:1578:10: fatal error: lua.hpp: No such file or directory
 #include <lua.hpp>
          ^~~~~~~~~
compilation terminated.
gmake[2]: *** [Projects/CoX/Servers/MapServer/CMakeFiles/mapserver_lib.dir/build.make:615: Projects/CoX/Servers/MapServer/CMakeFiles/mapserver_lib.dir/ScriptingEngine.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:1318: Projects/CoX/Servers/MapServer/CMakeFiles/mapserver_lib.dir/all] Error 2
gmake: *** [Makefile:84: all] Error 2
19:26:05: The process "/usr/bin/cmake" exited with code 2.
Error while building/deploying project SEGS (kit: Desktop)
When executing step "Make"
19:26:05: Elapsed time: 00:01.

Steps to reproduce behavior/symptoms
Clone latest git (540e7bce4d11c5126360c8180af6b39b3aa818a6) and build.
System Info
Qt 5.9.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.2.1 20170915 (Red Hat 7.2.1-2)) on "xcb"
OS: Fedora 26 (Workstation Edition) [linux version 4.13.8-200.fc26.x86_64]

This is frustrating. I see that lua.hpp is included here prior to loading sol2:
https://github.com/Segs/Segs/blob/540e7bce4d11c5126360c8180af6b39b3aa818a6/Projects/CoX/Servers/MapServer/ScriptingEngine.cpp#L9-L10
Is this a bug upstream with SOL2?

Might be a simple to solve, I think SOL2 expects lua.hpp to be directly accessible.. we might solve it by simply modifying sol.hpp to refer to lua/lua.hpp


Multiple secrets

Issue #, if available: Closes #13
Description of changes:

Changed the secret path to mount at /tmp/secrets/<secret name>
Added test for aws-secrets-manager

cc @jicowan
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@danquack  @jicowan  can we consider merging to master? The sooner the best as users will create dependencies on /tmp/secret structure

@danquack I am also waiting for this to be merged to master, as this will help us a lot to manager secrets in EKS Cluster.

I don't maintain this repo, this change that I opened, to a branch vs master, was at the recommendation of the maintainers.

Hi, how do i reference multiple secrets?

Hi @omriarieli , please checkout the branch: "multi-secret": https://github.com/aws-samples/aws-secret-sidecar-injector/tree/multi-secret#accessing-the-secret
With that code, you can refer multiple-secrets by separating them with commas

Hi @dnascimento, thanks for the reply is there a docker image for this branch? i cloned the repo in this branch theres a helm folder but trying to install getting
Failed to pull image "docker.io/amazon/aws-secrets-manager-secret-adm-controller:0.2": rpc error: code = Unknown desc = Error response from daemon: manifest for amazon/aws-secrets-manager-secret-adm-controller:0.2 not found: manifest unknown: manifest unknown
docker hub has v0.1.1 and v0.1.2 are any of them built from multi-secret branch?
thanks
Omri

Hi, thanks for the reply. i have built the images from multi-secret branch and installed the helm chart using these images. i see the annotations in the pod's manifest and init container has run and complete, yet under /tmp inside the container there is nothing. i have tried with two secrets seperated by a "," and with one secret as well. if you need any more info i would be happy to provide. using same service account that has the needed iam policy and verified as working from master branch with one secret.
Thanks
Omri

Could you share your configuration and logs @omriarieli so that I can help to debug? Feel welcomed to send me an email

Hi, I just noticed in my pod's generated manifest that both secrets get mounted not in /tmp/secrets that was my confusion. actually both secrets are present under /secrets
volumeMounts:
- mountPath: /var/run/secrets/kubernetes.io/serviceaccount
  name: kubernetes-external-secrets-token-69hjp
  readOnly: true
- mountPath: /secrets/my-env/my-secret-1
  name: secret-vol
  readOnly: true
  subPath: secrets/my-env/my-secret-1
- mountPath: /secrets/my-env/my-secret-2
  name: secret-vol
  readOnly: true
  subPath: secrets/my-env/my-secret-2

thanks


Composer Install Artisan Fatal Error

After cloning the master branch, installing dependencies, and running composer install in flox/backend/ the following error is thrown on Alpine 3.10:
flox-host:/opt/flox/backend# composer install
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating autoload files
> Illuminate\Foundation\ComposerScripts::postInstall
> php artisan optimize
PHP Fatal error:  Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: Class 'PDO' not found in /opt/flox/backend/config/database.php:16
Stack trace:
#0 /opt/flox/backend/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/LoadConfiguration.php(60): require()
#1 /opt/flox/backend/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/LoadConfiguration.php(38): Illuminate\Foundation\Bootstrap\LoadConfiguration->loadConfigurationFiles(Object(Illuminate\Foundation\Application), Object(Illuminate\Config\Repository))
#2 /opt/flox/backend/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(203): Illuminate\Foundation\Bootstrap\LoadConfiguration->bootstrap(Object(Illuminate\Foundation\Application))
#3 /opt/flox/backend/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(268): Illuminate\Foundation\Application->bootstrapWith(Array)
#4 /opt/flox/backend/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(114): Illuminate\Foundation\Console\Kernel->bootstrap()
 in /opt/flox/backend/config/database.php on line 16
Script php artisan optimize handling the post-install-cmd event returned with error code 255

I found this to be caused by not having php-pdo installed, however i still get stuck at "php artisan flox:db" as it says mysql is not configured.

Oh wow, i didn't see the issues here in flox :/
@jhollowe did the comment from @digibucc helped you?

I just changed to running on Ubuntu 18.04 and everything worked.


[Geo] Guard on spatial obj in form_data

Fix bug when spatial object isnt defined in form_data.

Moving to #4124


camGame turning black after i use this shader on camHUD

Describe your problem here.
camGame is turning black after i use a shader in camHUD, what do i change?

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
just added "camHUD.setFilters(new ShaderFilter(shader));" when creating the stage

already fixed it, just changed this


[BUG] cant open image with kvaesitso

Extension tried : png, jpg
Image path : sdcard, internal storage
App version : latest
Android 12
https://github.com/IacobIonut01/Gallery/assets/80298071/bd5654ae-b677-4095-9c0f-a6fc176c2471

I can confirm that it is not working...👍

Let me know if you find any other crashes while opening media from any apps.


Update Bootstrap 5.2.1

Update is live on bootscore.me and works fine.
@justinkruit there is already a drafted release. Want to copy content and create new v<IP_ADDRESS> release? There are two more PR's we should ship here, update scssphp 1.10.0 and a tiny WC checkout table improvement.

Adding the release tag of Bootstrap for reference: https://github.com/twbs/bootstrap/releases/tag/v5.2.1

@crftwrk Merged the other 2 PRs, will merge this and then make a new release file. 👍


General Validation pt II

This PR is connected with #918
What's done:

Improved validations on frontend when creating Organization
Improved validations on frontend when creating Project
Added high_level_names table where names of organizations and users are stored
Added check if current high level name is present in db or not
Added new response handler on frontend to process CONFLICT responses
Improved validation in ContestCreationComponent
Fixed minor frontend issues

It seems to me that this logic with an intermediate table is complicated. What will we do if a user or organization changes its name?
It is also better to add the id field to any table, especially if its data is associated with some other table.

It seems to me that this logic with an intermediate table is complicated. What will we do if a user or organization changes its name?

I guess we will want to change the name in high_level_names first and right after that in another table.

It is also better to add the id field to any table, especially if its data is associated with some other table.

Well, I am really not sure that we need it for now


aws_ebs_raid  fails to mount new raid volume on ubuntu 16.04LTS

Cookbook version
3.4.1
Chef-client version
Chef: 12.12.15
Platform Details
Ubuntu
us-east-1   xenial  16.04 LTS   amd64   ebs-ssd 20160721    ami-656be372    aki-919dcaf8
knife ec2 server create
--run-list 'role[mongo]'
--image ami-656be372
--flavor m3.large
--node-name mongo1.mongo.prod1
--security-group-ids xxxx
--tags Name=mongo1,environment=prod1,role=mongo
--ssh-key ops
-i .ssh/oun-ops.pem
--ssh-user ubuntu
--environment prod1
--subnet xxxx
--availability-zone us-east-1a
--ebs-size 30
Scenario:
trying to build an raid 10 array and mount
Steps to Reproduce:
including the AWS cookbook in my own,
aws_ebs_raid "Setup Mongo Raid" do
mount_point_owner node["oun-mongo"]["user"]
mount_point_group node["oun-mongo"]["group"]
aws_access_key xxx
aws_secret_access_key xxx
mount_point node["oun-mongo"]["db_mount"]
disk_count node["oun-mongo"]["ebs"]["number_of_disks"]
disk_size node["oun-mongo"]["ebs"]["disk_size"]
level node["oun-mongo"]["ebs"]["raid_level"]
disk_type node["oun-mongo"]["ebs"]["disk_type"]
mount_point_mode node["oun-mongo"]["ebs"]["mount_point_mode"]
disk_piops node["oun-mongo"]["ebs"]["provisioned_iops"]
disk_encrypted node["oun-mongo"]["ebs"]["encrypted"]
disk_kms_key_id xxxx
end
Expected Result:
i would like a raid 10 array mounted as request
Actual Result:
https://gist.github.com/neallawson/ad3af0d92224b5744b6480fc8fa0fb63

Update: this issue seems to be specific to the newer ubuntu 16.04 LTS as it works on ami-3ddd502a , Ubuntu 14.04LTS

+1 .. as above .. works fine on 14.04

The ebs_raid provider needs a complete rework and I'm hesitant to make the time commitment since it's not actually a core AWS feature, but a bolt on that really should have ended up in its cookbook. It makes a lot of assumptions about volume layout that just don't pan out across instance types and distro releases.  If someone wants to take on a refactor that works on PV/HVM and multiple distro releases I'd gladly merge it, but in the current state I'm more inclined to just remove the provider altogether.

Please leave it, i have found it very essential to many of my cookbooks, i would love to also see an LVM build in as well

Perhaps there is a way to string a RAID array together using the ebs_volume provider along with the mdadm cookbook and replace the ebs_raid provider with a nice example of this instead?

We've removed the aws_raid provider so this bug is no longer valid for this cookbook. I encourage anyone that needs the functionality to take on the provider in its own codebase. As ebs_raid itself is not a core AWS service we don't see it as fitting here.

thank you for letting us know, however i must say im disappointed, and found the functionality useful.

I highly recommend provisioned IOPS on an EBS volume where you can

yup, however when the business have a requirement, you code to the requirement....  and that was my use case for this feature...

If you run the existing PV instances where this functionality worked you can just copy the resource/provider into a local cookbook.


React "validateDOMNesting" warning appears to break component

Thanks for all the fantastic work on this great project.  However, I think I've identified a bug.
Example repo:
https://github.com/richsilv/next-error-example

npm i
npm run dev to observe the validateDOMNesting warning in the console and the fact that the button subsequently doesn't work when served by Next.
npm run build-non-next to browserify the same component, and then open the file non-next.html to see it working, despite the same warning.

Browsers: Chrome and Firefox running on Ubuntu
I know the warning is there for a reason, and the best resolution is to write something that compiles to valid HTML, but it was very surprising to me to find that the warning was also breaking my component.  This is particularly the case as these warnings can often be the result of imported components which work perfectly in isolation, but throw warnings when nested in your JSX.
The most logical explanation is that the SSR markup is being amended by the browser to conform to HTML spec, and this leads to a problem when it attempts to transition to the client-generated markup, which it expects to be the same.

It seems this is the issue of React since it occurs with no next.js if you do SSR.

@richsilv could you submit an issue to the React repo? That would be great ❤


chore(forbidden-identifiers): detect incorrect line endings

Removes stale scope checking (from @angular2-material/$COMPONENT times)
Adds support for error grouping (useful when having a file full of invalid line endings)
Moves chain functions into external functions to easily

understand procession.

Here you can see the error grouping - Notice that we don't show any special message for the line endings (because to keep the script small and easy to maintain)

@hansl can you take a look?

@hansl Do you have time to take a quick look at this? :)

Hi @DevVersion,
Sorry, this fell off a bit. Looking at it now.

LGTM for now.
@DevVersion What I'd like to see though is moving away from a forbidden-identifier file and using custom tslint rules instead. It would be better and less hacky (since reporting is done by tslint, for example). See documentation here: https://www.npmjs.com/package/tslint#custom-rules
What do you think?

@hansl - Great idea. I can do a follow-up PR to this one with the custom TS-Lint rules-

Yes, a follow up PR. This one is okay (for now).


Fixing image view controller presentation

I make some change. Please review it.

Thank you! :+1:

With Xcode 7.2 (7C68) with this change, I find in BaseViewController.swift, line 31-
popularShot.parentNavigationController = self.navigationController!

Compilation fails at this line. Commenting out this line lets the code to be compiled.
Is anyone seeing this error?
@oldtrafford91 @naoyashiga


SetNormalFontObject param-type-mismatch

https://warcraft.wiki.gg/wiki/API_Button_SetNormalFontObject
according to the wiki, string or Font are available for param
but Font is only eligible on your extension

There are some more. I should have included them.
Sethighlightfontobject has also same error.
Two of the params for Libdatabroker are required and th rest are optional. But they are set all required.
That's what I've found so far.
Once again, thank you for your extension


fastlane gradlew android inject properties is not formatted correctly

Issue

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

I have set up a lane called fastlane android dev and I have some tooling which fetches the current version_code and version_name from Google Play Console. I want to increment the version_code by one before pushing it to Google Play. I want to not have to do this by altering the build.gradle file, but instead passing it to my land and inject it via code.
platform :android do
  desc "[!! Dev environment is currently not set up !!] Push a new DEVELOPMENT build to Google Play Store | Internal testing"
  lane :dev do
    # fetch version code and version name from Fastvile ENV
    version_code = ENV["VERSION_CODE"]
    version_name = ENV["VERSION_NAME"]

    # print version code and version name for sanity check
    puts "Version code: #{version_code}"
    puts "Version name: #{version_name}"

    gradle(
      task: 'bundle',
      build_type: 'Release',
      project_dir: "android/",
      properties: {
        "android.injected.version.code" => version_code.to_i,
        "android.injected.version.name" => version_name
      }
    )

    upload_to_play_store(
      skip_upload_apk: true,
      track: 'internal',
      release_status: 'completed',
    )
  end
end

Command executed
When running fastlane android dev the gradlew command executed is this:
/path/to/project/android/gradlew bundleRelease -p android/ -Pandroid.injected.version.code=1000000010 -Pandroid.injected.version.name=5.3.1

The command I would assume should be ran is the this:
/path/to/project/android/gradlew bundleRelease -p android/ -P android.injected.version.code=1000000010 -P android.injected.version.name=5.3.1

Quite simply, I think the spaces are missing.
Complete output when running fastlane, including the stack trace and command used
No need - I have my own code running which works
Environment
✅ fastlane environment ✅
Stack

Key
Value

OS
debian_based bookworm/sid

Ruby
3.2.1

Bundler?
false

Git
git version 2.34.1

Installation Source
~/.asdf/installs/ruby/3.2.1/bin/fastlane

Host
Pop!_OS 22.04 LTS debian_based bookworm/sid (6.9.3-76060903-generic)

Ruby Lib Dir
~/.asdf/installs/ruby/3.2.1/lib

OpenSSL Version
OpenSSL 3.0.2 15 Mar 2022

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

System Locale

Variable
Value

LANG
en_DK.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# tooling
import './lanes/tooling/tools.rb'

# ios lanes
import './lanes/ios/dev.rb'
import './lanes/ios/internal.rb'
import './lanes/ios/external.rb'

# android lanes
import './lanes/android/dev.rb'
import './lanes/android/internal.rb'
import './lanes/android/external.rb'

# update_fastlane

def dev_to_staging
    sh "bash d2s"
end

def staging_to_production
    sh "bash s2p"
end

def production_to_staging
    sh "bash p2s"
end

after_all do |lane|
    production_to_staging
end

error do |lane, exception|
    production_to_staging
end

default_platform(:ios)

################# IOS LANE SPEC #################
# The lane are targeted towards the following user groups:
# Production - Public release on App Store
# TestFlight
#   - Internal Testing
#     # Will be staging builds for:
#       - Developers
#       - Product Owner (e.g. Jam)
#       - QA (e.g. CS when needed)
#   - External Testing
#     # Will be production builds for:
#       - All of the above
#       - Testers (e.g. CS, Junge, Casper etc.)
#       - Partners (e.g. NGF, GIT, beta testers, etc.)
platform :ios do
    before_all do
        setup_ci if ENV["CI"]
        match(type: 'appstore')
        api_key = app_store_connect_api_key(
            key_id: "8T67DGP9G4",
            issuer_id: "69a6de81-156c-47e3-e053-5b8c7c11a4d1",
            key_filepath: "fastlane/AuthKey_8T67DGP9G4.p8"
        )
    end
end

################# ANDROID LANE SPEC #################
# The lane are targeted towards the following user groups:
# Production - Public release on Google Play Store
# Internal Testing (development)
#   - Developers
#   - Product Owner (e.g. Jam)
#   - QA (e.g. CS when needed)
# Closed testing - aplha (staging)
#   - All of the above
#   - GLFR Testers
# Closed testing - beta (production)
#   - All of the above
#   - Partners (e.g. NGF, GIT, beta testers, etc.)
platform :android do
    before_all do
        project_dir = File.expand_path("../..", __FILE__) #this method gives the current file path of the project
        package_json_file = File.expand_path("#{project_dir}/package.json", __FILE__)
        gradle_file = File.expand_path("#{project_dir}/android/app/build.gradle", __FILE__)

        version_code, version_name = increment_version(gradle_file, package_json_file, 1)

        # Read the gradle file content
        gradle_contents = File.read(gradle_file)

        # Replace the versionCode and versionName in the gradle file content
        gradle_contents.gsub!(/versionCode\s+\d+/, "versionCode #{version_code}")
        gradle_contents.gsub!(/versionName\s+"[^"]+"/, "versionName \"#{version_name}\"")

        # Write the updated content back to the gradle file
        File.write(gradle_file, gradle_contents)

        # expose the version code and version name to the lanes
        ENV["VERSION_CODE"] = version_code.to_s
        ENV["VERSION_NAME"] = version_name
    end

    after_all do |lane|
        puts "============================================="
        puts "Successfully completed the lane: #{lane}"
        puts "reverting the gradle file back to the default version code and version name"
        puts "============================================="

        # Setup project specific variables
        project_dir = File.expand_path("../..", __FILE__) #this method gives the current file path of the project
        gradle_file = File.expand_path("#{project_dir}/android/app/build.gradle", __FILE__)

        # Read the gradle file content
        gradle_contents = File.read(gradle_file)

        # Revert the version code and version name back to the default values
        # This is done to avoid having to manage the version code and version name in
        # git and to avoid merge conflicts
        # Values:
        #  - versionCode 1337
        #  - versionName "${versionMajor}.${versionMinor}.${versionPatch}"
        gradle_contents.gsub!(/versionCode\s+\d+/, "versionCode 1337")
        gradle_contents.gsub!(/versionName\s+"[^"]+"/, "versionName \"${versionMajor}.${versionMinor}.${versionPatch}\"")

        # Write the updated content back to the gradle file
        File.write(gradle_file, gradle_contents)
    end

    error do
        # Setup project specific variables
        project_dir = File.expand_path("../..", __FILE__) #this method gives the current file path of the project
        gradle_file = File.expand_path("#{project_dir}/android/app/build.gradle", __FILE__)

        # Read the gradle file content
        gradle_contents = File.read(gradle_file)

        # Revert the version code and version name back to the default values
        # This is done to avoid having to manage the version code and version name in
        # git and to avoid merge conflicts
        # Values:
        #  - versionCode 1337
        #  - versionName "${versionMajor}.${versionMinor}.${versionPatch}"
        gradle_contents.gsub!(/versionCode\s+\d+/, "versionCode 1337")
        gradle_contents.gsub!(/versionName\s+"[^"]+"/, "versionName \"${versionMajor}.${versionMinor}.${versionPatch}\"")

        # Write the updated content back to the gradle file
        File.write(gradle_file, gradle_contents)
    end
end

`./fastlane/Appfile`
json_key_file("fastlane/android_key.json") # Path to the json secret file - Follow https://docs.fastlane.tools/actions/supply/#setup to get one
package_name("com.glfr") # e.g. com.krausefx.app

app_identifier("com.glfr") # The bundle identifier of your app
<EMAIL_ADDRESS># Your Apple Developer Portal username

itc_team_id("93731809") # App Store Connect Team ID
team_id("5G2JM72KQ3") # Developer Portal Team ID

# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem
Version
Update-Status

fastlane
2.225.0
✅ Up-To-Date

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-sentry
1.25.1
✅ Up-To-Date

Loaded gems

Gem
Version

error_highlight
0.5.1

did_you_mean
1.6.3

syntax_suggest
1.0.2

public_suffix
4.0.7

addressable
2.8.6

artifactory
3.0.17

jmespath
1.6.2

aws-partitions
1.930.0

aws-eventstream
1.3.0

aws-sdk-core
3.196.1

aws-sdk-kms
1.81.0

aws-sdk-s3
1.151.0

babosa
1.0.4

CFPropertyList
3.0.7

colored
1.2

highline
2.0.3

commander
4.6.0

dotenv
2.8.1

emoji_regex
3.2.3

excon
0.110.0

faraday-em_http
1.0.0

faraday-em_synchrony
1.0.0

faraday-excon
1.1.0

faraday-httpclient
1.0.1

multipart-post
2.4.1

faraday-multipart
1.0.4

faraday-net_http
1.0.1

faraday-net_http_persistent
1.2.0

faraday-patron
1.0.0

faraday-rack
1.0.0

faraday-retry
1.0.3

ruby2_keywords
0.0.5

faraday
1.10.3

faraday_middleware
1.2.0

domain_name
0.6.20240107

http-cookie
1.0.5

faraday-cookie_jar
0.0.7

fastimage
2.3.1

sysrandom
1.0.5

fastlane-sirp
1.0.0

gh_inspector
1.1.3

uber
0.1.0

declarative
0.0.20

trailblazer-option
0.1.2

representable
3.2.0

retriable
3.1.2

mini_mime
1.1.5

jwt
2.8.1

multi_json
1.15.0

os
1.1.4

signet
0.19.0

googleauth
1.8.1

httpclient
2.8.3

google-apis-core
0.11.3

google-apis-androidpublisher_v3
0.54.0

google-apis-playcustomapp_v1
0.13.0

google-cloud-env
1.6.0

google-cloud-errors
1.4.0

google-cloud-core
1.7.0

google-apis-iamcredentials_v1
0.17.0

google-apis-storage_v1
0.31.0

digest-crc
0.6.5

google-cloud-storage
1.47.0

mini_magick
4.12.0

naturally
2.2.1

plist
3.7.1

rubyzip
2.3.2

security
0.1.5

simctl
1.6.10

terminal-notifier
2.0.0

unicode-display_width
2.5.0

terminal-table
3.0.2

tty-screen
0.8.2

tty-cursor
0.7.1

tty-spinner
0.9.3

word_wrap
1.0.0

atomos
0.1.3

claide
1.1.0

colored2
3.1.2

nanaimo
0.3.0

xcodeproj
1.24.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.1

set
1.0.3

aws-sigv4
1.10.1

bundler
2.5.23

strscan
3.1.0

rexml
3.2.8

nkf
0.2.0

base64
0.2.0

rake
13.2.1

json
2.7.2

optparse
0.5.0

forwardable
1.3.3

logger
1.5.3

pathname
0.2.1

shellwords
0.1.0

cgi
0.3.6

date
3.3.3

timeout
0.3.1

securerandom
0.2.2

uri
0.12.0

openssl
3.1.0

digest
3.1.1

ipaddr
1.2.5

resolv
0.2.2

time
0.2.1

stringio
3.0.4

open-uri
0.3.0

mutex_m
0.1.2

net-http
0.3.2

net-protocol
0.2.1

english
0.7.2

erb
4.0.2

abbrev
0.1.1

tempfile
0.1.3

delegate
0.3.0

fileutils
1.7.0

tmpdir
0.1.3

singleton
0.1.1

open3
0.1.2

prettyprint
0.1.1

pp
0.4.0

find
0.1.1

ostruct
0.5.5

yaml
0.2.1

psych
5.0.1

fastlane-plugin-sentry
1.25.1

generated on: 2024-12-06

Did you have an error that you think required spaces? Gradle for the longest time has required no spaces between parameters because some tools improperly assumed that was part of the param and thus wrong.
https://docs.gradle.org/current/userguide/build_environment.html#setting_a_project_property

Did you have an error that you think required spaces? Gradle for the longest time has required no spaces between parameters because some tools improperly assumed that was part of the param and thus wrong.
https://docs.gradle.org/current/userguide/build_environment.html#setting_a_project_property

Huh.. You are correct! I will admit my mistake :)
When that is said - the properties still doesn't set/inject the version_code and version_name in my application. When I don't set them in the project_root/android/app/build.gradle I get an error while building complaining that the properties were not set. When set in the build.gradle config they either "overwrite" the properties set in my lane or they are completely ignored. Which one it is I am not sure

I pass code/name like this and it works.
    gradle(task: "assemble", build_type: 'Release', properties: {
      versionCode: version_code.to_i,
      versionName: version_name,
      // ....


Systemd unit exec path is wrong

The default prefix is /usr/local/bin, but the unit service was calling /usr/bin/macfand.

Thank you for the PR.


Balancing change in survival mode

Make Rail connector stackable
Consume Rail connector in survival mode
Give Rail connector back when properly removed (Use another connector or remover, but exclude remove the node)

Ref: Discord Suggestions
The reason why I made this is due to I am playing this mod in survival mode, and I found it is so OP.
The node is very cheap, and the connector can be used forever.
What if we change the connector to one rail one connector?
if I were the designer, I would change the connector to one connector for one rail, and make it stackable.
also I would like to make the node more expensive.
Because MTR is much stronger than vanilla rail system, so it should be much more expensive.

Your efforts are very much appreciated! I'd like to note one thing though, with all of the changes it's still going to be worth the same to make a 1m long and a 10km long track of the same type

One idea I had was to add a durability/damage to the rail connector, say 10,000, and every meter of track = 1 damage to the rail connector.


Make tape only watch the tensor with the floating dtype

This PR fixes #28248 by making the tape only watch the tensor with the floating dtype and removes the log info that may make users confused.

@alextp Thanks for your explanation! I rewrite this PR. Could you please have a look at the changes (https://github.com/tensorflow/tensorflow/pull/30107/commits/fbc212cfd666b205abf01bc1d79e1ea7844389f4) when you get a chance?

Oops, yes.
On Thu, Oct 17, 2019 at 10:28 PM RJ Skerry-Ryan<EMAIL_ADDRESS>wrote:

@rryan commented on this pull request.
In tensorflow/python/ops/script_ops.py
https://github.com/tensorflow/tensorflow/pull/30107#discussion_r336323652
:

   for tensor in args:

   tape.watch(tensor)

   for t in nest.flatten(tensor):

     if t.dtype.is_floating:

It looks like we should have also watched complex types here?
(context: #32774 https://github.com/tensorflow/tensorflow/issues/32774)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/30107?email_source=notifications&email_token=AAABHRIRFKOJBEYDQNWGYVDQPFCOLA5CNFSM4H3D4Z52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIMZ73A#pullrequestreview-303669228,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABHRN2YK4EDIL7AGJAJYDQPFCOLANCNFSM4H3D4Z5Q
.

--

Alex

Can you send a PR?
On Tue, Oct 29, 2019 at 10:48 AM Alexandre Passos<EMAIL_ADDRESS>wrote:

Oops, yes.
On Thu, Oct 17, 2019 at 10:28 PM RJ Skerry-Ryan<EMAIL_ADDRESS>wrote:

@rryan commented on this pull request.
In tensorflow/python/ops/script_ops.py
https://github.com/tensorflow/tensorflow/pull/30107#discussion_r336323652
:

   for tensor in args:

   tape.watch(tensor)

   for t in nest.flatten(tensor):

     if t.dtype.is_floating:

It looks like we should have also watched complex types here?
(context: #32774 https://github.com/tensorflow/tensorflow/issues/32774)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/30107?email_source=notifications&email_token=AAABHRIRFKOJBEYDQNWGYVDQPFCOLA5CNFSM4H3D4Z52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIMZ73A#pullrequestreview-303669228,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABHRN2YK4EDIL7AGJAJYDQPFCOLANCNFSM4H3D4Z5Q
.

--

Alex

--

Alex


[V3] [3.0.3] Controls are still visible after clicking pause/play on touch devices

Expected behaviour
When the video is playing and no further touch-input is triggered, the controls should hide
Actual behaviour
The controls stay on mobile
Environment

Browser: Any touch device
Version: Any touch device
Operating System: Any touch device
Version: Any touch device

Steps to reproduce

Go to https://plyr.io/
Start as a touch device
Try to play the video, then pause, and then play again - the controls are still shown, even after seconds

Further remarks

Many of the :hover states don't work correctly on mobile. I think we need some touch detection to fully add touch support. Modernizr offers a "touch"/"no-touch"-class on the body, which is widely used for dealing with hover-states on mobile.

I think I found the issue:
-                    utils.on(this.player.elements.controls, 'mouseenter mouseleave', function (event) {
+                    utils.on(this.player.elements.controls, 'mouseenter mouseleave touchstart touchend', function (event) {
                        _this4.player.elements.controls.hover = event.type === 'mouseenter';
                    });

Can confirm this! It's quite annoying

Feel free to debug and PR a fix then 👍

@malinushj I have found a quite good solution, but I can't make an pull request yet because the current version is not working for me. @sampotts the current version which is uploaded is somehow broken, I can't seek at all. Can you confirm this?

Yeah I noticed that - have pushed a fix.  Essential the requirements are hide after x seconds unless:

Controls are hovered on a mouse device
Controls are pressed on a touch or mouse device
Loads of other scenarios I've forgotten

It doesn't help that iOS just fires all the touch events and mouse events...

Hey @sampotts , yeah, I've noticed the mutiple events while I was debugging.
I have a version which is working correctly, here are my proposed fixes:
// Determine percentage, if already visible
            if (utils.is.event(event)) {
                var pageX = event.pageX

                if (event.touches !== undefined && event.touches.length && event.touches[0].pageX !== undefined) {
                    pageX = event.touches[0].pageX
                }

                percent = 100 / clientRect.width * (pageX - clientRect.left);
            }

            if (utils.is.event(event) && ['mouseenter', 'mouseleave', 'touchstart', 'touchmove', 'touchend'].includes(event.type)) {
                utils.toggleClass(this.elements.display.seekTooltip, visible, ['mouseenter', 'touchstart', 'touchmove'].includes(event.type));
            }

                utils.on(this.player.elements.progress, !support.touch ? 'mouseenter mouseleave mousemove' : 'touchstart touchend touchmove', function (event) {
                    return controls.updateSeekTooltip.call(_this4.player, event);
                });

                    utils.on(this.player.elements.controls, !support.touch ? 'mouseenter mouseleave' : 'touchstart touchend', function (event) {
                        _this4.player.elements.controls.hover = event.type === 'mouseenter';
                    });

                    utils.on(this.player.elements.controls, !support.touch ? 'mousedown mouseup' : 'touchstart touchend touchcancel', function (event) {
                        _this4.player.elements.controls.pressed = ['mousedown', 'touchstart'].includes(event.type);
                    });

It's really hard to work out what's changed from that lot.
With the seek tooltip. I've just binned that off on touch but could look at those changes you've done.
I can see the direction but another thing we need to support is both mouse and touch support. I think I have it fixed but seeing a weird bug with Safari after seeking it's impossible to press any other buttons in the controls and the progress container seems to get all the click events. It's so weird.

I've pushed my changes but will continue to work on a fix for after seeking. If you could take a look that'd be good.
BTW it's best to fork the repo, make your changes (run gulp to build + watch) and then commit and PR when you're done.

I think I'll push 3.0.4 for now as there's other fixes in there. Will fix the seeking issue and push 3.0.5 asap.

Ok, thank you for your time! I will consider this so we can work better together :)

If you need a hand, feel free to grab me in the Slack

Do you mean https://bit.ly/plyr-slack? I've found it in the readme, but it keeps saying "the invitation is not longer active". Do you have a new one?

Will update but try https://bit.ly/plyr-chat

I think it's better that the big-play and controls show after stoping in iphone.Dose anybody know how to archive it?

@1057641912 I can confirm that the big-play Button was working when the video stopped, even on iPhone. On which version do you see the issue?

plyr.js --- 3.0.9
iphone5s --- IOS 11.2.6
iphoneX --- IOS 11.2.6
but it works on iPad.
You can try the two website, https://codepen.io/sampotts/pen/jARJYp and snugnest.com on iphone then you will see the big-play Button was not working when the video stopped.

I'll close this for now as I think it's just the issue of the controls acting odd after a seek


Add transparent compression for on-disk shuffle with partd

Shoud close https://github.com/dask/dask/issues/5704
This change adds transparent file compression for on-disk shuffle via partd.
The compression algorithm can be specified by dask config (keyword shuffle_disk_compression).
It can be any algorithm which is exposed by partd.compressed. In case an algorithm is absent, it silently falls back to no compression.
Please check one thing - I am not sure about the naming schema and where to document the config parameter.

[x] Tests added / passed
[x] Passes black dask / flake8 dask

Thanks for submitting a PR for #5704 .  The default config file can be found here: https://github.com/dask/dask/blob/master/dask/dask.yaml .  Can I ask that you also add to the config test here: https://github.com/dask/dask/blob/5db6dad7947f186a9764cdf409b8f50bf7c38f22/dask/tests/test_config.py#L417-L418

What do we think about the name?  Two things come to mind:

We've started namespacing most of our configuration names.  Maybe we should do the same here?
We tend to use hyphens rather than underscores.  Maybe we should do the same here.

@quasiben : Thanks, I will add the config test.
@mrocklin : The current naming is definitly not optimal but I do not know the general naming convention or what would fit best here. Please make a proposal

I'd suggest dataframe.shuffle-comperssion.

There's a linting issue too: https://travis-ci.org/dask/dask/jobs/637027038#L1437-L1440. Contributing guidelines are at https://docs.dask.org/en/latest/develop.html#code-formatting. You might want to install and use pre-commit.


[FLINK-12821][table][cep] Fix the bug that fix time quantifier can not be the last element of a pattern

What is the purpose of the change
This pull request fix the bug that fix time quantifier can not be the last element of a pattern. Exception will be thrown for pattern "a{2}". Actually this pattern is not greedy and we should support it.
Brief change log

If the quantifier is fixed, we should not mark it as greedy.

Verifying this change
This change added tests and can be verified as follows:

Added tests in PatternTranslatorTest#testQuantifiers

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@flinkbot attention @dawidwys

Thank you for the fix @dianfu, merged.

@dawidwys thanks a lot for the review and commit. :)


TosterDB (storage for backed)

Mongodb as storage for inventory to be accessed from toaster

Created M0 mongodb in atlas

Need proper model in the future

How to store multiple Clients with orgs and limit access


Feature/dev workflow updates

Codecov Report

Merging #18 (d770a11) into master (2175c74) will increase coverage by 100.00%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           master       #18        +/-   ##
=============================================
+ Coverage        0   100.00%   +100.00%
=============================================
  Files           0         6         +6
  Lines           0        29        +29
=============================================
+ Hits            0        29        +29

Impacted Files
Coverage Δ

...ib/collections/test_runner/test_collections_main.c
100.00% <ø> (ø)

lib/mem_alloc/test_runner/test_mem_alloc_main.c
100.00% <ø> (ø)

lib/operations/test_runner/test_operations_main.c
100.00% <ø> (ø)

lib/pubsub/test_runner/test_pubsub_main.c
100.00% <ø> (ø)

lib/simple_fsm/test_runner/test_simple_fsm_main.c
100.00% <ø> (ø)

...ib/struct_pack/test_runner/test_struct_pack_main.c
100.00% <ø> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2175c74...d770a11. Read the comment docs.


refactor(sbb-file-selector): [Breaking change] change the "files" property type to a read-only array

Closed by #3198


Ensure voltage algorithms are tuned for OEPs standard tethers

The headstage specific auto port voltage tuning algorithm, e.g.:
https://github.com/open-ephys/onix-bonsai-onix1/blob/67f250de87cb825ee0f5091e4e3202032db79512/OpenEphys.Onix1/ConfigureHeadstage64.cs#L143
were not created using OEPS-supplied standard tether lengths in all cases. We need to ensure that the parameters of the algorithm are tuned to function well with the tethers provided by OEPS.
Related; #244

@filcarv What are the standard tether types and lengths that are used witch each ONIX headstage that OEPS is distributing?

Npx 1.0e
Npx 2.0e and 2.0e-beta
Headstage-64
Miniscope
Rhs2116

Hi @jonnew
The tethers are stated in the store, close to each device.
ONIX devices are shipped with the Coaxial Tether (X.FL to SMA) micro 8.2 ft (2.5 m)
Miniscopes are shipped with the Coaxial Tether (U.FL to SMA) mini 4.9ft (1.5m)

@ChucklesOnGitHub @filcarv The best way to do this is for me to work with you all while you plug in headstages one by one and we test them with multimeter etc. I have installed VS and the code on the ONIX test PC at OEPS. If we can schedule a time to do this let me know.


linalg should upcast float16 inputs to float32

@hawkinsp suggested: we probably need to change our linalg implementations to upcast to float32 for fp16. this is probably wise on all platforms, including TPU where even not doing this result may "compile" but you won't like it much.

I think this is stale...


pull request for e2e test at 01/12/2017 02:45:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Added Swift Package Manager

And also update .gitignore and directories hierarchy

I see that there are some unrelated code in this PR (especially the CocoaPods). Could you remove them?


GROBID not able to extract the header numbers when they're in Roman or in alphabets

Hi I am new to Grobid and really need help
I am trying to extract the section headers and while they do appear normally in the  tag, it does not give information about the section number in the tag, when the section IDs are Roman Numerals or alphabets

In contrast, when the numbers are in decimal notation/english integers, I am able to properly find the section number inside the tag

Please help me with a workaround so I am able to extract the section numbers inside the header tags.
Thanks a lot !

Hi @alwaysaditi, do you have a few CC-BY articles you can share? I'd like to do some testing and we might also use them as training data, in future, to improve the fulltext model.


Command Migration: ('LPUSH', 'RPUSH', 'LPOP', 'RPOP', 'LLEN')

This issue tracks the migration of the mentioned commands - ('LPUSH', 'RPUSH', 'LPOP', 'RPOP', 'LLEN') to make them compatible across the three protocols supported by the Dice database: RESP, HTTP, and WebSocket.
DiceDB now supports more than one protocols (Resp/http/websocket). We don't want eval operation of each command to be strictly bound with any of the protocols. Currently eval function return statements of each command is bounded to the RESP protocol.
The migration is required because:

The current implementation is specific to the RESP protocol
Evaluation functions of each command must be refactored to ensure protocol-agnostic behavior.
Evaluation functions should return raw responses instead of protocol specific responses.

The goal is to make the command logic protocol-independent, allowing all three protocols to call the same core functionality seamlessly.
Requirements

Refactor the evaluation function of [Command Name] to be generic.
Ensure the evaluation function does not include protocol-specific logic.

Migration Steps

Analyze Current Implementation

Review the current codebase to understand how the command logic is implemented.

Refactor Return Logic

Create a new function with the function definition as evalXXX(args []string, store *dstore.Store) *EvalResponse under the file /internal/eval/store_eval.go
Analyse return statements of the eval and modify them to send raw types without encoding
Use errors in the return statements from /errors/migrated_errors.go file
Use perdefined responses from /internal/clientio/resp.go file as RespType variables

Command/Worker specific Changes

Make IsMigrated flag to true in the commands information under /internal/eval/commands.go file.
Use the newly written eval function against the NewEval parameter in the same command structure.
Delete the old eval function from the /internal/eval/eval.go file.
Add the migrated command to the /internal/worker/CommandsMeta map and make it's type as SingleShard

Update Unit Tests

Refactor existing unit tests to accommodate the new implementation.
Add new unit tests if necessary to cover all possible cases.

Integration Tests

Run all integration tests to ensure successful migration.
Ensure that each protocol (RESP, HTTP, WebSocket) works correctly after migration.

Checklist

[ ] Migrated the evalXXX function with the latest definition
[ ] Update or add unit tests for the new implementation.
[ ] All unit tests pass successfully.
[ ] Ensure all integration tests pass successfully.

Additional Notes

Describe any edge cases that need to be handled in the generic function.
Mention any protocol-specific optimizations required in wrappers.

If there are any questions or concerns about this migration, please mention them here.
Related Issues/PRs

Sample implementation for the Get, Set, GetSet and SetEx can be found in this Pull Request.

Hi Ashwin, I'd like to work on this issue, Can you please assign this to me?

HI @ankkyprasad , I hope you are doing well. Do you happen to have any updates on this? If you've any doubts please let us know on the discord.

Hey @AshwinKul28, I'll start working on it from tonight. Didn't get time this weekends.

Hi @ankkyprasad hope you are doing well, can you please update the current progress on this task? If you have any blockers feel free to discuss here or on the discord.

Hey @AshwinKul28, I'm working on unittest cases. Will be done by this weekend...

Hey @ankkyprasad whts the update

Hey @mohit-nagaraj, you can take this up. I won't be unable to work on this due to some issues.

Hi, if this issue is available, I would like to work on it.

Hi @Aditya-Chowdhary, thank you for taking this on! Please proceed with the migration steps. Go for it!


Iterate over hierarchies to find matching hierarchy

Compare python evaluated and C++ evaluated HPWLs for the right hierarchy pairs.

Let's do this a little differently. I'll prooose a different change to the Python code.
Do you have a failing testcase? I want to know why this happened.

Let's do this a little differently. I'll prooose a different change to the Python code. Do you have a failing testcase? I want to know why this happened.

switched_capacitor_filter in examples/ has this issue. Please refer to issue #863 .
It is reproducible by running schematic2layout.py $ALIGN_HOME/examples/switched_capacitor_filter.


Initial size of the crop area

In my use case the initial size of the cropping area must as large as possible: depending on the size of the image and aspect ration, either width or height should span the whole dimension of the image.
Currently it is a minimum of  one half of the corresponding dimension or 200 (resetCropHost() in crop-host.js):
theArea.setSize({
    w: Math.min(200, cw / 2),
    h: Math.min(200, ch / 2)
});

It might be useful to introduce a parameter (e.g., initCropSize between 0 and 1) that allows defining the initial size of the crop area: e.g.,
theArea.setSize({
    w: Math.min(200, cw * initCropSize),
    h: Math.min(200, ch * initCropSize)
});

However, I am not quite sure how what is the nice way to implement it since resetCropHost() has no access to the scope of the directive. Any ideas?

Why do you need this access? Which is the problem with the way you build it theArea.setSize({     w: Math.min(200, cw * initCropSize),     h: Math.min(200, ch * initCropSize) });

Well, because if I want to control it via a parameter, the parameter will be attached to the scope.

+1 This is a terrific library - thank you! It would be really nice if I could set the initCropSize as a parameter.

There appears to be one more change that needs to be made, in addition to theArea.setSize change mentioned above. I also had to change the theArea.setCenterPoint call in the setMaxDimensions function to
 theArea.setCenterPoint({
   x: ctx.canvas.width / 2,
   y: ctx.canvas.height / 2
 });

for an initCropSize of 1. If I don't do this, the initial crop size is reduced in the setCenterPoint call. My change is clearly a hack(TM), but I'm not sure what the correct change is.

Darn I need this too. I tried to do this with area-min-size but when the cropper loads it doesnt load the minimum size, so I can't use that as a workaround.
Is there anyway to do this without forking it?

It looks like area-coords could do it, but it's not even in the original codebase?

Need to check it out. If in original it is working normally, i am pretty sure i can fix it quickly.

that would be amazing. PS I found the original area-coords, I didn't notice github doesnt let you search on forked repos... Either way, I still am not quite sure how to use area-coords or if that even helps.
Really I just want to set it on the max size immediately as the cropper loads. area-coords="{w: 500, h: 500}"

best would be area-coords="'max'", that will help cases where we can aspect ratio

yes, that would be amazing.

Agreed

+1

+1 please

+1 :)

+1

+1

I looked at the project and the initial forker/starter didn't had alot of time, at least that's what he said.
Here is my PR https://github.com/CrackerakiUA/ngImgCropFullExtended/pull/64

@CrackerakiUA the init feature is made and merged. This can be closed


Where can I download the House Pricing data?

Please point me<EMAIL_ADDRESS>to where I can download the Key Influencer House Pricing data.  I have googled w/o success.  Thanks!!!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4200dd45-15ab-ee4a-9818-10cc81475f64
Version Independent ID: 0b96ac28-e2a2-41c9-eff0-efd864fc0529
Content: Key influencers visualizations tutorial - Power BI
Content Source: powerbi-docs/visuals/power-bi-visualization-influencers.md
Service: powerbi
Sub-service: powerbi-service
GitHub Login: @mihart
Microsoft Alias: mihart

Thanks for your comment, @SirWm This looks like a product question rather than documentation feedback. You might find a solution in the Power BI Community. If not, try our support page.

@SirWm - assigning to the author to review.

You can find the dataset on Kaggle :) https://www.kaggle.com/c/house-prices-advanced-regression-techniques/data

@mihart - Please consider whether to link to this data source from the article. You may then close this issue as the customer question has been answered.

@msftrien - please see Kate's question above.

@juluczni is there anything preventing us from including the dataset in the docs? Some legal consideration, etc? If not, I think it would be useful to provide a download link so that users can follow along.

Yep the license of the dataset is public domain so we are good to share!

The article has been updated to include a link to the source data and will publish soon. Thank you for your contribution!


Code release

@jzhou316 hope you're well.
I was wondering if the code is going to be released for this paper. Really interested in the material.
Many thanks and best,
Andrew

Hi thanks for your interest. Sorry that I haven't got time to take care of the code release. I'll clean up the code and make a release soon. The original code was written in Matlab but we'll probably have a Python and/or R version later.

Amazing! thank you so much!
Very generous.
Hope your well.
Best,
Andrew


[Feature Request] Add network strength

It would be great having the network strength!

It would also require another IsSupported property at least as this is totally not supported on all mobile platforms i imagine...

@bbougot Could you elaborate on this request?
It will be nice if you add more details.
What are you ideas? And, how it should work?

Because we have not received a reply to our request for more information, I am marking this issue as closed. If you are still encountering this issue on the latest version of the plugin, please don’t hesitate to reopen the ticket with the requested information. Thanks!


Prepare promotional images for Chrome store

I took a quick look at what they require. Here's googles guidelines on the subject
https://developer.chrome.com/webstore/images?hl=en#promo
Any guidelines/thoughts on what this should look like @zakius?

Unfortunately I have no idea what to do about this, I don't have any brand to promote or literally anything that would make sense on promo images, tools like this aren't really fashionable either way
Possibly some combination of icon and name would do, it just has to be there for the automated part of submission system to pass package further in approval chain
Now that I think about it it will be required to prepare something for Detector too


Features for further roadmap

Goal: Provide best-in-class developer support for the interface of developers to cluster orchestrators

Connector to OpenShift [Prio 1]
Connector to Kontena [Prio 3]
Connector to Nomad [Prio 3]
Integrated syntax and consistency checks for all formats [Prio 1]
Linting of decriptors (best practices, pitfalls) [Prio 2]
Provide a visualization (e.g. like the OpenShift visualization) [Prio 2]
Also provide a Maven plugin [Prio 3]
Add blocking feature, which blocks until the container started [Prio 1] (See #50)
Remove all code style issues (Sonarqube, Codacy, Codebeat) [Prio 1]

A connector to Kontena would be just great, as my Docker images are built and tested with Gradle.


Bug in Audience Value for JwtBearerFlow

The audience value is not set correctly for sandboxes.  If the instance is a sandbox the aud value should be https://test.salesforce.com and for prod it should be https://login.salesforce.com.

Good catch, fixed it in the latest release v0.5.6