[RDK-34521] Create JSON schema for BundleGen templates/metadata files

Initial version for JSON schema verification task
Adding the metadata schema & platform schema files. Platform schema files will contains rules for both platform JSON & platform_libs.json
Added the validation part in bundle processor.
In this implementation, OCI bundle will not be generated in case there is a mismatch with the schema files.
Verified that the OCI bundle was generated successfully for the other existing apps in meta-dac-sdk repo to check for schema compatibility.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Copyright scan failure
Commit: c0d183d1e84893530d7c70cb2a68395d9817cb5b
Report detail: https://gist.github.com/4f3e47617b828e09e2fbc239c67a7831

Can we also add a simple schema for the xxxx_libs.json files ?

Done

@TeknoVenus - Uploaded changes as suggested in latest review. Pls check.
@goruklu  - Review request mentions it needs your approval since you have requested for change (Addition of separate schema for platform_libs - this activity is done now). Please check.


Try out newer python versions.

Python 3.8 support requires https://github.com/PyCQA/pyflakes/pull/369 to be merged.


run.sh syntax errors

Lines 45 and 46 contain syntax errors where the : should be ;
They are currently
45: m) modelsfolder=${OPTARG};:
46: s) cachefolder=${OPTARG};:
but should be
45: m) modelsfolder=${OPTARG};;
46: s) cachefolder=${OPTARG};;

Thanks for reporting the issue.
Fixed.


New Kinesis Analytics runtime environment missing

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
Currently unable to upload a Kinesis Analytics app using the newest runtime (FLINK-1_15)
Diagnostics:
  aws:kinesisanalyticsv2:Application (<snip>):
    error: aws:kinesisanalyticsv2/application:Application resource '<snip>' has a problem: expected runtime_environment to be one of [SQL-1_0 FLINK-1_6 FLINK-1_8 ZEPPELIN-FLINK-1_0 FLINK-1_11 FLINK-1_13 ZEPPELIN-FLINK-2_0], got FLINK-1_15. Examine values at 'Application.RuntimeEnvironment'.

Affected area/feature

Module kinesisanalayticsv2

Hi @mattfysh -- you didn't indicate which version of the provider that you're using, but this validation error is coming from an older version of the aws sdk, and should be fixed in the latest release.
https://github.com/pulumi/terraform-provider-aws/blob/patched-v4.42.0/go.mod#L7
https://github.com/aws/aws-sdk-go/commit/1356aada4806053cf6a64f66288912c9625fa016#diff-d6ee7cddb85132c8e4a2732b17c323705c690519d23ad9a49cf98706d186c951R15891

hey @lblackstone apologies! I landed here from the npm pkg and falsely assumed the whole repo was for the node.js plugin
I am using:

pulumi CLI v3.48.0 (installed via homebrew)
nodejs @pulumi/pulumi v3.48.0
nodejs @pulumi/aws v5.21.1

I'm having a hard time following the upstream dependencies so unfortunately unable to know which of those 3 packages contains the outdated enum. Let me know if I can offer any more info, cheers!

Ok, I double-checked the dependencies for<EMAIL_ADDRESS>and confirmed that it's pulling in an older version of the aws SDK that does not include the enum. We are in the process of releasing a new version in https://github.com/pulumi/pulumi-aws/pull/2237 that does include the dependency you need, so this should be resolved once that's out.

Here's the dependency chain in case you're interested:
upstream fix which is first available in v1.44.144
<EMAIL_ADDRESS>pulumi/terraform-provider-aws@4f71b6571c4a
v1.44.133 is older than v1.44.144, so doesn't include the enum fix

Thank you :) will keep an eye on the PR.

Hey @lblackstone - are you sure the linked pull request will bring in the updated enum? I see it is upgrading to v4.42.0 but when I look at the documentation for this version, I don't see the new enum value of FLINK-1_15
https://registry.terraform.io/providers/hashicorp/aws/4.42.0/docs/resources/kinesisanalyticsv2_application
It appears the Flink v1.15 option only appears in the documentation for v4.44.0 onwards


Create ronaldsvilcins.com.md

Very clean website - but unfortunately this falls under the "ultra light / ultra minimal" category and therefore cannot be added.

Sorry for hasty look-over - completely missed the "writings" page with extra content. Adding to club.


fix(deps): use only a single lodash dependency

Using the fragmented lodash dependency provides no benefit on the backend. Instead it will needlessly pollute the module cache and install fragmented lodash modules even though the full lodash is extremely likely to already be in the dependency graph.

Thank you for the contributing this @oliversalzburg. I updated jsonapi-server dependencies today and I will need to update this package to the use latest jsonapi-server and make sure all the tests pass, which I should be able to do soon.


Update r-rmeta to 3.0.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Switch out minimp3 with the dr_mp3 implementation

Description
Since @lieff seems to have stopped working on minimp3, it might be wise to switch to dr_mp3, which simplifies our implementation and might potentially have fixes for certain issues (tbd).
This also fixes #2215
Tasks

[ ] Tested on Linux
[x] Tested on Windows
[ ] Tested on macOS
[ ] Tested on iOS
[ ] Tested on Android

How to test this PR?

#include <SFML/Audio.hpp>
#include <SFML/Graphics.hpp>

int main()
{
    sf::Music music;
    music.setLoop(true);
    music.setVolume(10);

    if (music.openFromFile("file.mp3"))
        music.play();

    auto window = sf::RenderWindow{ {200, 200}, "MP3 Test" };
    window.setFramerateLimit(30);

    while (window.isOpen())
    {
        for(auto event = sf::Event{}; window.pollEvent(event);)
        {
            if (event.type == sf::Event::Closed)
            {
                window.close();
            }
        }
    }
}

I'm open to this change. It's certainly a liability to use abandoned dependencies. I believe in the past we may have hit sanitizer failures in minimp3 but I could be misremembering.

Tested the implementation with various MP3 of different bitrates, mono, stereo, ID3 tags, APEv2 tags, large files, small files. So far everything played back correctly. As such for me the PR is ready for review.

Are we sure this isn't too big to put into v2?
I got master caught up with 2.6.x (see #3002), merged this branch into that PR branch, fixed the new merge conflicts, then ran the tests and am seeing some test failures. Can you make sense of what is going on here? The lack of tests in v2 makes it harder to land a change like this in v2 versus v3.
https://github.com/SFML/SFML/actions/runs/9073215514

In the test you've just hard coded the returned samples. There's of course no guarantee that two different decoder implementation return the exact same four samples values at the beginning of a file.
Not sure what the "correct" values should be. Looking at the files in Audacity fully zoomed in, it seems like the first few samples would equal to zero, yet on FLAC it's the same and it too does report values to start with:

Either way, I don't think this is too big. We've added audio tests in master only some months ago, so it's not like SFML didn't work before that. And of course the tests need to be adapted. minimp3 is pretty broken in a few ways and there's no fix in sight.

The author of dr_mp3 mentioned to me that there is one known issue with LAME tags: https://github.com/mackron/dr_libs/issues/263
Not if this warrants a mention somewhere or if we just hope for a fix before the 2.6.2 release 😄

Just in case nobody noticed yet, the author of dr_libs is also the author of miniaudio and all the decoders (mp3, FLAC, wav) are also integrated into miniaudio. This PR wouldn't make sense targeting master since we would just use miniaudio for decoding instead.

Cherry picking the commit onto master with the tests, we seem to run into the linked issue. The test MP3 has been encoded with LAME and the tags aren't parsed, so the timing and sample count are wrongly reported.
  CHECK( inputSoundFile.getSampleCount() == 87'798 )
with expansion:
  91008 (0x16380) == 87798 (0x156f6)

  CHECK( inputSoundFile.getDuration() == sf::microseconds(1'990'884) )
with expansion:
  2063673us == 1990884us

I don't see a movement on dr_libs' side. As such, I'll move this into the backlog for now. Maybe if we choose to do a 2.6.3 one day and it gets fixed, we can pick it up, otherwise it may find its way into SFML 3.x


Add separate readme for bottom panel example

I think i ran into some problem, added separate readme for the example

Maybe u can grant me collaborator access? so that i can work on branches which makes our life much easier?

Willing to contribute more to this repo

Ok. I will send you an invitation

Thank you

Received, thx

And can you join our discord?

Emm.. One suggestion. next time you make pr, maybe you should checkout a new branch, so that I can help fix some problems for you

Sure

And can you join our discord?

Yes, willing to Can u share the link ?

https://discord.gg/KKZRDYrRYW

Joined, thx


Feature/more colors

Add luv and lchuv color space using a D50 illuminant.
Add din99o and din99o-lch color space using a D65 illuminant and associated Delta E~99o~ distance  algorithm.
Make it easier to add additional Delta E methods and gamut mapping methods to a custom Color() class.
Add new Delta E~z~ algorithm (Jzazbz).
Add new Delta E~hyab~ algorithm for any Lab-ish style color spaces.
Expose delta_e_<type> methods dynamically depending on what Delta E methods are currently available.
Consistent calculation of achromatic thresholds across all Lch-ish color spaces.

Ref #45

@gir-bot lgtm


Prodigal Error

Error LOG part:
== Prodigal Error: ================
PRODIGAL v2.6.3 [February, 2016]
Univ of Tenn / Oak Ridge National Lab
Doug Hyatt, Loren Hauser, et al.
Request:  Single Genome, Phase:  Training
Reading in the sequence(s) to train...
Error:  Sequence must be 20000 characters (only 10000 read).
(Consider running with the -p meta option or finding more contigs from the same genome.)
== End Prodigal Error. ============
Will this (to run prodigal in meta mode) require some changes to source code or can be handled using deepbgc commandline?

Hi @thinkgenome, thanks for this suggestion. We were thinking about adding this option, so since it looks like there is demand for it, I added it in DeepBGC version 0.1.16, which is now available through pip and soon through conda.
Now you can run deepbgc prepare and deepbgc pipeline with --prodigal-meta-mode option to run Prodigal in -p meta mode.

Thanks again @prihoda


ci: try plugin install

:tada: This PR is included in version 1.9.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Bug: QA Test Data Size Limit

Issue:
The user is getting size limitations using the QA/Cert API Import

[ ] Set the data size limit to a higher maximum.

Steps to Recreate:
Use the API Import link in POSTMAN to import a large file
https://api.epa.gov/easey/dev/qa-certification-mgmt/export?facilityId=3&stackPipeIds=CS0AAN&testTypeCodes=|7DAY|AF2LCHK|APPE|BCAL|CYCLE|DAHS|DAYCAL|DGFMCAL|F2LCHK|F2LREF|FF2LBAS|FF2LTST|FFACC|FFACCTT|HGLINE|HGSI1|HGSI3|INTCHK|LEAK|LINE|MFMCAL|ONOFF|OTHER|PEI|PEMSACC|PEMSCAL|QGA|RATA|TSCAL|UNITDEF&beginDate=2020-01-01

Can import the large file above.


Item Tables Overhaul

Item tables are currently implemented with flexbox, and when the header row becomes too crowded, it becomes off-centered from its table contents. Consider this spellbook section:

Rebuild list views so that becoming off-balance is impossible.
Overflow should be handled in a more controlled and predictable way.

Current idea 💡 specifically for Spellbook:

Offload the primary column title (e.g., "Pact Magic 1st Level 🟠 1/1 ✏") to a standalone header row, where this content can expand out comfortably. In place of this text, the primary column should have the column title "Spell".

For all sheets, the "Name" column, like the item name itself, should truncate with ellipses "..." when compressed.
If there are too many columns and the sheet is not wide enough to accommodate them, a dedicated horizontal scrollbar should be provided for that tab (or list?)

Consider switching to CSS Grid for building these tables.
In the re-design, build with column selection possibilities in mind (#60).

Gonna chuck this in here as a discussion point since it's relevant to header clutter. It would be kickass if the solution implemented here were designed in such a way that it could work in an environment where item list columns are customizable.
Very recently I was talking with my group about which things they didn't and didn't like about how the base dnd5e sheet displays items, and it became apparent to me that folks have different preferences for what information is easily visible. For instance, I don't need to have spell school or range listed as columns on the spellbook tab, and I would disable those if I could. Allowing people this flexibility might be a cool future feature.

Two complaints I've often seen in the wild:

Tidy has too many tabs
Tidy's tables are too crowded

With the way things are going, column selection is a very compelling feature add.
The way I see it, module developers will eventually be able to register columns and append content to existing columns. So, with our tables already feeling kind of crowded in their current state, providing extensibility like actor column selection will keep things sane.
And, column selection will synergize with the work currently being done on #58

I've looked at this long enough to know that table horizontal space should be resolvable with custom columns and better overflow control. CSS Grid vs Flexbox is not the real debate when fixing item tables. Grid has its own challenges and suffers from the same problems of overflow. Moreover, to support pure CSS animations, careful subgridding would be required, and even then, conditionally hiding columns via pure CSS would be off the table. I'm saying goodbye to this issue and will pursue custom columns and conditional column hiding by priority.


Use non-blocking random generator.

In certain containerized environments the default random number
generator can get starved of entropy and it takes a very long time to
produce random bytes (as in 10s of seconds). To avoid this we can use a
non-blocking random generator instead.
More info: https://medium.com/@TamasPolgar/hack-how-to-use-securerandom-with-kubernetes-and-docker-a375945a7b21

Interesting - have you observed this in practice? I don't think I've ever seen this type of access to the default SecureRandom implementation blocking. According to the JCA docs the default providers on both Linux and MacOS have two non-blocking implementations listed before the blocking one. Is something setting the java.security.egd property to /dev/random in your application?
Either way, I'm a bit hesitant to encode a specific algorithm in a general-purpose library like this - working with defaults is the most flexible option and leaves the control in the hands of the consumer.

Yes, I have seen this in practice. With nothing setting any settings with regards to this. If you google around a bit you find that it's not "uncommon". Once I managed to pin it down to SecureRandom taking absolute ages (10s of seconds) it was then easy to find the case of certain containerized environments being starved of entropy causing the default SecureRandom to exhibit this behavior.
I agree that if working aroung it by setting /dev/urandom instead of /dev/random would be a better workaround. I wasn't aware of that -D setting so will experiment.
The blog post I linked about says this about the openjdk images - so there's some risk it might not be enough:

If I do end up with a need to override the random number provider I could try to add a more flexible way to override which provider is used without hard coding it.

Also found this SO thread which has some ways to override the providers. That'd also be a better way as I do need this more generally than just ken:
https://stackoverflow.com/questions/49322948/slow-securerandom-initialization
Btw, tested this little test both locally and in the relevant docker image:
import java.security.*;
import java.util.*;

public class testSecure {
    public static void main(String[] argv) {
          // Trying to see which secureRandom provider we are using
          System.out.println("Trying to output RNG source");
          SecureRandom secureRandom = new SecureRandom();
          System.out.println("Secure random source: " + Security.getProperty("securerandom.source"));
          System.out.println("java.security.egd: " + System.getProperty("java.security.egd"));
          System.out.println("Algorithm: " + secureRandom.getAlgorithm());
    }
}

What I see in both cases is:
rying to output RNG source
Secure random source: file:/dev/random
java.security.egd: null
Algorithm: NativePRNG
I'm done here

Passing the flag:
app@fe7747533f9d:/tmp$ java -Djava.security.egd=/dev/urandom testSecure
Trying to output RNG source
Secure random source: file:/dev/random
java.security.egd: /dev/urandom
Algorithm: DRBG
I'm done here

Trying to look further inside the docker image I see this:

And further searching gives this: https://tersesystems.com/blog/2015/12/17/the-right-way-to-use-securerandom/
Then going back to my starting point I can see the original code I had was actually using SecureRandom.getInstanceStrong(), copied from opentelemetry code I believe.
So all is well, it is the case of using getInstanceStrong() that caused blocking, not general use of SecureRandom. Case closed!

Okay, that makes sense to me - thanks for digging into this further! Glad to hear that we don't need to change alphabase specifically to address this. 👍


Feature request: get all tasks / bullets if the note properties is tagged.

Area Note
---
tags:
  - career
---

## Task

- [ ] task two
- [ ] task three
- [x] task one

## Bullet

- note one

Companion note
---
tags:
  - career
---

## Header

- [x] task one
- [ ] task two
- note one

## Heaer two

- [ ] task three

This will be a black box. It is recommended to use the dataview or tasks plugin:
task from #career

of
tags include #career


Automated cherry pick of #4288: fix: 允许关闭账号健康检查

Cherry pick of #4288 on release/2.12.
#4288: fix: 允许关闭账号健康检查

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@ea12386). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.12   #4290   +/-   ##
==============================================
  Coverage                ?   6.85%
==============================================
  Files                   ?     501
  Lines                   ?   85128
  Branches                ?       0
==============================================
  Hits                    ?    5837
  Misses                  ?   78797
  Partials                ?     494

Flag
Coverage Δ

#aFlag
6.85% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/storages.go
1.12% <0%> (ø)

pkg/compute/models/disks.go
0.62% <0%> (ø)

pkg/compute/models/vpcs.go
1.76% <0%> (ø)

pkg/compute/models/cloudregions.go
1.88% <0%> (ø)

pkg/compute/models/networks.go
0.56% <0%> (ø)

pkg/compute/models/cachedimages.go
2.15% <0%> (ø)

pkg/compute/models/zones.go
2.4% <0%> (ø)

pkg/compute/models/cloudproviders.go
1.01% <0%> (ø)

pkg/compute/models/hosts.go
0.34% <0%> (ø)

pkg/compute/models/skus.go
1.31% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea12386...2ab0332. Read the comment docs.


Signature flow question - clickable rectangle with "menu" buttons?

Hello, I'm new to pdf and maybe I'm approaching it in the wrong way, but I hope you could provide some guidance.
Basically I'm trying to implement a signature flow similar to hellosign.com
The way they do it is that one party adds a signature "box" and the other party can click it to add their signature. They can click the "box" one more time to edit or remove their signature.
Here is how it looks like:
A clickable box to add signature:

Once they click the box, it fires a "click" event I assume, so a custom dialog appears to setup the signature:

Once done, they can click the box again to edit or delete the signature:

The flow that I assume and the questions are as below:

I need to draw a clickable rectangle so that when someone clicks it, it will fire a javascript "click" event. (is that possible at all?)
once signature is available, to paste it to that rectangle (how to obtain the specific pdf object that was clicked?)

What is the best way to approach this?

@arthabus I have built many of these types of applications. I did it by using PDF2HTMLEx to convert the pdf to html. Then I modified their javascript file with a function that adds the boxes, opens the signature stuff when clicked on (also scroll and zooming features), then when they "save" the signature image is applied to the pdf on the backend. Done. I have also added Timestamp Authority to my software, but right now those are saved separately, but would like that feature to embed them in this library. https://github.com/Hopding/pdf-lib/issues/371
This library by itself cannot do what you want to do, as far as my understanding it.

thanks @MarcGodard! appreciate your input.
I was just playing more with hellosign interface and I can see now that they've just rendered the pdf as an image and overlaid it with everything else in html - that works just fine for my case.


two recipients in privateFor

Hi, I am sending a private tx with two pubkeys in the privateFor array but I'm not sure if it is possible in crux current version.

Hi, we ran into the exact same issue.
Possible reason
The commit 2e0330f1 seems to broke the function store. The change make it call api.Push at the end iteration over recipients instead of the iteration above, however, the encryptedPayload.RecipientBoxes is reset at here to be [][]byte{sealedBox}, which make the end iteration run into panic: out of range.
Reproduce
Modify the privateFor in scripts/simpleContract.js as below
privateFor: ["QfeDAys9MPDs2XHExtc84jKGHxZg/aj52DTh0vtA3Xc=", "1iTZde/ndBHvzhcl7V68x44Vx7pl8nwx9LqnM/AfJUg="]

Then run the 4-node example then geth attach to node1, call loadScript('script/simpleContract.js'), you will get err message shown in geth console as below
err creating contract Error: Send Payload failed: rpc error: code = Unavailable desc = transport is closing

Then crux1 will run into panic with these log message:
time="2019-03-14T17:23:50Z" level=debug msg="Processing send request" b64From= b64Recipients="[QfeDAys9MPDs2XHExtc84jKGHxZg/aj52DTh0vtA3Xc= 1iTZde/ndBHvzhcl7V68x44Vx7pl8nwx9LqnM/AfJUg=]" payload=606060405234156100000...000002a
time="2019-03-14T17:23:50Z" level=debug msg="Publishing payload" digest=f9477d4522a156e87c8c01e9684c576004466a322e03fc4f32566384a6f04863d75f20b73f9754cb70e4d1e41df06506c12404a19a6d45cff460d70fae798996 recipient=41f783032b3d30f0ecd971c4c6d73ce232861f1660fda8f9d834e1d2fb40dd77
panic: runtime error: index out of range

goroutine 32 [running]:
github.com/blk-io/crux/enclave.(*SecureEnclave).store(0xc4200c66e0, 0xc420077320, 0xc4200a6340, 0xc4200a6360, 0xc4201cb050, 0x2, 0x2, 0x5626780d8dad, 0xc4200c8000, 0xc4205f81e0, ...)
    /quorum/crux/.GOPATH/src/github.com/blk-io/crux/enclave/enclave.go:195 +0xcd8
...

@thericciflow please see #59 (fix the problem)


Additional pre-requisites w.r.t S3-compatible storage

Description
https://issues.redhat.com/browse/RHOAIENG-666
Attempting to add clarity concerning object storage in this module: Users need access to and use S3-compatible object storage for storing their datasets. The described procedure doesn't "create" a bucket but creates a data source connection to the bucket so that the model to be deployed can access datasets as needed.
How Has This Been Tested?
Local Build
Preview

lgtm


When the "delete" button is dismissed the row remains highlighted

After clicking the row to dismiss the "delete" button, the row maintains it's highlighted state.

@elroyjetson offered up a fix for this by removing the active class when the row is tapped.


No module named 'gradio_i18n' on google colab

Which OS are you using?
Google Colab
On Run status, im getting error message
File "/content/Whisper-WebUI/Whisper-WebUI/app.py", line 4, in
from gradio_i18n import Translate, gettext as _
ModuleNotFoundError: No module named 'gradio_i18n'

@joonseo0505 Ah, thanks for noticing me!
This was fixed in #343 and worked fine.
Please let me know if the problem persists!

Thank you for the quick action! But last month [update gradio to 4.43.0] -> [merge pool request] had a similar issue, so I forked this repository for that commit and tried to run it today, but there was an error "No module named 'whisper'" just didn't work either. Is there a way to run 100% on the previous commit/fork?

Closing asumming this is resolved,
Feel free to reopen it!


Docker image

This PR contains the Dockerfile with which the image of the repo can be built.

Resolved!

Apparently, the reading of the simualtor address does not work properly:
Failed to connect to <IP_ADDRESS>:10001 (attempt 1 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 2 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 3 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 4 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 5 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 6 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 7 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 8 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 9 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 10 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 11 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 12 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 13 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 14 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 15 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 16 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 17 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 18 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 19 / 20)
Failed to connect to <IP_ADDRESS>:10001 (attempt 20 / 20)
Failed to connect after 21 attempts. Giving up on connection
terminate called after throwing an instance of 'std::logic_error'
  what():  RobotClient is not connected

Another word of warning as well, 20 attempts spaced by 1 sec (default implementation) might not be sufficient if spawning the robots takes 60 seconds.

Apparently, the reading of the simualtor address does not work properly:

Ohhh. I totally forgot about this. Right now the image needs special arguments like --ros-args -p host:="<IP_ADDRESS>" -p port:=10001 but indeed it makes a lot of sense that there should be an entrypoint that reads the environment variables and passes it to the ros node.


[WIP] Autosuggest should obey week start

fixes #33
So, this kinda works. But the problem is that it uses the "week start" setting from the Calendar plugin instead from NLDates 😕

I have an unpushed branch with some changes to the parser. We could use the start of the week as defined by moment (and that setting can be tuned by the calendar settings). Would that work better?

I bumped into the same issue today which I presume will be solved by this PR (i.e. next xxx doesn't work as expected on Sunday when my week starts on Monday). Are there any hold ups to merging this PR aside from the issue above? I'll be happy to take a look when I have some time (I'm completely new to Obsidian though so it might take me a while to orient myself).

Closing this PR in favor of #57 (which as a more complete fix for this issue)


Fix redundant resources

Removed all cluster.yaml files by automatically assigning CPUs based on {threads} and moving additional resources requirements of DeepVariant to the rules.
Added example batch scripts for lsf
Added profiles for slurm, sge, and lsf to define default-resources
Moved tmpdir specification from config to profiles and confirmed that both TMPDIR and SINGULARITY_TMPDIR are correctly assigned

resolves #67

Tested slurm and local (80 cores), completed all steps of workflow


[occm] Get occm pod logs when CI job fails

What this PR does / why we need it:
Currently when the CI job fails, we can't see the pod logs, making it hard for troubleshooting.
This PR also fixes the image tag issue.
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

/test openstack-cloud-controller-manager-e2e-test

/test openstack-cloud-controller-manager-e2e-test

/test openstack-cloud-controller-manager-e2e-test

/test openstack-cloud-controller-manager-e2e-test

Found the issue, we were using PR number as the image tag which is not allowed any more after you fixed the version issue.

as the image tag which is not allowed any more after you fixed the version issue.

ok ,didn't expect such side effect
so we need additional fix to the version thing .. let me know anything I can help

ok ,didn't expect such side effect
so we need additional fix to the version thing .. let me know anything I can help

All good now, I added the fix in this PR.

Thanks.
/lgtm

/approve


Migrate vienna subscriptions from a machine that no longer exists?

Migrate a vienna subscriptions list from a backup of a macbook pro that no longer exists to another MBP?

What you need is located in the Vienna folder inside your Library's Application Support folder :
\Users\USER_NAME\Library\Application\ Support\Vienna
or
~/Library/Application\ Support/Vienna
Restore either the entire Vienna folder or just the messages.db file inside it.


add systembetriebsart 36

Hi
could you please add
StatusItem(36,"Vorlauf regenerativ")
thank you

Sure!

Done in next version. Please feel free to contribute other codes when you know them.


Trading issues

When the transaction is usdt, the returned information indicates that the transaction has been submitted, and there is txid, but it can not be found on https://omniexplorer.info/website. I hope I can get your help，Thank you!

QbitNinja does not support Omni.


Unpin pydantic, allow v1 or v2

curies is a distal transitive dependency of many packages, it needs to be neutral w.r.t pydantic version. It looks like it already is, and the pinning to <2 is unneccessary
For more context see https://github.com/biopragmatics/bioregistry/issues/920

I’d like to see explicit testing for both versions running. I tried this before and didn’t find it so easy unfortunately

shall we get the sphinx fixed first then experiment with changes to gh actions to run with both versions of pydantic?

High priority for me as well now! Thanks for getting the ball rolling!

Codecov Report

Merging #64 (0fe4737) into main (77271fa) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 0fe4737 differs from pull request most recent head 3bc66a2. Consider uploading reports for the commit 3bc66a2 to get more accurate results

@@            Coverage Diff            @@
##              main       #64   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          554       554
  Branches        87        87
=========================================
  Hits           554       554

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I think it's the case that Pydantic rolled back some of its v1-v2 problems - one of the big issues was the config class that lives inside the actual base model subclass. This appears to be a "deprecation" now instead of being fully unavailable. This changes things wrt the previous try, making this easier. I have now solved all of the documentation and testing concerns, and can merge this + make a new release.

Release 0.6.0 reflects this update


100% code coverage for Renumbering

[x] get local codecov running

install https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
pip install pytest-cov
pytest --cov=. tests/ --cov-report xml:cov.xml
enjoy

[x] g3 100%
- [ ] numbering 100%
- [ ] renumbering 100%

Each file should have it's own PR. The code cov is helping refactor so it should be done in bit sized pieces.


Github Package Registry Integration

Hi there. I just found hub and I think it's a really cool tool that I plan on using within GitHub Actions. Part of what I want to be able to do is publish to the GitHub Package Registry. Would interaction with the registry be possible through an additional command? I poked around through the issues and PRs here and I didn't seem to find any previous mention of this.

No, this wasn't planned. What kind of GPR interaction would you envision hub to have? Is it something that you could feasibly implement manually using hub api?

I'd have to poke around for a while. Maybe it could be done with hub api.
That's a good idea. I'll give it a shot if I get the chance.
On Fri, Sep 27, 2019, 10:41 AM Mislav Marohnić<EMAIL_ADDRESS>wrote:

No, this wasn't planned. What kind of GPR interaction would you envision
hub to have? Is it something that you could feasibly implement manually
using hub api?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/github/hub/issues/2279?email_source=notifications&email_token=ABVLCFJKGJPEQJOQETALZHDQLYLQFA5CNFSM4I2NC7XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ZDV3I#issuecomment-535968493,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVLCFKN343T5B3YHXM7GRLQLYLQFANCNFSM4I2NC7XA
.

I would be inclined to close this unless you have some specific feature to suggest for hub. Interaction with GitHub API is available through hub api (this can be useful within Actions) and publishing to Package Registry is already available using supported package tools such as npm publish or gem push. https://help.github.com/en/articles/about-github-package-registry#supported-clients-and-formats

No worries. Feel free to close this.


Swap -f audio+video format input

Before submitting a pull request make sure you have:

[x] Searched the bugtracker for similar pull requests
[ ] Read adding new extractor tutorial
[x] Read youtube-dl coding conventions and adjusted the code to meet them
[x] Covered the code with tests (note that PRs without tests will be REJECTED)
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
When I use -F to explore the format options for Youtube I get the output with audio options first and then video options which I then pass to -f as <audio_format_code>+<video_format_code>. I got an error saying the input should be video first and then audio. This PR is a simple code change to check if the input is audio first and then video, and if so swap them.

Previously: #5154, #5581, #8157 and the even more general #6454. Apparently the maintainers here aren’t interested in fixing this issue.
Meanwhile, yt-dlp has had it fixed way since before it was even forked from youtube-dlc. I recommend you try it.


V8/V9 server not connecting (staying connected)

after connecting through alvr, when i start server, steam vr launches then crashes a few moments afterwards, this problem was present at the release of v8 and has continued onto v9, though both of these versions do not work, v7 has still worked flawlessly, currently it displays the hmd on the most recent steam vr 1.10.32, but no controllers. ive had no luck with either #90 nor #142 issue fixes. ive tried deleting local appdata , and also have the latest vc++ along with attempting a few other quick fixes

your issue sounds VERY similar to my issue, fortunately I pinpointed the cause. This might be your case as well. See #160
That might be the fix, although if you are using that feature in particular, you will have to wait for a fix.

no luck im afraid, just tried it and it still crashed

i believe i have narrowed the problem down to the keplar mobile series graphics cards being no longer supported for graphics driver updates after 425.31. should v8/v9 rely on the newer drivers it could very well be possible this is the issue. though i am still uncertain the newer alvr versions rely on the new drivers in shape or form


Remove jen2000 from codeowners file, replace with ARBOC

Description
@jen2000 has left the Transcom org in https://github.com/transcom/ppp-infra/pull/508. Instead of having only @ntwyman in codeowners I've replaced her with the team leads. Happy to make other changes too but figure we should have more than one person on the ADR review.
Code Review Verification Steps

[x] Request review from a member of a different team.
[x] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change

Thanks!


Add Potions Pages

Summary

Added Potion Index and Show Pages
Created Skeleton Animations that fit content
Added Potions link to Footer
Added Potions Type
Added extra prop to Load More Button
Added metadata for SEO
Added re-usable components that make up index and show pages

Related Issues

This closes #764
Checklist

[x] This pull request has a meaningful title and description.
[x] I have read and followed the Contributing guidelines.
[x] My code follows the conventions and coding style of this project.
[x] All tests pass and I have added tests for my changes
[x] I have updated necessary documentation

Screenshots (if applicable)

Additional information

@danielschuster-muc let me know if you have any feedback please.

Thank you very much sir! If there is nothing else to add, I would like to open up another PR to refactor the new changes to the new-website branch after this one is merged :)

Thank you very much sir! If there is nothing else to add, I would like to open up another PR to refactor the new changes to the new-website branch after this one is merged :)

Maybe you could also wait for #765 as this adds Spell Pages before you create a PR for the refactoring.

Sure will do. Thank you!


Reorganize examples page to better list out examples

Updates list of examples
Orders by beginner, intermediate, advanced
Links to github py rather than list the source code in the page.

Do you see the 16 comments I sent on this PR? Github still nags me for review, but I already did it yesterday.

Yes, I see the review.  Thanks for the quick turn-around.  I will address them later today.  I am not sure why github is bothering you.


Get user's birthday field if available

👍

@SammyK Could you review this pull request? :D

Thanks for the PR @leobaetarj!
The birthday field requires a special user_birthday permission which requires approval from Facebook. It's not the same as the email permission since the email permission does not require a special approval review. By default we only want to pull in User fields that don't require a permissions approval review from Facebook.
For that reason, I cannot merge this PR at this time.
If your app is approved to use the user_birthday permission and you want to access the birthday field on the User node, just use your user token to make another GET request to retrieve it.
$params = http_build_query([
    'fields' => 'id,birthday',
    'access_token' => $token->getToken(),
    'appsecret_proof' => hash_hmac('sha256', $token->getToken(), '{facebook-app-secret}'),
]);
$response = file_get_contents($baseUrl.'/me?'.$params);

I hope that helps! Thanks again for taking the time to send a PR! :)


Update vcfsort

use 1GB memory for vcf sorting by default

Coverage remained the same at 63.989% when pulling c5aea23d082a5ac67b6df08d7e65874d54c63fd9 on cc2qe-patch-1 into f2edb81eef7438ba62a3b202a193f2101161d931 on master.

See #182


Navigator _popN does not update routeStack state

The navigator keeps the routestack in state, this seems to be used by getCurrentRoutes. I noticed this gets updated on push but not pop/popN.
I'd expect a state update similar to the following:
this.setState({
idStack: nextIDStack,
routeStack: nextStack,
sceneConfigStack: nextAnimationConfigStack,
updatingRangeStart: nextStack.length - 1,
updatingRangeLength: 1,
});

@ericvicenti

I just did a small test can't get to replicate this though.

Agreed- a simplified example on RNPlay would be great to see
Currently, (and I agree that it's not ideal,) the Navigator will only remove the popped routes once the pop animation completes.

New Navigator is in progress, you can comment on it here: https://github.com/ericvicenti/navigation-rfc

New Navigator is in progress, you can comment on it here: https://github.com/ericvicenti/navigation-rfc


Reduced complexity through extraction of code into readable functions and reduced nesting

Breaking change

Proposed change
Extracted some of the code to make it more readable, reduced some if statement logics and replaced it with readable function names explaining behaivor. First, the state setting could be extracted to a standalone function with a readable name to fetch the states. Instead of setting the same state class variables in multiple places, it is done once with a tuple return. Second, returning instead of nesting a statement inside an if statement will always be more readable and will function exactly as before.
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] I have followed the perfect PR recommendations
[x] The code has been formatted using Ruff (ruff format homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

This PR might introduce a breaking effect. Did you test it?


feat(ci): allow for linting of the templates

Depends on:

[x] #1221
[x] #1234
[x] #1327
[x] #1329

TODO

[x] Add comment at the top describing the purpose of generate-all-templates.js
[x] Add inline comments where necessary
[x] exit in case of an error generating code from a template?
[x] Update yarn.lock

What do you folks think about it, do we need to lint and check for errors of the generators themselves and generated code?

Yes I'd love to land this! We really really need it!

Coverage decreased (-21.7%) to 76.923% when pulling ff2f46cd796ab38bd3620d1ea9b4baa8a670991a on Dattaya:lint-generated-templates into de60cd3dc4f28a94c7a39d2c7cf3f60fd0ba0fbb on mxstbr:dev.

Coverage decreased (-21.7%) to 76.923% when pulling fdd372cde0a4dab279dba318ed5e854d82a9cc88 on Dattaya:lint-generated-templates into de60cd3dc4f28a94c7a39d2c7cf3f60fd0ba0fbb on mxstbr:dev.

Coverage increased (+0.007%) to 98.592% when pulling 4d5a77d67100a01b882d3336030fdb3b43efb9f2 on Dattaya:lint-generated-templates into de60cd3dc4f28a94c7a39d2c7cf3f60fd0ba0fbb on mxstbr:dev.

@Dattaya Re: merge conflict:

I presume the eslint disable was a temporary measure? Or are you suggesting a different  handling?
The conflict is with #1327 which this PR "depends" on. My thought is that since we are generating a stub to be completed by the end user (developer), the eslint disable is more confusing, it looks more like there might be a reason for it that the dev will not immediately grasp. The return null is fine until one looks at a real sagas.js in the example app and sees there is no need for the return.
Now that I have looked at this more closely, maybe a better approach would be to remove the truly useless return and replace it with an informative comment e.g.

// See example project containers/HomePage/sagas.js

That eliminates the lint error and makes the project more usable all at the same time :smile:
I have edited the conflict with that solution, feel free to disagree 😉

Coverage increased (+0.007%) to 98.592% when pulling 75f652173b29eaa55dc79657659d1b3401ef56e0 on Dattaya:lint-generated-templates into 7b9581eea430a8d686e566a8d5f7e5fea201a8a4 on mxstbr:dev.

@gihrig, many thanks for merging those two PRs and looking into this one ❤, that means I will be able to finish it today.

I presume the eslint disable was a temporary measure?

Yes, that's correct, and I prefer your solution, because it's conciser, either way a dev would delete it.

Now that I have looked at this more closely, maybe a better approach would be to remove the truly useless return and replace it with an informative comment e.g.

Sounds like a good idea to me.

Coverage increased (+0.007%) to 98.592% when pulling 669a4b7de2b6be112e09ccecbf8caa7fcc8bb185 on Dattaya:lint-generated-templates into 7b9581eea430a8d686e566a8d5f7e5fea201a8a4 on mxstbr:dev.

Coverage increased (+0.007%) to 98.592% when pulling c7f63aea6cf6d7a69a639238268d5073d9ed68ac on Dattaya:lint-generated-templates into 7b9581eea430a8d686e566a8d5f7e5fea201a8a4 on mxstbr:dev.

Coverage increased (+0.007%) to 98.592% when pulling cf59b53ed201fc3884ef2a51c994aa6adc22678e on Dattaya:lint-generated-templates into 7b9581eea430a8d686e566a8d5f7e5fea201a8a4 on mxstbr:dev.

Coverage increased (+0.007%) to 98.592% when pulling cf59b53ed201fc3884ef2a51c994aa6adc22678e on Dattaya:lint-generated-templates into 7b9581eea430a8d686e566a8d5f7e5fea201a8a4 on mxstbr:dev.

Coverage increased (+0.007%) to 98.592% when pulling dfe1b6470c106bca9c2f9ac09dfee23f642c4ec9 on Dattaya:lint-generated-templates into 7b9581eea430a8d686e566a8d5f7e5fea201a8a4 on mxstbr:dev.

Coverage increased (+0.007%)

Good one, coveralls, 😁
Now my TODO list is empty, except the one TODO you can see in generate-templates-for-linting file, but it's not a big deal, console.error is synchronous on Mac according to the Node.js docs, but it also behaves synchronously on Windows in my experience, all error messages were successfully flushed into the terminal, it can be left as is until we experience any issues with it.
Should be ready for review. If you have any questions about this PR, don't hesitate to ask them.

Coverage increased (+0.007%) to 98.592% when pulling a698d96637ba905258a60e6f5b44b2b1d12a5c3b on Dattaya:lint-generated-templates into 7e763894bba85401996ddeffe079bc35c8dd4124 on mxstbr:dev.

Coverage increased (+0.007%) to 98.592% when pulling 6b5327ce5bc3a18f7fa0445c23fc4d313f1ea7b8 on Dattaya:lint-generated-templates into 4eff7a3b4c733e224166d48de0c0aa11e9cc8e4f on mxstbr:dev.

I imported your branch lint-generated-templates (88f35e95fd332ffaaeaa3dc4602e1ab5d5a74a30) into my RBP local project.
I pushed to my GitHub repo (setup for Coveralls, Travis and AppVeyor).
Both Travis and AppVeyor successfully completed the build.


Error:Failed to open zip file.

Error:Failed to open zip file.
Gradle's dependency cache may be corrupt (this sometimes occurs after a network connection timeout.)
Re-download dependencies and sync project (requires network)
Re-download dependencies and sync project (requires network)

To me this seems like it could be that Android Studio is having problems connecting to the network. You should check that it's not being blocked by your firewall or virus scanner.


[C++][Parquet] Set ColumnMetadata.encoding_stats field

This metadata field is not set in the C++ library.
Reporter: Wes McKinney / @wesm
Assignee: Gamage Omega Ishendra](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=omega_gamage)
PRs and other links:

GitHub Pull Request #6370

Note: This issue was originally created as PARQUET-1780. Please see the migration documentation for further details.

Wes McKinney / @wesm:
Issue resolved by pull request 6370
https://github.com/apache/arrow/pull/6370


Add Modal's keyboard escape and focus options to Toasts

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Add configuration options to Toast components that allow for keyboard escapes and element focus using the same methods as modals.
Motivation and context
Modals contain configuration options that allows for toggling off/on the ability for the user to keyboard esc to close and grant focus to the modal-window on init. Toasts can be used for similar, but less intrusive purposes in the UI, and allow to disable the autohide feature, but don't currently allow for keyboard escape options or focus, though they are perfectly capable of housing user inputs, meaning they are partially obscured from non-mouse users. Adding the same option gives both the developer and the user greater control over visibility of toasts.

@patrickhlauke can you give us your opinion over this?

I think this will need a slightly bigger, planned rethink of how some of our components should work/be exposed. There's crossover between alert components, toast components, and modal dialogs - different facets across all of them, and in some instances the line between these components gets a bit blurred.
Being able to explicitly say "move focus to the toast" (and the same probably also for alerts) would certainly be a good idea. How closing is handled though will need consideration - similar to modal dialogs, once the toast is explicitly closed, focus should programmatically return to whatever had the focus last/before the toast popped up. We'll also need to put up explicit guard rails so that IF a toast exhibits this new focusing behaviour, that it never automatically disappears/closes (as otherwise it would leave the focus dangling in limbo).
Suggest we plan this out more thoroughly for 5.3, but the general idea proposed here is sound.


Enable unikernel runtime log

enable basic unikernel log, we still need vm wrapper to reformat log from qemu.
enable vm ACPI, if not, it will hang at start time.
fix domain copy in ListDomains
enable basic libvirt bridge network for debug purpose.

/cc @feiskyer @resouer PTAL

This change is


[$250] IOS/Android - Attachment- App crashed after tap on link

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app
Log in with expensifail account
Go to any conversation and tap on plus button
Select Add Attachment
Select any attachment and Send
6.. Hold with finger by the attachment until option menu is displayed
Select Copy Link option
Insert link to the conversation
Tap on link

Expected Result:
App is not crashed after tap on link
Actual Result:
App crashed after tap on link
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any expensifail account
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/176456166-9cca8380-cda8-4f14-a0e9-85748b443051.MP4

Upwork job link: https://www.upwork.com/jobs/~012c15c3203494d613
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Mistakenly added External. I can do this

ooo so assigning to a teeammate!

@ctkochan22 quick question - is this internal or external? Seems the label has been added/removed a few times.

Its external. I accidentally put the label on once because I wanted to fix it. But with n7 I don't have time so I need to pass it off. MY bad

Ah makes perfect sense. No problem at all, this is precisely the reason we have external assignment and outsourcing :)
I'll get it moving.

Job link - https://www.upwork.com/jobs/~012c15c3203494d613

Applied for job link

Applied for job link

@woodenlabs Got me a bit confused here. If you're planning to add a proposal, please refer to this contribution guidelines and specifically proposing solution

This crash happens when try to open deep link with reportActionID
Current deep link implementation handles r/:reportID (chatroom deep link) which goes to report screen but not handling r/:reportID/:reportActionID (message deep link in chat room)
It's a new feature to implement scrolling to specific message (when click message deep link).
So for now, I suggest redirecting to room deep link when click message deep link as a temporary solution, until that new feature implemented.
i.e.
https://staging.new.expensify.com/r/97208274/1065573786 can be redirected to
https://staging.new.expensify.com/r/97208274
I will create PR as soon as my suggestion approved.
I applied for job on upwork

I'll need a day to investigate the issue and review @errahsoufiane's proposal.

I agree with @errahsoufiane's evaluation. But I am not sure if we should redirect to the chat instead of the attachment.
@NikkiWines @michaelhaxhiu What do we think of the expected behavior here?  I would have been great to load the exact chat, but I am not sure how it'll work with pagination.

Sorry, I'm OOO this week. Assigning another contributor manager to take this over while I'm out

I agree with @errahsoufiane's evaluation. But I am not sure if we should redirect to the chat instead of the attachment.
@NikkiWines @michaelhaxhiu What do we think of the expected behavior here? I would have been great to load the exact chat, but I am not sure how it'll work with pagination.

@Gonals @michaelhaxhiu  Can someone please confirm this?

Sorry for the delay, looking now.

Hmm @mananjadhav I'm a little conflicted. I do think re-directing to the chat would be ideal. But would that be significantly harder to accomplish or do you feel it's a breach of scope?
This could be a good opportunity to post it in #expensify-open-source for more input, too.

Thanks @michaelhaxhiu. Started the slack thread here

@michaelhaxhiu @Gonals Based on the chat here, our solution for the time being would be to hide the Copy Link behind the betas. The Key for the beta is BETA_COMMENT_LINKING. Can we please have the GH body updated for the expected fix.
@errahsoufiane If you're keen on working on this, can you please send in a revised proposal to get this expected behavior.

Updated Proposal:
    {         textTranslateKey: 'reportActionContextMenu.copyLink',         icon: Expensicons.LinkCopy,         shouldShow: () => Permissions.canUseCommentLinking,         onPress: (closePopover, {reportAction, reportID}) => {             Environment.getEnvironmentURL()                 .then((environmentURL) => {                     const reportActionID = parseInt(lodashGet(reportAction, 'reportActionID'), 10);                     Clipboard.setString(${environmentURL}/r/${reportID}/${reportActionID});                 });             hideContextMenu(true, ReportActionComposeFocusManager.focus);         },         getDescription: () => {},     },
Here, we can update shouldShow like this: shouldShow: () => Permissions.canUseCommentLinking,

@errahsoufiane I don't see a function canUseCommentLinking, can you expand your proposal to share the implementation for the same?

@errahsoufiane I don't see a function canUseCommentLinking, can you expand your proposal to share the implementation for the same?

@mananjadhav updated

@errahsoufiane's proposal is good. @Gonals all yours
@chiragsalian Tagging you just in case we get the betas key incorrect.
🎀 👀 🎀
C+ reviewed

The proposal looks good! @errahsoufiane, feel free to go ahead and create a PR following the steps detailed above!

@errahsoufiane just accepted you on the Upwork job. We'll stay tuned for your updates on this GH while you go 🤓

Update on behalf of @errahsoufiane. It seems this is in progress, but the PR hasn't merged successfully to staging.
https://github.com/Expensify/App/pull/10071#issuecomment-1201803371

paid.


Fix env

修复 #148

Coverage decreased (-4.7%) to 83.245% when pulling d3e1d59a126ecb3d20fa0d65603d3aead7f2505d on fix-env into 613c7b3b4599fdb77c81c65dddee9069e537748f on master.


Scaling in cplex interface

Hi, I experienced that modifying the objective in the cplex interface scales badly.
For a model with about variables setting the objective takes about half of the time when optimizing (see "cumtime" column which is the time the function call and all sub-calls takes):
 1174604 function calls (1050578 primitive calls) in 0.698 seconds

   Ordered by: cumulative time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
        1    0.000    0.000    0.698    0.698 {built-in method builtins.exec}
        1    0.000    0.000    0.698    0.698 <string>:1(<module>)
        1    0.000    0.000    0.698    0.698 parsimonious.py:27(pfba)
        1    0.003    0.003    0.698    0.698 parsimonious.py:138(_pfba_optlang)
        1    0.000    0.000    0.471    0.471 parsimonious.py:102(add_pfba)
        2    0.000    0.000    0.415    0.207 cplex_interface.py:713(objective)
        4    0.000    0.000    0.295    0.074 _subinterfaces.py:3852(set_linear)

However for a model with ~200.000 variables it now takes 95% of the time.
         40679344 function calls (36037663 primitive calls) in 257.649 seconds

   Ordered by: cumulative time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
        1    0.000    0.000  257.649  257.649 {built-in method builtins.exec}
        1    0.000    0.000  257.649  257.649 <string>:1(<module>)
        1    0.000    0.000  257.649  257.649 community.py:275(optimize)
        2    0.015    0.007  249.575  124.788 cplex_interface.py:713(objective)
        4    0.009    0.002  244.498   61.125 _subinterfaces.py:3852(set_linear)

I did not observe the same effect with the other solver interfaces.

I cannot replicate this. Can you provide a snippet?

Sure. I hope it is ok to use cobrapy, much easier to set up the test case...
In [1]: from cobra.test import create_test_model

In [2]: from cobra.io import read_sbml_model

In [3]: from cobra.flux_analysis import pfba

In [4]: import cProfile

In [5]: small = create_test_model("textbook")

In [6]: small.solver = "cplex"

In [7]: large = read_sbml_model("/home/cdiener/Downloads/recon_2.2.xml")
cobra/io/sbml.py:235 UserWarning: M_h_c appears as a reactant and product RE3453C
cobra/io/sbml.py:235 UserWarning: M_h_c appears as a reactant and product RE3459C
cobra/io/sbml.py:235 UserWarning: M_h_x appears as a reactant and product FAOXC24C22x
cobra/io/sbml.py:235 UserWarning: M_h_c appears as a reactant and product HAS1
cobra/io/sbml.py:235 UserWarning: M_h2o_x appears as a reactant and product PROFVSCOAhc

In [8]: large.solver = "cplex"

In [9]: cProfile.run("pfba(small)", sort="cumtime")
         43637 function calls (39034 primitive calls) in 0.035 seconds

   Ordered by: cumulative time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
        1    0.000    0.000    0.035    0.035 {built-in method builtins.exec}
        1    0.000    0.000    0.035    0.035 <string>:1(<module>)
        1    0.000    0.000    0.035    0.035 parsimonious.py:27(pfba)
        1    0.000    0.000    0.035    0.035 parsimonious.py:138(_pfba_optlang)
        1    0.000    0.000    0.021    0.021 parsimonious.py:102(add_pfba)
        2    0.000    0.000    0.019    0.010 cplex_interface.py:713(objective)
        5    0.002    0.000    0.012    0.002 basic.py:405(atoms)
        1    0.000    0.000    0.012    0.012 solver.py:96(set_objective)
        1    0.000    0.000    0.012    0.012 model.py:978(__exit__)
        1    0.000    0.000    0.012    0.012 context.py:32(reset)
        1    0.000    0.000    0.012    0.012 solver.py:158(reset)
        4    0.000    0.000    0.009    0.002 _subinterfaces.py:3927(set_linear)
       ...

In [10]: cProfile.run("pfba(large)", sort="cumtime")
         3445392 function calls (3067877 primitive calls) in 2.891 seconds

   Ordered by: cumulative time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
        1    0.000    0.000    2.891    2.891 {built-in method builtins.exec}
        1    0.000    0.000    2.891    2.891 <string>:1(<module>)
        1    0.000    0.000    2.890    2.890 parsimonious.py:27(pfba)
        1    0.001    0.001    2.890    2.890 parsimonious.py:138(_pfba_optlang)
        2    0.001    0.000    2.103    1.051 cplex_interface.py:713(objective)
        1    0.001    0.001    1.761    1.761 parsimonious.py:102(add_pfba)
        4    0.001    0.000    1.737    0.434 _subinterfaces.py:3927(set_linear)
      ...

The set_linear function takes up about 1/4 of the time for the small model (100 reactions) but half of the time for the large model (10000) reactions. For a model with 100,000 reactions it takes up more than 90% of the function call. I once read in the cplex docs that they don't recommend using named variables for large models since it will be slower, don't know if that is related though...

Ok, that helped. Now I see the problem, it's actually the cplex function that's slow. As far as I can see the issue is, as you pointed out, that referencing variables based on names is slow. The main part of the time in set_linear is spent running get_indices. It seems like cplex doesn't keep a mapping between names and indices, since the time it takes to look up the index of a name scales roughly linearly with its position.
To get around this I guess we could use the name -> index mapping that's already being kept by the .variables Container object. I'm not quite sure though if there would be cases where the two indices wouldn't be the same...

Maybe the indices would change if you delete a variable? I agree that it might be better to have optlang manage the variable -> mapping as in glpk. However, I think it's not high priority for now since it would be quite a lot of work...

I've managed to fix this specific issue with a relatively simple change. Modifying the objective should now scale linearly with the number of variables in the objective instead of quadratically. The get_indices issue might also be a problem in other cases where a function is called with a large number of variables/constraints, but changing the objective is probably where this happens most frequently.
Setting a pFBA-like objective on a model with 200,000 variables now takes a few seconds, comparable to GLPK.


deps: Upgrade Flutter SDK and video_player_android

Fixes the CI failure: https://github.com/zulip/zulip-flutter/actions/runs/11063896720/job/30740794793#step:7:1899

(If Android builds were part of Flutter's Customer test suite (https://github.com/zulip/zulip-flutter/issues/774), it would have added more friction on https://github.com/flutter/engine/pull/55463.)

Thanks for digging into this! I noticed CI fail on #967 last night, but it was right at the end of my day so I didn't investigate.
If I understand the commit messages right, tools/check --all would always fail at the middle commit, right? That commit makes us start requiring a Flutter version that will always cause that warning.
In that case, can the two commits go in the opposite order instead? I expect that way things work at every step (if you use the minimum required Flutter version), which is our usual approach because it makes things a bit cleaner to understand.

Thanks for the review @gnprice, pushed a revision with reordered commits and updated commit message.

Thanks! Looks good — merging.
I tweaked the commit message a bit:
-    Without this update, Android builds will fail with Flutter
-    SDK revisions after this commit[0], due to our strict
-    warnings as errors config in `app/build.gradle`.
+    Without this update, Android builds will fail with Flutter SDK
+    versions after the following change that landed yesterday:
+      https://github.com/flutter/engine/pull/55463
+      https://github.com/flutter/flutter/commit/7bb9352911d0471568a77fc57b94a646fe9571af
+    due to our strict warnings as errors config in `app/build.gradle`.
     The build error would look like this:

       /…/video_player_android-2.7.3/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java:88:
       warning: [removal] onSurfaceCreated() in Callback has been deprecated and marked for removal
         public void onSurfaceCreated() {
                     ^
       error: warnings found and -Werror specified

-    [0]: https://github.com/flutter/engine/commit/c2c242d50cf8d78057f347f600460f17c102e927
-

mainly because the reference to "this commit" sounded like it meant this commit, i.e. the one the commit message is on. (I think just putting the link immediately after the reference, instead of down in a footnote, would have been enough to fix that problem. But then once I was editing it, I changed "this" to "the following" to further disambiguate, and added a bit more information too.)

(If Android builds were part of Flutter's Customer test suite (#774), it would have added more friction on flutter/engine#55463.)

This is a good reminder that #774 would be good to do… but I think having our Android build there wouldn't actually have affected this. That's because that repo's policy is that deprecation warnings are to be ignored. It says:

The tests must pass even if there are analysis 'info' level issues in the code. Generally, this means that if the test performs static analysis, it does so ignoring info level items (i.e., flutter analyze --no-fatal-infos).

and the point of that is precisely about deprecation warnings — they want to be able to add deprecations and have those not be breaking changes. (Later when they actually remove the deprecated item, I guess that's a breaking change if people haven't migrated.)
So that's something I'll want to watch for when implementing #774. I'll make a note there.


[Ibis] Add read_csv / load data to Ibis

@aregm this is really more for the Ibis project. Also, ibis is just an API over other sources - including pandas. So you can actually load a pandas DF from csv (or parquet via pyarrow) and then connect to it via ibis - see https://docs.ibis-project.org/getting-started.html#pandas-quickstart


Unable to login with 'Enter' key press

The login button is only pressable after field validation, which only happens after fields lose focus.

This means that I have to click twice when I want to login (one to lose field focus, and another one to click on the login button)
Validation should be made on each key press?

Fixed


for public dashboard

for public dashboard:
generic statistics (aggregation of inventory) - no of surveys, KM's of effort, temporal coverage, species coverage - records of species (mix of charts and stats)
Originally posted by @neil-ices-dk in https://github.com/ices-tools-dev/cetaceans/issues/126#issuecomment-1149845759

First draft of the dashboard: https://cetaceans.ices.dk/dashboard

really good visual summary Carlos 👍

Thanks @cmspinto! Nice to have something to work with - @NikiClear and I have added some thoughts to this doc to consider/discuss...
Dashboard_NT_NC.docx

Can we remove the two graphics that refer to access type – I don’t want to highlight how much data is restricted… :)

i think we need to discuss justification of surpressing this info, what is it we are afraid of?

Can we remove the two graphics that refer to access type – I don’t want to highlight how much data is restricted… :)

i think we need to discuss justification of surpressing this info, what is it we are afraid of?

Happy to discuss - it's not about supressing the info, it's about choosing where we highlight it. The dashboard is an engagement tool for this db and highlighting how much data are restricted is a bit of a kick in the teeth against what we are trying to achieve. By not having a graphic here, we are not hiding the fact there are restricted data in the system, that is clear throughout the process docs and download system. But in the engagement tool where we are trying to support the JCDP and highlight the great steps forward in making data accessible - it's not great to have a graphic that shouts out much of the data are (currently) restricted and I don't feel we need to refer to this here.

Can we remove the two graphics that refer to access type – I don’t want to highlight how much data is restricted… :)

i think we need to discuss justification of surpressing this info, what is it we are afraid of?

Happy to discuss - it's not about supressing the info, it's about choosing where we highlight it. The dashboard is an engagement tool for this db and highlighting how much data are restricted is a bit of a kick in the teeth against what we are trying to achieve. By not having a graphic here, we are not hiding the fact there are restricted data in the system, that is clear throughout the process docs and download system. But in the engagement tool where we are trying to support the JCDP and highlight the great steps forward in making data accessible - it's not great to have a graphic that shouts out much of the data are (currently) restricted and I don't feel we need to refer to this here.

I understand this, but one could argue that the dashboard is a visualization tool for the database, not just an engagement one. I think not showing how much restricted data we have in the dashboard is dishonest, if I'm being blunt. While we're not denying that restricted data exists, we are hiding it in a way, because we are making this fact less visible. I'm not sure if it's good policy for ICES to do this.

Can we remove the two graphics that refer to access type – I don’t want to highlight how much data is restricted… :)

i think we need to discuss justification of surpressing this info, what is it we are afraid of?

Happy to discuss - it's not about supressing the info, it's about choosing where we highlight it. The dashboard is an engagement tool for this db and highlighting how much data are restricted is a bit of a kick in the teeth against what we are trying to achieve. By not having a graphic here, we are not hiding the fact there are restricted data in the system, that is clear throughout the process docs and download system. But in the engagement tool where we are trying to support the JCDP and highlight the great steps forward in making data accessible - it's not great to have a graphic that shouts out much of the data are (currently) restricted and I don't feel we need to refer to this here.

I understand this, but one could argue that the dashboard is a visualization tool for the database, not just an engagement one. I think not showing how much restricted data we have in the dashboard is dishonest, if I'm being blunt. While we're not denying that restricted data exists, we are hiding it in a way, because we are making this fact less visible. I'm not sure if it's good policy for ICES to do this. Also, while I understand why we wouldn't want to highlight this, as a user I would be extremely irritated if I looked at the dashboard before trying the download, because I would be convinced the data are open and then I'd find out most of them aren't.

Surely the 'dashboard' or data summary is whatever we want it to be on a project by project basis? This element is an addition to the landing page and search/download pages, which fulfil the needs of the project. The data summary graphics are additional as an engagement tool (at least in the case of the JCDP - it may differ for other projects?). There are many graphics we could choose to include (or exclude) but elsewhere were we refer to restricted data, we have the space to explain that this doesn't mean they are not accessible. IN a single visual graphic, I think it could look like restricted data (that are currently making up most of the JCDP, until we can get more data in!) are not available and be off-putting for users.
But, lets pick this up in our next meeting :)

could also add:
Average of Species Observed by survey
Average of KM travelled by survey
Average of Surveys per year
Average of Observations per survey
By the way, it is confirmed, the distance was in Meters.

I like the green boxes :)
label: "Number of data providers"
label: "Number of unique species"
all numbers to be in format xxx xxx 123 456
I'm not sure the averages are necessary as they are covered in the plots, and this might get too busy with too many stats

Brilliant! Thanks @cmspinto. These are great.
Agree with Neil's header tweaks
I’m not sure the averages will add much so happy to stick with actuals.
Do we need some sort of metadata to go with the dashboard, so we can provide some further information as to what is making up the numbers? E.g. is the number of species observations the number of sightings recorded, or the total number of animals recorded?

headline stats
Carlos to put at top of page (as separate page) and then we can also test adding to landing page

Done:
https://cetaceans.ices.dk/DashboardHeadlineStats

for first ballon:
* fix typos in title (travelled and specimen)

* make at species level only

* title: "average distance travelled from all surveys before sighting the species"

Done

balloon observations for species

restrict to species level

different colour by family

Put a different color for all of them, I can try to put similar colors by family, just not sure that will be clear!

@cmspinto

label: 'current data providers' (headline green box)
reword: 'In this page you can explore the dashboard of cetaceans database' -> 'overview of data holdings in the JCDP data portal'
move 'average distance travelled balloon' to the bottom
look to see if it is possible to wordwrap the species names, so they fit within the bubbles
to test a horizontal line to make a clearer visual break between charts
centre justify the access pie chart
REMOVE - bubble chart

[ ] label: 'current data providers' (headline green box)

[ ] reword: 'In this page you can explore the dashboard of cetaceans database' -> 'overview of data holdings in the JCDP data portal'

[ ] move 'average distance travelled balloon' to the bottom

[ ] look to see if it is possible to wordwrap the species names, so they fit within the bubbles

[ ] to test a horizontal line to make a clearer visual break between charts

[ ] centre justify the access pie chart

[ ] REMOVE - bubble chart

abel: 'current data providers' (headline green box)

reword: 'In this page you can explore the dashboard of cetaceans database' -> 'overview of data holdings in the JCDP data portal'

move 'average distance travelled balloon' to the bottom

look to see if it is possible to wordwrap the species names, so they fit within the bubbles

to test a horizontal line to make a clearer visual break between charts

centre justify the access pie chart

REMOVE - bubble chart

@neil-ices-dk to link https://cetaceans.ices.dk/dashboard to the landing page

have added a new section


Amplify user io for Rafs v5 break read

https://github.com/dragonflyoss/image-service/blob/master/rafs/src/metadata/md_v5.rs#L193-L215
The amplify_io  method will find next ino and merge chunk for read. But next file may in another blob, it will break BlobIoVec.validate method.

fixed by #406


feat: Including Regular Expression filter when targeting Github Repositories

What does this change
Allows to filter out target repositories using a regular expression
This change introduces a two new flags --repo-include and --repo-exclude which will filter out repositories mentioned in their specified regular expressions. Example:
 multi-gitter run ./test.sh --repo-include "^repoprefix-" --repo-exclude "^repoprefix-ignorerepo$" --repo-search "repoprefix-" --dry-run --commit-message "chore: foo"
What issue does it fix

Utilize Regexp to reduce the amount of repositories returned.
Minor improvement when removing duplicate repositories

Notes for the reviewer

Feature is currently only for Github Search

Checklist

[x] Made sure the PR follows the CONTRIBUTING.md guidelines
[x] Tests if something new is added

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

29 of 51 (56.86%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 38.226%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/scm/github/github.go
27
37
72.97%

cmd/platform.go
2
14
14.29%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
1461

Relevant Lines:
3822

💛  - Coveralls


Update get_lila_annotation_counts.py script to work with metatdata schema

Hey @agentmorris,
I was just poking around your LILA scripts and noticed a small bug in this line of the get_lila_annotation_counts.py script.
It looks like the image_base_url key no longer exists in the dict returned by lila_read_metadata(), and instead the image base url headers now follow this pattern: image_base_url_<cloud_provider>.
I fixed this by adding preffered_cloud = 'gcp' to the top of the file and modifying that line to:
    base_url = metadata_table[ds_name]['image_base_url_' + preferred_cloud]

Happy to open a PR for that change if you'd like.

Wow, you're fast!  That change to the metadata just happened this weekend.  Yes, that's the same change I would have made, please open a PR.  Thanks!

I'm happy to give you write access because I know you :), but... I think standard practice is for you to fork the repo, make your changes there, then create a PR from your repo into this repo.  E.g. this recent PR was submitted by a contributor who does not have write access to the repo, and that went smoothly.
GitHub's documentation on this process is clear and helpful, except for the confusing part where it says that you need write access; I'm 99.999% sure they mean that you need write access to the source repo, which in this case would be your fork.
Try that and let me know if you hit any snags?  Thanks!

Ah! I rarely contribute to external repos so had no idea you could create a PR from a forked project. Thanks I think that got me sorted.

Merged, closing this issue.  Thanks for finding this!