Extension tries to run powershell in git bash terminal

Issue Type: Bug

Behaviour
In windows, upon starting VSCode, which when automatically starting the git bash terminal, the path-to-python/Scripts/Activate.ps1 activation script is run, resulting in the error
bash: syntax error near unexpected token `&'

Expected vs. Actual Behaviour
I expected the bash script path-to-python/Scripts/activate to be run, resulting in successful activation of the virtual environment.
Steps to reproduce:
On a clean Windows with Git bash and python 3.10.4 installed, and VSCode with the python extension,

run pip install poetry (I do not have poetry on the PATH)
open a python project, run path-to/poetry install. This creates a new virtual environment at the path seen below.
set the workspace setting in the ./.vscode/settings.json (which is literally the only non-default setting I have, including user settings) like so:

{
    "python.defaultInterpreterPath": "C:\\Users\\User\\AppData\\Local\\pypoetry\\Cache\\virtualenvs\\api-Wxbj60dY-py3.10",
}

(the point is this is that I'm trying to link this project to that virtual environment, although maybe this is the wrong approach).

Open the git bash terminal in VSCode
Restart VSCode
Observe the error

Notes

I suspect there's a race condition. I tried figuring out which version this was introduced, but I can't get versions to behave consistently.
Restarting the window (via e.g. Reload window on extension install) results in the expected behavior. -
Also closing and reopening the terminal behaves expectedly.
Pointing the setting python.poetryPath to poetry doesn't help.

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.10.4
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Poetry
Value of the python.languageServer setting: Pylance

User Settings

defaultLS: {"defaultLSType":"Pylance"}

downloadLanguageServer: true

envFile: "<placeholder>"

venvPath: "<placeholder>"

venvFolders: "<placeholder>"

condaPath: "<placeholder>"

pipenvPath: "<placeholder>"

poetryPath: "<placeholder>"

languageServer: "Pylance"

linting
• enabled: true
• cwd: "<placeholder>"
• Flake8Args: "<placeholder>"
• flake8Enabled: true
• flake8Path: "<placeholder>"
• lintOnSave: true
• banditArgs: "<placeholder>"
• banditEnabled: false
• banditPath: "<placeholder>"
• mypyArgs: "<placeholder>"
• mypyEnabled: false
• mypyPath: "<placeholder>"
• pycodestyleArgs: "<placeholder>"
• pycodestyleEnabled: false
• pycodestylePath: "<placeholder>"
• prospectorArgs: "<placeholder>"
• prospectorEnabled: false
• prospectorPath: "<placeholder>"
• pydocstyleArgs: "<placeholder>"
• pydocstyleEnabled: false
• pydocstylePath: "<placeholder>"
• pylamaArgs: "<placeholder>"
• pylamaEnabled: false
• pylamaPath: "<placeholder>"
• pylintArgs: "<placeholder>"
• pylintPath: "<placeholder>"

sortImports
• args: "<placeholder>"
• path: "<placeholder>"

formatting
• autopep8Args: "<placeholder>"
• autopep8Path: "<placeholder>"
• provider: "autopep8"
• blackArgs: "<placeholder>"
• blackPath: "<placeholder>"
• yapfArgs: "<placeholder>"
• yapfPath: "<placeholder>"

testing
• cwd: "<placeholder>"
• debugPort: 3000
• nosetestArgs: "<placeholder>"
• nosetestsEnabled: undefined
• nosetestPath: "<placeholder>"
• promptToConfigure: true
• pytestArgs: "<placeholder>"
• pytestEnabled: false
• pytestPath: "<placeholder>"
• unittestArgs: "<placeholder>"
• unittestEnabled: false
• autoTestDiscoverOnSaveEnabled: true

terminal
• activateEnvironment: true
• executeInFileDir: "<placeholder>"
• launchArgs: "<placeholder>"

experiments
• enabled: true
• optInto: []
• optOutFrom: []

insidersChannel: "off"

tensorBoard
• logDirectory: "<placeholder>"

Extension version: 2021.12.1559732655
VS Code version: Code 1.67.1 (da15b6fd3ef856477bf6f4fb29ba1b7af717770d, 2022-05-06T12:37:03.389Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.84GB (10.37GB free)

Process Argv
--crash-reporter-id c3bb55ea-ef4f-422c-8ed0-95695e641d0a

Screen Reader
no

VM
0%

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
pythonvspyl392:30443607
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
cppdebugcf:30475217
vsclangdc:30486549

Git bash is not currently supported. Closing against #15799


event system

some Widget methods make sense to be redesigned as events since they share a lot in common with how they're passed on. events must be transparent to container widgets except when the containers actually want them, as opposed to requiring a new definition for each one that feasibly could be passed

a selection of Widget methods that feasibly behave like events:

on_key
on_press
on_scroll
on_text_input
resize (probably)
tick (probably)

related: #110


Feature: convert to hugo module

[x] Register PD as a Hugo module
[x] Rename /readme blocks to /index blocks
[ ] Rewrite PD block code on curriculum site to mount a module instead of using the readme blob api
[x] Rewrite the CMS to produce headless index blocks
[x] Rewrite the PD site to show blocks instead of pages
[ ] Mount PD into all the various sites as a module
[ ] Rewrite all the block calls to call pd/local instead of http links

I have no reviewers alas - no option here - I'm the only person here


Make the song length accurate when playbackRate is increased

The time bar's text isn't shown correctly if playbackRate is set to a number that isn't 1.0, so I fixed that.

burerergerg ballg
o8ytouyru 6rhukljgmvbhdnj ljl hj bvfhtrjyu8ijf hbvdghujlikh vfhgjukl vfrtyhujh

burerergerg ballg o8ytouyru 6rhukljgmvbhdnj ljl hj bvfhtrjyu8ijf hbvdghujlikh vfhgjukl vfrtyhujh

so true

Fire

ikr

I thought i was merging into experimental the whole time lmaoooo

It is how it is right now on purpose, it's not an oversight or bug

It is how it is right now on purpose, it's not an oversight or bug

BOOOOOOO


It is unclear how to use the Map typeclass

I've got a couple simple typeclass things working, but the code below fails, and I don't see why
class AddOne a b | a -> b where
addOne :: a -> b
instance AddOne int int where
addOne x = x + 1
instance (Map a b c d e f g h, AddOne c d) => AddOne f h where
addOne x = fmap(addOne, x)
Since we have both
instance () => Map d c a b 'array' [a] 'array' [b]
instance AddOne int int
it would seem that we should be able to resolve AddOne [int] [int]
But addOne([1]) fails.
Sadly nothing in boot does anything of the form instance Map ... => ... so it is tricky to puzzle out.

TBH, I think we should scrap this approach to 'Map/Functor' and do something more like vanilla Haskell.
The current implementation came out of the experience we got building programs with structural types where we were very enthusiastic about the additional power that structural reasoning gave us.  This went a little bit too far in the case of 'Map' where we basically had to infer an intended nominal type from a structural one, and that's not possible in general.
Rather than distinguishing certain structural patterns like this, we should just overload on type constructors in the usual way (and we already have a way to map type constructors with arguments into structural types if we need that information for something else).
That will make these puzzles much less difficult to solve and more straightforward to reason about the error messages that come up.
We still need to be a little bit more general than in Haskell, because for example if you map a function over a stored sequence, you don't want the result (necessarily) to itself be a stored sequence.
PS: I'm curious to know if you've looked at the structural type constraints, they will let you avoid a lot of boilerplate you might otherwise have to handle with something like Template Haskell (and IMHO e.g. fix the awkwardness of record types in Haskell).

FWIW, one way to recover something like Haskell's Functor would be like:
$ cat t.hob

class Functor f a b where
    fm :: (a -> b, (f a)) -> (f b)

data A x = [x]

mkA :: [x] -> (A x)
mkA = unsafeCast

unA :: ((A x)) -> [x]
unA = unsafeCast

instance Functor A a b where
    fm f xs = mkA(map(f,unA(xs)))

instance (Show x) => Show (A x) where
    show x = show(unA(x))

So that e.g.:
$ hi -s t.hob
> fm(show,mkA([1..10]))
["1", "2", "3", "4", "5", "6", "7", "8", "9", "10"]

It wouldn't be a lot of work to refactor things this way, but as described earlier this approach has some problems as in e.g. the case of querying out of structured data files (where we don't want the result structure to itself be a stored type, though the source structure must be).
But it's enough to define the class you want:
$ cat q.hob
...
class AddOne t where
    addOne :: t -> t

instance AddOne int where
    addOne x = x + 1

instance (Functor f t t, AddOne t) => AddOne (f t) where
    addOne x = fm(addOne,x)

So that:
> addOne(mkA([mkA([1..10]), mkA([11..20])]))
[[2, 3, 4, 5, 6, 7, 8, 9, 10, 11], [12, 13, 14, 15, 16, 17, 18, 19, 20, 21]]

HTH

Thanks, this helps in understanding what is going on.  The structural typing is very nice, as you say it gets rid of the need of a lot of boilerplate, although I'm still not totally certain that this ease isn't going to bite me later.

If it helps (in case the point wasn't made clearly elsewhere), the typical win for structural types is in writing explicit instance generators where you'd otherwise rely on implicit magic with "deriving".
For example, when you make custom record types in Haskell you might rely on "deriving Eq" to get equality testing.  But you can generically deconstruct record types this way to make the obvious definition:
instance (r={a*rr}, Eq a, Eq rr) => Eq r where
  x === y = recordHeadValue(x) === recordHeadValue(y) and recordTail(x) === recordTail(y)

So that two instances of a record are equal if all of their fields are equal.  It's the same thing you'd get with "deriving Eq" in Haskell but now the tools are in your hands to make the "deriving" logic yourself (and that tool is just plain old type classes).
Where I've found that you can get in trouble with structural types (where I've got in trouble) is in designating a "meaning" to a particular structure when that structure isn't canonical.  The bits you found with Map are a good example of that (maybe the most complicated example).  Another one would be using ()+t to mean maybe t because you could just as easily have picked t+() (similarly ^x.(()+(a*x)) to mean list a because it could just as easily have been ^x.((a*x)+()) for the same reason).
IMHO this is not a bug with structural types per se, but just a "user error" (one I've made a few times as I've come to terms with having this tool available myself).  In hindsight, I think that the right approach is to make structural types the default and introduce "intentional types" to designate these cases where you have some intention where you pick a structural representation arbitrarily.
Does that make sense?  I think you can still do what you do in Haskell, but don't have to resort to Template Haskell (or avoid it out of exhaustion) and can also do obvious things like have two struct types with overlapping field names in the same module, ditto for variants.


Template string support

Thanks for your work. This library is a lifesaver for building static next sites, but it lacks template string support, which is quite useful in many cases.
Users would probably want to translate like:
t('key', {count: 2})

{
   "key": "You clicked {{count}} times"
}

How about implement this feature by integrating mustache?

Thank you for the suggestion.
I think it's a great improvement. If you want to submit a PR I will happily merge it.
Otherwise it might take a week until I can add this feature :)

No problem, I'll do this

Oh man, you're using tab to indent...

Ready for review

Thank you!


Update tests failing on master

Ref to https://github.com/rtfd/readthedocs.org/pull/4461#discussion_r213152317
So, this was caused because the PR was outdated, makes me think if we could do better to prevent this. What about requiring the PRs to be updated before merging to master? Now GitHub supports a button to update the PR from the web, so the process isn't slow, but we will need to wait to the tests to pass again with the new merge, for simple PRs this can be a little overkill, but in general, I think this is a sane check

Changes look good!
What part of the PR wasn't updated? Do you mean you had local commits ready and didn't push up to your branch on GitHub yet?

The PR was done before https://github.com/rtfd/readthedocs.org/pull/4456, so it was using the old interface. Then the new interface was merged, and the tests were keeping the old interface.


RUM-3523: Report all threads for non-fatal ANRs

What does this PR do?
This PR adds reporting of all threads information for non-fatal ANRs, threads are reported in the same manner as it was done before for crashes (meaning name, state, stacktrace will be reported).
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1912 (1cbed8f) into develop (f46eb76) will increase coverage by 0.01%.
Report is 6 commits behind head on develop.
The diff coverage is 78.12%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1912      +/-   ##
===========================================
+ Coverage    83.38%   83.39%   +0.01%
===========================================
  Files          477      477
  Lines        16922    16985      +63
  Branches      2514     2524      +10
===========================================
+ Hits         14109    14164      +55
- Misses        2120     2126       +6
- Partials       693      695       +2

Files
Coverage Δ

...m/datadog/android/core/internal/utils/ThreadExt.kt
62.50% <100.00%> (ø)

...in/kotlin/com/datadog/android/rum/RumAttributes.kt
0.00% <ø> (ø)

.../android/rum/internal/monitor/DatadogRumMonitor.kt
84.62% <100.00%> (+0.10%)
:arrow_up:

...og/android/rum/internal/anr/ANRDetectorRunnable.kt
85.19% <74.07%> (-8.15%)
:arrow_down:

... and 25 files with indirect coverage changes


chore(java_templates): add lint/static analysis presubmit checks for samples

This PR was generated using Autosynth. :rainbow:
Synth log will be available here:
https://source.cloud.google.com/results/invocations/a1ab35b3-507a-48a2-9431-67bf79f39079/targets

[ ] To automatically regenerate this PR, check this box.

Source-Link: https://github.com/googleapis/synthtool/commit/c3caf0704f25a0c365f1c315e804a30b87c62a75

I need to update samples for lint.


Feat: multi field based validations

Adds the following validation rules:

requiredWith()
requiredWithAll()
requiredWithout()
requiredWithoutAll()
multiFieldComparisonRule()

Changed the following protected methods to public:

dateComparisonRule()
fieldComparisionRule()

Syntax
->requiredWith(['another_field', 'someother_field']) //array

->requiredWith('another_field, someother_field') //string

->requiredWith(fn () => ['another_field']) //closure

ref: https://github.com/filamentphp/filament/discussions/2585 & https://github.com/filamentphp/filament/discussions/2639#discussioncomment-3477505

This is great, could you quickly add some docs?

Thanks!


Can we replace the animation to our own designed animation?

Hi,
Interesting request. I believe one way is to have the consumers (you guys) to provide the animated line as a component. I’ll think about how I want to provide that API
Thanks

BarcodeMask and BarcodeMaskWithOuter now have an additional prop called animatedComponent. It is a Render Prop and will be called with the computed width, height
and must return a ReactElement.
<BarcodeMask animatedComponent={(width, height) => <Text>Custom Animation Component</Text>} />

:tada: This issue has been resolved in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Release v1.0.0

This is intended to help potential users of this library assess the API
stability and general maturity of this library.
v1.0.0 is a commitment that the API will not change in a backwards
incompatible way before v2.0.0.  The API is stable and has been since the
crate was made available.  In fact the implementation hasn't had to change
in 2 years.  It is time for v1, and the API commitment that comes with it.

Thanks. Merged without external badge.


Nested mutation with same object type errors out

EdgeDB Version: beta 2
OS Version: macOS Big Sure

Steps to Reproduce:
Reproduction repo: https://github.com/colinhacks/edgedb-update-insert-bug

Schema:

It looks like we reject this now with "cannot reference correlated set"


Assigning to a wider union type breaks type safety

🔎 Search Terms
invalid, type safety, union, type, broken type, no error
🕗 Version & Regression Information

This is an invalid type checker behaviour
This never changed, it was "always" like that >3.3.3
This is the behavior in every version I tried, and I reviewed the FAQ for entries about 3.3, 3.5, 4.5, 5.0, 5.2.0-beta

⏯ Playground Link
https://www.typescriptlang.org/play?ts=5.2.0-beta#code/C4TwDgpgBAcgrgWwEYQE4HkB2AbEBhAe02AEMBLTNKAXigG8AoKKMVAsALik0RVQG4GAXwYNsEYFBKYQwABYUA5l0bNW7LgGdgqJVAA+3XmkFDBYiVAQEAJlC7xkaLLkLFylVDXrrOUAIxmotKyCpiK3tY2-MyxcfEJiQD0SWSSmnIEcNh2AGbk2FByaBBcAERR3ASSJJqaZIqYJEjiUMAEUjLyeigAxiRwmtAAFNq64QZGTqgAlFBkmlU1dQ1NLdDtU3xlDCHd4QB0vt5lNhC5FBK4S1JbaGUxKQReaVAZWTncJKhsAO5txSgZRIvWAcBIhVAkDKbQ6dF8XB40yEnTyBSKJXKezCiiObDA80WTR+BF+EDsmyRfAANKi3jo9AsbrV6o1mq1KcZUDsGL0iJoCOIDtgCIphsC7l5ygBqKJ49gzR6pTBVKD9IZvTLZOxy44oKTrWE3fUkSVQYYQAAevQgYEkuWeLGwHigACsSAA3Wq9XR2qzSMhgbIkYBkIgzIA
💻 Code
type NumberOnlyContainer = {
  prop: number;
}

let anything: {
  prop: string | number;
};

let mod : NumberOnlyContainer = {prop: 1};

anything = mod;                           //it should fail here: "mod not assignable to anything because (string | number) is not assignable to number"
anything.prop = "definetly not a number"; //or it should narrow the "actual type" to {prop: number} and fail here: "anything.prop is narrowed to number, and string is not assignable to number"

console.log("a number : "+mod.prop); //in no case should mod.prop be able to not be a number

The result will allways be a number : definetly not a number which is a violation to the types since mod should be of type NumberOnlyContainer which's prop should only be able to be a number
🙁 Actual behavior
The code compiles / ts does not complain
🙂 Expected behavior
The code should no "compile/transpile" since it is invalid and breaks type safety.
It should not be possible to effectively expand/redefine a variable by assigning its value to another mutable variable.
The only way where this behaviour should be allowed is if the wider type ((string|number)[] for example) is readonly since you cannot break type safety with it.
Options to prevent this:

Disallow assigning the value of a variable of type A to a variable defined as type B if

A & B are reference types
B is mutable (anything except a readonly array)
B is a "wider" type than A

Narrow down/merge the type of a variable of type B (down to A) when a value of type A is assigned to it
(currently not possible since readonly only works for arrays) A variable of type B is narrowed to readonly B  when a value of type A is assigned to it and:

A & B are reference types
B is mutable (anything except a readonly array)
B is a "wider" type than A

All of these solutions would work for all the use cases (when considering passing a var to a function as a variable assignment)
Additional information about the issue
There are a lot more examples where this missing check should fail:

https://www.typescriptlang.org/play?#code/DYUwLgBAtgngcgVygIxAJwM4QFwQHZKpoDaAuhALwTECMpA3AFCMBmCeAxmAJYD2eEXgDd0AdzTcwIAOqSAFgGUwEvAHMMACgy8oIAIJo0AQxi4jeGGQCUAb0YQI23QeOWADOSoAiPV6YBfZmExCSlZMEVlbjVNWEQUdAwrJkYOfm1QADpgXlUNMBgABxBeFmh4QkTiD2SgA
https://www.typescriptlang.org/play?#code/DYUwLgBAtgngcgVygIxAJwM4QFwQHZKpoDaAuhALwTECMpA3AFCiQYD2UIAgmmgIYxcACgIp0AHwxg0ASzwBzAJRkm7Tj34xK0eIXQZVHbrwHEADOSoAiPG0h98etDkVWmAYzZ52oAHTA2eSFYRDFMRQ8vHxB-QKEwGAAHEDYAMx1QogxzUgigA

Since this behaviour (or rather the lack thereof) is pretty severe, I would be surprised to see that this is not a duplicate - that said, i do not found a matching issue. I guess it has already been reported or is at least known. If so - link the issue and close this one, maybe i am just too small brained to find the correct issue.

Properties are assumed to be covariant (i.e. only read from); writes to supertype aliases can be unsound. We don't really have intent to try to "fix" this; it's an accepted unsoundness.

I've made another example, which I think it's related (let me know if it's not):
interface A {
  name: 'A'
}

interface B {
  name: 'B'
  field: string
}

interface C {
  inner: A | B
}

const element: C = {
  inner: {
    name: 'A'
    // field not available, inner is infered as A
  }
}

// assigning inner to another type from the union
element.inner.name = 'B'

// @ts-expect-error - element.inner still infered to A
element.inner.field = 'test'

if (element.inner.name === 'B') {
  // works with unnecessary check due to assignation above
  element.inner.field = 'test'
}

view on playground


Make rsyslog only restart once

Description
This change means that if multiple file_input resources are declared the rsyslogd service restarts only once (at the end of the Chef run). This is required on systemd based distros where systemd imposes a limit on how many times rsyslogd can restart within a certain time space. Currently these systems get failed Chef runs when introducing multiple new file_input's.
Issues Resolved
N/A
Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing (N/A).
[x] New functionality has been documented in the README if applicable (N/A)
[x] The CLA has been signed. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Thanks for this contribution!


BXC-4524 - Upgrade to Mockito 5

https://unclibrary.atlassian.net/browse/BXC-4524

Handle "Cannot get facet class for null field key" by reducing it to a one line warning (see changes in https://github.com/UNC-Libraries/box-c/commit/50a0d1a10400681fcf9475a81f4d78a7c374bde6 ), and adding test coverage
Update mockito to version 5, and adjust method names/packages accordingly. This version allows for mocking of static methods without any extra dependencies, which was used in the facetLimits test

Closed in favor of https://github.com/UNC-Libraries/box-c/pull/1722


Validating other elements from a method breaks validation

The issue (and a workaround) are described here: http://stackoverflow.com/questions/22107742/jquery-validation-date-range-issue/
The main thing is that you can't call .element() from within a function provided to .addMethod().  While this is probably a less-common use case, the date range case in the example given is fairly straightforward.
This issue may not be something worth fixing in the current major release, but might be worth considering for the rewrite.

I'm sorry for the lack of activity on this issue. Instead of leaving it open any longer, I decided to close old issues without trying to address them, to longer give the false impression that it will get addressed eventually, especially after several years with no activity. It doesn't mean I'm abandoning the project, just that I'm unable to work through 200+ open issues with the little time I can afford to spend on this project.
To the reporter (or anyone else interested in this issue): If you're still affected by the same issue, please consider opening a new issue, with a testpage that demonstrates the issue with a current version of the plugin. Even better, make an attempt to fix the issue yourself, and improve the project by sending a pull request. This may seem daunting at first, but you'll likely learn some useful skills that you can apply elsewhere as well. And you can help keep this project alive. We've documented how to do these things, too. A patch is worth a thousand issues!


Fix ASAN error 'new-delete-type-mismatch' in WFServiceGovernance.h

It pops ASAN error "new-delete-type-mismatch" when run test "upstream_unittest".
And after investigating this error, the issue here is PolicyAddrParams. EndpointAddress's destructor deletes params, but unfortunately PolicyAddrParams has a type that derives from it (UPSAddrParams) and no virtual destructor.
Then, someone puts a UPSAddrParams pointer into an EndpointAddress, and the result is that the destructor deletes the incorrect type and calls the incorrect destructor.
So I modify the file WFServiceGovernance.h to make PolicyAddrParams's destructor virtual.

Thank you for the PR. But I can not reproduce the testing error you mentioned.
As a universal design in the project, any 'xxxParams' structure should be a POD type, and provide a corresponding 'constexpr' default value, like EndpointParams. When setting the parameters, we should always set the structure to default value first:
{
    struct WFServerParams params = SERVER_PARAMS_DEFAULT;
    params.max_connections = 10000;
    ....
}

The 'PolicyAddrParams' and 'UPSAddrParams' structures should follow this rule too. But maybe for convenience our developer added a constructor that sets the default values (To be fixed.). Because they are POD except having constructors, and no destructor or non-POD field will be added to them, I cannot think of any potential error in it. We can discuss on this. I ran upstream_unittest with valgrind and it shows no memory error too.

@Barenboim the real issue is in UpstreamPolicies.h:40, where UPSAddrParams inherits from PolicyAddrParams, and then in UpstreamPolicies.cc:132 an EndpointAddress's params field is initialized with a UPSAddrParams*. This field is then deleted through a pointer to PolicyAddrParams in EndpointAddress's destructor (defined at WFServiceGovernance.h:95), which is invalid unless PolicyAddrParams's destructor is virtual.

It is UB according to the specification ([[http://eel.is/c++draft/expr.delete#3\]][])

It is UB according to the specification ([expr.delete]/3)

In a single-object delete expression, if the static type of the object to be deleted is not similar ([conv.qual]) to its dynamic type and the selected deallocation function (see below) is not a destroying operator delete, the static type shall be a base class of the dynamic type of the object to be deleted and the static type shall have a virtual destructor or the behavior is undefined. In an array delete expression, if the dynamic type of the object to be deleted is not similar to its static type, the behavior is undefined.

However, this does seem to be a fairly innocuous form of undefined behavior... @ShelleyZhang01, could we instead turn off new-delete-type-mismatch checking for sogou/workflow?

OK, I will turn off "new-delete-type-mismatch" checking for sogou/workflow.


React native support.

hey @lynndylanhurley, thanks for the awesome repo! I saw that support for react native was coming soon, do you have a feature branch going already?

@lynndylanhurley Awesome work and helps me a lot in learning how redux work.  Can't wait to see this coming for React Native.

Any updates on this? React Native support would be awesome!

It's a priority. I have lots of client work to get thru so I can't give an ETA.

Wanted to bump this up. Anything on this?

Hi @lynndylanhurley thank you for this repo ! any news for react-native version ?

@lynndylanhurley Hi, any updates or existing PRs? If not can someone outline was is needed to make this happen so perhaps others can get involved and move the ball forward on this?

@whistlerbrk @lynndylanhurley I'd be happy to work on adding react native support if there is an outline of what is done and what still needs to be done.


Data augmentation and normalization

Your paper is really interesting, and I have tried implementing the network following your descriptions there.
For the supervised network, I was wondering if you have used any data augmentation during training. If so, what kind? Also, do you normalize the depths in any way (both the input and the ground truth)?

We found data augmentation not to help much, and you can always start without data augmentation. The network should be able to learn well, both with and without depth normalization.

Great, thanks for the prompt reply!


fix: Always uninstall IntegrationPlatform resources

Make sure to remove IntegrationPlatform resources from operator namespace on uninstall
Do not filter on label "app=camel-k" when removing IntegrationPlatform resources

Release Note
fix: Always uninstall IntegrationPlatform resources

@squakez there is a --skip-integration-platform option on the uninstall command for users that need to retain this resource

@squakez there is a --skip-integration-platform option on the uninstall command for users that need to retain this resource

I know, but that one would also skip any IP with app=camel-k. I don't have any strong opinion on this change anyhow, so, we can merge it if there is no other objection.


Koi mob ai needs to be imporved.

Koi currently just float there.

Added better AI, at least good enough for now.


Demo not working

https://jsfiddle.net/kirana/20bumb4g/
Does not show a working demo

We have moved to codesandbox. Here's the link: https://codesandbox.io/s/zzloxr09mp


Infinite loop

If there is a recursive import in the code and the interface to be mocked is in one of the packages in the chain of recursive imports, moq will go into an infinite loop rather than generating an error.

What's a recursive import? Aren't cyclic dependencies forbidden in Go?

@matryer Yes they are forbidden and that's a compile error, but in case someone runs moq when there is such an import in the code in the file that holds the interface to be mocked, moq will go into an infinite loop instead of printing some error and exiting.


New cop that suggests replacing complex unless with if

I was thinking about this before, but after this thread - https://twitter.com/nateberkopec/status/1314235606705340418, I finally decided to write here to start a discussion. Turns out there are a lot of people struggling to parse non-trivial unless statements, and i am amongst them.
Imo, while something like do_something unless cond is expressive and easy to parse and understand (and even something like do_something unless cond1 && cond2), when conditions become more complex (having || or !) it is hard to do so.
So, I suggest adding a cop (disabled by default), that will suggest rewriting complex unless with if.
# bad
do_something unless foo || bar
do_something unless foo || !bar
do_something unless !foo || bar || !quux
# ...

# good
do_something unless foo

do_something if !foo && !bar
do_something if !foo && bar
do_something if foo && !bar && quux

# neutral?
do_something unless foo && bar

How should we write do_something unless foo || bar?

do_something if !foo && !bar
Updated an example.

do_something if !foo && !bar
Updated an example.

I typically try to minimize the number of !, so I (typically) would prefer the unless in this case.
I could imagine a config "Prefer": 'if' / 'no negation', and maybe another one to apply only on compound conditions (as you are suggesting) or always?
Glad we agreed it shouldn't be enabled by default 😆

This reminds me of this Tweet. Lots of people seem to dislike unless. Haha.
https://twitter.com/nateberkopec/status/1314235606705340418?s=21

I was recently wondering why Rubocop haven't implement such a cop yet :)
Personally for me conditions like this do_something unless foo || bar are very hard to grasp. Sometimes to understand them I have to recall De Morgan's laws to transfer them to do_something if !foo && !bar and only after that I can really comprehend them in my head. I would even prefer to disallow constructs like do_something unless foo && bar because do_something if !foo || !bar is easier for me.

Same for me and I'm also regularly using De Morgan's laws to understand the conditional meaning 😄 .
I completely agree with Sam Saffron from mentioned twitter thread and would prefer to have unless keyword banned.


Looking for feedback: Adding support for multiple xrdp endpoint bindings?

With the added support for AF_VSOCK some users would like to be able to connect both hypervisor local and also expose a remote endpoint at the same time. This would be a modification to the config to support both tcp settings and vsock settings for the same daemon at the same time. Then a user could connect via a fast connection (ip independent) when local but also connect to this vm when remote. This is roughly exactly what the windows TermSrv does to accomplish this.
A few thoughts:

We would need to modify the config to support connection independent settings and add new connection dependent settings sections. IE: you might want bitmap_compression=true for tcp but =false for vsock.
The xrdp daemon would need to have a listener per connection entry and dispatch reads/writes with the appropriate settings.
If a user disconnected from tcp/vsock and switched to the other they should see the same user session. (I don't think this is a problem just pointing it out).
The same user account should be able to connect over both endpoints at the same time. Connecting via another endpoint should disconnect the previous connection and vice versa.

Other ideas/gotchas you can think of? I would be happy to try and work out some details in the code base here if everyone thinks its a good idea.

What about not at the same time? I'm trying to use MSTSC to connect with one single connection but, I cannot figure it out. Is xrdp not using the same 3389 port?

The main topic of this issue is vsock and tcp are exclusive, right? vsock is implemented by you and you make it exclusive. I'm OK if you make xrdp can listen both socket at the same time. Send a PR first.

IE: you might want bitmap_compression=true for tcp but =false for vsock.

IMO, I don't like it. It will make config complex and config parser with little benefit.

@worthwhileindustries - I'm not sure they are related to what I am asking. Check that your guest is configured in '/etc/xrdp/xrdp.ini' to use tcp and that your machine has that port open. Then you should be able to use mstsc to connect. We do this all the time.
@metalefty - Thanks for the feedback. I will work on getting a PR up supporting both connections but will not add the connection dependent settings for now. We can always do that later if it becomes an issue.

What is we get rid of xrdp.ini entry 'use_vsock' and just use the 'sock=' line in xrdp.ini
sock=/tmp/local.xrdp, tcp:<IP_ADDRESS>:3389, tcp:3390, tcp6:4500, vsock:1000
listen on unin domain socket /tmp/local.xrdp
listen on interface <IP_ADDRESS> tcp port 3389
listen on all interfaces tcp port 3390
listen on all interfaces tcp6 port 4500
listen on vsock port 1000
I think if you want different behavior for vsock vs tcp connection, there should be separate xrdp installs with a different prefix.  It would get too complicated otherwise.

@jsorg71 The idea is good. The format needs to be considered.
Let's specify the socket type uds or unix for unix doman socket.
If I want to specify to listen on a specific IPv6 interface, it looks complicated :(
2001 is a port? or a part of IPv6 address??
sock= unix:/tmp/xrdp.socket tcp6:2001:foo:bar::buzz:3389

Still ugly :(
sock= tcp6:[2001:foo:bar::buzz]:3389

The URI format for all these examples would be (I think):
unix://./tmp/xrdp.socket
tcp://.:3380/  (<- Localhost <IP_ADDRESS>:3380)
tcp://:3380/ (<- *:3380)
tcp://<any ipv4 format addr>:3380) (<- <IP_ADDRESS>:3380)
tcp6://.:3380/
tcp6://:3380/
tcp6://<any ipv6 format>:3380/
vsock://<cid>:<port>/

@jterry75 If you are going to do a PR, in xrdp_types.h, struct xrdp_listen, the 'listen_trans' needs to be changed to an array, or better yet, a list.  One struct_trans for each item in the 'sock=' line.

I created a working prototype using lists
https://github.com/jsorg71/xrdp/tree/listen-list

@jsorg71 - This is awesome! I did a super quick CR but will do a more thorough one later. Will install this private and give it a shot but it looks like it will do exactly what I was thinking. Way cool

@jterry75 Did you get any time to work on this?  If not, I think I should clean this up and do a PR.

Would you mind doing a rebase and PR. It did indeed work if I remember correctly

Hello @jterry75 and @jsorg71. It looks like this was never rebased and merged, is that correct?

The items left to address.

The old code was running a "listen test" that was used before the fork in daemon mode to make sure it can listen on the port.  Not sure what the new code should do,  Maybe test that all can listen? or at least one?
Do we need to have code to still use the old xrdp.ini file format?  I have not done this yet.
What about the -p parameter when starting xrdp.  -p is for port.  Maybe if -p is used, override xrdp.ini listen list and just listen on ::0:port ?

If we can figure these items out, we can merge.

I think all the items are addressed and I created PR #1366


Add s:SparkupPrevious() and corresponing key bindings to vim plugin

This is the counter part to s:SparkupNext(), bound to <C-p>.

I'm sorry, this is wrong. A single change was meant to go into the master branch.


Cant find library and locate the .so file

Hi, I have an PYNQ image v2.4 and have cloned this repo, but cant run the 3thed step:
I get this error but when I go there I can see the file and its executable, do I need to set a path or how do I solve the error?
OSError: cannot load library '/usr/local/lib/python3.6/dist-packages/bnn/libraries/pynqZ1-Z2/python_hw-cnvW1A1-pynqZ1-Z2.so': /usr/local/lib/python3.6/dist-packages/bnn/libraries/pynqZ1-Z2/python_hw-cnvW1A1-pynqZ1-Z2.so: undefined symbol: cma_alloc.  Additionally, ctypes.util.find_library() did not manage to locate a library called '/usr/local/lib/python3.6/dist-packages/bnn/libraries/pynqZ1-Z2/python_hw-cnvW1A1-pynqZ1-Z2.so'

Hi, on which board are you executing this?

On a Pynq Z2 board

Did you install the package using pip (as in the quick start) or just cloned the repo? In order to execute the available jupyter notebooks on the board you should install the package.

Yes I followed the quick start and did pip install, found bnn in my jupiter notebook.

Are you executing one of the jupyter notebooks or you're experiencing this issue in new code? If it's in a new codebase, are you importing the bnn library (import bnn) and experiencing the error during import?


Error during ng serve

Hi,
I am using ng serve command during development and when i change a module path or when i create a new module it needs to close and rerun the command:
ERROR in Cannot read property 'length' of undefined

Check your environments configuration. In my case, I had environments.hmr.ts in stead of environment.hmr.ts

Can you still reproduce this error?

Closing the issue due to inactivity. If the problem still exists in the latest version of the CLI, please open a new issue following the template and providing a minimal demo where we can reproduce it. Thanks! :-)


Fixed now


Support for printing help from scala compiler

Is your feature request related to a problem? Please describe.
Scala CLI should print help message from scala compiler like scalac -help. It can be added new flag to print help from compiler.

scalac -Xshow-phases is also like this:
% /usr/local/scala/scala-2.13.8/bin/scala -Xshow-phases
    phase name  id  description
    ----------  --  -----------
        parser   1  parse source into ASTs, perform simple desugaring
         namer   2  resolve names, attach symbols to named trees
...

but:
% scala-cli compile -S 2.13.8 -Xshow-phases
No inputs provided (expected files with .scala or .sc extensions, and / or directories).

similarly, scalac -X and scalac -Y and scalac -V and scalac -W print help for just those subcategories of flags


chore: consider passing structs for the core cmd functions to define params

Description
Some core functionalities such as:

SignCmd
SignBlobCmd
VerifyBlobCmd
and the other ones that not included in here...

...are high usage ones across different projects that imports cosign as a library. Every flag or feature we add, it gets being started to get more complex. And we need to pass default values unnecessarily. To avoid too many state-defining parameters, we can pass structs to handle this situation: i.e., SignOpts{}, SignBlobOpts{}, VerifyOpts{}, VerifyBlobOpts{}, etc.

+1

+1


Using components instead of controllers

Ionic version:
[ ] 2.x
[x] 3.x
[ ] 4.x
I'm submitting a ...
[ ] bug report
[x] feature request
Hello!
I wonder why ionic prefers to use controllers instead of a component approach for various modules like ActionSheet, Popover, etc.
I would prefer to have my actionsheet with their actionsheet items in the template. Like so:
<ion-actionsheet>
    <ion-actionsheet-item (handler)="openInfo" icon="cogs">Text</ion-actionsheet-item>
</ion-actionsheet>

I don't get, why popover, actionsheet etc have to be created so programatically, when you could configure them easily using templates and passing events using input and  output decorator and control using viewchild.
This looks like asking for a lot, but this would making components more customizable again. Ionic has a horrible culture of adding little snippets of CSS for all the things they can't achieve with component settings. Like placing the actionsheet icons somewhere else. This would be eliminated, by making components configurable and reactive again, without using controllers.

Ionic is designed to create apps, it is a end-to-end solution. It is not bootstrap, it handles many things under the hood. You are sub-estimating the complexity of it:

You need to handle browser navigation (go back button) with popover, action sheet etc.
All this components are not part of you page, but people expect to appear at a global context (on top a the sidemenu). Even if you switch between tabs, the actionsheet should keep visible.
You need to coordinate how action sheet, alert, popover, sidemenu, everything plays together.

Your use case might be simple, but it is not the case sometimes.I am not saying your idea is bad, but it is not complete, your approach might fixes one use case and breaks the rest.
Fortunately, this will get better with Ionic V4 which is based in WebComponents, ie the DOM is the API. The controllers will stay, for sure, because they are needed to handle the complexity of it. But I think it is going to be easier than ever to 100% customise the markup.

and Alerts, Actionsheet, Popover are never defined in the "markup" of native iOS or Android apps, but they are created programmatically.
Again, I agree it should be easier to customize, Ionic V4 will fix that.


FWI-3257 - Enable tfsec report by default and gracefully react if no paths were specified

Checklist

[x] I have signed the CLA
[x] I have updated/added any relevant documentation

Description
What's the goal of this PR?
Enable the tfsec report by default, returning gracefully if no terraform paths were specified
Please see the ticket for a deeper description of behavior changes in tfsec, including QA steps.
Internal Ticket FWI-3257

Another thing that I thought about... is default value change (false → true) a breaking change in this case? This is not to enforce a major change on the version bump, but just something to wonder about

@vitorvezani Yes, this is a breaking change in the case where a user specified terraform -> paths but did not intend for those paths to be scanned by relying on the previous default behavior of the tfsec report being disabled.
Although this wasn't necessarily your intent, perhaps this is a candidate for a major version bump, because we're changing the user experience for this report type. I will update the version to be a major bump, but we can change it.


Why the http/3 protocol cannot be rendered using IP addresses

Why the http/3 protocol cannot be rendered using IP addresses
package main
import (
"fmt"
"net/http"
"github.com/lucas-clemente/quic-go/http3"

)
func main() {
handle := func(w http.ResponseWriter, req *http.Request) {
	_, _ = fmt.Fprintf(w, "hello world")
}
mux := http.NewServeMux()
mux.HandleFunc("/", handle)

err := http3.ListenAndServe(":4431", "server.crt", "server.key", mux)
// err := http3.ListenAndServeQUIC("<IP_ADDRESS>:4431", "server.crt", "server.key", mux) // 只开通基于udp的QUIC 协议
fmt.Println(err)

}
https://<IP_ADDRESS>:4431/
https://localhost:4431/
HTTP/3 200 OK
alt-svc: h3=":4431"; ma=2592000,h3-29=":4431"; ma=2592000
These two methods can present http/3 protocol in Firefox browser
HTTP/1.1 200 OK
Alt-Svc: h3=":4431"; ma=2592000,h3-29=":4431"; ma=2592000
Date: Wed, 15 Jun 2022 07:32:57 GMT
Content-Length: 11
Content-Type: text/plain; charset=utf-8
https://<IP_ADDRESS>:4431/
Why the http/3 protocol cannot be rendered using IP addresses

I'm sorry, I don’t understand the question  / problem.

I guess he said when when use "https://<IP_ADDRESS>:4431/" the browser only use http1.1 protocol, only use "localhost" it can real use http3

I guess he said when he use "https://<IP_ADDRESS>:4431/" the browser only use http1.1 protocol, only use "localhost" it can real use http3

<IP_ADDRESS> and localhost can use http/3 protocol instead of https://<IP_ADDRESS>:4431/ Using httt /1

I guess he said when he use "https://<IP_ADDRESS>:4431/" the browser only use http1.1 protocol, only use "localhost" it can real use http3

<IP_ADDRESS> and localhost can use http/3 protocol instead of https://<IP_ADDRESS>:4431/ Using httt /1
yes,I tested , he was wrong.
but I just donot understand,why http3 must use TLS. some times I donot want to , for example, I want to use http3 for remote call   ,it does not need any security


Problem with latest firebase-tools

When using latest firebase-tools, I'm getting the following error:
Firebase config variables are not available. Please use the latest version of the Firebase CLI to deploy this function.

Solved installing<EMAIL_ADDRESS>This link helped me, documentation should reflect one of the two workarounds (downgrading firebase-tools or updating to latest firebase-admin and firebase-functions).

@timgivois Please specify which exact version you had when you saw this error.
Version 6.4.0 works without error messages.
npm install<EMAIL_ADDRESS>


Ecto.Changeset.html#validate_length/3 with empty list

Environment

Elixir version (elixir -v): Elixir 1.2.1
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.): PostgreSQL 9.5
Ecto version (mix deps): 1.1.4

Current behavior
defmodule ValidateLengthTest do
  use ExUnit.Case, async: true
  import Ecto.Changeset

  defmodule Group do
    use Ecto.Schema

    schema "groups" do
      field :members, {:array, :integer}
    end
  end

  defp changeset(model \\ %Group{}, params) do
      cast(model, params, ~w(), ~w(members))
  end

  test "validate_length/3 with list" do
    changeset = changeset(%{"members" => []}) |> validate_length(:topics, min: 6, foo: true)

    refute changeset.valid?
    assert changeset.errors == [members: {"should have at least %{count} item(s)", count: 6}]
  end
end

this test returns an error:
  1) test validate_length/3 with list (ValidateLengthTest)
     test/validate_length_test.exs:17
     Expected false or nil, got true
     code: changeset.valid?()
     stacktrace:
       test/validate_length_test.exs:20

Finished in 0.2 seconds (0.2s on load, 0.00s on tests)
1 test, 1 failure

Expected behavior
It should check for empty list and valid? should return false, but now validate_change doesn't run validation if empty list is passed as a changed parameter.

Duplicate of https://github.com/elixir-lang/ecto/issues/981
Current fix is to change default value for the array field to nil.


fix frameCount to be framePerBurst in echo sample(audio_main.cpp)

should write silent audio of framesPerBurst rather than samplesPerFrame

Hey @dturner: this is a typo fix,  I will merge it in   thanks


Consecutive blockquotes are joined instead of separate

I'd expect this:
> Quote 1, Line 1
> Quote 1, Line 2

> Quote 2

... to render as ...

Quote 1, Line 1

Quote 1, Line 2

Quote 2

... but instead it renders as ...

Quote 1, Line 1

Quote 1, Line 2

Quote 2

Is this expected?

Yes. Commonmark is a bit different in this regard, and will work as you want it to.
You can check out v4.1.0 which has a new parserOptions property, which allows you to enable commonmark parsing:
<ReactMarkdown
  source="your example"
  parserOptions={{commonmark: true}}
/>

Great, thanks!


Add project tagging so folks know what concepts have been covered

We could add specific keywords after the exercise name which show it's tags / main ideas

Maybe we can use the tags from Issue #7? If you agree, then I can add them to the exercises :smile:

Done, thanks!


Add details about canister settings

This PR explains each field of canister settings.

Thanks a lot for improvements, @jessiemongeon1 !


[CHECKLIST] Gadget SDK and Shell Manager

Gadget SDK
This SDK is primarily to help to have standard modules (a la std)  for Gadgets, it will live here in this repo under the sdk directory. We will keep each module behind a feature flag, and a full feature that would enable all of them by default.

[ ] #153
[ ] #155
[ ] #161
[ ] #156
[ ] #163
[ ] #162
[ ] #160

Shell Manager

[ ] #157
[ ] #158
[ ] #159

Repo

[ ] #164

Resources

https://github.com/supernovahs/eigensdk-rs

Another Gadget CLI related checklist, linking for good measure https://github.com/webb-tools/gadget/issues/147

Get to a point where it's easy to build and integrate for public examples & distribution.

Relayers for different protocols w/ Tangle (and Eigenlayer) contract templates (for job verification/slashing verification)
Nodes / infra for different protocols like Chainlink, Hyperlane, etc.
MPC integrations w/ basic API and onchain job verification/slashing verification

Developer experience should become an easy step-by-step process similar to EL’s that Donovan is running through for example

Clone repo or (gadget create)
Build your verifiers/slashers
Deploy to local w/ tests
Deploy to testnet
Deploy to mainnet

Then big next milestone is figuring out:

Service level agreement verification/slashing primitives
zkVM verification/slashing primitives (macros to automate this)

Recall, we need to prioritize this checklist @tbraun96 @shekohex. If things need to be updated, please jumpstart these conversations.


Implement/if else + block system

Because if needs to group statements into a block, it is implemented in this pr.
This way it is also (atm manually -> this needs to change soon) tested...

See also https://github.com/LoPoHa/CobolTruffle/issues/17

A lot doesn't work at the moment.
Like is numeric, and, or, parenthesis, not , ...
I'll merge this to have something for the internal prototype and implement the remaining stuff later.


CRD Strategy: implement concurrencyPolicy

Fixes #1

This implements concurrencyPolicy to lock currently running workflows/CR.
Added some doc/example fixes

Testing done

Unit tests passing
Full bdd test testing
Manually ran rollingupgrades with InstanceGroup AMI changes and only a single CR was processed at a time.

Codecov Report

Merging #6 into master will decrease coverage by 3.19%.
The diff coverage is 53.33%.

@@            Coverage Diff            @@
##           master       #6     +/-   ##
=========================================
- Coverage   69.37%   66.18%   -3.2%
=========================================
  Files           5        5
  Lines         542      618     +76
=========================================
+ Hits          376      409     +33
- Misses        122      155     +33
- Partials       44       54     +10

Impacted Files
Coverage Δ

...ontrollers/provisioners/ekscloudformation/types.go
63.07% <50%> (-1.84%)
:arrow_down:

...rollers/provisioners/ekscloudformation/strategy.go
50.81% <52%> (-5.31%)
:arrow_down:

...trollers/provisioners/ekscloudformation/helpers.go
59.57% <59.09%> (-0.43%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e36618...166644d. Read the comment docs.


www/nginx: 1.34

Hi!
more quick fixes than anything new, but still )

Add the option to not log TLS handshakes
Remove obsolete http2_push_preload directive
Migrate from the deprecated 'listen … http2' directive to the 'http2' directive

ref.:
https://github.com/opnsense/plugins/issues/3854
https://forum.opnsense.org/index.php?topic=41415.0
https://nginx.org/en/CHANGES (1.25.1 version changes)
@fabianfrz please take a look when you have time
Thanks!

Merged, thanks!

Thanks!!


Work together with a barcode reader capacitor plugin

Is your feature request related to a problem? Please describe.
To open the camera and start scanning barcodes.
Describe the solution you'd like
Install a third-party barcode reading plugin and then in the camera preview plugin's native side, use it to read barcodes.
Describe alternatives you've considered
Pass the frame as base64 to third-party plugins. But this may have a performance issue.
Additional context

I ended up using captureSample to pass the base64 to a third-party computer vision plugin.


[Dart] broadcastStream.first misses the first value if emitted immediately onListen & sync=true

Steps to reproduce
Please take a look at this bug report in flutter_blue_plus: https://github.com/boskokg/flutter_blue_plus/issues/740
Expected results
the first value should never be missed
Actual results
the first value is missed, and the future never completes
Code sample
Please take a look at this bug report in flutter_blue_plus: https://github.com/boskokg/flutter_blue_plus/issues/740
Screenshots or Video
Please take a look at this bug report in flutter_blue_plus: https://github.com/boskokg/flutter_blue_plus/issues/740
Logs
Please take a look at this bug report in flutter_blue_plus: https://github.com/boskokg/flutter_blue_plus/issues/740
Flutter Doctor output
[✓] Flutter (Channel stable, 3.13.4, on macOS 13.4.1 22F770820d darwin-arm64, locale en-US)
• Flutter version 3.13.4 on channel stable at /Volumes/User/MBP-Google-Drive/jamcorder/app/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 367f9ea16b (3 months ago), 2023-09-12 23:27:53 -0500
• Engine revision 9064459a8b
• Dart version 3.1.2
• DevTools version 2.25.0
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/chipweinberger/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14E300c
• CocoaPods version 1.12.1
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2022.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
[✓] VS Code (version 1.85.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.78.0
[✓] Connected device (2 available)
• macOS (desktop) • macos  • darwin-arm64   • macOS 13.4.1 22F770820d darwin-arm64
• Chrome (web)    • chrome • web-javascript • Google Chrome 119.0.6045.159
! Error: Failed to prepare the device for development. Please unlock and reconnect the device. (code 806)
[✓] Network resources
• All expected network resources are available.
• No issues found!

this is expected

If an event is added in a setting that isn't known to be another event, it may cause the stream's listener to get that event before the listener is ready to handle it. We promise that after calling Stream.listen, you won't get any events until the code doing the listen has completed. Calling add in response to a function call of unknown origin may break that promise.

An onListen callback from the controller is not an asynchronous event, and adding events to the controller in the onListen callback is always wrong. The events will be delivered before the listener has even received the subscription yet.


[suggestion] a toggle to make it "snow" everywhere?

Just purely visual, obviously. I tried replacing the rain texture with the snow texture but the particles are massive, plus it still makes the raining sound.

You can probably use seasons to make it snow everywhere, or use worldedit when playing on creative to change biomes, a toggle for snow doesn't really make any sense imo


npm install hang on several missing packages, either with node10 or node12

Hi,
Thanks for your default pdf config repo.
As of today 2020-03-27, after cloning and entering in the cloned directory npm install  throw a max of errors.
Tried with both node12 (error but success only for node-sass after altering node-sass version to 4.12.72 in package.json) or node10 ...
Here, errors after cleaning node-module & package-lock.json, with node12 (tried to reduce verbosity ...)

npm ERR! path .../mkpdfs-design-sample/node_modules/yargs/node_modules/camelcase/package.json.4015666455
ENOENT: no such file or directory, open '...mkpdfs-design-sample/node_modules/yargs/node_modules/camelcase/package.json.4015666455'

TIA for any answer
Cheers from cloudy Marseille, France

Hi @oturlier
Sorry for answering this late. It's quite difficult to perform follow ups for now.
I've made an update on packages. Can you please try and tell me if your issue has been fixed?
Thanks,
I hope this will fix your problem.
Take Care.
From Belgium


serde_json couldn't deserialize tree while pruning

rustic was build from git. rustic snapshots runs fine. repo was created with restic.
rustic prune
[INFO] using config /etc/rustic/rustic.toml
[INFO] repository opendal:home-schafweide-org: password is correct.
[INFO] using cache at /root/.cache/rustic/c27e74820324407a483109cc23f5b917fa8a8a98ab688718a6d310fae3c11330
[00:00:02] reading index...               ████████████████████████████████████████         62/62
[00:00:00] reading snapshots...           ████████████████████████████████████████         24/24

error: serde_json couldn't deserialize tree from bytes of JSON text: Error("invalid type: null, expected a base64 encoded string", line: 1, column: 15141)

Thanks @bjo81 for reporting. Seems this is some xattr which is set to null by restic..
I think this should be fixed once https://github.com/rustic-rs/rustic_core/pull/235 is in rustic_core.


Run command from Command ID

Say I want to invoke a command with a specific command ID.  For some commands, like workbench.action.toggleEditorVisibility the command palette does not return any results (e.g. if I type toggleEditorVisibility nothing comes out).
How can I invoke a command by directly typing its command ID?
Note: I opened this issue as a feature request. This is also tracked in this question in SO.

You cannot. If you are an extension you can use the vscode.commands.executeCommand-api, you can assign a keybinding (F1> Open Keyboard Shortcuts), and there is a request for user configurable menus (https://github.com/microsoft/vscode/issues/9285)


Upgrade to pana 0.7.3

Any idea what's going on here?
$ pub get
Resolving dependencies... (1.6s)
Package pana has no versions that match 0.7.3 derived from:
- pub_dartlang_org depends on version 0.7.3

Yet, it was published yesterday.

travis using non-matching sdk?


change the text of the light&dark mode toggle button

Please describe the problem
After we switch to light mode, the mode toggle button needs to show 'Dark Mode' to move from light mode to dark mode but instead it remains as 'Light Mode'. It will enhance the user experience and make it easier for the user to toggle between the two modes.
Describe the solution you'd like
After switching to light mode, the text on the button should read 'Dark Mode'.
Screenshot

Sure, I'll remember to add a screenshot during the Pull Request

It seems like the changes have already been made by someone else.


Update active-directory-b2c-configure-signup-self-asserted-custom.md

Add documentation for using "," as the delimitor for default values of CheckboxMultiSelect.

@stevenxzhou : Thanks for your contribution! The author, @davidmu1, has been notified to review your proposed change.

According to the PM responsible for the article, "the suggested solution works for edit profile, when you first read the information from the directory and then present the existing values. This article talking regarding sign-up, and using the SelectByDefault is the supported solution."
#please-close


[FEATURE REQUEST] Pass in properties to Custom Socket Factory Constructor

Is your feature request related to a problem? If so, please give a short summary of the problem and how the feature would resolve it
I'm one of the maintainers of the Cloud SQL Java Connector and my team is working on making improvements to the JDBC socket factory for SQL Server by allowing users to pass in more configuration options (for example, allowing them to specify connecting over Public or Private IP). In order to do this, we would need to pass in more than one argument to the SocketFactory constructor.
Describe the preferred solution
Instead of passing in a socketFactoryConstructorArg string to the SocketFactory constructor, give it access to all of the properties from the JDBC connection URL.

Reference Implementation
Example implementation from Postgres JDBC Driver: https://github.com/pgjdbc/pgjdbc/blob/01dbbac5b6c43e1079a463119e13c1bee74cbfdb/pgjdbc/src/main/java/org/postgresql/core/SocketFactoryFactory.java#L39

hi @shubha-rajan
Thank you for the suggestion, the team will consider this when we look into new features for the driver.


Updates #1344 for feature requested in #1257 and Closes #1257: option to use commitOrdering

Description

Updates eamodio#1344 for feature requested in eamodio#1257: option to use commitOrdering
commitOrdering setting will now allow to order the commits by date, author or topo.

Checklist

[x] I have followed the guidelines in the Contributing document
[x] My changes follow the coding style of this project
[x] My changes build without any errors or warnings
[x] My changes have been formatted and linted
[x] My changes include any required corresponding changes to the documentation
[x] My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
[x] My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

Merged this into the original PR https://github.com/eamodio/vscode-gitlens/pull/1344
Thank you for your contribution!

@eamodio Thank you and thanks for the amazing GitLens!


pt(13120): Change javascript workflow

https://github.com/rathmerdominik/SwagPaymentPayPalUnified/actions/runs/5455562895

Cant do: Plugin installs a specific version of ESLint
https://stackoverflow.com/questions/71572243/error-eslint-7-32-0-eslint-couldnt-find-the-config-standard-to-extend-from


Dashboard to see Members, Teams, permission status, and projects

Feature request for organization account project in PyPI.

Description
The Owner/Manager can see a list of projects, teams associated with the project and Members in each Team

User value
Easy to view each project, Team and Members and permission status

Part of this will be updating the Collaborators page for projects to indicate permissions granted to organization owners and teams.


Added One-Click and Go-To action to hasjob emails.

Added one-click action "Confirm Email Address" to email id confirmation.
Added go-to action "Reset password" to the email for resetting password.

@jace Could you please review this.


[orc] update to 1.9.3

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[ ] The "supports" clause reflects platforms that may be fixed by this new version.
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Thanks for the update!

Thank you @BillyONeal .
cc @dongjoon-hyun . I'm still working on the 2.0.0. It might need some changes on it.

Thank you so much for your effort on both versions, @deshanxiao !


Dev

Short Description:
Allow more time for Pokemons to appear during sniping from URLs.
Currently, if it falls into the if (seconds_since_last_check < self.MIN_SECONDS_ALLOWED_FOR_CELL_CHECK) statement, the wait time is around 1 second and that does not give enough time for the Pokemon to show up. It ended up missing some of the Pokemon.
Fixes/Resolves/Closes (please use correct syntax):
#5669

I am pretty sure this PR is a mistake, closing it.


Cryptomator FUSE mounts result in segfault

Describe the bug
I used to be able to run this quite easily, but it seems this package got broken in later version.
The error that appears after entering the correct password (when opening Cryptomator in console):
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007f4a403c8189, pid=16028, tid=16311
#
# JRE version: OpenJDK Runtime Environment (17.0.1+12) (build 17.0.1+12-nixos)
# Java VM: OpenJDK 64-Bit Server VM (17.0.1+12-nixos, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
# Problematic frame:
# C  [jffi1147876796803623234.so+0x7189]
#
# Core dump will be written. Default location: Core dumps may be processed with "/nix/store/q0881awy50g4srnnwasci37y2jk5sf99-systemd-249.5/lib/systemd/systemd-coredump %P %u %g %s %t %c %h" (or dumping to /home/peter/Projects/Trash/cryptomator/core.16028)
#
# An error report file with more information is saved as:
# /home/peter/Projects/Trash/cryptomator/hs_err_pid16028.log
#
# If you would like to submit a bug report, please visit:
#   https://bugreport.java.com/bugreport/crash.jsp
#
[1]    16028 abort (core dumped)  cryptomator

Steps To Reproduce
Steps to reproduce the behavior:

open Cryptomator (in console by typing cryptomator)
make a volume if you don't have one already
enter password and unlock
watch it crash

Expected behavior
Volume has been mounted and I can use it.
Additional context
I thought maybe upgrading Cryptomator would help, but it results in the same error. My current WIP nix package update:
{ lib
, stdenv
, fetchFromGitHub
, autoPatchelfHook
, fuse
, packer
, maven3
, openjdk17
, jre
, makeWrapper
, glib
, wrapGAppsHook
}:

let
  pname = "cryptomator";
  version = "1.6.4";

  src = fetchFromGitHub {
    owner = "cryptomator";
    repo = "cryptomator";
    rev = version;
    sha256 = "15pp4fg8q2b9p9zcqqb8lfp3hr5170yj3md5qc9i3lx0dn58qd2i";
  };

  # perform fake build to make a fixed-output derivation out of the files downloaded from maven central (120MB)
  deps = stdenv.mkDerivation {
    name = "cryptomator-${version}-deps";
    inherit src;

    nativeBuildInputs = [ openjdk17 maven3 ];

    preConfigure = ''
      sed '/isKeyLocked/c\//removed temporarily (do we have old OpenJFX on Nix?)' -i  src/main/java/org/cryptomator/ui/controls/SecurePasswordField.java
    '';

    buildPhase = ''
      mvn -Plinux package -Dmaven.repo.local=$out/.m2
    '';

    # keep only *.{pom,jar,sha1,nbm} and delete all ephemeral files with lastModified timestamps inside
    installPhase = ''
      find $out/.m2 -type f -regex '.+\(\.lastUpdated\|resolver-status\.properties\|_remote\.repositories\)' -delete
      find $out/.m2 -type f -iname '*.pom' -exec sed -i -e 's/\r\+$//' {} \;
    '';

    outputHashAlgo = "sha256";
    outputHashMode = "recursive";
    outputHash = "0qp9z2di31dx24s62kb8py93payjbifs4j7727myvz9pss4vv2j2";
  };

in
stdenv.mkDerivation rec {
  inherit pname version src;

  preConfigure = ''
    sed '/isKeyLocked/c\//removed temporarily (do we have old OpenJFX on Nix?)' -i  src/main/java/org/cryptomator/ui/controls/SecurePasswordField.java
  '';
  buildPhase = ''
    mvn -Plinux package --offline -Dmaven.repo.local=${deps}/.m2
  '';
  installPhase = ''
    mkdir -p $out/bin $out/libs $out/mods
    # moving over all libs
    cp -r target/mods/* $out/mods
    cp target/cryptomator-1.6.4.jar $out/mods
    cp -r target/libs/* $out/libs

    makeWrapper ${jre}/bin/java $out/bin/cryptomator \
      --add-flags "-p '$out/mods'" \
      --add-flags "-classpath '$out/libs/*'" \
      --add-flags "-Dcryptomator.settingsPath='~/.config/Cryptomator/settings.json'" \
      --add-flags "-Dcryptomator.ipcSocketPath='~/.config/Cryptomator/ipc.socket'" \
      --add-flags "-Dcryptomator.logDir='~/.local/share/Cryptomator/logs'" \
      --add-flags "-Dcryptomator.mountPointsDir='~/.local/share/Cryptomator/mnt'" \
      --add-flags "-Djdk.gtk.version=3" \
      --add-flags "-Xss20m" \
      --add-flags "-Xmx512m" \
      --add-flags "-m org.cryptomator.desktop/org.cryptomator.launcher.Cryptomator" \
      --prefix PATH : "$out/usr/share/cryptomator/libs/:${lib.makeBinPath [ jre glib ]}" \
      --prefix LD_LIBRARY_PATH : "${lib.makeLibraryPath [ fuse ]}" \
      --set JAVA_HOME "${jre.home}"

    # install desktop entry and icons
    cp -r ${src}/dist/linux/appimage/resources/AppDir/usr/* $out/
  '';

  nativeBuildInputs = [ autoPatchelfHook maven3 makeWrapper wrapGAppsHook openjdk17 ];
  buildInputs = [ fuse packer jre glib ];

  meta = with lib; {
    description = "Free client-side encryption for your cloud files";
    homepage = "https://cryptomator.org";
    license = licenses.gpl3Plus;
    maintainers = with maintainers; [ bachp ];
    platforms = platforms.linux;
  };
}

Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 ✘ peter@stoeptegel3  ~/Projects/Trash/cryptomator   nixos-test ±  nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.81, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.16`
 - channels(root): `"nixos-21.05.4438.5854a24cfcc, nixos-unstable-22.05pre335103.6daa4a5c045"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

Closing this, I fixed it in https://github.com/NixOS/nixpkgs/pull/150402


Seek behavior

This is a somewhat preliminary implementation of the Seek behavior for two different types of Kinematics.
Examples/tests will be added later, when I figure out a system for them.

Lgtm, maybe pull in Melos so that we don't have to manage the changelog manually?

I was thinking of adding Melos after the initial release, because the initial changelog wouldn't be very meaningful anyways.


check if property is empty in request

WHY
BEFORE - What was wrong? What was happening before this PR?
We were only covering the case where empty strings would be converted to null by using Laravel ConvertEmptyStringsToNull middleware.
As reported in https://github.com/Laravel-Backpack/CRUD/issues/4727 , disabling that middleware had side effects on our pagination because the null coalescing operator does not understand empty the same as null.
AFTER - What is happening after this PR?
we use empty() so that we cover empty strings or null values.
How can we test the before & after?
Enable/disable the middleware and test the ListOperation

OMG i didnt disable middleware so didnt see this problem:

Everything work normal after get this branch

I have disable middleware on base and Kernel

Look working great now.
Cheers.


Added option to 3d transforms

Heyo...
I've added the ability to use 3d transforms, example:
translate: {
  '1/2': '50%',
  full: '100%',
  center: '-50%, -50%',
  parallax: '20px, 10px, 100px'
},

There is a big ole conflict with the formatting, I'm using vscode with prettier and format on save, so it kinda did it's thing!
I've updated the test and readme.
It would be grand if this could get merged.
cheers

closing PR (as per our discussion - i.e remove formatting changes)


Document Oculus Home finickiness

Per https://www.reddit.com/r/WebVR/comments/72pxnl/getting_webvr_running_with_oculus_dk2_in_firefox/

this was fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=1384279. in a new PR, I've marked this bug as Fixed.


Add Ethereum BLS Signature verification tests

Adds a cairo program that can verify Ethereum beacon chain signatures. The ethereum test contains a valid block from the sepolia testnet.
Pull Request type
Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[x] Testing
[ ] Other (please describe):

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Closing as using deprecated lib


Oracle offline detection with multi collateral

Context
Before multicollateral, we had a simple oracle off-line detection system. If the oracle was inactive for too long, then we would stop incrementing active_block_count. Each bitcoin block header stored the active_block_count when it got relayed. An issue/redeem/replace is only cancellable when active_block_count increased by a certain number.
Problem
Now that we have multi collateral, we need to account for the possibility that one currency does not get updated, and thus the exchange rate becomes invalid for that specific currency. Operations with other currencies should be able to continue to function.
Solutions

Make oracles submit all currencies simultaneously. That way, either all currencies will be outdated, or none will be. Most of the logic can remain unchanged. The problem would be adding or removing currencies - different oracle providers will have to change the calls they are making simultaneously.
We can halt for all currencies if one of them is outdated.
We can maintain a active_block_count per currency. This requires additional iteration in System, to increment the value each block for all currencies. Note that we iterate over the currencies in the oracle anyway, so the big O complexity does not change. The client cancellation logic gets slightly complicated, but this should be manageable. We currently store active_block_count in bitcoin block headers, so this struct would grow some, but we might be able to store just the normal parachain height - I think we only use it to require a certain number of parachain confirmations before we accept bitcoin blocks.

I think I'm leaning to the last solution. The main downside is that it is the most complex solution, and thus has highest risk of bugs. But I feel it's the most correct solution.

What is the difference between solution 1 and 2? In 1, you'd just fail the setter if not all currencies are in included and in 2 you'd allow partial setting but you'd halt if one of them is outdated. Is that correct?
My main concern is around the time when we add a new collateral currency. I think once live, the oracles would not do partial updates, but I am concerned that if we add a new collateral currency and oracles are not catching up in time that we halt the entire functionality of the chain.
On the other hand, solution 3 adds a lot of complexity on the code side that would increase with every new asset we are adding (increasing the diff for a runtime upgrade).
I am currently leaning towards solution 2 whereby we need to ensure out-of-band that our oracles are up-to-date as it is a lot simpler than solution 3 and seem to be less impactful on future runtime upgrades/slightly better for performance as well.
But I would also like to hear what @alexeiZamyatin and @gregdhill are thinking.

What is the difference between solution 1 and 2? In 1, you'd just fail the setter if not all currencies are in included and in 2 you'd allow partial setting but you'd halt if one of them is outdated. Is that correct?

Yea in solution 1 it'd be mandatory for all oracles to supply all exchange rates at the same time, otherwise feed_values returns an error. This way you don't need separate offline detection per currency - either all are outdated or none are. In the second solution, you allow the omission of currencies in feed_values, so you have to do offline detection per currency. When a single currency is considered offline, this solution marks all of them as offline (such that most of the system can remain unchanged).

My main concern is around the time when we add a new collateral currency.

We could implement some activation logic. I.e. right after adding a new currency, oracles can start including the new exchange rates in their submissions, but the currency does not become active until a certain number of vaults include the new exchange rate. Until the activation, vaults can not register with the currency, and an insufficient number of inclusions does not trigger an oracle offline event.
The number of required active oracle feeds for 'activation' could be higher than the minimum number required to be considered offline. E.g. activate only when it is included by 3 oracles, but don't trigger 'oracle offline' unless the number of oracles is strictly less than 2.

Guess it could prove tricky to enforce that all oracles have all price feeds, but I would certainly prefer that to the additional complexity introduced in the other strategy.
On a related note, there are many reasons why an oracle may no longer provide a particular price feed - e.g. attack on the origin network. How do we plan to deprecate a currency? This might be worth splitting into a separate research ticket.

I think we'll have to operate under the assumptions that:

We will allow only a few currencies as collateral where we can reliable get price data for
Not all oracles might provide price data for all assets, e.g., I can imagine that if we add staking derivatives, only Polkadot specific oracles might provide prices for that whereas other oracles might lag behind

My current preference is option 2 since it's the most simple to implement and under the assumption that we have at least one oracle submitting prices for each asset, this works.

On a related note, there are many reasons why an oracle may no longer provide a particular price feed - e.g. attack on the origin network. How do we plan to deprecate a currency? This might be worth splitting into a separate research ticket.
You mean an attack on the oracle network or an attack on the currency we want to get the prices for?


1.0 intergration test fixture os independed

Based on https://github.com/neo4j/neo4j-dotnet-driver/pull/30
I just changed two lines

Made the download file location from {Version}.zip to {Version}{platformEnding}
Force to wait in WindowsServiceBasedNeo4jInstaller.start too

Then I formated the code to use 4-space-tab. Please use 4-space-tab when contributing, this is the only format requirement at this moment :)
Reopen the PR targeting 1.0 instead

@IngvarKofoed I got some problem to use enterprise windows zip file. So I also changed back to community. Would you mind to check out his branch and verify if you could use WindowsServiceBasedNeo4jInstaller now? If you could use the new one, do you mind me to remove the process installer?

I have tested #33 and it works for both community and enterprise :)
I agree that ee do not need the process based installer more now that the other is working. So feel free to delete it :)
Ill make PR for an installer that works on OSX (Linux and Unix) later today or tomorrow


docs: add note regarding the use of CNAME records

This PR adds a note discouraging the use of CNAME records for * that point to the public hostname of AWS Elastic Load Balancers.
Okteto Enterprise automatic certificate management uses cert-manager to issue the wildcard certificate used by the deployment. This certificate is issued by Let's Encrypt as default and uses ACME dns01 verification challenge, which consists of creating a TXT dns record for the Okteto domain.
If the user creates a CNAME dns record for *, it will shadow any other dns records, including TXT. This blocks the issue/renewal process as the verification can no longer be achieved.
Reasons why a user may set a CNAME record include the scenario where they manage DNS from a different AWS account, making it impossible to set an A dns record with an alias, or where they manage DNS with a different service/software rather than AWS Route53.
The best way to solve the issue for these scenarios would be to use AWS Network Load Balancers, which expose a public static IP.

Correct, but I think it's ok since this is an issue with AWS and not with our product.


Send to Alby Fails

Mutiny PWA wallet consistently fails to send to Alby.
Uploaded logs as requested by Tony.
mutiny-logs.txt

Thanks for that. As indicated in the discord:
"thanks for that. Doesnt look like there's anything out of the ordinary on your device specifically. Just a bunch of bad routes being taken, though our prober is still doing fine at making large payments. I've asked the LSP to open a channel to alby directly, it looks like it had been closed previoiusly. They will so hopefully it's better afterwards."
Hopefully that'll fix it, nothing wrong on mutiny itself.


Improving the UI of the Donate Page

The Donate Page looks very simple, I would like to Improve the Ui of this Page, like adding a Background Picture and making some font improvements and other changes.

go for it!

Hey @akshitagupta15june please assign this issue to me.

Hello @akshitagupta15june  mam I am a frontend developer and I can make this UI so impressive for users so can you please assign this issue to me?


fix: color-contrast

This PR fixes the issue related to background and foreground color visibility issue.
Fixes #120
Screenshots

Note to reviewers
Please Review the changes :)

Summary by CodeRabbit

Style

Updated text colors in the Activity component for better visibility and aesthetics.

Did you mean to close the PR?


Is it compatible with redux 3.6.0 for React Native project?

Hi,
We just want to use this awesome lib in our React Native project, but it looks like the redux-form has version requirement on redux.
I saw the basic requirement on official document is : react-native@18+, redux@4+ and npm@3+ (reference). react-native and npm on our project are satisfied with it, but redux version is 3.6.0, which is below than it. Could anyone help us with the decision? Is the redux-form compatible with redux 3.6.0 for React Native project? or are there any pitfall using redux in this version for React Native project?
Thanks in advance.

Please note you're looking at old docs! http://redux-form.com/7.0.3/docs/faq/ReactNative.md/ will point you towards https://esbenp.github.io/2017/01/06/react-native-redux-form-immutable-styled-components/.
Also, would you be willing to also raise this question on Stack Overflow? That way answers will remain visible for longer :).

Thanks for your tips @danielrob , I'll try it in my project at first.

Because this issue saw almost no activity for a few months, I'm closing it.


Storage scanner hide inventories

I have a big bank of drawers as main storage in base and they all linked to my storage scanner one drawer controller, I would like the options to hide the 20 odd drawers that my storage scanner does not need to know about, this does not mean hide all unroutable inventories, as I have cell that is unroutable that like I to send low charged item to charge on the go including the storage scanner tablet itself.

The easiest way to do that right now is simply to move all those inventories to the bottom of the list

What have done I have got a ridiculously small scroll bar, plus when I add something new, I have to more it top then past about 15 item I want above it. So way of hidden them in the further would nice.

Implemented for next release


Fatal Windows exception code 0xc0000005 PhantomJS has crashed

i tried to drawing data 93,240 nodes, 50,000 edges. but i met this
error: Fatal Windows exception, code 0xc0000005.
PhantomJS has crashed. Please read the bug reporting guide at
http://phantomjs.org/bug-reporting.html and file a bug report.
i think this is memory issues. i am trying is it possible to drawing graph with a lot of data fastly.
when i try using cytoscapejs in only client, i can get graph with little long time. but in cytosnap is fail.
is there any segestion?

Was this issue resolved. Because I still get it!

Either the graph is too big for your machine with PhantomJS or the image is too large.

Phantom issues won't apply to the package anymore with the change to Puppeteer.


Zoning should persist after structures are built

If a structure is destroyed by external forces, it should automatically be rebuilt.

This is currently the case.


Using cordova.plugins with Phonegap app developer

Hi,
I'm trying to use File Opener 2 (https://github.com/pwlin/cordova-plugin-file-opener2), when I generate the apk file from cli with cordova build  command everything works like a charm, but if I'm trying to test my app using Phonegap App Developer this error is thrown in my console:
[phonegap] [console.error] Error: undefined is not an object (evaluating 'cordova.plugins.fileOpener2')
Plugins like Camera, File and File Transfer work fine in Phonegap App Developer, it seems to be a bug with some 3rd party plugins.

it seems I can not use any plugins, I tried both on Android 4.1 and 4.4。

We're greatly improving the build process for the PG Dev App. Once complete, it should allow you to easily add third-party plugins and build your own version.

Alright guys, I've added documentation to the README.md to explain how to add a custom plugin and build the app on your local system. At the moment, you must use the platforms-as-artifacts branch (this is not mentioned in the README.md). Around next week, you can expect this branch to be merged into master.
Cheers!

Thank you @mwbrooks. Unfortunately it does not work. I've added cordova-plugin-imagepicker
$ cordova plugin add cordova-plugin-imagepicker --save

after that I did a
$ npm run -- phonegap run android

Now when I make a phonegap serve in my project directory my code tells me in my deviceready event that window.imagePicker is undefined.

No difference :confused:

Hi @screendriver,
Alright,  I've been able to recreate your problem and I've got the plugin working.
The first problem/solution is in Step 3 - Cordova installs an outdated version of the plugin.
The second problem/solution is in Step 6 - the plugin documentation is out-of-date because window.imagePicker should be window.plugins.imagePicker.
Here are my steps:

Navigate to the PhoneGap Developer App repository:
 $ cd phonegap-app-developer/

Add the plugin and save it to the config.xml:
 $ npm run phonegap -- plugin add cordova-plugin-imagepicker --save
 # or if you have cordova globally installed
 $ cordova plugin add cordova-plugin-imagepicker --save

Update the plugin from 1.1.0 to 1.3.0

For some reason, Cordova installs an old version of the plugin

Edit the config.xml to use the latest version:
  <plugin name="cordova-plugin-imagepicker" spec="~1.3.0" />

Compile and run the PhoneGap Developer App:
 $ npm run phonegap -- run ios

Create a sample project:
 $ phonegap create my-app

Add some image picker code to www/js/index.js:
 onDeviceReady: function() {
     app.receivedEvent('deviceready');

     alert(window.plugins.imagePicker.getPictures);

     window.plugins.imagePicker.getPictures(
         function(results) {
             for (var i = 0; i < results.length; i++) {
                 console.log('Image URI: ' + results[i]);
             }
         }, function (error) {
             console.log('Error: ' + error);
         }
     );

Serve and connect to the app:
 $ phonegap serve

Oh, ups. So the problem was the plugin itself, not phonegap? I am a bit embarrassed because I've only tried it out with this one plugin to test it with an example app :pensive:
Thank you for your help! :+1: It's working finally! Great! :sunglasses: In our company we waited so long for this feature :wink:

It's all good @screendriver! There were a number of problems, so it's natural to assume that it was PhoneGap.
Glad this is a feature that you've been waiting for! Feel free to create issues for any feature that you think would help your company. If we think it can apply to more people, we are open to adding it (Mobile App, Desktop App, or CLI).

Hi! @mwbrooks I have followed all the steps in your previous comment but window.cordova.plugins are still undefined...
In combination with phonegap serve must I use it with Phonegap App or simply with the browser?
I have tried both and only been able to work with Phonegap App, but window.cordova.plugins is still undefined...
I'm trying to use https://github.com/phonegap/phonegap-plugin-barcodescanner
Any advice about that?
Thanks!

In combination with phonegap serve must I use it with Phonegap App or simply with the browser?

You have to compile the App by yourself. After that you have to deploy that App to your emulator / device. Then you can use phonegap serve.
Could you post step by step what you did?

Ok I understand... but, how could I compile the App? Is the easiest way to compile using Phonegap Build?

but, how could I compile the App?

It's all documented in the docs: there is section called adding-custom-plugins.

I have followed these steps too, but when it is going to finish, console throws this error:
You may not have the required environment or OS to run this project
I'm working on a Windows computer and trying to test it on an iPhone... I think this is the problem.
So, Phonegap Build would be my only possible chance? Is there anyway to follow these steps from Windows to test on an iPhone device?
Thanks for your advices :)

Unfortunately not. You have to use Mac OS X to develop and deploy an iPhone App :confused:

@benjasHu unfortunately, ask @screendriver mentioned you cannot build the iPhone app on Windows.
@screendriver Thanks a lot for following up on this conversation today!

You're welcome :sunglasses:

Finally I'm using Phonegap Build to test/create my app.
Anyway, thank you both for your support @screendriver @mwbrooks !


Object Detection C++ Test Failure

On master, we have a C++ unit test failure in test_od_serialization.cxx
Running 2 test cases...
/build/test/unity/toolkits/object_detection/test_od_serialization.cxx(33): error: in "test_init_darknet_yolo": check (nn.layers_size()) == (25) has failed [31 != 25]
/build/test/unity/toolkits/object_detection/test_od_serialization.cxx(42): error: in "test_init_darknet_yolo": check convlayer_.has_convolution() has failed
/build/test/unity/toolkits/object_detection/test_od_serialization.cxx(44): error: in "test_init_darknet_yolo": check (convlayer_.name()) == ("conv" + std::to_string(x.first) + "_fwd") has failed [pool0_fwd != conv1_fwd]
/build/test/unity/toolkits/object_detection/test_od_serialization.cxx(45): error: in "test_init_darknet_yolo": check (convlayer_.convolution().outputchannels()) == (x.second) has failed [0 != 32]
/build/test/unity/toolkits/object_detection/test_od_serialization.cxx(46): error: in "test_init_darknet_yolo": check (convlayer_.convolution().kernelchannels()) == (num_features) has failed [0 != 16]
[libprotobuf FATAL /build/src/external/google/protobuf/repeated_field.h:1142] CHECK failed: (index) < (current_size_):
unknown location(0): fatal error: in "test_init_darknet_yolo": __tc_google::protobuf::FatalException: CHECK failed: (index) < (current_size_):
/build/test/unity/toolkits/object_detection/test_od_serialization.cxx(47): last checkpoint

*** 6 failures are detected in the test module "test_od_serialization"

#2418 Test test_init_darknet_yolo needs to be updated to match change in model initialization i.e. added pool layers.


Do external public release

As part of this, we should go to W3C CSV-W group and ask them to put our tool up there too, given that it passes most of the tests.

https://github.com/GSS-Cogs/csvw-check/releases/tag/v0.0.3


Old ReplicaSet Not deleted

deploy a new application version，the old ReplicaSet was not deleted

What's your version of vela? Can you describe more details about how to re-produce?

@RainElohim This is the Deployment version mechanism, you can set the spec.revisionHistoryLimit, and the default value is 10.
refer to : https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#clean-up-policy
In Kubevela, the webservice component type can not support this field, you can custom the definition and refer to the document:  http://kubevela.net/docs/platform-engineers/oam/x-definition

@RainElohim This is the Deployment version mechanism, you can set the spec.revisionHistoryLimit, and the default value is 10. refer to : https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#clean-up-policy
In Kubevela, the webservice component type can not support this field, you can custom the definition and refer to the document: http://kubevela.net/docs/platform-engineers/oam/x-definition

thanks for your reply


python client failed

I cloned the repositrie of interop from github and after going through all the steps i encounter this error "python client failed"(both of the clients failed). but server and frontend passed.
here is the link to the terminal output i'm getting :- http://pastebin.com/c6v5rP1R
please help

Do you have the output from the setup script? The errors like /interop/test.sh: line 8: venv/bin/activate: No such file or directory indicate that the setup did not complete successfully.

her's the link to the output
http://pastebin.com/c6v5rP1R

Yes, I saw that; I mean the setup.sh script that must be run before running tests. (http://auvsi-suas-competition-interoperability-system.readthedocs.org/en/latest/setup/machine_or_vm.html#automated-system-setup)

http://pastebin.com/SXkt6NRT
this is what i'm getting after running the test.sh script.

Fwiw, your attempt to force an upgrade didn't specify the package to upgrade.

@rishabhjoshi750 please git pull and try setting up on a clean machine.


Keyboard shortcuts

Mirror GitHub/vim keyboard shortcuts, t to autofocus file search, s and / to autofocus code search (when implemented) and w to open branch selector in repo view, ? to open help, l and : to jump to line in file view.

Is anyone interested to help implement this?

I've have an idea for the UX here:

Add a keyboard icon below the save icon (right below or maybe closer to where the "Authorize Github" button appears?); onhover: "Keyboard Shortcuts (Ctrl-K or best cross-platform combo)"

Modal opens when "Keyboard Shortcuts" is clicked or its shortcut is typed

List of selectable preset configs, such as Github, vim, emacs, etc.

with default keyboard shortcuts that override browser standards only while modal is open?

is there a better way to determine/choose these defaults?

List of individual actions with inputs for custom keyboard shortcuts

Is there a library we should use for this?

Save/Cancel buttons? Save/Close? Just a Close button?

I'm going to playing with these ideas in a minute. I'm not sure if this will let you pair with me through Nitrous.io, but let's see what happens...

My username on Nitrous.io is crawford if anyone wants to invite. Leave yours if you want me to invite. (Is there really not an easier way to pair like this?)

@crawfordcomeaux cool, don't have time right now to pair with you but interested in what you come up with!

After spending way too long trying to figure out how the icons are used, I realized that it's with an icon font. Would love guidance on how to create a keyboard one.
Also, I'm rusty on my node.js & am not sure where to begin when it comes to adding the buttons. I may have been too tired last night to look in the right place and will look again, but...any guidance?


add send() and receive() for longer messages.

0.3.0

Q: should this send() receive()  be in the rs485 class or should it be a class on top of any stream?

why would "my" packet format be useful for other apps? (ok, keeping it generic will help)
should there be an example how to create an ASCII or BINARY message system? (if binary works, ascii will too).

send(to, from, size, struct); is quite generic.


Branch : Quicklogic : Primitives for the post-layout simulations

Which are the primitive files that can be used for post-layout simulations?
Are the files @ /symbiflow-arch-defs/quicklogic/primitives used for post-layout simulations?
If yes, the primitive names in the top_bit.v file does not match with the names in the above files.
Ex. logic_cell_macro in top_bit.v file and LOGIC in the above primitive file
If the above primitive files are not used for post-layout simulations then can you please point me to the relevant primitive files used for post-layout simulations.

There is port miss match in the primitives that are in top_bit.v file and the above mentioned primitive files (@ /symbiflow-arch-defs/quicklogic/primitives).
Can you point me to the primitives files that needs to be used along with top_bit.v (post layout netlist) for running post-layout simulations.

hi @rakeshm75
please use the cells_sim library from Yosys https://github.com/antmicro/yosys/blob/quicklogic-rebased/techlibs/quicklogic/cells_sim.v

hi @kgugala ,
primitives in cells_sim.v don't have any provision for timing annotation whereas /symbiflow-arch-defs/quicklogic/primitives has timing constructs emdedded.
Is that work in progress? let us know when would that be available as well as SDF generation.