Video quality options (HTML5, YouTube, Vimeo)

please add video quality option for youtube

Will do. good idea 👍

From #220 @thelamborghinistory

First of all I just want to say I came here from PH and I instantly fell in love with this player (not only I have a crush on it but it also came up at the perfect time on my screen ;)). So big kudos to you guys.

However, I am curious if it's possible to integrate an option to switch quality of a video like YouTube has (I think half of the functionality for such a feature is already done with the plyr.source() method, so there might just remain a nice dropup menu for the resolution options). What do you think?
From #245 @tamanhquyen

I have created player using your plugins . But i can't change quality on vimeo source . Please help me . Thanks a lot!

Definitely need quality option for Vimeo on this great player!

Need the video quality option for Youtube !! ^^

Please add a quality change option for html5.
Would use this on all my sites.
Best looking and fastest html5 player ever!
10/10

Eagerly waiting for the Quality change Option for YouTube  like all the others. Amazing player BTW!!

It's coming along...

Yes!!

Looks awesome man. Can't wait.

+1 need this

@SamPotts looking great!

Looks awesome man. Can't wait.

@SamPotts Can't wait this feature.
I want to change my website and waiting for you since may=.=

Great work

Great work

Looks awesome, can't wait.

How`s it going?

Is it done and can be pushed to the master branch?

No, but my baby son is and is growing well. Sorry, he takes priority right now.

Waiting for this badly.

I've been managing to squeeze in some more time here and there in between changing nappies and getting the little fella to sleep. Sorry it's just been a bit more complicated than previous changes given all the new UI components and having a kid in the middle of it wasn't well planned.
This is going to be launched along with:

Multiple caption support
More advanced loop support
Speed controls

I'm getting there just hang in there 👍

Great! :+1:

It looks great ... Not it became more teasing than before 👍

@SamPotts let's us know if you need help testing this. I'd be happy to help out in what ways I can. I've been using your library in a vuejs project and really enjoying it.

Cool - I'm hoping to get a working version up and running in develop soon. Just trying to find more time.

Hey Sam,
How's life juggling the baby and code, I can't even imagine! Hope alls been well.
I am looking forward to your new release of features that's coming our way soon, I had a quick question for you. Will we be able to set the default for the vimeo links to load in HD? I am currently building a website that the user is not able to change controls to the player but I'd still like to load the videos in HD.
Take care!

Hey,
I'm getting there slowly. I keep chipping away at it when I get a few minutes.
Vimeo's API is fairly limited and doesn't allow control over the quality like YouTube does unfortunately. It seems to be "auto" the majority of the time for me - mostly loading in HD.
Nice VWs! I have an R36 wagon and Audi S3 8L myself 👍

Hey @SamPotts .
First of all, Thank you for making such a great HTML5 player 👍
Video Quality option for Direct MP4 Video will be there?
If yes, Please let me know, Will integrate  on https://burffee.com

any update?

Nope, still working on it. You'll see here when there's updates. Sounds like we'll have a load of testers 👍 I'm trying to find time where I can to get it done but as I'm sure you're aware (judging by your avatar) - there's a shortage of time when you have a kid.

I understand, OK we will wait and thanks for your work and time.

Quality selection function What time to launch？

See above. Plyr isn't a commercial, paid product. I do it in my spare time for free.

I think if there's enough people here that are requesting certain updates, we should all come together and donate to help Sam. We should make sure it's worth his time to put the effort to make something we all use even greater.

Totaly agreed to @mkdub .. I am ready to send some help to Sam.
Looking forward to Sam if he can really give us some time ...

Just a reminder that there is a donate link in the readme...use it (I'm about to).

Thanks for the donations guys. Really nice of you. I'll set aside as much time I can this weekend to make progress on the remaining items on my list. 👍

To save people time, as we all now understand time=money.
Here is the direct link to donate. Anything you can put in will go a long way, it's not just for this feature but everything else that will keep this great plugin at the top.

@mkdub Awesome, just sent some support Sam's way. Very much looking forward to seeing the HTML5 HD switch come to live. I can already see it in the dev branch for Youtube. Awesome.

...and then most people forgot about this

...and then most people forgot about this

I'm not sure what you mean? No one's forgotten and I've been putting in as much time on it as I can. So far it only works for YouTube and their API is pretty flaky in this area. The video will play back with "auto" as the default (they determine it based on connection) and from there you can only increase quality it seems. i.e. attempting to go from 720P to 1080P is fine but downgrading doesn't seem to work. The way the API works is you "suggest" a quality and it may or may not change the actual quality - you listen for an event to indicate the quality has changed.
Vimeo does not expose the ability to toggle from SD to HD and vice versa. They don't allow a lot in their API but what they do allow works well.
HTML5 quality control will have to come later, I'm not sure how to tackle that one quite yet.
The main delay is that I'm trying to do too much at once really, the main features in v3 include:

AirPlay support
PiP support
iOS inline playback support
Improvements to the setup (a proper constructor)
Multi language captions support
Improvements to looping options

...accompanied with a fairly hefty re-write in preparation for ES6 and making the lib more modular.

@sampotts awesome Sam. Thanks for the feedback and thanks for putting the effort in besides busy family life! In terms of the HD toggle for HTML5, would it be possible to have a way to extend the controls with a view / icon and registering a custom callback so those who need it might be able to implement it themselves? Same for a HTML5 download button.

@sampotts , thanks so much.

@sampotts, the quality selector will be implemented only for YouTube/Vimeo, or for type: 'video' will also be implemented?

When the quality features add in your product?

Thank you for this amazing player, can i get an early access somehow ? i really need the quality options even if they are not stable 💃

@SadeqRasheed: You can access v3 in the develop-branch. I'm already doing that (only for subtitles), but it's not recommended. Some features are partially implemented and will break unless you disable them.

Yeah as @friday said really. It's still buggy at the moment. I am chipping away at it as much as I can and am close but still doing a lot of testing and fixing bugs. This version should be a lot more stable as a result but again, I can't guarantee when it will be done other than as soon as I can get it out the door.
As for @POPSuL for now it'll be YouTube only. Vimeo doesn't expose their HD toggle. HTML5 will follow soon after (and should be relatively straight forward) but I want to get it out rather than keep delaying.

I've just found your library. It's Awesome!
Just one question.
Is there going to be some sort of an api to add your own options to the popup?
Like a function to add a component, and links within that component, and each link runs a callback function(or something like that)?

Could really use this 🙃 +1

Any update about YouTube option @sampotts ?
Thanks!

any update on html5 ones?

wow.... after 2 year still not released, it should be not very hard. After my comment above few days later I created plugin for Clappr for this functionality. just for idea https://github.com/ewwink/clappr-youtube-plugin

@ewwink as you can read above:

I've been putting in as much time on it as I can

He struggles with reading I think.
@ewwink Going by your avatar, you either have a child or are a child yourself so you know how much time they take up. I must have missed your pull request to actually help? Did I miss a donation from yourself? If so I'm sorry!!
I have to repeat myself over and over seemingly; open source is quite often written by people for free in their spare time. Be thankful, contribute, assist. Anything but sit back and moan like a child.
v3 is in beta. Check it out. It doesn't have HTML5 quality options yet but I will work on that next. It was a major rewrite so it took some time. I hope that's ok with you. I'm sorry I let you down!!

Ok, thanks for your time!

No need to justify, @sampotts. I think I can speak for the majority here when I say that we're grateful for all your effort you put in, in the time you have.

Exactly. I don't have a family/child but I haven't been able to use my spare time to develop and maintain something as popular as plyr. So instead I'm very grateful Sam has pulled it off.

Thanks fellas 👍

Let us know if there's anything we can do to help, test, write, whatever you need.

My compliments for this player, so far it works really smooth!
I don't want to be rude, but is there an ETA for the HTML5 quality options? A few months, half year?

@Droppers This is part of https://github.com/sampotts/plyr/issues/766 due to release very soon. It is implemented, but not for HTML5 yet, and the youtube api seems to ignore quality change requests (https://github.com/sampotts/plyr/issues/793#issuecomment-371278521).
It's hard to do this smoothly with HTML5 video unless it's a stream btw. I'm not sure but I imagine this is why html5 video hasn't been implemented yet.

@friday I am probably missing something, but I don't get why HTML5 video would be difficult.
I will try to implement it myself and I will experience it.

Go for it. Just make sure you remember how the cascading sources work, i.e. if webm is supported, that's used, if not mp4, etc

I think it's easy to implement, but hard to implement smoothly, without pausing or getting jumps. HTML5 Media Fragments for example aren't that precise/granular and neither is the html5 timeupdate event. For a smooth effect you may have to preload another html5 video and swap.
Good luck!

@Droppers , cool. Please leave a note here how you're getting on with that.

Is there any future plan to support changing video quality using shaka player?

I'm working on the HTML5 quality selection at the moment. Will look at Shaka after...

Perhaps you could implement the vanilla HTML5 video first, but allow overriding the actual switching with an event listener? That way you wouldn't have to detect, implement and support individual APIs like shaka, hls.js and dash.js but still work with them. Getting the sources list should be the same for all of them right?

I think they'd be similar but I'm really not too familiar with Shaka, HLS, etc. I really need to brush up in those areas.
The way I'm doing it currently is by using markup like this:
<source src="https://cdn.plyr.io/static/demo/View_From_A_Blue_Moon_Trailer-HD.webm?480" type="video/webm" size="480">
<source src="https://cdn.plyr.io/static/demo/View_From_A_Blue_Moon_Trailer-HD.mp4?480" type="video/mp4" size="480">

<source src="https://cdn.plyr.io/static/demo/View_From_A_Blue_Moon_Trailer-HD.webm?720" type="video/webm" size="720">
<source src="https://cdn.plyr.io/static/demo/View_From_A_Blue_Moon_Trailer-HD.mp4?720" type="video/mp4" size="720">

<source src="https://cdn.plyr.io/static/demo/View_From_A_Blue_Moon_Trailer-HD.webm?1080" type="video/webm" size="1080">
<source src="https://cdn.plyr.io/static/demo/View_From_A_Blue_Moon_Trailer-HD.mp4?1080" type="video/mp4" size="1080">

The issue I foresee is the compatibility of manual selection vs selection via media queries so I'm going to have to do a bit of testing there...

With hls you can also add sources via script. But I don't think it matters. They should end up as iterable child nodes of the video element in the end.
Manual vs automatic switching could be a problem. I don't know much about it, but Imagine it could be handled in an event listener-implementation as well in that case.

I'm not sure the native element fires an event when it switches via media query. Perhaps loadstart but I'd have to do more testing.
https://developer.mozilla.org/en-US/docs/Web/Guide/Events/Media_events

The good news is I have the basic functionality working. There is a flash while the new source loads and the poster image is shown. I'm not really sure how that can be avoided other than somehow preloading the other video which would get really complex I'd imagine. Currently it's just swapping out the source.

So it looks like my solution with the HTML5 quality selection breaks the media query functionality anyway so I think they'd be mutually exclusive. It's a shame there's no way to set an active attribute on the <source> element to force it to be active. Also disabled while we're at it.
Anyhow, I've pushed v3.1.0-beta.1 which includes HTML5 quality selection. I still need to document it properly but effectively you specify a size attribute on the <source> elements and then a menu is created based on that. You can have multiple <source> for the same size with different mime types so the cascading <source> mechanism works as before.
Check it out here:
https://plyr.io/beta

btw, also peek at this implementation (for a different player) https://github.com/clappr/clappr-level-selector-plugin

@aolko Not sure what's going on in that plugin. Pretty bad code: inconsistent formatting, strange variable names, and no comments.
So, I pushed this to master and it's now up at https://plyr.io

@sampotts will this work for HLS as well?

Closing since it's implemented now for HTML5. For Vimeo it's not possible. For YouTube it was supported. Sam implemented it, but YouTube remove the support on their end shortly after :( hls.js, dash.js and Shaka player is still not supported. There are a few assumptions in the architecture that makes this a little hard to implement.

there is not way to add quality list for vimeo ?? after api V.3 i think it become easier !

@friday @sampotts any update about to add Quality for vimeo video?

I cant believe, that it is still not released 😢

@friday here is official vimeo api to get\change quality:
https://github.com/vimeo/player.js/

I'm well aware of the Vimeo JS SDK. Plyr already uses it. However quality selection is reserved for paid accounts. Quality selection is already supported and documented for HTML5. YouTube's API for it is merely allows suggesting a quality level and in reality it's ignored 99.9% of the time. It useless.

@sampotts It is useful, because youtube\vimeo may set 720p for default, bases on internet connection, but users want to see it in 1080p, because their connection support it. And what is problem with paid vimeo accounts? I can give to developers access to my paid vimeo account, it is not problem. We want to use this player in our projects, but quality selection is really important feature.

I don't disagree that it's useful. However, as I said, for YouTube their API is useless for it. I opened a bug and they closed it as expected behavior. You could try again.
As for Vimeo, I'd need access to a paid account or at least a video from a paid account then I could give it a go. I'm surprised no ones given it a go and opened a PR if it's that critical.

@sampotts i can help you with this, can you mail me at<EMAIL_ADDRESS>Or we can connect via telegram @ilyamedzhidov, i will give you access to account or can upload and setup any video for tests.

@sampotts i did it just now, link to video:
https://vimeo.com/509541849

Thanks, I'll take a look.

hi!
Is there currently a video quality option for YouTube?

@Timur0076565 See my comment further up https://github.com/sampotts/plyr/issues/218#issuecomment-774754457

Can I change the default YouTube controls from 0 to 1?
This code doesn't work:

@sampotts
Can I change the default YouTube controls from 0 to 1?
This code doesn't work:

@sampotts
Can I change the default YouTube controls from 0 to 1?
This code doesn't work:

Stupid question.  I wanna use plyr with default youtube controls. This is vary important for my player.

 I wanna use plyr with default youtube controls. This is vary important for my player.

I guess Plyr parse link and take only videoId from url, so any params in your link will ignored

@medzhidov, yes, I already understood that !!
I need some kind of solution how to add YouTube controls using plyr.
Do you have an ideas?

@medzhidov ???

@medzhidov, yes, I already understood that !!
I need some kind of solution how to add YouTube controls using plyr.
Do you have an ideas?

Fork this repo and do what you want)

@medzhidov, Илья, по-моему я задал вполне адекватный вопрос, как мне включить controls = 1, ты же вместо того чтобы подсказать пишешь мне какую то фигню, я повторюсь, если ты такой умный парень, подскажи решение или не лез со своими "Stupid question"!

@medzhidov, А для чего мне Ютубовские контроллеры в этом плеере - это мое личное дело)

@Timur0076565 i answered your question - fork this repo and change youtube embedding for you needs. Stop spam here

Has anyone been able to validate the option for quality exchange recently?

Has any1 found new tags for the itag format? 4K with audio?

@sampotts Could you provide an update on the status of this feature? Has there been any addition of a quality option for playing YouTube videos? If not, it would be highly beneficial if the player could play videos in HD by default.

maybe you can add a feature to AUTO Play Videos in HD by default!?

@jelkomme If you've not gathered already, it's not something Plyr has any control over.

The changes explained below have been in effect for more than one year. This update merely aligns the documentation with current functionality:
The getPlaybackQuality, setPlaybackQuality, and getAvailableQualityLevels functions are no longer supported. In particular, calls to setPlaybackQuality will be no-op functions, meaning they will not actually have any impact on the viewer's playback experience.

Source: https://developers.google.com/youtube/iframe_api_reference#october-24,-2019
I found this out before this was updated. If you want it restored, I'd suggest reaching out to YouTube/Google, but I don't fancy your chances. Good luck!

@sampotts Hi, thanks for the quick response. I just need a player for my website, it can even be the standard YouTube player without a Plyr skin, as long as it has copyright protection (i.e. it doesn't allow clicking on the title, sharing, checking the source file code URL of the video, etc.).  like its already beeng integrated withing your player by this WP-plugin: https://wordpress.org/plugins/protected-video/ - so like you see in the plugin its possble to add some sort of "protection".
Would you be able to take on such a custom job because i need that quality check for my videos?


Check for log file existence

Fixes #9635

This PR is stale because it has been open for a year with no activity. Remove the stale label or comment on the PR otherwise this will be closed in 5 days


Bug 1809862: report lastlogsnippet from init containers on failed/errored builds

aside from including init container, I'm including BuildPhaseError that build controller will set for containers that complete bug exit with non 0 rc
/assign @bparees
@openshift/openshift-team-developer-experience fyi / ptal

updates pushed @bparees ... I will
/hold
this until I get the openshift/origin e2e change up

updates look good, will await e2e

e2e test in openshift/origin PR above

Seen a couple of instances of this unit test failure (unrelated to my change):
=== RUN TestUpdateNewStyleSecretAndDNSSuffixAndAdditionalURLs I0319 19:26:27.499384 10282 docker_registry_service.go:161] Shutting down DockerRegistryServiceController controller I0319 19:26:27.500412 10282 docker_registry_service.go:143] Starting DockerRegistryServiceController controller --- FAIL: TestUpdateNewStyleSecretAndDNSSuffixAndAdditionalURLs (45.01s) docker_registry_service_test.go:168: Waiting for ready docker_registry_service_test.go:179: Waiting to reach syncRegistryLocationHandler docker_registry_service_test.go:191: Waiting to update secret docker_registry_service_test.go:195: failed to call into syncSecret I0319 19:27:12.504798 10282 docker_registry_service.go:161] Shutting down DockerRegistryServiceController controller

Not seeing this when I run unit tests locally.
We'll see if this is a flake after sorting out the e2e's

install / terraform flake on e2e-aws-builds ... will try again in a little bit, in case we are hitting AWS throttling

/retest

the new e2e is catching what this PR fixes as we hoped:  https://github.com/openshift/origin/pull/24727#issuecomment-601725366
/hold cancel

non-build flakes e2e-aws
/test e2e-aws

/retest

have green tests and e2e in openshift/origin is ready @bparees

/lgtm


fix(ci): Install python on Mac OS Travis workers

As python/pip have recently become unavailable on Travis' Mac OS workers,
we actively install python on them to work around this issue.
Change-Type: patch

TravisCI log says:
$ ./scripts/ci/install.sh -o $HOST_OS -r $TARGET_ARCH
Warning: python 2.7.14 is already installed
==> Downloading https://homebrew.bintray.com/bottles/ccache-3.3.4_1.sierra.bottle.tar.gz
==> Pouring ccache-3.3.4_1.sierra.bottle.tar.gz
==> Caveats
To install symlinks for compilers that will automatically use
ccache, prepend this directory to your PATH:
  /usr/local/opt/ccache/libexec
If this is an upgrade and you have previously added the symlinks to
your PATH, you may need to modify it to the path specified above so
it points to the current version.
NOTE: ccache can prevent some software from compiling.
ALSO NOTE: The brew command, by design, will never use ccache.
==> Summary
🍺  /usr/local/Cellar/ccache/3.3.4_1: 61 files, 415.2KB
==> Installing dependencies for jq: oniguruma
==> Installing jq dependency: oniguruma
==> Downloading https://homebrew.bintray.com/bottles/oniguruma-6.6.1.sierra.bottle.tar.gz
==> Pouring oniguruma-6.6.1.sierra.bottle.tar.gz
🍺  /usr/local/Cellar/oniguruma/6.6.1: 17 files, 1.3MB
==> Installing jq
==> Downloading https://homebrew.bintray.com/bottles/jq-1.5_2.sierra.bottle.tar.gz
==> Pouring jq-1.5_2.sierra.bottle.tar.gz
🍺  /usr/local/Cellar/jq/1.5_2: 18 files, 958KB
Dependency missing: pip
The command "./scripts/ci/install.sh -o $HOST_OS -r $TARGET_ARCH" failed and exited with 1 during .

:-(

It just occurred to me to check the Travis issue tracker - duh, I don't know why I didn't think of that before!!
https://github.com/travis-ci/travis-ci/issues/8835 says We don't support this setup, so you are responsible for providing pip which is a bit rubbish, given that it used to be included in the previous OSX xcode image, and https://blog.travis-ci.com/2017-11-21-xcode8-3-default-image-announce says absolutley nothing about pip being no longer being included by default :-/
One of the comments in https://github.com/travis-ci/travis-ci/issues/8829 suggests switching to an older Travis OSX image, and a different comment suggests using pip2 instead of just pip might work?

#1897 makes everything green again :grin:


Get-Teams Alias error message

Getting an error running the following command
Connect-MicrosoftTeams -AccountId<EMAIL_ADDRESS>Get-Team -Alias "TestTeam"
The doc clearly states that this parameter can be used: https://docs.microsoft.com/en-us/powershell/module/teams/get-team?view=teams-ps
However, I'm getting the following error message:
Get-Team : A parameter cannot be found that matches parameter name 'Alias'.
At line:1 char:10

Get-Team -Alias "Test-Team"

     ~~~~~~

CategoryInfo          : InvalidArgument: (:) [Get-Team], ParameterBindingException
FullyQualifiedErrorId : NamedParameterNotFound,Microsoft.TeamsCmdlets.PowerShell.Custom.GetTeam

@officedocsbot assign @yogkumgit

Hello @SveinMorten
Thanks for your feedback!
In version 1.0.0 of Teams Module, the parameter has been changed to MailNickName.
I created a Pull Request to modify the documentation based on this, and referenced to it here.
Thank you

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @SveinMorten Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@officedocsbot close


Add comma separation to community pledge

before thousands place
"103501" --> "103,501"

Maybe we can put both of these in same PR https://github.com/tallycash/tally.cash/issues/108


Error processing argument at index 0 conversion failure from at TypeError (native) at toggleFullScreen (Linux)

In Linux (Fedora 23 x64) when I click on the full screen menu

appears the popup with following error:
Uncaught Exception:
TypeError: Error processing argument at index 0, conversion failure from
    at TypeError (native)
    at toggleFullScreen (/home/joseluis/webtorrent-app/main/menu.js:30:18)
    at MenuItem.click (/home/joseluis/webtorrent-app/node_modules/electron-prebuilt/dist/resources/atom.asar/browser/api/lib/menu-item.js:69:18)
    at Function.delegate.executeCommand (/home/joseluis/webtorrent-app/node_modules/electron-prebuilt/dist/resources/atom.asar/browser/api/lib/menu.js:128:69)

Working on it.

Cool! :+1:


Restore makedepend capabilities for Windows and VMS

This got lost somehow.  The methods to do makedepend on Windows and
VMS are hard coded for cl (Windows) and CC/DECC (VMS), because that's
what we currently support natively.

Ping
I'd like to add that the VMS builds currently break, and this PR fixes the issue.

Does it look better now, @dot-asm?

Merged.  fe191b49b3eb1f14afa528b5f64a687488470daa and ea7df7ea449ef85a163fde917906e6e3da9388e5


Get last commit of any file

Hi, is it possible to do the effect of page.git.last_commit but with any file (not necessarily the one you are on)?
For example something like
{% for file in site.static_files %}

console.log("FILE {{file.path}} LAST COMMIT: {{file.git.last_commit.short_sha}}");

{% endfor %}

This works for files with front-matter but not images, XML files etc.

Hello! 👋
There isn't functionality to get git data for static files but that's a great idea and I think we should do it. I welcome any pull requests for this functionality!


⚠ Adam Brand Music has degraded performance

In d958adf, Adam Brand Music (https://adambrandmusic.com) experienced degraded performance:

HTTP code: 200
Response time: 8030 ms

Resolved: Adam Brand Music performance has improved in ff04f1f after 8 minutes.


NO-ISSUE: Make examples better reflect their domain and contain more focused code

In this PR I'm improving almost all examples to have a more descriptive README and package name. I also split the huge webapp example to make our builds faster, separating the serverless-workflow-editor-on-webapp example be built as part of partition1.txt.
In this PR:

Split examples/webapp into several different examples, to make our builds faster and to have the examples have less boilerplate code, allowing users to focus on the content that matters for each individual component usage inside webapps:

examples/bpmn-editor-classic-on-webapp
examples/dmn-editor-classic-on-webapp
examples/dmn-editor-on-webapp
examples/dmn-editor-standalone-on-webapp
examples/micro-frontends-multiplying-architecture-base64png-editor-on-webapp
examples/micro-frontends-multiplying-architecture-ping-pong-views-on-webapp
examples/micro-frontends-multiplying-architecture-todo-list-view-on-webapp
examples/serverless-workflow-editor-standalone-on-webapp

Renamed examples/commit-message-validation-service to examples/kie-sandbox-commit-message-validation-service
Renamed examples/jbpm-compact-architecture-example to examples/process-compact-architecture
Renamed example/drools-process-usertasks-quarkus-example to examples/process-user-tasks-subsystem
Prefixed examples/ping-pong* and examples/todo-list* packages with micro-frontends-multiplying-architecture, to make it clear that those examples are related to Multiplying Architecture. The "Micro-frontends" part is to not have them be confused with Compact Architecture, which is a completely unrelated term used to signify the embedding of Data-Index, Jobs Service, and Data-Audit on Process applications.
Revisited the READMEs of all examples
Added a very short README to the packages and examples folder.

I know this is quite a lot, but there's not much difference in content. I recommend checking out this branch and looking at each of the changed examples individually, they're all quite small and simple, so shouldn't be a big effort to do it.

@jomarko Sorry not sure if you already began reviewing it, but there's a new commit from @cimbalek here, fixing running the  containers of process-compact-architecture example on Ubuntu.

[ ] @kie-tools-examples/bpmn-editor-classic-on-webapp
[ ] @kie-tools-examples/dmn-editor-classic-on-webapp
[ ] @kie-tools-examples/dmn-editor-on-webapp
[ ] @kie-tools-examples/dmn-editor-standalone-on-webapp
[ ] @kie-tools-examples/kie-sandbox-commit-message-validation-service
[ ] @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor
[ ] @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-chrome-extension
[ ] @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-on-webapp
[ ] kie-tools-examples-micro-frontends-multiplying-architecture-base64png-editor-vscode-extension
[ ] @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view
[ ] @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view-in-angular
[ ] @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view-in-react
[ ] @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-views-on-webapp
[ ] @kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view
[ ] @kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view-on-webapp
[ ] kie-tools-examples-micro-frontends-multuplying-architecture-todo-list-view-vscode-extension
[ ] @kie-tools-examples/process-compact-architecture
[ ] @kie-tools-examples/process-user-tasks-subsystem
[ ] @kie-tools-examples/serverless-workflow-editor-standalone-on-webapp
[ ] @kie-tools-examples/sonataflow-greeting
[ ] @kie-tools-examples/uniforms-patternfly

@kie-tools-examples/bpmn-editor-classic-on-webapp feedback
All buttons are bound to DMN instead of BPMN

New empty file tries to create DMN file
Open file tries to open DMN files
Open Sample same as ^
Download downloaded file has dmn extension, not bpmn

opening the homescreen http://localhost:7771/ works

@kie-tools-examples/dmn-editor-classic-on-webapp feedback
🟢 passed
Code
Sidebar.tsx contains unused import NavItem

@kie-tools-examples/dmn-editor-on-webapp feedback
🟢 passed
Code
Sidebar.tsx contains unused import NavItem

@kie-tools-examples/kie-sandbox-commit-message-validation-service
Readme start command should contain the filter

@kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-chrome-extension
Start command misses filter.
No manual check done. Do you have a link for a public base64png file on github that I could try for verification?

@kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-on-webapp
Start command dos not contain filter -F part

kie-tools-examples-micro-frontends-multiplying-architecture-base64png-editor-vscode-extension
is not consistent in naming:

kie-tools-examples-micro-frontends-multiplying-architecture-base64png-editor-vscode-extension
vs @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-vscode-extension,

this is also incompatible with the build command [1] KIE_TOOLS_BUILD__buildExamples=true pnpm -F @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-vscode-extension^... build:dev
Probably also build:prod command should contain -F part.
🔴  build command [1] failed
│ > copyfiles -u 1 "src/**/*.{sass,scss,css}" dist/
└─ Running...
packages/vscode-extension build:dev$ rimraf dist && tsc -p tsconfig.json
│ src/workspace/VsCodeResourceContentServiceForWorkspaces.ts(33,27): error TS2307: Cannot find module 'isomorphic-git' or its corresponding type declarations.
│ src/workspace/VsCodeResourceContentServiceForWorkspaces.ts(81,10): error TS7006: Parameter 'p' implicitly has an 'any' type.
└─ Failed in 9.5s at /home/jomarko/kie-tools/packages/vscode-extension
/home/jomarko/kie-tools/packages/vscode-extension:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL<EMAIL_ADDRESS>build:dev: `rimraf dist && tsc -p tsconfig.json`
Exit status 2

@kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view
No manual checks done, README looks fine.

@kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view-in-angular
No manual checks done. From README it is not clear to me how to start the example.

@kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view-in-react
same as above ^

@kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-views-on-webapp
Start command in readme could include -F part.

@kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view
No checks done, no comments to code.

@kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view-on-webapp
Readme start command could include -F part probably

kie-tools-examples-micro-frontends-multuplying-architecture-todo-list-view-vscode-extension
Similar issues as base64png vscode extension package
│ [run-script-if] Finished 'pnpm build'
└─ Done in 9s
packages/editor build:dev$ rimraf dist && pnpm copy:css && tsc -p tsconfig.json
│ ><EMAIL_ADDRESS>copy:css /home/jomarko/kie-tools/packages/editor
│ > copyfiles -u 1 "src/**/*.{sass,scss,css}" dist/
└─ Done in 9.2s
packages/vscode-extension build:dev$ rimraf dist && tsc -p tsconfig.json
│ src/workspace/VsCodeResourceContentServiceForWorkspaces.ts(33,27): error TS2307: Cannot find module 'isomorphic-git' or its corresponding type declarations.
│ src/workspace/VsCodeResourceContentServiceForWorkspaces.ts(81,10): error TS7006: Parameter 'p' implicitly has an 'any' type.
└─ Failed in 6.1s at /home/jomarko/kie-tools/packages/vscode-extension
/home/jomarko/kie-tools/packages/vscode-extension:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL<EMAIL_ADDRESS>build:dev: `rimraf dist && tsc -p tsconfig.json`
Exit status 2

@kie-tools-examples/process-compact-architecture
🔴 I am not able to use startContainers script
Getting these exceptions:
process-compact-architecture-service  | -------------------------------------------------------
process-compact-architecture-service  | SQL State  : 42P07
process-compact-architecture-service  | Error Code : 0
process-compact-architecture-service  | Message    : ERROR: relation "process_instances" already exists
process-compact-architecture-service  | Location   : kie-flyway/db/persistence-jdbc/postgresql/V1.35.0__create_runtime_PostgreSQL.sql (/home/jboss/file:/home/jboss/lib/main/org.kie.kie-addons-persistence-jdbc-999-20241016-SNAPSHOT.jar!/kie-flyway/db/persistence-jdbc/postgresql/V1.35.0__create_runtime_PostgreSQL.sql)
process-compact-architecture-service  | Line       : 21
process-compact-architecture-service  | Statement  : --
process-compact-architecture-service  | -- Licensed to the Apache Software Foundation (ASF) under one
process-compact-architecture-service  | -- or more contributor license agreements.  See the NOTICE file
process-compact-architecture-service  | -- distributed with this work for additional information
process-compact-architecture-service  | -- regarding copyright ownership.  The ASF licenses this file
process-compact-architecture-service  | -- to you under the Apache License, Version 2.0 (the
process-compact-architecture-service  | -- "License"); you may not use this file except in compliance
process-compact-architecture-service  | -- with the License.  You may obtain a copy of the License at
process-compact-architecture-service  | --
process-compact-architecture-service  | --   http://www.apache.org/licenses/LICENSE-2.0
process-compact-architecture-service  | --
process-compact-architecture-service  | -- Unless required by applicable law or agreed to in writing,
process-compact-architecture-service  | -- software distributed under the License is distributed on an
process-compact-architecture-service  | -- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
process-compact-architecture-service  | -- KIND, either express or implied.  See the License for the
process-compact-architecture-service  | -- specific language governing permissions and limitations
process-compact-architecture-service  | -- under the License.
process-compact-architecture-service  | --
process-compact-architecture-service  |
process-compact-architecture-service  | -- To be used with kie-addons-quarkus-persistence-jdbc for Quarkus or kie-addons-springboot-persistence-jdbc for SpringBoot
process-compact-architecture-service  | CREATE TABLE process_instances
process-compact-architecture-service  | (
process-compact-architecture-service  |     id              character(36)     NOT NULL,
process-compact-architecture-service  |     payload         bytea             NOT NULL,
process-compact-architecture-service  |     process_id      character varying NOT NULL,
process-compact-architecture-service  |     version         bigint,
process-compact-architecture-service  |     process_version character varying,
process-compact-architecture-service  |     CONSTRAINT process_instances_pkey PRIMARY KEY (id)
process-compact-architecture-service  | )
process-compact-architecture-service  |
process-compact-architecture-service  |         at org.flywaydb.core.internal.sqlscript.DefaultSqlScriptExecutor.handleException(DefaultSqlScriptExecutor.java:267)
process-compact-architecture-service  |         at org.flywaydb.core.internal.sqlscript.DefaultSqlScriptExecutor.executeStatement(DefaultSqlScriptExecutor.java:222)
process-compact-architecture-service  |         at org.flywaydb.core.internal.sqlscript.DefaultSqlScriptExecutor.execute(DefaultSqlScriptExecutor.java:126)
process-compact-architecture-service  |         at org.flywaydb.core.internal.resolver.sql.SqlMigrationExecutor.executeOnce(SqlMigrationExecutor.java:68)
process-compact-architecture-service  |         at org.flywaydb.core.internal.resolver.sql.SqlMigrationExecutor.lambda$execute$0(SqlMigrationExecutor.java:57)
process-compact-architecture-service  |         at org.flywaydb.core.internal.database.DefaultExecutionStrategy.execute(DefaultExecutionStrategy.java:27)
process-compact-architecture-service  |         at org.flywaydb.core.internal.resolver.sql.SqlMigrationExecutor.execute(SqlMigrationExecutor.java:56)
process-compact-architecture-service  |         at org.flywaydb.core.internal.command.DbMigrate.doMigrateGroup(DbMigrate.java:374)
process-compact-architecture-service  |         ... 36 more
process-compact-architecture-service  | Caused by: org.postgresql.util.PSQLException: ERROR: relation "process_instances" already exists
process-compact-architecture-service  |         at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2725)
process-compact-architecture-service  |         at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2412)
process-compact-architecture-service  |         at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:371)
process-compact-architecture-service  |         at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:502)
process-compact-architecture-service  |         at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:419)
process-compact-architecture-service  |         at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:341)
process-compact-architecture-service  |         at org.postgresql.jdbc.PgStatement.executeCachedSql(PgStatement.java:326)
process-compact-architecture-service  |         at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:302)
process-compact-architecture-service  |         at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:297)
process-compact-architecture-service  |         at io.agroal.pool.wrapper.StatementWrapper.execute(StatementWrapper.java:220)
process-compact-architecture-service  |         at org.flywaydb.core.internal.jdbc.JdbcTemplate.executeStatement(JdbcTemplate.java:201)
process-compact-architecture-service  |         at org.flywaydb.core.internal.sqlscript.ParsedSqlStatement.execute(ParsedSqlStatement.java:95)
process-compact-architecture-service  |         at org.flywaydb.core.internal.sqlscript.DefaultSqlScriptExecutor.executeStatement(DefaultSqlScriptExecutor.java:210)
process-compact-architecture-service  |         ... 42 more
process-compact-architecture-service  |
process-compact-architecture-service exited with code 1

Sounds to me like some additional cleanup of local environment is needed before I start this example, if that is the reason I think we need to share such information in README.
I did:

KIE_TOOLS_BUILD__buildExamples=true pnpm -F @kie-tools-examples/process-compact-architecture^... build:dev
cd examples/process-compact-architecture
mvn clean package -Pcontainer
cd docker-compose
sh startContainers.sh full

mvn clean package quarkus:dev seems to work fine 🟢

@kie-tools-examples/process-user-tasks-subsystem
🔴 there is a compilation error
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/jomarko/kie-tools/examples/process-user-tasks-subsystem/src/test/java/org/acme/travels/quarkus/ApprovalsProcessTest.java:[28,48] package org.jbpm.process.instance.impl.humantask does not exist
[ERROR] /home/jomarko/kie-tools/examples/process-user-tasks-subsystem/src/test/java/org/acme/travels/quarkus/ApprovalsProcessTest.java:[29,55] package org.jbpm.process.instance.impl.humantask.phases does not exist
[ERROR] /home/jomarko/kie-tools/examples/process-user-tasks-subsystem/src/test/java/org/acme/travels/quarkus/ApprovalsProcessTest.java:[30,47] package org.jbpm.process.instance.impl.workitem does not exist

@kie-tools-examples/serverless-workflow-editor-standalone-on-webapp
Manual check passed, start command could maybe include -F part.

General comments:

All commands in READMEs assume you're in the example's folder.
Bootstrapping the repo with pnpm bootstrap is always necessary.

@kie-tools-examples/dmn-editor-classic-on-webapp
✅ Fixed

@kie-tools-examples/dmn-editor-on-webapp
✅ Fixed

@kie-tools-examples/dmn-editor-on-webapp
✅ Fixed

@kie-tools-examples/dmn-editor-standalone-on-webapp
🟡 Updated the port. Will investigate the failures.

@kie-tools-examples/kie-sandbox-commit-message-validation-service
✅ There are no build instructions necessary here.. Simply "pnpm start" suffices.

@kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor
✅ True. This is not runnable. Mentioned in the README.

@kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-chrome-extension
✅ There are some in this repo! :) Or you can use the Base64 Editor VS Code Extension to create some based on PNG files.

@kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-on-webapp
✅ Nothing done.

kie-tools-examples-micro-frontends-multiplying-architecture-base64png-editor-vscode-extension
✅ Not having the scope (@kie-tools) part in the name of the package is a requirement from the VS Code Marketplace. Fixed the build command. Build failed for you because you didn't bootstrap first, I guess?

@kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view
✅ OK

@kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view-in-angular
✅ This is not runnable. I made it clear on the README now.

@kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view-in-react
✅ Same as above.

@kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-views-on-webapp
✅ OK

@kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view
🟡 Not sure I understand your feedback here...

@kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view-on-webapp
✅ OK

kie-tools-examples-micro-frontends-multuplying-architecture-todo-list-view-vscode-extension
✅ Please see the other VS Code extension example's comment from my end as they apply here too.

@kie-tools-examples/process-compact-architecture
✅ True... this is expected, and we need to upgrade the Kogito version of the repo. I'll do it soon in a separate PR.

@kie-tools-examples/process-user-tasks-subsystem
🟡 Weird... Will investigate. Thanks!

@kie-tools-examples/serverless-workflow-editor-standalone-on-webapp
✅ OK

@kie-tools-examples/sonataflow-greeting
✅ Out of scope of this PR.

@kie-tools-examples/uniforms-patternfly
✅ Out of scope of this PR.

@kie-tools-examples/process-user-tasks-subsystem
✅ Removed the test... The example compiles normally now. We currently don't have tests for our examples, but I guess if we want that, we need a new "examples-tests" top-level directory to host them.

@kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view
✅ As we discussed, this is ok.

@kie-tools-examples/dmn-editor-standalone-on-webapp
✅ Took me a while to read the comment, but I finally did:

// The paths are important here! Since path2/loan-pre-qualification.dmn is in a
// different parent path than the main content (path1/can-drive.dmn), it won't be availabe
// to be used as an included model.

I added a comment to the specific line pointing to the main comment:
["path2/loan-pre-qualification.dmn", { contentType: "text", content: loadFile("loan-pre-qualification.dmn") }], // Won't be available! Read comment above.

Hope it's in good shape now @jomarko. Thanks!

@jomarko Thanks! Comments addressed in bb960bd.


environment aware arg decorator

It would be cool to make it easier to set a value either through the command line or through the environment, so something like:
# foo.py

class Default(Command):
    @envarg("--foo", dest="foo", envsrc="FOO")
    def handle(self, foo):
        self.output.out(foo)

Could work like this:
$ python foo.py --foo=1

or like this:
$ FOO=2 python foo.py

and it would do all the requirement checking and things like that, so:
$ python foo.py

would fail because --foo wasn't passed in.
I might not even need something like @envarg, it might be good enough to just pass in envsrc into the @arg decorator

I think I could also add a prompt param that if set to to True would prompt for the value also, so the order of operation would be:

passed in via CLI
environment using environ_key or environ_name param
default value if present
prompt if value is required and prompt is True

Thinking about this a little more, for environment variables:
@arg("--foo", "-f", "$FOO")

Which basically says you can get the argument from the --foo or -f flags or the FOO environment variable.
And for the prompt, I think maybe something like this?
@arg("--foo", missing=prompt)

Where the missing argument can take a callback or something. Likewise, maybe:
@arg("--foo", action="prompt")

Would say that the foo value should prompt for a value? Or maybe the action should be prompt_if_missing or something like that.


Minor doc fix for python install script

I found a super-minor issue in the python.md when reading it to setup a dev environment.  In a previous change, the line after the RUN apt-get update && bash /tmp/library-scripts/python-debian.sh "3.8.3" "${PYTHON_PATH}" "${PIPX_HOME}" \  was removed, but the \ was left.  If someone is copy-pasting to play with it, they'll get an error because of it.

@CliffJumper Good eye, thanks for contributing.


punish repetitions & break if END_OF_TEXT & decouple prompts from chat script

@saharNooby, would you like to review this PR when you are available?

Hi! Thanks for adding elaborate prompts and repetition penalty feature. After comments above are resolved, the PR would look good to me :)

After comments above are resolved, the PR would look good to me :)

I resolve all comments and thanks to explanation from @BlinkDL.

@L-M-Sherlock Before I merge: JSON prompts became significantly smaller. For example, there was many example question-answer pairs in QA prompt, and now there is none. Is this intended?

Before I merge: JSON prompts became significantly smaller. For example, there was many example question-answer pairs in QA prompt, and now there is none. Is this intended?

I remove two English prompts because I don't know how to describe them and English-3.py has 4 names in the conversations.


locationd: Add camera-IMU cross-checks

Problem: Erroneous gyro measurements cause a degradation in the localizer, which adversely affects driving. We should detect the bad measurements, do not update them to the filter, and finally add an alert.

To Do:

[x]  Crosscheck gyro and cam odo rot to each other
[x] Fix the decays to ensure sane alert duration
[x] Run offline on a large seglist and compute TP/FP

@adeebshihadeh I think we can have an alert (I checked on 50k segs, without any FP). But we could also maybe add without alert on inputsOK, track closely offline and then add it in the next release. Don't have strong opinions on it, but it should have the alert eventually for sure.

excessiveResets triggered localizerMalfunction alert, but did not do anything. In this PR, that alert has been repurposed to be the catch-all localizer alert, and inputsOK triggers it now.


Scrollable

hello,
first thank you so much ,
I m trying to control the list view and the hight of the list but I could not find the way to do it
any example please ?

thanks in advanced

I have found the solution


AttributeError: 'InvalidURL' object has no attribute 'reason

Describe the bug
When try to retrieve tables with --skip-urlencode   getting following error:
Traceback (most recent call last):
  File "C:\Program Files\Python310\lib\site-packages\ghauri-1.2.1-py3.10.egg\ghauri\core\inject.py", line 87, in inject_expression
    attack = request.perform(
  File "C:\Program Files\Python310\lib\site-packages\ghauri-1.2.1-py3.10.egg\ghauri\core\request.py", line 180, in perform
    raise e
  File "C:\Program Files\Python310\lib\site-packages\ghauri-1.2.1-py3.10.egg\ghauri\core\request.py", line 135, in perform
    response = opener.open(request, timeout=timeout)
  File "C:\Program Files\Python310\lib\urllib\request.py", line 519, in open
    response = self._open(req, data)
  File "C:\Program Files\Python310\lib\urllib\request.py", line 536, in _open
    result = self._call_chain(self.handle_open, protocol, protocol +
  File "C:\Program Files\Python310\lib\urllib\request.py", line 496, in _call_chain
    result = func(*args)
  File "C:\Program Files\Python310\lib\urllib\request.py", line 1377, in http_open
    return self.do_open(http.client.HTTPConnection, req)
  File "C:\Program Files\Python310\lib\urllib\request.py", line 1348, in do_open
    h.request(req.get_method(), req.selector, req.data, headers,
  File "C:\Program Files\Python310\lib\http\client.py", line 1276, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "C:\Program Files\Python310\lib\http\client.py", line 1287, in _send_request
    self.putrequest(method, url, **skips)
  File "C:\Program Files\Python310\lib\http\client.py", line 1121, in putrequest
    self._validate_path(url)
  File "C:\Program Files\Python310\lib\http\client.py", line 1221, in _validate_path
    raise InvalidURL(f"URL can't contain control characters. {url!r} "
http.client.InvalidURL: URL can't contain control characters. '/load/(SELECT(0)FROM(SELECT(IF(LENGTH(LENGTH((/*!SELECT*//**_**/COUNT(*)#/**_**/\nFROM' (found at least '\n')

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Program Files\Python310\Scripts\ghauri-script.py", line 33, in <module>
    sys.exit(load_entry_point('ghauri==1.2.1', 'console_scripts', 'ghauri')())
  File "C:\Program Files\Python310\lib\site-packages\ghauri-1.2.1-py3.10.egg\ghauri\scripts\ghauri.py", line 514, in main
    target.extract_tables(
  File "C:\Program Files\Python310\lib\site-packages\ghauri-1.2.1-py3.10.egg\ghauri\ghauri.py", line 735, in extract_tables
    response = target_adv.fetch_tables(
  File "C:\Program Files\Python310\lib\site-packages\ghauri-1.2.1-py3.10.egg\ghauri\extractor\advance.py", line 423, in fetch_tables
    retval = self.__execute_expression(
  File "C:\Program Files\Python310\lib\site-packages\ghauri-1.2.1-py3.10.egg\ghauri\extractor\advance.py", line 82, in __execute_expression
    retval = ghauri_extractor.fetch_characters(
  File "C:\Program Files\Python310\lib\site-packages\ghauri-1.2.1-py3.10.egg\ghauri\core\extract.py", line 2015, in fetch_characters
    length = self.fetch_length(
  File "C:\Program Files\Python310\lib\site-packages\ghauri-1.2.1-py3.10.egg\ghauri\core\extract.py", line 1515, in fetch_length
    noc, _ = self.fetch_noc(
  File "C:\Program Files\Python310\lib\site-packages\ghauri-1.2.1-py3.10.egg\ghauri\core\extract.py", line 1424, in fetch_noc
    attack = inject_expression(
  File "C:\Program Files\Python310\lib\site-packages\ghauri-1.2.1-py3.10.egg\ghauri\core\inject.py", line 141, in inject_expression
    logger.critical(f"{e.reason}. Ghauri is going to retry..")
AttributeError: 'InvalidURL' object has no attribute 'reason'

To Reproduce
Steps to reproduce the behavior:
ghauri -u "http://***.bg/load/*" -D bu*** --tables --skip-urlencode
you got the website in your email
Expected behavior
To retrieve tables without error
Screenshots

Desktop (please complete the following information):

OS: Windows
Ghauri version which is causing the error (should be latest) 1.2.3
Type of SQL injection which cause the error: time
Phase where error occur: table

i tried to reproduce with latest ghauri version but for me it works fine no errors: if you are still facing the issue you can email me your target on<EMAIL_ADDRESS>if its okay sharing the target otherwise i can't help as i cannot reproduce so closing this issue as invalid.

On new version wont show error but would not match any timebased at all

this is fixed in upcoming release. the issue was with your target some sort of access error. it detects the vuln fine now.


rebranch, Windows: build fails with MSVC internal compiler error

See https://ci-external.swift.org/view/all/job/oss-swift-r-windows-x86_64-vs2019/1648/
C:\Users\swift-ci\jenkins\workspace\oss-swift-r-windows-x86_64-vs2019\swift\lib\StaticMirror\ObjectFileContext.cpp(561) : fatal error C1001: Internal compiler error.
(compiler file 'd:\a01\_work\3\s\src\vctools\Compiler\Utc\src\p2\main.c', line 213)
 To work around this problem, try simplifying or changing the program near the locations listed above.
If possible please provide a repro here: https://developercommunity.visualstudio.com/
Please choose the Technical Support command on the Visual C++
 Help menu, or open the Technical Support help file for more information
  cl!RaiseException()+0x69
  cl!RaiseException()+0x69
  cl!InvokeCompilerPassW()+0x11c5af
  cl!InvokeCompilerPassW()+0x17aa3b

Are we able to resolve this issue by updating to VS2022?

Okay, it seems to be related to a type construction:
auto context = new reflection::ReflectionContext<External<NoObjCInterop<RuntimeTarget<4>>>>(nullptr);

Are we able to resolve this issue by updating to VS2022?

Yes, I believe that VS2022 just happens to not hit the issue.

Ah so, doing a bit of sleuthing (thanks @al45tair!).
> git merge-base github/main HEAD
cc70677303ad05ddf45358173785fe9ae7d3582a

This allows us to do the following:
> git diff cc70677303ad05ddf45358173785fe9ae7d3582a..

This immediately shows what is likely the cause of this - the language mode was changed from C++14 to C++17, which has semantic changes.  I believe that TaggedUnion is no longer correct and will need to be adjusted.

Talking to some folks here, and looking at the code, we think the code is correct (both for TaggedUnion and TypeLookUpOrError) and that this is just an MSVC bug. @compnerd tells me that updating to VS2022 did fix it, which is good. If we can't do that, then I suspect that adding some extra constructors to TaggedUnion might allow us to work around the problem, though they aren't actually needed.

This has been fixed thanks to @al45tair.


Feature request: Reader mode

Displaying only the text legibly.
Thanks.

Thanks for the feature request. It will be a very nice feature to have.
Friendly reminder that we are a small team with a big backlog of features. We try to prioritize all our work based on our users' needs and the impact of each feature. We keep issues open so other users can show interest too, so thanks again for sharing it here.

I'm also interested in this feature.
Love your browser but I keep fennec too on my phone for reading articles.

Created an internal task to track this issue: https://app.asana.com/0/0/1199514257586723/f

Created an internal task to track this issue: https://app.asana.com/0/0/1199514257586723/f

Hello there. We have been received similar feedback from users using our embedded feedback form within the app. I've also shared this with others whe I created a task som time ago. However, no plans yet to support this.
Everyone can continue sending feedback using the feedback option inside settings (from our browser) or just using the web form. We process that feedback internally every day and scope projects when we see enough activity.
Closing this issue as it's already tracked internally. Thanks.
Check "share feedback" guidelines here (https://github.com/duckduckgo/Android/blob/develop/CONTRIBUTING.md#share-feedback).

Hi,
I don’t mean to be redundant. Is there any progress on the inclusion of a reader in DDG’s mobile browser?
If it isn’t something that’s easy to build in, especially keeping privacy in mind, couldn’t a !bang be used that could move the content you’re looking at to a reader service Online?
One of the best DDG features is !bang. Is there a way to use a reader service that already exists that would move the content being viewed to a reader or text-only service?
Thank you.


Create rule to exclude images from siteimprove crawl

https://equinor.slack.com/archives/C01MU3H6G0Y/p1685464669812009

Rule has been created to all sites in siteimprove @meols


PHP namespaced classes are not analyzed

The following class is not included in the report.
<?php

declare(strict_types=1);

namespace Kenjis\Test;

class Test
{
    public function test()
    {
    }
}

The following class is included.
<?php

declare(strict_types=1);

class Test
{
    public function test()
    {
    }
}

Thank you for reporting the issue.
We were able to reproduce the issue and have fixed it.
Very very thanks.

Thank you for reporting the issue.
We were able to reproduce the issue and have fixed it.
Very very thanks.

It worked! Thanks.

It worked! Thanks.


cygwin环境安装sumory/lor成功后报thread.exdata找不到

有人在cygwin环境安装lor成功过吗？我安装后运行lord -h 报错"nginx: [error] failed to run the Lua code for coroutine.wrap(): 2: coroutine.wrap:2: module 'thread.exdata' not found"，LUAJIT_LIB和LUAJIT_INC已经指向了openresty自带的luajit ，openresty我是用openresty-<IP_ADDRESS>.tar.gz 源码安装的，通过修改几个makefile已经安装上了，resty -v 和nginx -v都运行正常

I resolved this problem by:

use cygwin insall setup-x86.exe to uninstall key  "lua" and "luajit" all installed compoments at full mode.
recompile and make install the lastly version openresty<IP_ADDRESS> and lor0.3.4

@jordon1899 Thank you for adding the solution to this issue!


GROUP BY support

Please correct me if I'm misled, but it seems that Diesel currently doesn't support GROUP BY statements. #89 sounds like we can already call .group_by as of today, but there's actually no such method. Am I correct?
Another issue I encountered was that I can't write donate::table.select((donate::name, diesel::expression::sum(donate::amount))). It type-errors:
src/eventer.rs:189:31: 189:37 error: the trait `diesel::expression::SelectableExpression<eventer::donate::table, _>` is not implemented for the type `(eventer::donate::columns::name, diesel::expression::functions::aggregate_folding::Sum<eventer::donate::columns::amount>)` [E0277]

So I ended up working around the two issues above by using sql, such like:
donate::table.select((donate::name, sql::<Text>("sum(amount) AS sum")))
             .filter(sql("TRUE GROUP BY name"))
             .order(sql::<Text>("sum").desc())
             .load(&*db).unwrap();

One more thing: I had to use sql::<Text>("sum") because without ::<Text>, type inference fails. Though Text isn't exactly sane in this case, I'd say...
Any ideas? Thanks in advance for your help!

You are correct, we are missing support for group_by (and more generally, we are also missing the ability to select multiple aggregate expressions even if it's valid. Ref #3). This is something I'd like to add support for in the future. We haven't gotten to it yet, as the features that we're targeting for 1.0 are features that are likely to require breaking changes to our existing API (0.6 will bring a reworking of associations, and is currently planned to be the last release before 1.0).
For the most part, your workaround appears to be the way to go about doing this in the short term. The sql function will never infer the type, and will always need it to be specified. Text isn't correct here though, BigInteger is.
In the short term, I think it's fine for us to add a group_by function (not public API, as it will change when we properly support it) that takes a column. Because .filter(sql("TRUE GROUP BY ...")) is silly and you shouldn't have to do that.

@barosl I've pushed up 6df20de which adds a group_by method. This is not part of the public API, and has only the most basic of tests for it. This method will almost certainly have breaking changes when we properly support the group by clause publicly, but I wanted to make sure you had a reasonable workaround. With this, your workaround can become:
donate::table.select((donate::name, sql::<BigInteger>("sum(amount) AS sum")))
             .group_by(donate::name)
             .order(sql::<BigInteger>("sum").desc())
             .load(&*db).unwrap();

which is a little more sane. I'm not going to ship a new version for this change, as it doesn't affect the public API. That means you'll have to point at git for now, but next time I have a bug fix to use as an excuse I'll ship 0.5.2 which will include that change.
This "fix" does not close this issue, nor does it constitute proper group by support, it's simply a crappy workaround that is slightly less crapy than filter(sql("TRUE GROUP BY ..."))

Note for anybody reading this because they're looking for issues to work on:
Before we can add proper support for group by, we almost certainly need to resolve #3.

Ah, thanks for the explanation!
I think I can live with .filter(sql("TRUE GROUP BY ...")) for now, because although it's a bit silly as you said, there seems to be no other "better" workarounds out there. I was a bit worried if there were better alternatives, but given your explanation, I'm fine with using the best workaround. I can perfectly wait until you guys introduce a true group_by function.
The reason why I used .order(sql::<Text>("sum")) was that whatever I put there, it compiled and worked. So I put the one that looked the most "generic" (Text). But thinking again, it seems that the reason why it compiled was that .order() requires its parameter to be orderable, and Text happens to be SqlOrd. Is my assumption correct?

because although it's a bit silly as you said, there seems to be no other "better" workarounds out there

I just pushed a better workaround. :P Still not great, but less silly at least.

and Text happens to be SqlOrd. Is my assumption correct?

SqlOrd actually is only for functions like max. .order doesn't care about the type that you pass it. My comment about the type was for your select clause, not your order clause.

I just pushed a better workaround.

Oh, I thought the added group_by was for internal use because you said it was not part of the public API. By "public API" did you mean the method was #[doc(hidden)]?

My comment about the type was for your select clause, not your order clause.

Oops, it seems that the pasted code above is different from my production code. I actually did use BigInteger correctly in the select clause (it doesn't even compile if I use other types, actually), so what caused me confused is what to use in the order clause. I guess, even though .order doesn't care about types particularly, using BigInteger in there too is "correct". Am I right?

Oh, I thought the added group_by was for internal use because you said it was not part of the public API. By "public API" did you mean the method was #[doc(hidden)]?

Correct

I guess, even though .order doesn't care about types particularly, using BigInteger in there too is "correct"

Also correct

Awesome! Thanks for the explanation.

Does this mean it's not possible to group by a non-fkey column?
E.g. select version, count(*) from clients group by version order by version

Thanks, @barosl for the workaround. And just adding I can't wait for the group_by support! :tada:

How do  i do something like :    group by table.column, table2.column ?

How about the HAVING clause? It looks like it still requires the hacky filter(sql("TRUE GROUP BY ... HAVING ...")).

Things left to do after merging #2251:
Needed for 2.0:

[ ] Figure out support for group by in BoxableExpression
[ ] Figure out support for group by in BoxedSelectStatement
[ ] Expose GroupByDsl via public API

After 2.0/open for contributions:

[ ] Support for group by clauses with more than one column
[ ] HAVING clauses

So ... how will the transition to 2.0 play out?

@kivo360 From the perspective of the diesel team the transition is as simple as: We release 2.0 as soon as it is finished. There will be a changelog stating what has changed in an incompatible way compared to the last 1.x release and everything else is up to the user.

I see there's a grouped_by feature added now, but it seems like it loads all the data from the DB. I want to select one column from a parent table along with the number of records in a child table belonging to each record in the parent table. Is there a way to do just that, and not load the content of all the other columns of the child table (they're big)?

@yujiri8 Our issue tracker is not a place to ask questions. This is especially true for existing tracking issues for new features. Please use our forum or the gitter channel for such questions.


NPM Caching Issue

There might be an issue with the NPM Caching Documentation. The default path for the NPM Cache is different than the one we're pointing the Cache Task to.
This answer on SO explains everything: https://stackoverflow.com/a/64690902/2632991

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77c20289-dab2-7a6e-4f63-4b30eaff2c71
Version Independent ID: d75cc196-90c1-8291-9907-ff405bde4edf
Content: Pipeline caching - Azure Pipelines
Content Source: docs/pipelines/release/caching.md
Product: devops
Technology: devops-cicd-release
GitHub Login: @ramiMSFT
Microsoft Alias: rabououn

@eluchsinger Thank you for your feedback. npm ci deletes the node_modules folder to ensure that a consistent, repeatable set of modules is used, you should avoid caching node_modules when calling npm ci. Please refer to the tip at the end of the section.

@ramiMSFT  no one is caching node_modules... it's the folder .npm that's being cached. In fact, it's the same caching behavior that's described in the documentation.

@eluchsinger Your query was about the npm cache path. When npm is running, the config parameters are placed into the env with the npm_ prefix. npm_config_cache is the cache location env variable. See the npm docs here for more details.

Configuration parameters are put in the environment with the npm_config_ prefix. For instance, you can view the effective root config by checking the npm_config_root environment variable.

You can also set your own environment variable using export and unset to remove it.

@ramiMSFT
I am not asking about the NPM Cache path. I'm trying to tell you that the docs seem to be wrong. I don't need to export any location variables.
What I've found is that when you run the Cache Task as it's described in the docs in an Ubuntu Agent, the post-build step will fail.
It will fail because the NPM Task will cache the .npm folder in the default folder /home/vsts/.npm. But the docs tell the Cache Task that the folder is in a custom folder instead: $(Pipeline.Workspace)/.npm. So then in the Post Build Step, the Caching Task will try to cache a folder in $(Pipeline.Workspace)/.npm that does not exist.
Instead, what you have to do is tell NPM that it should cache everything in the same custom path that the Cache task is looking for: npm ci --cache $(NPM_CACHE_FOLDER).
The docs should be updated to fix the npm cache path.


[RSDK-7442] Update deps with moderate severity security issues

https://github.com/viamrobotics/viam-camera-realsense/pull/33
https://github.com/viamrobotics/viam-camera-realsense/pull/32
https://github.com/viamrobotics/viam-camera-realsense/pull/21
Dependabot has marked multiple dependencies in our Go integration test module as having "moderate severity" security issues. This consolidates all the suggested changes into one PR. Verified that the integration tests still work on linux/arm64
rawr-ubuntu@rawr-ubuntu:~/Projects/viam-camera-realsense$ /home/rawr-ubuntu/Projects/viam-camera-realsense/packaging/appimages/deploy/realsense-integration-tests-latest-aarch64.AppImage -module /home/rawr-ubuntu/Projects/viam-camera-realsense/packaging/appimages/deploy/viam-camera-realsense-latest-aarch64.AppImage
VIAM REALSENSE MODULE INTEGRATION TESTS
Tests defined at https://github.com/viamrobotics/viam-camera-realsense/tree/main/integration/tests
checking if file exists at "/home/rawr-ubuntu/Projects/viam-camera-realsense/packaging/appimages/deploy/viam-camera-realsense-latest-aarch64.AppImage"
Starting the tests...
PASS
all tests succeeded!

@hexbabe Please confirm tests still pass on all other supported platforms. Once you do you can merge it

@hexbabe Please confirm tests still pass on all other supported platforms. Once you do you can merge it

Docker for Mac worked for building a linux/amd64 appimage for these integration tests! Tested the amd64 appimage works on the UP board
VIAM REALSENSE MODULE INTEGRATION TESTS
Tests defined at https://github.com/viamrobotics/viam-camera-realsense/tree/main/integration/tests
checking if file exists at "./viam-camera-realsense-latest-x86_64.AppImage"
Starting the tests...
PASS
all tests succeeded!```


Add HaveIBeenPwned plugin

The plugin's readme barely gives any idea about what it is for. Users' should shouldn't to google to figure out what's "HIBP API". Also it should have proper installation and usage instructions.
The plugin doesn't have tests.
Why are there empty templates when the controller returns JSON?
Where can one find info about the service used in HIBPComponent? haveibeenpwned.com's API is pretty different https://haveibeenpwned.com/API/v2.

TLDR; In it's current state your plugins does not meet the standards we expect to be featured on this list.

The plugin isn't even installable using composer. Please read our Contribution Guidles
There's lots of do here. Please re-open the PR after the various issues are addressed.

That's odd? I'm pretty sure I did all of that? (might be that it's still on my old workstation and forgot to push it).
Will re-open the PR after the repo meets the QG.


Add script to generate subsets of scatter intervals from master list

Since Cromwell/WDL scatter-gather doesn't allow dynamic apportioning of intervals, we produce subsetted scatter intervals lists to scatter a fixed amount of ways.
We offer such a set of intervals lists (50-ways) for human WGS against hg38, but we and others need to be able to quickly generate sets for other references, datatypes or of different sizes.

This is ready for review. There's only one page of actual code (in create_scatter_intervals.py); the rest are demo files showing example input and expected outputs for the usage command.


Add protected automated deployment to environments

chore: Remove kubeconfig dependency (@gytis-ivaskevicius commit)
chore: Add workflow for protected auto deployments (extra configuration done in repo > settings > environments)
Context
Reason for the change? If an issue exists, reference it here using a keyword
Proposed Solution
Important Changes Introduced

Successful deploy to ops-preview-1@us-east-1: https://github.com/input-output-hk/cardano-js-sdk/actions/runs/10089733209/job/27897743167
I am leaving the push: trigger to make it easy for anyone testing to do that. Once approved, I am going to take out the push: trigger and the ops-preview-1@us-east-1 default value in instances of {{ inputs.environment || 'ops-preview-1@us-east-1' }}.
I would also create new environments for the repository and set protection rules as appropriate; to be discussed with @bernokl.
Cc: @michalrus @gytis-ivaskevicius

Looks good, has this been tested?

Yes, it works.


Save new package JSON and install dependencies

closes #8 and #9

@hidnasio I included the npm fallback based on yarn's lock file


Proposal errorOccurredDuringReconcile because of failed RBAC reconciliation

Because the last example-test failed, I found this issue. Looking back, in the last 100 example-test , I found that this problem occurred twice.
Name:         dissolve-network-sample
Namespace:
Labels:       bestchains.proposal.type=DissolveNetworkProposal
Annotations:  <none>
API Version:  ibp.com/v1beta1
Kind:         Proposal
...
Spec:
  Deprecated:  false
  Dissolve Network:
    Name:                  network-sample
  End At:                  2023-02-15T04:13:38Z
  Federation:              federation-sample
  Initiator Organization:  org1
  Policy:                  All
  Start At:                2023-02-14T04:13:38Z
Status:
  Conditions:
    Last Transition Time:  2023-02-14T04:13:39Z
    Message:               Success
    Reason:                Success
    Status:                True
    Type:                  Succeeded
    Last Transition Time:  2023-02-14T04:13:39Z
    Message:               failed to reconcile managers: failed RBAC reconciliation: failed sync rbac: Operation cannot be fulfilled on clusterroles.rbac.authorization.k8s.io "org1-blockchain:admin-clusterrole": the object has been modified; please apply your changes to the latest version and try again
    Reason:                errorOccurredDuringReconcile
    Status:                True
    Type:                  Error
  Phase:                   Finished
  Votes:
    Decision:     true
    Description:
    Name:         vote-org1-dissolve-network-sample
    Namespace:    org1
    Organization:
      Name:       org1
      Namespace:  org1
    Phase:        Voted
    Vote Time:    2023-02-14T04:13:39Z
    Decision:     true
    Description:
    Name:         vote-org2-dissolve-network-sample
    Namespace:    org2
    Organization:
      Name:       org2
      Namespace:  org2
    Phase:        Voted
    Vote Time:    2023-02-14T04:13:39Z
Events:           <none>

https://github.com/bestchains/fabric-operator/actions/runs/4170282714/jobs/7219140521#step:5:237

Once again in #134
logs in https://github.com/bestchains/fabric-operator/actions/runs/4210030445/jobs/7307448827#step:6:262

Once again in #131
logs in https://github.com/bestchains/fabric-operator/actions/runs/4210087123/jobs/7307552921#step:6:262


🐛 Bug Report: stonith404/pingvin-share:latest container does not disable registration anymore

👟 Reproduction steps
I'm running the latest Docker container with this docker-compose:
services:
  pingvin-share:
    container_name: pingvin
    image: stonith404/pingvin-share:latest
    restart: unless-stopped
    environment:
      - TRUST_PROXY=true # Set to true if a reverse proxy is in front of the container
      - ALLOW_REGISTRATION=False
    volumes:
      - "./data/pingvin-data/:/opt/app/backend/data"
      - "./data/pingvin-data/images:/opt/app/frontend/public/img"
networks:
  default:
    external: true
    name: npm-bus

However the registration is still allowed.

👍 Expected behavior
It should not let new registrations.
👎 Actual Behavior
It actually let any user to register himself.
📜 Logs
No response

The option to configure Pingvin Share using environment variables was removed two years ago in v0.3.0. You can now disable registration directly from the admin page at /admin/config/share.

 Thank you!


feat(forum, community): fix follower, following, friends

fix follower, following, friends, add page for forum, design for categories of forum, view single
forum

Merging you pull request.


Include generated classes without dates for XML projects

Currently, the generated classes in ots-xml and ots-opendrive are not published on github. This means that users of the code itself either have to run XJC with lots of command line parameters, or use Eclipse to generate the sources for these classes. This will not automatically work in environments like Visual Studio or IntelliJ. To make it easier for Java users to use opentrafficim 'out of the box', it would be nice if the source code of the generated classes can be incorporated in the git as well.
Since the generated classes have tags like:
@Generated(value = "com.sun.tools.xjc.Driver", comments = "JAXB RI v4.0.5",
    date = "2024-12-06T14:32:41+01:00")

with an included date, there is a chance that generated classes will be pushed very often to github. Therefore we will have to strip the date from the @Generated tag.

With the settings:
``xml
false
true

in the pom.xml file for the properties of the JAXB-parser, the file headers will not incur changes after new generation of the same source files.

Implemented in ots-xml and ots-opendrive projects.

Still need to make the generated files available on github.

Done for ots-xml

Done for ots-opendrive


Homepage #applebrowserban link needs to be more useful

Type of Change

[ ] Enhancement
[x] Content
[x] Improvement / Suggestion
[ ] Bug
[ ] Other (please clarify below)

Summary
Currently, on the home page, the #applebrowserban link goes through to a twitter search, which is very interesting and all but not very informative.
I propose we write a summary of that issue on a new page, and link that hashtag through to that along with some specific directives on what people can do in regards to this issue (such as use the hashtag on their posts!), and then a link through to the walled garden report, any relevant news articles we have, etc., so there's an easier entry point into understanding the issue.

This PR will fix this: https://github.com/OpenWebAdvocacy/website/pull/91


[Paper] Text comparison using word vector representations and dimensionality reduction, Hendrik Heuer

(Reviewer: Vlad Niculae, PhD student, Cornell University)
Summary
This paper describes a tool for visualizing and comparing text documents.  It uses a straightforward technique, by plotting words in the intersection and in the two set differences in a 2D space where close words are encouraged to be similar.
The implementation uses precomputed "word vectors" downloaded from the web. These induce a low-rank (300-dim) space that compress co-occurrence information from much larger text data, and therefore capture meaningful similarities.  t-SNE is run on the output, and D3.js is used to provide an interactive plot.
Brief review
As a popularization tool to introduce potential users to what natural language processing can provide, I find it welcome.  But I would like to see it written more in this direction, and give pointers to other potential NLP tools such as topic modelling (e.g. jsLDA)
I find the approach lacking in motivating applications and examples; of course one could always plot documents in such a way, but when should we use this software?
Also, this paper, like many that it cites, seems to present "word embedding vectors" in a mystical light; the presentation should be more objective, rather than rely on a handful of successful examples on tasks that are not directly relevant to the application.
Corrections and changes in this direction would make this a relevant and welcome paper for the community, in my opinion.


Document Cloud limits

Add information and links for new Cloud global and adjustable limits.
Add to:

/api/v2/write
/api/v2/query

Related to https://github.com/influxdata/docs-v2/issues/3411

https://github.com/influxdata/DAR/issues/304


Wrong dependency version detected in package-lock.json, resulting in false-positive alert

Package manager/ecosystem
javascript

Manifest contents prior to update
https://github.com/AlCalzone/node-zwave-js/blob/42a8a329396d950085424537aecf618a798c4874/package-lock.json

Updated dependency
https://github.com/AlCalzone/node-zwave-js/network/alert/package-lock.json/handlebars/closed
The only occurence of handlebars is ^4.7.6, however dependabot tries to update it to version 4.5.3 or later and fails with "one or more other dependencies require a version that is incompatible with this update".
What you expected to see, versus what you actually saw
I expected no update or alert at all, since the used version is already higher than necessary
Images of the diff or a link to the PR, issue or logs
https://github.com/AlCalzone/node-zwave-js/network/alert/package-lock.json/handlebars/closed/update-errors/48749721

Hi @AlCalzone, did you receive only an alert or also a PullRequest?

Only an alert (or rather three to be exact), which includes an error that dependabot could not update:

This is the description under "view details about this error":

Thanks, I don't work on those alerts myself, but I'll route this to the right team, thanks @AlCalzone!

We had those wrong reports now 3 times in a row the last 3 days. On first report, the dependency wasn't even present in our package-lock.json. The report yesterday and today was the same as the issue from the author - the version that's being requested to install is already installed.

This if the package-lock.json and this the report:

I'm now also getting the false positive for yargs-parser:

The lowest version in my package-lock.json is the recommended 18.1.1. Dependabot is unable to create an update (which is expected I guess).

I've experienced this, as well, and I have a hypothesis on why. In my case, dependabot reports the vulnerability in yargs-parser <= 5.0.0. The recommended remediation is: "Upgrade yargs-parser to version 5.0.0-security.0 or later". However, when I run npm ls yargs-parser on the main branch of my repo, I only see the patched version 5.0.0-security.0  listed. I manually checked my package-lock.json, as well.
I'm guessing this is maybe caused by the the following:

the parent dependency of the yargs-parser is<EMAIL_ADDRESS>the package.json of yargs version 7.x lists yargs-parser "^5.0.0"
dependabot only sees the yargs-parser version in the yargs package.json NOT my project's package-lock.json, therefore sending an alert
Would this be at all accurate? If so, is this the expected behaviour? I might be misunderstanding the internals of dependabot.

I've experienced this, as well, and I have a hypothesis on why. In my case, dependabot reports the vulnerability in yargs-parser <= 5.0.0. The recommended remediation is: "Upgrade yargs-parser to version 5.0.0-security.0 or later". However, when I run npm ls yargs-parser on the main branch of my repo, I only see the patched version 5.0.0-security.0  listed. I manually checked my package-lock.json, as well.
I'm guessing this is maybe caused by the the following:

the parent dependency of the yargs-parser is<EMAIL_ADDRESS>the package.json of yargs version 7.x lists yargs-parser "^5.0.0"
dependabot only sees the yargs-parser version in the yargs package.json NOT my project's package-lock.json, therefore sending an alert
Would this be at all accurate? If so, is this the expected behaviour? I might be misunderstanding the internals of dependabot.

These alerts are generated by code outside of dependabot-core... we only handle creating the code diff / PR to update the version.
I know that team has pushed a number of improvements in the 18 months since the last comment on this issue, so I'm going to close this for now. If I'm wrong and this is still happening for the examples illustrated above, please comment and we can re-open. Otherwise you can always open a new issue if / when it happens again.


feat(weave_query): Add string op to parse number with a specified thousands separator

Description

Handles WB-16442
Creates a new string op that will parse numbers with a thousands separator.

Testing
Added unit tests

I think this solution is pretty sweet especially since you removed the locale calls. Do you think it would feasible to add a second optional argument to represent the decimal symbol if needed? For example, I think 1.234.567,14 is valid in many European countries.


created a basic scraper

scrapes the national health service uk website to extract the consultant doctor details.

ok to merge with base branch.


Cloudformation - DescribeStacksErrorKind only contains "Unhandled"

Describe the bug
The DescribeStacksErrorKind only contains the value "Unhandled", and it is necessary to match against the error string to decide how to respond to an error. For instance, a quick way to check if a stack exists is to use this call to list, filtering for the given stack name, and then checking that the error returned indicates the stack doesn't exist.
Expected Behavior
The known responses to be parsed out and exposed as different kinds to avoid the caller having to do this themselves (like the other APIs?)
Current Behavior
Code like this:
return if e.to_string().contains("does not exist") {
                Ok(false)
            } else {
                // This is less great
               ...
            }

Reproduction Steps
call DescribeStacks and try and parse the response
Possible Solution
Parse the response out to the different types within the SDK
Additional Information/Context
No response
Version
0.21.0

Environment details (OS name and version, etc.)
osx 12.5.1
Logs
No response

Thanks @scottgerring for creating this issue. This is a problem with the modeling of the cloudformation api. Because this effects all of the sdks I have opened a new github issue here to track this and I will be closing this issue.

Re-opening this issue to track it here.
P76904203


CI: Install and test portable-ruby [WIP]

Install and test the portable-ruby bottle.

GitHub CI on Linux
mkdir: cannot create directory ‘/home/linuxbrew’: Permission denied

https://github.com/Homebrew/homebrew-portable-ruby/pull/90/checks?check_run_id=253953687#step:8:13

@sjackman You'll need sudo

Some suggestions if you are interested.

After setting HOMEBREW_DEVELOPER, you can set HOMEBREW_RUBY_PATH directly to use that ruby.
For Linux, you may want to test the portable-ruby on several Linux distros  using docker. The choice of distros can be based on your analytical data. So you can do something like this:

tar -xzvf /path/to/bottle/file
git clone --depth=1 https://github.com/Homebrew/brew
cat > test.env <<EOS
HOMEBREW_DEVELOPER=1
HOMEBREW_RUBY_PATH=/test/portable-ruby/<version>/bin/ruby
PATH=/test/brew/bin:$PATH
EOS
docker run --rm --env-file test.env -v $(pwd):/test/ debian:latest brew tests
docker run --rm --env-file test.env -v $(pwd):/test/ centos:latest brew tests

You could also add ARM build and test in CI. See https://github.com/Homebrew/brew/pull/6595#discussion_r334750572

Good ideas, thanks @xu-cheng.

@xu-cheng Is this PR superseded by PR https://github.com/Homebrew/homebrew-portable-ruby/pull/90?

@xu-cheng Is this PR superseded by PR #90?

I think so.


Fix attaching script after removing one

Fixes #26320
I investigated the issue and the culprit was this:
Node *selected = scene_tree->get_selected();
if (!selected)
    break;

When scene tree dock loses focus, it still has selection, but get_selected() returns NULL. So I did it in similar way as clearing script works, i.e. I get the selection list, but the "selected node" is still used. If there's no "selected node", the first element from selection list is used instead.

I like this change.. and I guess its simple enough to be merged into 3.1 for now

Thanks!


feat: scroll on top

Objective
What: https://app.clickup.com/t/2rreu34
Why:
How:
Create a function with router in config file
Usage:
Type

[x] Bug Fix

Tested
✅
Documented

[x] Have you documented in changed file using comments

Task linked: CU-2rreu34 scroll position not reset on SRP -> PDP


Feature/re adding quote mint and redeem

update unit converisons and add in necessary functions for quote mint/redeem

npm run format to fix the idl format


Support Mac OS X

Hi everyone!
As Docker 0.8 supports Mac OS X it should be possible to use dokku from Mac.

For those of us that run Mac Mini as a server , this is the PERFECT solution . It is unfortunate that you have decided not to pursue this further. In the meantime I may have to consider the pf to forward all requests to a VM running Ubunutu and Dokku on a Mac Mini.............Feels like a hack......

@glawson6 Docker runs on OS X inside of Vagrant, so you're not even really doing anything different. We have an open issue for docker-based deployments, which will make it a bit easier to run "directly" on OS X, but it's still the same hack...


Enable esp8266 tests

Summary
Split up and re-enabled ESP8266 tests.  API tests required further
splitting due to large amounts of strings.
Requires #157 and a rebase, or close #157 and just merge this PR.  However you want to break it up.

Checklist

[ ] Documentation (if necessary)
[x] Tests (if necessary)
[x] Ready to be merged

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.
If no reviewer appears after a week, a reminder will be sent out.

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.
Thank you for your contribution!

@ciband
conflicts.
There's also no longer a src/lib or test/lib dir.

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.
Thank you for your contribution!

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.


Setup BuddyBuild to be using the<EMAIL_ADDRESS>account instead of Travis's

So we're not waiting 20+ minutes for builds, we should set everything up using the Spartan account.

Completed in https://github.com/spartansystems/booster-kit-swift/pull/4


Doc, CMSIS-Core: minor documentation clean up.

There are still doxygen warnings left: https://github.com/ARM-software/CMSIS_6/actions/runs/7007859377?pr=95

Those in CMSIS-Driver I can't figure out. Some strange doxygen complain. But it doesn't impact documentation.


FIx Issue with Whoogle and This

Not sure if the fix should be applied here, but I noticed that it was really hard to read the hints that pop up. What to select to click the link.
It seems this theme's span setting gets overwritten by my whoogle theme also using catppuccin. So here is the fix I applied. Again not sure if this a hack let me know, thought I'd share with the community.
Before:

After:

Thanks for the PR. The maintainer of this repository left a long time ago so this repository hasn't had any eyes on it recently so sorry for the wait!
I refactored the code to make use of our internal tooling which unfortunately gives this PR a conflict. I've pushed this myself in #9 so it should be fixed now.


Add Callback.

I wanted to log when a snap to a point is done.
I found that the easiest way to do so, is to make the plugin have a callback function.
[UPDATE]
I have a solution, it is not the best tho. It also adds the ability to choose easing for the animation.
(I don't know how to post my solution, I just started using githib)

I added a pull request to resolve this issue.


WFLY-13885 SharedSessionTestCase should test non-distributed session manager

https://issues.redhat.com/browse/WFLY-13885

I put ready-for-merge on this before CI completed as the test it updates has already passed on all jobs.


datax Task execution failed

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
[LOG-PATH]: /opt/apache-dolphinscheduler-3.1.7-bin/standalone-server/logs/20240506/13510223263456_2-319-319.log, [HOST]:  Host{address='<IP_ADDRESS>:1234', ip='<IP_ADDRESS>', port=1234}
[INFO] 2024-05-06 07:19:58.225 +0000 - Begin to pulling task
[INFO] 2024-05-06 07:19:58.227 +0000 - Begin to initialize task
[INFO] 2024-05-06 07:19:58.227 +0000 - Set task startTime: Mon May 06 07:19:58 UTC 2024
[INFO] 2024-05-06 07:19:58.228 +0000 - Set task envFile: /opt/apache-dolphinscheduler-3.1.7-bin/standalone-server/conf/dolphinscheduler_env.sh
[INFO] 2024-05-06 07:19:58.228 +0000 - Set task appId: 319_319
[INFO] 2024-05-06 07:19:58.228 +0000 - End initialize task
[INFO] 2024-05-06 07:19:58.228 +0000 - Set task status to TaskExecutionStatus{code=1, desc='running'}
[INFO] 2024-05-06 07:19:58.229 +0000 - TenantCode:admin check success
[INFO] 2024-05-06 07:19:58.229 +0000 - ProcessExecDir:/tmp/dolphinscheduler/exec/process/admin/13376015454688/13510223263456_2/319/319 check success
[INFO] 2024-05-06 07:19:58.229 +0000 - Resources:{} check success
[INFO] 2024-05-06 07:19:58.230 +0000 - Task plugin: DATAX create success
[INFO] 2024-05-06 07:19:58.230 +0000 - datax task params {"localParams":[],"resourceList":[],"customConfig":0,"dsType":"SQLSERVER","dataSource":2,"dtType":"CLICKHOUSE","dataTarget":1,"sql":"SELECT CurrencyMonthID as Id,DayPeriod,CurrencyName,ExchangeRate  from ODS_Base_CurrencyMonth\r\n","targetTable":"ODS_Base_CurrencyMonth_test","jobSpeedByte":0,"jobSpeedRecord":1000,"preStatements":[],"postStatements":[],"xms":1,"xmx":1}
[INFO] 2024-05-06 07:19:58.233 +0000 - Success initialized task plugin instance success
[INFO] 2024-05-06 07:19:58.233 +0000 - Success set taskVarPool: null
[INFO] 2024-05-06 07:19:58.234 +0000 - Begin to create command file:/tmp/dolphinscheduler/exec/process/admin/13376015454688/13510223263456_2/319/319/319_319.command
[INFO] 2024-05-06 07:19:58.235 +0000 - Success create command file, command: #!/bin/bash
BASEDIR=$(cd dirname $0; pwd)
cd $BASEDIR
source /opt/apache-dolphinscheduler-3.1.7-bin/standalone-server/conf/dolphinscheduler_env.sh
/tmp/dolphinscheduler/exec/process/admin/13376015454688/13510223263456_2/319/319/319_319_node.sh
[INFO] 2024-05-06 07:19:58.238 +0000 - task run command: sudo -u admin -E bash /tmp/dolphinscheduler/exec/process/admin/13376015454688/13510223263456_2/319/319/319_319.command
[INFO] 2024-05-06 07:19:58.238 +0000 - process start, process id is: 24341
[INFO] 2024-05-06 07:19:58.270 +0000 - process has exited. execute path:/tmp/dolphinscheduler/exec/process/admin/13376015454688/13510223263456_2/319/319, processId:24341 ,exitStatusCode:127 ,processWaitForStatus:true ,processExitValue:127
[INFO] 2024-05-06 07:19:58.271 +0000 - Send task execute result to master, the current task status: TaskExecutionStatus{code=6, desc='failure'}
[INFO] 2024-05-06 07:19:58.271 +0000 - Remove the current task execute context from worker cache
[INFO] 2024-05-06 07:19:58.271 +0000 - The current execute mode isn't develop mode, will clear the task execute file: /tmp/dolphinscheduler/exec/process/admin/13376015454688/13510223263456_2/319/319
[INFO] 2024-05-06 07:19:58.272 +0000 - Success clear the task execute file: /tmp/dolphinscheduler/exec/process/admin/13376015454688/13510223263456_2/319/319
[INFO] 2024-05-06 07:19:59.239 +0000 -  -> /tmp/dolphinscheduler/exec/process/admin/13376015454688/13510223263456_2/319/319/319_319_node.sh:行1: /opt/soft/python/bin/python2.7: 没有那个文件或目录
[INFO] 2024-05-06 07:19:59.240 +0000 - FINALIZE_SESSION
What you expected to happen

How to reproduce

Anything else

Version
3.1.x
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@danielfree

已解决，未配置python目录


Readding custom tokens

Multiple users messaged saying, they have to re add the custom tokens every time they log in. Lets make sure saving to local storage works as standard.

You need to re-add new tokens everytime you long in and make sure to save to local storage wprk standard


Improve AffineMinCanonicalization in MatmulCodegen strategy.

The current solution would not fold if the dimensions were no used by
ForOp or AffineMin. Add a fallback to try to optimize those cases.

Not sure why this is part of IREE and not general affine.min canonicalization patterns?

Not sure why this is part of IREE and not general affine.min canonicalization patterns?

I’m not sure either. Nicolas had added it to the MatMulCodegen Strategy in a first place. I’m guessing there was some missing pieces that prevented him to upstream. I would rather wait for Nicolas to be back to move it upstream, in the meantime the tiling for several cases is a blocked without that patch so I was thinking changing it in IREE for now.

Not really sure what the new canonicalizations here are. SOme comments would help cause I dont have full context on these. Approving anyway, but hopefully this will move upstream soon.

Thanks Mahesh. I added a comment, there isn't a lot of details. Hopefully I can clean this up once Nicolas is back.