Netlify CLI keeps adding overzealous and incorrect rule to .gitignore

Describe the bug
In my .gitignore I have the following intentional line:
/.netlify

Linking a new site / running CLI in several ways will incorrectly add:
# Local Netlify folder
.netlify

In order to make my monorepos work again I have to add:
!sites/**/.netlify

To Reproduce
Steps to reproduce the behavior:

Create a new git repo
Add .gitignore with /.netlify
Run netlify deploy
It has added the line to .gitignore

Configuration
npx envinfo --system --binaries --npmPackages netlify-cli --npmGlobalPackages netlify-cli

  System:
    OS: Windows 10 10.0.19042
    CPU: (12) x64 Intel(R) Core(TM) i7-6800K CPU @ 3.40GHz
    Memory: 5.80 GB / 31.91 GB
  Binaries:
    Node: 12.18.2 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.4 -<EMAIL_ADDRESS>    npm: 6.14.5 - C:\Program Files\nodejs\npm.CMD
  npmPackages:
    netlify-cli: ^3.10.12 => 3.10.12

Expected behavior
It does not add .netlify to .gitignore.

The biggest issue with this is that it will silently fail on changes / new files. You won't notice until your build starts failing somewhere else (for example, because there is no state.json available. It's counter-intuitive and frankly, I hate that it's doing something to my .gitignore without telling me.

Hi @SleeplessByte, linking https://github.com/netlify/cli/issues/506 for context.
I agree this is not an ideal experience.
To clarify - you only want to ignore .netlify at the root level? Any reason you want to commit state.json?
Please note that the .netlify folder can also contain temporary files generated during netlify build and other information that should not be committed to the repo.

You got it.
We have our own build and then only use netlify deploy, so those other files never get generated.
state.json holds the siteId and is a far better tool to configure ci builds for a folder then trying to do it via environment variables.

The linked issue has very similar concerns (and remains unresolved).
I see the following options:

only ignore the files that contain sensitive information,
unignore state.json
ask a user

The notion that you need to protect users who might not understand and therefore do this automatically is understandable, but in my opinion not the right way. By not notifying such a user, and make it a conscious decision, a user is never taught that the folder may contain sensitive data, and what that sensitive data is.
It's also pretty elitist to decide for everyone how their projects should be structured but I think that was made clear in the previous issue from 2 years ago :)

I think we can solve this by looking for a .netlify substring in the patterns here https://github.com/netlify/cli/blob/14b1b7751fa259c78fc12e4f1207ca765ac7b483/src/utils/gitignore.js#L95 instead of trying to find a full match.
That would allow us to support both use cases WDYT?
Regardless we should add a log message when we add .netlify to .gitignore.
In addition we should re-visit the "sensitive data" reasoning  since users can unignore .netlify anyways or copy that directory with the folder to another location unaware of having that folder copied around.
Finally we'll need to make sure that if users do commit state.json (out of choice or mistake) we handle possible failures resulting from it (e.g. the site was deleted so the information in state.json is no longer valid).
How does that sound?

All go that sounds like it will solve my issues, the original issue, and potential future issues, so it got my seal of approval.


update dependencies

in reference to https://github.com/AllenDang/cimgui-go/issues/243 we need to update
@damntourists check if this works ;-)

waiting for https://github.com/gucio321/cimgui-go/actions/runs/8022280030/job/21916233019


Question: Important metric for monitoring

Hello,
Could someone prompt me, please? What are the Important metrics for monitoring Dynomite?
I am going to prepare a template for Zabbix.
Thanks.

http://localhost:22222/info
this will be configured under yaml file


Added a test for a regex that tests 'not in'

This in support of splitting tree zone data into Trees and 'everything else'.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c58fa57) 79.54% compared to head (25a0d81) 79.54%.
Report is 4 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   79.54%   79.54%
=======================================
  Files          67       67
  Lines        3588     3588
=======================================
  Hits         2854     2854
  Misses        734      734

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Play stream as progressive or interlaced

When I play a stream that has an interlaced format, it plays as progressive, causing the video to come out horizontally striped

Can you share a sample? It's hard to say anything like this.

Can you share a sample? It's hard to say anything like this.

Hi sir, I just need your help to show an error to users if video can't play!
Idk where and how to use playback event for error.

@usman615
Use Player.stream.error. Example:
https://github.com/media-kit/media-kit/blob/089437510a5852db80e196cb4007e9f3aacce5b3/media_kit_test/lib/tests/01.single_player_single_video.dart#L30
A better place for conversations & help-seeking can be our Discord:

Joined....


Update Dependencies to Support Minecraft 1.21.3

Update Dependencies to Support Minecraft 1.21.3
Summary
This pull request updates dependencies to support Minecraft 1.21.3. Key changes made:

Updated fabric-loom to version 1.8-SNAPSHOT in build.gradle.
Incremented mod version to 8.0.1 and updated Minecraft, loader, yarn mappings, and other dependencies in gradle.properties.
Upgraded Gradle wrapper to 8.10 in gradle-wrapper.properties.
Updated AuthButtonWidget by adding RenderLayer.getGuiTexturedOverlay now required by yarn.

Problem Statement
This update addresses the need for compatibility with Minecraft 1.21.3, ensuring the mod stays current with the latest Minecraft and Fabric API versions.
Justification
Updating dependencies to help ensure compatibility with the latest Minecraft version, and access to recent changes in external libraries.
Quality Assurance

Verified that dependencies align with Minecraft 1.21.3.
Tested rendering changes in AuthButtonWidget to ensure proper functionality with RenderLayer.getGuiTexturedOverlay.

Thank you for this, it has been released. <3


Lake creates a hard-to-delete file in src/lake/tests/

I sometimes end up (usually after cancelling a make test) with a file like:
Untracked files:
  (use "git add <file>..." to include in what will be committed)
        "src/lake/tests/init/\302\253A-B\302\273-\302\253C-D\302\273/"

Because of the terrible file name, it is quite hard to delete, and I seem to resort to git clean -xfd.
Could lake be more robust about cleaning up, or, simpler, just add this to a .gitignore?

@semorrison The directory created by that test is part of the .gitignore. It is not clear to me why Git is not ignoring it on your system. A change to produce better directory names for that test is included as part of the require overhaul in 88fd60174e74836abe505269c9e2780236b8e198, but I may be able to backport that fix into a separate smaller PR.

I've also seen this happen!
I think @semorrison and I are both on Macs. Could it be that the Unicode normal form stored in the .gitignore doesn't match the one on the filesystem, or that a byte comparison is being done somewhere in Git where a string comparison would be better, leading to a UTF-16/UTF-8 mismatch? If it's the latter, then we could probably duplicate a few .gitignore entries for different encodings/normalizations.

I have it on Linux.


ATX Builder support ATX V2

Motivation
Add support for building solo (non-merged) ATX version 2.
Description
Closes #5995
Test Plan

[x] UT
[x] e2e integration test testing the whole pipeline (builder together with handler)
[x] manual tests in standalone mode
[x] systest

All system tests were updated to produce ATX V2 since epoch 2. The nodes will build 1 ATX with version 2 in epoch 1 and switch to ATX V2. The tests in TestAddNodes also verify that a node can join the network after V1->V2 switch happened (so they start with V2 initial ATX).
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[ ] Update documentation as needed
[ ] Update changelog as needed

bors try

bors try

bors try

bors try

bors try

bors merge

CI job flake on windows runner
bors merge


phantomjs crash

2014-04-12 11:14:21.005 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API. 0 [ '2014-04-12 11:14:21.005 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'2014-04-12 11:14:21.006 phantomjs[5133:507] CoreText performance note: Set a breakpoint on CTFontLogSuboptimalRequest to debug.',
'2014-04-12 11:14:23.989 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'2014-04-12 11:14:25.029 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'PhantomJS has crashed. Please read the crash reporting guide at https://code.google.com/p/phantomjs/wiki/CrashReporting and file a bug report at https://code.google.com/p/phantomjs/issues/entry with the crash dump file attached: /tmp/53DE0C51-09B2-44FD-89D3-3DAB07AA6C68.dmp' ]
2014-04-12 11:14:21.006 phantomjs[5133:507] CoreText performance note: Set a breakpoint on CTFontLogSuboptimalRequest to debug. 1 [ '2014-04-12 11:14:21.005 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'2014-04-12 11:14:21.006 phantomjs[5133:507] CoreText performance note: Set a breakpoint on CTFontLogSuboptimalRequest to debug.',
'2014-04-12 11:14:23.989 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'2014-04-12 11:14:25.029 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'PhantomJS has crashed. Please read the crash reporting guide at https://code.google.com/p/phantomjs/wiki/CrashReporting and file a bug report at https://code.google.com/p/phantomjs/issues/entry with the crash dump file attached: /tmp/53DE0C51-09B2-44FD-89D3-3DAB07AA6C68.dmp' ]
2014-04-12 11:14:23.989 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API. 2 [ '2014-04-12 11:14:21.005 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'2014-04-12 11:14:21.006 phantomjs[5133:507] CoreText performance note: Set a breakpoint on CTFontLogSuboptimalRequest to debug.',
'2014-04-12 11:14:23.989 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'2014-04-12 11:14:25.029 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'PhantomJS has crashed. Please read the crash reporting guide at https://code.google.com/p/phantomjs/wiki/CrashReporting and file a bug report at https://code.google.com/p/phantomjs/issues/entry with the crash dump file attached: /tmp/53DE0C51-09B2-44FD-89D3-3DAB07AA6C68.dmp' ]
2014-04-12 11:14:25.029 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API. 3 [ '2014-04-12 11:14:21.005 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'2014-04-12 11:14:21.006 phantomjs[5133:507] CoreText performance note: Set a breakpoint on CTFontLogSuboptimalRequest to debug.',
'2014-04-12 11:14:23.989 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'2014-04-12 11:14:25.029 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'PhantomJS has crashed. Please read the crash reporting guide at https://code.google.com/p/phantomjs/wiki/CrashReporting and file a bug report at https://code.google.com/p/phantomjs/issues/entry with the crash dump file attached: /tmp/53DE0C51-09B2-44FD-89D3-3DAB07AA6C68.dmp' ]
PhantomJS has crashed. Please read the crash reporting guide at https://code.google.com/p/phantomjs/wiki/CrashReporting and file a bug report at https://code.google.com/p/phantomjs/issues/entry with the crash dump file attached: /tmp/53DE0C51-09B2-44FD-89D3-3DAB07AA6C68.dmp 4 [ '2014-04-12 11:14:21.005 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'2014-04-12 11:14:21.006 phantomjs[5133:507] CoreText performance note: Set a breakpoint on CTFontLogSuboptimalRequest to debug.',
'2014-04-12 11:14:23.989 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'2014-04-12 11:14:25.029 phantomjs[5133:507] CoreText performance note: Client called CTFontCreateWithName() using name "Times New Roman" and got font with PostScript name "TimesNewRomanPSMT". For best performance, only use PostScript names when calling this API.',
'PhantomJS has crashed. Please read the crash reporting guide at https://code.google.com/p/phantomjs/wiki/CrashReporting and file a bug report at https://code.google.com/p/phantomjs/issues/entry with the crash dump file attached: /tmp/53DE0C51-09B2-44FD-89D3-3DAB07AA6C68.dmp' ]

Please upgrade to PhantomJS 2. 1.9.x is no longer supported, and known to have many crasher bugs that are fixed in 2 version.


[FEATURE REQUEST] Borrow on Object types

An object subclass already implements AsRef<$ParentObject>. Could it also implement Borrow<$ParentObject>?
The Borrow trait has different requirements and I don't know if this is possible.
From the rust doc:

AsRef has the same signature as Borrow, but Borrow is different in few aspects:
- Unlike AsRef, Borrow has a blanket impl for any T, and can be used to accept either a reference or a value.
- Borrow also requires that Hash, Eq and Ord for borrowed value are equivalent to those of the owned value. For this reason, if you want to borrow only a single field of a struct you can implement AsRef, but not Borrow.

I would use the Borrow trait to accept parameters in setter functions in the Properties macro (#494). AsRef isn't enough because it doesn't have a blanket impl for any T

Borrow seems semantically the wrong trait for subtyping, and it also has the connections to the ToOwned trait which doesn't fit at all here.
Why do you need Borrow?

Let's say I have a struct with two fields:
#[derive(Properties)
struct MyClass {
  mystring: RefCell<String>,
  myobject: RefCell<Object>,
}

and given the related traits:
impl HasParamSpec for String {
    type ParamSpec = ParamSpecString;
    type SetValue = str;
}
impl HasParamSpec for Object {
    type ParamSpec = ParamSpecString;
    type SetValue = Object; // Ideally this would be a generic associated type `IsA<Object>`, but rust can't do that yet.
}

the related setter functions are
pub fn set_mystring(&self, value: HasParamSpec::SetValue);
pub fn set_myobject(&self, value: HasParamSpec::SetValue);  // This won't accept subclasses, until rust has GATs

Until we have GATs in rust, we could have
pub fn set_mystring(&self, value: Borrow<HasParamSpec::SetValue>);
pub fn set_myobject(&self, value: Borrow<HasParamSpec::SetValue>);  // This could accept subclasses if Borrow<ParentClass> is implemented

Borrow has a blanket implementation for any T, so it works well even with other types as f64, f32... AsRef isn't implemented on floats (and other types), so I can't use that.

I think it is actually possible to hack this using autoderef specialization to generate a setter method that detects if something implements IsA<Object>

I don't understand how this is supposed to work, you would have to implement it for T: IsA<Object>, not for each object type


Fix neutrinordp buffering

This PR primarily addresses #1634 and #1608 where displaying a video over a slow link causes XRDP to buffer unsent packets without a limit.
The basic issue is that the neutrinordp module is not making use of the source_info mechanism which is designed to throttle inputs when they are producing too much output.
I've also made some code improvements while implementing this as follows:-

A comment has been added to the struct source_infodefinition in trans.h explaining what this structure is used for.
An enum is now used for the cur_source member variable of this struct rather than an int to help when using a symbolic debugger.
The various XRDP modules for the backends had tintptr si (i.e. void *) member definitions in their header files for the module source_info pointer. I've replaced the void * pointers with pointers to incomplete type declarations as follows:-struct source_info;  /* Incomplete type */
. . .
struct mod
{
    . . .
    struct_source_info *si;
    . . .

This prevents the need for pointer casting and hence improves compile-time checking.

I haven't tested this yet but the code looks fine. Feel free to merge.


Update faq.md

Updating the M365 learning pathways FAQs article.

Hi @jhwang-ms,
I am looking into who processes the PRs for this repo.

Thanks @traya1! This is my first time submitting a PR through the desktop GitHub app, so please LMK if I missed any steps.

@traya1 any update on this PR?


New DB design document for supporting events endpoint

What problem does your feature solve?
subtask of https://github.com/stellar/soroban-rpc/issues/115
What would you like to see?
Design document with new schema of events and overview of implementation

WIP doc: https://docs.google.com/document/d/1Q5AJvszwFmwl3NzHh7PJIMj4mhN3HgHRn_7IOQGeMWg/edit


msw doesn't seem to actually work with this setup

Not sure if I'm doing something wrong but when I run npm run dev I see that the mocks are being started and loaded with this log console.info("🔶 Mock server running");
However, if I change onUnhandledRequest to "error" like this server.listen({ onUnhandledRequest: "error" }); I never see any errors or logs about unhandled requests even though I'm definitely making requests to Stripe.
I've tried all sorts of things to debug but can't make progress.
Any ideas?
edit: seems like the sanbox is likely starting separate node processes to run the lambdas which MSW won't see.

Ah, that's a bummer. I tested it in the other stacks but not this one. We may need to be a bit more invasive by requiring the mocks in app code 😬
@tbeseda can you confirm that this will run in a different node process from the app? If so, we may need to move that require into app/entry.server.ts during development.
Would be better if there were a way to do a --require sort of thing with arc directly so we don't have to put it in app code.

Yeah, I'm playing around with running msw in server.ts and it seems to work okay.

Can confirm it does work if you start the server in app/entry.server.ts but it feels like it really slows every request down quite a bit.  Also saw some issues with a 3rd party library that was using axios to post.

Correct, Architect will run each function execution in a new process. It does use the same environment from the root project/package.json, but doesn't inherit from the parent process. This behavior is important to emulating how Lambda will run the function in isolation on AWS.
Obviously msw is really helpful for mocking APIs that a function would interact with, but I'm not sure how it could be wrapped around a function in Sandbox. A plugin might help, but I think no matter what it has to be started each time a request is made since there are no long running processes.

any luck trying to make debugger work in grunge stack @eXigentCoder?

I am also facing challenges to debug in grunge stack. Anyonbe knows of some advices to make it work?


Limiter causes flashing/jumping screen at extents

Creating a limiter (ViewportLimiterKeepWithin) where layers may extend beyond that area causes flickering when the user pans / zooms beyond the limit (and continues to touch the screen).
This can be resolved in the map.Envelope calculation by limiting the bounding box by applying an intersection method.
In my case, this works nicely (but may not work for other limiters):
    public BoundingBox Envelope
    {
        get
        {
            if (_layers.Count == 0) return null;

            BoundingBox bbox = null;
            ...

            if (Limiter?.PanLimits != null)
            {
                if (bbox == null)
                {
                    return Limiter.PanLimits;
                }
                else
                {
                    var limitedBBox = bbox?.Intersect(Limiter.PanLimits);
                    return limitedBBox;
                }
            }
            else
            {
                return bbox;
            }
        }
    }

In order to create greater flexibility, ILimiter could provide a method to handle the equivalent of the intersection calc here. This would allow for the Limiter's author to implement their preferred calculation - or simply return the original BoundingBox.
    public BoundingBox Envelope
    {
        get
        {
            if (_layers.Count == 0) return null;

            BoundingBox bbox = null;
            ...

            if (Limiter != null)
            {
                return Limiter.Clip(bbox);
            }
            else
            {
                return bbox;
            }
        }
    }

The example above uses the following method to calculate the intersection:
    /// <summary>
    ///     Computes the intersection boundingbox of this instance and another boundingbox
    /// </summary>
    /// <param name="box">Boundingbox to create inersection with</param>
    /// <returns>Boundingbox of intersection of both boundingboxes</returns>
    public BoundingBox Intersect(BoundingBox box)
    {
        if (box == null)
            return Clone();
        return new BoundingBox(Math.Max(Min.X, box.Min.X), Math.Max(Min.Y, box.Min.Y),
            Math.Min(Max.X, box.Max.X), Math.Min(Max.Y, box.Max.Y));
    }

Trying to reproduce your issue I ran into an issue that may not be exactly the same. I fixed this first. Maybe you can test this fix to see how it affects your issue.

2.0.0-beta.17 was released which should improve your issue. Take a look and let me know if there are still issues left.


auto register exporters

When Exporter Beans are found in context, add them to the broker

The spring-starter for the broker was removed a while ago.


Make CoalescingBufferQueue test properly release all its buffers

Fixes https://github.com/netty/netty/issues/3989

@louiscryan - For consistency could we just use the new dequeue for the EMPTY buffer checks too?
assertEquals(0, writeQueue.remove(Integer.MAX_VALUE, aggregatePromise).readableBytes());

change to
assertEquals("", dequeue(Integer.MAX_VALUE, aggregatePromise));

Adjusted the empty tests as suggested

PTAL

@louiscryan - I think there is still 1 more case on line 158.

Done

Should be ripe for picking now. Fixed commit message

@louiscryan thanks!
Cherry-picked into 4.1 (e6ed3ce6b1bc7424d76a6a8a534592d7ec2ca731) and master (f608a139cfdb0a62ba84d5b006c6351d92578083)


question about running 'apartment' dataset

Thanks for your work firstly!
After I have downloads the data from the links in the 'download_data.py', I am confused of how to use them.
I downloaded 'apartment.zip' data. And I use ' --data-type replica'. It seems like it has to provide a 'traj.txt' file. Could you please describe how to run this dataset? Or I have to process the data to look like a tum dataset?
Thank you again.

I found it datatype is 'azure'. Sorry to bother you.


Prepopulate the Authorization Code in the SSO URL

Allows to skip the copy-paste step and prepopulates the authorization code in the browser login.

Will rather pull from next branch and recreate PR so as not to include other contributions.

Clearly, I'm an amateur at this... Sorry.

If I understand correctly, the change you're looking to make is to browser.py. I want to keep that message mostly in sync with the AWS CLI's aws sso login command, which is implemented here. I notice that they have added the verificationUriComplete URL to the message (well, only when you're using --no-browser), which is what you're looking for (there's no guarantee that the format for putting the code in the plain URL remains stable, that's why there's a separate parameter returned by the API for it).
So, with that in mind, here's how I'd like to do it:

Add two parameters to the call to self._message.format on line 70 (the idea is there's a friendly name and one matching the API):

urlWithCode=verificationUriComplete
verificationUriComplete=verificationUriComplete

Update the two messages DEFAULT_BROWSER_MESSAGE and DEFAULT_NO_BROWSER_MESSAGE to append the lines from the CLI starting "Alternatively..." seen here, but use urlWithCode rather than verificationUriComplete.

Does that make sense? I would also ask that you update the PR to be just a single clean commit to be added to the next branch.

Thank you for the excellent guidance. I am implementing as per your suggestion and testing now.


issuesof.net down/unresponsive?

Earlier today (August 30, 2021 around 8:30am US Eastern time) I was getting a 403 from the site.
Right now (11am US Eastern time) the main page loads but it shows zero issues and search query auto-complete isn't working, and actually running a search also doesn't seem to work).

2pm US Eastern - seems to be working now.


[<EMAIL_ADDRESS>requireError undefined ?

Discussed in https://github.com/brillout/vite-plugin-ssr/discussions/671

Originally posted by fortezhuo February 25, 2023
When I run my app that built using vite-plugin-ssr. Logs print out
[<EMAIL_ADDRESS>requireError undefined
[<EMAIL_ADDRESS>success true
[<EMAIL_ADDRESS>DEBUG_LOGS_RUNTIME [end]

What's requireError undefined mean ? and how to tweak or disable debug log ?

@fortezhuo It's a bug, let me fix it.

Fix released in 0.4.89.


Don’t escape html entities except for < and >.

Summary
Snapshots with React are used in different contexts, not just on the web. We don't need to replace all html entities. It does make sense however for < and > because otherwise it would break the pretty-printed JSX.
cc @vjeux
Test plan
jest

It's good


src\csharp\Grpc.sln shows no NuGet packages in VS2015

Windows 10. VS 2015. Latest master today.
Grpc.sln "Manage NuGet Packages for Solution" shows "No packages found"

This might be related to recently adding Grpc.Core.project.json (and other) files, so it seems VS2015 is trying to get the list of dependencies from   the *.project.json files and not from packages.config files.
Is it that you just don't see the nuget packages in VS 2015 or the build is broken (nuget restore seems to work).
Also, in VS2013 everything seems to work.

I can't see the nuget packages in VS 2015 nor can I restore them. But you are correct, it works well in VS 2013. I see that the solution still uses the pre-2.7 package restore techniques with entries in each csproj file. https://docs.nuget.org/consume/package-restore
Anyway, now I can proceed using VS 2013.
Thanks.

I'll reopen this one because it is an issue. Not clear to me though what is the best way to fix (besides copying the list of dependencies into project.json files (and thus having two copies - one in *.project.json files and one in packages.config file.

One way to work around this in VS2015 is to run nuget restore Grpc.sln manually. After doing that, the solution builds in VS2015 as without any problems.
I tried to experiment with techniques how to convince VS2015 to just ignore project.json file https://github.com/Microsoft/msbuild/issues/394,  but  none of the tricks has worked  (I tried false).

I submitted this pull request today for this issue. I don't know how to tie the PR to the issue.

Add project.json dependencies in Grpc.sln #7194

Probably this solution from this issue will better fit to your requirements. https://github.com/NuGet/Home/issues/3207

@jtattermusch I run nuget restore Grpc.sln manually, a new file Grpc.Core.project.lock.json is created:
{
  "locked": false,
  "version": 2,
  "targets": {
    ".NETFramework,Version=v4.5": {},
    ".NETFramework,Version=v4.5/win": {}
  },
  "libraries": {},
  "projectFileDependencyGroups": {
    "": [],
    ".NETFramework,Version=v4.5": []
  }
}

But msbuild Grpc.sln failed as the same.

@dalebrubaker, on #7194, thanks, but I'm not sure if that would that work with dotnet cli tools as well as vs2015? Would we have to use both sets of project.json files?
Also, another way of restoring packages and building the solution from the command line is with /path/to/repo/root/tools/run_tests/run_tests.py -l csharp -c <dbg,ops>, which will work with the old and new nugets. (when building the solution form visual studio, I was having trouble earlier because the native lib wasn't built for the config i was building the solution for).

@apolcyn, on #7194 you are probably correct. I closed my PR for this issue. I don't know (or care) about dotnet cli or project.json files, especially now that Microsoft has told us that they will be going back to csproj files early next year. Until then, I suppose each grpc consumer can muddle through getting a build in whatever way makes sense for him. Thanks.


Fix: Featured image requires absolute path #233

This fixes #233
I have one hesitation: func/GetFeaturedImage  that this modifies is called from 3 files:

layouts/post/summary-with-image.html
layouts/partials/page-header.html
layouts/partials/summary-with-image.html

As you can see there is both a summary-with-image.html in post/ and partials/. I was not able to find any reference to post/summary-with-image.html though, so I was not able to test that code-path. I could only see partials/summary-with-image.html being called:
me@machine:~/some/path/themes/ananke» ack summary-with-image
layouts/index.html:29:            {{ partial "summary-with-image.html" . }}

In my setup, everything worked fine even if post/summary-with-image.html is deleted entirely... So some help in how to setup something up that actually uses post/summary-with-image.html would be appreciated. But I don't (yet) see why it shouldn't work there also.

Hi @pmorch and thanks for your contribution.
I'm sorry for being so late on this. The featured image logic will be refactored in the upcoming 3.0.0 of the theme.
We'll include your reflexion in there.

Hi @pmorch and thanks for your contribution.
I'm sorry for being so late on this. The featured image logic will be refactored in the upcoming 3.0.0 of the theme.
We'll include your reflexion in there.


Wrong binaries in arm64 K3d image

Problem description:
With the 0.9.0 release, a K3d image has been created with two supported platforms, linux/amd64 and linux/arm64, both images contain the same shim binaries (x86-64). Using the linux/arm64 leads to this error when creating a container with those shims:
Failed to create pod sandbox: rpc error: code =
  Unknown desc = failed  to create containerd task:
    failed to start shim: start failed: :
      fork/exec /bin/containerd-shim-spin-v1: exec format error: unknown

Additional info:
root@kwasm-debug-6npz6:/# uname -m
aarch64

root@kwasm-debug-6npz6:/# file /mnt/node-root/bin/containerd-shim-spin-v1
/mnt/node-root/bin/containerd-shim-spin-v1: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, with debug_info, not stripped

The arm64 image works only on MacOS with Docker Desktop since it is able to run x86_64 binaries in aarch64 images.


Permission, Role and User

User has UserPermissionSetting, that extends PermissionSetting. Role has RolePermissionSetting that also extends PermissionSetting. So, generated database table AbpPermissions has both UserId and RoleId. Am I right to assume, that there is no separate table with unique permission entries and the table AbpPermissions can have multiple permissions with the same Name if this permission is added to several roles? Where should we keep global list of permissions, that we could show in the web form for adding to the role?
Could You give some brief information, how Permissions work, how Roles and Users should be managed (created, edited, permissions assigned to roles and/or individual users etc)?

I have the exact same question.

+1 for a bit of an explanation around permissions. I wanted to limit the main navigation by role but couldn't figure out how to do it and had to hack a solution together.
Thanks for sharing the framework by the way, it has saved me a ton of time.

It is answered in another issues somewhere - authorization is done by permission, not by role. There are few possible workarounds - use a permission in each role to determine user's role. In this case You have to limit the possibility to remove such permission.
The other way would be to check the role manually.

Hi,
List of all permissions are not stored in the database. It's stored 'in the code'. If you want to get a list of all permissions in the system, just inject IPermissionManager and use GetAllPermissions() method.

BTW,
I don't advice to check the role in the code. Because roles are dynamic, can be added and deleted by users. So, how can we know name of the role while we're coding..? Instead, check permissions. Role will be granted for permissions.
But, for some projects, we may need roles those are used in the code. I define these roles as 'static roles' (See Role.IsStatic property). Static roles can not be deleted by users and must be exists in the DB migration script. So, you can check it with UserManager.IsInRole("..."). Also, you can use they in AbpAuthorize attributes.
I haven't documented these yet since they are in-development. But I wanted to give brief info here :)

Thanks for a more detailed answer, it should help me  a lot.
Can you let me know how you would go about securing pages in the system based on whether the user is an admin or not and geenrating the navigation accordingly please?

Why do You need to generate navigation if a user "is admin"? Wouldn't it be better if any user would see only items that he has permission to access? There is a parameter for that in navigation provider.
public MenuItemDefinition(string name, ILocalizableString displayName, string icon = null, string url = null, bool requiresAuthentication = false, string requiredPermissionName = null, int order = 0);

If Your pages are a general CRUD, then You would add a Read permission, so a user would see the link only if he can view this information.
I am closing this, as @hikalkan has answered my initial question.


mariadb chart readiness probe fails with kolla/*-binary-mariadb image

The mariadb chart readiness probe uses pymysql which is not installed in the kolla mariadb images. End result is the database starts fine but the container is never marked as read due to the probe failure.

@wilreichert good catch!
@alanmeadows, would it make sense to explore using a more portable mysql binary client and shell based readiness check?

The check that is currently python based is extremely simplistic, we can easily replace it with a simpler, less dependent check.

I can work on this

The peer finder python script is also affected. Taking a look at it now


feat(helm): hiding password input on terminal

When using "helm repo add" with "--username" and without "--password",
hide user's input with a password prompt. This allows users to not
expose their passwords to the command line history.

@bacongobbler PTAL. This is an example of input interaction:

@bacongobbler  PTAL. Why wait so long?

Would you mind rebasing this one more time to kick off a rebuild? Looks like circleCI didn't trigger a test. Thanks!

@bacongobbler  done, PTAL


Json s3tests

adding tests per JSON input types, which includes various SQL operators.
alignment of some of the test routines upon removing the XML tags(<Payload><Records><Payload>) from the s3select results.

@galsalomon66 is this ready to merge?

@galsalomon66 is this ready to merge?

yes (tuethology ran with that)

@cbodley
how to backport this PR (into reef)?

similarly to how you cherry-picked to ceph-master, we'd cherry-pick to the ceph-reef branch. just be careful with the timing, so we don't introduce failures in other reef tests

similarly to how you cherry-picked to ceph-master, we'd cherry-pick to the ceph-reef branch. just be careful with the timing, so we don't introduce failures in other reef tests

ok

cherry-picked into ceph-reef (same as ceph-master). so  ...  i understand no tracker? no scripts for backport?
as for timing .... i guess both PR's should merge into reef at the same time.


fix lighthouse auditing workflow

and add badge https://github.com/emazzotta/lighthouse-badges

closed by
https://github.com/casca/lighthouse-reports
and
https://github.com/casca/lighthouse-reports-parser


Getting array data using JObject.Values("Field") fails to enumerate

Say I have an input string like this
{ \"Data\": [ \"item1\", \"item2\" ] }

If I do either of the following I get out an IEnumerable that when evaluated yields the two strings item1 and item2.
var s0 = data["Data"].Values<string>();
var s1 = data.Value<JArray>("Data").Values<string>();

However, if I do this:
var s2 = data.Values<string>("Data");

Then I get an exception when evaluating the IEnumerable saying Cannot access child value on Newtonsoft.Json.Linq.JProperty..
In the first two cases the IEnumerable is Convert<JToken, string> but in the latter it is Values<JToken, string>.
Should the latter use Convert as well?
Thanks!
Henrik

Values<T>(string) is a bit weird. It gets the key name from objects in a collection with that key.
e.g. if the values in data were objects instead of strings and they had a key called "name" then this would get those strings:
var s1 = data.Value<JArray>("Data").Values<string>("name");

ah, I see. thanks!


Event sources for the same resource type in multiple namespaces

With version 1.10.x of the SDK, event sources for the same type but different namespaces can be registered:
public void init(EventSourceManager eventSourceManager)
{
  SharedIndexInformer<Deployment> informer1 = client.apps().deployments()
    .inNamespace("ns1").withLabel("a", "b").runnableInformer(0);

  SharedIndexInformer<Deployment> informer2 = client.apps().deployments()
    .inNamespace("ns2").withLabel("a", "b").runnableInformer(0);

  InformerEventSource<Deployment> source1 = new InformerEventSource<>(informer1, ...);
  InformerEventSource<Deployment> source2 = new InformerEventSource<>(informer2, ...);

  eventSourceManager.registerEventSource("source1", source1);
  eventSourceManager.registerEventSource("source2", source2);
}

Using the same strategy in 2.1.1 produces an exception:
public List<EventSource> prepareEventSources(EventSourceContext<MyResource> context)
{
  SharedIndexInformer<Deployment> informer1 = client.apps().deployments()
    .inNamespace("ns1").withLabel("a", "b").runnableInformer(0);

  SharedIndexInformer<Deployment> informer2 = client.apps().deployments()
    .inNamespace("ns2").withLabel("a", "b").runnableInformer(0);

  return List.of(
    new InformerEventSource<>(informer1, Mappers.fromOwnerReference()),
    new InformerEventSource<>(informer2, Mappers.fromOwnerReference()));
}

java.lang.IllegalArgumentException: An event source is already registered for the (io.fabric8.kubernetes.api.model.apps.Deployment, io.javaoperatorsdk.operator.processing.event.source.informer.InformerEventSource) class/name combination
    at io.javaoperatorsdk.operator.processing.event.EventSourceManager$EventSources.add(EventSourceManager.java:216)
    at io.javaoperatorsdk.operator.processing.event.EventSourceManager.registerEventSource(EventSourceManager.java:107)

Is there an alternative way to implement this in v2?  This conversation implies it's still supported:
https://github.com/java-operator-sdk/java-operator-sdk/issues/827
Additional context:
The operator is configured to watch specific namespaces:
ControllerConfiguration<MyResource> baseConfig = DefaultConfigurationService.instance().getConfigurationFor(controller);
ControllerConfiguration<MyResource> config = ControllerConfigurationOverrider
    .override(baseConfig)
    .addingNamespaces("ns1", "ns2")
    .build();
operator.register(controller, config);

Environment:
Kube version 1.21
SDK version 2.1.1

hi @bearpaws , yes you have just to rename on of the event sources, there is a default name added, but the combination of name/type is unique. Just renaming one of the event sources should fix this.

More precisely, you need to override the name method in one of your event sources, for example by doing:
public List<EventSource> prepareEventSources(EventSourceContext<MyResource> context)
{
  SharedIndexInformer<Deployment> informer1 = client.apps().deployments()
    .inNamespace("ns1").withLabel("a", "b").runnableInformer(0);

  SharedIndexInformer<Deployment> informer2 = client.apps().deployments()
    .inNamespace("ns2").withLabel("a", "b").runnableInformer(0);

  return List.of(
    new InformerEventSource<>(informer1, Mappers.fromOwnerReference()),
    new InformerEventSource<>(informer2, Mappers.fromOwnerReference()) {
      @Override
      public String name() {
        return "informerFromNS2";
      }
    });
}

And it should also be exposed in the dependent resource configuration as well.

Thanks @csviri and @metacosm - overriding the name fixed it.  Yes, a constructor argument for the name would help to clarify.

Keeping this open to add the name to constructor and associated configuration

Closing this, since InformerEventSource supports more namespaces out of the box from 3.0


filetypes/File.h is missing

Project cannot be built because the file filetypes/File.h is missing.
Steps to reproduce:

Clone the repository
Attempt to build the project

Expected result: Project is built
Actual result: An error occurs:
Severity	Code	Description	Project	File	Line	Suppression State
Error		CMake Error at C:/Qt/6.5.0/msvc2019_64/lib/cmake/Qt6Core/Qt6CoreMacros.cmake:588 (add_executable):
  Cannot find source file:

    filetypes/File.h

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc		C:/Qt/6.5.0/msvc2019_64/lib/cmake/Qt6Core/Qt6CoreMacros.cmake	588

Forgot to remove these from the project. Re-download the repo.


Fix Windows NotImplementedError / Hanging of program

The ProxyBroker program will hang when the find command (at least, the only thing tested) is executed.
This PR allows proxybroker to be used on python 3.11.0 and returns some output.
3.12.0 does not work due to not being able to compile aiohttp not supporting 3.12

@ziloka awesome.
I see tests failed because they were testing aiodns. Would you mind update those tests to dnspython too?
BTW, can also add 3.11.0 into CI test python version. :smiley:

Relate to #113

I need to add a fix .
I don't think this works just yet, sorry

The program stops hanging but it is insanely slow.
Python 3.11 and python 3.12 will work but it will have (deprecation?) warnings about Transport Sockets.

I am unable to convert this into a "ready" pull request

We might want to look into this issue
https://github.com/aiortc/aioquic/issues/289

This pull request does not resolve the serve issue.
To fix that issue, I believe it is necessary to migrate from asyncio to trio.
See this stackoverflow comment for my reasons.
An additional reason is that the examples need to be updated and it would be inconvenient and unnecessary for applications who use this upstream to put
if sys.platform == 'win32':
    asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy())

In their code.
I would like to know the other maintainer's thoughts before making a merge for this.

Please look at this example


Set Up DockerHub Registry Push

Configures GitHub Actions Workflow to push to DockerHub Registry.
The following secrets are required and were set via the repository settings:

DOCKER_USERNAME - Docker User to login to for push
DOCKER_PASSWORD - Access Token for Docker User
DOCKER_ORGANIZATION - Organization to whom the Image Repository belongs (competemcgill organization created).

The following values were hard-coded for this repository:

IMAGE - Image Name to Build / Push to. Set to wisp-problems for now.

Workflow steps for deployment were left commented out for use in the future to complete our CI pipeline.

Question: I see that the images are tagged with Github SHA whenever they are build and pushed, but do we also want to tag them with "latest"? or is this already done by default?

Question: I see that the images are tagged with Github SHA whenever they are build and pushed, but do we also want to tag them with "latest"? or is this already done by default?

It's not - we could tag by latest too. For deployment, I think its best to reference to the specific Docker image (via SHA) though - if we're constantly overwriting the latest tag, I feel like its unnecessary room for error on deployment (but it might be useful for users, so I'll update this).

@idodin could we use the github short SHA as a tag instead of the full SHA?


Update library dependencies to avoid sbt eviction warnings

Using the latest 0.49.0-alpha version results in the following warning using sbt.
sbt:projectname> clean
[success] Total time: 0 s, completed 31.05.2018 22:50:18
sbt:projectname> compile
[info] Updating ...
[info] Done updating.
[warn] Found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[warn] 	* com.google.auth:google-auth-library-credentials:0.9.1 is selected over 0.9.0
[warn] 	    +- com.google.auth:google-auth-library-oauth2-http:0.9.1 (depends on 0.9.1)
[warn] 	    +- com.google.api:gax-grpc:1.25.0                     (depends on 0.9.1)
[warn] 	    +- com.google.cloud:google-cloud-core-grpc:1.31.0     (depends on 0.9.1)
[warn] 	    +- io.grpc:grpc-auth:1.10.1                           (depends on 0.9.0)
[warn] 	* com.google.code.findbugs:jsr305:3.0.1 is selected over {1.3.9, 3.0.0}
[warn] 	    +- io.grpc:grpc-core:1.10.1                           (depends on 3.0.0)
[warn] 	    +- com.google.api:gax-grpc:1.25.0                     (depends on 3.0.0)
[warn] 	    +- com.google.api:gax:1.25.0                          (depends on 1.3.9)
[warn] 	    +- com.google.http-client:google-http-client:1.23.0   (depends on 1.3.9)
[warn] 	    +- com.google.api:api-common:1.5.0                    (depends on 1.3.9)
[warn] 	    +- com.google.cloud:google-cloud-core:1.31.0          (depends on 1.3.9)
[warn] 	* com.google.guava:guava:20.0 is selected over 19.0
[warn] 	    +- com.google.api:gax:1.25.0                          (depends on 20.0)
[warn] 	    +- com.google.api:gax-grpc:1.25.0                     (depends on 20.0)
[warn] 	    +- com.google.cloud:google-cloud-core-grpc:1.31.0     (depends on 20.0)
[warn] 	    +- com.google.cloud:google-cloud-core:1.31.0          (depends on 20.0)
[warn] 	    +- com.google.auth:google-auth-library-oauth2-http:0.9.1 (depends on 19.0)
[warn] 	    +- io.grpc:grpc-core:1.10.1                           (depends on 19.0)
[warn] 	    +- io.opencensus:opencensus-api:0.11.0                (depends on 19.0)
[warn] 	    +- com.google.protobuf:protobuf-java-util:3.5.1       (depends on 19.0)
[warn] 	    +- io.grpc:grpc-protobuf:1.10.1                       (depends on 19.0)
[warn] 	    +- io.grpc:grpc-protobuf-lite:1.10.1                  (depends on 19.0)
[warn] 	    +- com.google.api:api-common:1.5.0                    (depends on 19.0)
[warn] Run 'evicted' to see detailed eviction warnings
[info] Compiling 51 Scala sources to /Users/tobscore/pathToProject/target/scala-2.12/classes ...
[info] Done compiling.
[success] Total time: 4 s, completed 31.05.2018 22:50:25

Adding the following line to any project's build.sbt, will cause the above warnings.
libraryDependencies += "com.google.cloud" % "google-cloud-speech" % "0.49.0-alpha"

I also tested this in a bare project with no other dependencies but this one.

@andreamlin you could probably solve this issue along with the release as well?

@TobsCore thanks for filing this issue! Would you mind using the latest 0.50.0 version? That hopefully would solve the jsr dependency issue.

@andreamlin hey, i just checked and it still showed the warning. I pushed my example project to github, so you can try it yourself/reproduce. It's just a simple Hello World project, but still. Here's the warning using the lates 0.50.0 version:
sbt:google-cloud-warnings> clean
[success] Total time: 0 s, completed 05.06.2018 17:35:56
sbt:google-cloud-warnings> evicted
[info] Updating ...
[info] Done updating.
[warn] Found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[warn] 	* com.google.auth:google-auth-library-credentials:0.9.1 is selected over 0.9.0
[warn] 	    +- com.google.auth:google-auth-library-oauth2-http:0.9.1 (depends on 0.9.1)
[warn] 	    +- com.google.cloud:google-cloud-core-grpc:1.32.0     (depends on 0.9.1)
[warn] 	    +- com.google.api:gax-grpc:1.27.0                     (depends on 0.9.1)
[warn] 	    +- io.grpc:grpc-auth:1.10.1                           (depends on 0.9.0)
[warn] 	* com.google.code.findbugs:jsr305:3.0.2 is selected over {1.3.9, 3.0.0}
[warn] 	    +- com.google.api:gax-grpc:1.27.0                     (depends on 3.0.2)
[warn] 	    +- io.grpc:grpc-core:1.10.1                           (depends on 3.0.0)
[warn] 	    +- com.google.api:api-common:1.6.0                    (depends on 1.3.9)
[warn] 	    +- com.google.cloud:google-cloud-core:1.32.0          (depends on 1.3.9)
[warn] 	    +- com.google.api:gax:1.27.0                          (depends on 1.3.9)
[warn] 	    +- com.google.http-client:google-http-client:1.23.0   (depends on 1.3.9)
[warn] 	* com.google.guava:guava:20.0 is selected over 19.0
[warn] 	    +- com.google.cloud:google-cloud-core-grpc:1.32.0     (depends on 20.0)
[warn] 	    +- com.google.cloud:google-cloud-core:1.32.0          (depends on 20.0)
[warn] 	    +- com.google.api:gax:1.27.0                          (depends on 20.0)
[warn] 	    +- com.google.api:gax-grpc:1.27.0                     (depends on 20.0)
[warn] 	    +- com.google.auth:google-auth-library-oauth2-http:0.9.1 (depends on 19.0)
[warn] 	    +- io.grpc:grpc-core:1.10.1                           (depends on 19.0)
[warn] 	    +- com.google.api:api-common:1.6.0                    (depends on 19.0)
[warn] 	    +- io.opencensus:opencensus-api:0.11.0                (depends on 19.0)
[warn] 	    +- com.google.protobuf:protobuf-java-util:3.5.1       (depends on 19.0)
[warn] 	    +- io.grpc:grpc-protobuf:1.10.1                       (depends on 19.0)
[warn] 	    +- io.grpc:grpc-protobuf-lite:1.10.1                  (depends on 19.0)

As you can see, i ran these commands from the sbt shell, but after cloning it, simply running sbt evicted in the console should display the same output.

Hi @TobsCore , are these just warnings or is this a blocker that prevents building your project? There are plans to resolve these dependency discrepancies.

@andreamlin, these are actually just warnings but this might still cause errors with certain flags set. But as there are plans to resolve this issue in the long run, this should be covered then.

@garrettjonesgoogle leaving this issue open to track the dependency management work

In case this helps you, there are at least two sbt plugins to help see whether fresher dependencies are available:

https://github.com/aiyanbo/sbt-dependency-updates
https://github.com/rtimush/sbt-updates

It's really tough updating dependencies across a bunch of repositories.  In this repository, we use Maven and do our best to update dependencies as they come along.  We also work with other dependencies of ours like io.grpc and io.opencensus to get them to upgrade their dependencies.  We will never be able to get all dependencies to upgrade in a similar way.
We have a bunch of issues like this, and we do our best to update specific issues as they come up.
I don't believe that there's anything actionable in this repository for this specific issue, but we'll continue upgrading dependencies and doing our best to get our dependencies to do the same.


Trying to add custom models but cannot run properly on Android

I am trying to add tinyllama chat to Android(Llama2 demo is a success) but failed. My operations are listed below:

Firstly, I add modeling_tinyllama.hpp in tools/jni and add some lines of code to LibHelper.cpp, also add marco TINY_LLAMA to PreDefinedModel in LibHelper.hpp

Then I add modeling_tinyllama.hpp to CMakeList.txt when building mllm_lib, run scripts/build_android_app.sh and got libmllm_lib.a in build-arm

In Android Studio(on Windows), replace libmllm_lib.a, and modify code in viewmodel:

val modelPath = when(modelType){
    0->"model/llama_2.mllm"
    1->"model/fuyu.mllm"
    2->"model/tinyllama.mllm"
    else->"model/llama"
}
val vacabPath = when(modelType){
    0->"model/vocab.mllm"
    1->"model/vocab_uni.mllm"
    2->"model/tinyllama_vocab.mllm"
    else->"model/vocab.mllm"
}

Finally change

// Chat(navController, it.arguments?.getInt("type") ?: 0)
Chat(navController, 2)

The result shows that the tinyllama can be successfully loaded but never output any char. Is there any mistake in my procedure, or wrong code in files? Code is attached. Thanks for your help.

Look into it....

Seems cool in codes.
Could u check if there is any ERROR in logcat? maybe tagged with "MLLM" or other related things.

Sorry, I haven't found anything useful in logcat...
For llama2, the log tagged with MLLM is
Setup!
param size:291 // 201 for tiny
MODEL TYPE:0 // 2 for tiny
tokenizer size:31902

which means the try catch in JNIBridge.run never catches exception.
And tag "chatViewModel" are the same for llama2 and tiny, both "files:0", but I am wondering what does the param size indicates, it seems not to be the disk occupancy. Besides them, the annoying "BLASTBufferQueue" occupies the window.
p.s. I forget to tell you that I also add TINY to PreDefinedModel in LibHelper.hpp in Android Studio, although it may not matter.

That's weird... I may need some time to reproduce the scenario.
BTW you are using the Q4K tinyllama weights from our HF right?

Yes, the weights (tinyllama-1.1b-chat-q4_k.mllm) are downloaded from your HF and renamed, and the vocab is from this repo.

Maybe my codes are never executed?...
I add LOGI to run function in LibHelper.cpp, run build_android_app.sh and replace libmllm_lib.a.
...
    for (int step = 0; step < max_step; step++) {
        unsigned int token_idx;
        if (model_ == FUYU) {
            LOGI("Image Patch!");
            executor_->run(net_, {input_id, img_patch, img_patch_id});
            auto result = executor_->result();
            token_idx = postProcessing(result[0], input_id);
            fullTensor(img_patch, net_, {0, 0, 0, 0}, 1.0F);
            fullTensor(img_patch_id, net_, {0, 0, 0, 0}, 1.0F);
        } else {
            executor_->run(net_, {input});
            auto result = executor_->result();
            token_idx = postProcessing(result[0], input);

/*new*/
            LOGI("MLLM TINY token_idx:%d", token_idx);
/*new*/

        }
        const auto out_token = tokenizer_->detokenize({token_idx});

/*new*/
        LOGI("MLLM TINY out_token:%s", out_token.c_str());
/*new*/

        if (out_token == "</s>" || token_idx == eos_id_) {
            callback_(out_string, true);
            break;
        }
        out_string += out_token;
        callback_(out_string, step == max_step - 1);
    }

However neither tiny nor llama2 output these tags. I am doubting whether my previous operations are correct.

Hi, I managed to set up the env and succeedfully run the model.
I think there may be several things to note:

Check the sendMessage fun(ChatViewModel.sendMessage) We add a double check here.[Actually we do not expect any new model in our Demo App...so terribly sorry😭]

if (arrayOf(0,2).contains(modelType.value)){
//            if (modelType.value == 0){
                CoroutineScope(Dispatchers.IO).launch {
//                val run_text = "A dialog, where User interacts with AI. AI is helpful, kind, obedient, honest, and knows its own limits.\nUser: ${message.text}"
                    JNIBridge.run(bot_message.id,message.text,100)
                }
            }

Check if any switch-case expression in LibHelper.cpp is ended with break; properly.

Thank you so much! The model now can run properly.

Thank you so much! The model now can run properly.

Glad to hear that! You can also make a pull request about this feature if you like so other can benefit too 😘


CI runs are flaky

Currently, CI runs on master are flaky and need a couple of restarts to finish properly

There might be a couple of underlying issues but so far I think the main issue is that if multiple benchmarks run concurrently and write results to the same place they might use a different version as a base to generate the changes and a different one to compare the changes to (the latter might have already been modified by another benchmark run)
The solution to this still needs some investigation

fixed by #215 and #216

fixed by #215 and #216


Nuget upgrade failed

HI Guys
I just upgraded from 3.0 to 3.1 just now using Nuget. Now the compressor wont run in the IDE.
I get this error:
The "RequireCompressorTask" task could not be loaded from the assembly C:\Users\gregv\Source\Repos\SquashSpider\SquashSpider\SquashSpider.build...\packages\RequireJsNet.Compressor.3.1.0\tools\RequireJsNet.Compressor.dll. Could not load file or assembly 'file:///C:\Users\gregv\Source\Repos\SquashSpider\SquashSpider\SquashSpider\packages\RequireJsNet.Compressor.3.1.0\tools\RequireJsNet.Compressor.dll' or one of its dependencies. The system cannot find the file specified. Confirm that the  declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.
I have a .build directory and I originally set it up using the instructions on the web site when it was 2.2. The instructions are still there. I don't know if they are still accurate or not. The instructions refer explicitly to version 2.2, which isn't installed. I changed the path to the new file but that's when I get this error.
Any suggestions?
The Compressor.targets file in the .build directory looks like this:
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <UsingTask TaskName="RequireCompressorTask" AssemblyFile="...\packages\RequireJsNet.Compressor.3.1.0\tools\RequireJsNet.Compressor.dll" />
  <ItemGroup>
    <Configs Include="$(_PackageTempDir)\RequireJS.json" />
    <Content Include="RequireJS.json">
      <Visible>false</Visible>
    </Content>
  </ItemGroup>
  <Target Name="RequireJsNetCompressor" AfterTargets="CopyAllFilesToSingleFolderForMsdeploy">
    <RequireCompressorTask
      LoggingType="Debug"
      RequireConfigs="@(Configs)"
      AutoCompressor="true"
      EncodingType="UTF8"
      ProjectPath="$(_PackageTempDir)"
      PackagePath="$(_PackageTempDir)\Scripts\" />
  </Target>
</Project>

You can close the issue if you want. I got up and running again by deleting the file that was in the .build folder. I guess it isn't needed anymore.


Font customization

This is half question, half feature request. I was trying to change the font but that turned out to be a lot more difficult than I thought.
The font is hardcoded both in site_head.html and in tailwind.config.js. So I ended up doing something inspired by these two articles [1] [2]. I cloned site_head.html into my project and changed it as follows:
diff --git a/layouts/partials/site_head.html b/layouts/partials/site_head.html
index a76283f..d24df40 100644
--- a/layouts/partials/site_head.html
+++ b/layouts/partials/site_head.html
@@ -10,7 +10,13 @@
   <link rel="icon" type="image/svg+xml" href="{{ "images/favicon.svg" | relURL }}" />
   <link rel="icon" type="image/png" href="{{ "images/favicon.png" | relURL }}" />
   <link rel="apple-touch-icon" sizes="180x180" href="{{ "images/apple-touch-icon.png" | relURL }}" />
-  <link rel="preload" href="/fonts/Inter-roman.var.woff2" as="font" type="font/woff2" />
+  {{ if .Site.Params.customFonts -}}
+    {{ range .Site.Params.customFonts -}}
+    <link rel="preload" href="{{ . | relURL }}" as="font" type="font/woff2" />
+    {{- end -}}
+  {{- else -}}
+    <link rel="preload" href="/fonts/Inter-roman.var.woff2" as="font" type="font/woff2" />
+  {{- end }}
   <meta name="description" content="{{ with .Description }}{{ . }}{{ else }}{{ with .Site.Params.description }}{{ . }}{{ end }}{{ end }}" />
   {{ hugo.Generator }}
   {{ if .Params.private }}
@@ -22,6 +28,11 @@
   {{ partial "opengraph.html" . }}
   {{ $css := resources.Get "/css/styles.css" | resources.PostCSS (dict "inlineImports" true) | resources.Minify | resources.Fingerprint }}
   <link rel="stylesheet" href="{{ $css.RelPermalink }}" />
+  {{ if .Site.Params.customCSS -}}
+    {{ range .Site.Params.customCSS -}}
+    <link rel="stylesheet" href="{{ . | relURL }}" />
+    {{- end }}
+  {{- end }}
   {{ $js := resources.Get "js/main.js" | js.Build (dict "minify" true) | resources.Fingerprint }}
   <script src="{{ $js.RelPermalink }}" defer></script>
 </head>

That allowed me to add a custom CSS …
@font-face {
  font-family: "Switzera";
  font-weight: 100 900;
  src: url("../fonts/switzera-regular.woff2") format("woff2");
}

html {
  font-family: "Switzera";
}

… and enable it and a custom font in my hugo.yaml:
params:
  defaultTheme: dark
  customCSS:
  - css/custom.css
  customFonts:
  - fonts/switzera-regular.woff2

This works but it's not terribly elegant and there are still traces left of the original Inter font despite it not being used.
I haven't delved into TailwindCSS yet and maybe there's some magic to be performed there. But is there a better way to do things? Perhaps something could be added to the theme to make changing fonts the easy task it should be?
PS: This particular issue aside, I love the theme and it was amazingly easy to get great-looking results with little effort. So thanks a lot for your work!

I think adding customization parameters would bloat the theme too much, this is why it is very opinionated ;-) (But this makes it easy to extend or modify)

Copy the font files to ./static/fonts. I found the OTF versions on fontlibrary.org, so for my test this would be something like this:

./static/fonts/SwitzeraADFRegular.woff2
./static/fonts/SwitzeraADFDemiBold.woff2

Copy the theme's assets/css/styles.css to your /assets/css/styles.css and motify the @font-face directives:

./assets/css/styles.css:

@font-face {
  font-family: "Switzera";
  src: url("../fonts/SwitzeraADFRegular.otf")
    format("opentype");
  font-weight: normal;
  font-style: normal;
}

@font-face {
  font-family: "Switzera";
  src: url("../fonts/SwitzeraADFDemiBold.otf")
    format("opentype");
  font-weight: bold;
  font-style: normal;
}

@tailwind base;
@tailwind components;
@tailwind utilities;
...

Copy the theme's tailwind.config.js to your site root, and change the Inter var to Switzera so Tailwind CSS will use the Switzera font.

Copy the theme's site_head.html to your ./layouts/partials/site_head.html and change the preload paths:

...
<link rel="preload" href="/fonts/SwitzeraADFRegular.woff2" as="font" type="font/woff2" />
<link rel="preload" href="/fonts/SwitzeraADFDemiBold.woff2" as="font" type="font/woff2" />
...

That should be pretty much it.

Thanks! Your solution works well. I wouldn't say the duplication of the Tailwind CSS config and the theme's CSS file makes it particularly elegant, but I understand the desire to keep bloat minimal. It's always a trade-off between adding features on the "library" side and duplicating functionality on the "consumer" side, though, and often the theme authors are in a better position (architecture, expertise) to do so. Anyway, themes deserve to be opinionated and I respect that. :-)
It might be nice to have a section in the README.md with "non-features", i.e. features that are purposely not part of the theme but have a solution in the issue section, similar to the Folders with no images section.
One last thing: I noticed that the dev tools console reports an error, even on the official example website:

preload for 'https://hugo-gallery-example.netlify.app/fonts/Inter-roman.var.woff2' is found, but is not used because the request credentials mode does not match. Consider taking a look at crossorigin attribute.

Adding a crossorigin="anonymous" attribute to the font preload did the trick for me:
<link rel="preload" href="/fonts/Inter-roman.var.woff2" as="font" type="font/woff2" crossorigin="anonymous" />

There's some detail here.


Pascal Evaluation

Hi @chenhsuanlin , thanks for the great work! I have few questions about your Pascal evaluation. I realize you mentioned in the paper that you applied ICP for Pascal pointcloud comparison but not shapenet. I'm wondering what's the specific reason for using ICP on Pascal? Also is the segmentation masks you are using the unoccluded version from mesh projection?
Thanks!

You're correct about the segmentation masks -- we treat them as the input silhouettes in this case.
Since the actual data for training SDF-SRN is cropped from the raw image data with the provided 2D bounding boxes, the resulting 3D shape prediction (aligned with the 2D masks) would (most likely) not live in the same canonical space as the ground-truth CAD model; in other words, there would be an unknown (but rather small) translational offset between ground truth and prediction. For this reason, we run ICP to align them together for evaluation. We don't need ICP for evaluating ShapeNet because we already know the images are rendered from the CAD models in the same canonical space.
Hope this helps!

Thanks for the prompt reply!
I'm still a litttle bit confused though. When you say cropping, does that also includes resizing? I think if it's only cropping you could do a translation in the shape space to recover the canonical shape right? Resizing does kinda make sense to me, but I still feel that you could recover that by resampling the points for marching cubes. Please let me know if I miss something here :)
Another thing I'm wondering is that you mentioned the weak perspective camera model is used in the paper, is the scale annotated already by the dataset or you learn it instead?

Sorry that I didn't look into the code carefully before, I realized you are using an orthographic camera where the size is dependent on the input. In this case, I guess there will be a size mismatch between the pascal annotation and the predicted shape as ICP won't deal with scaling (pls correct me if I am wrong). Could you please slightly provide some thoughts on this for evaluation? I see that you do something specifically for car cropping, not sure if this is relevant. (pls ignore my previous comment as I didn't take the size issue into consideration, which seems to make perfect alignment impossible anyway)

Sorry for the late reply. Since we don't know (just from the images) where the actual 3D center of the objects are defined, we can only heuristically normalize them by centering them with the bounding box. There will still be some translational misalignment, and that's why we run ICP when comparing pred/GT shapes.
For scale, weak perspective camera models can be thought of as orthographic cameras + scale handling. So yes, we do use the distance of the camera to the objects but only for evaluation purposes -- they are not given during the training process. You can find more details in Section B.2 of the supplementary document.
The car cropping part isn't too relevant here, it's just a different way of rescaling the objects (assuming they have a common height) before centering them in the image.
Hope this helps!

Thanks for the reply, looks like I misunderstood the train/eval pipeline of your method. Based on what you said and the supplementary document, I guess for training, you use an orthographic camera without scaling. But because input/mask has been normalized with bounding box, you could roughly say that the reconstructed shape is canonical in [-1,1]^3. And during evaluation, the gt shape from pascal3D is the fixed-scale canonical shape (idk the range though, based on 2/64, is it [-32,32]?) and thus so are the scanned pointclouds. Then for every sample you would rescale the pointcloud with cam_dist/f of this sample and thus it lies in [-1,1]^3 as well. To make the predicted and gt point more aligned you use ICP. Is all this correct?
If so, I assume the success of evaluation lies in the fact that the object is sphere-like (i.e. lead to similar sized 2D bounding boxes from different angles during training). Then for cars, height*3 is like the heuristic that you find would lead to a rough [-1,1]^3 shape (by hypothesizing gt car CADs have all similar heights around 0.67), right?

Yes, this all looks reasonable to me! Indeed the underlying assumption is that the objects are "sphere-like" and are observed from different viewpoints (looking into the objects) across the dataset. Since we don't have a principled way of rescaling with respect to the actual 3D ground truth during training, we do need to rely on some sort of heuristics for 2D rescaling.

Got it this makes sense, thanks!

Hi @chenhsuanlin , another quick question, I didn't seem to find the definition of chamfer distance you used in your paper. Could you please provide the detailed formula? The Chamfer distance people use often differs in details, so I want to understand your number in a better sense... Thank you!

Hi @stalkerrush, here's a definition of the "uncombined" (unidirectional) Chamfer distance I used for evaluation:

S1 = prediction and S2 = ground truth for shape accuracy, and vice versa for surface coverage (completeness). Note this metric is not squared (opposed to being used as a loss function for optimization), as it measures the average 3D Euclidean distance.
Please also see Sec 1.4 of the supplementary document of DVR, which has a very nice description of the metric, as well as discussions on their definition (autonomousvision/differentiable_volumetric_rendering#10).

Thanks for the reply, it makes sense now. I saw you also did the 10x multiplication, so the only difference to DVR is that you sampled 30000 instead of 100000 on gt, right?

Yes that's right 🙂

Got it thanks!


Module not found: Can't resolve '@/components/ui/accordion'

I am using expo react-native and followed the installation steps listed here
https://ui.shadcn.com/docs/installation. Not sure what I am missing here.
AssetRegistry.js:13  Uncaught Error: Cannot find module '@/components/ui/accordion'
at webpackMissingModule (AssetRegistry.js:13:1)
at ./src/components/Dashboard.jsx (AssetRegistry.js:13:1)
at webpack_require (bootstrap:24:1)
at fn (hot module replacement:62:1)
at ./App.js (bundle.js:19:83)
at webpack_require (bootstrap:24:1)
at fn (hot module replacement:62:1)
at ./node_modules/expo/AppEntry.js (WebBrowser.types.ts:192:1)
at webpack_require (bootstrap:24:1)
at startup:6:1

Under the hood, react native renders mobile native components that you would have used while coding in the native language on the platform.
https://reactnative.dev/docs/libraries#determining-library-compatibility

I am getting same error for Next.js I followed https://ui.shadcn.com/docs/installation/next

Same here. Followed the steps.

@MarkiyanPyts @cloudders-cloud I meet a similar error as well following the nextjs doc as well, turns out there's a typo in the doc, I bring a PR to fix that part https://github.com/shadcn-ui/ui/pull/1027
you need to import button component this way
import { Button } from "@/components/ui/button"

Fixed in #1062

S

@MarkiyanPyts @cloudders-cloud I meet a similar error as well following the nextjs doc, turns out there's a typo in the doc, I bring a PR to fix that part #1027
you need to import button component this way
import { Button } from "@/components/ui/button"

Same issue still exist

You might end up here if, like me, you're trying to set up path redirection in tsconfig.json, but your app is setup with Create React App.
In that case, you can't configure the proper path redirections because of how it configures Webpack. So to solve this, you need to rewire it someone and override its webpack config. Here is how:
https://plusreturn.com/blog/how-to-configure-a-path-alias-in-a-react-typescript-app-for-cleaner-imports/

Why is the shadcn community okay with such a vague important path that is problematic out of the box?
import { Button } from "@/components/ui/button"
from @/components looks like a very bad naming convention
I'm just trying to follow the tutorial for installing shadcn to render a button in a blank app and I'm running into this import issue:
Cannot find module '@/components/ui/button' or its corresponding type declarations.ts(2307)
Why does this need to be overly complicated with custom path aliases?

Why is the shadcn community okay with such a vague import path that is problematic out of the box?
import { Button } from "@/components/ui/button"
from @/components looks like a very bad naming convention
For the sake of everyone's sanity, just use a modern standard naming convention for imports like
import { Button } from "@shadcn-ui/components/ui/button"
I'm just trying to follow the tutorial for installing shadcn to render a button in a blank app and I'm running into this import issue: Cannot find module '@/components/ui/button' or its corresponding type declarations.ts(2307)
I'm not using webpack, just a simple Vite react app and this is problematic.
Why does this need to be overly complicated?

I have the same problem, is over complicated to get a simple button in a page.

I cannot get this to work

I cannot get this to work

I finally have a solution.
First, change the reference in json file (components.json) from @ to components.
Second, run again npx shadcn-ui@latest init the menu will ask again some options, answer in the same way as the first time.
Now the reference should be working well, components will be in /components/ui, if fails, just check the PATH inside the component used to Utils file.

@kevincompton and everyone who is having this issue:
You need to add components manually using npx shadcn-ui@latest add COMPONENTNAME
Some examples: npx shadcn-ui@latest add textarea or npx shadcn-ui@latest add button


Add placeholder color utilities

This PR adds new placeholder-{color} utilities for setting the placeholder color of form elements, with responsive and focus variants enabled by default.

You are awesome! Thanks you!


Inconsistent view of elements across different sources

First of all, thanks for this great plugin. I really think that it makes a lot of sense to have such generic view for tree-like data structures. I have plenty of ideas what to integrate next but first I need to get familiar with the basics, hence my migration from nvim-tree.
I modified file and directory renderers slightly to my liking but I noticed that my modifications look inconsistent across different sources.
File source:

Buffer source:

Git source:

Code for renderes:
renderers = {
            directory = {
                { "indent" },
                { "icon" },
                { "current_filter" },
                {
                    "container",
                    content = {
                        { "name",       zindex = 10 },
                        { "clipboard",  zindex = 10 },
                        { "git_status", zindex = 10, hide_when_expanded = true },
                        {
                            "diagnostics",
                            errors_only = true,
                            zindex = 20,
                            align = "right",
                            hide_when_expanded = true
                        },
                    },
                },
            },
            file = {
                { "indent" },
                { "icon" },
                {
                    "container",
                    content = {
                        { "name",        zindex = 10 },
                        { "clipboard",   zindex = 10 },
                        { "bufnr",       zindex = 10 },
                        { "git_status",  zindex = 10 },
                        { "modified",    zindex = 20, align = "right" },
                        { "diagnostics", zindex = 20, align = "right" },
                    },
                },
            },
        }

I also have a name component modified:
    name = {
       use_git_status_colors = false,
    }

neotree rev: 205184aa0e0f08e8a1249d9bb37b45bae85f01b9

The only difference I can see here is how the directory structure is displayed on the file source vs the git and buffer source. Am I missing something?

Sorry, my description was incomplete.
Here is a list of differences:

As you noticed the directory structure differs between the git source and buffer source. In the buffer source multiple directories are collapsed into a single node, while in git source every directory is its own node
Even though the use_git_status_colors was disabled entries in buffer and git sources have the color applied
Spacing between the file name and git status icon is different between file and git source

That makes sense, thanks for clarifying!

This is almost certainly intentional. As a file browser, the user may want to modify any of the in between directories on tree and as such, they should all be exposed as their own nodes (IE uncompressed). I don't know what setting would need to be modified for this, but IMO it should not be changed as it makes sense within the context of a "File Browser"
Totally missed that. That's strange, I would imagine use_git_status_colors would do exactly what its name implies. I'll take a peek this afternoon and see if I can figure out why this didn't work "as expected", though I may come back with 🤷♂, I am not that familiar with the codebase.
Ya I am not super fond of this, IMO icons should all line up the same regardless of source. My best off the cuff guess is that the git source is using or overriding different components to display its nodes. I'll poke that a bit as well and see what I can find out.

@miversen33 regarding 2, git_status and buffers override the name component, so I think that's what causes this. For 3, I think it is because some calculation with the padding, which could also stems from this override.

@nhat-vo

Regarding 2, git_status and buffers override the name component, so I think that's what causes this.

Is this how it should be? I couldn't find any settings for that in https://github.com/nvim-neo-tree/neo-tree.nvim/blob/v2.x/lua/neo-tree/defaults.lua I think that it is confusing that users are supposed to configure default_component_configs when in the end these values are not used.
@miversen33

This is almost certainly intentional. As a file browser, the user may want to modify any of the in between directories on tree and as such, they should all be exposed as their own nodes (IE uncompressed). I don't know what setting would need to be modified for this, but IMO it should not be changed as it makes sense within the context of a "File Browser"

Right, this makes sense. There is filesystem.group_empty_dirs options which does that. And for the buffer source there is indeed no reason not to group directories. However, it seems that group_empty_dirs could be also exposed for the git source, wdyt?

However, it seems that group_empty_dirs could be also exposed for the git source, wdyt?

I did not even realize the git source was not grouping them lol. I don't personally see an issue with adding that configuration option though I don't know the amount of work that would go into respecting it. That is likely more an @nhat-vo or @cseickel question. I don't have alot of experience in making modifications to the codebase, more so troubleshooting stuff :)
Anyway! So onto the item I said I would look into.
Taking a peek at #421, it looks like this option should go under default_component_configs.name EG
default_component_configs = {
    name = {
        use_git_status_color = false
    }
}

I can confirm that setting this here removes the git config
With the setting disabled

And with the setting enabled

I will take a look at the third point later tonight, I haven't spent much time looking at the git source

@miversen33 I agree that configuring use_git_status_color like that works for the filesystem source. My problem is that it doesn't work for the other sources. Unless what you showed is the git source, then I am confused why it doesn't work for me.
Here is my configuration https://github.com/ghostbuster91/dot-files/blob/neotree/programs/neovim/config/lua/local/neotree.lua#L45

Sorry for the ambiguity 😅.

Regarding 2, git_status and buffers override the name component, so I think that's what causes this.

What I meant here was that currently, git_status and buffers sources are overriding the default name component, and they do not take into account the use_git_status_colors config. Just pushed #864 to fix this. Feel free to have look to see if it fixes your problem. (Side note: it is currently a PR, so you can check it out by using
    -- 'nvim-neo-tree/neo-tree.nvim' -- change this
    {'nhat-vo/neo-tree.nvim', branch = '859-components'},  -- with this

kudos to @miversen33😁)
Regarding point 3, I'm planning to refactor the padding logic to avoid these kinds of missing/redundant padding behavior. This is a bit more complicated, so I'll add this to the PR later.
Regarding point 1, #832 and #833 also refers to this config, so I think it's best to have someone work on these 3 later.

No worries. That is all actually clear, my answer was regarding the screenshot from @miversen33.

Regarding point 3....

Awesome 👍

Regarding point 1, #832 and #833

Yeah, I also saw them because I wanted to report the same things 😅
Thank you both for explaining all of that to me and working on that. Much appreciated 🙏

@miversen33 I agree that configuring use_git_status_color like that works for the filesystem source. My problem is that it doesn't work for the other sources. Unless what you showed is the git source, then I am confused why it doesn't work for me.
Here is my configuration https://github.com/ghostbuster91/dot-files/blob/neotree/programs/neovim/config/lua/local/neotree.lua#L45

Ahh my bad I didn't check the git source when I did my test. It sounds like @nhat-vo is addressing that though, good catch both of you :)

I am going to close it. The main issue about inconsistency between views has been fixed by #864 .
My point about exposing group_empy_dirs for git source is in general valid but after some consideration I decided that I like the current way of displaying things more.


Remove unneeded 'chrome=1' X-UA-Compatible meta tag

This was only ever needed for a really old Chromeframe plugin for old IE and was discontinued by Google long ago.

Thanks for these, but at least one of these are coming from other modules (/dcos is a Git sub tree), and it would be too much work to push forward the changes. I would appreciate if patches to the theme is added to https://github.com/gohugoio/gohugoioTheme etc.


Feature/renaming

Resolves #4
Renaming to use a consistent 'modal' / 'simpleModal' name convention. Dialog is an implementation detail. The only dialog reference left in is one for accessibility role='dialog'

Tbh I'm with you, once in style block it's incredibly hard to override
other than using more JS.
On 29 Nov 2017 18:08, "Celso Trindade"<EMAIL_ADDRESS>wrote:

@celsomtrindade commented on this pull request.
In src/simple-modal-holder.component.ts
https://github.com/KevCJones/ngx-simple-modal/pull/5#discussion_r153869183
:

}

setTimeout(() => {

 modalWrapper.wrapper.nativeElement.classList.add('show');

 modalWrapper.wrapper.nativeElement.classList.add('in');

});
if (options.autoCloseTimeout) {

 setTimeout(() => {

   this.removeModal(_component);

 }, options.autoCloseTimeout);

}
if (options.closeByClickingOutside) {

 modalWrapper.onClickOutsideModalContent( () => {

   this.removeModal(modalWrapper.content);

 });

}
if (options.backdropColor) {

I must reinforce that this is just my personal preference and opinion.
In this case, I'm against any type of style control via options. I think
the style belong to the css, where it can be better integrated with the
general styleguide of each individual project without the need to change a
hex color, for example, in the javascript if it changes in the css. What if
I want a background color with transparency of 0.54? Maybe there will
have to be another option to use in conjunction with the backdropColor,
wich adds unecessary complexity to the code, when it's easily done in plain
css.
It's better to maintain where it belongs. I can provide an initial css
that is easy to understand and personalize.
I think the options should be related to modal behavior only, such as
closing by escape key, click outside, max number of modal open at the same
time, etc..
And again, just my preference. If theres is a better argument to why we
should keep it in the js, let's do it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/KevCJones/ngx-simple-modal/pull/5#discussion_r153869183,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqe8CjTFrdg_ipO63l8ICkY3-3DY51lks5s7Z2OgaJpZM4QvSvi
.

Then I think it's good to go! There is a lot of improvements on this code already!


Fix licensing typo & context window typo

• Storywriter is not commercially viable
• 65k not 64k context window for storywriter

Closing with "won't fix."
The license on the model is Apache 2.0.
65k vs. 64k depends on whether you count in base 2 or base 10.


Composer Update from Laravel 6.6.0 to 6.6.1 causes UrlGenerationException

Describe the bug
An upgrade of Laravel from 6.6.0 to 6.6.1 generates a UrlGenerationException.
Illuminate\Routing\Exceptions\UrlGenerationException
Missing required parameters for [Route: stancl.tenancy.asset] [URI: tenancy/assets/{path}].

Illuminate\Routing\Exceptions\UrlGenerationException::forMissingParameters:17
vendor/laravel/framework/src/Illuminate/Routing/Exceptions/UrlGenerationException.php:17

<?php

namespace Illuminate\Routing\Exceptions;

use Exception;

class UrlGenerationException extends Exception
{
    /**
     * Create a new exception for missing route parameters.
     *
     * @param  \Illuminate\Routing\Route  $route
     * @return static
     */

    public static function forMissingParameters($route)
    {
        return new static("Missing required parameters for [Route: {$route->getName()}] [URI: {$route->uri()}].");
    }
}

Steps to reproduce
composer update
Your setup

Laravel version: 6.6.1
stancl/tenancy version: 2.2.1

Hi. Thanks for reporting this. Fix should be on packagist in a few minutes.

Tagged 2.2.2.


feat: providing build flow

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Test config files

Added test config files to separate configuration & actual tests.

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           4      5    +1
  Lines          41     42    +1
  Branches        4      4
=====================================
+ Hits           41     42    +1

Impacted Files
Coverage Δ

enzyme.config.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5926614...9946be7. Read the comment docs.


TypeError: publish_event() got an unexpected keyword argument 'topic_name'

Expected Behavior
I wanted pub/sub sample from /examples/pubsub-simple.
Actual Behavior
When starting publisher.py with
dapr run --app-id python-publisher --app-protocol grpc python3 publisher.py
I get
== APP == Traceback (most recent call last):

== APP ==   File "publisher.py", line 21, in <module>

== APP ==     resp = d.publish_event(

== APP == TypeError: publish_event() got an unexpected keyword argument 'topic_name'

Steps to Reproduce the Problem

Ubuntu 20.10
install Dapr CLI with wget -q https://raw.githubusercontent.com/dapr/cli/master/install/install.sh -O - | /bin/bash
dapr init
Python 3.8.6
pip install dapr 1.0.0rc2
pip install dapr-ext-grpc 1.0.0rc2
clone repo and start publisher.py

same with

Ubuntu 20.04 on WSL2
Python 3.8.5
pip install dapr 1.0.0rc2
pip install dapr-ext-grpc 1.0.0rc2

same with

Ubuntu 20.04 on WSL2
Python 3.8.5
pip install dapr 1.0.0rc2
pip install dapr-ext-grpc 1.0.0rc2

my mistake - wrong SDK version

my mistake - wrong SDK version


Code compatibility with CadQuery Editor

This is now a meta issue that lists all steps required for CadQuery Editor compatibility:

[x] #8
[x] #34
[x] #35
[x] #36

Highlighting some ways in which you may wish to match the CQ-editor experience:

debug() is red with alpha 20% (you guesstimated 50% above): source

There are several globals injected when running the code: source

If show_object() isn't called then globals are searched for workplanes: source

fixed in 09b0360


Fix UI resizing

Fixes #83.

Enforces new minimum width of main window.
Sets components to grow with containers.

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #84   +/-   ##
=========================================
  Coverage     74.53%   74.53%
  Complexity      506      506
=========================================
  Files            83       83
  Lines          1520     1520
  Branches        156      156
=========================================
  Hits           1133     1133
  Misses          352      352
  Partials         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e870e4b...d8d0ed8. Read the comment docs.


Anonymous API implementation

It includes the client and server side API, support data structures, implementation of the server side and a simple test using typed async client and anonymous server to finish one simple rpc.
it still needs:
client side implementation
more tests (and leak free)

This is not ready for merging but should be pretty close.
@a11r for API review
@fengli-google for API preview
@vjpai do you want to do the (future) code review?

Yang, just wanted to confirm that you can give the PR to me when it is ready. Let me know.

@vjpai I still need to add several more tests but this is ready for review now. Thanks!

I added a few comments. The code and choices therein look good to me overall. Is there any desire to have a sync generic service? Given that the generic service is only async now, should the API names actually explicitly say that like they do for the other async calls?

I have changed the names related to the service from Generic to AsyncGeneric, and s/GenericServerReaderWriter/GenericServerAsyncReaderWriter/ in the same spirit. The stub class name and the test class name do not need to be changed I think. PTAL