Implement testing in React 0.14, 15, 16, add wallaby.js, use enzyme

This pull request uses enzyme to equalize most tests across all React versions.
Tests that need special handling:

should enforce a single child - the error text changed from 0.14 to 15 [Provider.spec.js]
works in <StrictMode> without warnings (React 16.3+) - the test is only run in newer React, and uses the test renderer (enzyme does not support React 16.3+ yet) [both Provider.spec.js and connect.spec.js]

All other tests that used the test renderer have been moved to enzyme with minor syntax changes, and no change to functionality.
There are two significant differences with enzyme:

Any change to the tree requires a manual .update() on the root element, or tests won't be able to detect changes
Tests that used stub to save a deep part of the rendered tree failed, because enzyme creates new object wrappers around the internal React elements when update() is called, so those had to be replaced by the original call in order to work.

Otherwise, it was simply find/replacing TestRenderer.create with enzyme.mount and then testRenderer.root.findByType with testRenderer.find and all checks of blah.props.name with blah.prop('name')
Travis is set up to run a matrix of tests, using React 0.14, 15, 15.4, latest 15 (15.6), 16.2, 16.3, 16.4 and I added local testing for each version with commands like npm run test:15 and npm run test:14
This is based on the code from enzyme-adapter-react-helper but modified because I don't think they ever actually really tested it with React 0.14 :). This code actually works.
CAVEAT: 12 tests fail in React 16.4. #980 is designed to fix them, so if the two requests are merged all tests should pass again. The important thing will be to re-base #980 on this pull request to see if the changes do break earlier React versions, once this pull request is accepted.
CC: @markerikson @timdorr

I dunno, this seems like a lot of complexity for something that's not likely to break any time soon.
4.x/5.x will continue to support React 0.14-16.3, and those versions of React aren't going to change (outside of some huge security thing). The plan is to make whatever we release next dependent on React 16.4, so testing on old versions is irrelevant. It's nice to confirm our guarantees, but it seems pretty expensive to do so.

Perhaps we view expense differently. We probably want 5.x to continue to work in new versions of React, and if we need to make changes as dramatic as the gDSFP bugfix, we will want to make sure that our users with massive legacy apps continue to work. I think it would be very expensive if a new 5.x version is released that breaks on react 15, and there is no test suite that can be used to verify a fix. No?
It took me about 20 minutes to convert the tests, and about 40 minutes to tweak getting 0.14 test environment to make it work. But it's not actually that complex.
What are you afraid will happen? The PR doesn't actually introduce any complexity to the tests, it just makes it possible to run them in different environments.

Ok. How do YOU intend to test any changes to react-redux against react 14 and 15?

I'm going to be blunt. Tim, you're not being helpful. Stop it. It is obvious to you and me and everyone paying attention that this test suite will simply make it possible to test bug fixes against the actual react versions that react-redux claims to support. Are you suggesting that faith is the proper testing approach?
Once master goes to react 16.4+, the complexity can be stripped and left in a 5.x branch for any necessary bug fixes. It won't scare away users because npm test actually does work.
 The bug still exists in latest npm.

OK, I'm going to bow out of this PR. To be clear: I'm not critiquing you, the human being behind the keyboard, I'm attempting to critique the code. But it seems like I've struck a nerve here on a personal level, so I'd rather not continue to stoke that fire.

Oh come on, you can accept a critique if you can give it :).
Here is my challenge: I clicked the checkbox next to "allow maintainers to make edits" a

This: https://github.com/npm/npm/issues/16839#issuecomment-305351096 is what was happening when I used --no-save. However, I was able to fix the issue because npm will not uninstall deps if it is within a single install command. So by merging the 2 calls to npm install into 1, we can again use --no-save.
In addition, the tests were changing our node_modules environment (by necessity) and now using the new run-tests.js file, we can properly restore them by running "npm i" after jest concludes, regardless of whether jest fails or not.
This does NOT address the question of whether this is too complex for contributing users to run tests. I updated the docs and added back in test:watch to match the docs. If this is too complex for contributors, that is a philosophical question I leave to you.
The trade-off is simple: do you want to make certain that react-redux works in all supported React versions with CI, or make it simpler to run tests?
In both cases, the tests will run with:
npm run tests
and this default command does NOT touch node_modules OR package.json/lock any longer.
Contributors dealing with issues that affect all versions can use that command (or test:watch) to do their work. Contributors dealing with regressions that affect older versions can use the test:* commands to run tests against the older versions.
Now that the tests don't touch package.json, it will always be possible to restore to equilibrium in node_modules with npm i even if Ctrl-C stops tests mid-run, and there is 0 chance of accidentally changing dev dependencies in a PR or commit.

I won't have time to look at this further until Sunday.
I see Dan commented over in #980 advising that we not switch to Enzyme, as it's been lagging behind React.
How feasible would this multi-version testing approach be without Enzyme?

We only use one feature of either, but the documentation for test renderer versions prior to current is not online so we would need to reverse engineer it. Difficult but not impossible

Here's the thing. react-test-renderer did not implement findByType until React 16, so we would need to implement it.
In other words, to support multiple versions of React, the only way to do it is either to use enzyme ...or to write enzyme. Fortunately, this wouldn't affect the 6.x or 7.x branch. What I'd recommend is that the current master be branched off so we can preserve the tests, before this PR is merged (if it is merged)
For version 6.x+, we can write all new tests using the test renderer, and then do a copy/paste of the tests from that saved branch to get the old tests back that use the 16+ test renderer.
We really only need enzyme for testing in React 14/15/16 with the same tests.

FYI, Dan pointed out that Brian set up per-React-version testing for react-lifecycles-compat here: https://github.com/reactjs/react-lifecycles-compat

Success! The tests build in their own sandboxed directories, with zero interference with the source or our package.json or node_modules. The "test" command runs only against the React version in package.json (and same with the wallaby.js), but continuous integration can test against all versions and combines the lcov.info that jest generates so we can verify full coverage across all versions.
This pull request is ready for another review @timdorr @markerikson
Basically, I made directories
test/
 react/
  0.14/
  15/
  16.2/
  16.3/
  16.4/

Each directory contains a private package.json, and on test runs, the test files AND source are copied just-in-time to these folders, packages installed in node_modules, and then the tests run from their own sandbox, generate coverage, then return back.
I have not figured out a way to make Travis run them in parallel yet, so the CI build will be 5 times slower than it needs to be until that is worked out.
As always, the travis build fails because 5.1.0 is broken on 16.4. Also it looks like I forgot to check for linting errors, so these known issues should be addressed prior to merge.

latest commit fixes travis parallel tests and linting errors, it's ready for merge unless your review finds other issues

just FYI, I made a branch on my setup that merges this with #980 in order to verify the correctness of the patch in all supported React versions (spoiler alert: it works)
I had to fix .babelrc and 1 test is wrong
https://github.com/cellog/react-redux/tree/multi-test-fix
If the PR and the testing config are acceptable, I can make a PR from this branch.

Cool.  I'll try to take a look at this tomorrow evening.  Thanks!

Looking at how things are set up now, I wonder if this could be an external package (react-testing-matrix?). Something for testing multiple React versions would be useful to other projects.
I also feel like this is close to being right, but could use a couple improvements. First, I'd move the scripts into either a scripts directory or the existing test directoryI would always run the tests through the run-tests.js script

One last thing, since it's broken at thee moment anyways, would be to test the scalability of this tooling by removing React 16.4 and then going through the motions of adding it back in. It should be as little modification to the repo as possible. Hopefully, just the addition of the vendored package and an adjustment to the Travis matrix. If we need to edit more than that, it's a smell that we can abstract some more things out.

This PR is pretty huge. Could you please write a condensed explanation for why you think Enzyme is necessary, pointing to particular tests you wouldn't be able to implement without it? I feel pretty strongly that we shouldn't be using Enzyme.

All sounds good. The coverage merging is just in case there is some aspect that is only covered in earlier versions, but if that's not important we can keep the merging code just in case for the future.

@gaearon : I think the primary reason is that Enzyme's adapters make it easier to test the same logic under React 0.14, 15, and 16.  I think there was also a question about some testRenderer.root.findByType() method not existing in 0.14 ?
Per https://twitter.com/monasticpanic/status/1023341534962429955 , it sounds as if Enzyme might be up-to-date with React in the near future.
I don't have strong opinions either way, as long as we have an approach that works.  Any particular concerns about use of Enzyme?

My next plan was to move the tests to use react-testing-library instead of either enzyme or test renderer, since it will work in perpetuity with any react version, I just thought that was too much for 1 set of changes.
The reason for enzyme was the complete API change from test renderer 1 to 15

@gaearon every test that used testRenderer.root.findByType was using the latest react-test-renderer version, which has a new API. This prevents running the test suite against React 15 or 0.14
So enzyme is used to unify the API for these tests. Going forward, I think it would work better to use something like react-test-library, which does not require any test renderer at all and will work even with a brand new dom renderer. If you can help me understand your strong recommendation against enzyme, that would help with making the PR better.

I'm about to push a bunch of commits, but wanted to say first for @timdorr that I wrote a short guide for how to add a new React version for testing in CONTRIBUTING.md, and I'll paste that section here to let you know how it works:
Adding a new React version for testing
To add a new version of React to test react-redux against, create a directory structure
in this format for React version XX:
test/
 react/
  XX/
   package.json
   test/
    getTestDeps.js

So, for example, to test against React 15.4:
test/
 react/
  15.4/
   package.json
   test/
    getTestDeps.js

The package.json must include the correct versions of react, react-dom,
react-test-renderer and the correct enzyme adapter for the React version
being used, as well as the needed create-react-class, jest, enzyme versions
and the jest and scripts sections copied verbatim like this:
{
  "private": true,
  "devDependencies": {
    "create-react-class": "^15.6.3",
    "enzyme": "^3.3.0",
    "enzyme-adapter-react-15.4": "^1.0.6",
    "jest": "^23.4.2",
    "react": "15.4",
    "react-dom": "15.4",
    "react-test-renderer": "15.4"
  },
  "jest": {
    "testURL": "http://localhost",
    "collectCoverage": true,
    "coverageDirectory": "./coverage"
  },
  "scripts": {
    "test": "jest"
  }
}

getTestDeps.js should load the version-specific enzyme adapter and
test renderer (all versions newer than 0.14 use react-test-renderer,
0.14 uses react-addons-test-utils):
import enzyme from 'enzyme'
import TestRenderer from 'react-test-renderer'
import Adapter from 'enzyme-adapter-react-15.4'

enzyme.configure({ adapter: new Adapter() })

export { TestRenderer, enzyme }

Then you can run tests against this version with:
REACT=15.4 npm run test

and the new version will also be automatically included in
REACT=all npm run test

I don't think a generic package for running tests against react versions is absolutely necessary now, because it would require taking some of the specific stuff and making it more generic, which necessitates more sanity tests, configuration (for example, we do NOT want to overwrite the getTestDeps.js file in each directory with the global one) that is not needed. I could extract it out later, and I'm happy to do that, but I want to focus on getting it working here first.
Once things are cooking in react-redux, the PR is merged, I can extract it to make the codebase more focused on react-redux. Same with the coverage merging.
Also, it turns out that codecov already automatically merges all lcov.info files it finds, so I can remove that code

@timdorr, I think I implemented all the suggestions, but it was quite a few, so you might want to verify that I didn't miss any. Thanks for the tips, it's a much leaner PR and more extensible for adding new versions.
I do think it can get leaner by removing enzyme, as we won't need adapters any more. react-testing-library will be much easier to work with long-term. With this change, the getTestDeps.js file becomes unnecessary, which will simplify adding new versions (or old ones) tremendously

Trying this out locally.  I'm on Windows, and it looks like the line that tries to spawn NPM to install a given React version is failing because of cross-platform mismatches with starting stuff.  I saw mentions of cross-spawn, and switching out spawnSync that seems to be working for me.

Awright, I'm ready to merge this in.  I know Dan's not keen on the Enzyme thing, but sounds like Greg wants to switch this over to react-testing-library anyway.
I want to go ahead and get this in now so that we can turn our attention to getting #980 done.  We can always tweak the test setup further later.

Yes, I am much more comfortable with rtl than enzyme for react-redux's testing needs


[feature request] Connecting to Nextcloud music fails ("Force plain password authentication" needed)

Hello,
I tried to use your app with the integrated Nextcloud subsonic server. I created an API-key on the Nextcloud interface which gives me an username and password. When using this with SubTune I get an "Token authentication not supported for LDAP users." error.
What does that mean? I can't make any sense out of this message?! I'm not using LDAP in any way!
edit: I found out that the Token authentication is somehow not implemented in Nextcloud music and an option "Force plain password authentication" is needed for clients to connect. Maybe you will consider adding this option to your app?!

Thanks for the feedback. This request will be implemented in the next version, SubTune 1.2.0.


Alt text / labeling issues in image cropping UI

Issue Summary
Related: #5291. Spotted while reviewing #5292. There are three accessibility issues picked up by Axe in the image cropping UI:

jcrop generates its own img element. That element does not even have an alt text, so the image src is read out loud.
The image tag rendered server-side uses the
title attribute for the alt text. While this might be appropriate on the site’s front-end, here the image is displayed in the admin, to be edited, so the title text does not work as an alt in that context. Relevant code: https://github.com/wagtail/wagtail/blob/70a749b10a1b0c4dac527da28e54cbb3581a774e/wagtail/images/templates/wagtailimages/images/edit.html#L67
jcrop injects its own radio element, which is flagged as not having a label

Steps to Reproduce

Go to the image editing UI on any Wagtail admin, /admin/images/52/
Navigate to the cropping UI with a screen reader

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Technical details

Wagtail version: v2.6a0

I think the simplest solution for this would be to make sure the image created with jcrop has an empty alt="" attribute, and same for our server-generated image. This might need further consideration for us to design a more screen-reader-friendly solution.

Hi @thibaudcolas ! Can I work on this ?
I consider adding a label to the input and name  in input, something like this :
<label for="jcrop" classname="visuallyhidden">Crooping tool</label> <input name="jcrop">
in https://github.com/wagtail/wagtail/blob/8b6b0425de87a802227b11ee8247c975e912ba83/wagtail/images/static_src/wagtailimages/js/focal-point-chooser.js#L32
What do you think ?


Dind container doesn't support adding extraEnv

Hi team,
Issue
Presently it's possible to add additional environment variables to the launcher container through the use of extraEnv
https://github.com/spacelift-io/spacelift-workerpool-k8s/blob/34ba079a0855c770d6e32be88e6668d41c822cd7/templates/deployment.yaml#L80-L82
However, this option doesn't seem to be available for the dind container
https://github.com/spacelift-io/spacelift-workerpool-k8s/blob/34ba079a0855c770d6e32be88e6668d41c822cd7/templates/deployment.yaml#L107-L109
This means that, for environments that are behind a proxy, it's only possible to configure the proxy for the launcher, making it so that the dind container cannot pull images from the internet
https://docs.docker.com/config/daemon/systemd/#httphttps-proxy
Proposed Solution
Add the extraEnv setting to the dind container
Alternate solutions

Have customers build a custom dind image but this seems overkill if the configuration can be done through an environment variable
Use a post renderer with a patch

Thanks a lot @romogo17. Makes perfect sense, and your PR looks great.


network/release 2024 10 21

Added cardano-client-0.4
Added cardano-ping-<IP_ADDRESS>
Added network-mux-0.5
Added ouroboros-network-<IP_ADDRESS>
Added ouroboros-network-api-<IP_ADDRESS>
Added ouroboros-network-framework-<IP_ADDRESS>
Added ouroboros-network-protocols-<IP_ADDRESS>

[x] checked with build-with-chap.sh in ouroboros-network


[gh-518] add Schnorr validator over Secp256k1.

Resolves #518

I have encountered an error and am still striving to resolve it.
thread 'tests::schnorr_validator_tests::test_validate' panicked at 'called `Result::unwrap()` on an `Err` value: VMError with status VECTOR_OPERATION_ERROR with sub status 1 at location Module ModuleId { address:<PHONE_NUMBER>000000000000000000000000000000000000000000000000000003, name: Identifier("schnorr_validator") } at code offset 17 in function definition 6', crates/rooch-framework-tests/src/tests/schnorr_validator_tests.rs:29:10

If I make
const SCHNORR_PUBKEY_LENGTH: u64 = 64;

shorter to 32, just like the Ed25519 public key, there will be an another error:
thread 'tests::schnorr_validator_tests::test_validate' panicked at 'called `Result::unwrap()` on an `Err` value: VMError with status ABORTED with sub status 66537 at location Module ModuleId { address:<PHONE_NUMBER>000000000000000000000000000000000000000000000000000003, name: Identifier("schnorr_validator") } and message 0x0000000000000000000000000000000000000000000000000000000000000003::schnorr_validator::validate at offset 14 at code offset 14 in function definition 9', crates/rooch-framework-tests/src/tests/schnorr_validator_tests.rs:29:10
stack backtrace:

Since I'm not very familiar with moveosvm, can you @jolestar check the file https://github.com/rooch-network/rooch/pull/517/files#diff-1d9159dbfcd0de959bf1f8d6f8ce44189d6cff88c74cabbfd6ff2163bc69b34f to see if anything went wrong?

Could you pass the test(skip some conditions)? And We can merge this PR and #524.  I will do some follow refactoring.

Could you pass the test(skip some conditions)? And We can merge this PR and #524. I will do some follow refactoring.

Resolved. You can review it now.


CSS imports prevent static Hops build

[x] I want to report a bug
[ ] I want to request a feature or change
[ ] I want to provide or change a feature

The problem
As soon as I import CSS into my application, the static build fails silently. There's no error message displayed, the build just doesn't produce any artifact. It also doesn't matter whether I import from my own codebase or from node_modules and it doesn't make a difference, whether it's a global or a CSS-module-import.
Furthermore it's an issue for dev- and prod-builds alike.

After a little more investigating, I can tell:

It's apparently not related to the Node version. I tried 8, 10 & 11 without getting a build.
It seems like this is broken since the introduction of hops-postcss.

So this is an issue in the RenderPlugin of @untool/webpack, where the additionalAssets-hook is called twice, when the mini-css-extract-plugin-loader is present. Which then causes the build to die in silence. ☠


Scalacheck and 2.10.0-M1

Hi folks,
I just tried out Scalacheck locally on my machine with Scala 2.10.0-M1. All the tests pass and it seems to work fine.
/David Christiansen

Hi Rickard,

The above happened both if I used sbt-launch-0.10.1.jar (the version in ScalaCheck's tools dir) and sbt-launch-0.11.2.jar (latest version). How did you build? With a locally installed sbt, or with the sbt script in ScalaCheck's repo?

There was a breaking changing regarding implicit conversions between
strings and compiler symbols.  I fixed it by doing the conversion by
hand.
To make it work, open up
~/.sbt/boot/scala-2.9.1/org.scala-tools.sbt/sbt/0.11.2/compiler-interface-src/compiler-interface-src-0.11.2.jar
Inside there's a file called API.scala.  Replace line 263 with:
	sym.isLocalClass || sym.isAnonymousClass ||

sym.fullName.endsWith(LocalChild.toString)
(in other words, add the trailing "toString" call)
Then pack the jar file back up with the new API.scala and SBT will
work for all versions that I've tried.
This is something that the Scala team is aware of, and they're working
on getting a fixed SBT out. The same instructions should work (with a
slightly different pathname for the jar file) for the older SBT
version.
/David

I recommend that using this patch for the moment
https://gist.github.com/1643715

Hi Kenji,
2012/1/24 kenji yoshida
<EMAIL_ADDRESS>
I recommend that using this patch for the moment
 https://gist.github.com/1643715

This didn't work for me, so I just looked at what it did and manually
replicated the steps in Emacs, which lead to what I sent before.
/David


Concatenate Trajectories

Function that takes in a list of sequential trajectories and combine into 1 trajectory. Requested by @gilwoolee
I actually have this written but I need to add safety check checks and PR it.

This will be fixed by #354, once it is merged.


[Doc] fix plugin name in configuration sample

Release notes

[rn:skip]
What does this PR do?
Fixes the name of plugin in configuration sample used in documentation, from appsearch to enterprise_app_search

I close this because already fixed by #3


[Suggestion] Ragdoll chams

As title says^^

@Straightplus i'v been using ragdoll glow if that's okay with you try it pretty cool when using reverse ragdoll gravity, not sure if there is ragdoll chams but if ur suggesting it u already checked.


DK Bcb scaling & imp unh presence updates

Fix bcb scaling to work with external CF/EF as it does on live
Stop rune holding for Dnd when improved unholy presence is talented

nice, frost UH lgtm. Did you test the BCB scaling with external EB or is there a log?

nice, frost UH lgtm. Did you test the BCB scaling with external EP or is there a log?

I dont have logs atm but i have 2 accounts with an 80 dk in both and it was very easy yo test this on a dummy as the damage difference is significantly big to notice it easy


Login / Signin with google

I will be responsible for creating functional signin / login Google Auth button and remove other as Google only is better
As the button you provided are not redirecting after login just move to google browser page .Assign thi issue with level 3 gssoc-extd

@gauravsingh1281 I want to contribute to this project on this particular issue. Please assign it to me!


Imported type defined multiple times

Assets/Plugins/Editor/VSCode.cs(441,32): error CS0433: The imported type `System.Diagnostics.Process' is defined multiple times
Assets/Plugins/Editor/VSCode.cs(489,55): error CS0433: The imported type `System.Net.WebClient' is defined multiple times
Assets/Plugins/Editor/VSCode.cs(713,25): error CS0433: The imported type `System.Text.RegularExpressions.Regex' is defined multiple times
Using Unity 5.4.1f1 and Google Mobile Ads Unity Plugin v3.1.3

Hey Joel,
Have you upgraded Unity to 5.5+ by chance?
Is it still happening?


Update 01 timing_windows_config.lua

change the osu! marvelous rating to 3, as the 3.2 is only the weighting in score, not the accuracy

it might also be nice to change the OD to 9 rather than 10 since 8.50-9 are more common


Tests for string support

There's some strange behavior in WASM, which might indicate there's still a bug in native code.. but will fix this in a later PR.


Unexpected exit code when validation fails

When a validation fails, the expected exit code would be different than zero but at the moment it is exiting with zero code.

Hi @santiagoaldanondo , can you provide the steps to reproduce please? a sample .enval.manifest.yaml if possible 🙏


Offline Data Persistence Support for Firestore

Is your feature request related to a problem? Please describe.
Offline data persistence feature that caches a copy of the Cloud Firestore data that dotnet app is actively using, so app can access the data when the device is offline. Enables App to write, read, listen to, and query the cached data. When the device comes back online, Cloud Firestore synchronizes any local changes made by the app to the Cloud Firestore backend.
Describe the solution you'd like
Using Sqflite or Any Other Local Database that suitable for Firestore to Persistent the Data Offline with the listener and adapter to make changes when's the connection is back online, exactly like the way firestore for Android, iOS, Flutter works

I'll bring this feature request to the attention of the Firestore product team.

I've heard back from the Firestore product team.

The .NET Client library for Firestore is considered a server side client library and we don't intend to support offline usage.

I'll be closing this issue now as we won't act on this feature request. I appreaciate this is not the reply you wanted and I'm sorry about that.


Switch to Java 8

What is this PR for?
Java 7 is now officially no longer supported by Oracle and Java 8 has been released quite a while. We should take the opportunity to switch to Java 8.
What type of PR is it?
[Improvement]
Todos

[ ] - Task

Is there a relevant Jira issue?
ZEPPELIN-621
How should this be tested?

Hava Java 8 installed locally
Build Zeppelin with mvn clean -Pxxxx -DskipTests
Create some notes with spark/angular/shell interpreter and test some basic use-case

This PR is low risk because Java 8 is backward-compatible with Java 7 source code.
Screenshots (if appropriate)
N/A
Questions:

Does the licenses files need update? --> No
Is there breaking changes for older versions? --> No
Does this needs documentation? --> No

I think we might need this under a profile switch - there are still a lot of companies running JDK 7 - what do you think?

@felixcheung I create this PR because Cassandra server version 3.0 is using Java 8. Right now, some of the features of the Cassandra interpreter cannot be tested because it requires pulling the server and so requires using Java 8 for the integration test.
In general, all the drivers that work at client side are still staying under Java 7 or even Java 6. But on the server side, it's not a problem to ask for Java 8 (because officially Java 7 is no longer supported). Since Zeppelin is a server technology, it's not  that a big deal.
However it's not an urgent matter, so I'm fine if we do not switch to Java 8 right now.
Maybe we need some feedback from the community

Closing since it's not urgent matter

right - feedback would be good. I think it's a great idea but I can't move to JDK 8 yet ;)
thanks for taking the lead on this though.

For me massive +1, this will allow us to update some ancient library.

Geode interpreter also depends on 1.8 https://issues.apache.org/jira/browse/ZEPPELIN-375
Would be nice to switch gradually too (i.e through profile at first)

+1

Any news regarding upgrade to java 8?

Spark 2.2 requires Java 1.8

yes it does. Zeppelin supports older versions of spark though (and other frameworks)

News flash...Java 7 was EOL over 2 years ago.
https://www.java.com/en/download/faq/java_7.xml
What more does it take to get Zeppelin working with Java 8?

and we have java 9 and Hadoop 3 increased the minimum java version from 7 to 8. Should we start to discuss using JDK 8 by default?

I think it's a great idea to move to 8
We need to see what's not supported and so on, and figure out the way to do it.

@doanduyhai since it's fairly urgent now so please consider re-opening the pull request?

@mf69 done, PR re-opened

Why it still not implemented? Spark starting with 2.2.0 works only with Java 8...


GetNewPayments should only look for Receivable and Received blocks

Currently, it's Receivable and any, which would include Send blocks.
Will fix - just adding here for tracking.

Fixed in 1.0.1.


'peerinvalid' errors when installing with npm

I have a project that uses Webpack for JS management. When I try to install better-dateinput-polyfill with npm install better-dateinput-polyfill --save-dev, I get the following error:
npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>
Looks like the 3.0.0-rc.1  does not satisfy the version requirements for the other three, somehow?

Check version 3.0.1


Change Person Model to not have tags and address

Addresses and Tags removed.

Codecov Report

Merging #62 (c6fa4de) into master (757455a) will decrease coverage by 1.41%.
The diff coverage is 92.85%.

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
- Coverage     71.40%   69.99%   -1.42%
+ Complexity      399      364      -35
============================================
  Files            71       68       -3
  Lines          1245     1133     -112
  Branches        125      105      -20
============================================
- Hits            889      793      -96
+ Misses          324      313      -11
+ Partials         32       27       -5

Impacted Files
Coverage Δ

...ain/java/manageezpz/logic/commands/AddCommand.java
100.00% <ø> (ø)

.../main/java/manageezpz/logic/parser/ParserUtil.java
95.00% <ø> (-2.23%)
:arrow_down:

...ain/java/manageezpz/model/util/SampleDataUtil.java
0.00% <ø> (-20.00%)
:arrow_down:

src/main/java/manageezpz/ui/PersonCard.java
0.00% <ø> (ø)

src/main/java/manageezpz/model/person/Person.java
96.55% <80.00%> (-1.07%)
:arrow_down:

...in/java/manageezpz/logic/commands/EditCommand.java
96.36% <100.00%> (-0.66%)
:arrow_down:

...java/manageezpz/logic/parser/AddCommandParser.java
100.00% <100.00%> (ø)

...ava/manageezpz/logic/parser/EditCommandParser.java
100.00% <100.00%> (+7.69%)
:arrow_up:

...ain/java/manageezpz/storage/JsonAdaptedPerson.java
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 757455a...c6fa4de. Read the comment docs.


chore(RingTheory): split AlgebraicIndependent.lean

As a follow-up to splitting RingTheory/Algebraic.lean, also split AlgebraicIndependent.lean.
This PR creates the following new files:

AlgebraicIndependent/Defs.lean: definition of AlgebraicIndependent and IsTranscendenceBasis
AlgebraicIndependent/Basic.lean: basic results on AlgebraicIndependent
AlgebraicIndependent/TranscendenceBasis.lean: basic results on TranscendenceBasis
AlgebraicIndependent/Adjoin.lean: relating AlgebraicIndependent and IntermediateField.adjoin
AlgebraicIndependent/Transcendental.lean: relating AlgebraicIndependent, Transcendental and Algebraic
AlgebraicIndependent/RankAndCardinality.lean: about the rank/cardinality of TranscendenceBasises

[ ] depends on: #19370

Good work! I think I'll come back after #19370 is merged, as currently the diffs are too big.

Thanks!
bors merge


added slepc eigensolver as an option for megaman

Currently works for eigendecompositon of symmetric matrices.
Passes unit tests, but I haven't run any benchmarks to see the performance.

Hi @keceli can you check your code for python3.4 and 3.5? Seems like it failed on both versions.

Hi @yuchaz. I couldn't figure out what is incompatible with Python 3 in my code. Any suggestions?

Hi @keceli
That is caused by the relative import issue in python 3. See PEP-404#Imports for details. In short, the implicit relative import is no longer supported in python 3. Therefore, you will have to do the following changes in eigendecomp.py:
# In line 2, add
from __future__ import absolute_import
# this is for python 2 compatibility

# In line 28, change it to
from . import slepctools as slepc

Something needed to be added

In eigendecomp.py line 308, need to add the error msg for SLPEC as well.
The SLEPC_LOADED flag is not used, you have to use it in check_eigen_solver function.
Add slepc4py in the installation guide under the Installation from source section in README.md.
That will be good if you can run some benchmarking and write some descriptions about why should we use SLPEC.

Thanks for your contribution!

Thanks Yuchia for the clear instructions. It now passes the tests for
python 2.7 and 3.5 but fails for 3.4.
I'll run benchmark calculations and add the support for null space
calculations later.
Murat
On Sun, Feb 18, 2018 at 12:49 PM, YuChia Chen<EMAIL_ADDRESS>wrote:

Hi @keceli https://github.com/keceli
That is caused by the relative import issue in python 3. See
PEP-404#Imports https://www.python.org/dev/peps/pep-0404/#imports for
details. In short, the implicit relative import is no longer supported in
python 3. Therefore, you will have to do the following changes in
eigendecomp.py:
In line 2, addfrom future import absolute_import# this is for python 2 compatibility
In line 28, change it tofrom . import slepctools as slepc
Something needed to be added

In eigendecomp.py line 308, need to add the error msg for SLPEC as
well.
The SLEPC_LOADED flag is not used, you have to use it in
check_eigen_solver function.
Add slepc4py in the installation guide under the Installation from
source section in README.md.
That will be good if you can run some benchmarking and write some
descriptions about why should we use SLPEC.

Thanks for your contribution!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mmp2/megaman/pull/90#issuecomment-366537702, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACA7dwWROTisjdF_F5tLa4qKT1kP4jLOks5tWHClgaJpZM4SI_ws
.

Hi @keceli Sadly I cannot reproduce the test failure of on my computer with python=3.4 therefore I am not 100% sure where the bug comes from.
I printed out the reconstruction error of each eigensolvers and found out that the reconstruction error of slepc is twice larger than other solvers. I suspect it's from the null space computation since you compute it using arpack solver directly and the arpack eigensolver is not so numerically stable.
Some workarounds will be use other solver to compute null space when using the slepc eigensolver (e.g. dense or lobpcg). But it will be nice if you can finish the null space computation for slepc since it will be more consistent. :)
Thank you!

I tested it on theta and printed reconstruction errors. I don't get any failures.
(base) 19:36:46|thetalogin5|megaman-slepc> nosetests --nocapture /home/keceli/miniconda2/lib/python2.7/site-packages/megaman/embedding/tests/test_lle.py
/home/keceli/.local/lib/python2.7/site-packages/petsc4py/lib/__init__.py:121: UserWarning: ignored arch: 'arch-theta-opt-cray', using: 'arch-gcc-opt'
  (os.path.pathsep.join(arch_env), arch))
../home/keceli/miniconda2/lib/python2.7/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
************************************
Reconstruction error: auto 0.0400798930466
************************************
/home/keceli/miniconda2/lib/python2.7/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
************************************
Reconstruction error: dense 0.0400798930466
************************************
/home/keceli/miniconda2/lib/python2.7/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
************************************
Reconstruction error: arpack 0.0694767617058
************************************
/home/keceli/miniconda2/lib/python2.7/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
/home/keceli/miniconda2/lib/python2.7/site-packages/megaman/utils/eigendecomp.py:63: UserWarning: lobpcg does not perform well with small matrices or with large numbers of vectors. Switching to 'dense'
  warnings.warn("lobpcg does not perform well with small matrices or "
************************************
Reconstruction error: lobpcg 0.0400798930466
************************************
/home/keceli/miniconda2/lib/python2.7/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
************************************
Reconstruction error: slepc 0.0380200814498
************************************
/home/keceli/miniconda2/lib/python2.7/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
************************************
Reconstruction error: amg 0.0400798930466
************************************
./home/keceli/miniconda2/lib/python2.7/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
/home/keceli/miniconda2/lib/python2.7/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
/home/keceli/miniconda2/lib/python2.7/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
/home/keceli/miniconda2/lib/python2.7/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
/home/keceli/miniconda2/lib/python2.7/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
/home/keceli/miniconda2/lib/python2.7/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
.
----------------------------------------------------------------------
Ran 4 tests in 1.399s

OK

Hi @keceli I ran on my computer with python=3.5 and got the reconstruction error. Can you try with another environment? I will also try to debug it :)
Yuchia

Thanks @yuchaz for looking into it. I tried with python 3.6 and it still doesn't give an error. I get errors only when I change the seed, but that error comes from arpack.
(base) 21:58:00|thetalogin5|megaman-slepc>  nosetests --nocapture /home/keceli/miniconda3/lib/python3.6/site-packages/megaman/embedding/tests/test_lle.py
..*************
Reconstruction error for numpy: 0.040312589381387036
*************
/home/keceli/miniconda3/lib/python3.6/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
*************
Reconstruction error for auto: 0.04007989304659544
*************
/home/keceli/miniconda3/lib/python3.6/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
*************
Reconstruction error for dense: 0.04007989304659544
*************
/home/keceli/miniconda3/lib/python3.6/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
*************
Reconstruction error for arpack: 0.06947676170584381
*************
/home/keceli/miniconda3/lib/python3.6/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
/home/keceli/miniconda3/lib/python3.6/site-packages/megaman/utils/eigendecomp.py:63: UserWarning: lobpcg does not perform well with small matrices or with large numbers of vectors. Switching to 'dense'
  warnings.warn("lobpcg does not perform well with small matrices or "
*************
Reconstruction error for lobpcg: 0.04007989304659566
*************
/home/keceli/miniconda3/lib/python3.6/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
*************
Reconstruction error for slepc: 0.038020081449784554
*************
/home/keceli/miniconda3/lib/python3.6/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
*************
Reconstruction error for amg: 0.04007989304659555
*************
./home/keceli/miniconda3/lib/python3.6/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
/home/keceli/miniconda3/lib/python3.6/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
/home/keceli/miniconda3/lib/python3.6/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
/home/keceli/miniconda3/lib/python3.6/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
/home/keceli/miniconda3/lib/python3.6/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
/home/keceli/miniconda3/lib/python3.6/site-packages/sklearn/utils/validation.py:393: DeprecationWarning: Passing 'None' to parameter 'accept_sparse' in methods check_array and check_X_y is deprecated in version 0.19 and will be removed in 0.21. Use 'accept_sparse=False'  instead.
  " instead.", DeprecationWarning)
.
----------------------------------------------------------------------
Ran 4 tests in 1.404s

OK


some more books can be add on books page

Actual Behaviour
Many books about p5.js are not added on book web page
Expected Behaviour
these books should present on books web page

Would you like to work on the issue?
yes
Please let us know if you can work on it or the issue should be assigned to someone else
I can work on it

Hi, @namanjain2001-code I would like to work on this issue.

hii, i really want to work on this issue can i?

i have mentioned the sulution of this issue in the pull request

hii . I wanted to work on this issue
Can I start working on these issue ???


[Bug, 1.10.2] Electrolytic Separator

The Electrolytic Separator power isn't reduced after adding energy upgrade (doesn't matter how many) in it.  I've tried taking them back out and in, and update to newest version of mekanism <IP_ADDRESS>2 with a new world.

why you closed it? the thumbs up should show, that you're not the only one where that bug occurs

Because it's not a bug.
https://github.com/aidancbrady/Mekanism/issues/3781
https://github.com/aidancbrady/Mekanism/issues/3760
https://github.com/aidancbrady/Mekanism/issues/3731
Definitely intended


Recaptcha Breaks 2FA

Have had 2FA installed for quite some time with no issues. After installing recaptcha, it shows up on the login page and then when entering login it just goes to a blank page. When disabling the recaptcha plugin and just refreshing the page the 2FA code page shows up and then loads the email. Created identical ticket with 2FA plugin as I do not know which is breaking which as each on their own works.

Hello,Is there any error in the logs?Which 2FA plugin do you use? We use twofactor_gauthenticator, this combination works for us.7 апр. 2019 г. 23:04 пользователь gh0stshell<EMAIL_ADDRESS>написал:Have had 2FA installed for quite some time with no issues. After installing recaptcha, it shows up on the login page and then when entering login it just goes to a blank page. When disabling the recaptcha plugin and just refreshing the page the 2FA code page shows up and then loads the email. Created identical ticket with 2FA plugin as I do not know which is breaking which as each on their own works.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

It is definitely the recaptcha plugin, if I remove all other plugins and
leave just that one when I tried to login it goes to a white page with no
errors in the mail.err log or mail.log or on the screen. If I remove
recaptcha and turn all plugins back on i can login with an account that has
2FA setup and one that does not. The issue is when having recaptcha enabled
after entering the email and password it just goes to a blank white page
with no errors.
On Thu, Apr 11, 2019 at 3:53 AM Volodymyr Kolesnykov <
<EMAIL_ADDRESS>wrote:

Hello,Is there any error in the logs?Which 2FA plugin do you use? We use
twofactor_gauthenticator, this combination works for us.7 апр. 2019 г.
23:04 пользователь gh0stshell<EMAIL_ADDRESS>написал:Have had
2FA installed for quite some time with no issues. After installing
recaptcha, it shows up on the login page and then when entering login it
just goes to a blank page. When disabling the recaptcha plugin and just
refreshing the page the 2FA code page shows up and then loads the email.
Created identical ticket with 2FA plugin as I do not know which is breaking
which as each on their own works.
—You are receiving this because you are subscribed to this thread.Reply to
this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sjinks/roundcube_recaptcha/issues/6#issuecomment-482066810,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABpPNwXETapbRRlJilJQLNzMIBqWirO-ks5vfxQygaJpZM4chAB9
.

What version of PHP are you running?
What do your PHP error log files say? Nothing would be in mail.err or mail.log, as that usually pertains to the internal mail system.

On my server i have custom logs and all roundcube and mail get dumped into
those 2 logs so yes there would be stuff in there.
PHP 7.3.3
When checking the web server logs after turning them up 2 levels I now get:
PHP Fatal error:  Uncaught Error: Class 'ReCaptcha\ReCaptcha' not found in
/etc/roundcube/plugins/recaptcha/recaptcha.php:39
Stack trace:
#0  /etc/roundcube/rcube_plugin_api.php(440): recaptcha->authenticate(Array)
#1 /etc/roundcube/index.php(112):
rcube_plugin_api->exec_hook('authenticate', Array)
#2 {main}
thrown in /etc/roundcube/plugins/recaptcha/recaptcha.php on line 39
On Thu, Apr 11, 2019 at 3:07 PM booshlinux<EMAIL_ADDRESS>wrote:

What version of PHP are you running?
What do your PHP error log files say? Nothing would be in mail.err or
mail.log, as that usually pertains to the internal mail system.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sjinks/roundcube_recaptcha/issues/6#issuecomment-482343692,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABpPN-JzD9r99sVrPk3xmXYjuwattj4Xks5vf7IngaJpZM4chAB9
.

This sounds like a required dependency was not satisfied:
"google/recaptcha": "^1.1"
Did you install this plugin with composer?

Per Getting started since you did not mention anything specifically i did
what it listed which was:
php composer.phar install
Should I dod it again, i ran this while inside the recaptcha folder.
On Thu, Apr 11, 2019 at 3:41 PM booshlinux<EMAIL_ADDRESS>wrote:

This sounds like a required dependency was not satisfied:
"google/recaptcha": "^1.1"
Did you install this plugin with composer?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sjinks/roundcube_recaptcha/issues/6#issuecomment-482353634,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABpPN62tNP5c_nnlQcOTewlG7IfCHXd1ks5vf7ovgaJpZM4chAB9
.

Typically the composer.phar file is in the root of your round cube directory.

I should of been more specific, The php composer.phar show command should be run within the root directory of your roundcube installation.


Building failed: No rule to make target '/usr/lib/x86_64-linux-gnu/libGLX.so'

Hi, I'm currently using Ubuntu 18.04 and gcc 7.4.0. When I ran "python setup.py install", the build would fail because " make[2]: *** No rule to make target '/usr/lib/x86_64-linux-gnu/libGLX.so', needed by 'deps/magnum-bindings/src/python/_magnum.cpython-37m-x86_64-linux-gnu.so'.  Stop." More detailed output is attached below:
[ 77%] Linking CXX static library libMagnumSceneGraph.a
[ 77%] Built target MagnumSceneGraph
Scanning dependencies of target MagnumDebugTools
Scanning dependencies of target magnum
[ 77%] Building CXX object deps/magnum/src/Magnum/DebugTools/CMakeFiles/MagnumDebugTools.dir/CompareImage.cpp.o
make[2]: *** No rule to make target '/usr/lib/x86_64-linux-gnu/libGLX.so', needed by 'deps/magnum-bindings/src/python/_magnum.cpython-37m-x86_64-linux-gnu.so'.  Stop.
make[2]: *** Waiting for unfinished jobs....
[ 77%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/math.matrixfloat.cpp.o
[ 77%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/math.range.cpp.o
[ 77%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/math.matrixdouble.cpp.o
[ 77%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/math.cpp.o
[ 77%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/magnum.cpp.o
[ 77%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/trade.cpp.o
[ 77%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/scenegraph.matrix.cpp.o
[ 77%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/math.vectorintegral.cpp.o
[ 77%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/primitives.cpp.o
[ 77%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/scenegraph.cpp.o
[ 78%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/math.vectorfloat.cpp.o
[ 78%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/gl.cpp.o
[ 78%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/shaders.cpp.o
[ 78%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/meshtools.cpp.o
[ 79%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/scenegraph.trs.cpp.o
[ 79%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/platform/glfw.cpp.o
[ 79%] Building CXX object deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/platform/glx.cpp.o
[ 79%] Linking CXX shared module containers.cpython-37m-x86_64-linux-gnu.so
[ 79%] Linking CXX static library libMagnumDebugTools.a
[ 79%] Built target MagnumDebugTools
[ 79%] Built target corrade_containers
[ 79%] Linking CXX static library libTinyGltfImporter.a
[ 79%] Built target TinyGltfImporter
[ 79%] Linking CXX static library libgeo.a
[ 79%] Built target geo
CMakeFiles/Makefile2:4895: recipe for target 'deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/all' failed
make[1]: *** [deps/magnum-bindings/src/python/magnum/CMakeFiles/magnum.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 79%] Linking CXX static library libassimp.a
[ 79%] Built target assimp
Makefile:151: recipe for target 'all' failed
make: *** [all] Error 2
Traceback (most recent call last):
File "setup.py", line 377, in
zip_safe=False,
File "/home/changan/.pyenv/versions/audio_nav/lib/python3.7/site-packages/setuptools/init.py", line 143, in setup
return distutils.core.setup(**attrs)
File "/home/changan/.pyenv/versions/3.7.2/lib/python3.7/distutils/core.py", line 148, in setup
dist.run_commands()
File "/home/changan/.pyenv/versions/3.7.2/lib/python3.7/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/home/changan/.pyenv/versions/3.7.2/lib/python3.7/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/home/changan/.pyenv/versions/audio_nav/lib/python3.7/site-packages/setuptools/command/install.py", line 67, in run
self.do_egg_install()
File "/home/changan/.pyenv/versions/audio_nav/lib/python3.7/site-packages/setuptools/command/install.py", line 109, in do_egg_install
self.run_command('bdist_egg')
File "/home/changan/.pyenv/versions/3.7.2/lib/python3.7/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/home/changan/.pyenv/versions/3.7.2/lib/python3.7/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/home/changan/.pyenv/versions/audio_nav/lib/python3.7/site-packages/setuptools/command/bdist_egg.py", line 172, in run
cmd = self.call_command('install_lib', warn_dir=0)
File "/home/changan/.pyenv/versions/audio_nav/lib/python3.7/site-packages/setuptools/command/bdist_egg.py", line 158, in call_command
self.run_command(cmdname)
File "/home/changan/.pyenv/versions/3.7.2/lib/python3.7/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/home/changan/.pyenv/versions/3.7.2/lib/python3.7/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/home/changan/.pyenv/versions/audio_nav/lib/python3.7/site-packages/setuptools/command/install_lib.py", line 11, in run
self.build()
File "/home/changan/.pyenv/versions/3.7.2/lib/python3.7/distutils/command/install_lib.py", line 107, in build
self.run_command('build_ext')
File "/home/changan/.pyenv/versions/3.7.2/lib/python3.7/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/home/changan/.pyenv/versions/3.7.2/lib/python3.7/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "setup.py", line 202, in run
self.build_extension(ext)
File "setup.py", line 274, in build_extension
shlex.split("cmake --build {}".format(self.build_temp)) + build_args
File "/home/changan/.pyenv/versions/3.7.2/lib/python3.7/subprocess.py", line 347, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['cmake', '--build', 'build', '--config', 'RelWithDebInfo', '--', '-j']' returned non-zero exit status 2.

@changanc Hi, may I know how you finally solved this issue? Thanks


Undo breaking change: MicrosoftAppCredentials ctor was changed

Version
version 4.2.2
Describe the bug
MicrosoftAppCredentials ctor was changed from
(string appId, string password)
to
(string appId, string password, HttpClient customHttpClient = null)
This is breaking Teams, an possibly other customers
[bug]

fixed with PR #1386


;issue embed for pulls should be purple for merged and red for closed

Not red for both

Fixed by #51


Remove the arrow on option selected ?

Hello there,
Thanks for this amazing plug-in, it's very useful in my app and I'm enjoying playing with it ! 😄
I've a simple question : is there a way to remove the arrow when an option is selected ?
I can't find a way to do it and my aim is to have something like this when the option is selected :

Thanks guys !

@npalbrecht Thanks for the feedback! We are glad you are enjoying it.
There us a property called dropdownIcon. You can replace this with anything of choice and style it with dropdownIconStyle
I have put together an example for you in the sandbox


909 Converter update for CTA Text

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #909
Test URLs:

Before: https://main--danaher-ls-aem--hlxsites.hlx.page/
After: https://909-converter-cta-text--danaher-ls-aem--hlxsites.hlx.page/

LGTM


Clean up telemetry keys

This is part of some cleanup work I've been meaning to do for a while just to get the stuff in TelemetryKeys more properly organized.
I also updated the agent stuff to use the AdsTelemetryService to align to the common schema we're using elsewhere. This does mean that we won't be able to easily correlate events from before this change to ones after - but given that we don't actually use these events for any reporting currently I don't think it's a huge deal to do this now.

Pull Request Test Coverage Report for Build 518933364

27 of 37 (72.97%)  changed or added relevant lines in 4 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 43.292%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/services/dialog/browser/wizardModal.ts
0
1
0.0%

src/sql/workbench/contrib/jobManagement/browser/jobActions.ts
7
16
43.75%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/common/ports.ts
4
74.14%

Totals

Change from base Build 518780484:
-0.005%

Covered Lines:
24620

Relevant Lines:
52078

💛  - Coveralls

Pull Request Test Coverage Report for Build 518933364

27 of 37 (72.97%)  changed or added relevant lines in 4 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 43.292%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/services/dialog/browser/wizardModal.ts
0
1
0.0%

src/sql/workbench/contrib/jobManagement/browser/jobActions.ts
7
16
43.75%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/common/ports.ts
4
74.14%

Totals

Change from base Build 518780484:
-0.005%

Covered Lines:
24620

Relevant Lines:
52078

💛  - Coveralls


(beta) consider changing the message list line height when preview lines change

Checklist

[X] I have used the search function to see if someone else has already submitted the same feature request.
[X] I will describe the problem with as much detail as possible.
[X] This issue only contains a request for one single feature, not multiple (related) features.

App version
6.508
Problem you are trying to solve
Hi!
Please consider changing the message list line height when preview lines change so that there is no excessive space between lines.
Here are som examples:
Message preview: 2 lines

Message preview: 0 lines

Suggested solution
Adjust the message list line height according to the number of preview lines chosen (noticed when switch between 0 and 2 lines)
Screenshots / Drawings / Technical details
No response

This has already been implemented in #6637 (but the change hasn't been included in a beta version yet). It won't make a huge difference when the star is displayed, though (see #6683).


Path of Executable JAR listed in README seems incorrect

The curl command listed
curl --fail --location https://jcenter.bintray.com/com/gojuno/swarmer/swarmer/${SWARMER_VERSION}/swarmer-${SWARMER_VERSION}.jar --output /tmp/swarmer.jarwill download swarmer.jar but the invocation example says java -jar swarmer-latest-version.jar
Shouldn't this be java -jar swarmer.jar ? otherwise i get error Error: Unable to access jarfile /tmp/swarmer-latest-version.jar

Probably just a copy-paste issue from our scripts or something. Thanks!

You should launch file with exactly the same name as downloaded, curl and run examples are just not using the same file name, we'll fix that thanks!
@ming13 it's not a copy-paste issue, swarmer-latest-version.jar was a hint to make sure users pay attention to the version of swarmer they download/work with, for instance artifact on Jcenter does have version in name swarmer-${SWARMER_VERSION}.jar.
However since now we provide curl sample, we probably need to change file name in examples to just swarmer.jar


Parameter passing erroring out

How are the parameters expected?  Tried a few ways and it errors out.

ShowPhoneNumberType is a switch, so you don't have to add $true. Just add -ShowPhoneNumberTrue.
-ShowPhoneNumberType
Specifies whether or not the phone number type of phone numbers should be displayed. (CallingPlan, OperatorConnect, DirectRouting)
Required:           false
Type:               switch
Default value:      false
All params are explained/defined in the synopsis.

Yeah this worked.  Showed True/False in readme so assumed all parameters required them.

Yeah some params are switches, some are bools because I want a default value for those. Not that uncommon for PowerShell I think.
I don't recall adding any of the new params to the readme but all should be in the synopsis.
You can always create a parent script which just calls the visualizer with your preferred params. ☺

Thanks all good.  Any way to run this once and capture ALL callflows in one run session?  The reason I ask is that if I run each AA as separate cmdlet it will read all AA's and CQs into an array and it slows down the processing.

The script can only run for 1 top level app at a time but there is now a param called CacheResults which is false by default. So try to use -CacheResults $true. It will get all AAs, CQs and RAs and store them in Global variables, so for the next run, it will only need to lookup the stuff it has to, which all should be graph requests with an explicit ID (users/groups) as long as the PS session persists. But it won't read all voice apps again.


Add tooltips to ticket graph

We need to show the amount and date the order took place in the form of tooltip for each data point

@iamareebjamal i am unable to add attendees using postman,
the api endpoint i used is http://open-event-api.herokuapp.com/v1/tickets/332 and  and i am getting
  `
405 Method Not Allowed
Method Not Allowed
The method is not allowed for the requested URL. ` ` `
but when i use http://open-event-api.herokuapp.com/v1/tickets/332 to find tickets it is working properly and givine   {     "links": {         "self": "/v1/tickets/332"     },     "jsonapi": {         "version": "1.0"     },     "data": {         "links": {             "self": "/v1/tickets/332"         },         "attributes": {             "is-description-visible": true,             "type": "free",             "min-order": 1,             "sales-ends-at": "2018-01-29T18:21:41.322000+00:00",             "max-order": 10,             "is-fee-absorbed": false,             "description": null,             "sales-starts-at": "2018-01-27T18:21:41.322000+00:00",             "is-hidden": false,             "name": "second ticket",             "price": 0,             "quantity": 1,             "position": 1         },         "relationships": {             "event": {                 "links": {                     "related": "/v1/tickets/332/event",                     "self": "/v1/tickets/332/relationships/event"                 }             },             "ticket-tags": {                 "links": {                     "related": "/v1/tickets/332/ticket-tags",                     "self": "/v1/tickets/332/relationships/ticket-tags"                 }             },             "attendees": {                 "links": {                     "related": "/v1/attendees?ticket_id=332",                     "self": "/v1/tickets/332/relationships/attendees"                 }             },             "access-codes": {                 "links": {                     "related": "/v1/tickets/332/access-codes",                     "self": "/v1/tickets/332/relationships/access-codes"                 }             }         },         "type": "ticket",         "id": "332"     } }

Attendees are added via /attendees endpoint

@iamareebjamal i created attendees using the endpoint but still i see no chart or graph


Add model validations in repository.

Add a validate function that validates the model data before saving in the database.

AuxiliaryChainRepository
ContractEntityRepository
GatewayRepository
MessageRepository
StakeRequestRepository

Check for the mandatory params are not null.

Please, make the function private and use it in save function itself as a precondition.

This ticket can be done after updating sequelize upsert to create/update/save.
Create/Update/Save sequelize methods does validation.
Revisit this ticket after completion of ticket #158

The ticket can be closed since valdiations are taken care in #158

Validations related to values are already available in repositories files. Closing this issue


Not working for figma browser users

It works great for figma desktop app users but I see no event tracked for figma broswer users.
Browser: Chrome 125
OS: Mac

No bandwidth to maintain it right now.
Feel free to submit a PR with a fix or fork.


Default value of state in routerReducer is null which causes store-log-monitor to error on a reset

As the state defaults to null in the reducer clicking reset in the dev tools throws an error...
Cannot read property 'path' of null.
If I edit the line in reducer.js to the line below it works fine in my app but not sure if there are any wider implication or a better fix.
if (state === void 0) { state = { path: '' }; }

I can also get round this issue by doing this in my app module which may be the recommended approach rather than just a work around.
StoreModule.provideStore(reducer, { router: { path: '' } })

What about  window.location.pathname ?

Setting this initial value for the reducer is the recommended approach. I didn't want to set the initial value using window.location so it would be safe to use where window isn't available.

Thanks @brandonroberts, I will use the initial value.
I do wonder whether this should also default in the router-store code as without this the ngrx store-log-monitor reset button causes the app to crash.

I'll add it to the README for defaulting to an initial value


"Quick Open" shortcut doesn't work when a BT is open in LimboAI editor

Alt+Shift+O is not relayed to the editor for some reason. It does work from the main menu.

Looks like it also happens while SceneTree view is selected, even without LimboAI plugin. Godot bug?


Decide which platforms to display in results views

The results views will have one row for each organization where we want to display some icons to indicate if an organization has an account on one of the more common platforms. We probably want to support this for about 3-5 platforms which we need to pick.
Some canidates:

Facebook
YouTube
Instagram
LinkedIn
WeChat
Telegram
Twitter
TikTok

My intuition is that Twitter, LinkedIn and Facebook will be those with highest coverage in Europe and North America. V Kontakte is large in countries where people understand russian. This site has some nice stats (also over time): https://vincos.it/world-map-of-social-networks/
Question: Should this be defined by country or would it add a lot more work than having the same choice globally?

Initially, I think we should aim for a global choice but it should not be an enormous task to have it configurable in [countries.rq](https://github.com/govdirectory/website/blob/main/queries/countries.rq (maybe as a way to override the default).

This does not work globally but maybe we could compare a few different countries https://w.wiki/3enY

Nice! I noticed that LinkedIn was missing, so I fixed that.

https://github.com/govdirectory/website/commit/8f608e161f2bbb78cbffc8741b41497ecc5b4d80 implemented Twitter, YouTube, LinkedIn, Facebook, and Instagram for now.

Closing this, it can be reevaluated at a later stage.


feat (runtime): Components with slots

Slots
This version of the framework allows to insert external content into a component using slots.
A component can define where the external content should be inserted by using the hSlot() function:
const Comp = defineComponent({
  render() {
    return h('div', {}, [hSlot()])
  },
})

Then, when mounting the component, you can pass the external content as the third argument to the h() function:
h(Comp, {}, [h('span', {}, ['Hello'])])

The result of mounting the component above will be:

  Hello

This sounds similar to children in React.

I think the concept of slots represents children in React.

It's exactly that!


Add event admin plugin.

Is this a feature request, or do you want to contribute such a bundle?

@saschazelzer I'd  like to contribute, I didn't see any standard us plugins, where are they?

There are only a few experimental bundles in the development branch, like httpservice and webconsole. Currently, the focus is still on improving the framework itself.

@lygstate This is great. We welcome contributions. The event admin would be a very useful addition.

This will be tracked in https://github.com/CppMicroServices/CppMicroServices/issues/687


Fixed Resnet Stem

Resnet did not project properly beforehand. This push fixes it.

Thanks for catching this bug during cleanup.


Issue getting it to run Something failed while connecting: mobileapi.toshibahomeaccontrols.com/api/Consumer/Login

Hi, First of all thank you for making this. I was looking for something to bypass homeassistant ;-)
I'm trying to run this on ubuntu. But it's giving me a weird error:
2022-12-02 23:35:48,775:WARNING:mqtt: unfiltered_messages() is deprecated and will be removed in a future version. Use messages() instead.
2022-12-02 23:35:48,776:ERROR:toshiba_ac.device_manager: Something failed while connecting: mobileapi.toshibahomeaccontrols.com/api/Consumer/Login
Traceback (most recent call last):
File "/home/bart/Toshiba-AC-mqtt/toshiba_ac/device_manager.py", line 52, in connect
await self.http_api.connect()
File "/home/bart/Toshiba-AC-mqtt/toshiba_ac/http_api.py", line 104, in connect
res = await self.request_api(self.LOGIN_PATH, post=post, headers=headers)
File "/home/bart/Toshiba-AC-mqtt/toshiba_ac/http_api.py", line 85, in request_api
async with method() as response:
File "/home/bart/.local/lib/python3.8/site-packages/aiohttp/client.py", line 1141, in aenter
self._resp = await self._coro
File "/home/bart/.local/lib/python3.8/site-packages/aiohttp/client.py", line 508, in _request
req = self._request_class(
File "/home/bart/.local/lib/python3.8/site-packages/aiohttp/client_reqrep.py", line 305, in init
self.update_host(url)
File "/home/bart/.local/lib/python3.8/site-packages/aiohttp/client_reqrep.py", line 364, in update_host
raise InvalidURL(url)
aiohttp.client_exceptions.InvalidURL: mobileapi.toshibahomeaccontrols.com/api/Consumer/Login
2022-12-02 23:35:48,779:WARNING:toshiba_ac.device_manager: Shutting down
I have triple checked my username and password; also i have tried to do the HTTP call with postman and this works correctly with my credentials. I cannot figure out why this doesn't want to connect. I've tried this on two seperate machines. Any ideas? :-)

Hey, nice that there are people who are using my stuff.
And good to hear that you've already figured it out yourself.
Now that I read your comment, I remember that I had to fix that, too, a couple of weeks ago, but I forgot to push that change.
I've pushed it now. Work on my side, maybe you can give it a try.

Thx It helps. But its stil crashing on the MeritB thing. I fixed it by adding 0x01 to the MeritB enum. Also the MQTT messages i received had numbers as status instead of the enum string value.
So i changed the ToJson method in FCU file. In the else clause i changed it to res[name[1:]] = val.name to get this to work properly.

Weird, it's already in the new version: https://github.com/holgerpieta/Toshiba-AC-mqtt/blob/88107117e8066a13d2d4e90206272ef3d669697b/toshiba_ac/fcu_state.py#L83
Can you show me what you changed?
The MQTT status returns numbers instead of strings because that was easier for me to parse in the receiver (i.e. Node-Red). I had planned to publish the strings as well, but never got to it (because I didn't need it).
If you like, maybe make a pull request with the old ToJson method and a new ToJsonString method and then publish the former on the old topic (i.e. ac/room/status) and the latter on a new topic (e.g. /ac/room/text_status or whatever you like).

I had some time and updated the Git. The MeritB is fixed. Thx.  I will see if i have some time the next weeks to do a pull.

Thanks. I haven't found the time to dig into it, so I'll await your changes.


Fix/reexport types from conversation

Description:
Just reexport of conversation types to get them available when using overlay library
Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[ ] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

Hey there and thank you for opening this pull request! 👋🏼
We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
No release type found in pull request title "Fix/reexport types from conversation". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - fix
 - hotfix
 - feat
 - feature
 - chore


Aliexpress product is different than what is shown on waveshare's website

The aliexpress link shows a different base board with one connector instead of the two black connectors, as shown on your site and the waveshare wiki. https://www.aliexpress.us/item/3256805983216570.html

Which one is the current revision? or are these actually two different products?
Also, is this display available by itself, without the controller board? What is the controller used for this display?
Thank you very much, your video was great by the way!

Yes, those are two separate products - with and without a touchscreen. Otherwise, they should be the same.
The screen alone without microcontroller is here - https://www.waveshare.com/1.28inch-lcd-module.htm
Let me know if was helpful.


Modal close callback

I was browsing through the code and it seems the close callback is hardcoded(by just setting this.show to false).
It would be nice to actually define a close callback, where we for example could do some model cleanup when closing the modal (through the close button or by clicking the background).
I might be missing something though, I'm still new to VueJS

v1.0.2 fixed this issue.

Hello. What's the callback? It doesn't seem to be documented.


Null-safety

About 2 months ago, Dart 2.12 was released, which made NNBD/Null-safety stable. This package has to be migrated.
Closed by #36.

Give a look at https://github.com/SpinlockLabs/irc.dart/pull/36.

Still trouble, when I run: dart migrate
Analyzing project...
[-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|]
2 analysis issues found:
error • A value of type 'Entity*' can't be assigned to a variable of type 'Channel' at lib/example.dart:125:23 • (invalid_assignment)
error • The method 'add' can't be unconditionally invoked because the receiver can be 'null' at lib/example.dart:198:25 • (unchecked_use_of_nullable_value)

The migration tool didn't start, due to analysis errors.
The following steps might fix your problem:

Set the lower SDK constraint (in pubspec.yaml) to a version before 2.12.
Run dart pub get.
Try running dart migrate again.

More information: https://dart.dev/go/null-safety-migration


.github: use ref name as docker image name if ref type is tag

Description
When push a tag to repository, use the TAG name as the docker image name.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

this PR has been tested in my private repo
since it does not impact cloudstack functionalities, merging this


dalfox not able to detect basic POST parameter xss

Describe the bug
Hey there!
First of all, thanks for this great initiative!
By testing dalfox against a simple login form (vulnerable), dalfox is able to find all 3 parameters correctly.
However, it is sending each payload through the query string instead of post data (--method POST is set).
I managed to trace the requests via projectdiscovery proxify + dump logs.
here is a sample of a request made by DalFox:
POST http://targetapp/?login=DalFox HTTP/1.1
Connection: close
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9
Accept-Encoding: gzip
Connection: close
Content-Length: 0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:75.0) Gecko/20100101 Firefox/75.0

... response here ...

The login= should be in post data, not in the URI.
It seems that  MakeRequestQuery() only sends POST request (with content in post-data) when we set -d. But that will ignore all fields/input that the mining analysis found":
Question:
Is this a bug? or dalfox only supports GET/query string fields?
In case dalfox only support GET/query string fields, Is there any plans to add full POST fields support?
Thanks!
Environment

Dalfox Version: current (2.4.7)
Installed from: go-get

Hi @dogasantos
Thank you for submit issue!
First of all, it looks like a bug based on what you shared. I'll check with roll up your sleeves.

thanks @hahwul !

@dogasantos
I looked into the point and testing, develop. First of all, mining for postBody was done only when the --data flag was present, which was changed to allow mining even when methods such as -X were specified.
Solved the issue that makes Mining inaccurate, but ultimately, there need many improvements to the Mining function itself, so if you have any issues, please let us know through the link below when found!
Test
vuln
e.POST("/", func(c echo.Context) error {
                name := c.FormValue("name")
                return c.HTML(http.StatusOK, "asdf\n"+name)
})

$ curl -i -k http://localhost:8070 -X POST -d "query=12
34"
HTTP/1.1 200 OK
Content-Type: text/html; charset=UTF-8
Content-Length: 4

12
34

$ ./dalfox url http://localhost:8070/ -X POST
[V] Triggered XSS Payload (found DOM Object): query=<iframe srcdoc="<input onauxclick=print(1)>" class=dalfox>
    2 line:  <iframe srcdoc="<input onauxclick=print(1)>" class=dalfox>
[POC][V][POST] http://localhost:8070/


Upload Books tab

Administrative Info
Monday Board ID: 853642866
Make sure your branch name conforms to: <feature/staging/hotfix/...>/[username]/[Monday Item ID]-[3-4 word description separated by dashes]. Otherwise, please rename your branch and create a new PR.
Changes
What changes did you make?

Created upload books page on admin site
All books and new books view
Searching and deleting books

Testing
How did you confirm your changes worked?

Toggle between 'All Books' and 'Recent Releases' to make sure appropriate books are displayed
Tested deleting one language, and deleting all languages of a particular book
Made sure search by title and author correctly filters books

Confirmation of Change
Upload a screenshot, if possible. Otherwise, please provide instructions on how to see the change.

Also the search bar is drifting to the right on my device, can you take a look at that?

code looks good, but the screen looks like this on my end

Its too big, not sure if thats ok for right now.

code looks good, but the screen looks like this on my end

Its too big, not sure if thats ok for right now.

Yeah I thought everything seemed too large on my laptop, but I'm pretty sure I used all the measurements in the style guide. I'm assuming the current style guides are optimized for larger desktops and we'll have to add media queries later to support smaller screens? @dacruz21

code looks good, but the screen looks like this on my end

Its too big, not sure if thats ok for right now.

Yeah I thought everything seemed too large on my laptop, but I'm pretty sure I used all the measurements in the style guide. I'm assuming the current style guides are optimized for larger desktops and we'll have to add media queries later to support smaller screens? @dacruz21

Is the navabar change in the new style guide? Or did i mess up following the style guide when making the navbar?I remember it being smaller. The page definitely looks better on my monitor

Is the navabar change in the new style guide? Or did i mess up following the style guide when making the navbar?I remember it being smaller. The page definitely looks better on my monitor

I didn't change any of the navbar styles, I'm pretty sure it was super big when I pulled it. But following the style guides everything seems huge.. I think it only really looks good on a monitor lol

Sorry for the delay, was having issues with react-scripts on my laptop. Back on my desktop now!
I think the layout looks good at any screen size from 720p to 1440p, which should cover most desktop/laptop screen sizes. We don't need to worry about mobile yet so I think we should be good.
Anything you want me to ask the designers about or is this good to land?


Update CFP

Update the submission site in cfp
Update the paper format in cfp
Fix jekyll version
Fix bundler version

Fix bundler version in workflow


Show image's rendered size when zooming in/out

Is your feature request related to a problem? Please describe.
When compressing an image, I usually zoom out to get the image to be of a similar size to how it would be rendered on the page. This way I know that the compression levels I am choosing are suitable for how this image will be displayed on the page.
Describe the solution you'd like
It would be extremely helpful if in addition to the zoom percentage, it also shows the rendered image size (in pixels) as you zoom in/out. I think this could be achieved by multiplying the image's original size with the --scale.
Does other service/app have this feature?
N/A

I like this idea!

Yes, I miss with feature every single time I'm using squoosh. This should be default. The preview should also reflect the new dimensions when rezising.


Abstract sanity check and simulation rules

Alternative mempools (that is not canonical mempool) can use only subset of all sanity check and simulation rules, e.g., only forbidden opcodes. They can also introduce new custom rules that are specific to them.
We should have a way modular way of enabling/turning on certain rules and add way to write custom rules and include them in the verification/validation workflow.
When bundler will received user operation, it will have to match to which alt mempool the user operation should be passed.

Look at: https://github.com/paradigmxyz/reth/blob/main/crates/transaction-pool/src/validate.rs#L30

Something similar for alt mempools: https://github.com/paradigmxyz/reth/blob/main/crates/transaction-pool/src/validate.rs#L111

Proposal
Create two traits: trait SanityCheck and trait SimulationCheck. All the checks implement one of these two traits.
Create trait UserOperationValidator that has function definition fn verify_user_operation.
Create struct CanonicalUserOperationValidator where you can select all the necessary checks:
CanonicalUserOperationValidator::new() .set_sanity_check(SenderOrInitCodeCheck::new()) .set_sanity_check(VerificationGasCheck::new()) .set_simulation_check(StorageAccessCheck::new(whitelisted_slots: [...])) .set_simulation_check(ForbiddenOpcodesCheck::new(ForbiddenOpcodes::default())) .set_simulation_check(SignatureCheck::new())
This is just a first and brief description. What do you think @zsluedem ?

Create two traits: trait SanityCheck and trait SimulationCheck. All the checks implement one of these two traits.

What is the difference between these two checks?(In the perspective of function signature)
Could that be more general just one trait CrazyCheck?

Create two traits: trait SanityCheck and trait SimulationCheck. All the checks implement one of these two traits.

What is the difference between these two checks?(In the perspective of function signature)
Could that be more general just one trait Check?

Hmmm, good point. We can probably merge this into single trait.


/r option for DVDs ignores other flags (such as /rr and /ps)

Version
32 bit, AnsiBuild, 20230413T211754
Describe the bug
When trying to dump a disc with Alpha-ROM that has intentional bad sectors, DIC is unable to finish a reverse dump with /r since it ignores flags such as /rr or /ps, causing the dump to always error out once it reaches the bad sectors. Specific logs are included for the disc I used, but this can be seen on any DVD at all that might need flags such as /rr or /ps. I triple checked, and the sector range used is the correct range to dump the entire disc.
Screenshots
.\DiscImageCreator.exe dvd D "E:\MPF\ISO\MBACverB_Rev\MBACverB_Rev.iso" 16 /r 0 1237023 /rr 1 /ps 0
AppVersion
        32 bit, AnsiBuild, 20230413T211754
CurrentDirectory
        E:\MPF\Programs\Creator
WorkingPath
         Argument: E:\MPF\ISO\MBACverB_Rev\MBACverB_Rev.iso
         FullPath: E:\MPF\ISO\MBACverB_Rev\MBACverB_Rev.iso
            Drive: E:
        Directory: \MPF\ISO\MBACverB_Rev\
         Filename: MBACverB_Rev
        Extension: .iso
StartTime: 2023-05-27T02:52:35-0600
Set the drive speed: 22160KB/sec
DiskSize of [E:\MPF\ISO\MBACverB_Rev]
        Total:<PHONE_NUMBER>872 bytes
         Used:<PHONE_NUMBER>144 bytes
        ---------------------------
        Space:<PHONE_NUMBER>8 bytes
         => There is enough disk space for dumping
LBA[1233359, 0x12d1cf]: [F:ReadDVDReverse][L:77]
        Opcode: 0xa8
        ScsiStatus: 0x02 = CHECK_CONDITION
        SenseData Key-Asc-Ascq: 03-11-05 = MEDIUM_ERROR - L-EC UNCORRECTABLE ERROR
EndTime: 2023-05-27T02:54:36-0600```

**Log file**
[MBACverB Logs.zip](https://github.com/saramibreak/DiscImageCreator/files/11581386/MBACverB.Logs.zip)

DiscImageCreator_test.zip
Added, but not test.

It'll be a while before it finishes running since I'm attempting to dump the whole disc, but there seems to be an issue that's popped up.
        Opcode: 0xa8
        ScsiStatus: 0x02 = CHECK_CONDITION
        SenseData Key-Asc-Ascq: 03-11-05 = MEDIUM_ERROR - L-EC UNCORRECTABLE ERROR
Read retry from 1236980 (Pass 1/1)```

The sector number mentioned first "LBA[1232013" doesn't match the second one "Read retry from 1236980". I'm not sure if it's only a visual bug or if it actually affects the dump.

Some fixed.
DiscImageCreator_test.zip

It looks like the sector numbers not matching is fixed now, thank you! There's a different bug that I just found though, DIC keeps trying to read reversed into negative sectors indefinitely, because it pads those with 00 when the read fails and keeps going in reverse forever. Here's the logs from a test dump I did to check the bug.
DIC 214 Logs.zip

Also, would it be possible to have an option to have the image be rearranged after so that it outputs as a normal image (starting with the first sector read, ending with the last sector read)? Basically I want to compare a full normal dump of the disc with a full reversed dump of the disc and see if there's any differences.

Some fixed.
DiscImageCreator_test.zip

The bugs I mentioned before all seem to be fixed, but now on creating the non-reversed image after the dump was completed, I get an error that just says Failed to read [F:ReadDVDReverse][L:120] after writing EXACTLY 2 GiB (2,147,483,648 bytes) of the second image, so the original reversed image is complete but the second one isn't.
DIC 214 Logs 2.zip

after writing EXACTLY 2 GiB

fixed seek32 -> seek64
DiscImageCreator_test.zip

Still the same exact issue, down to the byte of the file and error message given. I triple checked, and I'm on the latest test version you sent: 32 bit, AnsiBuild, 20230531T113049

Fixed seek offset.
DiscImageCreator_test.zip

Seems to work for me! Finished dumping the disc fully and got a usable ISO.


Creating a Docker webapp fails with NoneType object has no attribute 'reserved'

Stack trace
dan@Azure:~$ az webapp create --resource-group resource-group --plan hosting-plan-eun --name site-name --deployment-container-image-name fiorix/freegeoip:latest
'NoneType' object has no attribute 'reserved'
Traceback (most recent call last):
  File "/opt/az/lib/python3.6/site-packages/azure/cli/main.py", line 36, in main
    cmd_result = APPLICATION.execute(args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/application.py", line 216, in execute
    result = expanded_arg.func(params)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 377, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 618, in _execute_command
    exception_handler(ex)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/appservice/commands.py", line 63, in _polish_bad_errors
    raise ex
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 602, in _execute_command
    result = op(client, **kwargs) if client else op(**kwargs)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/appservice/custom.py", line 52, in create_webapp
    is_linux = plan_info.reserved
AttributeError: 'NoneType' object has no attribute 'reserved'
dan@Azure:~$

The expected output was a json object similar to the one within the docs

Environment summary
This is happened with both the az client under Windows using powershell (azure-cli (2.0.21)) and under the Bash Shell within the Azure web portal.
dan@Azure:~$ az --version
azure-cli (2.0.21)

acr (2.0.15)
acs (2.0.19)
appservice (0.1.20)
backup (1.0.3)
batch (3.1.7)
batchai (0.1.3)
billing (0.1.6)
cdn (0.0.10)
cloud (2.0.10)
cognitiveservices (0.1.9)
command-modules-nspkg (2.0.1)
component (2.0.8)
configure (2.0.12)
consumption (0.1.6)
container (0.1.13)
core (2.0.21)
cosmosdb (0.1.15)
dla (0.0.15)
dls (0.0.18)
eventgrid (0.1.5)
extension (0.0.6)
feedback (2.0.6)
find (0.2.7)
interactive (0.3.11)
iot (0.1.14)
keyvault (2.0.14)
lab (0.0.13)
monitor (0.0.12)
network (2.0.18)
nspkg (3.0.1)
profile (2.0.15)
rdbms (0.0.9)
redis (0.2.10)
reservations (0.1.0)
resource (2.0.18)
role (2.0.14)
servicefabric (0.0.6)
sql (2.0.15)
storage (2.0.19)
vm (2.0.18)

Python location '/opt/az/bin/python3'
Extensions directory '/home/dan/.azure/cliextensions'

Python (Linux) 3.6.1 (default, Nov 10 2017, 16:23:17)
[GCC 4.8.4]

Legal docs and information: aka.ms/AzureCliLegal

dan@Azure:~$

@liv3d can you please check if the app service plan that you are using is a linux app service plan or not?

@ahmedelnably So, I retried now that I've got home by copy/pasting names out of the portal and it worked as expected.
What I believe I may have done earlier on today is typo the resource group name as testing that now does give the stack trace above.

It is a fall out from SDK/azure-mgmt-web breaking change that 404 is not longer treated as an error. I have updated CLI to add a client side verification for this. Please use newer CLI release


update dutch stage amount calcullation

Coverage decreased (-0.09%) to 82.755% when pulling 641d56b6deaad2d7993b9b77aebb4ac5ca7a30ab on a480246862655073_dutch_round_calculation into 99849b6c19f9ddefc7a2a5f889b317f104c90009 on sandbox.


How to use the generation model to generate specific molecules?

Hello,
I was wondering how can I use the generation model to generate specific molecules? For example, I have a small dataset of molecules I am interested in generating, should I use ZINC250k dataset to train GraphAF model on and then use property optimization  to generate novel molecules with desired QED, logP properties or should I use my small dataset(around 4k) to train the GraphAF model?
Thank you kindly,
Looking forward for your reply

Hi! The pretraining dataset determines what kind of molecules you are interested in generating, so you may use your small dataset to train the GraphAF model. If that is too small, a possible solution is to first train on ZINC250k, then finetune on your small dataset and finally finetune on property optimization.


Added 2.6 to travis (SSL fixed), readme updates

Coverage remained the same at 95.21% when pulling c6906519d91321e443dac6f877d69756f97102fb on testing into 12bfe3d5afb2bf4dba2272d7d4d1c2982438c42c on master.


lodash: changed _.constant() method (added to the chainable wrapper, ad…

…ded tests)
https://lodash.com/docs#constant
https://lodash.com/docs#_ (the chainable wrapper description)

@chrootsu thanks mate!


Remove some caching to avoid same result for several calls of same ex…

The PR removes caching for functions as they lead to #87
Also it adds a corresponding testcase.
fixes #87
@bodiam I fear it could require to have a kind of fix release

@snuyanzin hmmm, you might be right, though people could use the snapshot version too. Thanks for fixing it!