Tests: provide a way to generate a simple repository

Related to: #1806
Description of the changes being introduced by the pull request:
I created a new script called "generate_md.py" which can be used
to easily generate a repository. Additionally, I created a new
test file making sure that the locally stored metadata files and
the newly generated metadata roles are the same.
This will allow us to test that we are not changing the metadata
file structure when making changes.
Signed-off-by: Martin Vrachev<EMAIL_ADDRESS>Please verify and check that the pull request fulfills the following
requirements:

[ ] The code follows the Code Style Guidelines
[ ] Tests have been added for the bug fix or new feature
[ ] Docs have been added for the bug fix or new feature

I am not sure how to resolve the mypy issue: https://github.com/theupdateframework/python-tuf/runs/5467473728?check_suite_focus=true
@jku any suggestions?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.311%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1178

Relevant Lines:
1194

💛  - Coveralls

I am not sure how to resolve the mypy issue: https://github.com/theupdateframework/python-tuf/runs/5467473728?check_suite_focus=true @jku any suggestions?

Directories do not become importable packages automatically. You need at least an empty __init__.py

@jku I fixed the mypy issues.
Additionally, I had to add the second commit as on the previous CI run the test failed on all Windows venvs https://github.com/theupdateframework/python-tuf/runs/5467473050?check_suite_focus=true).
The second commit aims to achieve consistency on all operating systems.
The downside to this is that the metadata files won't be human-readable.

The second commit aims to achieve consistency on all operating systems.
The downside to this is that the metadata files won't be human-readable.

That sounds highly undesirable... not to mention that it sounds like a bug somewhere. What is the inconsistency?

@jku I think I have simplified the test script a lot.
The test doesn't require context and it should be a lot better.

I commented a couple of observations/questions, mostly about further simplifying the script. But maybe I'm missing the big picture. In what direction should the script scale?
I'd probably make it just a collection of generate_*_metadata functions, plus helper functions to be re-used by those generation function, like your verification function.

I did it that way before and @jku mentioned that there is no sense in having separate functions now when we generate only one variation per role.
If we enhance this script to generate more variations (as we plan to) it will make sense to have separate generate_*_metadata functions.
@jku has mentioned something like this in his last points here https://github.com/theupdateframework/python-tuf/issues/1806#issuecomment-1060417793.

I'd probably make it just a collection of generate_*_metadata functions, plus helper functions to be re-used by those generation function, like your verification function.

I did it that way before and @jku mentioned that there is no sense in having separate functions now when we generate only one variation per role.

Oh, I probably wasn't clear. I didn't mean that you should split generate_all_files now. I was talking about the future when you have multiple functions that each generate a set of metadata files for a specific use case. So I think we are on the same page here.

@lukpueh I updated the pr with removing the class and a couple of small simplifications.
@jku and @lukpueh it's ready for another review.

@lukpueh because of a GitHub bug the new changes inside test-static-data-generation branch of my fork
weren't noticed. I closed it, but there was no option to reopen it.
That's why I created this new pr.


How to use dictionary and other reference type in the component?

I want to use an array, map other reference types as a field in a component.
Which I think I should use @field.ref.
However, want to know a bit more about its behavior.

Is updating the field like so will mark the component as changed?

@component
export class MyComponent {
    @field.ref declare indexes: {[key: string]: Entity};
}

let myComp = entity.write(MyComponent);
myComp["newItem"] = entity2;
myComp.indexes = myComp.indexes; // Mark the component as changed?

Will I going cause the problem with multi-threading by multiple systems trying to access and modify these ref type fields or referenced Entity?

We chatted about this on Discord:  https://discord.com/channels/654487419407826945/821272559634481152/908375726535897108


How add different meta descriptions on every pages.

Checklist

[x] I have read the newlest tutorials and know the correct effect of the functional design.
[x] There is no similar question on existing issues (including closed ones).
[x] I have tried to find the answer on Jekyll Forum and StackOverflow.
[x] My question is based on the latest code of the master branch.

Description
How add different meta descriptions on every pages. Singe home page description add in every pages. which make duplicate meta description error & it,s also bad for site seo.

It can be done by adding description in the page's front matter.


Stray LICENSE installed into site-packages

Describe the bug
The package installs a stray LICENSE file to the top directory of site-packages.
To Reproduce
$ pip install fakeredis
Collecting fakeredis
  Downloading fakeredis-2.24.0-py3-none-any.whl.metadata (3.8 kB)
Collecting redis>=4 (from fakeredis)
  Using cached redis-5.0.8-py3-none-any.whl.metadata (9.2 kB)
Collecting sortedcontainers<3,>=2 (from fakeredis)
  Using cached sortedcontainers-2.4.0-py2.py3-none-any.whl.metadata (10 kB)
Downloading fakeredis-2.24.0-py3-none-any.whl (97 kB)
Using cached redis-5.0.8-py3-none-any.whl (255 kB)
Using cached sortedcontainers-2.4.0-py2.py3-none-any.whl (29 kB)
Installing collected packages: sortedcontainers, redis, fakeredis
Successfully installed fakeredis-2.24.0 redis-5.0.8 sortedcontainers-2.4.0
$ ls $VIRTUAL_ENV/lib/python*/site-packages
fakeredis                   LICENSE  pip-24.2.dist-info  redis-5.0.8.dist-info  sortedcontainers-2.4.0.dist-info
fakeredis-2.24.0.dist-info  pip      redis               sortedcontainers

Note the LICENSE file that shouldn't be there.
Expected behavior
All files installed into fakeredis directory.
Screenshots
n/a
Desktop (please complete the following information):

OS: Gentoo Linux amd64
python version: 3.12.5
redis-py version: 2.24.0
full requirements.txt? n/a

Additional context
Apparently this is because LICENSE is listed in tool.poetry.packages.

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

thanks for reporting this. Fixed in 2.24.1

Thanks.


crypto: intent signing for Proof of Possession and Narwhal header digest

Description

intent.rs is extracted to a shared-crypto crate so that both sui and narwhal crate to use, LOC incurred by moving packages can be ignored)
(this changes genesis and onchain layout) Add PoP intent: see generate_proof_of_possession and pub fn verify(&self)
Add narwal intent for header digest: see narwhal-crypto and primary.rs
docs follow up: https://github.com/MystenLabs/sui/pull/8727

Test Plan
unit tests for move. narwhal e2e test.

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[x] breaking change for on-chain data layout: Genesis snapshot changes due to proof of possession calculation changes.
[ ] necessitate either a data wipe or data migration

Release notes

Proof of possession now commits to an intent and domain || authority_protocol_pubkey || authority_address

rebased and PTAL @kchalkias @benr-ml

first commit is whitespace moving crates, can ignore
second commit relating pop signing cc @longbowlu
third commit relating narwhal cc @mwtian


Add a labeling feature

Replicate NFD's node labeling feature for the kernel version, but use the node's .status.nodeInfo.kernelVersion field instead.
Users should be able to choose if they want to use NFD or that lightweight node labeler:

if NFD, then set DaemonSet selectors based on the NFD label;
if OOTO, then start an additional controller that merely labels nodes whenever their .status.nodeInfo.kernelVersion changes.

Implemented in #3.


LiveShare SDK does not work in SPFx meeting app

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
Windows
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

SPFx version: 1.18.1
New Teams Web Client
New Teams Desktop Client
Old Teams Web Client
Old Teams Desktop

Describe the bug / error
I was testing the LiveShare SDK with the new SPFx Version 1.18.1 which has the Teams JS version 2.12. The new SPFx version finally fulfills the Teams JS dependency requirement of the GA version of the LiveShare SDK (^2.11) so I gave it a go. Then I sadly found out that the LiveShare SDK is still not working in a SPFx meeting app.
When I start the app in a meeting (sidePanel), my app crashes and I get the error message "The library has not yet been initialized"

I could be able to debug the code and the code crashes on the creation of the LiveShareHost (the class comes from the Teams JS package of the SPFx: @microsoft/teams-js-v2):
const host = LiveShareHost.create();

To test it

I have created a new web part with the SPFx 1.18.1 generator.
Installed the LiveShare SDK packages: npm install fluid-framework @fluidframework/azure-client @microsoft/live-share --save
There is also a dev dependency which needed to be installed (@fluidframework/test-client-utils) - This step is only documented in the getting started documentation of LiveShare SDK
Added the needed code to join to the liveShare container to the code
Packaged and deployed the solution and added the app to a meeting
Joined to the meeting and opened the app

The following code is all you need to join the container:
protected async onInit(): Promise<void> {

    if (!!this.context.sdks.microsoftTeams){
      this.teamsApp = this.context.sdks.microsoftTeams.teamsJs.app;
      await this.teamsApp.initialize();
      if (this.teamsApp.isInitialized()){
        const frameContext = this.teamsApp.getFrameContext();

        if (frameContext === FrameContexts.meetingStage || frameContext === FrameContexts.sidePanel){
          const liveShareJoinResult = await this.joinContainer();
          this.container = liveShareJoinResult.container;
        }
      }
    }

    return this._getEnvironmentMessage().then(message => {
      this._environmentMessage = message;
    });
  }

  private async joinContainer():Promise<ILiveShareJoinResults> {
    // Are we running in teams?
    const host = LiveShareHost.create();

    // Create client
    const client = new LiveShareClient(host);

    // Join container
    return await client.joinContainer(containerSchema);
  }

As you can see in the code I am ensuring that the Teams JS is initialized successfully and I am executing the joinContainer code only in the sidePanel or meetingStage on which liveShare should be available.
I have checked the initialized Teams Js version and it was correct, 2.12
I have also tested the app as mentioned above in the additional env. detail on all available Teams client, on the new one as well on the old one, in web and desktop client.
I have also checked and configured all the prerequisites from the getting started documentation including the RSC permissions: https://learn.microsoft.com/en-us/microsoftteams/platform/apps-in-teams-meetings/teams-live-share-capabilities?tabs=javascript#prerequisites
@AJIXuMuK : Please check the issue. You have the best knowledge of the history of it :) Thanks a lot!!
Steps to reproduce

I have created a new web part with the SPFx 1.18.1 generator.
Installed the LiveShare SDK packages: npm install fluid-framework @fluidframework/azure-client @microsoft/live-share --save
There is also a dev dependency which needed to be installed (@fluidframework/test-client-utils) - This step is only documented in the getting started documentation of LiveShare SDK
Added the needed code to join to the liveShare container to the code
Packaged and deployed the solution and added the app to a meeting
Joined to the meeting and opened the app

Expected behavior
That I can create and join to a liveShare container in a SPFx meeting app.

@canturan - the library should be initialized by our code. You should not call initialize again.
And as you pass the initialized check - seems like something additional should be done for the LiveShare SDK...
I'm not too familiar with the LiveShare part and why it would not work...

Is there any updates on this topic?

@canturan Did you ever end up finding a solution to this? I am having the same issue.

Never mind- accessing LiveShareHost from BaseClientSideWebPart instead of importing directly from @microsoft/teams-js worked.
this.context.sdks.microsoftTeams.teamsJs.LiveShareHost.create()


Allow saving one file for all label vs different files for each label

Is your feature request related to a problem? Please describe.
Currently, SlicerCART saves all label in one file and do not offer the option to the user to save segmentatino masks in one or multiple files.
Describe the solution you'd like
Option selection for saving one file for all label vs different files for each label

Do we only want to give the following two options:

All labels
Every single label separately

Or do we give the user to choose which labels?

The user should have the option to chosse!
Almost done.
Assigned myself to the issue :)


Remove more polyfills for old browsers

Note that there's a number of additional polyfills which we ought to be able to remove, but we'd need to make a final decision regarding the exact IE and Android versions we'll support with PDF.js 2.0.
If we decide that IE 11 is the lowest supported version (which seem reasonable given https://en.wikipedia.org/wiki/Internet_Explorer_version_history#Release_history_for_desktop_Windows_OS_version), and similarly for Android 5 (given https://en.wikipedia.org/wiki/Android_version_history), then we could remove even more code.

/botio-linux preview

/botio test

Thank you for cleaning this up!


Error while creating Teleport token from PIN

When I execute python main.py --pin {ccnnn}, I get the result:
ERROR:root:'cryptography.hazmat.bindings._rust.x509.Certificat' object has no attribute '_x509'
Upon first trying to generate the token, I got a warning about having an old version of pyOpenSSL, followed by this error:
value=certificate_digest(self._cert._x509),  # type: ignore ERROR:root:[WinError 2] The system cannot find the file specified
After upgrading, I get the error message stated above(top).
Is there anything more I can provide to help resolve the issue?

...so, after reading back and forth about newer versions of the Python Cryptography libraries, I decided to uninstall the new pyOpenSSL, and then just use pip install "Cryptography==38"
This meant that I got the initial warning messages back, but also gave some more insight about the (probable) root cause of this issue: some sort of file access/permission gone wrong. This is way beyond my skills to sort out, so instead I hand you this Python error log output, and hope it may shed some light:
C:\Users\m\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-packages\Python38\site-packages\aiortc\rtcdtlstransport.py:211: CryptographyDeprecationWarning: This version of cryptography contains a temporary pyOpenSSL fallback path. Upgrade pyOpenSSL now.
  _openssl_assert(lib.SSL_CTX_use_certificate(ctx, self._cert._x509) == 1)  # type: ignore
C:\Users\m\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-packages\Python38\site-packages\aiortc\rtcdtlstransport.py:186: CryptographyDeprecationWarning: This version of cryptography contains a temporary pyOpenSSL fallback path. Upgrade pyOpenSSL now.
  value=certificate_digest(self._cert._x509),  # type: ignore
Traceback (most recent call last):
  File "main.py", line 31, in <module>
    print(connect_device(deviceToken))
  File "C:\Users\m\Downloads\teleport-main\teleport.py", line 218, in connect_device
    return loop.run_until_complete(coro)
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.8_3.8.2800.0_x64__qbz5n2kfra8p0\lib\asyncio\base_events.py", line 616, in run_until_complete
    return future.result()
  File "C:\Users\m\Downloads\teleport-main\teleport.py", line 146, in _connect_device_peer
    privateKey, publicKey = _generate_wg_keys()
  File "C:\Users\m\Downloads\teleport-main\teleport.py", line 21, in _generate_wg_keys
    privateKey = subprocess.check_output(["wg", "genkey"],
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.8_3.8.2800.0_x64__qbz5n2kfra8p0\lib\subprocess.py", line 415, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.8_3.8.2800.0_x64__qbz5n2kfra8p0\lib\subprocess.py", line 493, in run
    with Popen(*popenargs, **kwargs) as process:
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.8_3.8.2800.0_x64__qbz5n2kfra8p0\lib\subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.8_3.8.2800.0_x64__qbz5n2kfra8p0\lib\subprocess.py", line 1311, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] The system cannot find the file specified```
There are two files created in the same folder, named `teleport_token_0` and `teleport_uuid`, and they do contain data that seem relevant to the task.


sparkrkernel raises 'Could not start session: EPERM: operation not permitted' error

Issue Type: Bug
Restarted an instance of Azure Data Studio with two notebooks open. Touched nothing and allowed the screen to render. Notebooks rendered very quickly but kernel was loading. After several seconds, received this error:
Could not start session: EPERM: operation not permitted, unlink 'C:\Users\viharp\AppData\Roaming\jupyter\kernels\sparkrkernel\kernel.json'

The kernel indeed did not load for one of two open notebooks. The other loaded successfully. Both are Python notebooks.

Attempting to change the kernel from None shows another error, "Failed to change kernel due to error: Cannot start a session, the manager is not yet initialized"

Logs from above:
| console.(anonymous function) | @ | C:\Program Files\Azu…t\zone-node.js:2280
-- | -- | -- | --
  | onDidNotificationChange | @ | workbench.main.js:165962
  | _register.model.onDidNotificationChange.e | @ | workbench.main.js:165950
  | fire | @ | workbench.main.js:10023
  | notify | @ | workbench.main.js:170307
  | notify | @ | workbench.main.js:250588
  | handleModelError | @ | workbench.main.js:308565
  | model.onError | @ | workbench.main.js:308498
  | fire | @ | workbench.main.js:10023
  | notifyError | @ | workbench.main.js:161340
  | (anonymous) | @ | workbench.main.js:161551
  | rejected | @ | workbench.main.js:5984
  | ZoneDelegate.invoke | @ | C:\Program Files\Azu…st\zone-node.js:388
  | Zone.run | @ | C:\Program Files\Azu…st\zone-node.js:138
  | (anonymous) | @ | C:\Program Files\Azu…st\zone-node.js:872
  | ZoneDelegate.invokeTask | @ | C:\Program Files\Azu…st\zone-node.js:421
  | Zone.runTask | @ | C:\Program Files\Azu…st\zone-node.js:188
  | drainMicroTaskQueue | @ | C:\Program Files\Azu…st\zone-node.js:595
  | ZoneTask.invokeTask | @ | C:\Program Files\Azu…st\zone-node.js:500
  | ZoneTask.invoke | @ | C:\Program Files\Azu…st\zone-node.js:485
  | emit | @ | events.js:182
  | addChunk | @ | _stream_readable.js:279
  | readableAddChunk | @ | _stream_readable.js:264
  | Readable.push | @ | _stream_readable.js:219
  | onread | @ | net.js:636
Azure Data Studio version: azuredatastudio-insiders 1.9.0-insider (095f35d07eaae649a4a850c62dc475acd6135f6d, 2019-06-28T18:14:54.653Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7600U CPU @ 2.80GHz (4 x 2904)

GPU Status
2d_canvas: disabled_softwarechecker_imaging: disabled_offflash_3d: disabled_softwareflash_stage3d: disabled_softwareflash_stage3d_baseline: disabled_softwaregpu_compositing: disabled_softwaremultiple_raster_threads: disabled_offnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwaresurface_synchronization: disabled_offvideo_decode: disabled_softwarewebgl: disabled_offwebgl2: disabled_off

Load (avg)
undefined

Memory (System)
15.84GB (3.64GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (8)

Extension
Author (truncated)
Version

admin-pack
Mic
0.0.2

admin-tool-ext-win
Mic
0.0.1

agent
Mic
0.40.0

dacpac
Mic
0.3.0

import
Mic
0.8.0

profiler
Mic
0.9.0

schema-compare
Mic
0.4.0

azdata-sanddance
msr
1.2.0

Closing due to no repro


failed to run the demo

I found the extract image function store .jpg file on S3.
While the following function try to find .png file on S3 which will popup error like no key found on S3.

Please try enable X-ray as it is not on by default.

The problem is in the first step that extracts video frame and you may check the Lambda log. You may see the problem related to X-ray.

X-ray.docx
Please follow this word documents to enable X-Ray.

Hello Cyrus,
I have enabled x-ray, and i am also getting same issue. When i go in processing it shows error : collection id student not found.
But when i pass code in cli it shows  collection with id student.
'CollectionIds': ['facestore', 'student'],
'FaceModelVersions': ['2.0', '2.0'],
'ResponseMetadata': {'HTTPHeaders': {'connection': 'keep-alive',
'content-length': '75',
'content-type': 'application/x-amz-json-1.1',
'date': 'Thu, 01 Mar 2018 02:34:31 GMT',
'x-amzn-requestid': '12c9f606-1cf9-11e8-933d-f3253bdc093f'}
Can you help in debug this situation.

You have to follow https://aws.amazon.com/blogs/machine-learning/analyze-emotion-in-video-frame-samples-using-amazon-rekognition-on-aws/
Deploying HowWhoFeelInVideo
step 1 to create your image collection.

Thanks Cyrus, I have gone through many a times. Yesterday i changed environment parameter in process lambda it was written collectionId and corrected to CollectionId. Now it dont give error student not found. But processing still fails and error is unknow. With Yellow sign in xray.

Is there any possibility to share the aws credentials with you. And you can have a look what is common mistake everyone do even following tutorial step by step. Or there is a problem “ no such key found” in the program. I hope we can work on that part. If possible Please email me on<EMAIL_ADDRESS>i will share credentials and can work for finding actual cause.
Regards,
Tej


Bings Route Direction Directive for the Driving path

Hi @thor-schueler  Do we have any wrapper for native direction service of bings map to get the driving route?I tried creating the directive to do it but ran into "Microsoft not defined issue" even though i included the triple slash directive import.Do we have to generate the route data  and call polyline directive.I'm new to bings and angular 4.Thanks

We currently do not have support for the Directions module. That being said, you can use the Directions module directly to get your directions and print them on the map. You would need to load the directions module into the BingMapService. There are some hooks for that in the service already as we load other modules. You would not really need to create a polyline directive since the directions module takes care of putting the route onto the map. There is a JS sample at https://www.bing.com/api/maps/sdkrelease/mapcontrol/isdk#directionsCreateDrivingRoute+JS
If you are interested in adding support for the directions module to angular maps, I can provide some guidance.
Re the "Microsoft not defined issue", you probably ran afoul of the breaking change in the MSFT BingMaps types package. See #44 for an explanation and let me know whether this solves the Microsoft not defined issue.

A directions directive would be super helpful.  If that isn't possible how would I integrate the JS sample above into a layered map with other markers?


Blink v0.12.6 removed functions AtomShell.isinstalled() and AtomShell.install() used in KomaMRI.jl

This causes an error when compiling Koma.

@beorostica  Can you check if this commit fixes the problem? Or is it better to also change the compat of Blink to 0.12.6?

I tested the project with the new commit in a fresh installation with Julia 1.8.4. The UI is working without a any problem.


[Feature Request] Add support for new Ecommerce API feature

Which Gelato package(s) are relevant/related to the feature request?
No response
Description
Gelato added a new Ecommerce API feature that is currently missing in this repo.
Proposed solution
Add support for Ecommerce feature.
Alternatives considered
N/A

Closed by #49


Unable to configure platform netgear during homeassistant startup

Home Assistant release with the issue:

Since 0.68.1, also happen in 0.70.1
Last working Home Assistant release (if known):
Before 0.68.1 but cannot remember which version I had.
Operating environment (Hass.io/Docker/Windows/etc.):

Hassbian
Component/platform:

netgear
Description of problem:
Since I have upgraded to 0.68.1, the netgear platform showed the following error whenever I restarted homeassistant:
2018-06-02 09:14:32 ERROR (Thread-11) [pynetgear] <?xml version="1.0" encoding="UTF-8"?>
<SOAP-ENV:Envelope
   xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/"
   SOAP-ENV:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
<SOAP-ENV:Body>
<m:GetAttachDeviceResponse xmlns:m="urn:NETGEAR-ROUTER:service:DeviceInfo:1">    <NewAttachDevice>0</NewAttachDevice><NewAttachDevice> </NewAttachDevice>
</m:GetAttachDeviceResponse>
<ResponseCode>000</ResponseCode>
</SOAP-ENV:Body>
</SOAP-ENV:Envelope>

2018-06-02 09:14:32 ERROR (Thread-11) [pynetgear] Error parsing device-list: ['0']
2018-06-02 09:14:32 ERROR (Thread-11) [homeassistant.components.device_tracker.netgear] Failed to Login
2018-06-02 09:14:32 ERROR (MainThread) [homeassistant.components.device_tracker] Error setting up platform netgear

There is no change on my netgear router configuration (including username, password). My router is netgear WNR2200. This is one of the errors that I get, another time, when there was new device detected, it also throw an error but with values within xxx a string that contains all the device mac addresses. In that scenario, it complained about the XML being invalid.
2018-06-02 12:00:06 ERROR (MainThread) [homeassistant.components.device_tracker] Error setting up platform netgear
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/device_tracker/__init__.py", line 176, in async_setup_platform
    platform.get_scanner, hass, {DOMAIN: p_config})
  File "/usr/lib/python3.5/asyncio/futures.py", line 380, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.5/asyncio/tasks.py", line 304, in _wakeup
    future.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/device_tracker/netgear.py", line 52, in get_scanner
    devices, excluded_devices, accesspoints)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/device_tracker/netgear.py", line 74, in __init__
    results = self.get_attached_devices()
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/device_tracker/netgear.py", line 159, in get_attached_devices
    return self._api.get_attached_devices()
  File "/srv/homeassistant/lib/python3.5/site-packages/pynetgear/__init__.py", line 84, in get_attached_devices
    ".//m:GetAttachDeviceResponse/NewAttachDevice")
  File "/srv/homeassistant/lib/python3.5/site-packages/pynetgear/__init__.py", line 284, in _parse_xml_response
    root = ET.fromstring(response)
  File "/usr/lib/python3.5/xml/etree/ElementTree.py", line 1344, in XML
    parser.feed(text)
  File "<string>", line None
xml.etree.ElementTree.ParseError: not well-formed (invalid token): line 6, column 246

No change to the homeassistant configuration.yaml around the netgear platform either.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
device_tracker:
  - platform: netgear
     consider_home: 1800
     track_new_devices: yes
     interval_seconds: 600
     host: XXXXXXX
     port: 80
     username:  XXXXXXX
     password: !secret XXXXXX

Traceback (if applicable):
2018-06-02 09:14:32 ERROR (Thread-11) [pynetgear] <?xml version="1.0" encoding="UTF-8"?>
<SOAP-ENV:Envelope
   xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/"
   SOAP-ENV:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
<SOAP-ENV:Body>
<m:GetAttachDeviceResponse xmlns:m="urn:NETGEAR-ROUTER:service:DeviceInfo:1">    <NewAttachDevice>0</NewAttachDevice>
</m:GetAttachDeviceResponse>
<ResponseCode>000</ResponseCode>
</SOAP-ENV:Body>
</SOAP-ENV:Envelope>

2018-06-02 09:14:32 ERROR (Thread-11) [pynetgear] Error parsing device-list: ['0']
2018-06-02 09:14:32 ERROR (Thread-11) [homeassistant.components.device_tracker.netgear] Failed to Login
2018-06-02 09:14:32 ERROR (MainThread) [homeassistant.components.device_tracker] Error setting up platform netgear

and sometimes
<SOAP-ENV:Envelope
   xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/"
   SOAP-ENV:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
<SOAP-ENV:Body>
<m:GetAttachDeviceResponse xmlns:m="urn:NETGEAR-ROUTER:service:DeviceInfo:1">    <NewAttachDevice>THE CONTENT HERE IS REMOVE BECAUSE IT CONTAINS MAC ADDRESSES</NewAttachDevice>
</m:GetAttachDeviceResponse>
<ResponseCode>000</ResponseCode>
</SOAP-ENV:Body>
</SOAP-ENV:Envelope>

2018-06-02 12:00:06 ERROR (MainThread) [homeassistant.components.device_tracker] Error setting up platform netgear
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/device_tracker/__init__.py", line 176, in async_setup_platform
    platform.get_scanner, hass, {DOMAIN: p_config})
  File "/usr/lib/python3.5/asyncio/futures.py", line 380, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.5/asyncio/tasks.py", line 304, in _wakeup
    future.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/device_tracker/netgear.py", line 52, in get_scanner
    devices, excluded_devices, accesspoints)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/device_tracker/netgear.py", line 74, in __init__
    results = self.get_attached_devices()
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/device_tracker/netgear.py", line 159, in get_attached_devices
    return self._api.get_attached_devices()
  File "/srv/homeassistant/lib/python3.5/site-packages/pynetgear/__init__.py", line 84, in get_attached_devices
    ".//m:GetAttachDeviceResponse/NewAttachDevice")
  File "/srv/homeassistant/lib/python3.5/site-packages/pynetgear/__init__.py", line 284, in _parse_xml_response
    root = ET.fromstring(response)
  File "/usr/lib/python3.5/xml/etree/ElementTree.py", line 1344, in XML
    parser.feed(text)
  File "<string>", line None
xml.etree.ElementTree.ParseError: not well-formed (invalid token): line 6, column 246

Additional information:
Not sure if this is an issue with pynetgear or homeassistant at the moment.
I have modified the script to print out the XML payload.

I am using the netgear component just fine on my Nighthawk X8 on 0.70.1  I wonder if the error is more related to track_new_devices.  I know the component got updated recently as well probably in 0.68.

Thanks Daniel. It is interesting that it works on your netgear. I checked if there is any update of my netgear firmware and it is up to date.
In re: track_new_devices, do you know which python files got modified since 0.68? I can have a look at the git history and see if I can revert the changes in my local installation to troubleshoot further?

This was the last PR according to Github: https://github.com/home-assistant/home-assistant/pull/13331

I have the same problem with my WNDR4500, and I believe the problem is introduced by the pynetgear upgrade from 0.3.3 to 0.4.0.

Please send me the full output by mail, this is useless to me.

Hi @MatMaul,
Here is a snippet of the XML and the not well-formed error. Hope it helps.
2018-07-08 10:09:06 ERROR (Thread-20) [pynetgear] <?xml version="1.0" encoding="UTF-8"?>
<SOAP-ENV:Envelope
   xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/"
   SOAP-ENV:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
<SOAP-ENV:Body>
<m:GetAttachDeviceResponse xmlns:m="urn:NETGEAR-ROUTER:service:DeviceInfo:1">    <NewAttachDevice>6@1;<IP_ADDRESS>;GOOGLE-HOME-MINI;11:22:24;wireless;61;11;Allow@2;<IP_ADDRESS>;LALALA;11:22:33:44:55:66;wireless;121;11;Allow@3;<IP_ADDRESS>;;11:22:33:44:55:79;wireless;2;50;Allow@4;<IP_ADDRESS>;XXX;11:22:33:44:55:66;wireless;64;61;Allow@5;<IP_ADDRESS>;DDD;11:11:11:11:22:33;wireless;71;78;Allow@6;<IP_ADDRESS>;GFRTER;11:11:22:22:33:44;wireless;11;11;Allow</NewAttachDevice>
</m:GetAttachDeviceResponse>
<ResponseCode>000</ResponseCode>
</SOAP-ENV:Body>
</SOAP-ENV:Envelope>

2018-07-08 10:09:06 ERROR (MainThread) [homeassistant.components.device_tracker] Error setting up platform netgear
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/device_tracker/__init__.py", line 176, in async_setup_platform
    platform.get_scanner, hass, {DOMAIN: p_config})
  File "/usr/lib/python3.5/asyncio/futures.py", line 380, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.5/asyncio/tasks.py", line 304, in _wakeup
    future.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/device_tracker/netgear.py", line 52, in get_scanner
    devices, excluded_devices, accesspoints)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/device_tracker/netgear.py", line 74, in __init__
    results = self.get_attached_devices()
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/device_tracker/netgear.py", line 159, in get_attached_devices
    return self._api.get_attached_devices()
  File "/srv/homeassistant/lib/python3.5/site-packages/pynetgear/__init__.py", line 84, in get_attached_devices
    ".//m:GetAttachDeviceResponse/NewAttachDevice")
  File "/srv/homeassistant/lib/python3.5/site-packages/pynetgear/__init__.py", line 284, in _parse_xml_response
    root = ET.fromstring(response)
  File "/usr/lib/python3.5/xml/etree/ElementTree.py", line 1344, in XML
    parser.feed(text)
  File "<string>", line None
xml.etree.ElementTree.ParseError: not well-formed (invalid token): line 6, column 245

Let me know if you need more information.

Cf #15078 last comment, I'll have a look but holidays right now. Also for further reports would be nice to use pynetgear GitHub instead 😉

I have no idea what is happening regarding this not well-formed XML, I get no error when trying to parse the reported strings. Tried with python2.7, python3.5 and python3.6 on my fedora and my raspbian.

Probably some illegal non printable character in the device name...
I'll make a test branch with filtering of forbidden characters later this week:
https://stackoverflow.com/questions/1707890/fast-way-to-filter-illegal-xml-unicode-chars-in-python
If someone is fluent enough to try this on their own before, be my guest ;)

Hey @MatMaul, I am happy to give this a try this weekend and let you know.

Tried to reproduce the "not well-formed" issue today, and unable to because it is always returning empty NewAttachDevice whenever "GetAttachDevice" is called. Restarted my router and it is still the same. This is causing another error but I don't think this is an error - it is an empty payload.
2018-07-28 10:35:32 ERROR (Thread-18) [pynetgear] <?xml version="1.0" encoding="UTF-8"?>
<SOAP-ENV:Envelope
   xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/"
   SOAP-ENV:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
<SOAP-ENV:Body>
<m:GetAttachDeviceResponse xmlns:m="urn:NETGEAR-ROUTER:service:DeviceInfo:1">    <NewAttachDevice>0</NewAttachDevice>
</m:GetAttachDeviceResponse>
<ResponseCode>000</ResponseCode>
</SOAP-ENV:Body>
</SOAP-ENV:Envelope>

2018-07-28 10:35:32 ERROR (Thread-18) [pynetgear] Error parsing device-list: ['0']
2018-07-28 10:35:32 ERROR (Thread-18) [homeassistant.components.device_tracker.netgear] Failed to Login
2018-07-28 10:35:32 ERROR (MainThread) [homeassistant.components.device_tracker] Error setting up platform netgear

I updated the code a little to gracefully handle the "0" case, thanks for the feedback.
New version released, update sent to home-assistant.
home-assistant/home-assistant#15768
Next time please open a bug against pynetgear directly.
Thanks !

still reproduced on 0.78.3.

@MatMaul and @gsemet, I think I found the root cause of this issue - apparently my netgear returns a non-printable character (DLE) in the response if it is unable to find the device name (empty device name). As a result, pynetgear was unable to parse the response.
I have raised an issue at https://github.com/MatMaul/pynetgear/issues/46 and suggested a workaround/fix.
Hopefully this will be the end of this - have been having this issue for many months now :)


Feature request: Autokeras / Automl

Using an automl solution would make it even easier to train your own models without being an expert.
Furthermore, Ludwig would get new models / encoders on a regular basis by integrating the Autokeras API.
For example, new features like object recognition would be provided by the Autokeras team.
How hard would it be or is it even possible to integrate the Autokeras API?
https://autokeras.com/auto_model

@flozi00  we are already working on a hyperparameter optimization extension as we announced a few months ago.
Regarding Autokeras. The architecture of Ludwig is substantially different in particular in how it treats the outputs. Ludwig has a compositional way of defining models while autokeras has a monolithic way of doing that, so there won't be any integration.
What people can do is actually adding input encoders and output decoders, which are much more useful than monolithic models as they can be reused for several different tasks.

Thank you for the answer !


[core] Add optional "defaultTime" argument

We are adding an optional "defaultTime" argument to the "getTimeParams",
which defaults to "last15Minutes". This allows to overwrite the default
selected time in for example dashboards.
This feature is now used for the cost management in the Azure plugin to
set the default selected time range to 7 days. The formaly selected 15
minutes time range doesn't returned any data from the Azure API.
We also fixed a small scrolling bug for the cost management page in the
Azure plugin.

[x] I added a CHANGELOG entry for this change.
[ ] I adjusted the corresponding documentation for this change.
[ ] I adjusted the values.yaml file and the documentation for all values.

Codecov Report

Merging #283 (5489142) into main (71b2555) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   44.89%   44.89%
=======================================
  Files          96       96
  Lines        8032     8032
=======================================
  Hits         3606     3606
  Misses       4394     4394
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b2555...5489142. Read the comment docs.


jobs running while node-resque is recycled

What happens to jobs that are running while node-resque is recycled or if it crashes. It looks like any jobs in running status are cleared along with the workers?
Is it possible to retrieve a list of jobs that were scheduled but never completed?
Thanks

You can either look at the 'workingOn' jobs, and re-enqueue them, or error them out and use the error retry functions

Got it - Thanks

Sorry to restart this, but I've been unable to find the redis keys where the workingOn jobs are stored. Are these keys cleared as part of the worker clean up on restart?
Thanks

The code is here: https://github.com/taskrabbit/node-resque/blob/master/lib/queue.js#L365-L369
Yes, it is part of the worker's status.

maybe I'm missing something but isn't this something that should be the normal behavior?
For example, lets say I have a few dozen jobs currently in execution and the host and/or the  node-resque process crashes. Wouldn't the normal restart/recovery be to take whatever was in the previous workers' workingOn status and move them to the fail queue?

You can absolutely implant your code to do that.
It can't be standard because not all jobs want to be retried.  Perhaps sending 0 emails to the user is better than 2.

I get your point, but wouldn't the result of the scenario I described be that you wouldn't know if the user got an email at all? in other words instead of 0 or 2 - it would be an unknown.  If we move the 'workingOn' jobs to failed, then we get the  choice of retrying. With the worker status being cleared, I don't know if I missed a job and possibly the user never got an email at all.

Yep, that's how these types of job queues work.  You have to make tradeoff choices in your implementation based on the retry-ability, immutability, and permutability of your jobs.  There design patterns to store incremental state should you need it, so that you can always retry a job without harmful side-effects, but that is usually overkill for most folks.
For the email example, most apps I've worked on tend to be OK with a "mostly" delivered pattern... no need to retry.  Of course, we try not to crash and operate safely whenever we can.


Custom dataset import not functional in 1.8.22

When trying use the sentiment inference script given as example in demos/aspect_polarity_classification/ with a dataset made according to the guidelines provided in the ABSADatasets repository, an exception is raised during a detect_infer_dataset call.
At line 157, if os.path.isdir(max(d, search_path)): returns TypeError: '>' not supported between instances of 'NoneType' and 'str'.
Probably, the issue lies in the use of max on search_path and d, the later being first defined as a string, and then as an element of an iteration on a DatasetItem (line 147,  for d in dataset_path:).
Perhaps if not dataset_items: dataset_items = dataset_name in the class's __init__ (lines 47 and 48) is not the best way to do it, especially considering that dataset_name could have been defined as os.path.basename(dataset_name) prior to this, which sometimes returns an empty string.
In may be worth noting I use Databricks and its file storage system DBFS, which already seemed to affect the definition of the dataset_items of a DatasetItem object in (recent) previous versions: some paths end up with empty corresponding dataset_items lists. Although, it also seems that is the case on local environments like Windows.
Full stack:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<[command-759931538946855]()> in <module>
     41 results_mentions = sent_classifier.batch_infer(target_file=inference_sets_mentions,
     42                                                print_result=True,
     43                                                save_result=True,
---> 44                                                ignore_error=True,
     45                                               )

/local_disk0/.ephemeral_nfs/envs/pythonEnv-7eb1071f-0a42-4abe-bfbc-2f7e07c89670/lib/python3.7/site-packages/pyabsa/core/apc/prediction/sentiment_classifier.py in batch_infer(self, target_file, print_result, save_result, clear_input_samples, ignore_error)
    186         save_path = os.path.join(os.getcwd(), 'apc_inference.result.json')
    187
--> 188         target_file = detect_infer_dataset(target_file, task='apc')
    189         if not target_file:
    190             raise FileNotFoundError('Can not find inference datasets!')

/local_disk0/.ephemeral_nfs/envs/pythonEnv-7eb1071f-0a42-4abe-bfbc-2f7e07c89670/lib/python3.7/site-packages/pyabsa/functional/dataset/dataset_manager.py in detect_infer_dataset(dataset_path, task)
    155
    156     if len(dataset_file) == 0:
--> 157         if os.path.isdir(max(d, search_path)):
    158             print('No train set found from: {}, unrecognized files: {}'.format(dataset_path, ', '.join(os.listdir(max(d, search_path)))))
    159         raise RuntimeError('Fail to locate dataset: {}. If you are using your own dataset,' ' you may need rename your dataset according to {}'.format(

TypeError: '>' not supported between instances of 'NoneType' and 'str'

That is a problem, indeed. I will fix it soon, Also, I would like to ask for some advice.
Would you like to make a PR to improve this block?

Sure, here it is: https://github.com/yangheng95/PyABSA/pull/133
Please note I only changed the __init__ of DatasetItem and tested the result locally (Windows 10), and on one task only. So there very well may be other places that I don't know of where change is needed... You'll know better than me where to look for those, @yangheng95 !
Also, I probably have wrongly understood what you wanted to do with dataset_name. If that's the case, please accept my apologies and ignore this PR. Some more comments would be handy, though.

It doesn't fix everything when I tested it, but works better when given a path and not just the name.
Perhaps you can consider separating the two in some way? With the argument dataset_path in addition to dataset_name in the __init__ , both defaulting to None (and both attributes in the DatasetItem object). That would enable choosing to use either one or the other whenever are test is done.


Implement ITlsTokenBindingFeature

http://tools.ietf.org/html/draft-popov-token-binding-00
http://tools.ietf.org/html/draftbalfanz-https-token-binding-00
http://www.ietf.org/proceedings/91/slides/slides-91-uta-2.pdf
https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNetCore.Http.Features/ITlsTokenBindingFeature.cs
This requires new APIs on SslStream, and Win10+.

.NET 4.6.1: https://msdn.microsoft.com/en-us/library/system.security.authentication.extendedprotection.tokenbinding(v=vs.110).aspx
Not net available on .NET Core.

cc @cesarbs

If this is important, we can reopen.

@davidfowl Yes please, we'd like to support tokenbinding in https://github.com/abergs/fido2-net-lib/


Is it possible to show 6 rows always?

Is it possible to show 6 rows always?
Currently the height of the calendar is changing based on the number of days. Instead can we have fixed height or fixed rows in a month so that height changing issue gets resolved.

@rakeshnayak360 Check out the fixedHeight prop. I think that is what you want.

Is it possible to show 5 rows always?


IT-3421 Add missing build arg' to Docker build

The reverse proxy container can be built to work with Jupyter or RStudio notebooks.  To switch between the two requires a build-arg called notebook_type which we lost during the work on the GitHub workflow. This PR restores the argument.

could you reference the commit where this arg was lost in?

It's here:
https://github.com/Sage-Bionetworks-IT/notebook-reverse-proxy/pull/10/files
When we added in the second Docker build we omitted the build-arg.


Fix Random URL to provide more valuable URLs

dsfgsdfgjdsfgkljklsdajfkljskladdlfgk :satisfied:

You just made my day :smile:


keyFile not working since 8.0.10

Steps to reproduce:

Download service account credentials JSON file
Create Logging instance with path to JSON: new Logging({ keyFile: 'path/to/credentials.json' });
Receive error:<redacted>\node_modules\google-gax\build\src\fallback.js:59
             throw new Error(JSON.stringify(options) +
             ^

Error: {"servicePath":"logging.googleapis.com","port":443,"clientConfig":{},"fallback":true,"libName":"gccl","libVersion":"8.0.10","scopes":["https://www.googleapis.com/auth/cloud-platform","https://www.googleapis.com/auth/cloud-platform.read-only","https://www.googleapis.com/auth/logging.admin","https://www.googleapis.com/auth/logging.read","https://www.googleapis.com/auth/logging.write"],"keyFile":".\\gcp-logging-credentials.json"}You need to pass auth instance to use gRPC-fallback client in browser. Use OAuth2Client from google-auth-library.
 at new GrpcClient (<redacted>\node_modules\google-gax\build\src\fallback.js:59:23)
 at new ConfigServiceV2Client (<redacted>\node_modules\@google-cloud\logging\build\src\v2\config_service_v2_client.js:88:25)
 at new Logging (<redacted>\node_modules\@google-cloud\logging\build\src\index.js:126:30)
 [...]
```

This is happening in all versions since 8.0.10 and is working until 8.0.9. Might be related to https://github.com/googleapis/nodejs-logging/pull/935.

I'm not sure we ever (intentionally, anyway) meant to support keyFile. Instead, it's keyFilename. Could you give that a shot?

I tried both, it's the same behavior. Seems to be an alias: https://github.com/googleapis/google-auth-library-nodejs/blob/b4d139d9ee27f886ca8cc5478615c052700fff48/src/auth/googleauth.ts#L140

Thanks @protyposis for the report. Seems like the new fallback detection logic did not work well for your case :(
Can you try passing fallback: false to the constructor? (so it becomes new Logging({ keyFile: 'path/to/credentials.json', fallback: false }))  Apparently it thinks you're in browser - any chance you have a global window object?

...also, if you could provide the output of npm ls, it would be helpful too. Thank you!

fallback: false works, and I indeed have global.window set to an empty object (seems to be a pollution from a 3rd party package).  npm ls output is extremely long so here's it in a gist: https://gist.github.com/protyposis/cba664e4ee10dfcbf20655f6081fd7f0
Thanks for the fast feedback!

Thank you! I will probably change the detection to look at window.fetch or something like that, more browser specific. It will never get perfect but will reduce the amount of false browser detections.


Expose the History query functionality

Makes the history querying structs and enums pub as it seems reasonable
for now. Useful to create nushells history command.
Might make sense to change that API to something simpler cleaner later.
Relevant to nushell/nushell#5721

looks good to me


Policy Deployment Error - Unable to download deployment content

Describe the bug
When you try to deploy to either a Management Group or Subscription from this "Deploy to Azure" action. At the following link:
https://github.com/Azure/Enterprise-Scale/tree/main/azopsreference
I receive the following error for the deployment:
Unable to download deployment content from 'https://raw.githubusercontent.com/Azure/AzOps/main/template/template.json'. The tracking Id is 'c468a903-0961-4c7f-ac75-120604d6b4df'. Please see https://aka.ms/arm-deploy for usage details. (Code: InvalidContentLink)
Steps to reproduce

Visit here: https://github.com/Azure/Enterprise-Scale/tree/main/azopsreference
Choose either Deploys the policyDefinition of your choice to a management group or Deploys the policyDefinition of your choice to a subscription
Run through the deployment choosing any region and any one of the Policy Definitions.
You will get the error during Template Validaiton.

Screenshots

Thank you. We are about to deprecate the azopsfolder and the individual policy deployment. To get the policies, I highly recommend deploying the reference implementation(s)

Understood, I do think its a nice feature to be able to "test drive" an individual policy without having to deploy the entire landing zone. Also, you may not have the permissions to interact with constructs such as AAD and/or Management Groups if using a MSDN/VS type Azure subscription. Thanks for your reply.

We have added a button to deploy all policies to a management group now. Can you see if this solves it for you?

I think it's the other way. Sorry if that was confusing. So the same intent as the original two deploy buttons. Just have them work. So be able to deploy individual CAF inspired policies definition to either the subscription or management group scope. That would help me be able to test drive these at a subscription level or management group on the customer side.


[FEATURE REQ] InboundNatRuleData should contain a BackendAddressPool property

Library name
Azure.ResourceManager.Network v1.1.0
Please describe the feature.
InboundNatRuleData is missing a BackendAddressPool property.
This is found in the REST API.
It also provided by the deprecated Microsoft.Azure.Management.Network package.

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

The REST API doc is based on API version 2022-07-01 while the Azure.ResourceManager.Network v1.1.0 SDK is based on 2021-02-01. Therefore, we need to bump the API version to support the BackendAddressPool property in InboundNatRuleData.

The new version was released @itai, please try the latest version from nuget.


Assignments to components of fields within a struct array are optimized away by the runtime optimizer

Description
The following code leaves c[0].rgb[0] in an undefined state when the runtime optimizer is used:
struct custom { color rgb; };

custom c[1];
c[0].rgb[0] = 123;
printf("rgb: %g\n", c[0].rgb);
printf("rgb: %g\n", c[0].rgb[0]);

Patch add ability to have a test pass who's diff operation fails.
Fixes nothing related to the bug, but adds a test showing the behavior.

Checklist:

[x] I have read the contribution guidelines.
[x] I have previously submitted a Contributor License Agreement.
[x] I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
[x] My code follows the prevailing code style of this project.

Are you already working on a solution, or just giving us the test and assuming that I'll find the fix?
I'm truly not saying that in an accusatory way... I'm very happy to jump right on fixing this, but I don't want to do the work if it's a waste because you already are in the middle of it but haven't posted a PR yet.

I assume nothing, so have at it!
Was trying to fix it in olsc, but didn't get far and realized the runtime optimizer would probably still have to be addressed in case one loaded an oso compiled with an older version.

Yeah, I'm happy to take a stab at this.

Good luck. In case it not too obvious already, it looked to be  generating tmps for every access and not getting the aliasing or r/w boundary right.  Which cause the runtime optimizer to think is can be elided as a useless write.
c[0].rgb[0] = 123; ->
const	int	$const1	0		%read{0,17} %write{2147483647,-1}
temp	color	$tmp1	%read{2147483647,-1} %write{0,0}
const	color	$const2	1 2 3		%read{1,1} %write{2147483647,-1}
temp	color	$tmp2	%read{3,3} %write{2,2}
temp	float	$tmp3	%read{4,4} %write{3,3}
temp	float	$tmp4	%read{6,6} %write{4,4}
temp	color	$tmp5	%read{2147483647,-1} %write{5,6}
code ___main___
# test.osl:10
#     c[0].rgb = color(1,2,3);
	aref		$tmp1 c.rgb $const1 	%filename{"test.osl"} %line{10} %argrw{"wrr"}
	aassign		c.rgb $const1 $const2 	%argrw{"wrr"}
# test.osl:13
#     c[0].rgb[0] = -c[0].rgb[0];
	aref		$tmp2 c.rgb $const1 	%line{13} %argrw{"wrr"}
	compref		$tmp3 $tmp2 $const1 	%argrw{"wrr"}
	neg		$tmp4 $tmp3 	%argrw{"wr"}
	aref		$tmp5 c.rgb $const1 	%argrw{"wrr"}
	compassign	$tmp5 $const1 $tmp4 	%argrw{"wrr"}


Refactoring tests

I've refactored some tests, using:

assertCount instead of count function;
assertInternalType and assertNotInternalType instead of is_* functions;
assertContains instead of in_array function;
assertGreaterThan for mathematical comparisons;
assertNull and assertNotNull instead of strict comparison with null keyword;
assertTrue instead of strict comparison with true keyword;
assertFalse instead of strict comparison with false keyword;
assertArrayHasKey instead of isset function;
assertSame instead of comparisons == and strict comparisons ===.

Very cool, will review and test the tests!


Refactor Generator

Closes #1774
Description
Most of the works is just reoganizing logic

Removed branching logic based on template type in Generator.generate function.  This logic was all moved to the TemplateType structs.  This helps us generalize a bit better without needing special handling for each new type (i.e. README.md, tests, and anything else in the future.
Added a "TestTemplate" for generating tests instead of embedding this logic inside of Contract templates

I feel like this could be potentially abstracted further by breaking the template files themselves out of the generator, but probably out of scope for this PR/unnecessary right now and I think what's been changed in this PR is already an improvement.

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

Codecov Report
Attention: Patch coverage is 61.58940% with 58 lines in your changes missing coverage. Please review.

Project coverage is 29.56%. Comparing base (3b885aa) to head (4137f5f).

Files with missing lines
Patch %
Lines

internal/super/generator/generator.go
70.90%
8 Missing and 8 partials :warning:

internal/super/setup.go
0.00%
14 Missing :warning:

internal/super/generate.go
0.00%
9 Missing :warning:

internal/super/generator/contract_template.go
78.04%
7 Missing and 2 partials :warning:

internal/super/generator/test_template.go
66.66%
4 Missing :warning:

internal/super/generator/script_template.go
70.00%
3 Missing :warning:

internal/super/generator/transaction_template.go
70.00%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1772      +/-   ##
==========================================
- Coverage   29.65%   29.56%   -0.09%
==========================================
  Files          89       94       +5
  Lines        5197     5175      -22
==========================================
- Hits         1541     1530      -11
+ Misses       3469     3466       -3
+ Partials      187      179       -8

Flag
Coverage Δ

unittests
29.56% <61.58%> (-0.09%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@jribbink You tested this manually with init, generate, and with the custom directory flag in generate?


Italian translation

Hi. We've updated xml files with new notifications. Could you translate please? 😇


Print item call number if not empty. If empty, print holdings call number.

Hi,
I've tried both "Ex Libris parsing <parsed_call_number>" and "SpineOMatic parsing <call_number>", but they all print the holding call numbers only.  However, I want to print the holding call number only if item call number is empty and print the item call number if it's not empty.  Is there a way I can include this instruction in the program?  We use parse routine 5 in Alma.
Here is my current setting.

This is our item in Alma.  Note that the end of the holding and item call numbers are different.

Many thanks as always for your guidance.
Best regards,
Katie

@KatieLai, I believe you are looking for the <alternative_call_number> element in the XML response from Alma. You could select the "SpineOMatic parsing" radio button and specify the "<alternative_call_number>" as the source of the information. Unfortunately, I don't believe there is a way to do "either this call number or that call number"....at least I'm not seeing any way documented on the Wiki page.

Thank you @mgobat
Yes, that's what I did as a work around -- Using Spine Label type template for call numbers taken from the holding records, and a Custom Label type template for those taken from the item records.  It would be good to have the either or function though so that we can save the custom template for something else.

@KatieLai, I'll change this to an enhancement request.

@KatieLai,
If I understand this issue correctly, it's not possible for SpinOMatic to choose to print the <alternative_call_number> element and then, if this is empty, to print the holding's call number?
So your solution is to use two templates with two different sources? Does this mean that you first select the template with the source <alternative_call_number> element, and if nothing appears, you select the second template with the holding call number ?
Thanks for your help
Camille


New update turns the view black after closing the view

Hi
I just updated my app with the newest update to this project.
Now, when i close a card, the screen turns black.
I also tried it with the demo app, and it also turns itself black.
I am looking into the issue. And will post update as soon as i have found the bug.
But if you have found it, let me know.

Check out bug #131 && #121
find shouldPresent function and I replace detailVC.isFullscreen = fullscreen with
detailVC.modalPresentationStyle = .fullScreen

Check out bug #131 && #121
find shouldPresent function and I replace detailVC.isFullscreen = fullscreen with
detailVC.modalPresentationStyle = .fullScreen

let card = CardHighlight(frame: CGRect(x: 10, y: 30, width: 200 , height: 240))
card.backgroundColor = UIColor(red: 0, green: 94/255, blue: 112/255, alpha: 1)
card.icon = UIImage(named: "flappy")
card.title = "Welcome \nto \nCards !"
card.itemTitle = "Flappy Bird"
card.itemSubtitle = "Flap That !"
card.textColor = UIColor.white
card.hasParallax = true
let cardContentVC = storyboard!.instantiateViewController(withIdentifier: "CardContent")
card.shouldPresent(cardContentVC, from: self, fullscreen: false)
view.addSubview(card)
Xcode 11.4.1
Project Deployment Target iOS13.0
Target Deployment iOS 13.0
Device iOS 13.3.1

Check out bug #131 && #121
find shouldPresent function and I replace detailVC.isFullscreen = fullscreen with
detailVC.modalPresentationStyle = .fullScreen

Hello, after modifying according to your method, the problem remains
Xcode 11.4.1
Project Deployment Target iOS13.0
Target Deployment iOS 13.0
Device iOS 13.3.1

can confirm this solved the problem.
still had it in iOS 14 Thanks!

In the function "shouldPresent" of file Card.swift add the following code:
under detailVC.isFullscreen = fullscreen
need add
if fullscreen {
detailVC.modalPresentationStyle = .fullScreen
}
else {
detailVC.modalPresentationStyle = .currentContext
}
it worked for me


fix ceilometer serverspec errors

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

ok to test

Verified on my environment :+1:


Problem with multiple  elements inside a  top level node

I believe the following issue belongs here as well -
https://github.com/MicrosoftDocs/azure-docs/issues/42343
Though it may be a problem with the Cognitive service overall.

Given the attached issue is fixed, could you check if this one is fixed as well?


Moved WindowsFormsIntegration area

[Fixes Issue ](issue: [ Migrate ] WindowsFormsIntegration Area - Feature Tests) #67
Description
Adds the WindowsFormsIntegration Area - Feature Tests
Customer Impact
Developers can run the tests using .\RunTests.cmd /Area=WindowsFormsIntegration command and test their fixes.
Testing
Built and ran the tests.
Microsoft Reviewers: Open in CodeFlow

/azp run

/azp

/azp run

Closing this PR, we have raised another PR for the same and that has been merged- https://github.com/dotnet/wpf-test/pull/230.


Update to Apache AGE's directory on PGXN

AGE on PostgreSQL Extension Network (PGXN) is outdated. The last release on the website is 1.1.0, and the description (including the README) is stale. Do you think this can be updated?
Link to Apache AGE's directory on PGXN: https://pgxn.org/dist/apacheage/

@eyab Would this be something you could look into?

@Allison-E @jrgemignani PR #1711 should resolve this issue once merged.


Question about why SGD does not work

I have this problem: When I changed the value of lr or decay in SGD, I find that nothing changed in my result. (I fixed random number by using np.random.seed(1234))

The problem was solved for I made a stupid mistake by using "optimizer = 'sgd'".


[Feature request] Check for all ruby files to have frozen_string_literal pragma

I've tried searching for this one through the project but to no avail. Hence the feature request: it [w|c]ould be a good idea to add a check for presence of frozen_string_literal pragma either in all ruby files or only in new ruby files that go through the git hooks pipeline.
I know about the "if you want it - make a PR" rule, and, although this doesn't look like a very complicated check to implement, I'm not yet that familiar with Overcommit, and I think that for someone more experienced with all this it would take much less time to implement, than for someone new. But, if no one will, I guess I'll probably get to it, eventually.

There is a rubocop cop for that :)
https://docs.rubocop.org/rubocop/cops_style.html#stylefrozenstringliteralcomment


Fixed #32820 -- Added 'aria-invalid="true"' to fields with errors.

Ticket: #32820
Previous PR: https://github.com/django/django/pull/16933

@smithdc1 Thanks +1 I left small suggestions.

@smithdc1 I'd be happy to push edits if you're busy.

@smithdc1 I'd be happy to push edits if you're busy.

If you could, that would be great. 🥳

@smithdc1 I pushed edits :+1: I will check it again tomorrow.


Add CI/CD automation

This PR implements CI/CD automation that provides coverage-tools package build and NPM publish and updates Readme.

Note: Status badge link in readme should be updated when related pipeline definition will be created


Single Fetch Issues

Note: I'm still working on the migration/testing, so I kept this title vague for now in case I come across other problems.
Reproduction
https://stackblitz.com/edit/remix-run-remix-tfwhw2?file=app%2Froutes%2F_index.tsx
System Info
Vite: 5.2.10
Remix: 2.9.1

System:
    OS: macOS 14.4.1
    CPU: (10) arm64 Apple M2 Pro
    Memory: 80.28 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.12.2 - /opt/n/bin/node
    npm: 10.5.0 - /opt/n/bin/npm
    pnpm: 8.15.7 - /opt/homebrew/bin/pnpm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Browsers:
    Chrome: 124.0.6367.78
    Safari: 17.4.1

Used Package Manager
pnpm
Expected Behavior
Happy to split this out into separate issues, but while migrating to Single Fetch, I've found two issues:

From the Single Fetch overview doc:

If you are currently returning Response instances from your loaders (i.e., json/defer) then you shouldn't need to make many changes to your app code, but please read through the "breaking" changes below to be aware of some of the underlying behavior changes - specifically around serialization and status/header behavior.

This is in the reproduction, but for the existing use case with json(), the application crashes:
export const loader = ({ response }: LoaderFunctionArgs) => {
  return json({}, {
    headers: {
      'X-Test-Header': 'Foo-Bar'
    }
  })
}

json and other utilities now require the headers key to be an instance of Headers.
It could be as simple as checking if result.result.headers instanceof Headers before calling proxyResponseToResponseStub, or making the headers argument of proxyResponseToResponseStub something like headers: Headers | Record<string, string>, and handling it accordingly.

This is half question, half bug report.

From the Single fetch headers doc:

To alter the status of your HTTP Response, set the status field directly:
response.status = 201

However, the response stub is potentially undefined (the type in the doc calls this out as well). When is response stub undefined? Having to use a non-null assertion every time doesn't feel right, and typescript throws The left-hand side of an assignment expression may not be an optional property access. if trying to do something like response?.status = 200
Actual Behavior

The type of json would be correct and disallow plain objects for headers or support them
Clear documentation on when the response stub is undefined or improved ways of handling things like redirects (The doc mentions the current utilities are deprecated)

After looking at this a bit more, even a simple:
export const loader = () => {
  return json({})
}

throws the same error:
TypeError: headers.getSetCookie is not a function or its return value is not iterable
    at proxyResponseToResponseStub (file:///home/projects/remix-run-remix-tfwhw2/node_modules/@remix-run/server-runtime/dist/single-fetch.js:292:25)
    at eval (file:///home/projects/remix-run-remix-tfwhw2/node_modules/@remix-run/server-runtime/dist/single-fetch.js:61:9)
    at async Promise.all (index 1)
    at async eval (file:///home/projects/remix-run-remix-tfwhw2/node_modules/@remix-run/server-runtime/dist/single-fetch.js:39:19)
    at async callDataStrategyImpl (file:///home/projects/remix-run-remix-tfwhw2/node_modules/@remix-run/router/dist/router.cjs.js:4169:17)
    at async callDataStrategy (file:///home/projects/remix-run-remix-tfwhw2/node_modules/@remix-run/router/dist/router.cjs.js:3702:19)
    at async loadRouteData (file:///home/projects/remix-run-remix-tfwhw2/node_modules/@remix-run/router/dist/router.cjs.js:3677:19)
    at async queryImpl (file:///home/projects/remix-run-remix-tfwhw2/node_modules/@remix-run/router/dist/router.cjs.js:3522:20)
    at async Object.query (file:///home/projects/remix-run-remix-tfwhw2/node_modules/@remix-run/router/dist/router.cjs.js:3416:18)
    at async handleDocumentRequest (file:///home/projects/remix-run-remix-tfwhw2/node_modules/@remix-run/server-runtime/dist/server.js:222:15)

Found the culprit. installGlobals without nativeFetch uses remix's own polyfill, which doesn't implement headers.getSetCookie. Docs like this one are a bit misleading. The docs aren't clear on whether or not it installGlobals should be called for custom servers.

I am having the same problem with vercel.
Here is my reproduction code.
https://github.com/coji/remix-vercel-single-fetch-test
I was wondering where to put installGlobals since it's not a custom server.

I commented on the Vercel Fork, but I will leave it there in case it may help.
I'm getting this error too. I tried to use node 20 if it solves the issue, but it's the same.
The server is not accessible (Just blank screen).
Mine is just a local dev environment.
I tried to dig deeper a little bit and there I see this line: https://github.com/remix-run/remix/blob/7b2fa032cd465c7f6e9c8d90471d6a544e0c08f6/packages/remix-server-runtime/single-fetch.ts#L350
Even the comments themselves acknowledge the presence of certain typing issues.
I want to contribute to solve this issue, but i'm not a yet great JS dev myself 😅 .

Regarding the headers issue - It looks like we may have missed this call out in the docs and only included it in the release notes: https://github.com/remix-run/remix/blob/main/CHANGELOG.md#single-fetch-unstable
Single fetch requires using the built-in fetch on node 20, or passing the new option to installGlobals({ nativeFetch: true }) in your custom server.
I’ll get that added to the docs 👍

Just came back here to say the same thing. Rereading the release notes and saw it.

To recap here, I think this can be closed out?

was due to a missing installGlobals({ nativeFetch: true }) - we added a call out to the docs inhttps://github.com/remix-run/remix/pull/9335.
is a duplicate of https://github.com/remix-run/remix/issues/9314 and being addressed in https://github.com/remix-run/remix/pull/9349.  We are adding the response stub to resource routes to eliminate the ambiguity, and I think we are also probably going to look into a LoaderFunctionArgs override in the future/single-fetch.d.ts file so we don't have to introduce response as optionl when apps have not opted into single fetch.

Please let me know if anything is still outstanding and we can re-open!

I have enabled Single Fetch in my Remix (with Vite) project. It's working locally, but not on Vercel. I am seeing headers.getSetCookie is not defined error, and a blank page.
I am using Node 20. I am calling installGlobals({ nativeFetch: true }) in vite.config.ts

There's an issue for the problem with Vercel at https://github.com/vercel/remix/issues/109 where I posted a workaround.


update sources

sources added since previous update

Looks ok other than that change to .gitignore. Please revert that and I can accept this.

Whoops. Still a lot I need to learn about Git. I assumed that changes I made AFTER the pull request wouldn't get added to it retroactively.

Ok, good to go, more commits waiting on a branch until this one is done.

I went ahead and merged this so you're not blocked, but I won't be able to actually deploy until late tonight at the earliest.


ENH: add DiscreteUniform

#52 left out the DiscreteUniform distribution (it is commented out right now). I misunderstood the errors that TFP was raising, which was ironed out in https://github.com/tensorflow/probability/issues/286. All that remains is to properly implement the DiscreteUniform distribution (most of it is written, we just need to iron out the type casting).

I'll get to it in #70.

Will it be supported by samples at the time of merge?

Sorry for the question, @ferrine, but do you mean, "will it support sampling by time of merge"? Or is it something else?

Oh, a typo. I meant do whether we support discrete variables in pymc4 for now? As I remember, TFD does not support this by default.
I even found some relebant issue on SO


Device connection restored 423 error

Could be an issue due to timing.
Scenario: A device is DISABLED in core-metadata due to a lost connection and then that connection is restored
Action: The rfid-llrp-inventory-service sniffs a ReaderEventNotification to know that the device has connected, however a failure in querying the device causes it to not be added to the default reader group.
rfid-llrp-inventory-service logs
level=INFO ts=2021-06-29T23:03:59.609388766Z app=rfid-llrp-inventory source=controller.go:123 msg="Adding device to default group: SpeedwayR-11-25-D6"
level=ERROR ts=2021-06-29T23:03:59.609880492Z app=rfid-llrp-inventory source=controller.go:83 error="device info request failed with status 423" device=SpeedwayR-11-25-D6 msg="Failed to handle ReaderEventNotification."

device-rfid-llrp-go logs
level=INFO ts=2021-06-29T23:03:59.593299178Z app=edgex-device-rfid-llrp source=device.go:470 device=SpeedwayR-11-25-D6 msg="Device connection restored."
level=INFO ts=2021-06-29T23:03:59.593358051Z app=edgex-device-rfid-llrp source=logging.go:25 type=MsgGetSupportedVersion device=SpeedwayR-11-25-D6 msg="Sending LLRP message"
level=INFO ts=2021-06-29T23:03:59.593893146Z app=edgex-device-rfid-llrp source=logging.go:34 type=MsgErrorMessage device=SpeedwayR-11-25-D6 msg="Incoming LLRP message"
level=WARN ts=2021-06-29T23:03:59.593946153Z app=edgex-device-rfid-llrp source=logging.go:38 message-version=Version1_0_1 client-version=Version1_1 msg="LLRP incoming message version mismatch"
level=INFO ts=2021-06-29T23:03:59.607062967Z app=edgex-device-rfid-llrp source=logging.go:25 type=MsgSetReaderConfig device=SpeedwayR-11-25-D6 msg="Sending LLRP message"
level=INFO ts=2021-06-29T23:03:59.607314102Z app=edgex-device-rfid-llrp source=logging.go:34 type=MsgSetReaderConfigResponse device=SpeedwayR-11-25-D6 msg="Incoming LLRP message"
level=ERROR ts=2021-06-29T23:03:59.609737045Z app=edgex-device-rfid-llrp source=command.go:64 msg="SpeedwayR-11-25-D6 is disabled; GET"
level=INFO ts=2021-06-29T23:03:59.614819052Z app=edgex-device-rfid-llrp source=device.go:119 msg="Updated device: SpeedwayR-11-25-D6"

Adding a retry to the ds.GetCapabilities(device) call inside the NewReader(device string) function is one workaround:
level=INFO ts=2021-06-29T23:39:00.403912546Z app=rfid-llrp-inventory source=controller.go:123 msg="Adding device to default group: SpeedwayR-11-25-D6"
2021/06/29 16:39:00 failed: device info request failed with status 423, trying again in 250ms
level=INFO ts=2021-06-29T23:39:00.664325288Z app=rfid-llrp-inventory source=controller.go:126 msg="Successfully added device to default group: SpeedwayR-11-25-D6"


Deploying a vLLM server with LMFE support

Are there any examples of using lm-format-enforcer as part of a backend (akin to outlines)?

@noamgat I'm working on this right now and I have a question.
I have extended the vLLM server API as in the outlines implementation, allowing me to issue e.g. the following request:
response = requests.post("http://host:port/generate", json={
    "prompt" : "The best language for type-safe systems programming is ",
    "regex" : "(Python|Java|C|C\+\+|C#|JavaScript|PHP|Swift|Go|Ruby|TypeScript|Kotlin|Rust)",
    "max_tokens" : 10
})

When this call arrives at the vLLM server, I need to build the corresponding LogitsProcessor. E.g. like this:
build_vllm_logits_processor(llm.tokenizer.tokenizer, RegexParser(regex_string))

This line is taking over 35s for the example request above. Is this normal/expected? Is there a way to cache at least the ...TokenizerData?

The same thing happens with the JsonSchemaParser.

Yes, its possible to cache the tokenizer data.
vllm intergration has 'build_vllm_token_enforcer_tokenizer_data()' function, and the result can be passed as the first parameter
to build_vllm_logits_processor():
def build_vllm_logits_processor(llm: Union[vllm.LLM, PreTrainedTokenizerBase, TokenEnforcerTokenizerData],
                                character_level_parser: CharacterLevelParser,
                                analyze: bool=False) -> VLLMLogitsProcessor:

When adding vLLM support, could you help adapt to the openai api scenario?
For example, a typical use case I use for vllm is starting a backend with
python -m vllm.entrypoints.openai.api_server --model llama-model

Then in a piece of python code, I query the backend with
        openai.api_key = "EMPTY"
        openai.api_base = "http://localhost:8000/v1"
        response = openai.ChatCompletion.create(
            model=llama-model,
            messages=messages
        )

Can this scenario be intergrated into lm-format-enforce?
I am thinking maybe have the lm format specified when settign up the backend. So
python -m vllm.entrypoints.openai.api_server --model llama-model --template generation_template.json

Of course, I am not an expert and can not implement this, so just giving out suggestions here.

@br3no , the latest versions greatly improved the tokenizer cache build time. Can you check if there is a significant improvement on your side?

https://github.com/vllm-project/vllm/pull/3868 - If this feature interests you, please show your interest in this PR in vLLM which adds support for it in vLLM.

vLLM 0.4.1 was released with support for LMFE, see this project's README for instructions.


Verify file extension before trying to parse Collada XML (.dae) files…

Before trying to parse a Collada XML file in mesh_loader.cpp's getMeshUnitRescale(), verify the file extension. This function is called for all files that are loaded via Open Asset Import Library (Assimp) (#1366)
NOTE: I do not have any Collada files for testing, this needs to be done before accepting this PR.

I wonder if there could be any other extension used for collada (or maybe none at all?), otherwise +1

None that I am aware of or that googling pointed me to.

@rhaschke we could add some test-cases for collada with #1364

Instead of ignoring files based on their suffix, I suggest to silently ignore xml parse errors:
If the file couldn't be parsed in first place, this would be handled before.

true, so ROS_DEBUG instead of ROS_ERROR or complete silence?

Yes.

which one :D complete silence?

ROS_DEBUG will be fine

Integrated alternative patch 68a375a into #1365.


Seagrass duplication bug

When you right-click on Greenery's seagrass with a seagrass item in your main hand, the seagrass will emit breaking particles but remain, and it will also drop a new duped seagrass. (maintening right click will basically generate infinite amount of seagrass). This bug also work in survival mode.

mod version where I found the bug: Greenery-1.12.2-4.3

What's your version of Fluidlogged API?

it's Fluidlogged-API-v2.2.4-mc1.12.2.jar

Could you try it with the latest version on Modrinth?
https://modrinth.com/mod/fluidlogged-api/versions#all-versions

Okay, thanks for the report

I can not reproduce it only with Greenery installed. Do you have any other mods installed?
I presume it is an issue with some "right-click to harvest" mod.

Actually yes is it, because  I tested with only greenery loaded and there wasn't the bug, but it showed up with Quark:RotN Edition, with the "right-click to harvest" module on.

here is the mod list that I have used to reproduce the bug

and when the "right-click to harvest" module from Quark is set to off, the bug doesn't appear

Okay, thanks. I will try to fix it, somehow.

@Mindr0ide can you test if this is still present in v4.4?

Fixed in v4.4


UserCode crashes if reading a file containing an empty string.

It should delete the file if it is malformed.

fix for this staged for 0.2.1


Remove file type whitelisting limitations

Currently only a few file types are whitelisted and therefore scanned. Add additional file types or maybe a heuristic to scan the correct files (e.g. text only files no binary files)

Maybe this is helpful: https://gist.github.com/ppisarczyk/43962d06686722d26d176fad46879d41


python3Packages.pillow & python3Packages.pillow-simd: Fix cross compilation

Fixes the build time error:
ModuleNotFoundError: No module named 'setuptools'.
Description of changes
Added setuptools on nativeBuildInputs, so that it's available at build time when cross compiling.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux (cross compiled from x86_64-linux)
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

The hook should make setuptools available, even when cross-compiling.

This causes over 13k rebuilds in total.  Why merge directly to master?

Don't the docs say that small changes go to master? Or did I miss something?
I just saw that the CONTRIBUTING.md file got recently expanded from the time I created this PR, maybe I just missed something new there, I'll go re-read it. Sorry!

The automatic red rebuild-* labels are there to signify that the PR is probably too large a rebuild.  I'm sure it's expected that contributors with little experience may not know things like that; so IMHO this is more of a responsibility of the person who does the merge (though it's nice when others notice and comment about it, too).

Reapplied in 094bfcf23765


Tokens affected by a Token Image rule element do not become partially transparent when hidden

Video:
output.webm
Tested on B309 in electron client

This is much less meaningful but I think this also affects the "flip horizontal" setting, though that feels more expected and potentially desireable
It could be that the token image rule element would benefit from a flip setting if we wanted to pull out all the stops


Do you need onStartupFinished?

Describe the bug
When you are onStartupFinished activated, you compete with vscode for start up time and as a result, you hurt vscode's full startup time in the process.
It's better to be reactive and only activate when the user interacts with your extension:

via a command
via a view being visible

To Reproduce
Steps to reproduce the behavior:

Go to vscode.dev
install codetour
reload the window
codetour is activated

Expected behavior
It shouldn't activate until needed.
Additional context
The line in the package.json is here:
https://github.com/microsoft/codetour/blob/main/package.json#L34
Activation events for your reference (even though I know you know where these are)
https://code.visualstudio.com/api/references/activation-events

This project seems to be abandoned, I can't even get a code review on the feature I've contributed. I wouldn't expect this to get changed unless you write the change yourself. Perhaps we should fork the project and release our fork to the vs code marketplace?


⚠ Sinister has degraded performance

In 001413b, Sinister (http://sinister.ly/index.php) experienced degraded performance:

HTTP code: 200
Response time: 3757 ms

Resolved: Sinister performance has improved in 5f462c9.


Change the file name of media in path

Hey,
When I upload an image, the file name automatically uses an uid (/6/PM6ZOjY2EwOPOVEQhOexcanxsxQ7pA2jPfMmgDhx.jpg). However, inside the dropzone, a craftable option is available for setting a filename, but this only changes the custom_properties.
Can this option really changes the file name for seo purposes?
- http://localhost:8000/media/6/PM6ZOjY2EwOPOVEQhOexcanxsxQ7pA2jPfMmgDhx.jpg
+ http://localhost:8000/media/6/my-custom-filename.jpg

Hi,
thanks for this suggestion. This might look like a bug but it is actually expected behavior. However, we will try to figure out internally if it should work like this by default, or if it should be able to be changed per project and will get back to this issue afterwards.


Any plans to make neuralcoref avaliable on PyPI?

Hi,
First of thanks for the tool! I was just wondering if there were any plans to stick neuralcoref on PyPI?
I have uploaded My own project to PyPI, but because it depends on en-coref-md, trying to install it with pip install throws the following error:
Packages installed from PyPI cannot depend on packages which are not also hosted on PyPI.
saber depends on en-coref-md @ https://github.com/huggingface/neuralcoref-models/releases/download/en_coref_md-3.0.0/en_coref_md-3.0.0.tar.gz

Alternatively, if anyone knows install packages on PyPI with direct dependencies I would love to hear it, thanks!

The latest release (4.0) is now on PyPI

Awesome, thanks!


Quick_replies and Postback doesn't work. Is botkit for learning how to create bot or bot intended to be used?.

I wonder if everything is ok with botkit and if it is the right tool to use for a serious bot or just for testing how bot works. I ask myself is it my codes or logic or botkit?
I am using botkit version 0.5.2 to build facebook bot and I've been having serious problems:
Quickreplies : when someone click on a quick reply button nothing is as event his getting triggered (neither triggering a message_received nor postack event);
Persistent Menu: the postback button is not working (neither triggering a message_received nor postack event).
Sometimes they work, sometimes they don't with the same code and then sometimes I change the code; I am really confused, I would like to know if the problem is with my version of botkit?
here is a sample of my code for quick reply,(when the quick_reply is clicked the bot is not being even contacted and sometimes it is working:
bot.startConversation(message, function (error, convo) {
                convo.ask({
                            "text": "Should I find for you ?",
                            "quick_replies": [
                                {
                                    "type": "postback",
                                    "title": "Team",
                                    "payload": "TEAM"
                                },
                                {
                                    "type": "postback",
                                    "title": "Players",
                                    "payload": "PLAYER"
                                }
                            ]
                }, [{
                        pattern: "Team", callback: function (response, convo) {
                            saveStep("FIND_TEAM", message.user, "");
                            convo.ask("Which Product are you looking for ?", function (response, convo) {
                                saveStep("WHAT", response.user, response.text);
                                convo.say('Which team do you like?');
                                convo.next();
                            });

                    }
                    }, {
                            pattern: "Service Provider", function(response, convo) {
                                            saveStep("FIND_PLAYER", message.user, "");
                                            convo.ask("Players from which country ?", function (response, convo) {
                                                saveStep("WHAT", response.user, response.text);
                                                convo.say('Who is your favorite player?');
                                                convo.next();
                                            });
                        }
                        }]);
            });

I also noticed some quick replies won't fire from time to time, or the payload will be ignored. Always considered this is an issue with Facebook API, not our beloved Botkit. Would be interesting to have feedbacks from people having successful bots built with Botkit or Botkit creators!


ViewOperation adds Render Pattern

:tada: This PR is included in version 1.0.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


AssertionError

When I change the dataset to my own dataset, I will run this error when I run train.py.
I c:\tf_jenkins\home\workspace\release-win\device\gpu\os\windows\tensorflow\stream_executor\dso_loader.cc:135] successfully opened CUDA library nvcuda.dll locally
I c:\tf_jenkins\home\workspace\release-win\device\gpu\os\windows\tensorflow\stream_executor\dso_loader.cc:135] successfully opened CUDA library curand64_80.dll locally
Loaded dataset voc_2007_trainval for training
Set proposal method: gt
Appending horizontally-flipped training examples...
Traceback (most recent call last):
voc_2007_trainval gt roidb loaded from D:\python\project\FasterRcnn\FasterRcnn\Faster-RCNN-TensorFlow-Python3.5-master\data\cache\voc_2007_trainval_gt_roidb.pkl
File "D:/python/project/FasterRcnn/FasterRcnn/Faster-RCNN-TensorFlow-Python3.5-master/train.py", line 209, in
train = Train()
File "D:/python/project/FasterRcnn/FasterRcnn/Faster-RCNN-TensorFlow-Python3.5-master/train.py", line 69, in init
self.imdb, self.roidb = combined_roidb("voc_2007_trainval")
File "D:/python/project/FasterRcnn/FasterRcnn/Faster-RCNN-TensorFlow-Python3.5-master/train.py", line 48, in combined_roidb
roidbs = [get_roidb(s) for s in imdb_names.split('+')]
File "D:/python/project/FasterRcnn/FasterRcnn/Faster-RCNN-TensorFlow-Python3.5-master/train.py", line 48, in
roidbs = [get_roidb(s) for s in imdb_names.split('+')]
File "D:/python/project/FasterRcnn/FasterRcnn/Faster-RCNN-TensorFlow-Python3.5-master/train.py", line 45, in get_roidb
roidb = get_training_roidb(imdb)
File "D:/python/project/FasterRcnn/FasterRcnn/Faster-RCNN-TensorFlow-Python3.5-master/train.py", line 25, in get_training_roidb
imdb.append_flipped_images()
File "D:\python\project\FasterRcnn\FasterRcnn\Faster-RCNN-TensorFlow-Python3.5-master\lib\datasets\imdb.py", line 119, in append_flipped_images
assert (boxes[:, 2] >= boxes[:, 0]).all()
AssertionError
Process finished with exit code 1

Perhaps you didn't deleate the voc_2007_trainval_gt_roidb.pkl under data/cache

You can Comment out the" append_flipped_images "


Implement automated MacOS 11 (Big Sur) builds

Implement a GitHub action that uses MacOS runner to automatically build MacOS binary for each pull request.

According to the docs it may be possible to use a custom docker container
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontainerimage
This way we could try use the one provided by Fyne to cross compile and package for all platforms.

https://developer.fyne.io/started/cross-compiling
Supported:

GOOS
GOARCH

darwin
amd64

darwin
386

Done on a fork, the docker image has to contain Xcode and the license, therefore decided to exclude this. Perhaps can be added later.


Feature Request: Testing API Support

I didn't see an issue for this so I thought I'd add it here.
VSCode now has a native testing API, I've written an adapter for it for Powershell Pester here:
https://github.com/pester/vscode-adapter
Are there any plans for this to be incorporated into the C# extension directly for dotnet test, or will it strictly be the realm of add-on extensions?

@JustinGrote  I have a prove of concept of an adapter already,  I will open a draft PR this week.

Any update?

+1 desperately needed

This and styling extension (like Prettier for JS/TS or Rider CodeStyle) keeps me from fully using Vs Code for my daily .Net work.
Please consider on adding this feature. It will be nice to have it.

C# Dev Kit has a Test Explorer. Feel free to file an issue at https://github.com/microsoft/vscode-dotnettools/issues if you're having issues with it.

C# Dev Kit requires a visual studio license, AFAIK.

@bjornharrtell free for open source, commercial teams under 5 people, or when using dev box/codespaces
https://code.visualstudio.com/docs/csharp/cs-dev-kit-faq


In mud verify, don't give me an Etherscan URL when irrelevant

I verified a contract on Blockscout:
qbzzt@Oris-MacBook-Pro contracts % pnpm mud verify --worldAddress 0x40cc08060341a8449d0906fb5daf3cc1bf996b05 --rpc $ETH_RPC_URL --verifier blockscout --verifier-url https://eth-holesky.blockscout.com/api
(node:55480) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

 Verifying MUD contracts to RPC https://ethereum-holesky-rpc.publicnode.com

  mud:cli:deploy found CREATE2 deployer at 0x4e59b44847b379578588920ca78fbf26c0b4956c +0ms
running "forge verify-contract 0xB9A596A532AD582f80E6f88Aa4ec48c492749A11 TasksSystem --rpc-url https://ethereum-holesky-rpc.publicnode.com --verifier blockscout --verifier-url https://eth-holesky.blockscout.com/api"

Note: MUD is currently unable to verify store, world, and world-modules contracts with blockscout. We are planning to expand support in a future version.

Start verifying contract `0xB9A596A532AD582f80E6f88Aa4ec48c492749A11` deployed on holesky

Submitting verification for [src/systems/TasksSystem.sol:TasksSystem] 0xB9A596A532AD582f80E6f88Aa4ec48c492749A11.
Submitted contract for verification:
	Response: `OK`
	GUID: `b9a596a532ad582f80e6f88aa4ec48c492749a116654e1c4`
	URL: https://holesky.etherscan.io/address/0xb9a596a532ad582f80e6f88aa4ec48c492749a11

Why do I get the etherscan URL? The blockscout one, https://eth-holesky.blockscout.com/address/0xB9A596A532AD582f80E6f88Aa4ec48c492749A11 , in a lot more useful.

This is a Foundry issue