dos2unix on files; removed calls to azure (ASM) commands; fixed inval…

…id references to JSON data including virtual machine name and storage account name

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: pfriedland sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


(No need to review) Testing google_cloud_bigtable 2.25.2 with Beam 2.49.0

Do not merge.
Updating google_cloud_bigtable to 2.25.2 to test against Beam 2.49.0.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Java Tests / Java Unit Tests (ubuntu-latest) failure:
org.apache.beam.fn.harness.logging.BeamFnLoggingClientTest > testClosableWhenBlockingForOnReady FAILED
    java.lang.AssertionError at BeamFnLoggingClientTest.java:446

Java Tests / Java Unit Tests (windows-latest)
org.apache.beam.fn.harness.logging.BeamFnLoggingClientTest > testClosableWhenBlockingForOnReady FAILED
    java.lang.AssertionError at BeamFnLoggingClientTest.java:446

Java ("Run Java PreCommit")
18:43:29 Execution failed for task ':sdks:java:io:snowflake:compileJava'.
18:43:29 > Failed to store cache entry 2b3b0d96babb3c50b448068acc361fa2 for task ':sdks:java:io:snowflake:compileJava': Timeout waiting to lock Build cache (/home/jenkins/.gradle/caches/build-cache-1). It is currently in use by another Gradle instance.
...
18:43:29 Execution failed for task ':runners:java-fn-execution:test'.
18:43:29 > Process 'Gradle Test Executor 15' finished with non-zero exit value 143
18:43:29   This problem might be caused by incorrect test process configuration.

Display name in pull request
Command in pull request comments
Gradle goals
Success?

Java SDK Post Commit Tests
Run Java Postcommit
:sdks:java:io:google-cloud-platform:postCommit
?

Java_PVR_Flink_Batch
Run Java_PVR_Flink_Batch PreCommit
:runners:flink:1.13:job-server:validatesPortableRunnerBatch
?

Java Spark PortableValidatesRunner Batch Tests
Run Java Spark PortableValidatesRunner Batch
:runners:spark:2:job-server:validatesPortableRunnerBatch, :runners:spark:3:job-server:validatesPortableRunnerBatch
?

Dataflow V2 Java Post Commit Tests
Run PostCommit_Java_DataflowV2
:runners:google-cloud-dataflow-java:validatesRunnerV2
?

Google Cloud Dataflow Runner V2 Java ValidatesRunner Tests
Run Java Dataflow V2 ValidatesRunner Streaming
:runners:google-cloud-dataflow-java:validatesRunnerV2Streaming
?

Run Java_PVR_Flink_Batch PreCommit

Run Java Postcommit

Run Java Spark PortableValidatesRunner Batch

Run PostCommit_Java_DataflowV2

Run Java Dataflow V2 ValidatesRunner Streaming

Extracting the stack traces rather than just the boolean failed / not failed will make this easier to diagnose for a passerby like myself.

Extracting the stack traces rather than just the boolean failed / not failed will make this easier to diagnose for a passerby like myself.

I will certainly try to do that, but the console output only shows what I've already provided and I can't find how to extract more information from the results.

Run Java PreCommit

Run Java_GCP_IO_Direct PreCommit

Run Python_Integration PreCommit

Run SQL PreCommit

The Jenkins UI has browseable test results which will have the details. I like the Gradle Scan UI best, though. It may also be in the console log somewhere up higher, but that's more of a pain to dig through.

Run Java PreCommit

Run Python_Integration PreCommit

Closing since it looks like this testing process is no longer active. If I'm wrong, feel free to reopen


What 's the inference RTF on  CPU?

Just had a quick test run with the batch size of 1, the result RTF is about 0.0333 seconds per second of Mel-spectrogram.


Confusing Maybe Bug double use of can-stream #6

can-stream takes (streamInterface)
but can-stream-kefir for example already exports can-stream()
const streamInterface = require('can-stream-kefir') //-> module.exports = canStream(canStreamKefir);
const canStream = require('can-stream')
canStream(streamInterface)

so we double wrapp canStream? as the export of can-stream-kefir is already canStream(canStreamKefir) and we pass that into can-stream again?
same issue as: https://github.com/canjs/can-stream/issues/6
was not sure where we correct that but i think removing can-stream from this and removing kefir from can-stream is right

can be closed totall refactor needed


PCICClient Call hangs

I have this piece of code that is ran right after (successfully) connecting to the camera, which sometimes, after repeated forced disconnections (where camera waits for heartbeats to time out) hangs forever.
Reconnecting to the camera of course fixes it, but I would like to have a timeout or something similar for it. Is that possible?
    pcicclient->Call("a" + std::to_string(index));

where index = 1.

@Unmoon the issue you describe is caused by this loop:
	while (!has_result.load())
	{
		this->in_cv_.wait(lock);
}

From a quick glance over the code it looks like the return type of the inner call to Call is no checked
std::string
ifm3d::PCICClient::Impl::Call(const std::string& request)
{
	std::atomic_bool has_result(false);
	std::string result;

	Call(request, [&](const std::string& content)
	{
		// Copy content, notify and leave callback
		result = content;
		std::unique_lock<std::mutex> lock(this->in_mutex_);
		has_result.store(true);
		this->in_cv_.notify_all();
	});

	std::unique_lock<std::mutex> lock(this->in_mutex_);
	while (!has_result.load())
	{
		this->in_cv_.wait(lock);
	}
	lock.unlock();

	return result;
}

By adding a check for the return code before entering the endless loop. The described behaviour should not happen in an regular use additionally we should add a timeout like we do in the framegrabber's  WaitForFrame
  try
    {
      if (timeout_millis <= 0)
        {
          this->in_cv_.wait(lock);
        }
      else
        {
          if (this->in_cv_.wait_for(
                lock, std::chrono::milliseconds(timeout_millis)) ==
              std::cv_status::timeout)
            {
              VLOG(IFM3D_TRACE)
                << "Timeout waiting for PCIC call from camera";
              return "";
            }
        }
    }
  catch (const std::system_error& ex)
    {
      LOG(WARNING) << "PCICClient::Call: " << ex.what();
      return "";
}

In my opinion to handle this in an appropriate way I would suggest to add a new method:
bool
ifm3d::PCICClient::Impl::Call(const std::string& request,std::string& response,long timeout_millis )

But in the end @tpanzarella the maintainer has to decide what to do with this.

@graugans I am fine with your suggestion as you and your team are the authors/maintainers of the PCIC module. I'm happy to merge a suitable PR with associated tests.

Fix released in 0.15.1.


Add artifactshub metadata to get verified badge

Description
@prudhvigodithi this gives the official badge on opensearch charts
Issues Resolved

https://github.com/artifacthub/hub/issues/3533

Check List

[x] Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

[ ] Helm chart version bumped
[ ] Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks a lot @viceice, please remove the following user entry. As Idan is maintainer for the OpenSearch Operator repo.
  - name: Idan Levi
    email<EMAIL_ADDRESS>
Thank you


DisplayLink on D3100 is incredibly slow

Just tried the new release. I've a Dell D3100 dock connected to a Fedora system, compiled the kernel module and installed the DisplayLinkManager and companions. I've disabled selinux because of tons of complaints I didn't want to investigate for testing.
Now - for the first time, I can see something on the secondary monitor. BUT it is so incredibly slow, that it can't be used at all. I'm not sure how I can debug that. Any ideas?

Let's keep GitHub for evdi only. Could you please raise this at DisplayLink Forum? This post has link to a log gathering tool - but if you experience high CPU usage of DLM then it would be great if you could also use gdb to make a core file while the app is running (see this for more info and potentially also a fix?). Thanks.

Sigh. I really don't like this forum stuff. But if it's the correct place for it, I'll have no choice. Thanks.

The forum works as I know forums. No reaction for two days. Not even a download of the core file :-(

Don't worry, analysis of the dump already sits in the backlog of things to do this sprint. I wonder if you see this when things are slow?

No. The only vblank messages are these:
Mai 12 09:44:50 localhost kernel: [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
Mai 12 09:44:50 localhost kernel: [drm] Driver supports precise vblank timestamp query.


OSSM-3267: migrate cpu and ram flags to env variables

This PR is for migrating maistra prow jobs to Openshift CI jobs. It replaces the hard-coded CI cpu and RAM resources value with environment variables so that we can define and use more resources later.

/cherrypick maistra-2.3
/cherrypick maistra-2.2

/cherrypick maistra-2.2


'Exec format error' installing metrics server on k3s version v0.4.0 (7822549f) arm64 platform

Describe the bug
'Exec format error' installing metrics server on k3s version v0.4.0 (7822549f) arm64 platform
To Reproduce
curl -sfL https://get.k3s.io | INSTALL_K3S_EXEC="--disable-agent --kubelet-arg='address=<IP_ADDRESS>'" sh -

kubectl apply -f ./recipes/metrics-server/

Expected behavior
kubectl top node

Additional context
#252 #355

I tried to install metrics server on k3s using a raspberry pi, and I've got the same error.
the metric server pod always end in CrashLoopBackOff state.
I think the error is due to the following line:
https://github.com/rancher/k3s/blob/4af06882b67cd3f56285b6a5a1388b7190b93533/recipes/metrics-server/metrics-server-deployment.yaml#L39
specifying "amd64" in metrics server image
I've tried to replace that line with arm image:  image: k8s.gcr.io/metrics-server-arm:v0.3.1
and the metrics server pod is now running, and i was able to run kubectl top node successfully.

@meldafrawi If I executekubectl top node
I got Error from server (ServiceUnavailable): the server is currently unable to handle the request (get nodes.metrics.k8s.io)

@giminni
Can you please check the state of the mertics-server pod using:
kubectl get pods -n kube-system | grep -i metrics-server

Exact experience as @giminni.
I start the master with --
ExecStart=/usr/local/bin/k3s server --kubelet-arg='address=<IP_ADDRESS>'

and the nodes with --
ExecStart=/usr/local/bin/k3s agent

(I don't think the agents need the address=<IP_ADDRESS>, do they?
After applying the recipe, I have running (in -n kube-system) the a metrics-server deploy, rs, svc and pod.  Akk showing running and no errors.
Stumped.  5 node Rock64 cluster (1 manager, 4 nodes).  All running v1.14.1-k3s-4 and Linux rock0 4.4.132-1072-rockchip-ayufan-ga1d27dba5a2e #1 SMP Sat Jul 21 20:18:03 UTC 2018 aarch64 GNU/Linux.
Stumped.

Just an update for those that stumble down this path.  My metrics stuff is working now.  What did I change?  Nothing.  I simply wasn't being patient enough.  I just had to wait a loooong time (> 15 min).

@meldafrawi Sorry for answering late here the info
$ kubectl get pods -n kube-system | grep -i metrics-server
metrics-server-7cb5fc9958-4n6g4         1/1     Running     0          8d

Are you still running with --kubelet-arg='address=<IP_ADDRESS>'" @giminni?

@erikwilson Yes

How many nodes are being used @giminni?
Assuming it is multi-node, is the ip resolvable from the server node?

Starting with 0.6.0 the metrics server installation is reflected in the K3s documentation #557


Investigate TSLint Performance

No hard data, but running TSLint on a project's worth of TypeScript files has been feeling a little slow to me as of late. Would be worth looking into and benchmarking to see if there's a particular code chokepoint or rule that is slowing things down. Also would be neat to see how performance changes as the TypeScript language services change.

@JKillian anecdotally, I've noticed this as well.

I generated a quick flamegraph based off of running TSLint on its own src with its own configuration. The first point of note is that no-unused-variable and right after it, no-use-before-declare are taking up about the same runtime as all the other enabled rules combined. In this case, the recursive nature of walking the AST makes it a little hard to break down the flamegraph at a more granular level than this.
However, from recall and confirmed by a quick grep, these two rules are the only two rules which use special ts.LanguageServices APIs: they both use the getDocumentHighlights method to find other locations a variable is used.

And indeed, it does seem that most of the runtime is spent in getDocumentHighlights:

Here's a breakdown of one of those getDocumentHighlights calls:

So thinking about this it makes sense it's slow right? Typescript language services are not really designed with the use case, these rules check every variable is used. I haven't checked, but I'm pretty sure language services do not cache variable usage, so essentially each variable check is traversing the subset of the AST in which the variable can be in scope.
The solution is to not use language services in cases where all variables are inspected. Instead there needs to be a block scope aware Walker that accumulates variables.
Basically build up a cache, but because of 'use before declare' that will need to process the file and then match up unresolved variables at the end.
Or my premise is totally wrong :P

Anyhow, I was going to rewrite no unused variables in this way to see how complex it is... doing so should also fix the fact it doesn't detect unused imports in all situations... just wanted to see if anybody has more of an insight on this than me...
It might also be a candidate for shared data across rules that want to inspect variable usage. One step at a time though...

@lowkay yeah that sounds like a fair assessment and reasonable approach forward. Let us know how it works out!

So I have it matching variables in scope and ruling out some declarations based on simple usages (like in binary expressions or return statements). However, I need to work on extending this approach to class members as there are a bunch of edge cases that can't use simple name matching e.g. inside a class method:
someMethod(): void {
  const me = this;
  me.property  = "some value";
}

To catch this type of usage you have to know the type of me and match against that property.  I want to get the main ones explored and compare the performance before delving into all the nooks.

I also took a look at the language services implementation and while it is complicated it tries its best to figure out a subset of the AST to explore for usages. So my premise about the cost seems correct, it has to explore the AST for every declared variable, making it pretty terrible for this use case.

Any plans to integrate profiling into the build system so that regular contributors can see what effect they're having?

It wouldn't make sense to run in CircleCI, but a local version running as a one-off against a large code base would help determine the effect of a change

Regarding @andy-hanson's comment - I'd love to have some sort of --performance flag, either in the CLI or as a separate tool, that calls process.hrtime before and after each rule run to see how long each rule takes.
Thoughts?

@JoshuaKGoldberg You can use the builtin profiler in node. Just run node --inspect --debug-brk path/to/tslint-cli.js and use the profiler in chrome devtools. You can then sort by function name and find out how long MyRule.apply takes. You can also generate a flame graph there.
Note: the profiler does not stop recording automatically when tslint is done, so you have to click on stop yourself.

Yes, everybody on this thread knows how to do that, but for newer folks that don't know (or just for ease of convenience) it might be nice to have a utility for it.

Been looking for these comments on how to do it. It would be nice to include some section in the docs on how to measure performance.

@jmlopez-rod I can't recall exactly how I made those flamegraphs, but I believe it was using the general process described here: https://nodejs.org/en/blog/uncategorized/profiling-node-js/

closing in favor of the more actionable issue #2522


ETC-XBT Trade at Kraken

I have Question
September 10th, 2016 1:00 KST
Referring to https://github.com/carlos8f/zenbot/issues/9 Zenbot3 Had installed
and Run to RealTrading Mod
Now is 13:00 KST

You can change .format(d3.format(',.2fs')) to  .format(d3.format(',.8fs')) on line 88 in zenbot/plugins/server/public/main.js to fix the current close price for     var closeAnnotation = techan.plot.axisannotation()
and optionally doing a replace all ,.2fs to ,.8fs in your favorite text editor will change all plotted values to 8 decimals thereby fixing this issue. I'm not sure if it's best to do this for volumes as well as it may have an effect on performance so I will let @carlos8f decide how to commit those changes.
I'm not sure why there is no trade action on the 5min RSI, I think either it's a rs.min_double_wait/rs.min_reversal_wait issue or there wasn't enough look-back data to calculate RSI. It's also possible that zenbot missed the signal if it lasted less than 1 minute. Does anyone else have any input on this issue?


TestExecStartFails is broken on Windows

See this log for example:
FAIL: docker_cli_exec_test.go:616: DockerSuite.TestExecStartFails

docker_cli_exec_test.go:624:
    c.Assert(out, checker.Contains, "executable file not found")
... value string = ""
... substring string = "executable file not found"

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Ping @jhowardmsft: any hints?

@icecrime i saw this failure even for Janky and experimental today.
but after a rebase and rerun, I didnt see it again. FYI.

Yeah, I've seen this all week. Windows Jenkins was pretty much out from lunchtime last Friday until either Wednesday or yesterday. Since coming back, I've noticed this test pretty consistently failing. I was going to take a look at what might have changed, but haven't had a chance.

It's just broken in general, no?

It is broken in general.

I'm sure there's something deeper going on here to cause this to start failing in the past week. It was a reliable test before. I will dig in over the weekend (hopefully)

now am seeing the failure only in windows.
https://github.com/docker/docker/pull/16718

Related to (and almost duplicates) #16598

Failed in janky again : https://jenkins.dockerproject.org/job/Docker-PRs/17172/console

@MHBauer seems to work for me. Do you use remote daemon?

@LK4D4 yes I am using a remote daemon. Is this not supported with this test?

@MHBauer It is of course, just seems like it's easily reproduced with remote daemon. Seems like we closing something prematurely. @cpuguy83 could know more.

It's easily reproducible for me with a Linux daemon over a unix socket.
Within 5-10 times I get the failure, but only when not using -t.
I also see this problem in 1.8.2...

@cpuguy83 Probably stdcopy problem then?

FWIW I left this test running in a loop for a few hours here (from Windows to a remote Linux daemon) and didn't see any failures.

@LK4D4 Not sure.
I can confirm the daemon logs always shows the error it's just not always making it to the client... however I did notice that 100% of the time, when it doesn't make it to the client, the daemon logs are slightly different: https://github.com/docker/docker/issues/16598#issuecomment-145558865

@cpuguy83 Indeed stdcopy works between daemon and client when -t isn't specified :)

@LK4D4 Yep, you're right.

opencontainers/runc#316


set-output is deprecrated and will soon been removed

fixes: https://github.com/kiali/openshift-servicemesh-plugin/issues/193

CI workflow works... I see it pass on my fork repo.
Testing nightly and release now... if you see new images on my quay repo, you'll know those tests pass too:

https://quay.io/repository/jmazzitelli/ossmconsole?tab=tags
https://quay.io/repository/jmazzitelli/ossmconsole-operator?tab=tags
See my fork's actions: https://github.com/jmazzitelli/openshift-servicemesh-plugin/actions

Ready for review and approval - all my tests show that this works.


[Bug?]: solid-start-static build doesn't work with "(home).tsx" style filenames

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
If I run solid-start build while using the solid-start-static Vite adapter, the route at src/routes/index.tsx produces an output file at dist/public/index.html as expected. However, if I change the src/routes/index.tsx filename to src/routes/(home).tsx, then the dist/public/index.html file is no longer produced.
It seems like the solid-start-static Vite adapter doesn't properly handle the alternative index filename style (e.g. (home).tsx).
As a temporary workaround, I can fix the issue by adding the missing routes to the prerenderRoutes option of the Vite plugin:
export default defineConfig({
  plugins: [solid({ adapter: staticAdapter(), prerenderRoutes: ["/"] })],
})

However, it seems like this shouldn't be required.
Expected behavior 🤔
I expected the route at src/routes/(home).tsx to produce the dist/public/index.html file when building using the solid-start-static adapter.
Steps to reproduce 🕹
Steps:

npm init solid@latest

Where do you want to create the app? › my-app
Which template do you want to use? › bare
Server Side Rendering? › n
Use TypeScript? › y

cd my-app
npm add --save-dev solid-start-static
Edit vite.config.ts to be:

import solid from "solid-start/vite"
import staticAdapter from "solid-start-static"
import { defineConfig } from "vite"

export default defineConfig({
  plugins: [solid({ adapter: staticAdapter() })],
})

Rename src/routes/index.tsx to src/routes/(home).tsx
npm run build
Notice that dist/public/index.html does not exist.

Context 🔦
I am trying to build the site for static hosting.
Your environment 🌎
OS: macOS Ventura 13.2.1
solid-start: 0.3.3
solid-start-static: 0.3.3

Looks like the router does not generate the same path for a renamed index as it would for a index file. This causes the static adapter to behave this way. Opened a PR.


I would like only add my own editor without to redefine a default one.

Thanks for contributing to Wagtail! 🎉
Before submitting, please review the contributor guidelines https://docs.wagtail.io/en/latest/contributing/index.html and check the following:

Do the tests still pass? (https://docs.wagtail.io/en/latest/contributing/developing.html#testing)
Yes
Does the code comply with the style guide? (Run make lint from the Wagtail root)
yes
For Python changes: Have you added tests to cover the new/fixed behaviour?
yes

Merged in a4e05f453865fc1617e5880968503d658b4a2aaa (with documentation updated) - thanks @gassan!


fix: add "types" to "exports" in package.json to fix node16 typescript module resolution

This PR follows the same pattern set in #2454.
Resolves #2453
This PR fixes typescript errors when using "moduleResolution": "node16", because it is not using the types in the @open-wc/testing-helpers package.
Tested:

Still works with "moduleResolution": "node"
Works with "moduleResolution": "node16"

See https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#esm-nodejs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Fixed in https://github.com/open-wc/open-wc/pull/2507

Thanks for the update!


Allow gamepad and keyboard input.

When a gamepad is connected, the demo will not respond to keyboard input.
To allow for both, I commented out the else in Game.cpp (line 338).

Hmmm...  I should make gamepad+keyboard and mouse+keyboard work. What I'm trying to avoid is mouse+gamepad problems.


network: Refactor network handling to integrate hotplug

What this PR does / why we need it:
Embed most of the hotplug logic into the existing network setup flow.
This includes the logic of identifying if hotplug should be done and on which networks. Functions signatures have been adjusted to fit both the regular and hotplug setups.
The change handles both phase 1 and phase 2.
Future changes should strive to unify the logic, such that even a regular network setup can reconcile by hot-plugging the missing networks.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/test pull-kubevirt-e2e-k8s-1.24-sig-network
/test pull-kubevirt-e2e-k8s-1.25-sig-network
/test pull-kubevirt-e2e-k8s-1.26-sig-network
/test pull-kubevirt-unit-test
/test pull-kubevirt-build
/test pull-kubevirt-generate

/uncc stu-gott rmohr

/cc AlonaKaplan ormergi maiqueb

/retest-required

/retest-required

change: Answered review request to re-arrange the unit tests.

change: Removed redundant assert per review.

/lgtm
/approve


WIP: Distributed Scheduler CLI Changes

Dapr init, run, and uninstall with Scheduler.
Issue reference
https://github.com/dapr/dapr/issues/7605
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

Big thank you to @artursouza for the majority of the efforts for this change 🎉

Notes for the future to remember:
Planning to add to the cli these commands to a following release:
dapr job schedule --name=myjob --app-id=myapp --schedule "@hourly" --data '{"key":"value"}' --repeats 1
dapr job get --name=myjob --app-id=myapp
dapr job delete --name=myjob --app-id=myapp

I'm not seeing the scheduler initialized - I've created a custom installerbundle with the scheduler added to the dapr docker image. There are no errors/warnings logged
./dist/
./dist/dashboard_linux_amd64.tar.gz
./dist/injector_linux_amd64.tar.gz
./dist/scheduler_linux_amd64.tar.gz
./dist/daprd_linux_amd64.tar.gz
./dist/sentry_linux_amd64.tar.gz
./dist/placement_linux_amd64.tar.gz
./dist/operator_linux_amd64.tar.gz
./docker/
./docker/daprio-dapr-0.0.0-dev.tar.gz
./details.json
./dapr
ℹ  Removing Dapr from your machine...
⚠  WARNING: /home/runner/.dapr/bin does not exist
⚠  WARNING: dapr_placement container does not exist
⚠  WARNING: dapr_scheduler container does not exist
⚠  WARNING: dapr_redis container does not exist
⚠  WARNING: dapr_zipkin container does not exist
⚠  WARNING: /home/runner/.dapr does not exist
✅  Dapr has been removed successfully
⌛  Making the jump to hyperspace...
⚠  Local bundle installation using --from-dir flag is currently a preview feature and is subject to change. It is only available from CLI version 1.7 onwards.
ℹ  Installing runtime version 0.0.0-dev

Dapr runtime installed to /home/runner/.dapr/bin, you may run the following to add it to your path if you want to run daprd directly:
    export PATH=$PATH:/home/runner/.dapr/bin
Loaded image: daprio/dapr:0.0.0-dev
✅  Extracting binaries and setting up components...
✅  Extracted binaries and completed components set up.
ℹ  daprd binary has been installed to /home/runner/.dapr/bin.
ℹ  dapr_placement container is running.
ℹ  Use `docker ps` to check running containers.
✅  Success! Dapr is up and running. To get started, go here: https://aka.ms/dapr-getting-started```

@holopin-bot @cicoyle Thanks Cassie!


Add f.mapFailure(new CustomException); Add option.toFuture (without throwable)

@2rs2ts: test are flapping on Travis (#108).
The same commit (54f01f6) on my github space passed all tests.

@michalkowol Yeah, we're going to have to look at that later this week. I'll have one of my coworkers co-review this PR but it looks good to me. Thanks for the contribution!

@taylorleese I was honestly on the fence about this change, until I came to roughly the same conclusion as @2rs2ts . I don't see myself lifting Options into Future-land with this method all too often, but if it provides value, I'm fine with it.

I think it will be often used in for-comprehension. That was my use-casse.
Instead:
for {
  future <- Future(1)
  option <- Option(2).toFuture(new Exception("None"))
} yield {
  future + option
}

It will be good to have:
for {
  future <- Future(1)
  option <- Option(2).toFuture
} yield {
  future + option
}


Questions regarding kube-watch version support policy

Hello 👋
Firstly, thank you for taking up this project and helping maintain it. It's very much appreciated.
Secondly, I wanted to ask a few questions regarding kubewatch:

Is there a version support policy that kubewatch will be following moving forward? (For eg: Is the latest major.minor supported? Or is the latest major.minor.patch supported? Or is there an n and n-1 policy? etc).
Are there any compatibility concerns with any currently supported versions of kubernetes?
If someone is still using the (now deprecated) bitnami image for kubewatch, what will be your recommend method of upgrading to this one? Will it be to uninstall and then reinstall using the provided method of installation in README?

Your guidance and help will be very much appreciated!
Thank you 🙂

Hey, I replied on Slack but wanted to answer the questions here too:

At the moment, we only support the latest version (major.minor.patch)
Not that I’m aware of, but we don’t (yet) have automated testing for that so best to test yourself and be certain
Yes, that should work. If you encounter any issues you can ask here


After save (message it saved correctly) defaulting to pre-save entries

Noticed after placeholder update
Testing in status 6 (SD) and 13 (SR)

updates made to an existing field entries not being saved (reset to original text/toggle etc)

@calebissharp I reworded this to what I think is actually the issue.

@calebissharp Related to #359 that you mentioned earlier I think. I have confirmed that this is NOT tied exclusively to RUPs with missing required fields (although we should prevent this behaviour #378). There are a few fields that seem to update OK (ex. range name and plan dates) but most of plant community info is not saving. I wish I could be more specific but I keep thinking I've figured it out then I'll get a glitch in a save and what was saving before now seems not to.  Super irritating.

@LisaMoore1 This is due to the missing plant community update endpoint.

@calebissharp So can we do anything about this now or does it also need to wait until we get to versioning stuff where endpoints have been updated?

@LisaMoore1 Unfortunately, that's correct. Out of curiosity, what's the behaviour on the iPad when you try to update a saved plant community?

@calebissharp I make it look how I want, save, sync and when I get back to the web it looks the same as the updated iPad.

@calebissharp Size for this? I'll close once that is updated.

@LisaMoore1 Since the effort to add versioning (which is what resolved this issue) was captured in other issues, is it alright if we leave this without a size? This issue was never really worked on explicitly.

@calebissharp Works for me.


Different behavior between Chrome and PhantomJS (via Capybara)

Is it possible to drive an rspec/capybara test that uses angucomplete-alt with the headless browser, phantomjs?
My test a straightforward filtering of a results list.  With the chromedriver when I use capybara to fill in the input, the item I want pops up in a .angucomplete-rowclass with an .angucomplete-title that I can click on easily.  When I run with phantomjs no such item pops up and there appears to be nothing that my test can click on to select the item and move forward.
The code looks like this:
HTML:

      <angucomplete-alt
        focus-in='select_invoice(invoice)'
        id='invoice_item'
        input-class='form-control input-sm'
        local-data='invoice_items'
        minlength='1'
        pause='100'
        placeholder='Item'
        search-fields='description'
        selected-object='item'
        title-field='description'>
      </angucomplete-alt>

     <input class='form-control input-sm' ng-model='invoice.item_amount'>
     Add

The rspec/capybara code looks like this:
fill_in 'invoice_item_value', with: 'Labor Item'
wait_for_angular
save_and_open_page
find('.angucomplete-title').click

It seems like the two browsers are responding differently to the directive, but it also seems like there should be a single way to manipulate the interface when testing.

did you make any progress with this issue? i'm seeing the same thing


added web3

Please add web3 to the scirpt. Without it, not possible to connect optimism node to the interface.

With flag --ws.api=debug,eth,txpool,net,engine \

With flag --ws.api=debug,eth,txpool,net,engine,web3 \


Recreating components of earlier PR to add (T) densities.

Description
This PR will add CCSD(T) one- and two-electron densities to PyCC.
Todos

[X] Add an "inverted" disconnected triples driver to cctriples.py.
[X] Add a function to ccwfn.py called t3_density() that calculates all Lambda and density contributions at the same time as the (T) energy correction.
[ ] Add an interface to the ccwfn object to allow the user to control when t3_density() is called.
[ ] Modify cclambda.py to use the (T) contributions computed in t3_density() to the Lambda_1 and Lambda_2 equations.
[ ] Modify ccdensity.py to incorporate the (T) contributions computed in t3_density() to the one- and two-electron densities.
[ ] Add test cases to confirm that the CCSD(T) energy is computed correctly from the modified densities.

Status

[ ] Ready to go

Codecov Report

Merging #61 (3ca49eb) into main (63bdb13) will increase coverage by 0.53%.
The diff coverage is 97.87%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more


Replace all single-character strings with chars

Description
Was looking for something quick to do between tickets. Closes #871.
Regexes are your friend!

Checklist

[ ] Required by CI: Code is auto formatted using clang-format
[ ] Extend the tutorials / documentation reference
[ ] Document API changes relevant to the user in the MIGRATION.md notes
[ ] Create tests, which fail without this PR reference
[ ] Include a screenshot if changing a GUI
[ ] While waiting for someone to review your request, please help review another open pull request to support the maintainers

Need a slightly safer regex that uses a negative lookahead to exclude strings that contain \".

There appear to be some load-bearing single-character strings in MoveIt - I guess I am yet another developer brought low by this ticket.


Discrepancy between count and offset in /x/addresses endpoint

Description
There is a discrepancy between count and offset in /x/addresses endpoint.
How to reproduce

curl -s https://explorerapi.ava.network/x/addresses | jq .count
It returns 654754. So I expect there are 654754 addresses and I can retrieve each of them.

curl -s https://explorerapi.ava.network/x/addresses?offset=654753 | jq
I skip the first 654_753 addresses and I expect to retrieve the next addresses, but it returns:

{
  "count": 654753,
  "addresses": []
}

any news?


API Discovery

I'm working on implementing this concept as a PoC, but I would like to get some feedback!
When adding a new application that contains an API, to reduce the number of objects that a user has to author,
we can leverage annotations. A good place to annotate could be the Service used to drive traffic to the application
PODs.
You will recognize some of those from the "3scale discovery spec".
Annotations:

discovery.kuadrant.io/scheme: OPTIONAL Either HTTP or HTTPS specifies how the kuadrant gateway will connect to this API.
discovery.kuadrant.io/api-name: OPTIONAL If not set, the name of the API can be matched with the service name.
discovery.kuadrant.io/tag: OPTIONAL A special tag used to distinguish this deployment between several instances of the API.
discovery.kuadrant.io/oas-path:  Path where the OAS of the service is exposed. Kuadrant will contact the service and try to retrieve the OAS spec.
discovery.kuadrant.io/oas-configmap: Configmap that contains the OAS spec.
discovery.kuadrant.io/port: Only required if there are multiple ports in the service. Either the Name of the port or the Number.

Labels:

discovery.kuadrant.io/enabled:: REQUIRED true or false, marks the object to be discovered by kuadrant.

Complete annotated Service example:
apiVersion: v1
kind: Service
metadata:
  name: dogs-api
  annotations:
    discovery.kuadrant.io/scheme: "https"
    discovery.kuadrant.io/api-name: "dogs-api"
    discovery.kuadrant.io/tag: "production"
    discovery.kuadrant.io/oas-path: "/api/openapi/json"
  labels:
    discovery.kuadrant.io/enabled: "true"
spec:
  selector:
    app: dogs-api
  ports:
    - name: HTTP
      protocol: TCP
      port: 80
      targetPort: 9376

In case that the API is hosted outside the cluster, the developer can use the ExternalName service type, this way we keep only having to reconcile Services and not extra types. An example:
apiVersion: v1
kind: Service
metadata:
  name: dogs-api
  annotations:
    discovery.kuadrant.io/scheme: "https"
    discovery.kuadrant.io/api-name: "dogs-api"
    discovery.kuadrant.io/tag: "production"
    discovery.kuadrant.io/oas-path: "/api/openapi/json"
  labels:
    discovery.kuadrant.io/enabled: "true"
spec:
  type: ExternalName
  externalName: my-remote-api.example.com

By providing that label and those annotations, the kuadrant controller should be able to pull the OAS spec, and generate an internal object (API) that will be useful for the other kuadrant components, and also, to have a proper snapshot of the state without having to rely on external resources.
That API object will look similar to this, pending implementation:
apiVersion: networking.kuadrant.io/v1beta1
kind: API
metadata:
  name: dogs-api
spec:
  tags:
    - name: production
      APIDefinition:
        - OAS: |
             Inlined OAS spec.
      destination:
        serviceRef:
          name: dogs-api
          namespace: where-the-dogs-are
          port: 80
          schema: "https"

Problems/Questions:

We will get the OAS in the first reconcile run, but we need to define a way to find if the OAS has changed.. new PODs? New container image? Some basic polling? Only when the service gets touched/updated?

Is the externalName service type going to be enough? There are some edge cases that I'm not aware of, like DNS resolution issues or so?

Do we need to provide an alternative way to ship the OAS? A reference to a configmap/url?  -> Added the configmap version.

-- Updates (DD/MM/YY) ---
01/07/21: Added discovery.kuadrant.io/oas-configmap to the initial object. Already implemented in the actual codebase.

We will get the OAS in the first reconcile run, but we need to define a way to find if the OAS has changed.. new PODs? New container image? Some basic polling? Only when the service gets touched/updated?

Not sure if discovery.kuadrant.io/tag can be used for versioning. If so, then this will do it, no? Or maybe adding discovery.kuadrant.io/version otherwise.

We will get the OAS in the first reconcile run, but we need to define a way to find if the OAS has changed.. new PODs? New container image? Some basic polling? Only when the service gets touched/updated?

Not sure if discovery.kuadrant.io/tag can be used for versioning. If so, then this will do it, no? Or maybe adding discovery.kuadrant.io/version otherwise.

The OAS can change, for example, by the deployment being modified with a new container image, or using myimage:latest and pushing a new image to the registry...  Usually, the service is untouched between deployments, but perhaps we can be opinionated there.

The OAS can change, for example, by the deployment being modified with a new container image, or using myimage:latest and pushing a new image to the registry... Usually, the service is untouched between deployments, but perhaps we can be opinionated there.

I was thinking that, the first reconciliation will happen when the Service is first created or first annotated. IMO, it kind of makes sense that reconciling again depends on the Service object being as you said, "touched" by the owner of the resource. My suggestion before was more in the sense of how to touch it, i.e., by updating the annotation.

I miss from the service annotations the port of the oas:
discovery.kuadrant.io/oas-port

I miss from the service annotations the port of the oas:
discovery.kuadrant.io/oas-port

@eguzki I guess that can be a new "feature", the OAS spec living in a different port than the one used to serve the actual API traffic.

Ok, folks, we need to make a decision here.
Let's agree to go with reconciling the OAS on each service change?
later we can keep investigating the proper way: pulling each X seconds, watching for container/pod changes, etc...

Currently there is a way for the user to change the OAS and the kuadrant controller will reconcile the changes.
Let's say the user has deployed the following service:
apiVersion: v1
kind: Service
metadata:
  name: dogs-api
  annotations:
    discovery.kuadrant.io/scheme: "https"
    discovery.kuadrant.io/api-name: "dogs-api"
    discovery.kuadrant.io/tag: "production"
    discovery.kuadrant.io/oas-configmap: "cats-oas-v1"
  labels:
    discovery.kuadrant.io/enabled: "true"
spec:
  type: ExternalName
  externalName: my-remote-api.example.com

The user wants to update the OAS. The user can create a new configmap called cats-oas-v2 with the new OAS content and update the Service:
apiVersion: v1
kind: Service
metadata:
  name: dogs-api
  annotations:
    discovery.kuadrant.io/scheme: "https"
    discovery.kuadrant.io/api-name: "dogs-api"
    discovery.kuadrant.io/tag: "production"
    discovery.kuadrant.io/oas-configmap: "cats-oas-v2" <- **NOTE** the change in the config map name
  labels:
    discovery.kuadrant.io/enabled: "true"
spec:
  type: ExternalName
  externalName: my-remote-api.example.com

Then, the kuadrant controller will reconcile the underlying API resource and then reconcile ingress provider configuration accordingly.
Still not implemented:

When the OAS is exposed in the API in a path
Watch the OAS ConfigMap for external changes

Does not apply anymore


optimize wait store up log

When the store is not started, the program has no output and is blocked in WaitStoreUp, and the problem cannot be detected in time.

log before sleep is better

Codecov Report

Merging #261 (2893357) into main (f01aed9) will increase coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   97.09%   97.20%   +0.11%
==========================================
  Files          48       48
  Lines        2687     2688       +1
==========================================
+ Hits         2609     2613       +4
+ Misses         47       46       -1
+ Partials       31       29       -2

Impacted Files
Coverage Δ

dtmsvr/storage/registry/registry.go
80.00% <0.00%> (-5.72%)
:arrow_down:

dtmsvr/trans_type_saga.go
98.60% <0.00%> (+2.79%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f01aed9...2893357. Read the comment docs.

log before sleep is better

modified


Tagging Support

This PR defines a mechanism for handling tagged series in graphite, and is designed to be used in conjunction with PR 674 in carbon.
It defines a format for tagged series in carbon, which is <metric>;<tag1>=<value1>;<tag2>=<value2>
Each logical metric in the system is uniquely identified by the combination of its metric name and set of tags.  It does not attempt to store metadata about a metric that might change over time, if a tag is changed that creates a new series in the same way as changing a node in a regular series.  Internally the  portion of the series is stored in a name tag, making it available to the tag-related processing functions described below.
This format was chosen to remain compatible with existing carbon-based tooling as much as possible, while maintaining a clear format for defining tags and avoiding any issues with tag names or values containing ., which can be a problem for implementations that embed tag/value pairs as nodes within the dotted series name.
The foundation of this system is the tag database (TagDB), which is a pluggable system based roughly on the same concept as pluggable finders.  The TagDB is responsible for maintaining a list of series and their associated tags, and providing an interface for graphite-web to be able to upsert and delete series, as well as to query for series based on tag criteria.
The initial implementations of the TagDB are:

LocalDatabaseTagDB, which stores tag information in tables in the graphite-web database. This is fine for small deployments but will likely run out of steam pretty quickly.
RedisTagDB, which stores tag information in a redis database using the redis set type.  This obviously requires a redis server, but should scale out quite well.

Entering a series into the system is done by HTTP POST to a new /tags/tagSeries url, passing the series as path in the POST body.  The path is then parsed (using the same TaggedSeries class as in carbon), and added to the tag database.
Additional HTTP endpoints are:

/tags/delSeries accepts an HTTP POST to remove a specified path from the TagDB
/tags returns a list of tags in the TagDB
/tags/<tag> returns details of a particular tag, including the list of known values for that tag

Retrieval of data is done using the new seriesByTag function, which is based on the prometheus "vector selector" syntax, and accepts any number of criteria of the form <tag>=<value>, <tag>!=<value>, <tag>=~<value> (regex match), or <tag>!=~<value>.  This function looks up the series in the TagDB that match the specified criteria and returns a standard seriesList that can be passed into any other graphite function.  The series matching logic duplicates that of Prometheus, particularly when using criteria that match and empty value.
This function operates by querying the TagDB to get a list of series that match the specified criteria, then passing the resulting series through the same find/fetch pipeline as any other series.  There is also support in the remote prefetch code to perform the TagDB lookup and include the returned series in the prefetch requests to the cluster hosts.
One thing to note is that by virtue of the TagDB solely handling the lookup of tags to series it can handle situations where a series is removed on disk but still exists in the tag index, because it simply won't be returned from the find.  Clustered setups will use a single TagDB and each member of the cluster will return the series for which it has data.
Two additional functions are provided for working with tagged series; groupByTags and aliasByTags.  They closely follow the behavior of groupByNodes and aliasByNodes but work on tags rather than nodes.  In addition, all existing functions that create or modify series are updated to add a tag describing the action taken, so that they can be available for group/alias purposes.
Finally, the json output format has been extended to include a tags element for each series so that front-end tools can work with the tags.

Codecov Report

Merging #2002 into master will decrease coverage by 0.4%.
The diff coverage is 66.98%.

@@            Coverage Diff             @@
##           master    #2002      +/-   ##
==========================================
- Coverage   69.45%   69.04%   -0.41%
==========================================
  Files          71       78       +7
  Lines        6953     7404     +451
  Branches     1357     1431      +74
==========================================
+ Hits         4829     5112     +283
- Misses       1882     2025     +143
- Partials      242      267      +25

Impacted Files
Coverage Δ

webapp/graphite/app_settings.py
100% <ø> (ø)
:arrow_up:

webapp/graphite/urls.py
90.9% <ø> (ø)
:arrow_up:

webapp/graphite/tags/urls.py
100% <100%> (ø)

webapp/graphite/settings.py
75.84% <100%> (+0.55%)
:arrow_up:

webapp/graphite/tags/migrations/0001_initial.py
100% <100%> (ø)

webapp/graphite/render/grammar.py
82.69% <100%> (ø)
:arrow_up:

webapp/graphite/finders/standard.py
65.62% <16.66%> (-3.27%)
:arrow_down:

webapp/graphite/tags/views.py
28% <28%> (ø)

webapp/graphite/finders/ceres.py
84.84% <28.57%> (-15.16%)
:arrow_down:

webapp/graphite/render/utils.py
75% <42.85%> (-18.34%)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a54167c...3455d4d. Read the comment docs.

Cool, I'll review that early next week and think about how this can integrate with BigGraphite

High level comment: this should be abstracted in the existing finder/reader API (even if there is a new API) to make sure others can re-implement that using other backends.

@iksaif not sure I follow, there is already support for pluggable TagDB backends, and the mapping of tagged series names to actual files is handled by the finders.  What else would you want to customize?

What I mean is: why do we need a separate TAGDB while this could be just be done inside the finders (adding a tag argument or something like that).

Because there isn't a 1:1 relationship between TagDB and a specific finder, the TagDB operates one level up the stack.

@iksaif did you have a chance to take a look at this yet?

Hey,
I think I commented on both requests. I'm currently in the Himalayas for
the next 10 days but I'll double check when I'm back.
Sorry if I forgot to submit the form
Le 9 août 2017 6:01 AM, "Dan Cech"<EMAIL_ADDRESS>a écrit :

@iksaif https://github.com/iksaif did you have a chance to take a look
at this yet?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/graphite-project/graphite-web/pull/2002#issuecomment-321118860,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_DAz87ignm4isjGcDkbEUIIEC8JD3Vks5sWP3xgaJpZM4OehUP
.

Neat!
As the underlying scheme is compatible with Prometheus format you might be interested in https://github.com/RichiH/OpenMetrics which will spin out the format into a distinct project.

@iksaif hope you had/are having a great trip, would love to get your feedback when you're back.
@RichiH interesting stuff! One of the goals of the format I came up with was to retain as much compatibility as possible with existing carbon-based systems like relays, etc by sticking as much as possible to the existing set of allowed characters for carbon (the only change being allowing =), while supporting the OpenMetrics format would require using {, } and " (in addition to =) which are all currently considered special characters in graphite.

@DanCech @RichiH My guess would be that the ingestion would be responsible for receiving open metrics. Its just a communication protocol, not for queries and storage. Unless I misunderstand something :)

OpenMetrics is a wire format to exchange metrics, correct.

@iksaif I think I've hit most everything here also.  For the moment I'm punting on creation of a shared graphite-common lib, but we can do that at any point in the future.
@deniszh could use your feedback here also

Ok, @iksaif @deniszh @obfuscurity @cbowman0 I think everything brought up so far has been addressed.  Can I get a show of hands in favor of merging this beast?

Thanks for your work. Others: please review :)

@deniszh yes, that's been on my todo list for a while, I'll go ahead and get something put together.

I'm going to merge this, then work on the documentation in a new branch


add scheduler policy doc

What type of PR is this?
/kind documentation

What this PR does / why we need it:
add scheduler policy doc
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

@wawa0210 @CoderTH @archlitchi
PTAL

/lgtm

/approve


[Update] Updating agentTokenCreate mutation to use new tokenValue.

Context
With a recent security update from Buildkite, the token field in agentTokenEdge is deprecated but is now changed to tokenValue to retrieve the token when creating one through agentTokenCreate mutation.
This PR

Updates the buildkite-agent v3 documentation to use updated GraphQL API when creating agent token

Thanks for catching this and fixing it, @CheeseStick! I'll get someone from Buildkite to provide a technical review, then I'll run the linting and merge for you. 😊


App terminates immediately on iOS emulator

Steps to Reproduce
I recently ran flutter upgrade, and my Flutter app runs as expected on an android tablet, but terminates early on the iOS emulator. If I put breakpoints at the beginning of my code, they are never reached-- it appears none of the code is being executed.
Flutter Doctor
[✓] Flutter (on Mac OS, channel alpha)
• Flutter at /Users/emshack/vanadium/flutter
• Framework revision 9c0c0225a6 (2 weeks ago), engine revision bb9865538b
[✓] Android toolchain - develop for Android devices (Android SDK 23.0.2)
• Android SDK at /Users/emshack/Library/Android/sdk
• Platform android-23, build-tools 23.0.2
• Java(TM) SE Runtime Environment (build 1.8.0_60-b27)
[✓] iOS toolchain - develop for iOS devices (Xcode 7.3.1)
• XCode at /Applications/Xcode.app/Contents/Developer
• Xcode 7.3.1, Build version 7D1014
x ideviceinstaller not available; this is used to discover connected iOS devices.
Install via 'brew install ideviceinstaller'.
x ios-deploy not available; this is used to deploy to connected iOS devices.
Install via 'brew install ios-deploy'.
[✓] Atom - a lightweight development environment for Flutter
• flutter plugin version 0.2.3
• dartlang plugin version 0.6.31
Logs and Crash Reports
Running lib/main.dart on iPhone 6 Plus...
Xcode project created in /Users/emshack/vanadium/experimental/users/emshack/EmGen/ios/.
CoreSimulatorBridge: Requesting installation of file:///Users/emshack/vanadium/experimental/users/emshack/EmGen/ios/.generated/build/Release-iphonesimulator/Runner.app/ with options: {
CFBundleIdentifier = "com.yourcompany.testApp";
PackageType = Developer;
SimulatorRootPath = "/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk";
SimulatorUserPath = "/Users/emshack/Library/Developer/CoreSimulator/Devices/7AF4AC42-54BC-4134-8069-D5B4EE60297E/data";
}
syslogd: ASL Sender Statistics
installd: 0x700000094000 -[MIClientConnection _doBackgroundInstallationForPath:withOptions:completion:]: Install of "/Users/emshack/vanadium/experimental/users/emshack/EmGen/ios/.generated/build/Release-iphonesimulator/Runner.app" type Developer (LSInstallType = (null)) requested by CoreSimulatorBridge (pid 2385)
installd: 0x700000094000 -[MIInstaller _extractPackageWithError:]: Did not construct delta; doing full copy for installation.
installd: 0x700000094000 -[MIInstaller performInstallationWithError:]: Installing
installd: 0x700000094000 -[MIContainer makeContainerLiveReplacingContainer:reason:withError:]: Made container live for com.yourcompany.testApp at /Users/emshack/Library/Developer/CoreSimulator/Devices/7AF4AC42-54BC-4134-8069-D5B4EE60297E/data/Containers/Data/Application/07A5DA0B-1B01-49A8-91AC-A542DEADE31C
installd: 0x700000094000 -[MIContainer makeContainerLiveReplacingContainer:reason:withError:]: Made container live for com.yourcompany.testApp at /Users/emshack/Library/Developer/CoreSimulator/Devices/7AF4AC42-54BC-4134-8069-D5B4EE60297E/data/Containers/Bundle/Application/21FEE06A-ADE1-4FD5-9A48-E23271E5092D
installd: 0x700000094000 -[MIInstaller performInstallationWithError:]: Install Successful; Staging: 0.09s; Waiting: 0.00s; Preflight/Patch: 0.00s, Verifying: 0.00s; Overall: 0.12s
SpringBoard: Installed apps did change.
Added: {(
"com.yourcompany.testApp"
)}
Removed: {(
)}
Modified: {(
)}
SpringBoard: throwing out icon because it isn't visible in the model : node=<SBApplicationIcon: 0x7fce08e90c60; nodeID: "com.apple.camera"> com.apple.camera
containermanagerd: 0x700000117000 systemGroupContainerPath: com.apple.containermanagerd.internal is not entitled for system group identifier: systemgroup.com.apple.lsd
lsd: LaunchServices:(called by PID 2385) Identifiers file does not exist, creating file.
containermanagerd: 0x700000117000 systemGroupContainerPath: com.apple.containermanagerd.internal is not entitled for system group identifier: systemgroup.com.apple.lsd
CoreSimulatorBridge: Requesting launch of com.yourcompany.testApp with options: {
arguments =     (
"--flx=/Users/emshack/vanadium/experimental/users/emshack/EmGen/build/app.flx",
"--dart-main=/Users/emshack/vanadium/experimental/users/emshack/EmGen/lib/main.dart",
"--packages=/Users/emshack/vanadium/experimental/users/emshack/EmGen/.packages",
"--enable-checked-mode",
"--start-paused",
"--observatory-port=8106"
);
environment =     {
};
}
backboardd: SecTaskLoadEntitlements failed error=22 cs_flags=200, task->pid_self=-1
backboardd: SecTaskCopyDebugDescription: Runner[3581]
backboardd: SecTaskLoadEntitlements failed error=22 cs_flags=200, task->pid_self=-1
backboardd: SecTaskCopyDebugDescription: Runner[3581]
backboardd: SecTaskLoadEntitlements failed error=22 cs_flags=200, task->pid_self=-1
backboardd: SecTaskCopyDebugDescription: Runner[3581]
backboardd: SecTaskLoadEntitlements failed error=22 cs_flags=200, task->pid_self=-1
backboardd: SecTaskCopyDebugDescription: Runner[3581]
backboardd: SecTaskLoadEntitlements failed error=22 cs_flags=200, task->pid_self=-1
backboardd: SecTaskCopyDebugDescription: Runner[3581]
assertion failed: 15F34 13E230: libxpc.dylib + 57882 [66C28065-C9DB-3C8E-926F-5A40210A6D1B]: 0x7d
SpringBoard: [MPUSystemMediaControls] Updating supported commands for now playing application.
[INFO:FlutterDynamicServiceLoader.mm(107)] 0 custom service definitions registered
Observatory listening on http://<IP_ADDRESS>:8106
Application running.
Application finished.

I'm seeing this issue locally and am investigating.  For me it happens intermittently.  If I run the app again, sometimes it works.

For me it seems to happen every time I run the app.

I think i have a fix for this.  I'm going to vet it a bit more before marking this bug closed.

Fixed.


cQube Dashboard - logout button is not working

Navigate to the cQube Dashboard screen and click on the logout button it is navigating to the home screen instead of the login page

its already fixed. pls pull the latest code and retest it.

@FaizanMohammed326 @htvenkatesh Re-tested the defect it is working as expected.


'Sequence contains more than one element' following simultaneous NuGet push

If a package with same ID is simultaneously pushed to the NuGet gallery server, and that package ID doesn't pre-exist, you can get duplicate PackageRegistration rows (and associated rows) for this package, even if a prerelease or different version is used on the package.  Later attempts to push new versions of this package will result in the following error & the only known solution is to manually cleanup the db entries.
System.InvalidOperationException: Failed to process request. 'Sequence contains more than one element'.
[16:30:34][MSBuild output] EXEC : The remote server returned an error : (500) Internal Server Error.. ---> System.Net.WebException: The remote server returned an error: (500) Internal Server Error. [C:\BuildAgent\work\ccb7ae74f291883\.build\Build.proj.teamcity]
[16:30:34][MSBuild output]      at System.Net.HttpWebRequest.GetResponse()
[16:30:34][MSBuild output]      at NuGet.RequestHelper.GetResponse(Func`1 createRequest, Action`1 prepareRequest, IProxyCache proxyCache, ICredentialCache credentialCache, ICredentialProvider credentialProvider)
[16:30:34][MSBuild output]      at NuGet.HttpClient.GetResponse()
[16:30:34][MSBuild output]      at NuGet.PackageServer.EnsureSuccessfulResponse(HttpClient client, Nullable`1 expectedStatusCode)
[16:30:34][MSBuild output]      --- End of inner exception stack trace ---
[16:30:34][MSBuild output]      at NuGet.PackageServer.EnsureSuccessfulResponse(HttpClient client, Nullable`1 expectedStatusCode)
[16:30:34][MSBuild output]      at NuGet.PackageServer.PushPackageToServer(String apiKey, Func`1 packageStreamFactory, Int32 timeout)
[16:30:34][MSBuild output]      at NuGet.PackageServer.PushPackage(String apiKey, IPackage package, Int32 timeout)
[16:30:34][MSBuild output]      at NuGet.Commands.PushCommand.PushPackageCore(String source, String apiKey, PackageServer packageServer, String packageToPush, TimeSpan timeout)
[16:30:34][MSBuild output]      at NuGet.Commands.PushCommand.PushPackage(String packagePath, String source, String apiKey, TimeSpan timeout)
[16:30:34][MSBuild output]      at NuGet.Commands.PushCommand.ExecuteCommand()
[16:30:34][MSBuild output]      at NuGet.Commands.Command.Execute()
[16:30:34][MSBuild output]      at NuGet.Program.Main(String[] args)

If this repo's on NuGet.org this is quite poor behavior and should be fixed. Even for v3 feed in RTM milestone we still use the same publish path through the gallery.

Working on this in #2509


Automatic handling of NA threshold

Currently when a threshold could not be defined in the shazam step (naive samples) the pipeline breaks. Solution is to submit it with a manually defined threshold. This should be handled automatically.

will be solved when we merge samples from the same patient


Feature request: Allow value deserializer access to key

I have an application which needs to look at the key first before deserializing the rest of the message. Would you be opposed to a PR adding the key to SerializationContext?

you'd need to pass the bytes, not the deserialized key because the serialization context is also passed when deserializing the key and also, it's not a generic type, which it ideally would be. and if you're passing the key, probably also pass the value for completeness (though i expect that wouldn't be used).
if there's no alternative to satisfying an important use-case i'd probably be happy to, but i'm not convinced.

I've found a good workaround for my use case: I just use Consumer<byte[], byte[]> and then do the actual deserialization in my own code.


Allow arbitrary tag-types for use as containers

Please fix python 2.6 incompatible string formatting and '%d'.format() issues (and maybe some minor improvements like unicode literals). Other than that LGTM.

LGTM


Use a cache-backed client to reduce number of api requests

We currently use an api reader which results in an actual api request
whenwever we need to get an object. This change makes us use the
default cache-backed client again. There are now a couple of conflict
errors in the log, but as that results in a retry it is not a
correctness issue.
Ref https://issues.redhat.com/browse/HOSTEDCP-154

/retest

/retest

/test e2e-aws-metrics

/test e2e-aws-metrics

/test e2e-aws-metrics

/retest

lgtm pending rebase

/retest-required

/retest-required

/retest-required

@enxebre @csrwng this now passed tests, ptal if you have time

/lgtm


[build] error cv_state in namespace std does not name a type

In file included from ../src/util/util_fps_limiter.cpp:3
../src/util/thread.h:261:10

You are probably doing a mistake when building. I know I did recommend you latest dxvk version in another thread, and due to other comment there I just discovered that there are automatic builds available via github actions?!
So this one should be the from the current head of master:
https://github.com/doitsujin/dxvk/actions/runs/5467864893

I know I did recommend you latest dxvk version in another thread, and due to other comment there I just discovered that there are automatic builds available via github actions?!

So this should be the build from the current master branch:
https://github.com/doitsujin/dxvk/actions/runs/5467864893

Nice! Thank u again!

You are using the wrong mingw: https://github.com/doitsujin/dxvk#troubleshooting

You are using the wrong mingw: https://github.com/doitsujin/dxvk#troubleshooting

I am using mingW-w64 <IP_ADDRESS>, do you think it's because of the bcc-mingw-w64?

@FNsi Friendly ping. Did you figure out your issue?

@FNsi Friendly ping. Did you figure out your issue?

No clue, my SSD crashed, now I have to use windows for a while 😂

@FNsi Did you come back to Linux since and tried again? 👀

@FNsi Did you come back to Linux since and tried again? 👀

Sorry, I am using wsl nowadays...
But, I think it's the time to give it a try...again


fix memory problem on error handler (1.1.12 wmagent branch)

old wmagent branch of #8672

 Fix #8674 - fix memory problem on error handler


Readme - Building from source code

Second line should be

cd Ratatouille.lv2

Yep, thanks for the hint, fixed now.


update blur while scrolling LazyColumn below blur

I wanna create a screen with your really cool library but I got a issue with blur I wanna create a blue anything below my textField and I do it but while I scroll my list of items the blur does not update by the scroll and the scroll displays the outdated blur info
https://github.com/skydoves/Cloudy/assets/112812079/2966f526-5c59-4cf4-ac85-9d6798623285
and I wanna create some effect like on telegram with blur:
https://github.com/skydoves/Cloudy/assets/112812079/6ae0905f-5dbc-4eae-8e12-438995497213
my code:
var text by remember { mutableStateOf("") }
val rememberLazyColumnState = rememberLazyListState()
Box {
    LazyColumn(
        state = rememberLazyColumnState
    ) {
        items(100) { index ->
            Text(text = "Itemasd;klfja;kdfjka;lsjdfl;ajsdflasdlkf;alskdjf: $index")
        }
    }

    Box (
        modifier = Modifier.height(80.dp)
    ) {
        Cloudy(
            radius = 20,
            key2 = rememberLazyColumnState.firstVisibleItemIndex
        ) {
            Box(modifier = Modifier
                .fillMaxWidth()
                .fillMaxHeight())
        }
        OutlinedTextField(
            value = text,
            onValueChange = { text = it },
            placeholder = { Text("Search...") },
            modifier = Modifier
                .fillMaxWidth()
                .padding(10.dp)
        )
    }
}

Hey @MaximCemencov, for now, Cloudy doesn't support the window blurring feature. It's one of my plans for the next release.


Update http4s-blaze-server, http4s-circe, ... to 0.22.0

Updates

org.http4s:http4s-blaze-server
org.http4s:http4s-circe
org.http4s:http4s-dsl

from 0.21.25 to 0.22.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Applied Migrations

github:http4s/http4s/v0_22?sha=v0.22.0

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

labels: library-update, semver-minor, scalafix-migrations

Superseded by #158


refactor: auth refreshToken dtos refactor

auth refreshToken DTOs refactor

Just one thought @yashmurty @sivanpayyadakath, to keep the output DTO naming convention - is it be better to use AuthTokenOutput instead of AuthToken?

@asad-mlbd
Thank you for the review . Yes, AuthTokenOutput is more appropriate . 👍


BUG-Inconsistent frontend chart refresh when periodically updating with invoke_long_callback status function on linux

Description
When using invoke_long_callback, we can provide a period argument to call the status function every period ms. When using period=500 and a status function that updates the data of a chart, we would expect the chart to refresh every 500ms.
On Linux, the chart refresh seems to be inconsistent/buffered. The status function is correctly being called every 500ms, but the chart does not visually update in the browser. Every 3-5 seconds, the updates come in one go. On Windows, it works fine. Using Gui.run(async_mode="threading") also works fine.
How to reproduce
The following is a line chart which should alternate between 0 and 1 every 500ms:
from taipy.gui import Gui, invoke_long_callback
import time

def generate_data():
    i = 0
    while True:
        yield (i, i%2)
        i += 1

gen = generate_data()
data = [next(gen) for _ in range(10)]

def idle():
    while True:
        time.sleep(1)

# chart alternates between 0 and 1 every 500ms
def update_real_time_chart(state):
    state.data = state.data[1:] + [next(gen)]

def on_init(state):
    invoke_long_callback(state, idle, [], update_real_time_chart, [], 1000)

Gui("<|{data}|chart|>").run()#async_mode="threading")

Expected behavior
Chart should update every 500ms.
Screenshots
When available and relevant, screenshots to better highlight the problem.
Runtime environment
Please specify relevant indications.

Taipy 3.1
WSL Ubuntu (reproducible on Docker Python Debian image)
Chrome/Firefox

You might need to change the ping_interval from socketio. I have included the change for you to see. Let me know if it helps.
import time

from taipy.gui import Gui, invoke_long_callback

def generate_data():
    i = 0
    while True:
        yield (i, i % 2)
        i += 1

gen = generate_data()
data = [next(gen) for _ in range(10)]

def idle():
    while True:
        time.sleep(0.5)

# chart alternates between 0 and 1 every 500ms
def update_real_time_chart(state):
    state.data = state.data[1:] + [next(gen)]

def on_init(state):
    invoke_long_callback(state, idle, [], update_real_time_chart, [], 500)

Gui("<|{data}|chart|>").run(server_config={"socketio": {"ping_interval": 1}})

@dinhlongviolin1 Yes, that works for me. Is this something that can be "fixed"?  Changing the ping_interval in this case allows the frontend to receive messages more frequently.
I think we can put this in the doc so people know how to edit this if needed. I will create another doc issue.


Video bitrate question

I know that the script will convert a file and bring its bitrate down to the desired on if its higher but is there a way or could it be added that it brings the bitrate up?
The main reason for asking is I am converting a handfull of files that are h265 to h264 for compatibility reasons but due to the way h265 works it has far better quality while using much lower bitrates, noy if I convert it currently it will keep the bitrate from the h265 but loose so much quality its insane, but if I take the same file and run it through handbrake and bring it BR up to my default for my settings I loose no quality at all.

Just pushed an update the should allow you to get the behavior you want. The video-bitrate option can now be used to assign your desired video-bitrate when re-encoding

Awesome, do I need to change anything in the autoprocess file or just download update and away we go?

You'll need to set the video-bitrate option to use the new feature.
Essentially the behavior will works as follows:
same codec and video-bitrate is higher than your source video's bitrate > copy/remux, no transcoding
same codec and video-bitrate is lower than your source video's bitrate > transcode to lower bitrate, same codec
different codec and video-bitrate is set > will transcode using your specified bitrate to new codec
different codec and video-bitrate not set > will transcode attempting to match the source bitrate despite different codec


test_input.json is required

When I try to run the worker, I'm getting the following error:
WARN   | test_input.json not found, exiting.
which prevents me from using the runpod worker.

Hi @wwydmanski, could you please share more details? Does this still persist?

This is normal when you run it locally, you can start the local API as follows:
python3 -u handler.py --rp_serve_api --rp_api_port 8000 --rp_api_host <IP_ADDRESS>

Otherwise it defaults to looking for test_input.json instead.

For future readers, the non-vllm workers can be tested with the --test-input '{"input": {"message": "blah"}}' flag, but for vllm you need to put that input object in a test_input.json file in your current working directory.
(This isn't actually sufficient because the worker just outputs async_generator object handler at ... stuff, but it'll help you deal with this specific error message.)


Extension host terminated unexpectedly

Issue Type: Bug

Open VSCode and after 2-5 seconds, This Error Message appears:
"Extension host terminated unexpectedly".
Even when try to run this without any extension or reinstall VSCode.

My guess is that some extension is misbehaving, and by enabling/  disabling them you can find out which one and file a bug against that extension repository

I Checked again with provided information and Wakatime is misbehaving producing this error.


wire-desktop: bump versions

Motivation for this change
This bumps wire-desktop to the latest releases available (they have different versions per architecture).
Built and run the linux version.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

actually, that's a duplicate of #82664, which I missed :laughing:


updates order to sort_order, fixes potential nil error in acquired_by

Thank you Luke Ivers!

Thank you Luke Ivers! I has been fixed acquired_by bug.


File based QdrantClient does does not support multithreading

Hi all, I am the maintainer of the Cheshire Cat AI (we have Qdrant as default DB).
We currently have this setup:

using qdrant_client==1.6.2
for tests, in :memory: client
for dev setup, we would like to use file-based Qdrant
for deploy, the Qdrant container

The issue is about file-based Qdrant, QdrantClient(path="/something/folder").
Since conversations with the cat from different users are handled in different threads, we found no problem in reading the file based DB, but an error occurs when writing:
 self.client.upsert(
File "/usr/local/lib/python3.10/site-packages/qdrant_client/qdrant_client.py", line 796, in upsert
  return self._client.upsert(
File "/usr/local/lib/python3.10/site-packages/qdrant_client/local/qdrant_local.py", line 353, in upsert
  collection.upsert(points)
File "/usr/local/lib/python3.10/site-packages/qdrant_client/local/local_collection.py", line 810, in upsert
  self._upsert_point(point)
File "/usr/local/lib/python3.10/site-packages/qdrant_client/local/local_collection.py", line 805, in _upsert_point
  self.storage.persist(point)
File "/usr/local/lib/python3.10/site-packages/qdrant_client/local/persistence.py", line 96, in persist
  cursor = self.storage.cursor()
cheshire_cat_core  | sqlite3.ProgrammingError: SQLite objects created in a thread can only be used in that same thread. The object was created in thread id<PHONE_NUMBER>31296 and this is thread id<PHONE_NUMBER>00672.

What can we do?

Maybe check_same_thread=False when creating the connection?

Just saw there is an open PR about this

File based Qdrant is indeed does not support multithreading since it uses SQLite under the hood and SQLite is not threadsafe, it is not safe to write to SQLite from different threads.
I don't think that PR will be merged in its current state, however I think it is possible that we will provide a way to pass arguments to sqlite connection.

File based Qdrant is indeed does not support multithreading since it uses SQLite under the hood and SQLite is not threadsafe, it is not safe to write to SQLite from different threads.
I don't think that PR will be merged in its current state, however I think it is possible that we will provide a way to pass arguments to sqlite connection.

File based Qdrant is indeed just for testing/prototyping purpose, but useful to avoid using the whole container (it's one of the main reason we're using Qdrant XD).
Without threading it is not possible to use it in conjunction with any web server! Would be great to have this feat (safe or not)

On the docs, there is a page dedicated to this topic, as they wrote:

Use the SQLITE_THREADSAFE compile-time parameter to select the threading mode. If no SQLITE_THREADSAFE compile-time parameter is present, then serialized mode is used. This can be made explicit with -DSQLITE_THREADSAFE=1. With -DSQLITE_THREADSAFE=0 the threading mode is single-thread. With -DSQLITE_THREADSAFE=2 the threading mode is multi-thread.

So is thread-safe and they provide also a function (for C API) to check this flag, in python is possible with this query:
cx.execute("select * from pragma_compile_options where compile_options like 'THREADSAFE=%'").fetchall()

Sources:

Using SQLite In Multi-Threaded Applications
Test To See If The Library Is Threadsafe
Is sqlite3.threadsafety the same thing as sqlite3_threadsafe() from the C library?

#369 #376
should be fixed as of qdrant-client 1.6.9


Add a hint to the error message raised when with method is called w…

…ithout block
Related to #174

WDYT?

@asok thanks! That's a good idea. It happened to me so many times, not necessarily with WebMock.

@asok I just got this excellent error message, and came here to thank you! Very helpful. 💯

So nice to get a simple, direct thank you :)


Path intellisense for other files besides js/ts

I would like to allow VScode intellisence can detect and show more file types when write import syntax.
for now when working with custom file type ex .vue file, editor only show js / ts file, .vue file is hidden.
my suggest is we have new setting:
intellisence.suggest_file_types and allow input custom file type want to load.
Like this we can control better.

@mjbvz, when will this problem be fixed?

I created an extension that fixes this problem, please test who is also suffering from this problem.
Report bugs by creating issue in my GitHub repo.
https://marketplace.visualstudio.com/items?itemName=mishannn.vscode-file-suggest

Will this never be implemented?!

No update? It should be a base feature

It would be nice experience to suggest other types of files in the IntelliSense such as .css, .mdx, .png etc.

It would be cool to explore having it automatically suggest file types based on the discovery of declare module blocks inside .d.ts files.

When you install Next.js it includes module declarations for *.module.css, *.module.sass, *.module.scss and a bunch of different image types.

When you install MDX it includes module declarations for mdx, md etc.

You could also create your own module declarations for different file types.

In addition to @mishannn's extension, there's also this one: https://marketplace.visualstudio.com/items?itemName=thisismanta.third-eye


Measurement value of two-line angular dimension

The value returned by the DimensionAngular2Line.Measurement property is (converted to degrees), e.g., 114 instead of 95.
ACadSharp calculates this value instead using the value provided by AutoCAD, read from the DWG.
A two-line angular dimension is defiened by two intersecting straight lines given by four points and one more point that defines the radius of the arc and the location of the arc. It also defines which angle has to be taken. The value returned does not consider this, consquently returns 180 - measurement.
Why don't we use the value provided by AutoCAD?

Hi @mme1950,
For dxf the measurement is optional, so it may not be present when reading the file.
The measurement property should be a read-only dynamic value, if you change the points of the dimension the measurement should reflect the change, also it doesn't make any sense to be able to set the measurement value when the value is determinate by the dimension itself.
I'll check the case that you presented for DimensionAngular2Line and try to find a solution for this bug.


An error occurred during supervisied fine-tuning.

Traceback (most recent call last):
[rank2]:   File "/home/xxx/project/OpenRLHF/examples/scripts/../train_sft.py", line 180, in
[rank2]:     train(args)
[rank2]:   File "/home/xxx/project/OpenRLHF/examples/scripts/../train_sft.py", line 89, in train
[rank2]:     (model, optim, scheduler) = strategy.prepare((model, optim, scheduler))
[rank2]:   File "/home/xxx/.local/lib/python3.10/site-packages/openrlhf/utils/deepspeed.py", line 157, in prepare
[rank2]:     ret.append(self._ds_init_train_model(*arg))
[rank2]:   File "/home/xxx/.local/lib/python3.10/site-packages/openrlhf/utils/deepspeed.py", line 167, in _ds_init_train_model
[rank2]:     engine, optim, _, scheduler = deepspeed.initialize(
[rank2]:   File "/home/xxx/anaconda3/envs/openrlhf/lib/python3.10/site-packages/deepspeed/init.py", line 157, in initialize
[rank2]:     config_class = DeepSpeedConfig(config, mpu)
[rank2]:   File "/home/xxx/anaconda3/envs/openrlhf/lib/python3.10/site-packages/deepspeed/runtime/config.py", line 782, in init
[rank2]:     self._configure_train_batch_size()
[rank2]:   File "/home/xxx/anaconda3/envs/openrlhf/lib/python3.10/site-packages/deepspeed/runtime/config.py", line 961, in _configure_train_batch_size
[rank2]:     self._batch_assertion()
[rank2]:   File "/home/xxx/anaconda3/envs/openrlhf/lib/python3.10/site-packages/deepspeed/runtime/config.py", line 909, in _batch_assertion
[rank2]:     assert train_batch == micro_batch * grad_acc * self.world_size, (
[rank2]: AssertionError: Check batch related parameters. train_batch_size is not equal to micro_batch_per_gpu * gradient_acc_step * world_size 128 != 2 * 9 * 7

I used the conda to build environment...

We only test the codes within the docker container...


fix(chat): revoke access to folder if folder renamed (Issue #833)

Description:
Revoke access to folder if rename or delete
Issues:

Issue #833

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review


Replication, delete_mode not keep and key amnesia

Scenario
There are two clusters: ClusterA, ClusterB.  Both clusters are configured with the standard delete_mode (reaping on 3s timeout).
An object key (K1) belongs to a Preflist of {VnodeA1, VnodeA2, VnodeA3} on ClusterA, and {VnodeB1, VnodeB2, VnodeB3} on ClusterB.
An object is initiated with that key K1 on ClusterA (VnodeA1 say, acting as coordinator).  The creation is replicated.
The object is deleted on ClusterB (VnodeB1 say, acting as coordinator).  The deletion is replicated.
For some reason, on one cluster (ClusterA say) the reap does not occur on the timeout.
Replication Goes Wrong

There is now an object on ClusterA, a tombstone with a vector clock like [{VnodeA1, {1, TS1}}, {VnodeB1, {1, TS2}}], that does not exist on ClusterB.
nextgenrepl full-sync now runs with ClusterA as the src, and ClusterB as the snk.
The aae_exchange discovers that A > B for K1 as K1 not_found on B.  It puts a reference on the replication queue.
The fetch, which is run via riak_kv_get_fsm pulls across the tombstone object.  But as it prompts a read (via riak_kv_get_fsm), the read final action spots that this is a tombstone, and so triggers a maybe_delete, which causes the tombstone to be reaped from ClusterA.
The push of the tombstone to ClusterB, is performed as expected on VnodeB2 and VnodeB3.  However on VnodeB1 there is key amnesia - this vnode previously coordinated the write, but has no backend memory because of the reap.
Due to key amnesia, the object is written with an updated vector clock.
The riak_client:push function which has replicated the object prompts a GET of the object after the asis PUT.  This GET is intended to prompt any delete actions (e.g. it is expected to reap).   However, in this case it prompts a read-repair instead (there can only be one final action), because the tombstone's vclock differs at VnodeB1 from VnodeB2 and VnodeB3 due to the new actor epoch generated by key amnesia.
This means that the object has been reaped from ClusterA, but exists on ClusterB with a vector clock following read repair like [{VnodeA1, {1, TS1}}, {VnodeB1, {1, TS2}}, {VnodeB1.1, {1, TS3}}].
Now if full-sync runs from B to A - the same thing occurs in reverse.  The net effect is the tombstone is reaped from ClusterB, but re-added to ClusterA with an expanded vector clock due to the new actor epoch (triggered by the object update history from VnodeA1) e.g.: [{VnodeA1, {1, TS1}}, {VnodeB1, {1, TS2}}, {VnodeB1.1, {1, TS3}}, {VnodeA1.1, {1, TS4}}]

... this object can then loop around indefinitely, forever increasing the size of the vector clock.

Initial thoughts are, that the best solution is to change the riak_kv_get_fsm so as not to trigger delete on fetch (in the riak_kv_get_fsm).  This represents a change from riak_repl (as riak_repl was push rather than pull-based, and so did not use fetch), and hence why we have not seen this before.
This should prevent the cycle.
There is perhaps also a question about whether it is right to consider new_actor_epoch on tombstones when delete_mode is not keep.  Should key amnesia be the expectation here with replicated tombstones due to automatic reaping?
I think the safest thing is to leave key amnesia as it was, as it appears to be only this replication scenario that can trigger this cycle.

changing the fetch behaviour may cause other problems.  In particular, if we have the same situation - but this time there have bene no previous coordinate PuTs on either cluster (it originates from ClusterC).
There could now be a rotation, whereby the tombstone is on A.  Full-sync prompts A -> B.  There is no amnesia on  B, and so the GET post PUSH on B will now prompt the reap.  However, the Fetch from A hasn't prompted a reap now ... so we are just rotating tombstones again.

There is a demonstration of the original problem in this test

The kv679 behaviour, or handling key amnesia in all delete_modes, is implicitly tested (in that the default non-keep mode is used in all the tests).  So I don't think it is potentially unsafe to change this behaviour.
The alternative is to end the rule of a single final action only in riak_kv_get_fsm.  If a repair is prompted, and the repaired object is a tombstone, it should also prompt a delete (which is really a reap request).

https://github.com/basho/riak_kv/pull/1814


can not receive sia coin from some trading platform

I send 1sc to my wallet from some trading platform.
The transactions status is comfirmed and I synchronized block, but balance still is 0sc.
https://imgur.com/hSw0K4j
I tried recover-windows.exe

run recover-windows
F:\BitCoin\Sia-UI\sia>recover-windows.exe scan
Seed:
Generating keys... Finished in 7.70 seconds.
Scanning blockchain...
Scanned to height 123446 (largest index seen: 1)
Finished scanning. Largest index found: 1
Suggested seed progress: 2

set seed progress
F:\BitCoin\Sia-UI\sia>recover-windows.exe set 2
Rewrote seed progress from 2 -> 2
The next time you unlock the wallet, it will need to do a full rescan.

but nothing to help.

This is because 1 SC is below the "dust threshold:" the cost of spending a 1 SC output (due to transaction fees) is greater than 1 SC. We are working to make this less confusing in the UI. Rest assured that if you send a larger amount, it will appear in your balance.

please, reconsider taking off from the main GitHub tittle "highly efficient wallet" ... come back at us when u have worked out something w trezor or others


Release 0.1.5

Working towards a new release. I've added a change log, updated the README and made sure the generated documentation is the same as what's in the README.

If you want to release this @reem then please create the 0.1.5 tag once this is merged. That way the link in the change log works. You can of course also add me as a owner and then I can do all this myself.


Tox Fixing (cherry-picked and hand-picked from 192)

What do these changes do?
These are cherry-picked commits from PR #192 only related to tox + unittest + coverage.py
In summary, major things implemented in this PR:

Fixes tox to run well on three platforms: Windows, WSL, and Ubuntu
Fixes a lot of niggling "qa" fails which had been happening in master for some time but no one ever tried to fix (apparently)
Adds support for Python 3.8, Python 3.9, and PyPy3
Workaround due to Python 3.8 error messages "bleeding through" [1]
Optimize Travis config
Update README.rst to explain more about how we do tox

Since all but one (marked "[1]" above) of the changes are picked directly from PR #192 , merging this should not block #192 from being merged.

Are there changes in behavior for the user?
None.
This only makes QA life easier.

Related issue number
None.

Checklist

[x] I think the code is well written
[x] Unit tests for the changes exist
[x] Documentation reflects the changes
[x] Add a new news fragment into the CHANGES folder  -- I still have no idea on where "CHANGES" is. In any case, this should not be part of news because the changes affect only maintainers, not users.
[x] Unit tests have been run on the following platforms:

[x] Windows 10 (via PyCharm)
[x] Windows Subsystem for Linux (including PyPy3 testenv)
[x] Linux (including PyPy3 testenv)

I figure that these fixes are too valuable to be buried deep in #192 so I extracted them into a separate PR.
Because the changes are cherry-picked (or copied-and-pasted manually), this should not block #192.

Already reviewed these in 192 🙃 🚀

Yaay, it's merged!
Now I can apply for a Hacktoberfest Shirt! 😜
Ahahah, seriously, that was not my main intention. Just wanting to help maintain this nice package.
still, a shirt is a nice side-benefit


Align Italian with current English version

As title

/language it

@sftim can you please add an /approve? thanks :-)

/approve


Crypted password gets updated even if the record is invalid

Here's the deal. I have little form that let's the user change his password by entering password and password_confirmation. The controller has a standard update action that does an #update_attributes and depending on the return value calls it a success or failure. This works as expected, i.e. the user gets a validation error if password and passworfd_confirmation do not match. Cool so far.
Yet, internally Sorcery does update crypted_password when a new password is assigned (even if it does not match password_confirmation). The record is not being saved because it is invalid, though. So not a big problem.
But --- BIG but: When the activity logging goes ahead and does a #update_attribute on the last_activity_at column, the record will get saved without validation AND (this is Rails behaviour, I personally would call a bug, but they call it a feature) all dirty colums including crypted_password get updated together with last_activity_at. And the user ends up with a new password even though, the record is invalid and the controller told him, that the change could not be performed.
So either Sorcery should not touch the crypted_password at all when the record is invalid and/or the activity logging should make sure that only last_activity_at is being touched by it (this could be achieved by using #update_all with a condition on the id instead of using #update_attribute).
Thoughts?

BTW, to work around the problem until the behaviour is fixed, I ended up with a little before_update filter in the user model as follows:
class User < ActiveRecord::Base

  authenticates_with_sorcery!
  before_update :reset_crypted_password_if_invalid

  # ...

  protected

  def reset_crypted_password_if_invalid
    if password.present? && password != password_confirmation
      self.password = self.password_confirmation = nil
      self.salt = salt_was
      self.crypted_password = crypted_password_was
    end
  end

end


Use FlatMenu.handle to produce a list of template directories to try for templates

Instead of having to pass the template and sub_menu_template values to the {% flat_menu %} tag to specify different templates for each menu, it'd be helpful if wagtailmenus could automatically look for relevant templates in menus/handle/; falling back to menus/ if nothing was found. I know handles are editable and subject to change, but if used alongside the WAGTAILMENUS_FLAT_MENUS_HANDLE_CHOICES setting, I think the chance of 'unlinking' a menu from the templates created for it would be massively reduced.

Proposed order of template locations to try for the menu itself:

menus/{{ handle }}/{{ handle }}.html
menus/{{ handle }}/flat_menu.html
menus/{{ handle }}/menu.html
menus/{{ handle }}.html
menus/flat_menu.html (or whatever default is)

Proposed order of template locations to try for rendering sub_menus:

menus/{{ handle }}/sub_menu.html
menus/{{ handle }}_sub_menu.html
menus/sub_menu.html (or whatever default is)


fix: leveldb not close when stop program

when I restart program and got those errors

I think it is program can not correct to close level db
this link could get more info
https://github.com/Level/classic-level#dbclosecallback

Hey @zyjblockchain , I've released 1.2.17, where I'm forcing the leveldb to open.
But in general - I would suggest trying out the different - LMDB - cache implementation - https://github.com/warp-contracts/warp-contracts-lmdb#warp-contracts-lmdb-cache
I'm using the lmdb in our cache implementation (with many concurrent evaluators working at the same time) - and it works without issues.
Or you can create your own implementation - according to your need - you can take the warp-contracts-lmdb-cache as an example - it is simply a SortKeyCache interface implementation.


Add support for sending a threaded message to the WebAPI

I think this should cover the SKWebAPI portion of https://github.com/SlackKit/SlackKit/issues/100.

👍 Looks good, thanks!


White window

Issue Type: Bug
Every time I open the application, its window becomes white and I can't see anything. After changing the size of the window the content is showed again, but later the problem is back.
Azure Data Studio version: azuredatastudio 1.14.1 (f9b968c1ae514a0d1210788629e1c69125857279, 2019-12-24T02:42:26.303Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7600U CPU @ 2.80GHz (4 x 2904)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.88GB (0.72GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

I started experiencing this issue today also.


Ejection() might get called multiple times

Find code here
Make a copy of this issue in the internships2022 repo

The function  init checkApogee(){}  runs once since the state will be different for the next execution.


[macOS] CachedImage on Modal appears only the first time

Description
On macOS, the CachedImage is displayed only the first time in a Modal. If the Modal is closed and reopened, the image is not displayed. It works on UWP, iOS & Android.
Basic Information

Version with issue: 2.3.4
Platform: Xamarin.Forms <IP_ADDRESS>203 on macOS

Reproduction Link / Code
https://github.com/MADSENSE/Madsense.XamarinForms.Sample/tree/FFImageLoading-ModalPage

@daniel-luberda do you have a fix for this? I tried to disable the cache, the problem persists. This is blocking on macOS, the images are displayed only the first time in navigation between views.

That was hard :/ Fixed :)

Thank you 😄


[Chore] Add google analytics ID

What needs to be done
Required for game-client, shouldn't re-use whats in internal-client

Has been added, and is working.