Snippet only on one line

Hello again!
First a little follow-up on #3, it seems it's working much better now, I'm now using 0.7 and I have the latest version of your plugins.
I'm now facing another issue, but I'm not certain it's related to your plugin specifically. What happens is that the snippets suggested only cover one line:

This suggestion from copilot is not displaying more than one line, and I'm sure it's not supposed to be that short, and it doesn't matter if I select it, it remains short.
In comparison, here is a snippet related to typescript in this case:

This one generates the expected snippet on multiple lines.
My config is the following:
Packer:
      {
         "zbirenbaum/copilot.lua",
         event = { "VimEnter" },
         config = function()
            vim.defer_fn(function()
               require("copilot").setup()
            end, 100)
         end,
      },
      {
         "zbirenbaum/copilot-cmp",
         after = { "copilot.lua", "nvim-cmp" },
      },

nvim-cmp:
   snippet = {
      expand = function(args)
         require("luasnip").lsp_expand(args.body)
      end,
   },
   formatting = {
      format = function(entry, vim_item)
         local icons = require "plugins.configs.lspkind_icons"
         vim_item.kind = string.format("%s %s", icons[vim_item.kind], vim_item.kind)

         vim_item.menu = ({
            nvim_lsp = "[LSP]",
            nvim_lua = "[Lua]",
            buffer = "[BUF]",
         })[entry.source.name]

         return vim_item
      end,
   },
   mapping = {
      ["<C-p>"] = cmp.mapping.select_prev_item(),
      ["<C-n>"] = cmp.mapping.select_next_item(),
      ["<C-d>"] = cmp.mapping.scroll_docs(-4),
      ["<C-f>"] = cmp.mapping.scroll_docs(4),
      ["<C-Space>"] = cmp.mapping.complete(),
      ["<C-e>"] = cmp.mapping.close(),
      ["<CR>"] = cmp.mapping.confirm {
         behavior = cmp.ConfirmBehavior.Replace,
         select = true,
      },
      ["<Tab>"] = cmp.mapping(function(fallback)
         if cmp.visible() then
            cmp.select_next_item()
         elseif require("luasnip").expand_or_jumpable() then
            vim.fn.feedkeys(vim.api.nvim_replace_termcodes("<Plug>luasnip-expand-or-jump", true, true, true), "")
         else
            fallback()
         end
      end, { "i", "s" }),
      ["<S-Tab>"] = cmp.mapping(function(fallback)
         if cmp.visible() then
            cmp.select_prev_item()
         elseif require("luasnip").jumpable(-1) then
            vim.fn.feedkeys(vim.api.nvim_replace_termcodes("<Plug>luasnip-jump-prev", true, true, true), "")
         else
            fallback()
         end
      end, { "i", "s" }),
   },
   sources = {
      { name = "copilot" },
      { name = "nvim_lsp" },
      { name = "luasnip" },
      { name = "buffer" },
      { name = "nvim_lua" },
      { name = "path" },
   },

Okay it seems the issue is coming from copilot: https://github.com/github/feedback/discussions/13303

Okay it seems the issue is coming from copilot: github/feedback#13303

Yeah copilot is buggy. The actual codex api is better, but I haven't had a chance to implement a minimal LSP with it, and likely won't for at least a couple weeks. Also, waaaay less people have access to to the actual openai codex beta I think.

I'm still not sure how microsoft managed to make copilot worse than just the vanilla API calls, but I am somewhat impressed.

Having experience with Microsoft APIs, I'm not suprised tbh. Okay so I guess there's nothing to do but wait, right?

Hello there! So apparently Microsoft has rolled out an update. I see you also updated the copilot.lua. Copilot's suggestions are now back on cmp.
However I still have the same issue:

Here you can see my first suggestion is only the first line, I'm starting to doubt Copilot is the problem here. Do you think some plugins I'm using could be the reason? I'm thinking maybe the setting to close brackets and parenthesis automatically might cause this.

Hello there! So apparently Microsoft has rolled out an update. I see you also updated the copilot.lua. Copilot's suggestions are now back on cmp.
However I still have the same issue:
Here you can see my first suggestion is only the first line, I'm starting to doubt Copilot is the problem here. Do you think some plugins I'm using could be the reason? I'm thinking maybe the setting to close brackets and parenthesis automatically might cause this.

@Ganitzsh, you are right. The autopair plugin is messing with the Cmp.
   -- misc plugins
   ["windwp/nvim-autopairs"] = {
      after = "nvim-cmp",
      config = function()
         require("plugins.configs.others").autopairs()
      end,
   },

Removing the above snippet fixed this issue.

I managed to make them both work in harmony.
From:
   cmp.event:on("confirm_done", cmp_autopairs.on_confirm_done())

To:
   cmp.event:on("confirm_done", cmp_autopairs.on_confirm_done { map_char = { tex = "" } })

No luck here, just tried to disable autopairs and still getting incomplete suggestions. I'll try to learn a bit more about coding plugins for neovim and try to debug this properly. I'm using nvchad, so I'll have to go through most of the plugins to find the culprit.
Thanks @Hunter-Thompson for this, I think this could be added to the README in a new FAQ section maybe?

I use nvchad also, if you find a solution do add it here : )
   autopairs.setup {
      fast_wrap = {},
      disable_filetype = { "TelescopePrompt", "vim" },
   }

I wonder if CMP is its own filetype? Autopair has a disable filetype option which works well with TelescopePrompt. Maybe something can be done here?

Oh my, both of you are NvChad users? Of course its another repo I maintain causing problems with my own repo :laughing:
@Ganitzsh completely disabling autopairs didn't work? I was going to look into @Hunter-Thompson's filetype idea but if disabling autopairs didn't fix the problem adding an exclusion won't either.

@zbirenbaum yep didn't work, removed and cleaned but still happening

@Ganitzsh can you try using the following cmp config and see if it fixes the issue? You may need to make some small changes for the lspkind stuff but it should be fairly managable:
local present, cmp = pcall(require, "cmp")

local lspkind = require("custom.plugins.completion_plugins.cmp_configs.lspkind")
if not present then
  return
end

vim.opt.completeopt = "menuone,noselect"
cmp.setup({
  snippet = {
    expand = function(args)
      require("luasnip").lsp_expand(args.body)
    end,
  },
  style = {
    winhighlight = "NormalFloat:NormalFloat,FloatBorder:FloatBorder",
  },
  formatting = {
    format = lspkind.cmp_format({ with_text = false, maxwidth = 50 }),
  },
  window = {
    completion = {
      border = { "╭", "─", "╮", "│", "╯", "─", "╰", "│" },
      scrollbar = "║",
      winhighlight = 'Normal:CmpMenu,FloatBorder:CmpMenuBorder,CursorLine:CmpSelection,Search:None',
      autocomplete = {
        require("cmp.types").cmp.TriggerEvent.InsertEnter,
        require("cmp.types").cmp.TriggerEvent.TextChanged,
      },
    },
    documentation = {
      border = { "╭", "─", "╮", "│", "╯", "─", "╰", "│" },
      winhighlight = "NormalFloat:NormalFloat,FloatBorder:FloatBorder",
      scrollbar = "║",
    },
  },
  mapping = {
    ["<PageUp>"] = function()
      for _ = 1, 10 do
        cmp.mapping.select_prev_item()(nil)
      end
    end,
    ["<PageDown>"] = function()
      for _ = 1, 10 do
        cmp.mapping.select_next_item()(nil)
      end
    end,
    ["<C-p>"] = cmp.mapping.select_prev_item({ behavior = cmp.SelectBehavior.Select }),
    ["<C-n>"] = cmp.mapping.select_next_item({ behavior = cmp.SelectBehavior.Select }),
    ["<C-d>"] = cmp.mapping.scroll_docs(-4),
    ["<C-f>"] = cmp.mapping.scroll_docs(4),
    ["<C-s>"] = cmp.mapping.complete({
        config = {
          sources = {
            { name = 'copilot' },
          }
        }
      }),
    ["<C-e>"] = cmp.mapping.close(),
    ["<CR>"] = cmp.mapping.confirm({
      behavior = cmp.ConfirmBehavior.Replace,
      select = false,
    }),
    ["<Tab>"] = function(fallback)
      if cmp.visible() then
        cmp.select_next_item({ behavior = cmp.SelectBehavior.Select })
      else
        fallback()
      end
    end,
    ["<S-Tab>"] = function(fallback)
      if cmp.visible() then
        cmp.select_prev_item({ behavior = cmp.SelectBehavior.Select })
      else
        fallback()
      end
    end,
  },
  experimental = {
    native_menu = false,
    ghost_text = true,
  },
  sources = {
    { name = "copilot", group_index = 2 },
    { name = "nvim_lsp", group_index = 2 },
    { name = "path", group_index = 2 },
    { name = 'orgmode', group_index = 2 },
    { name = 'neorg', group_index = 2 },
    { name = "nvim_lua", group_index = 2 },
    -- { name = "luasnip", group_index = 2 },
    -- { name = "buffer", group_index = 5 },
  },
  sorting = {
    comparators = {
      cmp.config.compare.recently_used,
      cmp.config.compare.offset,
      cmp.config.compare.score,
      cmp.config.compare.sort_text,
      cmp.config.compare.length,
      cmp.config.compare.order,
    },
  },
  preselect = cmp.PreselectMode.Item,
})

--set max height of items
vim.cmd([[ set pumheight=6 ]])

Hey there! Sorry for the delay, I confirm it's now working for the most part. I noticed most of the issues I have are with TypeScript, but I'll keep monitoring. This one's resolved, thanks.

@zbirenbaum I seem to be having the same issue with the latest version of NvChad

I have no issues with other languages, but it still happens when I use TypeScript. Not sure what's wrong there, if it can help

Yeah I noticed it in JS and TS a day ago. Doesn't seem to happen for anything else though. I'll check to see if it's just copilot results being one line or if it's a bug on the plugin end

Ok a couple updates here. I have confirmed that the issue is not in my handling, but in the response itself. This may be fixed in the most recent version of copilot, but I am currently trying to reverse engineer what the changes were, as updating the copilot js code caused a massive series of unhandled exceptions and got my CPU running as hot as a stress test. Once I figure out what has happened, I can update, and hopefully this will be solved.

I haven't seen this problem for a bit. Is anyone still having it or is this safe to close?

I don't have access to copilot anymore, I cannot check. I guess if no one is replying in a few days you can close it.

Okay I subscribed to test but I still have the issue with JS/TS:

@Ganitzsh Microsoft has pushed versions of copilot that cause major problems at multiple points, so I manually include and update the copilot lsp myself after testing it. For a while I debated autoupdating, but the issues were too frequent. If you are also having the same issue on VSCode, it is likely not fixed in any version, as VSCode includes its lsp inside of the extension itself.
The vscode extension should be located in ~/.vscode/extensions, their lsp version should be in there. If you want to try a different copilot version, go to wherever packer installs copilot.lua, and replace the agent.js file in copilot/dist with a different one. ver_update.sh in the project root will automatically pull the latest version from copilot.vim and replace the current one, so you can try using that to test it.
This is almost certainly not an issue with copilot.lua, but with the copilot lsp itself.... I'm tempted to close this since it's upstream, but I'll leave it up to you @Ganitzsh

Thanks for all this, yeah we can close it, it's definitely not an issue of this plug-in.
It's very random at this point and it happened that it worked for a week then stopped again.

FYI I  opened a ticket with the Support team, they confirmed that it was a currently known issue and it is being worked on internally. No ETA can be given, as it seems to be a problem inherent to the model which is biased in some languages. I'll just throw another update here as soon as the issue is resolved, hopefully sooner than later.

FYI I opened a ticket with the Support team, they confirmed that it was a currently known issue and it is being worked on internally. No ETA can be given, as it seems to be a problem inherent to the model which is biased in some languages. I'll just throw another update here as soon as the issue is resolved, hopefully sooner than later.

Ahh that’s unfortunate, but I did think it was likely to be the case. Thanks for letting me know and keeping track of the issue!

Hey I was experiencing this issue for a couple of days thanks for all the info here. I'm having this issue with Python but works fine on Lua.

Here we go again! @zbirenbaum The GitHub support came back to me and gave me a temporary fix for VS Code, where they suggested me to add the following configuration:
"github.copilot.advanced": {
    "indentationMode": {
      "javascript": "client",
      "typescript": "client",
    }
  }

I confirm it works, but I'm not sure how I can replicate it with copilot-cmp, I went through the README again but couldn't find the equivalent for advanced.indentationMode.
Can you add support for this or is it specific to the VS Code plugin?

Here we go again! @zbirenbaum The GitHub support came back to me and gave me a temporary fix for VS Code, where they suggested me to add the following configuration:
"github.copilot.advanced": {
    "indentationMode": {
      "javascript": "client",
      "typescript": "client",
    }
  }

I confirm it works, but I'm not sure how I can replicate it with copilot-cmp, I went through the README again but couldn't find the equivalent for advanced.indentationMode.
Can you add support for this or is it specific to the VS Code plugin?

Some of those types of options are available from outside vscode, It depends on if they implemented them in the lsp or the vscode client extension. Ill take a look tomorrow, thanks for the info, that’s super helpful!

Alright, thanks! In the meantime I asked if they could give me a Vim equivalent, hopefully if it's not possible they might implement it, if they have a fix too I'll let you know here, I guess it'd make things easier to implement it here.

I just pushed a fix. @Ganitzsh Let me know how it works for you. I found the advanced.indentationMethod field inside the lsp, but I couldn't get it to do anything whatsoever. I did find some code inside that actually handles the indentation within the lsp after receiving the completion. My life would be a million times easier if they would just release the damn source code, it's honestly ridiculous that they don't since the valuable part of copilot is the model itself. If you are in contact with them again, feel free to let them know I'd be happy to write a fix and dedicated vim support.
Indentation is by far the most frustrating part of working with copilot and cmp. I need to make an issue in cmp about the execution functions now triggering at the wrong times after a recent update, which broke a bunch of stuff, including possibly this, but it looks like its probably on the copilot end this time.

Thanks for the quick reaction @zbirenbaum unfortunately it doesn't seem to work, still doesn't show multi-line suggestions, also now going through copilot's suggestions throws this error:

The support told me they will try to come back to me with a fix for vim, hopefully they deliver.

Thanks for the quick reaction @zbirenbaum unfortunately it doesn't seem to work, still doesn't show multi-line suggestions, also now going through copilot's suggestions throws this error:

I updated everything, including cmp itself, not sure what caused it.
The support told me they will try to come back to me with a fix for vim, hopefully they deliver.

Sorry about that, there was a brief period that one of the options was broken after I did a really large refactor and cleanup to account for some of the cmp changes and be a bit more defensive against copilot's formatting. That option has since been removed as it was a hacky solution for a problem that doesn't appear to exist anymore and shouldn't be necessary.
It should be working since this morning, could you try syncing? I'm getting multi line completions well formatted on the current version.

No worries, just updated and the error is gone.
Unfortunately I still have the issue, this is VS Code (with the fix mentioned yesterday):

And this is nvim with the latest version of copilot.lua and copilot-cmp:

The support got back to me with this about vim:
With plain Vim (not Neovim), this was caused by a change to the brand new ghost text API.
The latest version of Copilot.vim should fix it for you.

Can you try it with the copilot suggestion module in copilot.lua? It aims to replicate copilot.vim's ghost text. If it works it would make things easier to debug.

I have the same issue here.
On lua it works fine, on Typescript it only shows the completion for your current line :(

@primeapple same for me since I use this plugin 😞
I have multiline on lua/rust… but not on typescript

Same but but with Python, usually only the function declaration line and nothing more.

I have the same issue here on golang.

Same here for python, using LunarVim

Same in ruby...

Hey there! @zbirenbaum I've tried everything you've suggested and I get the same problem no matter what. I decided to give it some time to see if the copilot's updates would change anything but it seems like the problem remains. Visual Studio code is still working as expected, I think it's a shame that GitHub is not supporting neovim officially with the Lua API, but ow well. Not sure what you want to do with that issue, maybe you can pin it? It seems it's impacting quite a few people by now. And also maybe you can reach out to GitHub to ask them if they'd like to help who knows 😂

Hey there! @zbirenbaum I've tried everything you've suggested and I get the same problem no matter what. I decided to give it some time to see if the copilot's updates would change anything but it seems like the problem remains. Visual Studio code is still working as expected, I think it's a shame that GitHub is not supporting neovim officially with the Lua API, but ow well. Not sure what you want to do with that issue, maybe you can pin it? It seems it's impacting quite a few people by now. And also maybe you can reach out to GitHub to ask them if they'd like to help who knows 😂

I can reach out to GitHub tomorrow through the discussions, but unfortunately the last few times I have done so weren't particularly helpful.
I've done a fairly extensive amount of testing on this since I have the issue consistently with a few langs I use for work but it's just an issue with the data copilot returns. The methodology for requesting completions actually got updated recently but the issue has persisted.
Unless someone can confirm that copilot.vim or copilot.lua's vtext doesn't run into this problem I'm afraid it's not on my end. That said, I'll make a post on the GitHub discussions and link this there.

FYI I've been subscribed to the GitHub discussion on this for ages. It has people complaining every day that one-line snippets don't work. It's across many editors, including VSCode. It is almost certainly a Copilot issue.
It seems a bit random, and javascript is most impacted.
One tip seems to be if you close the curly race to a function, you're more likely to get multiline suggestions for the content.
Frustratingly there seems to be no response from GitHub at all.
If anyone knows someone that works there, I'd suggest reaching out.

@zbirenbaum Unfortunately nope, nothing new from GitHub. I guess my configuration is also triggering the broken responses in a way and that's why I don't see issues on VSCode that often.

If anyone is interested in the underlying reason that changing indentationMode causes single or multi-line suggestions, you can see my findings here. It all has to do with the stop parameter that is sent to the completions endpoint and whether it is one or three newlines.
I'm still curious if anyone knows how to pass parameters like indentationMode into the extension. Or, better, yet, if there is a way to override or patch the extension to to always send a stop of three newlines.

I have the same issue, using latest versions.

For a short term fix, see here: https://github.com/orgs/community/discussions/40522#discussioncomment-6676897

But that is a fix of VS Code.
I couldn't find a why to do the same fo Neovim.

But that is a fix of VS Code. I couldn't find a why to do the same fo Neovim.

It's literally written there:

I could apply the same hack to copilot.lua plugin for neovim. The file you need to change this in, is in copilot/dist/agent.js

I have the same issue, using latest versions.

For a short term fix, see here: https://github.com/orgs/community/discussions/40522#discussioncomment-6676897

But that is a fix of VS Code.
I couldn't find a why to do the same fo Neovim.

The agent.js file is an off spec lsp distributed by microsoft/GitHub. Copilot.lua, copilot.vim, and the VsCode extensions just interface with it to provide results. Problems like this aren't actually issues with copilot-cmp and there's nothing I can change about the plug-in to fix them.
I'm working on my own version of agent.js (it's mostly functional but I think it gets rate limited and breaks after a bit) so some of these issues can be fixed in a less hacky way, but it's a large undertaking and won't be fully polished for a bit.

But that is a fix of VS Code. I couldn't find a why to do the same fo Neovim.

It's literally written there:

I could apply the same hack to copilot.lua plugin for neovim. The file you need to change this in, is in copilot/dist/agent.js

Ok, I missed that somehow.
I did the change, but the completion stopped working completely...
$ rg --only-matching '.{21}\["(\\n)+"\]' ~/.config/nvim/pack/github/start/copilot.lua/copilot/dist/agent.js
2:n.multiline||(h.stop=["\n\n\n"]

My completion.lua config:
-- luacheck: globals vim

-- GitHub Copilot config
require('copilot').setup({
  suggestion = { enabled = false, auto_trigger = false },
  panel = { enabled = false },
})

require('copilot_cmp').setup()

-- Set up nvim-cmp.
local cmp = require 'cmp'

---@cast cmp -nil
cmp.setup({
  completion = {
    autocomplete = false,
  },
  snippet = {
    -- REQUIRED - you must specify a snippet engine
    expand = function(args)
      -- vim.fn["vsnip#anonymous"](args.body) -- For `vsnip` users.
      require('luasnip').lsp_expand(args.body) -- For `luasnip` users.
      -- require('snippy').expand_snippet(args.body) -- For `snippy` users.
      -- vim.fn["UltiSnips#Anon"](args.body) -- For `ultisnips` users.
    end,
  },
  window = {
    -- completion = cmp.config.window.bordered(),
    -- documentation = cmp.config.window.bordered(),
  },
  mapping = cmp.mapping.preset.insert({
    ['<C-b>'] = cmp.mapping.scroll_docs(-4),
    ['<C-f>'] = cmp.mapping.scroll_docs(4),
    ['<C-Space>'] = cmp.mapping.complete(),
    ['<C-e>'] = cmp.mapping.abort(),
    -- Accept currently selected item. Set `select` to `false` to only confirm explicitly selected items.
    ['<CR>'] = cmp.mapping.confirm({ select = true }),
  }),
  sources = cmp.config.sources({
    { name = 'nvim_lsp' },
    -- { name = 'vsnip' }, -- For vsnip users.
    { name = 'luasnip' }, -- For luasnip users.
    -- { name = 'ultisnips' }, -- For ultisnips users.
    -- { name = 'snippy' }, -- For snippy users.
    { name = 'copilot' },
  }, {
    { name = 'buffer' },
  })
})

-- Set configuration for specific filetype.
-- cmp.setup.filetype('gitcommit', {
--   sources = cmp.config.sources({
--     -- You can specify the `git` source if [you were installed it](https://github.com/petertriho/cmp-git).
--     { name = 'git' },
--   }, {
--     { name = 'buffer' },
--   })
-- })

-- Use buffer source for `/` and `?` (if you enabled `native_menu`, this won't work anymore).
cmp.setup.cmdline({ '/', '?' }, {
  mapping = cmp.mapping.preset.cmdline(),
  sources = {
    { name = 'buffer' }
  }
})

-- Use cmdline & path source for ':' (if you enabled `native_menu`, this won't work anymore).
cmp.setup.cmdline(':', {
  mapping = cmp.mapping.preset.cmdline(),
  sources = cmp.config.sources({
    { name = 'path' }
  }, {
    { name = 'cmdline' }
  })
})

-- Set up lspconfig.
local capabilities = require('cmp_nvim_lsp').default_capabilities()
local lspconfig = require('lspconfig')
local servers = { 'bashls', 'lua_ls', 'solargraph', 'tsserver', 'vimls' }

for _, lsp in ipairs(servers) do
  lspconfig[lsp].setup({
    capabilities = capabilities,

    on_attach = function(_, bufnr)
      -- Enable completion triggered by <c-x><c-o>
      vim.api.nvim_buf_set_option(bufnr, 'omnifunc', 'v:lua.vim.lsp.omnifunc')
      vim.api.nvim_buf_set_option(bufnr, 'tagfunc', 'v:lua.vim.lsp.tagfunc')

      -- Mappings.
      -- See `:help vim.lsp.*` for documentation on any of the below functions
      local bufopts = { noremap=true, silent=true, buffer=bufnr }
      vim.keymap.set({ 'n', 'i' }, '<Leader><F2>', vim.lsp.buf.rename, bufopts)
      vim.keymap.set({ 'n', 'i' }, '<F12>', vim.lsp.buf.definition, bufopts)
      vim.keymap.set('n', '<Leader><F12>', vim.lsp.buf.type_definition, bufopts)
      vim.keymap.set({ 'n', 'i' }, '<F9>', vim.lsp.buf.hover, bufopts)
      vim.keymap.set('n', 'gi', vim.lsp.buf.implementation, bufopts)
      vim.keymap.set('n', 'gr', vim.lsp.buf.references, bufopts)
      vim.keymap.set('n', '<Leader>rn', vim.lsp.buf.rename, bufopts)
      vim.keymap.set('n', '<Leader>ca', vim.lsp.buf.code_action, bufopts)
    end
  })
end

local lspkind = require('lspkind')
cmp.setup {
  formatting = {
    format = lspkind.cmp_format({
      mode = 'symbol_text',
      maxwidth = 50,
      ellipsis_char = '...',
    })
  }
}

I've been using VS Code now for a month, for what it's worth, it does exactly the same thing now (it wasn't always doing it back then). I also came across a LinkedIn post from GitHub demonstrating how to use copilot in JS and the same was shown (each new line gave a suggestion until the end of the scope)
So my 2 cents here for JS/TS devs out there wondering if it's a normal behaviour, don't bother trying to "fix" it, it ain't broken. @zbirenbaum You mentioned it in the early days of this thread, seems like it's not going to change anytime soon.

I've been using VS Code now for a month, for what it's worth, it does exactly the same thing now (it wasn't always doing it back then). I also came across a LinkedIn post from GitHub demonstrating how to use copilot in JS and the same was shown (each new line gave a suggestion until the end of the scope)
So my 2 cents here for JS/TS devs out there wondering if it's a normal behaviour, don't bother trying to "fix" it, it ain't broken. @zbirenbaum You mentioned it in the early days of this thread, seems like it's not going to change anytime soon.

Yeah I think this is right. There was a bug for a short period due to changes in cmp where sent multilines weren't appearing but that was fixed a while ago. Anything referenced here that is still a problem isn't fixable in copilot-cmp so i'm going to close this for now.

After a recent update, it has been working... sometimes.

I'm still having this issue w/ golang via LazyVim's copilot extra w/ default settings.


versioned values.yaml build output

Pull the version string out of each package.json, create a values.yaml file for subsequent use with helm

lgtm in in general with the following questions/statements:
as i understand it ./bin/mdsctl build should still-do-the-right-thing, in that images will be built and tagged appropriately in the local repo
q: re the conditionally-push-to-image-repo pr [ https://github.com/CityOfLosAngeles/mds-core/blob/feature/jwtodd-conditionally-push-to-image-repo/bin/install#L212 ] what changes are required?
also, does bin/mdsctl install:mds requires modification, ie point to the generated values.yaml?

lgtm in in general with the following questions/statements:
as i understand it ./bin/mdsctl build should still-do-the-right-thing, in that images will be built and tagged appropriately in the local repo

Correct.

q: re the conditionally-push-to-image-repo pr [ https://github.com/CityOfLosAngeles/mds-core/blob/feature/jwtodd-conditionally-push-to-image-repo/bin/install#L212 ] what changes are required?

I'm not sure - this PR only creates the up-to-date values.yaml for the apis: map - shouldn't affect any part of the image build.

also, does bin/mdsctl install:mds require modification, ie point to the generated values.yaml?

I'm not seeing where it points to any particular values.yaml file by default - are you referring to this?
      ${configs[values]:+$(helmOptions values ${configs[values]})} \
      ${configs[values-mds]:+$(helmOptions values ${configs[values-mds]})} \


Sourcemaps

Could we have sourcemaps for the minified versions? Would make debugging so much easier. You can do it with Webpack.

Or with rollup too. Yes, that sounds like something we can all agree!

Yea. Rollup with rollup-plugin-buble and rollup-plugin-uglify and passing just sourceMap: true to Rollup, gives zero config and sourcemaps.

@rbiggs SourceMaps are now available:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

Yup, I just noticed. Thanks. Will make it a whole lot easier to debug now.

We can close this :)

Hi @rbiggs, can you share how you are using source maps to debug? I don't use them, so I really wasn't paying much attention when this issue was created, but now that I thought about it a bit, hyperapp is written in ES5, so what's the benefit of distributing a source map?

@dodekeract Are you using<EMAIL_ADDRESS>

I was using a dev server to test hyperapp. In production you'll be using the minified/uglified version of hyperapp, so sourcemaps are very useful to have!

The last line in hyperapp.js
//# sourceMappingURL=hyperapp.js.map

makes the Dev Console download/load hyperapp's source map during a debug session, when an exception occurs, etc.
Without source maps 😞

With source maps 😄


Add Rust quantum volume function

Summary
This commit adds a new function quantum_volume used for generating a quantum volume model circuit. This new function is defined in Rust and multithreaded to improve the throughput of the circuit generation. This new function will eventually replace the existing QuantumVolume class as part of #13046. Since quantum volume is a circuit defined by it's structure using a generator function is inline with the goals of #13046.
Right now the performance is bottlenecked by the creation of the UnitaryGate objects as these are still defined solely in Python. We'll likely need to port the class to have a rust native representation to further speed up the construction of the circuit.
Details and comments

I ran some benchmarks comparing the construction speed of the quantum volume circuit using a logarithmic sweep from 10 to 1000 qubits (with equal depth for each point) using this function in parallel and serially (by setting QISKIT_IN_PARALLEL=TRUE) and comparing that against the Python QuantumVolume class:

All these results were on my laptop with a AMD Ryzen 7 PRO 7840U.
There is potentially some tuning we might want to do about the number of threads and the chunk size for each parallel worker. But this seems like a reasonable balance and nothing I've changed so far appreciably changed the performance. It might be worth testing for the serial path though if doing the unitary generation all up front, like what is done in the parallel case, improves performance.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

94 of 112 (83.93%)  changed or added relevant lines in 4 files are covered.
10 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.01%) to 88.857%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/circuit/library/quantum_volume.py
5
6
83.33%

crates/accelerate/src/circuit_library/quantum_volume.rs
87
104
83.65%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
4
92.48%

crates/qasm2/src/parse.rs
6
96.23%

Totals

Change from base Build<PHONE_NUMBER>7:
-0.01%

Covered Lines:
74215

Relevant Lines:
83522

💛  - Coveralls


Create a specific profiler for Releaser

We should add a dedicated profiler at the level of Releaser.

There is now a basic profile that gives details about the performance of individual actions.


NSP API changes

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[x] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@kaushal087, could you fix all the linter issues in this PR, for the breaking change, please refer to http://aka.ms/bcforapi for the review. Thanks

@nikhilsaxena2609 Made changes and resolved all comments.

    "x-ms-long-running-operation": true,

This delete is now async, is 200 and 204 still supported?

Refers to: specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json:690 in 054894f. [](commit_id = 054894ffd4a3790b359a35127161ab8eb3c4dae4, deletion_comment = False)

    "x-ms-long-running-operation": true,

This delete is now async, is 200 and 204 still supported?
Refers to: specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json:690 in 054894f. [](commit_id = 054894f, deletion_comment = False)

We support both async and sync so these status codes are required.

@raosuhas , thanks for the comments. I have made all the requested changes/provided explanation for the changes. Could you please review and mark these as resolved.

@raosuhas Could you please review and approve it?

@raosuhas Could you please review and approve it?

@MikhailTryakhov , this is an extension to the earlier definition of NSP APIs. This is for a preview version. Please take a look at it and approve if looks fine.


HBT-157 - Handle Google additional GDPR consent

Hey @samiul-shanto,
How did you test this? When I override headerlift.min.js with my local version pointing to a local PBS, I can't see any requests made to any bidders from PBS. Are you aware of this and why this is happening?

Hello @jbartek25
Sorry for delay reply.
We made a modification to headerlift build. We do following to test:

remove enablePrebidServer condition check in file src/prebid.js:228 then build headerlift - so all request go to PBS by default, not depend on config
Used script redirector for https://hb.improvedigital.com/pbw/headerlift.min.js to our local headerlift build path

If any request doesn't go to local PBS, then if might be not enable enablePrebidServer in config

That part is clear. What is not clear, I don't see any server-side requests from PBS to Improve /pbs endpoint on HeaderLift sites. Do you?

Remember, in our last meeting I shown you I got warning message debug turned off for account in response when testing with browser. This was the response:
{
    "id": "9b193aae-af54-4f09-a55c-1859bdf1499a",
    "ext": {
        "warnings": {
            "general": [
                {
                    "code": 10002,
                    "message": "debug turned off for account"
                }
            ]
        },
        "responsetimemillis": {
            "improvedigital": 266
        },
        "tmaxrequest": 10000,
        "prebid": {
            "auctiontimestamp":<PHONE_NUMBER>666
        }
    }
}

But when I test with postman, it seems make a request (http://ad.360yield.com/pbs) pbs server.
Local PBS: http://localhost:8000/openrtb2/auction
HTTP Body:
    "id": "1cea8058-fd27-402f-969e-6e01dd558a58",
    "source": {
        "tid": "1cea8058-fd27-402f-969e-6e01dd558a58",
        "ext": {
            "schain": {
                "ver": "1.0",
                "complete": 1,
                "nodes": [
                    {
                        "asi": "headerlift.com",
                        "hp": 1,
                        "sid": "12972"
                    }
                ]
            }
        }
    },
    "tmax": 20000,
    "imp": [
        {
            "id": "ax-skin",
            "ext": {
                "improvedigital": {
                    "placementId": 22592087,
                    "keyValues": {
                        "hb": [
                            "true"
                        ],
                        "pbct": [
                            "2"
                        ]
                    },
                    "bidFloor": 0.0113,
                    "bidFloorCur": "USD"
                }
            },
            "banner": {
                "format": [
                    {
                        "w": 5,
                        "h": 5
                    }
                ]
            }
        }
    ],
    "test": 1,
    "ext": {
        "prebid": {
            "auctiontimestamp":<PHONE_NUMBER>607,
            "targeting": {
                "includewinners": true,
                "includebidderkeys": false
            },
            "channel": {
                "name": "pbjs",
                "version": "v5.14.0"
            }
        }
    },
    "cur": [
        "EUR"
    ],
    "site": {
        "publisher": {
            "id": "1"
        },
        "page": "https://deluxemusic.de/"
    },
    "device": {
        "w": 630,
        "h": 980
    },
    "user": {
        "ext": {
            "eids": [
                {
                    "source": "criteo.com",
                    "uids": [
                        {
                            "id": "5Vejl18lMkJNVG9adGg4blcwV3hIWUklMkZWSmY0TzBWRDhhdXVhak5Hck1La1dEemQwYm5DYW41TDNlamVRZHhJdjFKREtKbWhyZlRHRnRNR1lBRVVOOWlMcU5pZE9XckhDN1NmYVElMkZPRFNmOHBLd0RPam83SHVHUkdvaTNQaGh5JTJGJTJCSGNYOTE",
                            "atype": 1
                        }
                    ]
                },
                {
                    "source": "id5-sync.com",
                    "uids": [
                        {
                            "id": "ID5*rGWcLf3suIbuIVL4knDej5pof3cUIBzaTQY-D0mxAdMABgnF4xTwigQ4vchgXkA5AAy_SRruImMkIWEw_7cPwAAScMeS8UmQCr8hg5ySIA8AGJ6KypWholVlRHRgofVSAB7q5w4WsyI-NQM9q3giUQAkRHusKg59gYt9sgrI3HkAKmSOdpKVqPyGs4wd19r8ADDAydWTN1xmbl7hCR64FAA2GbiH916AZcbbHS-JuEYANxgT4wvXYhaVj3djNoNlADvXpoAhiHgadvcBgI0ghgA8McZnWpJCUc7Z4fsAG30AQuEl6WoX2aHlW0V57aspAEg_KvZ_djs90evwLKp4FABOGAVDn2rWKFDpruYgDTAAVNiyiuiK1M6FFr2aK3WmAFnq2h5481LJ_eODelEM5QBa3v6cKS5Bp12IB8VLsv0AYIVGfUciCA_cRzvUZDDLAGbDTvOtIjrtJWPcTJsMbABs6pVcTiRg7oqxBzwzC7EAcu6cX9nRhXytghQ_CMihAHjtBrlW9mCWlhoAwKRvtwB-2iBvhBHaEFSRrmj4OocAhAFrWdu8UiPRWPEPJg5bAIqHeKWUDujygUrdvI5mTw",
                            "atype": 1,
                            "ext": {
                                "linkType": 2
                            }
                        }
                    ]
                },
                {
                    "source": "crwdcntrl.net",
                    "uids": [
                        {
                            "id": "410cfa577bbdce99a40cba1cb6374945a702ea8e971d4c9ec45c52a0e0002d81",
                            "atype": 1
                        }
                    ]
                },
                {
                    "source": "pubcid.org",
                    "uids": [
                        {
                            "id": "f0dc0a55-6ea5-4345-8786-293addaa3a7d",
                            "atype": 1
                        }
                    ]
                }
            ],
            "consent": "CPP6vO1PP6vO1AKAkADEB2CsAP_AAH_AAAYgIXtf_X__bX9j-_59f_t0eY1P9_r3v-QzjhfNt-8F2L_W_L0X42E7NF36pq4KuR4Eu3LBIQNlHMHUTUmwaokVrzHsak2cpyNKJ7LEmnMZO2dYGHtPn9lTuZKY7_78__fz3j-v_t_-39T378X_3_d5_Wu--_O_V399zLv9____39nP___9v-_9-CF4BJhqXkAXZljgybRpVCiBGFYSFQCgAooBhaIrABgcFOysAj1hCwAQmoCMCIEGIKMGAQACCQBIREBIAWCARAEQCAAEAKEBCAAiYBBYAWBgEAAoBoWIEUAQgSEGRwVHKYEBUi0UEtlYAlBXsaYQBlvgRQKL6KjARrNECwMhIWDmOAJAS8WSB5gAAAAA.f_gAAAAAAAAA",
            "ConsentedProvidersSettings": {
                "consented_providers": "1~<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>9.266.272.286.291.311.317.322.323.326.327.338.367.371.385.389.394.397.407.413.415.424.430.436.440.445.449.453.482.486.491.494.495.501.503.505.522.523.540.550.559.560.568.574.576.584.587.591.733.737.745.780.787.802.803.817.820.821.829.839.864.867.874.899.904.922.931.938.979.981.985.1003.1024.1027.1031.1033.1034.1040.1046.1051.1053.1067.1085.1092.1095.1097.1099.1107.1127.1135.1143.1149.1152.1162.1166.1186.1188.1192.1201.1205.1211.1215.1226.1227.1230.1252.1268.1270.1276.1284.1286.1290.1301.1307.1312.1329.1345.1356.1364.1365.1375.1403.1415.1416.1419.1440.1442.1449.1455.1456.1465.1495.1512.1516.1525.1540.1548.1555.1558.1564.1570.1577.1579.1583.1584.1591.1603.1616.1638.1651.1653.1665.1667.1677.1678.1682.1697.1699.1703.1712.1716.1721.1722.1725.1732.1745.1750.1765.1769.1782.1786.1800.1808.1810.1825.1827.1832.1837.1838.1840.1842.1843.1845.1859.1866.1870.1878.1880.1889.1899.1917.1929.1942.1944.1962.1963.1964.1967.1968.1969.1978.2003.2007.2008.2027.2035.2039.2044.2046.2047.2052.2056.2064.2068.2070.2072.2074.2088.2090.2103.2107.2109.2115.2124.2130.2133.2137.2140.2145.2147.2150.2156.2166.2177.2179.2183.2186.2202.2205.2216.2219.2220.2222.2225.2234.2253.2264.2279.2282.2292.2299.2305.2309.2312.2316.2322.2325.2328.2331.2334.2335.2336.2337.2343.2354.2357.2358.2359.2366.2370.2376.2377.2387.2392.2394.2400.2403.2405.2407.2411.2414.2416.2418.2425.2427.2440.2447.2459.2461.2462.2465.2468.2472.2477.2481.2484.2486.2488.2492.2493.2496.2497.2498.2499.2501.2510.2511.2517.2526.2527.2532.2534.2535.2542.2544.2552.2563.2564.2567.2568.2569.2571.2572.2575.2577.2583.2584.2589.2595.2596.2601.2604.2605.2608.2609.2610.2612.2614.2621.2628.2629.2633.2634.2636.2642.2643.2645.2646.2647.2650.2651.2652.2656.2657.2658.2660.2661.2669.2670.2677.2681.2684.2686.2687.2690.2695.2698.2707.2713.2714.2729.2739.2767.2768.2770.2771.2772.2784.2787.2791.2792.2798.2801.2805.2812.2813.2816.2817.2818.2821.2822.2827.2830.2831.2834.2836.2838.2839.2840.2844.2846.2847.2849.2850.2851.2852.2854.2856.2860.2862.2863.2865.2867.2869.2873.2874.2875.2876.2878.2879.2880.2881.2882.2883.2884.2886.2887.2888.2889.2891.2893.2894.2895.2897.2898.2900.2901.2908.2909.2911.2912.2913.2914.2916.2917.2918.2919.2920.2922.2923.2924.2927.2929.2930.2931.2939.2940.2941.2942.2947.2949.2950.2956.2961.2962.2963.2964.2965.2966.2968.2970.2973.2974.2975.2979.2980.2981.2983.2985.2986.2987.2991.2993.2994.2995.2997.2999.3000.3002.3003.3005.3008.3009.3010.3012.3016.3017.3018.3019.3024.3025.3028.3034.3037.3038.3043.3044.3045.3048.3052.3053.3055.3058.3059.3063.3065.3066.3068.3070.3072.3073.3074.3075.3076.3077.3078.3089.3090.3093.3094.3095.3097.3099.3100.3104.3106.3109.3111.3112.3116.3117.3118.3119.3120.3121.3124.3126.3127.3128.3130.3135.3136.3145.3149.3150.3151.3154.3155.3159.3162.3163.3167.3172.3173.3180.3182.3183.3184.3185.3187.3188.3189.3190.3194.3196.3197.3209.3210.3211.3214.3215.3217.3219.3222.3223.3225.3226.3227.3228.3230.3231.3232.3234.3235.3236.3237.3238.3240.3241.3244.3245.3250.3251.3253.3257.3260.3268.3281"
            }
        }
    },
    "regs": {
        "ext": {
            "gdpr": 1,
            "us_privacy": "1---"
        }
    }
}```

HTTP Response:

{
"id": "1cea8058-fd27-402f-969e-6e01dd558a58",
"ext": {
"debug": {
"httpcalls": {
"improvedigital": [
{
"uri": "http://ad.360yield.com/pbs",
"requestbody": "{"id":"1cea8058-fd27-402f-969e-6e01dd558a58","imp":[{"id":"ax-skin","banner":{"format":[{"w":5,"h":5}]},"ext":{"bidder":{"placementId":22592087,"keyValues":{"hb":["true"],"pbct":["2"]},"bidFloor":0.0113,"bidFloorCur":"USD"}}}],"site":{"page":"https://deluxemusic.de/\",\"publisher\":{\"id\":\"1\"},\"ext\":{\"amp\":0}},\"device\":{\"ua\":\"PostmanRuntime/7.28.4\",\"h\":980,\"w\":630},\"user\":{\"buyeruid\":\"5cd26de0-60ab-4302-8fd2-cad96fe07270\",\"ext\":{\"consent\":\"CPP6vO1PP6vO1AKAkADEB2CsAP_AAH_AAAYgIXtf_X__bX9j-_59f_t0eY1P9_r3v-QzjhfNt-8F2L_W_L0X42E7NF36pq4KuR4Eu3LBIQNlHMHUTUmwaokVrzHsak2cpyNKJ7LEmnMZO2dYGHtPn9lTuZKY7_78__fz3j-v_t_-39T378X_3_d5_Wu--_O_V399zLv9____39nP___9v-_9-CF4BJhqXkAXZljgybRpVCiBGFYSFQCgAooBhaIrABgcFOysAj1hCwAQmoCMCIEGIKMGAQACCQBIREBIAWCARAEQCAAEAKEBCAAiYBBYAWBgEAAoBoWIEUAQgSEGRwVHKYEBUi0UEtlYAlBXsaYQBlvgRQKL6KjARrNECwMhIWDmOAJAS8WSB5gAAAAA.f_gAAAAAAAAA\",\"eids\":[{\"source\":\"criteo.com\",\"uids\":[{\"id\":\"5Vejl18lMkJNVG9adGg4blcwV3hIWUklMkZWSmY0TzBWRDhhdXVhak5Hck1La1dEemQwYm5DYW41TDNlamVRZHhJdjFKREtKbWhyZlRHRnRNR1lBRVVOOWlMcU5pZE9XckhDN1NmYVElMkZPRFNmOHBLd0RPam83SHVHUkdvaTNQaGh5JTJGJTJCSGNYOTE\",\"atype\":1}]},{\"source\":\"id5-sync.com\",\"uids\":[{\"id\":\"ID5*rGWcLf3suIbuIVL4knDej5pof3cUIBzaTQY-D0mxAdMABgnF4xTwigQ4vchgXkA5AAy_SRruImMkIWEw_7cPwAAScMeS8UmQCr8hg5ySIA8AGJ6KypWholVlRHRgofVSAB7q5w4WsyI-NQM9q3giUQAkRHusKg59gYt9sgrI3HkAKmSOdpKVqPyGs4wd19r8ADDAydWTN1xmbl7hCR64FAA2GbiH916AZcbbHS-JuEYANxgT4wvXYhaVj3djNoNlADvXpoAhiHgadvcBgI0ghgA8McZnWpJCUc7Z4fsAG30AQuEl6WoX2aHlW0V57aspAEg_KvZ_djs90evwLKp4FABOGAVDn2rWKFDpruYgDTAAVNiyiuiK1M6FFr2aK3WmAFnq2h5481LJ_eODelEM5QBa3v6cKS5Bp12IB8VLsv0AYIVGfUciCA_cRzvUZDDLAGbDTvOtIjrtJWPcTJsMbABs6pVcTiRg7oqxBzwzC7EAcu6cX9nRhXytghQ_CMihAHjtBrlW9mCWlhoAwKRvtwB-2iBvhBHaEFSRrmj4OocAhAFrWdu8UiPRWPEPJg5bAIqHeKWUDujygUrdvI5mTw\",\"atype\":1,\"ext\":{\"linkType\":2}}]},{\"source\":\"crwdcntrl.net\",\"uids\":[{\"id\":\"410cfa577bbdce99a40cba1cb6374945a702ea8e971d4c9ec45c52a0e0002d81\",\"atype\":1}]},{\"source\":\"pubcid.org\",\"uids\":[{\"id\":\"f0dc0a55-6ea5-4345-8786-293addaa3a7d\",\"atype\":1}]}],\"consented_providers_settings\":{\"consented_providers\":[39,43,46,55,61,66,70,83,89,93,108,117,122,124,131,135,136,143,144,147,149,159,162,167,171,192,196,202,211,218,228,230,239,241,253,259,266,272,286,291,311,317,322,323,326,327,338,367,371,385,389,394,397,407,413,415,424,430,436,440,445,449,453,482,486,491,494,495,501,503,505,522,523,540,550,559,560,568,574,576,584,587,591,733,737,745,780,787,802,803,817,820,821,829,839,864,867,874,899,904,922,931,938,979,981,985,1003,1024,1027,1031,1033,1034,1040,1046,1051,1053,1067,1085,1092,1095,1097,1099,1107,1127,1135,1143,1149,1152,1162,1166,1186,1188,1192,1201,1205,1211,1215,1226,1227,1230,1252,1268,1270,1276,1284,1286,1290,1301,1307,1312,1329,1345,1356,1364,1365,1375,1403,1415,1416,1419,1440,1442,1449,1455,1456,1465,1495,1512,1516,1525,1540,1548,1555,1558,1564,1570,1577,1579,1583,1584,1591,1603,1616,1638,1651,1653,1665,1667,1677,1678,1682,1697,1699,1703,1712,1716,1721,1722,1725,1732,1745,1750,1765,1769,1782,1786,1800,1808,1810,1825,1827,1832,1837,1838,1840,1842,1843,1845,1859,1866,1870,1878,1880,1889,1899,1917,1929,1942,1944,1962,1963,1964,1967,1968,1969,1978,2003,2007,2008,2027,2035,2039,2044,2046,2047,2052,2056,2064,2068,2070,2072,2074,2088,2090,2103,2107,2109,2115,2124,2130,2133,2137,2140,2145,2147,2150,2156,2166,2177,2179,2183,2186,2202,2205,2216,2219,2220,2222,2225,2234,2253,2264,2279,2282,2292,2299,2305,2309,2312,2316,2322,2325,2328,2331,2334,2335,2336,2337,2343,2354,2357,2358,2359,2366,2370,2376,2377,2387,2392,2394,2400,2403,2405,2407,2411,2414,2416,2418,2425,2427,2440,2447,2459,2461,2462,2465,2468,2472,2477,2481,2484,2486,2488,2492,2493,2496,2497,2498,2499,2501,2510,2511,2517,2526,2527,2532,2534,2535,2542,2544,2552,2563,2564,2567,2568,2569,2571,2572,2575,2577,2583,2584,2589,2595,2596,2601,2604,2605,2608,2609,2610,2612,2614,2621,2628,2629,2633,2634,2636,2642,2643,2645,2646,2647,2650,2651,2652,2656,2657,2658,2660,2661,2669,2670,2677,2681,2684,2686,2687,2690,2695,2698,2707,2713,2714,2729,2739,2767,2768,2770,2771,2772,2784,2787,2791,2792,2798,2801,2805,2812,2813,2816,2817,2818,2821,2822,2827,2830,2831,2834,2836,2838,2839,2840,2844,2846,2847,2849,2850,2851,2852,2854,2856,2860,2862,2863,2865,2867,2869,2873,2874,2875,2876,2878,2879,2880,2881,2882,2883,2884,2886,2887,2888,2889,2891,2893,2894,2895,2897,2898,2900,2901,2908,2909,2911,2912,2913,2914,2916,2917,2918,2919,2920,2922,2923,2924,2927,2929,2930,2931,2939,2940,2941,2942,2947,2949,2950,2956,2961,2962,2963,2964,2965,2966,2968,2970,2973,2974,2975,2979,2980,2981,2983,2985,2986,2987,2991,2993,2994,2995,2997,2999,3000,3002,3003,3005,3008,3009,3010,3012,3016,3017,3018,3019,3024,3025,3028,3034,3037,3038,3043,3044,3045,3048,3052,3053,3055,3058,3059,3063,3065,3066,3068,3070,3072,3073,3074,3075,3076,3077,3078,3089,3090,3093,3094,3095,3097,3099,3100,3104,3106,3109,3111,3112,3116,3117,3118,3119,3120,3121,3124,3126,3127,3128,3130,3135,3136,3145,3149,3150,3151,3154,3155,3159,3162,3163,3167,3172,3173,3180,3182,3183,3184,3185,3187,3188,3189,3190,3194,3196,3197,3209,3210,3211,3214,3215,3217,3219,3222,3223,3225,3226,3227,3228,3230,3231,3232,3234,3235,3236,3237,3238,3240,3241,3244,3245,3250,3251,3253,3257,3260,3268,3281]}}},\"test\":1,\"at\":1,\"tmax\":20000,\"cur\":[\"EUR\"],\"source\":{\"tid\":\"1cea8058-fd27-402f-969e-6e01dd558a58\",\"ext\":{\"schain\":{\"ver\":\"1.0\",\"complete\":1,\"nodes\":[{\"asi\":\"headerlift.com\",\"hp\":1,\"sid\":\"12972\"}]}}},\"regs\":{\"ext\":{\"gdpr\":1,\"us_privacy\":\"1---\"}},\"ext\":{\"prebid\":{\"channel\":{\"name\":\"pbjs\",\"version\":\"v5.14.0\"},\"targeting\":{\"pricegranularity\":{\"precision\":2,\"ranges\":[{\"min\":0,\"max\":20,\"increment\":0.1}]},\"includewinners\":true,\"includebidderkeys\":false,\"includebrandcategory\":null,\"includeformat\":false,\"durationrangesec\":null,\"preferdeals\":false}}}}",
"requestheaders": {
"Content-Type": [
"application/json;charset=utf-8"
],
"X-Prebid": [
"pbs-go/unknown,pbjs/v5.14.0"
]
},
"responsebody": "",
"status": 204
}
]
},
"resolvedrequest": {
"id": "1cea8058-fd27-402f-969e-6e01dd558a58",
"imp": [
{
"id": "ax-skin",
"banner": {
"format": [
{
"w": 5,
"h": 5
}
]
},
"ext": {
"improvedigital": {
"placementId": 22592087,
"keyValues": {
"hb": [
"true"
],
"pbct": [
"2"
]
},
"bidFloor": 0.0113,
"bidFloorCur": "USD"
}
}
}
],
"site": {
"page": "https://deluxemusic.de/",
"publisher": {
"id": "1"
},
"ext": {
"amp": 0
}
},
"device": {
"ua": "PostmanRuntime/7.28.4",
"h": 980,
"w": 630
},
"user": {
"ext": {
"eids": [
{
"source": "criteo.com",
"uids": [
{
"id": "5Vejl18lMkJNVG9adGg4blcwV3hIWUklMkZWSmY0TzBWRDhhdXVhak5Hck1La1dEemQwYm5DYW41TDNlamVRZHhJdjFKREtKbWhyZlRHRnRNR1lBRVVOOWlMcU5pZE9XckhDN1NmYVElMkZPRFNmOHBLd0RPam83SHVHUkdvaTNQaGh5JTJGJTJCSGNYOTE",
"atype": 1
}
]
},
{
"source": "id5-sync.com",
"uids": [
{
"id": "ID5*rGWcLf3suIbuIVL4knDej5pof3cUIBzaTQY-D0mxAdMABgnF4xTwigQ4vchgXkA5AAy_SRruImMkIWEw_7cPwAAScMeS8UmQCr8hg5ySIA8AGJ6KypWholVlRHRgofVSAB7q5w4WsyI-NQM9q3giUQAkRHusKg59gYt9sgrI3HkAKmSOdpKVqPyGs4wd19r8ADDAydWTN1xmbl7hCR64FAA2GbiH916AZcbbHS-JuEYANxgT4wvXYhaVj3djNoNlADvXpoAhiHgadvcBgI0ghgA8McZnWpJCUc7Z4fsAG30AQuEl6WoX2aHlW0V57aspAEg_KvZ_djs90evwLKp4FABOGAVDn2rWKFDpruYgDTAAVNiyiuiK1M6FFr2aK3WmAFnq2h5481LJ_eODelEM5QBa3v6cKS5Bp12IB8VLsv0AYIVGfUciCA_cRzvUZDDLAGbDTvOtIjrtJWPcTJsMbABs6pVcTiRg7oqxBzwzC7EAcu6cX9nRhXytghQ_CMihAHjtBrlW9mCWlhoAwKRvtwB-2iBvhBHaEFSRrmj4OocAhAFrWdu8UiPRWPEPJg5bAIqHeKWUDujygUrdvI5mTw",
"atype": 1,
"ext": {
"linkType": 2
}
}
]
},
{
"source": "crwdcntrl.net",
"uids": [
{
"id": "410cfa577bbdce99a40cba1cb6374945a702ea8e971d4c9ec45c52a0e0002d81",
"atype": 1
}
]
},
{
"source": "pubcid.org",
"uids": [
{
"id": "f0dc0a55-6ea5-4345-8786-293addaa3a7d",
"atype": 1
}
]
}
],
"consent": "CPP6vO1PP6vO1AKAkADEB2CsAP_AAH_AAAYgIXtf_X__bX9j-59f_t0eY1P9_r3v-QzjhfNt-8F2L_W_L0X42E7NF36pq4KuR4Eu3LBIQNlHMHUTUmwaokVrzHsak2cpyNKJ7LEmnMZO2dYGHtPn9lTuZKY7_78__fz3j-v_t-39T378X_3_d5_Wu--_O_V399zLv9____39nP___9v-_9-CF4BJhqXkAXZljgybRpVCiBGFYSFQCgAooBhaIrABgcFOysAj1hCwAQmoCMCIEGIKMGAQACCQBIREBIAWCARAEQCAAEAKEBCAAiYBBYAWBgEAAoBoWIEUAQgSEGRwVHKYEBUi0UEtlYAlBXsaYQBlvgRQKL6KjARrNECwMhIWDmOAJAS8WSB5gAAAAA.f_gAAAAAAAAA",
"ConsentedProvidersSettings": {
"consented_providers": "1~<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>9.266.272.286.291.311.317.322.323.326.327.338.367.371.385.389.394.397.407.413.415.424.430.436.440.445.449.453.482.486.491.494.495.501.503.505.522.523.540.550.559.560.568.574.576.584.587.591.733.737.745.780.787.802.803.817.820.821.829.839.864.867.874.899.904.922.931.938.979.981.985.1003.1024.1027.1031.1033.1034.1040.1046.1051.1053.1067.1085.1092.1095.1097.1099.1107.1127.1135.1143.1149.1152.1162.1166.1186.1188.1192.1201.1205.1211.1215.1226.1227.1230.1252.1268.1270.1276.1284.1286.1290.1301.1307.1312.1329.1345.1356.1364.1365.1375.1403.1415.1416.1419.1440.1442.1449.1455.1456.1465.1495.1512.1516.1525.1540.1548.1555.1558.1564.1570.1577.1579.1583.1584.1591.1603.1616.1638.1651.1653.1665.1667.1677.1678.1682.1697.1699.1703.1712.1716.1721.1722.1725.1732.1745.1750.1765.1769.1782.1786.1800.1808.1810.1825.1827.1832.1837.1838.1840.1842.1843.1845.1859.1866.1870.1878.1880.1889.1899.1917.1929.1942.1944.1962.1963.1964.1967.1968.1969.1978.2003.2007.2008.2027.2035.2039.2044.2046.2047.2052.2056.2064.2068.2070.2072.2074.2088.2090.2103.2107.2109.2115.2124.2130.2133.2137.2140.2145.2147.2150.2156.2166.2177.2179.2183.2186.2202.2205.2216.2219.2220.2222.2225.2234.2253.2264.2279.2282.2292.2299.2305.2309.2312.2316.2322.2325.2328.2331.2334.2335.2336.2337.2343.2354.2357.2358.2359.2366.2370.2376.2377.2387.2392.2394.2400.2403.2405.2407.2411.2414.2416.2418.2425.2427.2440.2447.2459.2461.2462.2465.2468.2472.2477.2481.2484.2486.2488.2492.2493.2496.2497.2498.2499.2501.2510.2511.2517.2526.2527.2532.2534.2535.2542.2544.2552.2563.2564.2567.2568.2569.2571.2572.2575.2577.2583.2584.2589.2595.2596.2601.2604.2605.2608.2609.2610.2612.2614.2621.2628.2629.2633.2634.2636.2642.2643.2645.2646.2647.2650.2651.2652.2656.2657.2658.2660.2661.2669.2670.2677.2681.2684.2686.2687.2690.2695.2698.2707.2713.2714.2729.2739.2767.2768.2770.2771.2772.2784.2787.2791.2792.2798.2801.2805.2812.2813.2816.2817.2818.2821.2822.2827.2830.2831.2834.2836.2838.2839.2840.2844.2846.2847.2849.2850.2851.2852.2854.2856.2860.2862.2863.2865.2867.2869.2873.2874.2875.2876.2878.2879.2880.2881.2882.2883.2884.2886.2887.2888.2889.2891.2893.2894.2895.2897.2898.2900.2901.2908.2909.2911.2912.2913.2914.2916.2917.2918.2919.2920.2922.2923.2924.2927.2929.2930.2931.2939.2940.2941.2942.2947.2949.2950.2956.2961.2962.2963.2964.2965.2966.2968.2970.2973.2974.2975.2979.2980.2981.2983.2985.2986.2987.2991.2993.2994.2995.2997.2999.3000.3002.3003.3005.3008.3009.3010.3012.3016.3017.3018.3019.3024.3025.3028.3034.3037.3038.3043.3044.3045.3048.3052.3053.3055.3058.3059.3063.3065.3066.3068.3070.3072.3073.3074.3075.3076.3077.3078.3089.3090.3093.3094.3095.3097.3099.3100.3104.3106.3109.3111.3112.3116.3117.3118.3119.3120.3121.3124.3126.3127.3128.3130.3135.3136.3145.3149.3150.3151.3154.3155.3159.3162.3163.3167.3172.3173.3180.3182.3183.3184.3185.3187.3188.3189.3190.3194.3196.3197.3209.3210.3211.3214.3215.3217.3219.3222.3223.3225.3226.3227.3228.3230.3231.3232.3234.3235.3236.3237.3238.3240.3241.3244.3245.3250.3251.3253.3257.3260.3268.3281"
}
}
},
"test": 1,
"at": 1,
"tmax": 20000,
"cur": [
"EUR"
],
"source": {
"tid": "1cea8058-fd27-402f-969e-6e01dd558a58",
"ext": {
"schain": {
"ver": "1.0",
"complete": 1,
"nodes": [
{
"asi": "headerlift.com",
"hp": 1,
"sid": "12972"
}
]
}
}
},
"regs": {
"ext": {
"gdpr": 1,
"us_privacy": "1---"
}
},
"ext": {
"prebid": {
"channel": {
"name": "pbjs",
"version": "v5.14.0"
},
"targeting": {
"pricegranularity": {
"precision": 2,
"ranges": [
{
"min": 0,
"max": 20,
"increment": 0.1
}
]
},
"includewinners": true,
"includebidderkeys": false,
"includebrandcategory": null,
"includeformat": false,
"durationrangesec": null,
"preferdeals": false
}
}
}
}
},
"responsetimemillis": {
"improvedigital": 3756
},
"tmaxrequest": 20000,
"prebid": {
"auctiontimestamp":<PHONE_NUMBER>806
}
}
}

While I trying to debug, I found it actually send request to pds (http://ad.360yield.com/pbs) server but got 204 response from server. please take a look at screenshot https://paste.pics/2f00de0953d09d248be808446fd76fee

@jbartek25
Code update as you suggested. Removed UserExtReq, UserExtRes struct and just consented_providers key.


Execute read-only chain operations concurrently

Motivation
The ChainWorkerActor handles one request at a time. However, many of the requests don't change the chain (or rather, rolls back the changes after it has finished). That means that these "read-only" operations could be executed concurrently.
Proposal
Use ClonableView::clone_unchecked to create temporary clones of the ChainStateView and spawn tasks for each read-only worker operation.

Is it correct to say that this only matters on clients running a service (or if validators execute oracle calls to the service) ?


Techdebt: Mypy DataSync

Codecov Report

Merging #5756 (ef54d81) into master (56335e2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5756   +/-   ##
=======================================
  Coverage   96.19%   96.19%
=======================================
  Files         751      751
  Lines       73629    73631    +2
=======================================
+ Hits        70830    70832    +2
  Misses       2799     2799

Flag
Coverage Δ

servertests
36.93% <51.28%> (+<0.01%)
:arrow_up:

unittests
96.13% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/datasync/exceptions.py
100.00% <100.00%> (ø)

moto/datasync/models.py
95.86% <100.00%> (+0.03%)
:arrow_up:

moto/datasync/responses.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[semantic-sil] Copy DIMemoryUseCollector.{cpp,h} => DIMemoryUseCollectorOwnership.{cpp,h} so I can update the passes that use this functionality one at a time.

[semantic-sil] Copy DIMemoryUseCollector.{cpp,h} => DIMemoryUseCollectorOwnership.{cpp,h} so I can update the passes that use this functionality one at a time.
rdar://31521023

@swift-ci smoke test and merge


docs: fix link to the latest release in readme

:tada: This PR is included in version 2.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Remove compose watcher

Only causes problems, maybe also archive repo

remove mappings from readme
disable hook in github


Add Screenshot to readme/meta

I cleaned up my "test suite" a little bit and made 2 screenshots that would serve well as example in the repos readme (and meta-file).
Would it be ok for you if I added the monospace version to my upcoming 0.3-PR?

Let’s get rid of the monospace-declaration and use the second screenshot it you want :·)

Let’s get rid of the monospace-declaration and use the second screenshot it you want :·)

Second screenshot added - thank you!

https://github.com/animaux/simplemde/releases/tag/0.3


Hospot is overlapping with control UI

I find out that Control UI is being overlapped by hotspots

I came out with solution as well

panellum-container should instead have these 2 div in this order

pnlm-render-container
pnlm-ui

remove z-index of plnm-ui

As for now I override the css with this
div.pnlm-ui {
  z-index: auto;
  .pnlm-dragfix {
    z-index: 1
  }
  .pnlm-controls-container {
    z-index: 2
  }
}

Thanks for figuring this out! I noticed this issue last month, but my brief attempt at fixing it (ab423f66ea36e46d92d109e559818a0685971006) was unsuccessful.

@mpetroff: Could a test be added to prevent this from happening again? Like an emulated drag/click on the hotspot to check whether the click "goes through"?

So while my first attempt at a fix didn't work, my second one (5f0a1d8662272cae87ad23d367ab041ca3a2d34a) did. I had forgotten about that. I just reverted the additional changes made in 7362f5c948e17370a9368ccc23895dd8a1e16668, since they aren't necessary in my testing.
@tokidoki11 Can you confirm that you don't see this issue in the current Git master branch? If you do still see the issue, please report the browser, browser version, and OS.
@strarsis Good idea! I added an additional unit test to check for this in 74b83191928fb0b39fb2888adb7be1f5daad1d0a.

I hope it's okay to add this here, but I came across a very similar issue.
when a hotspot is clicked and its content is showing, it is overlapped by other hotspots.
one solution could be to have an active class on the clicked hotspot to give him a stronger z-index.
I tried to do it but my skills are limited and I can not find a way to do it.

I did find a way, I think this is far from being a nice solution but it works
var zindex = 10; function overlap(arg) {   $(arg.toElement).css('z-index',zindex);   zindex++; }
And i call this function in the hotSpots arguments of my viewer
"hotSpots": [   {     'pitch':pitch,     'yaw':yaw,     'type':type,     'text':$.trim(text.replace(/[\t\n]+/g,' ')),     'clickHandlerFunc': overlap   },   {     'pitch':pitch,     'yaw':yaw,     'type':type,     'text':$.trim(text.replace(/[\t\n]+/g,' ')),     'clickHandlerFunc': overlap   } ]


is it possible to customize the themes?

I want to set a few settings differently; such as using the cursor theme for the 'continue' list. I am unable to figure out how  though.

Would you like to customize the Telescope theme? If so, I want the same.
Here it is with telescope-dap.nvim. The height of the frame grows to full screen.

And here it is without—a centered dropdown that's much smaller.

I tried to send opts in like this. I was able to get it to look like so. But, still not the more straightforward drop-down I showed above.
require'telescope'.extensions.dap.configurations({ layout_strategy = 'center', layout_config = { height = 20, width = 100, prompt_position = 'top', preview_cutoff = 5000 } })

Hello @wassimk, it looks like you are using dressing.nvim which already replaces the default internal dap ui by overwriting vim.ui.select. My solution to get the straight forward drop-down would be to disable overwriting the internal ui: https://github.com/nvim-telescope/telescope-dap.nvim/pull/19


[BUG]: Vulnerability in healenium proxy

Describe the bug
Below are the vulnrabilites in hlm -proxy image
https://nvd.nist.gov/vuln/detail/CVE-2019-0190
https://nvd.nist.gov/vuln/detail/CVE-2023-44794

How to reproduce the issue
Below are the vulnrabilites in hlm -proxy image
https://nvd.nist.gov/vuln/detail/CVE-2019-0190
https://nvd.nist.gov/vuln/detail/CVE-2023-44794

Logs appeared during using Healenium
Below are the vulnrabilites in hlm -proxy image
https://nvd.nist.gov/vuln/detail/CVE-2019-0190
https://nvd.nist.gov/vuln/detail/CVE-2023-44794

Expected behavior
No response
Actual behavior
No response
Healenium Backend version
NA
Selenium version
NA
Platform
NA
Additional context
No response

any updates on this


NIFI-7127 - Allow choosing a SecureHasher implementation with NiFi co…

…nfiguration for FingerPrint checks. Defaults to Argon2.
NIFI-7127 - Moved StandardSensitiveValueEncoder SecretKeySpec to constructor from getEncoded(). Other small fixes.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Updated with changes as per review. Thanks, David!


Updates to support zone

Fixes #33

Coverage remained the same at 82.621% when pulling f4a8d04a18aba6d1df06463d7e57595ce1724ac6 on tswaters:issue-33 into 3deff60b671ad56590b93efd15da0003995e0aa8 on senecajs:master.

LGTM 👍


Failed to install DPythonModular on Ubuntu 14.04

I have Ubuntu 14.04
swig 2.0.11
gcc 4.8.4
python 2.7.11
numpy 1.10.4
I ran cmake -DPythonModular=ON .. and I get this at the end
-- Configuring done
-- Generating done
-- Build files have been written to: /home/youssef/shogun/build

Then I ran make but it fails at 86%
[ 86%] Built target libshogun
Scanning dependencies of target shogun
Linking CXX shared library libshogun.so
[ 86%] Built target shogun
Scanning dependencies of target python_modular_src
[ 86%] copying SWIG files
[ 86%] Built target python_modular_src
[ 86%] Swig source
/home/youssef/shogun/src/shogun/mathematics/linalg/ratapprox/opfunc/RationalApproximation.h:63: Warning 401: Nothing known about base class 'COperatorFunction< float64_t >'. Ignored.
/home/youssef/shogun/src/shogun/mathematics/linalg/ratapprox/opfunc/RationalApproximation.h:63: Warning 401: Maybe you forgot to instantiate 'COperatorFunction< float64_t >' using %template.
/home/youssef/shogun/src/shogun/kernel/BesselKernel.h:34: Warning 401: Base class 'CDistanceKernel' undefined.
/home/youssef/shogun/src/shogun/kernel/DistanceKernel.h:33: Warning 401: 'CDistanceKernel' must be defined before it is used as a base class.
Scanning dependencies of target _python_modular
[ 86%] Building CXX object src/interfaces/python_modular/CMakeFiles/_python_modular.dir/modshogunPYTHON_wrap.cxx.o
In file included from /home/youssef/miniconda2/lib/python2.7/site-packages/numpy/core/include/numpy/ndarraytypes.h:1781:0,
                 from /home/youssef/miniconda2/lib/python2.7/site-packages/numpy/core/include/numpy/ndarrayobject.h:18,
                 from /home/youssef/miniconda2/lib/python2.7/site-packages/numpy/core/include/numpy/arrayobject.h:4,
                 from /home/youssef/shogun/build/src/interfaces/python_modular/modshogunPYTHON_wrap.cxx:6139:
/home/youssef/miniconda2/lib/python2.7/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:15:2: warning: #warning "Using deprecated NumPy API, disable it by " "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
 #warning "Using deprecated NumPy API, disable it by " \
  ^
cc1plus: warning: unrecognized command line option "-Wno-c++11-narrowing" [enabled by default]
[ 86%] Building CXX object src/interfaces/python_modular/CMakeFiles/_python_modular.dir/sg_print_functions.cpp.o
Linking CXX shared module _modshogun.so
/usr/bin/ld: /usr/local/lib/libpython2.7.a(abstract.o): relocation R_X86_64_32S against `_Py_NotImplementedStruct' can not be used when making a shared object; recompile with -fPIC
/usr/local/lib/libpython2.7.a: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
make[2]: *** [src/interfaces/python_modular/_modshogun.so] Error 1
make[1]: *** [src/interfaces/python_modular/CMakeFiles/_python_modular.dir/all] Error 2
make: *** [all] Error 2

I am not sure about this error, but as a general thing I'd recommend newer swig.

No, the problem is:  He's trying to link against a static python-lib, which is not compiled to link into dynamic-so...
Am 20.02.2016 19:27 schrieb Sergey Lisitsyn notifications@github.com:I am not sure about this error, but as a general thing I'd recommend newer swig.
—Reply to this email directly or view it on GitHub.

@lisitsyn  I used swig 3.0.2 and nothing changed
@besser82 so what can I do to solve the issue ?

@besser82 I believe you are right and I found similar problems to mine in other libraries  but I can't find an appropriate solution so can you help me with that ?

Thanks to Gamal ElKomy from the mailing list , The solution is that the directory of everything needed should be specified in the cmake command
cmake command should be
cmake -DPythonModular=ON -DPYTHON_EXECUTABLE=/usr/bin/python2.7 -DPYTHON_INCLUDE_DIR=/usr/include/python2.7 -DPYTHON_LIBRARY=/usr/lib/x86_64-linux-gnu/libpython2.7.so.1  -DPYTHON_PACKAGES_PATH=/usr/local/lib/python2.7/dist-packages ..


Multi-OS Support; hidden password input

I have changed the clear terminal command to a function depending on OS (I would appreciate if Windows could be tested).
Using the getpass module, password inputs are now hidden from the screen (will only work running via the terminal, not shell).
Changed some 'if !=' statements to 'if not'
General file reformat for spacing and readibility

Hi, Lewis
kindly made the requested changes so, I can merge your pull request

Hello,
Thanks for your patience and review; I have been on holiday. I made the changes as per suggestion. Please take a moment to review

Thank you Lewis for your contribution to this repository. I'm glad to merge your pull request


Implement train in chunks for Core

related to #6836
If we train in chunks we need to train the policies one by one.
For every policy, read x number of stored DialogueStateTrackers from disk. We know how many DialogueStateTrackers we have and how much chunks we want to use, so we can calculate x.
Train the policy using the current data chunk.
After training is finished, save the policy to disk (if needed).

closing this issue because it's a duplicate


Some question about similarity_combo?

Thank u for your job. it helps a lot. I have ran the Deep-Image-Analogy on linux sucessfully. but i met some problems when do as your advises like
@TruePhone The Similarity SubNet (and Deep Image Analogy if you use it to build correspondence) is implemented in C++. It should be easy to transplant to Linux. Deep Image Analogy already has a Linux version (https://github.com/msracver/Deep-Image-Analogy/tree/linux) and our Similarity SubNet is actually built based on it. You may copy the source code from Deep-Exemplar-based-Colorization/similarity_subnet/windows/similarity_combo/ to msracver/Deep-Image-Analogy/tree/linux and slightly modify it on Linux.
but when i compile, it missing some files.h like windows.h . sorry, i am not familiar with c++ in windows. can u give me some advises to get similarity_combo file in linux?

@xuzhongyou Yes, that's a problem. We have to do some modification before compiling the code on Linux. We will do it soon. Thanks for your suggestion.

Did you ever get round to getting this working in Linux

not yet

Did you ever get round to getting this working in Linux

not yet


adding a new biom and reference for analysis

Here I'm adding a new reference (silva) and a new biom so we can start working on multiple analysis.
Additionally from adding those lines, fixing tests and a file:

Had to modify tree_fp in reference so it returns an empty string when the tree doesn't exist.
Change rename_dup_samples from or to and in build_files so it behaves as expected. This line is going to change once the rest of the code is there.

Note that this doesn't change anything in the front end or current status, thus, doing a PR against master.

@antgonza there are test failures here. I think those failures are related with your changes to populate_test_db.sql, not to your new functionality, so I'm going to review while you fix those tests.

Thanks @antgonza - few comments.
We really need to move away from having hard-coded id's in the tests. Ugh.

1 comment

:+1: @ElDeveloper @mortonjt able to review? Should be fast.


Simplify and improve staticIndexOf

This PR:

simplifies definition of staticIndexOf by unifying the type- and alias-based variants
improves the implementation

The failing test seems to be style-related


Encountering issues with @react-oauth/google 0.11.0 - given origin is not allowed

Hi,
I am using your library in my Next.js project and encountered the error "[GSI_LOGGER]: The given origin is not allowed for the given client ID" even though my Authorized JavaScript origins are correctly set up. The console also logs a "Failed to load resource: the server responded with a status of 403 ()" error.
Can you provide guidance or assistance in resolving this?
"@react-oauth/google": "^0.11.0",
import { GoogleOAuthProvider } from "@react-oauth/google";
import { GoogleLogin } from "@react-oauth/google";

<GoogleOAuthProvider clientId="CLIENT_ID.apps.googleusercontent.com">
<GoogleLogin
  onSuccess={credentialResponse => {
    console.log(credentialResponse);
  }}
  onError={() => {
    console.log('Login Failed');
  }}
  useOneTap
/>
</GoogleOAuthProvider>

Thank you

Hi
Make sure you are using the right client id
And configure you google console to allow localhost one without port and define it again localhost with the prt you are using

Yes, I have the correct one.
Authorized JavaScript origins:
http://localhost:3000
http://localhost
Authorized redirect URIs:
http://localhost:3000/api/auth/callback/google

Alright,
If you can provide codesanbox sample with the issue would be great, and will I will check later today


add amp-video example

this p-r adds amp-video html sample and assets required in the file. Slightly modified gulpfile.js to copy video files.

Lgtm if you fix the typo.

fixed typo and added HTTPS notice in Introduction. PTAL.


Setup with TLS using letsencrypt on a VPS

Excellent project! I have requestrepo running on a VPS and would like to add TLS support with letsencrypt. It looks like the backend project already has some logic to handle acme certificates. However, I am not sure how this works and would love some guidance.
A few questions:

Am I able to run the app on a subdomain? (e.g., oast.domain.com)
What records do I need to create on my DNS provider?
Do I need to manually create the letsencrypt certificate(s) and associate them to the app? Or does this happen automagically somehow?

Thanks in advance!

Self-closing since this is no longer needed.
I ended up purchasing a new TLD with namecheap, configured it as a nameserver, and the letsencrypt certificates were generated overnight for the web app and wildcard subdomains.
Thank you very much for creating and maintaining this awesome project!


[Feature] Add steps for cleaning up the Docker environment

Summary

Add steps to detail cleaning up the Docker environment (stop container, delete image).
Changes

This change would involve more text in the Readme generated in the third workflow.
The risk is minimal

Additional context

I worked up a PR since I already did the leg work (determining commands) for Docker on my local system.
PR #48

Additionally,
Would it make sense on the X-finish.md step to link to the MS Learn Introduction to Docker containers module?

@mjbear Thank you for submitting this PR! ✨

Would it make sense on the X-finish.md step to link to the MS Learn Introduction to Docker containers module?

I'll get this triaged for review, and the team can address this Q during their review 💛


identify: Expose API to update public addresses to the identify protocol

This PR exposes an IdentifyPublicAddresses object used from the users perspective to update (add or remove) the list of public addresses reported by the identify protocol.
In libp2p, the reported addresses are a list of listen and external addresses.
This ensures we can propagate both listen addresses and external addresses from substrate:

the current heuristic from Substrate is to "confirm" external addresses after we've seen 2 peers reporting the same external addresses
in this case, instead of adding a function to propagate the ExternalAddrConfirmed event through the layers of litep2p, Substrate will call identify_addr.add(..) after the confirmation mechanism
this keeps things simple atm and adds an API we can build upon for further extensions

Testing Done

Added an integration test with 2 litep2p nodes

Closes: https://github.com/paritytech/litep2p/issues/191
cc @paritytech/networking

The PR description and title don't match the PR now :)


Account Flag

What is the /Tmp/test.txt file contained in Demo? Is it contains eurekamediastore or how can i set to find blobs using domain

It's just a file with a few random container names :)

It's just a file with some random container names :)

It's just a file with some random storage account names =)


ConnectAsync

Hi guys, please, any idea why CrossInAppBilling.Current.ConnectAsync() Is raising an exception "Object reference not set to an instance of an object." in my Xamarin.Forms project? I went through README and I think I did everything correctly. Thanks!

Android or iOS?
If Android, I had a similar issue and it was related to the below code in my AssemblyInfo.cs file in the Android project.  Either delete or comment out the code and then everything worked.
#if DEBUG
    [Application(Debuggable=true)]
#else
    [Application(Debuggable=false)]
#endif

Hi, thanks for your reply (and yes, this is Android project). Unfortunately, it still doesn't work. As this is real beginning of the usage of this component (no passing productid or other specific stuff), some xamarin.forms issue maybe? Trying to create simple test project doing just this connectAsync, but no luck ;-( thanks for any hint!

Read: https://github.com/jamesmontemagno/InAppBillingPlugin#android-setup
You must be using a real device with google play services, your app needs to be in app store, version must match, must have a version in alpha, and tons of other stuff in docs


Pico-8 and particle swarm optimization  (PSO)

There's actually a lot of ideas possible:

Herding sheep, so your maxima is outside, the particles are the sheep, and the placement of your dogs are your PSO constraints
Dogfighting? cursor controls where the ships go

Closing in favor of #244


Add mass to moveable component

Mass will be required to correctly calculate collisions and correct thrust.

What about center of mass?

Duplicate #24


Plugin not working in Godot 4.3

I have tested this plugin before like half a year ago and it was working just fine at the time. My Godot version back then was probably 4.2.
I just retried it in Godot 4.3 and I can't create roads. I have created a fresh project, downloaded the latest Godot 4.x version of the plugin and followed the instructions in the "Getting Started" guide. But all that I can see when adding road points is blue tiles:

Maybe this is some trivial mistake on my part? I double-checked the guide and watched the tutorial video and can't see what I am doing wrong.

I'll take a look at this more later, but I'm actually in the middle of making the first true alpha release for Godot 4.x, and have been testing via 4.3. Not everything is working yet, but it's mostly there vis the open pr (take note of the pr description):https://github.com/TheDuckCow/godot-road-generator/pull/190If you happen to try this branch, let me know if it works any better. I do suggest starting in a fresh scene to test, and definitely use the Roads menu > refresh roads button if ever unsure. On Sep 25, 2024 1:11 PM, Stefan Schätz @.***> wrote:
I have tested this plugin before like half a year ago and it was working just fine at the time. My Godot version back then was probably 4.2.
I just retried it in Godot 4.3 and I can't create roads. I have created a fresh project, downloaded the latest Godot 4.x version of the plugin and followed the instructions in the "Getting Started" guide. But all that I can see when adding road points is blue tiles:
image.png (view on web)
Maybe this is some trivial mistake on my part? I double-checked the guide and watched the tutorial video and can't see what I am doing wrong.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hi @schaetz the godot4 branch has been updated now, and should be fully functional based on my own testing. Let me know if it's working now, again being sure to restart the editor / reload the project after putting the node plugin code into place. Press refresh roads if needed. Worst case scenario, the scene and its roadpoint connections just got borqed and would need to be recreated in a fresh scene (or by manually clearing and re-assigning each prior/next point init, if the paths got corrupted).

Sorry for my late response! I have been busy last week.
Yup, I created a new project and it works fine now. :) Thanks for the fix!

I might have encountered another bug. Not sure if it is already a known issue. When I selected all nodes of my road at once by drawing a rectangle with my cursor, Godot crashed. There were about 30 nodes, I think. Could be both a Godot issue or an issue with this plugin.
If you want I can create a new ticket for it, however, I have not been able to reproduce it, yet.

Ok - thanks for letting me know. If it ever happens again, I would highly appreciate if you can create a new ticket for that, hopefully it was just an unlucky situation. Thanks for commenting back on the success otherwise!


Ability to compare two devices configuration

Is your feature request related to a problem? Please describe.
When adding a new device (with a lot of parameters), I want an easy way to compare the configuration of the new device with an existing one.
To illustrate, when I motorized my curtains, it takes me long time to find the good parameters for the first one. Then, when I motorized the second one, I cannot compare value of the new one, with the old one easily. (I took a sheet of paper, write everything for the reference, and then compare with the new one).
Describe the solution you'd like
In the control panel, if I select to devices with the same product code, it activates a "compare" button.
When I hit compare button, I have a screen showing me on left all the values of the first selected, on the right, all the values of the second selected.
Cherry on the cake, add the hability to modify configuration of the first or second one directly from this screen
Describe alternatives you've considered
Keep my sheet of paper and my pen :)

For such things there is a snippet that you can call from Advanced Dialog > Driver Function, it's called clone config and allows to copy configurations from a node to another, just edit it with the nodes ids of the source and targets :)

How great funtion. Thank's for the tip. Never search here ^^
What about a compare function ? It could be interesting for debugging. Sometimes, setting new value is not really taken (or all the values are not set), especially with battery device that need to be wake up.

What about a compare function ? It could be interesting for debugging

You can do what you want :)


Builds failing with cryptic message

I've got a bitbucket POST hooks setup so that my builds are automated. Of late any build that comes in via that (as opposed to a manual one) fails and all that ends up in the log box is:
Failed to clone remote git repository.
Exception: Could not create a working copy.

Running the build manually causes it to succeed.
I'm unable to find any further log information.

@cooperaj @sklerotraficon I assume you have managed to fix this (and/or it has been fixed in a subsequent release) ?


bump openshift plugins for various fixes

@openshift/devex FYI
@smunilla ptal - we'll need new 3.6 based RPMs built for these new versions of the openshift pipeline, client, and sync plugins

[merge][severity: bug]


[HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy

Change Logs
When we do conflict detecting on BUCKET index table, we check bucketId to see if there is a conflict, for partitioned table, if two client write different partition but same bucketId, there will be a conflict, actually this case should not have conflict.
This pr check partition+bucketId to see if there is a conflict.
Impact
none
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@hudi-bot run azure


Simplify dependencies

remove tools, pin golangci-lint version at test.sh
update x/crypto
use newer golangci-lint (the one used fails to compile on ARM macs)

thanks!


update sqlite3 version to 3320200

Update the sqlite3 to point to the latest sqlite distribution https://www.sqlite.org/releaselog/3_32_2.html.
The link to the sqlite source code from the original web site https://www.sqlite.org/2020/sqlite-autoconf-3320200.tar.gz

I see the ci/aooveyor/pr check fails due the job https://ci.appveyor.com/project/Mapbox/node-sqlite3/builds/33337967/job/ar6acf2ffqr67nir.
What can I do to overcome that failure?

Changed the sqlite distribution version to 3.32.1 that is considered stable version and is available in official aliline 3.12 repo.

Hi,
I will be releasing this ASAP (5.0.1).

Hi @kewde,
Thanks for your approval and intention to create a new release 5.0.1
I saw a new release for SQLite 3.32.3 https://www.sqlite.org/releaselog/3_32_3.html
Is the any chance to update the current PR to point to the latest SQLite release?

Let me know if I have time to make the change.

One more PR that points to the latest sqlite distribution 3.32.3

#1351


Steph test

Fixing a typo in ReadMe. Exciting stuff.

Coverage remained the same at 84.37% when pulling 919221691c5c8e2c95679beb3f1eb2e2654376f4 on steph-test into 02ed532cc78152ba0d5ddbc865b6e7947209bf97 on master.

:+1: :)


CommandComplete typo in decoder.

I'm guessing most people throw this value away. I know I use .void on commands heh.

Thanks, this was fixed by #130 which I just got around to merging.


Improve the code coverage of the gutil, grand module

Issue:https://github.com/gogf/gf/issues/1988

Codecov Report

Merging #1989 (fabbb8d) into master (384fb3c) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1989      +/-   ##
==========================================
+ Coverage   75.94%   76.06%   +0.11%
==========================================
  Files         512      511       -1
  Lines       46656    46414     -242
==========================================
- Hits        35435    35303     -132
+ Misses       9222     9141      -81
+ Partials     1999     1970      -29

Flag
Coverage Δ

go-1.15-386
?

go-1.15-amd64
76.06% <100.00%> (+0.19%)
:arrow_up:

go-1.16-386
?

go-1.16-amd64
?

go-1.17-386
?

go-1.17-amd64
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

util/grand/grand.go
97.50% <100.00%> (+25.05%)
:arrow_up:

contrib/registry/polaris/polaris_watcher.go
67.85% <0.00%> (-5.36%)
:arrow_down:

os/gfsnotify/gfsnotify_watcher_loop.go
78.15% <0.00%> (-5.05%)
:arrow_down:

net/gtcp/gtcp_pool.go
71.59% <0.00%> (-3.41%)
:arrow_down:

os/glog/glog_logger_rotate.go
61.99% <0.00%> (-1.36%)
:arrow_down:

container/gmap/gmap_hash_str_any_map.go
97.00% <0.00%> (-1.00%)
:arrow_down:

os/gcmd/gcmd_parser.go
92.19% <0.00%> (-0.71%)
:arrow_down:

container/gtree/gtree_avltree.go
95.40% <0.00%> (-0.58%)
:arrow_down:

os/gcron/gcron_schedule.go
70.42% <0.00%> (-0.39%)
:arrow_down:

contrib/drivers/oracle/oracle.go

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 384fb3c...fabbb8d. Read the comment docs.


switch from CLA to DCO #765

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Pirates (Space IRS)

About the PR

gracing goobstation with more shitcode
very big draft, indicates that i'm slowly but surely working on it
will update the description as i figure stuff out

Why did you name it Space IRS

Why did you name it Space IRS

Ss13 pirates have different possible Crew option: skeleton Crew, gray tide, plain pirates , and irs

Why did you name it Space IRS

@JustSome1Nearby

Wait.. weak in space?
Shouldnt this antag be the reason to actualy USE ship combat, ship guns?
It isnt used ANYWHERE else (the only use of ship canons rn is to bomb the station itself... But Why?)
Imagine their ship BEING THE PLACE TO STORE THA BOOTY, being atacked by cargo shuttle with Friendship canons,
a violent, EPIC spacecraft battle starts, people fly out of the ship due to busted walls, you constantly need repair the power and atmos, being CREATIVE about it, some pirates proceed to hop onto oponent's vessel and a bloody fight on the cutlasses initiates

@whateverusername0 https://github.com/Goob-Station/Goob-Station/issues/731

Yeah also if you need a shuttle, ping me in discord

will these be a midround antag like ss13?

will these be a midround antag like ss13?

yes


[Addition]:  witness over 1000 km!!! Virtual Onyx Puma

Hotspot b58 Addresses
14nezTV1q6AgTtzzqv55ZMc6zQVjiLFZeCZMd1vHzuZFsEDuYLV
Discord Handle
No response
Reason(s)
Look over this HS. Witness 1000 km. Impossible without cheating

Removal already requested in
https://github.com/helium/denylist/issues/2556
Please understand that requests are processed manually, and creating dozens of requests for the same hotspot may only delay the overall processing of those requests.

Ok. I didn’t see the other post. Sorry for that mate


Items are re-created

Seems that with real data the include doesn't work. Will extend the tests.
Issue stands from the pagination.
Adding filtering with label + pagination will fix this.
Blocked by https://github.com/nobe4/girssa/issues/36

This was fixed by #36


The streets do not load in the mod

when I create a world in the planet earth option, I select to spawn streets, but when I enter it don't spawn streets, It don't spawn anything,Can someone help me?

Make sure you are in an area with streets like a city, you need to teleport with /tpll latitude longitude.
try
/tpll 51.502098, -0.140086
for London. or smthn

I'm having this issue as well, i tried teleporting to the coordinates above and i got no roads and no OSM building outlines. any fixes for this issue?

me too

For me it works fine. Maybe it is a http(s) bug. Do you have THIS MOD?


Handling Images without Tumors for Model Training and Testing

Hi,
Wonderful job! But when I ran your project, I have a question. My data includes some images that do not contain tumors; therefore, their masks are entirely zero. For these images, is the code unable to generate prompt points during training and testing?

Hi,
When I input an image without a tumor, the code crashes. The error shown is:

Hi, since this work is a promptable segmentation model, at least one prompt point is needed. So, if your label is totally empty, our code will crash.
If you have to infer without label, you can try this experimental script https://github.com/uni-medical/SAM-Med3D/blob/main/infer_sequence.sh


Topic/union converter

Union conversion draft.

Todolist:

[x] string "None" is not converted by default
[x] Union is handled
[x] Types inside union are matched even if there is no converter for the specific type
[ ] float -> int converter
[ ] int -> float converter
[ ] number -> timedelta converter
[ ] testing

This also has enum None conversion fix.


Design Product Logo

Design Brief
About Product: A free solution that automatically runs in the background of your Windows Operating System Device to routinely clean up Junk files, save storage/space and improve performance, without you having to do it manually every time. Junk files are temporary files that were created so that your computer/device could perform a task, such as opening a document, viewing an image, or browsing the internet. These files are useful at the moment, but once they’ve served their purpose, they’re just junk, system junk files that clog up a device and cause poor performance.
Inspiration:

The Logo should be able to come across as Tech savvy, Futuristic, and Simple but still communicate the purpose of the product.
It should be something that can easily be used as an icon. Ideas and suggestions by the Designer are highly welcome. Feel free to start a conversation in the comments section.
Feel free to suggest theme colors not more than 3, the primary theme color should be one of those three.

Suggested Design Tool:

Adobe illustrator or any other tool that can enable the designer produce vector graphics.

Expected Output:

png file format for the Product Logo on a transparent background

Use Cases for the Logo Design:

We intend to use Microsoft Store as our Distribution channel for the product (Windows Musawo). We are going to use this Logo there mostly and in our social media marketing campaigns. Be sure to look at the Microsoft Store and how apps display their logo to get an idea of how our Logo could fit in as well. For more clarity questions, start a discussion in the comments

Hi Ronnie, can I be assigned this?

Thank you @Victorayo! We're assigning you the issue. Don't hesitate to ask whenever you have questions about anything to help you deal with the issue.

@Victorayo! Go ahead please. Don't hesitate to ask any clarifying questions you may have. Thanks!

Hi Ronnie, the name of the Windows am designer logo for is "Musawo" right?

@Victorayo The name of the product is Windows Musawo. And the Logo is being designed for it. I hope this is clear now.

@Victorayo The name of the product is Windows Musawo. And the Logo is being designed for it. I hope this is clear now. 😊

Yeah it is.

I sent

@Victorayo The name of the product is Windows Musawo. And the Logo is being designed for it. I hope this is clear now. blush

Hi Ronnie, I sent some pull request. Kindly check them

Thank you so much, great stuff.


Remove Resource.templates and remove blanket tslint ignore

Don't include templates in the resource
Instead of a blank tslint:ignore, we now only ignore based on line-length.

lgtm