Add Hacktoberfest user stats cog

Initial functionality for #6 for review.
There are a few typos to fix but they'll be squashed in with changes from review.

Might want to run this through flake8 to clear up some of the syntactical errors I missed in the reviews.


Feature Request

First of all, great job!
It would be very helpful for characters with three of the same character types to have a way to know which one is which. Destiny app shows the characters' banner but you might be able to also get the species type. I have three lvl 40 warlocks, one awoken male and female, and one male human. All other factors can possibly change, but those cannot.

Nice idea, i will try to modify toolbar a bit, to fit there that information. I do not want to copy look from destiny app, because i want have tab's as small as it's possible to focus user on items

Yup makes sense, also I noticed you do have the banners in the app so that
does help but it would still be nice to show something that is permanent to
the character.

After few test i have best version:

but i want to think if put it to official version. I'm starting about creating setings page and add it as opt in

Nice! Definitely more functional than any other app out there trying to do
this. Thanks for the quick changes... I wasn't expecting anything.

Its pushed in 1.6.2 version


your api key

does it matter that it's in the constants?  Can it be used maliciously?
Just thought I'd check =)

Not quite mine :) It's hard-coded on Chromium.
https://www.google.com/search?q="AIzaSyBOti4mM-6x9WDnZIjIeyEU21OpBXqWBgw"&oq="AIzaSyBOti4mM-6x9WDnZIjIeyEU21OpBXqWBgw"&aqs=chrome..69i57.551j0j4&sourceid=chrome&es_sm=91&ie=UTF-8
Thanks for letting me know though!

No worries!  I had read a while back that people were leaving their EC2 API keys on their github commits and some malicious people wrote bots to mine github for them, then use them to do nefarious things.


New Source

there is a source i see with sesson like Prison School at last with one episode what other source doesn't you may look it here
UPDATE : Streaming , it's take data from different Source's it's can be good to the software since KawAnime dont find that Prison School: Mad Wax: stream
what i found there.
http://watchanime.info/prison-school-mad-wax/

As long as you have a torrent file or a magnet link, you can stream it in KawAnime. No source needed at the moment.
KawAnime offers magnet links for most of the anime but if not available, you can always simply paste the magnet link into the app or drag & drop a torrent file or a video file into the app to watch it.


Replace customer iteritems solution with provided from six package

Coverage decreased (-0.07%) to 37.328% when pulling 1e73fb65e7dcf1f525cb964e6e8bf836dc0ebdc8 on citizen-stig:python3-compatibility-improvements into f7fa9535b91c572ceeec343d7fbe4d585ad9bcbf on xhtml2pdf:develop.

Coverage decreased (-0.1%) to 37.299% when pulling ad8917777207b47a82db9a0e4e51bb762596ebd0 on citizen-stig:python3-compatibility-improvements into f7fa9535b91c572ceeec343d7fbe4d585ad9bcbf on xhtml2pdf:develop.

Big simplifications!


[DEFECT] GA searching only in limited subspace

Thank you for the defect report

[X] I am using the latest version of RAVEN.
[X] I have read the Wiki.
[X] I have created a minimum, reproducible example
that demonstrates the defect.

Defect Description
GA has been found that it only searches in limited subspace bound to initial population. If the number of population is small, then optimal solution may not be found.
Steps to Reproduce
Try running
...\projects\raven\doc\workshop\optimizer\GeneticAlgorithms\Inputs\4_GA_MaximumHorizontalRange.xml with small numbers of populations.
Even if you increase the number of iterations, optimal solution will be found.
Expected Behavior
Optimal solution needs to be found regardless of the number of initial population.
Screenshots and Input Files
No response
OS
Windows
OS Version
No response
Dependency Manager
CONDA
For Change Control Board: Issue Review

[x] Is it tagged with a type: defect or task?
[x] Is it tagged with a priority: critical, normal or minor?
[x] If it will impact requirements or requirements tests, is it tagged with requirements?
[x] If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

[x] If the issue is a defect, is the defect fixed?
[x] If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

issue checklist is good.


Some fixes for findreplace ui

Pressing tab in find-replace mode toggles between findbar and replace bar.
Text is selected in findbar or replacebar when focused.
Findbar focused by default in both findonly and findreplace mode.

Can you separate the logic for adding indentation vs removing indentation (shift+tab)? Because I think for adding indentation, the implementation should be very clean and small.

Can you separate the logic for adding indentation vs removing indentation (shift+tab)? Because I think for adding indentation, the implementation should be very clean and small.

The PR request for indentation is here. I have made the changes.

Can you separate the logic for adding indentation vs removing indentation (shift+tab)? Because I think for adding indentation, the implementation should be very clean and small.

The PR request for indentation is here. I have made the changes.

Sorry, I put the comment in wrong PR.


Remove automated_response

Table and struct job_applications have a field/column that shows if the ATS sent an immediate automated response. So far, only one has failed to send me an immediate email, so this is probably not a good metric. This is easy to do and hard to reverse, so I will keep the column and the field present while I work on higher priorities.

Multiple companies have not sent an automated response. I will still get rid of this.

For the 3 applications that have not sent an automated response, I just noted that in the notes column.


Feature: Custom handler

This PR adds support for custom lambda handlers. The API works in accordance to @danielcondemarin's proposal in https://github.com/danielcondemarin/serverless-nextjs-plugin/issues/12#issuecomment-487752306.
Fixes #12.

👍 waiting for this, good work

I’ll review this tonight, thanks @mekwall 👌🏼

Looks good. Will get this published asap 🚀


feat(prettier): implement format for ContinueStatement

Deleted by mistake at #1285

Current dependencies on/for this PR:

main

PR #1293   👈

This stack of pull requests is managed by Graphite.

It seems like I need to coordinate a bit for less conflicts.


(this.configurationService.getValue(...) || []).filter Error after updating VSCode

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:  1.56.2, Commit: 054a9295330880ed74ceaedda236253b4f39a335
OS Version: 11.2.3

Steps to Reproduce:

Go to Extension -> click on any extension -> error appears in notification

(this.configurationService.getValue(...) || []).filter is not a function
at Tn.getAssociationsForResource (workbench.desktop.main.js:2164)
at Tn.getContributionPoint (workbench.desktop.main.js:2164)
at Tn.resolveEditorOverride (workbench.desktop.main.js:2164)
at A.openEditor (workbench.desktop.main.js:2290)
at ss.open (workbench.desktop.main.js:2705)
at q.openExtension (workbench.desktop.main.js:2701)
at workbench.desktop.main.js:2701
at a.fire (workbench.desktop.main.js:60)
at workbench.desktop.main.js:58
at a.fire (workbench.desktop.main.js:60)
at workbench.desktop.main.js:58
at a.fire (workbench.desktop.main.js:60)
at U._open (workbench.desktop.main.js:662)
at U.onPointer (workbench.desktop.main.js:662)
at workbench.desktop.main.js:662
at a.fire (workbench.desktop.main.js:60)
at workbench.desktop.main.js:58
at a.fire (workbench.desktop.main.js:60)
at N.onViewPointer (workbench.desktop.main.js:124)
at workbench.desktop.main.js:58
at a.fire (workbench.desktop.main.js:60)
at workbench.desktop.main.js:58
at a.fire (workbench.desktop.main.js:60)
at HTMLDivElement.w (workbench.desktop.main.js:60)

W


Refactoring for better readability.

Polishing imports
Removing hostname & port from TestRestTemplate-calls
Substituting @Value("${local.server.port}") with @LocalServerPort

@elgohr Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@elgohr Thank you for signing the Contributor License Agreement!

Codecov Report

Merging #1686 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1686   +/-   ##
=======================================
  Coverage   75.08%   75.08%
=======================================
  Files         197      197
  Lines        6132     6132
  Branches      767      767
=======================================
  Hits         4604     4604
  Misses       1196     1196
  Partials      332      332

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78da7b...f56d786. Read the comment docs.

I assume that you use that you use the default eclipse behaviour when organising imports. In this way I also moved the static imports to the top.
Would be great to have a checkstyle for this.

This is what we have for now https://github.com/spring-cloud/spring-cloud-netflix/tree/master/eclipse


Model stuck in Loading decompress_residuals_cpp extension

@okhat
Hi, I am running colbert with following configuration on a single GPU.
Following is the script I am using.  I just wanted to see if I could run a quick indexing end to end.
import os
import sys
sys.path.insert(0, '../')

from colbert.infra import Run, RunConfig, ColBERTConfig
from colbert.data import Queries, Collection
from colbert import Indexer, Searcher

if __name__ == '__main__':
    dataroot = 'downloads/lotte'
    dataset = 'lifestyle'
    datasplit = 'dev'

    queries = os.path.join(dataroot, dataset, datasplit, 'questions.search.tsv')
    collection = os.path.join(dataroot, dataset, datasplit, 'collection.tsv')

    queries = Queries(path=queries)
    collection = Collection(path=collection)

    f'Loaded {len(queries)} queries and {len(collection):,} passages'

    print(queries[24])
    print()
    print(collection[89852])
    print()

    nbits = 2   # encode each dimension with 2 bits
    doc_maxlen = 300   # truncate passages at 300 tokens

    checkpoint = 'downloads/colbertv2.0'
    index_name = f'{dataset}.{datasplit}.{nbits}bits'

    with Run().context(RunConfig(nranks=1, experiment='msmarco')):  # nranks specifies the number of GPUs to use.
        config = ColBERTConfig(doc_maxlen=doc_maxlen, nbits=nbits)

        indexer = Indexer(checkpoint=checkpoint, config=config)
        indexer.index(name=index_name, collection=collection[:20], overwrite=True)

    print(indexer.get_index()) # You can get the absolute path of the index, if needed.

However the indexing seems to be stuck at this point.
WARNING clustering 2687 points to 512 centroids: please provide at least 19968 training points
Clustering 2687 points in 128D to 512 clusters, redo 1 times, 20 iterations
  Preprocessing in 0.00 s
  Iteration 19 (1.10 s, search 0.23 s): objective=463.491 imbalance=1.616 nsplit=0
[Apr 22, 02:32:04] Loading decompress_residuals_cpp extension (set COLBERT_LOAD_TORCH_EXTENSION_VERBOSE=True for more info)...

I am running on a Quadro RTX 8000 (49GB) and 128GB RAM machine.

Could you re-run and set the environment variable COLBERT_LOAD_TORCH_EXTENSION_VERBOSE=True? It's possible that you need to erase your torch extensions cache to enable the Torch extension code to compile.

What infrastructure are you using to run this?

and have you tried setting COLBERT_LOAD_TORCH_EXTENSION_VERBOSE=True

Hi, okhat. Thank for your response!
I run this on a single RTX2080 gpu in linux. I am not very sure what other information you need, so leave me a message if  you want more.
I built an environment following conda_env.yml, but the cuda version of my machine is cuda 11.3. So I am using torch-1.12.1+cu113-cp38 and other packages that may not strictly follow the corresponding versions in conda_env.yml.
Below is the same error when setting  COLBERT_LOAD_TORCH_EXTENSION_VERBOSE=True.
[May 04, 03:18:56] Loading decompress_residuals_cpp extension (set COLBERT_LOAD_TORCH_EXTENSION_VERBOSE=True for more info)...
Using /home/zzh/.cache/torch_extensions/py38_cu113 as PyTorch extensions root...
Detected CUDA files, patching ldflags
Emitting ninja build file /home/zzh/.cache/torch_extensions/py38_cu113/decompress_residuals_cpp/build.ninja...
Building extension module decompress_residuals_cpp...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
1.11.1.git.kitware.jobserver-1
Loading extension module decompress_residuals_cpp...
Process Process-2:
Traceback (most recent call last):
  File "/mntnfs/med_data5/zzh/anaconda/envs/colbert/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/mntnfs/med_data5/zzh/anaconda/envs/colbert/lib/python3.8/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/mntnfs/med_data5/zzh/Dream-of-red-chamber/codes/ColBERT/docs/../colbert/infra/launcher.py", line 115, in setup_new_process
    return_val = callee(config, *args)
  File "/mntnfs/med_data5/zzh/Dream-of-red-chamber/codes/ColBERT/docs/../colbert/indexing/collection_indexer.py", line 33, in encode
    encoder.run(shared_lists)
  File "/mntnfs/med_data5/zzh/Dream-of-red-chamber/codes/ColBERT/docs/../colbert/indexing/collection_indexer.py", line 67, in run
    self.train(shared_lists) # Trains centroids from selected passages
  File "/mntnfs/med_data5/zzh/Dream-of-red-chamber/codes/ColBERT/docs/../colbert/indexing/collection_indexer.py", line 225, in train
    bucket_cutoffs, bucket_weights, avg_residual = self._compute_avg_residual(centroids, heldout)
  File "/mntnfs/med_data5/zzh/Dream-of-red-chamber/codes/ColBERT/docs/../colbert/indexing/collection_indexer.py", line 302, in _compute_avg_residual
    compressor = ResidualCodec(config=self.config, centroids=centroids, avg_residual=None)
  File "/mntnfs/med_data5/zzh/Dream-of-red-chamber/codes/ColBERT/docs/../colbert/indexing/codecs/residual.py", line 24, in __init__
    ResidualCodec.try_load_torch_extensions(self.use_gpu)
  File "/mntnfs/med_data5/zzh/Dream-of-red-chamber/codes/ColBERT/docs/../colbert/indexing/codecs/residual.py", line 103, in try_load_torch_extensions
    decompress_residuals_cpp = load(
  File "/mntnfs/med_data5/zzh/anaconda/envs/colbert/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1202, in load
    return _jit_compile(
  File "/mntnfs/med_data5/zzh/anaconda/envs/colbert/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1450, in _jit_compile
    return _import_module_from_library(name, build_directory, is_python_module)
  File "/mntnfs/med_data5/zzh/anaconda/envs/colbert/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1844, in _import_module_from_library
    module = importlib.util.module_from_spec(spec)
  File "<frozen importlib._bootstrap>", line 556, in module_from_spec
  File "<frozen importlib._bootstrap_external>", line 1166, in create_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
ImportError: /home/zzh/.cache/torch_extensions/py38_cu113/decompress_residuals_cpp/decompress_residuals_cpp.so: cannot open shared object file: No such file or directory

Thank you again!

Can you try removing this folder and running again?
/home/zzh/.cache/torch_extensions/py38_cu113

Let us know if this helps

Thank you for your advice.
I actually have tried removing the folder /home/zzh/.cache/torch_extensions/py38_cu113 and running again several times before I asked your help. I am so sorry that this method does not solve the error I am faced with.
Best wishes!

I also get stuck here, have you solved it yet?

Try reducing the number of passages youre indexing? This code has been working for a long time so we should look into whether some of the dependencies have broken somehow

I run into the same issue yesterday (regardless of number of passages) but removing py38_cu113 from .cache  solved it for me.
I tested with small (10K) and large number of passages (.6M) and both worked fine. The issue appeared to originate by interrupting the process during an initial test run. This resulted in some IO hanging in the attempt to load the output files, which resulted in no errors even when debugging was turned on. Setup is RTX2080 on Ubuntu 20.04 LTS so quite comparable to past reported issues. I didn't have to re-do the conda environment but that might also help in some cases, or even trying the cpu only.

Try reducing the number of passages youre indexing? This code has been working for a long time so we should look into whether some of the dependencies have broken somehow

I also faced this problem and have tried to remove the torch_extensions, but still got stuck here.
Do you have any solutions? Best Wishes!
This is my error log:
[Jun 11, 13:37:02] [0] 		 # of sampled PIDs = 3633 	 sampled_pids[:3] = [1706, 3001, 41]
[Jun 11, 13:37:02] [0] 		 #> Encoding 3633 passages..
[Jun 11, 13:37:10] [0] 		 avg_doclen_est =<PHONE_NUMBER>310547 	 len(local_sample) = 3,633
[Jun 11, 13:37:10] [0] 		 Creaing 8,192 partitions.
[Jun 11, 13:37:10] [0] 		 Estimated 853,477 embeddings.
[Jun 11, 13:37:10] [0] 		 #> Saving the indexing plan to /home/zhangtong/ColBERT/experiments/nfcorpus/indexes/nfcorpus.2bits/plan.json ..
Clustering 810805 points in 128D to 8192 clusters, redo 1 times, 20 iterations
Preprocessing in 0.10 s
Iteration 19 (15.56 s, search 15.10 s): objective=183529 imbalance=1.361 nsplit=0
[Jun 11, 13:37:26] Loading decompress_residuals_cpp extension (set COLBERT_LOAD_TORCH_EXTENSION_VERBOSE=True for more info)...
Using /home/zhangtong/.cache/torch_extensions/py38_cu117 as PyTorch extensions root...
Process Process-2:
Traceback (most recent call last):
File "/home/zhangtong/anaconda3/envs/colbert/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
self.run()
File "/home/zhangtong/anaconda3/envs/colbert/lib/python3.8/multiprocessing/process.py", line 108, in run
self._target(*self._args, **self._kwargs)
File "/home/zhangtong/ColBERT/colbert/infra/launcher.py", line 115, in setup_new_process
return_val = callee(config, *args)
File "/home/zhangtong/ColBERT/colbert/indexing/collection_indexer.py", line 33, in encode
encoder.run(shared_lists)
File "/home/zhangtong/ColBERT/colbert/indexing/collection_indexer.py", line 67, in run
self.train(shared_lists) # Trains centroids from selected passages
File "/home/zhangtong/ColBERT/colbert/indexing/collection_indexer.py", line 225, in train
bucket_cutoffs, bucket_weights, avg_residual = self._compute_avg_residual(centroids, heldout)
File "/home/zhangtong/ColBERT/colbert/indexing/collection_indexer.py", line 302, in _compute_avg_residual
compressor = ResidualCodec(config=self.config, centroids=centroids, avg_residual=None)
File "/home/zhangtong/ColBERT/colbert/indexing/codecs/residual.py", line 24, in init
ResidualCodec.try_load_torch_extensions(self.use_gpu)
File "/home/zhangtong/ColBERT/colbert/indexing/codecs/residual.py", line 103, in try_load_torch_extensions
decompress_residuals_cpp = load(
File "/home/zhangtong/anaconda3/envs/colbert/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1284, in load
return _jit_compile(
File "/home/zhangtong/anaconda3/envs/colbert/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1508, in _jit_compile
_write_ninja_file_and_build_library(
File "/home/zhangtong/anaconda3/envs/colbert/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1592, in _write_ninja_file_and_build_library
verify_ninja_availability()
File "/home/zhangtong/anaconda3/envs/colbert/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1648, in verify_ninja_availability
raise RuntimeError("Ninja is required to load C++ extensions")
RuntimeError: Ninja is required to load C++ extensions

Does it mean the version of Ninja is not suitable?

Hi!
Facing the same issue as above:
RuntimeError: Ninja is required to load C++ extensions

你好！ 面临与上面相同的问题： RuntimeError: Ninja is required to load C++ extensions

I tried all the methods but couldn't solve this error, but it can run only on the CPU

Hi @zt991211 @palm2333 @zzhheloise, putting a comment here with what worked for me, so if you're still facing the issue I was, maybe this can help.
My issue turned out to be an environmental one, and that is in line with other people not facing such issues. I tried this on a couple of environments and am currently on WSL2.
Basically, my problem was with CUDA. As per my understanding, the cuda toolkit set up in the conda environment provided with this repo with pytorch comes with some needed runtime libraries, but the code requires nvcc as well. So what worked for me (In WSL2 on Windows 10) was installing cudatoolkit-dev via conda forge:
conda install -c conda-forge cudatoolkit-dev
Again, this is just what seemed to have worked for me.
Hope this is okay @okhat
Thanks!

Folks who are still facing issues can use this Google Colab: https://colab.research.google.com/github/stanford-futuredata/ColBERT/blob/main/docs/intro2new.ipynb

I also faced this same issue consistent with the case after the sub-processes crash and are left in a zombie state requiring manual killing.

I recently encountered a similar issue. I checked the GPU version of torch and other packages corresponding to the CUDA version, upgraded my GCC version.
And I tried several methods, and I'm not certain which one resolved it:
sudo apt update
sudo apt install build-essential
sudo apt-get install ninja-build
conda install -c conda-forge cudatoolkit-dev
rm -rf /root/.cache/torch_extensions/py38_cu113
Cache files are generated every time they run, so delete them before running.
I hope this helps anyone facing the same problem.


Mapper: support options at batch level

I will squash my commits as soon as build fixes

The jenkins is breaking because at mono the exception throw is UnavailableException, but at windows it throws a WriteTimeoutException.

I think the test can be simplified: if you use a single node cluster, create a keyspace with replication factor 3 and try to write with consistency > 1, it will throw an unavailable exception.


Persistent storage feature on Kubernetes, should I retain emqttd/data?

Environment
Kubernetes

OS: Alpine
Erlang/OTP: 7.3.1
EMQ: v2.0.7

Description
Hello,
We intend to run an EMQ cluster on Kubernetes...
Kubernetes has a persistant storage feature which allows data survive a re-start/crash of a container,
I understand that most EMQ data is stored in memory (except for 'topics trees' is it?)
Would there be any benefit to persisting any files? if so which would it be, maybe the emqttd/data folder?

+1

+1

+1

+1

+1

+1

isn't this available only in enterprise version? :)

Yes, :)


Sign in using same email on multiple devices

I am integrating firebase auth for google and facebook sign-in, everything works perfect but in a scenario I m stuck.
Any help would be appreciated.

Android device: Nexus 5
Android OS version: 7.1 Android
Google Play Services version: 10.0.84
Firebase/Play Services SDK version: 9.8.0

Step 3: Describe the problem:
If I sign-in using one device and keep it logged in and sign in using same email id in the second device, I want the first one to automatically log out.
Is there a way handle this case..
Steps to reproduce:

Sign in using an email Id in Device 1
Keep Device 1 signed in (do not log out)
Sign in using same email id (used in step 1) to sign in another device say Device 2

Observed Results:
Both devices are logged in using same email id
Expected Results:
I want the somehow the first device to log out automatically
Relevant Code:

Sorry @abhinav272 that's not a supported feature of Firebase Auth right now, but I will take it as feedback.

+1


[cl4] dotenv does not work on windows

Use a conf.py file with the contents
from dotenv import dotenv_values
from os import enviorn as os_env

environ = {
  **dotenv_values(".env")
  **os_env
  }

def getenv(key: str, default=None) -> str:
       return  environ.get(key, default)

and import that instead

(this is needed to changed mongo and redis URIS)

huh?
It works fine for me on Windows. I've been developing the whole CL4 port on Windows and haven't had any problems.

Dotenv does not work on windows 10 (home), because it modifies os
Environ

Are you sure you used py -m pip install -r requirements.txt?

Dotenv does not work on windows 10 (home), because it modifies os Environ

Do you get an error when trying to start the server or do the values just not get set?

just do not get set

just do not get set

Hm, alright, I will try Windows 10 Home and see if I can reproduce this.

What Python version are you using?

3.10.x im not actually at home RN

Were you using Windows ARM on your rpi or were you on an x86 computer?

x86 based  intel

Which variant of x86? The 32-bit version (x86) or 64-bit (x86_64)? it's likely you are actually using x86_64.
Regardless, a possible solution is to upgrade to Python 3.11 or newer.

Which variant of x86? The 32-bit version (x86) or 64-bit (x86_64)? it's likely you are actually using x86_64. Regardless, a possible solution is to upgrade to Python 3.11 or newer.

I use Python 3.10.8 (64-bit) without any problem.
I'm also getting a test VM ready to see if I can reproduce this.

x86_64 def

Python 3.11.0 on Windows 10 Education Edition (Work PC) works. I don't have any issues with dotenv.

Python 3.11.0 on Windows 10 Education Edition (Work PC) works. I don't have any issues with dotenv.

Windows Education is very similar to Pro/Enterprise (Pro is what I use), Windows Home has some interesting restrictions that may be causing something weird.

. . .

uh what?

This should be fixed now


x/pkgsite: pkg.go.dev/std is unreachable from the homepage

What is the URL of the page with the issue?
pkg.go.dev
What is your user agent?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.93 Safari/537.36
Screenshot

What did you do?
Visited the page
What did you expect to see?
A way to browse the standard library. I learned most of what I know about the runtime, sync, mime, and other packages by perusing the documentation looking for packages I hadn't used before. I never would have been able to do that with the use case the website is focused on right now: finding what you're already looking for. I don't always know what I'm looking for. I love that this is one place for documentation, even non-standard libraries, but pkg.do.dev/std should be easily accessible from the homepage. I had to find it by searching for something I didn't want to find then clicking a breadcrumb that didn't seem related to the actions I took to get there. It was not beginner-friendly.
Maybe one of the hints under the search bar could have a link or a "What's in the standard library?" FAQ link that takes you to the page.
What did you see instead?
A search bar that doesn't aid in discovery.

Duplicate of #40785


Assertion failed for distance calculator

Hello alfgo authors,
I am evaluating aflgo with fuzzing benchmark Magma.
When I tried to use scripts/gen_distance_fast.py in building Magma's targets, a lot of computations failed with the assertion
distance_calculator: main.cpp:174: std::vector<vertex_desc> cfg_calculation(graph_t &, std::ifstream &, std::ifstream &, std::ifstream &, unordered_map<std::string, double> &, unordered_map<std::string, double> &): Assertion `splits.size() == 2' failed.

On the other hand scripts/genDistance.sh worked in general, just being very very slow.
May I ask what is this assertion for and what maybe the cause of it? Is it fine to ignore it?
Please let me know if you would like to see the building scripts, binary, etc for this issue.
This happened for both the old aflgo and the current llvm11 version.
Thank you in advance!

Thanks for reporting the issue!
Tagging @Liblor.

Hi @spencerwuwu
This is probably caused by an empty line in the callgraph.distance.txt file (or it is possibly empty), could you have a look at that file and share it? In any case it would also be helpful if you can share your build scripts.
When it comes to your question what it does:
https://github.com/aflgo/aflgo/blob/6e87b69ab2c31177d66e1c3d0b674393cfdceec7/distance_calculator/main.cpp#L158-L164
Basically, the callgraph.distance.txt file should have a basic-block name and a distance (float) per line separated by a comma, the assertion asserts that exactly two elements are per line. This isn't proper error handling, and was rather used during developing and I'm a bit surprised that it is triggerable with the gen_distance_fast.py script.
Best,
Liblor

Hi Liblor and Marcel,
Thank you for the reply!
I checked the callgraph.distance.txt in my building environment. It seems to be fine as following:
MAGMA_png_read_info,3
MAGMA_png_read_row,4
MAGMA_png_read_end,3
MAGMA_png_read_chunk_header,2
MAGMA_png_check_chunk_length,1
MAGMA_png_read_IDAT_data,3
MAGMA_png_read_finish_IDAT,4
MAGMA_png_read_finish_row,5
LLVMFuzzerTestOneInput,4

And, but, somehow, the scripts started to worked today... really curious.
They have been not working for the past few weeks, until I tried to clean it up and send you guys.
I will let you know if I figure out what's happening...

Hi spencerwuwu
Great! In that case, there was probably some polluted state. While this shouldn't happen I didn't do extensive testing in that regard for the gen_distance_fast.py script. Happy to look into it, if you figure out what happened or how to reproduce.

Hi Liblor,
I found out that it's only luck that the scripts build a target successfully.
When I run it several times, the assertion is triggered constantly. My guess is that there are some object files that will trigger the assertion, but they may not be processed every time when calculating distances.
I clean up the scripts to demo this in branch aflgo of this repo.
Everything is built inside a Docker. You can use cd tools/caption && ./build_aflgo_example.sh to build the image.
The scripts basically fetch the code of aflgo and libpng into a container's $FUZZER/repo and $TARGET/repo respectively.
Then, fuzzers/aflgo/instrument.sh ($FUZZER/instrument.sh in the docker image) is executed to build libpng and calculate distances.
Regardless of the scripts succeed or not, we should get a docker image with or without an image name.
What I did is I run this image, edit $FUZZER/repo/scripts/gen_distance_fast.py to print out the cmd of exec_distance_prog, then run $FUZZER/instrument.sh. It's very likely to see gen_distance_fast.py failed, with the latest command executed printed.
If the script succeed, well you're lucky lol. Run it again and you should see it fail.
It's a bit complicated to reproduce. Please don't make it a priority to your tasks if you're busy. And thank you in advance again!
Best,
Spencer

Hi Spencer
So today I finally had time to investigate, but I can't reproduce the issue.
Here's what I did:
git clone https://github.com/spencerwuwu/magma.git aflgo_issue_97
cd aflgo_issue_97/tools/caption
./build_aflgo_example.sh
docker -it ... /bin/bash

Stuff from here is run inside the docker image:
First, I recompiled the distance_calculator in debug mode:
cd $FUZZER/repo/distance_calculator/
rm distance_calculator
cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug  # making sure to absolutely have assertions printed
ninja

Next, I edited exec_distance_prog as follows:
def exec_distance_prog(dot, targets, out, names, cg_distance=None,
                       cg_callsites=None, py_version=False):
    prog = DIST_BIN if not py_version else DIST_PY
    cmd = [prog,
           "-d", dot,
           "-t", targets,
           "-o", out,
           "-n", names]
    print(" ".join(list(map(str, cmd))))
    if cg_distance is not None and cg_callsites is not None:
        cmd.extend(["-c", cg_distance,
                    "-s", cg_callsites])
    pipe = subprocess.PIPE
    r = subprocess.run(cmd, stdout=pipe, stderr=pipe, check=True)
    print(f"stdout: {r.stdout.decode()}")
    print(f"stderr: {r.stderr.decode()}")

Finally, I ran instrument.sh:
./instrument.sh |& test.log

I did so multiple times (the last step), but test.log never contained the string "Assertion". Let me know, if I followed your instructions properly or whether I missed something crucial!
Cheers,
Liblor

Hi, I met the same problem when I tried to use AFLGO to fuzz libtiff. With the debug method in https://github.com/aflgo/aflgo/issues/97#issuecomment-869180985, I found the problem was due to the empty line in cg_callsites_stream (BBnames.txt), instead of cg_distance_stream (callgraph.distance.txt). And here is the file,
# head -n10 $TMP_DIR/BBcalls.txt

,TIFFErrorExtR
,TIFFReadDirEntryCheckRangeSbyteSlong8
,TIFFReadDirEntryData
,TIFFYCbCrtoRGB
,__assert_fail
TIFFError
addtiffo.c:105,strcmp
addtiffo.c:113,fprintf
addtiffo.c:126,atoi

These empty lines can be removed by adding |grep -v "^$" in the cleanup process
# Clean up
cat $TMP_DIR/BBnames.txt | grep -v "^$" | rev | cut -d: -f2- | rev | sort | uniq > $TMP_DIR/BBnames2.txt && mv $TMP_DIR/BBnames2.txt $TMP_DIR/BBnames.txt
cat $TMP_DIR/BBcalls.txt |grep -v "^$" | sort | uniq > $TMP_DIR/BBcalls2.txt && mv $TMP_DIR/BBcalls2.txt $TMP_DIR/BBcalls.txt

Additionally, several lines in BBcalls.txt may have incorrect number of comma marks, which also caused the assertion failed,
# cat $TMP_DIR/BBcalls.txt |grep ".*,.*,"
tif_dirwrite.c:3542,TIFFDataWidthtif_dir.c:60,setByteArray
tiffcp.c:1420,TIFFFileNametiffmedian.c:136,getopt
tiff2pdf.c:3027,TIFFFileNametiff2ps.c:284,getopt
# cat temp_tiffcrop_6247/BBcalls.txt |grep -v ","
tiff2ps.c:2190

I do not know why this happens, and it is hard to identify the correct function name automatically, so I corrected this file manually.


Move dummy types to submodule

Clippy warns about the dummy types, in an effort to clear all clippy warnings do:

Create a submodule dummy and move all the dummy key types there (refactor/clean up).
Manually implement PartialEq and Eq for all the dummy types.

We could rename these as well to drop Dummy from the name if we have a module called dummy.

Its acting like a dummy - (couldn't help myself)

Please see #508 before merging this, perhaps we just want to remove the dummy types altogether and use String?

@tcharding, agreed. It is best to remove the dummy keys altogether

Unneeded since #508 merged.


Add diagrams for state script transitions and use cases

Signed-off-by: Drew Moseley<EMAIL_ADDRESS>

This adds my state machine diagram as well as customized versions for the documented use cases. It's hard to see what this looks like here in PR form.  I ran mender-docs-site locally and did a print to PDF.  It's not a perfect representation but should give you an idea of how it looks.
State scripts _ Mender documentation.pdf

Actually you can see it if you click the little document icon on each file ("rich diff").
Big thumbs up from me!

Yeah, I thought the same thing but the Google Draw utility didn't have anything better.  If you come up with a better choice we can always update them later.  The source documents are in Google drive.

Really good stuff @drewmoseley!


Wrong link in German version of speech-to-text docs

The German version of this article has a broken link at the text "Beispiele für die Batch-Transkription (REST)."
German version:
https://learn.microsoft.com/de-de/azure/cognitive-services/speech-service/speech-to-text
English version:
https://github.com/Azure-Samples/cognitive-services-speech-sdk/tree/master/samples/batch

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cc2fcd39-a2d6-0a3a-1235-1aae45cae26d
Version Independent ID: db227248-d6d1-b1d3-05bc-522cd1435da2
Content: Speech-to-text overview - Speech service - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/speech-to-text.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @eric-urban
Microsoft Alias: eur

@d-Rickyy-b
Thanks for your feedback! We will investigate and update as appropriate.

Hi @eric-urban
Could you please review add comments on this, update as appropriate.

@d-Rickyy-b
Thank you for bringing this to our attention.
I've delegated this to content author @eric-urban, who will review it and offer their insightful opinions.

@d-Rickyy-b - Got it! I've submitted the internal support request to get this fixed, so we'll close the duplicate GitHub issue.

#please-close


Stripe payments in node js with frontend

Describe the project you want to add with tech stack
A node web app with frontend which uses stripe payments
Expected behavior
Using this clear and concise demonstration of Stripe payments implementation in NodeJs people can take reference and build their favorite projects with easy-to-go implementation of stripe payments
I hope you will assign this issue to me so I can start working on it add it to this nice repository

Describe the project you want to add with tech stack A node web app with frontend which uses stripe payments
Expected behavior Using this clear and concise demonstration of Stripe payments implementation in NodeJs people can take reference and build their favorite projects with easy-to-go implementation of stripe payments
I hope you will assign this issue to me so I can start working on it add it to this nice repository

@pranjay-poddar please assign this issue to me


leaky bucket rate limiting does not keep order of calls

Overview/summary
Shopify API rate limiting is based on leaky bucket. However library implementation relies on very naive ‘retry’ strategy without caring about leaky bucket and requests queuing so in edge cases it can end up with serious problem, even requests that will never be called. Two cases described below :
Here is most important part of https://github.com/Shopify/shopify-node-api/blob/main/src/clients/http_client/http_client.ts#L128-L141

RestAPI
As leaky bucket is built based on number of request this is almost ok implementation but only ‘almost’. As there is no queuing just ‘setTimeout’ it is still possible that if request A fails and is waiting till for retry there is another request B that will be made just before retry of A and therefore retry of B will fail again, in edge case it can be never called. Solution is simple : there should be queue of requests, when request fails because of rate limit then it is added at the end of queue of waiting requests, and library then makes request one by one from queue.

GraphQL
Actual implementation ignores leaky bucket mechanism and, if i didn't miss anything just retries after one second. Solution would be as above queue but this time bases on the throttle status returned by graphQL API.

Motivation

What inspired this enhancement?

...
Area

[x] Add any relevant Area: <area> labels to this issue

Checklist

[x] I have described this enhancement in a way that is actionable (if possible)

Hi, thx @bogdanrn for posting this. This is issue i wanted to post but for some reason it wasnt possible, so I asked my friend @bogdan to post the issue. Can someone explain me btw is there is some limit of issues per user or am i blacklisted for some reason?

Hi @bogdanrn, @pociej thanks for posting about this! These are valid points, we are currently looking into it.
@pociej, I'm not quite sure why you wouldn't be allowed to post 🤔 we definitely don't have a limit or blacklist. Let me know if this is still an issue for you!

Hi @mllemango  any update on this?

Hi @mllemango any update?

Hey everyone, we haven't had a chance to get back to this one yet. We'll keep this issue open for others to report the same problem and that will help us prioritize.

Hey everyone, we haven't had a chance to get back to this one yet. We'll keep this issue open for others to report the same problem and that will help us prioritize.

same problem

not stale

not stale

not stale

not stale

FYI - I've managed to work around this and rate limiting concerns using a combination of ts-retry-promise and p-queue, which is working quite nicely (albeit with clumsy syntax)
I would love to see these libraries baked into the library itself so that rate limits and transient network failures aren't things that I have to concern myself with as a consumer of this library!
import { retry } from 'ts-retry-promise';
import PQueue from 'p-queue';

const shopifyRateLimitQueue = new PQueue({
  concurrency: 1, // We are allowed 2 on the basic Shopify Plan, but we don't want to exhaust the limit in case another script is running
  interval: 1000,
  throwOnTimeout: true,
  autoStart: true,
});

await retry(
  async () =>
    shopifyRateLimitQueue.add(async () =>
      product_listing.saveAndUpdate()
    ),
  {
    retries: 3,
    backoff: 'EXPONENTIAL',
    logger: console.warn,
  };
);

+1 to fix this as the current internal logic of the library is useless for all but the most basic of cases and leads developers into a false sense of trust in the library

Bumping this...


Determine minimum ruby version

We need to determine the minimum ruby version that we should support for this gem.

Ruby 2.1 will give us required keyword arguments which I really like to have in the source code.
However, Ruby 2.1 won't run the minitest that we have now, since minitest namespacing was changed in ruby 2.2.

merged #10


[5.4] Make ServiceProvider::register a non-abstract method

Sometimes service providers don't need to register anything and only use the boot method. (e.g. if your service just needs to register some event listeners)
If register isn't abstract anymore, it removes the need to implement an empty method.
The failing test is caused by a mock depending on the method. If this would get merged, how should that be resolved?

What use case is there?

Service providers that don't need to do anything in register need to implement an empty method now.
Like a service provider that only needs to subscribe to events:
<?php

namespace App\Services\Mailers;

use Illuminate\Contracts\Events\Dispatcher;
use Illuminate\Support\ServiceProvider;

class MailerServiceProvider extends ServiceProvider
{
    public function register()
    {
    }

    public function boot(Dispatcher $events)
    {
        $events->subscribe(AdminMailer::class);
        $events->subscribe(ContactFormMailer::class);
        $events->subscribe(MemberMailer::class);
    }
}

Please send to 5.3 branch.

Also I agree I have wanted this myself at times.

I'll send it over in a minute, should I do anything with the failing test?

I'll look at that when you send it. :smile:


drivers: lora: Make the SX1276 driver independent of loramac module

Problem description
The Semtech sx1276 driver currently selects the incomplete loramac-node module to be built with it. This is unnecessary as users might wish to use just the driver without the entire LoRaMAC stack. Besides, currently the loramac-node contains it's own duplicate of the sx1276 driver code which is confusing.
Proposed change
Make it so that loramac-node (through HAS_SEMTECH_LORAMAC) requires the sx1276 driver and not the other way around.

@Mani-Sadhasivam could you please let me know if that makes sense?

@KubaFYI The SX1276 driver in Zephyr is a shim driver for the one available in loramac-node repo. During my first attempt to add LoRa support, I made the SX1276 independent of the LoRAMAC stack but that was NACKed and folks asked me to use the existing work available in loramac-node. Hence, I came up with this shim driver for Zephyr.
So the Zephyr SX1276 driver should depend on the loramac-node repo. Your proposed change won't work as loramac-node repo doesn't have any dependency with Zephyr.

Thanks, understood.
May I ask what's the rationale behind taking the entirety of loramac-node code and including it as a module rather than porting it as a driver + library? I'm in a process of building a Lorawan node on zephyr and I'm trying to understand what's the best way for me to go forward.

May I ask what's the rationale behind taking the entirety of loramac-node code and including it as a module rather than porting it as a driver + library?

I'm not sure if I understand your question. Currently loramac-node is built as a library. Not all the configurations in the loramac-node is enabled atm. You can look here.

I'm in a process of building a Lorawan node on zephyr and I'm trying to understand what's the best way for me to go forward.

Cool. I'm also working on LoRAWAN support in parallel. Let me know if you want to join the effort.

I'm not sure if I understand your question.

I suppose I meant why is it a module instead of just cherry-picked files put in zephyr/lib and zephyr/drivers/lora, but that just comes from me not being that familiar with zephyr's build process and project structure.

Cool. I'm also working on LoRAWAN support in parallel. Let me know if you want to join the effort.

Grand, I'll ping you an email.


Add ability to Preserve Whitespace

There is currently no way to preserve white-space.  Ideally it would be nice if there was a way to force a cell to use xml:space="preserve", but looking at the current logic it would likely end up complicating how the fromValue function works. The only semi no kludge way would be to see if the first character is a space similar to the logic that looks to see if the first character is an equal sign for formulas.  Worse case if it is not feasible to set it cell by cell, it would be good if there was a way to do it globally on a sheet by either by adding xml:space="default" on the  tag or  tag.

like "", in CSV?

like "", in CSV?

No. The reason I ask is in case you want to indent things.


Evaluate a new blogging platform to replace Ghost

I'll add more details tomorrow, but in the meantime, here is the little presentation I wanted to use to demonstrate what we have, what need/miss and what we will gain, in this case, with Wordpress.
https://docs.google.com/presentation/d/1IlWhl0fu7EfmhBvbvMPT0BAgPdlriAd0IXaXkI6Qv4s/edit?usp=sharing

Same question as in #21 what are the key features we currently miss with Ghost that should justify the migration? :)

Same answer as #21 🤣
You can check the small presentation I created, but I'll add more details here tomorrow (was supposed to do it yesterday 😬)

This discussion is quite easy IMHO. Ghost is a great platform, but it may be too simple for our needs. It comes down to the amazing number of plugins WordPress has. Right now, I would love to add more automation, like automatically optimizing the pictures in articles (which I could do with GitHub actions), but more important, an editorial calendar integrated to our blogging platform, which will make the devrel life easier. Having this ecosystem of plugins makes us future-proof.
Day to day, it won't change how writers use the platform, and we have more chances to lower down the learning curves since WordPress is more well known.
If we have concern about the speed, I run my blog on a 5$ droplet on DO, but it's also possible to make WordPress headless.
Any other questions?

I agree Wordpress might be a better fit for Meili :)
Let's migrate as soon as we have an editorial calendar, this way we will ensure we are not migrating for the sake of changing Ghost to Wordpress. What do you think?

The idea to have an integrated calendar into Wordpress is to be able to create the editorial calendar... in Wordpress 🤣
It's not just about that, but in any cases, we will have to brainstorm the blog post ideas before I have time to get Wordpress up & running.

Some examples:

Some examples:

Some examples of sites using Wordpress that have a great design:

Obama Foundation is running on Wordpress: https://www.obama.org/
Angry Birds :rolling_on_the_floor_laughing: http://www.angrybirds.com/
Studio Ouam (super creative site, love it) http://studioouam.com/en/
Filmaker Jony Guedj http://www.jonyguedj.com/
Awesome Motive (more tradition company & website, but still classy) https://awesomemotive.com/
Artists site, full of animations and colours http://10x17.co/
Semplice, click on other pages to see the design, but I personally love any typo first type of blog, it’s clean and minimalist https://www.semplice.com/

Some examples of sites using Wordpress that have a great design:

Obama Foundation is running on Wordpress: https://www.obama.org/
Angry Birds :rolling_on_the_floor_laughing: http://www.angrybirds.com/
Studio Ouam (super creative site, love it) http://studioouam.com/en/
Filmaker Jony Guedj http://www.jonyguedj.com/
Awesome Motive (more tradition company & website, but still classy) https://awesomemotive.com/
Artists site, full of animations and colours http://10x17.co/
Semplice, click on other pages to see the design, but I personally love any typo first type of blog, it’s clean and minimalist https://www.semplice.com/

It was decided in today's company meeting to move forward with the change to Wordpress!

It was decided in today's company meeting to move forward with the change to Wordpress!

The evaluation is done, creating another issue for the technology move.


update to EIPManager to check for eip binding at a different (faster) rate when none is bound.

NetflixOSS » eureka » eureka-pull-requests #504 SUCCESS
This pull request looks good


Add key.deleteScope(scope) to remove all handlers

Removes all handlers associated with a given scope, allowing throw-away and re-usable scopes. Includes test. Adds 1 function, 8 lines of functional code, and 117 bytes to the minified version.
I took the liberty of adding a simple test for scope while I was at it.
I love how keymaster is so simple and small, I hope this addition does not constitute undue bloat.
If you're curious why I added this function: on a single-site app I'm building we want to be able to be able to switch to different "apps" with their own shortcuts. However, when we navigate away from the app it is destroyed, and a new one is created when we navigate back. Allowing us to destroy the scope of all shortcuts the app registered means we don't need to worry about callbacks to a dead app being fired (and of course the app not getting garbage-collected because the closures hold references to it). Of course, if there's another, better way to do this, I'd be happy to hear that too. Now, we can just do:
// on app open
key('n', this.appName, this.createNewItem);
// ... and other shortcuts...
key.setScope(this.appName);

// on app close
key.setScope('all');
key.deleteScope(this.appName);

+1


crash on startup

any idea what's happening here?
minecraft 1.12.2
dynamic trees 0.9.1f
https://pastebin.com/P4wRsshM

Possbile duplicate of #183. There's no point to clutter the issue tracker.

Duplicate of #183


Workfile Templates: Fix ayon core refactor usage of correct placeholder data

Changelog Description
Fix workfile templates since ayon core refactoring family -> product_type
Additional info
Fixes:
# ========
# 'family'
# ========
# Traceback (most recent call last):
#   File "E:\dev\ayon-core\client\ayon_core\pipeline\workfile\workfile_template_builder.py", line 716, in populate_scene_placeholders
#     placeholder_plugin.populate_placeholder(placeholder)
#   File "E:\dev\ayon-core\client\ayon_core\hosts\maya\api\workfile_template_builder.py", line 246, in populate_placeholder
#     self.populate_load_placeholder(placeholder)
#   File "E:\dev\ayon-core\client\ayon_core\pipeline\workfile\workfile_template_builder.py", line 1577, in populate_load_placeholder
#     for repre_entity in self._get_representations(placeholder)
#   File "E:\dev\ayon-core\client\ayon_core\pipeline\workfile\workfile_template_builder.py", line 1471, in _get_representations
#     product_type = placeholder.data["family"]
KeyError: 'family'

Fix is also present in other larger PRs, but they make take some time to get along:

#425
#330
#327
#416

This implements the fix in isolation.
Testing notes:

This should fix workfile templates in ayon core.

Resolved in https://github.com/ynput/ayon-core/pull/416


Read VTK XML binary data [vtk-read-binary]

Improve MFEM's VTK XML reader:

Read appended raw data (small modifications to tinyxml2 required)
Read appended base-64 encoded data (added base-64 decoding, may be useful for other features)
Read inline base-64 encoded data
Decompress zlib-compressed data
Extract element attributes stored as "cell data" in VTK XML meshes

See some sample meshes for variations on these features.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#2150
@pazner
@tzanio
@jandrej + @bslazarov
04/01/21
⌛due 04/15/21
⌛due 04/22/21

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

LGTM

@jandrej your LGTM failed because of the issue in mfem-uberenv that was fixed in #2151. Everything should pass now.

Tested and valgrinded - everything works as it should. Excellent work!

LGTM

Codecov Report

Merging #2150 (bb93bd7) into master (80c5c07) will decrease coverage by 0.08%.
The diff coverage is 0.50%.

@@            Coverage Diff             @@
##           master    #2150      +/-   ##
==========================================
- Coverage   61.57%   61.48%   -0.09%
==========================================
  Files         397      397
  Lines      116670   116831     +161
==========================================
- Hits        71837    71834       -3
- Misses      44833    44997     +164

Impacted Files
Coverage Δ

general/binaryio.cpp
44.73% <0.00%> (-55.27%)
:arrow_down:

general/binaryio.hpp
100.00% <ø> (ø)

general/tinyxml2.cpp
0.00% <0.00%> (ø)

general/tinyxml2.h
0.00% <0.00%> (ø)

mesh/mesh.hpp
95.77% <ø> (ø)

mesh/mesh_readers.cpp
16.72% <0.00%> (-1.87%)
:arrow_down:

mesh/mesh.cpp
65.76% <25.00%> (-0.02%)
:arrow_down:

examples/ex24p.cpp
56.37% <0.00%> (-1.24%)
:arrow_down:

miniapps/meshing/pmesh-optimizer.cpp
52.65% <0.00%> (-0.21%)
:arrow_down:

examples/ex22p.cpp
61.28% <0.00%> (+0.30%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80c5c07...bb93bd7. Read the comment docs.

@pazner, can you help with resolving the conflicts?

@pazner, can you help with resolving the conflicts?

Done.
Also, sorry for the last-minute change, but it occurred to me that a unit test for this functionality would be very helpful. I added a small one to this PR in the latest commit. It involves adding some sample meshes to tests/unit/data. Hopefully the reviewers can take a quick glance to confirm this is ok, cc:  @jandrej @bslazarov

It seems that the tests failed otherwise I like the idea.

It seems that the tests failed otherwise I like the idea.

Hopefully this is fixed now. There appears to really have been a bug that the tests caught, which I guess means that adding unit tests was the right decision :)

@jandrej, @bslazarov and @termi-official can you confirm you are OK with the latest changes?

@tzanio I will check on the weekend properly, but quickly going over the changes I think they should be fine.

I think that PR is good to go.

Merged in next for testing...


In VS Extensions gallery, it displayed that the PoshTools is installed, but there is a link "Install Now" in the InfoBar leading you to install PoshTools

Repro Steps:

Open Dev14 without installing PoshTools
Open a PS file
There is a link "Install Now" in InfoBar which will lead you to install PowerShell Tools for Visual Studio.
Open Tools->Extensions and Updates... windows and search the PowerShell Tools for Visual Studio
Verify PowerShell Tools for Visual Studio status.

Expected:
PowerShell Tools for Visual Studio is not installed.
Actual:
It displayed PowerShell Tools for Visual Studio is already installed. Please see below screenshot:

Currently by design...ish; A v0.1 is installed, so that way users are notified that it exists.  I'm Okay with 'wont-fixing' this currently.
@bmoore-msft @jinglou-  Thoughts?

from the bmp I can't tell what version was installed, but if it is an earlier version, then yes - by design.  The gold bar link will go to the gallery, not the dlg so that should help direct users.

@bmoore-msft The version installed was the 0.1 'dummy' VSIX :)  Closing this out then.  @v-hedli Please reopen if you disagree!


description for github repo

Could you please fill in the description for github repo so it was easier to search for it in the list of starred repositories?
Thanks!

Not sure if this one is still active. Please let me know what you'd like to see.


Improve support for stateless functional components

Problem description

Arrow functions and methods can not be used as SFC.
SFC and SFC names can not be used as selectors.
Hypothetically SFC could be used for any kind of hierarchical data structure, for example multi-line texts.  However, right now a non-widget return value of a SFC causes an error 'JSX: Unsupported type'.

Expected behavior
Support the cases outlined above. Create reasonably behaviors for scenarios where SFCs that return non-widgets are appended to a JSX  widget element. For functions for example they could be called with the parent. Classes could be instantiated. For promitives they could be set on the text property or create a TextView.
Environment
any
Code snippet
const text = <text trim>
  This is text that has many lines
 and also <em> markup elements</em>.
</text>;

const Label = () => <textView background='green' />;

this.append(<composite><Label/></composite>);
this.apply('Composite > Label': {background: 'red'});
this.find(Label).set({text});

Fixed except using SFC as selectors


Send additional fields from ebpf-discovery: url-scheme, domain

eBPF-discovery should send additional information in each json:

URL scheme in text format (currently only “http” or “https”)
domain (from “Host:” header) - for now, we only have the resulting IP.
If we accidentally have IP in the header, it’s ok, don’t do reverse DNS

2024-06-21 15:53:42.894 [126305] debug [ebpfdiscovery] Handling new request. (method: GET, host: example.com, url: /, X-Forwarded-For client: <IP_ADDRESS>, sourceIPv4: <IP_ADDRESS>, pid: 127614)
{"service":[{"pid":127614,"endpoint":"example.com/","externalClientsNumber":1,"domain":"example.com","scheme":"http"}]}
2024-06-21 15:54:32.148 [126305] debug [ebpfdiscovery] Handling new request. (method: GET, host: google.com:4443, url: /test/other, X-Forwarded-For client: <IP_ADDRESS>, sourceIPv4: <IP_ADDRESS>, pid: 127197)
{"service":[{"pid":127197,"endpoint":"google.com:4443/test/other","externalClientsNumber":1,"domain":"google.com","scheme":"https"}]}
2024-06-21 16:12:25.232 [126305] debug [ebpfdiscovery] Handling new request. (method: GET, host: google.com:4443, url: /test/other, X-Forwarded-For client: fe00::, sourceIPv4: <IP_ADDRESS>, pid: 134011)
{"service":[{"pid":134011,"endpoint":"google.com:4443/test/other","externalClientsNumber":1,"domain":"google.com","scheme":"https"}]}
2024-06-21 16:14:21.741 [126305] debug [ebpfdiscovery] Handling new request. (method: GET, host: google.com, url: /test/other, X-Forwarded-For client: fe00::, sourceIPv4: <IP_ADDRESS>, pid: 127614)
{"service":[{"pid":127614,"endpoint":"google.com/test/other","externalClientsNumber":1,"domain":"google.com","scheme":"http"}]}

2024-06-26 14:07:31.719 [830732] debug [ebpfdiscovery] Handling new request. (method: GET, host: google.com:4443, url: /test/other, X-Forwarded-For client: fe00::, sourceIPv4: <IP_ADDRESS>, pid: 162099)
{"service":[{"pid":162099,"endpoint":"google.com:4443/test/other","domain":"google.com","scheme":"https","externalClientsNumber":1}]}
2024-06-26 14:08:33.974 [830732] debug [ebpfdiscovery] Handling new request. (method: GET, host: google.com, url: /test/other, X-Forwarded-For client: fe00::, sourceIPv4: <IP_ADDRESS>, pid: 127614)
{"service":[{"pid":127614,"endpoint":"google.com/test/other","domain":"google.com","scheme":"http","externalClientsNumber":1}]}