Check pr

Please trigger Slow CI and make sure all tests are passing before merging this pull request.


Uncaught Error EPIPE & Osascript Makes Hyper Lagging on Ubuntu

Hyperline keep getting Uncaught Error like this below, and makes Hyper Lagging
events.js
Uncaught Error: spawn osascript ENOENT
    at exports._errnoException (util.js:1024)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:192)
    at onErrorNT (internal/child_process.js:374)
    at _combinedTickCallback (internal/process/next_tick.js:138)
    at process._tickCallback (internal/process/next_tick.js:180)

Uncaught Error: write EPIPE
    at exports._errnoException (util.js:1024)
    at WriteWrap.afterWrite [as oncomplete] (net.js:851)

Same issue on Windows 10 :(

any news about it?

problem still exists :(
I keep on getting this on :
marcin@hp:~$ uname -a
Linux hp 5.11.0-27-generic #29~20.04.1-Ubuntu SMP Wed Aug 11 15:58:17 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
marcin@hp:~$ lsb_release --all
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.3 LTS
Release:        20.04
Codename:       focal
marcin@hp:~$

this might be helpfull:
https://stackoverflow.com/questions/27688804/how-do-i-debug-error-spawn-enoent-on-node-js

Close issues, because osascript is only in MacOS, that's why there's no Linux distribution has osascript either backported into Linux distribution.

@malwareslayer - is there a solution/workaround for that ?
Shouldn't then this osascript check/use only on Macs?
The issue still exists on Linux...
moreover I do confirm it's also exist on Windows:

it seems the only env where it doesn't is Mac ...


[Twig] Add tag component

Hi,
It would be great to have the tag component
{% component %}
    Content...
{% endcomponent %}

Here is an example that @weaverryan and @kbond had made:
https://github.com/weaverryan/twig-components-poc/blob/master/templates/main/index.html.twig#L7
Thanks ;)

Agreed, this is on my radar!

Oh awesome! It's going to be so handy with that!

This awesome library is my inspiration: https://github.com/giorgiopogliani/twig-components
"embedded components" is what I've been calling this.

One of the idea for me is to transcribe this repository https://github.com/seanpdoyle/stimulus_aria_widgets with Twig Component.
For instance https://github.com/seanpdoyle/stimulus_aria_widgets#combobox has 1 helper and 3 targets which generate different attributes.

@kbond Did you have time to explore the idea? 😄

Hi guys ! I really like the idea ! And I will be happy to contribute ! So what's your current state on this idea ? How do you wan't to processed, to make it real ? 😁

@seb-jean, not yet - was hoping to pick this back up again soon.
@WebMamba, if your willing to get started on this, that would be great. What I was hoping to do was port https://github.com/giorgiopogliani/twig-components over (the slots and embedded component stuff) but with the component class injected (as this) just like the current component() function.

Thanks @kbond

Started working on this over in #317. Not exactly what I envisioned but the internals of twig are complex!
I didn't end up using anything from https://github.com/giorgiopogliani/twig-components. Instead I modeled the feature after twig's native embed tag. It's basically an embed tag with access to the component and attributes. The benefit of this is it uses twig's native block tag for the slots. This allows calling parent() in your embedded component slot. The downside is, there is no concept of a default slot like in @giorgiopogliani's library. Maybe there is a way to achieve but I got stuck in the weeds and gave up :).


CI fails randomly

It seems like CI randomly fails. There appear to be two kinds of failure:

Failure to receive compiled bitcoind and/or simulator/emulator
Test times out

It seems like we can solve 1 by more aggressively using docker containers which contain bitcoind and simulators/emulators rather than building these as a separate job and relying on Cirrus to cache things properly. However my concern with doing that is that the built bitcoind and simulators/emulators will not always be updated to the current latest versions of each.
For tests timing out, we need to investigate why these are timing out to figure out how they can be fixed. So far, it seems like the Trezor 1 tests time out the most, but I have seen at least one test time out for each of the devices too, so this likely isn't a device issue.

Haven't seen random CI failures recently


Rewrite for Riak 2.0 feature support

We have completely rewritten the library from the ground up with a focus on simplicity of the developer API and portability by having its only dependency be the PHP cURL extension. The rewrite is currently only compatible with Riak's HTTP interface.
Using a simple benchmarking tool, we have identified an increase in write operations per second of over 10% and a decrease in fetches of 2.5% compared to the old codebase of this library. The output is below but please note that actual performance for you may vary based on MANY variables. This benchmarks were run using PHP v5.4.39 with Xdebug disabled.
[vagrant@localhost riak-clients-performance-comparison]$ ./vendor/bin/athletic -p src/RiakClientPerformanceComparison

RiakClientPerformanceComparison\FetchObjectEvent
    Method Name                 Iterations    Average Time      Ops/second
    -------------------------  ------------  --------------    -------------
    fetchUsingBashoRiakHttp  : [10,000    ] [0.0025948997021] [385.37135]
    fetchUsingBashoRiak2Http : [10,000    ] [0.0026617594481] [375.69135]

RiakClientPerformanceComparison\StoreObjectEvent
    Method Name                 Iterations    Average Time      Ops/second
    -------------------------  ------------  --------------    -------------
    storeUsingBashoRiakHttp  : [10,000    ] [0.0045337545395] [220.56774]
    storeUsingBashoRiak2Http : [10,000    ] [0.0040378854275] [247.65438]

Tests seem to pass:
PHPUnit 4.5.1 by Sebastian Bergmann and contributors.

Configuration read from /Users/hazen/dev/clients/php/mancini/phpunit.xml

...............................................................  63 / 125 ( 50%)
..............................................................

Time: 20.08 seconds, Memory: 9.50Mb

OK (125 tests, 1357 assertions)```

Tests pass for me on PHP 5.6 on OS X 10.10.


Version release handling

As we create more and more release, we may miss the latest release (we currently list 200 in the script). I don't know how the results are ordered when querying the API. If it's chronological, we're fine. But I've already seen some versions being missed, so I suspect it's not...
We may want to delete releases on a regular basis to clean them up, once https://github.com/slsa-framework/example-package/issues/34 is resolved

This is resolved.

We currently paginate through all releases using gh  api --method GET "/repos/$GITHUB_REPOSITORY/releases" --paginate
We delete old releases daily: schedule.delete-old-releases.yml


Rails Init Template Versions

We currently ask users to use the template on the master branch when calling rails new. This probably won't work in the long run; e.g. if I'm installing a Hyrax 1.0 alpha a year from now, it's unlikely that the template on master will still be acceptable. Can we communicate a better versioning scheme for these templates in the README?
Rationale
I'm writing up a playbook documenting best practices for starting a new hyrax project and don't want to reproduce--or even link to--a fragile bit of documentation.

Why would anyone use a template to install a version less than the most recent major? That seems implausible to me. I don't want to invent more process without a realistic use case

Why would anyone use a template to install a version less than the most recent major?

The current case has us only installing the most recent master, not the most recent major. This is the state of affairs I'm concerned about.

Doesn't the most recent template install 1.0.0.rc1?

Yes. However, it contains code that is subject to change independent of version releases.
If there's a general policy that the master template cannot change until a new version is released, I guess the risk is minimal. Otherwise, any maintenance to the template code may break installation, yes?
It seems like directing users to install a tagged version of the file would be more stable and more flexible. If that's wrong, feel free to close it.

@no-reply Is this the same thing we've been kicking around in https://github.com/projecthydra-labs/hyrax/issues/492?

Looks like. Closing as duplicate of #492.
Thanks @mjgiarlo and @jcoyne.

@no-reply do toss a comment on #492 to reflect your druthers, pls! I'd like to wrap that issue up soon.


cryptocoin daemon, where to get it?

Installation readme is speaking about "cryptocoin daemon" but i dont know what it is and where to get it.
Thank you

https://en.bitcoin.it/wiki/Bitcoind
2016-02-23 22:29 GMT+01:00 slrslr<EMAIL_ADDRESS>
Installation readme is speaking about "cryptocoin daemon" but i dont know
what it is and where to get it.
Thank you
—
Reply to this email directly or view it on GitHub
https://github.com/Crypton33/CryptoPonzi/issues/14.

--
Pozdrawiam
Mateusz Pawlica


Minor: Improve aggregate test coverage more

Which issue does this PR close?
Follow on to https://github.com/apache/arrow-datafusion/pull/6939
Related to https://github.com/apache/arrow-datafusion/issues/6889
Rationale for this change
I almost merged code that had incorrect aggregate null handling and the tests didn't catch it
This is my attempt to improve coverage
What changes are included in this PR?
Add some more tests of aggregates (several types were missing coverage with GROUP BY). I'll comment inline
Are these changes tested?

Are there any user-facing changes?

And this found a bug https://github.com/apache/arrow-datafusion/issues/6955 🎉

I think this is important coverage to add so I am merging it in


Vite plugin incompatible with vite-plugin-react-swc

I get the message Beyond: Can't find the component/id map. Did you forget to install the react-beyond/plugin/vite plugin?.
As far as I can tell, the plugin isn't being initialized properly because the regex in here does not catch the import which for some reason is slightly different in vite-plugin-react-swc than it is in vite-plugin-react:
    // vite-react-beyond.ts
    transform(code, id) {
      if (!hmr) return code

      return code.replace(
        /(import RefreshRuntime from "\/@react-refresh")/,
        '$1; window.__REFRESH_RUNTIME__ = RefreshRuntime'
      )
    },

It looks for import RefreshRuntime from "/@react-refresh", but it turns out that  for some reason, the swc-version of the plugin instead does import * as RefreshRuntime from "/@react-refresh".
See https://github.com/vitejs/vite-plugin-react-swc/blob/b829b03f6476bed60ff5535fe883abc1b0b4e095/src/index.ts#L153
I could monkey-patch that by just removing the initial "import " from the regex to get the transform to work.
Next issue was that the code that hooks into the RefreshRuntime doesn't seem to do anything.
As far as I can tell the RefreshRuntime object is setup a different way in the SWC plugin, so I'm not sure how easy it would be to add compatibility.

Thanks very much for the findings! I'll have a look at this plugin.


Get card type?

Is there a way to get the type of card that has been entered?  For example, once the user has typed in their credit card information, is there an event or something to tell if it is a visa, mastercard, etc.?

This isn't supported by card, but you can use Payment (which is already bundled) to get the card type.


How I can use QuerySelectorAllAsync for iFrame?

Your question
Hello:
I can use QuerySelectorAllAsync to get a collection of elements for a web page without iframe.
However, now I have to parse a HTML table inside a iframe, there are a lot of table rows, which has the 'tr' elements.
If I use
var iframe = page.FrameLocator("#frameID");
then, how I can get all the table rows, those element has with 'tr' attribute?
I can't find any example on this topic.
For the web page without iframe, I can use the following statement:
var trs = await page.QuerySelectorAllAsync("tr.class");
But in iframe, how I can return a collection of elements?
Please advise,
Thanks,

Essentially this would mean that you want to loop over the rows (tr) and then over the columns td. This guide should help you with that: https://playwright.dev/dotnet/docs/locators
We discourage using QuerySelector/All, see here: https://playwright.dev/dotnet/docs/locators#locator-vs-elementhandle

OK. Thanks!


Documentation migrated to zipkin.io (repo openzipkin.github.io)

1,971 deletions

Be advised, after this is merged, I'll also delete the gh-pages branch (it was built from content deleted in this PR)

:shipit: thanks for the help!

Looks like this might have broken the README.md file on Github...  I guess we could simply hotlink the images.

Ouch. I should've noticed that, sorry. Could hot-link, but that'll break and be even harder to notice. I'll pull that image back.


Determining optimal number of clusters

Is there a way to determine the most optimal number of clusters?

In my opinion, no, because the definition of cluster quality is subjective and domain specific. You'll need to run TICC multiple times to get different assignments and see which works best for you. I've done this with different values of number_of_clusters and then compared how they break down .. to some extent comparable to hierarchical clustering. When interval boundaries started to change just from adding more clusters I concluded that it was overfitting.
This little tool might be useful to illustrate your cluster assignments: https://gpcrviz.github.io/ChangePointDetection/DisplayIntervals/


Not Working with All files

Cannot listen txt or pdf files

Likely related to files not working right now. A fix is available here https://github.com/KasemJaffer/receive_sharing_intent/pull/201. You can use it like this in your pubspec.yaml.
receive_sharing_intent:
  git:
    url: https://github.com/reynirf/receive_sharing_intent
    ref: patch-1

@Baxter92 Did you resolve this? I am facing the same issue.
@simonbengtsson  I have added your solution but still facing the same issue.
Any solution?

I believe so. Unsure exactly how but you can take a look at the app code if it helps
https://github.com/simonbengtsson/airdash


Add ResourceGroup CRD installation as pre-step for kpt live apply

Adds ResourceGroup custom resource definition as a pre-step for kpt live apply

https://github.com/GoogleContainerTools/kpt/pull/1282


[ko] Translate docs/concepts/overview/working-with-objects/finalizers.md into Korean

This is a Feature Request

What would you like to be added

Translate docs/concepts/overview/working-with-objects/finalizers.md into Korean.

Page: https://kubernetes.io/docs/concepts/overview/working-with-objects/finalizers/
File: https://github.com/kubernetes/website/blob/main/content/en/docs/concepts/overview/working-with-objects/finalizers.md

Why is this needed
This has not been translated into Korean yet.
Comments

/assign
/language ko

@kyungjin99 감사합니다!
/triage accepted

Resolved by

#35822
#36804
#36810

/close


Issue/4323 e2e scenario 2.4

Description

Short description here *

closes #4323
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Code is clear and sufficiently documented
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Processing this pull request

Merged into branches iso5, master, iso6 in f30f727eb3cb75e92ff34b8dd64c01802788b2d4


Crashes when an invalid (?) time filter is chosen

I tried to type "2014-2015" into the Time filter. It would be nice if that format worked (sneaking in a feature request here!), but given that it doesn't, I get an error:
http://localhost:5000/account/Assets:Bank:BankNane/monthly_balances/?filter_time=2014-2015
builtins.TypeError
TypeError: 'NoneType' object is not iterable

Traceback (most recent call last)
File "/usr/lib/python3.4/site-packages/flask/app.py", line 1836, in __call__
return self.wsgi_app(environ, start_response)
File "/usr/lib/python3.4/site-packages/flask/app.py", line 1820, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/usr/lib/python3.4/site-packages/flask/app.py", line 1403, in handle_exception
reraise(exc_type, exc_value, tb)
File "/usr/lib/python3.4/site-packages/flask/_compat.py", line 33, in reraise
Open an interactive python shell in this frameraise value
File "/usr/lib/python3.4/site-packages/flask/app.py", line 1817, in wsgi_app
response = self.full_dispatch_request()
File "/usr/lib/python3.4/site-packages/flask/app.py", line 1477, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/lib/python3.4/site-packages/flask/app.py", line 1381, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/usr/lib/python3.4/site-packages/flask/_compat.py", line 33, in reraise
raise value
File "/usr/lib/python3.4/site-packages/flask/app.py", line 1473, in full_dispatch_request
rv = self.preprocess_request()
File "/usr/lib/python3.4/site-packages/flask/app.py", line 1666, in preprocess_request
rv = func()
File "/usr/lib/python3.4/site-packages/beancount_web-0.1.0a2-py3.4.egg/beancount_web/application.py", line 250, in perform_global_filters
payees=app.entry_filters.get('payees', set()).copy())
File "/usr/lib/python3.4/site-packages/beancount_web-0.1.0a2-py3.4.egg/beancount_web/api.py", line 238, in filter
self.apply_filters()
File "/usr/lib/python3.4/site-packages/beancount_web-0.1.0a2-py3.4.egg/beancount_web/api.py", line 207, in apply_filters
begin_date, end_date = parse_date(self.filters['time_str'])
TypeError: 'NoneType' object is not iterable
The debugger caught an exception in your WSGI application. You can now look at the traceback which led to the error.
To switch between the interactive traceback and the plaintext one, you can click on the "Traceback" headline. From the text traceback you can also create a paste of it. For code execution mouse-over the frame you want to debug and click on the console icon on the right side.

You can execute arbitrary Python code in the stack frames and there are some extra helpers available for introspection:

dump() shows all variables in the frame
dump(obj) dumps all that's known about the object
Brought to you by DON'T PANIC, your friendly Werkzeug powered traceback interpreter.

This is basically a duplicate of #31 which I'll work on, but I'm quite busy right now, so it might take a few days before I get the time.
On the format: 2014 - 2015 will work. The spaces around the - are important, as this makes parsing the date simpler. Otherwise there can be confusion between - in a date or a range. Although it might be nice to remove this distinction.

Good to know ranges already work!

I close this issue as @yagebu will fix it in #31


[bug] project name is empty in inherited tasks unless explictly defined

Describe the bug
I have to explicitly define the project name for it to be available in the inherited tasks
Expected behavior
For it to use the project's folder name as the project name in inherited tasks

@marcus-sa I don't really follow. Do you have an example config that isn't working?

@milesj

.moon/tasks/typescript.yml

tasks:
  test:
    command: 'echo $projectName'

Assume you have a project that inherits the test task and you run that command:
$ moon project:test

The output will be empty, whereas if you explicitly define the project name then it'll no longer be empty

project/moon.yml

project:
  name: project

@marcus-sa I think you just want $project?
$projectName maps to project.name which is human-readable metadata, not the actual ID of the project.

@milesj yeah you're right. The docs is a bit confusing.

@marcus-sa I think you just want $project?
$projectName maps to project.name which is human-readable metadata, not the actual ID of the project.

Yeah, you're right. The documentation is a bit confusing. I'm also wondering why $projectName is empty in one scenario and not the other?

Well project.name is empty by default unless explicitly configured.
The "folder name" logic is only for the project ID.

@milesj very confusing

$project = the project ID. The thing configured in projects in workspace.yml, and the thing used on the command line, and in task targets: moon project app, moon run app:lint. Here app is the ID.
$projectName = a human readable string derived from project.name in moon.yml. This is purely metadata for developers, and is only shown in moon project right now. It was added for a project/code ownership feature that never released.
An example in config:
# moon.yml

id: 'api'

project:
  name: 'Dashboard REST API'
  description: 'Primary REST API for the dashboard.'
  channel: '#dashboard-api'


fixed incorrect if case

!typeof token == "string"

means (!typeof token) == "string". typeof something always returns a non-empty string, so !typeof something will always be false since ! is negating it (turning it into a boolean)
false == "string" can never be true, so this'll always be false
instead what should've been used was
typeof token !== "string"

check if the typeof the token isn't string

Thank you


Updating versions.tf with newrelic provider source as 'newrelic/newrelic'

With the existing versions.tf , we are facing following error, while trying to execute 'terraform init'
Could not retrieve the list of available versions for provider hashicorp/newrelic: provider registry registry.terraform.io does not have a provider named
│ registry.terraform.io/hashicorp/newrelic
│
│ Did you intend to use newrelic/newrelic? If so, you must specify that source address in each module which requires that provider.
Hence updating the newrelic provider source to 'newrelic/newrelic' in versions.tf

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @Nagarajantv


Update CASA testing versions

We're encountering a python 3.6 setup issue in #809. Given support is now dropped for py37, and CASA >6.4 uses python 3.8, we can probably start dropping the 3.6 testing and support.

:+1: let's drop py36


Latest Alpha19 throws console warnings

Current behavior
22[Violation] 'setTimeout' handler took <N>ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 68ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 57ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 55ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 73ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 62ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 53ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 53ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 59ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 56ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 57ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 52ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 52ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 67ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 58ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 50ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 55ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 53ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 50ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 59ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 54ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 50ms
hovercard-anchor.js:54 [Violation] 'setTimeout' handler took 52ms
[Violation] Forced reflow while executing JavaScript took 30ms

My goal is that the MenuBar never steals focus from the page, I don't know if it is related.


Other games pzz files

The pzz format is also used in the Gundam Seed OMNI vs ZAFT2 game made by Capcom, the same company as Jojo.
Is it possible to support Gundam Seed OMNI vs ZAFT2's pzz files?
pl00.pzz
https://drive.google.com/file/d/1z1tnZibtSa134ko28FnMuEdUeK2Mftbg/view?usp=sharing

The pzz format is also used in the Gundam Seed OMNI vs ZAFT2 game made by Capcom, the same company as Jojo. Is it possible to support Gundam Seed OMNI vs ZAFT2's pzz files?
pl00.pzz https://drive.google.com/file/d/1z1tnZibtSa134ko28FnMuEdUeK2Mftbg/view?usp=sharing


Feature:   Add validation in fields of  Get a book form

Feature description
JS validation add in form to enhance user experience
Validation add for empty field
validation add for contact number
if any error occurs error message show below of that field
highlighted that field by red bottom border

@rohanbabbar04 I would like to work on it under GSSOC'23 .Please assign this to me.
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Sure go for it


Is this github has ACTE ABR algorithm implementation , can any one say which file has implementation code

For the code: Please refer to dash.js repo (https://github.com/Dash-Industry-Forum/dash.js/) which comprises our LoLp latest code (https://github.com/Dash-Industry-Forum/dash.js/tree/development/src/streaming/rules/abr/lolp).
Wiki: https://github.com/Dash-Industry-Forum/dash.js/wiki/Low-Latency-streaming


refactor compute

WARNING! This is a breaking change!

Refactor compute functions to use a new interface (ComputeAlgorithm) instead of passing 4-5 params to different functions.
add new test to prevent running a computeJob is both asset/algo are having compute services and they are not served from the same provider

cool, only 1 merge conflict after the big merging spree. So PR needs a merge or rebase against main to resolve conflict


HTML import fails silently on Safari 11

Steps to Reproduce
Use polymer-cli to create a new polymer starter kit app
Comment out lazy import and import my-view in my-app.html like so:
<link rel="import" href="my-view1.html">
<!-- <link rel="lazy-import" href="my-view1.html"> -->

polymer serve - you should get 404 on the homepage using Safari. Navigating to another page and coming back to view 1 should make it work. Refresh to break it again.
Expected Results
Consistent behavior. Works fine on Chrome & Firefox.
Actual Results
404 page on safari using polymer cli starter kit
Browsers Affected

✅  Chrome (62.0.3202.75)
✅  Firefox (56.0.2)
❌  Safari (11.0 (136<IP_ADDRESS>.6))

Versions

polymer 2.2.0
webcomponentsjs 1.0.17

That's pretty odd... Especially since the lazy-imports are just there to appease the linter.
I think the importHref call is erroring here because the import link already exists in the document. I'm not sure why it only happens on Safari.
If you insert a breakpoint and step through this with the debugger, you'll see the correct page being displayed, then the 404 page after the importHref error callback is invoked.
@azakus @sorvell any clue why this would happen?

Any new about this ?
Does anyone can suggest a workaround ?

The workaround is to either a) not add the <link rel="import"> or b) not call importHref on the import that you've statically imported.


error-chain deprecation

Hey, error-chain's maintainer here.
I have not been as active on error-chain maintenance as I should have (cf all the issues and PR). I'm also working less with Rust these times (I keep an eye on it though). Since it's not perfect anyway (https://github.com/rust-lang-nursery/error-chain/issues/190) and failure is an improvement on error-chain, I guess the best way to go would be to deprecate it and go full failure. It could be done with the 1.0 failure release.
I see a few points that should be solved before the full deprecation:

The doc should include a part about the transition from error-chain. I'm thinking something like "if you do this in error-chain, replace it by that in failure.
We need to be sure that every feature from error-chain is supported by failure.

Do you think of it?
Not sure who should be included in this discussion.

Hi. Thanks for your update.

We need to be sure that every feature from error-chain is supported by failure.

I think the biggest problem I see with this, is that the paradigms of both crates are a bit different, and in general going from error-chain to failure has involved rethinking my error handling. What's usually happened when using error-chain for me is that I end up creating ErrorKind enums with lots of variants for all possible foreign error types, so I can use try!/? everywhere, and when I port it to failure usually I only keep variants for semantic groups of errors and sometimes even box the errors. Because unlike error-chain no From conversions are implemented by failure. Instead the idea is to either map the error before trying or write your own From conversion, or if you don't care return an Error struct. (But it might be possible that I got something wrong, so please take my words with a grain of salt, I'm not involved in the development of either crate.)
My personal experience is that failure leads me to writing cleaner error handling, however I have yet to try how well it proves for debugging. Because on of the biggest selling points of error-chain for me has always been, use it everywhere (which is really easy) and you will get backtraces everywhere when you need them.

Yeah, I didn't mean a 1-1 feature mapping. I meant that the use-cases are covered.

Should this discussion be revisited now that the path forward for failure is a little clearer and @mitsuhiko has taken over active ownership?

I feel like the issue here is now more complex as error is now being fixed in the stdlib so it's not even clear what the failure story is going to be going forward.


Tests' dependencies

:tada: This PR is included in version 0.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Azure Search] Index package uploads

Today, the only way to index documents into Azure Search is manually through the ad hoc tool. Newly uploaded packages should be indexed automatically.

Done


Get certificates and implement signing for Medplum Agent binaries on Windows

Agent is currently unsigned which can result in warnings during install, download etc.
This issue is tracking the process of getting the right certificates and process to get the binaries signed to prevent those warnings.   Some options for the process are outlined in the Agent Github Discussion

Fixed in https://github.com/medplum/medplum/pull/3381


Add component status filters, hacbs merge status

Fixes
Fixes https://issues.redhat.com/browse/HACBS-822
Description
As a user, I should be able to view the status of the components and filter the components based on it. If there are no builds triggered yet, an Alert should be present in the component tab.
Type of change

[x] Feature
[ ] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review

How to test or reproduce?
Navigate to the components details list view
Browser conformance:

[x] Chrome
[x] Firefox
[x] Safari
[x] Edge

@jeff-phillips-18
As discussed on Slack, missing the Filters bar that pops up when the filter is enabled.
See the pipeline run list design @MariaLeonova created.
We can mark this as a bug if time is of the essence, but I suspect we want to solve this for both here and the pipeline run list.
@MariaLeonova FYI

@Ranelim I added the filter bar:

/assign @christianvogt

@christianvogt @karthikjeeyar Updated. PTAL.

@Ranelim @itsptk Updated filter bar:

/approve
/lgtm

Thanks @karthikjeeyar
Fixed. Rebased, and squashed.

/lgtm


Fluent cannot compile code for session.project.save_as

🔍 Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

🐞 Description of the bug
session.project.save_as(project_filepath=proj_path) gives the following error:
RuntimeError: Unable to compile python code:
Error Object: ()
This is only reproducible for Fluent 23.1. 22.2 works fine.
📝 Steps to reproduce
Requirements (develop versions):
ansys-fluent-core
ansys-fluent-parametric
Set environment variables:
PYFLUENT_FLUENT_ROOT = %AWP_ROOT231%\fluent
Enter the following in a python interpreter:
import os
from pathlib import Path
import shutil
import ansys.fluent.core as pyfluent
from ansys.fluent.core import examples
from ansys.fluent.parametric import ParametricSession, ParametricSessionLauncher, ParametricProject, ParametricStudy, DesignPoint
Step1: Read flprz
Launch Fluent in 3D and double precision
temporary_resource_path = os.path.join(
pyfluent.EXAMPLES_PATH, "test_parametric_project_resources"
)
if os.path.exists(temporary_resource_path):
shutil.rmtree(temporary_resource_path, ignore_errors=True)
if not os.path.exists(temporary_resource_path):
os.mkdir(temporary_resource_path)
flprz_filename = examples.download_file(
"project-elbow-param.flprz", "pyfluent/mixing_elbow"
)
session = ParametricSession(
project_filepath=flprz_filename,
launcher=ParametricSessionLauncher(precision="double", processor_count=2),
)
Save project
proj_path = str(
Path(temporary_resource_path) / "project-elbow-param.flprj"
)
session.project.save_as(project_filepath=proj_path)
💻 Which operating system are you using?
Windows
🐍 Which Python version are you using?
3.10
📦 Installed packages
ansys-fluent-core
ansys-fluent-parametric

Same issue here on Windows, works fine on Linux

Probably related, failing on GitHub:
Calling solver_session.file.parametric_project.save_as(), results in
RuntimeError: Failed to save the project
Error Object: #f

https://github.com/ansys/pyfluent-parametric/actions/runs/6239679282/job/16938116145?pr=237
https://github.com/ansys/pyfluent-parametric/actions/runs/6238517356/job/16934511115
https://github.com/ansys/pyfluent-parametric/actions/runs/6239350946/job/16937115443
gRPC call that fails is:
DEBUG    pyfluent.networking:interceptors.py:43 GRPC_TRACE: rpc = /ansys.api.fluent.v0.settings.Settings/ExecuteCommand, request = {'pathInfo': {'root': 'fluent', 'path': 'file/parametric-project'}, 'command': 'save-as', 'args': {'valueMap': {'m': {'project-filename': {'string': '/home/runner/.local/share/ansys_fluent_core/examples/parametric_workflow_resources/static_mixer_study.flprj'}}}}}

Note this does not fail locally when I test it using Linux, but it does fail on GitHub, and also when using Windows


feat: Improve code to check values for null or undefined.

Is your feature request related to a problem? Please describe.
First of all, I apologize for my poor English.
This is a code improvement proposal, not a feature improvement.
Describe the solution you'd like
I think the following code section can be substituted with the code I propose.
value === null || value === undefined
My Proposal:
value == null
By using the 'equivalence operator', it should be possible to inspect only null and undefined together.
Describe alternatives you've considered
Existing Code
value === null || value === undefined
My Proposal:
value == null
Additional context

If the points I make are good ones, may I make a pull request?

If the points I make are good ones, may I make a pull request?

Currently, the eslint rules used by the repo are enforcing value === null || value === undefined. This is to prevent an edge case of document.all:
document.all === undefined
// false
document.all === null
// false
document.all == null
// true

If the points I make are good ones, may I make a pull request?

Currently, the eslint rules used by the repo are enforcing value === null || value === undefined. This is to prevent an edge case of document.all:
document.all === undefined
// false
document.all === null
// false
document.all == null
// true

Hmm, interesting. Thanks Sukka!

Hmm, interesting. Thanks Sukka!

I am considering re-visit this. If == null is fast enough, we should disable that eslint rule (while nobody uses docuemnt.all now).

Hmm, interesting. Thanks Sukka!

I am considering re-visit this. If == null is fast enough, we should disable that eslint rule (since nobody uses docuemnt.all now).

I was gonna implement this fix in one of my PRs where ai was upgrading dependencies. I think I sort of lost track of it then.

Hmm, interesting. Thanks Sukka!

I am considering re-visit this. If == null is fast enough, we should disable that eslint rule (since nobody uses docuemnt.all now).

So, @nojiritakeshi can handle it then?

I am considering re-visit this. If == null is fast enough, we should disable that eslint rule (since nobody uses docuemnt.all now).

So, @nojiritakeshi can handle it then?

We will need to do some benchmarks on this, to see if changing to == null is really worth it.

We will need to do some benchmarks on this, to see if changing to == null is really worth it.
Would you like me to join you in checking?

We will need to do some benchmarks on this, to see if changing to == null is really worth it.

Would you like me to join you in checking?

Sure, of course!

We will need to do some benchmarks on this, to see if changing to == null is really worth it.

Would you like me to join you in checking?

Sure, of course!

Awesome!

By the way, I modified the code of block.ts and measured the speed with block.test.tsx with the following results.
Before correction:

case: should ignore null, undefined, false: 0.404
case: should ignore null, undefined, false: 0.0321
case: should patch block: 0.123
case: should patch block: 0.0238
case: should patch nested blocks: 0.0860

After correction:

case: should ignore null, undefined, false: 0.362
case: should ignore null, undefined, false: 0.0353
case: should patch block: 0.201
case: should patch block: 0.0281
case: should patch nested blocks: 0.0545

More research may be needed, but there may not be much to worry about in terms of speed.(?)

Will be updated in a PR for a bigger change soon, closing


Where is the proxy configuration in webpack-dev-service ?

proxy: {
  "/mock/86/api/v1": {
    target: "http://<IP_ADDRESS>:7080",
    changeOrigin: true
  }
},

We're not using webpack-dev-service


Add "Contribution" section to root README

We need to update the root README.md to include a "Contribution" section detailing the expectations on PRs and project coordination, taking guidance from existing CORTX repositories as available.

For the convenience of the Seagate development team, this issue has been mirrored in a private Seagate Jira Server: https://jts.seagate.com/browse/EOS-28449. Note that community members will not be able to access that Jira server but that is not a problem since all activity in that Jira mirror will be copied into this GitHub issue.

Richard Osowski commented in Jira Server:

Added CONTRIBUTING.md to the cortx-k8s repo.

Resolved via https://github.com/Seagate/cortx-k8s/pull/96

Richard Osowski commented in Jira Server:

Resolved via GitHub

Richard Osowski commented in Jira Server:

Fixed and verified.


1241 geglxinfo will process all meshes in a terrain packet

#1241 These changes update geglxinfo to process all meshes in a terrain packet.  Prior to this PR only the first mesh in a terrain packet would be processed.
Testing:

Build and run geglxinfo against a portable globe that contains terrain data with the --extract_packets parameter.  The terrain packets will be written under the directory globetiles/1/.
Verify that the terrain files written contain all the mesh entries for each packet.

Also tested and saw terrain packets with all meshes.


Fix: Fix unicode char in toc

Related in hyperref and loading accents topic, add unicode flag in hyperref option for unicode support.

Indeed... As we move on to LuaLaTeX, we have to change that.

@Karnaj This trouble occurs on all engines. The problem is due to hyperref that not support unicode by default.

Yep, I already had the same issue with french texts.


split tunnel not working

When I connect to the split tunnel udp VPN, nothing is blocked. not sure what im doing wrong.
Log from openVPN:
Thu Apr 02 23:12:19 2020 OpenVPN 2.4.8 x86_64-w64-mingw32 [SSL (OpenSSL)] [LZO] [LZ4] [PKCS11] [AEAD] built on Oct 31 2019
Thu Apr 02 23:12:19 2020 Windows version 6.2 (Windows 8 or greater) 64bit
Thu Apr 02 23:12:19 2020 library versions: OpenSSL 1.1.0l  10 Sep 2019, LZO 2.10
Thu Apr 02 23:12:19 2020 MANAGEMENT: TCP Socket listening on [AF_INET]<IP_ADDRESS>:25341
Thu Apr 02 23:12:19 2020 Need hold release from management interface, waiting...
Thu Apr 02 23:12:20 2020 MANAGEMENT: Client connected from [AF_INET]<IP_ADDRESS>:25341
Thu Apr 02 23:12:20 2020 MANAGEMENT: CMD 'state on'
Thu Apr 02 23:12:20 2020 MANAGEMENT: CMD 'log all on'
Thu Apr 02 23:12:20 2020 MANAGEMENT: CMD 'echo all on'
Thu Apr 02 23:12:20 2020 MANAGEMENT: CMD 'bytecount 5'
Thu Apr 02 23:12:20 2020 MANAGEMENT: CMD 'hold off'
Thu Apr 02 23:12:20 2020 MANAGEMENT: CMD 'hold release'
Thu Apr 02 23:12:20 2020 Outgoing Control Channel Encryption: Cipher 'AES-256-CTR' initialized with 256 bit key
Thu Apr 02 23:12:20 2020 Outgoing Control Channel Encryption: Using 256 bit message hash 'SHA256' for HMAC authentication
Thu Apr 02 23:12:20 2020 Incoming Control Channel Encryption: Cipher 'AES-256-CTR' initialized with 256 bit key
Thu Apr 02 23:12:20 2020 Incoming Control Channel Encryption: Using 256 bit message hash 'SHA256' for HMAC authentication
Thu Apr 02 23:12:20 2020 TCP/UDP: Preserving recently used remote address: [AF_INET]<IP_ADDRESS>:1194
Thu Apr 02 23:12:20 2020 Socket Buffers: R=[65536->65536] S=[65536->65536]
Thu Apr 02 23:12:20 2020 UDP link local: (not bound)
Thu Apr 02 23:12:20 2020 UDP link remote: [AF_INET]34.7--.---.---.--:1194    <-hidden for privacy
Thu Apr 02 23:12:20 2020 MANAGEMENT: >STATE:1585887140,WAIT,,,,,,
Thu Apr 02 23:12:20 2020 MANAGEMENT: >STATE:1585887140,AUTH,,,,,,
Thu Apr 02 23:12:20 2020 TLS: Initial packet from [AF_INET]34.7---.--.--.-:1194, sid=efd40773 79a619b5         <-hidden for privacy
Thu Apr 02 23:12:20 2020 VERIFY OK: depth=1, CN=ChangeMe
Thu Apr 02 23:12:20 2020 VERIFY KU OK
Thu Apr 02 23:12:20 2020 Validating certificate extended key usage
Thu Apr 02 23:12:20 2020 ++ Certificate has EKU (str) TLS Web Server Authentication, expects TLS Web Server Authentication
Thu Apr 02 23:12:20 2020 VERIFY EKU OK
Thu Apr 02 23:12:20 2020 VERIFY X509NAME OK: CN=instance-1_df3e--------de-b804-c71989b978b1
Thu Apr 02 23:12:20 2020 VERIFY OK: depth=0, CN=instance-1_df3e-----------804-c71989b978b1
Thu Apr 02 23:12:20 2020 WARNING: 'link-mtu' is used inconsistently, local='link-mtu 1549', remote='link-mtu 1550'
Thu Apr 02 23:12:20 2020 WARNING: 'comp-lzo' is present in remote config but missing in local config, remote='comp-lzo'
Thu Apr 02 23:12:20 2020 Control Channel: TLSv1.2, cipher TLSv1.2 EC----------AES256-GCM-SHA384, 256 bit EC, curve: prime256v1
Thu Apr 02 23:12:20 2020 [instance-1_df--------------------1989b978b1] Peer Connection Initiated with [AF_INET]<IP_ADDRESS>:1194
Thu Apr 02 23:12:21 2020 MANAGEMENT: >STATE:1585887141,GET_CONFIG,,,,,,
Thu Apr 02 23:12:21 2020 SENT CONTROL [instance-1_df3-----------------4-c71989b978b1]: 'PUSH_REQUEST' (status=1)
Thu Apr 02 23:12:21 2020 PUSH: Received control message: 'PUSH_REPLY,dhcp-option DNS <IP_ADDRESS>,block-outside-dns,compress lz4-v2,route-gateway <IP_ADDRESS>,topology subnet,ping 15,ping-restart 120,ifconfig <IP_ADDRESS> <IP_ADDRESS>,peer-id 0,cipher AES-256-GCM'
Thu Apr 02 23:12:21 2020 OPTIONS IMPORT: timers and/or timeouts modified
Thu Apr 02 23:12:21 2020 OPTIONS IMPORT: compression parms modified
Thu Apr 02 23:12:21 2020 OPTIONS IMPORT: --ifconfig/up options modified
Thu Apr 02 23:12:21 2020 OPTIONS IMPORT: route-related options modified
Thu Apr 02 23:12:21 2020 OPTIONS IMPORT: --ip-win32 and/or --dhcp-option options modified
Thu Apr 02 23:12:21 2020 OPTIONS IMPORT: peer-id set
Thu Apr 02 23:12:21 2020 OPTIONS IMPORT: adjusting link_mtu to 1624
Thu Apr 02 23:12:21 2020 OPTIONS IMPORT: data channel crypto options modified
Thu Apr 02 23:12:21 2020 Data Channel: using negotiated cipher 'AES-256-GCM'
Thu Apr 02 23:12:21 2020 Outgoing Data Channel: Cipher 'AES-256-GCM' initialized with 256 bit key
Thu Apr 02 23:12:21 2020 Incoming Data Channel: Cipher 'AES-256-GCM' initialized with 256 bit key
Thu Apr 02 23:12:21 2020 interactive service msg_channel=768
Thu Apr 02 23:12:21 2020 open_tun
Thu Apr 02 23:12:21 2020 TAP-WIN32 device [Local Area Connection] opened: \.\Global{9FD458ED-7110-4C------------EB84DCCA}.tap
Thu Apr 02 23:12:21 2020 TAP-Windows Driver Version 9.24
Thu Apr 02 23:12:21 2020 Set TAP-Windows TUN subnet mode network/local/netmask = <IP_ADDRESS>/<IP_ADDRESS>/<IP_ADDRESS> [SUCCEEDED]
Thu Apr 02 23:12:21 2020 Notified TAP-Windows driver to set a DHCP IP/netmask of <IP_ADDRESS>/<IP_ADDRESS> on interface {9FD458------------------15CEB84DCCA} [DHCP-serv: <IP_ADDRESS>, lease-time: 31536000]
Thu Apr 02 23:12:21 2020 Successful ARP Flush on interface [60] {9FD--------------A0F6-915CEB84DCCA}
Thu Apr 02 23:12:21 2020 MANAGEMENT: >STATE:1585887141,ASSIGN_IP,,<IP_ADDRESS>,,,,
Thu Apr 02 23:12:21 2020 Blocking outside dns using service succeeded.
Thu Apr 02 23:12:26 2020 TEST ROUTES: 0/0 succeeded len=0 ret=1 a=0 u/d=up
Thu Apr 02 23:12:26 2020 Initialization Sequence Completed
Thu Apr 02 23:12:26 2020 MANAGEMENT: >STATE:1585887146,CONNECTED,SUCCESS,<IP_ADDRESS>,<IP_ADDRESS>,1194,,

https://github.com/rajannpatel/Pi-Hole-on-Google-Compute-Engine-Free-Tier-with-Full-Tunnel-and-Split-Tunnel-Wireguard-VPN-Configs
This guide walks you through running a script which will configure a Split Tunnel IPv6 Wireguard connection for your Android, iOS, Linux, macOS, & Windows devices.
I can't provide support on the OpenVPN implementation, and I believe you will have really great success with the Wireguard solution.


Search API does not render full user info required in this plugin

31ec3a1 adds user API and uses combined array to fix the issue.


Minimization step after induced_fit simulation

minimization step:
We saw at some simulation we find the pocket but the best struct is not well scored, but it is after a minimization step

Check if the step is actually useful. Run the minimization for several poses and see if they also go down in energy as much as the good one. (danielSoler93)

If yes, build the pipeline. (frumpowy)
1.1 Cluster 1000 bestStructs from refinement into 125 clusters
1.2 From the previously 125 obtained structures, DIFFERENT simulations for each cluster (each simulation has 2 cpus) --> 3h
1.3 Analysis of all together, gather the 125 minimization simulations together and get best 200
structures

We finally decided to build two different packages a PPI package where we will place the ligand around the interface of the protein and let it move + a final, quick minimization.
And an allosteric package that will place the ligand all over the protein with a final induced fit simulation

Subdivided in issues #44 and #45


Javascript split

Article checklist
Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[ ] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #issue-number
This closes #2861

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

@Joshuathuo, I've noticed you didn't follow our  set standards/structure whiile working on this article. Kindly go over  here to find more. Alternatively, head over to already published articles  here to understand how they are done.  Thanks.

@jumamiller What have I gone against please

Hi, thanks for getting back,
The article is not well structured. For example, you have introduced the concept without the introduction part, what the reader expects to get at the end of the article. You have not told us what you'll  be covering in the tutorial. That's why I've suggested the above resources to get you started quickly. If you're stuck anywhere, feel free to reach me on Slack.

Thanks @jumamiller . Meaning that I have to include the introductory part

Thanks @jumamiller . Meaning that I have to include the introductory part

Go over to the suggested resources (refer to first comment).

@Joshuathuo
Javascript split #3433.pdf
There appear to be many sentences in this article that are taken verbatim from third-party sources. We can't publish any content that is not original or properly cited/referenced. There are many free online tools where you can check this (such as quetext.com, and if you're uncertain about the definitions around plagiarism, this is a good resource to reference


fix(jest-core): don't use workers in watch mode if runInBand specified

Summary
In #14059, I added code to say that if you use watch mode, even if you only run one test and one worker, we should still not run in band, because then a hard-crash in the test will crash the entire watcher. But the way the logic is written, this overrides even an explicit --runInBand, which can be useful if you really want to, say, attach a debugger to watch-mode; it's not the smoothest experience but it's better than nothing.
In this commit I make it so that if you explicitly say --runInBand that overrides everything else. (But if you just say --maxWorkers=1, or you just only have one test to run, we still use workers.) This required some replumbing; let me know if there's a better way.
Test plan
Ran unit tests

runInBand is explicitly meant to not use workers, so I think this is fine

runInBand is explicitly meant to not use workers, so I think this is fine

Ah.. That is absolutely fine with me. Less overthinking is always good (;
This approach makes the logic of shouldRunInBand() more simple and explicit. Also I think it is good idea to have runInBand included in the config object.
By the way, isn’t this check redundant, if runInBand gets added to the config object?
https://github.com/facebook/jest/blob/77c2c6e00e0da58e242862237e541af4dde90d3c/packages/jest-config/src/getMaxWorkers.ts#L27-L28

It would be wrong to follow my suggestion above, because that is breaking change. maxWorkers value is passed around with config object, hence it can be used by any extension. Some of them might depend on the logic I was suggesting to alter.
@SimenB Looks like everything is in place. This PR is ready to land, if you are happy with it.

Something like --maxWorkers=0 could turn off workers. Just thinking out loud. Not sure if that is needed. I think, if tests run using workers or not is implementation detail and users shouldn’t have to care about that. If tests should run in parallel or in band is different problem already.

Yeah if for some reason this approach doesn't work that could be a good one. This just seemed like the simplest and most robust approach if it works.

/easycla

Oh, new CLA? Will need to get my company to sign the new one if so.

Yeah, it's Linux/JS Foundation now

Ok, sorry for the delay, finally got the CLA sorted and merged the changelog, so hopefully this is ready to go now!

Workers are still used (code execution does not break in debugging tool) when --runInBand is set as a command line argument. I guess that is an oversight.
It works when I add the option here but I doubt this is the right way to go.

Yeah, I was actually debugging something earlier today and noticed the same thing


fix #1451

add parameName to paramNameList
// Describe your PR here; eg. Fixes #issueNo
fix #1451 add parameName to paramNameList

Make sure that:

[x] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #1454 (7ddf4e7) into master (be9824c) will decrease coverage by 0.52%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1454      +/-   ##
============================================
- Coverage     63.92%   63.40%   -0.53%
+ Complexity     2043     2037       -6
============================================
  Files           407      407
  Lines          8799     8799
  Branches        881      881
============================================
- Hits           5625     5579      -46
- Misses         2755     2801      +46
  Partials        419      419

Impacted Files
Coverage Δ
Complexity Δ

...enyu/client/tars/TarsServiceBeanPostProcessor.java
31.70% <0.00%> (-51.22%)
8.00% <0.00%> (-6.00%)

...henyu/plugin/httpclient/NettyHttpClientPlugin.java
57.14% <0.00%> (-2.05%)
10.00% <0.00%> (ø%)

...che/shenyu/sync/data/http/HttpSyncDataService.java
63.10% <0.00%> (-1.95%)
12.00% <0.00%> (ø%)

...elimiter/handler/RateLimiterPluginDataHandler.java
69.23% <0.00%> (-1.54%)
14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9824c...7ddf4e7. Read the comment docs.


⚠ Bofrost.at has degraded performance

In a14e339, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2078 ms

Resolved: Bofrost.at performance has improved in c021b52 after 6 minutes.


Multi-threaded RPC server in SPRIGHT Gateway

This PR splits the RPC server into two separate threads: a setup thread and an RX thread. The RX thread uses epoll for receiving. The setup thread is responsible for adding client sockets to epoll.
This PR also fixed the routing bug when the direct function routing (DFR) mode is disabled.

Need to use a better name to describe PR

Updated by force update to latest commit


[FIX] Incomplete multi-character sanitization

JIRA: CPOUI5FOUNDATION-728
fixes: https://github.com/SAP/ui5-builder/security/code-scanning/20

coverage: 94.444% (+0.001%) from 94.443%
when pulling a85bf783fc1bed8042f5df2f896afc3d0f8700f6 on fix-incomplete-multichar-sanitize
into 52fb507c69c5e4279d388e130985da5465656682 on main.


Don't have any functionality to change the default error messages

Hey there,
Nicel library you have here, but I'm just wondering if there's any plan on adding the ability to customise the error message text for the default validations, e.g. required gives the error "This field is required".
Seems that I have to do a silent validation add my own errors.
On a side note, on your Demos page, only 1 demo works, the rest are blank HTML files.

Second time I'm using your plugin in a project and again, I really find myself needing to be able to customise the error messages.

@maikeldaloo, looks like there's already a way to add custom error messages, but I forgot to add it in the documentation and also forgot that I actually wrote this feature!
Just add an attribute on the input field like this:
data-pristine-required-message="My custom message"
Demo here
Cheers!

Oh man, I'm very happy to hear that!
Good work. I just tested it and it works just as expected 👍.
@sha256 Do you want to keep this issue open until you update the docs?

@maikeldaloo thanks man! Updated the docs, so closing this issue.


When generate outputs, how to get the probility of the outputs? Is there any param to let the model output probility ?

Feature request
xx
Motivation
xx
Your contribution
xx

This does not appear to be a PEFT-specific question, so in the future, please ask the question in the appropriate forum.
In general, with transformers language models, when passing output_scores=True, return_dict_in_generate=True to generate, you should get the logits, which can be used to calculate the probabilities.


Evaluator is not finding any results for the maven's invitations

🐞 bug report
Describe the bug

The evaluator does not find any results when searching for the uncharted realms invitations
To Reproduce
Steps to reproduce the behavior:

Use evaluator hotkey on Uncharted Realms invitation e.g. the Twisted
No results
click on "Open in browser?"
Opens trade site, no results
expand filters and under "Type Filters" change "Item Category" from "map fragments" to "Any"
will now find results

Expected behavior

Expect to find results without needing to go to trade site and changing filters
Screenshots

🌍  Your Environment

Version:  e.g. v1.0.13
PoE:  e.g. Standalone 3.13.1

bumping and removing tag


Deadline of q-investigations in update menu is overlapping in german language

Description
The FE is available for ENG and DE languages. For DE currently the update menu for quality-investigations and -alerts is not completely correct displayed and the deadline / Rückmeldedatum is overlapping.
Current behaviour
The update windows for quality-alerts and -investigations has overlapping text for deadline on  in german:

Expected behavior
Text is not overlapping neither in ENG nor in DE in the FE.
Steps to reproduce the Bug

Change FE language to DE.
Create quality-investigation with deadline on e2e-a/b for any part.
Open the quality-investigations menu and "Approve"/"Genehmigen" the created q-investigation within the menu -> check "Rückmeldedatum".

Hi @jzbmw,
FYI for further prioritization.
Thank you!

@ds-ashanmugavel is working on it

changes merged by @ds-ashanmugavel with #883

The issue could not be reproduced on e2e-a anymore, see e.g.:

Successfully retested with all update-flows.
Ticket is ready for PO-review, FYI @jzbmw.

approved


Make link to GitHub repo in tutorial more explicit?

Hi @ctb, thanks for putting together this great tutorial.
Do you think it would be worth putting a link to this repo in the tutorial?
Sorry if it's there and I'm not seeing it.
I wanted to set this up locally instead of run on MyBinder but had to google to find it.
Just a suggestion, thanks!

Oh nvm just realized I should've clicked on " full set of installed software requirements [here]". I changed the issue name 😳
And by "more explicit" I don't mean "use curse words" but just have a link that says "you can get a copy of all the code we'll use here".

effin' A!
;)
see d22edec - works?

LfGTM! :D
Thanks


[eslint] disallow eslint disable comments not scoped to rule(s)

Summary
when eslint is disabled via a comment, it should always be scoped to the applicable rules that are intentionally violated
Allowed:
// eslint-disable-next-line @scope/the-rule-name

Not allowed:
// eslint-disable-next-line

Additional context
Ironically, there is an eslint rule for this!

[ ] install eslint-plugin-unicorn
[ ] configure to only use the no-abusive-eslint-disable rule (no need to use the full recommended set at this time imo)

:tada: This issue has been resolved in version 2.88.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


GEOPY-558: Fix versions import for em1d app

GEOPY-558

@sebhmg, that makes sense - I already removed cython, are there any other packages you'd like to trim?

Thanks @benk-mira . No, looks correct for the rest


GroupChat handle is_termination_msg

Why are these changes needed?
Setting the is_termination_msg function handler in the GroupChatManager has no effect. This is because the GroupChatManager simply forwards the message to the next agent, and it falls on those agents to stop the conversation. This is problematic as it wastes orchestration LLM calls when the conversation is over, and because it prevents the ability to use the GroupChatManager as a central place to control group chat termination.
This PR fixes the issue by checking the termination message before rebroadcasting.
Related issue number
Closes #802
Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f96963e) 27.76% compared to head (1272a69) 27.59%.

Files
Patch %
Lines

autogen/agentchat/groupchat.py
50.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #804      +/-   ##
==========================================
- Coverage   27.76%   27.59%   -0.18%
==========================================
  Files          27       27
  Lines        3493     3497       +4
  Branches      791      793       +2
==========================================
- Hits          970      965       -5
- Misses       2452     2460       +8
- Partials       71       72       +1

Flag
Coverage Δ

unittests
27.59% <50.00%> (-0.12%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I'm not sure about side effects. If other notebooks use well-behaved agents and sane termination conditions, the only difference will be saving a call to the orchestrator LLM.
I discovered this when testing an adversarial situation, where one agent just flatly refused to terminate. This will certainly cause such situations to behave differently.


Remove unused 2022 code

https://github.com/BitBucketsFRC4183/FRC2023-Charged-Up/blob/f10fa1f23a7f888f68c0bb3e6e5e051ab9c35ed4/src/main/java/frc/robot/Robot.java#L110
Elsewhere also?

https://github.com/BitBucketsFRC4183/FRC2023-Charged-Up/blob/f10fa1f23a7f888f68c0bb3e6e5e051ab9c35ed4/src/main/java/frc/robot/Buttons.java#L31
More in Buttons.java

https://github.com/BitBucketsFRC4183/FRC2023-Charged-Up/blob/f10fa1f23a7f888f68c0bb3e6e5e051ab9c35ed4/src/main/java/frc/robot/utils/MathUtils.java#L7
This comment
https://github.com/BitBucketsFRC4183/FRC2023-Charged-Up/blob/auto-orient/src/main/java/frc/robot/utils/MathUtils.java#L39
And this one

https://github.com/BitBucketsFRC4183/FRC2023-Charged-Up/tree/auto-orient/src/main/java/frc/robot/config
Is this whole section unused 2022 code? You moved config to be per subsystem? Or maybe you want one global config file with limited stuff in it?

https://github.com/BitBucketsFRC4183/FRC2023-Charged-Up/commit/f3a05d79c97c9079793d99720190951adc400664
https://github.com/BitBucketsFRC4183/FRC2023-Charged-Up/commit/38da39f60e7ceb7ef7fe1d7b981b0b2a288a53cd


ready? method for remote_resource.as_json is always true

To reproduce, build a simple template to an endpoint that returns a 401 with json content type (such as apache marathon api with authentication). The template will be considered ready immediately.
The cause is https://github.com/criteo/consul-templaterb/blob/master/lib/consul/async/json_endpoint.rb#L205 where

enforce_json_200 && !(200..299).cover?(http.response_header.status) && http.response_header['Content-Type'] != 'application/json'

should probably be replaced by:

enforce_json_200 && !(200..299).cover?(http.response_header.status) || http.response_header['Content-Type'] != 'application/json'

The logic should be: if the response is not a 200 OK or is not advertize as json, then it's an error.
This bug leads to consider template as immediately ready.

The reason I'm not submitting a PR is that I wonder how this could break some template.

@kamaradclimber I think you are correct regarding your patch from some POV.
Still, I would also add a parenthesis to be sure (I hate operator priorities):
if (enforce_json_200 && !(200..299).cover?(http.response_header.status)) || http.response_header['Content-Type'] != 'application/json'

The fun part about that is that this test was added exactly to solve the marathon issue (IIRC): I wanted it to converge when the reverse proxy was not serving that page and being able to still display some stuff by handling the error myself, because I when retry is set, the template never converges. And was thinking that anyway having an HTTP 401 would never converge, so, let's fail fast. So, basically, you want to change the behavior for the same use case, but you expect a different behavior :-) (which might be legit)
The question here is what is the semantic of enforce_json_200, with the current implementation:

enforce_json_200 => Fails if HTTP Code != 2XX OR Content-Type is not JSON

This means that if enforce_json_200 is not set, it will return the result if the content-type is "text/plain".
With your patch, you are changing the semantics, so in the real world, this patch would break the templates of people having JSON data served with "application/javascript" or "text/javascript" for instance.
This is very likely to break some people's code, so most likely I would keep it that way.
However, it might be possible to add additional options:
enforce_json_mime_type => ensures that Content-Type is "application/json" and fails whenever enforce_json_200 has been set or not.
Globally, I taking the RETRY stuff of consul templaterb should be avoided for errors that are not transient (I mean, in such case, the response will always be HTTP 401, so IMHO, triggering RETRY is not a good idea).
So, to sum up:

IMHO, I would avoid this patch as it breaks the mime-type stuff
I would add another opt-in option to validate mime-type validation whenever the response is 2XX or 4XX
maybe for your use case (I mean if you want ready? to be false in case of HTTP 4XX), then I would add the possibility to add a lambda to evaluate some code:

def should_retry_default(json_endpoint, http):
   false
end

def should_retry_enforce_json200(json_endpoint, http):
  json_endpoint.enforce_json_200 && !(200..299).cover?(http.response_header.status)) || http.response_header['Content-Type'] != 'application/json'
end

In the constructor of JSONEndpoint, I would add the following:
@retry_evaluator = should_retry_default
@retry_evaluator = should_retry_enforce_json200 if enforce_json_200
if retry_evaluator:
  @retry_evaluator = retry_evaluator
  raise "enforce_json_200 and retry_evaluator are exclusive" if enforce_json_200
end

and would change the retry stuff with:
         http.callback do
            if @retry_evaluator(self, http)
              _handle_error(http) do
                warn "[RETRY][#{url}] (#{@consecutive_errors} errors)" if (@consecutive_errors % 10) == 1
              end
            else

something like that (possibly adding other default evaluator methods like validation of mime-type only whatever the HTTP return code...
So, you would be free to implement your own logic when adding the endpoint while not breaking existing compatibility.


Community OpenSubtitles

Addon Manifest URL
https://app.strem.io/shell-v4.4/#/addons/community/all?addon=https%3A%2F%2F32d94ecc2689-stremio-addon-opensubtitles.baby-beamup.club%2Fspa%2Fmanifest.json
Addon Description
Community add-on for subtitles from OpenSubtitles
Language of Content
Multilingual (Default)
Choose Labels

[ ] anime
[ ] asian drama
[ ] bollywood
[ ] cartoons
[ ] debrid support
[ ] http streams
[ ] live tv
[ ] metadata
[ ] misc
[ ] movies
[ ] music
[ ] nsfw
[ ] podcasts
[ ] radios
[X] subtitles
[ ] torrents
[ ] tv shows
[ ] video games

this is not the way to submit working addons, they need to end with /manifest.json


End to end tests should not buffer logs

Expected Behavior
End to end tests run for multiple minutes, so as a developer running the tests, I should see log output as they run so I know what they are up to.
Actual Behavior
In https://github.com/tektoncd/pipeline/pull/662/files we switched to using the test log functions (i.e. t.Logf) instead of using the zap logger. t.Logf buffers logs until the end of the test, so you aren't guaranteed to see progress as you run the test.
Steps to Reproduce the Problem
Run the end to end tests locally (https://github.com/tektoncd/pipeline/blob/master/test/README.md#end-to-end-tests), observe that the log output comes out in bursts and/or doesn't appear until the test is done.

@vdemeester pointed out that this will be fixed in golang 1.14 in which t.Logf will not buffer! :D


Vite Async Module window onerror triggering capability

Description

Background: We have a scenario where we need to retry resource loading when there are exceptions, such as when changing domain names, based on Vite packaging.

Problem: In Vite ESM packaging, dynamic imports cannot trigger window.onerror, making it impossible to listen for errors. For example, dynamic imports in router or code (dynamic imports under ESM can only go through the catch process).

However, in webpack packaging, it will be loaded in the form of a script tag, and I will get onerror, thereby achieving the ability to retry.
Suggested solution
The solution should be globally supported during construction to reduce the complexity of modifying the business side.
When Vite is built under ESM, it converts dynamic imports into script module loading and callback processing, which will not affect the original logic.
function loadAsyncModule(url) {
  return new Promise((resolve, reject) => {
    const script = document.createElement('script')
    script.type = 'module'
    script.src = url
    script.onload = (event) => {
      import(event.target.src)
        .then((module) => {
          resolve(module)
        })
        .catch((err) => {
          reject(err)
        })
    }
    script.onerror = (err) => {
      reject(err)
    }
    document.head.appendChild(script)
  })
}

loadAsyncModule('/demo/scripts/module/add-async.js').then(({ default: add }) => {
  console.log('iresult', add(1, 3))
})

Alternative
No response
Additional context
If there are any unclear points, please let me know and I will supplement them.
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I feel this is similar to #12080. Would window.addEventListener('vite:preloadError', e => console.log(e)) work for you? It's added in 4.4 (#12084).

I feel this is similar to #12080. Would window.addEventListener('vite:preloadError', e => console.log(e)) work for you? It's added in 4.4 (#12084).

Thank you very much for your reply. I carefully read the code submission you provided. From the source code, it seems that vite:preloadError only works for CSS file loading. Based on the element's hook, I was able to intercept addEventListener's error and load events to achieve retry capability.
For asynchronously loaded module modules (non-preload), it is currently not possible to trigger exceptions and retries globally. One solution I can think of is to change the way Vite packages modules by replacing the asynchronous loading of import with a custom loadAsyncModule.
My idea is to see if it is feasible to use the script method instead of asynchronous import. If it is feasible, it could be a common solution for Vite configuration.

is there any update on this issue?

From the source code, it seems that vite:preloadError only works for CSS file loading. Based on the element's hook, I was able to intercept addEventListener's error and load events to achieve retry capability.

No, it does work for JS as well (it had a bug though https://github.com/vitejs/vite/pull/15203).
https://stackblitz.com/edit/vitejs-vite-eubg1i?file=main.js,counter.js
I'll close this issue as this is already implemented by https://github.com/vitejs/vite/pull/12084


Add hints for when 'x <*> y' could be 'y'

I haven't added all the alternatives with mempty and empty as hlint doesn't
know about types, and there could be lawless instances out there I suppose. So
it's safer just to deal with concrete types.
ghci> :{
ghci| let f :: Applicative m => m (b -> (Int, b))
ghci|     f = (,) <$> pure 5
ghci| :}
ghci> f <*> mempty :: Ap [] (Int, Sum Int)
Ap {getAp = [(5,Sum {getSum = 0})]}
ghci> f <*> empty :: Ap [] (Int, Sum Int)
Ap {getAp = []}

Would be nice to detect the last one, but hlint can't know that it's empty on Ap [] (..., Sum ...).

Thanks!


Does not work with custom SESSION_COOKIE_NAME

Example:
# settings.py

SESSION_COOKIE_NAME = "xsessionid"

See also:  #136

Seems to work after all. I've added a test to make sure


[Bug]: Floating IP not persistent

Description
The floating_ip feature added with https://github.com/kube-hetzner/terraform-hcloud-kube-hetzner/pull/611 does not persist the IP configuration on the servers eth0 interface.

set floating_ip=true on some agent node(s)
start the cluster, wait until finished
ssh into the server, test floating ip is configured

$ ssh<EMAIL_ADDRESS>k3s-agent-small-vlr:~ # ip a s eth0
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 96:00:02:54:1c:d5 brd ff:ff:ff:ff:ff:ff
    altname enp1s0
    inet <IP_ADDRESS>/32 scope global eth0
       valid_lft forever preferred_lft forever
    inet <IP_ADDRESS>/32 scope global dynamic eth0
       valid_lft 86162sec preferred_lft 86162sec
    inet6 2a01:4f8:1c17:7c97::1/64 scope global noprefixroute
       valid_lft forever preferred_lft forever
    inet6 fe80::9400:2ff:fe54:1cd5/64 scope link noprefixroute
       valid_lft forever preferred_lft forever

reboot the server, ssh into the server when up again, check interface again

k3s-agent-small-vlr:~ # reboot

$ ssh<EMAIL_ADDRESS>
k3s-agent-small-vlr:~ # ip a s eth0
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 96:00:02:54:1c:d5 brd ff:ff:ff:ff:ff:ff
    altname enp1s0
    inet <IP_ADDRESS>/32 scope global dynamic noprefixroute eth0
       valid_lft 86352sec preferred_lft 86352sec
    inet6 2a01:4f8:1c17:7c97::1/64 scope global noprefixroute
       valid_lft forever preferred_lft forever
    inet6 fe80::9400:2ff:fe54:1cd5/64 scope link noprefixroute
       valid_lft forever preferred_lft forever

The server node can no longer be reached via the floating_ip since the eth0 device has no working persistent config.
The config files from the PR code are in place but have no effect:
k3s-agent-small-vlr:~ # cat /etc/sysconfig/network/ifcfg-eth0
BOOTPROTO='static'
STARTMODE='auto'
IPADDR=<IP_ADDRESS>/32
IPADDR_1=<IP_ADDRESS>/32

k3s-agent-small-vlr:~ # cat /etc/sysconfig/network/ifroute-eth0
<IP_ADDRESS> - <IP_ADDRESS> eth0
default <IP_ADDRESS> - eth0 src <IP_ADDRESS>

But since Suse has been replaced wickedd by NetworkManager this does not work. The following NetworkManager config created by cloud-init is managing the device:
k3s-agent-small-vlr:~ # cat /etc/NetworkManager/system-connections/cloud-init-eth0.nmconnection
# Generated by cloud-init. Changes will be lost.

[connection]
id=cloud-init eth0
uuid=1dd9a779-d327-56e1-8454-c65e2556c12c
type=ethernet

[user]
org.freedesktop.NetworkManager.origin=cloud-init

[ethernet]
mac-address=96:00:02:54:1C:D5

[ipv4]
method=auto
may-fail=false

[ipv6]
method=manual
may-fail=false
address1=2a01:4f8:1c17:7c97::1/64
gateway=fe80::1
dns=2a01:4ff:ff00::add:1;2a01:4ff:ff00::add:2;

A possible solution is to use NetworkManager dispatcher scripts (/etc/NetworkManager/dispatcher.d/90-add-floating-ip.sh):
#!/bin/bash
if [ "$1" == "eth0" -a "$2" == "up" ]; then
  ip addr add <IP_ADDRESS> dev eth0
fi

(see discussion https://github.com/kube-hetzner/terraform-hcloud-kube-hetzner/discussions/866)
But I'm not sure if this will work well with the cilium egress feature (the dispatcher scripts adds the IP as second IP and does not set a explicit route)
Kube.tf file
locals {
  hcloud_token = "xxxxxxxxxxx"
}
module "kube-hetzner" {
  providers = {
    hcloud = hcloud
  }
  hcloud_token = var.hcloud_token != "" ? var.hcloud_token : local.hcloud_token
  source = "kube-hetzner/kube-hetzner/hcloud"
  ssh_public_key = file("id_ed25519.pub")
  ssh_private_key = file("id_ed25519")
  control_plane_nodepools = [
    {
      name        = "control-plane-hel1",
      server_type = "cpx11",
      location    = "fsn1",
      labels      = [],
      taints      = [],
      count       = 1
    }
  ]
  agent_nodepools = [
    {
      name        = "agent-small",
      server_type = "cpx11",
      location    = "fsn1",
      labels      = [],
      taints      = [],
      count       = 1
      floating_ip = true
      #floating_ip_id = "568730"
    }
  ]
  load_balancer_type     = "lb11"
  load_balancer_location = "fsn1"
}

provider "hcloud" {
  token = var.hcloud_token != "" ? var.hcloud_token : local.hcloud_token
}
terraform {
  required_version = ">= 1.4.0"
  required_providers {
    hcloud = {
      source  = "hetznercloud/hcloud"
      version = ">= 1.41.0"
    }
  }
}
output "kubeconfig" {
  value     = module.kube-hetzner.kubeconfig
  sensitive = true
}
variable "hcloud_token" {
  sensitive = true
  default   = ""
}

Screenshots
No response
Platform
Linux (Ubuntu 22.04)

@sebastianlutter Amazing debug! Please PR welcome, it would help a lot 🙏

@sebastianlutter Amazing debug! Please PR welcome, it would help a lot pray

There is one thing I'm unsure about. @JurgenTreeum added the following comment:
[ . . . ]
# its important: floating IP should be first on the interface IP list, move main IP to the second position
ip addr del {NODE_PRIMARY_IP}/32 dev eth0
ip addr add {NODE_PRIMARY_IP}/32 dev eth0

My approach sets the floating IP as second IP, while he explicitly set it as first and moved the other IP to the second spot. I do not understand why, but I guess this is egress specific. Would be great if @JurgenTreeum or someone familiar with the egress functionality could comment on this. I don't want to break the egress functionality.
If the order of IPs and the routing is needed like described in /etc/sysconfig/network/ifcfg-eth0 and /etc/sysconfig/network/ifroute-eth0 then the dispatcher script needs to be improved. I can work on this, but someone needs to explain to me what the egress feature needs (and how to test/debug the egress feature)

@sebastianlutter see solution (wicked => NetworkManager) https://github.com/treeumcorp/terraform-hcloud-kube-hetzner/commit/294a88656047092320cd486ce878b2a193ff0f23
P.S. floating ip in the 1th position needs for egress routing through the floating ip (when the connection is from the server side)

@sshcherbinin Obviously the better way to use nmcli. Thanks for letting me know
I plan to add support for existing floating IPs, see https://github.com/kube-hetzner/terraform-hcloud-kube-hetzner/discussions/857#discussioncomment-6291894
Hope your solution is merged into upstream soon, then I'll build on top of your commit

@kube-hetzner/core Any thoughts on this?

@sshcherbinin PR welcome, and with explanations would be wonderful! 🙏


Increase number of action plans from 20 to 1000

Motivation and Context
The ops tool only displays the first 20 action plans and action rules.
What has changed
Increased limit to 1,000.
How to test?
Create more that 20 action plans and see if you can see them using the ops tool.
Links
Trello: https://trello.com/c/wMo6KtBl

 Fix ops tool action plan limit of 20


Deploying Bokeh Apps Link is broken.

In this page; https://holoviz.org/talks/index.html, the link to Deploying Bokeh Apps Tutorial is broken.
https://holoviz.org/tutorial/13_Deploying_Bokeh_Apps.html

Thanks for the report!


Correct "OSX" to "OS X".

"Mac OS X"/"OS X" should be spelled with a space before the "X". Please pull.

Thanks!

@sylvanc: you're welcome and thanks.


Bump version to 0.2.1.

Prepare 0.2.1 release.
Updated some dependencies and disabled the powerpc64-unknown-linux-gnu and sparc64-unknown-linux-gnu images since they keep breaking.

bors try

bors try

bors r+

bors r+

bors r-

bors r=adamgreig

bors r-

bors r=adamgreig

Is there any description of how the sparc/ppc images keep breaking?


Add option to skip auto generated server.properties

Can I disable the auto generated files of image? I'm having problems with the auto server.properties with curseforge packs

If there's a pre-existing one, then it skips modifying it. Would that help or do you need it to avoid creating one itself?

The pack in specific create a custom on the start script, but, the image properties always create first, without the custom world settings

SKIP_SERVER_PROPERTIES has now been added to all the image variants. Documentation was added to https://github.com/itzg/docker-minecraft-server#server-configuration


mdata bug affecting interaction of simp and match

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.
Reduced the issue to a self-contained, reproducible test case.

Description
Running simp (config := {decide := false}) inside a branch of a match statement will often leave an unsolved goal True.
This behaviour has been hidden by the default decide := true, which subsequently closes the True.
Steps to Reproduce
example : 0 = 0 := by
  simp (config := {decide := false}) -- Works fine.

example (n : Nat) : 0 = 0 := by
  match n with
  | 0 => simp (config := {decide := false}) -- Fails: unsolved goal `True`
  | _ => simp

example (n : Nat) : 0 = 0 := by
  match n with
  | 0 => simp (config := {decide := true}) -- this is the default, so masks the problem?
  | _ => simp

Expected behavior:
All three examples to work.
Actual behavior:
The second example fails in the 0 branch, with unsolved goal True.
@Kha says "this looks like an mdata bug. pp.raw + trace_state uncovers the difference."
⊢ Eq.{1} Nat (OfNat.ofNat.{0} Nat 0 (instOfNatNat 0)) (OfNat.ofNat.{0} Nat 0 (instOfNatNat 0))

n : Nat
⊢ [mdata noImplicitLambda:1 Eq.{1} Nat (OfNat.ofNat.{0} Nat 0 (instOfNatNat 0)) (OfNat.ofNat.{0} Nat 0 (instOfNatNat 0))]

Reproduces how often:
Always.
Versions
Lean (version 4.0.0-nightly-2023-03-17, commit 8650804b025c, Release)
Additional Information
Reported on zulip.

Here are some other related failures:
example : True := by
  have : True := ⟨⟩
  simp (config := {decide := false}) -- unsolved goals

example : True := by
  let x : True := ⟨⟩
  simp (config := {decide := false}) -- unsolved goals

example : True := by
  suffices True by simp (config := {decide := false}) -- unsolved goals
  constructor


return the status

I chose to use different progress percentages for each part of the upload process because I can't tell how many files, like pictures, need to be handled.
For example, after unzipping files, the progress shows 60%, and it shows 99% when all data is uploaded to the database.

ty


reference-manual: security: guide on the PKI API

Signed-off-by: Mike Sul<EMAIL_ADDRESS>

@doanac @vkhoroz This is just a draft, I think it makes sense to wait until Voldoya merges and deploys the latest changes to the PKI so I can make sure that the guide is in line with the new requirements/changes. Also, I think it makes sense to sync the terminology with the terminology used/defined in device-gateway.rst (although I am not sure I fully like it).

@mike-sul - will be easier to read/review once CI builds. The new doc needs to be added to table of contents somewhere: https://ci.foundries.io/projects/fio-docs/builds/972/docs/artifacts/console.log

I worry people are going to see this and try to do it all by hand incorrectly rather than just using fioctl (or we'll change something in how ota-lite/fioctl do things and not fix this). You think we can do something similar but explain it in the context of the exact operations fioctl is doing?

I worry people are going to see this and try to do it all by hand incorrectly rather than just using fioctl

IMHO, as long as the API is exposed we have to document and explain it as much as possible.
We just need to make sure that the API implementation prevents incorrect PKI setup. We/Voldya have partially done it (OU check, signature check, etc). I think what is left is just checking the x509 certs' extensions are set to correct values. The rest parameters shouldn't impact mTLS/PKI in terms of successful communication setup, they just tune communication details (e.g. key type).
In addition to that, we can strongly advise using fioctl keys ca and if it's missing certain features ask customers to ask us to implement them :).

You think we can do something similar but explain it in the context of the exact operations fioctl is doing?

I think we can slightly elaborate the current doc on fioctl keys ca create and extend the doc on fioctl keys ca update. The latter explains just how to update Device CA certs, but it doesn't provide details on a new offline/local device CA creation, and how the CA cert bundle should be created/merged, and that it must include online CA cert unless they really don't want to use it.
Maybe we just need a new command, e.g. fioctl keys device-ca create or fioctl keys ca device-ca create/remove/replace?
Another alternative I think of could be merging the existing doc with the given guide. I.e. extend the current doc on fioctl keys ca <> with sub-section "behind the scene" that explains what actually happens under the hood.

IMHO, as long as the API is exposed we have to document and explain it as much as possible.

That's a fair point. Maybe we need something just before this. i.e. something between "fioctl magic" and "run these curl commands" that explains the certs better than I've been able to so far.
e.g. - this is the root key pair, it needs an OU= and these PKI attributes (keysign or whatever). this is the "device-ca".....
Then we describe the actual API and what it wants. Then we have some context for all these commands.
Another thing we might do - we could update the ota-lite api to return all the scripts that fioctl uses to serve as the basis for this tutorial. Then the user is running things by hand. I wish we also didn't have to add/support the fio-pki-api tool, but I'm not sure that's doable from scripts. Maybe this could be a fioctl subcommand though?

Docs for cb8fe97687a745c0b142449170dfd4c5d56c802e are browesable at: https://ci.foundries.io/projects/fio-docs/builds/976/docs/artifacts/html/index.html

Docs for cb8fe97687a745c0b142449170dfd4c5d56c802e are browesable at: https://ci.foundries.io/projects/fio-docs/builds/977/docs/artifacts/html/index.html

Docs for cb8fe97687a745c0b142449170dfd4c5d56c802e are browesable at: https://ci.foundries.io/projects/fio-docs/builds/977/docs/artifacts/html/index.html

@doanac Hey Andy, what do you think about this version of the doc on the PKI API, it focuses rather on the API usage by means of fioctl keys ca

Updated according to the comments.

Docs for e290bd182aab94ea8c5e59fa9005d623536191f9 are browesable at: https://ci.foundries.io/projects/fio-docs/builds/1040/docs/artifacts/html/index.html

Docs for b3cee79dda749c635ab7481e127f7287e4446908 are browesable at: https://ci.foundries.io/projects/fio-docs/builds/1041/docs/artifacts/html/index.html

looks good to me. might be good to get one other person to take a read

@ricardosalveti @vkhoroz FYI, your feedback is welcomed.

Docs for 1bfe481e06364baa813d32733f29479a9f70cf3d are browesable at: https://ci.foundries.io/projects/fio-docs/builds/1042/docs/artifacts/html/index.html

@doanac So, can I merge it?

@mike-sul - go for it.


Enrich LocalTxMonitor to report other tx size dimensions

As of PR https://github.com/IntersectMBO/ouroboros-consensus/pull/1175, the LocalTxMonitor has easy access to all of the size dimensions. Benkort confirmed they would be useful https://github.com/IntersectMBO/ouroboros-consensus/pull/1175#discussion_r1662639808.
This Issue is to update LocalTxMonitor to handle those dimensions.

changes to typed-protocols mean that this is kinda blocked on supporting the changes to ouroboros-network-protocols that haven't been released yet


Resolve syncing conflicts from from-prod-master to master

Pull request opened by OPS to resolve syncing conflicts from from-prod-master to master.

:x: Validation status: errors

File
Status
Preview URL
Details
Dependent Files

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OPS-E2E-PPE/azure-docs-powershell, working directory: W:\22fe-s, target branch: master, target branch commit: c708d058f6152b53f8de8e7e38013ffe83bb03bc, source branch: from-prod-master, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details
Dependent Files

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OPS-E2E-PPE/azure-docs-powershell, working directory: W:\qxga-s, target branch: master, target branch commit: c708d058f6152b53f8de8e7e38013ffe83bb03bc, source branch: from-prod-master, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details
Dependent Files

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OPS-E2E-PPE/azure-docs-powershell, working directory: W:\tyzp-s, target branch: master, target branch commit: c708d058f6152b53f8de8e7e38013ffe83bb03bc, source branch: from-prod-master, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details
Dependent Files

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OPS-E2E-PPE/azure-docs-powershell, working directory: W:\5k2z-s, target branch: master, target branch commit: cf8e00db1d3a7410a9b52e958252e982b678df6a, source branch: from-prod-master, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

.openpublishing.publish.config.json
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/AzureRM.DeploymentManager.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/Get-AzureRmDeploymentManagerArtifactSource.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/Get-AzureRmDeploymentManagerRollout.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/Get-AzureRmDeploymentManagerService.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/Get-AzureRmDeploymentManagerServiceTopology.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/Get-AzureRmDeploymentManagerServiceUnit.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/Get-AzureRmDeploymentManagerStep.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/New-AzureRmDeploymentManagerArtifactSource.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/New-AzureRmDeploymentManagerService.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/New-AzureRmDeploymentManagerServiceTopology.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/New-AzureRmDeploymentManagerServiceUnit.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/New-AzureRmDeploymentManagerStep.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/Remove-AzureRmDeploymentManagerArtifactSource.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/Remove-AzureRmDeploymentManagerRollout.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/Remove-AzureRmDeploymentManagerService.md
:white_check_mark:Succeeded

azuredmps-0.9.0/AzureRM.DeploymentManager/Remove-AzureRmDeploymentManagerServiceTopology.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.AnalysisServices/Add-AzureAnalysisServicesAccount.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.AnalysisServices/Azure.AnalysisServices.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.AnalysisServices/Export-AzureAnalysisServicesInstanceLog.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.AnalysisServices/Restart-AzureAnalysisServicesInstance.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.AnalysisServices/Sync-AzureAnalysisServicesInstance.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Azure.Storage.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Disable-AzureStorageDeleteRetentionPolicy.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Enable-AzureStorageDeleteRetentionPolicy.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageBlob.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageBlobContent.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageBlobCopyState.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageCORSRule.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageContainer.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageContainerStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageFile.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageFileContent.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageFileCopyState.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageQueue.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageQueueStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageServiceLoggingProperty.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageServiceMetricsProperty.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageServiceProperty.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageShare.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageShareStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageTable.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/Get-AzureStorageTableStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/New-AzureStorageAccountSASToken.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/New-AzureStorageBlobSASToken.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/New-AzureStorageContainer.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/New-AzureStorageContainerSASToken.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/New-AzureStorageContainerStoredAccessPolicy.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/New-AzureStorageContext.md
:white_check_mark:Succeeded

azurermps-6.11.0/Azure.Storage/New-AzureStorageDirectory.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.