Feature Request: Parameter in UserSettings and custom icons

Hi,
first of all: great App!
Sometimes I'm getting links to Office documents (Excel, PowerPoint, Word), that I would like to open directly in the respective app.
This is possible by using C:\Program Files\Microsoft Office\root\Office16\protocolhandler.exe as the browser with the argument ms-excel:ofe|u|https://... (for Excel)
to make this work, it would be required to have a parameter for the URL though that I can put into the LaunchArgs. Something like %URL% or $1, so the LaunchArgs would become ms-excel:ofe|u|%URL%
For the same use case, it would also be helpful to select a custom icon, since the icon of protocolhandler.exe is a generic Office icon, which obviously becomes confusing if you configure it three times for Excel, PowerPoint and Word.
Let me know what you think!
Thanks

[x] Custom Icons
[x] Parameter in UserSettings.json

Yeh.... This might be possible and quite a easy one. I'll try to include it in v0.7

Added both of them in v0.6.2
Report any issues on those if you got time.

Ello! Just another suggestion related to the custom icons.
Is it possible to make it suppose GIF image extensions? I would be great for more customization :>

GIFs.... I never thought about them. I don't know whether the underlying framework of Hurl (named WPF) supports it or not. Will look into it again.

It's alright if it's not possible, just a wacky suggestion of mine lol

I extracted 256x256 PNGs with alpha channel from the office executables and was able to use them using the CustomIconPath. Working nicely, thanks!


[SPARK-41986][SQL] Introduce shuffle on SinglePartition

What changes were proposed in this pull request?
This PR introduces shuffle on SinglePartition if it's physical size greater than spark.sql.adaptive.advisoryPartitionSizeInBytes.
Why are the changes needed?
Improve parallelism. For example:
spark.range(100000000L).selectExpr("id as a", "id as b").write.saveAsTable("t1")

sql(
  """
    |WITH base
    |     AS (select *, ROW_NUMBER() OVER(ORDER BY a) AS new_a FROM t1)
    |SELECT * FROM base t1 JOIN base t2 ON t1.a = t2.b
    |""".stripMargin).explain()

Before this PR:
== Physical Plan ==
AdaptiveSparkPlan isFinalPlan=false
+- SortMergeJoin [a#10L], [b#26L], Inner
   :- Filter isnotnull(a#10L)
   :  +- Window [row_number() windowspecdefinition(a#10L ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), currentrow$())) AS new_a#8], [a#10L ASC NULLS FIRST]
   :     +- Sort [a#10L ASC NULLS FIRST], false, 0
   :        +- Exchange SinglePartition, ENSURE_REQUIREMENTS, [plan_id=50]
   :           +- FileScan parquet spark_catalog.default.t1[a#10L,b#11L]
   +- Sort [b#26L ASC NULLS FIRST], false, 0
      +- Filter isnotnull(b#26L)
         +- Window [row_number() windowspecdefinition(a#25L ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), currentrow$())) AS new_a#27], [a#25L ASC NULLS FIRST]
            +- Sort [a#25L ASC NULLS FIRST], false, 0
               +- Exchange SinglePartition, ENSURE_REQUIREMENTS, [plan_id=54]
                  +- FileScan parquet spark_catalog.default.t1[a#25L,b#26L]

After this PR:
== Physical Plan ==
AdaptiveSparkPlan isFinalPlan=false
+- SortMergeJoin [a#10L], [b#26L], Inner
   :- Sort [a#10L ASC NULLS FIRST], false, 0
   :  +- Exchange hashpartitioning(a#10L, 5), ENSURE_REQUIREMENTS, [plan_id=60]
   :     +- Filter isnotnull(a#10L)
   :        +- Window [row_number() windowspecdefinition(a#10L ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), currentrow$())) AS new_a#8], [a#10L ASC NULLS FIRST]
   :           +- Sort [a#10L ASC NULLS FIRST], false, 0
   :              +- Exchange SinglePartition, ENSURE_REQUIREMENTS, [plan_id=50]
   :                 +- FileScan parquet spark_catalog.default.t1[a#10L,b#11L]
   +- Sort [b#26L ASC NULLS FIRST], false, 0
      +- Exchange hashpartitioning(b#26L, 5), ENSURE_REQUIREMENTS, [plan_id=61]
         +- Filter isnotnull(b#26L)
            +- Window [row_number() windowspecdefinition(a#25L ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), currentrow$())) AS new_a#27], [a#25L ASC NULLS FIRST]
               +- Sort [a#25L ASC NULLS FIRST], false, 0
                  +- Exchange SinglePartition, ENSURE_REQUIREMENTS, [plan_id=54]
                     +- FileScan parquet spark_catalog.default.t1[a#25L,b#26L]

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.

cc @cloud-fan @sunchao

Merged to master for Apache Spark 3.4.0.

@wangyum can we update the PR description? It does not match the real cod changes which is confusing.

@cloud-fan Has updated it.


Error when I open integrated terminal

VSCode Version:1.6.1
OS Version:Windows 7

Error: The terminal process terminated with exit code: 1
Steps to Reproduce:

Open integrated terminal

Does the current folder you have non-ascii characters in the path? If so this is fixed in the insiders build #7727

Closing as fixed. @rahdev Please let us know if you are still seeing this issue with VSCode 1.8.1
Thanks


[kind of OT] AppVerifier can not verify some apps installed via Accrescent

just a heads up from a first time user
I've installed Appverifier, Molly, Beautytxt, Arcticons and Ivpn from Accrescent.
Appverifier verifies Molly and Beautytxt but can't verify arcticons and ivpn.
I understand that this an Appverifier "issue" that can be solved in this way but I think that this highly confusing for a first time user who certainly expects to see a green check next to any application installed via Accrescent.
thank you for your work, very appreciated

Hi! AppVerifier isn't an Accrescent project and is maintained by @soupslurpr at https://github.com/soupslurpr/AppVerifier, so I think this issue would better be posted there.

hello! thank you for your reply.
I think I wasn't able to make my point here so I'll try rephrase.
I'm aware that Appverifier is not part of your project but you have a handful of applications and Appverifier stands out in the list. I think that a new user will think that all the applications you have in your own repo certainly are registered in Appverifier internal database.
So, maybe in order to avoid confusion you could just contribute your listed applications' signature back to Appverifier so that new users won't feel disoriented?
my 2 cents

@damko I'm not accepting contributions of new apps to AppVerifier's internal database

well this solves the issue completely :-)


Expose fuelGroup in fuel.lua

fuelGroup is a local variable defined in fuel.lua. Therefore, making any modifications to fuel groups is not possible unless you copy/paste everything

this is now exposed as fuel.fuelGroups in 0.4.


ValueError: 3 is not in list

Traceback (most recent call last):
File "C:\Users\KY\Desktop\1\main.py", line 757, in
app = App()
^^^^^
File "C:\Users\KY\Desktop\1\main.py", line 598, in init
self.sprite_handler.add_sprite(WIDTH // 2, HEIGHT // 2)
File "C:\Users\KY\Desktop\1\main.py", line 473, in add_sprite
self.sprites.append(SpriteUnit(handler=self, x=x, y=y))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\KY\Desktop\1\main.py", line 146, in init
self.image_ind = list(self.handler.app.frames.keys()).index(3)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: 3 is not in list
Simply this not even launching.

Do you have folders with files of specific characters in the root directory? The files for characters (like Oska, Tahni, etc.) are crucial. Be sure to download them here or here, since the original DeskMates are now abandonware.
Have you changed the variables character, working_dir and data_directory to proper parameters?

I did this: and I think I'm doing it wrong because I still have the same error

Don't change the variables in the App class' __init__ function -- change them at the very bottom of the code. Plus, the character should not be the full directory path -- it should the directory name.

ok, it started working when I did this with "data_directory"...

so I guess we can close the issue


Windows: extend some type conversion definitions

Add some more type conversion helpers for macros used in CreateFileW which adds verbosity by explicitly casting the imported types to DWORD.

@swift-ci please test


Greater teleport deleting items

The server I run occasionally dips in framerate and tickrate. On said server using greater teleport (seemingly exclusively when using a spell circle, and while entering confined spaces with it? Under 6x6 floor space in the very least) will take the items from a players inventory, throw them onto the floor, but then seemingly delete them outright? These items will last for under a second, won't be able to be picked up, and then will be instantly despawned, this happens approx 1 in every 5-10 teleports on the server. A way to disable the item drop feature outright would be appreciated if this bug can't be patched (understandable since it seems to only happen on servers at lower ends of performance)

As a few other things to note:
This is the latest build of the forge edition of the mod
this server is run by Apex hosting
The server lowers in frame and chunk rendering rate especially as far as it's performance issues are concerned

What version of Hex Casting is this issue for? Do you know if this bug is still present in the 1.20.1 prereleases? A complete modlist and exact versions would also be helpful if you still have those handy.

Could not duplicate this on 1.20.1 prerelease, additionally it seems some of Apex Hosting's Server Defaults alter item despawn rates


Draft: ON-32691 # Added lookupButton prop to elements

The changelog is not right, got two Added headings


Incorrect tree shaking in release 3.7.2 causing entire mui icons to be included

In issue 3.7.2 incorrect tree shaking, probably in in src/components/ExpandButton.js line 3,
is causing entire material-ui/icons module to be included.
I am using Webpack 5.10.0, so that may also play a factor.
I am thinking the issue could be fixed by either:

going back to the safe approach of importing like:
import Remove from '@material-ui/icons/Remove';

or ensure tree shaking is conducted

Expected Behavior

Entire icons module should not be included
Current Behavior

Entire icons module is included
Steps to Reproduce (for bugs)

Build project all else equal with release 3.7.2, make note of bundle size
uninstall 3.7.2, and install 3.7.1, it should be significantly smaller

Your Environment

To verify that the problem was with mui-datatables I used verbose mode on webpack along with bundle analyzer, to narrow down where the images were being imported in. After finding that my vendor module with the icons, only occurred on pages where I used mui-datatables, I followed the steps in "steps to reproduce" and found that fixed the extra icons.
If anyone else is having this problem, I could probably submit a pull request with a fix.

Tech
Version

Material-UI
4.11.2

MUI-datatables
Used both 3.7.2 and 3.7.1

React
16.14

browser
Chrome

Webpack
5.10

@spareelectronics
thanks report!
I changed the settings through the document below, but this seems to affect tree shaking.
https://material-ui.com/guides/minimizing-bundle-size/
It can be changed enough if it is proven.
 //AS-iS
import { Add as AddIcon } from '@material-ui/icons';
import { Tabs } from '@material-ui/core';
//                                 ^^^^ 1st or top-level

//TO-BE
import AddIcon from '@material-ui/icons/Add';
import Tabs from '@material-ui/core/Tabs';
//                                  ^^^^ 2nd level
``

If I have time, I'll measure it with this.
https://www.npmjs.com/package/webpack-bundle-analyzer

Have the same issue,
with import MUIDataTable from 'mui-datatables' 838 kB
without import MUIDataTable from 'mui-datatables' 4.42 kB
Checked with webpack-bundle-analyzer, looks like the entire @material-ui/icons package is included.
Using latest next.js

The mui docs link encourages library authors to use the path import instead of the top level import. I'll do some more testing with the latest version of mui datatables, and see if I can reduce the bundle size. I'll share images from bundle anaylzer, here once I'm done.  Here's the where it says to use path import:

confirming. had to fork and fix imports. tree shaking doesn't work with material-ui when you use imports like:
import { Add as AddIcon } from '@material-ui/icons';
import { Tabs } from '@material-ui/core';

Fixed 3.7.4

Fixed 3.7.4


Add template for basic PyHARP project.

In addition to the README tutorial, I think it would be really helpful to users of HARP if we included a barebones template project with indications such as:

<YOUR MODEL INITIALIZATION CODE HERE>
<YOUR AUDIO LOADING CODE HERE> (can provide default code)
<YOUR AUDIO PROCESSING CODE HERE>
<YOUR AUDIO SAVING CODE HERE> (can provide default code)
<YOUR UI ELEMENTS HERE>

This would help delineate between what code is necessary to adhere to the expectations of HARP and what code should be provided by the user to perform audio processing.
I am thinking this project would include the minimum code (app.py) and extra files (requirements.txt, .gitignore, etc.) such that users can simply insert the specifics of their model/algorithm and then upload their working and HARP-ready application to HuggingFace.

Addressed by PR https://github.com/audacitorch/pyharp/pull/11 ...


Add pprof as an external repo.

Summary: We add Google pprof as an external repository to support upcoming export of perf profiling in pprof format.
Type of change: /kind feature
Test Plan: Tested locally in a separate branch. At the moment, this additional bazel repo is not used.

You can also directly access the .proto file as @com_github_google_pprof//proto:profile.proto incase you don't want to rely on the auto generated proto_library rule.

We won't need this diff.


Add A4G bidder docs

Related: https://github.com/prebid/Prebid.js/pull/1526

Current code PR appears to be this one: https://github.com/prebid/Prebid.js/pull/1650

Hey @kononenko-a-m do these docs still apply to the latest A4G adapter code PR in https://github.com/prebid/Prebid.js/pull/1797 ?

0.33 was released a while ago. Merging.


Using provided height for custom view mode.

The aim of this change is that, when using CustomMode of MRProgressOverlayView, we want to show custom loading view as provided custom view's size.

Thanks :+1:


fix: loadImage memleak and performance issue

#914  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on  Graphite


Typo in README

I encountered this issue in the Readme. md file of this project, It's in this screenshot,

But according to me, It should be:- "I want to perform data analysis and data science-related tasks in JavaScript and Node.js, similar to how I might use Python, Julia, R, and MATLAB."

@Rajeevjewar According to this SO post, you are correct, as "data science-related" comes before "tasks". However, this would allow mean that we should have "data analysis- and/or data science-related tasks", as "data analysis" is part of the compound adjective.
If you want to submit a PR, we can review.

"Like how I might use Python, Julia, R, and MATLAB, I wish to execute data analysis and data science-related jobs with JavaScript and Node.js."
This will sound better, I believe.

@Rajeevjewar According to this SO post, you are correct, as "data science-related" comes before "tasks". However, this would also mean that we should have "data analysis- and/or data science-related tasks", as "data analysis" is part of the compound adjective.
If you want to submit a PR, we can review.

Can I submit a PR for that ?

Hello @Rajeevjewar  sir, the correct sentence should be "I want to perform data analysis and/or data science-related tasks in JavaScript and Node.js, similar to how I might use IPython, Julia, R, and/or MATLAB."

Hello @kgryte  , I want to work on this issue, can you please assign it to me.

if this issue isn't solved, i would like to work on it!


Icon

Hello everyone.
My problem is as follows, when I create the menu I pass an object from it as follows:
Var mb = menubar ({
   Dir: './',
   Index: config.frontEnd.protocol + ': //' + config.frontEnd.host + ':' + config.frontEnd.port,
   Icon: process.cwd () + '/ build / img / icon.png',
   ShowDockIcon: true,
   Width: 600,
   WebPreferences: {
     NodeIntegration: false
   }
In local shows the icon perfectly.
But once I create my Mac OS executable it always shows me the image of the cat that is the default one.
How can i solve this problem??
Thank you very much in advance.

Personally, I resolve paths with path and _dirname. You'll probably want to use a png for mac and an ico for windows. For example,
path.join(__dirname, '../img/trayicon.ico')

Excellent thank a lot .. work for me...


Doesn't run on Steam Deck

When trying to launch it on Steam Deck when added to Steam, and selecting the compatibility layer to use the Steam Linux Runtime container the game will launch fine but it gives an error about the video card not being supported.
Is there a way to skip this error? As it will likely run on it, most things do just fine.
Ps. I needed to use the Steam Linux Runtime compatibility option (since it's a Native game), as it uses a dependency not included by default (libgconf) on the Steam Deck OS.

Unfortunately I don't have a Steam Deck to test this out. Can you share any screenshots or error messages?

Oh yeah I suppose that would have helped woops.

That helps, thanks! Looks like the code in question is right here: https://github.com/open-duelyst/duelyst/blob/1c138df/app/application.coffee#L3857L3892

Out of curiosity, are you able to play in browser at https://staging.duelyst.org ?

Ah yeah, I was just hunting for it and found that.

That helps, thanks! Looks like the code in question is right here: https://github.com/open-duelyst/duelyst/blob/1c138df/app/application.coffee#L3857L3892

Hah yeah was hunting for it and just found it before your comment.

Out of curiosity, are you able to play in browser at https://staging.duelyst.org ?

With Chrome in Gaming Mode on Steam Deck it does run yes. Obviously the aspect ratio is a bit off right now, quick basic test.

(Sorry for camera not screenshot, Steam Deck doesn't seem to allow Chrome screenshots to upload to grab it)

Try adding these flags when starting up:
--enable-accelerated-mjpeg-decode --enable-accelerated-video --ignore-gpu-blacklist --enable-native-gpu-memory-buffers --enable-gpu-rasterization
Similar issues:

https://www.reddit.com/r/linux/comments/p2ivtq/updated_guide_on_how_to_get_hardware_acceleration/
https://thecodersblog.com/hardware-acceleration-in-linux-with-chrome/

I had this issue on my Arch install and using these flags solved it for me.

Try adding these flags when starting up: --enable-accelerated-mjpeg-decode --enable-accelerated-video --ignore-gpu-blacklist --enable-native-gpu-memory-buffers --enable-gpu-rasterization
Similar issues:

https://stackoverflow.com/questions/70619124/electron-linux-video-hardware-acceleration
https://www.reddit.com/r/linux/comments/p2ivtq/updated_guide_on_how_to_get_hardware_acceleration/
https://thecodersblog.com/hardware-acceleration-in-linux-with-chrome/

Confirmed, runs on the Deck with the flags above.

Thanks @marwanhilmi! I'll see if I can get these flags into the Linux build so this "just works" out of the box.

Here's the new release with the hardware acceleration flags added to the Electron build: https://github.com/open-duelyst/duelyst/releases/tag/1.97.11
Let us know if you run into any additional issues!


Advance to "Do not explicitly pass autogen to adapters" commit.

Coverage remained the same at 83.565% when pulling c72317640c39ba14c7bf51f9df6bc429bc31099c on no-pass-autogen-adapters into 877390f12439acd75fad8f7481739ecce131fb58 on master.


Add Resharper Settings File

Add in a solution specific settings file.

I do not use Resharper but feel free to add it. No worries :+1:

I'd highly recommend it, hard to program without it once you get used to how easy it makes using VS :smile:


apply migration and metadata changes on boot

Fixed by adding HASURA_GRAPHQL_DATABASE_URL in Render env

 Auto apply migrations on docker start up in Render


First crack at documenting a telemetry event in the docs site

We need to start documenting some of the key telemetry signals emitted by FF, to empower 1p/3p partners to make good use of the data we emit for diagnostics and analytics.
This one came up in a conversation today so I'm starting here.  Other areas of interest are the error types/codes we use.
Looking for feedback on location in docs site, how to link around between docs and code, etc.

@jvoels FYI

Closing, see #6976


GitHub gist line-number line height not aligned to code line-data

Recent updates to Casper theme now include some CSS for GitHub gists.
Line height is off, not aligning the line numbers and code, as seen here:

WIthin assets/css/screen.css under Third Party Elements - Embeds from other services at lines 1195-1197 line height should be something like:
.gist .line-number {
    line-height: 1.9em;
}

Line height should be 1.9em / 2rem / 20px to align.

This was fixed in #163 and will be included in the next release - thanks for reporting!


spatial_range, what is it and how to specify?

When I'm doing a generative transpose convolution on a tensor. An error occured:
AssertionError: spatial range must be specified in generative mode
This seems to because I didn't specify the spatial_range when creating sparse tensor.
My sparse tensor is converted from a MinkowskiEngine SparseTensor by:
def minkowski_to_torchsparse_sparse_tensor(sparse_tensor: ME.SparseTensor) -> torchsparse.SparseTensor:
    """Convert the MinkowskiEngine SparseTensor to torchsparse SparseTensor"""
    coords = sparse_tensor.C
    feats = sparse_tensor.F
    tensor_stride = sparse_tensor.tensor_stride
    col_indices = torch.tensor([3, 0, 1, 2], device=coords.device)
    coords = torch.index_select(coords, 1, col_indices)
    out = torchsparse.SparseTensor(coords=coords, feats=feats, stride=tensor_stride)
    return out

I don't know what does this spatial_range mean and how to specify it when converting from a MinkowskiEngine SparseTensor.

To understand sparse tensors, imagine a tensor with many zero elements. If you have a dense 3D tensor with dimensions HxWxL, defining a sparse tensor means that the spatial range of your tensor remains (H, W, L), but many of the values within this range are zero.

To understand sparse tensors, imagine a tensor with many zero elements. If you have a dense 3D tensor with dimensions HxWxL, defining a sparse tensor means that the spatial range of your tensor remains (H, W, L), but many of the values within this range are zero.

Thank you for your explanation! Still, I'm wondering how to

To understand sparse tensors, imagine a tensor with many zero elements. If you have a dense 3D tensor with dimensions HxWxL, defining a sparse tensor means that the spatial range of your tensor remains (H, W, L), but many of the values within this range are zero.

Thank you for your explanation! So this value numerically equals to the maximum value along 3 dimensions.


Make linux check for subprocess errors

MacOS, Windows and WSL wait for the open child process to exit, and checks its exit code. This means that errors in the opening process are returned to the user. However, the linux implementation does not wait for the xdg-open process to exit. This means that potential errors returned by xdg-open are ignored.
This fixes the code by making the linux implementation also wait for the child process to exit, and checking its return type.

The current behavior is deliberate. While it would be nice to be able to catch errors in this situation, if we catch errors by waiting for xdg-open to finish, we run into the issue of xdg-open, in certain cases, blocking until the launched application exits, which we don't want.

Thanks for explaining.
I guess I was confused since I saw the MacOS and WSL implementations waiting for their opener programs to exit, but it makes sense that their behavior is much more strongly specified than a generic xdg-open's behavior.
Would you be interested in other ways to align the behavior of the linux implementation with Windows/MacOS? For example, if there was a way to force the use of the embedded xdg-open it might be possible to make stronger guarantees about it exiting since the script is vendored in this crate.

The reasoning for the current behavior of trying the system xdg-open first is that some users (and distros?) use a customized xdg-open, or even an entirely different binary/script aliased as xdg-open that the user expects to handle the opening. We shouldn't break that. I don't know if there's a way to improve the situation given these constraints.

No worries, thanks for the explanation


Cleanup unused engine code

Part of #26780
Here's the current list (also removed some false positives): https://hatebin.com/punblqomki
That list is looong. There's lots of dead code, e.g. there was a method _get_selection_group_tail(), which I added as a helper for one PR then someone rewrote it for code that didn't use this function, but the function was never removed (until now). There are lots of methods that are only declared and implemented and that's all. Hard to say if they are supposed to be used in the future or they are leftovers. I even found a class for a dialog that had functionality removed, but it still existed in the code and was even created in EditorNode. Another thing are getters for properties, which are not bound. They were created likely for consistency, but they are unused. I think we should remove them (they can be re-added when needed, but it's unlikely IMO).
The biggest changes would be:
-removed shaders from Themes (nothing uses them and they are not bound)
-removed RunSettingsDialog
-set_stream_peer is now bound to _set_stream_peer, which has an additional error check (I think it was intended from the beginning; if not, _set_stream_peer should be removed altogether)
As I said, hard to say which methods should be removed and which are e.g. not bound by mistake, so this probably needs thorough review >_>
EDIT:
_set_stream_peer required some more changes actually :/

Thanks!


api: Refactor /messages/{message_id}/reactions endpoint.

This refactors the endpoint to allow deleting a realm_emoji reaction with emoji_name only.

@timabbott Can you have a look ?

@zulipbot remove "has conflicts"

@timabbott This is ready for a review.

Posted one comment, but mainly this needs a rebase.

@timabbott I've updated the PR.

@zulipbot remove "has conflicts"

@timabbott Can you have a look ?

@zulipbot remove "has conflicts"

@orientor This is ready for a review.


CAMEL-14136: Fix ConcurrentModificationException in Scanner

Internal use of non threadsafe map wrapped with synchronized block,
extracted some static patterns into class static block
https://issues.apache.org/jira/browse/CAMEL-14136

Some spaces were missing, due to a different formatter in eclipse.


ssh update

Hi just wondering is ssh fixed since I'm trying it and it still isent working.

Some updates are on the way but they are not in the most recent insider build, let's use some of the existing threads to track status, for example #300.


Msix package

Summary of the Pull Request
Implemented initial MSIX support. Follow the instructions at installer\README.md to test it. I haven't done exhaustive test of each setting, though generally this stuff works:

FancyZones
Shortcut_guide
Startup task as non-elevated and as elevated (tested as admin user)
PowerRename, except for bool_show_extended_menu option, since it's not supported by IExplorerCommand. Backward compatibility with .msi is preserved for now

PR Checklist

[x] Applies to #836
[x] Applies to #202

@yuyoyuppe
I forgot to ask you if the MSIX can support detecting an already installed version that was installed with MSI.
MSI uses an upgrade GUID to determine if there is an existing previous version installed and take action if present.
Also, what is used as unique id of the MSIX package?

@enricogior we're generating GUID every compilation for MSI and use a special upgrade GUID. MSIX also generates a unique GUID if we don't specify Identity.Name property.
I couldn't find any info on the MSIX upgrade support, but using MSI's upgrade code as a Identity.Name value in MSIX appmanifest had no effect when I tried it.


Dev

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.
@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
It appears you are making a pull request from a branch in your feedstock and not a fork. This procedure will generate a separate build for each push to the branch and is thus not allowed. See our documentation for more details.
Please close this pull request and remake it from a fork of this feedstock.
Have a great day!

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-webservice.
It appears you are making a pull request from a branch in your feedstock and not a fork. This procedure will generate a separate build for each push to the branch and is thus not allowed. See our documentation for more details.
Please close this pull request and remake it from a fork of this feedstock.
Have a great day!

Hi! This is the friendly automated conda-forge-webservice.
It appears you are making a pull request from a branch in your feedstock and not a fork. This procedure will generate a separate build for each push to the branch and is thus not allowed. See our documentation for more details.
Please close this pull request and remake it from a fork of this feedstock.
Have a great day!

Hi! This is the friendly automated conda-forge-webservice.
It appears you are making a pull request from a branch in your feedstock and not a fork. This procedure will generate a separate build for each push to the branch and is thus not allowed. See our documentation for more details.
Please close this pull request and remake it from a fork of this feedstock.
Have a great day!

Hi! This is the friendly automated conda-forge-webservice.
It appears you are making a pull request from a branch in your feedstock and not a fork. This procedure will generate a separate build for each push to the branch and is thus not allowed. See our documentation for more details.
Please close this pull request and remake it from a fork of this feedstock.
Have a great day!

Hi! This is the friendly automated conda-forge-webservice.
It appears you are making a pull request from a branch in your feedstock and not a fork. This procedure will generate a separate build for each push to the branch and is thus not allowed. See our documentation for more details.
Please close this pull request and remake it from a fork of this feedstock.
Have a great day!

Aha, very good @CarlKCarlK!
I think the simplest thing to do would be to open a new PR with the changes you made to the build.bat file, getting rid of the skip for windows and bumping the build number. Hopefully it'll all work ok then :crossed_fingers:

Hi! This is the friendly automated conda-forge-linting service.
I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

I made the changes. The PR is being tested.
Dev by CarlKCarlK · Pull Request #13 · conda-forge/bed-reader-feedstock (github.com)https://github.com/conda-forge/bed-reader-feedstock/pull/13/
From: Jerome Kelleher @.>
Sent: Friday, January 28, 2022 2:10 AM
To: conda-forge/bed-reader-feedstock @.>
Cc: Carl Kadie @.>; Mention @.>
Subject: Re: [conda-forge/bed-reader-feedstock] Dev (PR #13)
Aha, very good @CarlKCarlKhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCarlKCarlK&data=04|01||37d56f1c5eb74185264c08d9e246643f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637789614236286310|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=2uayDNLWKxjjcaiIcXTPp92WApO9ufiaqb0ks0hcWto%3D&reserved=0!
I think the simplest thing to do would be to open a new PR with the changes you made to the build.bat file, getting rid of the skip for windows and bumping the build number. Hopefully it'll all work ok then 🤞
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fconda-forge%2Fbed-reader-feedstock%2Fpull%2F13%23issuecomment-1024067563&data=04|01||37d56f1c5eb74185264c08d9e246643f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637789614236286310|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=9S27Yy80pYVG0PDb7AZ3Iv%2BYOKMw6Ks9MgVQHdy75Kk%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABR65PY5PH72RJ45JFRBDULUYJTQXANCNFSM5MZTMMCA&data=04|01||37d56f1c5eb74185264c08d9e246643f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637789614236286310|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Pqlz4en4XjY%2BboM9uEGb0TdQcEfgb6W%2Bjyz3ZCTiNME%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||37d56f1c5eb74185264c08d9e246643f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637789614236286310|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=mcfq0A0YWSJZGN0luhWb8A%2Bo0Xep1hXOSP2sz1%2F1Q7k%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||37d56f1c5eb74185264c08d9e246643f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637789614236286310|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=iUcfmTKpf0Xy%2BRFVip%2FIQwX7NihZCJI%2BPSgeOSzZtEo%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Hi @CarlKCarlK - I think it would be simpler to check out a fresh PR here rather that updating this one, as the history is a bit of a mess. This is one way to do it:
git fetch upstream
git checkout upstream/master
git checkout -b fix-windows
# apply changes
git push origin fix-windows

open a PR. Alternatively, the gh GitHub command like tool is excellent.

Sounds good. I think I did it.
Fix windows by CarlKCarlK * Pull Request #14 * conda-forge/bed-reader-feedstock (github.com)https://github.com/conda-forge/bed-reader-feedstock/pull/14/ is in testing
From: Jerome Kelleher @.>
Sent: Friday, January 28, 2022 7:50 AM
To: conda-forge/bed-reader-feedstock @.>
Cc: Carl Kadie @.>; Mention @.>
Subject: Re: [conda-forge/bed-reader-feedstock] Dev (PR #13)
Hi @CarlKCarlKhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCarlKCarlK&data=04|01||e34bda0c803d4b0832e908d9e275d637|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637789817992290460|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=K9XXal3ES0w8SuijhMTqcRIUS1nwWsQPb0q2ecDYFzc%3D&reserved=0 - I think it would be simpler to check out a fresh PR here rather that updating this one, as the history is a bit of a mess. This is one way to do it:
git fetch upstream
git checkout upstream/master
git checkout -b fix-windows
apply changes
git push origin fix-windows
open a PR. Alternatively, the gh GitHub command like tool is excellent.

Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fconda-forge%2Fbed-reader-feedstock%2Fpull%2F13%23issuecomment-1024348120&data=04|01||e34bda0c803d4b0832e908d9e275d637|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637789817992290460|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=%2FMtzG6u004U7Q30nAtC753F1k6W5VhDtM58m4%2BdxNQU%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABR65P7URLJASMJIQQW5CYDUYK3KNANCNFSM5MZTMMCA&data=04|01||e34bda0c803d4b0832e908d9e275d637|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637789817992290460|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=T%2BnPcrJq044UIr66R1IMKntP9deCEcpzN6v7ArPlDQ8%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||e34bda0c803d4b0832e908d9e275d637|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637789817992290460|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=u8sQp4c%2BECtdnUzaao39MlfnUCJmOF9Agfx9LQklXAc%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||e34bda0c803d4b0832e908d9e275d637|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637789817992446686|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=i%2F5L7d5Oy8dD1P5898QPLzd2YaxwlK0vCWnL4jQDqsk%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


CIV-12777 Part Admit Claimant Dashboard

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-12777
Change description
Added:

Handler for claimant response (claimant)
Script for Part admit Accepted claimant response
Method to return ordinal formatted date
Unit and integration test

Modified:

I have extracted the utils ClaimantResponseUtils.java
from civil/service/docmosis/utils to civil/utils because it is generally used. Consequently some imports have been modified

Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ x ] No

Open for review before the end of the sprint

Open to get reviews


no floor division, mod and divmod for mpc types

The floor function is defined for mpc types, so floor division should also be defined for mpc type: z1 // z2 = floor(z1 / z2). So, the mod function should also be defined for mpc types: z1 % z2 = z1 - z2 * (z1 // z2). However, the floor function, floor division, mod and divmod is not defined for built-in complex type.

The floor function is defined for mpc types

You meant for the mpf type?  It has floor division, because it implements the numbers.Real.

so floor division should also be defined for mpc type: z1 // z2 = floor(z1 / z2)

That doesn't make sense.  What's the floor of a complex number?

You meant for the mpf type? It has floor division, because it implements the numbers.Real.

I am really discussing about the mpc type.

That doesn't make sense. What's the floor of a complex number?

floor() is defined for complex number: floor(z) = floor(Re(z)) + i*floor(Im(z)). So z1 // z2 = floor(z1 / z2) = floor(Re(z1 / z2)) + i*floor(Im(z1 / z2)).

floor() is defined for complex number

>>> math.floor(mpc(1j))
Traceback (most recent call last):
  File "<python-input-8>", line 1, in <module>
    math.floor(mpc(1j))
    ~~~~~~~~~~^^^^^^^^^
TypeError: must be real number, not mpc
>>> math.floor(1j)
Traceback (most recent call last):
  File "<python-input-9>", line 1, in <module>
    math.floor(1j)
    ~~~~~~~~~~^^^^
TypeError: must be real number, not complex

I mean the mpmath's floor() is defined for mpc types.
Also, here is an example for mod of complex number (especially for Gaussian integers):
Mod(3e+4πi, e+πi) = (3e+4πi) - (e+πi) floor((3e+4πi) / (e+πi)) =  (3e+4πi) - (e+πi) floor(3.57… + 0.49…i) = (3e+4πi) - (e+πi)·3 = πi
(Also check out Wolfram Language: https://wolfram.com/xid/02cbm-ctu0mc, https://www.wolframalpha.com/input?i=(3e%2B4πi)+%2F+(e%2Bπi))


set container per section & fix layout footer

I have edited many parts on this netflix ui clone,
first, that is on a section by section, here I change it to be like the official from the netflix web, from like this

to like this

Second, I also tidy up the footer. I changed it from this

to like this

for reference to the official netflix website, it can be seen on the following website https://www.netflix.com/

resolve conflicts

resolve conflicts

I have fixed the conflict, and made sure the code actually runs properly

still there is some comflict in styles.css i can see

I have finished it. Previously I have fixed the conflict, but maybe because of another pull request, so I have to fix this conflict pull request again

still there is some comflict in styles.css i can see

Please, can you review my pull request

you have conflicts in index.html


S3Client.listObjects always return an empty array

What
It's been reported that the S3Client.listObjects returns an empty Array. We were able to reproduce the issue and should work towards a better understanding of what happens and a fix.
const s3 = new S3Client(awsConfig)
const objects = s3.listObjects(existingBucketNameWithExistingObjects)
console.log(objects) // []

Considerations
Ideally, we should consider introducing end2end tests to assert we don't break these kinds of operations in the future. localstack has been mentioned many times and seems a good option. As the signature process has unit tests asserting its correctness, we probably can afford a solution that doesn't require any authentication.
How
Needs investigation
Definition of done
For a given bucket, containing N files, a user with the appropriate permissions should be able to retrieve an array of N objects by calling S3Client.listObjects on it.

Maybe as a result of my session token #5 not having enough rights?

Found what was causing the issue (my typescript noobness for the most part): [`list-type=2&prefix=${prefix}](https://github.com/grafana/k6-jslib-aws/blob/main/src/internal/s3.ts#L88). As it turns out, `prefix` is an optional string parameter, I assumed that if not set it would hold an empty string (as optional types are a bit... atypical in TS). It would rather hold `undefined`.
Which would lead to the URL ending up looking like: https://test-jslib-aws.s3.us-east-1.amazonaws.com/?list-type=2&prefix=undefined, effectively asking AWS to send us back the list of objects prefixed with undefined. Not what we intended...


scrypt/yescrypt support

Thanks for this nice and easy to use library!
Meanwhile, most Linux distros included or even default to yescrypt for hashing user passwords (see also crypt.5 man page).
Any plans to include these into pwhash? :)

Thanks for the heads up, if an algorithm is in glibc it should also be in pwhash. I can't work on it right away, but it will be on my radar, and I'll keep this issue open as a reminder.

Thanks for the quick response! That would be great!


[Bug]: In the application deployed event there is a missing data field

Is there an existing issue for this?

[X] I have searched the existing issues

Description
In the application deployed event there is a missing data field i.e "Visibility": Private

Steps To Reproduce

Login as admin
Now click on member and setting tab
now from general tab click on Audit log menu
now check for application deployed event
in JSON check for the Data "Visibility": Private which is currently missing

Public Sample App
No response
Version
http://ec2-65-2-149-212.ap-south-1.compute.amazonaws.com/applications

@RakshaKShetty This is available on EC2 now.

@RakshaKShetty All application object will have visibility now.


Revert workaround for Kotlin lack of Java 21 support in kotlin-dsl plugin

This is not required anymore now that we have Kotlin 1.9.20 embedded which supports Java 21 and automatically caps the jvm target to the latest supported.

Reverts #26758

@bot-gradle test this without PTS

I've triggered the following builds with parameters: -DenablePredictiveTestSelection=false for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

@bot-gradle merge

I've triggered a build for you. Click here to see all failures if there's any.


Extract configuration from core module to API

Moves all configuration classes to the tracer module such that plugins can access it without depending on the agent core module.
Configuration that is exclusively used by the plugins, is moved to the core module altogether. Configuration that is used by both plugins and the core is split where plugins can access such configuration via a plugin.

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-04-25T21:08:53.492+0000

Duration: 5 min 0 sec

Steps errors
Expand to view the steps failures

Load a resource file from a library

Took 0 min 0 sec . View more details here
Description: approval-list/elastic/apm-agent-java.yml

Error signal

Took 0 min 0 sec . View more details here
Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/raphw return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/raphw : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/raphw : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

:robot: GitHub comments
Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark tests.

run jdk compatibility tests : Run the JDK Compatibility tests.

run integration tests : Run the Agent Integration tests.

run end-to-end tests : Run the APM-ITs.

run windows tests : Build & tests on windows.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Sorry, had to force push due to a changed user name for demonstrating an exploit somewhere else. Forgot to reset that change.

@elasticmachine run elasticsearch-ci/docs


Deploying via CLI using West US 2 fails

Type of issue

[x ] Bug
[ ] New feature
[ ] Improvement

While trying to deploy via CLI and using West US 2, it fails with the following error -
Deployment validation failed:
{
"code": "InvalidTemplate",
"message": "Deployment template validation failed: 'The provided value 'eastus 2' for the template parameter 'tsiLocation' at line '1' and column '15372' is not valid. The parameter value is not part of the allowed value(s): 'eastus,eastus2,westus,westus2,westcentralus,northeurope,westeurope'.'."
}

@VidyaNallathimmayyagari This issue has been fixed.


Python packages version confit

When I run your project, I do not know your environment. I install package but is not same with your version.
For example, when I run the code but throw Exception with follow in FeatureExtractor line 105(execute model_manager.get_encoder func):
A load persistent id instruction was encountered, but no persistent_load function was specified.
So, could you give your packages version with requirement.txt or other way？
Thank You!

Hi @wang836564944 Sorry for the late reply.
I uploaded the requirement.txt file to this repository and finished the test on the new anaconda environment with python 3.8.
I hope this answer helps your works : )

Thank you very much! This helped me a lot.


Providing the tcl file for the partial modules

Hello there,
In create_pr.tcl file, you used tcl files for rms (in line 12). How can I have those files? It seems we should provide them one by one, then convert the hierarchy block (gpio_0) to a partial region and use them to get the bitstream. However, in the tutorial video, it is shown how to get tcl when the hierarchy part (gpio_0) is already converted to PR. How we can have them to be imported in create_pr.tcl?

Open the PR region as a block design, then use the tcl command write_bd_tcl. If you need to generate different tcls for RMs, make changes to the opened block design and reuse write_bd_tcl.

I wrote a class in Python (Jupyter notebook) to download the partial bitstreams on PYNQ and I could run your project on v2.3. But when I start your project from scratch, I could not have the tcl files for partial modules.
When the project is open, I click on the goip_0 then it is opened. It contains three sub-blocks. One of them is rm and the others are static. Then I use write_bd_tcl.  This command generates the same tcl file as gpio_pr. Both are completely the same. Do you mean I can open the partial region without opening the design (gpio_pr)?

When you write_bd_tcl, make sure the PR region is the currently opened block design. Give it another name so you don't confuse yourself. It should work.

Not working. It gives me the same file as the main block diagram. May you set some option for this? Or use write_ip_tcl command?

I am attaching the result after running write_bd_tcl:
Successfully read diagram <gpio_pr> from BD file </home/yunq/workspace/pynqz1_partial/boards/Pynq-Z1/gpio_pr/gpio_pr/gpio_pr.srcs/sources_1/bd/gpio_pr/gpio_pr.bd>
open_bd_design: Time (s): cpu = 00:00:25 ; elapsed = 00:00:20 . Memory (MB): peak = 7350.129 ; gain = 0.000 ; free physical = 10669 ; free virtual = 49112
open_bd_design {/home/yunq/workspace/pynqz1_partial/boards/Pynq-Z1/gpio_pr/gpio_pr/gpio_pr.srcs/sources_1/bd/led_0/led_0.bd}
Adding cell -- xilinx.com:ip:axi_gpio:2.0 - btns_gpio
Adding cell -- xilinx.com:ip:axi_gpio:2.0 - leds_gpio
Adding cell -- xilinx.com:ip:axi_gpio:2.0 - rgbleds_gpio
Adding cell -- xilinx.com:ip:axi_gpio:2.0 - switches_gpio
Successfully read diagram <led_0> from BD file </home/yunq/workspace/pynqz1_partial/boards/Pynq-Z1/gpio_pr/gpio_pr/gpio_pr.srcs/sources_1/bd/led_0/led_0.bd>
write_bd_tcl example.tcl
INFO: [BD 5-148] Tcl file written out </home/yunq/workspace/pynqz1_partial/boards/Pynq-Z1/gpio_pr/gpio_pr/example.tcl>.

I checked example.tcl contents, it is the partial block design.
Another thing you can try is the Generate Block Design on the left panel of your GUI.
I am not sure which vivado you are using, if not 2018.3, please try 2018.3

Do you set Tool->Enable Partial Reconfiguration? Maybe it is just the difference?

Yes I did


Refine the ModelReaderWriterOptions to reuse a cached instance

Description
Add your description here!
Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

@m-nash @annelo-msft could you also have a review?


fix: ps cmd should ignore dead runners

fixes #1046
Runners that were found to have died (rather than cleanly being killed) end up with module_name not set to null.
This PR filters them out correctly from the ps command

Are these runners getting reaped eventually, and if so does the reaping correctly set the module_name to NULL eventually? If not it seems like we should fix that?

Are these runners getting reaped eventually, and if so does the reaping correctly set the module_name to NULL eventually? If not it seems like we should fix that?
Looking into why it's not being set to null.
I don't think the reap job touches these runners because they are set to dead immediately, and the SQL for that filters by <> dead

It's the deregister runner code that is setting it to dead in the db without updating deployment_id and module_name. I've updated the sql to amend that.
But I think the reap case will also end up those columns not nulled out... I'll set this PR back to draft and try recreating that case next week

Handled the above cases and updated PR description


Return to home on click when max zoom reached

Is there anyway to make it so that if you click on the image when at the maximum zoom level it returns you back to the home zoom level?

That's not a feature we directly support, but it should be easy enough to add a click handler that checks the zoom level and calls the home function if it's big enough. Let me know if you need a code example.

A code example would be awesome.

viewer.addHandler('canvas-click', function() {
  var zoom = viewer.viewport.getZoom();
  if (zoom > viewer.viewport.getMaxZoom() * 0.9) {
    viewer.viewport.goHome()
  }
});

Something like that... I haven't tested it, so it may need some tweaking.


Home assistant addon - unable to access file to retrieve bearer token

I spoke some with gcampax to work on integrating api calls into a home assistant implementation of node-red/almond. The direction given for the authentication step was to retrieve the bearer token from "/data/almond-server/prefs.db in the add-on container" where it should have been set up during setup/startup.
I was unable to find a method to access the file, and a search of the entire home assistant file system (ls -laR / | grep prefs.db) came up with zero hits. Per https://github.com/home-assistant/operating-system/issues/634 my understanding is that the add-on files are inaccessible.
One potential option I can think of is to set the bearer token to be available in a config file (editable if the user wants to modify it), and expose that config file for read/write in the Home assistant>supervisor dashboard > almond > configuration tab (I tried attaching an image of the add-on page with the configuration tab available, hopefully it goes through). All that said, I do not have a background in add-on setup, or the integration into Almond, so while that seems like an easy method to me, there may be better options to expose the bearer token to home assistant users.
Thanks for your work on this project and add-on for home assistant. Bit of background - my personal intermediate goal is to tie together my existing setup of Rhasspy server/satellites into Almond via API calls rather than having to hardcode (in node red) every command/response manually for Rhasspy.

Example of the configuration tab from another add-on to show where I was thinking it could work well to expose:


Fix spelling test

Environmental Info:
K3s Version:

Node(s) CPU architecture, OS, and Version:

Cluster Configuration:

Describe the bug:

When merging a PR, we have a spell check test running. It is failing right now with the error:
Run codespell --skip=.git,./scripts,MAINTAINERS,LICENSE,go.mod,go.sum --check-filenames --ignore-regex=.te# --ignore-words=.codespellignore
./tests/e2e/validatecluster/validatecluster_test.go:304: stoped ==> stopped
Error: Process completed with exit code 65.

This PR fixes that
Steps To Reproduce:

https://github.com/k3s-io/k3s/actions/runs/5241218582/jobs/9463021221
Expected behavior:

No errors in the spell check
Actual behavior:

Additional context / logs:

Closing as this is tested/validated in CI itself


Add blog post on "MongoDB Alternatives: 5 Database Alternatives to MongoDB for 2023"

Description
Closes FerretDB/engineering#16.

Readiness checklist

[ ] I added/updated unit tests.
[ ] I added/updated integration/compatibility tests.
[ ] I added/updated comments and checked rendering.
[ ] I made spot refactorings.
[ ] I updated user documentation.
[ ] I ran task all, and it passed.
[x] I ensured that PR title is good enough for the changelog.
[x] (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
[x] I marked all done items in this checklist.

@ptrfarkas wanted to take a look


Add persistent storage of installed toolchains

Extends #3726
Moves toolchain storage out of UV_BOOTSTRAP_DIR (./bin) into the proper user data directory as defined by #3726.
Replaces UV_BOOTSTRAP_DIR with UV_TOOLCHAIN_DIR for customization. Installed toolchains will be discovered without opt-in, but the idea is still that these are not yet user-facing.

I'm going to write a TestContext for uv-interpreter to make the setup less complicate.d

There's an open question about versioning. We probably shouldn't just discard old buckets like we do in the cache. Maybe we can version and write explicit migrations?

Updated to include #3726 which wouldn't pass CI otherwise since it was unused.


[Bugfix]Fix VideoCaptureElement is black out when front buffer is unavailable.

See #61, #42 and #3

Looks good, I'll test that later. Just the user associated with the commits does not match your GitHub account.

Yeah，the user is uesed for GitLab.
I deployed the same ssh key in github and gitlab

You may rewrite the commits, and push --force them, if you like.

Done

@Rhuaer I'm sorry I've deleted your commits from your fork by a mistake. I still cannot do properly amending PR commits and merge them. But I will commit everything into the Sascha-L/WPF-MediaKit master soon, so you can check it again.
I've just fixed the TestApplication camera and media element switching.

@Rhuaer I'm sorry I've deleted your commits from your fork by a mistake. I still cannot do properly amending PR commits and merge them. But I will commit everything into the Sascha-L/WPF-MediaKit master soon, so you can check it again.
I've just fixed the TestApplication camera and media element switching.


Error when when rendering collections is disabled

In my config I set $config['zf-hal']['render_collections'] = false in order to bandaid a problem with recursive entity reference. However, when I do so, the Apigility admin stops working. The main section of /apigility/ui#/api is blank. The javascript console displays this error:
TypeError: Cannot call method 'pop' of undefined
    at http://localhost:8080/zf-apigility-admin/js/app.js:1:5390
    at Array.forEach (native)
    at Object.f [as forEach] (http://localhost:8080/zf-apigility-admin/js/vendor-angular.js:1:1005)
    at f (http://localhost:8080/zf-apigility-admin/js/app.js:1:5326)
    at new <anonymous> (http://localhost:8080/zf-apigility-admin/js/app.js:1:5869)
    at d (http://localhost:8080/zf-apigility-admin/js/vendor-angular.js:1:15787)
    at Object.e [as instantiate] (http://localhost:8080/zf-apigility-admin/js/vendor-angular.js:1:15899)
    at http://localhost:8080/zf-apigility-admin/js/vendor-angular.js:1:32078
    at q (http://localhost:8080/zf-apigility-admin/js/vendor-angular.js:4:23001)
    at A (http://localhost:8080/zf-apigility-admin/js/vendor-angular.js:4:23362)

Not really sure if I should be posting this in zf-apigility or zf-hal, but they're both zfcampus modules so I'll let you guys sort it out.

This repository has been closed and moved to laminas-api-tools/api-tools; a new issue has been opened at https://github.com/laminas-api-tools/api-tools/issues/74.


tonelib-jam: init at 4.6.6 and tonelib-zoom: init at 4.3.1

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 128861 at e43844bb run on aarch64-linux 1

2 packages built successfully:

tonelib-jam
tonelib-zoom

@SuperSandro2000 please check my PR


Error of units in the documentation of eos80.dens(s, t, p)

In the documentation I see that you consider the unit of the density as [kg m :sup:3]. However according to https://unesdoc.unesco.org/ark:/48223/pf0000059832 a density corresponds to [kg m :sup:-3].

This package is deprecated in lieu of TESO-10. You should really be using that one instead. See https://github.com/TEOS-10/GSW-Python. Closing this b/c the only reason this package exists is for legacy purposes.


Fix build

This change is

+1

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


README example does not work

on my machine (OS X 10.8) the server just hangs when a request is received, I think it just get stuck on<EMAIL_ADDRESS>which never calls the block but never returns either (just tested with a quick puts debugging ;) ).
is it supposed to work ?
I tested it with latest celluloid release (0.14.1) and I tested both latest celluloid-dns release and master with the same result :(

I am having the same problem on OSX Yosemite, with both MRI 2.2.0 and RBX 2.2.10. I tried with master, but that makes no difference.

Celluloid::DNS is defunct. Please use RubyDNS:
https://github.com/ioquatix/rubydns


Truncated responses

Hello. The response often comes truncated, with the first few characters missing, especially when the response is long. For example, instead of "This is the answer to your question," comes "s the answer to your question."

Hi, well, it's a matter of how the AI responds to you.


⚠ Bofrost.be has degraded performance

In 526eb0d, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1071 ms

Resolved: Bofrost.be performance has improved in f952705 after 1 hour, 19 minutes.


steam.apps.search_games fails to convert id in apps.py when link has a list of ids

Bug
I found a bug in steam.apps.search_games that occurred when I searched for Fallout 4 using the method. Here's an example:
Example
Running test_steam_api.py
# test_steam_api.py
from steam import Steam
from decouple import config
# Get steam api key loaded from .env
STEAM_API_KEY = config("STEAM_API_KEY")
# Connect to steam api
steam = Steam(STEAM_API_KEY)
# Search for Fallout 4 title
steam.apps.search_games("Fallout 4")

Error
Traceback (most recent call last):
  File "/Users/jam/.pyenv/versions/3.11.5/lib/python3.11/runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jam/.pyenv/versions/3.11.5/lib/python3.11/runpy.py", line 88, in _run_code
    exec(code, run_globals)
  File "/Users/jam/.vscode/extensions/ms-python.python-2023.18.0/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher/../../debugpy/__main__.py", line 39, in <module>
    cli.main()
  File "/Users/jam/.vscode/extensions/ms-python.python-2023.18.0/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher/../../debugpy/../debugpy/server/cli.py", line 430, in main
    run()
  File "/Users/jam/.vscode/extensions/ms-python.python-2023.18.0/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher/../../debugpy/../debugpy/server/cli.py", line 284, in run_file
    runpy.run_path(target, run_name="__main__")
  File "/Users/jam/.vscode/extensions/ms-python.python-2023.18.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 321, in run_path
    return _run_module_code(code, init_globals, run_name,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jam/.vscode/extensions/ms-python.python-2023.18.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 135, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/Users/jam/.vscode/extensions/ms-python.python-2023.18.0/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 124, in _run_code
    exec(code, run_globals)
  File "/Users/jam/Projects/steam_api_playground/test_steam_api.py", line 11, in <module>
    steam.apps.search_games("Fallout 4")
  File "/Users/jam/.local/share/virtualenvs/steam_api_playground-W4Haidyw/lib/python3.11/site-packages/steam/apps.py", line 111, in search_games
    app["id"] = int(string_id.replace("\\", "").replace('"', ""))
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: invalid literal for int() with base 10: '377160,435870,435880,435881,480630,480631,490650'

Debugging Screens: Multi-Id Link is Unique
Debug screen 2 shows the entries in the debugger before the exception is thrown. It throws an error trying to convert the 3rd link (at index 2) which is the only entry with multiple ids. It seems that this edge case is not handled currently. I am not sure if this is unique to this title or not, I haven't tested any other examples.
Debug Screen 1

Debug Screen 2

I've been having this issue too. Do you have any updates on it?

@sgjholt @AhmedSherifH i submit a fix for this here  #14  if you want to test and try it

@sgjholt @AhmedSherifH i submit a fix for this here #14 if you want to test and try it

Thanks, I will take a look!

Sorry for being late on this! Update the package to 1.2.1. The fix is there! Thank you @UnreleasedDev !!


Use smaller data set for profiling

The current profiling functionality relies on a rather larger data set (1.8GB) and then uses just a manageable slice. See also https://github.com/ImperialCollegeLondon/pyrealm/blob/ad32a8eff8ea42ded2a6cefc0d33880e8560332b/tests/pmodel/test_profiling.py#L27 .
This needs some looking into.
Options to consider:

Keep the large data set and define a minimum slice that still gives reasonable results but reduces runtime.
Find/build a smaller data set.
Create a smaller synthetic data set (which might not even need be populated with realistic values).

In the long term, it would be more elegant to generate the data set. But it's good for now.


Improve the formatting of console output

We should review the places where console output is used and:

improve the usage of colors - after playing with some command line tools, a small set of well applied colors - red, yellow, green and perhaps blue/magenta can do wonders for readability of the output
improve indentation of the output

To clarify - I do not mean the script output itself as that should be up to the script itself to format its output, but the debug output, the errors/warnings output, the non-run script commands, REPL, compilation/export and so on

Closed by #328 and #330


AdMob Interstitial ad not show full size into screen

I have an Interstitial Ad in DFP. My creative is 320x480 like is recommended for Instertitials by DFP. But when I call the ad from the app, this not showed full size into screen and look so:

How do to fit the ad to the screen like that?

320x480 sounds small to me. But I'm sorry to say that you should look for an answer somewhere else, since the sizing of the interstitial is not managed by this library, but by the Google Mobile Ads SDK.


The macro __HAL_FLASH_CLEAR_FLAG does not work properly

I am experiencing an error when I write data to EEPROM.  I suspect that __HAL_FLASH_CLEAR_FLAG does not property clear FLASH->SR, and the macro should be defined as follows.
#define __HAL_FLASH_CLEAR_FLAG(__FLAG__)  ((FLASH->SR) &= ~(__FLAG__))
I would appreciate if you could take a look at the code.

Hello @tomatsu,
Thank you for your contribution, In fact, these flags are cleared by writinig 1 according to RM0394 Rev 4 page 102. Here's how you might define a macro to clear a flag by writing a 1:
#define __HAL_FLASH_CLEAR_FLAG(__FLAG__)  ((FLASH->SR) = (__FLAG__))  which is correct in our driver.
Regarding the point for which you opened the issue, as it is irrelevant, allow me to close the issue.

Hello @tomatsu,
Thank you for your contribution, the macro you provided:
#define __HAL_FLASH_CLEAR_FLAG(__FLAG__)  ((FLASH->SR) &= ~(__FLAG__))
is intended to clear specific flags by performing a bitwise AND operation with the complement of the flag. This method is typically used for flags that are reset by writing 0. However, as per RM0394 Rev 4 page 102 the flags in the FLASH->SR register are cleared by writing 1.
Therefore, the correct definition should be:
#define __HAL_FLASH_CLEAR_FLAG(__FLAG__)  ((FLASH->SR) = (__FLAG__))
This aligns with our driver's implementation. As for the issue you raised, since it is not relevant, I will proceed to close it. Thank you for your comprehension.
With regards,


fix(plugins/plugin-client-common): Add sass mixins for Grid cells and…

… Card Footer
Fixes #7410
mostly size/L because of the refactoring to take advantage of the new mixins.

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[ ] 🐛 Bug fix
[x] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

/lgtm


Proxy configuration

Hi,
i have a use case that sink connector would suffise if it had Proxy configuration. Currently we cannot use it as not able to connect to SaaS product without proxy usage and we tried to use environment variables/add to JVM for proxy but that also didn't work. Is it possible to add it?
Regards

Thanks @bucioo ! I think this make sense and can unblock other users having similar constraints.
I've look into the Jdk http library and setting proxy host:port should do the trick.
Would you mind giving a try to #215 ? We may need to add some integration test to validate the approach, but let us know if it solves the issue for your environment.

Hi @jeqo, thank you for adding proxy configuration.
I was able to build application, not without problems as in our org we cannot download pkgs from internet, but i can confirm that error "java.nio.channels.UnresolvedAddressException" which i had before is no longer there.
Unfortunately we cannot connect to the endpoint via https as now i have error about certificates, same as #216. Tried to add key/trustore to JVM but no luck.
Pls suggest if there is a way to skip certs validation or this conf would need to be added to the code?


add ignore interaction property

Added ignoreInteraction property to ScrollShadow so that the shadow will be ignored from interactions while you can still interact with the widget below. Defaults to true.

Thank you so much @coruscant187 for your contribution,
great work!


Move Resource#openRandomReader, Resource#openReader to ResourceLoader interface (or replace them with openStream)

Issues:

org.ec4j.core.ResourcePath.ResourcePaths#ofPath(Path path, Charset encoding) requires encoding which makes no sense.
Resource#openReader and Resource#openRandomReader make no sense for binary files (e.g. .jpg, .png).
Users have to guess encoding (or use a dummy one) when using ResourcePaths#ofPath and org.ec4j.core.Resource.Resources#ofPath

Samples
The current org.ec4j.core.ResourcePropertiesService#queryProperties(Resource resource) looks weird.
It requires Resource argument which in turn requires encoding.
That produces a chicken-and-egg problem.
Suppose there's .editorconfig file, and suppose there's sample.xml
[*.xml]
charset=windows-1251

What is the way to call ResourcePropertiesService#queryProperties to get the encoding of sample.xml file?
The current API requires clients to pass a dummy encoding which is never used, and which might be confusing.
For instance: https://github.com/ec4j/ec4j/blob/b4038eca6ac82d193f41d4176b27119a70be3bba/core/src/test/java/org/ec4j/core/EditorConfigUnsetTest.java#L47-L48

Thanks for the suggestion, @vlsi.

org.ec4j.core.ResourcePath.ResourcePaths#ofPath(Path path, Charset encoding) requires encoding which makes no sense.

ec4j is a low level library that has little to no ambition to hide details from its users. It is typically left up to the caller to figure out those details, like which encoding should be used to read resources under a given path.

Resource#openReader and Resource#openRandomReader make no sense for binary files (e.g. .jpg, .png).

I agree there is no point in calling those methods for binary files. Again it is up to the caller to figure out which files are binary.

Users have to guess encoding (or use a dummy one) when using ResourcePaths#ofPath and org.ec4j.core.Resource.Resources#ofPath

No, I'd say users are supposed to know the encodings of the files they want to read.

Samples
The current org.ec4j.core.ResourcePropertiesService#queryProperties(Resource resource) looks weird.
It requires Resource argument which in turn requires encoding.
That produces a chicken-and-egg problem.
Suppose there's .editorconfig file, and suppose there's sample.xml
[*.xml]
charset=windows-1251

What is the way to call ResourcePropertiesService#queryProperties to get the encoding of sample.xml file?

The EditorConfig spec. says that

EditorConfig files should be UTF-8 encoded, with LF or CRLF line separators. Source: https://editorconfig-specification.readthedocs.io/en/latest/#file-format

So you should read .editorconfig files using utf-8 and then go on to eval which encoding holds for sample.xml. The encoding to read .editorconfig files in the hierarchy of parent dirs of sample.xml is taken from the Resource you pass to ResourcePropertiesService.queryProperties(Resource). I admit, it may sound a bit unintuitive, and there is perhaps some potential to explain it in the JavaDoc. In any case the encoding of Resource is neither unused nor dummy.
Of course, it is up to you to decide whether the EditorConfig spec makes sense for your tool. ec4j gives you all means to coin your own convention. You are free to pass your own implementation of Resource that will operate without explicit encodings.

So you should read .editorconfig files using utf-8 and then go on to eval which encoding holds for sample.xml

@ppalaga ,
Supose I have the following file structure:

So you should read .editorconfig files using utf-8 and then go on to eval which encoding holds for sample.xml

@ppalaga ,
Supose I have the following file structure:
.editorconfig <-- regular file, with root=true
src
   .editorconfig <-- one more .editorconfig, it says [*.xml] charset=...
   main <-folder
       test.xml <-- test file

Could you please tell me which ec4j API should I use in order to figure out the charset and other properties of test.xml?

You are free to pass your own implementation of Resource that will operate without explicit encodings

Resource interface requires me to implement openReader and even openRandomReader which make no sense for me.
Are those methods really used by ec4j? Why is it important to have them in the ec4j API?

ec4j is a low level library that has little to no ambition to hide details from its users

My point is not hide details, but I ask to remove unnecessary methods from the API.
The low-level API should expose the bare minimum of the methods rather than "all the possible methods".
For instance, RandomReader is never used in ec4j-core, so it is very strange Resource#openRandomReader exists at all.

Here's the sample from "readme":
https://github.com/ec4j/ec4j/blame/9976b428605e57cb7c3b7a35d3f17a99810725d6/README.adoc#L64
ResourceProperties props = propService.queryProperties(
    Resources.ofPath(Paths.get("/my/dir1/Class1.java"), StandardCharsets.UTF_8));

It basically tells me "even if I want to request charset property, I must provide some sort of when creating a resource".

One question at time please. My time is limited. ec4j has users, so backwards-incompatible changes will only be accepted for good reasons.

Ok, my question is (it is exactly as in https://github.com/ec4j/ec4j/issues/116#issuecomment-680764321 )
Supose I have the following file structure:
.editorconfig <-- regular file, with root=true
src <-- folder
   .editorconfig <-- one more .editorconfig, it says [*.xml] charset=...
   main <- folder
       test.xml <-- test file

Could you please tell me which ec4j API should I use in order to figure out the charset and other properties of src/main/test.xml?

Something like this:
        ResourcePropertiesService propService = ...;

        Charset editorConfigEncoding = StandardCharsets.UTF_8; // encoding to use to read .editorconfig files.
        ResourceProperties props = propService.queryProperties(Resources.ofPath(Paths.get("src/main/test.xml"), editorConfigEncoding));
        String defaultCharset = "utf-8"; // use this if no charset is set in .editorconfig files
        String charsetFromEditorConfig = props.getValue(PropertyType.charset, defaultCharset, false);

That is the issue I mention: encoding to use to read .editorconfig files should be a property of EditorConfigLoader rather than a property of Resource or ResourcePath.
Resources.ofPath(Paths.get("src/main/test.xml"), editorConfigEncoding) looks extremely weird, especially as editorconfig encoding must always be utf-8.


Redundant reevaluation of computed properties used by react components.

Hello!
mobx-react do not track dependencies between components contained in each other
so evaluations of computed props they use are not ordered by mobx stale/ready algorithm.
This means that mobx-react's forceUpdate of parent component can eventually
call render method of child component while it's used @computed's are stale.
More precisely, suppose we have two components A and B where A uses B in it's render metod.
There is also Store with two @computed properties x and y both depending on @observable z.
Component A uses x, component B uses y. Now when z changes the following can happen:
z changes -> x evaluated -> forceUpdate A -> render B -> use y which is stale.
Computed properties x and y are not completely pure in my code, they
can make ajax requests, see this for the reasons.
The problem is that component B queries y multiple times, so many equal ajax
requests can be made. I admit that this violates mobx requirement for @computed props
to be absolutely pure functions, but maybe there is some workaround ? :)
All my other code is very neat without autorun's. And as another argument: many reevaluations of pure functions can also be an overhead.
(great work for mobx, @mweststrate, thank you for sharing it!)

Wrote this simple primitive
function isPromise<T>(x:IPromise<T> | T):x is IPromise<T> {
    const p = <IPromise<T>>x;
    return p.then !== undefined;
}

export class ObservablePromise<T> {
    private _valueAtom = new Atom();
    private _isPendingAtom = new Atom();
    private _value: T;
    private _isPending: boolean;
    private _getter: () => (IPromise<T> | T);
    private _pendingValue: T;
    private _autorunDisposer: any;

    constructor(getter: () => (IPromise<T>|T), pendingValue: T) {
        this._getter = getter;
        this._pendingValue = pendingValue;
        this._value = pendingValue;
    }

    public get value(): T {
        if (!this._autorunDisposer) {
            this._autorunDisposer = autorun(() => {
                const value = this._getter();
                if (isPromise(value)) {
                    this._setIsPending(true);
                    value.then(v => transaction(() => {
                        this._setIsPending(false);
                        this._setValue(v);
                    }));
                }
                else {
                    this._setValue(value);
                }
            });
        }
        this._valueAtom.reportObserved();
        return this._value;
    }

    public get isPending(): boolean {
        this._isPendingAtom.reportObserved();
        return this._isPending;
    }

    private _setValue(v: T) {
        this._value = v;
        this._valueAtom.reportChanged();
    }

    private _setIsPending(value: boolean) {
        this._isPending = value;
        this._isPendingAtom.reportChanged();
    }
}

Using it instead of @computed props solves the problem. Is it ok conceptually?

For the example in your first comment: Note that A and B usually render independently when MobX. So even when A renders before B, B renders only one as the shouldComponentUpdate usually prevents the render of B "because it is a child of A". The only exception to that is when assigning new props to B. But now that I think of it that case can maybe be optimized away as well :)
I think your ObservablePromise  is a very neat abstraction! I can imagine that being able to return promises from the getter works very nice with async/await. Thanks for sharing!

@gusev-p so how would this be used?

@capaj something like this:
class PersonsRepository {
    public loadPeson(id: number): IPromise<Person> {
        //...make server request for person
    }
}

class PersonsStore {
    private _repository: PersonsRepository;

    constructor(PersonsRepository repository)  {
        this._repository = repository
    }

    @observable
    public currentId: number;

    //_person.value can be used by regular computed props
    @computed
    public get personName(): string { return this._peson.value.name + " " + this._person.value.surname; }

    //can be used to display progress indicator
    @computed
    publci get personIsLoading(): boolean { return this._person.isPending; }

    //new server request will be made when currentId changes
    private _person = new ObservablePromise(() => this._repository.loadPerson(this.currentId), Person.emptyPerson);
}

@mweststrate for some reason in my case forceUpdate on A always calls render on B ignoring shouldComponentUpdate on it although https://facebook.github.io/react/docs/component-api.html#forceupdate clearly states the opposite: forceUpdate will trigger the normal lifecycle methods for child components, including the shouldComponentUpdate() method of each child.

@gusev-p apologies for the late response. Can you share your components A and B? What might happen is that keys are not setup, or that you pass new closures as callback to the child each time the parent is rendered. This might cause unexpected renderings on the child. The child then re-renders because the props have changed unintentionally.

Closed for inactivity, feel free to reopen when needed


[SPARK-43240] [SQL] Fix the wrong result issue when calling df.describe() method.

What changes were proposed in this pull request?
The df.describe() method will cached the RDD.  And if the cached RDD is RDD[Unsaferow], which may be released after the row is used, then the result will be wong. Here we need to copy the RDD before caching as the TakeOrderedAndProjectExec operator does.
Why are the changes needed?
bug fix
Does this PR introduce any user-facing change?
no
How was this patch tested?

@cloud-fan Please help to review. Thanks.

Do 3.3/3.4/master have the same issue?

Do 3.3/3.4/master have the same issue?

Spark 3.3 have this issue. And spark 3.4 and main doesn't seem to have this issue. Because the StatFunctions.scala is reimplemented and doesn't call the rdd.collect() method.

Oh, you're fixing branch-3.2. It reached EOL, and there won't be more releases in 3.2.x.

I am fine if we can land this to branch-3.3 alone but would need to fix the JIRA's affected version.

I am fine if we can land this to branch-3.3 alone but would need to fix the JIRA's affected version.

Sure. I have change the version to branch-3.3. Please help to review again. Thanks.

Thanks for your review. @cloud-fan Can you help to merge?

thanks, merging to 3.3!


dhcpd broken after update to OPNsense 15.7.2-amd64

the error in /var/log/dhcpd/log is:
no such user: dhcpd

Upgrading from 15.1.x? Using /var MFS? See https://forum.opnsense.org/index.php?topic=850.0
Please close if that thread helps, otherwise we'll need more info.

This manual workaround fixed the issue.

Sorry about the trouble!

At least the support was fast ;)

Doing a /usr/local/etc/rc.recover re-added the dhcp user for me and solved this problem.
I am currently running OPNsense 15.7.7_1-amd64

An hour later dhcpd crashed again with the same problem. Recover solved it again.
I think there is something deeper going on here.

15.7.7_1 comes from 15.7 images, which had a defect, at least for nano images. Which image type are you running, why are you not on 15.7.11?
A guide on how to fix the early nano image was provided with 15.7.1: https://forum.opnsense.org/index.php?topic=915.0


Use #run to send multiline arguments

Ran into a problem when converting a Ruby script to Thor.
With Ruby's system method, you can easily pass arguments that contain line-breaks:
body = <<-BODY.strip_heredoc
  String that
  spans multiple
  lines
BODY

# This works:
system("gh", "pr", "create", "--base", "master", "--title", title, "--body", body)

# Using Thor's `run` method does not:
run("gh pr create --base master --title #{title} --body #{body}")

Is there any way to use the run method in this type of scenario?

Not sure - it looks like Thor uses system to run this command: https://github.com/rails/thor/blob/main/lib/thor/actions.rb#L248
Maybe try fiddling with this and see if you can come up with a PR to fix?


Preset Button Order Needs Review

Generally speaking, buttons should be presented in the order they are most likely to be used. Info and Update are a matter of opinion, but Activate should almost certainly be first while Delete should be last. Activate and Delete certainly shouldn't be next to each other.

As for button placement, I like my action buttons to be on the right instead of the left. Its a personal preference, so Activate will always be on the far right.
However, you do make a good point that maybe delete and activate shouldn't be side by side, so Maybe it should go Delete, Info, Update, Activate?


Fixes #830.

Whenever a property chain returns a null observable, an instance of Observable.Empty<TRet> is swapped in.
Happy to rearrange as you see fit. In particular, I wasn't sure about where I should put the ObservableExtensions helper class.

Thanks!


Recommended worker implementation

This is a question rather than an issue, but I wasn't sure where else to ask. Sorry about that.
We have two batch servers. If I understand the locking correctly, it should be safe to run multiple workers against the same queue on each of these batch servers right?
I'm planning to just run a number of bundle exec rake qc:work processes on these batch servers. Is that a reasonable approach? I'm assuming that the locking mechanism will guarantee that each task is executed and deleted by a single worker only.
Thanks.

That's right. You can run multiple workers on the same queue. The locking will make sure that every job is only worked by one worker.


Automated cherry pick of #3271: region: capability public network count filter by host type

Cherry pick of #3271 on release/2.11.
#3271: region: capability public network count filter by host type

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@610ff5d). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.11   #3273   +/-   ##
==============================================
  Coverage                ?   7.13%
==============================================
  Files                   ?     476
  Lines                   ?   77213
  Branches                ?       0
==============================================
  Hits                    ?    5512
  Misses                  ?   71237
  Partials                ?     464

Flag
Coverage Δ

#aFlag
7.13% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/capabilities.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 610ff5d...742092c. Read the comment docs.


Expression Tree

Norm will postpone any reads from database until they are needed - allowing you to build expression trees and transformations - before it started fetching any data.<<

Can u provide an example of how to do Linq expression.  Using Blazor, a user can filter what records to get dynamically.  The Where is not known until runtime.  The user may select what fields to get back if that is possible with Norm.
Thanks.

Try with this article: https://dev.to/vbilopav/norm-data-access-for-net-core-3-fal


Allow mounting volumes from other containers

Previously all volumes were mounted from disk. This functionality supports downloading and sharing pipeline data in research.

LGTM


Android repo link checker running against entire repo

https://github.com/Azure/azure-sdk-for-android/pull/283#pullrequestreview-465433101
Android repo currently only runs against the service repo instead of the entire repo. We might leave some files unchecked in CI, like README.md under root repo.
Have the issue to track the issue.
Options:

Have an aggregator-report pipeline similar pipelines.
Running entire repo in core pipeline.

@weshaggard @mitchdenny

I prefer one of the two options, depending on speed:

Check all links on all pipeline runs.
Check all links under [service directory] based on the pipeline being run.

I think that the aggregate-reporting pipeline model should be a last resort for things that just don't behave. The reality is that aggregate reports won't get the attention of someone submitting a PR which breaks a link.

I think that the aggregate-reporting pipeline model should be a last resort for things that just don't behave. The reality is that aggregate reports won't get the attention of someone submitting a PR which breaks a link.

I agree that aggregate reports pipeline often gets ignored, we should try to fix that, however I also agree that if someone changes a link in a PR in they might not be notified that it is broken. It might be worth adding having the verify links pipeline check any modified MD files in a given PR.

We currently fixed this by running entire repo when check links. Will fix the workflow once it introduced too much burden in future.
Close the issue as the code has checked in: https://github.com/Azure/azure-sdk-for-android/commit/51a8f23abf47d087c9db54afddd91884f14cb0da

@sima-zhu can you file a follow-up issue in the azure-sdk repo which will filter the link checker to only run against MD files that are changed in a PR.