Annotation Issue: Unnecessary Key Nodes

The current labeled step evaluation regarding URL matching from searches only affirms the URLs found through on-site searches, rather than those accessed via Google searches.
For example, for the first task in the development set ("Browse best selling black hoodies in mens size Big and Tall that is between $25 and $50 in kohls"), since the initial URL is empty, the LLM Agent often resorts to Google search:
When using Google search, the accessed URL is: "https://www.google.com/search?q=best selling black hoodies mens Big and Tall $25 to $50 site:kohls.com". By clicking the first link, the Agent can reach: "https://www.kohls.com/catalog/mens-big-tall-hoodies-sweatshirts-tops-clothing.jsp?CN=Gender:Mens+SizeRange:Big %26 Tall+Silhouette:Hoodies %26 Sweatshirts+Category:Tops+Department:Clothing"
However, the labeled data indicates that one needs to access the URL through Kohl's search function: "https://www.kohls.com/search.jsp?submit-search=web-regular&search=mens+black+hoodie&kls_sbp=34524031611978259241165260194179142249"
{
  "match_function_name": "url_semantic_match",
  "content": {
  "key": "search",
  "reference_answer": "Decide whether are searching for mens black hoodie",
  "url": "https://www.kohls.com/search.jsp?submit-search=web-regular&search=mens+black+hoodie&kls_sbp=34524031611978259241165260194179142249"
  }
}

In the matching method, the key is "search", while the URL accessed via Google search does not include the "search" keyword. This ultimately leads to the agent's attempt to complete the task being considered a failure. However, both search methods can lead to the desired website for the task, indicating that this step's verification URL is not essential for completing the task.

Hi there, thanks for the feedback! Really apologies for the late response. We’ve received similar feedback from the community, and have made some modification of our mind2web-live dataset. Currently, we updated the task instructions to be more specific, such as explicitly instruct the agent to perform searches only on certain websites. However, we still encounter cases where multiple paths can lead to the completion of the task, which, as you pointed out, is not fully captured by the current evaluation method.
Ideally, such cases would require multiple key node sequences for evaluation to enable more accurate in progress evaluation, but we haven’t yet implemented this functionality. We're still refining this work, and we’re open to discussing more robust and accurate approaches for web agent online evaluation. Looking forward to collaborating on finding better solutions together.

Thank you for your reply. I'd like to know if your changes, "We updated the task instructions to be more specific," have been put on the Challenges of your official website. Because after using the dataset_io.py download today, I found that the file is the same as before.

Thank you for your reply. I'd like to know if your changes, "We updated the task instructions to be more specific," have been put on the Challenges of your official website. Because after using the dataset_io.py download today, I found that the file is the same as before.

I was saying that we modified other community reported tasks in this manner, but this one seems a little bit wierd to do so. We have updated the task title to be "Go to knols and search for best selling black hoodies in mens size Big and Tall that is between $25 and $50" for now. Inspired by your feedback, maybe a better way is to set a starting page rather than leave it blank page and remove all key nodes related to stepping on the target website. We will consider implement it in the future.


Django-sitetree update

Per client's request (https://basecamp.com/1849796/projects/9507827/messages/47649148) update django-sitetree on production

This issue seems to have been resolved in idlesign's django-sitetree repo (https://github.com/idlesign/django-sitetree) by pull request 169.

duplicate


docs: fix wrong modules usage links

Currently, clicking those links leads to a page like this:

As they are linked to the wrong files. This pull request fixes it.

This looks like it's attempting to fix https://github.com/nix-community/nixvim/issues/1625, but unfortunately this won't fully solve the issue because those relative links aren't always resolved from the same place.
Essentially, the install page can be accessed via either / or /user-guide/install.html. It is usually accessed at the former location, however relative links are broken at the latter location.

All this PR does is flip the issue, so now links from the / location will be broken while links from /user-guide/install.html will work.

Indeed, you are correct. I had not previously noticed that.


Start defining some encoders and decoders

still a work in progress
going to start with transaction

Thanks a lot for filling this with all the types! I have some questions and remarks before you continue doing it all, I'll start with the questions as they can change the other remarks.

I see you changed exposing (Data) to exposing (Data(..)). Why expose the Data variants (Constr)?
In TransactionBody why the Maybe (List Certificate) and not just List Certificate?
Is RationalNumber a thing of the uplc VM, or just useful stuff provided by aiken?

Additional remarks.
I'm personally not a fan of type aliases that are just name changes, such as type alias Coin = Int. Better have a { coin : Int } record wherever needed as it serves the same name documentation and doesn't hide the actual type.
For Tx Building, I'd like to use the extensible record phantom builder pattern, which provides strong guaranties about the completion of the Tx with still good error messages https://www.youtube.com/watch?v=Trp3tmpMb-o
I have few remarks about the Hash / Bytes stuff after we discuss the main above questions and remarks.

@mpizenberg yea cool, I'm fine with removing and adjusting anything
I kinda was just having fun and got carried away but let's get to some answers.

I see you changed exposing (Data) to exposing (Data(..)). Why expose the Data variants (Constr)?

We need a way to build it up I imagine? I guess we can hide the constructors and use smart constructors so hiding it is fine. For now it just seemed simpler to expose it for writing some tests.

In TransactionBody why the Maybe (List Certificate) and not just List Certificate?

I kind of just copied pallas so perhaps the Maybe is excessive. I guess we'll see when we implement the cbor stuff for it?

Is RationalNumber a thing of the uplc VM, or just useful stuff provided by aiken? OK je viens de voir que c'est utilisé dans poolPledgeInfluence

This was also something I got from pallas and is probably in the cddl file. It's used in some protocol parameter stuff.

I'm personally not a fan of type aliases that are just name changes, such as type alias Coin = Int. Better have a { coin : Int } record wherever needed as it serves the same name documentation and doesn't hide the actual type.

No problem. I'm happy to adjust or for you to clean things up to your taste. Things got chaotic pretty quickly as I started copying types over from pallas and so I just did the bare minimum to have things typechecking.

For Tx Building, I'd like to use the extensible record phantom builder pattern

Wonderful, I was just playing around a bit for fun. I'm happy for that to evolve in the direction you suggested.

I have few remarks about the Hash / Bytes stuff after we discuss the main above questions and remarks.

Yea sorry for messing with the way you did the Hash thing, it was confusing me a little so I just used some aliases for now. I noticed that aliases show up in type signatures (docs on hover) and so I thought it was "cute" enough. I pulled in Bytes because that's what the cbor library works with so I figured we might as well lean into that type instead of Array Int.

That all said, I can change anything and I don't mind if some of my stuff gets deleted or rewritten.

(talking about Data) For now it just seemed simpler to expose it for writing some tests.

Good, then let’s do it that way for now, we can work on the API presented to the user later

(talking about some Maybe (List ...) fields) I kind of just copied pallas so perhaps the Maybe is excessive. I guess we'll see when we implement the cbor stuff for it?

Ok, so I imagine the Maybe (List ...) is a better representation of the encoded data, as the field may be present or not Maybe, and if present, it could still be an empty list I guess. I’m sure Pallas needs the most exact representation as possible. The use case for the Elm offchain library is much more restricted. As much as possible I’d like users to not have different ways of doing things that have the same meaning. In this case, the maybe around the list could be just for structural reasons but could also be because they mean different things, it highly depends on each field, if Nothing and Just [] have different meanings or not.
So the different possible outcomes here:

if it’s complex to abstract away the Maybe with the cbor codec, we keep the Maybe because we have no choice
if cbor codec is no issue, but meaning of Nothing and Just [] are actually different, we keep it
if cbor codec is no issue and Nothing and Just [] have the same meaning, then we strip the Maybe on the Elm side.

(talking about type aliases) Things got chaotic pretty quickly as I started copying types over from pallas and so I just did the bare minimum to have things typechecking.

Ok, it’s an easy refactor after the fact anyway. So keep going through the easy path and we can discuss refactors after this PR.

I watched the video and it looks like I'm using this pattern in the builder but the constructor doesn't have the same name. Maybe I misunderstood?

Let’s focus on codecs for Transaction here, we don’t need the builder for now, we can discuss this after the PR.

Yea sorry for messing with the way you did the Hash thing

Let’s keep it the way you do things, I can discuss later what I had in mind. Mainly bringing some garanties but it has an impact on other things. So let’s do something that works first (what you do) then I can try an improvement.

Thanks for all the work @rvcas and @KtorZ !
As Lucas said in the discord server, it's not complete, but enough to start doing interesting stuff.
I'm interested in having the best representation and api for user consumption, so I'd have many remarks and I'll want to change some things, many @KtorZ pointed at already.
However, your process here has been to mirror a bit the rust code from pallas if I understood correctly @rvcas. So I think it's best I don't intervene too much until the other parts of this is implemented, the decoders. Elm code is super easy to refactor anyway, so I think the best move is I just do some of the obvious checks and changes, then we can merge it. Later, after the decoding part is done in a follow up PR, I'll start a more rigorous review, and suggest changes in a followup PR so that we can discuss these changes.
Is that ok with you @rvcas @KtorZ ?

@mpizenberg Yup. I'd be keen on merging this as-is (for I didn't see anything blatantly wrong so far) and proceed with smaller increments to refactor and re-structure the code to maximise the user-api friendliness, even if it comes at the price of slightly more complicated implementation details internally.
Also, I've played a ton with this kind of code on Cardano and I'd like to suggest a more "granular" file stucture as this is what I concluded works best for this type of API. See for example: https://github.com/CardanoSolutions/kupo/tree/master/src/Kupo/Data/Cardano

Alright I'll let you merge this then.
Regarding the "granular" I'd say it depends what modules are exposed to the users. I'd like to avoid big walls of imports for using the package.

Or rather, it depends on what modules are exposed for "regular" usage, like when building a standard website and building/submitting transactions. Otherwise I a agree with the "data-centric" way of organizing elm modules where a module is focused on one specific data type

I think the best strategy is to:
(a) organize the code around data
(b) re-exports the entire 'Cardano' API in a Cardano module. So that you don't have to search for which import.
That's also exactly how I do it with Kupo: https://github.com/CardanoSolutions/kupo/blob/5760f463656ee558b7c6721e0f92a7697479909c/src/Kupo/Data/Cardano.hs#L11-L39

Hum, ok let's go with your way and let's see where that leads us.


Make sure the spineGeneric single and multi subjects are 100% BIDS compatible

Ultimately they should pass the BIDS validator of OpenNeuro

This one can be closed because data is already on openneuro.


[TW#14487] volatile' qualifier from pointer target type

void vPortReleaseTaskMPUSettings( xMPU_SETTINGS *xMPUSettings )
{
	/* If task has live floating point registers somewhere, release them */
	_xt_coproc_release( xMPUSettings->coproc_area );
}

passing argument 1 of '_xt_coproc_release' discards '
volatile' qualifier from pointer target type [-Wdiscarded-qualifiers]
suggestion:
Typecast or make coproc_area a volatile field as well
best wishes
rudi ;-)

Hi @ESP32DE,
Thanks for reporting this. Sorry it's taken us a while to look into it.
coproc_area is a volatile pointer type and compatible with volatile void * so I'm not sure why you were seeing this warning. We're not able to reproduce on the current IDF & toolchain, maybe this was in an older version?
Feel free to reopen if there are steps to reproduce that we are not setting.
Thanks,
Angus


Allow non-gm users to play cards to the canvas.

In core Foundry, non-gm players lack permission to place tiles, thus only the GM can play cards from their hands onto the canvas. Allowing non-gm players to place their cards could be a great enhancement of this module.
I have a working code already, but it uses the event system provided by Warpgate to relay the placement to a GM account, thus adding another dependency. As you've mentioned here, less dependencies are better. But I don't think reinventing the wheel for this module is worth the effort.
What do you think of adding a new dependency? If you're fine with it, I'll create a PR once #15 is resolved (don't want to mix things up in case you're making changes to that).

It's true that less dependencies are better, but I'm fine with adding libraries. My problem with having Monk's tiles as a dependency is that it's not meant to be a library, so we have no guarantee on the stability of their interface.
That being said the same goes that my spare time is pretty limited, I'll try to give it a look in the weekend.

Also this is definitely a bug, players should totally be able to play their cards.

As I said, I have working code already. We just need to make minor adjustments to respect #17.
We can do this right now if you wish and in 15-20 minutes it'll be done I think.

I definitely don't have the mental energy right now to follow it through 😅 It's 9 pm in my timezone and I come from a day of work. As I said I'll try to check it in the weekend.

Ok I got the gist of it, makes sense. I'll open up a pull request and do some flavor edits. Thanks for the suggestion!


Add semantic card status to docsite

Semantic card status has been designed but has not been added to the docsite yet. Not sure if this has been built yet.
https://www.figma.com/file/eGmDp94FlqEr4iSqy1Uc1K/Paragon-Design-System?node-id=14061%3A6

Card status has already been implemented in https://github.com/openedx/paragon/issues/1328, you can see examples on the docs site in the Card page.


Provide the ability to customize Commands on a per Task basis.

@nickbp:  I'm of two minds about the change to exposing both name and type name.  It seems to expose some complexity that wasn't absolutely necessary.  Users were getting Task naming for free, although they still do if they use default implementations.  In any case, this is more consistent.  I think in the end it's better.

Talked offline about the index handling, LGTM! Resyncing to master then should be good to go.


NIFI-2319: Ensure that when we set cluster node id's and node address…

…es, that we do so only if they are not already populated

+1
Visually verified code and did a contrib check build. I built a secure 3 node cluster and tested various different logic paths related to viewing/emptying the queue and they all worked as expected. Thanks @markap14, I will merge it in.


Media type fix

Fix for #1235

cc @igrigorik for a review.

FWIW, I'm inclined to keep "screen". Both "all" and "screen" are valid types [1], where "screen" is a subset of "all". Switching to "all" doesn't win us anything here, and the update would also have to be reflected in all the translations -- seems like a lot of work for nothing.
[1] http://www.w3.org/TR/CSS2/media.html#media-types

Sorry, I might have been a bit unclear in the description as I was distracted while writing it. The issue is that it says the media type "screen" is equivalent to not setting a media type at all, which isn't correct. Removing that statement would be another solution, as it's not crucial information, but I've submitted a PR changing it to "all" in all the translations if you want to go for that.
On Mon, May 4, 2015 at 10:57 PM, Ilya Grigorik<EMAIL_ADDRESS>wrote:

FWIW, I'm inclined to keep "screen". Both "all" and "screen" are valid types [1], where "screen" is a subset of "all". Switching to "all" doesn't win us anything here, and the update would also have to be reflected in all the translations -- seems like a lot of work for nothing.
[1] http://www.w3.org/TR/CSS2/media.html#media-types
Reply to this email directly or view it on GitHub:
https://github.com/google/WebFundamentals/pull/1236#issuecomment-98847760

Looks like I'm still distracted. I thought you posted that on the issue, not the PR. The original problem description was on issue #1235.

@PontusHorn ok, with you know. LGTM, and thanks for the fix!


BOSH drain, Meet Kubelet drain

Now (unless you turn it off) the kubelet job will evict Pods so that
they get rescheduled on other nodes in the cluster, when we stop jobs.
This should lead to better quality-of-life on clusters during controlled
recreates, stemcell rolls, and software component upgrades / updates.

lgtm


Mouse wheel doesn't trigger any changes

Mouse wheel doesn't trigger any changes.
I would expect the mouse wheel to trigger a change. But when scrolling the wheel no changes occurs. I'm not entirely sure, but I think that a wheel event should be treated similarly to a mouse/pointer move event. Let me know what you think about this. Thanks in advance and keep up the great work.
Step to reproduce:

Open the demo
Start navigating with keyboard
Use the mouse wheel without moving the pointer
No changes in what-input or what-intent

Expected behavior:

what-intent should become mouse?

Hi @matteobad,
There actually is mousewheel support built in, but it appears that it's not functioning as it should so I'm going to take a look at it.
https://github.com/ten1seven/what-input/blob/master/src/scripts/what-input.js#L318-L334

I made an update in the latest release (v5.2.3) that addresses mousewheel not always being detected. Please note that wheel, mousewheel, and DOMMouseScroll all report as mouse.
If you have any issues, please re-open this ticket.

Thank you for your rapid response 👍


Provide context for "handlers must be a hash" error

The error "handlers must be a hash" doesn't tell the user in which file this needs to happen. It would be helpful if it provided more context.
There are other similar errors "X must be a Y" that would also be improved with the same idea.

@nhooey the "handlers": {} definition scope can be in one or more configuration files. All configuration files are deep merged. We recently documented general configuration - https://sensuapp.org/docs/0.21/configuration :+1:


dogehouse.tv is down?

the website seems to work 🤔

it has some kind of a bug or something, can't really use it sometimes

it has some kind of a bug or something, can't really use it sometimes

What bug?


Undo & Redo in editor

Underlying webkit supports undo & redo but thats not exported to use with HTMLEditor.

Included in latest pull request


feat: ServeTypeScript - Write front-end TypeScript

Implements #59
Is dependent on https://github.com/drashland/deno-drash/pull/421
Description

Allows TypeScript to be written on the front-end and served as compiled JS.
Compiles TypeScript files to JavaScript files and stores the JavaScript output in a variable. The JavaScript is served in a response body if a client requests the said TypeScript files. For example, if the the output variable is cache and it contains the key /ts/my_ts.ts, and a client makes a request to /ts/my_ts.ts, then the Drash server would send the value of cache["/ts/my_ts.ts"] back to the client. The client would see the response immediately since the TypeScript files were compiled during compile time.
View the README here

good call. def worthy time be in release notes


Please consider using WeakHashMap for stmts Map in DB.class

Could you please consider changing the stmts HashMap in DB to a WeakHashMap?
We've just spend days tracking down a memory leak in our application which was due to an unclosed PreparedStatement and the only reason it wasn't being GC'd was because of the reference from this HashMap. (It's a long running application which rarely, if ever, closes its open sqlite connections). It would appear that live PreparedStatments consume a considerable amount of off-heap memory which is almost impossible to track in a running Java process and so although the Java heap was a managable size, the Java process itself grew unbounded until the computer ran out of memory.

Is this still happening on the latest version?

I don't know to be honest. We went through our code and ensured that all PreparedStatements were being closed and haven't had a recurrence.
Looking at the implementation in <IP_ADDRESS> it seem stmts still a HashMap so I guess the issue remains.

I don't know to be honest. We went through our code and ensured that all PreparedStatements were being closed and haven't had a recurrence.

I think that was what needed to be done, those resources need to be closed.
Will close the issue.


The Mitogen master process was unable to serve 'ansible.module_utils.distro._distro'

Please drag-drop large logs as text file attachments.
ansible.log

Which version of Ansible are you running?
2.8.3+dfsg-1 from Ubuntu 19.10

Is your version of Ansible patched in any way?
Debian patches

Are you running with any custom modules, or module_utils loaded?
Not that I know

Have you tried the latest master version from Git?
Yes

Do you have some idea of what the underlying problem may be?
No

Mention your host and target OS and versions
Ubuntu 19.10 host, Ubuntu 18.04 target

Mention your host and target Python versions
3.7.4 and 3.6.8

output of "ansible-config dump --only-changed".
DEFAULT_STRATEGY(/home/jak/.ansible.cfg) = mitogen_linear
DEFAULT_STRATEGY_PLUGIN_PATH(/home/jak/.ansible.cfg) =
['/home/jak/Projects/Temporary/mitogen/ansible_mitogen/plugins/strategy']

Working on it right now :) Duplicate of #590. Please subscribe to that bug instead, it's the last before 0.2.8 will be cut. Thanks for reporting this!

This is now on master. Once again thank you for reporting it


Add separate activity to view a dining location's information

Currently, if you tap on a dining hall's name (or, once #3 is implemented, its row), it gives you a Toast if there is no all-you-can-eat menu, and it shows the menu in an AlertDialog if there is a menu.
Going forward, there will be some information about the thing no matter what, e.g. its open hours.
Thus, it would be better to have a separate activity that you go to when you tap on its name, that displays its information.

Completed as per 37a4cffcf14c8048025549a6a8504c1daa197401 :+1: @lidavidm


Fixed #25254 -- Added attribute in JsonResponse to pass kwargs to json.dumps

Hey! Do you need a rebase?

Doesn't hurt. You may also squash commits.

merged in d0bd5330432e1dda519ebd89606bd0980a36dcb4, thanks!


Add test filter option

Would like to see ng test support executing a subset of tests via something like karma's --grep or (perhaps better?) by passing a glob pattern. We use the latter in our pure webpack build today and it's pretty useful when you're working on a single component (or service, directive, etc) and don't need/want  the entire suite to build/execute.

for testing specific block you can append f (focused) to the test syntax
fdescribe(...)

fit(...)

ref https://jasmine.github.io/2.4/focused_specs.html

@antonybudianto Yes and no.
I'd prefer to filter without having to edit the test source.
Ideally, we'd also shave a couple seconds off the build time by only including the tree for the specified tests, vs. building everything and only executing some tests.

This issue came up before https://github.com/angular/angular-cli/issues/3603, but since that one has more discussion I'll keep it open instead.

I am looking for something like the same, any updates on this?

@aitchkhan it's quite a late, but maybe it can be useful for some developers. See this


Whatsapp messaging added

Related Issue or bug
Fixes: #154
Describe the changes you've made

Users will now also be adding the the mobile numbers of their contacts.
Modified the views, form and model accordingly.
Added a script to send whatsapp messages.

Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Tested by running the EMERGENCY functionality of the app.
Describe if there is any unusual behavior of your code
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] My changes generate no new warnings.

Screenshots
Details available here https://github.com/swapnilsparsh/Rescue/issues/154#issuecomment-805518122

@Tarun-Kamboj The message won't be automatically sent right? We need to tap the button to send the message.

@Tarun-Kamboj The message won't be automatically sent right? We need to tap the button to send the message.

Messages are sent automatically. Is that not happening?

No @Tarun-Kamboj

No @Tarun-Kamboj
Can you try it again @sakshikhachane, it's working on my machine. 😅

No @Tarun-Kamboj

Can you try it again @sakshikhachane, it's working on my machine. 😅

Not working 😕

It waits for 20 secs to ensure stable internet connection and then sends the message.

It waits for 20 secs to ensure stable internet connection and then sends the message.

Still not able to use this feature.

@swapnilsparsh @sakshikhachane is it working now?

@swapnilsparsh @sakshikhachane is it working now?

No

I don't know how to fix this since it's working for me already.
If anyone know what's the problem and how to solve, please help.

I don't know how to fix this since it's working for me already.
If anyone know what's the problem and how to solve, please help.

Can you share a working video ?

Can you share a working video ?

https://drive.google.com/file/d/1t8c7zAmLF5Ok1S2m5tunSFZAOiUWNVnr/view?usp=drivesdk
You can see here, I didn't touched the keyboard and the message got sent automatically.

@Tarun-Kamboj Great Work.

@Tarun-Kamboj Great Work.

Thanks.


why there is no flag for typescript?

As we know typescript is a very popular language these days. why don't you rewrite it with that or making a flag for creating a new express app by typescript for app generator??

I don't know typescript, but if you know someone who does and has the time and ability to add it to the generator, then it would be accepted. The tracking issue for adding typescript to the generator is https://github.com/expressjs/generator/issues/125

Hey @dougwilson I have not shared this much yet, but I have been working on a more robust and extensible project generator which builds off of the npm init functionality.  My goal was, once finished, to propose replacing the current generator with this more modern take.  If this direction sounds good, maybe we can send @apcom there to contribute the typescript template?
Link for reference: https://github.com/wesleytodd/create-express-app/


Mark foo[:bar] as not complex in Style/TernaryParentheses cop

Square brackets behavior is now same as Style/RedundantParentheses.
# EnforcedStyle: require_parentheses_when_complex
#
# # bad
# foo = (bar[:baz]) ? a : b
#
# # good
# foo = bar[:baz] ? a : b

It seems better to extract non_complex_type? to mixin and
Style/RedundantParentheses and Style/TernaryParentheses
use it even if incompatibility comes.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[ ] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

It seems better to extract non_complex_type? to mixin and
Style/RedundantParentheses and Style/TernaryParentheses
use it even if incompatibility comes.

Yeah, guess this would be best.


change the search method in multiple files

Ag is 5-10x faster than Ack.
https://github.com/ggreer/the_silver_searcher

Ag is used when it's present. https://github.com/avelino/vim-bootstrap/blob/master/vim_template/vimrc#L347-L351


NSURLSessionTask completion block not called when not following redirects

When -[NSURLSessionTaskDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:] calls its completion handler with nil to indicate that the redirect should not be followed, the completion handler from -[NSURLSession dataTaskWithRequest:completionHandler:] is normally called with the actual redirect response itself.
But when using OHTTPStubs such that a stub returns a redirect response, the task’s completion handler is simply never called.

Fixed by merging #175 👌


Card component

Duplicates ❌

[X] I have searched the existing issues

Which Figma library is concerned?
Not related to one Figma library
Summary 💡
Card refacto with Nathan Curtis method of sub components.
Examples 🌈
https://medium.com/eightshapes-llc/subcomponents-753ce9f6600a
Motivation 🔦
All the possible combinations with the current card are quite obscure.
New 🆕

[ ] Validated in a grooming session

Backlog 📋

[ ] Has a good summary
[ ] Has example link(s)

Design in progress 🏗

[ ] Analysis (functional & technical)
[ ] Design refinement
[ ] Dev qualification (properties, breakpoints, tokens etc.)
[ ] Documentation refinement (inside the Figma branch)

Design review 👀

[ ] Figma branch merged
[ ] Documentation review _(and move the documentation into Vitamin Documentation Figma file)

Ready to dev 👍

[ ] Issues are created in all repositories affected (vitamin-<web,android,ios,compose>)

Dev in progress 💻

[ ] All issues are resolved (to replace with issues links)

Fyi: https://github.com/Decathlon/vitamin-design/issues/146

A new ticket has been created on an inner source repository


kube-aws: installation instructions include GPG verification

Throwing binaries on S3 is not advisable when we also have the github release tarballs as well, so we won't be doing that anymore.

\cc @dghubble

Otherwise, LGTM

lgtm.
/cc @joshix @robszumski for doc changes

@joshix @robszumski docs changes enacted. no more instructables in the sh blocks ;)

@cohhom PTBF. If you want to get really fancy, add colons : at the ends of each line before the command block it introduces. But if not, we can iterate that later.


phpwhois error running php version 7.1.14

Appears to be an issue with phpwhois
https://mycooldomain.lan/SPFtoolbox/getWhois.php?domain=abc.net.au

Warning:  Illegal string offset 'domain' in /Volumes/MyMagicDrive/SuperSecret/Directory/Apache/SPFtoolbox/phpwhois/whois.parser.php(370) : eval()'d code on line 1

Fatal error:  Uncaught Error: Cannot use string offset as an array in /Volumes/MyMagicDrive/SuperSecret/Directory/Apache/SPFtoolbox/phpwhois/whois.parser.php(370) : eval()'d code:1
Stack trace:
#0 /Volumes/MyMagicDrive/SuperSecret/Directory/Apache/SPFtoolbox/phpwhois/whois.parser.php(370): eval()
#1 /Volumes/MyMagicDrive/SuperSecret/Directory/Apache/SPFtoolbox/phpwhois/whois.au.php(54): generic_parser_b(Array, Array)
#2 /Volumes/MyMagicDrive/SuperSecret/Directory/Apache/SPFtoolbox/phpwhois/whois.client.php(472): au_handler->parse(Array, 'abc.net.au')
#3 /Volumes/MyMagicDrive/SuperSecret/Directory/Apache/SPFtoolbox/phpwhois/whois.client.php(257): WhoisClient->Process(Array, true)
#4 /Volumes/MyMagicDrive/SuperSecret/Directory/Apache/SPFtoolbox/phpwhois/whois.main.php(259): WhoisClient->GetData('abc.net.au', true)
#5 /Volumes/MyMagicDrive/SuperSecret/Directory/Apache/SPFtoolbox/getWhois.php(15): Whois->Lookup('abc.net.au')
#6 {main}
  thrown in /Volumes/MyMagicDrive/SuperSecret/Directory/Apache/SPFtoolbox/phpwhois/whois.parser.php(370) : eval()'d code on line 1

Client Side:
Failed to load resource: the server responded with a status of 500 (Internal Server Error)

Receiving error 500 when searching '.com' domains. PHP version 7.1.14 as well. IIS 10, Windows server 2016.
Searching other '.co.uk' domains works as expected.

Resolved issue by installing 7.0.x along side of 7.1.14. With IIS 10, it automatically switch the "site" to an earlier version and now all works great.

I am working to programmatically fix this error but whenever I debug it it works.

If there is anything I can do to assist, feel free to ask.


Enable curated packages installation for controller via CLI

Issue #, if available:
Description of changes:
Enable curated packages installation for controller via CLI
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


build single js file and single css file like Svelte does.

Describe the problem
Is there an option or an adaptor that will build the app as svelte does - with a single js file and single css file?
Describe the proposed solution
This makes embedding into wordpress much simpler.
Alternatives considered
I am using the adapter from '@sveltejs/adapter-static' but this builds each component into many individual js and css files.
Also tried the wordpress adapter. It is not compatible with the latest version of Svelte Kit. And I do not believe it will create a single js file and single css file.
Importance
i cannot use SvelteKit without it
Additional Information
No response

You may be interested in the inlineStyleThreshold option: https://kit.svelte.dev/docs/configuration#inlinestylethreshold
The name is based on the file contents. This allows the file to be cached. Can you explain more about why you would want to link to these files?

Thanks for the idea but I don't think it will work in this case.
I have several svelte apps which I am dynamically inserting into wordpress content via shortcodes. In wordpress/php I wp_register_script() and wp_enqueue_script() to add the css and js assets to the wordpress page render process. These filenames can not change. I then insert the svelte startup markup into the content. e.g. svelte:

 , or sveltekit: start({...})

Wondering if I should be looking at component packaging instead https://github.com/sveltejs/kit/pull/1499

Encountered same need, we are transitioning from a React SPA. Hopefully this will get some love

@gevera looks like you can use vite config to influence file names: https://github.com/sveltejs/vite-plugin-svelte/issues/375#issuecomment-1156609925

@cubic3d
I tried and doesn't work.
The following Vite config options will be overridden by SvelteKit:
  - build.rollupOptions.output.entryFileNames
  - build.rollupOptions.output.chunkFileNames
  - build.rollupOptions.output.assetFileNames

I have the same problem with the latest version of Svelte.

While there's no solution or adapter itself hasn't been improved, I've created the "hacky" way of re-wrapping the project files to the bundle.js: https://github.com/d-velopment/SvelteKit-One-Bundle
It's not solving the problem of thousand chunks but gives the bundle.js to be loaded from a custom index.html or another project to render the application.

My use case is for an enterprise platform. In truth I don't need all the JS to be in a single file. Rather I need all the JS to be built to the /dist folder, no JS or CSS in subfolders.
So the enterprise platform I use allows me to serve a single html page at an endpoint with all JS & CSS file requests coming from that endpoint e.g.
Index html: platform.com/webapp/my_app
All JS/CSS files: platform.com/webapp/my_app/{filename}
Although that forces me to use hashed routing as well which I guess I'll have to implement myself unless Sveltekit has one I can turn on.

@benmccann I'm making a Capacitor application for iOS/Android. Capacitor works by starting a local web server and then serving your application like a static host on your phone. This local server does not have SSL or HTTP/2, so while some requests load in parallel, it takes quite a while to load 50+ resources over HTTP/1. It's hard to measure raw numbers but in our project it takes around ~1 second for loading up the app until interactable and about half that on our PWA version. So it takes twice as long to load a local application on your phone than going to servers in a different country.

This is also a common problem highlighted by SEO tools. 'reduce number of css files'. Would be good to be able to combine them.

I have this need for importing components into other systems like wordpress or drupal.
In react, we've always handled this by reading the assets manifest.json file from webpack to figure out which file names we need to load, which vite DOES support under the options build.manifest, but when I try and enable that settings I get the error:
The following Vite config options will be overridden by SvelteKit:
  - build.manifest

Like @wozzashek mentioned, I also work with an enterprise system, Microsoft Dynamics/Power Platform.

In their case Microsoft prepends a cache busting version value (=hash/guid) in front of my web files in the url path. So a hash in de filename is unnecessary.

/%7B%7D/WebResources/index.html

Those web resources are part of a solution zip file which is used to deploy and redeploy updates. So I want to have the same file names, otherwise my solution grows and grows with each build being added.

I tried all suggestions to disable the [hash] in the file names, but nothing works. Having multiple chunks is not a problem in my use case, as long as they have the same file names.
Any suggestions on how to disable the hash in the file names?

My use case is for packaging up an admin front-end UI within a back-end library. The devs consuming the library will ultimately choose which paths the UI will be served under, and it needs to be dynamic at runtime.
eg. The Hangfire dashboard UI (not my project, but a close analogy to what I need to do):
https://docs.hangfire.io/en/latest/configuration/using-dashboard.html
Note the end of the article, I'd like to support things like this too:

Multiple Dashboards¶
You can also map multiple dashboards that show information about different storages.
var storage1 = new SqlServerStorage("Connection1");
var storage2 = new SqlServerStorage("Connection2");
app.UseHangfireDashboard("/hangfire1", new DashboardOptions(), storage1);
app.UseHangfireDashboard("/hangfire2", new DashboardOptions(), storage2);

My most obvious usecase is developing a CSS framework and using SvelteKit as a wrapper for documentations and also partially custom implementation of the CSS style for one off svelte components.
So, such a feature would be extremely, extremely appreciated;
PS. Stuff like these seemed to be the focus/concern of the dev team at some point in time? see: Svelte.Dev Blog CSS-in-JS

@benmccann Any updates on this topic?

We need this solution in sveltelkit as well, as we have a domain issue restriction with the amount of Page Resources loaded, and need to minimize the number of resources Goolge-Bot needs to load.
The current solution, that we have identified that works as intended for CSS, is to use the following setup:
📌 src/app.html

[...]

<link
  rel="preload"
  href="/all-css-chunk.css"
  as="style"
/>
<link
  rel="stylesheet"
  type="text/css"
  href="/all-css-chunk.css"
/>

[...]

📌  vite.config.ts

import { defineConfig } from 'vitest/config';
import { sveltekit } from '@sveltejs/kit/vite';
import cssInjectedByJsPlugin from "vite-plugin-css-injected-by-js";
import fs from 'fs';

[...]

plugins:
[
  sveltekit(),

  // ### WARNING:
  // ### 'this' plugin removes all 'CSS' from standard
  // ### importing by 'svelte/svelteki' and styles will be missing
  // ### if not imported as a '<link ... >' in the 'src/app.html'
  cssInjectedByJsPlugin
  (
    {
      // ### NOTE:
      // ### definitive 'hack' solution for 'single CSS file' output chunk.
      injectCode:
      (
        cssCode,
        options
      ) =>
      {

        // ### NOTE:
        // ### the 'cssCode' generated contains some 'formatting' issues.
        // ### remove 1st and last speech marks.
        // ### remove cases of `\n` chars.
        // ### correct custom case of 'ids'/'classes' using the 'forward-slash' in the declaration.
        let cssCodeMod: string = cssCode.slice(1, -1);
        cssCodeMod = cssCodeMod.replace(/\\n/g, "");
        cssCodeMod = cssCodeMod.replace(/\\\\/g,"\\")

        // ### WARNING:
        // ### 'all-css-chunk.css' must exist inside '/static'
        fs.writeFile
        (
          './static/all-css-chunk.css',
          cssCodeMod,
          err =>
          {
            if (err) console.error(err);
          }
        );

        return '';
      }

    }
  ),

[...]

Warning
The only issue with this that has been detected, is that the


Radiobutton not displaying

Radio button to save presets not displaying

Hi firstimpressionmusic,
The "Output Radiobuttons" and accompanying "Save", "Save As" was removed because now the wrapper can read from "Sophia.PS1" files now to populate the radiobuttons in each tab.
I mean you can press "Output PowerShell" and "Save As" your choice of name for the PS1 file and open it up in the "Options" via "Open PS1". It should fully work now. This feature was in development for a while. You no longer need TXT preset files to separately save your choices or open them,


Fix StepAction support in Cluster resolver

Changes

Fix StepAction support in Cluster resolver
Fixes https://github.com/tektoncd/pipeline/issues/8381
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[x] Has Tests included if any functionality added or changed
[x] pre-commit Passed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
Fix StepAction support in Cluster resolver

/kind bug

Oh waw, how did I miss that 😮💨 . @afrittoli I would consider this as a bug, as it is supposed to be implemented (it's just that this part of the validation was missing 😱 )

Well it matches the current docs https://github.com/tektoncd/pipeline/blob/main/docs/cluster-resolver.md... but I'm also ok to merge this and update the docs in a separate PR as long as they go out in the same release

Oh waw, how did I miss that 😮💨 . @afrittoli I would consider this as a bug, as it is supposed to be implemented (it's just that this part of the validation was missing 😱 )

Well it matches the current docs https://github.com/tektoncd/pipeline/blob/main/docs/cluster-resolver.md... but I'm also ok to merge this and update the docs in a separate PR as long as they go out in the same release

oh waw I missed a lot of things 🤦🏼 my PR got merged too quickly 🎃 😓

/retest

I can update the docs too, give me a moment. :)

/retest

@afrittoli I think we should backport this to 0.65. The reason is that it appears in the changelog of v0.63.0 as a new feature supported, which… doesn't work (hence the initial kind/bug). How does that sound ?

Sounds good to me, feel free to change the label back if you prefer. I thought the feature label would give it more prominence in the release notes, but we can highlight it as a bug fix too

/kind bug
/cherry-pick release-v0.65.x


delay_load: FreeLibrary possible called too eagerly

https://github.com/microsoft/windows-rs/blob/1f8e1dd64bb31c286c683506834811b281b6d396/crates/libs/windows/src/imp/delay_load.rs#L10-L25
The FreeLibrary call here is possibly too eagerly called. LoadLibrary increments a reference count, FreeLibrary decrements the reference count. When the reference count reaches zero, the module is unloaded. GetProcAddress does not interact with the reference count, therefore a procedure address to a potentially unloaded library would be acquired.
The delay_load code only works when the module has been previously loaded with a nonzero reference count. Ideally delay_load would be more sophisticated and return a RAII based object that calls FreeLibrary should the function pointer no longer be used.

Hm. surely this only calls FreeLibrary on failure (i.e. there is no function address)? Though I guess it could be written to make this more clear. I.e. this is roughly:
    let library = LoadLibraryA(library);         // +1 ref count
    if library == 0 { return None; }
    let address = GetProcAddress(library, function);
    if address.is_null() {
        FreeLibrary(library);                    // -1 ref count
        None                                     // no address is returned
    } else {
        Some(std::mem::transmute_copy(&address)) // leak library
    }

Ah, in my tunnelvision I failed I see that I'm sorry. Though I always wondered why it is commonpractice to leak the library like this, but I suppose if you use the function forever that is perfectly acceptable. Again sorry for my negligence, I'll re-read it more carefully next time!

Better safe than sorry! I think it's a good idea to ask even if you risk having missed something.
As for library leaking, this is usually best practice in a general purpose function such as this because library unloading can be incredibly unsafe whereas it's always safe to leak the DLL. Even with RAII it's very hard to know if some thread somewhere is still using a resource (even if indirectly) that the DLL unload will free. So unless you know about the specific DLL and how it's being used, it's better to leak. Well, even if you do know then it's still safer to leak unless you really need to reclaim the memory or something.


receivers: support for manual OAI sets

closes #46

Coverage increased (+0.4%) to 97.188% when pulling b4e70cc5e502a288de0486c512395432847354d4 on jirikuncar:46-manually-managed-sets into f352d48f98453b755cf047b5056bf12ebab4f7fc on inveniosoftware:master.

Coverage increased (+0.4%) to 97.188% when pulling b4e70cc5e502a288de0486c512395432847354d4 on jirikuncar:46-manually-managed-sets into f352d48f98453b755cf047b5056bf12ebab4f7fc on inveniosoftware:master.


tests: ztest: base: remove main_deprecated file

On intel_adsp_cavs25 platform, tests/ztest/base failed.
Failed reason: RunID mismatch
And the cause of the failure was found.
Because when move to new ztest API, the file was forgotten to delete.
So I delete it to solve this bug.
Signed-off-by: Zhao Shuai<EMAIL_ADDRESS>

Please get a +1 from someone more familiar with the legacy API than me before merging.

Please get a +1 from someone more familiar with the legacy API than me before merging.

Ok. I will.


Search upwards for a draggable element in touchstartDelay

#75 added a very useful ability to delay dragging, but it only works if the direct target of the first touch is itself draggable. This patch adds a search up the tree for a draggable element, just like how touchstart does. This makes dragging work on my project :-).

Thanks! 🎉 Wonder if it'd be more readable to find the target element first and then continue? Having the whole thing in the loop body doesn't make it very intention revealing: we only want to do this once.

That's up to you - if we want to do that, we should do it in both places.

@bhollis I had started a PR to fix this same issue, but then closed it when I saw you had a solution. I'm glad to see someone else had an eye on the same problem :)
Are you planning on making the adjustment that Tim referred to?  Maybe extract the logic for finding the draggable item into a function, then calling that function from both touchstart and touchstartDelay?
I can review and merge if you do.

Refactoring for better code is a noble goal. However given the fact that this is work on a soon-to-be-deprecated branch I don't think it's a reasonable blocker. If anyone wants to do refactoring, you're more than welcome to do so, but let's do it in a separate PR.
As it stands now, this PR matches the code style we have and fixes a bug. I'll merge it as is.

Thanks folks!


Support for junit5

It would be very nice to get support for generating junit5 tests, since junit5 will be the preferred version in our ICT education (https://fontys.edu/ict/) from February 2021.
many thanks in advance.

@Fontyschriek a pull request has been created to add support for Junit5. This issue will be closed when the new version (3.3) will be available on plugins marketplace.

@Fontyschriek a pull request has been created to add support for Junit5. This issue will be closed when the new version (3.3) will be available on plugins marketplace.

thanks for the swift response!

thanks for the swift response!


System tray icon is unresponsive in Linux

When I click on the system tray icon, nothing happens. It doesn't matter if I left-click, right-click, or double-click. If the desktop client window is closed and I want to open it, I have to restart the app.
I'm using Keybase 6.2.2 on Pop!_OS 22.04 LTS (a Linux distribution downstream from Ubuntu 22.04 LTS). My desktop environment is GNOME 42.9.
This issue is similar to issue #23150, but in that case users were reporting that double-clicking worked, which it does not in my case.

I have the exact same environment as @rhanneken and experiencing the same issue that the tray icon no longer responds.

I'm assuming it's a GNOME-specific thing and likely related to AppIndicator and KStatusNotifierItem tray icons being deprecated.
For an unrelated app (Jagex Launcher) if I enable the legacy AppIndicator and KStatusNotifierItem support via GNOME extensions on Fedora, I can get it's tray icon to show in the top-right area, but it doesn't interact at all with left/right click. If I disable the legacy tray support, the launcher ends up docking the icon to a separate floating Wine tray and works fine. Iirc Steam from RPM Fusion installs the legacy tray support as a dependency.
I'm not sure how Pop!_OS handles that. Could try toggling between X and Wayland if it offers that.

@Espionage724 The package gnome-shell-extension-appindicator is installed on my machine. The project page says:

This extension integrates Ubuntu AppIndicators and KStatusNotifierItems (KDE's blessed successor of the systray) into GNOME Shell. Including support for legacy tray icons.

So I think that's not the issue.
Are you running Keybase on Linux? Does the system tray icon respond to your clicks? What's your desktop environment?

Right-clicking Keybase's icon in the top-right bar doesn't do anything, but double-clicking with left shows a small Keybase window with chats and files.
I'm using Fedora 38 with GNOME 44.3 and gnome-shell-extension-appindicator enabled.

@Espionage724 What version of Keybase are you running?

keybase-<IP_ADDRESS>30726175256.4464bfb32d-1.x86_64

I have the same issue, and the tray icon is totally unresponsive (single click, left/right/middle, double-click, doesn't matter, nothing happens).
Running: standard Ubuntu 22.04.3
Keybase: 6.2.2-20230726175256+4464bfb32d
Are there any logs somewhere I can gather information from to help the developers here?

Updated to 6.2.3, same issue

The same issue

Same here.

Same issue on Keybase 6.2.4-20240101011938+ae7e4a1c15

Well this now became a problem since one cannot simply continue using 6.0.x (where this works and was my solution so far).
Reason is that old versions contain expired embedded certificate (https://github.com/keybase/keybase-issues/issues/4219) so now a fix or workaround is really needed to be able to continue using Keybase.

Looking at the date of this issue, I have a bad feeling about the future of keybase

Looking at the date of this issue, I have a bad feeling about the future of keybase

Tray icons were deprecated on GNOME years ago afaik and things still doing it today use a 3rd-party GNOME extension for the legacy tray support.
If Keybase's tray icon works fine on another DE like Xfce, then I would put the blame at GNOME for no official tray support, and then just let it go because Keybase works fine without a tray icon.


question about physics

I'm looking for a way to put the engine in such a way that the physics provides the same result under the same initial conditions. Is this possible with this engine?

It should so long as the initial conditions are exactly the same and the timestep used is fixed and constant (which isn't the default with the debug runner).


Depreciated treeForAddonTemplates as per issue #881

See https://github.com/kaliber5/ember-bootstrap/issues/881

This seems straight forward but doesn't work. :cry:

Error: Could not find module ember-bootstrap/templates/components/bs-navbar imported from ember-bootstrap/components/base/bs-navbar

@veebs Do you have time to investigate what's happening here?

I've updated my branch.  Not sure why GitHub not showing it.

Finally github updated the PR.
OK found that treeForAddonTemplates() is still called when building ember-bootstrap.  However when building your own app that uses ember-bootstrap, it does not call it.
Not sure why but the work around is to reinstate the treeForAddonTemplates() function.

OK found that treeForAddonTemplates() is still called when building ember-bootstrap.

By "building ember-bootstrap" you are referring to dummy app, isn't it?

With my PR, I've been able to ember test on my fork of ember-bootstrap.

I have also replaced C:\dev\my-ember-app\node_modules\ember-bootstrap in my ember project that uses ember-bootstrap and can confirm that ember-bootstrap components are registered with the right module paths within C:\dev\my-ember-app\dist\assets\vendor.js.
I'm cannot recreate the failure on the travis-ci build.
Is it because I'm using ember-cli 3.13.0-beta.1 ?

I'm cannot recreate the failure on the travis-ci build.

After your second commit tests were actually passing! Only the Browserstack scenario was failing, but that is flaky at times, and seems unrelated to your changes.

Is it because I'm using ember-cli 3.13.0-beta.1 for my app?

Yes, I think so. Travis runs with the Ember CLI version specified in the addon's package.json.
I would still like to confirm if we really have to do the template transformations twice as we do now, once in treeForAddon (new) and once in treeForAddonTemplates (as before)...

I just got back to having a quick look at this issue.
PS C:\Windows\system32> cd C:\dev\svu-ui-poc\ember-app
PS C:\dev\my-ember-app\ember-app> ember --version
ember-cli: 3.13.0-beta.1
node: 10.16.3
os: win32 x64

PS C:\dev\my-ember-app\ember-app> cd C:\dev\ember-bootstrap
PS C:\dev\ember-bootstrap> ember --version
ember-cli: 3.11.0
node: 10.16.3
os: win32 x64
PS C:\dev\ember-bootstrap>

Maybe the issue is that the ember-cli version for ember-bootstrap is version 3.11.0.
Should we change that to 3.13.0-beta.1?

Should we change that to 3.13.0-beta.1?

No! The addon should work with any Ember CLI version (starting at 2.18 for the 3.0.0(-rc.x) version). So we should keep testing with the existing version.

After your second commit tests were actually passing!

But as said before (👆) your changes do work now with that version. See the green PR. The only remaining "issue" from my PoV is this one:

I would still like to confirm if we really have to do the template transformations twice as we do now, once in treeForAddon (new) and once in treeForAddonTemplates (as before)...

I see here you tried that out already, so idk if there is anything left we could try out. If not, we should still be able to merge as is I guess, even with that bit of code duplication...
Just to make sure (as CI runs with the older Ember CLI version): the current state of this PR work with the latest Ember CLI beta locally, right?

If not, we should still be able to merge as is I guess, even with that bit of code duplication...

I'm not that sure that merging in this stage would be best option.

This is only a work-a-round for an upstream bug. We have a confirmation from Ember CLI team member (rwjblue) that it will be fixed upstream.
This is not affecting any stable releases yet.
There is the plan to deprecate treeForAddonTemplates but it's not yet deprecate. There isn't even a RFC for deprecation.
It's likely that there will be a better migration path when treeForAddonTemplates is actually deprecated.
We don't have any test coverage for any other Ember CLI version than 3.11 and the current implementation seems to rely highly on some internals of Ember CLI.

It's a different story in my opinion if a stable release of Ember CLI will include that bug. But that's not the case yet.
Ember Leaflet also hasn't implemented a work-a-round yet: https://github.com/miguelcobain/ember-leaflet/pull/342

Yes - the current PR works locally for me on 3.13.0-beta.1
Maybe it is best to wait for a full release of ember-cli (rather than the beta).  The issue and my work around is documented for other users.
I'm only using the latest cause I wanted to try out Ember Octane.
Let's review again once Ember 3.13 is out in about 3-4 weeks?

I've manually confirmed that this is working for

Ember CLI ~3.13.0
Ember CLI ~3.12.0
Ember CLI ~3.8.0
Ember CLI ~3.4.0
Ember CLI ~2.18.0

with using <BsButton> in application template of a new project.
I've also manually compared asset size for Ember CLI ~3.12.0. If I didn't made any mistake this is decreasing the asset size from 1.09 MB (233.41 KB gzipped) to 899.67 KB (215.41 KB gzipped). I'm very confused by that one. I would have expected that we may include code twice due to having duplicated logic but I don't have any idea why we might ship less code...

I've tested with a small real-world application. Working fine for that one also with Ember CLI ~3.12.0 and 3.13.0.
I'm seeing the same reduction of asset size for production builds (>10 KB after gzip). While I'm still confused about what is going on there, it's actually amazing. But we should dig deeper into that one after releasing a bug fix.

Thanks @jelhan for testing, and @veebs for your work. Will merge then and publish another RC!

I'm seeing the same reduction of asset size for production builds (>10 KB after gzip). While I'm still confused about what is going on there, it's actually amazing. But we should dig deeper into that one after releasing a bug fix.

Agree. https://github.com/kaliber5/ember-cli-bundle-analyzer could come to a rescue! :wink:


tests build failing when check.h is not available

The check testing library is not used anymore, but check.h is still included in v2.4.
The fix is 8f61796c9596b6db37ad9d1825574f23d167b68d

closing as this has been fixed in the master branch


health: Refactored health_checker tests.

Signed-off-by: Manish Kumar<EMAIL_ADDRESS>For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Added allocHealthChecker and addCompletionCallback method  in TestHttpHealthCheckerImpl, TestProdHttpHealthchecker, TcpHealthCheckerImpl and TestGrpcHealthCheckerImpl.
Risk Level:
Testing:
Docs Changes:
Release Notes:
includes partial fix to  #11109

/wait

@mk46 to make it easier for the reviewer, when we have a PR is already in review, please don't do a force push. Thanks!

Can you fill out all the fields in the PR description?

/wait

Please do not force-push. It makes it impossible to follow review threads.

I suspect that the reason you saw the failure was that there is a subclass and a parent-class that have member variables named the same thing, but with different types. That's pretty confusing especially when searching around a large file.
Can you either make the names be different or, if there is no benefit to having the subclass/parent-class relationship, consider breaking that. You could also break up the file in that case too, which might make it easier to work with.

Please do not force-push. It makes it impossible to follow review threads.

I will take care from next time. Thanks!

May I change addCompletionCallback(), allocHealthChecker()  to addCompletionCallbackHttp()  allocHealthCheckerHttp() respectively and same for others?

I think OO priniciples suggest not doing that, but instead breaking inappropriate inheritance chains.
If there some limited re-use across the classes maybe they could be factored into a protocol-neutral HeathCheckTestBase class.

/wait

Sorry -- looks like there's still a functional bug in 'release' builds with the refactored tests.
2020-05-22T18:35:58.9507484Z [----------] 59 tests from HttpHealthCheckerImplTest
2020-05-22T18:35:58.9515587Z [ RUN      ] HttpHealthCheckerImplTest.Success
2020-05-22T18:35:58.9523998Z [       OK ] HttpHealthCheckerImplTest.Success (14 ms)
2020-05-22T18:35:58.9532706Z [ RUN      ] HttpHealthCheckerImplTest.Degraded
2020-05-22T18:35:58.9549434Z [2020-05-22 18:35:53.838][15][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:104] Caught Segmentation fault, suspect faulting address 0xe8
2020-05-22T18:35:58.9575222Z [2020-05-22 18:35:53.838][15][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:91] Backtrace (use tools/stack_decode.py to get line numbers):
2020-05-22T18:35:58.9601137Z [2020-05-22 18:35:53.838][15][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:92] Envoy version: 0/1.15.0-dev/redacted/RELEASE/BoringSSL
2020-05-22T18:35:58.9622678Z [2020-05-22 18:35:53.839][15][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #0: __restore_rt [0x7f972a7e4890]
2020-05-22T18:35:58.9649433Z [2020-05-22 18:35:53.841][15][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #1: Envoy::Upstream::(anonymous namespace)::HttpHealthCheckerImplTest_Degraded_Test::TestBody() [0x6f1b70]

To reproduce locally you could try compiling with
  bazel test --compilation_mode=opt  --cxxopt=-g --cxxopt=-ggdb3 //test/common/upstream:health_checker_impl_test

which will give you an optimized build with debug symbols. Or you might just look more carefully at your DegradedTest implementation to see what might be wrong.

Please also merge master.
/wait

Using a raw pointer for event_logger_ will fix the above failure.

I see why.  The reason is that (due to my suggestion) you were allocating event_logger_ with a unique_ptr and then releasing it when passing it to the constructor for the health checker. So far so good, but after that event_logger_ is null, and it is used in some tests after that for checking with EXPECT macros.
TBH I don't know what the best pattern for this usage model is best in modern C++, but this is what I'd do:
class HealthCheckerTestBase {
public:
 ....
  std::unique_ptr<MockHealthCheckEventLogger> event_logger_storage_{
      std::make_unique<MockHealthCheckEventLogger>()};
  MockHealthCheckEventLogger& event_logger_{*event_logger_storage_};
  ...

Then in the places where *event_logger_ is used in the tests, just remove the * as now event_logger_ is a valid reference, and will remain that way even after the unique_ptr is released.


fix: install poetry with pipx when running in docker

Installs poetry into a venv with pipx for docker.
This means that our dependencies and poetry's dependencies will not conflict.

Could you also remove .gitattributes, we don't have that file anymore.

UPDATE: I never tested this before now, but poetry is not needed to install and use importlib.metadata
It is fully possible to use pip install . and importlib.metadata will still work.
I'll be redoing this pull request to best execute this.


Make scrollFire resettable (e.g useful for Meteor)

See #4202 to understand what this PR fixs.
How it works :
Delete scrollFireEventsHandled that was preventing, on purpose, scrollFire to be called more than one time.
I tested it and it solves the issue described in #4202 on Meteor.

@Dogfalo, @acburst what do you think about it ?

Hey there 👋
We are happy to see, that you have created a pull request to fix a problem or add a feature or did something else.
Unfortunately does your PR include compiled files. Please do not edit materialize.css, materialize.js or any .html file directly! Those files are automatically generated. You should edit the source files in the locations below instead. Also make sure to check out our CONTRIBUTING GUIDE!
/materialize/sass/
/materialize/js/
/materialize/jade/page-contents/

We won't look into this, unless you modify your PR, so that it matches with our CONTRIBUTING guidelines.

WIth v1, you can now destroy and reinit


Async issue

Hi,
If you :

log in
go to dashboard
refresh the page

then you will be redirect to login page.
Dont log in, just click to home, then click to dashboard and here.
Problem : when accessing directrly a secure page (http://<IP_ADDRESS>:8080/public/#/dashboard), firebase is reponding after the onEnter function, so you are marked as not logged. Must found a better solution so onEnter function wait for firebase response (success or not but waiting for a response) before return. I'm working on it.

👍🏻

First you need to set state.loggedIn to false if user is not authenticated, to true if authenticated and to null when authenticated state in unknown (before Firebase response). When firebase response come back, update state.loggedin to true or false, but not null.
firebase.auth().onAuthStateChanged(firebaseUser => {
    this.setState({
        loggedIn: (null !== firebaseUser ? true:false)
    })
    ...
});

You need to move this part of code to your main js file to load early in the app, before the router. I use Redux so you probably need to change my code so the global state could be available from the main js file.
then update the requireAuth()
function requireAuth(nextState, replace) {

  // wait Firebase auth response
  (function waitAuthResponse() {
    if (null === state.loggedIn) {
      setTimeout(waitAuthResponse, 100);
    } else {
      if(null === firebase.auth().currentUser) {
        replace({
          pathname: '/login',
          state: { nextPathname: nextState.location.pathname }
        })
      }
    }
  })();

}

last change, update the root Route
 {this.state.loggedIn !== null ? this.props.children:'Auth in progress...'}

Hey I'm running into something similar. I am initializing firebase in a separate config file and importing firebase.auth() as auth into my routes file. Originally, I had something like this:
<Route
      path="/profile"
      getComponent={(nextState, cb) => {
        auth.onAuthStateChanged((user) => {
          if (user) {
            return require.ensure([], require => {
              cb(null, require('./modules/Profile/Profile').default);
            });
          } else {
            return require.ensure([], require => {
              cb(null, require('./modules/Login/Login').default);
            });
          }
        });
      }}
    />

Unfortunately in the short amount of time it takes to load the user, the alternate component renders, which isn't a very good experience. I've tried using onEnter and it never seems to work right when using firebase auth. Any luck or progress working on this?

So this seems to be working for me. Just adding callback() inside my onAuthStateChanged call does the trick.
function requireAuth(nextState, replace, callback) {
  auth.onAuthStateChanged((user) => {
    if (!user) {
      replace({
        pathname: '/login',
        state: { nextPathname: nextState.location.pathname },
      });
    }
    callback();
  });
}

I'm guessing because the transition is blocked until callback() is called. Let me know what you guys think of this and if there is a better solution.

A different solution is to use localStorage.
from http://stackoverflow.com/questions/37370599/firebase-auth-delayed-on-refresh
function (nextState, replace) {
    if (!firebase.auth().currentUser) {
        let hasLocalStorageUser = false;
        for (let key in localStorage) {
            if (key.startsWith("firebase:authUser:")) {
                hasLocalStorageUser = true;
            }
        }
        if (!hasLocalStorageUser) {
            console.log('Attempting to access a secure route. Please authenticate first.');
            replace({
                pathname: '/login',
                state: { nextPathname: nextState.location.pathname }
            });
        }
    }
};

@sebnun this seems to be working for me. I reworked it a bit with some lodashery. My second function here will kick the user back to their previous page if they tried to navigate to /login for some reason while they were logged in. Keep in mind that in my case auth = firebase.auth().
function requireAuth(nextState, replace) {
  if (!auth.currentUser) {
    let hasLocalStorageUser = false;
    _.forEach(_.keys(localStorage), (d) => {
      if (d.startsWith('firebase:authUser')) {
        hasLocalStorageUser = true;
      }
    });
    if (!hasLocalStorageUser) {
      replace({
        pathname: '/login',
        state: { nextPathname: nextState.location.pathname },
      });
    }
  }
}

function redirectBack() {
  let hasLocalStorageUser = false;
  _.forEach(_.keys(localStorage), (d) => {
    if (d.startsWith('firebase:authUser')) {
      hasLocalStorageUser = true;
    }
  });
  if (auth.currentUser || hasLocalStorageUser) {
    history.back();
  }
}

Do you think it makes any sense to keep an onAuthStateChanged() in there somewhere? Such as taking this onto the end of the requireAuth() function?
auth.onAuthStateChanged((user) => {
    if (!user) {
      replace({
        pathname: '/login',
        state: { nextPathname: nextState.location.pathname },
      });
    }
  });

I am using Facebook login, so that would allow me to send them to login if their Facebook creds expire (I think!). Would that work or is it unnecessary?

Update: I am having trouble with my code above when navigating to some routes. localStorage is not yet available and the page crashes. So here is my fix at the moment. This is slower and not as good, but doesn't crash:
function requireAuth(nextState, replace) {
  const browserStorage = (typeof localStorage === 'undefined') ?
    null : localStorage;
  if (browserStorage) {
    if (!auth.currentUser) {
      let hasBrowserStorageUser = false;
      _.forEach(_.keys(browserStorage), (d) => {
        if (d.startsWith('firebase:authUser')) {
          hasBrowserStorageUser = true;
        }
      });
      if (!hasBrowserStorageUser) {
        replace({
          pathname: '/login',
          state: { nextPathname: nextState.location.pathname },
        });
      }
    }
  } else {
    auth.onAuthStateChanged((user) => {
      if (!user) {
        replace({
          pathname: '/login',
          state: { nextPathname: nextState.location.pathname },
        });
      }
    });
  }
}

I just redid everything. Should be fixed.

@Bonitis Your solution works well for me! Thanks!


syntax highlighter for Lite XL

Lite XL is a text editor written mainly in Lua that I like to use because it's so small (around 4mb when extracted, barebones version) and it's easy to make extensions for it, also called "plugins"
in this case I made an Uxntal syntax highlighter for it :)
I didn't do it now, I have been "working on it" on and off for almost half a month, but I uploaded it to the Lite XL plugin repository and put it here just now lol

Very nice, first time hearing about Lite XL, can I see what it looks like with the uxntal syntax?

sure, here you go

I mainly made the syntax highlighter to be used with the Gruvbox Dark color theme but you can use it with any other else and it will look good :)

Looks nice :) Thanks for the picture


Example PS to check current app and owner

Here a quick hack PS to check apps and owner
Get-AzureADApplication | Foreach-Object{

    $AppObjectId = $_
    $AppOwner = Get-AzureADApplicationOwner -ObjectId $AppObjectId.ObjectId

    New-Object -TypeName PSObject -Property @{
        AppDisplayName = $AppObjectId.DisplayName
        AppObjectId = $AppObjectId.ObjectId
		AppAppId = $AppObjectId.AppId
		AppReplyUrls = $AppObjectId.ReplyUrls
        OwUPN = $AppOwner.UserPrincipalName
        OwType = $AppOwner.UserType
    }
} | select AppDisplayName,AppObjectId,AppAppId,@{ n='AppReplyUrls'; e={ $_.AppReplyUrls -join ' ' } },@{ n='OwUPN'; e={ $_.OwUPN -join ' ' } } | Export-Csv -Path .\AppsO365.csv -NoTypeInformation

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 279bb5c8-222e-5ee9-dcd7-8c06bd4d3a3e
Version Independent ID: 4b1d6664-91b3-8bd6-f26e-d46005891294
Content: Turning Integrated Apps on or off
Content Source: Office365-Admin/misc/integrated-apps.md
Service: o365-administration
GitHub Login: @KwekuA
Microsoft Alias: kwekua

@TiloGit - Thank you for submitting feedback.
Can you please share what specific issue you have with this doc?
We would really appreciate if you are able to help by providing more details as to what should be edited and/or included.

suggest to add this script to check before use the toggle.
Should give you current app and the current app owner.

@TiloGit - Thank you for your suggestion.
I will get this issue over to the O365ITPro writing team for their consideration.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@kwekuako - FYI. Please share your insights on this.
Thank you.

@TiloGit - We have forwarded this request to the product team who manages this topic for their consideration.
Thank you for engaging with the community here and for your contribution to help improve the docs.


[C++] Build error: arrow/dataset/test_util.h: No such file or directory

Describe the bug, including details regarding any error messages, version, and platform.
An error was displayed when the following command was executed.
$ cmake .. --preset ninja-debug-maximal -DARROW_BUILD_SHARED=OFF -DARROW_BUILD_STATIC=ON
$ cmake --build .

Errors:
/home/xxx/arrow/cpp/src/skyhook/protocol/skyhook_protocol_test.cc:20:10: fatal error: arrow/dataset/test_util.h: No such file or directory
   20 | #include "arrow/dataset/test_util.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

#include "arrow/dataset/test_util_internal.h" seems to be correct.
Component(s)
C++

It seems that #34036 broke this.


Add a metrics for cdc to observe the region count that use too long to do incremental scan

What is changed and how it works?

Issue Number: ref https://github.com/tikv/tikv/issues/12592

What's Changed:
Add a new metrics called tikv_cdc_scan_long_duration_region to observe the region count that use too long to do incremental scan.

Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[ ] Need to cherry-pick to the release branch

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

None

/merge


Mandatory update needed for availableReplicas

(Thanks for reporting an issue! Please make sure you click the link above to view the issue guidelines, then fill out the blanks below.)
Hi Nic,
A mandatory update is needed for OpenFaaS providers to work with the newest changes proposed in the OpenFaaS UI.
A new field: availableReplicas will need to be populated in the endpoint /system/function/<name>
I found the code here:
https://github.com/hashicorp/faas-nomad/blob/914044bbf61ddebbc35d8b07a41d8cba2c5c7a95/handlers/replication.go#L44
Now the purpose of this field is to indicate which functions (containers) have a replica ready for a HTTP request - often when pulling a large image the function is not ready until several minutes in. That's the purpose of this change - to provide that information to the UI or new endpoint.
You may need to vendor the latest release of faas-provider, which adds a healthcheck endpoint also.
https://github.com/openfaas/faas-provider/releases
The easiest way to maintain compatibility will be to set the availableReplicas count to be the same as replicas - this will mean the UI continues to work as planned. Down the road updating availableReplicas to its true meaning would be best.
Let me know if you have questions or if I can help.
Alex
What are the steps to reproduce this issue?
n/a
What happens?
Invoke button will be permanently disabled
What were you expecting to happen?
Button to be enabled.
Any logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
N/a
Any other comments?
As above
What versions of software are you using?
Operating System: …
OpenFaaS Version: …
0.7.5 and higher.
Nomad Version: …
n/a

Just need to finish debugging the failing tests but this is pretty much good to go

Thanks, I know you don't actively maintain this project so if you can get to it when you can that would help other potential nomad users.

Bump

This has been all merged with pull request https://github.com/hashicorp/faas-nomad/pull/34
Cheers,
Nic


Kingdom Come: Garbled Graphics

I am using Wine Staging 3.6.1 on Fedora 28 to try and play Kingdom Come: Deliverance. However, the graphics are extremely garbled and colorful. I am using DXVK version 0.42. I have tried compiling from master, but I am unable to compile the dll, because I am not sure which wingw64 package I need. The 3 biggest issues that stand out from the logs are the following 3 errors:
err:   D3D11: Cannot map a device-local image
warn:  D3D11RasterizerState: Depth clamp not properly supported
warn:  Vulkan extension VK_KHR_maintenance2 not supported
Software information
Kingdom Come: Deliverance.
Medium settings preset
System information

GPU: Vega 64
Driver: 18.0.1
Wine version: 3.6.1 staging
DXVK version: 0.42

Log files
d3d11.log:
info:  D3D11CreateDevice: Probing D3D_FEATURE_LEVEL_11_0
info:  D3D11CreateDevice: Using feature level D3D_FEATURE_LEVEL_11_0
info:  D3D11CreateDevice: Probing D3D_FEATURE_LEVEL_11_0
info:  D3D11CreateDevice: Using feature level D3D_FEATURE_LEVEL_11_0
info:  D3D11CreateDevice: Probing D3D_FEATURE_LEVEL_11_0
info:  D3D11CreateDevice: Using feature level D3D_FEATURE_LEVEL_11_0
info:  D3D11CreateDevice: Probing D3D_FEATURE_LEVEL_11_0
info:  D3D11CreateDevice: Using feature level D3D_FEATURE_LEVEL_11_0
info:  D3D11CreateDevice: Probing D3D_FEATURE_LEVEL_11_0
info:  D3D11CreateDevice: Using feature level D3D_FEATURE_LEVEL_11_0
err:   D3D11: Cannot map a device-local image
warn:  D3D11RasterizerState: Depth clamp not properly supported
err:   D3D11: Cannot map a device-local image
err:   D3D11: Cannot map a device-local image
err:   D3D11: Cannot map a device-local image
err:   D3D11: Cannot map a device-local image
err:   D3D11: Cannot map a device-local image
err:   D3D11: Cannot map a device-local image
dxgi.log:
info:  Enabled instance layers:
info:  Enabled instance extensions:
info:    VK_KHR_surface
info:    VK_KHR_win32_surface
info:  AMD RADV VEGA (LLVM 6.0.0):
info:    Driver: 18.0.1
info:    Vulkan: 1.0.57
info:  AMD RADV VEGA (LLVM 6.0.0):
info:    Driver: 18.0.1
info:    Vulkan: 1.0.57
warn:  Vulkan extension VK_KHR_maintenance2 not supported
info:  Enabled device extensions:
info:    VK_KHR_descriptor_update_template
info:    VK_KHR_sampler_mirror_clamp_to_edge
info:    VK_KHR_maintenance1
info:    VK_KHR_shader_draw_parameters
info:    VK_KHR_swapchain
warn:  Vulkan extension VK_KHR_maintenance2 not supported
info:  Enabled device extensions:
info:    VK_KHR_descriptor_update_template
info:    VK_KHR_sampler_mirror_clamp_to_edge
info:    VK_KHR_maintenance1
info:    VK_KHR_shader_draw_parameters
info:    VK_KHR_swapchain
info:  Enabled instance layers:
info:  Enabled instance extensions:
info:    VK_KHR_surface
info:    VK_KHR_win32_surface
info:  AMD RADV VEGA (LLVM 6.0.0):
info:    Driver: 18.0.1
info:    Vulkan: 1.0.57
info:  AMD RADV VEGA (LLVM 6.0.0):
info:    Driver: 18.0.1
info:    Vulkan: 1.0.57
warn:  Vulkan extension VK_KHR_maintenance2 not supported
info:  Enabled device extensions:
info:    VK_KHR_descriptor_update_template
info:    VK_KHR_sampler_mirror_clamp_to_edge
info:    VK_KHR_maintenance1
info:    VK_KHR_shader_draw_parameters
info:    VK_KHR_swapchain
warn:  DxgiDevice::SetMaximumFrameLatency: Stub
warn:  DXGI: MakeWindowAssociation: Ignoring flags
err:   DXGI: CheckInterfaceSupport: No D3D10 support
info:  Enabled instance layers:
info:  Enabled instance extensions:
info:    VK_KHR_surface
info:    VK_KHR_win32_surface
info:  AMD RADV VEGA (LLVM 6.0.0):
info:    Driver: 18.0.1
info:    Vulkan: 1.0.57
info:  AMD RADV VEGA (LLVM 6.0.0):
info:    Driver: 18.0.1
info:    Vulkan: 1.0.57
warn:  Vulkan extension VK_KHR_maintenance2 not supported
info:  Enabled device extensions:
info:    VK_KHR_descriptor_update_template
info:    VK_KHR_sampler_mirror_clamp_to_edge
info:    VK_KHR_maintenance1
info:    VK_KHR_shader_draw_parameters
info:    VK_KHR_swapchain
warn:  Vulkan extension VK_KHR_maintenance2 not supported
info:  Enabled device extensions:
info:    VK_KHR_descriptor_update_template
info:    VK_KHR_sampler_mirror_clamp_to_edge
info:    VK_KHR_maintenance1
info:    VK_KHR_shader_draw_parameters
info:    VK_KHR_swapchain
info:  DxgiVkPresenter: Recreating swap chain:
Format:       VK_FORMAT_B8G8R8A8_UNORM
Present mode: VK_PRESENT_MODE_IMMEDIATE_KHR
Buffer size:  2048x1152

Use mesa-git and latest llvm-svn.


Update suite.yml for v1.14.2+suite.1 release

Release Notes
All notable changes to this project will be documented in this file.
[v1.14.2+suite.1] - 2021-12-14
Table of Contents

Components
Installation Instructions for the Suite Release Version of Conjur
Upgrade Instructions
Changes

Components
These are the components that combine to create this Conjur OSS Suite release and links
to their releases:
Conjur Server

cyberark/conjur v1.14.2 (2021-12-13)
cyberark/conjur-openapi-spec v5.2.0 (2021-09-08)
cyberark/conjur-oss-helm-chart v2.0.4 (2021-04-12)

Conjur SDK

cyberark/conjur-cli v6.2.5 (2021-09-29)
cyberark/conjur-api-dotnet v2.1.0 (2021-09-08)
cyberark/conjur-api-go v0.8.0 (2021-09-10)
cyberark/conjur-api-java v3.0.2 (2020-10-28)
cyberark/conjur-api-python3 v7.0.1 (2020-04-12)
cyberark/conjur-api-ruby v5.3.5 (2021-05-04)

Platform Integrations

cyberark/cloudfoundry-conjur-buildpack v2.2.1 (2020-06-24)
cyberark/conjur-service-broker v1.2.2 (2021-11-03)
cyberark/conjur-authn-k8s-client v0.22.0 (2021-09-17)
cyberark/secrets-provider-for-k8s v1.2.0 (2021-11-30)

DevOps Tools

cyberark/ansible-conjur-collection v1.1.0 (2020-12-29)
cyberark/ansible-conjur-host-identity v0.3.2 (2020-12-29)
cyberark/conjur-puppet v3.1.0 (2020-10-08)
cyberark/terraform-provider-conjur v0.6.2 (2021-09-02)

Secretless Broker

cyberark/secretless-broker v1.7.8 (2021-11-09)

Summon

cyberark/summon v0.9.0 (2021-07-19)
cyberark/summon-conjur v0.6.0 (2021-08-11)

Installation Instructions for the Suite Release Version of Conjur
Installing the Suite Release Version of Conjur requires setting the container image tag. Below are more specific instructions depending on environment.

Docker or docker-compose
Set the container image tag to cyberark/conjur:1.14.2.
For example, make the following update to the conjur service in the quickstart docker-compose.yml
image: cyberark/conjur:1.14.2

Conjur Open Source Helm chart
Update the image.tag value and use the appropriate release of the helm chart:
helm install ... \
  --set image.tag="1.14.2" \
  ...
  https://github.com/cyberark/conjur-oss-helm-chart/releases/download/v2.0.4/conjur-oss-2.0.4.tgz

Upgrade Instructions
Upgrade instructions are available for the following components:

cyberark/conjur
cyberark/conjur-oss-helm-chart

Changes
The following are changes to the constituent components since the last Conjur
OSS Suite release:

cyberark/conjur
cyberark/conjur-service-broker
cyberark/secrets-provider-for-k8s

cyberark/conjur
v1.14.2 (2021-12-13)

Changed

Failed Login now writes the error code in the log
#2424
Bump cyberark base images from 1.0.5 to 1.0.6
#2420
Bump cyberark base images from 1.0.4 to 1.0.5
#2418

Fixed

Return 401 instead of 500 for invalid basic auth header.
#1990
Added check to stop hosts from setting passwords
#1920

Security

Bump gems related to openid_connect stack for improving the certificate
validation procedure during the OIDC keys discovery process
cyberark/ONYX-13304

cyberark/conjur-service-broker
v1.2.2 (2021-11-03)

Security

Updated Nokogiri to 1.12.5-x86_64-darwin to resolve
CVE-2021-41098
cyberark/conjur-service-broker#257

cyberark/secrets-provider-for-k8s
v1.2.0 (2021-11-30)

Added

Adds validation for output filepaths and names in Push-to-File, requiring
valid Linux filenames that are unique across all secret groups.
cyberark/secrets-provider-for-k8s#386
Adds support for Push-to-File annotation conjur.org/conjur-secrets-policy-path.{secret-group}.
cyberark/secrets-provider-for-k8s#392

Changed

Push-to-File supports more intuitive output filepaths. Filepaths are
no longer required to contain the hard-coded mount path /conjur/secrets, and
can specify intermediate directories.
cyberark/secrets-provider-for-k8s#381

@alexkalish
What's New
This suite release aligned with Conjur Server version 1.14.2. It includes a collection of minor fixes to Conjur itself, as well as the GA release of Push-to-File Mode in the Secrets Provider for Kubernetes.
Push-to-File Mode (GA release)
The Secrets Provider for Kubernetes can now be configured to output secret values to a file that can be accessed through a shared mounted volume. Providing secrets in this manner should require zero application changes, as reading local files is a common, platform agnostic delivery method. See PUSH_TO_FILE.md for more details. This is a community level release.
With the GA release, we have made minor improvements to stability and user experience, as well as improved documentation.

Skipping to v1.15.0


Hooking into the Command Line Compiler  broken

When trying to use require to hookup plugins (as mentioned on the this project's wiki), I get ReferenceError: CoffeeScript is not defined
It used to work fine on 0.9.4, which prevents me from upgrading coffeescript (lots of code depend on this feature). Has it changed, or was it removed? The changelog doesn't really help.

I don't think there's enough demand/reason for this to sweat it. The events work fine if you're building something large with node...


Halcyon.Sample.Ini Economy Section is Missing

The released sample Halcyon.ini files does not have the Economy section in it. This is the only place where the price values can be set for controlling all uploads, group creation and other settings related to fees and economy controls. While most grids wont need or use money operations this is still the only option open to control access to upload and group creation in a grid if those features are to be restricted to only approved persons.
It looks like this was the only place to set the default prim limit for any region, though this might only be a redundant entry since the value is set in each region.
[Economy]
; 45000 is the highest value that the sim could possibly report because of protocol constraints
ObjectCapacity = 30000
; Money Unit fee to upload textures, animations etc
PriceUpload = 0
; Money Unit fee to create groups
PriceGroupCreate = 0
; This is the account Money goes to for fees.  Remember, economy requires that money circulates somewhere... even if it's an upload fee
;EconomyBaseAccount = <UUID of Account that holds the starting cash>

Any comment improvements you can suggest? Jims got a PR is for this now: #444

As I mentioned in #444, I think many of the entries above (like the UserLevel, Stipend-related, etc) are old options copied from OpenSim but not used in Halcyon. I think some of the comments are very specific to OpenSim concepts that don't apply here, and I don't think we should be attempting to document any other options in the sample INI file unless they are confirmed to still apply and work correctly in Halcyon. I think the ObjectCapacity option should not be used from INI file, and may be ignored in some parts of the code in favor of the expected region.xml file option.
I have added an [Economy] section in PR #444, and with the key entries including an unused EconomyBaseAccount and comment, along with PriceUpload and PriceGroupCreate.  That's a good start.
I think additional entries will require specific source-level investigation to see if they are still appropriate and/or even supported at all.  Given the many higher priorities, I don't think this will happen any time soon, but we could leave this open on the backlog since we really should identify the options supported and document those.

My point was to have the [Economy] section restored and what items in it that are being used. Anything else is nice if it is known what it does and be better documented if it is supported.

Okay that's great, and should be resolved by #444.  And as we discover or make use of any other options that have code behind them, we can add those to the Halcyon.sample.ini as well.

#444 has been merged for some time. Closing.


test: refactor header inclusion to speed up building

Signed-off-by: Muge Chen<EMAIL_ADDRESS>Refactor mock class include directive after dividing test/server/mocks.h (#11649)
Building time comparison for affected tests:

test_name
before
after

//test/common/upstream:cluster_factory_impl_test
97.051s
80.938s

//test/common/upstream:eds_speed_test
102.03s
75.825s

//test/common/upstream:eds_test
101.319s
77.988s

//test/common/upstream:hds_test
105.666s
74.24s

//test/common/upstream:logical_dns_cluster_test
97.184s
78.586s

//test/common/upstream:original_dst_cluster_test
116.306s
74.845s

//test/common/upstream:transport_socket_matcher_test
99.237s
67.548s

//test/common/upstream:upstream_impl_test
101.438s
82.394s

Commit Message: refactor header inclusion to speed up building
Additional Description:
Risk Level: low
Testing: exsiting tests
Docs Changes: N/A
Release Notes: no
Related Issues: #10917
\cc @ahedberg

/azp run


dflowsvc: detect double-put

make sure consistency is upheld in face of double-put:
store := ctx.Store()
data := 42
// store data
err := store.Put("my-data", &data)

// oops, another time, under the same key
err = store.Put("my-data", &data)

otherwise, this could wreak havoc in the sync'ing of achan-s.

This issue was moved to go-hep/sw#39

This issue was moved to go-hep/hep#33


Windows terminal support

The test suite currently passes on Windows (thanks to https://github.com/CraigFe/progress/pull/15), but the terminal handling doesn't behave correctly on Windows terminal & Cygwin terminal:
https://user-images.githubusercontent.com/496345/123761425-1b683000-d8c2-11eb-8537-35d63c074f1e.mp4
Originally posted by @emillon in https://github.com/CraigFe/progress/issues/15#issuecomment-870377928
Details about terminal control sequences on Windows can be found here. The fix will probably involve touching Terminal.Ansi, and perhaps also renderer.ml in the Progress library.

to be honest, even opam is a bit broken in windows terminal:


feat: support cluster resource quota

What type of PR is this?

Feature: support tenant scope quota limit
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:

can tanant access the API clusterresourcesquota？
I think tanant can access the API clusterresourcesquota to know  how much clusterresouces are used.

can tanant access the API clusterresourcesquota？ I think tanant can access the API clusterresourcesquota to know how much clusterresouces are used.

@lcw2 I think no, clusterresourcesquota is a system resource, should not be accessed by tenant by default, maybe we can expose it when system crd feature is ready @Silverglass

ok,  when will this  system crd  feature  be release?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update bottlerocket to v1.9.2

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherrypick release-0.11


[GLBC] Fix backend status out of bounds error

This change is

Should investigate why the backend has zero backends.

Coverage increased (+0.03%) to 46.507% when pulling 851c9d0d41d7591b1b1f382c5479a706d59b0304 on nicksardo:gce-fix-backendStatus into 8ce0ea914c29e57fce46db18350957e40c1ebdf9 on kubernetes:master.


fix offline storage test

The delete was not deleting the blobs from the list. TransmitFromStorage test was passing as it was checking two different instances of FileBlobProvider. The fix updates MockFileBlob by passing in the List in to the constructor from MockFileProvider so that it can be used during delete operations.

API change check
API changes are not detected in this pull request.


chore(releases): Updadted the script to do releases to avoid generating a tag that links nowhere in main

Now it pushes to your fork (if you provide it) and gives you the links to create the pull requests (if you provide the url of your fork).
But it won't generate the tag. That's for when the PRs are merged.

Fixes #360


Cannot add Salt for the deployment - Not using defender

Hi,
I am trying to deploy a UUPS contract and wanted to add salt to my deployment contract to ensure, the same address on different chains.
Here is my code:
    address defaultAdmin = vm.envAddress("DEFAULT_ADMIN");

    bytes32 Salt = vm.envBytes32("SALT_DATA");

    function run() external {
        console.log("******** Deploying *********");

        vm.startBroadcast(deployer);

        address proxy = Upgrades.deployUUPSProxy(
            "<CONTRACT_NAME>.sol", abi.encodeCall(<CONTRACT_NAME>.initialize, (defaultAdmin, defaultAdmin, defaultAdmin))
        );

        console.log("<CONTRACT_NAME>proxy deployed at: ", proxy);

        <CONTRACT_NAME> inst = <CONTRACT_NAME>(proxy);
        string memory name = inst.name();

        console.log("<CONTRACT_NAME> name: ", name);

        console.log("******** Deployed *********");
    }

I tried sending salt through Options as well but no luck.

Hi, the salt option requires using Defender, because it uses a factory contract to perform the CREATE2 deployments.

Can I get any doc regarding deploying using Defender?

Thank you


requirePaddingNewlinesAfterUseStrict: Fix syntax error

See https://travis-ci.org/jscs-dev/node-jscs/builds/75073913.

Fast eye! Although it was already fixed - https://github.com/jscs-dev/node-jscs/commit/de1b932f2342fe4e90c1dcab5f7a674d069d8c35

:+1:


Add test plans support

Resolves https://github.com/tuist/xcodeproj/issues/442
Short description 📝

This PR is for adding support for parsing and generating test plans feature added in Xcode 11.

Solution 📦

Since it's very similar to existing Testables structure, but much simpler, I followed the same pattern that already existed for Testables. Test plans structure in scheme file is as follow:

...
<TestAction
    ...>
    <TestPlans>
        <TestPlanReference
            reference = "container:uitests.xctestplan"
            default = "YES">
        </TestPlanReference>
        <TestPlanReference
            reference = "container:unittests.xctestplan">
        </TestPlanReference>
    </TestPlans>
    ...
  </TestAction>
  ...

Implementation 👩💻👨💻

It was pretty straightforward with following the steps for Testables and the adding tests for XML parser. Then added the test plan support to iOS scheme that's used for scheme testing and fixed failing tests.

Awesome : ) Added the changes to CHANGELOG file. Let me know if it needed more explanation or links to what test plans.