docker-machine env fails to check certs, fails to generate certs

On OSX 10.9.5, docker-machine 0.5.3 and 0.5.6.
./docker-machine env dev gives the following error:
Error checking TLS connection: Error checking and/or regenerating the certs: There was an error validating certificates for host "<IP_ADDRESS>:2376": open : no such file or directory
You can attempt to regenerate them using 'docker-machine regenerate-certs [name]'.
Be advised that this will trigger a Docker daemon restart which will stop running containers.

Running docker-machine regenerate-certs dev results in:
Regenerate TLS machine certs?  Warning: this is irreversible. (y/n): y
Regenerating TLS certificates
Detecting the provisioner...
Copying certs to the local machine directory...
Copying ca.pem to machine dir failed: open : no such file or directory

I tried copying the new certs over manually from ~/.docker/machine/certs, but it didn't fix the initial problem. My guess is that it has nothing to do with the certs being missing on the remote machine, but I don't know how to troubleshoot past this point.

Did the create fail in the first place?  env and regenerate-certs won't be much help if create did not return successfully.

@nathanleclaire this is a machine that was created successfully and has been working without any problems for a month or more. I updated docker-machine and ran into this issue.

I'm also having the same issue.
OS X 10.11.2
VirtualBox 5.0.10 r104061
$ docker-machine version
docker-machine version 0.5.6, build

$ docker version
Client:
 Version:      1.9.1
 API version:  1.21
 Go version:   go1.5.1
 Git commit:   a34a1d5
 Built:        Sat Nov 21 00:48:57 UTC 2015
 OS/Arch:      darwin/amd64

The machine was created a while ago, but I haven't used it in months. It starts just fine. I can ssh into it (docker-machine ssh [name]). Most commands seem to work.
docker-machine config and docker-machine env fail checking the certs. docker-machine regenerate-certs fails with no such file or directory.

I'm also having this issue after upgrading docker toolbox to 1.10.2.
OSX: 10.11.1
docker-machine: 0.6.0
virtualbox: 5.0.14
Have any of you that have had this issue found a way around it?

I have the same issue and also notice that the issue is similar with https://github.com/docker/machine/issues/1159
But it still there.
##Environment
Mac OS 10.11.3
Docker version 1.10.3, build 20f81dd
docker-machine version 0.6.0, build e27fb87
##How my issue arose
Docker worked fine before I upgrade homebrew. Homebrew reminds me to link docker
brew link docker

After running the command upon, I got this message:
brew link docker
Linking /usr/local/Cellar/docker/1.7.1...
Error: Could not symlink bin/docker
Target /usr/local/bin/docker
already exists. You may want to remove it:
   rm '/usr/local/bin/docker'

then, I ran this commend:
rm '/usr/local/bin/docker'

##What's my issue
docker-machine env default

Error checking TLS connection: Error checking and/or regenerating the certs: There was an error validating certificates for host "<IP_ADDRESS>:2376": open : no such file or directory
You can attempt to regenerate them using 'docker-machine regenerate-certs [name]'.
Be advised that this will trigger a Docker daemon restart which will stop running containers.

When I wanna regenerate-certs, got this error message:
docker-machine regenerate-certs default

Regenerating TLS certificates
Waiting for SSH to be available...
Detecting the provisioner...
Copying certs to the local machine directory...
Copying ca.pem to machine dir failed: open : no such file or directory

##What I think about this issue:
Since certs can't be copied to the local machine directory, I think that specifying the machine dir would fix the issue or copy the certs manually.
Unfortunately, I don't know how to fix exactly. 😢
If anyone knows how to fix, please pin here, thanks.

I'm having exactly the same issue as @robbles
A machine that has been running for months. I can still ssh on it, but can't rebuild the docker-compose conf now that I have changes to apply, because of the failing certs.
I upgraded the docker daemon on the server but with no impact on this issue.
Docker version 1.11.2, build b9f10c9
docker-machine version 0.7.0, build a650a40
docker-compose version 1.7.1, build unknown

$ docker-machine ls
NAME       ACTIVE   DRIVER         STATE     URL                          SWARM   DOCKER    ERRORS
mymachine  -        digitalocean   Running   tcp://xxx.xxx.xxx.xxx:2376           Unknown   Unable to query docker version: Unable to read TLS config: open : no such file or directory

Same failing regenerate-certs.

Try this way:
1.firstly make sure there are ca.pem, cert.pem, key.pem, ca-key.pem  under $yourhome/.docker/machine/certs/ folder , for these lost four *.pem files,  you can copy them from other places or maybe create them yourselves ( these four pem files are surely not correct at the beginning )
2. make sure the env set correctly in bash_profile, like:
export DOCKER_HOST=tcp://<IP_ADDRESS>:2376
export DOCKER_MACHINE_NAME=default
export DOCKER_TLS_VERIFY=1
export DOCKER_CERT_PATH=/Users/johnwang/.docker/machine/machines/default
3. rerun the cmd: docker-machine regenerate-certs default (maybe before run this, you need reopen the docker terminal)
Tried on docker toolbox on mac, and it works.
Finally some logs of the result:
Error checking TLS connection: Error checking and/or regenerating the certs: There was an error validating certificates for host "<IP_ADDRESS>:2376": x509: certificate signed by unknown authority
You can attempt to regenerate them using 'docker-machine regenerate-certs [name]'.
Be advised that this will trigger a Docker daemon restart which might stop running containers.
...
...
johns-MacBook-Pro:certs johnwang$ docker-machine regenerate-certs default
Regenerate TLS machine certs?  Warning: this is irreversible. (y/n): y
Regenerating TLS certificates
Waiting for SSH to be available...
Detecting the provisioner...
Copying certs to the local machine directory...
Copying certs to the remote machine...
Setting Docker configuration on the remote daemon...
johns-MacBook-Pro:certs johnwang$ docker-machine ls
NAME      ACTIVE   DRIVER       STATE     URL                         SWARM   DOCKER        ERRORS
default   -        virtualbox   Running   tcp://<IP_ADDRESS>:2376           v17.03.1-ce
Hope it helps


Removing merge support, improving test failure messages

Test failures now provide lines that can be copied into baselines,
because they print with {CWD} and {OUTPUT}.

Current coverage is 77.36% (diff: 100%)

Merging #67 into master will increase coverage by 0.06%

@@             master        #67   diff @@
==========================================
  Files            33         33
  Lines          1044       1016    -28
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            807        786    -21
+ Misses          237        230     -7
  Partials          0          0

Powered by Codecov. Last update f5ed4c2...c4e3fc5

LGTM, nits only

Nits fixed.

LGTM


Update clipboard read write permissions with CDP

For https://github.com/puppeteer/puppeteer/issues/5720

Thanks for the patch! For the record, this was changed upstream in https://chromium-review.googlesource.com/c/chromium/src/+/1895749.


Add network option to disable DHCP services

When creating a VM with multiple network interfaces on different
networks, you typically don't want a DHCP server running on every
network. For example, a CoreOS VM will send out a DHCP request on every
network interface by default when it boots up (given no other config
from say, Ignition). This is problematic for the VM's networking
because it will end up with multiple default routes.
An example use case of this is a VM with DHCP enabled on one NIC (to be
used as the "management" network), from which the rest of the VM's
interfaces will be configured.

I'm not sure if it makes sense to have addresses = [something] and dhcp = false, so I was wondering if maybe we could skip this new dhcp argument and have the same effect when addresses is not defined (or defined to be an empty set).

@inercia - thanks for the quick feedback. I like that idea, but the 'nat' forwarding mode requires an <ip family='ipv4' address='x.x.x.x' prefix='x'/> element with an address that can be used on the bridge associated with the virtual network. That IP is then used as a gateway on the host and is necessary to perform NAT, so it seems that regardless of whether or not DHCP services are enabled, the addresses range will need to be supplied. Does that seem right?
Another thought I had was maybe forgetting the dchp option, specifying the addresses option on the network, and determining whether or not to start DHCP services based upon whether or not addresses is present on a domain's network_interface. That is, the libvirt network's xml definition would leave out the <dhcp> element by default, then as domains are created, if they have addresses for their network_interfaces, this libvirt provider would dynamically add the <dhcp> element along with the <host> entries, similar to what it does today (although I don't think it currently adds the <range> element). However, I'm not sure this is a better approach.

I tried out that 2nd possible approach [1] that dynamically updates the network to start DHCP services once domains are created with requested addresses/hostnames. I'm still unsure if that's the way to go. It would also require a small change to one line [2] in libvirt-go.
[1] https://github.com/rawlinp/terraform-provider-libvirt/commit/cc41dd69ffe2a12e8cbdee7196524f00625f6d23
[2] https://github.com/dmacvicar/libvirt-go/blob/master/network.go#L173

I find more elegant this dynamic solution (to add DHCP services when addresses is specified) even if that requires some changes to libvirt-go, but I don't see if there could be side effects in some other scenarios. I guess it would require some testing...

I've created a new PR for the dynamic solution: #111. I've tested each of the various network types (nat, none, route, bridge), and the new DHCP behavior doesn't seem to have unintended consequences.
I found that #111 doesn't actually require a change to libvirt-go like I originally thought. It turned out to be a race condition rather than a persistence issue, but the race condition manifested itself much more often when the network definition wasn't persisted. With some synced access to the network definition, the race condition goes away altogether.
As a side note, I do think I found an unrelated bug with the none and bridge network types, however, because interfaces of those network types aren't added to a domain's xml definition. See [1] and [2].
[1] https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/libvirt/resource_libvirt_domain.go#L348
[2] https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/libvirt/resource_libvirt_domain.go#L410

So can we close this PR and focus on #111 ?

Yes, we can focus on #111.


hapi-fhir-clinical-reasoning

Hapi-fhir-jpaserver-cql module was lacking several of the latest cql evaluator components and features needed to perform clinical reasoning operations. Propose we add a new module to replace it with the latest evaluation logic from cqf-framework as well as carry over existing capability from jpa-cql module. In the process of moving over we will also remove JPA server dependencies and make a new module called 'hapi-fhir-storage-cr'
Environment (please complete the following information):

HAPI FHIR Version-6.3.0-PRE5-SNAPSHOT
OS: [e.g. iOS]- na
Browser [e.g. chrome, safari]- na

Resolved by #4347


Azure Log Analytics

I'd like to know if Spark Connector for data explorer can be used to interface with Azure Log Analytics.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9fa46bfb-17f8-a18d-50a5-eaad4c85ae19
Version Independent ID: ac1fc513-55d6-203a-ce2c-bae250d126d4
Content: Use the Azure Data Explorer connector for Apache Spark to move data between Azure Data Explorer and Spark clusters.
Content Source: data-explorer/spark-connector.md
Service: data-explorer
GitHub Login: @orspod
Microsoft Alias: orspodek

Thanks for the question! We will review and get back to you shortly.

We have assigned the issue to the content author to comment on this .

If by interface you mean to query from Azure Log Analytics with the log analytics credentials and urls then the answer is no.
If you really want to use it for that you will need to find the Kusto cluster, dtabase and table supporting this Log analytics

Thanks, @ohadbitt, for your response.
@haritrichy thanks for reaching out with your question. Since it has been answered, I am going to proceed to close this issue. If you have further questions or comments, please feel free to open a new issue or @ mention myself or Ohad.
#please-close


feat: add borgbackup/borg

Check List

[x] Read CONTRIBUTING.md

[x] Read OSS Contribution Guide

[x] All commits are signed

This repository enables Require signed commits, so all commits must be signed

[x] Avoid force push
[x] Do only one thing in one Pull Request

Add borgbackup/borg to the registry.
While it's also a Python package, single executables are provided by the maintainer and a supported installation method.
ref: https://borgbackup.readthedocs.io/en/1.4-maint/installation.html#pyinstaller-binary

FWIW: Scaffolding added a whole bunch of old versions and accompanying overrides. Instead of digging through years-old releases to fix all the overrides, I went ahead and deleted the old versions. Hope that doesn't break assumptions. 😅

🛎 @ThomasWaldmann FYI

Thank you for your contribution!

⚠ This package doesn't support recent release candidates.
https://github.com/borgbackup/borg/releases

borg worked, but was very slow even if I executed borg directly without aqua.
$ aqua which borg
/Users/shunsukesuzuki/.local/share/aquaproj-aqua/pkgs/github_release/github.com/borgbackup/borg/1.1.12/borg-macosx64/borg-macosx64

$ time /Users/shunsukesuzuki/.local/share/aquaproj-aqua/pkgs/github_release/github.com/borgbackup/borg/1.1.12/borg-macosx64/borg-macosx64 --help
# ...
 --help  0.28s user 0.06s system 7% cpu 4.824 total

Can confirm. I suspect that has to do with how the Python application is packaged and run:

Note that the binary uses /tmp to unpack Borg with all dependencies.

For this application, I'm willing to take that startup overhead over having to handle globally installed pip packages. YMMV, obviously.
(I noticed a similar slowdown for pre-commit.pyz -- in that case, less tolerable.)

v4.193.0 is out 🎉
https://github.com/aquaproj/aqua-registry/releases/tag/v4.193.0


Urban Mobility : Part I

@chicco785 please could you review?

no news from @chicco785 . should I auto-land or someone may help. maybe @fgalan ? @jason-fox ?

@chicco785 I will try to accommodate your request by updating the documentation.

As general comment, the entities included in this entity don't use dateCreated and dateModified. Maybe it's intentional, but I have noticed it... as typically they are used in other models.

@fgalan now dateCreated , dateModified added


`Feature/1180 pathfinder single path csvs

Submisison Checklist

[x] Run tests: ./runCmdStanTests.py src/test
[x] Declare copyright holder and open-source license: see below

Summary:
Added flag save_single_path to method pathfinder, per discussion in #1180
Intended Effect:
Better user experience.
How to Verify:
Unit tests
Side Effects:
N/A
Documentation:
see PR https://github.com/stan-dev/docs/pull/651#
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

Do we feel like this should interact with the diagnostic files at all? I know at the moment there are no multipath-pathfinder specific diagnostics in reality, so it might be odd to require the save_single_paths argument to get any diagnostics out

it might be odd to require the save_single_paths argument to get any diagnostics out

but this isn't required - save_single_paths outputs CSV draws from the individual pathfinders.
the diagnostics files report on the Pathfinder trajectory via LBFGS.

I understand the current behavior, I'm asking if we think it should have an impact
Imagine one day we actually use the argument for multi-pathfinder to have diagnostics (independent of the single path diagnostics). Then it would seem natural that this argument also controlled whether the single-path diagnostics were saved.

I see - so if you want the diagnostics file then you'd probably want the single-path pathfinders as well?
which means that we don't need "save_single_paths" - diagnostic_file arg controls everything?
and then you'd have both .json and .csv files which have the same basename?
very elegant!

I was thinking of more or less the flip of that - what should this argument do if there are multiple kinds of diagnostics (like there are multiple kinds of output csvs at the moment)

add more arguments to pathfinder method that are fine-grained enough to handle this and forget about output arg diagnostics_file?

I think I was unclear.
This PR was motivated because the current “output” argument controls both the output of the PSIS draws and the individual paths. My point is just that one day, if we actually use the diagnostic file argument to the multi-path algorithm, we will have the same thing with the “diagnostic file” argument - some for the PSIS, some for single paths. Whether we care is another question, and the answer can be “no”

if I understand correctly proposal is this:

diagnostic_file - is an output sub-argument which is reserved for multi-path Pathfinder.
"save_single_paths" - for method pathfinder is a boolean arg which, if true, will create both the CSV file of draws and the json file of ELBO evaluations.

if I understand correctly, save_single_paths is useful mainly for exploring Pathfinder behavoir on challenging or ill-specified models.

Currently, this PR implements:

-
output=foo
diagnostic_file=bar

save_single_paths=0
One file, foo.csv, containing PSIS draws
Several bar_N.json files, one for each path, containing single-pathfinder diagnostics

save_single_paths=1
The same foo.csv file, plus individual foo_path_N.csv files, one for each path
Several bar_N.json files, one for each path, containing single-pathfinder diagnostics

My question was, should the matrix look instead like:

-
output=foo
diagnostic_file=bar

save_single_paths=0
One file, foo.csv, containing PSIS draws
One file, bar.json, containing the diagnostics for multi-path pathfinder (currently, this is completely unused).

save_single_paths=1
The same foo.csv file, plus individual foo_path_N.csv files, one for each path
The same bar.json file, plus individual bar_path_N.json files containing the diagnostics for each single-path

As noted, there are currently no diagnostics for multi-path besides each individual path's diagnostics, but if we ever think there would be then maybe the second table makes more sense. Of course, if someone is asking for diagnostics, maybe it's fine just to give them more than they asked for. It's a much less common use case than output, at any rate

two things:

creating an empty multi-path pathfinder diagnostics file is confusing
having to specify diagnostic file basename could be skipped in favor of adding distinguishing tags for output file basename.

per discussion w/ @WardBrian and @SteveBronder:

output sub-arg diagnostic_file will be used for outputs from multi-path Pathfinder.  currently, dummy json writer passed in to service method call.
pathfinder boolean arg save_single_paths, when true, will save both single-path sample as well as single-path diagnostics which report on the ELBO evaluations.   these files names will constructed from the output_file basename, plus _path + path id.

Question:  what should single path pathfinder output file be named if num_paths= 1?   what about num_paths=1 and save_single_paths=1?   Choices for output filenames:

a.  basename_path_1.csv  and basename_path_1.json
b.  basename.csv and basename.json

I prefer option b.  opinions?  @bob-carpenter ?

I think if num paths is 1 it should just be “output.csv”, and the diagnostic should probably come from the diagnostic file argument

how about this:
if num_paths=1 and save_single_paths=1 and arg diagnostic_file is unspecified, then single-path diagnostics are in file output.json.
if num_paths=1 and diagnostic_file="foo.json", then single-path diagnostics are in file foo.json.

this is ready for re-review.

CI failed on upstream/(downstream?) performance tests - one of the benchmarks gold files is missing?
@WardBrian @serban-nicusor-toptal

Informational Message: The current Metropolis proposal is about to be rejected because of the following issue:
Exception: gp_exp_quad_cov: sigma is 0, but must be positive! (in '../stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan', line 14, column 4 to line 15, column 59)
If this warning occurs sporadically, such as for highly constrained variable types like covariance matrices, then the sampler is fine,
but if this warning occurs often then your model may be either severely ill-conditioned or misspecified.

Iteration:  100 / 2000 [  5%]  (Warmup)
Iteration:  200 / 2000 [ 10%]  (Warmup)
Iteration:  300 / 2000 [ 15%]  (Warmup)
Iteration:  400 / 2000 [ 20%]  (Warmup)
Iteration:  500 / 2000 [ 25%]  (Warmup)
Iteration:  600 / 2000 [ 30%]  (Warmup)
Iteration:  700 / 2000 [ 35%]  (Warmup)
Iteration:  800 / 2000 [ 40%]  (Warmup)
Iteration:  900 / 2000 [ 45%]  (Warmup)
Iteration: 1000 / 2000 [ 50%]  (Warmup)
Iteration: 1001 / 2000 [ 50%]  (Sampling)
Iteration: 1100 / 2000 [ 55%]  (Sampling)
Iteration: 1200 / 2000 [ 60%]  (Sampling)
Iteration: 1300 / 2000 [ 65%]  (Sampling)
Iteration: 1400 / 2000 [ 70%]  (Sampling)
Iteration: 1500 / 2000 [ 75%]  (Sampling)
Iteration: 1600 / 2000 [ 80%]  (Sampling)
Iteration: 1700 / 2000 [ 85%]  (Sampling)
Iteration: 1800 / 2000 [ 90%]  (Sampling)
Iteration: 1900 / 2000 [ 95%]  (Sampling)
Iteration: 2000 / 2000 [100%]  (Sampling)

 Elapsed Time: 1.795 seconds (Warm-up)
               2.345 seconds (Sampling)
               4.14 seconds (Total)

Traceback (most recent call last):
  File "./runPerformanceTests.py", line 424, in <module>
    results = list(results)
  File "./runPerformanceTests.py", line 345, in process_test_wrapper
    time_, (fails, errors) = run(exe, data, overwrite, check_golds,
  File "./runPerformanceTests.py", line 275, in run
    summary = csv_summary(tmp)
  File "./runPerformanceTests.py", line 163, in csv_summary
    with open(csv_file, 'r', encoding = 'utf-8') as raw:
FileNotFoundError: [Errno 2] No such file or directory: 'golds/stat_comp_benchmarks_benchmarks_gp_pois_regr_gp_pois_regr.gold.tmp'
script returned exit code 1

It’s because the performance tests request output files that end in .tmp:
https://github.com/stan-dev/performance-tests-cmdstan/blob/ffff830fbd6d5e09dbee67dad336e957e9e19b2a/runPerformanceTests.py#L268
But the latest changes here (to make_filenames specifically) always overwrite that to be .csv


Document routing proto in JSON/YAML format

Need to document the routing proto in a human readable form. in markdown or someplace, instead of asking people to read the proto file.

Done by istio/istio PRs


Corrected Env API variable name in empty check

The Env variable name for the API key was different in the if check, so would never work.

@purplespider thanks for the fix.
Published as v1.0.13.


Square logo image

"This image is only used for Windows authentication and appears only on tenants that are using Windows Autopilot for deployment or for password entry pages in other Windows 10 experiences"
In my experience this logo is used in consent dialogs too.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72f2e675-436d-dcd4-fa27-49408b201158
Version Independent ID: 4d821732-fc10-f4a6-3c7d-77bce75299d7
Content: Add branding to your organization's sign-in page - Azure Active Directory
Content Source: articles/active-directory/fundamentals/customize-branding.md
Service: active-directory
Sub-service: fundamentals
GitHub Login: @eross-msft
Microsoft Alias: lizross

@crmhh Thank you for your feedback. We will investigate and update this thread further.

@crmhh It might be possible that you may have seen this within consent dialogues for work accounts . I have initiated a pr with a small note and it will be accordingly updated.


Missing error check of function entropy_get_entropy()

Hi,
As described in the project API documentation, function entropy_get_entropy() fills a buffer with entropy, returns 0 on success, and returns -ERRNO on error. However, as shown in the following code, a missing error check take places.
https://github.com/zephyrproject-rtos/zephyr/blob/577d588b3a108c34430b8fbaec9bb4f2a690b7fb/subsys/random/rand32_ctr_drbg.c#L133-L135
Furthermore, the return values of function entropy_get_entropy() from other call sites are all checked. See the following code which is from the same file, for example.
https://github.com/zephyrproject-rtos/zephyr/blob/577d588b3a108c34430b8fbaec9bb4f2a690b7fb/subsys/random/rand32_ctr_drbg.c#L85-L90

@Hxinrong would you mind sending a pull request for this?

OK, thank you for your replay. Also, in the same file, seeing the following code, the return value of function tc_ctr_prng_reseed() is not checked before it is assigned by another function.
https://github.com/zephyrproject-rtos/zephyr/blob/577d588b3a108c34430b8fbaec9bb4f2a690b7fb/subsys/random/rand32_ctr_drbg.c#L136-L148


collection(x).document(id).collection(y).getDocuments() always returns 0 documents

I have collection that contains subjects.
A subject contains a collection of posts.
await collection.document(this.id).collection('posts').document('explanation')
Returns Instance of 'DocumentSnapshot'
While
await collection.document(this.id).collection('posts').getDocuments()
always returns 0 documents`
collection.document(this.id).collection('posts').snapshots does not work either

Hi there, can you please send a flutter doctor -v flutter analyze and show a bit more of the code?

sorry had a typo in the collection name


feat: Implement bandwidth limit on ingress-egress using tc

Proposal:
TC(Traffic Control) supports multiple types of filters that can be attached to different classes inside q-disks(RTM). Since neither libbpfgo nor ebpf-go libraries support tc functionality directly due to multiple reasons listed here
We can use a separate library like go-tc to attach ebpf filters on an interface(ingress/egress) to implement bandwidth limiting on any given interface.
If the proposal sounds good, then I would like to create a draft PR on this where we can carry forward the discussion.

@DelusionalOptimist

@Revolyssup Have we considered the TC hooking capabilities that libbpfgo provides? Are they not sufficient for the use case?
Here is an example - https://github.com/aquasecurity/libbpfgo/tree/main/selftest/tc

@DelusionalOptimist Just to confirm few things, here is the proposal:

Since meaning of source and destination will be different for Ingress and Egress, rules can have two fields ingress and egress. Both consisting of their own configuration. Most of the configuration will be the same like protocol, src ip, dest ip, dest por, src port.
We can use XDP for ingress and tc for Egress.

What do you say?
For later:

Each field ingress and egress can be an array where the rules are evaluated in the order of priority where each rule can be given a priority like a nice value. The greater the value, the later it will be executed.
This can be helpful when later an optional action field is added that can be deny(default) and allow. This can help to chain together bunch of rules with necessary actions.

@Revolyssup based on your proposed configuration, I can picture it somewhat like below. Let me know if I'm right.
rules:
  - id: "restrict webserver"
    ingress:
      - id: "only allow port 443"
        sourceIP: '*'
        destinationPort: 443
        <...>
        # future
        action: allow
        priority: -20
    egress:
      - id: "block access to github.com"
        destIP: '<IP_ADDRESS>'
        destinationPort: '*'
        <...>
        # future
        priority: 20
  - id: "restrict firefox"
    egress:
      - id: "block access to ads.google.com"
        destIP: '<IP_ADDRESS>'
        destinationPort: '*'
        <...>
        # future
        priority: -20

This sounds good and also pretty close to Kubernetes' NetworkPolicy. I think this way we can use each individual "rule block" to granularly define process level networking.
A couple of things worth mentioning:

Structuring the rules internally keeping in mind limitations of BPF Maps and how they can be iterated.
For reference - https://github.com/xdp-project/xdp-tutorial/tree/master/advanced01-xdp-tc-interact

We can have sibling field action where more complicated packet manipulation actions could be defined, later referenced by ID/name in rules. This last one could be a no-no depending if we want dropit to do just one thing(act as a firewall dropping packets) or if we want to later on extend it to go beyond plain packet dropping.

I think we can extend further to basic things like redirecting packet based on some information and so on but let's think about it later.

@DelusionalOptimist In first iteration, will we need the interaction between xdp and tc or can they work independently on ingress and egress respectively?

@Revolyssup My bad. I meant to cite that resource for future reference. I don't think we would need any interaction b/w the two for our current use case.

@DelusionalOptimist What if we kept it simple and just add a type field to existing rules ? Assuming functionality added might have a different approach for ingress and egress but will be the same. In cases when something can not be implemented by either one, we can produce warn logs indicating that. For eg: [warn] xyz capability not supported on ingress by sanitising/checking the configuration provided with the features that can be supported at config load time.
Let me know if this categorization makes sense to you?

I think I should create a draft PR from here and carry discussion there so we have something concrete to make comments on.

@DelusionalOptimist Do you suggest we have separate maps for ingress and egress filter_rules? To avoid contention as the rules are evaluated on each entry, we would be evaluating ingress rules on egress packets.

What if we kept it simple and just add a type field to existing rules ? Assuming functionality added might have a different approach for ingress and egress but will be the same. In cases when something can not be implemented by either one, we can produce warn logs indicating that. For eg: [warn] xyz capability not supported on ingress by sanitising/checking the configuration provided with the features that can be supported at config load time.

Quite frankly that was what I was thinking initially but I thought you wanted to keep it close to Network Policy. I'm fine either ways.


[POC] Code generators for builder

Writing builders for models is tedious. Let's see if there is a way to automatically generate those classes completely.

Shifted to TestCodeGenerator repository.


Deprecate [Bintray] service

Fixes #6137.
The Bintray service is going away in a week, with a service brown-out scheduled for April 26th. Probably a good time to deprecate our badges.

Warnings

:warning:
This PR modified the server but none of its tests. That's okay so long as it's refactoring existing code.

Messages

:book:

Thanks for contributing to our documentation. We :heart: our documentarians!

:book:
:sparkles: Thanks for your contribution to Shields, @PyvesB!

  Generated by :no_entry_sign: dangerJS against b6e6a79b4f63a0b83ee7350579d2eb7a77f4a0ff


Organization List Page - Search Button

Scenario
Home Page -> Nonprofits
Fill in search keyword: Teens
Click Search

Requirement
Upon search button is clicked, retrieve and display the list of organizations satisfying the keyword search

Rest API
Rest Endpoint: GET /api/organization/search/byKeyword/{keyWord}
Rest API Document: http://localhost:8080/swagger-ui.html

This issue was moved to Code4SocialGood/c4sg-web#17


Added Procfile to deploy easily to Heroku

Provides a Procfile to deploy to Heroku through a worker. $EXTRA_ARGS is there to provide easy argument providing.

Isn't Heroku IP banned by Niantic?

Yes like almost every service provider, but it works great if you set a proxy through HTTP_PROXY and HTTPS_PROXY env variable

:+1:


Update fastly major version to 4

To be merged after https://github.com/pulumi/pulumi-fastly/pull/152

d'oh


feat: update brand

Because there were breaking changes in SDK, cloud flows need to be updated when this gets released.

@OPesicka we should also update colors in css template


Report binary version to error reporting service

Problem
The error reporting service (https://prisma-errors.netlify.com) does not show the binary version for errors. @janpio said that it wasn't reported at all.
While this information might be redundant, it would be useful to be able to view everything that can be reported.

Actually people can overwrite or change their local binary - so having this information is actually required to get a full and correct picture of what is happening locally.


More updates to the ignored translations file and translation CI infrastructure

Description
This update the json file that list the  ignored translations.
It is better reviewed one commit at a time.

recreate the json file, just sorting the keys.
update the regeneration logic to keep the string order in each file (it's more convenient).
regenerate the json file with:

python tools/test_strings.py

Note that many strings that disappeared are not there anymore just because they use to be seen as N joined-strings, are are not seen as a single one.

fix some pytest thingy.

Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change
[ ] example: I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

Thanks for fixing this @Carreau ! Changes look good, so we probably merge this soon.
But also wanted to check if you expect all the related tests to pass now? I pulled this branch down and ran them locally with the same command in the workflow: python -m pytest -Wignore tools/ --tb=short and found that test_missing_translations is failing with lots of missing translations.
No problem if that's expected - fine to follow up with more PRs that fix those, which might need specific authors anyway.


srt: Fix wrong srt.pc include path

Motivation for this change
Fixes #70872.
Fix copied from:
https://github.com/NixOS/nixpkgs/blob/1230fc8674439df5a90fe4c1ea740256ef9906e4/pkgs/development/compilers/hhvm/default.nix#L41-L44
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @nh2
FYI @j0sh

After merging this should be backported to release-19.09.

Thanks for this! Can confirm with a quick test [1] that this fix works.
[1] Overriding the cmakeFlags attribute to insert the new flag:
let
  nixpkgs = import <nixpkgs> {};
  srt = nixpkgs.srt.overrideAttrs (oldAttrs: rec {  cmakeFlags = nixpkgs.srt.cmakeFlags ++ [ "-DCMAKE_INSTALL_INCLUDEDIR=include" ]; }) ;
in
  with nixpkgs;
  stdenv.mkDerivation rec {
    name = "SRT_Fixed";
    env = buildEnv  { name = name; paths = buildInputs; };
    buildInputs = [ pkg-config srt ];
  }

Results in:
$ pkg-config --cflags --libs srt
-I/nix/store/82dkq0hb40ifgqm0kdg2mwkbpnsgjmip-srt-1.3.2/include -I/nix/store/82dkq0hb40ifgqm0kdg2mwkbpnsgjmip-srt-1.3.2/include/srt -L/nix/store/82dkq0hb40ifgqm0kdg2mwkbpnsgjmip-srt-1.3.2/lib -lsrt

Linking issue that collects such CMake path issues: #144170


Intents, activity, or Tasker integration to directly open App Drawer?

Is there currently a way through intents or activities in android to directly open the app or widget drawer without the anchor point? if not are there plans to enable this, possibly through the Tasker integration?

This feature has just been committed to master and will be available in the upcoming 4.0 release.


Why does CustomLayer example change the position if the comment says it shouldn't be transformed?

Am I the only one that thinks that the implementation of https://github.com/pmndrs/lamina/blob/main/README.md?plain=1#L205-L216 is confusing when looking at the comment?
For me it sounds like, that a CustomLayer should't change the position via the vertex-shader, but in the example it totally does exactly that:
  // Optionally Define a vertex shader!
  // Same rules as fragment shaders, except no blend modes.
  // Return a non-transformed vec3 position.
  static vertexShader = `
    // Varyings must be prefixed by "v_"
    varying vec3 v_Position;
    void main() {
      v_Position = position;
      return position * 2.;
    }

So Return a non-transformed vec3 position. sounds to me that  return position * 2.; shouldn't be done (I mean of course you can do that, but as a best practise it shouldn't right?).
When I copied the example I was surprised that my mesh had increased in size.

Sort typo, meant “non-projected”. Will fix
basically you don’t need to project the position by multiplying it with modelViewPosition

Awesome, thank you very much!


created the goal success modal ..(initial PR for this component)

Done with the goal success modal.... However I didn't import it into the create goals file to avoid breaking your code....its in the home.jsx file and it's displayed ' none ' to view it change the display to block.

@tundealabi review

@abiona01 reviewed


Microsoft to have an official Kotlin Extension

I would like Microsoft to have a working relationship with JetBrains official Kotlin Language,
So the language can work properly within VSCode, as well as have features like Linting and proper Code Formatting.

I would like to be able to have an official Microsoft Extension for Kotlin, like they do for Python, C#, C++ and others.
Sometimes people just want to open a simple IDE text editor like VSCode to do some quick coding instead of opening
and full fledged IDE , place ktlint in every single project to get something done.
Can Microsoft PLEASE make an official extension for Kotlin that has Code Completion, Linting, Semantic Highlighting, Debugging, Go-To Definition, Signature Help, Hover, Formatting, Document Symbols, Find References and others.
Thank you  :)

There are several existing Kotlin extensions on the extension marketplace. Maybe one of those would work for your needs.

We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the VS Code Marketplace. Just in case, in a few simple steps you can get started writing your own extension. See also our issue reporting guidelines.
Happy Coding!

I tried those extensions.  that's the first thing I did and they cause more problems than they should.
I even get tons of error messages when compiling.  THIS is the reason why I posted this post.  SMH
Microsoft currently has many extensions for languages and they run perfectly. Microsoft just does not have Kotlin.
All I am asking for is for Microsoft to do the same for Kotlin, just like they do for Python, C++, C# and other languages Microsoft has created extensions for.


Update CHANGELOG.md

Fixed in 66a2a5e8cae3421cf2c25cc56492e5674b7eeda3 thanks for the PR though :smiley:

You CHANGELOG.md still have two releases with title 0.16.1 ;)


[ARITH] Simplifier Improvement

The simplifier does not simplify (y - x) - y. Interestingly, (y - x) - y < 0 is simplified, but (y - x) - y > 0 is not:x = tvm.var('x')
y = tvm.var('y')
print(tvm.ir_pass.Simplify((y - x) - y))
print(tvm.ir_pass.Simplify((y - x) - y > 0))
print(tvm.ir_pass.Simplify((y - x) - y < 0))

Output:
((y - x) - y)
(0 < ((y - x) - y))
(0 < x)

CanonicalSimplify works well on this example though.
The simplifier rewrites (3*x + y)/3 into x + (y/3). Since tvm uses C/C++ truncated division instead of flooring or euclidean division, this is wrong (e.g. x = 1, y = -1). Recently there was a related issue here. However, instead of disabling another simplification rule I would suggest discussing another option: using Euclidean division in TVM, since the Euclidean definition has some advantages regarding program transformations, and it was originally used in Halide.

Some of these are not as problematic, because they can be caught by CanonicalSimplify.
Eventually, we will need a new simplifier that takes all of these into consideration, and do reasonable integer set analysis hopefully in the next release cycle

To follow-up on Euclidean divisions, I agree that euclidean div is nice for analysis. The main problem of Euclidean div generation is it is relatively hard to generate efficient low-level code for it. Unless we have a strict analysis of positiveness of the index, in which case the definition of division won't matter. So the case now is we would just stick for floor div as it is close to machine code, improve the integer set analysis to cover the range of the variable and then revisit the issue later

By the way, turned out the HalideIR submodule hasn't been updated for a while, so the fix of @xqdan is not  in TVM yet. (Unfortunately it doesn't solve my case of incorrect simplification anyway).
I would still vote for Euclidean division, and concerning its problems, I would suggest the following plan:

Rename Div and Mod in IR to EuclideanDiv and EuclideanMod
Add explicit functions like euclidean_div, truncated_div, etc into the python interface. The ordinary / and % operators should be translated into expressions checking that their arguments are non-negative and throwing an exception or something like that when they are negative.
Add a pass rewriting EuclideanDiv in terms of truncated div. As a result, select expressions will appear, but I think they can be effectively eliminated in most cases even with the existing integer set analysis and simplification. Of course, we have to think about some kind of performance regression testing before doing this.

If we choose truncated division, then we should do something with the HalideIR simplifier, because it is used everywhere and is heavily relied upon, and we cannot just replace it with CanonicalSimplify yet.

Given that truncate div is the current way and the limited simplification works fine for now, I propose us to do the following thing, from pragmatic point of view:

Upgrade the integer set analysis to cover most cases on positiveness testing
Keep Div/Mod as truncated version as developers in c++/LLVM are more familar with this semantics(no surprise principle).

If necessary, I wont mind disabling some of the rules temporary, given that the div rules in the index simplification do not play an important role for perf.

Add CeilDiv or EuclideanDiv to the IR.
Do the truncated rewriting pass as @sgrechanik-h suggested.

Since this would be a major change to the analysis pipeline, we might want to do it in the next release cycle.

move to #2588


Race condition when dealing with API Revisions

When exporting apis with multiple revisions, you can get a race condition trying to output the apis to disk.

I am able to recreate this using an apim instance with 1 api and multiple revisions.

Problem seems to stem here:
https://github.com/Azure/apiops/blob/af507dcb80f37fb9146e979c9f040d139ec14f08/tools/code/extractor/Extractor.cs#L315
there are 2 apis with the same DisplayName because of revisions, so they both try to write to the file at the same time.
you can replace it with:
        await foreach(var api in apis)         {             await ExportApi(api, cancellationToken);         }
but it doesn't solve the underlying issue.
One api will over-write the other.

Please check the latest version which now supports versioning and let us know if this fixed your issue so we can close this issue.


chore(deps): update dependency kubernetes/kubernetes to v1.29.1

This PR contains the following updates:

Package
Update
Change

kubernetes/kubernetes
patch
1.29.0 -> 1.29.1

Release Notes

kubernetes/kubernetes (kubernetes/kubernetes)
v1.29.1: Kubernetes v1.29.1
Compare Source
See<EMAIL_ADDRESS>Additional binary downloads are linked in the CHANGELOG.
See the CHANGELOG for more details.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Set the XR camera's fov

This is important for features requiring fov, like gaussian splatting.
Though it will probably not change on ech frame, this is computed on each frame in case the camera's projection matrix changes during the session.
Note that it is also expected that left fov === right fov, but the XR camera's parent is taking the first camera's fov (left)/

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14974/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14974/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14974/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14974/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14974/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14974/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14974/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14974/merge#BCU1XR#0

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14974/merge/testResults/webgpuplaywright/index.html


Increase magic power (API)

Hello,
I would like to know how to increase the power (spell damage) of a wand with the MagicAPI
Do I have to configure the wand ? Or can I change the damage with an event ?

boolean com.elmakers.mine.bukkit.api.wand.Wand.configure    (Map< String, Object >     properties)

Thanks.

The only way to do that with wand properties is to use configure and to set "power".
You could then modify the power-related config properties here:
https://github.com/elBukkit/MagicPlugin/blob/master/Magic/src/main/resources/defaults/config/defaults.yml#L469
To make it so Power only affects damage. By default it will also increase the radius and range of spells.
Otherwise yes another approach is to catch the damage event but there isn't a reliable way to know that the damage was from a spell. You can look for the MAGIC damage source, but it doesn't apply in a few random cases (witches, endermen) due to them being nearly immune to magic damage.
Hm- well this is a bit ugly but you could also look here:
https://github.com/elBukkit/MagicPlugin/blob/master/Magic/src/main/java/com/elmakers/mine/bukkit/utility/CompatibilityUtils.java#L82
CompatibilityUtils.isDamaging is set anytime Magic is dealing damage to something, and should be set during handling of the damage events.
If you do end up using that let me know and I'll add it to the API properly somewhere, probably on MageController.

Okay so I will configure the wand
But I didn't understand this :

Map< String, Object > properties

What kind of Map should I put in argument ?

Put "power", 1 in there for full power. Power is a floating point ranging from 0 to 1.

Oh, thanks :) !

And how to get all wands of a player ?

They are just items, so you'd have to search their inventory and check every item. If they are holding one you can get that one with Mage.getActiveWand

Yes but I wanted to know if there are another way (no loop)
It's not a problem
And also, how can I modify the lore on the wand describing the augmentation of spell damage so it displays a percentage instead of roman numbers ? To be clear, I want the wand to display something like "Spell Damage : +X%" instead of "Power III" or "Power VI".

Unfortunately no, the only options are show the raw value or roman numeral. I think percentage is a good idea though.

Okey, so thanks for your help !


Create pipeline for automated testing

Work-in-progress checkout pipeline branch

ToDo

[ ] Reuse letsencrypt accountkey

Merged draft pipeline into devel, devel will be merged into master with #122


docs: add example snippet for adding custom schema for yamlls

I struggled for a while to get the YAML language server to pick up my
custom schema as I was providing the same structure as to the JSON
language server. However, as the YAML language server expects a
{ url = fileMatch } this was not working. I figured it'd be helpful
for others to include this in the README.
I also believe #9 can be closed now because there's already a
require('schemastore').yaml.schemas() function!

Alternatively, maybe the require('schemastore').{yaml,json}.schemas() functions could accept additional schemas as an option, to abstract these operations away. Something like:
local extra_schemas = {
    {
        description = 'My Custom JSON schema',
        fileMatch = { 'foobar.json', '.foobar.json' },
        name = 'foobar.json',
        url = 'https://example.com/schema/foobar.json',
    },
}

require('lspconfig').jsonls.setup {
    settings = {
        json = {
            schemas = require('schemastore').json.schemas {
                extra = extra_schemas,
                select = {
                    '.eslintrc',
                    'package.json',
                },
            }
            validate = { enable = true },
        },
    },
}

require('lspconfig').yamlls.setup {
    settings = {
        yaml = {
            validate = true,
            schemas = require('schemastore').yaml.schemas {
                extra = extra_schemas,
            }
        }
    }
}

#14 supersedes this PR, if you think that approach makes sense!


CI: Use<EMAIL_ADDRESS>as the addres for Flatpak External Data Checker

Tried to make Flatpak External Data Checker's PR merged automatically before. But, it is failed and may due to the wrong mail address. Notice eos-google-chrome-app uses Flatpak External Data Checker and merges PRs automatically 1. So, sync the mail address as<EMAIL_ADDRESS>with eos-google-chrome-app.

Oh, I see that we have that, but not in the root of the repo.
Do you have the logs of it failing?

The CI is failing which I think is more likely to be the reason the PRs don't get automerged.

Oh, I see that we have that, but not in the root of the repo.
Do you have the logs of it failing?

No corresponding failed log, actually.  The PRs just not merged automatically as result.  So, this is a guess.

I believe the with open("flathub.json") as f: means the flathub.json in the working directory, right?

fedc does not automerge if there are failing CI checks.

I believe the with open("flathub.json") as f: means the flathub.json in the working directory, right?

It does, and the action for this repo does run in the right directory for that to work.

Have to fix the appdata.xml checking failure.  So, I convert this to draft.

The problem we're having is that the CI isn't running at all. See https://github.com/endlessm/endless-key-flatpak/actions/workflows/build.yml. None of the runs were triggered by an fedc PR which all have names that begin with Update.
I could never figure out why, but my only idea was just to remove this email address and let it be whatever GitHub Actions sets the git author to. Using<EMAIL_ADDRESS>might work, though. On the other hand<EMAIL_ADDRESS>does not represent any GitHub user that I'm aware of.
Also, eos-google-chrome-app is a little different. The CI runs in Jenkins, not GitHub Actions. In that case, Jenkins picks up the webhook event and starts the CI build. Then f-e-d-c can see that the CI was successful and can carry on with merging or not. We never get any builds triggered here, though.

#142 is a good target!

Or, maybe cause by this issue GitHub Actions Not Run on PR Generated by GitHub Actions

Or, maybe cause by this issue GitHub Actions Not Run on PR Generated by GitHub Actions

Oh, good find! Following the links, that eventually points to https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs. I think we could use a personal access token from eos-shell-build for this purpose. I just did something like this recently... The drawbacks are another PAT to manage and the PRs will be created by the eos-shell-build user.
However, I kinda like https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#authenticating-with-github-app-generated-tokens better.

This is basically exactly the same as https://phabricator.endlessm.com/T34806 where we needed a PAT to trigger a repository dispatch event because you can't trigger recursive workflows from the default GITHUB_TOKEN.

I just took the same token, which is scoped specifically for use in GitHub Actions with repo scope, and recorded it as a secret here with the name WORKFLOW_TOKEN. The idea being to use it when you need to trigger a recursive workflow. I'll add a commit to #142 that uses that token instead of GITHUB_TOKEN.

Well, that did trigger the checks, but it's not a fair test. In that case, the trigger was me pushing to the PR branch. The real test is when the trigger is the "Check for Updates" workflow. Anyway, the change to use the PAT is in #144.


docs(pipeline expressions): major refactor of current guide.

Split pipeline expressions guide into reference & overview docs
Updated the screenshots

@jeyrschabu mind taking a look at this?

@jeyrschabu yep, the screenshot titled "execution-json.png" shows how to get to the execution JSON, and the process is described in the "how do I test a pipeline expression?" section of the guide (guides/user/pipeline/expressions/index.md, as opposed to the reference file).


Rest API

Would it be possible to provide some kind of REST API to access the data remotely?  That would be unbelievably useful for something I'm working on at the moment :)

Unfortunately, we have no plans to release an API at this time. A data dump is available at ftp://ftp.broadinstitute.org/pub/ExAC_release if that helps!


Bug on hidesBarsOnTap

Hello Harshil Shah! Thanks a lot of what are you doing!!
In ios11 I found interesting bug. On hiding navigation bar on tap it disappears like on foto. Can you help with this?

It works good on version 0.4, but now don't

I use standard QuickLook library(QLPreviewController) to open files. And this QLPreviewController have default set  "hide bars on tap".  When I tap on image navigation bar disappears and  when I use your library this func
@objc private func handlePan(gestureRecognizer: UIPanGestureRecognizer) is not called at all.
Unfortunately this line of code did not help.

Hmm, interesting. Could you possibly upload a minimal demo project by modifying the example app to reproduce your issue?

Yeah sure, here is example:
https://github.com/Bronko44/example

Thank you so much for the example project!
So the issue here is that since navigation controllers are usually presented fullscreen, they just translate the bars directly with no clipping. Fortunately there's a simple solution for this.
In the DetailsVC's, if you use the following line, it will clip the navigation bar's contents:
navigationController?.view.clipsToBounds = true

Clipping has a performance cost sometimes, depending on exactly what drawing is going on, so I'd suggest toggling it with caution, but it does indeed make the animation look as you want it to.

Thanks a lot, this solved the problem. And thanks for a detailed explanation to, I appreciate it!


Just adding a new tag, 0.0.2, for Polymer 1.0

Added a tag version to people using Polymer 1.0.

Thanks @alefwmm


Ansible Shepherd-Install softbricks the Beaglebone

there seems to be a bug where the update_kernel.sh does not activate the downgrade to kernel 4.19 (from time to time).
-> current dev-branch has guards implemented in the ansible playbooks before deleting the active kernel-image.
Quick Fix: switch out entry for active kernel in /boot/uEnv.txt during install
Better Fix: double-check in ansible (determine installed kernel, adapt uEnv.txt), TODO
Workaround: there is a ready-to-use image (last update 2022-12-14)

found culprit -> dist-upgrade changed kernel from 4.19 back to 5.10 and a later step removed 5.10....
fixed with - ecd1a60f
but the ready-to-use image stays!


KLD Weight

Hi,
In the VAE paper (https://arxiv.org/pdf/1312.6114.pdf), the VAE loss function has no additional weight parameter for the KLD loss:

However, in the implementation of the Vanilla VAE model, the loss function is written as below:
loss = recons_loss + kld_weight * kld_loss
When I set "kld_weight" to 1 in my model, it could not learn how to reconstruct the images. If I understand correctly, the "kld_weight" reduces the effect of the KLD loss to balance it with the reconstruction loss. However, as I mentioned, it is not defined in the VAE paper. Could anyone please explain to me why this parameter is used and why it is set to 0.00025 by default?

It is defined in equation 8 of the paper.

In Equation 8, I see that the MSE loss is also scaled with N/M. However, only the KLD loss is scaled in the code. Shouldn't we scale both of them according to the equation @WonJunior ?

N is the dimensionality of input (for images, WH)
Couldn't it be WH*channels? Another part of that doc says
over the individual pixels xn

This weight is needed when you use L2 loss as the reconstruction loss. L2 loss (aka MSE) means that you're assuming a Gaussian $p_{\theta}(x|z)$, for which you need to specify a $\sigma$ for the Gaussian distribution as a hyperparameter. This is where the relative weight between the reconstruction loss and the KL divergence comes. If you instead assume a Bernoulli distribution and thus apply a (per pixel per channel) binary cross-entropy loss, this relative weight is not necessary.
You can refer to section 2.4.3 of Carl Doersch's tutorial on VAE for more details.


Whisparr v2 support

Looking at https://github.com/autobrr/omegabrr/blob/851eda82956c22e942150f4374061769541d1edc/internal/processor/service.go#L67 it looks like whisparr is configured for radarr which may have been the v1 whisparr.  v2 uses sonarr which results in this fail:
2023-08-30T21:08:50-04:00 DBG gathering titles... client=whisparr type=radarr 2023-08-30T21:08:50-04:00 ERR error while processing Whisparr, continuing with other clients error="api.Get(movie): failed:  (status: 404 Not Found): invalid status code, <200||>299: " client=whisparr type=whisparr 2023-08-30T21:08:50-04:00 WRN Run complete, with errors. 2023-08-30T21:08:50-04:00 WRN Errors encountered during processing: 2023-08-30T21:08:50-04:00 WRN Whisparr - whisparr: api.Get(movie): failed:  (status: 404 Not Found): invalid status code, <200||>299:

Fixed with #63


:art::fire: Remove msfragger .params as dependency for FragPipe

As pointed out by Witold, FragPipe configuration file contains all necessary information. (MsFragger .params is derived from .workflow file)

Can I have your parameter file @brvpuyve for testing. Did you already submit your dataset? otherwise I could it for testing.

Hi @enryH,
When I tried to submit the MSFragger output it was using the public server. I think my submission was not accepted yet, since I do not see any MSFragger output.
The worfklow file: fragpipe.zip
Please let me know if you need support!


Add more events to be handle on d3-network components

New events handled:
sim-start
sim-tick
sim-end
mouse-enter-node
mouse-leave-node
mouse-enter-link
mouse-leave-link

First, thanks for contribute to this project.
Your pull request introduces two modifications:

Adds ids to svg nodes
Add events to svg nodes and simulation

The addition of ids is unnecesary, you can add ids on _svgAttrs object.
For example:
data () {
    return {
      nodes: [
        { id: 1, name: 'my node 1',_svgAttrs:{ id:'node-1' } },

.....
Or using custom node formatter:
  formatNode(node){
    let svgAttrs = node._svgAttrs || {}
    if(!svgAttrs.id) svgAttrs.id = 'node-'+ node.id
    node._svgAttrs = svgAttrs
    return node
  }

About events: I didn't have time to analyze this.
I will try to respond soon.

Hi. I agree with you for the id. So I will remove it however I will let the newly handle events. In addition I am looking for a way to add text on links. I will let you know if I succeed :)

Text on links image
It is not the best implementation to add text on links. It would be better to transform orientation. Still working on it.

https://codepen.io/emilio/pen/ZampZb

I don't understand why you removed the sim events. I understand it is now possible for the user to use simCb to add his own event using the callback but it is somehow counter intuitive. Your component should be easy to use and give the developpers features without having him looking at every doc of the internal components you use (in my view).
If tomorrow another lib is used internally to generate the graph, then the developper will have to rewrite his code to support sim-start / sim-end and sim-tick events.
Eventually I manage to have labels on the links as you did. I did not look at how you implemented it. I guessed you used the same method as I. However I ve seen another use case that allows developper to have up to 3 labels onto a link.
I think name (for node as well as for link) should be rename into label.
In my solution, link.name can be either a string or an array of length 1, 2 or 3
switch(length)
   case 1:
         label[0] is aligned in the middle
   case 2:
         label[0] is aligned next to the source
         label[1] is aligned next to the target
  case 3:
        label[0] is aligned next to the source
        label[1] is aligned in the middle
        label[2] is aligned next to the target

Let me know what do you think about all of this. Plus it could be great to close the request if you implement everything that is in this request.

I perform a merge and re-compile the files this should be ok. Here is the list of new features:

Handle mouse events (enter/leave node/link)
Handle simulation events
Labeling links (with up to 3 labels)

I have one issue with the canvasRendered where labels are not rendering. I did not investigate on this point since I never worked on the canvasRenderer.

I don't understand why you removed the sim events. I understand it is now possible for the user to use simCb to add his own event using the callback but it is somehow counter intuitive. Your component should be easy to use and give the developpers features without having him looking at every doc of the internal components you use (in my view).

If tomorrow another lib is used internally to generate the graph, then the developper will have to rewrite his code to support sim-start / sim-end and sim-tick events.

I thought that the simCb option open more possibilities for set the simulation.
But I agree with you, about this point.

I have one issue with the canvasRendered where labels are not rendering. I did not investigate on this point since I never worked on the canvasRenderer.

The link labels does not work on canvas yet.
In canvas is not possible align text to path, I need find a solution to this.

@vibou In the future, please, separate your pull request by features

Great. Yeah next feature I ll do another branch. Thanks for your lib which is great ! :P


Fix GFF3 parser to handle trailing FASTA

The GFF3 spec allows trailing FASTA sequences to be put into GFF3 files with a ##FASTA line preceding them. ADAM's GFF3 parser should either stop parsing the GFF3 file if the ##FASTA line is encountered, or possibly also return a NucleotideFragmentRDD with the parsed FASTA included somehow.

Hello @benwbooth!
Yes, loadFeatures should not choke on a GFF3 file if it contains FASTA sequences.  We don't really have any methods in our API that return more than one GenomicDataset types from the same file, so we'd probably want to add GFF3 support to loadSequences.  Let me know what you think.

That seems sensible. Thanks!


Get-NixMount does not display correct

Get-NixMount returns two empty properties:  TargetPath and SourceName.
Get-NixMount | Select * reveals that these should be MountPoint and Device (respectively)

Fixed


begin work on ratifyOrder contract order follow-up call

Remaining work:

basic order support
reference contracts
tests inc. statefulness, validity of arguments, and post-execution status
optimization

Codecov Report
Base: 99.90% // Head: 99.35% // Decreases project coverage by -0.54% :warning:

Coverage data is based on head (00cac22) compared to base (5133505).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           1.2-post-execution     #712      +/-   ##
======================================================
- Coverage               99.90%   99.35%   -0.55%
======================================================
  Files                      47       27      -20
  Lines                    2200     1093    -1107
  Branches                  339      159     -180
======================================================
- Hits                     2198     1086    -1112
- Misses                      1        4       +3
- Partials                    1        3       +2

Flag
Coverage Δ

production
99.35% <50.00%> (-0.65%)
:arrow_down:

reference
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

contracts/lib/OrderValidator.sol
100.00% <ø> (ø)

contracts/test/TestInvalidContractOfferer.sol
100.00% <ø> (ø)

contracts/lib/ZoneInteraction.sol
85.41% <50.00%> (-14.59%)
:arrow_down:

reference/conduit/ReferenceConduitController.sol

reference/lib/ReferenceReentrancyGuard.sol

reference/conduit/ReferenceConduit.sol

reference/lib/ReferenceGettersAndDerivers.sol

reference/lib/ReferenceExecutor.sol

reference/lib/ReferenceOrderCombiner.sol

reference/lib/ReferenceBasicOrderFulfiller.sol

... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Release 2.1.0

Release 2.1.0

I'll have a look next week :-)

@emmanuelmathot Sorry, that it took so long. It was on my to-do list for way too long.
I've reviewed several aspects of the file extension again and made a couple of changes in my last commit 2d55b1d. I'll merge this now as I think this is ready to be released, but I think it would be good if you could take another look and once you reviewed again we can release. You can do it yourself or ping me and I'll do it. Thanks.


Adding donate five

We should be able to donate to this awesome project.
This money should go to awesome 5 stickers and other merch.
This PR adds a donate link to the readme.md
How much should people donate? Five of course!

+5

:five:


[Slack Channel] Connector API starts failing after re-adding Slack App with bot user

Connector API started throwing 500 responses after I removed and re-added a Slack App with a BotBuilder bot.

Added a Slack App with a bot user to a team
Exchanged couple of messages with the bot user
Removed Slack App from the team
Re-added the same App again
Now every message to my bot results in Internal Server Errors:
Error: Request to 'https://slack.botframework.com/v3/conversations/B4TGPB3HQ%3AT4Q5YL2H2%3AD4SS5US7K/activities/3b66170a8ebb47ce8b3428d6870e0e60' failed: [500] Internal Server Error at Request._callback (/app/node_modules/botbuilder/lib/bots/ChatConnector.js:452:46)

15 minutes later tried again - no errors this time. ConversationId is the same as in falling messages.
Also I've had a bunch of issues in Slack Channel:
Bot integration B4TGPB3HQ:T4Q5YL2H2 failed to connect to Slack due to invalid credentials and will be disabled. Error: account_inactive
P.S. I've also noticed you now send installationUpdate messages after an App was added to a team, which is great! Any ideas on how to also get an Id of the user who authorized the App?

hi @delight-by - Thank you for reporting this issue in the Connector API.  Can you provide additional details about your issue?
Environment

Operating System:

Windows
macOS
Linux

SDK Platform:

C#/.NET
Node.js

SDK version:
Development environment:

localhost
Azure Web App
Azure Bot Service App
other

If you are using the Node.js SDK:

Node.js version:
NPM version:

Issue
What the issue is, in broad strokes. Link to Stack Overflow post.
Example Code
The code snippet or complete bot example (preferred) that demonstrates the issue.
Steps to Reproduce
Please provide the shortest amount of steps to reproduce your issue.
Expected Behavior
What you expected to happen.
Actual Results
What actually happened. Please give examples and support it with screenshots, copied output or error messages.

I literally have all the information in my first post, with all the ids (just look at those logs). I'll just add that the bot is hosted on Heroku, all versions (node, sdk etc. are latest available).

Also I've had a bunch of issues in Slack Channel: Bot integration B4TGPB3HQ:T4Q5YL2H2 failed to connect to Slack due to invalid credentials and will be disabled. Error: account_inactive

@delight-by based on your error message in Slack, it looks like your bot may have been disabled by Slack themselves.
When you say you "re-added" the app, do you mean that you deleted the Slack Channel configuration from your bot in the Bot Portal? And then you added back the Slack Channel configuration in the Bot Portal?
Or did you mean that you changed some configuration of your Slack Application in the Slack API page which then led to the error? If your error was triggered by configuration settings updated in your Slack Application via the Slack API page, it's possible the error is in the Slack API itself, and not in the Bot Framework or Bot Connector Service.

None of your assumptions are right. You can add a Slack App (with a bot) to a team, and then remove the app (with the bot) from the team. And then repeat. That's what you're doing now and then while testing the Slack channel. I can't describe it any simpler, and that's not connected anyhow with the Bot Framework configuration or Slack App configuration. That's what the end users on Slack channel are able to do any time after you've published your bot.
Str again:

Added a Slack Bot (via Add To Slack button) to a team
Removed that Slack App from the team
Re-added the same bot to the same team again (= goto 1)
After step 2, the bot token you have from Slack gets invalidated hence the errors in Bot Portal, that's expected. What's wrong here is that when I add the bot to the team again (going through the whole OAuth process again) - I start getting errors from the Connector API, despite the fact that you have new valid token at the moment.

the error about Slack API disabling your account
The error has nothing to do with that. It literally says that the credentials (the token you got as a result of OAuth process) got invalidated (due to user removing the app from their team). And that the bot integration (this bot on this team) will be disabled at BotFramework side (due to lack of valid credentials).

@delight-by I followed the same process you described in your last comment with my Slack bot & team but I'm unable to reproduce your error. Everything is working fine when I add the bot to the Slack team using the "Add to Slack" button in the Bot Portal.
Can you link some screen shots of your workflow? Also, when you say you get errors from the Connector API, what are the errors and where do you see these errors. Screenshot?

@nwhitmont I've shown you the stack trace I was getting from BotFramework:
Error: Request to 'https://slack.botframework.com/v3/conversations/B4TGPB3HQ%3AT4Q5YL2H2%3AD4SS5US7K/activities/3b66170a8ebb47ce8b3428d6870e0e60' failed: [500] Internal Server Error at Request._callback (/app/node_modules/botbuilder/lib/bots/ChatConnector.js:452:46)
I didn't dig deeper, and didn't look at the message that your server was probably sending alongside 500 status code, probably I should have to. Nevertheless, to be honest, today I was going through the same process again and didn't catch any errors too. So hopefully the problem has been solved already. I'll post again if it comes back.

@delight-by  thanks for the update! reopen if it comes up again.

Can confirm that this happens to me too. After deleting and re-adding the bot several times, I'm unable to talk to it because of invalid_auth. It seems that the old token must be getting cached on the connector of MSFT side.

Yep, same here. Removed the app for holidays, because it started spamming replies to any message anywhere, now re-added and started getting invalid_auth.

And indeed some time has passed till while I was looking for solution and bot started working again. You're not invalidating some cache actively and we have to wait for it to be invalidated after some time (not sure even how much time).


mark command tests

created mark command tests for correctly marking (no -> yes and yes -> no) as well as correct exceptions thrown (no -> no and yes -> yes)

LGTM


string correction

Link under Overall Workflow reads
see Process flow for creating customer trainable classifiers.
should read
see Process flow for creating custom trainable classifiers.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2f3c5c98-9f47-9512-b932-2f72822796d2
Version Independent ID: fd477cf9-4ee0-544f-10c6-f3dfccb10186
Content: Get started with trainable classifiers - Microsoft Purview
Content Source: microsoft-365/compliance/classifier-get-started-with.md
Service: o365-seccomp
GitHub Login: @chrfox
Microsoft Alias: chrfox

@RAJU2529 Thank you very much for the contribution and updating the documentation with PR. @quickclix75 Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Several warnings about uninitialized variables in FindNanopb.cmake

When using --warn-uninitialized in a project using cmake with Nanopb, many warnings from inside extra/FindNanopb.cmake arise, e.g.:
CMake Warning (dev) at externals/nanopb/external/extra/FindNanopb.cmake:342 (find_program):
  uninitialized variable 'PROTOBUF_SRC_ROOT_FOLDER'
Call Stack (most recent call first):
  externals/nanopb/CMakeLists.txt:27 (find_package)

and:
CMake Warning (dev) at externals/nanopb/external/extra/FindNanopb.cmake:275 (add_custom_command):
  uninitialized variable 'NANOPB_DEPENDS'
Call Stack (most recent call first):
  proto/CMakeLists.txt:8 (nanopb_generate_cpp)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at externals/nanopb/external/extra/FindNanopb.cmake:292 (set):
  uninitialized variable 'NANOPB_SRCS'
Call Stack (most recent call first):
  proto/CMakeLists.txt:8 (nanopb_generate_cpp)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at externals/nanopb/external/extra/FindNanopb.cmake:293 (set):
  uninitialized variable 'NANOPB_HDRS'
Call Stack (most recent call first):
  proto/CMakeLists.txt:8 (nanopb_generate_cpp)

I tried adding e.g.
if(NOT DEFINED NANOPB_DEPENDS)
set(NANOPB_DEPENDS )
endif()

But I was not able to get everything away, and there might be better ways to solve the underlying problem.

Thanx for filing @kalj

Note about reproducing this problem: cmake --warn-uninitialized only warns about files that are under the project root folder. To test this with e.g. examples/cmake_simple, --check-system-vars has to be given also.


Incrementally parse documents

At the very least we can incrementally update the token list without re-parsing the entire doc.
Whether this speedup is worth it, idk. We could bring in my ltreesitter module to do this, but then theres the issue of translating the cst that tree-sitter generates to an ast that tl understands, which might not be worth it.
We could get a real speedup if we could figure out a way to incrementally update the type checking environment instead of regenerating it each time

With neovim master being able to get incremental updates I will try to implement this soon


PushNotification.init causes tap/scroll problems on Android 13 device/phone

Bug Report
On my android 13 phone, my cordova 12 android app built with ionic appflow has a problem where none of the textboxes or buttons are clickable/tappable after calling:
var push = PushNotification.init({
    android: {
        senderID: googleProjectID
    }
});

The only way I'm able to tap/click buttons, enter a textbox to start typing, or scroll by swiping is by quickly double-tapping the button or textbox, or double-swiping the screen to scroll.  I've discovered that if I go into the app's settings on the phone and grant the Push Notification permission, then everything works fine, and I can single-tap/swipe everything as expected.  Removing the permission once again forces everything to require double-tapping/swiping.
After a lot of trial and error, I've narrowed it down to this call to PushNotification.init.  If I comment out that line, single-tap/swipe works without issue, regardless of the Push Notification permission being granted or not.  Uncommenting that line results in double-tapping/clicking being required until the Push Notification permission is granted.
Please note, that the iOS version of my app does NOT have this issue and works perfectly.
Expected Behaviour
I'd expect no impact on single-click/tap or scrolling behavior of app.
Actual Behaviour
When Push Notification permission has not been granted, PushNotification.init causes single-tap/click on Android 13 phone to no longer work.  Also, scrolling by swiping up or down requires double-swiping.
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 13
Using the following Ionic AppFlow "Linux - 2023.10" Build stack:
Cordova CLI 12.0.0
Ionic CLI 7.1.1
Node.js 18.18.2 / 20.9.0
npm 10.1.1
Yarn 1.22.19
Debian 11.6
Gradle 8.4
OpenJDK 1.8.0_332 / 11.0.18 / 17.0.6
Android SDK 27-34

With the following preferences
<preference name="android-minSdkVersion" value="24" />
<preference name="android-targetSdkVersion" value="33" />
<preference name="android-compileSdkVersion" value="33" />

(Android) Device Vendor (e.g. Samsung, HTC, Sony...)
Android Moto G Play (XT2413V) phone

Oops, this was my bad, sorry!  After a ton of trial and error, I finally found the problem was due to my config.xml file having an incorrect android-targetSdkVersion that targeted version 31:
<preference name="android-targetSdkVersion" value="31" />

I had the correct preference further down in the config.xml
<preference name="android-targetSdkVersion" value="33" />

After removing the preference for targetSdkVersion = 31, it all works fine.

is this working on Cordova Android 13.0.0?  I think all new apps need to be using that version since Google Play is now deprecating older versions.


compile failed

/usr/bin/ld: /usr/local/lib/libgflags_nothreads.a(gflags.cc.o): relocation R_X86_64_32 against .bss' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: /usr/local/lib/libgflags_nothreads.a(gflags_reporting.cc.o): relocation R_X86_64_32 against .rodata.str1.8' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: /usr/local/lib/libgflags_nothreads.a(gflags_completions.cc.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
centos gcc 10
gflags 2.2.2
cmake ..
make & make install
glog 0.7.1
cmake ..
make & make install

Please use the search: this gflags issue has been discussed many times before.


Document where templates/mappings.yml comes from

With a fresh (local) clone of this repo, $ yarn install && yarn generate will produce an invalid template as it's missing the AWSRegion2AMI mapping as referenced in the templates/buildkite-elastic.yml template:
https://github.com/buildkite/elastic-ci-stack-for-aws/blob/63a1fb0e1b3b00933becd5ad7f9a8a7d91780e9b/templates/buildkite-elastic.yml#L502
I've noticed there's some (missing) phony rules in Make that look like they'd download this:
https://github.com/buildkite/elastic-ci-stack-for-aws/blob/63a1fb0e1b3b00933becd5ad7f9a8a7d91780e9b/Makefile#L1
And the Buildkite tests generate a version of this file in CI:
https://github.com/buildkite/elastic-ci-stack-for-aws/blob/63a1fb0e1b3b00933becd5ad7f9a8a7d91780e9b/.buildkite/steps/test.sh#L73-L77
https://github.com/buildkite/elastic-ci-stack-for-aws/blob/63a1fb0e1b3b00933becd5ad7f9a8a7d91780e9b/.buildkite/steps/publish.sh#L132
Is there something I'm missing? make update-stack references the phony download-mappings dependency but it does nothing.

Thanks, no you aren't missing anything, I think we broke this with a change at some point. I will investigate.

This is fixed in master.


https is rewritten to http

The form for editing a race (at race_edit.php) saves an https URL as http://.... All our links to https://is.orienteering.sk  are broken.
The issue lies in the function cononize_url which has the string http hard-coded, so this can affect code calling cononize_url with $scheme > 0.

The problem should be in cononize_url($odkaz);. The second argument 1 should be added to accept an existing protocol and only add http://... when no other is specified.
$odkaz = cononize_url($odkaz, 1);


Selection doesn't work in the content editable accessible buffer

Set terminal.integrated.accessibleBufferContentEditable: on
focus a terminal
run some commands
Shift+Tab and try to select 🐛

fyi @Tyriar

probably because i'm setting the selection so that the cursor is at the end

The setting of selection is just the initial state to position the cursor though, you should still be able to use shift+arrow to select something different/

Cmd+A doesn't select all for me but I can use cmd+A 🤔

cmd+a is likely running the select all in terminal command, you could check if the accessible buffer is up and select all in that instead (or not run the command and pass the event through?)

Or have a new context key for when it's up?

much clearer to see what's going on when I have an editor open - the terminal (ie terminal text area) is explicitly not focused when the accessible buffer is. the terminal's select all has when: TerminalContextKeys.focus
https://user-images.githubusercontent.com/29464607/218154386-e75318d5-1029-4bb6-aafa-be6c8d2c9071.mov

So seems like yeah new context key


Symbolic Rust EVM

Motivation
Fuzzing is great but it does not cover all potential code paths, it just sprays and prays randomly right now
Solution
Create a Rust Symbolic EVM which we ideally implement the Evm trait for so that it can be used seamlessly in forge.
Other Context
Symbolic evms impls:

https://github.com/palkeo/pakala/blob/fce61037e511321cfd97b8adf88f5d3b74781099/pakala/sm.py
https://github.com/dapphub/dapptools/blob/beaaeb6a6ad1cde22989bd088b10bdd06718b73f/src/hevm/src/EVM/Symbolic.hs
https://github.com/ConsenSys/mythril/tree/2518cc8b656bb0d21a80058c3f7f1def13da8db7/mythril/laser/ethereum
https://github.com/trailofbits/manticore/blob/b4d129f8b1fd07501ffe096a835366b110470b4d/examples/evm/minimal.py

Blogs

https://fv.ethereum.org/2020/07/28/symbolic-hevm-release/
https://forum.openzeppelin.com/t/symbolic-execution/2158

can get the best of both worlds with symbolic seed fuzzing:

Does anyone have good resources for building a performant symbolic execution engine? I am thinking of giving it a shot, but would like a better grasp of best practices + theory.

let's suppose the SEVM is done, what solver shall we use to exhaust the symbolic states?


Plot of cooloffs per site/agent for the last 24 hours.

As sometimes is difficult to keep track of cooloffs it will be nice to have plots on the request mgr which shows cooloffs per site, per agent in the last 24 hours. Like the ones found here:
https://test-service-cmst1regmgrmonitor.web.cern.ch/test-service-CMST1RegMgrMonitor/cooloff.html

This seems to be interesting, however we do not have plots while the workflow is running. How about the available tables showing cooloff jobs with different exit codes and sites? I believe it's Ok for now :-)
@ticoann what do you think? If that's basically not feasible, then let's close this one.

We have information in wmstats. We can plot it too. But I guess we will close this unless some one screams for it.


Bump time from 0.3.28 to 0.3.29

This should fix the coverage CI.
As the time crate is only a second-level dependency, dependabot did not pick up on this.

Codecov Report

Merging #477 (00b0482) into main (765ed7d) will decrease coverage by 9.32%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   67.47%   58.16%   -9.32%
==========================================
  Files           1       42      +41
  Lines         372     3762    +3390
  Branches       58       58
==========================================
+ Hits          251     2188    +1937
- Misses        121     1574    +1453

Components
Coverage Δ

apel_plugin
67.47% <ø> (ø)

auditor
81.77% <ø> (∅)

slurm_collector
36.52% <ø> (∅)

slurm_epilog_collector
0.00% <ø> (∅)

htcondor_collector
∅ <ø> (∅)

priority_plugin
50.69% <ø> (∅)


Date Difference is not working

When we use the newly added date diff xustom expression, we get an trino error trying to use AT TIME ZONE on a DATE data type which is not supported.
Here is the query sent to trino:
-- Metabase:: userID: 1 queryType: MBQL queryHash: 4243acab790001d0d88dc444c8ae5a88f665cdd88d1157ea3836b820a8407964

SELECT

    "source"."orderkey" AS "orderkey",

    "source"."custkey" AS "custkey",

    "source"."orderstatus" AS "orderstatus",

    "source"."totalprice" AS "totalprice",

    "source"."orderdate" AS "orderdate",

    "source"."orderpriority" AS "orderpriority",

    "source"."clerk" AS "clerk",

    "source"."shippriority" AS "shippriority",

    "source"."comment" AS "comment",

    "source"."datetimeDiff" AS "datetimeDiff"

FROM

    (

        SELECT

            "sf1"."orders"."orderkey" AS "orderkey",

            "sf1"."orders"."custkey" AS "custkey",

            "sf1"."orders"."orderstatus" AS "orderstatus",

            "sf1"."orders"."totalprice" AS "totalprice",

            "sf1"."orders"."orderdate" AS "orderdate",

            "sf1"."orders"."orderpriority" AS "orderpriority",

            "sf1"."orders"."clerk" AS "clerk",

            "sf1"."orders"."shippriority" AS "shippriority",

            "sf1"."orders"."comment" AS "comment",

            date_diff(

                'day',

                date("sf1"."orders"."orderdate" AT TIME ZONE 'GMT'),

                date("sf1"."orders"."orderdate" AT TIME ZONE 'GMT')

            ) AS "datetimeDiff"

        FROM

            "sf1"."orders"

    ) "source"

LIMIT

    2000

"sf1"."orders"."orderdate" is a date type
error
io.trino.spi.TrinoException: line 1:809: Type of value must be a time or timestamp with or without time zone (actual varchar(20))
	at io.trino.sql.analyzer.SemanticExceptions.semanticException(SemanticExceptions.java:48)
	at io.trino.sql.analyzer.SemanticExceptions.semanticException(SemanticExceptions.java:43)
	at io.trino.sql.analyzer.ExpressionAnalyzer$Visitor.visitAtTimeZone(ExpressionAnalyzer.java:1968)
	at io.trino.sql.analyzer.ExpressionAnalyzer$Visitor.visitAtTimeZone(ExpressionAnalyzer.java:581)
	at io.trino.sql.tree.AtTimeZone.accept(AtTimeZone.java:62)
	...

I think we can drop the casting here
See Trino's date interval functions: https://trino.io/docs/current/functions/datetime.html#interval-functions
Valid queries in Trino:
SELECT date_diff('hour', DATE '2020-02-29', TIMESTAMP '2020-03-01 02:00');

SELECT date_diff('hour', TIMESTAMP '2020-03-01', TIMESTAMP '2020-03-01 02:00');

SELECT date_diff('day', DATE '2020-02-29', DATE '2020-03-01');

Success Criteria

A new unit test is added to capture this issue for date
Tests pass and manually testing passes as well.

This change solves the issue, but metabase tests start to fail
https://github.com/starburstdata/metabase-driver/commit/1c6c958717c046a37ea66d2ba9c236574b8d1454

New custom expression operation here: https://www.metabase.com/docs/latest/questions/query-builder/expressions/datetimediff
This seems to have only been tested with timestamp, but will fail with trino's date types.
When working off main, you can reproduce the issue with: tpch/sf1/orders , using the orderDate field.


Refactored scaffolding. Add checkbox to disable ansii converting.

Fixes bug where ansi formatting triggered browser memory leak.
Refactor workflow of js development.
Update makefile to account for clientside asset generation.

Awesome! A proper JS scaffolding always is welcome.


Review section 4.3 and 4.3.1 Overview on Governance Aspects

The section explains the relation of the Governance aspects to the layers of the RAM.
This section should be reviewed.

Closed by #193


Not really an issue, Markers possible?

Hey love your mapper, in my opinion it is the best for MCBE.
My Questions is above. Is it possible to add markers? Or is something like that planned?
and does the isometric perspective is still in development?
Greetings

I'll work on this, in case anyone else started looking into it

I'd be interested in seeing markers added as well. I'm not thinking of player markers though, more like annotations to the map, eg for adding place names etc. Am I right in thinking this uses Leaflet to display the map? If so, I understand that has functionality for markers and also lines/shapes etc - I don't know if that could be utilised? It would also be useful for doing things like circling areas of interest or highlighting railways etc. These could be described in a separate "annotations" file which could be passed in as a new parameter


Data parent directory

This PR adds the parent directory argument to every File constructor. This allows one to use the data.dir system property to specify the location of the samples-data folder. This is useful for when you want to run a jar version of the sample from a directory which does not contain the samples-data folder.

@JonLavi canonicalPath isn't needed. It just fixes relative paths so you have "git/myProject/samples-data/something" instead of "git/myProject/./samples-data/something". I was using it to check if the relative path was causing a problem. I've removed use of it for now.


Start offset not working

Hi @cladera
I think this demo (http://cladera.github.io/videojs-offset/) is do not jump to the fifth second accordance with the example code :
var player = videojs('video_example', {
		plugins: {
			offset: {
				start: 5,
				end: 40
			}
		}
	});

Can you help me, since I experienced the same problem. Thanks

Hi @Blacx ,
It does jump to fifth second but videojs-offset shows relative time. The actual duration of the demo's video (http://video-js.zencoder.com/oceans-clip.mp) is 46 seconds, but I'm showing just 35 seconds of that video starting at 00:00:05 and finishing at 00:00:40. Take a look at the duration of the "cut" video, you should see 35 seconds.
Please, let me know if the plugin doesn't behave like I've explained.

Hi @cladera
Thank you for your fast response. Finally I understand.
Demo showing the duration of 35 seconds after the offset applied in the initial 5 seconds and 6 seconds to cut back because of the overall duration of the video is 46 seconds.

Anytime! ;)


arch/arm/src/stm32h7/stm32_usbhost.c: Fix nxstyle errors

Summary
error: Long line found
Impact
none
Testing

@simbit18
Are you aware that the initial comment line sets the the "Ruler" and then lines can be longer?
This change makes the file less readable. I would not support merging it.

@simbit18
Are you aware that the initial comment line sets the the "Ruler" and then lines can be longer?
Yes

Hi @davids5,
I just changed it this way to keep it consistent with the approach already established in other files.
https://github.com/apache/nuttx/blob/master/arch/arm/src/efm32/efm32_usbhost.c
https://github.com/apache/nuttx/blob/master/arch/arm/src/imxrt/imxrt_ehci.c
https://github.com/apache/nuttx/blob/master/arch/arm/src/kinetis/kinetis_usbhshost.c


Missing architectural diagram

The link is in the readme.md but there is no value for it.

Thanks for the issue, I've just added the diagram in.


Publishing metrics with Spectator

Hello, I am trying to use Spectator to publish metrics. I followed the instructions on this page: https://netflix.github.io/conductor/metrics/server/, but I'm not sure if it worked or if I have everything that is needed. How can I tell if metrics were published, or where can I check?

@nikijain17 If you're just trying to verify that metrics are being published, you can push them to Log4j as suggested here: https://netflix.github.io/conductor/metrics/server/#collecting-metrics. On top of that, configuring the metrics server, for eg., Atlas, Prometheus etc. is really an implementation detail fo that metrics server.

Is there another way to view the metrics without using Log4j? I thought it was optional

I added the additional modules in config.properties. It says the metrics will be printed to the console, but I don't see anything different. Is there a way to check if it worked?

@nikijain17 Not sure if something is still missing. You can check with Spectator folks at https://github.com/Netflix/spectator, who can better help with this.
Please feel free to reopen if you have further questions setting this up in Conductor.


Add support for using engine-backed keys in spkac(1ssl)

This allows for the usage of a key made available via an OpenSSL engine, such as OpenSC, for generating SPKAC attestations.
Tested using OpenSC and a YubiKey IV.
Checklist

[x] documentation is added or updated

You do know that you also made DER a possible choice, right?  I'd like to see the docs reflect that as well.

@levitte Updated.
The documentation is pretty inconsistent about that elsewhere keyform or similar is used… I'll open a task to clean it up.

pushed to master, as listed in the commit above.  thank you!


JAVA Popular Interview Questions

Hi! I have read the contribution guidelines.
I think that most of the questions here focus completely on DSA. For complete overall preparation, however, it would be good to add the top interview questions in Java language.
These will be quality-based and handpicked questions.
I can help with the same. Please assign this issue to me.

I had practiced its questions. I want to work on this issue. Please assign to me.

Raise separate issues.


cpr dependency not building on Windows MSVS 2015

conan install . --install-folder C:/Users/xxxx/github/cpplot/build/release
Configuration:
[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=Visual Studio
compiler.runtime=MD
compiler.version=14
os=Windows
os_build=Windows
[options]
[build_requires]
[env]
ERROR: cpr/1.5.0: Error in configure() method, line 39
if self.options["libcurl"].with_openssl == False:  # 'is False' doesn't work here (see conan-io/conan#3620)
ConanException: option 'with_openssl' doesn't exist
Possible options are []
I was using the conan-center as my remote.

OK. So, the cpr library isn't presently used. It's there in the build system from when I was messing with plotly online (it's used in online.h to post figures to plotly online.
I'd like to come back to whether an online feature should be kept - so cross-referencing #10 as some discussion should be made.
However, in the meantime at least, I'm quite happy with removing the cpr dependency because I don't think it's actually linked anywhere.
Give me half an hour.

OK. 36 minutes. Give that a try @ShamanTcler

Update I switched to using conan-cmake (https://github.com/conan-io/cmake-conan) in the CMakelists.txt file and then gave it:
conan_cmake_run(
REQUIRES
eigen/3.3.7
nlohmann_json/3.8.0
boost/1.73.0
glog/0.4.0
gtest/1.10.0
tbb/2020.1
IMPORTS
${CONANIMPORTS}
BASIC_SETUP
CMAKE_TARGETS
)
And it compiled but did not link.
The switch to using conan-cmake was because it gets rid of the install issue... though you do need to have a conan.cmake file...

Have you still got the same problem of not linking against cpr? or is it a new problem?